Figma "In the File" prep

Figma has asked us to hold a one hour session for "In the File". Mickey and Lucas will do this, Rebecca to help.
We need to estimate the prep time and come back to Figma with a date.

Should put this back to the backlog @BeckyBrekke ? We got our hands full till Christmas... 🙈


Exception thrown, causing crash.

Hello, I have encountered an error between Materialis and Tinkers' Evolution (https://www.curseforge.com/minecraft/mc-mods/tinkers-evolution).
During startup your mod attempts to register tin to Tinkers and throws an exception because Tcon Evolution has already registered it.
Installed Mods:
Tinkers' Construct.
Mantle.
Materialis.
Tinkers' Evolution.
Libnine.
BioLib.
Crash Report: https://pastebin.com/mTRwP3Mt
Thanks.

To fix conflicting materials, simply blacklist the conflicting material in the config for one of the mods


[BUG] Sarif format not working

vulnerability-scanning:
    runs-on: ubuntu-latest
    name: Vulnerability Scanning
    needs: [lint, test]
    timeout-minutes: 5
    permissions:
      id-token: write
      contents: write
      actions: read
      issues: write
      pull-requests: write
    steps:
      - name: Code checkout
        uses: actions/checkout@v3

      - name: Run Trivy vulnerability scanner
        uses<EMAIL_ADDRESS>        with:
          scan-type: 'config'
          scan-ref: ./
          exit-code: '0'
          ignore-unfixed: true
          severity: 'CRITICAL,HIGH'
          format: 'sarif'
          output: 'trivy-config-scan.sarif'

      - uses: actions/upload-artifact@v3
        with:
          name: trivy-config-scan.sarif
          path: trivy-config-scan.sarif

      - uses: reviewdog/action-setup@v1
        with:
          reviewdog_version: v0.15.0

      - name: Run reviewdog
        env:
          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
          echo -n "$(cat trivy-config-scan.sarif)" | reviewdog -reporter=github-pr-review -f=sarif -level=info -diff="git diff FETCH_HEAD"

The command echo -n "$(cat trivy-config-scan.sarif)" | reviewdog -reporter=github-pr-review -f=sarif -level=info -diff="git diff FETCH_HEAD"
Doesn't produce anything, or even any log.

{
    "id": "DS002",
    "name": "Misconfiguration",
    "shortDescription": {
      "text": "Image user should not be \u0026#39;root\u0026#39;"
    },
    "fullDescription": {
      "text": "Running containers with \u0026#39;root\u0026#39; user can lead to a container escape situation. It is a best practice to run containers as non-root users, which can be done by adding a \u0026#39;USER\u0026#39; statement to the Dockerfile."
    },
    "defaultConfiguration": {
      "level": "error"
    },
    "helpUri": "https://avd.aquasec.com/misconfig/ds002",
    "help": {
      "text": "Misconfiguration DS002\nType: Dockerfile Security Check\nSeverity: HIGH\nCheck: Image user should not be 'root'\nMessage: Specify at least 1 USER command in Dockerfile with non-root user as argument\nLink: [DS002](https://avd.aquasec.com/misconfig/ds002)\nRunning containers with 'root' user can lead to a container escape situation. It is a best practice to run containers as non-root users, which can be done by adding a 'USER' statement to the Dockerfile.",
      "markdown": "**Misconfiguration DS002**\n| Type | Severity | Check | Message | Link |\n| --- | --- | --- | --- | --- |\n|Dockerfile Security Check|HIGH|Image user should not be 'root'|Specify at least 1 USER command in Dockerfile with non-root user as argument|[DS002](https://avd.aquasec.com/misconfig/ds002)|\n\nRunning containers with 'root' user can lead to a container escape situation. It is a best practice to run containers as non-root users, which can be done by adding a 'USER' statement to the Dockerfile."
    },
    "properties": {
      "precision": "very-high",
      "security-severity": "8.0",
      "tags": [
        "misconfiguration",
        "security",
        "HIGH"
      ]
    }
  }

There seems to be a problem with JSON Decoder on DS002\nType: the /n is not valid and it's breaking the decoder.

ref: https://github.com/aquasecurity/trivy/discussions/5559

I've tested with a valid sarif file, still doesn't produce anything.

Command:
echo -n "$(cat ./trivy-config-terraform-module-scan.sarif)" | reviewdog -f=sarif -diff="git diff FETCH_HEAD"
no output produced

Note:
Trivy SARIF sample
https://github.com/aquasecurity/trivy-sarif-demo/blob/d1968305c1133a0efd42bde85cd3bbefa68aa960/debug-trivy-results.sarif

I have tested with an Trivy SARIF result https://github.com/aquasecurity/trivy-sarif-demo/blob/d1968305c1133a0efd42bde85cd3bbefa68aa960/debug-trivy-results.sarif, and fix it by PR #1653.

Great!!!

Any ETA on when #1653 might be available in a new release?

I just released the new version.


Fix airbyte loader

Fix airbyte loader
https://github.com/langchain-ai/langchain/issues/8996

@hinthornw maybe, there might be another reason this failed... in principle we should be able to catch this using unit tests if the python path is configured correctly and things are imported into the all namespaces correctly


Unusual size of the package

For what the this library does it seems like the import size is too large. Is it intended?

It's because of the libraries' dependencies.
You are probably using<EMAIL_ADDRESS>which would resolve to 16.4.2 at the moment,
while this project is using exactly<EMAIL_ADDRESS>.
So you end up with 2 react versions packaged in your bundle.
  "dependencies": {
    "core-js": "2.5.5",
    "lodash": "4.17.5",
    "prop-types": "15.6.1",
    "react": "16.4.1",
    "react-dnd": "3.0.2",
    "react-dnd-html5-backend": "3.0.2",
    "react-dom": "16.4.1"
  },


Monthly Chat Agendas April (2021-04-05 and 2021-04-19) Meeting Agenda

This is the Agenda for the Monthly CRS Chats.
The general chat is going to happen on https://owasp.slack.com in the channel #coreruleset on Monday, April 5, at 20:30 CET. That's the 1st Monday of the month. A separate issue chat is happening at the same location, same time on Monday, April 19. That's the 3rd Monday of the month.
Items on the Agenda:  (see previous meetings decisions: here)
What happend in the meantime since the chat last month
Outside development

@airween has identified a bug with file uploads in ModSec: modsec-nginx bug report 244

PRs that have been merged since the last meeting

#1868: Migrate PR: RE2 compatibility for 920120
#1934: feat(ci): upgrades ci to run tests using python 3
#1988: Documentation: Enhancement of installation process for Nginx / IIS
#2000: Try to fix 933210 bypass at PL1, lowering FPs
#2004: wrong version in requirements file
#2012: Fix False Positive in rule 932115
#2013: Move rule 920300 from PL2 to PL3
#2016: 930110: make bare '..' without (back)slashes not trigger
#2020: Request header Sec-Fetch-User: Allow only booleans
#2021: Added regression tests for 920275
#2022: Whitelist for YAM package manager
#2023: Fix PL typo
#2024: Adding new crawler, fixing alphabetical ordering
#2028: Fix Sec-CH-UA and Sec-CH-UA-Mobile request header validation
#2029: fix(test): verify that test encoded works in py2 also
#2032: Update REQUEST-932-APPLICATION-ATTACK-RCE.conf
#2033: 933210: check for spaces before ';' character
#2036: fix(compose): setting LOGLEVEL so nginx logs to error log properly
#2039: Add AnonymousFox PHP webshell
#2045: add httpx to scanners-user-agents

We merged 20 PRs since the last monthly project chat.
Open PRs

#1975: Nextcloud 20 false-positives
#1986: Anti-virus support without need to run external programs
#2035: Fix FP in 942230 with case
#2037: Example exclusion rule: monitoring agents exceptions
#2038: Includes for plugins
#2048: Block zerodium PHP backdoor: restricted header user-agentt
#2049: Override modsec rule 200001

Open PRs marked work in progress / needs action

#1958: Fix for issue #1922
#1993: Draft: Plugins support + response body decompress plugin
#2014: Move 941310 from PL1 to PL2
#2050: fix ReDoS on 941140
#2052: 932200 Linux RCE evasion with (more) uninitialized bash parameters

Other items

Getting ready for the dev-on-duty endeavour (every week, there is another dev on duty as first responder for new issues and requests)

Who is participating?
What are the rules?

Idea: 1 week CRS developer summit in 2nd half of October. Who would take part if we pay all your expenses, trip, accomodation, food and drinks.

Open Issues - Separate Issues Meeting (Monday, FIXME)
We generally cover 10 issues per month in a separate issue meeting. Add them as you see fit.

Issue slot 1: #1234
Issue slot 2:
Issue slot 3:
Issue slot 4:
Issue slot 5:
Issue slot 6:
Issue slot 7:
Issue slot 8:
Issue slot 9:
Issue slot 10:

How to get to our slack and join the meeting?
If you are not yet on the OWASP Slack, here is your invite: https://owasp-slack.herokuapp.com/ .
Everybody is welcome to join our community chat.

Decisions
PRs

Other items
Open Issues - Separate Issues Meeting (Monday, April 19th)

Issue slot 1:
Issue slot 2:
Issue slot 3:
Issue slot 4:
Issue slot 5:
Issue slot 6:
Issue slot 7:
Issue slot 8:
Issue slot 9:
Issue slot 10:


4.2.0/4.2.1/4.2.2.edge breaks InAppBrowser Window on Android with Platform WebView

A similar issue to https://github.com/AppGyver/steroids/issues/1082 occurs when using the Platform WebView:
Its simply reproduceable by calling open(url, "_blank", ...) on InAppBrowser Plugin.
The application will crash on the native side with the following Exception:

01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime: java.lang.ClassCastException: android.webkit.WebView cannot be cast to org.apache.cordova.CordovaWebViewInterface
01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime:     at org.apache.cordova.inappbrowser.InAppBrowser.openUrl(InAppBrowser.java:486)
01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime:     at org.apache.cordova.inappbrowser.InAppBrowser.access$1100(InAppBrowser.java:76)
01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime:     at org.apache.cordova.inappbrowser.InAppBrowser$6.run(InAppBrowser.java:702)
01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime:     at android.app.Activity.runOnUiThread(Activity.java:5524)
01-08 19:37:12.628 11349-11349/com.opaygo.guest.scanner E/AndroidRuntime:     at org.apache.cordova.inappbrowser.InAppBrowser.showWebPage(InAppBrowser.java:740)

+1

Thanks for reporting, we'll look into this!

You can try using "_system" instead of "_blank", see whether it helps.

This is still a major issue, any updates @harsaharsa ? Thanks

Any Updates/Timeline here ?

+1

As there is no progress on this, i decided to try a workaround / hack
Therefore I forked the original InAppBrowser Plugin from Apache Cordova. To prevent conflicts with the appgyver InAppBrowser I had to rename a lot of stuff. However I could manage to add this plugin to the Appgyver Android Cloud Build, and could use it successfully.
Opening a Browser Window with _blank works now even with Platform Web View.
This is really just a hack I did not test it extensively. Also I might have broken the other Platforms  Versions so only build it for android. Not sure why appgyver initially developed an own fork of InAppBrowser, probably my fork has problems when using inside multiple views in parallel.
Also I had to comment out some code related to Basic Authentication, so sites with Basic Authentication might also fail.
It is available in the Controllers at cordova.InAppBrowserOrig and also the window.open method will execute the new plugin.
Find it at https://github.com/stephan-klein/cordova-plugin-inappbrowser

so good!


Update concepts-extensions.md

The correct version for Orafce is 3.18 and not 3.1.8
cc: @sunilagarwal

@sunilagarwal
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


android.app.Application cannot be cast to org.kodein.di.KodeinAware

I get the following error when the app starts, I've tried to trace it but to no avail
2020-02-17 12:22:18.289 16962-16962/ga.forntoh.bableschool E/AndroidRuntime: FATAL EXCEPTION: main
    Process: ga.forntoh.bableschool, PID: 16962
    java.lang.RuntimeException: Unable to start activity ComponentInfo{ga.forntoh.bableschool/ga.forntoh.bableschool.ui.category.CategoriesActivity}: java.lang.ClassCastException: android.app.Application cannot be cast to org.kodein.di.KodeinAware
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3114)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3257)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1948)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7050)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
     Caused by: java.lang.ClassCastException: android.app.Application cannot be cast to org.kodein.di.KodeinAware
        at org.kodein.di.android.ClosestKt.kodein(closest.kt:25)
        at org.kodein.di.android.ClosestKt.access$kodein(closest.kt:1)
        at org.kodein.di.android.ContextKodeinPropertyDelegateProvider$provideDelegate$1.invoke(closest.kt:39)
        at org.kodein.di.android.ContextKodeinPropertyDelegateProvider$provideDelegate$1.invoke(closest.kt:38)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at ga.forntoh.bableschool.ui.base.BaseActivity.getKodein(Unknown Source:7)
        at org.kodein.di.KodeinAwareKt$Instance$1.invoke(KodeinAware.kt:176)
        at org.kodein.di.KodeinAwareKt$Instance$1.invoke(Unknown Source:4)
        at org.kodein.di.KodeinProperty$provideDelegate$1.invoke(properties.kt:42)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at ga.forntoh.bableschool.ui.base.BaseActivity.getViewModelFactory(Unknown Source:7)
        at ga.forntoh.bableschool.ui.base.BaseActivity.onCreate(BaseActivity.kt:38)
        at ga.forntoh.bableschool.ui.category.CategoriesActivity.onCreate(CategoriesActivity.kt:34)
        at android.app.Activity.performCreate(Activity.java:7327)
        at android.app.Activity.performCreate(Activity.java:7318)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3094)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3257)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1948)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7050)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

Gradle
implementation "org.kodein.di:kodein-di-generic-jvm:6.5.0"
implementation "org.kodein.di:kodein-di-framework-android-x:6.5.0"

Application
class App : MultiDexApplication(), KodeinAware {

    override val kodein by Kodein.lazy {
        import(androidXModule(this@App))
        ...

Manifest
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    package="ga.forntoh.bableschool">

    ...

    <application
        android:name=".App"
        ...

Activity
open class BaseActivity : ScopedActivity(), KodeinAware {

    override val kodein by closestKodein()

    private val viewModelFactory: ProfileViewModelFactory by instance()

    ...

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        viewModel = ViewModelProvider(this, viewModelFactory).get(ProfileViewModel::class.java)

        ...

    }

    ...

Hi,
My guess would be that when you are using the function closestKodein(), Kodein-DI finds the applicationContext from the android.app.Application, but for some reason this context cannot be cast to KodeinAware.
Is your Application extending android.app.Application somehow?
If not you should consider it, and then declare your bindings in it.

Hi,
My guess would be that when you are using the function closestKodein(), Kodein-DI finds the applicationContext from the android.app.Application, but for some reason, this context cannot be cast to KodeinAware.
Is your Application extending android.app.Application somehow?
If not you should consider it, and then declare your bindings in it.

My application extends MultiDexApplication and implements Kodeinaware
MultidexApplication inturn extends android.app.Application

Maybe you could try to force the App class to be use as the application context.
override val kodein by lazy { (applicationContext as App).kodein }

Maybe you could try to force the App class to be used as the application context.
override val kodein by lazy { (applicationContext as App).kodein }

I tried that too, but still not working 😞.

Do you have a reproducible case / repo that I could try ?

Maybe you could try to force the App class to be used as the application context.
override val kodein by lazy { (applicationContext as App).kodein }

Oh... What I tried was override val kodein by lazy { (applicationContext as KodeinAware).kodein }
But (applicationContext as App).kodein, works 😊
Question ⬇
Please can you tell me why forcing it works now, because since the debut of the project I have used closestKodein() and it worked, untill now.

It certainly depends on which class you used closestKodein(), as it is an extension function for different UI components. But in the end, the goal is always to find the nearest applicationContext that is carrying a Kodein instance. Maybe this is working somewhere else but in this particular case, it doesn't. I'm not an Android expert, thus I do not know every component and their differences.
Did you have a MultiDexApplication since the beginning?

Did you have a MultiDexApplication since the beginning?

At a certain point, I changed to MultiDexApplication it kept working.


test_sync_query_w_dml has num_dml_affected_rows unset

See: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2753
@tswast Any idea what would cause this "flake" to happen? (Note that the 2.7 system tests in the same build did not have this failure, as well as every other time this test case has run on CI.)

Bah! No clue. I wish we logged the Job ID so that I could pass it on to the backend team to investigate further.

Are the job IDs generated by the client? If yes, they probably match some specific regex with the build ID in it.

They are in this case, but I didn't think to make them match any specific pattern. https://github.com/GoogleCloudPlatform/google-cloud-python/blob/f034c6121dabfb20cb1cf6b6ae6985b236bfef11/bigquery/google/cloud/bigquery/dbapi/cursor.py#L136

Nice find. Is it worth making it possible to pass in a job_id (so the system test callers can use something unique)?

It doesn't fit the DB-API, but yeah I think we need to have some way to introspect.

Another failure: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2825

I'll update those tests to set a job ID prefix so it'll be easier to track down.

Ah, one thing it could be is the load job may not have finished. I'll use our handy new Futures API to wait until they are done before doing the DML query.

The other thing to keep in mind is that I'd very much like to remove the sync query method. Hopefully you got my redesign proposal doc?

I did, but we are in fix-it week so I will not read it until Monday.

Unfortunately the query verb doesn't take a job ID, so we'll only be able to debug half the flakes (DB-API, but not sync query). I'll finish my PR for the DB-API part, though.

Closing, as I haven't seen this flake on the bigquery-b2 branch and https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4245 is now out to merge that to master.


Fail to get the _start function ?

Steps to reproduce
test.txt
There is a _start function in the wat file, but if execute the wat file it didn't find the _start function by itself.
wat2wasm test.wat --enable-alll
wamrc -o test.aot test.wasm
iwasm test.aot
Expected output
0
Actual output
`[21:50:51:552 - 11148EDC0]: Lookup wasi _start function failed: invalid function type.
Exception: lookup the entry point symbol (like _start, main, _main, __main_argc_argv) failed`
But if use iwasm -f _start test.aot, it coulld print the correct result 0.

Hi, currently only _start function with signature "()" (no arguments and not results) is supported, the _start function with return type v128 is not allowed.

Thanks a lot !


Appstudio update test-custom-default-branch-vfuo

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-sorp-on-pull-request-
creating pipelinerun test-simple-build-sorp-on-pull-request- in namespace build-e2e-pmaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-kqtd-on-pull-request-
creating pipelinerun test-simple-build-kqtd-on-pull-request- in namespace build-e2e-pmaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-yvpd-on-pull-request-
creating pipelinerun test-annotations-yvpd-on-pull-request- in namespace build-e2e-pmaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-wyqr-on-pull-request-
creating pipelinerun test-annotations-wyqr-on-pull-request- in namespace build-e2e-pmaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mwia-on-pull-request-
creating pipelinerun test-annotations-mwia-on-pull-request- in namespace build-e2e-pmaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


test: update should usage

These changes are in anticipation of upcoming changes in node v7.0.0.
See: https://github.com/nodejs/node/pull/6102

@mscdex our tests should be updated now to not run into this issue, if it makes it into a Node.js version :) Thanks for the pull request & heads-up!


Usability problem with orientationchange

Hi,
this is a very nice library and I'm (almost) 100% happy with it. Many thanks for your effort!
My only problem is a usability problem with orientationchange on mobile devices.
To have a consistent styling one has to change the size of canvas when user changes the orientation of his device (your demo does it too). Unfortunately that clears whole canvas.
The usability problem I see is, that the person who owns the device hands it to another person to sign something and then the device is handed back its very likely that the orientation will change unintentionally. And thus the signature gets lost .
I think I know why you delete the canvas on resize as you don't want to scale the image, right?
But maybe there is another solution for orientationchange so you don't have to delete the image and preserve it?
Maybe add pixels dynamically when width gets bigger?
This would lead to a square image when starting with portrait format and switching to landscape. So toDataUrl() should return only the image that is visible in current canvas size, so you can always change back to landscape format when an unintentional orientationchange event happened.
Or is something like that maybe already possible with current version?
Thanks for your time.

I have found a solution to handle orientation change or window resize, here is it
https://stackoverflow.com/a/60057521/9277453
Tied with react

Though it doesn't solve all the criteria I have for resizing (because it has to maintain the same aspect ratio the whole time), I made a non-React version of @nikonov91-dev 's solution in the same issue. Look at the "Resize" section at https://stackoverflow.com/a/75261364/14144258.
The code is as follows, though it doesn't have a button to clear the canvas:
<div id="wrapper">
  <canvas id="pad" width="200" height="100"></canvas>
</div>

canvas {
  border: red 1px solid;
}

// Inspiration: https://stackoverflow.com/a/60057521
// Version with no React

const canvas = document.querySelector('#pad');
const signPad = new SignaturePad(canvas);
// Doesn't work without the #wrapper. Probably because #pad
// needs it to be able to be 100% of it. Not sure exactly
// why that makes a difference when #wrapper doesn't have
// a width set on it. Though #pad alone does work after the
// first resize.
let prevWidth = $('#wrapper').width();
let lines = [];

setTimeout(resizeSignatureAndCanvas, 0);
window.addEventListener("resize", () => setTimeout(resizeSignatureAndCanvas, 0));
window.addEventListener("orientationchange", () => setTimeout(resizeSignatureAndCanvas, 0));

function resizeSignatureAndCanvas () {
  // Get the current canvas contents
  lines = signPad.toData();

  // if there are no lines drawn, don't need to scale them
  if ( signPad.isEmpty() ) {
    // Set initial size
    resizeCanvas();
  } else {

    // Calculate new size
    let currentWidth = $('#wrapper').width();
    let scale = currentWidth / prevWidth;
    prevWidth = currentWidth;  // Prepare for next time
    // Scale the contents along with the width
    setRescaledSignature(lines, scale);
    // Match canvas to window size/device change
    resizeCanvas();
    // Load the adjusted canvas contents
    signPad.fromData(lines);
  }
};

// This is really the key to keeping the contents
// inside the canvas. Getting the scale right is important.
function setRescaledSignature (lines, scale) {
  lines.forEach(line => {
    line.points.forEach(point => {
      // Same scale to avoid warping
      point.x *= scale;
      point.y *= scale;
    });
  });
};

function resizeCanvas () {
  /** Have to resize manually to keep the canvas the width of the
  *   window without distorting the location of the "pen". */

  // I'm not completely sure of everything in here
  const canvas = $('#pad')[0];

  // Not sure why we need both styles and props
  canvas.style.width = '100%';
  canvas.style.height = (canvas.offsetWidth / 1.75) + 'px';

  // When zoomed out to less than 100%, for some very strange reason,
  // some browsers report devicePixelRatio as less than 1
  // and only part of the canvas is cleared then.
  let ratio = Math.max(window.devicePixelRatio || 1, 1);
  // This part causes the canvas to be cleared
  canvas.width = canvas.offsetWidth * ratio;
  canvas.height = canvas.offsetHeight * ratio;
  canvas.getContext("2d").scale(ratio, ratio);
};

As you can see from my notes, I'm not completely sure why every part works, but from what I can tell it does preserve the behavior of the version that @Alexey Nikonov made.
Future compatibility could be helped by adding a .scale() to signature_pad itself. If I have time I'll make an issue and a PR.


Does PMMLModel.score() ever return something other than a Double?

It appears that it does, but there is this "out" at the end:
    // Prepare output
    result.get(tname) match {
      case c: Computable => c.getResult.toString.toDouble
      case v => v
    }

What "non-Computable" might be returned? Could we assume it's an error if the first case class fails to match, and through an exception? Doing so would mean that Mode.score could return Double and all the ugly casts to Double everywhere could be removed.

Yes, The model interface is generic and allows to return anything. Implementation is specific for the data and model used.

Makes sense. Should we force the interface to always return Double or Option[Double], if necessary, for this project, to simplify the code that uses it?

I would not do that, not now


Recurring tasks

I'm trying add an event and set it as recurring and as a task, but when I click to save, the event is not a task.
Single events can be tasks no problem.
Not sure this is relevant but I'm on Linux.

Thank you.

+1 to have this feature. To be specific, having the ability to recur tasks and then check them individually would be good (basically like in google calendar).


Add database migration services and projects

Add database migration services and projects:

[ ] azurerm_database_migration_service
[ ] azurerm_database_migration_project

Configuration objects like:
database_migration_services = {
  dmstest = {
    name = "test-dms"
    resource_group_key = "dms"
    region = "region1"
    sku_name = "Standard_1vCores"
    subnet = {
        vnet_key                = "vnet_region1"
        subnet_key              = "example"
        #lz_key (remote landing zone)
        #subnet_id (literals for subnet_it)
    }
  }
}

and
database_migration_service_projects = {
  project1 = {
    name = "toto"
    database_migration_services_key = "dmstest"
...
  }
}

Closing as merged im 5.4.6


Adding connection pool properties

Setting hibernate.dbcp properties for connection pooling. These can be overriden from the persistence.yml if tuning needed.

LGTM


Reduce running time of integration tests for CI

Currently it's not possible to run full integration test suite on GitHub server because of 20 min time limit (actually, 15 minutes for tests themselves without setup).
Some of the integration tests run for 3-4-5 minutes (on my local machine). It's better to somehow reduce their running time.
I attached results of local runs of integration tests. Specifically:

test_api_example
test_multi_modal_example
tests in test/integration/quality

Я так понимаю что в последних PR-ах эта проблема более-менее решена вынесением инт. тестов в отдельную сущность.


Ability to specify containing element of Tooltip

Sometimes you will have a tooltip inside a container that has overflow-hidden. It would be useful to be able to specify the element the tooltip can bind to - like body, so that it can display correctly outside of the element with hidden overflow.

Tooltip can be put anywhere in the document. Use the triggeredBy property to bind it with controlling element.
<body>
<main>
  <Button id="button">Show tooltip</Button>
</main>
<Tooltip triggeredBy="#button">Text</Tooltip>
</body>

Unfortunately that often creates other issues. For example its often required to have the tooltip rendered inside of an if statement or conditional logic, if the tooltip is placed elsewhere it looses its connection to the element that it should be triggeredBy. To work around that you would have to have identical logic in both places. A much better solution would be to include the tooltip in the same logic, so and be able to specify where you want it to render.

OK. Fair enough.
Back to your question, can you please create a REPL with the case causing the issue? I've played a bit with overflow-hidden but I can't reproduce the issue.

@jjagielka can you point me in the correct direction to getting the REPL setup with flowbite svelte? - This is my work in progress, but as you can see the Tooltip will not hide and errors: https://svelte.dev/repl/8a4ce244ffdd4f7a98a2dad5d5e892ad?version=3.59.1

@jjagielka I'm trying to create a REPL for you, but using your template, I get an error rendering the tooltip.
Conceptually though its really simple, a tooltip can't display inside a container if it has overflow:hidden as it can't overflow it. Thats why we need the ability to set the containing element. (Which is already an option in Popper.js so its just a matter of exposing the prop).

(Which is already an option in Popper.js so its just a matter of exposing the prop).

@TristanBrotherton  Which option do you have in mind?

I was incorrect, it was another popper.js that allowed the specification of the HTML element. The one implemented here, from the best of my comprehension does not.  It could be implemented by exposing a prop:
    /**
     * The target element the popper should be appended to.
     * If not provided, the popper is appended to nearest simbling
     *
     * @type {HTMLElement}
     */
    export let target: HTMLElement = document.body;

and in popper:

        onMount(() => {
        if (!target) {
            target = document.body;
        }
        if (target) {
            target.appendChild(ref);
        }
    });

Another issue that makes this even more important is you can't specify a z-index for the tooltip as you are using a 3d transformation already which means the z-index is ignored.
https://stackoverflow.com/questions/5472802/css-z-index-lost-after-webkit-transform-translate3d

I close the issue for now since we have updated API.
Please feel free to open a new issue.
Thank you for your contribution.


Poptorch SDK 3.3 --> Revert changes

Once poptorch SDK 3.3 is released, revert the changes from PR #325 .
@callumm-graphcore, any timeline for the release?

@callumm-graphcore any update on that? Any need to keep the issue open or close it?

Closing since the issue is stalled, and doesn't appear to be important


MRG: fix topo legend placement when show_sensors=1

fixes #4839, see my comments there.

@mmagnuski what's new update?

right, sure - done now.

thx @mmagnuski


Add Variable.debug_print method

Closes #786.
@delta2323  Could you take a look?

@sinhrks I added comments. Could you check them?

Thanks, updated except one point.

@sinhrks  I updated the comment. Could you check it?
https://github.com/pfnet/chainer/pull/830#discussion_r50502613

@delta2323 Updated based on your comments. Pls review.

I updated the comments. Could you check them?

OK, fixed.

Please use quotes consistently, that is, do not mix single quotes or double quotes.
https://www.python.org/dev/peps/pep-0008/#string-quotes

I have added one comment. LGTM if you fix it.

LGTM :+1:

Thank you very much!


⚠ Bofrost.lu has degraded performance

In 07a827a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1473 ms

Resolved: Bofrost.lu performance has improved in b4b2027.


Improve cmake

This PR modifies header files and CMake files to

enable includion of mata without need to include simlib
to create one static library wrapping libmata and all its dependencies
add install to CMake and Make so after make install it it possible to use Mata by adding the following to user's project:

find_library(LIBMATA mata)
target_link_libraries(demo ${LIBMATA})

I have very limited knowledge of CMake so this PR is rather a prototype. I appreciate your feedback about possible improvements.

Well I used the following dummy examples:
#include <mata/nfa.hh>
#include <iostream>

int main() {
  Mata::Nfa::Nfa aut;
  aut.add_state();
  std::cout << "Hello, Mata!" << std::endl;
  return 0;
}

with the following CMake:
cmake_minimum_required(VERSION 3.3)
project(Demo)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")
add_executable(demo demo.cc)
find_library(LIBMATA mata)
target_link_libraries(demo ${LIBMATA})

Maybe, we can create somethin more complex, add it to a special folder and run cmake inside it. However, we need to run make install over mata. I am not sure if github actions allows us to export files to the system folders.

I have a problem with RE2 (missing symbols from RE2 during linking). A working solution for me is to copy libre2.a to the system folder during the installation of mata and then in a testing project simply use find_library(LIBRE2 re2) together with linking ${LIBRE2}.

Perfectly works even in z3.

Great, then if @tfiedor kindly fix the bindings I'will merge it asap.

Great, then if @tfiedor kindly fix the bindings I'will merge it asap.

OMG, ok, will do it, though this change shouldn't have broken it.

Actually, it was needed to move methods related to simulation from nfa.hh to algorithms since we don't want to export include of external library with basic NFA interface.

Great, then if @tfiedor kindly fix the bindings I'will merge it asap.

OMG, ok, will do it, though this change shouldn't have broken it.

It should have. compute_relation() function was moved from nfa.hh to nfa-algorithms.hh. Therefore, we try to bind to undefined method compute_relation() in nfa.hh in Python binding.

Actually, it was needed to move methods related to simulation from nfa.hh to algorithms since we don't want to export include of external library with basic NFA interface.

Yeah, it's OK. Can you please write me where was compute_relation moved? From Nfa:: to Nfa::Algorithms?

Great, then if @tfiedor kindly fix the bindings I'will merge it asap.

OMG, ok, will do it, though this change shouldn't have broken it.

It should have. compute_relation() function was moved from nfa.hh to nfa-algorithms.hh. Therefore, we try to bind to undefined method compute_relation() in nfa.hh in Python binding.

You misunderstood the shouldn't have :-). I meant PR that focuses on improving cmake, should not in ideal world include changes to API. But, Martin explained why it was necessary.

@martinhruska fixed

Great, thank you, I'm gonna merge it.


Uncaught Exception: The Internet connection appears to be offline.: (null)

An uncaught exception was reported.
Info:
OS: darwin
Arch: x64
GPMDP Version: 3.0.0
Time: Tue Mar 08 2016 15:40:08 GMT 0000 (GMT)
Error:
The Internet connection appears to be offline.: (null)
Error: The Internet connection appears to be offline.: (null)
    at Error (native)

This issue was created automatically inside the uncaughtException handler

Client side network issues


⚠ Slack has degraded performance

In a96ee52, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 21 ms

Resolved: Slack performance has improved in 3cde2ff.


Failed to link anything with libgit2 or libcurl in cargo

mold: error: undefined symbol: /private/var/folders/vw/nl1phyz55_q4mkv_qcq___m80000gn/T/cargo-installSM4oZT/release/deps/librustsec-f8494f431867b453.rlib(rustsec-f8494f431867b453.rustsec.769d14926edb1b0f-cgu.15.rcgu.o): _git_remote_fetch

mold: error: undefined symbol: /var/folders/vw/nl1phyz55_q4mkv_qcq___m80000gn/T/cargo-installCtNGpv/release/deps/cargo_install_update-ca4b1b9045c3bdd6.cargo_install_update.36f541b659f3efd3-cgu.11.rcgu.o: _curl_global_init

Could you give me the instructions on how to build libgit2 or libcurl?

For example:
cargo install cargo-update

which has both curl and git2 dependencies.


eth_createAccessList Improvements

Describe the feature
eth_createAccessList is currently susceptible to a race condition if no specific blocknumber is provided:
https://github.com/paradigmxyz/reth/blob/a046288af93ab88d607e963670ac20c4f86c3bde/crates/rpc/rpc/src/eth/api/server.rs#L261-L264
after the create_access_list_at we're still estimating the gas used, at which point the targeted block might be different (for example block mined in between).
Additionally, the subsequent estimate_gas_at can reuse the cached reads of the create_access_list_at.
This will require some API changes, I think this can best be solved by adding a new function for create_access_list_at that takes a callback(Env, DB), similar to the tracing functions:
https://github.com/paradigmxyz/reth/blob/a046288af93ab88d607e963670ac20c4f86c3bde/crates/rpc/rpc/src/eth/api/transactions.rs
Additional context
No response

I can take this

From what I have understood I just need to call estimate_gas_at inside the callback?

exactly, we can also reuse the db's cache

Is the assignee still working on this? Thx

I think this is up for grabs

Hey extremely sorry for the delay.
The PR will be up by tonight.

oh cool, then this still being worked on @supernovahs
no rush though @yash-atreya

Cool . Thanks

PR is up #4954

@mattsse Thank you for merging. Would like to contribute more. I'll be on the lookout for more issues to solve.


Roger > MDC original

hi, I don't like the implemented MDC 1200 function, I would like to restore the original MDC sound, what modification should I make?
Thank you so much for the work you do.

OneOfEleven starts to code with MDC stuff about 3days ago, here you can track down the detail of what he did and reverse it in you code.

MDC is not a cb'ers roger bleep, it's a way of transferring a tiny bit of data during transmission, why the chinese think it's a roger is a bit confusing.


Polifyll wont work on iOS - Reproducible example inside

The polyfill wont work on iOS, the view doesn't get updated while moving the device.
Even after requiring permissions and https on the site, when on the scene, the module tries to get the data from
var rotRate = deviceMotion.rotationRate;
and then:
this.gyroscope.set(rotRate.alpha, rotRate.beta, rotRate.gamma);
And then the console shows hundreds of errors (one per frameloop)
.
I have created a fork (and a PR) on the webxr-samples repo with which has a reproducible demo with the requiring permissions button to easily reproduce this issue on any iOS device:
https://ivnnv.github.io/webxr-samples/
PS: I have tried a workaround bypassing the motion capability detection here:

to attach to deviceorientation instead devicemotion event, but the alpha, beta, gamma values sent to deviceOrientationQ.setFromEulerYXZ doesnt work neither.

webvr-polyfill version: 0.10.11
Browser name/version/release channel: Safari 13.4.1
Operating System: iOS

is there any update on this problem?

This should be fixed now because they updated cardboard-vr-display to 1.0.19.
Btw, you are welcome @jsantell ... It could have been nice to have my fix PRed into the repo instead copy-pasting into your own PR because maybe for you its not important but for a random developer having its PR merged in a international organization repo is something to be prod of.

ok, thanks. If I can ask, how did you request permissions? I follow this https://medium.com/flawless-app-stories/how-to-request-device-motion-and-orientation-permission-in-ios-13-74fc9d6cd140 but it doesn't work.

I also created another PR on the webxr-examples repo that shows how to approach requesting permissions prior to get into vr/xr mode (mandatory for iOS)

@ivnnv unfortunately, merging things outside of Github UI separates committer and authoring in some of its displays, but your contribution is still attributed to you, and you are rightfully in the list of contributors -- contribution credit is absolutely important, so I hope this clarifies things. And thank you!
@GiuseppePennisi with https://github.com/immersive-web/cardboard-vr-display/pull/42 landing, webvr-polyfill 0.10.12 and up should use the latest cardboard-vr-display with the fix. Please reopen if you're still running into any issues


Update 0 10

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
~[ ] Reset the build number to 0 (if the version changed)~
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Second PR for release of xcube-cci 0.10 as first one wasn't deployed onto conda-forge.

@conda-forge-admin, please rerender


iOS 14 EXC_BAD_INSTRUCTION/EXC_BAD_ACCESS with inlineSize on TSpan

Bug
We've created a text box for users that is resizable in our application and it was working well in iOS 13. When we upgraded to iOS 14 we started to get an EXC_BAD_INSTRUCTION or a EXC_BAD_ACCESS when we attempt to resize the box. This problem, from what I've looked at, only happens when the inlineSize attribute on a TSpan element is set.
Environment info
React native info output:
 System:
    OS: macOS 10.15.7
    CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 564.02 MB / 8.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
    Xcode: 12.0.1/12A7300 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_242 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 12.1.0
I've created an example here that can be cloned and ran. There is a black square in the bottom right corner you can use to resize the box. I've run this on an iPad Mini iOS 14.0 simulator to produce this issue.
The crash is on line 203 of RNSVGTSpan.m regardless of which error code we receive.
Please let me know if there is anything else I can provide to try and resolve this.

It doesn't crash if I removed the lines that affect alignment, break modes, and color and let them be default.
    label.attributedText = (__bridge NSAttributedString * _Nullable)(attrString);
    label.baselineAdjustment = UIBaselineAdjustmentNone;
    //label.lineBreakMode = NSLineBreakByWordWrapping;
    label.backgroundColor = UIColor.clearColor;
    //label.textAlignment = NSTextAlignmentRight;
    label.numberOfLines = 0;
    label.opaque = NO;
    label.font = font;
    //label.textColor = [UIColor colorWithCGColor:color];

line 203 in RNSVGTSpan

I think I've narrowed it down further but I'm not certain yet why it does what it does.
I'm looking into the .attributedText value but if I change it out to just .text = (__bridge NSString * _Nullable)(string); I no longer have the issue.

Changing the following fixed the issues in our code base.
On line 202 we switched the .attributedText = (__bridge NSAttributedString * _Nullable)(attrString); to .text = (__bridge NSString * _Nullable)(string);


Change display to be more in line with godot's native display.

WAT looks a bit out-of-the-place at the moment.

Godot's UI is a confusing emotional mess sometimes. This is nowhere necessary so I'm abandoning it.

Significant improvements since this last update so I'm considering this resolved.


on-tasks code

on-tasks code additions. Includes tasks and jobs for create volume,
delete volume, and add hotspare.

Plz have these comments and suggestion fixed,

As the three jobs looks quite similar, is there possible to use only one job and distinguish their logic in JobUtils.RacadmTool? Or maybe we could leverage an existing racadm contorl base task (https://github.com/RackHD/on-tasks/blob/master/lib/task-data/base-tasks/racadm-control-base.js), and only implement corresponding tasks, just like https://github.com/RackHD/on-tasks/blob/master/lib/task-data/tasks/dell-racadm-update-firmware.js? Their actual logic can be added here, just like https://github.com/RackHD/on-tasks/blob/master/lib/utils/job-utils/racadm-tool.js#L222

It would be good to have unit tests

Don't have access to the repo to make these changes, i will do it after merge

Agree with the plan.  We do not have write access to the Longhorn 35 organization and the semester is over.  It is unknown if or when we would gain access.


Service Container -> Binding A Singleton

A clean installation of this repository, but:
.rr.local.yml
  # Workers pool settings.
  pool:
    # How many worker processes will be started. Zero (or nothing) means the number of logical CPUs.
    #
    # Default: 0
    num_workers: 2

MyCounter.php
<?php

namespace App\Singleton;

use Illuminate\Support\Facades\Log;

class MyCounter
{

    protected int $counter=0;

    public function __construct()
    {
        Log::debug('MyCounter __construct');

    }

    public function __destruct ()
    {
        Log::debug('MyCounter __destruct');
    }

    public function increment(): int
    {
         Log::debug('++');
         return ++$this->counter;
    }

}

In AppServiceProvider

    public function register()
    {
        $this->app->singleton('mc', function () {
            return new MyCounter();
        });
    }

In welcome.blade.php
   {{ app()->make('mc')->increment() }}

In the log file each request:
[2022-02-21 06:10:56] local.DEBUG: MyCounter __construct
[2022-02-21 06:10:56] local.DEBUG: ++
[2022-02-21 06:10:56] local.DEBUG: MyCounter __destruct

Obviously, the counter is reset every time.
Why? What am I doing wrong?
What power kills my singleton "mc"?

Greetings again, thanks for your issue!
The singleton will persist during the HTTP request processing and will be re-created for the next request (you can test it with the multiple calling increment() method in your view). Also, you can read this interesting article.
But, if you want to have a "true" singleton - you should make an instance of your container before the requests processing, e.g. put it into the warm section in the configuration file:
diff --git a/config/roadrunner.php b/config/roadrunner.php
index 3ad3f8c..8cc3a88 100644
--- a/config/roadrunner.php
+++ b/config/roadrunner.php
@@ -80,6 +80,7 @@

     'warm' => [
         ...Defaults::servicesToWarm(),
+        'mc',
     ],

     'clear' => [

This issue can be closed?

Thank you for your reply.
No more questions. I'm even a little ashamed that I did not look in the Spiral\RoadRunnerLaravel\Worker.php - all the answers are there.
Thanks for the awesome package.


Support Sequence() features in Croissant crumbs.

WIP: still checking that it works as intended on mlcroissant side.

@lhoestq Thanks for the clarification! I changed my code to handle both Sequence(Value("float32")) and [Value("float32")]. I don't handle the cases of dicts for now.

@lhoestq I don't have an easy way to launch the tests locally. Can you trigger them on the PR? Thanks :)

@lhoestq I shouldn't have amended my commit. Now it's asking for the approval again. Can you please trigger the workflows again? I'll make sure to push new commits instead of amending next time.

cool ! feel free to run make style to fix the code formatting issue

@lhoestq Done. There's still errors but unrelated to my changes, should I also change those? Thanks!

@lhoestq Quentin, pinging you again to trigger the workflows. 🤞

PS: I couldn't follow the DEVELOPER_GUIDE. poetry hangs at the very beginning and never finishes, so I ended up using pip manually.

haha should be good now ! x) sorry for the inconvenience of this process

It's green... except for the e2e tests. Is this normal? Once merged, when does it get deployed to https://huggingface.co/api/datasets? Thanks again!

I'll deploy this afternoon if it's ok for you


[question] Is there a plan to allow changing transition approval permissions based on the workflow instance object?

I am trying to integrate this work with a team/role based permission scheme where a user from team A can add a request to team B and only team B can work on it until review which would have to be done by somebody from team A. Team B would follow the same work flow as team A but the approvals would swap based on who the request was created for. I am trying keep with the same mentality of dynamic permissions and thought that hooks might be a good way to implement this, however, I don't see any return for the hooks nor does it look like I can affect the available approvals for a given user other than through the TransitionApprovalMeta. Is there a way to accomplish this task with current code or is a change required? Thanks in advance

You will need to create two workflows with two StateFields.
Team A creates a workflow for one statefield, and are only given permission to approve the specific last stage either through a Team A group or through individual permissions.
Same applies to Team B.
This is not really the best solution, because it is easy that Team C will come sometime in the future and mess up everything.

Thanks for the reply. Currently we have 4 teams with intentions of expanding so I don't think this will be a viable solution for me. With this being more of a question than a issue I will be closing it. I decided to write my own workflow tailored to my use case.


[Linux] Window tabs don't close when clicking on x button

Describe the bug
I can't close the extra viewport window by clicking on the x button in it's tab.
To Reproduce
Steps to reproduce the behavior:

Go to Windows->SceneView
Dock it to the same window as the existing viewport
Try to close it by clicking the tab's X button
See that it doesn't close.

Expected behavior
Windows should always close when clicking on their x button
Screenshots

Additional context
I am on kubuntu linux 24.04

I can't reproduce. It seems like you are missing libdl.so on linux, that's why the engine throws an exception and the viewport is not rendered in your screenshot. What I did in Debian is installing the package:
sudo apt install libc6
It was then installed to /lib/x86_64-linux-gnu/libdl.so.2, but Prowl is expecting it to be in /lib/x86_64-linux-gnu/libdl.so. At least that's on Debian, check if it's the case in Kubuntu too, and if so, simply create a link like so:
sudo ln -s /lib/x86_64-linux-gnu/libdl.so.2 /lib/x86_64-linux-gnu/libdl.so

I recently downgraded to dotnet 8.0 again because it's lts.
Is there a way we can downgrade this project to 8.0 and stay on it until the new lts?

You said you "can't test" not sure what you mean by that

@PaperPrototype I unintalled dotnet 9.0

You can have multiple versions installed

I am working on Debian and I have multiple dotnet versions installed. Also Rider detects them all and works like a charm.


FR: wrap yaml strings in quotes as necessary

For example, I use a title field in my yaml headers. Books and academic papers commonly include colons. When LINTER encounters this it fails silently - nothing happens (no error notification) but the console shows YAMLException. Simply wrapping the offending text in quotes fixes this.
Matched and unmatched single (') or double (") quotes also cause problems with interpreting the yaml string. Ideally you could recognize those cases and wrap the whole value with the appropriate (opposite) quote mark.
I really love this plugin - it has saved me a TON of time!! Thank you for the work.
ps - my first issue / FR on GH so please excuse any shortcomings

Hey @olearydj . It may be a little hard to fix this issue since I will not be able to parse the YAML since it is invalid, but I may be able to add some way to fix this or make the linter print a message when it encounters invalid YAML letting the user know that linting is not possible.

Alerting the user of invalid YAML would be a great addition, even if you are unable to correct the problem I described. Thank you for considering my request @pjkaufman!

@olearydj , I can see about adding a rule to put values in quotes if they have a quote (single or double) in it and do not start and end with it or if it has a colon in it. That should not be too bad to fix.
I am also fixing up some of the error message displays to show a YAML error if it exists. I cannot make it very specific, but it will try to show you what the offending issue is. It should always log the error in the console now instead of letting it go uncaught sometimes.

@olearydj , this change should go out with the release that I plan to put out this week. I need to do some more testing around #236 and another issue I may have found, but once I am satisfied with either creating issues for them or actually fixing the issues assuming it will not take a super long time, I will see about fixing them.
Please let me know if master or the next release does not solve the problem for this issue.


Turn rating feature into something presentable

TODO / Problems:

[x] XSS vulnerability (see the osm app entry in the store app to know what I mean)
[ ] you can go into the rating screen, even when you already rated the app
[ ] you can not use arrow up in the description field
[ ] no username where ratings are
[x] comment is mandatory (not optional) to discourage spam (you need a comment with atleast 3 chars: 2 emojis or a simple word like Awesome, good or whatever)
[ ] no possibility to set the username nor migrate the account

Optional ideas:

[ ] Code cleanup

[ ] move functions inside of an Rating namespace/object like we done it for the download counter
[ ] move network request functions to backend-api file, so later when implementing proxies we can do it all at one place (like it's done for the download counter)

you can not use arrow up in the description field
but you can use left and right, up and down ist die switch between star raiting and comment field


Design Enhancements

Consistent UI style across different pages
Add PancakeView on Add New Button on MainPage.xaml
Change close button to a close icon
Change corner radius of all elements to match each other

Thanks for completing the challenge! Fill out this form so we can send you the swag! https://aka.ms/cog-svcs-swag


Syntax error not reported in extension manifest

Description
A syntax error isn't reported for package.json

json file contents
```json
{
    "name": "new-extension",
    "displayName": "new-extension",
    "description": "",
    "version": "0.0.1",
    "engines": {
        "vscode": "^1.78.0"
    },
    "categories": [
        "Other"
    ],
    "activationEvents": [
        "html"
    ],
    "main": "./out/extension.js",
    "contributes": {
        "commands": [
            {
                "command": "extension.helloWorld",
                "title": "Hello World"
            }
        ]
    },
},
"scripts": {
    "vscode:prepublish": "npm run compile",
    "compile": "tsc -p ./",
    "watch": "tsc -watch -p ./",
    "pretest": "npm run compile && npm run lint",
    "lint": "eslint src --ext ts",
    "test": "node ./out/test/runTest.js"
},
"devDependencies": {
    "@types/vscode": "^1.76.0",
    "@types/glob": "^8.0.1",
    "@types/mocha": "^10.0.1",
    "@types/node": "16.x",
    "@typescript-eslint/eslint-plugin": "^5.49.0",
    "@typescript-eslint/parser": "^5.49.0",
    "eslint": "^8.33.0",
    "glob": "^8.1.0",
    "mocha": "^10.1.0",
    "typescript": "^4.9.4",
    "@vscode/test-electron": "^2.2.2"
}
}
```

Version
Version: 1.79.0-insider
Commit: c3867859cf3e1a73f3ddce5ad36b3791b7883d88
Date: 2023-06-01T05:26:04.304Z
Electron: 22.5.4
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0

I get errors reported: Trailing comma on line 23 and end of file expeced at line 24.
Make sure the language mode is JSON (check the label on the status bar) and that the JSON language extension is not disabled.


[CircleCI] Fix failing "Uploading test results"

The "Uploading test results" step failed in the tests:
Unable to save test results from /Users/distiller/test-results
Error stat /Users/distiller/test-results: no such file or directory
Found no path with test results, skipping

Source: https://circleci.com/gh/fastlane/fastlane/12658
This PR fixes this by:

Replace CIRCLE_TEST_RESULTS with CIRCLE_TEST_REPORTS (that is used by the Rakefile)
Define CIRCLE_TEST_REPORTS as ~/test-results
Reuse that explicit path (not via env var as Circle doesn't support this in 2.0 any more :/) in mkdir and store_test_results
Add store_artifacts to also upload and make accessible the whole .xml file with results
Rakefile: Use ENV var in string directly via ruby instead of shell command

Now the test results get written to the defined file, uploaded as test results and artifacts, and displayed in Circle CI UI:

Test Summary
Your build ran 4718 tests in RSpec with 0 failures
Slowest test: fastlane_core.spec.build_watcher_spec FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete returns specified build when strict watch is enabled (took 10.01 seconds).

Artifacts
Container 0
test-results/
fastlane-junit-results.xml

fixes #11303

          1 Warning

:warning:
Pull Request is Work in Progress

  Generated by :no_entry_sign: Danger

:tada:


Zones created in canvas mode with multi monitors and text scaling at 125%  produces zones of the wrong size

Microsoft PowerToys version
0.45.0
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Choose the setting "Allows zones to span across monitors":

Have 2 monitors and set both monitors to 125% text scaling:

Create a Fancy Zone using Canvas mode.
Apply this as the current fancy zone Mode.
Open a browser or other app that should scale to a zone. Shift drag the app to select the zone:
✔ Expected Behavior
The fancy zones regions displayed should be exactly the same size as created in the editor
❌ Actual Behavior
The fancy zones regions displayed are of the wrong size and appear to be 125% of their original size.
Other Software
n/a

Similar problem - more examples and screenshots at issue #10032. Been happening for months.

Hello - Upgraded to the latest version but still no luck.
I added some new screenshots. You can see that FZ is confused about what my monitors are.
I really have (2) 2560X1440 Monitors
Combined, FX sees (1) 5120X1380
Split, FZ sees (1) 2048X1104
Help!

I think it'ld be good for this issue to "take a step back and try again". @chrisride which version are you using now and does your issue still occur? And it would help if we could have a screenshot, to see the issue :)
It might be good to see if checking the settings ✔ "Allow zones to span across monitors" is really needed.

Hello,
Just upgraded to 0.57.0 on a fresh install of Windows 11, and the exact problem still exists.

Not able to repro this, going to close. Let us know if you see this again!


semicolon rule incorrectly applied inside of interface declarations

Bug Report

TSLint version: 3.15.1
TypeScript version: 2.0.3
Running TSLint via: grunt-tslint

TypeScript code being linted
interface PollLinkOptions {
    account: { domain: string },
    poll: { uid: string },
    emailToken: string
};

with tslint.json configuration:
{
    "rules": {
        "semicolon": [
            true,
            "always"
        ]
}

Actual behavior
(semicolon) routes/links.ts[2, 30]: Missing semicolon
(semicolon) routes/links.ts[3, 24]: Missing semicolon
(semicolon) routes/links.ts[4, 20]: Missing semicolon

Expected behavior
Should not be treated as an error.

@nonplus was having the same issue and stumbled across the tslint option ignore-interfaces, which would give you a configuration of
{
    "rules":  {
        "semicolon": [
            true,
           "always",
           "ignore-interfaces"
        ]
    }
}

Picked it up from here https://palantir.github.io/tslint/rules/semicolon/

Awesome, looks like this is fixed! 🎉


Side effect of os.path.exists on GetAttributes for directory junctions

On my computer, I have a strange effect when using os.path.exists on a directory junction: for about 10 seconds after using it, the GetAttributes function returns the attributes of the target.
So the function "isJunction" fails because it checks os.path.exists, then calls GetAttributes and gets the attributes of the target, which is a directory, not a junction.
I'm using python 3.2 on windows seven 64 bits. The directory junctions are on a network drive, the server is running windows server 2008r2.
I suggest checking the existence of the path directly with the attributes like this:
def isjunction(path):
attrs = fs.GetFileAttributes(path)
if attrs==0xffffffff or not fs.junctions_supported(path):
return False
return bool((attrs & fs.FILE_ATTRIBUTE_DIRECTORY) and
            (attrs & fs.FILE_ATTRIBUTE_REPARSE_POINT))

0xffffffff is the constant INVALID_FILE_ATTRIBUTES, that is not defined anywhere I think.

Had to +1 you for haven't had a working Windows development environment for several months
Same here, which brought me to this module as a potential solution for some windows users in SickRage xD.

Going to close this since there was no feedback for almost 8 years.


[Question] I'm failing to evaluate a model on a task.

I want to evaluate llama-3.1-instruct on the Math benchmark. The code runs without any error but it seems that the score each 0, which doesn't match what is on HF. Any help?
!lm_eval \
    --model_args pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct \
    --include_path /home/joaoabrantis/lm-evaluation-harness/lm_eval/tasks/leaderboard/math \
    --tasks leaderboard_math_hard

And after some processing I get:
hf (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct), gen_kwargs: (), limit: None, num_fewshot: None, batch_size: 1
|                    Tasks                    |Version|Filter|n-shot|  Metric   |Value|   |Stderr|
|---------------------------------------------|-------|------|-----:|-----------|----:|---|-----:|
|leaderboard_math_hard                        |N/A    |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_algebra_hard             |Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_counting_and_prob_hard   |Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_geometry_hard            |Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_intermediate_algebra_hard|Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_num_theory_hard          |Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_prealgebra_hard          |Yaml   |none  |     4|exact_match|    0|±  |     0|
| - leaderboard_math_precalculus_hard         |Yaml   |none  |     4|exact_match|    0|±  |     0|

|       Groups        |Version|Filter|n-shot|  Metric   |Value|   |Stderr|
|---------------------|-------|------|-----:|-----------|----:|---|-----:|
|leaderboard_math_hard|N/A    |none  |     4|exact_match|    0|±  |     0|

The leaderboard probably uses --apply_chat_template for instruct models (maybe also --fewshot_as_multiturn)

i Have same problem even when using  --apply_chat_template   but when I added  --fewshot_as_multiturn in addition of the previous chat template argument I got this.

Tasks
Version
Filter
n-shot
Metric

Value

Stderr

leaderboard_math_hard
N/A

- leaderboard_math_algebra_hard
1
none
4
exact_match
↑
0.1042
±
0.0175

- leaderboard_math_counting_and_prob_hard
1
none
4
exact_match
↑
0.0163
±
0.0115

- leaderboard_math_geometry_hard
1
none
4
exact_match
↑
0.0227
±
0.0130

- leaderboard_math_intermediate_algebra_hard
1
none
4
exact_match
↑
0.0107
±
0.0062

- leaderboard_math_num_theory_hard
1
none
4
exact_match
↑
0.0390
±
0.0156

- leaderboard_math_prealgebra_hard
1
none
4
exact_match
↑
0.1140
±
0.0229

- leaderboard_math_precalculus_hard
1
none
4
exact_match
↑
0.0148
±
0.0104

the results are quite low

On the leaderboard it says this model achieved 16%. On the model's card it says 51.9 with zero-shots!
It would be great to know which parameters were used on the leaderboard so that it gets easier to reproduce results.

cc @clefourrier any idea what might be going on here?

Hi!
We actually have a section on reproducibility in our doc here, you can simply follow the steps there. You do indeed need the chat template and few shot multiturn params for chat/instruct models, I'll add these 2 to the docs.
The other thing we noticed when discussing these results with the Meta team is that the instruction tuning of the model makes it ignore in context learning: it's no longer able to follow the minerva answer format, hence why most answers count as false.

Hi @clefourrier thank you for looking into this.
It seems that @sorobedio used both those settings and still wasn't able to achieve the results displayed in the Leaderboard. So maybe something else is missing.
The instruction tuned model achieves a better score (0.16 on math raw) than the base model (0.05).
Aside: If anyone knows how Meta tested their models on MATH would love to give it a look!

Did he use our fork, per the instructions? Some of our latest change are not in the harness yet

I'm getting similar results to those on the leaderboard, but not quite. Could be vllm handles stop sequences differently.
using
lm_eval -m vllm -model_args pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct -tasks leaderboard_math_hard -b auto  --apply_chat_template --fewshot_as_multiturn --num_fewshot 4

Task
VLLM
HF

- math_algebra_hard
0.3225 ± 0.0267
0.3257 ± 0.0268

- math_counting_and_prob_hard
0.0894 ± 0.0258
0.1301 ± 0.0305

- math_geometry_hard
0.0758 ± 0.0231
0.0455 ± 0.0182

- math_intermediate_algebra_hard
0.0250 ± 0.0093
0.0250 ± 0.0093

- math_num_theory_hard
0.1429 ± 0.0283
0.1364 ± 0.0277

- math_prealgebra_hard
0.3523 ± 0.0345
0.2850 ± 0.0326

- math_precalculus_hard
0.0519 ± 0.0192
0.0222 ± 0.0127

I was able to reproduce:
hf (pretrained=meta-llama/Meta-Llama-3.1-8B-Instruct), gen_kwargs: (None), limit: None, num_fewshot: 4, batch_size: auto (8)
|                    Tasks                    |Version|Filter|n-shot|  Metric   |   |Value |   |Stderr|
|---------------------------------------------|-------|------|-----:|-----------|---|-----:|---|-----:|
| - leaderboard_math_algebra_hard             |      1|none  |     4|exact_match|↑  |0.3290|±  |0.0269|
| - leaderboard_math_counting_and_prob_hard   |      1|none  |     4|exact_match|↑  |0.1138|±  |0.0288|
| - leaderboard_math_geometry_hard            |      1|none  |     4|exact_match|↑  |0.0909|±  |0.0251|
|leaderboard_math_hard                        |N/A    |none  |     4|exact_match|↑  |0.1775|±  |0.0099|
| - leaderboard_math_intermediate_algebra_hard|      1|none  |     4|exact_match|↑  |0.0250|±  |0.0093|
| - leaderboard_math_num_theory_hard          |      1|none  |     4|exact_match|↑  |0.1883|±  |0.0316|
| - leaderboard_math_prealgebra_hard          |      1|none  |     4|exact_match|↑  |0.3472|±  |0.0344|
| - leaderboard_math_precalculus_hard         |      1|none  |     4|exact_match|↑  |0.0370|±  |0.0163|

|       Groups        |Version|Filter|n-shot|  Metric   |   |Value |   |Stderr|
|---------------------|-------|------|-----:|-----------|---|-----:|---|-----:|
|leaderboard_math_hard|N/A    |none  |     4|exact_match|↑  |0.1775|±  |0.0099|

Thank you for the help!

@baberabb I also found differences between HF and vllm. I don't know why. Maybe one loads the model in float32 and the other in float16?

I think both vLLM and HF default to the dtype in the model config

On the leaderboard it says this model achieved 16%. On the model's card it says 51.9 with zero-shots!
It would be great to know which parameters were used on the leaderboard so that it gets easier to reproduce results.

Hi,
A simple question, does anyone know what leads to such a gap? It seems quite large. Are the datasets / num_shots the same?


Enable retain runs.

This PR enables the retain runs template in the C++ repo.

@mitchdenny what does that let us do?

@ahsonkhan this just makes sure the build pipelines that we end up release stick around longer so we can revisit logs or artifacts from that build longer.


无法在Ubuntu上编译，但是可以在CentOS上编译

Greensea 你好，
我在CentOS上，yum install libev-devel之后，编译仍然报错，后来把 /usr/include/libev的内容移动到/usr/include后编译成功。
可是ubuntu上apt-get install libev-dev后却编译报错，无法解决。
请问你有办法嘛？
无论如何都感谢你和你的项目。

请你把编译时的信息都贴上来，以便分析具体原因

I have the same problem, I'm unable to get it to compile under ubuntu. References to pthread and libev fail.
odroid@odroid:~/build/mptunnel$ make
gcc -MT "server.o server.d" -MM -g -Wall -I/usr/include/libev server.c > server.d
gcc -MT "rbtree.o rbtree.d" -MM -g -Wall -I/usr/include/libev rbtree.c > rbtree.d
gcc -MT "net.o net.d" -MM -g -Wall -I/usr/include/libev net.c > net.d
gcc -MT "mptunnel.o mptunnel.d" -MM -g -Wall -I/usr/include/libev mptunnel.c > mptunnel.d
gcc -MT "client.o client.d" -MM -g -Wall -I/usr/include/libev client.c > client.d
gcc -g -Wall -I/usr/include/libev   -c -o client.o client.c
gcc -g -Wall -I/usr/include/libev   -c -o net.o net.c
gcc -g -Wall -I/usr/include/libev   -c -o mptunnel.o mptunnel.c
gcc -g -Wall -I/usr/include/libev   -c -o rbtree.o rbtree.c
gcc -g  -lev -lpthread client.o net.o mptunnel.o rbtree.o  -o mpclient
client.o: In function `ev_thread':
/home/odroid/build/mptunnel/client.c:43: undefined reference to `ev_run'
client.o: In function `main':
/home/odroid/build/mptunnel/client.c:82: undefined reference to `pthread_create'
/home/odroid/build/mptunnel/client.c:83: undefined reference to `pthread_detach'
client.o: In function `init_recv_ev':
/home/odroid/build/mptunnel/client.c:215: undefined reference to `ev_loop_new'
/home/odroid/build/mptunnel/client.c:222: undefined reference to `ev_io_start'
client.o: In function `destroy_recv_ev':
/home/odroid/build/mptunnel/client.c:234: undefined reference to `ev_io_stop'
client.o: In function `client_thread':
/home/odroid/build/mptunnel/client.c:368: undefined reference to `pthread_create'
/home/odroid/build/mptunnel/client.c:369: undefined reference to `pthread_detach'
mptunnel.o: In function `received_init':
/home/odroid/build/mptunnel/mptunnel.c:114: undefined reference to `pthread_mutexattr_init'
/home/odroid/build/mptunnel/mptunnel.c:115: undefined reference to `pthread_mutexattr_settype'
/home/odroid/build/mptunnel/mptunnel.c:117: undefined reference to `pthread_mutexattr_destroy'
collect2: error: ld returned 1 exit status
make: *** [mpclient] Error 1
odroid@odroid:~/build/mptunnel$

Changed Makefile:
From
LDFLAGS = -g  -lev -pthread

to
LDFLAGS = -g  -lev -pthread

Now:
odroid@odroid:~/build/mptunnel$ make
gcc -MT "server.o server.d" -MM -g -Wall -I/usr/include/libev server.c > server.d
gcc -MT "rbtree.o rbtree.d" -MM -g -Wall -I/usr/include/libev rbtree.c > rbtree.d
gcc -MT "net.o net.d" -MM -g -Wall -I/usr/include/libev net.c > net.d
gcc -MT "mptunnel.o mptunnel.d" -MM -g -Wall -I/usr/include/libev mptunnel.c > mptunnel.d
gcc -MT "client.o client.d" -MM -g -Wall -I/usr/include/libev client.c > client.d
gcc -g -Wall -I/usr/include/libev   -c -o client.o client.c
gcc -g -Wall -I/usr/include/libev   -c -o net.o net.c
gcc -g -Wall -I/usr/include/libev   -c -o mptunnel.o mptunnel.c
gcc -g -Wall -I/usr/include/libev   -c -o rbtree.o rbtree.c
gcc -g  -lev -pthread client.o net.o mptunnel.o rbtree.o  -o mpclient
client.o: In function `ev_thread':
/home/odroid/build/mptunnel/client.c:43: undefined reference to `ev_run'
client.o: In function `init_recv_ev':
/home/odroid/build/mptunnel/client.c:215: undefined reference to `ev_loop_new'
/home/odroid/build/mptunnel/client.c:222: undefined reference to `ev_io_start'
client.o: In function `destroy_recv_ev':
/home/odroid/build/mptunnel/client.c:234: undefined reference to `ev_io_stop'
collect2: error: ld returned 1 exit status
make: *** [mpclient] Error 1
odroid@odroid:~/build/mptunnel$

@jamescorbett Seems your environment is misconfigured, make sure you have libev installed and GCC can find the dynamic libraries (libev.so)

Oddly the linker does find libev.so successfully, I'm not in front of my computer but I ran it with verbose and saw it located.

Could you post verbose output of the compiler?
On Mon, Nov 23, 2015 at 6:12 PM, James Corbett<EMAIL_ADDRESS>wrote:

Oddly the linker does find libev.so successfully, I'm not in front of my
computer but I ran it with verbose and saw it located.
—
Reply to this email directly or view it on GitHub
https://github.com/greensea/mptunnel/issues/2#issuecomment-158895863.


subnet_ids

I like your neat trick of autodiscovering subnet_ids.
However, not all subnets in a vpc could be suitable for deploying training instances (think of Denali). Also not all subnets could be connected to each other. In case of DDP, is it possible for instances may end up being deployed in a different subnets and not able to communicate to each other.

I don't think it is possible that individual instances get deployed in different subnets and then cannot communicate with each other. @divyamurali168 please confirm.


Visual editor

Visual scripting/programming for automation scripts its useful.
Maybe need add Blockly - visual editor?

Until then, you can use Node-RED for some action.

Ok, Thanks, i try Node RED

This is a duplicate of #486