Adding autocomplete support for python code

This PR adds code competition for python in streamlit.
I had to modify the kernel (the web worker) and added new dependency (jedi) that I am using for code completion and later we can re-use it for other things like validation, hover, function signature...etc.
https://github.com/cognitedata/stlite/assets/40126033/ea1cb3c2-6f63-49b8-b80a-836198340aae
Closes
https://github.com/cognitedata/cog-ai/issues/1626

Am I correct to understand that you are changing stlite internals? Wont this make it hard for us to merge changes from upstream?

Yes, I made changes in some of the stlite internal files and this is a valid question that I am asking myself 😀
I tried to isolate the changes that we are making to live inside cognite folder, but there are 1-2 files where there was no other way with the current setup.
We already have been making changes in the stlite internals when the code was modified to inject the sdk token.
The part that concerns me is that it will be harder to pull new changes without conflicts and storing python code as a string. The python code is covered with unit test but still it is hard to read and make changes there.
We've been discussing with Anders to contribute and make this changes in the upstream repo, but that will take time, assuming that they will accept the pr ☺

Approving, but create a ticket in cog-ai for moving these customizations upstream.


Maorbranch

Adding flake8.yml & README.md files

can you squash the readme commits? no need for 2 commits on the project history..


Related issues linked to use cases

Your use cases have a spot for open issues, but none of the related issues are linked?

Anyone know what this means?

Hm, I think this is referring to our "Open Issues" sections in the use case wikis, imo linking the relevant use case should be sufficient, perhaps we can remove this and replicate it by adding a " - open" next to relevant cases


How to reference the path for addScriptTag from a different file

Hi,
At present I have multiple test cases in a single file and i end up defining the library for each case.
Can you please show us some example of how to reference the library from a different file to use it inside the actual code. Probably a function
I'm new to javascript. This would definitely help a lot to most I believe!!
await this.page.addScriptTag({
path: path.join(__dirname, '../../node_modules/query-selector-shadow-dom/dist/querySelectorShadowDom.js')
});
Reference the above code in the actual test case.
I tried to use it from different file like below :
helper.js
async function path() {
await this.page.addScriptTag({
path: path.join(__dirname, '../../../node_modules/query-selector-shadow-dom/dist/querySelectorShadowDom.js')
});
}
module.exports = { path };
code :
const pathFor = require('./lib/helper.js')
await pathFor.path(); // this is the code in question
try {
const nextbtn = (await this.page.waitForFunction(() => {
const nextbtn = querySelectorShadowDom.querySelectorDeep(".something")
return nextbtn;
})).asElement();
await nextbtn.click();
console.log("clicking the button is a success")
}catch(e) {
    throw new Error("clicking button is not a success")
}

Thanks in advance

I'm a little surprised what you've dine in helper.js doesn't work I'll try to find some time later next week to look at this. I want to make using the this lib with puppeteer better, you may have seen the updates to introduce playwright support which is done I a much nicer way I'd like to do that same with puppeteer if it supported it

Great,  looking forward for the update on this!! will be much useful for my current project.

One thing to check with your code example you are importing path but also have function named path in the same scope, this wont work

also you re no passing in the page object?

I'm passing it in the page object

Georgegriff, i do not have any other function named path.
I also see that few click and tags are not recognized with deepqueryselector
for ex:
below is the complete path
document.querySelector("body > web").shadowRoot.querySelector("search").shadowRoot.querySelector("#search > div.search-text > dn-search").shadowRoot.querySelector("#helpers-1234").shadowRoot.querySelector("div > span")
deep selector to get the inner text is not working in this case

Happy to look into if there are issues with the library, what are those web and search elements? Can't be web components they have no dash

Doesn't seem valid that an element of web can be a direct child of body which is what your above snippet suggests

Georgegriff, i do not have any other function named path. What I meant was your function is named path and you're using the path node module path.join..., this doesn't seem right, please look closer at my screenshot

Closing sue to inactivity


Destroy or BeforeDestroy send to wrong component

If there are some components inside
You can test it in fiddle https://jsfiddle.net/robedgenius/817komr8/. When clicking "remove" button, it removes data index "1". However, the beforeDestroy method alert message is "4", i.e, the last index.
HTML

    <button @click.prevent="destoryEle(1)">Remove</button>

    <template v-for="g in gridData">

      <demo-grid :aid="g.aid" :name="g.name" :power="g.power"></demo-grid>

    </template>

end

Javascript code here:
Vue.component('demo-grid', {
    template: '#grid-template',
    replace: true,
    props: {
      aid: 0,
      name: Object,
      power: Object,
    },
    beforeDestroy (){
      alert('destroy: ' + this.aid);
    }
  });

// Creating a new Vue instance and pass in an options object.
var demo = new Vue({

	// A DOM element to mount our view model.
	el: '#main',

	// Define properties and give them initial values.
	data: {
     gridData: [
       {aid: 1, name: 'Chuck Norris', power: Infinity },
       {aid: 2,  name: 'Bruce Lee', power: 9000 },
       {aid: 3,  name: 'Jackie Chan', power: 7000 },
       {aid: 4,  name: 'Jet Li', power: 8000 }
     ]
  },
  methods:{
      destoryEle: function(aid){
        this.gridData.splice(aid, 1);
      }
  }
});

When you iterate components with v-for, you need to provide a key. Otherwise Vue 2 implicitly keys them by index, and the instance that actually dies is in fact the last one in the list. Unless your instances are stateless, this causes issues like the one you describe.
Demo: https://jsfiddle.net/817komr8/2/


[i18n/cn] update the nav structure for docs

Updated the nav structure in i18n/cn folder. EN change will be a new PR.
cc @qiupingdai @Jeanine-tw

Caution:
We don't  have the preview feature.
For such a big change, we only can know the effect after merged, which may cause some risks.

lgtm/

/hold
Let's hold this. We can merge EN  firstly because it supports build locally and check the final nav effect.

Well, all links are fixed and the CI is successful.


inference task will be blocked in spark mode

in spark mode, inference task will be blocked if the partition size can't be divided exactly by batch

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

For "train" just use the previous condition (get the exact batch_size items for each batch dicard the last batch if it is less than batch_size)
If the partition size can be divided exactly by batch_size, there still has a problem for "inference", where TFNode.next_batch will get "None" firstly, and return a empty list. It will break the iteration in "map_fun".
I have fixed this issue in my branch, please review it.

@mingxingwang yeah, I see that the "end of feed" vs. "end of partition" condition is a bit tricky.
I went ahead and made a branch to signal these differently, because I'd prefer to push the complexity into the framework vs. the users's application code.  Can you try it out?

@mingxingwang your last check-in doesn't work for me (for batch_size=100, it does work for batch_size=128).  I get the following error at mnist_dist.py, line 143
INFO:tensorflow:Error reported to Coordinator: <class 'ValueError'>, Cannot feed value of shape (0,) for Tensor 'x:0', which has shape '(?, 784)'

That said, was there a reason why my branch didn't work for you?

OK, to answer my own question... I missed the comment you made about the "train" termination condition not being fully correct.
Anyhow, I like what you've done with grouping the feed handling methods together into a class/object, but I still want to use the EndPartition marker object in the queue, since it's a bit more definitive than relying on the size of the batch to infer state (which may have led to the error I was getting).  Also, I want to defer the batch_size to the next_batch() call, just in case folks want to dynamically change that for any reason.
So, I've taken the liberty to create another branch that merges your latest branch with my previous branch, with some of the tweaks described above.  If this looks good to you, feel free to merge it back into this PR (so you can get credit for your work), and I'll merge it into master.

It looks good for me, and I have merged the code.

+1


Add downcast result check (#151)

This fix will prevent crash on types inherited from templates (issue #151).
Note that the resulting documentation will be incomplete because those templates are skipped.

You know where in the html output this is used?
I'd image we want templated derived classes to appear there as well.
Here is existing code that peals off eponymous templates, not sure if that makes sense here.
https://github.com/rejectedsoftware/ddox/blob/94ec70a8e5c7e7d31a0ec0f8d9d37fece266008b/source/ddox/parsers/dparse.d#L417-L424

I'd suggest fix the crash issue first and then create another one for incomplete documentation.
In its current state DDOX is unable to generate any documentation for every project that has at least one type inherited from template.

Sorry for not getting back earlier.
You arguments makes some sense, I'd still prefer to not simply workaround the immediate issue introducing new bugs. Also you just fixed interfaces, but left base class templates broken (2 lines above).
Those sort of if (exp !is null) fixes tend to accumulate as cargo cult and maintenance debt, better not to start with that.
It's clearly tricky for someone not too familiar with the codebase to provide a proper fix, I'll have a look.
Closed in favor of #167


client.Pull(..., WithPullUnpack) doesn't fetch layer contents if snapshot already exists

Description
When pulling an image using client.Pull function with WithPullUnpack option, the manifest blobs are split into "layers" and "non-layers". This allows to defer the download of layers which makes it possible for remote snapshotters to work.
https://github.com/containerd/containerd/blob/36b871955cd6698435498a4b986d6e80d21ab600/pkg/unpack/unpacker.go#L186-L205
However, the unpack code doesn't reach the point where it fetches the layers because it exits early when the snapshot is already present:
https://github.com/containerd/containerd/blob/36b871955cd6698435498a4b986d6e80d21ab600/pkg/unpack/unpacker.go#L298-L300
Steps to reproduce the issue

Pull image
Add snapshot lease or create child snapshot
Delete the image
Pull the image again

Nerdctl reproduction:
$ nerdctl image pull busybox
docker.io/library/busybox:latest:                                                 resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79:    done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:1fa89c01cd0473cedbd1a470abb8c139eeb80920edf1bc55de87851bfb63ea11: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:fc9db2894f4e4b8c296b8c9dab7e18a6e78de700d21bc0cfaf5c78484226db9c:   done           |++++++++++++++++++++++++++++++++++++++|
layer-sha256:8a0af25e8c2e5dc07c14df3b857877f58bf10c944685cb717b81c5a90974a5ee:    done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.4 s                                                                    total:  1.8 Mi (1.3 MiB/s)

$ nerdctl image run -d busybox
b8b8e9599bccbeacdaa83fcd63f5039dd9a619f5f9ae9511f5bd0da9e4cdcac1

$ nerdctl image rm busybox
FATA[0000] 1 errors:
conflict: unable to delete busybox (must be forced) - image is being used by stopped container b8b8e9599bccbeacdaa83fcd63f5039dd9a619f5f9ae9511f5bd0da9e4cdcac1

$ nerdctl image rm -f busybox
Untagged: docker.io/library/busybox:latest@sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79
Deleted: sha256:3694737149b11ec4d2c9f15ad24788e81955cd1c7f2c6f555baf1e4a3615bd26

### At this point snapshot exists because of a stopped container, but all image content is deleted.

$ nerdctl pull busybox
docker.io/library/busybox:latest:                                                 resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:3fbc632167424a6d997e74f52b878d7cc478225cffac6bc977eedfe51c7f4e79:    done           |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:1fa89c01cd0473cedbd1a470abb8c139eeb80920edf1bc55de87851bfb63ea11: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:fc9db2894f4e4b8c296b8c9dab7e18a6e78de700d21bc0cfaf5c78484226db9c:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.1 s                                                                    total:   0.0 B (0.0 B/s)

## ^^^ Note that the layer was not fetched

# Now we can't do anything that involves the packed content (for example push).
$ nerdctl tag busybox myregistry:5000/test
$ nerdctl push myregistry:5000/test
FATA[0000] failed to create a tmp single-platform image "myregistry:5000/test:latest-tmp-reduced-platform": content digest sha256:8a0af25e8c2e5dc07c14df3b857877f58bf10c944685cb717b81c5a90974a5ee: not found

Describe the results you received and expected
Operations that need packed content work after client.Pull(..., WithPullUnpack).
What version of containerd are you using?
v1.7.3
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

create child snapshot

It means that there is reference to the parent by the container. The delete image is to delete the reference from image to parent snapshot. However, the reference count is still one maintained by container. The snapshots won't be deleted.
I think the solution is to generate the content blob if it's not exist when push.
https://github.com/containerd/nerdctl/issues/2295

This is a common situation today in the pull->tag->push flow.  By default pull+unpack is optimizing for running a container on the current platform and will skip unneeded content (whether because different platform or already exists). Changing the default pull behavior should be up to the client but we could possibly try and be smarter on tag and push operations as well.

Add flag to pull to get the all the related content for an image so that it can be pushed.
Check content on tag, pulling missing content.
Attempt to pull missing content on push if needed using cross repo mount metadata, or just perform cross repo mount if exists from same registry (This might assume the WithAllMetadata option is at least provided on pull).

The same as https://github.com/containerd/nerdctl/issues/2327

Facing the exact same issue. While we are waiting for the fix PR #8878 to be reviewed and merged, is there any workaround we can try?
I tried to remove the image via nerdctl rmi and tried to remove it via ctr i prune --all. But whenever I tried to pull the same image again, I am facing the same reported issue.
nerdctl pull "amazon-ecr.amazonaws.com/some/image:latest"
amazon-ecr.amazonaws.com/some/image:latest: resolved       |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:somesha:           done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:some-different-sha:             done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.3 s                                                                              total:  9.1 Ki (7.0 KiB/s)

ctr i check
REF                                                                                TYPE                                                 DIGEST                                                                  STATUS            SIZE             UNPACKED
amazon-ecr.amazonaws.com/some/image:latest application/vnd.docker.distribution.manifest.v2+json sha256:somesha incomplete (1/44) 14.5 KiB/1.1 GiB true

Whenever I try export this image I faced the following issue:
nerdctl save -o ./image.tar "amazon-ecr.amazonaws.com/some/image:latest"
FATA[0000] failed to get reader: content digest sha256:some-entirely-different-sha: not found

any updates?

any updates?

nerdctl is facing many problems caused by this issue, see: https://github.com/containerd/nerdctl/issues/3509

Some issue 👀


Add the @context field to every response from the Archive API

This uses a custom Response class to ensure that we always include the @context parameter on our responses (even if it doesn't go anywhere yet!).
Importantly, it means we can keep this parameter out of our internal models, and never have to worry about it.

Ah, that might be why some of the tests are failing. Investigating.


Adding Button+AxisToAxis plugin

It's will be really useful in sims with lot of axis.
Pressing button "A" and roll axis "A" on joystic will give output as axis 1 of virtual joystic, pressing another button "B" and roll same axis "A" on joystic will give output axis 2 of virtual joystic.
Roll axis "A" without pressing any buttons will give output as axis 3 of virtual joystic (by AxisToAxis plugin).
And will be grate to do checkbox for variants of using button - press and hold, or press and release,

There is a future planned feature to support this called: Filters


stdin isn't a terminal

if I run :CheckHealth when it comes to the ruby provider I get this:
## Ruby provider
  - SUCCESS: Found up-to-date neovim RubyGem
  - INFO: Ruby Version: stty: stdin isn't a terminalstty: stdin isn't a terminalruby 2.0.0p481 (2014-05-08 revision 45883) [universal.x86_64-darwin14]
  - INFO: Host Executable: /Users/me/.gem/ruby/2.3.1/bin/neovim-ruby-host
  - INFO: Host Version: stty: stdin isn't a terminalstty: stdin isn't a terminal0.3.1

what can the problem be?

Are you using a GUI? Can you provide more details about your setup?

I'm in iTerm2 with zsh. Let me know if you need more information.

@zekus Can you try in bash? Or without your zsh rc files? Seems like something is calling stty.

Bingo! found
# Disable flow control commands (keeps C-s from freezing everything)
stty start undef
stty stop undef

Thanks!


add more information in Summarizer fromV

In this interface: https://github.com/twosigma/flint/blob/master/src/main/scala/com/twosigma/flint/timeseries/summarize/Summarizer.scala#L211
Sometime it is also good to know on which row it is rending. Is it possible to have something like:  def fromV(v: V, t: T): InternalRow

fromV() should be only called once after all rows are summarized, so there is no particular row associated with it. Can you elaborate why do you think it should be associate with an input row?

Forgot to mention, I was using summarizer in a window summarization, so the render function will be called on each row, to generate results for that row.


Grafana agent mimir updates

Place holder issue for this message...
i just checked my previous config for grafana agent. I had manually specified which url to scrape configs from

      configs:
      - name: integrations
        remote_write:
        - url: http://mimir-nginx.mimir-test.svc:80/api/v1/push
        scrape_configs:
        - job_name: kube-state-metrics
          static_configs:
            - targets: ['kube-state-metrics.hossted-operator.svc:8080']

@AdheipSingh : i'll try to see if i can make this dynamic without specifying manually. need to research on exact config.

Understand Loki Logs integration.
Cluster logs - k8s
Application logs


Statamic 4

We chatted about this on Discord but thought I'd create an issue in case you forget (because I know I do without an issue) about adding Statamic 4 support.
We're planning out Statamic 4 upgrades for our sites at the moment, this addon is a blocker for one of our sites (however, we have no massive rush on our end right now in upgrading)

Hey @robdekort can you try this PR? It's on the fix/support-v4 branch.
You'd put dev-fix/support-v4 as the constraint in your composer.json.
Note that I took out the GDPR Permissions thing cuz the Spatie package I use doesn't support it any more. I'll add it back in a bit, if this works.

Hey @edalzell. Much appreciated. I'm getting an error about the mailchimp assets missing.
Note: I don't use the GDPR stuff from Mailchimp.

Hmmm the vendor/silentz/mailchimp/dist directory is empty.

I was able to compile them.

Ok cool. I was able to subscribe to a mailchimp newsletter via the addon. That seems to work :-).

Neat

@robdekort @duncanmcclean please use 3.0.1, 3.0 was a broken release.

Wonderful Erin. Thanks. Updating the remainder of my sites right now.

Hey Erin,
I'm still running into issues with those darned assets. I don't understand any of that system tbh. Anyways. I'm getting this:
INFO  Publishing [mailchimp] assets.
ERROR  Can't locate path: <vendor/silentz/mailchimp/resources/dist/build/>.

I think the resources/ part shouldn't be in that path.


AdMob EasyBannerAd reloads ad on every rebuild

Place an EasyBannerAd anywhere in the widget tree
Trigger a rebuild (eg via hot reload)
Note that the banner ad is reloaded

This is an especially big problem if you try to size your ad according to the current device size because keyboard open/close will trigger tons of rebuilds which will make the banner ad attempt to load ~10 times on every open/close. This was causing huge perf problems in prod and hurting my AdMob CPM before I figured out what was happening.
Here's a minimal repro to demonstrate the problem:
// This is just a test scenario to make it easy to test opening and closing the keyboard.
class AdTest extends StatefulWidget {
  const AdTest({super.key});

  @override
  State<AdTest> createState() => _AdTestState();
}

class _AdTestState extends State<AdTest> {
  final FocusNode focus = FocusNode();

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Material(
        child: Column(
          children: [
            Expanded(
              child: Center(
                child: Row(
                  children: [
                    Expanded(child: TextField(focusNode: focus)),
                    IconButton(
                      onPressed: () {
                        focus.unfocus();
                      },
                      icon: const Icon(Icons.close),
                    ),
                  ],
                ),
              ),
            ),
            // This widget creates a banner ad that will resize if the screen width changes.
            // Eg if the user changes phone orientation or is using a folding phone and fold/unfolds.
            const _SelfSizingBannerAd(),
          ],
        ),
      ),
    );
  }
}

class _SelfSizingBannerAd extends StatefulWidget {
  const _SelfSizingBannerAd();

  @override
  State<_SelfSizingBannerAd> createState() => _SelfSizingBannerAdState();
}

class _SelfSizingBannerAdState extends State<_SelfSizingBannerAd> {
  late Future<AdSize?> adSize = getAdSize();
  int? lastSeenWidth;

  @override
  void didChangeDependencies() {
    final int? newWidth = MediaQuery.maybeOf(context)?.size.width.truncate();
    if (newWidth != lastSeenWidth) {
      adSize = getAdSize();
    }
    super.didChangeDependencies();
  }

  @override
  Widget build(BuildContext context) {
    return FutureBuilder(
      future: adSize,
      builder: (context, adSizeSnap) {
        if (adSizeSnap.connectionState != ConnectionState.done) {
          return const CircularProgressIndicator();
        }
        print('Building with ad size: ${adSizeSnap.data}');
        return EasyBannerAd(adSize: adSizeSnap.data ?? AdSize.banner);
      },
    );
  }

  Future<AdSize?> getAdSize() async {
    print('Getting ad size from media query!');
    // This creates a dependency on media query which will trigger rebuilds
    // (but not reinitialization) on keyboard open/close.
    lastSeenWidth = MediaQuery.maybeOf(context)?.size.width.truncate();
    if (lastSeenWidth == null) {
      return null;
    }
    return AdSize.getCurrentOrientationAnchoredAdaptiveBannerAdSize(
      lastSeenWidth!,
    );
  }
}

Note that the banner ad disappears while the keyboard is moving and then reappears some time after-it attempts ~10 reloads during this time.
You can verify the problem by putting a breakpoint on this line and then tapping hot reload and noting that the load() function executes again:
https://github.com/nooralibutt/easy-ads/blob/6a83bbc11895f65291338e8f3ae61e60d5462ad5/lib/src/easy_admob/easy_admob_banner_ad.dart#L70
The core problem here is that EasyAdMobBannerAd needs to be a stateful widget so that it is not reconstructed from scratch on every call to build. I can possibly take a stab at a PR in the next week or two if you do not have the time to tackle this, however I am also short time so I'm not sure if I actually can get to it. I also think the correct solution here is a fairly large rewrite. Here is what I would propose to properly solve this problem:
Ads that are shown in the widget tree and stay there (ex: banner ads) vs ads that "pop up" (ex: interstitial) are fundamentally different and it doesn't really make sense to have them implement the same base class. Banner ads should be stateful widgets and load should be handled from initState and show should just be a build function. Note, perhaps the size-selection logic should even be built into the EasyBannerAd widget while we're at it?
Let me know what you think of this.

yes, this is an important issue.


Dynamically read pg_config

Side tracked and built this https://github.com/Florents-Tselai/PyPgConfig

I should now use PyPgConfig to get the config object, and stored it within the Extension object.
That should be used to check that the PG instance we're extending.

While creating an Extension check and warn the user if the current python executable doesn't match the Python interpreter that Postgres uses.


Consider replacing master/slaves the terminology with primary/replicas

master/slave terminology is considered problematic. Would be great to make every step we can to remove those terms :-)

https://medium.com/@mikebroberts/let-s-stop-saying-master-slave-10f1d1bf34df
https://www.theserverside.com/opinion/Master-slave-terminology-alternatives-you-can-use-right-now
https://motherboard.vice.com/en_us/article/8x7akv/masterslave-terminology-was-removed-from-python-programming-language

Closed by #6


add artwork

Add new logo to for dateparser
I added the GIMP file and a png file.

fixes: https://github.com/scrapinghub/dateparser/issues/717

What about adding it to README.rst already?

Hi @Gallaecio, I was doing some tests, but I finally decided to add it as a subtask of this: https://github.com/scrapinghub/dateparser/issues/723
It will be easier to add the image once we have this merged.


[1.3.z] Update release checker

Summary
Backports  https://github.com/quarkus-qe/quarkus-test-framework/pull/1202 and https://github.com/quarkus-qe/quarkus-test-framework/pull/1209
Release 1.3.1 - changes in project.yml are required to match release versioning conventions
Please check the relevant options

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Refactoring
[x] Backport
[ ] Release (follows conventions described in the RELEASE.md)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

@michalvavrik release check failure is expected as we already have similar release 1.3.1.Final, script recognized it as 1.3.1. I don't like to release 1.3.2 as will not contain any changes for RHBQ.

@michalvavrik release check failure is expected as we already have similar release 1.3.1.Final, script recognized it as 1.3.1. I don't like to release 1.3.2 as it will not contain any changes for RHBQ.

Won't this PR trigger the release flow which will fail because you create PR from your fork? TBH I'd prefer to actually make release so that next guy that comes after you can just increment by one. This way, we have this whole compatibility issues behind us.

@michalvavrik release check failure is expected as we already have similar release 1.3.1.Final, script recognized it as 1.3.1. I don't like to release 1.3.2 as it will not contain any changes for RHBQ.

Won't this PR trigger the release flow which will fail because you create PR from your fork? TBH I'd prefer to actually make release so that next guy that comes after you can just increment by one. This way, we have this whole compatibility issues behind us.

I create another PR with release after this PR will be merged. So, 1.3.2  may be the next?

I create another PR with release after this PR will be merged. So, 1.3.2 may be the next?

sounds good


request support: brew plugin add $PATH settings

➜  ~ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: Homebrew's sbin was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting the PATH for example like so
  echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.zshrc

add this code:
if [ -d "$(brew --prefix)/bin" ]; then export PATH="$(brew --prefix)/bin:$PATH"; fi
if [ -d "$(brew --prefix)/sbin" ]; then export PATH="$(brew --prefix)/sbin:$PATH"; fi

see

brew --prefix source
brew diagnostic source
brew.plugin.zsh source

As a general rule we don't want to mess with people's $PATHs.


rtsp-simple-server crashes when HLS client connects

v0.16.1 linux_arm7 , see attached snippet of the log:
I`m reverting to previous version with bug  #374 for now, thanks.
journalctl -u rtsp-simple-server
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: 2021/05/23 16:11:47 I [0/8] [HLS] [conn 1xx.1xx.x.xxx:34532] GET /proxied2/
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: 2021/05/23 16:11:47 I [0/8] [HLS] [converter proxied2] opened
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: 2021/05/23 16:11:47 I [0/9] [HLS] [converter proxied2] is converting into HLS
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: panic: runtime error: invalid memory address or nil pointer dereference
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x12098]
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: goroutine 210 [running]:
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: github.com/aler9/rtsp-simple-server/internal/hlsconverter.(*Converter).runRequestHandler(0x310e070, 0x3505d00, 0x3
May 23 16:11:47 streamerbox rtsp-simple-server[5516]:         /s/internal/hlsconverter/converter.go:538 +0x14c
May 23 16:11:47 streamerbox rtsp-simple-server[5516]: created by github.com/aler9/rtsp-simple-server/internal/hlsconverter.(*Converter).runInner
May 23 16:11:47 streamerbox rtsp-simple-server[5516]:         /s/internal/hlsconverter/converter.go:320 +0x62c
May 23 16:11:47 streamerbox systemd[1]: rtsp-simple-server.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
May 23 16:11:47 streamerbox systemd[1]: rtsp-simple-server.service: Failed with result 'exit-code'.

Hello, to fix this i need to be able to replicate the issue, can you post a procedure that allows to replicate the issue? example:

start the server
publish with ...
read with ...

thanks

Thanks for having a look into this.

I start the server via systemd https://github.com/aler9/rtsp-simple-server#start-on-boot-with-systemd Same issue if started manually with server binary located in /home/$USER dir.

RTSP published streams are dahua ip cameras.

I read the HLS converted streams with a web browser (firefox/chromium) . When I try to connect to HLS via the browser the server crashes.  The server crashes both on record or proxy type streams.

The log below is from the record type stream rtsp-simple-server (linux_arm7 Raspberry Pi OS Lite), and the crash when I try to connect to it with a web browser.
It also crashes on my proxied rtsp-simple-server (inux_arm7 armbian, the log above from my first post)
journalctl -u rtsp-simple-server
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/0] [RTSP] [session<PHONE_NUMBER>] opened by 192.168.x.xxx:50352
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/0] [RTSP] [session<PHONE_NUMBER>] opened by 192.168.x.xxx:50348
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/0] [RTSP] [session<PHONE_NUMBER>] opened by 192.168.x.xxx:50354
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/0] [RTSP] [session<PHONE_NUMBER>] opened by 192.168.x.xxx:50350
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/1] [RTSP] [session<PHONE_NUMBER>] is reading from path 'cam1', 2 tracks with UDP
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/2] [RTSP] [session<PHONE_NUMBER>] is reading from path 'cam4', 2 tracks with UDP
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/3] [RTSP] [session<PHONE_NUMBER>] is reading from path 'cam3', 2 tracks with UDP
May 29 19:02:04 cambox rtsp-simple-server[21537]: 2021/05/29 19:02:04 I [0/4] [RTSP] [session<PHONE_NUMBER>] is reading from path 'cam2', 2 tracks with UDP
May 30 21:18:29 cambox rtsp-simple-server[21537]: 2021/05/30 21:18:29 I [0/4] [HLS] [conn 192.168.x.xx:32854] GET /cam1
May 30 21:18:29 cambox rtsp-simple-server[21537]: 2021/05/30 21:18:29 I [0/4] [HLS] [conn 192.168.x.xx:32854] GET /cam1/
May 30 21:18:29 cambox rtsp-simple-server[21537]: 2021/05/30 21:18:29 I [0/4] [HLS] [converter proxied1] opened
May 30 21:18:29 cambox rtsp-simple-server[21537]: panic: runtime error: invalid memory address or nil pointer dereference
May 30 21:18:29 cambox rtsp-simple-server[21537]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x4 pc=0x12098]
May 30 21:18:29 cambox rtsp-simple-server[21537]: goroutine 371 [running]:
May 30 21:18:29 cambox rtsp-simple-server[21537]: github.com/aler9/rtsp-simple-server/internal/hlsconverter.(*Converter).runRequestHandler(0x3f362a0, 0x3553640, 0x3553680)
May 30 21:18:29 cambox rtsp-simple-server[21537]:         /s/internal/hlsconverter/converter.go:538 +0x14c
May 30 21:18:29 cambox rtsp-simple-server[21537]: created by github.com/aler9/rtsp-simple-server/internal/hlsconverter.(*Converter).runInner
May 30 21:18:29 cambox rtsp-simple-server[21537]:         /s/internal/hlsconverter/converter.go:320 +0x62c
May 30 21:18:29 cambox systemd[1]: rtsp-simple-server.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
May 30 21:18:29 cambox systemd[1]: rtsp-simple-server.service: Failed with result 'exit-code'.

I quickly fired up an rtsp-simple-server_v0.16.2_linux_amd64 (debian) and the server does not crash as either record or proxied, but I get lots of unable to decode video track: first NALU does not contain the start bit and unable to decode video track: Packet is not FU-A errors.
The stream is virtually unwatchable with lots of buffering and artifacts as a proxy, but as a record stream there is less buffering and artifacts.
It may be an arm7 issue ?

Ok, that's better. Regarding the latest issue, follow the development here: #374


Asynchronous tests running

Are you requesting a feature or reporting a bug?
Feature
What is the current behavior?
testcafe.createRunner() executes every fixture one after the other.
What is the expected behavior?
Is there any way to execute all at the same time (asynchronously). Like opening 4 consoles and executing 4 tests at same time (with nightmare headless browser).
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code

Specify your

operating system: Mac OSX
testcafe version:
node.js version:

Hi,
Thanks for the proposal. We have this feature in our planned milestone but now we have no estimated date for this. You can vote for the feature by adding your 👍 there: https://github.com/DevExpress/testcafe/issues/1165


[Bug]Fix potential overflow of statistics values.

Add support for stats values up to max value of long.

Looks like the CI is failing. Could you take a look?
Also, what does the generated SQL look like for the migration Up method? You can generate it with Update-Database -Script.

Should we consider manually placing an overflowed download count in DEV or INT and test whether anything may be broken (CI, Tests, Manual UI tests)?

Also, should we have a better understanding about what will happen on DB side? It doesn't seem like a metadata change. Will it cause any on-site issues considering the scale?

Also, should we have a better understanding about what will happen on DB side? It doesn't seem like just a metadata change. Will it cause any on-site issues considering the scale?

This is a great concern. After testing this on DEV, I highly recommend we do the PROD transition on a weekend so that the index recreation can proceed at low traffic time (DEV migration, including rebuild, took about 8 minute). Note that there will be downtime between the migration and the deployment of the new gallery. During this time, any requests that hit the Download Count column will probably return 500 as the column is now too wide for the bits. This means we will need to coordinate the release of migration and gallery, and will likely need to leave a status message letting users know that there may be failures during this time while we migrate.

This migration looks like it might be DTU intensive. We should carefully planned the execution, perhaps at a non-peak time of day.
@advay26 + @ryuyu - consider holding off the dev to main merge for this PR.

Looks like the code is backwards compatible with either bitwidth in SQL. It should be safe to deploy code and run migration later during down time. Given this, I think it SHOULD be safe to merge, but I'm ok holding off if that is what we want to do @joelverhagen .

@ryuyu - is this ready to merge?


Add additional ref property to complex components

For some our more complex components such as Selects, Textfields, Search, Checkbox, Radio, Switch etc we are using a wrapped input or some other interact-able element.
In some use-cases our users would want to manually trigger or have access to events on the interact-able elements so that they then integrate it better into their app logic.
Example:

Fetching data from an api when someone does and action or starts typing inside a select..

Notes:

Look to TextField and inputRef for example of additional ref property

Actions:

Determine which components need an additional "ref" property

Breadcrumb - mismatch types if href is undefined

Breadcrumb:

mismatch types if href is undefined

Breadcrumbs:

feil type

Button:

mismatch types
as?: ElementType returns any

List:

as?: ElementType returns any

Search:

the clear button is a div element while in Select Multi.Select the clear button is a button element

Single & Multi Select:

input missing ref

Table:

HTMLTableDataCellElement deprecated, preferred HTMLTableCellElement
HTMLTableHeaderCellElement deprecated, preferred HTMLTableCellElement

Typography:

as?: ElementType returns any

Made an issue for the as properties #1736
Made an isse for the Search and clear button #1737

Breadcrumb:
mismatch types if href is undefined
Breadcrumbs:
feil type
Button:
mismatch types
as?: ElementType returns any
List:
as?: ElementType returns any
Search:
the clear button is a div element while in Select Multi.Select the clear button is a button element
Single & Multi Select:
input missing ref
Table:
HTMLTableDataCellElement deprecated, preferred HTMLTableCellElement
HTMLTableHeaderCellElement deprecated, preferred HTMLTableCellElement
Typography:
as?: ElementType returns any

Made an issue for the Table #1739

Closing issue as we have identified and created separate issues.


Release hotfix/2.2.3

/push

/push

/push

/publish

/publish

/publish

/push

/publish

/publish

Operator is published now! 2.2.3 is closed.


Research how to simplify the connection between JS and C++ code (considering both ios and android)

Specification
The work from #19 introduced rocksdb, and inherited the architecture from leveldown and rocksdb.
This means that we have roughly 3 layers of abstraction:

The JS side has classes like DB.ts, DBTransaction.ts and DBIterator.ts - this is what is used by the end user of this library
The C++ NAPI binding - this makes use of napi-macros, but doesn't use the node-addon-api framework. This creates a flat list of functions exposed from index.cpp, and these functions manipulate classes like Database, Transaction, these classes embed logic involving the napi system in nodejs, the code here is not portable to the non-node environment
The RocksDB C++ code, this is what actually does all the database work, it just lives in its own environment and exposes all of its functionality over C headers. We compile this from a submodule using node-gyp, and all of its objects are encapsulated in classes in our C++ NAPI binding

There's a couple things here that aren't as robust as they can be:

Instead of using the haphazard napi-macros, let's just use node-addon-api, it seems like a much more comprehensive framework for integrating into nodejs
Lots of places where an asynchronous error/exception may occur is not being checked for, and would result in invisible segfaults or undefined behaviour
Memory management and garbage collection seems duplicated, there's logic on the JS side to manage their objects, and similar objects on the C++ NAPI side to do the same again, this seems repeated
The lack of C++ exceptions makes some interactions awkward, I'd like to use C++ exceptions and connect them to JS exceptions
The ability to use some JS constructs in our NAPI code would be useful, but this may impact portability of the C++ NAPI code, it's already not portable to environments where node wouldn't be available like react native bindings, but we need to be aware of what can be done in android & ios

I have some ideas to make the C++ classes behave more like JS classes, and to use the napi bindings to connect them together. Then instead of exposing raw functions, we just extend the native class constructors with the JS classes. However at the same time, keeping the interface simple might simplify the expectations the JS side has of the C++ side, so that when android/ios work is involved, and napi conveniences are not available, then we have to consider if there's an additional bridge layer like Java or Swift/Obj-C that sits in-between the JS and C++ code.
Additional context

https://reactnative.dev/docs/native-modules-intro
https://reime005.medium.com/react-native-and-c-87a2311dc3d
https://github.com/nodejs/node-addon-api
https://github.com/napi-rs/napi-rs - rust tooling seems so much more elegant, but most likely more immature

Tasks

...
...
...

The rust way of doing things is a far simpler. And NAPI-RS does alot of good things. If we switch to using the rust's rocksdb, we might get around some of the problems.
Of course one has to be aware of the block encryption requirement. Right now no mention of that API support. I created an upstream issue.
Also see:
https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/20171220_encryption_at_rest.md


Convert classsearch to dtf.Module and remove binaries/classsearch.py

Changed: https://github.com/jakev/dtfmods-core/commit/ff7094f41a80f03bda38544b649e7c54cb9a7975


Two error character and font size

It displays special characters incorrectly.
Incorrect

Translation Before.

orginal : Dialogue: 0,0:02:55.38,0:02:59.79,Q0,,0,0,0,,I'm a second-year in high school,\Nand I already know I'll never be interested.
translate: Dialogue: 0,0:02:55.38,0:02:59.79,Q0,,0,0,0,,Lise ikinci sınıftayım \ ve asla ilgilenmeyeceğimi zaten biliyorum.
And it makes the subtitle fonts way too big.
subtitle file
altyazi.zip

I can notice there is a weird character on the translated file

Remove it and it should work (by now, but I'm gonna check this later)


ciao-down: Support VM cloning

Once we support multiple instances it will be nice to be able to create a new instance by cloning an existing one.

Moved to https://github.com/intel/ccloudvm/issues/6


Make xpath verification in $ selector use a xpath validator

Currently the $ selector distinguishes between a css selector or xpath using a string manipulation which does not cover all the cases.. update the check to do a proper xpath validation.

Don't think there is a fast way to check to valid expath without evaluating it against the document. It's better to stick to simple string check.


server/coordinator: fix "divided by zero" error

If the limit is 0, just return the original interval.

LGTM

CI failed

CI failed because of https://github.com/pingcap/pd/pull/519.


Retry upload 3 times in case of failure

Adds 3 tries for retrying to upload in case of failure.

Does not depend on external libraries

Codecov Report

Merging #703 (79d5260) into main (9b8af36) will decrease coverage by 0.69%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   89.63%   88.95%   -0.69%
==========================================
  Files         166      166
  Lines       13272    13262      -10
==========================================
- Hits        11897    11797     -100
- Misses       1375     1465      +90

Impacted Files
Coverage Δ

dataquality/core/finish.py
100.00% <ø> (ø)

dataquality/utils/dq_logger.py
95.23% <ø> (ø)

dataquality/utils/ultralytics.py
55.92% <0.00%> (ø)

tests/loggers/test_tabular_classification.py
100.00% <ø> (ø)

dataquality/clients/api.py
51.59% <75.00%> (+0.11%)
:arrow_up:

dataquality/clients/objectstore.py
47.94% <80.00%> (+4.00%)
:arrow_up:

... and 16 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add a settings cmd to rem, which will be used to set stuff like levels/greetings and so on.

done in indev branch


doc: tweak Zephyr introduction features list

Elevate prominence of some items buried in the services list that are
significant changes introduced in the last few releases.
Signed-off-by: David B. Kinder<EMAIL_ADDRESS>

Codecov Report

Merging #6035 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6035   +/-   ##
=======================================
  Coverage   52.51%   52.51%
=======================================
  Files         406      406
  Lines       39683    39683
  Branches     7715     7715
=======================================
  Hits        20839    20839
  Misses      15663    15663
  Partials     3181     3181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30824c9...cd61688. Read the comment docs.


[out_es] Elasticsearch error

Hello! Deployed EFK and Curator in Kubernetes 1.10. Externally, everything is fine, but in the fluent-bit logs - [2018/06/05 12:21:00] [warn] [out_es] Elasticsearch error
{"took": 38, "errors": true, "items": [{"index": {"_ index": "logstash-2018.06.05", "_ type": "flb_type", "_ id": "Sjvkz2MBucitTSdgq3rn "," status ": 400," error ": {" type ":" mapper_parsing_exception "," reason ":" failed to parse "," caused_by ": {" type ":" i_o_exception "," reason ":" Duplicate field '@timestamp' \ n at [Source: org.elasticsearch.common.bytes.BytesReference$MarkSupportingStreamInputWrapper@31b917f0; line: 1, column: 1257] "}}}}]} and there is no data in the ES.
root@kuberm2:/# kubectl get all -n logging
NAME                             READY     STATUS      RESTARTS   AGE
pod/curator-1527984060-2fq6n     0/1       Completed   0          2d
pod/curator-1528070460-6fkmn     0/1       Completed   0          1d
pod/curator-1528156860-t6tgz     0/1       Completed   0          12h
pod/es-client-db5cc477b-h4z8s    1/1       Running     0          6d
pod/es-client-db5cc477b-x7khj    1/1       Running     0          6d
pod/es-data-0                    1/1       Running     0          5d
pod/es-data-1                    1/1       Running     0          5d
pod/es-data-2                    1/1       Running     0          5d
pod/es-master-6985c67c44-lsz6n   1/1       Running     0          6d
pod/es-master-6985c67c44-rhtnp   1/1       Running     0          6d
pod/es-master-6985c67c44-w5sx4   1/1       Running     0          6d
pod/fluent-bit-6csqn             1/1       Running     0          6d
pod/fluent-bit-qxprd             1/1       Running     0          6d
pod/fluent-bit-t8td7             1/1       Running     0          6d
pod/fluent-bit-v2g4h             1/1       Running     0          6d
pod/kibana-8497d64b4d-fvkz9      1/1       Running     0          5d
pod/nettools-pod                 1/1       Running     0          6d
NAME                              TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
service/elasticsearch             ClusterIP   <IP_ADDRESS>           9200/TCP   6d
service/elasticsearch-discovery   ClusterIP   None                     9300/TCP   6d
service/kibana                    ClusterIP   <IP_ADDRESS>           80/TCP     6d
NAME                        DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/fluent-bit   4         4         4         4            4                     6d
NAME                        DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/es-client   2         2         2            2           6d
deployment.apps/es-master   3         3         3            3           6d
deployment.apps/kibana      1         1         1            1           5d
NAME                                   DESIRED   CURRENT   READY     AGE
replicaset.apps/es-client-db5cc477b    2         2         2         6d
replicaset.apps/es-master-6985c67c44   3         3         3         6d
replicaset.apps/kibana-8497d64b4d      1         1         1         5d
NAME                       DESIRED   CURRENT   AGE
statefulset.apps/es-data   3         3         5d
NAME                           DESIRED   SUCCESSFUL   AGE
job.batch/curator-1527984060   1         1            2d
job.batch/curator-1528070460   1         1            1d
job.batch/curator-1528156860   1         1            12h
NAME                    SCHEDULE    SUSPEND   ACTIVE    LAST SCHEDULE   AGE
cronjob.batch/curator   1 0 * * *   False     0         12h             4d
Help me please

curl -X DELETE 'http://<IP_ADDRESS>:9200/_all'

The error is clear.

Duplicate field '@timestamp'

Whatever is producing to Elasticsearch is doing it wrongly. You should look for issues in that fluentbit component.


Three Build issues in docker

Describe the bug
Trying to do a docker-compose build in the src folder and run into three different errors.
**error 1: yarn.lock cannot be found **
Step 4/29 : COPY package.json yarn.lock ./
1 error occurred:
	* Status: COPY failed: file not found in build context or excluded by .dockerignore: stat yarn.lock: file does not exist, Code: 1

error 2: build fails on node 17, seems to require either 16 or 18
yarn install v1.22.19
info No lockfile found.
[1/4] Resolving packages...
warning next-unused > madge > detective-postcss > postcss-values-parser ><EMAIL_ADDRESS>flatten is deprecated in favor of utility frameworks such as lodash.
warning typescript-plugin-css-modules > stylus > css-parse > css ><EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
warning typescript-plugin-css-modules > stylus > css-parse > css ><EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
warning typescript-plugin-css-modules > stylus > css-parse > css > source-map-resolve ><EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
warning typescript-plugin-css-modules > stylus > css-parse > css > source-map-resolve ><EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
warning typescript-plugin-css-modules > stylus > css-parse > css > source-map-resolve ><EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got "17.9.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
1 error occurred:
	* Status: The command '/bin/sh -c yarn install --frozen-lockfile' returned a non-zero code: 1, Code: 1

error 3: (after removing copy for yarn.lock and updating image to use node v18) get the following
 ./app/(posts)/components/file-dropdown/index.tsx:48:19
Type error: Property 'id' does not exist on type '{ icon: Element; content: string; html: string; }'.

  46 |

  47 | 			{items.map((item) => (
> 48 |

     | 				              ^
  49 | 					<Link href={`#${item.title}`} className={styles.listItem}>
  50 | 						{item.icon}
  51 |
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
1 error occurred:
	* Status: The command '/bin/sh -c yarn build' returned a non-zero code: 1, Code: 1

To Reproduce
run: docker-compose build (in the src folder)
Note: this is a clean env where a local build has NOT been done (git pull, cd src, docker-compose build)
Expected behavior
Docker image build successfully
Screenshots
Output above in the steps
Desktop (please complete the following information):

OS: Ubuntu 22.04

Thanks @ravensorb. I’m currently refactoring Drift and @kinghat is updating the docker stuff here: #135


Only one tuner tunes to 978MHz

Hello,
from the log I can see that my only one tuner does not tune to 1090MHz. I am in Europe, how can I change tunning from 978 to 1090MHz? Thank you
2016/02/26 01:40:01 	GetTunerType: RTLSDR_TUNER_R820T
2016/02/26 01:40:01 	SetTunerGainMode Successful
2016/02/26 01:40:01 	SetTunerGain Successful
2016/02/26 01:40:01 	GetTunerGain: 480
2016/02/26 01:40:02 	SetSampleRate - rate: 2083334
2016/02/26 01:40:02 	GetSampleRate: 2083334
2016/02/26 01:40:02 	GetXtalFreq - Rtl: 28800000, Tuner: 28800000
2016/02/26 01:40:02 	SetXtalFreq - Center freq: 28800000, Tuner freq: 28800000
2016/02/26 01:40:02 	SetCenterFreq 978MHz Successful
2016/02/26 01:40:02 	GetCenterFreq: 978000000
2016/02/26 01:40:02 	Setting Bandwidth: 1000000
2016/02/26 01:40:02 	SetTunerBw 1000000 Successful
2016/02/26 01:40:02 	ResetBuffer Successful
2016/02/26 01:40:02 	GetFreqCorrection: 0
2016/02/26 01:40:02 	SetFreqCorrection 0 Successful

Go to the main webui page (http://<IP_ADDRESS>/).
Tap the version number (middle-top of the screen) 7 times rapidly. This will enable "Developer Mode".
Go to "Settings". Disable 978.


[AI Agent idea] An AI ChatBot that can impersonate historical figures and let users have a conversation with them

Description
Meet TimeTravelerTom, your historical figure chatbot. Interact with past icons, ask questions, and explore history's gems!
Additional Information
@donqu1xotechina

/assign @viditagrawal56

/assign @mdsahilnoob


⚠ Bofrost.at has degraded performance

In 1282bc4, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 974 ms

Resolved: Bofrost.at performance has improved in 890e0de after 6 minutes.


feat: handle zksync direct deploys in deployContract

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR introduces support for deploying contracts on zkSync chains by modifying the deployContract function to handle direct deployments using zkDeployContract.
Detailed summary

Added import for isZkSyncChain and zkDeployContract.
Modified deployContract to check if the chain is zkSync.
If true, it invokes zkDeployContract with appropriate parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5002  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite


[Feature request] Can we have the functionality to change the locations of the download buttons

For example, in the _config.yml, if you enter download_loc: <branch>, the directory of the location will change to [repository URL]/zipball/[branch]

@Sweetboy13735 you can set the download location by setting the following in your config:
github:
  zip_url: URL


handle chunked responses

Apparently this was implemented, but we never flipped the bit to actually use it.

Where are you seeing that? CI shows cargo audit failing.


Collapse - Fix check to not prevent event for input and textarea

Thank you @git-marijus
Close : #22296

Does the test need updating per https://github.com/twbs/bootstrap/issues/22296#issuecomment-289909869?

I improved my unit test

In you new unit test you just added assert.ok(e.isDefaultPrevented() === false) that test if the shown.bs.collapse event is prevented. That will never be prevented.
Your modification in the code prevent the event from Event.CLICK_DATA_API.
They are not the same event. Your test still doesn't do what you intend.
You should test if the <div id="collapsediv1"/> has the class show instead, to make sure that the click on the checkbox did expand the collapsible area

Thank you @vanduynslagerp 👍 Time for me to sleep I make to much mistakes tonight


Don't mark blocks before latestValidHash as fully validated

PR Description
While latestValidHash guarantees that every block after it is invalid, there are cases where the EL may not have fully executed the block returned as latestValidHash (typically because it's on a non-canonical fork). As such it is not safe to mark those nodes as fully VALID and they should be left as optimsitically imported.
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Ok, I see that some ELs are not guaranteed to follow the spec and it's a good protection in this case


kapp rename should support optional --new-namespace

this would help scenarios where state configmap was dropped into a wrong namespace.

Only, the state configmap should be renamed. Label stays the same.

few more things,

How should the history be treated.
should the history be also moved across namespace?

available in release v0.40.0


Fix some type errors

does ci check these typings?

nope, there's hundreds more type errors. This just makes vscode less red


Roll engine e1599ccd3f89..e3772232c2d2 (2 commits)

https://github.com/flutter/engine/compare/e1599ccd3f89...e3772232c2d2
git log e1599ccd3f89943a11c89ac8a31cc7d3edd72073..e3772232c2d24c174beac7ef03dff63907cdda46 --no-merges --oneline
e3772232c Roll src/third_party/dart 82c8c78739..b48c8b1d1c (5 commits) (flutter/engine#9021)
14912e8e1 Roll src/third_party/skia d93ee53affd3..dbc3caaf6c3d (9 commits) (flutter/engine#9024)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Spelling error in taxonomie

Hi @ShKlinkenberg,
There is a spelling error in the tags. Instead of "Interpretating graph/output" it should be "Interpreting graph/output". (see https://github.com/ShareStats/Statistics_Taxonomy/blob/main/source/Taxonomie ShareStats versie 17 maart 2021.xlsx?raw=true) As a consequence, the error also on the website and our app and the misspelled tags is probably already in many item of the sharestats database. How shall we deal with this error?
Oliver

No to self. Write a script to check if the wrong spelling has been used in the item development and correct it.


nocode(traverse): code comments

#3434  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Unable to connect to GSC

I added all required variables and it logs:
2023-04-23T23:14:05.451004008Z [0] [ERROR] Search Console API Error for site.com (3days) : undefined undefined
2023-04-23T23:14:05.451859598Z [0] [ERROR] Search Console API Error for site.com (7days) : undefined undefined
2023-04-23T23:14:05.452633155Z [0] [ERROR] Search Console API Error for site.com (30days) : undefined undefined
2023-04-23T23:14:05.453519311Z [0] [ERROR] Search Console API Error for site.com (30days) : undefined undefined

Could Not fetch Keyword Data for this Domain from Google Search Console. is what shows on site.

I got all variants and I added the console api email to all with full access. I am using similar with SEOPress and there insights works well.
I see this is an area to improve a bit. As of first 3 hours of testing since I deployed all works well, beside the Console integration.

@uhlhosting have you managed to get it working?

Can you guys please make sure you are connecting a domain property and not a URL property.

Can you guys please make sure you are connecting a domain property and not a URL property.

what do you mean? on serpbear? i've added "mydomain.com"

In step 4 of this tutorial: https://docs.serpbear.com/miscellaneous/integrate-google-search-console Mak sure you select your Domain Property and not a URL property. eg: mydomain.com as opposed to https://mydomain.com/

In step 4 of this tutorial: https://docs.serpbear.com/miscellaneous/integrate-google-search-console Mak sure you select your Domain Property and not a URL property. eg: mydomain.com as opposed to https://mydomain.com/

Oh yes, i used a Domain property.
By the way this no longer exists or i couldn't find it:
2. Go to the Settings page, and click the "Users & Permissions" menu.
3. From the Users and permissions page, click the "Add User" button.

 I coulnd't find this option before:

Go to the Settings page, and click the "Users & Permissions" menu.
From the Users and permissions page, click the "Add User" button.

And i thought it was from an old interface and no longer needed. But i've seen it now! Added the email and all is working fine! Thanks!

Great to hear that!

@uhlhosting have you managed to get it working?

No I did not...

Great to hear that!

Is not working for me alto. I have added the mail to all domains variants I have. Scdomains: and two variants of domains.  How are you running the app? through docker or directly pulling the repo and running locally?

running

The app runs in caprover already explained above. So its using docker. With env variables shown above. The issue is the way you add the secret keys from google in env variables. My opinion these should not be as variables. Anyhow all the logs are there. I asked you how did you made the google key in one line. No reply to that. Indeed is hard to debug it when there are no docs on this. And you maybe do not noticed my previous video.

@uhlhosting Were you able to identify and fix the issue?

@towfiqi Yes, the issue was that i followed the form from the docs and that was a bit missleading. It seems that caprover supported the entire gcp key without modifications I made myself such as adding \n \n at the end and \ at first. Then I checked the caprover config and noticed these were duplicated. So I simply input the whole key pasted from the json and it started working!

Any suggestion on updating/modifying a specific portion of the doc in a specific way?

Any suggestion on updating/modifying a specific portion of the doc in a specific way?

@towfiqi Maybe just add a note in docs stating that people should paste the entire key from gcp unmodified. And mention that usualy docker here by the case adds by itself required to extra lines.

Why am I getting this error when integrating google search console. Following the steps exactly.
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (3days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (7days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden


Change to class

Updating the module to use the Class format

Thanks for doing this cleanup, @SparshithNR.

@stefanpenner @rwjblue I think this can be merged, no?

https://github.com/stefanpenner/broccoli-persistent-filter/pull/178#discussion_r354116126
Addressed with rebasing


Add mutli ack to AckHandler

Add multiple ack for AckHandler.
Refactor it to make it consistent with RT version

Note
There is a behaviour difference in AckHandler between SDK version and RT version:
When timeout, RT AckHandler will cancel the task, ref here.
While SDK AckHandler will set its result with AckStatus.Timeout rather than cancelling it, ref here

Refactor it to make it consistent with [RT version]

Is this a breaking change from SDK's perspective of view?

Refactor it to make it consistent with [RT version]

Is this a breaking change from SDK's perspective of view?

AckHandler is an internal class. I think it's not.

While SDK AckHandler will set its result with AckStatus.Timeout rather than cancelling it

So now ackHandler callers needs to catch the CancelldException?

While SDK AckHandler will set its result with AckStatus.Timeout rather than cancelling it

So now ackHandler callers needs to catch the CancelldException?

No, In SDK, AckHandler won't cancel the task when timeout. So catching CancelldException is not needed. It will set a result whose value is AckStatus.Timeout


Add non-core project "Synapse" to serverless workflow organization

Over the time we have built an eco-system around our specification which includes things like SDKs, Editor extensions, diagram generators etc. In order to grow it would be very beneficial to also include open-source runtime implementations which would like to be part of our project and hosted in our github organization.
@Neuroglia has kindly offered to donate his "Synapse" .NET 5.0 runtime implementation to our project.
This runtime can grow as part of our eco system.
I have prepared the https://github.com/serverlessworkflow/synapse repository for the project, pending this maintainers vote.
The project is intended to follow same rules as any other part of our specification eco system.
Our intention is as always to promote all runtimes that implement our specification, and also open the door for open-source runtimes to be part of our eco system. We are glad that we have the opportunity to start this with Synapse and open the door for more open-source runtimes that focus on the implementation our specification to join if they wish.
2 maintainer's LGTM required (2/3)

[x] Tihomir Surdilovic
[x] Manuel Stein
[x] Ricardo Zanini

LGTM

[...] an eco-system around our specification which includes things like SDKs, Editor extensions, diagram generators etc. [...]
The project is intended to follow same rules as any other part of our specification eco system.

I like this proposal, because

it names Synapse a sub-project of the Serverless Workflow Specification, same as SDKs, editor extensions, diagram generator
as such, it follows the CNCF model (CLA/signed commits, governance, code of conduct)
reporting in Serverless Workflow community calls
has its own release cycle, etc.

Hosting an implementation can be considered an endorsement or a promotion, so we should keep this in mind when linking implementations. It should not have a special status as compared to other runtime implementations.
Sorry I had suggested "reference implementation", on second thought that term has way too many connotations. So, I think sub-project is fine.
LGTM

I agree with @manuelstein. I don't think "reference implementation" should be a good term, but since it's under the Serverless Workflow umbrella, people can understand as it is. We might need to reinforce that it is not.


symbolic link to directory: ERROR: _scan_new_dir: Cannot go into subdir

Operating system or device - Godot version:
Arch Linux - 5545afd52b912722bbdb6e412cce9593857c5726
Adding a symlink to a directory to the project folder does not work and
throws
ERROR: _scan_new_dir: Cannot go into subdir
At: tools/editor/editor_file_system.cpp:660.

happens to me all the time atm in v2.1.3,
godot is descent on all files of my home directory,
on top of that it's trying to read arbitary xml files
ERROR: _scan_new_dir: Cannot go into subdir: ...
   At: editor/editor_file_system.cpp:614.

ERROR: open: Unrecognized XML File: res://Documents/python-docs/_static/opensearch.xml

this seems to happen mainly after i load a scene
i have the godot binary in ~/Godot/Godot and the projects next to the binary ~/Godot/projects/

#8144 has solve this issue for me, @akien-mga maybe you can close this ?

Will close as fixed, comment if it's not the case.


Confusion from Creating Linux Server

In "Quickstart: Create a Linux server VM by using the Azure Stack portal."
The link guides to deploy Ubuntu VM from market place. But in the real scenario, specific linux Ubuntu VM should be deployed for the AKS Engine which is "AKS Base Ubuntu 16.04-LTS Image Distro, October 2019"
If I follow the guides exactly, I will be deploying normal Ubuntu VM instead of AKS Base image.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d8c6cbd-54d8-9746-a1f8-a618b98e011e
Version Independent ID: 479c631e-b7a4-c5cf-160d-141d336ad50a
Content: Install the AKS engine on Linux in Azure Stack
Content Source: azure-stack/user/azure-stack-kubernetes-aks-engine-deploy-linux.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

@HassanAlmanasrah
Thanks for your feedback! We will investigate and update as appropriate.

@HassanAlmanasrah , In the doc where you see the link to deploy Ubuntu VM should be fine as you are not deploying the ASK VM at this step. It is a client VM on which you install AKS engine and other necessary tools to connect to AKS VM. In the next doc, you can see steps to deploy the AKS VM which will have the base OS as "AKS Base Ubuntu 16.04-LTS Image Distro, October 2019"
Let me know if you have any further questions.

Thanks Karthik
I had the impression that it is mandatory to use AKS Base for the AKS Engine, while from the below, AKS Base is used for the nodes not the engine.
Best Regards
Hassan
From: KARTHIK SRINIVAS<EMAIL_ADDRESS>Sent: Monday, December 23, 2019 11:06 AM
To: MicrosoftDocs/azure-stack-docs<EMAIL_ADDRESS>Cc: Hassan Almanasrah<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-stack-docs] Confusion from Creating Linux Server (#556)
@HassanAlmanasrahhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHassanAlmanasrah&data=02|01|hassan.almanasrah%40microsoft.com|3392314e9c814a18b5b508d78787460a|72f988bf86f141af91ab2d7cd011db47|1|0|637126887375012425&sdata=9vayHUAiip2sj5SHXMSUFB%2Bnpayn7kSCwP%2BtosykYjw%3D&reserved=0 , In the doc where you see the link to deploy Ubuntu VM should be fine as you are not deploying the ASK VM at this step. It is a client VM on which you install AKS engine and other necessary tools to connect to AKS VM. In the next doc, you can see steps to deploy the AKS VM which will have the base OS as "AKS Base Ubuntu 16.04-LTS Image Distro, October 2019"
Let me know if you have any further questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-stack-docs%2Fissues%2F556%3Femail_source%3Dnotifications%26email_token%3DANADCYQ2O37OVMWUA5O7KPLQ2B5N7A5CNFSM4J6MNYI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHQUCAY%23issuecomment-568410371&data=02|01|hassan.almanasrah%40microsoft.com|3392314e9c814a18b5b508d78787460a|72f988bf86f141af91ab2d7cd011db47|1|0|637126887375012425&sdata=QtiXd5I%2FgdFP5ZaWsNArE%2FCc9xGL1HiWznb0%2Bt3QTH0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANADCYSEXDCY5JNHLKWZ5ELQ2B5N7ANCNFSM4J6MNYIQ&data=02|01|hassan.almanasrah%40microsoft.com|3392314e9c814a18b5b508d78787460a|72f988bf86f141af91ab2d7cd011db47|1|0|637126887375022382&sdata=r2%2BXuq6GBOp4i4Q7bYpWb0UTLQLXhahzQ58nud8s2ow%3D&reserved=0.


python example fps

This is more of a general question, so feel free to close after answering. Is your python example with pygame capable of rendering games such as pokemon gold/silver at a framerate of 60 fps or more? My update loop looks like this roughly:
gameboycore.handle_vblank_callback(vblank_cb)
gameboycore.handle_scanline_callback(scanline_cb)
while True:
    handle_input()

    vblank = False
    while not vblank: # vblank set to True using vblank callback
        gameboycore.update(1)
    render_frame()
    swap_buffers()

I've compiled a few c++ examples of yours and my own and I can run the emulator at 60 fps pretty easily, but having a hard time getting my python example to run over 30 and sometimes it grinds to a halt around 2 fps.

The pygame example was more of a proof of concept that I made. The example isn't really that optimized.
Though I would recommend running the core more than 1 cpu step per iteration. I intend on adding a "running to vblank" function at some point.


find_robots_txt check does not work with redirects or reflect the test description

The find_robots_txt check does not work properly with redirects.
The description states
        Iterates through all service_sites in each RwsSet provided, and makes
        a get request to site/robots.txt for each. This request should return
        an error 4xx, 5xx, or a timeout error. If it does not, and the page
        does exist, then it is expected that the site contains a X-Robots-Tag
        in its header. If none of these conditions is met, an error is appended
        to the error list.

However the code only makes a request to the root, it does not first check for a 4xx/5xx against the service domain.
r_service = requests.get(service_site, timeout=10)

If a redirect (per the guidelines) is in place then the headers being checked are for the destination domain, not the service one.
I'm working to set up for our service domains to meet the requirements but running into issues because of the structure of this test and am waiting to finalize the setup until I know the expectations of the check.

I found https://github.com/GoogleChrome/related-website-sets/pull/28 which caused this breakage and made the comment out-of-date.
I think the solution here is to either allow robots.txt files that have noindex / none rules OR require check that the root of the domain returns a X-Robots-Tag header.


Can we use python 2.7 in Window 10 to operate this repo?

Python 2.7 is NOT supported. We didn't test our code on Windows 10 and I can't guarantee that.

okey thanks for your reply
On Wed, Sep 25, 2019 at 1:23 PM Tianheng Cheng<EMAIL_ADDRESS>wrote:

Python 2.7 is NOT supported. We didn't test our code on Windows 10 and I
can't guarantee that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HRNet/HRNet-MaskRCNN-Benchmark/issues/6?email_source=notifications&email_token=AISXSMADNGVXRW7XQW5EDEDQLMNYPA5CNFSM4IZ4V3X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RBPNQ#issuecomment-534910902,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AISXSMBTEWOWVO4D4TKUQVLQLMNYPANCNFSM4IZ4V3XQ
.


optimize sampler cumsum

Speeding up cumsum in top_p sampling with upper triangular matrix multiplication. The idea originally comes from the 13th item of https://zhuanlan.zhihu.com/p/673671771.
As we know, torch.cumsum uses cuda core, while matmul uses tensor core. Typically, tensor core is much faster than cuda core. Therefore, we use upper triangular matrix multiplication to calculate the cumsum in top_p sampling. This change decreases top_p sampling time from 6.8ms to 1.4ms for Llama-13B, whose vocab size is 32000. Here are our test settings:

GPU = 1 A100-80G
model = Llama-13B
vocab size = 32000
vllm = 0.2.7
top_p = 0.80
input length = 300
output length = 200

Nsys Perf
Before Optimization

After Optimization

Latency

QPS
Latency before opt (s)
Latency after opt (s)
Latency decrease (%)

1
4.9314 s
4.6609 s
5.48%

2
5.7945 s
5.4266 s
6.34%

4
7.9615 s
7.5823 s
4.76%

Hey, that looks really cool!

@HandH1998 would it be possible to add a unit test to ensure consistency between your implementation and torch? I would suggest generating random data for like 256 set seeds and asserting that results are all close.

We are pleased to add a unit test, using upper triangular matmul to calculate prefix sum is mathematically equivalent to cumsum.

@Yard1, hi, we have added a unit test to ensure consistency between two implementations. There are two points that need to be explained:

When the dtype is torch.float32, the two implementations are always consistent.
When the dtype is torch.float16 and vocab_size is large (>=5000), they give different results. We think it is because that there are more overflows for torch.float16 in our unit test. As the probability distribution in practical LLM sampling is much sharper (the top-k tokens may occupy the main probability), we think the new implementation can still work in practice.

@HandH1998 Thanks, could you merge upstream into your branch to run the CI?

@Yard1, we have merged upstream to our branch. But there is a case that failed when running tests/samplers/test_sampler.py::test_sampler_top_k_top_p for 'seed =  93`.

However, it can pass all the cases of the unit test in our machine (as the following picture). It is a little weird. Hope you can check it.

@Yard1, hi, could you please help us with the unit test issue? For example, you can run the unit test in your environment to see whether the failed case can reproduce. Thanks!

@HandH1998 Sorry, let me take a look at this soon! We may just need to relax the tolerances

Hi, have you relaxed the tolerances? Could you please give us any other advice?

@HandH1998 Sorry, let me take a look at this soon! We may just need to relax the tolerances

Hello, could you please give us more advice about this PR? Look forward to your reply!

Let me prioritize this on Monday, apologies for the long wait.

@HandH1998 As long as the fp32 test is passing, it should be fine. What I would suggest is keeping a tighter tolerance for fp32 and relaxing the tolerance for fp16.

@Yard1 Hello, thanks for your reply! I have two points to discuss.

The unit test failure is at test_sampler.py::test_sampler_top_p_top_k(as you can see in https://github.com/vllm-project/vllm/pull/2510#issuecomment-1918470080) which is not our new added unit test funciton. We don't think it should be modified by us. Thus, we hope you can relax the tolerance for test_sampler.py::test_sampler_top_p_top_k in github cr.

As for our unit test function test_sampler.py::test_optimized_cumsum, I will try to do as what you suggest, i.e.,  keeping a tighter tolerance for fp32 and relaxing the tolerance for fp16.

 I wouldn't be comfortable merging with such a huge divergence.

@Yard1 Hi, thanks for your test! I was wondering if this test was done on your machine or github cr env? In my test, both hf_probs and sample_probs have something like 0.5117 which is not equal to 1.0, but there is no such a huge divergence like what you found. As a result, all the cases of test_sampler_top_p_top_k can pass the test in my machine. It is so weird. I still need time to figure it.

@HandH1998 I ran this on an A10 GPU

@Yard1 I fixed the softmax dtype to torch.float in _apply_top_k_top_p(https://github.com/vllm-project/vllm/pull/2510/commits/f9b945521cd99b8542d83343fdcb4007c2e16091). It can work now. I wonder if the change is accepted.

@Yard1 Hi, I have fixed the unit test issue in my latest commit. Please review it when you are free. We will appreciate it if you could give us some other advice!

@HandH1998 can you confirm it still brings a performance benefit?


Create template for index/home page

Currently serves up the base template.  Create an index page template and serve that up instead.

Created template to begin adding things to homepage


Updated Documentation README.md

Hey maintainer,
There were some minor grammar fixes, so I fixed them, Kindly merge my PR if everything looks good.

Thank you @gkanishk !


Should put comments in tests

This would improve readability and understandability.

Added comments to tests in V1.7


ng8 update ng9 error:

hello, ng8 to ng9, Report an error after upgrading

[ ]

ng8 is ok，
in xxx.d.ts use:

Thank you!

package.json :


support transformation functions

Currently leaves outputs prediction as a raw score. Client code should transform it to probabilities (logistic), lambdarank and so.
Let's introduce this ability to leaves.
Short list for XGBoost:

"binary:logistic"
"binary:logitraw"
"multi:softmax"
"multi:softprob"
"reg:linear"

Short list for LightGBM:
todo

partially done in #54
but not all transformation functions were implemented. Currently here are logistic & softmax transformations for Lightgbm and XGBoost.
Close for now


Bio Weekly - Percent Suverys Submitted in 0-3hrs; Timetrend for UCHI, HFH, and SFH

Generate a line graph that shows the percentage of surveys submitted within 3 hours of visit check-in for UChicago, Henry Ford, and Sanford. Collections started on 7/11/22, making survey data became available at the same time.
Notes:

This figure should be inserted below the Baseline Research Biospecimen Survey Completion Time from Visit Check-In Time (Post-COVID-19 Questions Removal) table in the weekly metrics report.
Renumber all figures following the addition of this figure.

Requestor(s): Biospecimen Team
Table or Figure title: Figure 4: Weekly Percent of Biospecimen Surveys Submitted within 3 Hours of Visit Check-In
Metrics to be updated or created: Create new figure
Variables needed (include variable name and Concept ID):
Refer to code for metric table Baseline Research Biospecimen Survey Completion Time from Visit Check-In Time (Post-COVID-19 Questions Removal) in the weekly metrics report for "0 hrs to 3 hrs" calculations.
Specify numerator and denominator by variable name where applicable: N/A
Mock-up table if applicable:

Approved by:

*Issue not urgent

@HopkinsDC

@KELSEYDOWLING7 please remove HealthPartners and Marshfield from the graph.

@HopkinsDC

@KELSEYDOWLING7 I didn't anticipant this graph being a little difficult to read; can this be made into 3 separate plots (one for each site)?
The titles can be updated to include the site name; for example:
(1) Weekly Percent of Biospecimen Surveys Submitted within 3 Hours of Visit Check-In, Henry Ford Health System
(2) Weekly Percent of Biospecimen Surveys Submitted within 3 Hours of Visit Check-In, Sanford Health
(3) Weekly Percent of Biospecimen Surveys Submitted within 3 Hours of Visit Check-In, University of Chicago Medicine

@HopkinsDC

@KELSEYDOWLING7 Thanks, Kelsey! One last question: is there a reason why the trendlines return to 0% between each weekly percentage? Can that be adjusted to be a continuous line between each weekly percent?

@KELSEYDOWLING7 Excellent, thank you!
These plots can go into the next weekly report (8/28).


Wrapper 4.1-4.8 cause SSL handshake failure MacOs

Updating a project from 2.3 to 4.8...
Installed 4.8 using homebrew, generated a new wrapper
wrapper --gradle-version 4.8
./gradlew tasks
leads to
Exception in thread "main" javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at sun.security.ssl.Alerts.getSSLException(Alerts.java:192)
at sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1959)
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:328)
at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:322)
at sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1614)
at sun.security.ssl.ClientHandshaker.processMessage(ClientHandshaker.java:216)
at sun.security.ssl.Handshaker.processLoop(Handshaker.java:1052)
at sun.security.ssl.Handshaker.process_record(Handshaker.java:987)
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1072)
at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1385)
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1413)
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1397)
at sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:559)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1564)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1492)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:263)
at org.gradle.wrapper.Download.downloadInternal(Download.java:66)
at org.gradle.wrapper.Download.download(Download.java:51)
at org.gradle.wrapper.Install$1.call(Install.java:62)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:69)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:107)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
how ever
gradle wrapper --gradle-version 4.0
./gradlew tasks works just fine.
4.1-4.8 all produce the same exception.
./gradlew -version
Gradle 4.0
Build time:   2017-06-14 15:11:08 UTC
Revision:     316546a5fcb4e2dfe1d6aa0b73a4e09e8cecb5a5
Groovy:       2.4.11
Ant:          Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM:          1.8.0_161 (Oracle Corporation 25.161-b12)
OS:           Mac OS X 10.13.5 x86_64
gradle -version
Gradle 4.8
Build time:   2018-06-04 10:39:58 UTC
Revision:     9e1261240e412cbf61a5e3a5ab734f232b2f887d
Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM:          1.8.0_161 (Oracle Corporation 25.161-b12)
OS:           Mac OS X 10.13.5 x86_64
gradle works just fine.  Also I get the same error when trying to run -version, so seems to be crashing when gradlew tries to download a new version, 4.1-4.8.

@djkingCanada Thanks for reporting! We're already working on a fix for 4.8.1 in #5734.

That looks like a different problem. #5734 only enables TLSv1.2 support for JDK 7.
And here the error is with JDK8.
@djkingCanada:
Are you behind a company proxy? Which URL is this trying to hit?

@ljacomet You're right, I missed the JDK 8 part.
This looks more like a problem with SSL certificates on the JDK you're using. But as @ljacomet mentioned, we first need to know which URL is problematic. Looks like it's downloading a distribution via the wrapper so it's probably https://services.gradle.org/distributions/gradle-4.8-all.zip.
@djkingCanada Please confirm.
Once we do, here's how to list the available CA certs:
keytool -list -keystore $JAVA_HOME/jre/lib/security/cacerts

Downloading https://services.gradle.org/distributions/gradle-4.8-bin.zip
is the line before the exception, so I think that's what it is trying to do.
keytool dump:
certs.list.txt

I'm in a corporate env, so firewalls but no proxy that I'm aware of.

Not sure why 4.0 worked, but I'm not getting this if I try the 4.0 all version, so looks like it is a generic pix issue an not a code change that was introduced in the wrapper.

Strange. Have you tried a different JDK?
Could you download SSLPoke from here and the following?
java SSLPoke services.gradle.org 443

SSLPoke works just fine on java SSLPoke services.gradle.org 443
Going to use HTTP in wgradle.properteis and move on.

Also had the issue with JDK 9, and when I connected my laptop to my cell phone hotspot, so it's not a VM / corporate network issue.

Are the Java installations vanilla or provided by your company?
Also, it will be very hard for us to even look at this problem without either a reproducible test case or a detailed analysis of the SSL failure.
Turning debug on might be a good idea for that second point with -Djavax.net.debug=ssl:handshake:verbose or -Djavax.net.debug=all

JDKs are straight for Oracle, latest and greatest for 8 (Updated after reporting the issue)  and 9.  I'll try the debug statements.

Here is debug log of the failing handshake, using 4.7 as I have 4.8 cached now :)
handshake.txt

So I took a look at the download code for Wrapper and it just does a URL.open() so I thought I'd give that a try, and was able to dump the HTML from the https://services.gradle.org site no problem, here is the log of that handshake:
Handshake-good.txt
I have a work around using wrapper.properties to avoid HTTPS, but I <3 gradle so if I can help it be more reliable I'd love to help.

I checked no init scripts.

With both handshakes, it is obvious where the problem lies.
Compare this from the failing connection:
Reload the trust store
Reload trust certs
Reloaded 2 trust certs
adding as trusted cert:
  Subject: CN=Shaw Prod Issuing CA 1, DC=PRD, DC=AD
  Issuer:  CN=Shaw Prod Root CA
  Algorithm: RSA; Serial number: 0x1a6604ac00040000000e
  Valid from Tue Jun 30 10:08:06 MDT 2015 until Mon Jun 30 10:18:06 MDT 2025

adding as trusted cert:
  Subject: CN=Shaw Prod Root CA
  Issuer:  CN=Shaw Prod Root CA
  Algorithm: RSA; Serial number: 0x5708248916f58dbe472615041ed2f22c
  Valid from Wed May 26 14:36:11 MDT 2010 until Sat Jun 30 08:57:04 MDT 2035

with the following from the good connection:
trustStore is: /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre/lib/security/jssecacerts
trustStore type is : jks
trustStore provider is :
init truststore
adding as trusted cert:
  Subject: CN=Equifax Secure Global eBusiness CA-1, O=Equifax Secure Inc., C=US
  Issuer:  CN=Equifax Secure Global eBusiness CA-1, O=Equifax Secure Inc., C=US
  Algorithm: RSA; Serial number: 0xc3517
  Valid from Sun Jun 20 22:00:00 MDT 1999 until Sun Jun 21 22:00:00 MDT 2020

adding as trusted cert:
  Subject: CN=Entrust Root Certification Authority - EC1, OU="(c) 2012 Entrust, Inc. - for authorized use only", OU=See www.entrust.net/legal-terms, O="Entrust, Inc.", C=US
  Issuer:  CN=Entrust Root Certification Authority - EC1, OU="(c) 2012 Entrust, Inc. - for authorized use only", OU=See www.entrust.net/legal-terms, O="Entrust, Inc.", C=US
  Algorithm: EC; Serial number: 0xa68b79290000000050d091f9
  Valid from Tue Dec 18 08:25:36 MST 2012 until Fri Dec 18 08:55:36 MST 2037

adding as trusted cert:
  Subject: CN=SecureTrust CA, O=SecureTrust Corporation, C=US
  Issuer:  CN=SecureTrust CA, O=SecureTrust Corporation, C=US
  Algorithm: RSA; Serial number: 0xcf08e5c0816a5ad427ff0eb271859d0
  Valid from Tue Nov 07 12:31:18 MST 2006 until Mon Dec 31 12:40:55 MST 2029

[edited because quite long]

adding as trusted cert:
  Subject: CN=COMODO ECC Certification Authority, O=COMODO CA Limited, L=Salford, ST=Greater Manchester, C=GB
  Issuer:  CN=COMODO ECC Certification Authority, O=COMODO CA Limited, L=Salford, ST=Greater Manchester, C=GB
  Algorithm: EC; Serial number: 0x1f47afaa62007050544c019e9b63992a
  Valid from Wed Mar 05 17:00:00 MST 2008 until Mon Jan 18 16:59:59 MST 2038

[end removed because really long]

and that COMODO ECC Certification Authority is the root certificate for  https://services.gradle.org.
So you need to figure out why when running Gradle you end up with a different truststore.
I am going to close this as it really does not look like a Gradle issue but rather an environment issue.

@djkingCanada have you found the solution