[WIP] ENH+FIX: select excluded components by clicking on the ic title

@cbrnr
This is already contains title interactivity (was easy once @larsoner suggested using ax.title). Check if that works for you. We can consider whether gray is visible enough, but I think it is ok.
[WIP] because I'll add a test once you approve how it works in general.
edit: closes #4792

@larsoner Sure, I will - that's what I meant in the first post here.

This will be good to have!

This works really nicely! It would be nice if components could be selected even when no inst is passed though.

Also, 'gray' is fine. Could you please update the docstring of mne.viz.topomap.plot_ica_components? Maybe a new notes section explaining the interactivity would be good.

@cbnr Right, I'll do that soon.

@cbrnr
now title interactitivity does not depend on passing inst, I'll add docs later. Apart from the note, as you mention, I feel this should be mentioned in the ica tutorial.
@larsoner
added a _fake_click test, passes locally, but travis should fail on osx as it does on other PRs.

@mmagnuski nice, works like a charm!

@larsoner
Unfortunatelly the test does not work - on my computer adding 0.1 to y pos I got from title.get_position() worked well, but it doesn't on travis. I'm afraid I'd have to test a few values to finally hit the title... Any idea how to do it better?

Can you extract the bounding box of the title, then transform the center of that to figure coordinates (or axis coordinates, or whatever _fake_click needs)?

@larsoner
I'll try that!

I thought I was on the right track with midpoint = ax.title.get_window_extent().extents.reshape((2, 2)).mean(axis=0)
but I was working from a different computer and found that _fake_click seems to be broken on matplotlib 2.1.
I managed to fix it by constructing a MouseEvent and passing to canvas.button_press_event but then for some reason the y value gets inverted by the MouseEvent (it is turned to height - y).
I fixed that too by calculating y as height - y (so that it gets turned back to y) and now it works ok.

But that was an unexpected journey :)
I'll submit another PR tomorrow to fix _fake_click for new matplotlib, but before: @cbrnr - could you verify that _fake_click gives you errors? You can test it this way:
from mne.viz.utils import _fake_click
fig = ica.plot_components(picks=range(15))
_fake_click(fig, fig.axes[3], (0., 0.))

I'm on 2.1 on OSX and 2.2.dev on Linux IIRC and the mne/viz tests on master pass for me both places. Maybe there is a bug in the release.
Which viz tests fail for you on master? Or is it just what you've added in this PR? (It seems like if _fake_click were broken it would break some master tests.)

@mmagnuski no, _fake_click works for me, both with 0.15.2 and master. In your example snippet, I can simulate clicking on the title of IC008 with _fake_click(fig, fig.axes[3], (0.5, -0.3)).

Eh, that is really weird, I restarted the kernel many times to make sure the error is real. I will try in another env. There is only one thing I will need to add in the _fake_click, namely no transform of passed data point. I will see.

I tested that on another computer and it should work now.
Funnily enough on that computer I have some other weird problems where mne is not found from the console but found in jupyter notebook (although the same python env) and the reverse happens for another package...

@larsoner
All green now apart from OSX, I'll add docs and whats new soon.

please pull my 2 commits at : https://github.com/agramfort/mne-python/tree/ica_interactive_title_click
f45062c5910b19dc4a14da7ebe238f439de9f558
and
6378396224ef0877c00fc883841cd4de722894fa
I had a productive flight !

@agramfort
Cool, I will get to it tomorrow!

@mmagnuski let me know when you've integrated the changes and I can give it a final test spin.

Yes, thanks for reminding, I should have time tomorrow

@cbrnr You can test the title interactivity. Sorry it took so long.
I'm ready for comments and I'll change the whats new soon.

(sorry for the merge commit that propagates forward)

Can you fix it? Something is wrong, this PR is +2,469 −751

ouch, I see it now, really ugly, yeah I'll try to fix that.

@larsoner Any tips? :)

I would try to revert (using git history commands) to before it was broken. Then I would probably squash all my commits to one (this reduces the number of conflicts to fix). Then I'd rebase this on upstream/master rather than merge.
Or, if you don't have a lot of commits, you can start with a new clean branch based on upstream/master, and cherry-pick your commits, fixing conflicts along the way. But this will be more annoying because there  may well be more conflicts. But if they are just with whats_new it's not so terrible.

@larsoner Hm, I'm not sure if what I did is correct because I see no changes here. I've created a new local branch, cherry-picked the relevant commits from my old branch that got messed up (because I pulled from remote branch, I forgot to force push) but now when I try to force push:
git push -f -u github ica_interactive_title_click

I only get this:
Everything up-to-date
Branch 'ica_interactive_title_click' set up to track remote branch 'ica_interactive_title_click' from 'github'.

Ok, all my problems stemmed from naming issues (different local branch name and remote). Previously I was setting the remote tracking to a different branch than the one I was on and even after setting my local branch to track the remote, git didn't allow me to push. 👽
All is good now, I'll add a whats new update in the evening.

@agramfort @cbrnr @larsoner
Ok, I'm ready, PEP8 fixed (although it seems to have spilled over from some other changes) and whats new added.

CI errors are unrelated (in both cases: urllib.error.HTTPError: HTTP Error 503: Service Unavailable when running mne/tests/test_utils.py:487: in _test_fetch).

Except for my minor comments LGTM! This is really nice! Thanks for implementing this @mmagnuski!

fine with me

Thanks @mmagnuski

🚀 Thanks!


fix TypeError: get_embedding() missing 1 required positional argument

fix TypeError: get_embedding() missing 1 required positional argument

Thank you for catching this, and making this PR :)
Appreciate it!
Been trying to juggle this along with my day job 😅 .


fix doxygen version

Description
Enable building the dockerfile by updating the doxygen version.

Merging as CI passed on the closed ticket #566 and it is a CI related change


add missing useI18n export

Checklist

[x] I have :tophat:'d these changes
[ ] I have updated relevant documentation

/shipit


fix publish image step with dockerhub credential

To fix https://github.com/rancher/rancher/issues/11993
using the plugins/docker image to do publish and it is related to an upstream issue https://github.com/drone-plugins/drone-docker/issues/52#issuecomment-215611889 that setting the registry option with index.docker.io will fail.

LGTM

LGTM


Remove Node as dependency

Why
The new rails way removes any dependency from NodeJS
Who Benefits?
Anyone using our template as we won't have to deal with the rabbit hole of dependencies and tools

I have some concerns about the Node linter tools that we use in the development environment like

stylelint for CSS
eslint for JS

These tools help to keep the CSS and JS files consistent in code format and rule; without Node, we won't have that, so it's the trade-off here.
Another issue is, as we will rely on the CDN (Rails default uses https://jspm.org/) for the third-party package, for example, Bootstrap, it's rare, but the CDN could be down, and for that, our app won't work as expected. That is another trade-off as well.

While there are indeed some big concerns to tackle, it could be interesting to create an Engineering Showcase about it. This way we can better experiment with the ways to handle that.
Looking at the Signup page of hey.com (which applies the "No Build" approach), all the JS/CSS files are not built, yet loaded from the assets folder (no CDN).
As for code lint, 80% of the conventions can be applied with Prettier (even if this is NOT a linter!). It is a big topic, but worth exploring too 👍
I'll see this after noon if there are people interested in exploring this topic a bit more :)

There are two topics:

No build tool, such as WebPack or Esbuild. That removes the need to have Node.JS to deploy an application, i.e., Node.JS does not need to installed in Docker images or CD servers. With Rails 7 (namely with rails/importmap-rails), it is achievable. Likely, the Web is moving in that direction too, as a whole.
Not having Node.JS for development: It would remove lots of tooling (including Prettier) that improves DX for Web development. That friction point is minimal at Nimble thanks to the laptop script standardizing the dev environment. It could be further improved by using containerized dev environments (https://containers.dev/).

I would split 1. and 2. as they have very different scope and goals.

FYI I'm drafting an Engineering Initiative so we can work on each dependency with good follow up. This will be done on an internal project first (for fast feedback) and step by step be included in the Rails Template.


ffi: link to _PyPyBytes_Resize

Fixes #2737

When compiling for PyPy, _PyBytes_Resize wont be available, I think we could move the definition of this function out of cpython folder, like adding it here (or somewhere else in src/bytesobject.rs):
#[cfg_attr(windows, link(name = "pythonXY"))]
extern "C" {
    #[cfg_attr(PyPy, link_name = "PyPyBytes_Type")]
    pub static mut PyBytes_Type: PyTypeObject;
    pub static mut PyBytesIter_Type: PyTypeObject;
    #[cfg_attr(PyPy, link_name = "_PyPyBytes_Resize")]
    pub fn _PyBytes_Resize(bytes: *mut *mut PyObject, newsize: Py_ssize_t) -> c_int;
}

Damn, I saw there were already PyPy conditionals in bytesobject.rs, so I didn't check. Removing the conditional inmod.rs seems to be the right course of action.

See also #2758

The CI failure on main is caused by https://github.com/oli-obk/cargo_metadata/issues/212


Add allow_empty parameter to ImageFolder and related utils

Closes https://github.com/pytorch/vision/issues/8297

linux tests are passing so I'll risk a merge (macos failure is unrelated). Thanks a lot for the review!


Added Aptoide, darwinLabs, Elecnor Deimos, KEEP SOLUTIONS, Mind, Novabase, Opensoft, and VILT Group

Sorry to neat pick but the commit / PR history would be more clear if instead of "Updated README.md" it said "Add A,B,C,E companies".
On other note, of of the URLs is wrong as it leads to an HTTP 404, you can check the Travis build log.

Sorry to neat pick but the commit / PR history would be more clear if instead of "Updated README.md" it said "Add A,B,C,E companies".
On other note, of of the URLs is wrong as it leads to an HTTP 404, you can check the Travis build log.

Done on the first point and fixed the 404 which wasn't a link added by me.
Now it's giving a 503 on another link which opens normally when I tried.

Thanks @I-Vargas! 🚀


Add Latvian language

As per the title, please add Latvian language to the Crowdin project.

Here you go https://crowdin.com/translate/excalidraw/10/en-lv.
How do you Latvian in Latvian for the language picker?

@dwelle thanks! It's "Latviešu".


Visualization: Legend missing when overlay variable has only one value

The legend should be shown!
Example: subset/filter for one country, then do a viz plot and overlay by country

It can be done something like this
displayLegend={data.value && (data.value.series.length > 1 || typeof vizConfig.overlayVariable !== 'undefined')}


Added ability to disable.

I wanted the ability to turn off throttling in most of my specs, but turn it on for specs testing throttling itself.
So my test.rb now looks like this:
  # Use a lower ODK Collect request limit for tests
  configatron.direct_auth_request_limit = 5

  # Enable rack-attack middleware for protecting against brute-force login attempts,
  # but disable it until needed.
  config.middleware.use Rack::Attack
  Rack::Attack.disable!

And then I use before and after blocks to enable/re-disable it when needed.
Would be great to get this in the main build.
Thanks!

:+1:

@hooverlunch: did you see the Rack::Attack.clear! method?
You can call that in your before block, and restore your rack attack config by loading the config file in your after block.
Does that solve your case?

Interesting. Seems like a bummer to have to reload the config file. Is
there a reason not to have a disable function?
On 14 May 2015 at 13:56, Aaron Suggs<EMAIL_ADDRESS>wrote:

@hooverlunch https://github.com/hooverlunch: did you see the
Rack::Attack.clear!
https://github.com/kickstarter/rack-attack/blob/919976cb640c79163796b1e9290165e58f2c7748/lib/rack/attack.rb#L75-L77
method?
You can call that in your before block, and restore your rack attack
config by loading the config file in your after block.
Does that solve your case?
--
Reply to this email directly or view it on GitHub
https://github.com/kickstarter/rack-attack/pull/126#issuecomment-102117477
.

--
Tom Smyth
Worker-Owner, Sassafras Tech Collective
Specializing in innovative, usable tech for social change
sassafras.coop · @sassafrastech
Resident, Touchstone Cohousing
touchstonecohousing.org

First off, thanks for making this Pull Request to make Rack::Attack more useful for you and the community. :smile:

Is there a reason not to have a disable function?

My thinking is to optimize for production use. Every production request will check disabled? just to handle the less common case that we're in a test w/ Rack::Attack disabled. It's better to do extra work in the test harness than production.
Another idea is to do something like:
# Completely untested ;-)
before { Rails.application.middleware.delete Rack::Attack }
after { Rails.application.middleware.use Rack::Attack }

I see the value in being able to run integration tests with or without Rack::Attack, and I'd be grateful if you shared the best practice you discover. I'd welcome you sharing whatever best practice  you find in the README or wiki.

I tried using middleware delete but it won't let me change middleware
mid-test run.
How about if I changed it so disable! did like clear! but didn't wipe out
the config so that enable! could reload it?
On 14 May 2015 at 15:15, Aaron Suggs<EMAIL_ADDRESS>wrote:

First off, thanks for making this Pull Request to make Rack::Attack more
useful for you and the community. [image: :smile:]
Is there a reason not to have a disable function?
My thinking is to optimize for production use. Every production request
will check disabled? just to handle the less common case that we're in a
test w/ Rack::Attack disabled. It's better to do extra work in the test
harness than production.
Another idea is to do something like:
Completely untested ;-)
before { Rails.application.middleware.delete Rack::Attack }
after { Rails.application.middleware.use Rack::Attack }
I see the value in being able to run integration tests with or without
Rack::Attack, and I'd be grateful if you shared the best practice you
discover. I'd welcome you sharing whatever best practice you find in the
README or wiki.
--
Reply to this email directly or view it on GitHub
https://github.com/kickstarter/rack-attack/pull/126#issuecomment-102141257
.

--
Tom Smyth
Worker-Owner, Sassafras Tech Collective
Specializing in innovative, usable tech for social change
sassafras.coop · @sassafrastech
Resident, Touchstone Cohousing
touchstonecohousing.org

I tried using middleware delete but it won't let me change middleware
mid-test run.

D'oh!

How about if I changed it so disable! did like clear! but didn't wipe out
the config so that enable! could reload it?

:+1: Sounds like a good approach.

Closing this for now pending your update. Either re-open this, or open a new PR when you're ready.
Thanks!


[vcpkg] Revise appdeploy and copy_tool_dependencies

What does your PR fix?

[appdeploy] Fixes deployment for mingw on linux by

making path construction portable,
~catching failing~ fixing mutex creation.

[copy_tool_dependencies] Enables deployment for debug config.
[copy_tool_dependencies] Fixes overwriting of log files within a single port build.
[copy_tool_dependencies] Enables actual logging ~at least when DEBUG_PORT is set (cf. debug_message in ports.cmake)~.

Which triplets are supported/not supported?
--

For discussion

~Logging (-verbose) might always be enabled. It doesn't clutter output.~
~If there is a better idea how to deal with the mutex creation issue...~
To correctly handle some port being set to a single config (via triplet file), it would be necessary to also search the alternative bin directory.
It is not efficient to call appdeploy.ps1 twice. It should better take a list of directories as search path instead of a single directory.
And it should also take a list of executables (or just a single directory).

The original mutex error on linux:
New-Object: /home/kpa/Projekte/vcpkg/vcpkg/scripts/buildsystems/msbuild/applocal.ps1:26:16
Line |
  26 |          return New-Object System.Threading.Mutex($false, $mtxName)
     |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling ".ctor" with "2" argument(s): "The filename, directory name, or volume label syntax is incorrect. :
     | 'VcpkgAppLocalDeployBinary-/67pRTB1Ups2rRbHaFf9MmG5+3JTeHXhgLDIy6xHo3Wsrcl2RLAMD0XgKTwuKrwUcHqwWB5xF+iuO1frfY0xZQ=='"

The original mutex error on linux

... is caused by the / in the mutex name.

@BillyONeal Can you please review this PR?
Thanks.

It is not efficient to call appdeploy.ps1 twice. It should better take a list of directories as search path instead of a single directory.
And it should also take a list of executables (or just a single directory).

110% agreed. Additionally, using powershell for this has shown to be no longer sufficient. Both @BillyONeal and I have medium term desires to nuke this in favor of a small portable C++ utility (maybe separate, maybe built-in to vcpkg.exe), however the need for extensibility for plugin producers (Qt, magnum, etc) has made that non-trivial. I hope to eventually find a simple text/json format that can capture all needed information for those cases in a declarative way (and we can add a small amount of hardcoded logic for backwards compatibility to older port versions).

It is not efficient to call appdeploy.ps1 twice. It should better take a list of directories as search path instead of a single directory.
And it should also take a list of executables (or just a single directory).

110% agreed.

I just can't put too much in a single PR.

Thanks!


What Version Stable?

I have install dash daemon v0.14.03 but block not loading..
what version stable to intall?
thanks

This issue tracker is only for technical issues related to Dash Core.
General Dash questions and/or support requests and are best directed to the Dashpay Reddit.
To report critical security issues, email<EMAIL_ADDRESS>and/or see the DASH bug bounty program on Bugcrowd instead of creating Github issues.
Describe the issue
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
Screenshots.
If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.
What version of Dash Core are you using?
List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.
Machine specs:

OS:
CPU:
RAM:
Disk size:
Disk Type (HD/SDD):

Any extra information that might be useful in the debugging process.
This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

Problem solved


convert object blocks into object list

PrintByTemplate may not be a good UI/UX as in case of multiple BDs the above will generate something like this:-

Block Device Details :
----------------
Name     : blockdevice-c21bc3b79a98c7e8508f47558cc94f36
Capacity :<PHONE_NUMBER>00
State   : Active
Block Device Details :
----------------
Name     : blockdevice-c21bc3b79a98c7e8508f47558cc94f36
Capacity :<PHONE_NUMBER>00
State   : Active

The above should have been like this, similar to kubectl get list.
Block Device Details :
----------------
Name   Capacity  State
bd-1   107641    active
bd-2   187261    active

You can refer this code for the same:-
https://github.com/openebs/openebsctl/blob/de75453658baa6be23d739f3198df012e7c35f32/kubectl-openebs/cli/command/describe/pvc_info.go#L213
Originally posted by @Abhinandan-Purkait in https://github.com/openebs/openebsctl/pull/20#discussion_r642222214

@ParthS007 The above has been added as a part of cli-runtime refactor. Since it was a similar task it was included in the refactor. Thanks you.


The sound widget doesn't update volume

The sound widget isn't updating the system's volume setting (the microphone widget does update though) upon sliding. What information is needed to help get this fixed?

There was a bug that is now fixed, I'm sorry for that :)


nft_threejs.html   is not available

AR.js-master\three.js\examples\worker_artoolkit\examples\nft_threejs.html
I tried using the image to implement ar but the page could not be used.
The result is that the camera can not be called, the pinball NFT i can not see the result

nft arent supported at the moment sorry. what you trying is old experimental code. sorry about that


refactor ensure_server, run_detached: return api_base

Avoid duplicated code and shorten long functions.

@Mergifyio rebase

@Mergifyio rebase

@leseb , would you like please to check false report and review the PR?

@makelinux Please rebase

@leseb , @tiran , Would you like to add the final approval please?


Chaturbate plugin stopped working

Chaturbate changed their html layout and the plugin stopped working.
The solution is simple. Change Line 7 in chaturbate.py from
_playlist_url_re = re.compile("html \+= \"src='(?P<url>[^']+)'\";")
to
_playlist_url_re = re.compile("loadHlsVideo\('(?P<url>[^']+)")

Hello,
I do something wrong? :)
Added <  url  > after ?P...

Hi,
yes, the  <url> is required (named capture group). I copied the correct line but the editor here mistakes it for some code stuff. I had to escape this "tag" with backslashes.
Thanks for bringing this to my attention :-)
The code above is now correct.

I can confirm this.
However, what is the fix for Python 2?
The given line causes this error:
Failed to load plugin chaturbate:
  File "/home/jane/.local/lib/python2.7/site-packages/livestreamer/plugins/chaturbate.py", line 9, in <module>
    _playlist_url_re = re.compile("loadHlsVideo('(?P<url>[^']+)")
  File "/usr/lib/python2.7/re.py", line 194, in compile
    return _compile(pattern, flags)
  File "/usr/lib/python2.7/re.py", line 251, in _compile
    raise error, v # invalid expression
error: unbalanced parenthesis

Thanks ;)

Arghhhh,
this editor is killing me. It also eats single backslashes :-( This is no Python 2 problem I think (running 2.7 here).
Rechecked everything, it should work now...
Copy that line again from above please.

Okay - I can confirm that line fixes it for Python 3
(Have not tested Python 2)
Thanks ;)

Just FYI all, it's fixed in https://github.com/streamlink/streamlink/issues/455.
streamlink is a fork of livestreamer and is under active development as it appears livestreamer no longer is.

Oh, OK. Didn't know that yet. Just ran into that error and decided to fix it myself...
I'm gonna have a look at streamlink.
Thanks.

Hi,
I would like to fix this error, but I can't seem to do it?? I don't think I know how to :(
So, I'm going to "C:\Program Files (x86)\Livestreamer\livestreamer-1.12.2-py2.7.egg\livestreamer\plugins" and in this folder, I find chaturbate.pyc ... But when I open it with notepad++ to change the line, it's just a load of random characters :(
Where am I going wrong? Can someone please upload the fixed file.
Thank You

Hi,
I can't attach a py file here.
Open chaturbate.py not chaturbate.pyc. There you will find the code described. Change the code and save the file. Rename chaturbate.pyc or delete it. It will be recreated automatically. Otherwise recompile it with
python chaturbate.py
Hi,
I can't attach a py file here.
Open chaturbate.py not chaturbate.pyc. There you will find the code described. Change the code and save the file. Rename chaturbate.pyc or delete it. It will be recreated automatically. Otherwise recompile it with
python chaturbate.py
HTH

I downloaded the Windows Binaries file, so I only had the pyc files available to me. I managed to do it though.. I just recreated a blank text file renamed it as chaturbate.py (not pyc like all the others), got the original script from the GIT, edited the line text from above, and then just resumed my script.. It's working fine now :) Thanks a lot!!

Glad I could help... :-)

Can someone please post the phy file thx

I changed the .py file as described but it still does not work. Any help?

Obviously, you did it wrong. Read above, and try again.

Livestreamer only runs pyc files, you need to get python 2.7 and compile the fixed chaturbate.py file.

Hey all.
You can run:
pip install streamlink`

And run the same command. We've fixed the plugin there :)

Totally nonsense. For Windows:
Under: C:\Program Files (x86)\Livestreamer\livestreamer-1.12.2-py2.7.egg\livestreamer\plugins with admin rights

delete or rename chaturbate.pyc
create modified chaturbate.py
profit

Did they just change something again? It's not working again with:
([Errno 1] _ssl.c:504: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure)

Anybody else having problems with this plugin again? The same kind of scenario is happening as before.
I applied the first fix, and it's been working until last night?
Thanks

@AshleyUK1984
Hey Ashley,
This is working within streamlink, or fork of livestreamer.

Hi,
Please forgive me, seems like I found the problem.
The hard drive was completely full!

Thanks anyway.

Is there a problem again? Since a couple of hours I get this message "error: No streams found on this URL:"  :/

Having the same issue here.

I think the script is alright, I have a few streams recording, and a few failing for 502 and 404... So I think the site is just having a couple of issues. Hopefully be resolved soon.

Yes, my plugin is not working.

Not working anymore on any stream, fix?

@AshleyUK1984 @cb123321 @t0wer10 @makedir
Use https://github.com/streamlink/streamlink a fork of Livestreamer (I'm one of the maintainers). This plugin works on there.
@chrippa abandoned this project and hasn't communicated for over a year.

not working anymore, streamlink too


Fix typo in utils.py

Well, CI for docs build is failing but the PR did not contain changes for docs, i will merge this anyway.
Thanks for the contribution 💖, the PR has been merged


Bug fix: ButtonGroup with Tooltips

Closes https://github.com/primer/react/issues/4129
Related:

https://github.com/github/primer/issues/4189
https://github.com/github/primer/issues/4190

Changelog
Made CSS a bit more specific
New

Changed

Removed

Rollout strategy

[ ] Patch release
[ ] Minor release
[ ] Major release; if selected, include a written rollout or migration plan
[ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Storybook)
[ ] Changes are SSR compatible
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge
[ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

👋🏻 Friendly bump on this as it looks to be getting stale. @langermank is this something you plan to move toward merge? Looks like it would resolve one of the outstanding Accessibility Automation action items on our scorecard: https://github.com/github/primer/issues/3726#issuecomment-2512483082

Going to see if we can cut 37.7.1 from this branch do not merge it and do not update branch

@iansan5653 I attempted to do that here https://github.com/primer/react/pull/5343 and that caused these bugs I think cause it's not always all button or all a


[ie/facebook] add handling of facebook.com/events

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Add handling of facebook.com/events
Fixes #5355
Template

Before submitting a pull request make sure you have:

[X] At least skimmed through contributing guidelines including yt-dlp coding conventions
[X] Searched the bugtracker for similar pull requests
[X] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[X] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[X] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Please don't combine several unrelated issues into 1 PR. Separate PRs are preferable. There are also changes that seem unrelated to the 4 issues, please explain why they are necessary or revert

Please don't combine several unrelated issue fixes into 1 PR. Separate PRs are preferable. There are also changes that seem unrelated to the 4 issues, please explain why they are necessary or revert

Except the updates of some 'test' data, please kindly specify which changes seems unrelated to the 4 issues,

Now THAT'S obfuscation...  The blob should be easy to isolate though!

Video data is not extracted from Video tag therefore the blob here is irrelevent.
Please provide us the url of Fb event (https://www.facebook.com/events/...) if the extractor does not work.


Union types with allow_none_optionals causing maximum recursion depth exceeded errors

When I have

A model defined where some fields are Union of types and None and
__allow_none_optionals__= True

I'm getting an error: RecursionError: maximum recursion depth exceeded while getting the repr of an object
# snip
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/value_generators/complex_types.py", line 94, in handle_complex_type
  return model_factory.get_field_value(model_field=model_field)
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/factory.py", line 431, in get_field_value
  return handle_complex_type(model_field=model_field, model_factory=cls)
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/value_generators/complex_types.py", line 94, in handle_complex_type
  return model_factory.get_field_value(model_field=model_field)
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/factory.py", line 431, in get_field_value
  return handle_complex_type(model_field=model_field, model_factory=cls)
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/value_generators/complex_types.py", line 88, in handle_complex_type
  if is_union(model_field=model_field) and model_field.sub_fields:
File "/Users/hans/workspace/example/.venv/lib/python3.10/site-packages/pydantic_factories/utils.py", line 74, in is_union
  return repr(model_field.outer_type_).split("[")[0] == "typing.Union"
RecursionError: maximum recursion depth exceeded while getting the repr of an object`

Here's a simple (python 3.10) reproduce script:
import uuid

from pydantic import BaseModel
from pydantic_factories import ModelFactory

class Location(BaseModel):
    id: uuid.UUID | str | None
    name: str | None

class LocationFactory(ModelFactory):
    __model__ = Location
    __allow_none_optionals__ = False

if __name__ == "__main__":
    LocationFactory.build()

Version info:
❯ pip freeze | grep pydantic
pydantic==1.9.0
pydantic-factories==1.2.6

❯ python --version
Python 3.10.2

Hi there.
This seems to be a bug with how we determine if a given value is a Union type and the 3.10 union syntax. The error is here:
repr(model_field.outer_type_).split("[")[0] == "typing.Union", where I would assume that either pydantic changed its logic respective of union typings, or that python itself has a different repr for these types.
I will have time to check this during the weekend, unless you or someone else would like to give it a go.

It seems that the repr method is different for the 3.10 union syntax.
uuid.UUID | str | None
so I guess the is_union function in utils.py could be changed into something like this.
`
def is_union(model_field: ModelField) -> bool:
"""Determines whether the given model_field is type Union"""
if repr(model_field.outer_type_).split("[")[0] == "typing.Union":
    return True
elif "|" in repr(model_field.outer_type_):
    return True
else:
    False

If you add a PR with some test cases for this it would be great.

Will add PR today.

v1.2.7 released, thanks to @DaanRademaker for the PR! please confirm this issue is resolved and if it is - close this issue @hozn

Thank you both!  I will test this out.

Confirmed fixed; thanks again.


feature discussion: should portal visitors see the owner's posts first?

currently, when you visit another user's Rotonde page, you see their feed much like they would see it. This makes it difficult to see what they themselves have posted. my proposal is, that by default the feed is filtered by the portal's @name if you are not the owner of the page.
to make it possible to still see their full feed (including posts by others that don't mention them) if one so desires, I made it so that filters get removed immediately upon clicking the "filtering by …" message. this way, you can remove filters even when you don't have an operator.
→PR #63
following @ianh 's advice to discuss the matter in a github issue.
you can test the proposed changes yourself by going to my portal: dat://5276ca2f92b6d508933ac4b01ef9078938f69bed9ca15c462617f531641b7a6b/

this is a good change imo. while it's cool to be able to see how others' homepages/feeds look like, if i navigate to their page, i typically want to see the posts by them (at least by default – can always toggle it off easily!)

I agree this is a useful feature, but I also find it nice to explore other people's pages as they see them (without having to click through a filter link at the top).  I wonder if there's a more subtle way to focus self-entries on the page, like:

showing a "pinned entry" that you can choose
showing your last few entries at the top or on the side
adding a way to scroll between self-entries
or something else…

Semi-related, once a timeline "fills up" with more recent stuff (specifically, 42 entries + the $rotonde "bot" post) there's no way to see older stuff. Should we allow for multiple pages or even pagination/infinite scrolling so you can see all the way back? I feel like if I'm gone for a day, as long as I'm following more than a couple people, I'll miss out on mentions/whispers.

Yeah—you can always filter to see mentions, but I think just nobody has gotten around to implementing pagination yet.  We should probably have another issue for it.

Oh, that's true—I forget about that. Thanks for the reminder of that feature. :) I'll make an issue for it, at least to provide a platform for related discussion.

@ianh my intention was to implement the feature in a minimally-invasive way, utilizing the already in place filtering system. the problem with filtering right now is just that you can't do it on other people's pages. toggle-able filtering by portalname gives visitors some rudimentary filter capabilities.
(sidenote: filtering unowned pages works fine from the dev console)
your suggestions are cool features in their own right. pinned posts would be very nice! would we have to change the specs to allow for a 'pinned' field in portal.json?

It wouldn't necessarily have to be in portal.json, since other clients don't care about it.  We could have a "local.json" to store things like whether a post is pinned, for example.

Showing "local" posts first will speed up the first view load, right?

Not the way it's currently implemented; the client is still loading all the data from everybody's portals, it's just filtering them after the fact so only one person's posts are visible. Lazy-loading is an interesting idea, though.

Sort of related, I've implemented something pretty neat that works like this:
dat://2f21e3c122ef0f2555d3a99497710cd875c7b0383f998a2d37c02c042d598485/#neauoire-98

Will link directly to a specific entry, it could be modified so #neauoire displays all posts by user.


Making Deprecation of AdaptiveCards.Rendering.Html more discovereable

It seems since https://github.com/microsoft/AdaptiveCards/issues/6747, .NET HTML renderer is deprecated.
While there is a banner in the docs, it'd be great if it could be called out a little more. I'm involved in a project that has recently started using adaptive cards and was a bit surprised to discover the different state of the libraries.
eg.

[ ] Adding a note here:
https://github.com/microsoft/AdaptiveCards/blob/d9c7d711f2e9b5a66fb8db33bb63911f03a3d6be/source/dotnet/README.md?plain=1#L7

[ ] Remove the mention here:
https://github.com/microsoft/AdaptiveCards/blob/d9c7d711f2e9b5a66fb8db33bb63911f03a3d6be/README.md?plain=1#L26

[ ]  Deprecating the package on NuGet.

Also, if there was any information on any alternative html renderer was available, that'd be great to include too. Primarily I'd be interested in generating fallback content for email clients (like Apple's Mail on iOS).

so... any updates?

so... any updates?

We have stopped supporting .net html rendering. The alternative is JS/TS renderer. https://github.com/microsoft/AdaptiveCards/tree/main/source/nodejs.

@jwoo-msft I'd appreciate it any of the discoverability points I mentioned in the OP could be looked at, thanks!


sqlparser: fix binary unary operator bug

This fixes issue https://github.com/youtube/vitess/issues/798
where a construct like "a - -b" produced incorrect code.
I also found a related bug where a construct like "- -a"
also produced incorrect code.
This is also a potential vulnerability because "--" is
treated as a comment.

LGTM


Missing Docker Image for 1.8.2

Hi,
Deck 1.8.2 was released in September which fixes #495, but the latest image on DockerHub is 1.8.1
Is it possible to get a Docker image with version 1.8.2 ?

@rajkong Please ping @rainest internally for help to fix this.

Checking out v1.8.2 and  following https://github.com/Kong/deck/blob/accefdd1b2fde43a098a2fc9611003a2cfa4a703/RELEASE.md#docker-release will fix this, minus permissions. @hbagdi o we ever intend to end support for the registry under your account?

I have pushed v1.8.2 to  kong/deck:v1.8.2 and docker pull kong/deck:latest

Per conversation with Harry, we'll deprecate the hbagdi repo after this version. I've pushed the v1.8.2 image to it.


'expects' conflicts with Mocha

Context
Using Mocha::ObjectMethods#expects to assert that an interaction is expected to #run
Setup
# app/interactions/some_interaction.rb
class SomeInteraction < Less:Interaction
  expects :something

  def run
    AnotherInteraction.run(something: something)
  end
end

Test
# test/interactions/some_interaction_test.rb
require 'test_helper'

class SomeInteractionTest < ActiveSupport::TestCase
  test 'should run AnotherInteraction' do
    AnotherInteraction.expects(:run).once
    SomeInteraction.run(something: 'tricky')
  end
end

Result
NoMethodError: undefined method `once' for [:run]:Array
    test/interactions/some_interaction_test.rb:6:in `block in <class:SomeInteractionTest>'

As you can see, this is can be problematic if expecting with Mocha.
Any thoughts?

You can work around this like so:
class SomeInteractionTest < ActiveSupport::TestCase
  test 'should run AnotherInteraction' do
    AnotherInteraction.any_instance.expects(:run).once
    SomeInteraction.run(something: 'tricky')
  end
end

Not pretty, and not exactly the same, I know. But changing the API for this is a bit too much.


feat(LinearAlgebra/QuadraticForm/Prod): lemmas about polar,polarBilin, and associated

This also slightly adjusts the file sectioning in order to introduce the temporary Ring assumption.

bors merge


fix(OrbitControls): upstream fixes

Uses https://github.com/mrdoob/three.js/pull/25540/files to fix https://github.com/mrdoob/three.js/issues/25505

@CodyJasonBennett Sorry to ping you directly, I'm wondering how best to unstuck a PR and saw that you merged one recently.
I understand that this is open source software and am glad enough that volunteers like you did this great work, but I'm a bit surprised to see that you've multiple PR open, some for a while, with a green CI. Are there more steps required to get something merged?
Thx for your time 🙏

This was just missed. Thanks.


Merged martenson/disposable-email-domains blacklist

Just asked the Martenson if I could merge the blacklist, because his one is a bit better ;)
https://github.com/martenson/disposable-email-domains/issues/15

Good work. Although, yahoo.com.ph and yahoo.com.vn seem to be valid Yahoo! domains. I wouldn't consider them to be disposable any more than a yahoo.com or gmail.com address.

@nojacko good catch, added them to whitelist

They are now removed from the list: https://github.com/martenson/disposable-email-domains/commit/7ecfdaee44fe4b5832fda959a168de0897894c7f

Thanks for the pull request. I'm not going to merge it as it's prompted me to finish my disposable email library https://github.com/nojacko/email-data-disposable which pulls in https://github.com/martenson/disposable-email-domains  (along with several other sources) and whitelists a long more common domains. It loads it in via composer which, as a compose based project, I prefer over a submodule.


gpssh: removing b and \r getting added to command output

Issue:
This issue applies to 7x only. Gpssh command output contained byte string and \r characters.
RCA:
When gpssh reads output from pexpect.before, it's in byte format. Need to convert this output into the string format. Also, there are carriage return characters (\r) that need to be removed.
Fix:
When the output is returned from gpssh, made sure that we are converting bytes to string. To remove \r characters, striping the lines.
Sample output before the fix:
$ gpssh -h sdw1 hostname
[sdw1] b'sdw1\r'
After the fix:
$ gpssh -h sdw1 hostname
[sdw1] sdw1

fix #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


chore: generate return type for methods returning Promise

Fixes https://github.com/microsoft/playwright/issues/29152

Subsumed by https://github.com/microsoft/playwright.dev/pull/1282


FATAL Fatal error, application will be closed: UniversalDownloaderPlatform.Common.Exceptions.UniversalDownloaderException: Unable to retrieve crawl target info: Campaign id cannot be less than 1 (Parameter 'campaignId')

I started getting this error a few days or weeks ago. I tried deleting everything to start fresh, including chrome folder so it required me to login again.
Patreon $ .\PatreonDownloader.App.exe --url https://www.patreon.com/<...creator...>/posts --descriptions --embeds --campaign-images --json --log-level Trace
2023-09-22 11:25:26.2517 DEBUG Initializing UniversalDownloader...
2023-09-22 11:25:26.2517 DEBUG Initializing ninject kernel
2023-09-22 11:25:26.2691 DEBUG Loading custom ninject module
2023-09-22 11:25:26.2691 DEBUG Loading ICrawlTargetInfoRetriever
2023-09-22 11:25:26.2860 DEBUG Configuring IPageCrawler
2023-09-22 11:25:26.3025 DEBUG New plugin found: UniversalDownloaderPlatform.GoogleDriveDownloader.dll
2023-09-22 11:25:26.3831 DEBUG Token data saved to: GoogleDriveToken
2023-09-22 11:25:26.3831 INFO Loaded plugin: Google Drive Downloader
2023-09-22 11:25:26.3831 DEBUG New plugin found: UniversalDownloaderPlatform.MegaDownloader.dll
2023-09-22 11:25:27.4934 INFO Loaded plugin: Mega.nz Downloader
2023-09-22 11:25:27.4934 DEBUG Initializing plugin manager
2023-09-22 11:25:27.4934 DEBUG Initializing download manager
2023-09-22 11:25:27.4934 DEBUG KemonoCrawledUrlProcessor initialized
2023-09-22 11:25:27.4934 DEBUG Initializing crawl results exporter
2023-09-22 11:25:27.4934 DEBUG Initializing url checker
2023-09-22 11:25:27.4934 DEBUG Initializing web downloader
2023-09-22 11:25:27.4934 DEBUG Initializing cookie retriever
2023-09-22 11:25:27.4934 DEBUG Initializing cookie validator
2023-09-22 11:25:27.4992 DEBUG Initializing crawled url processor
2023-09-22 11:25:27.4992 DEBUG Universal Downloader Platform settings: PatreonDownloaderSettings { CookieContainer = , UserAgent = , UrlBlackList = System.Collections.Generic.List`1[System.String], MaxDownloadRetries = 10, RetryMultiplier = 5, FileExistsAction = BackupIfDifferent, IsCheckRemoteFileSize = True, ProxyServerAddress = , DownloadDirectory = , SaveDescriptions = True, SaveEmbeds = True, SaveJson = True, SaveAvatarAndCover = True, IsUseSubDirectories = False, SubDirectoryPattern = [%PostId%] %PublishedAt% %PostTitle%, MaxSubdirectoryNameLength = 100, MaxFilenameLength = 100, FallbackToContentTypeFilenames = False, IsUseLegacyFilenaming = False, LoginPageAddress = https://www.patreon.com/login, LoginCheckAddress = https://www.patreon.com/api/current_user, CaptchaCookieRetrievalAddress = https://www.patreon.com/home, RemoteBrowserAddress = , IsHeadlessBrowser = True }
2023-09-22 11:25:27.4992 INFO Retrieving cookies...
2023-09-22 11:25:27.4992 DEBUG Initializing PuppeteerEngine with parameters , True
2023-09-22 11:25:27.5165 DEBUG Calling login check
2023-09-22 11:25:27.5165 DEBUG Retrieving browser
2023-09-22 11:25:27.5165 DEBUG Downloading browser
2023-09-22 11:25:27.5165 DEBUG Launching browser
2023-09-22 11:25:27.6688 DEBUG Opening new page
2023-09-22 11:25:27.7653 DEBUG Creating IWebBrowser
2023-09-22 11:25:27.8243 DEBUG Checking login status
2023-09-22 11:25:28.1844 DEBUG We are logged in
2023-09-22 11:25:28.1888 DEBUG Retrieving browser
2023-09-22 11:25:28.1888 DEBUG Retrieving cookies
2023-09-22 11:25:28.4315 DEBUG Adding cookie: AWSALBTGCORS
2023-09-22 11:25:28.4315 DEBUG Adding cookie: patreon_device_id
2023-09-22 11:25:28.4315 DEBUG Adding cookie: __cf_bm
2023-09-22 11:25:28.4315 DEBUG Adding cookie: session_id
2023-09-22 11:25:28.4315 DEBUG Adding cookie: AWSALBTG
2023-09-22 11:25:28.4315 DEBUG Adding cookie: patreon_location_country_code
2023-09-22 11:25:28.4315 DEBUG Adding cookie: patreon_locale_code
2023-09-22 11:25:28.4315 DEBUG Adding cookie: a_csrf
2023-09-22 11:25:28.4368 DEBUG Disposing puppeteer engine
2023-09-22 11:25:28.4368 INFO Preparing to download...
2023-09-22 11:25:28.4368 WARN Datadome cookie was not found. Usually this is not an issue, but if you are experiencing any issues please make sure to report it via GitHub issues page.
2023-09-22 11:25:30.6211 FATAL Fatal error, application will be closed: UniversalDownloaderPlatform.Common.Exceptions.UniversalDownloaderException: Unable to retrieve crawl target info: Campaign id cannot be less than 1 (Parameter 'campaignId')
---> System.ArgumentOutOfRangeException: Campaign id cannot be less than 1 (Parameter 'campaignId')
at PatreonDownloader.Implementation.PatreonCrawlTargetInfoRetriever.GetCrawlTargetInfo(Int64 campaignId) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Implementation\PatreonCrawlTargetInfoRetriever.cs:line 58
--- End of inner exception stack trace ---
at PatreonDownloader.Implementation.PatreonCrawlTargetInfoRetriever.GetCrawlTargetInfo(Int64 campaignId) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Implementation\PatreonCrawlTargetInfoRetriever.cs:line 75
at PatreonDownloader.Implementation.PatreonCrawlTargetInfoRetriever.RetrieveCrawlTargetInfo(String url) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Implementation\PatreonCrawlTargetInfoRetriever.cs:line 26
at UniversalDownloaderPlatform.Engine.UniversalDownloader.Download(String url, IUniversalDownloaderPlatformSettings settings) in F:\Sources\BigProjects\PatreonDownloader\submodules\UniversalDownloaderPlatform\UniversalDownloaderPlatform.Engine\UniversalDownloader.cs:line 183
at PatreonDownloader.App.Program.RunPatreonDownloader(CommandLineOptions commandLineOptions) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 128
at PatreonDownloader.App.Program.Main(String[] args) in F:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 68
Patreon $

Same problem here !

Same error as #196 something changed and a pull request has been made. There's workaround advice in that thread and we should be getting an official fix soon.

Same

Hello, would someone please be kind, to Compile a working windows executable and share the folder as a zip? thanks so much if this would be possible.

Hello, would someone please be kind, to Compile a working windows executable and share the folder as a zip? thanks so much if this would be possible.

Yeah a windows .exe would be pretty nice.

Hello, would someone please be kind, to Compile a working windows executable and share the folder as a zip? thanks so much if this would be possible.

Yeah a windows .exe would be pretty nice.

Here you go! I went ahead and compiled the fix from the other thread into a zip. It's 29MB and too big for a github comment so here's a link
https://www.mediafire.com/file/2argbjfhj4xbtqf/net6.0-win-x64-release-Skyl3lazer.zip/file

thank you so much!!!!!!!!!!!!!!!!!!!

Current estimate for this issue to be addressed in the official build - some time next week.


Consider deriving more signature keys and local storage key

Currently, master secret KEY_MASTER_SECRET is used to derive one signing key KEY_SIGNATURE and one transport key KEY_TRANSPORT. It would be nice to have:

multiple signing keys (namely 3 - each for a single authentication factor)

KEY_SIGNING_F1
KEY_SIGNING_F2
KEY_SIGNING_F3

one "local storage key" to encrypt the original private key so that it can be used for further key derivation or asymmetric ECDSA signature

KEY_ENCRYPTED_STORAGE

This will also require description of expected key storage...

Just to add a note: the KEY_ENCRYPTED_STORAGE cannot of course be stored on the PowerAuth client. It must be used for initial encryption only, later purged and then retrieved from PowerAuth server upon successful authentication. For retrieving the key from the server, a unique transport key should be used, for example derived from CRT and KEY_TRANSPORT.

Implementation fixed in 4b8610f8fecbfa41ea1db6aea08aa08854a405fe.
Needed improvements:

better description of the key storage
description of fetching the vault unlock key from server

Fixed in ea19194b6536dd58c03c674a11b67dbb8400de27


[BUG] Cannot write files with disabled file system characters

I noticed that Zotify cannot save tracks with invalid file system characters like question marks, hashes, slashes etc.
A solution could be relplacing the characters either with Unicode lookalikes or underscores.
Example error message:
Track_ID: 2LqPmrNUWC5xo33ONwdooI

[Errno 22] Invalid argument: "Who's They? (by Hans Zimmer).mp3"

Traceback (most recent call last):
  File "/home/leo/.local/lib/python3.11/site-packages/zotify/track.py", line 232, in download_track
    with open(filename_temp, 'wb') as file, Printer.progress(
         ^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 22] Invalid argument: "Who's They? (by Hans Zimmer).mp3"

There's already something similar in utils.py, but i think this should be parametrized to be able to force windows filenames, even when running on linux.

This and would address my other bug ticket as well in one shot.  Currently I'm running Zotify in WSL and only came across the one character as being an issue at the moment but I'm likely to run into others.
https://github.com/zotify-dev/zotify/issues/106


Fail to Build a Flutter Project with 2.0.0 flutter_native_timezone

It seems like the Flutter_Native_Timezone plugin package needs an kotlin upgrade.  I got this build error from my vscode flutter env:
FAILURE: Build failed with an exception.

What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.5.20 and higher.
The following dependencies do not satisfy the required version:
project ':flutter_native_timezone' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 8s
Exception: Gradle task assembleDebug failed with exit code 1

Due to lack of maintenance in this repo, I have just published a fork on pub.dev.
There is an open PR in this repository that I should solve your issue and I have cherry-picked that into my fork.


TreeSize v9.1.2

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Sorry, our update script did a fall back to the outdated version of WinGetCreate from Chocolatey, instead of using the current version it just installed .. created a new request with the new version of WinGetCreate and the new manifest version ..


Explicitly name reusable header types as 'response header' types

For details, see https://github.com/apple/swift-openapi-generator/pull/74#discussion_r1234329155

Hi, I'd like to take a look at this issue.

Sure thing, thanks, @PARAIPAN9!


STM32H750 flash corruption with double buffering enabled

Hi,
It seems there is a problem with the flash write routines for STM32H750. A simple program like the below gives corrupted flash for about one out of five attempts for a 30 kB file, without any type of sign that something went wrong.
#!/usr/bin/env python3
from pyocd.core.helpers import ConnectHelper
from pyocd.flash.file_programmer import FileProgrammer

with ConnectHelper.session_with_chosen_probe(target_override='stm32h750vbtx') as session:
    FileProgrammer(session, chip_erase="sector", smart_flash=False).program("file.elf")

Looking at the diff, it appears that some pages are only partially written with only the first part containing correct data, and the rest of the page being 0xff.
I was very surprised to find that neither the FileProgrammer helper, nor any of the underlying classes, support built in verification of the flash contents after programming. This is a fundamental feature of any flash programming tool. Of course you can do a manual compare separately, but that command does not have the same file format support as FileProgrammer.
I added verification support to the FlashBuilder class for easier debug of this problem. I can send a PR after some cleanup and exposing through FileProgrammer if there is any interest.
After testing a lot of times with the verify support active, it seems corruption only happens with double buffering enabled, and regardless of whether using sector erase or chip erase (which is a lot slower on STM32H750 for some reason). I don't see any way to switch off double buffering except changing the builder code, since the builder method to disable it doesn't seem to be exposed all the way up to FileProgrammer.

I would think #1696 has the same root cause, since the chips are from the same family and probably uses the same flash algo.

I found a builtin target stm32h743xx which works much better than the Keil.STM32H7xx pack, after being modified for the H750 flash layout. I made 100 programmings in a row without any problems, whereas the CMSIS H750 pack flash loader failed after on average 2 programmings.
By the way, I think the H743 support added in #1567 lists the wrong sector size for the flash, which should be 128K, but is listed as 8K in the flash algo dict, and 32K in the memory map. I assume this must be a mistake.
Is this the correct issue tracker for CMSIS-PACK bugs? Otherwise I think this issue can be closed. I will send a PR adding the verify support and a new builtin target for H750.

Just to add a data point:
I'm having the same symptoms, while trying to program the STM32H750 on a Daisyseed board.
The success rate is about one out of three tries.
It seems to be independent of the used probe, I've tried a CMSIS-DAP LPClink2, a Picoprobe, and a JLink mini EDU.
Programming and verifying work flawlessly with the same probes when using OpenOCD.


Which font is that?

Hello, I was wondering which font was used in the code of this image?

That's fantasque sans. :)
On Thu, Feb 9, 2017, 8:54 PM Thiago Majesk Goulart<EMAIL_ADDRESS>wrote:

Hello, I was wondering which font was used in the code of this image
https://raw.githubusercontent.com/flyingfisch/VSGruvbox/master/Capture.PNG
?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flyingfisch/VSGruvbox/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPxeQ9q3Wwtm4vQvEsl_KllqEPca87Jks5ra8NEgaJpZM4L857z
.

Thanks!


Add --depth argument to limit the depth of the search

for target/ dirs.
I'm not super familiar with crossbeam so maybe the implementation is not idiomatic.
Tbh results are not that impressive, with --depth 2, I get 11s in my usecase, will without it, I have 14s.
However the difference is more noticeable for machine with few cores, as setting --threads 1, I see an improvement from 22s to 11s by enabling --depth 2.

Looks great, thanks for the PR!


Make TracingDataSource implements AutoCloseable

Container like spring ApplicationContext will close underlying DataSource automatically.
	@Bean
	public DataSource dataSource() {
		DataSource ds = createDataSource();
		if (tracingEnabled) {
			ds = new TracingDataSource(tracingConfiguration.getTracer(), ds);
			//the underlying ds will not be closed since it's not managed by spring now
		}
		return ds;
	}

Pull Request Test Coverage Report for Build 257

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 47.804%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java
0
3
0.0%

Totals

Change from base Build 253:
-0.1%

Covered Lines:
468

Relevant Lines:
979

💛  - Coveralls


Repository branches are not available

Expected behavior
The application ought to load all repository branches, which would refelct in the add schedule new cron section
Actual Behavior
While trying to add schedule new cron, the branches refuse to load, it keeps saying no branch found
How to reproduce

Download and install the application here
Lunch the application
Select "Travis CI (For open source projects)"
Paste your access token

How to get access token for new users

click on "where can i find my access token" to know how to get it
Click on the go to profile, log in with your github account.
Enable all repository
Now copy your access token
Go back to the app Paste your access token

Click on log in
Select a repository
Click on Cron
Click the add button
Click on select branch
It load for a while,  then say "No branch found"

Application version: v 1.1.1
Operating system: Android v7.0
Recording Of The Bug
https://youtu.be/aWQYOmCcqcE

if am  snake speed.github.io used in here in the video it
can't be located *check picture below.

also, you have to create ".travis.yml" , so if u don't know how to, then read that HERE.
as you can see, mine works fine.

But it us the same on all my repository

@Olamatto show a screenshot, or your "said" repository.
and make sure u have the right configurations on travis-ci.org

@Olamatto It seems like you haven't set Travis CI pipeline into your project. That's why Travis not able to pull any branches for your project and it returns empty branches list. As the branches list are not from your GitHub repo. It's the list of branches which Travis build in the past. You can see this here on the Travis website.
As @iykequame suggested you need to first set up travis.yml first and run a build.


Failed to apply plugin [class 'com.google.gms.googleservices.GoogleServicesPlugin']    > For input string: "+"

Expected Behaviour
To Build apk or run in emulator
Actual Behaviour
Throws an error
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Cordova CLI version and cordova platform version
cordova --version                                    #  8.0.0

cordova platform version android:

#Installed platforms:
android 7.0.0
Available platforms:
browser ~5.0.1
ios ~4.5.4
osx ~4.0.1
windows ~5.0.0
www ^3.12.0
Plugin version
cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

#card.io.cordova.mobilesdk 2.1.0 "CardIO"
com-sarriaroman-photoviewer 1.1.16 "PhotoViewer"
com.paypal.cordova.mobilesdk 3.5.0 "PayPalMobile"
cordova-plugin-calendar 5.0.0 "Calendar"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-device 1.1.7 "Device"
cordova-plugin-fcm 2.1.2 "FCMPlugin"
cordova-plugin-firebase 1.0.4 "Google Firebase Plugin"
cordova-plugin-inappbrowser 2.0.2 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-nativestorage 2.3.1 "NativeStorage"
cordova-plugin-splashscreen 4.1.0 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-uniquedeviceid 1.3.2 "UniqueDeviceID"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-plugin-x-toast 2.6.2 "Toast"
cordova-sqlite-storage 2.3.1 "Cordova sqlite storage plugin"
Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem

I don't see phonegap-plugin-push in your list of plugins

Now I've added but still got the same error.
card.io.cordova.mobilesdk 2.1.0 "CardIO"
com-sarriaroman-photoviewer 1.1.16 "PhotoViewer"
com.paypal.cordova.mobilesdk 3.5.0 "PayPalMobile"
cordova-plugin-calendar 5.0.0 "Calendar"
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-device 1.1.7 "Device"
cordova-plugin-fcm 2.1.2 "FCMPlugin"
cordova-plugin-firebase 1.0.4 "Google Firebase Plugin"
cordova-plugin-inappbrowser 2.0.2 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.0.5 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-nativestorage 2.3.1 "NativeStorage"
cordova-plugin-splashscreen 4.1.0 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-uniquedeviceid 1.3.2 "UniqueDeviceID"
cordova-plugin-whitelist 1.3.3 "Whitelist"
cordova-plugin-x-toast 2.6.2 "Toast"
cordova-sqlite-storage 2.3.1 "Cordova sqlite storage plugin"
phonegap-plugin-push 2.1.3 "PushPlugin"

but you had the error before adding the plugin, so I don't think it's related to the plugin. Probably caused by fcm or firebase plugin

I know but i'm stuck and unable to find a solution. It's been a week and nothing yet.


adds config.json files for doc types without them

Looking at the structure, can we put the closing disclosure folder as a top level folder? ie get rid of the "real_estate" folder ?


platforms: Update RISC-V kernel configs

Motivation for this change
One of the final pieces to make the whole thing work :)
Tested to boot on QEMU and on HiFive Unmatched (config). You can quickly test with this script. Run the script as root to mount host /nix/store as well as PWD into the VM.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Thanks!


Support querying of SubscriberLists with both tags and links

Modifies SubscriberList retrieval and creation of notifications to work with both links and tags, required as part of the migration to using only links.
Includes extraction of the (reasonably complex) querying logic into its own class. Could probably be factored much better than it is, but hopefully it provides a starting point for making this code easier to understand.
See each commit for more detail.
Trello: https://trello.com/c/x9pN83lI/365-email-alert-api-supports-links-to-topics-being-passed-as-content-ids-as-well-as-by-the-current-slug-method

Apart from what @rboulton brought up above, I think the rest of the code in here looks good. Once that's taken care of let me know; it would be good to see how this plugs together in the dev VM.

@rboulton have added a couple of commits which address your concerns.

@KushalP ready for another look whenever you are.

For the commits in 2d9e03 and ff61c5 do we have tests for them? It would be good to track any regressions in these instances.

@KushalP I feel like notifications are adequately tested at both integration and unit level, but on second look a basic link-oriented test in spec/requests/send_notification_spec.rb might be a good idea. Will add.

@KushalP @rboulton updated.
FYI, as noted on the Trello ticket I expect this PR to resolve this bug in errbit.


⚠ Bofrost.lu has degraded performance

In cd9946c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1148 ms

Resolved: Bofrost.lu performance has improved in 06564f5 after 10 minutes.


Add Tushar Mittal profile and Random Meme tool

What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[x] ✨ Feature
[ ] ✅ Joined Community
[ ] 🌟 ed the repo
[ ] 🐛 Grammatical Error
[x] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Tushar Mittal profile in the Little bit of everything section, and random meme generator in the Tools section.
Add Link of GitHub Profile
https://github.com/techytushar/techytushar

How about adding it to the Simple but Innovative Ones category ?

How about adding it to the Simple but Innovative Ones category ? Actually, I don't have any badges on the profile readme, so that might not be the best category.

Fine Add it~

Done! :rocket:


EOSJS - ReactNative -- undefined is not an object (evaluating 'self.fetch')

Hi, I have been following instructions from link https://github.com/EvaCoop/eosjs-react-native , to setup eosjs on already-build react-native app.
I have installed related dependencies as well like react-native-browser-polyfill  and react-native-hockeyapp
My build completes successfully and runs fine But I am facing following error when I open my app in mobile.
undefined is not an object (evaluating 'self.fetch')
Kindly guide for the same.

eosjs-api uses npm package isomorphic-fetch 2.2.1https://github.com/matthew-andrews/isomorphic-fetch
I don't see any RN issues ..  When you create eosjs it tries to check the chainId and warn if it does not match.  That is the first time it tries to fetch.

Currently I don't have any dependency for isomorphic-fetch  in my package.json, so do I need to import it explicitly?

You may need a RN version .. I don't know.  Make sure you have a question opened in the EvaCoop/eosjs-react-native repository.

Sure I'll thanks, for direction. :)


Elfeed support for gopher protocol?

Hi skeeto,
Many thanks for this package!  I find that as I get more and more into the gopher protocol as well as gemini that I'd like to be able to have all of my feeds across all of the protocols I use in elfeed.  It seems that relatively recent versions of cURL support the gopher protocol, so I think it would be feasible to add support for elfeed to support gopher feeds as well.
What do you think?  I will likely try to work on a PR for this if you are interested.

I'm interested in supporting this. I've already wanted to follow a
couple of Gemini feeds. (I ended up using a Gemini HTTP proxy.) What did
you have in mind? I'm thinking you could generalize the solution in #397
to other protocols that won't have HTTP headers in their results buffer.
Note: I'm unconcerned with supporting these protocols through the old
url-retrieve method since I consider it merely a last-resort fallback.

I'm interested in supporting this. I've already wanted to follow a
couple of Gemini feeds. (I ended up using a Gemini HTTP proxy.) What did
you have in mind? I'm thinking you could generalize the solution in #397
to other protocols that won't have HTTP headers in their results buffer.
Note: I'm unconcerned with supporting these protocols through the old
url-retrieve method since I consider it merely a last-resort fallback.

Okay, good to know you're on board for this.  I'll take a look at the solution you mentioned.
In my mind there's a couple of things to change: add a check for curl capabilities to see if gopher is supported (in the same fashion that compression is also checked) and then add the ability to determine the type of protocol to be called.  For the latter, I've been thinking that parsing the start of the feed URL in some sort of regexp-based pcase would influence how the feeds are parsed.  I'm thinking of defaulting to HTTP handling by default in case someone has existing feeds specified as "www.foo.com/bar/atom.xml".
This is going to be a weekend project for me, but if you have any particular ideas of places that I should touch then I'm happy to take any other advice.  I'm still mostly going through elfeed-curl.el with the debugger to understand the flow.

Okay, good to know you're on board for this.  I'll take a look at the solution you mentioned.
In my mind there's a couple of things to change: add a check for curl capabilities to see if gopher is supported (in the same fashion that compression is also checked) and then add the ability to determine the type of protocol to be called.  For the latter, I've been thinking that parsing the start of the feed URL in some sort of regexp-based pcase would influence how the feeds are parsed.  I'm thinking of defaulting to HTTP handling by default in case someone has existing feeds specified as "www.foo.com/bar/atom.xml".
This is going to be a weekend project for me, but if you have any particular ideas of places that I should touch then I'm happy to take any other advice.  I'm still mostly going through elfeed-curl.el with the debugger to understand the flow.

Hi skeeto,
I've put up a PR just to review what I have so far: https://github.com/skeeto/elfeed/pull/410
Locally, I am able to point to a gopher feed file (so far, I am just point to a feed file for my own phlog -- RSS doesn't seem to have caught on in the gophersphere yet) and am able to pull down my posts into elfeed and view them without any issue.  I've attached some screenshots here to show what I am seeing.

The PR has some more information about what needs to be done before this should get merged, but hopefully this looks like it's on the right track for you.

Hi skeeto,
I've put up a PR just to review what I have so far: https://github.com/skeeto/elfeed/pull/410
Locally, I am able to point to a gopher feed file (so far, I am just point to a feed file for my own phlog -- RSS doesn't seem to have caught on in the gophersphere yet) and am able to pull down my posts into elfeed and view them without any issue.  I've attached some screenshots here to show what I am seeing.

The PR has some more information about what needs to be done before this should get merged, but hopefully this looks like it's on the right track for you.

Even though elfeed will now support reading RSS files over gopher with #410 (thanks again @skeeto for your update to that), I think there's still a piece to this that is missing: properly handling links to gopher protocols in some sort of a suitable browser.
I have been using the Elpher (https://thelambdalab.xyz/elpher/) package for both Gemini and Gopher so there may be a chance to integrate with that package, but I think a more generic solution should be available as well, such as allowing a user to enter in a handler in a lookup table for an HTTP proxy for any given protocol.

Even though elfeed will now support reading RSS files over gopher with #410 (thanks again @skeeto for your update to that), I think there's still a piece to this that is missing: properly handling links to gopher protocols in some sort of a suitable browser.
I have been using the Elpher (https://thelambdalab.xyz/elpher/) package for both Gemini and Gopher so there may be a chance to integrate with that package, but I think a more generic solution should be available as well, such as allowing a user to enter in a handler in a lookup table for an HTTP proxy for any given protocol.

what the status of Gemini? I tried add a Gemini link and it didn't work, is it yet to be implemented or is this an issue?

Hi @JulianKG, gemini support fell off my radar because we'd need to support the gemini protocol by either writing in support to elfeed or using an external library.  I'm not sure if @skeeto has feelings about either solution, but I could take a look again if there's interest -- it just won't happen until I have some time on my schedule to dig in.


Use immer within redux-actions

Hi together,
I found combining redux-actions with immer to be a very powerful combination to avoid redux boilerplate code. See the example. But I think it would be even more elegant if handleActions would natively use immer to produce the new state.
So this
import produce from 'immer';

const reducer = handleActions(
	{
		[combineActions(
			actionCreators.shoppinglist.fetchDefaultShoppinglist,
			actionCreators.shoppinglist.modifyShoppinglist
		)]: produce((state, { payload }) => {
			state.loading = payload;
		}),
	},
	initialState
);

could be written as:
const reducer = handleActions(
	{
		[combineActions(
			actionCreators.shoppinglist.fetchDefaultShoppinglist,
			actionCreators.shoppinglist.modifyShoppinglist
		)]: ((state, { payload }) => state.loading = payload,
        },
	initialState
);

This would be a performance hit and not an insignificant API change to make for this lib in my opinion. Right now it does the same job whether or not you use immer, which means it is more flexible, and remains as fast as the user needs it to be.
If you do want to avoid the boilerplate while still using immer, you can just simply wrap handleActions yourself like so.
import produce from 'immer'
import { handleActions as raHandleActions } from 'redux-actions'

export const handleActions = (actions, state) => raHandleActions(
  Object.keys(actions).reduce((acc, key) => {
    acc[key] = produce(actions[key])

    return acc
  }, {}),
  state
)

Then whenever you need to use it you would just do
import { handleActions } from 'utils/redux-actions'

const reducer = handleActions(
	{
		[combineActions(
			actionCreators.shoppinglist.fetchDefaultShoppinglist,
			actionCreators.shoppinglist.modifyShoppinglist
		)]: ((state, { payload }) => state.loading = payload,
        },
	initialState
);

I also wrap handleActions as above when I want to use immer. It would be really nice however if you could optionally pass "produce" to handleActions as an option, and have it optionally wrap the returned reducer with it. I'm pretty sure that redux-starter-kit always wraps "createReducer" with immer, and includes it as a dependency. Supporting it in redux-actions like this would be really convenient and not require immer as a dependency or peer dependency:
import { handleActions } from 'redux-actions';
import produce from 'immer';

const mutableReducer = handleActions(reducerMap, defaultState, {produce});

that would be pretty nice @raythree
You don't want to submit a PR, don't you? :D
I would love to use this feature too, but not skilled enough to make this PR..


[IconButton] Port component

[x] Component
[x] Tests (at least unit tests)
[ ] Docs
[ ] Demo

Hi, are there no tooltips anymore in v1?


Double click to show all occurrences in scrollbar is broken

Vue - Official extension or vue-tsc version
2.1.6
VSCode version
1.93.1
Vue version
2.7.16
TypeScript version
5.5.4 / 5.6.2
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
    Memory: 28.76 GB / 47.81 GB
  Binaries:
    Node: 20.17.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.10.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.3527

package.json dependencies
No response
Steps to reproduce
Double click the name of a function in a .vue file. Previously, all occurrences were highlighted in the scrollbar of VS code.
Now the highlighting in the scrollbar is missing and can only be seen in the document.
When I double click the name of a function in a .ts file, scrollbar highlighting is still working as expected.
What is expected?
Show highlighting for occurrences in scrollbar
What is actually happening?
Highlighting is missing
Link to minimal reproduction
No response
Any additional comments?
No response

Noticed something similar as well. Though it's for single click occurrences highlight.
This feature is controlled via editor.occurrencesHighlight VS Code setting. After additional investigation:

"editor.occurrencesHighlight": "single" - works in .ts files, doesn't work in .vue files
"editor.occurrencesHighlight": "multiFile" - works in .ts and .vue files

VS Code:
Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.6.0

Vue Extension v2.1.6.
TS: 5.5.4, Hybrid mode enabled

Some additional findings re the "single click occurrence highlight":

this stops working intermittently - I cannot find a pattern when it stops working. sometimes it's when I open a .vue file, sometimes its when I open vscode
toggling the editor.occurrencesHighlight option from multiFile to single and back seems to solve the problem but just temporarily until next time it breaks

It is caused by hybrid mode.

Adding screenshots for clarity (we are also seeing this issue):
When hybrid mode is enabled:

When hybrid mode is disabled:

Noticed something similar as well. Though it's for single click occurrences highlight.
This feature is controlled via editor.occurrencesHighlight VS Code setting. After additional investigation:

"editor.occurrencesHighlight": "single" - works in .ts files, doesn't work in .vue files
"editor.occurrencesHighlight": "multiFile" - works in .ts and .vue files

VS Code:
Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.6.0

Vue Extension v2.1.6. TS: 5.5.4, Hybrid mode enabled
Anything else I can provide to help resolve this?

I personally can't reproduce this anymore and it works well for me again. Since my previous comment VS Code was upgraded to 1.94.2 and TypeScript is now 5.6.3.

Sorry! Yes @cabal95 is correct and issue is still reproducible. I had "multiFile" enabled.

Same issue for me, when single clicking a symbol. It is not just the scrollbar though, it is that none of the occurrences in the code are highlighted AS WELL as the scrollbar.
VSCode 1.94.2, TypeScript 5.6.3 - Hybrid Mode enabled. Issue was introduced in VSCode 1.93

Everything worked well exactly one year ago. I took a break for a while, so does anyone know in which version it started? And what exactly do I need to roll back – the Vue extension or VSCode? Can't really work without occurrences highlighting because there's a lot of code to refactor. This is killing me.

Everything worked well exactly one year ago. I took a break for a while, so does anyone know in which version it started? And what exactly do I need to roll back – the Vue extension or VSCode? Can't really work without occurrences highlighting because there's a lot of code to refactor. This is killing me.

I find that if I roll back VSCode to 1.92.x, it works again.

I find that if I roll back VSCode to 1.92.x, it works again.

It seems like we can just use the previous version of the Vue extension.

Does anyone know the potential drawbacks of using the 1.8.27 version of the extension while working with Vue 3.5.12?


Feature/shreyagupta112/created user model integrted passport js and made admin get route

Administrative Info
#20
Changes
What changes did you make?
Created the model.js, auth.js, scure-routes.js, routes.js, and admin.js files. Model.js is the user schema, admin.js contains a get route which prints out a list of admin or non-admin users, and the other three files deal with authentication.
Testing
Testing
How did you confirm your changes worked?
I created a few fake users to test out the admin get route and authentication and got it to work locally.
Confirmation of Change
Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.
I created these files, and haven't submitted any pull requests yet, so the entirety of the files are a new change.

LGTM, will approve when @mohakvni gets a chance to take a look


Some questions about *.kpl

Hello,
Thank you for your innovative work.
I see that the 3DMatch dataset seems to have to use ".kpl" files.
Are the files ".kpl" about keypoints？
Do I must need ".kpl" files for training?
How do I get the ".kpl" files using my dataset?
I do not understand how to train using my own dataset only with "*.ply" files.
Thanks.

Hi, I think I do not have .kpl file. What I have is .pkl file which save the down-sampled point cloud and pre-computed correspondences for training. I got these two files using datasets/cal_overlap.py
https://github.com/XuyangBai/D3Feat/blob/9ca3f011dab41f51885c0836d7dd77ecf041bd37/datasets/ThreeDMatch.py#L108-L109

Hi, thank you for your sharing. However, I can not find the "scene_list_{split}.txt", where is it? Is it provided by original 3DMatch dataset? If possible, could you please share the detailed 3DMatch data preprocessing?

Hi @MrZ19 The split files are provided by the original 3DMatch. For data preprocessing, I follow the instructions of 3DMatch paper to fuse the RGBD image to get .ply file and its corresponding pose. You may find our code here or use the original implementation provided by 3DMatch.

Hi，
Is “data_object_velodyne” used when training the KITTI dataset?

No.

Hi，
there are multiple datasets in dataset "KITII". Which one will be used?
1.Download odometry data set (grayscale, 22 GB)
2.Download odometry data set (color, 65 GB)
3.Download odometry data set (velodyne laser data, 80 GB)
4.Download odometry data set (calibration files, 1 MB)
5.Download odometry ground truth poses (4 MB)
6.Download odometry development kit (1 MB)
Thanks.

3,4,5 are needed.

Hi, when I used kitti's training results to match my own data, an error occurred:
Traceback (most recent call last):
  File "demo.py", line 207, in <module>
    model = KernelPointFCNN(dataset.flat_inputs, config)
  File "/media/vge/Public/PointRegistration/D3Feat/models/KPFCNN_model.py", line 119, in __init__
    self.anchor_inputs['trans'] = flat_inputs[ind]
IndexError: tuple index out of range

Hi, when I matched my data using pretrained model from KITTI, the error occured:
Traceback (most recent call last):
  File "demo.py", line 207, in <module>
    model = KernelPointFCNN(dataset.flat_inputs, config)
  File "/media/vge/Public/PointRegistration/D3Feat/models/KPFCNN_model.py", line 120, in __init__
    self.object_inds = self.anchor_inputs['object_inds']
KeyError: 'object_inds'

What is the 'object_inds'?

Hi，I did not find how to set the batch size.
Thanks. I would be grateful if you could help me figure this out.

Currently this codebase only support batch size equals 1

Hello, I noticed that your method does not need to load an additional corresponding ‘keypoint.txt’ file when matching (such as 3DSmoothNet/TEASER++, which are required), which makes it more convenient to use our own data. How to achieve it？

Thanks! If using my own data for registration, which path will the keypoints data be stored?

you can see the following part
https://github.com/XuyangBai/D3Feat/blob/9ca3f011dab41f51885c0836d7dd77ecf041bd37/utils/tester.py#L185-L187

Thanks! But I find that the files in these paths are all about the descriptor, keypoint and score of the 3DMatch dataset. There aren't relevant files about my own test data for registration.

You can change the path to that of your dataset. D3Feat only needs .ply as input, and generates per-point descriptor, detection score. You can see https://github.com/XuyangBai/D3Feat/blob/master/demo_registration.py as an example.


[RFC] Autocomplete Design

Xi-Mac Autocomplete
At its core, autocomplete will serve as a guide to the code that the user wishes to type. It should look and feel minimal while not distracting from the coding process. The assumption is most of the time, the user already knows what they’re trying to type - Autocomplete suggestions would then reassure the user of what they’re typing or nudge them slightly to add details to their partial input, so relevant suggestions may keep appearing.
Prominent designs from other editors that feature autocomplete:
VSCode

IntelliSense presents a very minimal yet functional autocomplete interface. The current top result is highlighted, while also providing brief information related to that suggestion and only that suggestion.
The suggestions are colored according to the current input - in the image above, the “l” is colored because the current input has an “l”.
Results also have an accessory view that can be clicked on to expand the autocomplete further, if the user would like to see more information.
For other suggestions, a small icon representing what that suggestion represents is also shown. However, what the icons mean isn’t inherently obvious to the user, and would require a reference on the IntelliSense page or experience with that specific language before it can be made sense of.
Atom

Like VSCode, Atom also has a minimal autocomplete view available. There is less additional info available in results, but it is seen in all results rather than just the current highlight. Instead of icons, an initial for the suggestion type is given (so “V” would be for “variable”, etc)
Suggestions also have their characters highlighted according to the current input, but it is only highlighted with a bold (and not color), which can look very similar to non-highlighted characters at a glance.
With the Java plugin, the autocomplete exposes a lot of information related to that suggestion. This is helpful in Java which is one of the most well known OOP languages. Methods that have the same name may come from very different classes, and letting the user know that distinction is very important.
Sublime Text

Sublime opts for just the list of suggestions. Characters are highlighted to the input, but it looks more noticeable here as compared to Atom due to the black on gray contrast.
Unlike the aforementioned editors, a scroll bar is visible to scroll through more of the suggestions if there are too many. The scroll bar serves as a hint that the current input may be too broad, but it does also add a bit of unnecessary noise to a minimalistic design.
XCode

XCode serves as a primary influence for Xi-Mac designs due to its status as a native Apple product that focuses on development.
Here, the highlighted suggestion has a small information tab below it to guide users on what the document for that completion is. The scrollbar in this image isn’t inherently visible, but there are more results to be seen on scroll.
The type of the suggestion (for example, M for Method), the return type and the method signature is all provided to the user through the autocomplete.
Xi-Mac
So what would Xi-Mac’s autocomplete look like? I believe there’s merits to both the informative design and the minimalistic design presented by various editors above. As such, I’ve decided to go for both approaches.

(Excuse my figma skills, I'm still figuring this out)
Xi-Mac expose a config variable (similar to united_titlebars), called minimal_autocomplete. If it’s true, the more minimal of the design will be chosen, and vice versa. I believe this would open up many possibilities for customization while keeping our aesthetics clean.
The most important features for our autocomplete would be:

Customizable number of suggestions shown
Keyboard navigation
Hidden scroll
Contrasting colorful design, playing nicely with macOS guidelines

Comments
As always, feedback is very much appreciated 😄 . What do you think of the design, and what would you like to see Xi-Mac autocomplete be like?

NetBeans also has some rather neat code completion / reference features, which I believe deserves being brought up here.
In general I'm very much a fan of what XCode does and approve of the (so far) similar design for xi. Just a couple of notes:

Add symbol type icons at least to the extended view. Everything besides sublime seems to use them and they do make it much easier to glance over the suggestions
Stay as consistent as possible with the hover view. After all, inconsistency is the root of all evil

This looks good @nangtrongvuon!
A few notes:
you'll notice that in all of your screenshots, the start of the current symbol lines up with the start of each item in the suggestions list. You'll even notice that on Xcode, they adjust whitespace to the left in order to ensure that this alignment is consistent. I think this is an important visual cue that we will want to maintain.
I would check out the LSP documentation for completion items; seeing what we get back from language servers may influence our design.
I would check out https://github.com/google/xi-editor/issues/734, which talks about how this will be implemented in core; that may influence some of your thinking as well.
I think it would make the most sense to pick one design first (probably the more full-featured one?) and then to get that working well, and then afterwards we can add the option for a minimal mode.

The white background looks Mac-native, but I also like how Atom and VSCode change it based on the theme. Maybe the theme could control the autocomplete menu when the unified_titlebar preference is enabled?
Ideally themes would have a separate field for the autocomplete menu, but (correct me if I'm wrong) I don't think xi-core can support that yet. An interim solution is to re-use one of the existing colors, like background or gutter.


Revert "[BACKLOG-26444] Adding some missing input links to the mdi analyzer"

Reverts pentaho/pentaho-kettle#5991

@pentaho/r2d2


NUMA aware allocators

In order to efficiently use std::vector and friends, a NUMA aware allocator needs to be written.
This work needs to be complemented with a proper NUMA aware executor to allow to iterate over vectors or similar in a memory efficient manner.

Moving this to the next milestone.

There is currently some work being done on the branch os_executors (particularily this commit: bc4153914014dc5a0e741793cde4d1fe85eb87da)

We have added parallel::util::numa_allocator (see here), which uses an executor to perform first-touch on the allocated data.


Had to disable Cable Tiers because it was breaking "Vanilla" RS Exporters/Importers

Dont really need this mod. All Gui was broken in the Advanced Exporters/Importers and in "Vanilla" RS too.
Only on my Server. RS Github says it got something to do with Desync.

Duplicate https://github.com/starforcraft/Cable-Tiers/issues/34
Btw to fix this issue Refined Storage has to change some code. I can’t do anything about it.


Remove mentioning of use of the async/await syntax from TodoMVC example's readme

Description
This PR removed the "This example requires rustc v1.39.0 or above to compile due to its use of the async/await syntax." line from TodoMVC example's README because that example does not make use of the async/await syntax.
Checklist:

[ ] I have run ./ci/run_stable_checks.sh
[ ] I have reviewed my own code
[ ] I have added tests

Thanks :heart:


cli-app: expose createProcess

Expose the createProcess function written in lib/cliapp/src/Obelisk/CliApp/Process.hs
Note that the Process.hs module exports it, but it is not on the list of functions exposed by the package.

Can we rebase on develop?