Error: use of closed network connection

{"level":"debug","logger":"proxy.domain-fronting","timestamp":1630336980553,"message":"error 'read tcp <IP_ADDRESS>:34718-><IP_ADDRESS>:443: use of closed network connection' happened on direction east"}
There are a lot of this kind of logs in debug mode, clients need takes a long time to connect, and then disconnect.
The network between the server and the client is in good condition in the iperf test.
Is this a problem with the server connecting to telegram?

This is fine situation. Let me briefly explain this module: https://github.com/9seconds/mtg/tree/master/mtglib/internal/relay since early days of mtg I've spotted and verified during experiments that it is possible that connection performance drops in time due to some vague conditions (this happens from time to time). So, mtg drops a connection after some period in time. Usually, a connection lifetime is a couple of minutes. All telegram clients work fine with such situation (each client has a couple of open connections).
https://github.com/9seconds/mtg/blob/master/mtglib/internal/relay/init.go#L5-L10
Here we see that connection lives from 2 to 10 minutes. Buf if Telegram server does not send any data to a client from 20s to 1m, connection is also aborting. These numbers were taken from my own experiments in different condition and you can think about them as "they work fine in Russia". I do expect that China is different but I obviously have no ability to measure there.
I can make this tunnable, but I do suspect that you have a different issue. If nothing is blocked, then a connection is established in <10ms. If client take a long time to connect, then this issue may have 2 folds: it is possible that it take a lot of time to connect to proxy. And vice versa, it takes a lot of time to connect from proxy to Telegram. If the issue is a second one, then a connection abortion mechanism is not relevant because it is enabled only after all connections are established. If we deal with a first variant, then mtg can do nothing about it.
Can you please share cases where "clients need takes a long time to connect, and then disconnect", how does it look like from a Telegram client perspective? Also, I would like to ask you to verify that there is no any network issues from a client to mtg and from mtg to Telegram.

Of course.
After adding a proxy, the telegram client shows that it is connecting. This process lasts a long time, about ten seconds or more, even the connection fails. Now it’s connected, but it will soon again show that it’s connecting.
But I found that this situation only occurs when using IPv4, IPv6 everything is normal.
OK: Client <-- IPv4 --> MTG <-- IPv4 --> Telegram
Bad: Client <-- IPv4 --> MTG <-- IPv6 --> Telegram

I installed the official telegram MTProxy, it works normally. IPv6 not tested.
OK: Client <-- IPv4 --> MTProxy <-- IPv4 --> Telegram
At the same time, I found a new problem. MTProxy has lower latency and much faster speed than MTG. I guess this may be due to Chinese GFW targeting TLS traffic.
If you need it, I can provide vps on the same network segment for you to test.

If ipv6 makes these problems, you can disable it: https://github.com/9seconds/mtg/blob/d0f18be91da36fdfefb7f6ce1a176dc19bda33e9/example.config.toml#L45 just set only-ipv4 here and mtg won't use ipv6 connections at all

@Aoang would you mind to share if it helped or not? If such IP preference helps with GFW, I would reconsider defaults. Also, if it didn't help, it is also a valuable information 🙏

Sorry, I didn’t reply until now.
Timeline

08-30
I found that there is an issue with mtg connecting to telegram, come here to raise an issue.

08-31
Tested with telegram's MTProxy and found that everything is normal. But I overlooked this time mtg is also normal.
Yes, the issue isn‘t with mtg. But at this time, I didn’t find out.

09-01 ~ now
Test the situation of mtg under different configurations. Test different versions, such as the Erlang version.

Conclusion
The reason for the abnormal mtg connection is that the that the hosting service provider was adjusting the route at that time.

One of GFW's filtering methods is based on traffic characteristics. For example, currently only TLS mode is available in China. Using IPv4 or IPv6 is the same in this case.
But IPv6 routing is very bad in China, North and South are only between one thought. And IPv4 will have high-quality lines with low QoS in China.
So Client <---> MTG uses IPv4.
No need to consider the connection between MTG and telegram. Because won't use such the server.
But the performance of TLS isn't as expected in GFW.
Maybe we need uncharacteristic traffic instead of TLS-like traffic.


How can i get request body from this plugin ?

When I need to get the body in the request body, whether form or JSON, instead of using the URL param, how can I get it from the request in the plugin

ping @shuaijinchao

@kiritoscs because the format and structure of the body are more complex, the current version does not yet support this feature.

do we have any plan about this feature? @shuaijinchao

And I have one more question.
Following the example of the stop plugin, I called self.stop() and rewrote Response.body. Why is nothing displayed in the browser? But can see it with Curl

And I have one more question. Following the example of the stop plugin, I called self.stop() and rewrote Response.body. Why is nothing displayed in the browser? But can see it with Curl

You need to rewrite Contet-Type. In addition, self.stop() will be obsolete in subsequent versions. We need to align the logic with Go and Java. You can check the examples in the documentation in the master branch.

do we have any plan about this feature?

Yes, we will support it in subsequent versions.


TILA-801 | Create resources to hauki

Functionality that sends reservation units to Hauki as resources when reservation units are mutated to public (is_draft = False).

Why only after they are public? doesn't this mean that there's no way to edit opening hours but after the res unit is made public? isn't it too late?

Good point, it might be too late. Draft requires a name which is a good thing since we're sending the reservation unit name as the resource name. The concern with drafts are that then the name can be somewhat "foggy" at that point. Also the description is sent and it can be empty also. One thing could be that we send it send it even when draft and edit it always when editing. Perhaps we could raise this discussion to slack

Changing the sending logic a bit.

Okay now ready for review again and a now this time it will create or update the resource in reservation unit mutation.


SendBangToReceiver definition not found - unity?

Hi,
I'm just working on my first project in Unity and I've been looking up tutorials here and there. I was wondering under what circumstances it's possible to use the heavyscript.SendBangToReceiver("receivername"); ? Currently, I've set a float to change an osc frequency for an engine sound but since I forgot to add a t f b, the patch isn't updating the sound when the speed changes (despite the inspector on the unity plugin showing a change in frequency). When I click on the inspector's slider however, the sound updates  (i'm assuming it sends a bang?). Anyways, how can I just get a simple bang to send in my update function.?

hi @Latimark which release are you testing with?
Have you looked at the @hv_event descriptor you can add to receivers for a bang interface to your patch? See these links for more info:
https://enzienaudio.com/docs/index.html#02.getting_started#exposing-events
https://enzienaudio.com/docs/index.html#05.unity#exposing-and-sending-events

damn ok thanks. can i expose events as well as parameters on the same inlet ?

Hmmm interesting, I guess I purposely chose to create separate interfaces for these. With the current system I believe it will only let you have one (although I haven't tried).
You use @hv_param and add a [t b] to the receiver outlet to create bangs. You'll get a bang everytime the parameter changes.

Out of curiosity what's your use case?

Hmm, what could be causing my patch to update a change in frequency only when i move the slider in the inspector with the mouse, but not when I change the parameter with a script? I've added t f b in my pd patch....it's for a typical engine sound script where i'm associating the speed of the player object to the frequency of an osc in a patch. I can share my code if you want, it's pretty basic.

ok i noticed some more strange behavior. the sound actually updates when the value reaches either the min or the max (to the min and max) but then nothing the rest of the  time.

hm it seems i was using script.param = float rather than the script.SetParamater(Hv_script_Lib.parameter, float) and it works properly when i switched. (i saw this in a youtube tutorial oO)

Hey alright so I have another question.
I've created a script that I want to attach to a game object and rely on unity's built in 3d settings. But, I want to have many instances of this script, which rely on separate 3d positions. And they're be running simultaneously and I'll be sending different values to them also simultaneously.
also, it needs to be cross platform.
My question is in regards to file management. What needs to be done/what's the best way of doing it? Do I need to copy paste the script and rename it for every instance? What files need to be renamed? What's the best way of setting up a project for OSX and Win64 simultaneously? I know that a lot of my scripts that reference heavy scripts have to have the heavy script dragged into the inspector...do I have to do this separately for OSX and Win? Would it be better to just duplicate my project ? hmm

@Latimark the SetParameter and GetParameter methods are the recommended way to access and modify exposed parameters from the patch.

My question is in regards to file management. What needs to be done/what's the best way of doing it? Do I need to copy paste the script and rename it for every instance? What files need to be renamed? What's the best way of setting up a project for OSX and Win64 simultaneously? I know that a lot of my scripts that reference heavy scripts have to have the heavy script dragged into the inspector...do I have to do this separately for OSX and Win? Would it be better to just duplicate my project ? hmm

Every instance of the Hv_*_AudioLib gameObject can be represented by the same C# script. You don't need to copy/paste/rename. Just drag it onto another gameObject in your scene.
For cross-platform projects you can download the platform specific binaries i.e. win, macos, etc... and place them in a Plugins folder. Sometimes you might need to tell Unity which platform each binary is used on.
Note: you only need one set of the C# files for each patch you're working with. The scripts generated by the Unity OSX and Unity Win 64bit targets will be identical.


Update mentions of Census in SOMA and TileDB-SOMA repos

Where "Cell Census" is named, change it to "Census" if in the context of CZ CELLxGENE Discover. Otherwise, if no context is provided then change to full name "CZ CELLxGENE Discover Census"

[ ] Update single-cell-data/TileDB-SOMA/README.md  --> make sure to update "channel #cell-census-users." to #cellxgene-census-users
[ ] Update single-cell-data/SOMA/README.md

#cell-census-users

This channel does not exist. @pablo-gar - do you want the docs updated before this channel exists?

See:

single-cell-data/TileDB-SOMA#1211
single-cell-data/SOMA#156

@pablo-gar - all is resolved except for the slack channel name.  Awaiting your feedback on this, as it did not seem prudent to update the README to point at a non-existent channel.

See also single-cell-data/TileDB-SOMA#1213


Sparecoins Chrome Extension Compromised?

I have a sparecoins extension to my google chrome, however, the extension abruptly sent all my of my bitcoins to the address 1F1vTnyvuvYioZ6jT1F9EXk1EfQoapTsMn.
I did not send at all, and I am curious if there is some issue with sparecoins to have cause it to do that.

i need to decrypt my files


Integration tests

Setup integration tests with a set of contracts, running add, push, link, create, and update operations. Tests are run against a local geth dev node, both directly and via a truffle hd wallet provider.
Also introduces travis build stages to split package tests correctly. An initial job runs lib tests, then CLI tests (on Linux and OSX) are run in parallel with tests from examples, and only then the integration tests are run.
Fixes #22

@facuspagnuolo just updated this PR with the changes requested, especially renaming integration to tests (agree in that it's a better name). Please review again!


fix: lua/ folder in default root pattern

I think this should be the default root pattern for sumneko

I don't agree with this, you could have an arbitrarily nested lua directory in a project, and this would set this as project root.


HTTPoison not started in interactive session...?

I'm pretty new to Elixir, so maybe this is just my ignorance, but when I tried the following in iex (with a running Datomic peer):
Datomex.start_link  "localhost", 8001, "dev", "mbrainz-1968-1973"
Datomex.databases

I would get
** (exit) exited in: :gen_server.call(:hackney_manager, {:new_request, #PID<0.158.0>, #Reference<<IP_ADDRESS>4>, {:client, :undefined, :hackney_dummy_metrics, :hackney_tcp_transport, 'localhost', 8001, "localhost:8001", [], nil, nil, nil, true, :hackney_pool, 5000, false, 5, false, 5, nil, nil, nil, :undefined, :start, nil, :normal, false, false, false, :undefined, false, nil, :waiting, nil, 4096, "", [], :undefined, nil, nil, nil, nil, :undefined, nil}}, :infinity)
    ** (EXIT) no process
    (stdlib) gen_server.erl:212: :gen_server.call/3
             src/hackney_manager.erl:66: :hackney_manager.init_request/1
             src/hackney_manager.erl:56: :hackney_manager.new_request/1
             src/socket/hackney_connect.erl:183: :hackney_connect.socket_from_pool/4
             src/socket/hackney_connect.erl:36: :hackney_connect.connect/5
             src/hackney.erl:321: :hackney.request/5
             lib/httpoison/base.ex:394: HTTPoison.Base.request/9

I was able to solve the problem by first calling
HTTPoison.start

Is this the way it's supposed to work?

It's been a while, but I think you can add HTTPoison to the applications list in mix.exs and have it started automatically.

Thanks; that works. Just sent a pull request to update the README.

Awesome!


Bulk insert notifications

Current coverage is 95.90%

Merging #598 into master will increase coverage by +0.01% as of 9f746db

@@            master   #598   diff @@
=====================================
  Files          103    103
  Stmts         4242   4249     +7
  Branches         0      0
  Methods          0      0
=====================================
+ Hit           4068   4075     +7
  Partial          0      0
  Missed         174    174

Review entire Coverage Diff as of 9f746db

Powered by Codecov. Updated on successful CI builds.


Add exception cause

Given:
# repro.py
import testslide

class Cause(testslide.TestCase):
  def test_smoke(self):
    try:
      try:
        raise RuntimeError("First")
      except RuntimeError as cause:
        raise RuntimeError("Second") from cause
    except RuntimeError as cause:
      raise RuntimeError("Third") from cause

For reference, unittest reports it as:
$ python -m unittest repro
E
======================================================================
ERROR: test_smoke (repro.Cause)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/fornellas/src/TestSlide/repro.py", line 8, in test_smoke
    raise RuntimeError("First")
RuntimeError: First

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/fornellas/src/TestSlide/repro.py", line 10, in test_smoke
    raise RuntimeError("Second") from cause
RuntimeError: Second

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/fornellas/src/TestSlide/repro.py", line 12, in test_smoke
    raise RuntimeError("Third") from cause
RuntimeError: Third

----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)

Here's how TestSlide was reporting:
$ python -m testslide.cli repro.py
repro.Cause
  test_smoke: RuntimeError: Third

Failures:

  1) repro.Cause: test_smoke
    1) RuntimeError: Third
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/contextlib.py", line 120, in __exit__
        next(self.gen)
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
        yield
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 676, in run
        self._callTestMethod(testMethod)
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
        method()
      File "repro.py", line 12, in test_smoke
        raise RuntimeError("Third") from cause

Finished 1 example(s) in 0.6s
  Failed: 1

Here's how things are with this PR:
$ python -m testslide.cli repro.py
repro.Cause
  test_smoke: RuntimeError: Third

Failures:

  1) repro.Cause: test_smoke
    1) RuntimeError: Third
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/contextlib.py", line 120, in __exit__
        next(self.gen)
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
        yield
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 676, in run
        self._callTestMethod(testMethod)
      File "/home/fornellas/.pyenv/versions/3.8.4/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
        method()
      File "repro.py", line 12, in test_smoke
        raise RuntimeError("Third") from cause

      Caused by RuntimeError: Second
        File "repro.py", line 10, in test_smoke
          raise RuntimeError("Second") from cause

        Caused by RuntimeError: First
          File "repro.py", line 8, in test_smoke
            raise RuntimeError("First")

Finished 1 example(s) in 0.6s
  Failed: 1

Closes #209.

Amended nits, tkz.


Linked Discord support thread: https://discord.com/channels/783806589991780412/1071935833885651004

Same issue on Quest 1

Same issue for me on Quest 2. We have a big art opening later this year for art done on Open Brush. This seems like a nice feature for gathering advertising snapshot -- better than using the oculus camera option. Any idea when this bug will be fixed?

After updating OpenBrush to the beta version, I noticed that only the first screenshot works fine, and the second one still saves a black image.

Fixed in #554


Speed up mavsdk integration tests

At the moment the CI runs every testcase-vehicle combination of the MAVSDK three times. Each run takes around 8 minutes and 40 seconds.
With the newest fixes for the offboard & vision tests, the vision tests can also run with a speed factor bigger than one. I tested this with a speed-factor=20 40 times in a row without failure.
Additionally there are calls to poll_condition_with_timeout in several places. This function tests the condition 10 times during the timeout interval. For example in the offboard_goto call or wait_until_disarmed call. In those two methods the timeout is set fix to 60 seconds. So if the condition is not satisfied immediately, it will wait for 6 seconds until it will check the condition again.
This timeout should depend on the specific mission. For a takeoff-and-land scenario 60 seconds is way too much.
This is solved by passing the timeout from the mission as an argument. For simple cases the timeout is reduced to 10 or 15 seconds. This is tested for all combinations with the critical speed-factor of 1.
These changes reduces the time of one complete MAVSDK test run by almost 3 minutes down to 6 minutes. So it saves roughly 3 x 3 minutes = 9 minutes for the complete sitl_test CI.
Outlook:

It would make sense to scale these timeouts with the speed factor.
In stead of running all models (also non-gps) in different locations, we could pass different locations to the test runner and run all gps models multiple times with different home locations. Therefore we do not run the non-gps  models unnecessarily multiple times.

The continuous-integration/jenkins/pr-head failure is fixed if you rebase on master.

Nice, thanks! Do these timeouts also work if the tests are run at 1x?

Yes @julianoes


Implement LinearTranslation widget

One of my projects required to translate certain widgets by logical pixels. I think a simple 'LinearTranslation' widget should be provided by Flutter, since there is a 'more complicated' FractionalTranslation widget.
I think the formatting is a little off, so I wanted to ask if I can find an IntelliJ code-style file somewhere? 🤔

I signed it!

Does the Transtform widget handle this use case for you?
If so, maybe a better alternate approach would be a new constructor on Transform, and some links in the API docs from the various widgets you did look at (like FractionalTranslation) to the Transform widget.

@sellmair ping (see last comment)

@Hixie
Yes, the Transform handles this case ✅
A comment on FractionalTranslation would have helped me a lot! Sounds like a good idea to me ☺

@sellmair Would you like to update this PR to add the documentation that would have solved your problems, or should we file a bug so we'll do it in due course?


Fix for #88 (version capture)

Fixes version capture.
@ej52

Running this right now but still getting the error, had this not been merged?


UITableViewCell delete gesture dosen't work

UITableViewCell scrollView dosen't work when trying to show delete confirmation button with swipe.

Hi.
@nullproduction, It's not a problem with all swipe-sliders.
Use gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer: delegate method to handle this problem.
For example, this implementation fix the problem:
- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer {
	return YES;
}

But maybe it's too simple, i think the controller should give a method to better control this.

@nullproduction thanks. It fixes


ip2ulong() error trapping & resubmit ip_compare()

Resubmit (https://github.com/pfsense/pfsense/pull/952) which tightened ipcmp(), ip_greater_than() and ip_less_than(), and extended them to IPv6 and bad data trap.
2 modifications: error trapping in ip2ulong() and avoiding inet_pton() as required.
--- Info ---

ip_less_than() and ip_greater_than() both fail for IPv6 as they rely on 32 bit ip2ulong

ip_less_than() and ip_greater_than() both also fail for data validation as they do not trap bad data, or detect the malformed case where one arg is IPv4 and the other IPv6 due to improper user input. (One will always be "greater" or "less" than the other so one of these functions will attempt to return True if they don't error out first)

ip2long32() and ip2ulong() don't detect ip2long() returning an error, fix this so calling code can know if the returned value is good if not. (Example: code might accept IPv4 + v6 but mistakenly use ip2ulong() at some point for both)

It's easier and cleaner if ip_less_than() and ip_greater_than() call ip_compare() than ipcompare() calls the two separate sub-functions. Effectively they are aliases for it, it saves a function call.

Previously there was no way to distinguish "equal" from "bad data" (except "bad data" wasn't trapped anyway); now it returns '' for bad data and 0 for equal.

Switches to a more obvious and 'canonical' name ip_compare() for the main function, ipcmp() remains an alias to ensure nothing breaks

Avoid inet_pton() as stated by Ermal.

Testing two IPv6 addresses as < > = has extra if() clauses since Net_IPv6 is 'expensive' and IPv6 has multiple valid formats.

WIll resubmit this shortly (see last comment(s) on closed PR #972)


Erroneous rotation migrations are disabled warning

Comment
There is an id/unique on the model, it's not just a single field. I can't see how to disable the warning or how to resolve it.
Error Text
[prisma-field-encryption] Warning: could not find a field to use to iterate over rows in model RetailerDistributor.
  Automatic encryption/decryption/key rotation migrations are disabled for this model.
  Read more: https://github.com/47ng/prisma-field-encryption#migrations

Relevant Schema
model RetailerDistributor {
  retailerId     String
  distributorId  String
  isActive       Boolean     @default(true)
  authJsonString String? /// @encrypted
  retailer       Retailer    @relation(fields: [retailerId], references: [id])
  distributor    Distributor @relation(fields: [distributorId], references: [id])
  createdAt      DateTime    @default(now())
  updatedAt      DateTime    @updatedAt

  @@id([retailerId, distributorId])
}

If you follow the link in the error, you'll see in the documentation that:

Note: Compound @@id primary keys are not supported.

Would you like to open a PR to add support?
Otherwise, an immediate solution would be to add a @unique auto-incrementing integer column to act as the cursor.

Apologies, I did spend some time in the documentation, and I missed it.


python310Packages.angr: 9.2.22 -> 9.2.23

Description of changes
Update angr stack to 9.2.23

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 196637 run on x86_64-linux 1

16 packages built:

python310Packages.ailment
python310Packages.angr
python310Packages.angrcli
python310Packages.angrop
python310Packages.archinfo
python310Packages.claripy
python310Packages.cle
python310Packages.pyvex
python39Packages.ailment
python39Packages.angr
python39Packages.angrcli
python39Packages.angrop
python39Packages.archinfo
python39Packages.claripy
python39Packages.cle
python39Packages.pyvex


etcher: 1.5.60 -> 1.5.83

etcher: 1.5.60 -> 1.5.83
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/balena-io/etcher/releases.
meta.description for etcher is: "Flash OS images to SD cards and USB drives, safely and easily"
meta.homepage for etcher is: "https://etcher.io/"
Updates performed:

Version update

Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.5.83 with grep in /nix/store/67k57v7dva48rr1wcgwzkrihmj6k8bwh-etcher-1.5.83

directory tree listing: https://gist.github.com/5e6621830fff28a450f453dfa51543bd

du listing: https://gist.github.com/fd6a539b283c49d9df7956fe0c77a7e7

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
etcher

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/67k57v7dva48rr1wcgwzkrihmj6k8bwh-etcher-1.5.83 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A etcher https://github.com/r-ryantm/nixpkgs/archive/188dbde2b87713ded24d77190301d2a8af0373bf.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/67k57v7dva48rr1wcgwzkrihmj6k8bwh-etcher-1.5.83
ls -la /nix/store/67k57v7dva48rr1wcgwzkrihmj6k8bwh-etcher-1.5.83/bin

Result of nixpkgs-review 1

1 package built:
- etcher

cc @Shou for testing.

Included in https://github.com/NixOS/nixpkgs/pull/86228


Cannot submit a form inside a charm

Hello,
because of the "e.preventDefault();" (line 3941) in the metro.js, we cannot submit any form inside the charm which is really annoying.  (I was stuck for 2 hours on this bug)
Maybe we can remove this "e.preventDefault();" I didn't found in what it was useful maybe you guys know ?

+1

I did remove close charms on document click and preventDefaul an d StopPropogation linked with this. This fixed in develop branch

I've found a way you can close charms by clicking outside them using the document click event and submit inside a charm with no problems by adding this:
$(document).on('click', function(e){
     $('[data-role=charm]').each(function(i, el){
        if(!$(e.target).closest(el).length){
             if (!$(el).hasClass('keep-open') && $(el).data('displayed')===true) {
                 $(el).data('charm').close();
             }
        }
     });
 });

I've tested it with ruby on rails (using firefox and vivaldi) and nw.js, it worked perfectly fine, My purpose is based on this link consider it for metro ui 4 and the current version.


Compiler: use Colorize.on_tty_only!

Colorize.on_tty_only! is introduced in #4271, but it is not used in compiler. I think it is useful that colorize is turned on/off depending on tty detection result.
In addition, I fixed bin/crystal wrapper script to detect TTY. bin/crystal script's SUPPORTS_COLORS is really buggy, at least it isn't working correct now.

Could you seperate the changes to bin/crystal and the compiler into seperate commits? The core team might even want them in seperate prs.

ok. Please wait.

@RX14 I can separate this PR into the wrapper bug fix and others (using Colorize.on_tty_support! in compiler). This bug fix is just one line, however it causes a conflict with this PR surely (because this PR added TTY detection into this line). Do you want it really?

@MakeNowJust i'm not sure I understand what the conflict is.

@RX14 Bug fix patch:
diff --git a/bin/crystal b/bin/crystal
index 54704199d..8b4380f30 100755
--- a/bin/crystal
+++ b/bin/crystal
@@ -115,7 +115,7 @@ __has_colors() {
     return 1
   fi
 }
-SUPPORTS_COLORS=$(__has_colors)
+SUPPORTS_COLORS=$(__has_colors && echo true || echo false)
 __error_msg() {
   if $SUPPORTS_COLORS; then
     # bold red coloring

I didn't intend to fix a bug. I implemented TTY detection on the wrapper script correctly, then I fixed a bug unexpectedly.
Why cause a problem when I make a PR about Colorize!!!!

This PR diff is a little large, but it is really simple fix. I will explain:

Added Colorize.on_tty_only! to Crystal::Command#run.
Fixed --no-color option to Colorize.enabled = false, and added --color option as Colorize.enabled = true.
Removed @color instance variable and colorize, with_color method, then replaced colorize(obj) to obj.colorize. In addition, removed .toggle(@color) on commands/formatter.cr.
Two specs about compiler is broken, fixed it.
The wrapper is fixed to use colorize on TTY only.

That's all.

@MakeNowJust could you rebase this PR on master?

@straight-shoota rebased.

I'd suggest to add the option to explicitly set color mode to auto (which is the default). This would be additional to the already included --color and --no-color.
Example from man git-diff(1):
--color[=<when>]
Show colored diff.  --color (i.e. without =<when>) is the same as --color=always.  <when> can be one of always, never, or auto. [...]
 --no-color
Turn off colored diff. This can be used to override configuration settings. It is the same as --color=never.

I think this would be the best way to handle this.

@straight-shoota It was implemented in #3925...

bin/crystal run --color a.cr means bin/crystal run --color=a.cr, so --color's default value does not make a sense. I'll remove this.

Why not use --color=[always,never,auto]?

@straight-shoota It does not change meaning.

Yes it does. If --color expects a = to be assigned a value, --color a.cr will not be confused.

Yes but it is not implemented.

You mean OptionParser doesn't differentiate between --color=<when> and --color <when>? Then maybe it should or you could implement this differently.
The commands should provide an arg-less --color flag to enable colorization.

Maybe it has already been said, but to me, the <when> is useless:

--color argument: force colors
--no-color argument: disable colors
no color-related argument: automatic colors (on tty)

It is not useless but adds expressiveness.
It makes it easy to inject a configuration value into the command line arguments, like crystal --color=$MY_COLOR_SETTING ... instead of some complicated decision tree between --color, --no-color and ``.

more complex things. global state in colorize used by all apps. global state is bad. the design is being ruined. more command line switches. the direction should be to simplify things.

@larubujo This PR is about the compiler, not "all apps".

The commands should provide an arg-less --color flag to enable colorization.

I totally agree with this. But it can be merged this before implementing this feature in OptionParser, and then fixes this in PR about OptionParser.

I personally prefer @bew's suggestion.

@straight-shoota I want to revert --color=when support for now because it blocks to merge this PR and I don't think this option is needed strongly. If you want this feature really, then you can create a new pull request after fixed OptionParser.

Sorry... 🙇

@MakeNowJust are you still working on this?


EBNF: RangeLiteral

The current definition is
RangeLiteral = WS, [IntegerLiteral, WS], ['..', WS, [IntegerLiteral, WS]] ;
Is WS really a valid RangeLiteral ?

The only usage of RangeLiteral is from RelationshipDetail:
RelationshipDetail = '[', [Variable], ['?'], [RelationshipTypes], ['*', [RangeLiteral]], [Properties], ']' ;

It is valid Cypher to give only an asterisk and use the default bounds for variable length patterns, like so:
MATCH ()-[r:ACTED_IN*  ]-()
RETURN r

So yes, WS is a valid RangeLiteral. Now, that isn't very helpful, so I think I'll push the asterisk to be parsed as part of the RangeLiteral instead, removing the empty string as a valid alternative.


JSR doesn't recognize module docstring if pragma comments come before it

The file for my packages server entrypoint has a module docstring but because of this issue, Support publishing with JSX, I had to manually add pragma comments before it. The Configuring JSX in Deno documentation says that pragma comments must come first.
You can see here the module docstring is the first after my pragma comments.
<EMAIL_ADDRESS>
You can see it is not showing it here.
https://jsr.io/<EMAIL_ADDRESS>
I'm not very familiar with pragma comments, I only know that they are needed from that issue I linked. If it will work and should be after the module docstring, I can move it, although I think it would be a better user experience if it didn't matter which comments came first.

Duplicate of #605


Texture region now updates when changing an Atlas region rect

Removed atlas_changed signal for AtlasTexture
Changes are now handled by _notify_change
Removed unneccesary signal connections
Texture preview now updates in real-time

Doesn't follow coding standards, check travis build logs.

Fixed

Just found a bug that makes moving Sprites around in the main scene editor very slow.

I want to make the editor more responsive to changes, so this was only a small portion of what would need to be changed. A lot of classes don't call _change_notify when their variables are changed. Some have their own custom signals solely for the same purpose. Others do sometimes use _change_notify, but don't pass in any parameters. This inconsistency is why the property list doesn't update to corresponding changes.
The editor's unresponsiveness to changes has always been one of my major annoyances with Godot, so I want to go through and fix them all to update to changes. This is a proof-of-concept of what would need to be changed to fix that.

All resources by default have a signal to notify it changed, check base
resource class..
On Apr 3, 2017 1:39 PM, "Robert Hernandez"<EMAIL_ADDRESS>wrote:

@robertdhernandez commented on this pull request.
In scene/resources/style_box.cpp
https://github.com/godotengine/godot/pull/8209#discussion_r109464868:

@@ -105,6 +105,7 @@ void StyleBoxTexture::set_texture(RES p_texture) {
texture = p_texture;
emit_signal("texture_changed");

StyleBoxTexture had a texture_changed signal already, but it was never
emitted, rendering it useless. I think the texture_changed signal is
already redundant, as Resource has a changed signal, but I added it to
maintain consistency; otherwise, I would have opted to remove it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/8209#discussion_r109464868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2-ifP5FASEtFdXpex0X6BlOJ_lcuks5rsSDagaJpZM4MuqGK
.


Chore: anakin and sebulba folders

What?
Changed the systems folder structure.
Why?
To create a folder for Sebulba systems.
How?
copied all of the Anakin systems into their own folder.
Extra
This PR must be reviewed after #1080  and #1088

Just wondering if it makes sense to have the anakin/sebulba split one folder deeper so instead of anakin/ppo it'll be ppo/anakin. The reason I say this is to have a shared types files, because I assume a lot of the types we already will be useful to sebulba. @Louay-Ben-nessir have you used the types we already have like HiddenStates/LearnerState etc?


There can be multiple type of proofs like sha-256 and objecthash but the response of /entries resource only specify item-hash as sha-256 string. Should item-hash be an object to return all hashes?

At this stage we are not considering providing multiple alternative types of proofs.


error in docker-compose up

Hi. I met one error in running the docker-compose up.

Thank you.

update docker-compose to latest. :)
old ones can't recognize pull_policy option.


Commented few unused part and added string type test case

Can one of the admins verify this patch?

ok to test

retest this please


Question-portable rez

Hi,
Im wondering rez have the capability to be portable without any install between multiple "same-os" machine.
So let's say my first install is set to "c:/portable/rez". And if I'm taking this folder and copy to another machine (without any install) in the same path and set the PATH environment variable on this new machine, is everything will be up&running?
I'm using an older version of rez on linux, wish is portable, but the latest version on widows seems to have limitation on portability.
Thanks a lot.

Hi @plboily,
There is a thread about that here: https://groups.google.com/d/msg/rez-config/ixb1-DGQDV0/ZGElwBJGEQAJ
Cheers,
Thomas

Ok thank you.
I'll take a look
But in my test, to be portable, if you install in a directory and the portable version without install respect the same hierarchy, it's gonna work without any problem.


Follow symlinks for AQ_DRM_DEVICES

Addresses #33
Iterates over explicitly declared GPUs and canonicalizes paths. This has the additional include of <filesystem>
and <system_error>.
Currently does not check if the device is a valid drm KMS device. This could be added in the future.
Sorry for the messy git tree. Probably better to squash.
Note: This works for me, but additional testing would be greatly appreciated.

Alright, should I check for drnIsKms in this pull or a new one?

new one, I'll merge this. Sorry for my lack of respinsiveness I am in the middle of nowhere on a "kinda break"

new one, I'll merge this. Sorry for my lack of respinsiveness I am in the middle of nowhere on a "kinda break"

Aw good for you. Have a nice one!


[Builder] issue with ttfautohint post process on statics

Builder has this option:
cleanUp: Whether or not to remove temporary files. Defaults to true.
Temp directories containing UFO are not removed by default at the end of the building process anymore, and it doesn't yell "complete" anymore also. Even if I set up the parameter manually in the config.yaml, they don't get cleaned up although the build works and all.
These directories are supposed to remain only if there was an error message.
This is Rosario as a test case:
Rosario.zip

I started to see that it does that cause the builder stops at the moment of applying autohinting on italic ttf statics. So italic statics ttf are not exported, and the builder stops with no output message.

This issue is messing up lots of automations for building statics upstream

The autohinting problem is the segmentation fault for Mac M1?

Yes, possible. That package is super practical but we regularly have issues with it. We should remove the python dependency and apply autohint with normal ttfautohint with a warning to users to brew install it imo

If we drop ttfautohint-py, the unified font repository will also need updating. ttfauothint-py is handy since it includes a wheel for all platforms that we target. By dropping it to just fix the mac m1 issue, we'll need to also system install it for linux etc.

I seem to remember it was something to do with the error handler callback.


M00-LAB00: Getting Errror Your Azure Pass Subscription is expired for this promo code

Contact Details
<EMAIL_ADDRESS>What happened?
Hi , I am trying to complete the Lab exercise as part of the course and i could not access the lab with same promo code  it says "Your Azure Pass Subscription is expired for this promo code " kindly advise.
Relevant screenshots
No response

@Yasin2018 please, contact your instructor or lab provider to request the Azure Pass. Thanks.


Ignore @internal check on Drupal\Core\Entity\ContentEntityDeleteForm

Apologies, not sure whether this belongs here or in the drupal-check project.  After recently running composer update in one of our drupal projects,  drupal-check is now reporting a number of issues with code that extends ContentEntityDeleteForm.  The message is:
Extend \Drupal\Core\Entity\ContentEntityConfirmFormBase. See https://www.drupal.org/node/2491057
Looking at that drupal.org issue though, it seems that it's pretty stale, and has not yet been adopted in Drupal 9 or 10.  The ContentEntityConfirmFormBase class itself within Drupal core hasn't been modified for 2 years. Therefore it seems a little premature to refactor our code now.
Is it possible to configure drupal-check/phpstan-drupal to suppress/ignore this particular error?

I thought about this as a fix for #284, instead of linking to the issue. I'd rather folks add it to their ignored errors so we can force the discussion in Drupal core.
You don't need to refactor. Just add it to your ignored errors. Hopefully, the effort to run PHPStan against Drupal core gets this answered.


Perform environment sync operations at the same time

For Publishing API and Content Store, we need their databases to be in sync with each other when the backup is taken and restored during the environment sync.
If we don't, we can get data conflicts that stop content being published to Content Store.
Therefore bringing backups for Publishing API and Content Store to be at the same time, and the same for the restore jobs.

Surely running them at the same time doesn't actually solve the race condition? Can you describe the problem more specifically (perhaps with an example) so that we can understand the rationale for the change and figure out whether it's correct?


“The IDPROM contents are invalid” when reprogramming on Ultra5

before reprogramming:

after reprogramming:

Ultra5 has no real-machine-type (real-machine-type ?), so the system type byte and first byte of date are left unchanged. this usually ends up being FFh in both cases, but that seems to be invalid, even though the checksum is definitely still 29h:

after 1738e5ddd6aa367606f4d0a663db2160774e77ad:


Unable to run toolkit on Debian

with "default-runtime": "nvidia" set, docker is not able to run:
$ docker run hello-world
docker: Error response from daemon: failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: error adding seccomp filter rule for syscall clone3: permission denied: unknown.
ERRO[0001] error waiting for container: context canceled

The issue is already discussed here:
https://github.com/containerd/containerd/issues/6203
It seems it was recently fixed but I think the fix was not published for ubuntu 18.04. Would it be possible to backport it ? I am running on a jetson and ubuntu 20 is not yet available.

@CourchesneA the 1.6.0 release of the nvidia-container-toolkit package includes the fix for this issue for non-Jetson platforms. We are actively working on getting the Jetson fix released In the coming days.

@CourchesneA we have just published nvidia-container-toolkit=1.7.0~rc.1-1 packages with this fix for Ubuntu18.04 (and Ubuntu20.04) to our experimental repositories.
You mention that this affects "Debian" which distribution is this exactly?

It is the default image for Jetson Xavier NX:
https://developer.nvidia.com/embedded/learn/get-started-jetson-xavier-nx-devkit#write
Which seems to be an L4T version of Ubuntu 18.04
$ sudo cat /proc/version
Linux version 4.9.253-tegra (buildbrain@mobile-u64-5497-d3000) (gcc version 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef90065c0eeb7f91977701] (Linaro GCC 7.3-2018.05) ) #1 SMP PREEMPT Mon Jul 26 12:19:28 PDT 2021
$ sudo lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.6 LTS
Release:        18.04
Codename:       bionic

Hello-World is running on my system (Jetson Nano).
$ sudo cat /proc/version
Linux version 4.9.253-tegra (buildbrain@mobile-u64-5496-d5000) (gcc version 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef90065c0eeb7f91977701] (Linaro GCC 7.3-2018.05) ) #1 SMP PREEMPT Mon Jul 26 12:13:06 PDT 2021
$ sudo lsb_release -a
LSB Version:    core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.6 LTS
Release:        18.04
Codename:       bionic
$ docker run hello-world

Hello from Docker!
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
    (arm64v8)
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker ID:
 https://hub.docker.com/

For more examples and ideas, visit:
 https://docs.docker.com/get-started/

@somera it seems to be the same error, in the first case you are not using nvidia runtime so you do not encounter the error. As mentionned, I think the fix will be ported to jetson soon

@somera which version of the nvidia-container-toolkit package is installed on your system? As mentioned, the fix was released in nvidia-container-toolkit=1.7.0~rc.1-1.

To get access to this version, you need to have our experimental repo configured as described in the first note here:
https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#setting-up-nvidia-container-toolkit

@somera which version of the nvidia-container-toolkit package is installed on your system? As mentioned, the fix was released in nvidia-container-toolkit=1.7.0~rc.1-1.

This?
$ apt show nvidia-container-toolkit
Package: nvidia-container-toolkit
Version: 1.0.1-1
Priority: optional
Section: utils
Maintainer: NVIDIA CORPORATION<EMAIL_ADDRESS>Installed-Size: 1.814 kB
Depends: libnvidia-container-tools (>= 0.1.0), libnvidia-container-tools (<< 2.0.0)
Breaks: nvidia-container-runtime (<< 2.0.0), nvidia-container-runtime-hook
Replaces: nvidia-container-runtime (<< 2.0.0), nvidia-container-runtime-hook
Homepage: https://github.com/NVIDIA/nvidia-container-runtime/wiki
Download-Size: 502 kB
APT-Manual-Installed: yes
APT-Sources: https://repo.download.nvidia.com/jetson/common r32.6/main arm64 Packages
Description: NVIDIA container runtime hook
 Provides a OCI hook to enable GPU support in containers.

@klueska Thanks for the info. I can confirm the fix on the experimental repo works. Any ETA on when that will be on the main repo ?

We don't have a concrete ETA at the moment.

This is a major blocker for me running https://github.com/linuxserver/docker-plex on Ubuntu 20.04.1 LTS with the below docker-compose file.
---
version: "2.3"
services:
  plex:
    image: ghcr.io/linuxserver/plex
    runtime: nvidia
    container_name: plex
    network_mode: host
    environment:
      - PUID=1000
      - PGID=1000
      - VERSION=docker
      - UMASK_SET=022 #optional
      #- PLEX_CLAIM= #optional
      - NVIDIA_VISIBLE_DEVICES=all
    volumes:
      - /home/jcreek/plex:/config
      - /home/jcreek/plex/tv:/tv
      - /home/jcreek/plex/movies:/movies
      - /home/jcreek/plex/music:/music
    restart: unless-stopped

@jcreek are you able to verify that the 1.7.0-rc.1 addresses the issues that you are seeing?

The 1.7.0-rc.1 packages have been promoted to GA (1.7.0) and are available from our stable repositories.
See https://github.com/NVIDIA/nvidia-container-toolkit/releases/tag/v1.7.0

@CourchesneA could you close this issue if your problem has been addressed by the 1.7.0 release?

Will the update be available for Ubuntu 18.04.6 LTS (GNU/Linux 4.9.253-tegra aarch64) too?
Cause at the moment I have the current version installed:
$ sudo apt-get install nvidia-container-runtime
Paketlisten werden gelesen... Fertig
Abhängigkeitsbaum wird aufgebaut.
Statusinformationen werden eingelesen.... Fertig
nvidia-container-runtime ist schon die neueste Version (3.1.0-1).
0 aktualisiert, 0 neu installiert, 0 zu entfernen und 0 nicht aktualisiert.

@somera please follow the instructions here to add the required repos and get access to the packages. They have not yet been included in Jetpack.

@somera please follow the instructions here to add the required repos and get access to the packages. They have not yet been included in Jetpack.

ok & thx

Following the instructions here got mine going again, thanks all :) https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#docker

Works for me too. thx!

Hi, does the jetson nano include this fix yet?

https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#docker

Just uninstall docker and do this: https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html#docker


Added a way to know the nav bar dimensions using the refresh action.

I'm creating this pull request to add the feature I requested in : https://github.com/aksonov/react-native-router-flux/issues/561

Ok check this out and let me know if it is correct, I can now get the dimension of the nav bar in my reducer like so:
const reducerCreate = params=>{
            const defaultReducer = Reducer(params);
            return (state, action)=>{

              switch(action.type){
                case "refresh":
                  console.log("Nav bar dimensions:",action.navBarDimensions.height);
                  break;
                default:
                  break;
              }
              return defaultReducer(state, action);
            }
        };

Why you need custom reducer? Current scene will get navBarDimensions property.

Hmm sure but I'm new to react-native-router-flux, how would I access it otherwise?

Oh, if you need to access it from your reducer, not from your scene component, then you did right.

Why do you need this? I don't know about your app but storing dimensions in redux doesn't seems to be best practice.

agree with @rturk

Well then what should I do, would this.props. navBarDimensions work in any Schene now?

Good question, i'm not sure. It will 100% work for current scene when layout is changed, but for other scenes it will be lost probably. Let me think about it.

this.props.navBarDimensions is nowhere to be found at the moment (answering my own question above). null null null

Maybe storing nav bar dimensions in redux is only way...
Here is one solution:

don't use 'refresh' but your redux dispatch
connect RNRF Router to your redux.
all properties you passed to Router from 'connect', will be globally available across all scenes

@SudoPlz can you detail your use case, why you need dimensions?
We can explore it at Gitter. I have a fairly complex App and I've managed to make it work only using flexbox, padding, and margin in the root View of each component
Overall IMO this package is a navigation stack. Adding rendering, view, features will diverge from it's core purpose

@rturk I don't have different height for navbar, but probably will do (smaller height for landscape, for example). One usage i see now is setting top:HEIGHT within my scenes to avoid its overlapping by navbar.
In my current app it is just fixed (equal to navbar height), but what i can do it navbar height is flexible?

Ok this comment is so confusing to me right now.
This is pretty much my init.js file at the moment:
  /**
  *
  * ## Initial state
  * Create instances for the keys of each structure in placeAVote
  * @returns {Object} object with 4 keys
  */
  function getInitialState() {
    const _initState = {
      auth: new authInitialState,
      device: (new deviceInitialState).set('isMobile',true),
      global: (new globalInitialState),
      profile: new profileInitialState,
      router: new routerInitialState
    };
    return _initState;
  }

let Example = React.createClass( {
render() {
        const store = configureStore(getInitialState());

        //Connect w/ the Router
        const Router = connect()(RNRF.Router);

        // configureStore will combine reducers from Example and main application
        // it will then create the store based on aggregate state from all reducers

        var self = this;
        var renderRtBtn = function renderRtBtn(){
          return
        }
        const reducerCreate = params=>{
            const defaultReducer = Reducer(params);
            return (state, action)=>{

              switch(action.type){
                case "push":
                  store.dispatch(navigateState(action.key));    //I navigate to the state I want to go using my action creator (uses Actions.ScheneName on the background)
                  break;
                case "back":
                case "BackAction":
                  store.dispatch(navigateToPreviousState());    //I navigate to the previous state using my action creator (uses Actions.pop on the background)
                  break;
                case "refresh":
                  console.log("Nav bar height:", action.navBarDimensions.height);
                  store.dispatch(setNavBarDimensions(action.navBarDimensions));
                  break;
                default:
                  break;
              }
              return defaultReducer(state, action);
            }
        };

        // let backButtonImg = ()=><Image source={require("../assets/back_chevron.png")} style={{padding: 8,backgroundColor:'red'}}></Image>;
        //
        // <Scene key={ScheneKeys.LOGIN} type="push" title="Sign In" navigationBarStyle={{backgroundColor:Colors.primaryColor}} backButtonImage={backButtonImg} renderRightButton={()=><RightPavLogo/>}>
        // setup the router table with App selected as the initial component

        // when the hideNavBar is true we see the right button but not the left, and the opposite.
        return (
          <Provider store={store}>
            <Router hideNavBar={false} createReducer={reducerCreate} sceneStyle={{backgroundColor:'#F7F7F7'}} >
              <Scene key="modal" component={Modal} >
                <Scene key="root" navigationBarStyle={{backgroundColor:Colors.primaryColor}}  titleStyle={{color:Colors.mainTextColor, fontFamily:"Whitney"}}>
                  <Scene key={ScheneKeys.ONBOARDING} direction="vertical" component={Onboarding} type="replace" hideNavBar={true} />
                  <Scene key={ScheneKeys.LOGIN} component={EmailSignIn} hideNavBar={false} title="Sign In" type="push" renderBackButton={()=><BackBtnImg/>}  renderRightButton={()=><RightPavLogo/>}/>
                  <Scene key={ScheneKeys.REGISTER_STEP_1} component={EmailSignUpStep1} type="push" hideNavBar={true} />
                  <Scene key={ScheneKeys.REGISTER_STEP_2} component={EmailSignUpStep2} type="push" hideNavBar={true} />
                  <Scene key={ScheneKeys.REGISTER_STEP_3} component={EmailSignUpStep3} type="push" hideNavBar={true} />
                  <Scene key={ScheneKeys.REGISTER_STEP_4} component={EmailSignUpStep4} type="push" hideNavBar={true} />
                  <Scene key={ScheneKeys.TOPIC_PICK} component={TopicPick} schema="modal" type="push" hideNavBar={true} />
                  <Scene direction="vertical" key={ScheneKeys.NEWSFEED} title="News Feed" hideNavBar={true} panHandlers={null} duration={1} tabs={true} initial={true}>
                        <Scene key={ScheneKeys.TAB_NEWS} title="News Feed" component={NewsFeed} icon={TabIconFactory} navigationBarStyle={{backgroundColor:Colors.primaryColor}}  titleStyle={{color:Colors.mainTextColor, fontFamily:"Whitney"}}/>
                        <Scene key={ScheneKeys.TAB_NOTIFS} title="Notifications" component={NewsFeed} icon={TabIconFactory} navigationBarStyle={{backgroundColor:Colors.primaryColor}}  titleStyle={{color:Colors.mainTextColor, fontFamily:"Whitney"}} notifications={["a notification", "another notification"]}/>
                        <Scene key={ScheneKeys.TAB_PROFILE} title="Profile" component={Profile} icon={TabIconFactory} navigationBarStyle={{backgroundColor:Colors.primaryColor}}  titleStyle={{color:Colors.mainTextColor, fontFamily:"Whitney"}} initial={true}/>
                  </Scene>
                </Scene>
              </Scene>
            </Router>
          </Provider>
        );
      }
    });
    /**
    * registerComponent to the AppRegistery and off we go....
    */

    AppRegistry.registerComponent('ExampleApp', () => Example);

@rturk The reason I need the dimension of the navigation bar is because I want to know its height, so that I can start rendering my schene children below it. If otherwise some of my children will be hidden beneath the navigation bar. I have to specifically set my View to start at top= navigationBar.height.
@aksonov you said:

don't use 'refresh' but your redux dispatch
But the Actions.Refresh() call is currently within the react-native-router-flux code, so I cannot use my own redux dispatch within there can I?

connect RNRF Router to your redux.
I think I have that in my code in line: const Router = connect()(RNRF.Router); but I neeever really understood how it works. I NEVER managed to get dispatches from RNRF directly within my own reducers.

all properties you passed to Router from 'connect', will be globally available across all scenes
Would you please mind giving a line of code or 2 as an example to this statement?

Maybe @rturk has better solution for it, i would listen it too.

You may use your own NavBar, and dispatch redux there, right?
connect(state=>({navBarHeight:state.navbar.navBarHeight})(RNRF.Router) will pass navBarHeight prop to all your scenes (but you should store it within your navbar reducer first)

@aksonov @SudoPlz
I'm using my own NavBar so have more control over he UI. Also trying to follow redux best practices, this means that I only store app data and app state in the redux store.
Within my ownNavBar I'm listening to app state changes. If the app rotates I simply update the internal state of the NavBar height. Currently I only have two heights one for portrait one for landscape.
Also I wouldn't recommend using top for layout. Instead I'm using a View with a padding as wrapper for my content. React Native Virtual DOM is smart and will convert this to a single Native Object. The benefit of this is that different than top this will look much better for views that are rotated

 ...content

@rturk Teach me sensei! Could I please see some code with this. Trying to style views using flexbox is already hard enough for me, would you be kind enough to share some code so that I can see your custom NavBar and how you implement this?

@SudoPlz I'm OOTO with no access to my code. I'll share something mid next week.

I have the same prolem because the height of NavBar changes from IOS to Android and i want manage it in each screen.

So still no solution to this..


Replace usages of raw string names with LogSegmentName

Full refactor of ambry-store package to replace usages of string segment
names with the LogSegmentName class.

Codecov Report

Merging #1756 (c4be675) into master (78f0dcf) will increase coverage by 28.23%.
The diff coverage is 88.44%.

@@              Coverage Diff              @@
##             master    #1756       +/-   ##
=============================================
+ Coverage     45.62%   73.86%   +28.23%
- Complexity     5319     9185     +3866
=============================================
  Files           656      657        +1
  Lines         50542    50563       +21
  Branches       6316     6319        +3
=============================================
+ Hits          23062    37348    +14286
+ Misses        25522    11246    -14276
- Partials       1958     1969       +11

Impacted Files
Coverage Δ
Complexity Δ

...om/github/ambry/store/CompactAllPolicyFactory.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...com/github/ambry/store/HybridCompactionPolicy.java
75.86% <ø> (ø)
15.00 <0.00> (ø)

...va/com/github/ambry/store/StoreMessageReadSet.java
78.57% <ø> (ø)
12.00 <0.00> (ø)

.../java/com/github/ambry/store/BlobIndexMetrics.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ava/com/github/ambry/store/CompactionVerifier.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...main/java/com/github/ambry/store/DumpDataTool.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...c/main/java/com/github/ambry/store/StatsUtils.java
87.50% <87.50%> (ø)
4.00 <4.00> (?)

...in/java/com/github/ambry/store/LogSegmentName.java
96.82% <96.82%> (ø)
38.00 <38.00> (?)

...ava/com/github/ambry/store/BlobStoreCompactor.java
90.15% <100.00%> (ø)
125.00 <13.00> (ø)

...in/java/com/github/ambry/store/BlobStoreStats.java
85.68% <100.00%> (-0.85%)
143.00 <2.00> (-4.00)

... and 400 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f0dcf...c4be675. Read the comment docs.

Codecov Report

Merging #1756 (c4be675) into master (78f0dcf) will increase coverage by 28.23%.
The diff coverage is 88.44%.

@@              Coverage Diff              @@
##             master    #1756       +/-   ##
=============================================
+ Coverage     45.62%   73.86%   +28.23%
- Complexity     5319     9185     +3866
=============================================
  Files           656      657        +1
  Lines         50542    50563       +21
  Branches       6316     6319        +3
=============================================
+ Hits          23062    37348    +14286
+ Misses        25522    11246    -14276
- Partials       1958     1969       +11

Impacted Files
Coverage Δ
Complexity Δ

...om/github/ambry/store/CompactAllPolicyFactory.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...com/github/ambry/store/HybridCompactionPolicy.java
75.86% <ø> (ø)
15.00 <0.00> (ø)

...va/com/github/ambry/store/StoreMessageReadSet.java
78.57% <ø> (ø)
12.00 <0.00> (ø)

.../java/com/github/ambry/store/BlobIndexMetrics.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...ava/com/github/ambry/store/CompactionVerifier.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...main/java/com/github/ambry/store/DumpDataTool.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...c/main/java/com/github/ambry/store/StatsUtils.java
87.50% <87.50%> (ø)
4.00 <4.00> (?)

...in/java/com/github/ambry/store/LogSegmentName.java
96.82% <96.82%> (ø)
38.00 <38.00> (?)

...ava/com/github/ambry/store/BlobStoreCompactor.java
90.15% <100.00%> (ø)
125.00 <13.00> (ø)

...in/java/com/github/ambry/store/BlobStoreStats.java
85.68% <100.00%> (-0.85%)
143.00 <2.00> (-4.00)

... and 400 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f0dcf...c4be675. Read the comment docs.


fix(editor): remove MDN reference tool-tips

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Reference on how to disable:
https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_54.md#hovers-in-csslessscss-and-html
Closes #44735

Hi Sem, wasn't the plan to remove them entirely, rather than on update?

Hi Sem, wasn't the plan to remove them entirely, rather than on update?

If there is a option to do so, this is also immediate, once the editor is loaded in.

Can't we just update these options: https://github.com/freeCodeCamp/freeCodeCamp/blob/c0af99748e28204fa10fcc3a8a6730aaf84d2d79/client/src/templates/Challenges/classic/editor.tsx#L229 ?

Can't we just update these options:

My bad! I completely looked over that!

I liked the feature...

I somehow failed to notice your comment to that effect.  Sorry!
@ahmadabdolsaheb conceivably this is something we could A/B test, though it might make the editor look flaky if it shows tooltips one day and then randomly stops.

Cheers Sem, I really prefer this quieter editor. You wouldn't happen to know how to turn this off in VSCode?

File > Preferences > Settings, Search for MDN

Bliss. Thanks @Sembauke


Merge refs/heads/temp-branch-6404039043 into alpha

Merge refs/heads/temp-branch-6404039043 into alpha

This PR has been merged into alpha. Thanks for your contribution!

This PR has been merged into alpha. Thanks for your contribution!


[Fix]:Add device responsive to contact us form #3420

Related Issue
When visiting your site on a small device, the contact us form is not responsive.
Fixes:  #3420
Description

Made changes to the HTML and CSS files for proper functionality.
Modified some CSS properties.
Added media queries to ensure the site works properly on small devices.

Type of PR

[ X] Bug fix

Screenshots / videos (if applicable)

Checklist:

[X ] I have made this change from my own.
[ ] I have taken help from some online resources.
[X ] My code follows the style guidelines of this project.
[ X] I have performed a self-review of my own code.
[X ] I have commented my code, particularly in hard-to-understand areas.
[X ] My changes generate no new warnings.
[ X] I have tested the changes thoroughly before submitting this pull request.
[ X] I have provided relevant issue numbers and screenshots after making the changes.

@sailaja-adapa , now you can merge this PR.


Add unit-tests for Joda convert.

Also adds a common script to get test repos from github.
Issue #30

Alright, I think you can take a look @brunobowden

Finally - it all passes!

travis is finally working again - all green @brunobowden

My main question is why offer flexibility on which tasks you run? For now, you're only running "build". Hopefully that should remain the case. Please explain why you want to offer more?

@brunobowden ptal.  Re flexibility:
I'd had a plan to allow 2 travis entries for a single TEST_DIR:
  - TEST_DIR=com.google.code.gson-gson TEST_TASKS=assemble
  - TEST_DIR=com.google.code.gson-gson TEST_TASKS=check

this would allow you to have unit tests in the allowed failures but have translation/compilation in the required successes.  I'll put that in the Gson cl itself though - removed from this PR.

LGTM - please ignore my last comments about the assemble / build ordering. I'd do that on the next PR.

your suggestion is why i had added that code in the first place.  unfortunately, it doesn't work as expected because we made a decision long ago that j2objc translation depends on Java unit-testing.
we may want to reconsider that.

Does Travis have a feature where you can mark a certain checkpoint in the build? E.g. "Complete Stages 1&2, Failed at Stage 3"? I searched but couldn't see anything.

No it doesn't.  The only distinction is 'install' vs 'build'.  You cannot distinguish between steps of 'build' which is what we'd like


Filter hooks via file extension / file type

In the same repo, some hooks are checking only some kinds of files.
For instance, if I modify a Markdown I don't necessarily want that the hook formatting Python files runs uselessly.
Thus would be great to have an option like files, fileType or fileExtension (or anything else) so that the hook only run if that files of that kind have changed :)
This would optimise the run time too!
Example:
    {
        "name": "yapf",
        "command": "yapf -ri escape_scanner tests",
        "files": [".py"]
    },

Hey :)
I have the feeling that what you describe here should be determined by the hook command. We could definitely add such a feature in mookme, but that would probably be overkill and misleading for the following reasons :

most modern linters implement their way to run only against staged files
more specifically, it is possible in a given directory to list the files that have been changed and match a specific extension

In your case, to find *.py files changed in the package mypackage, you would cd into that package (good news, mookme already performs that the current working directory is scoped by package :) ) and run git diff --name-only --relative  --cached --diff-filter=AM -- './**/*.py'

The former becomes very handful when you have a linter or formatter that accept list of files or folders
In the case of yapf, your probleme could be solved by changing your hook from

yapf -ri escape_scanner tests
to
yapf -ri $(git diff --name-only --relative  --cached --diff-filter=AM -- './tests/**.py' './escape_scanner/**.py')
If you wanna understand the git diff command :

--name-only -> only the name of the files
--relative -> relative path
--cached -> only staged files
--diff-filter=AM -> only added or modified files
-- './tests/.py' './escape_scanner/.py' -> only files that match './tests/.py' or './escape_scanner/.py

Hello,
I don’t understand the workaround but I see at least 2 issues here:

In my opinion yapf -ri $(git diff --name-only --relative --cached --diff-filter=AM -- './tests/**.py' './escape_scanner/**.py')  feels way more confusing than

cmd: yapf -ri escape_scanner tests
ˋfiles: .py`

This means that even if I have a just modified Markdown file the Python formatter will start in the repo in order to understand it has to format nothing… A bit like if you were giving your math exam to your history teacher that would say « It’s okay for me! » because in fact it’s not his role to correct a math exam.

But I think the philosophical issue behind this is the same as my first enhancement proposal.
Either you consider MookMe as a « hook trigger » or a « hook manager ».
And I think that pre-commit is a horrible « hook trigger », especially for Monorepo, and you definitely killed it in less than 1 week of work on that point.
However I think ˋpre-commit` remains a « hook manager » with a lot of relevant and productive options. I did not say it was good but at least tunable and some options are definitely cool. It could be possible to kill it on that side too :)
And maybe adding a file key is not the best option to make MookMe better than pre-commit on hook management.

I have two concerns here :

the more we'll try to be a copy of pre-commit, the more we'll encounter the same pledges and drawbacks
the more feature and options we provide, and thus move aside from the minimalistic approach of mookme on the question of git hooks, the more features we'll to support and maintain, including compatibility assesment.

This second point is the only reason why I am heavily discussing any feature request, I do not say it is not a good idea, I just want to make perfectly sure that it is a move forward for the tool.
But I agree it could be nice to have some more management options and hook optimization, would it be possible for you to provide a poc of this so that I can wrap my head around how deep it would alter already existing filters, and how it would operate with them ?
The way I see this it should be at the step level, so each step of a given hook JSON file could have a onlyOn option that will be a regular expression.
On a given step, if this option is present, the step will be executed only if there is at least one staged file matching this regular expression.
En vrac :

beware that diff are retrieved with absolute path unless we tell git to ;)
let's at least have a warning telling the step is skipped because no file matched in place of the running.... -> success / failed logger

Proposal in https://github.com/Escape-Technologies/mookme/pull/9

I'm closing this since it has been implemented


Xcontrols Calendar layout issue

Hi,  I reported an issue with the calendar controls here:
https://github.com/teamstudio/xcontrols-domino/issues/341
And the issue was closed before explaining what changes I need to make to fix the data issue that you fixed on your site.  I am still having the problem.
Please advise, thank you.
-E

In the CalendarEntries view, all the documents had their start date in 2015, but the end date in 2016, so a simple formula agent to set the EndDate year to 2015 is all that is required to fix the data.

Grazzi


Create javascript state management tools

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

JavaScript community has many state managements tools, but framework agnostic collection can be useful when you searching tool that fit for purpose.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@kenyonj

Unfortunately we are currently blocked from merging in collection changes due to an internal CI issue. We hope to have this resolved shortly.

@kenyonj do you have any changes?


Rename 'neurological system process' to 'nervous system process'

This was brought up in #13806
@pgaudet:

I wonder, should we refer to 'neurological system', since this is how it's described in GO (AFAIK). (I always wondered why we didn't have 'nervous system process', but this may be a whole different issue).

@dosumis

I think nervous system is fine. People are more likely to understand it. We could add a formal clause
linking behavior to Uberon nervous system:

SubClassOf 'has participant' some 'nervous system'
'neurological system process' looks like it might be broader. Should be aligned with Uberon and ideally get some kind of logical def that improves the weirdly spotty classification under it. But that should be another ticket.

My point was the 'nervous system' was fine for the definition of behavior, rather than the broader 'neurological system' that this term refers to.  It might be worth keeping 'neurological system process' if the intent is broader and others think it useful.  Changing to 'nervous system process' would probably mean find a home for some of its children.   Should check whether Uberon has 'neurological system'

Hi @dosumis
I don't mind one way or the other. You can just close this issue if this is not appropriate.

Hi @dosumis
Uberon has 'neurological system' as an exact synonym for 'nervous system'.
http://www.ontobee.org/ontology/UBERON?iri=http://purl.obolibrary.org/obo/UBERON_0001016
... let me know what you would like me to do.
Thanks, Pascale

Hi @dosumis
Just as I did the merge request I saw what you were saying. Is there any way to revert it ?
I do think it’s a problem that Uberon and GO do not use the same meaning for neurological/nervous system processes. It seems to me Uberon should be the authority on this. So if we assume that neurological system is an exact synonym of nervous system as stated in Uberon, I can finish the implementation of this in GO (ie fix the regulation classes and the definitions that use ‘neurological process’).
What do you think ?

I cannot find anywhere a definition of neurological system versus nervous system. "Neurological" seems to be more used in the medical field, for example 'Neurological disorders', which are described as 'A neurological disorder is any disorder of the nervous system' (https://en.wikipedia.org/wiki/Neurological_disorder). I am closing this one.

From @judyblake
From one of our resident neurologists here at JAX
Neurology:  study of diseases of nervous system.
Nervous System:  nervous system
No where ‘neurological system'
Judy
From: Robert Burgess<EMAIL_ADDRESS>Date: Friday, October 6, 2017 at 1:45 PM
To: Judith Blake<EMAIL_ADDRESS>Subject: Re: neurological vs nervous system
I have never heard anyone say “neurological system.”  Neurological refers to things in the medical field of neurology, which are diseases of the nervous system.  I think this is like diseases of the cardiovascular system being seen by a cardiologist.  These are not diseases of the cardiological system.
Robert W. Burgess, Ph.D.
The Jackson Laboratory
600 Main St.
Bar Harbor, ME 04609
phone:<PHONE_NUMBER>
fax:<PHONE_NUMBER>
<EMAIL_ADDRESS>


Modify apply_method to handle nils

Fixes #44

There's another bug to be solved:
[7] pry(main)> df
=>
#<Daru::DataFrame:21298420 @name = 5763c93c-46bb-4707-975e-ec0be84cec96 @size = 10>
                    a          b          c          d          e
         0        foo        one      small          1          2
         1        foo        one      large          2          4
         2        foo        one      large          2          4
         3        foo        two      small          3          6
         4        foo        two      small          3          6
         5        bar        one      large          4          8
         6        bar        one      small          5         10
         7        bar        two      large          6         12
         8        bar        two      small          7         14
         9        ice        one      small          8        nil

[8] pry(main)> df.pivot_table(index: [:a], vectors: [:b], values: :e)
ZeroDivisionError: divided by 0
from /home/ubuntu/workspace/daru/lib/daru/accessors/array_wrapper.rb:70:in `/'

Perhaps we should return nil instead of ZeroDivisionError.

Good idea. mean is returning a divide by zero error because it does not consider the number of missing elements when computing the mean.
Go ahead and change it.

Could you add a test that makes sure that the issue this PR fixes has been actually fixed? This will also serve for avoiding potential pitfalls for future contributors.

Done.
Maybe we should also have min and max methods working for vectors having nils.

Yes we should.

I am about to add tests. I noticed no expect keyword in some of the specs. Is that intentional?

Those specs are incomplete. I had added a method call there just to make sure that I've not made any syntax errors.

I have created compact in array_wrapper. Does it look good? If it's alright then I will go write the same for other wrappers.

I was implementing the functions in gsl wrapper and found out that I couldn't create a vector with dtype gsl having nil values. Is it normal? This will lead to problem if we use pivot_table on a data frame having vectors of dtype gsl.
[6] pry(main)> @dv_with_missing = Daru::Vector.new [1, 2, 3, 3, nil], missing_values: [3], dtype: :gsl
TypeError: no implicit conversion to float from nil
from /home/ubuntu/workspace/daru/lib/daru/accessors/gsl_wrapper.rb:86:in `alloc'

So @data is a GSL::Vector and it does not support the #- method with an Array. Same is the case with not supporting nils. User cannot use nils if he's using GSL as the internal storage type.

I updated the functions for gsl wrapper. I think there are also many other functions like median, mode which could also be updated. What do you say?
Also, I think I should split this PR into 2 PR's

one to fix #44
another to update functions min, max, etc.

I'm concerned about the space overhead that we'll have per object if @valid_data is used too. So let it be for now. GC is a big concern when dealing with a lot of objects and it quickly becomes a bottleneck.
Also, could you try benchmarking with #compact versus writing a loop inside methods like mean and individually checking whether the value is nil or not to compute that particular stat?

Here are benchmarks:
       user     system      total        real
Sum of a vector using compact  0.000000   0.000000   0.000000 (  0.001734)
Sum of a vector without compact  0.010000   0.010000   0.020000 (  0.018389)

Here's the code for benchmark and sum functions.

Alright looks good. Just add those benchmarks to the codebase and I'll merge.

Note: Modify benchmarks to reflect the real statistics methods being used in daru.


Process Priority behavior opposite of documentation

Godot version:
3.2 beta 4
OS/device including version:
Windows 10 Pro version 1903 build 18362.535
Issue description:
The documentation tool-tip in Godot says, "Nodes with a higher process priority will have their processing callbacks executed first." However, the observed behavior is the opposite; nodes with a lower process priority are executed first.
Steps to reproduce:

Node1 has Process Priority of 0
Node2 has Process Priority of 1
Both nodes have the same script that just prints its name + the number of times executed
Run the project
Observe that Node1 always executes first instead of Node2 even though Node2 has a higher process priority (1) than Node1 (0)

Minimal reproduction project:
ProcessPriorityDemo.zip

The documentation tool-tip in Godot says, "Nodes with a higher process priority will have their processing callbacks executed first."

IIRC this is only related to processing signal callbacks.


steps.Changelog.outputs.changelog has the commit messages from the previous release.

Hello
I thought it was a comfortable action, so I tested it to try it out.
I use it as follows, but it works by including the commit message of the last release each time a new release is made.
Could you please let me know if I am using it wrong?
workflow yml code
on:
  push:
    branches: [ master ]

env:
  VERSION: '0.3.12'

jobs:
  build:
    # The type of runner that the job will run on
    runs-on: ubuntu-latest
    timeout-minutes: 30

    ...

    - name: Checkout master branch
      uses: actions/checkout@v2
      with:
        fetch-depth: 0

    - name: Check changelog
      uses: scottbrenner/generate-changelog-action@master
      id: changelog

    - name: Create Release
      id: create-release
      uses: actions/create-release@latest
      env:
        GITHUB_TOKEN: ${{ secrets.TOKEN }}
      with:
        tag_name: ${{ env.VERSION }}
        release_name: Release ${{ env.VERSION }}
        body: |
          ${{ steps.changelog.outputs.changelog }}
        draft: false
        prerelease: false

    ...

@ScottBrenner Thank you for checking quickly.


Create a simple footer exclusively for Error Component

House of Geeks 404 Page should have an image in the footer, Only a single image that of the moon should be displayed.

@hariom1625 @tusharjain0022 Thoughts?

Currently that half cut moon like svg is looking a bit weird to me . Yes, if we'll display only the image of moon , it'll look more cleaner and nice.

Suggestion : I think that the Home link in the top left corner is also not necessary as we're having that in the navbar menu also.

@tusharjain0022 I think you misunderstood the problem...I am talking about what happens when you scroll
although home button can be changed into an svg

Agreed, while scrolling the page it does look weird having that landed astronaut below the floating one over the moon, so for that, I think we can remove the image in the footer or the complete footer from the ERROR page and can keep the rest of the page as it is or instead of half-moon can have an image of a full moon.
Suggestions?

I agree with hariom, removing the footer images will make it cleaner!

Agreed, while scrolling the page it does look weird having that landed astronaut below the floating one over the moon, so for that, I think we can remove the image in the footer or the complete footer from the ERROR page and can keep the rest of the page as it is or instead of half-moon can have an image of a full moon.
Suggestions?

Yup. We should be removing the Footer component and add a custom footer especially for the error page. Although, I dont think any modification to the actual Footer component is necessary.

Agreed, while scrolling the page it does look weird having that landed astronaut below the floating one over the moon, so for that, I think we can remove the image in the footer or the complete footer from the ERROR page and can keep the rest of the page as it is or instead of half-moon can have an image of a full moon.
Suggestions?

Yup. We should be removing the Footer component and add a custom footer especially for the error page. Although, I dont think any modification to the actual Footer component is necessary.

Agreed 🙌

How About this , If the error page would render like this ??

@Vishal19111999 What do you say?

Make the footer opaque

1 (After making the footer opaque)

I've tried few more things 😄
2

3

try pink color of hamburger

4

5

@Vishal19111999  thoughts?

@tusharjain0022 We can finalize the 5th one! 🎉

BTW great work!

Great work @tusharjain0022 🤩

Looking closely, the 404 is supposed to have a gradient in the background, which would help the original mini footer in visibility, as well as the moon(planet) is to be centered a bit.
Also, the pink color #EE2A7B , in the footer will be very vibrant and would turn out to be over popping for the viewers.
What i propose is the original mini-footer, lying OVER the moon with a an opacity 95%.
ignore the burger location

https://www.figma.com/file/NyIGhH5PhxbjfDf4DNmW55/House-of-Geeks?node-id=0%3A1
Here's the figma file.

@tusharjain0022 Interested in implementing this?

working on it !! 🙌


best, worst format selectors

It would be nice if ytdl supported youtube-dl's shortcut format selectors: best, worst, bestvideo, bestaudio, worstvideo, worstaudio

Fixed in 4dc41fd8cbe1e95f9598cd513b3e34526cd5849b.

-f best for best video and audio
-f worst for worst video and audio
-f best-video for best video
 -f best-audio for best audio
-f worst-video for worst video
-f worst-audio for worst audio


Upgrade uptest to v1

Description of your changes
This PR updates uptest to v1 it includes:

update of build-module
set annotations for rendering
include missing function to dependencies
include function in examples
use unified Makefile
add project-configuration via project.mk

Fixes #
I have:

[ ] Read and followed Upbound's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
make render.show
make check-examples

/test-examples


Validate All Date Fields

ensure all year date fields have 4 digits

All error message copy is in the master doc - https://docs.google.com/a/digital.justice.gov.uk/document/d/1jRMeOHOAWBI-3FhUSywga7G28NNCioUQWyYGbqqIMms/edit
Here's one specific to DOB. Obviously only include copy after the colon.
Error (field blank): Please enter the claimant’s date of birth
Error (field invalid): Please enter the date of birth in the correct format (DD/MM/YYYY)


Cloud Speech-to-Text API C++, how to check streams sent to GCP STT service

Hi,
Currently i am using GCP STT, and facing below  issues.

the queries are not timely responded or response is incomplete
Also we see that STT  response text is very different then "what is spoken".

So is there a way, where we can download or listen to the queries sent to gcp STT service.
I worry that  my code sometime fails to send whole stream to  STT service or  may be sometime code is writing the frame slowly .
just  want to make sure that my code is sending the stream correctly or not.
Thanks
Gaurav

On the client-side, you can enable logging to see if your requests are flowing correctly.  In this case use the environment variables described here:
https://googleapis.dev/cpp/google-cloud-speech/latest/#autotoc_md1
specifically, set GOOGLE_CLOUD_CPP_ENABLE_CLOG=yes and GOOGLE_CLOUD_CPP_ENABLE_TRACING=rpc,rpc-streams
On the server-side, I am afraid (the C++ SDK team) may not be the best team to ask.  There are simply too many services for us to be experts in all of them.  With that said:

So is there a way, where we can download or listen to the queries sent to gcp STT service.

I don't think such a mechanism to query the received requests exists.
The service specific support page has links to the mailing list, the community slack channel, and the relevant stackoverlow pages:
https://cloud.google.com/speech-to-text/docs/getting-support
Also consider the troubleshooting guide:
https://cloud.google.com/speech-to-text/docs/troubleshooting


Need details to view Deployment history for all deployment scopes

This document assumes Resource Group scoped deployments, and makes no mention of viewing deployment history of other scopes.  For example, viewing the list of Subscription scoped deployments, which is probably obvious enough (look for the Deployments tab in the Subscription instead of the Resource Group), but isn't obvious at all for Tenant or Management Group scoped deployments.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4369e3ef-baf8-5ea9-cba8-87d49bbc21a4
Version Independent ID: 1ba05ac6-f9e2-3c90-c2a9-8efec79f9d23
Content: Deployment history - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deployment-history.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@seangifford - thanks for this feedback. I am adding those scopes to this article.

I have submitted an update to include viewing deployment history for other scopes. At the very least, it will get published Monday AM but it might get published today.
#please-close


IndexError: list index out of range when hiding comments?

Was hiding comments (to easily view the next top level comment) and came across this:
Traceback (most recent call last):
File "/usr/local/bin/rtv", line 9, in
load_entry_point('rtv==1.0a4', 'console_scripts', 'rtv')()
File "build/bdist.macosx-10.10-x86_64/egg/rtv/main.py", line 83, in main
File "build/bdist.macosx-10.10-x86_64/egg/rtv/subreddit.py", line 49, in loop
File "build/bdist.macosx-10.10-x86_64/egg/rtv/subreddit.py", line 110, in open_submission
File "build/bdist.macosx-10.10-x86_64/egg/rtv/submission.py", line 47, in loop
File "build/bdist.macosx-10.10-x86_64/egg/rtv/page.py", line 144, in draw
File "build/bdist.macosx-10.10-x86_64/egg/rtv/page.py", line 119, in add_cursor
File "build/bdist.macosx-10.10-x86_64/egg/rtv/page.py", line 223, in _edit_cursor
IndexError: list index out of range
close failed in file object destructor:
sys.excepthook is missing
lost sys.stderr

I hadn't updated in a while so I did that, haven't encountered this one yet. will re-open if it happens again.


set default Dockerfile CMD to -help

Default docker entrypoint is set to "run" which is an invalid argument to the ENTRYPOINT pinot-admin.sh.
setting it to -help instead.

Codecov Report

Merging #7767 (24e11ae) into master (362f3e1) will decrease coverage by 57.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7767       +/-   ##
=============================================
- Coverage     71.63%   14.59%   -57.04%
+ Complexity     4079       80     -3999
=============================================
  Files          1578     1533       -45
  Lines         80629    78764     -1865
  Branches      11982    11780      -202
=============================================
- Hits          57756    11498    -46258
- Misses        18981    66426    +47445
+ Partials       3892      840     -3052

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.59% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362f3e1...24e11ae. Read the comment docs.


Change the way store deletes rows specified by a query

Fixes https://github.com/Azure/azure-mobile-apps-js-client/issues/232

Enumerating records in a table matching the specified query and then deleting them is problematic for multiple reasons. Poor perf is one, but more importantly the generated statement may exceed the max allowed number of sql variables.
Changed the implementation to use a nested select instead.

@danderson00

:shipit:


Update transifex translations automatically via github action

Is your feature request related to a problem? Please describe.
Part of the developer notes for releasing a new version of IPFS-desktop indicate that we need to run transifex locally and then push the changes. We should instead run this as part of a release github action
Describe the solution you'd like
We should use something like https://github.com/marketplace/actions/github-transifex-actions
Describe alternatives you've considered
Running transifex locally as specified at https://github.com/ipfs/ipfs-desktop/blame/main/DEVELOPER-NOTES.md#L25
Additional context
Enabling this functionality via github actions means we wouldn't have to have devs who need to release a version create a transifex account.

Related to #1528

@lidel , this could use your input whenever you get a chance.

Yes, automating i18n would be really nice :+1:  (and we would apply it across all translated projects)
FYSA we already have Transifex set up for fetching source strings once a day (https://www.transifex.com/ipfs/ipfs-desktop/content/ → "Auto update resources"), but we don't have automation for pulling translations back – this is still a manual step done via tx  before the release.

I briefly looked at https://docs.transifex.com/transifex-github-integrations/github-tx-ui  but  afaik it still has the awkward permission model where we need to give Transifex write rights to our repo – I dont feel comfrortable with such broad permission granting to a third-party, so we can't use this.
Isolated github action you linked, namely https://github.com/sergioisidoro/github-transifex-action#pull-the-entire-current-state-from-transifex-and-commit-to-the-pr with pull_sources: false sounds better – PR is created programmatically without granting any special access to Transifex, and we only fetch translations, and dont overwrite source strings.

I completely agree with your view on permissions granted to transifex. Alright, I will look into this later thanks for your input!

this is done