Issues with MoveIt2 configuration for ABB IRB1200 Robot - Simulation

Development Environment:
     ROS 2 Rolling
     Ubuntu 24.04

After following the environment preparation tutorial and running the commands below:
dayvson@dayvson:~/ws_abb$ ros2 launch abb_bringup abb_control.launch.py description_package:=abb_irb1200_support description_file:=irb1200_5_90.xacro launch_rviz:=false moveit_config_package:=abb_irb1200_5_90_moveit_config use_fake_hardware:=true

and
dayvson@dayvson:~/ws_abb$ ros2 launch abb_bringup abb_moveit.launch.py robot_xacro_file:=irb1200_5_90.xacro support_package:=abb_irb1200_support moveit_config_package:=abb_irb1200_5_90_moveit_config moveit_config_file:=abb_irb1200_5_90.srdf.xacro

I got the following error:
dayvso@dayvson:~/ws_abb$ ros2 launch abb_bringup abb_moveit.launch.py robot_xacro_file:=irb1200_5_90.xacro support_package:=abb_irb1200_support moveit_config_package:=abb_irb1200_5_90_moveit_config moveit_config_file:=abb_irb1200_5_90.srdf.xacro
[INFO] [launch]: All log files can be found below /home/ist/.ros/log/2024-10-20-11-39-06-510986-ist-1043877
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [move_group-1]: process started with pid [1043880]
[INFO] [rviz2-2]: process started with pid [1043881]
[INFO] [static_transform_publisher-3]: process started with pid [1043882]
[INFO] [robot_state_publisher-4]: process started with pid [1043883]
[static_transform_publisher-3] [WARN] [1729435146.643934066] []: Old-style arguments are deprecated; see --help for new-style arguments
[static_transform_publisher-3] [INFO] [1729435146.651995377] [static_transform_publisher]: Spinning until stopped - publishing transform
[static_transform_publisher-3] translation: ('0.000000', '0.000000', '0.000000')
[static_transform_publisher-3] rotation: ('0.000000', '0.000000', '0.000000', '1.000000')
[static_transform_publisher-3] from 'world' to 'base_link'
[robot_state_publisher-4] [WARN] [1729435146.652556559] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[robot_state_publisher-4] [INFO] [1729435146.652636294] [robot_state_publisher]: Robot initialized
[move_group-1] Error:   Name of virtual joint is not specified
[move_group-1]          at line 77 in ./src/model.cpp
[move_group-1] [INFO] [1729435146.683659680] [move_group.moveit.moveit.ros.rdf_loader]: Loaded robot model in 0.0027739 seconds
[move_group-1] [INFO] [1729435146.683821795] [move_group.moveit.moveit.core.robot_model]: Loading robot model 'abb_irb1200_5_90'...
[move_group-1] [INFO] [1729435146.683869961] [move_group.moveit.moveit.core.robot_model]: No root/virtual joint specified in SRDF. Assuming fixed joint
[move_group-1] [WARN] [1729435146.693899673] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[move_group-1] [INFO] [1729435146.694076576] [move_group.moveit.moveit.kinematics.kdl_kinematics_plugin]: Joint weights for group 'manipulator': 1 1 1 1 1 1
[move_group-1] [INFO] [1729435146.718764404] [move_group.moveit.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[move_group-1] [INFO] [1729435146.718872487] [move_group.moveit.moveit.ros.moveit_cpp]: Listening to 'joint_states' for joint states
[move_group-1] [INFO] [1729435146.719300320] [move_group.moveit.moveit.ros.current_state_monitor]: Listening to joint states on topic 'joint_states'
[move_group-1] [INFO] [1729435146.719632247] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to '/attached_collision_object' for attached collision objects
[move_group-1] [INFO] [1729435146.719644709] [move_group.moveit.moveit.ros.planning_scene_monitor]: Stopping existing planning scene publisher.
[move_group-1] [INFO] [1729435146.719723100] [move_group.moveit.moveit.ros.planning_scene_monitor]: Stopped publishing maintained planning scene.
[move_group-1] [INFO] [1729435146.720307042] [move_group.moveit.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[move_group-1] [INFO] [1729435146.720372859] [move_group.moveit.moveit.ros.planning_scene_monitor]: Starting planning scene monitor
[move_group-1] [INFO] [1729435146.721156746] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to '/planning_scene'
[move_group-1] [INFO] [1729435146.721174033] [move_group.moveit.moveit.ros.planning_scene_monitor]: Starting world geometry update monitor for collision objects, attached objects, octomap updates.
[move_group-1] [INFO] [1729435146.721521429] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to 'collision_object'
[move_group-1] [INFO] [1729435146.721825753] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to 'planning_scene_world' for planning scene world geometry
[move_group-1] [WARN] [1729435146.722053850] [move_group.moveit.moveit.ros.occupancy_map_monitor]: Resolution not specified for Octomap. Assuming resolution = 0.1 instead
[rviz2-2] [INFO] [1729435146.859310505] [rviz2]: Stereo is NOT SUPPORTED
[rviz2-2] [INFO] [1729435146.859372682] [rviz2]: OpenGl version: 4.6 (GLSL 4.6)
[rviz2-2] [INFO] [1729435146.876161070] [rviz2]: Stereo is NOT SUPPORTED
[move_group-1] terminate called after throwing an instance of 'rclcpp::ParameterTypeException'
[move_group-1]   what():  expected [string_array] got [string]
[rviz2-2] Warning: class_loader.impl: SEVERE WARNING!!! A namespace collision has occurred with plugin factory for class rviz_default_plugins::displays::InteractiveMarkerDisplay. New factory will OVERWRITE existing one. This situation occurs when libraries containing plugins are directly linked against an executable (the one running right now generating this message). Please separate plugins out into their own library or just don't link against the library and use either class_loader::ClassLoader/MultiLibraryClassLoader to open.
[rviz2-2]          at line 321 in /opt/ros/rolling/include/class_loader/class_loader/class_loader_core.hpp
[rviz2-2] [WARN] [1729435146.965749415] [rcl.logging_rosout]: Publisher already registered for node name: 'rviz2'. If this is due to multiple nodes with the same name then all logs for the logger named 'rviz2' will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[ERROR] [move_group-1]: process has died [pid 1043880, exit code -6, cmd '/opt/ros/rolling/lib/moveit_ros_move_group/move_group --ros-args --params-file /tmp/launch_params_glxdie2f'].
[rviz2-2] [ERROR] [1729435149.984280948] [rviz2.moveit.ros.motion_planning_frame]: Action server: /recognize_objects not available
[rviz2-2] [INFO] [1729435150.014951686] [rviz2.moveit.ros.motion_planning_frame]: MoveGroup namespace changed: / -> . Reloading params.
[rviz2-2] Error:   Name of virtual joint is not specified
[rviz2-2]          at line 77 in ./src/model.cpp
[rviz2-2] [INFO] [1729435150.083227287] [rviz2.moveit.ros.rdf_loader]: Loaded robot model in 0.0027774 seconds
[rviz2-2] [INFO] [1729435150.083358530] [rviz2.moveit.core.robot_model]: Loading robot model 'abb_irb1200_5_90'...
[rviz2-2] [INFO] [1729435150.083401979] [rviz2.moveit.core.robot_model]: No root/virtual joint specified in SRDF. Assuming fixed joint
[rviz2-2] [WARN] [1729435150.097462972] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[rviz2-2] [INFO] [1729435150.097573042] [rviz2.moveit.kinematics.kdl_kinematics_plugin]: Joint weights for group 'manipulator': 1 1 1 1 1 1
[rviz2-2] [INFO] [1729435150.133940403] [rviz2.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[rviz2-2] [INFO] [1729435150.138520704] [rviz2.moveit.ros.planning_scene_monitor]: Starting planning scene monitor
[rviz2-2] [INFO] [1729435150.139283108] [rviz2.moveit.ros.planning_scene_monitor]: Listening to '/monitored_planning_scene'
[rviz2-2] [INFO] [1729435150.237054992] [interactive_marker_display_107440723022128]: Connected on namespace: /rviz_moveit_motion_planning_display/robot_interaction_interactive_marker_topic
[rviz2-2] [WARN] [1729435150.238640640] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[rviz2-2] [INFO] [1729435150.256817570] [interactive_marker_display_107440723022128]: Sending request for interactive markers
[rviz2-2] [INFO] [1729435150.290697797] [interactive_marker_display_107440723022128]: Service response received for initialization
[rviz2-2] [INFO] [1729435155.240622842] [rviz2.moveit.ros.planning_scene_monitor]: Failed to call service get_planning_scene, have you launched move_group or called psm.providePlanningSceneService()?
[rviz2-2] [INFO] [1729435155.240920451] [rviz2.moveit.ros.motion_planning_frame]: group manipulator
[rviz2-2] [INFO] [1729435155.241000486] [rviz2.moveit.ros.motion_planning_frame]: Constructing new MoveGroup connection for group 'manipulator' in namespace ''

And consequently MoveIt2 does not load MotionPlanning as shown in the image.

After researching and not finding any reference to what could be the error, I started checking the moveit configuration files and comparing the repository code with the moveit2 example files, I found a significant difference in the ompl_planning.yaml file. As a test I made the modification of:
planning_plugin: ompl_interface/OMPLPlanner
request_adapters: >-
  default_planner_request_adapters/AddTimeOptimalParameterization
  default_planner_request_adapters/ResolveConstraintFrames
  default_planner_request_adapters/FixWorkspaceBounds
  default_planner_request_adapters/FixStartStateBounds
  default_planner_request_adapters/FixStartStateCollision
  default_planner_request_adapters/FixStartStatePathConstraints

To:
planning_plugins:
  - ompl_interface/OMPLPlanner
request_adapters:
  - default_planning_request_adapters/ResolveConstraintFrames
  - default_planning_request_adapters/ValidateWorkspaceBounds
  - default_planning_request_adapters/CheckStartStateBounds
  - default_planning_request_adapters/CheckStartStateCollision
response_adapters:
  - default_planning_response_adapters/AddTimeOptimalParameterization
  - default_planning_response_adapters/ValidateSolution
  - default_planning_response_adapters/DisplayMotionPath

With the modifications when trying to run the code I got an error just signaling that the maximum acceleration of the joints was not defined, so I modified the code to:
 joint_1:
    has_velocity_limits: true
    max_velocity: 5.027
    has_acceleration_limits: false
    max_acceleration: 0.0

To:
 joint_1:
    has_velocity_limits: true
    max_velocity: 5.027
    has_acceleration_limits: true
    max_acceleration: 15.0

With this, I was able to run the simulation and it was also possible to plan and execute movements.
If anyone has the same problem, perhaps they can use this solution. Or if possible, I would like to understand if the root cause was actually just the lack of a package at the beginning of the process.

Hi Wei, can you post the log from your terminal?
One thing that I may not have made clear is that in joint_limits.yaml, all axes must be modified.
joint_limits:
joint_1:
has_velocity_limits: true
max_velocity: 5.027
has_acceleration_limits: true
max_acceleration: 15.0
joint_2:
has_velocity_limits: true
max_velocity: 4.189
has_acceleration_limits: true
max_acceleration: 15.0
joint_3:
has_velocity_limits: true
max_velocity: 5.236
has_acceleration_limits: true
max_acceleration: 15.0
joint_4:
has_velocity_limits: true
max_velocity: 6.981
has_acceleration_limits: true
max_acceleration: 15.0
joint_5:
has_velocity_limits: true
max_velocity: 7.069
has_acceleration_limits: true
max_acceleration: 15.0
joint_6:
has_velocity_limits: true
max_velocity: 10.472
has_acceleration_limits: true
max_acceleration: 15.0
Another detail is that the max_acceleration value that I configured (15.0) is not the value in the robot's datasheet, it is just a test value, I need to find the robot's manual and check this data.

Hi @dayvsonsilva,
Thanks! Dayvson
I have made the all changes in joint_limits.yaml as you mention above, for all joint.  still same problem.
here all my terminal errors:
root@9358374d31de:~/test1# ros2 launch abb_bringup abb_moveit.launch.py robot_xacro_file:=irb1200_5_90.xacro support_package:=abb_irb1200_support moveit_config_package:=abb_irb1200_5_90_moveit_config moveit_config_file:=abb_irb1200_5_90.srdf.xacro
[INFO] [launch]: All log files can be found below /root/.ros/log/2024-11-01-11-37-51-258995-9358374d31de-14269
[INFO] [launch]: Default logging verbosity is set to INFO
WARNING:root:Cannot infer URDF from `/root/test1/install/abb_irb1200_5_90_moveit_config/share/abb_irb1200_5_90_moveit_config`. -- using config/abb_bringup.urdf
WARNING:root:Cannot infer SRDF from `/root/test1/install/abb_irb1200_5_90_moveit_config/share/abb_irb1200_5_90_moveit_config`. -- using config/abb_bringup.srdf
[INFO] [move_group-1]: process started with pid [14272]
[INFO] [rviz2-2]: process started with pid [14273]
[INFO] [static_transform_publisher-3]: process started with pid [14274]
[INFO] [robot_state_publisher-4]: process started with pid [14275]
[static_transform_publisher-3] [WARN] [1730461071.515236206] []: Old-style arguments are deprecated; see --help for new-style arguments
[static_transform_publisher-3] [INFO] [1730461071.554447860] [static_transform_publisher]: Spinning until stopped - publishing transform
[static_transform_publisher-3] translation: ('0.000000', '0.000000', '0.000000')
[static_transform_publisher-3] rotation: ('0.000000', '0.000000', '0.000000', '1.000000')
[static_transform_publisher-3] from 'world' to 'base_link'
[robot_state_publisher-4] [WARN] [1730461071.580134027] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[robot_state_publisher-4] [INFO] [1730461071.580265124] [robot_state_publisher]: Robot initialized
[rviz2-2] QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
[move_group-1] Error:   Name of virtual joint is not specified
[move_group-1]          at line 77 in ./src/model.cpp
[move_group-1] [INFO] [1730461071.634989899] [move_group.moveit.moveit.ros.rdf_loader]: Loaded robot model in 0.00364555 seconds
[move_group-1] [INFO] [1730461071.635161702] [move_group.moveit.moveit.core.robot_model]: Loading robot model 'abb_irb1200_5_90'...
[move_group-1] [INFO] [1730461071.635188854] [move_group.moveit.moveit.core.robot_model]: No root/virtual joint specified in SRDF. Assuming fixed joint
[move_group-1] [WARN] [1730461071.646036422] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[move_group-1] [INFO] [1730461071.646135943] [move_group.moveit.moveit.kinematics.kdl_kinematics_plugin]: Joint weights for group 'manipulator': 1 1 1 1 1 1
[rviz2-2] MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
[rviz2-2] glx: failed to create drisw screen
[move_group-1] [INFO] [1730461071.701752886] [move_group.moveit.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[move_group-1] [INFO] [1730461071.701912497] [move_group.moveit.moveit.ros.moveit_cpp]: Listening to 'joint_states' for joint states
[move_group-1] [INFO] [1730461071.703775358] [move_group.moveit.moveit.ros.current_state_monitor]: Listening to joint states on topic 'joint_states'
[move_group-1] [INFO] [1730461071.704306196] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to '/attached_collision_object' for attached collision objects
[move_group-1] [INFO] [1730461071.704327408] [move_group.moveit.moveit.ros.planning_scene_monitor]: Stopping existing planning scene publisher.
[move_group-1] [INFO] [1730461071.705953927] [move_group.moveit.moveit.ros.planning_scene_monitor]: Stopped publishing maintained planning scene.
[move_group-1] [INFO] [1730461071.708132320] [move_group.moveit.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[move_group-1] [INFO] [1730461071.708287332] [move_group.moveit.moveit.ros.planning_scene_monitor]: Starting planning scene monitor
[move_group-1] [INFO] [1730461071.712905330] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to '/planning_scene'
[move_group-1] [INFO] [1730461071.712939169] [move_group.moveit.moveit.ros.planning_scene_monitor]: Starting world geometry update monitor for collision objects, attached objects, octomap updates.
[move_group-1] [INFO] [1730461071.713745876] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to 'collision_object'
[move_group-1] [INFO] [1730461071.714409162] [move_group.moveit.moveit.ros.planning_scene_monitor]: Listening to 'planning_scene_world' for planning scene world geometry
[move_group-1] [WARN] [1730461071.714964396] [move_group.moveit.moveit.ros.occupancy_map_monitor]: Resolution not specified for Octomap. Assuming resolution = 0.1 instead
[move_group-1] [ERROR] [1730461071.714987150] [move_group.moveit.moveit.ros.occupancy_map_monitor]: No 3D sensor plugin(s) defined for octomap updates
[move_group-1] [FATAL] [1730461071.721635528] [move_group.moveit.moveit.ros.planning_pipeline]: Exception while loading planner 'ompl_interface/OMPLPlanner': According to the loaded plugin descriptions the class ompl_interface/OMPLPlanner with base class type planning_interface::PlannerManager does not exist. Declared types are Available plugins:
[move_group-1] terminate called after throwing an instance of 'pluginlib::LibraryLoadException'
[move_group-1]   what():  According to the loaded plugin descriptions the class ompl_interface/OMPLPlanner with base class type planning_interface::PlannerManager does not exist. Declared types are
[rviz2-2] MESA: error: ZINK: vkCreateInstance failed (VK_ERROR_INCOMPATIBLE_DRIVER)
[rviz2-2] glx: failed to create drisw screen
[rviz2-2] [INFO] [1730461071.786074145] [rviz2]: Stereo is NOT SUPPORTED
[rviz2-2] [INFO] [1730461071.786197679] [rviz2]: OpenGl version: 4.5 (GLSL 4.5)
[rviz2-2] [INFO] [1730461071.828355849] [rviz2]: Stereo is NOT SUPPORTED
[ERROR] [move_group-1]: process has died [pid 14272, exit code -6, cmd '/opt/ros/rolling/lib/moveit_ros_move_group/move_group --ros-args --params-file /tmp/launch_params_fgc69_g0'].
[rviz2-2] Warning: class_loader.impl: SEVERE WARNING!!! A namespace collision has occurred with plugin factory for class rviz_default_plugins::displays::InteractiveMarkerDisplay. New factory will OVERWRITE existing one. This situation occurs when libraries containing plugins are directly linked against an executable (the one running right now generating this message). Please separate plugins out into their own library or just don't link against the library and use either class_loader::ClassLoader/MultiLibraryClassLoader to open.
[rviz2-2]          at line 321 in /opt/ros/rolling/include/class_loader/class_loader/class_loader_core.hpp
[rviz2-2] [WARN] [1730461071.925754349] [rcl.logging_rosout]: Publisher already registered for node name: 'rviz2'. If this is due to multiple nodes with the same name then all logs for the logger named 'rviz2' will go out over the existing publisher. As soon as any node with that name is destructed it will unregister the publisher, preventing any further logs for that name from being published on the rosout topic.
[rviz2-2] [ERROR] [1730461074.960847306] [rviz2.moveit.ros.motion_planning_frame]: Action server: /recognize_objects not available
[rviz2-2] [INFO] [1730461075.011500521] [rviz2.moveit.ros.motion_planning_frame]: MoveGroup namespace changed: / -> . Reloading params.
[rviz2-2] Error:   Name of virtual joint is not specified
[rviz2-2]          at line 77 in ./src/model.cpp
[rviz2-2] [INFO] [1730461075.166587617] [rviz2.moveit.ros.rdf_loader]: Loaded robot model in 0.0125437 seconds
[rviz2-2] [INFO] [1730461075.166671006] [rviz2.moveit.core.robot_model]: Loading robot model 'abb_irb1200_5_90'...
[rviz2-2] [INFO] [1730461075.166691177] [rviz2.moveit.core.robot_model]: No root/virtual joint specified in SRDF. Assuming fixed joint
[rviz2-2] [WARN] [1730461075.203112647] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[rviz2-2] [INFO] [1730461075.203266909] [rviz2.moveit.kinematics.kdl_kinematics_plugin]: Joint weights for group 'manipulator': 1 1 1 1 1 1
[rviz2-2] [INFO] [1730461075.260048684] [rviz2.moveit.ros.planning_scene_monitor]: Publishing maintained planning scene on 'monitored_planning_scene'
[rviz2-2] [INFO] [1730461075.303083566] [rviz2.moveit.ros.planning_scene_monitor]: Starting planning scene monitor
[rviz2-2] [INFO] [1730461075.304431210] [rviz2.moveit.ros.planning_scene_monitor]: Listening to '/monitored_planning_scene'
[rviz2-2] [INFO] [1730461075.481855209] [interactive_marker_display_110440514737552]: Connected on namespace: /rviz_moveit_motion_planning_display/robot_interaction_interactive_marker_topic
[rviz2-2] [WARN] [1730461075.483595995] [kdl_parser]: The root link base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.
[rviz2-2] [INFO] [1730461075.650074819] [interactive_marker_display_110440514737552]: Sending request for interactive markers
[rviz2-2] [INFO] [1730461075.693162724] [interactive_marker_display_110440514737552]: Service response received for initialization
[rviz2-2] [INFO] [1730461080.486839630] [rviz2.moveit.ros.planning_scene_monitor]: Failed to call service get_planning_scene, have you launched move_group or called psm.providePlanningSceneService()?
[rviz2-2] [INFO] [1730461080.486926103] [rviz2.moveit.ros.motion_planning_frame]: group manipulator
[rviz2-2] [INFO] [1730461080.486935337] [rviz2.moveit.ros.motion_planning_frame]: Constructing new MoveGroup connection for group 'manipulator' in namespace ''

At first I couldn't link the failures to specific reasons. My suggestion is that you check the branch you are using (Rolling).
I reproduced the process again by creating a new workspace. Again, only the changes I pointed out were necessary.
I used rosdep to ensure that all dependencies were installed.

Please open a PR to fix any configs!


feat: custom scrollbar

Is your feature request related to a problem? Please describe.
The current user interface has the default scrollbar and does not match the theme.
Describe the solution you'd like
Style the default scrollbar.

@MaySi11  do not open PR unless you have not been assigned to the issue it is not good practice in open-source else the PR will not get merged .

@MaySi11 do not open PR until you have been assigned to the issue , it is not good practice in open-source else the PR will not get merged .

@ManishaSwain8 understood


Refactor to better mirror OpenAPI terminology

Is your feature request related to a problem? Please describe.
Currently some of the terms  / organization in this project don't line up very well with OpenAPI terminology.
Examples:

"Schema" in this project refers only to something declared in the "schemas" section of the OpenAPI document. In reality, the things we call "Response" and "Property" are also schemas in OpenAPI.
"Property" refers to some property within an including schema. Properties are themselves schemas, so should be named as such.
"Responses", rather than containing a schema, currently duplicate some of the behavior of schemas. This should be fixed.

Describe the solution you'd like
The best course of action, I think, is to separate the parsing of the OpenAPI document from the reorganization of data for client generation. Currently this is done all in one pass, mixing the logic and verbiage of the parsing with the client generation.
It may be possible to find a library which already exists which will parse the document into strongly typed objects. If not, I'll write one. The terminology of the parsed document should mirror the OpenAPI specification as closely as possible.
This project will then reorganize that already-parsed data into something that makes sense for client generation. Hopefully in the process some of the schema-logic can be simplified to make more interesting response types possible.

I found https://github.com/kuimono/openapi-schema-pydantic which is pretty much perfect for our needs as a parser. I opened https://github.com/kuimono/openapi-schema-pydantic/pull/1 to get a marker file so mypy will work with it. For now, going to use my fork from this project so we can get migrating.


new dataset

@taki0112 I want to train new dataset with this model, must I resize the image to 32*32?

I have the same question as you,have you found way to train own pictures dataset? @HanYuanyuaner

me too

you could change prepare_data function to load your own dataset.
def prepare_data():
print("======Loading data======")
traindata_dir = 'e:/train/' #change your traindata_dir
testdata_dir = 'e:/test/' #change your testdata_dir
image_dim = image_size * image_size * img_channels
label_names = ['cardboard','glass','metal','trash','paper','plastic'] #change your classes
label_count = len(label_names)
train_files = [traindata_dir+s for s in label_names]
test_files = [testdata_dir+s for s in label_names]
train_data, train_labels = load_data(train_files, traindata_dir, label_count)
test_data, test_labels = load_data(test_files, testdata_dir, label_count)
print("Train data:", np.shape(train_data), np.shape(train_labels))
print("Test data :", np.shape(test_data), np.shape(test_labels))
print("======Load finished======")
print("======Shuffling data======")
indices = np.random.permutation(len(train_data))
train_data = train_data[indices]
train_labels = train_labels[indices]
indices = np.random.permutation(len(test_data))
test_data = test_data[indices]
test_labels = test_labels[indices]
print("======Prepare Finished======")
return train_data, train_labels, test_data, test_labels

or you can  train and test ratio to generate trainfile and testflie list then load.


Add I2C software_reset method.

Add method for software reset via the “General Call” address.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.
Please see the contribution instructions for more information.

We discussed this in the meeting today and decided against merging it due to a number of reasons:

It does not seem anybody would need anything else than the default implementation, so it would not build an abstraction that implementations later define, like with the rest of traits.
It is trivial to do in user code if needed: bus.write(0x0, &[0x06]).
It has potential for unintended foreign device resets.
Support for I2C General Call Reset command is rare.

Nevertheless, thank you very much for the proposal!


Add more specs for method calls with a space

This is a question disguised as optimistic patch :).
Looks like
foo (...)

(note the space after foo) is special-cased to turn single statements into expressions without the need of extra parentheses, but mulitple statements don't have this automation.
Assuming this is intentional, this patch adds coverage for it, and a few related specs since I was on it.

❤

@eregon when we write
foo (1), (2)

do you know what is (1) syntactically? On one hand, it is not an argument list, clearly. Looks like an expression, but if it was an expression, single and multiple statements in it would work without double parens (in particular, single statements would not need to be said to be special-cased).
What is it?

I don't, it might be this expr vs stmt rule in parse.y or so.

Maybe related: https://bugs.ruby-lang.org/issues/19281

So since YARP.parse('puts (:x; :y)').success? works and puts (:x; :y) itself in Ruby doesn't, which one is the correct behavior really?
@fxn Thanks by the way for creating this PR.

@eregon Any chance Matz might get his thoughts about this and how () should work in general?  () allowing multiple statements is pretty much undocumented.

It seems the behavior was changed in https://bugs.ruby-lang.org/issues/19281 so we'll adapt the specs based on that

OK, that makes sense.


fix: batched mcmc reshaping'

when the num_chains was higher or not a multiple of the number of samples to be generated with MCMC sample_batched, the samples were reshaped incorrectly: The remaining samples were pushed into the last dimension here:
https://github.com/sbi-dev/sbi/blob/b27544891ab1418ff9214886d580d2bf0ba43a3b/sbi/inference/posteriors/mcmc_posterior.py#L467
This is a fix where we first collect all the generated samples from the chains (possibly more than needed), then select as many as we need and then reshape into the desired (*sample_shape, batch_size, input_shape).
I also added tests that cover all the cases, which makes them quite slow.

@gmoss13 I had to change one thing in your reshape-permute magic to make it work for len(sample_shape) > 1. Can you please double check that this does not mess up the collection of samples from the chains?


Replacing 'Cannot be null' by 'Must not be null' in docstrings in Diagnostics.

For both Asp.Net Diagnostics and Asp.Net Core Diagnostics

Thanks, merging without waiting for all green since these are changes in comments.


Color picker - Cannot copy / paste content

Describe the bug
We cannot copy or paste content from / to the color picker.
To Reproduce
Steps to reproduce the behavior:

Go to the main calendar page
Click on any color
Try to copy the color code or paste something into it.

Expected behavior
It would be nice to be able to copy and (at least) paste content inside cells, this way we can use color codes from another place on the internet.
Additional context
I think it may be related to #55, but unsure.

I don't think it's a "we" issue; it works perfectly on Firefox. The color picker opened when doing what you say to reproduce the bug is not something we implemented, but the default fallback color picker of the browser you're on.
I guess you're trying this on Chrome...?


Add WizardCoder

Add WizardCoder

https://github.com/nlpxucan/WizardLM/tree/main/WizardCoder

Does not seem very open to me when it's restricted to research purposes only.

Looks like this isn't open for commercial use based on the disclaimer. Thus, we'll decline this PR.

The resources, including code, data, and model weights, associated with this project are restricted for academic research purposes only and cannot be used for commercial purposes.


After I upgraded from 3.1.8 to 3.2.0, I could not find the workflow instance after creating tasks in the workflow definition and clicking Run.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
After I upgraded from 3.1.8 to 3.2.0, I could not find the workflow instance after creating tasks in the workflow definition and clicking "run". I checked the database table, and found that a data was inserted into the t_ds_process_instance table, but the project_code was null. Moreover, the task instance of the task I created in 3.1.8 had the same project_code, which could not be found.

What you expected to happen
Clicking Run will show that the foreground is successful, and the background will not report an error. When I upgraded, I executed the upgraded ddl and dml sql scripts, and also tried to rebuild the database, but this situation still exists
How to reproduce
1
Anything else
No response
Version
3.2.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hive you execute the upgrade tools?

类似的问题，我用helm安装了全新的3.2.0版本后，运行一个工作流提示成功，但是实例列表没内容

Have you execute the upgrade tools? In 3.2.0 we add a new column project_code in t_ds_process_instance.

t_ds_process_instance already has a project_code field, but there is no new instance data in the table.

类似的问题，我用helm安装了全新的3.2.0版本后，运行一个工作流提示成功，但是实例列表没内容

facing the same issue, if you check the log of workers, there may be errors indicate that current cpu load average is overload or available memory is insufficient. Related to this bug: https://github.com/apache/dolphinscheduler/discussions/15047

Why can't I find the execution result in the task instance?

Is this the root of the problem? How to solve it?

类似的问题，我用helm安装了全新的3.2.0版本后，运行一个工作流提示成功，但是实例列表没内容

facing the same issue, if you check the log of workers, there may be errors indicate that current cpu load average is overload or available memory is insufficient. Related to this discussion: https://github.com/apache/dolphinscheduler/discussions/15047#discussion-5752268

https://github.com/apache/dolphinscheduler/issues/15494#issuecomment-1992100746


The secretkey in plain_acl.yml is saved in plaintext. Can I change it to ciphertext

Is Your Feature Request Related to a Problem?
The secretkey in plain_acl.yml is saved in plaintext. So theoretically, I can see the unencrypted secretkey from the text.Can I change it to ciphertext
Describe the Solution You'd Like
Secretkey writes plaintext to a file, and Rocketmq automatically encrypts plaintext into ciphertext.
Describe Alternatives You've Considered
none
Additional Context
none

if  users can see you yaml file , maybe he has the way to know the unencrypt method。


Update the Developer Guide

Add the following to the DG:

Target user profile, value proposition, and user stories: Update the target user profile and value proposition to match the project direction you have selected. Give a list of the user stories (and update/delete existing ones, if applicable), including priorities. This can include user stories considered but will not be included in the final product.
Use cases: Give use cases (textual form) for a few representative user stories that need multiple steps to complete. e.g. Adding a tag to a person (assume the user needs to find the person first)
Non-functional requirements: Note: Many of the given project constraints can be considered NFRs. You can add more. e.g. performance requirements, usability requirements, scalability requirements, etc.
Glossary: Define terms that are worth recording.

Done with commit 4acc6fc. Good job everyone!


Single-cell coordinate

Hi, I am not able to find the spatial coordinate for each cell within each core. Could you please suggest where to find this information? Thank you!

Hi, the single-cell location information is available in the folder singlecell_locations.zip on zenodo https://zenodo.org/record/4607374#.YbcFKWDMI2w.

Thank you Jana. I have another question: I couldn't interpret the expression data included in the SC_data file.
Q1: the nomenclature seems difficult to interpret, for example, what does 10311243Ru101Di Rutheni means? Is there a dictionary to translate these?
Q2: these expression values are raw and have not been transformed or scaled, is that correct?
Thank you.


To report code coverage of tests run with "npm run test"

Objective
To report code coverage of "npm run test"
Abstractions
Tried several different options, and it's finally done following steps in this article:
https://frenya.net/blog/vscode-extension-code-coverage-nyc
Tests performed
A "coverage" folder is generated with code coverage report in HTML:

Also print coverage summary in console so that we could easily check the result on the CI in future:

Screen shot
See "Tests performed".

This is very cool!

This is very cool!

Thanks, this is so quick! let me add you as a reviewer :)

I would like to report coverage if an option is specified, for example, --coverage. In CI, I don't think we care about coverage so we should be able to control when to generate coverage.


CJS / ES Module when using library with Vite Dev / Rollup

Hello there!
First of all, thank you for this awesome package 👍🏻
That's why I'd like to report this minor issue, because I guess some other people have encountered it:
asciinema-player doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module
(i.e. it doesn't have "type": "module" or an .mjs extension for the entry point).
Please contact the package author to fix.

It appears on a vanilla Astro JS installation, which is using Vite Dev Server + Rollup under the Hood.
Cheers

I'm not sure why this happens. We use Rollup to produce ES module, see here https://github.com/asciinema/asciinema-player/blob/77a92b3e53ed2799604849105a1c0d78f6c3b57f/rollup.config.js#L37

Mhhh, I see.
I will keep an eye on this during my developments, and keep you in touch here, if it's an environment specific issue, or some kind of mismatch from I don't know where 😅
If needed, I'll make a minimal repro. repo.
👋


allow shorthands to merge with previous line

When I use shrinko8 in sizecode/tweetcart situations, I often have to edit the output to change lines like this:
x=3y=4
?'score'

into this: x=3y=4?'score'
I'm not 100% sure that change this won't break the semantics of some carts, but the local logic seems sound to me: the only thing that should prevent a shorthand from merging onto the previous line is if the previous line already has a shorthand
Also, I manually edited the test cases I changed, and the tests passed. (I wonder if adding a new type of test that checks cart runtime behavior would be helpful -- likely by using printh to produce output files)

Running pico8 during the test is a good idea - I've added a --pico8 option to the run_tests.py for this now (only hit upon 4 pico8 bugs in the process 😛)
Your changes look great, thanks! I'll do a bit more local testing and push it (I think I'll be doing the thing where I'll be closing merge requests with a "merged" tag).

Note that this change does seem to cost an average of 0.06 compressed bytes per characters saved, but this seems worth it, so I've pushed.

Hm, maybe don't merge the two lines if a space would be required to replace the newline? e.g. do merge x=3+if(x)foo() =>x=3if(x)foo() but don't merge  x=y+if(x)foo() =>x=y if(x)foo()
or similarly, only merge ?, but don't merge if/while.
I have no idea how well any of that works, but I suspect that merging ? is always a win, because it only ever shows up in the shorthand context
(a focus-char option seems reasonable! it may not do much (yet?) but it seems like a fine idea to me. there's certainly tension between the two goals (chars/compressed-chars) sometimes, and I usually only care about one of them for any given cart)

I did a bit of testing myself (just 2 very simple carts) to compare the old code against the new merge-happy code. I noticed something surprising -- pico8's compression was 1 byte better than shrinko8 (on these two very specific carts). Maybe the difference you're seeing between the old code and the new code is due to something inside your heuristics that usually make shrinko8 better at compressing than pico8?
The carts in question were "04.p8" and "12.p8" of https://mboffin.itch.io/pico-8-top-down-adventure-game-tutorial although I think I renamed the carts. Here's 12.p8, which pico8 compresses to 813 bytes, and shrinko8 now compresses to 814 (before this commit it was 813 as well)
function _init()a()y()l=false u=false end function _update()if not u then g()v()p()else
if(btnp(❎))extcmd"reset"
end end function _draw()cls()if not u then k()w()
if(btn(❎))m()
else b()end end function a()h=0j=30q={18,32,33,34,36,37,50,52}x={20}z={52}𝘢={23}𝘣={24}𝘤={23}𝘥={7}𝘦={36}end function g()if h<0then 𝘧()h=j end h-=1end function k()c=flr(n.e/16)*16r=flr(n.f/16)*16camera(c*8,r*8)map(0,0,0,0,128,64)end function e(n,t,i)f=mget(t,i)for e=1,#n do
if(f==n[e])return true
end return false end function 𝘨(n,f)return not e(q,n,f)end function s(n,e)f=mget(n,e)mset(n,e,f+1)end function 𝘩(n,e)f=mget(n,e)mset(n,e,f-1)end function 𝘪(e,f)n.t+=1s(e,f)sfx(1)end function 𝘫(e,f)n.t-=1s(e,f)sfx(2)end function 𝘬(e,f)n.i+=5s(e,f)sfx(1)end function y()n={}n.e=3n.f=2n.d=1n.t=0n.i=0end function w()spr(n.d,n.e*8,n.f*8)end function v()t=n.e i=n.f
if(btnp(⬅))t-=1
if(btnp(➡))t+=1
if(btnp(⬆))i-=1
if(btnp(⬇))i+=1
𝘭(t,i)if 𝘨(t,i)then n.e=mid(0,t,127)n.f=mid(0,i,63)else sfx(0)end end function 𝘭(f,t)if e(x,f,t)then 𝘪(f,t)elseif e(z,f,t)and n.t>0then 𝘫(f,t)elseif e(𝘦,f,t)then 𝘬(f,t)end end function m()d=c*8+40o=r*8+8rectfill(d,o,d+48,o+30,0)print("inventory",d+7,o+4,7)print("keys "..n.t,d+12,o+14,9)print("gold "..n.i,d+12,o+20,9)end function 𝘧()for n=c,c+15do for f=r,r+15do if e(𝘢,n,f)then s(n,f)sfx(3)elseif e(𝘣,n,f)then 𝘩(n,f)sfx(3)end end end end function p()if e(𝘥,n.e,n.f)then l=true u=true elseif e(𝘤,n.e,n.f)then l=false u=true end end function b()camera()if l then print("★ you win! ★",37,64,7)else print("game over! :(",38,64,7)end print("press ❎ to play again",20,72,5)end

Thanks for the ideas & example files!
I've worked on the compression algorithm some more (there was some stuff left undone) and did get some fair benefits.
It didn't really change the situation where this PR costs ~0.06 compressed bytes per characters saved (less than before [rounded away]) - but it does much more than makes up for it.
Maybe at some point I'll look into more systematically adding extra whitespace to improve compression ratio, and then add the option to control whether to prefer that or character count.


elfparser: Add method to load BPF from an io.ReaderAt

This patch adds the LoadBpfFromReader to the bpfSDKClient to load an ELF file from an io.ReaderAt. With this patch, it becomes possible to load an ELF binary embedded in an application binary using go:embed as the following:
package main

import (
	"bytes"
	_ "embed"

	"github.com/aws/aws-ebpf-sdk-go/pkg/elfparser"
)

func main() {
	elfc := elfparser.New()
	reader := bytes.NewReader(_ElfFileBytes)
	elfc.LoadBpfFromReader(reader, "global")
}

//go:embed bpf/kprobe.bpf.elf
var _ElfFileBytes []byte

I like it. do you want to add a test too?

Hi @dims, Thank you for your review.
Sure! I've added the testcase.

I've made fixes based on the feedback. Happy with these changes?


ScoreBoard update request

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is Get the score board on top, with a better design.
Ex. I'm always frustrated when I need to go at the bottom of the screen, to view my score.
Describe the solution you'd like
Below the good afternoon message, the score board should be placed, with a better, more circular design.
Describe alternatives you've considered
I am not sure why the project isn't running on my local machine, I think have some issues on my side, will resolve it, so just creating an issue for this feature request.
Additional context
Not yet, but yours project is good, found it on HashNode.
Will be coming up with more feature updates when it runs on mine ;)
Twitter ?
I am here

Thank you for your idea, Prakhar. The reason it's shaped as a hexagon is to tie in with the branding, like a beehive. For now, I'd like to keep it at the bottom as my daughter likes to have quick access to the games and would rather scroll to see her points. But as more features are added (she wants to be able to do something with her points) this may need to be revisited. Thank you.


Deposit Issue Binance api

I read the document for the deposit. I followed the steps but I am stuck in one step
step 1: I get the deposit address for deposit crypto i.e USDT through the binance api. because i am using binance apis to create my exchange. If my users want to deposit crypto using binance api.
step 2: I have usdt address, then I login to my kucoin account in my mobile app and then withdraw the 20 USDT to the address created in 1st step
step 3: In this step, How binance knows whether it receives 20 USDT or not, any webhook or any other method please help me,
Please help me
Thanks

Message https://t.me/boydtech on telegram he’s the best on account recovering

Hello,
sorry for late reply. For the mentioned situation, I believe you can use this GET /sapi/v1/capital/deposit/hisrec endpoint - named "Deposit History (supporting network) (User Data)" in Postman - to get the Deposit History.
User data Websocket Stream is not support, but if you want to develop your own project, you can refer to https://binance-docs.github.io/apidocs/spot/en/#payload-balance-update to receive deposits or withdrawals from the account information.


iOS module bundle

Hi,
From where iOS module for multiple image select can be downloaded. I also try to compile the module but it says YPImagePicker : No such module and class definition is not available in project. Any help will be appreciated.
Regards,
Moiz

Added!


Disable DCHECKs related to ScrollBegin event

When testing https://github.com/electron/electron/issues/13137 I have encountered these assertions. I grouped them together since they are all related to the ScrollBegin event.

Any idea why we hit it?

Any idea why we hit it?

I think it is related to our code  in NativeWindowMac listening to the NSScrollWheel events.

/trop run backport-to electron-3-0-x


Do not export the submodules gost-engine

Remove gost-engine from the distribution tarball.
Signed-off-by: Hu Keping<EMAIL_ADDRESS>

Thank you

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged. Thanks!


fix: update types

follow up to #266

The generated types still have some issues to work out,
See my work in octokit-next: octokit/octokit-next.js#104
https://github.com/drwpow/openapi-typescript/issues/984


Error in getter for watcher "displayData": "TypeError: Cannot use 'in' operator to search for null

If sort column value is null, then sort function has this error:
Error in getter for watcher "displayData": "TypeError: Cannot use 'in' operator to search for 'full_name' in null"

Hello @merigold, can you please provide more details into how it is failing, if you could create a codepen or codesandbox it would be awesome. Thank you

If I have data like this:
model
{ name:'test',
cattegory:{
   name:'test-cattegory'
}
}

When cattegory is null, I have this error.

I'm not able to reproduce the issue. If the value for the sort column is null we just replace it with ''


fix name to make "npm shrinkwrap" work

Awesome, Thanks!

Will publish this as soon as I can.

Awesome. Would be cool to have it on NPM soon.

1.0.3 is now up on npm.

excellent
On 3 September 2015 at 17:39, Tom Gallacher<EMAIL_ADDRESS>wrote:

1.0.3 is now up on npm.
—
Reply to this email directly or view it on GitHub
https://github.com/tomgco/chrome-cpu-profiler/pull/5#issuecomment-137488594
.


code error

There is no Generator3DLUT_identity  in the code. Please help me, thank you.

And image size is less than 512, how do you deal with it? I don't see it in the code.

There is no Generator3DLUT_identity in the code. Please help me, thank you.

I am experiencing the same problem and would like to know how you resolved the problem？


Launcher failing while installing dependencies

Seems to be an issue with pillow specifically but Im not too sure how to read it.
zelda3.log

Same error here, the launcher is building the Pillow wheel from source but zlib-devel is required and there's no easy way in Windows to automatically install zlib-devel. Building pillow with --global-option="build_ext" --global-option="--disable-zlib" --global-option="--disable-jpeg" no longer works either. Pillow has prebuilt wheels to download but they're all 64 bit and the launcher uses a 32 bit build of python.

I can also confirm the error and the logs state it's failing at pillow as others have noted.

I just want to add that I'm having the same issue. The error says it can't install dependencies.

same issue.

Wow this is open source at its usual

Doesnt even work on an intel machine surface pro

Python version was updated with release v<IP_ADDRESS> and should now use the version currently recommended in snesrev's project.


Codecov is not running for some of the PRs

Summary:
Codecov should run and comment should appear automatically on PRs with code coverage information. Recently it seems to be not happening for some of the PRs.

@maskaravivek Does it work on master branch PRs?

Nope

@maskaravivek Looks like this one is resolved, I can see the report on my PR https://github.com/commons-app/apps-android-commons/pull/3892


Wish Updates

changes by @sekaiwish from ZeruLight
This PR should be merge as squash

Closed because US6 Erupe version


Fix examples/cifer10_cnn.py error by missing steps_per_epoch parameter at model.fit_generator

Summary
examples/cifer10_cnn.py
This python script don't work because error.
ValueError: steps_per_epoch=None is only valid for a generator based on the keras.utils.Sequence class. Please specify steps_per_epoch or use the keras.utils.Sequence class.
Fix missing steps_per_epoch parameter at model.fit_generator
Related Issues
PR Overview

[n] This PR requires new unit tests [y/n] (make sure tests are included)
[n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[y] This PR is backwards compatible [y/n]
[n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

The output of flow is in fact a Sequence, so the argument steps_per_epoch is not required. Can you check that your version of Keras is up-to-date?

The output of flow is in fact a Sequence, so the argument steps_per_epoch is not required. Can you check that your version of Keras is up-to-date?

Hi, @fchollet . Thanks for your reply. I bought a your keras book Japanese version.
When I runed cifer10_cnn.py code on google colaboratory, found this error.
I check keras version on google colaboratory by this code.
import keras
print(keras.__version__)
and this version number is printed.
2.2.4

@fchollet , I made 2 scripts on google colab to compare(keras version is 2.2.4).
cifer10_cnn code that steps_per_epoch is missing(now keras/examples code)
It can not train by ValueError.

ValueError: steps_per_epoch=None is only valid for a generator based on the keras.utils.Sequence class. Please specify steps_per_epoch or use the keras.utils.Sequence class.

cifer10_cnn code that step_per_epochs is added
It can train. no error.


Add a document describing key revocation

This document lays out some of the options for key revocation that have been discussed. These options might eventually fit better as part of the key management document, but are posted separately for the sake of discussion.

I could also see a use case for a middle ground, where there's several types of keys used by an organization. One to identify "this content was produced by this organization" and another key that claims "we believe this content is currently secure". That would allow Docker to use a longer lifetime key on something like a 4 year old ubuntu image, that we know has vulnerabilities, but still want to know that Docker signed it. And since that image isn't changing, it could go through a more controlled offline signing process with a longer lived key. While the ubuntu image that was just updated yesterday, that we think is secure, may get signed with a key that expires in a week.

I haven't been looking at the problem as broadly as all of you - on purpose - but I'm strongly in favor of expiration approaches rather than revocation ones.
Transparency logs + timestamps are better than revocation IMO - and can also be made compatible with most air-gapped scenarios.
So, overall strong +1 to this entire document @mnm678 :)

This LGTM!

I started writing up some thoughts and concerns for the scaling problem of maintaining all the public and private content we expect to see currently, and the coming years.
Before getting into the tradeoffs of short-lived, long-lived keys, how we might continually update those, or how we might manage revocations or allow lists, I figured I'd outline a sense of scale.
Please see: Scaling Public & Private Registries, and perhaps we can have a discussion there.
My hope is we can have a baseline of scale, and then the various approaches may start to become more obvious.

To be honest those are still tiny numbers compared to other public-key crypto key management systems in the wild today. Could you be more specific on what you think will be a scaling issue here?

@mnm678, I can see this doc being used in one of two ways:

A good generalization of the key revocation scenarios, as general background reference we consider through our designs.
A discussion for how TUF solves some of the problems (not trying to state quantity, just that it's an opinionated approach)

If you can strip this down to general background on the scenarios, we can merge it into the repo as good overview for the reader, regardless of implementation. As we develop the key management specs of Notary v2, we can reference this, and update it to reflect how Notary v2 solves these problems.
Or, we can transfer this as a discussion, capturing an opinionated view on TUF.
The difference allows us to merge content (1) we haven't closed on a direction with, vs. opinionated content on a specific solution we haven't committed to yet (2)

Thanks @SteveLasker and @sudo-bmitch. I updated the description of TUF's approach to key revocation to more generally describe combining explicit and implicit revocation.

Thanks @mnm678,
The description has references to TUFs implementation, so I think you're asking for this to move to a discussion for how TUF solves these problems, as opposed to the general background, not referencing specific implementations.
We can transfer "issues" to "discussions", but we can't transfer PRs to "discussions".
Can you create a discussion titled something like "Describing Key Revocation with TUF", link this PR and close this one?

I guess I wasn't clear. I re-worded the final option to explain how implicit and explicit key revocation can be used in general so that it can be discussed in the context of other approaches to key revocation. The technique of combining implicit and explicit key revocation was introduced in this paper by @justincappos and others and refined in this paper by @trishankatdatadog and others. It has only been used widely in TUF and related projects, so I think a mention of TUF is necessary to understand the technique and know where to look for more information.
More fundamentally, when talking about key revocation the specific implementation is important, because like other security systems, it is only as secure as its weakest link. That's the benefit of using existing, well tested security mechanisms instead of attempting to build them from the ground up.

The description has references to TUFs implementation, so I think you're asking for this to move to a discussion for how TUF solves these problems, as opposed to the general background, not referencing specific implementations.

Steve, I'm hard-pressed to see how you could discuss a comprehensive background without discussing specific implementations. That's like citing papers without naming its authors.

Can you create a discussion titled something like "Describing Key Revocation with TUF", link this PR and close this one?

Is there a good reason to close this PR and open a discussion instead, other than citing specific implementations?

For the last option, while TUF may be the only solution we know of that takes this approach, we've done such a good job keeping the other sections abstract and not listing the various implementations of each technique that naming TUF in the last section comes across as a sales pitch.
Here's my own attempt to reword this:
Combining explicit and implicit revocation
By using a hierarchical combination of keys, a trusted root key can delegate signing to various keys that expire. Additionally, artifacts may be signed by more than one key, allowing automated tooling to provide short lived signatures that verify the signer and artifact have not been revoked. Clients then verify the necessary collection of signatures is found on the artifact.
This method allows signers to have relatively long lived keys, to simplify their workflow and avoid needing to resign the artifacts themselves, while enabling timely revoking of the signer key or a single artifact signature.
For efficiency, a meta-artifact can be created and maintained, containing references to a collection currently signed artifacts. And the short lived signature can be created for this single artifact, rather than every artifact individually.
Pros:

Keys may be quickly revoked
Individual artifact signatures may be quickly revoked
Signers do not need to frequently resign all artifacts
Verifiers only need to trust the root key, all delegated keys can be verified against this

Cons:

Requires maintenance of an automated system to refresh short lived signatures
A root key compromise requires updating all signers, clients, and signatures on the artifacts
Signatures in disconnected environments and on artifact copies may quickly become stale
Updating short lived signatures on a large number of artifacts may encounter scaling challenges and loses some of the caching efficiencies of content addressable storage in registries

Thanks @sudo-bmitch. I updated the pr.

Thanks for the review @gokarnm! I updated the document and responded inline to a couple of comments.

@sudo-bmitch @gokarnm I updated the intro as discussed in the meeting. Can I get a review/approval to merge?

Just noticed the DCO validation error. Not sure if that will block the ability to merge.
Still LGTM and hope we can merge and iterate forward. Thanks for driving this @mnm678 !

@mnm678 LGTM!

@mnm678, can you also solve the DCO issue?

This looks great to me, we can definitely keep iterating after merge.

+1 on merge


[FLINK-13499][maprfs] Remove dependency on MapR artifact repository

What is the purpose of the change
This change removes the MapR FS connector to work based on reflection and avoid a hard dependency on any of the MapR vendor-specific artifacts. That allows us to get rid of the dependency without regressing on the support for the file system.
The MapR artifact repository causes some problems. Access to the a secure (https://) endpoint is very flaky.
Verifying this change
Verified by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): No
The public API, i.e., is any changed class annotated with @Public(Evolving): No
The serializers: No
The runtime per-record code paths (performance sensitive): No
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: No
The S3 file system connector: No

Documentation

Does this pull request introduce a new feature? No
If yes, how is the feature documented? No

Thanks. Will change this and merge...

Looks good to merge, yes! The build failure is in the python profile

@StephanEwen Did you forget to close this PR?


[Bug] New-TestResources.ps1 Scripts fails when $BaseName > 24 characters

While working with Azure Loadtestservice SDK, script New-TestResource.ps1 was failing as $BaseName for me was, "niveditjainloadtestservice" which is greater than 24 characters. It was showing this behaviour because Azure KeyVault Resource should have a name between 3 and 24 Characters as mentioned here.
Screenshot of the error:

Fixed by https://github.com/Azure/azure-sdk-tools/pull/5242


[WIP] Disable fedora tests

It looks like the fedora registry might be giving us network flakes so
we are disabling them to see if test run rates improve.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

bot, retest this please

bot, retest this please

How long are you looking to disable these?

@baude I think we can close this, it doesn't seem to be a recurring problem


Add new API SpanBuilder#setRegisterNameForSampledSpanStore().

This PR addresses item#1 in this comment.
I will work on another PR later to resolve the renaming issue.

Coverage increased (+0.008%) to 81.323% when pulling efeef37269fd3199b3a58ee1f4358dacbdadbe08 on HailongWen:add-spanbuilder-setregistername into 6e1ab48620aef90ba897fb5a7e93185a4a015103 on census-instrumentation:master.

Sorry for the miss understanding of the issue 👎, totally my bad. This was done in https://github.com/census-instrumentation/opencensus-java/pull/703
We just need the rename, sorry again.

No problem. I will close this PR.


UDP payload support

Add a udp.data field to capture object so that one can analyze custom udp protocols. Follows same pattern as tcp (slice, not copy).

Thanks.


No way to make requests redirect POST/PUT/DELETE requests

In the documentation (see http://docs.python-requests.org/en/latest/api/#requests.request) it says that specifying allow_redirects to True means that redirecting POST/PUT/DELETE is allowed.
Quick attempts show that the reality is that those requests ALWAYS get redirected as GETs, even when this parameter is True (which it is by default). It seems like the tests here support this claim.
The one commented out test here supports the statement from the documentation, but is commented out (the reason seems to be a bug in httpbin, but no further explanation is supplied)

Requests will change the verb used for a redirect in the following cases:

On a 303 See Other response, HEAD and GET are left alone: all other verbs get changed to GET, as per RFC 7231 Section 6.4.4.
On a 302 Found response, HEAD and GET are left alone: all other verbs get changed to GET. This is allowed by the note in RFC 7231 Section 6.4.3, and is extremely common behaviour with all browsers.
On a 301 Moved Permanently response, POST is changed to GET. All other verbs are left alone. Again, this is allowed by the note in RFC 7231 Section 6.4.2 and is extremely common behaviour with browsers.

While requests allows redirects, it uses the semantic meaning in the status code to potentially adjust the redirect verb. If a server explicitly wants the redirected user agent to keep the verb the same in all circumstances, servers should use 307 Temporary Redirect and 308 Permanent Redirect.

:+1: thanks. You learn something new every day...

@lukasa we should add your snippet of text there to the docs. Doubt it'll reduce incoming issues (questions) around this, but it'd be great for the docs.


Update ns-minwinbase-debug_event.md

CREATE_THREAD_DEBUG_EVENT  is not called when main thread is created. It is bunched together with CREATE_PROCESS_DEBUG_EVENT. Added a remark to indicate that.

@RedSkittleFox : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Karl-Bridge-Microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Default behavior for Maps LoadFromURL

Currently, the Map.LoadFromURL method takes a string containing a GeoJSON URL as input but fails silently if the GotFeatures event is not defined to process the features from the file. This isn't necessarily intuitive behavior.
Default behavior should be to loop through features defined in the file and create those features using the FeatureFromDescription method.
Default behavior can be overridden by defining the GotFeatures event.

Closed via #1538


Revert "Changes for auto incrementing version number"

Reverts wayfair/brickkit-android#57

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     90.12%   90.12%
  Complexity      383      383
=========================================
  Files            23       23
  Lines          1073     1073
  Branches        185      185
=========================================
  Hits            967      967
  Misses           44       44
  Partials         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3124458...450f521. Read the comment docs.


ScanStructs with left join query

Problem
If I scan results of left join query where there are no joined rows, ScanStructs fails with errors like: converting NULL to string is unsupported.
To Reproduce
type FromTable struct {
	ID uint64 `db:"id"`
}

type TableToLeftJoin struct {
	ID uint64 `db:"id"`
}

type Result struct {
	FromTable `db:"from_table"`
	*TableToLeftJoin `db:"table_to_left_join"`
}

var rs []Result
ds := db.From("from_table").LeftJoin(goqu.T("table_to_left_join"), goqu.On(goqu.V(false)))
err = ds.ScanStructs(&rs)

err is not nil.
Expected behavior
rs[0].FromTable should have some filled fields.
rs[0].TableToLeftJoin should be nil.
err should be nil
Dialect:

[x] postgres
[ ] mysql
[ ] sqlite3

Tested only with postgres, but should affect other dialects too.
Maybe there is a way of achieving the same result but some other way?

"converting NULL to string is unsupported" is a common error when trying to Scan null results into a struct and is not specific to just the LeftJoin. This has been brought up with Go ORMs in the past, and has normally been rejected in favor of using a pointer or using sql.Null{Type} (NullString, NullInt, etc.), see sql package docs. If you convert your types over, it will not error out anymore. This also helps everyone distinguish the result from just being empty and actually being null.
Please see these other relevant issues:
gorm: https://github.com/go-gorm/gorm/issues/3387
go-sql-driver: https://github.com/go-sql-driver/mysql/issues/34#issuecomment-14249039
Furthermore, please note that the author of the library mentions "While goqu may support the scanning of rows into structs it is not intended to be used as an ORM if you are looking for common ORM features like associations, or hooks"
In my opinion its a non-issue, but I'll let @doug-martin review.


Investigate methods to reduce cf-d deployment time

Per @jontours -- this should be lower priority as the deployment is stable even though it takes a long time to complete.

This story needs to be further fleshed out to be considered for an upcoming sprint.

It takes 2-4 hours to deploy cf, and there are non-breaking changes we can make to our deployment strategy that will decrease deployment times. Lower priority.

@mxplusb will add his research findings here.

Okay, so it turns out there is a way to set a per-instance group update block which sets the pace for updates within that instance group.
I'd like to update cf-d in production using an update block specific to the diego cells which does a create-swap-delete on 33% of the diego cells. That's the slowest part of deployments and decreasing that instance group deployment time should bring down cf deployments to a much more reasonable time. We felt this most painfully on the k8s recursor issue, where apps had to get the updated DNS config value, so we had to go into every single stemcell and update it ahead of time while we waiting on cf to deploy. Being able to push changes out faster to diego will help prevent stuff like that in the future.

Tackle as part of pipeline refactoring.


Nvim crash on startup with git config --global core.autocrlf input on W10

Describe the bug
Nvim crash on startup with git config --global core.autocrlf input on W10. See https://github.com/lewis6991/gitsigns.nvim/pull/64#issuecomment-786811813. Finally, I got an error message after several attempts to start nvim without crashing.
Observed output

Additional context
It's caused by https://github.com/lewis6991/gitsigns.nvim/blob/cfc8728782b1bcb45410b3616dbf0820e60f292b/teal/gitsigns/git.tl#L221
I think the reason is the same as https://github.com/lewis6991/gitsigns.nvim/blob/926eb0602a5245839fe1feae754c76603b9a49ea/teal/gitsigns.tl#L469-L470
So, as the crash is initially caused by staged which uses \r\n instead of \n, I searched to fix that and I found this. I tested with(open(file, 'wb'), function(writer: FILE) in https://github.com/lewis6991/gitsigns.nvim/blob/cfc8728782b1bcb45410b3616dbf0820e60f292b/teal/gitsigns.tl#L68
And it works, staged uses \n now. So, wb fix the root of the previously broken diff and --ignore-space-at-eol seems no longer useful.
But there is still the problem of print in on_stderr which causes nvim to crash. With wb, git config --global core.autocrlf input no longer returns an error, so nvim don't crash, but I don't think it's enough, an error may be caused by some other problem and if there is an error, there is a crash.
diff --git a/teal/gitsigns.tl b/teal/gitsigns.tl
index 17b258b..36ec4b4 100644
--- a/teal/gitsigns.tl
+++ b/teal/gitsigns.tl
@@ -65,7 +65,8 @@ local function dirname(file: string): string
 end

 local function write_to_file(file: string, content: {string})
-  with(open(file, 'w'), function(writer: FILE)
+  -- On windows 'w' mode use \r\n instead of \n, see: https://stackoverflow.com/a/43967013
+  with(open(file, 'wb'), function(writer: FILE)
     for _, l in ipairs(content) do
       writer:write(l..'\n')
     end
diff --git a/teal/gitsigns/git.tl b/teal/gitsigns/git.tl
index e3d3514..82eb1c4 100644
--- a/teal/gitsigns/git.tl
+++ b/teal/gitsigns/git.tl
@@ -203,7 +203,6 @@ function M.run_diff(staged: string, text: {string}, diff_algo: string): cb_funct
         '--diff-algorithm='..diff_algo,
         '--patch-with-raw',
         '--unified=0',
-        '--ignore-space-at-eol', -- On windows 'staged' has \r\n instead of \n
         staged,
         '-'
       },

However, I don't know how to fix the print issue.
Thank you.

You could try wrapping the print with vim.schedule:
vim.schedule(function()
  print(...)
end)

Yes, this fixes the crash and displays the message correctly.
Here is the final diff:
diff --git a/teal/gitsigns.tl b/teal/gitsigns.tl
index 17b258b..36ec4b4 100644
--- a/teal/gitsigns.tl
+++ b/teal/gitsigns.tl
@@ -65,7 +65,8 @@ local function dirname(file: string): string
 end

 local function write_to_file(file: string, content: {string})
-  with(open(file, 'w'), function(writer: FILE)
+  -- On windows 'w' mode use \r\n instead of \n, see: https://stackoverflow.com/a/43967013
+  with(open(file, 'wb'), function(writer: FILE)
     for _, l in ipairs(content) do
       writer:write(l..'\n')
     end
diff --git a/teal/gitsigns/git.tl b/teal/gitsigns/git.tl
index e3d3514..438212b 100644
--- a/teal/gitsigns/git.tl
+++ b/teal/gitsigns/git.tl
@@ -203,7 +203,6 @@ function M.run_diff(staged: string, text: {string}, diff_algo: string): cb_funct
         '--diff-algorithm='..diff_algo,
         '--patch-with-raw',
         '--unified=0',
-        '--ignore-space-at-eol', -- On windows 'staged' has \r\n instead of \n
         staged,
         '-'
       },
@@ -218,7 +217,9 @@ function M.run_diff(staged: string, text: {string}, diff_algo: string): cb_funct
         end
       end,
       on_stderr = function(_, line: string)
-        print('error: '..line, 'NA', 'run_diff')
+           vim.schedule(function()
+              print('error: ' .. line, 'NA', 'run_diff')
+           end)
       end,
       on_exit = function()
         callback(results)

Do you want me to apply this again or do you want another stab at the PR yourself? I don't mind, I just feel a bit guilty committing and taking credit for other peoples work as the change goes under my name 😝.

I can try, git config --global core.autocrlf input is supposed to convert my hideous \r\n xD. As long as the problem is fixed, I'm happy :p

Fixed https://github.com/lewis6991/gitsigns.nvim/pull/70.


First panel is only display

With Bolt 3.1.x, when I click on "More statistics" admin widget button, nothing happens.
On developer console, there are errors related to makeCanvas(id) function.
It seems that the divs #chart-1-container, #chart-2-container… aren't created on dom.

Actually, the divs #chart-1-container… are only added on extension page. And the bug didn't come from there, but from the button which is a div rather than a link node.


CDN SKU requirements

Is there a specific sku requirement for this to work? When trying to associated a WAF with a CDN endpoint no valid profiles can be found

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dad8de5b-1473-a1d6-b00d-f5ab580f53c9
Version Independent ID: adf7dd84-539f-7aa7-e739-3221526b9820
Content: Tutorial: Create WAF policy for Azure CDN - Azure portal
Content Source: articles/web-application-firewall/cdn/waf-cdn-create-portal.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@mauleb
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@mauleb
Yes. The article has been updated to state: Azure CDN Standard from Microsoft
#please-close


some error about:"RuntimeError: cuda runtime error (100) : "

hello,when i run the " bash train_aggcn.sh",there are some errors.
but,i test my torch:
Default GPU Device: /device:GPU:0
Your tensorflow-gpu is available
Default GPU Device: Tesla P4
Your pytorch-gpu is available
and,my environment is
cuda:10.1
python:3.7.5
pytorch:1.3.
could you please help me to solve this error?
thank you very much!
Finetune all embeddings.
Traceback (most recent call last):
File "train.py", line 120, in
trainer = GCNTrainer(opt, emb_matrix=emb_matrix)
File "/home/yaoshengnan/AGGCN-master/semeval/model/trainer.py", line 68, in init
self.model = GCNClassifier(opt, emb_matrix=emb_matrix)
File "/home/yaoshengnan/AGGCN-master/semeval/model/aggcn.py", line 26, in init
self.gcn_model = GCNRelationModel(opt, emb_matrix=emb_matrix)
File "/home/yaoshengnan/AGGCN-master/semeval/model/aggcn.py", line 51, in init
self.gcn = AGGCN(opt, embeddings)
File "/home/yaoshengnan/AGGCN-master/semeval/model/aggcn.py", line 133, in init
self.layers.append(GraphConvLayer(opt, self.mem_dim, self.sublayer_first))
File "/home/yaoshengnan/AGGCN-master/semeval/model/aggcn.py", line 206, in init
self.weight_list = self.weight_list.cuda()
File "/root/anaconda3/envs/tf14/lib/python3.7/site-packages/torch/nn/modules/module.py", line 305, in cuda
return self._apply(lambda t: t.cuda(device))
File "/root/anaconda3/envs/tf14/lib/python3.7/site-packages/torch/nn/modules/module.py", line 202, in _apply
module._apply(fn)
File "/root/anaconda3/envs/tf14/lib/python3.7/site-packages/torch/nn/modules/module.py", line 224, in _apply
param_applied = fn(param)
File "/root/anaconda3/envs/tf14/lib/python3.7/site-packages/torch/nn/modules/module.py", line 305, in
return self._apply(lambda t: t.cuda(device))
File "/root/anaconda3/envs/tf14/lib/python3.7/site-packages/torch/cuda/init.py", line 193, in _lazy_init
torch._C._cuda_init()
RuntimeError: cuda runtime error (100) : no CUDA-capable device is detected at /pytorch/aten/src/THC/THCGeneral.cpp:50

pytorch=1.3.1

thank you ,it has been solved

Hello, I have the same problem as you. Could you tell me how to solve it

thank you ,it has been solved

Can you mention what was the problem?


[Feature]: BitsandBytes quantization with TP>1

🚀 The feature, motivation and pitch
Any QLoRA adapters trained on large checkpoints (e.g., 70B) are unusable as we cannot use TP>1 to shard the model over multiple GPUs. Therefore, resolving this would enable models that were trained with quantization, rather than having to rely on GPTQ and AWQ, which are applied post-hoc after training.
Alternatives
No response
Additional context
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

feature added in v0.6.2 https://github.com/vllm-project/vllm/pull/8434.


Loss of ROV information from Dxvk to SPIRV

shader is as follow, when compile to SPIRV, the ROV info is loss.
RasterizerOrderedStructuredBuffer rovBuffer   : register(u1);
struct PSIn
{
float4 pos : SV_Position;
float4 clr : COLOR;
};
struct PSOut
{
float4 c0 : color;
};
PSOut main(PSIn input)
{
PSOut output;
uint x = floor(input.pos.x);
uint y = floor(input.pos.y);
uint addr = x * 64 + y;
for(int i = 0; i < 1; ++i)
{
    uint value = rovBuffer[addr];
    rovBuffer[addr] = value + 1;
}

output.c0.r=1.0f;
output.c0.g=1.0f;
output.c0.b=0.5f;
output.c0.a=1.0f;
return output;

}

I'm not really sure what you mean with "is lost". Assuming you're using DXVK 2.0 or newer, we emit shader interlock instructions around the entire entry point (which isn't optimal, but is a valid way to implement this feature).


Error calling npm to fetch template. Please ensure that node and npm are installed and available on your system. Full error message: Command failed with exit code 1: npm root -g --prefix C:\Users\T\AppData\Roaming\BotFrameworkComposer.yo-repository --loglevel error 'npm'

Describe the bug

Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

@Targonnnn
Which version of Composer you are trying to run?
What OS and version are you trying to install on?
Have you verified that you have Node.js installed on the target machine?

Closing due to inactivity. Please feel free to reopen if the issue persists or you have new details to share.


Questions about newly opened files

When you open a new file, it will either open a new window or overwrite the current window. This problem really affects usage.
From windows 10.

Maybe #128385


Google Search Console recommended fixes for SEO and performance

Purpose of this pull request
This pull request:

Reduces image size to accelerate load time. Google Search Console reported these two docs as having longer than 200ms load times.
404 fixes
Duplicate/Google chose different canonical than us
Exclude pages that aren't indexed or served on Google

Select the type of change

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions, updating sections
[ ] New Content - New features, sections, pages, tutorials
[x] Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@jpipkin1 thank you!


Fails to create AccessLoggingBucket in us-east-2

Describe the bug
Deploying the CF Stack in us-east-2 results in the following error from resources AccessLoggingBucket
Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting

To Reproduce
Deploy CF template v3.2.4 in us-east-2: https://s3.amazonaws.com/solutions-reference/aws-waf-security-automations/v3.2.4/aws-waf-security-automations.template
All parameters are the default value besides these three:
ActivateAWSManagedRulesParam = yes
EndpointType = ALB
AppAccessLogBucket = (I created a bucet with default security settings, so ACL disabled)

Expected behavior
Deploys successfully; S3 bucket is created.
Please complete the following information about the solution:

[x] Version: v3.2.4
[x] Region: us-east-2
[x] Was the solution modified from the version published on this repository?: no
[x] ~If the answer to the previous question was yes, are the changes available on GitHub?~
[x] Have you checked your service quotas for the services this solution uses?: yes, not hitting limits
[x] Were there any errors in the CloudWatch Logs?: Same error found in the stack. No other errors.

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).
Additional context
In the same AWS account I was able to deploy v3.2.4 in the following regions SUCCESSFULLY:

us-east-1
us-west-1
us-west-2

Other info:

I had my AWS organization admins check for any SCP's that may affect this but they found nothing. Maybe they missed something though? Is there something they can double check?
I'm able to create an S3 bucket in us-east-2 that has ACL's enabled manually through the web console
I do have a ticket open with AWS but they've yet to figure anything out
This change in the default S3 settings may be affecting this, waiting for AWS support to answer that: https://aws.amazon.com/about-aws/whats-new/2023/04/amazon-s3-two-security-best-practices-buckets-default/

Hi @taylorsilva, this issue should be fixed in the release/v3.2.5 (released yesterday)

@WillAWS any idea when the template will be up at https://s3.amazonaws.com/solutions-reference/aws-waf-security-automations/<version>/aws-waf-security-automations.template?
Thanks again for the fast reply!

The documentation is a bit behind, should release the updated docs soon. We released with an updated name here: https://solutions-reference.s3.amazonaws.com/security-automations-for-aws-waf/v3.2.5/aws-waf-security-automations.template


Put uv_async_init on main thread

Relevant gist

NOTE: Windows is good but Linux/OSX are both false positives. The tests die but report a success.

Closing this test PR out.


Idear for new initial transfer filter

Short Description:
It would be nice to have a filter for the initial transfer function. Up to now one can only go down to 1 pokemon that is kept. It would be nice to be able to change this value to 2 which will keep 2.
Furthermore it would be nice to be able to use the feature on specific pokemon. For example one wants to keep his Weedles with 10-300 CP but also wants to release his Pigeys with 300-500 CP

are you on master branch? this should be possible on dev through the release config

This feature has alreaady been implemented in the latest dev branch.
/closed


Fix tests and code broken by bootstrap4

Lots of fixes here. Approximately one file changed per commit to make review simpler and keep the history tidy (if verbose).

@mahmoodkhan Still lots of changes, but no files from outside the test tree.


Fixed 'selected' property for option in select

Fixed unselecting of options

Sorry, but this does not affect anything and definitely not the problem you have mentioned in #14, hence I am closing this.

This fix affects native browser getting value of select.


Can't install via pip: multiprocessing is already present in Python 3

$ pip install pygmmis
Collecting pygmmis
  Using cached pygmmis-1.1.3-py2.py3-none-any.whl (22 kB)
Requirement already satisfied: numpy in /home/gabriel/miniconda3/envs/py3/lib/python3.7/site-packages (from pygmmis) (1.18.1)
Collecting parmap
  Using cached parmap-1.5.2-py2.py3-none-any.whl (15 kB)
Requirement already satisfied: scipy in /home/gabriel/miniconda3/envs/py3/lib/python3.7/site-packages (from pygmmis) (1.4.1)
Collecting multiprocessing
  Using cached multiprocessing-<IP_ADDRESS>.tar.gz (108 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/gabriel/miniconda3/envs/py3/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-redkuhhn/multiprocessing/setup.py'"'"'; __file__='"'"'/tmp/pip-install-redkuhhn/multiprocessing/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-redkuhhn/multiprocessing/pip-egg-info
         cwd: /tmp/pip-install-redkuhhn/multiprocessing/
    Complete output (6 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-redkuhhn/multiprocessing/setup.py", line 94
        print 'Macros:'
                      ^
    SyntaxError: Missing parentheses in call to 'print'. Did you mean print('Macros:')?
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

According to this SO post, multiprocessing is already included in Python 3.

Thanks for the link. It shows that the package is quite old.., but the fix is simple.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: NelsonRetnam sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


config: Rename Configuration trait to OnlineConfig

What problem does this PR solve?
The name of Configuration trait and its deriving macro is very mysterious.
What is changed and how it works?
Rename it to OnlineConfig
Check List
Tests

Unit test
Integration test

Release note
None

/run-all-tests

@NingLin-P PTAL

/merge

@ti-chi-bot


Update Error

Checking....
Downloading 1/14
...
Downloading 14/14
Update check failed!
One or more files couldn't be downloaded.
Check your internet connectvity or try again later.
i have a stable internet connection

Are there any other messages during the update check? The update process itself seems to be working fine for me; I just updated a copy of the program from 1.4.89 to 1.4.90 without issue.

Checking for update...
Downloading update...
Downloading Classes/ConfigTab.lua... (1 of 14)
Downloading Data/2_6/ModCache.lua... (2 of 14)
Hash mismatch on 'Data/2_6/ModCache.lua'
Downloading Data/New.lua... (3 of 14)
Downloading Modules/ConfigOptions.lua... (4 of 14)
Downloading Modules/Build.lua... (5 of 14)
Downloading Classes/TreeTab.lua... (6 of 14)
Downloading Data/Uniques/amulet.lua... (7 of 14)
Downloading Data/3_0/ModCache.lua... (8 of 14)
--- ERROR ---
Critical error at address 67B0C0EBh in thread 4540:
Access violation: attempted to read from address FFFFFFFFh

where to download the latest version?
because i cant update 1.4.89


LowerBound and UpperBound Test run issue

First of all, I would like to thank you all and appreciate the work that has been put into this project.
So, Regarding the issue, When trying to do the test for BEV Segmentation task using either the lower bound or the upper bound approach, Getting an issue with invalid key error for ['trans matrices']

Would greatly be helpful, if someone can assist me in knowing what the issue is actually.
Thanking you in advance

Hi @rajuptvs, thanks for pointing this out! This bug was introduced when I was refactoring the API earlier. I'll fix this in the following commit.

Hey thanks, for the quick response. Just wanted to check regarding the dataset, Dataset has the images, but I don't see the images being utilized for any of the training models. Is that correct?
Thanking you in advance

Hey thanks, for the quick response. Just wanted to check regarding the dataset, Dataset has the images, but I don't see the images being utilized for any of the training models. Is that correct?
Thanking you in advance

@rajuptvs Hi, are you referring to the images captured by the RGB cameras? If so, then yes, currently we are not using any of these images.


Freemind import

Outside the scope the of the project.

Outside the scope the of the project.

Just came across this and there is a workaround whereby this can be accomplished, for the technically more savvy:
How to import from freeplane (freemind fork) to draw.io
Pre-requisite: Download and start freeplane, open the freemind map in freeplane.
Basically, add and use the CSV export script in freeplane, and then use the CSV text import tool in draw.io.
So:

Use one of the sample csv export scripts for freeplane. Here: http://www.freeplane.org/wiki/index.php/Scripts_collection#Output_A_Map_to_CSV
Use the CSV import tool in draw.io. Its a bit technical.

Both steps are a bit technical. Using scripts in freeplane is actually quite easy once you get going.
The csv import in draw.io is a bit involved. :)

Hi

The csv import in draw.io is a bit involved. :)

Thanks for your support
I can't figure how to import csv in draw.io.
It only create a big object not a graph
Could you explain a little more?
Thanks

Ok
Tried it.
The first passage is really easy. You can use a simple script and create a CSV file.
Import CSV into draw.io it's not so easy
More, it's just for table data NOT for mind map
It as to define every relation from columns but in a mind map you don't have columns just connections
It's not a practical solution
Thanks
And also mermaid it's not a solution 'cause draw.io create a single block not editable
And also svg it's not a solution 'cause draw.io import it as an image and not a editable object.

Hi @lordmax ,

The first passage is really easy. You can use a simple script and create a CSV file.

If you succeeded with this, you should be able to get the second part right... :)

Import CSV into draw.io it's not so easy
More, it's just for table data NOT for mind map
It as to define every relation from columns but in a mind map you don't have columns just connections

This sounds not quite right, I suspect you might be using a different solution - as the example in the drawio create an organizational chart, where the connections are indeed an important part.
Check this page for info on how the relations are captured in the drawio import.
https://drawio-app.com/import-from-csv-to-drawio/
Looks like it should be doable, after all?
BR! /m

Hi @chipbite
Thanks
It's exactly as you say.
Connections are fundamental in CSV import for draw.io
But they have to be explicit in the setup pop-up.
You can't get a CSV and import it, you have to write down all relations and in both directions, if needed.
This is a huge waste of time.
And more, in a mind map you can't define this kind of relations, they're just connections. If I have to explicate every connection and maybe in a bidirectional way, the time I need to do so it's unacceptable.
CSV import can't be the right solution

You can't get a CSV and import it, you have to write down all relations and in both directions, if needed.

if the export does not have the relations (which it should) then I guess you would have to do it manually.
But of course, when you are getting the relations from freemind/freeplane, you need to process/transform the csv from freemind to make it into the csv that the csv import in diagrams.net expects. Might need a bit of code to do that.

And more, in a mind map you can't define this kind of relations, they're just connections.

well, relations / connections - aren't they the same thing in this context? A -> B. Like graphs in graphviz or plantuml.
Anyway, sorry it did not work out for you. Take care!

Hi
Not so easy
In the CSV you must have a column with the relation
AND
In the pop up for the CSV import, you have to explicitate every relations

connect: {"from": "manager", "to": "name", "invert": true, "label": "manages", \
"style": "curved=1;endArrow=blockThin;endFill=1;fontSize=11;"}
connect: {"from": "refs", "to": "id", "style": "curved=1;fontSize=11;"}

It's not sufficient they are in the CSV
So you can understand that also in case of a standard excel table you need a big amount of time to write down all relations
It's not only a matter of create CSV in the right manner.
In a mind map it's more complicated 'cause it's not an excel table with clear relations
Anyway, thanks for the support, really


Android Basics: Fragments Navigation component

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-fragments-navigation-component?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-2%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-fragments-navigation-component#4
In which task and step of the codelab can this issue be found?
Fragments and navigation Component....Step 5
Describe the problem
The started code has a error already.        This is the second started code I found with errors.
There is no way to even import it!     How can I get through this course!
Screen shots included.   I sent another email with different errors also yesterday....waiting on a reply on that one.

Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

This is addressed in step 6 of the page in the screenshot you attached:

Then set the value of the recyclerView property in onViewCreated(), and call chooseLayout() like you did in MainActivity. You'll move the chooseLayout() method into LetterListFragment soon, so don't worry that there's an error.

Thx so much!
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: guru-meditation-no42 @.>
Sent: Sunday, February 27, 2022 2:08:55 PM
To: google-developer-training/android-basics-kotlin-words-app @.>
Cc: Jennifer Hodge @.>; Author @.>
Subject: Re: [google-developer-training/android-basics-kotlin-words-app] Android Basics: Fragments Navigation component (Issue #246)
CAUTION: External Sender
This is addressed in step 6 of the page in the screenshot you attached:

Then set the value of the recyclerView property in onViewCreated(), and call chooseLayout() like you did in MainActivity. You'll move the chooseLayout() method into LetterListFragment soon, so don't worry that there's an error.

—
Reply to this email directly, view it on GitHubhttps://github.com/google-developer-training/android-basics-kotlin-words-app/issues/246#issuecomment-1053664494, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVXNC3H6KEFEZQSSCYSJNRTU5KAFPANCNFSM5NWBOKSA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
CONFIDENTIALITY NOTICE: This electronic mail transmission and any attachments are confidential and may be privileged. They should be read or retained only by the intended recipient. If you have received this transmission in error, please notify the sender immediately and delete the transmission from your system.

I sent in an issue on the Lunchbox app on the issues list.
It is the 1st one, so you should see it.
thanks,
Jennifer
Jennifer Hodge
Internet Sales
414-586-5425
Russ Darrow Honda
[cid:50365b39-7950-48e2-af3c-872569107ad6]https://your.tradeinvalet.com/tdhe0j

From: guru-meditation-no42 @.>
Sent: Sunday, February 27, 2022 2:08 PM
To: google-developer-training/android-basics-kotlin-words-app @.>
Cc: Jennifer Hodge @.>; Author @.>
Subject: Re: [google-developer-training/android-basics-kotlin-words-app] Android Basics: Fragments Navigation component (Issue #246)
CAUTION: External Sender
This is addressed in step 6 of the page in the screenshot you attached:

Then set the value of the recyclerView property in onViewCreated(), and call chooseLayout() like you did in MainActivity. You'll move the chooseLayout() method into LetterListFragment soon, so don't worry that there's an error.

—
Reply to this email directly, view it on GitHubhttps://github.com/google-developer-training/android-basics-kotlin-words-app/issues/246#issuecomment-1053664494, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVXNC3H6KEFEZQSSCYSJNRTU5KAFPANCNFSM5NWBOKSA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
CONFIDENTIALITY NOTICE: This electronic mail transmission and any attachments are confidential and may be privileged. They should be read or retained only by the intended recipient. If you have received this transmission in error, please notify the sender immediately and delete the transmission from your system.


#9 active list

Based on this comment we need to refactor Active list and Active item: move all behavior  into activeContainer and activeUnit directives, while leaving markup decoration to activeList and activeItem.

Although there is some functionality to add, let's release activeList in its current stable state and enhance in the next release.


Fix arm test

🦟 Bug fix
I believe this fixes the arm tests.
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

testing with a nightly build from this branch using arm64 arch:

 https://build.osrfoundation.org/view/ign-garden/job/gz-math7-debbuilder/925/