No space between Nerd font icon and label

The issue
There is no space between the Nered font icon and the text.

Expected behavior:
My config worked well till now. I've defined a label containing an icon + a space + a stat (e.g. cpu usage), cf the above picture or here. Normally, there should be a space between them.
Actual behavior:
It seems there is a negative space. If I add some spaces in the label description, it looks good, but that's strange.
Was it working before?
It worked perfectly in a previous 16.04 and 18.04 LTS computer. I installed it on my new 20.04 LTS and the bug appeared, but around three weeks after...
To Reproduce
My config is  here.
I'm using polybar 3.4.0-120-g3895ace.
Polybar Log
The log at trace level ...
notice: Parsing config file: /home/etienne/.config/polybar/config
- config_parser: Parsing /home/etienne/.config/polybar/config
- config: Copying missing params (sub="bar/bottom", base="bar/default")
- config: Copying missing params (sub="bar/homelaptop", base="bar/bottom")
- config: Copying missing params (sub="bar/left", base="bar/default")
- config: Copying missing params (sub="bar/mainlaptop", base="bar/bottom")
- config: Copying missing params (sub="bar/right", base="bar/default")
- config: Copying missing params (sub="bar/smalllaptop", base="bar/bottom")
- config: Copying missing params (sub="module/backlight-acpi", base="module/xbacklight")
* Loaded monitor HDMI-1 (1920x1080+0+0)
* Bar geometry: 1920x30+0+1050; Borders: 0,0,0,0
- bar: Attach X event sink
- bar: Attach signal receiver
- controller: Install signal handler
- controller: Setup user-defined modules
- module/network: Deconstructing
error: Disabling module "network" (reason: Invalid network interface "enp0s25")
- pulseaudio: started mainloop
notice: pulseaudio: using default sink alsa_output.pci-0000_28_00.4.analog-stereo
- module/battery: Deconstructing
error: Disabling module "battery" (reason: No suitable way to get current charge state)
- module/powermenu: Creating menu level 0
- module/powermenu: Creating menu level item 0
- module/powermenu: Creating menu level item 1
- module/powermenu: Creating menu level item 2
* Starting application
- controller: Main thread id = 1
* Starting module/i3
* Starting module/date
- module/i3: Thread id = 2
* Starting module/cpu
* Starting module/memory
- module/cpu: Thread id = 3
* Starting module/temperature
- module/memory: Thread id = 4
* Starting module/pulseaudio
- module/temperature: Thread id = 5
* Starting module/powermenu
- module/powermenu: Thread id = 6
* Entering event loop (thread-id=1)
- module/pulseaudio: Thread id = 8
* Eventqueue worker (thread-id=7)
- bar: Create renderer
- renderer: Get TrueColor visual
- renderer: Allocate colormap
- renderer: Allocate output window
- renderer: Allocate window pixmaps
- renderer: Allocate graphic contexts
- renderer: Allocate alignment blocks
- renderer: Allocate cairo components
- renderer: Load fonts
* Configured DPI = 96x96
* module/date: Invoking shell command: "/home/etienne/.config/polybar/scripts/date/date.sh"
- command: Waiting for pid 12322 to finish...
- command: Exited with status 0
notice: Loaded font "System San Francisco Display:size=10" (name=DejaVu Sans, offset=2, file=/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf)
notice: Loaded font "Hack Nerd Font:style=Regular:size=11" (name=Hack Nerd Font, offset=2, file=/home/etienne/.local/share/fonts/NerdFonts/Hack Regular Nerd Font Complete.ttf)
* Bar window: 0x1600002
- bar: Reconfigure window
- bar: Set window WM_NAME
- bar: Set window _NET_WM_WINDOW_TYPE
- bar: Set window _NET_WM_STATE
- bar: Set window _NET_WM_DESKTOP
- bar: Set window _NET_WM_PID
- bar: Map window
- bar: Draw empty bar
- bar: Setup tray manager
- tray: Find systray selection atom for the default screen
* Activating tray manager
- tray: Create tray window
* Tray window: 0x1600006
- tray: Restacking tray window
- bar: Set window WM_NAME / WM_CLASS
- tray: Set window WM_PROTOCOLS
- tray: Set window _NET_WM_WINDOW_TYPE
- tray: Set window _NET_WM_STATE
- tray: Set window _NET_WM_PID
- tray: Set window _NET_SYSTEM_TRAY_VISUAL
- tray: Set window _NET_SYSTEM_TRAY_ORIENTATION
- tray: Set _NET_SYSTEM_TRAY_COLORS to ff222222
warn: Systray selection already managed (window=0x1400006)
- tray: Listen for events on the new selection window
* Deactivating tray manager
- tray: Unembed clients
- tray: Destroy window
* module/i3: Rebuilding cache
* module/date: Rebuilding cache
* module/cpu: Rebuilding cache
* module/memory: Rebuilding cache
* module/temperature: Rebuilding cache
* module/pulseaudio: Rebuilding cache
* module/powermenu: Rebuilding cache
- bar: Force update
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
- bar: Force update
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
- bar: Received expose event
* module/temperature: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
* module/cpu: Rebuilding cache
* module/memory: Rebuilding cache
* module/temperature: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
* module/temperature: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
* module/cpu: Rebuilding cache
* module/memory: Rebuilding cache
* module/temperature: Rebuilding cache
* Redrawing bar window
- renderer: flush(1 geom=56x30+0+0, falloff=0)
- renderer: flush(2 geom=228x30+846+0, falloff=0)
- renderer: flush(3 geom=417x30+1503+0, falloff=0)
notice: Termination signal received, shutting down...
- controller: Uninstall sighandler
- controller: Detach signal receiver
- controller: Stop modules
* module/i3: Disconnecting from socket
* module/i3: Stopping
warn: module/i3: Attempting to reconnect socket (reason: Unexpected EOF while reading header)
* module/i3: Reconnecting socket succeeded
- module/i3: Release sleep lock
* Deconstruction of module/i3 took 0 ms.
- module/date: Release sleep lock
* module/date: Stopping
- module/date: Release sleep lock
* Deconstruction of module/date took 0 ms.
* module/cpu: Stopping
- module/cpu: Release sleep lock
* Deconstruction of module/cpu took 0 ms.
* module/memory: Stopping
- module/memory: Release sleep lock
* Deconstruction of module/memory took 0 ms.
* module/temperature: Stopping
- module/temperature: Release sleep lock
* Deconstruction of module/temperature took 0 ms.
* module/pulseaudio: Stopping
- module/pulseaudio: Release sleep lock
* Deconstruction of module/pulseaudio took 0 ms.
* module/powermenu: Stopping
- module/powermenu: Release sleep lock
* Deconstruction of module/powermenu took 0 ms.
- controller: Joining threads
- module/i3: Deconstructing
- module/date: Deconstructing
- module/cpu: Deconstructing
- module/memory: Deconstructing
- module/temperature: Deconstructing
- module/pulseaudio: Deconstructing
- module/powermenu: Deconstructing
* Waiting for spawned processes to end
* Reached end of application...

Environment:

WM: i3wm
Distro: Ubuntu 20.04
Output of polybar -vvv:

polybar 3.4.0-120-g3895ace

Features: +alsa +curl +i3 +mpd +network(wireless-tools) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm -xcursor

Build type: Release
Compiler: /usr/bin/g++
Compiler flags:  -Wall -Wextra -Wpedantic -O3 -DNDEBUG
Linker flags:

I think this is the same issue as reported in #991. I have added some of my findings to the original post.
TL;DR: Likely Nerd Fonts issue and not polybar.

Ok ! As many, I just moved Nerd font back to v2.0.0. That worked great !


make install also installs the tests

Describe the bug
make DESTDIR="/wherever/" install also copies tests
To Reproduce
./configure --prefix=/usr
make
make DESTDIR="/wherever/" install
this creates the $PWD directory tree and tests, like /home/zoe/Downloads/mptcpdpkg/pkg/mptcpd/home/zoe/Downloads/mptcpdpkg/src/mptcpd-0.4/tests in my case. (here DESTDIR was "/home/zoe/Downloads/mptcpdpkg/pkg/mptcpd/"
Expected behavior
tests should not be installed, and especially not under /prefix/$build_pwd
Desktop:

Linux Kernel: 5.6.14-arch1-1
Compiler: gcc version 10.1.0

Additional context
an arch PKGBUILD:
pkgname=mptcpd
pkgver=0.4
pkgrel=1
pkgdesc="Multipath TCP daemon"
url="https://github.com/intel/mptcpd"
arch=('x86_64')
license=('GPL2' 'BSD')
depends=('ell')
source=("https://github.com/intel/mptcpd/releases/download/v$pkgver/$pkgname-$pkgver.tar.gz")
sha512sums=('1db9fa7182b167d45c44e16dcec051f426039eeeb84dc5b7352819f5b5048e5f5cdc22c567b32054b72bed444869cad36b24c3354e63d671a807010d0b9aab68')

#prepare() {
#       cd "$pkgname-$pkgver"
#    #./bootstrap # only required when building a git clone
#}

build() {
        cd "$pkgname-$pkgver"
    ./configure --prefix=/usr
    make
}

package() {
        cd "$pkgname-$pkgver"
    make DESTDIR="$pkgdir/" install
    echo "$PWD"
}

Nice catch!
This looks like an artifact of my attempt to force test plugins to be built and installed in the mptcpd/tests directory.  In tests/Makefile.am:
## Build a test mptcpd plugin.
##
## "check_LTLIBRARIES" can't be used here since a dynamically loadable
## module will not be built.  A Libtool convenience library would be
## built instead.
##
## Absolute path needed by Libtool during installation.
plugin_adir    = $(abs_builddir)/plugins_a
...
plugin_a_LTLIBRARIES = plugin_three.la plugin_four.la
...

The generated tests/Makefile ends up prepending $(DESTDIR) to the test plugin installation directories, which then causes them to be potentially installed outside of the mptcpd/tests directory when DESTDIR is set.  Ideally, the test plugins would only be built when running make check, but then we run into the problem described in the above Makefile.am snippet.  I'll see what I can do about this problem.  Thanks for the bug report!

thanks. I also had issues when trying to build from a dedicated build directory. simply mkdir build; cd build; configure ..; make will fail
I should open up a new issue for that, I guess

The dedicated build directory problem (VPATH build) was fixed by pull request #73 that was recently merged to the master branch.  Please give it a try if you get a chance.
I'm still reworking the plugin test infrastructure to address the original problem you reported.

mptcpd 0.5 was just released.  It fixes this problem.


Feature: Download Multiple chat all at once

It would be beneficial to have the ability to download multiple chats in bulk and import them into another browser instance. (Note: I use different browser profiles.)

This feature has already been implemented. It is in the import/export tab on the left side menu.


Reminder notification does not appear

I am not getting reminders for subjects.

Also, is it possible to select more specific time for notification for subjects, currently it is limited:

You seem to be using different functions for interval calculations. As each reminder uses different times.
A.

B.

C.

Having one custimizable format will simplify code and give users more flexibility.

Can you share your device details?


Fix dependency issues

[x] Ran into issue described here - https://github.com/zsvoboda/ngods-stocks/issues/22 - resolved by updating dbt version
[x] Ran in issue described here after resolving

https://stackoverflow.com/questions/61305727/head-cannot-open-etc-ssl-certs-java-cacerts-for-reading-no-such-file-or-dir

[ ] DBT no longer working

@oreillyjw thanks for sharing the first steps for resolving the dependency issues.
After applying it, dbt was also not working anymore on my side (dagster stopped with error).
The fix is to rename the /projects/dagster/dbt.py file (e.g. to dbt_ops.py). The dagster_dbt module tries to import from dbt and accesses the ngods file instead of the real dbt files.


Add your comment in the standard rejection options

PR includes

[x] Refactor
[x] Feature

Related issues
Resolve #833

https://github.com/user-attachments/assets/14679f14-ebf3-4dd4-af2f-f0835cd5572c
https://github.com/user-attachments/assets/619a67b7-cdc1-4b46-b1c0-902e62bdb03d

https://github.com/user-attachments/assets/dabd4211-1e85-4135-85bd-52ce896a6c21


Enable specification of which cache location to use

This PR resolves issue #58 and issue #56 .
As stated in issue #58, setting the cacheLocation property on a UserAgentApplication instance does not effect where auth data gets stored, since the storage occurs in the UserAgentApplication constructor. This PR includes cacheLocation as a desctructured UserAgentApplicationuses constructor parameter with a default value. It also includes an optional redirectUri parameter to address issue #56.
It uses the already implemented cacheLocation setter to set the cache location with this argument in the constructor. In addition, all other effectively optional UserAgentApplication parameters have been destructured. This simplifies the usage of UserAgentApplication, by avoiding the requirement of passing null arguments for optional parameters that the client does not wish to specify, and also by enabling the client to define the UserAgentApplication in a single construction. It also avoids the,
    constructor (one: number, two?: number, three?: number) {
        this.one = one
        this.two = two ? two : 2
        this.three = three ? three : 3
    }

pattern used to implement optional parameters with default values, and uses the TS/JS syntax for optional parameters with default values:
    constructor (one: number, { two = 2, three = 3 }: { two?: number, three?: number }) {
        this.one = one
        this.two = two
        this.three = three
    }

@austindyoung,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@austindyoung Why do you have 2 PR's on the same issue. Isnt PR 71 addressing the same issue?

@austindyoung fixed in dev


Fix for issue #2264 Do not reset the search if minimumInputLength is > 1...

..., multiple is true, and closeOnSelect is false

Now that 4.0.0 has been released, the branches have switched and this is pointing to the wrong one. If you are still interested in getting this merged, create a new pull request for the stable/3.5 branch and link back to this old one.
Until then, we have to close this off as it is not possible to merge it in.


[ExternalGenericMetadataBuilder] Add configurable log levels.

Add a call to set the log level of the builder, and have the builder default to no logs except for fatal errors.

@swift-ci please test


[Beginner] Postfix Unary Semantic Actions

I might be missing it in the documentation, but is there an idiomatic way to handle a semantic action on a postfix unary expression, like a keyword that will mark it during lexing to translate it to prefix?
For example below, SemanticBody in the action for @OnNot has what I need to properly evaluate since l_unary is coming from the right hand side of the tree, but for @OnIncrement, primary has not yet been parsed.
rules {
   ...

    // Prefix Unary
    l_unary -> primary^
            |  '!'^ l_unary @OnNot
            |  '-'^ l_unary @OnNegate ;

     primary -> function^
            |  literal^
            // Postfix Unary
            | primary '++'^ @OnIncrement
            | primary '--'^ @OnDecrement
            | '('! expression^ ')'! ;
   ...
}

I may be misunderstanding, when you refer to primary, you mean the one in the rule's body, right?
When the @OnIncrement action is called, it should be given the rule's body as argument with the node for the primary in the primary '++'^ @OnIncrement as first item. At this point the node should be the full AST.
If this is not the case this is a bug. I'll try to check this on my end.

Thanks, that prompted me to take another look and it turns out that I had been using a test case where my literal rule wasn't catching the value right in one of its Semantic Actions and pushing it on the stack.  So, that is why @OnIncrement didn't have what I was expecting.  Basically my own fault.  Sorry about that!


Inconsistency in attribute name in IdentifierKeyValuePair class

  "specificAssetIds": [
     {
        "key": "EquipmentID",
        "value": "538fd1b3-f99f-4a52-9c75-72e9fa921270",
        "subjectId": {
           "keys": [
              {
                 "type": "GlobalReference",
                 "value": "http://customer.com/Systems/ERP/012",
                 "idType": "IRI"
              }
           ]
        }
     }

In jsonExample.json the attributesubjectId is used, whereas the Part 1 document specifies externalSubjectId. The same inconsistency is seen in JSON examples within the Part 1 document.
I am not sure which name should be the correct one, as I can't find any reference to a change of this attribute, other than it being introduced alongside IdentifierKeyValuePair.

externalSubjectId is the correct name in V3.0RC01

JSON-Schema will be fixed with V3.0RC02.


does not save time on map

Everytime I am on a server, campaign or matchmaking, it never saves the time I have spent on the map and this is with the recently updated version from 2 months ago as well.

is this a specific map or any maps at all?

All maps
On Fri, Sep 8, 2023, 1:43 PM Owen Halliday @.***> wrote:

is this a specific map or any maps at all?
—
Reply to this email directly, view it on GitHub
https://github.com/drekdrek/grinding-stats/issues/27#issuecomment-1712020540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6XF4A23JXO5R2HOESOGQW3XZNKLBANCNFSM6AAAAAA4MMAPYI
.
You are receiving this because you authored the thread.Message ID:
@.***>

does the Grinding Stats folder exist in your Openplanet folder?

No it does not, and I am going to guess that's the reason why it won't save
any of the times. So would I just need to make a folder ?
On Fri, Sep 15, 2023, 10:33 AM Owen Halliday @.***>
wrote:

does the Grinding Stats folder exist in your Openplanet folder?
—
Reply to this email directly, view it on GitHub
https://github.com/drekdrek/grinding-stats/issues/27#issuecomment-1721382213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6XF4A52P6KJH52PAKEBSBTX2RRKXANCNFSM6AAAAAA4MMAPYI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yeah try making a folder, ill look into why its not detecting the folder not existing

do you get any errors in console when it starts or tries to load a file?

I'm currently not home at the moment but the only error I remember seeing
on the screen was mania exchange
On Fri, Sep 15, 2023, 10:44 AM Owen Halliday @.***>
wrote:

do you get any errors in console when it starts or tries to load a file?
—
Reply to this email directly, view it on GitHub
https://github.com/drekdrek/grinding-stats/issues/27#issuecomment-1721399526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6XF4A3PHTQV2PIVZKBFSY3X2RSWLANCNFSM6AAAAAA4MMAPYI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Want me to make a folder in OpenPlanet or the plugins folder in OpenPlanet?

make a Grinding Stats folder in OpenplanetNextOn Sep 15, 2023 7:19 PM, Unused-Joker @.***> wrote:
Want me to make a folder in OpenPlanet or the plugins folder in OpenPlanet?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

i do not have a OpenPlanetNext folder

the Grinding Stats folder is located at
C:/Users/<username>/OpenplanetNext/Grinding Stats
if this doesn't exist try creating it

Okay, lets see if that changes anything

I exited the map, went back in and it didnt save
also the only error that pops up on my screen is

I needed to change the permissions of my user folder and that fixed it
c:\users\name
^This folder


Metrics upsert appears to be very expensive

In our load testing, the metrics upsert is by a couple orders of magnitude the most expensive database query. We tried to disable it via the SSM enable_metrics parameter and re-run our tests, but it appears that this parameter does not actually control all of the places where metrics are involved, because the upsert still happens. We would:
a) adjust this so that the parameter actually works - at present disabling it appears to stop the app from plumbing the metrics route, but other code in the backend API still just calls the metrics SQL insert directly
b) like to turn it off entirely and run our load tests without any metrics table inserts whatsoever
c) fix the metrics collection to not bury the database
CC: @segfault, @arybka777

This has been removed and is now populated from a lambda function


Force expand PaymentsForInvoice fields. Rerun generator.

Current dependencies on/for this PR:

#71  👈
main

This stack of pull requests is managed by Graphite.

Merge activity

Feb 23, 12:50 PM EST: @jklein24 merged this pull request with Graphite.


Re-enable tests in E2E_Test.MvcControllerTest

Some test in E2E_Test.MvcControllerTest were disabled due to flakeyness. Once they're reliable again re-enable them.

Scaffolding tests were broken by the following chagne:
https://github.com/aspnet/EntityFramework/commit/58185bab7972f895dcdec71dc8250b32c76f6dfc#diff-ab3bc569c936729f7138226d324bb0b7L26
I think Scaffolding just needs to react.

Related: https://github.com/aspnet/EntityFramework/issues/8547

@prafullbhosale dynamic issue was fixed by PR aspnet/EntityFramework#8549


Upgrade to a /v2 module and bump deps

When tagging a v2, we should also update the Go module itself to a /v2 by suffixing.
Also updated the dependencies.
You should be able to merge this, tag a v2.0.1 and then users will be able to correctly go install ...

This is the type of errors users will see:
go install github.com/GoogleCloudPlatform/protoc-gen-bq-schema/v2@latest
go: github.com/GoogleCloudPlatform/protoc-gen-bq-schema/v2@latest: module github.com/GoogleCloudPlatform/protoc-gen-bq-schema@latest found (v1.1.0), but does not contain package github.com/GoogleCloudPlatform/protoc-gen-bq-schema/v2

Thanks Michael!


Mouse cursor does not accept click in Remote Desktop

When I use particular application in remote desktop some actions cause the mouse cursor no longer accept any click, I can move it but I can not click on any window, either within the Remote Desktop and even in my station, I can only use through the keyboard, and close the Remote Desktop window everything back to normal.
My PC: Ubuntu Mate
Server: Windows 2008 R2

Duplicate #2363


Policy for GKE private google access

This rule won't work with Forseti today due to the pagination and the need for this rule to reference data that may not be available. @joecheuk can you work to define how we should annotate this in regards to not usable with Forseti.
I suspect this rule will work fine in Gatekeeper since all the k8s data will all be available at eval time.

@dekuhn This certainly wouldn't work in Gatekeeper because it depends on looking at the configuration of the subnets which GKE is running on (information which is never actually exposed to k8s).

@morgante would this be a useful in CFT Scorecard?
@blueandgold @ryanismert the team should think about how we could run such a scan within Forseti. We will have this challenge with other rules going forward I am sure.

@dekuhn It would be, if/when we support referential constraints.

@blueandgold @charliewolf @joecheuk I don't think we want to accept this rule due to the referential data and the decision by the CV team to no support referential constraints at this time.
Should we close this PR as it and preserve its details. We could reopen at some point in the future when referential constraints will be supported.


create awesome footer

I want to create awesome footer for this website.
please assign me this issue under gssoc'23.

Sure !!
Assigned to u. Complete it in 10 Days and follow contributing.md  Guide


Integrate functional tests

configure https://github.com/smooth-code/jest-puppeteer in https://github.com/Cognifide/gradle-aem-multi/tree/flat-structure/test.functional/  build.gradle.kts

use instead https://www.cypress.io/

Ok I'd like to own the ticket.

Done


Branding changes

Fixes #1154

Description

Updated selected toolbar item styles.
Updated Storybook and NeetoUI versions.
Updated Storybook theme to match the branding.

@praveen-murali-ind _a
Checklist
~- [ ] I have made corresponding changes to the documentation.~
~- [ ] I have updated the types definition of modified exports.~
~- [ ] I have verified the functionality in some of the neeto web-apps.~

[x] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers

@AbhayVAshokan _a Please review.


[icons] Synchronize icons with Google

[X] I have followed (at least) the PR section of the contributing guide.

Closes #21295
Icons have been newly synced with Google, adding 200+ to the mix.  A few notes:

New icon dump contained icons starting with "5g" so a new naming exception has been added (5g > FiveG)
New icon dump had "\n" in one of its tags so I've added a case for that to the synonym update script
Motrocycle icon has been dropped by Google, so these changes re-export the TwoWheeler icon with a console warning in non-prod mode

Great work! We're missing a synonym "5g' for the FiveG icons, (and also "3d" for ThreeDRotation). Would you like to add them?

@alecananian I have rebased the pull request on the next branch as our active development branch.

Thanks for the updates! @mbrookes I've gone ahead and added those synonyms now as well.

The publishing script seems to systematically fail. I suspect the new icons makes us reach a timeout. There are too many of them.

Is that the ci/codesandbox step?  I noticed that failing on other new PRs as well. Earlier the errors just said deadline exceeded, but now I'm seeing:
{ [Error: EACCES: permission denied, mkdir '/tmp/output/@material-ui']
  errno: -13,
  code: 'EACCES',
  syscall: 'mkdir',
  path: '/tmp/output/@material-ui' }

Not sure, I have seen the same fail in other pull requests. However, it could be interesting to reduce the number of published files on the package, if it turns to be a bottleneck.

it could be interesting to reduce the number of published files on the package

Five "themes" per component, or separate package per "theme"?

Five "themes" per component, or separate package per "theme"?

@mbrookes A package per theme could be interesting, especially to scale to themes outside material design.

@material-ui/icons-md-filled
@material-ui/icons-md-outlined
…

They might be another leverage, force 1 level deep imports, drop the /esm/ folder, and index.js file.

Is that the ci/codesandbox step? I noticed that failing on other new PRs as well.

I encounter this in my own packages as well that have even less files than @material-ui/utils. The claim that file count makes this task fail is unconfirmed.

@alecananian Thanks!

If I'm not mistaken the icons have been included in the new v5 release, but still aren't in v4. Is it not planned now to include them in v4 anymore? @oliviertassinari wrote this in the latest v4 release notes:

⚠ This release marks the end of the active development on the v4.x versions, after 18 months of development.
We are moving all ongoing efforts to v5 (next branch) ✨.
This means a feature freeze on v4. The development of this version will be limited to important bug fixes, security patches, and easing the upgrade path to v5.

As v5 is still in alpha, that means the missing icons won't be available for production for quite a long time? Not the end of the world as you can include them yourself, but still 😢

Your analysis and conclusion are correct.


CAST/CONVERT: incorrect description of [Length]

https://docs.microsoft.com/en-us/sql/t-sql/functions/cast-and-convert-transact-sql?view=sql-server-ver15
states

but sql server allows this conversion
select cast(null as real(26)),convert(real(128),null)
pay attention to real(128)
https://docs.microsoft.com/en-us/sql/t-sql/data-types/float-and-real-transact-sql?view=sql-server-ver15
states that there is no length for REAL data type
also,
declare @r real(26)
produces error
Msg 2716, Level 16, State 1, Line 1 Column, parameter, or variable #1: Cannot specify a column width on data type real.
SQL version:
Microsoft SQL Server 2019 (RTM-CU14) (KB5007182) - 15.0.4188.2 (X64)

@OleksiiKovalov -- Oleksii, we appreciate your keen attention to the details in our documentation.
@MikeRayMSFT, @markingmyname -- Mike, Mark, please look into this issue.

https://www.youtube.com/watch?v=tsGE8DCUm2c

@OleksiiKovalov --
I agree with @WilliamAntonRohm - thank you for the attention to the details.
This appears to be a bug in the CAST/CONVERT code. It is likely legacy behavior inherited from older versions of SQL Server. You are welcome to file feedback to record your experience with the issue and how it impacts you.
If this causes specific problems for an implementation of the problem, you may Contact Microsoft Support.


Misuse of BufRead might lead to hangs

(This is a bug report, with attached code.. making it a PR? Eh, thanks github.)
The Reader utility apparently uses BufRead's fill_buf incorrectly. It repeatedly calls fill_buf until the codec makes progress. However, typical BufRead implementations, including std::io::BufReader will never read more data from the underlying reader, unless the client has consumed every single byte.

Returns the contents of the internal buffer, filling it with more data from the inner reader if it is empty.

The test tries to demonstrate by this by having an Operation which wants two bytes, but a Read which only returns one byte at a time. It hangs indefinitely. I didn't really check the test is correct, but it demonstrates the problem I am thinking about.
I've not actually hit this bug with zstd-rs, but have written the same bug in other code. Is zstd itself doing internal buffering, helping us not hit this (and making the retry loop pointless)? I guess the test could be extended to check that.

Hi, and thanks for the report!
Indeed, operations are currently expected to always either read at least one byte, or write at least one byte per step. This is indeed (I think) what is guaranteed by the zstd API we're using.
A more general implementation that would be robust to different operations might be interesting, especially if we want to split it in a separate crate, but might be trickier to design, especially if we want to avoid unnecessary copies for performance reasons.

TLDR: yes, the zstd library has its own internal buffer, and will always consume some input.


Check Accept-Encoding headers before creating compression provider

Fixes: https://github.com/aspnet/BasicMiddleware/issues/142
@Tratcher

Brought ShouldCompressResponse back.

Added auto flush, fixes https://github.com/aspnet/BasicMiddleware/issues/137


Siege Tank name is misleading based on its attack type(s)

Not quite prepared to call this one a bug but definitely worth throwing in an improvement for.

I tend to forget about these small ones whne doing some "fine tuning" so just here as a reminder

Just double checked.
Siege tank (Kul'tiras) does have siege damage.
I incorrectly assumed "Assault tank" (goblins) was called siege tank as everyone calls it goblin siege.
Alternatively, the bipedal star-wars looking ones (siege walker) do not have siege either.
@Technopig1992 can maybe take to a discord chat in how we might wanna proceed with these.


Organized C Coding with Dark and Light Modes for Easy Access

I have placed all the C code into cards for better visual representation. I’ve also added two modes, dark and light, to suit different preferences. All the code is well-organized, making it easy for any user to copy and paste as needed.

@Ek-ta-bharti appreciate your effort but currently we don't want to develop website, you can add algorithm. We have mentioned here https://github.com/AlgoGenesis/C/tree/main/Website .

@pankaj-bind   Hello, I would like to request the following algorithm categories to be assigned to me for my project:
Network Flow Algorithms: These analyze flow within networks and focus on maximizing flow (e.g., Ford-Fulkerson Algorithm).
Approximation Algorithms: These provide near-optimal solutions for complex optimization problems (e.g., Traveling Salesman Problem).
Branch and Bound Algorithms: These systematically explore the solution space for optimization problems (e.g., Knapsack Problem).
Heuristic Algorithms: These offer approximate solutions for difficult problems using rules of thumb (e.g., Genetic Algorithm).


pull request for e2e test at 12/31/2016 19:45:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Click events on NFT wallet view

Right now, I don't a way to register click events on the NFT wallet component without actually modifying the component code. Am I reading this right?
If I wanted to add click event support and have the change merged back, does the team have any strong opinions on how this should be implemented?

You are reading this right, we are working on adding click functions to the Organisms
There aren't any strong opinions if you want to contribute to the code. You can refer to this and how this is implemented.
There are tests for proper linting that need to be passed before merging the code and thats it!

Hey @wtracy
This feature is added, you can use actionables like in the [https://goldrush-kit.vercel.app/?path=/story/organisms-nft-collection-view--nft-collection-view](urlstorybook

Thanks!
I have it working with my local copy, and haven't had a chance to get it
cleaned up and submit a pull request.
William
On Wed, May 29, 2024, 1:44 PM Yashvardhan Jagnani @.***>
wrote:

Hey @wtracy https://github.com/wtracy
This feature is added, you can use actionables like in the [
https://goldrush-kit.vercel.app/?path=/story/organisms-nft-collection-view--nft-collection-view](urlstorybook
—
Reply to this email directly, view it on GitHub
https://github.com/covalenthq/goldrush-kit/issues/162#issuecomment-2138232192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARYQK7BTEHWLKGEGN5NW3ZEY42PAVCNFSM6AAAAABG6BO2XSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGIZTEMJZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


[ENH] test framework: invert test loop order plus generators

See here for overview of recent test framework related PRs:
https://github.com/alan-turing-institute/sktime/issues/2053

Combines modifications to tests in #2054 and #2022

closed as https://github.com/alan-turing-institute/sktime/pull/2142 was merged


A more informative exception on unhashable name type

@goto40 This change adds a better exception message for #40 and #266. Also the docs is extended to better explain the issue and the right way to solve the problem.
Fix #40 #266
Code review checklist

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Commit messages are meaningful (see this for details)
[ ] Tests have been included and/or updated
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Standalone docs have been updated accordingly
[ ] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
to update for typo fixes and such).

Very good work! The error message should point the user in the correct direction.
While implementing the scope providers I never had a name type other than string in mind... Maybe we should add a note in scoping.md:
"the provided scope provider implementations FQN, RelativeName and ExtRelativeName assume a name attribute to have a string type, like for name=ID."
For the plain name scope provider I am not 100% sure...

While implementing the scope providers I never had a name type other than string in mind... Maybe we should add a note in scoping.md:
"the provided scope provider implementations FQN, RelativeName and ExtRelativeName assume a name attribute to have a string type, like for name=ID."

@goto40 Sure, I agree. Please add the note to the docs. I don't see any point in having names of other types.


first pass at thread-safe version to use within Glyphs using _Thread_local for global vars

[ Partially copied from my email to Georg last night. ]
I believe the changes committed to the MakeThreadSave branch of psautohint [in this pull request] should allow you to call it from within Glyphs. Short version: ended up backing out mostly of passing along the global state and used C11's _Thread_local for all global and file-scoped static variables.
For an interim test, perhaps it would be useful to have an internal option in Glyphs to switch between calling AutoHintString() directly or using the compiled binary with the time to hint logged.
Though not included in this commit, I did add some tests for multiple calls and even calling the external binary (hardcoded on my installed path) for some rough tests, along with adding testPerformance...() that simply called those routines in a measureBlock. The multiple internal routine calls test needs to be cleaned up and refactored to make it simpler to add more test data before committing.
Couple quick questions: In the WIP very early commit, you commented out a couple routines:
- chkBad()
- ReportLinearCurve()
Was that for some reason other than the thread-safe work? I uncommented chkBad() in this commit, but left ReportLinearCurve() commented out. Mentioning in case commenting out chkBad() was intentional and should be commented out, again.
Also, I saw reference to #if LOGDEBUG in report.c mentioned in commit 5cf7d0e as performance. I don't think that did what you want. LOGDEBUG is really AC_LogDebug which is equal to -1. So, the #if LOGDEBUG is #if -1 and would always be included.

I have merged and tested the new lib and it works fine. Thanks
I don’t need the ReportLinearCurve() as is just reporting. And it is not needed.
The chkBad() is in a if branch that relies on gEditGlyph. That is never set from within Glyphs.
There is more code that Glyphs doesn’t need …


Adding support for 'ignore stopped containers'

Addresses https://github.com/aporeto-inc/aporeto/issues/2091

Closing in favor of https://github.com/aporeto-inc/enforcerd/pull/1465


Re-attach handlers?

The handlers (e.g. mousewheel) are attached to the container element.
However, this interferes with elements inside, e.g. scrolling inside the container element.
How can I let Pannellum attach these handlers to an element inside?
Can I manually detach + re-attach these handlers from an outside script (as workaround)?

Is this still an issue now that #452 has been merged in?

With all UI related elements/handlers separated, this issue has been also resolved. Thanks.


problem

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\pauldyu57\Anaconda3\lib\site-packages\spyder\plugins\editor.py", line 1712, in new
text, enc = encoding.read(self.TEMPLATE_PATH)
File "C:\Users\pauldyu57\Anaconda3\lib\site-packages\spyder\utils\encoding.py", line 243, in read
text, encoding = decode( open(filename, 'rb').read() )
FileNotFoundError: [Errno 2] No such file or directory: 'C:\Users\pauldyu57\.spyder-py3\template.py'
Version and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.13.3 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26.1 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.4 (OK)

Thanks for reporting. This is a duplicate of #5717 , which is already being investigating and will hopefully be fixed in a new version soon, and so this issue will be closed. In the meantime, please reference my comment over there for some more information and potential mitigations in the meantime, and if you have more detail about the circumstances in which it occurs please provide it there. Best of luck!


Add Changelog

Add file with changelog and updates sorted by release.
This file should be listed in the documentation as well.
You can take copy the style of the changelog used in geotrek-admin or geotrek-rando-v3.
It should list new features, breaking changes, updates in configuration, enhancements, bugfix, maintenance, etc.
Each new pull request should update the changelog accordingly with the modifications.

ce21944fac44574d751a7bb808c14ffdd609f430

Can you explain more the procedure ? Where is the changelog, how can we maintain it ?

Ok I think I get it now. So each time you want to do a release you'll need to open a PR like #85 ?

When i will merge this PR, a release will be created. This action handle the versioning based on commits.

fix: which represents bug fixes, and correlates to a SemVer patch.
feat: which represents a new feature, and correlates to a SemVer minor.
feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.

Then a new PR will be created automatically by this action when there will be a new commit.


Tunnel upgrade prices suddenly show huge numbers

After send ants to explore and leaving them until it auto stops the upgrade prices are suddenly in the billions.
Reloading the page resets the prices to the correct numbers.

Ya this one is weird, I'm unable to reproduce, but have heard about the issue multiple times.


Request Failed. Server issues

I have Ollama running on my Windows machine and ngrok running with a static url. I use that url in the settings of the app and it says it's good, I check the url on multiple devices and it says "Ollama is running!", but when I select the model in the app and send a message I get "Issue: Request Failed. Server issues". Is this a problem with my pc setup or my phone?

After selecting a model or before the models are displayed?

After selecting the model. I select llama3.1 and try sending a message and that's the error I get.

Have you tried any other model?

Just tried with phi3, same issue

Could you download the latest version, v1.2.0 and set the timeout multiplier (Settings > Interface) to ten? Does that solve the issue?

Here are the thing I did that fixed the problem (not sure which did what but it's working now):
Updated everything (app, ngrok, ollama)
Set timeout multiplier to 10
Appended "--host-header="localhost:11434" to my ngrok run command (this is very likely what fixed it)


fix(sdk): do not create temp folders on import

Description

Fixes WB-16987
Fixes #NNNN

What does the PR do?
Include a concise description of the PR contents
Testing
How was this PR tested?

hey @biaslucas, this is a follow-up on https://github.com/wandb/wandb/pull/6891 addressing https://github.com/wandb/wandb/pull/6891#pullrequestreview-1842515931. however, I don't really like what I'm doing here :) Deferring to you the part that creates the temp folder for artifacts -- what would be your suggestion?

thanks @dmitryduev  — it's great your latest PRs have (1) cleaned up temp dirs (2) only create temp dirs on runtime usage instead of imports.
re: lock usage. i've added a suggestion to avoid it but my suggest might be naive and miss context


Specify the maximum number of fireworks to start

This is different than launch() because it respects the delay (whereas launch() just does everything at once).
Feel free to not accept this or change it however you like. I haven't tested it at all as the changes I made were in JavaScript and I can't get the project to build/work with typescript.
Checklist

[ ] run pnpm format
[ ] documentation is changed or added
[X] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@aaron13100 you misunderstand me. 😄
i mean about this:

use my own function to play audio so I can adjust the volume and follow whether it's playing or not.
wait to load the audioContext until initTrace() so there's no warning about missing user interaction in Firefox.

currently implemented like this:
https://github.com/crashmax-dev/fireworks-js/blob/8c15ac042fdafee69fd724e59bb2bb01a32230df/packages/fireworks-js/src/fireworks.ts#L127-L136


🩹 csharp detection

ray.so does not recognise cs as the csharp language type
This PR addresses this by rewriting cs to csharp.

Thanks for this great PR!


Ingress: improve status writer

This has 2 parts (and 2 commits):

Fix https://github.com/istio/istio/issues/44142, a regression in master, wehre we do not stop watching an Ingress if it points to a bogus IngressClass. This fixes a flaky test
Currently ingress status sync runs on a loop, every 60s syncing things. This makes it very very slow - both for users and tests. This is changed to an event driven model so it updates ~instantly.

No release note is added as the regression has not yet pushed to a release.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test lint

unit-tests-arm64_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test lint

unit-tests-arm64_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test unit-tests-arm64

unit-tests_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Changes look good. Test data race is related.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test unit-tests-arm64

unit-tests_istio
5d5fbc6e1b6a78bcd76b00a78fbbe4e822b005ad
link
true
/test unit-tests

lint_istio
cfbeeb2f23d6b225540740441f6b67b108cb9373
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Added URL update on scroll

This updates the hash in the URL when scrolling the site with the current visible section's ID.

 :D

Haha, I completely forgot about this one. You added all your feedback and then... I just stopped? Let me look into that branch again.

Classic @morkro. <3

So, shall I close or? :D

I think we have changed so much over the past year, I would've to start over anyway. Maybe keep the branch so we don't lose all the effort yet?


Bump version to v0.28

Pending PRs from https://github.com/rust-bitcoin/rust-bitcoin/milestone/10, specifically:

#776
#587

Draft for the release info is autogenerated by GitHub, so we have to edit it. Please feel free to edit it right here, in place. Once we will be happy with it, I will add it to the CHANLELOG.md to the release commit.
What's Changed
Breaking changes

Script serialization/deserialization in serde non-human-readable format by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/596
use Amount type in verify by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/621
Add OP_CHECKSIGADD and OP_SUCCESSxxx by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/644
WitnessVersion type by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/617
Taproot P2TR address by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/563
Improvements to Error types (part 4) by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/625
Add Bloom filter network messages by @benthecarman in https://github.com/rust-bitcoin/rust-bitcoin/pull/580
Adds Taproot BIP341 signature message and create a unified sighash cache for legacy, segwit and taproot inputs by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/628
~Changes for checking script size and returning Result<Address, Error> for p2sh by @vss96 in https://github.com/rust-bitcoin/rust-bitcoin/pull/655~
Add taproot data structures by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/677
P2TR address from untweaked key by @nlanson in https://github.com/rust-bitcoin/rust-bitcoin/pull/691
Making globals part of PSBT struct. Closes #652 by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/654
New Witness struct to improve ser/de perfomance by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/672

Theoretically non-breaking
These are things people shouldn't have depended on in the first place but may be considered breaking in some contexts.

Removed fuzztarget feature by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/634

New APIs/features

Implement possible_networks function for Address by @elsirion in https://github.com/rust-bitcoin/rust-bitcoin/pull/618
Super-trivial: Implement FusedIterator for Instructions by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/733
Implement Sum for amount types by @sgeisler in https://github.com/rust-bitcoin/rust-bitcoin/pull/615
Implement Block.get_strippedsize() and Transaction.get_vsize() by @visvirial in https://github.com/rust-bitcoin/rust-bitcoin/pull/626
util/address: make address encoding more modular by @benma in https://github.com/rust-bitcoin/rust-bitcoin/pull/643

Bug fixes

Fixing no_std for Amount sum iterator by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/651
Fix Uint256::increment panics by @TheBlueMatt in https://github.com/rust-bitcoin/rust-bitcoin/pull/612
Hotfix for secp256k1 alloc feature by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/694

Mildly interesting improvements
These improvements are mainly internal or documentation but may have noticeable impact on the quality of the crate.

Document cargo features by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/633
Add i686 to tested architectures by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/659

Other/uncategorized changes

fix changelog date by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/640
~Use consts for address prefix values by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/632~
Fix documentation referencing macro var by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/623
Check for overflow in Script::bytes_to_asm_fmt() by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/658 (this was released in point release)
Document lack of support for 16-bit pointers by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/663
Improve Fuzz CI by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/664
Refactor Script::bytes_to_asm_fmt to use iterator by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/662
no-std cleanup by @devrandom in https://github.com/rust-bitcoin/rust-bitcoin/pull/637
util/address: remove unused generic type by @benma in https://github.com/rust-bitcoin/rust-bitcoin/pull/698
~Clean up module level rustdocs by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/689~
tests: improve coverage for P2tr and AddressType by @LeoComandini in https://github.com/rust-bitcoin/rust-bitcoin/pull/683
~Return the correct LeafVersion when building a Taproot ControlBlock by @afilini in https://github.com/rust-bitcoin/rust-bitcoin/pull/703~
~Add unit test for bitcoin_merkle_root functions by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/711~
P2tr fixes by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/707
~util/address: Improve docs by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/704~
Huffman Bug Fix by @JeremyRubin in https://github.com/rust-bitcoin/rust-bitcoin/pull/699
Huffman Encoding Bug Test by @JeremyRubin in https://github.com/rust-bitcoin/rust-bitcoin/pull/700
~Use expect instead of unwrap for calls to consensus_encode by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/719~
Use TapTweakHash::from_key_and_tweak() method in computing tweak for UntweakedPublicKey by @nlanson in https://github.com/rust-bitcoin/rust-bitcoin/pull/697
Decrease Huffman Weights to u32 by @JeremyRubin in https://github.com/rust-bitcoin/rust-bitcoin/pull/701
~Use un/tweaked public key types by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/728~
Improvements to script methods related to Taproot by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/721
add helpful message to division-by-zero panic by @z8674558 in https://github.com/rust-bitcoin/rust-bitcoin/pull/743
Separate signature hash types by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/702
add MAX_MONEY public constant to Amount by @z8674558 in https://github.com/rust-bitcoin/rust-bitcoin/pull/742
~Refactor bitcoin_merkle_root functions by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/710~
BIP341 test vectors by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/695
Fixed a bunch of clippy lints, added clippy.toml by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/686
Re-export SigHashType in lib.rs by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/749
Fixed docs.rs metadata by @Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/744
Improve parsing of Denomination string by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/731
~transactions: add a note about get_vsize and standardness rules by @darosior in https://github.com/rust-bitcoin/rust-bitcoin/pull/665~
~Allow specifing a raw TapLeafHash in sighash computation by @afilini in https://github.com/rust-bitcoin/rust-bitcoin/pull/722~
Add support for taproot psbt fields BIP 371 by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/681
Tapsighash test vectors by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/705
Deprecate StreamReader by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/680
~Put rustdocs above attributes by @tcharding in https://github.com/rust-bitcoin/rust-bitcoin/pull/753~
Update to secp256k1 0.21.2 by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/755
Use test_data for big objects, add big block for benchmarking by @RCasatta in https://github.com/rust-bitcoin/rust-bitcoin/pull/750
PSBT: partial sig data type by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/669
Converting LeafVersion into an enum by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/718
Taproot: BIP32 extended keys using Scep256k1 keys instead of bitcoin ECDSA by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/590
Taproot trivial post-merge fixups by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/761
wrap u8 and LeafVersion in backticks and square bracket in doc by @bruteforcecat in https://github.com/rust-bitcoin/rust-bitcoin/pull/766
improve example: take hex-encoded seed instead of WIF in bip32 example by @bruteforcecat in https://github.com/rust-bitcoin/rust-bitcoin/pull/760
PSBT BIP32 keys using to Secp256k1 keys instead of bitcoin ECDSA by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/591
Rename inner key field in PrivateKey and PublicKey by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/762
Add Witness::new() by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/771
Change type of final script witness to Witness from Vec<Vec> by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/774
Taproot tweaks generalization & KeyPair support by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/696
Issue #394 - Refactor Block::merkle_root()  by @nilswloewen in https://github.com/rust-bitcoin/rust-bitcoin/pull/775
Fixups for taproot improvements by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/778
Introduce PsbtSigHashType by @sanket1729 in https://github.com/rust-bitcoin/rust-bitcoin/pull/779
add nano and pico BTC to Denomination enum by @bruteforcecat in https://github.com/rust-bitcoin/rust-bitcoin/pull/768
replace unncessary closure with function pointer in FromStr::from_str for Deonomation by @bruteforcecat in https://github.com/rust-bitcoin/rust-bitcoin/pull/784
Minimally-invasive separation of bitcoin keys from ECDSA signature types by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/757

New Contributors

@Kixunil made his first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/634
@elsirion made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/618
@tcharding made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/632
@visvirial made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/626
@benthecarman made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/580
@vss96 made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/655
@nlanson made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/691
@benma made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/698
@LeoComandini made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/683
@z8674558 made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/743
@bruteforcecat made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/766
@nilswloewen made their first contribution in https://github.com/rust-bitcoin/rust-bitcoin/pull/775

Full Changelog: https://github.com/rust-bitcoin/rust-bitcoin/compare/0.27.0...0.28.0

LOL that half the "first contributors" are established regulars now. It's been a long time since we had a release.
I guess as far as editing, maybe people should just add strikethrough text to the PR they consider too minor to mention, so we can discuss controversial ones?

I do not have edit permissions on the original post. All of my contributions listed are too minor to mention IMO except perhaps:

Improve parsing of Denomination string

I've invited you to be a maintainer on this repo, so you should be able to edit the issue now.

I guess as far as editing, maybe people should just add strikethrough text to the PR they consider too minor to mention, so we can discuss controversial ones?

I think mine is definitely too minor to be worthy of release notes, feel free to strikethrough/remove.

I've invited you to be a maintainer on this repo, so you should be able to edit the issue now.

Awesome, thanks!

I guess as far as editing, maybe people should just add strikethrough text to the PR they consider too minor to mention, so we can discuss controversial ones?

My change is minor as well, so feel free to remove it.

I strongly believe it'd be very useful to call out breaking changes separately. Will be probably hard to track them down as I'm not confident all of them have API break label.
(Also LOL at my first contribution - I believe my first was overflow bug fix long.)

Started categorizing issues but there are many of them and have to go AFK for a bit and didn't want to risk losing the changes. (Hope it's OK given we can see edit history.)

I guess as far as editing, maybe people should just add strikethrough text to the PR they consider too minor to mention, so we can discuss controversial ones?

I can't directly edit the post, but I think mine aren't worth mentioning. They were mostly improvements/bugfixes to unreleased taproot code, so they also won't have any real impact to external users.

Strike through done for those requesting it up to now.

Do we want to re-release secp256k1 with Parity fixup before we release 0.28.0?

@apoelstra, I think we should fix the parity along with https://github.com/rust-bitcoin/rust-secp256k1/issues/378. It would simplify a lot of things for rust-miniscript downstream.

I don't think we should be tagging everyone for the release notes PR.
The goal of release notes should be

Document breaking changes. Suggest how to fix them if they are non-trivial
Highlight new features and APIs that might be of interest.
Thank everyone for the contributions

I agree with Sanket. I'd add bugfixes as well, as they would definitely be of interest to a downstream project.
-------- Original Message --------
On Jan 21, 2022, 03:10, Sanket Kanjalkar wrote:

I don't think we should be tagging everyone for the release notes PR.
The goal of release notes should be

Document breaking changes. Suggest how to fix them if they are non-trivial
Highlight new features and APIs that might be of interest.
Thank everyone for the contributions

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

Superseded by #915

I think you meant: superseded by #944


Google map on iOS does not exactly centre on the screen

Google map on iOS does not exactly centre on the screen. The screenshots below demonstrate the difference between iOS & Android. The view has been created using a Stack with Google Map and PositionedWidget.fill widgets. The positioned widget contains a black dot at the centre of the screen.
The red tint is the background for the PositionedWidget.fill widget, which shows its extent is full screen.
On Android there is an exact overlap. This makes it hard for implementing features like ones you see on ride hailing/food delivery applications where a user selects the centre location as their pickup/drop. Having this discrepancy will lead to different locations being selected that what the user intended to do.
Using: google_maps_flutter: ^1.2.0
Screenshots
iOS

Android

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on Mac OS X 10.15.4 19E287 darwin-x64, locale en-IN)
    • Flutter version 1.22.6 at /Users/abhaysood/flutter
    • Framework revision 9b2d32b605 (4 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/abhaysood/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio 2.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.10.1

[✓] IntelliJ IDEA Ultimate Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin installed
    • Dart plugin version 203.6912

I tired to add an offset to the black dot to workaround this. But it seems like the alignment is different on different device sizes. So I can't even compute this offset reliably. Check the screenshots:

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.22.6 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 9b2d32b605 (4 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 14.2
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)

! Doctor found issues in 1 category.

@darshankawar  I went over the code in google_maps_flutter but could not find how Google map logo is taking into account the bottom safe area on iPhone 11 Pro even though I am not using a safe area in my app. I have a feeling that might be one of the issues.
Sample app
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  static const CameraPosition _initialCameraPosition = CameraPosition(
    target: LatLng(-6.1753924,<PHONE_NUMBER>),
    zoom: 12,
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Stack(
          children: [
            _buildGoogleMap(),
            _buildOverlay(),
          ],
        ),
      ),
    );
  }

  GoogleMap _buildGoogleMap() {
    return GoogleMap(
      initialCameraPosition: _initialCameraPosition,
      myLocationEnabled: true,
      myLocationButtonEnabled: true,
      zoomControlsEnabled: false,
      indoorViewEnabled: false,
      compassEnabled: false,
      mapToolbarEnabled: false,
      onMapCreated: (controller) {},
      rotateGesturesEnabled: false,
      scrollGesturesEnabled: false,
      tiltGesturesEnabled: false,
      zoomGesturesEnabled: false,
    );
  }

  Widget _buildOverlay() {
    return Positioned.fill(
      child: Icon(
        Icons.circle,
        size: 16,
      ),
    );
  }
}

Output
iPhone 11 Pro (iOS 14.0)

iPhone 6s (iOS 12.6)

Thanks @abhaysood for the code sample. I do see slight variation in the position. Verified on iPhone 6s (OS 14.3), iPhone Pro max 12 (simulator).

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.6 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 9b2d32b605 (4 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.2

! Doctor found issues in 1 category.

We need to evaluate the behavior of Google Map SDK on iOS to see if the issue is caused by the plugin or the SDK.

I can reproduce the issue using google_maps_flutter: ^2.0.3

code sample
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  static const CameraPosition _initialCameraPosition = CameraPosition(
    target: LatLng(-6.1753924,<PHONE_NUMBER>),
    zoom: 12,
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Stack(
          children: [
            _buildGoogleMap(),
            _buildOverlay(),
          ],
        ),
      ),
    );
  }

  GoogleMap _buildGoogleMap() {
    return GoogleMap(
      initialCameraPosition: _initialCameraPosition,
      myLocationEnabled: true,
      myLocationButtonEnabled: true,
      zoomControlsEnabled: false,
      indoorViewEnabled: false,
      compassEnabled: false,
      mapToolbarEnabled: false,
      onMapCreated: (controller) {},
      rotateGesturesEnabled: false,
      scrollGesturesEnabled: false,
      tiltGesturesEnabled: false,
      zoomGesturesEnabled: false,
    );
  }

  Widget _buildOverlay() {
    return Positioned.fill(
      child: Icon(
        Icons.circle,
        size: 16,
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.5, on macOS 11.3 20E232 darwin-x64, locale
    en-GB)
    • Flutter version 2.0.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision adc687823a (13 days ago), 2021-04-16 09:40:20 -0700
    • Engine revision b09f014e96
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554                        •
      android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 (mobile)      • ABF92D13-8EC5-4C28-B825-EEA9197A69A0 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)         • macos                                •
      darwin-x64     • macOS 11.3 20E232 darwin-x64
    • Chrome (web)            • chrome                               •
      web-javascript • Google Chrome 90.0.4430.93

• No issues found!

[✓] Flutter (Channel master, 2.3.0-1.0.pre.168, on macOS 11.3 20E232 darwin-x64,
    locale en-GB)
    • Flutter version 2.3.0-1.0.pre.168 at /Users/tahatesser/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 93242d7548 (9 hours ago), 2021-04-28 19:19:05 -0700
    • Engine revision e7939e091e
    • Dart version 2.14.0 (build 2.14.0-48.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554                        •
      android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 (mobile)      • ABF92D13-8EC5-4C28-B825-EEA9197A69A0 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)         • macos                                •
      darwin-x64     • macOS 11.3 20E232 darwin-x64
    • Chrome (web)            • chrome                               •
      web-javascript • Google Chrome 90.0.4430.93

• No issues found!


Please reconsider forking httprouter

Back in https://github.com/influxdata/influxdb/commit/3dbb9c0fd2d8423a6116c3106e60fff23a6faeec you decided to fork julienschmidt/httprouter to influxdata/httprouter . I'd like you to reconsider forking project like this and move your changes upstream as much as possible. This fork will likely not be taken care off and will be cut from upstream updates and potential security fixes.
You already have forked this project before and it was never updated anymore: github.com/bouk/httprouter
So now you have 2 forks of the same project to add a single feature, which will never benefit from upstream updates.

@eclipseo thanks for the issue. @GeorgeMac what do you think? Was there a specific reason for the fork?

Thanks @eclipseo and @russorat !
I will get this on my radar as support for what we needed got merged into https://github.com/julienschmidt/httprouter/pull/286
It is slightly different shape to our fork, but solves the same problem. So I just need to do a bit of work to get the upstream change integrated.


Don't scan the dot folders

Description
I have some folders like .localhistory and inside there are backups of my .sln files. Paket incorrectly attempts to scan those too.

you can stop paket by placing an empty paket.dependencies file in .localhistory.

feature request: add support for a .packetignore? ;D

In general I'm fine with changing the current filter to ignore such
folders. I think a PR has good chances to get merged.
Lukas Rieger<EMAIL_ADDRESS>schrieb am Sa., 16. Juni 2018,
15:11:

you can stop paket by placing an empty paket.dependencies file in
.localhistory.
2.
feature request: add support for a .packetignore? ;D
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/3250#issuecomment-397811466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNOKyApv2rUkE0B5S-Rpot81n062hks5t9QQXgaJpZM4Ulitg
.

@forki,  perhaps good candidate for Paket 6?

@OnurGumus sure we take PRss


ExpansionPanelList requires two pumps to expand

The expansion_panels_test.dart test shows that ExpansionPanelList requires two pumps to expand. It should only require one.
(https://github.com/flutter/flutter/issues/5648 is hiding this bug right now, but once it is fixed the problem will be more obvious.)

MergeableMaterial has the same problem.
I'll put a link to this bug everywhere where I ran into this problem in the tests, so once this bug is fixed the codebase should have no such links.

This is probably actually a bug in AnimationController. Taking.


New version: PolyesterWeave v0.1.10

Registering package: PolyesterWeave
Repository: https://github.com/JuliaSIMD/PolyesterWeave.jl
Created by: @chriselrod
Version: v0.1.10
Commit: 7a1e6e329f0b4c77b029210dd8f58f5802b49f97
Reviewed by: @chriselrod
Reference: https://github.com/JuliaSIMD/PolyesterWeave.jl/commit/7a1e6e329f0b4c77b029210dd8f58f5802b49f97#commitcomment-83437482
Description: Scheduler for Polyester.jl and compatible libraries such as LoopVectorization.jl.

block


I pushed a commit to delete the vendor directory.  The vendor directory is making the diff hard to understand for this PR and PR #20.


Document memory planning guidelines

Proposal
I would like to ask the prometheus dev community to consider adding some documentation around estimating the memory requirements of prometheus.
The fact that prometheus is mostly being run in memory capped containers and is OOMkilled when reaching the mem limit is surprising many users who are accustomed to robust software that degrades instead of dying.
I've been running prometheus in production for a while which is occasionally OOMKilled. I have expanded the memory limits more than once to arbitrary limits but I would prefer to make an educated estimation for a reasonable limit given my workload.
I have read the TSDB design paper which was super interesting but I don't feel that it gave me a practical hint to my problem, and even if I did, I think this is something the average user is far away from doing, and I'd consider this a development task rather then a usage question.
Since being in this state I have also learned that many others are in the same situation and are just "living with it", which is unfortunate.
Can we please discuss this topic, and possibly document our conclusions in the readme?
(I understand that planning for queries is harder, so we can stick to planning for metrics ingestion only which is supposed to be predictable)

HI, Any insights about this?

I still think this issue needs to be formally addressed, but it's worth mentioning that since opening this issue, Robust Perception posted this calculator:
https://www.robustperception.io/how-much-ram-does-prometheus-2-x-need-for-cardinality-and-ingestion

Is it possible to provide the formula or method of calculation used in the blog

There is another insightful blog post: https://www.robustperception.io/why-does-prometheus-use-so-much-ram

Hello from the bug scrub.
While we acknowledge that such a memory planning document would be super useful, we are chasing a moving target here. The code is continuously optimized (reducing the memory usage) and new features are added (potentially increasing memory usage), so any serious memory planning document will be out of date very soon. Furthermore, the question itself is very tough to answer because the shape of your data changes the memory usage.
Given that nobody has given a try to write up an official memory planning document in the last five years, it's probably best to tap into the wisdom of the crowd and search the web for experiences people have made in various situations.
This is not ideal, but we'll close this issue anyway because we just don't have a concrete plan of action how to go forward with this.
If somebody has a plan how to tackle this and wants to invest work in it, please follow up and we'll happily re-open.


issue with Server (can not be find)

Hello.
When i install FireCoder vsix file offline with VScode, i got these errors:

Server file info not found (while starting VScode)
fetch failed (when start chat)

It seems he can not find the server.exe file ? Maybe it would be a good idea to add a option for defining a own path to its file inside the FireCoder-Extension-Settings.
Surprisingly, if i am online and i install FireCoder vsix file with VScode, than it works. Only offline install seems not to work.
I will try to investigate a bit more into this.

Hello.
You are right, FireCoder can't start offline right now, because we are trying to get a new version of the server at every start of the extension.
But I think I can change it to work offline and start the current version of the server if we have it.

Ah ok.... I wasnt sure if its only me, only my System that has this problem. I mean, its nothing big, to be once online. But somehow i like things to work also offline. Maybe because i got often in situations where i dont have a stable connection. And than i am lost without internet. Thats why i prefer Software to be usable also offline ;-)


Correct PHPDocs of doSendToRouter

The PHPDocs of doSendToRouter where not the same as the types of the method's arguments

Thanks for your pull request! We love contributions.
However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package.
If you want to contribute, you should instead open a pull request on the main repository:
https://github.com/php-enqueue/enqueue-dev
Read the contribution guide
https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md
Thank you for your contribution!


Denote SXG support in Samsung Internet 11+

SXG was first supported in Chromium M73, and Samsung 11 is the first version running an equal or higher milestone.
I've also confirmed that SXG works on my phone on Samsung Internet (currently ver 14, but I tested earlier too).

Thanks!


fix alphabet translation using hash function and prefix

hash function taken from here

hash function taken from here

Would suggest to also use a dictionary because the hash is not very long.
There is a good chance that a whole project including some libraries would have more than 10000 functions and variables so it could actually have 2 functions with the same name.

Would suggest to also use a dictionary because the hash is not very long.
There is a good chance that a whole project including some libraries would have more than 10000 functions and variables so it could actually have 2 functions with the same name.

A nice and clean solution might be to just create a counter and use it's value to name variables and functions.

A nice and clean solution might be to just create a counter and use it's value to name variables and functions.

@dorilahav , it's important to stay deterministic,
I think it would be a good idea to use both hash and transliteration for readability sake.
function $chava_46165799_lbrch($chava_1432970484_mbvrch) {
    console.log('היוש, ' + $chava_1432970484_mbvrch);
}
$chava_46165799_lbrch('עולם');

WDYT?

@dorilahav , it's important to stay deterministic,
I think it would be a good idea to use both hash and transliteration for readability sake.
function $chava_46165799_lbrch($chava_1432970484_mbvrch) {
    console.log('היוש, ' + $chava_1432970484_mbvrch);
}
$chava_46165799_lbrch('עולם');

WDYT?

@dorilahav , it's important to stay deterministic,
I think it would be a good idea to use both hash and transliteration for readability sake.
function $chava_46165799_lbrch($chava_1432970484_mbvrch) {
    console.log('היוש, ' + $chava_1432970484_mbvrch);
}
$chava_46165799_lbrch('עולם');

WDYT?

I agree

@dorilahav , it's important to stay deterministic,
I think it would be a good idea to use both hash and transliteration for readability sake.
function $chava_46165799_lbrch($chava_1432970484_mbvrch) {
    console.log('היוש, ' + $chava_1432970484_mbvrch);
}
$chava_46165799_lbrch('עולם');

WDYT?

I agree

@dorilahav I do agree with @elisherer that we want determinism. I also agree that we want to avoid collisions of hash result. I think that a combination of the two should be safe enough for the purposes of חווה סקריפט.
closing in favour of https://github.com/ChavaScript/chavascript/pull/36

@dorilahav I do agree with @elisherer that we want determinism. I also agree that we want to avoid collisions of hash result. I think that a combination of the two should be safe enough for the purposes of חווה סקריפט.
closing in favour of https://github.com/ChavaScript/chavascript/pull/36


Allow developers to customize the OIDC parameters when calling Challenge

Related: https://github.com/aspnet/Security/issues/990
https://github.com/aspnet/Security/pull/1401#issuecomment-372072396
https://github.com/aspnet/Security/pull/1691
Developers can already do this the long way by hooking into the RedirectToIdentityProvider event and customizing the protocol message. For well known properties consider allowing developers to specify them in the AuthProperties from Challenge provide a built in mapping.

@Tratcher I'm putting this on your plate to track the PR.

Are we taking the PR?  @Tratcher you seem to have approved it, will you be taking it in, or should this be reassigned?

I approved the initial version but then it snowballed. There's ongoing debate over an expanded design.

We discussed at standup this morning. I think we either get it into Preview2 or it has to wait until 2.2.


Orchard documentation: infinite redirect

trying to access to
http://docs.orchardproject.net/Documentation/Alternates we obtain an ERR_TOO_MANY_REDIRECTS error

Add /en/latest before the path in the meantime. Must be an issue with readthedocs as on Google it's indexed correctly without this prefix.


[Feature Request] Add Convolution Backward Op

Request description
Hi guys,  I'm from ByteDance AML team.
HLO doesn't have op like mhlo.convolution_backward_data or mhlo.convolution_backward_filter, since that HLO lowering backward op to something like reverse + transpose + convolution_forward or convolution_forward + transpose.
But sometimes we want to do convolution data format transformation (like NCHW => NHWC, BTW, NCHW format get from torch_xla/torch-mlir). So it's hard for me to do data format transformation when there isn't a singleton operation.
Because of the above reasons, I wonder if it is possible to add convolution backward op?

Hi @qingyunqu! Apologies that it's taken quite a bit of time to get back to you - in my reply, I wanted to reference the RFC process and iterating on details took some time.
Overall, this is a very reasonable feature request. Many related opsets have an op like that; here are some examples of these ops, in alphabetical order of the opset name:

MIL has conv_transpose.
ONNX has ConvTranspose.
TFLite has transpose_conv.
TOSA has transpose_conv2d.

For historical context, the philosophy behind HLO has been focused on providing a minimal opset paired with a client API of higher-level abstractions that decompose to the minimal opset. MHLO has inherited this philosophy with the MHLO/CHLO split, although about a dozen of MHLO ops are currently misplaced and would be a better fit for CHLO (see #3 for some additional details). This is the context behind the current state of StableHLO, and one of the key pieces of related work as we're working out the StableHLO philosophy.
To evaluate the possibility of having transpose_conv in the StableHLO opset, I think we need the following:

Survey of related work (mostly done above, we could also throw in an analysis of how JAX, PyTorch and TF model this).
Design for how the potential transpose_conv op would look like (would it be a fork of convolution in all its glory? or a simplified version thereof?).
Analysis of pros and cons of having vs not having this op in StableHLO (I imagine this would boil down to how hard it would be to do pattern matching on the consumer side).
Recommendation (include in StableHLO, include in CHLO, don't include).

At the moment, the main focus of the StableHLO team at Google is on finishing the StableHLO v1.0 specification. We have made significant progress with speccing the existing statically-shaped HLO semantics, with the goal of providing a well-understood baseline for future evolution. There's still much spec work to do, so I don't expect that we'll have the throughput to look into transpose_conv in Q4.
That said, anyone in the community can contribute to StableHLO! At today's OpenXLA meeting, @theadactyl shared that we're working on formalizing the OpenXLA governance process and invited everyone to contribute RFCs even if these RFCs would be more or less informal at the moment.
If transpose_conv is something that you feel strongly about and have some cycles for, do consider writing an RFC about this. We currently don't have an RFC template, but something along the lines of what's mentioned above would work. Same for the discussion / decision-making process - we don't have a process for that yet beyond the very high-level governance.md, but we can play it by ear.


Bot doesn't appear online but everything is complete. No errors.

is your token correct? If so, can you post your bot.js here?

Is your token correct? If so, can you post your bot.js here?

This was on June 13th I no longer need help ty to <3


Standardisation of Tests

Currently there is no clear structure or definition of how tests should be built. This should be standardised.
For example, in the case of the Interface object there are multiple tests per each method whereas in others there are only one. One possible solution is to have one single test function per each method that tests out all possible combinations.
The naming of functions is also not clear. We should give test cases (e.g. in ages mutlisystem pytest.fixture system1 and system2 should be used) and test functions more descriptive names and even a docstring explaining what is being tested.
Another issue of standardisation is how documents are saved/removed during testing. In different parts we are using different ways of building and removing them. The current methodology sometimes causes the files to remain if the test fails.
In order to improve standardisation all strings referenced in ui.py and others should be saved in messages.py so that in testing this can be compared and so when a string is changed we don't have to change the string twice, once in the function and once in the test.
Moreover, there are many warnings that are thrown when running the tests. This should either be silenced or be dealt with in the tests.
Requirements to close the issue:

Clear documentation of how tests should be built
Tests follow all the guidelines set out in documentation

For example now in the UI when we are testing it we create a dummy interface but the directory it is intialized to is the same working directory in some cases and others is a generated directory. This shoul allso be unified. Research should be done in which type of way is better.


Bug fix: Handling of alpha pixels when committing selection

When you finish a selection with pixels that aren't fully-opaque (whether due to layer opacity or the pixels' alpha channel), those pixels are blended with the target layer according to the opacity, but this is not the proper semantic for a selection. If you create a selection and then use Move Selection tool to relocate it, within that layer, the pixels' opacity should simply be translated along with the colour. This PR fixes selection moves so that when the selection is "dropped" onto the underlying layer, it simply replaces all of the pixels involved. It implements this by still blending the pixels the way it did before, but by clearing the underlying pixels so that there's nothing there for them to blend with. The new blend method ignores the layer opacity as well.
There is a separate bug in how the selection layer is previewed. Prior to finishing the selection, it will appear incorrectly blended with the underlying pixels. That is outside of the scope of this PR.
Before moving selection:

After moving selection, before finish selection:

After finishing selection:

This PR partially fixes #819.

retest this please

Spurious build failure for build-macos, looks like.

Rebased.

Looks good, thank you!


Which Android version is needed?

I've got this working fine under iOS with deployment-target,  wondering what the android-minSdkVersion is?

I have it working as far back as API 15 (4.0.1).


ranger error about devicons

when i start ranger in nvim i dont see icons next to folder and files.
on top i see a error loading...rangerInvalid linemode: devicons; should be filename/metatitle/permissions/fileinfo/mti

https://github.com/alexanderjeurissen/ranger_devicons

yes, is fixed it :D


Allow running deploy without extensions

WHY are these changes introduced?
Fixes https://github.com/Shopify/app-deploys/issues/349
WHAT is this pull request doing?
Following up the work done here we want to enable deployments without extensions if you have the beta flag.
How to test your changes?

Enable the appUiDeployments beta flag
Try deploying in an app with no extensions
It should work
It shouldn't work if you don't have the beta flag

I'm actually going to wait before merging this PR as we do a check on organization.app.appUiDeployments, but the new check is going to be on the app itself so we don't need to move the if down after ensureDeployContext.


hyprland/backend: drop unnecessary getaddrinfo call

Hyprland hasn't been using TCP sockets for IPC since the first release, so this getaddrinfo call and its result was never needed.
Additionally, it leaks the aiRes, causing test failure under ASan.
Not tested on a real Hyprland, but see https://github.com/hyprwm/Hyprland/commit/39a9980fb116108807ee68def27a6348184f282c.
CC: @khaneliman

Sorry, didn't see this right away. Will verify later tonight in Hyprland.


Undoing renaming a class sometimes makes that class impossible to re-open

Reproduction:

me/coley/Options ->me/coley/Options2
*undo*

And now the class in the file tree me/coley/Options won't open. No exceptions seem to be thrown.

Important note: This only applies to a few classes, one such class being Options. Doing to same to Main does not trigger this.

The back-end updates in BMF seem to have fixed this. Will reopen if this comes back.


fix reference to interview-created

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.92%. Comparing base (1763b0b) to head (ff8c32e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #64   +/-   ##
=========================================
  Coverage     82.92%   82.92%
  Complexity      433      433
=========================================
  Files           106      106
  Lines          1622     1622
  Branches         48       48
=========================================
  Hits           1345     1345
  Misses          257      257
  Partials         20       20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add -Xdump option permanently to Mauve tests

Related to https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/352#issuecomment-647733647
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

Test: Test_grinder/job/Grinder/8547/console

<EMAIL_ADDRESS>- please review.

Will assume you check to ensure no impl is broken by this change (isn't this test used for testing both j9 and hs?

Good catch! I'll have to add the option in a separate target to be run for hotspot.

Related : https://github.com/AdoptOpenJDK/openjdk-tests/pull/1839

Final test : Internal-Grinder/8552


operator mariadb-operator (0.6.7)

Add operator mariadb-operator (0.6.7) to community operators

/merge possible

/merge possible


doc/Add breadcrumb info and make general edits

@Andy-Grigg
I'm sure my poor attempt to add breadcrumb information needs your attention!


upgrade to intellij 15.0.2

Thank you for the contribution. It was merged directly as<PHONE_NUMBER>59a7e71f4a9abd264ec28173a8fdf5 to keep commit history cleaner. Your contribution is still credited to you.


make sure random seeding is consistent

in particular we need to make sure random seeding works properly especially for multiprocessing simulations.

Python uses the Mersenne Twister as the core generator. This will give a reproducible sequence given a seed, but it is not sufficient for this purpose for 2 reasons:

We need to expose the setting of a seed more clearly for simulations, including possibly passing them on to other processes (not a single seed for all such processes, but the ability to specify them separately).

Users may wish to plug in totally different random generation, such as low discrepancy sequences.

Note that right now all our randomness for simulation is coming from numpy.
Agree with 1.
For 2 we should likely add something that does the right delegation to numpy in cirq.  That way we are explicit about this.

Since we deleted the multiprocessing simulator, this now just depends on the numpy random seed.  We should add this to documentation, and then close.

Or better yet allow it to be set in the simulator.