Source code of the Project Factory Skyline

Hi everyone,
I just upload my source code of this mod. You can download it at: https://github.com/cepheidqq/FactorySkyline/blob/main/FactorySkylineSourceCode.zip
I know it does not work in the lastest version of the Satisfactory. But I think it will be helpful to other modders. It uses some hack methods to call the API of the FactoryGame Library, and the .h files in /FactoryGame are also be modified by this mod. Well, it does not mean this mod hacked the game, it just hacks the compiler. I'm not sure it also works in the lastest version of the game, this is why I can't maintain a branch of this project at github, but I can show you all my source code.
I love this game, it gives me lots of fun, and I love this mod too, I didn't make it to be a business project. But I found that I cannot used the discord due to the great firewall, and the community almost completly works on it. It was a heavy blow to me, and sometimes I even can not open the github. I hope it can be changed in a few years.
I'm still a player of the Satisfactory Game. Hopes everybody have a good time:)

Hi, thanks for providing the source code and thanks for the mod, it was super useful and i really miss it. But nobody is entitled to use something that others created in their free time and maybe someone can build on your code (unfortunately i'm a java/kotlin guy and getting back into C++ seems exhausting)

Hi @cepheidqq !
First off thanks for making your mod open-source and hopefully with some effort from the community a chance for it to live again!
Ive decided to try to make this happen by drumming up some noise and hopefully drafting some of the community to make this happen. ive forked this repo and set up a discord server to allow people to come together to talk about the feasibility of this (links in the forked repo).
I was wondering if i could have your written permission to try to continue the project on in its current name in this community and open-sourced spirit?
a few members from the community would like you to give the go-ahead for this to happen. personally, I would like to continue it on as under the same title as an hommage to the hard work you have put in to get it to this pont but that is up to you ofcourse.
we would also love it if you would like to be apart of this in any way you like, even if thats taking a back seat and just calling in to chat when you can. any contribution from yourself would be awesome :)
kind regards, The1

Hello,
I have successfully patched your code for working with update 4 of the game @cepheidqq . I'm ready to upload/publish, but I need a license file to work with. Your mod is awesome. I do not intend to maintain the mod, but I have made the initial upgrade work.
Either I can upload it to @The1NdNly's rep, or I can upload it here. But I need permissions for either. If you have issues accessing github, it might be easier with @The1NdNly's rep. But its your call.

Hi, i would ask if there's some progress on the Work and if Yes, are there any progress on the task with @cepheidqq in licensing. Or if there's any other way i would like to hear from you. Thanks in advance for all your work

Hello, I have successfully patched your code for working with update 4 of the game @cepheidqq . I'm ready to upload/publish, but I need a license file to work with. Or at least a written consent to republish the mod. Of course, leaving credit to you. Github has a function for generating a licence file. Your mod is awesome. I do not intend to maintain the mod, but I have made the initial upgrade work. Either I can upload it to @The1NdNly's rep, or I can upload it here. But I need permissions for either. If you have issues accessing github, it might be easier with @The1NdNly's rep. But its your call.
I am working together with @The1NdNly

@RozeDoyanawa
Judging from this reply, the author seem to be okay with re-publishing the mod with a GPL or MIT license.
Is there any further difficulties in publishing it?


Initial set of files for //test

Currently there are no tests, but this will enable finishing setup Prow.

/lgtm

/approve

i tried... :D

/lgtm

/lgtm
/approve


Date difference columns adding an additional one hour in enhanced data table

Hi I am having two columns, with login time and logout time,
i have used computed column in enhanced tabel to find the difference ,
The column is adding one hour day light saving time after difference in HH:mm:ss format,
if i give the format as DD MM YYYY it is adding 1970 january 1st if the difference is in only hours and minutes.
Any additional configuration to be added to get an correct out put.

If you want to compute difference and display the difference, I invite you to set :

Formula: (col2 - col1) / 1000 / 60 (to get the duration in minutes
Format: Number
Apply Template: checked
Template: {{value}} minutes

Don't use "Date" format to display a duration.


[BugFix] fix .net can not read sr (backport #51946)

Why I'm doing:
cp from https://github.com/StarRocks/starrocks/pull/51946
What I'm doing:
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[x] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
[ ] I have added documentation for my new feature or new function
[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

@Mergify backport branch-3.1

@Mergify backport branch-3.0


:GoInstallBinary with cmp-cmdline

Error executing vim.schedule lua callback: Vim:E5108: Error executing Lua function: ~/.local/share/nvim/lazy/go.nvim/lua/go/complete.lua:22: bad argument #1 to 'sort' (table expected, got nil)
stack traceback:
        [C]: in function 'sort'
        ~/.local/share/nvim/lazy/go.nvim/lua/go/complete.lua:22: in function < ~/.local/share/nvim/lazy/go.nvim/lua/go/complete.lua:20>
        [C]: in function 'getcompletion'
        ~/.local/share/nvim/lazy/cmp-cmdline/lua/cmp_cmdline/init.lua:124: in function 'exec'
        ~/.local/share/nvim/lazy/cmp-cmdline/lua/cmp_cmdline/init.lua:175: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/source.lua:325: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:289: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:169: in function 'autoindent'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:161: in function 'on_change'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/init.lua:313: in function 'callback'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:138: in function < ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:136>
stack traceback:
        [C]: in function 'getcompletion'
        ~/.local/share/nvim/lazy/cmp-cmdline/lua/cmp_cmdline/init.lua:124: in function 'exec'
        ~/.local/share/nvim/lazy/cmp-cmdline/lua/cmp_cmdline/init.lua:175: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/source.lua:325: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:289: in function 'complete'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:169: in function 'autoindent'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:161: in function 'on_change'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/init.lua:313: in function 'callback'
        ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:138: in function < ~/.local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/async.lua:136>

when invoking :GoInstallBinary <space> gives the following error

Should been fixed. Thanks for reporting


Random::ISAAC pseudo random number generator

As suggested by @scidom in #329 here comes a Crystal implementation of the ISAAC generator.
I implemented the readable algorithm, since the fast C implementation uses lots of pointers, that don't make much sense in Crystal (I think). I'm not sure how much safer, or less biased, it is compared to MT19937. It's current performance is ~36% slower than MT19937: 0.072s vs 0.046s for 10 million numbers.
Notes:

This patch changes the signature of Random.new/1 which now expects an engine class instead of a seed.
I removed the srand methods that were broken —they called the missing Random#init_by_array method, which could be made to point to the engine's method (private for now). I'm not sure if they are required.

I'm wondering about Random.new_seed: shouldn't we use SecureRandom.random_bytes instead of Intrinsics.read_cycle_counter to seed the generators?

How about adding another overload def initialize(seed : Int, engine_class=Mt19937)?

Wow! You are amazing!
Seriously! One day @scidom suggests we add an ISAAC generator, the other day you send a pull request! I really can't tell you how much I appreciate your (all of you) contribution.
The speed is OK for now, we can always optimize it later, specially because we have those accurate specs.
I'm thinking, maybe instead of having Random have an engine, why not make Random a module that can be included in a random generator implementation? What I don't like about the @engine variable is:

There's an indirection, so generating numbers through Random will be a bit slower than just using the engine (unless we turn Random into a struct)
If you create many Random instances with different engines, @engine will become a union type and then each call to it will result in a dispatch (unless we make Random be generic, Random(E), where E is the engine type).

But those "unless" solutions seem too complex. Instead, we can do this:
# Include this into your random engine. You only need to implement next_int
module Random
  def next_float
    next_int * (1.0/4294967295.0)
  end

  def next_int(max : Int)
      if x > 0
        next_int % x
      else
        raise ArgumentError.new "incorrect rand value: #{x}"
      end
  end

  # and so on...
end

Java almost does this: it has a Random class which by default uses this algorithm, and subclasses must override a next(int bits) method to provide other algorithms. Then there's, for example SecureRandom, which inherits Random.
We could do the same as Java, but I think it's cleaner if we use a module so that each Random implementation has its own internal state. Then we can make SecureRandom include Random to share some implementation, as suggested by @rhysd.
Then we can have a Random::DEFAULT constant that has an instance of Random::MT19937 (or whatever engine we consider good as a default), and have Random#rand and the top-level rand delegate to this default engine, maybe guarded by a mutex so all of these are thread-safe by default. We can also have Random::new just create an instance of a default implementation we choose:
puts Random.new #=> #<Random::MT19937:0x106503000>

I don't think it matters much that Random.new doesn't return an instance of a class named Random as long as it quacks like a random engine.
What do you think?
Oh, @ysbaddaden, also thanks for moving the engines to their particular source files, I was going to do that but you were faster! :-)
I'll accept your pull request, which is perfect, and then we can do those changes later.

Oh, I didn't expect the pull request to be merged so quickly!
I like your Random module suggestion @asterite. I'll do the changes. Better design, better performance, less indirections: that's a win!

Great to see that you implemented the Isaac @ysbaddaden. A few general remarks in relation to the above thread:

Perhaps RNG is a more suitable name rather than the less descriptive Random for the base class or module. All these random devices are random number generators (RNG), which is a much more concrete concept than Random. Besides, the abbreviation RNG is an established one.

We shouldn't be thinking about unions of random devices. By that I mean that there must be only one random number generator at a time regulating the generation of random numbers. It is simply conceptually wrong to allow coexisting RNGs and we should avoid it by all means.

A Random module or class may encapsulate behaviour that is more generic and independent of RNG, thus being used by any RNG. For example, the initialization of the seed, which may entail a couple of different methods could be used by any RNG. According to my mindset, this dictates structuring the code by distinguishing between Random and RNG, the latter being a subset and possibly a member of the former, but this is only one way of organizing the problem.


Remove unused dependency jest-mock-process

Another one. Removes jest-mock-process which seems to be unused.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
230

Relevant Lines:
230

💛  - Coveralls


Generate by weights / deprecate npm Name-gen

The name generation is not done by weights. This means that 'optionals' aren't optional at all. This is due to the sideloaded app that requires active running not supporting this function.
The persona generator already is formatted for these weights, but did not generate its own due to not being able to access the file system.

This ticket shares a lot of similarity with issue https://github.com/eosfrontier/PersonaGenerator/issues/8
Fixing one should also fix the other by the nature and root cause of these issues.


Repeater field  - "sortable: false" not working

Winter CMS Build
1.1
PHP Version
7.4
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
I would like to be able to block the reordering of the repeater field, despite having set the sortable key to false the items keeps showing the reorder icon and move around if grabbed.
Yaml below:
opening_hours:
    commentAbove: 'archisol.mi::lang.restaurants.form.comments.opening_hours'
    context:
        - update
    label: 'archisol.mi::lang.restaurants.form.labels.opening_hours'
    span: left
    type: repeater
    sortable: false
    tab: 'archisol.mi::lang.restaurants.form.tabs.opening_hours'
    form:
        fields:
            day:
                comment: 'archisol.pages::lang.pages.form.links_form.label_comment'
                label: 'archisol.pages::lang.pages.form.links_form.label'
                placeholder: 'archisol.pages::lang.pages.form.links_form.label_placeholder'
                span: full
                type: text

Steps to replicate
Create e repeater field and set sortable: false
Workaround
No response

Thank you @LukeTowers !

Thanks to @Flynsarmy, he's the one that implemented it :)


docs: Adapt link targets for posts in admin ui

This fix addresses the tutorial docs for the blog example and the respective example sources. The links in the Admin UI for the existing posts are broken. This adaption adds /posts/ as prefix to the slug so that the links lead to the correct documents.

Closes #644


improve isPartiallyValid

A number can't be partially valid if it's already the full length and it's not valid.
With the old implementation you could type 16 invalid Visa digits and isPartiallyValid would return true even though it's impossible for the number to become valid with the addition of more digits.
P.S. Hi @jflinter

I took a look at PTKCardExpiry and PTKCardCVC and in both of those isPartiallyValid returns true (not false) when it's completely valid. So I've amended this to have the same property.

Whoa, hey there @jmanian!
This seems good to me - worth mentioning that I'm currently in the process of rewriting this library (see #88) and that will probably/hopefully render these changes kind of a moot point, but no harm in merging this now.


A couple of suggestions:

Maybe use \s* instead of \s? to detect multiple spaces
Match at as well  as @ (case insensitive)
Match dot as well as . (case insensitive)
Match `@` and other formatting methods

Would this capture this, which I just observed on a spam message?  "antonio.iosdevmate" &Gmail

I have tried to implement @JF's suggestions, and came up with the following:
(?<![=#\/])\b[A-z0-9_.%+-]+\W*(@|[aA][tT])\W*(?!(example|domain|site|foo|\dx)\W*(\.|[dD][oO][tT])\W*[A-z]{2,4})[A-z0-9_.%+-]+\W*(\.|[dD][oO][tT])\W*[A-z]{2,4}\b
Regex 101
I'm hesitant to implement the example of Thomas; it looks too much like
valid code to me, for instance:
if (name == "first.last" & gmailEnabled) {
I also noticed the three regexes are slightly different. I think it makes
sense to have one global EMAIL_REGEX constant, which can be modified
before calling regex.compile, but I'd rather leave that to somebody who
is proficient in Python.
On 2 March 2017 at 06:19, Thomas Ward<EMAIL_ADDRESS>wrote:

Would this capture this, which I just observed on a spam message? "antonio.iosdevmate"
&Gmail
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Charcoal-SE/SmokeDetector/pull/564#issuecomment-283559182,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXeJRk5x1DpcIAInt4YNxdwCysZxihPyks5rhlFVgaJpZM4MQJPR
.

I'd like to see some data before we merge this. Is anyone experienced enough with the SEDE to get some?

I think I am, but SEDE is too slow and doesn't support regexes, just the general SQL LIKE syntax.

SEDE is too slow and doesn't support regexes

We can work around that by unconditionally SELECTing as many Posts as possible, downloading the resulting dataset, and then running regexes over it.

That... would break SEDE.

@ArtOfCode I mean, we can SELECT * FROM Posts, download the results as a .csv file, and test the regexes on that .csv file. That wouldn't break SEDE as it makes no online interaction other than a mere SELECTion.

I've done it before, you can get any table 50k at a time from SEDE (or just
download the data dump).
On Mon, Mar 13, 2017 at 7:24 AM dorukayhan<EMAIL_ADDRESS>wrote:

@ArtOfCode https://github.com/ArtOfCode I mean, we can SELECT * FROM
Posts, download the results as a .csv file, and test the regexes on that
.csv file. That wouldn't break SEDE as it makes no online interaction other
than a mere SELECTion.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Charcoal-SE/SmokeDetector/pull/564#issuecomment-286105536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKjSMyiQoL7sAkKt1VqkoCtmaLSx22biks5rlUOTgaJpZM4MQJPR
.

@dorukayhan: that would be @ArtOfCode- , not me ;-)

o/ namesake :)
But yeah, @dorukayhan SEDE really doesn't like large numbers of records. You're likely to have trouble getting lots of posts from it.


'View Release Notes' links to deprecated rollbar-android library

This links to the old Android library: https://github.com/rollbar/rollbar-android
Not sure where to post bugs for the main site, so I'm doing it here.

This is a bug in the Rollbar app, so I'm going to close this issue and create one in our internal tracker.


Support multi-cluster setup within a single VPC

This is a feature request to support multi-cluster setup within a single VPC.
Currently, the controller supports multi-cluster servince networks when the clusters are running in different VPCs, but when customers are running a multi-cluster setup in a single VPC there can be unexpected behaviour from the controller. Due to customer internal architecture and processes they are unable to move a multi-VPC setup.
See the related ticket where customer had this issue:
https://github.com/aws/aws-application-networking-k8s/issues/252

#392 #393


Message Is Mostly? Useless

The public api Message type doesn't do much and could be replaced with impl Future<Output = ()> + Send + Sync + Unpin

https://github.com/ardaku/whisk/commit/9bedad21fc2923b0efe10ecf15b2dfcdcc5d9941 resolves this


Support for leading and trailing underscores

First, I appreciate for your wonderful work.
As you see  in the following example, having an underscore as prefix and suffix for DI is very handful when you organize your Javascript, and it is perfectly legal in AngularJS.
I leared it from here, https://docs.angularjs.org/tutorial/step_05

// The injector ignores leading and trailing underscores here (i.e. $httpBackend).
// This allows us to inject a service but then attach it to a variable
// with the same name as the service in order to avoid a name conflict.

However, it ng-annotate does not seem work with this syntax, _$scope_, _MyService_, etc.
http://plnkr.co/edit/2vZGxggEcJJ7k4tSBpWa?p=preview
<!DOCTYPE html>

Hello {{name}}!

Hi Allen,
While, due to code re-use, this does work in actual applications - it isn't documented, nor should it be needed, outside of unit test use (the example you provided is for tests.
See #71 and #120.

I want to provide some use case.
The following directive requires some custom function to use $http.
However it's hard to organize this code because $http is only available in directive function only;
(function(){
  'use strict';

  var myDirective = function($http) {
    return {
      restrice: 'A',
      require: '?ngModel'
      link: function(scope, element, attrs) {
        var someArray = attrs.foo;
        // need to make a function to isolate some code with $http
        var someVeryLongCustomFunction = function(array) {
          for (var i=0; i<array.length; i++) {
            $http(array[i]).success(function() {
              // ...
            })
            // ...
            // long
            // ...
            // ...
            // ...
          }
        };
        someVeryLongCustomFunction(someArray);
     }
  });

  angular.module('myApp').directive('myDirective', myDirective)
})();

By simply making $http available, the code can get better organized.
I personally think the following coding style is a log better the upper one.
(function(){
  'use strict';
  var $http;

  var someVeryLongCustomFunction = function(array) {
    for (var i=0; i<array.length; i++) {
      $http(array[i]).success(function() {
        // ...
      })
      // ...
      // long
      // ...
      // ...
      // ...
    }
  };

  var linkFunc = function(scope, element, attrs) {
    var someArray = attrs.foo;
    someVeryLongCustomFunction(someArray);
  };

  var myDirective = function(_$http_) {
    $http = _$http_;
    return {
      restrice: 'A',
      require: '?ngModel'
      link: linkFunc
    }
  };

  angular.module('myApp').directive('myDirective', myDirective)
})();

It's been quickly closed, and I respect your decision not to open the debate again.
However, I highly recommend to make underscored arguments injectable for best code practices and better styling.

While non-nested functions might be a best practice, assigning an injected variable outside of it's injected context most certainly is not.
I highly suspect what you actually want in this case is a service.

A service are collection of sharable code. We do not put make it as a service just to organize code. All injected services are singleton, and there is no harm to access outside of of it outside of injected context.


Figure out how we can minify and still be able to debug merchant sites

Especially on older browsers where source maps are a no go -- which coincidentally, are the browsers with all of the issues.
(more details in my reply to @slightlyoff below)

@slightlyoff,
Hope you don't mind me responding here -- saw your tweets and wanted to respond properly, but I can never really say anything meaningful in 140 chars, so wanted to get in touch this way instead. Appreciate your comments.
To give you some background: checkout.js has been around for 2-3 years now, and has accumulated a lot of code, and a lot of technical debt. My team and I came in 3-4 months ago to take it over and overhaul it, and we're in the middle of that process right now.
The open source modules we've released so far -- xcomponent, post-robot, beaver-logger -- all represent our efforts to split out the reusable/non-paypal parts of checkout.js into small, open source modules, which we're trying to keep as lean as possible. The next step for us is to figure out how we can slim down the paypal specific parts of checkout.js

Firstly, on the file size. We definitely know it's a problem, and we have a plan to reduce it:

There's a lot of legacy code that we need to factor out.
There's also a lot of static content that we need to split out and lazy-load.
xcomponent alone is 130kb / 32kb gzipped, which is at least manageable for anyone hoping to build similar components.
Our larger / more advanced merchants we expect to pull the script from github or npm, and use the published minified versions.

There are challenges though:

Smaller merchants have the most frequent integration issues, especially on older browsers without source-map support. We get a huge number of support requests from these merchants, on an almost daily basis.
We have those guys using checkout.js by default, because being able to debug unminified code with proper stack-traces etc. is often the only way we can support these merchants.
Our end-game is to have the checkout.js url minified by default, and be able to switch off minification on a per-merchant or per-cookie basis so we can debug. This is a work in progress, and we're having to work with our CDN provider to get there.

So, just so you know we didn't forget to minify the script. :) It's a trade-off between speeding up our merchants' sites, and being able to support them, and it's a problem we're actively working on fixing.

On the web component thing: sorry for being misleading here. You're right, xcomponent doesn't use web components (yet), mainly because of the lack of browser support.
The way xcomponent works is to let you set up a spec for the component, then it auto-generates bindings for you in popular frameworks like React, Angular, etc. so people can drop-in the components you write. The plan is to create bindings for web-components too. So we're set up to be able to support these, it's just not the biggest priority at the moment.
I've edited the title of the article to just read "components" rather than "web components". I was really just going for "cross domain components for the web" rather than specifically "cross domain web-components".

Sorry for the lengthy response, happy to take any advice you have on any of the above!
Best,
Daniel

Heya,
Thanks for taking the time! Happy to engage anywhere that makes sense for y'all = )
First, happy to hear that you've got size reductions planned and good to know that you're working to get the minified sources to more users. That'll have a huge impact.
I have some questions!

What's the browser support matrix for checkout.js?
Is that matrix any different for mobile vs. desktop?
How tightly do you control the the CDN infrastructure that served checkout.js? Can you serve different versions to different UAs?
I noticed that a meaningful % of the total byte count is translations. Any chance those can be lazy-loaded or included based on headers and not baked into the default binary?
Related to the browser support question (and contingent on it), have you looked at using raw Web Components for your component model and polyfilling where that's not possible? Might get you some nice savings and a clean way to integrate with embedders.
Do you have a size/perf budget for the project?

Thanks again for engaging and apologies for the tone of my tweets.
Regards

Hey,

What's the browser support matrix for checkout.js?

        Chrome: 27,
        IE: 9,
        MSIE: 9,
        Firefox: 30,
        Safari: 5.1,
        Opera: 23

Is that matrix any different for mobile vs. desktop?

Right now for mobile, checkout.js doesn't do much other than a full-page redirect to PayPal. That's changing though; we're about to start ramping up mobile users, so we'll be defining that matrix soon.

How tightly do you control the the CDN infrastructure that served checkout.js? Can you serve different versions to different UAs?

In theory yes, in practice the infrastructure is a little inflexible, and it takes time to get things pushed through. Depending on what the estimate is for this, I may just enable minification / source maps in the mean time.

I noticed that a meaningful % of the total byte count is translations. Any chance those can be lazy-loaded or included based on headers and not baked into the default binary?

Yep. Those are some of the static resources mentioned above.  This is being tracked here: https://github.com/paypal/paypal-checkout/issues/90

Related to the browser support question (and contingent on it), have you looked at using raw Web Components for your component model and polyfilling where that's not possible? Might get you some nice savings and a clean way to integrate with embedders.

The problem is, we support three different flavours of component:

Inline iframes
"Lightbox" style iframes, which are fixed position and outside of the normal document flow
Popup windows, which are visually similar to #2 but obviously totally outside the DOM.

Web components (along with those React/Angular bindings I mentioned) only really make sense as a means of using #1. That's why we were thinking about adding them as another driver for #1, alongside the React/Angular bindings.
Also -- and I might be betraying my lack of knowledge about web components here -- do they provide any way to pass down data types like functions, objects etc? Callbacks are an important feature of xcomponent's props.

Do you have a size/perf budget for the project?

Nothing formalized. The plan is just to make it as streamlined as possible, given the myriad of features we have to support.
Thanks!
Daniel

Any news with this?

@bluepnume as you said here https://github.com/paypal/paypal-checkout/issues/443

There's a minified version at https://www.paypalobjects.com/api/checkout.min.js which clocks in at 98kb.

Now it's 893KB and non-minified version (that we supposed to use if we want benefit from cashing) is 1.5MB! I am sorry but this size is just ridiculous, it's bigger than my entire SPA with Angular 5, RxJs, and bunch of other dependencies. And our users need to download all this code just to render the button which they may never ever click.
Can I somehow render the PayPal button by myself so all the heavy downloading starts only when user clicks it? This way it won't affect all our users at least.

Is there any movement on this?  We committed to vue-paypal-checkout months ago.  Because the vendor bundle that incorporates paypal-checkout is 1.5 megs of javascript, we are getting severely punished by google speed test.
When I remove paypal-checkout from our build, the bundle size goes below 300k.
Without an alternative solution, we are considering completely removing support for paypal from our store.
As @albv pointed out, the "minified" version is huge (just downloaded today, it's 962K).
I'm all ears for better ideas...

Elon Musk is busy with submarine.

@ryanrca I think for now your best option is to load checkout.js asynchronously when user somehow selects PayPal as a payment method. Something like this https://github.com/paypal/paypal-checkout/blob/master/docs/performance.md#delayed-render should work but maybe you will have to drop vue-paypal-checkout wrapper


Rewrite documentation using correct module names

Remove traits section now that we have embedded-hal-async and refer to
it.
Explanation that embassy is multiple things.
Bootloader description image

bors r+


Add "Video/Audio Encoding" sections to docs

In response to #386.

Codecov Report

Merging #387 (cd7703d) into master (d40d184) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   77.77%   77.77%
=======================================
  Files          26       26
  Lines        3730     3730
=======================================
  Hits         2901     2901
  Misses        829      829

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40d184...cd7703d. Read the comment docs.


Thank you for themer

Not an issue, but wanted to send some appreciation for all your great work on themer.  It has made my software development and computer usage extremely delightful.  So much so, that you inspired me to whip together https://www.github.com/tomselvi/nightenv which really wouldn't have been possible without it.
Thank you!

Thanks so much for the kind words, @tomselvi ! I'm so glad themer has been fun for you to use. Thank you so much for your contributions to themer, too. I am just checking out nightenv now and it looks awesome. What a brilliant idea.


As the Designer, I want to refactor setup.hs so that I have a modular solution to bootstrapping my environment.

[x] Setup boostrap.cabal
[x] Create directory structure src/Traap
[x] Split setup.hs into Configuration.hs, DataTypes.hs, and Workflow.hs
[x] Have bootstrap.hs use Traap.Workflow.
[ ] Test
[ ] Update README

This issue has been moved to Traap/bootstrap #2.


add CDK Bootstrap for initiating providers

In order to avoid end-user to manually cdk bootstrap each account and region, add cdk bootstrap as part of creating new providers

Hey @arditti 👋
This is a great improvement and will save a lot of unintentional (and avoidable) failures!
If you run cdk bootstrap in a directory where a cdk.json file already exists, then cdk will parse the referenced app (and reports errors and warnings).  This adds some unnecessary processing time.
I think a few seconds can be shaved off of the bootstrap process if you perform it before changing directories into the .iac subdirectories.  This would also mean that the desired cdk environment is specified to the bootstrap command (e.g. cdk bootstrap aws://123412341234/eu-west-1).  Could this change be added?

Nice catch @awsjim - agree with the approche to minimize bootstrap times.
Made the relevant changes cross all providers

Thanks so much for the contribution @arditti 👏
This is a great addition for users.  Apologies for the delay.  Merging to include in the next release.


added 0/1 knapsack in Java -> Dynamic-Programming. Issue #72

🛠 Issue #72 0/1 Knapsack - Dynamic Programming approach
👨💻 Changes proposed

Added code for 0/1 Knapsack (Dynamic Programming)
Updated README.md

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

Added 0-1 Knapsack (Dynamic-Programming) in Java
recursion -> memoization -> tabulation -> space optimzation
Starting with the naive recursive solution and gradually improving time complexity with memoization, then addressing the space complexity with tabulation and finally with space optimization.
(mentioned time complexity and space complexity of each approach)

And change file name to 01_knapsack.java

And change file name to 01_knapsack.java

changing file name to "01_knapsack.java" will result in illegal class name, as class names are to match with file names in java and they can't start with a digit.
May I rename the file to "_01_knapsack.java"?


Simplify concatenation code

A number of improvements:

Use size_t for string length
Remove useless checks of pointers which are sure to be non-null
Remove len manipulation, manipulate what it's computed from only
Prefer memcpy() over strcpy() - fewer security concerns

So we have 2 times the same function?  Can you make that a non-static function instead?

@kroeckx Actually the error codes are different.

You mean DSO_F_DLFCN_MERGER vs DSO_F_DL_MERGER?  That would just be the name of the function generating the error.

@Dmitry-Me: Still waiting for a reply.


Replace wget with curl

Signed-off-by: Sayali Gaikawad<EMAIL_ADDRESS>Description
Got error while running this workflow. Instead of adding new package using what we already have on the system
line 1: wget: command not found

Replacing wget with curl
Issues Resolved
N/A
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

You will need to update the regression tests as they will fail

On it!

Hey, as a matter of practice, is there a reason this script doesn't specify the full path to binaries it calls? E.g. why curl instead of /usr/bin/curl? It seems like a best practice to use the latter.

Hey, as a matter of practice, is there a reason this script doesn't specify the full path to binaries it calls? E.g. why curl instead of /usr/bin/curl? It seems like a best practice to use the latter.

We have lots of places we call shell scripts without hard-coding a path, so maybe better to open a new issue.
Note that likely the "correct" way to do this is /usr/bin/env curl to be properly cross-platform.


Questions about the state of mysos within twitter?

hello @xujyan
Not sure what the best medium to post these questions, whether it is github issue or one of the following mailing list. let me know
<EMAIL_ADDRESS><EMAIL_ADDRESS>I have some general questions about the state of mysos/cotton within twitter. My guess is that each of the features currently available within twitter will be slowly open sourced and make generic so that different implementation can be contributed by the community. I am curious what they look like at twitter right now
I am curious about how twitter current using mysos to do failover, it seems like it is using the reparent.sh as you mentioned here that without gtid "some files need to be copied out of band by tools such as MHA", does the version running inside twitter already have integration with MHA? or is ther other mechanism that bring the bin log to new master.
Also i see that there is the concept of BackupStore, does twitter current using HDFS to backup the files? i see some sample code related to it here but not sure if it is just an idea or twitter already have one implementation of it.
Thanks again for open sourcing cotton, we look forward to more news

Hey! Sorry about the confusion as we were transitioning code/docs into the new home: https://github.com/apache/incubator-cotton
I have now updated this repo's code and README to point to the new repo. You should use<EMAIL_ADDRESS>and I have just updated the README page with the new links.
w.r.t to the failover issue, it's not solved in the codebase and at Twitter we are going to leverage 5.6 GTID for this and therefore don't have plans to make this work on pre-5.6. The currently deployed code doesn't support failover and our initial use cases don't need it. We'd be happy to accept contributions for it though.
Regarding BackupStore and more generally "gradually open sourcing more internal features", the truth is that we don't have more internal features that have yet to be open sourced. We merely have our custom implementations of BackupStore and Installer, etc. that handle our internal backup workflow and internal MySQL packages. Given how other organizations manage backups and package installation, implementations of BackupStore and Installer can be very simple and a reference implementation may not be necessary. And yes we store the backups on HDFS we pull them down by using hadoop commands directly. What's your workflow?
I have updated https://github.com/apache/incubator-cotton with details about mailing list and JIRA, etc. Please subscribe and post questions over there! Thanks for your interest!
Admittedly documentation is terribly lacking currently and we'll improve on this.


Identification of non-synonymous Variants

As Authors have mentioned that for identification of non-synonymous variants they have used ivar,
So I belive they might have used (samtools | ivar) for the identification of non synonymous variants for species of interest.
But somehow I am unable to generate output file with Amino Acid mutation, I did validated gff3 file using https://genometools.org/cgi-bin/gff3validator.cgi
How this issue can be resolved?
Also which bam file to consider from tmp file (virus_pathogen_database.mmi.*_input.fastq.sort.bam), and If i want to identify for specific species then the output which is generated for all the species that mapped against the reference database, is there a way to get the output for respective species only.

Hi,
First, I want to apologize for not answering this issue until now. I did not have the correct settings on this repo, and I wasn't getting the notifications for new issues.
For your question, you probably want to make and issue on the ivar github.
But I may be able to help a bit:
I used reads specific to my reference of interested extracted from accessions_final_threshold1.bam files in the EsViritu temp files.
Are you specifying your .gff file with the -g flag when you use the ivar variants command?


Fix duplicate points

Codecov Report
Base: 99.07% // Head: 99.08% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (6de9ba8) compared to base (8ed5a37).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   99.07%   99.08%   +0.01%
==========================================
  Files           8        8
  Lines         539      546       +7
  Branches       88       89       +1
==========================================
+ Hits          534      541       +7
  Misses          2        2
  Partials        3        3

Impacted Files
Coverage Δ

bayes_opt/bayesian_optimization.py
100.00% <100.00%> (ø)

bayes_opt/target_space.py
99.21% <100.00%> (+0.03%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


I can use crictl image sees my images, but I can't ctr images ls sees them.

my containerd version:
Client:
  Version:  1.3.7
  Revision: 8fba4e9a7d01810a393d5d25a3621dc101981175

Server:
  Version:  1.3.7
  Revision: 8fba4e9a7d01810a393d5d25a3621dc101981175
  UUID: bd6c158d-f808-4df5-b684-f2c0e83a61be

my containerd config file :
version = 2
root = "/data/containerd"
state = "/data/run/containerd"
plugin_dir = ""
disabled_plugins = []
required_plugins = []
oom_score = 0

[grpc]
  address = "/run/containerd/containerd.sock"
  tcp_address = ""
  tcp_tls_cert = ""
  tcp_tls_key = ""
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[ttrpc]
  address = ""
  uid = 0
  gid = 0

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[timeouts]
  "io.containerd.timeout.shim.cleanup" = "5s"
  "io.containerd.timeout.shim.load" = "5s"
  "io.containerd.timeout.shim.shutdown" = "3s"
  "io.containerd.timeout.task.state" = "2s"

[plugins."io.containerd.grpc.v1.cri"]
  stream_server_address = "<IP_ADDRESS>"
  stream_server_port = "10010"
  enable_selinux = false
  sandbox_image = "registry.my.io/kubernetes/pause:3.2"

[plugins."io.containerd.grpc.v1.cri".cni]
  bin_dir = "/opt/cni/bin"
  conf_dir = "/etc/cni/net.d"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
  runtime_type = "io.containerd.runc.v2"
[plugins."io.containerd.grpc.v1.cri".registry.mirrors]
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."registry.my.io"]
  endpoint = ["http://registry.my.io","http://<IP_ADDRESS>"]
[plugins."io.containerd.grpc.v1.cri".registry.configs."registry.my.io".auth]
   username = admin
   password = password

when I used crictl images , I can sees my images
[root@k8snode03 data]# crictl images
IMAGE                                                TAG                 IMAGE ID            SIZE
registry.cn-hangzhou.aliyuncs.com/denverdino/lxcfs   3.0.4               a4c6e5c590a42       75.7MB
registry.my.io/kubernetes/flannel                 v0.13.0-rc2         79dd6d6368e25       19.4MB
registry.my.io/kubernetes/kube-proxy              v1.18.2             0d40868643c69       48.8MB
registry.my.io/kubernetes/pause                   3.2                 80d28bedfe5de       298kB
[root@k8snode03 data]#

But I can't used ctr images ls sees them, and I can used ctr image export <IMAGE_NAME>.tar.gz registry.my.io/kubernetes/lxcfs:v3.0.4
[root@k8snode03 data]# ctr images ls
REF TYPE DIGEST SIZE PLATFORMS LABELS
[root@k8snode03 data]#

CRI containers are in the k8s.io namespace, so ctr -n k8s.io has to be used.


Properly handle sequence and read group metadata from BWA

We write out empty dictionaries:
scala> println(sc.loadAlignments("LP6005441-DNA_A01.bwa.adam").recordGroups)
RecordGroupDictionary()

scala> println(sc.loadAlignments("LP6005441-DNA_A01.bwa.adam").sequences)
SequenceDictionary{}

I see what #11 is doing but I don't fully understand the issue. Shouldn't LP6005441-DNA_A01.bwa.adam contain a sequence dictionary on disk within the Parquet folder?

We copy the sequence dictionary from the unaligned reads, hence, the output sequence dictionary is empty.

Ah right, we're starting from FASTQ.  The user would have to build the .dict from the bwa indices or from the FASTA reference first, I suppose.


Parallelizes report command executions when test fails.

Signed-off-by: Weilong Cui<EMAIL_ADDRESS>Fixes: #11976

Coverage increased (+0.009%) to 37.043% when pulling b6c145e0df935c759469de92866d6a419bec50c8 on Weil0ng:timeout into 6d3e72157f5f9cbe37e3f8fc8f0752200606e3c0 on cilium:master.

Please take another look :) Thanks!

test-me-please

I've updated #12576 to test the new fix.

test-me-please

Marking for backports in 1.7 and 1.8 because I've noticed the same issue in 1.7 and it looks like it should be trivial (i.e., no conflicts).


re-dowload a blog

I was trying to find here but failed: how can I "urge" a re-download of a blog I already downloaded before? "urge rescan" doesn't help.
The blogname seems to be saved somewhere, where to reset this?

Your initial situation is not totally clear. "Force rescan" is rescanning/downloading the meta data and checks if something has been missed (due to timeouts etc.) before, but doesn't unnecessarily download again the files.
If you mean, you "lost" your blog folder, you have to get rid of the entries in blog_files.tumblr, either by editing it manually or maybe better:

remove the blog from the list
delete/remove the two blog files from the Archive folder
add the blog again to the list and download again

thanks!


Remove workaround for compiler dill-initialization.

Workaround is not needed since real fix has landed in dart sdk: https://dart-review.googlesource.com/c/sdk/+/62729.

@a-siva , PTAL

The test failure shows up as broken assertion when run against vm with enabled assertions:
[   +1 ms] Evicting dirty assets
[   +1 ms] ext.flutter.evict: {value: AssetManifest.json, isolateId: isolates/9702818}
[   +3 ms] Compiling function : 'dart:developer_::__runExtension@4383715' @ token 2134, size 1886
[        ] Compiling Class 'Library:'dart:developer' Class: ServiceExtensionResponse'
[   +1 ms] --> 'dart:developer_::__runExtension@4383715' entry: 0x7fb1d52f2a60 size: 2472 time: 2815 us
[        ] Compiling function : 'package:flutter/src/foundation/binding.dart_BindingBase_registerServiceExtension_<anonymous closure>' @ token 13818, size 2154
[        ] ../../third_party/dart/runtime/vm/kernel_binary.h: 183: error: expected: (size_ >= 4) && (offset >= 0) && (offset <= size_ - 4)
[        ] Dumping native stack trace for thread 309ed
[   +7 ms]   [0x000000000249fe1f] Unknown symbol
[   +5 ms]   [0x000000000249fe1f] Unknown symbol
[        ] -- End of DumpStackTrace
[  +11 ms] Service protocol connection closed.

When initializing from existing kernel file versus when running from scratch, incremental compiler produces different result which seems to be the root cause:
$FH/flutter/examples/flutter_gallery$ $FH/engine/src/out/host_debug_unopt/dart-sdk/bin/dart $FH/engine/src/out/host_debug_unopt/gen/frontend_server.dart.snapshot --sdk-root $FH/engine/src/out/host_debug_unopt/flutter_patched_sdk/ --strong --verbose --target=flutter --no-link-platform --incremental --packages .packages --output-dill build/app.dill --depfile build/snapshot_blob.bin.d lib/main.dart
...
$FH/flutter/examples/flutter_gallery$ ll build/app.dill
-rw-r--r-- 1 x x 16093560 Aug 27 11:16 build/app.dill

$FH/flutter/examples/flutter_gallery$ $FH/engine/src/out/host_debug_unopt/dart-sdk/bin/dart $FH/engine/src/out/host_debug_unopt/gen/frontend_server.dart.snapshot --sdk-root $FH/engine/src/out/host_debug_unopt/flutter_patched_sdk/ --strong --verbose --target=flutter --no-link-platform --incremental --packages .packages --output-dill build/app.dill --depfile build/snapshot_blob.bin.d lib/main.dart
...
$FH/flutter/examples/flutter_gallery$ ll build/app.dill
-rw-r--r-- 1 x x 16006861 Aug 27 11:16 build/app.dill

cc @jensjoha

Created https://github.com/dart-lang/sdk/issues/34280 to track incremental compiler issue

https://dart-review.googlesource.com/c/sdk/+/71700 hopefully with the fix.

The reason why less than bit-perfect dill files break integration tests(flutter_attached_test, hot_reload_test) is that these tests use FlutterTesterDevice which is built as such that there is no separation(normally closed by DevFS) between kernel file produced by compiler and kernel file loaded by vm. While vm loads a kernel file (from build/app.dill) incremental compiler updates exact same build/app.dill file.

Am I right in assuming that there is no longer anything for me to see here?

@jensjoha wrote:

Am I right in assuming that there is no longer anything for me to see here?

Right.


When in a directory, collapse and focus on parent

I'm following this tip to help navigating with h and l
When doing h inside of a directory, that script needs 2 keystrokes to collpase:

First one goes to the parent
Second one collapses

Thank you

I'm not sure what this issue is. Do you have a question to ask or bug to report?

OMG, sorry, I was editing it, and removed the question part, my bad!
Here it was:

I was wondering if the steps can be achieved with a single keystroke

Sorry again

@cseickel just checking in to see if there's a way for this

You don't need to use a custom function for that. close_node, which is mapped to C by default, already does that.

Oh wow, thank you @cseickel  , that's super useful! May I bother you with one more question:
Is there a way to recursively close all child nodes of the current node? What C does is close it and when I open it, whatever was expanded is already expanded, I want all of them to be collapsed

I don't think there is a built-in command to do that. There is close_all_nodes (mapped to z) which closes everything up to the root node. You can use set_root (mapped to .) on the parent directory, use z to collapese everything, and then use navigate_up (mapped to <bs>) to go back to your previous root.
I agree that this is a bit inconvenient, so if you want I could help implement this feature.

Sorry @nhat-vo for the late reply, I was busy and wanted to get back to this when I'm free.
And wow, I guess you already implemented it?

It does appear so. @nhat-vo  moves quick lol. Closing this out as  completed in #764

I had a bit of free-time yesterday, and this fix is quite similar to another PR I did, so I just went ahead and do it 😄

@nhat-vo thank you very much, question: is there a command to do the opposite? Basically, when on a node, recursively open all the subnodes? (recursively is the important big 🙂 )

@farzadmf so an auto expand of all nodes under a current node? That seems... dangerous for memory lol.

Thank you @miversen33 , I completely agree. Usually I don't get replies on the new questions I ask, so I tried to get an answer for that from here 😝 , but I completely agree with your point to keep issues focused on their scope.


My sticky state's link url is "ignored" (unless I open it in new tab)

Hi,
2 versions to my problem:

The short -
I use "ui-sref" in one of my sticky views. When I navigate to a view which is not nested in the sticky one, everything goes well. But then, I click on a link from the sticky view, and I can see that I get errors (because some of my stateParams have gone), although the "href" attributes of this link still shows the correct path (with the missing stateParams) and will render the right state if I open it in a new tab.
How can I make the href "override" the router behavior ?

The detailed -
I have a sticky state(info.selected_tag). When I click on a link to a state which is not nested in this sticky state(info.detailed_item), everything go as expected and the sticky state's view remains displayed, while the new state gets displayed as well.
Then, I click on another link located in my sticky state view, but now I get an error and I can see that it's because the $stateParams is empty. But when I hover on the link, and open it in a new tag, I can see that its url is the url I really need to navigate to, with all the stateParams. What's going on here? Why the url is ignored when clicking on a link? how does the "ui-sref" works?

 state('info.selected_tag', {
        abstract: true,
        sticky: true,
        url: '/:shortName',
        resolve: {
          'grouping_tag': ['$stateParams', 'grouping_tags',
            function($stateParams, grouping_tags) {
              console.log($stateParams);
              return grouping_tags.get($stateParams.shortName).$promise;
            }
          ]
        },
        views: {
          'second-navigation': {
            controller: ['$stateParams', '$scope', '$rootScope', 'grouping_tag',
              function($stateParams, $scope, $rootScope, grouping_tag) {
                $rootScope.selected['grouping_tag'] = grouping_tag;
              }],
            templateUrl: "grouping_tags/selected.html"
          }
        }
      }).
     state('info.selected_tag.items', {
        url: '/items',
        views: {
          'list': {
            templateUrl: 'items/list.html',
            controller: ['$rootScope',
              function($rootScope) {
                $rootScope.selected['item'] = null;
              }
            ]
          }
        }
      }).
     state('info.detailed_item', {
        url: '/items/:item_id?grouping_tag=:shortName',
        views: {
          'detailed': {
            controller: ['$scope', '$rootScope', 'info_items', '$stateParams', '$state',
              function($scope, $rootScope, info_items, $stateParams) {
                info_items.show($stateParams.item_id).then(function(info_item) {
                  $scope.item = info_item;
                  $scope.header = "Preview";
                });
              }],
            templateUrl: 'info_items/detailed.html'
          }
        }
      });

This may be a fundamental flaw in using sticky states.
ui-sref is a passthrough for $state.go. It supplies .go with two options, one of which is inherit: true.
When .go sees the inherit option, it uses the current state params and combines them with any additional params you specified.
When your state is inactive, the current state params do not include the params that you used when you activated your now-inactive state.
I'm not sure what the appropriate fix would be for this.  Perhaps:

write a custom sref directive
do not rely on inherit: true behavior

Marking 'wontfix' because I'm not sure what a good approach is.


Fix internal version of mod

Some mods/tools like Mod Manager look at this version, in case of an update. If this version isn't properly updated, the affected mods are the new, updated version in the /mods folder (in my case 2.3,0), but the mod thinks it's running the version listed (in my case 2.1.0). So I made a quick version bump, and please @Motschen, make sure to always update this version number ahead of release. Thanks!

Sorry for not updating the version, I forgot I had to manually do it for this mod.


Rename instrumentation to parametrization in optimizers init

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

@teytaud FYI this is a big change that will be breaking in v0.4.0: renaming instrumentation to parametrization as first parameter of the optimizers, for more clarity and consistency. In the meantime this PR introduces a "compatibility-mode" where you can still use instrumentation but get a deprecation warning. When it is landed I will release v0.3.2, and soon I will delete all old code and all compatibility-mode to release v0.4.0


Is it possible to have a BindTo method?

Issue description
Binding marker and circle once it was being dragged
Steps to reproduce and a minimal demo of the problem
I created a marker and circle and I want them to be draggable as once
What steps should we try in your demo to see the problem?
If you clicked the marker it should also drag the circle so the result will be is it will stay on one location.
Current behavior
It can only be drag separately not as pair.
Expected/desired behavior
Can be drag as pair using bindTo method if possible
angular2 & angular-google-maps version
1.0.0-beta.1
Other information

I'd like to use the bindTo() method this too.

how about
<agm-marker (drag)="updateCircle($event)">
<agm-circle [latitude]="circleLat" [longitude]="circleLng">

updateCircle(event: MouseEvent) {
  circleLat = event.coords.lat;
  circleLng = event.coords.lng;
}


Fix PS1 keys

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.175%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
11128

Relevant Lines:
13379

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.175%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
11128

Relevant Lines:
13379

💛  - Coveralls


Keep track of last page viewed

As an on and off editor, it would help to remember the last page I worked on proofing. If there is github integration and you can check the ID of the last issue I opened, it would at least be good enough to give an idea to me of where to work forward from.

What if we had a button/link on the sources page that said You were last on page x of source y?
We can store this in localstorage for now, since I'll assume that most of the time, people use the same browser and machine


access_log: formatter for upstream host metadata

Commit Message:
formatter for upstream host metadata
Additional Description:
Part of #20389. Most of the formatters used in header manipulation are also present in substitution access log formatters. However, UPSTREAM_METADATA was not present in access log formatters.
Also, as noted in #17457 all xxxx_METADATA will be eventually replaced my METADATA(xxxx,...) so this PR also extends METADATA formatter.
api changes are trivial and limited to comments.
Risk Level: Low
Testing: Added unit tests.
Docs Changes: Yes.
Release Notes: Yes
Platform Specific Features: No

/assign-from @envoyproxy/first-pass-reviewers

@dmitri-d please review.

@dmitri-d Would you mind reviewing the changes? They are really trivial. The formatter just needs to get the metadata from HostDescription, similarly to getting dynamic and cluster matadata as it is done here: https://github.com/envoyproxy/envoy/blob/release/v1.22/source/common/formatter/substitution_formatter.cc#L1683-L1702.
Thanks!

@htuch PTAL for non-tetrands review


update global service descriptions

As per https://wmo-im.github.io/wis2-guide/guide/wis2-guide-DRAFT.html#_technical_considerations_3

OK


add badges

cc @cmungall @turbomam

Address with PR https://github.com/microbiomedata/nmdc-schema/pull/39


g3doc

Thank you for submitting a TensorFlow documentation issue. Per our GitHub
policy, we only address code/doc bugs, performance issues, feature requests, and
build/installation issues on GitHub.
The TensorFlow docs are open source! To get involved, read the documentation
contributor guide: https://www.tensorflow.org/community/contribute/docs
URL(s) with the issue:
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/MyMethod
Description of issue (what needs changing):
Clear description
For example, why should someone use this method? How is it useful?
Correct links
Is the link to the source code correct?
Parameters defined
Are all parameters defined and formatted correctly?
Returns defined
Are return values defined?
Raises listed and defined
Are the errors defined? For example,
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/feature_column/categorical_column_with_vocabulary_file#raises
Usage example
Is there a usage example?
Request visuals, if applicable
Are there currently visuals? If not, will it clarify the content?
Submit a pull request?
Are you planning to also submit a pull request to fix the issue? See the docs
contributor guide: https://www.tensorflow.org/community/contribute/docs and the
docs style guide: https://www.tensorflow.org/community/contribute/docs_style

@JunhuaYe ,
Can please fill the information requested in the standard template?Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Improve handling of dangling symlinks when creating file list

Hey @stapelberg 👋
Toying around with your tool/library here and ran into a small problem I'm a bit befuddled by:
(I'm trying to see if I can build a container backup solution using rsync as the primary driver)
I'm an invoking an rsync(1) client invoking the gokr-rsync over a shell like so:
$ rsync --rsh="docker run -i --rm -v data:/data prologic/docker-rsync" --list-only :
2022/12/30 23:44:31 remote protocol: 31
2022/12/30 23:44:31 exclusion list read
2022/12/30 23:44:31 sendFileList(module="implicit")
2022/12/30 23:44:31   path "." (module root "/")
2022/12/30 23:44:31 lstat /proc/1/fd/3: no such file or directory
gokr-rsync [sender]: lstat /proc/1/fd/3: no such file or directory
rsync: connection unexpectedly closed (71 bytes received so far) [Receiver]
rsync error: error in rsync protocol data stream (code 12) at io.c(231) [Receiver=3.2.7]

I'm not sure why /proc/1/fd/3 is being opened? I poked around in the container that is spawned and there is no file descriptor 3, only 0 1 2 as you'd expect (stdin, stdout, stderr).

Just wanted to say that I got something working in a slightly different setup:
Dockerfile:
# Build
FROM golang:alpine AS build

RUN go install github.com/gokrazy/rsync/cmd/gokr-rsyncd@latest

# Runtime
FROM alpine:latest

RUN apk --no-cache -U add su-exec shadow

ENV PUID=1000
ENV PGID=1000

RUN addgroup -g "${PGID}" nonroot && \
    adduser -D -H -G nonroot -h /var/empty -u "${PUID}" nonroot && \
    mkdir -p /data && chown -R nonroot:nonroot /data

EXPOSE 8730

VOLUME /data

WORKDIR /

# force cgo resolver
ENV GODEBUG=netdns=cgo

COPY --from=build /go/bin/gokr-rsyncd /usr/local/bin/rsyncd

COPY entrypoint.sh /init

ENTRYPOINT ["/init"]
CMD ["rsyncd", "--daemon", "--gokr.listen=<IP_ADDRESS>:8730", "--gokr.modulemap=data=/data"]

entrypoint.sh:
#!/bin/sh

[ -n "${PUID}" ] && usermod -u "${PUID}" nonroot
[ -n "${PGID}" ] && groupmod -g "${PGID}" nonroot

printf "Switching UID=%s and GID=%s\n" "${PUID}" "${PGID}"
exec su-exec nonroot:nonroot "$@"

I was successfully able to rsync the contents of a Docker named volume (even while a container was running/attached to it) 👌 -- That's backup done.
Now for restore 😅

My plan was to (btw):

Spin up a backup container like: docker run --rm -p 8730:8730 -v data:/data:ro prologic/docker-rsync for any given named volume.
Perform an initial backup using like: rsync --archive --delete --verbose --port 8730 rsync://localhost/data/ .
Temporarily stop the any attached running containers.
Re-run the backup (in case any files changed)
Restart the affected containers.

Hey! The problem you ran into is that you were trying to serve /, which includes the /proc pseudo file system, which in turn contains a bunch of dangling symlinks (by design).
Obviously the current behavior of gokr-rsyncd isn’t great when encountering dangling symlinks. I haven’t checked what the original rsync does yet.
You can work around the issue by changing the code to ignore ENOENT for now:
--- i/rsyncd/flist.go
+++ w/rsyncd/flist.go
@@ -45,6 +45,12 @@ func (st *sendTransfer) sendFileList(mod Module, opts *Opts, paths []string) (*f
 		err := filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
 			// st.logger.Printf("filepath.WalkFn(path=%s)", path)
 			if err != nil {
+				if os.IsNotExist(err) {
+					// We encounter -ENOENT when walking over a dangling symlink
+					// (e.g. /proc/<pid>/fd/3). Don’t stop file list creation,
+					// just ignore the affected file.
+					return nil
+				}
 				return err
 			}

@stapelberg Oh! 🤦♂ This is because despite the modulemap I configured, I had set the working directory of the image to / 🤔


Use the new path to the linter package

@abarth @ianloic @pylaligand

Hi @Hixie and @danrubel can you either of you take a look? Thanks!

FYI, there was a similar PR in dart sdk:
dart-lang/sdk#28062

cc @jason-simmons

I'm going to land this to unblock you since it seems fine but I'm not really the right reviewer.
RSLGTM
TBR @abarth


Stream parser fails HTML comment from OkHttp3 response body (JSoup >= 1.11.1)

From a very specific HTML page, it got that a HTML comment is badly parsed and that happen (as far i could test) only with OkHttp3 response body stream() and JSoup >= 1.11.1
Please have a look at the dedicated running testcase here: https://github.com/btheu/jsoup-parsing-issue.
@Test
public void testJsoup() throws IOException {

    OkHttpClient client = new OkHttpClient();

    Request request = new Request.Builder()
            .url("https://www.letrot.com/stats/fiche-course/2019-09-22/202/6/partants/tableau").build();

    Response response = client.newCall(request).execute();

    Document parse = Jsoup.parse(response.body().byteStream(), "UTF-8", "https://www.letrot.com/");

    int numberOfCells = parse.select("td").size();

    System.out.println(numberOfCells);

    // Here: JSoup fails parsing the comment for the second html table row
    //
    // this can be read at line 687 (more or less) from the raw response page
    System.out.println(parse.select("#result_table tr").get(1).select("td").text());
    System.out.println(parse.select("#result_table tr").get(2).select("td").text());
    System.out.println(parse.select("#result_table tr").get(3).select("td").text());

    assertEquals(156, numberOfCells);
}

Best regards,

Hi,
Testcase does not show the issue any more. The remote web site used for test may fixed some code on their side.
This ticket can be close.


ModLoaderStore - Singleton for to store data

As @KANAjetzt suggested on Discord, if we add another singleton before ModLoader, we can use it to hold all the data that we might want to share between ModLoader core and all its associated methods.
This fixes an issue where you can't refer to the local variables in mod_loader.gd during its _init phase, because it's not ready yet.
This will help us to address these issues, which are currently (mostly) blocked by this problem:

#109
#140
#141
#146
#145 (implement the remaining options)
#153

It may also provide us with more optimisation options, eg for _get_verbosity (mod_loader_utils.gd) we can store the command line arg overrides once and refer back to them later, rather than checking them every time a log is performed.
Additionally, we can refactor out code to be simpler with less repetition, eg. currently in the 2 places that get_local_folder_dir("configs") is used, it's immediately followed by a check to see if there's a CLI override; we could simply store the path to use once, then refer to that single point of data instead.

Closed by #172


ERROR in Loader project\node_modules\preprocess\lib\preprocess.js didn't return a function

I did
npm install --save preprocess

and in webpack
module: {
    loaders: [
        {test: /\.tsx?$/,loader: "preprocess!ts-loader"}
    ],

but webpack says:
 ERROR in Loader F:\wamp-new\www\dacore\modules\browser-core\node_modules\preprocess\lib\preprocess.js didn't return a function

using webpack 1.13. Will try upgrading to webpack 2 now
Edit: similar error with webpack 2:
Error: Module 'F:\wamp-new\www\dacore\modules\browser-core\node_modules\preprocess\lib\preprocess.js' is not a loader (must have normal or pitch function)

You have most likely solved this by now but for completeness sake, you need to install preprocess-loader not preprocess.


Feature/face detection android

Thank you, it seems a nice feature.
I'm concerned about performance and battery usage as this feature is activated by default. I think this should be activated by a boolean prop or only when onFacesDetected callback is provided, it will save some unneeded computations and events from DeviceEventEmitter.
cc @rt2zz

+1

@ptomasroos what do u think of this feature?

@pfeiffer can you rebase with master?

Camera.FaceDetectionListener is deprecated
import android.hardware.Camera; is deprecated as well


Updated information

I updated the following point.

information of official Docker image
year of LICENSE

:+1:

:+1:


886 msa precip variability xcdat

The code for precip variability across timescales has been updated to use xCDAT. I have tested it with oservational and model data and there was no issue.
Demo notebooks: using CDAT, using xCDAT

@msahn looks great, thank you for adding this. One more thing that could be added is dependency in the dev.yml file. The latest xcdat is v0.4.0. Could you please check your code is working okay with xcdat v0.4.0 and add xcdat=0.4.0 in the dependency list?


As a player, I want an app home, So that I can manage multiple character.

As a player,
I want an app home,
So that I can manage multiple character.
Acceptance criteria

[ ]

Definition of Done:

[ ] All acceptance criteria are met.
[ ] Code is reviewed and approved.
[ ] Necessary tests are written and pass.
[ ] Documentation is updated, if applicable.
[ ] Feature is deployed.

Mockup
TODO
Wireframing

(análogo à tela de hirelings)

Closed by 16c9b38f45d0b6e81bfce212f66af4a710665f4e


rtorrent.rc: fix delete data when removing torrent issue

Minor PR which comments out a line in .rtorrent.rc defining that when a torrent is removed, the data is always deleted. This is quite controversal as you have the erasedata plugin for that scenario. So, for those who actually wants to always delete data when removing a torrent, they can simply uncomment the line and skip using the erasedata plugin.
Tested and it works as intended, similar to the findings in https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/199
Related issue which will be fixed: https://github.com/crazy-max/docker-rtorrent-rutorrent/issues/199
PR which can be closed after merging: https://github.com/crazy-max/docker-rtorrent-rutorrent/pull/203

@crazy-max We fixed a race condition with the erasedata plugin on ruTorrent version 4 in https://github.com/Novik/ruTorrent/commit/2f59732ead6b086d849b2addb972f43c48b30d71 . It will properly delete torrent data now. This workaround to always delete data is no longer desirable. It should be removed entirely.
The erasedata plugin allows the user to choose when removing a torrent:

Delete just the torrent and preserve the torrent data.
Delete both the torrent and the torrent data.

It's a default plugin that should always be enabled. There's no reason to ever disable it anymore. It's modular and just enables torrent deletion options on the Graphical User Interface. It's compatible with any other type of script and works as intended.


Password Recovery

When typing in you email on the password recovery site you get a Server Error (500)

After password recovery fix was applied the login page no longer works


modelPath needs a setter

First, thank you so much for this great port of Whisper to Unity ❤ ! It got me up and running in half no-time with increadibly accurate results 🚀 .
However, I am missing a setter for WhisperManager.modelPath.
The field is private but serialized. So, one can set it in the inspector, but not from code.
As a workaround, I am settings it via reflection at the moment
    private void SetWhisperModelPath(WhisperManager whisperManager, string modelPath)
    {
        // Set the model field via reflection, because the property is private.
        FieldInfo prop = whisperManager
            .GetType()
            .GetField("modelPath",
                System.Reflection.BindingFlags.NonPublic
                        | System.Reflection.BindingFlags.Instance);
        prop.SetValue(whisperManager, modelPath);
    }

The field does not need to be private. It can be changed as long as InitModel has not been called yet.
public string ModelPath
{
    get => modelPath;
    set
    {
        if (IsLoaded || IsLoading)
        {
            throw new InvalidOperationException("Cannot change model path after loading the model!");
        }

        modelPath = value;
    }
}

Good point! Could you make a PR with new setter code? I will speed merge that.

Will do.
Using the streamingAssetsPath as base path should also be optional.
var path = Path.Combine(Application.streamingAssetsPath, modelPath);


fix(client): discard empty paths

Replaces
https://github.com/prisma/prisma/pull/11829
https://github.com/prisma/prisma/pull/10804
Goes with https://github.com/prisma/e2e-tests/pull/2488
Closes https://github.com/prisma/prisma/issues/9435

Hey @Faithfinder, thanks for pointing that out. This PR does exactly what https://github.com/prisma/prisma/pull/11829 does, which means that it is not a fix. I will point your comment there to find a solution.

@millsp  Any idea when this is going to be published out as a 3.11?
This fixes https://github.com/prisma/prisma/issues/9435 which is an issue I was having also (as well as all the others mentioning it!)

Hey @JonParton, this PR will be published in two weeks from now. If you really need it now, you can temporarily use the integration version that I shared in a comment in the related issue.


ERROR Cannot start nuxt: kit.writeTypes is not a function

Environment
Nuxt project info:                                                                                8:15:37 AM

Operating System: Linux
Node Version:     v20.5.0
Nuxt Version:     3.7.1
CLI Version:      3.8.0
Nitro Version:    2.6.3-28235083.5639f5b
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      alias, app, colorMode, css, dayjs, devtools, experimental, i18n, image, modules, nitro, pwa, runtimeConfig, security, ssr, tailwindcss, viewport, vueEmail
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>vue-email/nuxt
Build Modules:    -

Reproduction
New instaled nuxt with modules
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>vue-email/nuxt
Describe the bug
-Nuxt 3.7.1 with Nitro 2.6.3-28235083.5639f5b                                                                                8:14:07 AM
8:14:09 AM
➜ Local:    http://localhost:3000/
➜ Network:  use --host to expose
ℹ Adding @auth/nuxt module... { verifyClientOnEveryRequest: true,                                                                             @auth/nuxt 8:14:12 AM
guestRedirectTo: '/',
authenticatedRedirectTo: '/',
baseUrl: '' }
✔ Added @auth/nuxt module successfully.                                                                                @auth/nuxt 8:14:12 AM
ℹ Vue I18n configuration file does not exist at i18n.config. Skipping...                                                                    @nuxtjs/i18n 8:14:13 AM
ℹ Using default Tailwind CSS file                                                                                nuxt:tailwindcss 8:14:13 AM
ℹ Using yup with vee-validate                                                                                8:14:14 AM
✔ Nuxt DevTools is enabled v0.8.3 (experimental)                                                                                8:14:16 AM
ℹ Tailwind Viewer: http://<IP_ADDRESS>:33087/_tailwind/                                                                                nuxt:tailwindcss 8:14:17 AM
ERROR  Cannot start nuxt:  kit.writeTypes is not a function                                                                                8:14:17 AM
at NuxtDevServer._load (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/chunks/dev.mjs:230:11)
at async NuxtDevServer.load (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/chunks/dev.mjs:161:7)
at async NuxtDevServer.init (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/chunks/dev.mjs:156:5)
at async Object.run (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/chunks/dev-child.mjs:91:5)
at async runCommand$1 (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/shared/nuxi.913ed971.mjs:1645:5)
at async runCommand$1 (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/shared/nuxi.913ed971.mjs:1639:7)
at async runMain$1 (node_modules/.pnpm/nuxi@3.8.0/node_modules/nuxi/dist/shared/nuxi.913ed971.mjs:1757:7)
Additional context
No response
Logs
No response

I also get this. My dependencies are:
"devDependencies": {
"@hebilicious/authjs-nuxt": "^0.3.0-beta.2",
"nuxt": "^3.7.1"
}
Just having this and running "npm run dev" gives me the same error as above.

I also get this. My dependencies are:
"devDependencies": { "@hebilicious/authjs-nuxt": "^0.3.0-beta.2", "nuxt": "^3.7.1" }
Just having this and running "npm run dev" gives me the same error as above.

Can you downgrade Nuxt to 3.7.0 and let me know if that fixes the issue for you ?

Downgrading to 3.7.0 doesn't fix it, but downgrading to 3.6.5 does

Downgrading to 3.7.0 doesn't fix it, but downgrading to 3.6.5 does

Thanks for the heads-up, we're investigating.

Downgrading to 3.7.0 doesn't fix it, but downgrading to 3.6.5 does

Thank you, downgrade to 3.6.5 works for me too

Btw if you guys have a reproduction that would be great. I tried to reproduce with nuxt 3.7.1 but no luck, everything works on my end : https://github.com/Hebilicious/nuxt-cli-module-issue

Interesting. What version of Node are you using? I'm currently on 18.17.1
I will try 20.6.1 and see if that makes any difference.

Interesting. What version of Node are you using? I'm currently on 18.17.1 I will try 20.6.1 and see if that makes any difference.

20.5.0, but I'm using bun, not node.

I can confirm that upgrading Node to 20.6.1, this fixes the issue. I can install this package and use Nuxt 3.7.1

I can confirm that upgrading Node to 20.6.1, this fixes the issue. I can install this package and use Nuxt 3.7.1

That seems very odd ... I'm gonna close this so we can track in https://github.com/nuxt/cli/issues/157

fixed in https://github.com/nuxt/cli/pull/158


Add router class and example of usage

@rohan-dhamal-clarice @jotiram @abhra-clarice
This also illustrates how we should be dealing with singletons.

@aleffert I agree that lot of refactoring will be required for this. We will continue refactoring in parallel with other tasks maintaining priority.
Thanks for adding Router example, I will work on similar implementation in Android.

@rohan-dhamal-clarice yeah, don't worry about transitioning existing code to do this. That will be a gradual process as we touch those areas


The remote certificate is invalid according to the validation procedure: RemoteCertificateNameMismatch, RemoteCertificateChainErrors

I have two services that are running in Tye using Dapr Rc3.
Both services startup and I am able to invoke API commands via Swagger on each.

When I attempt to make a service to service invocation from the second service to the first service (update API above), it throws an exception as follows;

The logs  on both daprd instances appear normal, as does the log on placement.

My bad...
the issue was that I had UseHttpRedirection enabled ... I commented that out and it works great..

Dapr Rocks!

My bad...
the issue was that I had UseHttpRedirection enabled ... I commented that out and it works great..

Dapr Rocks!

Issue resolved as per my last comment

Issue resolved as per my last comment


Linux Mint + Brave/Chrome : the plugin icon do not show the mark when a page has been saved

Hi,
I just installed Brave on Linux Mint with the Raindrop Plugin.
Whenever I do add a page to Raindrop by clicking the icon (and eventually filling up the tags and description), I don't see the mark on the icon showing "that" url has been saved.
A few days ago I was still on Windows, I had that little mark on the icon, in my case this changes everything (I tend to save a lot of stuffs, even stuffs I know their url by hart)
Is there anything I can do to fix this ?
Peace of mind is on the edge here...

Did you enabled "saved indicator" https://help.raindrop.io/browser-extension#saved-indicator ?


App-only: how to use + common pitfalls

Article that describes how to use app-only and more important that describes what doesn't work using app-only

Closing back log - this is nicely covered in following guidance article: https://github.com/OfficeDev/PnP-Guidance/blob/master/articles/SharePoint-Add-In-Recipe-elevated-privileges.md


Add support for Matrix MPD DJ

Would it be possible for you to add this cool project to your image? It allows users to control MPD through matrix.

Sure but I have no idea what it is.  does it makes sense without a STREAMURL? Mopidy doesn't support streaming its audio via http and therefore nor do we.

At least play/pause and stuff like that should work. Also, I think it does more than what the readme contains, from looking at the commits.

Having looked a bit closer at what matrix is I'm not convinced this is something aimed at the pimusicbox crowd. If someone wants to provide a PR adding this software then that's great but I'm not going to look into it myself.


Bump architect-orb to v5.10.0

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Renovate also found this :) https://github.com/giantswarm/zot/pull/106


"The context paramter [sic] is invalid" error if Experimental Web Platform features flag is on

All samples at https://webmachinelearning.github.io/webnn-samples/ fail with:

The context paramter is invalid

If chrome://flags/#enable-experimental-web-platform-features is enabled.
Tested with Chrome Stable 107 and Canary 109.

Yes, when testing by Chrome with enabled enable-experimental-web-platform-features flag, the following code would invoke createContext() function of ML interface from Model Load API.
const context = navigator.ml.createContext(contextOptions);

The createContext() function of Model Load API is an async function, it returns a Promise<MLContext> object, while WebNN API MLGraphBuilder constructor requires a context parameter of MLContext type, so the error was alerted.
this.builder_ = new MLGraphBuilder(context);

To fix this issue need modify code using await, @Honry PTAL, thanks.
const context = await navigator.ml.createContext(contextOptions);

while there's an issue https://github.com/webmachinelearning/model-loader/issues/41 of Model Load API.
And current WebNN Polyfill API checks whether Navigator object has ML interface, if not, WebNN Polyfill API will provide it.
if (navigator.ml == null) {
  navigator.ml = new ML();
}

We are enabling latest async and sync APIs (PRs: https://github.com/webmachinelearning/webnn-polyfill/pull/172, https://github.com/webmachinelearning/webnn-samples/pull/150), which should fix this issue.


ansible_mitogen.target.run_module get wrong module_params (sometimes)

With ansible.builtin.template sometimes "foo.bar/foo.bar.j2" (file in directory) is created instead of "foo.bar" plain file.
I was able to reproduce it three times in two different tasks of a somewhat large execution (36 plays with some hundred tasks). It took about 10 tries. On the next day I was not able to reproduce the issue in 30 tries.
I was not able to reproduce it when execution was limited using tags to just a failing task in 200 tries.
Ansible version is 2.9.15 from PyPi, no custom modules, Mitogen 0.2.9

Have you tried the latest master version from Git?
No. I'm unsure I could easily reproduce the issue.

Do you have some idea of what the underlying problem may be?
It looks a configuration variable with target path is evaluated wrongly.

Mention your host and target OS and versions
Ubuntu 18.04.5 with latest updates (local connection).
Python 3.6.9

Example failing task:
- name: copy my.cnf
  template: src=mysql/{{ item }}.j2 dest={{ foo }}/mysql/{{ item }}
  with_items:
    - my.cnf
  tags: mysql

$ ansible-config dump --only-changed
ANSIBLE_FORCE_COLOR(/home/igorfraa/ansible/playbook/ansible.cfg) = True
ANSIBLE_PIPELINING(/home/igorfraa/ansible/playbook/ansible.cfg) = True
ANSIBLE_SSH_ARGS(/home/igorfraa/ansible/playbook/ansible.cfg) = -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o ForwardAgent=yes -o ControlMaster=auto -o ControlPersist=60s
DEFAULT_CALLBACK_WHITELIST(/home/igorfraa/ansible/playbook/ansible.cfg) = ['profile_tasks']
DEFAULT_HOST_LIST(/home/igorfraa/ansible/playbook/ansible.cfg) = ['/home/igorfraa/ansible/hosts']
DEFAULT_STRATEGY(/home/igorfraa/ansible/playbook/ansible.cfg) = mitogen_linear
DEFAULT_STRATEGY_PLUGIN_PATH(/home/igorfraa/ansible/playbook/ansible.cfg) = ['/home/igorfraa/ansible/playbook/files/mitogen-0.2.9/ansible_mitogen/plugins/strategy']
DEFAULT_TIMEOUT(/home/igorfraa/ansible/playbook/ansible.cfg) = 30
HOST_KEY_CHECKING(/home/igorfraa/ansible/playbook/ansible.cfg) = False
PERSISTENT_CONNECT_TIMEOUT(/home/igorfraa/ansible/playbook/ansible.cfg) = 30

Log for a task:
mitogen-cleaned.log

Does anybody have an idea of a possible cause of this bug?
I have looked into Ansible sources and parameter parsing/substitution appears simple and straightforward. I do not think that bug could resist in vanilla Ansible itself.

At first glance I'm not sure what could be going on here. Please try one of the latest Mitogen releases to see if the issue still persists:
v0.2.10rc1  for Ansible < 2.10
v0.3.0rc1 for Ansible 2.10+


As a developer, I would like a documented process for generating releases

As a: developer
I want: a documented process for creating a Bedrock releases.
So that: there is a consistent plan, criteria, and process in place for releases.
Describe the solution you'd like:
The release process should consider:

when to release
what the state of master is in prior to release
how to highlight both changes/new features as well as any upgrade/migration issues
how to handle any dependencies in the release that requiring knowing the release number/etc

Does this require updates to documentation?: Yes

PR - #535 awaiting review

Closed in #535


MVP polish: Learn page and Learn detail page

Note that these pages are named "explore" rather than "learn" in the code base, as well as in the taxonomy. Fixing that is out of scope for MVP.
ACs:

Style the pages according to the mocks: top-level Learn Page: https://projects.invisionapp.com/share/3VJJSE3NG28#/screens/300196080 , sub-level Article Pages: https://projects.invisionapp.com/share/3VJJSE3NG28#/screens/300196079
Clicking on a task or article in the Learn detail page should navigate to that article or task

Also completing the polish of the article as per #158 as part of this story due to my oversight.


Ground Item Sort by Value

It's annoying when high value items are hidden at the bottom of ground item stacks. For example, runescape gives the option to pick up oysters before giving the option to pick up gems. I also often see fremmenik rings hidden at the bottom of pk loot stacks. This is for both left-clicking on a pile of ground items as well as right-clicking a pile of items and opening the ground item menu.
Ground item stacks should show the highest value items first - for both directing picking off the ground and within the ground item menu.

@deathbeam would you not accept a PR for this? Is there a fundamental reason this shouldn't be an option? I came across this issue looking for the same feature.


Why are entrypoints specified individually for .profile and not loaded dynamically?

One of our projects uses a custom entrypoint to set some environment variables. Looking at "~/.profile" I see that the entrypoints are individually sourced and not loaded using /lagoon/entrypoints.sh
This means that adding a custom entrypoint (EG: /lagoon/entrypoints/99-add-a-runtime-var.sh) don't get automatically sourced to the CLI shell environment when accessing the container remotely.
Is there a reason the entrypoints are sourced individually in ~/.profile? Would it not make sense for the ~/.profile to call /lagoon/entrypoints.sh to create a congruent experience for the shell as well as the container runtime CMD environment?

yes, reason is remote(shell) connections. (I've spent countless hours on this and is many years ago, so I hope I remember this correctly).
When you connect to a container through an remote container we need to run some (but not all) entrypoints, for example to generate environment variables. If we would run all entrypoints it would lead to a lot of issues. One example would be the cronjob one, which means you would have a cronjob running inside your remote shell, which is not what we want. Or in some other cases (like mariadb) it would actually start another mariadb process, which would also fail.
If you want to run something during a shell connection I would suggest to add your stuff directly to https://github.com/uselagoon/lagoon-images/blob/main/images/commons/lagoon/entrypoints/55-generate-env.sh or maybe source it from there, as the 55-generate-env.sh file is sourced during a shell connection: https://github.com/uselagoon/lagoon-images/blob/main/images/commons/.bashrc#L10

@Schnitzel - Thanks for this!
Two follow-ups...

Is there value in considering having a /lagoon/cli-entrypoints.sh and a new directory /lagoon/cli-entrypoints/? The cli-entrypoints.sh would source from the new directory, and then the .bashrc only references the one file. In this scenario, if a dev was wanting to add an entrypoint that was run for both CLI as well as , they could either symlink the same file, or even docker COPY the same file to two places. The value for me there is the dev doesn't have to touch 55-generate-env.sh or the .bashrc - both of which could be changed at any point and then downstream images are making changes as well.

Either way, should I contribute some docs on how to add a new entrypoint that also runs in the cli? It wasn't immediately clear why my script wasn't running until I checked .profile and saw how it was done.

we've just talked about this, and think that providing an empty XX-profile-source.sh entrypoint that is called both by the startup and ssh entrypoints should work, with the intention that this be either overwritten or appended to.

nice - that's great @tobybellwood


SUGGESTION: make types in comments colorized

VSCode Version: 1.11
OS Version: Linux Ubuntu 16.04

Hello,
my suggestion is to make types in comments colorized like it's in Atom. This will be really cool to have in VS Code. The color of types will be as it is right now if we write it outside of comments.
VS Code:

Atom:

As you can see in Atom it is colorized like it was outside of comments, it will be very cool to have it same in the VS Code.

I don't see this in Atom by default. What plugins do you have installed?
I also think an extension could contribute this using a grammar injection. See how https://github.com/natewallace/angular2-inline for an example of this

Closing as extension canidate

@mjbvz I was using nuclide package with recommended packages (you can enable it in nuclide package settings).

@mjbvz Nuclide just installs bunch of plugins I checked and it was https://github.com/gandm/language-babel this plugin.


Fixed file path to string conversion on MSVC

Added explicit conversion from std::filesystem::path to std::string. Implicit conversion works on Linux but not MSVC, which caused the program compilation to fail.

thank you!


Packages using NIXOS_OZONE_WL need wayland dep.

Describe the bug
When running an application with NIXOS_OZONE_WL=1 on nixos-unstable results in the following error:
wayland_connection.cc(157)] Failed to load libwayland-cursor.so.0.
ERROR:ozone_platform_wayland.cc(220)] Failed to initialize Wayland platform
ERROR:env.cc(255)] The platform failed to initialize.  Exiting.

Adding wayland as a runtime dependency through an overlay appears to fix the program.
An example program with this issue is signal-desktop. Overlay that fixed it:
  signal-desktop = super.signal-desktop.overrideAttrs (old: {
    runtimeDependencies = old.runtimeDependencies ++ [super.wayland];
  });

From a grep I would guess this probably affects:
pkgs/applications/office/micropad/default.nix
pkgs/applications/misc/whalebird/default.nix
pkgs/applications/misc/obsidian/default.nix
pkgs/applications/misc/1password-gui/linux.nix
pkgs/applications/networking/browsers/chromium/default.nix
pkgs/applications/networking/instant-messengers/teams-for-linux/default.nix
pkgs/applications/networking/instant-messengers/session-desktop/default.nix
pkgs/applications/networking/instant-messengers/feishu/default.nix
pkgs/applications/networking/instant-messengers/schildichat/schildichat-desktop.nix
pkgs/applications/networking/instant-messengers/slack/default.nix
pkgs/applications/networking/instant-messengers/signal-desktop/generic.nix
pkgs/applications/networking/instant-messengers/jitsi-meet-electron/default.nix
pkgs/applications/networking/instant-messengers/discord/linux.nix
pkgs/applications/networking/instant-messengers/element/element-desktop.nix
pkgs/applications/networking/browsers/brave/default.nix
pkgs/applications/networking/browsers/google-chrome/default.nix
pkgs/applications/editors/vscode/generic.nix

It looks like there's one fix PR fro the vscode one in  #206695.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.0, NixOS, 23.05 (Stoat), 23.05.19700101.dirty`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.12.0`
 - nixpkgs: `/nix/store/5nl9sdpbqcgiq4qjd6ah5hms5kh6j4x3-source`

Does anyone have an overlay fix for slack?
I tried
slack = super.slack.overrideAttrs (old: {
      rpath =
        super.lib.makeLibraryPath [
          ...
          super.wayland

but that doesn't seem to work.

rpath = old.rpath ++ super.lib.makeLibraryPath ...

vscode and signal have been fixed now.

Does anyone have an overlay fix for slack? I tried
slack = super.slack.overrideAttrs (old: {
      rpath =
        super.lib.makeLibraryPath [
          ...
          super.wayland

but that doesn't seem to work.

Why not fix this upstream?

This should fix all packages that use our electron binary: https://github.com/NixOS/nixpkgs/pull/206978 i.e. element-desktop

Why did this just start cropping up, did something change in Electron?

I have not tracked it down but something is dlopen this particular wayland library.

The basic issue was solved with #206808, is there something left, to close this issue? :)

I'm not sure they all work, but the ones I tested do, so I'll close this.

This does not seem to have been resolved with 1Password. Also adding an overlay to rpath or runtimeDependencies for it does not allow the configuration to be created.

This does not seem to have been resolved with 1Password. Also adding an overlay to rpath or runtimeDependencies for it does not allow the configuration to be created.

This is on purpose (https://github.com/NixOS/nixpkgs/pull/237925)


Remove allocations in callbacks

add PrimalVector abstraction to remove the need to use _madnlp_unsafe_wrapper
rework KKT system to pass only the Jacobian w.r.t. the original variable x (without the slack)

Codecov Report

Merging #230 (5e769b1) into master (be4f87e) will decrease coverage by 0.02%.
The diff coverage is 95.87%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   74.31%   74.29%   -0.03%
==========================================
  Files          38       38
  Lines        3703     3727      +24
==========================================
+ Hits         2752     2769      +17
- Misses        951      958       +7

Impacted Files
Coverage Δ

src/IPM/utils.jl
93.47% <ø> (ø)

src/IPM/callbacks.jl
92.04% <80.55%> (-7.96%)
:arrow_down:

src/IPM/solver.jl
91.44% <98.07%> (+0.05%)
:arrow_up:

src/IPM/IPM.jl
98.87% <100.00%> (+0.06%)
:arrow_up:

src/IPM/kernels.jl
84.16% <100.00%> (ø)

src/IPM/restoration.jl
100.00% <100.00%> (ø)

src/KKT/rhs.jl
89.36% <100.00%> (+2.18%)
:arrow_up:

src/KKT/sparse.jl
99.33% <100.00%> (+0.02%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more