Cannot Edit Project?

As far as I can tell there's no way to edit a project.  I would like to add a timeout.  Some of the mutations are causing infinite loops and I would like to mitigate that.

As quick fix, you could edit the database. It’s a plain SQLite file.

Maybe a near term solution would be adding flask-admin to keep the editing in the tool a little more.
https://flask-admin.readthedocs.io/en/latest/introduction/

PRs welcome! ;-)

I created a script using the CLI commands (and I added a delete_project.py in #34) which could easily be used to reinstate the project with slightly different parameters (i.e. always create projects using CLI).


Screen device failure

"_index": "error-reports-4ce1113",
"_type": "log-entry",
"_id": "583",
"_score": 1,
"_source": {
"@timestamp": "2015-07-08T13:55:59.121-05:00",
"level": "ERROR",
"thread_name": "AWT-EventQueue-0",
"logger_name": "org.multibit.hd.core.error_reporting.ExceptionHandler",
"message": "Uncaught exception. Proceeding to show Error Reporting dialog...",
"stack_trace": "java.lang.ArrayIndexOutOfBoundsException: 1
at sun.awt.Win32GraphicsEnvironment.getDefaultScreenDevice(Unknown Source) ~[na:1.7.0_80]
at sun.awt.windows.WWindowPeer.updateGC(Unknown Source) ~[na:1.7.0_80]
at sun.awt.windows.WWindowPeer.displayChanged(Unknown Source) ~[na:1.7.0_80]
at sun.awt.SunDisplayChanger.notifyListeners(Unknown Source) ~[na:1.7.0_80]
at sun.awt.Win32GraphicsDevice.displayChanged(Unknown Source) ~[na:1.7.0_80]
at sun.java2d.d3d.D3DGraphicsDevice.displayChanged(Unknown Source) ~[na:1.7.0_80]
at sun.awt.Win32GraphicsEnvironment.displayChanged(Unknown Source) ~[na:1.7.0_80]
at sun.awt.windows.WToolkit$5.run(Unknown Source) ~[na:1.7.0_80]
at java.awt.event.InvocationEvent.dispatch(Unknown Source) ~[na:1.7.0_80]
at java.awt.EventQueue.dispatchEventImpl(Unknown Source) ~[na

This is a similar problem to #608. Some additional information about the operating system would be helpful here.

Looking at the nature of the error I don't think it's something we can fix. The EDT has issued an event and the JRE has incorrectly provided a default screen that is not available.
If you agree with this analysis feel free to close.

Yeah - I don't think we can fix this.
Closing.


Improve docs

The README leaves a lot to be desired. API documentation is vague and it would really benefit from broken down examples.

Be sure to mention that with tokens == NULL, there is minimal validation.


LethalLib causes Old Birds entity to not spawn on v50

With LethalLib enabled:

With LethalLib disabled:

On my side it causes all entity spawning to fail. I get null exception in the terminal in the roundmanager update which causes spawning not to happen. I only have lethallib and my sirenhead mod installed
[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
RoundManager.Update () (at <7c1294fdd4e74b13968c5a3e316e621a>:IL_004D)

I'm having the same exact issue, and can confirm that LethalLib seems to be the culprit here.
The first error message that pops up is a few seconds after pulling the lever to land the ship:
[Error  : Unity Log] Error while predicting outside enemies: System.NullReferenceException: Object reference not set to an instance of an object
  at RoundManager.PredictAllOutsideEnemies () [0x0004b] in <7c1294fdd4e74b13968c5a3e316e621a>:IL_004B
  at RoundManager.FinishGeneratingNewLevelClientRpc () [0x00135] in <7c1294fdd4e74b13968c5a3e316e621a>:IL_0135

... which is followed by the error @Ccode-lang mentioned, multiple times a second.

I am having the same issue of having no enemies spawn when LethalLib is enabled

+1 need to fix like rn maybe

Такая же проблема , после добавления этого мода пропали всё монстры? Ещё фикс не делали?

For me, this has been fixed. Haven't had any problems. I haven't specifically checked for old birds though.

checked this issue are fixed


bug(cdk/a11y , material/core): Enabling verbatimModuleSyntax causes error TS2748

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I have enabled verbatimModuleSyntax introduced in typescript 5.0.

Added "verbatimModuleSyntax": true to tsconfig.json

As a result, an error occurred.
TS2748: Cannot access ambient const enums when 'verbatimModuleSyntax' is enabled
Reproduction
Steps to reproduce:

Update to Angular 16.
Change to typescript 5.0.4.
Add "verbatimModuleSyntax": true to tsconfig.json .
Build

Expected Behavior
build success !!
Actual Behavior
Error: node_modules/@angular/cdk/a11y/index.d.ts:729:9 - error TS2748: Cannot access ambient const enums when 'verbatimModuleSyntax' is enabled.
729         FocusMonitorDetectionMode,
~~~~~~~~~~~~~~~~~~~~~~~~~
Error: node_modules/@angular/material/core/index.d.ts:430:9 - error TS2748: Cannot access ambient const enums when 'verbatimModuleSyntax' is enabled.
430         RippleState,
~~~~~~~~~~~
Environment

Angular: 16.0.0
CDK/Material: 16.0.0
Browser(s): Chrome 113
Operating System (e.g. Windows, macOS, Ubuntu): win32 x64

I got a clear answer from @alan-agius4  about using verbatimModuleSyntax.
So I will close this issue.
https://github.com/angular/angular/issues/50154#issuecomment-1540002109


Decoding mp3 to flac wrongly

http://music.163.com/song?id=1463338826
It's a 320K HQ file (in fact a mp3), but is decoded to a flac file using qn-decode.

From this pic, you can see the result file is a lame mp3 file, but the extension is wrongly named as ".flac".

At present, the file is recognized by the extension, not the file header. @Kennnnnnji

Yes. I mean the conversion result is "xxx.flac" instead of ".mp3".
But the audio should be ".mp3" in fact, it should be a lossless audio file.

Yes, you can see this code https://github.com/luanxuechao/qn-decode/blob/a3497bd65e726cf13e2cdf0752cc8c0abb1541bb/util/decodeNcm.go#L316


Blog post: Platform Engineering Through the Lens of Two-Sided Markets

Closes https://github.com/cncf/tag-app-delivery/issues/501

Great, thanks for opening this @nagyv !
I think you'll need to manage the DCO failure, there are some instructions for how to do that in the CI step.
In addition, it would be great to remove the "draft" status so we can see it on the blog preview (to review headings etc).
@joshgav / @roberthstrand it would be great to get a review of this!

@abangser I fixed the DCO commits behind the failure. Could you trigger a new pipeline run, please?

Thank you for this @nagyv! I did an initial review now and will read again soon, a couple thoughts:
Is there an opportunity to discuss "Thinnest Viable Platform" in the context of build versus buy? Could we emphasize more that even if an organization buys most of a platform from GitLab or another vendor they'll still be responsible for the "thinnest layer" on top, even if that's just documentation pointing to e.g. GitLab?
I'm also a bit concerned that the only vendor mentioned is GitLab and @nagyv you're a PM for GitLab :rofl: - perhaps it would come off better to mention another vendor or two as well - WDYT?
Thanks again for the submission!

The title of the post is currently Platform Engineering Through the Lens of Two-Sided Markets, so I wonder if the proposed path for the post the-economics-of-the-cncf-platform-engineering-model might be updated to better agree with the title?

Thanks for the review @lianmakesthings.
I think that blockers have been met by the disclaimer, additional tool examples, and softening of language around defining the category.
I would love to see @nagyv get this published. With that in mind, IMO all open suggestions (including yours @lianmakesthings) should be optional as at the end of the day this is a community post and while different people have opinions this post appears to meet community guidelines and if a community member wants to write on a similar topic with a different voice or from a different angle that would be also be welcome.
I know it has been a long road @nagyv and that the start of the year can be a hectic time but please do let me know what I can do to help get this published for you!

@nagyv it would be great to see this merged - could you review @lianmakesthings 's comments please?

Hey @nagyv, any word on if/when you may want to review  this for merge? Would love to get this on the site!

Sorry everyone, I got distracted by life. I'm back on this now, and hope to have everything answered this week.

The title of the post is currently Platform Engineering Through the Lens of Two-Sided Markets, so I wonder if the proposed path for the post the-economics-of-the-cncf-platform-engineering-model might be updated to better agree with the title?

Fixed

Closing due to lack of activity


AttributeError: 'module' object has no attribute 'ASNUM_EDITION_V6'

Quick question - Is this error related to my environment, the import file, or something else?  This file does not contain any IPv6 addresses...
root# ./csv2dat.py -w Citrix_mynewdb.dat mmcity myoldcsv.csv
Traceback (most recent call last):
File "./csv2dat.py", line 270, in
class ASNv6RadixTree(ASNRadixTree):
File "./csv2dat.py", line 274, in ASNv6RadixTree
edition = pygeoip.const.ASNUM_EDITION_V6
AttributeError: 'module' object has no attribute 'ASNUM_EDITION_V6'
[root]#

This constant was added in version 0.3.0 of pygeoip. Make sure you have at least this version installed.


bundles: invenio-records-js v0.0.3

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

ping @lnielsen

LGTM


Problem with the Count parameter of the Until action

Describe the Bug with repro steps

Create a standard logic app and create a workflow in it
Add the Until loop to it and you can see its Count parameter has a default value of 60
Save the workflow, check code view and designer view, the Count parameter is good with value 60
Now In designer change the Count parameter to some other value like 300, save workflow, check code view and designer view, the Count parameter is good with value 300
Now in designer, delete the Count parameter, save workflow, the code view and designer view look good with no Counter parameter.

Now add some action like Compose to the workflow, save it, Check code view and designer view , you will find the Counter parameter is back with its default value of 60.

The old designer does not have this issue, because in old designer, the Counter parameter cannot be deleted.
What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome
Additional context
ICM 486728741

@Eric-B-Wu
I'm sorry to bother you.
Please confirm this problem as soon as possible, as it is keeping our clients waiting.

Apologies for the delay, we've identified a code bug and will be hotfixing this issue today, we expect this to complete EOD today to all regions.

@Eric-B-Wu
Before reporting to the customer, I have some additional questions on this issue.
Is the Count parameter an optional parameter?
If the Count parameter is deleted, is my understanding correct that the default value will not be set unless the user subsequently modifies the Count parameter with the value?
Is my understanding correct that the loop count of the Until action will exceed the default limit If the Count parameter is deleted (initially 60 loops)?
If the Count paramete been deleted, is it correct that the number of loops in the Until action will exceed 5000?

Apologies for the delay, we've identified a code bug and will be hotfixing this issue today, we expect this to complete EOD today to all regions.

there have been release delays that's still holding the deployment, will try to get this deployed as quick as possible.

@AyanaKobashikawa

Is the Count parameter an optional parameter? According to the Manifest, yes.

If the Count parameter is deleted, is my understanding correct that the default value will not be set unless the user subsequently modifies the Count parameter with the value? That is what was intended, but there was a bug that we'd use the default anyways when serializing the parameter, causing the issue seen in this bug

Is my understanding correct that the loop count of the Until action will exceed the default limit If the Count parameter is deleted (initially 60 loops)? Yes if the limit is unset, it will go until either the loop is finished or the max limit is reached: Here is the link for until limits for each sku

If the Count paramete been deleted, is it correct that the number of loops in the Until action will exceed 5000? It should be capped at 5000, and if count parameter is unset, it should still not exceed 5000 iterations

@Eric-B-Wu
Thank you for your answer. I am aware of the contents of 1~4.
This issue has been closed. Thank you for your response.


refactor: article feeds

style and function fixes for article feed and recommended articles

recommended articles and article headers will appear in their own sections
article feed and article headers now span the width of the page properly
beginnings of string variable localization

Related Issue
small part of #60, #57
Links

https://article-feeds-styling--business-website--adobe.hlx.live/blog/
https://article-feeds-styling--business-website--adobe.hlx.live/drafts/uncled/blog/kitchen-sink

not sure if that's related to this PR, but the CLS looks a bit out of the ordinary, probably because of the unfortunate sizing of the h1. i think more generally, the h1 could use some left-right padding/margin anyway on mobile.

LCP slightly improved...


Fix ExplainNode forgetting to set sname for node 'T_TupleSplit'

When node is 'T_TupleSplit' , the sname for it forgotten to  set, then the explain command will fail.
Just fix it

fix #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Please add a description?

When node is 'T_TupleSplit' , the sname for it forgotten to set, then the explain command will fail.

In what case will this happen, shall we add the cases to test?

When node is 'T_TupleSplit' , the sname for it forgotten to set, then the explain command will fail.

Add the cases to test?

Hard to add cases to cover each type of plannode.  Maybe enable the autoexplain extension can help.


Timestamps are milliseconds since Unix epoch

tweak our encoder's format for dates

converts datetime -> Unix milliseconds when unix is the date_format requested
unix is the default date_format

use our encoder to encode datetimes for API querystrings

convert incoming milliseconds to a UTC timestamp in Postgres

Rebasing on master...

Holding on merging this until 0.2.1 officially lands in MDS

MDS re-targeted this to 0.3.0

rebased on mds-0.3


Adding ML Cubes Examples

Hey @cassianomoraes, thanks for putting this together!
There are a few things we can improve:

The instructions contain some formatting errors

All of this should be a codeblock, but for some reason the ``` are getting ignored. This also happens multiple times in most of the other pages submitted.
I think it's a good time to revise the instructions that I wrote some time ago. @hasan7n, @AlexanderGetka-cbica, @sarthakpati and @cassianomoraes, we all have different levels of familiarity with MLCubes and medperf. Can you guys give them a try and see if they can be improved?
Some instructions make sense in the context of the mlcube examples repository, but when moved into mkdocs they're ambiguous. For example, there are instructions for "cloning the repository", without specifying which repository. We need to make these instructions more explicit. @hasan7n @AlexanderGetka-cbica @sarthakpati @cassianomoraes if any of you tries to follow the instructions, please note any ambiguity so we can work it out.


SwiftUI Scrolling glitch

I have a scrollview-lazyvstack inside of the page view, when you scroll up, the scrollview glitches repeatedly at the top. Any idea on what could be causing this?
https://user-images.githubusercontent.com/85640211/211188368-bd922c34-bbd3-45fa-b296-707b0c09cdd3.mov

Unrelated to this amazing package, thank god.

I have the same issue, when I append new items into the array of the scrollView inside the Page, it scrolls to the top. Seems like the whole page refreshes again.
Page { state in
        crushBacksPageHeaderView(state)
      } content: {
        List {
          ForEach(viewModel.crushBacks) { crushBack in
            let crushBackCellViewModel = CrushBackCellViewModel(matchButtonPressed: onMatchButtonPressed(_:), notInterestedButtonPressed: crushBackNotInterestedButtonPressed(_:), viewDetailButtonPressed: onShowingCrushBackDetailView(_:))

            CrushBackCell(crushBackModel: crushBack, viewModel: crushBackCellViewModel)
              .cornerRadius(15)
              .background {
                RoundedRectangle(cornerRadius: 15)
                  .stroke(Color.gray.opacity(0.5), lineWidth: 1)
              }
              .listRowSeparator(.hidden)
              .listRowBackground(Color.clear)
          }

          Button(action: loadMore) {
            Text("Load more")
              .multilineTextAlignment(.center)
          }
        }
        .padding(.top, -12)
        .refreshable {
          Utility.delay(1) {
            viewModel.crushBacks = CrushBackModel.mockData()
          }
        }

      }
    }
    .indicatorColor(.main)


No results for Teucrium pyrenaicum subsp. guarense

Hold on @dimus ... there is still something broken?
Why does this similar example not return any names?
http://verifier.globalnames.org/api/v0/verifications/Teucrium%20pyrenaicum%20subsp.%20guarense?data_sources=196%7C197%7C198%7C158&all_matches=true

Perhaps you only corrected it for matching fuzzy species names, but not infraspecies?

But even with that explanation, there is some error in this json output.
Because if there is a names array item with a matchType different to "NoMatch", then that name item should contain be an array of results ... I think.

i.e., in this example array of names, the 1st one (NoMatch) shold contain no results ... but the 2nd one (Fuzzy) should contain them:
http://verifier.globalnames.org/api/v0/verifications/Dont%20matchme%20Ever.%7CTeucrium%20pyrenaicum%20subsp.%20guarense?data_sources=196%7C197%7C198%7C158&all_matches=true

I take the opportunity to ask about that.
My application broke with this name because it tries to parse an array of results whenever name[i].matchType != "NoMatch". Should I better do this in a different way?

http://verifier.globalnames.org/api/v0/verifications/Teucrium pyrenaicum subsp. guarense?data_sources=196|197|198|158&all_matches=true
should work correctly now
BUT I was trying to fix inconsistencies in API for search and verification and introduced a few backward incompatible changes
please read https://github.com/gnames/gnames/releases/tag/v0.8.0
please read


cannot compile serde_json 1.0.45

   Compiling serde_json v1.0.45
error[E0405]: cannot find trait `StdError` in module `serde::de`
   --> /Users/xin/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.45/src/error.rs:317:17
    |
317 | impl serde::de::StdError for Error {
    |                 ^^^^^^^^ not found in `serde::de`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0405`.
error: could not compile `serde_json`.

toolchain
active toolchain
----------------

stable-x86_64-apple-darwin (default)
rustc 1.40.0 (73528e339 2019-12-16)

It looks like serde_json now depends on serde => 1.0.100, which isn't reflected in Cargo.toml.

yep, it seems dependency serde is not updated to latest version.

You can fix this by running cargo update to update all dependencies. This happens when serde-json is added as a new dependency, and the existing serde isn't new enough. Ideally, this shouldn't happen, but managing old version dependencies can be hard with as many moving parts as serde has.


b40/b41 issues

b40 and b41 cannot clear my messages after being read the badge shows, and b40 cannot JB unless not in Airplane Mode.
Also other tweaks are not working.

You didn't fill out the bug report template and didn't follow the issue guidelunes. Close this issue and create a new one.

@cryptiiiic close this issue


Accept-Language not really working

const IMDB_LANG = 'en-US,en;q=0.9';
When I send a request I get response part on english, part on ukranian(here is my server).
Tried to set true in function $imdbList->getTitles(true);, but don't help.
Maybe somebody know how to fix it. Need pure english. Will be very grateful for the help. Thanks.

If this won't help, you'll most likely need a proxy or a web host in the US.

Thanks.


Add a mac specific note to the readme

I am just adding what was mentioned here:
https://github.com/sickill/stderred/issues/2#issuecomment-3134764

Thx!


Cannot install nuget package

below is the log:
Install-Package : Could not install package 'MetroRadiance.Core 2.1.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
At line:1 char:1

Install-Package MetroRadiance

- CategoryInfo          : NotSpecified: (:) [Install-Package], InvalidOperationException
- FullyQualifiedErrorId : NuGetCmdletUnhandledException,NuGet.PowerShell.Commands.InstallPackageCommand

Sorry, MetroRadiance supports only .NET 4.6 or later.

Nuget failing at 4.8.

Nuget failing at 4.8.

+1

https://github.com/Grabacr07/MetroRadiance/issues/33 has the solutions.


Formatter Failure

Formatter breaks logic in when formatting 50 000 lines of code, i got segfault memory acces violation and another bug when map does not even load. I think other bugs possible also.
Also fails and does not even reformat when formatting more than 100 000 lines.

It's an issue with parsing a JASS file into the syntax tree representation. I have an issue here for it: https://github.com/zach-cloud/JSyntaxTree/issues/7 that I'll get around to someday.
The syntax tree parses everything into a logical representation of that item, down to the function argument level. Unfortunately even that small representation of it still stores the value as a String, and eventually with 100k+ objects holding Strings, you get  a memory error. I think some level of caching could help. I'd also be interested in best practices implemented in syntax trees used by IDEs like IntelliJ, though I am really busy with work & private projects right now so this stuff has kind of taken a backseat right now.


Fix empty array slicing.

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 53.38983% with 110 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (906719e) to head (68677d5).

Files with missing lines
Patch %
Lines

src/libfuncs/array.rs
53.38%
110 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   80.67%   80.65%   -0.02%
==========================================
  Files         107      107
  Lines       29235    29307      +72
==========================================
+ Hits        23585    23638      +53
- Misses       5650     5669      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


There was an error parsing Gemfile: tried to create Proc object without a block. Bundler cannot continue.

On following Local Installation instructions and running rake secret according to .env in order to update APP_SECRET_TOKEN, I get:-

[!] There was an error parsing `Gemfile`: tried to create Proc object without a block. Bundler cannot continue.

 #  from /home/subhodeep/tech/apps/huginn/Gemfile:26
 #  -------------------------------------------
 #      # to include them, so we scope them to an unsupported platform.
 >      platform :ruby_18, &proc
 #    end
 #  -------------------------------------------

and the same on running bundle.
$ uname -s -r -v -m -p -i -o
Linux <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Aug 25 23:20:18 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
$ ruby -v
ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-linux]
$ gem -v
3.3.3
$ rake -V
rake, version 13.0.6
$ bundle -v
Bundler version 2.3.5

I apologize if I'm missing really obvious here, as I have absolutely no knowledge of Ruby.

Mark. I have the same question.

I also have the same problem.


collect fails because of unkown service s3control

Running the command python cloudmapper.py collect --account devAccount
Gives me the output bellow
* Getting s3control:get-public-access-block info
Traceback (most recent call last):
  File "cloudmapper.py", line 73, in <module>
    main()
  File "cloudmapper.py", line 67, in main
    commands[command].run(arguments)
  File "/Users/username/Projects/cloudmapper/commands/collect.py", line 371, in run
    collect(args)
  File "/Users/username/Projects/cloudmapper/commands/collect.py", line 227, in collect
    handler = session.client(runner['Service'], region_name=region['RegionName'])
  File "/Users/username/.virtualenvs/cloudmapper-WkZRcN-E/lib/python3.7/site-packages/boto3/session.py", line 263, in client
    aws_session_token=aws_session_token, config=config)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore/session.py", line 885, in create_client
    client_config=config, api_version=api_version)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore/client.py", line 69, in create_client
    service_model = self._load_service_model(service_name, api_version)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore/client.py", line 102, in _load_service_model
    api_version=api_version)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore/loaders.py", line 132, in _wrapper
    data = func(self, *args, **kwargs)
  File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/botocore/loaders.py", line 378, in load_service_model
    known_service_names=', '.join(sorted(known_services)))
botocore.exceptions.UnknownServiceError: Unknown service: 's3control'. Valid service names are: acm, acm-pca, alexaforbusiness, apigateway, application-autoscaling, appstream, appsync, athena, autoscaling, autoscaling-plans, batch, budgets, ce, cloud9, clouddirectory, cloudformation, cloudfront, cloudhsm, cloudhsmv2, cloudsearch, cloudsearchdomain, cloudtrail, cloudwatch, codebuild, codecommit, codedeploy, codepipeline, codestar, cognito-identity, cognito-idp, cognito-sync, comprehend, config, connect, cur, datapipeline, dax, devicefarm, directconnect, discovery, dlm, dms, ds, dynamodb, dynamodbstreams, ec2, ecr, ecs, efs, eks, elasticache, elasticbeanstalk, elastictranscoder, elb, elbv2, emr, es, events, firehose, fms, gamelift, glacier, glue, greengrass, guardduty, health, iam, importexport, inspector, iot, iot-data, iot-jobs-data, iot1click-devices, iot1click-projects, iotanalytics, kinesis, kinesis-video-archived-media, kinesis-video-media, kinesisanalytics, kinesisvideo, kms, lambda, lex-models, lex-runtime, lightsail, logs, machinelearning, macie, marketplace-entitlement, marketplacecommerceanalytics, mediaconvert, medialive, mediapackage, mediastore, mediastore-data, mediatailor, meteringmarketplace, mgh, mobile, mq, mturk, neptune, opsworks, opsworkscm, organizations, pi, pinpoint, polly, pricing, rds, redshift, rekognition, resource-groups, resourcegroupstaggingapi, route53, route53domains, s3, sagemaker, sagemaker-runtime, sdb, secretsmanager, serverlessrepo, servicecatalog, servicediscovery, ses, shield, sms, snowball, sns, sqs, ssm, stepfunctions, storagegateway, sts, support, swf, transcribe, translate, waf, waf-regional, workdocs, workmail, workspaces, xray

I suspect you did not install CloudMapper properly, as this indicates to me that you are using an older version of boto that doesn't know about s3control, which means you didn't run:
pipenv install --skip-lock
pipenv shell

I actually did, I followed the installation guide for MacOs exactly as its written.
$ pipenv install --skip-lock
Installing dependencies from Pipfile…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 11/11 — 00:00:03
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

Then
$ pipenv shell
Launching subshell in virtual environment…
bash-3.2$  . /Users/username/.virtualenvs/cloudmapper-WkZRcN-E/bin/activate

Then
(cloudmapper) bash-3.2$ python cloudmapper.py collect --account devAccount
And that's where I get the issue

Hmm, maybe you're running in a different partition?  Are you running in gov-cloud or China maybe?  CloudMapper support is minimal there as I don't have access to either of those partitions.

Not at all, I'm running on us-east-1
Le sam. 25 mai 2019 12 h 03 p.m., Scott Piper<EMAIL_ADDRESS>a
écrit :

Hmm, maybe you're running in a different partition? Are you running in
gov-cloud or China maybe? CloudMapper support is minimal there as I don't
have access to either of those partitions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/duo-labs/cloudmapper/issues/421?email_source=notifications&email_token=AABU6I7NJDWTICQBMS7FIRLPXFPNZA5CNFSM4HPUWPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWHUPQA#issuecomment-495929280,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABU6I7XLPF4YLZ5RVIMPI3PXFPNZANCNFSM4HPUWPPA
.

My best guess is still that somehow it's not using the expected boto3 library version.  Try this, from a pipenv shell, run python, import boto3 and print(boto3.__version__). That should print 1.9.145.
Your session should look like this:
$ pipenv shell
Launching subshell in virtual environment…
bash-3.2$  XXX/.local/share/virtualenvs/cloudmapper-rt_DstOG/bin/activate
(cloudmapper-rt_DstOG) bash-3.2$ python
Python 3.7.0 (default, Sep 18 2018, 18:47:22)
[Clang 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import boto3
>>> print(boto3.__version__)
1.9.145

Here is my output
~/Projects/cloudmapper => pipenv shell
Launching subshell in virtual environment…
bash-3.2$  . /Users/username/.virtualenvs/cloudmapper-WkZRcN-E/bin/activate
(cloudmapper) bash-3.2$ python
Python 3.7.3 (default, Mar 27 2019, 09:23:15)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import boto3
>>> print(boto3.__version__)
1.9.145
>>>

The only way I was able to able to make this work is by commenting all s3control instances, otherwise, it still throws the error even though boto3 version seems to be correct

Maybe the underlying botocore version is incorrect somehow?
You could try this, and this is the output I get.
$ python
Python 3.7.0 (default, Sep 18 2018, 18:47:22)
[Clang 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import botocore
>>> print(botocore.__version__)

Closing due to staleness. I believe the original issue was still somehow due to botocore not being on the correct version.


Player get more latency playing RTMP

PLPlayer get more latency when it get buffering state. How to make PLPlayer skip and play latest frame instead of playing old frame and get more latency.

PLPlayerOptionKeyMaxL1BufferDuration  the option indicate the latency.
Its default value is 2s。

Thank you


[BUG] Inheritance causes conflict index creation if children have different TTL indexes

Sorry for my poor English.
Describe the bug
Inheritance causes conflict index creation if children have different TTL indexes
To Reproduce
import asyncio
from datetime import datetime
from typing import Any

from beanie import Document, init_beanie
from motor.motor_asyncio import AsyncIOMotorClient
from pymongo import IndexModel

class Cache(Document):
    key: str
    value: Any
    update_time: datetime = datetime.utcnow()

class SearchCache(Cache):
    class Settings:
        name = "search_cache"
        indexes = [
            IndexModel([("update_time", 1)], expireAfterSeconds=3600)
        ]

class DetailCache(Cache):
    class Settings:
        name = "detail_cache"
        indexes = [
            IndexModel([("update_time", 1)], expireAfterSeconds=3600 * 2)
        ]

class ImageCache(Cache):
    class Settings:
        name = "image_cache"
        indexes = [
            IndexModel([("update_time", 1)], expireAfterSeconds=3600 * 3)
        ]

async def main():
    client = AsyncIOMotorClient("mongodb://localhost:27017")
    await init_beanie(database=client.test_db, document_models=[SearchCache, DetailCache, ImageCache])

    cache = SearchCache(key="search", value="test2")
    await cache.save()

    cache = DetailCache(key="detail", value="test2")
    await cache.save()

    cache = ImageCache(key="image", value="test3")
    await cache.save()

    client.close()

if __name__ == "__main__":
    asyncio.run(main())

These two collections were created:
> show collections
< Cache
  search_cache

Then it crashed:
Traceback (most recent call last):
  File "C:\Users\huang\PycharmProjects\pythonProject\main.py", line 57, in <module>
    asyncio.run(main())
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\asyncio\runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\asyncio\base_events.py", line 641, in run_until_complete
    return future.result()
  File "C:\Users\huang\PycharmProjects\pythonProject\main.py", line 42, in main
    await init_beanie(database=client.test_db, document_models=[SearchCache, DetailCache, ImageCache])
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\beanie\odm\utils\init.py", line 456, in init_beanie
    await Initializer(
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\beanie\odm\utils\init.py", line 89, in __await__
    yield from self.init_class(model).__await__()
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\beanie\odm\utils\init.py", line 426, in init_class
    await self.init_document(cls)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\beanie\odm\utils\init.py", line 328, in init_document
    await self.init_indexes(cls, self.allow_index_dropping)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\beanie\odm\utils\init.py", line 281, in init_indexes
    new_indexes += await collection.create_indexes(found_indexes)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\concurrent\futures\thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\collection.py", line 1865, in create_indexes
    return self.__create_indexes(indexes, session, **kwargs)
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\collection.py", line 1900, in __create_indexes
    self._command(
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\collection.py", line 272, in _command
    return sock_info.command(
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\pool.py", line 743, in command
    return command(
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\network.py", line 160, in command
    helpers._check_command_response(
  File "C:\Users\huang\AppData\Local\Programs\Python\Python310\lib\site-packages\pymongo\helpers.py", line 180, in _check_command_response
    raise OperationFailure(errmsg, code, response, max_wire_version)
pymongo.errors.OperationFailure: An equivalent index already exists with the same name but different options. Requested index: { v: 2, key: { update_time: 1 }, name: "update_time_1", expireAfterSeconds: 10800 }, existing index: { v: 2, key: { up
date_time: 1 }, name: "update_time_1", expireAfterSeconds: 7200 }, full error: {'ok': 0.0, 'errmsg': 'An equivalent index already exists with the same name but different options. Requested index: { v: 2, key: { update_time: 1 }, name: "update_ti
me_1", expireAfterSeconds: 10800 }, existing index: { v: 2, key: { update_time: 1 }, name: "update_time_1", expireAfterSeconds: 7200 }', 'code': 85, 'codeName': 'IndexOptionsConflict'}

Expected behavior
Cache collection is not expected (but actually it was created, I don't know if it's by design). There should be three collections: search_cache, detail_cache, and image_cache, with different TTL indexes.
Additional context
It works on v1.31.1, but fails on v1.15.3.

I think in that case it is better to subclass from pydantic.BaseModel rather than beanie.Document:
I.e. this
class Cache(BaseModel):
    ...

instead of
class Cache(Document):
    ...


Crasing in SwiftInjection

Hey,
at first it was occasional, now almost every other app build/start, I get crashes in SwiftInjection.swift

Could it be related to some unit test files are not building at this moment? I cann't figure out what could trigger this. Updated to latest version 4.10.3 and latest InjectionIII app too, didn't help.

Do you have "Enable TDD" selected? Are you wanting to use the inject test feature? If not you may want to try the new simpler version https://github.com/johnno1962/InjectionLite which no longer needs the app running.

I don't want to use inject test feature (didn't know it exists :D ), just main code injection. I just tried with Enable TDD with Injection app, same result, then removed the app, added InjetcionLite and also the same crash at the same place.

I have also fixed the unit tests, they build correctly now, but that didn't help anyway.

newClass should be the class you're injecting. What can you tell me about it? Is it a generic or inherit from one?

Yeah, it inherits from a generic one in this case that I just tried.
class SomeCoordinator: NavigationCoordinator<SomeRoute>

I've pushed a new branch generics-tests you could sync to which should avoid this problem. Let me know how you get on.

There is a different error now, I've tried with changes in the same class as before

I've pushed another commit avoiding the newly loaded class in this test. It's strange this hasn't been reported before.

Still looks the same, hope the error output helps

Your output helps a lot. Seems like your class doesn't inherit from NSObject anywhere so a lot of Objective-C run time capabilities like isSubClass: and superclass are not available. I'll have to look into what can be supported. Are you able to inherit NSObject somewhere to prove the theory?

Yep, it recompiles and injects ok now, but those classes are part of a library so I had to edit inside it. Anyway, now I at least know what are some additional caveats.

Yes, I imagine most people are injecting UIViewControllers where NSObject comes for free. Thanks for taking the time to report this. I'll see if I can replicate and find a solution but it might be tricky. Seems like I need to find an alternative for superclass and isSubclass not dependant on Objective-C.

Thank you for your work on HotReloading, still amazing with all the limitations!
Btw, the library in place was https://github.com/QuickBirdEng/XCoordinator so you can see there all the inheritance and from what they started so that you can replicate it.

Thanks, I chip away at the limitations as people report them. I've pushed another commit to the HotReloading branch which moves further away from the runtime apis. Are you able to do a quick check to see if there is anything else that your class trips up?

Pulled and tried again, still looks the same as the last crash

Are you sure you're refreshing the branch? It can't look the same as the code has changed. Try "Reset Package Cache" or "Update Package"

Yeah, you were right, I did update packages and clean build and now got different error

I've pushed another commit. I thought === would be safer but I've seen it fail before. Can you try f67d5a60b2616cb1f2f38305365d5723d0599fb7 please.

Aha, it seems to be working now! One thing I've noticed is that there are now lots of some gunzip/grep commands going on in the first recompile, but later it injects much faster.

Great, happy to hear it. The greps happen the first time you inject a particular file and after that it is cached in memory.  I've pushed another commit which uses the disk cache more if you want to try it. 811668041ed8cd63e7ad6552dab01919e569b211

Tried it, no big difference, but that's ok. Important thing is that now it works. Thanks

Strange, it should have remove the initial scan if you're injecting a file that you've injected before. I'll leave the change in as it should fail-safe and delete the cache entry if a compile fails. Thanks again for raising this issue. This has been one of the more useful ones! Removing those last vestiges of dependency on the Objective-C runtime was worth it. Let me know if anything else crops up otherwise I'll merge the branch later today.

Actually, it does improve compiling the first time, I guess I didn't apply the update properly again. After removing and adding the package, and clean build now I see it injects faster.

I wondered about that... The easiest way to flush the package cache and be sure you have the right version is to update the hash 2d4bffa00a07fd925369b120810e6fbd2117ae9f of the commit as you add the package. I've pushed another commit reverting to class_getSuperclass() which seems to be a generic-proof api. In the new version and you can now add a @objc func injected() method to classes that don't inherit from NSObject. See how you go.

I've merged and tagged this now as 4.11.0. If you could give it a try and let me know if there are any problems I'd appreciate it. Thanks again for taking the time to raise this issue and try the various versions!


Ros sharp close socket solutions

I have a question!
How can I solve the problem that Unity games sometimes crashed when I close the ros socket.

My OS is: Windows 10 Pro
My Unity Version is: Unity 2018.
My ROS Distribution is: ROS Kinentic 16.04
My Build Target Platform is: Windows

Here is my bug description:
I have been using the ROS# package for almost two years from the 11/2018. It has become a great contribution to my project by connecting the real robot with the simulated one in Unity.
Recently, I tried to close all the ros sockets in the current scene (before going to another scene) to reduce the lag/delays of the simulated robot in the game after scenes.
When I tried to close the socket using RosConnector.RosSocket.Close(), the lag/delays disappeared but the game sometimes crashed for some reasons.
The similar issue is #154. I figured out that updating ROS# package may remove this problem but we have been using this package (v1.3) for a long time. When I tried to replace it with a newer version (1.6), lots of errors came up and the configuration that we have been using, were lost.
I had to fix the problem by putting the v1.3 package back. So how do I solve this problem without updating or updating the package but still keep our configuration (since we got lots of subscriber/publisher and a robot in every scene).

Hi @MinhDangTG ,
ROS# v1.3 is from Sep 2018, two years ago. I strongly suggest updating to a more recent version, even if it takes time to update your custom scripts. Here is the list of changes since version v1.3: https://github.com/siemens/ros-sharp/compare/v1.3...master#files_bucket
Some further hints:

We already had Protocols at that time. You can try and use your own Protocol implementation or update the respective Protocol only.
Do the delays occur in both WebSocketNetProtocol and WebSocketSharpProtocol?
ROS# contains the sources of WebSocketNetProtocol. Here is the Close() method: WebSocketNetProtocol. Please feel free to adjust it to your needs.


(Tracker) ToDo's in the at_client sync unit tests

This is a base git issue to list out all the refactoring/enhancements that are identified during the analysis in the sync unit tests in the at_client.
Things to refactor/enhancements

[ ] Add a new method to verify if the client and server are in sync which returns an enum - https://github.com/atsign-foundation/at_client_sdk/issues/832
[x] Add description to the KeyInfo to add additional notes about the key - https://github.com/atsign-foundation/at_client_sdk/issues/833
[ ] Optimized sync process by skipping keys which have commitOp.Update and Commit.Delete and the keys are not synced to the server earlier (Enhancement Request).
[ ] Add validation to check if the key is an Invalid key before adding a key to the sync batch request.
[ ] Refactor the sync_service code to test the following scenarios:
Skip the sync process when any of the following conditions are met:
* When the sync is already running
* When there is no network
* Server and Client are InSync
* Sync request threshold is not met
[x] Update all the available metadata fields and assert - At the moment, there is a known issue where version and createdAt, createdBy and updatedBy fields do not show correct info. https://github.com/atsign-foundation/at_server/issues/1126

Things to discuss

[ ] At the moment, deleting a non-existent would add an entry to the commit log. Should we throw an exception and not add an entry to the commit-log?
[ ] Should we have a scenario on deletion and re-creation on the encryptionPrivateKey and PKAMPrivateKey
[ ] Need to figure out a way to pause sync to perform assertions (if that is even possible)
[ ] With TBB set to a key, when sync triggers and TTB of the key is not met, we still fetch the actual value from the keystore for the sync process (we do not return data: null to sync because that would cause the key with null value getting created in the cloud secondary). Is this fine?

The following issue, https://github.com/atsign-foundation/at_client_sdk/issues/832 is not a priority. Hence moved to backlog.


Fix SHA for pasystray.

I presume there's something about how github creates the .zip files such
that they can change SHA.
Please note: this is a very outdated version of pasystray---I don't know
if that's intentional, but perhaps a better strategy would be to update
it wholesale.

And, in fact, this now updates to the latest version of pasystray, which I've built and tested locally.

Use fetchzip.

Updated.

I'd suggest using fetchFromGitHub, which uses fetchzip but also abstracts out common things, so if issues arise in future we can fix (almost) all GH fetches in one place.

Thanks.


refactor(lane change): lane change class rework

Description
refactor lane change class so that it is more resemble to scene module manager
Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Evaluator test seems okay
https://github.com/tier4/pilot-auto/commit/cc281caf6a6d0dc7a95f6bd92aa5e95a84984f1e

@zulfaqar-azmi-t4 LGTM :+1:  I'll approve it after you resolve conflicts.


Add ES-browser build

This build is intended for users who want to use Redux in a browser with ES modules support. The build removes all references to process by assuming it is in a production environment.
Additionally, it does not transpile, as all browsers that have ES modules support also support ES2015+
This approach is similar to the one of Vue (https://github.com/vuejs/vue/pull/7110) which I have also been using with success.
Fixes #2907

Hey Tim, it's Tim 😄
I'm wondering if we can keep this in the es path, but output redux.browser.js or something like that.
What happens with symbol-observable in this bundle?

@timdorr Updated, PTAL :smile:

I'm actually mucking about with the babel and rollup configs right now. I'll have a conflict ready for you in just a second...

@timdorr Conflict should be busted :tada:

Hm, let me actually minify just like the minified umd build.

Cool. I renamed it to just redux.mjs for simplicity. Forgot about that extension.

Thanks for the quick review @timdorr ! Can't wait for the next release :tada:

@timdorr What is the ETA of a release of a new version of Redux which includes this PR?

According to ES modules support taken from here - https://github.com/babel/babel/blob/6b8261bbb7ebb8d2980cb30c3b3369678fd99835/packages/babel-preset-env/data/built-in-modules.json#L1-L11 and testing only desktop browsers quickly it seems that used object rest spread syntax in the es/redux.mjs is not supported in those verstions of Edge & Safari.
Depending on what the audience of this bundle is it might need to get adjusted.


Throw exceptions, not strings (or just use error())

As the title says, we should throw exceptions and not strings. Alternatively, if throwing generic errors of type ErrorException with a message, it's better to just use the error() function with the message as argument which does the same thing.
This also helps with formatting the error message correctly in the terminal. For example, when passing a path in read_input() omitting the trailing / the error message previously was:
ERROR: LoadError: "\"species\" directory is missing in the configuration input folder!\nPlease provide either a \"species\" directory at \"PATH/TO/MetaRange.jl/examples/static\" or provide a custom path to a directory with species data with a \"species_dir\" argument in \"configuration.csv\"!"

while after this fix it is:
ERROR: LoadError: "species" directory is missing in the configuration input folder!
Please provide either a "species" directory at "PATH/TO/MetaRange.jl/examples/static" or provide a custom path to a directory with species data with a "species_dir" argument in "configuration.csv"!

Is there a specific reason to do:
msg = "error message"
error(msg)

instead of
error("error message")

Just wondering. Looks good :) thanks a lot

Not really, they are functionally equivalent. It's just personal preference, especially when the message is long (spans multiple lines etc.). But it's only that, a preference.


[Task]: Cleanup XML of transform Kafka Consumer, Producer

What needs to happen?
Cleanup XML of transform Kafka Consumer, Producer
Issue Priority
Priority: 3
Issue Component
Component: Metadata

KafkaConsumerInputMeta.java
KafkaProducerOutputMeta.java


Check if type strains are being chosen for references

Mark them in the phylogeny if not only type strains are used.

This should be revisited when #113 is worked on


Can't get into Web Configurator

I'm shorting pin 27 of my Pi Pico to ground, re plugging the device, opening http://<IP_ADDRESS> but nothing is showing up. What am I missing?

I'm in. There is an error in docummentation. It was a button L2 ( GP17 ) not S2 ( GP27 )


Store the display value of a selected codelist entry in the datamodel

Description
Codelists are connected to checkboxes, radiobuttons and dropdowns and consist of a key/value pair. Today only the key is persisted when these fields are connected to the data model.There are however several cases where you would like to store the actual text displayed to the user as well in order to reference that field later in the form. This can be achieved today by doing an additional lookkup on DataProcessWrite, but this requires C# and extra complexity just for storing an already known value.
Additional Information
This should not be solved using a | (or other symbol) and store both values in the same field as this only pushes complexity further down the processing chain.
Blocked by: https://github.com/Altinn/app-frontend-react/issues/1175
Possible solutions:

Map the text value to data model
Allow components as data source for a text resource as this would allow for formatted values in texts.

Tasks
No response
Acceptance Criterias

[ ] Ability to configure a separate field for storing the text value of a selected codelist entry
[ ] Selected text value is stored in the selected field

One solution might be to have something like
{
    "type": "RadioButtons",
    "dataModelBindings":{
        "simpleBinding": "normal.store.of.key",
        "valueBinding": "additional.store.of.translated.tekst.shown"
    }
}

I agree with @ivarne, but I'll add that it feels a bit redundant to include the word binding everywhere. A simpleBinding seems to always mean that the value is bound as a string value, so in a way I think it should just be called string, or at the very least just simple, but it's easy to see in hindsight. For this new binding, I think we should use label as a key, as that's the term we use in option lists.
So:
{
    "type": "RadioButtons",
    "dataModelBindings":{
        "simpleBinding": "normal.store.of.key",
        "label": "additional.store.of.translated.tekst.shown"
    }
}

Yup, I think we should have both! The expression for looking up the display value of a component would be nice, but at the same time that display value might not be very machine readable. I think part of the point of having this in the data model is that it can be extracted and processed in backend code (or on the receiving end when the form is submitted).
One more thing Ronny reminded me about today: This probably requires us to map to more list-like structures in the data model. For a checkbox group, comma-separated option values might work, but option labels are far more likely to contain commas (as they are meant to be human readable). Making this work smoothly might require us to know more about the data model and store the display values properly (see #990).

Solution 2 is kind of possible now since #1341 . You can now get the formatted value of any component including the label of a selected code list using the new displayValue expression. So if the use-case is simply to display the formatted value of a code list in a text it can be achieved using:
{
  "textResourceBindings": {
    "title": ["concat", ["text", "selectedColor"], ": ", ["displayValue", "radio-button-component"]]
  }
}

Which would result in something like
Farge valgt: Blå

Putting this on blocked as I might have discovered a bug in the PATCH while working on this.
If you add an subtract a value in a list, and this ends up in the PATCH request we end up with this payload:

As you can see, value 4 was first deleted, but then we try to insert a value in the same position.
We end up with this response from backend:


riscv-none-elf-ld: -shared not supported

Description
While building the shared library (.so) for a risc-v based core, I am getting the following error reported by the linker:
riscv-none-elf-ld: -shared not supported
I want to know if the -shared option is supported by the toolchain. If not, is there any other way to create the .so file?
Versions
I am using the following version of the linker:
$ riscv-none-elf-ld --version
GNU ld (xPack GNU RISC-V Embedded GCC x86_64) 2.38
Copyright (C) 2022 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.

EDIT: Added gcc version that I'm using
$ riscv-none-elf-gcc --version
riscv-none-elf-gcc (xPack GNU RISC-V Embedded GCC x86_64) 12.1.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Operating System:
16.04.1-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux

I'm not planning to load the shared library on board. Instead, I'm planning to call the symbols/functions present in the shared library via a wrapper written in python.

... via a wrapper written in python.

Python? Do you have Python on the bare metal board?

I'm not planning to load the shared library on board

Regardless how you plan to invoke it, a shared library must first be loaded into memory and this requires lots of processing. This is the job of a dynamic loader. Do you have such a thing for your bare metal application?

Python? Do you have Python on the bare metal board?

We are using JTAG interface to access our board, and the JTAG interface is controlled via python script. The python script is just an interface to call underlying C functions.

... a shared library must first be loaded into memory. Do you have such a thing for your bare metal application?

Correct me if I'm wrong, but isn't that the job of the linker itself? It should get the definition of the functions present in the shared library and put that information in the generated executable/hex.
Let me know if you need more information.

Correct me if I'm wrong, but isn't that the job of the linker itself? It should get the definition of the functions present in the shared library and put that information in the generated executable/hex.

It isn't the job of the linker alone, you also need a loader. On Linux it is ld.so.
On bare metal I am not aware of such a solution. Some years ago I worked with a friend on an experimental dynamic loader for Cortex-M targets, but using it was quite complicated.
If necessary, I can enable shared libraries in the linker build scripts, but I recommend you build your application statically.

I understand what you are trying to say. Let me see if I can build the application statically. Closing this issue for now. Thanks for your response.

BTW, I checked the build scripts and I could not find any explicit options to enable/disable the creation of shared libraries.
Exactly the same scripts create the arm-none-eabi-gcc toolcahin that allows the linker to create shared libraries and the riscv-none-elf-gcc that does not.
I would say that the RISC-V team did not enable shared libraries for the bare-metal toolchain.


OperationContext

The OperationContext class is now a holder for:

Operation Id
RequestContext
SessionContext
TimeoutContext

The BindingContext interface has been simplified to only have an OperationContext getter. Elsewhere OperationContext is supplied down through the code so its accessible.
Note:

The Operation currently supplies the TimeoutSettings this maybe further refactored to be calculated at the OperationExecutor level (JAVA-5176).

Build: https://spruce.mongodb.com/version/6512f8efd1fe07c300f6df36/

New build: https://spruce.mongodb.com/version/651430781e2d17297de7c91e/

Closed - manually merged / folded and squashed.


Update getprops function

Codecov Report

Merging #6 (b88d326) into main (ec8a2c3) will increase coverage by 0.06%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%
==========================================
  Files           3        3
  Lines          65       66       +1
==========================================
+ Hits           62       63       +1
  Misses          3        3

Impacted Files
Coverage Δ

src/macro.jl
94.59% <88.88%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8a2c3...b88d326. Read the comment docs.


Add Snappers Facial Rig

SteamDB app page links to a few games using this
https://steamdb.info/app/668580/
Brief explanation of the change
Added a rule for Snappers Facial Rig

Atomic heart is the only app that uses this.


Auth update

I converted the authentication methods for both drivers to use Auth2.0 Implicit Authentication Flow. Currently the Thingiverse driver is running off of a new app that I generated. I can either publish that app or delete it and you can put the new client id in the settings file. Just let me know which you'd prefer. As a note, I did see that there is an OAuth2 plugin built with Cura, but it seemed to be more geared towards the way that Ultimaker does its authentication and broke from the logic that I needed for this. I did borrow some code from there and if you really want to, we could possibly just extend those objects/inject our own callbacks/handlers into it. I tried that already but it became a bit more work and I wanted to try making my own Local Auth Server anyway.
By the way, this bypasses the authentication issue that even the Thingiverse android app is having with their API! :)
Thanks!

Great work! I'll review this more in-depth over the weekend and merge it. Any minor changes on it I can do while reviewing.

I have rebased the PR to https://github.com/ChrisTerBeke/ThingiBrowser/pull/50 and made some improvements. I'll merge that soon and have a look at the credentials.


Segfault - null ptr deref in what appears to be strdup

react-native version : 0.48.1
jsc installed via    "jsc-android": "^216113.0.2",  in package.json
This app starts and runs in iOS just fine, and also in the debugger,  but it was failing on Android due to a lack of real Uint8Array. That's why we were hoping to upgrade jsc.
Upon executing via react-native run-android  I get this error at startup.  I am presently attempting to build a debug version of the lib in order to get a better stack trace (any tips would be appreciated) .
However, I still wasn't able to get a better backtrace out of logcat.  Any tips would be appreciated.

Just remove this line https://github.com/SoftwareMansion/jsc-android-buildscripts/blob/master/common.sh#L139 to preserve symbols in the build. You can also replace -s with -g to include GDB debug information.
Note that installArchives also strips debug symbols, so if you are using it you have to run adb logcat |  $ANDROID_NDK/prebuilt/darwin-x86_64/bin/ndk-stack -sym . in a directory with libjsc.so copied directly from lib/distribution-?/jsc/lib/?/

Thanks.  I think it was that 2nd piece that I was missing.  I have encountered this trace on a few different occasions and the symptom went away when we fixed some type mismatch/coersion bug in javascript.   I wonder if a later version of jsc has found and fixed this.

ok.. here is the latest trace with the x86 so :
Stack frame #00 pc 0001c7c2  /system/lib/libc.so (strlen+18)
Stack frame #01 pc 00084360  /system/lib/libc.so (__strlen_chk+32)
Stack frame #02 pc 000731aa  /system/lib/libc.so (strdup+42)
Stack frame #03 pc 008ef58c  /data/app/com.mobilemessenger-1/lib/x86/libjsc.so: Routine formatLocaleDate at /bitrise/src/target/webkit/Source/JavaScriptCore/runtime/DatePrototype.cpp:255 (discriminator 1)
Stack frame #04 pc 008ea291  /data/app/com.mobilemessenger-1/lib/x86/libjsc.so: Routine formatLocaleDate at /bitrise/src/target/webkit/Source/JavaScriptCore/runtime/DatePrototype.cpp:316
Stack frame #05 pc 008ea0e4  /data/app/com.mobilemessenger-1/lib/x86/libjsc.so: Routine dateProtoFuncToLocaleString at /bitrise/src/target/webkit/Source/JavaScriptCore/runtime/DatePrototype.cpp:582 (discriminator 1)

This seems to directly indicate that somewhere in our libraries we are using dateLocale operations and should therefore use the icu build.   Interesting that it was able to get to this point in the code, though, I would have guessed that HAVE(LANGINFO_H) would have been false.

pointing android/app/build.gradle to the ICU build as prescribed in the README did remove the crash.  It might be worth either documenting that toLocaleString() might crash in the documentation, or figure out how to actually make it work like toString in all cases.  I can try to provide some help there if needed.


Custom Resource Array values exported to the inspector show as null on running project

Godot version
Godot 4.0 beta 9, Godot 4.0 beta 10 (Pre-Release)
System information
Windows 10, GLES3, RTX 3060Ti
Issue description
This is how it is in the inspector. I've assigned the 4 values:

But this is what is shown in console when I print the values:
[<null>, <null>, <null>, <null>]
One more thing to mention is I gave a setter function that is resizing the array to have a specific size:
func _validate_suits(value: Array[SpellSuitData]) -> Array[SpellSuitData]:
	if value.size() != total_suits:
		value.resize(total_suits);
	return value;

But even if I remove the setter function, the printed array is empty.
Steps to reproduce

Create an Array of a custom resource and export it to the editor.
Assign resources to it.
Run the project and print it in the ready function

Minimal reproduction project
N/A

Duplicate of https://github.com/godotengine/godot/issues/62916.


Package true/punycode is abandoned, you should avoid using it.

Description
The true/punycode github is archived, and no longer maintained.  A replacement is suggested at:
https://github.com/symfony/polyfill-intl-idn

+1 one this. I have just removed true/punycode dependency from my project. Later it came back as third party dep when I needed to make some whois queries.

+1 on this, I really don't like having abandoned packages

I can check it later. Maybe will fix it by myself..

Merged


Hide scroll bar

Description of the new feature/enhancement

The scroll bar is mostly unnecessary for me when working and slightly distracts from the complete full screen experience. Terminal should obey the "Automatically hide scroll bars in Windows" setting from the display control panel and hide the scroll bar at least when not being used, if not always.
Proposed technical implementation details (optional)

I would appreciate the ability to completely hide the scroll bar and just be able to scroll using mouse scroll wheel/touch pad.

You should look into scrollbarState in the settings schema. Does hidden seem like what you’re looking for?

Doesn't work for me. Even after doing:
"scrollbarState": "hidden"
the config file ignores it and maintains the visible state
I've tried setting up globally and locally (on my profile). Same result.

Even after relaunching? It’s a profile specific setting but in 0.9 it doesn’t hot-reload.

The behavior was the following: the original pane would have the scrollbar and the consequent panes, after spiting, would behave as expected.
Closing the original pane before the others and relaunching the terminal fixed for me. Now even the original one behaves as expected.
Weird behavior but I think it's not very common since apparently I was the only one having it (judging by Google results).
Thanks for taking the time to answer.

Any solution yet? I want to remove the scrollbar, the setting dose not work at all
"scrollbarState": "hidden"
Windows Terminal Preview
version: 1.5.3242.0

@sweihub where did you put that setting?

put "scrollbarState": "hidden" in profiles-defaults block, it works for me
{
    "profiles":
    {
        "defaults":
        {
            "scrollbarState": "hidden"
        }
    }
}

😳 Acknowledging rookie move: If you're like me and searched through the registry and powershell cmdlets and custom windows terminal themes ("scrollbarState": "visible") so it wouldn't auto-collapse.... it's right in:
Windows Settings -> Ease of Access -> Vision (Tab Group) -> Display (Tab) -> Automatically hide scroll bars in Windows = Set to false/Off
Note:
If there are some theme options I'm missing to configure the Windows Terminal scroll bar's collapsed width size, expanded width size, set to preview (like VS Code), please let me know.

put "scrollbarState": "hidden" in this block, it works for me:
{
    "profiles":
    {
        "defaults":
        {
            "scrollbarState": "hidden"
        }
    }
}

@simonla @DHowett
Now it works, thank you guys!

Personally I dislike the decision of obeying "Automatically hide scroll bars in Windows" setting from the display control panel. When turned on, Settings UWP app looks much clunkier. Why not just add separate setting for the app - always, auto-hide and never? Why make people go search through "Ease of access" menu setting?

@vserdyuk Uh, there are already Terminal-specific settings for this?
https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#scrollbar-visibility
always was added in #14047 which is shipping in 1.17 (https://github.com/MicrosoftDocs/terminal/pull/593 may have been pre-emptively merged to the published docs...)

@zadjii-msft Thank you for pointing to this, glad to know that there is a fix and it will soon be released!

Hello all,
Thank you for working on the scrollbarState in the the schema. I still have a problem that I would like to confirm with everyone. There is still some space horizontally in full screen mode. Here is an example showing tmux bar:

While the terminal window is not in full screen mode, there is no space noticed:

Does anyone experience this ? Sorry for jumping into this issue

@rfc2119 You mean that tiny black space at the bottom of the window? If that's what you're talking about, the reason is basically this: when the window is windowed, it can "snap" to the size of a character, so that there's no leftover space in the window. The window is exactly a multiple of the character size (+ the titlebar, etc). However, if the window is maximized or fullscreen, then the window can't be snapped exactly to the character grid. It's instead snapped exactly to the size of the display. Hence the tiny bit of padding - something has to fill those last few pixels.

@zadjii-msft Understood. Thank you for the explanation and your quick response. I can live with that.


Standardize CHANGELOG format

https://github.com/signalwire/signalwire-node/blob/master/packages/js/CHANGELOG.md

Duplicate.


Lime-104, Issue 96: credit line liquidation

Description
Stacked pull request on #173
It is intended that if a credit line has autoLiquidation as false, then only the lender can be the liquidator (see docs here: https://docs.sublime.finance/sublime-docs/smart-contracts/creditlines). However, this is not correctly implemented, and anyone can liquidate a position that has autoLiquidation set to false.
Even worse, when autoLiquidation is set to false, the liquidator does not have to supply the initial amount of borrow tokens (determined by _borrowTokensToLiquidate) that normally have to be transferred when autoLiquidation is true. This means that the liquidator will be sent all of the collateral that is supposed to be sent to the lender, so this represents a huge loss to the lender. Since the lender will lose all of the collateral that they are owed, this is a high severity issue.
Integrations Checklist

[ ]  Have any function signatures changed? If yes, outline below.
[ ]  Have any features changed or been added? If yes, outline below.
[ ]  Have any events changed or been added? If yes, outline below.
[ ]  Has all documentation been updated?

Changelog

Added a require statement to the liquidate function in the CreditLine.sol contract(Issue 96: credit line liquidation
Ref: https://github.com/code-423n4/2021-12-sublime-findings/issues/96)

Event Signature Changes
Function Signature Changes
Features
Events

Codecov Report

Merging #174 (0ac8ead) into lime-109 (896c08b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           lime-109     #174      +/-   ##
============================================
- Coverage     15.96%   15.95%   -0.01%
============================================
  Files            16       16
  Lines          1735     1736       +1
  Branches        321      322       +1
============================================
  Hits            277      277
- Misses         1458     1459       +1

Impacted Files
Coverage Δ

contracts/CreditLine/CreditLine.sol
9.82% <0.00%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896c08b...0ac8ead. Read the comment docs.


Make BigTable partition size configurable

BigTable is hardcoded to use 4 billion-sized partitions based on the timestamp. While this value can't really be changes for an existing cluster, it is something that should be configurable for new clusters.
As part of this, we should have documentation for how to reason about what a good partition size is based on the expected usage.

Currently for Bigtable the partition period is set to 0x100_000_000L; which roughly equates to ~50 days of values contained in a single row.
This value made more sense when Spotify had datacenters and servers that rarely changed as its more efficient to fetch a single row.
When Heroic started supported resource identifiers to be used for monitoring gke containers that have a higher churn rate this partition causes us to scan over a very large range. Most of the rows being returned are empty since the 75% of gke containers are less than 7 days old and 57% are less than 1 day old. This could be made more efficient by lowering the partition to a lower value.
Looking at the time ranges users are search for the top ones in order are...

60 minutes
3 hours
24 hours
7 days


Rename the current template to XML

Why
The template currently consists of both XML & Compose.
For the sake of simplicity, we will have a separate template for XML and another one for Compose.
Acceptance Criteria

Rename template to template-xml
Change package name to co.nimblehq.template.xml
Update app name to Template XML
Update the workflows for template-xml
Update new_project.kts so it still works correctly

Note: Removing the code of Compose will be done in a different issue (#334)

Create new folder template-xml copied from template
Change package name to co.nimblehq.template.xml and adjust (AndroidManifest.xml, applicationId, ...)

@Tuubz @Wadeewee  I'm wondering if we follow this way, we will lose all git history from what we contributed into the current template folder. Should we rename template to the new template-xml instead? This way does not actually destroy the history & not require the next task #334 to remove what we just cloned (Compose).

Good point @luongvo 👍 So, If we have a plan to remove template and use template-xml instead I think renaming way it  could be better than copy and remove the previous one then we can keep git history 🤔

@luongvo @Wadeewee I have updated the issue 🚀
However, I still believe we should do it in two pull requests (clone first, then remove)
IMO, if we do it in two pull requests it will be clear to see what files of compose are being removed from template-compose.
(Ex: Base classes, dependencies, other gradle configurations, ...)
What do you think? 🙏

@Tuubz lgtm +1


Reusing linkify-it instances

Instantiating linkify-it is relatively expensive, this becomes a bit of a performance issue when instantiating markdown-it itself multiple times, as a new instance of linkify-it is created for each.
This is what we want if we want to customize linkify-it for each markdown-it instance, but if we want it to always behave the same way it should be possible to reuse an existing linkify-it instance.
I propose to add support for passing a pre-instantiated linkify-it instance as the linkify option.

This does not looks like sample from real wold, and i don't like polish code just for fun. Do you have example when this is really required and creating cache of some markdown-it instances is not enougth?

Kind of, in notable I have a markdown-it instance used for rendering notes, which has a set of plugins enabled, and another markdown-it instance which I use for actually stripping out HTML and Markdown markup, which has another set of plugins enabled.
In the second instance I don't really need linkify-it though, ensuring it doesn't get instantiated https://github.com/markdown-it/markdown-it/issues/578 would be a better option for my particular use case.

That doesn't look as example of "really required". What will change if you app will be initialized 2ms faster?

What will change if your app will be initialized 2ms faster?

I've answered this here, basically I think every millisecond matters, 2ms here and there add up to something significant.

Closing in pair with #578. Let's return to this after several months, when you collect more data from real product, why this is critical chain.


I was wondering if you can provide a choice, that I can choose one of sub module to build the docker image?

MVN 3.5.2:

Jib version: 1.12.0
Build tool: Maven 3.5.2
MAC OS:

Description of the issue:
This is not an issue...
Expected behavior:
For example, I have three modules in a maven project. I make the configuration at the parent pom.xml. It'll affect in every sub module and all of them will be built in to a docker image.
I just want to build only one of them, but I want make the config at the parent pom.xml.
Just like this:
trade
-- trade-api
-- trade-server
-- trade-biz
I want to build a docker image just happen in trade-server build phase.

Hi @playingjoker.  I can think of a few ways to accomplish this:

put your Jib plugin configuration for each module within separately-named profile (mvn -Pjib-build-api ...)
use the jib.skip property with a separate value for each module (mvn -Djib-build-api=true ...).

There's also an internal property jib.containerize which is the dual of jib.skip — it specifies the coordinates or locations of the Maven modules to build (mvn -Djib.containerize=trade-biz ...).  Note that it's internal and may change without notice.

Also, if you're not familiar with profiles, this gives a good overview on how you might implement what @briandealwis described in their first suggestion: https://maven.apache.org/guides/introduction/introduction-to-profiles.html

I think this answers your question. Feel free to give us feedback.


Investigate 'gh-pages' package instead of Travis deploy

I saw the gh-pages libraries mentioned in a Redoc-related issue for use with publishing rendered docs to GitHub Pages. Using the package might be safer / easier to control than the blanket pages deploy with TravisCI (and would also be more build system agnostic).

@jaeddy I propose instead to publish documentation to gh-pages using GH Actions as part of the CI/CD workflow. We could use the solution that I used for the NLP Sandbox Schemas repository.


aws.yml

I'd show paid user restored new divice

tag:github.com,2008:/ashiqe26

Private Feed for ashiqe26
2019-08-08T10:05:25-06:00

I think you opened this by mistake


Add style and phrasing nitpicks

Just had some small grammar and wrap nitpick
Thanks for putting this section together btw -- good summary.
@jeanlaurent @dgageot PTAL
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

LGTM


Using synchronous reqwest from a synchronous handler causes a panic

... with the message "attempted to run an executor while another executor is already running"
It seems like tower-web should run synchronous handlers without a running executor, possibly using threadpool::blocking and executor::exit?

We've hit the same problem.

attempted to run an executor while another executor is already running


System.NotSupportedException about encoding when opening .xls file

Hello,
I'm using the 3.0.0-develop00086 version of ExcelDataReader in a .NET core project to open an XLS file generated by a web API. However, I've got the following exception when creating the reader :
Exception thrown: 'System.NotSupportedException' in System.Private.CoreLib.ni.dll ("No data is available for encoding 1252. For information on defining a custom encoding, see the documentation for the Encoding.RegisterProvider method.")
I've tried using the FallbackEncoding property but without success. Is there a way to read this file ? Send me an email if you wish to have the XLS file, I cannot share it publicly.

Hi,
Before using the reader from a .NET Core application, I believe you need to add a dependency on the "System.Text.Encoding.CodePages" Nuget package, and then register the codepage provider in the application initialisation code (f.ex in Startup.cs):
System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);

The error message you see comes from when ExcelDataReader initializes the FallbackEncoding property internally, but fails on .NET Core because the codepages aren't registered by default.
This should be documented in the README, or fixed if possible! The codepages stuff is a difference in .NET Core from the full framework I have not looked too much into yet

@andersnm this solution is correct, thanks you ! Adding System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance); in Startup.cs does solves the problem. Maybe adding a .NET Core part in the README or throwing a more explicit Exception could solve this ?


Not support UUID or another string key type when use queued

The finished event allow to use only int as a user id.

Thanks. I'll have a look at it with the next release.


Treat most worker task failures as a reason to mark the associated node flaky.

The semantics of FAILED and BADREQUEST weren't working well in the scheduler code where we need to mark nodes as flaky depending on what went wrong. FAILED should mean that we had an internal error and BADREQUEST should mean that the user did something wrong.

Codecov Report

Merging #291 into master will decrease coverage by 0.01%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   59.25%   59.24%   -0.02%
==========================================
  Files          90       90
  Lines        6983     6991       +8
==========================================
+ Hits         4138     4142       +4
- Misses       2541     2545       +4
  Partials      304      304

Impacted Files
Coverage Δ

runner/status_rw.go
0% <0%> (ø)
:arrow_up:

sched/scheduler/task_runner.go
86.15% <100%> (+0.21%)
:arrow_up:

runner/runners/invoke.go
71.27% <100%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8a01e...e22ac07. Read the comment docs.


Accept Map<String, dynamic> in Hint class

:scroll: Description

Accept Map<String, dynamic> in Hint class

:bulb: Motivation and Context

Closes #1610
:green_heart: How did you test it?
Ran unit tests.
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

fyi I'm fixing the sqflite tests in another pr

@buenaflor I have updated SentryDatabase in sqflite so that CI is happy. We need to implement spans/crumbs for it though.

Sounds good, thx for adding the fix

The hint was added as <String, Object> to avoid passing null values, if null values are passed as part of the event, it will result in errors since the Java SDK uses thread safety maps and they don't accept null values.
An easy workaround for the user is to just do hint["mykey"] = myValue ?? "null"

@marandaneto Thx for the reminder, I should have documented that in the class. I guess right now we also might have this issue if users pass maps, which in turn have a map as a value, containing null values?

What about handling the null cases directly in the SDK? This way it will at least remove the need for any further docs or explanations to users if this ever comes up again.

@marandaneto Thx for the reminder, I should have documented that in the class. I guess right now we also might have this issue if users pass maps, which in turn have a map as a value, containing null values?

Nope, nested maps are fine because they are not converted to ConcurrentHashMap.

@marandaneto @buenaflor If nested maps are no issue we can check for null and then do the string "null" fallback and also log a warning to users.


cephadm-adopt: use named args in rgw export creation

In order to avoid breaking changes, let's use named argument
instead of positional argument syntax in the command line
used to create rgw export.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2037691
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-container-cephadm_adopt


Increase ComposeBox zIndex to overlay unread notice

A recent merge undid an important change in zIndex of ComposeBox which results in unread notice to overlay ComposeBox. This PR undoes that change

I suggest you rework it a bit: if you put the notice inside the MessageList it will never overlay the compose box and you will simplify the calculations (you can remove the 'if a compose box is shown' logic).
For 'bottom' and 'top' position property, I also think you can remove it. If we decide to add it to the top, we'll place the other in the MessageList, but on top with likely a bit of different styles.

Sounds doable. Also, just to be sure that we really want to move UnreadNotice to MessageList including what we agreed on weeks ago -> https://github.com/zulip/zulip-mobile/pull/413#issuecomment-285042506

I think moving UnreadNotice to Chat.js makes more sense for consistency with OfflineNotice. Also, MessageList should really just focus on handling message rendering

Approving this small change and we can discuss what to do with UnreadNotice and OfflineNotice


Add "Use abbreviations" checkbox

Implement a checkbox to allow the user to show abbreviations if they are available in the data.
Also see design concept: #424
And Comment from Véronique in Gitlab pasted below: https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/439#note_9215

I now notice that the concept does not clearly say that the "use abbreviation" check box should also be available when choosing the dimension on the colour axis.
As the Screenshot in #424 only shows the use case on the x-axis, I prefer to make this clear here.
Please make sure that the check box is also available for the colours.

@bprusinowski Shouldn't it be the other way round in this example. Here when I check the abbreviations box I get the long labels. But I guess has to do how it is handled in the cube?
https://user-images.githubusercontent.com/59613691/205866900-fe28db90-bb77-4ed6-8876-a20baa716ea7.mp4


sign opentf manifesto

signing name to the manifesto

Added in https://github.com/opentffoundation/manifesto/pull/903


Ctrl+F in editor is only partially working, which is confusing

Describe the Issue
I saw this forum post: https://forum.freecodecamp.org/t/technical-documentation-page-build-a-technical-documentation-page/564364
It seems the camper is confused by the red highlight appeared in the editor.
And I found that I could replicate the red highlight similar to the one in the forum post by pressing Ctrl+F.
After some discussion with the dev team, it turned out that this is Monaco editor's "Find" functionality partially displayed. The highlight on the code is shown, but the Find panel on top right is hidden.
Affected Page
Any page with fCC editor
Steps to Reproduce

Open an editor on /learn
Enter some code
Place the cursor on any word in the code
Press Ctrl+F

Expected behavior

If we want to enable Monaco editor's "find" functionality, show the panel properly

If we don't, then:

Don't show the red highlight
We could also enable the browser's default search function with Ctrl+F instead?

Screenshots

Demo on https://microsoft.github.io/monaco-editor/

System

Device: Laptop
OS: Windows 10
Browser: Chrome
Version: 106.0.5249.119

Additional context
No response

Generally speaking we've kept it fairly simple, so that it's not overwhelming for beginners.  That said, this doesn't seem too much.
Having said all that, I don't know that we've deliberately disabled the search and I'm not sure how to enable it.

We do explicitly disable (hide) it:
https://github.com/freeCodeCamp/freeCodeCamp/blob/6f5b372f75a2f98818702d088c4e7bb62834c4a8/client/src/templates/Challenges/classic/classic.css#L14-L16

@sidemt I might be underestimating the challenge, but I assume the fix is as simple as unregistering (removing an event listener) Ctrl + F.

Thanks @ShaunSHamilton I'd forgotten about that ugly hack. I'm not surprised that it had unintended consequences, though.
Anyways, a slightly less ugly hack that we will probably need to use for now is:
editor._standaloneKeybindingService.addDynamicKeybinding(...

Hello guys, I'm new to contributing here.
Do you guys still need help for this issue ?

@CallmeHongmaybe I think this is resolved.
@sidemt now that https://github.com/freeCodeCamp/freeCodeCamp/pull/48241 is in, can we close this?

Alright glad to hear.


inv compile clang++ not found

Running inv compile --user=polybench --clean yields the following error:
CMake Error at CMakeLists.txt:2 (project):
  The CMAKE_C_COMPILER:

    /usr/local/faasm/toolchain/bin/clang

  is not a full path to an existing compiler tool.

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.

CMake Error at CMakeLists.txt:2 (project):
  The CMAKE_CXX_COMPILER:

    /usr/local/faasm/toolchain/bin/clang++

  is not a full path to an existing compiler tool.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "/usr/local/code/faasm/build/func/CMakeFiles/CMakeOutput.log".
See also "/usr/local/code/faasm/build/func/CMakeFiles/CMakeError.log".
Failed to compile

I'm not sure if this is supposed to be /usr/local/code/faasm/toolchain/bin/clang, but /usr/local/faasm/toolchain does not exist.
This is what I see in /usr/local/code/faasm/toolchain/bin/
/usr/local/code/faasm/toolchain master
❯ ls -al
total 44
drwxr-xr-x  3 sean sean 4096 Dec  3 11:57 .
drwxr-xr-x 28 sean sean 4096 Dec  3 16:54 ..
-rw-r--r--  1 sean sean  730 Dec  3 11:57 ClangNativeToolchain.cmake
-rw-r--r--  1 sean sean  827 Dec  3 11:57 env.sh
-rw-r--r--  1 sean sean 1881 Dec  3 11:57 FaasmToolchain.cmake
-rw-r--r--  1 sean sean    9 Dec  3 11:57 .gitignore
-rw-r--r--  1 sean sean    0 Dec  3 11:57 __init__.py
-rw-r--r--  1 sean sean 5264 Dec  3 11:57 Makefile
-rw-r--r--  1 sean sean  982 Dec  3 11:57 Makefile.envs
-rw-r--r--  1 sean sean 1171 Dec  3 11:57 python_env.py
drwxr-xr-x  2 sean sean 4096 Dec  3 11:57 sysroot_extras

Ah yes, you'll need to run inv download-toolchain. Adding to the benchmark docs.


Show "forked" on GitHub projects that are forks

The Cuckoo project here: https://bestpractices.coreinfrastructure.org/en/projects/1712
is a fork of the original project, not the original project.  That may be confusing to people.
Sometimes only the fork is the live project, so we don't want to forbid it.  However, it may be valuable to mark such things somehow.
One idea: If a project is on GitHub, and GitHub notes that it's a fork of a different project, show "[FORK]" after the name in the project list and project display. We can store that as a boolean value in the project, and a detective can determine that.  We probably want admins (but only admins) to be able to set/clear this value.
It wouldn't be hard to evade automatic detection.  E.g., just copy the files, and re-upload them.  But I don't see an easy way to deal with that, and it may not be necessary to do more.

The "less than a hundred stars" rule won't really work for smaller projects with less exposure. What about something like "the number of stars is smaller than one order of magnitude below the number of starts of the original project", as in the fork with less than 10 stars vs. the original repo with 100+stars.


Basic .htaccess/.htpasswd based HTTP authentication for the Apigility admin panel

The Apigility admin panel has to be protected ba a simple authentication. The files .htaccess and .htpasswd should be follow the global|local|dist concept (or something like this, what allows different authentication setting in different environments).

Rejected as effort for a needless purpose.

Rejected as effort for a needless purpose.


Adopt the OpenJS Foundation Code of Conduct

This includes:

Accepting the OpenJS Foundation Code of Conduct.
Agreeing on an escalation path with the OpenJS Foundation's CPC.
Updating existing CoC files to point to the Foundation's CoC.
Adding missing CoC files to the following repositories:

amp.dev
amp-by-example
samples
amp-readiness
amp-sw
amp-toolbox
ampbench
amppackager
amp-github-apps
amp-status
amphtml-build-artifacts
error-tracker
design-docs

Assigning to @nainar as the Code of Conduct WG facilitator.
/cc @ampproject/wg-codeofconduct

Blocked on https://github.com/openjs-foundation/cross-project-council/pull/271.

Does this issue also track accepting the approach for handling reports here: https://github.com/openjs-foundation/cross-project-council/pull/271/files#diff-812992e45f618c751cdf4843a6c93aa2
Or just the CoC?

Raised some concerns here: https://github.com/openjs-foundation/cross-project-council/pull/379#issuecomment-548496149

During the CPC meeting on November, 4 (minutes, the decision was made to postpone merging openjs-foundation/cross-project-council#379 until the feedback from the AMP CoC WG was accounted for.
A meeting between @nainar, @jorydotcom, @mhdawson, @joesepi, and @bnb was organized on November, 8. The outcome of which was a pull request against the Contributor Covenant itself: https://github.com/ContributorCovenant/contributor_covenant/pull/733.

Created a new PR to edit the Handling document on OpenJS as well: https://github.com/openjs-foundation/cross-project-council/pull/407

See summary of conversation with maintainer on Contributor Covenant Pull Request: https://github.com/ContributorCovenant/contributor_covenant/pull/733#issuecomment-603286973

Following our conversation in the Foundation Onboarding WG today, we noted that there were two possible options moving forward:

Maintaining a separate code of conduct from the rest of the foundation and not participating in the foundation-wide code of conduct panel (see https://github.com/openjs-foundation/cross-project-council/issues/469) and its related work.
Adopting the foundation's current code of conduct (Contributor Covenant 2.0) so that we can move forward with the onboarding process, and work with the foundation (and possibly the ContributorCovenant organization) to find  the right solution to move forward with the desired changes (see notably https://github.com/openjs-foundation/cross-project-council/issues/503).

The foundation onboarding WG did express a preference for the second option, but obviously can't make the decision by itself, so would love to hear your thoughts on this topic.

The CoC WG agrees that since the Open JS Code of conduct is happy to accept the edits and the open discussion is mainly finding how to make the changes we are happy to accept the CoC as is.
The plan of action if for us to change the AMP Code of Conduct to point to code-of-conduct.openjsf.org
@jorydotcom is also going to add the AMP reporting email address to the Open JS code of conduct too.

@nainar to sync with @mrjoro on updating all the repositories accordingly.

Should we update to the new Code of Conduct now, or wait until we graduate from the incubation phase?

Let's block on https://github.com/openjs-foundation/cross-project-council/pull/515 being approved and merged. As soon as it is merged, it's clear how to report issues and we can go-ahead.
Should we consider using this opportunity to change the email address used for reporting CoC violation to an @amp.dev email address?

Sounds good.  I've created a new mailing list on amp.dev (code-of-conduct@) and added the current wg-codeofconduct members to it.

Thanks, @mrjoro. Updated openjs-foundation/cross-project-council#515 accordingly.

I'm a little concerned about the pushback on openjs-foundation/cross-project-council#515 and the risk of that conversation dragging on.
There's an alternative option we could consider in the meantime and that would allow us to move forward with this right away and revisit once onboarded:

Simply update AMP's CoC with the content of the OpenJSF's CoC (this is what node.js does for now).
Make sure every repo continues to point to it; a few were missing the last time I looked, see the list in the body of this issue.

I'll make sure this is issue is discussed in the next CPC meeting. I'll report on the outcome of that conversation in our next onboarding WG call and we can make a decision on how to move forward then.

To clarify taking this approach would have the Open JS code of conduct inlined in place of the current AMP CoC?
Works for me as an interim. Let's wait till the CPC meeting and see how that goes?

To clarify taking this approach would have the Open JS code of conduct inlined in place of the current AMP CoC?

Yes.

Works for me as an interim.

Awesome.

Let's wait till the CPC meeting and see how that goes?

💯

Created CoC files in all projects that were missing it.
Exception: https://github.com/ampproject/amp-by-example - it's a read only project.
Next step is changing the central CoC