Restarting network-manager.service breaks plasma-nm of running session

Issue description
When restarting network-manager.service (as done by nixos-rebuild switch) breaks the plasma-nm plasmoid of the running plasma session. I'm on 35C3 right now in case someone can help me debug this:

the network plasmoid vanishes from the system tray
restarting the plasma shell (killall plasmashell && plasmashell) brings back the icon, but not all previous working networking works again yet:

example: WLAN connection using WPA enterprise can't connect due tokernel: IPv6: ADDRCONF(NETDEV_UP): wlp3s0: link is not ready
NetworkManager[12408]:   [1545925864.8391] device (wlp3s0): No agents were available for this request.
NetworkManager[12408]:   [1545925864.8421] device (wlp3s0): Activation: failed for connection '35C3'
kernel: IPv6: ADDRCONF(NETDEV_UP): wlp3s0: link is not ready
kernel: IPv6: ADDRCONF(NETDEV_UP): wlp3s0: link is not ready
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: Do. Dez. 27 16:51:04 2018: Qt Warning: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: Warning: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"
xsession[1622]: "Keine derartige Schnittstelle »org.freedesktop.DBus.Properties« des Objekts im Pfad /org/freedesktop/NetworkManager/ActiveConnection/3"

*rough translation*: xsession[1622]: "No such interface »org.freedesktop.DBus.Properties« of object in path /org/freedesktop/NetworkManager/ActiveConnection/3"

at the same time, connecting to the WLAN network works through nmtui. But this program does not access the secrets store

Steps to reproduce

run a plasma session and connect to a network (preferably WLAN) using the networks applet with NetworkManager
sudo systemctl restart network-manager.service
see that the networks icon is gone from the system tray
killall plasmashell && plasmashell
see that the plasmoid is visible again, but connecting to a password-protected WLAN might now work

Technical details

system: "x86_64-linux"
host os: Linux 4.14.88, NixOS, 18.09.1814.33000fe7cab (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(root): "nixos-18.09.1814.33000fe7cab, nixos-unstable-19.03pre162671.44b02b52ea6"
channels(spiollinux): "home-manager-18.09"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Yes, this is quite annoying.

I guess we have 2 options:

do not restart network-manager.service at rebuild switch, at least if Plasma is enabled. This is the easiest option
try to encapsulate all depending services (kwallet and other stuff) as user services and restart them as well. This requires invesgating which services are actually involved in this bug

I would have expected the plasmoid to be robust to the service restarting, otherwise wouldn't this affect people using KDE in other distros who restart that service? Maybe they never do?

@michaelpj The plasmoids are not the real problem here: While you can get the back with a killall plasmashell && plasmashell, re-establishing connections still won't work in cases where these require some credentials (e.g. WLAN passphrase) or backend services (e.g. WPA enterprise).

Possibly this error: https://github.com/NixOS/nixpkgs/issues/51375, should be fixed by https://github.com/NixOS/nixpkgs/pull/51382

I'm affected by this as well.

do not restart network-manager.service at rebuild switch, at least if Plasma is enabled. This is the easiest option

I discovered this issue while working on a NixOS module to define NetworkManager connections, and it seems like needs a restart to pick up new connections, or at least a reload. Therefore I hope we can find a solution which works with restarting/loading the service.

This is probably an upstream issue. I landed here because I am having the same problem on a different distro but still plasma. It's more annoying in my case though because it seems that closing and re-opening the laptop lid effectively causes a nm restart. So I can only reconnect to wifi/VPN via nmcli until I log out of KDE and log back in.

I was just affected by this.


Add cross-network support to the watch module

Hi,
It'd be awesome if it was possible to get highlight notifications across networks.
E.g. I have my ZNC set up to connect to 5 networks and I'm only connected to my ZNC network A.
Then someone on network B could highlight me and I'd get a notification on my client that only is connected to network A, so I can know there's something going on and I can connect to network B.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1442867-add-cross-network-support-to-the-watch-module?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

This would be very helpful and this would probably mean user level module which would also help a lot.
It seems like I am just putting exact same config to all network instances or forgetting it and wondering why they don't work and returning to those sometime long time later.
The example would also help as my ZNC is on 8 networks and with phone I am on 4 (both numbers include BitlBee) and it's not entirely impossible that someone says something on some other network that I should be aware of or reply to.

What is currently the best way to handle the following situation?

Two clients: WeeChat & Communi Sailfish

Communi Sailfish doesn't support highlighting on anything else than nick

8 networks
Having alert for alternative nicks and specific words like !ops in addition to %nick% on specific channels?

I think this issue/user level *watch would make it easier and I think currently I would be forced to write rules to some text file and copy-paste it to all networks or to /allserv.
https://github.com/znc/znc/issues/965 would also be very helpful when phone is offline.

This comment might be useless, but possibly shows the issue more clearly.
dumps
chatspike
2015-09-09 14:52:10+0300 < *watch> ---------------
2015-09-09 14:52:10+0300 < *watch> /msg *watch CLEAR
2015-09-09 14:52:10+0300 < *watch> /msg *watch ADD *!*@* *highlight *%nick%*
2015-09-09 14:52:10+0300 < *watch> /msg *watch SETSOURCES 1 * !##Mikaela !NickServ !ChanServ !GroupServ
2015-09-09 14:52:10+0300 < *watch> /msg *watch ADD *!*@* *ops *!ops*
2015-09-09 14:52:10+0300 < *watch> /msg *watch SETSOURCES 2 #AceCoding
2015-09-09 14:52:10+0300 < *watch> ---------------

dereferenced
2015-09-09 14:52:10+0300 < *watch> ---------------
2015-09-09 14:52:10+0300 < *watch> /msg *watch CLEAR
2015-09-09 14:52:10+0300 < *watch> /msg *watch ADD *!*@* *highlight *%nick%*
2015-09-09 14:52:10+0300 < *watch> /msg *watch SETSOURCES 1 * !##Mikaela !NickServ !ChanServ !GroupServ
2015-09-09 14:52:10+0300 < *watch> ---------------

freenode
2015-09-09 14:52:10+0300 < *watch> /msg *watch CLEAR
2015-09-09 14:52:10+0300 < *watch> /msg *watch ADD *!*@* *highlight *%nick%*
2015-09-09 14:52:10+0300 < *watch> /msg *watch SETSOURCES 1 * !##Mikaela !NickServ !ChanServ !GroupServ
2015-09-09 14:52:10+0300 < *watch> /msg *watch ADD *!*@* *ops *!ops*
2015-09-09 14:52:10+0300 < *watch> /msg *watch SETSOURCES 2 ##abgilpqt+ ##Mikaela #weechat-fi #akunapu #znc

oftc
2015-09-09 14:52:11+0300 < *watch> /msg *watch CLEAR
2015-09-09 14:52:11+0300 < *watch> /msg *watch ADD *!*@* *highlight *%nick%*
2015-09-09 14:52:11+0300 < *watch> /msg *watch SETSOURCES 1 * !##Mikaela !NickServ !ChanServ !GroupServ

pirateirc
2015-09-09 14:52:11+0300 < *watch> /msg *watch CLEAR
2015-09-09 14:52:11+0300 < *watch> /msg *watch ADD *!*@* *highlight *%nick%*
2015-09-09 14:52:11+0300 < *watch> /msg *watch SETSOURCES 1 * !##Mikaela !NickServ !ChanServ !GroupServ
2015-09-09 14:52:11+0300 < *watch> /msg *watch ADD *!*@* *ops *!ops*
2015-09-09 14:52:11+0300 < *watch> /msg *watch SETSOURCES 2 #aktivismi #kaakko #piraattipulue #uutiset #transpiraatit

the first rule as you might see is in all networks with /allserv, but the optimal case would be
/znc loadmod --type=user watch
/znc *watch add * *highlight *%nick%*
/znc *watch setsources 1 * !##Mikaela !NickServ !ChanServ !GroupServ
/znc *watch add * *ops *!ops*
/znc *watch setsources 2 #AceCoding ##abgilpqt+ ##Mikaela #weechat-fi #akunapu #znc #aktivismi #kaakko #piraattipulue #uutiset #transpiraatit

as those channels exist only in one network or I am not in the other networks I wouldn't have to do so much work in all networks.

Looking from user side it wouldn't need small changes
2015-09-17 13:17:43+0300 < *highlight> -Euforia:#channel- Mikaela: blah!
2015-09-17 13:18:02+0300 < *highlight> <Euforia:#channel> Mikaela: blah!

would become
2015-09-17 13:17:43+0300 < *highlight> -freenode:Euforia:#channel- Mikaela: blah!
2015-09-17 13:18:02+0300 < *highlight> <freenode:Euforia:#channel> Mikaela: blah!

The only potential issue I see is having all watch notifications on all networks, but I wouldn't mind that so much, notify_connect has the same issue and I don't have problems with it either.


Using 1filellm open large git repository and generate prompts for LLMs

Hi, jimmc414. Thank you for a very nice application.
I'm running into a problem right now when dealing with large code repositories. When I'm dealing with small code repositories, 1filellm works great. But when I'm dealing with large repositories, I have a token overflow problem when interacting with LLM.
So how should we deal with large code repositories? Sending only part of the source code will affect the context. Now it seems that only Gemini 1.5pro can handle about 200m tokens, which is the upper limit.
Do you have any good suggestions?

Hi, thank you!   do you have an example repo I can use for testing?

Hi, LZING thank you! do you have an example repo URL I can use for testing?

Thx jimmc414, we are using the framework of this project. This project is quite large, and all ts and js add up to nearly 400M tokens. I think it should be divided into modules or folders to process.
The repo address is: https://github.com/backstage/backstage/tree/master

I was able to reproduce the issue.  However, it appears that the issue is that Github's API is timing out, not the python code.  If you download the entire repo locally then process the local folder, all 12 million tokens will process.  The fix for this would be to add pagination to the download, but that would come at a performance cost for normal size repos.  Given that the largest context window at present is 2 million tokens and this repo is a total of 12,000,000 tokens, the best solution would be to download repos over 2 million tokens locally and the will process without error.  Let me know if this doesn't work for you.


Description shows HTML tags

The first one, in the task list, will be fixed in the upcoming release. The one on the task edit page, however, isn't as easy, and since it's only a textfield I have to think about how to change it to properly display the html.


0.9.x branch

learn storm

@Taichidasheen is there a reason for this pull request?  If not could you please close it?


secretmanager: add initial samples

I also noticed there's some fun Koroko scripts that download secrets from GCS. Let me know if you'd like some help to migrate those to Secret Manager 😉

Also, CI is broken partly because of some dependency updates. I'm fixing that and plan to have that fix merged in a few hours. When you are done with the changes plese check that all your tests pass on CI.
As for updating the Kokoro scripts, I don't have a final answer to whether we need migrating those or not, but if you'd like to start another PR for that we can work from there. Your help would be really appreciated ;).

Hey @amanda-tarafa - I've made the requested updates. Once we get the samples reviewed and merged across all the languages, I'll take a pass at any libraries that have secrets and look into an update 😄

Hi @amanda-tarafa please re-review. There are unrelated (Leaderboard) tests failing. I don't see any tests related to secrets failing.

Secret Manager API has not been used in project<PHONE_NUMBER>775 before or it is disabled...

Can someone with permissions run gcloud services enable secretmanager.googleapis.com on the appropriate test projects please? @amanda-tarafa

Unfortunately I don't have permission to do this :( Amanda is back from vacation on Monday.

I also don't have permissions to enable APIs. @SurferJeffAtGoogle can you please take a look.

@sethvargo I'm shortly pushing a PR that will fix the Translate test that is failing.
The Logging test that is timing out is known flakiness, so that you can ignore, if it happens again, rerun CI by adding the kokoro:force-run label to the PR until is green. I'll fix the test sometime in the near future.
Also, I've asked @SurferJeffAtGoogle for ownership of the test project so I can enable the API.
Let me know if there are more issues you are running into.
When all is green let me know and I can take another look at the PR.

Hi @amanda-tarafa - I believe it's currently green for secret manager. From the build output
Starting .\secretmanager\api\SecretManagerTest\runTests.ps1...
-------------------------------------------------------------------------------
.\secretmanager\api\SecretManagerTest\runTests.ps1
  Restore completed in 2.09 sec for T:\src\github\dotnet-docs-samples\testutil\testutil.csproj.
  Restore completed in 11.76 sec for T:\src\github\dotnet-docs-samples\secretmanager\api\QuickStart\QuickStart.csproj.
  Restore completed in 11.88 sec for T:\src\github\dotnet-docs-samples\secretmanager\api\SecretManagerSample\SecretManagerSample.csproj.
  Restore completed in 12.11 sec for T:\src\github\dotnet-docs-samples\secretmanager\api\SecretManagerTest\SecretManagerTest.csproj.
Test run for T:\src\github\dotnet-docs-samples\secretmanager\api\SecretManagerTest\bin\Debug\netcoreapp2.0\SecretManagerTest.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.0.1
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
 Passed: 4. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 8.0770 Seconds

Hey @amanda-tarafa I believe I've addressed all your comments. PTAL


Advice: add "remember last order" feature for pop up copilot window

Currently, when using the pop up copilot with ctrl+i, it can't remember the last order.  In my case, I use a lot "format line by line", I hope every time except the 1st to use this order can be fast rechoosed by just pressing the arrow up/down key to switch the history order.

... the arrow up/down key to switch the history order.

I can be done via ctrl+up/down and since very recent it actually persists across editor sessions.
@dbsxdbsx What version are you using? Can you try vscode insiders?

... the arrow up/down key to switch the history order.

I can be done via ctrl+up/down and since very recent it actually persists across editor sessions.
@dbsxdbsx What version are you using? Can you try vscode insiders?

Thanks for your advice, with ctrl+up/down, it is workable.


Something went wrong notification

Description

Steps To Reproduce
Use the computer
Requirements

e.g. Fix crash that occurs when...

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3803
Log File
debug.log

Thanks for the report, Please add the steps to reproduce.

I put "use the computer" cause I was not doing something special, just navigating thru a folder, before and after the notification appeared. Yes, Files crashed and restarted. I'll be uninstalling so take a look at the log included.

I'm not seeing anything in the log regarding a crash but it's likely that it wasn't handled. Has this happened again or was it just once?

It happened once but I'm of no help as I had to uninstall the program cause
the drag files option was a nightmare.
On Mon, Jan 8, 2024 at 12:00 AM Yair @.***> wrote:

I'm not seeing anything in the log regarding a crash but it's likely that
it wasn't handled. Has this happened again or was it just once?
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14265#issuecomment-1880322564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEZ6PFGZBFNMVMHOSTRMKH3YNNOLFAVCNFSM6AAAAABA4E6FRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGMZDENJWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Please let us know if it happens again. Also, it might be best to open a new issue for this can can you share the issues you had with drag & drop?

How would I tell you if it happens again if I'm telling you I uninstalled
the program?
Also, I did open 1 for the drag and drop issue with details about it, check
all my tickets, maybe somebody closed it.
And please do not contact me for this app again. I tried it, didn't work
for me and reported issues but I'm not planning to get it again.
Thanks!
On Mon, Jan 8, 2024 at 1:32 AM Yair @.***> wrote:

Please let us know if it happens again. Also, it might be best to open a
new issue for this can can you share the issues you had with drag & drop?
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14265#issuecomment-1880372012,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEZ6PFAUSGYKO3RNETGT5XDYNNZELAVCNFSM6AAAAABA4E6FRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGM3TEMBRGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Implement text KeyValues 3

@yaakov-h Can you give this an initial review pass? I especially want to hear about stuff around handling arrays and flags.


[Compatible] HTTP/1.1 302 Moved Temporarily

Video address cdn sometimes occurs  http 302 state, whether it can be compatible

Whatever's compatible with the <video> element:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

What can be said to be more detailed? I do not really understand. thx

I'm not really too sure what the question is? Do you mean the Plyr CDN returns a 302? Or your video CDN returns a 302 and you're asking if the <video> element is ok with that?

source src：http://a.xxx.com/CourseWareMp4/15bbf4d9c2f6d2a5137aef03055e5042_sd.mp4
cdn http state 302   -->>
http://<IP_ADDRESS>/mp4files/4173000003137183/a.xxx.com/CourseWareMp4/15bbf4d9c2f6d2a5137aef03055e5042_sd.mp4
Lead to can't play.

Well that last URL doesn't load for me...

It doesn't seem like a Plyr issue so I'd make sure the video is in the correct format, is served with the correct content type and actually loads by itself. As I say, Plyr is just an abstraction for the <video> element so if it doesn't work with that, it'll not work with Plyr.

source url can not be played when redirected,I'm not sure if it's Plry.

No, it's not. Good luck fixing it! :-)

On 11 Oct 2017, at 6:29 pm, An0nymous<EMAIL_ADDRESS>wrote:
source url can not be played when redirected,I'm not sure if it's Plry.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


fix(manage-merge-queue): throw if github email not found

:pencil: Description

Jobs should fail if a slack webhook is being used with notifyUser() and a user's github email is not found

:tada: This PR is included in version 1.59.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ICSS export not working in CRA 4

Describe the bug
Exporting keys like this used to work in CRA 3 (react-scripts : 3.4.4) but when we upgraded to CRA 4 (react-scripts : 4.0.0) it stopped working.

After exporting, you can use it like this:

Did you try recovering your dependencies?
1.22.4
Which terms did you search for in User Guide?
export
ICSS
Environment
Environment Info:
current version of create-react-app: 3.4.1
running from /Users/you-haurliu/.config/yarn/global/node_modules/create-react-app
System:
OS: macOS 10.15.7
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 12.16.1 - /usr/local/bin/node
Yarn: 1.22.4 - ~/.yarn/bin/yarn
npm: 6.13.4 - /usr/local/bin/npm
Browsers:
Chrome: 87.0.4280.67
Firefox: 82.0
Safari: 14.0
npmPackages:
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-scripts: 3.4.4 => 3.4.4
npmGlobalPackages:
create-react-app: 1.5.2
Steps to reproduce

Use CRA and create a project
install node-sass as a dependency  to allow for scss files
Create a new file called colors.scssin the src folder
Add this block of code inside colors.scss

:export {
  primary: red;
}

import this file in app.js with import colors from './colors.scss'
Apply the style to any p tag
For example

<p style={{color: colors.primary}}>
      This should be red
</p>

The text should be red

But if you update react-scripts to 4.0.0 and delete the node modules and yarn lock. Then yarn and start up the server, the text is white and the colors object is empty.
Expected behavior
colors object should contain primary
Actual behavior
colors object is empty
Reproducible demo
Instructions are included in the link
https://github.com/justsolarry/test-cra

I confirmed the problem on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I confirmed the problem on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@justsolarry I've create a repository the share my investigations about this problem
TD;LR; the problem seems to come from a regression introduce by css-loader@4.
I will continue my research on this problem, and share here my progression.

According to @alexander-akait response https://github.com/webpack-contrib/css-loader/issues/1262#issuecomment-777387038
There is no current solutions to fix the problem without ejecting your app :(
I will propose soon a PR to support /\.icss\.(scss|sass)$/ pattern natively in create-react-app.

There is already a PR opened by @thabemmz to fix this issue.


⚠ ClamAV has degraded performance

In cc99774, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 198 ms

Resolved: ClamAV performance has improved in 123a96e.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4762

Questions ?
Please refer to the Backport tool documentation


Client and event input validation

Could use some input on this:
Currently the maximum length of someone's name is 750 characters (I googled)
and the maximum description name for an event is limited to 1200 characters.
Both numbers are quite arbitrary (and high), should I lower them?

If you want to, you could possibly limit the length of names to something more reasonable like 100 characters.
As for the description for events, that would depend on the intended usage of descriptions, but for display purposes, maybe something like 200 characters could be suitable so that it does not take up too much space on the GUI.
Some testing might be required to see how it would look on the GUI

Codecov Report
Base: 45.63% // Head: 45.26% // Decreases project coverage by -0.37% :warning:

Coverage data is based on head (dfb71d2) compared to base (d228827).
Patch coverage: 24.59% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     45.63%   45.26%   -0.38%
- Complexity      602      607       +5
============================================
  Files           152      152
  Lines          3186     3232      +46
  Branches        426      439      +13
============================================
+ Hits           1454     1463       +9
- Misses         1576     1593      +17
- Partials        156      176      +20

Impacted Files
Coverage Δ

...n/java/longtimenosee/storage/JsonAdaptedEvent.java
0.00% <0.00%> (ø)

.../java/longtimenosee/storage/JsonAdaptedPerson.java
70.78% <0.00%> (-14.35%)
:arrow_down:

...in/java/longtimenosee/logic/parser/ParserUtil.java
66.95% <27.27%> (-5.01%)
:arrow_down:

...in/java/longtimenosee/model/event/Description.java
57.14% <33.33%> (-12.86%)
:arrow_down:

...main/java/longtimenosee/model/person/Birthday.java
50.00% <33.33%> (+2.50%)
:arrow_up:

src/main/java/longtimenosee/model/event/Date.java
47.50% <42.85%> (-0.89%)
:arrow_down:

src/main/java/longtimenosee/model/person/Name.java
78.57% <50.00%> (-4.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Good point! I've added more input validation for phone number as well (and changed the display to show information row by row for person, and event, policy and assignedPolicy (@Ssatu you might wanna check whether everything's in order but it's just to toString() ).
Phone number range [3,25]
Name range [1, 100]
Desc range (for events) [1, 175]

If you want to, you could possibly limit the length of names to something more reasonable like 100 characters.
As for the description for events, that would depend on the intended usage of descriptions, but for display purposes, maybe something like 200 characters could be suitable so that it does not take up too much space on the GUI.
Some testing might be required to see how it would look on the GUI

Agree with this!


SCIM2 filtering using eq operator failed when username equals admin

use the IS 5.8 Beta 3
send the following curl request
curl -v -k --user admin:admin 'https://localhost:9443/scim2/Users?filter=userName+eq+admin'
it will give an error
this issue only occurs for the username admin
error:
{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error"],"detail":"Error in getting user information for user: admin","status":"500"}B

Fixed


NASA Challenge_[franklinselva]_[Restructure the contents of demos to be modular and scalable]

Depends on space-ros/space-ros#186
Fixes space-ros/space-ros#178

Merge queue no. 1

This PR restructures the contents of the demo (from space-ros/simulations, space-ros/docker, space-ros/demos) under a single tree. The main changes include

Add canadarm_description package for simulation assets of canadarm2
Add curiosity_description package for simulation assets of curiosity mars rover
Add gazebo packages for canadarm and curiosity rover demos
Add docker based entrypoints for canadarm and curiosity rover demos
Add makefile for easier building and running of candarm and curiosity demos

This PR also restructure the workflow of the past demo in such a way the GUI apps are ran outside the docker. The reason for this change is to adapt different simulation tools and have a reproducible demo across the simulation tools.

Note for reviewers: This is a large refactoring related to the referenced issue. I think it would be easier to review the work from clear slate. If there is any information needed, please let me know.

Hi @mkhansenbot, Thanks for your review. I understand the use of Makefile as a runtime dependency is odd that is not in favor. I will make a direct replacement of the makefile with the shell script to build, clean and run the demos.

Would you consider moving to either a docker-compose or Earthly build instead?

I would not go for Earthly builds for demo since this will also be an addtional runtime dependency for working with the demos. At the moment, Earthly builds are only used as internal tool within collaborators and the scope of the build tool doesn't need to be expanded beyond this point. As mentioned here in the issue, using docker-compose for show casing different demos supported by shell scripts would be an good choice in my opinion. This will ensure, we still have the required entrypoints to the demos.

I have replaced the Makefiles with the build.sh.
There are still few changes expected in the shell script based on #35. I will need to hold the queued PRs until this PR is resolved.

Thanks for consolidating the simulation assets into one repository! This is a much more straightforward package layout.

@mkhansenbot Can you approve the workflow for the CI run?


Sometimes there is no this, only window.

Fixes scenarios where the library is called with undefined this, yet there is a browser global window object.

:+1:

Personally I would prefer https://github.com/bebraw/libumd/commit/f43a331e7c484ed9c5696d4827d5b16a918ec3bb


I believe my filenames are compliant according to documentation for the prior version, but it's possible that I'm forgetting something; we've occasionally had problems getting captions to work with individual items with prior versions.
To Reproduce
Steps to reproduce the behavior:

Find an item with a video supported by the media viewer, and a .vtt caption/subtitle file with the correct naming conventions. For testing, I submitted a new item, uploading both files at on item creation. This item in the sandbox  may be deleted by the time you see this report, but I took the files from an item in our repository.
Start video playback
Enable captions (in this example English) in the usual fashion. In my case, there's a disclosure arrow on the right side of the playback controls. (I tested this on a Mac with Safari). The captions won't display, even after speech starts.

Expected behavior
I expected the text from the captions to be visible in, or immediately next to the media playback window.

Good afternoon @tdonohue!
We at Neki-it did a current test with a video with subtitles in Safari on MacOS and it worked perfectly (using DSpace 8).

Thanks @DanGastardelli for verifying this functionality works for you! In that case, I'll close this ticket as unreproducible.  (I'm not able to reproduce this issue in other browsers either)
If anyone else discovers a way to reproduce this in the future, we can always reopen this ticket as necessary.


Blocking subsystem calls

Introduces a wrapper over subsystem::Handle that blocks, so can be used without async. Not intended for merge yet, just filing a draft PR to gather early feedback.

I know this isn't over and it's in draft form still, but I wanna say it's looking good. I like the idea of an isolated struct that converts calls to sync. Though I wanna emphasize that async can look good and still lead to dead-locks when called in blocking mode. Let's try to scrutinize this as much as possible to make it impossible to get that.
One hint here too is that functional tests can help as an external software for testing. It's totally possible to have everything work fine here in unit tests, but then see dead-locks in functional tests. This, actually, happened with me once in p2p.


IGNITE-8737: Improve checkpoint logging information

BTW, I applied your patch to master branch and found out that there is no changes in CheckpointHistory class which uses truncate method.
Because of this I see compilation error in my code although TC passes just fine.
Could you check please what's going on with this class?


chore: Add async typeahead select to shared components

This PR adds stories of a shared async typeahead select which we want to use for resource prefix. The notable stories are

Creatable Text: When user types a value for a resource type(for e.g topic) that does not exist, an option to create "Value" shows up in the dropdown
Validtion: A number of stories sow the different validation error messages that can come up while typing a resource prefix value
Loading Suggestions: A story that depicts a loading spinner in the dropdown, for when we are waiting to resolve the promise from relevant api
Placeholder text variation: Depending on the prefix rule 'is' or 'Starts with' the placeholder changes,

This document was followed for providing validation rules to the stories
Where to find Stories
shared > AsyncTypeaheadSelect > AsyncTypeaheadSelect

Your updates look good!
There's an option with the typeahead select to allow the user to specify a new value and not select an existing value. The designs showing how we use this option are shown here: https://marvelapp.com/prototype/a5e2da1/screen/81950514
I think the prop you use to add this functionality is createText=[translated string for "Use"]
I also pasted the relevant portion of that design below:

Thank you for adding the "Use" option to the component. Looking at this again, the filtering doesn't behave as I would expect it to.
If I start typing, the value I enter should be matched wherever that value occurs in an option. For example, I see these options are available

If I type test, I no longer see the option "topic-test"

Should this behavior be represented in the storybook examples, or is that handled somewhere else?
One other question, I saw that this moved to the shared section, but these examples are all specific to the manage permissions modal. I'm just curious what the reasons are for that. I'm still learning how we're organizing components in our storybook.

@jgiardino  The filtering done here is handled automatically by PF Select, we have not added any custom filtering to this, which is why it does not filter 'topic-test' when we type 'test'. This behaviour can be changed by adding custom filtering.
We decided to add this to a shared component because of the nature in which typeahead suggestions are shown, even though right now it's only used here, we might need it in the future when we want to display suggestions in a typeahead that are fetched from an api call

:tada: This PR is included in version 1.30.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


idk

ERROR:root:A error has occured at 04:25:59 04
Traceback (most recent call last):
File "Martingale.py", line 24, in init
File "Martingale.py", line 392, in sendBets
File "Martingale.py", line 122, in getBalance
NameError: name 'cloudscraper' is not defined

go into cmd and type this following command "pip install -r requirements.txt"

run installer.bat


Suppress C# unused variable warnings when enable_testing is off

Fixes #3628

Merging as travis error is unrelated


feat: add footer

Footer element with sharing options and copyrights

Could you please add hacktoberfest-accepted label to my PR?

Here we go @ThPadelis  tysm for contributing 😄


50k from facebook!

https://github.com/facebookresearch/wav2letter/tree/master/recipes/mls

http://openslr.org/94


Fails to accurately print nonnumeric page numbers

Currently Hayagriva converts all page numbers to integers before using them in the bibliography.  This is a problem because many journals these days don't number their pages sequentially and include letters in the "page numbers".  Right now Hayagriva truncates nonnumeric letters, which leaves the citations incomplete.
For example, Review of Scientific Instruments issues each article it publishes a unique six-digit alphanumeric code and uses that in lieu of a page number.  See Rev. Sci. Instrum. 87, 11E201 (2016), which is article 11E201.  The pages of the PDF are numbered 11E201-1 through 11E201-7, and the autogenerated BibTeX file contains pages = {11E201}.  Putting this BibTeX file into Hayagriva truncates the page number to "11".
I think in general if pages (or page-range in YAML) is a string that doesn't contain dashes, it should print that string as-is rather than casting it to an integer and treating it as a starting page.
There's a similar issue with Physics of Plasmas, which uses fully numeric article codes but gives a lot of them leading zeros.  See Phys. Plasmas 29, 072711 (2022) (the pages of the PDF are numbered 072711-1 through 072711-13), which has its page number shortened to 72711 by Hayagriva.  The loss of leading zeros is not as bad as the loss of the alphabetical characters since there's at least enough information to find the article, but it's still nonideal, as the journal wants you to cite it with the leading zero BibTeX formats it with the leading zero.
Example YAML file:

bachmann16:
  type: article
  author: ["Bachmann, B.", "Hilsabeck, T.", "Field, J.", "Masters, N.", "Reed, C.", "Pardini, T.", "Rygg, J. R.", "Alexander, N.", "Benedetti, L. R.", "Döppner, T.", "Forsman, A.", "Izumi, N.", "LePape, S.", "Ma, T.", "MacPhee, A. G.", "Nagel, S. R.", "Patel, P.", "Spears, B.", "Landen, O. L."]
  parent:
    title: Rev. Sci. Instrum.
    volume: 87
    date: 2016
  page-range: "11E201"
  doi: "10.1063/1.4959161"

kunimune22:
  type: article
  author: ["Kunimune, J. H.", "Rinderknecht, H. G.", "Adrian, P. J.", "Heuer, P. V.", "Regan, S. P.", "Séguin, F. H.", "Gatu Johnson, M.", "Bahukutumbi, R. P.", "Knauer, J. P.", "Bachmann, B. L.", "Frenje, J. A."]
  parent:
    title: Phys. Plasmas
    volume: 29
    date: 2022
  page-range: "072711"
  doi: "10.1063/5.0096786"

With the "american-physics-society" style built into Typst, this produces

[1] B. Bachmann et al., Rev. Sci. Instrum. 87, 11 (2016)
[2] J. H. Kunimune et al., Phys. Plasmas 29, 72711 (2022)

But it should produce

[1] B. Bachmann et al., Rev. Sci. Instrum. 87, 11E201 (2016)
[2] J. H. Kunimune et al., Phys. Plasmas 29, 072711 (2022)

I have the same issue as the Springer journal also uses page identifiers.


Solution

Updated pv&pvc manifest by adding a namespace to it
Change the markdown file with adding  to it .md extension

updated


add silhouette of top bar and grids

added silhouette of top bar. To add it also started to add grid system logic.

i don't have prior context for the silhouette components, so pardon the probing question.
what is the intended developer experience for the silhouette components?
are they supposed to represent the entire page layout? or be a building block to place in the page?

Same question as @chasestarr.
Also how does this work alongside HeaderNavigation (#525)? As a developer I'd be very confused if I saw both HeaderNavigation and TopNavigation in the storybook.

i don't have prior context for the silhouette components, so pardon the probing question.
what is the intended developer experience for the silhouette components?
are they supposed to represent the entire page layout? or be a building block to place in the page?

each silhouette is just a block and doesn't design the whole page layout. Main difference between silhouettes and other components is that silhouettes are invisible and only provide layout styles. Also they fall under grid system of Base UI, whereas regular components do not.
This is my understanding. I will send email to Jeff to get some extra feedback.

Also how does this work alongside HeaderNavigation (#525)? As a developer I'd be very confused if I saw both HeaderNavigation and TopNavigation in the storybook.

Probably we should start documentation describing silhouettes and grid concept so customer would be aware of difference and usage. So far HeaderNavigation can be placed anywhere and it's not fixed, cause doesn't represent layout. I assume in current implementation we can use them together as below, which may be confusing, especially because of naming
<TopNavigation>
     <HeaderNavigation />
</TopNavigation>

cc @nadiia  @austin94 @chasestarr @schnerd @gergelyke

I agree with the question raised by Chase and David. Should we rather have a generic layout component, that has different types, and each type would support different placements.
So for this one, it would be something like this:
<Layout type={Layout.TOP_BAR} placements={{
  header: HeaderNavigation,
  body:

}}/>

What do you think @blackswanny @schnerd @chasestarr ?

I think it's a good idea, which saves a ton of extra code. However, it would be a factory of many different layouts. So far we have 12, so this might be a big file

rather than type as a prop, silhouettes may export multiple components. this could lead to more encapsulated implementation code and suggests semantic names for each silhouette configuration for eng/design to collaborate.
nit on your example @gergelyke, but i don't feel strongly either way (I'm mostly trying to understand the team's preferences). it may be more idiomatic react to expose top-level render props, like in the example below, rather than nest in a placements obj
import {HeaderFlush} from 'baseui/silhouettes';

<HeaderFlush
  header={<CustomerHeader />}
  body={<CustomBody />}
/>

may want to consider an implicit parent<>child relationship. what this does better than the other api is it removes the documentation/naming overhead of shoving a component into header, body, etc... props. downside is it may require guard-rails like if a dev places more than two children, throw/log an error.
<HeaderFlush>
  <CustomHeader /> // implicitly oriented at top of layout
  <CustomBody /> // implicitly oriented below previous element
</HeaderFlush>

That sounds good too to me Chase - Oleg, would you mind starting with an RFC first, maybe as a new PR?

That sounds good too to me Chase

What approach exactly? Both examples have downsides
This one explicitly tells layout parts which we need to consider, whereas every application requires many custom layout elements: header, subheader, main body, footer, left menu, side menu, right menu. Silhouettes themselves show at least 12 examples, and it's only those that might be needed. Silhouettes can be used in custom app layout here and there, but not setup the whole page as we can't comprehend those
<HeaderFlush
  header={<CustomerHeader />}
  body={<CustomBody />}
/>

This example has the same concern as previous, but also the styles will be forced to apply even if we shuffle these children in different order, which may confuse as usually React elements reflect the same DOM tree from left to right, from top to bottom. Also our overrides approach needs to be enforced frequently to work with this example and override styles
<HeaderFlush>
  <CustomHeader /> // implicitly oriented at top of layout
  <CustomBody /> // implicitly oriented below previous element
</HeaderFlush>

I think we shouldn't tight the content of a top bar to its props, but it should accept it as children and it should not care much what children it has. It should be a simple layout component not more.

Can we take a step back please, and split the RFC part into a new PR, so we can discuss just that separately please?

Can we take a step back please, and split the RFC part into a new PR, so we can discuss just that separately please?

added RFC PR https://github.com/uber-web/baseui/pull/558


Need a clear doc page that shows which OS versions Terminal will run on

Coming from this issue in the PowerShell Repo (that I created) I found PowerShell has this nice easy to understand document section for supported versions of windows
This Doc is the closest similar one & I think could be updated to show where you expect Terminal to actually run, like as show above would provide much needed clarity going forward.

I mean, it's pretty front and center at the top of the README

Windows Terminal requires Windows 10 2004 (build 19041) or later

But we can just add a note at the top of that docs page too. No need to have a whole matrix of options - it's just >10.0.19041 for all terminal versions.

Sorry but this is what I mean by it's not clear & why just using build numbers makes it unclear & would with a matrix with clearer notes as to why it's unsupportable on those os'es would likely have stopped you having ever had the support 2016/2019 issues being raised.
It also does not help that Windows 11 still shows up as Windows 10 in many places
being crystal clear helps stop confusion, and your docs in this case aren't crystal clear, hence the ask for a matrix.
I know to you & others within & outside Microsoft that build numbers make a lot of sense, but the way they are right now is super confusing to many of us, especially if we are managing mixed estates.
Just trying to give some honest and useful feedback here that would definitely help many going forward for what isn't really a big ask in much needed clarity.

Moved to our docs repo: https://github.com/MicrosoftDocs/terminal/issues/701

sorry for raising in the wrong repo @zadjii-msft & thank you for raising in the right one!


Incrementing to new build tools / SDK and adding local broadcasts for Pinning Failure Reports

Incrementing to gradle 3.3.2
Incrementing build version names and codes
Incrementing compile SDK to 28
Incrementing buildTools to 28.0.3
Incrementing targetSdk to 28
Incrementing appCompat to 28.0.0
Adding local broadcast of pinning failures
Adding examples of PinningFailureReportBroadcastReceiver
Adding test for local broadcast of pinning failures

Thanks for the pull request - this is a cool feature. We'll take a look asap.

Thanks so much!


Trouble installing python-mander

I have successfully installed and run mandeR in R and have compactnesslib, etc., installed.
I am trying to run python-mander.  I am new to python.  I am running python3 (on ubuntu linux 21.04).   I have the virtualenv working.
When I run  pip install -r requirements.txt I get errors for functools32 and wsgiref.  Are these essential?  If I delete these lines, the other requirements install.  At this point, i.e., without functools32 and wsgiref but with everything else,  python setup.py build runs without errors.
When I launch python and try import mander  I get the following:
>>> import mander
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/Desktop/python-mander/mander/__init__.py", line 1, in <module>
    import _mander
ModuleNotFoundError: No module named '_mander'

Please let me know if you have any suggestions for installation. Thanks.

I have the same issue as above.


Need to interact with particular particle on mouse touch and destroy it

Hi,
I'm new to pixi-particles library, I'm using pixi-particles v4:3:0 and pixi-js-legacy 5:3:7
I creating a scenario using pixi-particles where I integrated a rain effect. I need to destroy particular particle emit from emitter on mouse interact. How can we achieve this. I'm facing difficulty to get particular particle object on mouse interact.
Much needed help ASAP.
Thanks

I would advise against this, as hit testing against hundreds/thousands of particles each mouse down/up will not be good for performance. If you still want to do it, then I would write your own behavior implementation that adds the mouse event listeners and reports the results. I haven't used the new event library in PixiJS v7 yet, but I believe it bubbles, so you could also try adding a listener to the parent of the particles and the event should tell you which object is the target - you may need to make a behavior to make particles interactive so that they are valid as individual targets.

Yes @andrewstart I need to achieve the same functionality using mouse events ( over / left click ). Please do the needful.


Fullscreen bugs

When fullscreen,

Windows controls appear in the bottom bar
With the titlebar removed, there's a weird space left.

Fixed.

Pd: There is an issue when hide-single-tab.css is active, if you have a single tab, header bar will not shown when full screen is active.

Temporal fix for hide-single-tab.css ready.


Patches + DevKit

Applies all the latest framework updates (4.1.9)
Switches to the CodeIgniter DevKit and applies all update configurations

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

136 of 156 (87.18%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+13.1%) to 86.624%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/Actions/EmailAction.php
16
17
94.12%

app/Actions/PushAction.php
17
18
94.44%

app/Commands/RedditExecute.php
7
8
87.5%

app/Controllers/BaseController.php
0
1
0.0%

app/Database/Seeds/TemplateSeeder.php
9
10
90.0%

app/Models/SubmissionModel.php
21
22
95.45%

app/Database/Seeds/InitialSeeder.php
5
9
55.56%

app/Commands/RedditFetch.php
23
28
82.14%

app/Commands/RedditFilter.php
20
25
80.0%

Totals

Change from base Build 953067111:
13.1%

Covered Lines:
136

Relevant Lines:
157

💛  - Coveralls


Tflite testsuite issue with tflite 2.1.0 (test_elemwise(partial(add, "RELU6")))

As documented in #5392 using the packages for tflite and tensorflow 2.1.0 the test as in the subject line segfaults. It has now been skipped in the testsuite but this needs to be fixed.

This is the failure in the build and test run.
`

    raise ConverterError("See console for info.\n%s\n%s\n" % (stdout, stderr))

E         tensorflow.lite.python.convert.ConverterError: See console for info.
E         2020-04-22 14:25:04.973317: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer.so.6'; dlerror: libnvinfer.so.6: cannot open shared object
file: No such file or directory; LD_LIBRARY_PATH:
E         2020-04-22 14:25:04.973380: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer_plugin.so.6'; dlerror: libnvinfer_plugin.so.6: cannot open
shared object file: No such file or directory; LD_LIBRARY_PATH:
E         2020-04-22 14:25:04.973388: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:30] Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
E         2020-04-22 14:25:05.600205: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 2 operators, 4 arrays (0 quantized)
E         2020-04-22 14:25:05.600303: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 2 operators, 4 arrays (0 quantized)
E         Fatal Python error: Segmentation fault
E
E         Current thread 0x00007f4ad17cc700 (most recent call first):
`
E           File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 56 in execute
E           File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 250 in _run_main
E           File "/usr/local/lib/python3.6/dist-packages/absl/app.py", line 299 in run
E           File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/platform/app.py", line 40 in run
E           File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 93 in main
E           File "/usr/local/bin/toco_from_protos", line 8 in
E         Segmentation fault (core dumped)

@u99127 @anijain2305 can you comment on the state of the issue?

ping, will consider this issue closed due to inactive status


Support of Elasticsearch SQL for Watcher configuration

Hey guys,
I just want to ask you if Elasticsearch SQL is planned for the watcher configuration?
I think this could help many guys to configure there watchers.
Best regards,
Robert

Hey @lmangani
The elasticsearch team added the SQL support with version 6.3.0 for all versions (there are special things which are just availlable with XPACK, but its availlable, also the translator).
As reference follow the release notes of the elasticsearch team: https://www.elastic.co/guide/en/elasticsearch/reference/6.4/release-notes-6.3.0.html
But its good to know that your team has also a variant.

XPACK is licensed in a "free access" manner but it is not open source - there is a big difference in there ;)

@lmangani
I fully agree with you :)
I don’t master elastic license rights to use : if sentinl provides features based on elastic licensed (free) features, would it be a juridic issue ?

Quite frankly I don't know what using those XPACK API might mean in terms of licensing and cross-linking plus the SIREN stack already offers much greater possibilities on that front (and many others) so this is not a priority. SENTINL comes with its own sample SQL to ES converter and this can sure be extended to provide a similar experience without any dependency if enough people are interested.

just my2c If the free version offers a REST api sentinl can call it just
fine
so contributions welcome :) . In Siren we'll evenctually have a SQL with
joins etc for now its an extention to the Elastic DSL .Of course one can go
via other third parties apache open sourced SQL on Elasticsearch
https://github.com/NLPchina/elasticsearch-sql  (seems to be quite
maintained) or heave weight via Dremio.

@jccq
Indeed, Elastic XPACK SQL provides a REST API to execute SQL queries.

@fbaligand we do too ;)


dd-extension Record a video of running  and using the extension and replace the video on the main page

Bug Report
The Docker Desktop extension points to a video of TCE unmanaged clusters. As there was no other marketing material available at launch, this was the best we could do. We need to replace that video with one specific to running and using the extension.

@jpmcb Tagging you so you remember this


LMP 3.9 devc mode does not pick up the pom.xml change

Scenario 1:

used LMP 3.9 and Colima Docker on Mac
run mvn liberty:devc -DcontainerRunOpts="-e DB_HOSTNAME=<IP_ADDRESS>" -DserverStartTimeout=240
add test class
get expected compilation error
update the pom.xml with the required dependencies
nothing change

expected same as Scenario 2

Scenario 2:

used LMP 3.8.2 and Colima Docker on Mac
run mvn liberty:devc -DcontainerRunOpts="-e DB_HOSTNAME=<IP_ADDRESS>" -DserverStartTimeout=240

run 3 times for a known issue

add test class
get expected compilation error
update the pom.xml with the required dependencies
tests are recompiled
successfully run the tests

@gkwan-ibm Nothing changed in the two scenarios except the LMP version? This is very odd since nothing changed in how file changes are monitored in devc mode. What version of Maven are you using? And what version of Java?
Finally, these are direct file changes? Not through Liberty Tools correct?

mvn -version
Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
Maven home: /Users/gkwan/tasks/softwares/apache-maven-3.9.1
Java version: <IP_ADDRESS>, vendor: IBM Corporation, runtime: /Users/gkwan/tasks/softwares/jdk-<IP_ADDRESS>+1.semeru.aarch64/Contents/Home
Default locale: en_CA, platform encoding: UTF-8
OS name: "mac os x", version: "14.0", arch: "aarch64", family: "mac"

Yes, direct file changes. Not through LT.

I am wondering if this change caused this problem. I will build a snapshot with that change backed out and see if it fixes it. If so, I will need to determine a different fix for the original problem.

@gkwan-ibm Can you give me specific recreate instructions? I need something specific for the following:

add test class
get expected compilation error
update the pom.xml with the required dependencies

Also, can you check if the same scenario fails for dev vs devc? I tried to recreate with one of my sample projects locally, but without a specific test class and dependency to add, I am spinning my wheels.

hi @cherylking You can do following:

git clone https://github.com/OpenLiberty/draft-guide-testcontainers.git
visit https://guides-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/guides/testcontainers.html#implementing-integration-tests-to-use-testcontainers
follow the instructions in the guide
after replacing the pom.xml, expect test classes are compiled, and hit enter to run the tests successfully

@gkwan-ibm fyi...if you run this same scenario on 3.8.2 with -DpollingTest, you would get the same incorrect behavior. There were two issues here.

For some reason, when trying to get events from the file watcher, it is taking too long and therefore defaulting to use polling instead in the 3.9 version of the plugin.
There was some incorrect logic in the polling method that caused some files (including build files) to not get monitored correctly.

For 1, I have increased the timeout so that there is a better chance that file watching will occur instead of polling.
For 2, I fixed the logic to handle monitoring of all files correctly.
This fix will be contained in the next release of the plugin. Once a snapshot is available for testing, I will close this issue.

Snapshot driver 3.10-SNAPSHOT contains this fix. If the issue persists even with the snapshot, please reopen.

verified 3.10-SNAPSHOT that can resolve this issue


one off charge (invoiceFor)

Hi,
I'm wondering is there a method to process one time charges.

This will be added in the future according to the docs
https://github.com/laravel/cashier-mollie#one-off-charges

True! I'll hijack this ticket as a reference.
Also, feel free to help me out with a PR. My focus primarily shifts to Spark for the next month.

I'm going to try to spare some time this weekend to hack at this. I'll keep you guys posted.

I'd like to stay as close to Cashier for Stripe as possible, so let's start there.
Cashier for Stripe offers the following on the Billable trait for one off charges (I'm trying to understand the differences):

/**
     * Make a "one off" charge on the customer for the given amount.
     *
     * @param  int  $amount
     * @param  string  $paymentMethod
     * @param  array  $options
     * @return \Laravel\Cashier\Payment
     */
public function charge($amount, $paymentMethod, array $options = [])

    /**
     * Add an invoice item to the customer's upcoming invoice.
     *
     * @param  string  $description
     * @param  int  $amount
     * @param  array  $options
     * @return \Stripe\InvoiceItem
     */
public function tab($description, $amount, array $options = [])

    /**
     * Invoice the billable entity outside of the regular billing cycle.
     *
     * @param  array  $options
     * @return \Laravel\Cashier\Invoice|bool
     */
public function invoice(array $options = [])

    /**
     * Invoice the customer for the given amount and generate an invoice immediately.
     *
     * @param  string  $description
     * @param  int  $amount
     * @param  array  $tabOptions
     * @param  array  $invoiceOptions
     * @return \Laravel\Cashier\Invoice|bool
     */
public function invoiceFor($description, $amount, array $tabOptions = [], array $invoiceOptions = [])

As I understand it:

charge() and tab() result in charges to be processed in the upcoming bill, so the billing cycle is left intact.
invoice() and invoiceFor() trigger payments directly, without delay.

Ok, the laravel docs state that the difference is just charging with or without an invoice... 😕

Checking this with Dries.
On another note, I'd like to either return a RedirectToCheckout or an Order, depending on whether the customer has registered a valid payment mandate.
This is similar to starting a new subscription.

charge: single charge without an invoice
tab add a line to the upcoming invoice
invoice create a new one-off invoice
invoiceFor create a new one-off invoice with the specified amount

Thanks @driesvints !

any ETA on the one-off feature ?

Thank you very much for creating the cashier package for mollie 🙏
For our service, one-off feature is required, would be nice to hear any ETA.

@rabol  @Hesesses
I (re)started working on it this morning, since I'm currently having a little more free time. Since it has been a while since I initially started working on it I simply dropped everything, and created a new fork from development. I'm not sure when it will mergable, but I'm aiming to get the biggest part done in around 2 weeks (~17 May).
After that it will depend on feedback and Sander, so I can't really give an ETA.

Thanks for quick update!

Thank you for this awesome package! Any updates on this feature?

Hi @JordiBaguette, you can read up on the actual status in the associated pull request. The code in the pull request works, but the final version still needs some work (especially the part of the “open tab”).
After Sander finds more time to have a look at it and reviews it, I can check if I can find some more time to process his feedback. I’m also kind of busy though at the moment, so it’s also fine with me if someone else will finish it.

Great to see some progress on this. I, too, am hoping for a resolution soonish... 😊

Let me know if I can help test!


[iOS] Upgrade button and messaging on Locked Content

For scenarios where content is gated, an embedded value proposition should be displayed, detailing the benefits of upgrading to regain access or unlock content.
Acceptance criteria:

UI matches a similar theme as the prod app
Tapping the upgrade button initiates the mobile store payment processor
Tapping show more expands the content to show the bullets present in the value prop modal

Resources:
Current implementation video demo: https://drive.google.com/file/d/1wsP9L7xLRQv8RbobX3SX1ZIPIU6gTJxq/view?usp=drive_link
Screenshot:

@saeedbashir any updates here? Do we have API to implement that?


Boost dependency(?)

Why does valgrind-feedstock depend on boost?
I looked on the valgrind manual and there's no reference to boost.
I noted this because calling conda install valgrind wanted to downgrade my version of boost (and causing a chain reaction of changes).

configure.ac does check for Boost.
You can install valgrind in its own separate env, and make a shim in your main env to activate the valgrind env and run valgrind, like so:
conda create -n valgrind_env valgrind -y
then, put a file like this in your working env's bin/ directory:
#!/bin/bash
set -e -o pipefail
. "/ilya/miniconda3/etc/profile.d/conda.sh"
conda activate valgrind_env
valgrind "$@"
conda deactivate

Thanks for your explanation.
I see what you are referring too in configure.ac:
#----------------------------------------------------------------------------
# Other library checks
#----------------------------------------------------------------------------
# There now follow some tests for Boost, and OpenMP.  These
# tests are present because Drd has some regression tests that use
# these packages.

From my understanding, valgrind doesn't really need boost besides running some tests.
So should not boost-cpp be a build requirement and not host or run requirement?

How did you come to this understanding?

The comments I quote explicitly says that boost is only needed for regression testing of the DRD: a thread error detector component of valgrind.
A recursive grep in the valgrind source will indeed show that the only place where boost is used is in the testdrd/tests/boost_thread.cpp.

@uvilla I think you're right; I'm testing a boost-less PR right now - https://github.com/conda-forge/valgrind-feedstock/pull/8
thanks,
ilya

The comment I quoted explicitly says that boost is only needed for regression testing of the DRD: a thread error detector component of valgrind.

It says there are tests for Boost. Not that it is not needed for anything else. Hence the question. 😉

A recursive grep in the valgrind source will indeed show that the only place where boost is used is in the testdrd/tests/boost_thread.cpp.

That said, this does answer it. Thanks for checking. 🙂

@uvilla I've merged the PR that drops the Boost dependency.  (It might take a day to show up in conda search).  I had to temporarily drop the MacOS build, until I figure out an issue with it; hope you're working on Linux.
Oddly, http://www.linuxfromscratch.org/blfs/view/cvs/general/valgrind.html thinks Boost is needed not just for tests; I'll check with them for their reason.
Btw, for a low-level tool like valgrind, you might get better performance if you build it from source specifically for your system, rather than using conda-forge's built-for-lowest-common-denominator version.
Thanks again for pointing out the spurious Boost dependency!

@notestaff and @jakirkham ,
Thank you very much again for looking into the issue in such fine details.
I truly appreciate that!

Closing as resolved.


DS-3700: MediaFilterServiceImpl forgot to close an input stream.

https://jira.duraspace.org/browse/DS-3700
At least within linux there is a limit of the numbers of files you may open in parallel. This can be configured within limits by using ulimit. Best way to reproduce this error would be to find a way and reasonable limit and then start filter-media -f on a repository that hits this limit.
This needs to be cherry-picked to master as well.

I'm still testing it myself. But the problem looked so obvious to me, that I already created the PR.

While try with resources is a cleaner approach I had to change more code to apply it here. In the meantime I found another socket leak in DSBitStoreService which I fixed while being on it.
This PR ensures that we close three streams we haven't closed before. While I don't see anymore unclosed streams in this code area, I can still bring our filter-media script to an IOException: too many open files. Nevertheless it is a big progress and we should merge this PR.
If someone else has a chance to take another look unclosed sockets, I would appreciate that.

'mvn findbugs:findbugs' on dspace-api turned up 28 possible unclosed streams.  We should perhaps have a separate issue for a general unclosed-streams bug hunt.
In total, findbugs noted over a thousand constructions that it disliked.

@mwoodiupui pointing towards findbugs is a good idea. I would prefer to do as you suggested and try to fix this in a separate issue. What do you think of this PR as it is for now?

@tomdesair I think @pnbecker has made the changes you requested, can you confirm and resolve your review? Thanks!

+1
i tested using @pnbecker 's instructions, I had to use a hard limit of 215 on my particular system and number of bitstreams, but managed to reproduce this error on dspace-6_x:
ERROR filtering, skipping bitstream #7caffaf3-7845-4098-99b8-184539337e99 java.io.IOException: java.io.FileNotFoundException: /home/vagrant/dspace/assetstore/37/71/23/37712310757983322376345532200733929853 (Too many open files)
And ran successfully with same limit using this PR.
Thanks @pnbecker !

I've merged this PR and created a cherry-pick PR for the master branch here: https://github.com/DSpace/DSpace/pull/1963


No module named 'psycopg2'

I'm trying to follow the instructions in a raspberry pi with ubuntu 22.04.
Once I get to part 5 of the instructions it always fails at the first command.
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/mbslave", line 5, in <module>
    from mbdata.replication import main
  File "/home/ubuntu/.local/pipx/venvs/mbdata/lib/python3.10/site-packages/mbdata/replication.py", line 7, in <module>
    import psycopg2
ModuleNotFoundError: No module named 'psycopg2'
I tried to install psycopg2 in several ways (installing psycopg2-binary using pip and pip3, building from the source and installing it), and in all those times the installation was successful. However, those mbslave commands always end up not finding the module.
What am I missing here?

Interesting, I just ran into this issue and It looks like you need to install psycopg2, try pip install psycopg2==2.8.5, I ran this command and it worked for me. How did you install mbslave?

First installing using pipx it doesn't worked. Even by having psycopg2 installed. However by installing mbdata over my system package manager and uninstalling pipx it worked.

Make sure you have the psycop2 folders installed into the correct directory:
                                           /home/<<user>>/.local/pipx/venvs/mbdata/lib/python3.10/site-packages

I had the folders installed in the wrong directory ( /home/<>/.local/lib/python3.10/site-packages).

I had a hard time figuring this out. IMHO the Install guide should point out a way to install this dependency. I'd suggest installing it into the venv with pipx:
pipx inject psycopg2

Make sure you have the psycop2 folders installed into the correct directory:
         /home/<<user>>/.local/pipx/venvs/mbdata/lib/python3.10/site-packages

I had the folders installed in the wrong directory ( /home/<>/.local/lib/python3.10/site-packages).

pipx lets you load libraries on a per app basis - this worked for me:
pipx inject mbdata psycopg2

How exactly did you guys install it initially? In the README file, it says to use pipx install mbdata[replication]. The [replication] tag make is require psycopg2 on install. Did you just run pipx install mbdata?

Closing this one, it should work fine if you are following the instructions exactly.


This one could work ?

Phillips USB 64GB
Volume: D:
Controller: Phison 2303 (2251-03)
Possible Memory Chip(s):
Toshiba TH58NVG9T2JTA20
Toshiba TH58TEG9T2JTA20
Memory Type: TLC
Flash ID: 983CA992 7AD7
Chip F/W: 01.07.53
Firmware Date: 2013-06-21
ID_BLK Ver.: <IP_ADDRESS>
MP Ver.: MPALL v3.70.0E
VID: 13FE
PID: 5200
Manufacturer: Philips
Product: USB Flash Drive
Query Vendor ID: Philips
Query Product ID: USB Flash Drive
Query Product Revision: PMAP
Physical Disk Capacity:<PHONE_NUMBER>6 Bytes
Windows Disk Capacity:<PHONE_NUMBER>2 Bytes
Internal Tags: 2Q2P-S78J
File System: NTFS
Relative Offset: 4032 KB
USB Version: 3.00
Declared Power: 504 mA
ContMeas ID: E9A2-06-00
Microsoft Windows 7 SP1 x64 Build 76100
http://www.antspec.com/usbflashinfo/
Program Version: <IP_ADDRESS>0

I think so, because it has the right chip
Where do you bought it?


Auto Suggest Tests for Table Entities

We should allow auto suggestion of tests for table entities.
Solutions
Tests suggestions should be listed on their own page and allow users to accept/reject suggestionsm then validate and automatically add those tests to the entities

closing as this will be a collate feature


Empty Sidenav on Mobile

The mobile sidenav opens but is currently empty. The expandable dropdown system in the sidenav is Materialize's collapsible, different to the one in the navbar which is dropdown. So, we can't just point the sidenav's data-target to the source ul that we're using for the navbar dropdowns. To avoid getting make-cards.py to copy card content twice, is there a way of adding some innerHTML modifications in the $(document).ready function to update the sidenav collapsibles?

Fixed in c5e463c.


GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Whitespace PreCommit

R: @udim


Update __generators helper to match TS#24463

This updates the __generator helper to match the changes in Microsoft/TypeScript#24463.

@DanielRosenwasser we need a new release for this one.


CompactType: Swap || Snake

I guess this is more of a feature request. A simple swap of two items doesn't seem to be possible. Neither horizontal, vertical, or null compaction is the desired behavior, because it can leave blank spaces or it creates carousel like behavior: for instance a horizontal move with vertical compaction and vice versa. I am just looking for a simple swap :P. Or a another compaction type could be: SNAKE where a gap is filled by compacting horizontally and the new gap at the end of the row is filled by the first item in the next row andsoforth.

That would be nice and yes, that's more like a feature request. On the other hand,  I feel like this would create too much work to create.

really need this, like iOS home screen reordering of apps.


[Question] Send a message to a single peer in a room

Hello,
is it possible to send data directly to a peer instead of broadcasting it to all peers in the room?
If I can give my opinion it would be great if there was an event like:
p2psocket.on('peer-connected', function(peer){
    //peer.emit('peer-msg', {msg:'Hello there!'})
})

or have access to all peers from within the p2psocket object. Right now I see that there is _peers attribute, but it isn't possible to send data with the emit method.
Thank you for the great library!

Vote for this one as well

This sounds useful. I will have a look at a solution.

:+1:

:+1:

+1


fixed the links to social media and resume

Please, go through these steps before you submit a PR.

[ ] My Pod Leader knows I'm working on this Pull Request
[ ] I've explained what the Pull Request is adding.
[ ] I've explained why this is important.
I fixed the links to the social media accounts and resume in the profile page. Previously the links only refreshed the page.
Now all fellows can navigate to their peers social accounts.

kindly review @himanshu-thakur-7  @dw2761

Links are working well. Will merge it


ECC partly for key creation instead of RSA.

I was wondering about the selection for encryption keys on the creation part of the tutorial. Isn't it a better idea to recommend here ECC keys instead of RSA? There is a lot of discussion I remember about RSA which is going to be kind of deprecated. Honestly, I have to research it again, but my gut tells me it makes more sense. Is there a good reason, not to do it?

I selected RSA for compatibility, as GnuPG 2.1 (which added ECC supported) had not been the default installation at the original time of writing the guide. The 2015 paper A Riddle Wrapped in an Enigma is a good additional reading on the subject. This analysis by DJB is another to consider and personally gives me pause about using Yubikey's supported ECC algorithms (p256, p384). There is nothing I'm aware of that would characterize RSA with sufficient key length as being or soon to be deprecated, however.

I found a talk from "Rüdiger Weiß" who is professor researching in cryptology from Germany. His talk from a slightly older c3 gave me the hint, that using RSA is still a good idea and ECC has a lot of flaws actually.

ECC has beenout there for a while and Curve25519 is being used by Signal Messenger and many others.
I think it would be fair to reconsider.
see:

https://en.wikipedia.org/wiki/Curve25519
https://ianix.com/pub/curve25519-deployment.html
https://zach.codes/ultimate-yubikey-setup-guide/


Add isScoped to LocalPlayer

I have added isScoped boolean to LocalPlayer class which will return whether player is in scoped mode or not.

You're returning an int, not a bool, since you're reading an int (as you can probably see) "rpm", what you could do instead is:
bool LocalPlayer::isScoped() { 	return rpm<bool>(LocalPlayer::getLocalPlayer() + netvars::m_bIsScoped); }

I have added isScoped boolean to LocalPlayer class which will return whether player is in scoped mode or not.


cursor / pointer in textarea does not work properly

In Ionic application (v1.0.0-rc.2) tested on ios (8.2 device and simulator)
When keyboard is up and cover a part of the textarea. it's impossible to move properly the cursor in the textarea's text.
""

Greetings @benziane!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Hello! Are you still experiencing this issue with the latest version of ionic(ionic 1.2.4)? Thanks (:

This issue is corrected with the latest version.
Thanks.


Production ready and support for Reactive spring stack

Could you please let me know if this library is fully tested and can be used in Production environment without any technical issues?
Also, does it works well with Reactive spring stack?
Does this support Honeycomb?

Could you please let me know if this library is fully tested and can be used in Production environment without any technical issues?

The tests are passing if you're asking about it. There are companies that use the tool in production. OTel has just been released as GA. OTel instrumentation has not. So it's really difficult to answer your question.

Also, does it works well with Reactive spring stack?

Yes.

Does this support Honeycomb?

What do you mean? If Honeycomb has a dedicated exporter then add it to the classpath and register it as a bean.


Backport podmonitor to release-0.3

Apply #317 to enable the discovery of Podmonitors Custom Resource across namespaces in release-0.3.

@lilic


Feature request: Page that shows user's RBAC permissions (kubectl auth can-i equivalent)

Octant could have a view that displays the current user's RBAC permissions on the cluster.
Conceptually, this is similar to kubectl auth can-i --list command.
Prior art:

https://github.com/jasonrichardsmith/rbac-view
https://github.com/team-soteria/rback
https://github.com/corneliusweig/rakkess

We want to add this to Octant, we will be spending some time to write up a feature proposal for how this will be implement. We will be sure to link back to this issue in that PR.

This work will require a proposal to be implemented effectively.
Things to consider:

how can we use this information to enable/disable aspects of the UI before a user attempts to perform an actions
where should this information be stored?
how and when do we refresh this information?

Two questions that came up when I took my first pass at this ...

Why do you want to see the RBAC for your account?
Is this more useful as a tool to explore the RBAC of any user or service account?

For example, this table has 310 records in it, a row for every single resource in my cluster I have access to and every resource in that namespace, which for my admin account, is all duplicates.

I am trying to recall what made me open this issue 😄

Why do you want to see the RBAC for your account?

I think this would be mainly for troubleshooting purposes as I create/modify/delete roles and role bindings.

Is this more useful as a tool to explore the RBAC of any user or service account?

100% yes! This is especially useful when crafting RBAC policy.
Hope that helps.


fix and update Pod requests vs usage dashboard

This PR updates "Pod requests vs usage" dashboard.
Towards https://github.com/giantswarm/roadmap/issues/1963
Changes:

show each pod
don't use "avg", it was a trick to show only 1 graph but was displaying false values when multiple pods
show each pod independently
fix legends
fix "top10" lists
migrate to new graph panels

Before

After

I'm still wrapping my head around how to make this more useful, but at least it's not broken anymore!
Checklist

[x] Update changelog in CHANGELOG.md in an end-user friendly language.

Tested on gauss :heavy_check_mark:


[Question] Next SSR support

Hello, I was interested to try snackui with a project, in which we use next with expo as our web platform. I saw the information about no SSR support, and I was curious what problem there is to solve, maybe I could contribute a solution.

There's no reason it shouldn't work with SSR I believe, I just am not sure if it does in practice. One first good step would be go set up a simple example in the examples folder for SSR, and just see what happens first try. I believe we had SSR working somewhat previously even.
So it's more an unknown if it works or not, but I don't see any reason it shouldn't. Let me know if you have any questions, happy to help.


Ignore Sync errors on pipes when doing CheckAttributeReader.CheckPath, fix the hang of git cat-file

It is not necessary to call Sync on pipes. And the Sync usually results in error: "sync |1: invalid argument".
Ref: https://man7.org/linux/man-pages/man2/fdatasync.2.html :
EROFS, EINVAL:  fd is bound to a special file (e.g., a pipe, FIFO, or socket) which does not support synchronization.

If we return early from CheckPath when Sync returns error, the GetLanguageStats will hang forever (because the stdin's buffer will be fully filled, then Write in CheckPath blocks)
But I can not confirm the Sync behaviors on different platforms, so I think it's OK to keep it while ignore the returned error.
Related issues:
Bug report:

https://github.com/go-gitea/gitea/issues/17094

Add caller to cat-file batch calls for debug:

https://github.com/go-gitea/gitea/pull/17089
https://github.com/go-gitea/gitea/pull/17082

Codecov Report

Merging #17096 (ae92e3e) into main (a4bfef2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #17096      +/-   ##
==========================================
+ Coverage   45.25%   45.27%   +0.02%
==========================================
  Files         773      773
  Lines       86828    86826       -2
==========================================
+ Hits        39291    39309      +18
+ Misses      41188    41162      -26
- Partials     6349     6355       +6

Impacted Files
Coverage Δ

modules/git/repo_attribute.go
68.06% <100.00%> (+1.74%)
:arrow_up:

modules/process/manager.go
72.83% <0.00%> (-2.47%)
:arrow_down:

services/gitdiff/gitdiff.go
73.48% <0.00%> (+0.38%)
:arrow_up:

services/pull/pull.go
42.19% <0.00%> (+0.40%)
:arrow_up:

modules/queue/workerpool.go
50.00% <0.00%> (+0.76%)
:arrow_up:

models/repo_list.go
78.43% <0.00%> (+0.78%)
:arrow_up:

modules/log/file.go
75.20% <0.00%> (+1.60%)
:arrow_up:

models/unit.go
43.83% <0.00%> (+2.73%)
:arrow_up:

modules/git/repo_language_stats_nogogit.go
54.09% <0.00%> (+4.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bfef2...ae92e3e. Read the comment docs.

This was my worry when we added the error check here in the first place.
But I couldn't force it to happen myself - Did you actually get this error reported? If you're didn't - it's possible something else is actually happening:
I added the Sync because I was also seeing an unusual hold-up likely because the \x00 is not recognised as a line and because the buffer on a pipe can be up to 64Kb.  The Sync appeared to cause a flush in my testing so the unexpected hold-up disappeared.
Now if you're experiencing some block then the Sync may not be enough to solve the problem - especially if you're not actually seeing the above error that you were expecting.

Looking again at the code - I think you're likely suffering from the problem I was experiencing earlier.
Can you repeatedly replicate this issue?

diff --git a/modules/git/repo_attribute.go b/modules/git/repo_attribute.go
index 0bd7d7e49..f001e65e3 100644
--- a/modules/git/repo_attribute.go
+++ b/modules/git/repo_attribute.go
@@ -112,13 +112,15 @@ func (c *CheckAttributeReader) Init(ctx context.Context) error {

 	if len(c.IndexFile) > 0 && CheckGitVersionAtLeast("1.7.8") == nil {
 		cmdArgs = append(cmdArgs, "--cached")
-		c.env = []string{"GIT_INDEX_FILE=" + c.IndexFile}
+		c.env = append(c.env, "GIT_INDEX_FILE="+c.IndexFile)
 	}

 	if len(c.WorkTree) > 0 && CheckGitVersionAtLeast("1.7.8") == nil {
-		c.env = []string{"GIT_WORK_TREE=" + c.WorkTree}
+		c.env = append(c.env, "GIT_WORK_TREE="+c.WorkTree)
 	}

+	c.env = append(c.env, "GIT_FLUSH=1")
+
 	if len(c.Attributes) > 0 {
 		cmdArgs = append(cmdArgs, c.Attributes...)
 		cmdArgs = append(cmdArgs, "--")

Could you check if this helps?

You patch is good, but it doesn't help about this problem.
Linux document has said that a pipe should be fsync-ed.
So I think my patch makes the problem better than before.
On you side, the Sync is still been called, so you do not worry about buffered data.
On my side, the Sync error is ignored, the whole logic is correct.
If one day we have enough confidence about the pipe's behavior on all platforms, we can optimize this logic again.
ps: I have written a test program to test Sync, the result is:
2021/09/20 12:44:32 GOOS=darwin
2021/09/20 12:44:32 pipeWriter.Sync error: sync |1: bad file descriptor

2021/09/20 12:52:25 GOOS=linux
2021/09/20 12:52:25 pipeWriter.Sync error: sync |1: invalid argument

It's obviously wrong to call Sync on pipes in Linux / macOS.
Test Program:

```
package main
import (
"log"
"os"
"os/exec"
"runtime"
)
func main() {
log.Printf("GOOS=%v\n", runtime.GOOS)
var err error
pipeReader, pipeWriter, err := os.Pipe()
if err != nil {
	log.Fatalf("os.Pipe error: %v", err)
}

cmd := exec.Command("/bin/cat")
cmd.Stdin = pipeReader
err = cmd.Start()
if err != nil {
	log.Fatalf("cmd.Start error: %v", err)
}

_, err = pipeWriter.WriteString("test")
if err != nil {
	log.Fatalf("pipeWriter.Write error: %v", err)
}

err = pipeWriter.Sync()
if err != nil {
	log.Fatalf("pipeWriter.Sync error: %v", err)
}

}
</details>

Did you actually get this error reported? If you didn't - it's possible something else is actually happening:
Can you repeatedly replicate this issue?

Both yes, I added many debug logs and I am sure that ignore the Sync error will make the logic correct, and CheckPath can successfully ReadAttribute without Sync on my side.
And you can refer the test program to test Sync on pipes.

I too am running on Linux but didn't get the sync error you do - otherwise I'd have never put it in. I even tested in a Windows virtual machine.
Hmm, are you building with go 1.17? I know that at some point go moved to use pipe2 - maybe that doesn't error on sync.  Or maybe it's a kernel difference.

I also don't understand how an err at the Sync causes a hang. The logic there should abort and cancel the reader before a hang was possible at Read - at least that was how I intended it - so if there's a hang despite the error then that logic is failing somehow.
So I'm doubly confused and that makes me concerned that I've got the channel logic wrong somewhere in there - but I just can't see it.

Anyway if GIT_FLUSH env reliably prevents this hang along with ignoring the error on sync then I am happy.
But if the actual slow down/hang is not occurring because of the sync but at read - then you're likely suffering the same issue that the original native git implementation of commit info was suffering. That is, that although the write has been sent it's not reaching the git program or the git program's output is not reaching the read. If GIT_FLUSH prevents this then that was due to git buffering, if not then...
Perhaps placing a runtime.Gosched() in between the write and the read is needed? Another is changing the code to make things non-synchronous - that is push all of the paths in to git attribute channel, closing the writer at the end and reading them all. This would both fill the buffer and force go to schedule the other goroutines.

About environment
I have test the Sync on pipes with:

Debian 10 Linux 4.19.0-16-amd64 SMP Debian 4.19.181-1 (2021-03-19) x86_64 GNU/Linux
go version go1.16.2 linux/amd64
Debian 11 Linux 5.10.0-8-amd64 SMP Debian 5.10.46-4 (2021-08-03) x86_64 GNU/Linux
go version go1.17 darwin/amd64 with GOOS=linux
macOS 11.5.2
go version go1.17 darwin/amd64

Sync on pipes always fails and reports error sync |1: bad file descriptor for macOS or sync |1: invalid argument for Linux.
I believe that since Linux document says that fsync on pipes will fail, then here is a problem.
Why there is a hang
It seems that there are other flaws with git cat-file or git check-attr, eg: when the git process is killed by timeout, the go routine still exists, then I still can see a background git process has been running for over 3 hours (in the process.Manager), but I can not find the process in system's process list by ps.
Because there may be unknown bugs, when Sync returns an error and CheckPath returns early, there are more calls to CheckPath and fill the stdin buffer, then the Write in CheckPath blocks.


ERROR bad signature: Unknown signature subpacket: 33 (error 1002)

When trying to log in from the command line using keybase login, I encounter this error message after selecting option 1:
▶ ERROR bad signature: Unknown signature subpacket: 33 (error 1002)

Full output:
$ keybase login
Your keybase username or email address<EMAIL_ADDRESS>Please enter the Keybase passphrase for<EMAIL_ADDRESS>(12+ characters):
In order to authorize this installation, keybase needs to sign this installation
with your GPG secret key 8139C5FCEDA73ABF.

You have two options.

(1) Keybase can use GPG commands to sign the installation.

(2) Keybase can export your secret key from GPG and save it to keybase's local encrypted
    keyring. This way, it can be used in 'keybase pgp sign' and 'keybase pgp decrypt'
    going forward.
Which do you prefer?: 1
Enter a public name for this device: coloris
▶ ERROR bad signature: Unknown signature subpacket: 33 (error 1002)

The login works if I select option 2, though I'd still be interested to know why option 1 didn't work.
my log id: 09d13b105bc30f885b06581c
keybase version: 1.0.18
Go version: 1.7

Many many dupes on this one.

Hmm, you're right: #4947, keybase-issues#2668, keybase-issues#111. Though I looked quite hard for dupes, but obviously not hard enough.

I hope to get to this today or tomorrow.
On Wed, Dec 7, 2016 at 9:56 AM Kier Davis<EMAIL_ADDRESS>wrote:

Closed #5023 https://github.com/keybase/client/issues/5023.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/5023#event-885344254, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_yTnrHsvo1XIhN-nz2zIKbVNTrm5ks5rFskLgaJpZM4LGn22
.


MM-15462 Basic subscribe to jira events.

Basic channel subscriptions. Supports 1 subscription per channel.
Supports 3 events (Create, Update, Delete)
Supports fields of project and issue type only. (custom fields needs holistic support across both create and this)
Needs UI work.

Awesome! Quick questions

Supports 3 events (Create, Update, Delete)

1  - Is this for "issue" events, or also "comment" events? (from reading the diff file, looks like "issue" events only)

Supports fields of project and issue type only. (custom fields needs holistic support across both create and this)

2 - Can this be resolved after https://mattermost.atlassian.net/browse/MM-15589 is fixed? Or to be determined once MM-15589 is being worked on.

Needs UI work.

3 - Confirming that this be for @asaadmahmood in a separate ticket rather than this PR?
4 - Confirming that when a notification is posted to a Mattermost channel, is this using the same UI as for webhook-based notifications?

Issue events only. After https://mattermost.atlassian.net/browse/MM-15439 should be trivial to add.
Yes essentially these are the same issue.
I asked @asaadmahmood to do some modifications on this PR. There is also the known problem with dropdowns going below the modal.
Correct. No additional UI work was done here.

1 + 2: Sounds good and noted
3: Okay, also added to his "Jira UI update" ticket for tracking
4: +1

@cpoile Ready for re-review!

Updated the icon @crspeller Need to look at the other UI stuff but it's not working fine for me locally.
The icon also is not vertically centered, but I have submitted a PR for that on the webapp.
https://github.com/mattermost/mattermost-webapp/pull/2818

@levb Ready for re-review.

Cherry-picked into master


Use AzureIdentity SDK or MSAL instead of ADAL

Which version of the AzCopy was used?
V10.16.0
Which platform are you using? (ex: Windows, Mac, Linux)
Linux
What command did you run?
I'm trying to use azcopy with Azure AD Workload Identity without using Workload Identity's proxy sidecar. The proxy sidecar is used to intercept token requests to IMDS and acquire an AAD token on behalf of the user with federated identity credential. Unfortunately, our use case requires running azcopy in a k8s init-container therefore we can't rely on the proxy sidecar.
Based on this comment if a project uses the AzureIdentity SDK or MSAL then there is no need for the proxy sidecar. However, it seems azcopy is using ADAL, which is both deprecated and prevents azcopy to be used in an init-container.
The command below only works in conjunction with a proxy sidecar:
azcopy login --identity --identity-client-id < client ID of a managed identity >
What problem was encountered?
Not using Azure AD Workload Identity's proxy sidecar will make azcopy fail to acquire a token.
How can we reproduce the problem in the simplest way?

follow the installation guide for Workload Identity
create a pod without the proxy sidecar (this is the default behaviour)
attempt to run azcopy login --identity --identity-client-id < client ID of a managed identity >

Have you found a mitigation/solution?
No

With ADAL being deprecated on June 2023, @zezha-msft how do you plan to migrate to MSAL or AzureIdentity library ?

Hi @jbpaux
The plan is to migrate azcopy to the new Azure Identity library  https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/azidentity This is work we have scheduled and will get to it soon.

Perfect @gapra-msft please target 1.3.0+ as it support Workload Identity 😉

Hi @gapra-msft  Do you have any updates on this issue?  It would be helpful if you could comment on the ETA  if you have one.

Hi, we are currently blocked on the MSAL and Azure Identity SDKs until they add support for token cache persistence. https://github.com/Azure/azure-sdk-for-go/issues/16643
We have almost completed the bulk of the work on our end to upgrade, we are just waiting on this support.

@gapra-msft , will it be possible after migrating to MSAL and Azure Identity SDk to share a token cache with other applications? In my use case, a long-running service application already uses MSAL to obtain a valid token. Occasionally, azcopy is called to perform actions. At the moment, this requires re-authenticating in the azcopy child process due to the opaque token cache persistance, or abusing $env:AZCOPY_OAUTH_TOKEN_INFO.

Hi @maikschulze I would recommend you create a new Github issue describing the details of the scenario you are interested in. Then, the team will internally discuss this and get back to you on our thoughts.

I got tired of waiting on this, as its a massive blocker for our usecases, and only gets worse as time marches forward.  So, for those of you in the same position we're in, I patched in azidentity 1.3.0 to replace the MSI implementation for ADAL, which works in our initial testing.  https://github.com/Azure/azure-storage-azcopy/compare/main...randywallace:azure-storage-azcopy:add-default-azure-credential-msal?expand=1 .  I'm not opening a PR, b/c I'm all but certain the implementation is not sustainably mergeable, but for those that need this, here it is, until this issue is resolved.

It seems to be available in next version 10.21.0 in preview

Hi, yes we have upgraded most of the OAuth logic to the new azure identity SDK, with the exception of device code credential, as of 10.21.0
Closing this issue as this has been addressed in a recent release.

Hi @gapra-msft,
Original task was about using "azcopy with Azure AD Workload Identity", not about SDK upgrade.
When I tried 10.21.0 a couple weeks ago it wasn't working as expected.
Is there a config, environmental variable setup that I am missing?
Related issue: https://github.com/Azure/azure-storage-azcopy/issues/2112

Hi @gapra-msft
Would also like to have some instructions on how to use workload identity/federated credentials, if it's already supported by azcopy. Thanks!

@rpahli we are tracking adding native support to AzCopy for workload identity here. Please subscribe to that issue for updates.


Allow passing boostrap configuration via environment variables instead of config file

Having to manage the configuration files in container is a real drag.  Given traefik is focused on dynamic and automatic configuration, it would be nice if we could simply bootstrap the configuration with the minimal configuration that is needed to enable access to the backend provider via environmental values.

Hi @BrianAdams, there is already an issue on that point: #7


Effective type of a type referred intersection type contains wrong information

Description:
$subject
Consider the following code,
type Detail int[];

type IntersectionType Detail & readonly;

At the code generation, the intersection type created for the type reference type IntersectionType is as follows.

Note that the effective type of the IntersectionType is a BArrayType and not the type reference type for Detail.
IMO, it should be a BTypeReferenceType with the name Detail where the readonly bit is set as true.
Similar behavior can be observed for the intersections with other types.
Affected Versions:
latest master
Related Issues (optional):
This will affect some parts of https://github.com/ballerina-platform/ballerina-lang/issues/36855

Since effective type is an internal representation we can argue that this is fine because the members contain the correct typereference type.
Anyway, this behavior will change with https://github.com/ballerina-platform/ballerina-lang/issues/24078 not to unwrap to get the effective type.