Danger at top level

          1 Warning

:warning:
Please provide a summary in the Pull Request description

  Generated by :no_entry_sign: Danger


QuickConvertorV2_Scintilla gets spammed with warnings when reloaded

To reproduce

Run QuickConvertorV2_Scintilla.ahk
Press Reload (The issue is a lot easier to see when testmode is on)

The error (sorry about partial transparency, it kept opening and closing so it was hard to get a quality screenshot)

That line is in /lib/scintilla.ahk

Turns out it's actually on closing, press esc while testmode is on

About half of the errors can be fixed by setting scintilla.ahk L389 to If (this.CustomSyntaxHighlighting && WinExist("Quick Convertor V2")) {
The other half I think are caused by the convertor not actually exiting after it's finished the exit routine


Add UserLoggedIn hook to SignInManager

I'm writing my custom SignInManager which is derived from Microsoft.AspNet.Identity.SignInManager. Right now I'm looking for a way to perform some action whenever the user has successfully logged in, regardless of the method he used (password, external, with/without two factor). That action could for example be setting a LastLogin field in my ApplicationUser.
I could override SignInAsync but it looks like this method not only gets called when the user has explicitly logged in but also on other occasions.
Or I could override PasswordSignInAsync, TwoFactorSignInAsync and ExternalLoginSignInAsync. Here I have to look at the sources to find out which overload of PasswordSignInAsync is the right one to override (or I just override all of its overloads), but this is not so future proof, since these implementation details could change in future versions.
Long story short: I think it would be nice to have some hook in SignInManager which gets called whenever a user has logged in.

Would #650 meet your requirements?

No because I also need to perform some project specific actions after login.

As discussed with @rustd last week

Unassigned since this is in backlog, reassign when we want to do this.

adding that would be great, I noticed that it's a common pattern that leads people o custom implementations, some "hooks" to perform extra work would be fantastic.
Thanks

Given that the current virtual SignInAsync catches too many flows for you, I think the best approach would be for you to extend exactly which methods you want to do your additional post SignIn logic.

All the hooks should already be there as every method is already virtual


Add alternative domain validation for custom domain

Originally reported by @liprec
Is your feature request related to a problem? Please describe.
To add a custom domain to the Azure Static Web App service you need to add a CNAME record for the custom (sub)domain that points to the *.azurestaticapps.net URL to validate the ownership of the domain.
If you want to move your current production site to the Azure Static Web App service this validation and assignment step will need downtime of your website due to the DNS change.
Describe the solution you'd like
An option to validate the custom domain via an alternative way so the move of the site can only triggered by an DNS update. Alternative validation can be done via a TXT record or via an alternative CNAME record (see e.g. the CDN option: https://docs.microsoft.com/en-us/azure/cdn/cdn-map-content-to-custom-domain#map-the-temporary-cdnverify-subdomain)

Someone of the team can close this issue as this option is available. Thanks and congratulations with the GA 🎉!


chore(dev): release tunarr 0.4.2

:robot: I have created a release beep boop
0.4.2 (2024-08-04)
⚠ BREAKING CHANGES

use OS-specific, stable path for default Tunarr data directory (#643)

Features

ability to manually add Plex servers (#622) (7027efc)
add ARM builds (#618) (c2d5a66)
implement on-demand channels (#613) (13fe504), closes #612
support for intermittent watermarks (#644) (9b490b2), closes #492
support setting opacity on channel watermarks (#621) (9480aa2), closes #615
use OS-specific, stable path for default Tunarr data directory (#643) (1c56752), closes #620
web: display channel duration and program count on channels page (#617) (7564a4b)

Bug Fixes

ambiguous column error when selecting all filler shows (#635) (ddb0723), closes #634
cannot use createRequire in web-module; move version function to server (#641) (7175f15)
default disableChannelOverlay to false (df8192b)
define platforms for docker edge build workflow (a1ad921)
do not double suffix docker image tags for latest (8501eca)
double star for tag event? (2d0fce1)
navigation blocker appeared after channel update (#645) (a2809d8)
new custom show programming button led to wrong path (#647) (554a003)
properly save filler list / channel associations (#610) (017eca5)
single edge build failure should not affect other builds (d8840ac)
tag matching in docker release; remove quote and semver specific (0c45071)
Use inputted name for new filler lists (38f76d1)
use PAT for release-please so tag pushes trigger releases (f8f524d)
workaround for macOS binary release (#608) (8b8f6f8)

Miscellaneous Chores

manual release (b24c231)
manual release (356249c)

This PR was generated with Release Please. See documentation.

Not sure what is up with the releaser here....

:robot: Created releases:

tunarr-v0.4.2
:sunflower:


Any Mod adding spells missed some spells

Describe the bug
Any Mod adding spells to the base classes not work as it should be, some spells are not included when creating a spell list
To Reproduce
Steps to reproduce the behavior:

install MysticalMayhem 0.6.6f(should load before isekai)
goto DLC1, create a char with IseKai class and level up
the spell list missed spells from MysticalMayhem
recreate a basic class - Mage and level up
spells from MysticalMayhem are in the list correctly

Expected behavior
IseKai spell list created should included spells from MysticalMayhem
Additional context
the spells are also in Oracle and so on, maybe same spell from different list cause the problem? Or, the spells are NOT really added to the base classes?

In addition, another bug in UMM loading log:
[IsekaiMod] reference class=1b9873f1e7bfe5449bc84d03e9c8e3cc feature re-encountered at level=10 guid=d3135a2ddba34502b82670ed770c9068 name=SecondPatronRequisiteFeature
[IsekaiMod] ERROR: Attempt to patch Progression Tree stopped at Level 10 to prevent endless loop, if you see this message please report so we can figure out if someone created a loop here or if this limit needs to be higher
[IsekaiMod] ERROR: reference class=1b9873f1e7bfe5449bc84d03e9c8e3cc Stop Feature=d3135a2ddba34502b82670ed770c9068 name=SecondPatronRequisiteFeature
[IsekaiMod] ERROR: guid=381cf4c890815d049a4420c6f31d063f [IsekaiMod] ERROR: guid=08518b2a62446c74b9ae08ee73664047 [IsekaiMod] ERROR: guid=9f2e7426e5e61224e93d2c3072bf9c1c [IsekaiMod] ERROR: guid=beb4a8ad0033dbf47939c96ec14583fa [IsekaiMod] ERROR: guid=38d34391d7cf2da4e8705c2cb23edd30 [IsekaiMod] ERROR: guid=88b19f1f895da364099c5975b04b2fdc [IsekaiMod] ERROR: guid=2e44d8b36eb8be14db7bf05a1cc81df1 [IsekaiMod] ERROR: guid=68e539d674b037f4a8db194e8307b8fb [IsekaiMod] ERROR: guid=2c5574dce48718d449183d8c5056d286 [IsekaiMod] ERROR: guid=6164c2aa71247bd4d91274ebe93a6c0f [IsekaiMod] ERROR: guid=1e418c5f030347542ad47dd752cdea05


Problem with sending cookies

I have react-redux application and server on nodejs. I make authentication using jsonwebtoken. After I receive token on client side I put it inside httpOnly cookie. Next I make an authorized request to API with flag credentials : 'include',  but I receive empty object instead of cookie on server.
I was trying twise. First on localhost ans second - using two aws ec2 instances. Same result - I can't get my cookie. I don't know is it an issue, but it could be and I want to know how to send cookie properly.

An HttpOnly cookie may only be set by the server in an HTTP response. Client-side scripts cannot read or send HttpOnly cookies—they must be managed by the browser and server.
See https://github.com/github/fetch/issues/236, https://github.com/github/fetch/issues/163, and https://github.com/github/fetch/issues/138 for cookie discussions.

Thanks for your answer. Unfortunately,the problem is still not solved. I am setting cookies with res.cookie() on Node.JS server, then I make fetch with credentials : 'include' option and I have no cookie in request according to my server log.

I'm sorry that your problem isn't solved yet. The think with cookies is that their handling is left entirely by the browser. In browsers that support window.fetch natively, such as Chrome and Firefox at the time of this writing, cookies will be handled hopefully according to the WHATWG fetch spec. If you see that's not the case, then you'll have to take it with the respective browser's bug trackers.
In other browsers, such as Safari and IE, this polyfill will kick in and implement fetch using XMLHttpRequest as the underlying implementation. In this case, we also don't have any way of manipulating how cookies are handled— that is left entirely to the browser's implementation of XMLHttpRequest. So, it's very unlikely that this project (the polyfill) can break cookie handling because it doesn't have any access to it.
Most people's problems with cookies ultimately boiled down to their improper approach to cross-origin requests (CORS). If the requests that you're making with fetch are to another domain name (or a different port number even), you will have to double-check all the server headers that can affect CORS requests. Other than this, we can't really help you with this particular authentication problem. If everything else fails, you can always implement authentication not using cookies, but exchanging some kind of token manually via custom headers or URL query parameters.

i agree with you ,CORS with cookie is never worked! @mislav @NikitaLiashenko


chore(docs): reorder alphabetically list of components

Backport of https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1188, this PR is a proposal to reorder alphabetically the list of components in the documentation.
I'm not sure this is the only place in the docs in v4 where we have a list of components.

Maybe we could add docs\4.6\about\boosted-history.md to this PR :)

I knew that I would forget one list :smile: Thanks LM. Fixed in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/1195/commits/6afbd95af3f732dddc41549984976cfd22a4b807.


don't call sync if email is not verified

If a user goes into the app without signing in, 5 minutes into their session we call sync get/set which pushes up a backed up wallet. This causes an issue once they actually sign into because their wallets cannot be merged (their new user id, has this incorrect sync, is merged into their original account and fails).
The API could also prevent syncing if email is not available.

Fixed.


Add comments to NgCachingCompiler

That explain how it fits into Meteor's caching compiler API

@dotansimha please reference the commits

All compilers work are in : https://github.com/Urigo/angular2-meteor/commit/66593685ac30cfd3734c11f152befb6536212395


No need to call Sentry if user quits with CTRL+C

sct_download_data -d deepseg_sc_models

--
Spinal Cord Toolbox (cJ-misc/5fe166c4f750a32192ee110a3460a00e9f5ec1cf)
Running /Users/julien/code/sct/scripts/sct_download_data.py -d deepseg_sc_models

Trying URL: https://osf.io/mg8wr/?action=download
Downloading 20180211_deepseg_sc_models.zip...
Status:   0%|2                                                   | 172K/37.2M [00:00<02:58, 207KB/s]^C
ERROR: User canceled process.

Traceback (most recent call last):
  File "/Users/julien/code/sct/scripts/sct_download_data.py", line 205, in <module>
    main()
  File "/Users/julien/code/sct/scripts/sct_download_data.py", line 111, in main
    sct.printv('\nERROR: User canceled process.\n', 1, 'error')
  File "/Users/julien/code/sct/scripts/sct_utils.py", line 1093, in printv
    raise RuntimeError("printv(..., type=\"error\")")
RuntimeError: printv(..., type="error")
Sentry is attempting to send 1 pending error messages
Waiting up to 10 seconds
Press Ctrl-C to quit
Note: you can opt out of Sentry reporting by editing the file ${SCT_DIR}/bin/sct_launcher and delete the line starting with "export SENTRY_DSN"

Fixed by #1872


[WIP] Packet: Switch to official Flatcar images from Packet

This PR switches from iPXE-booting Flatcar to using official Flatcar images from Packet.
Also fixes https://github.com/kinvolk/lokomotive-kubernetes/issues/27.
We should merge this only after Flatcar is generally available in all Packet facilities.
Testing
At the moment official Flatcar images are available only in the sjc1 and nrt1 facilities in preview mode, so this PR can be tested only using these facilities.
Please use the updated docs from this PR when testing since the PR includes variable changes.

core@test-pool-1-worker-0 ~ $ sudo fdisk -l /dev/sda
Disk /dev/sda: 111.8 GiB,<PHONE_NUMBER>76 bytes, 234441648 sectors
Disk model: SSDSCKJB120G7R
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes
Disklabel type: gpt
Disk identifier: 18D4FFCD-565C-41F3-A945-C038B5C61C5F

Device       Start       End   Sectors   Size Type
/dev/sda1     4096    266239    262144   128M EFI System
/dev/sda2   266240    270335      4096     2M BIOS boot
/dev/sda3   270336   2367487   2097152     1G unknown
/dev/sda4  2367488   4464639   2097152     1G unknown
/dev/sda6  4464640   4726783    262144   128M Linux filesystem
/dev/sda7  4726784   4857855    131072    64M unknown
/dev/sda9  4857856 234441614 229583759 109.5G unknown
core@test-pool-1-worker-0 ~ $ sudo fdisk -l /dev/sdb
Disk /dev/sdb: 111.8 GiB,<PHONE_NUMBER>76 bytes, 234441648 sectors
Disk model: SSDSCKJB120G7R
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes
core@test-pool-1-worker-0 ~ $ sudo fdisk -l /dev/sdc
Disk /dev/sdc: 447.1 GiB,<PHONE_NUMBER>56 bytes, 937703088 sectors
Disk model: SSDSC2KB480G7R
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes
core@test-pool-1-worker-0 ~ $ sudo fdisk -l /dev/sdd
Disk /dev/sdd: 447.1 GiB,<PHONE_NUMBER>56 bytes, 937703088 sectors
Disk model: SSDSC2KB480G7R
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes

Disk layout for c2.medium worker after installation.
My only concern is that we have 2 disks for OS, but we don't use RAID 1... But in case of CoreOS, that doesn't really matter I believe, since we shouldn't keep data on OS disk anyway.

Since Flatcar Images are not yet available in all regions and we still have some issues to address, I guess we should delay merging this PR, what do you think?

I've tested this PR with the following options:

Channel: stable, beta, alpha
Facility: ams1, ewr1, nrt1, sjc1
Type: t1.small.x86, c2.medium.x86

Everything works fine.
It's really great that it takes only 10~12 minutes until a working k8s cluster became provisioned.
I've seen the issue of multiple block devices with c2.medium.x86 as mentioned above.
I'm not completely sure, but it looks like that's not a common use case. I would say, that should be a separate issue we should further investigate.
So +1 for merging this PR.

@dongsupark I strongly disagree on merging this.
There are two things to address:

Setup RAID 0 array (that was before but this PR removes it, see here: https://github.com/kinvolk/lokomotive-kubernetes/pull/28#discussion_r296000926)

Packet Flatcar Linux images create issues with node local storage.

Let me elaborate a littleprovisioning works with c2.medium.x86 but it uses a "random" disk to install (this is the way the Packet Flatcar Linux image is currently working). This, basically, breaks reasonable usage of node local storage on servers with more than one disks, and it would be a regression on current master. I explained the problem in more detail in this comment: https://github.com/kinvolk/lokomotive-kubernetes/pull/28#discussion_r301029722
As that is out of our control (is the way current beta Packet images work) and:

Is currently working on master without using them
Already have a meeting with Packet and they will fix it soon

I think we should wait, so we merge this when it won't break existing users of node local storage.
What do you think? Or am I missing something?

Ok, if you say so, I'm fine with waiting until Packet fixed the issues.
I'm just wondering, if it's simply possible to fall back to the ipxe variant for c2.medium.x86, like it's done in the current master branch. That would be a fairly simple workaround.
That's why I'm not sure if the multiple block storages issue is a hard blocker.

@dongsupark It is not just c2.medium, but any server with more than one disk. I think only t1.small.x86 and s1.small.x86 may be the only ones with one disk (had a quick look at the site, not sure).
But yeah, that is a valid work around too. Not sure if it's worth the complexity, but maybe is because I'm too lazy. I'm okay with that temporary approach :)

Came here to say that I just provisioned a 1 controller - 5 worker cluster from the commit a59aa8769d9bbca162c99964f421303845f84513 from this PR and it just worked! :tada:

@johananl pending when this PR gets merged, please can you help ensure that this branch is up to date with master in the mean time?

@kosyfrances since @johananl is usually busy, maybe you can rebase it and test if you need it? It seems that new RAID configuration options needs to be ported here. You can push to PR branch without problems.
Did we confirm with Packet that OS is now installed on smallest disks always?

Did we confirm with Packet that OS is now installed on smallest disks always?

@pothos confirmed, that OS is now installed on smallest disk only.
I guess we could merge after rebasing then.
Also #54 is coming, which changes RAID script again.

Not having the latest RAID variables are not a blocker as far as I remember but of course it would be nice to have them ready when merging. @surajssd Do you want to add a patch on this branch providing the same functionality? Or should we delay it and create an issue for doing it in the next weeks?

@kosyfrances I'll reabse this later today.

@kosyfrances @pothos @invidian @rata rebased over current master.
I've included the RAID-related changes from master as of 4b5174bfba533702382a55e186cd78030b721e2d but did not include https://github.com/kinvolk/lokomotive-kubernetes/pull/54 as it's not merged yet.
I am currently testing. Will do my best to check on multiple Packet regions. Please feel free to do the same. If all looks good I'll request a final review and I think we can merge.

Packet regions tested:

[ ] yyz1
[ ] mrs1
[ ] dfw1
[ ] hkg1
[ ] ams1
[ ] dfw2
[ ] syd1
[ ] sea1
[x] sjc1 (tested by CI)
[ ] nrt1
[ ] ewr1
[ ] atl1
[ ] lax1
[ ] sin1
[ ] ord1
[ ] iad1
[ ] fra2

So, the variables for SSD and HDD RAID are present but not used now, right?

So, the variables for SSD and HDD RAID are present but not used now, right?

Oh, just realized we don't have install.yaml.tmpl anymore. I guess it doesn't make sense to have these vars in this PR then.
Any idea what we should do here?

Summarizing offline discussion with @pothos:
We should port the RAID-related logic from install.yaml.tmpl to worker.yaml.tmpl so that the setup_raid_* vars take effect.
We should consider the refactoring in https://github.com/kinvolk/lokomotive-kubernetes/pull/54 when doing so.

I updated my last commit to include the disk-type-specific RAID setup. While porting I fixed some bugs and am testing it now. If worth the effort to rebase this here once more I can also make PRs for the spotted bugs (commented in https://github.com/kinvolk/lokomotive-kubernetes/pull/48).

Thanks for helping @pothos.
I guess my only remaining concerns before merging are:

We didn't test all Packet regions.
We don't have automatic updates of new Flatcar versions on Packet, so new clusters will use an older image.

As far as I'm concerned we can merge since we've tested our most "important" regions and we can probably fix problems in others by pinging Packet after merging.
Regarding Flatcar updates - I'm personally fine with using a slightly-older Flatcar image for clusters until we have an automated publishing mechanism for images on Packet.

I think the update issue was solved because there is a mirror script running regularly and the installer fetches the image from the local mirror while installing.

I've just tested this PR in ewr1. It works well.
So it's confirmed that it works in all 4 major regions.
It installs still Flatcar stable 2079.6.0, which is a little behind.
Anyway I don't think that's a blocker, as there's nothing we can do about it.
:+1: for merging it.

I'm testing it on all available regions now. On FRA2 was the latest stable version. If we observe that some regions don't catch up in the next days, we can report it.

I've tested all the regions a few days ago (past Friday?) and it worked in all but SIN1, report it and they fixed it. So, I feel confident about that too :-)


CommandHandler | Error in cleverbot - Updated to latest version

Hello, I am having an issue with the bot where attempting to use cleverbot returns the error "CommandHandler | Error in cleverbot". I have updated to the latest version as described in the other issues, but this does not seem to help.

I would like to add that we were using it VERY heavily last night. Could the clever bot website have blacklisted my bot somehow because it thought we were spamming it?

I'm getting the same error as of recently. I've tried both a Linux and Windows copy with the same credentials, and neither are working.

I have done a bit more troubleshooting here. I have tried accessing the cleverbot site through an internet browser and when I query it, it returns no results. I am unsure if this is a result of my IP being blacklisted or their site is experiencing issues. @StewieFellows can you attempt to use the bot at www.cleverbot.com and see if you get the same results?

I'm having this error as well. I run the linux version of Nadeko on my linode VPS. I can ping the cleverbot website but don't have a good way to test actually using the bot on my machine.

Nadeko\NadekoBot\src\NadekoBot\Services\CleverBotApi
Open ChatterBotFactory.cs
Go to line 35
You will see something like:
http://www.cleverbot.com/webservicemin?uc=3210&botapi=chatterbotapi
Edit the 3210 to 777
Restart your bot
And it should work again. :D

@Gremagol That worked for me :) Thank you! No clue how you figured that out.
Hopefully I won't have to edit that every time I update.

 :)

As of today, the fix from @Gremagol is no longer working for me (same error as before). Anyone else notice this?

Change the 777 to UseOfficialAPI

Should work then :D

Update to latest again.

I would like to say that this issue is occurring again on the latest version. The UseOfficialAPI fixed described by @Gremagol no longer works either.

@roflsausage The devs are aware, but this is because the unoffical API no longer works at all. There is an official one, but it would probably require reworking some code to get it swapped in, and the free version won't support the bandwidth of requests the public bot was getting before. I'm not sure if the devs are even planning to swap it over to the official API or not, so hopefully they can give an answer as to whether or not that will be done. I would gladly get my own API key if I had to supply one for my copy.

can someone describe how i would insert my own API key into ChatterBotFactory.cs? I don't seem to get the hang of the url formatting in the python code.

#1076

@HailfireCCS Even if you have an official API key, the URL in ChatterBotFactory is not for the official API, and the code utilizing that URL is intended for the unofficial API that no longer works.

what now? UseOfficialAPI no longer works

Latest version of nadeko used another API, it's called Program-O.

guess i need to update then


Update understanding-permissions-when-migrating.md

updated typo: https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/commit/a6f4262447f774d12144a4a09aca325dad351597

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Integrate vim/slimv/tmux

This adds support for editing Common Lisp files using the vi family of editors, using vim, slimv, and tmux.
The documentation in the README.md file has been expanded to include both pointers to tutorials on Common Lisp, and to the editor extensions slime, and slimv.

As a bit of background, I was inspired to extend this package to offer vim and slimv after reading the State of the Common Lisp Ecosystem, 2015](http://eudoxia.me/article/common-lisp-sotu-2015/) and reading:

SLIME is a Common Lisp IDE built on Emacs, and the most widely-used CL IDE. The fact that it’s built on Emacs is a problem, as telling a new user they have to learn Emacs before using SLIME (which is not strictly true) is a significant artificial barrier to entry.
Consolidation:

Reduce the barrier to entry to using SLIME

Future Work:

Non-Emacs IDEs can’t hurt. An Atom plugin that interfaces with a Swank server, for instance, would be pretty great.

Many people with a computing background use vi editors proficiently, this combination could provide an easy entry for them into common lisp programming. I'm a Common LISP beginner who is much more comfortable in vi than emacs, for example.
Yes, there's a lot of additions here, but having slimv available is good. I also added syntastic which has proved invaluable to me in dealing with other languages (bash, python, ruby, etc) over the last couple years. I had to add clisp to the set of installed packages to support syntastic; it's error messages are arguably more friendly than the ones that sbcl produces, which is a nice bonus.

So many thanks for your contributions! :)

You are welcome! :fireworks: :100: :memo: :dancers:


Edit profile features

As an authenticated user I would like to:

[x] change my public name
[x] change my password (with previous password confirmation)
[ ] change my email (with confirmation)
[ ] change other stuff in profile (description, avatar, things like this)

To discuss: "Edit profile" page fields should be asynchronous, eg. changing values in inputs should automatically save them in database. I would see it as forms in Blade files on one /profile/edit page and some calls to API within.

Hi, I have one question about confirmation new email.
Confirmation with user password or email message or what?

Hi, I have one question about confirmation new email.
Confirmation with user password or email message or what?

Confirmation with user password or email message or what?

@kamilpiech97, I think that an e-mail confirmation would be OK.

Confirmation with user password or email message or what?

@kamilpiech97, I think that an e-mail confirmation would be OK.

@krzysztofrewak i have question about psalm.
I use Carbon parser in mutator at Profile Eloquent claas and when i checked project with Psalm i have errors like this https://github.com/vimeo/psalm/issues/1325 - missing throwblocks. Do you have any solution for that or something.

@krzysztofrewak i have question about psalm.
I use Carbon parser in mutator at Profile Eloquent claas and when i checked project with Psalm i have errors like this https://github.com/vimeo/psalm/issues/1325 - missing throwblocks. Do you have any solution for that or something.

I would add what kind of exception is being thrown there:
    /**
     * @throws InvalidFormatException
     */
    public function setBirthdayAttribute($value): void
    {
        $this->attributes["birthday"] = Carbon::parse($value);
    }

I would add what kind of exception is being thrown there:
    /**
     * @throws InvalidFormatException
     */
    public function setBirthdayAttribute($value): void
    {
        $this->attributes["birthday"] = Carbon::parse($value);
    }

The frontend we will add to new feature branch like "frontend/livewire" etc.
I think it is good idea and we must choose livewire, laravel blades or something like Vue.js

The frontend we will add to new feature branch like "frontend/livewire" etc.
I think it is good idea and we must choose livewire, laravel blades or something like Vue.js


Adding test_036 operator volume re-provisioning.

@antip00
could you rollback https://github.com/Altinity/clickhouse-operator/pull/1052/commits/012046f7d7eddc240e69eb5f7ec910a5d42c506c ?
look like you apply some strange formatter
and it make too much changes, to code which not related to your pull request

I added changes regarding last comments


Add enable_docker_enroot_pyxis, enable_observability in config.py

Description of changes:

Adding enable_docker_enroot_pyxis, enable_observability in config.py so that lifecycle_config.py doesn't have to be edited to enable/disable features.

Install docker/enroot/pyxis by default.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Addressed feedback. Please review again.

If I run install_docker.sh twice, it fails. Investigating now.

Fixed docker 2nd installation failure

LGTM - let's make sure to update the workshop and merge at the same time.


Bst open too many files which causes OSErrors for the next calls

See original issue on GitLab
In GitLab by [Gitlab user @alatiera] on Aug 15, 2018, 09:38
Summary
While trying to build gnome-build-meta today, I hit the following bug. bst seems like it have opened too many File descriptors and the rest syscalls failed with  OSError: [Errno 24] Too many open files
Steps to reproduce
Not really sure how to reproduce it, It only happened once thus far. I had a recent checkout and build artifacts of the project, did a git pull and tried building again. Most of the fetches should have pulled down little if anything at all.
What is the current bug behavior?
For each pull task the following happened:
An unhandled exception is thrown that keeps. Upon control-C neither quit nor terminate options seem to be able to exit.
What is the expected correct behavior?
Buildstream never gets to have too many files open at which point the syscalls start to fail.
Relevant logs and/or screenshots
I couldn't copy more than a task due to a weird bug with my terminal, but the following trace was identical for the rest of the too.
Unknown exception in SIGCHLD handler
Traceback (most recent call last):
  File "/usr/lib64/python3.6/asyncio/unix_events.py", line 819, in _sig_chld
  File "/usr/lib64/python3.6/asyncio/unix_events.py", line 885, in _do_waitpid_all
  File "/usr/lib64/python3.6/asyncio/unix_events.py", line 919, in _do_waitpid
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/jobs/job.py", line 557, in _parent_child_completed
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/scheduler.py", line 238, in job_completed
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/scheduler.py", line 288, in _schedule_queue_jobs
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/queues/queue.py", line 174, in enqueue
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/queues/queue.py", line 174, in <listcomp>
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/queues/queue.py", line 171, in create_job
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/jobs/elementjob.py", line 69, in __init__
  File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/jobs/job.py", line 112, in __init__
[--:--:--][????????][ pull:bootstrap-junction.bst:coreutils.bst] START   freedesktop-sdk-bootstrap/coreutils/????????-pull.4976.log
[--:--:--][????????][ pull:bootstrap-junction.bst:coreutils.bst] INFO    Pulling ???????? <- https://cache.gitlab.gnome.org:11001
[--:--:--][????????][ pull:bootstrap-junction.bst:coreutils.bst] INFO    Pulling ???????? <- https://testcache.codethink.co.uk:11001
[--:--:--][????????][ pull:bootstrap-junction.bst:coreutils.bst] INFO    Pulling ???????? <- https://cache.gitlab.gnome.org:11001
[--:--:--][????????][ pull:bootstrap-junction.bst:coreutils.bst] INFO    Pulling ???????? <- https://testcache.codethink.co.uk:11001
[00:00:01][????????][ pull:bootstrap-junction.bst:coreutils.bst] SUCCESS freedesktop-sdk-bootstrap/coreutils/????????-pull.4976.log
[--:--:--][????????][ main:bootstrap-junction.bst:coreutils.bst] BUG     Unhandled exception in post processing

    Traceback (most recent call last):
      File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/queues/queue.py", line 310, in _job_done
      File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/queues/pullqueue.py", line 65, in done
      File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/scheduler.py", line 332, in _check_cache_size_real
      File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/jobs/cachesizejob.py", line 25, in __init__
      File "/usr/lib/python3.6/site-packages/buildstream/_scheduler/jobs/job.py", line 112, in __init__
      File "/usr/lib64/python3.6/multiprocessing/context.py", line 102, in Queue
      File "/usr/lib64/python3.6/multiprocessing/queues.py", line 42, in __init__
      File "/usr/lib64/python3.6/multiprocessing/context.py", line 67, in Lock
      File "/usr/lib64/python3.6/multiprocessing/synchronize.py", line 163, in __init__
      File "/usr/lib64/python3.6/multiprocessing/synchronize.py", line 60, in __init__
    OSError: [Errno 24] Too many open files

Possible fixes
Other relevant information

BuildStream version affected: 1.1.6 /milestone %BuildStream_v1.1

In GitLab by [Gitlab user @tristanvb] on Aug 15, 2018, 10:06
My theory about this issue is that we are hitting the limit when we have a lot of short lived processes.
We probably need to explicitly trigger the GC to cleanup the Queue instances related to terminated/completed jobs, and ensure we aren't relying on periodic GC to cleanup the fds whenever python thinks it's a good idea.
These docs might be helpful: https://docs.python.org/3/library/gc.html

In GitLab by [Gitlab user @alatiera] on Aug 15, 2018, 10:47
The following log might also be relevant, seems like its the same issue.

In GitLab by [Gitlab user @jonathanmaw] on Sep 4, 2018, 14:17
Hi, I'm not sure if I have the exact same problem, but I definitely have a case that I can replicate.
To replicate
Using a modified bstgen (https://gitlab.com/BuildStream/benchmarks/tree/jonathan/fix-bstgen/contrib/bstgen), create a pipeline containing 10000 elements:
bstgen -n 1 -f 1024 -p 10000 -s dots test-dir
bst build build_all.bst
The results
This will cause buildstream to crash while queueing up the jobs, as Job creates a multiprocessing.Queue() when it's instantiated, as opposed to when it's started.
I managed to work around this by moving the creation of the queue into Job.spawn().
With that change, the number of open file descriptors seems to gradually increase. I'm currently chasing down the cause here, but thought this might be helpful in the meantime.

In GitLab by [Gitlab user @danielsilverstone-ct] on Sep 4, 2018, 16:44
Tristan was pretty much spot on when he suggested it might be leaking queues.  Jonathan's suggestion to move the multiprocessing.Queue() into Job.spawn() helps by only creating those pipes when a job is ready to run.  However the job's sentinel FD and the job's queue FDs are left open upon completion.
Sadly a cheeky gc.collect() in the scheduler, while it causes things to get cleaned up, is really quite slow since it'll walk every object in the interpreter (which with the test case from [Gitlab user @jonathanmaw] above is super-slow, i.e. ca. 1s per call).  gc.collect(generation=0) or gc.collect(generation=1) does not seem to clean up effectively (nor both) I imagine because those objects have lasted long enough to get into generation 2.  gc.collect(generation=2) is essentially the same as gc.collect() in terms of time cost (generations 0 and 1 are undetectably quick to my eye) and does achieve the collection of the objects.
I will look harder into a way to persuade the queue and process sentinels to be released on demand.

In GitLab by [Gitlab user @danielsilverstone-ct] on Sep 4, 2018, 17:26
mentioned in merge request !778

In GitLab by [Gitlab user @danielsilverstone-ct] on Sep 5, 2018, 13:39
[Gitlab user @alatiera] Could you try with master bst now that !778 is merged?  If that resolves your issue it'd be handy if you could close this issue.  Thanks.

In GitLab by [Gitlab user @tristanvb] on Nov 4, 2020, 10:34
At this stage the too many files issues is pretty much fixed.

In master, with buildbox-casd, the issue does not happen.

In 1.6.x, without buildbox-casd, the problem still occurs when build processes open many files (lots of hyperthreading going on within a single build job), but only on platforms where the default limit of file descriptors is low, best to configure a reasonable limit on these systems.


[docs] fix wrong package name

What is the purpose of the change

fix wrong package name in document

Documentation

Does this pull request introduce a new feature? (no)

nice catch, merging.


server wont auto start and ctrl-alt-o or menu toggle dont work

Hello,
I'm using atom on sp4 running windows 10 pro and I've installed omnisharp, but it does nothing. I've tried to get it running by all the accessible means and nada, zippo.
Any help would be appreciated

@JMPSequeira Same here - server not responding. I'm running atom on windows 10 x64, .net 4.6.1. I also tried on windows 7 x84 and the same problem occured.

Same here, on Mac Sierra 10.12.1. I don't see anything appear in the Omnisharp console and I can't do anything to enable it.

Same, following is thrown when trying to start the server manually:
Atom Version: 1.12.2
Electron Version: 1.3.6
System: Microsoft Windows 10 Home
Thrown From: omnisharp-atom package, v0.30.7
Stack Trace
Uncaught TypeError: Cannot read property 'connect' of undefined
At C:\Users\Michael\.atom\packages\omnisharp-atom\dist\atom\solution-information.js:63

TypeError: Cannot read property 'connect' of undefined
    at atom-workspace.<anonymous> (C:\Users\Michael\.atom\packages\omnisharp-atom\dist\atom\solution-information.js:63:86)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\src\command-registry.js:259:29)
    at C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\src\command-registry.js:3:59
    at CommandPaletteView.module.exports.CommandPaletteView.confirmed (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\node_modules\command-palette\lib\command-palette-view.js:210:32)
    at CommandPaletteView.module.exports.SelectListView.confirmSelection (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:338:21)
    at space-pen-li.<anonymous> (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\node_modules\atom-space-pen-views\lib\select-list-view.js:139:19)
    at HTMLOListElement.dispatch (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\node_modules\jquery\dist\jquery.js:4435:9)
    at HTMLOListElement.elemData.handle (C:\Users\Michael\AppData\Local\atom\app-1.12.2\resources\app.asar\node_modules\jquery\dist\jquery.js:4121:28)

Commands
     -5:44.9.0 core:undo (atom-text-editor.editor.is-focused)
     -5:43.2.0 application:open-folder (atom-text-editor.editor.is-focused)
     -5:37.5.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -5:34 core:confirm (atom-text-editor.editor.mini.is-focused)
     -5:34 linter:toggle (atom-text-editor.editor)
     -5:31.2.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -5:28.2.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -5:27.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -5:27.3.0 linter:toggle (atom-text-editor.editor)
     -5:24.8.0 pane:reopen-closed-item (atom-text-editor.editor.is-focused)
     -5:22.2.0 core:cancel (div.panels-item)
     -5:06.1.0 omnisharp-atom:toggle (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  2x -5:01.2.0 omnisharp-atom:new-project (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:14.1.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:12.8.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:04.1.0 omnisharp-atom:start-server (atom-text-editor.editor)

Config
{
  "core": {
    "disabledPackages": [
      "wrap-guide",
      "git-diff"
    ],
    "ignoredNames": [
      "*.meta"
    ],
    "telemetryConsent": "no"
  },
  "omnisharp-atom": {
    "autoAdjustTreeView": true
  }
}

Experiencing this as well.  Server doesn't start, no sign of life from omnisharp.

Similar here, on Mac El Capitan 10.11.5, nothing appears in the Omnisharp-atom console, flame never turns green, and I can't find any way to enable it.
I have mono v4.6.2 installed and dotnet 1.0.0-preview2-1-003177.

Same here with Windows 10. Reproduced on 3 separate machines.

Same here on Debian 8, with mono 4.6.2 & atom 1.11.2.
[15186:1120/154312:INFO:CONSOLE(728)] "getPackageDirPaths: /home/kaari/.atom/packages", source: /home/kaari/.atom/packages/omnisharp-atom/dist/server/omni.js (728)
[15186:1120/154312:INFO:CONSOLE(730)] "packagePath /home/kaari/.atom/packages exists: true", source: /home/kaari/.atom/packages/omnisharp-atom/dist/server/omni.js (730)
[15186:1120/154314:INFO:CONSOLE(158)] "Activating omnisharp-atom solution tracking...", source: /home/kaari/.atom/packages/omnisharp-atom/dist/omnisharp-atom.js (158)
[15186:1120/154314:INFO:CONSOLE(94)] "Omni Project Candidates: Searching /home/kaari/MonoProjects for global.json,*.sln", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/candidate-finder.js (94)
# ...
# ...
[15186:1120/154320:INFO:CONSOLE(65)] "Omni Project Candidates: Found /home/kaari/MonoProjects", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/candidate-finder.js (65)
[15186:1120/154320:INFO:CONSOLE(49)] "PRETTY_NAME="Debian GNU/Linux 8 (jessie)",NAME="Debian GNU/Linux",VERSION_ID="8",VERSION="8 (jessie)",ID=debian,HOME_URL="http://www.debian.org/",SUPPORT_URL="http://www.debian.org/support",BUG_REPORT_URL="https://bugs.debian.org/",", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/helpers/platform.js (49)
[15186:1120/154320:INFO:CONSOLE(50)] "getValue("ID")", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/helpers/platform.js (50)
[15186:1120/154321:INFO:CONSOLE(49)] "PRETTY_NAME="Debian GNU/Linux 8 (jessie)",NAME="Debian GNU/Linux",VERSION_ID="8",VERSION="8 (jessie)",ID=debian,HOME_URL="http://www.debian.org/",SUPPORT_URL="http://www.debian.org/support",BUG_REPORT_URL="https://bugs.debian.org/",", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/helpers/platform.js (49)
[15186:1120/154321:INFO:CONSOLE(50)] "getValue("ID")", source: /home/kaari/.atom/packages/omnisharp-atom/node_modules/omnisharp-client/lib/helpers/platform.js (50)
[15186:1120/154321:INFO:CONSOLE(307)] "Uncaught (in promise) TypeError: baseCodecheck.map(...).cache is not a function", source: /home/kaari/.atom/packages/omnisharp-atom/dist/server/view-model.js (307)
[15186:1120/154322:INFO:CONSOLE(197)] "Loading feature "atom/dock.js"...", source: /home/kaari/.atom/packages/omnisharp-atom/dist/omnisharp-atom.js (197)
# ...
# ...

Relevant ?

Same problem here on Windows 10, server won't start and Omnisharp output is empty. Lates version of Atom and Omnisharp.
I tried compiling and starting the omnishar-roslyn server my self, but omnisharp-atom does not find that server either (that one is actually running).


Added ingress-nginx usage information in README

Image from this repo also used in ingress-nginx controller ingress-nginx
I guess this info also can be added to Known Users section

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Possibility to bypass cache with argument?

Nice package.
Would be nice with a way to bypass the cache using input arguments from the client

Hi @simplenotezy , I don't know if you found a way to do it, but it's possible using the responseCachePlugin at the module level:
GraphQLModule.forRoot({
  driver: ApolloDriver,
  autoSchemaFile: true,
  sortSchema: true,
  cache: KeyvAdapter(new Keyv(redisConnURI)),
  plugins: [
    ApolloServerPluginCacheControl({ defaultMaxAge: 300 }),
    responseCachePlugin({
      shouldReadFromCache(requestContext) {
        const cacheControl = requestContext.request.http.headers.get('cache-control');
        return !cacheControl || !cacheControl?.includes('no-store');
      },
    }),
})

Reference: https://www.apollographql.com/docs/apollo-server/v3/performance/caching#configuring-reads-and-writes


[Feature] Deploy to Heroku  (#633)

addresses https://github.com/restarone/violet_rails/issues/385
Co-authored-by: Prashant<EMAIL_ADDRESS>Co-authored-by: donrestarone<EMAIL_ADDRESS>

@alis-khadka looks like we are using a node version that is incompatible with our capistrano deploy. We will need to make sure that both node versions are the same (we have to prioritize Cap deploy because that supports clients, we cannot change that easily)
 at new Class (/var/www/violet/releases/20220602122430/client/node_modules/core-object/core-object.js:21:5)
- Building
- Building
- building...
- cleaning up
- cleaning up
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "14.19.x". Got "10.19.0"
error Found incompatible module.
rake aborted!
Sprockets::FileNotFound: couldn't find file 'trix/dist/trix' with type 'text/css'
Checked in these paths:
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/activestorage-6.1.5/app/assets/javascripts
  /var/www/violet/releases/20220602122430/app/assets/config
  /var/www/violet/releases/20220602122430/app/assets/images
  /var/www/violet/releases/20220602122430/app/assets/javascripts
  /var/www/violet/releases/20220602122430/app/assets/stylesheets
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/graphiql-rails-1.8.0/app/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/graphiql-rails-1.8.0/app/assets/stylesheets
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/local_time-2.1.0/app/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/chartkick-4.0.4/vendor/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/ahoy_matey-3.2.0/vendor/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/simple_discussion-ccc76a485221/app/assets/stylesheets
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/comfy-blog-767f3848165a/app/assets/config
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/comfortable-mexican-sofa-456fb8507e96/app/assets/config
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/comfortable-mexican-sofa-456fb8507e96/app/assets/fonts
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/comfortable-mexican-sofa-456fb8507e96/app/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/bundler/gems/comfortable-mexican-sofa-456fb8507e96/app/assets/stylesheets
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/jquery-rails-4.4.0/vendor/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/actioncable-6.1.5/app/assets/javascripts
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/actionview-6.1.5/lib/assets/compiled
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/turbolinks-sou***e-5.2.0/lib/assets/javascripts
  /var/www/violet/releases/20220602122430/node_modules
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/font-awesome-sass-5.15.1/assets/stylesheets
  /var/www/violet/shared/bundle/ruby/2.6.0/gems/font-awesome-sass-5.15.1/assets/fonts
/var/www/violet/releases/20220602122430/app/assets/stylesheets/actiontext.scss:6


Add ability to upload+reload routes.yaml

We haven't announced Dynamic Routing Beta yet, but you can already read through this issue and read what Dynamic Routing is and how it works 🤠
We would like to add the ability to upload the routes.yaml file in the admin panel. We will add a new form under Labs (very similar to the redirects upload form).
When the file was successfully uploaded, Ghost will reload all site routes based on your new routes.yaml version/file. A server restart won't be required.
This sub-feature will be available in Ghost 2.0.
Tasks

[x] reload express site app after the routes.yaml file was uploaded
[x] add proper error handling e.g. what if you upload a broken routes.yaml file - use backup and return a proper message to the user
[x] add simple UI @kevinansfield
[x] add more tests
[x] create backup (use the same strategy as for redirects)

Endpoints:
I am following the convention of our redirect uploads.
POST /routes/yaml
GET /routes/yaml

Alternative is
POST /settings/routes/yaml
GET /settings/routes/yaml
The routes.yaml file is currently treated as "extra" blog setting - just file based. e.g. the routes.yaml file is completely handled in our settings service.
Maybe it's better to stay consistent for now and use this route notation.

This issue can be closed. All tasks are done. Final QA/testing will happen soon.


Implement EIP712 email attestation

In a similar manner as to the ticket/email combo authentication mechanism already implemented based on EIP712, we also want to implement this for just an email attestation.

Closed with merge of PR #117


Use existing Docker container when possible to prevent redundancy

What is the purpose of this PR?
Closes #732. Each time start_docker.sh is run a new container is created, which can lead to several large, redundant Docker containers on a user's computer. We should instead use an existing container with a standardized name whenever possible.
How did you implement your changes
This PR requires the following:

Each Docker container should now be tagged with a specific name, currently set to the Docker image release. The VERSION parameter  in start_docker.sh needs to be updated when a new image is released to Dockerhub. This name will help us easily identify if the Docker container exists on the user's computer.
If the container is found on the machine, default to the original docker run command, but if it is, then simply use docker start

The exception is if the user attaches an external volume. We have no choice but to delete the container and rebuild it, since Docker won't allow you to change the attached volumes on an existing container.

Remaining issues
Haven't tried this on Windows yet, will need some external testers to assist. UPDATE: tested it on Sri's computer, output redirection works now.

@ngreenwald on second thought, it's easiest to just remove the Docker image and recreate it each time. It doesn't cause a lot of overhead and it makes the underlying logic much easier to follow.

@alex-l-kong will you make a new release with a brief summary of what got changed


Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2

Fixes #20

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [18]

@conda-forge-admin please lint

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Build failure on toolchain+3.7 is due to getting protobuf and libprotobuf from different channels.

Depends on https://github.com/conda-forge/libprotobuf-feedstock/pull/16 and a follow-up PR to protobuf


Deriving Deserialize for structs with Cow<'a, str> fails

Consider the following code:
#[derive(Deserialize)]
struct S<'a>(Cow<'a, str>);

This fails with a cryptic error message:
error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
 --> <quote expansion>:1:2
  |
1 | <'a>
  |  ^^ unconstrained lifetime parameter

I believe Deserialize is implemented for Cow<'a, str>, so I think this should work.

The buggy generated code looks like this:
    struct __Visitor;
    impl<'a> _serde::de::Visitor for __Visitor {
//       ^^ unconstrained lifetime parameter
        type Value = S<'a>;

we can assume that any lifetimes during deserialization are 'static and thus simply replace then. They should be coercible to the target lifetime. If/When we get a deserialization strategy that borrows the object that it deserializes from, we can revise this.

Interestingly this works and I can deserialize S<str>:
#[derive(Deserialize)]
#[serde(bound = "T::Owned: Deserialize")]
struct S<'a, T: ?Sized + 'a + ToOwned>(Cow<'a, T>);

because it generates this code:
struct __Visitor<'a, T: ?Sized + 'a + ToOwned>(::std::marker::PhantomData<&'a ()>,
                                               ::std::marker::PhantomData<T>)
    where T::Owned: Deserialize;
impl<'a, T: ?Sized + 'a + ToOwned> _serde::de::Visitor for __Visitor<'a, T>
    where T::Owned: Deserialize
{
    type Value = S<'a, T>;

@oli-obk maybe we should stick with this PhantomData<&'a ()> approach and just make it work when there are no type parameters.

Interestingly this works

amusing.

maybe we should stick with this PhantomData<&'a ()> approach and just make it work when there are no type parameters.

Yea, we probably just need to take out a few things from the bound-attribute code path

@vks thanks for the report. I released serde 0.8.3 containing a fix.

Thanks for the quick fix! It works perfectly for me.


Deprecate ddclient chart

Details
Helm chart name:
ddclient
Describe the solution you'd like:
This chart is not very useful IMO, it's much better suited for a cronjob to do ddns updates. i don't think we want to maintain a chart that's a job because it's only like a 20 line YAML file.

I agree, there are multiple alternative solutions possible that either:

Do the same thing beter
Do the same thing with less code (so less chance of breaking)

@Ornias1993 Do we have charts for any of those?
ddclient supports quite a few DNS providers, and for programatically defined infrastructure, running ddns updates in a container is way better than in some cronjob outside of the environment the rest of the containers run in.
I used ddclient for a few years, but only dropped it because I have proprietary hardware that handles ddns.

than in some cronjob outside of the environment the rest of the containers run in.

Why outside? There are k8s jobs that work (relatively) fine.
About other solutions: thats an unfair question as k8s-at-home ignores a lot of networking related containers for which (official) charts are already available. Which is often the case for these tools..

Maybe it's a better idea to document different ways at doing ddns, a chart should not be needed for it.

@onedr0p Even outside of a k8s perspective such information would be quite valuable for a lot of users :)

Why outside? There are k8s jobs that work (relatively) fine.

I've somehow have never actually paid attention to the CronJob resource until now. Thank you!

About other solutions: thats an unfair question as k8s-at-home ignores a lot of networking related containers for which (official) charts are already available. Which is often the case for these tools..

Agreed; just curious what they are, really. I'm not aware of any other tools that support as many DNS providers. My phrasing was mainly shaped by the impression that alternatives were extremely numerous.

I guess my misunderstanding might be philosophical.
What criteria are used when deciding which charts to accept/add or reject/remove?
If ddclient is an actively developed, popular program relevant to the general theme of running k8s at home, implemented with the common chart, and hasn't generated any Issues or even ddclient-specific maintenance commits, it seems like a reasonable inclusion.
Are there official criteria?
Are there actual real disadvantages to using ddclient compared to alternatives; the kind that are noticeable to the user rather than focusing on implementation details?
Granted most of these charts are just a little bit of boilerplate thanks to the common chart's heavy lifting; but discoverability and ease is important when making these technologies more available to the masses.
I'd say that the ease of googling error messages for a well-used program makes it friendlier than debugging a custom cron job too.

Mainly the issue with the chart is that it runs once and doesn't repetitively do ddns updates which is why a cronjob makes more sense.

Mainly the issue with the chart is that it runs once and doesn't repetitively do ddns updates which is why a cronjob makes more sense.

Setting config.daemon=600 in the existing k8s-at-home ddclient chart will make it check every 10 minutes.

Oh interesting! Maybe we just need to add that to the config example then? But I still feel like this chart is much more suited as a cronjob.

Oh interesting! Maybe we just need to add that to the config example then?

Opened a PR for it.

But I still feel like this chart is much more suited as a cronjob.

ddclient being bloated comes in handy when you are stuck with a bad ISP, router, or ISP-provided router.
For those of us privileged enough to have normal setups, yeah basic cronjobs can be good.

What I mean is you can create a kubernetes cronjob using this ddclient image and use a configmap as the config file. Which is pretty much what this chart is doing sans cronjob.

Ahh, didn't realize that. Is the benefit great enough - or the use case common enough - to justify configuring it as a CronJob in this repo? I haven't looked at the common chart's internals too much; unsure how much extra config would be needed.

I think it's better not having a chart and just documenting a example cronjob in the wiki.

Seems to use 9MiB on idle. certainly something; but I hesitate to think it's worth special-casing the handling of ddclient for both the maintainers (making a guide or cronjob instead of a chart) or users (reading a separate set of instructions instead of just using the knowledge they have from setting up multiple other k8s-at-home charts.)
I don't think I have too much more to add to the conversation, besides that I still didn't realize that every 'cron job' mention in this whole thread was referring to kubernetes CronJobs; until your last message. Makes more sense now.

Ran across this kubernetes cronjob config for ddclient.


build: simplify with babel-dual-package.

Simplifies the build with babel-dual-package.

Codecov Report
Patch and project coverage have no change.

Comparison is base (75641ca) 99.28% compared to head (91c3caa) 99.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   99.28%   99.28%
=======================================
  Files           7        7
  Lines         561      561
  Branches      149      149
=======================================
  Hits          557      557
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


About your code environment

Shall you give me the code environment you used in this work?

python2 or python3 are both ok and the version of pytorch should be 0.3 or 0.4. BTW, there are some errors in dataloader, I will update github content these two days. Thank you for your concern.


Rename after pivot_wider and sumarise swap names from column

After upgrading from 0.1.2 in 0.2.0 I started to get the columns swapped when we rename the columns after a pivot wider and a summarise, I tried to reduce it to only use summarise or only pivot_wider and this is not happening, it needs to be used together in order to fail.
I think this is the minimal test to reproduce this bug
    test "pivote_wider swaping columns" do
      df = DF.new(
        names: ["cou", "adv", "spo", "cou", "adv", "spo"],
        val: [1.0, 2.0, 3.0, 4.0, 5.0, 6.0],
        team: ["A", "A", "A", "B", "B", "B"],
      )

      df2 =
        df
        |> DF.pivot_wider("names", "val")
        |> DF.group_by("team")
        |> DF.summarise(%{"adv" => [:max], "cou" => [:max], "spo" => [:max]})
        |> DF.rename(cou_max: "cou", adv_max: "adv", spo_max: "spo")

      assert Series.to_list(df2["cou"]) == [1.0, 4.0]
      assert Series.to_list(df2["adv"]) == [2.0, 5.0]
      assert Series.to_list(df2["spo"]) == [3.0, 6.0]
    end

This is the result from the test
  1) test rename/2 pivote_wider swaping columns (Explorer.DataFrameTest)
     test/explorer/data_frame_test.exs:893
     Assertion with == failed
     code:  assert Series.to_list(df2["cou"]) == [1.0, 4.0]
     left:  [2.0, 5.0]
     right: [1.0, 4.0]
     stacktrace:
       test/explorer/data_frame_test.exs:907: (test)

I tried to follow all the code, and may be is possible that the clone function on rust is not keeping the order of the columns when we do pivot_wider + summarise, is just a big, big guess.

This is fixed in main. :) I get at the end:
#Explorer.DataFrame<
  Polars[2 x 4]
  team string ["A", "B"]
  cou float [1.0, 4.0]
  adv float [2.0, 5.0]
  spo float [3.0, 6.0]
>

@josevalim mine is still falling :(, I compiled using rust nightly 1.65, I tested in a mac A1 and in linux, are you sure that you have pushed all your changes? By the way, than you for your super fast response

I could reproduce the problem - btw, thanks for the test case! - and it's a bug.
For what I could understand, in some of the steps we end up with different name ordering between Elixir and Polars. I guess it is in the step of summarizing, but it could be in the pivot step.
In any case I sent a fix => https://github.com/elixir-nx/explorer/pull/311
Now we are using the proper column names to rename, and not its position.

@philss thanks pals! you are awesome!


Fix log entry order with docker file building

Fixes https://github.com/dotnet/aspire/issues/4635
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

/azp run


Topic:  add base.css

Describe the types of DevOps topics you'd add in HelpOps-Hub Resource pages
Continuous Integration/Continuous Deployment (CI/CD): Tools and practices for automating the software release process.
Infrastructure as Code (IaC): Technologies for managing and provisioning infrastructure through code.
Containerization and Orchestration: Insights into Docker, Kubernetes, and related technologies for managing containers.
How many and what types of DevOps tools are you adding?
Jenkins
Docker
Kubernetes
Terraform
Ansible
Prometheus
Grafana
GitLab CI/CD
AWS CloudFormation
Azure DevOps
How many years of experience do you have in the DevOps field?
6 months+
Could you share some screenshots or a video of your previous DevOps work?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[ ] I'm DevOps professional
[X] Soon, I'll complete it and create a Pull Request.
[X] I'm a beginner in DevOps, but I'll try to contribute the best resources with hands-on experience.

@AKSHITHA-CHILUKA I apologize, but I need to close this issue because your title and description are completely different. Sorry, I cannot accept it. By the way, thanks for your issue. Please don't be discouraged.


[Question] FormFlow Dialogue with Adaptive Card for rendering in the client?

Using DirectLine for in the client (Xamarin) to communicate with the bot. Using the adaptiveCard rendering for xamarin and it works fine whenever we send the adaptive card as attachments. Issues starts when we start using the FormFlow dialogue which send the button and control in a HeroCard rather than adaptive card.
Question #1 : Is there a way that we can tell the FormFlow to send adaptive card instead of Hero Cards ?
Question #2 : Is there a way to render the adapative card by converting the hero card in the client ? .. in my case AdaptiveCard rendering for Xamarin ?
Related but not similar : https://github.com/Microsoft/BotBuilder/issues/2997

duplicate of https://stackoverflow.com/questions/45496651/how-to-show-hero-card-in-from-bot-in-xamarin-app


4650-Fix for collection resource bag download

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[x] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Create couple of composite resource.
Create a collection resource and add one or more resources to the collection.
Download the bag zip file the collection resource. Verify that bag download happens without redirect to a different page.

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4651


VertexPath does not contain a constructor that takes only one argument

Documentation says, Generating a path:
VertexPath GeneratePath(Vector2[] points, bool closedPath)    {        // Create a closed, 2D bezier path from the supplied points array        // These points are treated as anchors, which the path will pass through        // The control points for the path will be generated automatically        BezierPath bezierPath = new BezierPath(points, closedPath, PathSpace.xy);        // Then create a vertex path from the bezier path, to be used for movement etc        return new VertexPath(bezierPath);    }
But, the last line seems incorrect, VertexPath does not contain a constructor that takes only one argument.

I've had the same issue. I investigated the implementation of the VertexPath and the constructors appear  to have changed since this documentation was written.


Possible to compile electron prebuilt and embed a specific node version?

this module doesn't actually compile electron, it just downloads the versions pre-compiled by GitHub. I think you wanna look at the official Electron repo for how to do this


generate list of studies for review

@ValentineHerr ,
Let's create a systematic method for identifying studies (citationID) to be reviewed for contribution to IPCC.
It would be helpful to generate a spreadsheet with the following fields : citationID, n potential records, variables represented, sites represented, review priority score, ready to rerun and send (to be filled manually). We'll probably want to tweak this list.
Requirements (all sites listed in the spreadsheet should meet this)

includes records for variables identified for sending to IPCC:  in ForC_variable_mapping, provide.to.IPCC=1.
includes records that were not digitized
... (list not complete)

Prioritize based on: (assign points, put in review priority score)

number of records linked to citationID (1 point per record)
there are no sites identified as potential duplicates (remove 10 points for each potential duplicate)
... (list not complete)

This is just a rough start. Please modify as you see fit, and leave flexibility to change as we go.

OK, what do you think is best, looking at MEASUREMENTS of ForC_simplified (and its column suspected.duplicate)?
If using MEASUREMENTS table and there is potential duplicates, if they don't get resolved during review, the corresponding records won't make it through.
(same with ForC_simplified and suspected.duplicate).

(I'll do MEASUREMENTS for now)

Should be fine, although we may need to add a simple mechanism to bypass the duplicate flagging for studies that we've carefully reviewed.

Ok I pushed this file. Let me know if that works and if it is a good place for it.
I only penalized potential site duplicate, not potential measurement duplicate....
But I manually checked the top 10 citations and non have conflicts except Powers_2012_csaa that has 2 records that are replicates and Wang_2013_eofa for which all records replicates. But I think replicates are not as bad as duplicates and are "resolved" by taking average... Which, now that I am saying that, is probably not good for IPCC's review process...

Thanks! That's a good start.
A score of -3549... YIKES! (That one may be fully replicated between original ForC and SRDB.)
One small modification: could you please list the variables, rather than just giving the count? Some will get higher priority than others.

done (ignoring if in C or OM units).

Thanks! Let's leave it at this for now, but I'll keep this issue open for now because there's a good chance we'll want to adjust later.

We want to refine this system. Here are my notes on what I'd like to weight towards:
ForestGEO
Studies included in GROA
By region: tropics
By variable: major stocks and increments
I need to come back and provide details.

Here's the list above, edited:
Requirements (all sites listed in the spreadsheet should meet this)

includes records for variables identified for sending to IPCC:  in ForC_variable_mapping, provide.to.IPCC=1.
study not flagged as ready to process: in ForC_citations,  EFDB.ready = 0
includes records that were not digitized, or where we don't know if they were digitized

Prioritize based on: (assign points, put in review priority score)

number of records linked to citationID (1 point per record)
there are no sites identified as potential duplicates (remove 10 points for each potential duplicate)
"ForestGEO" is in site name (add 1000 points)
study from GROA (add  .5 points per record)
"Tropical" is included in FAO.ecozone (add 1 point per record)
Variable is highlighted in image below - add 1 point per prioritized variable


Missing DaoMaster

Hi, first of all, thanks for this example, I'm trying to build an App using this example.
I'll use a local DB so I'm using what you build with Greendao but I'm facing problems with your DaoMaster class. In your DbOpenHelper.java you use a class called DaoMaster located on your model package (as your import says)
import com.mindorks.framework.mvp.data.db.model.DaoMaster;

But there isn't such class in your model package. The same goes for DaoSession class.
Could you provide these two files?
Thanks

@adriamt These two classes are generated by annotation processor when you build your project.
Clean and rebuild your project. You will find these classes under the build->generated->source->apt


Travis

Minor cleanup
Added tests
added config for travis

ref #11

@avelino, silly me forgot to add the Travis badge on README!


[Bug] github.event.pull_request.title doesn't show their title name

Description

github.event.pull_request.title cannot  show title.

Problem
github.event.pull_request.title can be only existed in  on.pull_request. Currently Deploy workflow is triggered on push, so github.event.pull_request.title doesn't work!
Solution
So we will change on.push to on.pull_request


Add support for building in docker

As a developer I would like to build woodpecker on any environment
Added:

Make command to build woodpecker on docker (recreate make build environment).
Dockerfile for make environment

Isn't this somehow redundant to the work done in #635? We at least use a similar approach for building the cli and agent already.

also is it possible to preserver the permissions from user exec that command. at the moment build artefacts are owned by root if run within docker :/

make version
> next-22ae7fb8
VERSION=1.0 make version
> 1.0
make in_docker version # expect same as before get ""
>


Prebuilt binary fail to mount on Heroku Cedar-14

run on fresh heroku app.
$ heroku run bash
$ curl -LO https://github.com/kahing/goofys/releases/download/v0.0.13/goofys
$ chmod u+x goofys; mkdir mnt
$ AWS_ACCESS_KEY_ID=key AWS_SECRET_ACCESS_KEY=secret ./goofys -f --debug_fuse s3.bam.com mnt
2017/07/12 13:11:31.832587 main.FATAL Mounting file system: Mount: mount: running fusermount: exit status 1

stderr:
fusermount: fuse device not found, try 'modprobe fuse' first

packages available on Heroku

Did you try modprobe fuse as the log suggests?

from googling around it sounds like heroku does not support fuse.


How do I get the SSL client TPS and Total new connections

Through the endpoint, can I get to the CPU usage, detailed totConn, but for the SSL client ,I didn't find them
if it is need to be calculated, please tell me how to get them

Please resubmit this issue following one of our issue templates: https://github.com/F5Networks/f5-telemetry-streaming/issues/new/choose


shrink-mds: do not play ceph-facts entirely

We only need to set container_binary.
Let's use tasks_from option.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-container-shrink_mds

jenkins test centos-non_container-shrink_mds


[Core] HttpX Support in Azure Core Experimental

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core-experimental


Support Maps

Supporting maps with arbitrary key types would make swagger codegen very complicated but supporting a Map[String, Object] would be very useful.

When In Spring rest api has @requestParameter Map<String ,String> then we can not validate Map's Parameter !!
Any solution for swagger model schema to get Map parameter to validate ??


error in dotnet

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/install
Operating System: linux chromebook crouton
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
it said "/ has 'other' write 40777"

@samsonite98765 did you install dotnet via snap? Can you try reinstalling? Maybe it got corrupted.
cc @dagood


How to ignore specified warning？

In syntastic:
"let g:syntastic_quiet_messages = { 'regex': ["should have comment or be unexported"]}

How to do it in ale?

For ignoring messages, you should configure each tool individually, through either configuration files or by changing the options for a linter.

Is there an example?

You can use different settings for each linter.
https://github.com/w0rp/vim/blob/df44e61a2e72442f0b1e59a67052da2b8447939d/ftplugin/gitcommit.vim#L2
Otherwise, create a project configuration file for each linter, such as one for ESLint.

See :help ale for a table of contents linking to all of the options available for everything.

I don't know how to configure it to ignore the specified warning, It's golint's warning.

Consult the documentation for golint.

That isn't relevant to this issue, but thank you.

I think that I have a valid use-case for this feature.
My team's .eslintrc includes the import/no-unresolved rule. I get false-positives from ALE (because it can't figure out the package dir properly?). My other teammates use other editors/linters, so I can't remove it from .eslintrc because it would disable it for them also.
I would like to ignore the rule in my local setup so I don't get errors everywhere. Some hook that allowed me to grep -v 'import/no-unresolved' before entries are added to the location list would be super useful in this case.

You should configure ESLint so it does work, or is submit a patch for the ESLint plugin or in ALE so it works. I do think filtering the list of problems in Vim is a bad idea. If we did do it, it would be best to do it with a function that returns 0 or 1.

Unfortunately, lacheck cannot be configured to filter. At least not without writing a wrapper for it. For now I just disabled it entirely :(


Freeze Literal, Node and URI values on instantiation.

Use symbol, rather than string, to index intern cache.

This looks good. Will merge when travis is happy.
Should we also freeze #to_base return values, or does that upset client code?

Coverage increased (+0.002%) to 91.594% when pulling 4c3b258fb899dfa8ba7614e9e17d041eab26cef6 on feature/frozen-terms into 0ca5ec2906785489b81b71a562dc222ec974e879 on develop.

We should be able to freeze #to_base too. Anything that breaks can be fixed.

Coverage increased (+0.02%) to 91.613% when pulling 3ca2a4ad6ea612937eed423d6bc5db0593c1f500 on feature/frozen-terms into 0ca5ec2906785489b81b71a562dc222ec974e879 on develop.


Feature request

Can it show its output in flow launcher preview window if possible(f1)
Thanks

Thanks for the suggestion! I'll have a look at the sources when I have some spare time and then share some more info.

@surajmandalcell - please check the info in #15
I've pushed a new release. This should be officially available through Flow-Launcher soon. Either check for updates in the settings under Plugin Store or run the command pm update Ollama directly.


What's means to use the normal function as a middleware ?

I have a code by CoffeeScript like:
router.post '*', (next) ->
  console.log 'first'
  yield next

router.post '/abc', ->
  console.log 'second'

If there are no 'yield' keywords, CoffeeScript will think it is a normal function. Sometimes I forget the yield next when the middleware is a return-point middleware.
The example will print 'second', 'first'. Of course, I hope to print 'first', 'second'...
So I have a question that If i use the normal function in middleware, what will happen? why call the normal function early than the generator function?

@KID-WuMeng  https://github.com/alexmingoia/koa-router/blob/5.x/lib/router.js#L326-L330
1. matched /abc
2. run next = normalFunction(next)     // log 'second' & next == undefined

3. matched *
4. run next = generatorFunction(next)  // next == Iterator Object

5. run yield *next                     // log 'first'

@helloyou2012 I see and thanks ~


[Autocomplete] Using limitTags prevents clicking buttons outside of autocomplete while autocomplete is focused

Steps to reproduce
Link to live example: issue is also in the MUI docs
Steps:

Select options until there are more than limitTags options selected
Try to click a button outside of the autocomplete (e.g. the 'expand code' button)

Current behavior
The autocomplete is unfocused, but the click on the button is ignored.
Expected behavior
The click is also propagated to the button.
Context
We have a form with an AutoComplete where we set limitTags to prevent the AutoComplete from growing indefinitely. When people make a change to the selection in the AutoComplete and immediately click our 'Save changes' button, the click is not propagated to the button and the changes are not saved.
Your environment
Tested on latest Chrome (linux and mac) and Firefox (linux).
Search keywords: Autocomplete limitTags

The limitTags prop is only applied when there's a blur event. Clicking the button outside of the autocomplete triggers a blur event for the autocomplete. Users won't see the tags being limited until they click outside of the autocomplete. Wouldn't it be better to show the limited tags all the time (#21328)? If so, would this solution work for you: https://github.com/mui/material-ui/issues/21328#issuecomment-979880227? I'm suggesting this because I believe it would offer a better user experience for your use case.

Adding the renderTags in https://github.com/mui/material-ui/issues/21328#issuecomment-979880227 does solve the click blocking on buttons outside of the AutoComplete. The solution is not ideal though, since there is then no easy way to see all selected elements while filling in the form, which is also confusing for our users.

I'm unsure if we can keep both behaviors. I'll leave this issue open for now.


Allowing ORM objects in filter() function

[First of all I have to say that your library is incredible. I am currently playing with it and it might fix the doubts I had on React + Redux in comparison with the OO Backbone/Ampersand.js apps.]
So far everything just works.
I would however like to request a feature on the filter() object so that the folllowing can work out of the box:
schema.get('ModelA').filter({
modelB: schema.get('ModelB').withId(2),
modelC: schema.get('ModelC').withId(1)
});
Currently you have to call the id property:
schema.get('ModelA').filter({
modelB: schema.get('ModelB').withId(2).id,
modelC: schema.get('ModelC').withId(1).id
});
It would be a nice feature if the filter() function types check for ORM Models and converts the values to Ids automatically.

Hi! You should be able to do this now in 0.6.0, see https://github.com/tommikaikkonen/redux-orm/commit/8680f35df3e97bae210eab612b992b050b08ee3b

Can we close this? @ConneXNL you can always reopen when you get around to re-testing.


(test only) rules_python @ 0.30.0 with presubmit modifications

Test only to verify changes to presubmit will satisfy BCR before committing the changes upstream.

Hello @f0rmiga, modules you maintain (rules_python) have been updated in this PR. Please review the changes.


create userplans automatically

This addresses issue #43 by various methods. It creates UserPlans during initial migration, by management command and it allows to set user in UserPlanAdmin (not removing the link).

Note: Both PRs #80 and #79 contains migrations which would conflict if pulled together. So please pull one of the PRs first and I will make the appropriate migration changes for the second before pulling.

@Alir3z4 I have added changelog record to this and changed the list_display back to tuple as requested in #82

@PetrDlouhy should we close this pull request if the it has been addressed in other pull requests ?

Codecov Report

Merging #80 into master will decrease coverage by 0.73%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage    76.9%   76.17%   -0.74%
==========================================
  Files          29       31       +2
  Lines        1667     1746      +79
==========================================
+ Hits         1282     1330      +48
- Misses        385      416      +31

Impacted Files
Coverage Δ

plans/management/__init__.py
54.54% <ø> (ø)

plans/migrations/0002_create_user_plans.py
100% <100%> (ø)

plans/admin.py
76% <100%> (ø)
:arrow_up:

plans/listeners.py
67.56% <100%> (-1.67%)
:arrow_down:

plans/models.py
82.83% <87.5%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a813201...c9c0e47. Read the comment docs.

@Alir3z4 I don't think, the changes are included in other PRs, or they should not. I tried to make separate PR for every problem, but they are clashing with migrations and changelog changes.

Ok, the pull request looks good to me.
However it has code that are not covered in the tests.
You can see the uncovered code at https://codecov.io/gh/django-getpaid/django-plans/pull/80/diff
Let's write tests to cover those parts and we can merge it.

@Alir3z4 OK, I will do that.

Great!
Let me know when it's ready so I can take a look ;)

I have created the test, but I can't find the Codecov report. Anyway the create_for_users_without_plan and create_userplans management command should be covered.

coverage won't be able to catch that, because call_command spin another process to run the management command.
However, still we need to somehow test the output of that command.
I see there's no output from the command, either failure or success.
I recommend to print out something once the management done, something simple like "User plans created " or anything more you find meaningful, then you can catch that from stdout within the tests.
This is how you'd be writing tests for stdout when calling a management command: https://docs.djangoproject.com/en/dev/topics/testing/tools/#management-commands

@PetrDlouhy could you please check this pull request so I can merge ?

@Alir3z4 I added direct test, and modified the command test by Your requirements. I also rebased this to fixed master (please merge #86 first) and added reverse code for the migration.