[PRO] Stacked Class is missing

I can't quite reproduce it, but after installing material and material-pro, some parts are missing. For example the Stacked class or Filtersets. Is there any way to reliably install material pro?

Now the class is back again, however others are missing:
ModuleNotFoundError: No module named 'material.frontend.apps'

Mm, that's hard to say what thing when wrong in your case.
Probably starting from fresh virtual environment could solve the issue. django-material-pro package is a complete replacement for open source version. Both packages should not be installed together.
Could you please contact over zendesk with detail steps and materail package versions that you used and the complete stacktrace.


Counters for daily kWh etc.

When monitoring the (cumulative) total kWh, it would be more convenient to look at hourly/daily/weekyl/monthly/yearly increase/counters in total kWh as bargraphs. As an example see https://forum.mysensors.org/uploads/upload-8db4363b-6c76-41fc-b4bc-02bbcb36b314.JPG from https://forum.mysensors.org/topic/469/energy-meter-not-updating-watts.

@BSRasmussen Added option to support for counter, We have to change metric type to Counter

@jkandasa Where can I find the "Counter" setting for "metric type"? Does this exist in the latest version?


Jp/macos 4gb

One other possibility is, on macos, to make BEHAVIOR_ADDRESS_SPACE a variable. The implementation then just reserves from any place a big enough area (4gb+4gb-1), takes the 4gb aligned part of it discarding the rest, and then just uses bump allocation to commit more space as needed from the reserved zone.

Now on mac we reserve 4gb upfront because MAP_FIXED_NOREPLACE is not supported (we might use mach_vm_* api in the future to avoid this).
Last thing before merging this branch is changing the CI file, to make it compile the C++ vm on each platform to at least check we don't break this vm.


Max bugfix

Max needs to return the upper bound of the top bucket to be more than
the actual maximum value seen.

Good find, but this breaks the build. Can you fix the tests?

Sorry, I ended up including my addition to hdr as well as the fix of the test in the same commit

No worries — thanks for the fix!

I'm modifying metrics to allow entire distributions to be extracted, not just percentiles. Needed the extra method in hdr. I've got versions for codahale/metrics and for go-kit/metrics.
Thanks for the quick merge!


[Feature request] Limit allowed http methods

Hello,
I think it could be useful to add the possibility to limit the allowed http methods (POST, GET etc.) for a certain service.
Example use case: a swarm cluster with 2 services, service_A and service_B, where service_A can make POST, DELETE and GET requests to service_B, but only the GET endpoint should be available outside the proxy. The idea is to provide read-only access to some services from outside the proxy but to let the full access to the other services inside the proxy.
I was thinking of something like this:
services:
  service_B:
    ...
    deploy:
      labels:
        # If not specified, all methods should be allowed by default.
        # If specified, only the chosen methods should be allowed in the request.
        - com.df.allowedMethods=GET,HEAD,OPTIONS

        # If not specified, all methods should be allowed by default.
        # If specified, the requests with the chosen methods should be rejected.
        # In case of conflict with the previous setting for a specific method,
        # this setting should take the precedence and disable the method.
        - com.df.disabledMethods=POST,PUT,DELETE

As a workaround, at the moment I'm editing the haproxy.tmpl file to obtain the same behavior:
# Deny all DELETE requests coming to service_B
acl is_delete_method method DELETE
http-request deny if is_delete_method { hdr(host) -i my-service.example.com }

Do you think this could be a useful feature? Thanks in advance.

It's done and available in the release 17-06-1. Please try it out and let me know whether it works as expected.

I tried the last version of the proxy and works perfectly, exactly how I was expecting! Thank you very much!


fix: shuffle peers in transaction propagation

The order of HashMap's traversal is fixed if there is no rehashing. This will lead to choosing same subset of peers at each propagation. It's better to choose totally random peers at every propagation.

forgot about this -.-
@DaniPopes perhaps you have an idea of how to efficiently pseudo-sort a list of peers

Is this superseded by #5930 then and should be closed? Or should we merge both? If so any next steps? cc @DaniPopes per Matt's comment above

wdyt @emhane ? perhaps there's a smarter solution for this

why is it better to choose totally random peers, I guess you are thinking because of decentralisation? if so, that's a valid point. nonetheless, how kademlia is designed for example is to favour long-lived connections, so choose the same peers that have served us well over and over. favouring the most responsive peers here would translate, simply, to a lru cache for storing peers. "last peer to send us a valid message" is the peer we can rely on the most and may want to send the full transaction to here. it's important to have a connected network graph in the decentralised context, so switching which peers we send transactions too all the time isn't necessarily a good idea since if they aren't healthy peers we loose connectivity in the p2p.
libp2p has a more elaborate may to decide which peers to send full transactions too, Peer Exchange is used: https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#outbound-mesh-quotas. here is also a nice diagram from them https://docs.libp2p.io/concepts/pubsub/overview/#gossip. full-message peers aren't chosen at random, the peers that get IHAVE, the libp2p equivalent to NewPooledTransactions announcement, are chosen at random.

@emhane Kademlia already handles the favour of long-lived peers at connection level, right?

That's totally right that the properties of Kademlia will propagate up to all levels on top of the connection.

I agree a better solution is to scoring the connected peers and send full transactions to the top peers. Currently it will send full transactions to a fixed set of peers. I think choosing a random subset is better than fixed subset of peers and add less complexity than scoring peers.

Unfortunately, I disagree with you here. It'm not convinced it's better to choose the random set of peers anew every time transactions are propagated. I think preferential attachment, i.e. a peer scoring system, is better. I proposed a simple solution in my previous comment: store peers in a lru cache instead of a hashmap. Peers that are good at responding to  transaction requests, can be promoted to lru, for example. The idea here is to send full transactions to the peers that serve our needs best, "the rich get richer" effect. That is in some sense a scoring system simply by using properties of the lru cache.
Whether we really want to make any change to this at all is not obvious. I'd appreciate if you open an issue showing benchmarks to make your case why it's better to choose the random set of full transaction peers anew on every call to propagate_transactions.

On second look, the issue has already been acknowledge https://github.com/paradigmxyz/reth/issues/5906 and is linked in precedent https://github.com/paradigmxyz/reth/pull/5930. So, let's include this.
Shuffling a list of 4-8 bytes indices is much cheaper than a list of 32 bytes hashes!
Let's make the re-sampling happen on another period than each call to propagate_transactions, will leave some suggestions.

how's it going with this @Gooong ?

due to the nonce gap problem outlined here https://github.com/ethereum/go-ethereum/pull/29034, it's safe to say that it's not favourable to randomise peers to which we send transactions to even more. closing pr.


Bug. Service does not have any active endpoints. 0.9.0-beta.11

Hi!
My conf:
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-controller-tcp
  namespace: kube-system
data:
  "5002": "ns/logstash:5001"

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-controller-udp
  namespace: kube-system
data:
  "5001": "ns/logstash:5001"

If i use two protocols in service:
---
apiVersion: v1
kind: Service
metadata:
  name: logstash
  namespace: ns
spec:
  ports:
  - name: log
    protocol: UDP
    port: 5001
    targetPort: 5001
  - name: log2
    protocol: TCP
    port: 5001
    targetPort: 5001

I got error:
5 controller.go:542] service ns/logstash does not have any active endpoints for port 5001 and protocol TCP
If I delete the first record about the udp, then the tcp starts working.
If the ports are the same, the controller sees only the first entry in the service.

Changing the port number helps to get around this problem

Closing. This was fixed in https://github.com/kubernetes/ingress/pull/1078


Add a Moving Window Class

A data window that moves with the latest data points of a data stream.
When dealing with machine learning models, often the input features
are derived from timeseries data or are timeseries itself.
In order to obtain a timeseries as a data batch from streamed data
one can define a window that is essentially.
This approach creates a window that moves with the data flow by
utilizing a ringbuffer such that copying of buffer and therefore
memory allocations are minimized.

There seems to be a typo in the commit message:

In order to obtain a timeseries as a data batch from streamed data
one can define a window that is essentially.

Maybe just "essential"?


Refactor Chirp.CLI's Program.cs so that all User Interface code resides in a separate class

User story
As a software developer,
I want to refactor the 'User Interface' related code from the Chirp.CLI into a separate class: UserInterface,
to improve the structure of the code and thereby enhance its maintainability by separation of concerns.
Acceptance criteria
Separation of Concerns: Separating the UI into its own class to isolate the code responsible for user interaction from the core business logic of the application.
Definition of Done (DoD)
The readability should be enhanced, and the responsibility for the new class should be very clear.
All team members are comfortable with the changes introduced during refactoring.
The refactoring doesn't cause any errors.

This was done in the following pull request! PR15. closing this now:)


Implement searching via filters.

The list endpoints should allow for searching. This needs implementation and testing.

Using django-url-filter has issues. The original code base isn't maintained: https://github.com/miki725/django-url-filter, but there are two solid forks, both available on PyPI:

dj-url-filter (https://github.com/enjoy2000/django-url-filter)
django-ufilter (https://github.com/Qu4tro/django-ufilter)

However, neither of them have merged in JSON field support: https://github.com/miki725/django-url-filter/pull/82/commits/5221c484660470c322b01ddcfe6681b7729c81cb
So, using the basic django-filter may be required...


Making doParse protected (for issue #8)

This changes the visibility of the doParse method over from private to protected to make it more extensible.

LGTM. Thanks for the pull req! 😃


Support EXISTS subquery expression

Use case:
Using the singer-target-postgres Singer target to get data from a source like Github into CrateDB.
The singer-target invoked the following query:
SELECT
    EXISTS (
        SELECT
            1
        FROM
            pg_tables
        WHERE
            schemaname = 'doc'
            AND tablename = 'commits');

Which fails:
Unsupported expression EXISTS (...)

(Disclaimer: I was just playing around and don't have a concrete use-case for singer)
Feature description:
See PostgreSQL EXISTS clause
EXISTS (subquery)

The argument of EXISTS is an arbitrary SELECT statement, or subquery. The subquery is evaluated to determine whether it returns any rows. If it returns at least one row, the result of EXISTS is “true”; if the subquery returns no rows, the result of EXISTS is “false”.

Note that for the query that failed, correlated sub-query support is not required.

Added with https://github.com/crate/crate/pull/12900


Add IntelliSense Support (Autocomplete, Documentation Hints, etc.)

Currently working on this feature at the moment using Tree-sitter and a custom Node.js language server. Having this functionality will making writing Dispatcher Config files much easier.

Adobe's Dispatcher Configuration Documentation: https://experienceleague.adobe.com/docs/experience-manager-dispatcher/using/configuring/dispatcher-configuration.html?lang=en

This is still work in progress but it's coming along nicely:

I created a pull request for this: https://github.com/BeardedFish/vscode-apache-dispatcher-config-language-support/pull/9. I think I'm going to implement diagnostics via another pull request as I don't have time to implement it right now.

Closing this issue as pull request https://github.com/BeardedFish/vscode-apache-dispatcher-config-language-support/pull/9 was merged into the main branch.


adjacency tooltip cleanup (issue 233)

Fixes #233
In the game, there are five types of mountains. This change will make
the game ommit to retrieve an adjacency tooltip for holy site and campus
for 4 of these types and for the fifth it will slightly modify the
output to make it more readable.

I am waiting for approval

I'll check this out today and probably merge as long as nothing has changed for the worse since last check

Sorry for taking a while to get back to this. I've checked out the changes and it doesn't seem like the tooltips are any different:


Change selected game without restarting the app

Overall looks good from what I can tell code-wise. git-wise the develop branch in our fork should be treated as read-only since we keep it in-sync with the base repo by pulling new commits on top. We could use ts-develop in our fork but that has extra clutter in there already & would make merging this upstream harder.
So you can re-open this to target ebkr/r2modmanPlus/develop (GitHub doesn't seem able to change the base repo on an already-opened PR)

Closing to switch the target repo.


DELETE requests work unauthenticated

A DELETE https://domain.com/ will return 403 Forbidden but actually delete any file (non directory) at the root.
The logs will show that the root folder cannot be deleted, with permission denied. Yet, any contained file will disappear.
nginxwebdav  | 2021/12/17 13:39:16 [error] 13#13: *1 rmdir() "/data/" failed (13: Permission denied), client: <IP_ADDRESS>, server: localhost, request: "DELETE / HTTP/1.1", host: "myhost.ineed.coffee"
nginxwebdav  | <IP_ADDRESS> - - [17/Dec/2021:13:39:16 +0100] "DELETE / HTTP/1.1" 403 153 "-" "Paw/3.3.2 (Macintosh; OS X/12.0.1) GCDHTTPRequest

@rozhuk-im are you the author of http://netlab.dhis.org/wiki/ru:software:nginx:webdav?
If yes, this bug might affect you, too.
If you have
    location / {

      auth_basic "Restricted";
      auth_basic_user_file htpasswd;
[...]
      if ($request_method = DELETE) {
        return 598;
      }
[...]
}
[...]
location @delete_handler {
      internal;
      open_file_cache	off;

      if ($destination ~ ^https?://(.*)$) {
        set $new_path $1;
        more_set_input_headers "Destination: http://$new_path";
      }

      if (-d $webdav_root/$uri) { # Microsoft specific handle: Add trailing slash to dirs.
        more_set_input_headers "Destination: http://$new_path/";
        rewrite ^(.*[^/])$ $1/ break;
      }

      root			$webdav_root;
      dav_methods		DELETE;
    }
[...]

The authentication mechanisms auth_basic and auth_basic_user_file must be repeated in the location @delete_handler, too:
    location / {

      auth_basic "Restricted";
      auth_basic_user_file htpasswd;
[...]
      if ($request_method = DELETE) {
        return 598;
      }
[...]
}
[...]
location @delete_handler {
      auth_basic "Restricted";
      auth_basic_user_file htpasswd;
      internal;
      open_file_cache	off;

      if ($destination ~ ^https?://(.*)$) {
        set $new_path $1;
        more_set_input_headers "Destination: http://$new_path";
      }

      if (-d $webdav_root/$uri) { # Microsoft specific handle: Add trailing slash to dirs.
        more_set_input_headers "Destination: http://$new_path/";
        rewrite ^(.*[^/])$ $1/ break;
      }

      root			$webdav_root;
      dav_methods		DELETE;
    }
[...]

Otherwise, nginx will return 403 but delete the files.
Let me know if this issue applies to you, too 👍

Yes, netlab is mine.
Thanks for pointing that, never think that auth apply only in location that generates reply.
I can not check this, I do not use WebDAV for r/w operations any more, only for share content for kodi with simple minimal DAV config.
May be this will also relevant to you:
https://github.com/arut/nginx-dav-ext-module/issues/55
https://github.com/arut/nginx-dav-ext-module/pull/56

@rozhuk-im all good. Thank you for the Wiki article, it has helped a lot! I can credit you properly in the README now.


feat: formatted default test file

Description
feat: formatted default test file
Type of change

[x] New feature
[x] Test

How has this been tested

[x] Unittest
[ ] Others: Confirmed by myself

Checklist:

[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Let's make the world better✨😋🐍🌎

Codecov Report

Merging #36 (66d3416) into main (abc6e64) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   95.52%   95.56%   +0.04%
==========================================
  Files          21       21
  Lines         603      609       +6
  Branches       36       36
==========================================
+ Hits          576      582       +6
  Misses         18       18
  Partials        9        9

Impacted Files
Coverage Δ

pypj/file_path.py
96.15% <100.00%> (+0.32%)
:arrow_up:

pypj/task/poetry.py
82.25% <100.00%> (+1.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc6e64...66d3416. Read the comment docs.


[UBS. Main page] The main body of the page and the footer are misaligned.

Environment:
Redmi Note 13 Pro 5G, Android 13TKQ1.221114.001, екран 2712 x 1220 пікселей, Chrome Версія 128.0.6613.100
Reproducible: always
Preconditions

https://www.pick-up.city/#/ubs is opened.

Steps to reproduce

Scroll down to the footer.

Actual result
The main body of the page and the footer are misaligned.

Expected result
The main body of the page and the footer are aligned.
User story
User story https://github.com/ita-social-projects/GreenCity/issues/5192.

Fixed :


[BUG waybar-network] Enforcing interface causes {gwaddr} to be empty

Case 1
config
"network#wifi": {
  "interface": "wl*"
  "format-wifi": "{gwaddr}",
}

result
module is empty
debug log (network-relevant entries only)
[2022-05-21 13:27:25.066] [debug] network: selecting new interface wlp3s0/3
[2022-05-21 13:27:25.066] [debug] network: wlp3s0, new addr aaa.bbb.ccc.ddd/24

Case 2
config
"network#wifi": {
  "format-wifi": "{gwaddr}",
}

result
module contains gateway address
debug log (network-relevant entries only)
[2022-05-21 13:28:08.345] [debug] network: new default route via aaa.bbb.ccc.xxx on if3 metric 3003
[2022-05-21 13:27:25.066] [debug] network: wlp3s0, new addr aaa.bbb.ccc.ddd/24

NOTE
In the logs, I have replaced the actual IP address with aaa.bbb.ccc.ddd and aaa.bbb.ccc.xxx

Diagnosis

If interface is set in the config, then config_["interface"].isString() is true.
When config_["interface"].isString() is true, the module never sets want_route_dump_ = true;
so askForStateDump() never asks for a route dump
so handleEvents() never receives a RTM_NEWROUTE message
and so it never sets  net->gwaddr_
and therefore, gwaddr_ remains unset.

Should be better wirh a4d27ea

Nope, still not fixed.

Same for me.

Still happening with waybar 0.9.24.

Any news ? Issue still persist on waybar 0.10.3-1


MAID-2131 Web Hosting manager - Text overflow UI issue

Resolved text overflow issue.

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Improve finding the minimum distance efficiency

Instead of processing the distances from all atoms from the supercell to another, only find the distance from the atoms in the unit cell to all other other atoms in the supercell. As tested in CIF Bond Analyzer (CBA), this modification can handle 10,000 atoms in a supercell within 1 to 2 minutes.

The new feature has been updated in the latest version.


ghostx.livebalance from pin protected wallet not reflecting on exchange page

What is working wrong?
Balance in btc pin protected wallet not showing in exchange balance
What should happen instead?
I believe going to exchange that balance in pin protected wallet should be able to be used for trade and show there
Steps to reproduce

steps
to
reproduce

Your system charateristics

Browser:
OS:
Mainnet or Testnet:

Does this affect atomic swap flow?

[ ] yes
[x ] no

Are real funds at risk?

[ ] yes
[x ] no

Screenshots

Additional info

https://github.com/swaponline/MultiCurrencyWallet/issues/2889
https://github.com/swaponline/MultiCurrencyWallet/issues/2892
https://github.com/swaponline/MultiCurrencyWallet/issues/2897
https://github.com/swaponline/MultiCurrencyWallet/issues/2898
Pin-prorected will be ready today, maybe tomorrow


TypeScript breaks when the Nuxt application is placed in a sub-folder

Versions

nuxt: 2.14.1
node: 13.x
typescript: 3.9.5

Reproduction
The issue can be reproduced simply by creating a new Nuxt application inside a sub-folder of a project. In this case, a Nuxt application has been created inside the packages/nuxt folder as seen in monorepos. A reproduction repository can be found here.
Steps to reproduce
After setting up a new TypeScript-based Nuxt application or using the provided reproduction repository, the issue becomes apparent when importing a component through an alias or using a property or type unique to Nuxt such as asyncData. Both issues can be reproduced by pasting the code snippet below into a page like index.vue:
<script lang="ts">
import Vue from 'vue'

export default Vue.extend({
  components: {
    Logo: () =><EMAIL_ADDRESS>  },
  asyncData(ctx) {
    console.log(ctx)
  }
})
</script>

What is Expected?
The aliased module resolution and types are expected to work properly regardless of where the Nuxt application is placed.
What is actually happening?
Both of the aforementioned break in Webstorm as well as Visual Studio Code. TypeScript throws an error saying that the imported module or its corresponding type declarations cannot be found, and that asyncData does not exist in the ComponentOptions type provided by Vue. The issues only appear in the IDE, however, and the application builds without problems. The issues can also be mitigated by opening the Nuxt application folder directly rather than the top-level project, but this workaround is not ideal in a monorepo when working on multiple packages.
I apologize if this is not directly a Nuxt issue, but the same thing has been tested with a TypeScript-based Vue application generated through the vue-cli without problems. Also, if anyone has successfully set up a TypeScript-based Nuxt application inside a monorepo, I would really appreciate your suggestions!

@jonasolesen There are a couple of things to try. First, make sure that you have correct paths set in your tsconfig.json or TS can't resolve imports. Second, as I recall, VS Code has a weird quirk whereby it only properly understands imports in the first project in a workspace.

@danielroe Thank you for your reply!
I have not changed the paths from what is provided by default:
"baseUrl": ".",
"paths": {
  "~/*": [
    "./*"
  ],
  "@/*": [
    "./*"
  ]
}

Despite showing an error of not being able to find the module, the IDE (or at least Webstorm) seems to resolve it correctly as seen below:

Also, the behaviour does not seem to be influenced by shims-vue.d.ts.
I don't know too much about the behaviour of VS Code as I'm mostly using Webstorm. I just checked with VS Code to ensure it wasn't specifically a Webstorm issue. :slightly_smiling_face:

@jonasolesen I don't think this is a Nuxt issue. For VSCode, you need to create a workspace for this to work: https://code.visualstudio.com/docs/editor/multi-root-workspaces. I'm not sure what Webstorm requires but I think it's an editor integration. The fact that there is no type issue when it compiles is revealing...

@danielroe You are correct - it is indeed an integration issue. After further testing, it seems like the issue has been introduced in both WebStorm and PhpStorm alongside the support for Nuxt. When opening the project with an older version of either IDE, everything works as expected. For anyone curious, it can be mitigated by having the Nuxt project as the only project root, which is somehow similar to VS Code workspaces like you suggested. The moment I add an additional project root, the module resolution and declaration merging breaks again.
Thank you for your time, Daniel 🙂 I'm closing the issue.


increase coverage rate of distributions.py

import order (lint)
add unit tests for higher coverage. (+1.6%)
https://coveralls.io/github/chris-chris/rlax

Thanks for the contribution!


Passport Connect Error

Hello, I am trying to implement the SDK login, but I get this error Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service
Do you know if I am missing something? I am using XCode 15 with minimun iOS version 13.0.

hello @jromandeveloper, I have not been able to replicate your issue on my side. Would you be able to send us a sample project that shows that issue so we can better debug it?
Thanks

Hey @CassiusPacheco thanks for answering, I tried creating a new empty project and I was able to pass this error but now I am getting an exception only in iOS, I will create a new ticket with the info.


Specify custom x/y accessors

Suppose I have some data that looks like
let data = [
  { date: moment(), value: 0 },
  { date: moment().add(1, 'min'), value: 0.5 },
  { date: moment().add(2, 'min'), value: 1 }
];

I'd like to display it in a MarkSeriesand use date for the x value and value for the y value. The xy-plot docs list x and y props, which I'd expect to behave like accessors:

X
Type: number|Object
Exact X position of all series points in pixels or a series object.

That seems like what I'd expect, except... why would I want to set all X values to a static number, and what is a "series object"?
Skimming the library code quickly shows the following usage of the x and y props:
...
      .attr('cx', this._getAttributeFunctor('x'))
      .attr('cy', this._getAttributeFunctor('y'));

Since that does indeed seem like what I want, I tried it:
<MarkSeries data={data} x={d => d.date.valueOf()} y={d => d.value} />

Except that apparently this literally means "use this function as the x value", since this is what gets rendered:
<circle r="5" cx="function x(d) {
    return d.date.valueOf();
}" cy="function y(d) {
    return d.value;
}" style="opacity: 1; fill: rgb(255, 127, 14); stroke: rgb(255, 127, 14);"></circle>

IMHO, this is a fairly obvious violation of the principle of least astonishment. So, the crux of this feature request is basically:

If it is not currently possible to provide custom accessors, either add an additional check that would interpret function x/y props as accessors, or add explicit props to handle this case
Clarify existing prop documentation, and add documentation describing how to specify custom accessors

In the meantime, the obvious workaround is to simply map the data beforehand, but this is sometimes not desired.

@austinhyde Thank you for your comment.
The goal of the library was to keep the API as simple as possible and rely on the user in the questions of performance and data preparation. We want the user to provide well structured data and deal with such corner cases as null or undefined values of objects (currently they will be treated as zeros). Besides that, the value accessors will unfortunately solve only the part of the problem: the values are frequently stored in much more complex (e.g. nested) objects.
I created the task to improve the documentation for the scales: there are some certain gaps in it. Meanwhile please check out the existing docs for scales and date, probably you'll find some of the answers there.

I also created a related task to track the progress of the documentation update: currently the docs for scales are very poor.


Use rlax

Feature
Use rlax where we can, so that we don't have to implement and test common methods.
Proposal
As far as I can see we can use it for policy/critic loss and GAE.
Benchmarking

Needs to match the perfromance of the current develop branch.

Investigated, it massively slowed down existing systems :disappointed:


Latest Linux daily builds compiled without OpenCL

I have received two independent reports that the latest OpenCL Linux daily builds are apparently compiled without OpenCL support:

This message in Blender means that pyluxcore.GetPlatformDesc().Get("compile.LUXRAYS_DISABLE_OPENCL").GetBool() returned True.
One of the reporters says LuxMark 4 is running fine on all GPUs.
One of the last working daily builds was apparently the one from 15.10.2019, although it's not clear that was the last one.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I have downloaded BlendLuxCore-latest-linux64-opencl.zip and it is working fine here with PATHOCL.
So or was something temporary due to the (very common) Azure fails to upload the .tgz or the user is installing the wrong version.

It still doesnt work for me. Latest working build is from 15.10.2019. OS Linux Ubuntu 18.04 with latest Nvidia drivers.

The only possible explanation is that Blender finds first a pyluxcore.so compiled without OpenCL instead of the one you are downloading and installing (or I have a pyluxcore.so compiled with OpenCL somewhere and it is used first than the one I'm downloading and installing).
Try this:

download https://github.com/LuxCoreRender/BlendLuxCore/releases/download/latest/BlendLuxCore-latest-linux64-opencl.zip
execute "unzip BlendLuxCore-latest-linux64-opencl.zip"
execute "cd BlendLuxCore/bin"
execute "python3"
type "import pyluxcore" and press enter
type "pyluxcore.GetPlatformDesc().Get("compile.LUXRAYS_DISABLE_OPENCL").GetBool()"

Do you get "True" or "False" as answer ?
My test:
david@i7-3930k:~/tmp/ocl/BlendLuxCore/bin$ python3
Python 3.6.8 (default, Oct  7 2019, 12:59:55)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyluxcore
>>> pyluxcore.GetPlatformDesc().Get("compile.LUXRAYS_DISABLE_OPENCL").GetBool()
True
>>>

@Dade916 Your test seems to confirm the problem, is that correct?

Yes, it is why a deleted my previous post, I have to check what is going wrong.

Ok, I have found the problem, the OpenCL C++ bindings header was missing:
ERROR--> Could not locate required OpenCL files, disabling OpenCL support - Please check
And the OpenCL binaries where built without OpenCL.
I'm testing the fix.

The build looks ok now.

Confirmed. Its working now. Thanks


Slow QR Code Reading Issues on Samsung A4E Devices with Android 13: Plugin or Device Troubleshooting?

Expected Behaviour
Fast reading QRCode
Actual Behaviour
I'm experiencing a slowdown issue when reading QR codes on Samsung A4E devices. This model is taking longer than expected. My question is whether anyone has encountered something similar or if it could be related to a specific plugin. I'm also wondering if it might be a device-specific issue.
The device in question is a Samsung A4E running Android 13.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 13
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samsung

Hi, @andrerds
I would like to know more details.
For example, can you give us a video of the QR code being scanned and how long it takes to scan it?
Note that I do not own your device, so it is most likely difficult to reproduce.

Hi, @andrerds
I would like to know more details. For example, can you give us a video of the QR code being scanned and how long it takes to scan it?
Note that I do not own your device, so it is most likely difficult to reproduce.

Hi, everything good, thank you for responding so promptly.
Unfortunately, due to company privacy policies, I can't share a video of the QR code being scanned. I understand your curiosity regarding this specific aspect.
Regarding the delay in reading the QR code, I've made some test requests, such as trying to scan another QR code, uninstalling and reinstalling the app, among others. These tests can help us better understand the origin of the problem.
It's worth mentioning that we have the same app in other locations, and this is the first report of such an issue. This makes the situation a bit more challenging as we don't have previous cases to compare.
Unfortunately, as it's a client's device issue, I can't directly access logs or perform deeper checks, making it more difficult to identify the root cause. I'm working hard to resolve this, and if more information or possible solutions arise, I'll be more than happy to share them.
Thanks again for your interest and understanding.


[SPARK-13436][SPARKR] Added parameter drop to subsetting operator [

Added parameter drop to subsetting operator [. This is useful to get a Column from a DataFrame, given its name. R supports it.
In R:
> name <- "Sepal_Length"
> class(iris[, name])
[1] "numeric"

Currently, in SparkR:
> name <- "Sepal_Length"
> class(irisDF[, name])
[1] "DataFrame"

Previous code returns a DataFrame, which is inconsistent with R's behavior. SparkR should return a Column instead. Currently, in order for the user to return a Column given a column name as a character variable would be through eval(parse(x)), where x is the string "irisDF$Sepal_Length". That itself is pretty hacky. SparkR:::getColumn() is another choice, but I don't see why this method should be externalized. Instead, following R's way to do things, the proposed implementation allows this:
> name <- "Sepal_Length"
> class(irisDF[, name, drop=T])
[1] "Column"

> class(irisDF[, name, drop=F])
[1] "DataFrame"

This is consistent with R:
> name <- "Sepal_Length"
> class(iris[, name])
[1] "numeric"
> class(iris[, name, drop=F])
[1] "data.frame"

Test build #51719 has started for PR 11318 at commit 632a81f.

Test build #51719 has finished for PR 11318 at commit 632a81f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51719/
Test PASSed.

Merged build finished. Test PASSed.

Please update your PR title. Thanks!

@felixcheung @sun-rui @shivaram Can you folks please take a look at this one? Thank you!

Hmm, just as #11336 wouldn't it be confusing then to return a Column, particularly since Column in SparkR is pretty restricted, unlike in R?

https://stat.ethz.ch/R-manual/R-devel/library/base/html/Extract.data.frame.html here for reference

Test build #53357 has started for PR 11318 at commit 6ebe948.

Test build #53359 has started for PR 11318 at commit adc977f.

Test build #53360 has started for PR 11318 at commit 017fcdb.

@felixcheung @shivaram @sun-rui I have addressed all your comments. Do we have a consensus on the default value for drop? I'd say drop=T makes sense cuz R does it that way. Anyways, it's just a one-line change for me. Please let me know! Thanks!

Test build #53360 has finished for PR 11318 at commit 017fcdb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53360/
Test PASSed.

Test build #53359 has finished for PR 11318 at commit adc977f.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53359/
Test FAILed.

Build finished. Test FAILed.

Test build #53357 has finished for PR 11318 at commit 6ebe948.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53357/
Test PASSed.

@olarayej, there are still similar coding style issues:)

Test build #53689 has started for PR 11318 at commit 0473d03.

Test build #53689 has finished for PR 11318 at commit 0473d03.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53689/
Test FAILed.

Test build #53691 has started for PR 11318 at commit b576fba.

Test build #53691 has finished for PR 11318 at commit b576fba.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53691/
Test FAILed.

Merged build finished. Test FAILed.

Test build #53693 has started for PR 11318 at commit 13dfcbb.

Test build #53693 has finished for PR 11318 at commit 13dfcbb.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53693/
Test FAILed.

Test build #53696 has started for PR 11318 at commit 9ab303a.

Test build #53696 has finished for PR 11318 at commit 9ab303a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53696/
Test PASSed.

Merged build finished. Test PASSed.

@sun-rui Done with the style issues. Thanks!

@sun-rui @shivaram Shall we merge this?

Test build #57060 has started for PR 11318 at commit 1a4ca8b.

Test build #57060 has finished for PR 11318 at commit 1a4ca8b.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57060/
Test FAILed.

Test build #57063 has started for PR 11318 at commit b169e14.

Test build #57063 has finished for PR 11318 at commit b169e14.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57063/
Test FAILed.

Test build #57146 has started for PR 11318 at commit def5987.

Test build #57146 has finished for PR 11318 at commit def5987.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57146/
Test FAILed.

Test build #57150 has started for PR 11318 at commit fc07e85.

Test build #57150 has finished for PR 11318 at commit fc07e85.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57150/
Test FAILed.

Test build #57151 has started for PR 11318 at commit 290a2cf.

Test build #57151 has finished for PR 11318 at commit 290a2cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57151/
Test PASSed.

@shivaram @sun-rui @felixcheung This one's ready. Shall we merge?

Thanks @olarayej for updating this. I think the code looks good. The only thing I'm not sure of is the default value for [ - I see that you have gone through SparkR's internal code base to add drop = F. The reason I prefer keep drop=F as the default is that I'm not sure if we have missed some place where we use [. While I see the argument that its the default in normal R, I feel like it might not be worth changing the default if we'll run into other unexpected bugs.

Test build #57187 has started for PR 11318 at commit 36163e1.

Test build #57187 has finished for PR 11318 at commit 36163e1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@shivaram I've changed default value to drop=F as you suggested. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57187/
Test PASSed.

LGTM. Merging this. Thanks @olarayej


Change GL ammo back to 64

Why?

Why?

It's not at a point where I should start "balancing" it

I think 16 is a good balance as normal grenade stack size are 1, so that means you can already have 16 times more grenade if you use a launcher for them which is already powerful enough

Maybe

I do not believe that this change would be beneficial. Grenade launcher ammo stacking to 64 makes no sense. I might consider switching it to 8 or 16 at the very most.


Steps to recover speech recognizer when it failed due to connectivity issues

The page describes steps how to manually connect/disconnect the speech recognizer. Can you please also provide details about what to do when connections fail while a speech recognizer is actively running - i.e. when it was fully set-up, doing continuous recognition with keyword spotting using StartKeywordRecognitionAsync?
The observation is that if the user says the keyword while offline, the recognition attempt with the server fails and the recognizer fires a Cancelled event with ConnectionFailure error code. If the network connectivity is back later on and then an attempt is made to reestablish the connection using recognizerConnection->Open(true) as suggested on this page here, this fails with an exception 0x1e (SPXERR_SWITCH_MODE_NOT_ALLOWED) .
Afterwards, the recognizer seems to be permanently unable to work further. Can you please provide guidance what the recommended way to recover is from this connectivity issue?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 41f99480-fdfb-1cb6-3e2b-caade9da93fa
Version Independent ID: 46942e00-767a-182e-b76c-0187101bd705
Content: Service connectivity how-to - Speech SDK - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/how-to-control-connections.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @trrwilson
Microsoft Alias: travisw

@jens-totemic
Thanks for your feedback! We will investigate and update as appropriate.

@jens-totemic
I've delegated this to @trrwilson , a content author, to review and share their valuable insights.

@trrwilson - Do you have any thoughts on this? Do you need more details about the environment or steps to reproduce the issue? Thanks

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Data Export / Data Download

Develop/deploy export and download functions to and from SWR.
This includes backend and frontend work.

question by WE (@Somakanthan ); which formats should a user be able to download the data by? csv, pdf, xml, ...? and should we keep them as original format or convert to another format?
Bonares; mostly csv, pdf, xml and mostly keep as this format or extra function to convert to pdf


Virtual Machine: System.Net.HttpListenerException (0x80004005) Error

Hey I moved my JMM server to a virtual machine and I get this error when trying to start the server:
[2015-06-27 06:34:28:641] Info|BackgroundWorker.WorkerThreadStart => MainWindow.workerSetupDB_DoWork => MainWindow.AniDBDispose Disposing... [2015-06-27 06:34:28:643] Info|MainWindow.workerSetupDB_DoWork => MainWindow.AniDBDispose => AniDBHelper.Dispose ANIDBLIB DISPOSING... [2015-06-27 06:34:30:645] Info|StackBuilderSink._PrivateProcessMessage => BackgroundWorker.WorkerThreadStart => MainWindow.workerSetupDB_DoWork Setting up database... [2015-06-27 06:34:30:798] Info|StackBuilderSink._PrivateProcessMessage => BackgroundWorker.WorkerThreadStart => MainWindow.workerSetupDB_DoWork Initializing Session Factory... [2015-06-27 06:34:30:798] Info|StackBuilderSink._PrivateProcessMessage => BackgroundWorker.WorkerThreadStart => MainWindow.workerSetupDB_DoWork Initializing Hosts... [2015-06-27 06:34:30:798] Info|MainWindow.SetupAniDBProcessor => AniDBHelper.Init => AniDBHelper.BindToLocalPort -------- Local IP Addresses -------- [2015-06-27 06:34:30:812] Info|MainWindow.SetupAniDBProcessor => AniDBHelper.Init => AniDBHelper.BindToLocalPort -------- End Local IP Addresses -------- [2015-06-27 06:34:30:812] Info|MainWindow.SetupAniDBProcessor => AniDBHelper.Init => AniDBHelper.BindToLocalPort BindToLocalPort: Bound to local address: <IP_ADDRESS>:4556 - Port: 4556 (InterNetwork) [2015-06-27 06:34:30:812] Info|MainWindow.SetupAniDBProcessor => AniDBHelper.Init => AniDBHelper.BindToRemotePort BindToRemotePort: Bound to remote address: <IP_ADDRESS> : 9000 [2015-06-27 06:34:30:837] Info|MainWindow.workerSetupDB_DoWork => MainWindow.SetupAniDBProcessor => AniDBHelper.Init starting logout timer... [2015-06-27 06:34:31:006] Error|StackBuilderSink._PrivateProcessMessage => BackgroundWorker.WorkerThreadStart => MainWindow.workerSetupDB_DoWork System.Net.HttpListenerException (0x80004005): The process cannot access the file because it is being used by another process    at System.Net.HttpListener.AddAllPrefixes()    at System.Net.HttpListener.Start()    at JMMServer.FileServer.FileServer..ctor(Int32 port, Int32 maxthreads) in c:\Projects\GitHub\JMMServer\JMMServer\FileServer\FileServer.cs:line 192    at JMMServer.MainWindow.StartFileHost() in c:\Projects\GitHub\JMMServer\JMMServer\MainWindow.xaml.cs:line 2318    at JMMServer.MainWindow.workerSetupDB_DoWork(Object sender, DoWorkEventArgs e) in c:\Projects\GitHub\JMMServer\JMMServer\MainWindow.xaml.cs:line 861

I think the problem was that I had assigned only 1 core to the VM, assigning 4 cores seems to have fixed the problem.

Great to hear


DHT won't work without torrent?

I've noticed TT only connects to peers found using the DHT if we already have the torrent file.  But what if we don't have the torrent file and only the infohash?
eg of the restriction: https://github.com/jackpal/Taipei-Torrent/blob/master/torrent/torrent.go#L520
Even if I remove all such restrictions like this (I think there are 2 more of them), I still can't download using just an infohash, for example "magnet:?xt=urn:btih:deca7a89a1dbdc4b213de1c0d5351e92582f31fb", even though I can connect to peers found over the dht for it (and there are several).
What's the deal?

PR #89 should fix this issue (As the saying goes, "works on my machine"). Anyone who has had this problem, can you try to reproduce and confirm it works now?

Works as expected. :+1: Thanks a mil :)

Cool, then I'm closing this issue :-)


Reconstruction Bias Block 2022

What is this reconstruction bias and where does it come from?
A bias to the size of the S1, S2 signals is introduced during the signal reconstruction process. This bias can come from a variety of sources:

under-amplified photons [captured as part of the in the single photoelectron(SPE) pulse shape]
ADC trigger
different SPE shape for different PMTs [1 photon will give different areas for different PMTs]
PMT afterpulses [as PMTs age, they will emit more afterpulses which are merged into the original peak by the reconstruction software]
by the reconstruction software itself because of the way signals are quantized, peaks are clustered, etc.

Please read xenon internal document on reconstruction bias for more details.
How is this reconstruction bias quantified?
This reconstruction bias, obtained via separate Monte Carlo studies by other analysts(@JoranAngevaare, @FaroutYLq), is defined as
$$\text{reconstruction bias} = \frac{\text{reconstructed area}}{x} - 1$$
where $x$ can either be the raw area hitting the detector, or the reconstructed area from the reconstruction software.
How is it implemented in Flamedisx?
Affects both ERSource (see these lines) and NRSource (see these lines).
The reconstruction bias block is implemented as a Gaussian smearing in ERSource with zero mean and small standard deviation after the MakeS1 and MakeS2 blocks.
Gaussian smearing in SR1ERSource with mean and standard deviation obtained from Monte Carlo studies. _simulate and _compute both use the reconstruction bias and smear maps with $x=\text{raw area}$. _annotate uses the reconstruction bias and smear maps with $x=\text{reconstructed area}$.
The reconstruction bias is defined while normalised to 1 (see equation above) in the MC study, but this 1 is added back in this line for ease of computation since
$$\text{reconstructed area} = (\text{reconstruction bias}+1)\times\text{raw area} $$
Testing
Agreement between _compute and _simulate was tested using an updated template accuracy notebook I got from @robertsjames.

A unit test is also added (see here).
Dependencies
This PR requires the reconstruction bias block to 'sum' over non-integer internal dimensions (s1_raw, s2_raw) and this functionality is provided in PR #258 by @robertsjames. However, for numerical reasons (see comments in PR #258), it is imperative to be able to tune max_sigma for the blocks stepping on non-integer dimensions. This feature is then provided in PR #272 also by @robertsjames.
Other remarks
Since this reconstruction bias block affects all sources, I highly encourage @eangelino and @cecilia-ferrari to check for any breaking changes or degradation to fit performance before this PR is merged in.

@plt109 this looks really great. To summarise our discussions offline:

This validation is for the default sources, which have no bias and the default (small) 'loading' term for the smearing
This demonstrates that the block, there but essentially doing nothing, does not break things
You haven't rebased in the per-block max_sigma tuning yet - you just hard-coded it for the validations (which is fine!)
When you tested it with a real case, you found poor agreement in the validation plots (quite a large spread of residuals). But you found exactly the same thing with this block removed for that source, suggesting that there's either a bug there, or more fine-tuning the needs to happen for that source with the max_dim_size / max_sigma stuff

Do you agree with my summary above? If so, what are the next steps towards getting this merged?

Thanks for the review Robert! I rebased onto main, which includes your non-integer dimension fix; and I removed some unfortunate comments you pointed out.
Merging this won't break any sources not providing maps since the default is no bias and no smearing. It shouldn't increase the computation time either since the new dimension will have a size of 1 element if there is no smearing.
I agree work remains to show that we get a better fit to data with this than without. But the implementation seems right and involved a significant amount of work. If someone resumes work on this, they would want to start from this implementation, not from scratch.
So @robertsjames @plt109 , if neither of you objects, I would propose to merge this.


chore(docs): include environment variables

Issue number: https://github.com/aws-powertools/powertools-lambda-python/issues/2923
Supersedes: https://github.com/aws-powertools/powertools-lambda-python/pull/2922
Summary
Clarifies some documentation pages by including their related environment variables. They were only included on the main page, though it may be useful to also mention them on their corresponding page.
Changes
For each page, a new Environment variables section was created under Getting started right before Advanced. This section contains a table listing all environment variables affecting that page. It also mentions the preference order (parameter overrides environment variable).
User experience
When navigating through documentation, developers will now find the environment variables for each core/utility on its page. It is useful as it allows us to quickly understand the behaviour of these environment variables by Ctrl+F'ing them.
This comes from personal experience, as I found out about Tracer's environment variables by checking the parameters of Tracer decorators' source code. But when going to Tracer's documentation page, I couldn't find these environment variables, until I realized they were only in the main page.
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
No.
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Thanks for sending this PR @barreeeiroo!!
Hei @heitorlessa! Since I don't have the context here, I'd like your review or we can sync tomorrow and I can review.


Facetted search may be under reporting workflows reported by workflow language

Describe the bug
I'm looking to automate some reporting and downloaded a copy of the production database (2022-09-28T05-01-31+0000) and installed it locally.  I then started executing some queries.  The general form of the query is:
select workflowname, dbupdatedate, organization, repository, descriptortype from workflow where ispublished = true AND descriptortype = 'wdl' ORDER BY workflowname;
When I execute the command, I obtain a value of 1493.  According to the faceted search, there are 1342 WDL workflows.

Workflow Language
Faceted Search
SQL Query

WDL
1342
1493

CWL
202
220

Nextflow
55
57

Galaxy
30
31

It makes sense to me that we filter some internal/test workflows; however, I can't find a query that produces the same numbers.
svonworl did a bit of investigation and found some inconsistencies that indicate some workflows may be missing from the ElasticSearch query results.  I'll let him report on his findings.
svonworl here!  My findings follow:
If you modify Ben’s query above to exclude checker workflows, it matches our ElasticSearch (ES) filtering logic, and the number of workflows returned by the query should match the number reported in the “WDL” part of the search facet.  However, as 29/Sep/2022, on prod, this was not the case, the facet reported a significantly smaller number of workflows than the query.
Some investigation indicated that at that time, on prod, there were published workflows that appeared on the site that did not appear in the search results.  For example, https://dockstore.org/workflows/dockstore.org/yuliamostovoy/KmerCount did not appear when searching for the keyword ‘yuliamostovoy’.
Upon downloading and installing the prod db locally, these entries did appear in the search results in my local install, and the query count and search facet count were the same.
A likely cause is that a fraction of published workflows were not indexed in prod ES for some (currently unknown) reason.
┆Issue is synchronized with this Jira Story
┆friendlyId: DOCK-2257
┆sprint: Backlog
┆taskType: Story

As temporary fix, try reindexing. Check if staging has same problem, and try there first.

On staging before reindex:
858 WDL, 201 CWL, 44 Nextflow, 26 Galaxy.
After reindex: 883 WDL, 201 CWL, 44 Nextflow, 26 Galaxy. Still a big gap. I wonder if we're missing something in the SQL query, or if we're (intentionally?) skipping something in the ES code.

If I reindex locally with a snapshot of staging data, I correctly get 1,058 WDL, 209 CWL, 46, Nextflow and 28 Galaxy, which adds up to 1,341.

qa: 1,135 faceted workflows, 1,248 published and not checkers before reindex; after reindex: 1,129 faceted workflows (it actually went down!).

Upgraded the ES instances on qa, reindexed again, and this time got 1,240, which is closer to 1,248. Noticed two "Executing bulk [37] with 4 requests" followed by "413 Request Entity Too Large" in the logs, which could explain the difference of 8.
See this Stackoverflow post -- similar confusion; we're setting the it to 2.5Mb here, and the default request size should be 100MB. Unless I did the units wrong.

AWS OpenSearch sets its own limits; 10MB in our case: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/limits.html#network-limits

I think there is one main issue going on here: we are occasionally submitting requests with > 10MB payloads. This is caused by #5042 -- we submitting the source files from all of versions. This problem causes an entire bulk request to fail, e.g., if you have a bulk request with 3 entries with sizes 1MB, 1MB, and 9MB, all 3 entries will fail to index.
Reindexing a recent prod snapshot locally, with the same max request limit as AWS OS, only successfully reindexes 1,632 out of 1,793 published workflows.
A hypothetical but probable secondary issue is that if ES is unresponsive (due to it being underpowered), the code to update ES will fail silently and the index won't get updated.

If there's a default version, we only submit the default version's source files for indexing. But if there isn't, we submit the source files from all version. See code.

For the record, the query also needs to contain "AND ischecker = false":
select workflowname, dbupdatedate, organization, repository, descriptortype from workflow where ispublished = true AND ischecker = false AND descriptortype = 'wdl' ORDER BY workflowname;
The numbers now match using that query (modified for the appropriate language).


Pull Request for adding in MAX17435

(Symbol & Footprint) MAX17435 - a multi-chemistry battery charger that communicates on SMBus. Dimensions appear to be correct. I've used nominal values from the datasheet (not min nor max). Not sure about the EP pad thing.

Rectifying errors...

Errors rectified!

@Wizongod Please could you run make compile and update? The failing check is because make verify has found that agg-kicad.pro is out of date.


Complete the example for actix-web

Hi.
The example for actix-web (examples/actix.rs) is not actually implemented yet. I complete that example by following the behavior of examples/rocket.rs except that Content-Type is not set because actix-web does not have built-in support for inferring content-type from file extension and it is unavoidable to import another crate, to which I think be unnecessary.
I have tested it and ensure it works as expected.

Thanks @Gowee . This is great. The mime thing to find the content type can be added later. if needed  Since most of the browsers can infer content type using file meta data.


Explain implications of on-demand spot ratio split actions

Description
https://karpenter.sh/docs/concepts/scheduling/#on-demandspot-ratio-split
How can the docs be improved?
There are quite a lot of unknowns in this section of documentation.
The docs do not explain certain implications of implementing the on-demand/spot ratio split.
These situations include:

What happens to workloads on the same nodepool that do NOT have the capacity spread label? ... will they join the on-demand nodepool be default? (having a fallback for all the various nodepool specific workloads is unfeasible e.g. fallback, on-demand, split for 3-5x nodepool specific settings)
What happens when workloads rapidly scale (5x or 10x # of workloads)? Does Karpenter scale up accordingly with the split logic? Or will it scale up and re-balance after a little while?

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

With this constraint: https://karpenter.sh/docs/concepts/scheduling/#workload-topology-spread-constraint, Karpenter will scale up accordingly with the split logic
Your pods will have to have the capacity spread label to be compatible with these nodepools

Sorry I should have included examples of implications.
If you have some pods that do not have the capacity spread label, do they fall back to the on-demand deployment?
Or will there a be a need for another nodepool that is a fallback for these deployments?
Will the spotToSpotConsolidation setting conflict with the ratio split if there is a spot termination?
Will pods be stuck in Pending waiting for a node to stand up

Also do the virtual domains only work for workloads that have enough pods to satisfy the desired ratio split?
e.g.
We are aiming to get 10% of all nodes to be spot. We set the spot ratio as described in the docs (1-9 on demand and 10 is spot). We have lots of workloads with between 3-6 pods and a few with 10+ pods. Will this only work for workloads that have 10+ pods or will this spread with all workloads calculated in the virtual domain spread calculation (assuming all workloads have the capacity spread topologySpreadConstraint)


OG images

Update global og image with this one https://www.figma.com/design/xKWICiVwIbEG75cad5nr3o/bitlauncher-Landing?node-id=387-108&t=Q82qXEhbefjwfkcm-4
For project landing page use project image as background and display title and pitch dynamically in the middle, copy code from masterbots search https://github.com/bitcashorg/masterbots/blob/search/apps/masterbots.ai/app/og/route.tsx

 [Bitlauncher] Set And Update OG Images


python310Packages.identify: 2.5.1 -> 2.5.2

Description of changes
Update to latest upstream release 2.5.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 182234 run on x86_64-linux 1

4 packages built:

check-jsonschema
pre-commit
python310Packages.identify
python39Packages.identify


conflict with gflags already exists

I have a project which depends on both gflags and glog. I include them in my CMakeLists.txt file as below.
cmake_minimum_required(VERSION 3.0)
project(Test)

add_subdirectory(thirdparty/gflags)
add_subdirectory(thirdparty/glog)

add_executable(Test main.cc)
target_link_libraries(Test pcanbasic gflags glog)

this comes an error:
$ cmake ..
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include unistd.h
-- Looking for C++ include unistd.h - found
-- Looking for C++ include stdint.h
-- Looking for C++ include stdint.h - found
-- Looking for C++ include inttypes.h
-- Looking for C++ include inttypes.h - found
-- Looking for C++ include sys/types.h
-- Looking for C++ include sys/types.h - found
-- Looking for C++ include sys/stat.h
-- Looking for C++ include sys/stat.h - found
-- Looking for C++ include fnmatch.h
-- Looking for C++ include fnmatch.h - found
-- Looking for C++ include stddef.h
-- Looking for C++ include stddef.h - found
-- Check size of uint32_t
-- Check size of uint32_t - done
-- Looking for strtoll
-- Looking for strtoll - found
CMake Error at /usr/local/lib/cmake/gflags/gflags-targets.cmake:34 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: gflags_nothreads_static

  Targets not yet defined: gflags_static

Call Stack (most recent call first):
  /usr/local/lib/cmake/gflags/gflags-config.cmake:10 (include)
  thirdparty/glog/CMakeLists.txt:54 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/weizhengyuan/Workspace/CanBusTest/build/CMakeFiles/CMakeOutput.log".

are there any solution?
BR

Should it be a if(NOT TARGET gflags) judgement arround glog/CMakeLists.txt:54?

Take a look at CMake's ExternalProject module. This is the proper way of integrating local dependencies.

if(NOT TARGET gflags)
        add_subdirectory(third/gflags)
endif()

This solves the problem

Using ExternalProject solves the problem well. It allows defining dependencies between the projects.

Define external projects

# Build gflags as an external project.
set(GFLAGS_INSTALL_DIR ${CMAKE_BINARY_DIR}/libs/gflags)
set(GFLAGS_INCLUDE_DIR ${GFLAGS_INSTALL_DIR}/include)
set(GFLAGS_LIB_DIR ${GFLAGS_INSTALL_DIR}/lib)
ExternalProject_Add(gflags_external_project
    SOURCE_DIR  ${CMAKE_SOURCE_DIR}/libs/gflags
    PREFIX      ${GFLAGS_INSTALL_DIR}
    INSTALL_DIR ${GFLAGS_INSTALL_DIR}
    CMAKE_ARGS  -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
                -DCMAKE_CXX_FLAGS=${EXTERNAL_PROJECT_CMAKE_CXX_FLAGS}
                -DCMAKE_INSTALL_PREFIX:PATH=${GFLAGS_INSTALL_DIR}
                -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS}
                )
include_directories(BEFORE SYSTEM ${GFLAGS_INCLUDE_DIR})
link_directories(${GFLAGS_LIB_DIR})

# Build glog as an external project.
set(GLOG_INSTALL_DIR ${CMAKE_BINARY_DIR}/libs/glog)
set(GLOG_INCLUDE_DIR ${GLOG_INSTALL_DIR}/include)
set(GLOG_LIB_DIR ${GLOG_INSTALL_DIR}/lib)
ExternalProject_Add(glog_external_project
    SOURCE_DIR  ${CMAKE_SOURCE_DIR}/libs/glog
    PREFIX      ${GLOG_INSTALL_DIR}
    INSTALL_DIR ${GLOG_INSTALL_DIR}
    CMAKE_ARGS  -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
                -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
                -DCMAKE_CXX_FLAGS=${EXTERNAL_PROJECT_CMAKE_CXX_FLAGS}
                -DCMAKE_INSTALL_PREFIX:PATH=${GLOG_INSTALL_DIR}
                -DBUILD_SHARED_LIBS=${BUILD_SHARED_LIBS}
    DEPENDS     gflags_external_project
    )
include_directories(BEFORE SYSTEM ${GLOG_INCLUDE_DIR})
link_directories(${GLOG_LIB_DIR})

Define the dependencies for your target and link against the libraries

add_dependencies(my_program
    gflags_external_project
    glog_external_project
    )
target_link_libraries(my_program pthread gflags glog)

As taken from the fuchsia/cobalt project.


Problem of disambiguation of ENs according to the case or spelling of terms

In French entity-fishing has difficulty recognising Ireland by case and spelling. "Irlande" is the correct spelling "Ireland" is the English spelling and the others are "Irlande" written with spelling mistakes. It is not consistent according to the case certain spellings are not recognized the same, if there is a capital letter or not.
With other countries there is no such problem (I tested with Japan).
correctly recognize : irlande, irland (incorrect), irelande(incorrect), Irelande(incorrect)
only type ner LOCATION: Irlande, Ireland(incorrect)
not recognize : Irland, ireland
See below for example.

Thanks for the issue @aa303554 !
Currently each spelling variant relies on its own statistics as anchor in the French Wikidata, which explains these different behaviours. In case we don't have enough context for a spelling variant, the term will never been linked to the Wikidata entity - in the current state of entity-fishing.
To improve this, my idea is to use better smoothing and priors for variants and for Wikidata labels (currently not used), #72.
Please note: the example you are using is too short for the normal text disambiguation field (normal unit for text field is more a paragraph), you need to use the short text input. It might not solve the spelling error/variants problem in general, but it will work better. I think however it solves your first example:


Please release/tag source for 3.3.0

Issue Type

Bug report

Ansible and Ansible Lint details
There is no way to download 3.3.0 source tarball from github
Desired Behaviour
The current release get tagged in github also
Actual Behaviour (Bug report only)
The current released 3.3.0 version is available only at PyPI.

Tagged, apologies for the oversight.


haskellPackages.squeal-postgresql: fix build, add myself as maintainer

Description of changes
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I have cherrypicked and resolved the conflict onto haskell-updates.
Interestingly in contrast to your commit message you have not added yourself as a maintainer in this PR. Can you please do that in a new PR?

Interestingly in contrast to your commit message you have not added yourself as a maintainer in this PR. Can you please do that in a new PR?

Didn't this do the job? https://github.com/NixOS/nixpkgs/pull/173163/files#diff-f03d404df9c59a2cbb7f6f902247841245c97c3c6ad9096006f8e84aec81c0c0R191

@erictapen I think you need to regenerate the packages after adding yourself as a maintainer.  But the package set has been regenerated in the meantime, so no action should be required from you for this now:
This PR https://github.com/NixOS/nixpkgs/pull/173328, contains https://github.com/NixOS/nixpkgs/pull/173328/commits/6e028bd63297a2e49305d42d67b7be4c69c59c99, which has made its way into https://github.com/NixOS/nixpkgs/pull/172982.

@cdepillabout I see, thanks!


Bigtable: Add integration test for DirectPath fallback to and from CFE

//cc @WeiranFang
This test will simulate an IPv6 outage using a faulty Netty ChannelHandler. Unfortunately this requires a reflection hack to extract the underlying NettyChannelBuilder from the ComputeEngine, which makes this test dependent on the implementation of ForwardingChannelBuilder which is marked ExperimentalApi. This isn't great, but it's better than not testing this functionality or doing some kind of man in the middle proxy or trying to implement the grpclb and dns protocols in the test.

A bit odd that coverage went down from adding a test :man_shrugging:

All comments should be addressed, PTAL


Should be able to provide/configure ssl certificate for each component

While there are ways/settings available to point the components (chef, delivery, analytics) at a ssl certificate, delivery-cluster does not provide a good way of getting the ssl certs on to the box.
For example, if I want my chef server to use "mydomain.crt" and "mydomain.key", I can point to them on the filesystem of the chef-server:
"chef-server": {
  "attributes": {
    "chef-server-12": {
      "extra_config": "nginx['ssl_certificate'] = '/etc/opscode/mydomain.crt'\nngnix['ssl_certificate_key'] = '/etc/opscode/mydomain.key'\n"
     }
   }
}

However, delivery-cluster does not place the cert on to disk, so the chef server configuration will error out.
Could a configuration item be added so each resource is able to put the certs in place using a "remote_file" resource, or put in place from a directory with a machine_file resource?

I can see a way to hack this currently using the trusted_certs directory, but that would end up providing the cert and key to all the nodes within the cluster, and would not be secure.

@dreamnite Thank you for your feedback. I think it would be nice to have this ability in delivery-cluster, I have marked this as "enhancement" since it is not something we are planing to work on in the coming days. Although we are open to accept PR's 😄


AttributeError: 'PolicyNetwork' object has no attribute 'output'

3 play black D5
=3
4 genmove white
Traceback (most recent call last):
File "main.py", line 109, in
argh.dispatch(parser)
File "D:\Python\lib\site-packages\argh\dispatching.py", line 174, in dispatch
for line in lines:
File "D:\Python\lib\site-packages\argh\dispatching.py", line 277, in _execute_command
for line in result:
File "D:\Python\lib\site-packages\argh\dispatching.py", line 260, in call
result = function(*positional, **keywords)
File "main.py", line 51, in gtp
engine_reply = gtp_engine.send(cmd)
File "D:\Python\lib\site-packages\gtp.py", line 154, in send
message_id, getattr(self, "cmd" + command)(arguments))
File "D:\Python\lib\site-packages\gtp.py", line 222, in cmd_genmove
move = self._game.get_move(c)
File "D:\MuGo-master\MuGo-master\strategies.py", line 81, in get_move
move = self.suggest_move(self.position)
File "D:\MuGo-master\MuGo-master\strategies.py", line 115, in suggest_move
move_probabilities = self.policy_network.run(position)
File "D:\MuGo-master\MuGo-master\policy.py", line 152, in run
probabilities = self.session.run(self.output, feed_dict={self.x: processed_position[None, :]})[0]
AttributeError: 'PolicyNetwork' object has no attribute 'output'

thanks，i know how to deal with it。

l
could you tell me how to deal with it?i meet the same problem,thank you !

fixed in https://github.com/brilee/MuGo/commit/8ca84b812a0e555d06da4b616b5c2d0e90c7efb4


Workaround for v10

For issue #12 ,
I found that if fix the socketwatcher / node_pcap code (namespace deprecated message) like this, node v10 will build pass .
I pull request to node_pcap, and socketwatcher also had a fork to solve this issue ,
But, both are not update recently, so I pull request for v10 work around.

pcap merged, close.


fix: show PVA topic's dialog options

Description
The dialog schemas are indexed by dialog id which is the file name for composer dialogs and the display name for topics. The dialog data references the topics internal guid and was failing to find the dialog schema with this id.

Screenshots

Coverage increased (+0.01%) to 55.947% when pulling 80b607fbf69716e612ef213aba87dc4bd603a3a1 on abrown/topics-schema into 6d2b695b2a4564b89e858d8dbad447607feff30e on main.


[Bug] Bug Missing mlc_llm.dll file when setting up MLC LLM for Android development on Windows

🐛
I am trying to set up MLC LLM for Android development on Windows, but I am encountering an issue with a missing mlc_llm.dll file. The file is not present anywhere on my PC, and the closest match I could find was mlc_llm.rst in the C:\Users\rando\Documents\mlc-llm\docs\install directory.
To Reproduce
Followed the installation instructions for MLC LLM on Windows for Android development.
Installed the required dependencies, including Android Studio, Android SDK, NDK, Rust, Git, and Git LFS.
Cloned the MLC LLM repository and navigated to the python directory.
Ran python setup.py install to install the package.
The setup.py script fails with the following error:
RuntimeError: Cannot find libraries: mlc_llm.dll
this is the full error shown
Traceback (most recent call last):   File "C:\Users\rando\Documents\mlc-llm\python\setup.py", line 49, in <module>     LIB_LIST, __version__ = get_lib_path()                             ^^^^^^^^^^^^^^   File "C:\Users\rando\Documents\mlc-llm\python\setup.py", line 25, in get_lib_path     libinfo["find_lib_path"]("mlc_llm")[0],     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\rando\Documents\mlc-llm\python\./mlc_llm/libinfo.py", line 70, in find_lib_path     raise RuntimeError(message) RuntimeError: Cannot find libraries: mlc_llm.dll List of candidates: C:\Users\rando\Documents\mlc-llm\python\mlc_llm\mlc_llm.dll C:\Users\rando\anaconda3\envs\mlc_llm\lib\mlc_llm.dll C:\Users\rando\anaconda3\envs\mlc_llm\mlc_llm.dll C:\Users\rando\anaconda3\envs\mlc_llm\Library\usr\bin\mlc_llm.dll C:\Users\rando\anaconda3\envs\mlc_llm\Library\bin\mlc_llm.dll C:\Users\rando\anaconda3\envs\mlc_llm\Scripts\mlc_llm.dll C:\Users\rando\anaconda3\condabin\mlc_llm.dll C:\Program Files\Common Files\Oracle\Java\javapath\mlc_llm.dll C:\Program Files (x86)\VMware\VMware Player\bin\mlc_llm.dll C:\Windows\system32\mlc_llm.dll C:\Windows\mlc_llm.dll C:\Windows\System32\Wbem\mlc_llm.dll C:\Windows\System32\WindowsPowerShell\v1.0\mlc_llm.dll C:\Windows\System32\OpenSSH\mlc_llm.dll C:\Program Files\Git\cmd\mlc_llm.dll C:\Program Files\Git LFS\mlc_llm.dll C:\Program Files\Java\jdk-22\bin\mlc_llm.dll C:\Users\rando\anaconda3\mlc_llm.dll C:\Users\rando\anaconda3\Library\mingw-w64\bin\mlc_llm.dll C:\Users\rando\anaconda3\Library\usr\bin\mlc_llm.dll C:\Users\rando\anaconda3\Library\bin\mlc_llm.dll C:\Users\rando\anaconda3\Scripts\mlc_llm.dll C:\Users\rando\.cargo\bin\mlc_llm.dll C:\Users\rando\AppData\Local\Microsoft\WindowsApps\mlc_llm.dll C:\Users\rando\AppData\Local\Programs\Microsoft VS Code\bin\mlc_llm.dll C:\Users\rando\AppData\Local\GitHubDesktop\bin\mlc_llm.dll C:\ghcup\bin\mlc_llm.dll
Expected behavior
I expected the mlc_llm.dll file to be present in the package or generated during the installation process, allowing the setup.py script to complete successfully.
Environment

Platform : Vulkan
Operating system : Windows
Device  : PC+ amd gpu and cpu
How you installed MLC-LLM : conda
How you installed TVM-Unity : source
Python version : Python 3.11.9

Additional context
I have followed the installation instructions provided in the MLC LLM documentation for Android development on Windows. I have installed all the required dependencies and set up the necessary environment variables. However, I am stuck at the step where I need to run python setup.py install due to the missing mlc_llm.dll file.
I have searched for the file on my entire PC but couldn't find it. The closest match was mlc_llm.rst in the docs\install directory of the cloned repository.
Any guidance on how to resolve this issue and proceed with the installation would be greatly appreciated.

you don't need to build from source and run setup.py, instead follow prebuilt option here to obtain a copy https://llm.mlc.ai/docs/install/mlc_llm.html#install-mlc-packages

you don't need to build from source and run setup.py, instead follow prebuilt option here to obtain a copy https://llm.mlc.ai/docs/install/mlc_llm.html#install-mlc-packages

Thank you for your replay
Can please clarify on this

are you telling me that I only have to follow what it is written here and no need to worry about setup.py?

are you telling me that I only have to follow what is written here and no need to worry about setup.py?
that is correct

issue resolved


Different results for tests/headers/objc_template.h in LLVM trunk.

Running the tests on LLVM trunk with (or without) #694 yields:
diff --git a/tests/expectations/tests/objc_template.rs b/tests/expectations/tests/objc_template.rs
index e5a874c6..95d12ff6 100644
--- a/tests/expectations/tests/objc_template.rs
+++ b/tests/expectations/tests/objc_template.rs
@@ -11,8 +11,8 @@ extern crate objc;
 pub type id = *mut objc::runtime::Object;
 pub trait Foo {
     unsafe fn get(self)
-    -> id;
+    -> *mut ObjectType;
 }
 impl Foo for id {
-    unsafe fn get(self) -> id { msg_send!(self , get) }
+    unsafe fn get(self) -> *mut ObjectType { msg_send!(self , get) }
 }

cc @scoopr

Ah yes, I was kind of afraid of this :/
Suggestions are welcome how I should handle this, the template handling stuff is a bit harder to grok in bindgen.
So before the objc template params came up as an typedef, but now they seem to be TypeRefs, which I think aligns with, and are handled, as proper template params. And to keep things simple I'd just want the type to be replaced with the ‘id’.
I almost got it working hacking Item::named_type() to rewrite the name to "id" when location.referenced().typedef_type().kind() == CXType_ObjCId, but that made it also mut-pointer. Also I kind of feel that it should be done earlier in the parsing.
I suppose making it behave like a proper generic in rust land would also be an option, but so far I have not looked in to that.


test klayout macosx packages

@njcoburn offered to test the recent work on macosx packages.
putting some instructions there for testing:

install miniconda in a new environment https://docs.conda.io/projects/continuumio-conda/en/latest/user-guide/install/macos.html
run the following command:

source silicon-macosx-env/bin/activate
conda install -c litex-hub klayout magic openlane open_pdks.gf180mcuc
bash ~/Downloads/mixed-signal.gf180mcuc-0-Linux-x86_64.sh -b -p silicon-env/
source silicon-env/bin/activate
klayout -v
yosys --version
openroad -version
netgen -batch quit
magic -dnull -noconsole --version
echo exit | flow.tcl -interactive # openlane

@proppy I finally got back to trying this on my personal Mac M1.
I am not getting past here...
PREFIX=/Users/njcoburn/opt/anaconda3/envs/myenv/silicon-env
/Users/njcoburn/Downloads/mixed-signal.gf180mcuc-0-Linux-x86_64.sh: line 213: md5sum: command not found```


Deprecate env_logger::from_env and clean up examples

The env_logger::builder and env_logger::from_env methods are a bit confusing as-is, because it's not clear that env_logger::builder should call Builder::from_default_env instead of Builder::new. The builder function is a convenient way to get started configuring your logger before initializing it, but the from_env method doesn't actually save you any work because you still need to use env_logger::Env, so may as well use env_logger::{Builder, Env} while you're at it.
I've also cleaned up our examples a bit and added a new one for logging in cargo test.

I'll fix up that lint while I'm here.

I'll fix up that lint while I'm here.

Started on #169. Some more popped up after that. You should be able to push to that Pr since you’re maintainer.

Anything you want to add to the PR @KodrAus? Else this can be merged.


Fix issue with precompute_ref_log_probs not working when rpo_alpha is None

When using the precompute_ref_log_probs=True option, the training process is halted( the training loss sucks at 0.6932 which shows the model is not training). This issue arises due to the following code segment:
if (
            "reference_chosen_logps" in batch
            and "reference_rejected_logps" in batch
            and self.args.rpo_alpha is not None
        ):
            reference_chosen_logps = batch["reference_chosen_logps"]
            reference_rejected_logps = batch["reference_rejected_logps"]

The condition self.args.rpo_alpha is not None prevents the reference_chosen_logps and reference_rejected_logps from being used in the training process when rpo_alpha is set to None. This is problematic because when precompute_ref_log_probs=True, we still need to access these log probabilities from the batch regardless of the rpo_alpha value.
To resolve this issue, the condition should be adjusted to ensure that reference_chosen_logps and reference_rejected_logps are accessed when precompute_ref_log_probs is set to True, independent of the rpo_alpha value.

@mina-parham would it be possible to add a test for this?

@mina-parham would it be possible to add a test for this?

yes of course, I'm on it :-)

I added the test for this.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Issue reporting Jira Collector Stats

Hi
I've got my Jira collector running, and mapped the status' in my customised Jira worksflow etc.
I can select my Jira project from the DB drop down.
I can see the Dashboard listing the current active Sprint (with correct name) but the stats aren't reporting correctly.
Total = 60 (but i can't see how that matches anything in my Sprint)
WIP = 0
Done = 0
No Features listed under In Progress
Some thoughts:

Should this be the numeric ID or the name string? feature.jiraIssueTypeId=
Do issues need to have a specific Jira field present?  I've configured customised screens for my issues with only specific fields that I wanted.
Any other ideas of what I could check?

Thanks for your help in advance

@gillianwilson
Can you please share your properties file.
#Jira API Query file names (String template requires the files to have .st extension) (required)
feature.storyQuery=story
feature.epicQuery=epic
feature.projectQuery=projectinfo
feature.memberQuery=memberinfo
feature.sprintQuery=sprintinfo
feature.teamQuery=teaminfo
feature.trendingQuery=trendinginfo
What I am able to understand is that JIRA collector requires -->
story.st, epic.st, projectinfo.st, memberinfo.st, sprintinfo.st, teaminfo.st, trendinginfo.st
And in each of these files, it requires a query. What kind of query is needed in each of these files.
Thanks

@aryasunny , @gillianwilson :  Thank you for reaching out.  @aryasunny has already asked this question on the following post, which I will follow-up on:  https://github.com/capitalone/Hygieia/issues/497.  Please look to that post for further details.

@amp5208 Hey Arnold,
I followed your response in #497, and it didn't address the question posted here.
I was wondering if you can clarify where the JIRA API Query file names are being declared, how they are used, and what kind of query they need?
I couldn't find these files in the Hygieia file structure, or reference to them in the Jira API documentation... so maybe I'm misunderstanding how this info is being used.
I'm running in to issues querying data from an enterprise instance of Jira ran on a private node, and i'm wondering if these are at least part of the reason.

@415DomSmith , Thank you for clarifying.  The API query files are embedded in source and do not need to be modified.
Your connectivity issues are more likely related to your configuration of the following properties:

. . .
# In Jira, general IssueType IDs are associated to various "issue"
# attributes. However, there is one attribute which this collector's
# queries rely on that change between different instantiations of Jira.
# Please provide a numerical ID reference to your instance's IssueType for
# the lowest level of Issues (e.g., "user story") specific to your Jira
# instance.  Note:  You can retrieve your instance's IssueType ID
# listings via the following URI:  https://[your-jira-domain-name]/rest/api/2/issuetype/
feature.jiraIssueTypeId=Story
# In Jira, your instance will have its own custom field created for "sprint" or "timebox" details,
# which includes a list of information.  This field allows you to specify that data field for your
# instance of Jira. Note: You can retrieve your instance's sprint data field name
# via the following URI, and look for a package name com.atlassian.greenhopper.service.sprint.Sprint;
# your custom field name describes the values in this field:
# https://[your-jira-domain-name]/rest/api/2/issue/[some-issue-name]
feature.jiraSprintDataFieldName=customfield_11112
# In Jira, your instance will have its own custom field created for "super story" or "epic" back-end ID,
# which includes a list of information.  This field allows you to specify that data field for your instance
# of Jira.  Note:  You can retrieve your instance's epic ID field name via the following URI where your
# queried user story issue has a super issue (e.g., epic) tied to it; your custom field name describes the
# epic value you expect to see, and is the only field that does this for a given issue:
# https://[your-jira-domain-name]/rest/api/2/issue/[some-issue-name]
feature.jiraEpicIdFieldName=customfield_11111
. . .

You may also reference more information on this configuration at the following issue comment:  https://github.com/capitalone/Hygieia/issues/276#issuecomment-172060522.  Please validate the above configurations and provide some log output for me to further debug.

@amp5208 Thanks Arnold,
Looks like i've got everything connected now, except for populating the sEvaluate field in MongoDB, and thus being able to display the score properly on the widget.
I understand that the way my companies Jira is set up (using a customfield instead of the out of the box field) is preventing sEvaluate from being updated.
But otherwise, it looks like everything is working.

@415DomSmith , definitely understand your company's need - as mentioned, we have foreseen this need and we have an enhancement on the issue backlog to fix this.  Thank you for reaching out, and I hope you look forward to our future enhancements!
@tabladrum / @jdamick :  This issue has been resolved; please close this issue at your earliest convenience.

Issue #673. See if latest code with PR #682 fixed.

Closed. Reopen if there are any problems. Use latest codebase and follow cleanup instructions provided in https://github.com/capitalone/Hygieia/pull/1137.


Navigation with <C-n>, <C-p> instead of <Up>, <Down>(arrow keys)

As title.

You can do it in your config, call the .setup function with a set_keymaps hook.
require('fine-cmdline').setup({
  hooks = {
    set_keymaps = function(imap, feedkeys)
      local fn = require('fine-cmdline').fn

      imap('<C-n>', fn.up_search_history)
      imap('<C-p>', fn.down_search_history)
    end
  }
})

If you prefer the "simple" history navigation replace up_search_history with up_history, and down_search_history with down_history.

You can do it in your config, call the .setup function with a set_keymaps hook.

This is not what I meant. When the completion list is shown, I want to use <C-n>, <C-p> to change selection.

That's weird. I don't remap  <C-n> or <C-p> inside the plugin, they should work. Maybe you have some conflicting keymap in your config.
If you try ctrl + o then use the command :verbose imap <C-p> it should tell you what you have bound in that key.

Yes I use nvim-cmp but I cannot delete it because that is an important plugin. Sorry I have to delete this one.

You don't have to delete anything. I use nvim-cmp, and for me it works fine.
Can you share your config?

This is part of nvim-cmp config:
and notice that I didn't set anything related to <C-n>, <C-p>.
use {
  'hrsh7th/nvim-cmp',
  requires = {
    'neovim/nvim-lspconfig',
    'hrsh7th/cmp-buffer',
    'hrsh7th/cmp-path',
    'hrsh7th/cmp-nvim-lua',
    'hrsh7th/cmp-nvim-lsp',
    'hrsh7th/cmp-vsnip',
    'hrsh7th/vim-vsnip'
  },
  config = function()
    local cmp = require'cmp'
    cmp.setup {
      snippet = {
        expand = function(args)
          vim.fn["vsnip#anonymous"](args.body) -- For `vsnip` users.
          -- require('luasnip').lsp_expand(args.body) -- For `luasnip` users.
          -- vim.fn["UltiSnips#Anon"](args.body) -- For `ultisnips` users.
          -- require'snippy'.expand_snippet(args.body) -- For `snippy` users.
        end,
      },
      mapping = {
        -- <option-shift-P/N>
        ['∏'] = cmp.mapping.scroll_docs(-4),
        ['˜'] = cmp.mapping.scroll_docs(4),
        ['<C-o>'] = cmp.mapping.complete(),
        ['<C-c>'] = cmp.mapping.close(),
        ['<C-y>'] = cmp.mapping.confirm({
          behavior = cmp.ConfirmBehavior.Replace,
          select = true
        }),
        -- Tab Completion.
        ['<Tab>'] = cmp.mapping(cmp.mapping.select_next_item(), { 'i', 's' }),
        ['<S-Tab>'] = cmp.mapping(cmp.mapping.select_prev_item(), { 'i', 's' })
      },

So it's not nvim-cmp. It must be something else.
There is a way to unmap them.
require('fine-cmdline').setup({
  hooks = {
    after_mount = function(input)
      vim.api.nvim_buf_del_keymap(input.bufnr, 'i', '<C-p>')
      vim.api.nvim_buf_del_keymap(input.bufnr, 'i', '<C-n>')
    end
  }
})

There is also the vimscript alternative.
-- Use inside the after_mount hook
vim.cmd([[
  iunmap <buffer> <C-n>
  iunmap <buffer> <C-p>
]])

I think one of those should restore the default behavior of those keymaps.

So... I guess that's it. I have no idea what's causing the issue. No way to reproduce it. I'm closing this for now.


BUG: member with special name such as "@if" is not prefixed with '@' in generated code.

    public partial class MyClass(int @if, ...)
in generated code:
    __if = value.if;

thanks, I've released for this issue.
However, TypeName and MethodName are not supported(I won't do it now).


PR - Jan22- Quiet Mode - CLA Signed Not Approved - 1

Hi @selvabrillio, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla-ppe.dotnetfoundation.org.

TTYL, DNFBOT;

@selvabrillio, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


Glossary changes based on @pattivacek comments--addresses Issue #83

I had added text to the glossary based on comments @pattivacek  made on an earlier draft of this PR (which I accidentally merged directly).   I am opening this PR in part to act on those suggestions, and also to solicit changes based on a more fundamental question raised by @pattivacek. I am particularly directing this to @iramcdonald, but others are welcomed to chime in.
What appears here is essentially the same glossary as in the Standard. I have not included the explanation of  Conformance Terminology, as these pages use much less of it than the Standard, and @pattivacek noted that none of the acronyms in that list appear in the Deployment pages. I also eliminated  some one-sentence introductory text that didn't feel needed in this context.  Is this what we need for such a section in Deployment Best Practices? Or do we need to evolve new terminology for this document? Perhaps we need to cull the pages.
I would appreciate your thoughts, as well as those of others on the team.

If we follow-upon the suggestion of  @iramcdonald we would need to remove the existing glossary in the Standard and replace the elements we removed here. If we have consensus here to make this move I will open a new PR in the Standard to remove the glossary there. I still think, as suggested above, that we should skim for other terms unique to deployment, if any.

I need an approval and I can close this PR.

Thanks, Marina.