Sorted dict 2

This pull request contains the latest version of the SortedDict code and documentation, and additionally includes the recent suggestions from Kevin Squire for usage of the 'compat' package in testing (so that the tests run in both Julia 0.3 and 0.4) and the use of the @test macro in the test file instead of the @assert macro.

This build failed since REQUIRE does not include the Compat package

Coverage remained the same at 82.6% when pulling 1766593bc0228ec93eca526a761cc81ce6d890b1 on StephenVavasis:SortedDict-2 into 553c7dd3068d98c7a8fe44ec07fc93b57e875043 on JuliaLang:master.

I fixed the REQUIRE file, and I also fixed a typo in the documentation.

I added Compat to the REQUIRE file, pushed the new commit to the server,
and added a comment to #70.  Is my pull request still active, or do I need
to somehow reactivate it?
(Kevin: I have cc'd your gmail account on this message because I can't
tell if you will get this message through another channel.)
-- Steve
On Thu, 22 Jan 2015, Avik Sengupta wrote:

This build failed since REQUIRE does not include the Compat package
—
Reply to this email directly or view it on
GitHub.[AHhEhzri2PSGgJoOKf-n0tywqz19Jmlwks5nkSglgaJpZM4DNqaX.gif]

Hi Stephen, thanks for the email. I've been swamped, but hope to get to
this tomorrow.  I'm hoping we can just merge.  Thanks for your patience.
Avik,  thanks for taking a quick look.
Cheers, Kevin
On Thursday, January 22, 2015, StephenVavasis<EMAIL_ADDRESS>wrote:

I added Compat to the REQUIRE file, pushed the new commit to the server,
and added a comment to #70. Is my pull request still active, or do I need
to somehow reactivate it?
(Kevin: I have cc'd your gmail account on this message because I can't
tell if you will get this message through another channel.)
-- Steve
On Thu, 22 Jan 2015, Avik Sengupta wrote:

This build failed since REQUIRE does not include the Compat package
—
Reply to this email directly or view it on
GitHub.[AHhEhzri2PSGgJoOKf-n0tywqz19Jmlwks5nkSglgaJpZM4DNqaX.gif]

—
Reply to this email directly or view it on GitHub
https://github.com/JuliaLang/DataStructures.jl/pull/70#issuecomment-71147982
.

Merged in #71


Add Waffle.io Throughput Graph

Add in some metrics badges to the project README.md
This is the Markdown for the badge:
[![Waffle.io - Columns and their card count](https://badge.waffle.io/chingu-voyage3/bears-16.svg?columns=all)](https://waffle.io/chingu-voyage3/bears-16)

Will give you this shiny one:

And this one will give you a nice burndown chart 🔥 :
[![Throughput Graph](https://graphs.waffle.io/chingu-voyage3/bears-16/throughput.svg)](https://waffle.io/chingu-voyage3/bears-16/metrics/throughput)

SHINY:

This is for no other reason than to keep us all motivated to taking on these issues, this is the very beginning

I like them both. :+1:
They are nice motivators. It would be easy for anyone to see how we are doing here. :rocket: :building_construction: :hammer: :wrench:
I'd like to pick up it and play with these badges, of course, if you didn't mind. :smiley:

Absolutely, go ahead @mar-bi 👌
Drop them into the top of the README.md

What do you think about this? :smile:
grad.then()

Chingu Voyage 3 project (bears-16 team)
Life after freeCodeCamp
Completed your boot camp? No more freeCodeCamp challenges to take?
Looks like it's time to get a job! 💪
grad.then() is aimed at you, to give you the information and tools you need to
get a job after completing your training.

Project Progress
We are proud to work as a team, and here is our project progress.
We are aspiring developers and eager learners.
And this is the very beginning.

Super duper! 🚀

I wanted it to be super motivating. :muscle:

Ok, so looks like there's one side effect of changing the project name
The URL needs changing on the readme for the waffle badge and graph @mar-bi
Can I leave this with you?

I saw it.
Sure. I will fix it now


Rewrite for loop desugaring to use language items

Rendered

This requires a good way for HIR lowering to refer to lang items (currently they are collected after lowering). cc #30809 @eddyb

Since lang items are an implementation detail of rustc, I do not see the need for a RFC.
I personally prefer using lang items instead of hardcoding paths, and would like to see a proper discussion on rust-lang/rust#30809.
cc @rust-lang/compiler

@eddyb RFCs for implementation details of the compiler are allowed and encouraged! It's what we have a T-compiler label for.
I also agree we should do this, in fact I filed https://github.com/rust-lang/rust/issues/20541 about the same thing a year ago (back when the desugarings were in libsyntax). It's still not clear to me how that should work though, I'd like to see some ideas here or elsewhere for how this could be implemented

@nrc Right, I want the discussion, but it felt that this RFC was dealing with language semantics and not implementation details (I see this change as a bugfix). Hopefully the tagging solves that.
To expand on what was suggested in rust-lang/rust#30809:
We could have an enum in librustc_front of all the lang items it's going to use, and a map:
enum FrontLangItem {
    IntoIteratorIntoIter,
    IteratorNext,
    Range,
    OptionSome,
    OptionNone
    ...
}

fn lower(krate: ast::Crate) -> (hir::Crate, NodeMap<FrontLangItem>) {...}

Then resolve can take that map, look up HIR nodes in there, and if they are found, ignore the actual path, and convert the FrontLangItem into a librustc lang item DefId to be stored in the def_map.

Hmm, a lazy approach to lang items, that sounds promising. The approach I had considered before was that we could just move the lang item machinery earlier in the compiler and allow resolving lang items to fully qualified paths as well as actual references. Not sure if that will actually work.

I agree with @eddyb that this probably doesn't rise to the level of complexity that necessitates an RFC, but it does seem like a reasonably good idea to me, presuming we can rearrange the lang item business and make that work out.

That said, I should note that I don't feel especially motivated to support #[no_core]. I consider core and the compiler pretty tied together and don't expect to ever stabilize or really support #[no_core]. If there are use cases for which core is really unsuitable, I'd like to know more about them and see if we can fix that (perhaps through some sort of target-specific subsetting or what have you).

Hear ye, hear ye. This RFC is now entering final comment period.
The conclusion in the meeting was that while this may or may not have truly needed an RFC, there is one now and, since it generated some mild discussion and controversy, we might as well accept it like any other.

Making Option a language item was something that I hoped we could avoid, but was probably inevitable anyway. I prefer it to the ad-hoc approach we have right now anyway.

There are two kinds of language items - on the one hand we have "normal" items like Iterator, or Option, or eq_slice, not special-cased in any way. The only thing the compiler has to know about them is their path, then it can use them like usual structs, functions or traits.
On the other hand we have strange beasts like Drop or UnsafeCell deeply integrated into the compiler and having additional custom restrictions or abilities.
Maybe they can be separated somehow?

@petrochenkov
I am not sure about that. Drop is also not that special itself - the compiler prohibits you from using it normally, but its main specialness is that the compiler calls it from drop glue,

It only seems worthwhile to merge this RFC if we have a plan for how we'll handle lang items in the HIR lowering step. That seems to be the difficult part of implementing the RFC. Since it isn't part of the RFC, the FCP seems premature (unless we just close the PR).

So the language team reviewed the situation here and came to the following conclusion:

It is not clear whether we want to make the change suggested here.

Deciding whether we want to make the change suggested here would require deeper thought on how such a change would actually be implemented

(There is on the one hand the broad question what would be the plan for the set of lang items and how each are special-cased.  There is also the much more narrow question of how just this particular desugaring would be revised to use lang items.)

So, we don't want to accept this RFC without having more discussion of the implementation details.
But we also do not think that this RFC thread is the right place for such a discussion of hypothetical implementation details.
There are two places that team members asserted would be better spots for such a discussion:

One could put up a PR against rust-lang/rust with a concrete set of changes. Then we would discuss those changes. (Doing this is in some ways ideal, since there will be no ambiguity about what we are discussing. However, it does run the risk that the team may decide "no, this PR is not quite what we want for the compiler", and closing the PR.

One could put up a post on internals.rust-lang.org to discuss how such an implementation should be made. (That is a better venue for that sort of off-the-cuff discussion, rather than the rather formal process that the RFC protocol follows.)

(closing; see previous comment for why.)


Git command not found

Git command will not be found/usable if not on path (?). VS Code already has a setting "git.path" which is set but not used by git blame it seems.
So Git works as expected in VS Code, Git Blame reports an error that git can not be executed.
[ 08:45:49 | command ] git rev-parse --show-toplevel
[ 08:45:49 | critical ] Error: spawn git ENOENT
[ 08:45:49 | info ] Will not try to blame file "c:\Users\marc.....html" as it is outside of the current workspace
[ 08:45:53 | info ] Will not try to blame file "extension-output-#13" as it is outside of the current workspace

Note: File is not outside of Workspace.

Hello Marc!
Thank you for the issue.
Right now we use a crude implementation of the vscode.git extension to get the git path. If we can't get it from that built in extension we default to attempting git in the path.
Sometimes it can take a while for vscode.git to get activated. Perhaps this is what you are experiencing? Does it start working after a short while (10-15 seconds)?

Git extension works as expected where I can push/pull/commit. If I open a file vs code reports the git blame error.
So, it does not start to work at any later point in time. It does work fine as soon as I put git on the path.
Furthermore, I am on the newest version of VS Code and its extensions. (just today updated to 1.39.0 with same problem)

Also, other Git related extensions (e.g. Git Graph, Git History) work fine as well.

Did check the code for Git Graph (which searches a lot for git exe, not ideal) and Git History which uses this:
this.gitExtension = extensions.getExtension('vscode.git');
this.gitApi = this.gitExtension!.exports.getAPI(1);
this.gitExecutablePath = this.gitApi.git.path;

https://github.com/DonJayamanne/gitHistoryVSCode/blob/a0cf14a13539f17f93c8ec99896cb9ecd3c55133/src/adapter/exec/gitCommandExec.ts
which looks closer to the example you mentioned.

Thank you for the research and quick responses!
Last time I tried to implement the getAPI function it had some issues. I can't remember exactly what but in the experiments I did yesterday it looks like it is working now. I will change getGitCommand to the following in the next version:
export async function getGitCommand(): Promise<string> {
    const vscodeGit = extensions.getExtension<GitExtension>(
        "vscode.git",
    );

    if (vscodeGit && vscodeGit.exports.enabled) {
        const api = vscodeGit.exports.getAPI(1);
        if (api.state === "initialized") {
            return api.git.path;
        } else {
            let resolved = false;
            return new Promise((resolve): void => {
                api.onDidChangeState((newState): void => {
                    if (newState === "initialized" && resolved === false) {
                        resolved = true;
                        resolve(api.git.path);
                    }
                });
            });
        }
    }

    return GIT_COMMAND_IN_PATH;
}

A fix for this was uploaded to the marketplace just now. It should be available in a few hours to a day.


⚠ SpeakUpForHope.org has degraded performance

In fcd2ac7, SpeakUpForHope.org (https://www.speakupforhope.org) experienced degraded performance:

HTTP code: 200
Response time: 24922 ms

Resolved: SpeakUpForHope.org performance has improved in 38476d9 after 10 minutes.


Add the newest paper on Clustering with River from KDD'22

Can you the year in parentheses too? :)

Can you the year in parentheses too? :)

Just did! :D

Cheers


errors on baqup

This issue may be inconsistent or due to other problems as the concerned folder was imported from Evernote.
Anyway, I called main like this:
baqup/main.py --access_token "ABCDEF1GH2abcdd=e123456789f0/g1hilmIJKLMNm2n3oOpqrPQstu45Rvwx6STU78VWX="  --root_folder_id AbCDEFgHHIl --output_directory my_backup
The first six thread were backed up
INFO:root:Backing up folder my_quip_folder_0...
INFO:root:  Backing up thread Report XANTOS (OOfAAAANU4B)...
INFO:root:  Backing up thread Workgroup (HWTAAASVKEL)...
INFO:root:  Backing up thread Acronyms (NIaAAAlbMii)...
INFO:root:  Backing up thread tricks for ZOTS (KaJAAAMKxPv)...
INFO:root:  Backing up thread zots for tricks (dENAAApyH59)...
INFO:root:  Backing up thread Z8080 chemin a parcourir (CVAAAAmJ4H6)...
INFO:root:  Backing up thread Z8080 pre-verification (VYWAAAVhT5Y)...
Traceback (most recent call last):
  File "baqup/main.py", line 256, in <module>
    main()
  File "baqup/main.py", line 68, in main
    _run_backup(client, output_directory, args.root_folder_id)
  File "baqup/main.py", line 75, in _run_backup
    client, output_directory, 0)
  File "baqup/main.py", line 118, in _descend_into_folder
    _backup_thread(thread, client, folder_output_path, depth + 1)
  File "baqup/main.py", line 128, in _backup_thread
    tree = client.parse_document_html(thread["html"])
  File "/home/myuser/quip/quip-api-master/samples/baqup/quip.py", line 574, in parse_document_html
    return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
  File "<string>", line 124, in XML
cElementTree.ParseError: mismatched tag: line 127, column 346
Access token, file IDs and document names were changed.
It seems there was a problem in parsing XML. Could it be a wrong utf-8 character or something of the like?

Thanks for the report- may I have your permission to examine the Z8080 pre-verification (VYWAAAVhT5Y) document to see if I can reproduce?

Obviously.
I changed every link and name, here is the true report:
INFO:root:Backing up folder hern_0...
INFO:root:  Backing up thread Relazione CARSTOS (OOfAAAANU4B)...
INFO:root:  Backing up thread Workgroup (HWTAAASVKEL)...
INFO:root:  Backing up thread Acronyms (NIaAAAlbMii)...
INFO:root:  Backing up thread dummies for hern (KaJAAAMKxPv)...
INFO:root:  Backing up thread hern for dummies (dENAAApyH59)...
INFO:root:  Backing up thread H2020 cose da fare (CVAAAAmJ4H6)...
INFO:root:  Backing up thread H2020 pre-submission (VYWAAAVhT5Y)...
Traceback (most recent call last):
File "baqup/main.py", line 256, in
main()
File "baqup/main.py", line 68, in main
_run_backup(client, output_directory, args.root_folder_id)
File "baqup/main.py", line 75, in _run_backup
client, output_directory, 0)
File "baqup/main.py", line 118, in _descend_into_folder
_backup_thread(thread, client, folder_output_path, depth + 1)
File "baqup/main.py", line 128, in _backup_thread
tree = client.parse_document_html(thread["html"])
File "/Users/carlo/Desktop/HERN/quip-api-master/samples/baqup/quip.py",
line 574, in parse_document_html
return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
File "", line 124, in XML
cElementTree.ParseError: mismatched tag: line 127, column 346
ecco il comando:
baqup/main.py --access_token
"TUNPQU1BU2twakk=|1460814688|6/n3cgdOFRlCPk3j7qXugjTYbmf08Mwjx1JDLP30YGM="
--root_folder_id EdFAOAvIIMk --output_directory bkup
There is nothing personal inside, so you can use any other file for any
test.
The name of the specific blocking file is
H2020 pre-sumbission (https://quip.com/s873Ad4XbaTu).
Ciao.
c
On Mon, Apr 20, 2015 at 7:59 PM, Casey Muller<EMAIL_ADDRESS>wrote:

Thanks for the report- may I have your permission to examine the Z8080
pre-verification (VYWAAAVhT5Y) document to see if I can reproduce?
--
Reply to this email directly or view it on GitHub
https://github.com/quip/quip-api/issues/4#issuecomment-94524961.

--
Carlo A. Bertelli
Charta servizi e sistemi per il territorio e la storia ambientale srl
Dipendenze del palazzo Doria,
vc. alla Chiesa della Maddalena 9/2 16124      Genova (Italy)
tel./fax +39(0)10 2475439  +39<PHONE_NUMBER>  gsm:+39<PHONE_NUMBER>
e-mail<EMAIL_ADDRESS>http://www.chartasrl.eu

The root cause of this appears to be a bug in the evernote importer.
I will file a bug to fix both evernote import and platform export, but for now the issue appears to only be in the link containing "Standard proposal template (administrative forms and structure of technical annex)", so if you delete and recreate that bullet point it may fix it in this case.
So sorry for the trouble!

How did you spot it? I have several other files and maybe I'll find otrer
blocking errors. I would prefer to fix them myself then passing them to you
to find a fix.
Thank you very much.
c
On Mon, Apr 20, 2015 at 10:41 PM, Casey Muller<EMAIL_ADDRESS>wrote:

The root cause of this appears to be a bug in the evernote importer.
I will file a bug to fix both evernote import and platform export, but for
now the issue appears to only be in the link containing "Standard proposal
template (administrative forms and structure of technical annex)", so if
you delete and recreate that bullet point it may fix it in this case.
So sorry for the trouble!
--
Reply to this email directly or view it on GitHub
https://github.com/quip/quip-api/issues/4#issuecomment-94563059.

--
Carlo A. Bertelli
Charta servizi e sistemi per il territorio e la storia ambientale srl
Dipendenze del palazzo Doria,
vc. alla Chiesa della Maddalena 9/2 16124      Genova (Italy)
tel./fax +39(0)10 2475439  +39<PHONE_NUMBER>  gsm:+39<PHONE_NUMBER>
e-mail<EMAIL_ADDRESS>http://www.chartasrl.eu

I fetched the thread:
>>> t = client.get_thread("s873Ad4XbaTu")

Parsed the HTML and looked at the error:
>>> client.parse_document_html(t["html"])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/casey/quip/clients/quip.py", line 619, in parse_document_html
    return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
  File "<string>", line 124, in XML
cElementTree.ParseError: mismatched tag: line 127, column 346

Confirmed the problem was in that line and looked at its contents:
>>> client.parse_document_html(t["html"].split("\n")[126])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/casey/quip/clients/quip.py", line 619, in parse_document_html
    return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
  File "<string>", line 124, in XML
cElementTree.ParseError: mismatched tag: line 1, column 352
>>> t["html"].split("\n")[126]
u'

Standard proposal template (administrative forms and structure of technical annex)
'

Then finally confirmed the rest of the document was okay:
>>> client.parse_document_html("\n".join(t["html"].split("\n")[:126] + t["html"].split("\n")[127:]))
<Element 'html' at 0x106c6d030>

Thank you.
c
On Mon, Apr 20, 2015 at 10:55 PM, Casey Muller<EMAIL_ADDRESS>wrote:

I fetched the thread:

t = client.get_thread("s873Ad4XbaTu")

Parsed the HTML and looked at the error:

client.parse_document_html(t["html"])
Traceback (most recent call last):
File "", line 1, in
File "/Users/casey/quip/clients/quip.py", line 619, in parse_document_html
return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
File "", line 124, in XML
cElementTree.ParseError: mismatched tag: line 127, column 346

Confirmed the problem was in that line and looked at its contents:

client.parse_document_html(t["html"].split("\n")[126])
Traceback (most recent call last):
File "", line 1, in
File "/Users/casey/quip/clients/quip.py", line 619, in parse_document_html
return xml.etree.cElementTree.fromstring(document_xml.encode("utf-8"))
File "", line 124, in XML
cElementTree.ParseError: mismatched tag: line 1, column 352
t["html"].split("\n")[126]
u'
Standard proposal template (administrative forms and structure of technical annex)'

Then finally confirmed the rest of the document was okay:

client.parse_document_html("\n".join(t["html"].split("\n")[:126] + t["html"].split("\n")[127:]))
<Element 'html' at 0x106c6d030>

--
Reply to this email directly or view it on GitHub
https://github.com/quip/quip-api/issues/4#issuecomment-94566183.


Java : Java Substring #64

write your solution to this java problem of hackerrank :-
Problem link: https://www.hackerrank.com/challenges/java-substring/problem

Please assign me this issue.

@Rittika1234 Have you checked this problem is not related to any other issue? If yes, then you may start working to this issue.

I have done a lot of program in java. I want to contribute

@dhirajmishra98 You may raise an issue for a hackerrank problem of java, mentioning the problem link and please ensure that problem is not already raised in any issue or added to the repo. Thanks!


python39Packages.jupyter-server-mathjax: 0.2.3 -> 0.2.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python39Packages.jupyter-server-mathjax is: "MathJax resources as a Jupyter Server Extension"
meta.homepage for python39Packages.jupyter-server-mathjax is: "https://jupyter.org"
meta.changelog for python39Packages.jupyter-server-mathjax is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.2.5 with grep in /nix/store/bi279kzd772g01hfj12nck1bgk2xxy0z-python3.9-jupyter-server-mathjax-0.2.5

found 0.2.5 in filename of file in /nix/store/bi279kzd772g01hfj12nck1bgk2xxy0z-python3.9-jupyter-server-mathjax-0.2.5

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.jupyter-server-mathjax
python310Packages.jupyterlab-git
python310Packages.nbdime
python39Packages.jupyter-server-mathjax
python39Packages.jupyterlab-git
python39Packages.nbdime

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bi279kzd772g01hfj12nck1bgk2xxy0z-python3.9-jupyter-server-mathjax-0.2.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python39Packages.jupyter-server-mathjax https://github.com/r-ryantm/nixpkgs/archive/cb09f866e2bed3edc0f5e45849c8a6a523a2aec3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bi279kzd772g01hfj12nck1bgk2xxy0z-python3.9-jupyter-server-mathjax-0.2.5
ls -la /nix/store/bi279kzd772g01hfj12nck1bgk2xxy0z-python3.9-jupyter-server-mathjax-0.2.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python310Packages.jupyter-server-mathjax
python310Packages.jupyterlab-git
python310Packages.nbdime
python39Packages.jupyter-server-mathjax
python39Packages.jupyterlab-git
python39Packages.nbdime

Maintainer pings
cc @jonringer for testing.

@ofborg eval


[SPARK-17237][SQL][FOLLOWUP] Add a qualifier in pretty expressions

What changes were proposed in this pull request?
This pr added a qualifier for column names in pivot aggregations. #16565 wrongly droped a qualifier for aggregated column names (then, it changed the existing behaviour).
// Spark-v2.1
scala> Seq((1, 2)).toDF("id", "v1").createOrReplaceTempView("s")
scala> Seq((1, 2)).toDF("id", "v2").createOrReplaceTempView("t")
scala> val df1 = sql("SELECT * FROM s")
scala> val df2 = sql("SELECT * FROM t")
scala> df1.join(df2, "id" :: Nil).groupBy("id").pivot("id").max("v1", "v2").show
+---+-------------+-------------+
| id|1_max(s.`v1`)|1_max(t.`v2`)|
+---+-------------+-------------+
|  1|            2|            2|
+---+-------------+-------------+

// Master
scala> df1.join(df2, "id" :: Nil).groupBy("id").pivot("id").max("v1", "v2").show
+---+---------+---------+
| id|1_max(v1)|1_max(v2)|
+---+---------+---------+
|  1|        2|        2|
+---+---------+---------+

// Master with this pr
scala> df1.join(df2, "id" :: Nil).groupBy("id").pivot("id").max("v1", "v2").show
+---+-----------+-----------+
| id|1_max(s.v1)|1_max(t.v2)|
+---+-----------+-----------+
|  1|          2|          2|
+---+-----------+-----------+

How was this patch tested?
Added tests in DataFramePivotSuite.

Test build #78051 has started for PR 18302 at commit dbe793d.

Test build #78051 has finished for PR 18302 at commit dbe793d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78051/
Test FAILed.

Test build #78074 has started for PR 18302 at commit a6aacd0.

Test build #78074 has finished for PR 18302 at commit a6aacd0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78074/
Test FAILed.

Merged build finished. Test FAILed.

Test build #78099 has started for PR 18302 at commit b423e6f.

Test build #78099 has finished for PR 18302 at commit b423e6f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78099/
Test FAILed.

Test build #78100 has started for PR 18302 at commit a8728f6.

Test build #78100 has finished for PR 18302 at commit a8728f6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78100/
Test FAILed.

Test build #78101 has started for PR 18302 at commit d5e0eab.

Test build #78101 has finished for PR 18302 at commit d5e0eab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78101/
Test FAILed.

Since this pr changed the existing behaviour, I'll close this for now.


pywal not working in debian

Installed pywal using pip3 install pywal, so now im trying to use the command wal -i [PICTURE] but i keep getting this: bash: wal: command not found, did i do something wrong or is debian not supported?

I am encountering this same issue in Kubuntu 18.04

Encountering this issue with macOS


Composer is focused while RHN is open, when user opens RHN before page finishes loading

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to sing in page
Apply slow 3G throttling in dev tools
Enter email > Enter Magic code > click on ‘Sign in button
Click on ‘Avatar’ icon before page finishes loading and before focus is applied to composer
Verify that RHN is opened before page finishes loading
Wait for the page to finish loading
Observe that focus is applied to the composer while RHN remains opened
Start typing on keyboard while RHN is opened
Observe that keys are entered to composer while RHN is opened

Expected Result:
Focus shouldn’t be applied to composer while RHN is open
Actual Result:
Focus is applied to composer while RHN is open, user can type message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235268182-111e1ae9-6062-4ed6-ace7-e768347fedf2.mp4
https://user-images.githubusercontent.com/43996225/235268188-359c7b91-102d-4011-a3da-532838f0d96c.mp4
Expensify/Expensify Issue URL:
Issue reported by: @natnael-guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682591950639359
View all open jobs on GitHub

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Heading OOO for a couple of days, need to reassign!

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Not overdue, @kadiealexander just got assigned this. Thanks for taking over this one :)

I can't reproduce as I don't know how to enable the throttling in step 1. @kavimuru or @natnael-guchima could either of you please include this in the reproduction steps?

I can't reproduce as I don't know how to enable the throttling in step 1. @kavimuru or @natnael-guchima could either of you please include this in the reproduction steps?

I will post steps and video recording on how to enable throttling in a minute.

Primo testing steps, thanks @Natnael-Guchima!! I was able to reproduce:
https://user-images.githubusercontent.com/59587260/235843662-7ee80872-1cef-4da1-a99e-4faf3153c507.mp4

Job added to Upwork: https://www.upwork.com/jobs/~019f805dd0d74f5fd4

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Primo testing steps, thanks @Natnael-Guchima!! I was able to reproduce:
https://user-images.githubusercontent.com/59587260/235843662-7ee80872-1cef-4da1-a99e-4faf3153c507.mp4

You are welcome @kadiealexander🙌.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Composer is focused while RHN is open when RHN is opened after login and before page finishes loading
What is the root cause of that problem?
There's already logic to prevent composer auto-focus when modal is open:
https://github.com/Expensify/App/blob/200ca8591b8c342718f1a7ab3ff4296270783f42/src/pages/home/report/ReportActionCompose.js#L905
But issue happens because this.props.modal.isVisible is set to false.
Then why is this set to false which expects true when RHN is open?
After login, some modals are unmounted and this happens after RHN modal page is open.
So at first, this line is called when open RHN modal, and then this line is called when unmount modals.
Finally, modal.isVisible is set to false and saved in Onyx.
What changes do you think we should make in order to solve the problem?
2 solutions:

don't set modal visibility to false when invisible modal is unmounted. Because this is global value and there's possibility of another modal visible before this modal is hidden
add one more condition to autofocus prop value - && !this.props.isFocused

I prefer Solution 1 because the correct value of modal visibility is saved to Onyx

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

I've verified that @situchan's solution does in fact take care of the problem, but I'm having difficulty wrapping my head around why it fixes it. callHideCallback isn't the most descriptive parameter name. 😅

@parasharrajat any updates on this one?

https://github.com/Expensify/App/blob/d60f21ca5f7000c6e1a51661269330d82eccafaa/src/components/Modal/BaseModal.js#L61
After my solution, callHideCallback param name is confusing.
The idea is that we prevent Modal.setModalVisibility(false); call on componentWillUnmount if modal is already invisible (this.props.isVisible = false)
We pass this.props.isVisible to this.hideModal but the param name is callHideCallback which is confusing.
https://github.com/Expensify/App/blob/d60f21ca5f7000c6e1a51661269330d82eccafaa/src/components/Modal/BaseModal.js#L62-L64

add more condition here: && callHideCallback

So actually this means && this.props.isVisible

Does @situchan's update satisfy your concerns @parasharrajat?

@parasharrajat bump?

Bumped @parasharrajat here.

@situchan would you like to make another proposal based on Rajat's suggestion above?

Bump @situchan

Good call Rajat! Sorry, was OOO.

Sorry for that confusion team. As per this comment, the issue is now internal. The price isn't a factor, we just need to get it fixed ourselves!

@parasharrajat you can review #19744 which applied my solution.

When the parent component is unmounted, it would simultaneously trigger the unmounting of its child components

@kidroca this is true of course but here "unmount" what @parasharrajat meant is stop condition render.
i.e. isVisible && <Component />
When isVisible is set to false from true, componentWillUnmount (useEffect(() =>{}, []) return callback in functional component) will never be executed.

When the parent component is unmounted, it would simultaneously trigger the unmounting of its child components

@kidroca this is true of course but here "unmount" what @parasharrajat meant is stop condition render.
i.e. isVisible && <Component /> When isVisible is set to false from true, componentWillUnmount (useEffect(() =>{}, []) return callback in functional component) will never be executed.

Actually, the situation you described is precisely when componentWillUnmount or the cleanup function from useEffect in a functional component will be executed. According to the React docs:

"Effects may also optionally specify how to "clean up" after them by returning a function. This is not a requirement (you don’t need to return a function if you don’t need to clean up anything), but it’s an important mechanism for resources that should be released before the component exits. When you return a function in the effect, React will run it when it is time to clean up:" source

So, in your scenario, when isVisible switches from true to false, causing the component to conditionally unrender, the cleanup function will indeed be invoked.
Conditional rendering is not exempt from cleanup, if you think about it pretty much everything in an app is conditional rendering

@kadiealexander @deetergp @parasharrajat Hi! I'm Agata from Callstack - expert agency - and I would like to help you to close this issue 🙂 I've just reviewed the discussion and reproduced the bug, I'll keep you updated if I have any new findings.

Thank you @koko57!

Ok, I checked the explanation above but I am not sure if that is the best approach. Imagine there is only one Modal visible and now instead of hiding this we unmount the parent component. Now the setModalVisibility will not be set to false.

When the parent component is unmounted, it would simultaneously trigger the unmounting of its child components, including the Modal in this context. If the Modal is visible at this time, the setModalVisibility would indeed update to false, aligning with the desired outcome.

@kidroca is right - when the parent component is unmounted (because a condition changes) or its visibility is changed via props the child component's componentWillUnmount will still be triggered - just like here. So even in the case that @parasharrajat mentioned, the change will still be handled properly by the @situchan solution, as componentWillUnmount will work here as expected - if the modal is visible the Onyx will be updated (isVisible set to false). Otherwise (like in this case) the update will be skipped - the composer will not be focused.
So for this issue - @situchan solution is a sufficient, working solution.

But I still think that managing the modals state should be improved. There are some scenarios in which there's some inconsistency between the Onyx and what is on the screen - like here:

we open RHN -> isVisible is set to true

navigate to profile, click avatar to edit the photo -> the Popover is shown, isVisible is still true

close the Popover -> isVisible is set to false (but RHN is opened so it should be set to true)

This particular scenario doesn't cause any issue now, but in the future, when maybe new other components will be added, a similar one may cause some problems.
Maybe instead of setting isVisible to boolean we could store the names of the opened modals in the array and check if it's empty or not? I didn't tested this solution yet, I can try to work on this on Monday.
But if you're good with @situchan solution for now, I think it's okay to go with it. 🙂

@koko57,
I find your observations align with my own and I like your idea. I'd also like to draw attention to the fact that we might need to revisit how the onClose callback is captured when modals are mounted.
https://github.com/Expensify/App/blob/0813e2ca1476635a8324cbd9f998424663a33128/src/components/Modal/BaseModal.js#L40-L41
Currently, I'm unsure about the exact functionality of this mechanism, but it seems to capture the onClose of the most recently mounted Modal, it seems the reason is to avoid other views to close the modal, but it would be more accurate to capture the callback when the Modal actually becomes visible.
I implemented @situchan's proposal unknowing of the current issue. They stumbled upon my PR and commented and that's how I found the current ticket.
If this solution also addresses the issue at hand, I propose we merge this fix and open a new ticket for additional modal refactoring. What are your thoughts on this plan of action?

If this solution also addresses the issue at hand, I propose we merge this fix and open a new ticket for additional modal refactoring. What are your thoughts on this plan of action?

Sounds like a plan to me.
Still waiting for @parasharrajat's feedback who made me raise this discussion.

If this solution also addresses the issue at hand, I propose we merge this fix and open a new ticket for additional modal refactoring. What are your thoughts on this plan of action?

@kidroca Totally agree 🙂

@parasharrajat are you recommending to hire @situchan here?

Ah, thank you!

Not overdue.

@parasharrajat the PR you mentioned has passed the regression period, does anything else need to happen here to close this out?

@kadiealexander ~Please pay the reporting bonus and close this.~ Ok, reporting bonus was already paid on another issue https://github.com/Expensify/App/issues/18150#issuecomment-1584406195.
No action left. Please close it.

Yes, I am already paid on the other issue on the basis of having similar root cause. Thanks.


typedefs: intermediate nodes are always required

In our generated typedefs, any inferred intermdiate nodes (generated at L293 and L302) will always be marked as non-optional. But, in reality, there are many scenarios in which intermediate nodes are actually optional.
Since these nodes are inferred, there probably isn't a great solution available other than making them not be inferred. This would require that the obs-websocket docs explicitly list every intermediate node in a path, and whether it is required or not.
We could add a heuristic that checks if an intermediate node is required, but any heuristic we add will be flawed. For instance, we might say that if every child of an intermediate node is optional, then the node itself is optional too. But, the inverse is not always true: just because a child of an intermediate node is required does not necessarily mean that the intermediate node itself is required -- it may just mean that if this intermediate node is present, certain children must also be present, but omitting the intermediate node entirely might be allowable by the protocol.
I'll need to loop @Palakis into this discussion, and see what he thinks about making the obs-websocket protocol spec explicitly define intermediate nodes and whether or not they are optional.

@Lange sorry, brain's a bit foggy currently. Could you please provide an example?

Sure, no problem:
The generated typedefs for SetSceneItemProperties include the following implcit intermediate nodes:

position
scale
crop
bounds

These nodes are implicit because the nodes themselves aren't listed as fields of the request -- only the leaves (i.e, the children of these nodes) are listed as fields of the request.
This means that the automatic typedef generation script has to discover these implied intermediate nodes and add them to the typedef. However, it has to just guess if these 4 intermediate nodes are optional or not. To be safe, the script currently always lists these intermediate nodes as being required, but that often isn't the case. So what ends up happening is that my invocations of SetSceneItemProperties look like this:
compositingOBS.send('SetSceneItemProperties', {
	'scene-name': scene.name,
	item: source.name,
	visible: true,

	// We have to include these objects to satisfy the typedef, even if they are empty.
	// See: https://github.com/haganbmj/obs-websocket-js/issues/158
	bounds: {},
	scale: {},
	crop: {},
	position: {},
});

I think the best way to fix this would be for the protocol definition in obs-websocket to explicitly list these intermediate nodes, and whether or not they are required. Then, there would be no ambiguity for the typedef generator to have to make potentially incorrect decisions about.

I am currently running into this issue as well. My current fix is to edit node_modules/obs-websocket-js/types/index.d.ts, but obviously that's non-ideal


Fix issue 3

Closes #3 by removing all of the Now UI kit files and reworks the navigation bar to use vanilla Bootstrap. This was less work than I had imagined, as the UI kit was built on top of Bootstrap to begin with. The biggest change is the navigation bar color is now blue instead of orange. This is adjustable once we get some branding...
Tons of deletions of supporting files for the UI kit. It was way too bulky for what I wanted to do originally. Live and learn. Major changes were simplifying the style.css to make everything work and minor tweaks to navbar html.
I also deleted some older files that were related to the SC Codes project and deployment that are no longer needed.

Think thing should be live now. Good work.
You should come to OpenWorks tomorrow at 4:30 and drink a beer.
https://hackgreenville.com/orgs


Fixed ResizableTriggerIcon theme token usage in styles

Closes #917
Description
Replaced the token used for ResizableTriggerIcon with the actual value.
Is this a breaking change (Yes/No):
No

@108yen
Thank you very much!
We have fixed it and confirmed that the lint is running correctly, please check again.

nice!


Upgrade ubuntu from 20.04 to 24.04 LTS version

Moving container images from using Ubuntu 20.04 to Ubuntu 24.04, this is to reduce amount of vulnerabilities reported with 20.04 version, effectively  from this
    i New version 1.13.0 available (installed version is 1.11.0) at https://github.com/docker/scout-cli
          ✓ SBOM of image already cached, 218 packages indexed

  Target               │  hyperledger/fabric-peer:latest  │    1C     1H     1M    10L
    digest             │  260a5496cc95                    │
  Base image           │  ubuntu:20.04                    │    0C     0H     1M    10L
  Refreshed base image │  ubuntu:20.04                    │    0C     0H     1M    10L
                       │                                  │
  Updated base image   │  ubuntu:24.04                    │    0C     0H     1M     3L
                       │                                  │                         -7

to this
    i New version 1.13.0 available (installed version is 1.11.0) at https://github.com/docker/scout-cli
          ✓ SBOM of image already cached, 213 packages indexed

    i Base image was auto-detected. To get more accurate results, build images with max-mode provenance attestations.
      Review docs.docker.com ↗ for more information.

  Target             │  hyperledger/fabric-peer:latest  │    0C     0H     1M     3L
    digest           │  bd06340d98f4                    │
  Base image         │  ubuntu:24.04                    │    0C     0H     1M     3L
  Updated base image │  ubuntu:24.10                    │    0C     0H     0M     0L
                     │                                  │                  -1     -3

--- FAIL: TestBlockPullerBadBlocks (10.17s)
    --- FAIL: TestBlockPullerBadBlocks/wrong_number (10.02s)
        deliver_test.go:1193: PullBlock did not complete within time
2024-08-27 19:43:17.184 UTC 133f INFO [grpc] Infof -> [transport] [client-transport 0xc00021e248] Closing: connection error: desc = "error reading from server: EOF"

doesn't seem related to my change, re-running UT job again.

Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images. How do you feel about using 22.04 for a more incremental step up?
Not an issue for fabric, but for fabric-ca since it uses CGO updating to a version later than the ultimate server runs causes issues. For this reason I like to keep fabric-ca a little more behind. But I'd be comfortable with 22.04 across all the repositories.

I am just fine to use 22.04 also, just feeling more secure to going with the most recent LTS. But I am ok, let's start with 22.04 and then plan switching to 24.04 later on.

@denyeart, per your suggestion, changed to 22.04.

Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?

I've done a separate PR - https://github.com/hyperledger/fabric/pull/4986

Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?

yeap

@C0rWin I can also move -latest to 24.04, let me know

Talked to Ry, we're just going to use fabric-ubuntu-22.04 for the time being.

In the Makefile 22.04 is correct, merged.


Revert "improvement: 节点样式、交互、接口错误处理优化"

Reverts TencentBlueKing/bk-itsm#568

Codecov Report

Merging #574 (1264e03) into feature/new_workflow_ui (d95be9e) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           feature/new_workflow_ui     #574   +/-   ##
========================================================
  Coverage                    62.29%   62.29%
========================================================
  Files                          442      442
  Lines                        27429    27429
========================================================
  Hits                         17088    17088
  Misses                       10341    10341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95be9e...1264e03. Read the comment docs.


Encoding GB2312 is not available on Windows.

Issue Title
Encoding GB2312 is not available on Windows.
General
If we try to use HttpClient.GetString for a GB2312 response, it throws exception.
Actually GB2312 encoding is quite important for Chinese developers.
Please consider to fix it.

@stdcppdev
This is quite known problem in .NET Core because Some codepages needs to be registered.
It's quite easy to fix.
If you are using .NET Core 2.0, in your app entry point (such as main), use this:
System.Text.Encoding.RegisterProvider(new CodePagesEncodingProvider())

@eriawan
Yes, it works. Thanks!
Close for resolved.


Fix duplicated logs when running a pipeline

Description
1. Bug description
When we try to run a pipeline, for example make run pipeline=training, we noticed that there are duplicated lines of log showing up

2. Root cause analysis
In google.cloud/aiplatform modules:
base.py: lib/python3.7/site-packages/google/cloud/aiplatform/base.py
class Logger:
    ...
        self._logger.setLevel(logging.INFO)

pipeline_jobs.py: lib/python3.7/site-packages/google/cloud/aiplatform/pipeline_jobs.py
#line 48
_LOGGER = base.Logger(__name__)

#line 430
_LOGGER.info("View Pipeline Job:\n%s" % self._dashboard_uri())

In pipelines modules:
main.py: pipelines/trigger/main.py
#line 194
logging.basicConfig(level=logging.DEBUG)

When a base function has already set the logging level to logging.INFO and a child function calls logging.basicConfig(level=logging.DEBUG), it causes duplicated log entries with both INFO and DEBUG levels. This is because basicConfig configures the root logger, so the child function's call to basicConfig will not affect the already-configured logger in the base function. As a result, any log entries generated in the base function with INFO level will still be logged even if the child function has set the level to DEBUG.
To avoid this issue, it is recommended to configure logging only once at the start of the program and avoid calling basicConfig in child functions. This ensures that all loggers share the same configurations and prevent duplicated logs with different levels. In addition, it is important to choose an appropriate logging level for each module or function to ensure that the logs are relevant and not too verbose.
In order to set the logging level to DEBUG in the child function (sandbox_run) without causing duplicated logs with INFO level from the base function, we can create a logger instance in the child function and set its logging level to DEBUG. For example:
import logging

def sandbox_run(args: List[str] = None) -> aiplatform.PipelineJob:

    logger = logging.getLogger(__name__)
    logger.setLevel(logging.DEBUG)
    logger.debug('This is a debug message')

How has this been tested?

make test-all-components

make run pipeline=training
Logs are no longer duplicated

make run pipeline=prediction

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have successfully run the E2E tests, and have included the links to the pipeline runs below
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have updated any relevant documentation to reflect my changes
[ ] I have assigned a reviewer and messaged them

Pipeline run links:

/gcbrun


Jobs with string names faile

Environment

Kitto version: 0.5.1
Elixir / Hex version (mix hex.info):

mix hex.info
Hex:    0.15.0
Elixir: 1.4.0
OTP:    19.2.3

Built with: Elixir 1.3.4 and OTP <IP_ADDRESS>

Node / NPM version (node -v) (npm -v):

> node -v; and npm -v
v7.7.1
4.1.2

Operating system:

> uname -a
Darwin Compe.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64

Current behavior
If naming a job with a string, the job runner will crash. Example:
job "my_test_job", {5, :minutes} do
  text = ["Hello World!", "Hi Kitto!", "Elixir is the best!"] |> Enum.random()

  broadcast! text
end

Expected behavior
The job should fail when compiling (instead of at runtime) or automatically convert the name of the job to an atom.

When I say "fail when compiling", what I really mean is it should fail validation from the workspace.


Better strategy to updates sites m2m

[Current coverage][cc-pull] is 93.02%

Merging [#269][cc-pull] into [develop][cc-base-branch] will not change coverage

@@            develop       #269   diff @@
==========================================
  Files            19         19
  Lines          1217       1217
  Methods           0          0
  Messages          0          0
  Branches        148        148
==========================================
  Hits           1132       1132
  Misses           39         39
  Partials         46         46

Powered by Codecov. Last updated by [c5668bf...ea66bd3][cc-compare]
[cc-base-branch]: https://codecov.io/gh/nephila/djangocms-blog/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/nephila/djangocms-blog/compare/c5668bf943d60931bc592981dccf75a0bf0b03b0...ea66bd3481ba3038fa87770d81e42f7c621d988f
[cc-pull]: https://codecov.io/gh/nephila/djangocms-blog/pull/269?src=pr

Coverage remained the same at 96.795% when pulling ea66bd3481ba3038fa87770d81e42f7c621d988f on feature/sites into c5668bf943d60931bc592981dccf75a0bf0b03b0 on develop.


False verification failures since version 0.28.0

I tried this code:

static START1: usize = 0;
static END1: usize = 2;
static START2: usize = 2;
static END2: usize = 4;

pub struct Test<B: AsRef<[u8]>> {
    buffer: B,
}

impl<B: AsRef<[u8]>> Test<B> {
    fn new(buffer: B) -> Result<Self, ()> {
        if buffer.as_ref().len() < 28 {
            return Err(());
        }
        Ok(Self { buffer })
    }

    fn get1(&self) -> u16 {
        u16::from_be_bytes(self.buffer.as_ref()[START1..END1].try_into().unwrap())
    }

    fn get2(&self) -> u16 {
        u16::from_be_bytes(self.buffer.as_ref()[START2..END2].try_into().unwrap())
    }
}

#[cfg(kani)]
mod verification {
    use super::*;

    #[kani::proof]
    pub fn get_proof() {
        let mut slice: kani::slice::AnySlice<u8, 100> = kani::slice::any_slice();
        if let Ok(to_test) = Test::new(slice.get_slice()) {
            to_test.get1();
            to_test.get2();
        }
    }
}

using the following command line invocation:
cargo kani

with Kani version:  0.28.0
I expected to see this happen:
Successful verification.
Instead, this happened:
Kani reports failed verification with the following error:
SUMMARY:
 ** 1 of 160 failed (1 unreachable)
Failed Checks: This is a placeholder message; Kani doesn't support message formatted at runtime
 File: "/github/home/.rustup/toolchains/nightly-2023-04-16-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs", line 1687, in core::result::unwrap_failed

VERIFICATION:- FAILED
Verification Time: 0.652294s

This started happened after updating to version 0.28.0 and when switching back to 0.27.0 everything succeeds as expected.
If the statics in the code get replaced with actual values, the verification succeeds with version 0.28.0.
The verification also succeeds if only one of the get functions is used in the proof.
I could only reproduce the one error in a small example. In my actual code, I get four new errors, none of them appear with 0.27.0:
SUMMARY:
 ** 4 of 381 failed (4 unreachable)
Failed Checks: attempt to add with overflow
 File: "/home/arctic-alpaca/git/[redacted].rs", line 19, in [redacted]
Failed Checks: This is a placeholder message; Kani doesn't support message formatted at runtime
 File: "/github/home/.rustup/toolchains/nightly-2023-04-16-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs", line 78, in core::slice::index::slice_end_index_len_fail_rt
Failed Checks: This is a placeholder message; Kani doesn't support message formatted at runtime
 File: "/github/home/.rustup/toolchains/nightly-2023-04-16-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs", line 120, in core::slice::index::slice_end_index_overflow_fail
Failed Checks: This is a placeholder message; Kani doesn't support message formatted at runtime
 File: "/github/home/.rustup/toolchains/nightly-2023-04-16-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs", line 1687, in core::result::unwrap_failed

VERIFICATION:- FAILED
Verification Time: 24.684526s

If the actual code is needed, I can clean it up and share it in a repo.
In both the repro code as well as the actual code, I get this warning:
warning: Found the following unsupported constructs:
             - caller_location (1)
             - foreign function (1)

         Verification will fail if one or more of these constructs is reachable.
         See https://model-checking.github.io/kani/rust-feature-support.html for more details.

I don't think these constructs are used in my code and I'm fairly certain,they are not used in the repro code.

@celinval could reachability be pruning the statics?

@arctic-alpaca Thanks for reporting the issue. We will look into it.

@celinval could reachability be pruning the statics?

Seems this is the case because for this definition of get1:

    fn get1(&self) -> u16 {
        u16::from_be_bytes(self.buffer.as_ref()[0..END1].try_into().unwrap())
    }

END1 is not assigned in the output of --gen-c:
$ grep END1 *.demangled.c
// END1
unsigned long int END1;
  var_11 = byte_extract_little_endian((unsigned long int *)((unsigned char *)&END1 + 0), 0, unsigned long int *);

I'll take a look at it. We haven't really changed the reachability algorithm last release. 🤔

Posting a minimal example that @celinval and I arrived at:
static A: usize = 0;
static B: usize = 1;
static C: usize = 1;

#[kani::proof]
pub fn get_proof() {
    assert!(A < B);
    let _a = C;
}

The assertion incorrectly fails:
$ kani test.rs --no-assertion-reach-checks --no-default-checks
Checking harness get_proof...
CBMC 5.83.0 (cbmc-5.83.0)
CBMC version 5.83.0 (cbmc-5.83.0) 64-bit x86_64 linux
Reading GOTO program from file /home/ubuntu/examples/iss2455/test__RNvCs2FDnRyjezqh_4test9get_proof.for-get_proof.out
Generating GOTO Program
Adding CPROVER library (x86_64)
Removal of function pointers and virtual functions
Generic Property Instrumentation
Running with 16 object bits, 48 offset bits (user-specified)
Starting Bounded Model Checking
Runtime Symex: 0.00347459s
size of program expression: 196 steps
slicing removed 126 assignments
Generated 1 VCC(s), 1 remaining after simplification
Runtime Postprocess Equation: 2.655e-05s
Passing problem to propositional reduction
converting SSA
Runtime Convert SSA: 7.8052e-05s
Running propositional reduction
Post-processing
Runtime Post-process: 7.72e-06s
Solving with MiniSAT 2.2.1 with simplifier
0 variables, 0 clauses
SAT checker: instance is SATISFIABLE
Runtime Solver: 3.5761e-05s
Runtime decision procedure: 0.000149183s

RESULTS:
Check 1: get_proof.assertion.1
         - Status: FAILURE
         - Description: "assertion failed: A < B"
         - Location: test.rs:7:5 in function get_proof

SUMMARY:
 ** 1 of 1 failed
Failed Checks: assertion failed: A < B
 File: "/home/ubuntu/examples/iss2455/test.rs", line 7, in get_proof

VERIFICATION:- FAILED
Verification Time: 0.01527433s

The following test is enough:
static END1: usize = 2;
static START2: usize = 2;

#[kani::proof]
pub fn get_proof() {
    assert!(START2 == END1);
}

It looks like the problem is how we allocate and initialize static variables. We rely on the allocation hash, but that seems to be the same now for END1 and START2 since they have the same value. Probably due to the toolchain upgrade?
@zhassan-aws thanks for helping me narrow this down and noticing that the values had to be the same.
This logic probably works well for constants embedded in the code, but not for static variables where we rely on the symbol. We need to fix this ASAP!

BTW, this used to work before because the rust compiler used to propagate the constant, but this is no longer the case.


Preview of image with filter not showed

Version of Pixel: 0.0.9
Xcode: 11.0 beta 6
iOS: 13 beta
As in attached screenshoot there is an issue with previewing images with filters on newest iOS 13 beta.

Thank you.
I’ve also found that issue. And then that has been fixed as temporally.
https://github.com/muukii/Pixel/pull/32
Could you check that behavior on this branch?

Hi Muukii, I am facing the same issue on iOS 13, I just wanted to check when will these changes be merged to master?

I'm sorry.
Actually, we can merge this.
I'll do this.

Issue has been fixed in latest version


Added new project

Added my ray tracer that I completed as part of the Computer Graphics course to PROJECTS.md. It's not a huge project, but there aren't many projects currently and I think the program makes pretty images, so I hope that it is interesting for other students.

@MartinOvington my impression is that the Ray Tracer is one of the official projects of the Computer Graphics course and that as such sharing the code used to complete the project violates the course's Code of Conduct. Feel free to show that this is not the case. Closing this PR until that time.

@waciumawanjohi I've checked the Code of Conduct and you're right, so I've taken down the public repo. I'll have a look at it to see if it can be modified to not have the code and still be worthwhile.


Configure automatically generated release notes

This issue is of pretty low importance, but we could generate more stratified release notes if we wanted to according to the PR labels.
By configuring some YAML file somewhere in the repository, we could say that, for example, everything with the area:llvm label is then in a special "LLVM" section. This could then help to produce easy-to-skim release notes.
See docs for more details: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuring-automatically-generated-release-notes
Testing this is a bit cumbersome, probably easier by making a fork of the repo and letting the autorelease.yml action run every day / running it manually.
Follow-up from #538.

Yes, this is very low prio, even though it sounds cute.


No '_ctx' column, also please add the 'region_name' support in openstack.spc

Hi, thanks for the new openstack plugin, now I'm using/testing it:

can we add the support for 'region_name' in the openstack.spc? If users have multiple regions, so we can add mulitple connections for multiple regions, instead using environment variables, I need to export the OS_REGION_NAME every time on the CLI.
I don't see the '_ctx' column in the tables, can it be added to all tables? it's useful when i need to know the region by using the _ctx column.
thanks you!

Fixed in 11183caaafdee464093108551c50351dd84a5e2e. @zhujian0805 if you have any further feature or table requests, please let me know by opening an issue.

Released with v0.0.3.


Bug fix for _sortNewestFirst

The comparator function _sortNewestFirst returns incorrect values, so that when used for sorting in getLatest, it result in incorrectly returned image.

Sheesh, this was pretty wrong! Thanks!

Looks great, thank you for catching all of these bugs. Would you mind adding semicolons to match the style of the file? I'm happy to do this later as well.

Done. Would it be possible to bump the version on this and update https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/packages/compute/package.json#L58? It's hard to get around this bug in production code without hacks.

Yes, mobile now, but I will try to get a new Compute release out before the next couple of hours.

Thank you for all the quick feedback!

Finally got a connection. Working on this now :)

@josephui published under v0.3.1, so un- and re-installing @google-cloud/compute will pick up the fix. Thanks again for catching this and fixing it. Very much appreciated :)


Typo and spaghetti code fixes

Went in initially to fix an important typo, and realized there was some spaghetti/verbose code that should be fixed too, some of it was even making your call stack unnecessarily larger!! :)
I couldn't quite figure out your NAPI build/test tooling (seems you've deviated from the crate's defaults) so I left that alone, but I've been checking with cargo build to make sure the Rust compiles, and it does!

Closing this PR to open a cleaner one


Waiting for ssh login on <IP_ADDRESS> with user root to sshd on port => 7222

I launch the following command
veewee vbox box arch64 --force

And every goes smooth but after the execution of ssh.sh it launches reboot.sh
and then i get the mesage of the issue i tried to connect ssh manually to VM but i cant
last dump of the log....
Executing command: ./ssh.sh
sh-4.3# pacman -S --noconfirm openssh
resolving dependencies...
looking for inter-conflicts...

Packages (4): dnssec-anchors-20130320-1  ldns-1.6.17-1  libedit-20140213_3.1-1
              openssh-6.6p1-1

Total Download Size:    1.18 MiB
Total Installed Size:   6.08 MiB

:: Proceed with installation? [Y/n]
:: Retrieving packages ...
 libedit-20140213_3....    90.6 KiB   281K/s 00:00 [######################] 100%
 dnssec-anchors-2013...   980.0   B  0.00B/s 00:00 [######################] 100%
 ldns-1.6.17-1-x86_64     427.8 KiB   450K/s 00:01 [######################] 100%
 openssh-6.6p1-1-x86_64   693.0 KiB   476K/s 00:01 [######################] 100%
(4/4) checking keys in keyring                     [######################] 100%
(4/4) checking package integrity                   [######################] 100%
(4/4) loading package files                        [######################] 100%
(4/4) checking for file conflicts                  [######################] 100%
(4/4) checking available disk space                [######################] 100%
(1/4) installing libedit                           [######################] 100%
(2/4) installing dnssec-anchors                    [######################] 100%
(3/4) installing ldns                              [######################] 100%
Optional dependencies for ldns
    libpcap: ldns-dpa tool
(4/4) installing openssh                           [######################] 100%
Optional dependencies for openssh
    xorg-xauth: X11 forwarding
    x11-ssh-askpass: input passphrase in X
sh-4.3#
sh-4.3# # Make sure SSH is allowed
sh-4.3# echo "sshd:ALL" > /etc/hosts.allow
sh-4.3#
sh-4.3# # And everything else isn't
sh-4.3# echo "ALL:ALL" > /etc/hosts.deny
sh-4.3#
sh-4.3# # Make sure sshd starts on boot
sh-4.3# systemctl enable sshd.service
ln -s '/usr/lib/systemd/system/sshd.service' '/etc/systemd/system/multi-user.target.wants/sshd.service'
sh-4.3# exit
Waiting for ssh login on <IP_ADDRESS> with user root to sshd on port => 7222 to work, timeout=10000 sec
.
Executing command: ./reboot.sh
Received a disconnect; moving on

Waiting for ssh login on <IP_ADDRESS> with user root to sshd on port => 7222 to work, timeout=10000 sec
...................................................

At this point im unable to login through ssh to the VM
Any help to solve the issue will be much apreciated thanks.
(Sorry for my bad English :) )

closing as there was no feedback in three months, please let me know if you can provide more details and I will reopen

Am currently having a play attempting this, have run into the same issue.
Logged in using the open virtual box window and checked systemctl's services and the sshd daemon is running.

on a second attempt, i ran into the same issue and noticed that systemctl reported the sshd daemon as dead.
running systemctl restart sshd set the daemon to running, but the script still hangs waiting for login...
Ideas / useful information I can provide?

@chrisRidgers could be network configuration problem, can you check netstat -tpln on the VM?

Got exactly the same problem, same output.
I could not run netstat -tpln though. It is not installed by default and running pacman -S net-tools says the machine is not connected to the internet.
I checked the VM's network configuration and the NAT network adapter is enabled with a redirection rule for host port 7222 to guest 22.
What's weird is that there are other "Waiting for ssh login on [...]" commands that have worked before that step.

my guess is the network interface changed it's name from the installation and the configuration is on wrong name, we have seen similar thing in other systems, can you try debug it from this info?

just found this:
Chroot into the new system
arch-chroot /mnt <<ENDCHROOT
Previously dhcpcd.service was enabled. However, in my testing it repeatedly
failed to connect to the network on reboot. Enable<EMAIL_ADDRESS>has worked
in my case. My guess is that this is due to the line
After=sys-subsystem-net-devices-%i.device
in the service file.
Restarting dhcpcd.service after boot or using Network Manager instead of
dhcpcd also works
Maybe a related bug report?
https://bugs.freedesktop.org/show_bug.cgi?id=59964
Replace this with a better fix, when available.
systemctl enable<EMAIL_ADDRESS>Disable systemd's Predictable Network Interface Names
ln -s /dev/null /etc/udev/rules.d/80-net-name-slot.rules
within
https://github.com/jedi4ever/veewee/blob/master/templates/archlinux-x86_64/base.sh
To me this describes the problems we're having.  I'm currently rebuilding the box to see how far I get with this info, but if anyone can read this and identify a definite solution I'd be happy to hear it :)

the last two lines look like related to what I was thinking about:

# Disable systemd's Predictable Network Interface Names
ln -s /dev/null /etc/udev/rules.d/80-net-name-slot.rules

Right so this is looking like the cause of the problem.  As a test i logged into the VM and restarted dhcpcd.  Sure enough, the install process resumed.
ip link showed me an interface name enp0s3 (or the ilk of).  So is that ln supposed to override that behaviour and revert back to the eth0 naming scheme?  Because if so it hasn't done so.

yes it looks like it did not happen, you need to investigate why it failed, it's either not executed or moved for execution later on after ssh?

It failed because of this:
http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/
You disable the assignment of fixed names, so that the unpredictable kernel names are used again. For this, simply mask udev's rule file for the default policy: ln -s /dev/null /etc/udev/rules.d/80-net-setup-link.rules (since v209: this file was called 80-net-name-slot.rules in release v197 through v208)
symlink linked to an outdated file/ filename.
So once I updated that the build went smoothly (bar some issues with chef, but that's something else completely).
Still, even with it working its not something I feel entirely comfortable with (disabling systemd's more current naming structure...)  During the boot process I noticed that even during the initial install the network interface was set set to the new naming scheme, if it's consistent within virtual box I'll see if setting the
systemctl enable<EMAIL_ADDRESS>line can be switched to reflect it, and then drop the rule change change completely.
Thoughts?

Well I suppose the name of the predictable name can be retrieve with something like:
ip addr show label 'en*' | head -1 | cut -d' ' -f2 | sed 's/://'

The only thing is I'm not sure if matching on 'en*' is okay.

@chrisRidgers the new naming convention is desired in real servers, in our case it is reverse, we want the first interface to be always the same eth0, could you provide pull request that has both paths handled?
@ibizaman go with first @chrisRidgers solution, playing with different names is to complicated and unnecessary when we can just disable it.

I'm currently in work, I'll submit the relevant pull requests when I get home tonight,  so the agreement is the fix to the ln command is the most appropriate here?

(For knowledges sake) changing base.sh's systemctl service to
systemctl enable<EMAIL_ADDRESS>Worked for me.  The comments in base.sh reference a bug/ issue with the empty dhcpcd@ service.

@mpapis I agree with your point of view, but if we can avoid disabling it, why not?
@chipchilders In fact I posted my answer just before going to work so I didn't have time to test with something like:
systemctl enable dhcpcd\@$(ip addr show label 'en*' | head -1 | cut -d' ' -f2 | sed 's/://').service

About my comment about "is en* a good test for the label", it seems it is: http://cgit.freedesktop.org/systemd/systemd/tree/src/udev/udev-builtin-net_id.c#n29

the thing with persistent network interface names it can be a lot of things, matching en* might be not enough, but anything you can get working and create a pull request I will merge

Okay, I'll do something tonight :)

fixed with #1034


twitter bot init

Added basic twitter bot using Tweepy (https://github.com/tweepy/tweepy).  This file currently gets up to 50 mentions of the developer account, and prints them to the screen.  Future additions would include a tweet response from the developer account.
http://www.tweepy.org/

Thank you. I'm currently working on something else (a TODO app with Django), so I'll take a look at this later.


Add better example and library support

Will add library support at least on unix based systems

Fixes #8

@FlyingGraysons can you test on Windows soon?

Also, @FlyingGraysons fix the duplicate comments in your README.

How about now @truell20

@FlyingGraysons Nope. You have a duplicate backprop object in the README.


Remapping keys or shortcuts to media keys not working anymore

Microsoft PowerToys version
0.82.1
Installation method
Chocolatey
Running as admin
Yes
Area(s) with issue?
Keyboard Manager
Steps to reproduce
I had certain keys on the numeric keypad mapped to buttons to control media, but now they no longer work. Trying to reassign other keys or shortcuts also does not make the next track, previous track, play/pause mapping work.
✔ Expected Behavior
I hope they work
❌ Actual Behavior
mapping to next track, previous track, play/pause not working
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/22346


libconfig: fix static windows build

Motivation for this change
when building statically for windows, libconfig tests fail to build. This disables them in that situation.
I feel like this is a lot of tweaking for an edge case, and it seems ugly and hard to follow sprinkled throughout the derivation. Is there a canonical way to change a bunch of stuff based on one conditional all in once place? I can imagine using something like
(stdenv.mkDerivation rec {
  ...
}).overrideAttrs (old:
lib.optionalAttrs (stdenv.hostPlatform.isWindows && stdenv.hostPlatform.isStatic) {
  doCheck = false;
  ...
}

But I've never seen such a thing in a derivation before, so I don't know.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120973 at a204e5fe run on aarch64-linux 1

4 packages marked as broken and skipped:

giada
pulseeffects-legacy
pulseeffects-pw
sonic-pi

4 packages skipped due to time constraints:

audiality2
koboredux
koboredux-free
lsp-plugins

45 packages built successfully:

ahoviewer
aj-snapshot
carla
clight
faust2jack
faust2jaqt
ffado (libffado)
jack1
jack2
jackmix_jack1
libconfig
libguestfs
libtoxcore (libtoxcore_0_2)
libtoxcore-new
libtoxcore_0_1
odp-dpdk (linuxPackages.odp-dpdk)
littlegptracker
ltc-tools
luppp
lxqt.compton-conf
mar1d
neocomp
nntp-proxy
octavePackages.audio
picom
python38Packages.guestfs
python39Packages.guestfs
qradiolink
qtox
ratox
shairport-sync
shotcut
soundtracker
sslh
tetraproc
toxic
toxprpl
toxvpn
umurmur
utox
vagrant
webcamoid
xob
yabar
yabar-unstable

1 suggestion:

warning: unclear-gpl
lgpl3 is a deprecated license, please check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/libconfig/default.nix:34:5:
   |
34 |     license = licenses.lgpl3;
   |     ^

Usually we override an input if we want to disable a test.

I changed it to take in a doCheck argument. let me know if this isn't what you meant

This is still ready to merge I think.

@Radvendii merge conflict

Fixed. It's actually a simpler change now, since my upstream patch has been accepted, and the nixpkgs version has been bumped


Peer dep missing after update 1.11.0 - 2017-06-30

After updating reactql, eslint stopped working.
With this error: https://github.com/airbnb/javascript/issues/1454
This is why : https://github.com/airbnb/javascript/issues/1447
airbnb doesn't support eslint v4
To reproduce:
npm i -g reactql
reactql n

Just press enter to get the defaults.
cd reactql-app
and run
npm ls
this is what you'll get:
npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>|| ^2.1.0-beta || ^2.2.0-rc, required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>|| ^2 || ^2.1.0-beta || ^2.2.0-rc, required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>

@balciseri - good catch- I knew there was a reason I'd held off from bumping to Webpack v3 before now, but it seemed to be working locally. I'll revert to v2 in the next version.
I've got 'add tests' on my to-do to avoid this kinda thing in future.

In 1.12.0, I reverted to ESLint v3 which fixed npm run lint.
There are still a few peer-dependency issues due to the Webpack v3 bump, but they're just warnings; Webpack still works well, and produces smaller bundle sizes too.
I also added a Travis CI step to verify that the kit can build and passes linting.


☂ [Roadmap]: Clean Up

This is an umbrella issue to related to one of our priorities for code-server: clean up.
They're chores. Think of this as cleaning up the repository and making things easier both for maintainers and contributors.
1. Easier for Maintainers
code-server is a big project. The easier to maintain, the faster we can fix bugs, ship features and help the community.

⏳ separate unit and e2e testing #2646
⏳ improve updating vscode process

⏳ improve existing script #2787
figure out a way to pull in their changes on a regular cadence (so updating is easier)

⏳ pre-install script that checks dependencies #2807
⏳ automate release process #2817
⏳ add homebrew job to publish.yaml #2841

2. Easier for Contributors
If we want to encourage contributions from the community (and even Coder employees), we need to make it as simple as possible to contribute.

⏳ Remove shfmt as a dependency #2772

3. Remove Dead Code
We need to do an analysis to see how much unused code exists in the code-server codebase. This could slim down the size, maybe help performance but also help with maintenance long-term.

🚧 remove pages/updates.css #2823

4. Improve Security Practices
We want to make sure we're staying on top of security vulnerabilities in code-server by following best practices.
-⏳ utilize GitHub security tools #2839

LEGEND

⏳ = to do
🚧 = in progress
✅ = done

Note: this is part of an experiment to be more transparent about our priorities and our roadmap. See everything related to this effort in the project board

@jsjoeio can we mark remove pages/updates.css from :construction: -> :heavy_check_mark:

We are moving away from the umbrella issue approach and instead only using the Project Board. Things that are not yet issues are cards. Once they are to be worked on, they will be converted to issues.
See items under "To do" in Roadmap: https://github.com/cdr/code-server/projects/4


redirect can't execute in beforeAction with yii 2.0.7

redirect can't return in beforeAction with Yii 2.0.7,
but it can execute do in Yii 2.0.3
All extend yii\web\Controller.
public function beforeAction($action)
    {
        return $this->redirect(['/login']);
    }

Additional info

Q
A

Yii version
2.0.7

PHP version
7.0 or 5.5

Operating system
Windows 10 x64

How to reproduce the error?

redirect   can't  redirect  at once ...
try $this->redirect('/')->send();
it will be abort the request and redirect immediately.

beforeAction  should return  a  boolean value

@crstudio

@quorzz is right

@qorzz I have tried, it is ok now.

beforeAction should return a boolean value

more specifically it should return false in this case.


Add information for when adding a secondary domain

[When adding a secondary domain for a tenant within GCC high, it is my understanding that the MX records are the same BUT you need to add it into  azure AD and verify the domain first before creating users and/or aliases under that domain. Could we include this information in the article somewhere?  ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1a8b9e7-32c2-9e42-5f9d-8824bd15ab8e
Version Independent ID: 4e4ba710-bb50-569d-34a6-8ef122d57aa6
Content: DNS records for Office 365 GCC High - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/dns-records-for-office-365-gcc-high.md
Service: o365-administration
GitHub Login: @dzazzo
Microsoft Alias: dzazzo

Discussed this offline with @SingingTech - I'm not sure this is an appropriate edit.  I agree that there's some orders of operations work that needs to happen here (you need to add the domain to the tenant before you can use it to accept email), but the process of adding and verifying the domain (with the ms= MX or TXT record) is external to this guidance and isn't part of the Office-specific DNS guidance.  I'll noodle on this some more though.
We're also working to try to get the Domains functionality reintroduced to the Office 365 Admin Center for GCC High and DOD which will deprecate these two pages altogether.

@SingingTech Thank you for the feedback.
@dzazzo-msft  I have added a reference link at the bottom which talks about adding a new domain to an existing tenant. If you think it is a suitable edit, please approve. Reference PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3650
Thanks
Sri

Ordinarily, I'd say yes, but on this one - no, this will add more confusion. Domain management is not currently available within the Office 365 Admin portals for GCC High and DOD. Hopefully will change soon, but not yet.

@dzazzo-msft Thank you for the update. I'll close the PR.
@yogkumgit This issue can be closed as there are no changes required to the document.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @SingingTech Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Post-3.5 code cleanup

(waiting for a VMU run before marking this not-draft)

Finally. https://osg-sw-submit.chtc.wisc.edu/tests/20220509-1139/packages.html


Update main with dev to keep the README up-to-date

Updated to .NET 8. Added a new executable: silk. Enums now exist -- kinda. Other related changes.


onChange event firing twice

Hello guys, I've been working with this module for a few weeks but only today I noticed my onChange handler has been called twice. I imagine it has something to do with event bubbling but  the onChange function signature does not include the event so I can run event.preventDefault(). Here is my is my code:
const Editor = ({ value, onUpdate }) => {
  const handleChange = (editor, data, val) => {
    onUpdate(val)
  }

  return (<CodeMirror
    value={value}
    onChange={handleChange}
    options={{
      mode: 'javascript',
      theme: 'lesser-dark',
      lineNumbers: true,
    }}
    autoCursor={false}
  />
  )
}

Thanks @scniro for your response, I haven't noticed your example was printing on console. That would be enough to guarantee the error is in my setup. I'll check my component structure and come back with the solution for my case or some more details if I get stuck.

@rolandgnm just keep me posted with your findings! We'll get this squared away for ya 😺

Thanks @scniro, my error was actually on my side. Assessing the example closer I found out I've chosen wrong combination for component (un/controlled) and change handler. Now it's pretty much like this, and running properly:
<Controlled
      value={value}
      onBeforeChange={handleChange}
/>


Missing bearer or basic authentication in header, param: null, eventId: null

System Info
When I was trying to use openai_realtime_dart: ^0.0.3 with following codes, it appears Connected to "wss://api.openai.com/v1/realtime" yet when trying to receive the response after submitting request, i got this error:
flutter: RealtimeEvent.error(eventId: event_AT79LFUhCzb6peAlJDhME, type: RealtimeEventType.error, error: APIError(type: invalid_request_error, code: null, message: Missing bearer or basic authentication in header, param: null, eventId: null))
Was trying to use web_socket_channel 3.0.1 with headers and it worked.
Related Components

[ ] doc-loaders
[ ] doc-transformers
[ ] prompts
[ ] llms
[ ] chat-models
[ ] output-parsers
[ ] chains
[ ] memory
[ ] stores
[ ] embeddings
[ ] retrievers
[ ] agents

Reproduction
Future<void> StreamingAI() async {
  final client = RealtimeClient(
    apiKey: Platform.environment[OPENAPIKEY],
  );

  await client.updateSession(instructions: 'You are a great, upbeat friend.');
  await client.updateSession(voice: Voice.alloy);
  await client.updateSession(
    turnDetection: null,
    inputAudioTranscription:
        const InputAudioTranscriptionConfig(model: 'whisper-1'),
  );

  client.on(RealtimeEventType.all, (e) {
    print(e);
  });

  client.on(RealtimeEventType.conversationUpdated, (e) {
    final event = e as RealtimeEventConversationUpdated;
    print(event);
    final item = event.result.item;
    final delta = event.result.delta;
  });

  await client.connect();

  await client.sendUserMessageContent(const [
    ContentPart.text(text: 'Can you tell me the temperature of New York'),
  ]);
  await client.sendUserMessageContent(const [
    ContentPart.text(text: 'Thank you and how are you doing today?'),
  ]);
}

Expected behavior
Successful websocket connection and able to receive valid response

hey @ronnnald,
Thanks for the report, I'll have a look at it soon.

Hey @ronnnald,
I've just tried your sample code, and it worked fine for me. I didn't get any authentication error.
I would double-check that your OPENAPIKEY env variable contains a valid token.
I'll close this issue for now, if you still think is a bug please feel free to provide more details.


Bug with cd command

Evertime i use "cd" command and the autocomplete feature, i got an wrong autocompletion.
Actual behaviour: (on Ubuntu 14.04)
$ cd /var
$ cd c  (will show cache and crash suggestion)
$ cd co (will suggest nothing)
$ cd colord (cd: file ou directory not found: colord)
Actual behaviour:
$ cd /var
$ cd c  (will show cache and crash suggestion)
$ cd co (will autocomplete with colord)
$ cd colord
$ pwd (/var/lib/colord)
--
This is annoying :angry:
Thanks.

Can you try running unsetopt cdablevars to see if that fixes it?

Thank you, this solve my problem.
Searching by cdablevar i found the same issue #2560.
Sorry for redundancy and thanks for your time.


Support for Path and str to an existing image in dvclive.log_image

Docs for the https://github.com/iterative/dvclive/pull/518

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

The code example has both an np array and PIL image. Can we add a path there too?


feat: Add salt-api ldap eauth tests.

A first pass at adding salt-api ldap integration tests as promised.
The osixia/openldap container comes with 2 'builtin' users: admin and readonly, and we add an ldap group called saltadmins containing the readonly user.
We then set salt-api.conf to connect to the LDAP server, and set the eauth rules to give access 'directly' to the admin user and also to members of the saltadmins group.
We then get a token and run a command via the for both users, testing both eauth rules.
I have tweaked things to try to handle the start/stop of the openldap container and cleanup neatly - but you might prefer the existing cleanup function being extended to also shut down the openldap container, if found?
I also haven't added this test to the github workflow as I wasn't sure if it should go in as it's own entry, or will be called from the existing salt-api/test.sh
Let me know what you think, and if you have any other changes you would like to see.

Wow! That was fast! Thank you very much for adding this test!
I think it is perfect, and a great documentation complement for people needing a full example of how to setup the image with an ldap db.
You can call this test directly from the salt-api section of the workflow:
- name: Execute salt-api tests
        if: always()
        run: |
          tests/salt-api/test.sh
          tests/salt-api/salt-api-ldap.sh

Currently all tests are failing because of Salt Project migration: https://saltproject.io/blog/upcoming-salt-project-docs-and-repo-migration/
I hope the migration finishes soon so we can run these tests without errors.

It was actually much easier than I expected to get working due to the container already having default baseDN, user accounts etc set up.
I've updated the tests to run ldapadd inside the Docker container, and have added them to the github workflow

Hi @mrichar1, could you rebase your branch with the latest changes in the main branch?

That's the rebase completed and the shellcheck fix added and pushed.

Thank you, @mrichar1!
Your test has passed, so I'm going to merge the PR!
I have to solve an issue with the gitfs tests, but I think it must be something related with secrets permissions.
Thank you for your contribution!


Add BRANCH_NAME env and modify default branch for effected step

Description
To solving a problem that failures when triggering the Git workflow from a different branch.

add BRANCH_NAME env
modify default branch for effected step

This PR move to https://github.com/cloudforet-io/actions/pull/43


Military Symbology should be scale dependent

From @ACueva on March 14, 2018 22:53
Summary of Issue Encountered:
As a user I should be able to zoom in to a map and have my military symbology draw based off of preset scales set for Command/Brigade/Battalion/ etc.
As a user I should be able to set the scale threshold on when each type of military symbology draws.
Current State:
This functionality is currently not possible.
Expected Results / Behavior
Scale dependent rendering of Command/Brigade/Battalion/ etc.
Version
Pro 2.2
Copied from original issue: Esri/military-features-data#303

Using the ability to showcase scale dependent layers based on echelons would be a great blog. This would showcase to our users how you can track elements from a company to a brigade.


Fixed issues #231,#217 and #227

Fixed incorrect Statusbar color and Toolbar icon colors.

Thanks


Broken width after opening component with router

If you open component with router and then open another component in Storybook, width of page becomes smaller each time you open component with router decorator

Hi @goodmind, thanks for the report. Could you please provide more details? Which version are you using? With react or vue? Do you have some snippet or an example project to help me reproducing the problem? Thanks!

@gvaldambrini it's react, but now I think its not related to this module. I removed it and have same issue. I'll make minimal reproduce though

i think this div in _innerComponent breaks my height: 100% flexbox layout

@gvaldambrini https://github.com/gvaldambrini/storybook-router/blob/715d35677ed823155c5c25c90161f24d76981d1a/src/react.js#L18

I'm not sure why the wrapping div causes the problem you mention, but as it is not really needed I removed it and pushed a bugfix version without it (0.3.2). Please check if this solves your issue and if not provide an example to reproduce the problem.


docs(example): add a real example

This is similar to the example that will be added to the Next.js repository
in examples/

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


cypress open timeout error

Running cypress for the first time:
npx cypress open

Got this error:
It looks like this is your first time using Cypress: 7.5.0

Cypress verification timed out.

Try it again:
npx cypress open

It may take a while to install the Cypress app the first time.


ERROR: python-slugify 1.2.1+ is not installed

I installed kcc via AUR (Arch Linux). If I try to start it via console I get the following error:
ERROR: python-slugify 1.2.1+ is not installed!
Does anyone know how to solve this? I already tried to install python-slugify 1.2.1 with pip, but the error is still there if I try to open the program.
Have a nice day!

Never mind, I had some issues with already having installed python-slugify with pip.