create3_teleop missing project

Hi,
The create3_teleop project is missing a reference to the ROS2 teleop_twist_keyboard project.
It would be helpful if a link of the project was added to the Readme file as well as adding it to the installations setup.
Thanks a lot,
Ariel

Hi,
the create3_teleop project is listing this dependency in its package.xml https://github.com/iRobotEducation/create3_examples/blob/galactic/create3_teleop/package.xml#L12-L13
I just tested this on a clean system and this dependency is correctly installed when running rosdep install --from-path src --ignore-src -yi as per the build instructions in the README.md

Hi,
Sorry for not adding, but I'm running ROS2 on windows, and no rosdep. For me the project didn't install.
Thanks

Sounds to me like the problem you are having is with rosdep, not with our examples. It seems like this is a known issue. I can add a note to the readme that if a user has not or cannot install rosdep, that they should install the depenedencies manually, but that should go without saying -- in general, if the steps in a project's parent README.md are not followed, it's unfair to expect children to function properly out of the box.


State bug where a piece is never moved

https://katamino.sheep.army/pentas/clam6daee0000ml082psw98qz

Nearly every part of the application that this might have applied to has been replaced. Closing.


Grid column chooser

1st pass on gridColumnChooser

Great thanks for opening this up - eager to take a look today and will do so.

Hi again - took a quick look to provide any immediate feedback I can - discussed with Lee prior and he will also take a look as soon as he has a chance as we're eager to get this in.
My first and primary thought is that we probably want the ColumnChooserModel to interact with the GridModel and use that to read / manipulate columns. The GridModel is our class to hold and process any state we want to define/load/adjust, then it gets flushed into the grid itself. That should avoid the chooser model needing to use those nested calls to locate various parts of the native ag-grid API, and also give us more options / hooks to ensure it can provide whatever data something like the chooser needs in a nicely normalized form.  Does that make sense?
Regarding the column properties, we should be to use our fileColFactory method to default and document any column props the framework expects. We have it as a (not yet documented but soon) standard that we run all column definitions through this method, even if only via baseCol() so these defaults are applied.
An example there would be to ensure headerName gets set.  That happens internally in ag-grid based on the field prop, but the resulting value isn't then in the model (and also doesn't seem to be easily accessible via the grid API).  We could default it within fileColFactory to ensure it's always set on the definition (suggest using lodash.startCase()).
Minor note - for the extended properties we are adding like excludeFromChooser, I am not sure if we should preface them with xh as we did in Sencha world to indicate "this is not something you will find in the ag-grid docs" or if we want to let them go unprefixed but document here.  We can discuss all together.
Finally re. launching from the default context menu - that's great, would probably default enableColumnChooser to true. I think we will also want another convenience button of some kind that can be linked to a given grid and show its chooser so we can place in more visible locations like a toolbar.
With that will give you / Lee a chance to review and see what you think - especially re. the models - and happy to talk more anytime.

Sorry - know I said I would leave it but also just thinking - we should think about / account for the chooser model picking up changes to the columns that it didn't make itself.  Right now I believe it gets initialized once along with the grid and then assumes its state stays in sync because it's the only thing changing columns.
If it's instead bound to the GridModel it can be reactive to the observable columns there.

re interacting with through  the GridModel. Completely agree.
fielColFactory etc. Great.
Re. the xh prefix. I think it is extraneous.  I don;t think we want to distinguish between property names that happen to match those of the underlying implementation, and those which do not. Maybe I am missing something?
Default to enabledColumnChooser: true -- sure i'll just have to be carefull that LRChooser's grids disable it :)
I see what I can do towards a pre-packaged button.

Ah good point re. the default - I think you are correct that it's likely best to require opt-in given all the contexts in which grids can be used (and all cols should always be shown, etc).  👍
Also am happy to proceed without tacking on more xh's everywhere. I think we are taking sufficient control of these APIs across the board that you kinda need to know that things might or might not map directly onto the underlying libraries.

I am not longer so sure about  default col def properties. It seems that these get send directly to the agGrid, which warns about properties it is not familiar with. This seems like a nice thing for it to do, but now it feels our model isn't align with the agGridl model.
It would be nice if we had a way on the LeftRightChooser to set the headings of the left and right sides.  Right now we have fairly generic headings, but would be nice override for specific uses cases. I also didn't see a way to change the 'No records found...' message which appears when one of the L/R pickers is empty.

Hi - worked on this a bit more to handle the custom props we want for the chooser (and other things) a bit differently so we can keep them around in the column config but avoid passing them to ag-grid.  Also shortened the name up, added a convenience button component (see new gridColumnChooser branch in toolbox) and a few other tweaks.
I think we can / should merge this so we can get it in there, look at saving state, and keep iterating as we go along.  Happy to review / discuss anything tomorrow!


[CORE] ExpandFallbackPolicy should propagate fallback reason to vanilla SparkPlan

What changes were proposed in this pull request?
This pr makes ExpandFallbackPolicy propagate fallback reason to vanilla SparkPlan. The real fallback reason should not be overwritten by ExpandFallbackPolicy's fallback reason.
How was this patch tested?
add test

cc @zhztheplayer @PHILO-HE thank you


Add tests for bool and nat primops

Starting work towards #37 . Some of the tests are probably redundant and I'm not sure if it was a good idea to put the test cases in a vector which is iterated through because the error messages no longer show the line number of the failing test. I did add some messages to the assertion that should make it at least a little easier to track these failures down. Let me know if this was a bad idea and I'll change it such that each assert_eq! call is on its own line instead.

Yeah, I wouldn't put them in a vector like this. Would prefer individual assert_eq!'s

Yeah, I wouldn't put them in a vector like this. Would prefer individual assert_eq!'s

Ah right. I've since replaced them with individual quickcheck tests instead, but I haven't updated this yet because I'm still trying to figure out how I can use the Testable trait to constrain the arguments to the tests.

I didn't add tests for u128.rs as per John telling me that it's probably going to be removed.

So I've finished implementing some tests for all the ops in the *Op enums and I think the PR is somewhat ready for review, so I've marked it as such. But there's three failing tests that I don't know how to fix. Well, one of them is caused by the fact that the TextOp::ToBytes operation is unimplemented, and I'm not sure how that should work exactly, so I didn't try to implement it. But I've no clue about what's causing the other two failures, only that they're probably related to IPLD.


feat: add edit link component

Closes #1216
Adds a link at the bottom of every page to allow editing on github.
Changelog
New

EditLink component

Changed

Increased padding-bottom of the page component to be closer to the 160px target (some of the content lacks a padding bottom and will still come up short). This handles the most common case.
Repository link

GitHub should be spelled with an uppercase G and H. Other than that change, this is amazing.

So glad you figured this one out!

[ ] Click zone stretches out too far, users could accidentally click it while thinking they wanna click Next button.

[ ] Any chance of getting "Last updated..." in there? If not let's not close the issue yet so we don't forget to update later.

@shixiedesign should be resolved now
Adding the last updated bit will require some Gatsby source magic.
I'm okay with opening a new feature request issue or modifying the current one. Whichever makes more sense to @designertyler.

Let's add the time stamp in another PR so we can get this one merged today. I'll create an issue for the time stamp.


Add validation of gradle wrapper

Add validation of grade wrapper as per https://github.com/gradle/wrapper-validation-action . This is best practice and recommended by grade team.
Affects many repositories across Egeria

All repositories using gradle should now be validating the wrapper


Notebook cell not found during render after openWith

VSCode Version: 1.53.0-insider
OS Version: Win10

(Ported from dotnet/interactive#961)
Steps to Reproduce:

Download the file https://github.com/EverybodyKurts/corrupted-dotnet-interactive-notebook/blob/main/clean-code-with-ces.ipynb locally.
Install the .NET Interactive notebook extension.
Ctrl+Shift+P to execute the command ".NET Interactive: Open notebook" and open the file downloaded in step 1.

Does this issue occur when all extensions are disabled?: N/A
The user is shown the error Cannot read property ``rendererId`` of undefined, but using the developer tools, it appears the issue is really coming from here; the index returned is outside of the bounds.

I have revert this change because has caused a severe regression https://github.com/microsoft/vscode/issues/115293

I have revert this change because has caused a severe regression https://github.com/microsoft/vscode/issues/115293

Fixed via https://github.com/microsoft/vscode/commit/3fe4b0eb2f7d80255fa93eb1fc413058788c431a

Fixed via https://github.com/microsoft/vscode/commit/3fe4b0eb2f7d80255fa93eb1fc413058788c431a


Add files via upload

@johnlmaoxd Please provide us with:

the university official website URL, if different from the domain you are submitting
an URL of a page on the official website where an IT-related long-term (>1 year) course is offered by the university
an URL of a page or another proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the students.

@johnlmaoxd You might miss my previous comment. Please react.

@johnlmaoxd I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the abovementioned issue. Thank you for the understanding!


Helm on Windows: unknown flag: --kubeconfig

I'm testing using Helm on Windows, and running in to an issue trying to pass it the Kubernetes configuration.
The --kubeconfig option is being reported as an unknown flag. For reference, the config file is saved at the default location, C:\Users\my-user\ .kube\config, which is being picked up just fine by kubectl without having to set any flags.
From the docs, it looks like this flag should be a valid option. My version of Helm:
Client: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}
Should I be able to use this flag (and rely on it being there in future versions)?

#2219 was merged in after v2.7.0 was released, so it'll make it into v2.8.0. Thanks!

sorry, #2621. #2219 is the issue.

Awesome, thanks @bacongobbler


Add csv-to-excel extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer Hi 👋
I added new validation when just press Convert without selecting a file.
You can test this extension again 😉
Thanks ❤


match file parsing lib and convert tool

Hello,
I wrote a Rust lib for parsing ASP match files.
It provides functions for parsing and writing ASP match files as binary or text.
It also contains a convert tool provided as an example similar to parse_match_file.py cf examples.

convert does parse descriptors

motivation: it has been a while I wanted to write a binary parser using nom. I thought I might as well write something useful =)
NB: I have not published my code to crates.io (Rust registry) yet so aspmatch is not cast in stone (I can still change the name).

Hope that was fun and instructive.


ITE: drivers/i2c: it8xxx2: add mutex lock

Add mutex lock to prevent race conditions.
Signed-off-by: Tim Lin<EMAIL_ADDRESS>

This change is

what is the story with 'Reviewable'?

what is the story with 'Reviewable'?

The  extra comment is inserted by https://reviewable.io/.  I'm not sure if there is a setting to disable adding the extra context.  I and couple team members are trying out reviewable in hopes that it provides a better PR review interface than the Github interface.


w_serial_number_low_entropy lint should return an error:

Suprisingly, some CAs can't get even this right:
https://crt.sh/?id=277579245&opt=cablint,x509lint,zlint
As per the CA/B BR wording this should be an error. Any objections ?

The definitely could do better: https://crt.sh/?id=277426104&opt=x509lint,zlint,cablint

Agree, this looks more like an error than a warning given the SHALL.

This is intentionally not an error as it's not possible to programmatically detect a violation of this clause with 100% accuracy: https://github.com/zmap/zlint/pull/112#issuecomment-324677507

Sigh that's fair enough. It have been some time since I have read about the reasoning about this requirement. It was about a known prefix attack, right ?
The question is, does the missing bytes in the serial number ( if they CSPRNG outputs  bits with leading zeroes ) facilitate the attack> I guess not, because the length of the prefix cannot be predicted anyway in such case. Can someone please correct me here?
I am not very keen on digging into it again.
If encoding the serial number on smaller number of bytes makes the attack easier, I think this lint should return an error in the end. It is trivial to prepend the output from the CSPRNG with a fixed byte > 0 if one wanted to enforce a minimum byte length of the SN.

Sigh that's fair enough. It have been some time since I have read about the reasoning about this requirement. It was about a known prefix attack, right ?

It was introduced in response to the MD5/SHA-1 weaknesses in order to change the level of attack necessary to forge a certificate with a broken hash algorithm from chosen-prefix collision to random-prefix collision: https://cabforum.org/pipermail/public/2016-June/007858.html

The question is, does the missing bytes in the serial number ( if they CSPRNG outputs bits with leading zeroes ) facilitate the attack> I guess not, because the length of the prefix cannot be predicted anyway in such case. Can someone please correct me here?

No, the byte length itself doesn't matter.

If encoding the serial number on smaller number of bytes makes the attack easier, I think this lint should return an error in the end. It is trivial to prepend the output from the CSPRNG with a fixed byte > 0 if one wanted to enforce a minimum byte length of the SN.

While this is trivial, it is not required by the Baseline Requirements, and so I don't think it's reasonable to trigger an error given that a few CAs do not do this and appear to generate exactly 64 bits of entropy before encoding it as the serial number.

It looks like this has been addressed in the conversation here. I'm going to close this issue.


another attempt at ignoring run-exports

Neither #27 nor actually ended up ignoring the run-exports from python/nodejs

Logs are indicating that this worked now. No idea why ignore_run_exports_from would be different for python than ignore_run_exports...


Application window on desktop not showing everything

Versions

Python: Python 3.6.1
OS: Windows 10
Kivy: 1.10.0
Kivy installation method: via the pip method on the kivy official website

Description
I have tried to go through the tutorial "Creating Desktop and Mobile Apps with Python by brousch at PyOhio 2013" on the github kivy wiki but midway through I realized that my application window is not showing the elements(not sure if this is the right word to use) properly. i.e. they are being clipped off/cropped away
Unlike in the video tutorial where the instructor's application window was showing everything without being clipped off.
I've got a feeling the code doesn't matter because this issue also came up in the earlier steps of this tutorial; and that the issue actually lies in my windows settings somewhere? I just cant figure it out...
P.S. Apologies if this is a repeated issue that was solved before, but i really could not find this issue anywhere on the web
My application window:

Instructor's application window in the tutorial:

Code and Logs
This is the codes for the .py file and .ky file that I have got to so far... it should be the same as the instructor's codes in the video.
.py file:
import kivy
kivy.require('1.10.0')

from kivy.app import App
from kivy.uix.boxlayout import BoxLayout

class SayThis(BoxLayout):
    pass

class SayThisApp(App):
    def build(self):
        return SayThis()

if __name__ == '__main__':
    SayThisApp().run()

and
.ky file:
#:kivy 1.10.0

<SayThis>:
    orientation: 'vertical'
    button_font_size: '30sp'
    Label:
        text: 'Say This!'
        font_size: '45sp'
        size_hint: 1, None
        height: self.texture_size[1]
    TextInput:
        text: 'Hello, world!'
        font_size: str(font_slider.value) + 'sp'
    Slider:
        id: font_slider
        orientation: 'horizontal'
        min: 1
        max: 100
        value: 15
        size_hint: 1, None
    BoxLayout:
        orientation: 'horizontal'
        size_hint: 1, None
        height: sayit_button.height
        Button:
            id: sayit_button
            text: 'Say it!'
            font_size: root.button_font_size
            size_hint: 1, None
            height: self.texture_size[1]
        Button:
            text: 'Clear'
            size_hint: 1, None
            font_size: root.button_font_size
            height: self.texture_size[1]

Run your code on Windows 10 and Python 2.7.13. Every widget is drawn correctly, so this seems a problem with your OS settings.

Can't reproduce on Windows 10, Python 3.6.2 also:

Only guess I have: try to install latest dev (1.10.1) Kivy version from here and see if error remain.

@germn after updating to 1.10.1 via your link, i still get the cropping issue on my computer.

Can't reproduce, but I'd look into Environment and check how different scaling behaves for you.

I'm seeing the same symptoms with Python v3.6.3, Kivy 1.10.0 on Windows 10. Tried setting the scaling to 100%, but that did not fix.

Does anybody find the solution for this issue?
I'm observing same behavior for:
Win: 7
Python: 3.7.1
Kivy: 1.10.1
Provider: sdl2
I've tried all backend: angle, glew, sdl2

It's most likely a driver issue as explained here https://github.com/kivy/kivy/issues/5542.


Show information for non-text files in the status bar

Description
This PR allows CodeEdit to show the file size of the currently opened file. And if the file is an image, CodeEdit also shows its dimensions.
I could not find a style for file information in the Figma concept.
Related Issues

#1712

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots
sample.pdf:

sample.heic:

sample.ods:

screenshot.png

Thank you. I have resolved the conflict


rafthttp: fix pipeline.stop may block

This PR makes pipeline.stop stop quickly. It cancels inflight requests,
and stops sending messages in the buffer.
fixes #2888
I have manually tested the case that is described, and it has been fixed.
@tj-corrigan Give this branch a try if you have time?

I tested this branch and the behavior is now exactly what I was hoping for. We are able to remove an unhealthy client from an otherwise healthy cluster without any interruption to the cluster. Thanks!

@xiang90 remove the goroutine and double check. PTAL

hope this one can be more clear.

LGTM

LGTM

will be more cautious in the future. thx for figuring these points out!


Heroku deletes static files

Switch to aws for cloud storage, or firebase cloud storage

Resolved by shifting to firebase storage


Add syslog supports

This refers to https://github.com/nix-rust/nix/issues/413.
Hello world works locally:
2024-11-12 19:19:52.264557+0800 0x27405d0  Default     0x0                  27738  0    test-aae182a0654f64e3: Hello, nix!

I'd like to send this patch early for any necessary alignments.

BTW, a changelog is needed, please see CONTRIBUTING.md on how to add one.

@SteveLauC Thanks for your information! All updated.

For enum, libc_enum! will be used. Types Severity and Facility fall into this category.

Updated.

If a C string is needed (string with a tailing NUL), trait NixPath can be used to fill the gap. You can use it for the void openlog(const char *ident argument.

Updated.

The priority argument of syslog() and vsyslog() should be constructed by ORing enum Severity and enum Facility, we can probably impl std::ops::BitOr<Output = c_int> for these 2 types, but this is not that fault-resilient, perhaps we should define another wrapper type here🤔

Reasonable. Priority struct added.

Regarding the format void syslog(int priority, const char *format, ...); argument, do you think we should implement syslog as a macro similar to println!?

No. As stated at https://github.com/nix-rust/nix/issues/413#issuecomment-2470194025, I think we just simply use Rust's formatting function and pass the formatted string. This is also how Python wraps syslog functionalities.

A few tests to ensure the wrapper would work should be sufficient.

Included.

This patch doesn't wrap vsyslog and setlogmark.
For vsyslog, it's a variant of syslog for ergonomically coding in C, irrelevant to Rust.
For setlogmark, libc doesn't export LOG_MASK and/or LOG_UPTO, make it hard to wrap reasonable code. I temporarily added the wrapper but later revert it. IMO it's less used and we can revisit this function when there is a real-world necessity.

LOG_MASK and LOG_UPTO may be easy to add:
#[macro_export]
macro_rules! LOG_MASK
{
    ($($arg:tt)*) => (
        (1 << $($arg)*)
    )
}

#[macro_export]
macro_rules! LOG_UPTO
{
    ($($arg:tt)*) => (
        ((1 << (($($arg)*) + 1)) - 1)
    )
}

But I'd like to wait for this patch getting review and perhaps did it in a followup so that we don't push everything at once.

Just noticed that we can't use with_nix_path here because NixPath has a limit on length which seems not applicable for ident and message.

@SteveLauC test on unix and updated.
I have an idea to implement setlogmask, but not sure if we can export libc::c_int or we have other better types:
pub fn setlogmask(maskpri: libc::c_int) -> libc::c_int {
    let mask = unsafe { libc::setlogmask(maskpri) };
    mask
}

pub fn log_mask(pri: Severity) -> libc::c_int {
    1 << (pri as libc::c_int)
}

pub fn log_upto(pri: Severity) -> libc::c_int {
    (1 << ((pri as libc::c_int) + 1)) - 1
}

@SteveLauC test on unix and updated.
I have an idea to implement setlogmask, but not sure if we can export libc::c_int or we have other better types:
pub fn setlogmask(maskpri: libc::c_int) -> libc::c_int {
    let mask = unsafe { libc::setlogmask(maskpri) };
    mask
}

pub fn log_mask(pri: Severity) -> libc::c_int {
    1 << (pri as libc::c_int)
}

pub fn log_upto(pri: Severity) -> libc::c_int {
    (1 << ((pri as libc::c_int) + 1)) - 1
}

Also related test ideas - https://stackoverflow.com/questions/56049852/python-2-7-setlogmask0-not-disabling-syslog

@SteveLauC Here is an open question on whether to include setlogmask in this PR.

Regarding the setlogmask() interface, I think we can implement it in the following way:
/// System log priority mask.
#[repr(transparent)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct LogMask(libc::c_int);

/// Set the process-wide priority mask to `mask` and return the previous mask
/// value.
///
/// Calls to `syslog()` with a priority level not set in `mask` are ignored. The
/// default is to log all priorities.
///
/// If the `mask` argument is `None`, the current logmask is not modified, this
/// can be used to query the current log mask.
pub fn setlogmask(mask: Option<LogMask>) -> LogMask {
    let mask = match mask {
        Some(mask) => mask.0,
        None => 0,
    };

    let prev_mask = unsafe {
        libc::setlogmask(mask)
    };

    LogMask(prev_mask)
}

impl LogMask {
    /// Creates a mask of all priorities up to and including `priority`.
    #[doc(alias("LOG_UPTO"))]
    pub fn up_to(priority: Severity) -> Self {
        todo!()
    }

    /// Creates a mask for the specified priority.
    #[doc(alias("LOG_MASK"))]
    pub fn of_priority(priority: Severity)  -> Self {
        todo!()
    }

    /// Returns if the mask for the specified `priority` is set.
    pub fn contains(&self, priority: Severity) -> bool {
        todo!()
    }
}

impl std::ops::BitOr for LogMask {
    type Output = Self;
    fn bitor(self, rhs: Self) -> Self::Output {
        Self(self.0 | rhs.0)
    }
}

Though I think the C macros LOG_MASK and LOG_UPTO should be added to the libc crate first, so perhaps we can include these things in the next PR?

Though I think the C macros LOG_MASK and LOG_UPTO should be added to the libc crate first, so perhaps we can include these things in the next PR?

Yes. Let's review this PR as is now.
@SteveLauC Thanks for your following commits!


找不到neural_renderer文件夹

Failed building wheel for neural-renderer:
Apparently, this software does NOT like the newest version of Visual Studio 2019, so I had to download an older version (16.8.4).


Automated cherry pick of #5111: region: server list by host sn

Cherry pick of #5111 on release/3.1.
#5111: region: server list by host sn

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@a3b3e9c). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             release/3.1   #5112   +/-   ##
=============================================
  Coverage               ?   6.75%
=============================================
  Files                  ?     545
  Lines                  ?   95246
  Branches               ?       0
=============================================
  Hits                   ?    6433
  Misses                 ?   88275
  Partials               ?     538

Flag
Coverage Δ

#aFlag
6.75% <0%> (?)

Impacted Files
Coverage Δ

pkg/mcclient/options/servers.go
0% <ø> (ø)

pkg/compute/models/guests.go
0.56% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b3e9c...d91dbf5. Read the comment docs.

/lgtm

/approve


[ENG-458][ENG-440][ENG-52] View-only links for registries

NOTE:

Replaces #9020
Reverts #9018
Depends on FE changes -- merge/release those first (or at the same time): https://github.com/CenterForOpenScience/ember-osf-web/pull/670

Purpose
Registrations in the API viewed with and without view-only links should contain most of the same information except user-identifying information.  We're currently filtering too much relevant information when a registration is viewed through a VOL.  Registered_meta needs to strip identifying information from the schema responses.  We lack good registration VOL tests - as a part of adding registration VOL tests, fix any bugs found.
Changes

To specify which fields should be anonymized, hardcode the anonymized_fields on the serializer, instead of all the fields that shouldn't be anonymized. (anonymized_fields will usu be the exception, not the rule). This change exposes registered_meta which wasn't being displayed before
Delete question responses that have been specified as having identifying information
Add Registration VOL crud tests
Fix bugs in ENG-52 -  APIv2 Returning deleted VOL's and unable to make VOL's anonymous

QA Notes

Documentation

Side Effects

Ticket
Feature: https://openscience.atlassian.net/browse/ENG-458
Subtask: https://openscience.atlassian.net/browse/ENG-440
Bugfix: https://openscience.atlassian.net/browse/ENG-52

Failing test appears to be random, cannot reproduce.


Expanding the CustomVariable

Discussed in https://github.com/Snow-Shell/servicenow-powershell/discussions/204

Originally posted by DrMarkX September 22, 2022
I like the new IncludeCustomVariable format. This makes it easier to display the minute data within that variable.  However, I used to be able to see all the details of the CustomVariable by using this one-liner.
Get-ServiceNowRecord RITM888888 -IncludeCustomVariable | Select-Object CustomVariable -ExpandProperty CustomVariable
That no longer expands all parts. Is there another way to get these data?
Old way shows data like this.
Name          : something_check
Value         : false
DispalayName  : Do you need this thing?
Type          : CheckBox

New Way shows data like this.
something_chcck       : {Type, DisplayName, Value}

@drmarkx, thanks for the heads up.  I left off a conversion to pscustomobject and was returning a hashtable instead.  Would you mind manually updating and see if this is what you're looking for?  https://github.com/Snow-Shell/servicenow-powershell/commit/1c8fe5850943c424657356201d050e1ea41651d3

Tested.  That fixed the issue.  Thanks!


Add corner axis

This would cause fails of most checks, because of the freeze() function used by new Vispy. We could try to merge it later when the new Vispy is released.

@PennyQ - I fixed the issue with VisPy 0.4 here: https://github.com/PennyQ/glue-3d-viewer/pull/2 - you can merge that PR and it will add the commit to you branch.

This is looking promising! However, at the moment, the axis doesn't seem to be lined up in the same direction as the white cube axes – do you know why this is?

@ I guess it's because the visual is under the perspective display of the current camera, while the corner axis is drawn on the scene instead of on the view of canvas, which means the axis is not influenced by the camera setting.

The direction of the axis is actually the same of camera coordinate (shown below), so I tried to get the transform from camera coor to scene coor as
tr = as_matrix_transform(self.get_transform(map_from='visual', map_to='scene')) and matrix multiply to original transform, but the tr here equals unit matrix. @astrofrog do you have any ideas?


Existing resource policy verification in e2e

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

/lifecycle frozen

@kaovilai can you please explain this issue?

Add restore existing resource policy coverage to e2e

using this field, right?
https://github.com/openshift/oadp-operator/blob/0347669ab8b5f051d815a59d6f45183742380720/bundle/manifests/velero.io_restores.yaml#L56

Yup


Add TLSCipherSuite to slapd.conf

Has to be explicitly enabled - default is not to add the line to slapd.conf (which is current default)

Thanks @neilh23


Today's date is being recorded wrong.

It is showing up as yesterday instead of today. Perhaps a timezone issue?

It was recorded correctly, but displayed wrong. This is fixed now.


Update test-module-for-model.js

This is to avoid deprecation warning:
You tried to look up 'store:main', but this has been deprecated in favor of 'service:store'.

:+1:


Allow to disable editor group maximize on double click

Occasionally a mouse click turns into a double click (which is hard to avoid), but I don't want to maximize the editing group and have to get it back every time I accidentally maximize it.
I can't find the relevant settings in the Settings, I hope this feature can be turned off, thank you very much!

Related on Stack Overflow: How do I stop VS Code from maximizing the size of an editor group when double-clicking one of its tabs' handles?. I'll update my answer post with progress and discussion from here.

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Verification:

configure workbench.editor.doubleClickTabToToggleEditorGroupSizes to false
open more than 1 editor group
double click a tab and verify no group sizes changes


Update to 1.21

Also added a few new offset types and added overlay message as a toggleable option with offset
Compiled jar here
I have changed up the mixins quite a lot so if you would prefer them to be more like how they were before I can revert to using those :)

Workflows will need updating, I haven't done those

Thank you so much for doing this, i have been working 40 hours a week and 12 hours of school a week. This means so much ❤


Allow control over parallel network activity

A bug was reported to glide (https://github.com/Masterminds/glide/issues/411) about how concurrent git+ssh activity causes issues when the key hasn't been decrypted into an agent. To handle this case, vsolver must provide an option for fetching in serial so that the requests are made in serial, and each password input is recorded correctly.
In some imaginary, future version, we might also attempt to predetect which URLs are safe to parallelize (e.g., unsecure git http), and have this option (or a new one) always parallelize those, but not others.

Affects #13

This issue was moved to golang/dep#448


Refactor/heading

Coverage decreased (-0.05%) to 52.602% when pulling 0e812f2c6cd67c81464b7e05465c47f64d372046 on refactor/heading into 0c42137e60c78df7f70c6522d80c6732be62fab7 on master.

Fix #12


Conditional type doesn't work inside tuple

TypeScript Version:  4.1.0-dev.20200807

Search Terms: conditional type tuple
Code
type Tuple<T> = [T extends null ? T? : T];

Expected behavior:
Expected the definition to work as expected.
Actual behavior:
Got the following error:

JSDoc types can only be used inside documentation comments.

Playground Link: Playground Link
Related Issues: Did not find anything close.

As per #24897, outside of JSDoc the ? modifier is only valid for tuple elements, not arbitrary types. It does not make sense to say that a type can be omitted, only that an element can be omitted.

The above definition is inside a tuple, and one way to look at that is the element can be omitted or not.
But I guess that messes up in other ways like making sure all the other elements are optional too.


First version of Forest

TODO:

Add more tests (ex: logging to a file etc)

file extension for cache should be .ara.cache ( because anything that ends in .ara is valid Ara code according to the parser )


strict-export-declare-modifiers and default keyword

How do you write that's something is a default without the export key word?
This is failing: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24144/files#diff-1c3d7581a68db8b801e724cb6478a526R11

This will be fixed by #143.


SSH Key Setup

name: ROS2 Humble Build

on:
  push:
    branches:
      - main
  pull_request:

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v2

      - name: Build the workspace
        run: |
          ls
          rm -rf Accio-Messages

      - name: Setup SSH
        uses: MrSquaare/ssh-setup-action@v2
        with:
          host: github.com
          private-key: ${{ secrets.JACOB }}

      - name: Clone repository
        run: git clone git@github.com:Accio-Robotics/Accio-Messages.git

This is the GitHub action that I have written. The action is stuck in the Setup SSH step. I have added the private key in secrets in the GitHub repository.

Hello!
Could you re-run the workflow with debug logging enabled and give me the output?


Merge pull request #3195 from Raku/markdown-fix-github-org

The problem
Contributor Markdown refers to the perl6 org, not Raku
Solution provided
Change README.md and STYLEGUIDE.md to refer to Raku.
Note that there are numerous cases of 'perl6[.]org' appearing in non-Markdown, such as in build scripts, SASS, etc. Not touching those, since those will affect doc site building. This is just for contributor-facing text.
I’m still sending this as PR so that I don’t step on others’ toes—I can’t find the umbrella “perl6(.org) → Raku(.org) migration plan” ticket if it exists...

Just fix anything you notice. I think the only thing we tend not to change now is the binary name, everything else can and should be changed.


Error upload asset to a Media collection when relatedTo as field in another collection

Describe the Bug
Logging error when trying to upload asset to a Media collection that is linked to another collection as a field. Everything seems to process properly and UI does not crash but the following error is logged.
Happens when trying create new and editing Media collection item from relatedTo collection.
[09:13:05] ERROR: Error: Could not find field schema for given path "undefined"
    at buildFormState (webpack-internal:///(rsc)/./node_modules/@payloadcms/ui/dist/utilities/buildFormState.js:81:11)
    at Object.buildFormState [as form-state] (webpack-internal:///(rsc)/./node_modules/@payloadcms/next/dist/routes/rest/buildFormState.js:21:113)
    at eval (webpack-internal:///(rsc)/./node_modules/@payloadcms/next/dist/routes/rest/index.js:589:45)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Link to the code that reproduces this issue
https://github.com/codedawi/payload-v3-media-bug
Reproduction Steps
Configure Media collections of upload type.
Configure People collections with field profile that links to media upload type.
Create new or Edit People collection and then click to upload profile.
On redirect to the Media page upload for profile field it will through this error in the logs. Page seems to function fine though. This error is ONLY happens when being redirected to linked Media field from different collection (uploading Media directly to that collection doesn't result in error.
Which area(s) are affected? (Select all that apply)
area: ui
Environment Info
Payload: 3.0.0-beta.118
Next.js: 15.0.1

I am also experiencing the same issue -- when trying to upload asset to a Media collection that is linked to another collection as a field.
Payload: 3.0.0-beta.125
Next: 15.0.0
Is there a fix for this?


refactor the non_host part for not injecting to custom env

fix: https://github.com/tox-dev/pipdeptree/issues/343
We can get the sitepackages directory from the given interpreter directly instead of running our code again with it.

I think the result of this method is the same with the original one. Please take a look if you have time. @kemzeb

Hmm, I noticed that when we're using a venv that has system site packages enabled (i.e. I did python -m venv --system-site-packages venv), running the following:
pipdeptree --python path/to/python --local-only

...would cause us to hit the else branch (since I am not running in a virtual environment). We don't want this since we will use paths to metadata from the entire environment.
I think what we need to do here is if --python and --local are given, we should grab the result of:
"str(py_path), "-c", "import sys, site; print(site.getsitepackages([sys.prefix]))"

...and pass it to distributions(). Otherwise, use sys.path.

That's a really good situation which I didn't notice. I will add some tests to cover this too.

FYI once we merge this I'll make a 2.18.0 release.

Can't see any other issues, so it looks like this is good to go. Will release 2.18.0 after merging

Looks like we're good to go, releasing 2.18.0


Allow enums as step parameters

Request
I would like to have the ability to have an enum in a step. Say that I have the following enum:
public enum ShirtColor {
    RED, ORANGE, YELLOW, GREEN, BLUE, PURPLE;
}

I would like to create a step that only allows these options:
    @Step("Buy a <color> shirt")
    public void buyAShirt(ShirtColor myColor) {
        // Implementation goes here
    }

So in a spec, * Buy a "GREEN" shirt is allowed, but * Buy a "BROWN" shirt is not.
Current behavior
There are no validation errors with * Buy a "GREEN" shirt or * Buy a "BROWN" shirt. When running the spec, the following error appears:
Failed Step: Pick color "GREEN"
Specification: specs\example.spec:41
Error Message: java.lang.IllegalArgumentException: argument type mismatch
Stacktrace:
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:497)
com.thoughtworks.gauge.execution.MethodExecutor.execute(MethodExecutor.java:31)
com.thoughtworks.gauge.execution.StepExecutionStage.executeStepMethod(StepExecutionStage.java:94)
com.thoughtworks.gauge.execution.StepExecutionStage.executeStep(StepExecutionStage.java:77)
com.thoughtworks.gauge.execution.StepExecutionStage.execute(StepExecutionStage.java:58)
com.thoughtworks.gauge.execution.AbstractExecutionStage.executeNext(AbstractExecutionStage.java:24)
com.thoughtworks.gauge.execution.HookExecutionStage.execute(HookExecutionStage.java:42)
com.thoughtworks.gauge.execution.ExecutionPipeline.start(ExecutionPipeline.java:31)
com.thoughtworks.gauge.processor.ExecuteStepProcessor.process(ExecuteStepProcessor.java:34)
com.thoughtworks.gauge.connection.MessageDispatcher.dispatchMessages(MessageDispatcher.java:72)
com.thoughtworks.gauge.GaugeRuntime.main(GaugeRuntime.java:37)

Desired behavior
I would like to have one of the following two options:

A validation error (i.e. the red squiggly lines) underneath the word "BROWN" in * Buy a "BROWN" shirt
A runtime error such as the following: BROWN is not an enum value of ShirtColor

It would also be a plus to be able to use toString() values or some other means of identifying an enum, rather than its value (so some way that "green" could be an acceptable parameter in this case).

This feature is implemented by @boazberman in this PR and is merged.
@sguptatw Fix should be available in nightly >= 24.10.2016

Test case failing with params
# Buy

##Clothes
* Buy a "red" shirt

##Another
* Buy a "" shirt

@sguptatw Hey I added the requested support in failing cases. Would love if you can approve it now ;)

@boazberman: Thanks for your interest in this feature. We are looking into the PR, will update you regarding this soon.

Please notice that #75 was merged. Would love to see a version containing this feature rolling out. Any more urgent issues concerning this feature to resolve before it can be released? Please let me know!

Steps with parameter enum and ContinueOnFailure configuration is not working as expected. The corresponding issue is here

@sguptatw Both the issues that you have mentioned above aren't applicable in this case. I feel this particular issue can be closed.

Gauge-Java 0.5.1 is released with this feature!
Run gauge --update java to update java plugin.


fixes https://github.com/perfood/couch-auth/issues/65

I did what @LyteFM suggested in https://github.com/perfood/couch-auth/issues/65#issue-1554755156 if session conflicts are happening. I tested locally, manually provoking the error like suggested in https://github.com/perfood/couch-auth/issues/65#issuecomment-1587534835 and everything seems to work fine with the fix. However please check my solution, since I'm not familiar with the code and the workflows.
By the way, thanks for the amazing library, for keeping "superlogin" alive. We depend on it in our project AsTeRICS Grid which is a tool that helps many families with disabled children around the world.

Great thanks for the review and merging! 👍
If possible please publish a new version including the fix to npm. Thanks!


Add support for purescript.

Fixes #431
Changes proposed:

[x] Add
[ ] Prepare
[ ] Delete
[ ] Fix

Things I've done:

[x] I've pulled the latest master branch.
[x] I've run npm install to install all the dependencies.
[x] I've run ESLint.
[x] My pull request fixes an issue, I referenced the issue.
[x] I've run npm run build to build the extension.

Has the same colors as ansible.

not really on a high-contrast monitor...

What you mean?

I think the background of the logo is quite more dark than the Code background color.

So is the logo.

Okey.

Hi @JimiC, I think this is a perfect case for the new light support functionality. I personally don't like the idea of having the squared background like this. Is too similar to the vscode background but different enough to notice the change in the tonality. I would remove it or sorround it with a 1px border of a more lighter tone so users could notice the difference. In this case I do think the logo background is important so I would opt for the second option. What do you think?

By the way, who's "Nooknok"? When I try to visit his profile, I see a 404 error page...

As I said to @jens1o the icon has the same background as the ansible icon and those colors are the official ones of the logo. On a light theme colors can be swapped. I don't we need to do any extra work for the time being.

@robertohuertasm I love the idea of having a light version and with the work we are doing converting all icons to SVG it can be easily done. But first we need to finish the first task.

After having done a few tests and seen the purescript github page, the official page and what google has to say I would discard the background square.
I will try to explain my statement:

I think that the logo with the background that we have in this PR doesn't respect the margins in the "official" logo. I know this is because we want to better see the icon inside the square but, in my opinion, this doesn't look good, it seems forced. The alternative, being making the icon smaller doesn't work in our favour either, because the icon is barely recognizable.

After seeing some of the Purescript resources I think that the icon is the main piece of the logo. They even use the icon on itself without any background. I think this background is just the contrasted version they use but given that VSCode dark theme has a similar background I think we could take advantadge of that. This would allow us to make the icon look bigger and be close to the "official" way. We're not always accurate  or loyal to the original implementation (see markdown, js, ts...)

@JimiC, you're right about the Ansible icon. First thing about this icon is that the A should be white. I will change it asap. The other thing to remark, in contrast with the Purescript logo is that in Ansible the Circle is a piece of the icon so it makes sense to incorporate it. It's not like that in the case of Purescript.

Finally, about the light version, I think it can be implemented no matter the state of the SVG conversion process. What I mean when I talk about a light version is not that we're going to provide a light version for all the icons at once. I'm talking about implementing a way to mark the icons with a light version flag in the supportedExtensionsfile and generate the proper icons.jsonfile. There's already some people who is using the light version with our theme extension. In this case, I was thinking that maybe this could be a way to force us to implement this automatic process by the virtue of having this new icon amongst us. The real light icons implementation would come later. But indeed it's not my idea to force anything so never mind!

@robertohuertasm In the SVG version the A is white for the ansiblelogo. When I worked on the purescript logo what troubled me was that it's white and on the artboards white background it doesn't show. I CAN make the logo be only the white parts and amke it 30x30 on the 32x32 canvas.
The problem is that it will not show on a light them.
So until we have support for light theme we can go with this and revise it later.

I suggest you make your priority to implement the support of a light version of an icon and let me do the adjustments on the icons.
Now that I'm familiar with the tool I use to create the icons the process can speed up.

@JimiC ok! You've made your point. Let's do it like you say. Once the light version functionality (#392) is ready this will be the first icon to convert 😉

@robertohuertasm And the ansible too.


Setup codecov coverage reports on GitHub

Description of the issue
Our GitHub project can benefit from integration with https://codecov.io to provide test coverage reports for the master branch and pull requests.  The CI already checks for test coverage of the lines modified in the PR and blocks when changed lines are not tested.  codecov reports would in addition give us a color markup for covered/uncovered lines in PR diffs and also for all files on the master branch.

I would like to work on this

Thank you for taking this on!

The Codecov app might have to be installed and configured by an Admin in the Github organization https://codecov.freshdesk.com/support/solutions/articles/43000593941-set-up-github-app-integration to add a repository token as repository secret as per this: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Is there a way to configure codecov to recognize coverage: ignore? Not a big issue though since we still have another coverage check today.


fix: incorrect padding of game container 🛠

Close #811

Hey there @panwar8279, please make sure to review this PR.


Threaded example in MacOS

When running the HelloWorldThread example with LibUV in MacOS, it fails to initialize beyond a single thread:
▸ ./HelloWorldThreaded
Thread Thread Thread Thread 0x7000005fb000 failed to listen on port 30000x700000472000 listening on port 0x7000004f5000 failed to listen on port 3000

3000
0x700000578000 failed to listen on port 3000
^C

I noticed the uSocket library has a OPTION_REUSE_PORT but it doesn't seem to be used. Is SO_REUSEADDR / REUSEPORT necessary for the threaded example, and if so, how to enable it?
Note: had to add the -luv parameter to compile, otherwise it tries to use epoll despite the docs stating the contrary.

SO_REUSEPORT is only really supported on Linux. I don't think any other OS has documented similar behavior, even if it might work. I don't know the situation on macOS.


Not working on Android Chrome - Server responded with 0 code

Hello, thank you for the great library. There is an issue by using it on Android devices. It can't upload file from gallery. I get error ' Server responded with 0 code'. I have tried on your example web-site http://reactdropzone.azurewebsites.net/example/ with the same result.
I gues that the problem is in http headers.

Seems to be the problem with dropzonejs itslef:
https://github.com/enyo/dropzone/issues/1278
But interesting, have you met same problems?

One more screenshot

It works fine in standard android browser but not in Chrome or FireFox.

It's definitly problem with Android Chrome browser. You just can't uploud any stored files on any website (even social networks), but you can take photo and then Chrome will have anough permissions to use photo for uploading. But it is not the same with stored photos.
On iOS Chrome - all works fine.

So, the problem was with Google Chrome permissions on Android. You must allow access to storage to Chrome manually in Android OS. After that works fine!
I'm closing issue.


Problem: Move subscriptions to organization account

List of Accounts

[ ] - Ankr
[ ] - Alchemy
[x] - Lianereum (nftgo)
[x] - DataImpulse
[x] - bitscrunch

cc @Jarryd-pretorius

DataImpulse - used in truflation-ingestors
NFTGO - used in truflation-ingestors

Alchemy (there are some hardcoded URLs in the website repo).
@Jarryd-pretorius Do I need to create an Alchemy account or can you invite me to the existing one?

@Jarryd-pretorius Will be great to get the proxy configuration values from Joseph

which service is this for @georgeciubotaru ?

@Jarryd-pretorius Was, DataImpulse, but clarified already.

@Jarryd-pretorius Can you help me access the nft.truflation.com so I can check where the Ankr endpoints are used?
Also, provide access to Alchemy.

Log: Alchemy usage not found, the only usage is inside the website repo, but the code is not used in production.
Also, the Alchemy keys are provided by @markholdex.
So there are no issues with Alchemy.

All subscriptions are moved under<EMAIL_ADDRESS>email account


Chunk key

Part of #624
Chunks are sorted, merged and uniq-ified by comparing their key metadata.
Previously this went via Sprintf() with six memory allocations per call.
The replacement is a bit long-winded, but very fast in operation.
Benchmarks:
before (master commit aa2a85dd2731ec3aa20709ce506fcee905ca57bd)
$ go test -bench=. -benchmem
goos: linux
goarch: amd64
pkg: github.com/weaveworks/cortex/pkg/chunk
BenchmarkByKeyLess-2        	 1000000	      1094 ns/op	     224 B/op	      12 allocs/op
BenchmarkByKeySort100-2     	    2000	    549354 ns/op	  111174 B/op	    5954 allocs/op
BenchmarkByKeySort1000-2    	     200	   9140388 ns/op	 1923367 B/op	  103022 allocs/op
BenchmarkByKeySort10000-2   	      10	 124749426 ns/op	26928371 B/op	 1442535 allocs/op
PASS
ok  	github.com/weaveworks/cortex/pkg/chunk	13.577s

after this PR:
BenchmarkByKeyLess-2        	100000000	        15.9 ns/op	       0 B/op	       0 allocs/op
BenchmarkByKeySort100-2     	  100000	     12036 ns/op	      32 B/op	       1 allocs/op
BenchmarkByKeySort1000-2    	   10000	    209585 ns/op	      32 B/op	       1 allocs/op
BenchmarkByKeySort10000-2   	     500	   2788854 ns/op	      40 B/op	       1 allocs/op

Is this safe?  There are at least two different version of chunk keys, one from before we added checksums.

Is this safe? There are at least two different version of chunk keys, one from before we added checksums.

There are exactly two versions in Chunk.ExternalKey(), differentiated by whether the checksum is set.
Since we compare everything else ahead of the checksum, we are left to contemplate the problem of two chunks which are identical except one was stored with and one stored without the checksum.  And the checksum is exactly zero.  The new code would consider those chunks equal, and the old would consider them different.  It would be easy to re-instate this behaviour, but I'd like to hear the justification.
I remarked in the commit message on the more general theme of changing the sort order: it was fairly arbitrary before, and it is different now.  But as long as the order is self-consistent and matches the equality test used for de-duping I think it is fit for purpose.


Bug: The world was reset after the transformation

I was using the tool to convert the region to .liner format after deleting the .mca from the old format I noticed that when I reopened the server, the world would turn back to the way it was, no sign of construction at all.
I'm using the leaves end with the .liner storage format turned on, but I converted it manually using the tool here.
So wondering what went wrong here.

DM me on Discord if you want me to take a look closer look, Github isn't suited for direct technical support.
I'm pretty certain it's not a problem with either leaves nor linear, but with configuration.


BDD Test Sign up fix

Bdd test complaining about hydra cookie missing. Needs more investigation. Low priority for now.
url: https://localhost:8045/oauth2/callback?code=fIv9Jx2mI6Eq6dU2li8vZIjihaMwhSACsUUyshL_n1E.5EGxlncHuNAVktO20bx4r8do-OQX892jZhxoGXucWTg&scope=openid profile email&state=899fe848-2aba-405e-afe8-edf28b01fa3c
body: missing hydra login challenge cookie

This is not applicable now as we have moved to ui-automation tests.


Messaging: Use composite actions

Description
Use composite actions.
References
https://app.zenhub.com/workspaces/mighty-ducks---the-outlaws-6193fe815d79fc0011e741b1/issues/energinet-datahub/the-outlaws/328

Codecov Report

Merging #121 (ddf86b2) into main (470565e) will decrease coverage by 8.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   70.63%   61.84%   -8.79%
==========================================
  Files          50      117      +67
  Lines        1192     2089     +897
  Branches      120      295     +175
==========================================
+ Hits          842     1292     +450
- Misses        308      699     +391
- Partials       42       98      +56

Flag
Coverage Δ

messaging
51.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...onApp.TestCommon/Configuration/AzureB2CSettings.cs
100.00% <0.00%> (ø)

...mmon/Configuration/IntegrationTestConfiguration.cs
100.00% <0.00%> (ø)

...ource/FunctionApp/Middleware/JwtTokenMiddleware.cs
0.00% <0.00%> (ø)

source/Messaging/source/Messaging/HubResponse.cs
0.00% <0.00%> (ø)

.../SchemaValidation/SchemaValidatedInboundMessage.cs
0.00% <0.00%> (ø)

...unctionApp/Extensions/FunctionContextExtensions.cs
0.00% <0.00%> (ø)

...nostics/HealthChecks/HealthCheckEndpointHandler.cs
0.00% <0.00%> (ø)

...essaging/source/Messaging/Validation/RuleResult.cs
100.00% <0.00%> (ø)

...urce/Messaging/MessageTypes/HubMessageAttribute.cs
0.00% <0.00%> (ø)

...p/source/FunctionApp/Middleware/ActorMiddleware.cs
0.00% <0.00%> (ø)

... and 59 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Android client compilation?

Using the gradle dependency
compile 'de.ruedigermoeller:fst:2.42'
I have fst running on Android. And it really is faster! Thanks!
I'd like to be able to build form source.  However, these dependencies don't seem to be part of the Android SDK:
import sun.misc.Unsafe;
import sun.misc.Cleaner;
import sun.nio.ch.FileChannelImpl;
import sun.reflect.ReflectionFactory;
Given that the jar obtained by gradle works, it seems this is a problem you have solved.
Can you explain how to compile fst from source for Android?
Thanks!

I just build against standard JDK with -source 1.7. FST detects Android at
runtime and uses fallback implementations for the proprietary classes then.
2015-11-09 6:32 GMT+01:00 bradedelman<EMAIL_ADDRESS>
Using the gradle dependency
compile 'de.ruedigermoeller:fst:2.42'
I have fst running on Android. And it really is faster! Thanks!
I'd like to be able to build form source. However, these dependencies
don't seem to be part of the Android SDK:
import sun.misc.Unsafe;
import sun.misc.Cleaner;
import sun.nio.ch.FileChannelImpl;
import sun.reflect.ReflectionFactory;
Given that the jar obtained by gradle works, it seems this is a problem
you have solved.
Can you explain how to compile fst from source for Android?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/RuedigerMoeller/fast-serialization/issues/95.

I see. Thanks.

hi there
reopen to serve as faq.


JBPM-4979 - Generated PDF is unreadable

Adding yahp used by jBPM Designer to create pdf from html

I will try to mavenize thee libs used and do another PR


Create Flutter CI integration tests

[ ] iOS (macos-latest runner)
[ ] Android (ubuntu-latest runner)
[ ] macOS
[ ] Windows
[ ] Linux

We also currently download the binaries from GitHub so we will have to add support to load the binaries from disk in order to do this


Remove licenses for non-distributed dependencies; add sha1 for all maven_jars [phab:D1078]

Created by shahms at 2016-09-22 17:28:01:
Remove licenses for non-distributed dependencies; add sha1 for all maven_jars

fromberger accepted this revision at 2016-09-22 17:33:18

shahms closed via commit bc807c4cab97bfb88036a40cb332bc740b868542 at 2016-09-22 17:46:25


PDH to be able to use new agent signature

Also remove multi instance support. All key based dictionaries have been converted into single lists.
Dictionaries have been left as dictionaries and _make_counters preserves the unused key attribute to prevent breaking IIS check.
Failing integrations Clickhouse, HTTP and TLS are failing on master too

You'll need to pre-process the args like https://github.com/DataDog/integrations-core/pull/4469/files#diff-09e2f9e4c13710e993b2ce26901f9065

Shouldn't AgentCheck be in charge of that?

/azp run

Need to extract things before super() like:
https://github.com/DataDog/integrations-core/blob/8b2ed4dda9b2196ef8bc10927ad3156c6ad8941e/datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py#L46-L58

Does it make a difference to do it before or after?


Resolve broken links issue

Hi @CelesteDG, please review this.

Hi @CelesteDG - Please review this.


Blurry fonts on Linux when display scaling is engaged

Hello, and thank you for the wonderful program you have made!
When I start goneovim (v0.6.2) I see the following (goneovim is on the left, nvim-qt is on the right for comparison):

I use ArchLinux with KDE and Xorg with HiDPI monitors and have global display scaling set to 131.25%. The issue goes away either if the scaling is set to 100% or QT_SCREEN_SCALE_FACTORS environment variable is set to 1.
Here is the illustration.

@coordinatio
Hi :D
Thanks for this issue report.
Problem reports with screen captures are helpful.
I have analyzed your issue and fixed the code that seems to be relevant.
You can check the behavior in the following CI job artifacts. Any feedback would be appreciated.
https://github.com/akiyosi/goneovim/actions/runs/2861545890

It seems that the issue still persists, here is how it looks like now:

The screenshot is made with goneovim-linux taken from artifacts of the build you have pointed to.

@coordinatio
Thanks for the confirmation.
You mentioned that setting the QT_SCREEN_SCALE_FACTORS environment variable to 1 resolves the problem, would it be acceptable to automatically export this environment variable inside Goneovim as a solution to fix the problem?
The following is a test binary that automatically exports this environment variable inside Goneovim.
https://github.com/akiyosi/goneovim/actions/runs/2895363660

Still the same:

According to the diff here: https://github.com/akiyosi/goneovim/commit/d0bdbe6a94dc5cd0c82405583eac1d3892732f0d you have misspelled the variable name.
It's name is QT_SCREEN_SCALE_FACTORS not QT_AUTO_SCREEN_SCALE_FACTOR.

@coordinatio
Sorry, I was confusing them.
I have fixed it further. You can get the artifacts in the following jobs.
https://github.com/akiyosi/goneovim/actions/runs/2899895368

Unfortunately, the Linux artifact of https://github.com/akiyosi/goneovim/actions/runs/2899895368 behaves in the same way as before. The same blurry fonts, which can be fixed by setting the environment variable outside the application.
I can guess that Qt is initialized before you set the variable. I observe the very similar issue with nvui, and that pull request fixes it: https://github.com/rohit-px2/nvui/pull/142/commits/83a17f9b0f1bdb0f94247dd98549bc4c268ab831
Maybe that can give you a useful hint for fixing the problem.

@coordinatio
Thanks for the useful information.
I do not have a High DPI display so it is difficult for me to investigate this issue and your information is very helpful.
Any additional information you can provide on the following points would be very helpful.

Your last comment indicates that the current environment variable setting process is not working effectively. Therefore, I have created a modification that changes the environment variable setting process. Does this solve the problem?
https://github.com/akiyosi/goneovim/actions/runs/2903388540

For the same problem in Neovim-qt, only setting QT_AUTO_SCREEN_SCALE_FACTOR=1 seems to work ok. I have created a version with only QT_AUTO_SCREEN_SCALE_FACTOR enabled with the new setting process. Does this solve the problem as well?
https://github.com/akiyosi/goneovim/actions/runs/2903391086

@coordinatio
Sorry to bother you, but we would appreciate it if you could confirm that it works.

@akiyosi I'm facing this issue as well. Where can I find the build artifact for:
https://github.com/akiyosi/goneovim/actions/runs/2903391086

@akiyosi the artifact from this build: https://github.com/akiyosi/goneovim/actions/runs/2903391086 still suffers from fuzzy text on Sway.

@ldelossa
Thanks for confirming.
I have made further fixes.
Could you please confirm that it works with the following CI artifacts?
https://github.com/akiyosi/goneovim/actions/runs/3144946308

Not much improvement.
Here is the binary you provided compared to neovide:

Also, goneovim doesn't seem to adjust its fond rendering based on screen size. I keep my font size at 12 in neovide, and it adjusts the size of it when it moves from my 2k to 4k screen. In goneovime, i must change the font size manually.

@ldelossa
Thanks. Please let me confirm the following.

Is it correct understanding that the QT_SCREEN_SCALE_FACTORS environment variable is set to 1 in your environment beforehand, also avoiding the problem?
Would the situation be different if you started a goenovim with the CI artifact binaries as follows?
/path/to/goneovim --nofork

Also, goneovim doesn't seem to adjust its fond rendering based on screen size. I keep my font size at 12 in neovide, and it adjusts the size of it when it moves from my 2k to 4k screen. In goneovime, i must change the font size manually.

The above issues would be discussed in a separate issue, if you would like.


Adopt the OCaml Code of Conduct

The OCaml Code of Conduct can be found in ocaml/code-of-conduct and has been discussed in this Discourse thread.
We propose adopting it for ocurrent/ocaml-ci as well.

Requires https://github.com/ocurrent/ocaml-ci/pull/830 and the email addresses from there.


Disable duplicate detector:

High Level Overview of Change
Partially revert the functionality introduced with #4195 / 5a15229 (part of 1.10.0-b1).
Context of Change
Supersedes #4437. This PR simply squashes the two commits in #4437. I elected to do this on a new branch/PR so that we have a clean slate to re-review and look for any other potential risks.
Alternative to this PR: #4439
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

Test Plan
@manojsdoshi @sgramkumar to prepare a test plan.

Acknowledgements:
Aaron Hook for responsibly disclosing this issue.

Bug Bounties and Responsible Disclosures:
We welcome reviews of the rippled code and urge researchers to
responsibly disclose any issues they may find.

To report a bug, please send a detailed report to:

<EMAIL_ADDRESS>
Note: This PR will be squashed to 1 commit upon merging.

LGTM, could also remove the Instance-Cookie header from the handshake and the Application::instanceID/_instanceCookie since it's no longer used, but I don't think it's hurting anything if it sticks around


[Query] Is there a method for deleting docs/links/etc. in the vector database?

Is there a way to delete certain/all items (uploaded PDFs, YouTube links, etc.) in the vector database (besides the app.reset() function)?

It should be by using app.db_client and then Chroma's delete method that you can find in the chroma docs.

but I also had the idea, which you probably want, to automatically add a metatag for the loader used. I will open an Issue for this.

Thanks, @cachho. Does embedchain automatically create and name a Chroma db collection when you add the first data? If so, what is the collection called?

what is the collection called?

embedchain_store
https://github.com/embedchain/embedchain/blob/8f42ced9b590d30b3abf4303fda5a19e828cc41e/embedchain/vectordb/chroma_db.py#L47C15-L47C15

Tracking this issue with #387. Closing this.


Fix custom labels for the deployable components in production strategy

Which problem is this PR solving?

Resolves #1531

Short description of the changes

We are facing this error because labels generated in the selector fields are different from the labels in the template.metadata.labels. With this PR we are generating the same labels under both sections.

/retest

/retest-required

@hiteshwani29 the linting is failing. You can check what is failing with make ci USER=jaegertracing

/retest-required


Fix frontend visual glitch on create order when no addreeses

Fix frontend visual glitch on create order when no addreeses

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

[ ] Unit test(s)
[ ] Integration test(s)
[ ] Tested manually

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I have checked my code and corrected any misspellings
[X] I have added frontend code and checked it for mobile & desktop

Task linked: CU-862jfdw6t Fix frontend visual glitch on Create Order when no addreeses


Box component - what is the best way of cleaning up props rendered on the dom when using styled?

Describe the bug
I have a box component made using the styled-system props. Its not done via emotion. The problem is that all box props end up on the dom. I am wondering if there is some sort of a clean solution for this that wouldnt require adding tons of extra code to maintain.
To Reproduce
Here is some code you can use to reproduce it
import styled from "styled-components";
import { color, layout, position, space, border, shadow, flexbox, compose, system, textAlign } from "styled-system";

export const BoxStyledProps = compose(space, color, layout, position, border, shadow, flexbox, textAlign);
export const StyledBox = styled.div(BoxStyledProps);

Expected behavior
None of the props I pass to my StyledBox end up on the actual dom
Screenshots

color and height should not be there
Additional context
I know there is some doc about this somewhere, but it really isnt clear on how to actually deal with the situation in the context of using the true power of styled-system props for creating a box

Hello,
related docs are : https://styled-system.com/guides/removing-props-from-html
Docs exposed 2 methods to avoid passing props to HTML. In your case  you need the first one using this package :
npm i @styled-system/should-forward-prop
The docs only mentioned emotion  but it should work with styled-components as well. You need to use this https://styled-components.com/docs/api#shouldforwardprop
styled-system/should-forward-prop give you all props links to styled-system but actually you can also add yours if you need to add more 😄

@marcin-piechaczek thanks this is very helpful :) It does have one disadvantage and that is having to add withConfig to every component that takes in box props.
Is it possible to abstract this somehow?
Lets say I have this in one place
// Box component
export const BoxStyledProps = compose(space, color, layout, position, border, shadow, flexbox, utilProps, textAlign);

and then every component I want to get box props for me has this
const MyOtherComponent = styled.div`
....
  ${BoxStyledProps}
`;

const AnotherComponent = styled.div`
....
  ${BoxStyledProps}
`;

In this example MyOtherComponent and AnotherComponent take in box props, is there a way to not have to add withConfig to both of them and somehow keep it in one place - preferably the Box component?

@LoiKos The shouldForwardProp built into styled-system is for emotion only.

@LoiKos The shouldForwardProp built into styled-system is for emotion only.

it does appear to work in styled too, there is just the problem I mentioned in my previous post

@blurymind You can solve this problem with the @The-Code-Monkey solution mentioned here.
Use your own method to import/export styled with withConfig method.

@The-Code-Monkey yes it is. But i believe it's because the docs have been written before styled-components provide an official way to handle that. When I was looking for withConfig  juste before it was out, the docs was already the same on that parts.
@blurymind to solve your problem instead of using div you can use whatever component you want e.g:
const Wrapper = styled.div.withConfig(**your config goes here**)

const MyOtherComponent = styled(Wrapper)`
....
  ${BoxStyledProps}
`;

const AnotherComponent = styled(Wrapper)`
....
  ${BoxStyledProps}
`;

Another solution is to keep adding withConfigto each component who need it but at least to define a common shouldForwardProp e.g:
// props-blocker.js
import { props } from '@styled-system/should-forward-prop'

const toRemoveProps = [
  ...props,
]  // You can add whatever prop you like here

const regex = new RegExp(`^(${toRemoveProps.join('|')})$`)

const shouldForwardProp = (prop, defaultValidatorFn) => {
  return !regex.test(prop)
}

export { shouldForwardProp }

// ComponentA.js
import {shouldForwardProp} from 'path/to/props-blocker.js'
const ComponentA = styled.div.withConfig({ shouldForwardProp })``

@LoiKos thanks for the suggestions
I want to avoid doing this
const Wrapper = styled.div.withConfig(**your config goes here**)

const MyOtherComponent = styled(Wrapper)`
....
  ${BoxStyledProps}
`;

specifically styling the wrapper which is in itself a styled component noticeably impacts mount time

Sorry not sure to understand your question. You are supposed to provide a callback as shouldForwardProp but unfortunately it's up to styled-component to run it so you can't really control how it will be used.
Depend how it work internally inside Styled-component. Anyway the function you provided in production will never change so i don't think you need to memoize it.

Here is the updated info about using shouldForwardProp with styled-components:
import styled from 'styled-components';
import { space, layout } from 'styled-system';
import shouldForwardProp from '@styled-system/should-forward-prop';

const Wrapper = styled.div.withConfig({
  shouldForwardProp
})`
  ${space};
  ${layout};
  position: relative;
  height: 42px;
  border: 0;
  padding: 0;
  margin-top: 20px;
`;

There are currently no official methods to apply withConfig globally. You can achieve this by making your own "styled" wrapper, but I encountered problems in situations where the styled parameter was another component or an SVG file.


Make ArragAgg (not ordered or distinct) into a UDAF

Which issue does this PR close?
Part of  #8708

Closes #10999.
Rationale for this change

What changes are included in this PR?

Are these changes tested?
Existing tests.

Are there any user-facing changes?
This adds UDAF for ARRAY_AGG when it not disitinct or ordered. The distinct and ordered will be handled in future PRs.

Thanks @eejbyfeldt  and @jayzhan211  -- this PR seems to be failing CI so I am marking it as a draft until that gets sorted out. I am working on reducing the backlog


Is there a generic version change event?

Let's say I have the following:
var db = new Dexie("People");
db.version(1).stores({friends: "++id,name"});

Then I take that same example and update it to:
var db = new Dexie("People");
db.version(2).stores({friends: "++id,name"});

The only thing I've changed is the version number, but is there a way to subscribe to an event that triggers on the just that change when the user refreshes their browser? I know it would be silly to update the version when nothing has changed, but I'm just using this example to help clarify things.

Yes, you can do:
var db = new Dexie("People");
db.version(1).stores({friends: "++id,name"});
db.version(2)
    .stores({friends: "++id,name"})
    .upgrade(function() {
        // Will be triggered if version is below 2.
    });

db.open()
    .catch(function (e) { console.error(e); });

What if I update the 1 to 2, without adding an extra line containing the previous version?

You need to keep all previous versions that may have been installed on any of your clients for dexie to work properly on upgrade.
A future version of Dexie may improve this (if I get the time) so that you don't have to keep old versions but instead parse current version from IDB.

But if nothing has changed in the new version, you don't have to provide each store again. You just need to provide changed, added and deleted stores in the newest version.
If "friends" isnt changed, just do:
var db = new Dexie("People");
db.version(1).stores({friends: "++id,name"});
db.version(2).stores({}).upgrade(function() {
    // Will be triggered if version is below 2.
});

db.open()
    .catch(function (e) { console.error(e); });

Closing


bikeshed watch only shows errors the first time around

Create test.bs:

Title: Test
Status: ED
ED: https://example.com/
Shortname: test
Level: 1
Abstract:
Editor:

interface Int {
  readonly attribute long? service;
  readonly attribute ArrayBuffer? value;
  readonly attribute ArrayBuffer value2;
  attribute ArrayBuffer? value3;
};

Then run bikeshed watch test.bs. Once it finishes building, remove the value3 line and save. You'll get the output:
$ bikeshed watch test.bs
FATAL ERROR: IDL SYNTAX ERROR LINE: 3 - skipped: "readonly attribute ArrayBuffer? value"

FATAL ERROR: IDL SYNTAX ERROR LINE: 5 - skipped: "attribute ArrayBuffer? value3"

==============DONE==============
Source file modified at 15:31:43. Rebuilding...
==============DONE==============

which doesn't show the remaining error on the second build.

Whoops, forgot that I dedup warnings/errors, so you don't get tons of spam messages from a single mistake throughout the doc.  I'm now resetting the cache between watch runs, so it should work.

Fixed now for real. Python's scoping semantics are confusing; using a variable from outside the closure is fine, but assigning to one creates a new local variable instead.
(Also those WebIDL errors are fixed now.)


help!There are some errors when i run a demo.

What version of Go are you using (go version)?

$ 1.9.7

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GOARCH=amd64
set GOBIN=C:\Go\bin
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=D:\gopath
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\DELL\AppData\Local\Temp\go-build397049711=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?
go install in a demo,there ara logs:
# fyne.io/fyne/vendor/golang.org/x/image/vector
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:142: unrecognized instruction "PABSD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:144: unrecognized instruction "PMINUD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:215: unrecognized instruction "PABSD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:217: unrecognized instruction "PMINUD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:330: unrecognized instruction "PABSD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:332: unrecognized instruction "PMINUD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:366: unrecognized instruction "PABSD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:368: unrecognized instruction "PMINUD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:460: unrecognized instruction "PABSD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:462: unrecognized instruction "PMINUD"
..\..\vendor\golang.org\x\image\vector\acc_amd64.s:494: unrecognized instruction "PABSD"
asm: too many errors
# fyne.io/fyne/driver/desktop
..\..\driver\desktop\shortcut.go:21:9: undefined: strings.Builder
# fyne.io/fyne/storage
..\..\storage\uri.go:29:10: undefined: strings.ReplaceAll
..\..\storage\uri.go:30:10: undefined: strings.ReplaceAll
# fyne.io/fyne/vendor/github.com/go-gl/gl/v3.2-core/gl
In file included from D:/MinGW/mingw64/x86_64-w64-mingw32/include/minwindef.h:163,
                 from D:/MinGW/mingw64/x86_64-w64-mingw32/include/windef.h:8,
                 from D:/MinGW/mingw64/x86_64-w64-mingw32/include/windows.h:69,
                 from ..\..\vendor\github.com\go-gl\gl\v3.2-core\gl\package.go:27:
D:/MinGW/mingw64/x86_64-w64-mingw32/include/winnt.h:1554:11: fatal error: x86intrin.h: No such file or directory
 # include <x86intrin.h>
           ^~~~~~~~~~~~~
compilation terminated.
# fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.3/glfw
In file included from D:/MinGW/mingw64/x86_64-w64-mingw32/include/minwindef.h:163,
                 from D:/MinGW/mingw64/x86_64-w64-mingw32/include/windef.h:8,
                 from D:/MinGW/mingw64/x86_64-w64-mingw32/include/windows.h:69,
                 from ./glfw/src/win32_platform.h:68,
                 from ./glfw/src/internal.h:186,
                 from ./glfw/src/context.c:30,
                 from ..\..\vendor\github.com\go-gl\glfw\v3.3\glfw\c_glfw.go:4:
D:/MinGW/mingw64/x86_64-w64-mingw32/include/winnt.h:1554:11: fatal error: x86intrin.h: No such file or directory
 # include <x86intrin.h>
           ^~~~~~~~~~~~~
compilation terminated.
# fyne.io/fyne/layout
..\..\layout\gridlayout.go:63:13: undefined: math.Round

What did you expect to see?
install successfully
What did you see instead?
some errors above

Please update to a recent version (Go1.15 is the latest) and try again. Go1.9 is no longer supported.

I don't think this will ever work on Go 1.9.x. At least three of the compilation errors are due to APIs that were added in Go 1.10+, so I don't think there's anything to be done here. I'm going to close this out.

Please update to a recent version (Go1.15 is the latest) and try again. Go1.9 is no longer supported.

thank you,problem is solved.


Small autorestore issues

I've released a version of Lectrote with autorestore, and it's working pretty good. Thanks! And quote boxes look good too.
A couple of autosave corner cases:

If you quit the game and then close the window (while the blue "game session has ended" banner is showing), the VM should do a null autosave -- that is, delete the autosave file. Then the next game the game is launched, it will from the beginning. ZVM currently doesn't do this.

(You can see the support for this in glkapi.js, at the end of the update() function. If has_exited is true, it calls do_autosave() with a negative argument, which tells Quixe to call Dialog.autosave_write with a null snapshot argument.)

If an autosave occurs inside the Advent.z5 help menu, the autorestore comes back with the output stream set to the wrong window. The effect is that hitting the arrow keys draws the > selection mark in the story window, instead of updating the status window. (But the next time you select a menu option it all gets back on track.)

The zvm.min.js in curiousdannii/lectrote (css branch) fixes the first case, but the second one is still going funny. The > marks now appear in the status window, but they accumulate in the top row instead of being drawn in the correct line as you hit the arrow keys. It looks like the set-cursor-position calls are not working after autorestore?

After fixing this the first time I made a change to the autorestore code which meant that the locals weren't being restored properly. I must have only tested that when line input was active and I think in Inform 6 there weren't any crucial locals in the line input functions. It's fixed now and I've published 1.1.1.


METRON-74: Remove Mysql RPM from Project.

Remove RPM pull from dev.mysql.com.
Also cleaned up a warning and a textural error in ambari_common that I noticed while testing.

+1

+1 this looks good, merging now


Apple/token supply

Description

Checklist

[x] Targeted PR against correct branch.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. #23
[x] Wrote unit tests.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #26 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   63.12%   63.16%   +0.04%
==========================================
  Files           6        7       +1
  Lines         442      448       +6
==========================================
+ Hits          279      283       +4
- Misses        124      125       +1
- Partials       39       40       +1

Impacted Files
Coverage Δ

database/supply.go
66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfe650...a516bf8. Read the comment docs.


'WifiClientSecure' does not name a type

Following this tutorial to try and solve issue with not being able to connect to broker with ESP9266 01 am getting the above error.
http://www.radupascal.com/2016/04/03/esp8266-arduino-iot-hub
So far seems to be only Arduino related libraries that are failing. Python and Node JS work fine. Any ideas anyone.

Hi,
what version of the Arduino IDE are you using? Have you got the right board type selected? Have you tried googling that error message to see how other people have resolved it?
As this is not a problem with the PubSubClient, I'm going to close this issue.

The latest, yes, yes and the only thing says use latest version I have the latest version.

The issue was actually a spelling mistake in the code on the following article the F was lower case all good.
http://www.radupascal.com/2016/04/03/esp8266-arduino-iot-hub


docs: only render DocSearch when algolia keys are set

Description
We just recently merged a PR to add search to the Paragon documentation website, via Algolia DocSearch. However, there seems to be an issue with the environment variables configured in Netlify where they are not getting picked up (they are coming back as undefined).
To prevent a temporarily broken search from being on production, this PR will hide DocSearch until there are valid Algolia environment variables coming through.
This will also prevent search from appearing on the PR deploy previews, where the environment variables configured in Netlify are not applied.
Also included in this PR, though, is an attempt to fix the environment variables. Because the docs site is using Gatsby, we may actually need to prefix the environment variables with GATSBY_ (docs) so they are accessible at runtime. By default, in Gatsby, environment variables are only available at build time, which is why the SEGMENT_KEY environment variable works as expected.
The previous environment variables, when defined in .env.development during local development, works because they are explicitly sourced via dotenv in gatsby-config.js?
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

:tada: This PR is included in version 19.25.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


command-preview block cursor refresh of cmdline when move

Describe the bug
When enter a command with command-preview like :s/foo/bar, the cursor of cmdline will not refresh when move, until insert or delete.
Which version of Neovim are you using?
NVIM v0.9.0-dev-150+g2f9b94a26
To Reproduce
Steps to reproduce the behavior:

Enter a command with command-preview like :s/foo/bar,
Try move cursor.

Expected Behavior
The cursor will refresh.
Screenshots
https://user-images.githubusercontent.com/40141251/197363853-cfffcb7c-94ff-44fd-8e6e-55c9ba371509.mov
Noice Log
No log during reproducing.

That's a known issue on the Neovim side. See the tracking issue for noice. It's a problem with substitute, seems to work fine with other command preview stuff

https://github.com/neovim/neovim/issues/20463

My bad, forget to check known issues.

Seems like this is happening again when using noice with inc-rename on NVIM v0.11.0-dev-168+ge20c5fba2c.

Yes indeed. changing the cmdline is working correctly during substitute on nightly, but moving does not.
feel free to post an issue upstream.

Seems to be fixed now, thanks @folke!

Yes indeed! We're using real (fake) cursors now in noice.
It uses the Neovim API to draw the real cursor in the noice windows, but it's still fake, since those windows are not the current window.
Only drawback is that if a redraw happens somewhere not by noice, then the cursor may disappear (briefly).


perf(rpc): use gogoproto codec

What this PR does
Official grpc-go has not been compatible with gogoproto since
https://github.com/grpc/grpc-go/pull/3958. To use gogoproto's marshaler and unmarshaler, a custom
codec should be registered.
A simple benchmark show it worth:
name          old time/op    new time/op    delta
StreamRPC-16    7.49µs ± 3%    6.98µs ± 5%  -6.85%  (p=0.000 n=20+20)

name          old alloc/op   new alloc/op   delta
StreamRPC-16    16.4kB ± 0%    16.4kB ± 0%  -0.24%  (p=0.000 n=20+20)

name          old allocs/op  new allocs/op  delta
StreamRPC-16      51.0 ± 0%      49.0 ± 0%  -3.92%  (p=0.000 n=19+17)

Which issue(s) this PR resolves
Resolves #235
Anything else
Links:

https://github.com/grpc/grpc-go/pull/3958
https://github.com/grpc/grpc-go/issues/4466

Codecov Report
Base: 63.09% // Head: 63.11% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (ff7b4c2) compared to base (d61b9e5).
Patch coverage: 22.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   63.09%   63.11%   +0.02%
==========================================
  Files         130      131       +1
  Lines       17409    17427      +18
==========================================
+ Hits        10984    10999      +15
- Misses       5864     5871       +7
+ Partials      561      557       -4

Impacted Files
Coverage Δ

pkg/rpc/codec.go
22.22% <22.22%> (ø)

internal/metarepos/raft_logger.go
33.33% <0.00%> (-33.34%)
:arrow_down:

internal/storagenode/logstream/executor.go
75.75% <0.00%> (-1.70%)
:arrow_down:

internal/storagenode/storagenode.go
68.94% <0.00%> (-0.35%)
:arrow_down:

internal/metarepos/report_collector.go
77.42% <0.00%> (ø)

internal/metarepos/storage.go
78.99% <0.00%> (+0.38%)
:arrow_up:

...metarepos/dummy_storagenode_client_factory_impl.go
63.90% <0.00%> (+1.32%)
:arrow_up:

internal/storagenode/logstream/committer.go
81.03% <0.00%> (+2.41%)
:arrow_up:

pkg/mrc/mrconnector/mr_connector.go
75.95% <0.00%> (+2.67%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

We need more investigation into this. For now, I will close it.


x/build: skip darwin-386-10_14 builder on release-branch.go1.12

As far as I can tell, the darwin-386-10_14 builder was added for #31751 and has been failing for release-branch.go1.12 ever since.
I doubt we'll want to fix a deprecated architecture on an old Go version, so we should skip the builder in that configuration instead.
CC @golang/osp-team

I can take a look into this.

@dmitshur, I notice that this builder is currently showing up in the build dashboard for release-branch.go1.12. I assume that's an expected wart after https://golang.org/cl/199878 (with the fix gated on the app/appengine / cmd/coordinator cleanup)?

@bcmills That is correct.
I think it is a low priority enough wart that it can wait a few weeks (compared to the master branch of the main Go repo, I didn't think that could wait as long), but let me know if you think it's more disruptive and should be fixed sooner.


[zuul] Update irrelevant files for osp18 tests

Don't run tests on changes to the roles that aren't run

This update can be seen working in:

https://github.com/infrawatch/feature-verification-tests/pull/176
https://github.com/infrawatch/feature-verification-tests/pull/175
https://github.com/infrawatch/feature-verification-tests/pull/174


Carthage tvOS

Carthage update skips RxAlamofire with error:

Dependency "RxAlamofire" has no shared framework schemes for any of the platforms: tvOS

Project has tvOS target, but it is not shared. Any reason for this.

I think this is fixed.


Added Images

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@Eme-rald, thank you for taking the time to improve this section of the guide. Great effort here, but the changes you've made here would mean that the actual Bootstrap buttons won't show on https://guide.freecodecamp.org/bootstrap/buttons, so I'll have to close this. However, please feel free to help us improve other sections of the guide. Happy coding! :+1:


error: ‘pthread_setname_np’ was not declared in this scope

What version of gRPC and what language are you using?
gRPC v1.20.0
What operating system (Linux, Windows,...) and version?
Linux,  SUSE Linux Enterprise Server 11 (x86_64)
What runtime / compiler are you using (e.g. python version or version of gcc)
GCC v6.3.1
What did you do?
I tried to build the gRPC on the aforementioned system.
What did you expect to see?
I expected the build to complete.
What did you see instead?
<long path>/grpc-1.20.0/src/core/lib/gprpp/thd_posix.cc: In lambda function:
<long path>/grpc-1.20.0/src/core/lib/gprpp/thd_posix.cc:99:67: error: ‘pthread_setname_np’ was not declared in this scope
                             pthread_setname_np(pthread_self(), buf);
                                                                   ^
make[2]: *** [CMakeFiles/gpr.dir/src/core/lib/gprpp/thd_posix.cc.o] Error 1

Anything else we should know about your project / environment?
The function pthread_setname_np() is not available on an older GLIBC.  It was introduced in glibc 2.12.
This patch/workaround worked for me:
--- a/include/grpc/impl/codegen/port_platform.h
+++ b/include/grpc/impl/codegen/port_platform.h
@@ -176,7 +176,7 @@
 #else /* _LP64 */
 #define GPR_ARCH_32 1
 #endif /* _LP64 */
-#ifdef __GLIBC__
+#if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 12
 #define GPR_POSIX_CRASH_HANDLER 1
 #define GPR_LINUX_PTHREAD_NAME 1
 #include <linux/version.h>

Feel free to transform your small patch into a pull request.


Create listing - max listing size help text

Checklist:

[x] Test your work and double-check to confirm that you didn't break anything
[x] Wrap any new text/strings for translation

Description:

Add help text saying 'Total listing size may not exceed 2MB'
Localize all strings in the image-upload component

Issue: https://github.com/OriginProtocol/origin-dapp/issues/410

@micahalcorn - the issue https://github.com/OriginProtocol/origin-dapp/issues/410 didn't have a super-clear task in it, so I took a whack at it. LMK if you have/had other ideas for this one.

@jordajm it looks like there may actually be more work to do here than I realized. 😇 I glossed over the current state of this implementation. It's still frustrating to have to deal with calculating the combined image sizes + some unknown size of the other form data. Can you look into https://github.com/OriginProtocol/origin-dapp/issues/489 and see if it's reasonable to quickly change the size validation to allow multiple 1.5MB images, for example? I also think that it might be helpful to give an in-form error rather than waiting for the user to click "Continue" before informing them that the data is too large, but that's not critical.


VRT Information

Opting to get legal aid to verify the language before merging this PR.

@littledivy @johnletey @martonlederer @maximousblk could one or two of you guys review this for me?
After some discussion, this verbage should be okay.