EIP712 message UX/UI

Can you please make it look nice so that before clicking Sign the user can copy & paste values from the signature so that it is easier to double-check everything?
The EIP712 Message looks hideous. Here is an example of the EIP712 Permit message on CowSwap.

Hello! We have plans about a complete redesign of WalletConnect UI soon. Thank you.


peer-exchange browser feedback

This PR is meant to track the feedback and dial errors encountered via peer exchange on browser using the web-chat example, and is part of the milestone https://github.com/waku-org/js-waku/issues/1429 and https://github.com/waku-org/js-waku/issues/1326
Related:

https://github.com/waku-org/js-waku/issues/1309
https://discord.com/channels/1110799176264056863/1111541029309534249/1136633301386412062

After some time I got.
Peers Discovered: 126
Bootstrap: 2 Peer Exchange: 124
Peers Connected: 18
Bootstrap: 2 Peer Exchange: 16
and mostly WSS errors.

Left for a long time and noticed below.

Only logs were errors like below
The connection to wss://node-02.gc-us-central1-a.status.prod.statusim.net/p2p/16Uiu2HAmDQugwDHM3YeUp86iGjrUvbdw3JPRgikC7YoGBsT2ymMg was interrupted while the page was loading.

@mfw78 what's the setup on dappnode? I see some ws error, can we ensure that nwaku is configured using wss by default?

I am getting
 Firefox can’t establish a connection to the server at wss://node-01.do-ams3.wakuv2.prod.statusim.net:8000/p2p/16Uiu2HAmL5okWopX7NqZWBUKVqW8iUxCEmd5GMHLVPwCgzYzQv3e.
 Firefox can’t establish a connection to the server at wss://node-01.gc-us-central1-a.wakuv2.prod.statusim.net:8000/p2p/16Uiu2HAmVkKntsECaYfefR1V2yCR79CegLATuTPE6B9TxgxBiiiA.

Despite node connections being quite low: https://grafana.infra.status.im/d/qrp_ZCTGz/nim-waku-v2?orgId=1&refresh=30s&var-host=node-.*&var-fleet=wakuv2.test&var-fleet=wakuv2.prod&var-dc=All&from=now-2d&to=now&viewPanel=2&editPanel=2
Do we not log our own PeerId? Needed to investigate on nwaku side.

Same in Brave:
main.10c2788a.js:1 waku:peer-discovery-dns Use following EIP-1459 ENR Tree URLs:  +0ms<EMAIL_ADDRESS>15:12:55.436 main.10c2788a.js:1 waku:peer-discovery-dns Starting peer discovery via dns +84ms
15:12:55.440 main.10c2788a.js:1 waku:peer-exchange-discovery Starting peer exchange node discovery, discovering peers +0ms
15:12:55.961 main.10c2788a.js:1 waku:discovery:fetch_nodes got new peer candidate from DNS<EMAIL_ADDRESS>+0ms
15:12:56.122 main.10c2788a.js:1 waku:discovery:fetch_nodes got new peer candidate from DNS<EMAIL_ADDRESS>+161ms
15:12:56.133 main.10c2788a.js:1 waku:waku Waku node created +0ms 12D3KooWRSPam6T7v1WV7pw4BTdzbfN9mcxLekZspnHp4XZeFrnS relay: false, store: true, light push: true, filter: true
15:12:56.134 main.10c2788a.js:1 waku:connection-manager Connection Manager is now running +0ms
15:12:56.212 main.10c2788a.js:1 waku:connection-manager Dialing peer 16Uiu2HAmL5okWopX7NqZWBUKVqW8iUxCEmd5GMHLVPwCgzYzQv3e on attempt 1 +78ms
15:12:56.214 main.10c2788a.js:1 waku:connection-manager Dialing peer 16Uiu2HAm4v86W3bmT1BiH6oSPzcsSr24iDQpSN5Qa992BCjjwgrD on attempt 1 +1ms
15:13:26.156 main.10c2788a.js:1 WebSocket connection to 'wss://node-01.ac-cn-hongkong-c.wakuv2.prod.statusim.net:8000/p2p/16Uiu2HAm4v86W3bmT1BiH6oSPzcsSr24iDQpSN5Qa992BCjjwgrD' failed: WebSocket is closed before the connection is established.
(anonymous) @ main.10c2788a.js:1
close @ main.10c2788a.js:1
a @ main.10c2788a.js:1
r @ main.10c2788a.js:1
r @ main.10c2788a.js:1
15:13:26.160 main.10c2788a.js:1 waku:connection-manager Error dialing peer 16Uiu2HAm4v86W3bmT1BiH6oSPzcsSr24iDQpSN5Qa992BCjjwgrD - The operation was aborted +30s
15:13:26.161 main.10c2788a.js:1 waku:connection-manager Dialing peer 16Uiu2HAm4v86W3bmT1BiH6oSPzcsSr24iDQpSN5Qa992BCjjwgrD on attempt 2 +1ms
15:13:26.171 main.10c2788a.js:1 WebSocket connection to 'wss://node-01.do-ams3.wakuv2.prod.statusim.net:8000/p2p/16Uiu2HAmL5okWopX7NqZWBUKVqW8iUxCEmd5GMHLVPwCgzYzQv3e' failed: WebSocket is closed before the connection is established.
(anonymous) @ main.10c2788a.js:1
close @ main.10c2788a.js:1
a @ main.10c2788a.js:1
r @ main.10c2788a.js:1
r @ main.10c2788a.js:1
15:13:26.172 main.10c2788a.js:1 waku:connection-manager Error dialing peer 16Uiu2HAmL5okWopX7NqZWBUKVqW8iUxCEmd5GMHLVPwCgzYzQv3e - The operation was aborted +11ms
15:13:26.172 main.10c2788a.js:1 waku:connection-manager Dialing peer 16Uiu2HAmL5okWopX7NqZWBUKVqW8iUxCEmd5GMHLVPwCgzYzQv3e on attempt 2 +0ms

@mfw78 what's the setup on dappnode? I see some ws error, can we ensure that nwaku is configured using wss by default?

nwaku actually runs as ws, and not wss as TLS is handled by a proxy within dappnode. This proxy is responsible for auto-configuring over the SSL certificates etc.

@mfw78 what's the setup on dappnode? I see some ws error, can we ensure that nwaku is configured using wss by default?

nwaku actually runs as ws, and not wss as TLS is handled by a proxy within dappnode. This proxy is responsible for auto-configuring over the SSL certificates etc.

Fair but is nwaku in dappnode configured so that it advertised itself using the wss proxy multiaddr and NOT the ws one? looks like it ain't happening sometimes.

Regarding dappnode, we can open an orphan issue for now and track with @mfw78 to understand what can be done.
What is the second issue about? I'd suggest we investigate a bit more before considering peer exchange as done.

Some more feedback:

Peers Connected on right and left do not always match, especially on mobile
Are Peers Discovered only wss peers?

* `Error: Error occurred during XX handshake: Error occurred while verifying signed payload: Payload identity key does not match expected remote peer`

Interestingly enough this is a fleet peer:
common.js:113 libp2p:connection-manager:dial-queue:error error during dial of /dns4/node-01.gc-us-central1-a.wakuv2.prod.statusim.net/tcp/8000/wss/p2p/16Uiu2HAmVkKntsECaYfefR1V2yCR79CegLATuTPE6B9TxgxBiiiA/p2p/16Uiu2HAmEhN1JUTSVau1xf71a8z7web8b7kTMv2xZD6JwJ8UT19q +948ms CodeError: Error: Error occurred during XX handshake: Error occurred while verifying signed payload: Payload identity key 16Uiu2HAmVkKntsECaYfefR1V2yCR79CegLATuTPE6B9TxgxBiiiA does not match expected remote peer 16Uiu2HAmEhN1JUTSVau1xf71a8z7web8b7kTMv2xZD6JwJ8UT19q

so we should investigate as part of peer exchange milestone.

Actually, if js-waku can connect to a Status desktop node via a fleet node thanks to rendezvous to consume filter and lightpush that would be beneficial.
While the js-waku node would still hog a connection on the fleet (rendezvous) node and take bandwidth (but only to send messages and receive messages on specific content topic), the usage of memory resources to hold the subscription would be delegated to the Status Desktop node. I assume it would not consume one more connection on the status desktop node either as the connection to the rendezvous node is re-used.
@richard-ramos @waku-org/research is my analysis corect?

Note that peer exchange can be tracked in a browser scalability milestone yet to be created.

That is a very nice idea @fryorcraken . This way the load of light clients can be distributed to the nodes in the network rather than just the fleets making it more decentralized.

Wrt connection, same libp2p connection will be reused for multiple protocols as it is the same peer.

Actually, if js-waku can connect to a Status desktop node via a fleet node thanks to rendezvous to consume filter and lightpush that would be beneficial.

Agree here that connecting to distributed nodes for filter and lightpush is beneficial. Currently Status Desktop nodes do the same. What I'm confused about is why this necessarily has to be discovered via rendezvous? Status Desktop nodes are discoverable in most cases via discv5 and peer exchange. For now, we suggest peer exchange as better discovery mechanism than rendezvous, as it's less prone to neighbourhood-effects. Rendezvous is useful to discover nodes behind a NAT and coordinating a hole punch.

I think. Is that even the correct multiaddr format for rendezvous? cc @richard-ramos

This is not a correct multiaddress format as it is missing the p2p-circuit component. Where is this address from?

I assume it would not consume one more connection on the status desktop node either as the connection to the rendezvous node is re-used.

yeah, libp2p does stream multiplexing, so a single connection can be reused for multiple protocols

@jm-clius my bad, wherever I said "rendezvous" I actually meant "p2p-circuit" Thanks @richard-ramos for jumping in.

This is not a correct multiaddress format as it is missing the p2p-circuit component. Where is this address from?

Maybe older Status Desktop versions? Would be good to see if we successfully find and connect to p2p-circuit addresses via peer exchange cc @danisharora099

@danisharora099 let me know if i can help. FWIW the go-waku test/prod fleets should have circuit relay enabled so maybe they can be used to force an scenario win which p2p circuit addresses appear in peer exchange.


How can we integrate kroki,mermaid diagrams in starlight

What version of starlight are you using?
0.21.2
What version of astro are you using?
4.5.9
What package manager are you using?
pnpm
What operating system are you using?
Linux
What browser are you using?
Chrome
Describe the Bug
How can we integrate kroki,mermaid diagrams in starlight.
We have tried by adding some packages, but it is not working and gets displayed as plain text.
Link to Minimal Reproducible Example
.
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for your report.
Mermaid support is something that has been discussed in this specific discussion with various opinions, alternatives and suggestions.
I'd like to also specific highlight this post from the same discussion which is a step-by-step guide on how to integrate Mermaid diagrams in Starlight using rehype-mermaid.
Considering the above, I'm closing this issue and if you have any further questions or need help, feel free to ask in this discussion or even join the #starlight channel in the Astro Discord.


Suggestion: Show current chain and allow user to change chain

the UI doesn't show what chain i'm connected (i understand it's connected to kovan because it added encrypted keys after i created an account to the ~/Library/Application Support/io.parity.ethereum/keys/kovan folder on my computer)
it doesn't give me the option to change chain (i.e. from kovan and mainnet)
it doesn't show me a help icon with step-by-step instructions on how to manually change chains from the CLI if i'm a developer
after clicking an account that i've created, if i click "Add tokens" and enter say "dot" to search for DOT tokens, it returns no results or feedback, such as a suggestion to change to a different chain

Valid concern. This is a feature (for now). We do not want people to think about this. It will be launched as an alpha on Kovan. Later on, on Mainnet (beta?). We want to make it easy for beginner users, and they should not care about Kovan IMO.
Could be a good feature for later releases

I think that as long as Fether's functionality is limited to sending ETH/tokens and showing account balances, it is fine that Fether doesn't offer chain selection. Perhaps we should publish two binaries though:

alpha/beta: kovan only
beta/stable: mainnet only


Delete button for product is misplaced

And why we're using this 3 dots as an icon for menu, even when there is only one option?

Overflow menu is by design, we don't want to offer remove directly.

It's already fixed.


⚠ Jenkins Plugins Artifactory has degraded performance

In e3bb269, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1309 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 09edd08 after 20 minutes.


Add noscript tags for fallback content

The fallback message should be seen only when JavaScript fails to load. Currently, if the app loads on a slow network, it is displayed. I added the tags outside the root element, as seen in the create-react-app template.

If we're going to do something like that, I'd prefer we have something like:

  For full functionality of this site it is necessary to enable JavaScript.
  Here are the instructions how to enable JavaScript in your web browser.


Accept TodoItem Id from query string

Hi team,
I moved this from here: https://github.com/aspnet/AspNetCore.Docs.it-it/issues/44
@belfed commented 23 hours ago
Hello,
I'm really new to ASP.NET (Core and Standard) and I came accross this guide, that is what I was looking for. I wanted to ask this: what if, using the same API, I'd want client applications to get a TodoItem with the Id passed as a query string parameter?
This is what I mean:
http://localhost:5000/api/TodoItems?Id=1
I searched for explainations about this and everything I found isn't working. I tried with [FromQuery] attribute, changing the HttpGet content, using Route attribute, nothing is working. Can you please explain how can I achieve this?
Thank you very much for the help.

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.


Backport of PR #3742

What does this PR (Pull Request) do?
Backports the fixes from PR #3742
Which Traffic Control components are affected by this PR?

Documentation
Traffic Ops

What is the best way to verify this PR?
See #3742
If this is a bug fix, what versions of Traffic Ops are affected?
see #3742
The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4000/
Test PASSed.

Technically, we can't backport something that hasn't been merged to master yet, since the commit message should reference the commit hash of the commit that the backport is cherry-picked from (via the -x to git cherry-pick.

Oh, well I'd make this a draft if I could. I guess the best I can do is say "don't merge until #3742 is merged".
Can I fix conflicts from a cherry-pick? Because the docs I edited in #3742 don't exist in 3.x

Yeah, if there are conflicts when a cherry-pick is done, it's basically the same process as addressing merge conflicts when doing a rebase. You can prefix the title with DO NOT MERGE if you want, that usually gets the point across.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4048/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4065/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4109/
Test PASSed.


feat(helm): Add option to deploy extra containers to remaining deployments

SUMMARY
Note: this completes #25783
Adds extraContainers to remaining deployments.
This is required if for example connecting to an external database using the Cloud SQL Auth Proxy as a sidecar.

Rebased. Can we please merge this asap ? Thanks !


cmd/compile: linux/s390x: inlining bug in s390x

Go version
Go 1.21.4
What operating system and processor architecture are you using (go env)?
GO111MODULE=''
GOARCH='s390x'
GOBIN=''
GOCACHE='/home/tolsen/.cache/go-build'
GOENV='/home/tolsen/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='s390x'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/tolsen/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/tolsen/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/golang/go1.21.4'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/opt/golang/go1.21.4/pkg/tool/linux_s390x'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -march=z196 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build156610009=/tmp/go-build -gno-record-gcc-switches'

What did you do?
https://go.dev/play/p/d9uIJAd1yEr
What did you expect to see?
ABCDEF12
ABCDEF12
What did you see instead?
ABCDEF12
ABCDEF12000000
( Note that go.dev/play gives the correct answer; presumably because it is not running on Linux/s390x )

Also note that this problem is not present in Go 1.20.11

Just confirmed it also happens with ppc64

cc @golang/s390x

Hm, I'm having trouble seeing the problem here.
GOOS=linux GOARCH=s390x go1.21.4/bin/go build -gcflags=-S ~/gowork/issue64468.go

Produces assembly for main.main that just has 2 identical blocks calling the runtime.print functions with identical args. I don't see how that could possibly generate different print outputs.
Unless there is a bug in print. Or this is a bug in the compiler when run on the platform. I will try to reproduce that way. Anyone who reproduced, can you also reproduce when cross-compiling from amd64 or arm64?

Not a cross-compile, but IBM has confirmed the bug w/ details on the assembly/ML : https://groups.google.com/g/golang-nuts/c/TYGuzUTTsN8/m/pHwtGqo8AAAJ

I can reproduce on the ppc64 platform. For some reason, inlining happens differently when on platform then when cross compiling. (That's a separate issue which I will investigate - the toolchain should generate identical assembly no matter the platform.)
I think I see the bug, something wrong with the memcombine pass with big-endian and elements bigger than a byte.

@gopherbot please open a backport issue for 1.21.
This is a pretty serious miscompilation with no easy workaround.


1.8.1 Normal 1.8.2 low numbers don't seem correct on Flemish Meter

Great plugin!
Worked out of the box on my Flemish meter!
The only minor thing that looks slightly off is the day and night totals.
Flemish meters have 4 counters:

1.8.1 Dag Afname
1.8.2 Nacht Afname
2.8.1 Dag Injectie
2.8.2 Nacht Injectie
The numbers in the Eve app don't seem to correspond with these.

Strictly speaking, 1.8.1 and 2.8.1 are tariff 1; and 1.8.2 and 2.8.2 are tariff 2.  In the Netherlands, tariff 1 is low (night), and tariff 2 is normal (day).  I understand in Flandres, it’s the other way round.
What do you mean the numbers don't correspond?

Are they different numbers altogether?  In that case: did you refresh the screen in the Eve app?  Did you check the Homebridge log?  Are the numbers correct there?; or
Are they mixed up (Normal showing the night value and Low showing the day value)?  In that case, please list the telegram as reported by Homebridge P1 during startup.

According to my meter,
These are my numbers right now:
1.8.1 Dag Afname : 3,953
1.8.2 Nacht Afname : 24,865
2.8.1 Dag Injectie : 29,496
2.8.2 Nacht Injectie : 1,095
In te Eve app, for the "afname", i get:
Total consumption : 29,10
Total consumption Low : 15,6
Total consumption Normal : 2,3
In the homebridge log, it looks like the totals are only printed now and then for "Electricity delivered" & "Gas".
Not for "Electricity".

After a restart of the plugin, and refreshing my Eve app, the numbers now seem updated. My bad!
Thanks again for the great plugin!


Allow setting Squid's max file descriptors

Under heavy load Squid may need to open more file descriptors than the
default limit of 1024. According to Red Hat best practices, the max
file descriptors number should be increased like this.

+1


Empty aggregateRating Issue

Traceback (most recent call last):
  File "C:\Users\user\react\letterboxdwatchlist\backend\api.py", line 17, in <module>
    movie_instance = movie.Movie("eline-vere")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\letterboxdpy\movie.py", line 27, in __init__
    self.movie_rating(dom, script)
  File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\letterboxdpy\movie.py", line 56, in movie_rating
    script['aggregateRating']['ratingValue'] if script else None
    ~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'aggregateRating'

Movie link: https://letterboxd.com/film/eline-vere/
I am on latest git version
pip install git+https://github.com/nmcassa/letterboxdpy.git
To reproduce
from letterboxdpy import movie
movie_instance = movie.Movie("eline-vere")
print(movie_instance)

I think there should be a check whether a movie has a rating or not.

Indeed, I had been considering alternative approaches for these use cases. For now, I've set the default to None.
    # letterboxd.com/film/?
    def movie_rating(self, dom, script: dict=None) -> float:
        elem = dom.find('span', attrs={'class': 'average-rating'})
        rating = elem.text if elem else None
        try:
            rating = rating if rating else (
                script['aggregateRating']['ratingValue'] if script else None
                )
            self.rating = float(rating)
        except KeyError:
            self.rating = None

In the future, I'll try to calculate something over the rating-histogram-bars and see if the ratios are consistent.

Thanks for the report!

Thanks that problem is solved after the change you posted.
But, I found another edge case with this movie. https://letterboxd.com/film/romeo-julie-a-tma/
  File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\letterboxdpy\movie.py", line 123, in movie_popular_reviews
    data = data.find_all("div", {"class": ["film-detail-content"], })
           ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'find_all'

# letterboxd.com/film/?
def movie_popular_reviews(self, dom) -> dict:
    data = dom.find("ul", {"class": ["film-popular-review"]})
    items = data.find_all("div", {"class": ["film-detail-content"]}) if data else []

    self.popular_reviews = []
    for item in items:
        curr = {}

        owner = item.find("strong", {"class": ["name"], })
        rating = item.find("span", {"class": ['rating'], })
        review = item.find("div", {"class": ['body-text'], }).p

        curr['reviewer'] = owner.text if owner else None
        curr['rating'] = rating.text if rating else None
        curr['review'] = review.text if review else None

        self.popular_reviews.append(curr)

https://github.com/FastFingertips/fork.letterboxdpy/commit/50449f4a4ae52e4ec827d52a5c18c09256fa6d26#diff-f94f83537966af10a02e071769a592be1cfe5e23722786dfc203325f5b4cad63R101-R117

For faster responses, you can test using my repository(https://github.com/nmcassa/letterboxdpy/pull/26).
pip install git+https://github.com/fastfingertips/fork.letterboxdpy.git --force


Error parsing Jellyfin response.

I/flutter (23107): ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
I/flutter (23107): │ #0   _MainMenuState.build.<anonymous closure> (package:jellybook/screens/MainScreens/mainMenu.dart:512:26)
I/flutter (23107): │ #1   _FutureBuilderState.build (package:flutter/src/widgets/async.dart:616:55)
I/flutter (23107): ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
I/flutter (23107): │ ⛔ Error: FormatException: Unexpected character (at character 1)
I/flutter (23107): │ ⛔ <html>
I/flutter (23107): │ ⛔ ^
I/flutter (23107): │ ⛔
I/flutter (23107): └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

I got an error status 400 (bad request). So authentication works but somehow it the request is not being able to be processed by Jellyfin server. I did not found anything in Jellyfin logs.
As concept I have created an automatic Jellifin client generation with openapi_generator plugin based on the specs from version 10.8.8 from https://api.jellyfin.org/openapi/.
I had no time to test it, but if the automatic client works, the openapi.json file can be edited with a sub set of methods that are useful for Jellybook only.
The branch with the changes is here: https://github.com/jpuerto/JellyBook/tree/openapi-client

I'll take a look into a openapi generated API. I think what might be better to do is to have all the modules there and as a package and then have it used as a dependency in this project. will have to explore further tho.

I'll take a look into a openapi generated API. I think what might be better to do is to have all the modules there and as a package and then have it used as a dependency in this project. will have to explore further tho.

I think it could be a good help, I have used a similar approach in others projects with great results. I created it because I realized that the Jellifin REST API documentation is really bad. Even the openapi specs are invalid (I had to fix it locally).
Anyway, it seems to be working fine with the patch I created. Problem seems to be when populating the "Host" header if the URL contains a subpath, like it is my case. It should work fine for all cases now.


Add Models::AlwaysDestroyable/NotDestroyable/ValidateDestroy

This brings in Models, which requires in Models::NotDestroyable,
Models::AlwaysDestroyable and Models::ValidateDestroy. These
mix-ins provide special handling and validations for destroying
domain models.
Note: This also brings in ActiveRecord which was needed in this
effort to support destroy! and destroyable? methods in the
Models::ValidateDestroy mix-in.

@nweathersbee can you be sure to change the name of the PR and the original comment message to not say "Models::" and instead say "Records::"?


Not Live in IE 11 or Microsoft Edge

Hi Chris
The gem is failing to update in IE 11 or Microsoft Edge. No error message.
Let me know if there is anything you need. I have Windows 8.1 and 10 and Edge and IE.
Thanks.
JS

This was a local configuration issue involving Faye and my network. Not important.


fix: Set the environment for local evaluation mode on init

Changes
This sets up the environment for the first time before booting the update cycle. This avoids a failure where waiting on a network request in one thread allows the primary thread to attempt to get flags before the local cache is set.

Sorry @zachaysan looks like some big PRs got merged so you've got some conflicts here. Thankfully just in the tests!

@zachaysan I handled the conflicts here.


Minor: fix tz in NowFunc

Which issue does this PR close?

Closes #10957.
Rationale for this change

Timezone was specified as "+00:00" instead of "UTC". This caused a missmatch in temporal_coercion.
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb PTAL.
Since "+00:00" and "UTC" are the same - I think this is okay? Perhaps, there might me some docs that need some updates to clarify the behavior or documented the supported timezones?

I responded on https://github.com/apache/datafusion/issues/10957#issuecomment-2176332944

Since "+00:00" and "UTC" are the 'same' - is this viable? Or do we have to extend the logic here in order to provide both variants (and possibly not introduce a breaking change)?

+1 on including type coercion logic for "UTC" and "+00:00" and leaving the signature of NowFunc unchanged. This would fix the error descrined in https://github.com/apache/datafusion/issues/10957 more generally without introducing any breaking changes

...I'm not sure what went wrong with the branch here - I didn't want to close this. I'll reopen (yet...) another PR with the adjusted type coercion. I might need some help here to construct a proper sqllogictest to test this.

...perhaps someone can help me out on this. I still haven't found a way to create a timestamp with timezone in order to create a proper sqllogictest.

...perhaps someone can help me out on this. I still haven't found a way to create a timestamp with timezone in order to create a proper sqllogictest.

There are some examples here: https://github.com/apache/datafusion/issues/10602
You can also use arrow_cast (there are some examples here https://datafusion.apache.org/user-guide/sql/scalar_functions.html#arrow-cast)

I think this should be fixed now. I added some sqllogictest as well to validate the new behavior - thanks @alamb for the pointer on arrow_cast. PTAL @alamb @erratic-pattern

I added some additional comments and merged up from main.
@erratic-pattern  if you have time, it would be great if you could review this PR as well

Thanks everyone!


Fix unused hide var

Fixes #5

Re-opening for circle trigger

Codecov Report

Merging #6 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   99.22%   99.21%   -0.01%
==========================================
  Files           6        5       -1
  Lines         129      128       -1
==========================================
- Hits          128      127       -1
  Misses          1        1

Impacted Files
Coverage Δ

src/init.js
83.33% <50%> (-16.67%)
:arrow_down:

bin/opencollective.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec2425...4ab7294. Read the comment docs.

@nojhamster 	Looking good so far. Could you add a test that covers the change? :relaxed:

@manniL Added a test to cover the change. I added some hooks in order to reset fetch-mock history, so that we can assert that fetch is not called when not needed.

@nojhamster 	many thanks!


Bump goodkey, fix breakage

Summary
This fixes a breaking API change upstream:
https://github.com/letsencrypt/boulder/pull/7543
I believe the behavior is equivalent, but I am not a cryptography expert, so please let me know if this isn't quite right.
Release Note
NONE
Documentation

Forgot to run go mod tidy, PTAL.

@jonjohnsonjr i've update the pr to sync the go mod to the kms part

I don't mind at all, thanks!


docs: fixes for some issues I found

When going through the docs noticed some issues and inaccuracies. These are the ones I was able to fix on my own.

@fabis94, this looks good - feel free to merge away!


Implement for statement ast_dumper

Parse for statement
Implement for statement ast_dumper
Bump build version to C++17

Please note that even if step is evaluated after each statement execution, we still dump and typecheck step before loop_body. It will only affect the order when generating assembly code.

Is there a test case of the for statement with a expression clause?

I added one.


Add Web-Assets Support

I assume this is related to being able to load the fonts as we discussed?

I assume this is related to being able to load the fonts as we discussed? It could be simpler to save the font and host it with the bot. Either as the font file itself or base64 encoded!

the fonts will be loaded via Base64 #125 , the webAsset is for loading remote background.
@pavlovcik


[Bug]: Failure to pull licenses can causing multiple pre/post commits to fail

What happened?
The license pulling step in multiple testing workflows can fail when pulling from external sites if they go down. This prevents these suites from running on both snapshots and pull requests, making it harder to identify real breakages.
Issue Priority
Priority: 2
Issue Component
Component: test-failures

Site is back up

Is there something we can/should do to alleviate this?

The ideal solution is to keep a static collection of the licenses in the repo so we aren't pulling them every single time IMO

I'd be slightly concerned that they could get out of date. I'm not sure how important that is though.
We could have a process for pulling licenses from the source of truth periodically. One possibility:

Modify the current script to place licenses in the repo, and commit them.
Modify other jobs to reference the licenses committed to the repo.
Define a postcommit that pulls the license scripts and verifies they haven't changed. A failure will alert us that we need to re-generate.
(optional) We might also double-check the licenses in the release process, maybe that just means running the postcommit (along with all the others) on the release branch


[HUDI-6563] support projection push down for lookup join and fix look…

support projection push down for lookup join and fix lookup join test.
If the dim table have 100 fields, and we only use 3 fields of them, then we should only keep 3 fields in the cache.
Change Logs

Modify HoodieTableSource,  when constructing HoodieLookupFunction, pass in query required schema, instead of the dim table schema.
Fix lookup join test in ITTestHoodieDataSource. It will pass no matter what before, because source table and target table share same path.

Impact
None
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

cc @danny0405


A shape with 2 crossings and 0 intersections

After 250 CPU-days of computation, I discovered a shape with 2 crossings and 0 intersections.
https://gist.github.com/galqiwi/5ba7695139bfb281009161485846946d
To reproduce these results:

Checkout my patched code from here. This version exits after a single optimizer run and prompts for topology at startup
Compile it. I use clang++ -I <path to eigen 3> -std=c++17 *.cpp -O2 -o main
Run it with seed 30000157 and topology 4

The resulting output is here.

When I first saw this, I was thinking the shape might be degenerate due to the quality measures being really bad, in particular the A and D factors. So I ran it through the quality optimizer.
To my surprise, it managed to greatly improve the scores and reveal an order-2 symmetry. So then I added the symmetry enforcement and produced the 'best' looking shape around this minimum. I've also attached a printable version with the crossings split into 2 polygons.
m4_original_polygons.obj.txt
m4_triangulated_manifold.obj.txt
Great work! I didn't spend quite as much time on the non-zero crossing search so I must have missed this one! I'll definitely mention this in a follow-up once all the dust has settled. This makes it slightly more likely there could be a 0-crossing 2-intersection shape somewhere, or even a completely intersection free one maybe.


fix: APPLICS-875 - Allow desc to be created when timetable desc is not present

Describe your changes
https://pins-ds.atlassian.net/browse/APPLICS-875?atlOrigin=eyJpIjoiNzJkNDA4ZGE1M2VjNDg3NThlOGRkNzQ2MzZmNzYzMWUiLCJwIjoiaiJ9
Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.36.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow writing a non-distributable layer upstream

Context
As part of #62 a 'workaround' solution was found to ggcr's inability to write a non-distributable layer.
The workaround solution was to write the 'foreign' layers upfront before trying to write the image manifest.
We decided to proceed with the workaround solution, since there was some urgency behind getting window images working. See https://kubernetes.slack.com/archives/CH8KCCKA5/p1598013615011900
Description
Create a PR or Issue to https://github.com/google/go-containerregistry to allow writing a non-distributable layer.
Change imgpkg to use the above change to writing an image manifest that contains a 'foreign' image layer.
Notes

There's a closed issue that has some background.
Matt Moore<EMAIL_ADDRESS>worked on this library if it's difficult getting traction in the repo

Tasks

[x] Introduce Option to allow specifying "allow non distributable layers"
[x] Wherever that option is used, support the allowance

[x] Write (this is all we really need, but the options are also used...)

[x] MultiWrite

[x] Add task to use upstream GGCR functionality OR create a story to do so.

Made the PR in upstream GGCR. Currently blocked on signing the CLA, unsure if that should be done as an individual or for the company.
After that gets merged, we should use it in imgpkg!

Looks like the PR was merged a couple of weeks back but has not been part of a release yet. Let's keep this issue open until we can consume the upstream changes.

go-container registry released 0.4.1 that contains the PR to non-distributable layers
https://github.com/google/go-containerregistry/releases/tag/v0.4.1

This issue was resolved in https://github.com/vmware-tanzu/carvel-imgpkg/pull/110 and released in v0.6.0.


missing segment settings in Advanced MDX-Net Options - Demucs Settings

Segment settings is vital for laptop users because of low amount of available vram.
I can't seem to find the Segment settings in Advanced MDX-Net Options - Demucs Settings.
This means if I enable Demcus Model in MDX-Net Panel, it will warn me about GPU may not be supported error.
I can use the Demcus Model just fine. I can lower the Segments settings and no errors.

I have no idea what these settings mean. Pardon if I didn't notice obvious things.

I think disabling Split Mode fixes everything.


HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

Description of PR
Applications using AzureBlobFileSystem to create the AbfsOutputStream can use the AbfsOutputStream for the purpose of writing, however, the OutputStream doesn't hold any reference to the fs instance that created it, which can make the FS instance eligible for GC, when this occurs, AzureblobFileSystem's finalize() method gets called which in turn closes the FS, and in turn call the close for AzureBlobFileSystemStore, which uses the same Threadpool that is used by the AbfsOutputStream. This leads to the closing of the thread pool while the writing is happening in the background and leads to hanging while writing.
How was this patch tested?
mvn -Dparallel-tests=abfs -DtestsThreadCount=8 -Dscale clean verify on us-west-2
[INFO]
[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 4

[INFO]
[ERROR] Tests run: 582, Failures: 5, Errors: 1, Skipped: 107
Seeing "lease" related errors, seems to be my bucket related(have seen the same in trunk for me too, so unrelated).

[ERROR] Failures:
[ERROR]   ITestAbfsReadWriteAndSeek.testReadAndWriteWithDifferentBufferSizesAndSeek:78->testReadWriteAndSeek:111 [Retry was required due to issue on server side] expected:<[0]> but was:<[1]>
[INFO]
[ERROR] Tests run: 339, Failures: 1, Errors: 0, Skipped: 41

Seeing this in the trunk as well, not so sure about this.

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

CC: @steveloughran @mukund-thakur Cannot think of another test other than checking if the correct fs instance is passed. But I did have a test in my local where I tried to explicitly run a System.gc()(Which actually doesn't run the GC, just points if there is something to collect) which resulted in finalize() getting called on the FS after applying the patch, fs instance wasn't getting GC'ed and thread pool was not closed for writing.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 22s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 14s

trunk passed

+1 :green_heart:
shadedclient
24m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m  2s

the patch passed

+1 :green_heart:
shadedclient
24m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  2s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

104m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5d801861a67f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f4a39ab5a5712c19140d3afab35c231534d8c8fa

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/1/testReport/

Max. process+thread count
542 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Actually, existing HadoopExecutors could store stack of close() and include it in exceptions raised, this would benefit all uses.
could we have abfs.close() log at debug the stack trace of its invocation?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
19m 35s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 46s

trunk passed

+1 :green_heart:
compile
18m 50s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 55s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 43s

trunk passed

+1 :green_heart:
mvnsite
2m 29s

trunk passed

+1 :green_heart:
javadoc
1m 59s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 57s

trunk passed

+1 :green_heart:
shadedclient
25m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
17m 51s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 51s

the patch passed

+1 :green_heart:
compile
16m 55s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 39s
/results-checkstyle-root.txt
root: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)

+1 :green_heart:
mvnsite
2m 27s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  6s

the patch passed

+1 :green_heart:
shadedclient
25m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 57s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 18s

hadoop-azure in the patch passed.

-1 :x:
asflicense
1m  0s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

224m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3e06f4484ec1 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b638fa337478be5a8b5b9313d1fe6ecd4a46b28e

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/2/testReport/

Max. process+thread count
2040 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

This problem I guess would happen when job opens filesystem and opens an OutputStream and the job is writing data into it, But after outputStream open, there is no reference to AzureBlobFileSystem object in the job. Shouldn't jobs have logic to close the filesystem.
Kindly point if there are other usecases where in this problem arises. Thanks!

This problem I guess would happen when job opens filesystem and opens an OutputStream and the job is writing data into it, But after outputStream open, there is no reference to AzureBlobFileSystem object in the job.

Yes

Shouldn't jobs have logic to close the filesystem. Kindly point if there are other usecases where in this problem arises. Thanks!

No, close() on an FS you got from FileSystem.get shouldn't be called as they are shared. Things like FileSystem.closeAllForUGI() do the cleanup

@saxenapranav having the close() in finalize helps avoid leakage of threads and things if caching for an fs schema is disabled and clients call FileSystem.get(path), the way they should: normally apps shouldn't close it.
In #4966 we had to add finalizers to the FileContext bindings as they were leaking.
One thing to consider is this problem surfaced as reports of the output stream hanging in close(): it was waiting for the async uploads to finish but because all was broken, that was not to be.
Mukund, as well as avoiding premature close(), can this PR have output stream close() fail noisily if the thread pool was shut down? this is at least testable, to an extent

Did a bit of research on GC and came up with this test, this seems to fail almost every time when I pass in "null" as the backreference for the stream and pass when passing the FS reference. Again, GC is something that may vary from system to system, but this should add some more coverage. CC: @mukund-thakur @steveloughran

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 34s

Maven dependency ordering for branch

-1 :x:
mvninstall
36m  1s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
23m 43s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 44s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
2m  0s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 47s

trunk passed

+1 :green_heart:
shadedclient
38m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
17m 37s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 37s

the patch passed

+1 :green_heart:
compile
16m 55s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 35s

the patch passed

+1 :green_heart:
mvnsite
2m 26s

the patch passed

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  8s

the patch passed

+1 :green_heart:
shadedclient
39m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  4s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 19s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

267m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 55523de2de86 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bee4fd6ef654080930db78078a34a53880f845cf

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/3/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

No similar test for InputStream?

So, InputStream doesn't actually use any threadpool passed from the FS instance so would be tricky to test that. But, Let me just add a test for checking back reference notNull, that should be enough I think.

Can we also handle filesystem.close() in the output stream by failing cleanly if the fs was explicitly closed()?

@steveloughran Was thinking about this, so essentially whenever an Abfs.close() is closed we need to call the stream's close() as well, so that we can flush any remaining writes etc? Was thinking how this should be handled say mid way through a write, currently, I believe since the executor itself is shut down it just simply rejects any request incoming like this
Could not submit task to executor java.util.concurrent.ThreadPoolExecutor@5c5e7584[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 14s

trunk passed

+1 :green_heart:
compile
18m 43s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m  5s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 47s

trunk passed

+1 :green_heart:
mvnsite
2m 31s

trunk passed

+1 :green_heart:
javadoc
1m 58s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
39m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
17m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 52s

the patch passed

+1 :green_heart:
compile
16m 49s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 36s

the patch passed

+1 :green_heart:
mvnsite
2m 26s

the patch passed

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  5s

the patch passed

+1 :green_heart:
shadedclient
39m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m  6s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 25s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

264m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d52748214247 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0731d4d5cd9794fe4537fa23219132df4726b970

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/4/testReport/

Max. process+thread count
3138 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
20m 14s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 19s

trunk passed

+1 :green_heart:
compile
18m 26s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 52s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 39s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
1m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
38m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
17m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 44s

the patch passed

+1 :green_heart:
compile
16m 44s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 41s
/results-checkstyle-root.txt
root: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
2m 26s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  4s

the patch passed

+1 :green_heart:
shadedclient
39m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 44s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 12s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

279m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a0a97075f75c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ca34a699466db2c8410a414e8f9ef30745957d62

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/5/testReport/

Max. process+thread count
1239 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Interesting. I have pushed a check style fix commit, but it doesn't seem to propagate here whilst it shows that I committed it successfully in my local machine.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 29s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 34s

trunk passed

+1 :green_heart:
compile
18m 34s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
16m 57s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 30s

trunk passed

+1 :green_heart:
javadoc
1m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 50s

trunk passed

+1 :green_heart:
shadedclient
39m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
17m 45s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 45s

the patch passed

+1 :green_heart:
compile
16m 57s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 36s

the patch passed

+1 :green_heart:
mvnsite
2m 25s

the patch passed

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m  6s

the patch passed

+1 :green_heart:
shadedclient
39m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 54s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 18s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

261m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0a362ecc465f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 959c241bb7f56c6312a15050d9546a5236d4bdba

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/6/testReport/

Max. process+thread count
1754 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 32s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
37m 52s

trunk passed

+1 :green_heart:
compile
18m 38s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
17m  1s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
4m 40s

trunk passed

+1 :green_heart:
mvnsite
2m 28s

trunk passed

+1 :green_heart:
javadoc
1m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 49s

trunk passed

+1 :green_heart:
shadedclient
39m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
17m 46s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
17m 46s

the patch passed

+1 :green_heart:
compile
16m 58s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
16m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 34s

the patch passed

+1 :green_heart:
mvnsite
2m 28s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
4m 20s

the patch passed

+1 :green_heart:
shadedclient
39m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 56s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 18s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

264m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5780

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f54dad37fd11 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 57657468fdb539d5526632ad54a2c39e803d9dd6

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/7/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5780/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

i'm happy with all production code, just wondering if the stream close behaviour could be tested with a test which would behave consistently. if not, then let's not worry


cannot connect to newly updated EVduty station firmware that should add OCPP

Hello Everyone!
My EVduty station was just updated with what I believe OCPP support.
the manufacturer told me a few weeks ago that they are working on adding OCPP support... and 2 weeks ago they said it should be released shortly.
I just got an update today that added en OCPP URL entry.
so here I am with trying to add it to home assistant.
It looks like the station is trying to connect to the integration... but there's some kind of error.
see below log... is there anything I can do to fix this problem?
I already tried the skip validation option.
2022-06-27 20:42:12 INFO (MainThread) [websockets.server] connection open
2022-06-27 20:42:12 WARNING (MainThread) [custom_components.ocpp] Skipping websocket subprotocol validation
2022-06-27 20:42:12 INFO (MainThread) [custom_components.ocpp] Charger websocket path=/ocpp/EVC30-24541
2022-06-27 20:42:12 INFO (MainThread) [custom_components.ocpp] Charger EVC30-24541 reconnected to <IP_ADDRESS>:8500.
2022-06-27 20:42:12 DEBUG (MainThread) [custom_components.ocpp] Reconnect websocket to EVC30-24541
2022-06-27 20:42:14 INFO (MainThread) [ocpp] EVC30-24541: send [2,"f6ee754e-9506-4d5c-a546-4e845c97c9e3","GetConfiguration",{"key":["SupportedFeatureProfiles"]}]
2022-06-27 20:42:14 INFO (MainThread) [ocpp] EVC30-24541: receive message [3,"f6ee754e-9506-4d5c-a546-4e845c97c9e3",{"configurationKey":[{"key":"WifiSSID","readonly":0,"value":"beaulac2"},{"key":"ChargeAccessType","readonly":0,"value":1},{"key":"MaxCurrent","readonly":0,"value":30},{"key":"InputVoltage","readonly":0,"value":240},{"key":"LocalIPAddress","readonly":1,"value":"<IP_ADDRESS>"},{"key":"MACAddress","readonly":1,"value":"A4:CF:12:E9:DF:FF"},{"key":"Firmware_A_Version","readonly":1,"value":"<IP_ADDRESS>"},{"key":"Firmware_B_Version","readonly":1,"value":"<IP_ADDRESS>"},{"key":"PSLVL1_BreakerValue","readonly":0,"value":40},{"key":"PSLVL1_LinkID","readonly":0,"value":1},{"key":"PSLVL1_ID","readonly":0,"value":1},{"key":"PSLVL1_TotalNumber","readonly":0,"value":1},{"key":"PSLVL2_BreakerValue","readonly":0,"value":40},{"key":"PSLVL2_LinkID","readonly":0,"value":2},{"key":"PSLVL2_ID","readonly":0,"value":1},{"key":"PSLVL2_TotalNumber","readonly":0,"value":1},{"key":"ChargeSessionEndingType","readonly":0,"value":0},{"key":"FallbackMode","readonly":0,"value":0},{"key":"WifiRSSI","readonly":0,"value":-49},{"key":"RampUpCurrentOutputAfterBoot","readonly":0,"value":0}]}]
2022-06-27 20:42:14 ERROR (MainThread) [custom_components.ocpp] Unexpected exception in connection to 'EVC30-24541': 'TypeConstraintViolationError: Payload for Action is syntactically correct but at least one of the fields violates data type constraints (e.g. “somestring”: 12), {'cause': "0 is not of type 'boolean'"}'
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/ocpp/messages.py", line 200, in validate_payload
validator.validate(message.payload)
File "/usr/local/lib/python3.9/site-packages/jsonschema/validators.py", line 267, in validate
raise error
jsonschema.exceptions.ValidationError: 0 is not of type 'boolean'
Failed validating 'type' in schema['properties']['configurationKey']['items']['properties']['readonly']:
{'type': 'boolean'}
On instance['configurationKey'][0]['readonly']:
0
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/ocpp/api.py", line 913, in run
await asyncio.gather(*self.tasks)
File "/config/custom_components/ocpp/api.py", line 409, in post_connect
await self.get_supported_features()
File "/config/custom_components/ocpp/api.py", line 483, in get_supported_features
resp = await self.call(req)
File "/usr/local/lib/python3.9/site-packages/ocpp/charge_point.py", line 289, in call
validate_payload(response, self._ocpp_version)
File "/usr/local/lib/python3.9/site-packages/ocpp/messages.py", line 203, in validate_payload
raise TypeConstraintViolationError(details={"cause": e.message})
ocpp.exceptions.TypeConstraintViolationError: TypeConstraintViolationError: Payload for Action is syntactically correct but at least one of the fields violates data type constraints (e.g. “somestring”: 12), {'cause': "0 is not of type 'boolean'"}
2022-06-27 20:42:14 DEBUG (MainThread) [custom_components.ocpp] Closing websocket to 'EVC30-24541'
2022-06-27 20:42:15 INFO (MainThread) [custom_components.ocpp] Charger EVC30-24541 disconnected from <IP_ADDRESS>:8500.
2022-06-27 20:42:15 INFO (MainThread) [websockets.server] connection closed

Suggest sending the log to the manufacturer and raising a ticket. It is not responding to the Ocpp standard when sent [2,"f6ee754e-9506-4d5c-a546-4e845c97c9e3","GetConfiguration",{"key":["SupportedFeatureProfiles"]}]

@drc38
thanks! I'll do this immediately and report back if they fix it.

If the list of keys in the request PDU is empty or missing (it is optional), the Charge Point SHALL return a list of all configuration settings in GetConfiguration.conf. Otherwise Charge Point SHALL return a list of recognized keys and their corresponding values and read-only state. Unrecognized keys SHALL be placed in the response PDU as part of the optional unknown key list element of GetConfiguration.conf.

@drc38 thanks again for your comments. I've shared this thread with the manufacturer... their dev is apparently looking at this right now.

Manufacturer still hasn’t updated firmware yet.

Hello Everyone,
I've got a beta firmware installed my my charging station... this should fix the "incompatibilities" but it's not.
here's the log done with the previous version of OCPP (before the update has been released this week):
2022-10-05 18:11:11.051 INFO (MainThread) [custom_components.ocpp] Charger websocket path=/ocpp/EVC30-24541
2022-10-05 18:11:11.051 INFO (MainThread) [custom_components.ocpp] Charger EVC30-24541 reconnected to <IP_ADDRESS>:9000.
2022-10-05 18:11:11.052 DEBUG (MainThread) [custom_components.ocpp] Reconnect websocket to EVC30-24541
2022-10-05 18:11:13.054 INFO (MainThread) [ocpp] EVC30-24541: send [2,"a5317123-8ed6-41e5-933b-819a649109e3","GetConfiguration",{"key":["SupportedFeatureProfiles"]}]
2022-10-05 18:11:13.203 INFO (MainThread) [ocpp] EVC30-24541: receive message [3,"a5317123-8ed6-41e5-933b-819a649109e3",{"configurationKey":[{"key":"SupportedFeatureProfiles","readonly":true,"value":"Core"}]}]
2022-10-05 18:11:13.204 DEBUG (MainThread) [custom_components.ocpp] Feature profiles returned: Profiles.CORE
2022-10-05 18:11:13.205 INFO (MainThread) [ocpp] EVC30-24541: send [2,"92979304-e0c4-49fa-bef2-538c6b1a0e52","GetConfiguration",{"key":["NumberOfConnectors"]}]
2022-10-05 18:11:13.497 INFO (MainThread) [ocpp] EVC30-24541: receive message [3,"92979304-e0c4-49fa-bef2-538c6b1a0e52",{"configurationKey":[{"key":"NumberOfConnectors","readonly":true,"value":1}]}]
2022-10-05 18:11:13.499 ERROR (MainThread) [custom_components.ocpp] Unexpected exception in connection to 'EVC30-24541': 'TypeConstraintViolationError: Payload for Action is syntactically correct but at least one of the fields violates data type constraints (e.g. “somestring”: 12), {'cause': "1 is not of type 'string'"}'

it looks like it's expecting a string when reading Number of connectors... but this is not what is received. Apparently, it's an integer.
And to my best of knowledge (and this is what the manufacturer told me), it should be an integer according to point 9.1.19 of the ocpp 1.6 document.
is this something that needs to be fixed in the ocpp implementation of this integration or my charging station manufacturer needs to adjust something from their side?
sadly I cannot try the new OCPP release of this week immediately... my charging stating has been reprogrammed with the stable firmware automatically (a newer stable release will be available later this month).

You'd need to do some research but I think the ocpp1.6 schema still requires it to be passed in json as a string. Validation of messages is not part of the HA integration and is handled upstream by this library https://github.com/mobilityhouse/ocpp

They need to be using the official schemas eg for GetConfiguration.json:
{
    "$schema": "http://json-schema.org/draft-04/schema#",
    "id": "urn:OCPP:1.6:2019:12:GetConfigurationRequest",
    "title": "GetConfigurationRequest",
    "type": "object",
    "properties": {
        "key": {
            "type": "array",
            "items": {
                "type": "string",
                "maxLength": 50
            }
        }
    },
    "additionalProperties": false
}

thanks @drc38 for your help. they finally switched all integer to string in their code because apparently this is what ocpp standard is supposed to be.
now they need to fix the latency test issue...
not sure here what could be the cause... seeing this every 2 minutes
and reconnect after 2 seconds.
2022-10-17 20:30:45.586 DEBUG (MainThread) [custom_components.ocpp] Connection latency from 'central' to 'EVC30-24541': ping=1.0 ms, pong=20000 ms
2022-10-17 20:31:25.589 DEBUG (MainThread) [custom_components.ocpp] Connection latency from 'central' to 'EVC30-24541': ping=1.0 ms, pong=20000 ms
2022-10-17 20:32:05.591 DEBUG (MainThread) [custom_components.ocpp] Connection latency from 'central' to 'EVC30-24541': ping=1.0 ms, pong=20000 ms
2022-10-17 20:32:05.592 DEBUG (MainThread) [custom_components.ocpp] Connection to 'EVC30-24541' timed out after '2' ping tries
2022-10-17 20:32:05.592 DEBUG (MainThread) [custom_components.ocpp] Closing websocket to 'EVC30-24541'
2022-10-17 20:32:15.667 INFO (MainThread) [custom_components.ocpp] Charger EVC30-24541 disconnected from <IP_ADDRESS>:9000.
the station did send this...
2022-10-17 19:51:35.560 INFO (MainThread) [ocpp] EVC30-24541: send [2,"402c3023-ffd6-40c1-9fe5-10beaea88f15","GetConfiguration",{"key":["WebSocketPingInterval"]}]
2022-10-17 19:51:35.849 INFO (MainThread) [ocpp] EVC30-24541: receive message [3,"402c3023-ffd6-40c1-9fe5-10beaea88f15",{"unknownKey":["WebSocketPingInterval"]}]
2022-10-17 19:51:35.851 WARNING (MainThread) [custom_components.ocpp] WebSocketPingInterval is unknown (not supported)
which is the correct answer apparently if websocketpinginterval is not supported.
is this something missing from the charging station... like a standard ocpp that is not implemented?

It is a websocket standard to respond to a ping with a pong. The fact it does not support WebSocketPingInterval should not matter. Is your wifi connection rssi solid?

yes very solid -48 dBm.
router is less than 10 feet from charging station.
if I put a high ping retry... it stays connected until it reaches the retry count. it will reconnect immediately after 3 seconds.
besides this ping/pong disconnections, I've not see any other disconnection.

I've sent a message to the manufacturer regarding the ping/pong reply that should be supported.
everything else is working fine... I'm very near to get a working station with this ocpp integration.

here's the last answer from the charging station manufacturer.
it's apparently unusual for the server to send a ping.
Thus the charging station will not reply to with a pong.
They are saying it's the "client" (here the charging station) that should do it... and they are doing it by default every 5 seconds I believe.
yes I read point 9.1.34... and it's taking about server sending ping and client replying with pong...
but apparently manufacturer is not interested to add this feature.
is there a way to disable this ping/pong from the server?
if not, I'll start looking for an other charging station that is really supported.

See https://www.rfc-editor.org/rfc/rfc6455#section-5.5.2 replying with a pong is not optional.
You would need to create a patch for the function monitor_connection eg skip pinging if interval is 0, and submit a PR.

Thanks a lot for your comment.
I’ve submitted this link to the manufacturer… I don’t put any hope in this. Lets see what they are going to do.
I will not submit a patch for this as I don’t want to encourage a company that doesn’t follow the rfc. If they don’t do it, I’ll simply start looking for something else

Hello all.
Just got a final email from the manufacturer...
they have no intention to push this further... they are saying no more work will be done on their OCPP implementation because it's compliant. These are essentially their words... not mine.
At this point, it's just the pong reply that needs to be adjusted/added in their firmware... I'm not sure why they do not want to do it.
Unless someone here wants to push this further in the OCPP code, we can close this bug report (and maybe tag it as a charger bug) as I have no intention to submit a PR

CAN you contact me?

CAN you contact me? I have issue with my evduty

You should contact EVduty directly if you need support


[SLUS_211.93] Inuyasha Feudal Combat freezes and missing sfx (UDPBD)

The game it can freeze at a loading screen, when you start a to play either at the first or second battle the sfx of when the characters get hit by the weapons and such will be missing, i took this screenshot when it froze

On USB i lasted 4 battles before freezing, i only tried once but it had all the sfx in every battle
My model is SCPH-90010

I'll take a look at it.
Did you try any compatibility modes? If usb works then the issue could be that udpbd is too fast. Perhaps adding -gc=1 helps?

I tried a few times with -gc=1 and it doesn't help, -gc=2 seem to work but i can't get past a third battle without freezing

Those warnings about missing files are just bugs in the game. The files do not exist on the DVD. Even when running this game on PCSX2 you will see these warnings, but the game will run just fine on PCSX2.
I spent some time trying to fix the game but no luck so far.


WIP (PUP-6629) Tighten up corruption handling for transactionstorefile

This adds better testing for the corruption case, and stops the system from
hard failing if it has to do a rename.
Signed-off-by: Ken Barber<EMAIL_ADDRESS>

CLA signed by all contributors.

Wow, a behavior difference in Ruby 1.9. This is just the worst.
I should have some time today to get poke this, but damn :(

@branan I'm going to break this PR in half because I'm worried about the YAML solution. This PR covers the transactionstore corruption for now only.

@branan this one at least passes on its own.


dev.ssr performance when route name same as root file in user's disk

Qwik Version
0.0.102
Operating System (or Browser)
mac
Node Version (if applicable)
No response
Which component is affected?
Qwik City
Expected Behaviour
issue report from steranevdy on discord, reproduce in my machine as well
version
<EMAIL_ADDRESS>"0.0.102"
<EMAIL_ADDRESS>"0.0.104"

In starters, create route named home, run command npm run dev.ssr
expect page render speed is on 20ms~
Actual Behaviour
page render speed is around 300ms ~ 1s
Additional Information
not expert on vite, but I tried to debugging at my best, found out every request will go through vite:resolve plugin at first, if no match then qwik-city's devServer middleware.
so code in https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/resolve.ts#L260
handling '/home' html request, will attempt to search '/home' absolute file path, then hit without read permission (at least in mac or my machine....).
then result in issue of https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/resolve.ts#L508
IMHO, There is chance to optimize dev perf for HTML request no need to go through whole vite plugins middleware one by one( or at least let qwik-city handle it first), https://vitejs.dev/guide/ssr.html#setting-up-the-dev-server might helps here.
Also noticed that default vite's conf appType default is SPA, maybe need to change something else.

Closed w/ https://github.com/BuilderIO/qwik/commit/a84e0d9a5fcb32c22bfb333cc0bd1c79a1f0032b


[Serious bug] Can no longer select folders

When I try to select or change a folder, all I get is this:

Desktop cannot be expanded in any way.
My current windows version:

For those that need a workaround, you can edit the default starting location in the XML:

This obviously is still very limiting.
I do note #143; hopefully this is already fixed internally and we get a release soon. Thanks!

I've been experiencing the same problem for a couple of weeks now

Same here too, seems to be caused by the new "explorer" version

Hi,
I could not reproduce this error, it seems to work. Did you do something special before or its always happenning if you click on Add/Change Folder?
My windows version is:

Oh god windows onedrive is so stupid... Thx for the solution !

Solved and not a bug -> Closed


add patch for k/k 1.31

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/approve

/lgtm


Speedup performance.

Hi, I tried to compare Sublime and Vscode and feel that Vscode is not enought smooth and speedy. When I click on something in vscode it reacts after maybe 100-300ms. I feel it. But in Sublime it reacts instantly (maybe 10-30 ms). Moreover, in settings, where a lot of list elements scroll feels very laggy. What do you think about it? Maybe its time to create trully native and light crossplatform code editor with needed for development features but simple and light? I really don't like jetBrains editors because there is too much features and UI is too overloaded and hope Microsoft can invest and create really speedy editor.
Smooth editor really matters, because it helps us to be calm and don't think about lags.

In order for us to investigate and act, please be more specific and avoid mentioning multiple problems in the same issue (file one issue per problem)
You say clicking on something. Where is that? Can you give detailed steps?
Also, what is your OS and machine spec? Does it reproduce without extensions?

In order for us to investigate and act, please be more specific and avoid mentioning multiple problems in the same issue (file one issue per problem)
You say clicking on something. Where is that? Can you give detailed steps?
Also, what is your OS and machine spec? Does it reproduce without extensions?

https://youtu.be/faVXPcSeLt8

/needsMoreInfo
Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues. Thanks.


Solve error under Windows 10

I get the following error when I try to solve the model with: scen.solve(model='MESSAGE):

subprocess.CalledProcessError: Command 'gams "MESSAGE.gms" --in="MESSAGE_in.gdx" --out="MESSAGE_out.gdx" LogOption=4' returned non-zero exit status 6.

model_file in ixmp/core is gives the following string MESSAGE.gms. In a former version model was a path to MESSAGE_run.gms .
Current version:
model = os.path.join(ix.default_paths.MODEL_DIR, '{}_run.gms'.format(model))
Older version:
model_file= model_file or config.model_file.format(model=model)
I am not sure if I made a error during the installation process or this is a general error.

hi @tzipperle , due to the migration, we separated all MESSAGE-specific parts from the generic ixmp aspects. To use it as before, you just have to load the package message_ix at the beginning of any Python script - this will tell the ixmp package that whenever the model is MESSAGE or MESSAGE-MACRO, it should use the default MESSAGE GAMS file names and paths.
Please let me know whether this solves your problem

Only the import is not enough.
import message_ix
model = model=message_ix.model_file.format(model='MESSAGE').replace('.gms', '')
scen.solve(model=model)

With the upper workaround it works...

when you run install.bat in your message_ix (message_ix_dev) clone, do all unit tests pass? In particular the one on the tutorials?

I have uninstalled message_ix and reinstalled. Now it works fine with the import statement.
But when I run the install.bat under message_ix, then the unit test doesn't starts. Only when I call it under message_ix/ixmp - all tests pass.

@OFR-IIASA , does this also happen on your Windows 10 PC? Do the unit tests run when you double-click install.bat in the message_ix folder?

@danielhuppmann , I havent encountered this issue.  When I execute install.bat two sets of tests are executed.

@tzipperle , can you post a screenshot of the command prompt when executing the top-level install.bat?

thanks @OFR-IIASA !

thanks @tzipperle for identifying and solving this issue!


github assignement gplassais

you're done for the first part
btw don't start your PRs from your main branch, it'll create problems for you in the long run


📝 Documentation: File issues for increasing unit test coverage

Bug Report Checklist

[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Merged test coverage is just under 93%. That means that >7% of this template is not run in any of the end-to-end tests or unit tests. I don't think we specifically need 100%, but I bet there are some areas that could be given unit tests.
I'll go through the merged report on https://app.codecov.io/gh/JoshuaKGoldberg/create-typescript-app to see if there are any potential areas that could have a contribution to add more testing.
Additional Info
Already in existence:

#699
#700
#701

I filed some. 👍


Use proc macros for specifications

Would be rather nice to be able to write stuff like
#[flux]
fn assert(b:bool[true]) {}

#[flux]
fn inc(x: &mut i32{v:0<=v}) {
    *x += 1
}

#[flux]
fn inc(x: &mut i32[v]) ensures x: i32[v+1] {
    *x += 1
}

#[flux]
fn dist(x: &Point[@n], y: &Point[n]) -> f32 {
  let mut res = 0.0;
  for i in range(0, x.len()) {
    let di = x[i] - y[i];
    res += di * di;
  }
  res
}

#[flux]
fn inc(x: &mut i32{v:0 < v})
{
    *x += 1
}

#[flux]
fn kmeans(n: usize, mut centers:RVec<Point[n]>[@k], points: RVec<Point[n]>)
   requires 0 < k
{
  for _ in 0..100 {
    let point_centers = mr::map(&points, |x| nearest(&centers, x));
    let center_clusters = mr::group(point_centers);
    let weighted_centers = mr::reduce(center_clusters, |p1, p2| centroid(p1, p2));
    for (i, (x, w)) in weighted_centers {
      centers.set(i, x.map(|xi| fdiv(*xi, w)))
    }
  }
}

### Tasks

I was very surprised that flux is implemented as a compiler driver. Would it be impossible to implement it in standard rust using macos?

That seems difficult because flux relies quite heavily on a lot of the internal analyses done by rustc (e.g. flux analyzes MIR) which would be hard using just macros (?)

Oh I see! That's very clever! I suppose, then, it could be done in a macro, but you'd re-implement much of the logic done by the internals of rustc. Hmm.

We implemented the flux! macro a long ago which is the closest we can get to the proposal suggested here, so I'm closing this.


Fix for Issue #2059

Note: I clobbered my previous changes in lieu of the simplest fix possible.  There will be other problems that still exist with the acceptance of this simpler fix.

Alright, I'll merge it so I can start building installers.


Found a Lost Link

https://github.com/dendronhq/dendron-site/blob/96628a1dbffed7d1303b6dd2a763bcf4b8938b13/vault/dendron.topic.hierarchies.md#why-hierarchies
line 56 the last Link here

Thanks for the tip. Just fixed!


Start Menu Shortcuts on Uninstallation

Removing start menu shortcuts bug on Scoop uninstallation :/
$ scoop uninstall scoop
INFO: Win10 v1903 V1

What bug? What is not working?

I just uninstalled scoop with:
$ scoop uninstall scoop
but the shortcuts still appear in the start menu


Bump the docker version for sparse attention?

I bumped the versions to pytorch 1.7/cuda10.2/cudnn8 and am still getting sparse attention to properly compile.
I know @robvanvolt at least has had trouble getting sparse to compile on the 3090RTX though so it's probably wise to test this out on other GPU architectures than mine which apparently is similar-ish enough to the widely supported V100 for sparse to work.

https://github.com/lucidrains/DALLE-pytorch/pull/320

actually works on 1.8.1 LTS CUDA 10.2 CUDNN7


Bug in _patch_dropout_layers

Describe the bug
In the function _patch_dropout_layers, when changed=True, _patch_dropout_layers(child) of the current child which is not a dropout layer is never executed. However, this function is supposed to recursively replace all dropout layers of a given module with MC dropout layers.
def _patch_dropout_layers(module: torch.nn.Module) -> bool:
    changed = False
    for name, child in module.named_children():
        if isinstance(child, torch.nn.Dropout):
            new_module = Dropout(p=child.p, inplace=child.inplace)
        elif isinstance(child, torch.nn.Dropout2d):
            new_module = Dropout2d(p=child.p, inplace=child.inplace)
        else:
            new_module = None
        if new_module is not None:
            changed = True
            module.add_module(name, new_module)

        # recursively apply to child
        changed = changed or _patch_dropout_layers(child)
    return changed

To Reproduce
Occur when more than one children of a module are not dropout layers but contain dropout layers. => only dropout layers in the first children are replaced with MC dropout.
Some advices:
From this
changed = changed or _patch_dropout_layers(child)
to this:
 changed |= _patch_dropout_layers(child)

Thanks a lot for submitting this issue! The PR is opened at #147

Thank you very much for the fast update, but be careful with changed = changed or in baal/bayesian/weight_drop.py  and baal/bayesian/consistent_dropout.py. Same problem.


Clean up warning

There is a warning that appears in the last xcode version in DTTimePeriodChain.m at line 149
The solution is easy, replace the line
[((DTTimePeriod *) obj) shiftEarlierWithSize:DTTimePeriodSizeSecond amount:[periods[0] durationInSeconds]];

for
[((DTTimePeriod *) obj) shiftEarlierWithSize:DTTimePeriodSizeSecond amount:[self->periods[0] durationInSeconds]];

Let me know if you want a PR for this

The PR #266 fixes this warning

Great! thank you!


Small Issue

Maybe it is kid an iOS stock issue but it appeard after going back from the Theme section.
http://imgur.com/a/RoPq7
Model: iPhone SE
Version: 64GB
iOS Version: 10.2
Note:
I think it could be triggered by upscale or cask.

Sry for bad English ¯_(ツ)_/¯

Does it happen every time? Does it happen to any other tweak's settings?

isolated incident, closing for now.