cast_assoc for required has_many allows empty list if assoc set to on_replace: :delete

When

a struct's has_many assoc is required
that assoc is marked on_replace: :delete
that assoc is cast with an empty list

then: the required validation still passes, even though an empty list is invalid in other situations (def empty?(%{cardinality: :many}, []), do: true)
This PR adds a failing test for this as well as a fix.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Fix undefined method `windows?'

This fixes an incompatibility with current pry HEAD, which apparently retired Pry::Platform.
I fear this fix by itself would again be incompatible with current pry release version. But I don't know enough about the respective releases processes, and which strategy you tend to prefer (set dependency to next pry release/respond_to?/etc.).
Feel free to close and/or adapt as you see fit.

FWIW, I restored the method and it'll emit a warning. It'll be removed after next Pry release, though.

We should get this merge and consider a minimum pry version dependency. @MatthiasWinkelmann, can you rebase to trigger a CI rerun?

@ConradIrwin can you cut a new release from master?

@ConradIrwin Great. I'll try to git tag to match your release as well.


Different vermagic

Hey Jim,
I'm using TX2 connected to connect-tech Astro carrier board with kernel 4.4.38+.
The force option dose'nt work for me, it gives me the "version magic should be" error.
Is there any way you publish the pre-compiled cdc_acm?
Thanks, Gal

Not quite sure what you're looking for. The pre-compiled cdc-acm.ko file is in the repository.

cdc-acm.ko is already compiled for 4.4.38-tegra.
Before it was a driver (ko) it was a pre-compiled driver (c file for example).
In order to solve the the issue of "version magic should be" I can do 2 things:

Compile the cdc-acm in my kernel with the vermagic 4.4.38+ .....
Compile the entire connect-tech kernel in order to change the string 4.4.38+ to 4.4.38-tegra (much more complicated)

Oh, there's a misunderstanding on the naming.
The term pre-compiled means that the module has already been compiled.
You are asking for the source code for the module, cdc-acm.c
The file cdc-acm.c is available in the source code for the kernel and modules. You should be able to get it through the NVIDIA Embedded download site, or possibly through ConnectTech.
What command did you execute to force the module to load? It should only check the version (4.4.38) not the local version. Note that the module will only load if there's a CDC-ACM device attached.

I used "sudo modprobe -f cdc-acm" and it gave me the error. CDC-ACM device was connected

I am running into the same issue here. Was this ever resolved? (I'm relatively new to working in linux like this.)

@blairm-gmnameplate What issue are you running in to? What are carrier board are you running? Which version of L4T?

Wow. Didn't expect to get a response so quickly. Thanks!
I am running a ConnectTech Rudi (ESG506-21) board. It is using a version of L4T28.1 (not sure exactly how custom it may be).  The kernel name (what shows up on a uname -r query) is 4.4.38+.
When I run your script it recognizes the difference in names - I try to do the forcing but still get a "Exec format error" when I run sudo modprobe -f cdc-acm,
I assume this error means that the kernel name missmatch is causing it to reject the module install.
I'm trying to come up with an easy installation solution for my customer, integrating my device (the one that should be using CDC-ACM) with their hardware (the TX2 system).

You can try to insmod it and see if that is a workaround. If you are providing this to a customer, you should compile the module with the correct version magic for your environment.

I'm working now to recompile with the correct vermagic. I'll test that out and report back it if works. (Thanks for the help.)

I recompiled L4T28.1 with the same vermagic name as my installed kernel. I copied the new compiled version of cdc-acm.ko into the installACMModule directory and successfully installed the module by running ./installCDCACM.sh.
The USB device I was attempting to get to load the cdc-acm driver now successfully reports as using the correct drivers.


Bump escargot version to 0.5.7

Part of https://github.com/clap-rs/clap/pull/3172

trycmd v0.8.3 is released.


1.9.0 externalIstiod default value

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
I just started comparing values.yaml files for istiod in 1.8.0 and 1.9.0. In 1.9.0 I see this
# External istiod controls all remote clusters: disabled by default
externalIstiod: true

I am not sure if the docs need to say "enabled by default" or if the default value needs to be "false", but the current values don't add up.
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Docs to align with default values
Steps to reproduce the bug
Download istio 1.9.0 and look at istio-1.9.0/manifests/charts/istiod-remote/values.yaml around line 331
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

I agree its slightly misleading , but this file is autogenerated so there isn't much we can do here.

Is 30845 a fix for this and we can close this issue?

No, I closed the fix. I don't think we will fix this since the file is auto generated and we don't have a reasonable way to modify this


fix(devx): Disable vcs stamping when running in docker container.

Fixes #1789
I put this at the top level to pass to all hack commands so it covers both the hack-test-unit and hack-build-cli commands (and any future commands that may be affected).

Thank you @webstradev!


Add sent2vec fit

Sent2vec https://github.com/epfml/sent2vec is a library not on pypi that depends on fasttext in order to train a model. As such installing it properly is not as as straightforward as it requires running make and there are not pre compiled distributions we could use. @jdu is of the opinion that we should create those distributions before installing it. @jdu it would be great to know approximately the steps that need to be done in order for this to happen so someone can pick this up in the future

There are two main options:

We precompile usingpython setup.py bdist with some modifications to the repo to ensure that the compiled shared fasttext library and FFI bindings are included.
We rework the repo to have a concrete installation compile-time step.

There are trade-offs between the two.
With N°1 we will have to compile a bdist for each and every platform we want to target (macos x86_64, linux x86_64, etc....) which can get tricky and maintenance heavy quickly.
WIth N°2 that compilation is pushed down to the install phase, but as this incorporates cython and C code it will mean that whoever is installing this will have to have a C compiler toolchain and cython installed in order to use it.
Both these options would require us forking this repo and making significant changes to how it's structured and it's setup.py file in order to make it an installable package.
The Repo Now
The way the repo is now, they've copied the C code from the facebook fasttext library directly into the src folder and generated an FFI binding using cython (src/sent2vec.cpp and src/sent2vec.pyx) as well as possibly they've added additional C code (shmem_matrix.cc?), i'm not sure, the code in the actual fasttext facebook git repo has diverged a lot from when this code was initially copied into the sent2vec repo so it's hard to tell what's facebooks and what items are changes in here.
Some Reference Material
. https://docs.python.org/3.6/extending/extending.html
. https://docs.python.org/3.6/extending/building.html
Example FFI binding repo
This https://github.com/swistakm/pyimgui is a repo where python and cython are used to wrap an existing C++ library using FFI bindings to produce an installable python package, it would be a good reference point to understanding what's required to wrap a C/C++ lib inside of a python package for anyone wanting to tackle this before I start to poke and prod it more.


self-check

please add some self-check command
as if you install via phar, there's no mechanism checking whether environment is suitable for running phan.
as for example i encountered that it needed sqlite3 extension middle of execution, there's no mention of sqlite3 extension installation on install pages. and likely ast extension installation may also fail or wrong php engine used to invoke phan.

@glensc: Any chance you remember what you were running when you got the SQLite required exception? Were you perhaps running with the -s CLI option?
I still have code that requires SQLite in Phan, but we stopped using the feature, so we removed the constraint that the extension should be installed.

[~/scm/eventum/phan (master)⚡] ➔ php ./phan.phar
Unable to read file src/Phan/Output/Printer/CSVPrinter.php
Unable to read file tests/Phan/IntlTest.php
Unable to read file tests/Phan/Output/Printer/CSVPrinterTest.php
RecursiveDirectoryIterator::__construct(vendor/phpunit/phpunit/src): failed to open dir: No such file or directory
PHP Fatal error:  Class 'SQLite3' not found in phar:///home/glen/scm/eventum/phan/phan.phar/src/Phan/Database.php on line 10
[~/scm/eventum/phan (master)⚡] ➔

it's git checkout pointing to 80cda749843a5936e5422e4ce9997d980cc33966

@morria looks like sqlite3 is still required in composer, no?

@morria https://github.com/etsy/phan/issues/282#issuecomment-230265341 is now resolved that you closed?

Hi @glensc. I removed the reference to sqlite in https://github.com/etsy/phan/commit/80ac316b4672dbe6f9c65f4435e67839de2c1335 and for the rest of the dependencies, we check to make sure they're available.
Does that take care of what you were hoping for? Happy to open this back up.


⚠ Thumbnails API Endpoint has degraded performance

In e799e0d, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1729 ms

Resolved: Thumbnails API Endpoint performance has improved in 16bd2a3 after 12 minutes.


Update system-settings-dialog-box-customization-tab.md

Just ran into this issue where I could not shut off admin mode (it caused issues on a client that upgraded to v9.)  The checkbox seems to be disabled in v8.2 as well.  The fix is to use the Power Platform Admin Center (where it can be edited).  Cheers, Nick

This appears to be a bug and I've reported it to the product group. Thanks for bringing this to our attention.


functions within create event for an object aren't picked up as functions

Awesome project you have going on here! don't know what I'd do without multiple pointers in gml tbh
Here's a minor annoyance I found:
#event create
function doStuff() <- does not get highlighted as a function
{
    //etc
}

#event step
doStuff() <- linter complains about missing function, this is not the case

The linter complains that functions within the create event, are missing in the step event, perhaps the linter does not register functions outside of scripts?
I have disabled inspecting for missing functions to resolve this temporarily, hopefully this can be fixed easily.

For in-object functions, you should do:
doStuff = function() {}

Declaration with the function at the beginning making it global.

<- does not get highlighted as a function

It will not be highlighted as a function¹, but I did push a commit that fixes auto-completion and argument info.
Here's a build (to be extracted over the current beta's files): Editor-App-Only.zip
¹ Since that is a choice between highlighting inside with blocks being blatantly incorrect and syntax highlighting becoming much more CPU-intensive due to parsing the code in search for with blocks. Neither are good.

<- linter complains about missing function, this is not the case

Are you using the current version of GMEdit? I don't think that's been a thing for a while - in 2.3 the "missing function" warning basically never shows as you can never be sure that something doesn't get assigned a function using a less-obvious method.

Haven't heard back but this is most likely fixed along with other changes in the new beta.


Add RTL support for accordion caret

Fix for https://github.com/Esri/calcite-web/issues/950

Merging... build failure was unrelated to the PR


Overflow menu example opens in random place in FF

Detailed description
In Carbon V10 website, The overflow menu example opens from an unexpected place. (not next to the overflow menu icon)
Browser : In FireFox (60.6.1esr (64-bit)),
Additional information

Screenshots or code

Thanks for reporting, looking in to it 👀

@asudoh something you have time this week to look at maybe?


guideline for adding new languages is sub-optimum

The guideline for adding new languages should mention what pieces of software script/convert-grammars requires, and possibly also how to get them. Most notably, the message reported if a particular required ruby gem (such as plist) is missing is only remotely helpful for users who are unfamiliar with ruby, let alone ruby gems. Also the script surprised me with an unexpected complaint about some ominous missing or unaccessible file "npm", and I first had to figure out that I'd need to install the nodejs package for that one.
At the very least, the guideline should somehow hint at the fact that this is not a classic shell script relying on standard Unix tools, but a ruby script relying on standard web development tools.
Also, I suspect trying to get the script to run on a Windows machine might be a tad troublesome. Git tools for Windows typically do come with a Unix shell environment, but usually not with ruby or the like installed. Even the GitHub Desktop for Windows doesn't ship with ruby.

Thanks for the feedback @c-lipka. We'd welcome any suggested improvements in the form of a pull request :smile:


feat: ui components migration

@Rickk137 @tiltom I can't find any discussion about why we use CSS instead of SCSS in atom components or we planning to update them later?

We decided not to use Sass in one of our spikes regarding the new dapp. It's not something I think we need to have in guidelines but I updated the existing guidelines so we don't mention scss anymore.


i18n

Hi, whenever I have set, like the doku says, the language in the WARP_LANGUAGE_FILE and restarted the app with a "custom" language (german in this case), all entries and links disappear. Unfortunately, the app does not load the additional i18n file. Do you have an idea what could be causing this?

Hi, can you please upload your german translation file? It's hard to say what's wrong without it.

Hi, yes this could be helpful ;-)
https://github.com/jpboehm/warp/blob/6eebe99fd2be206d37428d4b14aa74f3cfa157ef/warp/static/i18n/de.js

Hi,
so it seems that the file is correct, which means that it is not accessible by the app. How do you run the app, in a container? If so, had you added this file to static folder before you built the docker image?

Hi, I'm a newbie to docker unfortunately (any tips?). But I have started the app in a container.
About the file: I put the de.js in the Static folder (next to the English and Polish variants), adjusted the demo_compose.yaml and fired it up (in one variant also the config.py) and it doesn't work. The app actually does not find the de.js. Have I forgotten essential steps? I am curious how and if it works in "porduction", if I get there.
Thank you already for the quick answer and support.

ok, so please do the following steps:

(just to be sure) check out the project again (git clone ...)
copy your de.js to warp/static/i18n directory
add WARP_LANGUAGE_FILE: 'i18n/en.js' to environment section in demo_compose.yaml
rebuild containers without cache: docker compose -f demo_compose.yaml build --no-cache
run container: docker compose -f demo_compose.yaml up

the problem you had is that docker used cached versions of containers where your de.js file was not present

you are welcome - enjoy!

ahh.. and feel free to make a pull request with your DE translation (when you think it is completed)


[Bug]: scoop can't fetch latest version of sharex-dev and can't install

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
ShareX
Expected/Current Behaviour
Installing 'sharex-dev' (<IP_ADDRESS>) [64bit] from versions bucket
The remote server returned an error: (404) Not Found.
URL https://github.com/ShareX/DevBuilds/releases/download/v<IP_ADDRESS>/ShareX-15.0.0-portable.zip is not valid
Steps to Reproduce
scoop install sharex-dev

Possible Solution
please adjust the sharex-dev release fetch to the latest.
Scoop and Buckets Version
scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
ccb23377b (HEAD -> master, origin/master, origin/HEAD) notepad3: Update to version <IP_ADDRESS>

'main' bucket:
cc5e0a8be (HEAD -> master, origin/master, origin/HEAD) libjxl: Update to version 0.8.0

'nonportable' bucket:
d81345b (HEAD -> master, origin/master, origin/HEAD) spotx-np: Update to version 150-86h

'versions' bucket:
b321e7b73 (HEAD -> master, origin/master, origin/HEAD) chromium-dev: Update to version 111.0.5547.0-r1093907

Scoop Config
scoop config

aria2-enabled last_update                       scoop_branch scoop_repo
------------- -----------                       ------------ ----------
        False 2023-01-18T22:51:55.8175368+01:00 master       https://github.com/ScoopInstaller/Scoo

PowerShell Version
$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.2364
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.2364
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Additional Softwares
No response

Cannot reproduce with current version.
> scoop install sharex-dev
Installing 'sharex-dev' (<IP_ADDRESS>2) [64bit] from versions bucket
ShareX-<IP_ADDRESS>2-portable.zip (50.4 MB) [====================================================================] 100%
Checking hash of ShareX-<IP_ADDRESS>2-portable.zip ... ok.
Extracting ShareX-<IP_ADDRESS>2-portable.zip ... done.
Running pre_install script...
Linking ~\scoop\apps\sharex-dev\current => ~\scoop\apps\sharex-dev\<IP_ADDRESS>2
Creating shim for 'ShareX'.
Creating shortcut for ShareX Dev (ShareX.exe)
Persisting PersonalPath.cfg
Persisting ShareX
'sharex-dev' (<IP_ADDRESS>2) was installed successfully!


I can port this mod for fabric?

This is not an issue, but i reached the 100 server limit on discord, but i can port the mod for Fabric?

Sorry, I forgot to reply to this. You can port the mod to fabric if you'd still like to. It would be preferable if you could join the mod's discord server.


ClientModel Prototype: Evaluate using nullable annotations instead of OptionalClientResult

Investigation for https://github.com/Azure/azure-sdk-for-net/issues/40568

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core

Per offline discussion, result/response hierarchy is now:
ClientResult <- ClientResult<T> <- NullableResponse<T> <- Response<T>


Change version to 1.0.0

We haven't had a 1.0.0 so 1.1.0 is wrong.

IMO it's too late to make this change since 1.1.0 has already been used. Otherwise it will create confusion when you do make it to 1.1.0.

It has never been release except for snapshots.

artfiacts exist in public, snapshot or not, that in my book is a release :)

Snapshots don't count IMO. When we move to 1.1.0 for real the timestamps will override anything so far deployed.

okay


Update Gson to version 2.9.0

Gson 2.9.0 has been released. It fixed google/gson#1875. After updating to 2.9.0, I think we can remove --add-opens java.base/java.util=ALL-UNNAMED, which was previously added to workaround the illegal access issue.

Nice, it pained me to add that JVM argument...thanks!


Gmail and Keep do not open on the grounds that the browser is not secure.

Gmail and Keep do not open on the grounds that the browser is not secure.

Please refer to https://github.com/getferdi/ferdi/issues/264 🙏 I have renamed the title of https://github.com/getferdi/ferdi/issues/264 to include "Google Issues Megathread" as the issue was pinned but couldn't be easily identified as containing the infos it contains regarding the Google issues.
Thank you!


Separated CommandBox and ResultsDisplay

Fixes #91

Ready for review?

yes.

Noted. As before, use labels to indicate PR status.

changes made.

I'll merge after updating diagrams.

Updated diagram. Waiting @lejolly 's input on another comment.

ok changes made.


HTTP API updates

Let's start adding some basic bells and whistles:

some kind of fluency around building http requests
some kind of fold/foldwith functionality on StreamedHttpResponses
ability to pull types other than Strings from headers
maybe a few others will add comments and such as they get fleshed out

I would think some specific handling for common headers would be nice. A good example is cookie - they're commonly used and reading/writing them is a PITA that we should handle in the framework.

I think we definitely need more cleanup on the pattern matching stuff.  I have a super-old branch somewhere with a new method where you create your routes outside the PartialFunction.  I think that may work really well since we can make the API much more flexible (since we're not at the mercy of unapply) and it should work nicely with the new TagDecorator for adding route and response code tags.

Request parameters as well.  Having a way to match and type those would be badA

Hi, I'm also facing the issue of having to manually add headers that (on other frameworks) would be default. Just curious to know if it would make any sense, for example, to have default Content-Type to plain/text. My two cents here. Thanks!

Closing this because the http API has improved dramatically since this was created.  I'm sure there's still plenty of room for improvements, but we can open smaller, more focused issues for those changes.


[DIR-705] Add submit buttons to inputs in filters

:rocket: preview: https://direktiv-ui-refs-pull-437-merge.direktiv.dev/
Changes

Uses InputWithButton to add a submit button to the time input in the instance filters
Ditto for the TextInput for filtering by name
Fixes a serious bug I noticed by chance: The guard I had previously added to check that time values are not undefined also prevented them having a value of "0".

@stefan-kracht, thanks for the feedback. I updated the submit button icon to ArrowRight, as suggested (17671d312335b4008a794bae571b6fbc6de4bb34)
Regarding the width of the time input, I am not sure what's the best approach. There is no explicit width set on the element. The input uses w-full and the parent (Command component) uses w-min. Maybe changing it to (or adding) min-w-min would solve the issue? Since I cannot see the issue under Linux, I can't try out possible fixes. Could you maybe investigate a fix that works on your Mac?

@stefan-kracht, thanks for the feedback. I updated the submit button icon to ArrowRight, as suggested (17671d3)
Regarding the width of the time input, I am not sure what's the best approach. There is no explicit width set on the element. The input uses w-full and the parent (Command component) uses w-min. Maybe changing it to (or adding) min-w-min would solve the issue? Since I cannot see the issue under Linux, I can't try out possible fixes. Could you maybe investigate a fix that works on your Mac?

I merged the base branch into this branch and had to fix one tiny issue, that broke the layout. And I deleted an old proof of concept component that was not in used as well.
I can reproduce the time input issue outside our app. So it's a Mac/Chrome/Retina related bug. Let's just ignore that for now.

Feel free to merge 🚀


Mixin fails to apply on 1.21.4

Game environment
M1 MacBook Pro
Minecraft version 1.21.4 (the issue can date back to 1.21.2, though)
Fabric Loader 0.16.9 with Fabric API 0.110.5 for 1.21.4
Java 21 (bundled Microsoft runtime)
Steps to reproduce

Install FAPI and Hide Arrows on Fabric 1.21.4 (or any 1.21.2+)
Launch the game
Initialization screen progress bar fails
Stuck on initialization screen

latest.log

Thanks for reporting this. I have posted an update which should now support these new Minecraft versions!


Moving to Coming Soon until go live 3-30

Hi @charislove, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@charislove
Please remove this file from the repo. We can't publish an article that just says "coming soon", and the formatting will likely break the publishing release for Azure.

Hi, this was an ask from the marketing team, as it is a live page announcing new branding and they are very concerned about it getting leaked. Please r me with any questions, chlovel.


bumping the version to 1.0.5

Codecov Report

Merging #731 into master will decrease coverage by 35.66%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #731       +/-   ##
===========================================
- Coverage   51.23%   15.57%   -35.67%
===========================================
  Files          76       10       -66
  Lines        5295      642     -4653
  Branches      901      111      -790
===========================================
- Hits         2713      100     -2613
+ Misses       2197      542     -1655
+ Partials      385        0      -385

Impacted Files
Coverage Δ

...s/docs-markdown/src/controllers/bold-controller.ts

...docs-markdown/src/controllers/cleanup/utilities.ts

...arkdown/src/controllers/redirects/sortRedirects.ts

...down/src/controllers/cleanup/handleYamlMetadata.ts

...down/src/controllers/snippet/snippet-controller.ts

packages/docs-markdown/src/helper/output.ts

...cs-markdown/src/controllers/redirects/constants.ts

packages/docs-markdown/src/helper/AllowList.ts

...markdown/src/controllers/row-columns-controller.ts

packages/docs-markdown/src/helper/format-styles.ts

... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162f2f0...2d8e974. Read the comment docs.


#3193 Show clients and projects id on the projects page

Targets #3193

Description

The projects page of the Coloredcow portal has undergone some modifications to include the identification of Clients and their respective project IDs. However, the current version of the page does not display the Clients' IDs and Projects' IDs.
The inclusion of these IDs would provide valuable information regarding the number of clients and their associated projects.

Approach
I examined the Projects index page and reviewed the controller, view page, in order to retrieve information from the clients table and project table. To accomplish this, I referred to the Laravel documentation to understand the process of fetching data from tables and displaying variables in the blade file.
Before the changes the projects page looks like this :

After the changes projects page looks like this :

Expected Time

Examine the Projects page related code files. 0-1 Hour
Review the code files. 0-1 Hour
Making the required changes. 1-2 Hours

Total Time = 2-3 Hours
Actual Time

Examine the Projects page related code files. 0-1 Hour
Review the code files. 0-1 Hour
understand the process of

Models in Laravel.
fetching data from tables.
displaying variables in the blade file.
2-3 Hours

Making the required changes. 2-3 Hours

Total Time = 7-8 Hours
Accessors-
https://laravel.com/docs/5.4/blade#displaying-data
https://laravel.com/docs/5.4/eloquent-relationships
Checklist:

[x] I have performed a self-review of my own code.

@ImRishabhRawat Please resolve the merge conflicts.


robusta playbooks push fails if robusta is installed in namespace other than default and namespace is not specified

Describe the bug
robusta playbooks push fails if robusta is installed in a namespace other than the default namespace and the --namespace flag is not specified. Since it is not recommended to have pods in the default namespace, it is common to install robusta in its own namespace.
To Reproduce
Steps to reproduce the behavior:

Install robusta in a namespace other than the default using helm install robusta robusta/robusta -f ./generated_values.yaml -n robusta --create-namespace
Create a custom playbook repository by following https://docs.robusta.dev/master/developer-guide/actions/playbook-repositories.html
Load the playbook using robusta playbooks push ./my-playbooks-project-root
See an error

Expected behavior
An appropriate error should be displayed instead of the python erorr.
Errors
======================================================================
Uploading playbooks code...
======================================================================
No resources found in default namespace.
======================================================================
Runner pod not found.
======================================================================
======================================================================
Fetching logs...
======================================================================
Error from server (NotFound): deployments.apps "robusta-runner" not found
Traceback (most recent call last):
  File "/home/avinashupadhyaya/.local/bin/robusta", line 8, in <module>
    sys.exit(app())
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/robusta/cli/playbooks_cmd.py", line 84, in push
    return
  File "/usr/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)
  File "/home/avinashupadhyaya/.local/lib/python3.9/site-packages/robusta/cli/utils.py", line 93, in fetch_runner_logs
    subprocess.check_call(
  File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'kubectl logs  deployment/robusta-runner -c runner --since=1s' returned non-zero exit status 1.

Robusta version
robusta version
version 0.8.26

Additional context
Sorry, I opened the issue without checking for the namespace flag. I found the namespace flag but would like appropriate error messages to be displayed if possible.

+1
If the pod doesn't exist then we should say so and recommend using the namespace flag if necessary. No need for a long exception.
@avinashupadhya99 any interest in working on a PR for this?

I just realized that the exception logs are from the Fetching logs... section, which is displayed for both positive and negative scenarios. Should we not display logs if the command fails? Or should I just update the error message suggesting to use a namespace flag if the robusta-runner pod does not exist?
Looking at the logs for a new user, it feels like the command crashed and printed exceptions but it is by design to print the logs. Should we display the logs in case of exceptions?

I think there are two issues here that should be fixed:

If the runner pod doesn't exist then fetch_runner_logs throws an exception. It would be better if it just printed something like "Cannot fetch logs. robusta-runner not found."
In the push command we should check if the runner pod exists. If not, we can print an appropriate message suggesting you set --namespace and exit. (I don't think it matters in this case if we call fetch_runner_logs or not because after fix 1 that will just print "Cannot fetch logs. robusta-runner not found." which is fine.)


[hardened_site] harden project website, repo and downloads

(This is required for gold status under CII.)
The project website, repository (if accessible via the web), and download site (if separate) MUST include key hardening headers with nonpermissive values.
(see: https://github.com/coreinfrastructure/best-practices-badge/blob/master/doc/other.md#hardened_site)

We may already be catering for this if we're signing our Maven releases, and Maven Central is where we expect people to obtain the releases.  I haven't read the details here, but this might help: http://www.sonatype.com/people/2010/01/how-to-generate-pgp-signatures-with-maven/
Again, I haven't investigated the detail, but an important consideration is usually that the keys used for verification are kept in a separate location from the released artefacts themselves.

@bramwelt Can you confirm our keys are kept securely/seperate?

@planetf1 @cmgrote Yes, keys are kept separate from the code for signing. For the previous releases artifacts were signed by keys stored in a signing server (Sigul) - Artifacts were passed to the signing server, then signatures were returned; and for this release they'll be signed by Bintray's site-wide keypair, which signs the artifacts as they're uploaded to the distribution repository.

Just a question of addressing my own ignorance here, then, most likely...  Is there a common pattern by which someone can verify the downloaded artifact against that separate key, after having downloaded the artifact (to ensure no potential man-in-the-middle replacement of code in the artifact or the like)?

@cmgrote The key pair link in the post my trevor above has the binary GPG public key. Looks like http://branchandbound.net/blog/security/2012/08/verify-dependencies-using-pgp/ covers how to then use to verify?

I believe we've met this one via GitHub itself (see results from https://securityheaders.com/?q=https%3A%2F%2Fgithub.com%2Fodpi%2Fegeria&followRedirects=on)
Specifically, it makes use of the following key hardening headers with nonpermissive values:

Strict-Transport-Security
X-Frame-Options
X-Content-Type-Options
Content-Security-Policy
X-XSS-Protection

@cmgrote it sounds like we're nearly there on this one and you're the expert :-) (removing myself)


Workaround for watching in TextMate etc.

An edit in TextMate on OS X triggers the events CHMOD and REMOVE.
This makes fsnotify stop watching that file.
This commit works around that problem by re-adding the file to the watcher on REMOVE if the file still exists.
See #1053

Note: This PR is a better fix:
https://github.com/go-fsnotify/fsnotify/pull/111

:heart:


[release-0.53] [vmi-mutator-webhook]: do not inject LimitRange defaults into VMI

Signed-off-by: enp0s3<EMAIL_ADDRESS>This is a manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/9054
What this PR does / why we need it:
There were merge conflicts in the e2e tests because of recent refactors in the main branch
Which issue(s) this PR fixes
https://bugzilla.redhat.com/show_bug.cgi?id=2152534
Release note:
NONE

/lgtm


C# tool scripts without a parameterless constructor crash the editor on build

Tested versions
Reproducible in 4.2.1.stable
System information
Godot v4.2.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 580 Series (Advanced Micro Devices, Inc.; 31.0.21905.1001) - AMD Ryzen 7 2700X Eight-Core Processor (16 Threads)
Issue description
Problem
If you instantiate a C# tool script that has no parameter-less constructor in a scene and then rebuild, the editor will crash.
This can happen if you instantiate the tool script through another tool script.
Expected behavior
I expect the editor not to crash and instead output an error message telling that it couldn't instantiate the culprit script.
AFAIK C# tool scripts always need a parameter-less constructor so I don't expect the editor to be able to reload such scripts. However the editor shouldn't crash because of such scripts.
Steps to reproduce

open scene.tscn in the MRP
build a first time
reload the editor (an instance of a tool script without a parameter-less ctor will be added to the scene)
change the source of any C# script (e.g. add a newline)
rebuild
the editor crashes

Minimal reproduction project (MRP)
MRP.zip

I was able to reproduce this in 4.2.1.stable.mono and 4.3.dev.mono.custom_build.
Crash occurs in CSharpLanguage::reload_assemblies when checking the pending reload instances:
	// The script instance could not be instantiated or wasn't in the list of placeholders to replace.
	obj->set_script(scr);
#if DEBUG_ENABLED
	// If we reached here, the instantiated script must be a placeholder.
	CRASH_COND(!obj->get_script_instance()->is_placeholder());
#endif

Calling set_script() like this seems strange, because it will internally try to instantiate the script instance again, which obviously fails, resulting in a null script_instance and a subsequent null pointer crash when trying to call is_placeholder().
Adding a null safeguard to the CRASH_COND condition can prevent the editor crash with seemingly no ill effects, but the intended/expected behavior here isn't super clear.


[Feature] CLI Parameter for packages-install-path

resolves #9932
Problem
In the docs, under target-path, it says:

Just like other global configs, it is possible to override these values for your environment or invocation by using the CLI option (--target-path) or environment variables (DBT_TARGET_PATH).

However, the cli option for packages-install-path does not exist.
Solution
Add a CLI parameter --packages-install-path which populates DBT_PACKAGES_INSTALL_PATH in the same way --target-path does this for DBT_TARGET_PATH
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
[ ] This PR includes type annotations for new and modified functions

We're closing this for the reasons in https://github.com/dbt-labs/dbt-core/issues/9932#issuecomment-2221122673, but open to hearing additional examples or use-cases.


PF-281 Fix the publish workflow to start up Postgres for its unit test runs.

Broken in PR #11
Maybe later we should investigate having the publish workflow use the test workflow instead of copying its test executions.

Broken in PR #11
Maybe later we should investigate having the publish workflow use the test workflow instead of copying its test executions.

Is this about gaining some level of code sharing between the workflows? I looked at this briefly when Isaac introduced the "matrix variables approach" in WSM, but GitHub's support for any level of code sharing seemed unfortunately quite lacking.

Some kind of code sharing or workflow re-use. Or say, only run this workflow after the test workflow has passed on develop. I didn't look at what matrix variables are.


Loading images from XCAssets

Is there a way to load image from the XCAssets bundle into a UIImageView or a UIButton?

You could use [UIImage imageNamed:@:""] for that as this caches the image in the app memory cache.


Redirect with destination params is broken in studio view

When a not-logged-in user opens a sturio url, the getDestinationParam function returns /login?destination=login instead of a proper destination params.
p.s. Check StudioContainer.

This happening from any url (eg: https://bbp.epfl.ch/nexus/web/admin/public/sscx ) that requires a redirect.


Win8-IE11 UA detects Desktop as Tablet

When using Internet Explorer on a Windows 8 Desktop (which does not have Touch feature) the Device detected is shown as a Tablet.
When using Chrome on the same machine, the Device detected is shown correct i.e. Desktop/Laptop.
The userAgent that is captured for IE11 is -
Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; .NET4.0E; .NET4.0C; .NET CLR 3.5.30729; .NET CLR 2.0.50727; .NET CLR 3.0.30729; Tablet PC 2.0; rv:11.0) like Gecko

What kind of device is that?)

I'm also curious what the exact device is you are using. Might help me solve this :)

It is a normal desktop machine w/o touch screen monitor.
The issue is only when you use IE11.

Surface Pro device are really difficult to detect, a tablet like with mouse or no mouse ? we need something to detect these.

Surface Pro device are really difficult to detect, a tablet like with mouse or no mouse ? we need something to detect these.


Ipv6

Description
Changes proposed in this pull request.
Test plan
Outline the test plan used to test this change before merging it.

Fixes #.

/build

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "172642a40d76f398ae11e8f56b1ea12b1b82bf28"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "e0cc36747789fd78e4f40ac96689e04c1683d5e9"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "46a8419f899ecd950f1a3bca064173c08cc2be28"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "46a8419f899ecd950f1a3bca064173c08cc2be28"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "8c7a44d127fda4ef5c55d9ac9e213bfbebb7b54b"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "c3f9749ee91fc3509e38d32f7148ddd10962ed30"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "8c7a44d127fda4ef5c55d9ac9e213bfbebb7b54b"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "8a95a89c7bbcae3ce62864b1718135e190b61b19"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "55de3c18b54d45ac10306ff6561ea2269fcfdbf5"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "0ebf2f49ae71783ff75d9a417efc9560ba0bcdf8"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "8a95a89c7bbcae3ce62864b1718135e190b61b19"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "a66e3c8600e979998eb27a8f763ae1baafd11f13"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "dff97766f4690460cb1f52f76d7b66a0482d6709"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "8a95a89c7bbcae3ce62864b1718135e190b61b19"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "a66e3c8600e979998eb27a8f763ae1baafd11f13"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "dff97766f4690460cb1f52f76d7b66a0482d6709"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "8a95a89c7bbcae3ce62864b1718135e190b61b19"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "ba6e64866524cba65f909025d2f72dd8e515d74d"
  }
]

/build

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "690683895e65a577eb5731166174e127c56f6bfb"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "ba6e64866524cba65f909025d2f72dd8e515d74d"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "7834fecf5fdae712ef0df23abf099c2cf33d316d"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "3a4416e61d1785550f8874e6e6ce05d471899c66"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "ddda0f0e0809c73553a64568dd2701a6a52146c5"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "c4fa7194a223423cd6932900d50310b84b8c1ce2"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "07cbfac2bf6565be4cb3d98ab1bae41f5ae0dbda"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "c4fa7194a223423cd6932900d50310b84b8c1ce2"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "63321bdb9ed46d7f7ec2c92fbcba6ce6fb47c121"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "e7a1ee784be23777e0e4485e29989b772fa38d85"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "f64a405746c6e1318653d7220bd65cf818abe578"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "e7a1ee784be23777e0e4485e29989b772fa38d85"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "883daa98a9225ae8b05885840d8fcb41ee4a79b8"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "e7a1ee784be23777e0e4485e29989b772fa38d85"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "18054e7d5c349644a3cf6208afff11c2e080d7e3"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "f42cd8f45f5485ae457bea93acf9f72f8132beaf"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "18054e7d5c349644a3cf6208afff11c2e080d7e3"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "9e2d8d08a2e0cb19b8cf2d06838f0eb07142afed"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "18054e7d5c349644a3cf6208afff11c2e080d7e3"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "b3bd5dee923a3007a06cdc3111ddcd8a5ecc5b90"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "b3bd5dee923a3007a06cdc3111ddcd8a5ecc5b90"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "b137088abb1efdd19563bff747b6e31bef0b5871"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "b137088abb1efdd19563bff747b6e31bef0b5871"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "32399f4051eee8ca79473884d39361bf9b613499"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "3892aa9c01816f7704a176c41aa7eec8a975d60f"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "2a135cfc266b19dc3a149354a2218cc9beaade65"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "2a135cfc266b19dc3a149354a2218cc9beaade65"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "3892aa9c01816f7704a176c41aa7eec8a975d60f"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "2a135cfc266b19dc3a149354a2218cc9beaade65"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "3892aa9c01816f7704a176c41aa7eec8a975d60f"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1039",
    "commit-sha": "03055e06527bb6bccb190f5bebf2cbffb9cf73ae"
  },
  {
    "project": "",
    "component": "netlink-go",
    "pr-id": "45",
    "commit-sha": "dac4a66fcbac0ccd73972735f7dfc709950ed6e4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "741",
    "commit-sha": "2137f5828365c68ab534aa75339c6964092a0951"
  }
]


Fix running state behavior with delete

When a dispatch is deleted, the running state change notification telling the actor that it is no longer running will only be sent if there are no other dispatches of the same type running.

@llucax I assume this PR would break jacks battery charging actor?

Isn't this a deja vu of https://github.com/frequenz-floss/frequenz-dispatch-python/pull/41?

Again, I think the most flexible approach would be to track dispatches by dispatch ID, not by type, and then have helper functions/classes to do any sort of merging we could need, like merging dispatches with the same type to be considered one instance.

Not sure where we talked about this, but we talked about it. I think in some PR.

Yeah, I was just seeing the branch and couldn't remember :D


tomllib.load is expecting a file descriptor (not path) with tomllib

I am using python 3.11.0 and therefor tomllib packed with it.
In that situation, call to tomllib.load is expecting a file descriptor,
and thus crash with the given file path.
           config = tomllib.load(path)
I cant simply fix it, because load function API seems to differ between tomllib and toml:

tomllib: https://github.com/python/cpython/blob/9585a1a2a251aaa15baf6579e13dd3be0cb05f1f/Lib/tomllib/_parser.py#L57
toml: https://github.com/uiri/toml/blob/65bab7582ce14c55cdeec2244c65ea23039c9e6f/toml/decoder.py#L113

thanks for spotting this, will look into it asap

From https://realpython.com/python311-tomllib/
Its seems its tomli that should be the fallback, not toml.
I revert the commit with the file descriptors, and it works for me. But I dont want to do PR, since I have no mean of proper testing.


Icons not displaying correctly in taskbar, show up as white pages.

Describe the bug
Icons that used to appear as normal icons have changed into white page icons, this happened a couple of versions ago but recent updates have not fixed it. Have tried removing the icons from the quick launcher and putting them back on but the issue still occurs. This also happens in the Programs menu and in the App Grabber.
Expected behavior
Icons to appear correctly.
System information:

Windows version: Windows 10 Pro 64bit
Cairo version: 0.3.7108.0 - Pre-release
32-bit or 64-bit: 64bit
In Cairo Settings > Advanced, is Cairo set as shell?: Windows Explorer

Screenshots

Interesting, do you know which was the last version these worked correctly in?

I think about 2 versions ago, but they didn't disappear after or during an update, They where there one day, and gone the next, I thought an update would fix it.

Do you know if there were any other changes to your system around the time they stopped working correctly?

Potentially, I couldn't tell you what though.

Hmm, could you try resetting the shell icon cache?

OK, it didn't work initially, but what I did was exit Cairo shell, right click the shortcuts in the start menu and click on properties, I then clicked on change icon and selected the icons already highlighted and applied. I did that for each of the issue icons and then started Cairo shell back up, all icons have returned now. Thanks for the fix!


Bug: 双击表查看数据时报错无法查看数据

Chat2DB Version
3.1.13
Describe the bug
{
"getApplicationMessage": {
"env": "desktop",
"versions": "3.1.13",
"buildTime":<PHONE_NUMBER>906,
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) chat2db/3.0.14 Chrome/108.0.5359.215 Electron/22.3.27 Safari/537.36"
},
"requestUrl": "http://<IP_ADDRESS>:10824/api/rdb/dml/execute_table",
"requestParams": "{"sql":"select * from order","tableName":"order","pageNo":1,"pageSize":200,"total":0,"hasNextPage":true,"dataSourceId":2,"databaseType":"MYSQL","databaseName":"tn_management_system","type":"MYSQL"}",
"errorCode": null,
"errorMessage": "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'order' at line 1",
"errorDetail": null,
"solutionLink": null
}

新接口 execute_table，sql是后端拼的，需要给表名包一下order

建议修改为 前端传入 table name时自动带入table name


Crashes on 20w20a/b. No crash reports given. Mojang did more technical changes, thus, breaking the mod yet again.

This mod hasn't been updated to 20w20a/b

Well, update it then.

Well, update it then.

😐


Is this similar to FLEX?

https://github.com/Flipboard/FLEX

Well I released the original version before Flex came about, so there may be some overlap.
However there's a considerable difference, both in how I present details and also that Peek is read-only.
Its designed as a testing tool for getting the 'truth' about the current state of your app/component. Both tools allow you to inspect properties, etc.. however Peek also has sophisticated reporting tools for communicating back to the development team.

When will an alpha version come out?

Apologies for such a delayed release. But it's available now ;)


Batch events and buffer events from logs API until metadata is available

This PR makes introduces 2 features for handling events generated by Logs API:

Events generated from lambda logs are batched. The batch is bounded by age and size.
Pushback on Lambda logs API if metadata from agents is not available. Due to this behavior, the lifecycle of the extension is also affected since we push back on all log events from the Logs API including the platform.runtimeDone. In case lambda Logs API drops logs due to resource constraints generated by our pushback, a new event platform.logsDropped is published which we log from the extension. Retention of this log event by the logs API is not clear, it might be possible that this log event is also dropped but it hasn't occurred in any of my tests so far.

Closes #311

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-28T10:57:19.974+0000

Duration: 18 min 5 sec

Test stats :test_tube:

Test
Results

Failed
4

Passed
172

Skipped
2

Total
178

Test errors
Expand to view the tests failures
Test / Matrix - PLATFORM = 'macosx && x86_64' / Test / TestInfoRequestHangs – github.com/elastic/apm-aws-lambda

Expand to view the error details
 Failed

Expand to view the stacktrace
 === RUN   TestInfoRequestHangs
{"log.level":"debug","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"extension/client.go","file.line":123},"message":"ExtensionID : b03a29ec-ee63-44cd-8e53-3987a8e8aa8e","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"app/run.go","file.line":45},"message":"Register response: {\n\t\"functionName\": \"UnitTestingMockLambda\",\n\t\"functionVersion\": \"$LATEST\",\n\t\"handler\": \"main_test.mock_lambda\"\n}","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"logsapi/subscribe.go","file.line":73},"message":"Extension listening for Lambda Logs API events on <IP_ADDRESS>:49399","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"apmproxy/receiver.go","file.line":71},"message":"Extension listening for apm data on :49401","ecs.version":"1.6.0"}
{"log.level":"info","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"app/run.go","file.line":129},"message":"Waiting for next event...","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"app/run.go","file.line":146},"message":"Received event.","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:43.139-0700","log.origin":{"file.name":"app/run.go","file.line":147},"message":"{\n\t\"timestamp\": \"2022-09-28T04:04:43.139597-07:00\",\n\t\"eventType\": \"INVOKE\",\n\t\"deadlineMs\":<PHONE_NUMBER>139,\n\t\"requestId\": \"8d49d613-29b5-4ba1-9b03-6f5650cb5a3d\",\n\t\"invokedFunctionArn\": \"arn:aws:lambda:eu-central-1:627286350134:function:main_unit_test\",\n\t\"tracing\": {\n\t\t\"type\": \"\",\n\t\t\"value\": \"\"\n\t}\n}","ecs.version":"1.6.0"}
{"log.level":"warn","@timestamp":"2022-09-28T04:04:43.240-0700","log.origin":{"file.name":"logsapi/route_handlers.go","file.line":39},"message":"Metadata unavailable, signaling lambda to buffer log events","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:44.241-0700","log.origin":{"file.name":"apmproxy/receiver.go","file.line":109},"message":"Handling APM server Info Request","ecs.version":"1.6.0"}
{"level":"debug","ts":1664363084.241715,"caller":"apm-aws-lambda/main_test.go:106","msg":"Event type received by mock APM server : Hangs","ecs.version":"1.6.0"}
{"level":"debug","ts":1664363084.2417548,"caller":"apm-aws-lambda/main_test.go:114","msg":"Hang signal received","ecs.version":"1.6.0"}
{"level":"error","ts":1664363084.4415739,"caller":"apm-aws-lambda/main_test.go:302","msg":"No response following info request : Post \"http://localhost:49401/\": net/http: timeout awaiting response headers","ecs.version":"1.6.0","stacktrace":"github.com/elastic/apm-aws-lambda.processMockEvent\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/src/github.com/elastic/apm-aws-lambda/main_test.go:302"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:44.441-0700","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":244},"message":"APM server Transport status set to Failing","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:44.441-0700","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":247},"message":"Grace period entered, reconnection count : 0","ecs.version":"1.6.0"}
{"log.level":"error","@timestamp":"2022-09-28T04:04:44.441-0700","log.origin":{"file.name":"apmproxy/receiver.go","file.line":105},"message":"Error querying version from the APM server: context canceled","ecs.version":"1.6.0","log.origin.stack_trace":"github.com/elastic/apm-aws-lambda/apmproxy.(*Client).handleInfoRequest.func1\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/src/github.com/elastic/apm-aws-lambda/apmproxy/receiver.go:105\nnet/http/httputil.(*ReverseProxy).ServeHTTP\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/.gvm/versions/go1.19.darwin.amd64/src/net/http/httputil/reverseproxy.go:312\ngithub.com/elastic/apm-aws-lambda/apmproxy.(*Client).handleInfoRequest.func2\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/src/github.com/elastic/apm-aws-lambda/apmproxy/receiver.go:122\nnet/http.HandlerFunc.ServeHTTP\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/.gvm/versions/go1.19.darwin.amd64/src/net/http/server.go:2109\nnet/http.(*ServeMux).ServeHTTP\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/.gvm/versions/go1.19.darwin.amd64/src/net/http/server.go:2487\nnet/http.serverHandler.ServeHTTP\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/.gvm/versions/go1.19.darwin.amd64/src/net/http/server.go:2947\nnet/http.(*conn).serve\n\t/Users/admin/workspace/ibrary_apm-aws-lambda-mbp_PR-316/.gvm/versions/go1.19.darwin.amd64/src/net/http/server.go:1991"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:44.441-0700","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":255},"message":"Grace period over - context done","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:04:44.441-0700","log.origin":{"file.name":"apmproxy/apmserver.go","file.line":259},"message":"APM server Transport status set to Started","ecs.version":"1.6.0"}
{"log.level":"warn","@timestamp":"2022-09-28T04:04:44.541-0700","log.origin":{"file.name":"logsapi/route_handlers.go","file.line":39},"message":"Metadata unavailable, signaling lambda to buffer log events","ecs.version":"1.6.0"}
{"log.level":"warn","@timestamp":"2022-09-28T04:04:44.642-0700","log.origin":{"file.name":"logsapi/route_handlers.go","file.line":39},"message":"Metadata unavailable, signaling lambda to buffer log events","ecs.version":"1.6.0"}
    main_test.go:706: timed out waiting for app to finish
2022/09/28 04:05:08 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0002762b0 <IP_ADDRESS>:49407 in state active
{"log.level":"info","@timestamp":"2022-09-28T04:13:03.021-0700","log.origin":{"file.name":"app/run.go","file.line":206},"message":"Time expired waiting for agent signal or runtimeDone event","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:13:03.021-0700","log.origin":{"file.name":"app/run.go","file.line":104},"message":"Waiting for background data send to end","ecs.version":"1.6.0"}
{"log.level":"debug","@timestamp":"2022-09-28T04:13:03.021-0700","log.origin":{"file.name":"logsapi/event.go","file.line":118},"message":"Current invocation over.   View more details here
Description: gotestsum --format testname --junitfile junit-report.xml -- -v ./...

Running Go tests

Took 10 min 10 sec . View more details here
Description: gotestsum --format testname --junitfile junit-report.xml -- -v ./...

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


typo in Install Tools docs

In the second sentence of the first paragraph under kind:
"This tool it requires that you have Docker installed and configured."
Is it better to remove "it"?
My suggestion is remove "it"
"This tool requires that you have Docker installed and configured."

/triage accepted
/language en
/kind bug
/good-first-issue
/priority backlog
Thanks @kosehy - I agree with your suggested fix.

/assign


autogenerate NOTICE.BINARY from NOTICE and licenses.yaml

Description
This PR migrate binary NOTICE entries to live in licenses.yaml, and adds a new script, docs/_bin/generate-notice-binary.py that uses licenses.yaml and NOTICE to generate NOTICE.BINARY at distribution time. Adapted from generate-license.py.
This should make maintaining the notice file a bit easier, but this PR doesn't include anything to automatically check that everything that needs a notice has one in here, so we will still need to manually make sure the notice or notices are set for a dependency for now.

#8309 and #8310 should potentially be merged and this PR updated prior to getting merged, since those PRs relate to some dependencies that were previously listed in the NOTICE.BINARY that upon looking closer do not appear to be necessary dependencies.


Update Python Version

Describe the task
Update python version from 3.7 to newer version
Purpose
The reason why this task is needed and/or what value it adds.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

A ticket to audit WALLY pipeline should be made first.


Remove --production flag from yarn

(we need to install devtools, which is a dev dep)

@geoknee The hub currently should not rely on devtools when not using Ganache. Let me briefly investigate the devtools error on heroku.

Looks like this change brought devtools into the simple-hub production environment: https://github.com/statechannels/monorepo/pull/1660. I am not sure convinced that was intentional?

Looks like that PR did not make an intentional decision to introduce devtools to the simple-hub production environment.

Closing in favor of https://github.com/statechannels/monorepo/pull/1666


Generated code for client streaming methods forces the client type parameter to implement Debug

Bug Report
When the RPC features client-streaming methods, generated code imposes a Debug bound on the client object's parameter type.
Version
tonic v0.5.0
tonic-build v0.5.0
Description
In the generated code, the gRPC client method for a client-streaming request looks like this:
        pub async fn push_headers(
            &mut self,
            request: impl tonic::IntoStreamingRequest<Message = super::Header>,
        ) -> Result<tonic::Response<super::PushHeadersResponse>, tonic::Status>
        where
            T: std::fmt::Debug,
        {
            self.inner.ready().await.map_err(|e| {
                tonic::Status::new(
                    tonic::Code::Unknown,
                    format!("Service was not ready: {}", e.into()),
                )
            })?;
            let codec = tonic::codec::ProstCodec::default();
            let path = http::uri::PathAndQuery::from_static("/iohk.chain.node.Node/PushHeaders");
            self.inner
                .client_streaming(request.into_streaming_request(), path, codec)
                .await
        }

It's not clear what in this code would make the Debug bound necessary. Code generated for methods with other streaming signatures, including bidirectional methods, does not impose this bound.

I see why https://github.com/hyperium/tonic/blob/master/tonic-build/src/client.rs#L227 😅 That definitely was committed by accident! Sorry about that.
I made a quick fix https://github.com/hyperium/tonic/pull/719. Will try and get a release out quickly.

Fix is published as part of tonic-build 0.5.1


⚠ ClamAV has degraded performance

In ccc6115, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 88 ms

Resolved: ClamAV performance has improved in 0c6f865 after 5 minutes.


Three second delay after Auth Failure

The throttle code that imposes a three second delay ("Voluntary Backoff") if the headers received from the server don't include the X-Rate-Limit info. This happens most commonly when you have an authorization failure. It "works" but you wait an unnecessary 3 seconds to find out you have bad creds.
[ fixed already in my dev tree awaiting eventual commit/release ]

Fixed in 1.0.1 gem


fix firefox password amnesia

Stop fooling Firefox's password manager

:+1:

:+1: Looks like ready to go


Handle one-shot false good against TUR at failover process

Summary of changes
This pull request includes following changes or fixes.

Fix of issue #409

Description
Try to fetch the stable (3 straight same response) from the drive for detecting the new path for failover is as same as previous path or not.
Fixes #409
Type of change
Please delete items that are not relevant.

Bug fix (non-breaking change which fixes an issue)
Especially this change is a kind of workaround, LTFS doesn't expects one-shot false good response from the drive at all

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have confirmed my fix is effective or that my feature works

I will merge this in advance with self review.

Also merged to the master branch by cherry-pick


Allow view modifications in placeholders

Add onBindPlaceholder method within BaseBrick in order to have full control over placeholder views.
This method will be called instead of the onBindData method by the BrickRecyclerAdapter when data is still not ready.

Codecov Report

Merging #65 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage     89.71%   89.64%   -0.08%
  Complexity      391      391
============================================
  Files            24       24
  Lines          1089     1091       +2
  Branches        190      190
============================================
+ Hits            977      978       +1
- Misses           49       50       +1
  Partials         63       63

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/wayfair/brickkit/brick/BaseBrick.java
95.71% <0%> (-1.39%)
30 <0> (ø)

...ava/com/wayfair/brickkit/BrickRecyclerAdapter.java
97% <100%> (+0.01%)
54 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f132b1...4acc04f. Read the comment docs.


Explicit output of storage mode information in logs

Why you need it?
Is your feature request related to a problem? Please describe in details
目前启动的时候没有明确输出seata-server使用的session和lock的type 如 db，redis，file
加上数据基本上是秒删，导致用户启动后并不是非常直观能知道自己配置的是否正确，需要在日志上增加标识信息
The current startup does not explicitly output the type of session and lock used by seata-server such as db, redis, file plus the data is basically deleted in seconds, resulting in the user not being able to intuitively know whether they are configured correctly after startup, and need to add identification information to the logs
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

please assign it to me

please assign it to me

Looking forward to your pr

@selectbook Since it has been too long without your feedback, this task will be released to others


Missing required files when running preprocess_main.py

There are sections of preprocess_main.py that are commented that prevents the script from successfully completing.
e.g.
https://github.com/hoon9405/DescEmb/blob/cfee6df97722cce9a11ed30bab2dc7dee358b4dd/preprocess/preprocess_main.py#L110
which leads to the following error,
FileNotFoundError: [Errno 2] No such file or directory: './data_input_path/mimic/mimic_cohort.pk'

Hello, there was a serious issue with the Preprocess code, but we have now refactored the preprocess code.
Please let us know if there are any other issues. Thank you.


Update nf-winreg-regenumvaluea.md

Document missing details

@justanotheranonymoususer : Thanks for your contribution! The author(s) have been notified to review your proposed change.


how to management not available route

Hi, thanks for your work.
When a route is not available I get an http status 503 (Service Unavailable). Is it possible to define a hook or middleware to access this response?

Hi @maxmartinezc thanks for liking the project.
Unfortunately, the 503 response code is coming from the low level fast-proxy library and it is not configurable through options.
However, you can just use a custom middleware to intercept and post-process any response such as this 503, please see the entire example below:

'use strict'

const gateway = require('fast-gateway')
const PORT = process.env.PORT || 8080

const middleware503to404 = (req, res, next) => {
  const end = res.end
  res.end = function (...args) {
    if (res.statusCode === 503) {
      res.statusCode = 404
    }
    return end.apply(res, args)
  }

  return next()
}

gateway({
  routes: [{
    prefix: '/service',
    target: 'http://<IP_ADDRESS>:3000',
    middlewares: [
      middleware503to404
    ]
  }]
}).start(PORT).then(server => {
  console.log(`API Gateway listening on ${PORT} port!`)
})

Middlewares can be applied per route, or globally. Just in case you would like to enable this behaviour for all routes.
Regards

Great, it works. Thanks for your help.
Regards


added extra features

Added extra features to you point cloud annotation tool.

extra camera views
able to toggle full screen those view
added a real time update of box details in message box
reduce intensity point cloud
reduce opacity of box

Thanks for your contribution, I will handle this when available.

There are currently some issues, but nothing deal breaking i think. I will try to work on it when i have more time.
Issues:

When an actor is selected, to unselect it, you will need to click on another renderer
In select point cloud mode, if an actor is selected you will need to unselect it if not the label does not work.
Toggle fullscreen using ctrl-z is a little fiddly, do not toggle too quickly.


adding unadj value

Do we want to keep it as value_unadj or rename value to amount and use that for both?

I think value_unadj as the column name we use is value. Yes, it is different from others but the term is taken directly from the chain so is one of those chain-specific conventions


Django 1.9 support

Django 1.9 support probably needs multiple small changes here and there, but one of the first issues to be solved is how to deal with Django 1.9's new app loading behaviour. Since Django 1.8, loading models directly or indirectly from an app's __init__.py is deprecated. As of Django 1.9, it's not working anymore at all. See this thread: https://groups.google.com/forum/#!topic/django-developers/26GdwpmU6KQ
The shortcuts workaround seems like a good idea for me.
I'm happy to come up with a patch.

I'm rather curious: Is there any reason for not defining models in polymorphic.models? That would be quite in line with regular django practices, and would fix the issue.

I'm rather curious: Is there any reason for not defining models in polymorphic.models? That would be quite in line with regular django practices, and would fix the issue.

It's not only the models; many other parts of django-polymorphic depend on the models being loaded. As an example, the manager module depends on the query module, which depends on django.contrib.contenttypes.models.ContentType.

Right, but the question still applies: is there any particular reason for not defining Manager and Models in models.py, and query in some other file (instead of everything in init).

Also interested in the outcome of this. Django 1.9 is out there in release candidate stage with some nice features. Wish we could upgrade asap.

@lorinkoz The linked PR should be ready-for-merge (there seem to be no pending issues on it, merely waiting a response from the devs).
If you can, I'd appreciate you trying out that branch and sending any feedback. :)

What branch is it on? I'd like to test it.
@hobarrera It seems the decision for moving models away from models.py has been made almost 6 years ago 116e2af08b02deed9118a8e71a363ce8b99c9c8e by @bconstantin, perhaps he can explain?

@mvdwaeter: PR, branch

+1

+1

I want to upgrade my project to Django 1.9, but it seems a compatible version is not released yet. Can I upgrade to Django 1.9 or should wait for a compatible release? Thanks.

@mjnaderi There's no stable django19-compatible release yet. I made my own fork temporarily for this (since we needed to upgrade), but I otherwise recommend that you wait for a new release.


Windows: OCI HVRuntime and LayerPaths to options

Signed-off-by: John Howard<EMAIL_ADDRESS>This is the last of the refactoring necessary to bring Windows to a spec which is OCI compliant. Similar to https://github.com/docker/docker/pull/26650, https://github.com/docker/docker/pull/26640 and https://github.com/docker/docker/pull/26577 this moves structures from the hacked OCI spec to CreateOptions for libcontainerd, thus being controlled directly through the runtime, as they should be.
When combining this with the other PRs above (some merged), this gets Windows to a point where the OCI spec can subsequently be moved across to the OCI spec supporting Windows, currently under review in the following PRs: https://github.com/opencontainers/runtime-spec/pull/573https://github.com/opencontainers/runtime-spec/pull/567 https://github.com/opencontainers/runtime-spec/pull/564 and https://github.com/opencontainers/runtime-spec/pull/563.
@wking, @swernli fyi.
@mlaventure @tonistiigi PTAL.

LGTM

Rebased

ping @mlaventure @crosbymichael PTAL!

LGTM


Exposing Context for App.contextType

For React SDK
Hello!
First of all, This is very useful! Thank you for making this available FullStack Labs!
I was wondering if you can expose the Context file for the package for me to reference it in contextType.
Instead of only using render prop strategy, this might also be useful!
If possible, I can also try adding this as a PR myself

Hi @KyruCabading are you proposing having programmatic access to the underlying optimizely object?  You can currently use withOptimizely to inject the optimizely object as a prop in a component.
Is this what you are referring to?  If not could please provide more detail or a small code example so I can better understand the request.
Thanks!


ci: split the ci pipelines for better readability

Description
This PR fixes #

Split not possible as it needs the build artifacts from other file and can't be linked.


Health Maintenance Organization (HMO) and Health Insurance?

Hallo,
Can you share know-how on Health Maintenance Organization (HMO) and Health Insurance?
Thank you.
Health,
SYSON, MICHAEL B. (Representative)

Health Maintenance Organization (HMO) and Health Insurance?
observed: as VALUE, Health Maintenance Organization (HMO) < Health Insurance;
Health Maintenance Organization (HMO)
--> where: if monthly payment stopped, health service via HMO also stopped;
--> adds: monthly payment : 600 PHP*2 (approx)
--> employer and employee pay
Reference:

https://mariahealth.ph/partners/maxicare/; last accessed: 20221110

Health Insurance (Private)
--> voluntary contribution for WORKER
--> where: if monthly contribution stopped, total contribution CAN still be received;
Example:
--> 500PHP/month *10 years = 60,000 PHP
--> 1200PHP/month *10 years = 143,900 PHP
--> adds: it is as with Educational Plan
--> where: monthly contribution system assists Family Unit
--> to execute Income > Expenses for children's education
--> adds: however, monthly school tuition (private) COST currently @ > 4K~10K PHP/month
--> where: COST based on school
ACTION#1
--> recommends: as based on own action, to use PESO-BOND due to higher interest rate than the Education Plan product after computation and discussion with, e.g. Bank Unit Member;
ACTION#2
--> recommends: as based on own action, to put in lower priority HMO payments;
--> where: has eventually stopped monthly HMO payments
--> opts: for LIFESTYLE CHANGE, and Health Insurance (Public and Private)
--> adds: increase know-how in health, et cetera
Reminder
PhilHealth : Health Insurance (Public)
--> required monthly contribution from WORKER (employee)
Thank you.
Health,
SYSON, MICHAEL B. (Representative)


New doc gen started from Matt's PR

Follows on https://github.com/blockstack/blockstack.js/pull/628 I'll rebase after it is merged.

Usersession.getOrSetLocalGaiaHubConnection not previously exposed should it be?
Did we intend to deprecate the getFileURl cin storage/index.ts ?
As far as the include files go, right now I have most of them attached. I'm mulling whether they shouldn't simply be in the using docs and not in here at all.
storage/index.ts has two functions encryptContent and decryptContent they are not putting out deprecation warnings, should they?
Existing Javascript is not exposing the Profile1 object but we have examples using the toToken` method in there.  I think we want this public

@zone117x @kantai Can I get y'all to take a look at this. I think the first pass is done. I'd like to merge this and then do some fine tune work after the fact.


VSLanguageService -> VFPT.Core

Dependent upon completion of Open Documents Tracker #1410
Much of the functionality of the VSLanguageService can be moved to the LanguageService

unsure how to address buildQueryLexState, to start ignore the conditional branch that requires the ITextBuffer
EntityCache - Can this be re-implemented using a ConcurrentDictionary without the need for lock?
use FCSPoint & ranges instead of SnapshotPoint and SnapshotSpan
*instead of passing the ITextView in GetLoadDirectiveFileNameAtCursor pass the caret position directly
unclear how to migrate and reportProgress from with FindUsages while in Core, save for end

Code Located @
https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Logic/ProjectSystem/VSLanguageService.fs
https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Core/LanguageService.fs

I don't think LanguageService should accumulate more functionality. In fact, I'd like make it lighter. Feature specific code should be spread among other types.


Fix a typo leading to paginate(plt; row, col) failures

I have a plot with many facets that I am not able to paginate using the col and row arguments.
Fixing this typo makes it work properly.

After double-checking, while this solves the error that paginate raised, it does not fix my actual problem... I will look a bit more into this and update this PR. If I can't get to the bottom of it, then I'll close the PR and open an issue.

In the end, I did not read with enough attention the docstring and did not notice that you need to specify row and col in mapping too... Still, I think paginate(plt; row, col) should not throw never throw an error, so fixing this typo is not completely useless even if not particularly useful.


fix paged table page-size selector reloaded from preferences

fix paged table page-size selector reloaded from preferences

merged in master and 0.7.x


About the Motion-Language Pre-training Stage?

Are there some mistakes when choicing a condition?

Hi, @huifu99
Here is the switch for the supervised condition. Currently, we have implemented it in a hardcoded manner, but we will incorporate config item in next version to allow for more flexible configuration.

But you mentioned that both supervised and unsupervised manner are used at the Motion-Language Pre-training Stage. Should I change the code here during training?

Hi, you should not change this training now. This pre-training is prepared for some specific version of MotionGPT, which will come later. You can wait for our online demo for testing and use SFT for training now. We will inform you once this part is ready. Thanks bro!


Rename *.css.scss to *.scss for sass-rails 5.0.3.

In v5.0.3, the sass-rails gem dropped support for the *.css.scss extension https://github.com/rails/sass-rails/commit/d355de9b5aa8b79576c9afcadb58ebe164155861. I tested the gem locally within another Rails app, and it appears to be working, without triggering any more deprecation warnings.

Thank you!

Changes released in v0.2.2

Anything for you, dear!


[FEATURE REQUEST] Support for UPSERT operations using BulkCopy

Support for UPSERT operations using BulkCopy
As of now we can bulk copy data from one db system to sql server. But in this approach, the process fails if a primary key constraint is violated. There is no option to implement upsert kind of operation in the current setup.
Preferred solution
It would be cool if the SQLServerBulkCopyOptions has a parameter like updateIfExists. Using this parameter, users can choose whether to fail the bulk copy or proceed with updating the rows.

This issue needs a more descriptive title.

Hi @pkgajulapalli,
We will investigate and get back to you.

Hi @pkgajulapalli ,
Apologies for the delay, I got carried away with other features and this issue escaped my attention.
Looks like there is no way achieving this using SQL Server bulk load feature. The only close alternative would be using temporary tables and merge command, which would be almost a new feature separate from bulk copy from driver point of view.


Creating a "Getting Started" page for SDKs

🚀 Deployed on https://66172caeb039b4092009e7f6--cozy-fox-0defec.netlify.app


Feature request - specific s3 targets

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
Is it possible to have electron-forge distribute to different folders within a single s3 bucket? Currently I believe we can push artefacts to a single bucket and directory.
I am hoping to be able to push into architecture segregated structures as follows:
s3://bucket_name/releases/darwin/...files
s3://bucket_name/releases/win/...files
s3://bucket_name/releases/lunix/...files
Is this currently possible? Or planned?

We could make this possible by adding a keyResolver config option.  Might look something like so:
s3: {
  keyResolver: (artifactName, platform, arch) => string
}

Would that kind of thing work for your use case?

Thats much cleaner that what I was thinking but yes, perfect.


not able to use addAttributes plugin

The addAttributesToSVGElement plugin will not function without first being defined in the .svgo.yml defaults file.
This should just need to be added to the default plugins config to be allowed for use.

Any update on this? It does not work and I have no idea where to find the .svgo.yml file.

What svgo version are you using? The plugin is available as of 7.0.1. There is a file named .svgo.yml in the base directory of your svgo installation. Near the bottom of that file is a line that reads   - addAttributesToSVGElement. I'd be curious to know if it' there.

You can also enable it in your own config file or through --enable option (as of v0.7.1).

I pulled it in via imagemin and imagemin grabs imagemin-svgo: 5.1.0 which in turns grabbed svgo 0.7.0.
I guess that's where the problem is.
I've added it myself to the file but it does not work properly though.
If I try this:
{
	addAttributesToSVGElement: {
		attribute: ["mySvg", "test"]
	}
}

I will get an error:
Error in parsing SVG: Invalid attribute name
If I try this:
{
	addAttributesToSVGElement: {
		attributes: ["mySvg", "size-big"]
	}
}

I will get an error:
Error in parsing SVG: Attribute without value
Am I using it wrongly here?

Are you able to put this up as a minimal example in a gist or repo? I'll happily take a look to see what's going on, but I'm having trouble understanding from what you've said.
Also, the first example of attribute expects a single string. attributes will accept and array and add all of them.

Nevermind, easy enough to repro.

Yes I thought so as well with the single string for a single attribute and I tried that as well but it does not work. This is repo where my gulpfile is located:
https://github.com/stephan-v/svg-workflow
You can take a look if you want. I will try to see why it is not working.

I am also getting this issue. What was the resolution to using the addAttributes plugin?

{
      addAttributesToSVGElement: {
        attributes: [`mirror-on-bidi="true"`, `is-static="true"`]
      }
    }

The code above works, but I am unable to add an attribute without a value.

This was never resolved since I used this for a research project. I am afraid that the current implementation is broken/unfinished.

the problem still occurs, solution?


Initial Template v0.1.0

No use of framework.

Merge templates from:

https://github.com/iandevlin/html5bones
https://www.w3schools.com/css/css_rwd_grid.asp


TrustedHostMiddleware ignores port in Host header

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
app = FastAPI()
app.add_middleware(
    TrustedHostMiddleware,
    allowed_hosts=["localhost:8000"]
)

Description
Using the provided example code and making a request from localhost:8000 I get an "Invalid host header" response, even though looking at dev tools in chrome the header is Host: localhost:8000
If I change to allowed_hosts=["localhost"] it works fine.
I understand it's a trusted host, and not a trusted port, but seems strange to me that it says invalid host header even though thats exactly what the browser is sending in the host header.
Not sure if this is intended behaviour or not.
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.88.0
Python Version
3.10.8
Additional Context
No response

I don't think you can have port as a part of host. Host names do not contain port🤔

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
app = FastAPI()
app.add_middleware(
    TrustedHostMiddleware,
    allowed_hosts=["localhost:8000"]
)

Description
Using the provided example code and making a request from localhost:8000 I get an "Invalid host header" response, even though looking at dev tools in chrome the header is Host: localhost:8000
If I change to allowed_hosts=["localhost"] it works fine.
I understand it's a trusted host, and not a trusted port, but seems strange to me that it says invalid host header even though thats exactly what the browser is sending in the host header.
Not sure if this is intended behaviour or not.
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.88.0
Python Version
3.10.8
Additional Context
No response

Hey, man!
A hostname is the name of a server, which resolve to one (or multiple) IP addresses. You should not include the port as it have nothing do with hostname, at all.

Hello @blipk
A hostname is the name of a server, which resolve to one (or multiple) IP addresses. You should not include the port as it have nothing do with hostname, at all.

@iudeen @aybruhm
I understand that, but the Host header is passed with a port from the browser, and the TrustedHostMiddleware works on the basis of that header.

@iudeen @aybruhm
I understand that, but the Host header is passed with a port from the browser, and the TrustedHostMiddleware works on the basis of that header.

The port should be specified when you want to run the server, not on the domain name(s).
uvicorn.run(         "backend.apps.core.main:server", host="<IP_ADDRESS>", port=3000, reload=True     )
As you can see here, the domain names (without their port numbers) are been specified. The port that you pass to the uvicorn is where you'll be able to access the domain names.
So if you set the server to run on port 3000. As long as you set the proxy port to use the above port, you should be able to access the domain names.

@aybruhm
I have and can read the docs fine, doesn't make my question invalid just because you don't understand.

The relevant bit of code is here https://github.com/encode/starlette/blob/master/starlette/middleware/trustedhost.py#L38
I agree since the Host header can include port (https://www.rfc-editor.org/rfc/rfc9110.html#field.host)  it should not be trimmed off before the check.

Thanks @jgould22 did not realise this was using starlette underneath.
Have posted the issue on their repo here: https://github.com/encode/starlette/issues/1997


Remote debug - adb connect

Hey! Great work! I managed to put almost everything working.
Now I'm with an issue that not sure is a problem on my side or a missing feature of the android-farm.
On STF, on the "Remote debug" box appears the stf-provider pod IP address

this of course is not accessible outside the kubernetes cluster.
Are you able to use adb connect in any other way? I'm missing something?
Thanks

Hey! Thanks for the reply...
well.. that would be "ugly" in terms of management... I mean every time that somehow the pod dies we have to redo the forwarding...
I guess I will keep everything in kubernetes except the real-provider... not sure if is better, but at least appears to be more stable.


Revert back to antd v4

Overview
There are too many warnings and errors associated with antd v5 right now, might probably be best to wait until Superset addresses this themselves before trying it ourselves.
UI
Reverting back to antd v4

Resolved in 4511d23ceab7e8b1504503a6bd8f4b0a7c10ecf8


Add the sys.snapshot_restore table.

Summary of the changes / Why this improves CrateDB
A user can check the progress of the RESTORE SNAPSHOT statement
by querying the sys.snapshot_restore.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please

@Mergifyio rebase