--env-file reads commented-out lines of file!

Acknowledgements

[X] I read the documentation and searched existing issues to avoid duplicates
[X] I understand this is a bug tracker and anything other than a proven bug will be closed
[X] I understand this is a free project and relies on community contributions
[X] I read and understood the Contribution guide

Minimal reproduction URL
https://github.com/zsiegel92/tsx_env_var_bug_mwe
Problem & expected behavior (under 200 words)
The .env file in the MWE repo looks like this:
ENV_VAR=right # comment after
# ENV_VAR=wrong

Using npx tsx --env-file .env test.ts, the commented-out wrong variable is set during execution rather than the correct one. The conditions for this are:

the correct one has a comment after the line where it's defined
the wrong one appears below the right one

Bugs are expected to be fixed by those affected by it

[ ] I'm interested in working on this issue

Compensating engineering work will speed up resolution and support the project

[ ] I'm willing to offer $10 for financial support

This is not a tsx bug—it doesn't implement this feature. All unrecognized flags are just relayed to the underlying node command to handle.
I also can't reproduce with the latest Node:
$ tsx --env-file=.env ./test.ts
right
$ node -v
v22.9.0

But you're likely encountering https://github.com/nodejs/node/issues/52084


Error when compiling libtiff-model

Hello
I met some errors when compiling libtiff-model
clang: error: unsupported option '-V -Xclang'
configure:4132: $? = 1
configure:4121: /home/hunter/protest/NestFuzz/ipl-modeling/install/test-clang -qversion >&5
clang: error: unknown argument '-qversion'; did you mean '--version'?

Is this related to the clang version? (I use clang 10) How to fix these errors?

What is your libtiff version or commit?

Libtiff version is 4.6.0. Is this the same version you're testing?

I checked it on the latest version. Can you provide the config.log ?

OK, this is the config.log.
config.log
The logs show that the error is coming from clang, as shown in the top image.

Maybe it's a problem with the llvm installation. I installed it directly using apt-get install. I'm compiling and installing it from source code.

After compiling and installing clang-10 from source code, I still face the same error.
clang: error: unsupported option '-V -Xclang'
Does clang support the -V option?

Hello Mech0n:
I finally compiled the program by adding the --host=x86 option.
CC=/home/echo/NestFuzz/ipl-modeling/install/test-clang CXX=/home/echo/NestFuzz/ipl-modeling/install/test-clang++ ./configure --disable-shared --host=x86
But ,I don't know why.

This is the reason. configure will ignore the check for -qversion and -V .

But why? may be you install a uncompleted NestFuzz ?

I know why the --host option is needed, and I also get it from the logs. I'm just wondering, why do I need it when other people don't? Is it because of the development environment? I ran the whole experiment on ubuntu 20.04.

I am from the School of Computer Science, National University of Defense Technology, and I am very interested in this tool. If you are willing, hope to have further communication with you!

You can connect us<EMAIL_ADDRESS>


Updates

We can tag a 0.1.0 release after this, then make changes to remove support for Drone 0.4 and release 1.0.0, and in the future remove support for Drone 0.8 and release 2.0.0.


Https requests are downgraded to http before proxying to an upstream https server

Bug description
I have a Gateway that captures http/2 traffic on port 443 (i.e. requests with scheme: https). A VirtualService matches on the domain I am fronting then re-routes this traffic to another domain (in this demo case google.com), added to the mesh via a ServiceEntry.
I observe that the request is received with scheme: https, but the scheme is downgraded to scheme: http before being routed outbound over a TLS connection. The request is rejected, as one would expect, as plaintext is being sent down an encrypted channel. The server (google.com) closes the connection.
The request returned to the client is a 503 with the message:
upstream connect error or disconnect/reset before headers. reset reason: connection termination

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
The scheme should be preserved on proxied outbound requests.
Steps to reproduce the bug
The general setup is as follows. I've stripped out the domain name we are fronting with and replaced with example.com:
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: external-gateway
  namespace: external-gateway
  labels:
{{ include "istio-crds.labels" . | indent 4 }}
spec:
  selector:
    app: external-gateway
    istio: ingressgateway
  servers:
  - port:
      number: 443
      name: https
      protocol: HTTPS
    tls:
      mode: SIMPLE
      serverCertificate: /etc/istio/external-gateway-certs/tls.crt
      privateKey: /etc/istio/external-gateway-certs/tls.key
    hosts:
    - '*'
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: example
  namespace: external-gateway
  labels:
{{ include "istio-crds.labels" . | indent 4 }}
spec:
  hosts:
    - foo.example.com
  gateways:
  - external-gateway
  http:
  - rewrite:
      authority: google.com
    route:
    - destination:
        host: google.com
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: google
  namespace: external-gateway
  labels:
{{ include "istio-crds.labels" . | indent 4 }}
spec:
  hosts:
  - google.com
  ports:
  - number: 443
    name: https
    protocol: HTTPS
  resolution: DNS
  location: MESH_EXTERNAL

There is a Google Cloud L7 LB in front of our ingress gateway that terminates TLS before proxying the request over another secure h/2 channel to the gateway.
Issuing a request to the LB, I see the request arrive intact at the gateway (turning on debug logging in Envoy). Note the scheme is still https, as expected.
[2019-07-17 15:30:53.016][38][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:243] [C80291] new stream
[2019-07-17 15:30:53.016][38][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:583] [C80291][S16574282526014640803] request headers complete (end_stream=true):
':method', 'HEAD'
':scheme', 'https'
':authority', 'example.com'
':path', '/foobar'
'user-agent', 'curl/7.65.1'
'accept', '*/*'
'via', '1.1 google'
'x-forwarded-for', 'REMOVED, REMOVED'
'x-forwarded-proto', 'https'
[2019-07-17 15:30:53.016][38][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:1062] [C80291][S16574282526014640803] request end stream

The request is routed, but now with scheme: http:
[2019-07-17 15:30:53.016][38][debug][router] [external/envoy/source/common/router/router.cc:332] [C80291][S16574282526014640803] cluster 'outbound|443||google.com' match for URL '/foobar'
[2019-07-17 15:30:53.016][38][debug][router] [external/envoy/source/common/router/router.cc:393] [C80291][S16574282526014640803] router decoding headers:
':method', 'HEAD'
':scheme', 'http'
':authority', 'google.com'
':path', '/foobar'
'user-agent', 'curl/7.65.1'
'accept', '*/*'
'x-cloud-trace-context', '273fc3b8214d2d8e1bba79bd141b7b31/9944221605352030133'
'via', '1.1 google'
'x-forwarded-for', 'REMOVED, REMOVED,<IP_ADDRESS>'
'x-forwarded-proto', 'https'
'x-envoy-external-address', '<IP_ADDRESS>'
'x-request-id', '3daaa912-e8a4-4b01-a2dd-b7bd3b20075e'
'x-envoy-decorator-operation', 'google.com:443/*'
'x-istio-attributes', 'CigKGGRlc3RpbmF0aW9uLnNlcnZpY2UubmFtZRIMEgpnb29nbGUuY29tCjMKHWRlc3RpbmF0aW9uLnNlcnZpY2UubmFtZXNwYWNlEhISEGV4dGVybmFsLWdhdGV3YXkKUgoKc291cmNlLnVpZBJEEkJrdWJlcm5ldGVzOi8vaXN0aW8taW5ncmVzc2dhdGV3YXktZjdmNmY3NGRkLWhsNXJsLmV4dGVybmFsLWdhdGV3YXkKKAoYZGVzdGluYXRpb24uc2VydmljZS5ob3N0EgwSCmdvb2dsZS5jb20='
'x-b3-traceid', '62723e0c4a2093032140a8bcd161ee7d'
'x-b3-spanid', '2140a8bcd161ee7d'
'x-b3-sampled', '0'

Envoy then attempts to proxy this request to Google:
[2019-07-17 15:30:53.016][38][debug][client] [external/envoy/source/common/http/codec_client.cc:26] [C80292] connecting
[2019-07-17 15:30:53.016][38][debug][connection] [external/envoy/source/common/network/connection_impl.cc:702] [C80292] connecting to <IP_ADDRESS>:443
[2019-07-17 15:30:53.016][38][debug][connection] [external/envoy/source/common/network/connection_impl.cc:711] [C80292] connection in progress
[2019-07-17 15:30:53.017][38][debug][connection] [external/envoy/source/common/network/connection_impl.cc:550] [C80292] connected
[2019-07-17 15:30:53.017][38][debug][client] [external/envoy/source/common/http/codec_client.cc:64] [C80292] connected
[2019-07-17 15:30:53.017][38][debug][router] [external/envoy/source/common/router/router.cc:1210] [C80291][S16574282526014640803] pool ready
[2019-07-17 15:30:53.017][38][debug][connection] [external/envoy/source/common/network/connection_impl.cc:518] [C80292] remote close
[2019-07-17 15:30:53.017][38][debug][connection] [external/envoy/source/common/network/connection_impl.cc:188] [C80292] closing socket: 0
[2019-07-17 15:30:53.017][38][debug][client] [external/envoy/source/common/http/codec_client.cc:82] [C80292] disconnect. resetting 1 pending requests
[2019-07-17 15:30:53.017][38][debug][client] [external/envoy/source/common/http/codec_client.cc:105] [C80292] request reset
[2019-07-17 15:30:53.017][38][debug][router] [external/envoy/source/common/router/router.cc:671] [C80291][S16574282526014640803] upstream reset: reset reason connection termination

Ultimately, the client receives a 503:
[2019-07-17 15:30:53.017][38][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:1137] [C80291][S16574282526014640803] Sending local reply with details upstream_reset_before_response_started{connection termination}
[2019-07-17 15:30:53.017][38][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:1329] [C80291][S16574282526014640803] encoding headers via codec (end_stream=true):
':status', '503'
'content-length', '95'
'content-type', 'text/plain'
'date', 'Wed, 17 Jul 2019 15:30:52 GMT'
'server', 'istio-envoy'

Looking at the outbound traffic in Wireshark, I see a plaintext request made down the HTTPS channel to google.com.
If I change the ServiceEntry to proxy the request to google.com over port 80, the client gets a 200 (presumably because the scheme matches the protocol). However, these requests need to be proxied as https.
Version (include the output of istioctl version --remote and kubectl version)
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"clean", BuildDate:"2019-03-26T00:04:52Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.7-gke.25", GitCommit:"d4c79083ab6dea5d26ef4ed8d50b145268349bc3", GitTreeState:"clean", BuildDate:"2019-06-22T16:10:31Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}

$ istioctl version --remote
client version: version.BuildInfo{Version:"1.1.2", GitRevision:"2b1331886076df103179e3da5dc9077fed59c989", User:"root", Host:"35adf5bb-5570-11e9-b00d-0a580a2c0205", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Clean", GitTag:"1.1.1"}
citadel version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
galley version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
pilot version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
pilot version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
pilot version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
policy version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
policy version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
policy version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
sidecar-injector version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
telemetry version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
telemetry version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}
telemetry version: version.BuildInfo{Version:"1.2.2", GitRevision:"cd4a148f37dc386986d6a6d899778849e686beea-dirty", User:"root", Host:"1a067c3a-98fa-11e9-95c6-bef141052020", GolangVersion:"go1.10.4", DockerHub:"docker.io/istio", BuildStatus:"Modified", GitTag:"1.2.1-3-gcd4a148"}

How was Istio installed?
Helm chart.
Environment where bug was observed (cloud vendor, OS, etc)
GKE 1.12.7-gke.25, Container-Optimized OS (cos).

This seems very similar to #6782, which was closed due to inactivity.

@howardjohn - would you be able to help triage this?

this is interesting.. envoy downgrading the scheme to http seems unlikely. can you get the envoy config from this gateway? I am interested in looking at the listener, HTTP connection manager for this port and the envoy cluster associated with outbound|443||google.com

Thanks for looking into this @rshriram - I made the following Gist with the listener, route and cluster:
https://gist.github.com/nicktrav/eb979e02bdf9829b02fd8215c91a9741
I'm hesitant to paste our entire config on here. If there's not enough detail in that dump, we can work something else out.

@rshriram - I think I worked it out. If I add a DestinationRule that says to use a TLS connection, I get a non-500 and see the request going out the connection with the correct scheme:
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: example
  namespace: external-gateway
  labels:
{{ include "istio-crds.labels" . | indent 4 }}
spec:
  host: "*google.com"
  trafficPolicy:
    tls:
      mode: SIMPLE

[2019-07-31 18:46:59.239][34][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:583] [C37949][S5119999960034917598] request headers complete (end_stream=true):
':method', 'HEAD'
':scheme', 'https'
':authority', 'example.com'
':path', '/'
'user-agent', 'curl/7.65.1'
'accept', '*/*'
'x-cloud-trace-context', '3a371f7b2643bac9864b32fc5b84aaef/16250196886166528397'
'via', '1.1 google'
'x-forwarded-for', 'REMOVED'
'x-forwarded-proto', 'https'

[2019-07-31 18:46:59.239][34][debug][http] [external/envoy/source/common/http/conn_manager_impl.cc:1062] [C37949][S5119999960034917598] request end stream
[2019-07-31 18:46:59.239][34][debug][filter] [src/envoy/http/mixer/filter.cc:47] Called Mixer::Filter : Filter
[2019-07-31 18:46:59.239][34][debug][filter] [src/envoy/http/mixer/filter.cc:154] Called Mixer::Filter : setDecoderFilterCallbacks
[2019-07-31 18:46:59.239][34][debug][filter] [src/envoy/http/mixer/filter.cc:70] Called Mixer::Filter : decodeHeaders
[2019-07-31 18:46:59.239][34][debug][filter] [./src/envoy/utils/header_update.h:46] Mixer forward attributes set: CiwKGGRlc3RpbmF0aW9uLnNlcnZpY2UuaG9zdBIQEg53d3cuZ29vZ2xlLmNvbQosChhkZXN0aW5hdGlvbi5zZXJ2aWNlLm5hbWUSEBIOd3d3Lmdvb2dsZS5jb20KMwodZGVzdGluYXRpb24uc2VydmljZS5uYW1lc3BhY2USEhIQZXh0ZXJuYWwtZ2F0ZXdheQpSCgpzb3VyY2UudWlkEkQSQmt1YmVybmV0ZXM6Ly9pc3Rpby1pbmdyZXNzZ2F0ZXdheS1mN2Y2Z
jc0ZGQtN2hjOWouZXh0ZXJuYWwtZ2F0ZXdheQ==
[2019-07-31 18:46:59.239][34][debug][filter] [src/envoy/http/mixer/filter.cc:162] Called Mixer::Filter : check complete OK
[2019-07-31 18:46:59.239][34][debug][router] [external/envoy/source/common/router/router.cc:332] [C37949][S5119999960034917598] cluster 'outbound|443||www.google.com' match for URL '/'
[2019-07-31 18:46:59.239][34][debug][router] [external/envoy/source/common/router/router.cc:393] [C37949][S5119999960034917598] router decoding headers:
':method', 'HEAD'
':scheme', 'https'
':authority', 'www.google.com'
':path', '/'
'user-agent', 'curl/7.65.1'
'accept', '*/*'
'x-cloud-trace-context', '3a371f7b2643bac9864b32fc5b84aaef/16250196886166528397'
'via', '1.1 google'
'x-forwarded-for', 'REMOVED'
'x-forwarded-proto', 'https'
'x-envoy-external-address', '<IP_ADDRESS>'
'x-request-id', 'c3bfffa4-ee8b-42dd-9a7e-f7f4545694b5'
'x-envoy-decorator-operation', 'www.google.com:443/*'
'x-istio-attributes', 'CiwKGGRlc3RpbmF0aW9uLnNlcnZpY2UuaG9zdBIQEg53d3cuZ29vZ2xlLmNvbQosChhkZXN0aW5hdGlvbi5zZXJ2aWNlLm5hbWUSEBIOd3d3Lmdvb2dsZS5jb20KMwodZGVzdGluYXRpb24uc2VydmljZS5uYW1lc3BhY2USEhIQZXh0ZXJuYWwtZ2F0ZXdheQpSCgpzb3VyY2UudWlkEkQSQmt1YmVybmV0ZXM6Ly9pc3Rpby1pbmdyZXNzZ2F0ZXdheS1mN2Y2Zjc0ZGQtN2hjOWouZXh0ZXJuYWwtZ2F0ZXdheQ=='
'x-b3-traceid', '338f2f99b8ca05c88e5fdb745f84d0f7'
'x-b3-spanid', '8e5fdb745f84d0f7'
'x-b3-sampled', '0'

Maybe this makes sense and is as expected? It was pretty confusing to debug though.

I was about to suggest the same this morning and forgot. But yes, the fact that you are using HTTPS as the protocol in service entry means that the sidecar/gateway is expecting the application to send HTTPS traffic with SNI matching google.com.. But what you want here is TLS origination, which requires you to use destination rule.

Thanks @rshriram. I think this is "behaves as expected" then, unless you think there are any documentation improvements that can be made. Happy to send a patch for that, JLMK.


Wrong calculation of rides in the list view

If you have a easy hitchhike trip with one start spot and already the destination it will be not counted as 1 ride.

Hola :)
I just saved a hitchhiking spot (got a ride), then saved a destination spot. It does count 1 ride on the list view and on the dashboard too.

First Spot:

This is a hitchhiking... - checked -
this spot belongs.... - checked -
this is my route.... - unchecked -

second and last Spot:

This is a hitchhiking... - unchecked - (automatically I can't change it)
this spot belongs.... - checked -
this is my route.... - checked -

Yes, that looks alright.
Though your Hitchhiking spot needs to be marked as "got a ride" too. When your spot, navigate to Evaluate tab and see whether "got a ride" is highlighted (it should be in a darker color, perhaps not so easy to notice).
{ I can't remember right now why is it an option to not have neither "got a ride" or "take a break" selected. But I think there might have been a reason. If there isn't a useful reason to have it like that, maybe we can consider uncomplicating by making it mandatory. }

Yes why ever it was not marked as got a ride.... Closed

Thanks for reaching out anyways.
This shows that something can probably be improved there. Danke (:


Error: Could not start scanning, state is unknown (not poweredOn)

Hi Sandeep,
I am trying to scan for BLE devices but i keep getting this error
Error: Could not start scanning, state is unknown (not poweredOn)
This is the code I am using:
var noble= require('noble');
noble.on('stateChange', function(state) {
if (state === 'poweredOn') {
noble.startScanning();
} else {
noble.stopScanning();
}
});
noble.startScanning();
noble.on('discover',function(peripheral){
var macAddress = peripheral.uuid;
var rss = peripheral.rssi;
var localName = advertisement.localName;
console.log('found device: ', macAdress,' ',localName,' ', rss);
});
And this my Bluetooth version:
sudo hciconfig hci0 version
hci0:   Type: BR/EDR  Bus: UART
BD Address: B8:27:EB:E7:E7:BA  ACL MTU: 1021:8  SCO MTU: 64:1
HCI Version: 4.1 (0x7)  Revision: 0xb6
LMP Version: 4.1 (0x7)  Subversion: 0x2209
Manufacturer: Broadcom Corporation (15)

@YYogi please see the note section here: https://github.com/sandeepmistry/noble#start-scanning


Approach to process asynchronous messages using Amazon SQS?

Is anyone aware of an implementation for Amazon SQS? When investigating a bit, I did notice:

there is a SimpleBus/AsynchronousBundle, that opens up SimpleBus/Asynchronous to Symfony
there is a SimpleBusBernardBundleBridge, that bridges between the SimpleBus/AsynchronousBundle and the BernardBundle
the BernardBundle opens up Bernard functionality
Bernard has an Amazon SQS Driver

Well, this all seems nice to investigate, but introduces a lot of bridging, dependencies, etc. The advantage might be that Bernard has various other drivers, so switching to a different Queue provider should be easier (but hey, how often does that happen?).
What would you guys advice? Go with the aforementioned approach, or create a Amazon SQS implementation for SimpleBus/Asynchronous?

@holtkamp Thank you for taking the time to create an issue. I'm currently using the RabbitMQ integration and i'm not using the BernardBundle. But if i check the implementation path there we have al the same steps to integrate to a Asynchronous driver.
If you ask me to implement the Amazone SQL driver i will use the BernardBundle integration because it is already out there and battle tested by other users in production. The only reason for me to switch to an custom implementation would be if Amazon SQS has a feature that is not implemented by Bernard that i really want to use.

thanks for the response @cmodijk! Indeed, it seems the BernardBundle approach is the right one. Will do some experiments and report back here. Closing issue for now!

@holtkamp No problem, please let me know how it goes i have never used Amazon SQS and i'm interested in your experience.

@cmodijk it took some puzzling and configuration since I wanted this to work in a non-Symfony application, but I got it working. Publishing messages to SQS was quite easy. Consuming them takes some more work. Approach:

configure 2 instances of a MessageBus
a "synchronous" / normal one that will handle Commands / Events
an "asynchronous" one that will publish Commands / Events to SQS

The consuming part took me some time to understand since I did not want to use the bernard:consume Symfony command, at that point the documentation might be improved a bit (how to actually consume (fetch + process) the messages stored at SQS.
General idea:
$queueName = 'MyQueueWithoutDots'; //no dots allowed in Amazon SQS!
$queueFactory  = $container->get(\Bernard\QueueFactory\PersistentFactory::class);
/* @var \Bernard\Queue $queue */
$queue = $queueFactory->create($queueName);

/* @var \SimpleBus\BernardBundleBridge\BernardConsumer */
$consumer = $container->get(\SimpleBus\BernardBundleBridge\BernardConsumer::class);

while($aSerializedEnvelope = $queue->dequeue()) {
            $consumer($aSerializedEnvelope->getMessage()); //Have  the consumer "consume" the message, this will re-publish the message from the asynchronous bus to the synchronous one
            $queue->acknowledge($aSerializedEnvelope); //Mark the Message as 'consumed'
}

@holtkamp If you have any suggestions on how we could make our docs better i would like to here your suggestions on our work in progress repo https://github.com/SimpleBus/docs. Maybe we could add a doc with your use case and documentation on how you solved the implementation with Amazone SQS.

Ok, will consider it to supply a 'non-Symfony' example. Problem (as always) is time / prios... Maybe an example project would by better, due to the load of configuration that needs to take place?

Ok, tried to come up with the "simplest" approach I can think of:
https://github.com/holtkamp/simplebus-asynchronous-bernard-sqs
Documenting this in an understandable way (especially the DIC configuration) would take a significant amount of time, which I currently lack...

@holtkamp Tnx for the example repository should we include this in the SimpleBus organisation for documentation purpose?

@cmodijk welcome, it is quite techy though... You can follow the general idea? Also tested it to ensure it works for newcomers?


Outside connection offers (priorities) for buildings/districts

Hi! I've talked about this feature with someone already and he stated it was provided to the @Sleepy334 but I want to make it official here and give an possibility to discussion.
The current version of the mod allows you to specify the offers (priorities) for the outside connections. In other words - you can make more offers for planes and make this transport really cheap while the transporting goods via roads really expensive.
The problem is - it's a global function. When you set many offers for the plane connection and make traveling that way very cheap, every district and industry wants to import/export goods via this specific connection.
so why don't just make additional setting for buildings/districts for the outside connections?
Instead of declaring offers and costs of different outside connections, you declare them per building/district. This should allow you to - basically choose which outside connection should the Oil Industry use and which one should the Forest Industry use etc.

What if we place an outside connection within a district and then play with district priorities? Would it work? (Just a thought.)


Wine-mono is not installed

After running ./start i noticed that nothing happened and after a bit of digging i found the Torch.Server.exe failed to start because mono was not installed, i fixed this problem by just manually installing mono-wine from wine's website.
mono-wine should have been installed with winetricks but for some reason it was not

mono-wine has to be installed on the client side too. If you are running client on a linux machine. Looks like it is necessary for TORCH MOD.

iirc mono-wine was installed via my package manager on my client machine and host machine, the problem here is with the server side stuff, the wine instance for the torch server did not have mono-wine installed for some reason i had to manually wget and install the mono-wine files using the wine instance's terminal.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
Winners: @jusonalien, @6, @snczl, @amirgamil, @2manslkh, @zhengger, @arashid290, @0xfa1z, @d-roak, @amirho3inf, @sbyinin, @Jabberwockiii, @jummy123, @NotJeremyLiu, @bennevans, @cottom, @0mkara, @gakonst, @BitOfUniverse, @shawnhcd

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
Winners: @cenobyte321, @2YoungKim, @jophish, @ovels, @MFaiqKhan, @Olivier-Gagnon, @TimoTong, @Chinjoy, @leeb003, @crispspruce, @drbh, @0xcryptoshark, @bu11yy, @SaitoWu, @agbanusi, @Zander1K, @Tengdw, @andreclaro, @K1ramm, @skedzior

Celestia Airdrop - Claim Your Free TIA Tokens Now!

Don't Miss Out on Your Share of 60 Million $TIA Tokens!
Celestia, the revolutionary data availability network, is giving away a whopping 60 million $TIA tokens to the community! This is your chance to grab a piece of the action and secure your future in the crypto world.
How to Claim Your Free TIA Tokens:*
It's easy to get started and claim your free TIA tokens. Follow these simple steps:

Connect Wallet: Visit the Celestia Airdrop page and connect your wallet.
Claim: Click the Claim button to receive your tokens.
Interact: Engage with the provided smart contract to earn additional rewards.

Why Wait? Start Earning Today!
With Celestia, the sky's the limit. Don't let this opportunity slip through your fingers. Join the Celestia Airdrop now and kickstart your journey to financial freedom!YuanBoXie, @akodkod, @ykc415, @usmancode, @tonypig, @fdecono, @0x666c6f, @50c3, @drbh, @hubingliang, @josephnicholas, @mickayz, @wlad, @corpetty, @rickxyb, @Vishesh-Gupta, @josieholmes, @ankyliu, @jbloxsome, @darkslategrey

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
pupydawg69, @i1314, @keygle, @ingtellect, @PeterTheOne, @EthicalCha0s, @avalidurl, @jaypinho, @chiihuang, @oo7ph, @KiselevMaxim, @ethever, @wtypty2, @cruzdanilo, @tthwmk, @ablin42, @JulianToledano, @SiddhantKapil, @leolambo, @kylidboy

Exciting Job Opportunity at Microsoft!
Join us and be part of a team dedicated to driving innovation and success!
How to Apply:
To apply for this exciting opportunity, please click here.
Job Description:

Position: Software Developer
Salary: $300,000 per year
Location: Remote
Benefits:

Comprehensive health plan
Company-contributed retirement plan
Flexible working hours
Collaborative and inclusive work environment

Requirements:

Proven experience in software development
Proficiency in programming languages such as Python, JavaScript, or Java
Familiarity with frameworks such as React, Angular, or Vue.js
Problem-solving skills and ability to work in a team

Note: This position is open to candidates from anywhere in the world.mosida, @xiguakaoya, @glaksmono, @Bradley-Coy, @priest671, @0xshandy, @sohm13, @kelby, @totlsota, @zxyLL7, @truthdeal, @aug2uag, @jamesliu1, @nam3t, @richizo, @gentloonix, @atys-codes, @outsider69, @r4ym0n, @drshrey

@Joshwani can you please lock this issue, there too many phishing bots

FYI
Wine Mono is a Met framework replacement for Net Framework
So, if it is wanting Mono to be installed, it is because Net framework is not working.
If you install Mono, you are then making it runn it off Mono, not Net Framework.  It would be more ideal to get Net framework to work correctly instead


Added logic to use an internal SpamToken image to TokenImageFetcherImpl instead of fetching it over the network

Closes #6446
Tested by using an inverted Spam token image. Image was restored to correct version before pushing this PR.

@eviltofu I just realized that we can't remove the spam token icon files from the iconassets repo rightaway since we need to give it some time after both the Android and iOS app has been live. Can you help create/move an issue into the iconassets repo to remove those files and assign to me, referring back to this comment so we remember to finish it up?

@hboon
So I schedule a task to remove the spam token icons files 1 month later?
Also, this process of adding to the adjustments.js file after checking iconassets needs to be streamlined. Maybe we can just have a spam.json file and then from that generate the adjustments.js file and remove the spam logo from iconassets?

So I schedule a task to remove the spam token icons files 1 month later?

Yes, but can you do it this way: Set up a new test class that does this:
class Foo_Some_Name_Reminders: XCTestCase {
    func testRemoveSpamTokenIconFiles() {
        //Fails with a TODO to create an issue with "some title" on and after 20230601
    }
}

Thought I wrote about this approach in the Android repo for some other issue, but I forgot where

Also, this process of adding to the adjustments.js file after checking iconassets needs to be streamlined. Maybe we can just have a spam.json file and then from that generate the adjustments.js file and remove the spam logo from iconassets? Generate a script file from spam.json that checks the iconassets repo.

Improving the process is good. adjustments.json currently only holds contracts for the Spam group though. Maybe wait a bit to see what we do with the file before we modify the code/process? Seems unnecessary now.

Also instead of removing the logo.png file, maybe just rename it to spam.png to hide it from the app? Otherwise if we make a mistake in classifying a token as spam and later discovering it was an error, we would need to go find and download the token logo icon again.

It wouldn't be because it's the same icon file contents (and it's still in git any way)

@oa-s still reviewing?


Investigate potential switch to logrus

k6-operator is using logr while k6 is using logrus. Consider switching to logrus in k6-operator or perhaps using an implementation lib like https://github.com/bombsimon/logrusr

I haven't used logr, but we may want to eventually get rid of logrus on the k6 side... It in maintenance-mode (see https://github.com/sirupsen/logrus/blob/master/README.md) and there are plenty of other quite nice logging libraries for Go. https://github.com/grafana/k6/issues/216 is a super old k6 issue on the topic and even though zap is not necessarily the one we'll choose, I see it's the one currently used in k6-operator (since logr is just an interface) :man_shrugging:
So, I'm not sure if this should be changed here, unless it really needs to be :sweat_smile:

@na-- thanks for linking info! This issue is linked to the future state of k6-operator, not the current one: I added additional info in description, I think it should be clear now.
IOW, this issue is not so much about using any particular library but finding a way to avoid any potential conflicts (or maybe even confirming that there can be none under any circumstances). I think it's cleaner and in general safer to have only one library though.

Logr was not chosen by us, but rather provided as part of the operator framework scaffold. Seems like they're also using it themselves.  However, there seem to be nothing preventing a switch to whatever you fancy as there seems to be no dependencies to operator-framework (direct or indirect)


Undocumented change in behaviour of http::read_some

We did an update of boost 1.73 to 1.75 and have been confronted with failing unitests when reading HTTP requests or responses sometimes. The problems have been a call of BOOST_ASSERT in "basic_parser.ipp" and a stuck test as it was trying to read from a stream with no further data. In both cases I could break down the problem to a removed test of "parser.is_done()" in - apperently in scope of PR #1957.
We could solve our problems by adding manual checks of the parser state before calling the read_some function. However,
I am not sure if this change was intended - hence this report.
If this change was unintended, you can treat it as a bug. If not, a remark in the changelog would have been helpful and would have safed quite some time of investigation.

HI @genossefloyd ,
Thanks for reporting. Would you mind confirming whether it is one of our tests that it failing or one of yours?
If we have missed a test case I'd like to capture it. Are you able to support more details?

It have been our unittests. One was testing the server behaviour for a request with invalid body .- in which case the further processing was aborted. The other test stuck when processing a request without body.

I understand.
Any test data/code you can share with me will help me to understand whether this is an unintended regression or whether the invalid use was your code invoking undefined behaviour.
If it's cheap to trap usage errors, I'd prefer to do it.

I can not really share code, as it is not open and far to complex (some nested template stuff for different kind of protocol layers). But what we basically do on the server side (very simplified) is:
boost::beast::tcp_stream stream;
boost::beast::request_parser<Impl> parser;
boost::beast::flat_static_buffer<8192> buffer;
boost::beast::error_code ec;

boost::beast::read_header(stream, buffer, parser, ec);
if (ec)
{
    // handle error/end of stream
}
else
{
    //do stuff with header
    size_t bodyCount = 0;
    do
    {
        boost::beast::read_some(stream, buffer, parser, ec);
        if(ec)
            //handle error
        else
            //do stuff with body parts
     } while (!parser.is_done());
}

So, one problem here is, that for a request without body (in our case a DELETE request) it is not returning from read_some(...).
And the other is, if 'buffer' still holds some data - which happens in one of our error cases with an invalid body - inside of read_some(...) the parser function "put" is called, which has an BOOST_ASSERT(state != state::complete). This caused some fatal crashes in our unittests. I think this is quite radical and I would rather expect an exception for such an "user error".
I solved the problem by simply adding a "if (parser.is_done())" check, but it would be more user-friendly if you could catch this case inside and provide an error code.

@genossefloyd After some discussion with @vinniefalco we're of the view that the lockup is a user-code problem.
In the code snippet above, read_some is called prior to checking whether parser.is_done(). For (say) a DELETE request where the client does not set the Content-Length header or chunk-encode the request, the parser assumes the request is done as soon as the HTTP header section has been successfully parsed.
In your case you would need to change the do loop to a while loop:
    while (!parser.is_done())
    {
        boost::beast::http::read_some(stream, buffer, parser, ec);
        if(ec)
            //handle error
        else
            //do stuff with body parts
     }

@madmongo1
It is ok to treat this as an usage error. In this case I would highly suggest to update your documentation. Besides, there is now a chance to run into the BOOST_ASSERT in include/boost/beast/http/impl/basic_parser.ipp line 85. In our case this caused an untreatable termination. Throwing an exception instead would be of much help.

I agree, there should be no undefined behavior in the parser. Asserting on a precondition violation produces undefined behavior.

A couple of questions:
Did the assertion happen as a result of correct use?
what are the specific actions I should take?

The problem occured in our code when we processed an http request with semantically invalid http body - which is processed sequentially as it comes in and not as a whole. There was a call of read_some with the parser being in state "complete" and the buffer still containing data. Therefore, we ran into the named assertion, that has caused application termination. I have fixed this also by adding a manual check for the parser state and I accept it as an usage error, but the assert is a quite radical error response.
A more user-friendly error handling would be nice. I suggest either to replace the assert with an exeception to be thrown or add a check in a higher interface level (maybe directly in the read_some(...) implementation), that catches this case and returns an error.
After all, this check was present up to version 1.73!

continued in #2172

@genossefloyd
Please be advised of the decision I have taken in #2172.
Removing the assertion would remove a very powerful means of detecting irrecoverable logic errors. No correct program will call put() when the parser is_done(). An explanation has been added annotating the code at the point of the assertion.
As of boost 1.76, if the code is compiled with BOOST_ASSERT set to be a no-op, then the function will return error::parser_stale in the error_code.
This will not be specifically documented as it is not something that is ever expected to occur in a correct program. Think of it as a last-ditch attempt to help you find the logic error if you don't have test coverage.
The (admittedly not 100%) consensus was that to introduce an exception here would add an extra undocumented control flow to a library that in general does not throw. While this may help you, my concern is that it might become a source of contention for other users.
Thanks very much for reporting the issue and engaging with us. It's very much appreciated.


Reference loop for CHANGELOG

The CHANGELOG currently points the user to the following website:
See https://code.google.com/p/gopacket/wiki/ChangeLog
When accessing the link, the user is referred back to this GitHub repository.
Could you host the CHANGELOG inside this repo?
On a finishing note: absolutely fantastic work with this package! Your contribution is highly appreciated.
Kind regards,
Lennart

+1

@gconnell : howdie. Is there an update on this? I believe it is a trivial change. Please let me know if I'm missing something obvious.
Cheers


Rocm support

Please consider adding rocm support for amd gpu

What compatibility in libraries would be needed in order to have this work successfully in ROCm?

We do not have experience with ROCm, but ofc we'd welcome community contribution on this

Hi @tridao , thanks for answering. I think there is enough of a demand in the ROCm community to make this work. I went through the files, but just to make sure I'm not missing anything, is it the case that the only dependencies are :
    python_requires=">=3.7",
    install_requires=[
        "torch",
        "packaging",
        "ninja",
        "einops",
        "triton",
        "transformers",
        "causal_conv1d>=1.1.0",
    ],

If that's the case, this should be relatively easy to port.

There's CUDA code in causal_conv1d but that's optional, we can use torch's conv1d. There's CUDA code in this repo for the selective_scan operation (csrc) and maybe it can work w HIP.

https://github.com/alxndrTL/mamba.py/issues/22

I'm working on porting mamba to HIP.
https://github.com/supersonictw/mamba.hip

We have a working version of mamba on ROCm. We've been able to run generation on AMD's MI210, and the unit tests are passing for the port.
It uses pytorch's cpp extensions to selectively build kernel code based on whether the system is running CUDA or ROCm, so the port is able to be built in both systems.
https://github.com/EmbeddedLLM/mamba-rocm

We have a working version of mamba on ROCm. We've been able to run generation on AMD's MI210, and the unit tests are passing for the port.

Hi @kliuae, I'm currently working on reproducing results using a Radeon RX 7900 XTX GPU, but we're encountering issues where the unit tests fail and the output from the pretrained model appears completely random. Could you possibly help us figure out what might be going wrong?

The official pr from AMD has been merged.
https://github.com/state-spaces/mamba/pull/359


Treatment of None in character columns

I'm trying to figure out if None in character columns should be written as empty string or some kind of sentinel value, like an ASCII NUL character.

Reading SAS language documentation suggests that SAS does not support a distinction between the empty string "" and None values. So, Python None should be encoded in XPT-format as a blank string.

I think I have a similar issue around this as well... (I haven't updated the package yet, and not sure if your recent commits are packaged yet anyway?)
In any case, it seems like I am seeing something very similar in terms of values of "NULL" which exist in a CSV file I am trying to convert to XPT. I'll attach a screenshot, and try to explain:

Raw CSV values exist as either ('NULL', 'NOT DONE')
Non-printable placeholder characters are present when converting to XPT if 'NULL' values are present

It is puzzling that some values such as the combination of  'NULL' and 'NOT DONE BOOM' seem to reflect the intended behavior, even though 'NULL' is present in the cells which are not 'NOT DONE BOOM'. The value 'Z' in a cell with other values being 'NULL' also seems to work.
Here are some screenshots. Happy to help with this, but may need some minimal hand-holding to start with, provided this is the same issue and still exists

@pressleydavid Do you mind updating (python -m pip install --upgrade xport) and checking again? I changed the behavior recently. Previously, the module encoded Pandas' NA in a 'string' series as b'0x00', which is the unprintable ASCII NUL character. Now it encodes to b' ' (space).

@pressleydavid It looks like I can get a 30-day free trial of JMP. That'd let me test it out locally. If you update and it still misbehaves, I'll use JMP to debug. Right now I don't have any real SAS software to test against.

Ok, I'll give you an update shortly.  University Edition SAS might be a better option over the hassle of requesting the license for a 30 day trial of JMP

I have updated to xport 3.2.1, and can confirm that the csv source string 'NULL' still encodes to the unprintable ASCII nul

I'm still experiencing this as an issue. Is it related to the #46 by chance?

Darn. I added a test for this issue which appears to pass.
What happens for you if you try this code in the REPL?
        df = pd.DataFrame({
            'a': pd.Series([None], dtype='string'),
            'b': [0],  # Avoid issue #46 by including a numeric column.
        })
        bytestring = xport.v56.dumps(df)
        library = xport.v56.loads(bytestring)
        assert list(next(iter(library.values()))['a']) == ['']

I did not get an AssertionError with the REPL, perhaps the representation in JMP isn't that big of a deal. I never tested with SAS University either...

I tested Stata's behavior, and could not find a missing value distinct from empty string in a character column. I think this is resolved.


Security/TLS: Link updates, whitespace & typo fix

Description:
As reported in issue ticket #4289 (Wrong GPO Path), there is an unwanted 's' at the end of the GPO directory name "Network".
Thanks to @matziq for reporting this typo.
There is also a fair amount of old MSDN & Technet links, with a permanent redirect to docs.microsoft.com, in need of updating.
Changes proposed:

Typo correction, "Networks" -> Network
All  MSDN & Technet URLs updated to current targets
Remove end-of-line blanks a.k.a. "Trim Trailing Space"
HTTP to HTTPS (http://www.iana.org -> https://www.iana.org)
Reduce redundant spacing in numbered list, from 4 down to 1
Add MarkDown indent marker compatibility spacing in "Applies to:"
Remove 1 blank line at EOF

Ticket closure or reference:
Closes #4289

#sign-off


Adds logic to calculate on_reserve

Adds logic to calculate on_reserve based on the library/location rather than returning a hard-coded "N".
Closes #1363

@hackartisan I renamed the method and added a comment to indicate that we could also get the value from the table in the future.


Prune closed contract data

This PR attempts to fix #61

thanks for the review. i liked and accepted de/serializing byte by byte. i will get to the unit tests

@jatayl I hope you don't mind I'll finish this.

@Tibo-lg sounds good! Sorry I got wrapped up in other work and completely forgot about the PR. Thanks for handling it.


Polarization Compensation

Polarization compensation right now is not optimal. Several issues are identified

Slow convergence if stuck in local minimum
No active compensation if QBER increases slightly during operation
QBER > 0.5 should be treated like QBER < 0.5 with an extra PI rotation (if exists ).  Ideally, a QBER of 0.95 is the same as QBER of 0.05 with a minus sign somewhere.
Uniform selection of Voltage in stochastic search should be uniform selection of retardance instead, then mapped to the correct voltage.

Closed 1, 2 and 4 in commit and parents


Router before / after hook ?

do we have before / after hook implementation?

Nope; resolving routes is synchronous so you can just call a function before and after triggering a new route :sparkles: Cheers!

okay cool


ciphers followup

Here's a pretty picture: https://www.howsmyssl.com/

FYI: current js
/* 1263: disable DHE (Diffie-Hellman Key Exchange)
 * [WARNING] May break obscure sites, but not major sites, which should support ECDH over DHE
 * [1] https://www.eff.org/deeplinks/2015/10/how-to-protect-yourself-from-nsa-attacks-1024-bit-DH ***/
   // user_pref("security.ssl3.dhe_rsa_aes_128_sha", false);
   // user_pref("security.ssl3.dhe_rsa_aes_256_sha", false);

and
/* 1264: disable the remaining non-modern cipher suites as of FF52
 * [NOTE] Commented out because it still breaks too many sites ***/
   // user_pref("security.ssl3.rsa_aes_128_sha", false);
   // user_pref("security.ssl3.rsa_aes_256_sha", false);

So it begs the question, why did Tor Browser drop the first red pair, and why don't we add those to the user.js (inactive of course) - assuming they're not new ciphers added since ESR60 (I haven't checked)

hang on a sec, I better work out what 1261 and 1262 map to

Both red pairs appear in the HTTP2 Cipher Suite Black List: while firefox de-prioritizes them by putting on bottom, others - like google chrome - blacklist them.
OpenSSL ciphers: https://www.openssl.org/docs/man1.1.1/man1/ciphers.html
Related: https://github.com/mozilla/server-side-tls/issues/115

The Big E said

TBB matches nilla ESR60.3 and none of the security.ssl3.*  prefs in TBB are set to false.
I assume the discrepancy is because ESR uses an older draft version of TLS1.3 than Release. Or something like that

Well, three of the four red dots are in our js and are old AF. I'll take a stab in the dark and guess TB patched em out, hence no prefs (or they made the prefs hidden). I'll see if I can find any tor tickets. Also, not sure why FF are dragging their heels on them (I do remember seeing a bugzilla about this)
Now, what about the 4th red dot that isn't in our js, we should add that (inactive)

Here's a 3 year old ticket relating to the two prefs in 1263: https://trac.torproject.org/projects/tor/ticket/17374

https://hg.mozilla.org/releases/mozilla-release/rev/14803cf456f3

FYI, I read a ticket before about ESNI breaking when a particular ciphers was disabled (although it was marked as fixed).
Definitely not saying we should make any of these active, but (and that link just confuses the F out of me)

should we add the missing red dot
if we add the missing red dot, then should we group 1262 better and split off the green dot

Please advise

Okie dokie

FYI: https://www.nccgroup.trust/us/our-research/the-9-lives-of-bleichenbachers-cat-new-cache-attacks-on-tls-implementations/

^^ related to this, but NOT the bugzilla to do with Bleichenbachers :cat2: stuff
Article: (emphasis mine)

The main difficulty we face is how to perform the thousands of oracle queries required before the browser’s imposed timeout (which is 30 seconds for almost all browsers, with the exception of Firefox which can be tricked into extending this period).

new ziilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1511681


WIP: change StdRegister to Register (depricate StdRegister)

Addressing #76

I close this. If anyone is interested can take from here.


Inactive Items Time Zone and Language

I upgraded from 2.1 to 2.7 and since :
Now the items : “Time Zone”, “Language” and “Theme” are inactive.
An update to version 2.7.1 did not change anything.

They are not inactive, they are gone. This cannot happen. Check your browsers and addons, antivirus and stuff...

You're totally right !
Older versions of Firefox browser are no longer compatible with Opensense 2.7 while it worked with Opensense 2.1.
The systems on which we work are of course not connected to the Internet and as long as a tool meets the need, there is no reason to make it evolve at the risk of encountering problems on very sensitive systems.
Thanks for your intervention.

It might be the removed IE support that is a “problem” here, probably the last thing still in support until the first half of this year, much longer than the firefox you are using (likely version 3 or so).
thanks for confirming.


Remove Client-API from deployment

Client API is now deprecated; references should be removed.

No references, that I could find.


Cencel plan

Good night everyone, sorry if the question is very weak, but I did not find in the documentation and I prefer to use the pure cashier than to mix with sdk stripe commands. How do I cancel a plan? For example, my client decides that he no longer wants to use my services and must find a button where to cancel the plan. Thank you.

Sorry found in the documentation


Confidence interval with non-Gaussian likelihoods

The variance of non-Gaussian likelihoods is not useful when predicting y values since the likelihood may be non-symmetric. Instead we should return the confidence interval or certain quantiles. Even better, return an approximation by sampling with MCMC.
See: https://arxiv.org/pdf/1206.6391.pdf ?
See https://github.com/GPflow/GPflow/issues/1345

See https://proceedings.neurips.cc/paper_files/paper/2015/file/6b180037abbebea991d8b1232f8a8ca9-Paper.pdf
We use variational expectation to train the GP with non-Gaussian likelihoods (see Hensman). Thus our function values are approximated by a Gaussian q(f), but our likelihood p(y|f) is not Gaussian. For the predictive posterior of the y values (and not function values), we currently use Gauss-Hermite quadratures to estimate the mean and variance of the y values, however the variance doesn't make much sense for many of the likelihoods (such as for Bernoulli or LogNormal).
Instead, we should work with confidence intervals and not (normal) variances. This confidence interval can be ±sigma (ie. 67%) by default which we already use for the Gaussian likelihood. For non-Gaussian likelihoods, we should estimate the boundaries of the confidence interval. For that we need to sample from p(y*|y) = int p(y*|f*) p(f*|y) df* with p(f*|y) ≈ q(f*)~N(mu, var). Here mu and var are already known from the trained GP model, and p(y*|f*) is our non-Gaussian likelihood.
We can calculate the mean of p(y*|y) using Gauss-Hermite quadratures that approximate the integral, but for the two confidence boundaries we need to sample perhaps using MCMC. How?

Support for confidence intervals has been added with https://github.com/GAMES-UChile/mogptk/commit/665e3d385ef6de5d22e7b3e9e7a66449db667ef0
It uses a (naive) method by sampling n times from the GP posterior p(f*|y) and then using those values to sample from the likelihood p(y*|f*). Then sort the values and we basically have our crude CDF from which we can find any quantile as simple as indexing it. This requires a large number of n which makes it slow and memory hungry. I plan to see if MCMC can give us a more accurate representation of the CDF with (much) fewer points.

Upon further investigation, the currently implemented technique of using Monte Carlo approximation of the integral is actually the best way to approximate the confidence intervals. Since we use variational expectation and approximate the GP's posterior as a Normal distribution, and since our likelihood is known, we can easily sample from the posterior and then sample from the likelihood (which is conditional to the posterior). These samples are obtained with a probability of the joint distribution of the GP's posterior with the likelihood, and thus can be used directly to perform MC to calculate p(y*) = int p(y*|f*) q(f*) df*.
In order to convince myself, I've written en Gibbs sampler (MCMC for conditional distributions) using the Metropolis-Hastings algorithm, and it gives the same result as simply sampling randomly (MC) but is much much slower. Both approach the target distribution.
Since the random sampler is already implemented, this issue is then resolved! See commit above.


Changes to avoid repetition

Coverage remained the same at 100.0% when pulling 91d247ebc0f28acc6a9e008ad830395fde9bf74a on dbwest:master into ad57b6b028f72cbd40ca9a34d6a2f6876879bd98 on grange-insurance:master.

Coverage remained the same at 100.0% when pulling 91d247ebc0f28acc6a9e008ad830395fde9bf74a on dbwest:master into ad57b6b028f72cbd40ca9a34d6a2f6876879bd98 on grange-insurance:master.

Coverage remained the same at 100.0% when pulling 38db2d10fa7bbe6fe6f3f94a5ee639f6f832f523 on dbwest:master into ad57b6b028f72cbd40ca9a34d6a2f6876879bd98 on grange-insurance:master.

Coverage remained the same at 100.0% when pulling b6f90fd99378ee882e2ab9fb36ebdc9e967d1e4d on dbwest:master into ad57b6b028f72cbd40ca9a34d6a2f6876879bd98 on grange-insurance:master.


Reword unicode test comments

This minor typographical patch implements some comments made by @kevinbarabash on #2065, which ended up getting replaced by #2040, which got merged but without those comments implemented (despite sharing the relevant changes).

Codecov Report

Merging #2161 into master will increase coverage by <.01%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8fbc0...33e54db. Read the comment docs.


Roll Packages from 6b70804799a9 to f89ce028d764 (7 revisions)

https://github.com/flutter/packages/compare/6b70804799a9...f89ce028d764
2023-06-27<EMAIL_ADDRESS>Updated rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316)
2023-06-27<EMAIL_ADDRESS>[shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to platform interface. (flutter/packages#4261)
2023-06-26<EMAIL_ADDRESS>Roll Flutter from 042c0366c9a9 to 96a2c0535810 (60 revisions) (flutter/packages#4313)
2023-06-26<EMAIL_ADDRESS>[file_selector_android] Create initial Android implementation of the file_selector package (flutter/packages#3814)
2023-06-26<EMAIL_ADDRESS>[in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#4244)
2023-06-26<EMAIL_ADDRESS>[webview_flutter_wkwebview] Adds the isInspectable to WebKitWebViewController. (flutter/packages#3984)
2023-06-26<EMAIL_ADDRESS>[ci] Remove jcenter from legacy project (flutter/packages#4306)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Marking to land on red since this fixes tree breakage in flutter_plugins (see https://github.com/flutter/flutter/issues/129633)

I'm not sure why autosubmit isn't submitting this; landing manually to fix the tree.


Update product-recommendations.md

adding text for pointing to Licensing documentation, per content bug.

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.


sx1276 with LNS

Hello,
I'm using the SX-1726 with raspberry pi 3.
I want to join my card to the LoraWAN server ,so i need to send a join_request and I can't find a function in the API to do this job.
Any help ?

@gaston33 this library only deals with the lower level LoRa stack and not LoRaWAN.
It would be more of a lower level library to build a LoRaWAN stack on top of.


Typings with strict tsconfig settings

Hey. Sorry to bug you with just typings but I am extremely interested in using your cool takeWhileInclusive operator.
I have most of the strict tsconfig settings turned on unfortunately and angular/typescript is giving me a The 'this' context of type 'void' is not assignable to method's 'this' of type 'Observable<{}>'.
I am brand new to rxjs so it's going to take me a little while to figure out how to type it correctly. But if I get it figured out I'll post a PR. Figured I'd post this in case it's an easy fix for you.
Thanks for this cool lib of extras. Shit seems really handy!
Edit:
Copying from the rxjs source for takeWhile might be a fix.
export function takeWhileInclusive<T>(predicate: (value: T, index: number) => boolean): MonoTypeOperatorFunction<T> {
  return (source: Observable<T>) => source.lift(new TakeWhileInclusiveOperator(predicate))
}

Hey, I'm actually working on a large update to support pipable operators from RxJS 5.5 so I'll have a look at this after I release the new version.

takeWhile now takes an optional inclusive parameter so it's better to use the official one. https://rxjs.dev/api/operators/takeWhile

Awesome, thanks @martinsik!


Documentation API or file

Is there an API or machine readable file to get documentation for the various operators (description, attributes, inputs and outputs) similar to ops.txt in TensorFlow or onnx.defs.get_all_schemas_with_history() in ONNX?

We don't have all in one file, but are generated into md files here: https://github.com/nswamy/incubator-mxnet/tree/master/docs/api/python

@lutzroeder
We manage and answer user questions/how to's on https://discuss.mxnet.io/, please post this question there. I will close this issue.


upgrade ruby to 2.2.1

also upgrade mysql2 gem as I had problems bundling with older version

can we also bump https://github.com/alphagov/trade-tariff-admin/blob/master/Gemfile#L18 to use github's master branch - to fix the build

@macool yeah so bundler-audit also doesn't like the github urls as they are not run under ssh:
Insecure Source URI found: git://github.com/alphagov/gds-api-adapters.git
I'll see if we can get a new version cut, and we can just use that.

https://github.com/alphagov/gds-api-adapters/pull/285/files


The BIDS connectivity project - finalization of BEPs

Title
The BIDS connectivity project - finalization of BEPs
Short description and the goals for the OHBM BrainHack
Besides BIDS' success, expansion, and description of multiple data modalities, gaps still exist in developing the standard to effectively support the process of scientific results reporting. Among others, this prominently refers to data obtained through and during connectivity analyses. This comprises brain parcellations, connectivity maps, structural and functional connections, major white matter tracts, diffusion signal models, white matter tractograms and tractometry, as well as networks based on dimensionality reduction. Sharing processed data and features in addition to raw and minimally processed data is critical to accelerating scientific discovery. This is because substantial effort, software, and hardware instrumentation, and know-how are required to bring raw data to a usable state. The aim of the present project is to extend the BIDS standard to encompass derivatives resulting from experiments related to macroscopic brain connectivity (U.S. National Institutes of Health NIMH R01-MH126699). During the Brainhack, we would like to

Finalize the existing BEPs (BEP17 - Relationship matrices, BEP38 - Atlases, BEP39 - Dimensionality reduction-based networks)
Gather feedback from experts, users, tool developers, ie everyone!
Discuss next steps, e.g. software integrations

Link to the Project
https://pestillilab.github.io/bids-connectivity/
Image/Logo for the OHBM brainhack website
https://pestillilab.github.io/bids-connectivity/img/logo.svg
Project lead
Peer Herholz, GitHub: peerherholz, discord: peerherholz
Franco Pestilli, GitHub: francopestilli, discord:
Ariel Rokem, GitHub: arokem, discord
Main Hub
Seoul
Link to the Project pitch
No response
Other hubs covered by the leaders

[X] Seoul
[ ] Hybrid (Asia / Pacific)
[ ] Hybrid (Europe / Middle East / Africa)
[ ] Hybrid (Americas)

Skills
Experience with one of our covered data modalities and respective analysis software packages would be helpful: s/fMRI, dMRI, PET, MEG, i/EEG. Additionally, knowledge of BIDS would come in handy.
However, these are not requirements: we're happy to welcome everyone interested.
Recommended tutorials for new contributors
No response
Good first issues
No response
Twitter summary
Interested in Brain connectivity and FAIR data? The BIDS connectivity project might be of interest to you! During the Brainhack we will discuss work on the different connectivity-related BIDS Extension Proposals (BEPs) and welcome support from all interested parties!
Short name for the Discord chat channel (~15 chars)
bids-connectivity
Please read and follow the OHBM Code of Conduct

[X] I agree to follow the OHBM Code of Conduct during the hackathon

@PeerHerholz Thanks for submitting this amazing project, the submission looks good to go and will soon be listed on our website.


Added Build a Quiz App with HTML, CSS, and JavaScript

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

https://github.com/EbookFoundation/free-programming-books/pull/7870/commits/ad16f1e9f8f7be0c64d4d19d2d32a3ed641d917b {solve}

https://github.com/EbookFoundation/free-programming-books/pull/7870/commits/ad16f1e9f8f7be0c64d4d19d2d32a3ed641d917b (deleted duplicate)


v1: Adapt to new composer spec

@Gundersanne do you have any idea what's happening to the Edge test? It's like it's trying to download the edge commit but it takes forever and the times out...

@Gundersanne do you have any idea what's happening to the Edge test? It's like it's trying to download the edge commit but it takes forever and the times out...

The edge test is extremely flaky and has multiple pain points. Need to get on fixing it or maybe just removing it at some point.


Typo in GamePhysicsSRS case study

In instances models -> IM1 -> Description:
is:
ai(t) is the i-th body’s acceleration at time t **(m)**.
should be:
ai(t) is the i-th body's acceleration at time t **(ms−2)**.
should the case study be updated?

fixed as of 577932a

Thank you for catching this type Henry.


Support for 3090

Thank you making this tool for the rest of us that are clueless. Would it be possible to make it work for nvidia.de, and if so, what about a 3090? Would like to be prepared to grab one on the 24th. Appreciate any help

Yeah, I think getting ready for locales is a good thing and something on the todo list (#25). I'm hoping I get more information about 3090 in the coming days so we can get prepped for that launch. You'll be able to see the announcements for anything like that here or Discord.

thanks, I was going to ask about that, Also you might to change the instructions on the run command to: "npm Start"
The former "npm Run start" command errors out on the latest Build.
Thank you.

Do we have an update on 3090 support? With the launch tomorrow I want to be ready!

3090 is the boss GPU. Waiting for that one as well. (Hopefully and Aorus Xtreme)

3090 is a work in progress. You can see the README for the ones we do have thus far.

https://github.com/jef/nvidia-snatcher/commit/676e793ef32a6010f23aabe395ec28c07eb42923
https://github.com/jef/nvidia-snatcher/commit/dd45dba82cb86f7e7664298dd202b93bbbd46d9f
https://github.com/jef/nvidia-snatcher/commit/482fb58cbfde6f95fb6f77de790d76e6aa2a5926
https://github.com/jef/nvidia-snatcher/commit/9f470f06e9e9fb605d340c0b0f9016d7288e8c0b

Going to close for now. Keep posted on README for the most accurate information.


Improve error/workflow for attempts to re-load the same pcap

If I've previously done a brimcap load of a pcap of a particular filename, and attempt it again, the error I see as a user:
$ brimcap load -s wrccdc -root ~/brimcap-root ~/wrccdc.pcap
error writing brimcap root: symlink /Users/phil/wrccdc.pcap /Users/phil/brimcap-root/wrccdc.pcap: file exists

The fact the Brimcap root consists of symbolic links is an implementation detail that the user probably shouldn't need to be aware of in order to understand what went wrong here. A few things come to mind:

The error message could be improved to something like "a capture file named wrccdc.pcap already exists in the brimcap root"
Perhaps we need a command (brimcap rm?) that unlinks files from within the Brimcap root
So the user can review what's in the root (e.g. to see if the conflicting wrccdc.pcap is the same one they're trying to load, or just to review what's in there before deleting stuff) perhaps they also need a way to list information about what's already in the root (brimcap ls?)
There's the potential for a user to load different files of the same name from different locations in the filesystem. @mattnibs and I talked about this offline and he acknowledged that at some point we could do something like have the contents of the Brimcap root be unique (e.g. filenames based on hashes) with metadata that points to filesystem locations. That said, at the moment I do find it mildly convenient to be able to ls -l the contents of the Brimcap root and see what's in there, so this would probably further make the case for something like the brimcap ls proposed above so the user can see a processed summary of what's in the root.

Thanks to the changes in #37, the error shown in this issue no longer happens. Instead a re-load of the same pcap completes successfully, generating duplicate records in the destination Space. It would likely be a mistake if a user were to do this, so #45 has now been opened to consider if we should warn/prevent this somehow. Also, the ability to maintain the Brimcap root through commands like brimcap ls and brimcap rm still seems like it would be handy, so #46 has been opened to track that.


CASMTRIAGE-4302 add troubleshooting info for csm_rbd_tool.py

Description
Add troubleshooting info for csm_rbd_tool.py.
Checklist Before Merging

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.3


⚠ BeyondHD has degraded performance

In 98e7526, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 2294 ms

Resolved: BeyondHD performance has improved in 05e4218.


Chrome 54+ and Opera 41+ support BroadcastChannel

Sources:
https://developers.google.com/web/updates/2016/09/broadcastchannel
https://www.chromestatus.com/features/4585496197988352

#2787 already covers this.

Yup, already covered.


[BUG] yurtadm join fails with k8s version 1.19.4

What happened:

When we use k8s version v1.19.4, yurtadm join will fail
What you expected to happen:
yurtadm join has no exceptions and can join nodes smoothly
How to reproduce it (as minimally and precisely as possible):
When refactoring the yurtadm join, we constructed the JoinConfiguration file as the configuration file for calling kubeadm, which apiVersion is kubeadm.k8s.io/v1beta3. According to https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/, v1beta3 is only supported for v1.22.x and above.
Anything else we need to know?:
Environment:

OpenYurt version:
Kubernetes version (use kubectl version):v1.19.4
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

others
/kind bug

@rambohe-ch I think we need to switch the apiVersion of the JoinConfiguration file to v1beta2 so that it supports v1.15.x and above, WDYT?
Another question is whether we still need to be compatible with k8s below v1.15.x. If so, perhaps we should dynamically switch the apiVersion used depending on the k8s version of the cluster.

@rambohe-ch I think we need to switch the apiVersion of the JoinConfiguration file to v1beta2 so that it supports v1.15.x and above, WDYT? Another question is whether we still need to be compatible with k8s below v1.15.x. If so, perhaps we should dynamically switch the apiVersion used depending on the k8s version of the cluster.

@YTGhost I think we only need to support K8s with versions larger than v1.18, and don't need to consider any smaller version.
maybe it's a good idea to switch the apiVersion of JoinConfiguration according to K8s version.

/assign


Week3 commentart overhaul

A significant portion of the changes are due to the .html and .css. In addition, the functions in .js are largely copied and pasted from the previous PR. With that said, I am terribly sorry about this huge PR. I hope that the comments help though. (:


[needs verification] validate the contents of a repo before using it as an organization-level Dangerfile

Scenario: I am a user of Danger and have a Dangerfile in my repo samdmarshall/pyconfig. I want to contribute a change back to Danger so I fork the danger/danger repo to samdmarshall/danger. There should be some verification that this new repo samdmarshall/danger doesn't get consumed by Danger under the assumption that it is a repo I created to house an organization-level Dangerfile that should be run.
Note: I wasn't able to create a repro case for this because I already have an organization-level Dangerfile repo created. Since I only have the one org (myself) there should be some testing done on this behavior to ensure it works correctly.

One way to check, would be for us to do a check to se if danger.gemspec exists in that repo first, otherwise you're going to run our Dangerfile

Also the case of what happens if you have multiple repos that match the name pattern of an org-level Dangerfile repo.

You can only have one repo called Danger to my knowledge, I think we only specifically work with that one

ah, you are right, for some reason i remember the guide saying that you could name the repo danger/Danger/dangerfile/Dangerfile but that isn't the case.

I had this issue as well, where my fork of danger/danger to ashfurrow/danger was being interpreted on a personal repo to be an org-wide Dangerfile repo. Deleting my fork fixed things.


Amatrix

amatrix which is currently noted under Math is not a mathematical matrix library but a prototypical implementation of the Matrix protocol.
So instead of Math it should be under Algorithms, containers and protocols although I'd suggest to remove it completely from this list since it is far away from being usable for any serious project.

thx for letting me know. I just removed it.


BUG - Click on link instructions is not clickable

Related Feature
Feature request: issue number
Description
The guided answers shared instructions  provides instructions to click on the link for VSCode users however the link is not clickable as it is wrapped in quotations.
Steps to Reproduce
Steps to reproduce the behavior:

Go to GA content
Click on copy link with instructions icon
Paste instructions
See error

Expected results
Click on link for VSCode link
Actual results
VSCode link is not clickable as per instructions.
To resolve your reported issue, open Guided Answers extension by SAP, and follow the steps mentioned in the guide.
->If your IDE is VSCode, please click on the following link: "vscode://saposs.sap-guided-answers-extension#/tree/3046/actions/45995:45996"
->If your IDE is SAP Business Application Studio, then:
a. Launch Guided Answers via the command "SAP: Open Guided Answers"
b. Paste the following guide shortlink into the search input field: "vscode://saposs.sap-guided-answers-extension#/tree/3046/actions/45995:45996"
Screenshots
Version/Components/Environment
Add any other context about the problem here
OS:

[ ] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

@ritarora this seems to be fixed already


CU-86bwj1mfw-in-markdown_to_anki-if-no-notes-are-found-do-not-create-deck

added conditional return if no codeblocks or callouts have been found

Task linked: CU-86bwj1mfw in markdown_to_anki if no notes are found do not create deck


Warning Log Generated in wso2carbon.log When User Attempts Login to Application with "Enable Authorization" Enabled

Describe the issue:
When a user tries to log in to an application where "Enable Authorization" is enabled under the Application Advanced Tab, a warning log is generated in the wso2carbon.log file.
[2023-11-08 08:53:51,195] [fe971235-5390-4685-a81d-cdfba6d7e4ef]  WARN {org.wso2.carbon.identity.application.authz.xacml.handler.impl.XACMLBasedAuthorizationHandler} - No applicable rule for service provider<EMAIL_ADDRESS>Hence authorizing the user by default. Add an authorization policy (or unset authorization) to fix this warning.

How to reproduce:

Enable "Enable Authorization" under the Application Advanced Tab
Attempt to log in to the application using valid credentials.
Observe the wso2carbon.log file for warning logs generated during the login attempt.

Expected behavior:
Logging in to the application with "Enable Authorization" enabled triggers a warning log entry in the wso2carbon.log file.
Remove "Enable Authorization" button/ option from console
Environment information

Product Version: Alpha2 7.0
OS: Mac
Database: Mysql
Userstore: JDBC

This is not reproducible in the latest console version

Closing the issue as this is not reproducible.


Integrate hspec

@markandrus Hi. I wanted to start a PoC of unit testing the suite to give us an opportunity to discuss what we do going forward.
Testing the resources (Account, Message, Call) would be most important, but given that this is my first foray into real Haskell code, I wanted to make sure this was what you had in mind.
(P.S., you can run the stack runhaskell test/unit/Twilio.Types.PriceUnitSpec to avoid running the entire test suite).

I also added QuickCheck. This is likely overkill for PriceUnit, but again, just trying to layout precedent for the rest of the suite, making sure it is all wired up correctly on a small example.
BTW, nice to be working with other UChicagoan. (Do we ever call ourselves Maroons?)

Cool! I haven't used HSpec. Does the directory structure pattern match what you see in other projects? E.g., mirroring the src dir, but under a test/unit dir?

(P.S., you can run the stack runhaskell test/unit/Twilio.Types.PriceUnitSpec to avoid running the entire test suite).

Nice 👍

BTW, nice to be working with other UChicagoan. (Do we ever call ourselves Maroons?)

Oh, cool :-) UChicago is where I learned Haskell. I've never called myself a Maroon :-p
I had a few comments on the PR, but otherwise it seems like a reasonable pattern. Maybe we should grow the tests a bit—e.g., add a slightly more or similarly complicated test—to further confirm the pattern will work for us (and answer the Arbitrary Text instance question) before merging?

@markandrus In terms of hspec, the only requirement (and this is because we are using the automatic spec discovery feature) is that the specs have to be placed in the same directory as the Spec.hs file.
The short answer is yes, we should have our test directory mirror or src directory, but since we have api specs, but I nested them inside an extra directory test/unit to separate the tests that actually reach out and make api calls.

@StevenXL thanks for the info on the automatic spec discovery feature. Based on that, I think the folder structure here is good. 👍
Regarding the Arbitrary Text instance, instead of adding a test/support module (which may make sense for future code we end up adding) could we add a dependency on quickcheck-instances to our test suite? It seems to be recommended here.

@StevenXL I spotted a few things in the Travis CI logs:
/home/travis/build/markandrus/twilio-haskell/test/unit/Twilio/Types/PriceUnitSpec.hs:9:1: warning: [-Wunused-imports]
 The import of ‘pack’ from module ‘Data.Text’ is redundant
/home/travis/build/markandrus/twilio-haskell/test/unit/Twilio/Types/PriceUnitSpec.hs:10:1: warning: [-Wunused-imports]
 The import of ‘Test.QuickCheck.Instances’ is redundant
 except perhaps to import instances from ‘Test.QuickCheck.Instances’
 To import instances alone, use: import Test.QuickCheck.Instances()

These should be easy to fix; however, there are also some dependency issues that I'm not yet sure how to fix. For example, on the Stack builds:
Error: While constructing the build plan, the following exceptions were encountered:
In the dependencies for twilio-<IP_ADDRESS>:
 QuickCheck-2.8.2 must match >=2.9 (latest applicable is 2.10.1)
 hspec-2.2.4 must match >=2.4 (latest applicable is 2.4.4)
needed since twilio-<IP_ADDRESS> is a build target.

And on the Cabal builds:
Warning: solver failed to find a solution:
Could not resolve dependencies:
rejecting: twilio-<IP_ADDRESS>:!test (constraint from config file, command line
flag, or user target requires opposite flag selection)
trying: twilio-<IP_ADDRESS>:*test
unknown package: quickcheck-instances (dependency of twilio-<IP_ADDRESS>:*test)
Dependency tree exhaustively searched.
Trying configure anyway.
Configuring twilio-<IP_ADDRESS>...
cabal: Encountered missing dependencies:
QuickCheck >=2.9, hspec >=2.4, quickcheck-instances -any

@markandrus Hey - Build is still not passing. I'm going to look into it whenever I get a chance, but happy to hear your thoughts on it.
Quick question. How could we have gotten the two redundant imports on local, so that we could fix them before we push? I tried adding the same ghc-options that the library target has to the test targets but that didn't do anything. (Whatever option has the redundant imports, I imagine it is turned on by the -Wall, so I thought that would work).

@markandrus any further changes required to this PR?

Hey @StevenXL,
I wanted to add some more tests just to prove out directory structure/how we scale to testing more modules, but I think the path is clear and we don't need to block this PR on that.

How could we have gotten the two redundant imports on local, so that we could fix them before we push? I tried adding the same ghc-options that the library target has to the test targets but that didn't do anything. (Whatever option has the redundant imports, I imagine it is turned on by the -Wall, so I thought that would work).

Not sure :-\ I'd have to play around with ghc-options next time I build. I expect it is these, though. One thing I remember: we should not set -Wall in the .cabal file, since then Hackage complains when we upload.
Anyway, nice work on this PR! 👍


how to get IP of the client?

I need to get the IP of the client who requests the route. In iron router I did it like this:
Router.map ->
  @route 'importXML',
    where: 'server'
    path: '/importXML'
    action: ->
      clientIP = @request.connection.remoteAddress
      if clientIP is '<IP_ADDRESS>'
        @response.end 'executed from local host'
        Meteor.call('importAllXMLs')
      else
        @response.end 'error: access denied'

Wished result - only server can make http request to itself to execute some code.
Can this be achieved with picker?

Of course yes. In picker response object is the standard NodeJS response object. You can do it.

oh, thank you :)


[Hello] Add continuous trajectory tracking & teleop

Description
Changes:

Within remote interfaces (remote_hello_robot and remote_hello_robot_ros):

Expose direct velocity control: set_velocity
Create continuous goto controllers: set_relative_goal, set_relative_position_goal (remote_hello_robot_ros only)

Add continuous teleop script keyboard_teleop.py

Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[x] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Please describe the tests that you ran to verify your changes and how we can reproduce.
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

Codecov Report

Merging #1371 (750d8ee) into main (3308290) will increase coverage by 18.96%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1371       +/-   ##
===========================================
+ Coverage   15.44%   34.41%   +18.96%
===========================================
  Files         349      357        +8
  Lines       34777    35196      +419
===========================================
+ Hits         5372    12111     +6739
+ Misses      29405    23085     -6320

Impacted Files
Coverage Δ

test_utils.py
21.87% <0.00%> (ø)

tools/hitl/utils/tests/hitl_logging_test.py
98.07% <0.00%> (ø)

tools/hitl/utils/hitl_logging.py
100.00% <0.00%> (ø)

tests/test_base_utils.py
98.55% <0.00%> (ø)

tools/hitl/utils/hitl_utils.py
21.21% <0.00%> (ø)

...itl/dashboard_app/backend/dashboard_model_utils.py
44.44% <0.00%> (ø)

...ard_app/backend/tests/dashboard_aws_helper_test.py
98.00% <0.00%> (ø)

...hitl/dashboard_app/backend/dashboard_aws_helper.py
57.57% <0.00%> (ø)

dialog/post_process_logical_form.py
29.23% <0.00%> (+1.53%)
:arrow_up:

memory/filters_conversions.py
62.19% <0.00%> (+5.20%)
:arrow_up:

... and 126 more

@theophilee Can you take a look at this PR as well?


Default behavior for sharing doesn't adhere to PSR-11 recommendations

In PSR-11 I read this:

Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned.

So while it gives the room to implementors to do things differently, it still recommends that two consecutive get calls to a container, should return the same value. (And in my interpretation, the same value, also means the same instance when it concerns service objects).
Too bad this library doesn't adhere to this behavior in its defaults, because as far as I know, containers are there mostly to share services, which you normally only need to instantiate once.
Some places at which I think defaults should better be differently:

the add method should be better of being shared by default.
the ReflectionContainer should return the same instance every time something is called.
(maybe there are more that it didn't discover yet?)

This is of course breaking compatibility, so just missed the boat for 3.0. Although I do think that making or providing a SharingReflectionContainer and/or being able to configure your container to share everything by default, should be possible with this library and maybe even recommended in the docs.
I'd like to know what you think of this, because being able to configure container in such a way that it shared everything by default, might already have save our team some nasty bugs...

Quick reply on the SharinReflectionContainer: A sharingreflectioncontainer
could be built very easily by wrapping a reflection container and caching
results returned by the reflection container. If you make it implement the
right interfaces you can pass it on to the main container using
$container->delegete($sharingReflectionContainer);.
On Sun, Aug 12, 2018, 11:03 Stijn Vannieuwenhuyse<EMAIL_ADDRESS>wrote:

In PSR-11 I read this:
Two successive calls to get with the same identifier SHOULD return the
same value. However, depending on the implementor design and/or user
configuration, different values might be returned.
So while it gives the room to implementors to do things differently, it
still recommends that two consecutive get calls to a container, should
return the same value. (And in my interpretation, the same value,
also means the same instance when it concerns service objects).
Too bad this library doesn't adhere to this behavior in its defaults,
because as far as I know, containers are there mostly to share
services, which you normally only need to instantiate once.
Some places at which I think defaults should better be differently:

the add method should be better of being shared by default.
the ReflectionContainer should return the same instance every time
something is called.
(maybe there are more that it didn't discover yet?)

This is of course breaking compatibility, so just missed the boat for 3.0.
Although I do think that making or providing a SharingReflectionContainer
and/or being able to configure your container to share everything by
default, should be possible with this library and maybe even recommended in
the docs.
I'd like to know what you think of this, because being able to configure
container in such a way that it shared everything by default, might
already have save our team some nasty bugs...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thephpleague/container/issues/148, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWFNubi6RjfJ-h3vEyu69HS-21H_aS5ks5uP-9GgaJpZM4V5dxb
.

Just to save any unnecessary work, sharing won’t ever be default behaviour for add, however, it was brought to my attention yesterday that I mistakenly removed the share method (basically a proxy to add that always marks the definition as shared) in 3.0.0 so that’ll will be reintroduced in the next couple of days.
I would be open to an extension of the reflection container or an option on it to cache results. Feel free to create a PR. If not then I’ll look at it when I get chance.
Sent from my iPhone

On 12 Aug 2018, at 10:23, Stijn Vannieuwenhuyse<EMAIL_ADDRESS>wrote:
@hannesvdvreken
I know that I could fix that locally, I just doesn't make sense that I have to do that.
In most (?) systems, you only need one FooRepository or BarTransformer or ... no?
I'm currently looking for more container implementations in- and outside of php to see how other approach this. First observation: symfony has a share everything default, laravel has more or less the same principles as container, so there is indeed no common understanding.
Will follow up :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@stivni https://github.com/thephpleague/container/releases/tag/3.1.0 this should cover what you want, it's not by default though

I do agree with @stivni that when I read:

Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned.

I would expect share to be the default behaviour unless you specify otherwise. Isn't PHP-DI also shared by default?

I don’t disagree with the interpretation, but SHOULD is not MUST and for my purposes I’ve always preferred not shared by default, I think the recent release and your PR is a good enough compromise.
Sent from my iPhone

On 13 Aug 2018, at 09:04, Jens Segers<EMAIL_ADDRESS>wrote:
I do agree with @stivni that when I read:
Two successive calls to get with the same identifier SHOULD return the same value. However, depending on the implementor design and/or user configuration, different values might be returned.
I would expect share to be the default behaviour unless you specify otherwise. Isn't PHP-DI also shared by default?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.