Still cannot get Job ID to Display

After making modifications described in Issue #83 I am still not seeing Job ID displayed.
I created the new build by following the instructions provided here:
https://github.com/bullhorn/career-portal/blob/master/README.md#building
Here are the steps I followed:

Install Git & node.js (Git Bash installed on Windows 10 desktop)
In the Git Bash Console I issued the following sequence of commands:
a.  git clone https://github.com/bullhorn/career-portal.git
b.  cd career-portal
c.  npm install -g bower
d.  npm install -g gulp
e.  npm install
f.  bower install
Edit the src/app/list/list.html and add the following line to :
{{::job.id}}
Edit the src/app/detail/detail.html and add the following line to :
{{::detail.job.id}}
Final command:
a.    gulp --corpToken='[our corp token]' --sl='[our swimlane]' --companyName='[our company name]'
Upload the dist directory to the root directory on the host (GoDaddy) and rename directory to careerportal.

FINAL RESULT:
The job listing displays fine, but still does not show the job ID.
Here is what I added to list.html in the section span class="card-title-category":
    {{::job.id}}

Here is what I added to detail.html in the section span class="card-title-category":
    {{::detail.job.id}}

Here is the full listing of updated each file:
list.docx
detail.docx
After making these two simple changes, the job listing displays fine but I still do not see the job id.

Hey, @rmglass —
I went through the exact same steps that you've listed above (I even copied and pasted your code), but mine worked, which tells me that this is probably like when you hear a rattle in your car but once you take it to the mechanic the rattling stops, haha. I've uploaded that version to my own site here for you to see working (a little ugly, but working).
I've also forked this repo onto my private account and uploaded the code changes I've used here. Could you try cloning that version locally, installing all the dependencies (step 2's b-f), then building and deploying that? Once you've done that, if you have a link to your build send it over and I can take a further look if it isn't working.
Thanks!

Hey Kameron,
Thanks for your quick response. I downloaded your version. It looks like everything is working fine now. I need to do a small tweak to the details page, but other than that I am in business:
http://wimmersolutions.com/careers/
Thanks again, for your help.


Chris judge pfp change

Appears to be more change than just pfp in this PR. There is also category fixes here.

📝 Changed routes:

…n/base-consumer-crypto
/hackathon/readyplayer3

(view full size)
(view full size)

Commit 50702535d92f7322d41eb89a61db3361a6010a36 (https://thirdweb-grkeyerdu.thirdweb-preview.com).


Replicat the summarization approach in AWS

Replicate the following code: https://github.com/rodralez/JurisGPT/blob/main/code/python/scripts/jurisgpt_court_ruling_summary.py
in AWS

I did not use the same approach. Instead I asked the LLM to summarize each of the sections and the for all the section I ask the LLM a final summary.


[RootView] Fix positioning of the root view content (frame -> bounds)

The root view's content was being rendered at the wrong offset when it was not positioned at (0, 0) exactly, because the shadow view's frame was set to the root view's frame when it should have been set to the root view's bounds instead.
Test Plan: Render a root view positioned at (0, 100) and see that its content is positioned where the root view is, not at (0, 200).

Oops, thanks!


Philadelphia numbers seem unlikely

An average person in Santa Clara, CA gets assigned a baseline risk level of 300μC. Santa Clara has about 20-100 cases daily.
An average person in Philadelphia, PA gets assigned a baseline risk level of 1μC. Philadelphia has about 20-100 cases daily.
(The populations are in the same order of magnitude.)

Yeah our system is showing 0 cases this week and last week in Philadelphia. We'll look into it. Thanks.

Looks like it's been resolved. Not sure what the cause was. But feel free to re-open if it pops up again.


Cannot read properties of null (reading 'useRef')

What happens?

What did you expect to happen?
run success
How can we reproduce the issue?
// src/App.jsx
import { ApiReferenceReact } from '@scalar/api-reference-react'
import<EMAIL_ADDRESS>import React, { useState } from 'react';
function App() {
return (
<ApiReferenceReact
configuration={{
spec: {
url<EMAIL_ADDRESS>},
}}
/>
)
}
export default App

I just use demo code to run , but throw error;
"dependencies": {
"@ant-design/icons": "^5.3.6",
"@docusaurus/core": "^3.1.1",
"@docusaurus/preset-classic": "^3.1.1",
"@mdx-js/react": "^3.0.0",
"@scalar/docusaurus": "0.4.44",
"antd": "^5.16.1",
"clsx": "^2.0.0",
"fs-extra": "^11.2.0",
"prism-react-renderer": "^2.3.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
OpenAPI Document
No response

There is no problem running the demo alone, but if it is used together with docusaurus, this error will be reported

@lys623 would you be able to share a minimal reproducible repository so we can help debug ✨ :)

For what its worth I think I've seen this error (or something similar) when I've ended up with multiple versions of react in a project's lockfile, with the solution being de-duplicating the dependency to ensure there is only one version.

For what its worth I think I've seen this error (or something similar) when I've ended up with multiple versions of react in a project's lockfile, with the solution being de-duplicating the dependency to ensure there is only one version.

So how do you do that? Writing a dead react version in package.json won't fix it @mp

scalar/api-reference-react

https://github.com/lys623/scalar-api-reference-react-demo   a minimal reproducible repository , pls help to check @marclave

For what its worth I think I've seen this error (or something similar) when I've ended up with multiple versions of react in a project's lockfile, with the solution being de-duplicating the dependency to ensure there is only one version.

So how do you do that? Writing a dead react version in package.json won't fix it @mpminardi

Changing the react dependency in package.json to 18.3.1 (or ^18.3.1) to match what @scalar/api-reference-react currently has in its package.json and doing a yarn install solves this for me locally and gets rid of the duplicate version in yarn.lock.

my 2-cents are that react should be a peerDependency instead of dependency, and the versions should be as loose as possible ^18.0.0 instead of ^18.3.1 (unless there is a reason why 18.1 or 18.2 doesn't work?)
I can't imagine a scenario where an app that installs @scalar/api-reference-react do not already have react as a dependency.

I'm still facing this issue, I have:
"react": "18.3.1",
"@scalar/api-reference-react": "0.3.47",
``

but when I downgrade to "@scalar/api-reference-react": "0.3.44" I don't have it anymore.

With both 0.3.44, and 0.3.47 I do have two versions of react in my pnpm lockfile:

<EMAIL_ADDRESS>dependencies:
loose-envify: 1.4.0
object-assign: 4.1.1
prop-types: 15.8.1
<EMAIL_ADDRESS>dependencies:
loose-envify: 1.4.0

but the react 16.14.0 comes from `"@playwright/test": "1.45.2",` (also in my package.json) and i do need that package.

What can I do to fix this?

i upgraded and faced this same issue on 0.3.47
took a look at the difference between 0.3.47 and 0.3.44
https://yarnpkg.com/package?q=%40scalar%2Fapi&name=%40scalar%2Fapi-reference-react&file=%2Fdist%2Findex.js&version=0.3.47
https://yarnpkg.com/package?q=%40scalar%2Fapi&name=%40scalar%2Fapi-reference-react&file=%2Fdist%2Findex.js&version=0.3.44
.44 only has react-jsx-runtime.production.min.js and react-jsx-runtime.development.js
seems like in .47, react.production.min.js and react.development.min.js is also bundled into the dist/index.js
i don't think any of these react code should be part of the final dist files.


[bug]: Error GPU Mac M1 when training Stable Diffusion using Textual Inversion

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
mps
VRAM
16
What happened?
I have a problem when I re-implement it. I run it on Mac pro M1, and I have error:
"RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (CPU) "
when I training with command:
python main.py --base ./configs/stable-diffusion/v1-finetune.yaml
-t
--actual_resume ./models/ldm/stable-diffusion-v1/model.ckpt
-n my_key
--gpus 0,
--data_root ./training_data/key/
So, Can you help me fix this error, please? Thank you very much!
My laptop is Macbook Pro 14" M1pro
Screenshots

Additional context
No response
Contact Details
<EMAIL_ADDRESS>

fix for this: https://github.com/Birch-san/stable-diffusion/commit/46f793b5ecd5bdd70ee8c9da9c6f379aa566afc5
also, if you are using a nightly build of pytorch, you might face some bugs

fix for this: Birch-san/stable-diffusion@46f793b also, if you are using a nightly build of pytorch, you might face some bugs

Thank you very much! I'll try this

Thanks @remixer-dec  for pointing to the solution. I’ll apply it to InvokeAI.

Im still getting the same error, any idea what I should be doing differently?

@pangshengwei Try this command:
python main.py --base ./configs/stable-diffusion/v1-finetune.yaml
-t
--actual_resume ./models/ldm/stable-diffusion-v1/model.ckpt
-n my_key
--accelarator "cpu"
--data_root ./training_data/key/

@FreeBlues for M1 chips there is a config called v1-m1-finetune.yaml

@remixer-dec Thank you, I will have a try.

I was getting this error on an M1 mac while attempting textual inversion...
MisconfigurationException: MPSAccelerator can not run on your system since the accelerator is not available. The following accelerator(s) is available and can be passed into  accelerator argument of Trainer: ['cpu'].
I went down a rabbithole of attempting various version changes, nightlies, updates, etc - nothing worked.
I finally realized that despite actually being on an M1, and having built python and conda and so on with the arm64 appropriate invocations ... there is some code that determines while running, what platform it's running on.
When I would run things like uname and uname -m and arch and so on, I was getting answers in the x86_64 and i386 and such. I eventually realized that because I was running a zsh which was installed through intel homebrew (probably from migrating previous laptop onto this newer M1 device), that was cascading down.
I was able to install both the M1-specific version of homebrew, and then separately reinstall zsh with that homebrew ... and now I get arm64 from arch command and arm64 from uname -m as well.
...I'm not sure if this is the end of my issues or not, but it at least got me past the error I was seeing and the inversion script is running now. Hope this helps someone else!

I was getting this error on an M1 mac while attempting textual inversion...

MisconfigurationException: MPSAccelerator can not run on your system since the accelerator is not available. The following accelerator(s) is available and can be passed into  accelerator argument of Trainer: ['cpu'].

I went down a rabbithole of attempting various version changes, nightlies, updates, etc - nothing worked.
I finally realized that despite actually being on an M1, and having built python and conda and so on with the arm64 appropriate invocations ... there is some code that determines while running, what platform it's running on.
When I would run things like uname and uname -m and arch and so on, I was getting answers in the x86_64 and i386 and such. I eventually realized that because I was running a zsh which was installed through intel homebrew (probably from migrating previous laptop onto this newer M1 device), that was cascading down.
I was able to install both the M1-specific version of homebrew, and then separately reinstall zsh with that homebrew ... and now I get arm64 from arch command and arm64 from uname -m as well.
...I'm not sure if this is the end of my issues or not, but it at least got me past the error I was seeing and the inversion script is running now. Hope this helps someone else!

@mjankowski Do you have a link to installing the M1-specific version of homebrew?
Trying to train Textual Inversion on my M1 Mac and getting no where.

You just reinstall it and it will install the M1 version when it pulls down from the repo. This blog post was useful - https://earthly.dev/blog/homebrew-on-m1/ as were random notes in the homebrew repo.
 during the install so that it selects properly, if its attempting to reinstall the intel versions.
Notably - homebrew switched to keeping things in /opt/homebrew for the m1 version ... so unrelated to anything to do with GPUs or inversion, you'll have to manage that.


Cloud UI: retain dashboard while reconciling

TODO:

[ ] Dashboard is shown during reconcile, but queries hang halfway through the reconcile

Problem
While a project is reconciling, the dashboard is initially interactive. However, about halfway through the reconcile, queries hang, and a request fails with a 400 error "table does not exist".
In this case, the full reconcile takes ~30 seconds, and the queries hang for about half that time.

Here, a toplist request failed with a 400. Other times, a timeseries request fails with a 400.

Note: I'm testing by running rill project reconcile --refresh and interacting with the dashboard.

This should now be unblocked by https://github.com/rilldata/rill/pull/2747
Lets test it and see if we hit any new blockers here.

@ericpgreen2 : This should now be unblocked by #2747 Lets test it and see if we hit any new blockers here.

@nishantmonu51, @begelundmuller, I tried this branch again. I've updated the PR description with a new problem I'm observing.

@ericpgreen2 I tested the PR and had these findings:

The queries did not hang for me, but did take longer to resolve during source refresh. I think this is connected to the 2 slot default on cloud, which translates to two concurrent DuckDB connections, of which background source ingestion grabs one. So all other queries become serialized and one slow query can cause everything to hang. Could this explain what you saw? I think this is acceptable, and should be less of an issue for deployments with more than 2 slots.

I was able to reproduce the 400 error in one out of three source refreshes where I was constantly clicking filters. I think it depends on hitting the exact moment we drop the old table and rename the temporary table. I'm exploring options to do that transactionally on the backend, but it would also help if the cloud UI could show individual dashboard request errors inline (like it does on local) instead of blocking the entire page. Would that be hard to do?

I also found that the UI is not rendering the list of dashboards when a refresh is running:

UPDATE: This PR should fix the 400 error: https://github.com/rilldata/rill/pull/2897

@begelundmuller, on your points:

Yeah, that sounds like a good explanation.
Adding error boundaries to dashboard components is definitely something we need to do. Though thanks to your PR, it doesn't sound like an error boundary is necessary for this PR anymore.
Just fixed.

Given all this, I'll mark this PR as ready.


User images all look the same

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed: https://github.com/GetStream/Winds/issues

Description
Almost everyone has the Gravatar G image. It's nicer to use an identicon, so even if no image is known by gravatar at least everyone has something different. https://en.gravatar.com/site/implement/images/#default-image (you can do that by doing the same request with default=identicon as a GET parameter)

Fixed in https://github.com/GetStream/Winds/blob/master/app/src/components/Avatar/index.js


[Tasks] Should be able to limit the number of attempts of a survey

Admins should be able to limit the number of times a user takes a survey.

Addressed by #66


Query with order_by from browser error: "expecting an object"

What version of Super Graph are you using?
v0.14.35
Steps to reproduce the issue (config used to run Super Graph).
I'm trying to query with this payload (from browser):
{
  "query": "query players($order_by: playerOrderBy!) {
    players(order_by: $order_by) {
      id
      created_at
    }
  }",
  "operationName": "players",
  "variables": {
    "order_by": {
      "id": "desc"
    }
  }
}

Expected behaviour and actual result.
It gives me error:
ERR  error="expecting an object"

Why?

Order By requires you to set specific indexes on the database so the order has to be deliberate. Also changing the order invalidates the pagination cursor. In short since we generate a SQL query and re-use it in production and since ORDER BY cannot be a parameter in SQL this can't be done easily or without hurting performance. I'll think over this some more but closing for now.

Order By requires you to set specific indexes on the database so the order has to be deliberate.

Sorry for my ignorance in databases.
I have already set the indexes on the DB for the columns on which I want to leave the user free to order.

Also changing the order invalidates the pagination cursor.

It doesn't matter to me because when the user changes the order he knows that the cursor is invalidated and "starts over".

I think this is another good case for a "special function" "without pre-compiled scheme" that allows this kind of user queries comfortable but (perhaps) slower.
Like in #115.

Below is how I do similar things in my apps. I'm still thinking on how to make variables work with order_by and limit not against implementing it just need to figure out a good solution.
fragment Player on players {
  id
  created_at
}

query getPlayersDesc {
  players(order_by: { id: desc }) {
    ...Player
  }
}

query getPlayersAsc {
  players(order_by: { id: asc }) {
    ...Player
  }
}

The problem I have is to ORDER BY and filter with WHERE in a completely dynamic way.
Example
Take Github's issues page > Sort menu, what I need is very similar:

I can sort results by many columns (even by reactions!).
Another example
In this tutorial here: https://www.howtographql.com/react-urql/7-pagination-and-cache-updates/ they use this query:
export const FEED_QUERY = gql`
  query FeedQuery($first: Int, $skip: Int, $orderBy: LinkOrderByInput) {
    feed(first: $first, skip: $skip, orderBy: $orderBy) {
      count
      ...
    }
  }
`

And they use variables object:
const variables = React.useMemo(() => ({
  skip: isNewPage ? (page - 1) * 10 : 0,
  first: isNewPage ? 10 : 100,
  orderBy: isNewPage ? 'createdAt_DESC' : null
}), [isNewPage, page])

Here the code
Another example
Here a user is trying to solve the same problem using sqlc:
https://github.com/kyleconroy/sqlc/issues/364#issuecomment-593100103

I need to select on t1, which the filters are determined from UI, so I need any combination of filters, it means I should support following 9 queries on my back-end.
Users can also sort on any column they wish (ASC/DESC).
Which is 9*4 = 36 different possible queries for a table with 2 fields.

As you can see I need to sort the results not only by one column but many.
And creating so many javascript queries is wasteful and counterproductive. Which is the opposite of what SuperGraph would like to achieve: 100% productivity. :smile:

I think we can close this in favor of #120.


Fix for GIF viz so that pocket is coloured correctly

Fixes #393
Adds in keepIds=True so the right residue numbers are written to PDB files.

@JenkeScheen this should be a quick review.

Codecov Report

Merging #422 (c905e90) into main (8fbbe8e) will increase coverage by 3.69%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.


Black Screen

Hi
I have a two sets of flows in main story board. One which uses slide menu & other doesnt. Both flows have a button to switch from one flow to another. When I switch for the first time, I can see the menu. But when when I go to second flow & then back to first flow I cant see the menu only black screen.  Also when i checked SlideNavigationControllerDidOpen is getting called but the menu is black.
Nikhil

I have exactly the same problem

My problem was that I was reinstantiating the rootview controller of the slide menu programatically. Just saying: [[SlideNavigationController sharedInstance] popToRootViewControllerAnimated:NO]; worked for me

There is also popAllAndSwitchToViewController if you want to replace the entire stack with a new one

I had the problem when I used popAllAndSwitchToViewController only in the case of going to the rootViewConroller of the slider.

I used the popAll... and it works better for me because using the popToRoot leaves the chevron in the newly presented view.

HI,
I am using two different storyboards first time app login   showing one storyboard and remaning times showing another storyboard..
when i run app first time menu getting black screen after relaunch app it getting data..
Can you please slove my issuse..
Thanks in advance.


Freeze conv layers for faster training

In inception_v2's config file, how do I change the configurations so as to freeze all the layers except the last layer to train faster - as we do in transfer learning?

I got same problem with you and stuck because of tensorflow. If using Keras, it would be much easier...

I also got the same problem... Do you have a solution right now ?

To my understanding this is not Transfer Learning right? It seems like we are reusing the entire faster_rcnn_inception_v2 CNN model and training it to only recognize our N number of custom objects.
How do we keep the categories that the faster_rcnn_inception_v2_ has already been trained on and just add the playing card categories or our custom objects?
Secondly, how do we really modify this example to perform transfer learning by only modifying the last layer?


alignStepBoundaries edge cases

This method is not very large, but does a few things which IMO are questionable.

reversing start/end
if the user flipped start/end, it is not the responsibility of trickster to flip it. This is additionally confusing as things will work, but if trickster is removed from the call path all queries this fixes will break. IMO it is not the place of the cache to "correct" user queries.

time.Now() checks
I think its fine to cut off queries from going into the future, but this doesn't handle the case where both start/end are in the future. IMO in that case this should return an error. In the remaining cases I think its fine to leave it truncating end as the query results will remain unaffected, although I'd rather it didn't (the time.Now() constraint is a cache issue, not a query issue).

default step param
If the user didn't define one, this is not the place of a caching proxy to correct it. Here we should just return an error and make the user correct their query.

Thomas, totally agree on these things. Thanks for the feedback! Were you hoping to contribute these things? My plan is to use much of the upcoming holiday to work through Trickster issues, so if you are unable, we should be able to get them ripped out soon in any event.

I can definitely submit a PR for these. If you are okay with all 3 changes I'll get a PR going with those changes.

Absolutely. thank you!

Hi Thomas, looks like this change has created a defect wherein the initial request for data (e.g., a trickster cache miss) results in a 404 to the user, while subsequent (cache hits) are successful. Are you able to take a look and identify what went wrong?  I will keep digging to see if it's something I did wrong in my tests.

So you are saying that you get different results for cache miss vs cache hit? I definitely didn't see that before, so that is interesting. Do you have a repro case?

@jranson I did some quick local testing and can't reproduce the error (I can send a query and I get the same result when its a hit or a miss). If you have a repro case (or test case) I can definitely take a look into it.

Definitely seeing an issue, might be related to #96 instead of #98. Here is how I detected it (using the current master merged with your recent changes):
Start trickster with a 100% clean cache. Request any url
# curl -g 'http://my.trickster.fqdn.com:9090/api/v1/query_range?query=my_query_here&start=1543952782&end=1543953082&step=60'
(No response)
Make the same request again:
# curl -g 'http://my.trickster.fqdn.com:9090/api/v1/query_range?query=my_query_here&&start=1543952782&end=1543953082&step=60'
Full Response Received:
{"status":"success","data":{"resultType":"matrix","result":[{"metric":{"failure":"0"},"values":[[1543952760,"25.568510766704293"],[1543952820,"25.631668883048594"],[1543952880,"25.326226925519595"],[1543952940,"25.199999999999815"],[1543953000,"25.129824561403314"],[1543953060,"25.29122807017526"]]},{"metric":{"failure":"1"},"values":[[1543952760,"0.03157905817213394"],[1543952820,"0.031579058172133946"],[1543952880,"0.038596355802260326"],[1543952940,"0.031578947368421054"],[1543953000,"0.03859649122807017"],[1543953060,"0.05614035087719298"]]}]}}

(accompanying debug logs for the requests above)
time=2018-12-04T20:24:46.387372919Z app=trickster caller=trickster/main.go:63 level=info event="application startup" version=0.1.2
time=2018-12-04T20:24:46.387741923Z app=trickster caller=trickster/memory.go:39 level=info event="memorycache setup"
time=2018-12-04T20:24:46.387792546Z app=trickster caller=trickster/metrics.go:47 level=info event="metrics http endpoint starting" address= port=8082
time=2018-12-04T20:24:46.387959086Z app=trickster caller=trickster/main.go:94 level=info event="proxy http endpoint starting" address= port=9091

time=2018-12-04T20:24:52.192511417Z app=trickster caller=trickster/handlers.go:657 level=info event="starting originRangeProxyHandler" cacheKey=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:52.395010098Z app=trickster caller=trickster/handlers.go:312 level=debug event=prometheusOriginHttpRequest url="http://prometheus:9090/api/v1/query_range?end=1543953060&query=my_query_here&start=1543952760&step=60" duration=185.264946ms
time=2018-12-04T20:24:52.401166014Z app=trickster caller=trickster/handlers.go:312 level=debug event=prometheusOriginHttpRequest url="http://prometheus:9090/api/v1/query?query=my_query_here" duration=191.383478ms
time=2018-12-04T20:24:52.40122951Z app=trickster caller=trickster/memory.go:47 level=debug event="memorycache cache store" key=aade0adf5f2ad6da17b2f94d3cf343ed.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:52.401623809Z app=trickster caller=trickster/handlers.go:854 level=debug event="Compressing Cached Data" cacheKey=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:52.401687323Z app=trickster caller=trickster/memory.go:47 level=debug event="memorycache cache store" key=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:52.401712055Z app=trickster caller=trickster/handlers.go:860 level=debug event=setCacheRecord cacheKey=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73 ttl=21600

time=2018-12-04T20:24:57.490149329Z app=trickster caller=trickster/memory.go:56 level=debug event="memorycache cache retrieve" key=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:57.490215365Z app=trickster caller=trickster/handlers.go:522 level=debug event="Decompressing Cached Data" cacheKey=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73
time=2018-12-04T20:24:57.490392862Z app=trickster caller=trickster/handlers.go:591 level=debug event=deltaRoutineCompleted CacheLookupResult=hit cacheKey=8357e505473d9e936694566d8525dda2.6a8564ed8ab42df78d1368ae1e56cc73 cacheStart=1543952760000 cacheEnd=1543953060000 reqStart=1543952760000 reqEnd=1543953060000 OriginLowerExtents.Start=0 OriginLowerExtents.End=0 OriginUpperExtents.Start=0 OriginUpperExtents.End=0 extent=none

As a more concrete example, I curl'd http://localhost:18082/api/v1/query?query=prometheus_build_info&time=1543957478.813&_=1543957448463 and I got data back both times. Whats interesting is my debug logs don't have any mention of compression, maybe something to do with that (can't repro the issue with compression on or off in config from my side either :/) ?

Thomas - it looks like your example that is working is a query, rather than a query_range.
The issue appears to be isolated to query_range requests. I am still digging but it looks related to checks around response StatusCode handling (it is being seen as 0 instead of 200, and thus triggering the errorBody instead of the "good" body at or around handlers.go:724)
Try it with curl -g 'http://localhost:9090/api/v1/query_range?query=go_goroutines&start=1543957478&end=1543957778&step=60'
Also, an additional regression has been introduced with your PR that I have found: providing the same value for start and end to a query_range (not an optimal way to do this, but technically it should work, and does work directly to prometheus), trickster now panics with index out of range error.

@jranson fix is in https://github.com/Comcast/trickster/pull/101 -- basically 2 issues, (1) I had changed resp -> r incorrectly, and (2) even if that was fixed the check if the resp was still not set was incorrect (as it would never be true). That PR fixes the issue, and I can no longer reproduce the issue.

@jacksontj  Everything checks out now. This is truly awesome, thank you so much for all of these contributions. Trickster is so much better because of it!


Mix dialyzer fails

Test Steps
Run
mix dialyzer

This does typechecking. You will get this error:
lib/teiserver/helpers/oban_logger.ex:43:call
The function call will not succeed.

System.convert_time_unit(any(), :native, :milliseconds)

breaks the contract
(integer(), time_unit() | :native, time_unit() | :native) :: integer()

Looking at the valid units
https://hexdocs.pm/elixir/1.12/System.html#t:time_unit/0
I think it should be :millisecond not :milliseconds
@Beherith this is a file you have worked on recently so it would be good if you can investigate.

Addressed in #304


<EMAIL_ADDRESS>download via aria2 failed

Got the following error when trying to install pgadmin on Windows 10 and cmd
>scoop install pgadmin4-np
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
WARN  To disable this warning, run 'scoop config aria2-warning-enabled false'.
Installing 'pgadmin4-np' (4.29) [64bit]
Starting download with aria2 ...
Download: 06/08 23:21:25 [ERROR] CUID#8 - Download aborted. URI=https://ftp.postgresql.org/pub/pgadmin/pgadmin4/v4.29/wiDownload: Exception: [AbstractCommand.cc:351] errorCode=3 URI=https://ftp.postgresql.org/pub/pgadmin/pgadmin4/v4.29/windDownload: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 62a70f|ERR |       0B/s|C:/Users/Daniel/scoop/cache/pgadmin4-np#4.29#https_ftp.postgresql.org_pub_pgadmin_pgadmin4_v4.29_windows_pgadmin4-4.29-x86.exe
Download: Status Legend:
Download: (ERR):error occurred.
Download: aria2 will resume download if the transfer is restarted.
Download: If there are any errors, then see the log file. See '-l' option in help/man page for details.

ERROR Download failed! (Error 3) Resource was not found
ERROR https://ftp.postgresql.org/pub/pgadmin/pgadmin4/v4.29/windows/pgadmin4-4.29-x86.exe
    referer=https://ftp.postgresql.org/pub/pgadmin/pgadmin4/v4.29/windows/
    dir=C:\Users\Daniel\scoop\cache
    out=pgadmin4-np#4.29#https_ftp.postgresql.org_pub_pgadmin_pgadmin4_v4.29_windows_pgadmin4-4.29-x86.exe

ERROR & 'C:\Users\Daniel\scoop\apps\aria2\current\aria2c.exe' --input-file='C:\Users\Daniel\scoop\cache\pgadmin4-np.txt' --user-agent='Scoop/1.0 (+http://scoop.sh/) PowerShell/5.1 (Windows NT 10.0; Win64; x64; Desktop)' --allow-overwrite=true --auto-file-renaming=false --retry-wait=2 --split=5 --max-connection-per-server=5 --min-split-size=5M --console-log-level=warn --enable-color=false --no-conf=true --follow-metalink=true --metalink-preferred-protocol=https --min-tls-version=TLSv1.2 --stop-with-process=23996 --continue --summary-interval=0 --auto-save-interval=1

I’m not sure when this changed exactly, but it looks like the current version is 4.30 and it’s only available as a 64-bit binary. I was able to get it to work by changing autoupdate.url to https://ftp.postgresql.org/pub/pgadmin/pgadmin4/v$version/windows/pgadmin4-$version-x64.exe and running checkver.ps1 pgadmin4-np -u '4.30', which updated it for me locally and allowed me to install the application.


Add Effort/Achievement spacy adjective attribution

This begins to address #64 and #8:
This includes the conventional/naïve wordlist check from before, but now also tries to attribute that adjective to a noun/pronoun in the text. If it can find one, it excludes adjectives about a set of excluded pronouns (I, me, myself) so as to avoid the problem in this comment where adjectives about the writer are excluded.

@ProfJanetDavis unfortunately I'm a bit out of my depth in more nuanced NLP. The first version of this was able to correctly detect issues in noun phrases, but longer, more complex sentences were still a bit out of reach.
I rewrote the way I traverse phrasal dependency trees and I think that I have tuned it for better performance on your example text, but in general I have a feeling there will still be some corner cases no matter what we do, for as long as we stay in rule-based problem-detection.
Take a look and see if this resolves your concerns?

Are you sure you've pulled the latest from this branch? I am not encountering these issues, and your text is from the old (master) version.

I'm still having trouble with this one:

[9:15pm] janet@MacBook-Air (~/sandbox/gender-bias): pip install -e .
Traceback (most recent call last):
  File "/usr/local/bin/pip", line 6, in
    from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip._internal.cli.main'
[9:15pm] janet@MacBook-Air (~/sandbox/gender-bias): python3 bin/genderbias -f example_letters/letterofRecW
[nltk_data] <snip/>>
Traceback (most recent call last):
  File "bin/genderbias", line 6, in
    from genderbias import ALL_SCANNED_DETECTORS, Document
  File "/Users/janet/sandbox/gender-bias/genderbias/__init__.py", line 40, in
    _scanned_detectors = scanned_detectors()
  File "/Users/janet/sandbox/gender-bias/genderbias/__init__.py", line 30, in scanned_detectors
    for path in module_paths
  File "/Users/janet/sandbox/gender-bias/genderbias/__init__.py", line 30, in
    for path in module_paths
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.7/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/Users/janet/sandbox/gender-bias/genderbias/effort/__init__.py", line 16, in
    import spacy
ModuleNotFoundError: No module named 'spacy'

But more significantly: @j6k4m8, I don't think we should merge this. I don't think it's good to mix NLP libraries in the production code base, especially when there's a comprehensive move from nltk to spacy on the horizon.
@molliem do you have any opinions on this? It's not a code issue so much as a project direction/pacing issue.

The new corpus requirement from spacy is only a handful of megabytes, and it is quite common to use multiple NLTK libraries in the same project. But if you think this disqualifies from mergability, it makes more sense to close this branch and wait a few months to solve this until I have time to make the switch all at once.

Fair enough! I think I'd like @molliem's opinion before we decide.
Janet
On Sat, Jul 18, 2020 at 7:24 AM Jordan Matelsky<EMAIL_ADDRESS>wrote:

The new corpus requirement from spacy is only a handful of megabytes
https://github.com/explosion/spacy-models/releases//tag/en_core_web_md-2.3.1,
and it is quite common to use multiple NLTK libraries in the same project.
But if you think this disqualifies from mergability, it makes more sense to
close this branch and wait a few months to solve this until I have time to
make the switch all at once.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660490569,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXJIU5NFWT6NSGRCSGG2LTR4GWARANCNFSM4OPLZR7Q
.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis

I don't understand the difference between the different corpus'
I haven't weighed in because I don't understand what we are trying to
decide.
On Sat, Jul 18, 2020 at 12:35 PM Janet Davis<EMAIL_ADDRESS>wrote:

Fair enough! I think I'd like @molliem's opinion before we decide.
Janet
On Sat, Jul 18, 2020 at 7:24 AM Jordan Matelsky<EMAIL_ADDRESS>wrote:

The new corpus requirement from spacy is only a handful of megabytes
<
https://github.com/explosion/spacy-models/releases//tag/en_core_web_md-2.3.1
,
and it is quite common to use multiple NLTK libraries in the same
project.
But if you think this disqualifies from mergability, it makes more sense
to
close this branch and wait a few months to solve this until I have time
to
make the switch all at once.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660490569
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AEXJIU5NFWT6NSGRCSGG2LTR4GWARANCNFSM4OPLZR7Q
.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660531328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGNPQY5XCBZBG46QDTGMPMDR4H2ONANCNFSM4OPLZR7Q
.

--
Mollie Marr
MD/PhD Candidate | GS3
Developmental Cognition And Neuroimaging Lab
https://www.ohsu.edu/school-of-medicine/developmental-cognition-and-neuroimaging-lab
Department of Behavioral Neuroscience
Oregon Health & Science University
Immediate Past President, National Student Division
American Medical Women's Association (AMWA)
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>

Fair enough! I’m willing to defer to Jordan since he has more ownership of this repo, or perhaps he and I should meet and hash it out.
--
Janet Davis
Sent from my "smart" phone, in haste, with auto-(in)correct

On Jul 19, 2020, at 3:14 PM, Mollie Marr<EMAIL_ADDRESS>wrote:

I don't understand the difference between the different corpus'
I haven't weighed in because I don't understand what we are trying to
decide.
On Sat, Jul 18, 2020 at 12:35 PM Janet Davis<EMAIL_ADDRESS>wrote:

Fair enough! I think I'd like @molliem's opinion before we decide.
Janet
On Sat, Jul 18, 2020 at 7:24 AM Jordan Matelsky<EMAIL_ADDRESS>wrote:

The new corpus requirement from spacy is only a handful of megabytes
<
https://github.com/explosion/spacy-models/releases//tag/en_core_web_md-2.3.1
,
and it is quite common to use multiple NLTK libraries in the same
project.
But if you think this disqualifies from mergability, it makes more sense
to
close this branch and wait a few months to solve this until I have time
to
make the switch all at once.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660490569
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AEXJIU5NFWT6NSGRCSGG2LTR4GWARANCNFSM4OPLZR7Q
.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660531328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGNPQY5XCBZBG46QDTGMPMDR4H2ONANCNFSM4OPLZR7Q
.

--
Mollie Marr
MD/PhD Candidate | GS3
Developmental Cognition And Neuroimaging Lab
https://www.ohsu.edu/school-of-medicine/developmental-cognition-and-neuroimaging-lab
Department of Behavioral Neuroscience
Oregon Health & Science University
Immediate Past President, National Student Division
American Medical Women's Association (AMWA)
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

And @molliem, I know you are super busy right now, too. Hang in there!
--
Janet Davis
Sent from my "smart" phone, in haste, with auto-(in)correct

On Jul 19, 2020, at 4:13 PM<EMAIL_ADDRESS>wrote:
Fair enough! I’m willing to defer to Jordan since he has more ownership of this repo, or perhaps he and I should meet and hash it out.
--
Janet Davis
Sent from my "smart" phone, in haste, with auto-(in)correct

On Jul 19, 2020, at 3:14 PM, Mollie Marr<EMAIL_ADDRESS>wrote:

I don't understand the difference between the different corpus'
I haven't weighed in because I don't understand what we are trying to
decide.
On Sat, Jul 18, 2020 at 12:35 PM Janet Davis<EMAIL_ADDRESS>wrote:

Fair enough! I think I'd like @molliem's opinion before we decide.
Janet
On Sat, Jul 18, 2020 at 7:24 AM Jordan Matelsky<EMAIL_ADDRESS>wrote:

The new corpus requirement from spacy is only a handful of megabytes
<
https://github.com/explosion/spacy-models/releases//tag/en_core_web_md-2.3.1
,
and it is quite common to use multiple NLTK libraries in the same
project.
But if you think this disqualifies from mergability, it makes more sense
to
close this branch and wait a few months to solve this until I have time
to
make the switch all at once.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660490569
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AEXJIU5NFWT6NSGRCSGG2LTR4GWARANCNFSM4OPLZR7Q
.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660531328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGNPQY5XCBZBG46QDTGMPMDR4H2ONANCNFSM4OPLZR7Q
.

--
Mollie Marr
MD/PhD Candidate | GS3
Developmental Cognition And Neuroimaging Lab
https://www.ohsu.edu/school-of-medicine/developmental-cognition-and-neuroimaging-lab
Department of Behavioral Neuroscience
Oregon Health & Science University
Immediate Past President, National Student Division
American Medical Women's Association (AMWA)
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I looked into this a bit over the weekend.  I think I would rather have
multiple libraries with the detector as part of the MVP than not have the
detector in place.  I think we can work on making it more streamlined as a
next step.
On Sun, Jul 19, 2020 at 4:14 PM Janet Davis<EMAIL_ADDRESS>wrote:

And @molliem, I know you are super busy right now, too. Hang in there!
--
Janet Davis
Sent from my "smart" phone, in haste, with auto-(in)correct

On Jul 19, 2020, at 4:13 PM<EMAIL_ADDRESS>wrote:
Fair enough! I’m willing to defer to Jordan since he has more ownership
of this repo, or perhaps he and I should meet and hash it out.
--
Janet Davis
Sent from my "smart" phone, in haste, with auto-(in)correct

On Jul 19, 2020, at 3:14 PM, Mollie Marr<EMAIL_ADDRESS>wrote:

I don't understand the difference between the different corpus'
I haven't weighed in because I don't understand what we are trying to
decide.
On Sat, Jul 18, 2020 at 12:35 PM Janet Davis<EMAIL_ADDRESS>wrote:

Fair enough! I think I'd like @molliem's opinion before we decide.
Janet
On Sat, Jul 18, 2020 at 7:24 AM Jordan Matelsky <
<EMAIL_ADDRESS>wrote:

The new corpus requirement from spacy is only a handful of megabytes
<

https://github.com/explosion/spacy-models/releases//tag/en_core_web_md-2.3.1

,
and it is quite common to use multiple NLTK libraries in the same
project.
But if you think this disqualifies from mergability, it makes more
sense
to
close this branch and wait a few months to solve this until I have
time
to
make the switch all at once.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660490569

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AEXJIU5NFWT6NSGRCSGG2LTR4GWARANCNFSM4OPLZR7Q

.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660531328
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AGNPQY5XCBZBG46QDTGMPMDR4H2ONANCNFSM4OPLZR7Q

.

--
Mollie Marr
MD/PhD Candidate | GS3
Developmental Cognition And Neuroimaging Lab
<
https://www.ohsu.edu/school-of-medicine/developmental-cognition-and-neuroimaging-lab

Department of Behavioral Neuroscience
Oregon Health & Science University
Immediate Past President, National Student Division
American Medical Women's Association (AMWA)
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-660724280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGNPQYYOZBZDNFLAEGI2BQDR4N44VANCNFSM4OPLZR7Q
.

--
Mollie Marr
MD/PhD Candidate | GS3
Developmental Cognition And Neuroimaging Lab
https://www.ohsu.edu/school-of-medicine/developmental-cognition-and-neuroimaging-lab
Department of Behavioral Neuroscience
Oregon Health & Science University
Immediate Past President, National Student Division
American Medical Women's Association (AMWA)
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>

@molliem, I believe the detector works as currently implemented with nltk in the master branch. It's just a bit over-eager. @j6k4m8, does that seem right to you?
I can go either way on merging this.

I vote we merge now, and then start to address this in earnest with the
integration-tests we mentioned upthread (in parallel with the shift to
Spacy)
On Mon, Jul 20, 2020 at 6:38 PM Janet Davis<EMAIL_ADDRESS>wrote:

@molliem https://github.com/molliem, I believe the detector works as
currently implemented with nltk in the master branch. It's just a bit
over-eager. @j6k4m8 https://github.com/j6k4m8, does that seem right to
you?
I can go either way on merging this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-661394284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFJKBYJL7G2OPBUH3T3KK3R4TBO7ANCNFSM4OPLZR7Q
.

Works for me! Thanks for your patience!
On Mon, Jul 20, 2020 at 5:47 PM Jordan Matelsky<EMAIL_ADDRESS>wrote:

I vote we merge now, and then start to address this in earnest with the
integration-tests we mentioned upthread (in parallel with the shift to
Spacy)
On Mon, Jul 20, 2020 at 6:38 PM Janet Davis<EMAIL_ADDRESS>wrote:

@molliem https://github.com/molliem, I believe the detector works as
currently implemented with nltk in the master branch. It's just a bit
over-eager. @j6k4m8 https://github.com/j6k4m8, does that seem right to
you?
I can go either way on merging this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-661394284
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAFJKBYJL7G2OPBUH3T3KK3R4TBO7ANCNFSM4OPLZR7Q
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gender-bias/gender-bias/pull/73#issuecomment-661502016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXJIU6T5FR6MEGZV36SOGTR4TQTRANCNFSM4OPLZR7Q
.

--
Janet Davis (she/they)
Department Chair, Computer Science
Associate Professor and Microsoft Chair of Computer Science
Whitman College, Walla Walla, WA 99362
206-383-8798 (cell), http://cs.whitman.edu/~davisj/
Schedule an appointment: http://meetme.so/JanetDavis


Consider both components and wrappers directories.

@LasaleFamine Maybe we can consider to provide another directory beside the components one:

Components (For modular components)
Wrappers (for containers components like views, pages, components-containers)

What do you think?

Maybe the wrappers folder inside the components folder?
Like:
   /src/components/
       |-- app -> files
       |-- wrappers -> component-folder -> files
       |-- units -> component-folder -> files

Is useful for every automated task having all the components within a single directory. Make sense?
We need to think also a mixins or behaviors folder, may be outside the component directory, which contains all the js classes shared between every component (one could be Redux).
Maybe I will open another issue for this.

Oks 👍

Thinking about the tree structure, actually we can have another directory beside the components or maybe inside, but we can just assume this as good practice for the skeleton.
We can think about a layout folder where place three (or more) components:
  /src/components/
       |-- wrappers -> component-folder -> files
       |-- units -> component-folder -> files
       ...
  /src/layout/
        |-- app -> files
        |-- header -> files
        |-- footer -> files

I don't know if it's too dogmatic, but could be a good sharing point for using the skeleton.
Ideas?

Or this structure?
  /src/components/
       |-- wrappers (complex composed components like areas inside views)
           ├ component-folder -> files

       |-- units (units components)
           ├ component-folder -> files

       |-- /shell/  (views and shell elements)
           ├ app -> files
           ├ header -> files
           ├ footer -> files

or do you this is a bit complicated @LasaleFamine ?

I think mine it's more complicated :man_astronaut:
+1 for your. Let's keep this open, I think also in relation to #16.

I think that logically both shell, units and wrappers are components and should stay inside the component folder. Otherwise the division should be made outside the component folder, and i don't like that.

@LasaleFamine This structure actually work?


Stage 5 classes slider viewer has a blank class

(I'm seeing this on the demo branch, but I'm guessing it'll be on main too because I don't see why the demo would be pulling different data).

Just for future reference, we think this went away because of some updates to backend data processing.


Is it possible to load route on first redirect to that route?

Hi! I have a question.
I have configured everything according to example in the test folder. And now one of my routes is loading async successfully BUT new chunk that contains this module is loaded along with other assets.
Is it possible to load appropriate chunk after first redirect to async route?

Yes, but it's not related to the loader, this is an @angular/router configuration
See the docs

Oh, sorry. Thank you very much :)


Allow PHPUnit ^7.0

Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

After changing composer.json file composer.lock should be updated as well.

After changing composer.json file composer.lock should be updated as well.

Of course, but how?
I mean, we all know the command composer update --lock but thisis not the case.
The lock file here is present to test a particular set of depencencies that are neither the lowest nor the latest. The fact is that I don't know how to rebuild it, or putin another way, I don't know the exact envirnoment on how the lock file should be updated into.

Of course, but how?

Basically build should work with any lock file - generated on any env but and builds should check set of different configuration - with different dependencies. I think you can use either
$ composer update --lock

or:
$ composer update nothing

and it will just update the hash in composer.lock. And it's enough.

I repeat what I saidin the previous comment: of course composer update --lock updates the lock file hash, but I think it's useless because it doesn't address the purpose of the lock file.
Btw, I've updated it.

@Slamdunk the only reason to do that is to keep composer.lock in sync, even if dependencies are still older than the latest ones.

Any ETA to merge?

@Slamdunk thank you


correct support route configuration components as a array

Version
2.4.1
Test Case
http://jsbin.com/wepineyika/1/edit?html,js,output
Steps to reproduce
visit http://output.jsbin.com/wepineyika/1#/test?_k=aq03lh
Expected Behavior
when components is an array, this.props.children should be working
Actual Behavior
this.props[0]
this.props[1] is working

This syntax is not supported.

Look into using named components if you want multiple children.


Update Features and Fix Bugs in V0.2.5

Updating benchmarks and documents:

Update mixup benchmarks in model_zoos: providing configs, weights, and more details.
Update latest methods in Awesome Mixups and Awesome MIM.
Update README.md and fix auto_train_mixups.py for various datasets.

Fixing bugs:

Fix the normalization bug in config files and plot_torch.py as mentioned in #16.
Fix the random seeds in tools/train.py as mentioned in #14.

Update v0.2.5 with the commit.


Expand upon existing ImageSubscript support (Metal, GLSL, SPIRV)

fixes: #4394
fixes: #4404

Added ImageSubscript support for Metal and test case(s)

Merge GLSL/SPIRV/Metal ImageSubscript legalization pass

Added multisampled texture support to glsl/spirv/metal for when using ImageSubscript

Metal does not support read+write on multisampled textures, check was added to verify target before legalization.

Fixed minor metal texture Load/Read bugs

HLSL methods of access do not support subscript accessor for texture cube array
removed swizzling of uint/int/float
other odd bugs which were causing compile errors

Notes:

Compute tests do not work due to what seems to be the GFX backend (causes crash without error report). These tests are disabled.
resolves tests/bugs/buffer-swizzle-store.slang of #4291,

https://github.com/shader-slang/slang/issues/4411 seems to be related to this issue

This may not be a blocker for your change.
But I personally don't like the long function like legalizeImageSubscriptStore . It will always increase the cyclomatic complexity.
Especially legalizeImageSubscriptStore is definitely separable regarding the functionality..

It will always increase the cyclomatic complexity. Especially legalizeImageSubscriptStore is definitely separable regarding the functionality..

I agree, I will rename the function. Should be fine to assume the functionality is to legalize ImageSubscript since it is in the file slang-ir-legalize-image-subscript.cpp.

It seems like tests/bugs/buffer-swizzle-store.slang is still failing for Metal.
See, https://github.com/shader-slang/slang/pull/4494

It seems like tests/bugs/buffer-swizzle-store.slang is still failing for Metal. See, #4494

It seems like the test was missing a keyword -compute.
I am running the test again with the fix.


Add kubernetes plugin slave auto-discovery

@bparees FYI (tested and working on centos7 image)

lgtm (pending packages becoming available in rhel)

[test]

[test]

[test]

@bparees this is a bug in this code... if user provide custom config.xml we override it when we generating kubernetes config. Fixed that and will merge this when Jenkins get green.

[merge]


Rework nix instructions now that nixpkgs has it

now that this project is packaged in the main nixpkgs repostitory
the need for instructing people to compile from source is unnecessary.
I'm also proposing changes to include process-compose as a built-in component in this project:
https://devenv.sh/
https://github.com/cachix/devenv/issues/78
The above would solve problems like https://github.com/F1bonacc1/process-compose/issues/14
and provide nice common service descriptions for common architectural components (postgres/kafka/redis/etc.).
Might be worth mentioning in the README.md once the above issue is resolved.

Hey @thenonameguy,
I gave it a little more thought. You don't need to change your PR. I will initialize the boolean flag to be false, so if you pass nothing we will get the desired behavior.
I will update my makefile to pass true, of course.


PlutoTV live channels support

Checklist

[X] I'm reporting a site feature request
[X] I've verified that I'm running yt-dlp version 2021.12.27. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Italy
Example URLs
https://pluto.tv/it/live-tv/pluto-tv-film-it
https://pluto.tv/it/live-tv/pluto-tv-film-azione-it
Description
While VOD is supported, live channels are not supported yet.
Verbose log
[debug] Command-line config: ['-Uv', 'https://pluto.tv/it/live-tv/il-banco-dei-pugni-it']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2021.12.27 [6223f67] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.18363-SP0
[debug] exe versions: ffmpeg 4.4.1-essentials_build-www.gyan.dev (setts), ffprobe 4.4.1-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [generic] Extracting URL: https://pluto.tv/it/live-tv/il-banco-dei-pugni-it
[generic] il-banco-dei-pugni-it: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] il-banco-dei-pugni-it: Downloading webpage
[generic] il-banco-dei-pugni-it: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://pluto.tv/it/live-tv/il-banco-dei-pugni-it
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1353, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1423, in __extract_info
  File "yt_dlp\extractor\common.py", line 599, in extract
  File "yt_dlp\extractor\generic.py", line 3829, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: https://pluto.tv/it/live-tv/il-banco-dei-pugni-it

theoretically this shouldn't be too hard if ffmpeg is used, i recently added it to one of my download bash scripts.
for anyone who is capable to write python code looking at the start.json at .EPG[0].stitched.path would be were the live master stream lives
but the thing is sorta actually live and ideally functionality would be added to detect video playing is also available as on demand so one would actually obtain the full content for archival purposes.


gcc: fix cyclic dependency for Darwin cross-build

When building a cross-compiler for Linux targets on Darwin hosts, the sanitizer libraries are built as Linux ELF shared objects. These binaries contain superfluous rpaths, causing a cyclic dependency between the out and lib outputs.
Manually pruning rpaths with patchelf fixes the issue. This should have no impact on non-cross builds.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@mroi Are you aware of the discussion in https://github.com/NixOS/nixpkgs/issues/88213?

No I was not. Sorry about that. It describes exactly the problem I was seeing: rpaths in the sanitizer libraries caused dependency cycles because they have been moved to a separate output.
With my patch, I get a working cross-compiler. But I am not sure if there is a better way to fix this, like reverting d9feea58aeded06aded50eee7e9d69ebe1086e7e.

@Ericson2314 @matthewbauer what are your thoughts on this approach versus @Gaelan 's https://github.com/NixOS/nixpkgs/compare/master...Gaelan:gcc-cross ?

It has been decided to go with PR #88213. I am closing this one and suggest everyone to follow that PR.


Required temperature no changes in boiler

Hi again,
If I change temperature from HA it does not produce any change in the boiler or in the phone app. If the temperature changes from the phone app it also does not change to HA.
I am testing and reviewing generated files in the aquaariston_data_http folder. If I change temperature from the phone app the file "data_ariston_get_main.json" is updated to the new data but in the frontend it does not change.
Temperature from phone app: 56 ºC
/config/aquaariston_http_data/data_ariston_get_main.json
{"gw": "***************", "on": true, "mode": 1, "temp": 50.0, "procReqTemp": 56.0, "reqTemp": 56.0, "antiLeg": false, "heatReq": true, "eco": false, "rmTm": "00:35:00", "avShw": 2, "pwrOpt": false}
Thanks for your time

Few questions:

When changing temperature via phone app did you wait up to few minutes in HA (did you check timestamp for mentioned file)? - it takes some time for HA to sync as unlike Ariston app which sends request when specific page is reloaded here I use periodic requests with set period that cashed relatively few connection events, so it might take time.
When changing temperature via HA did you reload page on phone app in about 10-15 seconds?

I do not have a boiler using this app nor I get any funding for this, so I do not want to look into code unless there is definitely a fault and I have time.
If there is fault I'll have a look into code and If I won't be able to find I'll probably need credentials to set traces to figure out which part does not work (from experience I had to add multiple logging cases to identify problematic place by multiple attempts and sending new file versions and waiting replies with logs I would consider a waste of my time (it is an option if it is potentially 1-2 times, not 5-15)).
So at first please confirm if there is actually a fault, if it is a fault, then I shall have code review, and if it won't help, I would need credentials to pinpoint the issue.

When changing temperature via phone app did you wait up to few minutes in HA (did you check timestamp for mentioned file)? - it takes some time for HA to sync as unlike Ariston app which sends request when specific page is reloaded here I use periodic requests with set period that causes relatively few connection events, so it might take time.
When changing temperature via HA did you reload page on phone app in about 10-15 seconds?

Yes, I waited a while and checked time stamp.
Yes

/config/aquaariston_http_data/data_ariston_get_main.json
{"gw": "XXXXXXXX", "on": true, "mode": 1, "temp": 48.0, "procReqTemp": 52.0, "reqTemp": 52.0, "antiLeg": false, "heatReq": true, "eco": false, "rmTm": "00:40:00", "avShw": 1, "pwrOpt": false}

Required temperature in phone app was set at 52 ºC but required temperature in hassio was set at 48 ºC.
/config/aquaariston_http_data/required_shower_temperature.json
{"required_temperature": 48.0, "showers_mode": "temperature"}

If you make any changes I can test it. Thanks!

The Velis boiler I based integration on did not use setting of temeparture directly but used number of showers (each additional shower stepped required temperature by multiple degrees). It caused additional logic, which stores/reads reuired temperature from dedicated file to tune number of showers. From what I understand in your Velis model you set temepartures directly.
If that is the case, you may try:

changing boiler type to "lydos" (not 'lydos_hybrid'), which shares a lot of data with Velis (including requests, which differ for lydos_hybrid) but works with temepartures directly.
if first step does not help, you may try replacing python file (also change extension to .py), which is potential workaround, which breaks logic for shower-based Velis so it is only a prototype to pinpoint the issue.
aristonaqua.txt

changing boiler type to "lydos" (not 'lydos_hybrid'), which shares a lot of data with Velis (including requests, which differ for lydos_hybrid) but works with temepartures directly.

It's working with changing boiler type to "lydos", thanks.
Testing with "velis" type: Required shower requests do not work either.


Optimize Linear Layer Operations in LoRALinear Class

This PR introduces a minor but impactful optimization in the LoRALinear class within the src/mistral_inference/model.py file.
Changes:

Updated forward method to compute LoRA outputs more efficiently by concatenating intermediate results, reducing computation overhead.

Benefits:

Improved performance and reduced computational overhead.
Cleaner and more maintainable code.

This change has been thoroughly tested and reviewed for correctness and efficiency.

I am not ready with the PR, please close it

can you explain this PR

@mandlinsarah This PR refactors the forward method by breaking down the computation process for clarity. Specifically, it stores the intermediate result of self.lora_A(x) in a variable lora_A_result before passing it to self.lora_B(). This change is intended to enhance readability and facilitate easier debugging, while maintaining the original functionality and output.


Makefile not outputting valid .wasm file

Hey I've been trying to compile main.wasm on multiple versions of Go (primarily 1.16.15 and 1.21.4).
When I run your main.wasm (which came with the repo) there are no issues, but attempting GOOS=js GOARCH=wasm go build -o main.wasm myself will give me a binary that doesn't seem to work.
The application throws the following error:
Error while parsing JSON-Object: TypeError: window.parseModelViaString is not a function

Could you share what flags you've been using to compile the .wasm file?

Funnily enough, I've got the same problem.

LoL, after one year fixed. The wasm_exec was too old.


[18.03] Relax global client lock on containerd restore.

backport of https://github.com/moby/moby/pull/36848 for 18.03
git checkout -b 18.03-backport-libcontainerd_client_locking upstream/18.03
git cherry-pick -s -S -x -Xsubtree=components/engine 806700e410a1b30aa1033d71d825e57880c75298
git push -u origin 18.03-backport-libcontainerd_client_locking

no conflits
This unblocks the client to take other restore requests and makes sure
that a long/stuck request can't block the client forever.

ping @tonistiigi @cpuguy83 PTAL


Changes to Database Schema

Here are the basic (functional) requirements that I intend to integrate into the website: -

There are 4 types of users who should be able to access the website:

Admin -> Has unsrestricted access to the website.
Teacher / Educator -> Can create, edit and delete questions and choices created by them.
Student -> Can only view question and select choices.
Guest -> Can view every question, but not edit or update anything. They can also not view any choices.

Every question can have at max 5 choices, out of which only one will be true.
Every question can belong to more than one category. One category can also have multiple questions.
A teacher can create a question_set which will consist of a set of questions in a single place. One teacher can create multiple question_sets.

Based upon these, I had created an ER Diagram. However, there are some logical flaws in it.

Find out the flaws and ping me for doubts.
Feel free to suggest any new changes / table you feel will be needed.

I guess no one else is interested in this.
sigh...

Okay, I created a new DB. Hopefully, it fixes it.


Add documentation for database SSL feature

As per PR #7243 and PR #7233, new documentation needs to be written.
I will work on this.

@dhensby @tractorcow As promised, documentation has been successfully completed in PR #7254.
Let me know what you think!

Merged


Clarify usage in README

Why:
Copying and pasting the usage command in the README doesn't work.
This PR:
Clarifies that you need to provide a project name when running stack
new.

Whoops! Good catch.
Looks good to merge.


Crypto Financing

Epic for progressing the work on Crypto Financing, use cases, and potential partnerships. All issues/tickets related to this work should fall under this epic.

This has been addressed in the DPG Explorations document.


optimize: RedisLocker#acquireLock use LUA

Ⅰ. Describe what this PR did
Use Lua to ensure atomicity
Ⅱ. Does this pull request fix one issue?

no
Ⅲ. Why don't you add test cases (unit test/integration test)?
jedis mock not support jedis.eval
Ⅳ. Describe how to verify it
acquireLock
Ⅴ. Special notes for reviews

Codecov Report

Merging #3472 (c586331) into develop (e9ff5f9) will decrease coverage by 0.28%.
The diff coverage is 37.28%.

@@              Coverage Diff              @@
##             develop    #3472      +/-   ##
=============================================
- Coverage      51.57%   51.28%   -0.29%
+ Complexity      3376     3362      -14
=============================================
  Files            617      617
  Lines          20467    20446      -21
  Branches        2564     2510      -54
=============================================
- Hits           10555    10485      -70
- Misses          8852     8886      +34
- Partials        1060     1075      +15

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/io/seata/core/lock/AbstractLocker.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...o/seata/server/storage/redis/lock/RedisLocker.java
36.84% <44.89%> (-26.56%)
7.00 <0.00> (-11.00)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

... and 30 more

Codecov Report

Merging #3472 (c586331) into develop (e9ff5f9) will decrease coverage by 0.28%.
The diff coverage is 37.28%.

@@              Coverage Diff              @@
##             develop    #3472      +/-   ##
=============================================
- Coverage      51.57%   51.28%   -0.29%
+ Complexity      3376     3362      -14
=============================================
  Files            617      617
  Lines          20467    20446      -21
  Branches        2564     2510      -54
=============================================
- Hits           10555    10485      -70
- Misses          8852     8886      +34
- Partials        1060     1075      +15

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/io/seata/core/lock/AbstractLocker.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...o/seata/server/storage/redis/lock/RedisLocker.java
36.84% <44.89%> (-26.56%)
7.00 <0.00> (-11.00)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

... and 30 more


Feature: Inject view models

#4180
Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Open app ...
Click settings button ...

Screenshots (optional)
N/A

also looping in: @d2dyno1

/azp run

Apart from that LGTM

Can you consider adding SidebarViewModel.cs to services? It is istantiated only once in the whole application (in MainPage.xaml.cs

Can you consider adding SidebarViewModel.cs to services? It is istantiated only once in the whole application (in MainPage.xaml.cs

We're going to limit the scope of this PR to what's already implemented and merge it once the requested changes are complete.

@lukeblevins thank you!

@lukeblevins can you check what happens if you change the background color (using one of the built-in options)? I think there is a regression.


build: build error

Fix npm install issue.
it happens due to @types/node and @types/react-native having conflicting types which are causing the error.

@Julesssss  could you please merge it? Thanks.


Help Request: Attach Action to TableView Cell Selection

Hi Colin, and thanks for this excellent example. Would you be able to suggest a way (or point to an example — I've been looking for hours but haven't found one that fits your better RAC4 approach) to respond to a table view cell selection? Something simple, like printing the indexPath for the selected cell. I tried making the TwitterSearchViewController a UITableViewDelegate but realized that RAC defeats that approach. And keep up the inspiring work!

Too old. Closing.


internal/gamepaddb: split the text file for each platform

Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
Now the text file is about 525 kb. Splitting this file and keeping a necessary part of it for each platform should reduce the executable binary sizes.
Why is this needed?
The smaller executable size, the happier we are.

I'd like to pick this up as a first issue if that's alright.

Thanks. As 2.7 is close to releasing, I might keep you waiting to merge your PR, but contributions are welcome.

Sounds good! I've been looking at the code and my current theorized approach is:

write a script to automate fetching the controller db from SDL_GameControllerDB and splitting into a text file per platform (delineated by # lines)
create db.go files for each platform with respective build tags and embeds pointed at each platform's respective controller text file

One area I'm not sure about yet are the platforms listed in this ticket that are not directly mentioned in the controller DB file. The file only references Windows, Mac OS, Linux, Android, and iOS. I'm not sure if e.g. Playstation 5, Switch, and Xbox fall under one of those umbrellas. I can see that js is explicitly excluded from the current controller db embed.

write a script to automate fetching the controller db from SDL_GameControllerDB and splitting into a text file per platform (delineated by # lines)
create db.go files for each platform with respective build tags and embeds pointed at each platform's respective controller text file

Yeah we should have a 'script' as gen.go, which runs by go generate. We would need these db_*.go files:

db_windows.go (Windows)
db_macos_darwin.go (macOS) with the build tag //go:build !ios
db_linbsd.go (Linux and other UNIX excpet for Darwin)
db_ios.go (iOS)
db_android.go (Android)

I'm not sure if e.g. Playstation 5, Switch, and Xbox fall under one of those umbrellas.

Consoles don't use the database, so we should treat this like js.


enableSnap={false} crashes with this._onScrollEnd is not a function

When I set the prop enableSnap to false and I scroll the carousel it crashes with:
this._onScrollEnd is not a function

I'm on iOS with<EMAIL_ADDRESS>

@Kerumen Good catch! I've released a fix in version 3.3.3. Can you confirm that it works for you?
The issue only occurs when you set lockScrollWhileSnapping to true, am I right? I must warn you that the prop doesn't have any effect when enableSnap is disabled.

It works! But lockScrollWhileSnapping was not enabled for me.


Sample test data support

This PR adds the ability to download sample data. It makes use of the sunpy sample data directory.

Would it not be better if we could use the sunpy machinery for this, and just give it an extra set of URLs? or even just put the iris data in the sunpy sampledata?

@Cadair i don't think that it should be part of the sunpy sample data as it's not really a solution for other affiliated packages. If the sunpy machinery could be made to be more easily used by affiliated packages that would nice.

@ehsteve Could you look into why the checks fail?  The test coverage one fails, I assume, because the overall test coverage has gone down which is fine at this stage.  But there are other failures too.

@ehsteve yeah that's fair, we should have a way to make this pulggable though, copy and pasting code is not sustainable either.

FYI, we've decided to make downloading sample data pluggable in sunpy. I've submitted a PR to sunpy to do that. I'll update this PR once that is done. Also we've seen hosted the iris sample data on github but to be served by AWS (see https://github.com/sunpy/sample-data).

OK sounds good!

Updated for new pluggable sunpy download architecture.

PR2116 has been merged so please update your SunPy and this PR should now work.


Feat/fix publicstore index bug

Found this bug as I was playing around with the box object and all() function in publicStore. This function had side effects on the internal representation of the db in orbitdb-kvstore.
NOTE: Merge this after #111

hmm would not have expected that, but yeah best to return new obj, if you want to make it more functional and once line, since already using map, could do
Object.keys(entries).reduce((acc, key) => { acc[key] = entries[key].value; return acc }, {})


Limit is not being enforced?

I'm seeing this behaviour:
[3] pry(main)> Sidekiq::Queue['cloud_cleanup'].limit
=> nil
[4] pry(main)> Sidekiq::Queue['cloud_cleanup'].limit = 5
=> 5
[5] pry(main)> Sidekiq::Queue['cloud_cleanup'].busy
=> 178

In my sidekiq.yml file I have:
:concurrency: 5
:verbose: false
:pidfile: tmp/pids/sidekiq.pid
production:
  :concurrency: 50
:queues:
  - [default, 10]
  - [cloud_copy, 3]
:limits:
  default: 40
  cloud_copy: 25

I'm using latest version from git with:
  remote: https://github.com/deanpcmad/sidekiq-limit_fetch.git
  revision: 9bf29b248458c80593939f937c67c42ad4fae7e1
  specs:
    sidekiq-limit_fetch (4.3.2)
    sidekiq (6.4.2)
      connection_pool (>= 2.2.2)
      rack (~> 2.0)
      redis (>= 4.2.0)
    rails (7.0.4)

I have this in my gemfile:
gem 'sidekiq', '~> 6.4', '< 6.5'
gem 'sidekiq-limit_fetch', github: 'deanpcmad/sidekiq-limit_fetch'
gem 'sidekiq-status'
gem 'sidekiq-unique-jobs'

Any ideas what I'm doing wrong?

Any ideas about this one? - can't seem to figure out what is going wrong or how to resolve.

@rgaufman I have the same gems, here is my config of sidekiq (initializers/sidekiq.rb)
require 'sidekiq/web'
require 'sidekiq-scheduler'
require 'sidekiq-status'

Sidekiq::Web.use Rack::Auth::Basic do |username, password|
  # Protect against timing attacks:
  # - See https://codahale.com/a-lesson-in-timing-attacks/
  # - See https://thisdata.com/blog/timing-attacks-against-string-comparison/
  # - Use & (do not use &&) so that it doesn't short circuit.
  # - Use digests to stop length information leaking (see also ActiveSupport::SecurityUtils.variable_size_secure_compare)
  ActiveSupport::SecurityUtils.secure_compare(
    ::Digest::SHA256.hexdigest(username), ::Digest::SHA256.hexdigest(ENV.fetch('SIDEKIQ_USER'))
  ) & ActiveSupport::SecurityUtils.secure_compare(
    ::Digest::SHA256.hexdigest(password), ::Digest::SHA256.hexdigest(ENV.fetch('SIDEKIQ_PASS'))
  )
end

# https://github.com/mperham/sidekiq/wiki/Using-Redis
SidekiqUniqueJobs.config.lock_info = true

Sidekiq.configure_server do |config|
  config.redis = { url: ENV.fetch('REDIS_URL') }

  config.on(:startup) do
    Sidekiq.schedule = YAML.load_file(Rails.root.join('config', 'schedule.yml'))
    SidekiqScheduler::Scheduler.instance.reload_schedule!
  end

  config.client_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Client
    chain.add Sidekiq::Status::ClientMiddleware, expiration: 5.hours
  end

  config.server_middleware do |chain|
    chain.add Sidekiq::Status::ServerMiddleware, expiration: 5.hours
    chain.add SidekiqUniqueJobs::Middleware::Server
  end

  SidekiqUniqueJobs::Server.configure(config)
end

Sidekiq.configure_client do |config|
  config.redis = { url: ENV.fetch('REDIS_URL') }

  config.client_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Client
    chain.add Sidekiq::Status::ClientMiddleware, expiration: 5.hours
  end
end

Ah, sorry, I forgot to post my sidekiq initialiser in the question, I already have this, but just trying your config now, will report back:
SidekiqUniqueJobs.configure do |config|
  config.logger = Sidekiq.logger # default, change at your own discretion
  config.debug_lua       = false # Turn on when debugging
  config.lock_info       = false # Turn on when debugging
  config.lock_ttl        = 86_400 # Expire locks after 24 hours
  config.lock_timeout    = nil   # turn off lock timeout
  config.max_history     = 0     # Turn on when debugging
  config.reaper          = :ruby # :ruby, :lua or :none/nil
  config.reaper_count    = 1000  # Stop reaping after this many keys
  config.reaper_interval = 600   # Reap orphans every 10 minutes
  config.reaper_timeout  = 150   # Timeout reaper after 2.5 minutes
end

Sidekiq.configure_server do |config|
  config.redis = {
    url: ENV.fetch('SIDEKIQ_REDIS_URL', 'redis://<IP_ADDRESS>:6379/1'),
    network_timeout: 15, pool_timeout: 15, timeout: 15
  }

  config.client_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Client
  end

  config.server_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Server
  end

  SidekiqUniqueJobs::Server.configure(config)
end

Sidekiq.configure_client do |config|
  config.redis = {
    url: ENV.fetch('SIDEKIQ_REDIS_URL', 'redis://<IP_ADDRESS>:6379/1'),
    network_timeout: 15, pool_timeout: 15, timeout: 15
  }

  config.client_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Client
  end
end

@dawidof Sorry, maybe I'm being dense, in your example it shows UniqueJobs, not sidekiq-limit_fetch - I already have the required middlewhere for uniquejobs, but I cannot find any example for limit_fetch?

I don't have any experience with Sidekiq Unique Jobs so there's a possibility it could be overriding limit_fetch?

I'm not seeing any issues in my app but I just use sidekiq-limit_fetch so I'm going to close this for the moment

I updated all gems and restarted sidekiq and now limits are enforced as expected, strange! Thank you for the replies.


Opened/closed and fill level sprites for drinks, condiments, and more

About the PR

This adds visual differences to the sprites of many of the game's drinks when they are opened, as well as visual fill levels for most see-through drink containers. Condiment packets are visibly torn open in the corner when opened. Glue, lube, and condiment bottles are visibly opened too. I also noticed that the soda bottles were all completely opaque, so I fixed that while I was at it. Oh, and I updated the wine bottle sprite to say 14 instead of 13, 'cause yeah.
As a result of the way fill levels take on the color of the contained liquid, many of the drinks have changed slightly in appearance. This can be adjusted in the future by modifying the colors of the reagents, but seems outside the scope of this already large PR. This also means that if you refill the bottles with a different liquid, they'll take on the new color appropriately.
Why / Balance

All this information is in the game, so why not make it more readily visible? It's nice being able to tell if a bottle is open and how much is left in it. Plus, bartending should be a bit cooler looking now.
Technical details

First, I apologize for the volume of files changed. Major thanks to anyone who reviews this beast.
I used multiple inheritance in the entity prototypes to try to keep the copy-pasting to a minimum.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added opened/closed visuals and fill levels for a variety of drinks.

blessed

I intentionally didn't change the trash version of the bottle, so I think you can still find empty bottles lying around, implying that someone drank all of the 13.
I had fun trying to work out the real versions of all of the bottle designs. I wasn't sure about the wine bottle, to be honest. My best guess is that it's based on 19 Crimes?


AgeRelatedAllowanceChooser could be generalised

(Note: pulled out of README)
The AgeRelatedAllowanceChooser has been created to return the
age-related personal allowance to assist with the calculation of
married couple's allowance. However, the reduction of allowances that
takes place in MarriedCoupleAllowanceCalculator applies to other tax
calculations, as your personal allowance depends on both your age and
income. So the AgeRelatedAllowanceChooser could be changed to a
PersonalAllowanceCalculator and extended such that it takes all those
factors into account and can be used across the system to calculate
someone's personal allowance depending on their age, income, and if
required, other factors:
[http://www.hmrc.gov.uk/incometax/personal-allow.htm]

I've moved this to Trello in an attempt to end up with a single place containing Smart Answers stories/tasks/bugs.
See the Trello card (not public).
Closing this issue.


Include check for existence of jinja files and api_helpers dir in aft-account-customizations pipelines

AFT Version:
1.10.3
Bug Description
When the customizations pipelines are run and a developer hasnt added the api_helpers dir and jinja templates to the account specific terraform dirs the pipeline fails after running terraform plan and it isnt clear what the problem is.
When I encountered this issue I was attempting to deploy vpc/subnets in an account. The terraform error is:
Error: creating EC2 VPC: UnauthorizedOperation: You are not authorized to perform this operation.
The buildspec log error message:
[Container] 2023/05/23 06:28:44 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: if [[ $CODEBUILD_BUILD_SUCCEEDING == 0 ]]; then
The above error messages dont provide any useful feedback in describing the issue.
Expected behavior
Early failure with helpful error message in aft-account-customizations buildspec when the jinja files/api_helpers dir do not exist

@saccy thank you for reporting this. I have created a backlog to address your request.


Migrate travis to use new docker system.

test/run now detects best vim to use.
travis now installs built vim into $DEPS (or $HOME/deps).

Advantages:

Faster startup/execution.
Travis a bit more explicit.
Don't know if legacy support will ever be dropped, preventative.

Cons:

Sudo still unsupported, but don't think we will ever need.

I'll just leave this for your feedback @junegunn, if you are alright with changes its fine to go.

On a related note, I have noticed intermittent build failures happening at random. After your doc change yesterday, I had to do several restarts to get a green build. I guess it is just travis/github being flakey but should keep in mind.

One more thing: their article says that sudo: false is required to use the container-based stack, but I don't see it here Something's changed, or you just forgot to put it there?

@junegunn Ah that's true, hehe. Also geez, github really having problems. One of the last travis jobs got a 443 on the clone :/.

Funny how we both missed that glaring typo, all fixed up now. Any other comments?

Looks like the overhead of the legacy mode of execution was not a dominant factor in build time and thus the change doesn't seem to make the build noticeably faster. But still I prefer the style of the new travis.yml, so let's go for it. Thanks!

@junegunn One advantage of new infrastructure I forgot to mention is optional caching. Though I didn't enable it as I'm not sure what kind of cache expiration policy we want. By default, cache lasts until you manually expunge it via dashboard. If we don't care about most recent vim build, we could just invalidate it ourselves when we feel like it.

Ah, okay, thanks for the explanation. Sounds nice, but rapid build is obviously not something we desperately need at the moment. :)


Allow to use catalog files

As a user of redhat "XML" extension for vscode, i use a catalog file in which i list custom dtd that are used in various documents.
When trying to remediate some files with XSLT, saxon raised an error about not knowing the dtd.
Might be cool to add a catalog setting as to avoid the error while retaining the doctype in the source document (and avoid removing the original doctype to bypass this.

see commit ce96b003944c5130d278596ecd7322c048f85734


Disable analytics when running daemon from within our tools

In daemon_client.dart, line 19, we run "flutter_tools daemon", which appears to be sending an analytics ping. Since this is an internal command, I don't think we're interested in tracking when our tools themselves run daemon.

cc @devoncarew

It's somewhat interesting to know the usage of the tools from IDEs.

The daemon tool is only used by IDEs?

Yup, it's what IDEs use to get device add/remove notifications.

Closing this as I don't think it hurts to track it.

Would we know the difference between a human running flx and a tool/script ? Perhaps humans never run flx so we can reasonably assume a tool is driving it.
Leaving the report of flx means when we want to know the top commands our users are running, we'll have to filter out flx. That might be possible in the analytics UI.

We're sending in a --suppress-analytics arg to calls to flx from tooling (from the xcode script) now. Any place where we're not we should add that arg - we shouldn't need to do any filtering of the analytics data.

Ah, I see. This is specifically about daemon, not the policy of sending pings from within tools. Gotcha. Thanks!


[Feature Request]  reading marks under messages

Duplicate of #156.

On that note, @benawad, can I have permission to close/tag issues?

@unDeadHerbs invited you as a collaborator


HOP-3842

HOP-3842 PipelineExecutor: wrong groupBuffer initialization
Following this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [HOP-XXX] - Fixes bug in SessionManager,
where you replace HOP-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.
If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[x] In any other case, please file an Apache Individual Contributor License Agreement.

Can we add some tests to this? A couple of pipelines with different group settings and check if the incoming data is correct.

The only tests we can add are unit tests and not integration tests or do tou have a different idea?


yet anoterh DUMD rule

Have you ever checked your impact on public methods???? just check the following code
public class OperationController
{
#region Methods
    /// <summary>
    /// Check if the service is alive
    /// </summary>
    /// <returns></returns>
    [HttpGet]
    public async Task<bool> IsAlive()
    {
        return await Task.FromResult(true)
                         .ConfigureAwait(false);
    }

    #endregion
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73190016-ddef-0e31-ffb2-d72d551e0d0b
Version Independent ID: 44822112-d0c7-3f59-75c0-3e81f1ee57d7
Content: CA1822: Mark members as static - Visual Studio
Content Source: docs/code-quality/ca1822.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@d4e666 I can repro CA1822 on this code. It sounds like you would like to see the rule changed so that this code does not emit the CS1822 warning? Can you clarify? Or, do you see a doc issue here? Thanks

Since you mentioned public methods, I'm guessing your question falls into the category described in the "When to suppress" section: i.e., "It is safe to suppress a warning from this rule for previously shipped code for which the fix would be a breaking change."
If you would like to see the behavior changed, please open an issue in https://github.com/dotnet/roslyn-analyzers/issues


Implement Threshold when updating asset price in pallet unit of Account

The first attempt to implement asset price and issuance threshold is wrong.
We need to implement the threshold in the right way such that:

We have a particular percentage(can be a u8) runtime Config value which can be used to determine the lower and upper bound of the asset price(from storage). When calling the update_asset_priceextrinsic, we'd check the incoming price with the dynamic lower and upper bound asset price(which are to be calculated using the percentage set in the runtime Config) to be accepted.

We also need to perform the check in 1 over a certain number of blocks. We therefore need another runtime Config value indicating the number of blocks to check for.

Whitelisting accounts that can update resolves this.


Removed .npmignore

Fixes #669

Removed .npmignore.
Checklist

[ ] I have made corresponding changes to the documentation.
[ ] I have updated the types definition of modified exports.
[x] I have verified the functionality in some of the neeto web-apps.
[ ] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers

@AbhayVAshokan _a
Please review.