Why aren't double, int, bool and string properties of AEXMLElement optionals?

Let's say I've created an AEXMLElement object from API data and I assume its value is a double but I'm obviously not sure, since it's coming from an external source.
If I then use the AEXMLElement object's double property, I have no way of knowing if the data was invalid, I will just get 0.0 if it's invalid, but that may be valid data. Why isn't double an optional, so I can check if it's actually valid? As far as I can see I would have to check if value is non-nil and can be cast to Double myself.

Well, I thought those are like convenience properties which you can use in most cases to accomplish your logic. If you would need more specific behavior you could extend AEXMLElement and implement other computable properties with your logic. Now, I agree it could be vise-versa too.

Hmm, I'm not sure I understand your logic. Could you give me an example of a scenario, where I would expect or even want to get a 0.0 value when that isn't the actual value from the XML source?
This is Apple's introduction of optionals:

You use optionals in situations where a value may be absent. An optional represents two possibilities: Either there is a value, and you can unwrap the optional to access that value, or there isn’t a value at all.

It seems to me like this is a perfect scenario for using optionals.

Yes, that's why value property is optional. You may achieve your logic by just using that property and casting it to different types yourself. You may also extend AEXMLElement to have properties like optionalDouble, optionalBool etc. if you want to use it like that everywhere.
While I understand your reasoning behind this, try to understand that those are convenience properties for more simple usage of the library and I have 2 reasons not to change that:

Simplicity - you probably noticed that subscript of AEXMLElement could also return optional (if element is not found) but it doesn't. That's because if everything would be optional it would make end-user's code more verbose and harder to write in the end. Some other libraries prefer this approach, but I think that's exactly what differentiate AEXML from the others.

Legacy - even if I would maybe do it like you said if I was making this from scratch (still maybe not because of reason 1.), think about breaking changes of existing end user's code if this kind of logic update is introduced. It would require handling those optionals everywhere in code, and I bet most of the users would handle it the same way as it's already working now.

About scenario in which this approach could work as supposed: imagine a backend which always returns exactly the same structure of data which always contains all the fields in proper format, so that way "alternative" values would never be used, and end user's code would be more brief and easier to write.

How do you know the backend always returns valid data? I'm not trying to be facetious here, but using a remote API seems like one of the most obvious scenarios where you should properly validate the received data, since you have no control over what the API returns.
I don't find your arguments very convincing, breaking changes are expected with major or minor releases, I mean, every major new Swift version usually has a bunch of breaking changes. I think you're opting for minor added convenience in place of important data validation, but it's obviously your library and therefore your decision, and I don't seem to be able to convince you otherwise. :)

I don't know if backend will always work properly (probably not), that was just "example"... :)
Anyway, in the end, this is kind of everybody's code, feel free to contribute by implementing those changes and making a pull request.
After all this discussion, I think that compromise would be to add new separate properties (rather then replacing existing), and leave existing convenience properties as they are. This way users of library could choose what they prefer to use and we don't have breaking changes. We just need to think of some good explanatory names for those new properties. What do you think?

I think that's a fine compromise. I added a suggestion in #110.

Hi @mattsson,
I thought some more about this and decided to make initial convenience typed accessors to be optionals (instead of having default values) like you suggested on the beginning of this issue.
I just didn't like redundancy which came up in #110 that much, so even if this is gonna be a breaking change for some, it will be easy to fix and it makes more sense in the end.
Cheers

@tadija I am very happy to hear that, will look forward to the release!

@mattsson release is already there (4.1.0) :)

Ah, nice. I took a look at the code. You left the non-optional string in there?

Yes, because it's used for other accessors, and value is already optional string so no need to duplicate that.


chore(protractor-typescript-cucumber):cucumber 3.x support

Added cucumber 3.x support
This should fix the circle ci test as well.
Added json & html reports
Added tslint to project
Updated readme file.

Yay tests are passing! if circle ci is happy then everyone's happy :smile:


webpack v5 compatibility

R: @philipwalton @housseindjirdeh (who might have some more webpack background)
Fixes #2630
There are unfortunately a lot of changes; they basically follow the guidance I received from the webpack team at https://github.com/webpack/webpack/issues/11425
The codebase should work with webpack v4.40.0 or higher or webpack v5.0.0, so that's a breaking change (we previously worked with webpack v4.0.0 or higher).
There are now two different sets of tests, each going against a different major version of webpack. (Thanks to @developit for help getting the proper node module resolution set up.)
One major outstanding issue is compatibility with the latest html-webpack-plugin (see https://github.com/jantimon/html-webpack-plugin/issues/1522); I believe they still need to do some work to properly support webpack v5.0.0, and in the meantime, I would consider using our plugin alongside it unsupported. I did not want that to block getting this new code out there for the Workbox v6 prereleases, though.

I added the comment to the test and updated the devDependency to the webpack v5.0.0 release.


Models and containers in different order making dropped elements show up in wrong containers

I'm having an issue, but I can't provide a working demo, because it looks like a race condition. But I think I can't explain what is probably happening by referencing back to the code.
Context: using angularjs 1.5.8, angular-dragula 1.2.8. Google Chrome 53.0.2785.143 (64-bit) and Firefox 49.0.1 on Mac OS X 10.11.6. I'm using angular-dragula to drag elements between multiple containers, each container an array using dragula-model attribute.
The issue: sometimes, when dragging and dropping an element to another container, it shows up in another container instead of the container it was dropped on. Sometimes the model dropped turns into an undefined reference.
In my debug sessions, I found out that angular-dragular loads drake.containers at the time of linking (https://github.com/bevacqua/angular-dragula/blob/fccd088c4776eb7d1d282325ac33c6afbd181a48/directive.js#L28), and drake.models on a watch callback (https://github.com/bevacqua/angular-dragula/blob/fccd088c4776eb7d1d282325ac33c6afbd181a48/directive.js#L47).
In this line https://github.com/bevacqua/angular-dragula/blob/fccd088c4776eb7d1d282325ac33c6afbd181a48/service.js#L44 , that service expects the container and its respective model to be at the same index in both arrays (drake.models and drake.containers), but sometimes, depending on the initial values on dragula-model attributes, they might not be in the same indices, because at linking time, when containers are added, its respective model might still be null and it will just return on this line https://github.com/bevacqua/angular-dragula/blob/fccd088c4776eb7d1d282325ac33c6afbd181a48/directive.js#L35 .
I don't know if angular watches and linking order are deterministic, but as a workaround I added an ng-if to the element with the dragula-model attribute, so it is only linked and fires watch when that model actually has a value. But ng-if creates another scope, so I had to add dragula-scope="$parent.$parent" to make dragging to another container work. It seems to mitigate the problem, but I've seen the issue happening after doing that.
Thanks for building this library. It feels so much better than any other DnD library I've used!

I had a similar issue, and the problem turned out to be that one of the dragula-models was set to null before the dragula directive was initialized. When that scope attribute was later populated by an http callback, it seems to sometimes confuse angular-dragula's association map between containers and models. Setting the attribute to an empty array from the start resolved the immediate issue.


fix: yarn classic  Command "tsc" not found

Problem

We removed installing tsc for yarn-classic in https://github.com/aws-amplify/amplify-backend/pull/1016 and the test didn't fail, because the yarn create amplify was not using the correct beta version.

This PR is to fix yarn-classic and the test.
Note: we have to install create-amplify saperately because yarn create fails when specifying a package version
Issue number, if available:
Changes

install tsc for yarn-classic
install create-amplify in local folder and use the binary directly

Corresponding docs PR, if applicable:
Validation

Checklist

[ ] If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
[ ] If this PR requires a change to the Project Architecture README, I have included that update in this PR.
[ ] If this PR requires a docs update, I have linked to that docs PR above.
[x] If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you update the description with details on the following?

Why we removed installing the tsc from yarn classic in https://github.com/aws-amplify/amplify-backend/pull/1016?
Why do we have to add it back?

Can you update the description with details on the following?

Why we removed installing the tsc from yarn classic in fix(package-manager): pnpm tsc not found #1016?
Why do we have to add it back?

It was removed because the test didn't fail after I removed them 😂  (I thought we could just remove)
Now I fixed the test and added them back.


2 0/admin UI id column

Description
Updates ID columns in admin UI to utilize CodeCell component if less than 5 chars in length

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Chore (non-breaking change which does not add functionality)

Checklist:

[x] Existing test suite passes locally with my changes

Getting a build error on this PR


add simplified chinese translation

Add Simplified Chinese translation for issue #1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Zaeworks sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

好看了，谢谢！


Binomial_Distribution_(User-Defined)

Find the mean and variance of a binomial distribution of number of coin flips (X), probability of heads (Y) and number of samples (N) in it with optional seed value (S) all variables are user defined.

@Dekode1859 Please add your name to the contributors.html file

@dikshantrajput Added my name to contributors.html


Add Minesweeper

Added Minesweeper.
Maybe consider splitting games into their own category, separate from other applications?

Merged. I'll take your suggestion of splitting apps and games into mind.

Reopening so I can mark this as merged.


Pinning multiple table columns looks wonky

Environment

Is this bug related to Nuxt or Vue?
Nuxt
Version
v3.0.0-alpha.10
Reproduction
Pin multiple columns from the docs and scroll to the right:
https://ui3.nuxt.dev/components/table#with-column-pinning
Description
The columns overlap:

Additional context
No response
Logs

It's an example, I don't think it will happen in a real-life project. The pinned columns are sticky with transparent background and background blur on purpose.


refactor: [M3-6282] MUI v5 Migration - SRC > Features > StackScripts pt1

Description 📝
Part 1 of migrating the MUI styling for the StackScripts package. This PR is for the Partials, SelectStackScriptPanel, StackScriptBase, StackScriptCreate and StackScriptForm subpackages.
Changes  🔄

Migrated styling from makeStyles to use Styled components and sx
Removed React.FC
updated imports to be named exports instead of default exports (unless lazily exported / the component had higher order functions applied to it)
removed unnecessary index.tsx files

How to test 🧪
There should be no visual changes.
Prerequisites
(How to setup test environment)

Set up local host and navigate to the stack scripts section

Verification steps
(How to verify changes)

Verify that there are no visual changes on the StackScript landing page
Verify that the StackScript create page still looks and functions the same
Verify that the StackScript section in the Linode Create flow still looks and functions the same

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[x] ❔ Our contribution guidelines
[x] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[x] 🔐 Removing all sensitive information from the code and PR description
[x] 🚩 Using a feature flag to protect the release
[x] 👣 Providing comprehensive reproduction steps
[x] 📑 Providing or updating our documentation
[x] 🕛 Scheduling a pair reviewing session
[x] 📱 Providing mobile support
[x] ♿  Providing accessibility support

merging -- confirmed that stackscript related cypress tests pass!


initial planning

From planning discussion:
*default item generation: small bounding box (at 0,0) and current datetime
-hecstac
	-ras  (core functionality, stable)
  -extensions
	  - v1
	  - v2
  -item (from prj & files)
	  - geom: current geometry vs unioned geometries ?
	  - datetime: last edited (if available)

  -asset (from any ras file)

	-hms (core functionality, stable)
		-[see ras]

	-event (relatively unstable)
		-extensions
			v1/ focus on results / outputs
		-ras.asset (ras plan output)
		-hms.asset (hms output)

		-ras.item (link: source model item)
		-hms.item (link: source model item)

	-utils
		-hec-text parser
		-s3-converters
		-file-grabber/file-search
		-api
		-validation?

	-collections (relatively unstable)
		-summarize data
		-assets (collection level)

should we share a consts.py and errors.py, for the entire repo?  or should ras have its own and hms have its own?

I am initially inclined towards having ras and hms have their own constant and error files (would this be subclasses of the Exception class that we would want to raise? or is it something else?), just because trying to import things across directories is annoying in python. Then I think about how events is shown as importing classes from ras and hms and that makes me think that importing from other directories is going to have to happen regardless

yes, subclasses of the Exception class.


Bump helm-chart submodule to add more restrictions to the server pod

Fixes #1377

Codecov Report

Merging #1511 (05c831e) into main (b2c1617) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
- Coverage   39.89%   39.32%   -0.58%
==========================================
  Files         165      165
  Lines       12090    12090
==========================================
- Hits         4823     4754      -69
- Misses       6558     6645      +87
+ Partials      709      691      -18

Flag
Coverage Δ

acceptance-apps
37.90% <ø> (-0.58%)
:arrow_down:

unittests
8.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/cli/usercmd/env.go
0.00% <0.00%> (-17.48%)
:arrow_down:

pkg/api/core/v1/client/envs.go
0.00% <0.00%> (-11.60%)
:arrow_down:

internal/api/v1/service/validate.go
43.58% <0.00%> (-10.26%)
:arrow_down:

pkg/api/core/v1/client/http.go
41.75% <0.00%> (-9.80%)
:arrow_down:

internal/cli/env.go
5.88% <0.00%> (-8.24%)
:arrow_down:

internal/application/workload.go
40.88% <0.00%> (-6.90%)
:arrow_down:

pkg/api/core/v1/client/services.go
13.98% <0.00%> (-5.60%)
:arrow_down:

internal/api/v1/service/delete.go
46.96% <0.00%> (-4.55%)
:arrow_down:

internal/cli/usercmd/service.go
31.59% <0.00%> (-2.98%)
:arrow_down:

internal/cli/services.go
36.88% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c1617...05c831e. Read the comment docs.


Support Diligent Adept's 'djtgcfg' utility for flow.program() on applicable Diligent boards

@cfelton
What do you think of the idea of adding programming support to flow.program() for Diligent boards through their command line djtgcfg utility? (supports windows and linux).     If you're good with it, how do you think it would fit abstraction wise?  It seems like boards that support it shouldn't duplicate the functionality.   (though I imagine it would only be a couple of lines of code to add it)

Capturing design conversation with @cfelton re: this task:
Christopher Felton @cfelton 09:02
reading the description, I think what would make the most sense is to create a class DigilentFPGA(FPGA) the class would live in build/boards/xilinx dir.
then the digilent board descriptions would change to class Atlys(DigilentBoard)
Christopher Felton @cfelton 09:03
I guess DigilentBoard would make more sense than DigilentFPGA


[Balancing] My personal feedback on the items

First off, props to you for making a highly polished item pack which fits almost seamlessly into the base game. I've played around with all of the items on several runs, and I think most of them are properly balanced, but here're my thoughts on some in particular:
Faulty Spotter - In a perfect world, this would be an actual drone you could repair, and not an item. ChensGradiusMod added new drones to the game in the past, maybe you could look into that if you wanted to expand upon this idea. You could re-use the same model you placed in Sundered Grove. As for the item, the fact the amount of scanned enemies is the value that stacks makes it very earrape-y once you go past several stacks. Maybe lower the initial critical chance, and let that scale instead?
Relentless Vendetta - It could really use shorter durations. It often feels like the effect is on at all times. With 15 seconds base and 15 additional seconds per stack you can very easily achieve constant Vendetta status once a single one of your drones dies during the Mithrix fight, using 3D printers or cauldrons. I would put it at 12 seconds base and 8 additional seconds per stack (exactly double the values of Berserker's Pauldron).
Mysterious Monolith - This item seems really out of place in the "normal" item pool, both balance-wise aswell as aesthetics-wise. It's very easily abusable when it comes to shrines of chance, but it also leads to very awkward moments where extremely expensive shrines of chance will never be deplenished. Shrines of the mountain do not spawn as reliably as the former, making extra teleporter rewards a very rare scenario where you happen to have Monoliths in your inventory and also found a shrine. From my experience, it seems like a very chaotic item. For that reason I think it would fit best into the Lunar tier, making it akin to Defiant Gouge (which spawns enemies on shrine usage, and does nothing else). You could add a downside, but for me it already has a very high risk/reward level (which thematically fits with both the game and the concept of lunar items), as you'll be potentially wasting lots of precious time trying to scrounge the last white out of a shrine of chance or struggling against elite superbosses because of multiple challenges of the mountain. Not to mention an ominous, black monolith doesn't belong with the other bits and baubles, but looks more like a unique artifact (which could reminisce the Obelisk where you can choose to obliterate).
Treasure Map - A very fun item, and well balanced, asking you to commit time and effort into a random Red. The only suggestion I could give is multiplayer related, to maybe have the area charge faster if more players are inside, just like teleporters. Maybe even have it act as a "Holdout Zone", and let the items that affect them (Lepton Lily, Focused Convergence, Crystallized World) work on the treasure spot too.
Rift Lens - As of right now this item is essentially a must-buy, since a single Red Whip negates its downside. I suggest for it to add +33% movement speed penalty per stack, and for each 33% penalty to be removed one at a time as you get rid of the Rift Afflictions by opening the chests (rather than having to open all of them).
Gate Chalice - A very interesting item. Love the visual effect, makes it seem like you're doing something you're not supposed to do. I think the debuffs should be a bit more emphasized since they become trivial in later stages (maybe have them scale better with player power, somehow). The cooldown should comfortably be raised to something like 3-5 minutes, balancing it out once you start stacking Fuel Cells. It also should not be usable in Commencement (where it just reloads the stage) to avoid issues/trolling/cheesing.
Ratio Equalizer - Incredible potential. Its cooldown should be inbetween the older value and the newer one, 30 seconds would be ideal. Mithrix being affected by this is very, very wrong. Attempting to use it on him should result in a cool easter egg (or very bad outcome) rather than its intended purpose.
Again, very nicely done with this. Good luck on your work.

Closing all suggestion/enhancement/balancing/feedback issues. A new, actual discussion board will be set up after the next mod update.
Thank you for the feedback though!


views: support auxiliary bar in OpenViewContainerAction

Fixes #169907

Oops, My approval auto merged it and I did not see the auto merge is enabled. Sorry about it.
@sbatten Feel free to suggest any additional comments if you have.


Proposal for implementation of PHP object storage in session handler

This PR fix PHP object storage in session handler (#100), by using systematically AS_BYTE_PHP data type.
It also adds support for binary session.serialize_handler like igbinary.
I successfully tested with all of these session.serialize_handler : php, php_binary, php_serialize, wddx, igbinary

:+1:

Hi @rbotzer and @jboone100 do you have an update for us on that ?
Thanks !

:+1:

:+1:

:+1:

👍

Ok, it's been 10 days this pull request has been submitted without no feedback.
It's been more than a month the issue #100 has been submitted without any real feedback. We are playing the open source game by submitting a Pull Request to fix a bug we need to see fixed and it's really annoying to have no feedback.
I think we finally should not move to aerospike in production if we can't have any serious feedback when we submit a pull request. What do you think @koleo ?

I agree @xavierleune that the lack of reactivity is quite annoying and may change our plans regarding the choice of Aerospike as our PHP Session backend (or other NoSQL needs).
However, as @rbotzer mentioned last week on this thread, it seems that Aerospike Team is working hard to release a PHP7-compatible version soon (including this PR)...
So, I keep hoping to see a fixed release in the next few days or weeks!

Thanks for the feedback. All these items are definitely on our radar and we certainly are working towards resolving them one at a time!


Trigger action and close layout after swiping

It is possible to trigger an action and close the layout after swiping the surface?

Add a ´SwipeLayout.SwipeListener´ (use ´SimpleSwipeListener) and override and trigger your action in onOpen()`

does it close the surface automatically? or do I have to do it manually?
if yes, how could I do it? Thanks

Updated my answer while you replied with exactly that, need to call close() as well onthe layout to get as a parameter in onOpen

cool thanks


 The text of these commands is written in the chat.
  - pex user <player> add To.Next
  - pex user <player> remove neproshel.obuchenie
  - sudo <player> tofarm

It is not very good for the player to see this. I think this does not need to be shown. In previous versions of the plugin, this was implemented differently.

Look at #849

Like @Technodate alluded to, use a command display override.
Sent with GitHawk


Protobuf java version 3.19.3 affected by CVE-2022-3171

The protobuf-java version declared in WORKSPACE.bazel ("com.google.protobuf:protobuf-java:3.19.3") is affected by CVE-2022-3171. Version 3.19.6 should be used instead as it contains the fix.

This has been fixed in https://github.com/google/closure-compiler/commit/6da46fcc7fe64b74eeb87dc4a2493611cdf30f6a.


[Refactor] Using half query_timeout as automatic partition creation timeout

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19510
Problem Summary(Required) ：

create partition timeout us thrift_rpc_timeout_ms, which is not convinent to change for load.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@merfigy backport branch-3.0


Updated settings to celery 4

#42

After upgrading the settings file, you need to set the prefix explicitly in your proj/celery.py module:
app.config_from_object('django.conf:settings', namespace='CELERY')
http://docs.celeryproject.org/en/latest/whatsnew-4.0.html#v400-upgrade-settings


chore(yarn): second attempt to make pnp works

Test out pnp related to this https://github.com/belgattitude/nextjs-monorepo-example/issues/800
Prisma still fails, maybe check https://github.com/prisma/prisma/issues/1439

pnp still have drawbacks when using standalone mode (@vercel/nft). Link: https://gist.github.com/belgattitude/0ecd26155b47e7be1be6163ecfbb0f0b
Closed


Wildcard on second-level domain does not work

I have setup mkcert, and in apache config successfully created two sites: hostname.local and somename.test. These two work, but then I also tried to setup a wildcard *.test system where other folders in the ~/Sites are "converted" to .test domains:
<VirtualHost *:443>
  ServerName test
  ServerAlias *.test

  VirtualDocumentRoot "/Users/David/Sites/%-2+"

  SSLEngine on
  SSLCertificateFile "/Users/David/ssl/_wildcard.test.pem"
  SSLCertificateKeyFile "/Users/David/ssl/_wildcard.test-key.pem"
</VirtualHost>

This system in Apache works, but the certificate doesn't work:

FWIW, in Chrome the error is  NET::ERR_CERT_COMMON_NAME_INVALID.

Most web browsers will not trust a second-level wildcard certificate. See here for example, which links to the source code in Chromiun (Google Chrome) that disallows it.

Indeed, this is not something that can be handled by mkcert AFAICT. It will work if you use a name like *.wild.test.

I'll add a warning though.

I get that this is a fundamental browser limitation but anyone think of why the certificate might work for one domain and not another? I've got a ".me" certificate installed into Apache for a VirtualHost proxy to puma/puma-dev. And while one domain gives me a warning:

the other says not secure but doesn't mention the certificate:

Any ideas?

@bradical Are you sure you accessed the second site using https:// and not just plain http://? Plain http:// without the s is what your second screenshot looks like.
For example:

It would appear you’re using Chrome, right? If you open DevTools there’s a security tab with more information about the certificate

@bradical Are you sure you accessed the second site using https:// and not just plain http://? Plain http:// without the s is what your second screenshot looks like.

Thanks for that! I think you're right.

It would appear you’re using Chrome, right? If you open DevTools there’s a security tab with more information about the certificate

Thanks for that too! I was unsure where to look for certificate information in the latest Chrome.


Checked Mistakes and Corrected.

"I have been checked and formatted."

Current behavior

Proposed changes

Checks

[x] All commits in this Pull Request are signed and Verified by Github.

@Nishitbaria @Yash636261 check and merge.

Please, try to mention the issue you are resolving with pull request. it makes easier for us to work with and leaves good impression also. : )

Sorry, I forgot to mention the problem and began solving it. I promise not to do this again. @Yash636261


x-useragent validation

Hi,
It seems there is a difference in RegExp-Validation between the sample Implementation of authorization-service and the OpenAPI
Setting User-Agent like this:
x-useragent: Zero-Go/0.0.1
Gives error:
vau-proxy-server       | 13:06:07.585 VPS ERROR ServerExceptionHandler: {MessageType=Error, Message=Transcript Error: 400 : "{"error":"invalid_request","error_description":"getNonce.userAgent.userAgent: invalid user agent: doesn't match pattern \"^[a-zA-Z0-9]{20}\\/[a-zA-Z0-9\\-\\.]{1,15}$\""}", ErrorCode=5}
Although RegExp in OpenAPI says:
https://github.com/gematik/ePA-Basic/blob/cc2ae0e7e9a8855ac531aa601bd2919e5afed798/src/openapi/I_Authorization_Service.yaml#L884-L888
The symbol - seems to be allowed in first part of user agent string (before the slash). Length is between 1 and 20.

Hi all,
I have the same issue here since I updated my Docker Installation "dc-mocks.yml" from version 1.0.9 to 1.0.10 ...
Regards,
Jürgen

Thank you for reporting this issue. We will create an internal ticket to fix it by adjusting the RegExp validation.
Best,
Iryna

Fixed with a release version 1.0.11


Pitch to apple

Apologize if this isn't the right forum, but I think, as well as yourself, as many people who are using this project, that this is the missing tool from the Xcode toolchain. Thank you for writing it, and maintaining it. I hope one day that Apple will offer a tool like this, but more importantly, this tool if there's some interest from both sides there.
I'm sure you've thought of this, but I'm calling it out, that the benefits go beyond just build/integration tooling. Swift will support LSP, and this tool essentially allows any IDE a path to integrate with Xcode itself rather than just the Swift toolchain. It could be a boon for adoption, as it lowers barriers for engineers to try client-side Swift development, but have IDE bias.

Feel free to close this as it's not actually an issue, but I couldn't find any forum of general discussion.

Thanks for the kind works @drkibitz. While I'd also love to see something like this built in, I'm hoping that's what the Swift Package Manager will bring to the table as it matures. As they add support for bundles and other platforms, XcodeGen's main reasons for existing will thankfully go away, as SPM can already generate an Xcode project on demand.

I had the same wish as you, but after having read too many points of views and debates on who’s responsibility it is, the Xcode team or the open source project, I tend to side with those who say it is Xcode’s responsibility, not SPM. Unless this point of view has changed, that was the point of view of the SPM project. Now yes there is Xcode generation now, but it is limited, and if I could find a recent article, backward and broken. Long story short, my hopes have been curbed, and I don’t think proper ingegration


Unit test the video conversion and plugin system

They are quite separate components and it should be possible to test them individually.
This is not the same as #27, which is about integration tests.
I'll set up some testing with AVA when I have a chance.

@issuehunt has funded $80.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.


[tvmc] add instruments for PassContext

cc @leandron

The i386 compilation failure was caused by the git fetch error. How can I trigger a new one tvm-ci/pr-head? @lhutton1 @Mousius @gromero

@tvm-bot rerun

@tvm-bot rerun

It seems that it doesn't work.

Hmmm seems like it didn't work for some reason, could you try a git commit --amend then a force push from your local branch?

https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/520
It seems that the CI system is not stable and so slow.

May I trigger the failed docs: GPU separately without the whole process? @lhutton1 @Mousius @gromero

And the unittest: CPU failed with the Upload JUnits to S3 error.

sorry the CI error there is a bit confusing (and you got a bit unlucky with the docs checkout failure, it should be fixed for subsequent runs), however there are test failures on arm: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/488#step-1582-log-1404

@zhyncs this looks like a github problem. they are reporting problems with their API servers, but not with git ops. might be worth retrying in a few hours in case there's something unreported going on.

sorry the CI error there is a bit confusing (and you got a bit unlucky with the docs checkout failure, it should be fixed for subsequent runs), however there are test failures on arm: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-13136/7/pipeline/488#step-1582-log-1404

fixed

@leandron @lhutton1 @Mousius @gromero Could you merge this PR?


[docs]: fix article "Deploy SSH Key"

Description
Article Deploy SSH Key needs to be updated, more details @ #855
Issue List

[ ] Guide the user to click Resource Name

Steps below needs to be fixed accordingly

1. Click DETAILS on the SSH key you want to deploy

[ ] Update action code to lowercase

❌ Wait for the Ssh-key:Deploy action to be completed
✅ Wait for the ssh-key:deploy action to be completed

This issue remains relevant to documentation

@thlmenezes can you assign this to me?


Test CORS for presigned put_object

This adds CORS testing for presigned put_object
URLs.

superceeded by https://github.com/ceph/s3-tests/pull/544


[CORE-1772] Updated helm diff version to support arm64 arch

While installing helm-diff tool, I ran into the below error. Doing a 3.1.3 -> 3.3.0 upgrade fixes this.
failed: [localhost] (item={'name': 'helm-diff', 'url': 'https://github.com/databus23/helm-diff', 'version': 'v3.1.3'}) => changed=true
  ansible_loop_var: item
  cmd:
  - helm
  - plugin
  - install
  - https://github.com/databus23/helm-diff
  - --version
  - v3.1.3
  delta: '0:00:04.612550'
  end: '2023-02-23 11:57:32.160696'
  item:
    name: helm-diff
    url: https://github.com/databus23/helm-diff
    version: v3.1.3
  msg: non-zero return code
  rc: 1
  start: '2023-02-23 11:57:27.548146'
  stderr: 'Error: plugin install hook for "diff" exited with error'
  stderr_lines: <omitted>
  stdout: |-
    No prebuild binary for macos-arm64.
    Failed to install helm-diff
            For support, go to https://github.com/databus23/helm-diff.
  stdout_lines: <omitted>

After upgrade:

Woohoo! Thanks guys!


Support dynamic imports in the node bundle

Part of #11996

⚠ This will need some testing by people more familiar with the extension to make sure web and the dynamic imported bits are working correctly.
Summary:

await import(...) syntax now works in the node bundle and are put in the same bundle for web
New dynamically imported modules:

portfinder
tcp-port-used
svg-to-pdfkit
@vscode/extension-telemetry

extension.node.js' webpack config now correctly uses tsconfg.extension.node.js
webpack.extension.web.config.js fallbacks didn't seem to be used so were removed
Simplified stripVTControlCharacters usage in gulpfile
New npm scripts: webpack-analyze:node, webpack-analyze:web - plus this now works for the node bundle 🎉
Centralized importing of reflect-metadata into platform/ioc/reflectMetadata.ts
Tightened up some eslint rules
Replaced import x = require(...) with import x from ...
LinkedMap was removed as it was unused and was causing invalid JS to be output 🤷

Unfortunately I can't get the stats for the previous state, but the size of the minified/production bundle before after building main just now was 3.72 MB, so it went down 0.85 MB
New state (stat):
All (7.1 MB)
extension.node.js (5.9 MB)
vendors-node_modules_vscode_extension-telemetry_lib_telemetryReporter_node_min_js.node.js (329.99 KB)
vendors-node_modules_microsoft_1ds-core-js_dist-esm_src_Utils_js-node_modules_microsoft_appli-f0ebb4.node.js (228.18 KB)
vendors-node_modules_portfinder_lib_portfinder_js.node.js (214.31 KB)
vendors-node_modules_microsoft_1ds-post-js_dist-esm_src_Index_js.node.js (141.91 KB)
vendors-node_modules_svg-to-pdfkit_source_js.node.js (121.94 KB)
vendors-node_modules_microsoft_1ds-core-js_dist-esm_src_Index_js.node.js (113.99 KB)
vendors-node_modules_tcp-port-used_index_js.node.js (74.02 KB)
node_modules_vscode_extension-telemetry_lib_sync_recursive_lib_Connection_-node_modules_vscod-7cf308.node.js (320 B)

New state (parsed):
All (3.38 MB)
extension.node.js (2.87 MB)
vendors-node_modules_vscode_extension-telemetry_lib_telemetryReporter_node_min_js.node.js (319.98 KB)
vendors-node_modules_svg-to-pdfkit_source_js.node.js (59.59 KB)
vendors-node_modules_microsoft_1ds-core-js_dist-esm_src_Utils_js-node_modules_microsoft_appli-f0ebb4.node.js (39.78 KB)
vendors-node_modules_portfinder_lib_portfinder_js.node.js (34.06 KB)
vendors-node_modules_microsoft_1ds-core-js_dist-esm_src_Index_js.node.js (25.01 KB)
vendors-node_modules_tcp-port-used_index_js.node.js (23.76 KB)
vendors-node_modules_microsoft_1ds-post-js_dist-esm_src_Index_js.node.js (22.92 KB)
node_modules_vscode_extension-telemetry_lib_sync_recursive_lib_Connection_-node_modules_vscod-7cf308.node.js (689 B)

Codecov Report

Merging #12129 (882d20b) into main (20701ef) will increase coverage by 0%.
The diff coverage is 93%.

:exclamation: Current head 882d20b differs from pull request most recent head 970b83f. Consider uploading reports for the commit 970b83f to get more accurate results

@@           Coverage Diff           @@
##            main   #12129    +/-   ##
=======================================
  Coverage     70%      70%
=======================================
  Files        495      495
  Lines      31109    30875   -234
  Branches    4886     4845    -41
=======================================
+ Hits       21826    21845    +19
+ Misses      7419     7173   -246
+ Partials    1864     1857     -7

Impacted Files
Coverage Δ

src/kernels/telemetry/helper.ts
94% <ø> (ø)

src/platform/vscode-path/map.ts
23% <ø> (+12%)
:arrow_up:

...ebviews/extension-side/plotting/plotViewer.node.ts
26% <0%> (ø)

src/extension.node.ts
78% <100%> (+1%)
:arrow_up:

src/kernels/execution/helpers.ts
65% <100%> (ø)

src/kernels/helpers.ts
73% <100%> (ø)

...kernels/jupyter/preferredRemoteKernelIdProvider.ts
95% <100%> (ø)

src/kernels/raw/session/rawKernel.node.ts
65% <100%> (ø)

src/platform/telemetry/index.ts
90% <100%> (-1%)
:arrow_down:

src/platform/telemetry/telemetry.ts
78% <100%> (ø)

... and 10 more

The compile differences might be vscode vs workspace typescript version

Error in web:
ERROR in ./node_modules/colors/lib/system/supports-colors.js 28:9-22
Module not found: Error: Can't resolve 'os' in '/home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/lib/system'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "os": require.resolve("os-browserify/browser") }'
	- install 'os-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "os": false }
resolve 'os' in '/home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/lib/system'
  Parsed request is a module
  using description file: /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/package.json (relative path: ./lib/system)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/lib/system/node_modules doesn't exist or is not a directory
      /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/lib/node_modules doesn't exist or is not a directory
      /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/colors/node_modules doesn't exist or is not a directory
      /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules
        single file module
          using description file: /home/runner/work/vscode-jupyter/vscode-jupyter/package.json (relative path: ./node_modules/os)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/os doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/os.ts doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/os.js doesn't exist
        /home/runner/work/vscode-jupyter/vscode-jupyter/node_modules/os doesn't exist
      /home/runner/work/vscode-jupyter/node_modules doesn't exist or is not a directory
      /home/runner/work/node_modules doesn't exist or is not a directory
      /home/runner/node_modules doesn't exist or is not a directory
      /home/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./node_modules/colors/lib/colors.js 41:23-[72](https://github.com/microsoft/vscode-jupyter/actions/runs/3528324146/jobs/5930316161#step:39:73)
 @ ./node_modules/colors/lib/index.js 1:13-32
 @ ./src/test/datascience/widgets/commUtils.ts 12:33-50
 @ ./src/test/datascience/widgets/standardWidgets.vscode.common.test.ts 36:20-42
 @ ./src/test/ sync \.common\.test$ ./datascience/widgets/standardWidgets.vscode.common.test
 @ ./src/test/web/index.ts 69:22-68


Update loading and saving of parameters.

Load_params and save_params have been deprecated in favor of
load_parameters and save_parameters. Replace all occurrences of
load_params and save_params with load_parameters and save_parameters,
respectively as per
https://mxnet.incubator.apache.org/tutorials/gluon/save_load_params.html

Note this change will eliminate the warnings of deprecation of load/save params and allow us to include these notebooks in the MXNet continuous integration test based on the Straight Dope, here: http://jenkins.mxnet-ci.amazon-ml.com/job/NightlyTests_onBinaries/
Thank you!


Fix various sonar warnings for class ActionSupport

see https://builds.apache.org/analysis/dashboard/index?id=org.apache.struts%3Astruts2-core%3Asrc%2Fmain%2Fjava%2Fcom%2Fopensymphony%2Fxwork2%2FActionSupport.java

Coverage decreased (-0.002%) to 46.891% when pulling 67d0e71f3e9a1033c0614fcf2256aa9638e98c1f on sepe81:fix-sonar-warnings-for-ActionSupport into 7530042ead8013205569e9a8fe7a66ca3cc927a0 on apache:master.

LGTM 👍


feat(): back-button css

Short description of what this resolves:
Extracts ion-button from the back-button component and adds custom css.

@mhartington,
I merged this in a separate branch that rebased nicer. Nice job!
Thanks,
Dan


Vmon cherry picked outline proxy controller

@AurangZ Apologies for the slow reply! I've been out on leave. Many thanks for addressing those comments. Now I'm going to look at the C++ code :-)

@AurangZ @vmon I finally looked at the C++ code. For now, two things stand out:

the size of the test file
moving the main function to //third_party


Remove deface reliance

Made this PR to the public repo to, but not sure it's perfect for that one. Should work for us.

@jacobherrington for our purposes I changed your PR to target the gemini_master branch. We can make a separate PR for upstream against their master.

@jacobherrington Can you rebase this against gemini_master and resolve the conflicts? I think that will make it merge ready.


RevEng: Updating command-line table-selection syntax

As per the design meeting - see https://github.com/aspnet/EntityFramework/wiki/Design-Meeting-Notes-(October-1,-2015)#table-selection-in-reverse-engineering
Fix for #3296. Also provides fix for #3227.

No longer checking in to release branch - closing in favor of #3356.


Case insensitive search

When filtering projects, the search is case sensitive.
Please add a case - insensitivity to this.

Closed #991


MessagesClientApplication not listening on the defined port

Describe the bug
When running MessagesClientApplication, it sayings that the application started but is not listening on the port (8080). When I opened http://<IP_ADDRESS>:8080/, the browser is responding ERR_EMPTY_RESPONSE
To Reproduce
Just run MessagesClientApplication
Expected behavior
MessagesClientApplication should listen on the configured port (8080).
Sample

@zubair-farooqui The messages-sample has been working for a while now without any issues reported. Can you try rebooting your machine and start over again. If the issue is still happening, can you try on another machine? I suspect it's environment related.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


[web]: Fail to announce button press when using

issue: Screenreader is not announcing what button is pressed (using enter key). Also related, the snack bar that appears when a button is pressed isn't announced or read out loud.
Expectation: Screenreader should indicate that the button is pressed by announcing the action. Snackbar announcement should trigger when snackbar pops up.
Tested using JAWs, NVDA, VoiceOver on Chrome
Sample code: https://github.com/morrison999/aira-flutter

Reproducible on the latest master 2.3.0-17.0.pre.180 with Narrator.

flutter doctor -v
[√] Flutter (Channel master, 2.3.0-17.0.pre.180, on Microsoft Windows [Version 10.0.19041.985], locale et-EE)
    • Flutter version 2.3.0-17.0.pre.180 at C:\Development\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 320f27713b (6 hours ago), 2021-06-03 02:49:03 -0400
    • Engine revision fe6d19b911
    • Dart version 2.14.0 (build 2.14.0-176.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\202.7351085\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\202.7351085
    • Flutter plugin version 57.0.2
    • Dart plugin version 202.8488
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Ultimate Edition (version 2021.1)
    • IntelliJ at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\211.7442.40
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19041.985]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.77
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 91.0.864.37

• No issues found!

This issue has the same cause as https://github.com/flutter/flutter/issues/83809. Deduplicating


Rewrites delete() and batch_delete() to support bulk delete per request

Hi, I came upon this repo and found it super useful in my personal project. The new bulk support of Airtable API looks nice, so I decided to give it a try to add it to this library.
I tried not to change the behavior of existing public methods. I found that batch_xxx methods call _batch_request(), so to not change too much code, I decided to let delete() accepts multiple ids, and made batch_delete() call it repeatedly. Since batch_delete()'s behavior changed so much, I had to change the test for it.
I also fixed some typos in the tests along the way. If this PR goes well, I would like to add bulk support to methods as well.

I think batch api has been added in some form.
sorry we weren't able to use this, but thank you for your contribution.


set firstDigest to false in schemaValidate directive

In my specific use case, I have a customized multi-select form element. But when the form is first loaded, scope.firstDigest of this directive is false. AT: schema-form.js#L2858
Which makes it to validate this form element, and update ngModel.$error at the first time. This is not the expected behavior I think. scope.firstDigest here should be true the first time it is loaded.
I could solve the issue by increasing the timeout at schema-form.js#L2634 to for example: 1000. So, I guess this may related to the sequence how angular initialize the directives and how much time each directive will take.
This pull request do solved my issue, but I'm not sure if there are more elegant ways(or if this breaks anything). feel free to comment :)

@ruanyl could you perhaps create a gist or plunker to demonstrate the different behaviours? Help us to see what is happening and what you expect to happen more clearly.

@ruanyl I agree, it would really help.

@ruanyl can you check out the issue in the alphas and see if this is still needed in some way or not? Please re-open if it is and we can work on it, but I am hopeful it is no longer an issue :)


Do vcpkg_build_cmake before vcpkg_install_cmake

Mentioned here: https://github.com/Microsoft/vcpkg/issues/258#issuecomment-259098011
This PR adds vcpkg_build_cmake to all portfiles (at time of commit) that didn't already have it

Hi @Morten242, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

I think that this is the right thing to do, for reference all the vcpkg_build_cmake were removed after the discussion in  https://github.com/Microsoft/vcpkg/issues/123 between @ras0219-msft and @KindDragon .

Hmm, if it does overbuild then adding "/m" to vcpkg_install_cmake.cmake might be a better choice. And then we might as well remove vcpkg_build_cmake if it's not going to be used for anything. But I'll leave this up here for now.

yeah, this is a limitation of how cmake and vcpkg stamp files I think, that's why packages were being overbuilt.

I think adding vcpkg_build_cmake() to individual portfiles is fine (and generally good for debugging), however I think there isn't a strong value in adding it back to all the existing portfiles. For any new ones you create, feel free to use the separate build step for better debugging or not use it if there's an issue with rebuilding.


Uncaught Error: Geofence latitude is not provided in geofence.js:137

Hello,
I am using VS2015 Professional to develop an android app. When i deploy on my ANDROID 6 device i am getting the following error when i check using "CHROME://INSPECT". Please help to resolve the error. I am also getting the following errors in my VS2015. I've added the Promise Plugin (https://github.com/vstirbu/PromisesPlugin.git).

@coddypotter the plugin has own promise plugin dependency. Have you resolved your problem?


Unify OpenQASM 2 exceptions

Summary
Since gh-9784 added a new qiskit.qasm2 package and suitable exceptions for both import and export of OpenQASM 2 programs, this commit now unifies the exception handling through the rest of the library to use these exceptions.
To avoid breaks in compatibility, the old qiskit.qasm.QasmError is now a re-export of qiskit.qasm2.QASM2Error.  This is the base error of both the exporter and importers, despite the old documentation of QasmError claiming to be specifically for parser errors.  In practice, the exporter also emitted QasmError, so having that be QASM2Error allows people catching that error to get the same behaviour in these new forms.  The actual exporter and importer are updated to emit the precise subclasses.

Details and comments
Probably this will clash a little with #9955 (and this PR technically probably wants to merge before that one) and potentially #9953.  I'll fix any merge conflicts as they arise.
This PR is preparing for a later total deprecation and removal of the qiskit.qasm namespace, likely starting in Terra 0.26, since we've begun the process of moving to qiskit.qasm2 and qiskit.qasm3 as explicitly versioned packages, to avoid confusion in the future.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 9 (100.0%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.006%) to 85.762%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
2
90.38%

qiskit/circuit/quantumcircuit.py
2
93.98%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
70190

Relevant Lines:
81843

💛  - Coveralls

The problems in the QPY backwards compatibility tests are likely because it uses a slightly unusual ordering and import structure for its objects, and there are nasty circular dependencies between qiskit.qasm and qiskit.circuit.  Once those circular imports are solved, it should not be an issue for the import structure in the QPY backwards compatibility tests if there's a temporary dependency between qiskit.qasm and qiskit.qasm2, since both will be fully at the same level of the hierarchy.
See #9959 for the fix on that.

Arg. I made every effort to ensure no conflicts... Anyway, a blank line and an unwanted import

John: what are you trying to do to this PR?  It was already up-to-date and rebased completely on top of main before your force push.

I convinced myself that it was not correct (because it was rebased on most recent main, and things disappeared). But, I think  it was correct. I also think that what I force pushed was also the same as what you did.

I fixed or avoided the two errors above here: https://github.com/jakelishman/qiskit-terra/pull/14

Ok, I've reverted it back to the previous state and put in the correct test fix - the issue is that a change in some of the imports caused qiskit.qasm2 to be loaded when previously it wasn't, which caused two "new" Gate subclasses to be picked up by an automated discovery in a place that they shouldn't have been.

I was just comparing your last branch to mine. I think I rebased on top of main that was less up to date than yours. So I agree reverting was correct.

picked up by an automated discovery in a place that they shouldn't have been.

I assumed it was intended. I may have tried harder with DefinedGate. But I ran into an opaque compiled extension when I wanted to look at OpCode.


Clearing olders logs

Hi,
I am looking for settings and MVC action for elmah which can show the logs for deleting...
and another action to delete the logs.
OR,
a way to indicate that don't parse all the log-files to count the total list. just parse first say 200 in reverse chronological order, only if we click on "next" after first 200, read the next.
Regards,
Amit

Can you be more specific as to what you are asking?  I don't understand.


Encoding of PSA SW Components claim

Decoding is supported, but encoding is not.
Note that the TFM version of this SW constructs the SW Component claims in its own way. What is done here is needed for the general library and for xclaim.  Maybe they can be combined, maybe not.

Duplicate of #39


compose: Make focus_in_empty_compose check untrimmed compose content.

The focus_in_empty_compose function used for hotkeys, now checks if the compose box is truly empty by considering it's untrimmed value. If there are just spaces in the focused compose box, focus_in_empty_compose returns false now.
This fixes the bug where using the left key among just spaces did not move back the cursor as expected, and may unexpectedly trigger edit state for the last sent message.

Fixes: #issues>can't use left key for spaces in composebox
Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Since focus_in_empty_compose is also used for determining how to process Up/Down/Home/End/PageUp/PageDown, those keys will also now navigate within a compose box containing only whitespace characters, rather than navigating the message feed.
I think changing that risks being annoying -- in particular, if you just hit Enter to open the compose box twice in a row (thus accidentally putting an extra Enter in the compose box), this change would now result in that preventing you from navigating the app using keyboard shotrcuts until you delete the enter character (or hit Esc) to close compose.
I'll post about this in issues for more discussion.

@timabbott Could you have another look at this? Have implemented the suggestions you made in the czo thread

@timabbott Marking for "integration review" since your feedback above has been addressed. I have not attempted to review.

Merged, thanks for fixing this @N-Shar-ma!


Increase CI speed.

Hi.
In this PR, I parallelized CI jobs, thus CI time was divided by approximately 1.5, from around 35 minutes to around 20 minutes.
Everything was tested and validated even release jobs.
I would like to have your opinion about it because there are several caveats:

There are several places where I do the same action, e.g. getting go 1.17, but I do not want to share it between jobs as artifact.
I bumped libseccomp from 2.5.1-1ubuntu1~20.04.1 to 2.5.1-1ubuntu1~20.04.2 because it seems to not exist anymore in ubuntu-latest.
I was not able to test rajatjindal/krew-release-bot due to a strange behavior.
local-gadget for arm64 was removed from build and release artifact due to #471.
In release artifact, inspektor-gadget-*tar.gz was replaced by kubectl-gadget-*tar.gz.

Best regards.

Hi.
Thank you for your input, here are some of my opinion so we can brainstorm about it:

Compile kubectl-gadget: it can be 1 Job for each architecture / os combination). Given that each one takes around 1 minute and a half I think it's just OK to have all of them under the same job.

I think I will let like it is actually (and the same for local-gadget), as the matrix permits the builds to occur in parallel because gaining 1 minute and a half is quite cool.

Build the gadget container image: given that it's a heavy task, a different Job for each architecture (taking into consideration we will add arm64 in the future) is needed.

Crossbuilding for arm is really long and in #441 I only build the arm image when pushing on master.

Unit tests, lint, etc. Those are very short tasks and don't block the integration tests, so I think it's fine to run them as different steps on the same job.

I think I will group them under one job.

Release tasks: All release related tasks can go on the same job IMO, they are very quick tasks so I don't think need to parallelize them.

I think I will also group them under one job.
Also, we do not release as often as we push, so this is acceptable if it takes a bit of time.
Best regards.

Nice CI times @eiffel-fl! Now it's nice and clear what could be further optimized. And run time seems to be <10min instead of previous ~30 minutes, awesome.

There is one more thing I forgot about. (It can be handled in this PR or if you prefer we can do in a different one).
Github Actions has a concurrency concept, it's to avoid running multiple actions at the same time for the same concurrency job. For example, if one pushes multiple times to the same branch, each push will be trigger a run and hence multiple workflows will be running for the same branch at the same time. It can produce some weird problems: a run could be use the container image pushed by another (I think I hit it once). By using concurrency we can avoid those problems and also make our CI a bit more efficient as we could cancel workflows that are not needed anymore.
I think the syntax we're looking for is:
concurrency:
  group: ${{ github.ref }}
  cancel-in-progress: true

Thank you for all your reviews!


Add dense layout support to dropdown

Added an isDense flag to DropdownButton to reduce the vertical size of the button.
By default DropDownButtons have the same height as their menu items, which is 48.0 per the material design spec.  Specifying isDense: true causes the button's height to be 24. This is useful for layouts that embed dropdowns in other decorated widgets, like InputContainers.
See #6604


[Component] Delete the Header component, it's left over from the boilerplate. And should we make our own Header?

Already done! ✅


Add support enabling multiple virtual tables at a time

For the cmdlets Set-BapEnvironmentVirtualEntity and Update-BapEnvironmentVirtualEntityMetadata, could it be possible to add support to pass a list of entities with their full names, so we modify the properties for all of them?
Is there any API limitation preventing this?

Hey @aariste , glad to see you here 😄
Thanks for the suggestion. I'm not sure if the API can handle multiple entities at once, @Splaxi can probably answer that.
But even if the API cannot, our cmdlets sure could and then just call the API in the background separately for each entity name.
You could probably already right now do something like
$entityNames = ("entity1","entity2")
foreach ($entity in $entityNames) {
    Set-BapEnvironmentVirtualEntity -Name $entity -EnvironmentId 00000000-00...
}

And we get some cool stuff out of the box it seems:
https://learn.microsoft.com/en-us/power-apps/developer/data-platform/org-service/execute-multiple-requests
https://learn.microsoft.com/en-us/power-apps/developer/data-platform/org-service/execute-multiple-requests#specify-run-time-execution-options
Both ContinueOnError and ReturnResponses seems like something that would make sense, when handling an array of entities.

And here we can learn how to load the DLL files and make it easier in the discovery phase of things. I suggest staying away from the DLL files, as I don't know if we are allow to redistribute these along with the module. So for now we can just use them, to map out how the raw data structure for the SOAP is - and do the implementation based on that.

https://github.com/Capgemini/powerapps-specflow-bindings/blob/15f32875846753be8fb25ed754157a3f475baf6a/scripts/Set-AllUserLocalesToUk.ps1#L37

About using the DLLs... I understand the reason to not use them, but I just checked another tool like xrmToolbox and they include them in their package. I'm also using a modified version of AXUtil.dll (which maybe is even worse than using the original DLL 🤣) for the ISVLicenseGenerator tool. I guess that as long as they're used on community-like tools MS is fine with that, but of course they can decide against that at-will.
I'll investigate the PowerShell module from the last comment!


Add optional argument to get_note_list() to specify number of notes to return

Hi mrtazz,
I've hundreds of notes stored in Simplenote and so retrieving a list of all notes can be a bit slow for me. More often than not I only want to list the most recent ones I've been working on. So I've been looking to modify simplenote.vim so I can say "just list the first 10 notes", i.e. :Simplenote -l 10.
I thought I'd start with simplenote.py and get some feedback from you if it's ok, before I look to implement in simplenote.vim.
How does this look to you? I'm not sure whether the qty=float("inf") is good practice or not (link). I have also had a go at adding two tests for this feature (all tests pass).

Thanks for the pull request, simplenote.py is definitely the right place for such an addition. It looks good on first glance. I'll take a closer look at it later and get back to you with more feedback.

Just to let you know I've implemented this in Simplenote.vim here:
https://github.com/i5m/simplenote.vim/commit/d5422b87b7b1d706089cbdccd7d82f96991b4f96
But I'll hold off a pull request until you've signed off on this one for Simplenote.py.

I finally found time to review this and merge it in. Thanks again.


lost blocks

I waited 7 days to create a block, it was created in red (575 block)
Four hours later, another block was created (588 block)
And initially it was green, they counted me an award of about 13k, but then someone took it away from me.

my nick: sazhiv#2581
my address: B62qnYByR7kvpk8SnkU7ajHvaWpMmyNdes3xCgr7AhujqeVZzjEM12H

Hi
On block height 599 my node generates a block. The block was green in the explorer and I was credited with 400 coins. An hour and a half later, the block turned out to be with another user and my coins were debited from the account, and the block turned red.
my nic: vadim888#0018
my address: B62qjATdfJ6Vo1SD4UnggshjJjTpcGhXmwxAAPhqY2KvYMADDXSmdng

Hi
On block height 599 my node generates a block. The block was green in the explorer and I was credited with 400 coins. An hour and a half later, the block turned out to be with another user and my coins were debited from the account, and the block turned red.
my nic: vadim888#0018
my address: B62qjATdfJ6Vo1SD4UnggshjJjTpcGhXmwxAAPhqY2KvYMADDXSmdng

Closing this issue as it is stale for a long time.


Autocomplete, Arrows etc. not working in Ubuntu Install Script Installation

For Bug Reports

Ubuntu 16.04 Installation Script

Expected Behavior
I want to use Tab for Autocomplete or Arrow Down/Up for Previous command.
Current Behavior
Not working - Tab just makes a tab.
Arrows just print "^[[A"
Steps to Reproduce
I am not really good in Linux - I thought it is a bash issue.  Also if I login I don't see the user in the shell just "$".
Tried to install:
sudo apt-get install bash-completion
But was already installed.
Tried to add to bash config:
# enable bash completion in interactive shells if ! shopt -oq posix; then   if [ -f /usr/share/bash-completion/bash_completion ]; then     . /usr/share/bash-completion/bash_completion   elif [ -f /etc/bash_completion ]; then     . /etc/bash_completion   fi fi

@sirup This is specific to Bash, not Bookstack.
I'm not sure what your end goal is though in using the tab completion? Can you give an example? You mentioned that you want to use the arrow keys and such but...
The script doesn't ask for anything aside from the domain name you want to have applied to the instance.

Hi @sirup, Since this is not a BookStack issue I will close this issue but I won't lock it so feel free to continue to comment.
There's some good advise above. Try following that; otherwise provide some more details such as how you're logging in to your Ubuntu machine.


HBASE-25815 RSGroupBasedLoadBalancer online status never updates after being set to true for the first time

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

 Thanks


revised SQL query returning next pool metadata to fetch

Issue Number

Overview

fccb250ff7628ad0d2a30f2aa36a4f35f542be1b
:round_pushpin: revised SQL query returning next pool metadata to fetch
There are two fundamentals change here:
a) This now does a LEFT JOIN on the fetch attempts table on BOTH the metadata_hash and
metadata_url. Before, we would discard metadata based solely on their metadata_hash. Now,
we select on the joined table directly and keep all pool metadata with either no fetch attempts,
or a fetch_after that is prior to the current datetime.
b) It now sorts the result based on their fetch_after date, the most "urgent" first. This is to cope
with the arbitrary batch limit of 100 pools and make sure that all metadata are eventually fetched.
Before, we could potentially retry fetching the same metadata over and over again until they expire.

Comments

@paweljakubas I am currently trying this out on my mainnet wallet, which has 524 unfetched pool metadata in it :s, including a lot of very recent pool metadata that are valid but are not being fetched because of other older metadata retrials still ongoing. I'll post an update in a bit.

bors try


Code Highlights Missing

Environment

node -v: 8.0.0

npm -v: 5.0.4

npm ls react-scripts (if you haven’t ejected): ?

Operating system: Windows 10

Steps to Reproduce
Install Jest plugin, run within project
Expected Behavior
Decorators should be applied to code
Actual Behavior
Plugin fails to show highlights for unit tests even though output runs correctly.
I've disabled all extensions in my work space (except Jest) and decorators are not showing.  Using VS Code 1.13.0.  There are no errors in the dev console.

This seems to work when testRegex is used and not testMatch

Good catch, I didn't know testMatch exists - the logic is here, you're welcome to add support 👍

@orta thanks for pointing me in the right direction. Ill give it a shot. No promises!


Node.js 8 functions are deprecated

Node.js 8 functions are deprecated and it has to be upgraded to minimum 10 or greater.
As stated by firebase documentation. Node.js 12 functions are more stable version also successful for this repository.

@oguzhnatly thank you!  This is a good change.

@oguzhnatly thank you!  This is a good change.


fix(metrics): ensure status_condition metrics reflect the status

ref: #471
This is an initial attempt at tackling #417, I've kept the logic fairly simple in
metrics.go.
It might be better off being implemented elsewhere. (in SetExternalSecretCondition
perhaps?)

➜ make reviewable
17:40:47 [ OK ] Finished generating deepcopy and crds
time="2022-01-21T16:40:48Z" level=info msg="Found Chart directories [.]"
time="2022-01-21T16:40:48Z" level=info msg="Generating README Documentation for chart /helm-docs"
17:40:48 [ OK ] Finished generating helm chart files
ERRO Running error: unknown linters: 'revive', run 'golangci-lint linters' to see the list of supported linters
golangci-lint failed: some checks can be fixed with `make fmt`
make: *** [Makefile:121: lint] Error 1

I don't know how to resolve this error, I have revive installed:
➜ revive -version
Current revive version dev commit none, built @unknown by unknown.

➜ pacman -Q revive
revive 1.1.2-1

Regarding make reviewable: Did you check that you have golangci-lint 1.42.x? It seems like you version is old before support for revive was added to golangci-lint.

/merge

@moolen Thank you for getting this merge. Is there a predefined release cadence for ESO? We're looking forward running this fix in our systems.

A release is overdue, we'll do one asap (probably this week)!

@Duologic we have released 0.4.1; If you're using OLM it may need a couple more days until the release available, there's an issue with the CI. FYI these are the PRs

https://github.com/k8s-operatorhub/community-operators/pull/696
https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/740


Little improvement: sort themes in selector by darkness

Please, divide themes by they backgrounds: dark or light. I never use bright code themes, some people never use a dark one.

great suggestion, thanks! (included in 0.9.0, rolling out)

Thank you.


Make it possible to build test artifacts

Is your feature request related to a problem? Please describe.
We are not able to catch problems in the build workflows until it's too late. Since our release process requires to cut a new release and the fact that we are distributed that'll adds tons of latency for getting a package out of the building.
Recent incidents:
https://github.com/elastic/apm-agent-python/pull/1990
https://github.com/elastic/apm-agent-python/pull/1993 and https://github.com/elastic/apm-agent-python/pull/1996
Describe the solution you'd like
I'd like to being able to run the release workflows pushing test packages / lambdas / you name it to test instances so we can check that the workflows are working.
Ideally this would be run every time we touch .github/workflows to catch dependabot regressions :)
The emphasis here is running the very same github workflows and not on publishing test artifacts.
Describe alternatives you've considered
None I can think of.
Additional context
In python we have a test package index (https://test.pypi.org/) where we can push things without bothering anyone.

I enabled the test.pypi as explained in https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-pypi


Discard post shortcut should always prompt user confirmation dialog

Currently if I press the discard post shortcut while composing a reply, the post is discarded immediately without prompting the confirmation dialog: "Are you sure you want to discard this post?" This may cause user frustration as the post is lost forever by accidentally pressing the shortcut.
If I typed something in the compose box, then blur the focus of the compose box by clicking outside of it, then press the shortcut it does prompt the confirmation dialog. It should prompt the dialog regardless whether the focus is in the compose box or not.

It actually just simulates a click on the discard button. Whether the dialog pops up is on the composers scope. It does not ask up to a few characters thought. This plugin should behave exactly like clicking "Discard" by hand.
Please check again whether clicking the discard button with similar composer content and changes does show the dialog. I'm not exactly sure about the conditions for that dialog to show up, it has something to do with key types and changes or content length thought.

Yes, clicking the discard button does show the dialog box.


topmost deprecate (first build after upgrade to v.6.2)

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI:  6.2
Cross-platform modules: 6.2
Android Runtime: 6.2
Plugin(s):
"@nstudio/nativescript-cardview": "^1.0.0",
"@nstudio/nativescript-snackbar": "^1.0.0",
"base-64": "^0.1.0",
"email-validator": "^2.0.4",
"guid-typescript": "^1.0.9",
"nativescript-angular": "~8.2.0",
"nativescript-iqkeyboardmanager": "^1.5.1",
"nativescript-plugin-firebase": "^10.0.1",
"nativescript-theme-core": "~1.0.6",
"nativescript-ui-listview": "^7.0.5",
"reflect-metadata": "~0.1.12",
"rxjs": "^6.4.0",
"sha1": "^1.1.1",
"tns-core-modules": "^6.2.0",
"underscore": "^1.9.1",
"utf8": "^3.0.0",
NativeScript-Angular: ~8.2
Angular: ~8.2

Describe the bug

After building the project on the 6.2 android emulator, a message appeared on console:

topmost() is deprecated. Use Frame.topmost() instead.
I do not use it (topmost) directly. There is a list (RadListView) on the page and scrolling does not occur. When you re-enter the page, everything is OK.

When building the release, a message appeared

ERROR in NativeScriptSnapshot. Snapshot generation failed!
Docker installation cannot be found. Install Docker and add it to your PATH in order to build snapshots.
Executing webpack failed with exit code 2.

I deleted the parameter --env.snapshot and managed to collect the release.
In previous versions, this was not.

Hi @Cheas,
Regarding the first issue topmost() is deprecated. Use Frame.topmost() instead. there is a new release of<EMAIL_ADDRESS>in which this usage is changed and the warning does not appear. Could you test with that version and log a new issue if there is anything not working with the scroll.
Regarding your second issue, I will transfer it to https://github.com/NativeScript/nativescript-cli/issues where it could be answered in detail.

Hi. elena-p.
Yes, I changed the package "nativescript-ui-listview": "^7.0.5" to "nativescript-ui-listview": "8.0.0", the message does not appear. Thanks for the help.

The problem disappeared after replacing the version Angular 8.2.0 to 8.2.13.


[$500] Chat – Green image appears in IOU as Admin when delete receipt as employee

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
In the workspace chat create a Manual request (i.e with no receipt)
Once created > navigate to the request conversation
Click on the three dot menu in the header > Add receipt
Select/take a picture
As admin view this IOU with a receipt.
When the manual expense has a receipt as employee attached delete it
As admin view this IOU

Expected Result:
Receipt is deleted from the request
Actual Result:
Green image appears in IOU as Admin when delete receipt as employee
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ce42471e-021a-4681-9dc9-0f3007ad36a6
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e9b3bfb36be58b04
Upwork Job ID:<PHONE_NUMBER>644609536
Last Price Increase: 2023-12-14

How can we test as an employee or as an admin?

Looking at this issues.  It looks like a default image has been used when uploaded images is null or other value.
I will carefully look into the codebase, look into the condition that is rendering this images, if a default is used upon deletion, I will remove this default image and display the normal Request card has appropriate only.
This will be my technical approach to this issue

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~011458797003438c4f

@samilabud

How can we test as an employee or as an admin?

You can create two test accounts, one will be the employee account and the other will be the admin. Create your test workspace under the admin account and invite the employee to it.

Closing as low priority


Make class, module, and struct definitions aware of numblock

This PR makes class, module, and struct definitions aware of numblock.

Looks good.
If this comes up a lot, we should consider supporting (gen_block ...) or something...

Released 1.11.0

Great! Thanks!


Web view issue on multiple Device resolution

I am using Google Pixel 3 my device resolution is 1080px × 2160 my web view buttons are cutting off as you can see in the picture it's working fine on the Portrait but having problems with Landscape.

@basitcubix Can you please check if it's resolved?


changes from matlab unfold

It is nice for maintenance & coding to keep the structure of unfold and jlunfold similar.
But while implementing some nice-to-have features, I noticed some things are unfortunate:

[ ] Cross validation of spline numbers is difficult, as the pipeline is modular, but the number of splines are changed in uf_designmat, but the cfg for uf_timeexpanddesignmat is currently not completly saved. This would also require that EEG.events is saved into EEG.unfold.events (not a biggy, but I didn't do it yet; I dislike it, as it doubles datastructures)
[ ] Different timewindows for different Events is currently not possible in matlab. The outcome would be, that I cannot reshape the EEG.unfold.beta to three dimensions, as the "time" dimension would be different for the different betas. Unsure how to procede here

Could be solved by some kind of lazy evaluation, i.e. generate Xdc only once you need it. This is suboptimal in my opinion, as it makes it less transparent & harder to check your EEG.unfold structure
not exactly sure. Some type of DataFrame could be useful, which directly encodes what predictor & channel we have there. Have to think about how later matrix products for contrasts etc. intervene here.

see #5 for a potential solution. The different ized basis functions might still be a problem though - but I think using tables with submatrices also fixes that (similar to unmixed in matlab)


MinecraftForge Ignore

Reasons for making this change:
Handy for Forge modding, since the Java one doesn't cover Gradle.
Links to documentation supporting these rule changes:
This file has been available in the Forge MDK for awhile, but many people forget to put it in their repositories.
Link to application or project’s homepage:

Repo
Website

Didn't see #1104, never mind.


Viewport

Fixed window resizing issues by using SFML's built-in functionality
Please use CluwneLib.Camera:

SetWorldView(): render the world, you can set which part of the world will be visible
SetInterfaceView(): render the UI
ViewSize: the bounds where you have to render the UI, this won't change on window resizing

New terminology to make things consistent:

Pixel Position: the pixel that was clicked physically, this is returned by the SFML MouseButton/MouseMove events
Window Position: coordinates in original window size (not resized), this is used by the UI
World Position: coordinates used by the gameplay

Graphics/MapUtil is just a temporary solution for replacing the remaining part of ClientWindow, the problem is that Services/Map/MapManager is not static, moreover TileSize is used all around the code, but MapManager can't be seen in every project because it would cause circular dependency

yus pls, merge this or I will commit shooter crime,


Safe decode uri component

As titled, see https://github.com/yoshuawuyts/wayfarer/issues/57 for discussion :)

Coverage increased (+0.09%) to 97.315% when pulling 87974ff0a51d2689cc9225c3a9fbe34aa8983450 on delvedor:safe-decodeURIComponent into 4e4bfd34afd06fce7e52ca0b11996291c2f7455d on yoshuawuyts:master.

v6.5.3


Add Favicon To The Website(Feature Request)

The current website, does not have any default Favicon. I can add this, if you'll assign this issue to me.

Hey @bhaveshgoyal182 !
Thanks for taking out the time to open this issue. I've assigned this to you, please go ahead and make a PR.
Goodluck! ✨

Thanks a Lot for the same!!

@ishandeveloper do check out #200 it might contain a possible solution for this problem and provide your reviews.


Add 'unparam' to Go linters

Which Issue(s) this Pull Request Fixes

Resolves #365
Release Note

NONE

Notes for Reviewers

I'll wait to #342 to merge this, I don't want to interfere with the work being done there.


Disable 'open with Code' on desktop context menu

Hi, can you add a setting or something to hide 'open with code' option from desktop context menu? it's a pretty neat feature but i don't think it's useful on desktop context menu.
P.S. this is my first ever feature request on github, so please don't ban/cancel me for this. thanks! :)

Assuming you are on Windows, I think you can use regedit and delete the HKEY_CLASSES_ROOT*\shell\VSCode key plus descendants. Do this at your own risk, and maybe export it first as a backup in case you change your mind.

thank you but i don't wanna completely disable it from all context menus. only from context menu on desktop :)

Then try removing HKEY_CLASSES_ROOT\Directory\Background\shell\VSCode

It kinda solved the problem, thanks. But it also removed that option from inside of other folders, not jus from desktop. right clicking on files or folders works fine 👍

The right fix is: Reinstall VS Code and choose the right options in the setup wizard.


Conversion and unit tests

This PR adds a rework of severity level management. Severity levels, including the level NONE that indicates a file/test without violations are now used in all returns. On the user side, this PR introduces the following changes:

A minimal conversion test that converts a yml to tsv file.
Tests are now run and required for PRs.
Add lint b003 that checks if all titles within the DatasetField block are unique.

Conversion of my stack of yml files works just fine with this branch.

Thank you!


Alternative to multiprocessing?

Having an issue using this on App Engine
ERROR    2015-03-16 21:37:06,549 wsgi.py:263]
Traceback (most recent call last):
 File "/Applications/GoogleAppEngineLauncher.app/Contents/Resources/GoogleAppEngine-default.bundle/Contents/Resources/google_appengine/google/appengine/runtime/wsgi.py", line 240, in Handle
   handler = _config_handle.add_wsgi_middleware(self._LoadHandler())
 File "/Applications/GoogleAppEngineLauncher.app/Contents/Resources/GoogleAppEngine-default.bundle/Contents/Resources/google_appengine/google/appengine/runtime/wsgi.py", line 299, in _LoadHandler
   handler, path, err = LoadObject(self._handler)
 File "/Applications/GoogleAppEngineLauncher.app/Contents/Resources/GoogleAppEngine-default.bundle/Contents/Resources/google_appengine/google/appengine/runtime/wsgi.py", line 85, in LoadObject
   obj = __import__(path[0])
 File "/Users/kevinchau/Dev/airfare/main.py", line 9, in <module>
   from firebase import firebase
 File "/Users/kevinchau/Dev/airfare/lib/firebase/__init__.py", line 3, in <module>
   from .async import process_pool
 File "/Users/kevinchau/Dev/airfare/lib/firebase/async.py", line 1, in <module>
   import multiprocessing
 File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/__init__.py", line 65, in <module>
   from multiprocessing.util import SUBDEBUG, SUBWARNING
 File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/util.py", line 40, in <module>
   from subprocess import _args_from_interpreter_flags
ImportError: cannot import name _args_from_interpreter_flags
INFO     2015-03-16 21:37:06,557 module.py:737] default: "GET /blast HTTP/1.1" 500 -

Is there an alternative to multiprocessing?

I'm having the same issue. Any answer?

Same issue here. It's surprising to see so few postings about the use of Firebase on Google Appengine on the internet.

@puruzio @kevinchau This library doesn't work in GAE and they still have no plans to do it. The best you can do is to create/reuse a simple wrapper around the REST api (for the methods you need). The library to generate the tokens works well.

If you are not using the async methods you can workaround the issue by disabling the multiprocessing (that's my case...).
class dummy:
    def close(self):
        pass
    def join(self):
        pass
    def terminate(self):
        pass

class DummyProccessing(ModuleType):
    def __init__(self):
        pass
    @staticmethod
    def Pool(processes):
        return dummy()

sys.modules['firebase.async.process_pool'] = dummy()
sys.modules['multiprocessing'] = DummyProccessing

from firebase import firebase


L2TP unable to adjust accepted ciphers

SE version. Any. Using latest builds to reproduce.
Operating system. Ubuntu 18.04 or centos7 and centos8.
Adjusting the algorithms used in the vpncmd or GUI for the ciphers has no effect on L2TP client.
Unable to disable ike aggressive mode.
Using ike-scan you can clearly identify that insecure ciphers allowing connections to the server. But also lacks ability to force main mode. This is a big security risk as a client could negotiate to use a broken cipher. There should most definitely be a flag to adjust these settings. If it's using the openswan or strongswan libraries, there's definitely the ability to set these parameters.
This security vulnerability for server/client connections should hopefully be an easy fix.
Can someone guide me on where to look to test adjusting this?
Why is this important?
MacOS is deprecated the support for the Tunnelblick so no more Openvpn. Using the built in client, l2tp is the best solution but need better control of ciphers.
L2TP is also greater performance than Openvpn due to running on kernel space vs user space.
Please let's fix this security vulnerability to remove or atleast select ciphers accepted by server.

The cipher selection is for TLS. L2TP does not use TLS.

L2TP does use ciphers. The IKE/IPSEC portion of L2TP handshake uses proposal sets. It's currently using/allowing very insecure ciphers/Proposals which should be an option to turn off/select proposals.
I've edited the source code and built my instances by removing the insecure cipher sets for OPENVPN and IKE/IPSEC proposals.
There needs to be an option to select the ciphers/proposals used.


clean up making user agent optional

Followup to #26 which missed a few things.

$ npx np patch

Warning: No files field specified in package.json nor is a .npmignore file present. Having one of those will prevent you from accidentally publishing development-specific files along with your package's source code to npm.

Publish a new version of replicate (current: 0.6.0)

Commits:
- clean up making user agent optional (#28)  b54f0f2
- Don't require user agent  ef03afa

Commit Range:
v0.6.0...main

Registry:
https://registry.npmjs.org/

  ✔ Prerequisite check
  ✔ Git
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

https://github.com/replicate/replicate-javascript/releases/tag/v0.6.1


freebsd: move net/if_mib.h contents to submodule

There is a conflict of NETLINK_GENERIC definitions between net/if_mib.h and netlink/netlink.h.  netlink.h is already exported in the crate root for Linux (and those definitions are already used by at least crates neli and netlink-packet-route), and if_mib is not much used yet, so this moves if_mib contents into its own namespace to leave place for netlink support on FreeBSD (rust-lang/libc#3201).
Looks like it is the first time namespacing is used in the libc crate, so I had to guess a few things, being quite new to this project.
The moved symbols did not appear in semver, so I just added the new ones.  grep.app from @GuillaumeGomez seems to be the only impacted public crate.

New revision completely drops the semver part -- will gladly use any hint to get it working and add it back.

To avoid the semver issue, the only way I see is to reexport items from the submodule by default.

To avoid the semver issue, the only way I see is to reexport items from the submodule by default.

That would avoid the breaking change, but that would not work for NETLINK_GENERIC, which this PR is all about.

Indeed. Let's see if libc's maintainers have another way to do it. But otherwise, I'm very fine with the breaking change. I'll just update libc in sysinfo and everything should be fine.

I'm baffled by the tests still trying to look at ifmib::* after I removed them from semver...

I'm baffled by the tests still trying to look at ifmib::* after I removed them from semver...

OK I realize they come from the generated tests. This part is essentially dedicated to ctest, and I don't see a way there to tell a header's contents live in a submodule.
Looks like for now we'll have to flag those definitions not to be checked.

Note also that private code might use these items. The libs-maintainers team has been considering making a new major release (0.3? 1.0? I'm not sure though) and I think it'd be better to include this change there. Let's wait for that release.

Note also that private code might use these items. The libs-maintainers team has been considering making a new major release (0.3? 1.0? I'm not sure though) and I think it'd be better to include this change there. Let's wait for that release.

How can we track that here, when the symbols moved were not included in semver to start with?  Is there a "list of breaking changes" somewhere to add this PR to for consideration?

:umbrella: The latest upstream changes (presumably #3341) made this pull request unmergeable. Please resolve the merge conflicts.

See https://github.com/rust-lang/libc/issues/3248, I've added this to the task list.

Rebased onto 0.2.151

What about adding a feature flag to libc?  An off-by-default "ifmib" feature would let crates like @ydirson's use the constants in their correct namespace, not conflicting with the new constant introduced by #3201 , while other crates won't see a change.  And libc could remove the feature flag when it does next make a major release.

As I understand it, such a flag would enable either ifmib of netlink, so for 0.2 it could make sense to let ifmib be the default, and rather add a netlink feature flag to disable it and enable netlink support?

Whatever it's named, the default option should be the status quo, and the alternative would be to put ifmib into a submodule.  BTW, I've seen other crates that call this "unstable".

I've seen other crates that call this "unstable".

That would seem a bit too generic here, we could just name it netlink.
However I see some moves on the 0.3 front, so should I proceed with this suggestion for 0.2?

rebased

:umbrella: The latest upstream changes (presumably #3587) made this pull request unmergeable. Please resolve the merge conflicts.

Could we just add a single NETLINK_GENERIC_IF_MIB?

Could we just add a single NETLINK_GENERIC_IF_MIB? Or are more conflicts expected?

All software using the if_mib.h version will miscompile and need to make a change to get the NETLINK_GENERIC they need.  My gut feeling is that anyone using that API is likely to use other consts (but I may be wrong), and the namespacing would prevent miscompilation if someone just casually tries to bump libc.  The change would be more fullproof if we forced attention by moving the ifmibdata type to the namespace as well.
But I would not object to a simpler change without namespacing if other parties more in contact with that API feel it's OK. @GuillaumeGomez do you think about any FreeBSD devs who would have informed opinion?
Note I just stumbled by chance (digging into sysinfo to check how that API is used there) against recently-merged #4022, adding the same if_mib,h API for apple, whose code would now need to be changed at the same time.

I don't know of any FreeBSD devs so I have no idea.

If the intent is that both netlink and if_mib are available and the user has to select one, then it makes sense to move either everything from if_mib to a separate module, possibly everything from netlink to its own module as well. If instead it is only a couple of variables that conflict then I don't think we need to move everything.
@asomers what is planned here? Based on your above comment

What about adding a feature flag to libc? An off-by-default "ifmib" feature would let crates like @ydirson's use the constants in their correct namespace, not conflicting with the new constant introduced by #3201 , while other crates won't see a change. And libc could remove the feature flag when it does next make a major release.

this makes it sound a bit like if_mib is intended to replace netlink at some point.

If the intent is that both netlink and if_mib are available and the user has to select one, then it makes sense to move either everything from if_mib to a separate module, possibly everything from netlink to its own module as well. If instead it is only a couple of variables that conflict then I don't think we need to move everything.
@asomers what is planned here? Based on your above comment

What about adding a feature flag to libc? An off-by-default "ifmib" feature would let crates like @ydirson's use the constants in their correct namespace, not conflicting with the new constant introduced by #3201 , while other crates won't see a change. And libc could remove the feature flag when it does next make a major release.

this makes it sound a bit like if_mib is intended to replace netlink at some point.

No.  If anything, more stuff is moving toward netlink.  But I definitely expect both to be used for a long time.  I don't see any solution that doesn't involve moving one thing or the other into a submodule.  Perhaps both.