KAFKA-16195: ignore metadata.log.dir failure in ZK mode

This change ensures we check that the broker is running in Kraft mode or is undergoing a migration while handling a failure for metadata.log.dir.
This avoids halting a broker in ZK mode when the metadata.log.dir fails. When unconfigured, it defaults to the first log directory.

CC: @cmccabe @showuon

I think the impact of this bug is that if there are more than 1 log dirs in ZK broker, and when the 1st of them is failed, we will shutdown the broker unexpectedly. But if there's only 1 log dir, it should be fine to shutdown the broker since no available online log dir. (just have a strange log saying Shutdown broker because the metadata log dir. Is my understanding correct?
If so, I think the change makes sense. Could you add tests for it?

That's correct. The case where all log directories fail is handled in logManager.handleLogDirFailure which is invoked on line 2588.
Will follow up with a test shortly.

@showuon added a test with commit https://github.com/apache/kafka/pull/15262/commits/d0858deb5500ebdec071bc06ca6f98726ae6f602. Please take a look

Tests Compilation is failing with
[2024-01-26T16:18:05.648Z] > Task :core:compileTestScala
[2024-01-26T16:18:05.648Z] [Error] /home/jenkins/jenkins-agent/712657a4/workspace/Kafka_kafka-pr_PR-15262/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:6410:23: Invalid literal number
[2024-01-26T16:18:06.555Z] [Error] /home/jenkins/jenkins-agent/712657a4/workspace/Kafka_kafka-pr_PR-15262/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:6413:5: ')' expected but '}' found.
[2024-01-26T16:18:07.582Z] two errors found
[2024-01-26T16:18:07.582Z]

Hey folks. We've seen a large increase in LogDirFailureTest after this PR. Can we take a look and see if something here caused it?
gradle enterprise: https://ge.apache.org/scans/tests?search.names=Git branch&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=America%2FLos_Angeles&search.values=trunk&tests.container=kafka.server.LogDirFailureTest
jira: https://issues.apache.org/jira/browse/KAFKA-16225

The issues started for 3.7 on the same day so it is one of the 3 commits backported feb 2
https://ge.apache.org/scans/tests?search.names=Git branch&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=America%2FLos_Angeles&search.values=3.7&tests.container=kafka.server.LogDirFailureTest

The issues started for 3.7 on the same day so it is one of the 3 commits backported feb 2 https://ge.apache.org/scans/tests?search.names=Git branch&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=America%2FLos_Angeles&search.values=3.7&tests.container=kafka.server.LogDirFailureTest

Hi @jolshan just introduced a fix here #15354


why did the development on this stop?

In the Readme it says

This project does not have any active maintainers. We recommend that you use nteract, a native notebook application

What is the reason for this? I very much like the idea of jupyter notebooks, but the lack of having a fully capable text editor has always annoyed me too much to use it. Now it seems that nteract is recommended, however nteract does not seem to differ too much from a browser based jupyter notebook except it's a desktop application.
There are two possibilities: a) I am not getting something here, and there are ways to use jupyter notebooks in text editors that I haven't found out yet. b) people are generally not so much depending on the tools and editing comfort of proper editors as I am.
I think a) is unlikely, I have googled around quite a bit, but I wish I would be wrong and somebody points me to an answer. I think b) is also unlikely, if I look at the deep complexity of emacs for example, people really seem to love their editors. Now what is happening in the field of python data analysis? Do people not care about editors there? Also unlikely.
I want to make the point, that a package promising the functionality as I can read it in this Readme (I have never used it, I started using atom at a point where it was already deprecated) can not be replaced by nteract, surely not by the current version of it. If nteracts plan is to grow to a full fledged text editor, wouldn't it be easier to try to implement notebook support into an existing one with a huge userbase? So what are the reasons for this development to stop, and start something (in my eyes) very different?
thanks for clarifications

Did you consider that the developers just have other things to do? :-)

developer time is of course a precious resource. But the way how I tried to frame my question was not "but why did you guys stop?", I rather wanted to say "I must not be getting something here" - because, devs don't seem to have stopped, but moved to something else. So time and talent is still spent, but one something very different, hence the "I must not be getting something here" component of my comment.

do you mean they've moved to some other project in the same area, and you wonder why the new project is needed rather than this one?


Add Test Utilities to support Facilities / Facility List

100% test coverage for listf, findf, clearf
Model can be used in tests relating to facilities as added set of default facilities in getTypicalAddressBook()
Facility list no longer instantiated with sample data. To be implemented in Storage portion

IMPORTANT
@felix-ong clearm now clears facility list as well because setAddressBook method will modify both facilityList and memberList

[ ] Fix clearm bug

Codecov Report

Merging #98 (0f49fe0) into master (952d6f4) will increase coverage by 1.47%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
+ Coverage     72.28%   73.76%   +1.47%
- Complexity      475      488      +13
============================================
  Files            85       85
  Lines          1411     1418       +7
  Branches        141      142       +1
============================================
+ Hits           1020     1046      +26
+ Misses          358      337      -21
- Partials         33       35       +2

Impacted Files
Coverage Δ

...edu/address/model/facility/UniqueFacilityList.java
78.57% <66.66%> (+8.57%)
:arrow_up:

src/main/java/seedu/address/model/AddressBook.java
93.93% <100.00%> (+7.27%)
:arrow_up:

.../java/seedu/address/model/util/SampleDataUtil.java
18.75% <0.00%> (-6.25%)
:arrow_down:

...in/java/seedu/address/model/facility/Facility.java
89.65% <0.00%> (+3.44%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
100.00% <0.00%> (+8.92%)
:arrow_up:

...el/facility/LocationContainsKeywordsPredicate.java
100.00% <0.00%> (+28.57%)
:arrow_up:

...du/address/logic/commands/FindFacilityCommand.java
100.00% <0.00%> (+44.44%)
:arrow_up:

...du/address/logic/commands/ListFacilityCommand.java
100.00% <0.00%> (+75.00%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952d6f4...0f49fe0. Read the comment docs.

Noted. Will edit clearm such that it only clears the member list. Just to clarify, what do you mean by "Tests for member methods still using AB3 Person attributes"? Are we removing certain attributes from Person instead of just adding more attributes such as availability to Person?

@YoYoCiti Noted. Will edit clearm such that it only clears the member list. Just to clarify, what do you mean by "Tests for member methods still using AB3 Person attributes"? Are we removing certain attributes from Person instead of just adding more attributes such as availability to Person? Or we are just using TypicalAddressBook to test instead of TypicalPersons?

Oops sorry, our user guide addm removed the attributes email, address, and tags so I thought we were removing those. But I guess we could keep those. Got to update the docs then. But yeah, now use TypicalAddressBook to test cause TypicalAddressBook will load the addressbook with both TypicalPersons and TypicalFacilities.

Oh I see, we did remove those attributes from the User Guide. Do you think it may be useful to keep those or will it be better to remove them? I can do all the availability attribute related tasks so that we do not need to wait for the other person to finish before proceeding.

LGTM. Will update ClearMembersCommand and ClearMembersCommandTest so that the member list can be cleared independently of the facility list.

Oh I see, we did remove those attributes from the User Guide. Do you think it may be useful to keep those or will it be better to remove them? I can do all the availability attribute related tasks so that we do not need to wait for the other person to finish before proceeding.

I guess only address is quite irrelevant. The rest can be kept


Making the auth endpoint relative to the given registry's domain

The realm, used in authenticating docker client to registry requests, doesn't rely on registry's config anymore and becomes constructed by the domain of the registry the client is talking to in a given request - relevant in DTR when the default config settings don't specify a domain name for the registry but we'd still like to authenticate requests to a known registry.
This is a part of a change that's also dependent on changes to docker client

I would generalize this issue as support for relative URLs in the www-authenticate realm field. As such the realm should be parsed and detected when a non-absolute URL is given and be able to create the full URL.
I might start by adding a section in the token documentation. This should specify exactly what the allowed return values for realm are and how each case will be handled. Example for "registry.example.com "/token" would get translated to "https://registry.example.com/token", "token" may get translated to "https://registry.example.com/v2/token" and "https://auth.example.com/token" would be used as is.
Since this is currently lacking a strict definition feel free to reach out to me or another distribution team member for what we might expect here.

Realms should not be assembled or resolved from external properties. We run the risk of creating a security hole. Authentication realms should be relatively static.
Looks like DTR is returning the incorrect realm to correctly authenticate. This bug needs to be fixed in DTR. This needs to be set in the auth section for a token. Arguably, the documentation needs to updated to be clear that this is actually the authentication host.


Only use Bugsnag when it is set in the Container

In some cases, exceptions can be thrown before Bugsnag is even registered with the IoC container. In these cases, the app will run into a fatal error when trying to use Bugsnag to notify it for errors. See #41 and #53. I've run into this a couple of times myself.
It's better to first check if the library is already registered with the container before trying to instantiate it.

+1 This PR does indeed fix the issue of receiving a fatal error when exceptions are thrown / errors occur before bugsnag has been registered in the container.

This looks good, thanks @driesvints!

Thank you for confirming the fix, @philbates35.

Thanks for merging :)

@kattrali Could you create a new tag with this fix please ?

Shipped 1.6.3! I apologize for the delay.

Hello!
New message, please read http://free-tatting.com/entirely.php?z6j4l
<EMAIL_ADDRESS>


For android, no DelegateEvent is not firing, and it does not show any ad as well

For android, no DelegateEvent is not firing, and it does not show any ad as well.
For IOS, it is working fine

+1
The same problem.

Any update on this issue?

try https://github.com/lilili87222/chartboost-ane-flash-air-android-ios

For anyone facing this issue, try going on your app's basic settings on the chartboost console and check both orientations - no matter if your app runs only in landscape or portrait.
It works for me! I don't know why but it works! (my bet is that it's related to the app orientation glitches that have been found in the newer versions of AIR).

@rubel Please contact our support team and reference this issue and me so we can resolve your issue.  In the mean time please try upgrading to the latest version.


S3 Key with unicode sequence U+0065 U+0301 cannot be accessed

Expected Behavior

Keys with the following unicode should be accessible via calls to GetObjectRequest or GetObjectMetadataRequest:
é  // U+0065 U+0301

Note that this is different from the normal way to express this character in unicode (U+00E9)
Current Behavior

When we construct a GetObjectRequest or GetObjectMetadataRequest and make a get call, we get a 404:
Amazon.S3.AmazonS3Exception : The specified key does not exist.
  ----> Amazon.Runtime.Internal.HttpErrorResponseException : The remote server returned an error: (404) Not Found.

Possible Solution

The SDK normally encodes unicode correctly.  It should handle this case gracefully.
Steps to Reproduce (for bugs)

Create a S3 object with a key that contains the unicode sequence U+0065 U+0301.  Attempt to access it via the SDK.
Context

Your Environment

AWSSDK.Core version used: <IP_ADDRESS>
Service assembly and version used:
Operating System and version: Windows 10 Pro, v 1703
Visual Studio version: 15.3.5
Targeted .NET platform: v4.5

I was able to create an S3 object with the keys: \u0065\u0301 and blep\u0065\u0301 and make GetObject and GetObjectMetadata requests.  Could you provide a sample code that repors the exception?

Looks like this may have been an error in our code.  I see correct SDK behavior in simple tests.  Apologies for the noise.


Update handleChange to dispatch immediately when passed a value (#108)

This patch:
• Updates a form's handleChange() prop to dispatch if passed both a field and value as stated in documentation. Related issue #108

Thanks for that. Oversight on my part. :+1:


Update concepts-identity.md

Additional privileges introduced in vSphere 7 release added for Content Library.

@suzizuber

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@jjaygbay1 - can you review this PR?


export_responses_by_token for anonymous surveys

Feature Type
Other
Description
Hi @edgarrmondragon,
i might have another use-case where im not sure how to implement it.
I want to export responses for specific tokens in an anonymous survey.
I tried client.session.export_responses_by_token
but i get the error that my survey (which can be called and stuff) does not have the field "token".
Reading the documentation from LS, i am not even sure what token i need to give the function (tokenID? the token to access the survey?)
I was wondering if my problem persists since its an anonymous survey and if you have any thoughts.
Best regards,
Matt

Hi @MatthiasGer0821!
It's probably not documented all to well but LimeSurvey only attaches a token (a.k.a. access code) to a response, and  creates the token column, if the responses are not anonymized and there's a participants table. If the survey is anonymous and has a participants table I think only whether the participant has responded is recorded, but no link between survey and participant is created.
>>> client.export_responses(411981, token="sgrw0BtXWbxA6Ws")
---------------------------------------------------------------------------
LimeSurveyApiError                        Traceback (most recent call last)
<ipython-input-15-15f0803c5896> in <module>
----> 1 client.export_responses(411981, token="sgrw0BtXWbxA6Ws")

~/edgar/citric/src/citric/client.py in export_responses(self, survey_id, token, file_format, language, completion_status, heading_type, response_type, from_response_id, to_response_id, fields)
    353         else:
    354             return base64.b64decode(
--> 355                 self.__session.export_responses_by_token(
    356                     survey_id,
    357                     enums.ResponsesExportFormat(file_format),

~/edgar/citric/src/citric/method.py in __call__(self, *params)
     42         some_method 1 a
     43         """
---> 44         return self.__caller(self.__name, *params)

~/edgar/citric/src/citric/session.py in rpc(self, method, *params)
     99         # Methods requiring authentication
    100         else:
--> 101             result = self._invoke(self._session, self.url, method, self.key, *params)
    102
    103         return result

~/edgar/citric/src/citric/session.py in _invoke(session, url, method, *params)
    150
    151         if error is not None:
--> 152             raise LimeSurveyApiError(error)
    153
    154         if response_id != request_id:

LimeSurveyApiError: Table "lime_survey_411981" does not have a column named "token".

Btw, you can also use citric's Client.export_responses(<sid>, token=...) to get non-anonymous responses 😉

Hi @edgarrmondragon,
thanks for your reply. Yes, the Client.export_responses(, token=...) request from citric works great for the non-anonmyous surveys I have.
But for the anonymous responses, I think i´m gonna check if by filtering for specific fields (with $aFields) I can check for specific answers. Background of my question is that i´m expecting to have a really large number of anonymous responses and i do not want to receive all of them every time i cal the export_responses function.
Best,
Matt

@MatthiasGer0821 Oh I see. So yeah, the only way to get specific responses is to use a range of response IDs, if you already know those IDs.
A workaround would be to export all response but only the fields you would like to filter by, store the response ID if a condition is true, and then iterate over response IDs to export all fields only for those responses:
import json
import citric

client = citric.Client(...)

sid = 542847
question_code = "Q00"
question_sgq_id = "542847X34X56"  # https://manual.limesurvey.org/SGQA_identifier

# Export only the response ID and answers for "Q00"
all_responses = client.export_responses(sid, fields=["id", question_sgq_id])
response_ids = []
for response in json.loads(all_responses)["responses"]:
    if response[question_code] == "<SOME VALUE>":
        response_ids.append(response["id"])

# Export all fields for a single ID each time
for rid in response_ids:
    single_id_resp = client.export_responses(sid, from_response_id=rid, to_response_id=rid)
    data = json.loads(single_id_resp)["responses"][0]
    print(data)


draft / experiment: remove popover to test effect on CI tests [DIR-639]

This is an experiment to see whether the changes solve a flaky test in the CI pipeline.
This removes a feature, so it is not supposed to be merged.
EDIT: The test are still flaky, so it seems the Popover was innocent.

Closing because this was a dead end. Better solutions have been found in https://github.com/direktiv/direktiv-ui/pull/415/


NUT-06 info endpoint version serialization wrong

Per NUT-06

version is the implementation name and the version of the software running on this mint separated with a slash "/",

The latest Moksha built from source serializes:
"version":"0.2.1-"

This could break a downstream client that tries to parse the field into two parts (program/version) by slash
References

https://github.com/cashubtc/nuts/blob/main/06.md

Nice catch. I wasn't aware of the constraints inside the version-string. This should be easy to fix.


in providers list, indicate correctly who is the automatically created provider

Issue:
When installing MTV + CNV on openshift, MTV automatically creates a provider pointing to local cluster (usually named "host")
This provider can not be deleted of edited because the operator will revert any changes.
Currently:
a. we do not mark this provider correctly in the providers list.
b. we do not enable/disable the delete/edit actions
Fix:
a. test for "owned provider"
b. change the label string from "default" to "owned"
c. fix the actions logic to enable/disable the action using the new test

Work in progress in https://github.com/kubev2v/forklift-console-plugin/pull/219

Fixed in https://github.com/kubev2v/forklift-console-plugin/pull/249


Update dependencies

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
https://github.com/istio/istio/issues/24473

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-notes_istio

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

lint_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test lint_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test release-test_istio

integ-galley-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
c63ddcd4a252cae17daeecd1a5fb08fb46d533c7
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
1388839731e2fd910f12946e17867aeb74f4b596
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It seems we have no alternative other than wait for https://github.com/istio/istio/pull/25677 to be merged.


chore(ci): generate .generated_ast_watch_list.yml

closes #4699
I also did some reordering to the code so it is easier to follow.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4737  👈
#4735
#4732
#4731
#4728
#4730
#4729
#4726
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

Not reviewed in full yet, but a couple of quick things:

Is there a reason for . on start of .generated_ast_watch_list.yml? Can it be just generated_ast_watch_list.yml?
Could you add a line break on end of the file?

1. Is there a reason for `.` on start of `.generated_ast_watch_list.yml`? Can it be just `generated_ast_watch_list.yml`?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better.
Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

2. Could you add a line break on end of the file?

Sure, I don't like the trailing newline but that's just me.

1. Is there a reason for `.` on start of `.generated_ast_watch_list.yml`? Can it be just `generated_ast_watch_list.yml`?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better. Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

OK cool.

2. Could you add a line break on end of the file?

Sure, ~I don't like the trailing newline but that's just me.~

It's a matter of taste, but it's the project's convention...


Fix libcxx for sim/macOS

Summary
Fix libcxx for sim/macOS
Some of fixes apply to Linux as well.
Impact
Testing
helloxx
cxxtest
with the new libcxxtest config.
on macOS and ubuntu.

@yamt please try https://github.com/xiaoxiang781216/incubator-nuttx/tree/cpp3
it can build and run on wsl.

@xiaoxiang781216 what's wsl?

@xiaoxiang781216 i tested the latest version of this PR on ubuntu as well.

@xiaoxiang781216 what's wsl?

The fast way run Ubuntu on Windows
https://docs.microsoft.com/en-us/windows/wsl/install-win10
but the real Ubuntu should work too.

@yamt could you reorg the PR to help review:

macOS specific fix
libcxx specific fix
nuttx fix

@xiaoxiang781216
i separated the easily separatable part: https://github.com/apache/incubator-nuttx/pull/2076

@xiaoxiang781216
i separated a few other things
https://github.com/apache/incubator-nuttx/pull/2110 a small build fix
https://github.com/apache/incubator-nuttx/pull/2111 non macos specific things

@yamt could you reorg this patch and https://github.com/apache/incubator-nuttx/pull/2111, https://github.com/apache/incubator-nuttx/pull/2114, https://github.com/apache/incubator-nuttx/pull/2064?

@xiaoxiang781216
i separated a few other things
#2110 a small build fix
#2111 non macos specific things

i guess i will come back to these cxx things once i finished printf format things.

@xiaoxiang781216 do you still have any concerns on this?

@xiaoxiang781216 do you still have any concerns on this?

@yamt, these two patches is too hack to support macOS:

sim: Postpone constructor calls after main on macOS
task_startup: Implement cxx_initialize for sim/macOS
Could you split other patches to new PR? then, we can merge them first. I want to try whether macOS has more simple method to  postone the constructor calling.

@yamt, these two patches is too hack to support macOS:

sim: Postpone constructor calls after main on macOS
task_startup: Implement cxx_initialize for sim/macOS
Could you split other patches to new PR? then, we can merge them first. I want to try whether macOS has more simple method to  postone the constructor calling.

@yamt, these two patches is too hack to support macOS:
1. sim: Postpone constructor calls after main on macOS

2. task_startup: Implement cxx_initialize for sim/macOS
   Could you split other patches to new PR? then, we can merge them first. I want to try whether macOS has more simple method to  postone the constructor calling.

done. https://github.com/apache/incubator-nuttx/pull/2678
i spent considerable time on the constructor issue and this was the simplest method i could find.
i hope you can come up with something better.

@yamt, these two patches is too hack to support macOS:
1. sim: Postpone constructor calls after main on macOS

2. task_startup: Implement cxx_initialize for sim/macOS
   Could you split other patches to new PR? then, we can merge them first. I want to try whether macOS has more simple method to  postone the constructor calling.

done. https://github.com/apache/incubator-nuttx/pull/2678
i spent considerable time on the constructor issue and this was the simplest method i could find.
i hope you can come up with something better.

@xiaoxiang781216 do you have any updates?

Not yet, but the keypoint for macOS/Linux is same: how to avoid the host startup code initialize NuttX's c++ constructor.
The approach selected on Linux is to rename the init section name in linker script on the fly, so we don't need make any special change to NuttX initializition code.
Your solution is modified the init section at runtime to bypass the host startup code, which require to patch the code inside NuttX.
If it's hard to modify the linker script on macOS, how about we instruct the linker rename the init section name? as far as I know, binutils tools support rename the section, and clang linker(https://lld.llvm.org/) claim it fully compatible with gnu linker, so it look  doable.

Not yet, but the keypoint for macOS/Linux is same: how to avoid the host startup code initialize NuttX's c++ constructor.
The approach selected on Linux is to rename the init section name in linker script on the fly, so we don't need make any special change to NuttX initializition code.
Your solution is modified the init section at runtime to bypass the host startup code, which require to patch the code inside NuttX.
If it's hard to modify the linker script on macOS, how about we instruct the linker rename the init section name? as far as I know, binutils tools support rename the section, and clang linker(https://lld.llvm.org/) claim it fully compatible with gnu linker, so it look doable.

as i explained earlier in this PR, it doesn't work as far as i know.

@xiaoxiang781216 how long should i wait?
as i said, i'm not entirely happy with this approach either.
but this is the best approach i was able to find.
how about accepting this for now, and revert it later if you, or i, or someone else find a better approach?

@yamt see my reply. Another approach is switch to our own entry point.

@yamt see my reply. Another approach is switch to our own entry point then all c++ initialization bypass automatically.

IIRC, the program entrypoint is invoked after ctors are executed on macOS.

@yamt see my reply. Another approach is switch to our own entry point then all c++ initialization bypass automatically.

IIRC, the program entrypoint is invoked after ctors are executed on macOS.

The entry point I talk here come from OS view, which is normally provided by libc implementation:
https://stackoverflow.com/questions/51109508/how-can-i-change-entry-point-for-a-mach-o-executable-for-a-c-file
https://stackoverflow.com/questions/24841283/how-can-i-set-a-custom-c-entry-point-with-clang-on-os-x-mavericks
start(libc)->main(nuttx)
c++ constructor is called iby start(libc), we can use -e option to let linker point to main(nuttx) directly.

@yamt see my reply. Another approach is switch to our own entry point then all c++ initialization bypass automatically.

IIRC, the program entrypoint is invoked after ctors are executed on macOS.

The entry point I talk here come from OS view, which is normally provided by libc implementation:
https://stackoverflow.com/questions/51109508/how-can-i-change-entry-point-for-a-mach-o-executable-for-a-c-file
https://stackoverflow.com/questions/24841283/how-can-i-set-a-custom-c-entry-point-with-clang-on-os-x-mavericks
start(libc)->main(nuttx)

c++ constructor is called iby start(libc), we can use -e option to let linker point to main(nuttx) directly.

are you sure about it? it doesn't match my experience.
i wrote a small program to demonstrate it. https://github.com/yamt/garbage/tree/master/macos/ctors
the output from the constructor was shown first on my environment.

@yamt I made a minor change, it work on Ubuntu now:
https://github.com/yamt/garbage/pull/1
Please try it.

c++ constructor is called iby start(libc), we can use -e option to let linker point to main(nuttx) directly.

are you sure about it? it doesn't match my experience.
i wrote a small program to demonstrate it. https://github.com/yamt/garbage/tree/master/macos/ctors
the output from the constructor was shown first on my environment.

@yamt I made a minor change, it work on Ubuntu now:
yamt/garbage#1
Please try it.

yes, on ubuntu it works that way. on macos it's different.
i made it build on both of linux and macos and i put a few results.
https://github.com/yamt/garbage/tree/master/macos/ctors/results

@xiaoxiang781216 can you revisit this when you have a chance? thank you.

I think we agree that Linux also swith to your solution, so please modify remove Linux specific stuff too.

i already made the change as i understand the discussion.
i guess i misunderstood what you meant. can you rephrase?

I mean that:

Remove sim Linux special support like this:

$(Q) $(CC) $(CCLINKFLAGS) -Wl,-verbose 2>&1 | \	     sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e 's/__init_array_start/_sinit/g' \	         -e 's/__init_array_end/_einit/g' -e 's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld	$(Q) echo "__init_array_start = .; __init_array_end = .; __fini_array_start = .; __fini_array_end = .;" >>nuttx.ld
2.Remove CONFIG_HOST_MACOS from your change, so both Linux and MacOS share the same code.

I mean that:
1. Remove sim Linux special support like this:

$(Q) $(CC) $(CCLINKFLAGS) -Wl,-verbose 2>&1 | \	     sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e 's/__init_array_start/_sinit/g' \	         -e 's/__init_array_end/_einit/g' -e 's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld	$(Q) echo "__init_array_start = .; __init_array_end = .; __fini_array_start = .; __fini_array_end = .;" >>nuttx.ld<!--

and what to do instead?
introduce another linux-specific way to suppress ctors execution like entrypoint replacement?

2.Remove CONFIG_HOST_MACOS from your change, so both Linux and MacOS share the same code.

i don't understand how it's possible given that they need to deal with different ways to find ctors.

I mean that:
1. Remove sim Linux special support like this:

$(Q) $(CC) $(CCLINKFLAGS) -Wl,-verbose 2>&1 | \	     sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e 's/__init_array_start/_sinit/g' \	         -e 's/__init_array_end/_einit/g' -e 's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld	$(Q) echo "__init_array_start = .; __init_array_end = .; __fini_array_start = .; __fini_array_end = .;" >>nuttx.ld<!--

and what to do instead?
introduce another linux-specific way to suppress ctors execution like entrypoint replacement?

No, use your macOS same approach.

2.Remove CONFIG_HOST_MACOS from your change, so both Linux and MacOS share the same code.

i don't understand how it's possible given that they need to deal with different ways to find ctors.

The main difference is the name of init section, the code can be reused after the section is located.

I mean that:
1. Remove sim Linux special support like this:

$(Q) $(CC) $(CCLINKFLAGS) -Wl,-verbose 2>&1 | \	     sed -e '/====/,/====/!d;//d' -e 's/__executable_start/_stext/g' -e 's/__init_array_start/_sinit/g' \	         -e 's/__init_array_end/_einit/g' -e 's/__fini_array_start/_sfini/g' -e 's/__fini_array_end/_efini/g' >nuttx.ld	$(Q) echo "__init_array_start = .; __init_array_end = .; __fini_array_start = .; __fini_array_end = .;" >>nuttx.ld<!--

and what to do instead?
introduce another linux-specific way to suppress ctors execution like entrypoint replacement?

No, use your macOS same approach.

on linux, the table seems to be mapped read-only.
thus the same approach doesn't work.

2.Remove CONFIG_HOST_MACOS from your change, so both Linux and MacOS share the same code.

i don't understand how it's possible given that they need to deal with different ways to find ctors.

The main difference is the name of init section, the code can be reused after the section is located.

the prototype of init functions is different as well. i suspect only little code can be shared.

@xiaoxiang781216 ping

@xiaoxiang781216 ping again

Ok, let's merge this until we find the better solution.

now this is ready to review (again)


fix(wetransfer-step):add icon

New Pull Request Checklist
Please mark the points which you did / accept.

[X] I read the Step Development Guideline
[ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[ ] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Hi, @kawaiseb
Thanks for the PR, we'll check it ASAP.

Hi @kawaiseb ,
please share your step icon's in separate pull requests and please fix your icons, by following this rules:

background color should not be transparent
icon size: 256px * 256px
margin size: 60px

Ok @godrei thanks.


Update proxy_info.py

Introduction
This PR introduces updates both to the format/fields of proxy_info.yaml and the implementation of proxy_info.py.
Changes

introduce new proxy_info format, add field enable_ota_proxy_cache, split local_server into ota_proxy_listen_addr and ota_proxy_listen_port.
refactor proxy_info.py
add test files for proxy_info
adjustment and fix according to the updates at the proxy_info.py

Behavior changes

perception ECUs don't require to enable ota-proxy any more, as all the files has been cached by the mainECU. When the perception ECU's ota update is interrupted, it can use the files cached by mainECU to recover the ota update.

proxy_info format change
Updated format
    """OTA-proxy configuration.

    NOTE: all the default values are for mainECU!
    Attributes:
        enable_local_ota_proxy: whether to launch a local ota_proxy server, default is True.
        gateway: (only valid when enable_local_ota_proxy==true) whether to enforce HTTPS when local ota_proxy
            sends out the requests, default is True.
        local_ota_proxy_enable_cache: enable cache mechanism on ota-proxy, default is True.
        local_ota_proxy_listen_addr: default is "<IP_ADDRESS>".
        local_ota_proxy_listen_port: default is 8082.
        upper_ota_proxy: the upper proxy used by local ota_proxy(proxy chain), default is None(no upper proxy).
    """

    enable_local_ota_proxy: bool = True
    gateway: bool = True
    # to be compatible with mainECU
    local_ota_proxy_enable_cache: bool = True
    upper_ota_proxy: str = None
    local_ota_proxy_listen_addr: str = server_cfg.OTA_PROXY_LISTEN_ADDRESS
    local_ota_proxy_listen_port: int = server_cfg.OTA_PROXY_LISTEN_PORT

New default proxy_info
For the case that proxy_info.yml doesn't exist(for mainECU):
"""yaml
enable_local_ota_proxy: true
gateway: true
local_ota_proxy_enable_cache: true
"""
Proxy_info template for perceptionECU
# for internal ecu that doesn't have direct internet connection,
# the following is the template configuration for it.
"""
# internal ecu is not the gateway for the local network.
gateway: false

# set to false if internal ECU doesn't have child ECU to serve.
enable_local_ota_proxy: false

# typically, we can only enable ota cache on the gateway ECU.
enable_local_ota_proxy_cache: false

# for internal ECU, upper_ota_proxy is required,
# internal ECU will use this proxy to request for ota update.
# upper ota proxy must be an HTTP URL.
upper_ota_proxy: <upper_ota_proxy_URL: str>

# the listen_addr of local_ota_proxy, if not presented, default to <IP_ADDRESS>:8082
local_ota_proxy_listen_addr: "<IP_ADDRESS>"
local_ota_proxy_listen_port: 8082
"""

I'd like to support the previous name enable_ota_proxy:. USB install image has this value.
From the specification point of view, enable_local_ota_proxy is OK and we don't need to specify the old name enable_ota_proxy.
Do you think can we support it?
After changing the vehicle setting, we can remove this support.

I'd like to support the previous name enable_ota_proxy:. USB install image has this value. From the specification point of view, enable_local_ota_proxy is OK and we don't need to specify the old name enable_ota_proxy. Do you think can we support it? After changing the vehicle setting, we can remove this support.

Do you mean support enable_ota_proxy as an alias of enable_local_ota_proxy, so that old configuration can be parsed correctly?

Compatibility to enable_ota_proxy is added in e750427.


Refactor transaction gas price limit estimating

Closes #2101

Estimate gas price and gas limit for all type of transactions
Estimation of gas price and gas limit for send transactions is now only done in 1 place (not done for TokenScript transactions as well as import ERC875 transactions yet)
Make sure that when the gas price and limit estimates are retrieved, it is only applied if the user hasn't set their own
Only provide gas limit estimate if it hasn't already been specified in the transaction (currently only dapp-initiated transactions optionally set this)

@James-Sangalli can you describe what you saw? It's (trying to) treat gas limit and price the same way.

Request for estimates
While waiting, user can override if they want to
When the estimates are retrieved, use them if the user has not overridden it
Users can still override

It would be clearer and less error prone than the original version. Let's see if we can fix it?

@James-Sangalli can you describe what you saw? It's (trying to) treat gas limit and price the same way.

Request for estimates
While waiting, user can override if they want to
When the estimates are retrieved, use them if the user has not overridden it
Users can still override

It would be clearer and less error prone than the original version. Let's see if we can fix it?

Sorry @hboon I should've clarified that I am referring to the gas limit defaulting to 100k, this is evidence that the gas limit is simply assigning the hardcoded value rather than getting the estimate

While waiting, user can override if they want to

Yeah, it happens because we are still waiting for the estimates. The limit (and similarly price) should change after a while though. Does it?
(Maybe it was faster previously because the estimate for ERC20 token sends were done earlier, we can address this too)

While waiting, user can override if they want to

Yeah, it happens because we are still waiting for the estimates. The limit (and similarly price) should change after a while though. Does it?
(Maybe it was faster previously because the estimate for ERC20 token sends were done earlier, we can address this too)

It flat out stays at the hardcoded value, doesn't update (vs before)

It flat out stays at the hardcoded value, doesn't update (vs before)

Fixed. Was a bug. Have also rebased master. Would you help check again?


Add logo

Travis CI is breaking because of a link issue for openservicebrokerapi.org
We should move the logo to here so we're not dependent on that site being up. Note that the logo URL won't work until this is merged.

@avade @angarg12 @shalako @pmorie @duglin

Should we close #309 in favor of this one?

@angarg12 I hadn't actually seen #309 ! Sorry!
Up to you. I'd probably vote to add the logo to the repo, but I'm not overly fussed.

Don't care which we point to.
LGTM

LGTM

lgtm

LGTM


Object Detector should use new SFrame shuffle method if possible

It's only possible to use the new shuffle method if the user does not specify a seed parameter. We should also benchmark this change to ensure that it is indeed quicker for reasonably large datasets.

As mentioned in #3178, the Object Detector creates a seed parameter even when the user does not specify one. The shuffle method for SFrame/SArray does not accept a seed parameter. Until shuffle accepts a seed parameter, we can no use it in object detection.
We are tracking adding a seed parameter to shuffle in #3187.


add back button #9953

Issue Reference
add back button #9953

Checked and found that the back button has been added. Please check the video for reference.
Video
https://github.com/bagisto/bagisto/assets/92721837/907a7675-da58-4e20-b58e-0052f123c321


Feature Request: Modbus TCP Read with slaveid

TCP client read only slaveid=0, are there any solution read other slaves?
Thanks.

I see in readme, sorry.


Fix typo in documentation

Summary of the changes (Less than 80 chars)

Detail 1
Detail 2

Closes #bugnumber (in this specific format)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@simplicbe can you please sign the CLA?

Closing the PR since CLA was not signed.


metadata reuse

the hard part is to generate metadata of art object. Possibilities include use another art object's metadata as a template or create description and tag banks

built on top of search:
created metadata search that returns matching metadata used before
implemented tap on selection to copy to clipboard.


use correct variable for raid parameter in call to getrequestprintout

Exactly! The guy from DFN just told me that and I tried it and it works for the testing=false, for testing=true still get
Traceback (most recent call last):
  File "/home/xemacs/.local/bin/dfnclient", line 11, in <module>
    sys.exit(cli())
  File "/home/xemacs/.local/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/xemacs/.local/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/xemacs/.local/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/xemacs/.local/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/xemacs/.local/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/xemacs/.local/lib/python3.6/site-packages/dfngen/dfnclient.py", line 73, in create_cert
    soap.submit_request(req, **conf)
  File "/home/xemacs/.local/lib/python3.6/site-packages/dfngen/soap.py", line 28, in submit_request
    Publish=True,  # publish cert
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/client.py", line 559, in __call__
    return client.invoke(args, kwargs)
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/client.py", line 618, in invoke
    result = self.send(soapenv)
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/client.py", line 658, in send
    result = self.succeeded(binding, reply.message)
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/client.py", line 696, in succeeded
    reply, result = binding.get_reply(self.method, reply)
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/bindings/binding.py", line 152, in get_reply
    self.detect_fault(soapbody)
  File "/home/xemacs/.local/lib/python3.6/site-packages/suds/bindings/binding.py", line 183, in detect_fault
    raise WebFault(p, fault)
suds.WebFault: b"Server raised fault: 'Unbekannte RA_ID'"

Thanks for that fix


Two six-digit numbers got outputted randomly

Checklist

[X] I'm asking a question
[X] I've looked through the README and FAQ for similar questions
[X] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
I was downloading some music and yt-dl out putted this:

[1] 523123
[2] 523124

Are these magic numbers or are these error numbers?
The input and output:
void@thevoid:~/Desktop/Muzik$ audio -o "The Living Tombstone - What I Want.%(ext)s" https://www.youtube.com/watch?v=Bhaot-BchF8&list=TLPQMDUxMDIwMjA1qSoztYyoXA&index=3
[1] 523123
[2] 523124
void@thevoid:~/Desktop/Muzik$ [youtube] Bhaot-BchF8: Downloading webpage
[youtube] Downloading just video Bhaot-BchF8 because of --no-playlist
[youtube] Bhaot-BchF8: Downloading embed webpage
[download] Destination: The Living Tombstone - What I Want.webm
[download] 100% of 3.11MiB in 00:00
[ffmpeg] Destination: The Living Tombstone - What I Want.mp3
Deleting original file The Living Tombstone - What I Want.webm (pass -k to keep)

https://github.com/ytdl-org/youtube-dl#video-url-contains-an-ampersand-and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command


Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying.

General troubleshooting tips
Before logging an issue please check that:

[x] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[x] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[x] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.
Required information
In order to help us sort your issue, we ask that you provide the following information:

[x] Mac model: Macbook Pro M1 (2020)
[x] macOS version: Sonoma 14
[x] Monitor setup: Don't have a monitor

If appropriate, please enable Debug mode and Log to disk in Advanced tab and replicate your bug, then attach the AerialLog.txt file (You can access this file through the Advanced tab).
Description of issue / Feature request: Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time.
{{Replace this}}

Hey @greylogan
Not sure I understand, can you expand a bit ? You close your laptop but you don't have external monitors ? What do you need to restart ? Are you talking about the desktop background or the saver ?

Thank you for your response. When I close the lid and then open it later on to resume working on the laptop, Arial has closed itself and the live wallpaper under Experimental has stopped completely. I would really like it if it would continue like the previous version. The new update seems to have caused Arial to force close upon closing the lid, which closes using the screensaver as a live wallpaper as well.

From: Guillaume Louel @.>
Sent: Monday, October 2, 2023 22:30
To: JohnCoates/Aerial @.>
Cc: greylogan @.>; Mention @.>
Subject: Re: [JohnCoates/Aerial] Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying. (Issue #1331)
Hey @greyloganhttps://github.com/greylogan
Not sure I understand, can you expand a bit ? You close your laptop but you don't have external monitors ? What do you need to restart ? Are you talking about the desktop background or the saver ?
—
Reply to this email directly, view it on GitHubhttps://github.com/JohnCoates/Aerial/issues/1331#issuecomment-1743238640, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC7EZABBWELVNVZ6J3AVX5TX5LM2VAVCNFSM6AAAAAA5OZQT3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGIZTQNRUGA.
You are receiving this because you were mentioned.Message ID: @.***>

Ok so, this is a Sonoma thing that I may not have accounted for. However, you should not use that old version of Companion (the menu bar thing), please use this version for Sonoma, and use the desktop from there (2nd option), see if it still does it when you close the lid. I dont have a laptop to test but it's fine if my MacStudio goes to sleep ,so that should be about the same.
https://github.com/AerialScreensaver/AerialCompanion/releases/tag/v1.5.1

Hi. I installed the Sonoma version and for some reason it is doing the same thing as the 3.3.1 version. It force closes and does not stay open upon closing the laptop and opening it up again. I have to restart it every time.
On Oct 3, 2023 at 06:08 +0700, Guillaume Louel @.***>, wrote:

Ok so, this is a Sonoma thing that I may not have accounted for. However, you should not use that old version of Companion (the menu bar thing), please use this version for Sonoma, and use the desktop from there (2nd option), see if it still does it when you close the lid. I dont have a laptop to test but it's fine if my MacStudio goes to sleep ,so that should be about the same.
https://github.com/AerialScreensaver/AerialCompanion/releases/tag/v1.5.1
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks for the feedback, I'll try to see if I can simulate something here to replicate and will keep you posted. I assume that if you let you mac fall asleep with the lid on, it's fine though.
Will let you know if I can find a workaround

Also, can you give me the exact steps you do ? Is the screen saver (not the desktop thing) running when you close the lid ? etc etc
Thanks, that would help me narrow it down.

Basically I will close the lid and travel somewhere like home. Then I will open the Macbook and notice the icon is no longer at the top of the task bar.
Ok I just received dialogue for the first time telling me how to choose Arial as my screensaver. I never noticed this before when I clicked the button within the Arial app in the task bar. I will see if this fixes the issue. It should be set to Arial and not the default Apple screensaver, but I am not sure that will fix the issue using the screensaver as a live desktop. I will see if it stays active.
On Oct 3, 2023 at 19:05 +0700, Guillaume Louel @.***>, wrote:

Also, can you give me the exact steps you do ? Is the screen saver (not the desktop thing) running when you close the lid ? etc etc
Thanks, that would help me narrow it down.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

I see, you weren't running the screensaver but maybe Apple's one. All in all you can use anything you want and use the Companion's desktop independently, but it's really confusing right now with the way Apple presents their stuff.
What I'm asking specifically is when you close the lid. Is your mac running with apps and stuf in the foreground or was (any) screensaver running ?

I found a way to reproduce the issue, I'll keep you posted!

@greylogan found the issue, this is fixed in 3.3.2 https://github.com/JohnCoates/Aerial/releases/tag/v3.3.2
To update using Companion, if you don't see it when you open the app, you can go into settings (second icon at the bottom) and press "Check now" in the window that opens.
After update, you have to close Companion and restart it so the new version gets loaded properly. Please let me know if that fixes things for you but I'm pretty sure it should.

You can't do attachements by email, you have to do them on GitHub. But I'm pretty sure it's the new sandboxing prompt saying that Aerial needs access to other applications data.
This is an unfortunate new thing that Apple added in Sonoma, the fix is simple though, see this screenshot :

You have to explicitly grant Aerial full disk access.
This happens because I distribute 2 bits of software, the first one is Aerial (the screensaver), and the second is Aerial Companion, which is the auto updater and the part that lets you run the desktop background. In order to make the desktop background work, what Aerial Companion does is it loads Aerial (the screensaver), and that triggers this prompt.
In a perfect world, because I distribute both bits together, it shouldn't trigger anything, but because Apple still hasn't released a new SDK for screensavers, they don't, and we get this prompt. It's super annoying but I can't do much about it.
You may have the same issues with text editors or other apps that need to open files, full disk access is the only workaround for now.

Thank you. When I get home, I'll implement this fix. Yeah, Apple makes it hard to do anything.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Guillaume Louel @.>
Sent: Wednesday, October 4, 2023 6:33:27 PM
To: JohnCoates/Aerial @.>
Cc: greylogan @.>; Mention @.>
Subject: Re: [JohnCoates/Aerial] Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying. (Issue #1331)
You can't do attachements by email, you have to do them on GitHub. But I'm pretty sure it's the new sandboxing prompt saying that Aerial needs access to other applications data.
This is an unfortunate new thing that Apple added in Sonoma, the fix is simple though, see this screenshot :
[Capture d’écran 2023-10-04 à 13 26 02]https://user-images.githubusercontent.com/37544189/272558483-ee7ea14e-a657-43ab-a211-87f272fab704.jpg
You have to explicitly grant Aerial full disk access.
This happens because I distribute 2 bits of software, the first one is Aerial (the screensaver), and the second is Aerial Companion, which is the auto updater and the part that lets you run the desktop background. In order to make the desktop background work, what Aerial Companion does is it loads Aerial (the screensaver), and that triggers this prompt.
In a perfect world, because I distribute both bits together, it shouldn't trigger anything, but because Apple still hasn't released a new SDK for screensavers, they don't, and we get this prompt. It's super annoying but I can't do much about it.
You may have the same issues with text editors or other apps that need to open files, full disk access is the only workaround for now.
—
Reply to this email directly, view it on GitHubhttps://github.com/JohnCoates/Aerial/issues/1331#issuecomment-1746690255, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC7EZAESF3Q5354Z4ZVBVVDX5VCQPAVCNFSM6AAAAAA5OZQT3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWGY4TAMRVGU.
You are receiving this because you were mentioned.Message ID: @.***>

After having both 3.3.2 and having restarted it, it should no longer prompt quit on your though, make sure it's properly running. You can check in settings that you have the correct version installed.

OK will do. Also, I don't have 3.3.2 any longer. I deleted that and installed the Sonoma you shared a link to.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Guillaume Louel @.>
Sent: Wednesday, October 4, 2023 7:56:09 PM
To: JohnCoates/Aerial @.>
Cc: greylogan @.>; Mention @.>
Subject: Re: [JohnCoates/Aerial] Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying. (Issue #1331)
One last thing, if you still experience the issue after that, instead of closing the lid, try going to the Apple menu top left and select sleep there, then wake it up, see if it still quits on you or not. This is how I simulate the lid closing on my MacStudio here and it now works fine.
—
Reply to this email directly, view it on GitHubhttps://github.com/JohnCoates/Aerial/issues/1331#issuecomment-1746824326, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC7EZAEQPVEW73AO3VNJPT3X5VMGTAVCNFSM6AAAAAA5OZQT3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWHAZDIMZSGY.
You are receiving this because you were mentioned.Message ID: @.***>

Let me recap because it's confusing, first you need Aerial Companion 1.5.1, this is the thing on your menu bar, see the screenshot (again, come to github to see them)  :

In here, if you press the cog icon top right, it will load the screen saver settings, if you go to the bottom it should show 3.3.2 (which is the screensaver version) :

If you have those things aligned, then you should no longer see the quit thing.

OK. I'll check when I get home and fix the Apple settings
Get Outlook for iOShttps://aka.ms/o0ukef

From: Guillaume Louel @.>
Sent: Wednesday, October 4, 2023 8:05:49 PM
To: JohnCoates/Aerial @.>
Cc: greylogan @.>; Mention @.>
Subject: Re: [JohnCoates/Aerial] Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying. (Issue #1331)
Let me recap because it's confusing, first you need Aerial Companion 1.5.1, this is the thing on your menu bar, see the screenshot (again, come to github to see them) :
[Capture d’écran 2023-10-04 à 15 02 51]https://user-images.githubusercontent.com/37544189/272582485-c9712f0a-7adb-4760-9be9-3bbae00ac934.jpg
In here, if you press the cog icon top right, it will load the screen saver settings, if you go to the bottom it should show 3.3.2 (which is the screensaver version) :
[Capture d’écran 2023-10-04 à 15 04 15]https://user-images.githubusercontent.com/37544189/272582809-40c47ac9-1bc5-49c2-85c6-d15b66ba145c.jpg
If you have those things aligned, then you should no longer see the quit thing.
—
Reply to this email directly, view it on GitHubhttps://github.com/JohnCoates/Aerial/issues/1331#issuecomment-1746840688, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC7EZAE3VSGYDZ7TRM5MDILX5VNK3AVCNFSM6AAAAAA5OZQT3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWHA2DANRYHA.
You are receiving this because you were mentioned.Message ID: @.***>

I was wondering what screen this is. It's in French or something I can read it.
On Oct 4, 2023 at 19:52 +0700, Grey Haven @.***>, wrote:

Thank you. When I get home, I'll implement this fix. Yeah, Apple makes it hard to do anything.
Get Outlook for iOS
From: Guillaume Louel @.>
Sent: Wednesday, October 4, 2023 6:33:27 PM
To: JohnCoates/Aerial @.>
Cc: greylogan @.>; Mention @.>
Subject: Re: [JohnCoates/Aerial] Ariel, after 3.3.1, does not remain running when laptop is closed. Have to restart it every time. Pretty annoying. (Issue #1331)
You can't do attachements by email, you have to do them on GitHub. But I'm pretty sure it's the new sandboxing prompt saying that Aerial needs access to other applications data.
This is an unfortunate new thing that Apple added in Sonoma, the fix is simple though, see this screenshot :
You have to explicitly grant Aerial full disk access.
This happens because I distribute 2 bits of software, the first one is Aerial (the screensaver), and the second is Aerial Companion, which is the auto updater and the part that lets you run the desktop background. In order to make the desktop background work, what Aerial Companion does is it loads Aerial (the screensaver), and that triggers this prompt.
In a perfect world, because I distribute both bits together, it shouldn't trigger anything, but because Apple still hasn't released a new SDK for screensavers, they don't, and we get this prompt. It's super annoying but I can't do much about it.
You may have the same issues with text editors or other apps that need to open files, full disk access is the only workaround for now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Yes sorry, I happen to be french ;) Look for "Full disk access" in settings, you'll find it.

Got it. And the funny thing is, before I even turned it on, I opened the lid and it was running! And I didn't get the pop up this time. So maybe it corrected itself? Either way, I granted full disk access so maybe Apple won't throw a tantrum anymore lol
On Oct 4, 2023 at 21:01 +0700, Guillaume Louel @.***>, wrote:

Yes sorry, I happen to be french ;) Look for "Full disk access" in settings, you'll find it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Fix for uncentered BoundingBoxes

Supposedly fixes #2
This commit changes the algorithm to not rely on mirrored coordinates, instead calculating left and bottom from the BoundingBox and checking for coordinates to be in range bottom <= y <= top and left <= x <= right. I chose not to rely on un-shift -> voronoi -> re-shift, since this could cause confusion for users.

The new output looks okay at first glance, but the BoundingBox Corners (e.g. top-left Voronoi-Diagram, upper right corner) are still a little broken. Haven't figured out why, yet.

Benchmark Comparison "large_input_benchmark":

100.000
1.000.000
5.000.000
10.000.000

Fix
28.814 ms
412.98 ms
2.4891 s
5.3512 s

Master
29.228 ms
418.78 ms
2.4628 s
5.3161 s

After some testing, the broken corner cells were already present in the master-branch.
So this PR "could" be seen as ready to merge.
I'll try to fix the corners over the weekend

After some testing, the broken corner cells were already present in the master-branch.
So this PR "could" be seen as ready to merge.
I'll try to fix the corners over the weekend

Opened new issue #4 for the corner-problem, as it is not related with any of the changes made here

Opened new issue #4 for the corner-problem, as it is not related with any of the changes made here

@Telzhaak - thanks for the PR and reporting the issues! I started taking a look at the code and looks good.
Thanks for adding the benchmark results, I was curious on that - but looks like no measurable to minimal impact.

@Telzhaak - thanks for the PR and reporting the issues! I started taking a look at the code and looks good.
Thanks for adding the benchmark results, I was curious on that - but looks like no measurable to minimal impact.

Short update: I added a UnitTest for the BOundingBox, but noticed that one of my changes results in a previously fine Unittest to fail:
---- cell_builder::test::extend_and_close_hull_test stdout ----
thread 'cell_builder::test::extend_and_close_hull_test' panicked at 'assertion failed: `(left == right)`
  left: `[32.75, -15.5]`,
 right: `[7.905417527999327, -3.0777087639996634]`:
Invalid vertex for position 1. Expected cell vertices [
    [0.5, 0.625],
    [32.75, -15.5],
    [0.5, 33],
], found [
    [0.5, 0.625],
    [7.905417527999327, -3.0777087639996634],
    [0.5, 9],
]. First cell', src\cell_builder.rs:513:13

I'm currently investigating the reason for that

Short update: I added a UnitTest for the BOundingBox, but noticed that one of my changes results in a previously fine Unittest to fail:
---- cell_builder::test::extend_and_close_hull_test stdout ----
thread 'cell_builder::test::extend_and_close_hull_test' panicked at 'assertion failed: `(left == right)`
  left: `[32.75, -15.5]`,
 right: `[7.905417527999327, -3.0777087639996634]`:
Invalid vertex for position 1. Expected cell vertices [
    [0.5, 0.625],
    [32.75, -15.5],
    [0.5, 33],
], found [
    [0.5, 0.625],
    [7.905417527999327, -3.0777087639996634],
    [0.5, 9],
]. First cell', src\cell_builder.rs:513:13

I'm currently investigating the reason for that

Sry, I'm currently busy moving, and I forgot to get back at this.
It is indeed due to the expected values being outdated.
Normalizing the orthogonal, and changing the scale factor to be the more easily computed as width+height of course changes where the extended vertices end up
Due to these changes, it is also very very difficult to find "pretty" numbers for tests.
I changed the tested triangle to be
(-0.5,  1.0)
(-1.5, -1.0)
( 0.5, -1.0)

According to my hand-math:
circumcenter c = (-0.5, -0.25)
new scale = width + height = 4 + 4 = 8
angles with +x-axis as reference
e1angle = 270° - atan(-1/-2) = 243.435°
e2angle = 0°
e3angle = 180° - atan(2/1) = 116.565°

The following vertices represent a rough estimate of where the extended vertice should end up
Instead of extending the half-edge-intersection point, the circumcenter is extended:
exv1.x = c.x + scale * cos(e1angle - 90°) = -0.5 + 8. * cos(153.435°) = -7.655
exv1.y = c.y + scale * sin(e1angle - 90°) = -0.25 + 8. * sin(153.453°) = 3.328

exv2.x = c.x + scale * cos(e2angle - 90°) = -0.5 + 8. * cos(-90°) = -0.5
exv2.y = c.y + scale * sin(e2angle - 90°) = -0.25 + 8. * sin(-90°) = -8.25

exv3.x = c.x + scale * cos(e3angle - 90°) = -0.5 + 8. * cos(26.565°) = 6.655
exv3.y = c.y + scale * sin(e3angle - 90°) = -0.25 + 8. * sin(26.565°) = 3.328

The following vertices are calculated by the code:

(7.865633420552356, 2.8089875327071336)
(8.155417527999326, 3.5777087639996634)
(0, -9) <-
The proximity of each calculated point to its hand-estimated position is an indicator, that the expected test-values are correct. This is confirmed by the third point, whose mid-edge intersection point is trivial to find at (-0.5, -1.0). Extending this by scale in -90°-direction leads to exactly this value.

Thus, this PR finished its scope and can be merged


config for lang selector

Code is very good and efficient.
I've found small errors :
- the placeholder is never removed on the search input
-  missing a `cursor:pointer;` on lang links when the lang is not selected.
-  use a different css for the link of the selected language

should be ready for squash and merge now

It works perfectly !!! squash and merge.

Thanks @oterral @pfanguin


FileError { code: 5 } on $cordovaFile.writeFileon iOS

var $cordovaFile = $injector.get('$cordovaFile')

var filePath = $window.cordova.file.dataDirectory + 'test.html'
var fileContent = new Blob(['<html>HELLO WORLD</html>'], { type : 'text/html' })
var options = {}

$cordovaFile.writeFile(filePath, fileContent, options).then(function (result) {
  console.log(result)
}, function (err) {
  console.error(err) // FileError { code: 5 }
})

Monkey patching as Zenconomy described and relative paths don't seem to be working for me. I'm on beta-14.

@panchisco we completely stopped using ngCordova for anything related to the file system as there are several serious bugs and limitations in their implementation.
Instead we're just using the native cordova commands, I recommend you do the same... it will save you a lot of pain and frustration.

Now why didn't I think of that, instead of spending many hours trying to find/fix this problem.
Saw quite a few people having similar problems on issues here or stackoverflow. Reverting back to beta 13 and everything works better for now. Likely I'll go backt o 14 but use native cordova apis.

Recent refactoring of $cordovaFile resolved the issue that's described here. The original problem was that a file system was requested with storage type "1", while for Library/NoCloud that should've been "4". Now the requestFileSystem method isn't used any longer which resolves this issue.
Unfortunately these changes haven't been released for usage with Bower, but you can use it in your app already. Just include ngCordova like this in Bower:
{
  "dependencies": {
    "ngCordova": "driftyco/ng-cordova#b5e612d109a90afa7edcbaf63406a41b9912eba6"
  }
}

Also make sure that the extra file systems get included by adding the following to config.xml:
  <preference name="iosExtraFilesystems" value="library,library-nosync,documents,documents-nosync,cache,bundle,root"/>

Then use the methods of $cordovaFile as described in the docs, for instance:
$cordovaFile.checkFile(window.cordova.file.dataDirectory, 'file.ext').then(function() {
  ...
});

I've only tested this with the latest version of the cordoba-file-plugin, so just to be sure you could remove and add it:
cordova plugin remove org.apache.cordova.file
cordova plugin add org.apache.cordova.file

I have the same issue with writeFile on android. Download works OK, but I can't write simple text file, I always get error code 5

I am not even able to use the core $cordovaFile functions.
Can u help
Thanks in advance
<EMAIL_ADDRESS>

Hi is there any progress on this?  I'm have the same exact problem with $cordovaFile.moveFile resulting in an Error Code 5.  { code : 5}
I'm using ng-cordova  0.1.17-alpha

I monkey patched or rather, modified ng-cordova.js using some of the info above.
Works for me, I still need to upgrade Ionic and hope these issues were resolved.
Inside getFilesystem():
var initFs = function(fn, errFn) {
var size = 0;
//var size = 1024 * 1024;
var x = $window.PERSISTENT;
if(device.platform == 'Android') {
//x = 2;
$window.requestFileSystem(x, size, fn, errFn); // android
} else if(device.platform == 'iOS') {
x = 3; // works.
/*
* https://stackoverflow.com/questions/26151731/cordova-phonegap-ios-filesystem-custom-root-path-iosextrafilesystems-is-not
* https://github.com/apache/cordova-plugin-file/pull/82
* https://github.com/wei-lee/dotfiles/issues/1
*/
$window.requestFileSystem(x, size, fn, errFn); // ios
} else {
$window.requestFileSystem($window.PERSISTENT, size, fn, errFn); // dev doesnt work
}
}
initFs(q.resolve, q.reject);

hey @panchisco, are you adding all that inside
.provider('$cordovaFile', [function () {
})

Just in case you are here with the same problem as me, my problem was I was giving the file a name containing invalid characters. I was building a system to log application events and I created the file like this:
dir.getFile("log123-" + new Date().toString() + ".txt", ...

I have used a better name and it works!


⚠ Minecraft has degraded performance

In f76d52e, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1752 ms

Resolved: Minecraft performance has improved in 82984fa.


update CSS stylesheet

Hi team,
I tried to update main.css for navigation bar background to dark grey, but it is not working, it is still showing steel blue.
original:
.bg-steel {
background-color: #5f788a;
}
updated to:
.bg-steel {
background-color: #666666;
}
Thank you,
Ling

Its pretty much hectic work to override bootstap navbar CSS.Better remove the Bootstrap class=".bg-steel" from your main code and make your own navbar.If you want bootstrap class then use
.bg-steel {
background-color: #5f788a !important;
}
but i wouldn't recommend doing everywhere

I've had the same problem. I was able to change the background colour by inserting the CSS stylesheet into the base.html page & remove the .bg-steel  class from CSS.

Before it was like :


Fix styling bugs in graph settings and style panel

Fixes #1194, Fixes #1188, Fixes #1190, Fixes ##1193
Description of the changes:

Reverts graph setting textbox to original style
Fixes heading font sizes and spacing
Hooks up line style combo box foreground color
Make line style combo box binding mode to OneWay instead of OneTime

How changes were validated:

Manual testing

In Graph Settings, is the Line Thickness combo box supposed to align with the right side of the Trig Units buttons?

It looks good. I was wondering if the LineThickness combobox was supposed to be wider. That can come in a different PR though.

Can you write a bug for it? I can do it in a new PR.

/azp run


homebridge-hue does not recognized newest version of homebridge

Hello,
Homebridge is not starting anymore:
[2019-6-23 10:11:00] ERROR LOADING PLUGIN homebridge-hue: [2019-6-23 10:11:00] Error: Plugin /usr/lib/node_modules/homebridge-hue requires a HomeBridge version of ^0.4.50 which does not satisfy the current HomeBridge version of 0.4.49. You may need to upgrade your installation of HomeBridge.     at Plugin.load (/usr/local/lib/node_modules/homebridge/lib/plugin.js:56:11)     at Server.<anonymous> (/usr/local/lib/node_modules/homebridge/lib/server.js:153:14)     at Array.forEach (<anonymous>)     at Server._loadPlugins (/usr/local/lib/node_modules/homebridge/lib/server.js:145:22)     at new Server (/usr/local/lib/node_modules/homebridge/lib/server.js:57:24)     at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:32:16)     at Object.<anonymous> (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)     at Module._compile (internal/modules/cjs/loader.js:774:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)     at Module.load (internal/modules/cjs/loader.js:641:32)
[2019-6-23 10:11:00] ERROR LOADING PLUGIN homebridge-lib: [2019-6-23 10:11:00] Error: Plugin /usr/lib/node_modules/homebridge-lib requires a HomeBridge version of ^0.4.50 which does not satisfy the current HomeBridge version of 0.4.49. You may need to upgrade your installation of HomeBridge.     at Plugin.load (/usr/local/lib/node_modules/homebridge/lib/plugin.js:56:11)     at Server.<anonymous> (/usr/local/lib/node_modules/homebridge/lib/server.js:153:14)     at Array.forEach (<anonymous>)     at Server._loadPlugins (/usr/local/lib/node_modules/homebridge/lib/server.js:145:22)     at new Server (/usr/local/lib/node_modules/homebridge/lib/server.js:57:24)     at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:32:16)     at Object.<anonymous> (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)     at Module._compile (internal/modules/cjs/loader.js:774:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)     at Module.load (internal/modules/cjs/loader.js:641:32)
[2019-6-23 10:11:00] Error: The requested platform 'Hue' was not registered by any plugin.     at API.platform (/usr/local/lib/node_modules/homebridge/lib/api.js:134:13)     at Server._loadPlatforms (/usr/local/lib/node_modules/homebridge/lib/server.js:327:45)     at Server.run (/usr/local/lib/node_modules/homebridge/lib/server.js:90:36)     at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:59:10)     at Object.<anonymous> (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)     at Module._compile (internal/modules/cjs/loader.js:774:30)     at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)     at Module.load (internal/modules/cjs/loader.js:641:32)     at Function.Module._load (internal/modules/cjs/loader.js:556:12)     at Function.Module.runMain (internal/modules/cjs/loader.js:837:10)
So, homebridge tells me "Got SIGTERM, shutting down Homebridge...".
I think, newest homebridge is already installed:
`/usr/bin/homebridge -> /usr/lib/node_modules/homebridge/bin/homebridge

<EMAIL_ADDRESS>updated 1 package in 3.799s`

But, I noticed, the messages above are showing 2 different paths:
/usr/lib/ and /usr/local/lib
Why does homebridge-hue not recognize that newest version of homebridge is already installed and shuts down homebridge ?

Homebridge-hue doesn’t check what versions of homebridge are installed, it just receives the version from tye running homebridge.  Looks like you’re running an old version of homebridge from /usr/local/lib.

That is what I quoted above, yes. But, as you can this above, 0.4.5 is installed... the newest version.
The quoted text shows, 0.4.5 is installed in /usr/lib... the error message of hue plugin is looking for homebridge at /usr/local/lib... which is different.

Again, homebridge-hue is not looking for homebridge.  You're starting homebridge from /usr/local/lib, and that version fails to load homebridge-hue.


Application crashes during blockchain synchronization

Ledger Live Version and Operating System

Tested on Ledger Live 2.14.0
Phone version: Samsung S10+ on Android 10

Expected behavior
Application synchronizes succesfully with the blockchain and works as intended.
Actual behavior
Application always crashes at startup during blockchain synchronization.
Steps to reproduce the behavior
Issue seems to be related with having a lot of different Ethereum tokens in a wallet (> 100).
Stacktrace attached.

@juan-cortes do you recon this error also relates to your #1431 report?

Looks like it to me yes


[Cosmos v4] Cleanup: RemainingWorkEstimatorImpl is dead-code

The type RemainingWorkEstimatorImpl  is not used anywhere. This type was revealed when spot bug reported URF_UNREAD_FIELD for this class.

@milismsft  - can we remove this dead code or is it necessary to keep it ?
Whatever may be the reason, we can close this issue. Please update it. Thanks.

yes, we can remove it (and the interface).


Update to #FightClub Family / YAML Config

name: #FightClub Family
key: fightclub
color: purple
emblem: Skull_01
info:
  logo:
  description: >
    A drama free group of fun loving folks, focused on warring. From casual to competitive, there's something for everyone!
  social:
    - discord: http://discord.gg/SuM7BgNck6
clans:
  - name: #FightClub
    tag: 8JP082C
  - name: #FightClub2
    tag: 2CLVG9V9
  - name: #FightClub3
    tag: 9YVJ98CV
  - name: #FightClub4
    tag: PJYPUVGJ
  - name: #FightClub69
    tag: PCP929JU

Thank you!

https://royaleapi.com/f/fightclub

Thank you very much!


flash-attn successfully installed but Flash Attention 2 is not available

cuda: 11.7
torch: 2.0.1
python: 3.10.9
release: flash_attn-2.3.5+cu117torch2.0cxx11abiFALSE-cp310-cp310-linux_x86_64.whl
File "/home/.conda/envs/venv310/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 566, in from_pretrained
    return model_class.from_pretrained(
  File "/home/.conda/envs/venv310/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3233, in from_pretrained
    config = cls._check_and_enable_flash_attn_2(config, torch_dtype=torch_dtype, device_map=device_map)
  File "/home/.conda/envs/venv310/lib/python3.10/site-packages/transformers/modeling_utils.py", line 1273, in _check_and_enable_flash_attn_2
    raise ImportError(
ImportError: Flash Attention 2 is not available. Please refer to the documentation of https://github.com/Dao-AILab/flash-attention for installing it. Make sure to have at least the version 2.1.0

I failed in installing flash-attn by pip install flash-attn --no-build-isolation.
raise OsError('CUDA_HOME environment variable is not set. though I set CUDA_HOME and the variable can be seen by echo.
I've successfully installed flash-attn through release.
pip show flash-attn
Name: flash-attn
Version: 2.3.5
Summary: Flash Attention: Fast and Memory-Efficient Exact Attention
Home-page: https://github.com/Dao-AILab/flash-attention
Author: Tri Dao
Author-email<EMAIL_ADDRESS>License:
Location: /scratch/users/yanxinl4/my.conda.dir/envs/venv310/lib/python3.10/site-packages
Requires: einops, ninja, packaging, torch
Required-by:

4070 ti super
ubuntu 22

Hi, have you solved the problem yet? I successfully installed flash-atten through pip install flash-attn --no-build-isolation
but I also got the "not available" error.

Same problem here. I checked there are two ways

but none of them works for me

Any luck ?

Same problem. On UNC longleaf.

Same problem.

Hi everyone, the issue was due to an incompatible Python version. I faced the same problem, and the simple solution is to downgrade Python from version 3.10 to 3.9. It worked for me.


new default: no public plaintext listener

@DanielOaks I won't merge this without your approval.
I feel like public plaintext is a bad default for 2020, and goes against the ideas in https://github.com/ircv3/ircv3-ideas/issues/45. But if you think this is an unfriendly default, or insufficiently batteries-included, I get it.
@csmith I'm not 100% clear on how this would interact with the Docker configs; would 6667 still be exposed despite this change, because of EXPOSE and -p?

Yeah, if you're running in docker per the README in dist/docker then it will still expose 6667.
But docker's not doing anything clever - if the ora binary isn't listening on 6667 then connections will fail in basically the same way they'd fail if it was running on bare-metal.
(If this lands we should update the docker bits though, as it'll be weird and confusing to expose a port we're not listening on!)

Yep, let's do this


Add files via upload

Your checklist for this pull request
Author name
Author:Tawhid Bin Omar

About your game
What is your game about?
Rolling a dice
How do you play your game?
W A S D I J K L every buttons works
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

Yea


[Enahncement] PXC File JSON Minification

Currently the JSON for a .pxc file is fairly minified, but it does leave some spaces that can be removed to reduce file size even more.
Empty Project (Current)
{ "nodes": [ ], "graph": { "graph_x": 560.0, "graph_y": 338.0 }, "version": 1100.0, "animator": { "framerate": 8.0, "frames_total": 16.0 } }

Empty Project (Minified)
{"nodes":[],"graph":{"graph_x":560.0,"graph_y":338.0},"version":1100.0,"animator":{"framerate":8.0,"frames_total":16.0}}

This minor data optimization could probably be implemented whenever since it shouldn't affect functionality, and would help shave off some KB as files get larger and larger.

Sure, currently I just use default GameMaker json function. I think I can optimize save file a lot more (also deal with those weirdly long decimal value e.g. 0.10000000000000000555111512312578)

Implemented in 1.12