Circular Reference using webpack & useminPrepare - caused by style-loader

Webpack: 1.12.14
grunt-webpack: 1.0.11
Windows & Linux
Our Travis build started failing today reporting "Circular Reference detected"
I have replicated this locally on my development machine by deleting my node_modules and running npm install
It seems that running grunt webpack useminPrepare is causing the issue.  Running them individually is fine.
I have spent some time altering the build file and code to narrow down the issue and it seems that it is the css loading which causes the issue.
I have tried upgrading/downgrading various things but cannot get the error to go away.  It must be a combination of things here but I am stuck
When I removed the line of code "var css = require("./dialog.css");" the build works fine
In my webpack config I have
module: {
loaders: [
{test: /.css$/, loader: "style-loader!css-loader"},
{test: /.html$/, loader: "html-loader"}
]
}
Package file contains:
"grunt-usemin": "^2.3.0",
"grunt-webpack": "^1.0.11",
"style-loader": "^0.13.0",
"webpack": "^1.12.14",
"webpack-dev-server": "^1.14.1",
"css-loader": "^0.23.1",
If anyone can assist with this issue it would be greatly appreciated

I spent 3 hours investigating the issue, eventually our build just started passing again.
All I can summerise is a package or dependency was released which caused an error and in that 3-4 hour window another release was performed and it fixed the dependency!
Who knows what it was or which package!


dict_reader.py throws KeyError when supports_multivalues=True for custom commands

This error seems to occur because dict_reader.py populates the fieldnames property with only the non __mv_* field names, which causes super(DictReader, self).next() to return a dict where the __mv_* fields are grouped together in a single dictionary entry.
Example:

Splunk passes a set of field names to the custom command:
 test1,test2,__mv_test1,__mv_test2

splunk_csv.DictReader.fieldnames gets called which results in:
 csv.DictReader._fieldnames = ["test1", "test2","__mv_test1","__mv_test2"]
 splunk_csv.DictReader.__fieldnames = ["test1", "test2"]
 splunk_csv.DictReader.__mv_fieldnames = [("test1","__mv_test1"), ("test2","__mv_test2")]
 return __fieldnames

Note that __fieldnames is returned.

splunk_csv.DictReader.next is called, which in turn calls csv.DictReader.next and reads an event from Splunk:
 "1 2 3","9193","$1$,$2$,$3$",

csv.DictReader.next combines the event and fieldnames property...
 d = dict(zip(self.fieldnames, row))
 lf = len(self.fieldnames)
 lr = len(row)
 if lf < lr:
     d[self.restkey] = row[lf:]
 elif lf > lr:
     for key in self.fieldnames[lr:]:
         d[key] = self.restval
 return d

Because this method uses fieldnames, d now contains:
 [("test1","1 2 3"),("test2","9193"),(self.restkey,["$1$,$2$,$3$",""])]

splunk_csv.DictReader.next iterates over self.__mv_fieldnames and attempts to look up "__mv_test1" in the dictionary, which results in a KeyError.

Running Splunk 6.2.4
Python SDK 1.3.1

Thanks @brattonc, we're working on updating search commands. We'll be sure to address this when those changes are released

For my relatively simple streaming command, switching fieldnames to return _fieldnames instead of __fieldnames fixed this bug without any noticeable side effects. I'm running Python SDK 1.4.0 on Splunk 6.2.4.

We've just released v1.5.0 to address this, thanks again for the bug report @ahoying @brattonc


CTRL-A to select all only works in Arrow tool mode

Currently when another tool is selected like paintbrush, CTRL-A to select all is not working.
It looks like only the arrow tool supports CTRL-A select all.
It would be great to have CTRL-A and block operations for ALL modes of editing.

Block operations should work for all modes of editing - there is no restriction on them. If there is no selection they work on the whole layer by default.
For example try cut & paste and ctrl+alt + arrows - that are the scroll operations - they work on the floating layer

closing. Added selection mode. Select All doesn't make sense much for other modes.


 I've demonstrated the changes I would make in a series of commits. My goal was to reduce duplication and coupling.
I've tried not to use any advanced features of the language.
Let me know if you have any questions about what I've done

Thank you! Sorry for taking so long to get to this. I'll create a new file with your version, go through it, and see if I have any questions. Thanks!


avoid negations

for example:

Am not bothered by difficult social situations

Can easily manage difficult social situations
Prefer easy/small social situations

Am not interested in theoretical discussions

Am interested in theoretical discussions

Have difficulty starting tasks

Prefer to start tasks
Prefer to start new things (?)

Try not to think about the needy

Prefer to think about the bright sides of life

the question is: should we use binary or ternary logic?
ternary logic uses negations in questions, and a "negation of negation" can be seen as a neutral response,
but here we explicitly provide a "neutral" answer, so i would prefer questions in binary logic

Hey @milahu.
Thanks for the input :-)
The survey are taken from J. A Johnson's https://ipip.ori.org/30FacetNEO-PI-RItems.htm
so if you are looking to change the questionnaire that would be the place to go with your concerns.


token info passed as token_info argument to handler function, safe to use?

Description
I try to use the basic authentication feature of connexion 2.0. I figure out that currently not only the  sub entry of the token info is passed as user argument to the handler function but also the hole token as token_info argument. Which is great because i need some additional information from the user authentication function passed to the handler function.
Is this intended and just not documented or must i be aware that this will removed in the future?

@cziebuhr reworked that part, so they would know best. We'll try very hard in general to not break the interface until the next major version bump. The are some minor bugfixes that are still coming in, but everything should be pretty solid after that.

This feature has already been there for oauth2, I just reused the same mechanism for all authentication schemes. So yes, it's intended to be used that way.

Hey @herrwagner - I'm going to close out this ticket.
Hopefully you have what you need, otherwise please feel free to re-open it!


Remove unused datetime helpers

Summarise the changes this Pull Request makes.
Remove an unused class of datetime helpers.
Please include a reference to a GitHub issue if appropriate.

Test flakiness should be fixed in #127.


Compatible with Python 3.x

Some decoding and encoding code is not compatible with python 3.x
I think I will contribute some code to fix it

Thanks, I have no experience with Python 3.x compatible -_-|||


test: Add auto-redaction for not found error

What does this PR try to resolve?
This PR introduces auto-redaction for error messages related to "entity not found" across various platforms, as discussed in https://github.com/rust-lang/cargo/pull/14111#discussion_r1649176792.

Could you squash the fixup commit?

Could you squash the fixup commit?

Yes, I'll do it once the CI passes!

Squashed and rebased! Thanks for the review!

@bors r+

:pushpin: Commit 91569f84b051ae6572fd9e0c0224c01a15d6fc1b has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 91569f84b051ae6572fd9e0c0224c01a15d6fc1b with merge 5e93754c31ba2a9c758516cdb2530c66249240ef...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 5e93754c31ba2a9c758516cdb2530c66249240ef to master...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 5e93754c31ba2a9c758516cdb2530c66249240ef to master...

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.


Include an example with ServersideOutput and memoize in the documentation?

Hi, I'm wondering if you could include an example with ServersideOutput and memoize in the documentation. Thank you.

Yes, i plan to add some examples to the documentation in the near future. For now, you could look here for inspiration,
https://github.com/thedirtyfew/dash-extensions/blob/master/examples/callback_memoize.py

Thanks, that works. I made a mistake in the import statement. I was just reading your posts on dash community lol

Ah, I see. Yes, the syntax has changed a lot in the last release, but I think it has gotten a lot better. Let me know if you have any suggestions for improvements :)


Taking forever to compute + .pk files too large?

I have been re-computing the scores, and now I am including the paths, the thresholds, and the f-measures. However, it takes a long time to compute (around 6 or 7 hours each file), and each file weights around ~800MB (my guess is that the Isophonics ones will be much lighter).
I believe the files weight so much because I am saving the paths in a list of lists, which is highly inefficient (and it contains redundant information, since the matrices are symmetrical). When I tgz them, the files become around 25MB each, which is not that bad.
Should we stop and re-run the scores, or should we leave them like this? I got 2 files so far (of 12).

SALAMI small scale files are around 3.7GB, which is unacceptable.

Hrm.  A couple of simple hacks come to mind:

Cast everything down to float32
Use pickle.dump(..., protocol=-1) to use the latest protocol

The segment-by-segment cost matrix probably doesn't cost too much to store.
The segment-by-segment path arrays might be hurting here, in which case, yeah, only store the upper triangle.

After doing that, the files are dramatically reduced (now the largest file is no more than 2MB,  which is so small that makes me wonder if I'm doing something wrong).
Only one more file remaining to be computed, once all of them are done I will upload them to the data folder.

Ok, I just uploaded the data. Please, take a look at it if you have some time, and let me know if it makes sense.

Ok, the small scale data is uploaded. I think all scores and paths are correct now.


Running example returns empty array

OS: Ubuntu 22.04.3 LTS (GNU/Linux 5.15.0-89-generic x86_64)
The example seems to be unable to load aasx package. I did:
git clone https://github.com/eclipse-basyx/basyx-java-server-sdk.git
cd basyx-java-server-sdk/examples/
docker compose up -d
curl http://localhost:8081/shells

returns:
[]
What's the problem and how do I fix it?

I removed all containers, images and volumes. Started from scratch -> works.


Random browser user agents or random user agents?

Hi,
I got a question. The user agents from useragentstring.com also includes crawlers and bots. Does that mean that those are included in the random generation of user agents or are only browsers included?
Thanks!

@japborst good question. Since we use fake-useragent package and it uses the real-world stats (available here), the random user agent you get would only contain the browsers presented on this page which are Chrome, IE, Firefox, Safari or Opera. The user agent strings can though be not only 'desktop' but 'mobile' as well. Thanks.

Thanks for the update @alecxe. With some auto throttling it works perfectly btw! :-)


MINOR: add docker usage documentation link in README.md

We have a detail usage guide for running Kafka in docker. However, it might be easy for people to miss it if they only scan through the README.
This PR add a basic example command for quick start and  link directing users to the detailed usage guide
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the PR. I'm thinking we can put the running with docker below these 2 sections since they are all doing the same thing: Running a Kafka broker in KRaft mode Running a Kafka broker in ZooKeeper mode
WDYT?
Also, in our quick start guide section in doc, we use different command to run the image. I think we should be consistent.

Thanks for reviewing my PR! And I totally agree with you, I think that would make it easier to be found 😄 And we should align with the quick start in other places. I revise a bit base on those points, could you help me have a look again?


os-clamav plugin only listens to <IP_ADDRESS>

As reported, and described, in the OPNsense forum:
https://forum.opnsense.org/index.php?topic=15319.0
OP from forum post:
`
Hi!
Code: [Select]
OPNSense: v19.7.8
os-clamav: v1.7
I have recently started to play with the plugin os-clamav to be used by my mailserver (other machine on local network) for scanning mails.
As far as I can understand the configuration 'Enable TCP port' (This will enable TCP port 3310 in addition to the local socket) should make it listen to port 3310 and be available to other machines on the network.
It turns out that I only get it to listen to <IP_ADDRESS> port 3310 regardless if it's enabled or disabled in the configuration.
After having a look in /usr/local/etc/clamd.conf I can see the entry for this
TCPAddr <IP_ADDRESS>
How do I get it to listen on either ALL interfaces (*) or the local LAN address of the OPNSense server?
Am I doing something wrong here?
Regards,
/Jonas...
`
Reported here as proposed by @mimugmail
Thank you!

Just came across the same issue and solved it with port forwarding to "<IP_ADDRESS>:3310".
Just my opinion: Would vote for keeping it as-is but improve the UI help to mention that port forwarding is required. An unprotected/unencrypted service like ClamAV should be protected by a firewall rule. Binding it to localhost enforces this.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


Traefik v3: postgres Cancel Request not handled

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
If you start a connection to Postgres, for example with psql, through a Traefik proxy, then you start a transaction, then press control + C to send interrupt to psql, psql will send a Cancel request to the server, and this cancel request is not handled in Traefik
example query:
create table users(name text);

DO $$
DECLARE
    -- You can declare any necessary variables here
BEGIN
    LOOP
        -- Insert command goes here
        INSERT INTO users (name) VALUES ('brian');

        -- Pause for 1 second
        PERFORM pg_sleep(1);
    END LOOP;
END$$;

What did you see instead?
The cancel request is initiated, TCP handshake works. Then PGSQL Cancel request is sent. The server ACK, then FIN / ACK. TCP connection closes. I'm not sure how this ought to work in the case of required encrypted connections, routing with SNI.
Here is a filtered down pcap that shows this interaction
cancel-request-rejected.pcapng.zip
This is what a Cancel request looks like

What version of Traefik are you using?
Version:      3.0.0-beta2
Codename:     beaufort
Go version:   go1.19.4
Built:        2022-12-07T16:32:34Z
OS/Arch:      linux/amd64

What is your environment & configuration?
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRouteTCP
metadata:
.... omitted
spec:
  entryPoints:
  - postgresql
  routes:
  - match: HostSNI(`org-tembo-test-inst-steven.data-1.use1.tembo-development.com`)
    services:
    - name: org-tembo-test-inst-steven-rw
      port: 5432
  tls:
    passthrough: true

If applicable, please paste the log output in DEBUG level
No response

Please /assign this issue to me and let's discuss over it.

@rtribotte We are interested to fix this issue, please let me know and the Tembo team is here to help in any way to move it forward.

Hello @sjmiller609,
Thanks for reporting this and sorry for the late answer!
I was able to reproduce the issue, I'm marking this issue as bug/confirmed.

@rtribotte We are interested to fix this issue, please let me know and the Tembo team is here to help in any way to move it forward.

Sure, any contribution to this would be gladly welcome!
Nonetheless, can you please explain the approach that you think should be taken?
Would recognizing the CancelRequest bytes be enough if it is only a clear text connection, Traefik will not be able to route to the correct Postgres instance. Also, because it is a new connection, even if the connection could be routed to the correct Traefik service thanks to the TLS SNI, if the service is a load-balancer of multiple servers, it seems not possible to target the right possible Postgres instance.

I have the same initial conclusions about the wire protocol seems not possible to handle the cancel request, so I will need to find more information on the postgres side to know what can be done.


PDFString does not handle escaping

Hello,
the PDFString class does not handle escaping; its documentation reports:
  // The PDF spec allows newlines and parens to appear directly within a literal
  // string. These character _may_ be escaped. But they do not _have_ to be. So
  // for simplicity, we will not bother escaping them.

which is incorrect, because parenthesis may not be escaped only if they are balanced.
Furthermore, strings longer than 255 characters are split into multiple lines, which is not handled by PDFString as well.

The screenshot shows a PDF form field with /TU set to a string 320 characters long. Adobe Reader automatically inserts a 5C0D (a reverse solidus followed by carriage return) at the 255th character. PDFString does not handle this.

Hello @daniloarcidiacono! You are correct that PDFString does not auto-escape its input. The PDFString class is part of pdf-lib's low-level core API. It is assumed that the caller of PDFString has already handled any necessary escaping. That being said, I'd be open to a PR that adds a new method to PDFString which escapes its input.


Auto merge should not proceed if approved reviews greater than minimum required but requested changes exist

Bug Report
Current Behavior
The current logic is that the following conditions need to be met

All requested reviews are provided and minimum review is disabled
All provided reviews are approved and (reviews greater or equal to minimum count required or minimum count disabled)
Approved reviews is greater or equal to minimum count required (if enabled)

This could cause unexpected merger in the case where there are requested changes but others have approved the change as this would pass check 3
To Reproduce
Steps to reproduce the behavior:
With minimum review count = 1

Create a PR
As a reviewer request changes via a review
Another reviewer approve the change
Auto merge will happen

Expected behavior/code
We should expect that while there is a rejected review it does not process the auto merge
GitHub Action Configuration (.yml, etc)
jobs:
  prhelper_job:
    runs-on: ubuntu-latest
    steps:
    - name: Run PR Helper
      id: runprhelper
      uses<EMAIL_ADDRESS>      with:
        repo-token: ${{ secrets.GITHUB_TOKEN }}
        enable-prmerge-automation: true
        enable-prcomment-automation: true
        enable-prlabel-automation: true
        enable-welcomemessage: true
        welcome-message: "Thanks for opening an issue! Make sure you've followed CONTRIBUTING.md."
        prmerge-requireallchecks: true
        prmerge-requirereviewcount: 1
        permerge-method: 'merge'

Released


Authenticating with Azure DevOps using SPN

Introduce identity based azure-pipelines trigger authentication for scaledObjects / scaledJobs.
Use-Case
With the recent introduction of Azure identity based authentication for Azure DevOps - link , it would be nice if we can leverage identities in the azure-pipelines trigger. As of documentation in 2.11, it seems that only a Personal Access Token (PAT) is supported.
I am using attached startup script for my agent where AZP_CLIENTID, AZP_CLIENTSECRET and AZP_TENANT values are used instead of the PAT token to authenticate with Azure DevOps. The agents are setup as scaled Jobs. The token generated by the identity in this approach is valid for 1 hour only. For this reason, the token is regenerated again in the cleanup() block to accommodate long running jobs. This has been working seamlessly in our setup for the last 2 months. If the same values are available to be passed within the azure-pipelines trigger, it would help remove the dependency on the PAT token altogether.
FYI - Below change has additionally been done in the Dockerfile. Ref - link
ENTRYPOINT [ "./start.sh", "--once" ]
startup.txt
Specification

[ ] Enable identity support in azure-pipelines trigger authentication for Azure Pipelines.

any updates please?


Merge main into live

Please don't squash-merge this PR.

closing and reopening for a fresh build


Azure Cosmos DB Docker container stopping

Copying from: https://github.com/Azure/azure-cosmos-dotnet-v3/issues/3010
Describe the bug
Using Azure DevOps and a ubuntu-latest hosted agent, when starting the container, the container returns right away the following:
This is an evaluation version.  There are [165] days left in the evaluation period.
Shutting Down
Shut Down

To Reproduce
Create an Azure DevOps pipeline with the following:
pool:
  name: Azure Pipelines
  vmImage: 'ubuntu-latest'
jobs:
- job: TestJob
  displayName: 'My Job'
  steps:
  - task: PowerShell@2
    name: showNetAdapters
    displayName: 'Show NetAdapters'
    inputs:
      pwsh: true
      targetType: inline
      script: |
        ifconfig
        $ipAddress = (hostname -I | awk '{print $1}')
        Write-Output "IpAddress = $ipAddress"
  - task: PowerShell@2
    name: startCosmosDb
    displayName: 'Start Azure Cosmos DB emulator'
    inputs:
      pwsh: true
      targetType: inline
      script: |
        $ipAddress = (hostname -I | awk '{print $1}')
        $containerId = (docker create -p 8081:8081 -p 10251:10251 -p 10252:10252 -p 10253:10253 -p 10254:10254 -m 3g --cpus=2.0 -e AZURE_COSMOS_EMULATOR_PARTITION_COUNT=10 -e AZURE_COSMOS_EMULATOR_ENABLE_DATA_PERSISTENCE=false -e AZURE_COSMOS_EMULATOR_IP_ADDRESS_OVERRIDE=$ipAddress mcr.microsoft.com/cosmosdb/linux/azure-cosmos-emulator)
        Write-Host "##vso[task.setvariable variable=cosmosDbContainerId]$containerId"
        docker start $containerId
        Start-Sleep -Seconds 5
        $isStarted = $false
        while ($isStarted -eq $false) {
            $logs = (docker logs $containerId)
            if ($logs.Contains('Started')) {
                Write-Output "Container $containerId started."
                $isStarted = $true
                break;
            }
            Write-Output "Waiting for container $containerId to start"
            Write-Output ($logs | Out-String)
            Start-Sleep -Seconds 5
        }
  - script: |
      echo 'ContainerId = $(cosmosDbContainerId)'
      docker logs $(cosmosDbContainerId)
    displayName: Diagnostics
  - script: |
      ipAddress="hostname -I | awk '{print $1}'"
      curl -k https://$ipAddress:8081/_explorer/emulator.pem > $(Agent.TempDirectory)/emulatorcert.crt
      cp $(Agent.TempDirectory)/emulatorcert.crt /usr/local/share/ca-certificates/
      update-ca-certificates
      echo "##vso[task.setvariable variable=cosmosDbEndpoint]https://$ipAddress:8081"
    displayName: 'Prepare emulator'
  - script: |
      if [ ! -z "$(cosmosDbContainerId)" ];
      then
        docker rm -f $(cosmosDbContainerId)
        rm -f /usr/local/share/ca-certificates/emulatorcert.crt
      fi
    displayName: 'Clean Azure Cosmos DB emulator'
    condition: always()

Expected behavior
The container should create the partitions and return "Started" at some point
Actual behavior
The container exits and the logs shows
This is an evaluation version.  There are [165] days left in the evaluation period.
Shutting Down
Shut Down

Additional context
Can't use older images (tags) to see if the code has changes since, as it fails the evaluation time check
Is there something I can add as environment variable to get more logs out to diagnose the problem?

After discussion, it seems there's a problem with ubuntu-latest (ubuntu-20.04) vmImage. ubuntu-18.04 works.
Anyway to understand what has changed from 18 to 20?

Hi @soenneker @DOMZE for questions regarding changes on hosted images - I would suggest to open a ticket in https://github.com/actions/virtual-environments to get right eyes on it.

Should this be closed as https://github.com/Azure/azure-cosmos-db-emulator-docker/issues/45 is still not yet fixed?

Bump.   There are [37] days left in the evaluation period.
Shutting Down
Shut Down
Testing

Also have this issue, currently blocking us from running CosmosDB on azure devops pipelines

Right now we're using the cosmos emulator script that's included on the windows host. Another workaround might be using a real cosmos instance and clearing out the data before running tests against it.

Bump. Any updates?

I'm running into this issue on an Apple M1 chipset but my colleague seems to be able to run the image just fine from a Windows machine. Nothing spit out of the verbose logs, the image quietly exits with code 0 like it ain't no thang.
verticalslice-cosmos-1  | This is an evaluation version.  There are [152] days left in the evaluation period.
verticalslice-cosmos-1  | Starting
verticalslice-cosmos-1 exited with code 0

Same error in Nov 2024. Any updates how to run on M1 macs?


Feature/overriding refresh token timeouts

There might be a better approach here (or this may not be desired or needed at all) but this should allow for users to override the advisory and mandatory refresh timeouts that are a part of the RefreshableToken Class - addresses this issue: #2190

Codecov Report

Merging #2190 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2190      +/-   ##
===========================================
- Coverage    98.19%   98.18%   -0.01%
===========================================
  Files           58       58
  Lines        10843    10843
===========================================
- Hits         10647    10646       -1
- Misses         196      197       +1

Impacted Files
Coverage Δ

botocore/credentials.py
98.54% <100.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6205e5...f9047c4. Read the comment docs.

Thank you for submitting this PR. After team discussion, we're going to have to discuss with other SDKs for potential cross-SDK approach to keep it consistent and decided not to consider this one at this time.


This PR improves execing to the pod trhough CITF

improves execing to the pod trhough CITF.

generalizes to handle multiple container pods

empty string can be passed for namespace param if namespace is default

empty string can be passed for containerName param in ExecToPodThroughAPI method, If the pod has only one container then it will work fine, otherwise it will through error.

empty string can be passed for containerName param in ExecToPodThroughKubectl method, In this case it will be handled by kubectl.

empty string can be passed for containerName param in ExecToPod method, In this case if there is only one container ExecToPodThroughKubectl will give the output, else it will be handled by ExecToPodThroughKubectl hence by kubectl eventually.
Signed-off-by: Abhishek Kashyap<EMAIL_ADDRESS>

@a4abhishek Can you please resolve the conflicts?

Sure @Akash4927

Addressed all your comments @sagarkrsd , have a look again.


Test failing running data-jolokia-demo

Hi, first some changes I've made in pom.xml to work without needing to deploy *.war flies in maven repository by hand.

<dependency>
      <groupId>org.jolokia</groupId>
      <artifactId>jolokia-war</artifactId>
      <version>${jolokia.version}</version>
      <type>war</type>
      <scope>system</scope>
      <systemPath>${absolutepath}/jolokia.war</systemPath>
    </dependency>
    <!-- Jolokia Integration Test Setup (registers some Test MBeans) -->
    <dependency>
      <groupId>org.jolokia</groupId>
      <artifactId>jolokia-it-war</artifactId>
      <version>${jolokia.version}</version>
      <type>war</type>
      <scope>system</scope>
      <systemPath>${absolutepath}/jolokia-it.war</systemPath>
    </dependency>

Running mvn verify and with boot2docker up ... I get:
Running org.jolokia.docker.maven.sample.jolokia.VersionIT
Checking URL: http://<IP_ADDRESS>:32780/jolokia
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.71 sec <<< FAILURE! - in org.jolokia.docker.maven.sample.jolokia.VersionIT
testVersion(org.jolokia.docker.maven.sample.jolokia.VersionIT)  Time elapsed: 1.644 sec  <<< ERROR!
com.jayway.restassured.path.json.exception.JsonPathException: Failed to parse the JSON document

Complete log ¿any idea?:
@jaloncad/Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo$ mvn verify
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.jolokia:docker-jolokia-demo:jar:0.13.4
[WARNING] 'dependencies.dependency.systemPath' for org.jolokia:jolokia-war:war should use a variable instead of a hard-coded path /Users/jaloncad/Downloads/jolokia.war @ line 49, column 19
[WARNING] 'dependencies.dependency.systemPath' for org.jolokia:jolokia-it-war:war should use a variable instead of a hard-coded path /Users/jaloncad/Downloads/jolokia-it.war @ line 58, column 19
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building docker-jolokia-demo 0.13.4
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ docker-jolokia-demo ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ docker-jolokia-demo ---
[INFO] No sources to compile
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ docker-jolokia-demo ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/src/test/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ docker-jolokia-demo ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.10:test (default-test) @ docker-jolokia-demo ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ docker-jolokia-demo ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO]
[INFO] --- docker-maven-plugin:0.13.4:build (start) @ docker-jolokia-demo ---
[INFO] DOCKER> ... latest Pulling from busybox
[INFO] DOCKER> ... cfa753dfea5e Already exists
[INFO] DOCKER> ... d7057cb02084 Already exists
[INFO] DOCKER> ... Digest: sha256:16a2a52884c2a9481ed267c2d46483eac7693b813a63132368ab098a71303f8a
[INFO] DOCKER> ...  Digest: sha256:ed5dde276731bd3acdb50beb3d57e88851368352f3f13c7677a84ae7b9f70d37
[INFO] DOCKER> ... Status: Image is up to date for consol/tomcat-7.0:latest
[INFO] DOCKER> [consol/tomcat-7.0:latest] "server": Start container 9d2467a7a69a
00:13:51.435 server> Checking *.war in /maven
00:13:51.437 server> Linking /maven/*.war --> /opt/tomcat/webapps/*.war
00:13:52.280 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.280 server> INFO: Server version:        Apache Tomcat/7.0.62
00:13:52.283 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.283 server> INFO: Server built:          May 7 2015 17:14:55 UTC
00:13:52.287 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.287 server> INFO: Server number:         <IP_ADDRESS>
00:13:52.290 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.290 server> INFO: OS Name:               Linux
00:13:52.292 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.292 server> INFO: OS Version:            4.0.7-boot2docker
00:13:52.295 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.295 server> INFO: Architecture:          amd64
00:13:52.297 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.297 server> INFO: Java Home:             /usr/lib/jvm/java-7-openjdk-amd64/jre
00:13:52.303 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.303 server> INFO: JVM Version:           1.7.0_79-b14
00:13:52.303 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.303 server> INFO: JVM Vendor:            Oracle Corporation
00:13:52.309 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.309 server> INFO: CATALINA_BASE:         /opt/tomcat
00:13:52.313 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.313 server> INFO: CATALINA_HOME:         /opt/tomcat
00:13:52.318 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.318 server> INFO: Command line argument: -Djava.util.logging.config.file=/opt/tomcat/conf/logging.properties
00:13:52.319 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.319 server> INFO: Command line argument: -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
00:13:52.323 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.323 server> INFO: Command line argument: -Xmx32m
00:13:52.326 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.326 server> INFO: Command line argument: -Djava.security.egd=file:/dev/./urandom
00:13:52.329 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.329 server> INFO: Command line argument: -Djava.endorsed.dirs=/opt/tomcat/endorsed
00:13:52.334 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.334 server> INFO: Command line argument: -Dcatalina.base=/opt/tomcat
00:13:52.338 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.338 server> INFO: Command line argument: -Dcatalina.home=/opt/tomcat
00:13:52.342 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.VersionLoggerListener log
00:13:52.342 server> INFO: Command line argument: -Djava.io.tmpdir=/opt/tomcat/temp
00:13:52.347 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.core.AprLifecycleListener lifecycleEvent
00:13:52.347 server> INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: /usr/java/packages/lib/amd64:/usr/lib/x86_64-linux-gnu/jni:/lib/x86_64-linux-gnu:/usr/lib/x86_64-linux-gnu:/usr/lib/jni:/lib:/usr/lib
00:13:52.485 server> Sep 23, 2015 10:13:52 PM org.apache.coyote.AbstractProtocol init
00:13:52.485 server> INFO: Initializing ProtocolHandler ["http-bio-8080"]
00:13:52.502 server> Sep 23, 2015 10:13:52 PM org.apache.coyote.AbstractProtocol init
00:13:52.502 server> INFO: Initializing ProtocolHandler ["ajp-bio-8009"]
00:13:52.509 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.Catalina load
00:13:52.509 server> INFO: Initialization processed in 711 ms
00:13:52.556 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.core.StandardService startInternal
00:13:52.556 server> INFO: Starting service Catalina
00:13:52.557 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.core.StandardEngine startInternal
00:13:52.557 server> INFO: Starting Servlet Engine: Apache Tomcat/7.0.62
00:13:52.577 server> Sep 23, 2015 10:13:52 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:52.577 server> INFO: Deploying web application directory /opt/apache-tomcat-7.0.62/webapps/host-manager
00:13:53.133 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:53.133 server> INFO: Deployment of web application directory /opt/apache-tomcat-7.0.62/webapps/host-manager has finished in 556 ms
00:13:53.140 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:53.140 server> INFO: Deploying web application directory /opt/apache-tomcat-7.0.62/webapps/manager
00:13:53.240 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:53.240 server> INFO: Deployment of web application directory /opt/apache-tomcat-7.0.62/webapps/manager has finished in 106 ms
00:13:53.244 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:53.244 server> INFO: Deploying web application directory /opt/apache-tomcat-7.0.62/webapps/ROOT
00:13:53.326 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.HostConfig deployDirectory
00:13:53.326 server> INFO: Deployment of web application directory /opt/apache-tomcat-7.0.62/webapps/ROOT has finished in 84 ms
00:13:53.331 server> Sep 23, 2015 10:13:53 PM org.apache.coyote.AbstractProtocol start
00:13:53.331 server> INFO: Starting ProtocolHandler ["http-bio-8080"]
00:13:53.347 server> Sep 23, 2015 10:13:53 PM org.apache.coyote.AbstractProtocol start
00:13:53.347 server> INFO: Starting ProtocolHandler ["ajp-bio-8009"]
00:13:53.351 server> Sep 23, 2015 10:13:53 PM org.apache.catalina.startup.Catalina start
00:13:53.351 server> INFO: Server startup in 839 ms
[INFO] DOCKER> [consol/tomcat-7.0:latest] "server": Waited on url http://<IP_ADDRESS>:32780/jolokia and on log out 'Server startup' 2089 ms
[INFO]
[INFO] --- maven-failsafe-plugin:2.17:integration-test (integration-test) @ docker-jolokia-demo ---
[INFO] Failsafe report directory: /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/target/failsafe-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.jolokia.docker.maven.sample.jolokia.VersionIT
Checking URL: http://<IP_ADDRESS>:32780/jolokia
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.71 sec <<< FAILURE! - in org.jolokia.docker.maven.sample.jolokia.VersionIT
testVersion(org.jolokia.docker.maven.sample.jolokia.VersionIT)  Time elapsed: 1.644 sec  <<< ERROR!
com.jayway.restassured.path.json.exception.JsonPathException: Failed to parse the JSON document
        at groovy.json.JsonLexer.nextToken(JsonLexer.java:82)
        at groovy.json.JsonLexer$nextToken.call(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:112)
        at com.jayway.restassured.internal.path.json.ConfigurableJsonSlurper.parse(ConfigurableJsonSlurper.groovy:99)
        at com.jayway.restassured.internal.path.json.ConfigurableJsonSlurper$parse.callCurrent(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:49)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:133)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:141)
        at com.jayway.restassured.internal.path.json.ConfigurableJsonSlurper.parseText(ConfigurableJsonSlurper.groovy:85)
        at com.jayway.restassured.path.json.JsonPath$4$1.method(JsonPath.java:839)
        at com.jayway.restassured.path.json.JsonPath$ExceptionCatcher.invoke(JsonPath.java:874)
        at com.jayway.restassured.path.json.JsonPath$4.doParseWith(JsonPath.java:837)
        at com.jayway.restassured.path.json.JsonPath$JsonParser.parseWith(JsonPath.java:917)
        at com.jayway.restassured.path.json.JsonPath.get(JsonPath.java:182)
        at org.jolokia.docker.maven.sample.jolokia.VersionIT.testVersion(VersionIT.java:32)

Results :

Tests in error:
  VersionIT.testVersion:32 » JsonPath Failed to parse the JSON document

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

[INFO]
[INFO] --- docker-maven-plugin:0.13.4:stop (stop) @ docker-jolokia-demo ---
[INFO] DOCKER> [consol/tomcat-7.0:latest] "server": Stop and remove container 9d2467a7a69a
[INFO] DOCKER> [jolokia/docker-jolokia-demo:0.13.4] "data": Stop and remove container fabaf713d748
[INFO]
[INFO] --- maven-failsafe-plugin:2.17:verify (verify) @ docker-jolokia-demo ---
[INFO] Failsafe report directory: /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/target/failsafe-reports
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19.404 s
[INFO] Finished at: 2015-09-24T00:13:56+02:00
[INFO] Final Memory: 28M/272M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.17:verify (verify) on project docker-jolokia-demo: There are test failures.
[ERROR]
[ERROR] Please refer to /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/target/failsafe-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Rgds,
Juan.

The issue is, that the assembly used to build the docker image doesn't pick up your dependencies:

[INFO] Reading assembly descriptor: /Applications/Dev/idea/docker-maven-plugin/samples/data-jolokia-demo/src/main/docker/assembly.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'org.jolokia:jolokia-war'
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'org.jolokia:jolokia-it-war'

The reason for that is, that you use system scope for the dependencies, which apparently the assembly plugin doesn't consider to be a dependency.
Since you want to include specific files anyway, I recommend to use a <fileSet> instead of a <dependencySet> in the assembly configuration of the plugin. Please refer to the assembly-maven-plugin for the detailed syntax.

Perfect!!! I tried with filesets and something went wrong, so I've came back to manually installation : mvn install:install-file -Dfile=./src/main/docker/demo/jolokia.war -DgroupId=org.jolokia -DartifactId=jolokia-war -Dversion=1.3.2-SNAPSHOT -Dpackaging=war
Thx, Juan.


Complete move to Vaadin v8

Replaced all references to vaadin.v7 components with v8 equivallent,
Replaced v7 compability layer with v8 layer
Switch demo to DefaultWidgetset
Bumped version to 2.0.1
Use Vaadin v8.0.5

Looks good to me, thanks!


Add Sciter 4.x port

Based on https://github.com/c-smile/sciter-sdk, but Windows only.
Current version: <IP_ADDRESS>.
Can be installed either as dynamic or static package (but static one requires the DLL presence still).

Thanks for the review, I'll fix it.

Hi @pravic, thanks for the PR, it looks great!
It's unfortunate that sciter publishes header files called "value.h" and "value.hpp" and also prefers being included without any subdirectories.
Despite that, I concur with your decision here to put the includes into a subdirectory 👍, it seems the best option.

Great, thanks!


[fix]: add checkout action in steps and add more log when kepler not …

add checkout action in steps to avoid invoke without checkout.
add more log when kepler is not started.

Merge as it is. and Hope we can get more logs.


Remove Structure Overlay Progress Bar

I created a structure in a book and really like the overlay feature, especially since my structure is very complicated. However, many of it's complications come from it's use of stairs. Because stairs are complicated in and of themselves, with the same orientation being able to be created 2 different ways in code, the progress bar for this structure sometimes displays blocks as being incorrect when it is in fact correct. Stairs are very particular in the location you're facing when placing them, so to be fair to the player, I made my structure very error tolerant, where if it looks like the ghost overlay structure, it'll work. However, like I said, the progress bar doesn't see it that way. I'm sure at least one person will be confused when building my structure and the progress bar says something is wrong, so I was wondering how I can disable the progress bar from displaying altogether.

I was able to remove the bar for my structure through the use of custom events, but it would be nice if this was something that could be easily turned off in the book itself.


Code execution on slide

Fixes #9
Changes Introduced

Allows any (ruby) code blocks to be executed if one is found
by pressing the e key.

(Just a prototype, this solution probably won't work for most lanugages. Going to try a different approach with writing files and creating a code package to make it easier to add support for more languages)

This is super cool! Really clean implementation.
Up to you, but I'm wondering if it's worth adding an additional piece to the UI to indicate to the user that code will be executed if they press E.
Like anytime there is a codeblock in a slide, either include a simple icon or a really light message in the bottom.
Mostly concerned to ensure someone is 10000% sure they'd like to execute code before they do so. Could be the unnecessary security headspace, but wanna make sure the feature isn't abused by crappy people to send slides with code exec to folks that don't know.

I had the same thought, definitely don't want slides to be abused as an attack vector. So I want to add some safeguards to ensure that user's know that code will be executed on the machine. We're at a little bit of an advantage because the code is displayed on the screen so we should be fine in terms of users seeing exactly what they'll be running.
I like your idea with displaying something on the UI, I'll implement something that tells the user to press e that will get replaced by the result once they do press it.

Could include something like this maybe.
# Here is my slideshow!

fmt.Println("hello")

													Slide 1/6 | ⚡

Tbh though, theres much easier ways to execute malicious code on people's machines than using this feature of slides 😂 if a user is willing to download a binary and run a command. So I don't think we need to be extremely protective especially since the code would be displayed.

lmao hey you're not wrong! If this is their chosen attack vector, I'd probably argue they should evaluate their techniques.
Nevertheless, I'd hate if some freshman in college got sent a slideshow be a friend that had a slide that said rm -rf /* and they changed their slide to say press e to go to next slide.

Agreed! I think we can probably execute the code in a sandbox, so they don't have access to the filesystem.

Here's an interesting reference repo that contains filesystem sandboxing of anything executed by cmd.Exec with Go. Looks like it confirms anytime the code attempts to access the filesystem. I'm not sure how disruptive this approach is but obviously it'd be nice if it felt pretty seamless.
Because ideally users would be able to access the filesystem if they need to, but only if they trust the process running.
https://github.com/nishitm/goBox
All the stuff I'm sending could totally be out of scope of your current idea though. Maybe just an icon is plenty for the initial PoC version! Again, this is your project so it's whatever feels best to you. :smile:

Yea, I will think about this a bit more. I think we definitely need some indication (if a code block is detected on the page) the E will execute the code block, but I don't think we need confirmation after that. Since the code will run as the user it won't have sudo privileges to do very harmful things.

Yep, totally agree! I think you're golden on this one. Should be a killer feature.

Sweet! Thanks for the feedback/input on the feature. Always nice to have a second set of eyes!

Continued some work in #27


Jr/17 linux guacamole issue when package mirror is stopped

Resolves #3811
What is being addressed
If a Linux VM is created while the Nexus package mirror VM is stopped, the Linux VM fails to create properly, meaning Guacamole connections to it fail.
When using the PowerShell start/stop scripts provided in the documentation on test environments, the start script does not restart the package mirror, leading to this issue.
How is this addressed
This change extends the start script, to start all VMs in the core resource group.  It also aligns the PowerShell start script behaviour with the make tre-start behaviour, which already starts the core VMs.

/test-force-approve docs only

@marrobi conflicts fixed

/test-force-approve


react how to use createStore

version:
"botframework-webchat": "^4.3.0",
"react": "^16.8.5",
"react-dom": "^16.8.5",
I want to do the  post activity by react like blew
https://github.com/Microsoft/BotFramework-WebChat/blob/16e33e1660fee638717d2b3c1627f5f6a2474722/samples/15.c.programmatic-post-activity/index.html#L41
But compile error happened when I import it
import  { createStore } from "botframework-webchat-core";

Did you find an answer to this question?


fix cve-2022-21698 in rook

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[ ] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary
Fixes CVE-2022-21698 for rook. The vulnerability is in the client_golang go module, which is vendored in this package. Fix is to apply a (modified) patch to the vendored code.
Change Log

Applied upstream patch to work with the older version of client_golang used by this package, along with getting rid of tests.

Does this affect the toolchain?
NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-21698

Test Methodology

Tested locally in a container.
Buddy Build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501233&view=results

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/CBL-Mariner/pull/7765

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=501368&view=results


[core] BytesPerPart does not work for bytes

It only works with a unit suffix, but a byte would have no suffix

fixed by PR https://github.com/chridou/condow/pull/6


Redis cluster support

Need to add redis cluster support to the client library.
Redis Cluster Specification - https://redis.io/topics/cluster-spec

The major difficulty will be extracting keys from the commands, because the QueryExecutor currently only gets an array of arguments, but doesn't know which ones are keys and which aren't. Knowning the keys is, however, important to use a client side routing table. Without a client side routing table, most queries will have to be redirected by the first server being queried, which is inefficient.


isEffectiveOn -> ?

isEffectiveOn in Item, ShearsItem, MiningToolItem, and its subclasses is not clearly named.
The current name implies that if the current item can break the given blockstate, it will return true. This is not the case - most notably for axes on wood, but other tools also face this issue - shears, shovels, hoes.
Naming this as "effective" in the sense that using the item would produce a drop not normally available from the block is also incorrect, see shears and shovels.
Shear's isEffectiveOn does slightly account for special behavior with tripwires, but it also returns true for redstone wire (of which there is no special behavior).
Strangely enough, it does seem to be properly implemented for pickaxes.
This method might simply be something left over, or not fully implemented - but whatever it is, it isn't a check for if an item can mine a block effectively or not outside of pickaxes.
Some name proposals:

hasProperLevel
correctMiningLevelFor
pickaxeCanMine
isProperToolMaterial
canMineIfHandFails
miningOptsForTool
hasCorrectLevelFor

(Mining)Level is used as it implies that the check is only for blocks/tools that have an associated mining level of which they must be broken by in order to obtain drops, implicitly invalidating it from consideration in regards to non-tool items, shears, shovels, and the like of which normal gameplay does not place tool material requirements.

The ultimately gets called through ItemStack by PlayerInventory's isUsingEffectiveTool, which then maps to PlayerEntity's isUsingEffectiveTool, which is then used by Block and BlockState for calcBlockBreakingDelta, DoorBlock for dropping items in onBreak, and something in ServerPlayerInteractionManager's tryBreakBlock
The naming in PlayerEntity makes sense as it also checks if the block can be broken by hand (and seems to indicate the naming was about the blocks dropping items or not), so those names (from PlayerEntity onwards seem fine).
For clarity on what "effective" implies in these cases:

using this tool will drop an item

this fails for axes on logs, shovels on dirt, gravel, or sand, and shears on vines and other foliage (it returns false in those cases). Works for pickaxes, and sword's special behavior with cobwebs

using this tool will increase the speed of breaking

returns false for shears on wool, axes on logs, etc

using this tool will do some special logic

this works somewhat in that shears return true for tripwire, and pickaxes perform the check for mining level, but fails as it returns true for shears on redstone wire of which there is no special behavior, true for shovels on snow blocks,

The fact that wood doesn't return true is because the method only needs to return true if the material of the block requires tool.
This behavior can be called "harvest" as in its run it drops the loot table, or "mine" because it increases mined stats. Maybe we should use isMiningTool/isHarvestTool and note that if the material of the block requires breaking tool and the tool is improper, the breaking of the block is not counted towards mining stats and will not drop the loot table

~canSpeedUpBreaking~ /s

doesn't relate to breaking speed as i see

hasMiningLevelFor
Example: stack.hasMiningLevelFor(Blocks.IRON_ORE.getDefaultState());


Machine classes

According to the Pokemon documentation here : https://pokeapi.co/docs/v2#machines-section
Create all classes needed for this call.

[x] Classes
[x] Architecture file convention
[x] Documentation

Machine are implemented whit #27.


Android Support Libraries Missing

Hey Darryn,
First I want to thank you for being so attentive with this plugin.  It has been very helpful.  I was running into an issue with my builds when I tried on one of my apps without Androidx, installing your v1.3.0.  I was missing the old support libraries which are needed in some of your files.  I got past it as I happened to need it for my other files as well, so I added to my plugin.  But others who don't otherwise have these support libraries added will likely get errors.  I believe you should only need to add back the following to your <platform name="android"> tag in your plugin.xml, which was recently removed, to solve it.
<framework src="com.android.support:support-v4:27.1.0" />

Take a look at it and let me know what you think.
FYI, I am trying to make a switch to using https://github.com/dpa99c/cordova-plugin-androidx-adapter to cover these and all other androidx support cases if I can, so yours and other plugins that don't need to be updated don't have to.

Hi @cabaird , I am looking at the plugin.xml source code for v1.3.0 and it looks like that framework line is already present.  Am I missing something?
https://github.com/darryncampbell/darryncampbell-cordova-plugin-intent/blob/160def5f8698f24d5ad83cb0d5b1ff6f60911f96/plugin.xml#L42

Nope.  Apparently I'm the one that's missing something.  I'm not sure what I was looking at.  My apologies.  Maybe I'm having issues with mismatching versions of these or something.


Related results not stable on same ranks

I'm currently doing some diff checking on the Hugo Docs site to make (pretty) sure I have not broken anything with my 0.55 fixes/changes, and I get some annoying diffs in the See Also sections. I have not looked closely, but I assume that these are matches that have equal weight.

I have checked, and this is the Less function used for sorting:
func (r ranks) Less(i, j int) bool {
	if r[i].Weight == r[j].Weight {
		return r[i].Doc.PublishDate().After(r[j].Doc.PublishDate())
	}
	return r[i].Weight > r[j].Weight
}

We need an additional tiebreaker to the above.


Create CI/CD to auto sync docs runner

Create a github workflow to handle the task of updating new code for docs-runner if the main branch is updated.

Done!


Programmatically fire quicksearch

Dear all,
I want to programmatically fill the Quicksearach input field and then fire the search.
Filling the quicksearch input box is no Problem. The Problem Comes with firing the search itself.
I have the following code, in XYZgrid.ts, which successfully fills the field but is unable to trigger the search Event:
protected onClick(e: JQueryEventObject, row: number, cell: number): void {
            // let base grid handle clicks for its edit links
            super.onClick(e, row, cell);

            // if base grid already handled, we shouldn"t handle it again
            if (e.isDefaultPrevented()) {
                return;
            }

            // get reference to current item
            var item = this.itemAt(row);

            // get reference to clicked element
            var target = $(e.target);

            if (target.hasClass("Location-link")) {
                e.preventDefault();

                // *** Get clicked text ***
                var bla = target[0].innerText;

                var qs = $(".s-QuickSearchBar").find(".s-QuickSearchInput");

                qs.val(bla);
                qs.focus();
                qs.trigger(jQuery.Event('keypress', { keycode: 13 }));

            }
        }

The idea is to fill the quick search input field with the text of a klicked link within the grid (following Volkan's basic samples) and then fire a search on this value.
Actually, I try to emulate a keyboard entry on the field with pressing "Enter".
Edit: After some Research, it seems that entering key strokes into a Input text field programmatically is suppressed for security reasons.
Therefore how can I trigger the quicksearch programmatically?
Thanks for your help and
With Kind regards,
John

Change trigger in
qs.trigger(jQuery.Event('keyup', { keycode: 13 }));

Hi Estrusco,
wow - it works :-) Who would think that keyup works and keydown not.
Thank you very much and
with Kind regards,
John

but I want to press enter key on button.
https://github.com/jan-molak/serenity-js/issues/238
Please help me if you have any solution


Cannot get the engine

Hello ! Thanks for a great project.
However, i wrote an app that works on my machine(tm), but fails to start on the production server.
It throws EngineNotAvailable without any additional information.
I cannot find any info about this exception in the docs.
Can you point me where should i dig ?
Thanks !

Usually that's related to permission issues. Please verify that your application has write access to the /tmp. And, you may join the discord to discuss with me in realtime.

So... i added logs, and figured out that libc on prod server is 2.27, and javet is built with 2.29.
Maybe consider linking native libraries with static libc ?
For now feel free to close the issue, i'm going to trying build native library with 2.27.

hs_err_pid72563.log
Sorry for bumping this topic again, but i built javet on ubuntu 18.04 following the guide, but it crashes.
Maybe you seen this error before / there are other things to consider when building ?

It's very strict to use the function cache.

Same V8 version
Same OS env
Same CPU arch
...

May I know if you tried to load a function cache generated in another env?

I'm just trying to load and executre a script in NodeJs env.
I don't know if underlying caches are involved. Maybe javet uses some type of cache storage by default that i should clear?

I see. It seems your build is corrupted. You may consider using some legacy Javet builds that are friendly to Ubuntu 18.04.

Would you kindly point me to the right one? I've had tried 1.1.7 with no luck.
Also maybe a page with compatibility info should be updated?
Thank you !

Sorry, I don't have enough time testing every Linux distributions. In general, the older the release is, the better compatibility does Javet have.


Inputs into PolarNet

PolarNet seems to take in a 9-dimensional feature vector as an input; could you clarify what these 9 features are?
Based on spherical_dataset in ./dataloader/dataset.py, my guesses are --

return_xyz: (3 features) [**not too sure what this is**]
xyz_pol: (3 features) original x, y and z coordinates converted to radius, angle and z, size [num_points, grid_size_r, grid_size_theta, grid_size_z]
xy: (2 features) original x and y coordinates, size [num_points, 3]
sig: (1 feature) reflectance, size [num_points, 1]

Are my guesses correct / wrong? Thanks!

return_xyz is the residual distances of points from the center of the assigned grid.

Thanks for your clarifications, @edwardzhou130! Why do you choose to input so many variations of spatial representation (return_xyz, xyz_pol, xy) instead of just, for example, xyz_pol and reflectance?

Hi @polars05 ,
Thanks for asking and very insightful questions. return_xyz (not even reflectance) is all you need if you only need to set up a decent baseline. We found additional seemingly-redundant  xyz improve 0.5% mIoU (c.f. 9F in Table 5 in our paper). This trick is also used in SqueezeSeg papers and we are inspired by them.
Also, you can replace sig with your customized features (RGB + reflectance/ RBG only/ nothing at all).

Hi @YangZhang4065, it was a very interesting paper, and hence my curiosity / questions 😄
To clarify that my understanding of return_xyz ("residual distances of points from the center of the assigned grid" as mentioned by @edwardzhou130) is correct, is this what it means?:

Is so, why not convert the points and grid to polar coordinates first, and then use the residual distances in the polar space instead?

@polars05, sorry for the confusion caused by the name. I used the same name return_xyz in both voxel_dataset and spherical_dataset class, despite return_xyz in spherical_dataset is actually the distance in the polar space.
https://github.com/edwardzhou130/PolarSeg/blob/73488e8fe3ea9505d2822232ac5e814530c3c724/dataloader/dataset.py#L239-L247

Thanks for clarifying my confusion! And residual distances refer to the l1, l2, l3, etc. in my above diagram?


WSO2 AM deploy error java.net.NoRouteToHostException: No route to host (Host unreachable) on Centos7 Server

I'm using AM 2.6.0. When I deploy in PC using Window everything OK. But when I deploy it on Centos7 Server it has error below https://i.stack.imgur.com/xjYVR.png. I try config as the following docs https://docs.wso2.com/display/SP430/Installing+as+a+Linux+Service but still has this error.
Please let me know if you have any other solutions in my case. Tks all!

Hi @TrugNIng
The reason for this error in the startup is that Qpid server hasn't bound to the port 5672. There may be some firewall rules bound with the Centos server which causes to block this port.
When you see the above exception, without shutting the server down, could you please check whether any process bound to the port 5672?


tour: this is not a random sequence: 1, 1, 1, 1, 1, 1, ...

Context: https://tour.golang.org/basics/1
See subject.

See text on that page:

Note: The environment in which these programs are executed is deterministic, so each time you run the example program rand.Intn will return the same number.

as explained a few lessons earlier:

This makes it easier to cache programs by giving them deterministic output.

@ALTree  this text does not display in the offline version of the tour.
It is still not a random sequence in the offline version, so that should be updated


Fix System.ObjectDisposedException in Crash Group # 3

Version 1.0(1)
Stacktrace
Reason
System.ObjectDisposedException
Link to App Center

https://appcenter.ms/users/butvinik/apps/azure-storage-browser/crashes/groups/aeeab7fb64b01772faa34f817fef2d63f760ddd9

fixed with #31


iOS badge not visible

Summary
Notification badges are not appearing randomly. Notifications are displaying normally in the notification center.
Environment Information

Device Name: iPhone
OS Version: iOS 17.0.3
Mattermost App Version: 2.9.0 (Build 489)
Mattermost Server Version: 9.1.0

Steps to reproduce
Sometimes I see the badge when I get a notification, but more often it doesn't show up.
Expected behavior
Show badge icon.
Observed behavior (that appears unintentional)

Opened https://mattermost.atlassian.net/browse/MM-55131.

@baek-sang Thank you for your report. Let me ask a few question to figure out what is going on.

The notifications you receive imply a mention? (i.e. they have an @mention or are in a DM)
Is there any chance the message is being read in a different client? (e.g. on desktop or the web browser)

I have the same issue.


Lab 4: Errors with filter function

@gmcirco I keep getting these errors when I try to "Run Document" for Lab 4:
In the Viewing page for the document output the error codes read:
Problem with `filter()` input `..1`.
ℹ Input `..1` is `name == dat.one.team`.
x Input `..1` must be of size 2340 or 1, not size 105.

In the Console's R-Markdown tab it reads:
Warning: Error in : Problem with `filter()` input `..1`.
ℹ Input `..1` is `name == dat.one.team`.
x Input `..1` must be of size 2340 or 1, not size 105.
  185: <Anonymous>

Here are what my lines of code that include the filter () function look like:
team.name <- input$my_team
dat.one.team <- filter(Teams, name == team.name)  # Filtering to include only selected team

Teams$ave.so <- Teams$SO / Teams$G
one.team <- filter( Teams, name == dat.one.team )
points( x= one.team$yearID, y= one.team$ave.so, type="b", pch=19, col="darkorange4" )

What do these error messages mean and how do I fix them? Help would be greatly appreciated!

You might need to provide your whole code. The error is referring to an issue with your name filter. I think there might be a problem with the Teams data.

@gmcirco
Would you like me to include all my code in here or just email you my RMD file?

That is probably the best option - yes.


View train loss

I used TensorBoard and saw val_classification and val_bbox_regression.
How should I view the train loss after the model training is completed?
Thank you for taking the time to answer my question.

I am wondering whether this is an issue on my end or are there any adjustments I need to make?
I hope you can help me answer my question, thank you.

Please use issues for bugs or requests for new features. For general discussion, please create a discussion and outline a much fuller example and question. Not enough information here to help.


Message object examples facet has a wrong type

Issue part of #397
It’s an array of Maps, it should be only a Map. Message trait objects have the same problem.
https://github.com/asyncapi/asyncapi/blob/master/versions/2.0.0/asyncapi.md#message-object
https://github.com/asyncapi/asyncapi/blob/master/versions/2.0.0/asyncapi.md#message-trait-object

Hi. Why examples should not be an array. The description is clear that it should be an array, schema too https://github.com/asyncapi/asyncapi/blob/master/versions/2.0.0/schema.json#L692. Or you have something different in mind?

Hi @derberg, if examples is an array it is wrongly expressed. Imagine a payload schema of type string only. How would the examples be expressed with the syntax as it is today? An array of map from string to the example (the message object with a json schema):
payload:
  type: string
examples:
  -  someName: theExample
  -  someOtherName: anotherExample
      otherNameItemInThisArrayItem: lastExample

If we want examples to be named, the type should be only a map of string to the example, so that names are not repeated and we don't have the confusion happening in the previous example (exactly as OAS and RAML do this):
payload:
  type: string
examples:
  someName: the Example
  someOtherName: anotherExample
  otherNameItemInThisArrayItem: lastExample

This is the correct approach using the examples keyword, just remove the array around the Map in the examples type.

I think what's wrong here is to say that it should be an array of Maps. It actually should be an array of "any". So to compare with your example, @gutee, it should be:
payload:
  type: string
examples:
  - the Example
  - anotherExample
  - lastExample

This should be fixed on the human-readable spec and also on the machine-readable spec. It would be great to take the opportunity to mention that whatever "any" is, it has to match the type defined on payload.


feat(storage)!: reduce remove_blocks IO

BREAKING: A new column family is required now - full_block_ids

it's a huge win


M5Stack CoreS3 is a supported device on framework ESP-IDF ?

I try to build M5GFX on Ubuntu 22.04 , framework ESP-IDF v5.1  device target esp32s3 but the build crash .
M5Stack CoreS3 is a supported device on framework ESP-IDF ?
Thanks !

I have never worked with M5GFX and ESP-IDF in combination.
Now I need M5Unified and M5GFX on ESP_IDF v5 framework because I want to run micro_ros_espidf_component on M5Stack CoreS3 .

If you are considering using M5Unified for the first time with ESP-IDF, the following repositories and issues may be helpful.
https://github.com/hp27596/m5core2idfdemo
https://github.com/m5stack/M5Unified/issues/42
In addition, please note the following

The components to be used must be described in CMakeLists.txt file.
M5Unified and M5GFX are C++ libraries and cannot be used from .c source.

Sorry !
I built M5GFX without M5Unified and build it's OK !
M5Unified it's my problem.

I am glad to hear that you have not had any problems with M5GFX.
If you have problems with M5Unified, please write another Issue in the M5Unified repository.
However, maybe M5Unified is still not buildable with ESP-IDF v5.1...?

Thanks  @lovyan03 !


why is it not working after run "ng build -prod"

why is it not working after run "ng build -prod". i deploy it on prod mode it do not work on production mode. working file in "ng serve".

dupe of #10

Fixed by #15.
Please check and confirm


Unresolved dependency: com.lendup.fs2-blobstore#core_2.12;0.3.0

I can't find the the 0.3.x releases of the project.
Tried with:
com.lendup.fs2-blobstore" %% "s3" % "0.3.0" // "0.3.+" // "0.3.0-SNAPSHOT"

No luck with any of them..
I browsed the maven repository and found there is no 0.3.0 version yet. However I could find an SNAPSHOT in sonatype is this intended? do I need to add the sonatype snapshots repository to use the 0.3.0 version?
I am really needing it, because I am having troubles uploading some big files to S3 - and the latest release states this is now possible.
Thanks in advance for the help.

Thanks! - it worked for me too!
PS: I noticed that the 0.3.0 release is only published for scala 2.12 - for me that is enough since I use scala 2.12 on all of my projects...
But I'm sure there are folks who still need the 2.11 release, and I can see in your build.sbt file that you are still doing crossBuild. Thus, I'm sure you are still having some troubles with it, hope you can fix it :+1:
I'm closing this for now since my problem is resolved, thanks again!


⚠ Adam Brand Music has degraded performance

In fb57576, Adam Brand Music (https://adambrandmusic.com) experienced degraded performance:

HTTP code: 200
Response time: 6346 ms

Resolved: Adam Brand Music performance has improved in 20300e1 after 14 minutes.


fix: Make chip not clickable while fetching events

Detail:

A clickable flag inside SearchViewModel is used to check whether chip should be clickable or not.
Change id name of chip in XML file

Fixes: #1544
Screenshots for the change:
When loading, those chips card are not clickable any more

resolved


GHAzDO scanning does not find target branch main

Hi has anyone a idea why on one of my projects the targetbranch is not found.
URI : https://advsec.dev.azure.com/COMPANYNAME/PROJECTNAME/_apis/Alert/repositories/REPOGUID/Alerts?top=500&orderBy=lastSeen&criteria.ref=refs/heads/main&criteria.states=1
There are no GHAzDO results on the target branch, wait and try again.

If i try the call with postman i get this error
{
"$id": "1",
"innerException": null,
"message": "The branch does not exist",
"typeName": "Microsoft.VisualStudio.Services.AdvancedSecurity.Alerts.BranchNotFoundException, Microsoft.VisualStudio.Services.AdvancedSecurity.Server",
"typeKey": "BranchNotFoundException",
"errorCode": 0,
"eventId": 3000
}
Branch name main exists, repo guid is ok. I cannot find any error. In another repo in the same project it works fine with the same PAT token.

Ok found the problem. If you have never run a security check on the main branch, the script will fail at this line because you will get a branchnotfoundexception.
while ($retries -gt 0) {
    try {
        $alertsPRTarget = Invoke-WebRequest -Uri $urlTargetAlerts -Headers $headers -Method Get -ErrorAction Stop
        # Success
        break
    }

Perhaps the catch block can be changed to skip the error? Is it possible that the target branch may not exist when the script is run from a pull request?
catch {
        # No GHAzDO results on the target branch, wait and retry?
        if ($_.ErrorDetails.Message.Split("`"") -contains "BranchNotFoundException") {
            $retries--
            if ($retries -eq 0) {
                # We have retried the maximum number of times, give up
                Write-Host "##vso[task.logissue type=error] We have retried the maximum number of times, give up."
                throw $_
            }

            # Wait and then try again
            Write-Host "There are no GHAzDO results on the target branch, wait and try again."
            Start-Sleep -Seconds 60
        }


Helm rollback fails when the deleted resource is created manually

Helm rollback is failing when a resource is created manually which existed in the previous release (before the upgrade) but not in the current version.
Steps to reproduce:

Create a helm release with just a configmap in the chart.

kind: ConfigMap
metadata:
  name: {{ .Release.Name }}
  namespace: {{ .Release.Namespace }}
data:
  key1: {{ .Values.key }}

Do a helm release.
Remove the configmap from the chart and replace it with a secret:

apiVersion: v1
kind: Secret
metadata:
  name: {{ .Release.Name }}
  namespace: {{ .Release.Namespace }}
data:
  key: {{.Values.key | b64enc}}

Do helm upgrade
Create the same CM with the same name/namespace manually
helm rollback <RELEASE_NAME> 1 fails.
Again helm rollback <RELEASE_NAME> 1 is success but now the secret is not deleted, although configmap is created.

Stacktrace when using --debug:
helm.sh/helm/v3/pkg/kube.(*Client).Update.func1
	helm.sh/helm/v3/pkg/kube/client.go:413
helm.sh/helm/v3/pkg/kube.ResourceList.Visit
	helm.sh/helm/v3/pkg/kube/resource.go:32
helm.sh/helm/v3/pkg/kube.(*Client).Update
	helm.sh/helm/v3/pkg/kube/client.go:386
helm.sh/helm/v3/pkg/action.(*Rollback).performRollback
	helm.sh/helm/v3/pkg/action/rollback.go:172
helm.sh/helm/v3/pkg/action.(*Rollback).Run
	helm.sh/helm/v3/pkg/action/rollback.go:79
main.newRollbackCmd.func2
	helm.sh/helm/v3/cmd/helm/rollback.go:69
github.com/spf13/cobra.(*Command).execute

Output of helm version: version.BuildInfo{Version:"v3.12.1", GitCommit:"f32a527a060157990e2aa86bf45010dfb3cc8b8d", GitTreeState:"clean", GoVersion:"go1.20.5"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3", GitCommit:"25b4e43193bcda6c7328a6d147b1fb73a33f1598", GitTreeState:"clean", BuildDate:"2023-06-14T09:47:38Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"darwin/arm64"} Kustomize Version: v5.0.1 Server Version: version.Info{Major:"1", Minor:"24+", GitVersion:"v1.24.16-eks-2d98532", GitCommit:"af930c12e26ef9d1e8fac7e3532ff4bcc1b2b509", GitTreeState:"clean", BuildDate:"2023-07-28T16:52:47Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): AWS

Two things I think there.
First:

helm rollback <RELEASE_NAME> 1 fails.

This is expected. helm rollback is just the same as helm upgrade, but it utilizing the stored manifest from the prior install/upgrade. And just like helm upgrade or helm install, Helm will fail if a resource already exists.

Second:

Again helm rollback <RELEASE_NAME> 1 is success but now the secret is not deleted, although configmap is created.

Are you saying if you simply re-run helm rollback .. again, it will succeed? Or, did you delete the configmap in the interim?

Are you saying if you simply re-run helm rollback .. again, it will succeed? Or, did you delete the manually created configmap in the interim?
The rollback would succeed, without deleting the configmap. But the secret will now not be deleted too, even if rolled back to version 1, in which the secret didn't exist.

This is expected. helm rollback is just the same as helm upgrade, but it utilizing the stored manifest from the prior install/upgrade. And just like helm upgrade or helm install, Helm will fail if a resource already exists.

The error (before the stacktrace) :
rollback.go:176: [debug] warning: Rollback "ragrover-rollback" failed: no ConfigMap with the name "ragrover-rollback" found
Why does it say not found, it ideally should say that it can't take the ownership of that because the Configmap doesn't have helm ownership annotations and labels.
The rollback wont work even if the configmap is created manually with helm annotations/ labels, according to the reason you mentioned it should.

I have the same problem. I think the title of this issue is incorrect. It should be: "Helm rollback fails when the deleted resource already exists".
If you install a failed release R+1 : This release is supposed to make changes to resources installed in release R and delete a resource installed in release R.
If the installation of release R+1 fails before Helm can delete the resource to be deleted, when you rollback to release R, you will get the error message: "no %s with the name %q found"
(https://github.com/helm/helm/blob/v3.12.3/pkg/kube/client.go#L381)
The problem is when you encounter this error, Helm stops the rollback and does not process the remaining resources to be processed.
I think this error should not be blocking and let Helm continue to process the remaining resources.
The case of @ra-grover is approximately the same (the deleted resource has been created manually. This is not the case in my situation) : Helm is supposed to recreate the configmap, but since it already exists it will try to update it... but since Helm cannot obtain the original definition of the configmap, it fails and does not delete the secret.

Does anyone know the reason to throw a blocking error if the resource exists in Kubernetes but does not exist in the rollback source release?
I think there may be several solutions:

the error should not be blocking
If the resource exists in Kubernetes but not in the rollback source release, we retrieve the definition of the resource directly from Kubernetes
like "helm install", "helm rollback" might be able to re-adopt resources

Any updates on this issue ?

If you install a failed release R+1 : This release is supposed to make changes to resources installed in release R and delete a resource installed in release R.
If the installation of release R+1 fails before Helm can delete the resource to be deleted, when you rollback to release R, you will get the error message: "no %s with the name %q found"
(https://github.com/helm/helm/blob/v3.12.3/pkg/kube/client.go#L381)

Thanks for the clear explanation. Let me try and find some cycles to confirm. And mark as a bug if I can confirm the above.

Hi @gjenkins8 I am also facing the same issue when helm upgrade fails at a point where K8s resources which are supposed to be deleted (but not actually deleted by helm) and subsequent helm rollback fails with above error (no %s with the name %q found). So this is no more a support/question and should be triaged as bug. Is there any plan to this issue based on the proposal from @tizard34?

Just flagging a possibly similar(?) issue when using the "helm.sh/resource-policy" annotation in the linked issue (https://github.com/helm/helm/issues/13142) - in that case, the resource wasn't 'manually created' per se, but was left existing in the cluster after a successful release due to the annotation.


Align Angular test.ts config

Pull Request
🤨 Rationale
Align the test.ts config and stop overriding the destroyAfterEach default property across the Angular projects.
Context was this AzDo discussion.
👩💻 Implementation
Copy and paste.
🧪 Testing
Rely on CI.
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 poke


Add Xavier as approver

we never want just a single active approver on a repo, so adding @xrajesh for coverage.
/assign @syedriko

need to merge https://github.com/openshift/lightspeed-rag-content/pull/45 first to sync up plaintext docs with the website

/approve
/lgtm

/override "Red Hat Konflux / lightspeed-rag-content-on-pull-request"


feat: introduction of devshell

This PR introduces devshell rather than using mission-control

@selfuryon I chose devshell as it's quite similar to mission-control but removes extra mambo jambo that regular mkShell introduces into the system variables when loading the dev environment.
And why not devenv? Mostly it's a personal preference, I do believe it introduces too much that, probably, we won't need in the near term. We don't need features like processes, languages, containers, etc. Even if we do someday, I prefer to incorporate more fine-grained tools like process-compose or another similar tooling. I prefer to favor the Unix philosophy (do one thing very well).
Also with devshell I can optimize the repository much faster if necessary as I'm working with Numtide (the owner of the repository) these days.
As with everything, it's not set in stone, so we can evaluate at a later date another tool that suits us better (even devenv, I'm not excluding it by any means). I'm always open to exploring new ideas.

@aldoborrero can you sign the commits?

Mmm, it seems hercules-ci is behaving weirdly today...


Bad-looking C code generated

Currently pycrc generates bad-looking C code like this:
for (i = 0; i < 32; i++) {
    bit = crc & 0x80000000;        crc = (crc << 1) | 0x00;

This bug was introduced in 0.7.9. The parser eats newline characters
after block delimiters, so a double-newline is necessary. This patch
fixes it.

Actually, I would prefer a different fix for this bug. The empty line could be avoided by placing the semicolon out of the macro blocks {: ... :}, something like this:

bit = $if ($c_std == C89) {:!!(crc & $cfg_msb_mask);:} $else {:crc & $cfg_msb_mask;:}

bit = $if ($c_std == C89) {:!!(crc & $cfg_msb_mask):} $else {:crc & $cfg_msb_mask:};

Can you rework your pull request to change this please?
Thanks a lot.
PS: yes, I know the macro language I've come up with is a bit simplistic/unflexible/crap/you-name-it, but one important goal for pycrc was that running it must be as painless as possible, so I did not want to include dependencies on external code generators.

Good idea, I pushed a new commit to my fork.
(I was trying to think of prettier ways to solve the problem, but couldn't think of that)


Detected indentation should take precedence over useSpaces preference

@alexandrudima We're not bad at detecting indentation. We're bad at respecting it.

Our useSpaces setting always takes preference, regardless of detection. That setting should only be respected when the detection is inconclusive (e.g. a blank file, a mixed indentation file etc.). Having it set to true, opening a tabbed file and have spaces being inserted when automatically indenting is wrong.

I half agree :).
I think this is the first time we need to distinguish between user settings and workbench settings.
If insertSpaces = false in a workspace, then it means that for no reason whatsoever should spaces be inserted.
If insertSpaces = false in the user settings, then you could argue that in case autodetection fails to get sufficient hints, it could be used as the fallback value.

What would happen to a workspace with insertSpaces set to false, just as our own, and suddenly someone puts a perfectly valid YAML file in there? YAML files consider tabs to be syntax errors. Should I jump to Sublime Text every time I want to edit that file?
IMO there are a few issues here:

a file's indentation should always be detected and respected, regardless of any setting
if detection is inconclusive, be that due to mixed indentation or to lack of it, the setting should be taken into account for the decision
insertSpaces should be a boolean setting. auto makes no sense at all to me
insertSpaces is ultimately a bad name. It should be something around preferSpaces, preferredIndentation, defaultIndentation, etc

@isidorn this is what I mean

I want wrapping for .txt files and not for other files.
I want Arial for .txt files.
IMHO the YAML example you give is arguing for per-file settings, which, I definitely agree, is something we should have.

Both wrapping and font are view-only attributes. Neither can they be determined by the syntax of the file nor can they affect the syntax itself. Per-file view settings are another feature altogether.
Indentation is not. It is strongly bound to the file's syntax. A change in indentation character actually changes the file's contents.
But let me pick up another argument.
The indentation problem is exactly the same as the end-of-line problem, at which we do an almost perfect job:

We either show LF or CRLF in the status bar, always indicating what line endings the current opened file has.
When the user presses Enter in a file, that value is respected. The detection itself defines the end-of-line character to use.
Switching to another file with another end-of-line sequence will update this value.
Switching the value itself will modify the file's contents.
We are almost perfect simply because there isn't a configuration setting for the default case. But we do have a pretty good heuristic: the OS itself.

Ok, I really like the analogy with LF/CRLF detection. I'm sold!

For this we should use the detection algorithm in
https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/model/textModel.ts#L461
And set the editor to whatever it returns.

This should also be done in the exact same way we detect EOL and encoding. @bpasero where and how do we do it?

@joaomoreno we currently only detect encoding using BOM on the file service layer. Not sure about EOL.

I am marking this important because of https://github.com/Microsoft/vscode/issues/3656 which is very confusing otherwise.

:+1:

Fixed by @alexandrudima


multiprocessing.fork breaks PyTorch autograd

Python version: 3.6.5
AutoGluon version: 0.0.11
PyTorch version: 1.5.1
I'm using an Autogluon HyperbandScheduler to do neural architecture search. I'm running into trouble executing jobs on a multi-node cluster due to this error thrown during a backwards call.
RuntimeError: Unable to handle autograd's threading in combination with fork-based multiprocessing.
See https://github.com/pytorch/pytorch/wiki/Autograd-and-Fork.

Reading the linked issue, it seems like PyTorch supports the use of multiprocessing.spawn but not multiprocessing.fork. Does fork support some feature that spawn does not? Is there a known workaround?
--

@zhreshold Could you take a look?

I'm working on a minimal example to reproduce the issue. My use case is something like this
import multiprocessing as mp
import torch
import autogluon as ag
import yaml
import hydra
import os
import time

@ag.args(x0=ag.space.Categorical('a', 'b', 'c', 'd', 'e'),
         x1=ag.space.Categorical('a', 'b', 'c', 'd', 'e'),
         x2=ag.space.Categorical('a', 'b', 'c', 'd', 'e'),
         epochs=32)
def train_fn(args, reporter, **kwargs):
    x = torch.rand(1)
    x = x.cuda() if torch.cuda.is_available() else x
    x.requires_grad = True
    optimizer = torch.optim.SGD([x], lr=1e-2)
    for i in range(args.epochs):
        loss = x ** 2
        loss.backward()
        optimizer.step()
        print(f"--- iteration: {i+1}, x: {x.item():.4f} ---")
        time.sleep(2.)
        reporter(epoch=i+1, objective=-loss.item())

@hydra.main(config_path='../hydra/main.yaml')
def min_example(cfg):
    num_cpus = mp.cpu_count()
    num_gpus = torch.cuda.device_count()
    host_file = os.path.join(hydra.utils.get_original_cwd(), 'hosts.yaml')
    with open(host_file, 'r') as f:
        dist_ip_addrs = yaml.full_load(f)

    scheduler = ag.scheduler.HyperbandScheduler(
        train_fn,
        resource=dict(num_cpus=num_cpus, num_gpus=num_gpus),
        search_options=dict(first_is_default=False),
        dist_ip_addrs=dist_ip_addrs,
        searcher='random',
        grace_period=1,
        reduction_factor=2,
        num_trials=32,
        time_attr='epoch',
        reward_attr='objective',
        type='promotion',
    )
    scheduler.run()
    scheduler.join_jobs()

if __name__ == '__main__':
    min_example()

Strangely enough, this example works fine, but when I replace my dummy train_fn with actual model training code, the error I mentioned gets thrown. As far as I can tell, it seems to work fine when the train_fn call happens on a worker, and fail when the train_fn call happens on the main node.

I guess it's related to https://github.com/awslabs/autogluon/issues/602

Thanks for the tip! In my case, I was saving and loading model checkpoints from S3 inside my train_fn to halt/resume training. Doing the checkpoint saving/loading on CPU appears to have resolved my issue.


Updated dependencies.

I'm using this library with Scala 2.13.10 and ZIO 2.0.13 and I get the following error when compiling:
[error] Symbol 'type zio.prelude.Newtype.Type' is missing from the classpath.
[error] This symbol is required by 'type nl.vroste.zio.amqp.model.ExchangeName'.
[error] Make sure that type Type is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'package.class' was compiled against an incompatible version of zio.prelude.Newtype.
[error]       _ <- channel.exchangeDeclare(
[error]            ^

Updating the dependency versions of zio and zio-prelude resolved my issue.
I also went ahead and updated other dependencies for the sake of completeness.

Sorry, I didn't notice your PR until I was already making some dependency updates, all changes are incorporated in #323 now.
Thanks for the PR though. I will make a new release shortly.


not detecting circular dependencies with require-directory

OS: Mac OS X 10.12.6
Node.js: 10.15.0
npm: 6.4.1
madge: 3.3.0
require-directory: 2.1.1
When I use madge with require-directory, it doesn't detect circular dependencies.
Example repo: https://github.com/oprogramador/madge-not-working
See this build https://travis-ci.org/oprogramador/madge-not-working/builds/473994109

Hi guys, any news?

Sorry, we're not going to support. This tool can only compute dependencies by using static analysis and require-directory breaks that.


ci: added github attestation to build assets

added github attestation to build assets,
users will be able to prove that the assets were downloaded from github using
gh attestation verify PATH/TO/YOUR/BUILD/ARTIFACT-BINARY -R Yubico/Yubico.NET.SDK
gh attestation verify PATH/TO/YOUR/BUILD/ARTIFACT-BINARY -O Yubico

fyi @dainnilsson


[ffigen] Migrate method filtering to the visitor

Fixes #1595
Fixes #1594

coverage: 91.389% (+0.07%) from 91.316%
when pulling 06d86a1f27f4c1a9f27a1be3572c1938513ce5f3 on methodvisitor
into 8a8603b7e94f300157ca8d1f68ee07147c29b1e2 on main.


More minor DotNet / NuGet related clean-ups

Please have a look at the individual commit messages for the details.

This change is

/cc @neubs-bsi


QueueClient.Send never returns, and never sends message

Here's what I do:
var queue = QueueClient.CreateFromConnectionString(connectionString, QueueName);
using(var bodyStream = new MemoryStream())
{
	this.taskSerializer.WriteObject(bodyStream, contentObject);
	bodyStream.Flush();
	bodyStream.Position = 0;
	BrokeredMessage message = new BrokeredMessage(bodyStream);
	message.ContentType = "application/json";
	message.Properties["time"] = DateTime.UtcNow;
	tasksQueue.Send(message);
}

The last Send never returns, and nothing is sent to the queue.

I just checked in simple console app, and issue does not seem to repro. It reproes, however, in ASP.NET app. Let me build a minimal repro.

Basically, it hangs, when it runs in async Controller method. I wrapped it into Task.Run, and it passes successfully now. Will provide a repro sometime later.

It's a normal behavior due to underlying implementation of AMQP .Net Lite library.


GET report_endpoint

Report page to display questions from database
BDD testing to check for displayed questions

Use requests.get('http:localhost:port/api/route') to connect to the backend API, then check if the status code is 200 before getting the data out of the response to create the form.
** this is only to view the report form - this is not to get data from the form yet.
Create questions page for GET request

use questions from the BE to load in the FE
correctly display the report questions in the correct format
test the GET page to display the data using a request to the BE questions route (same BDD testing as questions_route but questions_endpoint)

@QuestionsEndpoint
Feature: Test Questions Endpoint

    Scenario: Load questions from Backend to Frontend Endpoint Using GET request
    Given the questions_endpoint is running
    When a GET request is made to the questions_endpoint
    The questions should be displayed in the correct format.


Inconsistent support of log2

Reporting a bug
The cpu platform supports np.log2 but not math.log2. The gpu platform supports math.log2 but not np.log2. This makes it impossible to maintain library routines using log2 that are called on both platforms.

[x] I have tried using the latest released version of Numba (most recent is
visible in the release notes
(https://numba.readthedocs.io/en/stable/release-notes-overview.html).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'.

import math
import sys

import numba as nb  # type: ignore
import numpy as np
from numba import cuda  # type: ignore
from numpy import typing as npt  # type: ignore

@cuda.jit
def log2_math_kernel(x: npt.NDArray[np.float64]) -> None:
    if cuda.grid(1) == 0:
        x[0] = math.log2(x[0])

@cuda.jit
def log2_np_kernel(x: npt.NDArray[np.float64]) -> None:
    if cuda.grid(1) == 0:
        x[0] = np.log2(x[0])

@nb.njit
def log2_math_cpu(x: float) -> float:
    return math.log2(x)

@nb.njit
def log2_np_cpu(x: float) -> float:
    return np.log2(x)

x = np.ones(1, dtype=np.float64)
if __name__ == "__main__":
    if sys.argv[1] == "gm":
        log2_math_kernel[1, 1](x)
    elif sys.argv[1] == "gn":
        log2_np_kernel[1, 1](x)
    elif sys.argv[1] == "cm":
        log2_math_cpu(x[0])
    elif sys.argv[1] == "cn":
        log2_np_cpu(x[0])

When running, options "gm" and "cn" run, "gn" and "cm" do not compile.
I am using 0.58.1 on python3.11.3, ubuntu focal.

I've submitted https://github.com/numba/numba/pull/9416 which partially fixes this issue for the CPU case.

Thank you!

CUDA support for np.log2 is here:
https://github.com/numba/numba/pull/9417


More API docs

embassy-cortex-m is covered now, making some progress on embassy-nrf, but not complete.

bors r+


cmd/portable-package: fix for Homebrew.args changes

Broke after Homebrew/brew#8144.
Also use safe_popen_read.

Thanks, @Bo98!