Make the Processing thread survive errors from messages

The processing thread needs to handle exceptions so it can survive the occurrence of an error when processing a message. The listener interface should probably also gain a "on_error" method that allows the library user to get notified when decoding a message fails for some reason.

Probably makes more sense to notify the Monitor interface (#21), not the Listener interface.

I think this should now be OK. Need some buggy messages to come through to be sure though.


[Enhancement] Support dynamic adjustment of four BE parameters

Why I'm doing:
The BE parameter cannot be adjusted dynamically and is inconvenient to use.
What I'm doing:
Supports dynamic adjustment of four be parameters, as shown below:

pipeline_connector_scan_thread_num_per_cpu
disable_column_pool
create_tablet_worker_count
number_tablet_writer_threads

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

@wyb @kevincai PTAL


uppercase mac address in requires results in "main: config: normalize MAC address ... to ..."

When bootcfg encounters an uppercase mac address in requires, it will print main: config: normalize MAC address ... to ... and exit(1).
This is very inconvenient. One would assume that bootcfg is able to do a simple uppercase -> lowercase conversion on the fly. Additionally, the error message is very misleading. I did not understand it is an error message for a very long time, assuming that bootcfg was normalising the mac address (as I had expected).
At the very least I would expect a "fatal error:" prefix and a message like: "MAC address ... not normalised, expecting ... instead".

Related to #25


Pwm implementation is missing for Alternate

Currently the Pwm implementation works only for Alternate.
I miss the implementation for Alternate, furthermore I was not able to figure out how to fix this.
Perhaps this Alternate abstraction should become independent of outputmode, and constraints should be changed where both are needed.

Hmm, from a quick skim of the datasheet, I don't see a reason for it being restricted to OpenDrain.
I believe the place where it gets set to PushPull is here: https://github.com/stm32-rs/stm32f1xx-hal/blob/master/src/pwm.rs#L111. Changing that PushPull to a generic parameter should fix the issue if I'm not misstaken

I think this issue can be closed. I am using PWM in OpenDrain-Mode and it works fine.
#358 even says that is fixed this issue.


Standalone year picker

First of all, thank you for this great project!
I'm currently building an app where it would be useful to not only have a date picker dialog, but also a standalone year picker dialog. I took a quick look at the code, and I think it might be possible to re-use YearSelection for creating a year picker dialog without much work.
What do you think?

Hello and thanks for the input!
As of now (for the 1.0.0 Milestone), the standalone year (or month) picker isn't planned. It might be implemented in the future, together with a standalone month picker - for a "complete set".


Fix strtoul test on alpine/musl

The strtoul tests that were recently added had a compile time check for __WORDSIZE to properly determine the string to use for an maximal unsigned long.  Unfortunately musl libc doesn't define __WORDSIZE so we were in a position where on that platform we fall to the 32 bit unsigned long variant, which breaks on x86 platforms.
Fix it by checking if __WORDSIZE is defined, and, if not, falling back to reliance on x86_64 being defined

Agreed.  I think we're in good shape at the moment, as we don't support wacom, but we need to watch out for that in the future

merged, thank you!


SA1302: InterfaceNamesMustBeginWithI

http://www.stylecop.com/docs/SA1302.html

grabbed

Can it be closed ? The implementation is merged (#357). We just need to add code fix (probably a separate issue ?).

:bulb: If you add a line like Fixed #xxx to the description in your pull request, it will close the associated issue automatically when the pull request is merged. :+1:


this.screen.screen is undefined / leaking Element / dangling set:resolution event handler

On browser resize, we're seeing:
TypeError: this.screen.screen is undefined playcanvas-stable.dbg.js:26924:13
	_calculateLocalAnchors https://code.playcanvas.com/playcanvas-stable.dbg.js:26924:13
	_calculateSize https://code.playcanvas.com/playcanvas-stable.dbg.js:26980:5
	_onScreenResize https://code.playcanvas.com/playcanvas-stable.dbg.js:26911:5
	fire https://code.playcanvas.com/playcanvas-stable.dbg.js:608:5
	set https://code.playcanvas.com/playcanvas-stable.dbg.js:26576:5
	_onResize https://code.playcanvas.com/playcanvas-stable.dbg.js:26562:7
	fire https://code.playcanvas.com/playcanvas-stable.dbg.js:608:5
	resizeCanvas https://code.playcanvas.com/playcanvas-stable.dbg.js:5848:5
	setCanvasResolution https://code.playcanvas.com/playcanvas-stable.dbg.js:20545:5
	resizeCanvas https://code.playcanvas.com/playcanvas-stable.dbg.js:20617:9
	reflow [...]

The statement is https://github.com/playcanvas/engine/blob/7f54ed08ca0615615d53146494778bf07c84279a/src/framework/components/element/component.js#L389
Exploring a bit:
The image element and this.screen in question appear to have been destroyed by a prior scene transition (entities have parents, but each parent has no children).
It seems plausible that the set:resolution event (which is what's being triggered in the upper fire in the stack above) needs to be offed.  This event handler looks like it is set up in framework/components/element/component.js in _updateScreen.
Not sure if there needs to be a destroy override or if it would suffice to do something like _updateScreen(null) in the onRemove handler?

(Apologies while I chase my tail a bit here; I can probably whip up a minimal repro case if this doesn't prove fruitful. =)
Looking further up the stack, perhaps it's actually the resizecanvas event that's the important link? I don't see the resizecanvas for ScreenComponent off'd either?
https://github.com/playcanvas/engine/blob/d0e2c802a37ae721b5b29117103a0e23e36781d0/src/framework/components/screen/component.js#L39

Thanks for reporting! Pushed a fix https://github.com/playcanvas/engine/commit/1f2d33a5a0daf112c4afe600f7f6d34a6aeec751

No longer getting the undefined error and I don't see ScreenComponent hanging around in heap snapshots after the scene.  Thanks!


How to fix a flickering effect when dragging onto an empty placeholder?

Hi,
As I mentioned in my question, when I start dragging a node onto an empty tree, its placeholder starts flickering and it's difficult to add a new node.
You can see such behaviour on the [demo page] (http://angular-ui-tree.github.io/angular-ui-tree/#/connected-trees) ("Connected trees" example)
Is there any way/workaround to fix this issue?

Hi
I don't see any flickering at the connected trees example. What's your setup? (device, OS, browser)

MacBook Pro 13, Yosemite 10.10.5.
I've tested this example with Chrome and Safari and had the same result. I've attached the gif to demonstrate the problem. It actually flickers very fast while moving mouse over it (the gif example doesn't show that because of frame rate limit).

Can't reproduce this with almost the same device but El Capitan. Anyone else with Yosemite installed?
OK, got it. This happens here too when the node is dragged over the lower area of the dropping zone. Even happens on iPhone. Without looking into the code I think this should happen on any device, no matter what browser. I assume that everytime you move the selected node inside dropping zone of tree 1 but outside one node height it checks whether the empty dropping zone or the placeholder should be displayed. Can't look any further into this one since I'll be on vacation for one week. Somebody feel free! :)

@SvenJunga thanks!

@SvenJunga thanks for looking into this! How does the div you add on top prevent the flickering? I assume that div is still able to receive the node being moved around?

I think I've figured this out.
The problem is that when an element is dragged onto the empty placeholder, the element is added to the tree using targetNode.place(placeElm).
This removes the empty placeholder.
Once there is no placeholder, the ui-tree div has no visible children, so it's height collapses to 0.
Next time the dragged element is moved, getting the DOM element it's being dragged above doesn't return the ui-tree div, but rather whatever happens to be there.
An easy fix for this is to set the height of ui-tree div explicitly. In my case setting the height to 100% as follows works:
.angular-ui-tree {
  height: 100%;
}

I fixed this issue with flickering, but I have another problem, see GIF in link ..when I'm dragging item from right list without stop moving, item is not possible to add to left list. Why? From UX it's really bad, I think
https://www.dropbox.com/s/xr4uxinh4qxk3ra/angular ui tree view bug.gif?dl=0

@joujo1212 see this issue #562

Thanks a lot @SvenJunga , it helped!! i didn't see this issue, sorry.

Closing this issue due to inactivity. See #815 for more information.
Please create a new issue is this still occurs with the current version of the component.


Fix: Do not evm validate final states

Following the force move contracts we should not be calling validTransition when transitioning to a isFinal state.
This fixes the validation logic to respect that.

Ok with this as is.
If it's not a burden, can you add a regression unit test for this? An effective one might require a refactor to, for example, extract code that validates state transitions into a method not attached to the store.
A reasonable alternative is to create an issue for this request.

I'd like to get this in as soon as possible so I've created a separate issue here: https://github.com/statechannels/statechannels/issues/2789#issue-733455024


Import listing from airbnb

Just wanted to let you know I think it's a great project! I'm not competent enough to contribute, alas, but I keep my fingers crossed you succeed! Do you have a tentative date for the first release?

Very exciting to hear someone is interested already! Would  you be open for a short call so I can better understand how you would plan to use LibreProperty? I would like to make a first release that meets your needs. Please sent me an email at<EMAIL_ADDRESS>if you are open to talk.
I've been working on it quite actively but it's a lot of work. The 1st large feature I'm working on is being able to create a dedicated website for a vacation property for free on a subdomain.  The development branch has my latest work, that work hasn't been merged to main branch yet.
Sadly, the Airbnb API isn't an open API that you can just sign up for. I do plan to work on being able to import from Airbnb to create a dedicated website very easily.


Uncaught ReferenceError: returnfalse is not defined

This is probably caused by some of the dependencies or by the fact that we use two minifiers (babel and uglify)
Here's the very minimal repro repo https://github.com/Hypnosphi/returnfalse-repro/tree/master

An issue for babel/minify: https://github.com/babel/minify/issues/920

Downgrading webpack to ~4.21.0 helps

Fixed in<EMAIL_ADDRESS>let's upgrade to that

Confirmed fixed in repro repo


Interlaced color images with D415 camera

Good evening,
I'm trying to get color images from al D415 in BGR8 format. I save the frame.get_data() pointer to disk
when I open it with a python script with the right resolution and 3 bytes per pixel I see an interlaced image.
I'm running in a Ubuntu 16.04 with a 4.10 Kernel in a NUC 6 i3 and NUC 7 i3 using librealsense 2.11.0
Thanks in advance for your help.
Regards
Jose

I saw the video_frame has a method get_stride_in_bytes. If I record heightstride instead od heightwidthbytes_per_pixel, I save more data to the disk. When I try to see the recorded image, I have to reject the last stride-widthbytes_per_pixel bytes of each line.
¿Which information is stored in the bytes I reject in each line?

I'm sorry I was assuming the resolution was 1280x720 instead of 1920x1080.


minor gdal version needed for linux build

I tried to build Fiona on Linux according to https://github.com/Toblerity/Fiona/blob/master/README.rst#unix-like-systems and got
Traceback (most recent call last):
File "setup.py", line 175, in
gdal_minor_version = int(gdal_version_parts[1])
IndexError: list index out of range
I had to specify the major and minor version, so e.g. not --gdalversion 2 but --gdalversion 2.3.

I'll update the docs.
Most of the time, the easiest thing to do when building from source is to specify the path to gdal-config:
GDAL_CONFIG=/path/to/gdal-config pip install Fiona-$version.tar.gz
I'll move that up in the installation directions.


Please, can you help me please ?

I have this repository running on Pythonista, when IBAN is ok, works like a charm, but if it s wrong, is not printing the error....
The test code :
from openibanlib import openiban
# By trying to initialize an IBAN object

try:
        openiban.IBAN('DE89370400440532013004')
        print("valid IBAN ")
except IBANFormatValidationException:
        print("Invalid IBAN provided")

The error :
It throwns this :
_Traceback (most recent call last):
File "/private/var/mobile/Containers/Shared/AppGroup/70EF7C81-4506-4E0F-A08E-B2C9E8144F15/Pythonista3/Documents/ibanTest.py", line 5, in
openiban.IBAN('DE89370400440532013004')
File "/private/var/mobile/Containers/Shared/AppGroup/70EF7C81-4506-4E0F-A08E-B2C9E8144F15/Pythonista3/Documents/site-packages/openibanlib/openiban.py", line 24, in init
openibanlib.exceptions.IBANFormatValidationException: Invalid IBAN format provided: DE89370400440532013004
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/private/var/mobile/Containers/Shared/AppGroup/70EF7C81-4506-4E0F-A08E-B2C9E8144F15/Pythonista3/Documents/ibanTest.py", line 7, in
except IBANFormatValidationException:
NameError: name 'IBANFormatValidationException' is not defined_
I ve OpenIban on Python Modules-> site-packages-> openiban, and the exceptions.py has IBANFormatValidationException defined....
I m not  a pro developer... so this error is killing me...any help please ?
Thanks in advance

@bateria2x100
few years later, so i guess this isnt relevant anymore.
in case some one runs into this issue, let me know and i will fix.


Signal blob tx on transaction list results

part of dencun support: https://github.com/otterscan/otterscan/issues/1727
we have a space before the transaction hash where we can display some decoration, currently being used only when the transaction fails to display a "revert" icon.

I think we could use this same area to display an icon for blob transactions in order to make them easier to identify in tx result lists (criteria: tx type == 3).
I'd like to suggest this initial icon/color: https://fontawesome.com/icons/mound?f=classic&s=solid&pc=%23076ab6
with a tooltip of "Blob transaction"
open to discuss better icon/colors, let's see how it looks like.

Here is what this color looks like:

Personally, to separate blobs from the verified contract color, I'm considering a slightly different color, such as purple:

hm, that icon doesn't look as good as I expected 😅
how do you feel about it?

BTW, agree about your color comment

what about using the soap icon?
https://fontawesome.com/icons/soap?f=classic&s=solid

or simply the "O" icon
https://fontawesome.com/icons/o?f=classic&s=solid

https://fontawesome.com/icons/disease?f=classic&s=solid

https://fontawesome.com/icons/cubes-stacked?f=classic&s=solid

https://fontawesome.com/icons/splotch?f=classic&s=solid
I think splotch is a bit closer to the idea than disease:

I'm testing the PR and taking a look at the other icons against sepolia tx list, and so far I think splotch looks the best.

about the color, the purple one isn't "clicking" on me, I think we should try something closer to the blob fish which is the unofficial meme.
let me try some rose variants here.

rose-400, wdyt?

I think the rose color is a bit too red. Would pink-400 be a good compromise? Official sources say blobfish are "pale pink" or "pinkish gray" anyway; the photo above is miscolored, unless that's part of the meme.

I prefer the rose-400, IMHO it looks better being kind of red-ish than pink-ish. TBH, pale pink looks like rose to me :)
I tried lighter versions of rose to reduce the red-effect, but it didn't look great, so -400 seemed ok.


How Integration of SSI with OpenID is useful or optimal as compared to SSI without OpenID?

I've read some research papers on SSI and SSI integration with OpenID and, as here SSI is integrated with openID. So can you tell me Why SSI integration with openID is optimal to SSI without openID?

I am not sure I understand your question. Open ID Connect is a widely used standard and having an OIDC-compliant SSI authentication method allows for an easy integration of SSI/Verifiable Credentials in existing systems, without the need for "special" changes.
Whether you use an OIDC integration or not it will depend on a number of factors, including what you are trying to achieve and what type of ecosystem you are working with and need to support/integrate.

Closing the issue, @ankitkr1606 feel free to reopen if further discussion is required.


Should be able to check job status when executing algorithms on real devices

What is the expected enhancement?
To the best of my knowledge there is no way to check the status of a job that is called internally by an aqua algorithm when running on real devices.

Your observation is correct. This notion has come up a couple of times recently and we have a work item noted for Aqua where the expected enhancement would be an optional user defined callback, that they can supply if they wish, to monitor an algorithms progress in respect of the job(s) it issues over the course of it's processing.

In the meanwhile, you can turn on the aqua logging to the INFO level to see the ids of all submitted job, and then you can check that the status externally.
However, as Steve mentioned, we will work on the callback solution.

@nonhermitian with PR #549, you can provide a callback to check the status of the submitted job.
the callback is called every wait second. The callback is an argument when you create the quantum instance.
By default, if you set the Aqua logging to INFO, we will log the job id and job status.
However, with the callback, you can do more if you want.
The callback takes four arguments: job_id, job_status, queue_position, job.
The queue_position will be zero if it is not queued.
Here is a simple example of the callback, it simply prints out the argument.
def job_callback(job_id, job_status, queue_position, job):
    print(job_id)
    print(job_status)
    print(queue_position)
    print(job)

And this is the output after your running your algorithm, including the Aqua logging and callback's printing. (I set wait=1 in the example)
2019-06-04 14:27:20,780:qiskit.aqua.utils.run_circuits:INFO: All job ids:
['5cf6b800255fce0072360729']
2019-06-04 14:27:20,781:qiskit.aqua.utils.run_circuits:INFO: Running 0-th qobj, job id: 5cf6b800255fce0072360729
2019-06-04 14:27:21,333:qiskit.aqua.utils.run_circuits:INFO: Job id: 5cf6b800255fce0072360729 is queued at position 227
5cf6b800255fce0072360729
JobStatus.QUEUED
227
<qiskit.providers.ibmq.job.ibmqjob.IBMQJob object at 0x12ef50828>
2019-06-04 14:27:23,206:qiskit.aqua.utils.run_circuits:INFO: Job id: 5cf6b800255fce0072360729 is queued at position 227
5cf6b800255fce0072360729
JobStatus.QUEUED
227
<qiskit.providers.ibmq.job.ibmqjob.IBMQJob object at 0x12ef50828>
2019-06-04 14:27:24,911:qiskit.aqua.utils.run_circuits:INFO: Job id: 5cf6b800255fce0072360729 is queued at position 227
5cf6b800255fce0072360729
JobStatus.QUEUED
227
<qiskit.providers.ibmq.job.ibmqjob.IBMQJob object at 0x12ef50828>
2019-06-04 14:27:27,712:qiskit.aqua.utils.run_circuits:INFO: Job id: 5cf6b800255fce0072360729 is queued at position 227
5cf6b800255fce0072360729
JobStatus.QUEUED
227
<qiskit.providers.ibmq.job.ibmqjob.IBMQJob object at 0x12ef50828>

Why not just return the job instance and let the user decide what they want to do with it?

@nonhermitian I do not fully understand why users need to get the job instance back.
For example, for a hybrid algorithm, aqua includes the logic for classical computing and how to interpret the count results from the quantum device.
If users simply get the job instance back, for me, it seems that they need to re-write all logic of classical computing and the post-process of the count results out of aqua.
A specific example, VQE, the quantum part only computes the observation of each Pauli term; then, users need to write the logic to interpret the count results and then handle the classical optimizer and update the variational form from their side. In this case, it seems that the users had already re-written the whole VQE.
If the algorithm only needs to submit one job and then, users can simply call the construct_circuit method to get the circuit and then compile/submit the job by themselves; however, after they get the result back, they still need to re-write the logic for interpreting the count result at their side.

Actually I now consider this closed as we can automatically check job status in jupyter notebooks, and the pubsub hooks to do it in other contexts is already there.


Restyled to some of John Papa's guidelines: added explicit DI …

…to remove need to use ngAnnotate, thus removed it from grunt build task, and changed .jslintrc to allow function use before definition.
Not a big change, but speeds the build process a little bit ...

Looks good, thanks for doing this.

Glad to help ... although I just realized I misspelled "guidelines" in my
commit message ... doh!

{
"name": "Benjamin Boruff",
"title": "SPA Developer",
"url": "http://benjaminboruff.github.io",
"email"<EMAIL_ADDRESS>"twitter": "@BenjaminBoruff"
}
On Wed, Jul 15, 2015 at 1:11 PM, Joel Kanzelmeyer<EMAIL_ADDRESS>wrote:

Looks good, thanks for doing this.
—
Reply to this email directly or view it on GitHub
https://github.com/kanzelm3/angular-video-bg/pull/7#issuecomment-121682290
.


Is there a way to add delay between jest.retryTimes()?

I have few flaky tests which needs some delay before the retry, is there an option to provide such delay along with jest.retryTimes()?
Thanks!

No, sorry. And I don't think we should either. If you really need it, you can add a timeout and some local counter to track retries.


Generative art platform on Solana

Add
[Code Canvas] (https://codecanvas.art) – Generative art platform on Solana.
[New Frontier.art] (https://newfrontier.art) - Generative art platform on Solana.

Done.


Switch to GoCD Debian source

This is so we can install the latest version.

Closing since change was incorporated with #10


field name compatibility for SCK

backward compatible field names for container metadata.

Thank you so much for detailed review!


CPC-2626 sprint/2010 -> sprint/2101

Closing this outdated PR. Please submit this to the latest sprint branch if needed.


pcsx-redux: init at 0093bea292920f1d1c3eb7515026b4153fe2e926

Description of changes
Added new PSX emulator.
Runs well, except the sound which doesn't work for me (NixOS). I will address with follow-up commits when I figure it out.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Runs well, except the sound which doesn't work for me (NixOS). I will address with follow-up commits when I figure it out.

I've managed to fix the sound so that's included now. Only PA/ALSA though, I guess there should be flags enabling all the backends or something.

You may have already tried this, but how about specifying the MA_NO_RUNTIME_LINKING option in miniaudio?
It seems that MA_ENABLE_JACK can also be set as a compile option.
https://miniaud.io/docs/manual/index.html#Building


transports/quic: Refactor listener handling

Description
Note: this PR also includes all commits from libp2p/rust-libp2p#2652. They have been squash-merged into the upstream master already, but I can not merge the latest master here because of the muxer changes. Once the target branchkpp:libp2p-quic is updated to those changes (at least to the point where https://github.com/libp2p/rust-libp2p/pull/2707 was merged upstream) I can rebase onto the latest master.
Discussed in https://github.com/libp2p/rust-libp2p/pull/2289#discussion_r907228272.
This PR adapts the quic transport to the upstream listener changes of libp2p/rust-libp2p#2652. Additionally, it now allows the quic transport to listen on multiple addresses / endpoints. The changes include:

QuicTransport now owns and drives multiple endpoints. An endpoint is created each time Transport::listen_on is called.
When dialing a remote, a random existing listening endpoint is used. If none exists a new one is created that only supports outbound connections (i.e. server config is None). If then a new listening endpoint is created any following dials will use the new endpoint, but existing connections are not migrated.

This PR is WIP and still needs some cleaning. Opened now just to avoid duplicate work.
@kpp the PR only affects QuicTransport, but does not change anything major in Endpoint. Connection and QuicMuxer are not touched at all, so it should not conflict with your work on the muxer changes.
Open Questions

If a first listening endpoint is created and we already have an endpoint used for dialing (without server capabilities enabled): should we, instead of creating a new endpoint, enable server capabilities on the old endpoint and rebind it to the new listening address? The benefit of this would be that the remote peers could then update their address information once they notice the address change. For later dial attempts they would then know the correct address to dial.
Rare case: if the user starts listening on a socket address that we already randomly chose for an existing dialer-endpoint, what should happen?

Thank you. I will carefully review your PR.

Rare case: if the user starts listening on a socket address that we already randomly chose for an existing dialer-endpoint, what should happen?

I would be fine with not handling this case, that is erroring on the listen_on call, forcing the user to handle the case.
I am guessing re-using the existing dialer-endpoint is complicated, especially when handling listen requests across interfaces (i.e. <IP_ADDRESS>) as we would need to do an additional listen_on call for the remaining interfaces with the specified port, right?

If a first listening endpoint is created and we already have an endpoint used for dialing (without server capabilities enabled): should we, instead of creating a new endpoint, enable server capabilities on the old endpoint and rebind it to the new listening address? The benefit of this would be that the remote peers could then update their address information once they notice the address change. For later dial attempts they would then know the correct address to dial.

This sounds very neat to me, especially the part where the remote is notified of the address change. I am fine with this landing in a later iteration in case it is a big undertaking.
Also, something to consider when making a call here: Does the go-libp2p QUIC transport support the case? //CC @marten-seemann

but I can not merge the latest master here because of the muxer changes. Once the target branchkpp:libp2p-quic is updated to those changes (at least to the point where

See https://github.com/kpp/rust-libp2p/pull/18

Sorry for the force-push, rebasing got a bit messy. Closing this PR instead in favor of #19, which includes the changes of #18 and merges the latest master.


Make it possible to memoize and Instance and execute it with different HostImports

The discussion started here: https://github.com/dylibso/chicory/pull/461#issue-2461610175
Basically, I would love to be able to skip the Instance initialization phase or do it against some sort of "signatures" and provide the real HostImports on the fly, just before executing a function.
Current situation:
You can do the parsing and cache the loaded module in memory with:
private static final Module MODULE = Module.builder(...).build();

after that, you still need 2 steps:

Instance initialization
start function call
the initialization will also map the HostImports, but, when using wasi we always need to re-initialize everything even when changing only the arguments, as we have a single build method:

Instance.builder(MODULE).withHostImports(imports).build();

this is sub-optimal as there are use cases(i.e. multiple subsequent executions of a tool) that would benefit from caching the Instance and hot-swapping the wasi HostImports:
Possible resolution:
private static final HostImports baseImports = ???;
private static final Instance INSTANCE = Instance.builder(Module.builder(...).build()).withHostImports(baseImports).withStart(false).build();

when using the Instance we should be able to fully skip the initialization(and have an effective memoization) by using, something like:
INSTANCE.updateImports(baseImports.withArgs(myNewArgs)).export("_start").apply();

There are few possible alternatives to tackle the problem, I'm interested if this is something we want to fix now or something that can be postponed, I'm not sure how much this pattern is widely used.

Another example use case that would be nice to consider(wrt functions "late bindings") raised in the op-chicory integration.

I have reviewed the instantiation logic of Instance and I'm convinced that this feature is not necessary as the initialization phase is only populating tables and memory, which needs to be done anyhow for correctness.


fix(driver): use configure system to build class_create with a single parameter

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Address RHEL 9 backport of class_create signature change introduced in kernel 6.4 git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1aaba11da9aa7d7d6b52a74d45b31cac118295a1
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
fix(driver-kmod): error: too many arguments to function ‘class_create’

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: deepskyblue86
Once this PR has been reviewed and has the lgtm label, please assign hbrueckner for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

driver/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP here the fix for https://falcosecurity.github.io/libs/matrix_X64/#centos-514-kmod_build

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepskyblue86, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

driver/OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepskyblue86, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

driver/OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone next-driver


chore: bump cosign dependencies

Signed-off-by: hectorj2f<EMAIL_ADDRESS>Bumped cosign dependencies to latest version.

thanks! closing in favor of: https://github.com/pivotal/kpack/pull/985 which has some updates


CELEBORN-1349: Add SSL related configs and support for ReloadingX509TrustManager

What changes were proposed in this pull request?
Add SSL related configs and support for ReloadingX509TrustManager, required for enabling SSL support.
Please see #2416 for the consolidated PR with all the changes for reference.
Why are the changes needed?
Introduces SSL related configs for enabling and configuring use of TLS.
Does this PR introduce any user-facing change?
Yes, introduces configs to control behavior of SSL
How was this patch tested?
The overall PR #2411 (and this PR as well) passes all tests, this is specifically pulling out the ReloadingX509TrustManager and config related changes

ReloadingX509TrustManager and ReloadingX509TrustManagerSuiteJ are pretty much unmodified from Spark - I can pull it to a separate PR if that helps with the review.

Note to reviewers, the ssl configs in this PR are namespaced differently from the current module configs.
celeborn.ssl.<module> instead of the current celeborn.<module>.ssl for example.
This was done primarily to indicate the inheritance relationship of celeborn.ssl.rpc (for ex) to celeborn.ssl configs.
But I am not sure if this fits with the overall Celeborn configuration conventions or not.

+CC @otterc, @FMX , @pan3793, @waitinfuture

Thanks for the review @pan3793, that was faster than me adding comments to help with the review :-)


Add tags

Using jsdelivr on the master branch can unexpectedly break things.
Is it possible to release versions on npm or to add tag to the repo using some semantic versioning? This way it avoids to break things.
Thanks!

I second that!

I completely agree! And, sorry for the delay. Here is the official v1.0.0 release.
Most of the details are in the release, and I've provided links for the jsdelivr using the released version.
I'll close this ticket but reopen it if there are any other issues.


Label is [Object,Object]

Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Sales from Select in Menu
Go to Store Room -> Store from Setups in Menu
File : com/dbz/modules/Common/dbzStoreSetup.mxml
In Flex :

In Royale :

@aharui Issue resolved.Thank u so much


Feat/tranisition 2

:tada: This PR is included in version 0.11.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Mastodon -> Bluesky

Mastodon users' postings to Bluesky do not seem to have been reflected since the night of November 20.
Are you currently experiencing problems?

Sorry, yes, Bluesky themselves are: #1520

Duplicate of #1520

Thanks for your time. I will wait patiently.


feat(parser): allow markdown files to be parsed as external refs

This PR adds a simple text parser to be able to parse .md or
.markdown files used as external refs (as a $ref in the contract
document).
With this change, our users will be able to extract big markdown
content from their parent contract document into dedicated external
files.
E.g.
openapi: 3.1.0
info:
  title: This is a super cool API
  description:
    $ref: "./api-description.md"
  version: "1.0"
servers:
  ...
paths:
  ...

Thanks for the review @Polo2!


Update QtClassConverterController.ring

Correct three errors:
1- Detect virtual class destroyer.
2- Correct duplicated end brackets.
3- Avoid affecting enums\flags if some are substring of others.

Thanks for the update
Keep up the good work


Added: Prometheus Metric Server

What issue does this PR address?
Add Prometheus metric server. Issue #234
How did you implement it?

Set up a server.
Add /metrics endpoint that exposes Prometheus metrics.
Add --prometheus flag to enable the server.
Register the Prometheus metric collector.
Each probe request metric collector name will have a prefix with the following format monika_${snakeCase(probeName)}_request_${probeRequestIndex}

Metric Name
Type
Purpose

${metricNamePrefix}_status_code_info
Gauge
to get HTTP status code

${metricNamePrefix}_response_time_seconds
Histogram
to get duration of probe request in seconds

${metricNamePrefix}_response_size_bytes
Gauge
to get size of response size in bytes

Collect the metrics.
Expose the Monika probe request metrics along with Prometheus default metrics and Node.js specific metrics.

How did you test?

Run Monika with the --prometheus flag. e.g., ./bin/run --prometheus 3001.
Open http://localhost:3001/metrics.
Download Prometheus
Add text below to the Prometheus configuration, below scrape_configs field

- job_name: "monika"
  static_configs:
    - targets: ["localhost:3001"]

Start Prometheus.
Run some Prometheus query. e.g., monika_monika_${snakeCase(probeName)}_request_0_status_code_info

Note
Here is the visualization of Monika Prometheus metrics from a Grafana dashboard.

Close this issue, and will try to refactor some functions first, before re implementing this again.


[SPARK-33052][SQL][TEST] Make all the database versions up-to-date for integration tests

What changes were proposed in this pull request?

This PR intends to update database versions below for integration tests;

ibmcom/db2:<IP_ADDRESS>a => ibmcom/db2:<IP_ADDRESS> in DB2[Krb]IntegrationSuite
mysql:5.7.28 => mysql:5.7.31 in MySQLIntegrationSuite
postgres:12.0 => postgres:13.0 in Postgres[Krb]IntegrationSuite
mariadb:10.4 => mariadb:10.5 in MariaDBKrbIntegrationSuite

Also, this added environmental variables so that we can test with any database version and all the variables are as follows (see documents in the code for how to use all the variables);

DB2_DOCKER_IMAGE_NAME
MSSQLSERVER_DOCKER_IMAGE_NAME
MYSQL_DOCKER_IMAGE_NAME
POSTGRES_DOCKER_IMAGE_NAME

Why are the changes needed?

To improve tests.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Manually checked.

cc: @HyukjinKwon @dongjoon-hyun

okay, thanks for the check, @HyukjinKwon

Test build #129338 has started for PR 29932 at commit 961f36c.

cc @gaborgsomogyi for Kerberos integration testing.

Test build #129338 has finished for PR 29932 at commit 961f36c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129338/
Test FAILed.

Thank you for this updates, @maropu . I verified mostly. For the rest, I'll leave it to you and @gaborgsomogyi .

Thanks for your manual checks, @dongjoon-hyun !

Test build #129343 has started for PR 29932 at commit 877bc2a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33951/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33951/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33951/
Test PASSed.

Double checked and LGTM, except I suggest to bump the MariaDB version to 10.5 w/ the suggested change.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33954/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33954/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33954/
Test PASSed.

okay, I've checked the latest mariadb in MariaDBKrbIntegrationSuite worked well on my local env. Anyone can check this again? Thanks! @HyukjinKwon @dongjoon-hyun @gaborgsomogyi

Test build #129343 has finished for PR 29932 at commit 877bc2a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129343/
Test PASSed.

Test build #129344 has started for PR 29932 at commit 0ef813b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33955/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33955/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33955/
Test PASSed.

Test build #129344 has finished for PR 29932 at commit 0ef813b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129344/
Test PASSed.

Thanks, @srowen ! Merged to master.

Thank you, @maropu and all!

Hi, @maropu .
Could you resolve the JIRA issue, SPARK-33052?

Oh, I forgot to do so. Thanks for letting me know, @dongjoon-hyun


[hubot] Parse multiple spaces/whitespace as one delimiter

Building on work by @danriti to support whitespace-delimited parameters. This should resolve TVD-480 reported by @ctcutler (extra spaces make the hubot deploy script do bad things).
Also updated the multiple-param test to catch this case.
From the Chrome console:
> "foo  bar  \t baz".split(' ')
["foo", "", "bar", "", "	", "baz"]
> "foo  bar  \t baz".split(/\s+/)
["foo", "bar", "baz"]

Looks good to me! :+1:

:beers: :beers:


$touched bug

formField.$touched is never set to true, even after a user has interacted with the control.
Plunkr: https://plnkr.co/edit/fyXGWqJgOeQPoTAjQT7r?p=preview

Thanks for posting, I will look into this.


ARROW-5045: [Rust] Code coverage silently failing in CI

@fsaintjacques actually the PR was not ready to be merged yet, I was exploring cargo-tarpaulin but it was still failing with the following error (code coverage failure will not prevent CI from succeeding):
...FFFFFFFFFFFFF.plan: TableScan: people projection=Some([0, 1, 4])
.[ERROR tarpaulin] Failed to get test coverage! Error: Failed to run tests: A segfault occurred while executing tests

I did look at the output but didn't see any immediate errors (https://travis-ci.org/apache/arrow/jobs/550633131#L1761). Weird that travis hides the error in this case. To avoid this confusion in the future, might I suggest to either add the WIP keyword in the PR name or not publish it at all (you can activate travis on your fork before opening the PR).

Yes that's correct. You'll have to expand the step to see the error :)
Good suggestion on the WIP. Let me do it next time. I'll file another JIRA and PR later.


Await for expression using type ReceivePort causes exception in Resolver

Pasting the following code into an empty Dart file:
import 'dart:isolate';

f(ReceivePort p) async {
  await for (var v in p) {}
}

causes an exception to occur.  Here's the relevant part of the stacktrace:
RangeError (index):: Invalid value:: Only valid value is 0:: 0
#0      List.[] (dart::core-patch/array.dart::134)
#1      ResolverVisitor._getStreamElementType (package::analyzer/src/generated/resolver.dart::11268)
#2      ResolverVisitor.visitForEachStatementInScope (package::analyzer/src/generated/resolver.dart::10824)

It appears that the problem is that _getStreamElementType() assumes that if the type of the stream expression exposes a listen() function, then its zeroth type parameter indicating the type of the thing being iterated over.  But that is not the case for ReceivePort, which has no type parameters.
It is also possible to imagine classes which have type parameters, but for which the zeroth type parameter is not the type of the thing being iterated over, e.g.:
class MyCustomStream<T> implements Stream<List<T>> { ... }

Probably what should happen instead is that _getStreamElementType() should examine the type of the listen() function in order to determine the type of the thing being iterated over (this is similar to what _getIteratorElementType() does).
However we might want to consider doing a band-aid fix sooner, since this exception causes the analysis server to go into an infinite analysis loop.
(I will file a separate issue about the fact that an exception in resolution can cause an infinite analysis loop in the analysis server; the analysis server really should be more robust than that.)

should be fixed now


pull request for new passive scalar scheme and bc

I've merged this pull-request into the existing one. Please use the passive_scalar branch instead for your changes. I'm closing this MR.


Submit file doesn't take a tuple

I see in the comments, it says:
Parameters:
sample:       The sample to submit. Needs to be a file-like object or a tuple in
the shape (filename, file-like-object).
Which I tried and I believe correctly.   And I get:
TypeError: a bytes-like object is required, not 'tuple'
It works great if I just pass a file-like-object but of course that doesn't allow me to specify a file name. They all come in as 'sample' which I believe is because of line 179:
files = {'sample': sample}
Thanks. Greg.

+1

Thanks for reporting this issue. Fixed in version 2.6.1 which is currently uploading.
https://github.com/joesecurity/joesandboxcloudapi/commit/b25a8196ec101218c6ae03d8c90dc061cca38f25


🐛 Fix detection of contextvars compatibility with Gevent 20.9.0+

🐛 Fix detection of contextvars compatibility with Gevent 20.9.0+
This is described in https://github.com/getsentry/sentry-python/issues/1063, and this PR would fix it (it should at least).
Description
The current implementation checks if Gevent patched contextvars, but:

Gevent 20.9.0 depends on Greenlet 0.4.17 which natively handles switching context vars when greenlets are switched.
Older versions of Python [older than 3.7] that have the backport installed will still be patched.

Ref: https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/monkey.py#L604-L609
This PR updates the implementation to check the version of Gevent and Python to account for that.
Use Case
I'm migrating a code base with a couple of apps from Flask to FastAPI. During the migration both Flask and FastAPI are available at the same time, sharing a lot of the code and tests.
The Flask app is currently deployed with Gevent, so the tests use Gevent's monkey patching.
The FastAPI app uses the SentryAsgiMiddleware, which internally uses contextvars to store and handle all the Sentry stuff per request. And that in turn uses this utility function to check if the current environment has working contextvars available.
So, with Python 3.7+ and a recent installation of Gevent monkey patching stuff, Sentry errors out complaining about broken contextvars, but it seems it's actually just a false positive.

Thanks for the reviews @untitaker and @ahmedetefy! :rocket:
Dang it, sorry for the linter warnings, I just ran them locally and fixed them (hopefully :crossed_fingers:).
I agree that all the extra complexity for testing different versions of Gevent with different versions of Python doesn't seem worth it as it's probably more of an edge case.
Nevertheless, let me know if they are needed and I can give that a try.

Thanks @tiangolo !

Awesome! Thanks for the quick response/review and merge! :rocket:
Do you have any estimate of when this could be included in a release?

Anytime! Yep will cut a patch today

Woohoo! Awesome, thanks a lot! :rocket:


Build release Failing

FAILURE: Build failed with an exception.

Where:
Build file 'C:\Users\createam\Desktop\DZ_FLEX\dz_flex\node_modules\react-native-read-sms\android\build.gradle' line: 111

What went wrong:
A problem occurred configuring project ':react-native-read-sms'.

Configuration with name 'compile' not found.

Apparently, this is the root course of the issue, you can update the node_module manually if you're not working with tools like expo for remote building
if you go to node_modules\react-native-read-sms\package.json
look for the author key which looks like
"author": "KSquad Pvt. Ltd<EMAIL_ADDRESS>and change it to
"author": {     "username": "KSquad Pvt. Ltd<EMAIL_ADDRESS>    "name": "KSquad Pvt. Ltd<EMAIL_ADDRESS> }
Same issue as #8


Installation of a storage cluster fails

Blueprint used :
- action: install
  actor: storage_cluster
  service: mycluster
  force: false
storage_cluster__mycluster:
  label: mycluster
  nrServer: 56
  diskType: ssd
  nodes:
   - 0cc47a3aad5a
   - 0cc47a3b3d6a
   - 0cc47a3b3d98
   - 0cc47a3b3eb2
   - 0cc47a6b2c1c
   - 0cc47aab6444
   - 0cc47aab6702
   - 0cc47aab670a
  clusterType: storage
  k: 0
  m: 0

First time execute the blueprint I get:
 ays blueprint storage.bp
[Thu10 14:41] - SystemProcess.py    :661 :j.sal.process                  - INFO     - Checking whether at least 1 processes redis-server are running
error during execution of the blueprint storage.bp: Error: Request Timeout

Then second time I try to execute the blueprint it works. but then when I create the run.
The init action of the storagecluster is schedule. Which shouldn't be the case, cause init is supposed to be executed during the execution of the blueprint.
I tried to run the blueprint anyway but got this error:
2017/08/10 14:51:25 trace: JumpScale9.errorhandling.JSExceptions.Input: ERROR: Not enough available disks on node 0cc47aab670a ((type:input.error)

         2017/08/10 14:51:25 errormsg: Traceback (most recent call last):
          File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
            result = self.fn(*self.args, **self.kwargs)
          File "/tmp/actions/storage_cluster/a228ca9d02447f177e5ed702330713ee.py", line 75, in init
            raise j.exceptions.Input("Not enough available disks on node {}".format(node.name))
        JumpScale9.errorhandling.JSExceptions.Input: ERROR: Not enough available disks on node 0cc47aab670a ((type:input.error)

Which clearly show that the init has not been executed the first time cause this error is supposed to be raise during the blueprint executing not during the run.

probably duplicate of #691

we created 10 nodes type 2 and we tried to create a storage cluster, It consumed more than 15mins and of course the api request return time out then we listed the cluster, it returned the cluster name then we get the cluster status, it returned 500 then we tried to create vdisk, it consumed +3mins and return 500

Should be fix by https://github.com/Jumpscale/ays9/pull/168

verified.
We created a storage cluster in 5 nodes (25 ssd disk), it consumed ~400sec. Then we get the cluster info, it consumed ~90sec


PrecacheController createHandlerBoundToURL return type error, does not match the declared type

I am coming again.
Library Affected:
workbox-precaching
Issue or Feature Request Description:
PrecacheController createHandlerBoundToURL return type error, does not match the declared type

This should be fixed in v6 by https://github.com/GoogleChrome/workbox/pull/2548


GH-482 Exclude internal properties from action menu

Fixes #482

Applied to main (=2.1) and branch 2.0.


[CARBONDATA-95] Columns values with numeric data types are not getting parsed when included in dictionary_include

Analysis: When a numeric datatype lets say Decimal is defined for a column and the column is included as dictionary_include, then the whatever precision and scale is defined by the user is not taken into consideration and each value is accepted and dictionary is generated for that value.
Solution: Parse big decimal while generating global dictionary and dictionary look up and set the precision and scale specified by the user

Also 2 test cases are skipped in below package, please correct it
org.carbondata.integration.spark.testsuite.complexType

@sujith71955 .....none of the test cases are failing. just before my PR one complex type bug was fixed and PRbuilder was ran. In that 2 new test cases were added. If a PR that ran just before your PR had some additional test cases than in your PR result it will display -count for the number of additional test cases that were added in the previous ran PR.

retest this please

retest this please


Check device changes by address

Changes

Fixed windows hotplug polling to correctly identify devices using address
Fixes https://github.com/node-usb/node-usb/issues/516

Fixes

https://github.com/node-usb/node-usb/issues/516

Checklist

Have you...

[x] Tested the change acts as expected
[x] Checked the change doesn't remove or change existing functionality
[x] Considered how the feature impacts the product and tested around it (not just the happy paths)
[ ] Where possible, executed the hardware tests on multiple operating systems

The deviceAddress is only unique within the USB bus. If we are going to do this, it should be at least based on a (busNumber, deviceAddress) tuple.
However, I'd wait for libusb to confirm which checks are needed


Upgrade Eclipse Collections library dependencies from 10.2 to 11.0

Feature Request
Description of Problem:
Most of the repositories for Legend currently depend on Eclipse Collections 10.2 which is two years old. The latest 10.x release was 10.4 and was released in August 2020. Eclipse Collections 11.0 was released in November 2021 and is the current release.
I would recommend upgrading to the latest version of Eclipse Collections (11.0) in each Legend Java Repository to stay up to date with the latest features and bug fixes.
Potential Solutions:
Upgrade dependencies in pom files replacing Eclipse Collections 10.2 with 11.0 in the following repositories.

legend-pure
legend-engine
legend-sdlc
legend-depot

I looked across all of the Legend Java language repositories for references to Eclipse Collections in the parent pom. It's possible I missed a repository.

Hi Don!  Would you be open to contributing this upgrade?  That would be awesome!

Hi @neema3000, I'll see if I can find the time. The latest release of Eclipse Collections is now 11.1. Any release before 10.4 of Eclipse Collections will have an issue when used with JDK 15 or above. We discovered and reported an issue in JDK 15 before it was released that broke Eclipse Collections.
https://stuartmarks.wordpress.com/2020/09/22/incompatibilities-with-jdk-15-charsequence-isempty/
It looks like Legend is still on Java 8. I'm not sure if there are plans to upgrade Legend code bases to JDK 11 or 17 which are the two most recent Long Term Support (LTS) versions of the JDK. If an update to JDK 17 is planned, you'll need to complete the EC 10.2 upgrade to 10.4 or higher first.


Utf8Decoder should set FormatException.offset

When Utf8Decoder.convert() encounters an invalid byte sequence, it throws a FormatException. However, that exception's offset field is unset, so there's no way to tell where the invalid bytes were in the input.

fixed.


[Firestore] Possible misleading information in a doc?

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I want to check if doc is up to date.
Additional context
Hi,
I use Firestore library, and found out possible outdated information.
https://github.com/FirebaseExtended/flutterfire/blob/master/packages/cloud_firestore/cloud_firestore/lib/src/transaction.dart#L88
The above doc says that developer can provide SetOptions param to enable merge operation, but it appears that the method signature of set does not accept any arguments related to SetOptions.

Hey, as part of our on-going work for #2582, this has been resolved in our Firebase Firestore rework (#2913) - which has now been merged into master. We'll look at publishing some prereleases in the next few days along with the new documentation website. Thank you

@Salakar just wanted to know whether we will be having set options in future releases or just the documentation will be updated?

Both, changes are on master but not yet published and we also have a new docs website.

Awesome @Salakar !


[BUG] No matching signature found on free-threaded Python code generation

Describe the bug
Whilst testing SciPy for issues against free-threaded CPython 3.13 https://github.com/scipy/scipy/pull/21496, we have observed several instances of errors on functions that fuse dtypes, for some reason, these errors are being flagged when running tests under parallel conditions, and not under single threading.
__________________________________________________________________ test_label03[numpy] __________________________________________________________________
scipy/ndimage/tests/test_measurements.py:169: in test_label03
    out, n = ndimage.label(data)
        data       = array([1.])
        xp         = <module 'numpy' from '/home/rgommers/code/pixi-dev-scipystack/scipy/.pixi/envs/free-threading/lib/python3.13t/site-packages/numpy/__init__.py'>
scipy/ndimage/_support_alternative_backends.py:37: in wrapper
    result = func(*args, **kwds)
        args       = (array([1.]),)
        delegator  = <function binary_fill_holes_signature at 0x385421dfa00>
        func       = <function label at 0x385421de9c0>
        kwds       = {}
        module_name = 'ndimage'
        xp         = <module 'scipy._lib.array_api_compat.numpy' from '/home/rgommers/code/pixi-dev-scipystack/scipy/scipy/build-nogil-install/lib/python3.13t/site-packages/scipy/_lib/array_api_compat/numpy/__init__.py'>
scipy/ndimage/_measurements.py:218: in label
    max_label = _ni_label._label(input, structure, output)
        caller_provided_output = False
        ii         = 3
        input      = array([1.])
        need_64bits = False
        output     = array([-889028608], dtype=int32)
        structure  = array([ True,  True,  True])
_ni_label.pyx:200: in _ni_label._label
    ???
_ni_label.pyx:237: in _ni_label._label
    ???
_ni_label.pyx:93: in _ni_label.__pyx_fused_cpdef
    ???
E   TypeError: No matching signature found

The generated C code for the Cython instance is described in the following comment: https://github.com/scipy/scipy/pull/21496#discussion_r1850947457
I will provide a minimal reproducible example soon.
cc @rgommers
Code to reproduce the behaviour:
No response
Expected behaviour
No response
OS
Linux
Python version
3.13t
Cython version
No response
Additional context
No response

There's definitely some caching inside the fused dispatch function (so it's quicker to match on subsequent calls). On a quick look, I'm not convinced that caching is currently thread-safe. I'll look into it.
(There's also some code that imports numpy and gets the dtype. That's less likely to be an issue, but probably still needs a close look)

The generated C code for the Cython instance is described in the following comment: [...]

That's probably actually a lower level than it's worth looking at. In this case it goes "fused function"->"generated Cython code"->"generated C code" and the issue is in the intermediate Cython code.
I think this should apply to any cpdef or def fused function so there isn't too much value trying to prepare a specific reproducible example.

I've made a couple of PRs to fix different bits of this. https://github.com/cython/cython/pull/6508 is the main one. (I think #6507 would probably just result in a reference leak at worst).
I've added a test that fails intermittently without the fix, and doesn't seem to fail with the fix. But of course that doesn't prove that it fixes scipy.

Thanks for the quick fix @da-woods! I have tested gh-6508 with SciPy, and it seems to fix all known issues (at least, failure rates go from 25% - 50% to 0% over >10 test runs for each of the 4 problematic tests).


docs(changelog): update changelog for tag v0.4.21

Description

Related links

Notes for reviewers

Pre-review checklist for the PR author

[x] I've confirmed the contribution guidelines.
[x] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Please add following links

https://github.com/tier4/caret_analyze/pull/430
https://github.com/tier4/caret_doc/pull/313


$router.push doesn't work correctly with two dynamic parameters

Versions

nuxt: v2.14.7
node: v12.14.0

Reproduction
Sandbox link:
https://codesandbox.io/s/beautiful-ellis-6l1y5?file=/pages/_lang/order/_id/index.vue
Steps to reproduce

Run a sandbox project
Go to the order page (the URL has two dynamic params): https://6l1y5.sse.codesandbox.io/en/order/1111
Click the "Success" button
The following method is called:
      this.$router.push({      name: "lang-order-id-success",    });

What is Expected?

To go to Sucess URL with both dynamic params: https://6l1y5.sse.codesandbox.io/en/order/1111/success

What is actually happening?

The actual URL is: https://6l1y5.sse.codesandbox.io/en/order/success -> id param in URL is missing

Note: started to get reproduced after the upgrade from "2.12.2" to "2.14.17"

@omm2 Your reproduction doesn't reproduce the issue for me.

This issue is reproducible on firefox. In the chrome, routing works fine.

@pulsarpoint I was using Firefox too, when I couldn't reproduce the bug.

@danielroe Sorry, you're right. I just check once again and works fine in ff too.

Hello, thank you for your quick reply!
Apparently, the issue is only reproduced with the parameter being optional. I re-wrote the example a little bit, so that :id is now :id?
Steps to reproduce:

Go to sandbox example: https://6l1y5.sse.codesandbox.io/
Click the "Payment" page, the URL changes to https://6l1y5.sse.codesandbox.io/en/order/1111/payment
Click "Success" button, the URL changes to https://6l1y5.sse.codesandbox.io/en/order/success

Expected: URL to change to https://6l1y5.sse.codesandbox.io/en/order/1111/success


[DS-3770] always uncache item after performed curation task

https://jira.duraspace.org/browse/DS-3770
The hibernate cache makes curation task on a large number of items very slow.

Must be cherry-picked to master too.
I think the fix is obvious and I'm +1. Nevertheless I should mention that @pbroman is my colleague and this should be approved by other DSpace committers.

@tomdesair I assign this to you, as this falls into your expertise. Please feel free to unassign it if you disagree or cannot spend time on this.

@hardyoyo gave it a +1, @tdonohue could you please confirm that all requested changes where implemented? I think this is ready to be merged and cherry picked to master.

Tested using Vagrant-DSpace, I used the XMLUI Curation Task UI, and ran the Profile Bitstreams sample task. It ran blink-fast, and returned accurate results for my test collection, with no errors. Looks good. My +1 remains.


netlify lm:install crashes

Describe the bug
Runnning
netlify lm:install
results in a crash with the following output:
$ netlify lm:install
✔ Checking Git version [2.17.1]
✖ Checking Git LFS version
→ Check that Git LFS is installed in your system
Checking Git LFS filters
Installing Netlify's Git Credential Helper for Linux
Configuring Git to use Netlify's Git Credential Helper
Error: Check that Git LFS is installed in your system
at checkLFSVersion (/home/naavis/.local/share/netlify-cli/node_modules/netlify-lm-plugin/lib/requirements.js:38:15)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Task.task (/home/naavis/.local/share/netlify-cli/node_modules/netlify-lm-plugin/lib/requirements.js:17:29) {
context: [Object: null prototype] {}

Despite the error message I have Git LFS installed and working.
To Reproduce
Steps to reproduce the behavior:

Run npm install -g netlify-cli
Run netlify plugins:install netlify-lm-plugin
Run netlify lm:install

Configuration
npx envinfo prints the following:
System:
    OS: Linux 4.15 KDE neon 5.19
    CPU: (4) x64 Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz
    Memory: 489.86 MB / 7.49 GB
    Container: Yes
    Shell: 5.4.2 - /usr/bin/zsh
Binaries:
    Node: 14.15.4 - ~/.nvm/versions/node/v14.15.4/bin/node
    npm: 6.14.11 - ~/.nvm/versions/node/v14.15.4/bin/npm
    npmGlobalPackages:
        netlify-cli: 3.4.3

Expected behavior
The command should not crash, but it should install necessary tools and configurations necessary for using Netlify Large Media

Thanks @naavis, we're in the process of moving https://github.com/netlify/netlify-lm-plugin into the CLI repo, so I'll keep this issue in mind while doing so.
See https://github.com/netlify/cli/pull/1489.
Can you share the output of git-lfs --version? That's how we're checking that it's installed:
https://github.com/netlify/netlify-lm-plugin/blob/f129b0ccb90fefd2226cf1f468797f12708a2bf4/src/requirements.ts#L33

Thanks @naavis, we're in the process of moving https://github.com/netlify/netlify-lm-plugin into the CLI repo, so I'll keep this issue in mind while doing so.
See https://github.com/netlify/cli/pull/1489.
Can you share the output of git-lfs --version? That's how we're checking that it's installed:
https://github.com/netlify/netlify-lm-plugin/blob/f129b0ccb90fefd2226cf1f468797f12708a2bf4/src/requirements.ts#L33

git-lfs --version returns the following error:
$ git-lfs --version
Error: unknown flag: --version
Sorry, no usage text found for "git-lfs"

However, running git lfs version returns this:
$ git lfs version
git-lfs/2.3.4 (GitHub; linux amd64; go 1.8.3)

git-lfs --version returns the following error:
$ git-lfs --version
Error: unknown flag: --version
Sorry, no usage text found for "git-lfs"

However, running git lfs version returns this:
$ git lfs version
git-lfs/2.3.4 (GitHub; linux amd64; go 1.8.3)

We require 2.5.1 see https://docs.netlify.com/large-media/requirements-and-limitations/#requirements. We should improve that error message though

We require 2.5.1 see https://docs.netlify.com/large-media/requirements-and-limitations/#requirements. We should improve that error message though

Good point, seems like KDE Neon provides a pretty old version of Git and Git LFS. Thanks.

Good point, seems like KDE Neon provides a pretty old version of Git and Git LFS. Thanks.


Update for new capabilities in libratbag

ratbagd_device_get_capabilities() doesn't handle all capabilities, especially not the new ones from
https://github.com/libratbag/libratbag/pull/176
This is required by https://github.com/libratbag/piper/pull/10/

I'll tackle this one today.


[Feature] Include the footer in the submission and in the resource view

Description
After the work done in https://github.com/creativecommons/cc-resource-archive/pull/206, the site already includes the footer on the homepage. Now, the footer can also be included in the submission and resources view to add visual consistency over the entire site, and ease the navigation.
The code that implements the footer currently included in listing.html can be extracted to a new footer.html file. Then, it will be possible to leverage the Jekyll includes folder to easily add the footer to any other view on the site.
Alternatives

An alternative to this option would be to include the footer only in the resources view, taking into account that currently the submissions view has not so much content which can led to a weird visual effect.
Implementation

[x] I would be interested in implementing this feature.

@vivitt
As the issue is now ready for work, Are you working on this ? I would be glad to help

I will also be glad to contribute to this issue.

Hi @Murdock9803 and @BalrajDhakad, thanks for asking. I already had the changes made so I just opened a PR


OPENSSL_cpuid_setup FreeBSD PowerPC update

This pull request is ready to merge

This pull request is ready to merge

Pushed. Thanks.

Pushed. Thanks.


Delete preset and saved categories

As a user, I want to be able to delete a category, whether it's preset, or saved.
Scenario 1 - Preset
Given: I am editing a preset category
When: I delete that category
Then: The category and its associated phrases no longer show in settings or the main screen of the app
Scenario 2 - Custom
Given: I am editing a custom category
When: I delete that category
Then: The category and its associated phrases no longer show in settings or the main screen of the app
Note
This depends on #504

This was erroneously closed.


Modify view command to show error for negative index

Codecov Report

Merging #357 (c3bbf34) into master (26e6a54) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
- Coverage     69.37%   69.28%   -0.10%
- Complexity      703      706       +3
============================================
  Files           137      137
  Lines          2390     2396       +6
  Branches        269      271       +2
============================================
+ Hits           1658     1660       +2
- Misses          606      609       +3
- Partials        126      127       +1

Impacted Files
Coverage Δ

...ic/parser/itemcommandparser/ViewCommandParser.java
66.66% <60.00%> (-33.34%)
:arrow_down:

...in/java/seedu/foodrem/commons/util/StringUtil.java
86.95% <100.00%> (+0.59%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(featureCard): multiple bugs and knob removal

Related Ticket(s)
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5400
Description
Multiple bug fixes, including corrected card overflow in smaller screens:

Hello @photodow, issue is ready for review. I fixed the overflow issue in the react component too and saw what you meant about the multiple background color definitions. To improve this, the styles for this component would need a couple of days of dedications to achieve this.

To improve this, the styles for this component would need a couple of days of dedications to achieve this.

Sorry, to improve what? You said you fixed it in the sentence before, so I'm slightly confused there.

Hello @photodow, issue is ready for review.

I'm still seeing many of my points above not addressed yet. Let me know if we need to sync up on those.

@photodow my apologies if I didn't explain myself well. What I meant was that the overflow problem was fixed, but I would need to dedicate some time to refactor the code to try to avoid the multiple background definitions you mentioned. I think that would need a new issue to be created.
For the focus, you're right, I thought I had to leave 1px gap because of this screenshot. Gap removed.

Fixed the missing image hover too.

@shixiedesign fixed the hover and outline ;)

I captured James comment above in a new bug issue: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5601

Before I approve did this introduce a grid alignment issue to FeatureCardBlockMedium? I'm not seeing it on the main storybook site.

Something changed...yep, but looks like the current (canary) Feature card block medium is not to spec too. The card should be hanging into the gutter. I'm also looking to deprecate the "block" feature cards in general and add the large size to feature card component. See this #5416 @photodow.
Current (canary) Feature card block medium below


epic: Refactor the project into NEXT+REACT+TailWind

Proposal:

Refactor the entire repository using NEXT to turn the react website static and faster

This is a very heavy task and should be broken into more pieces. Blockful have a  public repository with a very light front-end already using NEXT+REACT+RAINBOW+WAGMI+VIEM, which should be explored for this integration: https://github.com/blockful-io/frontend-web3-boilerplate
#15 Should work alongside this task because both of them achieves the same ecosystem

@heronlancellot hey, can I work with you on this task?

 Let's handle that one

Any updates on this task?

I'm bumping this for updates once more @diegosano @heronlancellot
We should sync next week, contact me!

Sure, we can schedule a call to review together what is missing from this task to finalize!

yupp ! Let's schedule a call @0xneves


Enhanced Select with no label has too much top padding

The first field in this screen capture is a TextField with no label, the second is an enhanced Select:

Expected Behaviour
TextField and Select(enhanced) should have the same top padding when there is no label
Actual Behaviour
TextField has padding-top: 16px, Select(enhanced) has padding-top: 20px

This might actually be an issue for material-components/material-components-web...

Current workaround is to give the Select a className prop:
className={"mdc-select__no-label"}

then in scss:
.mdc-select__no-label {
  .mdc-select__selected-text {
    padding-top: 16px;
  }
}

Thank you for finding this issue!
There are some breaking changes in Select component.
But it looks not reflect.
Do you wanna tackle this?
If not, I'll make fixing PR as soon as possible :)

I'll have a go :) I don't really know TypeScript, so it'll be an interesting foray! (I've been looking for at least 20 minutes and still can't work out where the label gets render()ed

Think I've got it - it helps if you're looking in the right project. I'll give it a go 👍

Here is renderLabel method:
https://github.com/material-components/material-components-web-react/blob/master/packages/select/index.tsx#L416
And this doc is helpful for you!
https://github.com/material-components/material-components-web/tree/master/packages/mdc-select/#enhanced-select

Tested this out and yes you're right, there is a 20px padding-top for the select and 16px padding-top for the text-field (for both with label and no label). Screenshots attached of misalignment:

Moving this to MDC Web


staticCall not working on hardhat 2.22.5, <Module being constructed - No results available yet>

What happened?
Everytime that I try to get the answer from the getMessage function with ignition I get the following result rather than the answer:
<ref *1> NamedStaticCallFutureImplementation {
  id: 'Interact#Rocket.getMessage',
  type: 'STATIC_CALL',
  module: IgnitionModuleImplementation {
    id: 'Interact',
    results: <Module being constructed - No results available yet>,
    futures: Set(2) { [NamedContractAtFutureImplementation], [Circular *1] },
    submodules: Set(0) {}
  },
  dependencies: Set(1) {
    NamedContractAtFutureImplementation {
      id: 'Interact#Rocket',
      type: 'NAMED_ARTIFACT_CONTRACT_AT',
      module: [IgnitionModuleImplementation],
      dependencies: Set(0) {},
      contractName: 'Rocket',
      address: '0x5fbdb2315678afecb367f032d93f642f64180aa3'
    }
  },
  functionName: 'getMessage',
  contract: NamedContractAtFutureImplementation {
    id: 'Interact#Rocket',
    type: 'NAMED_ARTIFACT_CONTRACT_AT',
    module: IgnitionModuleImplementation {
      id: 'Interact',
      results: <Module being constructed - No results available yet>,
      futures: [Set],
      submodules: Set(0) {}
    },
    dependencies: Set(0) {},
    contractName: 'Rocket',
    address: '0x5fbdb2315678afecb367f032d93f642f64180aa3'
  },
  args: [],
  nameOrIndex: 0,
  from: undefined
}

Minimal reproduction steps
This is the contract:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.0;

contract Rocket {
    string public name;
    string public status;
    string public message;

    constructor(string memory _name) {
        name = _name;
        status = "ignition";
    }

    function launch() public {
        status = "lift-off";
    }

    function getMessage() public view returns (string memory) {
        return message;
    }

    function setMessage(string calldata _message) public {
        message = _message;
    }
}

I deployed it using this ignition script:
const { buildModule } = require("@nomicfoundation/hardhat-ignition/modules");

module.exports = buildModule("Apollo", (m) => {
  const apollo = m.contract("Rocket", ["Saturn V"]);

  m.call(apollo, "launch", []);

  return { apollo };
});

With this command:
$ npx hardhat ignition deploy ignition/modules/interact.js --network localhost

I started the local node with the normal command:
$ npx hardhat node

I tried to print the message with this script:
const { buildModule } = require("@nomicfoundation/hardhat-ignition/modules");

module.exports = buildModule("Interact", (m) => {
  const contract = m.contractAt("Rocket", "0x5fbdb2315678afecb367f032d93f642f64180aa3");

  //m.call(contract, "setMessage", ["Hi!"]);
  const output = m.staticCall(contract, "getMessage", []);
  console.log(output);

  return { contract };
});

I executed it with:
$ npx hardhat run .\scripts\interact.js --network localhost
$ npx hardhat run .\ignition\modules\interact.js --network localhost
$ npx hardhat ignition deploy .\scripts\interact.js --network localhost

None of them worked
Search terms
staticCall, Module being constructed

Hey, @human-77. This is expected.
Everything passed into buildModule is run before execution. The module is constructed, which is when the console.log(output) is run. The constructed module is then used for running the execution.
This separation of the describing of the deployment from its execution allows us to support features like restarting a deployment that was only partially completed.

But then, How can I get to print the output of the function?
Do I need to import the script from other script, export the result and then print the result? I have tried to that, but got the same result

But then, How can I get to print the output of the function?
Do I need to import the script from other script, export the result and then print the result? I have tried to that, but got the same result
What I'm trying to do is the same as the scripts that were executed with "hardhat runner", but with ignition, or is that a mistake?

You can use scripts as before. Ignition is giving you a declarative deployment which means it is less procedural but allows us to understand the complete deployment before running it (so we can do static analysis and validation, visualize it, restart it from a midpoint due to a previous failed run).
But you can combine both approaches as well. Deploy an Ignition module from within a script:
https://hardhat.org/ignition/docs/guides/scripts


ignore empty objects

sometimes a null-loader will return an empty object and that could be sent to proj4-merge

done


Optimize TestSuite and TestCase list

TestSuite -> summary filed
TestCase -> testCaseResult

@TeddyCr please add more details. Don't understand the requirement here.

@TeddyCr we can close this right?

Yes


Column access

We usually don't need all columns at once.  We store them separately but haven't yet provide separate access (though I suspect that this is only a few lines of code)
How do we want to spell these queries?  The typical pandas/bcolz solution seems odd.
>>> c[['col1', 'col2', 'col3']]['2014-01': '2014-02']

Thoughts on throwing out getitem syntax for a method?
>>> c.select(start='2014-01', stop='2014-02', columns=['col1', 'col2'])

Or we could merge both getitems into one
>>> c['2014-01': '2014-02', ['col1', 'col2', 'col2'])

They all look odd, select still seems the most elegant but is inconsistent to  __getitem__

We might not want to use getitem until we actually know what we want to do with it.  It's hard to go back once that choice is made.

Upon further pondering I came to the conclusion, that:
>>> c['2014-01': '2014-02', ['col1', 'col2', 'col2'])

Is the best since it mimics Numpy 2D access. Providing either a single identifier, an iterable (not a tuple), or a slice should be permitted for both arguments.


Error in Hurdle Percentage Estimates

So I'm not much of a coder but decently good with numbers and I noticed a problem with the way the program is calculating the hurdle figures. I've run some calculations based on its numbers and I'm reasonably certain it's deriving the hurdles from this equation:
H = (100%)(D + R)/(2R)
where H = estimated hurdle percentage, D = vote differential, and R = estimated votes remaining.
This seems fairly accurate, but it's actually wrong. Let me explain why with the following system of equations:
L - W = D
L + W = R
where L = # of currently losing candidate's (Trump or Biden) remaining votes if they make the hurdle, W = # of currently winning candidate's (Trump or Biden) remaining votes if the other one makes the hurdle, and D and R are the same as what I defined them as before.
The rationale here is pretty simple. If the currently losing candidate is to beat the currently winning candidate, then in the remaining votes, the losing candidate must beat the winning candidate by a margin greater than or equal to the current vote differential, D (i.e., the first equation). And obviously Biden and Trump's remaining votes have to sum to the total number of remaining votes, R (i.e., the second equation).
Solving by elimination, we get:
2L = D + R
L = (D + R)/2
Then we just divide L by R and multiply the quotient by 100 percent to get the hurdle percentage, H:
H = (100%)(D + R)/(2R)
As you can see, this is exactly the same equation that I said I believe the program is using now. So where's the error? It's actually in our original system of equations. Remember when I said Biden and Trump's remaining votes have to sum to the total number of remaining votes? That's only true if every single vote was cast for Biden or Trump. We're ignoring the small fraction of non-Biden, non-Trump votes (i.e., third-party, independent, and write-in votes).
There's no perfect way to account for these votes since we don't know what the proportion of non-Biden, non-Trump votes will be among the remaining votes. However, we can approximate it by calculating that proportion for the votes already counted. Scaling down the right side of our second equation on this basis, our amended system of equations is:
L - W = D
L + W = R(B + T)/S
where B = # of current Biden votes, T = # of current Trump votes, and S = sum of all current votes.
Reworking the math, we find:
H = (100%)(D + R(B + T)/S)/(2R)
Even though the program's hurdle percentages tended to be only ~0.6 percent off from the ones I calculated using the amended equation, considering how close this race is, I think fixing the error is warranted. And while my equation is also flawed as it assumes the proportion of non-Biden, non-Trump votes won't change, estimating that proportion is far better than disregarding it altogether.
That being said, I'm a coding amateur at best and don't trust myself to work with the files. I'm just putting this out there so that someone who's better at this stuff than I am can make what I assume is a very small edit.

This is a good issue! Our actual equation is even dumber than the one you derived, but you're right, we're not accounting for Libertarians. Looking into it!

This is a good issue! Our actual equation is even dumber than the one you derived, but you're right, we're not accounting for Libertarians. Looking into it!

No problem! I'm glad I could help.

Will do. Of course, we'll leave this issue open for now.

Yep! We'll make sure the PR closes this issue when it gets merge (someone is taking a shot at a making fix atm).

@AutumnMystic Thanks for the fantastic report! We've merged your suggested fix and the site should update shortly (<=5m) with better information.

If you're curious about what was involved this should take you to the diff: https://github.com/alex/nyt-2020-election-scraper/pull/200/files

@thomasdesr Thanks! I checked the new Georgia numbers and they match my figures.


Update scalafmt-core to 3.3.1

Updates org.scalameta:scalafmt-core from 3.3.0 to 3.3.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #1899 (8d2ec32) into main (1f2e30f) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
- Coverage   86.33%   86.21%   -0.12%
==========================================
  Files          73       73
  Lines        2532     2532
  Branches      134      130       -4
==========================================
- Hits         2186     2183       -3
- Misses        346      349       +3

Impacted Files
Coverage Δ

...re/shared/src/main/scala/io/circe/KeyDecoder.scala
97.50% <0.00%> (-2.50%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
87.13% <0.00%> (-1.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f2e30f...8d2ec32. Read the comment docs.


feature add: raw_arg

This is needed for some arguments to work correctly on some commands:
https://doc.rust-lang.org/nightly/std/os/windows/process/trait.CommandExt.html#tymethod.raw_arg
related to: https://github.com/rust-lang/rust/issues/29494

Since windows_process_extensions_raw_arg was stabilized on Rust 1.62, I would accept a patch to support this on 1.62+ using the build script.
It would also be nice to do #6 at the same release, considering that the standard library has determined that sealing the CommandExt will not cause breakage (https://github.com/rust-lang/rust/pull/81975).


[decorations] renderWhitespace collides with before decoration

re #8268

set renderWhitespace to true
have a before decoration with a width

🐛 the width is ignored

duplicate of #11485


[New game]: Save The Mouse

🎮 Game Request
This game provides you with a single path within which you have to keep your mouse and go all the way to the safe zone. If the mouse gets out of the predefined area, the game is over.
Point down the features

Challenging
Fun
Addictive

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Sriparno08 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Sriparno08 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Update SUMMARY.md

Forgot to add new page to the summary, my bad!

Thanks! I may be able to review later today
On Apr 23, 2023 8:56 AM, Fin Mead @.***> wrote:
Caution: EXT Email
Forgot to add new page to the summary, my bad!

You can view, comment on, or merge this pull request online at:
https://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11
Commit Summary

0cee40ehttps://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11/commits/0cee40e27c547b2ba6c61db41ca01b9ea6308528 Update SUMMARY.md

File Changes
(1 filehttps://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11/files)

M SUMMARY.mdhttps://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11/files#diff-4f74b24c8cd7466c1c46dc972d8e284ed47091160afda95a432cc000f2eceb4a (1)

Patch Links:

https://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11.patch
https://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11.diff

—
Reply to this email directly, view it on GitHubhttps://github.com/NXPHoverGames/GitBook-NavQPlus/pull/11, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACQFV7UAILAMCIEVLAMQZYLXCUYH3ANCNFSM6AAAAAAXIRSTH4.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


K8's 1.31 Support for Gengo

Support Gengo for 1.31

This should be done after wrangler has been updated to support k8s 1.31. The only other two frameworks repos that reference this are steve and webhook, and looks like only because they depend on wrangler.

There's nothing left to do here.  Issue #47207 covers moving away from gengo (v1)


Makes sync_media_s3 multithreaded.

If you have a huge media directory, this will be pretty helpful.

Think this could be very helpful.
But its kind of a large patch and since I do not use S3, it's hard for me to check.
Anybody who uses S3 cares to help get this merged ?


[Feature Request] EmuLibrary Integration

Right now when scanning games from the EmuLibrary extension to pull Retroachivements sets creates an empty json, you also don't have the option to manually scan it because it counts as a store.

https://github.com/Lacro59/playnite-successstory-plugin/commit/8c26353ceab3fa8bd99730fc4a031bd92c36bd3a


Add an about.html page to talk about the team

We already have a docs folder that a file named about.html should go into.

@mickeymond I want to pick this issue up


how to include dht22 library (import third party library) error in CMakeLists.txt file (IDFGH-2493)

I have to interface dht22 sensor in ESP32 using esp-idf.I refered https://github.com/UncleRus/esp-idf-lib for dht22 and i was unable to include the dht lib.Can you please help me with the CmakeList.txt file and the Make file to include path.The issue after following the procedure in above link is that esp32 is restarting.I didnt know how CmakeList file works.

Hi @ravishree19, so you are able to build a project using the library you mentioned successfully?

Hi @ravishree19, so you are able to build a project using the library you mentioned successfully?

yes bt after flashing esp32 is restarting below are the screenshots.

@ravishree19 Since the build succeeds, I would guess that the library you were trying to use got 'imported' correctly. The error at runtime is a totally different issue, and from what I can see in the logs, is with the third-party library.
Unfortunately, you would have to file this issue with the author of the library you were trying to use.

@renzbagaporo Thanks for the support. @ravishree19 Thanks for reporting, for "how" question or "third party issues", suggest you could create a post on our forum at https://esp32.com or file the issue with the author of the library you were trying to use. Will close the ticket for now. Thanks.


How to handle closing socket connections?

When implementing the @effection/websocket-server, I implemented it as a Subscription<Connection> where each item in the connection represents a new connection. Unfortunately this doesn't really work for a few reasons:

There is currently no elegant way to iterate this and spawn a new task for each connection. See #332
It is unclear when a connection should be closed from the server end. We don't want websocket connections to dangle unless they are actually being processed. Once we are "done" with a connection on the server, we should close it. This could also occur if there is an error in the connection.
Error handling is unclear. What happens if there is an error in a connection, should it crash the entire server, or just this connection?

We should come up with a better API which solves these problems.

I think that the part of the api that is right is modeling both sides of the connection as a finite subscription of messages.

if the client closes the connection, the subscription on the server finishes
if the server closes the connection, the subscription on the client finishes

On top of that, we need to be able to handle errors at each level of the lifecycle: tree server -> connection -> message
On the server:

if an error happens on the server, it can be mitigated without crashing the spawner of the resource.

might need to see all open connections in order to customize the shutdown of each?

if an error happens with a single connection, it can be handled without effecting the server.
if an error happens with a single message, it can be mitigated without effecting the connection.

Could we make it so that each connection visitor is automatically spawned in the server scope, and each message visitor is automatically spawned in the connection scope? E.g.
run(function* () {
  let server = yield createWebSocketServer();
  try {
    // each visitor is automatically spawned in the server scope.
    // errors are propagated to the calling scope.
    // operation blocks forever
    yield server.forEach(function*(connection) {
      try {
        // each visitor is automatically spawned in a connection scope
        // errors are propgated to connection.
        // operation blocks until connection close
        yield connection.forEach(function*(message) {
          try {
            // handle message
          } catch (error) {
            console.log('message level error');
          }
        });
      } catch (error) {
        console.log('connection level error')
      }
    });
  } catch (error) {
    console.log('server level error')
  }
});

We could do this with a forAll operation on subscription, but it's difficult for me to imagine ever wanting to not do this, so maybe it makes sense to just do this with forEach here. In other words, it's always invoked asynchronously.

We need to re-think websocket connection in the context of v3 streams and iteration. Closing for now until some best practices start emerging.


missing command exist on original doc: https://databricks-training.s3…

Hi, I found missing command exist on original english document.
Next command will cause error without this missing command.
Thanks for sharing great articles.

Thanks for fix !


Sharp (#) in url is not handled elegantly

Describe the bug
If there's a # in the url (e.g. http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome), it can't be pinned with ipfs companion.
To Reproduce
Steps to reproduce the behavior:

Go to http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome
Click on 'Pin IPFS Recource'
Open ipfs-companion panal again
It shows it's not pinned

Expected behavior
http://element-web.0x1a8510f2.space.ipns.localhost:8081/#/welcome should be pinned as /ipns/element-web.0x1a8510f2.space. That is, it should strip the # suffix, because they are not part of the path in the resource
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Of course,
ipfs pin add /ipns/element-web.0x1a8510f2.space/#/welcome
Error: no link named "#" under QmSmQSREw7PtCNLDC4LxAoi8eWwj3tSCtJGaqXJFjKwA5S

But many sites redirects to a # url automatically. And the ipfs companion's pinning workflow doesn't allow editing.

I believe this is no longer an issue since #810 replaced pinning with import to IPFS.


[YBUG.IO] When clicking trade on main page...

When clicking trade on main page for lending, am brought to a 404.
Source url: https://live.sovryn.app/loans
Reported by:
Reported at: 23 Apr at 02:12 UTC
Location: CA, Ontario, Kitchener
Browser: Chrome 90.0.4430.85
OS: macOS 10.15.7
Screen: 1440x900
Viewport: 1440x692
Screenshot:

For more details please visit report page on Ybug:
https://ybug.io/dashboard/reports/detail/tab5dhgy3zacqq7fd4s0

To replicate this, open https://live.sovryn.app/ and click Lending section "Trade" button:

Button text should be updated to "Lend", and link updated to correct one: https://live.sovryn.app/lend
In addition, the Swap section "Swap" button is using the ?swap query param in the redirect, but it isn't working - we should adjust this so that it uses the redux state to set swap as active tab, before redirecting to https://live.sovryn.app/trade in the same way as header menu - sample code here: https://github.com/DistributedCollective/Sovryn-frontend/blob/97d25885d1521c1320d0a08fff9c40401daab1e3/src/app/components/Header/index.tsx#L142