Update teams-contact-center.md

Proposed small change to our company name: 'ROGER365.io' instead of Roger365

Docs Build status updates of commit 0df0cbb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/teams-contact-center.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@cazawideh PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

Reassigning to @wlibebe who the writer for this area is now


[Bug]: Eufy T8520 battery draining rapidly after eufy-security-ws 1.8.0 update

Version
1.8.0
Node version
16.20.0
Operating System type
Linux
Operating system version
Synology DSM 7.2
Describe the bug
Since upgrading eufy-security-ws to version 1.8.0, my Eufy T8520 lock is draining its battery much more rapidly than before.

To reproduce

Screenshots & Logfiles
No response
Additional context
No response

Seeing this also on both my locks


Implement Flask server

Building on #4, #3, #2: given a URL, unescape it and treat it as a UCUM code, serving HTML+RDFa with links to Turtle and JSON-LD files

This is being built in a separate repo: https://github.com/ontodev/units-demo


Nested arrays

! @tranma @jystic
/jury approved @tranma

:eye:'d the C
👍

👍 seems to working in production


Added support for TensorStridedSliceUpdate

This adds support for using the StridedSliceAssign op on tensors, similar to TensorScatterUpdate. To remain consistent, the new op is named TensorStridedSliceUpdate. We need this to add support for efficient tensor strided slice setters in Swift for TensorFlow. The relevant PR and comments can be found here.
@alextp does this look ok? I cannot currently compile and test on my machine, but I hope I'll be able to do so tomorrow.

Thanks Alex! I made some fixes and added support for the op in the public python API (through the strided slice assignment operator).

@alextp there was a typo and a test that does not apply anymore that should be fixed now.

(for tf-api-owners) This should not be visible in the Python API except as a raw_op. Can you remove the exposure via Python and re-run the API compatibility test to regenerate the goldens?

@karmel Do I need to do something about this or is it just the tf-api-owners?

@eaplatanios I think you need to rerun the api_compatibility_test with --update_goldens=True

@alextp @karmel I rerun the API compatibility test and committed the updated files.

Can we run the tests again to verify there are no remaining issues?

=== Sanity check step 4 of 13: do_buildifier (buildifier check) ===
Running do_buildifier on 440 files
tensorflow/core/kernels/BUILD # listsort unsafesort sort:tf_kernel_library.deps
buildifier took 0 s
FAIL: buildifier found errors and/or warnings in above BUILD files.
buildifier suggested the following changes:
151a152
>         ":inplace_ops",
154d154
<         ":inplace_ops",
Please fix manually or run buildifier <file> to auto-fix.

@alextp If this was due to the alphabetical ordering, it should have been fixed now. :)

All tests seem to pass now. Not sure what's wrong with the "android" and the "feedback" checks.

@alextp Is this ready to be merged now or should I do something further for the failing checks?

@eaplatanios it should be good to go, I'll retry internally

@alextp Sounds good, thanks! :)

This should be ready to merge now I guess.

When is this expected to be merged? I'm asking because it's currently blocking some features I'm working on for Swift for TensorFlow.

When is this expected to be merged? I'm asking because it's currently blocking some features I'm working on for Swift for TensorFlow.

Thanks for your contribution, this should be merged on Monday.

Thanks @rthadur! :)

Thanks @rthadur! :)


Plese help ... how solve "Permission needed. Ask Your IT Admin to enable this options for you"?

now am done this list but is show same error

permissions and Graphs APIs have been granted
Addmore in Graphs APIs https://user-images.githubusercontent.com/96084578/145883901-c256eaf1-bad7-4a3c-b225-211a1ef47e8e.png
3.-Going to the Teams Admin Center
-Selecting the Company Communicator Author App
-Clicking on "Permissions" tab
-Clicking on button "Review Permissions and Consent"
-Accepting the required permissions.

All Solution not Solve problems
who has take this error and can solve ???

Hi @arruzarmas ,
Thanks for raising the issue. Could you please send the repo url and branch you are pointing to?

https://github.com/onemtc/microsoft-teams-apps-company-communicator/tree/mibon/imagetranslateanalytics5.0

Hi @arruzarmas ,
Could you please cross verify the graph app registration secret has been correctly configured or not. And the repo URL seems to be a customized one. We won't be able to assist on that.
Thank you.

Hi @arruzarmas ,
Could you please cross verify the graph app registration secret has been correctly configured or not. And the repo URL seems to be a customized one. We won't be able to assist on that.
Thank you.

am recheck and add more from search solution in github...

Hi @arruzarmas ,
The repo that is being used is of customized one . We won't be able tp help on this.
Thank you.


Update Portal to use ReactDOM.createPortal

Steps
Mount a react component that has a modal form using enzyme and try searching for children nodes.
Expected Result
A call to wrapper.find(<content>) should return content with specified selector.
Actual Result
It's not possible to get modal content using enzyme wrapper.
Version
0.79.1

Agreed.  We'll need to plan release timing.  This will be part of a breaking change update that will require users to use React >=16 so they have the API.
There are other React 16 updates such as returning arrays and strings.  This can really help us in some areas.  Our Accordion has ugly markup and code due to not being able to return arrays.
At any rate, let's batch these changes into a major update.  PRs welcome!

Workaround
In the meantime, if you have to mount and test Modal code you can find the elements in the DOM using conventional DOM APIs.  This is in fact how our Moda tests have worked for years in the absence of a first-class Portal API.

Thanks @levithomason, I actually ended up using this suggestion.

Was fixed in #2755.


Unexpected input  vercel_protection_bypass_header

Issue Details
Environment:

App: Next.js v14.2.12
Context: A protection bypass for automation secret is set in Vercel and copied over to my GitHub Secrets but it doesn't seem to be working in the action.

GitHub Action Snippet:
- name: Waiting on the Vercel Preview
  uses<EMAIL_ADDRESS>  id: waitForDeploy
  with:
    token: ${{ secrets.GITHUB_TOKEN }}
    vercel_protection_bypass_header: ${{ secrets.VERCEL_PREVIEW_BYPASS_AUTH }}
    max_timeout: 300

Problem:
When running this action, I encounter the following warning:
Warning: Unexpected input(s) 'vercel_protection_bypass_header', valid inputs are ['token', 'max_timeout', 'environment', 'allow_inactive', 'check_interval', 'vercel_password', 'path']

Despite this, the action continues, but returns 401 errors on each of the 150 iterations, which leads me to think that something might be broken.
The input vercel_protection_bypass_header seems valid based on the README and the action.js file, but it isn't recognized.

Request:
Any suggestions or insights into resolving this issue would be greatly appreciated!

An update,  I had my secret setup incorrectly.  However I still see the warning from this action.

@beelarr That is probably because in that version the "vercel_protection_bypass_header" option is not documented in the action.yml. Therefore Github gives you that warning. It does however exist in the code and should work as expected.

Hi! I have the same issue with the newest 1.3.2 version.

Thanks @patrickedqvist !
@vilkg It seems that Vercel has updated some of their Protection Bypass for Automation and this action currently doesn't work with the bypass header.  If I get a few minutes I will look into fixing this.

@patrickedqvist Canary works great!!
If anyone else is following along here is my setup:
- name: Waiting on the Vercel Preview
uses: patrickedqvist/wait-for-vercel-preview@canary
id: waitForDeploy
with:
  token: ${{ secrets.GITHUB_TOKEN }}
  vercel_protection_bypass_secret: ${{ env.VERCEL_PREVIEW_BYPASS_AUTH }}
  max_attempts: 20
  retry_interval: 5

I'll be looking for the v2 release. Reach out if I can ever help with anything and thank you for working on this!!


[SUPPORT]client spark-submit cmd error:Caused by: java.lang.NoSuchMethodError: org.apache.spark.sql.execution.datasources.DataSourceUtils$.PARTITIONING_COLUMNS_KEY()Ljava/lang/String;

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:
code for example:
df.writeStream
      .queryName("kafka2Hudi")
      .outputMode("append")
      .option("truncate",false)
      .trigger(Trigger.ProcessingTime(2000))
      .foreachBatch { (batchDF:DataFrame, _: Long) => {
        batchDF.persist()
        println(LocalDateTime.now() + "start writing mor table")
        batchDF.write.format("org.apache.hudi")
          .option("hoodie.datasource.write.table.type", "COPY_ON_WRITE")
          .option("hoodie.datasource.write.operation","upsert")
          .option("hoodie.combine.before.insert", "true")
          .option("hoodie.combine.before.upsert", "true")
          .option("hoodie.table.name", "hudi_test4")
          .option("hoodie.bulkinsert.shuffle.parallelism","200")
          .option("hoodie.bulkinsert.shuffle.parallelism", "10")
          .option("hoodie.insert.shuffle.parallelism", "10")
          .option("hoodie.upsert.shuffle.parallelism", "10")
          .option("hoodie.datasource.write.precombine.field", "publish_time")
          .option("hoodie.datasource.write.recordkey.field", "id")      // id
          .option("hoodie.datasource.write.partitionpath.field", "partition_date")
          .option("hoodie.datasource.hive_sync.enable", "true")
          .option("hoodie.datasource.hive_sync.database", "ods")
          .option("hoodie.datasource.hive_sync.table", "hudi_test4")
          .option("hoodie.datasource.hive_sync.jdbcurl", "jdbc:hive2://xxxx:10000/")
          .option("hoodie.datasource.hive_sync.partition_fields", "partition_date")
          .option("hoodie.datasource.hive_sync.partition_extractor_class", classOf[MultiPartKeysValueExtractor].getName
          )
          .mode(SaveMode.Append)
          .save("..../ods.db/hudi_test4")
        println(LocalDateTime.now() + "finish")
        batchDF.unpersist()

      }
      }
      .start()
      .awaitTermination()

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.8.0

Spark version : 2.4.5

Hive version :  2.2.1

Hadoop version : 2.7

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) : no

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.
dependencies for ：
spark:2.4.5
scala:2.11.12
hudi-spark-bundle_2.11:0.8.0
hudi-hadoop-mr-bundle:0.8.0
error meeassage :
=== Streaming Query ===
Identifier: kafka2Hudi [id = 0b1db50e-2f7c-49a8-bf61-052415c18609, runId = 8798b3a8-0db1-4125-b8e3-9e2efc2ade0e]
Current Committed Offsets: {}
Current Available Offsets: {KafkaV2[Subscribe[smartnews-sentiment]]: {"smartnews-sentiment":{"8":1023541,"2":1024137,"5":1020474,"4":1021909,"7":1022019,"1":1022542,"9":1022066,"3":1021346,"6":1023235,"0":1022049}}}

Current State: ACTIVE
Thread State: RUNNABLE

Logical Plan:
Project [id#25, source_type#26, title#27, source#28, publish_time#29L, created_time#30L, url#31, from_unixtime(cast((cast(publish_time#29L as double) / cast(1000 as double)) as bigint), yyyy-MM-dd-HH, Some(Asia/Shanghai)) AS partition_date#39]
+- SubqueryAlias `kafkatable`
   +- Project [json_value#23.id AS id#25, json_value#23.source_type AS source_type#26, json_value#23.title AS title#27, json_value#23.source AS source#28, json_value#23.publish_time AS publish_time#29L, json_value#23.created_time AS created_time#30L, json_value#23.url AS url#31]
      +- Project [jsontostructs(StructField(id,StringType,false), StructField(source_type,StringType,false), StructField(title,StringType,false), StructField(source,StringType,false), StructField(publish_time,LongType,false), StructField(created_time,LongType,false), StructField(url,StringType,false), value#21, Some(Asia/Shanghai)) AS json_value#23]
         +- Project [cast(value#8 as string) AS value#21]
            +- StreamingExecutionRelation KafkaV2[Subscribe[smartnews-sentiment]], [key#7, value#8, topic#9, partition#10, offset#11L, timestamp#12, timestampType#13]

	at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:295)
	at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:189)
Caused by: java.lang.NoSuchMethodError: org.apache.spark.sql.execution.datasources.DataSourceUtils$.PARTITIONING_COLUMNS_KEY()Ljava/lang/String;
	at org.apache.hudi.DataSourceWriteOptions$.translateSqlOptions(DataSourceOptions.scala:206)
	at org.apache.hudi.DefaultSource.createRelation(DefaultSource.scala:139)
	at org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:45)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
	at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:86)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
	at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
	at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)

my hunch is that, your local spark version is 3.0.0 or higher. Can you try with 2.4.5.

The same thing happened on my Environment,
Environment Description
Hudi version : 0.9.0
Spark version : 2.4.0
Hive version : 2.2.1
Hadoop version : 3.0.0
Storage (HDFS) :
Running on Docker? (yes/no) : no

@mdz-doit @xer001 Tested locally with hudi-spark-bundle 0.8.0 as well 0.9.0 for Spark 2.4.7, it works for me. Environment specific issues are hard to debug. Could you please try on a common environment? See this docker demo.

@mdz-doit : can you please respond.

@codope @nsivabalan this seems like an issue with Spark 2 vs Spark 3, right. I am not following the connection to Hadoop 3.0

@xer001 @mdz-doit : Can you please check Raymond's comment above and respond.

Going ahead and closing out the issue as its a jar mismatch issue. If the above proposed solution does not work, please feel free to re-open or create a new issue. would be happy to assist.


[Issue] Case sensitivity

Even though you have text-transform: uppercase the projects are still case-sensitive, hence counted as different projects, although they are the same thing. In the first case I had to be Driving License and in the second case it was Driving license.

The text-transform: uppercase is meant for the display only. In the log data, they will be considered two separate projects. I will patch this; thanks for the heads up. :)
Also: are you on 0.1.3 already?

1.0 lets you edit entries :)

@joshavanier oh so you did a first release 1.0 :)
Congrats on that!
Yeah I have been on 0.1.3 at that point. If the issue is resolved in the new version, then thank you!


doc: fix typo on optimizer.py

Codecov Report

Merging #161 (7a366f1) into main (ea80a83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   89.55%   89.55%
=======================================
  Files          37       37
  Lines        3924     3924
=======================================
  Hits         3514     3514
  Misses        410      410

Impacted Files
Coverage Δ

strawberry_django_plus/optimizer.py
88.36% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


SARAALERT-1300 negated non-bool symptom value

When assigning a reviewer, tag their GitHub username in the reviewer checklist section below.
Description
Jira Ticket: SARAALERT-1300
Write out a concise summary of this pull request and what it addresses.
When a non-symptomatic SMS/Voice report comes through, the int/float symptoms are set to 0 instead of nil. This PR makes sure that int/float symptoms values are set to nil for non-symptomatic SMS/Voice assessments.
(Bugfix) How to Replicate
In report mode, submit a non-symptomatic assessment for a patient in a jurisdiction that has an int/float symptom eg: any of the State1 jurisdictions in the sample jurisdictions.yml included in the repo.
{"response_status": "success_sms","experiencing_symptoms":"No","patient_submission_token": "TYptUSsGmj","threshold_hash":"854613cf6657d5ebfef5babcc3eb0f1a465ac723859d4df0d1cdcd5ff321d165"}
See that the report that was generated has a int/float symptom value of 0.
(Bugfix) Solution
Insert description for the solution this PR implements to address the bug.
Repeat the steps above and see that the int/float symptom within the newly created report does not contain a value.
Checklists
Submitter:

[x] This PR describes why these changes were made.
[x] This PR is into the correct branch.
[x] This PR includes the correct JIRA ticket reference.
[x] Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, Chrome Dev Tools Lighthouse accessibility test has been executed to ensure no 508 issues were introduced. NA
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Test fixtures updated and documented as necessary NA

@ :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

@ :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

@ :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

Can you make sure to uncomment this test?

It looks like IntegerSymptom and FloatSymptom do have negate defined (see here and here. I only see those functions being used in clone_symptoms_negate_bool_values, so I think it makes sense to either update those functions, so that they return nil instead of 0 and 0.0, or to keep the current code and just remove those functions from IntegerSymptom and FloatSymptom.

Negate means to make a symptom not meet the symptomatic definition so I wouldn't opt to set them to nil. I will consider deleting the negate functions on Float and Int symptoms as they should not be called anywhere my only concern lies with how symptoms are typically handled as their super class Symptom and in the event negate is accidentally called on a non BoolSymptom it will result in a show stopping error rather than a saved assessment with symptom values that might not make sense.

It looks like IntegerSymptom and FloatSymptom do have negate defined (see here and here. I only see those functions being used in clone_symptoms_negate_bool_values, so I think it makes sense to either update those functions, so that they return nil instead of 0 and 0.0, or to keep the current code and just remove those functions from IntegerSymptom and FloatSymptom.

Addressed here https://github.com/SaraAlert/SaraAlert/pull/786/commits/aed353ea1019474fed17b97d4fab5913dd5ab0e2

Needs rebase


Should we apply face alignment for evaluation data?

Hi~
Thank you for your great work.
Does the reported accuracy result on validation data (e.g. LFW, MegaFace) apply face alignment process (e.g., MTCNN)?
Thank you.

@lymanblue  All the training and validation/test data have been aligned by MTCNN to the size of 112*112

Thanks.
And there is no file like ms1m.py in dataset directory.
Would you provide the file in the future?
Or is the data loader of ms1m the same with other dataset loader?
Does the training results of the cleaned-MS1M is the same with the MS1M-V2 provided from InsightFace?
Thank you.

@lymanblue  The cleaned-MS1M I used is provided by DeepGlint, it only has 3.9M images, while InsightFace has a 5.8M cleaned version.
The dataloader of MS1M is as same as the CASIA-WebFace.

Therefore, we have to preprocess (e.g., face alignment) the cleaned-MS1M of DeepGlint by ourself with the aid of the msra_lmk file.
On the other hand, ff we use the MS1M-V2 (already aligned?) from InsightFace.
Can we use the CASIA-WebFace loader directly for training?
Thank you.

Is the MS1M-IBUG from InsightFace the cropped and aligned result of the cleaned-MS1M?

You can use your own data (MS1M-V2) to train the models directly.

For training the model directly from MS1M-V2 from InsightFace.
Do you mean the following steps? (e.g., LFW for validation)

set --train_root to the faces_emore/train.rec in train.py
set --train_file_list to the faces_emore/train.idx in train.py
set --lfw_test to the faces_emore/lfw.bin in train.py
set --lfw_file_list to the path of txt file (i.e., from http://vis-www.cs.umass.edu/lfw/pairs.txt)

Thank you.

No, train.rec and train.idx are the mxnet's data format, the dataloader I provided is suitable for images,just like this:
00000
00000-00001.jpg
00000-00002.jpg
00000-00003.jpg
00001
00001-00001.jpg
00001-00002.jpg
00001-00003.jpg

Thank you~!
Could we use the the prepare_data.py from https://github.com/TreB1eN/InsightFace_Pytorch to convert the mxnet's format to the specified format?
The data format looks similar. (if identical would be better).

Well, you can use it to parse the train.rec file to get original images.

model

请问您使用预训练模型了吗？
Have you used the pre training model?


Move secrets refresh task out of auth-webhook app startup

We see somewhat frequent issues with gunicorn killing auth-webhook workers after claiming that they failed to start, with no apparent reason as to why they might be considered to have failed to start. This attempts to address this by moving the secret refresh task entirely out of the startup process and instead kick it off on the first request. This does mean that that first request will need to wait a bit for the secrets to be loaded, so some logic was added to handle the case where the secrets are not available but are actively being fetched.

Closed in favor of #171 which is a less invasive fix.


improve aws cloudwatch scaler metrics pulling logic

Signed-off-by: Xiayang Wu<EMAIL_ADDRESS>
Provide a description of what has been changed
To address the issues mentioned in https://github.com/kedacore/keda/issues/2242
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs/pull/568
[x] Changelog has been updated

Fixes #

Truncate/Round down the endtime based on the metrics period setting to provide better performance and avoid getting empty data
startTime to be based on the endTime(to avoid two time.now() calls)
Add a new param named metricEndTimeOffset to allow skipping the most recent data point from cloudwatch
Add a new param named metricUnit to allow passing a metric Unit which is needed by some metrics

Could you please update docs and fix the linter problems? https://github.com/kedacore/keda/runs/4089628384?check_suite_focus=true

@fivesheep fyi you can run the static check locally if you configur precommit or you can run make golangci. This should help you tackling the linter problems.

@JorTurFer a couple more changes were made to fix the linting issue. need to introduce two helper function to reduce the number of if-elses, please review again. thx!

LGTM!
Let's wait until the validations are finished to check that all is good.
BTW, thanks a ton for your effort updating this AWS scaler! ❤ ❤

One more thing, could you update the CHANGELOG please?

There's a timeout on the failed check, not sure how to re-trigger it

Thanks! :)
Maybe @zroubalik could re-execute it. Let's wait until he has time

Once comments on doc PR are resolved we can merge this :)

Thanks a lot for the contribution!


Add some methods to wal page

Proposal
Why
Better encapsulation.
Action
page.buf abstracts three methods

func (*page) alloc() []byte

Include the following codes
https://github.com/prometheus/prometheus/blob/7d43feb03ffca86276bf6dd47b618b6986c6583a/tsdb/wal/wal.go#L489

func (*page) remaining() []byte

Include the following codes
https://github.com/prometheus/prometheus/blob/7d43feb03ffca86276bf6dd47b618b6986c6583a/tsdb/wal/wal.go#L611

func (*page) reset()

Include the following codes
https://github.com/prometheus/prometheus/blob/7d43feb03ffca86276bf6dd47b618b6986c6583a/tsdb/wal/wal.go#L497-L501

Based on the outcome of the discussion in #5967, I'm closing this. Please speak up if you disagree.


Failed to start Docker Application Container Engine

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Environment:

Cloud provider or hardware configuration:
Bare metal

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
Linux 3.10.0-693.21.1.el7.x86_64 x86_64
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

Version of Ansible (ansible --version):
ansible <IP_ADDRESS>

Kubespray version (commit) (git rev-parse --short HEAD):
d73d60c9
Network plugin used:
Flannel
Copy of your inventory file:
[all]
*1.net 	 ansible_host=*.*.*.71 ip=*.*.*.71
*2.net 	 ansible_host=*.*.*.72 ip=*.*.*.72
*3.net 	 ansible_host=*.*.*.73 ip=*.*.*.73
*4.net 	 ansible_host=*.*.*.74 ip=*.*.*.74
*5.net 	 ansible_host=*.*.*.75 ip=*.*.*.75

[kube-master]
*1.net
*2.net

[kube-node]
*1.net
*2.net
*3.net
*4.net
*5.net

[etcd]
*1.net
*2.net
*3.net

[k8s-cluster:children]
kube-node
kube-master

[calico-rr]

[vault]
*1.net
*2.net
*3.net

Command used to invoke ansible:
ansible-playbook -i inventory/mycluster/hosts.ini scale.yml -b -v -u root

Output of ansible run:

RUNNING HANDLER [docker : Docker | reload docker] *************************************************************************************************************************************************************************************************
Wednesday 09 May 2018  10:16:41 -0400 (0:00:00.032)       0:01:42.390 *********
fatal: [dmetal3.cogolo.net]: FAILED! => {"changed": false, "msg": "Unable to restart service docker: Job for docker.service failed because the control process exited with error code. See \"systemctl status docker.service\" and \"journalctl -xe\" for details.\n"}

Anything else do we need to know:

First I ran:
ansible-playbook -i inventory/mycluster/hosts.ini cluster.yml -b -v -u root

Which worked perfectly but we found a conflict with metallb and calico so I changed the network settings and ran
ansible-playbook -i inventory/mycluster/hosts.ini reset.yml -b -v -u root
ansible-playbook -i inventory/mycluster/hosts.ini cluster.yml -b -v -u root

And 4/5 nodes came up perfect, node3 did not
It looks like the docker.service file is failing to start:
[root@*3 ~]# journalctl -n 100 -f -u docker
May 08 16:57:12 *3.net systemd[1]: Failed to start Docker Application Container Engine.
May 08 17:02:21 *3.net dockerd[29723]: time="2018-05-08T17:02:21.310015681-04:00" level=warning msg="[!]
May 08 17:02:22 *3.net dockerd[29723]: time="2018-05-08T17:02:22.329840278-04:00" level=warning msg="Using pre-4.0.0 kernel for overlay2, mount failures may require kernel update"
May 08 17:02:39 *3.net dockerd[29723]: time="2018-05-08T17:02:39.951331121-04:00" level=info msg="stopping containerd after receiving terminated"
May 08 17:02:41 *3.net dockerd[30165]: Status: invalid argument "172.162.50" for --dns: 172.162.50 is not an ip address

I also tried remove-node.yml to try and reset node3 to its previous state.
Any help here would be really appreciated!

I resolved the docker issue by manually fixing the typo in the /etc/resolv.conf and the docker-dns.conf but then I got The conditional check 'etcd_cluster_is_healthy.rc == 0' failed. The error was: error while evaluating conditional (etcd_cluster_is_healthy.rc == 0): 'etcd_cluster_is_healthy' is undefined\n\n


uploads with mutable batches should only override chunks on index collision if a header is specified

We can make the immutable stamps the default purchase. If the user is fine with losing data, they can use mutable flags.

Once it is out, it needs to be communicated to the communicated. It chancges the API in any of the two solutions and the default behaviour.

default batch type is now immutable.


Integrate video volume with sound system

Provide some basic volume integration between video widgets and the sound system.  Perhaps create a pseudo "video" track that cannot play sounds, but can be used to control the volume of videos (including ducking).  Master volume setting in sound_system should also be applied to videos.  The upcoming track_player could also be used to automate the "video track".

Can we use a kivy binding to multiply video volume to master volume


The hierarchy tree map causes play mode colors to be displayed incorrectly

If you have changed the colors in play mode, some of the colors will become strange when you enable the Hierarchy tree.

Fixed in #94


onReconnect() does not trigger

I have setup my bot with the following listener
@Override
public void onReady(ReadyEvent event) {
   LOG.info("Connected to Discord");
}

@Override
public void onDisconnect(DisconnectEvent event) {
   CloseCode code = event.getCloseCode();
   String reason = (code == null) ? null : code.getMeaning();
   LOG.info("Disconnected from Discord, reason: {}", reason);
}

@Override
public void onReconnect(ReconnectedEvent event) {
   LOG.info("Successfully reconnected to Discord");
}

While onReady and onDisconnect are properly triggered onReconnect is never called despite the bot managing to reconnect to Discord immediately after a disconnect event has been thrown. The JDA instance is set to automatically reconnect.

onResume is called if a full reconnect is not needed. Resume and Reconnect both imply that the connection has been restored. Resume means it was done within a small enough time frame that the internal cache did not need to be invalidated, and it is a cheap reconnection. Reconnect means that discord requested cache invalidation due to being disconnected for too long. In this case, all JDA entities are destroyed and rebuilt upon reconnecting to discord.
Thus, Resume vs Reconnect.


Use the latest @types/svgo typing

@types/svgo is deprecated: https://www.npmjs.com/package/@types/svgo

While it's still being used as typing source : https://github.com/gregberge/svgr/blob/main/packages/core/package.json#L48
It's better to upgrade the svgo typing

@JunlinPan-Crypto thanks, feel free to submit a PR to fix it.

Fixed by using svgo v3.


[Feature Request] Support configurable timeout for requests

Hi, I notice that the implementation of the Transport class ultimately supports passing in a request timeout value as a parameter.
However, this does not seem to be exposed any where in the options to allow us to configure this value. Would be nice to have this, cheers!

@cy-cdc , could you please share the code snippet you're using?


Add more unit test cases for EditableText widget

Description
Add regression test for #66036
The root cause of the issue is that the keyboard was requested incorrectly after receiving repeated updated values.
I added some test cases to test this situation, and also tested the scenario where the keyboard is hidden.
Related Issues
#66036
Tests
See files.

(PR triage): @xu-baolin Do you have plans to come back to this soon to address the feedback? Thanks.

(PR triage): @xu-baolin Do you have plans to come back to this soon to address the feedback? Thanks.

I'm sorry I didn't reply in time. I'll finish my holiday tomorrow and get back to work right away.

Just some periods to fix quickly, then this is ready to merge.

Sorry for not understanding what you mean, it has been fixed now

Thanks, it will be merged when the tree is green now!


Framework not found TwilioVoice

Did you follow all the instructions as specified in the Twilio Quickstart repositories?
Actually I didn't get this far
What version of React Native are you running?
0.52.0
What version of react-native-twilio-programmable-voice are you running?
3.18.0
What device are you using? (e.g iOS10 simulator, Android 7 device)?
iPhone 6s
Is your app running in foreground, background or not running?
Not running
Is there any relevant message in the log?
When trying to build, the build fails with "Framework not found TwilioVoice"
If using iOS, which pod version are you using?
Cocoapods 1.5.0, pod 'TwilioVoice', '~> 2.0.0'
Step to reproduce

yarn add react-native-programmable-voice
react-native link react-native-programmable-voice
pod init
Edited Podfile like so:

# Uncomment the next line to define a global platform for your project
platform :ios, '9.0'

target 'yotribe' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for yotribe
  pod 'TwilioVoice', '~> 2.0.0'
  pod 'RNTwilioVoice', path: '../node_modules/react-native-twilio-programmable-voice'
  target 'yotribeTests' do
    inherit! :search_paths
    # Pods for testing
  end

end```

5. Tried to run app on iPhone
6. Build failed with said error

Any ideas?

Thanks!
Leonard

I ran into this issue before and it has to do with Xcode not initializing the TwilioVoice framework correctly. There was no one task that fixed it for me, but some things that did eventually work for me was running ‘pod deintegrate’ with Xcode closed, then pod init to rebuild the pods folder.
I’ve literally seen this error popup on one build, restart Xcode, then it will go away. Assuming everything is connected up correctly then TwilioVoice should be linked.
I even had success with changing the order, dragging and dropping, of the linked frameworks in Xcode.
You also want to be opening the .xcworkspace folder in Xcode to make sure your pods are being recognized.
I also tried setting the pods file build for TwilioVoice to be an exact version using = instead of ~>
I know that error is frustrating, and you can thank Xcode for that.

On May 1, 2018, at 11:22 AM, nxz91<EMAIL_ADDRESS>wrote:
Did you follow all the instructions as specified in the Twilio Quickstart repositories?
Actually I didn't get this far
What version of React Native are you running?
0.52.0
What version of react-native-twilio-programmable-voice are you running?
3.18.0
What device are you using? (e.g iOS10 simulator, Android 7 device)?
iPhone 6s
Is your app running in foreground, background or not running?
Not running
Is there any relevant message in the log?
When trying to build, the build fails with "Framework not found TwilioVoice"
If using iOS, which pod version are you using?
Cocoapods 1.5.0, pod 'TwilioVoice', '~> 2.0.0'
Step to reproduce
yarn add react-native-programmable-voice
react-native link react-native-programmable-voice
pod init
Edited Podfile like so:
Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'yotribe' do
Uncomment the next line if you're using Swift or would like to use dynamic frameworks
use_frameworks!
Pods for yotribe
pod 'TwilioVoice', '~> 2.0.0'
pod 'RNTwilioVoice', path: '../node_modules/react-native-twilio-programmable-voice'
target 'yotribeTests' do
inherit! :search_paths
# Pods for testing
end
end```

Tried to run app on iPhone
Build failed with said error

Any ideas?
Thanks!
Leonard
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you! I finally could build after creating an app using react-native init from scratch and moving all resources back in there.


ui5-middleware-serveframework + ui5-test-runner issue?

Hi,
I noticed that test-runner fails if ui5-middleware-serveframework is used.
Steps to reproduce the behavior:

Go to https://github.com/SAP/openui5-sample-app
Add to ui5.yaml

...
server:
  customMiddleware:
    - name: ui5-middleware-serveframework
      afterMiddleware: compression

    - name: "@ui5/middleware-code-coverage"
      afterMiddleware: compression
      configuration:
        excludePatterns:
          - "resources/"
          - "test/"

Expected behavior
Test runner executes.
Report
Died on test #1     at http://localhost:8080/resources/sap/ui/test/starter/runTest.js:1112:6559: Called start() while test already started running
⠙ Generating reports
Error: Command failed with exit code<PHONE_NUMBER>: npm run test-runner
    at makeError (C:\workspace\samples\openui5-sample-app\node_modules\execa\lib\error.js:60:11)
    at handlePromise (C:\workspace\samples\openui5-sample-app\node_modules\execa\index.js:118:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  shortMessage: 'Command failed with exit code<PHONE_NUMBER>: npm run test-runner',
  command: 'npm run test-runner',
  escapedCommand: '"npm run test-runner"',
  exitCode:<PHONE_NUMBER>,

BR,
Jacek

Hello ! I was able to reproduce the issue. For some reasons, when the ui5-middleware-serveframework is being used, the tests are either starting too soon or twice. I am qualifying.

Did some progress in my investigation : ui5-test-runner opens the pages with some preloaded scripts that hook important events during the loading of the tests. For some technical reasons, it seems like this generates bad interactions with the compiled version of UI5 resources.

Source of the problem : https://github.com/ArnaudBuchholz/ui5-test-runner/blob/84c0dce0d36a082b4558e6072bd49aaf57311450/src/inject/qunit-intercept.js
This code was created to handle asynchronous loading of QUnit : QUnit hooks might be registered before QUnit is actually loaded. This code defers the executions of the hooks but somewhat conflicts with the logic implemented in the new test runner.

Hello ! I released version 5.3.7 that fixes the issue. can you please test and close the incident ?

Worked, thanks for prompt reaction 👌


[BEAM-8206] Fix syntax errors in Java doc for PipelineRunner

Fix syntax errors in Java doc for PipelineRunner, i.e.,

R: @dmvk :)

Anything missing on this one?


Fix up 1.9.0 migration for new parentid

We might also be generating openapi slightly differently in develop?

Why no travis-ci?

ERROR [2020-03-25 19:39:04,918] org.apache.tomcat.jdbc.pool.ConnectionPool: Unable to create initial connections of pool.

! org.postgresql.util.PSQLException: FATAL: remaining connection slots are reserved for non-replication superuser connections

! at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2440)

boo

Three times, sigh.


update spanish translations

Bug fixes.

not it's conflicts, please use the latest files.
and there are some new translations.


Simplify code and avoid duplicate lookups where possible.

Replace calls to find followed by emplace with a single insert where possible without adding additional overhead. Use insert instead of emplace in some cases where it is expected that the operation can fail. insert is more efficient than emplace because emplace always has to create the internal node before checking if another entry with the same key already exists.

Fixed by merging #7197.


Upgrade to cardano-cli-<IP_ADDRESS> and cardano-api-<IP_ADDRESS>

Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests
integration tests
See Runnings tests for more details

[ ] Any changes are noted in the CHANGELOG.md for affected package
[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

Kind of superceded by https://github.com/IntersectMBO/cardano-node/pull/5621 ?


Adopt some deprecated charts

Helm chart name
navidrome
Describe the solution you'd like
After the news of #1761 (which I totally understand, btw) I am willing to take ownership of some of the charts that I am using. I already have a small repo of helm charts. I'm a bit reluctant to take on extra responsibility, but it's important to me that these charts don't rot.
Is there a process where interested people can claim/adopt charts? I'm already using these charts below, and I can probably find a home for most or all of them.

homer
navidrome
webtrees
joplin-server
bookstack
littlelink
paperless
photoprism
uptime-kuma

Thanks,
Jonathan
Additional Information
No response

It's an open ball field, there is no process. Take which charts you want, fork bjw-s/helm-charts and put them in that repo, wire up the CI bits and hopefully there's not many issues.


Song crashes

What is your question?
so i'm working on a mod for a while now and today when i tried to play a song, the song carshes.
It's not the game itself because other songs dosen't crash and it isn't the difficulty.
Please help me

are you using lua or source to make the mod?
did you use an lua script in the song?
is there an error message when it crashes?
if so does it say anything?
you have to provide details, and not just say "my game crashed"

i use lua and source but the song it's in lua
i just used a credits script but the same script is in all the songs
no it dosen't it just crashes on the first note

@BrightEyesFox

i use lua and source but the song it's in lua
i just used a credits script but the same script is in all the songs
no it dosen't it just crashes on the first note

can you send the script then? also try removing the song script and see if the game still crashes

ok

the song crashed anyways

the song crashed anyways

then idk what your problem is


Wrong RadioAriaProps interface name for useRadio

In https://react-spectrum.adobe.com/react-aria/useRadioGroup.html
useRadio(
  props: RadioAriaProps,
  state: RadioGroupState,
  ref: RefObject<HTMLElement>
): RadioAria

Is: RadioAriaProps
Should be: AriaRadioProps

Thanks for noting this, looks like we just need to rename here<EMAIL_ADDRESS>

Ah, actually that type extends from AriaRadioProps, this is correct.

@LFDanLu yeah, but it's not exported, so there is no way to use it. IMO the docs are misleading.

@schabluk Do you need that type specifically? I'm not entirely sure what you mean by misleading.

@LFDanLu yes, I need it to type component props that are required by useRadio. The docs suggest RadioAriaProps which is not exported from @react-types/radio. How should I know which type to use?
import * as React from 'react'
import { useRadio } from '@react-aria/radio'
import type { AriaRadioProps } from '@react-types/radio'

import { RadioContext } from './RadioGroup'

export default function RadioButton(props: AriaRadioProps) {
  const ref = React.useRef<HTMLInputElement>(null)
  const state = React.useContext(RadioContext)
  const { inputProps } = useRadio(props, state, ref)

  return (
    <label>
      <input ref={ref} {...inputProps} />
    </label>
  )
}

@schabluk Ah I see. So the reasoning for useRadio using RadioAriaProps instead of AriaRadioProps is because it contains a couple extra hook specific options that shouldn't show up in the Radio props, namely isRequired and isReadOnly. These two props are set on a RadioGroup so we can properly set required/readonly on all radios within the group. Applying isRequired or isReadOnly on an individual Radio therefore doesn't do anything and thus we don't include it in the AriaRadioProps. IMO the same should apply to your RadioButton example above, I don't think you would want isRequired and isReadOnly in the prop definition of your RadioButton since those should be controlled by the RadioGroup instead.


Move unit tests to separate "tests" folder

I think it makes more sense to keep the tests separate from the source code.
I created a new "tests" folder in the root of the repository, mirroring the folder structure of the fontTools package. I moved there all the unittest modules, each in its respective subfolder.
I changed all relative imports in the test scripts to absolute imports, since they are no longer part of the package.
I modified the run-tests.sh shell script so that it performs all the doctests first, which are still located in the ./Lib folder, and then all the unittests in the ./tests folder.
The shell script extends the PYTHONPATH automatically. However, if one wishes to run individual test scripts, then the fontTools package must be importable -- e.g. by using setuptools "develop" or pip "editable" mode.
Please let me know what you think,
Thanks.
Cosimo

So originally I didn't have any objection with tests being in-tree, because they don't have any overhead on the library itself, and test files that are close to code they test are much more likely to be updated over time.  So, why do you think we should move?

I see what you mean. But then also the test data used by the tests should be located somewhere in the package, right?
See also my comment in the woff2 thread: https://github.com/behdad/fonttools/pull/270#issuecomment-107532229

Actually, if we don't want the *_test.py and the respective test fonts to be installed in the Python site-packages we could always not include them in the setup.py.
To make sure the test data is reachable from the unit test's location, the two have to go together. Either we install them both or none.
Anyway, if you think it's not a good idea, I'll close the PR and try another strategy.

OK, let's keep the unittests in the same folder as the modules they test.
I will create a "test_data" folder inside Lib/fontTools/ttLib and place two test fonts in TTX format, one TT-flavoured, the other CFF-flavoured, which I'll use for testing the woff2 module.
One last thing and then I stop: what about putting all the *_test.py inside a "tests" subfolder, one for each sub-package? E.g. fontTools/ttLib/tests, fontTools/misc/tests, etc. The relative import would still work, by just adding another dot (e.g. from ..woff2 import *).


Divider guidance

What component is this related to?
Divider
Why do we need it?
Additional functionality was recently added to ic-divider, as a result ic-divider needs its own page with guidance and code examples.
Related issue
https://github.com/mi6/ic-ui-kit/issues/1331

Closing as it's a duplicate of #849


invocation code doesn't work.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a30fb645-c853-a93a-4137-1e2bf7398a11
Version Independent ID: 75fb99ac-72e8-7bdc-ff1b-85e7ed930d50
Content: Excel custom functions tutorial - Office Add-ins
Content Source: docs/tutorials/excel-tutorial-create-custom-functions.md
Product: excel
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

@zhangxj19 Thanks for letting us know about this. Can you share any additional details about what behavior you're seeing? Also, can you let us know where you're trying this (browser, Windows)?
@alison-mk Can you take a look?
Thanks.

Hi @zhangxj19, thanks for submitting an issue. I've tested this custom functions tutorial and added a fix for a bug in the Create a streaming asynchronous custom function section. It's in PR #2796 now. Once that PR is merged, this issue will automatically close. Let us know if you have any additional questions or concerns.
Cheers,
Alison


Problem with unexpected bool loading with unquoted yes/no

Just started to try and do some simple validation with pykwalify but am running into unexpected problems with unquoted yes/no being loaded as booleans.
I installed with pip install 'pykwalify[ruamel]' as I wanted the 1.2 yaml spec where yes and no would not be loaded as True/False.  It does looks from my output that I am using ruamel to load the yaml files...I've tried explicitly setting the YAML version to 1.2 in the files but doesn't seem to help.
I'm a but stumped!  So I though I'd ask here first before looking at ruamel in case it is some interaction that  I missing.
I have installed from epel and pip on Centos, the versions I have are:
Python 2.7.5
pykwalify 1.6.0
ruamel.yaml 0.11.15
The schema and data files I am using as well as output to the command line attached:
Command line is:
pykwalify -vvvvvvvvvv -s not_bool_schema.yaml -d not_bool_data.yaml > Output.txt 2>&1
not_bool_data.yaml.txt
not_bool_schema.yaml.txt
Output.txt
Appreciate any help you can offer!

@beauchar If you can make a example file that you load with ruamel.yaml outside of pykwalify then this kind of error do not belong here as pykwalify is not the problem but ruamel is. In that case i would suggest that you close this ticket and open up a new one over at ruamel.yaml bitbucket repo instead with your problem. If you however can show that pykwalify is the source of the problem and that it might interfere with the data loading then i will deal with it here.

@Grokzen Thanks for the response.
I've had another look and can't get ruamel.yaml examples to run stand-alone which may well be the problem I am seeing.
This looked a promising way to solve an issue for me.  Sadly I don't have the cycles to track things down right now.
Closing the issue for now.


sendMessage with allow_sending_without_reply=false replies to deleted message

The documentation states that passing True with the allow_sending_without_reply parameter in the sendMessage API method will send the message even if the specified replied-to message is not found. Based on this, I assume that if I pass False as a parameter, the message should not be sent. However, there seems to be an issue or ambiguity in this behavior.
Steps to reproduce the issue:

I send the message to the Supergroup (let's say its ID is 1)
I delete this message by myself using the UI
I call sendMessage method with allow_sending_without_reply=false and reply_to_message_id=1 (https://api.telegram.org/bot{{token}}/sendMessage?chat_id={{chatId}}&reply_to_message_id=1&allow_sending_without_reply=false&text=replied)

And the bot successfully replies to the message that is already deleted.
I highlighted that I deleted the message by myself because in all the other cases everything works as expected:

I delete the message posted by the user using deleteMessage method
I delete the message posted by the bot using deleteMessage method
I delete the message posted by the bot using UI

In all those cases sendMessage method with allow_sending_without_reply=false returns Bad Request: replied message not found.
This issue happens only at the first call, the second one already returns Bad Request: replied message not found.
The issue is also not the case in e.g. forwardMessage and copyMessage methods (I haven't checked all the methods that work with existing messages), they can detect that the replied-to message doesn't exist anymore right away.
I'm wondering if there's some delay before the message is considered deleted? Cause in my application it's crucial to not send the message back if the user deleted his message within the first few seconds.

Based on this, I assume that if I pass False as a parameter, the message should not be sent.

No, it means exactly as stated, that message is sent even the replied message can't be found. There is always a delay between an action and it is observable consequences, so there is no way to guarantee, that the message will not be sent without reply. After all the message, which was replied, can be deleted right after the replied message is sent.

No, it means exactly as stated, that message is sent even the replied message can't be found.

Yeah, but if allow_sending_without_reply = True means that the message is sent even if the replied message can't be found, then logically, setting it to False should imply the opposite behavior, shouldn't it? If no and in both cases we send the message even if the replied message can't be found, then I don't really understand the value of this parameter.
I'm not here to argue or blame someone. I'm simply curious and trying to understand this situation better, just in case.

There is always a delay between an action and it is observable consequences, so there is no way to guarantee, that the message will not be sent without reply.

I've just got 4 minutes between deleting the message to reply and sending a new message via the bot with allow_sending_without_reply = False. I don't understand why sendMessage method cannot verify if the message to reply is still there if such mechanism seems to exist. When I call forwardMessage or copyMessage methods with message_id = {{some deleted message}} I get Bad Request: replied message not found right away, so they know somehow that the message is not there anymore, why sendMessage doesn't?
An interesting discovery indeed: even after calling the forwardMessage and copyMessage methods for a deleted message and receiving Bad Request: replied message not found twice, the sendMessage method, when invoked with allow_sending_without_reply = False and reply_to_message_id = {{that deleted message}}, still sends the message. So it doesn't know about the state of the message even though it's been processed by two other methods which were aware of the message's absence.
I tried to figure this out myself, but I'm just not really into c++ and the code looks a bit too complicated for me 😥

Yeah, but if allow_sending_without_reply = True means that the message is sent even if the replied message can't be found, then logically, setting it to False should imply the opposite behavior, shouldn't it?

No, If A implies B, it doesn't mean that not A implies not B. Logic doesn't work this way.

An interesting discovery indeed: even after calling the forwardMessage and copyMessage methods for a deleted message and receiving Bad Request: replied message not found twice,

This is not possible. The methods can't return the error.

No, If A implies B, it doesn't mean that not A implies not B. Logic doesn't work this way.

Okay, I got this, the flag is here and guarantees only the behavior that is described (True = message is sent even if the replied message can't be found). Thanks.

This is not possible. The methods can't return the error.

But what do you mean by this? That those two methods can't return the errors in general or the specific ones that I described, cause yes, I made a mistake a put incorrect error text there.

forwardMessage returns

copyMessage returns

A bit of context: my wrong flag's understanding comes from the need to ignore the messages from the users that were deleted before the bot reacts to them (it's hosted on the Azure Portal, so there's like about 10-15 seconds to get awake), and I thought that this flag works in the other way as well (False = doesn't allow to send the message if the message to reply is gone), apparently is doesn't.
So I tried to find another way to verify the message existence, and as there's no getMessageById method or something, I found those two methods forwardMessage and copyMessage which could easily detect is the message is deleted or not.
Thus, I thought that there might be a bug in the sendMessage method as the mechanism for detecting the message existence does exist, but is not used there when allow_sending_without_reply = False. As now I'm inventing the wheel by trying to copy the message (to check if it exist) and only then reply to it.

Bot may not know that a message is deleted and may allow to reply it even the message has already been deleted and allow_sending_without_reply == false. But message identifiers passed as reply_to_message_id are resolved by the same function as message identifiers for forwardMessage and copyMessage. There is no way that the methods will return "message to ... not found", but then a message is sent without reply despite allow_sending_without_reply == false.

But message identifiers passed as reply_to_message_id are resolved by the same function as message identifiers for forwardMessage and copyMessage. There is no way that the methods will return "message to ... not found", but then a message is sent without reply despite allow_sending_without_reply == false.

I'm not a c++ dev, but I was digging a little in the source code with my limited knowledge, and I also remember that those methods call the same "verification" function for the message id. But the behavior still differs, there is the representation: https://youtu.be/Vh6Vcz5Fka4

The last two sentences were a reply to

An interesting discovery indeed: even after calling the forwardMessage and copyMessage methods for a deleted message and receiving Bad Request: replied message not found twice, the sendMessage method, when invoked with allow_sending_without_reply = False and reply_to_message_id = {{that deleted message}}, still sends the message. So it doesn't know about the state of the message even though it's been processed by two other methods which were aware of the message's absence.

This isn't possible and the video contains no disproof.

The last two sentences were a reply to

An interesting discovery indeed: even after calling the forwardMessage and copyMessage methods for a deleted message and receiving Bad Request: replied message not found twice, the sendMessage method, when invoked with allow_sending_without_reply = False and reply_to_message_id = {{that deleted message}}, still sends the message. So it doesn't know about the state of the message even though it's been processed by two other methods which were aware of the message's absence.

I'm sorry, I didn't realize you were talking about these particular sentences. There I recreated the described steps from those sentences: https://youtu.be/POXKgDGcdW8

Yes, this can happen when copyMessage/forwardMessage return "MESSAGE_ID_INVALID", but not "message to copy not found"/"message to forward not found",

Yes, this can happen when copyMessage/forwardMessage return "MESSAGE_ID_INVALID", but not "message to copy not found"/"message to forward not found",

I believe the error messages were different two months ago when I created this issue, but, unfortunately, there's no way to prove it now with video, I have only the screenshots left https://github.com/tdlib/telegram-bot-api/issues/469#issuecomment-1710811848.
But still, even if the error message is different, why sendMessage method doesn't return the same "MESSAGE_ID_INVALID" if those three methods use the same verification function? Or if the "MESSAGE_ID_INVALID" error message is returned by different function, some additional verification, also why isn't it used in sendMessage method?

"MESSAGE_ID_INVALID" is a server-side verification.


Web - App gets stuck in edit mode and displays 'pre' html block around text while editing and deleting code block in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Turn off your internet connection or trigger force offline
Send code block with any text in report
Edit the code block
Remove all the text, click enter to trigger delete popup and click enter again to trigger delete button (Note that it is important to use enter to trigger delete button)
Observe that app is now stuck in edit mode and we can't write anything in it or dismiss it
Revisit the report to see that now, app displays 'pre' html tag around the text in place of backticks

Expected Result:
App should strikethrough the message when we try to delete message in offline mode
Actual Result:
App is stuck in edit mode with no text and no way to close or add new text and it adds 'pre' html block in place of backticks in message on revisit if we send any code block, edit it, remove the content, press enter to trigger delete popup and press enter again to delete in offline mode
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/d9181598-9c40-4452-b417-8658b650e1e3
https://github.com/Expensify/App/assets/93399543/d5802f79-f596-4f83-b953-930be818010a
Expensify/Expensify Issue URL:
Issue reported by:  @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686933486555979
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - App gets stuck in edit mode and displays 'pre' html block around text while editing and deleting code block in offline mode
What is the root cause of that problem?
There are three main events in confirm modal, onConfirm, onCancel, onModalHide.
https://github.com/Expensify/App/blob/0adbf8397252f1b2e2e066fc51cb92462d8b23ac/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L325-L330
When confirm button is pressed onConfirm then onModalHide events happen. onModalHide event's callback change based on which event is called before it.
Basically when enter is pressed to submit empty edit message when delete confirm modal opens the window focuses in backdrop of modal. And when enter is pressed to confirm delete, first it triggers delete button which is listening to keyboard, and also it triggers click action on backdrop since focus was here. When clicking on backdrop it triggers onCancel event.
https://github.com/Expensify/App/blob/9ba7cd33671f61c55e46bece2f358b4db9390642/src/components/Modal/BaseModal.js#L103-L108
And this happens:
onConfirm -> onCancel -> onModalHide , the problem is that onCancel is being called in between of these two events and changes callback of onModalHide this both onConfirm and onCancel actions happen and edit input remains open.
What changes do you think we should make in order to solve the problem?
We should prevent onClose event from getting triggered when modal is already closing by adding condition here
https://github.com/Expensify/App/blob/b8aeec0bcf2cac06d51129f287f932ba0421ed4e/src/components/ConfirmModal.js#L65
            onClose={props.isVisible ? props.onCancel : () => {}}

Or we can add this condition for every place where onClose is called like here:
https://github.com/Expensify/App/blob/9ba7cd33671f61c55e46bece2f358b4db9390642/src/components/Modal/BaseModal.js#L103-L108
What alternative solutions did you explore? (Optional)

I'm not able to reproduce the bug. The message is struck through as expected.


website: add file size on golang.org/dl/

It would be nice if http://golang.org/dl/ shows the size of downloadable files also. (third world country reasons)

This can be closed, https://golang.org/dl/ has had the file sizes starting with Go 1.4.3.


Editorial: Use internal spec value for param

Using an ECMAScript string value to represent internal state may cause
readers to incorrectly assume that the state is directly observable from
ECMAScript code. Replace with a internal specification value in
accordance with the latest practice in ECMA262 [1].
Modify the values so that they will be distinctive in the context of the
specification in order to facilitate tool-assisted search (e.g. via the
grep command-line utility or via "Ctrl+F" in a web browser).
[1] https://github.com/tc39/ecma262/pull/2566

Codecov Report

Merging #52 (34042ea) into master (f5404e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   99.37%   99.37%
=======================================
  Files           1        1
  Lines         160      160
  Branches       50       50
=======================================
  Hits          159      159
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5404e8...34042ea. Read the comment docs.