INCORRECT LIGHTING IN COMBINATION WITH SHADOWS

The objects are too dark
The illuminated faces are displayed in color less vivid than those against the light
Possibly the normalization of normal used to calculate the inclination of light are being made in the wrong place (see examples of DX11)

Done! 6aefca2ac15c8f279ca1ddf69c4fe0000a48382b


macvlan and vMX

I'm not sure if I'm doing something wrong or that it's a bug :)
The idea is that the fxp0 is connected to a management vlan. On the physical host I've got eth1 connected untagged to a switch in the right vlan. I've created a macvlan with eth1 as a parent.
This works for an alpine linux container. I can ping an outside host and vice versa.   (note, I've attached this container later, so not via docker-compose)
It doesn't work with my vMX container.
When tcpdumping on the physical host, I see ping requests coming from the vMX towards the real world and see ping replies coming in on eth1.
On the vMX however, I don't see the replies. The only thing I see on the vMX are arp packets and broadcast packets, but no unicast.
On the alpine linux container I do see the unicast ofcourse.
Now, I'm quite new to docker, so it might be that I'm misinterpreting something, but this should normally work, right?
I have been able to connect two vMX's together with macvlan to do some L2 protocols over the link (lacp and lldp), but why doesn't it work when I connect it to a physical interface?
$ docker inspect vmx_01-mgmt
[
    {
        "Name": "vmx_01-mgmt",
        "Id": "4b61327756c5c977b04e153569c560905f6931071e4f59cd158ee36ef0c8cd35",
        "Created": "2021-02-23T16:22:34.982498718Z",
        "Scope": "local",
        "Driver": "macvlan",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": null,
            "Config": [
                {
                    "Subnet": "<IP_ADDRESS>/24"
                }
            ]
        },
        "Internal": false,
        "Attachable": true,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
            "4b2a273f222ec02f32dce5bad2e44ec66710f9b3b0a849068ea647cbf016c4e8": {
                "Name": "infallible_elion",
                "EndpointID": "33cc2792acb7190251b1a7d5b7d24551c1e193698ae3a5374afabfd763cd87db",
                "MacAddress": "02:42:c0:a8:2d:0b",
                "IPv4Address": "<IP_ADDRESS>/24",
                "IPv6Address": ""
            },
            "534f5b16aa43a7c17f896c5bb6dc3a28744eadd1f292c85d698211fb8c2ff713": {
                "Name": "vmx_aqplm1-rt001i_1",
                "EndpointID": "2dcd05c6532870acd7deedcd869214b0eed186cbafb7fbc0a4d46ec3e82dd682",
                "MacAddress": "02:42:c0:a8:2d:0a",
                "IPv4Address": "<IP_ADDRESS>/24",
                "IPv6Address": ""
            }
        },
        "Options": {
            "parent": "eth1"
        },
        "Labels": {
            "com.docker.compose.network": "01-mgmt",
            "com.docker.compose.project": "vmx"
        }
    }
]

$ cat docker-compose.yml
version: "3"

services:

  aqplm1-rt001i:
    image: juniper/openjnpr-container-vmx:bionic
    privileged: true
    tty: true
    stdin_open: true
    environment:
      - ID=aqplm1-rt001i
      - LICENSE=license-eval.txt
      - IMAGE=junos-vmx-x86-64-20.4R1.12.qcow2
      - PUBLICKEY=id_rsa.pub
#      - CONFIG=aqplm1-rt001i.conf
    volumes:
      - $PWD:/u:ro
      - /var/run/docker.sock:/var/run/docker.sock
    networks:
      01-mgmt:
        ipv4_address: <IP_ADDRESS>
      02-bla:

networks:
  01-mgmt:
    driver: macvlan
    driver_opts:
       parent: eth1
    ipam:
       config:
         - subnet: <IP_ADDRESS>/24
  02-bla:

Unfortunately you can't use macvlan for the management port (fxp0) that gets mapped to eth0. The root cause is this line in the launch.sh script of the container: https://github.com/Juniper/OpenJNPR-Container-vMX/blob/21a4ce1e121151b2875a7a7e4d94525f0dcf1fd3/src/launch.sh#L71
Basically the script moves the mac address of eth0 to fxp0 of the VCP VM, then bridges it back to eth0. That works well with veth endpoints (what you get when using Docker mgmt networks), but won't work for macvlan. That's why you only see BUM traffic, but no unicast.
Note, you can use macvlan just fine for revenue ports of the vMX (ge-0/0/x).
Hope this helps.

Check, that makes sense.  Patched it now up to ge-0/0/0 and it works as expected.
Thank you.


fix(gauge): fix z2 is negative when maxVal is negative

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

When max of a gauge is negative, the z2 calculated is also negative. Thus the axisLine is on top of the progress bar. This PR fixes how z2 is calculated to ensure it is always non-negative.
Fixed issues

fix #20097
Details
Before: What was the problem?

The progress bar is beneath the axisLine.

After: How does it behave after the fixing?

Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Misc
ZRender Changes

[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[ ] Please squash the commits into a single one when merging.

Other information

Online test case

A minor tip: please don't use force push next time. This will lose the commit history and our discussion context. We will use "squash and merge" if there are too many unnecessary commits.

Thanks very much for your advice!


Social media: replace Twitter bird icon with X icon

We need to update the icons file, as well as the social media component.

Thanks @beatrizmartinmartins Could you please also replace the icon in all components and templates where it's used? Off the top of my head, I think it's used in the hero card, footer and social media. But there can be more.

It was automatically changed when we updated the library @inesdgomes

@beatrizmartinmartins Still showing in the hero card and hero header

True, I didn't realized that had the social media. Done!

@beatrizmartinmartins Thanks! For some reason the bird is still showing in the templates https://www.figma.com/design/TnVsWy6VobbHzZdbHdx3Rb/ILO-Page-Templates?node-id=3702-31735&t=PcE9icy7oX60G7G9-0

@justintemps This can move to development, please.


position mat-menu in right side of the trigger

Please describe the feature you would like to request.
I would like to have option to open mat-menu in right side of the trigger.
It should look like below

while as per current design it is looking like as below

What is the use-case or motivation for this proposal?
I want to create overlay which should not overlap other menuitems in sidemenu and should render in right side of the trigger.
Is there anything else we should know?
Here is sample stackblitz
https://stackblitz.com/edit/angular-wurasp
I also tried with custom overlay but in that also there are only three options
for Xposition start, center and end
for Yposition top, center, bottom
I tried with xPosition end and Yposition center but not able to get what I want.

Any update on this ?

In order for this to work, you have to change the way the setPosition method of the MatMenuTrigger works. Something like this:
  private setPosition(positionStrategy: FlexibleConnectedPositionStrategy) {
    let [originX, originFallbackX]: HorizontalConnectionPos[] = this.menu.xPosition === 'left' ? ['start', 'end'] : ['end', 'start'];
    let [originY, originFallbackY]: VerticalConnectionPos[] = this.menu.yPosition === 'top' ? ['top', 'bottom'] : ['bottom', 'top'];

    let [overlayX, overlayFallbackX]: HorizontalConnectionPos[] = ['start', 'end'];
    let [overlayY, overlayFallbackY]: VerticalConnectionPos[] = this.menu.yPosition === 'top' ? ['top', 'bottom'] : ['bottom', 'top'];

    let offsetY = 0;

    if (this.triggersSubmenu()) {
      // When the menu is a sub-menu, it should always align itself
      // to the edges of the trigger, instead of overlapping it.
      overlayFallbackX = originX = 'end';
      originFallbackX = overlayX = 'start';
      originFallbackY = overlayY = overlayFallbackY = originY = 'top';
      offsetY = -MENU_PANEL_TOP_PADDING;
    } else if (!this.menu.overlapTrigger && originY === 'bottom') {
      overlayY = 'top';
      originFallbackY = 'bottom';
    }

    positionStrategy.withPositions([
      { originX, originY, overlayX, overlayY, offsetY },
      { originX: originFallbackX, originY, overlayX: overlayFallbackX, overlayY, offsetY },
      {
        originX,
        originY: originFallbackY,
        overlayX,
        overlayY: overlayFallbackY,
        offsetY: -offsetY
      },
      {
        originX: originFallbackX,
        originY: originFallbackY,
        overlayX: overlayFallbackX,
        overlayY: overlayFallbackY,
        offsetY: -offsetY
      }
    ]);
  }

Also:
export type MenuPositionX = 'left' | 'right';
export type MenuPositionY = 'top' | 'bottom';

This way, the menu by default will still open the same as before, but if you use xPosition="right" yPosition="top", it will open to the right of the trigger.

Thanks @jpzwarte. I saw this method but was not able to override as its private method. Did you find any way to override it?

The more i think about it the more i think the API needs to be different something like: [position]="['right', 'top']" where the first position is the primary position and the second the secondary, so:

right, top: right side of the trigger, align to top of trigger
top, right: top side of the trigger, align to right of trigger
bottom, left: bottom side of the trigger align to left of trigger
etc.

@lokeshdaiya i'm working on a custom menu component (not OSS). So using material as inspiration.

I've written the code that implements the behavior in my previous comment: https://gist.github.com/jpzwarte/5b6f848a8cbc1488779181894382f306
Feel free to use the code however you see fit (cc @crisbeto)

@jpzwarte Have some stackblitz example? I tried to use your API but something got wrong.

Any update on this feature? I see this lacking in angular mat-menu which is very common usecase and need.

This would be a nice feature

Until the material team up the priority for this feature and actually implements it, here is an example that emulates the behavior using the existing API...
https://stackblitz.com/edit/material-menu-right-position
You may want to add some css and codes to fine tune its appearance and behavior. For example, automatically expand the nested submenu when parent menu is clicked, etc.
Hope this helps.

https://stackblitz.com/edit/material-menu-right-position

@okeydoky Your url appears to be incorrect, it points to the repo issues page.

@rafaelss95  Thanks for noticing. I updated the url.

You can use matMenuTrigger and matMenuTriggerFor to achieve this.
https://stackblitz.com/edit/angular-material-menu-position-aside

@nzbin
Come up with the same idea, but when the element is at the bottom of the page, the menu will open above the trigger

Tracking this via #22493 now


Bump sts version

https://github.com/microsoft/sqltoolsservice/releases/tag/v3.0.0-release.89
Adds support for SQL Auth for Migration Assessments

Pull Request Test Coverage Report for Build 698510660

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.216%

Totals

Change from base Build 698125732:
0.0%

Covered Lines:
25474

Relevant Lines:
53777

💛  - Coveralls


[Misc]: vLLM v0.6.0  CUDA 12 missing wheel file

Anything you want to discuss about vllm.
I'd like to understand why the most recent release is omitting the CUDA 12 wheel package built?
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

I can't find any direct reasons as to why its not included in the 0.6.0 release. From https://github.com/vllm-project/vllm/issues/385 and https://github.com/vllm-project/vllm/issues/949, vLLM already support CUDA 12 and from the docs https://docs.vllm.ai/en/latest/getting_started/installation.html, by default vLLM already uses CUDA 12 binaries.

the wheels in pypi https://pypi.org/project/vllm/ should be cuda 12
cc @simon-mo  if the release pipeline changed, the release page https://github.com/vllm-project/vllm/releases/tag/v0.6.0 indeed only has cuda 11 wheels.


[stable/newrelic-infrastructure] fix unprivileged cache directory

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
This PR fixes an issue with the unprivileged New Relic Kubernetes Integration, where the cache directory has not been properly set.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @douglascamata

/lgtm

/ok-to-test


Latest code is missing files?

I did a git pull and noticed a bunch of changes -- one of which is the autoProcess.ini.sample file seems to be missing.  Did something change?
[UPDATE] Ok, it looks like there was a pretty major upgrade.  Any chance you can share steps to upgrade (like changes to the ini file and dependencies)?

I am seeing this in the output of SABNZBD now -- does seem correct?
2020-03-09 21:28:03 - SABPostProcess - INFO - Passing None directory to Sonarr.
2020-03-09 21:28:03 - autoprocess.sonarr - INFO - Sonarr notifier started.
2020-03-09 21:28:03 - autoprocess.sonarr - INFO - Requesting Sonarr to scan directory 'None'.
2020-03-09 21:28:03 - autoprocess.sonarr - INFO - Sonarr response: queued.

I actually just reverted a lot of the changes as they were causing more problems then they were fixing
I did move the default location of autoProcess.ini into a /config folder (though it should pick up the old location still)
Reason for the move was for docker config mounting

Depending on when you last updated it will also migrate your configuration file to a new format too
Not sure why it would be sending 'None' as the scan directory though, I don't believe that was changed at all. Is your output-directory set to 'None'?

I like the cleanup and love the support for docker :) Just trying to get it working again.
For the log above -- I just moved my autoProcess.ini file into the config folder and got that from the next file that was processed. If I revert back to an older commit everything works (and has been working for well over a year)

Can you post your autoProcess.ini file? and if it did the migration can you post the .backup file that was created as well?

Sure, here are both of them
autoProcess.ini.backup.txt
autoProcess.ini.txt

Hm that all looks ok, any chance you could post some debug logs? Also what issue are you having exactly? Hard to tell from the logs what's going wrong. It looks like SAB is passing 'None' as the directory which I don't have a good way to explain why it would do that
How does that log look on the old commit that does work for you?
Does manual.py process ok?

Here is an example of one that works with the commit id of e25c4314aa5471fc06477172a7bd03a007ef89c9
Its a fair amount different
The two cahnges are

The working one used the commit id above
The latest I had to change the #!/usr/bin/env python to #!/usr/bin/env python3 as sabnzbd is still using python 2.7 and it looks like your script needs python 3

2020-02-15 20:12:47 - SABPostProcess - INFO - SAB post processing started.
2020-02-15 20:12:47 - readSettings - INFO - /usr/local/bin/python
2020-02-15 20:12:47 - SABPostProcess - INFO - Performing conversion
2020-02-15 20:12:47 - SABPostProcess - INFO - Processing file /mnt/Downloads/Complete/tv/MythBusters S05E06 More Myths Reopened READNFO 720p HDTV x264-MiNDTHEGAP.1/mythbusters.s05e06.720p.hdtv.x264-mtg.mkv.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Input Data
2020-02-15 20:12:47 - mkvtomp4 - INFO - {
"audio": [
{
"index": 1,
"language": "eng",
"default": true,
"channels": 6,
"codec": "ac3",
"type": "audio"
}
],
"subtitle": [],
"format-fullname": "Matroska / WebM",
"video": {
"pix_fmt": "yuv420p",
"index": 0,
"codec": "h264",
"type": "video",
"profile": "High"
},
"format": "matroska,webm"
}
2020-02-15 20:12:47 - mkvtomp4 - INFO - Reading video stream.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Video codec detected: h264.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Pix Fmt: yuv420p.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Profile: High.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Reading audio streams.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Audio detected for stream #1 - ac3 eng 6 channel.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Creating copy audio stream 0 from source stream 1.
2020-02-15 20:12:47 - mkvtomp4 - INFO - 1 total audio streams with 1 set to default disposition. 1 defaults in your preferred language (None), 0 in other languages.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Reading subtitle streams.
2020-02-15 20:12:47 - mkvtomp4 - ERROR - Unable to add language for download with subliminal.
Traceback (most recent call last):
File "/mnt/Downloads/Scripts/sickbeard_mp4_automator/mkvtomp4.py", line 878, in downloadSubtitles
languages.add(Language(self.sdl))
File "/usr/local/lib/python2.7/site-packages/babelfish/language.py", line 82, in __init__
raise ValueError('%r is not a valid language' % language)
ValueError: 'en' is not a valid language
2020-02-15 20:12:47 - mkvtomp4 - ERROR - No valid subtitle download languages detected, subtitles will not be downloaded.
2020-02-15 20:12:47 - mkvtomp4 - INFO - Output Data
2020-02-15 20:12:47 - mkvtomp4 - INFO - {
"subtitle": {},
"audio": {
"0": {
"channels": 6,
"map": 1,
"codec": "copy",
"disposition": "+default",
"language": "eng",
"debug": "base",
"bitrate": 384,
"filter": null
}
},
"video": {
"profile": null,
"map": 0,
"field_order": "progressive",
"codec": "copy",
"level": null,
"debug": "base",
"bitrate": 2359.0950999999995,
"pix_fmt": null
},
"format": "mp4"
}
2020-02-15 20:12:47 - mkvtomp4 - INFO - Preopts
2020-02-15 20:12:47 - mkvtomp4 - INFO - []
2020-02-15 20:12:47 - mkvtomp4 - INFO - Postopts
2020-02-15 20:12:47 - mkvtomp4 - INFO - [
"-threads",
"0"
]
2020-02-15 20:12:47 - mkvtomp4 - INFO - Subtitle Extracts
2020-02-15 20:12:47 - mkvtomp4 - INFO - []
2020-02-15 20:12:47 - mkvtomp4 - INFO - Starting conversion.
2020-02-15 20:12:50 - mkvtomp4 - INFO - /mnt/Downloads/Complete/tv/MythBusters S05E06 More Myths Reopened READNFO 720p HDTV x264-MiNDTHEGAP.1/mythbusters.s05e06.720p.hdtv.x264-mtg.m4v created.
2020-02-15 20:12:50 - SABPostProcess - INFO - Passing /mnt/Downloads/Complete/tv/MythBusters S05E06 More Myths Reopened READNFO 720p HDTV x264-MiNDTHEGAP.1 directory to Sonarr.
2020-02-15 20:12:50 - autoprocess.sonarr - INFO - Sonarr notifier started.
2020-02-15 20:12:50 - autoprocess.sonarr - INFO - Requesting Sonarr to scan directory '/mnt/Downloads/Complete/tv/MythBusters S05E06 More Myths Reopened READNFO 720p HDTV x264-MiNDTHEGAP.1'.
2020-02-15 20:12:50 - autoprocess.sonarr - INFO - Sonarr response: queued.

I found a small bug that was breaking python 2 that has since been fixed if you wanted to update and try again

Additionally, it looks like they do have python3 version of SAB out there now
The correct solution if you're still on python2 would be to make a .sh file and include something like this
#!/bin/bash
/path/to/python3 /path/to/script/SABPostProcess.py "$@"

Thats pretty much the exact script I ended up writing :)
Question - for debug logs, are you looking for debug logs from sabnzbd or from your script?  If it's your script, is there something I need to do to enable debug logging?

Hm so apparently SAB just doesn't like exit codes, even though its the success exit code. Just pushed an update to take that out. I will say that it appears otherwise that should have all worked perfectly. Its passing the correct download directory (assuming that /mnt/Downloads/Complete/tv/Magnum P I S01E19 Blood in the Water 1080p AMZN WEB-DL DDP5 1 H 264-NTb.1 is the corrrect directory and the request was queued. I suppose its possible that last exception was creating some trouble but that was really a fake exception just due to the exit code
Pushed an update to remove the exit code unless there's an error
88e02866db181b643df323aca8a85f7b8ac0da4c

Bingo, that fixed the issue with sabnzbd -- next question is, is there anything that changed in how plex is notified? In the latest version new shows are not showing up until after a full library scan.

The biggest change with plex was that previously all the media manager scripts had the same code which was consolidated down into a single method handled by the mediaprocessor
In doing so I tweaked the function slightly but nothing major
Are you getting any exceptions in the logs related to plex refresh?
That would happen from postSonarr.py you can check in /var/log/sickbeard_mp4_automator/index.log and see if there's any errors in there related to plex

Plex refresh working on my end
Added some additional debugging and cleaned up a logging bug to help if you wanna update before you do further testing to the Plex side of things
I did have to refresh my token in autoProcess.ini

Ok, let me grab the latest and give it a try.  Thanks!

Gonna close this for now since I think I got all these resolved, reopen if any issues

Agreed -- I think everything is looking ok in regards to this issue.  Thanks!


periphmraa: Fix compilation errors in PWM

config PERIPHERALMAN fails to compile with PWM. Fix it.
Signed-off-by: Sanrio Alvares<EMAIL_ADDRESS>

Merged to periphmraa branch.


feat: prototype opportunities slice

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3136   👈

This comment was auto-generated by Graphite.

Opening for early review


Wrapper for http.Get that supports caching

Some of our calls to noaa should be cached. For example, the /points/<lat,lng> endpoint should be cached. Would be nice if we could do something like httpWrapper.Get(url, 1000) which would cache the response for 1000 seconds.
We could also use this for the hourly forecast fetcher, realistically the forecast wont be changing all that often. Retrieval for hourly forecast takes a 1-2 seconds from noaa but we probably only need to get fresh data every ~2 hours.
There almost certainly is an existing package that does this and caches in memory which is probably good enough.

Excellent idea!
Here are a few design suggestions that could achieve this in a very simple manner:

The cache can be a map attached to the server, or some other struct.
a. lat,lng is the key.
b. note that maps are not thread safe, so we need to ensure we add proper mutex mechanics.
The forecast fetcher starts with the server, in a separate go routine.
a. It continues running until the server receives a shutdown signal.
When a request comes in, we check the cache for a key.

if it doesn't exist, call the noaa API
if it does, ensure the timestamp on the caches value is new enough (eg 1000 seconds)

if new enough, return cached value
if too old, call noaa API

All noaa request made (due to cache miss or otherwise) always refresh the cache for the lat,lng (key).

Along with simplicity, a primary benefit is our API remains as is since the complexity around cache logic is buried into the implementation details retrieval. This is great for clients that don't need to understand where the data is coming from. We also no longer need to set TTLs with our http calls.
Here's a quick visual to make this idea a bit concrete (missing some nuance in the bullets above):

Let me know your thoughts!


Training window documentation is out of date

Needs to be updated in dfs and calculate_feature_matrix

Fixed by #166


Could not use custom model in object detection

Recently I would like to replace model ssdlite_object_detection.tflite by my custom model, which is trained with ssd_mobilenetv2_coco(float model). To get tflite file, I use the script export_ssdlite_graph.py and set the flag add_postprocessing_op=False as mentioned in the tutorial, then I used TFliteConverter to quantize my model (weight only) to obtain my graph tflite.
For the part of mobile, I modified the model_path, label_map_path,num class,num_boxes(for my case is 1917 instead of 2034) in the object_detection_android_gpu.pbtxt. Besides, I replace the models and file txt in objectdetctiongpu/BUILD file. Then I build and install apk, no errors during the process. But when I run inference with my mobile, no bounding boxes were detected.. Did I miss something ? Thanks for your help!

Routing to @fanzhanggoogle @chuoling

One issue is that to use quantized model, you should add use_quantized_tensors: true option to TfLiteConverterCalculator. Then the rest of the graph should take care of the quantized model naturally. Let me know if it works for you.

Please pull the latest commits, quantized model might not be supported yet in the previous release.

Closing the issue. Please re-open if you still issues.


Only create inner chain provider once in profile creds provider

The SsoCredentialsProvider maintains an in-memory expiring cache of SSO tokens, and this cache is maintained within its instance. The ProfileFileCredentialsProvider, which uses SsoCredentialsProvider as a base/inner provider, is currently reconstructing the inner provider every time it loads credentials, which discards the SSO token cache entirely.
This PR refactors the ProfileFileCredentialsProvider to cache the inner provider so that it is only initialized once on first load of credentials. This is done via a new ErrorTakingOnceCell abstraction since the same init-caching mechanism will be needed for the ProfileFileTokenProvider when it is implemented.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Maybe we could construct a fake environment, mutate the file system, then requery credentials and validate that they change (or don't?)

Or, perhaps easier, we can register a named source in NamedProviderFactory that verifies the source is created exactly once.

Actually looks like the way I proposed won't work because the factory holds arcs of already instantiated ProvideCredentials implementations, and SSO is separate from it entirely.


Bugfix

Try to fix the bdd test bugs

Codecov Report

Merging #110 (ebbf74a) into main (396dce1) will decrease coverage by 0.71%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   96.91%   96.19%   -0.72%
==========================================
  Files           7        8       +1
  Lines         421      526     +105
==========================================
+ Hits          408      506      +98
- Misses         13       20       +7

Impacted Files
Coverage Δ

service/common/error_handlers.py
70.00% <50.00%> (-22.11%)
:arrow_down:

service/routes.py
97.39% <97.66%> (+2.15%)
:arrow_up:

service/__init__.py
90.62% <100.00%> (ø)

service/models.py
97.72% <100.00%> (-1.09%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Composition vs inheritance

References #25.
I believe the translation is fair. I just have some questions:

I treated props as a feminine gender noun. I don't know if this is right, but that made sense to me.
Also, I took the liberty to translate some component names and create new CodePens to show them. Components like <Dialog /> were left untranslated but <WelcomeDialog />, for example, was translated to <DialogBenvenuti />. I'm open to suggestions, though, if you think this is not right.

@deblasis No worries! I know that my Italian has a lot to improve, and if you think that it's better for a native speaker to do it rather than me, that's no problem 😃.
While I wait for your reviews, I'll start to fix the other points that you mentioned.
Thank you!

Hi @GCrispino, so... I had a look at your translation, started reviewing it but I gave up after noticing that I was rewriting it 😞, please have a look at the first suggestions to have an idea. I really appreciate your attempt but I would abandon this PR and make the page available for other translators, if @LucaBlackDragon agrees with me of course. Sorry for not getting back to you earlier, I hope you didn't spend more time on this meanwhile.
Ciao! 😄

@deblasis no problem! Thank you so much for your feedback, and sorry to waste your time.

No worries @GCrispino, thanks anyways!

I'm sorry to reply so late, this is going to be a busy week for me. I'll try to focus on reviewing PRs... Anyway I agree with @deblasis, but thanks again for the effort @GCrispino!


Repo sync for protected CLA branch

The pull request is created from main637877990562651957 to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Cannot Install Inside a Docker

Description
The newrelic-cli is unable to be installed effectively inside a docker due to snapcraft and requiring sudo (using the script install) which dockers typically don't have because building the docker is already running at root privileges.
Go Version
Provide the output of go version here please
Current behavior
A clear and concise description of what you're currently experiencing.
Expected behavior
A clear and concise description of what you expected to happen.
Steps To Reproduce
Steps to reproduce the behavior:

Run this in any Dockerfile
RUN curl -Ls https://download.newrelic.com/install/newrelic-cli/scripts/install.sh | bash

Debug Output (if applicable)
If applicable, add associated log output to help explain the problem.
Additional Context
Add any other context about the problem here.
References or Related Issues
Are there any other related GitHub issues (open or closed) or Pull Requests that should be linked here?

hi @radiantone thank you for filing this.  Have you tried the docker image?


Release Google.Cloud.GkeBackup.V1 version 2.5.0

Changes in this release:
New features

Add IServiceCollection extension methods for client registration where an IServiceProvider is required. (commit 022fab2)

Created release for Google.Cloud.GkeBackup.V1-2.5.0


'user' and 'me' roles not added when use allowedRoles

Given I have the following set in nhost/config.yaml:
user:
    allowed_roles: user,me,company,freelancer
    default_allowed_roles: user,me,company,freelancer

When I then do a signUp I expect the user and me roles to be added the to user by default even if I did not add them to the allowedRoles option.
nhost.auth.signUp({
  email,
  password,
  options: {
    displayName: name,
    defaultRole: 'freelancer',
    allowedRoles: ['freelancer'],
  },
});

@st3phan thank you for pointing this out. We currently use default_allowed_roles only if allowedRoles is not specified, meaning allowedRoles effectively override default roles. What you are suggesting makes sense to me, we would need to also add the option to change default roles to the UI. /cc @elitan

default_allowed_roles works similar to a default value in a database. If no value is specified the default value is used.
In the example above you specified allowedRoles: ['freelancer'] and so you overrided the default value (default_allowed_roles).
Does it make sense? Is there any way we could make it more intuitive?

Does it make sense? Is there any way we could make it more intuitive?

Yes, I understand the default/override principle but shouldn't me and user be roles that a user always needs?
Would there be a use case for a user without the me and user roles?

Ah, I see. You're thinking of me and user roles as almost system roles that are always attached to a user.
Hmm, yea good question. I still favor the current behavior which I think is more flexible.


Fix some accessibility issues

This pull request improves the editor for the following users

keyboard only users
those with visual impairments, who use a screen reader for some, although not all of their editing

Although many of them are generally useful to people outside those groups also.
Features/fixes
Added aria landmarks to describe the main areas of the editor. With MacOS 'voice over' enabled pressing CTRL + ALT + U you'll see

Added missing title attributes to all icon only buttons. Both mouse users when hovering the button and screen readers will get descriptive text.

Inaccessible <Multibutton/> component has been changed internally to be a group of radio buttons, whereas before it was <button>s. This improves screen reader accessibility, because it is now announced as a group. Also keyboard users can access it using the arrow keys, as they would with normal radio buttons (up/down or left/right)

Replaced 1 'skip navigation link' with 3 more obvious 'skip links'

Layers list
Layer editor
Map view

Tab based keyboard interaction (versus using something like voice over) was really slow previously because you had to tab through a lot of links/buttons to get to what you wanted to interact with. With the added 'skip links' a user can navigate back to the URL bar (usually CTRL + L / CMD + L`) and restart navigation from the quick links.

Added the existing map specific shortcuts to the shortcuts menu (? menu). The shortcuts menu also compliments the previous keyboard improvements.

I've hidden 'layer list' actions from tab order, preferring to use the layer editor options. Having 3 buttons per menu item, increased the amount of tab navigation you needed and the 'layer editor' menu is a lot more efficient.

Also the 'tree view' approach for the 'layer list' as mentioned in #320 was a no-go, because as mentioned at https://dequeuniversity.com/library/aria/tree-view it's currently not supported by screen readers

WARNING: Screen Reader support for tree components is spotty at best.

I instead went with a 'menu button' aria markup approach instead, similar to the 'layer editor' more menu.
Summary
Hopefully the above improves the editing experience for everyone. I know personally using a mix of keyboard/mouse is my preferred method of using most applications.
I will be continuing to work on improving accessibility, I'll expand on further work to be done in other tickets.
If anyone reading this ticket has any accessibility requirements that are not met by the current editor, please reach out and let us know. We can't promise to fix everything, but we'll always try to help those who struggle.
Fixes #320

Demo link for anyone who wants to try this out:
https://2606-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html

I'm going to merge this now, if anybody has any comments please feel free to comment post merge or open a new ticket.


EKF: dont check gps_check_fail_status is velocity reset

This PR removes a bug that was introduced here
In a velocity reset we only used the GPS measurement if _gps_check_fail_status.value was equal to zero. The value of this flag is independent of EKF2_GPS_CHECK so checks can fail even if they are not configured to have any effect. E.g. on PX4 v1.10.1 the check will always fail if the vehicle is using two GPS modules since the gdop field is set to infinity. (On master gdop is replaced by tdop which is set correctly since https://github.com/PX4/Firmware/pull/13515/files)
My interpretation is that the GPS checks configured to run by EKF2_GPS_CHECK and defined by the corresponding threshold parameters are preflight checks and should have no influence other than that.

This was added then with the intent of stopping resets to bad GPS velocities after flying into GPS denied environments, where we still have other sources of aiding.

This was added then with the intent of stopping resets to bad GPS velocities after flying into GPS denied environments, where we still have other sources of aiding.

Yeah, but the EKF will still continuously fuse the GPS from the next sample so the gain is marginal if any. So I would propose to merge this and handle the case of GPS denied environments differently, probably more sophisticated logic is needed there.

Yeah, but the EKF will still continuously fuse the GPS from the next sample so the gain is marginal if any. So I would propose to merge this and handle the case of GPS denied environments differently, probably more sophisticated logic is needed there.

In my case the difference was not marginal. I was flying into a tunnel. While hovering in place, the EKF reset to the falsely non-zero GPS velocity, causing it to the fly into the wall.
For me this seems to be a more general discussion about what the GPS checks are. I understand that historically this was only thought as a preflight check, but IMHO this should also be used in-flight. If not, I suggest to stop performing the checks also after takeoff.
For now I would rather change it to && (_gps_check_fail_status.value==0 && "EKF_GPS_CHECK active" as an intermediate solution.

In my case the difference was not marginal. I was flying into a tunnel. While hovering in place, the EKF reset to the falsely non-zero GPS velocity, causing it to the fly into the wall.

Sorry to hear that. But wouldn't it still have flown into the wall since the gps data would have been fused into the EKF directly afterwards? Or was the data so bad that the innovation checks would have been failing.

For me this seems to be a more general discussion about what the GPS checks are. I understand that historically this was only thought as a preflight check, but IMHO this should also be used in-flight. If not, I suggest to stop performing the checks also after takeoff.

I agree, but that will require more work since we need to add different thresholds for when to pass preflight checks and when to allow data into the EKF. And also add configuration options to set what to check in preflight and what checks need to pass for the data to be fused.

But wouldn't it still have flown into the wall since the gps data would have been fused into the EKF directly afterwards? Or was the data so bad that the innovation checks would have been failing.

Not in my case, since I had a VIO sensor proving valid odometry information. After a reset the EKF would still have been vulnerable to bad GPS data. Probably it would have fused it for a short amount of time as the variance was increased during the reset. But while converging to the VIO solution it would not be affected that much by bad GPS data.
In comparison while reseting to the unrealistically high velocity, the delta velocity biases would also change and the filter would need much longer to converge towards the more valid VIO data, if it even does. More likely it will reject the VIO data.
To the best of my knowledge, I was testing this additional check on the replay log of the crash in the tunnel and it stopped it from diverging after the reset.
Would you be okay with the intermediate solution I have proposed?

Okey thanks for the explanation!

Would you be okay with the intermediate solution I have proposed?

Yes, you mean something like this?
if (_control_status.flags.gps && _time_last_imu - _last_gps_fail_us > (uint64_t)_min_gps_health_time_us) {

Yes. But without the subtraction of two unsigned integers. xD

hehe, okey I will update the PR and test it in replay

Thanks a lot. I am sorry that I caused troubles with that additional check.

Thanks a lot. I am sorry that I caused troubles with that additional check.

Oh no problem! It's cool to see more contributors to ECL, with more diversity in the projects used by ECL these things are inevitable to happen. Good that we have replay so we can catch it in simulations :)

v1.10.1 vs PR


Set up the development environment

As a developer,

I need to set up the development environment
So that I can start working on the customer accounts microservice.

Details and Assumptions

The project is hosted in an online lab environment.
The development environment needs to have Python, Flask, and the necessary database connectors installed.

Acceptance Criteria

Given I have access to the online lab environment,
When I follow the setup instructions,
Then I should be able to run the customer accounts microservice locally.

Acceptance Criteria:

The development environment is set up with all necessary dependencies installed.
The Flask-based REST API for creating an account is integrated into the development environment.
Unit tests are created to ensure the functionality of the service.


Allow deleting draft projects

Fixes #741.
I've allowed the "Delete Project" menu to show up for draft projects as well as real projects, and changed the SoftDeleteProject mutation to delete a draft project if there is no "real" project with that GUID. (Draft projects are hard-deleted, because there's no reason to soft-delete them: they were just project requests, and there is no Mercurial repo attached).
Currently the wording on the modal is exactly the same for deleting a draft project as for deleting a "real" project. I could change it to say "Delete Draft Project" if necessary, but I feel like it's probably good enough as-is.

@rmunn does the Draft project disappear when you delete it?
I'd expect that you need to invalidate the GQL cache.
So, in our gql-client.ts cachExchange something like this:
softDeleteProject: (result, args: SoftDeleteProjectMutationVariables, cache, _info) => {
  cache.invalidate({__typename: 'Project', id: args.input.projectId});
  cache.invalidate({__typename: 'DraftProject', id: args.input.projectId}); // +
},

I just went ahead and added the GQL cache invalidation, because there's a draft in prod we're looking forward to deleting 😆


Add accessibility features on website

Accessibility features on website (e.g. tabIndex, keyboard support)
User experience; P4

This was done with accessibe integration around a month ago - you can see on prod.

If you have questions about it ask @kterry1 in Slack.

Ok thanks !
On Sun, Oct 11, 2020 at 12:53 PM Josh Morel<EMAIL_ADDRESS>wrote:

Closed #1585
https://github.com/FightPandemics/FightPandemics/issues/1585.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FightPandemics/FightPandemics/issues/1585#event-3863872535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARG6ZUEXFLMG4BP5X7EZD7LSKHPJLANCNFSM4SEWZXRQ
.


Is the "latest" tag being published and updated?

The documentation for the Amazon SD service (https://aws.amazon.com/blogs/opensource/unified-service-discovery-ecs-kubernetes/ ) points to an image tagged as registry.opensource.zalan.do/teapot/external-dns:latest which is also used in plenty of our tutorials.
Are we nowadays updating the latest tag in the pipeline? It doesn't look like it's the case from https://github.com/kubernetes-incubator/external-dns/blob/master/delivery.yaml .
/cc @njuettner @linki

latest is a magic tag in our registry. It returns always the latest "real" tag. As of right now it's the same as tag v0.5.9-13-ge94a9be.

Understood, thanks for the clarification. What if we make this less magic and we document this? A couple of lines in the README would do and we will make sure not to confuse users.

/remove-lifecycle stale


Fix typo

s/Deimoms/Deimos/

📚 Documentation preview 📚: https://hapsira--6.org.readthedocs.build/en/6/

Thanks for showing up to the party & the PR!


Particle system component should have sensible defaults

If you add a particlesystem component to an entity with no options set, it should still display something sensible. Right now, you don't see anything, which makes it hard to get to the point where you start iterating options to get the effect you want. I suggest the same defaults that are used when creating a particle system component in the Editor.

Critical part is fixed here: https://github.com/playcanvas/engine/pull/417
Not sure about other parameters though.

I'm happy to have this closed for now then, since at least something is now visible.


Re-add Tcp{Stream,Listener}::take_socket_error

This was accidentally removed in #262
Closes #279

:+1:

Merged: 70952070c7a0c091167e2b96b40e6b1250b56840


[hotfix] [REST] Various rest-related hotfixes

This PR is based on #4700.
What is the purpose of the change
This PR contains a number of smaller changes that i made while working on FLINK-7072, which are however not really related to it, so I decided to front-load them instead.
Brief change log

modify the existing EmptyRequestBody class to be a singleton

add QoL variations of RestClient#sendRequest for empty requests/parameters

add PATCH http method wrapper

Fix the error message when a GET message could not mapped to the respective RequestBody. This now properly returns BAD_REQUEST instead of INTERNAL_SERVER_ERROR.

Add a special case to the RestClient for reading plain-text responses, which previously failed with cryptic json parsing exceptions.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

Changes look good to me. Thanks a lot for your contribution @zentol. Merging this PR.


When will the code be available?

Hi, I'm interested in your group's work published at ICLR-2022. When will the code be released?
Best wish！

Hi, thank you very much for your interest! We're planning to release the code early next week. We'll keep you posted.

We just made the code available. Thanks again for your interest!


Removed resize event from toolbar

Removed resize event from toolbar to avoid the control is automatically resized when parent is resized   (issue #563)

Hi, if we remove the resize handler, the codebase that uses toolbar without using place will cause bugs. I think we should add a new method to remove the resized event handler, that could prevent breaking existing codebase.

I consider the toolbar a control like any other. If apps (without place) needs to adjust controls size when the parent size change they should add the proper resize event. I don't think the lib should add events for specific cases.

Agree with you, it's a legacy problem.


Chocolatey Packaging

Add scripts to build chocolatey install packages. One package installs to the global modules location in c:\Windows the other installs to the installing user's Documents module location.
If this is accepted, I assumed that @lzybkr would want to upload and own the package on Chocolatey.org. If not, I can upload the packages if I notice a new release in Github.
I would also suggest that Githubs release functionality be used to store release binaries rather than checking in the built packages directly in the repo.

@lzybkr did you abandon the idea? Every now and then I found myself typing in cinst PSReadLine before I remember there is no package.

@vorou Try using PowerShellGet from the WMF 5.0 preview. You can download the experimental builds of OneGet for Windows 7.
Find-Module psreadline | Install-Module
It works pretty well. :smile:

I'm sure it works, but I'm also sure there are much more people who are already using chocolatey. And it seems weird to install a new package manager just to install ReadLine. I mean, it's OK to do it one time (if you only need to install it on a single box, you could go well w/ just downloading the file manually, after all) but it's a pain to repeat it on each box.
But since the issue isn't getting any attention, I guess I'm the only one with that problem.
@lzybkr are you still against the chocolatey? If not, and you just don't have the time/motivation, I could upload the package myself.

Out of laziness, I'd prefer publishing in just one place.  With the introduct of the PowerShell gallery, I was somewhat compelled to publish in more than one place to help bootstrap/test PowerShellGet.
When OneGet/PowerShellGet has support for PowerShell V3/V4, I will consider publishing on the PowerShell gallery exclusively - partly out of laziness, partly to have a single set of instructions for installation.
Because OneGet support both chocolately and the PowerShell gallery, I'd really prefer not publishing a chocolately package because some people will see two packages and wonder which one is the official one.


add a card display to all features that are presented in website

On clicking on those cards they will redirect to the functioning page

I would like to work on this issue,please assign it to me

@akshitagupta15june I can work on this issue can you descibe it little more.

Hey checkout the recent issues, this issue is completed by a contributor


fix js ruby php parser

Fixing issue: https://github.com/ncoop57/function_parser/issues/2#issue-796498722
Hey !
I just fixed the problem for the javascript ruby and php parser ! It was just a matter of version !
Let me know if you are going to accept the pull request !
Lucas.

Thanks so much Lucas!


Support Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy on dev server

Clear and concise description of the problem
Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy headers are necessary to support SharedArrayBuffer, as is explained in this article.
But so far, on Vite.js website and docs, there is no description of that, which would be a pain.
Here (https://vitejs.dev/config/#server-https) in docs, no examples are given.
server.https
Type: boolean | https.ServerOptions

Enable TLS + HTTP/2. Note this downgrades to TLS only when the server.proxy option is also used.

The value can also be an options object passed to https.createServer().

Usually in node.js it is set like this:
response.writeHead(200, { "Content-Type": mimeType ,
  "Cross-Origin-Opener-Policy": "same-origin",
  "Cross-Origin-Embedder-Policy": "require-corp" });

But it seems that in vite there is no way to do it?

Well, I build this plugin. It works for my purpose but may require further testing.
https://github.com/chaosprint/vite-plugin-cross-origin-isolation

Well, I build this plugin. It works for my purpose but may require further testing.
https://github.com/chaosprint/vite-plugin-cross-origin-isolation

Worked for me. Awesome lib. Thanks!

Any headers should be configured like in serve https://github.com/vercel/serve-handler#headers-array

Any headers should be configured like in serve https://github.com/vercel/serve-handler#headers-array

Thanks for the info. I know that Firebase or Netlify all have own ways to set it, but in this issue thread I am referring to the vitejs local dev server. This header settings should become default for testing SAB locally.

@chaosprint thank you for reply.  I developing frontpage  for our wasm lib in vite  and it require special headers for it. I using some plugin for vite for it. But I suppose it should be in core for wasm supporting.

To add custom headers, you can add the following snippet inline to the vite.config.ts file. The code is based on the plugin of @chaosprint. Thank you for that!
import { defineConfig } from 'vite';

export default defineConfig({
  plugins: [
    {
      name: 'configure-response-headers',
      configureServer: server => {
        server.middlewares.use((_req, res, next) => {
          res.setHeader('Test-Header', 'A random value');
          next();
        });
      }
    }
  ]
});

@ssc-hrep3
thx but I did it with vite-plugin-cross-origin-isolation.
I ask about how to copy wasm files with js glue (after emscripten) from src to dist folder with linking.

Going off of what @ssc-hrep3 here's what I have now in my vite.config.ts file!
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    react(),
    {
      name: "configure-response-headers",
      configureServer: (server) => {
        server.middlewares.use((_req, res, next) => {
          res.setHeader("Cross-Origin-Embedder-Policy", "require-corp");
          res.setHeader("Cross-Origin-Opener-Policy", "same-origin");
          next();
        });
      },
    },
  ],
});

This can now be supported through the server.headers option since https://github.com/vitejs/vite/pull/5580


Couldn't quantize a model with QUANTIZED_UINT8 if output layer don't have activation

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): installed a binary with Conda
TensorFlow version (or github SHA if from source): 1.14.0

Command used to run the converter or code if you’re using the Python API
import tensorflow as tf
from tensorflow import keras

import numpy as np
import matplotlib.pyplot as plt

fashion_mnist = keras.datasets.fashion_mnist
(train_images, train_labels), (test_images, test_labels) = fashion_mnist.load_data()

train_images = train_images / 255.0
test_images = test_images / 255.0

def build_keras_model():
  return keras.Sequential([
    keras.layers.Flatten(input_shape=(28,28)),
    keras.layers.Dense(128, activation='relu'),
    keras.layers.BatchNormalization(),
    keras.layers.Dense(10)
  ])

train_graph = tf.Graph()
train_sess = tf.Session(graph=train_graph)

keras.backend.set_session(train_sess)
with train_graph.as_default():
  train_model = build_keras_model()

  tf.contrib.quantize.create_training_graph(input_graph=train_graph, quant_delay=100)
  train_sess.run(tf.global_variables_initializer())

  train_model.compile(
    optimizer='adam',
    loss='sparse_categorical_crossentropy',
    metrics=['accuracy']
  )
  train_model.fit(train_images, train_labels, epochs=5)

  saver = tf.train.Saver()
  saver.save(train_sess, 'checkpoints')

eval_graph = tf.Graph()
eval_sess = tf.Session(graph=eval_graph)

keras.backend.set_session(eval_sess)

with eval_graph.as_default():
  keras.backend.set_learning_phase(0)
  eval_model = build_keras_model()
  tf.contrib.quantize.create_eval_graph(input_graph=eval_graph)
  eval_graph_def = eval_graph.as_graph_def()
  saver = tf.train.Saver()
  saver.restore(eval_sess, 'checkpoints')

  frozen_graph_def = tf.graph_util.convert_variables_to_constants(
    eval_sess,
    eval_graph_def,
    [eval_model.output.op.name]
  )
  with open('frozen_model.pb', 'wb') as f:
    f.write(frozen_graph_def.SerializeToString())

converter = tf.lite.TFLiteConverter.from_frozen_graph(
  'frozen_model.pb',
  ['flatten_input'],
  ['dense_1/BiasAdd'])
converter.inference_type = tf.lite.constants.QUANTIZED_UINT8
input_arrays = converter.get_input_arrays()
converter.quantized_input_stats = {input_arrays[0] : (0, 255)}  # mean, std_dev
tflite_model = converter.convert()
open('model.tflite', 'wb').write(tflite_model)

The output from the converter invocation
---------------------------------------------------------------------------
ConverterError                            Traceback (most recent call last)
<ipython-input-18-c82690488195> in <module>
      6 input_arrays = converter.get_input_arrays()
      7 converter.quantized_input_stats = {input_arrays[0] : (0, 255)}  # mean, std_dev
----> 8 tflite_model = converter.convert()
      9 open('model.tflite', 'wb').write(tflite_model)

~/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/lite/python/lite.py in convert(self)
    896           input_tensors=self._input_tensors,
    897           output_tensors=self._output_tensors,
--> 898           **converter_kwargs)
    899     else:
    900       result = _toco_convert_graph_def(

~/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/lite/python/convert.py in toco_convert_impl(input_data, input_tensors, output_tensors, *args, **kwargs)
    402   data = toco_convert_protos(model_flags.SerializeToString(),
    403                              toco_flags.SerializeToString(),
--> 404                              input_data.SerializeToString())
    405   return data
    406

~/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/lite/python/convert.py in toco_convert_protos(model_flags_str, toco_flags_str, input_data_str)
    170       stderr = _try_convert_to_unicode(stderr)
    171       raise ConverterError(
--> 172           "TOCO failed. See console for info.\n%s\n%s\n" % (stdout, stderr))
    173   finally:
    174     # Must manually cleanup files.

ConverterError: TOCO failed. See console for info.
2019-11-14 14:46:19.525955: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 39 operators, 63 arrays (0 quantized)
2019-11-14 14:46:19.526224: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 39 operators, 63 arrays (0 quantized)
2019-11-14 14:46:19.527392: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 1: 10 operators, 18 arrays (1 quantized)
2019-11-14 14:46:19.527775: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 2: 9 operators, 17 arrays (1 quantized)
2019-11-14 14:46:19.527893: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 3: 8 operators, 15 arrays (1 quantized)
2019-11-14 14:46:19.527982: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before pre-quantization graph transformations: 8 operators, 15 arrays (1 quantized)
2019-11-14 14:46:19.528015: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After pre-quantization graph transformations pass 1: 5 operators, 12 arrays (1 quantized)
2019-11-14 14:46:19.528050: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Group bidirectional sequence lstm/rnn: 5 operators, 12 arrays (1 quantized)
2019-11-14 14:46:19.528084: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before quantization graph transformations: 5 operators, 12 arrays (1 quantized)
2019-11-14 14:46:19.529767: W tensorflow/lite/toco/graph_transformations/quantize.cc:132] Constant array batch_normalization/batchnorm/mul lacks MinMax information. To make up for that, we will now compute the MinMax from actual array elements. That will result in quantization parameters that probably do not match whichever arithmetic was used during training, and thus will probably be a cause of poor inference accuracy.
2019-11-14 14:46:19.529796: W tensorflow/lite/toco/graph_transformations/quantize.cc:132] Constant array batch_normalization/batchnorm/sub lacks MinMax information. To make up for that, we will now compute the MinMax from actual array elements. That will result in quantization parameters that probably do not match whichever arithmetic was used during training, and thus will probably be a cause of poor inference accuracy.
2019-11-14 14:46:19.529847: F tensorflow/lite/toco/graph_transformations/quantize.cc:149] Array dense_1/BiasAdd does not have MinMax information, and is not a constant array. Cannot proceed with quantization.
Fatal Python error: Aborted

Current thread 0x00007f40e79dd700 (most recent call first):
  File "/home/dojip.kim/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 33 in execute
  File "/home/dojip.kim/anaconda3/envs/tensorflow/lib/python3.6/site-packages/absl/app.py", line 251 in _run_main
  File "/home/dojip.kim/anaconda3/envs/tensorflow/lib/python3.6/site-packages/absl/app.py", line 300 in run
  File "/home/dojip.kim/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 40 in run
  File "/home/dojip.kim/anaconda3/envs/tensorflow/lib/python3.6/site-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 59 in main
  File "/home/dojip.kim/anaconda3/envs/tensorflow/bin/toco_from_protos", line 11 in <module>

Also, please include a link to the saved model or GraphDef
# Put link here or attach to the issue.

Failure details
I could quantize a model with QUNATIZED_UINT8 if output layer have activation like 'softmax'.  I want to quantize a model without the activation function for the final output. In that case, I couldn't quantize it.
2019-11-14 14:46:19.529847: F tensorflow/lite/toco/graph_transformations/quantize.cc:149] Array dense_1/BiasAdd does not have MinMax information, and is not a constant array. Cannot proceed with quantization.
Fatal Python error: Aborted
Please let me know how to quantize a model.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Here are the node names and operations of the frozen_model.pb
flatten_input => Placeholder
flatten/Shape => Shape
flatten/strided_slice/stack => Const
flatten/strided_slice/stack_1 => Const
flatten/strided_slice/stack_2 => Const
flatten/strided_slice => StridedSlice
flatten/Reshape/shape/1 => Const
flatten/Reshape/shape => Pack
flatten/Reshape => Reshape
dense/kernel => Const
dense/bias => Const
dense/MatMul/ReadVariableOp => Identity
dense/MatMul => MatMul
dense/BiasAdd/ReadVariableOp => Identity
dense/BiasAdd => BiasAdd
dense/Relu => Relu
batch_normalization/gamma => Const
batch_normalization/beta => Const
batch_normalization/moving_mean => Const
batch_normalization/moving_variance => Const
batch_normalization/batchnorm/ReadVariableOp => Identity
batch_normalization/batchnorm/add/y => Const
batch_normalization/batchnorm/add => Add
batch_normalization/batchnorm/Rsqrt => Rsqrt
batch_normalization/batchnorm/mul/ReadVariableOp => Identity
batch_normalization/batchnorm/mul => Mul
batch_normalization/batchnorm/mul_1 => Mul
batch_normalization/batchnorm/ReadVariableOp_1 => Identity
batch_normalization/batchnorm/mul_2 => Mul
batch_normalization/batchnorm/ReadVariableOp_2 => Identity
batch_normalization/batchnorm/sub => Sub
batch_normalization/batchnorm/add_1 => Add
dense_1/kernel => Const
dense_1/bias => Const
dense_1/MatMul/ReadVariableOp => Identity
dense_1/MatMul => MatMul
dense_1/BiasAdd/ReadVariableOp => Identity
dense_1/BiasAdd => BiasAdd
dense/weights_quant/min => Const
dense/weights_quant/min/read => Identity
dense/weights_quant/max => Const
dense/weights_quant/max/read => Identity
dense/weights_quant/FakeQuantWithMinMaxVars => FakeQuantWithMinMaxVars
dense/act_quant/min => Const
dense/act_quant/min/read => Identity
dense/act_quant/max => Const
dense/act_quant/max/read => Identity
dense/act_quant/FakeQuantWithMinMaxVars => FakeQuantWithMinMaxVars
dense_1/weights_quant/min => Const
dense_1/weights_quant/min/read => Identity
dense_1/weights_quant/max => Const
dense_1/weights_quant/max/read => Identity
dense_1/weights_quant/FakeQuantWithMinMaxVars => FakeQuantWithMinMaxVars
batch_normalization/batchnorm/mul_1/activation_Mul_quant/min => Const
batch_normalization/batchnorm/mul_1/activation_Mul_quant/min/read => Identity
batch_normalization/batchnorm/mul_1/activation_Mul_quant/max => Const
batch_normalization/batchnorm/mul_1/activation_Mul_quant/max/read => Identity
batch_normalization/batchnorm/mul_1/activation_Mul_quant/FakeQuantWithMinMaxVars => FakeQuantWithMinMaxVars
batch_normalization/batchnorm/add_1/activation_Add_quant/min => Const
batch_normalization/batchnorm/add_1/activation_Add_quant/min/read => Identity
batch_normalization/batchnorm/add_1/activation_Add_quant/max => Const
batch_normalization/batchnorm/add_1/activation_Add_quant/max/read => Identity
batch_normalization/batchnorm/add_1/activation_Add_quant/FakeQuantWithMinMaxVars => FakeQuantWithMinMaxVars


There are issues in how FFMpeg works with our tool in terms of frame-rates and having data available

At this time it is our recommendation that using FFMpeg and Liveswitch-Connect may work but would be considered unstable.
There are many cases we’ve found which will cause a crash that is outside of the client's control.
We recommend using NDI to avoid these problems or a Loopback Adapter.

Cases where the framerate changes can crash when using FFRender and the default LSDecode. Has to do with FFMpeg socket reader throwing an EOF or InvalidData if there are no frames or too many frames in the buffer.


Add "benediktmeurer.de" to list of 11ty users

Adding my website, which was migrated to 11ty recently (having my colleague @mathiasbynens pushing me into this).

Thank you! (and to @mathiasbynens 😀)


adding system prompt to custom dataset

What does this PR do?
Small update to examples/custom_dataset.py to add an optional system prompt argument to tokenize_dialog(). As shown in https://huggingface.co/blog/llama2#how-to-prompt-llama-2 for example.
Feature/Issue validation/testing
Added an additional test test_system_prompt() in tests/datasets/test_custom_dataset.py to verify expected behavior.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

Thanks for contributing 🎉!

@mreso any thoughts? happy to do some refactoring if needed


Error when installing OXAR with ORDS 3.0.11

Error when installing OXAR with ORDS 3.0.11:
This version of ORDS is not yet supprted in OXAR Please report this at http://github.com/OraOpenSource/oxar/issues

I created a branch with the changes. Haven't tested yet, so if you happen to be running again, let me know if all is good

Should be resolved in #240


doc request — authentication details

Summary
What does wn.redirectToLobby do? It takes you to the auth-lobby site, and what happens there? I imagine it updates state stored within indexedDB. I would like to be able to mock the call to update indexedDB, so that you could be authenticated just locally, without an external service. This would be using IPFS just on your local computer, not synchronizing with any server.
Detail
The context
I am making a module that uses webnative, and I'm trying to run tests -- https://github.com/nichoth/wn-blob/blob/1f7bd69f140fe090cc209f3c302baf6af1eaa1ae/test/index.js#L42
The tests are automated,  and start with a brand new browser each time. So how to do authentication?
The call to wn.initialise returns
{
      scenario: 'NOT_AUTHORISED',
      permissions: {
        app: { name: 'test', creator: 'nichoth' },
        fs: { public: [Array] }
      },
      authenticated: false
    }

The readme says to call wn.redirectToLobby. But it's not ideal since the tests are running without a UI.
 case wn.Scenario.NotAuthorised:
    wn.redirectToLobby(state.permissions)
    break;

At the moment webnative is designed to only run with a UI.
Getting all of webnative to work in nodejs is planned - but it'll take a while before we support something like that fully.

Documenting what the auth lobby does is an orthogonal issue I think.  I think we might need to update the auth lobby's readme.

✅
Going to close since there is an issue in auth-lobby for this


Reduce the default PooledByteBufAllocator chunk size from 16 MiB to 4 MiB

Motivation:
By default we allocate 2 arenas per core, and each arena that is put to use will allocate a chunk.
If we don't need a lot of memory, and certainly not compared to the number of cores on a system, then this will take up more memory than necessary, since each chunk is 16 MiB.
By reducing the chunk size to 4 MiB, we reduce the minimum memory usage by a good deal, in these cases where not much is needed.
The drawback is that we risk allocating more huge buffers, but this is a fair trade-off since Netty's use cases mostly involve very small buffers.
Modification:
Reduce the default max order from 11 to 9.
Also make similar configuration changes in PooledByteBufAllocatorTest, to reduce the memory usage during testing.
Result:
Netty now uses less memory when less memory is needed by the application.
This fixes #8536

@chrisvest exactly :)

Put that back port in a separate PR: #12109

@chrisvest so from a practical pov if the chunk is smaller and there's no available pooled we just allocate one?
I might need to expose io.netty.buffer.PoolSubpageMetric in our application to get a better idea of what "available" is in production to avoid regressions in performance.

That's why I have proposed a soft limit to release some memory if the memory used goes below a threshold after a configurable amount of time

I am in favour of this, though I wonder whether it may cause unexpected changes to the perf characteristics of different applications. I know it can be easily overridden but often netty is used within libraries that don't have control over sys props. Same comment would apply to the non-EL buffer change. How about reducing to 8MiB for at least a couple of releases first? In any case we'd want to have this/these very clearly communicated with the release.
Related old issue: #9768

@chrisvest WDYT ?

@normanmaurer @njhill Made the change less dramatic.

@chrisvest sorry for the back and forth but with the feedback of @ejona86 let's just go all in and use 4 :). Once you adjusted  it please merge.

Alright, I have no strong opinion on 8 vs 4.

Sorry for such a late response on this. But we changed this setting in Elasticsearch to 1MB (https://github.com/elastic/elasticsearch/pull/62410) a while back because we found pool chunks were always causing G1GC humungous allocations which is very inefficient in memory usage since it causes significant portions of G1GC regions to be wasted. Additionally, our allocations are pretty fixed in size at 64KB, 32KB, or 16KB so the smaller chunks don't make a significant difference for us.
Just an additional point about the motivation for smaller chunks.


Store password in secure type like secstr::SecUtf8

Would it be a good idea to return the password wrapped in data type meant for that purpose? Possibly as an optional feature.
Advantages include being unprintable, zero-ing when dropped, and other things mentioned at secstr.
(It could be any type, I'm not affiliated with secstr, it's just the only one I know.)

mlock protection if possible: it's sadly not cross platform but would be great to have on unix

Windows has a similar function called VirtualProtect which is already available in the winapi crate

This issue seems stale. If at any point anyone wants to create a pull request for that, feel free to do so.

This issue seems stale. If at any point anyone wants to create a pull request for that, feel free to do so.


Issue with Setting up DNS records in PrivateLink Setup to the Dedicated cluster

Hi @linouk23, i'm trying to setup PrivateLink setup with the terraform scripts, in the step for setting up the DNS records, it's throwing these errors. Could you please kindly help in the same as i've used the same terraform scripts that are given here.

aws_vpc_endpoint.privatelink: Still creating... [1m40s elapsed]
aws_vpc_endpoint.privatelink: Still creating... [1m50s elapsed]
aws_vpc_endpoint.privatelink: Still creating... [2m0s elapsed]
aws_vpc_endpoint.privatelink: Still creating... [2m10s elapsed]
aws_vpc_endpoint.privatelink: Creation complete after 2m15s [id=vpce-xyz]
╷
│ Error: Error in function call
│
│   on main.tf line 253, in locals:
│  253:   hosted_zone      = replace(regex("^[^.]+_([0_9a_zA_Z]+[.].*):[0_9]+$", confluent_kafka_cluster.dedicated.bootstrap_endpoint)[0], "glb.", "")
│     ├────────────────
│     │ confluent_kafka_cluster.dedicated.bootstrap_endpoint is "lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:9092"
│
│ Call to function "regex" failed: pattern did not match any part of the
│ given string.
╵
Releasing state lock. This may take a few moments...
ERRO[3751] Module /Users/vsharma8/projects/github.int.mcafee.com/mcafee/efw-infra/infra/qa has finished with an error: 1 error occurred:
        * exit status 1

Thanks for reporting an issue @VipulZopSmart!
That actually looks interesting. Could you double check the value of confluent_kafka_cluster.dedicated.bootstrap_endpoint?
When I run it locally:
locals {
  new_boostrap = "lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:9092"
}

output "foo" {
  value = replace(regex("^[^.]+-([0-9a-zA-Z]+[.].*):[0-9]+$", local.new_boostrap)[0], "glb.", "")
}

I can see:
terraform plan

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

Terraform will perform the following actions:

Plan: 0 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + foo = "pdwnk6.us-west-2.aws.confluent.cloud"

I can't reproduce it 🤔

@linouk23 , i erased the line and copy pasted again, now that is working fine but while creating API keys for the topics now it's failing. The errors are as follows:
╷
│ Error: error waiting for Kafka API Key "AKLRQC4ARLUDTXKV" to sync: error listing Kafka Topics using Kafka API Key "AKLRQC4ARLUDTXKV": Get "https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics": GET https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics giving up after 5 attempt(s): Get "https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics": cannotconnect
│
│   with confluent_api_key.app_manager_kafka_api_key,
│   on main.tf line 58, in resource "confluent_api_key" "app_manager_kafka_api_key":
│   58: resource "confluent_api_key" "app_manager_kafka_api_key" {
│
╵
╷
│ Error: error waiting for Kafka API Key "RGCHUQAXKMVUNX65" to sync: error listing Kafka Topics using Kafka API Key "RGCHUQAXKMVUNX65": Get "https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics": GET https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics giving up after 5 attempt(s): Get "https://lkc-w7kgd5-pdwnk6.us-west-2.aws.glb.confluent.cloud:443/kafka/v3/clusters/lkc-w7kgd5/topics": cannotconnect
│

Not sure if the API keys got created, it's failing in between.

👍 @VipulZopSmart
This new issue is related to connectivity issue:

This example assumes that Terraform is run from a host in the private network, where it will have connectivity to the Kafka REST API in other words, to the REST endpoint on the provisioned Kafka cluster.

@linouk23 i added disable_wait_for_ready, now it's failing in generating ACLs and the topics, the errors are same like above looks like some connectivity issue. Could you please tell me do i need to add something in the resource of ACLs ant topics?

@VipulZopSmart you need to run the whole example / or at least code snippet that creates ACL / topics from

a host in the private network, where it will have connectivity to the Kafka REST API in other words, to the REST endpoint on the provisioned Kafka cluster.

Namely, run Terraform configuration from an ec2 instance that is in the target network (not just from a laptop).


How to make 200 redirect ONLY when there is no file

Please describe which feature you have a question about?
Redirects and rewrites
Provide additional details
Hello,
I have a problem with the 200 rewrites.
Imagine I have a pre-generated news website with Gatsby.
I have some generated html files with the path /news/xxx and some news non-generated with the same path.
To handle non-generated news I have a static file /loader/news which make all api request to display the news as a pre-generated one. Obviously, to handle it, I've add a 200 rewrite like that :
{
  "source": "/news/<*>",
  "target": "/loader/news",
  "status": "200",
  "condition": null
}

But my pre-generated news are also rewrited to /loader/news.
If I change the status to 404-200 it work well but the status code one non-regenerated are 404 which is wrong...
How can I make the 200 status code work only if the requested file is not found ?
What AWS Services are you utilizing?
Amplify

Hi @AlexandreFauchard apologies for the delay. We are investigating if this is currently possible. We will update you shortly.

It's currently not possible to make a redirect rule conditional in this way. If you had a specific path for the non-generated pages like /news/xxx/xxx then you would be able to leverage the Order of Redirects and have that rule honored first. The pre-generated pages at news/xxx would then be redirected using the rule you already have.


fix issues with cs so + cs vm system by using built-in custom cs so instead of managing it, update migration scripts

resolves https://github.com/kthcloud/go-deploy/issues/360


Idea: Achievement based special badges

Custom designed badges a la  for...

time spent with a stream event or series
time spent in a channel
Milestones with badge trading

Times a trade made
Times checked for set completion

Achievements could also give XP


Support several extensions on indexes

Most index types use a single file extension. But some others do not.
Thinking that ForwardIndexType was the only that supports multiple file extensions, which depends on whether the column is sorted, dictionary encoded, etc. We initially added a ColumnMetadata argument to IndexType.getFileExtension. But recent bug reports (see https://github.com/apache/pinot/issues/11529 and https://github.com/apache/pinot/issues/11520) prove that we were wrong and Text index does also use different file extensions depending on whether it uses the native or lucene type.
This PR changes the code a bit. It replaces String IndexType.getFileExtension(ColumnMetadata) with List<String> IndexType.getFileExtensions(@Nullable ColumnMetadata). This means that each index may return several extensions. The code that called this method has been changed accordingly. This mainly affects FilePerIndexDirectory.getFileFor, which now depends on FilePerIndexDirectory.getFilesFor, which returns a list of them. The older method returns the first file that does exist or any on the list in case there is no file with a valid extension. That is compatible with the older implementation, which my return files that didn't exist.
A couple of new test were added. They reproduce the error detected in https://github.com/apache/pinot/issues/11529. These test fail on master and run successfully in this PR. Creating a test that replicates https://github.com/apache/pinot/issues/11520 is more difficult and I propose to merge this without having an automatic test for that case.

Codecov Report

Merging #11600 (4da2da1) into master (4292356) will decrease coverage by 48.43%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11600       +/-   ##
=============================================
- Coverage     62.92%   14.49%   -48.43%
+ Complexity     1103      201      -902
=============================================
  Files          2326     2326
  Lines        124984   125008       +24
  Branches      19080    19081        +1
=============================================
- Hits          78641    18124    -60517
- Misses        40730   105353    +64623
+ Partials       5613     1531     -4082

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
14.49% <0.00%> (-0.02%)
:arrow_down:

java-17
?

java-20
?

temurin
14.49% <0.00%> (-48.43%)
:arrow_down:

unittests
14.49% <0.00%> (-48.42%)
:arrow_down:

unittests1
?

unittests2
14.49% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ment/local/segment/index/bloom/BloomIndexType.java
0.00% <0.00%> (-89.66%)
:arrow_down:

.../segment/index/dictionary/DictionaryIndexType.java
0.00% <0.00%> (-83.74%)
:arrow_down:

.../local/segment/index/forward/ForwardIndexType.java
0.00% <0.00%> (-92.67%)
:arrow_down:

.../segment/local/segment/index/fst/FstIndexType.java
0.00% <0.00%> (-65.00%)
:arrow_down:

...ot/segment/local/segment/index/h3/H3IndexType.java
0.00% <0.00%> (-67.86%)
:arrow_down:

...ocal/segment/index/inverted/InvertedIndexType.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...egment/local/segment/index/json/JsonIndexType.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...al/segment/index/nullvalue/NullValueIndexType.java
0.00% <0.00%> (-82.61%)
:arrow_down:

...ment/local/segment/index/range/RangeIndexType.java
0.00% <0.00%> (-83.34%)
:arrow_down:

...egment/local/segment/index/text/TextIndexType.java
0.00% <0.00%> (-78.44%)
:arrow_down:

... and 2 more

... and 1486 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


for https://www.hoyolab.com/

How to make accept the https://www.hoyolab.com/ cookies , i can't manage to make it work.
Please help.

modify api related url and arguments https://github.com/mcxiaoke/CarrotProjects/blob/master/GenshinLib/GenshinConst.cs
you can try this https://github.com/DGP-Studio/Snap.Genshin hoyolab is supported maybe

Thank you ! I apreciate it you response.

@cip300  for you, here it's a working example: https://github.com/y1ndan/genshinhelper2/blob/main/genshinhelper/hoyolab.py

https://github.com/Xm798/Genshin-Dailynote-Helper.git


Authenticator Email Only Signup fails

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
5.3.0
What operating system are you using?
mac
Amplify Categories
auth
Amplify Commands
add
Describe the bug
When I try and create a new account, using my email address, I get the following message.
Username cannot be of email format, since user pool is configured for email alias
I did notice that the new pool has "Username" selected under the user pool attributes. I believe it should be "Email address or phone number".
I believe there are related bugs filed #7833, but they were using a custom flow and not the hosted/built in widget. Most likely the same root issue, so I thought I'd file a separate bug. Please mark duplicate if they are in fact the same issue.
Expected behavior
Allow email address to be used as the login instead of a username.
Reproduction steps
I deleted my old auth setup/userpools which was set up for username login.
I added a new auth setup which uses email login. I followed the steps found here:
https://docs.amplify.aws/guides/authentication/email-only-authentication/q/platform/js/#ui-components
I use the built in authenticator widget in my app.
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Hey @awhig :wave: thanks for raising this! The change to use username alias attributes was recent, and the issue you are experiencing does appear to be related to the mentioned issue. Labelling this as a duplicate auth bug and closing in favor of tracking #7833. Please subscribe to the mentioned issue for updates 🙂 and we will work with the folks maintaining the components to find a suitable solution.


Support for Sharing a Volume Among Different Kubernetes Namespaces

Requirement
We have a requirement to share a volume with different PODs in different Kubernetes namespaces.
Problem
In Kubernetes, a volume can only be shared within one namespace by using PersistentVolumeClaim. It is not easy to share a purestorage volume among different namespaces.
Can you provide an official way to fulfill this requirement?
Workaround
Currently, we are using some workaround to share the same purestorage among different namespaces.  Is there any problem with it?

Create a PersistentVolumeClaim in one namespace. Because we already have purestorage Storage Class being configured. a new PV and purestorage volume are provisioned.
run "kubectl get -o yaml <the_new_pv_name>" on the new PV
the output would look like this:

apiVersion: v1
kind: PersistentVolume
metadata:
  name: pv1
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 2Gi
  persistentVolumeReclaimPolicy: Retain
  flexVolume:
    driver: pure/flex-norelabel
    fsType: nfs
    options:
      accessMode: exclusive
      backend: file
      labels: ""
      namespace: k8s
      volumeMode: ""
      volumeName: pvc-xxxx
  storageClassName: pure

create a new PV in a different namespace with same flexVolume settings retrieved from the first PV.
because this new PV have the same flexVolume setting. It will actually use the same purestorage volume.

@zhaojunhua119 First and most important comment - FlexVolumes are now deprecated and Pure recommends that you upgrade to the CSI version of the PSO driver.
After you have done this, we can reassess your issue as your workaround may not work with a CSI driver.

Thank you @sdodsley , I have post it in helm-charts  https://github.com/purestorage/helm-charts/issues/241

Issue raised in incorrect repo.


Support For Other sites

Is there any plan of adding support for other sites like zoro or 9anime. Or it will be legal sites only.

It is and will be legal only.


sc scraper broken, site has changed

New url: https://www.sccourts.org/opinions-orders/opinions/published-opinions/supreme-court/?term=2024-09
Old url not longer working: https://www.sccourts.org/opinions/indexSCPub.cfm?year=2024&month=9
Sentry Issue: COURTLISTENER-86B

May as well start collecting unpublished opinions, which have the same frontend
https://www.sccourts.org/opinions-orders/opinions/unpublished-opinions/court-of-appeals/
https://www.sccourts.org/opinions-orders/opinions/unpublished-opinions/supreme-court/?term=2024-07


[Storage] Onboard Storage Table Commands

If it follows blob and file, 70% or more can be reflected from the SDK.

PR #702 merged.


[Feature Request] Add the Suggest field containing the output from the did-you-mean suggester in the SearchResp

Is your feature request related to a problem? Please describe
Calling the Search function with a term suggester query as shown here in the documentation does not return suggestions. This is because the SearchResp struct does not contain the Suggest field that should contain the suggestions for the misspelt tokens.
Describe the solution you'd like
Adding the Suggest field to the SearchResp struct
Related component
Search
Describe alternatives you've considered
No response
Additional context
No response

Suggest         map[string][]Suggest       json:"suggest,omitempty"


make install broken

make install is currently broken. It errors with the following output:
sed: 1: "sample.tf": unterminated substitute pattern
I'm not super knowledgable about sed, but I was able to get make install to work successfully by changing this line to use sed -ie instead of just sed -i

do you have POSIX sed (Mac default)? It works on GNU sed.

Yes I have the mac default sed.

@codebop , I just checked - -ie works on both sed versions. So, I'm gonna add it now.

@danielmkn Thanks so much!


Upload project javadocs folder

Generate project javadoc files and upload it as a folder to GitHub.

Alternatives are better, javadocs will be kept in a separate branch though.


dist: implement auth challenge

This PR supports auth challenge using  github.com/docker/distribution/registry/client/auth/challenge.
With this PR, auth.docker.io no longer needs to be hard-coded
Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

Codecov Report

Merging #546 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   62.12%   62.12%
=======================================
  Files           3        3
  Lines         404      404
=======================================
  Hits          251      251
  Misses         93       93
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b1736...8d0e91c. Read the comment docs.

@AkihiroSuda The intention here is actually side-channel the authentication with a callback system. Currently, the authentication is very protocol bound and this PR continues in that vein, preventing different styles of authentication to be implemented.
Essentially, I don't want to take this code down this path until we've solved this problem.

OK, and closing this PR, in favor of the resolver/fetch interface introduced in the summit 👍


ghprb stores transient info in the job file

I recently upgrade from 1.29.5 to 1.30 and I noticed now the plugin stores the last PR tested in the config, for example:
      <pullRequests class="concurrent-hash-map">
        <entry>
          <int>955</int>
          <org.jenkinsci.plugins.ghprb.GhprbPullRequest>
            <id>955</id>
            <updated>2016-01-29 19:56:56.0 UTC</updated>
            <head>9ced4278ac0af138846672da6b103172a09e37ae</head>
            <accepted>true</accepted>
            <changed>false</changed>
          </org.jenkinsci.plugins.ghprb.GhprbPullRequest>
        </entry>
      </pullRequests>

This is quite inconvenient for me, as I have all jenkins config versioned. This is first time I see a job file storing information that changes from run to run, so this mean I will get a lot of config updates that are completely irrelevant, and not really data the user configure.
Can this information be stored in another file?

Will be fixed in #259

+1, we use chef-client and upload all of our job XML files from a Git repo periodically, so when Chef overwrites the XML for a given job this info disappears, and we are seeing multiple builds for a single PR for no good reason.

Will be fixed in #259

Thanks!

Oh, this is worse than I thought, if you change a job configuration via Jenkins' web interface, all PR metadata is removed from the job configuration too. Will be a release with this fix soon?

The latest is released,  1.30.1

@leandro-lucarella-sociomantic please check and close if the result is acceptable

It's working great! Thanks a lot for the quick fix!


Adjustments in the referendums page

Adjustments Referendums page:

Finished Referndums -- > Past Referendums
Remove brackets
Text bigger
In the List: show the First x characters of the "Text to add"
For the not opened referendums display: "Haven't been opened for voting yet"

Completed on version 0.7.7


Return stream on IUploadFileParameter

We should also probably rename IUploadFileParameter to IFileParameter.

Also have the file streams delayed created until specifically requested. That way we don't have to clean up resources after requests.


Docs: Update dataframe-groupby.rst [skip ci]

This PR updates dataframe-groupby.rst with a few corrections to grammar, punctuation and naming conventions (nothing major)

Thanks @farrajota!


feat(#17): Add range input

Closes #17
Description
Add range input support
Tested on:

[x] MacOS, GNU bash 3.2.57
[x] Uubntu 20.04, bash 5.0.17
[x] Windows 10, bash ??

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Using with slint

Hello, great library!
I am trying to use it with slint on esp32-s3 and I am getting Exception occured 'LoadProhibited' error
The funny thing is, my equivalent implementation of https://github.com/slint-ui/slint/blob/cadfd9e1041214021a375795df9ef96e45d14999/examples/mcu-board-support/esp32_s3_box.rs#L219 is
display.clear();
display.flush().unwrap();

Do you have any ideas why this is happening?
If not, would it be worth while implementing set_pixels method in this driver like it is implemented in this one? https://github.com/almindor/st7789/blob/e18dc571c1e2adb56bf9c6511887845b852f69c6/src/lib.rs#L236
Thank you!

Please provide more information:

A minimal example to reproduce the issue.
A precise request, for example, if you need a feature like set_pixels.

Please do not provide external exceptions such as:

Exception occurred 'LoadProhibited'

At the library level, we cannot support issues caused by other libraries.
What are the requirements for set_pixels when set_pixel is already available with the buffered approach?
https://github.com/IniterWorker/gc9a01/blob/6b3ddc81c68e61b495825ab46a58a33a37bba1e9/src/mode/graphics.rs#L164

I think the key difference between set_pixel is that it changes data in the buffer, while set_pixels writes it straight to the device, line by line
Will try to submit minimal reproduceable example soon

In progress of stripping down everything, the exception went away but it's not displaying correctly
Here is what is expected:

Here is what I get:
Note the little line at the edge changes when background color is changed

Branch with code:
https://github.com/rsov/rusty_bucket_face/blob/feature/slint/src/main.rs
I have tried changing rotation and replacing the example fill_contiguous code that yielded same results
for (i, pixel_color) in buffer.iter().enumerate() {
  self.display.set_pixel(i as _, line as _, pixel_color.0);
}

It almost feels like it's either rendering the very last bit or one of the axis is flipped
Any help with this is appreciated

Yes the example code worked well with direct draw calls
Sorry, I am out of my depth when it comes to embedded environments and rust. What would be some good keywords to search for to get started?

You may have been on the right track with the double buffering issue
I have forked and added a method to send buffer data directly. It works... but the colors are all wrong and it lost the sharpness. Will see if it's possible to improve it further
https://github.com/rsov/gc9a01/blob/7f5a94657cf327b9a23a1a80a28fe015edc09cdd/src/driver.rs#L287

Please always provide an example. Mainly a color shift from your end with map(|&x| x.0). But, I can't help you without more source.

I am implementing the esp32-s3-touch-lcd-1-28 with lvgl. Currently, lvgl provides a specialized trait for drawing lines using embedded_graphics (https://github.com/lvgl/lv_binding_rust/blob/3b3abb3019eef637b932fae967a8d246bf5b6f14/lvgl/src/display.rs#L308).
It seems like a better approach for slint to offer such a trait as well.

@IniterWorker It does look somewhat similar. I think slint wants to write directly into buffer
I got it to work on my project but haven't had the time to fork your example code and port it there

@IniterWorker Got the example repo up https://github.com/rsov/esp_s3_touch_lcd_1_28_example_slint
See this commit in driver, gives direct access to the buffer https://github.com/rsov/gc9a01/commit/b1c71fe54611dbf2ac674ff8fd527d0605fef768 then it is used here to send data to screen in the example
I can open a PR for it but it does not feel like I have implemented it the correct way

Seems like you are missing some commands https://github.com/rsov/gc9a01/commit/b1c71fe54611dbf2ac674ff8fd527d0605fef768 like MemoryWrite.
Maybe, I should provide an unbuffered driver to easly customized the driver implementation/usage.
NOTE: You may encouter #8, I will fix this soon.

So I've tried implementing fill_contiguous method  and then using it as it's written in slint docs, going off the work done in this one https://github.com/IniterWorker/gc9a01/issues/8
And it works! 🚀
But UI feels slower compared to just writing it directly like https://github.com/rsov/gc9a01/commit/b1c71fe54611dbf2ac674ff8fd527d0605fef768 because you have to flush buffer after each line. And this way doesn't do screen rotation and has endianness issues
I will see if I can make something like this method but public https://github.com/IniterWorker/gc9a01/blob/89adb341b8c6ed3c2d33e742ad9c609884174776/src/driver.rs#L265
Or this that accepts RBG color
https://github.com/IniterWorker/gc9a01/blob/89adb341b8c6ed3c2d33e742ad9c609884174776/src/driver.rs#L127

But UI feels slower compared to just writing it directly like https://github.com/rsov/gc9a01/commit/b1c71fe54611dbf2ac674ff8fd527d0605fef768 because you have to flush buffer after each line. And this way doesn't do screen rotation and has endianness issues

If you're looking for performance and direct access without buffering, I've made changes to the master branch. Could you please give it a try and provide some feedback?
let mut display_driver = Gc9a01::new(
        interface,
        DisplayResolution240x240,
        DisplayRotation::Rotate180,
    );

I added graphics feature too.
Here is an example with lvgl without BufferedGraphics a.k.a BasicMode.
let buffer = DrawBuffer::<{ 12 * 240_usize }>::default();
let display = Display::register(buffer, 240, 240, |refresh| {
    display_driver
        .fill_contiguous(
            &Rectangle::new(
                Point::new(refresh.area.x1.into(), refresh.area.y1.into()),
                Size::new(
                    (refresh.area.x2 - refresh.area.x1) as u32 + 1,
                    (refresh.area.y2 - refresh.area.y1) as u32 + 1,
                ),
            ),
            refresh
                .as_pixels::<Rgb565>()
                .into_iter()
                .map(|color| color.1),
        )
        .unwrap();
})
.unwrap();

@IniterWorker  Works like a charm!