Replace fft module with easyfft

This significantly simplifies the project. This should reduce bugs and make maintenance easier. It would've been better if we could use the const sized variants of the easyfft crate, but those currently require the unstable generc_const_expr feature and is only available on nightly.
I think it's worth it to check for performance regression before you merge though. I'm not familiar enough with the crate to be sure I test it correctly. easyfft should in theory be on par with rustfft and realfft but the way this project is structured may have forced an extra allocation or two.

So, I am thinking through some ideas to add functionality to easyfft that would eliminate the allocations. All of them seem pretty clunky but perhaps not too bad.
Before we go down that route, let's just figure out if that's the performance bottleneck. I've run cargo bench before and after my changes and get the following report:
nnnoiseless sin/440/1   time:   [4.4528 ms 4.4543 ms 4.4560 ms]
                        change: [-0.3693% -0.1473% +0.0158%] (p = 0.15 > 0.05)
                        No change in performance detected.

I've previously got a slight regression just above the noise level.

I think the following addition to easyfft would be workable:
impl<T: FftNum + Default> DynRealDft<T> {
    /// TODO: Add documentation
    ///
    /// # Panics
    /// Panics if the `original_length` is not equal to `output.len()`.
    pub fn real_ifft_at(&self, output: &mut [T]) {
        assert_eq!(self.original_length, output.len());
        let c2r = get_inverse_real_fft_algorithm::<T>(self.original_length);

        // SAFETY:
        // The error case only happens when the size of the input and output and fft algorithm are
        // not consistent. Since all these are calculated inside this function and have been double
        // checked and tested, we can be sure they won't be inconsistent.
        unsafe {
            c2r.process_with_static_scratch(
                &mut Into::<Box<[Complex<T>]>>::into(self.clone()),
                output,
            );
        }
    }
}

Not sure which wording is most appropriate for this function. real_ifft_at or real_ifft_into or real_ifft_using.
I can implement the same for the real_fft operation too. This would be a bit of a bandaid until generic_const_exprs is stabilised.
Thoughts?

Sure, that sounds like a reasonable API to me. Honestly, I think it would be useful even with generic_const_exprs -- in my experience, reusing buffers is quite common. It's only a little bit less nice to write and read, but you get better memory locality and you don't have to worry about exceeding stack size limits (which is not an issue for nnnoiseless because our ffts are small, but could be an issue elsewhere).

I think it would be useful even with generic_const_exprs -- in my experience, reusing buffers is quite common.

Since there's no explicit allocation and the sizes of the const structs are known, I suspect assignment will be equivalent to a different API which explicitly uses the same buffer. The temporary buffer should be compiled out.

You might be right, but I wouldn't be too sure. See, for example this thread

Got this working on a new version of easyfft:
use alloc_counter::{count_alloc, AllocCounterSystem};
use easyfft::prelude::*;
use std::thread;

#[global_allocator]
static A: AllocCounterSystem = AllocCounterSystem;

fn main() {
    let ((single_fft_allocation_count, _, _), _) = thread::spawn(|| {
        count_alloc(|| {
            let signal = vec![0.0; 100];
            let dft = signal.real_fft();
            let _signal = dft.real_ifft();
        })
    })
    .join()
    .unwrap();

    let ((muliple_fft_allocation_count, _, _), _) = thread::spawn(|| {
        count_alloc(|| {
            let signal = vec![0.0; 100];
            let mut dft = signal.real_fft();
            let mut signal = dft.real_ifft();

            // Extra operations
            signal.real_fft_using(&mut dft);
            dft.real_ifft_using(&mut signal);
        })
    })
    .join()
    .unwrap();
    assert_eq!(single_fft_allocation_count, muliple_fft_allocation_count);
}

Will publish the new version asap. Just wanna make sure there's no other regressions.

Nice! I figured out where the factor of 2 is coming from. You can just leave that part as you had it and I'll fix it in another PR.

I published easyfft-v0.3.3 that contains the buffer re-using api. So this patch-set doesn't introduce any non-initialisation allocations AFAICT. Also seems to improve the performance benchmark by ~6%:
nnnoiseless sin/440/1   time:   [4.3782 ms 4.3832 ms 4.3889 ms]
                        change: [-6.1564% -5.9242% -5.7357%] (p = 0.00 < 0.05)
                        Performance has improved.

Thanks for all the input. These suggestions and real-world issues are really valuable to make a useful library.


nbc-events-nestjs-5-test-ci-pull-request

Testing CI on a basic pull request.

@taylorpapke we didn't talk about this my fault. When reviewing setup we never got to creating the tests. By default nest creates a test for the controller and services. These need updated so they pass.
You can look at my user module controller branch to see how to set it up.
Get it passing locally if you can. Reach out if needed.
I am trying to configure yaml files to use github secrets / env variables to access the variables. Just comment out the e2e test for now until we get this resolved.


[Scenario] Demonios entre los Wilson

Hello everyone!
I just finished creating my first scenario for MoM. For now it's only in Spanish, but I'm working on the translation into English!
Thank you for your time,
F. J.

What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?

[X ] Mansions of Madness
[ ] Descent

Please enter the GitHub Url to your scenario here
https://github.com/FJReina21/Stories/tree/master/DemoniosEntreLosWilson

I have published this, it should be live within the hour


Etcd pre-upgrade attempts to remove etcd-proxy twice

The same task is present twice in pre upgrade of etcd. The second time, the rm -f command fails as the container was just removed.

It's covered in https://github.com/kubernetes-incubator/kargo/pull/798

OK, feel free to merge or just close the PR then.


auto generate gha auth token

🚀 Pull Request
Description
This PR enables automated authenticating with a newly created and installed SciTools owned GitHub App for generating tokens for a GHA to enable other workflow actions.
The GitHub App iris-actions is only installed and enabled for iris.
The context here is to allow the refresh-lockfiles GHA to trigger the CI workflows automatically on the PR generated to update the conda-lock files on the main branch.
Reference: create-pull-request GHA Authenticating with GitHub App generated tokens

Consult Iris pull request check list

Nice clever workaround.
I assume this needs additional infrastructure in the form of the app that provides secrets.AUTH_APP_ID etc? That needs maintainer documentation somewhere, either in the docs, or in a comment in this file would probably be a good place.

I guess I could add something to the dev docs, that if anything point people to the standard GH docs etc on how to do all this.
We didn't have to go off piste from the minimal GH app to make this work, so it's pretty straight forward thankfully.
Also, I tested the same workflow on geovista, which was experiencing the same problem, and it works a treat. See https://github.com/bjlittle/geovista/pull/79 as an example with the CI workflows are successfully run automatically on the GHA generated PR.

@jamesp Supporting owner/developer/admin documentation is available here.

@jamesp Supporting owner/developer/admin documentation is available here, as part of this PR.
On first impression the level of documentation may seem a tad overkill, but I suspect the process of creating a GitHub App is very rare, so it's probably best to capture the detail now before it fades 👍

Blimey, love it... I was only expecting a comment in the GHA file! :D

I'm happy @trexfeathers

@bjlittle given the number of images used in the docs page, would you consider popping them all into their own sub-directory?

@trexfeathers I'm confused... they are all in their own sub-directory i.e. docs/src/developers_guide/assets... or do you mean something else?

@bjlittle given the number of images used in the docs page, would you consider popping them all into their own sub-directory?

@trexfeathers I'm confused... they are all in their own sub-directory i.e. docs/src/developers_guide/assets... or do you mean something else?

A sub-directory specifically for this page, since I personally find it difficult to work with documentation when there is a large mass of image assets that could belong to one of several pages.
docs/src/developers_guide/assets/github_app or similar.

Jeez, I hadn't realised it was already a bit of a mess ☹ I don't like either of the apparent choices:

Confusing
OR
Over-complicated

I'm just going to merge it


[question] non linux based border router

I am trying to find out whether it is feasible to develop a thread compatible border router which is not based on a linux system. Reason is to save hw costs. We are evaluation the thread technology for a series of products in the smart home area. We don't consider a raspberry pi solution to be a stable product.
Currently it seems that there are hardly an thread compatible border routers available on the market. I wonder what the reason for this is.

Does anyone know of any available border router devices on the market?
Would it be possible to implement a border router without linux? Basically with a TI-1352 chipset and host controller with eth interface.

Yes, it is possible to implement a Thread Border Router in a non-Linux environment. The Nest Connect is one example of a shipping product that employs OpenThread to implement a FreeRTOS-based Thread Border Router. That said, the Nest Connect does not currently support Thread Commissioning, which makes it difficult to use outside the Nest ecosystem.
You may want to look at the openthread/ot-rtos project, that provides an integration of OpenThread, FreeRTOS, and LwIP. While the project does not currently implement a Thread/Wi-Fi border router, it should provide a good starting point.
Hope that helps.

Closing stale issue.


Selected field available as helper for custom resolvers

When writing custom resolvers we cannot benefit from features that are available inside our own

Isn't this in the context?

@wtrocki @craicoverflow Current,  to write custom resolvers that relies on the CrudService and data providers you'll need to do something like this
https://github.com/aerogear/graphback/blob/master/packages/graphback-codegen-schema/src/SchemaCRUDPlugin.ts#L474-480
we have this done for all resolvers we provide but writing custom ones can become out of hand if you have to do that all the time. What we are missing is the ability to query all fields if the context has no options.
I'll look at this tomorrow.

I'll look at this tomorrow.

Let's avoid jumping towards quick solutions. This issue is actually very big problem that might need some research first.

I'll look at this tomorrow.

Let's avoid jumping towards quick solutions. This issue is actually very big problem that might need some research first.

Sure.

Spiked last evening idea of having helper method on service instead. context.User.withInfo(info).create(..)
This way we avoid problems with override etc.
Just idea

Hmm.. actually this could be tricky to do as it will require cloning service. I guess having method in context would be enough?

Hmm.. actually this could be tricky to do as it will require cloning service.

When you say "cloning the service" do you mean returning an instance of CrudService in withInfo?
If so, what is wrong with that?
public withInfo(): CRUDService {
  this.selectedFields = ['*']

  return this;
}

Or do you mean creating a builder class?

It means returning completely new object of service.
If someone executes 2 queries that hit the same service we will override selectedFields on service itself. We hit this problem in OVP

It is technically impossible to use getSelectedFieldsFromResolverInfo in a custom resolver because this function requires ModelDefinition as a parameter.
Even if ModelDefinition were available in resolvers, there is too much boilerplate for a user to have to write to add the selected fields to the context.
Suggestion: Let's not add selectedFields to the context, just pass the info object to the CRUDService and let the service extract this information.
There is too much manual modification of the context. We have the contextCreator specifically to not let the user control graphback context, yet here they have to do modify it.
export const noteResolvers = {
  Query: {
    findDraftNotes: async (_: any, args: any, context: GraphbackContext, info: GraphQLResolveInfo) => {
      const selectedFields = getSelectedFieldsFromResolverInfo(info, model); // <= cannot use this helper, do not have model.

      const graphback = {
        services: context.graphback.services,
        options: { selectedFields }
      };

     const results = await graphback.services.Note.findBy({ title: { contains: '[DRAFT]' } }, context, info, args.page, args.orderBy)

      return results.items;
  }
} as IResolvers

export const noteResolvers = {
  Query: {
    findDraftNotes: async (_: any, args: any, context: GraphbackContext, info: GraphQLResolveInfo) => {
      const results = await context.graphback.services.Note.findBy({ title: { contains: '[DRAFT]' } }, context, info, args.page, args.orderBy)

      return results.items;
    }
  }
} as IResolvers

It is technically impossible to use getSelectedFieldsFromResolverInfo in a custom resolver because this function requires ModelDefinition as a parameter.
Even if ModelDefinition were available in resolvers, there is too much boilerplate for a user to have to write to add the selected fields to the context.
Suggestion: Let's not add selectedFields to the context, just pass the info object to the CRUDService and let the service extract this information.
There is too much manual modification of the context. We have the contextCreator specifically to not let the user control graphback context, yet here they have to do modify it.
export const noteResolvers = {
  Query: {
    findDraftNotes: async (_: any, args: any, context: GraphbackContext, info: GraphQLResolveInfo) => {
      const selectedFields = getSelectedFieldsFromResolverInfo(info, model); // <= cannot use this helper, do not have model.

      const graphback = {
        services: context.graphback.services,
        options: { selectedFields }
      };

     const results = await graphback.services.Note.findBy({ title: { contains: '[DRAFT]' } }, context, info, args.page, args.orderBy)

      return results.items;
  }
} as IResolvers

Simplified version if we pass info to the CRUDService and get it to do gather selected fields info.
export const noteResolvers = {
  Query: {
    findDraftNotes: async (_: any, args: any, context: GraphbackContext, info: GraphQLResolveInfo) => {
      const results = await context.graphback.services.Note.findBy({ title: { contains: '[DRAFT]' } }, context, info, args.page, args.orderBy)

      return results.items;
    }
  }
} as IResolvers

Very nice followup. Thanks for the update.

Suggestion: Let's not add selectedFields to the context, just pass the info object to the CRUDService and let the service extract this information.

The only thing that I do not like about passing the info object into service (which should be pure business logic) is that it will feel like its invading the service layer while its something that ought to stay in the resolver (think of it as routing) layer.
Instead of passing the whole resolver info object, maybe we can just pass selected fields in a dedicated argument (that would increase the number of arguments so not that much elegant). Having said that, I am seeing the .findBy(query: GraphbackQuery) taking one argument an options GraphbackQuery object that contains:

filter
aggregations e.g count
page
orderBy
selectedFields

With this.

The service layer would do its logic on this, and pass it down under to the data provider later if need.
Context won't be passed around different layers (not needed)
Context no longer modified saving us a few cpu cycles
GraphbackQuery  object could be easily extendable and the .findBy() stays intact agains future evolutions

Slightly unrelated to what's said above and I might be going off topic. Forgive me for asking, I'd like to know what use case are we targeting with this?

The only thing that I do not like about passing the info object into service (which should be pure business logic) is that it will feel like its invading the service layer while its something that ought to stay in the resolver (think of it as routing) layer.

Very good point there. I was thinking it would be okay to pass to the CRUD Layer to extract the selected fields, so long as the Database layer is kept clean.

Instead of passing the whole resolver info object, maybe we can just pass selected fields in a dedicated argument (that would increase the number of arguments so not that much elegant)

That would be a good middle ground. However, when https://github.com/aerogear/graphback/pull/1730/files gets merged, getSelectedFieldsFromResolverInfo will require ModelDefinition as an argument, which is not available in the the resolvers.

Instead of passing the whole resolver info object, maybe we can just pass selected fields in a dedicated argument (that would increase the number of arguments so not that much elegant).

Yep, anything outside of the context is an improvement :+1: I was looking at the context in the different layers and it is not really required for anything.
const results = await context.graphback.services.Note.findBy(filter, {
  aggregations,
  page: args.page,
  selectedFields: getSelectedFieldsFromResolverInfo(info)
})

Slightly unrelated to what's said above and I might be going off topic. Forgive me for asking, I'd like to know what use case are we targeting with this?

I was looking at https://github.com/aerogear/graphback/issues/1627 and because it is quite difficult for a user to create their own resolvers with Graphback CRUD services, I am looking for ways to improve this.

I was looking at #1627 and because it is quite difficult for a user to create their own resolvers with Graphback CRUD services, I am looking for ways to improve this.

Awesome!
My prefference to have everything in the service - this will allow us to not care but it will mean that every service call will need info object (which is actually very simple comparing to
API proposed above and requiring some separate helpers.

Putting everything into the service presents its own challenge..lots of arguments and easy to break the API in the future. We do require some form of wrapper type to contain dynamic props but I do not believe that context is the solution.
The primary reason we have a CRUD service layer and do not use the resolvers directly is because it is extendable. I really believe the method signature should align more closely to the resolver function.
+ public findBy(args?: FindByArgs<T>, context?: GraphbackContext, info?: GraphQLResolveInfo): Promise<ResultList<T>>;
- public findBy(filter: QueryFilter<T>, context?: GraphbackContext, info?: GraphQLResolveInfo, page?: GraphbackPage, orderBy?: GraphbackOrderBy): Promise<ResultList<T>>;

interface FindByArgs<T = any>> {
  filter?: QueryFilter<T>
  page?: GraphbackPage
  orderBy?: GraphbackOrderBy
}

thoughts?

Putting everything into the service presents its own challenge..lots of arguments and easy to break the API in the future. We do require some form of wrapper type to contain dynamic props but I do not believe that context is the solution.
The primary reason we have a CRUD service layer and do not use the resolvers directly is because it is extendable. I really believe the method signature should align more closely to the resolver function.
+ public findBy(args?: FindByArgs<T>, context?: GraphbackContext, info?: GraphQLResolveInfo): Promise<ResultList<T>>;
- public findBy(filter: QueryFilter<T>, context?: GraphbackContext, info?: GraphQLResolveInfo, page?: GraphbackPage, orderBy?: GraphbackOrderBy): Promise<ResultList<T>>;

interface FindByArgs<T = any>> {
  filter?: QueryFilter<T>
  page?: GraphbackPage
  orderBy?: GraphbackOrderBy
}

thoughts?

I like the idea. So +1.


curl flux api to redeploy on bundle unavailable on monitoring server

this can be done with the fluxDeploy script
node ./dev/scripts/dist/scripts/fluxDeploy.js ProcaptchaJavascriptServer

This was due to dodgy netlify architecture which is no longer used.


add symphony generator logo to landscape

Build failed because of:
No cached entry, and https://github.com/finos/symphony-wdk-gallery has issues with stats fetching: Request failed with status code 404
No cached entry, and https://github.com/finos/ElectronSpellchecker has issues with stats fetching: Request failed with status code 404
No cached entry, and https://github.com/finos/symphony-wdk-gallery has issues with start date fetching:, Request failed with status code 404
No cached entry, and https://github.com/finos/ElectronSpellchecker has issues with start date fetching:, Request failed with status code 404
Duplicate item: FINOS Currency Reference Data at path Data & Business Logic / Tick & Reference
Duplicate item: FINOS Currency Reference Data at path Legend / Modeling Initiatives

Build failed because of:
No cached entry, and https://github.com/finos/symphony-wdk-gallery has issues with stats fetching: Request failed with status code 404
No cached entry, and https://github.com/finos/symphony-wdk-gallery has issues with start date fetching:, Request failed with status code 404
Duplicate item: FINOS Currency Reference Data at path Data & Business Logic / Tick & Reference
Duplicate item: FINOS Currency Reference Data at path Legend / Modeling Initiatives


Fix don't swallow the error when building zap logger

What changed?
Fix don't swallow the error when building zap logger

Why?
Currently, start the cadence server would be panic when
failed to build the zap logger. It will cause confusion since
the error was swallowed.

How did you test it?
test local with no permission log dir

Potential risks
no

Pull Request Test Coverage Report for Build 537eaa3f-9134-49e3-9908-2d2a65e4bc2f

2 of 15 (13.33%)  changed or added relevant lines in 5 files are covered.
23 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.009%) to 67.98%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bench/lib/context.go
0
1
0.0%

tools/cli/domainUtils.go
0
2
0.0%

canary/runner.go
0
4
0.0%

cmd/server/cadence/server.go
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

host/archivalTest.go
1
97.81%

tools/cli/domainUtils.go
1
1.79%

common/persistence/historyStore.go
2
66.41%

common/task/weightedRoundRobinTaskScheduler.go
2
89.12%

common/types/mapper/thrift/shared.go
2
72.02%

common/task/fifoTaskScheduler.go
3
84.54%

service/history/queue/timer_queue_processor_base.go
5
78.6%

service/history/queue/processor_base.go
7
61.82%

Totals

Change from base Build b5b4de3f-e897-4629-a30c-130a72d78cad:
-0.009%

Covered Lines:
98661

Relevant Lines:
145132

💛  - Coveralls

Huh.  Why don't we have this passed in?  Constructing a logger seems doomed to be over-complicated (as we expose more and more logger-configuration fields) and less flexible (zap loggers can do effectively anything, there's no reason for us to limit them).
Accepting a logger would also simplify the log, _ := config.NewZapLogger() case in tests: pass in a zaptest.NewLogger(t) instead of constructing one and trying to work around the test environment.

Huh. Why don't we have this passed in? Constructing a logger seems doomed to be over-complicated (as we expose more and more logger-configuration fields) and less flexible (zap loggers can do effectively anything, there's no reason for us to limit them).
Accepting a logger would also simplify the log, _ := config.NewZapLogger() case in tests: pass in a zaptest.NewLogger(t) instead of constructing one and trying to work around the test environment.

Which one are you referring to? I think we have to do this way because they are in from different main() : server, bench, canary and CLI. So we can't pass a logger from server to cli code, hehe.
Or in other words, we already try the best to pass around/initiate only once.

@Groxx I merged this PR but if you see a way that we can improve by passing around logger, we make do a refactoring


Move to a plugin/command url scheme

This changes the format of url requests from
curl -v -H "Content-Type: application/json" -X POST -d '{"cmd": "lint", "params":{"file":{"file":"/home/moritz/code/haskell/playground/src/Main.hs"}}}' http://localhost:8001/req/ghcmod

to
curl -v -H "Content-Type: application/json" -X POST -d '{"file":{"file":"/home/moritz/code/haskell/playground/src/Main.hs"}}' http://localhost:8001/req/ghcmod/lint

Imho this is a more intuitive. The double file parameter comes from the fact that the first is the parameter name and the second is the type so that’s nothing specific to the servant protocol.

Looks like a good idea

We need to come up with whatever scheme works best with swagger2, for documentation and tooling

My understanding is that swagger is a standardized way to specify your api but doesn’t require it to be in a specific way, however I’m happy to be corrected here.
Also swagger or at least servant-swagger doesn’t seem particularly useful for the way our servant api currently looks since it only contains one route and doesn’t know about the plugins or the commands that exists so anything that tries to generate documentation from the servant type can’t document plugins and commands. Again I’m happy to be corrected here.
For the json stdio I’m currently writing a documentation generator that outputs rst, but I’m happy to later merge that with the swagger docs if they turn out to be useful or to merge our http docs into that.


perf(prune): Only analyze when rebuilding

When pruning by delete, it's overzealous to analyze. When combined with auto-prune on large tables, I've seen shards struggle with one long analyze after the other.
It can also conflict with the lock for autovacuum and result in a long running transaction waiting for the lock.

@lutter thanks for reviewing, I've tried another approach on the latest commit, given I've learned about the very convenient analyze skip_locked.

@lutter thanks for reviewing, I've tried another approach on the latest commit, given I've learned about the very convenient analyze skip_locked. This is a Postgres 12 feature, do we document our minimum Postgres? Postgres 11 has hit end-of-life already anyways.

I don't think we have a minimum version documented, but not worrying about EOL versions seems reasonable to me.


There's no way to refresh new files/directory

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T13:56:35.908Z)
OS Version: Darwin x64 16.5.0
Extensions:

Extension
Author
Version

beautify
HookyQR
1.0.1

vscode-docker
PeterJausovec
0.0.13

sort-lines
Tyriar
1.2.0

code-gnu-global
austin
0.2.1

vscode-standard-format
chenxsan
0.0.12

vscode-standardjs
chenxsan
1.1.0

scala
daltonjorge
0.0.4

vscode-eslint
dbaeumer
1.2.7

githistory
donjayamanne
0.2.0

python
donjayamanne
0.5.5

vscode-semistandard-format
homerjam
0.0.9

cpptools
ms-vscode
0.10.5

debugger-for-chrome
msjsdiag
2.5.2

Spell
seanmcbreen
0.9.1

python
tht13
0.2.3

markdown-authoring
yanz
0.1.5

TabSpacer
yuichinukiyama
1.0.2

Steps to Reproduce:

Open your terminal
Create a new directory or a file
VScode wont show it

There is actually a refresh button in my VSCode (version 1.9.1) in the EXPLORER panel. The button is next to the name of the folder and only shows when the mouse pointer is hovering inside the EXPLORER panel. Clicking the refresh button shows newly created files for me.

Same version (Code 1.10.2, validation 8076a19) on Windows 7 and no problem noticed : As qizhuli mentionned there's a refresh button for forcing the refresh and even without clicking it new files/folders are automatically added.

Or maybe settings? Can you share yours? There is a files.exclude setting that can have an impact.

Thanks I'll check it out (on vacation)


I think transactable SaaS offers can be purchased through MSA accounts as well right?

I think transactable SaaS offers can be purchased through MSA accounts as well right?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2f95e63d-2814-d226-7a9f-3719616eb682
Version Independent ID: 1ad4ff3b-e271-8ba6-5764-b1422e7392a9
Content: Monetize your Microsoft 365 add-in or app through Microsoft Commercial Marketplace
Content Source: articles/marketplace/monetize-addins-through-microsoft-commercial-marketplace.md
Service: marketplace
Sub-service: partnercenter-marketplace-publisher
GitHub Login: @mingshen-ms
Microsoft Alias: siraghav

@santhoshb-msft
Thanks for your feedback! We will investigate and update as appropriate.

@mingshen-ms To review the query and comment on it.

Hi @santhoshb-msft , thanks for the feedback. I will spin up a thread about this question and get the docs updated accordingly. #please-close


Error editing or deleting product groups

On the /dashboard/store/products/groups page, if I tried to click the edit or trash button on any of the groups I got a javascript error such as:
Error: Syntax error, unrecognized expression: li['data-group-id=1']
Fixed by editing lines 79, 80, 83 and 84 of js/vividStoreFunctions.js in the edit and cancel functions:
Changed these:
FROM:
$("li['data-group-id="+groupID+"']")
TO:
$("li[data-group-id='"+groupID+"']")
ALSO I then hit an additional error with line 48 of that file:
var confirmDelete = confirm(vividStore.Strings.AreYouSure);
ReferenceError: vividStore is not defined
I have hardcoded that confirmation message on mine for now - perhaps you can fix.

The second error is odd that it had that issue. The first is an easy fix. Though if you submit a pull request that would be easier ;)


ContextErrorException in FieldTypeBase.php line 59

After update, I start receiving this error:
ContextErrorException in FieldTypeBase.php line 59:
Notice: Undefined index: loadScript

in FieldTypeBase.php line 59
at ErrorHandler->handleError('8', 'Undefined index: loadScript', '/home/pagekit/public_html/packages/bixie/pk-framework/src/FieldType/FieldTypeBase.php', '59', array('scripts' => object(AssetManager))) in FieldTypeBase.php line 59
at FieldTypeBase->registerScripts(object(AssetManager)) in index.php line 44
at FrameworkModule->{closure}(object(Event), object(AssetManager))
at call_user_func_array(object(Closure), array(object(Event), object(AssetManager))) in EventDispatcher.php line 123
at EventDispatcher->trigger('view.scripts', array(object(AssetManager))) in PrefixEventDispatcher.php line 72
at PrefixEventDispatcher->trigger('scripts', array(object(AssetManager))) in View.php line 189
at View->trigger('scripts', array(object(AssetManager))) in ScriptHelper.php line 31
at ScriptHelper->Pagekit\View\Helper{closure}(object(ViewEvent), object(View))
at call_user_func_array(object(Closure), array(object(ViewEvent), object(View))) in EventDispatcher.php line 123
at EventDispatcher->trigger(object(ViewEvent), array(object(View))) in PrefixEventDispatcher.php line 72
at PrefixEventDispatcher->trigger(object(ViewEvent), array(object(View))) in View.php line 189
at View->trigger(object(ViewEvent), array(object(View))) in DeferredHelper.php line 57
at DeferredHelper->Pagekit\View\Helper{closure}(object(KernelEvent), object(Request), object(Response))
at call_user_func_array(object(Closure), array(object(KernelEvent), object(Request), object(Response))) in EventDispatcher.php line 123
at EventDispatcher->trigger(object(KernelEvent), array(object(Request), object(Response))) in HttpKernel.php line 175
at HttpKernel->handleResponse(object(Response)) in HttpKernel.php line 80
at HttpKernel->handle(object(Request)) in Application.php line 67
at Application->run() in app.php line 24
at require_once('/home/pagekit/public_html/app/system/app.php') in index.php line 40

The problem are coming from this part of the script, probably I need to contact Bixie team.
public function registerScripts ($scripts) {
if ($this->type['loadScript']) {
$script = $this->type['resource'] . '/fieldtype-' . $this->id . '.js';
$scripts->register('fieldtype-' . $this->id, $script,
array_merge(['~bixie-fieldtypes'], $this->type['dependancies']));
return [];
} else {
return $this->type['dependancies'];
}
}
Technical Details

Pagekit version: 1.0.11
Webserver: Apache/2.2.3
Database: 5.1.58
PHP Version: 5.5.38

Solved 👍


Remove DNX branding from footer

#722 I also did a quick search for other occurrences of the word dnx. Still need to investigate the use of https://github.com/aspnet/Hosting/blob/12fff1833fdcaa36b6d43bbdeb0465a11d9cf365/src/Microsoft.AspNetCore.Server.Testing/Deployers/IISExpressDeployer.cs#L88-L95.
The new error footer looks like:

Review: @Tratcher
Approval: @Eilon @DamianEdwards

The version is wrong but it's the "rightest" thing we can do right now 😄
:shipit: !

Shouldn't be ".NET Framework CoreCLR", that's combining two things that shouldn't be. It's either ".NET Framework version 4.*" or ".NET Core version .".
Also, the "x64 Runtime version <IP_ADDRESS>" is confusing. What is that referring to exactly? We don't have DNX anymore so I don't think it's even needed. Move the bitness string into the first string and remove that section completely.
For the OS string, please include the bitness there too, as it may be different to the runtime bitness.

@DamianEdwards Just want to clarify a few things here.

".NET Framework" and ".NET Core" makes sense but what about Mono? Since we differentiate it in PlatformAbstractions, we originally had ".NET Framework Mono" but maybe we can drop the "Mono" part of it.
The runtime version is what we get from PlatformAbstractions. There it uses the version of the assembly containing the type object as the "Runtime" version. I'm guessing this is what was meant by it's wrong but it's the rightest thing for now.
I don't think hosting is the right place to figure out the OS bitness. PlatformAbstractions feels like the more logical place to have this logic. There is a work item to update to using CoreFX's RuntimeInformation which will have this information but that's for RTM. Unless we are going to pull that back to rc2, I'll look into some other options.

Let's just fix the first one for RC2 then. Happy to keep "Mono" where applicable, so ".NET Framework", ".NET Core", and ".NET Framework (Mono)"?

@DamianEdwards I also removed the runtime section as well and moved the bitness string to the clr type section. The updated footer looks like

Do you like this better?

I think that's fine, only part that's a little weird is ".NET Framework x64 version 4.0....".  @DamianEdwards thoughts?

:up::date: as per offline discussion with @DamianEdwards
The updated footer looks like:

Will create a followup issue to convert the full CLR version to something more reasonable like 4.5.1, 4.6...


Icons get extra padding on bottom within a div

I added an icon to my whisper and the span doesn't have any padding, but the div that contains the span does. This prevents me from being able to vertically align an icon and text to the center.
For example, see the code and output below:
export const MyComponentTestingAlignment = (props) => {
  return (
    <oh-box
      justifyContent={JustifyContent.Left}
      direction={Direction.Horizontal}
      alignItems={AlignItems.Center}
      layout={{ padding: StyleSize.None, margin: StyleSize.None }}
    >
      <oh-icon
        color={Color.WhisperStrip}
        name={'fiber_new'}
        size={IconSize.Large}
      />
      <oh-markdown body={`testing`} />
    </oh-box>
  );
};

Is this something that can be fixed? Thanks!

still backlogged @kyuhas

This bugfix has been released! Closing the thread out.


invoke() ignore before/after links

Q
A

Issue Type
Bug

Deployer Version
v6.0.3

Local Machine OS
Ubuntu 17.10

Remote Machine OS
Debian 9

Description
invoke()  executes only the given task, ignoring before/after links. I have not checked failure/success tasks.
Steps to reproduce
Link task 'frontend:generate' to be executed before task 'deploy:assets:install' using before().
Define task 'build' to invoke() task 'deploy:assets:install'.
Run task 'build'.
'frontend:generate' is not executed.
Content of deploy.php
task('frontend:vendors', 'yarn install --pure-lockfile');

task('frontend:generate', 'yarn run encore production');
before('frontend:generate', 'frontend:vendors');

task('deploy:assets:install', '{{bin/composer}} install-assets --no-interaction');
after('deploy:assets:install', 'frontend:generate');

task('build', function () {
    set('deploy_path', __DIR__ . '/.build');
    set('composer_options', '{{composer_action}} --verbose --prefer-dist --no-progress --no-interaction --no-dev --optimize-autoloader --ignore-platform-reqs');

    invoke('deploy:prepare');
    invoke('deploy:release');
    invoke('deploy:update_code');
    invoke('deploy:vendors');
    invoke('deploy:assets:install');
    invoke('deploy:clear_paths');
    invoke('deploy:symlink');
    invoke('cleanup');
})->local();

Output log
$ vendor/bin/dep -v build test
➤ Executing task build
➤ Executing task deploy:prepare
✔ Ok [7ms]
➤ Executing task deploy:release
✔ Ok [35ms]
➤ Executing task deploy:update_code
✔ Ok [4s 568ms]
➤ Executing task deploy:vendors
✔ Ok [2s 87ms]
➤ Executing task deploy:assets:install
✔ Ok [601ms]
➤ Executing task deploy:clear_paths
✔ Ok [17ms]
➤ Executing task deploy:symlink
✔ Ok [26ms]
➤ Executing task cleanup
✔ Ok [2ms]
✔ Ok [2ms]

Please note, this implementation of invoke() does the job:

/**
 * Run task
 *
 * @experimental
 * @param string $task
 */
function invoke($task)
{
    $hosts = [Context::get()->getHost()];
    $tasks = Deployer::get()->scriptManager->getTasks($task, $hosts);
    $executor = Deployer::get()->seriesExecutor;

    $executor->run($tasks, $hosts);
}

But I am sure about neither the way I get $hosts nor if using seriesExecutor by default is a good thing.

So, What do you suggest?

To review and test it. I just tweaked it by mimicking the TaskCommand, but I do not know the project well enough to know its implications and side-effects. If it seems fine to you, I can make a PR.

A PR will be okay, as this feature still @experimental we can tweek it.

It is actually fixed in the master branch. I overlooked the PR #1364. It was for another issue but it also solves this one. I am sorry for wasting your time.


wasi: provide thread-safe implementations of WASI contexts

With the presence of shared memories and, eventually, with wasi-threads providing a way to spawn multiple Wasm threads, access to the WASI state will no longer be single-threaded. This state (e.g., WasiCtx for wasi-common) must be appropriately protected from concurrent access, e.g., by locking as @haraldh has attempted here.
What complicates this issue is that I expect that not all users of Wasmtime will want to pay the performance penalty for locking access to WASI. This means that we may need two implementations for each WASI state object, ideally factored so that all the meaningful bits are kept in one place. Also, there may be some complications when wiring up either the single-threaded or thread-safe implementations of each WASI context during linking; presumably the thread-safe version should be used when the threads feature is enabled, but it is unclear if all of the Host types will be agreeable with this.

One improvement that I think would be good to have is to have a method on GuestPtr<'_, str> to go to:
enum GuestCowStr<'a> {
    Borrowed(GuestStr<'a>),
    Owned(String),
 }

impl Deref for GuestString<'_> {
    type Target = str;
    // ...
}

And that way all bindings in all places could create this GuestCowStr<'a> and it would work with shared and unshared memories. For unshared memories this will retain borrows and for shared memories it's required to copy bytes out no matter what and this helps encapsulate that.
Lists are harder, however, and I believe will require case-by-case handling.

The last time we talked about this, there were two "roadblocks" to starting to work on this issue:

Benchmarking: adding RwLocks (e.g.) to various fields of the WASI context structures could add some locking overhead for each WASI call. @alexcrichton hypothesized that this overhead would be minimal compared to the overhead already imposed by Wiggle. We decided to benchmark a locking implementation of wasi-common in order to decide if we can apply locking unconditionally or if we have to (undesirably) maintain two implementations of each WASI context. Now that #5274 and #5309 are merged, we can actually measure this: use cargo bench wasi/ to run these new benchmarks first with the current HEAD and subsequently with a locking implementation.
Async: wasi-common is designed to support both asynchronous and synchronous calls; we decided when we met that we shouldn't allow async and wasi-threads to mix. In my mind, this involved some (perhaps major) refactoring to wasi-common; @haraldh had some questions along this lines IIRC. We had discussed a separate issue to discuss how the design of this refactoring to wasi-common might look, but now I think it could be discussed here, as a part of this issue. I would summarize this as: "wasi-threads and async cannot be enabled at the same time." This has ramifications for what is allowed in the embedding API (e.g., should an async call fail with an error when the threads feature is enabled?).

I think this is done now, right @abrown?

It's done for wasi-common but I haven't yet propagated it to wasi-nn and wasi-crypto. Should I create separate issues for those and close this one?

Ah good point! Nah keeping this is fine.


Create pull_request_template.md

Proposed changes
Added pull request template
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[x] DevOps related

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the project guidelines doc
[x] I locally linted my code
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Unable to find this in my .github folder. Also does not pass linting checks

https://github.com/Visual-Testing-for-Android-Apps/web/tree/develop/.github,
Also changed to draft, because I need to #11 merged first


Fix rendering of  in DNS names

The rendering of <ASE name>.appserviceenvironment.net and text using other placeholders that start with < and end with > characters is broken in the article "Create and use an Internal Load Balancer App Service Environment"..
The problem is due to the <ASE name> token getting interpreted by markdown as a custom HTML tag and therewith the text between the < and > characters doesn't show up (refer to screenshot below which highlights the problem areas in red underlines).
To display the text correctly, the < and > characters must be HTML-escaped (see for example how the "Use an App Service Environment" articles handles this). As such, this pull request fixes the rendering by replacing < with < and > with >.

@c-w : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good/verified.


feat: implement persisted language selection; deps for writing tests

This implements #28. I use window.sessionStorage to persist the selected language (ISO code) as well as React's state to trigger a client-side refresh when the user selects and clears the option.

Not super happy with the "clear selection" button's appearance. Keep in mind that #14 has to land for the language to be applied - so not sure if we want to stage this for now until that's implemented. I'm open to any suggestions, big or small on any of this!
Also

Added first .test.js file, __snapshots__ and necessary Jest deps
Added selected-item class to scope the white color for the country
Added PR template
Fixed console warnings in RecentLinkItem

Todo

[x] Tests
[x] Clean up

Hey Phil and Mike! Requested you as reviewers as I'm not sure who the best folks to reach out to are. Happy to elaborate on any of this!

Thanks for taking a swing at this!
Sorry for any confusion, but this is only meant to be a country selector. Everyone is still stuck seeing english, it's just going to display content for Brazil or Australia or Bolivia, it's all about restricting to content relevant to you. A basic filter, which is persisted.
Localiztion is out of scope, as #14 will give people language. If somebody else wants to view the site in French when they live in Mongolia that should be fine.
Do you think you could tweak that to make it clear?

Do you think you could tweak that to make it clear?

For sure! So is the intent to fold the functionality from the "Filter site for your country" bit into a single dropdown?
Also good timing I think - guessing the site's undergoing some maintenance but getting a "website is pending domain owner verification" on https://protect.earth/.

Right, the goal was to make the "Filter site for your country" work properly.

persist the country of choice
display the country of choice
make sure it showed things from your country and things which had no country, because a website available anywhere is a good thing to show to somebody wherever they are

Does that make sense?
The hosted URL is https://actions.protect.earth whilst we switch the main page over to Squarespace, which is surprisingly slow at making SSL certificates. 😓

Took another stab at this @philsturgeon! Happy to make any desired changes.

Getting a chance to revisit this @philsturgeon - apologies for the delays!
Following the contrib guidelines, do you mind sharing env variables for the new Airtable setup?

Sorry or the delays here too! Agh.
This project is finally getting its new home, merged with climatechoice over here https://github.com/impactmakers/climatechoice/pull/161
The airtable source and directory approach is simply being moved over there, so this will still need to be done, just once the dust has settled of that PR. Could you subscribe to the PR and when its done try and help with a country selector?

Btw I'll try and get the read-only version of the API up so people dont need EVN vars soon.


JS serialize binary error "Unknown base64 encoding at char: @"

Create simple proto file:
syntax = "proto3";

message Test {
  bytes test_bytes_field = 1;
}

Generate code using buf:
# buf.gen.yaml
version: v1
plugins:
  - name: grpc-web
    out: ./src/grpc
    opt: import_style=commonjs+dts,mode=grpcwebtext
  - name: js
    out: ./src/grpc
    opt: import_style=commonjs,binary

Try setting a non base64 char (e.g. @) to test_bytes_field and use serializeBinary method on generated jspb.Message:
try {
  const test = new Test();
  test.setTestBytesField('@');
  test.serializeBinary();
} catch (e) {
  console.error({ e });
}

Results in an error  "Unknown base64 encoding at char: @"

This is working as intended: a string argument is intended to be used for base64 strings. Unfortunately, there's nothing in the setter API to signal as much, so the error only pops up during serialization:
https://github.com/protocolbuffers/protobuf-javascript/blob/566f35982a0a04718855f650e4496c2add001988/binary/utils.js#L1093-L1120
Depending on your use case, you may just want to use a Uint8Array instead.


Updating tiered caching settings

Description
We need to add new settings in tiered caching which were introduced in 2.18. We also corrected few setting name which was wrongly named in older versions.
I will raise a separate PR to fix wrong setting names for older versions 2.14 and above.
Issues Resolved
Closes https://github.com/opensearch-project/documentation-website/issues/8351
Version
2.18
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kolchfa-aws @Naarcha-AWS Can you take a look at this one?
Also I need to correct setting names in the documentation for older versions ie 2.14 upto 2.17. I can separate PR for that, would that work?


Pathways to use python3 and work using the legacy 2018 handbook

In the path to getting pathways working again, I have updated it to work with python3 and use the legacy 2018 handbook found here.
I removed the cgi bash script in the hopes of being able to get it hosted elsewhere and not have to deal with cgi ever again.
There is a lot more that could be done here but to just have it working I think this is a good milestone to leave it at temporarily :)
Below is a screenshot of it working

Nice!
Since I haven't actively worked on Pathways for years though, I think it's probably easier if you make this and future changes to the CSESoc fork. I can update the README here with a link to it.

Ah whoops, guess I cloned this one instead of the fork; my bad! I'll close this and move the work to the fork :)


Removing FadeInFromDown and FadeOutAndShiftDown

In my opinion they are completly useless since when FadeInFromand FadeOutAndShift are called direction = DOWN is set by default.
(And FadeInFrom(mobject, direction = DOWN) , FadeOutAndShift(mobject, direction = DOWN) are equivalent)
EDIT : I mixed up FadeIn and FadeInFrom. I'm talking about the latter; FadeIn is fine

Paging @XorUnison, what do you think about this in terms of convenience?

From a user's perspective, it is strange to have specific functions for fading from one direction, but not from others. Even though I am too small a sample to be representative, I would prefer a generic function with the direction given as a parameter and a reasonable default.

I mean, there's also the factor that manim used to have this whole convoluted process of mixing animations.
Now we can just do:
self.play(mobject.rotate,np.pi,
          mobject.shift,DOWN)

And call it a day.
That's because manim can now mash and mix all properly coded methods of mobjects such as shift and rotate. Works with custom stuff too.
So what we should do is probably nuke those archaic methods, and instead add mobject.fade_out and mobject.fade_in. Then we can just go the much better way of:
self.play(mobject.fade_out,np.pi,
          mobject.shift,DOWN)

And any other combination we may want.

(And FadeIn(mobject, direction = DOWN) , FadeOutAndShift(mobject, direction = DOWN) are equivalent)

This... however doesn't seem to be the case on my end? FadeIn is FadeIn for me, direction passed or not. I see no way for FadeIn to digest a direction into anything meaningful either.

Now we can just do:
Hol' up, have we fixed the multiple animations on one mobject issue already? On which PR?

Which issue exactly? I see no such open issue and this is currently possible in vanilla manim, and I've not been able to find any issues with it either. What's the problem?

Oh... I was thinking of the "bug" that doesn't let you do
self.play(Rotating(mobj), FadeIn(mobj))

(for e.g.)

Right, this has been a thing for a good long while, and I'm not even sure what the issue is, nor if it can and should be fixed.
But as I said, the syntax I highlighted above does now work. But as far as I know it requires mobject.methods to work with.

So it seems that there's agreement on removing FadeInFromDown and FadeOutAndShiftDown and other similar methods.
Now, do we want to just nuke them or deprecate them (ie issue a DeprecationWarning for now and delete them later)?

I prefer the latter. It is always frustrating when stuff disappears without prior notice. If nobody else is currently on it, I might be able to prepare a PR to solve this issue.

@huguesdevimeux, or anyone else, are there any volunteers to write a PR that deprecates FadeInFromDown, FadeOutAndShiftDown, and other similar methods?

@PhilippImhof Feel free to submit a PR :)

@PhilippImhof Feel free to submit a PR :)

Haha, j'allais dire la même chose.... 😊 I'll have a look at it, but I 'm not sure whether I got all of it right.

but I 'm not sure whether I got all of it right.

That's what code reviews are for! Looking forward to your PR.


stop processing if updated_deps is empty

As part of the work inside Azure DevOps to improve dependabot (see #8179) there were other updates that needed to be split out into their own PR, specifically not continuing with an update if the updated set was empty.

I have adjusted the change per your suggestion, added a test for this scenario, and updated the branch. The PR should be ready for re-review.


[1.11]<PHONE_NUMBER> does not fit in an int on 32 bit systems

Currently cri-o will not build on 32 bit systems.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

@rhatdan @runcom port to 1.11

/test all

LGTM
/test all


Master -> Main Rename

Part of https://github.com/Islandora/documentation/issues/1595

Should be good to go now @manez @rosiel @whikloj


[#646] Move submission input label, value, required, hint, value-pairs to angular i18n

References

Addresses #646
Requires DSpace/DSpace#8322

Description
All form components used by submission in dspace-angular are piped through 'translate'. This PR aims to shift localisation of submission input definitions over to dspace-angular en.json5 to take advantage of this localisation.
This means administrators will not need to maintain separate submission_form_xx.xml forms which are cumbersome to maintain, and keeps i18n labels, hints, required messages in the frontend application with other form localisation.
This PR is a work in progress. There are some comments in the JSON5 file as this is allowed by the spec, but after an initial review we can change the formatting if that is necessary.

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.

I've pushed an update to dynamic-scrollable-dropdown template so that the formatted listEnty is piped to translate, which means the Types, Languages and other value pairs can also be i18n'd.
I didn't do this for the value (ie. stored value for value-pairs) though that might be worth it?
I'm pretty sure this won't cause any unexpected translation as the keys used are really long and specific like submission.section.describe.value-pairs.common_iso_languages.english
If anyone thinks this could be a problem and if there are other dynamic controls that might need this for working with Controlled Vocabs and Value Pairs please let me know!

hi @kshepherd thanks for proposing that, I agree that keep (manually) in sync several submission_forms_xx.xml file is cumbersome but the main advantage of these xml files over the i18n is that when the admin make change/add new form these are almost immediately available to the user without the need to rebuild the application. Moreover, it would force other REST client to implement their own i18n for configuration managed by the REST part.
If we want to move these translation to angular IMHO we will need to first define a way to reload the i18n file at runtime on the angular side without the need to rebuild/package the application until then we should at least offer the values provided by the REST side as fallback if no specific i18n key is defined.
An alternative approach could be to modify the structure of the xml file to accommodate all the translation in a single file, this would require a lot of work on the REST side

This is a good point, I hadn't considering how inaccessible the json5 i18n files are, comparatively. A full rebuild to change a label seems excessive. (This problem applies to all other i18n text, of course, and I think will be a pain for admins)
My reasoning behind moving the translation to Angular is that all the other labels served by the Web UI are handled there. That said, perhaps it's a more simple, maintainable fix here to do some translation at REST before sending the submission data to Angular.

@abollini and @kshepherd :  another option would be to move these keys to the Messages.properties file on the backend. That file still exists...it's much smaller though as most translations occur in the UI.  But, we still do have the need for some backend messages, and that's where they are generally stored: https://github.com/DSpace/DSpace/blob/main/dspace-api/src/main/resources/Messages.properties
(That said, I'm not sure that solves the issue of making these labels easily editable, as that file is embedded in dspace-api.jar by default)

@tdonohue yep, that's what I was meaning about "translation in REST", use I18nUtil to translate those backend messages before sending submission definition / form data to angular... that seems pretty simple, right? I think that'd still be an improvement over having a different form for each language.

I think that having part of the description of a submission field in the back-end and another part in the front-end is cumbersome.  But abstracting the descriptions to message catalog keys within the back-end makes a lot of sense.
Each part of the system should be able to talk about what it knows, and trust the other parts to do the same.  I dislike the idea that multiple front-ends will have to have their own, probably duplicate, explanations of what the back-end wants the user to put into a submission field.  That is:  the back-end should hold the logical design of a form (with labels) and a front-end should render that and provide the behavior.
Putting the labels for form fields into the front-end requires the front-end to know too much about the details of the back-end, since the back-end is in charge of which fields are in the form.  It's too tightly coupled.

Just a reminder that this PR is not 100% complete from memory, there may still be some keys missing.
Also, given the feedback, I'm not sure that there is much point to a review of the changes.
The related PR in the DSpace backend might still be useful for future work that translates in the backend, instead: https://github.com/DSpace/DSpace/pull/8322

@kshepherd : I had only left this PR open as I wasn't sure if a final decision had been made.  That said, since it sounds like most of us (who've looked at this PR) lean towards a solution which is all in the REST API, I'll close this PR.  So, let's move this discussion over to the backend PR https://github.com/DSpace/DSpace/pull/8322 (and @kshepherd , let us know when you feel that's ready for reviewers to provide more feedback on)


Add complementary method to match OpenIdConnectConfiguration Create(string json).

Add a method that generates the JSON.

It would be natural to remove the IDictionary methods. Have a look at #61


Update substrait requirement from 0.12.0 to 0.13.0

Which issue does this PR close?

Closes #7437.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

cc @alamb

Thank you @yjshen


Add API which allows resolving clusters from a given command criterion

/api/v3/commands/{id}/clusterCiteria/{priority}/clusters will execute the criterion resolution against the clusters in the database to see what would be selected if a job was submitted and evaluated against that criterion

I'm not in favor of indroducing new API that solves a thin sliver of a problem (but that we will have to maintain or worry about breaking going forward).
It seems to me that this exposes something that we can already kinda do via search APIs.
I'm in favor of introducing API if it solves the whole problem.
In my head, solving this entire problem means

Take (job) command criteria and (job) cluster criteria
Expose all steps and intermediate matching result

This is so that when something is not working, we can take a job, run it through this API and have a full debug trace.

Coverage decreased (-0.009%) to 92.853% when pulling 561f7439bc5b7eb75c74920ae03a09567a40bca9 on tgianos:GENIE-374 into b9581ee7064c5372f33b9345feef7b6c9c12712b on Netflix:master.

@mprimi I believe you're discussing a different problem than this is targeted at. Your vision for helping to debug execution details is valid and useful but this specific PR is intended for helping administrators more so than end users.
The admins of our deployment asked for the ability to tell which clusters a command can run on and which commands a cluster can use during our meeting last week. I circled back with those admins and asked specifically about this PR and they re-iterated that this seems to solve what they're asking for as they work on the migration from old to new resource resolution mechanisms. Yes, this can partially be addressed with the search API but it is not abstracted in the same manner and isn't as specifically targeted to recreate the environment the clusters are resolved in as this API is.
It builds on existing APIs in the service tier developed for this brand new cluster/command resolution feature so maintenance going forward shouldn't be an issue as it is where we're heading in the near term.

After discussion on design I'm going to revise this a little bit and open a new PR.


please update the changelog in master as part of the 2.x release process

v2.10.1 is missing in the master branch changelog.
Please consider making sure the default branch is the same as the last released major? You could make 2.x the default until you're ready to release v3, perhaps.

also v2.11.0 now :-(

It seems we just need to stop releasing 2.x

Certainly deciding to not be fearful since releases are cheap, and just releasing 3.x and fixing bugs as they come, is a totally valid option :-)

Not all tests are passing in 3.0 at the moment

master branches where all tests aren't passing make me sad

"unstable master approach" is popular in some workflows or at the transition periods, this is the latter


Remove hack where terminal layout is performed twice after it becomes visible

A hack was added for https://github.com/Microsoft/vscode/issues/54230#issuecomment-406127177, it needs https://github.com/xtermjs/xterm.js/issues/702#issuecomment-403133603 to be implemented before we can fix this.

https://github.com/microsoft/vscode/commit/7b4576411523cb4d4c21205d0965e194e174bd00


cli usage

[ ] better output https://github.com/fuse-box/fuse-box/issues/356
[ ] config running
[ ] config creating
[ ] doc & help
[ ] skeleton creation

lots of community members expressed that we shall keep fuse simple with no CLI, so I think we will close this :)


Remove unnecessary branch in minimum forward.

This PR removes an unnecessary branch in chainer.functions.minimum forward computation, which might cause slight cost but  it would be enough to ignore.

Thanks for the followup! LGTM, I will merge after test pass.

LGTM!


fix: add support for pyproject.toml and env.yml/env.yaml files

Tested this manually by adding these files to the repo and conifrming they are picked up. This supports both versions: env.yml and env.yaml

Original issue: https://github.com/pyupio/safety/issues/505

Summary by CodeRabbit

New Features

Enhanced scanning commands with improved functionality and error handling.
Introduced a summary feature for vulnerabilities in scan reports.
Added support for reading dependencies from pyproject.toml files.
Expanded file handling capabilities to include special files like pyproject.toml and environment files.

Improvements

Real-time feedback added during dependency scanning for better visibility.
Detailed output control adjusted for relevant information display based on vulnerabilities.
Streamlined report processing for various output formats, including JSON and SPDX.
Refined command structure for better parameter handling.

Bug Fixes

Improved clarity in error reporting during upload failures.
Corrected logic and indentation issues in file handling processes.

Please note that this PR in the safety_schemas repo is needed for this to work: https://github.com/pyupio/safety_schemas/pull/1

After changes in our approach, the code changes we need are much simpler and it is easier to just open them in a new PR here: https://github.com/pyupio/safety/pull/621


Ignore fields?

I was just curious if there was a way to ignore fields in our models? I would like to add some properties to my model that I don't want to be decoded or mapped to json values.
Is this possible?

@MikeHuntington This is definitely possible! Those other values will probably need to have defaults though. You can provide those defaults in the decoding steps like <*> .Success(default_value) or write a custom initializer that ignores those values. If you have an example we can help you work through it.

Hi! I went with the custom initializer method and that worked great! Thank you for the help!


Don't pollute the global namespace

Hi @gregjhogan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@gregjhogan, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@gregjhogan Thank you!


Highlight the currently active tab

The unTab window shows results for all the currently open tabs in the browser windows. It would be great if it could show the currently active tab in a certain way.
I would propose the following two ways, although the developer must feel free to incorporate the feature as per his own liking.

Use a different color to highlight the currently active tab
Use an asterisk before the tab icon to represent the tab is currently active.

Good idea, it'll be an easy addition I think.
I'd prefer option 2 but with a better UI indicator. Choosing different color would create confusion between what's selected and what's active.

Good idea, it'll be an easy addition I think.
I'd prefer option 2 but with a better UI indicator. Choosing different color would create confusion between what's selected and what's active.

I tried implementing this using browser.tabs.query({ active: true, currentWindow: true }) in tabs.js
Due to the behaviour in chrome (CTRL+SHIFT+SPACE opens a new UnTab tab), the newly opened tab is matched with query, as opposed to the actual current tab (where the shortcut was pressed on), rendering the query quite useless in tabs.js.
Any ideas for an alternative implementation? Perhaps the query needs to be ran outside tabs.js and then the query output imported to tabs.js?
I also though it would be an easy addition :/

@brendan-c Interesting case. There was an active discussion going on in #70 to remove the active tab from results as it didn't make sense to show it(as user wouldn't want to switch to current tab itself). I'm still not sure if it improves the experience or makes it worse 😅(What do you say @tanishqvyas?)
So if the above changes go through, this issue will become irrelevant.
If we don't go ahead with the changes, then I think querying for current tab is still OK. UnTab only opens in a new tab when it can't open in the current tab which happens in only certain tabs in normal use(not always at least from my experience). The result in this case will obviously not make sense as active tab changed. I'm not sure how we can prevent this and also not increase complexity, maybe open UnTab in a browser popup instead of new tab? (I don't know if this is considered as a tab also). Stuff to think about!

The active tab is no longer shown in tabs-switching results. Hence, this issue is no longer relevant


Scale: autoSkip before fit

Resolves: #3694
As @benmccann suggested in https://github.com/chartjs/Chart.js/issues/3694#issuecomment-570875337, the fit was already split in two quite a long time ago (the _length is adjusted in configure). So this was quite and easy fix today.
Edit: the _length is also still adjusted in fit, I'll do additional testing.
Seems to work nicely now

calculated maxTicksLimit was decimal, rounding that down probably fixes some other bugs too
made sure the margins are enough for the additional tick when offset is false.

Filename
Size
Change

dist/chart.esm.js
66.7 kB
+98 B (0%)

dist/chart.js
84.4 kB
+84 B (0%)

dist/chart.min.js
60.2 kB
+62 B (0%)

LGTM! This was a lot smaller of a diff than i expected


Kubernetes Components - please define/explain "user containers"

There's one single mention of "user containers" under https://kubernetes.io/docs/concepts/overview/components/#control-plane-components
This concept is not explained as a component nor otherwise.
Would it be possible to explain the concept as it's confusing for newbies like me. (Especially since it's the 2nd page in explaining what Kubernetes is)
Is a "user container" a "node" or a "kubelet" or something else?

I'd replace the text:

Control plane components can be run on any machine in the cluster. However, for simplicity, set up scripts typically start all control plane components on the same machine, and do not run user containers on this machine. See Building High-Availability Clusters for an example multi-master-VM setup.

with:
People who manage large clusters typically isolate the control plane
onto dedicated computers; that isolation offers a defined level of
performance, improves reliability, and also helps with information security.

For small clusters, you can run the control plane components on the
nodes. If your workload containers and control plane components are
sharing the same resources, this can sometimes cause issues.

[Creating Highly Available clusters with kubeadm](/docs/setup/production-environment/tools/kubeadm/high-availability/)
explains one way to set up a replicated control plane that runs
separate from the nodes.

However, as this is now more text, maybe it makes sense to move that detail into the page at https://kubernetes.io/docs/concepts/architecture/ (which is currently just a list of topics). Thoughts welcome.

/triage accepted
/language en
/kind cleanup

/priority backlog


Use LESS_COMPRESSOR variable in the Makefile

We look for and set LESS_COMPRESSOR in the Makefile but don't use it.
I've got a ruby less version that is higher in my loadpath than the javascript version so it was trying to use that and failing.  This lets me set LESS_COMPRESSOR and then have be used.

I'm apparently a noob and don't know how pull requests work entirely.  Didn't mean to include that new commit in this.  Will try again.


View client log

Where i can find client log? Thanks

On your client

And it is possible find client log on server where is openvpn server is running?

    If you're actually this new at computers you can have a basic definition of some primary school computer terms are. Here explaining basic English behind Server and Client


Missing embedded screenshot 'Deploy-Azure-Monitor-1.png'

After the first few lines in this doc there is some text showing "" where it should show the screenshot. Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c813d7c-1789-d0c9-c833-cbdd3f60e2b8
Version Independent ID: e5b7e6a7-2f78-dd58-b450-0d173935e26c
Content: Deploy Microsoft Teams Rooms management with Azure Monitor - Microsoft Teams
Content Source: Teams/room-systems/azure-monitor-deploy.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@neilmallon Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@neilmallon  Thank you for raising this issue! I'll be looking into it!

Merged the PR. Thanks @TokyoScarab and @neilmallon.

@neilmallon Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


gltf.parse assumes 4-byte aligned little endian data

Ran into this because I used @embedFile to embed my glb model. Unfortunately, according to https://github.com/ziglang/zig/issues/4680 it's currently not possible to specify alignment for @embedFile.
I know it's simpler to just assume these preconditions (and it's probably faster to cast to u32 pointers). But it would be nice to at least have an assertion for alignment and endianness to help with the error search.
~The safer/correct but also slower way would be to treat the data as a byte stream and use something like this:~
var reader = std.io.fixedBufferStream(data).reader();
const my_int = reader.readInt(u32, .little);

Edit: nvm, saw in the glTF spec that 4-byte alignment is a requirement. So at least an assertion would be nice.

Thanks, I will see what I can do on this; I'll let you know.

Hey, thanks for considering this. And thanks for the great library. It's awesome!
I added align(4) to relevant places here:  #10
Now type-checking will complain when you want to pass unaligned data to gltf.parse. What do you think?
I don't know if it's worth it to handle big endian. I think it's a pretty rare these days. I'm targeting wasm, btw.

Merged; thanks a lot! :)


Misc docs fixes

Specified impossibility to capture item's references into futures (https://github.com/rust-lang/futures-rs/pull/2044#discussion_r369249321)
Corrected order of split to (Sink, Stream) in docs
Other fixes

Thanks!


chore(doc): mention custom domain setting in dashboard

Update doc to mention setting in the dashboard for custom domain and this is a paid plan feature https://pockethost.io/docs/usage/custom-domain/

Much appreciated!


i am trying to use uvr5 for the first time and this happens , while a i have an rtx 3060ti , is there anyway to fix it ?

Last Error Received:
Process: Ensemble Mode
The application was unable to allocate enough GPU memory to use this model. Please close any GPU intensive applications and try again.
If the error persists, your GPU might not be supported.
Raw Error Details:
OutOfMemoryError: "CUDA out of memory. Tried to allocate 1.25 GiB (GPU 0; 8.00 GiB total capacity; 4.94 GiB already allocated; 0 bytes free; 6.46 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF"
Traceback Error: "
File "UVR.py", line 4716, in process_start
File "separate.py", line 672, in seperate
File "separate.py", line 803, in inference_vr
File "separate.py", line 770, in _execute
File "lib_v5\vr_network\nets.py", line 161, in predict_mask
File "lib_v5\vr_network\nets.py", line 137, in forward
File "lib_v5\vr_network\nets.py", line 30, in call
File "lib_v5\vr_network\layers.py", line 59, in call
File "lib_v5\vr_network\layers.py", line 24, in call
File "torch\nn\modules\module.py", line 1194, in _call_impl
File "torch\nn\modules\container.py", line 204, in forward
File "torch\nn\modules\module.py", line 1194, in _call_impl
File "torch\nn\modules\batchnorm.py", line 171, in forward
File "torch\nn\functional.py", line 2450, in batch_norm
"
Error Time Stamp [2023-08-23 20:23:03]
Full Application Settings:
vr_model: 7_HP2-UVR
aggression_setting: 15
window_size: 1024
batch_size: 4
crop_size: 256
is_tta: False
is_output_image: False
is_post_process: False
is_high_end_process: False
post_process_threshold: 0.2
vr_voc_inst_secondary_model: No Model Selected
vr_other_secondary_model: No Model Selected
vr_bass_secondary_model: No Model Selected
vr_drums_secondary_model: No Model Selected
vr_is_secondary_model_activate: False
vr_voc_inst_secondary_model_scale: 0.9
vr_other_secondary_model_scale: 0.7
vr_bass_secondary_model_scale: 0.5
vr_drums_secondary_model_scale: 0.5
demucs_model: Choose Model
segment: Default
overlap: 0.25
shifts: 2
chunks_demucs: Auto
margin_demucs: 44100
is_chunk_demucs: False
is_chunk_mdxnet: False
is_primary_stem_only_Demucs: False
is_secondary_stem_only_Demucs: False
is_split_mode: True
is_demucs_combine_stems: True
demucs_voc_inst_secondary_model: No Model Selected
demucs_other_secondary_model: No Model Selected
demucs_bass_secondary_model: No Model Selected
demucs_drums_secondary_model: No Model Selected
demucs_is_secondary_model_activate: False
demucs_voc_inst_secondary_model_scale: 0.9
demucs_other_secondary_model_scale: 0.7
demucs_bass_secondary_model_scale: 0.5
demucs_drums_secondary_model_scale: 0.5
demucs_pre_proc_model: No Model Selected
is_demucs_pre_proc_model_activate: False
is_demucs_pre_proc_model_inst_mix: False
mdx_net_model: Choose Model
chunks: Auto
margin: 44100
compensate: Auto
is_denoise: False
is_invert_spec: False
is_mixer_mode: False
mdx_batch_size: Default
mdx_voc_inst_secondary_model: No Model Selected
mdx_other_secondary_model: No Model Selected
mdx_bass_secondary_model: No Model Selected
mdx_drums_secondary_model: No Model Selected
mdx_is_secondary_model_activate: False
mdx_voc_inst_secondary_model_scale: 0.9
mdx_other_secondary_model_scale: 0.7
mdx_bass_secondary_model_scale: 0.5
mdx_drums_secondary_model_scale: 0.5
is_save_all_outputs_ensemble: True
is_append_ensemble_name: False
chosen_audio_tool: Manual Ensemble
choose_algorithm: Min Spec
time_stretch_rate: 2.0
pitch_rate: 2.0
is_gpu_conversion: True
is_primary_stem_only: False
is_secondary_stem_only: False
is_testing_audio: False
is_add_model_name: False
is_accept_any_input: False
is_task_complete: False
is_normalization: False
is_create_model_folder: False
mp3_bit_set: 320k
save_format: WAV
wav_type_set: PCM_16
help_hints_var: False
model_sample_mode: False
model_sample_mode_duration: 30
demucs_stems: All Stems

i fixed it right now , by opening the program from the exe extension and not the launcher

bro downloaded more vram lmao


Settings Sync: No way to specify individual platform-specific settings

This was previously brought up in #88625; but the discussion was left a little bit narrow.
That discussion decided that #23251 would sufficiently satisfy the need for Settings Sync to allow specific settings to be left un-synced to specific platforms; but I think this feature would be widely useful outside of which-extensions-are-installed. Various features that almost necessitate platform-specific values for individual settings:

Filesystem paths to installed binaries, for formatting programs and other tooling
Fonts, sizes, window-locations, and the like, for which different values will be available on different platforms (I use this myself, with the deprecated Settings Sync extension)

I'm opening this because the original Issue is bot-locked, and I figure this could use a little more discussion; even if it ends up being out-of-scope.

/duplicate
https://github.com/microsoft/vscode/issues/5595


Add bartavelle's packages

base-<IP_ADDRESS> is out of bounds for:

[ ] hruby-0.3.4 (>=4.6 && < 4.9). Simon Marechal<EMAIL_ADDRESS>@bartavelle. @bartavelle

Wait what ? https://hackage.haskell.org/package/hruby-0.3.4

@bartavelle It's the test-suite

Is there a magic way to retrigger travis or do I have to create a bogus change in the PR ?

I restarted it.
There are a couple tricks that let the submitter retrigger the travis build. The simplest is to close and reopen the PR.


Refactoring leaves files dirty when auto save is on

Steps to Reproduce:

run out of sources and leave auto save on (after 1s)
use a refactoring to extract a class into a new file
notice how editors appear dirty

I find this weird, when auto save is enabled I would expect that editors save automatically, but maybe I am missing something?

I think that's nothing the refactoring should decide

I think that's nothing the refactoring should decide

My mistake, I had auto save delay to 30 seconds...

My mistake, I had auto save delay to 30 seconds...


add neo4j:console task to start Neo4j server in foreground

It can be useful to start Neo4j server in the foreground, for example when developing using a foreman Procfile.
This pull request add a neo4j:console task that starts the server in the foreground.

Yes, excellent, thank you!  I actually had to use neo4j console recently to get Neo4j working with upstart.
Released neo4j-rake_tasks 0.2.0 and updated neo4j-core to use it with version 5.1.5


Inquiry about frame dim, 16 for inference and 14 for training?

Hi,
I found the frame dimension you are using is confusing.
For inference.py, you use 16.
For training period, you use 14.
May I ask which one is better? I assume larger means better?

During training, the 2 is for motion frames, thus it's total 14+2=16 frames too


Fedora 28 - Error during installation of pbis-open 8.6.0

Hi.
I have enabled yum repo as indicated here:
https://repo.pbis.beyondtrust.com/yum.html
Then I have tried to install pbis-open with commands indicated:
sudo yum clean all
sudo yum install pbis-open
but I obtain the following error:
Problem: conflicting requests

nothing provides sh-utils needed by pbis-open-8.6.0-427.x86_64

I have found that "sh-utils" is part of "coreutils" package:
yum search sh-utils
Last metadata expiration check: 0:16:33 ago on Mon 07 May 2018 10:09:34 AM CEST.
============================ Description Matched: sh-utils =============================
coreutils.x86_64 : A set of basic GNU tools commonly used in shell scripts
that is yet installed.
How can I solve this issue?
Thank you

I found by doing a search in your repository that maybe it would be enough to update the ini files you use to compile rpm packages.
In Fedora, but also in CentOS, sh-utils are in coreutils package.
This cause an installation error.
Thank you

Another note (maybe useful for you): sh-utils is the Debian nomenclature of the package. So I think that a simple change of ini files must solve the issue.
Regards

I'll have a look. Hopeful that's all it is with no impact elsewhere

Thank you for your answer.
Il giorno lun 7 mag 2018 alle 14:47 rbest-bt<EMAIL_ADDRESS>ha
scritto:

I'll have a look. Hopeful that's all it is with no impact elsewhere
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BeyondTrust/pbis-open/issues/128#issuecomment-387053608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AORLAPjqWUN4Sb7Sk5-zBbPJPETrlE5lks5twEJ2gaJpZM4T0l7N
.

Looks like it is already fixed in master 5517ac69cb90a39a3e38d2709a5194c3f0d11bda. When can we expect a updated package in fedora/centos?

It seems, 5517ac6 already fixes this issue; when can we expect an updated release?
Thanks!

Great, thanks for the update!

Just uploaded the 8.6.1-beta.1 which includes this change.

Thanks for releasing a beta!
I updated to the beta version and did a release upgrade to Fedora 28. After rebooting, GNOME login manager does not show domain accounts anymore and also manually specifying my domain user does not work.
Do you have a clue what could have went wrong here?
I will try to provide logs or further information tomorrow.
Thanks very much!

lwsmd needs libnsl so it seems the package for Fedora 28 has to depend to the libnsl package. Now everything works like a charm. Thank you very much!

@nning How did you manage to resolve this issue? I've been having the same problem with the latest version of Fedora. Thanks!

@rbest-bt I still receive the error:
domainjoin-cli: error while loading shared libraries: libnsl.so.1: cannot open shared object file: No such file or directory

@GlennSmeulders  This is what I have done to update to Fedora 28 including the new pbis-open version
dnf install libnsl --releasever=28 # Missing dep for pbis-open 8.6.1 dnf install nss-pem-1.0.3-9.fc28 --releasever=28 # Known bug wget https://github.com/BeyondTrust/pbis-open/releases/download/8.6.1-beta.1/pbis-open-<IP_ADDRESS>5.linux.x86_64.rpm.sh sh pbis-open-<IP_ADDRESS>5.linux.x86_64.rpm.sh rm -f /etc/yum.repos.d/pbiso.repo dnf upgrade --refresh dnf system-upgrade download --releasever=28 dnf remove orca # Improve performance in Gnome dnf system-upgrade reboot

sh-utils fixed with 5517ac69cb90a39a3e38d2709a5194c3f0d11bda which is in 8.7.0
We are working on libnsl and ncurses for the next release

ncurses was replaced in 8.7.1 with

113326 - libedit replaced with linenoise

Thank you
Il giorno lun 19 nov 2018 alle 21:34 rbest-bt<EMAIL_ADDRESS>ha
scritto:

ncurses was replaced in 8.7.1 with

113326 - libedit replaced with linenoise

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BeyondTrust/pbis-open/issues/128#issuecomment-440032739,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AORLAJAS8xbONkTCO5PxH68m7Yfe3ZJkks5uwxXxgaJpZM4T0l7N
.


25 RC returned from certain projects when trying to add feature to liberty fails install

classpath 'net.wasdev.wlp.gradle.plugins:liberty-gradle-plugin:2.6.3'
Version
liberty {
    install {
        runtimeUrl = "http://repo1.maven.org/maven2/com/ibm/websphere/appserver/runtime/wlp-webProfile7/<IP_ADDRESS>/wlp-webProfile7-<IP_ADDRESS>.zip"
    }
    // Install all requested liberty features
    server {
        configFile = file('src/main/liberty/config/server.xml')
        features {
            name = ['servlet-4.0']
            acceptLicense = true
        }
    }
    packageLiberty {
        archive = packageFile
        include = packagingType
    }
}

* What went wrong:
Execution failed for task ':installFeature'.
> CWWKM2002E: Failed to invoke [/Users/scottsd/Documents/GitHub/analytics-service-api/com.ibm.internal.rest.meta/build/wlp/bin/installUtility, install, --acceptLicense, servlet-4.0]. RC= 25 but expected=[0, 22].

* Try:
Run with --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':installFeature'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
        at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
        at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
        at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
        at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
        at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
        at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
        at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
        at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

Can you provide the build.gradle file and the referenced server.xml file? Since you are specifying a server.xml file, I would not expect the need to specify the servlet-4.0 feature in the build.gradle file.

@scottdickerson Since this is nearly a year old, I presume you got past your issue and this can be closed?

Yes thanks


ZEVA - Credit balance incorrect on Summary page of model year reports

Description:
https://zeroemissionvehicles.gov.bc.ca/compliance/reports/88/summary
In the summary page of a suppliers model year report, in the credit activity section, the line:
Balance at end of September 30, [xxxx]
All the credits, of all model years, that the supplier held on that date, showing do displayed. As they are on the compliance obligation page of the report (Line: Balance at end of September 30, [xxxx])
In some instances only credits of one model year are being displayed here. Examples include:
https://zeroemissionvehicles.gov.bc.ca/compliance/reports/88/summary (Tesla MY2021)
https://zeroemissionvehicles.gov.bc.ca/compliance/reports/132/summary (Hond My2021)
Acceptance Criteria:
Given I am a supplier who is signing off their model year report
When I am reviewing and checking off the summary page
Then it should contain the same complete credit Balance at end of September 30, [xxxx] information as the compliance obligation page of the report.
Development Checklist:
Notes:

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @emi-hi @tim738745 @vibhiquartech


Use letsencrypt staging certificates

I tried using the letsencrypt-staging target instead of the letsencrypt-prod, but then Keycloak appeared to complain about invalid redirect uri's.
I didn't have a lot of time to research, but I'm guessing there's some extra configuration needed to allow keycloak to use staging certificates?
I set it back to use the letsencrypt-prod and that works fine.
I created this issue as a reminder to research as we have time.

The keycloak profile includes scripts that demonstrate how to use Let's Encrypt staging certificates.
It also provides examples on how to configure Identity JVM to recognize the Let's Encrypt staging CA's inside a custom truststore. This way, the Identity app is allowed to connect over tls to an external Keycloak configured with a Let's Encrypt staging tls certificate.


Exposes a log level option to the command line interface

Currently ps-http-sim logs are flooding our CI logs which makes it difficult to find real errors we should pay attention to. These changes expose a log-level option so the amount of outputted logs can be set the desired level.

Ah, definitely an oversight on my part. We typically expose this through PS_LOG_LEVEL environment variable, but I didn't do that here.
Would you mind changing this to simply use log.ParseLevel instead? https://github.com/planetscale/log/blob/main/logger.go#L63-L76
If not, I can do that in a little bit here. Thanks!

No worries @mattrobenolt! Thanks for letting me know about the ParseLevel method. This PR's been updated to use it.

Great, thank you! I'll get a release tagged here too.

v0.0.10 was pushed.

Thanks @mattrobenolt ! 🙏


Dynamically rendering Index components from arrays results in incorrect teardown on unmount

Hello. My name's Ike 🙂
Context
I'm trying to build a UI that allows users to preview multiple facets of an index simultaneously.
My mental model for it is a folder structure, where 4 results from each folder are displayed, and nesting into a folder will show 4 results from each subfolder.
The way I've tried doing this is with a separate <Index> and <Configure> pair for each folder. The folder structure is dynamic, so I've tried rendering them using inline array mapping:
const Folder = (props: {name: string}) => (
  <Index indexName="my_index">
    <Configure facetFilters={[`tags:${props.name}`]} hitsPerPage={4} />
    <Hits />
  </Index>
)

['A', 'B'].map(folderName => <Folder key={name} name={folderName} />

Problem
When I update the array, the original folders' widgets aren't disposed correctly, and an erroneous POST is sent, requesting results for both the old folders and the new ones. Then a second POST is sent, for the correct data.
I discovered this doesn't happen when I hardcode the folders, but given that data is dynamic, hardcoding isn't really an option.
Video demo:
https://github.com/user-attachments/assets/934f288f-f752-44a8-9829-7fe8c8f0ba57
For discoverabilty, I'll also include the two error messages I get on my local dev environment (though they don't occur in the sandbox)
Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
Configure

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
Hits2

🔍 Steps to reproduce
Render an Index and Configure component by mapping through an array, then update the array so that the Index and Configure component is configured differently. Look at your network requests and see that 2 requests have been sent. One containing the old queries+the new queries, and another just containing the new queries.
Live reproduction
https://codesandbox.io/p/sandbox/react-instantsearch-array-cleanup-example-wjv8j3?file=%2Fsrc%2FApp.tsx
💭 Expected behavior
Updating the array responsible for the rendering of Index components shouldn't result in 2 queries being sent. Only 1 query, for the correct data should be sent.
Package version
algoliasearch 4.23.2, instantsearch.js 4.72.1, react-instantsearch 7.12.2
Operating system
macOs 14.5
Browser
Firefox 130
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I investigated this some more today and it seems to be due to a race condition that occurs between the index.addWidgets and index.dispose calls. It doesn't always happen, but the more <Index> components that are being rendered, the more likely it is.

I've avoided the issue by building my own client using the Algolia REST API instead. Fixing this race condition seemed to rely on some pretty deep react/instantsearch internals and I couldn't imagine being able to solve that as an outsider without introducing other regressions.
Closing the issue 🙂


Not being able to scan on iOS

What

The app goes in permission loop , hence not being able to allow the camera to scan

Steps to reproduce the behavior

Download the app from testflight
Try to open the app
…
See error

Screenshot/Mockup/Before-After
https://user-images.githubusercontent.com/57723319/196029148-7b7d9ef7-0635-473e-b54c-e6d3c8226cb5.MOV
Smartphone model

Device: iPhone Xr
OS: iOS 16
App Version: latest install from test flight

Additional context

I can reproduce that on Android. I had to roll back the app to the stable version on my phone to be able to scan.

So stable is working that's good news but scan broken never

That's strange, I can't reproduce on Android.
Could you provide steps to reproduce?

Trying to scan in safe mode with that version, it will keep trying to refocus

Ok, so there is no link with permissions.
Please open a new issue instead

I want to contribute to this repository and want to get involved in GSoC discussions.

That's great to hear @shivanshu814 though this is probably the wrong place to talk about it 😄
Did you join the mobile-app channel in the openfoodfacts slack

yes i joined

That's great to hear @shivanshu814 though this is probably the wrong place to talk about it 😄
Did you join the mobile-app channel in the openfoodfacts slack

yes i have joined


I cant anymore

Describe your problem here.
I think i broke my entire mod i am currently trying to salvage it if somebody can help please do the mod has broken very badly
https://streamable.com/vlhc9h
every button leads to null obj reference
at this point im screwed im going to upload the source so someone can help me find the errors
i am on the github version found from the <> Code tab
i will update this as soon as it upload to google drive
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
sound changes and 2 custom achievements, 4 custom credits playstate.hx titlestate.hx main.hx Everything inside of source\editors options
odd error
but i can get to the freeplay menu with going into chart editor loading a song and then going to exit but when i reclick the btn  it crashes

somehow fixed


Docs were not supposed to take over specs

This spec still needs to be managed in the constituent project. Do not move it over.
https://github.com/docker/docker.github.io/tree/master/registry/spec
I was assured these would not be moved over. Not sure how this mistake was made.

From what I can see, the docs directory was not removed yet from the distribution tree https://github.com/docker/distribution/tree/master/docs/spec.
PR docker/distribution#1985 deletes some content in the docs directory, but doesn't seem to delete the spec.
If we decide to delete the spec files from docker/docker.gihub.io, we will break links that have ~8000 monthly page views and are currently indexed by search engines.

So, the reference material that is maintained in the projects should get periodically refreshed in docs.github.io, by means of some kind of CI. @johndmulhausen knows about this requirement. The files will live in both places, but will only be maintained in the upstream projects.
I am carrying the PR in the distribution repo so that we can get it done even while John is on vacation. There's no other work to be done on this issue, so I'll close it.

Do we have a manifest of which documents are locally maintained versus which are upstreamed?

That's a great idea. We don't yet, but we will. Let us have a few days to figure out the right location and format for that manifest.


Refactoring trace_state code

Fixes #
Changes

Refactoring trace state changes to reuse some common functionality into baggage.
Extracted key value pair functions from trace_state into common place

For significant contributions please make sure you have completed the following items:

[ ] CHANGELOG.md updated for non-trivial changes
[x] Unit tests have been added
[ ] Changes in public API reviewed

PR merged in upstream. Closing it.