UndoRedo add version changed signal

added some functions to manage undo buttons
EDIT:
extends HBoxContainer

var undo_redo = UndoRedo.new()

var undo = Button.new()
var redo = Button.new()
var save = Button.new()

var do = Button.new()
var label = Label.new()
var saved_state = -1

func _ready():
	OS.set_window_size(Vector2(230, 80))
	undo.set_text("Undo")
	redo.set_text("Redo")
	save.set_text("Save")

	do.set_text("Do")
	label.set_text("0")

	add_child(undo)
	add_child(redo)
	add_child(save)

	add_child(do)
	add_child(label)

	undo_redo.connect("version_changed", self, "update_undo_button_state")

	undo.connect("button_down", undo_redo, "undo")
	redo.connect("button_down", undo_redo, "redo")
	save.connect("button_down", self, "save_state")
	do.connect("button_down", self, "do_changes")
	update_undo_button_state()

func update_undo_button_state():
	undo.set_disabled(!undo_redo.has_undo())
	redo.set_disabled(!undo_redo.has_redo())
	save.set_disabled(saved_state==undo_redo.get_version())

func save_state():
	save.set_disabled(true)
	saved_state = undo_redo.get_version()

func do_changes():
	undo_redo.create_action("do Change")
	undo_redo.add_undo_method(label, "set_text", str(undo_redo.get_version()-1))
	undo_redo.add_do_method(label, "set_text", str(undo_redo.get_version()))
	undo_redo.commit_action()

Alright, seems sensible. Could you rebase and add documentation for the new methods and signal?

Could you rebase and add documentation for the new methods and signal?

Bump.

Any idea why ./bin/godot.x11.tools.64 --doctool . is removing many descriptions?

Any idea why ./bin/godot.x11.tools.64 --doctool . is removing many descriptions?

Did you compile Godot from this branch? It might be that you have a very old Godot build with no support for constant descriptions, which thus removes them.

You are right something was too old, solved it with git clean -fdx.

Thanks!


Feature: Implement Queue using Stacks in Javascript

https://leetcode.com/problems/implement-queue-using-stacks/

Hello, may I contribute to this issue?

Hello, may I contribute to this issue?

Sure, you can picko


database hostname=db hardcoded in klaros image

PostgreSQL/klaros/files/catalina-wrapper.sh contains this line:
echo "hibernate.connection.url = jdbc:postgresql://db/${DATABASE_NAME}"

that db is actually the hostname, which klaros will use to connect to the database. This just happens to work since docker-compose.yml spins a container with that name.
However, its no good if the image is used by some other orchestrator, Kubernetes in my case, and/or when the database is to reside on some generic postgresql server, ie. a database cluster or so.
I suggest adding a DATABASE_HOST environment variable with default value db  to the klaros Dockerfile. Then its possible to specify something else.

This sounds like a useful enhancement. Do you care to submit a pull request for this?

very busy at the moment
can you do it along with some fix going to be released anyway?

Thanks for responding.
We are likewise busy to get version 5.1.0 out the door later this month. I may fit this in with the 5.1.0 Docker release afterwards.

Resolved via #49.


proposal: cmd/compile: clarify whether "-l" and "-N" compiler flags are actually supported

I've seen a number of changes lately where test failures on the linux-amd64-noopt builder are worked around by skipping tests based on the presence of -noopt in the GO_BUILDER_NAME environment variable:
https://cs.opensource.google/search?q="-noopt" case:yes&ss=go%2Fgo
Looking at the git history, it appears that all of these environment-based skips were added within the past year. (As far as I can tell, this is a recent shift, not a long-standing practice.)
Those tests are for packages within std, and thus may be run as part of go test all within a user's module. Users are not expected to set GO_BUILDER_NAME, but may reasonably set any supported compiler flag in the GOFLAGS environment variable. go test all should be a reasonable thing for users to do, and should pass reliably for any supported build configuration.

To me, the existence of the linux-amd64-noopt builder suggests that they are. However, if they are supported, then the tests in std should also pass in that supported configuration when run by users, and today they systematically do not.

I propose that we take one of the following courses of action. I don't have a strong preference as to which one.

Declare that the -l and -N flags are fully supported. Remove the test skips based on GO_BUILDER_NAME containing -noopt, and fix the tests throughout the project so that they pass by default when the -l and/or -N flags are set. (Perhaps convert the tests to benchmarks, and/or skip them when GO_BUILDER_NAME is not set.)

Declare that the -l and -N flags are fully supported, and also define and document a build tag (such as noopt) that users can set (and check for) to explicitly disable tests that assume optimized builds. Switch the tests to use that build constraint instead of GO_BUILDER_NAME. (The noopt build tag would be conceptually similar to the purego tag discussed in #23172.)

Declare that the -l and -N flags are deprecated but remain available for one-off debugging, and document that in the cmd/compile documentation and a release note. Continue to run the builder, and allow builder-based skips going forward.

(CC @FiloSottile, @bradfitz, @josharian, @cuonglm, @cherrymui)

I think the question is what "supported" means. I would say "supported" means "the flag does what is specified in the doc, and will continue to do so". The flag's specified behavior could be printing extra debugging information, altering compiler's behavior, making the compiler slower (or faster), including even generating broken programs. It doesn't mean all generated programs have the same expected behaviors (like, a test is expected to pass).
That said, I think Action 2 above is a reasonable approach.
That also said, https://golang.org/doc/go1compat#tools said tools can change (although it is unlikely that we'll intentionally break it). I don't think we want to declare anything stronger than that (so what "fully supported" actually means?).

Action 1 is a non-starter, as it would prevent us from writing tests that protect the performance characteristics of low level code (like the proximate cause of this bug, whether UDP send/recv allocates).
Action 2 seems perfectly reasonable to me. It's how we deal with a similar problem, namely alloc tests that fail under the race detector. I will note that build tags are annoyingly verbose to use for skipping tests. Related in multiple ways: https://github.com/golang/go/issues/36477.

@cherrymui

I think the question is what "supported" means.

I agree that that's the heart of the question. To me, “supported” means:

The semantics when these flags are set match the Go language spec, and do not cause the behavior of any package in std to deviate from its documentation. (This is in contrast with, say, the -B flag, which intentionally violates the language semantics.)

If a user files a bug (i.e. a violation of the above, in the compiler or in a package in std) that only occurs when one of both of those flags is set, we treat it as a real bug (and not, say, close it as invalid or infeasible).

We do not treat these flags as rendering a binary unsuitable for production use (as we might with, say, certain GOEXPERIMENT settings).

@josharian, course (1) would not prevent us from writing tests that protect performance characteristics. It would only prevent us from running those tests by default as part of the package's test. Other options that would remain available include:

Leaving the test in the package, but skipping it by default. (For example, only running the test when a particular flag is set, and only defaulting that flag to true when GO_BUILDER_NAME is non-empty.)
Moving the test outside of std (for example, into ../misc), but still running it as part of all.bash.
Converting the test to a benchmark, and checking the benchmarks (periodically and during code review) for regressions.

FWIW, I think a flag- or environment-guarded test is likely to be less annoying to write than one guarded by a build constraint, although it's more likely to slip through until the TryBots are run during code review.

@bcmills all those options make running the test difficult or rare. I don't want to have to explain that when developing package net you need to export an envvar to pretend to be a builder or that running the package net tests is insufficient.
And the track record for using benchmarks to prevent regressions is terrible. The way you make it not terrible is with tooling. And we have tooling—it's alloc-per-run.
Running with -N is the unusual case. Let's support it, but let's not have the tail wag the dog.

@josharian

I don't want to have to explain that when developing package net you need to export an envvar to pretend to be a builder or that running the package net tests is insufficient.

That's why I suggest a flag. then you don't need to export a variable to pretend to be a builder; you just pass a flag to go test:
$ go test net -checkallocs

And the failure message in the TryBot and the default skip message can even tell you exactly which flag to set to run it.
I agree that the track record for using benchmarks to prevent regressions is not good, but I also don't think it's unreasonable to expect developers to consider allocations, run the benchmarks, and check for regressions when making a change to performance-sensitive code. A TryBot failure that reminds you to run the benchmarks does not seem at all unreasonable to me.

@bcmills thanks. I would think all (non-default) flags have the same support level, at least in theory. -N and -l are not more supported than -B (again theoretically).
We can still have tests for them to ensure that it does what it should do, namely -N  disables optimization, -l disables inlining (same as -B disables bounds checks), and nothing more than that (e.g. none of them should crash the compiler or generating a binary that doesn't run).
But "deprecated" (in your Action 3) doesn't sound what we want, though. (I interpret "deprecated" as "you should not use it; it may be removed in the future".)

My understanding is that dlv debug will rebuild your binary with -l -N to make it easier to debug.  That would imply that we want them to keep working as documented.
I don't see a problem with the writing tests that only work if the code is optimized, especially when testing the compiler itself, so I think the only question is how tests should detect that fact.  I don't think a build tag is quite right, but it's there and it's easy to use and I can't think of anything else that is simple, so I'm OK with it.

If we use a build tag there is no API change here and this doesn't have to go through the proposal process.  We can just drop a couple of files in internal/testenv and use that in the standard library.  Other packages will have to make their own choices, but other packages are less likely to write tests that are affected by this and are also less likely to actually run their tests with -l -N.

If we use a build tag there is no API change here and this doesn't have to go through the proposal process.

I don't think that addresses the problem: if the build tag is internal to the standard library, then either the test is excluded by default (a situation @josharian wants to avoid), or it fails with -l and/or -N unless the Go user knows to set the build tag (a situation I want to avoid). So it seems that if we use a tag, that tag has to become part of the documented, user-facing surface of the standard library.

I don't see a problem with the writing tests that only work if the code is optimized, especially when testing the compiler itself, so I think the only question is how tests should detect that fact.

These are not tests of the compiler itself — they are tests of packages like net, runtime, and crypto/ed25519.

ObPedantic: they are in effect tests of the compiler, expressed as tests of other packages: they are testing that the compiler is behaving as the package expects.
I'm not suggesting that the build tag is internal to the standard library.  A build tag is a build tag.  I'm suggesting that in internal/testenv we check for the "noopt" build tag and provide a function that the standard library can call to see whether it is running in a non-optimized build.  Then when a builder that uses -l -N can use that build tag.
It seems to me that this completely addresses the problem with the standard library.  It doesn't help at all with people running their own tests outside of the standard library.  I'm suggesting that if those people want to test their code with -l -N, then they can use their own build tag mechanism.  It can be "noopt" or it can be something else.  It really doesn't matter.
The only reason we would need to define an official build tag would be non-test code needs to change.  As far as I know, it does not.

It seems to me that this completely addresses the problem with the standard library. It doesn't help at all with people running their own tests outside of the standard library.

As I stated in the original post, the tests for packages in std may be run by a user as part of go test all, and in module mode we expect go test all to be a reasonable thing for users to do. Using an undocumented build tag does not help those users.
The specific case I am concerned about is:

A user writes a program that uses the net package.
The user observes some problem in their program.
As part of debugging said problem, the user sets GOFLAGS=-gcflags=all=-N, or GOFLAGS=-gcflags=all=-l.
As part of debugging said problem, the user runs go test all within their module, which compiles and runs the tests for all of the packages transitively imported by their module (including net).

In step (4), the user — in the course of diagnosing a problem in their own program — ends up running the tests for packages in std, to verify that those packages are actually working on their platform. If the -l and -N flags are actually supported, those tests should pass just like they do without those flags, and today they will not.
That is: either the user needs to know to do something else in step (3), or the test needs to do something else in step (4), or we need some documentation to explain to the user what they did “wrong” to cause the tests to fail.

Thanks.  I guess that I have a hard time caring very much about that case.
I think that building with -l -N is fully supported.  I don't think that running standard library tests when building with -l -N is fully supported.
I suggest that we use a standard-library-specific build tag and internal/testenv function as I suggested, and we make that internal/testenv function
t.Log("note: test may fail if building with -l and/or -N")

A testenv function sounds good and would let us patch it in BoringCrypto to always skip, to centralize the workarounds for the BoringCrypto-introduced allocations.
/cc @rolandshoemaker

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@ianlancetaylor wrote:

I think that building with -l -N is fully supported. I don't think that running standard library tests when building with -l -N is fully supported.

Is that the answer? Does anyone object to that as the answer?

It sounds like that's the answer.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group


Notification not working

Push Notification breaks on android chrome

Will be fixed soon. Notification on chrome for android now uses the service workers notification class... The present code is however based on the legacy web workers JavaScript Notification() API...

The issue has been fixed in the latest release


Autocomplete from file system strings doesn't complete correctly

Description
Dear @krassowski ,
when trying to autocomplete from a string, i.e. completing a file/directory name from the file system, the result is appended without cleaning up the existing string, leading to a duplication of the content.
So, if I search for /path/to/file/an_imp<tab> to complete the file an_important_file.txt I end up with /path/to/file/an_impan_important_file.txt
For instance:

Reproduce

On a notebook, or editor start typing a path as a string
Click  to autocomplete
Select the wanted autocomplete entry

Expected behavior
The final path should contain a correct path, not just the combination of the original string and the autocomplete one.

Context

JupyterLab version: 3.1.18
Jupyterlab-lsp version: 3.8.1

Required: installed server extensions

Paste the output from running `jupyter server extension list` (JupyterLab >= 3)
or `jupyter serverextension list` (JupyterLab < 3) from the command line here.
You may want to sanitize the paths in the output.

Required: installed lab extensions

Paste the output from running `jupyter labextension list` from the command line here.
You may want to sanitize the paths in the output.

Troubleshoot Output

Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.

Command Line Output

Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.

Browser Output (recommended for all interface issues)

Paste the output from your browser JavaScript console replacing the text in here.
To learn how to open the developer tools in your browser:
https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_are_browser_developer_tools#How_to_open_the_devtools_in_your_browser
If too many messages accumulated after many hours of working in JupyterLab,
consider refreshing the window and then reproducing the bug to reduce the noise in the logs.

The path completions were improved in v3.9.0 and we are currently on v3.9.1.
Please upgrade to the latest version of the extension.

Hi @krassowski ,
Things work much better on v3.9.1, and the error I reported has indeed been fixed. I apologise for not having tried with the latest version.
I wish to share other issue though: I notice that string completion still require kernel lookup and

I can't make it work on the editor;
only work on a notebook with the defaults. It stops working if I disable Kernel autocomplete via

{"disableCompletionsFrom": ["Kernel"],
}

This happens on both my Mac and Linux CentOS7 instances, even on v3.9.1.
Is it something you expect?

This might be a limitation of the LSP server you use - it might not be providing the path completions (the kernel generally knows more about your environment than the LSP server). It's hard to tell without more details.

Thanks for answering @krassowski,
What information can I share with you?
I am using:
jupyter-lsp               1.5.0
jupyterlab-lsp            3.9.1
python-lsp-jsonrpc        1.0.0
python-lsp-server         1.3.0.dev (your fork if I am not mistaken)
Here's my autocomplete config:
{
    "showDocumentation": true,
    "caseSensitive": true,
    "continuousHinting": true,
    "waitForBusyKernel": false,
     "kernelCompletionsFirst": false,
    "kernelResponseTimeout": 6000,
     "disableCompletionsFrom": [], //["LSP", "Kernel"]
}

Does it help? Am I missing something obvious?


CI: Travis / unit-tests: speaker_test.go:223: expected fence to be empty. got: map[:1]

Travis failure on master (not reliably failing):
https://app.travis-ci.com/github/cilium/cilium/jobs/552491812
=== RUN   TestSpeakerOnDeleteService
level=info msg="processing new event." component=MetalLBSpeaker.run subsys=bgp-speaker
    speaker_test.go:223: expected fence to be empty. got: map[:1]
--- FAIL: TestSpeakerOnDeleteService (0.00s)

CC @ldelossa any thoughts on why this may occur occasionally?


chore(Segment): use React.forwardRef()

Similarly to #4234, adds native ref forwarding to Segment and all subcomponents.

Codecov Report

Merging #4238 (da02fa8) into next-v3 (a8167df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           next-v3    #4238   +/-   ##
========================================
  Coverage    99.75%   99.75%
========================================
  Files          180      180
  Lines         3254     3260    +6
========================================
+ Hits          3246     3252    +6
  Misses           8        8

Impacted Files
Coverage Δ

src/elements/Segment/Segment.js
100.00% <100.00%> (ø)

src/elements/Segment/SegmentGroup.js
100.00% <100.00%> (ø)

src/elements/Segment/SegmentInline.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8167df...da02fa8. Read the comment docs.


Updated the Show code page

Changes made according to the Issue #495
Code can now be changed and reviewed directly from the webPage.

Tasks Completed:

[x] Redesign of the UI
[ ] Betterment of Dark Mode
[x] Make the code such that changing it propagates to the displayed button
[x ] Fix errors

Note: Some errors are still there.

It's an issue of vercel!
It only provides 100 deployments each day!

It was a pleasure


Added tools dnu

Added support for DNX Utility

dnu restore
dnu build
dnu pack

@jorisdebock Great! :+1: Will take a look at this tonight (CET).

@patriksvensson did you have time to take a look at it?

Sorry for not getting back to you @jorisdebock , if no one gets to it before me I'll take a look and get back to latest this weekend.

@jorisdebock Sorry for not getting back to this sooner. Life got in the way of reviewing this.
As far as I can see this looks good, but there are some minor things that need to be addressed.

All references to Dnu in comments (and alias attributes etc) should be DNU.
All comments should end with a period (.).

Other than that, I think everything looks good :+1:
@devlead @gep13 You have more experience than me with :NET Core, would you mind taking a look as well?

@patriksvensson I fixed the minor things you said, let me know if there are other things that can be improved.

@jorisdebock Looks good to me :+1:
Could you rebase this against develop and squash it to a single commit?
Would also appreciate if you updated the commit message to something like Added DNU tool support.
Thanks! :smile:

@jorisdebock this looks good to me :+1:
I just left some minor code style comment.
Just rebase into one commit as @patriksvensson already commented and we'll get this merged.

@devlead ok great, will do shortly

Excellent @jorisdebock :+1:

@jorisdebock This have been merged. I had to rebase it against develop so it won't show up a merged. Sorry about this but didn't want to bother you once again with a new rebase :smile:
Great work! It's really appreciated:+1:


Optimization issue with CurrentMediaSessions

Currently, grabbing CurrentMediaSessions creates a new ReadOnlyDictionary.
This can cause massive memory/general optimization issues for anything that calls CurrentMediaSessions.
Need to create a class to handle both an internally usable Dictionary, and an externally usable ReadOnlyDictionary. Keeping 2 dictionaries in sync should be much more efficient than creating a new dictionary every CurrentMediaSessions get.

public IReadOnlyDictionary<string, MediaManager.MediaSession> CurrentMediaSessions => _CurrentMediaSessions;
private readonly Dictionary<string, MediaManager.MediaSession> _CurrentMediaSessions = new Dictionary<string, MediaManager.MediaSession>();

Pretty sure changing to this will work?

Yup! That worked wonderfully! Thanks a ton.

Implemented in 2.4.0 release


Use a lock file to allow only one jenkins test script at a time

Looking at this I realized that Spark 1.1.0 is hard-coded into out jenkins test script. We'll need to address that for Spark 1.2.0 support. We are also downloading Spark each time we run the script; we should probably cache the tarball locally instead.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/560/Build result: FAILUREGitHub pull request #559 of commit 6b268d3b5a7b1c28331432a73c4816285ab6212b automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/559/merge^{commit} # timeout=10Checking out Revision 346b984b06281163e7cde3058bcb5adb74eb8864 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 346b984b06281163e7cde3058bcb5adb74eb8864 > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURE
Test FAILed.

Bother. lockfile isn't available on the workers. I'll look into this tomorrow with Shane.

Jenkins, test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/578/Build result: FAILUREGitHub pull request #559 of commit 6b268d3b5a7b1c28331432a73c4816285ab6212b automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/559/merge^{commit} # timeout=10Checking out Revision 0d7105ecd05b110086eb6db1b4a2b6d1e396c6fd (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 0d7105ecd05b110086eb6db1b4a2b6d1e396c6fd > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.2.0,centosADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.2.0,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Ping @massie @shaneknapp to install lockfile on Jenkins.

python, i assue...  right?
On Tue, Feb 3, 2015 at 5:01 PM, Frank Austin Nothaft <
<EMAIL_ADDRESS>wrote:

Ping @massie https://github.com/massie @shaneknapp
https://github.com/shaneknapp to install lockfile on Jenkins.
—
Reply to this email directly or view it on GitHub
https://github.com/bigdatagenomics/adam/pull/559#issuecomment-72770302.

Nah, tis a command: man lockfile

I'm starting to question this approach now. A better fix might be to configure Jenkins to guarantee one build per worker. I'll chat with Shane about this more later. I'm going to close this for now.


RetinaFace pretrained model

Thanks for porting this to tensorflow. Is there a retinaface r50 pretrained model for tensorflow, like there is for mxnet?

Sorry, retinaface in this repository is not completed yet, we can't provide pretrained model now.

Is there a insightface pretrained model for this projects?

Do you have a timeline to finish the work on RetinaFace?


two churn tests are flaky

These two tests fail frequently for me:
X	proxy integration tests using churn run a simple echo test
X	proxy integration tests using churn detects a remote close

Still flaky as of 29.0.4.

Annoying, but probably not something we want to block Beta given current Firefox flakiness.

Not seeing this anymore! Yay.


[CI][UMT] build focal berkeley migration deb

I learned from our AN ops that they would like to use focal debian for berkeley migration. This PR introduces such job

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


⚠ BCR Bot has degraded performance

In cec3fc3, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1801 ms

Resolved: BCR Bot performance has improved in d47d7f8.


change version to 0.10.4

Codecov Report

Merging #1642 (0546fb0) into main (efafd00) will decrease coverage by 0.15%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   46.21%   46.07%   -0.15%
==========================================
  Files          47       47
  Lines        6913     6913
==========================================
- Hits         3195     3185      -10
- Misses       3718     3728      +10

see 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Json Schema] support if-then

I see this mentioned as "Applying Subschemas Conditionally" here circa 2019 in this repo, but I dont see any mention of it since. So, I am not sure if it is just not supported yet or if I am doing this wrong.
I made a stackblitz for this here:
https://stackblitz.com/edit/angular-g45ydm?file=src%2Fassets%2Fjson-schema%2Fif_then.json
I also have an active question on stack overflow with more details here:
https://stackoverflow.com/questions/70175244/json-schema-formly-dependent-sub-schemas
Currently using formly version 5.10.23 in angular 12.2.10
Just looking at the code it does not appear to, it simply merges the if then constructs directly into the base schema.

not yet but here is an implementation that I've done a while ago https://stackblitz.com/edit/angular-ub9hnv  which you could use till we provide it

Bummer! Well thanks for taking a look, I will check out your example and see if I can apply it. I have a workaround for what I'm trying to do, basically just using oneOf on configurationData in that example, and making a text area field type to edit the inner json data directly in a text area. Not ideal obviously, and prone to error, so adding this would be super helpful. I might actually consider just making a fork and taking a crack at it myself just to understand the formly code better. Thanks!

any plans to include this soon?

Hi @aitboudad,
I am using Angular v-14 and formly v-6, (https://stackblitz.com/edit/angular-hsezmz) when switching between if and else fields form is resetting the data, if I update resetFieldOnHide to false then not facing the issue,
extras: {
        resetFieldOnHide: false,
      },

in FormlyModule.forRoot. but this will effect entire app, is there any better way to resolve this issue?
Thanks.

Hi @aitboudad,
I am using Angular v-14 and formly v-6, (stackblitz.com/edit/angular-hsezmz) when switching between if and else fields form is resetting the data, if I update resetFieldOnHide to false then not facing the issue,
extras: {
        resetFieldOnHide: false,
      },

in FormlyModule.forRoot. but this will effect entire app, is there any better way to resolve this issue?
Thanks.

@subhani1249 see https://formly.dev/docs/guide/migration#6-resetonhide-is-enabled-by-default

I would like to try implementing this feature. It should be similar to dependency


Update dependencies for aarch64

compiles properly on apple's arm chips with a version bump of dialoguer.

Interesting, I'm not getting any compile issues with the current main branch which is still on dialoguer 0.9. Running on an Apple M1 Max with macOS 13.2.1.


🐛 Bug Report: Select Source Documentaiton modal blocks interface

📜 Description
Following the installation instructions, both running with run.sh and with run-with-docker-compose.sh, when executing for the first time, a modal requesting the source documentaiton prevents using the page.

Application contains the indexes with the default documentation:
-rw-rw-r-- 1 pga_gcp_10 pga_gcp_10 343K Oct 19 11:41 index.faiss
-rw-rw-r-- 1 pga_gcp_10 pga_gcp_10  27K Oct 19 11:41 index.pkl

👟 Reproduction steps
./run.sh
Follow the instructions
open localhost:5173
👍 Expected behavior
I can use the interface
👎 Actual Behavior with Screenshots

💻 Operating system
Linux
What browsers are you seeing the problem on?
Chrome
🤖 What development environment are you experiencing this bug on?
Docker
🔒 Did you set the correct environment variables in the right path? List the environment variable names (not values please!)
API_KEY
LLM_NAME
VITE_API_STREAMING
📃 Provide any additional context for the Bug.
No response
📖 Relevant log output
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🔗 Are you willing to submit PR?
Yes, I am willing to submit a PR!
🧑⚖ Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would love to work on this issue would you please assign this to me!

I can't assign issues to developers, but I would be happy if you have a look. Please tell me if you need anything :).
Thanks!!

I have the same question

I also have the same question

@pablo-aledo i also have the same problem

me too, did u solve it?

Its a networking issue, happens if your frontend cannot connect to the backend.
Please avoid creating similar issues and describe how you launched docsgpt and your environment.
Ensure that Both frontend and backend containers are exposed and accessible, and that frontend is aware of correct backend location.


HL-864, HL-875: Fix failing submit for handler

Description :sparkles:
Crashed as the frontend couldn't parse the backend error message related to the missing terms. This fixes error message parsing.
Also, added fixture for handler terms to avoid this happening in the future.
Modified seed command to seed handler applications also (HL-875).

Codecov Report

Merging #2153 (78a8b0b) into develop (36b198d) will decrease coverage by 18.22%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop    #2153       +/-   ##
============================================
- Coverage    30.01%   11.80%   -18.22%
============================================
  Files          816      160      -656
  Lines        16766     4465    -12301
  Branches      3645     1115     -2530
============================================
- Hits          5032      527     -4505
+ Misses       11122     3768     -7354
+ Partials       612      170      -442

Impacted Files
Coverage Δ

...rc/components/newApplication/useApplicationForm.ts
0.00% <0.00%> (ø)

...ntend/benefit/handler/src/hooks/useFormActions.tsx
0.00% <0.00%> (ø)

... and 656 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot download fasta sequences

Hi
This is a great tool, all steps work fine. However, I am not able to download the prophage sequences in fasta-format. The double-stranded DNA icon for BLAST works perfectly alright. But, the vertical arrow to download fasta sequences does not seem to work. In short, how can I extract fasta sequences of these prophage regions? Thanks.

Hello, unfortunately, the server with the necessary script is down. But now the problem is fixed and the new version of phigaro is available now.  Also, you can change the line at header of your html file:
from <script src="https://fastcdn.org/FileSaver.js/1.1.20151003/FileSaver.min.js"></script> to
<script src="https://cdn.jsdelivr.net/gh/bobeobibo/phigaro/scripts/FileSaver.min.js"></script>

Thanks. It works fine now. However, it would be nice to save prophage sequences of each sample in the result folder automatically, along with phg and html files (prefix with sample name). For few samples it is easy to download these fasta files manually, but will be difficult if there are large number of samples to analyze. Just a thought.

At the bottom of the html page you can find two icons: to blast all and to download all

I am using this one-liner to generate phg and html files for 3 samples (In future, I plan to run on ~500 samples). Then, I open 3 html files to download their prophage fasta by clicking the download icon at the bottom corner, which is great.
Is it possible to add fasta download/generate feature with -e option? So it produce ".phg", ".html" and ".fasta" for each sample (accession number in this example), instead of downloading them manually from the html file. I think PHASTER tool produces fasta format sequence for each sample.
###############
#!/bin/bash
files=('CP016072'
'CP016073'
'CP032682'
)
for file in "${files[@]}"; do
phigaro -f FASTA/${file}.fasta -o RESULT/${file}.phg -p --not-open -c config.yml -t 16 -e txt html
done
#############
Thank you so much.

Hello! We add the feature you asked about! Try it in a new Phigaro <IP_ADDRESS> =)

Thank you so much. The newly added -s option downloads all the prophages in fasta format. It becomes easier to cluster all predicted prophages now. Thanks again for this great tool.

Hello
I just updated to phigaro 2.2.6 using conda, and see that -s option to automatically download prophages in fasta format is no longer available. It would be nice to have this option for comparing all prophages. It is difficult to download them from the icon in the html file. Also, I can not find --wtp option with phigaro -h.

Hello, sorry,
I'll check tomorrow when and why I lost the -s option and restore it!
About --wtp, it is a service option for WhatThePhage tool, so, it is not supposed for general usage


Create a macOS guide for Getting Started

Basic content has been added, but styling on the Download button is missing.


HTTP wrapper missing?

After quite some digging I was not able to find instructions on how to get started with the https://github.com/Open-EO/openeo-processes-dask backend (other than installing the dependencies and running the tests, which works fine for me) - do you have any hint?
After some chats with @m-mohr and Jonas Eberle they've recommended to open an issue on your side.
I'm interested in getting my hands dirty with openeo-processes-dask - basically connecting the python OpenEO client to it

Hi Romeo - I think you're looking for the openeo-pg-parser-networkx repository. This contains the code to parse and execute a process graph, and contains instructions for how to register process implementations from an arbitrary source (e.g. openeo-processes-dask) to the registry of available processes.
I should have really linked to there in the readme, it really isn't obvious that the parser is what one needs to execute a process graph - I'll do that asap!
If you run into any problems, please don't hesitate to open further issues, more than happy to help! :)

What he's looking for is the "the full thing", so basically the docker image with API "wrapper", pg parser, processes-dask etc combined or at least a hint how to do that. Because the Python client can't directly connect to the pg parser, of course. Maybe that's something you or @clausmichele could help with?

I'm actually working on that, currently based on our processes implementation and later will move to openeo-processes-dask and openeo-pg-parser-networkx.

Thanks @clausmichele - yes, saw it in the last monthly meeting, thanks so much for pointing this out


Represent VARBINARY with hex in ResultSet.getString

Fixes https://github.com/prestosql/presto/issues/6247

based on https://github.com/prestosql/presto/pull/6208, cc @losipiuk

rebased to resolve a logical conflict with https://github.com/prestosql/presto/pull/6207

Rebased to resolve conflct with https://github.com/prestosql/presto/pull/6243

Looks good but it would be great to confirm that other DB do similar thing.

They do and i also added a test for that in this PR

Awesome thanks. I missed that.

CI https://github.com/prestosql/presto/issues/4063 -> https://github.com/prestosql/presto/pull/6272


kubernetes on azure not working :

I was trying to follow these instruction @ https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/azure.md  to build some containers and manage it but I can’t get pass the step of deploying apps
Steps I am able to run until is cluster/kube-up.sh (
This step never finishes , loops on Validation step and never ends, but I can see master and Menons spin up in Azure portal and can SSH to master , It looks like the kube-up.sh is not successful.
But  I tried Next steps of deploying a sample app on nginx container fails
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/simple-nginx.md
It basically can't connect to master node with error it can't connect to localhost:8080 api server
One thing other thing is doc is not clear about where to run this from ? Workstation , or kubernetes master ?
Also when run kubectl run my-nginx --image=nginx --replicas=2 --port=80 it says "run" is not recognized option.
Thanks

Can you please try if these steps will work for you:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/coreos/azure/README.md

Thank you  for your response, I have tried this steps also and it still does not work.
With this steps  https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/coreos/azure/README.md    I can successfully, spin up to ./create-kubernetes-cluster.js and able to ssh intto kube-00 , but after that it fails at step core@kube-00 ~ $ kubectl get minions
I get error as below:
Error: Get http://<IP_ADDRESS>:8080/api/v1beta3/minions: dial tcp <IP_ADDRESS>:8080: i/o timeout
basically it seems after install none of the Services are started on master.
 Rakesh Shah
408-391-9610
From: Iaroslav Savytskyi<EMAIL_ADDRESS>To: GoogleCloudPlatform/kubernetes<EMAIL_ADDRESS>Cc: srakesh28<EMAIL_ADDRESS>Sent: Saturday, May 30, 2015 3:37 PM
Subject: Re: [kubernetes] kubernetes on azure not working : (#9036)
Can you please try if these steps will work for you:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/coreos/azure/README.md—
Reply to this email directly or view it on GitHub.

Error: Get http://<IP_ADDRESS>:8080/api/v1beta3/minions: dial tcp <IP_ADDRESS>:8080: i/o timeout

That's a bit odd, I'll take a look into it now.

Ok this is due to mass rename that came with<PHONE_NUMBER>93d435dfb1cd31e6337d53d92f7194, I will update the code to use latest 0.18 release.

Thank you very much, Ilya.
Is it possible to add some error handling? Because now script process without an error but nothing works.

On 1 Jun 2015, at 14:18, Ilya Dmitrichenko<EMAIL_ADDRESS>wrote:
Ok this is due to mass rename that came with 3005471, I will update the code to use latest 0.18 release.
—
Reply to this email directly or view it on GitHub.

@yaroska it'd be great to chat over on IRC, I'm not sure what exactly did you do and what didn't work... I'm errordeveloper in Freenode.

@yaroska feel free to post details here, but IRC might be just a bit easier :)

This should be fixed with #9060.


Refactor EigenGate to include a global phase shift

Use it in RotZGate
Refactor ExpZGate to inherit from RotZGate

Part of https://github.com/quantumlib/Cirq/issues/865
Part of https://github.com/quantumlib/Cirq/issues/816
Part of https://github.com/quantumlib/Cirq/issues/952
Part of https://github.com/quantumlib/Cirq/issues/950

Automerge done.


Calculate  basic damage for skills

It could be a useful way to compare equipment builds for the same hero.

Damage Formula
Skill Data

See EpicSevenDB/gamedatabase#114


not install, not compatible guzzle

composer require eko/googletranslatebundle
Using version ^1.1 for eko/googletranslatebundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- eko/googletranslatebundle 1.1.2 requires guzzlehttp/guzzle 5.0.@dev -> satisfiable by guzzlehttp/guzzle[5.0.0, 5.0.1, 5.0.2, 5.0.3] but these conflict with your requirements or minimum-stability.
- eko/googletranslatebundle 1.1.1 requires guzzlehttp/guzzle 5.0.@dev -> satisfiable by guzzlehttp/guzzle[5.0.0, 5.0.1, 5.0.2, 5.0.3] but these conflict with your requirements or minimum-stability.
- eko/googletranslatebundle 1.1.0 requires guzzlehttp/guzzle 5.0.*@dev -> satisfiable by guzzlehttp/guzzle[5.0.0, 5.0.1, 5.0.2, 5.0.3] but these conflict with your requirements or minimum-stability.
- Installation request for eko/googletranslatebundle ^1.1 -> satisfiable by eko/googletranslatebundle[1.1.0, 1.1.1, 1.1.2].
Installation failed, reverting ./composer.json to its original content.

I have the same issue. I'm using another bundle which use GuzzleAdapter 6 and I have conflict with guzzlehttp/guzzle 5.0

+1 I would like to have a 1.1.4 tag where the guzzle dependency would be defined as higher then 5.3.0 or something.

Hello,
Could you please propose a Pull Request with that change in order to tag it?
If you can't I will try to do that later.
Thank you


It seems that the data provided by useOwnedHandles is not sufficiently real-time. I am unable to retrieve the profile I purchased through this hook.

Describe the bug
It seems that the data provided by useOwnedHandles is not sufficiently real-time. I am unable to retrieve the profile I purchased through this hook.
To Reproduce
 const {data: infos} = useOwnedHandles({     for: '0x1a4De364e26E9A822c42510206DFbDB13e5543Ea',   });

Expected behaviuor
A clear and concise description of what you expected to happen.
If using the React bindings, what is the essence of your React app?

[ ] React Web App

[* ] React Native

Version of the packages you are using
"@lens-protocol/metadata": "^1.0.5",
"@lens-protocol/react-native": "^0.1.0-alpha.2",
Additional context
Add any other context about the problem here.

You only own a profile, not a handle they are 2 different things
That handle is owned by https://polygonscan.com/address/0xF4a0657b93f78Bf5F5387d1D391bf6361F7A7Fdc
that metadata in your wallet is out of date here one which is refreshed > https://opensea.io/assets/matic/0xdb46d1dc155634fbc732f92e853b10b288ad5a1d/36799
you brought the profile 10 days ago https://polygonscan.com/tx/0xeb887c4412bad6e1751cadef3c779a3f1794d46db125ccdef80d6649ffc24833 the handle will not follow it as they are 2 different NFTs

Thanks, Got it. lol


Rake task for full SCSB dump file

https://github.com/pulibrary/marc_liberation/compare/full_partner_updates

Investigating with @mzelesky .
Currently we have the partners full dump files on bibdata-worker2:/data/scsb_full.

We want to create a task to connect to the scsb ftp server and pull the latest full dump. (this is either one zipped file or the 2 zipped files we currently have in the /data/scsb_full. I will know that after I connect to the scsb ftp server.)
We will look for the earliest timestamp of these 2 zipped files; use this date to run a second rake task to index the incremental updates from that date until now.


Remove markdown-based static pages

What is the motivation for adding / enhancing this feature?

This feature appeared to be redundant. It's also complicating our vue-cli pkugin migration plan
We should base demo static pages on simple placeholders or some external cms data.
What are the acceptance criteria

remove markdown static pages and remove corresponding business logic
replace it with placeholders (can be a static vue component)

Can you complete this feature request by yourself?

I'm busy doing other issues regarding modules ;/
Additional information

We can remove them only if we replace the current mockups (terms and conditions etc ...) with static Vue Components. I don't want to have the demo site dependent on any external service (CMS in this case)

Ok, scheduled it for today ;)


Missing Gateway API example that is userd by Linkerd

I'll be happy to contribute if this is ok with you

Yes please!
You can add it here https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/tree/main/examples
And also update the documentation here https://rollouts-plugin-trafficrouter-gatewayapi.readthedocs.io/en/latest/provider-status/
Thank you in advance

@kostis-codefresh On it, are there any rules I should be aware of?

Try to make it similar with the other examples
Explain all the prerequisites needed for the setup
Make it clear which version of LinkerD you are using and which version of the Gateway API CRDs
Ideally it should be simple to replicate (use local cluster, an easy to find version of Linkerd, simple Argo Rollouts example) etc.

@kostis-codefresh https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/pull/81/

https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/pull/81 was merged.


Taxation on waste generation in public mining

Brave does not clearly specify which modules, crystals and drones we can use for the types of resources extracted from public moons, as our neighbors do.  See: https://wiki.bravecollective.com/member/alliance/industry/moonmining
Increasingly, we are seeing several multiboxing players using T2 modules and drones with B II crystals to obtain scarce resources (such as R64, R32) and generating waste ranging from 34% to 93%.
This situation is generating losses of billions of isk in fees for the alliance in each extraction, also affecting prices on the market and other mining players who do not generate waste using t1 modules and drones.
The losses can be easily calculated by cross-referencing the data per ore made available at each extraction with the fees actually charged on that resource.
Currently, the software does not charge for the volumes of resources wasted due to the use of T2 modules and drones and various types of crystals when mining public moons.
To implement this, we will have to see if we can somehow collect information on the amounts of waste generated in mining through the EVE API and also review the mining policies to define the requirements for applying charges on these resources with the alliance.
If the implementation of this functionality is not possible immediately, the alliance could review the mining policies so that the mining of public resources is accessible to all members in an equalized way and also charge the appropriate fees with improved use.

ESI does not contain the amount of residue that a character generates.

Hi @tkhamez :)
I've checked my consumption via ESI and also via the Mining Ledger UI  and the application is recording and charging for all the minerals collected, including waste.

When I opened this application it wasn't clear that the waste was included in the total mined, as we can see in the following images.

Moon Mining Manager Log

UI Mining Ledger Logs

ESI

The ESI is recording the total amount mined, so the application is correctly charging the fees.


fix: add id attribute to noopApp

Types of changes

[X] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Add id attribute to noopApp Vue instance.
If a route face redirection during its rendering process, noopApp will render on the server side server.js#L182. Since the noopApp does not contains id attribute, This cause an error during client side hydration.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #8596 (63916a3) into dev (c15078f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #8596   +/-   ##
=======================================
  Coverage   66.02%   66.02%
=======================================
  Files          92       92
  Lines        4009     4009
  Branches     1103     1103
=======================================
  Hits         2647     2647
  Misses       1095     1095
  Partials      267      267

Flag
Coverage Δ

unittests
66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15078f...63916a3. Read the comment docs.

Codecov Report

Merging #8596 (63916a3) into dev (c15078f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #8596   +/-   ##
=======================================
  Coverage   66.02%   66.02%
=======================================
  Files          92       92
  Lines        4009     4009
  Branches     1103     1103
=======================================
  Hits         2647     2647
  Misses       1095     1095
  Partials      267      267

Flag
Coverage Δ

unittests
66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15078f...63916a3. Read the comment docs.


UX Consistency

Describe the bug
Consistency is one of the UX Design principal that every website should take care of that.
Sign out button above the title of the page "Account Settings for User Name" is not a good choice. I think that we should Remove this button or change the position at the bottom of the page. Because we have this button in the Menu
Steps to reproduce the behavior:
1.Go to 'Freecodecamp.org'
2.Click on 'Menu'
3.Scroll down to 'Settings'
4.See an error.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: chrome
Version: 89.0.4389.90

Hello there,
I am closing this as a duplicate of your previous issue which is a duplicate of #41423


Host selector for all hosts

Currently all hosts need to be tagged somehow. Handle "all" as a selector to use with "--no-iteraction" flag, which would default to all provided hosts.

Not sure how i missed it :)

Will add docs =)


Feature request: make integrated decks optional when cardcast deck is added

I think it would be useful to let users play with only an imported cardcast set.
An example: In the case of translations, users will not want to have english cards mixed with an imported translation deck.
For the record: I tried using the banned cards list to ban the "non optional" deck, but it did not work.

That is a must have. pls fix volvo.


Add configurable APU and APV values in ECDH KDF process

Right now, these JWE recipient headers are not being read and are set to empty []byte during the KDF process.
Read the recipient headers from the envelope and update the Tink keys to include them.

closed by #2523


V0.4.0 release

Integrate necessary version updates back into main:

version change in setup.py
a small requirement bug fix
roadmap change:

v0.5.0 refers to incremental development
v0.6.0 refers to parts of data agents

LGTM

LGTM


Upgrade get-owner polyfill

I just made the changes proposed by @rwjblue in https://github.com/stefanpenner/ember-moment/issues/249#issuecomment-318916134

@Madumo thanks for taking this up - I will version a patch shortly.  Disregard beta & canary CI failures, unrelated to your changes.


Added spaceless tag around render_plugin_preview

This is to avoid having a new line (user rendered as a space) just after the plugin.

@batisteo the template that ckeditor renders doesn't have own spaces, you can see that in the diff. if there is a space - it comes from a plugin being rendered and therefore shouldn't be changed.

I wish.

Case 0
{% load djangocms_text_ckeditor_tags %}{% render_plugin_preview plugin %}

My template, with a trailing new line as defined in the project editorconfig.
{{ instance.link_name }}

<template class="cms-plugin cms-plugin-start cms-plugin-76596"></template>

This is a link

.

Case 1
{% load djangocms_text_ckeditor_tags %}{% render_plugin_preview plugin %}

My template, without a trailing new line, violating the project editorconfig.
{{ instance.link_name }}

One less new line:
<template class="cms-plugin cms-plugin-start cms-plugin-76596"></template>

This is a link
.

Case 2
{% spaceless %}{% load djangocms_text_ckeditor_tags %}{% render_plugin_preview plugin %}{% endspaceless %}

My template, with a trailing new line as defined in the project editorconfig.
{{ instance.link_name }}

No new lines in the output.
<template class="cms-plugin cms-plugin-start cms-plugin-76596"></template>

This is a link.

@vxsx I really don’t know how to deal with this issue on my side.

The template of the link plugin must not have a trailing newline, that's it (e.g. like this: https://github.com/divio/djangocms-link/commit/e02fa6cabb7462b7bfab2a9dfbe9dd1d7391dd9b). The render template of ckeditor doesn't have a trailing new line already, so ckeditor itself doesn't render any extra whitespace (unless the template was overwritten).
Editorconfig is amazing, but the tools are just tools, exceptions happen, and for a good reason. You can define something similar to this https://github.com/divio/djangocms-text-ckeditor/blob/master/.editorconfig#L23 if you really need to ever actively edit the file.

The template of the link plugin must not have a trailing newline, that's it.

In the Case 1, my template don’t have any trailing newline. Yet it gets rendered with a remaining newline.

Could you provide an example project to reproduce?


PomBase slim update

please could we replace
meiotic nuclear division (GO:0140013)
with
meiotic cell cycle process (GO:1903046)
MAny thanks
v

Thanks!


SpongeForge Server + GD not working.

Minecraft 1.12.2
Sponge Forge: 7.2.0
Forge 2847
GriefDefender 1.2.6 Sponge B4
Removed Grief Prevention.
Added Grief Defender.
Booted server. It starts but throws errors.
Config stays blank in the GriefDefender folder.
Log is here
java.lang.NullPointerException: null
	at com.griefdefender.task.PlayerTickTask.run(PlayerTickTask.java:60) ~[PlayerTickTask.class:1.2.6]
	at org.spongepowered.api.scheduler.Task$Builder.lambda$execute$0(Task.java:139) ~[Task$Builder.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SchedulerBase.lambda$startTask$0(SchedulerBase.java:197) ~[SchedulerBase.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SyncScheduler.executeTaskRunnable(SyncScheduler.java:74) ~[SyncScheduler.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SchedulerBase.startTask(SchedulerBase.java:188) ~[SchedulerBase.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SchedulerBase.processTask(SchedulerBase.java:174) ~[SchedulerBase.class:1.12.2-2838-7.2.0]
	at java.util.concurrent.ConcurrentHashMap$ValuesView.forEach(Unknown Source) [?:1.8.0_241]
	at org.spongepowered.common.scheduler.SchedulerBase.runTick(SchedulerBase.java:112) [SchedulerBase.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SyncScheduler.tick(SyncScheduler.java:47) [SyncScheduler.class:1.12.2-2838-7.2.0]
	at org.spongepowered.common.scheduler.SpongeScheduler.tickSyncScheduler(SpongeScheduler.java:189) [SpongeScheduler.class:1.12.2-2838-7.2.0]
	at org.spongepowered.mod.SpongeMod.onTick(SpongeMod.java:457) [SpongeMod.class:1.12.2-2838-7.2.0]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_368_SpongeMod_onTick_ServerTickEvent.invoke(.dynamic) [?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) [ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.forgeBridge$post(EventBus.java:753) [EventBus.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:703) [EventBus.class:?]
	at net.minecraftforge.fml.common.FMLCommonHandler.onPreServerTick(FMLCommonHandler.java:279) [FMLCommonHandler.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:657) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_241]```
Please help

renaming sponge to a_spongeversion, i get this
https://hastebin.com/elahexewor.md
Both way's the config does not load.

Make sure you've also updated your Luckperms to latest

Well i had version 5.0.70  and see that 5.0.117 is the newest.   i updated, but the error is still the same

So the issue is Prism Plugin from Sponge.   Took some removing. But it does not play good with Prism. Unsure what servers are using that are close to prism, but we use it for anyone who griefs

So the issue is Prism Plugin from Sponge. Took some removing. But it does not play good with Prism. Unsure what servers are using that are close to prism, but we use it for anyone who griefs

Not sure what purpose a rollback plugin serves when using GriefDefender, but either way it's not related to GD.
However GD does have restore features

I did not know that GD does that. :) Good to know

Just tested latest build from https://github.com/prism/Prism/releases and it works fine on latest SF.

Hello, My players cant seem to use the golden shovel, and somehow i lost all perms to be able to use /gd commands. How can i fix these two issues?


Cannot read property 'startTime' of undefined

Error in Shape Shifter
TypeError in /
Cannot read property 'startTime' of undefined
View on Bugsnag
Stacktrace
webpack:///src/app/components/layertimeline/layertimeline.component.ts:696 -

View full stacktrace
Created by Alex Lockwood via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
TypeError in /


Token doesn't take tokens (dead or alive) into account

Together with Drag Ruler and Terrain Ruler, the Enhanced Terrain Layer module does work with difficult terrain tiles, but (even when checked) doesn't take into account when walking over dead or alive tokens/creatures
To Reproduce
Tested in an old world and in a new one!

Activate the Modules "Drag Ruler (Traumi's Patch)" and "socketlib", "Enhanced Terrain Layer" and "Terrain Ruler"
In Settings, check "Include Live Tokens" and "Include Dead Tokens"
Try to drag a Token over a friendly/enemy token or over a dead one.
Both types do not count as difficult terrain!

Expected behavior
Dead or Alive Tokens should count as difficult terrain, when being dragged over!
Screenshots

Please complete as much of the following information as possible:

Foundry Version 10, Build 286
System D&D5e
Module version 10.3
No errors in the console

Additional context
Add any other context about the problem here.

This is the same for PF2e

I believe this is fixed with the latest version.  If it is not, please re-open this ticket.


feat: the short complexes attached to homological complexes

If K is an homological complex and i some degree, this PR defines the short complex K.sc i which is `K.X (c.prev i) ⟶ K.X i ⟶ K.X (c.next i)``.

[x] depends on: #6008

bors r+


Preparation for Simd reduction, removal of redundant code

The current reduction code to lower ONNX to Krill used 2 methods, one for legacy and one for current ops. As new versions will be needed to handle SIMD code, the first step is to unify these two methods into a single code generation scheme.
The code also use old methods to generate Krill iterate loops; upgraded to use the builder based on lambda function.
Code generated is slightly more compact, functionally equivalent.
Once this is in, I can start the SIMD code gen.

Jenkins Linux s390x Build #11751 [push] Preparation for Simd red... started at 08:35

Jenkins Linux amd64 Build #11739 [push] Preparation for Simd red... started at 07:35

Jenkins Linux amd64 Build #11739 [push] Preparation for Simd red... failed after 1 hr 10 min

Jenkins Linux ppc64le Build #10798 [push] Preparation for Simd red... passed after 1 hr 59 min


[Question] Plans for Windows Notifications?

Hi,
I noticed that for a while now, support for rendering Adaptive Cards in Windows Notifications has been shown as planned, and in fact support even was advertised in a preview version of the Windows 10 SDK.
However, I can no longer find the AdaptiveCard field in ToastNotification, and checking wpnapps.dll in a reverse engineering tool shows a check along the lines of the following:
enum
{
  PAYLOAD_XML = 0x0,
  PAYLOAD_ADAPTIVEJSON = 0x1,
  PAYLOAD_RAW = 0x2,
};

// snipped out feature check for an always-disabled feature
if (obj->m_payloadType == PAYLOAD_ADAPTIVEJSON) {
    return E_INVALIDARG;
}

if (obj->m_payloadType != PAYLOAD_XML) {
    return E_UNEXPECTED;
}

Is this feature still planned to be released in a future Windows platform release, or alternately as a wrapper library (rendering to XML payloads) so that it'll work on older Windows versions as well?

Hi @nta : At this point we do not have an ETA on when or how this integration will be released.  Thanks for your interest though. How are you planning on using Adaptive Cards in notifications again?  @andrewleader    / @matthidinger  FYI.

Closing due to inactivity from OP


chore(General): :hammer: Change husky install command to husky

Description
Briefly describe the changes made in this Pull Request.
Additional context (optional)
Add any additional context or information about the changes made in this PR.
How to test
Provide clear and concise instructions on how to test the changes made in this PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7e6b299) 89.54% compared to head (87f7749) 89.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   89.54%   89.54%
=======================================
  Files         117      117
  Lines        3472     3472
  Branches      779      779
=======================================
  Hits         3109     3109
  Misses        333      333
  Partials       30       30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


prep for 2024 release

Add scaffold link / name to frontend.

small update to client instructions in getting started

@ client please review the client instructions in getting started

Looks good to me, although I was doing some testing and I'm not sure about the accuracy of the jdk stuff. For one, the release workflow uses one called 'adopt,' which isn't oracle. Hank is also using a non oracle jdk during dev


KAFKA-1194: changes needed to run on Windows

Hi,
I have come across this comment by Maksim Zinal.

I've created a quick patch which seems to fix the issue on my system and on the Kafka version I use (2.8.0).
I believe that the reason of lock failures is the use of RandomAccessFile Java API to open the files in some cases, while in other cases FileChannel.open() is used instead. When opening files with RandomAccessFile under Windows, FILE_SHARE_DELETE flag is not set, which leads to "access denied" errors when trying to rename or delete the open files. FileChannel.open() sets the FILE_SHARE_DELETE by default, as I checked on JDK 8 and 11.
Here's the link to the branch based on tag 2.8.0: https://github.com/zinal/kafka/tree/2.8.0_KAFKA-1194
Here are the exact changes implemented: https://github.com/zinal/kafka/compare/2.8.0...zinal:2.8.0_KAFKA-1194 (plus jcenter and grgit stuff needed to run the build).

This change addresses some "access denied" errors which occur on Windows.
KAFKA-1194, KAFKA-2427, KAFKA-6059, KAFKA-6188, KAFKA-6200, KAFKA-7575, KAFKA-8145, KAFKA-9458
Stackowerflow
45141541, 45599625, 48114040, 50755827, 67555122
Testing
I deployed Kafka 2.8.1. with the original patch provided by Maksim Zinal in January on ~50 Windows servers. Each Kafka instance has only one queue. Several processes per Kafka instance write their logs in to the queue and one process reads the queue and processed the data.
It seems that these issues mentioned on stackowerflow by Windows users are gone.
I am currently testing Kafka 3.3. with the latest version of the patch which was modified according to @divijvaidya requests.
Kafka 3.3. log files

controller.log
server.log
log-cleaner.log

You can see in the logs that Kafka managed to delete timeindex files.
Thank you for your time.

Thank you for your help, I really appreciate it.
$ ./jmh-benchmarks/jmh.sh FileRecordsBenchmark

Benchmark                                    Mode  Cnt  Score    Error   Units
FileRecordsBenchmark.testOpenChannelAfter   thrpt   25  0.333 ▒  0.004  ops/ms
FileRecordsBenchmark.testOpenChannelBefore  thrpt   25  0.001 ▒  0.001  ops/ms
JMH benchmarks done

@divijvaidya, thank you for you help. JDK 17 and Scala 2.13 build and tests finished successfully. Can we now request can a committer for review on this PR?

@divijvaidya thank you for your help. I updated the summary of the PR.

@mimaison perhaps you might be interested in looking at this one? I have done an initial review.

I'm afraid I have no experience running Kafka on Windows so I'm not familiar with the issues on that platform.

@ijuma, would like to take a look at this or perhaps tag a committer who would be most suited to look into this one? (note that we can review this PR from the lens of change the file preallocation logic to use the new Java NIO.2 APIs. The new APIs are better at handling Windows OS which is nice.)

I also had a problem with Kraft which did not start on Windows. The latest commit fixes https://github.com/apache/kafka/pull/12331/commits/f7cc920771735576d9cfba2afe6f26fdcfb2ccd4 it. The commit https://github.com/apache/kafka/pull/12331/commits/77ae23d816ea1a30a3ec970b7dfe77fd35f7fe00 most likely fixes KAFKA-7575 and KAFKA-2427, but I will have to do more testing to confirm that.

This is a really important fix for Windows. Can someone help move this along, please?

@sjetha you should probably send an email to the<EMAIL_ADDRESS>mailing list, explaining the urgency and asking for someone to take a look at this.

@MPeli do tests pass for you? I ran unitTest task on Windows 10 and some are failing
test-results.zip

@MPeli
I found AccessDenied exception again when a topic is deleted. This causes a crash same way it used to while deleting message.
Could the same fix be applied to delete topic as well?

I'm going to leave a -1 here because there are a number of issues in the patch and it's not ready to commit yet. I would encourage you to split this patch into several parts and clearly explain what issue each one solves and how.
From the high level, the challenge for us is that Windows does things quite differently in some cases, but we don't want to degrade performance on all the other platforms. So a lot of thought is probably required here. Ideally other platforms would not be impacted at all.

Agree that this change should be ideally confined to the Windows platform.

@Hangleton : Agree that this change should be ideally confined to the Windows platform w/o any code change for others.

Yeah. To be totally clear, it's OK to change the main code paths, but it really raises the stakes because then we want to understand that there haven't been performance or correctness regressions.
@MPeli: I really do want this to get in eventually but in its current form it's very difficult to review. As a first step, how about splitting out just the FileRecords.java change, for example. If you want to do preallocation differently on windows, then explain how it will be different and why, and have a PR that just does that. Since preallocation seems to be working fine on other platforms this particular change could be put behind an isOsWindows check.

Can someone help kafka on windows , please?
Two years have passed ！

@Hangleton @cmccabe I encountered a bug while using KRaft where Kafka would mark .checkpoint files in the _cluster-metadata_0 folder for deletion and then would fail to delete them because they are read-only. The root cause is that it tried to do it using the Files.deleteIfExists method, which can't delete read-only files on Windows. I made changes to KafkaMetadataLog.scala and Snapshots.java where I created a new method for this purpose.
path.toFile().setWritable(true) works if there is no file at the path on Windows, but I'm not sure how it behaves on Linux, so I can create a new unit test for it or put it behind an isOsWindows check. Should I create a new PR for this?

Hi Julius (@AB027PS) - just to clarify, this isn't the same as the AccessDeniedException  addressed by this CR right?

I work with Martin Pelak and he suggested that I add my change to this PR, but my change is unrelated to the rest of this PR. So this doesn't address the errors mentioned in the first comment if that's what you're asking.

Who can reslove that test failures?

I noticed that this issue has been open for some time, and it's currently preventing us from moving forward with production. Does anyone know of a workaround we could use until an official release with a fix is available?

I built broker from source and used it for local development
On Tue, Aug 13, 2024 at 8:32 PM Henrique Melo @.***>
wrote:

I noticed that this issue has been open for some time, and it's currently
preventing us from moving forward with production. Does anyone know of a
workaround we could use until an official release with a fix is available?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/kafka/pull/12331#issuecomment-2286771459, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABOO7DLPZHRV5FF2C2QJVDZRI7MHAVCNFSM5ZQDV53KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRYGY3TOMJUGU4Q
.
You are receiving this because you commented.Message ID:
@.***>

--
Yours faithfully,
Gleb

I fully agreed with @MeloHenrique , it's currently preventing us from moving forward with production for Windows user. Anyone can let me know a workaround could use until an official release with a fix is available?
@chester89 : is it working fine ?

Broker was certainly starting fine (I started one node with zookeeper) and can accept and route messages.
If I remember correctly, deleting a topic would still crash the process, but that seems to be a separate issue

Although I was using an older version of Martin's changes, likely built before his last rebase

I've been running this custom branch on a windows box for 9 months, processing over 10TB of data on a single node, and the only time it crashed was when I deleted a topic using the cli.

I'll take a look tomorrow.

@MPeli

From the high level, the challenge for us is that Windows does things quite differently in some cases, but we don't want to degrade performance on all the other platforms. So a lot of thought is probably required here. Ideally other platforms would not be impacted at all.

As the comment from Colin said, we are afraid this change degrades the performance for platforms other than Windows.
Also, from @AB027PS, it looks like we only need the makeWritableAndDeleteIfExists change to make it works in WINDOWS, is that right? If so, why other changes needed (ex: moving away from the CheckpointWriteBuffer)?

I made changes to KafkaMetadataLog.scala and Snapshots.java where I created a new method for this purpose.
path.toFile().setWritable(true) works if there is no file at the path on Windows

To avoid impacting the performance to platforms other than WINDOWS, I think we can do something like what we did in AbstractIndex:
https://github.com/apache/kafka/blob/743e185c8bf6d1d548fe7041ce543c7c31388e68/storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java#L202-L204
So, maybe we can just add a method like this:
public static boolean makeWritableAndDeleteIfExists(Path path) throws IOException {
       if (OperatingSystem.IS_WINDOWS) {
           path.toFile().setWritable(true);
       }
       return Files.deleteIfExists(path);
    }

WDYT?

Hi,
I only created the makeWritableAndDeleteIfExists method because it was causing crashes specifically while using KRaft. MPeli made the other changes before I even started using Kafka, so I'm assuming they are fixing the problems from the issues mentioned in the original comment.
And the method you suggested makes sense to me.

MPeli made the other changes before I even started using Kafka, so I'm assuming they are fixing the problems from the issues mentioned in the original comment.

Ah, I see. So, to move this PR forward, We need to resolve the conflict and apply the suggestion I provided above, to avoid to impact performance for platforms other than Windows.
@MPeli , do you want to complete this PR? I'd suggest if @MPeli has no response by tomorrow, anyone who is interested in this issue can help take over and open a new PR.

@showuon : it seems @MPeli has no response, if possible, could you please open a new PR ? That's very helpful to all Kafka windows users. Many thanks to you in advance.

Hi @showuon @vinothchandar ,
I think this is not only write permission problem, when I run logCleanerTest and UnifiedLogTest, ther error message is
[2024-09-06 09:15:51,661] WARN Failed atomic move of C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned to C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap retrying with a non-atomic move (org.apache.kafka.common.utils.Utils:958)
java.nio.file.FileSystemException: C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned -> C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap: 程序無法存取檔案，因為檔案正由另一個程序使用。
	at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
	at java.base/sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317)
	at java.base/sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293)
	at java.base/java.nio.file.Files.move(Files.java:1430)
	at org.apache.kafka.common.utils.Utils.atomicMoveWithFallback(Utils.java:955)
	at org.apache.kafka.storage.internals.log.AbstractIndex.renameTo(AbstractIndex.java:229)

Do you have any idea about this?

Hi @showuon @vinothchandar , I think this is not only write permission problem, when I run logCleanerTest and UnifiedLogTest, ther error message is
[2024-09-06 09:15:51,661] WARN Failed atomic move of C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned to C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap retrying with a non-atomic move (org.apache.kafka.common.utils.Utils:958)
java.nio.file.FileSystemException: C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned -> C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap: 程序無法存取檔案，因為檔案正由另一個程序使用。
	at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
	at java.base/sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317)
	at java.base/sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293)
	at java.base/java.nio.file.Files.move(Files.java:1430)
	at org.apache.kafka.common.utils.Utils.atomicMoveWithFallback(Utils.java:955)
	at org.apache.kafka.storage.internals.log.AbstractIndex.renameTo(AbstractIndex.java:229)

Do you have any idea about this?

I think this is the same issue. The KAFKA-2170 is talking about the issue that renameTo will fail, and the PR description also said:

I believe that the reason of lock failures is the use of RandomAccessFile Java API to open the files in some cases, while in other cases FileChannel.open() is used instead. When opening files with RandomAccessFile under Windows, FILE_SHARE_DELETE flag is not set, which leads to "access denied" errors when trying to rename or delete the open files. FileChannel.open() sets the FILE_SHARE_DELETE by default, as I checked on JDK 8 and 11.

So, let's say, after applying this patch, is the issue fixed?

Hi @showuon @vinothchandar , I think this is not only write permission problem, when I run logCleanerTest and UnifiedLogTest, ther error message is
[2024-09-06 09:15:51,661] WARN Failed atomic move of C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned to C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap retrying with a non-atomic move (org.apache.kafka.common.utils.Utils:958)
java.nio.file.FileSystemException: C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.cleaned -> C:\Users\TJWu\AppData\Local\Temp\kafka-10199909925325139565\kafka-437821\00000000000000000000.timeindex.swap: 程序無法存取檔案，因為檔案正由另一個程序使用。
	at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
	at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
	at java.base/sun.nio.fs.WindowsFileCopy.move(WindowsFileCopy.java:317)
	at java.base/sun.nio.fs.WindowsFileSystemProvider.move(WindowsFileSystemProvider.java:293)
	at java.base/java.nio.file.Files.move(Files.java:1430)
	at org.apache.kafka.common.utils.Utils.atomicMoveWithFallback(Utils.java:955)
	at org.apache.kafka.storage.internals.log.AbstractIndex.renameTo(AbstractIndex.java:229)

Do you have any idea about this?

I think this is the same issue. The KAFKA-2170 is talking about the issue that renameTo will fail, and the PR description also said:

I believe that the reason of lock failures is the use of RandomAccessFile Java API to open the files in some cases, while in other cases FileChannel.open() is used instead. When opening files with RandomAccessFile under Windows, FILE_SHARE_DELETE flag is not set, which leads to "access denied" errors when trying to rename or delete the open files. FileChannel.open() sets the FILE_SHARE_DELETE by default, as I checked on JDK 8 and 11.

So, let's say, after applying this patch, is the issue fixed?

Hi @showuon ,
The PR can’t pass log test directly, I will try fixing related issue for verification recently.
Many thanks.


[interop] ensure IRGen reaches code referenced through destructor inv…

…oked using the 'delete' statement in C++

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please test and merge


pull request for e2e test at 01/03/2017 13:56:13

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bump the PHP version on appveyor

@jakzal try the symfony-hosted one https://github.com/phpspec/phpspec/pull/1201/files

@ciaranmcnulty your suggestions seemed to've worked 🍺

great!


Incorrect value in PRAPI, when quantity is >1

Current behavior
Summary during 'Instant checkout' displays only single product price - even when quantity was set diffrently.  Other values (shipping, grand total) are displayed correctly.
Customer sees group of quotas and grand total, that does not match.

Expected behavior
Value displayed along with product name, should be calculated basen on quantity.
Steps to reproduce the issue

Add any product to cart with quantity > 1
Proceed t Instant checkout
Check displayd summary

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[x] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome
OS:  Win10

Hi @pkarw @ArturDivante @vishal-7037
I was testing this fix and I think that maybe we need a more complex solution.
There are two more situations where prices visible in the Instant Checkout Order summary are still different than in the cart, so again the customer sees a group of amounts and grand total, that does not match:
1. When an item has a reduced price due to some cart discount rule or discount code added.
In this situation, the 'Discount' line appears and the full prices of the listed products are visible in the Instant Checkout summary.
For now 'Discount' shows value only from the net price without tax, so the discount of the tax is missing, to have the correct equation.
So we can solve this in two ways:
a. show reduced prices and hide discount line
b. show correct discount value (with tax)
Look out for reduced price in the cart (currently not correct calculation - #2892).
2. When customer provided in his Shipping Details a country for which the tax is not included.
The prices without tax are visible in the cart, but in Instant Checkout summary customer sees the full prices with the tax.

https://drive.google.com/file/d/16wo3fCXzgEIMJ-8RXnIuebO2fQ7Decve/view?usp=sharing

@qiqqq @patzick @pkarw
I tested changes on next and something is wrong again.
When I apply a discount code (mmtest - 50%) -> price visible next to the product is correct (it contains tax already) but in the Instant Checkout, the product price has tax value doubled.
Maybe this fix #2892 has not been taken into account.
We should show the same reduced price in the instant checkout as in the cart.

Fixed


FIX Imagick installer for travis and php 5.3

Fixes the imagick installer for PHP 5.3

See #5153

"properly" he says. :P

:P


Ring Ground filter wrong segmentation

Follow-up from PR #655:
I tried the code on this bag: http://db3.ertl.jp/autoware/sample_data/sample_moriyama_150324.tar.gz using these commands:
$ rosbag play sample_moriyama_150324.bag
$ rosrun points_preprocessor ground_filter _sensor_model:=32
$ rosrun rviz rviz

Then I added blue point cloud as ground and red point cloud as non ground. From the attached screenshot you will see that blue point reach densely up to 0.5m above the ground and some sparse blue points are also way above the ground. So I'd conclude that the algorithm doesn't quite work correctly yet.

Hi @dejanpan
I used the same commands and got the following results:

There are a lot of mistakes.
The performance of ray ground filter is worse:

Do you have any suggestion? I used the default parameters.


Project dependencies not working when using an authentication setup

I'm trying to implement authentication setup using a project dependency as it is shown in this doc https://playwright.dev/docs/auth
So for that I've created an auth.setup.ts file that includes the loging process and then I configured the playwright.config.ts with:
  projects: [
    {
      name: 'setup',
      testMatch: '**/*setup.ts'
    },
    {
      name: 'Regresion tests using chromium',
      dependencies: ['setup'],
      use: {
        ...devices['Desktop Chrome'],
        storageState: STORAGE_STATE,
      },
    },

When I run my test cases I get this error:
Error: Error reading storage state from myprojectdir\.auth\user.json: ENOENT: no such file or directory
It seems that the project-dependency is not triggered.

In my setup it is working, seems you have some problems with the path of the json.
Do you have these lines in the beginning of the config file, in your case for STORAGE_STATE

After Login is successfull and you wait for some element to be visible you store the session right?

Do you see the json file being created after you login the first time?

@NikkTod yeah, I have export const STORAGE_STATE = path.join(__dirname, '.auth/user.json');
but when I run the tests I'm just getting this error
Error: Error reading storage state from myprojectdir\.auth\user.json: ENOENT: no such file or directory
nothing else. Actually, the user.json, where is suppose to be stored the state, never gets to be created.
it seems that my auth.setup.ts is never triggered:

import { test as setup } from '@playwright/test';
import { STORAGE_STATE } from './playwright.config';

setup('authenticate', async ({ page }) => {
    await page.goto('https://myapp/');
    await page.locator('a', { hasText: 'External Identities'} ).click();
    await page.getByPlaceholder('Email Address').fill('****');
    await page.getByPlaceholder('Password').fill('***');
    await page.getByRole('button', { name: 'Sign in' }).click();
    await page.context().storageState({ path: STORAGE_STATE });
});

Dependencies don't work if require or import is identical in both projects. I have a repo where steps are more general, used by a couple of features and unfortunately, it is just not working.
I made a quick PoC, and copy all my general steps to another folder, so I have steps/ and steps-copy/, and by changing import (or require) in the second project it started to work, but I feel its not the best practise to have duplicated steps.

Thank you @Ridd0 I will check.
Reopening this issue.

Fixed in v4.0.0.
@Ridd0 @jzaratei could you re-check on<EMAIL_ADDRESS>and share the results?

I though this issue was close, so, I created a new one https://github.com/vitalets/playwright-bdd/issues/39 with the results


Allow to run specific test's scenario

This allows to run specific test' testcase, e.g. nplusone, 2nd testset
Tested with
# Run all testsets
$ docker run -e SMASHBOX_TEST_NAME=hello3 owncloud/smashbox

# Specify custom testset configuration via options
$ docker run -e SMASHBOX_TEST_OPTIONS="-o hello3_B=10"  -e SMASHBOX_TEST_NAME=hello3 owncloud/smashbox

# Specify specific testset
$ docker run -e SMASHBOX_TEST_OPTIONS="-t 1"  -e SMASHBOX_TEST_NAME=hello3 owncloud/smashbox

@tboerger @patrickjahns

And directly after submiting my review I realized that this change is not needed at all, you can already define specific tests with the env variable SMASHBOX_TEST_NAME, so just add -e SMASHBOX_TEST_NAME=nplusone, you can already see exactly that within https://github.com/owncloud/smashbox-testing/blob/master/.drone.yml#L47-L60

@tboerger it is not about test (name), it is about test's testcase, e.g. test #1 of nplusone

@tboerger Updated the README

The rest of the pr is also not needed, it's executing -a, but the env variable defines which tests are getting copied into a new directory where it's executing with the -a flag...
If I remember correctly you have integrated this copy and general -a execution.

@tboerger there is a difference between running -a and -t #scenario. If you specify all, you cannot simply run specific scenarios, and this is what this PR is about..

Than your specific cp magic applied months ago destroyed the behavior, before it was possible to define nplusone@2

@tboerger could you point me to PR? Not sure if I follow.

We had a chat about that, let's define the testset via an env variable like SMASHBOX_TESTSET, if this is set execute only the defined set, if it's not set just keep the -a.

@tboerger @patrickjahns please have a look in the top description - I updated it (https://github.com/owncloud-docker/smashbox/pull/11#issue-197824242)

@tboerger addressed your comments

@tboerger is it ok now?

@mrow4a Is this change still required?

@TheOneRing do you know something about this? Can we close it?

@TheOneRing do you know something about this? Can we close it?

No idea but I assume we can close it.


Dualcast fix o4s.js

Changed comments from Decisive Battle to Dualcast

Thanks for the clarification! I think it is much clearer now.


[trivial] Fix tx breaking change when NDEBUG is undefined

Codecov Report

Merging #2164 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2164      +/-   ##
===========================================
- Coverage    69.01%   68.99%   -0.03%
===========================================
  Files          684      684
  Lines        50468    50468
===========================================
- Hits         34833    34818      -15
- Misses       15635    15650      +15

Impacted Files
Coverage Δ

src/ripple/app/paths/impl/StrandFlow.h
89.81% <0%> (ø)
:arrow_up:

src/ripple/app/misc/detail/WorkBase.h
69.81% <0%> (-11.33%)
:arrow_down:

src/ripple/basics/DecayingSample.h
77.77% <0%> (-8.34%)
:arrow_down:

src/ripple/app/ledger/PendingSaves.h
93.54% <0%> (-6.46%)
:arrow_down:

src/ripple/beast/asio/io_latency_probe.h
97.01% <0%> (-1.5%)
:arrow_down:

src/ripple/app/misc/SHAMapStoreImp.cpp
78.86% <0%> (-1.04%)
:arrow_down:

src/ripple/app/misc/impl/ValidatorSite.cpp
78.47% <0%> (-0.7%)
:arrow_down:

src/ripple/server/impl/BaseWSPeer.h
67.5% <0%> (-0.63%)
:arrow_down:

src/ripple/app/ledger/impl/LedgerMaster.cpp
44.04% <0%> (-0.23%)
:arrow_down:

src/ripple/server/impl/BaseHTTPPeer.h
89.93% <0%> (+3.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0d482...cec81de. Read the comment docs.

Merged as 7abd70356d320bb2c258ba81f579daa066cca8b3


分页有一个特殊场景sql解析错误，会直接抛出异常

场景是 sql 的where条件中 例如 a = "a" , 当左边属性列有concat等函数时 使用 zebre的sql解析工具解析时强转sqlName错误，原类型未SQLMethodInvokeExpr 非SQLName

来信已收到，谢谢~~

Hello, we tried to solve the issue.
This is what we did:
Modified the DefaultSQLRewrite class to handle cases where the left-hand side of a condition contains functions like concat. This prevents the casting error when encountering SQLMethodInvokeExpr instead of SQLName.
You can review changes in this commit: https://github.com/kkpo4553/Meituan-Dianping-Zebra-113/commit/585d47868859c320795a313c017ddc856b11ef6b.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.


istioctl proxy-config lookup localhost on <IP_ADDRESS>:53: no such host

Bug description
When executing any of the proxy-config commands - have error saying:
$ istioctl proxy-config cluster productpage-v1-6b746f74dc-cjlxw
Error: failed to execute command on productpage-v1-6b746f74dc-cjlxw.default sidecar: failure running port forward process: Get "http://localhost:44217/config_dump": dial tcp: lookup localhost on <IP_ADDRESS>:53: no such host

Reproduced on an AWS EKS and local minikube clusters.
Looks line istioctl proxy-config going to the locally configured DNS on a workstation instead on the pod.
My resolv.conf has Google DNS set:
$ cat /etc/resolv.conf
# Generated by resolvconf
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
istioctl proxy-config must return dump from a pod's local Envoy.
Steps to reproduce the bug

spin up a minicube cluster
install the Bookinfo app from the Getting Started guide
issue any of the istioctl proxy-config

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
$ istioctl version --remote
client version: 1.9.1
control plane version: 1.9.1
data plane version: 1.9.1 (8 proxies)

How was Istio installed?
istioctl install --set profile=demo -y
Environment where the bug was observed (cloud vendor, OS, etc)

minikube
AWS EKS

I think its a reasonable expectation that localhost resolves. You should have something like
$ cat /etc/hosts
<IP_ADDRESS>        localhost

This will break a lot of other apps if you don't do this (source: I had the same issue with other apps :slightly_smiling_face: )

OMG! Thanks a lot, @howardjohn!
Didn't even thought about that.
Yeah, checked my /etc/hosts and I had no <IP_ADDRESS> localhost in there.
After adding - everything works as expected.


[ci:component:github.com/gardener/etcd-backup-restore:0.7.3->0.8.0]

Release Notes:
Fix the error handling in revision consistency check leading to restoration on valid etcd data directory.

Fix the object listing for OSS snapstore

Added TLS support for backup-restore server. TLS can be enabled by passing the paths to both TLS cert and key PEM-format files via `--server-cert` and `--server-key` flags.

Defragmentation schedule can be configured now in cron standards using flag `defragmentation-schedule`. :warning: Removed the flag `defragmentation-period-hours`.

:warning: Removed the flag `delta-snapshot-period-seconds`. Instead use replacement flag `delta-snapshot-period` with input value format supported by golang `time.Duration`.

:warning: Removed the flag `garbage-collection-period-seconds`. Instead use replacement flag `garbage-collection-period` with input value format supported by golang `time.Duration`.

Expose new metric `etcdbr_snapshot_required`.

Expose http API to trigger out-of-schedule delta snapshot.

[Fix] Cleanup in-memory events before stopping snapshotter.

Added documentation for restoration.

Added negative tests for restoration of snapshots.

Performance regression tests can be executed using the `make perf-regression-test` target against the Kubernetes cluster pointed to by the environment variable PERF_TEST_KUBECONFIG.

Closing in favor of https://github.com/gardener/gardener/pull/1762.