is there a specification for determining the most accurate OLC for a place?

Addresses are traditionally references to physical places rather than physical locations, and it seems the goal of OLC is to serve as addresses.
Has any work been done on a specification/process/algorithm to determine the correct level of precision for a given place; and, to determine the most accurate/canonical OLC for a place that may be ambiguous - for instance, it relatively equally crosses two OLC boundaries at a level, but going smaller means that there are multiple OLC s that could address it equally well.
Mainly, my concern is how to make sure that any generation of OLCs from existing cadastre/parcel data will result in a single canonical and non-ambiguous OLC for each place.

There are some ideas floating around, but I don't think that any of it has been strictly specified.
One aspect is the precision necessary and useful to properly address a real-world location. Less than 10 digits means that the resulting area is often too big to be useful - 12 or more might easily be more precise than necessary (see also #190). That leaves 10- or 11-digit codes, probably shortened to a "XXXX+XX[X], City" format. For what it's worth, Google Maps displays the 10-digit variant, which could be considered a statement towards those.
Other than that, an idea that has been brought up in the past is to use the OLC closest to the relevant entrance, or the door bell, or mail box, so that potential visitors (or the postman, if OLC is used as a mailing address) end up in a sensible place.
I wonder, does cadastre data even regularly include data like exact locations of main entrances or, more generally speaking, useful "points of contact"?

You can have a single, canonical and non-ambiguous OLC for a place - but that doesn't mean it's useful. :-(
For example, you could us the 10-digit OLC that contains the center point. Does that make sense for the Boeing factory? Maybe - it all depends on what you're trying to do with it.
An alternative is to say "the largest OLC that fits within the polygon (or bounding box?) that contains the center point". That will give you a sense of size, but for small buildings it may go to 11 or 12 digits. (This could be a good thing depending on your point of view.)
I'm mostly interested in the applications around addressing, directions, access, so I tend to go for the 10-digit code that is nearest the entrance (if known) or the building center. I'm personally cautious about using additional digits simply because I don't believe most consumer GNSS devices are that precise, although additional digits may have their place to disambiguate buildings that are small and near each other.
For a cadastre or land parcel, you may want one code that gives you the center, but you may also want to compute a covering of codes to provide a definition of the area.
There is some work done by the Pacific Northwest National Laboratory in the US around using it for building IDs.

@bocops cadastre data doesn't normally contain building footprints, at least globally; even in the USA, it's very rare.  It definitely doesn't contain any door/etc points.
The precision question is a bit easier - either from a parcel or (satellite or in person) building footprint, it can be specified as the largest precision that completely fits within the boundaries; or perhaps the smallest precision that completely encloses at least 50% of a parcel/building, but not 50% of any other (just examples - this is what I'm thinking on currently).
@drinckes and usefulness is part of what I'm looking for.  I'm interested in exploring ideas for how to determine which OLC, at what precision, best describes a place that something might be delivered to.  To that end, I see two possibly "best" locations:

designating the building
designating the nearest intersection to a street.

I'd like to find a way to avoid duplicate OLCs for a place; even if it's as simple as "the OLC that most contains the building and no other"; something that can be generated either via a computer with parcel/building footprints, or via a person on-location.

This issue raises: "is there a specification..."
The answer is that no, we do not have such a specification and it appears that there is not an appetite to add such a specification to the Open Location Code specification.
Recommending to close this issue as resolved.

I accept that recommendation @fulldecent  :-)


add controllers callbacks

About "Loop bound injection" error in "Code scanning results / CodeQL" check
We don't use .length property from object, we use array
So I think it's false positive


PHOENIX-6173 Archive test artifacts in Jenkins multibranch postcommit…

… job

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m  1s
There were no new shelldocs issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

1m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-911/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/911

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux b672ff115c47 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 10ef717

Max. process+thread count
48 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-911/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.7.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
shelldocs
0m  1s
There were no new shelldocs issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

1m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-911/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/911

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux f6f160bd7741 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 10ef717

Max. process+thread count
47 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-911/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.7.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

+1


Binary Tree ZigZag Level Order Traversal

@ashavijit Can I work on this issue

@harshita9621 go!

@avijitsen7076 Is this repo part of Hacktoberfest

@avijitsen7076 Is this repo part of Hacktoberfest

yup!

@avijitsen7076  i want to work on this problem , please assign me this problem

@avijitsen7076 assign me too


CRI: Register metadata store types by definitions

Closes https://github.com/containerd/containerd/issues/8669
Register the types by their definitions so if any outside clients want to unmarshal they'll run the registration.

Perhaps we can move these types elsewhere, or rethink them a little for 2.0, but for a 1.7 backport this seems reasonable.

LGTM, It looks like it would be good to register in the type definition, unless some other caller of the package wants to register another url path, but that seems unlikely to happen

Perhaps we can move these types elsewhere
The other alternative would be to move the Metadata type out of the CRI sandbox store to a more common package along with the typeurl registration.

Metadata is coupled to cri, if not in pkg/cri, do you have any ideas?

Metadata is coupled to cri, if not in pkg/cri, do you have any ideas?

That's basically where I left off in my train of thought. I couldn't think of anywhere to move it as it really only makes sense in CRI land, but perhaps we can rework what structures we pass around in general for 2.0.


purge-with-truncate option fix

Previously to this commit, the option "purge-with-truncate" seems didn't worked as InputArgv::hasOption always return true for all defined options even if option is not passed from CLI.
UPD: .idea removed from commit

Thanks for the patch @rznzippy. There's only the two errors to fix, nevermind the failure I'm fixing that in another PR.

Done, thanks @rznzippy


[BUG]The client's background is being spammed with error logs.

Firstly, this is an issue that can only be reproduced on the server; I have not encountered the same error logs in local gameplay.
When the client connects to a server with the Apotheosis mod loaded, the output log is spammed with errors. The keyword to look for is:
[023月2024 02:56:03.029] [Render thread/WARN] [net.minecraft.client.multiplayer.ClientPacketListener/]: Entity Bat['蝙蝠'/346, l='ClientLevel', x=31.88, y=3.64, z=-52.98] does not have attribute null
[023月2024 02:56:03.029] [Render thread/ERROR] [net.minecraft.util.thread.BlockableEventLoop/FATAL]: Error executing task on Client
java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.ai.attributes.AttributeInstance.m_22135_()" because "inst" is null
	at net.minecraft.client.multiplayer.ClientPacketListener.handler$zzj000$apoth_postAttrChangedEvent(ClientPacketListener.java:2571) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_7710_(ClientPacketListener.java:2222) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAttributesPacket.m_5797_(ClientboundUpdateAttributesPacket.java:59) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.network.protocol.game.ClientboundUpdateAttributesPacket.m_5797_(ClientboundUpdateAttributesPacket.java:15) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.client.multiplayer.ClientPacketListener.m_264308_(ClientPacketListener.java:2305) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.network.protocol.game.ClientboundBundlePacket.m_5797_(ClientboundBundlePacket.java:13) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.network.protocol.game.ClientboundBundlePacket.m_5797_(ClientboundBundlePacket.java:6) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.network.protocol.PacketUtils.m_263899_(PacketUtils.java:22) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:156) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:130) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:115) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1106) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23164!/:?]
	at net.minecraft.client.main.Main.main(Main.java:218) ~[Karoglan-TFC-Create.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.2.20.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.2.20.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.2.20.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
	at oolloo.jlw.Wrapper.invokeMain(Wrapper.java:71) ~[?:?]
	at oolloo.jlw.Wrapper.main(Wrapper.java:51) ~[?:?]

I have noticed the keyword apoth_postAttrChangedEvent. Is this an exception triggered by Apotheosis? Although I have not yet observed any impact on the gaming experience, I believe it could potentially have negative effects on the game's performance. If possible, I hope this issue can be resolved.
The full log is as follows: https://gist.github.com/Tollainmear/55ab2093566e44f6f42afaca7c2333e6
Envinfo:

Mc 1.20.1
ForgeVer 47.2.20

Modlist:

Apotheosis-1.20.1-7.3.1
Placebo-1.20.1-8.6.1
Patchouli-1.20.1-84-FORGE
ApothicAttributes-1.20.1-1.2.1

Codec failure for type affixes, message: Unknown registry key in ResourceKey[minecraft:root / minecraft:attribute]: forge:step_height
outdated datapack files?
the attribute should be named forge:step_height_addition
you need to fix these:
affix: apotheosis:armor/attribute/elastic
gem: apotheosis:core/solar
gem: apotheosis:overworld/royalty

The code path you are seeing a NPE in is already guarded by a null check at the injection site:
for(ClientboundUpdateAttributesPacket.AttributeSnapshot clientboundupdateattributespacket$attributesnapshot : pPacket.getValues()) {
    AttributeInstance attributeinstance = attributemap.getInstance(clientboundupdateattributespacket$attributesnapshot.getAttribute());
    if (attributeinstance == null) {
        LOGGER.warn("Entity {} does not have attribute {}", entity, BuiltInRegistries.ATTRIBUTE.getKey(clientboundupdateattributespacket$attributesnapshot.getAttribute()));
    } else {
        attributeinstance.setBaseValue(clientboundupdateattributespacket$attributesnapshot.getBase());
        attributeinstance.removeModifiers();
       // First injection point
       for(AttributeModifier attributemodifier : clientboundupdateattributespacket$attributesnapshot.getModifiers()) {
           attributeinstance.addTransientModifier(attributemodifier);
       }
       // Second injection point
   }
}

You may have another mod applying a mixin to the same site, causing my injection to be incorrect, but since you have only provided the latest.log I cannot investigate further.  I need at the very least the debug.log file, or a mixin debug export of the ClientPacketListener class.

The code path you are seeing a NPE in is already guarded by a null check at the injection site:
for(ClientboundUpdateAttributesPacket.AttributeSnapshot clientboundupdateattributespacket$attributesnapshot : pPacket.getValues()) {
    AttributeInstance attributeinstance = attributemap.getInstance(clientboundupdateattributespacket$attributesnapshot.getAttribute());
    if (attributeinstance == null) {
        LOGGER.warn("Entity {} does not have attribute {}", entity, BuiltInRegistries.ATTRIBUTE.getKey(clientboundupdateattributespacket$attributesnapshot.getAttribute()));
    } else {
        attributeinstance.setBaseValue(clientboundupdateattributespacket$attributesnapshot.getBase());
        attributeinstance.removeModifiers();
       // First injection point
       for(AttributeModifier attributemodifier : clientboundupdateattributespacket$attributesnapshot.getModifiers()) {
           attributeinstance.addTransientModifier(attributemodifier);
       }
       // Second injection point
   }
}

You may have another mod applying a mixin to the same site, causing my injection to be incorrect, but since you have only provided the latest.log I cannot investigate further. I need at the very least the debug.log file, or a mixin debug export of the ClientPacketListener class.

Hi, here is my latest.log and debug.log file.
latest on gist
debug on gist
File:debug.log
File:latest.log

Based on the debug log, the only other mod with a mixin into ClientPacketListener is nochatreports, which doesn't mixin into this method (handleUpdateAttributes).  So the only thing that I can potentially look at is a mixin debug export of ClientPacketListener.
To retrieve this, you will need to launch with -Dmixin.debug.export=true and -Dmixin.debug.export.filter=ClientPacketListener.  The generated file will then be in your <instance>/.mixin.out/ folder.

Based on the debug log, the only other mod with a mixin into ClientPacketListener is nochatreports, which doesn't mixin into this method (handleUpdateAttributes). So the only thing that I can potentially look at is a mixin debug export of ClientPacketListener.
To retrieve this, you will need to launch with -Dmixin.debug.export=true and -Dmixin.debug.export.filter=ClientPacketListener. The generated file will then be in your <instance>/.mixin.out/ folder.

Hello, thank you for your patient help. I followed the method you mentioned and added the corresponding parameters to my MC's startup parameters. However, I did not find the mixin.out folder you mentioned anywhere. Here are the parameter sets of the startup script I used. Did I do something wrong?
-XX:+UseG1GC -XX:-UseAdaptiveSizePolicy -XX:+ExplicitGCInvokesConcurrent -XX:-OmitStackTraceInFastThrow -Dfml.ignoreInvalidMinecraftCertificates=True -Dfml.ignorePatchDiscrepancies=True -Dlog4j2.formatMsgNoLookups=true -Dmixin.debug.export=true -Dmixin.debug.export.filter=ClientPacketListener

The syntax for the filter is not exactly specified (at https://github.com/SpongePowered/Mixin/wiki/Mixin-Java-System-Properties) It may need to be =ClientPacketListener.class instead of =ClientPacketListener
Alternatively you can drop the entire -Dmixin.debug.export.filter=ClientPacketListener argument. It will cause all mixin classes to be exported (and may take a while), but the ClientPacketListener export will be there.

Hi, thanks again for your help. After trying to replace =ClientPacketListener with =ClientPacketListener.class, I still didn't find mixin.out anywhere. However, when I dropped the entire -Dmixin.debug.export.filter=ClientPacketListener field as you said, Mixin.out appeared. I found ClientPacketListener.class there. Considering that you may need other class files and to avoid omissions, I have packaged this directory. I hope this can resolve the issue this time.
I think the class path is
.mixin.out\class\net\minecraft\client\multiplayer\ClientPacketListener.class
.mixin.out.zip

The only differences in the bytecode are the absence of
     140: new           #4874               // class org/spongepowered/asm/mixin/injection/callback/CallbackInfo
     143: dup
     144: ldc_w         #4875               // String handleUpdateAttributes
     147: iconst_0
     148: invokespecial #4878               // Method org/spongepowered/asm/mixin/injection/callback/CallbackInfo."<init>":(Ljava/lang/String;Z)V

which has been replaced with 140: aconst_null (probably due to an optimization eliding CallbackInfo when unnecessary) - this will not cause the issue we are seeing here.
The injection point is still within the loop, as it is still before the final goto in both cases.
Ah, hell, wait a second.  I've realized there isn't an explicit continue statement in the if-block, which means the jump isn't to the head of the loop, but rather to the end.
This means if the modifier is null it will still hit my hook, so I need to account for that there.
This does mean something weird is going on - which looking back at the logs, something exceptionally weird is going on, because the attribute is null.  This means a ClientboundUpdateAttributesPacket is being sent with attributes the client has no knowledge of whatsoever, which typically would indicate a screwed up instance (or at the very least a mod mismatch where something is absent from the client).
I can add in a nullcheck, but your instance is broken.  You should double check that all mods are present on both sides of the server/client.

Hi there, have the same problem and its VERY annoying cuz the server logs will be massive. Can't afford this mod in modpack until there will be a fix. PLEASE PLEASE fix it, I don't want to delete your mod from modpack, it's so big and usefull

This is an external problem, even if I nullcheck on my end, you will still be spammed by the vanilla log message (below) until you fix the issues with your game instance.
[023月2024 02:56:03.029] [Render thread/WARN] [net.minecraft.client.multiplayer.ClientPacketListener/]: Entity Bat['蝙蝠'/346, l='ClientLevel', x=31.88, y=3.64, z=-52.98] does not have attribute null


Concept database test

Motivation

Along with the UI test, database test is to be introduced.
Proposed Solution

TBD
Alternatives

User Story

Additional Context

Related to #2583
Design Requirements

I think this task can be basically closed, since we already actively use database checks in our tests.
Not sure if anything else can to be done as part of this task.
But feel free to re-open it and object :)


Added ts-auto-mock

refactored tasks.test to make reuse easier

Minor changes need after #94, So this PR will wait.


Extension to India forests

Hi,
I like to contribute to the project. Can we extend it to Indian forests or any other forest regions

Yeah sure, you or anyone interested in extending the work with me and can mail me on<EMAIL_ADDRESS>we can discuss there how can we proceed.


Add support for Python 3.10

Prerequisites

[X] I checked the documentation and made sure this feature does not already exist.
[X] I checked the existing issues to make sure this feature has not already been requested.
[X] I have read the code of conduct before creating this issue.

Problem
No response
Feature / Solution
Add support for Python 3.10
Alternatives
No response
Additional Context
No response

There is an existing PR on this #83. This PR was created a while back and needs updating.

A new PR now addresses this issue #236

PR merged


Ability to pass quiet and verbose options to parseAndGenerate function.

As title say I think need to add ability to pass quiet and verbose options to parseAndGenerate function.

Hi,
Added in latest commit, will be released in next few days. Thanks for idea!

Big thanks!

Hi,
Added in latest commit, will be released in next few days. Thanks for idea!

Any news about new release?

@dmitryk-sfx 1.4.0 is released


[BUG]: Conflict with Lobe Theme

Is there an existing issue for this?

[X] I have searched the existing issues

Bug Description
Not sure on which end (this or theirs) the issue lies.
Lobe Theme ((https://github.com/canisminor1990/sd-webui-lobe-theme/)) is a modern restyling of the Automatic 1111 UI
Normally when I install an extension, it just goes in the main window in its own row like normal.
However, when Better Styles  is open, nothing under better styles is accessible until you close it.
Things work, if i generate, it will, but i cant see the generation until I close better styles.
Steps to Reproduce
Install Lobe Theme
Screenshot (optional)
Expected behavior -

What actually happens

Better Styles adds content within an existing container, but it seems to be conflicting with the modified CSS of the Lobe Theme, resulting in this situation. To fix this issue, I will add Better Styles as an independent container.

This issue has been resolved with the 1.4.0 update.


Error:com.android.builder.internal.aapt.AaptException: Failed to crunch file

Error:com.android.builder.internal.aapt.AaptException: Failed to crunch file C:\Users\jason\AndroidStudioProjects\ud851-Exercises-student\ud851-Exercises-student\Lesson01-Favorite-Toys\T01.01-Exercise-CreateLayout\app\build\intermediates\exploded-aar\com.android.support\appcompat-v7\24.1.1\res\drawable-hdpi-v4\abc_ic_star_half_black_48dp.png into C:\Users\jason\AndroidStudioProjects\ud851-Exercises-student\ud851-Exercises-student\Lesson01-Favorite-Toys\T01.01-Exercise-CreateLayout\app\build\intermediates\res\merged\debug\drawable-hdpi-v4\abc_ic_star_half_black_48dp.png

http://stackoverflow.com/questions/30764604/execution-failed-for-task-appmergedebugresources-crunching-cruncher-png-fa

I believe the error is because the path name is greater than 240 characters. I fixed the problem by adding an option to the build.gradle project file "buildDir = "C:/tmp/${rootProject.name}/${project.name}"
http://stackoverflow.com/questions/39621250/how-to-fix-com-android-builder-internal-aapt-aaptexception-failed-to-crunch-fil

Again, the path character length limit.
Maybe that is one of the reasons why many developers turn to Mac.

Go to build.gradle project file and the buildDir goes under the allprojects section
`// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:2.2.3'
    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}
allprojects {
buildDir = "C:/tmp/${rootProject.name}/${project.name}"
repositories {
jcenter()
}
}
task clean(type: Delete) {
delete rootProject.buildDir
}`

If anyone is watching this, I pushed what I think should be a fix to the lesson 2 exercises. Anyone want to give 'em a try?

Should be fixed by https://github.com/udacity/ud851-Exercises/commit/ca3e7db67b100f17a77532416225ef2838447760

HI Jeremy, the problem seems fixed

Does this problem apply to mac?


Would it be possible to make install source configurable?

Fedora and EL7 both have support for installing JJB as RPMs. Is this something you'd be open for in this module?

I'm happy to have this feature.

+1

I will be getting to this.. :)

This should be fixed with #20


Update GenerateResourcesAndImage.ps1

Ubuntu2004 is also a valid option for parameter ImageType
Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@miketimofeev since we have a template for Ubuntu16 in our repo, I'd rather leave this as a valid option until we remove it in September.


ability to automate discreet iam policies

Note: WIP!
Currently arc-create creates a role (named arc-role) which gives broad access to Dynamo, S3 and SNS.
This is a great default and has worked wonderfully for a very long time.
However, it should be possible to grant or limit permissions on a lambda by lambda basis. For example, maybe you want to lock a lambda down to a policy that is read only or perhaps you want to opt a lambda into new permissions for another AWS service such as SES.

This should be an additive change (non breaking)
We will want this to be a standalone workflow command for reading, verifying and synchronizing policies
Security is important: this cannot be unclear in any way
Custom roles are defined in src/iam such as src/iam/role-name.json
Roles are applied using .arc-config
npx iam lists lambdas and their associated roles (or missing roles)
npx iam apply ensures everything is in sync

Example .arc-config
@aws
timeout 30000
memory 512
role my-custom-role # expects src/iam/my-custom-role.json to exist

shipped! as npx audit


Use Unicode Identifier and Pattern Syntax classes

See https://unicode.org/reports/tr31/
Use

ID_Start / ID_Continue (X?)
Pattern_Whitespace
instead of the current implementation

Resolved by 4ea6fdc993d372e5dd32ada8459fb2820e44283d


Display alias target on 'cargo help `

Previously, `cargo help <alias>` resolved the alias and displayed the
help for the targeted subcommand. For example, if `br` were aliased to
`build --release`, `cargo help br` would display the manpage for
cargo-build.

With this patch, it will print "'br' is aliased to 'build --release'".

Addresses issue #10138.
This is my first patch to Cargo. I attempted to follow the style of the surrounding code. Please let me know if any changes are required: happy to make them. In particular, I wasn't sure if any tests exist for this path.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
Please see the contribution instructions for more information.

Aha, found the test location! I'll fix that up.

One good UX option here may be to show the manpage if the alias is a simple command, e.g., b = build, but show the alias if it's a more complicated command, e.g., br = build --release. That would perhaps be the least surprising change, while still servicing the needs of users who define more complicated aliases. I'll wait for feedback on what direction you'd like to take.

@bors: r+
Seems reasonable to me, thanks!

:pushpin: Commit 4c66d183611d9104fecb79da14e2dce46869e286 has been approved by alexcrichton

:hourglass: Testing commit 4c66d183611d9104fecb79da14e2dce46869e286 with merge c689f55b8c795435b23a17ec0d4ca7e05d66aba1...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing c689f55b8c795435b23a17ec0d4ca7e05d66aba1 to master...

Thank you @sstangl !


Idempotent constructor

Would be nice if ndarray could take any ndarray-ish object and automatically coerce it to an ndarray.  For example, if you feed it any object with data,shape,stride,offset properties, it should convert it into an ndarray with the correct interface automatically.

Pros:

This would allow for a new pattern where libraries construct ndarrays immediately, thus protecting themselves from possible API breakages and ensuring stability
It would also simplify the problem of marshalling ndarrays, since a plain old JS object could be directly converted with this style.
It would not break backwards compatibility in any existing ndarray code.

Cons:

This is a minor version bump, and would break the promise of freezing the API

In lieu of this, is there a nice clean already-existing way to serialize/deserialize an ndarray? It looks possible to make one with something like typedarray-to-buffer, but I'd rather not if it already exists.


Typechecking capabilities are dramatically reduced in v0.3

Ever since StateObject:get was removed, typechecking became essentially useless. More specifically, the T in StateObject<T> is used nowhere, meaning that any StateObject can be cast to any other StateObject, even if their types are invalid.
This drastically reduces the capabilities to guard against developer mistakes. When working in v0.2, I was frequently saved headaches by type errors warning me that I inserted an incompatible state object. Now, every StateObject is basically treated as if the type it stores is any.
Here are examples of things that would have given errors in v0.2, but now give nothing, even in strict mode.
local foo: Fusion.Value<boolean> = Value("foo")
local bar: Fusion.StateObject<number> = Computed(function()
	return "bar"
end)
local baz: number = peek(Value("baz")) -- In v0.2 this would be Value("baz"):get()

The second line of this would even give an error in nonstrict mode.
local foobar: Fusion.Value<boolean> = Value("foobar")
local foobaz: Fusion.Value<string> = foobar

To fix this, something inside the StateObject<T> type must use T. Since no functions make use of it, probably the only way to fix this would be a fake property that contains the type.
export type StateObject<T> = Dependency & {
	type: "State",
	kind: string,
	_typeIdentifier: T
}

Or perhaps a function that takes never, so that luau will give a typechecker warning if someone mistakenly tries to use it.
export type StateObject<T> = Dependency & {
	type: "State",
	kind: string,
	_typeIdentifier: (never) -> T
}

I've noticed this in my own Fusion codebases. I'll take a look into these solutions here.


"Help" fairseq now is support transformer_from_pretrained_xlm and I found it is not compatible for pretrained_xlm checkpoint

is it support to load a pretrained xlm model or Not? or it is means using fairseq pretrain a xlm model and load ?

I meet the similar problem. And I'm testing the latest code for transformer_from_pretrained_xlm.

Any updates on this?

Yes this is for loading an already trained XLM model.  Please open a new issue following the issue template if you are still having problems.


Poudriere validates wrong (system default) ports tree upon 'testport'

Prerequisites

[X] Have you checked for an existing issue describing your problem?
[X] Are you running the latest version?
[X] Is your ports tree recent?
[X] Is your FreeBSD Host on a supported release?

Describe the bug
Consider the following:
# poudriere ports -l
PORTSTREE    METHOD    TIMESTAMP           PATH
default      git       2021-11-30 10:54:18 /var/poudriere/ports/default
default-head git       2021-11-30 10:54:18 /var/poudriere/ports/default-head
ldadw-custom svn+https 2021-11-30 10:56:25 /var/poudriere/ports/ldadw-custom
michael-o    git       2021-11-30 10:54:18 /var/poudriere/ports/michael-o
root@deblndw011x:/var/poudriere/ports/default-head (pr-272541 *)
# git status
On branch pr-272541
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   Mk/Uses/ghostscript.mk
        modified:   print/ghostscript10/Makefile

no changes added to commit (use "git add" and/or "git commit -a"

now lets test the port:
root@deblndw011x:/usr/local/etc/poudriere.d
# poudriere -vv testport -j 124-release-amd64 -p default-head -i print/ghostscript10
=>> Debug: Reading /usr/local/etc/poudriere.conf
[00:00:00] Creating the reference jail... done
[00:00:13] Mounting system devices for 124-release-amd64-default-head
[00:00:13] Warning: Using packages from previously failed, or uncommitted, build: /var/poudriere/data/packages/124-release-amd64-default-head/.building
[00:00:13] Mounting ports from: /var/poudriere/ports/default-head
[00:00:13] Mounting packages from: /var/poudriere/data/packages/124-release-amd64-default-head
[00:00:13] Mounting distfiles from: /usr/ports/distfiles
[00:00:13] Copying /var/db/ports from: /usr/local/etc/poudriere.d/124-release-amd64-default-head-options
[00:00:13] Appending to make.conf: /usr/local/etc/poudriere.d/124-release-amd64-default-head-make.conf
/etc/resolv.conf -> /var/poudriere/data/.m/124-release-amd64-default-head/ref/etc/resolv.conf
[00:00:13] Starting jail 124-release-amd64-default-head
[00:00:13] Will build as nobody:nobody (65534:65534)
[00:00:14] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:14] Inspecting ports tree for modifications to git checkout... yes
[00:00:15] Ports top-level git hash: 6ffebb1e6505 (dirty)
make: "/usr/ports/print/ghostscript10/Makefile" line 52: Malformed conditional (${FLAVOR} == default)
make: "/usr/ports/print/ghostscript10/Makefile" line 55: Malformed conditional (${FLAVOR} == x11)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/print/ghostscript10
[00:00:15] Error: Port is broken
[00:00:15] Cleaning up
[00:00:16] Unmounting file systems
Exiting with status 1

Yes, I have shredded /usr/ports/print/ghostscript10/Makefile because I did nagivate to the wrong dir, then stopped and moved to default-head. It is suprising that /usr/ports is touched at all since I have suppied a separate ports tree.
Fixing /usr/ports and retrying:
root@deblndw011x:/var/poudriere/ports/default-head (pr-272541 *)
# gitup ports
# Scanning local repository...
# Host: git.freebsd.org
# Port: 443
# Proxy Host: de.coia.siemens.net
# Proxy Port: 9400
# Repository Path: /ports.git
# Target Directory: /usr/ports
# Have: c2432e318536e2c98d555e29d14faa705d73bbec
# Want: 9370aa5524f43224d8f8c49e2a1c8a32b500cf3f
# Branch: 2023Q3
 ! /usr/ports/ftp/curl/Makefile has been modified.
 ! /usr/ports/print/ghostscript10/Makefile has been modified.
# Action: repair
 * /usr/ports/ftp/curl/Makefile
 * /usr/ports/print/ghostscript10/Makefile
# The local repository has been repaired.  Please rerun gitup to pull the latest commit.
# Done.
root@deblndw011x:/var/poudriere/ports/default-head (pr-272541 *)
# gitup ports
# Scanning local repository...
# Host: git.freebsd.org
# Port: 443
# Proxy Host: de.coia.siemens.net
# Proxy Port: 9400
# Repository Path: /ports.git
# Target Directory: /usr/ports
# Have: c2432e318536e2c98d555e29d14faa705d73bbec
# Want: 9370aa5524f43224d8f8c49e2a1c8a32b500cf3f
# Branch: 2023Q3
# Action: pull
 * /usr/ports/archivers/p5-Gzip-Faster/Makefile
 * /usr/ports/audio/gnome-podcasts/Makefile
 * /usr/ports/audio/mumble/Makefile
 * /usr/ports/audio/mumble/distinfo
...
root@deblndw011x:/var/poudriere/ports/default-head (pr-272541 *)
# poudriere testport -j 124-release-amd64 -p default-head -i print/ghostscript10
[00:00:00] Creating the reference jail... done
[00:00:13] Mounting system devices for 124-release-amd64-default-head
[00:00:13] Warning: Using packages from previously failed, or uncommitted, build: /var/poudriere/data/packages/124-release-amd64-default-head/.building
[00:00:13] Mounting ports from: /var/poudriere/ports/default-head
[00:00:13] Mounting packages from: /var/poudriere/data/packages/124-release-amd64-default-head
[00:00:13] Mounting distfiles from: /usr/ports/distfiles
[00:00:13] Copying /var/db/ports from: /usr/local/etc/poudriere.d/124-release-amd64-default-head-options
[00:00:13] Appending to make.conf: /usr/local/etc/poudriere.d/124-release-amd64-default-head-make.conf
/etc/resolv.conf -> /var/poudriere/data/.m/124-release-amd64-default-head/ref/etc/resolv.conf
[00:00:13] Starting jail 124-release-amd64-default-head
[00:00:13] Will build as nobody:nobody (65534:65534)
[00:00:14] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:14] Inspecting ports tree for modifications to git checkout... yes
[00:00:23] Ports top-level git hash: 6ffebb1e6505 (dirty)
make: "/usr/ports/print/ghostscript10/Makefile" line 52: Malformed conditional (${FLAVOR} == default)
make: "/usr/ports/print/ghostscript10/Makefile" line 55: Malformed conditional (${FLAVOR} == x11)
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/print/ghostscript10
[00:00:23] Error: Port is broken
[00:00:23] Cleaning up
[00:00:23] Unmounting file systems
Exiting with status 1

Still does not work. Then I fixed /var/poudriere/ports/default-head/print/ghostscript10/Makefile:
root@deblndw011x:/var/poudriere/ports/default-head (pr-272541 *)
# poudriere testport -j 124-release-amd64 -p default-head -i print/ghostscript10
[00:00:00] Creating the reference jail... done
[00:00:13] Mounting system devices for 124-release-amd64-default-head
[00:00:13] Warning: Using packages from previously failed, or uncommitted, build: /var/poudriere/data/packages/124-release-amd64-default-head/.building
[00:00:13] Mounting ports from: /var/poudriere/ports/default-head
[00:00:13] Mounting packages from: /var/poudriere/data/packages/124-release-amd64-default-head
[00:00:13] Mounting distfiles from: /usr/ports/distfiles
[00:00:13] Copying /var/db/ports from: /usr/local/etc/poudriere.d/124-release-amd64-default-head-options
[00:00:13] Appending to make.conf: /usr/local/etc/poudriere.d/124-release-amd64-default-head-make.conf
/etc/resolv.conf -> /var/poudriere/data/.m/124-release-amd64-default-head/ref/etc/resolv.conf
[00:00:13] Starting jail 124-release-amd64-default-head
[00:00:13] Will build as nobody:nobody (65534:65534)
[00:00:14] Ports supports: FLAVORS SELECTED_OPTIONS
[00:00:14] Inspecting ports tree for modifications to git checkout... yes
[00:00:15] Ports top-level git hash: 6ffebb1e6505 (dirty)
[00:00:16] Logs: /var/poudriere/data/logs/bulk/124-release-amd64-default-head/2023-08-31T12:24:50
[00:00:16] Loading MOVED for /var/poudriere/data/.m/124-release-amd64-default-head/ref/usr/ports
[00:00:16] Gathering ports metadata
[00:00:17] Calculating ports order and dependencies
[00:00:18] Trimming IGNORED and blacklisted ports
[00:00:19] Sanity checking the repository
[00:00:19] Checking packages for incremental rebuild needs
[00:00:19] Deleting glib-2.76.4,2.pkg: new version: 2.76.4_1,2
[00:00:19] Deleting jpeg-turbo-<IP_ADDRESS>.pkg: new version: 3.0.0
...

So as far as I can see the correct tree is examined, but the output is wrong.
Expected behavior
To continue w/o touching /usr/ports at all!
Environment

Host OS [e.g. 12.2 amd64]: 12.4-STABLE 55b79ced0 amd64
Jail OS [e.g. 12.0 powerpc]: 124-release-amd64
Poudriere Version [e.g. 3.3.1 or git hash or port version]:  poudriere-git-<IP_ADDRESS>20831
Ports branch and revision [e.g. 2020Q3 r550754]: HEAD

Looking at this again and the poudriere source, I believe that my report is bogus since the output applies to the jail where the tree is of course, by default, in /usr/ports and not the jailhost.

Closing because I was wrong.


API details page is 404

Describe the bug
Hey, awesome work! but please can you fix the 404 on page:
https://tanstack.com/router/v1/docs/api/core
would be helpful to read and understand each function specs.
Thanks
Your Example Website or App
https://tanstack.com/router/v1/docs/api/core
Steps to Reproduce the Bug or Issue

go to https://tanstack.com/router/v1/docs/api/core

Expected behavior
none
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]
Any.

Additional context
No response

Docs are getting fixed now. Thanks!


Automated Package Upgrade

:tada: This PR is included in version 9.0.36 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[ic-side-navigation]: Review component in relation to PR checklist

Summary
A revised checklist has been added to the PR summary which lists actions to be performed on any updates to a component. This ticket is to review the list and apply any updates to side navigation that are required.
💬 Description
Review side navigation in relation to new PR checklist to prep for further updates. For current components, this approach may be useful as it will streamline any new PRs and keep any ticketed updates in scope:
Full list of PR checks:

[ ] Relevant unit tests and visual regression tests added.
[ ] Visual testing against Figma component specification completed.
[ ] All acceptance criteria reviewed and met.
[ ] Accessibility Insights FastPass performed.
[ ] A11y unit test added and yields no issues.
[ ] A11y plug-in on Storybook yields no issues.
[ ] Manual screen reader testing performed using NVDA and VoiceOver.
[ ] Page can be zoomed to 400% with no loss of content.
[ ] Screen magnifier used with no issues.
[ ] Text resized to 200% with no loss of content.
[ ] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
[ ] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[ ] Windows High Contrast mode tested with no loss of content.
[ ] System light and dark mode tested with no loss of content.
[ ] Manual keyboard testing for keyboard controls and logical focus order.
[ ] Min/max content examples tested with no loss of content or overflow.
[ ] Browser support tested (Chrome, Safari, Firefox and Edge).
[ ] Correct roles used and ARIA attributes used correctly where required.
[ ] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
[ ] All prop combinations work without issue.

💰 Use value
This preps the side navigation for any further work without the work falling out of scope due to a high number of changes related to the PR checklist.
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given as a developer working on the side navigation component
When I create a PR with bug fixes and updates
Then the ticket will stay in scope and not contain more updates relevant to the PR checklist
✏ Designs
N/A
## 🧾 Guidance
N/A
Additional info
Tell us anything else useful to help us understand your suggestion.

Do we have an issue for every component?

Create an epic for this

Done as part of epic #1817


engine "node" is incompatible with this module

error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "~0.6.9".
error Found incompatible module
Maybe you should open this up to all future node version.  Works under v0.12.7.

Closed out by #4


Move plot legends to top (on zoom)

Compliments #3228.
Related to https://github.com/iterative/vscode-dvc/issues/3226
Demo
https://user-images.githubusercontent.com/37993418/216891284-55ee9552-21a1-428f-9858-26216aba6016.mov

Can we test it on 7 selected experiments? I'm worried that legend won't look good / can take too much space.

Can we test it on 7 selected experiments? I'm worried that legend won't look good / can take too much space.

No longer like the change

Did test changing the direction to horizontal too:


convert args to env

fixes a crash back off loop that happens

Thanks for fixing this. Forgot to update this when changing agones-mc.

 Thanks for publishing the repo. I've been looking for someone like this for a while


Add missed css_class to TabHolder template

PR to fix Issue #178
Now we can use css_class TabHolder attribute to add css classes to html element. For example:
adding  "justify-content-center" css class to TabHolder gives this result:
<form method="post">

          One

          Two

...

Thanks @kosdmit  -- I pushed a change to the tests. If you could let me know that you are happy with these I can then merge this.

If you could let me know that you are happy with these I can then merge this.

I think it's done well, we can do the merge.


add highlights for 2022-10-06

This Weeks Highlights PR

all good from Phoenix

No updates from Hydra.

added contribution from honeybadger


Add Eclipse Maven repos to all projects

Failed to execute goal on project oauth.sample: Could not resolve dependencies for project org.eclipse.lyo.server:oauth.sample:war:0.0.1-SNAPSHOT: The following artifacts could not be resolved: org.eclipse.lyo.server:oauth-webapp:war:2.3.0, org.eclipse.lyo.server:oauth-core:jar:2.3.0, org.eclipse.lyo.server:oauth-consumer-store:jar:2.3.0: Could not find artifact org.eclipse.lyo.server:oauth-webapp:war:2.3.0 in central (repo.maven.apache.org/maven2) -> [Help 1]

All CI builds are passing


Cherrypick for fixing ACK header IE related bugs

Revert hotfix from PR: https://github.com/nrfconnect/sdk-zephyr/pull/1441
Fix bugs in current implementation of ieee802154 driver:

after refactoring set_vendor_ie_header_lm, case when link_metrics_data_len == 0 has been ignored. Fixed by refactoring the code again.
Resetting RCP stack by openthread has been handled incorrectly (-ENOTSUP returned). Fixed by implementing otPlatRadioResetCsl in upstream OpenThread and adding clear_ie flag.
refactoring of enh ACK header IE resulted with returning -ENOTSUP when ack_ie.header_ie == NULL (set when csl period set to 0 in otPlatRadioEnableCsl), because
ieee802154_header_ie_get_element_id accessed NULL pointer.
struct ieee802154_config config is a struct containing an union. Members of config were accessed incorrectly in otPlatRadioEnableCsl. Fixed by initializing config with 0 and accessing one member at a time.

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

openthread
https://github.com/zephyrproject-rtos/openthread/commit/00076aff3ae571db7c90509ec9dc293457098c35
https://github.com/zephyrproject-rtos/openthread/commit/7761b81d23b10b3d5ee21b8504c67535cde10896 (main)
<EMAIL_ADDRESS>

Note: This message is automatically posted and updated by the Manifest GitHub Action.

It seems that the commit message of the revert refers to maciejbaczmanski@1da00e0 instead of 1da00e0. Please correct it to keep a valid reference to the commit in the future.
Other than that - lovely 👍

that's weird because commit message does not contain any remote references:

I'll change the commit message to a full link


Fix: Prevent exception when parsing request port in ServeCommand

Summary
This PR fixes an issue where php artisan serve throws an exception on Windows when a log line does not contain a valid request port.
Problem
"process forking is not supported" when running the "artisan serve", and the flushOutputBuffer method tries to parse invalid lines. This raises the exception
Solution

Added a guard condition to check if the line contains the expected keywords (Accepted, Closing) before calling getRequestPortFromLine.
Ensured no exception is thrown for invalid lines.

Changes Made

Updated flushOutputBuffer method in ServeCommand.php:

Added contains() checks for specific keywords.
Skipped port parsing for invalid lines.

How to Test

Run php artisan serve.
Verify that no exception occurs when invalid lines are logged.
Check that server output behaves as expected.

Mark as draft since it has a merge conflict.

This error is caused by the change from #53887. Which has been reverted in Release 11.36.1.
In the PR behaviour was changed by pulling out the common logic of getting the port from a line.
Which, previously was behind if-statements.
This PR might not be necessary if #53887 is adjusted so that the


Let App Bar swipe away when scrolling down

This could be achieved by using the new design support library

Use CoordinatorLayout from Design Support Library: http://android-developers.blogspot.de/2015/05/android-design-support-library.html

@bjrne This is on your list, isnt it

[x] Use CoordinatorLayout
[x] Make AppBar scrollable
[x] Use TabLayout (see #22)

Implemented in /feature/design-support.
Known issues (hopefully fixed by Google soon):

WebView doesn't support NestedScrollView or implements NestedScrollingChild, workaround is implemented with NestedScrollWebView. Scroll behavior isn't 100% perfect anymore with that, but it's acceptable.
EditText in NestedScrollWebView with open keyboard blocks full scrolling. #182362

TODO:

[ ] Change tab background in offline mode
[ ] Make sure Cast MiniController widget is visible in all screens


feat(pilot): ability to set hostname in gateway status

Please provide a description of this PR:
Addresses: https://github.com/istio/istio/issues/44230
When trying to use a Gateway API gateway type on AWS Istio is not able to update its status field with the hostname of the load balancer, with the error status.addresses[0].value in body must be of type ipv4: "k8s-istioing-gatewaya-xxxxxxx-xxxxxxx.elb.us-east-1.amazonaws.com", which causes problems for things like external-dns. This is because Istio always tries to set the address as type IP. This PR adds some parsing so that Istio can (hopefully) set the correct address type in the Gateway status. I'm not sure if this is the correct approach, since it might be possible to use the Kubernetes service status type as that already contains this information as well. Also some unit tests should be added for this but due to my limited time I haven't been able to look at that yet.

Hi @DavidSpek. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Closing this as https://github.com/istio/istio/pull/46815 implemented the change.


Change docs / website from usage of componentReferences to references

Description
There is a difference between v2 and v3, where in v2 componentReferences and in v3 references is used. Since we want to switch to v3 as the default, the documents used in OCM CLI help texts and the OCM website need to be corrected.
Related and dependent on https://github.com/open-component-model/ocm-project/issues/262
Done Criteria

[ ] Internal technical Documentation updated
[ ] Enduser Documentation updated

not required as fe only support v2 in the future


How to control compression quality

With default option, the compression result is poor that it doesn't fulfill my need. Kindly assist if there is any parameter to tweak to achieve some better quality of compression.

For image compression, i think we can enable the option for you to enter your own compression format. Google recently released new specification for compression of images and we would be adding that as well next.

I also need this feature. I want to control the compression quality. With default compression, video output quality is very poor.

Any update on controlling the compression quality ?

With default option, the compression result is poor that it doesn't fulfill my need. Kindly assist if there is any parameter to tweak to achieve some better quality of compression.

did find any solution ?


Fallback to CPU when encoding is not supported for JSON reader

Falllback to CPU when encoding is not UTF-8 or US-ASCII

build


Add Workers tagging API methods

Today we must use a Raw request to add tags to Workers scripts; this implements it as a native Go API call.
Description
Supports both namespace and unnamespaced Workers.
Has your change been tested?
Yes, as we implemented it similarly ourselves
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

Codecov Report

Merging #1354 (19e7d09) into master (b9ac804) will increase coverage by 0.14%.
Report is 102 commits behind head on master.
The diff coverage is 57.10%.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   48.33%   48.48%   +0.14%
==========================================
  Files         133      135       +2
  Lines       13023    13227     +204
==========================================
+ Hits         6295     6413     +118
- Misses       5201     5257      +56
- Partials     1527     1557      +30

Files Changed
Coverage Δ

access_application.go
72.72% <ø> (ø)

access_organization.go
53.84% <ø> (ø)

device_posture_rule.go
61.80% <ø> (ø)

load_balancing.go
59.40% <ø> (ø)

teams_accounts.go
53.84% <ø> (ø)

regional_tiered_cache.go
43.75% <43.75%> (ø)

logpush.go
51.81% <46.15%> (-0.30%)
:arrow_down:

workers.go
57.74% <46.42%> (-1.72%)
:arrow_down:

images.go
44.70% <47.82%> (-0.12%)
:arrow_down:

access_custom_page.go
48.27% <48.27%> (ø)

... and 6 more

superseded by other PRs that add dispatch namespaces and tagging for Workers.


Fix BottomNavigationBar can not apply some theme property

Description
Removed the default value in the constructor so that the value in the theme can take effect. At the same time, some documentation errors were corrected and some redundant codes were removed.
Related Issues
Fixes  #66738
Tests
See files.

I saw a PR #67342 repeatedly fixed this bug, I will close this PR, thanks.


photoprism: thinks assests location is read-only filesystem

Describe the bug
Since photoprism is now packages for NixOS I wanted to try it out. However I can't get it to run. Frist it complains about various folder not being able to create. I created them manually and then added 0777 permissions (for testing). However for the serial it complained about not being able to create it. So I created it also and made it 0777. It complains now about read-only file sysem.
Steps To Reproduce
Steps to reproduce the behavior:

Enable photoprism; I use config like:

    # Photoprism
    services.photoprism = {
        enable = true;
        storagePath = "/data/photoprism";
        settings = {
            PHOTOPRISM_ADMIN_USER = "admin";
            PHOTOPRISM_ADMIN_PASSWORD = "some_super_secret_password";  # will change the password file later
            PHOTOPRISM_DEFAULT_LOCALE = "en";
        };
        port = 2342;
        originalsPath = "/data/Pictures";
    };

Create the /data/photoprism folder (owner: root, permissions 0777)
Create the ``/data/Pictures` folder (owner: root, permissions 0777)
Rebuild, check systemd status:
It will complain about lots of folder. Create them (owner: root, permissions 0777):

[root@servi:/data/photoprism]# ls -al
total 69
drwxrwxrwx  8 root root  9 Feb 24 19:27 .
drwxrwxrwx 14 root root 14 Feb 24 19:17 ..
drwxrwxrwx  2 root root  2 Feb 24 19:24 albums
drwxrwxrwx  2 root root  2 Feb 24 19:15 backup
drwxrwxrwx  4 root root  4 Feb 24 19:22 cache
drwxrwxrwx  3 root root  3 Feb 24 19:23 config
-rwxrwxrwx  1 root root  0 Feb 24 19:27 serial
drwxrwxrwx  2 root root  2 Feb 24 19:22 sidecar
drwxrwxrwx  2 root root  2 Feb 24 19:14 users

(There's a few subfolders....)

After creating all the folders, it complaind about the serial file. So I crated it with permissions 0777 also. However it keeps complaining about it:

systemctl status photoprism.service
○ photoprism.service - Photoprism server
     Loaded: loaded (/etc/systemd/system/photoprism.service; enabled; preset: enabled)
     Active: inactive (dead) since Fri 2023-02-24 19:38:59 CET; 227ms ago
   Duration: 5.873s
    Process: 70178 ExecStartPre=/nix/store/xq4wj07fpk5ib3c9gsrrlfxa7mgswnh8-unit-script-photoprism-pre-start/bin/photoprism-pre-start (code=exited, status=0/SUCCESS)
    Process: 70292 ExecStart=/nix/store/1775l2920q58manppsgsx0byyarcyy44-unit-script-photoprism-start/bin/photoprism-start (code=exited, status=0/SUCCESS)
   Main PID: 70292 (code=exited, status=0/SUCCESS)
         IP: 0B in, 0B out
        CPU: 11.803s

Feb 24 19:38:47 servi systemd[1]: Starting Photoprism server...
Feb 24 19:38:53 servi photoprism-pre-start[70178]: time="2023-02-24T19:38:53+01:00" level=error msg="could not create /data/photoprism/serial: open /data/photoprism/serial: read-only file system"
Feb 24 19:38:53 servi systemd[1]: Started Photoprism server.
Feb 24 19:38:59 servi photoprism-start[70292]: time="2023-02-24T19:38:59+01:00" level=error msg="could not create /data/photoprism/serial: open /data/photoprism/serial: read-only file system"
Feb 24 19:38:59 servi systemd[1]: photoprism.service: Deactivated successfully.
Feb 24 19:38:59 servi systemd[1]: photoprism.service: Consumed 11.803s CPU time, no IP traffic.

Obviously it's not a read-only filesystem, otherwise I would not have been about to create the folders and the serial file.
I have no idea under which user photoprism is to run and also no idea why it keeps complaining that it can't create folders and now that it's a read-only file system.
Notify maintainers
@BeneSim
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 5.15.94, NixOS, 23.05 (Stoat), 23.05pre456790.988cc958c57
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.13.2
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

I'm not the maintainer of photoprism - you probably meant to ping @BeneSim

I'm not the maintainer of photoprism - you probably meant to ping @BeneSim

Sorry :(

Hi, while its true that I'm the maintainer of photoprism I wasn't actually involved in the creation or review of the nixos module nor did I ever use it since. The nixos module has been thankfully contributed by @Stunkymonkey who is also the maintainer for the module.
That being said, giving the config a quick glance I'd imagine that it has something to do with the DynamicUser Option https://github.com/NixOS/nixpkgs/blob/b3e65bf87264517e573eb3cd9c4bdb7b7ed7dd22/nixos/modules/services/web-apps/photoprism.nix#L103 which is very restrictive. Particular when it comes to writing to the filesystem.
From my perspective the only way to write the state is using the StateDirectory directive which must be relative (to /var/lib) and is currently hardcoded to photoprism https://github.com/NixOS/nixpkgs/blob/b3e65bf87264517e573eb3cd9c4bdb7b7ed7dd22/nixos/modules/services/web-apps/photoprism.nix#L104 .
So if I'm not mistaken settings of storagePath other than /var/lib/photoprism or maybe something below that root shouldn't work at the moment.
I guess this could be fixed by adding cfg.storagePath to ReadWritePaths, however then we would need to deal with the UID/GID recycling of DynamicUser. We could remove the cfg.storagePath, I suppose you're always free to mount whatever you want to /var/lib/photoprism be it a btrfs subvolume or a bind mount or something similar.
Maybe @Stunkymonkey has some more insights what the issue might be or how to properly fix it.

I suppose you're always free to mount whatever you want to /var/lib/photoprism be it a btrfs subvolume or a bind mount or something similar.

I do not want to have extra datasets because that means I need one more dataset to setup in the backup job. So I figured out that it sets up /var/lib/photoprims as symlink to /var/lib/private/photoprism. Using your idea to mount whatever I tried now bind mount:
  fileSystems."/var/lib/private/photoprism" =
    { device = "/data/photoprism";
      options = [ "bind" ];
    };

That works. However it would still be nice to use the storagePath option as that is given in the module.

Ok, I was able to fix most of the things. However still can't get it to run properly:
    # Photoprism
    services.photoprism = {
        enable = true;
        settings = {
            PHOTOPRISM_ADMIN_USER = "admin";
            PHOTOPRISM_ADMIN_PASSWORD = "xxx";
            PHOTOPRISM_DEFAULT_LOCALE = "en";
            PHOTOPRISM_DATABASE_DRIVER = "mysql";
            PHOTOPRISM_DATABASE_NAME = "photoprism";
            PHOTOPRISM_DATABASE_SERVER = "/run/mysqld/mysqld.sock";
            PHOTOPRISM_DATABASE_USER = "photoprism";
            PHOTOPRISM_SITE_URL = "http://sub.domain.tld:2342";
        };
        port = 2342;
        originalsPath = "/data/photoprism";
        address = "localhost";
    };

    # Enable nginx
    services.nginx = {
        enable = true;
        recommendedTlsSettings = true;
        recommendedOptimisation = true;
        recommendedGzipSettings = true;
        recommendedProxySettings = true;
        clientMaxBodySize = "500m";
        virtualHosts."sub.domain.tld" = {
            forceSSL = true;
            sslCertificate = "/data/ssl/https-cert.pem";
            sslCertificateKey = "/data/ssl/https-key.pem";
            http2 = true;
            locations."/" = {
                proxyPass = "http://<IP_ADDRESS>:2342";
                extraConfig = ''
                    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                    proxy_buffering off;
                    proxy_http_version 1.1;
                    proxy_set_header Upgrade $http_upgrade;
                    proxy_set_header Connection "upgrade";
                '';
            };
        };
    };

    # MySQL
    services.mysql = {
        enable = true;
        dataDir = "/data/mysql";
        package = pkgs.mariadb;
        ensureDatabases = [ "photoprism" ];
        ensureUsers = [ {
            name = "photoprism";
            ensurePermissions = {
                "photoprism.*" = "ALL PRIVILEGES";
            };
        } ];
    };

With this, photoprism runs nicely, websockets from nginx to photoprism also works and it uses mariadb as backend. Couldn't get it to work with sqlite.
However I still can't upload anything because it keeps complainging about the originalsPath:
Feb 25 18:06:47 dns photoprism-start[1753]: 2023-02-25 18:06:47.244588: I tensorflow/cc/saved_model/reader.cc:31] Reading SavedModel from: /nix/store/8icxb6iy5xx0pxvap7gamdp6jzkk05jd-photoprism-221118-e58fee0fb/share/photoprism/nsfw
Feb 25 18:06:47 dns photoprism-start[1753]: 2023-02-25 18:06:47.275476: I tensorflow/cc/saved_model/reader.cc:54] Reading meta graph with tags { serve }
Feb 25 18:06:47 dns photoprism-start[1753]: 2023-02-25 18:06:47.298521: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2
Feb 25 18:06:47 dns photoprism-start[1753]: 2023-02-25 18:06:47.368260: I tensorflow/cc/saved_model/loader.cc:202] Restoring SavedModel bundle.
Feb 25 18:06:48 dns photoprism-start[1753]: 2023-02-25 18:06:48.131627: I tensorflow/cc/saved_model/loader.cc:311] SavedModel load for tags { serve }; Status: success. Took 887388 microseconds.
Feb 25 18:06:48 dns photoprism-start[1753]: time="2023-02-25T18:06:48+01:00" level=info msg="nsfw: loading labels from labels.txt"
Feb 25 18:06:48 dns photoprism-start[1753]: time="2023-02-25T18:06:48+01:00" level=info msg="1 files uploaded in 1 s"
Feb 25 18:06:48 dns photoprism-start[1753]: time="2023-02-25T18:06:48+01:00" level=info msg="processing upload..."
Feb 25 18:06:48 dns photoprism-start[1753]: time="2023-02-25T18:06:48+01:00" level=info msg="classify: loading nasnet"
Feb 25 18:06:48 dns photoprism-start[1753]: 2023-02-25 18:06:48.926523: I tensorflow/cc/saved_model/reader.cc:31] Reading SavedModel from: /nix/store/8icxb6iy5xx0pxvap7gamdp6jzkk05jd-photoprism-221118-e58fee0fb/share/photoprism/nasnet
Feb 25 18:06:49 dns photoprism-start[1753]: 2023-02-25 18:06:49.445677: I tensorflow/cc/saved_model/reader.cc:54] Reading meta graph with tags { photoprism }
Feb 25 18:06:50 dns photoprism-start[1753]: 2023-02-25 18:06:50.640208: I tensorflow/cc/saved_model/loader.cc:202] Restoring SavedModel bundle.
Feb 25 18:06:54 dns photoprism-start[1753]: 2023-02-25 18:06:54.599362: I tensorflow/cc/saved_model/loader.cc:311] SavedModel load for tags { photoprism }; Status: success. Took 5672843 microseconds.
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="classify: loading labels from labels.txt"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="import: found no .ppignore file"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="import: added folder /var/lib/photoprism/users/urqn81c18l2y5ks1/upload/sessdgqupwadnc5v9s"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="media: IMG_20230205_135937[1].jpg was taken at 2023-02-05 12:59:37 +0000 UTC (meta)"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=error msg="import: failed creating folder for IMG_20230205_135937[1].jpg (mkdir /data/Pictures/2023: read-only file system)"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="import: moving main jpg file IMG_20230205_135937[1].jpg to 2023/02/20230205_125937_B6B2A015.jpg"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=warning msg="import: failed moving file to 2023/02/20230205_125937_B6B2A015.jpg, is another import running at the same time?"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=error msg="import: no such file or directory in 2023/02/20230205_125937_B6B2A015.jpg"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="upload: imported 2 files"
Feb 25 18:06:55 dns photoprism-start[1753]: time="2023-02-25T18:06:55+01:00" level=info msg="upload has been processed"

It complains again about read-only filesystem.
[root@dns:/data]# ls -al
total 45
drwxr-xr-x  9 root        root         9 Feb 25 17:02 .
drwxr-xr-x 17 root        root        17 Feb 25 18:05 ..
drwxr-xr-x  3 adguardhome adguardhome  4 Feb 25 18:05 AdGuardHome
drwx------  7 mysql       mysql       17 Feb 25 18:05 mysql
drwxr-xr-x  9 photoprism  photoprism  12 Feb 25 18:06 photoprism
drwxrwxrwx  2 photoprism  photoprism   2 Feb 25 11:07 Pictures
drwx------  2 root        root         2 Feb 24 18:03 private
drwx------  2 root        root         6 Feb 24 17:26 ssh
drwxr-xr-x  2 root        root         5 Feb 25 17:02 ssl

I tried with the same bind trick as for the photoprism.StoragePath. Creating a folder in /data/Pictures then bind it to /var/lib/private/Pictures and also tried to bind it to /var/lib/Pictures. No luck with either of them.

sorry for responding so late. I am currently short on time.
the upload of photos into the GUI was never tested by myself, because I am using syncthing for getting images into photoprism.
I guess the problem comes with:
DynamicUser = true;

I guess you can create an overlay to set it to false and see if it works.

Well, I "fixed" it meanwhile using bind mount, see https://nixos.wiki/wiki/PhotoPrism#Storing_user_data_in_specific_location . Still, if there's an option given for location it should work.

I've run into this bug too. I'll add that DynamicUsers=true also stops the photoprism-manage script created by the module in the storagePath directory from doing anything useful, even when run by the photoprism user, since only the transient user created by systemd is able to access any of the directories this script is meant to operate on. So, for instance, "./photoprism-manage index [path]" fails because everything under the storage path is read-only for the photoprism user. Even when executed as root the script fails (I don't fully understand why). Feel free to let me know if I should open a separate issue for this.

sorry for responding so late. I am currently short on time. the upload of photos into the GUI was never tested by myself, because I am using syncthing for getting images into photoprism.
I guess the problem comes with:
DynamicUser = true;

I guess you can create an overlay to set it to false and see if it works.

Thanks for the hint, works for me now:
  systemd.services.photoprism.serviceConfig.DynamicUser = lib.mkForce false;
  users.users.photoprism = {
    group = "photoprism";
    isSystemUser = true;
  };
  users.groups.photoprism = { };

Is there any way to run cli?

@katyo please go to /var/lib/photoprism and try the photoprism-manage. But I did not use it for a long time.

@katyo please go to /var/lib/photoprism and try the photoprism-manage. But I did not use it for a long time.

I already tried that but it does not works for me.
Mariadb rejects connection from 'photoprism'@'localhost' because I run it not as a 'photoprism' user (root or myself).

@katyo I remembered:
sudo nsenter -t 467850 -m -S 64600 -G 64600 --wdns=/var/lib/photoprism /var/lib/photoprism/photoprism-manage faces reset

@Stunkymonkey Thank you so much!


Traffic are not all being route

Hi,
I install openvpn using the last script and got some issue when trying to access site or using local app.
I'm using ArchLinux on both client and server side.
Using my normal browser I can see than my IP got the server one (IPV4 or IPV6 are working)
On the server nothing was change same for client side.
I use the command openvpn sudo --config vpnfile.ovpn to connect to my vpn server.
When I try for example accesing site that are allowing only my IP or when I try use local app that allow my IP to access them it still use my local IP and not the one I openvpn assign me.
Is there something i need to change client side to force the use of tun0?

When you go on websites like https://www.ipalyzer.com/ or https://ipleak.net/ which IP do you see? The server's or your router's?
This should overwrite your gateway. What does ip route says?

This issue is something similiar to mine. When client connects to the VPN I the public ip changes as expected, but there are resources on the LAN which I want to get into remotely that do not respond. For example if I want to log into my freenas web interface I am unable to. Pings DO work but no other protocols seem to. Any thoughts? Is this just a routing issue?

I forgot to mention my goal for using this vpn is to have 1 encrypted link to my home lan so that I don't have to have ports forwarded too much. For things like nextcloud syncing and whatever else.


HDDS-10071. Merged TestContainerStateMachineIdempotency into TestContainerOperations

What changes were proposed in this pull request?
TestContainerStateMachineIdempotency has a single test case that spins up a 3 DN Mini Ozone cluster. Merged TestContainerStateMachineIdempotency into TestContainerOperations to make integration tests faster.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10071
How was this patch tested?
Test ran as part of integration (ozone) tests.

Thanks @SaketaChalamchala for the patch.


Renaming the library?

On the mailing list @pavel-kirienko asked me if I had a name for the library. I've used uavcan.rs (uavcan on crates.io) as a working title, do we want a more exotic name?
A lot of rust projects have cool names, some examples are:

Servo, a browser engine
Nom, a parser library.
Piston, a game engine.
Chrono, a time library.

It's also very common to use a highly descriptive name without any extensions. This would probably be the equivalent of sticking with the name uavcan.

FYI I took the liberty to register uavcan.rs. It's supposed to point to the implementation docs at uavcan.org, when they are ready.
Seems like a fair name to me, too.

That's awesome!
I'll leave the issue a little longer, but in my opinion, that pretty much settles it.

I don't see much reason leaving this open any longer. Uavcan.rs it is!


remove init inkey by id

let's just use initSrc. make only 1 path for mounting / unmounting to DOM.

consider manual dom el removal (which resets need to happen)

Removed the option in Algonaut config, but left FrameBus.ts untouched in case we decide to implement this functionality later.


Thanks! This file is generated so I'll also change it in the source.


Add animation utility to example_envs

Helps in decluttering the internals from the users.

Thanks much for the PR, @kaushikb11 ; makes a lot of sense. We have already added it to the repo folder here: https://github.com/salesforce/warp-drive/tree/master/example_envs/tag_continuous. So, I will go ahead and close this.


Tell the kernel to not group our screen updates together

Fixes #243

Haven't been able to test this with websockets yet, we'll see what happens in the next prod deploy


Create Dockerfile

Description
Creates a production Dockerfile which installs the dependencies of the app and deploys it to a gunicorn WSGI HTTP server.
Testing Instructions
Checkout the k8s-deployment branch in the DataGateway repo, the deployment/adding-docker-file-#1029 branch in the SciGateway repo and the configure-scigateway-auth-container branch in the ICAT k8s Deployment Config repo. Then configure the docker-compose.yml file and the configs of DataGateway, SciGateway and SciGateway Auth if needed, and run docker-compose build followed by docker-compose up.

[ ] Review code
[ ] Check GitHub Actions build
[ ] Review changes to test coverage
[ ] Successful installation
[ ] Successful server deployment
[ ] SciGateway should successfully communicate with SciGateway Auth (To test this, you should be able to login using with the root account).

Agile Board Tracking
closes #69

Will do
Alexander Kemp
Senior Research Software Engineer
Science and Technology Facilities Council
Rutherford Appleton Laboratory | OX11 0QX
@.***
[signature_944526895]
From: Viktor Bozhinov @.>
Date: Monday, 9 May 2022 at 14:46
To: ral-facilities/scigateway-auth @.>
Cc: Kemp, Alexander (STFC,RAL,SC) @.>, Mention @.>
Subject: Re: [ral-facilities/scigateway-auth] Create Dockerfile (PR #71)
@VKTB commented on this pull request.

In Dockerfilehttps://github.com/ral-facilities/scigateway-auth/pull/71#discussion_r868032383:

@@ -0,0 +1,24 @@

+# Dockerfile to build and serve scigateway-auth

+FROM python:3.6-alpine3.15
@moonraker595https://github.com/moonraker595 As already discussed earlier, the container was failing to build due to issues with the building and installation of the cryptography pip dependency. This was not the case when I opened this PR which is very confusing why it started doing this all of a sudden even on my machine.
I made some changes in b5f94cchttps://github.com/ral-facilities/scigateway-auth/pull/71/commits/b5f94cc22ccfae16284f568785ff66b1cbc93195 that fix this issue so could you please pull the latest changes on this branch and try to rebuild the container to see if it is happy on your machine?
—
Reply to this email directly, view it on GitHubhttps://github.com/ral-facilities/scigateway-auth/pull/71#discussion_r868032383, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFS6J3M25VFHFHLV2VIS2S3VJEJKDANCNFSM5VCGW5OA.
You are receiving this because you were mentioned.Message ID: @.***>
This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.


[Utils] Add PipedSpawnSync and PipedSpawnSyncStdout functions

This commit adds PipedSpawnSync and PipedSpawnSyncStdout functions and test cases.
ONE-vscode-DCO-1.0-Signed-off-by: Jiyoung Yun<EMAIL_ADDRESS>draft pr: #1329

/cc @hyunsik-yoon


VISTA-3D label.json file missing

Describe the bug
Not really a bug, but missing information in VISTA-3D bundle. The README.md file states: "We unified a global label index (docs/labels.json)", but this file cannot be found in bundle's subfolder "docs".
Could someone please add the labels.json file? Thanks in advance! :)

Hi @nvahmadi, the file will be downloaded automatically when you download the bundle, as it is stored within the large file.
You can find it here:
https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/large_files.yml#L6

Ah, apologies, I was looking for that file in the GitHub repo. Indeed, when I download the bundle, the file does show up. Thanks for the quick response. :)


Add self observability metrics for otel handler

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

Why is the latency percentile so huge? Did I do anything wrong?

Buckets of histogram should be as close as latency layout as possible. The the percentiles from buckets make the sense.

Looks like the latency is too huge indeed.
Please check the demo http://<IP_ADDRESS>/dashboard/SO11Y_OAP/ServiceInstance/ZGVtby1vYXAuc2t5d2Fsa2luZy1zaG93Y2FzZQ==.1/ZGVtby1vYXAuc2t5d2Fsa2luZy1zaG93Y2FzZQ==.1_ZGVtby1vYXAtNzY1NjdjNjhjZi1xZnE3ZA==/Self-Observability-OAP-Instance

Which buckets are you using? If last is 10ms, then over 10ms means max.int.

That percentile of histogram is not OAL percentile functions. Skywalking percentile in oal is auto adoptive, but otlp/Prometheus is predefined.

Could you share the latest dashboard of so11y? I think new are added into inbound traffic.

Could you share the latest dashboard of so11y? I think new are added into inbound traffic.

Please check the latest demo env, it was updated before those suggested comments.

http://<IP_ADDRESS>/dashboard/SO11Y_OAP/ServiceInstance/ZGVtby1vYXAuc2t5d2Fsa2luZy1zaG93Y2FzZQ==.1/ZGVtby1vYXAuc2t5d2Fsa2luZy1zaG93Y2FzZQ==.1_ZGVtby1vYXAtNzlkZjk0OWY1Yy1yZHN4Zg==/Self-Observability-OAP-Instance

Let's bring the latest to the showcase. We can check and see later. I hope the recent repeatable crashing will be fixed.


Something is broken in PowerShell 7 (in Get-ADUser?)

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to the known issues.

Steps to reproduce
Hello,
The following code, when run under PowerShell 7, is "broken".  But when it's run in PowerShell 5 (Windows Server 2016), it runs perfectly.
$employeeNumber = "000"
Get-ADUser -Filter {employeeNumber -eq $employeeNumber}  | select name
PowerShell 7 Version 7.1.3
The error message is
Get-ADUser: Variable: 'employeeNumber' found in expression: $employeeNumber is not defined.
I'll attach a screen shot to show the difference.
Expected behavior
Not broken and returns some AD users

Actual behavior
Error message:
Get-ADUser: Variable: 'employeeNumber' found in expression: $employeeNumber is not defined.

Environment data
Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

According to this https://docs.microsoft.com/en-us/powershell/module/activedirectory/get-aduser?view=windowsserver2019-ps -filter is of type string and not a scriptblock.
This works:
Get-ADUser -Filter "employeeNumber -eq '$employeeNumber'"

Check Get-Module ActiveDirectory; I suspect pwsh is loading it in a compatibility session, which will make it run inside a hidden PSv5.1 process and thus a separate environment than your actual pwsh session, so the variable won't be found. If it is, you'll see the ActiveDirectory module reported as a script module with (I think?) a version reported as 0.0.0 or similar.
You can try importing the module into pwsh directly with Import-Module ActiveDirectory -SkipEditionCheck and see if you get better results there. From memory, on newer servers the ActiveDirectory module has been updated and should auto-import correctly.
You may still have issues on a 2016 box, though, even with forcing the module to be imported; there were some outstanding bugs in the module running on .NET Core that needed to be fixed, if memory serves.
Another option is to ignore all of the above and simply change your filter syntax. As @Northman-de mentions, scriptblock syntax is (at best) a bit of a lie, and the documentation should never have been written that way IMO. The AD module converts it to a string and then re-parses the string manually looking for variables, which just flat out breaks around the edges. Changing the parameter syntax as they suggest should allow the values to be properly evaluated by pwsh instead of the AD module, and generally has a better success rate in general.

Windows 10 Build 14393 is from 2016 which is most likely not marked as comptaible with .NET core and as @vexx32 says it will load in an implicit remoting session. AFAIK it was in Server 2019 that the ActiveDirectory module was updated to support .NET Core and will run natively in PowerShell. Any of it's operations are run in a separate process and runspace and does not have access to any of your vars so it won't be able to find $employeeNumber when it converts that scriptblock to the LDAP filter.


Text Collection: Error while clicking around

Describe the bug
After adding multiple projects, one of them (NLT07) showed empty for Heb 1:1, but shows text after clicking on it.
After clicking some of them (NIV84, ESV16), the text collection ui blanked out and console error appeared on the console

renderer.js:2 TypeError: Cannot read properties of undefined (reading 'startsWith')
at index.js:1758:1
at Array.find ()
at Us (index.js:1757:1)
at ue.isValidMarker (index.js:2725:1)
at _o (index.js:3541:1)
at index.js:3718:1
at Array.forEach ()
at Mt (index.js:3698:1)
at Object.Al [as serializeEditorState] (index.js:3396:1)
at index.js:3074:1

On restarting Platform it shows up and then blanks out on its own again.
It does not break for: HEBGRK, HBKENG, HPUXK, PCM, NLT07
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

oh, just disovered that the root cause is an issue in the scripture editor. Will open an issue there...

root cause: https://github.com/BiblioNexus-Foundation/scripture-editors/issues/129


Capture Frame Action - Memory Leak

@rjhowell44, during my longer running tests I found that the capture-frame-action are causing memory leaks.  It seems that that the NVBufSurface stuff might not be cleaned up correctly.
Herewith screenshots showing jtop showing memory usage

Before running sample
Running sample with capture-frame action DISABLED
Running sample with capture-frame action ENABLED

This can be reproduced by the following sample.  Note that the trigger limit is set to 230, which will cause sluggishness when maxing out memory. Setting the limit to 250 starts writing buffer related errors to the console.
#!/usr/bin/env python

import sys
sys.path.insert(0, "../../")
from dsl import *
import os

uri_file = "../../test/streams/sample_1080p_h264.mp4"

# Filespecs for the Primary GIE
primary_infer_config_file = '../../test/configs/config_infer_primary_nano.txt'
primary_model_engine_file = '../../test/models/Primary_Detector_Nano/resnet10.caffemodel_b8_gpu0_fp16.engine'

PGIE_CLASS_ID_VEHICLE = 0
PGIE_CLASS_ID_BICYCLE = 1
PGIE_CLASS_ID_PERSON = 2
PGIE_CLASS_ID_ROADSIGN = 3

def xwindow_key_event_handler(key_string, client_data):
    """Function to be called on XWindow KeyRelease event"""

    print('key released = ', key_string)
    if key_string.upper() == 'P':
        dsl_pipeline_pause('pipeline')
    elif key_string.upper() == 'R':
        dsl_pipeline_play('pipeline')
    elif key_string.upper() == 'Q' or key_string == '' or key_string == '':
        dsl_main_loop_quit()

def xwindow_delete_event_handler(client_data):
    """Function to be called on XWindow Delete event"""

    print('delete window event')
    dsl_main_loop_quit()

def eos_event_listener(client_data):
    """Function to be called on End-of-Stream (EOS) event"""

    print('Pipeline EOS event')
    dsl_main_loop_quit()

def state_change_listener(old_state, new_state, client_data):
    """Function to be called on every change of Pipeline state"""

    print('previous state = ', old_state, ', new state = ', new_state)
    if new_state == DSL_STATE_PLAYING:
        dsl_pipeline_dump_to_dot('pipeline', "state-playing")

def main(args):

    # Since we're not using args, we can Let DSL initialize GST on first call
    while True:

        # New URI File Source using the filespec defined above
        retval = dsl_source_uri_new('uri-source', uri_file, False, 0, 0, 0)
        if retval != DSL_RETURN_SUCCESS:
            break

        # New Primary GIE using the filespecs above with interval = 0
        retval = dsl_gie_primary_new('primary-gie', primary_infer_config_file, primary_model_engine_file, 0)
        if retval != DSL_RETURN_SUCCESS:
            break

        # New KTL Tracker, setting max width and height of input frame
        retval = dsl_tracker_ktl_new('ktl-tracker', 480, 272)
        if retval != DSL_RETURN_SUCCESS:
            break

        # New Tiled Display, setting width and height, use default cols/rows set by source count
        retval = dsl_tiler_new('tiler', 1280, 720)
        if retval != DSL_RETURN_SUCCESS:
            break

         # Object Detection Event (ODE) Pad Probe Handler (PPH) to manage our ODE Triggers with their ODE Actions
        retval = dsl_pph_ode_new('ode-handler')
        if (retval != DSL_RETURN_SUCCESS):
            break

        # Add the ODE Pad Probe Hanlder to the Sink Pad of the Tiler
        retval = dsl_tiler_pph_add('tiler', 'ode-handler', DSL_PAD_SINK)
        if retval != DSL_RETURN_SUCCESS:
            break

        # Create occurrence trigger
        retval = dsl_ode_trigger_occurrence_new(
            'occurrence-trigger', source=DSL_ODE_ANY_SOURCE, class_id=PGIE_CLASS_ID_PERSON, limit=230)
        if (retval != DSL_RETURN_SUCCESS):
            break

        # Create capture-frame directory and action
        imageDir = './captures/'
        if not os.path.exists(imageDir):
            print(f'Creating directory {imageDir}')
            os.makedirs(imageDir)
        retval = dsl_ode_action_capture_frame_new('capture-frame', outdir=imageDir, annotate=True)
        if retval != DSL_RETURN_SUCCESS:
            break

        # Add the Actions to the trigger for this source.
        retval = dsl_ode_trigger_action_add('occurrence-trigger', action='capture-frame')
        if (retval != DSL_RETURN_SUCCESS):
            break

        # Add trigger to ODE handler
        retval = dsl_pph_ode_trigger_add('ode-handler', trigger='occurrence-trigger')
        if (retval != DSL_RETURN_SUCCESS):
            break

        # New OSD with clock enabled... .
        retval = dsl_osd_new('on-screen-display', True)
        if retval != DSL_RETURN_SUCCESS:
            break

        # New Window Sink, 0 x/y offsets and same dimensions as Tiled Display
        retval = dsl_sink_window_new('window-sink', 0, 0, 1280, 720)
        if retval != DSL_RETURN_SUCCESS:
            break

        # Add all the components to our pipeline
        retval = dsl_pipeline_new_component_add_many('pipeline',
                                                     ['uri-source', 'primary-gie', 'ktl-tracker', 'tiler', 'on-screen-display', 'window-sink', None])
        if retval != DSL_RETURN_SUCCESS:
            break

        # Add the XWindow event handler functions defined above
        retval = dsl_pipeline_xwindow_key_event_handler_add("pipeline", xwindow_key_event_handler, None)
        if retval != DSL_RETURN_SUCCESS:
            break
        retval = dsl_pipeline_xwindow_delete_event_handler_add("pipeline", xwindow_delete_event_handler, None)
        if retval != DSL_RETURN_SUCCESS:
            break

        # Add the listener callback functions defined above
        retval = dsl_pipeline_state_change_listener_add('pipeline', state_change_listener, None)
        if retval != DSL_RETURN_SUCCESS:
            break
        retval = dsl_pipeline_eos_listener_add('pipeline', eos_event_listener, None)
        if retval != DSL_RETURN_SUCCESS:
            break

        # Play the pipeline
        retval = dsl_pipeline_play('pipeline')
        if retval != DSL_RETURN_SUCCESS:
            break

        dsl_main_loop_run()
        retval = DSL_RETURN_SUCCESS
        break

    # Print out the final result
    print(dsl_return_value_to_string(retval))

    dsl_pipeline_delete_all()
    dsl_component_delete_all()

if __name__ == '__main__':
    sys.exit(main(sys.argv))

@jlerasmus really appreciate all the help... I'll look into this.

@rjhowell44, I believe this is fixed now.  Please double check.  Getting more up to speed with DSL :-)
I will start a new long running test, but with the above sample it seems fine.

@jlerasmus that's awesome!  I will check and pull in shortly... let me know when you're ready for some new issues to work on :) now that you're getting up to speed.
Thanks again, really appreciate the help.

@jlerasmus can we close this issue now?

This seems to be fixed.
But I believe there is still one or more memory leak somewhere (not related to the capture-frame-action as far as I can tell) as I have had 2 crashes due to memory filling up, each within 8 hours of running.

@jlerasmus good to know... I would be very surprised at this point in development if there aren't at least a few issues to uncover.


Upgrade to akka-persistence-spanner 1.0.0-RC5

Travis CI failed, but as far as I can see, not related to this change. I have restarted the build ... let's see.

Travis CI failed, but as far as I can see, not related to this change. I have restarted the build ... let's see.

@jroper any ideas why this is failing CI?

@jroper any ideas why this is failing CI?

@marcellanz or @sleipnir, would you please approve this PR now that the CI tests are green?

@marcellanz or @sleipnir, would you please approve this PR now that the CI tests are green?

@hseeberger we are not part of the core team, hence have no permission to do so. Either James or Peter might be able to do that or Viktor.

@hseeberger we are not part of the core team, hence have no permission to do so. Either James or Peter might be able to do that or Viktor.

OK, as nobody of the core team wants to review, I am going to use my superpowers and get this PR merged.

OK, as nobody of the core team wants to review, I am going to use my superpowers and get this PR merged.

^^ (I'm sorry for my emotional outbreak, of adding a GIF)

^^ (I'm sorry for my emotional outbreak, of adding a GIF)

😂

😂


[FEATURE REQ] Provide Service Bus Message Headers in Spring Cloud Azure Stream Binder for Service Bus

Is your feature request related to a problem? Please describe.
Service Bus adds a number of headers to messages as outlined here. We would like to use these headers, namely the "DeliveryCount" in one of our projects.
Describe the solution you'd like
In spring-cloud-azure-starter-stream-servicebus version 4.0.0-beta3, the org.springframework.messaging.Message.getHeaders() method already returns a org.springframework.messaging.MessageHeaders object. Unfortunately, these headers lack a lot of the values provided by Azure Service Bus.
Describe alternatives you've considered
There is no clear alternative in this case.
Additional context
See the org.springframework.messaging.MessageHeaders definition for exposed headers compared to the actual headers exposed by Service Bus
** Note **
This feature request is for documentation purposes and was addressed in 4.0.0-beta4.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

@yiliuTo : This is the feature you added in 4.0.0-beta4. Thanks for that! Can I ask you to resolve this feature request?

Hi @TechPreacher thanks for tracking this, and I also created an issue #27620 for it and resolve this in pr #27675.

Close for the issue has been resolved.

Thanks again, @yiliuTo !


Send errors to stderr too.

This has been implemented in master using the following code:
https://github.com/rla/blog-core/blob/dc51f6042fc68082d6990c68513a03bc5869a86c/prolog/bc/bc_main.pl#L79-L87


Add favicon for dark mode use it on browser dark mode

Thanks for the help

Looking good now! Could you please also use this favicon (https://raw.githubusercontent.com/bitcartcc/bitcart-media/master/favicon.ico) without additional borders, so that we have consistent favicons in all repos?

You are now in our contributors list:
https://github.com/bitcartcc/bitcart#contributors-
Thanks again!
As you said you are using prettier. We currently don't have any formatting guidelines set up for our vue/js code, so any suggestions are welcome. We want to set up some CI checks and formatting in our vue repos. I will describe it a bit later, if you want, you can take a look at that

Sure. I will. 🙂

See bitcartcc/bitcart-admin#13


Process hangs on manual request abortion

It looks like inner timeout is not cleared when aborting request manually. Maybe I'm missing something?
Here is code to reproduce:
const needle = require("needle");
const log = require("why-is-node-running");

const readStream = needle
  .get("https://google.com", {
    read_timeout: 120000,
    follow_max: 10
  })
  .on("header", statusCode => {
    // do some checks, but for example purposes I'll just abort the request
    readStream.request.abort();
    readStream.destroy();
  });

setTimeout(() => {
  log();
}, 500);

You're right! We need to ensure all timers are cleared when the request is aborted

Done! Just pushed v2.2.3

@tomas could you comment why stream.request.abort(); not called automatically on stream.destroy()?
I got similar issue with mocha hang due missed timers cleanup. Just used require('stream').pipeline(needle_stream, comsumer) and called consumer.destroy() when no more data needed.
AFAIK, pipeline() is new recommended method to glue streams with guaranteed cleanup. It would be nice to support it.