handling types

Hi josua
I've just started to test your API. Are you receptive to new ideas? If not it's ok, just ignore me. But if you are, here are some ideas:
(1)
O.get().u32
I don't really like the look of the above. Why not simply allows access like this:
O.get<unsigned>()
O.get<double>()
O.get<std::string>()

You have defined a bunch of types yourself, but they pretty much map straight back to c++ types. Why not use the C++ types directly? Use your own types internally only. If the conversion fails, throw an exception.  Maybe even better:
if(parser.available("optimization")){
        int o = parser.get<int>("optimization");
}

I think it worth thinking about this. I'm sure its not entirely straight forward, especially in light of interpreting empty string values/ 'null-strings'. I had many such situations in my own code recently, and I usually found that a simple solution was usually possible. I'm happy to discuss.
(2)
Also, personally I don't like the:
auto&& O = parser["optimization"];

I'm not even sure what the auto&& is really for.  Is a simple reference not enough?
Thanks, Peter

hi
For declaring options, one way of doing it would be:
parser.option("optimization",'O').help("some help text");
Thanks, Peter

Hello
Thanks a lot for your feedback. I appreciate every suggestion and criticism.
(1.1)

O.get<unsigned>()

Well, O.get().u32 is actually both shorter to type and more expressive (it tells you the exact amount of memory and the value range), so I vastly prefer it. Do you not agree?
(1.2)

if(parser.available("optimization")){
        int o = parser.get<int>("optimization");
}

You shouldn't look up the string "optimization" every time you use it. Every instance of "optimization" means another lookup in the internal hashmap. That's why I saved references to the option in my examples and that's how you should do it too. Then your code becomes much simpler:
if(optimization.available()){
        auto o = optimization.get().i32;
}

(2)
auto& may be sufficient for certain cases but auto&& is more generic. It also binds rvalue-references and adopts CV-qualifiers. If you're not familiar with C++11's new auto&&, here's a link: https://stackoverflow.com/questions/13230480/what-does-auto-tell-us
(3)

parser.option<int>("optimization",'O').help("some help text");

The problem with this is that I could not store the values in a union anymore. I would need to implement a value class with complete type-erasure which would require 1. RTTI enabled and 2. typeid, which is generally slow. And on the other hand, what is gained by this? A slightly different syntax? I don't consider it worth it.
Cheers

hi
I'm glad you appreciate my feedback.
(1)
If there is any confusion about size a user can easily type
O.get<uint32_t>()
functions with a signature like get() and as() are used so widely and are so useful that I don't see why something new needs to be invented.
(2)
You know, some libraries need performance and memory optimization, and others need convenience. Parsing program options falls into the latter category. Nobody is going to worry about a microsecond when parsing program options. Nobody is going to want to upgrade to the latest compiler just to use it either. In large projects like mine you can't just upgrade compilers and IDE for the sake of using one library. We'll get around to that eventually, but not immediately.
Ok, thanks for your consideration!
Best Regards, Peter

Hello
(1)
I agree, get templates are pretty commonplace. I'll have a look into that, if you're still interested. Would you mind testing it once I've implemented it? I envisioned keeping the .type(i32) syntax for setting the options' types but offering an additional get template that automatically converts the type if possible.
(2)
Fair enough. Unfortunately, I can't change the value class to store an arbitrary type at the given moment, because that would basically require me to rewrite the whole library. Everything is built upon the assumption that only the given 8 value_types are possible. And rewriting everything would mean shedding backwards compatibility completely. But I will definitely keep that in mind for version v2.0! Someone has actually suggested something similar because they wanted to specialize get for their own class type, so I guess you're in the majority ;)
As to the point with the compiler: I see what you mean but if you're alluding to the other issue, that Visual Studio 2015 won't compile my library, that is unfortunately out of my scope. It is quite obviously a compiler bug. My code is C++11-compliant, so there's nothing to "fix" on my end. However, I have figured out a workaround if your standard library supports C++14 and I'm going to post it in the other issue.
Thanks for the cooperation.
Cheers

hi
You don't have to support 'arbitrary' types! The ones you are supporting are quite sufficient. You can easily restrict to just the types you are supporting. I have a 'variant' class that I use in all my projects. It is an extremely useful class. In fact it could easily be the basis for a library like yours as it takes care of all type conversions. It also has an internal type enum like you are using, but I do have get() and as()  members. I restrict the allowed template argument types by doing this:
	template<typename T> T get(void) const {
		static_assert(std::is_same<T, int64_t>::value ||
			std::is_same<T, double>::value ||
			std::is_same<T, float>::value ||
			std::is_same<T, int64_t>::value ||
			std::is_same<T, uint32_t>::value ||
			std::is_same<T, int32_t>::value ||
			std::is_same<T, bool>::value ||
			std::is_same<T, std::string>::value ||
			std::is_same<T, tsa::date>::value ||
			std::is_same<T, tsa::date_time>::value ||
			std::is_same<T, tsa::duration>::value
			, "variant::get<T>() template argument not supported");
	}

I'll test your compiler fix tomorrow. I'm near London, its late here :-)
Peter

Hi
I just had another thought. Why does the user have to declare the 'type' of an option at all? To start with, every option value is a string. Its only when the user does .get() that you need to parse the string to see if it converts cleanly to a 'double'. The only reason why users would have to declare a type for an option is if they expected the string to be error checked at the time parser::parse() is called. That is what I would do. If the user does pass a type, then you use it to error check the input immediately. If the user does not give a type, then you only throw an optional error at the time the user calls get() sometimes later.
Food for though! Sorry to bombard you with all these ideas.
Peter


lxd bridge: move forwarding iptables rules to the NAT section

Disabling IPv4 NAT removes the MASQUERADE rule from the nat table, but the FORWARD rules remain.
While this is consistent with the parameter name, forwarding outgoing traffic is useless without a NAT, and forwarding incoming traffic leaves the container exposed to the host's LAN.
As a user, I would expect this option to create an isolated setup.
Signed-off-by: Wojciech Górski<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Nope, this is wrong.
If I have a setup (as I do here) where the subnet I have on lxdbr0 is routed by my gateway to my host, then I absolutely DO need the FORWARD rules but absolutely DON'T want the MASQUERADE one.
Your change would effectively break every single, properly designed corporate or production network.
Note that in the near future we will be adding support inside LXD itself for managing bridges, that feature will let you create an isolated bridge.

Yes, that is the "exposed to the host's LAN" part ;) Thanks for the explanation, looking forward to the bridge management feature.


Fix TypeError in Runner.actual_distance

(fixes #47)

Coverage decreased (-0.2%) to 97.387% when pulling ddbddabd63fd37a771159aef80742c14d23b6781 on runners into 23502eb63aace051e79aef2d015ba8cccb7fb27b on master.


Debug static class conflicts with other uses

Thanks for UberLogger!
I had one issue which is that making it a drop-in replacement with the global static class Debug conflicts with several use cases for me, including dropping in the standard Unity Test Tools.
There are 2 issues I've seen and the test tools trigger both of them:

Anything which tries to access the property Debug.isDebugBuild fails and I don't believe it's possible to fix that by proxying since C# doesn't allow properties on static classes, or global variables which you'd need to proxy it with an instance.

using Debug = UnityEngine.Debug; because you're also importing System.Diagnostics conflicts with the global namespace Debug

I've fixed this in my projects by just renaming the Debug class UberDebug because I don't really mind that it's not a drop-in replacement and that I need to use it specifically (it's still a nice shortcut over UberLogger.Logger.Log). I don't know if you want a PR for this though since one of the highlighted features is that it's a drop-in replacement - although sometimes it isn't if your code has either of the 2 issues above 😉 Maybe you can think of a better way to mitigate this, or maybe this could just be in the docs as a gotcha.
Thanks again!

Hi Steve!
I'm trying to remember why I implemented it via a Debug aliasing class - I seem to remember it was:
a) I was having difficulty intercepting all Unity messages, and thus capturing existing calls via function spoofing was necessary.
b) I initially had versions of 'Log'/etc with just extra parameters for channels and stuff.
I'm 90% sure a) is no longer true, and b) is definitely not true, so I think the solution of renaming the class is actually fine. I'll give it a quick go now (I'm adding some new features anyway).
Ta!
Simon

FYI, I’ve just created a ‘version 2’ branch, which has the following:

Completely rewritten the renderer - the ‘easy’ way was slow and made supporting other features a nightmare.
Added support for ‘collapse’.
Added support for ‘autoscroll/follow’.
Removed the old ‘Debug’ namespace spoofing - it was causing problems for people. All the UberLogger debug commands are now in UberDebug - Debug.Log will still be intercepted correctly, however.
Better selection of colouring - should now work with Pro skins.

Let me know if this fixes your original issue, or if it creates new problems - then changes are fairly extensive, so I'll only pull it back into main when I'm sure it's safe.
Simon

Wow, thanks Simon, that's way more than I was expecting! 😄 I'm going to check this out properly tomorrow...

Works great for me, thanks so much for the fast response! I just submitted a small warnings cleanup as a PR but otherwise just works & doesn't have the conflicts any more. :metal:  🎉


Fix for proper script invocation by path

It is much better to invoke scripts by path than by extracting their contents. This allows for PowerShell to set $PSScriptRoot to the folder containing the script (very important for scripts that want to reference something in the local folder), $MyInvocation gets set up properly with access to the script path under $MyInvocation.Command.Path, etc.
It is also much better to invoke the script file without creating an unnecessary child scope. There is no point in introducing additional overhead where it is not required. That is why the second argument was replaced with false.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Note that I am not set up on my system to test this change; however, this change should work (automated testing via appveyor should pick up on any issues). It would be really nice if you had a PowerShell script to test a system to see if it is properly set up, with messaging that tells users what is missing if they are not set up properly for build/test scenarios. The documentation you have already is a good start, but it isn't as clear as it should be and it would be better to just automate what can be automated so that people can get up and running with a build/test environment more easily.

Also note that this addresses one of the many items identified in #1563 (related to being able to use $PSScriptRoot/$MyInvocation to reference the current folder and the script path if necessary). I can update this to also set the current working folder to the folder where the script is located if you're OK with that change as well, either as part of this PR or as a separate PR. That would also give proper support for relative paths and $pwd from within the script.

Adding @tohling
Would be nice to see some tests validating the enhancements you've mentioned above.

@fabiocav Agreed, and I just noticed that I broke a test by removing GetScript (which is no longer required), so I'll update that test and add additional tests.

@fabiocav For the additional tests, since this change is about what happens inside of a PowerShell function running inside if an Azure Function App, Pester would be more appropriate for test validation. Do you have any Pester tests set up for this repo yet? I couldn't find any. What I'm picturing is a set of Pester tests that push a new Azure Function App into an Azure account, add a PowerShell function to it, run the PowerShell function it contains, validate the results, and then tear the Azure Function App down when completed.

I removed the test that is no longer necessary. I don't believe the appveyor failures are my own now, but please correct me if I am mistaken.

The AppVeyor failures are due to this issue: https://github.com/Azure/azure-webjobs-sdk-script/issues/1581

It seems the issue that was causing the AppVeyor failures is resolved. @fabiocav: Are you able to get AppVeyor to build this again or does an artificial change like a source code comment have to be added just to get AppVeyor to try again?

This is an old PR that we were hesitant to take in the past. Now it is out of date, because in the dev branch which this targets, we've migrated to .NET Core, and the PowerShell invoker no longer exists. When we reintroduce PowerShell support, we'll take these ideas into consideration. Thanks - closing this for now.


Update StorageLoader so that loads a specified run of data to atomic.events

Currently, when StorageLoader loads shredded data into Redshift, it specified a path to the shredded file as part of the Redshift copy statement which includes the etl_tstamp in it.
It does not do this when loading data from the enriched events table - instead it loads everything in the enriched/good bucket.
If we could specify the precise location of the enriched files to be copied, the way we do with the shredded files, it would make it less likely that in the event that there's an overlap between two runs, data would be loaded twice.

It seems StorageLoader was able to load from enriched good at some point. Closing as this is not the case with RDB Loader.


Add F# implementation

~The simple implementation is very slow, since it is using immutable Map to store counters, which is probably one of the slowest things you could possibly do. This is certainly not an attempt at "how fast can it go" :)~
EDIT: I reconsidered this, since using Map would not probably be considered a reasonable implementation for this task even in idiomatic F#.
Optimized version could, in theory, be identical or very close to C# in performance, but that is not what I tried to do here.

Thanks again!


Confused

What exactly does everything do? What is its purpose? Im not exactly sure what it all does from looking at it. How is the index structured?  It may be obvious, but I am clearly missing it. lolz
Thanks in advance

It adds the ArrayList class, so if you don't know what it is or how to use, search on the Internet or don't use it. It's not the place to ask something like that.


Padding / Module Margin not working

Hi,
I have pretty much finished my bar configuration but I'm not completely happy about the layout of the bar.
I noticed that the settings padding-left / padding-right don't seem to have any effect, nor do the module-margin-right / module-margin-left settings.
Here is a screenshot with both "padding" settings set to 5 :

Thanks in advance

Hi, could you please post your full configuration.

Here it is : https://github.com/BenoitAverty/dotfiles/blob/82e3e6a20879e324067de4a45f4ab8bd6ec0ff47/.config/lemonbuddy/config
I'm not sure if it corresponds exactly to the screenshot above but i'm certain there was never any padding for the bar.

Thanks :smile:


Update OptimalControlSolution: type, getters, setters

          > @PierreMartinon Do you need more than:

T = sol.times         # T = [t0, t1, ...]
X = sol.state.(T)     # X = [x0, x1, ...]
U = sol.control.(T)
P = sol.costate.(T)

and
x = ctinterpolate(T, ...)
p = ctinterpolate(T, ...)
u = ctinterpolate(T, ...)

You lost me there :D
What I meant is, we currently have the functions state, control, costate, and I'd like to have additional vector state_d, control_d, costate_d, to store discrete trajectories. This discrete part would be used when exporting to JSON text format, instead of the discrete solution struct I currently use.
In the case of direct methods these vectors would store the original discrete solution, and in other cases it would simply default to apply the functions to a given time grid.
Ah, while we're on OptimalControlSolution, here is the list of keys for the different constraints and multipliers (other than costate), since these vectors and functions are currently saved in the infos dictionary of the solution. Maybe we could add explicit fields in the struct instead of dumping everything in the dictionary ? Note: I chose to return functions (ie interpolate) for everything related to path constraints, including 'boxes' on state and control variables, and keep vectors for boundary conditions and optimization variables constraints.
Vectors: :boundary_constraints, :mult_boundary_constraints, :variable_constraints, :mult_variable_constraints, :mult_variable_box_lower, :mult_variable_box_upper
Functions: :control_constraints, :mult_control_constraints, :state_constraints, :mult_state_constraints, :mixed_constraints, :mult_mixed_constraints, :mult_state_box_lower, :mult_state_box_upper, :mult_control_box_lower, :mult_control_box_upper
Originally posted by @PierreMartinon in https://github.com/control-toolbox/CTBase.jl/issues/144#issuecomment-2301801915

@PierreMartinon For what I understand, we have:
T = sol.times # or sol.time_grid now i think
state_d = sol.state.(T)
control_d = sol.control.(T)
costate_d = sol.costate.(T)

or with the getters
T = time_grid(sol)
state_d = state(sol).(T)
control_d = control(sol).(T)
costate_d = costate(sol).(T)

So I do not think it is a good idea to add fields for the discretized state, control and costate. It will be redundant and source of errors. However, we can add getters to get them:
state_d = state_discretized(sol)
control_d = control_discretized(sol)
costate_d = costate_discretized(sol)

In the OptimalControlSolution, I propose to add the fields:
Vectors: :boundary_constraints, :mult_boundary_constraints, :variable_constraints, :mult_variable_constraints, :mult_variable_box_lower, :mult_variable_box_upper
Functions: :control_constraints, :mult_control_constraints, :state_constraints, :mult_state_constraints, :mixed_constraints, :mult_mixed_constraints, :mult_state_box_lower, :mult_state_box_upper, :mult_control_box_lower, :mult_control_box_upper
with the associated getters.
Moreover, the constructor need to be updated.
I propose also to add setters for all the fields. The constructor must use the setters.

Hi, reopening this one for a quality-of-life point :D
Currently the fields related to variables are not present if the OCP is not variable dependent. While this certainly makes sense, this gives two separate constructor calls and requires a test before choosing the correct one.
Could we just pass nothing values to everything variable-related in the variable-independent case ?
Or is there already a way to use the variable case constructor even for variable independent OCPs ?

You can uncomment:
https://github.com/control-toolbox/CTBase.jl/blob/1480852e69d6de96f56719b3b3026cadbfe6deef/src/optimal_control_solution-setters.jl#L103
and
https://github.com/control-toolbox/CTBase.jl/blob/1480852e69d6de96f56719b3b3026cadbfe6deef/src/optimal_control_solution-setters.jl#L113-L116


As a global admin, I want the source of borrowing event information documented so that I can refer back to the item if necessary.

Notes for testing

import script creates footnote bibliography entries (with type lending library card) for each card, including cards in a single file (check known cases, e.g. bernheim)
bibliography entry notes include the image paths associated with the card from the xml
card bibliography is associated with the account, and visible in the account edit form
each borrowing event has a footnote documenting the image it came from (generated by the import script)

Notes for development
Current plan is to use the footnote functionality; import script will generate bibliography records for each card, and the footnote location will be the card image.
Sample card citation:

Sylvia Beach, Gertrude Stein Lending Library Card, Box 43, Sylvia Beach Papers, Department of Rare Books and Special Collections, Princeton University Library.

It looks like the image files are indeed imported and, from the ones I've checked, correct.  @clmahoney would you take a look at a few more random ones of these?
Just click on a random borrowing event, and then scroll down to the footnote and look at the "location" link to the pudl image database.  Then check that image to make sure it does indeed contain the borrowing event.

On the account page, there is now a field for "card" and it appears to be set to the correct card when that exists.  I'm not sure I understand what the functionality should be, though--we can't access these "cards," can we?  That might be a useful feature for some point in the future: to be able to click on a "card" and see all of the borrowing events associated with it.  I suppose we can approximate that now by searching by borrower in the borrowing-event list and sorting by date...

@elspethgreen you can browse the card citations and footnotes on specific events, but I agree it's somewhat limited right now.  I think that's ok for current phase.

Yes this looks good!


What is the difference between Adopt and OpenJDK distributions?

Hello
I apologize for this dumb question, but I am confused with this new Java versioning.
Suppose I want to use Java 11 (LTS) server side.

OpenJDK provides its own Java 11 ditribution on openjdk on jdk.java.net. What is the difference between this and AdoptOpenJDK Java 11 distribution?
When there is some security Bug in OpenJDK (Oracle patches only the latest open jdk) and hopefully someone will backport this fix to older OpenJDK versions. Does AdoptOpenJDK just take that fix from OpenJDK ? If the fix will be provided by AdoptOpenJDK will this fix be also available in OpenJDK?

Thanks for clarification
Peter

There's very little difference - Adopt has a couple of extra patches which makes life a bit easier in PRD deployments (like backporting certificates from 11 to 8 for SSL connections).
Yes we pick up all of the patches including security from upstream.


Question: what is the recommended way to profile multi-gpu code?

I've used rocprofv2 and encountered the same problem stated in this issue.
I'm wondering what is the recommended way to profile multi-gpu code with ROCm-5.6? Also, API form is perfered since I want to control the profiling range.
Omnitrace seems an overkill for me since I only want to trace each gpu kernels.
For example, the output of rocprofv2 in "ROCPROFILER_DISPATCH_TIMESTAMPS_COLLECTION" mode is exactly what I want:
dispatch[1], gpu_id(0), queue_id(1), queue_index(1881), pid(123346), tid(123510), grd(256), wgr(256), lds(2048), scr(512), arch_vgpr(112), accum_vgpr(64), sgpr(112), wave_size(64), sig(140333513201792), obj(1), kernel-name("ncclKernel_SendRecv_RING_SIMPLE_Sum_int8_t(ncclDevComm*, unsigned long, ncclWork*) [clone .kd]"), start_time(2492860750916911) , end_time(2492860751105392)
dispatch[2], gpu_id(0), queue_id(4), queue_index(13687), pid(123346), tid(123510), grd(6656), wgr(256), lds(0), scr(0), arch_vgpr(4), accum_vgpr(4), sgpr(16), wave_size(64), sig(140333513201536), obj(2), kernel-name("take_kernel.kd"), start_time(2492860751121072) , end_time(2492860751126192)

Thanks!

@tiandi111 Apologies for the lack of response. Do you still need assistance with this ticket? If not, please close the ticket. Thanks!

@tiandi111 Closing ticket for now.  Please leave a comment if you still need assistance and I will re-open the ticket. Thanks!


Remove AbstractEngineProcessorShim

We can use cg.AbstractProcessor and its descendants instead.
This is blocked by adding default arguments to the marked-Optional-but-no-actually arguments to AbstractProcessor.get_device and .get_sampler
cc @dstrain115 @MichaelBroughton

I don't think we can use SimulatedLocalProcessor directly because it isn't serializable -- either philosophically or in practice.

related: https://github.com/quantumlib/Cirq/issues/2820

@MichaelBroughton @dstrain115 this should be ready for your review, PTAL

Also, did #4850 solve your optional gate set issues?  Or is there further work needed?

@verult @dstrain115 ptal. With #4909 merged in, the diff should be fixed (smaller)


Repository link is broken

The link in the repository filed of Cargo.toml is missing a 't'. This brakes the link shown on crates.io.

oh yes I see "texure" :sweat_smile:, thanks for catching that.


[BUG] cant use lv3 snippets

Hi
sorry for finding all these bugs, hope this isnt annoying :)
when i set:
  (setq yankpad-snippet-heading-level 3)
and then issue yankpad-insert the list comes up empty. if i change the level back to 2 then the 2nd level org heading do show.
any clue what to check to debug this?

I don't have the time to look into it right now, but I believe it may be because yankpad-category-heading-level has to be one step lower than yankpad-snippet-heading-level. I'll look into this.

I've pushed a fix to this to GitHub. Don't know how long it will take until its on Melpa.

I can conforms this works thx  :)


feat: NFT details panel

Description
resolves #145
Demo
https://github.com/aeternity/aescan/assets/15363559/6684cef1-d9de-4df8-8f03-b5daf5a64c7e
Checklist:

[x] I have read and followed the Contributing Guide
[x] display nft details

I added some suggestions, some hints are not aligned to the NFTs list PR.

Now it is rebased

On mobile the Collection Name row goes to two lines, is it possible to fix it?

At the exact resolution I have differently broken content, but anyway, it's a more general issue. I am not really sure how to fix it in elegant way ./

@janmichek Is the issue with the collection name going to get fixed on this pr?
Because i tried different mobile resolutions and it always appear on that spot


[Joy] Add radio button documentation page

Preview: https://deploy-preview-33254--material-ui.netlify.app/joy-ui/react-radio-button/

[x] I have followed (at least) the PR section of the contributing guide.

@danilo-leal I moved RadioGroup and Controlled demos up because they are more common than Position.

I figured that but I'd say it's good to follow the flow of simple → complex on the documentation. As the RadioGroup is already an aggregator component for more complex layouts, position made sense to come in first. What do you think?

I figured that but I'd say it's good to follow the flow of simple → complex on the documentation. As the RadioGroup is already an aggregator component for more complex layouts, position made sense to come in first. What do you think?

I agree completely with simple → complex. That's why I move the RadioGroup up because I'd say that it is the most simple one. The layouts and position come later (not every app needs them).

That makes sense but then it's a different rationale, isn't it?
Simple to complex as opposed to more frequently used to less frequently used.
I'd still follow the first one!

That makes sense but then it's a different rationale, isn't it?
Simple to complex as opposed to more frequently used to less frequently used.
I'd still follow the first one!

That's true. I will revert the change then.


Implement Multiharp data formats

From the offical Read_PTU.m code (MATLAB version), MultiHarp use the same "ReadHT2" function as HydraHarp and TimeHarp260

% choose right decode function
switch TTResultFormat_TTTRRecType;
case rtPicoHarpT3
ReadPT3;
....
....
case {rtMultiHarpNT3, rtHydraHarp2T3, rtTimeHarp260NT3, rtTimeHarp260PT3}
isT2 = false;
ReadHT3(2);
case {rtMultiHarpNT2, rtHydraHarp2T2, rtTimeHarp260NT2, rtTimeHarp260PT2}
isT2 = true;
ReadHT2(2);
....

I would be glad to take a pass at this, do you have sample data from the MultiHarp? If so, I would like to add it to https://github.com/tsbischof/picoquant-sample-data and use it to test this library before release


"Tutorial: Get started on macOS" link broken

Before you open an issue
If the issue is:

A simple typo or similar correction, consider submitting a PR to fix it instead of logging an issue. See the contributor guide for instructions.

I probably know what the link should be but not 100% sure.  Also it looks like you want me to sign something before creating a PR.  I'm not doing that.

A general support question, consider asking on a support forum site.

Not a general support question.

A site design concern, create an issue at MicrosoftDocs/feedback.

Not a site concern.

A problem completing a tutorial, compare your code with the completed sample.

Not a code sample.

A duplicate of an open or closed issue, leave a comment on that issue.

After looking for 30s, it doesn't look like anyone has reported this yet.
Issue description
Steps to reproduce:

Go to https://github.com/dotnet/docs/blob/master/docs/core/install/macos.md
Under "Next Steps" click link "Tutorial: Get started on macOS."

Expected behavior:

Taken to a new page

Actual behavior

404 when taken to https://github.com/dotnet/docs/blob/master/docs/core/tutorials/using-on-mac-vs.md

Perhaps link should go to https://github.com/dotnet/docs/blob/master/docs/core/tutorials/with-visual-studio-mac.md
[Edited by gewarren to add document details]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07a5fade-535f-2fad-c7b0-77bf9e28773e
Version Independent ID: 68d524f7-6cf1-2caa-56d5-f243952d1526
Content: Install .NET Core on macOS
Content Source: docs/core/install/macos.md
Product: dotnet-core
GitHub Login: @adegeo
Microsoft Alias: adegeo

It looks like a redirect has been put in place, because this is working for me.

@damonzocp Hi. Thank you for spotting this. The redirect is in place so this doesn't happen in the live site, only when you're browsing the source. However, the source should be updated. The thing you sign is a legal agreement between you and the .NET Foundation: https://cla.dotnetfoundation.org/ which basically says you allow any project of the .NET Foundation to use your contribution.
As that page says:

We appreciate community contributions to code repositories open sourced by the .NET Foundation. By signing a contributor license agreement, we ensure that the community is free to use your contributions.

Anyway, I'll fix that up. Thanks again.


Make beanstalkd more performant and allow bigger jobs.

This is for Icerocket, so beanstalkd won't be hammeres with small bin log files.

This is the wrong place to set those.  They should be set in the configuration of the individual instance, not as the defaults of the puppet module.
Defaults in puppet modules should reflect the default configuration of the component it managing, then the real settings are changed when necessary.

Joseph, how (or where) do I set in individually so that puppet does not overwrites it?

It is set in our puppet-site manifest.  All this module does is provide the mechanism to configure it.

I still does not understand where it is. Puppet-site contains links to many modules... Can you point me where is it physically (like a link) for beanstalkd or on disk in case of local override. Thanks.


suggestion, add user name

It is an excellent package to use in our projects. Thank you very much for your help.
I have the following suggestion, which makes it more practical to use the name of the user that I create, update or delete:
Add the following to the model:
protected $ appends = ['created_by_user', 'updated_by_user', 'deleted_by_user'];
Public function getCreatedByUserAttribute ()
    {
        if (! empty ($ this-> creator-> name)) {
            return $ this-> creator-> name;
        } else {
            return '';
        }
    }
Public function getUpdatedByUserAttribute ()
    {
        if (! empty ($ this-> editor-> name)) {
            return $ this-> editor-> name;
        } else {
            return '';
        }
    }
Public function getDeletedByUserAttribute ()
    {
        if (! empty ($ this-> destroyer-> name)) {
            return $ this-> destroyer-> name;
        } else {
            return '';
        }
    }
You could declare in the model which username to return
const USER_BY = 'name'; // const USER_BY = 'email';
Regards,

I would suggest creating your own trait to handle this.

OK, Thank you


Fix spark comparison functions signature

Fixes: #7785

Thank you for fixing this. Some comments in addition to @rui-mo 's. Can you run the fuzzer again to see if anything else needs fixing?

I observed two failures, which are caused by split and arrar_sort, and they are already tracked by separate issues.
I1130 15:35:40.310659 29433 ExpressionVerifier.cpp:258] Skipping persistence because repro path is empty.
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
  what():  Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: (3 vs. 1) split only supports only single-character pattern
Retriable: False
Expression: patternString.size() == 1
Context: split(2cc6d2aa8b55cdeddc58dc2b9edf5c027f5c8871:VARCHAR, t|/:VARCHAR)
Top-Level Context: Same as context.
Function: apply
File: ../../velox/functions/sparksql/SplitFunctions.cpp
Line: 94

I1130 18:19:48.515769  3869 ExpressionVerifier.cpp:86] Executing expression 0 : try(sort_array(array(1 elements starting at 80 {4899089136835737722 => 334861609},map("c0","c1",3897655363396438434,"c2"),map("c0","c1",3897655363396438434,"c2"),if("c3",map("c0","c1",3897655363396438434,"c2")),map("c0","c1",3897655363396438434,"c2"))))
I1130 18:19:48.518962  3869 ExpressionVerifier.cpp:74] All results match.
E1130 18:19:48.519145  3869 Exceptions.h:69] Line: ../../velox/expression/tests/ExpressionVerifier.cpp:66, Function:operator(), Expression: left->equalValueAt(right.get(), row, row) Different results at idx '3': '[3->3] 5 elements starting at 10 {[10->13] null, [11->11] 2 elements starting at 99 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [12->12] 2 elements starting at 289 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [13->14] 2 elements starting at 559 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [14->10] 1 elements starting at 2 {4899089136835737722 => 334861609}}' vs. '[3->3] 5 elements starting at 10 {[10->13] null, [11->11] 2 elements starting at 99 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [12->12] 2 elements starting at 289 {2997714920536524086 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [13->14] 2 elements starting at 559 {2997714920536524086 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [14->10] 1 elements starting at 2 {4899089136835737722 => 334861609}}', Source: RUNTIME, ErrorCode: INVALID_STATE
I1130 18:19:48.519325  3869 ExpressionVerifier.cpp:258] Skipping persistence because repro path is empty.
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
  what():  Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Different results at idx '3': '[3->3] 5 elements starting at 10 {[10->13] null, [11->11] 2 elements starting at 99 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [12->12] 2 elements starting at 289 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [13->14] 2 elements starting at 559 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [14->10] 1 elements starting at 2 {4899089136835737722 => 334861609}}' vs. '[3->3] 5 elements starting at 10 {[10->13] null, [11->11] 2 elements starting at 99 {1583829170647228153 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [12->12] 2 elements starting at 289 {2997714920536524086 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [13->14] 2 elements starting at 559 {2997714920536524086 =><PHONE_NUMBER>,<PHONE_NUMBER>396438434 =><PHONE_NUMBER>}, [14->10] 1 elements starting at 2 {4899089136835737722 => 334861609}}'
Retriable: False
Expression: left->equalValueAt(right.get(), row, row)
Function: operator()
File: ../../velox/expression/tests/ExpressionVerifier.cpp
Line: 66

@zhli1142015 Indeed, this is the expected change. We'll have to ignore this CI failure for now.
CC: @kgpai


port sqlcipher to go-sqlite3

hi mattn:
I ported sqlcipher to go-sqlite3 and just made it work, I knew that the PR is mess up, here are what i did:

port sqlcipher from 3.20 to 3.24, put it in sqlite3-binding.c
put libtomcrypt files in (just for easy building)
port your see branch back
some readme modification for people just want make it work quickly
modify _example/simple just for testing if it works

I don't know weather you are willing to add this feature. if it is, I will do some clean up and make the PR decent. here is a list i am willing to do, and any advise is welcome :)

make a patch for sqlite3-binding.c, add it to upgrade package
make the crypto lib out side the project
put openssl and commoncrypt support back, maybe
make a build tag for enabling the crypto codec
more tests
cleanup the garbage commits

Coverage decreased (-0.01%) to 58.154% when pulling 88abdaae46b3314973c1746beeff14722dbd73fa on CovenantSQL:master into b3511bfdd742af558b54eb6160aca9446d762a19 on mattn:master.

You have better to work on $GOPATH/src/github.com/mattn/go-sqlite3 with branch not on $GOPATH/src/github.com/CovenantSQL/go-sqlite3-encrypt.

@GJRTimmer How do you think this PR?

FYI github.com/xeodou/go-sqlcipher is basically what is described in this PR (I can't speak for the code though, haven't read it)

any progress ?

any progress ?

you can just use my fork version.

@GJRTimmer How do you think this PR?

Lokking into it

Any updates?

I have created the following PR to allow using SQLCipher with go-sqlite3, which I believe supersedes this one: https://github.com/mattn/go-sqlite3/pull/1109


Image does not download

I installed python 3.9.6, obsidian 0.12.8 on windows 10
I run main.py, the folder External_Imgs_to_Local_Files and the log file are created.
The new folder is empty.

Please check if you run the main.py file on the same folder as the markdown files you want to edit (the obsidian vault folder).
If yes, try reading the log text file.
See if the your markdown files were opened or skipped.
Also, look for any errors reported on the log file.
If you don't have privacy concerts, you can post the contents of the log file here too.
Otherwise, try reading it yourself and post what you find.

Thanks for your answer. Run main.py in the same folder of md file "test_script"
Send you some screenshots.

Nice, thanks for sharing.
The files are being opened, but the script can't find the URLs.
The script looks for URLs with the Obsidian embed images syntax, like this:

![Optional_image_name_for_screen_readers](www.link.com/folder/image.png)

Are your links following this format?

Don't worry about the URL for now. Just check if your img links begin with the exclamation point, followed by the brackets and then the parentheses.

Now if it works, maybe I had the wrong link.
Is there any way to replace the original file (md) and save the image in a
folder inside the original?
Here's an example:
Source path
test_script\test1.md
Target Path
test_script\test1.md
test_script\images
Thanks
El jue, 1 jul 2021 a las 18:56, xZaR3y4p @.***>)
escribió:

Don't worry about the URL for now. Just check if your img links begin with
the exclamation point, followed by the brackets and then the parentheses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xZaR3y4p/Img_link_to_local_markdown/issues/3#issuecomment-872404586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2GF4H7KBPPIWZ2DE5V3Z3TVSM2ZANCNFSM47SCB4ZQ
.

Nice that it worked.
Replacing the original file is dangerous because if there is some error you can't reverse it.
So I created a new branch for you that saves the images and .md files to a "/Images" folder inside the vault.
Then you can first test if the files are showing the images correctly with Obsidian.
If everything is fine copy and paste the modified .md files to the vault, replacing the old ones.
I've also edited your previous comment because you unintentionally pasted some private information from the email github sent you notifying about this thread.
Try the modified script and see if it works for you.

Thanks!
I've tried the new version and it works fine, except that the images don't appear.

Regarding the issue of not overwriting the originals I think it's a smart choice.
How about renaming the originals by adding _back or something similar?
test1.md -- test1_back.md
This way you avoid having to move files and it is also possible from time to time you can delete all *_back.md files and they will be deleted from all folders at once.

Good suggestion regarding the files.
About the images not being downloaded, apparently the script found the URL and the images names correctly, but couldn't download them.
To help you more, I would need to see the log file again. Look for an "Error when downloading {url}".
If you could share just one URL that failed to download too, that would help.
I've just tested the script on my computer and it downloaded the images.
Let's try to discover what is happening on your case, even thought it is a little slow chatting in here, maybe we can make some progress.

The images download correctly.
If I add 2 dots before /images it works correctly.
before

after

Try now. It was a issue with relative vs absolute path when linking the images on the new .md files.
Test it and give a feedback if it worked please.

Now it works, thank you very much for the changes.  It is a very useful script when you have many documents with images. Are you thinking about making a plugin?

I first thought about it, but couldn't understand the documentation on how to create plugins.
So I went with python.

At least your script is very easy to use, sometimes you have to install and configure a lot of options.


Feature Request - Policy Only Deployment

Hi Team,
Looking for a feature to deploy the Azure Policies alone as per the below architecture without deploying all the resources in Management Group as per the below architecture.

https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Policies
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Is your feature request related to a problem?

Describe the solution you'd like

Additional context

Hey @zansarif,
Thanks for the issue, if you just want the management groups and the policy definitions and assignments you can follow the guidance here: https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/wiki/[Examples]-Deploy-Demo-Landing-Zone-Archetypes

@jtracey93:  Is it possible to deploy just the policy definitions and policy assignments (no management groups, for those brownfield scenarios where they've deployed the management group structure previously but haven't yet got any Azure Policy in place?)


Added parametrization for k8s components restart check

Added parameters for components restart retries and delay between retries.

Related to issue https://github.com/kubernetes-incubator/kubespray/issues/2277

Too much parametrization complexify the configuration for new users.
I would rather increase the default rather than parametrize them

I can argue that as long as the user does not need to specify the parameters it cannot increase the complexity for him. I used as defaults the old hard-coded values.
For a user running kubespray with defaults, there is no change...
For one that is looking to change parameters it is a improvement.
Am I wrong?

A user will discover what he can parametrize by reading the defaults.
Kubespray as already too many knobs and these ones aren't strictly necessary.
If the timing is failing for you it will fail for others. If increasing the hardcoded solve it let's do it for everyone.
Please propose timing that works for you.

Ok, let's try like this, I had problems only with API server. I increased the number of retries.

I'll close this one and start another. The name of the issue and PR is no longer relevant and I'm not willing to spend too much time with git great features.

ok, no problem, I'll wait for the new PR, thanks


[-] Connection Failed with Host:

Once I input IP address/port number and name for the overflow, I can see "Pattern Generated Successfully". However, it is failing when trying to connect the target. Even if I could ping to the target and see the vulnerable app is listening on the assigned port.
Is there any way to overcome that?
I am targeting windows 7 VM through my Kali Linux VM.

Double check everything and make sure you are giving correct input to the program.


No longer working when server includes Message-Authenticator

Not sure what's going on here, but when getting results via radiusPacketParser.Parse() method, library is unable to properly calculate message authenticator and always throwing 'Invalid Message-Authenticator in packet' error. Happens on FreeRadius v3.0.20 on RHEL. Maybe server implementation of how message-authenticator is generated has changed and now there is a mismatch? This used to work, but not working anymore. Maybe it's related to BlastRADIUS issue?

Could be blastradius related indeed. What kind of packet did this happen with?

Could be blastradius related indeed. What kind of packet did this happen with?

Happened on Access Request.

Could be blastradius related indeed. What kind of packet did this happen with?

Happened on Access Request.

I should add that it happens after Access Request is sent. BlastRadius fix for the client requires message-authenticator on every request, so I manually 'Message-Authenticator' attribute with zero bytes to client attributes, which then gets filled in GetBytes() method. Server gets the request, doesn't complain that Message-Authenticator is missing, processes the request and sends back Access Accept. It's here when library tries to parse the packet bytes, it throws an error due to Message Authenticator mismatch. I'm really puzzled as to what's wrong here. The packet looks fine, but calculated hash doesn't match the message authenticator hash in the packet.

I think I have a pretty good idea what the issue is. The biggest task is dragging the codebase into 2024 to test it

I think I have a pretty good idea what the issue is. The biggest task is dragging the codebase into 2024 to test it

Good to hear! Looking at what the BlastRADIUS fix was about, does it have something to do with message-authenticator being now first attribute in the response?

This is really odd. I don't see what could be wrong when generating message authenticator to compare with value in RADIUS packet. The only fix for BlastRADIUS was always including message authenticator in all responses from the server, but the client already handles that, so I'm now really sure what's going on here anymore. Where could the issue be?

This is really odd. I don't see what could be wrong when generating message authenticator to compare with value in RADIUS packet. The only fix for BlastRADIUS was always including message authenticator in all responses from the server, but the client already handles that, so I'm now really sure what's going on here anymore. Where could the issue be?

I got it! When calculating message authenticator for response, it needs to use original authenticator of the packet in position 4 of the response packet. Probably, need to change Parse() method to pass original authenticator from request and then use that as parameter to CalculateMessageAuthenticator() method, which right now uses null as third argument?

So, finally got around to actually test the server. Seems like it does kinda work when manually adding a Message-Authenticator to response packets with an empty byte[16].
Tried with the test server and set it to respond with:
https://github.com/vforteli/Flexinets.Radius.Core/blob/b7a495b5c367a06ef464b4657a0aa224a97a658a/RadiusTestServer/src/PacketHandler/TestPacketHandler.cs#L36
Log from radclient using -b to require blastradius checks
root@6652caa65b66:/# echo<EMAIL_ADDRESS>User-Password=1234" | radclient -x host.docker.internal:1812 auth somesecret -b
Sent Access-Request Id 19 from <IP_ADDRESS>:53435 to <IP_ADDRESS>:1812 length 74
	User-Name =<EMAIL_ADDRESS>	User-Password = "1234"
	Cleartext-Password = "1234"
Received Access-Accept Id 19 from <IP_ADDRESS>:1812 to <IP_ADDRESS>:53435 length 38
	Message-Authenticator = 0x701df9d5e3dbccaf7f29da6b2cf6209a

Now if this should be the responsibility of the packet handler, server or the lower level package is then up for debate 🤔 Now 8 years later the API does seem a bit convoluted and could probably be simplified quite a lot

I think for BlastRadius fix, every RADIUS server that has a fix automatically responds with message authenticator. Prior to the fix, I believe it was optional. But now when parsing packet response, library fails to process bytes due to mismatch on message authenticator. From what I understand, when calculating message authenticator from response, it needs to use original request authenticator.
Something like this: public IRadiusPacket Parse(byte[] packetBytes, byte[] sharedSecret, byte[] originalRequestAuthenticator) and then inside the method this:
var calculatedMessageAuthenticator = CalculateMessageAuthenticator(tempPacket, sharedSecret, originalRequestAuthenticator);
Only with the above, I could get the code to process response from my FreeRadius server.

ah that was the other way around compared to my example. Have to try that also then

ah that was the other way around compared to my example. Have to try that also then

Yes, the issue is from the server to the client. With server always including message authenticator now, there is now mismatch on the message authenticator value since library is not using client message authenticator when calculating response value. When calling Parse() method after getting RADIUS packet from the server, it just needs to pass request packet.Authenticator to the method and use it when calling  CalculateMessageAuthenticator(). Also, client should now always include message-authenticator for all calls. I think it's adding Message-Authenticator attribute only for StatusServer packet code.

There is a somewhat working poc in this branch https://github.com/vforteli/Flexinets.Radius.Core/tree/feature/blastradius but ill still create more tests and refactor it a bit

This fix is required also for windows radius NPS. After 2024-10 Cumulative Update for Windows Server 2019 for x64-based Systems (KB5044277) the behaviour is the same as described in this issue.

Looks good now! I will close this issue.

Nope. This fix has broken windows nps radius before KB5044277 update. If Message-Authenticator is not presented in the package, I got error from check for blast (throw new MessageAuthenticatorException("No message authenticator found in packet");). Of course I can set _skipBlastRadiusChecks but I don't think that it's a good solution.

Nope. This fix has broken windows nps radius before KB5044277 update. If Message-Authenticator is not presented in the package, I got error from check for blast ("No message authenticator found in packet"). Of course I can set _skipBlastRadiusChecks but I don't think that it's a good solution.

Yes, but you are supposed to have all servers upgraded to always include Message-Authenticator in the packet. That's a requirement for BlastRADIUS fix. You can use _skipBlastRadiusChecks, but technically, it's not a good idea to skip it.

I think that _skipBlastRadiusChecks variable should be renamed because it's not a unique behaviour for blast. We must explicitly specify whether we should skip the message-authenticator check and for which types of packets.

Yes, definitely, maybe.
According to the RFC the message authenticator should also be required with EAP, but that isnt enforced here in the parser now. Technically you could of course do that in the handler instead but I suppose it would make more sense to have that as the responsibility of the lower level parser in this repo.
Anyway, now that I got around to dragging this project into 2024 Ill probably do some more fixes to better cover the RFCs


Navigation

Implement a navigation for the ebooks.
design:
https://www.figma.com/design/sOphUcS0UV2Xh7mgmrJaSA/Lullabot.com-Refresh-(Jared's-Explorations)?node-id=1816-1288&t=2nT3macsH3szy7Hn-0
prototype:
https://www.figma.com/proto/sOphUcS0UV2Xh7mgmrJaSA/Lullabot.com-Refresh-(Jared's-Explorations)?page-id=1806%3A3014&node-id=1809-11&viewport=95%2C266%2C0.18&t=KBf8himnUqF4lxOv-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=1811%3A8
goal: not to have a list of ebooks, but to pull in the current book's TOC when clicking a hamburger

Let's make sure we add in the footer with link to resources

@huntermacd @jared Is it intentional that there seems to be no way to get back to the landing page with all the ebooks listed? Or is it the intention that most users will not be sent to that page?

@DBNubs it is intentional.


⚠ 한경주요지수-코스피200 has degraded performance

In d3b2647, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 6482 ms

Resolved: 신규상장 performance has improved in 7fe0007.


Implement state class

@travissluka I've finished the class State and passed all the tests. please check and merge my branch develop_chen to branch develop. As for the next step,

Once it's been merged, and since the JEDI github location has been changed, I plan to download the OISSTv3 develop branch and re-compile it from the beginning (since there has been a lot of changes).

This is from your comments, "focus on state for now, I think what we should do for increment is to actually move the common methods of state and increment, as well as the the atlasFieldSet variable, into a common Fields base class. You can either do this now, or wait until you have most of State implemented. That way we wont have as much duplicate code between State and Increment". I know that classes of State and Increment have similar content, and it makes sense to me to combine them in some way, but it is related to the STRUCTURE of the program, shall we follow what JEDI's structure? What is your plan and suggestion?

closes #11

You never merged in the latest develop branch, you need to do that and resolve the conflicts first

I'm not entirely sure, but I think TravisCI is refusing to run the tests until the merge conflicts are resolved

@loganchen39 I fixed a data/ Data/ mixup, the TravisCI tests should work now. Once they do I'll approve and merge.
Now that the code base is starting to get bigger, and we might have more things going on simultaneously, I'm going to start adding "to-do" items as issues in github. I can help out from time to time on some of these, so to prevent overlap assign yourself on an issue before starting work so we know who is doing what (I already assigned you for the next step of implementing Increment). WHen you issue a PR, if you put "closes #<issue_number>" the associated issue will be closed when the PR is merged.

@travissluka Thanks for your suggestions. I'm actually quite new to this git/github stuff. Previously I learned that I should never code on develop branch, but only on my own branch develop_chen. If there's any change on develop branch and I have "git pull" to merge to my local develop branch, what are the commands to merge branch develop to develop_chen?
Now that my current version of branch develop_chen passed all the test, I'd like merge it to develop branch on github, and then I'll re-download  and re-compile all the code since there's been a lot changes, and then I'll work on with your suggestions above, (e.g. change name sst, delete std::cout etc.).

:+1

@travissluka Thanks for your suggestions. I'm actually quite new to this git/github stuff. Previously I learned that I should never code on develop branch, but only on my own branch develop_chen. If there's any change on develop branch and I have "git pull" to merge to my local develop branch, what are the commands to merge branch develop to develop_chen?
Now that my current version of branch develop_chen passed all the test, I'd like merge it to develop branch on github, and then I'll re-download and re-compile all the code since there's been a lot changes, and then I'll work on with your suggestions above, (e.g. change name sst, delete std::cout etc.).

One thing I would recommend is that you use branches with meaningful names. It's best practice to create a new branch, from develop, for each new feature/bugfix that is being added. Reusing the same branch name can cause small issues with other people pulling your branch.
when you're going back to develop, just run
git checkout develop
git pull

to get the latest develop branch, and make sure to run make update within the build directory to have ecbuild pull the latest versions of the JEDI repositories.
when you're working on your work branch, the easiest way to make sure you have the latest develop merged in is run
git fetch --all
git merge origin/develop

with these commands you don't have to switch branches before merging Alternatively you could merge in the latest develop using
git checkout develop
git pull
git checkout <your branch>
git merge develop

.... but that's more to have to do.

@travissluka Thanks a lot, will follow these suggestions.


JJ-Abrams: Custom Service, need to manually inject?

My custom session service:
import Session from 'ember-simple-auth/session';

export default Session.extend({ ....etc

Is throwing this error when its being instantiated:
Uncaught TypeError: Cannot read property 'on' of null

Error occurs on line 313 of session.js
 /**
      @method _bindToStoreEvents
      @private
    */
    _bindToStoreEvents: on('init', function () {
      var _this5 = this;

      this.store.on('sessionDataUpdated', function (content) {
        var _ref2 = content.authenticated || {};

It appears to be because the store is not being injected into my custom service as it is in the base service. https://github.com/simplabs/ember-simple-auth/blob/jj-abrams/addon/initializers/setup-session.js
Do i need to manually inject it for the upcoming version?
FYI here is my config
ENV['ember-simple-auth'] = {
        base: {
            authenticationRoute: 'public.login',
            routeAfterAuthentication: 'portal',
            routeIfAlreadyAuthenticated: 'portal',
            store: 'session-store:local-storage',
            session: 'service:session',
        },
        authorizer: 'authorizer:web-api',
    };

You're extending the session itself, not the session service. Change you custom service to:
import Session from 'ember-simple-auth/services/session';

export default Session.extend({
  …


question regarding zshenv and prezto

I have a script I would source into my ~/.zshenv before I started using prezto https://github.com/AlJohri/dotfiles/blob/gh-pages/templates/commonenv
but it would generally be pretty slow and I'm pretty sure most of it is in the wrong file
I sourced it in zshenv because some linters from sublime text wouldn't find the command (especially if it was a gem or python package) unless I established pyenv rbenv my path etc.
As I'm moving to prezto, where do you recommend I move most of this?
Thanks!

Put it in zprofile for now. Then see which parts can be moved to modules. If it's in zshenv, it will be sourced on every shell start as well in every subshell. Hence why it's slow.


Update cluster.save behavior

Current dependencies on/for this PR:

main

PR #471   👈

This stack of pull requests is managed by Graphite.


Cannot navigate to source location

Gateway Version: 2023.3.4
CLion Version: 2023.3.4
Plugin Version: 1.2.0
When clicking on a finding in the SARIF viewer, I would expect it to navigate to the location in the source.
Instead, nothing happens.
Maybe this is connected to using CLion through Jetbrains Gateway, but this might also be unrelated.

Hello @LittleHuba,
I just took the time to test the SARIF viewer plugin with JetBrain Gateway. I am able to navigate to the location in the source.
How did you get the SARIF file? Did you use the GitHub integration or just import a local SARIF file ?

Thanks for the reply!
I used a local SARIF file that I imported.

ok, the SARIF file may not have the same path or at least doesn't start the relative path at the root of your CLion workspace.
Maybe I need to add a quick message to explain that when the location can't be resolved.

Hi,
I looked at the SARIF file again and the paths start at the root of the CLion workspace and the file is present under the exact path.
Can I provide some kind of debug logs? I did not find anything in the logs of the IDE.

Hello,
I have released a new version that fix an issue when navigating into file in the steps. I also added a message when we can't resolve the location.
Let me know if it helped


CookieJar.fromJSON is undefined

I think it's due to being defined before deserializeSync here:
https://github.com/SalesforceEng/tough-cookie/blob/master/lib/cookie.js#L1268

Oops! you're right.

Fix published in v2.2.1. Thanks for reporting @maraoz !

Thanks!


Request to Include a Recent Study that Incorporates LLM and GNN in Financial Services

Hi Xiaoxin, thank you for creating this invaluable repository, which consolidates papers on graph-based techniques and LLMs.
We recently posted a paper that incorporates ChatGPT's graph inference capacity with Graph Neural Networks. We have tested our model in a financial forecasting and portfolio management scenario. The results show quite promising potential even with a simple model structure.
Would you mind adding our paper to this nice repo? I guess it would be suitable under the category of "Application -- Others", and I added it there. Also, since our work is under review, we can post the associated code once the review process concludes.
Once again, thank you for your diligent efforts in maintaining this repository.

Thank you for contributing to the repository! I slightly modified the format and reordered the paper list according to the submission date on arXiv.


[Backport-2.x][Tiered Caching] Indices Request cache stalekey management (#12625)

Description
Backports https://github.com/opensearch-project/OpenSearch/pull/12625
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for 4e937ca: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was due to flaky test that has issue created - https://github.com/opensearch-project/OpenSearch/issues/10704

❌ Gradle check result for 4e937ca: null
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was due to flaky test that has issue created - https://github.com/opensearch-project/OpenSearch/issues/12236


Addition to runblender.ipynb

Sorry, I am a novice to pull requests and forking, so decided this way to communicate.
I've added Python Virtual Display and changed the paths of mounting google drive to make them navigable in Colab's U.I.
To have a look:
https://github.com/jujubeesloco/Colab-and-Snippets/blob/master/runblender.ipynb
Again, sorry for the method of communication,
-jujubeesloco

Hi, thanks!
I will have a look at it tomorrow and merge it if it looks fine to me
Normally you would fork this repo, add your changes and create a pull request from you cloned repo to mine. It should be in the GitHub docs too


Unify the representation of the dotInfoConnected value to always be a…

Prior to this change, the kDotInfoConnected path was initialized with @NO, which is an NSNumber representing a constant __NSCFBoolean value.
The onConnect and onDisconnect methods in FRepo.m later on updated the value with @true and @false respectively. These values represent __NSCFNumbers wrapping int values: 1 and 0.
This means that even thought the value is wrapped in an NSNumber, it changes it's type from being a boolean to later on being an int.
This change unifies the representation so that the value is always represented by an NSNumber wrapping a boolean value.

I signed the CLA.

Fixes #252

Thanks for sending this over. Merging this so that this can go out with our next release.


Impossible shape during ablation study

Hello, authors! I am confused about Table 5, where you did an ablation study including the scenario with Φpos and Affine but no Φpre.
Based on lines 337-340, for the complete model, the shape of x should look like follow during processing.
[b,g,k,d] -> Affine -> [b,g,k,d] -> Φpre -> [b,d,g] -> Φpos -> [b,d,g]
If we remove Affine, the following still works:
[b,g,k,d] -> Φpre -> [b,d,g] -> Φpos -> [b,d,g]
If we remove Φpos, the following also works:
[b,g,k,d] -> Affine -> [b,g,k,d] -> Φpre -> [b,d,g]
However, if we remove Φpre, the following would be impossible since Φpos cannot process an input x with a shape of [b,g,k,d].
[b,g,k,d] -> Affine -> [b,g,k,d] -> Φpos -> [b,d,g]
I hope you can clarify my doubts.
Thanks!
Shen Zheng

@ShenZheng2000 Thanks for your detailed description.
It's simple to achieve this ablation by simply setting pre_blocks=[0, 0, 0, 0] in model configuration. Here is an example
return Model(points=1024, class_num=num_classes, embed_dim=64, groups=1, res_expansion=1.0,
                   activation="relu", bias=False, use_xyz=False, normalize="anchor",
                   dim_expansion=[2, 2, 2, 2], pre_blocks=[0, 0, 0, 0], pos_blocks=[2, 2, 2, 2],
                   k_neighbors=[24, 24, 24, 24], reducers=[2, 2, 2, 2], **kwargs)

We remove the residual pointmlp block, but the aggregation function is still avaliable. Hence, the tensor shape will still be [b,d,g] as you described.

Thanks for your timely reply. Really helpful for me. :smile:


use redis SCAN

redis KEYS may block other requests. This PR changes List and Read to SCAN and implements prefix and suffix

do not fail when redis cannot be initialized
make redis store use SCAN to list keys, with prefix and suffix
read using SCAN with prefix and suffix

Thanks for the contribution, looks good


Default now() timestamp in migration script example causes fixed date

The migration script example in the ideal stack has the following line: col.defaultTo("now()").  It should be:
col.defaultTo(sql`now()`)

Otherwise the default date is hardcoded when the table is created and then all new records will use that same date. I was going to submit a simple PR for this, but yarn test was failing for me on the repo, and I didn't want to start poking around on how to fix the build.
To confirm that the date was hardcoded I ran this in the SST console:
select col.table_schema,
       col.table_name,
       col.column_name,
       col.column_default
from information_schema.columns col
where col.column_default is not null
      and col.table_schema not in('information_schema', 'pg_catalog')
order by col.column_name;

Columns that used defaultTo("now()") had a hardcoded date associated with column_default, whereas columns that used the sql template literal helper correctly showed now() in column_default.

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Swarm crashes, then fails to restart (1.1.2; multiple networks; might be related to "error locating sandbox")

What I did (approximately):

I have a Compose application spanning multiple networks

I scaled a service (on network A) to 100 instances

I scaled a service (on network B) to 100 instances

I have a load balancer between the two networks

at first, I saw bursts of errors like the following:
System error: nosandbox: error locating sandbox id 23d5e3ec0012ee0b180fa2bb320b0c0d130cc601

84fbf048135b728bec63f33e: no sandbox found
- so I remove everything with `docker-compose down` and retried
- then Swarm stopped responsing
- `docker ps` on the node showed that it was restarting and crashing instantly, in a loop
- I have other nodes in a redundant setup and they all crash in a loop, too
- swarm version 1.1.2 (f947993)

Logs are attached.

I'll wipe the cluster so I can continue to work, but let me know what I can do if this happens again to gather more data.

[swarm.log.txt](https://github.com/docker/swarm/files/153560/swarm.log.txt)

@jpetazzo A network-related problem also bugged me and I accidentally found a workaround. The good news is that you don't need to wipe the whole the cluster.
The workaround is to clean up the cluster store (in my case consul) by recursive delete all keys there. After that, wait until all nodes registering themselves again, all overlay networks will be gone and you'll be good to go.
This bug seems to be for docker/libnetwork anyway.


Build failed (E0554, E0658)

error: failed to run custom build command for `azalea v0.9.0 (https://github.com/azalea-rs/azalea#4f288b1c)`

Caused by:
  process didn't exit successfully: `E:\azaleatest\target\debug\build\azalea-f068c0b71e7a1d72\build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at C:\Users\Admin\.cargo\git\checkouts\azalea-cdffe42e9d507c39\4f288b1\azalea\build.rs:4:55:
  called `Result::unwrap()` on an `Err` value: NotPresent
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\lib.rs:2:12
  |
2 | #![feature(portable_simd)]
  |            ^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\lib.rs:3:12
  |
3 | #![feature(array_chunks)]
  |            ^^^^^^^^^^^^

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:28:40
   |
28 |         (chunk, remainder) = remainder.split_first_chunk::<16>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:39:40
   |
39 |         (chunk, remainder) = remainder.split_first_chunk::<8>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:50:40
   |
50 |         (chunk, remainder) = remainder.split_first_chunk::<4>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

Some errors have detailed explanations: E0554, E0658.
For more information about an error, try `rustc --explain E0554`.
error: could not compile `simdnbt` (lib) due to 5 previous errors

Here's the main.rs I'm using.
https://pastebin.com/AAAKEf0A
And  Cargo.toml.
https://pastebin.com/suyEb2vd
(Also I did:
rustup install nightly
rustup default nightly
rustup override set nightly

And I'm using cargo build)

That error shows up when it's not using nightly. Try doing cargo clean and rebuilding, or if that doesn't work try adding a rust-toolchain file to your project like this one: https://github.com/azalea-rs/azalea/blob/main/rust-toolchain

Having the same issue after doing cargo clean and adding rust-toolchain
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\lib.rs:2:12
  |
2 | #![feature(portable_simd)]
  |            ^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\lib.rs:3:12
  |
3 | #![feature(array_chunks)]
  |            ^^^^^^^^^^^^

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:28:40
   |
28 |         (chunk, remainder) = remainder.split_first_chunk::<16>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:39:40
   |
39 |         (chunk, remainder) = remainder.split_first_chunk::<8>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

error[E0658]: use of unstable library feature 'slice_first_last_chunk'
  --> C:\Users\Admin\.cargo\git\checkouts\simdnbt-6350c7beb21f1e0d\4594562\simdnbt\src\mutf8.rs:50:40
   |
50 |         (chunk, remainder) = remainder.split_first_chunk::<4>().unwrap();
   |                                        ^^^^^^^^^^^^^^^^^
   |
   = note: see issue #111774 <https://github.com/rust-lang/rust/issues/111774> for more information

Some errors have detailed explanations: E0554, E0658.
For more information about an error, try `rustc --explain E0554`.
error: could not compile `simdnbt` (lib) due to 5 previous errors
warning: build failed, waiting for other jobs to finish...

Thanks, worked after a few tries.

Can azalea can use stable rust in the future?