json parser failed to parse full text if text startes with a number

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
def custom_parser(self, inputs: AIMessage):
    output = {"answer": None}
    try:
        json_parser = JsonOutputParser(pydantic_object=JsonOutputParserModel)
        json_output = json_parser.parse(inputs.content)  # type: ignore
        print('json_output',json_output)
        output["answer"] = json_output.get("answer", None)

    except (json.JSONDecodeError, OutputParserException) as e:
        parser = StrOutputParser()
        str_output = parser.invoke(inputs.content)  # type: ignore
        output["answer"] = str_output
    except Exception as e:
        print(f"Custom Parsing Error :{e}")

    return output

Error Message and Stack Trace (if applicable)
json_output 90
Custom Parsing Error :'int' object has no attribute 'get'
Description
I am trying to use langchain json parsing lib to parse a text into json.
Input of the custom_parser is model response : AI message, function checks if the respnse can be parse as json then try block will be executed and it the message can't be parsed as json, then JSON Decode Error block will be executed. The function is written in such a way that it can handle plain string as response or stringify json.
Issue is when i pass a string message:
custom_parser("90. Yes, you need to file the dispute")
output is:
json_output 90
Custom Parsing Error :'int' object has no attribute 'get'
But if i pass string message without number then it goes to second block and code get executed as usual
custom_parser(" Yes, you need to file the dispute")
Output:
{'answer': 'you need to file the dispute'}
System Info
langchain==0.2.0
langchain-community==0.2.0
langchain-core==0.2.1
langchain-openai==0.1.7
langchain-text-splitters==0.2.0

@spsingh559 could you provide a minimal reproducible example? From the report it looks more likely that there's a bug in the custom code than with the library.

I'm going to close the issue for now -- feel free to re-open if you're able to provide a minimal reproducible example

Hi @spsingh559, none of the strings passed are is in json format, so it's not surprising that it is not working. If one steps through the code, one can see that the program flow is different:

in the first case, after subtracting the characters it ends up with "90" which is parseable (try it out: json.loads("90")), but it just returns the integer instead of a dict. By adding AttributeError to the list of exceptions, one would also end up with calling the StrOutputParser.
in the second case, none of the parts is parseable, thus it throws a OutputParserException which is caught and then the StrOutputParser is used.

Furthermore, the documentation clearly states that the LLM has to fulfill some conditions, see: https://python.langchain.com/v0.2/docs/how_to/output_parser_json/
Some notes:

the description is missing the python version
please try to use the latest version of the library, because this is a project which evolves fast (and is still in beta)
the MCVE is not "complete": it is missing the imports, the main function and most importantly the JsonOutputParserModel. Additionally, the way how you called custom_parser would just fail because there is a self argument. I just used None for it, but it suggests that you might have even more (for the MCVE unrelevant) logic.


Diff editor have no more close button

disable workbench tabs
install gitlens
open a diff editor
there is so many commands that the split and close button overflow into the secondary menu

This is technically caused by extension but also annoying. I am building on the new'ish support to hide menu items and such don't count against the limit anymore

To verify:

follow the steps above
make sure you can hide item so that split and close appear again

Does the split and close actions shall not be checked?

The checked state represents the hiding that's done by a user while overflowing is just a space constraint. I believe the activity bar behaves the same


Add deps required to build other deps

This increases the size of the image quite a lot.
Alternatives welcomed. Would also be nice to pin the container version so that this doesn't become stale again, but I don't know if you want to do that.
We can pin by setting FROM to python:3.7-alpine3.10.

Same here,
Is this still necessary after merging #253 ?

Probably not, if people are reporting success with 253.
My comment about pinning the alpine version is still relevant, tho. An alternative would be testing the dockerfile with CI, but that sounds like a lot of wasted cycles to me.


Style in child component not changing when wrapped inside a container component

Environment
## System:
 - OS: Linux 4.15 Ubuntu 18.04.1 LTS (Bionic Beaver)
 - CPU: (8) x64 Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz
 - Memory: 7.49 GB / 15.53 GB
 - Container: Yes
 - Shell: 4.4.19 - /bin/bash
## Binaries:
 - Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
 - npm: 6.4.1 - ~/.nvm/versions/node/v10.13.0/bin/npm
## npmPackages:
 - styled-components: ^4.1.1 => 4.1.1

Reproduction
I am getting different results in codepen and codesandbox.
Using same React, ReactDom and Styled components Versions:
Codepen (Wrong behaviour)
CodeSandbox (Expected behaviour)
Steps to reproduce
Watch how the buttons are rendered the same color in Codepen, and then watch the behaviour in CodeSandbox. The second button is rendered with a red background, when it is wrapped inside the Container component.
Expected Behavior
I am getting the same result as in Codepen. My components don't change their style depending on container.
The expected behaviour is that I can change styles depending con container (context) so a certain small component becomes truly reusable. I know I could make it work passing props, but I would have to pass those props through a few components that shouldn't need to know about them, plus I have to be thinking about names for those props that are only used to include a set of styles, and it quickly becomes a mess of hard to understand props.
Actual Behavior
Style in child component not changing when wrapped inside a container component.

You have to move the Container declaration over the Button declaration: https://codepen.io/anon/pen/XyQEgE

THANK YOU SO MUCH

No worries, happy to help!


[#6433] Error in AdaptiveDialog.ContinueActionAsync with native dialog SDK

Fixes #6433
Description
This PR fixes an issue where the ComponentDialog cannot be found in the Dialogs stack and in the ResourceExplorer when using AdaptiveDialogs, adding a condition to evaluate the resource existence before trying to load it into the dialogs stack.
Additionally, it reworks the solution to load the dialog resource from the DialogContext instead when it cannot find the dialog (more information can be found in this comment).
Specific Changes

Adds a pre-condition before trying to load the dialog from the ResourceExplorer.
Added a unit test validating the new condition when using ComponentDialogs with AdaptiveDialogs.
Added FindDialog method in the AdaptiveDialog class, that detects when there is no Dialog in the stack, it loads it from the ResourceExplorer.
Added unit test that handles bot reconnection and resumes the conversation.
Updated the DialogContext.FindDialog method to detect when the AdaptiveDialog cannot be found, delegate the search to the AdaptiveDialog class.
Updated the AdaptiveDialog_LoadDialogFromProperty.test.dialog unit test, validating the new condition.
Removed previous implementation in BaseInvokeDialog and AdaptiveDialog related to the PRs (# 6338, # 6365).

Testing
The following image shows the new unit tests passing and the conversation samples detecting the LUIS Activity.

Hi @MatteoMilanese, @EricDahlvang, @johnataylor, @sbiaudet, @ramfattah, @tracyboehrer.
The past few days, we've been looking for a way to solve the issue described by @MatteoMilanese in this comment.
We were able to reproduce the issue described in the comment, and the solution we found is to let the DialogContext class detect when the AdaptiveDialog couldn't be found in the dialogs stack and allow the Parent dialog to find it.
Moreover, the AdaptiveDialog class will include a second FindDialog method, so in case the Dialog cannot be found, gather it from the ResourceExplorer.
Additionally, we already pushed the changes and updated the PR's description.

Note: Previous implementations made in the PRs (#6338, #6365) have been removed (except unit tests), as they are no longer being evaluated.

Thanks

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll


Introduce public max length fields for SelectOption

Pull Request Etiquette

[/] I have checked the PRs for upcoming features/bug fixes.
[/] I have read the [contributing guidelines][contributing].

Changes

[/] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Description
Introduces public fields in SelectOption that contain the maximum length of Label, Value and Description. Identical to MessageEmbed, these fields can then be used by developers without having to update themselves when changes occur.

Wrong project, meh.


create logo

Work on logo for left of HLL header

ALready had most of this done at home. Finished it. Looks good.


VOCSegmentation, VOCDetection, linting passing, examples.

Hey there guys, I hope this PR can revive some of the efforts that past PRs implemented, I'm referring to:

#86 by @ellisbrown
#37 by @desimone

This PR supports VOCSegmentation and VOCDetection for multiple years (2007 to 2012). 2006 and 2005 are not supported due to the very different format.
I tried to address many of the comments of the pasts two PRs. For the VOCDetection part __getitem__ will return the image and a list of bounding boxes of the format [[xmin, ymin, xmax, ymax, ind],[...],...] as PR 37 directly instead of a ET Element.
I think VOC is a very iconic dataset for both detection and segmentation so it'd be very useful to have it ready to use on pytorch/vision.
If there are any comments or suggestions let me know, I can put some time on implementing recommendations or so.
There are two examples (jupyter notebook gist) of the dataset being loaded:

This one is for segmentation
This one is for detection

I've tested for all the years and regarding the transforms, I'm using the same structure other datasets used, I've seen implementations where a joint_transforms is passed as argument, and that transform is applied to both input and target, I guess that'd work for segmentation but not much for detection so that's why it's not used.

Hi,
I'm just about to get https://github.com/facebookresearch/maskrcnn-benchmark/pull/131 merged, and I'll be pushing a more genera version of this here. I can coordinate with you guys so that we can get this finally merged.

Hi @fmassa, just checked the PR, seems really robust. Keep me in the loop if you need help with testing or implementation.

I've just finished testing it and got some reasonable results with the codebase. I'll look into merging the PR todayish.

Looking forwards to it!

I think the better approach would be to pass a dict of the parsed ET.parse().getroot(). I'm struggling a bit to implement a recursive function to parse it correctly so if anyone has some tips, they are appreciated.

@fmassa I followed your recommendations and added this instead for loading:
        with open(os.path.join(_split_f), "r") as f:
            file_names = [x.strip() for x in f.readlines()]

        self.images = [os.path.join(_image_dir, x + ".jpg") for x in file_names]
        self.annotations = [os.path.join(_annotation_dir, x + ".xml") for x in file_names]

In the detection part and this in the segmentation part:
        with open(os.path.join(_split_f), "r") as f:
            file_names = [x.strip() for x in f.readlines()]

        self.images = [os.path.join(_image_dir, x + ".jpg") for x in file_names]
        self.masks = [os.path.join(_mask_dir, x + ".png") for x in file_names]

Removed keep_difficult and _get_bboxes() and replaced it with parse_voc_xml that converts the xml to a dictionary like this (formatted):
{
    'annotation': {
        'filename': '2010_001870.jpg',
        'folder': 'VOC2010',
        'object': [{
            'name': 'person',
            'bndbox': {
                'xmax': '325',
                'xmin': '110',
                'ymax': '375',
                'ymin': '72'
            },
            'difficult': '0',
            'occluded': '0',
            'pose': 'Frontal',
            'truncated': '1',
            'part': [{
                'name': 'head',
                'bndbox': {
                    'xmin': '180',
                    'ymin': '75',
                    'xmax': '286',
                    'ymax': '211'
                }
            }, {
                'name': 'hand',
                'bndbox': {
                    'xmin': '225',
                    'ymin': '284',
                    'xmax': '292',
                    'ymax': '342'
                }
            }]
        }, {
            'name': 'person',
            'bndbox': {
                'xmax': '490',
                'xmin': '57',
                'ymax': '327',
                'ymin': '73'
            },
            'difficult': '0',
            'occluded': '1',
            'pose': 'Frontal',
            'truncated': '1',
            'part': [{
                'name': 'head',
                'bndbox': {
                    'xmin': '283',
                    'ymin': '88',
                    'xmax': '360',
                    'ymax': '226'
                }
            }, {
                'name': 'hand',
                'bndbox': {
                    'xmin': '58',
                    'ymin': '235',
                    'xmax': '116',
                    'ymax': '329'
                }
            }, {
                'name': 'hand',
                'bndbox': {
                    'xmin': '356',
                    'ymin': '136',
                    'xmax': '413',
                    'ymax': '215'
                }
            }]
        }],
        'segmented': '0',
        'size': {
            'depth': '3',
            'height': '375',
            'width': '500'
        },
        'source': {
            'annotation': 'PASCAL VOC2010',
            'database': 'The VOC2010 Database',
            'image': 'flickr'
        }
    }
}

As you can see it handles part and objects ok.
The only downside would be that the user needs to pass a target transform otherwise it won't be usable directly if a target_transform is not passed. I can write a transform and added to transforms, or shall we leave that to the user?

Oh indeed I was not using class_to_ind anymore, removed it and removed VOC_CLASSES too. And I just checked with VOC2012, it seems it's working for parts that have a single object.
This gist is the data loading of VOC2010, for target_transform I just passed a function that prints it and returns a 0.
Also tested for VOC2012 in this gist, as you can see it works when the object has one or multiple bounding boxes. Picture bellow for example, but you might just check the gists.


Disallow robots in non-production

Fixes #172. Got the example from https://github.com/twbs/bootstrap/blob/110c7f4cc0c5693583e0e69bdde3465c934b6e58/site/robots.txt
The question is: does netlify actually set environment: production when building for production/master?

Preview of your commit: https://5be9646fe47085303512ed78--thelounge.netlify.com/robots.txt
Preview of my dummy commit after I added the JEKYLL_ENV env variable (with production value) to our Netlify config: https://5bea6f3a40e2a44868ff04aa--thelounge.netlify.com/robots.txt
It seems to have worked to me.
We should probably move it to a netlify.toml file we'd put in the repo instead of a setting in their UI, but for now it will do. I wasn't sure which way you'd prefer so I went with what doesn't alter the repo for now.

Wondering, by "non-production", did you intend this to differentiate builds for main website vs. deploy previews / next website? If so then the environment variable way set to production wouldn't work, but they do have a $CONTEXT env var that would work. Not sure how to leverage it though.

There's this plugin: https://github.com/jayvdb/jekyll-netlify
Which seems to set jekyll env based on netlify context.

Why did you approve the PR then, is there something else required to be set?

Because I initially thought it was to distinguish between dev and non-dev. I think. That was a while ago.

I see you set Build environment variables, but wouldn't that apply to all deploys/previews?

Correct.

There's this plugin: https://github.com/jayvdb/jekyll-netlify

I did see this, do you want to play with it?

I did see this, do you want to play with it?

I don't have ruby installed (nor can I be bothered to install it, haha) to update the gemfile correctly.

Looks good


LinkException when not using Mutation Widget

Describe the issue
When not using the mutation widget and trying to get the error from the mutation, the following error is thrown
OperationException(linkException: UnknownException(NoSuchMethodError: The getter 'context' was called on null.
flutter: Receiver: null
flutter: Tried calling: context), graphqlErrors: [])

When using the Mutation Widget, this error is not thrown
Code

final QueryResult mutationResult = await graphQlClient.mutate(
        MutationOptions(
          document: gql(mutations.login),
          variables: {
            'email': email,
            'password': password,
          },
        ),
      );

      if (mutationResult.hasException) {
        debugPrint('Auth Login :- ${mutationResult.exception}');

      }

Expected behavior
Mutation Exception should show thee GraphQL errors as excepted

what version is this & what does your client declaration look like?

what version is this & what does your client declaration look like?

GraphQL version :- 4.0.1
The Client Declaration
/// GraphQL functionality is initalised in [LocalGraphQLClient]
class LocalGraphQLClient {
  static BuildContext context;

  /// The [HttpLink] is used to intialise the base HTTP URl
  static final HttpLink httpLink = HttpLink(
    Endpoints.baseUrl,
  );

  /// The [AuthLink] is used to add the token to the Header of the request
  static final AuthLink authLink = AuthLink(
    getToken: () async => 'Bearer ${await UserRepository(context: context).getTokenRefreshed()}',
  );

  /// The [WebSocketLink] is used to work with GraphQL Subscriptions
  static final WebSocketLink websocketLink = WebSocketLink(
    Endpoints.wsBaseUrl,
    config: SocketClientConfig(
      inactivityTimeout: const Duration(hours: 2),
      initialPayload: () async => {
        "Authorization": 'Bearer ${await UserRepository().getToken()}',
      },
    ),
  );

  /// The [ErrorLink] is used to manage errors globally.
  /// Both the errors by thrown by GraohQL and by the Client are handled
  /// Client Error - [SocketExceptions], [MalformedExceptions] and more
  static final ErrorLink errorLink = ErrorLink(
    /// if `linkException` is `not null`, we show `noInternet` message
    onException: (
      Request request,
      Stream<Response> Function(Request) forward,
      LinkException exception,
    ) {
        ToastUtil.errorToast(message: Strings.noInternet);
      return null;
    },

    /// if `graphqlErrors` has some items, we display the message from the graphQL
    /// error message
    onGraphQLError: (
      Request request,
      Stream<Response> Function(Request) forward,
      Response response,
    ) {
      debugPrint('GraphQL Error :- ${response.errors[0].message}');

      debugPrint('$request');
      ToastUtil.errorToast(message: response.errors[0].message);

      return forward.call(request);
      // return null;
    },
  );

  /// We split the links based on a normal request and subscription [GraphQLClient]
  static final Link link = Link.split(
    (request) => request.operation.operationName != "getAccessToken",
    Link.split(
      (request) => request.isSubscription,
      websocketLink,
      authLink.concat(
        errorLink.concat(httpLink),
      ),
    ),
    httpLink,
  );

  /// [GraphQLClient] is initalised with the required parameters
  /// [initalizeClient] should be called at the root of your application
  static ValueNotifier<GraphQLClient> initailizeClient({
    UserRepository userRepository,
    BuildContext buildContext,
  }) {
    context = buildContext;
    final ValueNotifier<GraphQLClient> client = ValueNotifier(
      GraphQLClient(
        defaultPolicies: DefaultPolicies(
          query: Policies.safe(
            /// [FetchPolicy] is set to networkOnly to keep the application
            /// online only
            FetchPolicy.networkOnly,

            /// [ErrorPolicy] is set to none to ensure that no data is shown to
            /// the user when a error is thrown
            ErrorPolicy.none,

            CacheRereadPolicy.mergeOptimistic,
          ),
        ),

        /// We use the default [GraphQLCache] to support In-Memory cache
        cache: GraphQLCache(),
        link: link,
      ),
    );
    return client;
  }
}

 static BuildContext context;

await UserRepository(context: context)

I'm guessing this is your issue. Idk what flutter does with context under the covers but maybe it gets disposed and then your getTokenRefreshed fails to find it's inherited widget or w/e. Try peppering some prints and exception handling in getTokenRefreshed to see if that's the issue

 static BuildContext context;

await UserRepository(context: context)

I'm guessing this is your issue. Idk what flutter does with context under the covers but maybe it gets disposed and then your getTokenRefreshed fails to find it's inherited widget or w/e. Try peppering some prints and exception handling in getTokenRefreshed to see if that's the issue

I tried adding debugPrint statements in the getTokenRefreshed method and no errors show up there. So that cannot be causing the problem for this

@aseef17 maybe try "pausing on all exceptions" in your IDE to see what exacty .context is being called on

@aseef17 maybe try "pausing on all exceptions" in your IDE to see what exacty .context is being called on

Sure. I'll try that.
But just discovered something that might be helpful for you to debug (Not sure though).
Tried to run my code with the graphql_flutter: 4.0.0-beta.5 and it works fine. Doesn't throw any errors but with version 4.0.1, the error is thrown.

I am also getting this type of error after upgrading graphql_flutter.
Tried following versions of qraphql_flutter package:

5.0.1-beta.1
5.0.0
4.0.0-beta.5

Still getting the same error. Below is screenshot of error message.

@milansurelia
By reading the issue, it is related to the client, but I'm happy to use my free time to debug your issue if you can produce a minimal example to reproduce the problem.
Thanks.

This issue looks stale. Closing for now.


Fix key for regexp in miq_expression.yaml

there is a lot of occurrences of :regexp
miq_expresion.rb and also in
app/controllers/application_controller/filter/expression.rb
and it fixes to edit of expression with regexp in UI
(report definition, filter tab)
so there is the typo in yaml.
UI error:
before:

after:

@miq-bot add_label reporting, bug
@miq-bot assign @gtanzillo

This PR should fix BZ https://bugzilla.redhat.com/show_bug.cgi?id=1447374

Made the change to lib/miq_expression.rb in Fine branch.
Fine backport details:
$ git log -1
commit de2fbcb8aa7f75efd058ecdcc647c8cb7c7edb5a
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Tue Jun 27 10:15:55 2017 -0400

    Merge pull request #15452 from lpichler/fix_key_for_regexp

    Fix key for regexp in miq_expression.yaml
    (cherry picked from commit 1a666022ce92a0691a4193e5e9f8eb7c4d7f5c4e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1477702
    https://bugzilla.redhat.com/show_bug.cgi?id=1477701


Modify Navbar section

Feature Request
Modify the navbar section and add the required links (home, projects, team, contribute, contact). Also replace the bulma logo image with elevate-lab logo.

I would like to work on this

@2802harsh please go ahead :tada:

Hi! I'd like to work on this too!

Feature Request
Modify the navbar section and add the required links (home, projects, team, contribute, contact). Also replace the bulma logo image with elevate-lab logo.

A

I would like to work on this

Navbar toggler is not working. You can look for that also.

@rush-tea Yeah, I have noted that. Working on it.

@rush-tea @2802harsh Good team work 🤜  🤛

@Tlazypanda ma'am Please review the PR here


Turn last validation warnings into errors

This PR turns the remaining validation warnings into errors (except those which are for 8.0).

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.


current messages problematic: scale ends on rating task no longer show up

this problem happened after moving to spreadsheet-based reading in of messages

fixed this by converting each message with JSON.parse() if possible (otherwise, it's a string, and should be kept as is). new function convertJSON()  does this... this could also be applied to the experiment spreadsheet, but that would would require testing whether it breaks anything (right now, json objects in experiment spreadsheet are converted with eval() where necesecary)


Update publish-to-azure-webapp-using-vs.md

The document is little vague with regards publishing a site that uses appsettings.json. This lead me to raise a SO query which you guys kindly answered:
https://stackoverflow.com/questions/44768865/asp-net-core-latest-appsettings-json-connectionstring-not-overriding-on-azur/44771419#44771419
I think the document needs to be clearer on how this option effects the use of appsettings.json. I had to manually remove the Config Settings on Azure post-publish (which I wasnt aware of).

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@garfbradaz, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

@garfbradaz  that's insecure and we don't want to promote an insecure approach. I don't know who answered that SO question but they should explain what's going on and remove the tacit approval for using a file to store sensitive information.

Thaanks @RickAndMSFT !
Is there a ASP.NET Core Version of this for appsettings.json?
https://docs.microsoft.com/en-us/aspnet/identity/overview/features-api/best-practices-for-deploying-passwords-and-other-sensitive-data-to-aspnet-and-azure

@garfbradaz One option that comes to mind for storing sensitive data in production environments is Azure Key Vault. I recommend reading the Azure Key Vault configuration provider doc. An alternative to this for local development is the Secret Manager tool. Read the Safe storage of app secrets during development doc for more info on that option.

@scottaddie Beautiful  - thanks again - awesome response times.


Monitoring upgrade nginx

@aiyengar2 ik we've been doing this but if they already have a version of the catalog with that chart version then the max won't get updated for v0.2.1 right?

The max should get updated if they have internet access, as it's just part of the charts that will sync. But if they have 0.2.1 installed then that will stay as-is. They just can't downgrade to it if they upgrade to 0.2.2.

@rmweir I think that makes sense though. We only want to prevent new users of Rancher in the new Rancher version from seeing older versions of the Monitoring chart because they should ideally be on the latest.


Flush measure memory data to disk.

Related to apache/skywalking#11472

[x] Tests(including UT, IT, E2E) are added to verify the new feature.
[x] Update the CHANGES log.

Codecov Report
Attention: 247 lines in your changes are missing coverage. Please review.

Comparison is base (eca1e45) 42.28% compared to head (3b2c4dc) 42.97%.

Files
Patch %
Lines

pkg/fs/local_file_system.go
0.00%
56 Missing :warning:

banyand/measure/tstable.go
60.71%
39 Missing and 16 partials :warning:

pkg/fs/local_file_system_nix.go
0.00%
40 Missing :warning:

banyand/measure/part_metadata.go
43.58%
16 Missing and 6 partials :warning:

banyand/measure/query.go
22.72%
15 Missing and 2 partials :warning:

banyand/measure/gc.go
62.50%
13 Missing and 2 partials :warning:

banyand/measure/flusher.go
84.12%
8 Missing and 2 partials :warning:

banyand/measure/part.go
89.87%
6 Missing and 2 partials :warning:

pkg/fs/file_system.go
0.00%
8 Missing :warning:

banyand/measure/snapshot.go
89.83%
4 Missing and 2 partials :warning:

... and 5 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   42.28%   42.97%   +0.69%
==========================================
  Files         145      150       +5
  Lines       16221    16801     +580
==========================================
+ Hits         6859     7221     +362
- Misses       8722     8911     +189
- Partials      640      669      +29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

The build task failed due to the lack of Windows file handlers. Relevant implements will be pushed later.


Ignore any *config files in site root

So you can have additional config files, like mobile-config.js, ipad.config.js, etc. at the site root and have them be ignored by git.

There is "/includes/" folder in the gitignore for such proposes

I understand and I make use of the includes folder after finding that in the .gitignore file. Though if I have multiple config files I would like to have them in the same place in the file structure. But I understand if not wanting to accept this change as there is already a place, the includes folder, to add custom code.

I believe that having a single config.js and whatever user wants in /includes is a much cleaner solution.


Support for Node.js environment and fallback for printing colors in Terminal/Command prompt

console.message should be installable through npm install console.message and should fallback to printing colors in the Terminal(Mac) and Command Prompt(Windows).

+1

+1

How are you planning on printing colours within Command Prompt? Would you be relying on a third party library to allow ANSI control sequences within CMD?

Hi @jakewhiteley,
Actually I could extract the logic from third party library and apply it in mine. The implementation for printing colors to the console is easy and straightforward. The only problem is to print the closest color. The CMD supports only limited number of colors and when you provide a custom color like #12345 this should be translated to its closest supported CMD color.

9 years later, I will answer this #1 issue 😄.
I decided to start working on this project again as I find it useful and started using it daily. I rewrote the library and now it heavily relies on web console specifics. Currently, if I implement Node.js support, this would mean that it will be almost as writing 2 different implementations for the web and node. This is why I will close this issue. This is a decision that may change in the future as the library evolves.


$auth->getUser(); error

Hi,
when I try to use the following:
try{
    $data = $auth->getUser($bearerToken);
    print_r($data); // show all user data returned
  } catch(Exception $e){
    echo $auth->getError();
}

I receive back an error:
Client error: GET         https://*****.supabase.co/auth/v1/user resulted in a 401 Unauthorized response:
"Invalid JWT: unable to parse or verify signature, signature is invalid".
Do you probably know what the problem could be?

Hey @bobmolgui, do you remember what the solution was to this issue?

Hi @mblode
Check your credentials. Was the $bearerToken generated correctly?

For me, it was the packages. After I updated them, everything worked. What is your error or could you already fix it?


tpl: Expose funcMap as FuncMap

Hugo has the best template funcmap that I've seen and to be able to use it in any other Go project I'm faced with either:

Fork Hugo, change visibility of funcMap to FuncMap, vendor forked Hugo
Copy the bits of the funcMap I need, attempt to ensure all licenses and credits are copied, maintenance nightmare
Ask if Hugo would consider just changing the visibility of funcMap
Extract tpl into it's own project to supply improved templating and functions to all Go projects

I'm thinking option 3 is the most trivial for now and achieves the goal. The license already permits the code re-use, but the default unexposed visibility does not. This change would be just to make the code follow the spirit of the license.
PS: My usage scenario is that I'm porting a Django project to Go and need a few simple functions within my templates, and whether it's dfault or in Hugo has the best so it makes sense to use these.

We're not exporting funcMap. We want as a small external API to Hugo as possible. Hugo is a lot of things, it is not a "library for template funcs". Many of them are special to Hugo, and we want the liberty change them at will without having to consider breaking other peoples' apps.

bep is right, so don't complain if your code breaks.  However, you can already do what you want by looking up the underlying html.Template object (which also doesn't export it's FuncMap, btw).
myFuncMap := template.FuncMap{...}
templ := tpl.New()
templ.Lookup("").Funcs(myFuncMap)


Improve SqliteDataReader.GetSchemaTable() DataType

Note that column and table names cannot be bound using parameters (I enclosed them in " to make SQL injection attacks less likely).
Addresses #436

Rebased on top of current dev.


added 'emojiconAlignment' XML attribute to further fine-tune the alignment of emojis

We needed to have a little more control of the alignment of the emojis, so we exposed the constructor argument verticalAlignment of DynamicDrawableSpan.
We welcome your feedback and hope, you can integrate this pull request upstream.
Best regards,
Roman

Hey @rzimmer can you please resolve the conflict?

Sorry for the delay! Rebased and updated the commit. Hope that it's fine now! Failing build is due to an TravisCI configuration error..

Let me fix the CI error


Issue running in Minikube

Unable to attach or mount volumes: unmounted volumes=[kvconfig2 kvconfig1], unattached volumes=[kvconfig2 default-token-27tbn kvconfig1]: failed to get Plugin from volumeSpec for volume "kvconfig1" err=no volume plugin matched; failed to get Plugin from volumeSpec for volume "kvconfig2" err=no volume plugin matched
Setup LV Flexvolume in Minikube using service principal
Volume should be mounted
0.0.16
Service principle
minikube 1.7.3
Additional context

@trhumphries While installing on minikube the target dir needs to be https://github.com/Azure/kubernetes-keyvault-flexvol/blob/master/deployment/kv-flexvol-installer.yaml#L47. Once you update /etc/kubernetes/volumeplugins to /usr/libexec/kubernetes/kubelet-plugins/volume/exec  in the manifest and deploy to minikube it should work.
Can you please try that out?

Closing this issue with https://github.com/Azure/kubernetes-keyvault-flexvol/issues/182#issuecomment-597323434. Please feel free reopen if the above comment doesn't resolve the issue.

Hi @aramase ,
I am getting the same error. Could you please help me with the path that needs to be used as I am using K8s on Docker Desktop Win 10 machine with WSL2 backend.
May I use the same path below  suggested for minikube?
/usr/libexec/kubernetes/kubelet-plugins/volume/exec


Project Manager: Intended directory change with enter opens a listed project in Import dialog

Godot version:
2.1.4 and 3.0 beta 2
OS/device including version:
Fedora 27 (x86_64)
Issue description:
An already listed project is opened when you press enter to change directory path in the Import dialog. Pressing enter should result only in directory change.
Steps to reproduce:
In the Project Manager, first click on a project on the list. But then select Import, click on Browse (actually optional), write a non-importable path and press enter. Instead of opening the directory you entered and allowing you to proceed exploring the file system, Godot will open the listed project you clicked on earlier.

I think this happens always when using any dialog window in Project Manager. It feels like the focus remains on project list regardless of whatever dialog you are using, so the list always takes away the enter key input.

Duplicate of #17620


Yiisoft\Assets\Exception\InvalidConfigException The sourcePath to be published does not exist: C:\wamp64\www\demo\blog/node_modules/bootstrap/dist

What steps will reproduce the problem? A new installation of demo
What is the expected result? Smooth run
What do you get instead? Above error
Additional info

Q
A

Version
1.0.?

PHP version
8.2.1

Operating system
Windows 10

The bootstrap node modules are missing.

Run docker-compose run php npm update.

For WAMP:
Installing npm_modules folder containing bootstrap as mentioned in package.json

Step 1: Download node.js at https://nodejs.org/en/download
Step 2: Ensure C:\ProgramFiles\nodejs is in environment variable path. Search ... edit the system environment variables
Step 3: Run ````npm i```` in c:\wamp64\yii3-i\blog folder.


Fixed in ec669a0c452b5cf5983ee026f06444c5b4ac860b


Feature Request - Model scale

Would it be possible to receive result with approximately correct scale?
Considering that the mobile camera focal length is provided you should be able to do the triangulation and calculate the scale of the model, right?

We don't support this RGB (image) method to obtain result.
May I ask what your scenario is? Is there any other way to implement the function in your project in addition to the one in your issue? We will consider adding this capability if it's highly needed in the future. But it needs to be reminded that  additional sensors are needed to achieve this capacity, and sensors have high requirements on hardware equipment, which need to be tested with appropriate equipment.

There is increasing demand of composing scenes using created 3D models. The problem is that the models have different scales and setting the scale backwards manually ends usually wrong.
Image for example scanning objects in a furniture shop and using AR put it in your room. If the scale is wrong you might do a wrong decision.
I tried to automatically rescale the results myself but the AR pointcloud I collected had different orientation and contained background points. I would need at least for some vertices of the scan UV coordinates in captured photos...

service exception error code 1112


Hotfix Develop: Fix overriding default rules

Fixes an issue with default rules always being merged into user defined configurations even if merge-default-rules is set to false.
Fixes #309
DCO 1.1 Signed-off-by: Dan Purdy<EMAIL_ADDRESS>

It's fine in atom and mou..


Support typed arrays in the extension API dump

Summary
Currently we're using {"type: "typedarray::Node"} to represent a typed array.
This PR changes this to: {"type": "Array", "array_type": "Node"}.
Changing the value of type breaks compatiblity.
Details
Adds optional array_type field to specify the type of the array element when type is Array (for example in Node::get_children).
The JSON for Node::get_children with this PR is now:
{
	"name": "get_children",
	"is_const": true,
	"is_vararg": false,
	"is_static": false,
	"is_virtual": false,
	"hash": 873284517,
	"return_value": {
		"type": "Array", // <-- This is modified with this PR
		"array_type": "Node" // <-- This is added with this PR
	},
	"arguments": [
		{
			"name": "include_internal",
			"type": "bool",
			"default_value": "false"
		}
	]
},

Alternative design

#64469

Your issue with the hint seems to be similar to what I have already encountered as some point too.
https://github.com/godotengine/godot-headers/issues/67

@CedNaru Thanks! After reading that it's still not clear to me if the JSON should leave that as is. I think other places use the type name directly without the need to specify the hint so I think I'll trim the leading 24/17: then.

By the way shouldn't you use  pinfo.hint && PROPERTY_HINT_ARRAY_TYPE instead of pinfo.hint == PROPERTY_HINT_ARRAY_TYPE like in the rest of the code ?
pinfo.hint is a bitfield, several hints can be set in it, and if that's the case your == won't work anymore.

Regarding
"return_value": {
  "type": "Array",
  "array_type": "Node" # <-- This is added with this PR
},

Are we sure Array is the only class that will have generics? What about Dictionary, or possibly even user-defined classes in the future?
Also, are nested annotations allowed, e.g. Array<Array<int>>?

Maybe the notation could be written more general:
# Array<Node>
"return_value": {
  "type": "Array",
  "generic_types": ["Node"]
},

# Dictionary<String, *> (if that's ever a thing)
"return_value": {
  "type": "Dictionary",
  "generic_types": ["String", "Variant"]
},

# Array<Array<int>>
"return_value": {
  "type": "Dictionary",
  "generic_types": [{
    "type": "Array",
    "generic_types": ["int"]
  ]},
},

In essence, a type could then either be a string "Ty" or a JSON document { "type": "Ty", generic_types: [...] }.
It's also possible to rename generic_types to generic_args.

Are we sure Array is the only class that will have generics? What about Dictionary, or possibly even user-defined classes in the future?

My idea was other classes would use a different JSON field, so for dictionaries it could be:
"return_value": {
	"type": "Dictionary",
	"dictionary_key_type": "String",
	"dictionary_value_type": "int"
},

The type field value would let you know which optional fields you can check for, and if the generic type is Variant (unspecified) then the field would not appear in the JSON. Something like:
auto return_type = read_json_return_type();

if (return_type["type"] == "Array") {
	String array_type = "Variant";
	if (return_type.has("array_type")) {
		array_type = return_type["array_type"];
	}
	// Do something with the Array type
} else if (return_type["type"] == "Dictionary") {
	String key_type = "Variant";
	String value_type = "Variant";
	if (return_type.has("dictionary_key_type")) {
		key_type = return_type["dictionary_key_type"];
	}
	if (return_type.has("dictionary_value_type")) {
		value_type = return_type["dictionary_value_type"];
	}
	// Do something with the Dictionary type
}

Also, are nested annotations allowed, e.g. Array<Array<int>>?

I don't think they are supported in ClassDB at all because I'm using the PROPERTY_HINT_ARRAY_TYPE which I don't think supports nested generics and I don't think there's any API in Godot right now that uses nested generics.

I can see how this won't scale if we have more generic classes than Array and Dictionary but I don't really think any other generic classes would be added to the engine anytime soon and user-defined generic classes is also unlikely to happen in my opinion (not that I don't want it to happen because I love generics but it just doesn't seem likely, we don't even support method overloading in ClassDB).
I do like your idea better and kinda wanted to implement it like that at the beginning since it's more similar to how generic parameters work in C# reflection APIs but I thought it'd be better to keep it simple.

The question is: do we anticipate that at some point, more classes may have generic parameters than just currently Array?
A generic_types or generic_args field holding a list would support both the current case and any future cases, and not need hardcoded field names such as dictionary_key_type. On the other hand, with hardcoded fields, the Variant means field absent works well as you mentioned.
Your deserialization example is procedural because C++ doesn't have JSON mapping frameworks. Languages that support some sort of reflection however, would likely use a declarative version, e.g. Rust:
// Note: Option is like std::optional, meaning value can be absent
// Vec is like std::vector

#[derive(Deserialize)]
struct ReturnType {
    type: String,
    generic_args: Option<Vec<String>>,
}

and with your proposal:
#[derive(Deserialize)]
struct ReturnType {
    type: String,
    array_type: Option<String>,
    dictionary_key_type: Option<String>,
    dictionary_value_type: Option<String>,
    ... // more for others?
}

I'm pretty sure C# offers something like that as well. I think both approaches are possible, let's maybe see what engine developers think about it.

@Bromeon I opened #64469 with your proposed design.

regarding #64469 vs #54249, I'd rather have dedicated array_type/dictionary_key_type/dictionary_value_type than a generic_args.
This is because the first approach is more explicit which is really important considering there is basically no documentation for extension_api.json (appart from reading Godot source code ^^)
Generics support with variant is only informative (i.e. there is no guarantee the declared type will be respected at runtime). On top of that generic typing support for custom classes is a complex topic (see for instance how much energy Python community put into this). So I don't think support for deep nested generic types (Array[Array[Dictionary[String, int]]]) is coming any time soon, and when/if it come I don't see a real benefit for the extension_api.json (especially since there is the native_structures that already fill the need for typed parameters/return value in Godot standard api)
So I'd much rather take the YAGNI pragmatic approach there :smiley:

See also #65817.

Needs rebase.

We could rediscuss this in next week's GDExtension meeting and see if we're all happy with the merged option or if we want to change it further. I think it's still OK to break compatibility if we need to to get a solid base for 4.x.

Glad to hear it's implemented 🙂
I'm not too convinced the :: approach is the best one (in general, not just here), because it's essentially a poor-man's reinvention of JSON fields -- another undocumented protocol inside JSON that requires consumers to manually parse strings. It probably works as long as all parts are alphanumeric, but if ever double-colons enter the value space, it will cause problems.
If there were a small spec of this internal protocol, things would already be quite a bit easier.

Closing for now:

The changes in this PR break compat and we'd rather not do that unnecessarily.
Generic typed arrays are already supported, although it uses a different format (see https://github.com/godotengine/godot/pull/65817). So this PR doesn't allow anything that isn't already possible.
If/when we need to add additional information to the API dump, we can re-asses the format.
The current format (typedarray::Node) needs to be documented.


[BUG]: Clicking pay by card creates an invalid order

Is there an existing issue for this?

[X] I have searched the existing issues.

🐞 Describe the Bug
I click pay by credit/debit card. A PayPal dialog box shows a loading image and closes, and the created order Id is given.
When I go to Subscriptions in the dashboard, no orders/subscriptions are listed. When I search on the given order Id it finds it, but the order appears to be invalid. It has no status, and clicking on the order details displays an error page.
😕 Current Behavior

Not prompted for card details.
An invalid order is created with no error message.

🤔 Expected Behavior

I expect to be prompted for card details.
An error message should be displayed instead of creating an invalid order.

🔬 Minimal Reproduction
1. Setup a page to create a subscription.
2. Click on pay be credit/debit card.

🌍 Environment
| Software         | Version(s)  |
| ---------------- | ----------- |
| react-paypal-js  | 7.8.2       |
| Browser          | Firefox 109 |
| Operating System | Fedora 37   |

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

➕ Anything else?
No response

i faced the same issue , please if you have a solution share it with me.

I gave up and went with Chargebee. They support PayPal as a payment processor.


[Request] Export GitTabExpansion

I've written a tiny module to configure aliases for git subcommands to omit typing git.
https://gitlab.com/igrep/pwsh-git-aliases/blob/master/GitAliases.psm1
Then, I want to configure TabExpansion for the generated aliases by reusing the GitTabExpansion function.
So can you export GitTabExpansion to make it reusable?
P.S. Thank you for an excellent module! I use it every day!

Sure: #563

P.S. Thank you for an excellent module! I use it every day!

You are very welcome.

Aside: instead of...
Enable-GitAliases([boolean] $avoidConflicts = $true)

It would be more PowerShell-y to use:
Enable-GitAliases([switch] $AllowClobber)


Add FindIlmBase.cmake

Added CMake module to make compiling non-conan-aware projects easier.

Thanks for the PR !

No problem.


Ingress is unable to find services running in other namespaces.

Rancher versions: 2.0.2
rancher/server or rancher/rancher: 2.0.2
rancher/agent or rancher/rancher-agent: 2.0.2
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable): 1.10
Docker version: (docker version,docker info preferred): 17.03.2-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred): Ubuntu 16.04
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO): VirtualBox
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB): Single node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos): Kubernetes
Steps to Reproduce:
I have installed k8s (1.10) using rancher 2.0. This is what the ingress yaml while installing the cluster to expose the rancher dashboard:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
namespace: cattle-system
name: cattle-ingress-http
annotations:
nginx.ingress.kubernetes.io/proxy-connect-timeout: "30"
nginx.ingress.kubernetes.io/proxy-read-timeout: "1800"   # Max time in seconds for ws to remain shell window open
nginx.ingress.kubernetes.io/proxy-send-timeout: "1800"   # Max time in seconds for ws to remain shell window open
nginx.ingress.kubernetes.io/ssl-passthrough: "true"      # Enable ssl-passthrough to backend.
spec:
rules:

host: myservice.com
http:
paths:

backend:
serviceName: cattle-service
servicePort: 443

This works fine. But when I add one more service into ingress by editing the active ingress by 'kubectl edit ingress cattle-ingress-http -n cattle-system':

host: myservice-grafana.com
http:
paths:

backend:
serviceName: kube-prometheus-grafana
servicePort: 80

This new ingress rule does not work. I get "503 Service Temporarily Unavailable" when I hit http://myservice-grafana.com. The ingress pod logs shows:
$kubectl logs nginx-ingress-controller-cmcz6 -n ingress-nginx
NGINX Ingress controller
Release:    154a606-dirty
Build:      154a606
Repository: git@github.com:rancher/ingress-nginx.git
I0702 07:05:09.472942       5 main.go:181] Creating API client for https://<IP_ADDRESS>:443
I0702 07:05:09.502494       5 main.go:193] Running in Kubernetes Cluster version v1.10 (v1.10.1) - git (clean) commit d4ab47518836c750f9949b9e0d387f20fb92260b - platform linux/amd64
I0702 07:05:09.505446       5 main.go:84] validated ingress-nginx/default-http-backend as the default backend
I0702 07:05:10.248658       5 stat_collector.go:77] starting new nginx stats collector for Ingress controller running in namespace  (class nginx)
I0702 07:05:10.252827       5 stat_collector.go:78] collector extracting information from port 18080
I0702 07:05:10.269484       5 nginx.go:244] starting Ingress controller
I0702 07:05:11.381434       5 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"cattle-system", Name:"cattle-ingress-http", UID:"6525b6b3-792e-11e8-b914-00155d7a541c", APIVersion:"extensions", ResourceVersion:"855783", FieldPath:""}): type: 'Normal' reason: 'CREATE' Ingress cattle-system/cattle-ingress-http
I0702 07:05:11.482128       5 store.go:613] running initial sync of secrets
I0702 07:05:11.483792       5 nginx.go:665] starting TLS proxy for SSL passthrough
I0702 07:05:11.484021       5 nginx.go:266] starting NGINX process...
W0702 07:05:11.484796       5 controller.go:666] error obtaining service endpoints: error getting service cattle-system/kube-prometheus-grafana from the cache: service cattle-system/kube-prometheus-grafana was not found
The service account 'nginx-ingress-serviceaccount' has clusterrole binding and so ingress should not have any issue
in accessing services running in another namespace. (kube-prometheus-grafana is running in namespace 'monitoring' and ingress is running in namespace 'cattle-system'). Moreover, why is the ingress looking for kube-prometheus-grafana inside the namespace 'cattle-system' ?
nginx-ingress-controller image that rancher pulls in is 'rancher/nginx-ingress-controller:0.10.2-rancher3'(image id: docker-pullable://rancher/nginx-ingress-controller@sha256:58944b175505087dfa7afc444577d1933fd3bf1f1f668ef57b9eaaa8b36f59ce)
Results:
Hit http://myservice-grafana.com:
"503 Service Temporarily Unavailable"

Thanks for your report.
This is a K8S limitation.  Please check https://github.com/kubernetes/kubernetes/issues/17088#issuecomment-156287304


Not getting SMS when I register new user

Is that a bug? Needs a config?

I am also not able to receive sms messages.  I have aws-exports.js in my src directory and i confirmed that user-signin is enabled in awsmobile features.


Can't import changes in the core store table

Bug report
Issues trying to import config changes in core store settings in Strapi 4.14.5
Describe the bug
The config changes can easily get exported, but can't get imported.
Steps to reproduce the behavior
Assuming there is an article type.
for key 'plugin_content_manager_configuration_content_types::api::article.article'
Running version 4.14.5

In local environment do changes requiring changes in the key mentioned above - for example, change a label on a field, make read only, add new field, etc.
Export config changes and commit in the repo
Release changes to the hosted environment
In Settings/ConfigSync/Interface page you can see a difference in the config.
Click import button
You can see the config in diff state and changes are not persisted
3

Expected behavior
Config changes in core store are imported
Screenshots
If applicable, add screenshots to help explain your problem.
Code snippets
If applicable, add code samples to help explain your problem.
System

Node.js version: 18.18.1
NPM version: 9.8.1
Strapi version: 4.14.5
Plugin version: 1.1.3
Database: postgreSQL
Operating system: debian linux

Additional context
Add any other context about the problem here.

Probably a duplicate of #110

Are you sure you're running version 1.1.3 of the plugin?

Hey,
Yes, been having these issues since yesterday when I updated strapi to 4.14.5. I had the plugin in version 1.1.3. I tried updating the plugin but it didn't help.

Hmm. Then it might not be a duplicate of #110.
I'll investigate later.

Thank you!

I's lso like to say that other config changes, like admin-role.strapi-author.json go through without issue. I only have an issue with importing changes for the key 'plugin_content_manager_configuration_content_types::api::article.article'

Gotcha. That's why I thought it might be related to #110 as that issue also only happens for plugin_content_manager_configuration_content_types.... config files.

@jklimonda Could you run a yarn why strapi-plugin-config-sync and paste the output in a comment on this issue.

I've made a new release with some fixes (v1.2.2)
Could you install that and see if the issue is resolved?

Hey. Sorry for late response, today I could test the config changes with the new plugin. It works fine in version 1.2.2
Thank you very much for a rapid fix.


Every time I select date it is triggered submit

When I have the calendar in a form, every time I select a date the form is submitted

I think the button in DayCell is missing type="button".

Fix on master. Will be released with next alpha version. You can follow up from this issue https://github.com/Adphorus/react-date-range/issues/198


Style of selected tab differs between tab link and basic tab

When I use appearance="primary" for tab, style of the selected tab differs between tab link and basic tab.
Is it by design or a bug?
I examined the stylesheet and it seems to be a bug since the css selector looks not correct:
.ub-tfrm_qu4iyp_1d0tz5k[aria-current="page"], .ub-tfrm_qu4iyp_1d0tz5k[aria-selected="true"]:before {
    transform: scaleY(1);
}

I think it should be like this:
.ub-tfrm_qu4iyp_1d0tz5k[aria-current="page"]:before, .ub-tfrm_qu4iyp_1d0tz5k[aria-selected="true"]:before {
    transform: scaleY(1);
}

or at least, the selected tab link should have aria-selected="true" attribute.
Rendered Example

Code
import React from "react";
import {
  Pane,
  Tablist,
  TabNavigation,
  Paragraph,
  Tab,
  Heading,
} from "evergreen-ui";

/** Example copied from https://evergreen.segment.com/components/tabs#accessibility and modified to use appearance="primary" on Tab component */
function BasicTabsExample() {
  const [selectedIndex, setSelectedIndex] = React.useState(0);
  const [tabs] = React.useState(["Traits", "Event History", "Identities"]);
  return (
    <Pane height={120}>
      <Tablist marginBottom={16} flexBasis={240} marginRight={24}>
        {tabs.map((tab, index) => (
          <Tab
            aria-controls={`panel-${tab}`}
            isSelected={index === selectedIndex}
            key={tab}
            appearance="primary"
            onSelect={() => setSelectedIndex(index)}
          >
            {tab}
          </Tab>
        ))}
      </Tablist>
      <Pane padding={16} background="tint1" flex="1">
        {tabs.map((tab, index) => (
          <Pane
            aria-labelledby={tab}
            aria-hidden={index !== selectedIndex}
            display={index === selectedIndex ? "block" : "none"}
            key={tab}
            role="tabpanel"
          >
            <Paragraph>Panel {tab}</Paragraph>
          </Pane>
        ))}
      </Pane>
    </Pane>
  );
}

/** Example copied from https://evergreen.segment.com/components/tabs#tab_link_usage and modified to use appearance="primary" on Tab component */
function TabLinkExample() {
  const tabs = React.useMemo(
    () => ["Traits", "Event History", "Identities"],
    [],
  );
  // State is only used here for demo purposes, your routing abstraction might support hash links
  const [selectedIndex, setSelectedIndex] = React.useState(0);

  return (
    <TabNavigation>
      {tabs.map((tab, index) => {
        const id = tab.toLowerCase().replace(" ", "-");
        const hash = `#${id}`;
        return (
          <Tab
            href={hash}
            is="a"
            isSelected={selectedIndex === index}
            appearance="primary"
            key={tab}
            onClick={() => setSelectedIndex(index)}
          >
            {tab}
          </Tab>
        );
      })}
    </TabNavigation>
  );
}

function App() {
  return (
    <Pane margin={16}>
      <Pane marginBottom={8}>
        <Heading marginBottom={8}>Basic Tab</Heading>
        <BasicTabsExample />
      </Pane>
      <Pane marginBottom={8}>
        <Heading marginBottom={8}>Tab Link</Heading>
        <TabLinkExample />
      </Pane>
    </Pane>
  );
}

export default App;

Package version
    "evergreen-ui": "^7.1.4",
    "react": "^18.1.0",
    "react-dom": "^18.1.0"

Hmm, this looks like a regression from the V7 changes. The same code looks fine in v6.13.3: https://codesandbox.io/s/issue-1622-selected-tab-doc3fp
It looks like using the Link component instead of an a tag directly should also style correctly, as a workaround:
<Tab
  href={hash}
  is={Link}
  isSelected={selectedIndex === index}
  appearance="primary"
  key={tab}
  onClick={() => setSelectedIndex(index)}
>
  {tab}
</Tab>

Thanks for the reply! I'll use the workaround until the fix is applied.

I do think you're on to something with the incorrect selectors being generated - I think that's an edge case in the newer ui-box features that wasn't handled properly. The selector for _current maps to this:
https://github.com/segmentio/evergreen/blob/e13b9b4f2609ed3ecb5f7dc218dfe4fe1a1da048/src/tabs/src/Tab.js#L27
The nested selectors defined in the theme (i.e. :before and :after) should be attached to both of these:
https://github.com/segmentio/evergreen/blob/e13b9b4f2609ed3ecb5f7dc218dfe4fe1a1da048/src/themes/default/components/tab.js#L45-L51
However, these are only being attached to the last of the parent selectors, as you noted:
-.ub-tfrm_qu4iyp_fiauus[aria-current="page"], .ub-tfrm_qu4iyp_fiauus[aria-selected="true"]:before {
+.ub-tfrm_qu4iyp_fiauus[aria-current="page"]:before, .ub-tfrm_qu4iyp_fiauus[aria-selected="true"]:before {
  transform: scaleY(1);
}

I should have a PR up there to fix it soon, and then we can bring it in here. It seems to solve the issue without having to change the existing tab.js theme file.

Once this lands, I don't think you should need the aria-selected={selectedIndex === index} prop anymore (since it sets aria-current="page" internally if isSelected is true).


Gallery / Success Stories

We should add a section "Gallery" (or similar), which shows projects done with Wegue in the README and the upcoming website.
Therefore we should collect addresses / references to projects build upon Wegue. Please add such references in here as comments.

https://bevinggevoeld.nl/oeds/groot/
https://www.starkregengefahr.de/baden-wuerttemberg/glems/

https://wegue.heron-mc.org/

https://map.naturpark-lueneburger-heide.de/  - how could I forget this one ;-).

If possible a one-liner as description and a link to a public source code repo (if available) would be nice to have for the given links. So we can use this on the Wegue website. Thanks for any hint / support.

closed with https://github.com/meggsimum/wegue/pull/167


Soko Puzzle Game Mode

Working on Sokoban, again.
Greg on sprite art, @BlueScrewy also on programming (again).
Tasks: https://github.com/users/hunterdyar/projects/9/

@hunterdyar not sure why this got closed. It ain't done. Get to it!

Merged! I want to write some instructions on the main menu though


Is the project still maintained?

Hi - I wanted to check if the project is still maintained. If yes, would you be open to a PR with the following changes?

switch from vendoring dependencies to using Go modules
replace the current go-powershell dependency with https://github.com/antoninbas/go-powershell. This fork converts the project to Go modules and removes the dependency on juju packages (which are distributed under an LGPL v3 license, making usage in commercial products difficult)

Additionally, would you be willing to make a Github release/ create a tag after making the changes above?
Thanks

Sure happy to help with this!
On Wed, Jan 27, 2021, 7:46 PM Antonin Bas<EMAIL_ADDRESS>wrote:

Hi - I wanted to check if the project is still maintained. If yes, would
you be open to a PR with the following changes?

switch from vendoring dependencies to using Go modules
replace the current go-powershell dependency with
https://github.com/antoninbas/go-powershell. This fork converts the
project to Go modules and removes the dependency on juju packages (which
are distributed under an LGPL v3 license, making usage in commercial
products difficult)

Additionally, would you be willing to make a Github release/ create a tag
after making the changes above?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rakelkar/gonetsh/issues/13, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2CTBJ43CVDFDO5ZKDQJRDS4DMZZANCNFSM4WWLVE6Q
.

Sure happy to help with this!
On Wed, Jan 27, 2021, 7:46 PM Antonin Bas<EMAIL_ADDRESS>wrote:

Hi - I wanted to check if the project is still maintained. If yes, would
you be open to a PR with the following changes?

switch from vendoring dependencies to using Go modules
replace the current go-powershell dependency with
https://github.com/antoninbas/go-powershell. This fork converts the
project to Go modules and removes the dependency on juju packages (which
are distributed under an LGPL v3 license, making usage in commercial
products difficult)

Additionally, would you be willing to make a Github release/ create a tag
after making the changes above?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rakelkar/gonetsh/issues/13, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2CTBJ43CVDFDO5ZKDQJRDS4DMZZANCNFSM4WWLVE6Q
.

@rakelkar Thanks for merging #14. Do you think you could create a Github release tag?

https://github.com/rakelkar/gonetsh/releases/tag/v0.3.2 works?

Works for me, but why not start at v0.1.0 or something similar?


Integration with appcenter build

Hi,
is there a possiblitiy to integrate with appcenter thru setting the ENVFILE? Setting it as global variable doesnt work. Thanks

@ivanpagac any luck with this? I'm also trying to get my app set up in AppCenter but not sure how to approach setting it up to use react-native-config.

@jordanmkoncz for the ios its quite straightforward, just create new scheme and use it in your build. With Android I assume as per the code for gradle describes the order of precedence how to pick the right config file. For me setting up the ENVFILE in appcenter build was enought as this is a sys variable and is picked first. I was using wrong global variable .ENVFILE (with the . at the beginning) thats why it was not picking it.

@jordanmkoncz if you are still having issues, on iOS builds make sure to follow the instructions for adding build scripts to your build. RN Config uses a pre-build script on iOS to set the correct env file. The best I've found for Android is to use the ENV App Center provides.

@jordanmkoncz for the ios its quite straightforward, just create new scheme and use it in your build. With Android I assume as per the code for gradle describes the order of precedence how to pick the right config file. For me setting up the ENVFILE in appcenter build was enought as this is a sys variable and is picked first. I was using wrong global variable .ENVFILE (with the . at the beginning) thats why it was not picking it.

For Android, does this mean we can't tell the Microsoft Visual Studio App Center to look at the .env files we create then? I couldn't quite grasp what you were saying when you mentioned setting up the ENVFILE in appcenter build.
Like you said, with iOS we can redirect the Build configuration to look at the different schemes, so it can read the specific .env file we've tied to that scheme.

I would rather not have to manually enter the environment variables into the build configuration in App Center, but instead have it read directly from a specific .env file for each of my branches.

any updates here?

+1

@ivanpagac Can you please elaborate on "setting up the ENVFILE in appcenter build"? What exactly did you do? Thank you very much.

@ivanpagac @sabun123 any updates?

@sabun123 I faced your exact issue. What I found is that the env variables set in Appcenter build config can be accessed in very specific ways as shown here. I got it to work with react-native-config by creating a appcenter-pre-build.sh script
#!/usr/bin/env bash
# Creates an .env from existing env files for use with react-native-config
# based on branch
if [  "$APPCENTER_BRANCH" == "master" ]; then
   cp .env.prod .env
else
   cp .env.dev .env
fi

printf "\n.env created with contents:\n"
cat .env

Thus achieving what you were looking :

I would rather not have to manually enter the environment variables into the build configuration in App Center, but instead have it read directly from a specific .env file for each of my branches.

Lemme know if it helps
@vforvasile @platonish  Alternatively instead of tying the environment config to a branch name we can specify the same in Appcenter config like this:

And then having a pre build script in this form:
#!/usr/bin/env bash
# Creates an .env from ENV variables for use with react-native-config
if [ $ENVIRONMENT_VARIABLE = "prod" ]; then
   cp .env.prod .env
else
   cp .env.dev .env
fi

printf "\n.env created with contents:\n"
cat .env

Also the following script is very useful if you want to pick out certain ENV variables(matching a pattern) from Appcenter Build config and create .env file
#!/usr/bin/env bash
# Creates an .env from ENV variables for use with react-native-config
ENV_WHITELIST=${ENV_WHITELIST:-"^RN"}
printf "Creating an .env file with the following whitelist:\n"
printf "%s\n\n" $ENV_WHITELIST
set | egrep -e $ENV_WHITELIST | egrep -v "^_" | egrep -v "WHITELIST" > .env
printf "\n.env created with contents:\n"
cat .env

For example this will create .env file which has RN_LABEL=APP_NAME alone (refer image)

If this works @arjithn you're my hero!

App Center works fine for me when I mention the ENVFILE in the Environment variables

I haven't been able to find this in the documentation, but isn't it supported to simply specify environment variables normally, outside of the .env file, which react-native-config would pick up? The point of the .env file is to help set up development, in a production/build environment it's better to specify real environment variables.
Then there would be no reason to use ENVFILE or other prebuild scripts.

It seems like "real" environment variables are not supported, but using printenv to write them to a file seems to work.
That means adding printenv > .env to appcenter-pre-build.sh, that way you can use any environment variable set up via the AppCenter UI.

@andreialecu point should be more loud and clear:
The Environment variables section does not inject variables into your app
So create an .env file programmatically via appcenter-pre-build.sh

If you add the AppSecret to each .env file, you can access it by BuildConfig.ANDROID_APP_CENTER_SECRET in Android and NSString *appSecret = [ReactNativeConfig envFor:@”IOS_APP_CENTER_SECRET”]; in iOS. That way you don't even need to create Config.plist or add to asset.
I wrote an article about it that may help: https://medium.com/@aureosouza0801/integrate-appcenter-and-react-native-config-85d44b7a3d2


new security rule: insecure-buffer-usage

detect-new-buffer
// Detects instances of new Buffer(argument)
// where argument is any non literal value.
https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-new-buffer.js

Also detect this issue: https://snyk.io/blog/exploiting-buffer/

Also detect this issue:
Tries to detect buffer read / write calls that use noAssert set to true
https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-buffer-noassert.js

💀 It's time! 💀
TSLint is being deprecated; therefore, it and tslint-microsoft-contrib are no longer accepting pull requests for major new changes or features. See #4534. 😱
If you'd like to see this change implemented, you have two choices:

Recommended: Check if this is available in ESLint + typescript-eslint ✅
Not Recommended: Fork TSLint or tslint-microsoft-contrib locally 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!


Align RNA data with existing repository

In order to make feature IDs in the RNA expression levels point to features within an existing repository three changes were made. The rnaseq2ga script now accepts a repository path.
First, when writing expression levels to the database features are searched within the first feature set in the first dataset found. Features are matched based on name and the resulting feature ID is written to the database.
Second, the signature of the usage of this script in prepare compliance data was changed.
And third, the rna data model needed to be modified to read from the feature ID column. It was reporting the 'id' for both name and featureId.
@saupchurch @dcolligan

+1


Replace TravisCI into GHAction

after updating package information, it seems working on GHAction.
pushing this for future use?

Thanks @himorin I'm not sure how active this repo will be considering WebVR is deprecated but it's useful to push changes as needed.

@AdaRoseCannon Thank you for merging.
Yeah, this repo should be inactive, but we need to update webvr.rocks with redirecting to immersiveweb.dev, which is done by this PR! ;)

Oh perfect, thank you!!


Add numerical to godot String and StringType conversion

This allows for
auto myDouble = 434.0.String;
auto myFloat = 434f.String;

auto myDouble2 = 434.0.StringName;
auto myFloat2 = 434f.StringName;

Instead of
import std.conv : text;
auto myDouble = 434.0.text.String;
auto myFloat = 434f.text.String;

auto myDouble2 = 434.0.text.StringName;
auto myFloat2 = 434f.text.StringName;

Looks like previously it was not allowed to just pass it to ctor, and this current example doesn't illustrate potential benefits well enough.
So I assume the real value of this addition is to be able to use it in such cases where you have method returning numerals and not just numeric literals, right?
Something like this
ui.setTimeRemainingText(String(game.timeRemaining));

Yes something like
fpsLabel.text = String(Engine.getFramesPerSecond());


Auto pricing issue

🐞 bug report
Describe the bug

To Reproduce

Expected behavior

Screenshots

🌍  Your Environment

OS:  e.g. Win7 x64
Version:  e.g. 0.6.9 portable
PoE:  e.g. Steam 3.10.0/e English

When you go to auto price an item in the stash it will click on the chatbox instead of typing the value of the selected item

Duplicate of #489


Release/0.19.2

Codecov Report

Merging #565 (f744f4d) into main (b45416a) will increase coverage by 0.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   96.56%   97.14%   +0.57%
==========================================
  Files          56       56
  Lines        2303     2308       +5
==========================================
+ Hits         2224     2242      +18
+ Misses         79       66      -13

Impacted Files
Coverage Δ

pfhedge/autogreek.py
100.00% <ø> (ø)

pfhedge/instruments/derivative/base.py
93.02% <ø> (ø)

pfhedge/instruments/derivative/european_binary.py
100.00% <ø> (ø)

pfhedge/nn/functional.py
91.56% <100.00%> (+5.33%)
:arrow_up:

pfhedge/nn/modules/bs/european_binary.py
100.00% <100.00%> (ø)

pfhedge/version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45416a...f744f4d. Read the comment docs.


Support macos arm64 in ANGLELoader

See https://github.com/libgdx/gdx-angle-natives/pull/1

I need to figure out how to build the arm64 binaries on macOS for angle, but let's merge this for now. I have an M1 laptop to test.

Nm, just saw the PR on the other repo. I'll updated the natives now.


Error message on package index update is unclear

Hi,
If there is no internet connection while updating package index, the error message is "Failed to write package index". It seems rather that the error is "Failed to download package index". I was a bit surprised and thought there was a problem with the underlying storage.
Thanks!
Cam

Ah, thanks, I'll make this clearer.


Fixing the user command + some little improvement in help

Headline says everything.

README updated.

There were some conflicts with my files while you were committing.
Everything should be done now and can be merged.


Horse version  ?

Hi,
thanks for your mod ! An horse version is planned ? :)
Thanks.

There has never been any plans for horse support, no. I don't mean to sound like a takedown, but what would a horse HUD even display? There's no drifting because the controls are immediately responsive, horses accelerate and decelerate very quickly, speed could be there but that's such a generic thing to track, player name and ping? Sure, that could be the BoatHud signature.
The speed bar would be a funny one: there's absolutely no benefit for running horses across different surfaces, not even stairs and foot paths (at high enough speeds, the server gets confused on how you're moving and thinks you're cheating). For the boat "version", it's there because boats on ice are much more difficult to control than on water, and the ice gives them a speed boost. The speed bar helps the player judge how fast they're going by visualizing said speed, but on a horse, you can just let go of W to stop. Not to mention, what would be the upper limit of the speed bar? The fastest horse speed available in vanilla survival? Or the top speed of the horse?
Inputs are also interesting because you need mouse to steer a horse, but mouse inputs are not easy to transform into a small HUD element while also keeping precision.
I could add the name of the horse and how full a donkey's or a mule's inventory is, but last time I tried to do it with chestboats, it was nontrivial. I'll have to investigate how it is now and if it's changed in the 20.3 snapshots because who knows what might happen xd very large undocumented changes are good to keep the game healthy xd!.
If you have any ideas, let me know, I'd love to hear them.


If the only path is a loop then counted as the shortest path.

This is a fix for #12941

Thank you. It is pretty straightforward, but could we have a bit more description so that won't lose track of the patch in the future?

I can do either... Are you asking me to better comment the code or improve the PR description?

PR description or commit message, which will show in git log so that people don't need to click the issue link and open a browser. It's pretty minor and not a blocker :)

Edited the PR description. let me know if that's better, or is there somewhere else you want it.

@bors r+

:pushpin: Commit d19273c04d77323bdc3dbbece646d05ef29edb18 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit d19273c04d77323bdc3dbbece646d05ef29edb18 with merge 6658e1abe30eb0553f7f3f4a0071771e3ca07c1c...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 6658e1abe30eb0553f7f3f4a0071771e3ca07c1c to master...


How to make result privilege different?

Hello
how to make result with admin to list result to member (normal) view ? is possible? privilege
Look a error:
http://prntscr.com/9aauaz
Thanks
Live:sandro.alvares

Hello Sandro,
I do not fully understand your question. Bases on your screen-shot has the under not the needs read permission.
In case you ask how to perform the query with the permission of an other user: This is not possible.
Daniel
Von meinem Windows Phone gesendet

Von: Sandro<EMAIL_ADDRESS>Gesendet: 04.12.2015 17:52
An<EMAIL_ADDRESS>Betreff: [CrmFetchKit] How to make result privilege different? (#9)
Hello
how to make result with admin to list result to member (normal) view ? is possible? privilege
Look a error:
http://prntscr.com/9aauaz
Thanks
Live:sandro.alvares

Reply to this email directly or view it on GitHub:
https://github.com/thuld/CrmFetchKit/issues/9

Hi Sandro,
In order to run query CRM as an elevated user you need to have a bespoke
backend solution (plugin or workflow) which then you can execute for a
given system event under specific credentials, including admin service
account.
It is not possible to bypass system security model via web service queries,
you always impersonate current user.
Thanks,
Piotr
On Friday, December 4, 2015, Daniel Thul<EMAIL_ADDRESS>wrote:

Hello Sandro,
I do not fully understand your question. Bases on your screen-shot has the
under not the needs read permission.
In case you ask how to perform the query with the permission of an other
user: This is not possible.
Daniel
Von meinem Windows Phone gesendet

Von: Sandro<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
Gesendet: 04.12.2015 17:52
An<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','CrmFetchKit@noreply.github.com');>>
Betreff: [CrmFetchKit] How to make result privilege different? (#9)
Hello
how to make result with admin to list result to member (normal) view ? is
possible? privilege
Look a error:
http://prntscr.com/9aauaz
Thanks
Live:sandro.alvares

Reply to this email directly or view it on GitHub:
https://github.com/thuld/CrmFetchKit/issues/9
—
Reply to this email directly or view it on GitHub
https://github.com/thuld/CrmFetchKit/issues/9#issuecomment-162032739.

sorry brother, bad english!
So i know is not work! Its crm just xml, odata and wsdl are impossible are self member, i was thinking make crm with api from server, account token with admin to return value a resource web
Im try soap php are hard wsdl
:+1: thanks! :-/

Problem seems to be solved.


Testing: Switch to JUnit5

We could use newer version of JUnit
https://github.com/mannodermaus/android-junit5

Done https://github.com/igorwojda/android-showcase/pull/141


Support for data attributes

In practice, acsets almost always have data attributes, e.g., Petri nets might have labels for the states and/or transitions and rate constants for the transitions.
Editing attributes with Semagrams could become arbitrarily sophisticated, but I figure that to get started it would be enough to have editing support for text attributes (String and Symbol) and numeric attributes (Int and Float*).

I'm not going to close this until I get attributes for wires working, #12 did not get this.

Also, the numerical input needs to be more user-friendly; it should show the current number, and also allow setting of max/min for the slider.


⚠ Bofrost.at has degraded performance

In 24b1cfc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1616 ms

Resolved: Bofrost.at performance has improved in 1102cea after 13 minutes.


tf.compat.v1.signal.rfft2d and rfft3d lacks input validation leading to crashes

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): N/A
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.8.0
Python version:3.7.12
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 11.2 (based on a colab notebook)
GPU model and memory: Tesla T4, 15109MiB (based on a colab notebook)

Describe the current behavior
The following code snippets lead to crashes when executed:
import numpy as np
import tensorflow as tf

a = np.empty([6, 0])
b = np.array([1, -1])
try:
  tf.compat.v1.signal.rfft2d(input_tensor=a,fft_length=b)
  # on a different machine: Check failed: size >= 0 (-9223372036854775808 vs. 0)
  # Aborted (core dumped)
except:
  pass

print('execution does not reach this line')

and
import numpy as np
import tensorflow as tf

a = np.empty([6, 1, 1])
b = np.array([1, 2, 0])

try:
  tf.compat.v1.signal.irfft3d(input_tensor=a,fft_length=b)
  # on a different machine: failed to initialize batched cufft plan with customized allocator: Failed to make cuFFT batched plan.
  # Aborted (core dumped)
except:
  pass
print('execution does not reach this line')

In either case, the inputs do not quite make sense, and tensorflow should throw.
Describe the expected behavior
Tensorflow should throw exceptions instead of crashing.
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Here is a colab notebook:
https://colab.research.google.com/drive/168jYG6MqnW4jpJdIXFMUBkyiaweA43aP?usp=sharing
Edit: the notebook has to be run with GPU
The code snippets above should also reproduce the issue.

Added PR #55274 for the fix.


bugs in airr-schema.yaml / airr-schema-openapi3.yaml

Some issues encountered when auto-generating LinkML from airr-schema.yaml / airr-schema-openapi3.yaml
These are all relatively easy/small fixes.

[ ] Property unit occurs as an ontology across different classes. This ontology does not have the same meaning. E.g.: TimePoint (unit=UO:0000003), TimeInterval (unit=UO:0000033), PhysicalQuantity (unit=UO:0000024), TimeQuantity (unit=UO:0000033). The field 'unit' should be renamed to something unique (time_unit, time_interval_unit, physical_quantity_unit)
[ ] Property release_version has inconsistent type. In AlleleDescription, type=integer; in GermlineSet, type=number. Should be integer in both cases.
[ ] Ontology species is missing source node in some places. This ontology is correctly defined in Subject, but in AlleleDescription and GermlineSet, the expected field x-airr/ontology/top_node/id is missing.
[ ] Some enums are defined several times, and differ in that they contain 'null' in some places, but not in others: locus (contains 'null' in Rearrangement, but not in AlleleDescription, GermlineSet, Genotype); mhc_class (contains 'null' in Reactivity, not in MHCGenotype)
[ ] For ontology property in class Expression the expected field x-airr/ontology/top_node/id is missing.
[ ] For ontology antigen in class Reactivity the expected field x-airr/ontology/top_node/id is missing.
[ ] For ontology orcid_id in class Contributor the expected field x-airr/ontology/top_node/id is null.
[ ] For ontology affiliation in class Contributor the expected field x-airr/ontology/top_node/id is null.
[ ] Property reactivity_ref is defined with two different types. Inside class Reactivity, the type is array. Inside class Rearrangement, the type is string, but the description explicitly states that this string should be a comma separated list. I would propose changing the type to array. (and besides, Rearrangement also contains reactivity_id which is a comma separated list as string, the type for that should then probably change as well.)
[ ] Property nodes of class Tree should have $ref: '#/Node' directly under nodes, now it is placed under a field called additionalProperties which is not used anywhere else

One issue where the solution is not as obvious:

[ ] RepertoireGroup contains property repertoires. This is not simply an array of Repertoire objects, but rather, an array of items which are unnamed (!) objects, where each object contains a repertoire_id, repertoire_description, time_point. There are no other comparable occurrences in the schema files where new objects are defined in such a way. Since this object is listed under 'items', I cannot infer a name for this object when auto-generating LinkML. Therefore, I would suggest creating a new named class, e.g.,  RepertoireReference, which contains these three fields, and is used as a 'type' for this array.

[ ]  RepertoireGroup contains property repertoires. This is not simply an array of Repertoire objects, but rather, an array of items which are unnamed (!) objects, where each object contains a repertoire_id, repertoire_description, time_point. There are no other comparable occurrences in the schema files where new objects are defined in such a way. Since this object is listed under 'items', I cannot infer a name for this object when auto-generating LinkML. Therefore, I would suggest creating a new named class, e.g.,  RepertoireReference, which contains these three fields, and is used as a 'type' for this array.

Yes, this is a good point that we haven't addressed in #773 yet, and is a criteria we applied to the germline gene set schema. Adding a new class is the solution, though I'm not sure the best name. Maybe RepertoireDetail as its details about how the repertoire is organized in the group.

Hi @LonnekeScheffer , we need to differentiate these issues between v1.5 and v2.0. If v2.0 ends up being broken for awhile, that's ok, all the data is currently in v1.5 so that's the priority. Maybe some of these issues are only present in v2.0 so we can ignore them for now.

Hi @schristley, I have now updated the list to separate the airr v1.5 issues (which also occur in v2.0) from the v2.0-only issues

[ ]  For Ontology 'Property' in  class 'CellExpression' (v1.5) / 'Expression' (v2.0) the expected field x-airr/ontology/top_node/id is missing.

@bussec @bcorrie  This seems to be incorrect usage by AIRR standards. Gene names are not ontology-based exactly, i.e. each individual gene is not an ontology term. This is more like a controlled vocabulary from an external source. I don't think we have a similar situation elsewhere in the AIRR schema, so I think we need to define this differently.
Likewise for antigen, each antigen is not an ontology term.

[ ]  Property nodes of class Tree should have $ref: '#/Node' directly under nodes, now it is placed under a field called additionalProperties which is not used anywhere else

@LonnekeScheffer this is actually correct, it is just uncommon. What this means is that instead of the keys/properties of the dictionary being pre-defined, they are dynamic. The additionalProperties then indicates the schema for those dynamic properties.
For LinkML, this gets translated into a multivalued range


Improve type check messages for some functions

Partially fixes #4969.

Jenkins, test this please.

Jenkins CI test (for commit 47391027bd06027b6ae896d00dee17b36babd272, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

The Jenkins failure (TestTriangularInv_param_0.test_backward_cpu) is irrelevant to the PR.


2nds in bank overlay for Chamber Of Xeric

Is your feature request related to a problem? Please describe.
Would be asome have a overlay that shows how many 2nds or resources are in the cox bank... would be so usefull.
A permanent overlay while doing the raid that show this
Describe alternatives you've considered
A overlay or a command
Additional context

Something like this (sorry for the draw, i made it on paint...)
And the Overlay (more friendly of course... mine sucks)

While it is inside the Raid, the Overlay will obtain the information of the amount of resources that are in the bank at all times (of those that appear in the photo), that way it would be very useful when doing massive cox or raids with people you don't know (no discord) and you skip the step of asking them how many resources are in the bank and things like that.

In order to get an accurate count of what's in the chest, your client would need to have the chest open at the same time that any equipment changes are made. This isn't really doable without something else to share the data between clients.
With that said... maybe this could be done through the Discord party system?

In order to get an accurate count of what's in the chest, your client would need to have the chest open at the same time that any equipment changes are made. This isn't really doable without something else to share the data between clients.
With that said... maybe this could be done through the Discord party system?


Add support for /me twitch command

Fixes #539

Thanks for the PR, I'll take a stare soonish.

available in https://github.com/Xithrius/twitch-tui/releases/tag/v2.6.6