HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

removed RS entry from zk draining server znode on RS stopped

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
master passed

+1 :green_heart:
checkstyle
1m  8s
master passed

+1 :green_heart:
spotbugs
2m  0s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

-0 :warning:
checkstyle
1m  2s
hbase-server: The patch generated 4 new + 13 unchanged - 0 fixed = 17 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
1m 20s
the patch passed

+1 :green_heart:
javac
1m 20s
the patch passed

-1 :x:
shadedjars
5m 59s
patch has 10 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
146m 20s
hbase-server in the patch failed.

176m 56s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 548e4457e226 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/testReport/

Max. process+thread count
3817 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 41s
master passed

+1 :green_heart:
checkstyle
1m 26s
master passed

+1 :green_heart:
spotbugs
2m 37s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  5s
the patch passed

-0 :warning:
checkstyle
1m 11s
hbase-server: The patch generated 4 new + 13 unchanged - 0 fixed = 17 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 20s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
7m 37s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 55s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
143m 28s
hbase-server in the patch failed.

176m 37s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 29a4caffd1fc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/testReport/

Max. process+thread count
4429 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
6m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
211m  9s
hbase-server in the patch failed.

237m 53s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3186eb3ce0d6 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8de8c44029

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/testReport/

Max. process+thread count
3493 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 20s
master passed

+1 :green_heart:
checkstyle
1m  5s
master passed

+1 :green_heart:
spotbugs
1m 59s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 21s
the patch passed

-0 :warning:
checkstyle
1m  4s
hbase-server: The patch generated 4 new + 13 unchanged - 0 fixed = 17 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
6m  3s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
148m 22s
hbase-server in the patch failed.

175m  2s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux db93a765a849 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/testReport/

Max. process+thread count
3811 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
5m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
157m 35s
hbase-server in the patch failed.

181m 32s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47bc8dc2181c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 08c97d3a87

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/testReport/

Max. process+thread count
3891 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
checkstyle
1m  6s
master passed

+1 :green_heart:
spotbugs
2m  1s
master passed

-0 :warning:
patch
2m 10s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 57s
root in the patch failed.

-0 :warning:
checkstyle
1m  4s
hbase-server: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
hadoopcheck
2m  3s
The patch causes 23 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 13s
The patch causes 23 errors with Hadoop v3.2.1.

-1 :x:
spotbugs
0m 36s
hbase-server in the patch failed.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
3m  3s
root in the patch failed.

-1 :x:
compile
1m 17s
hbase-server in the patch failed.

-0 :warning:
javac
1m 17s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m 27s
patch has 23 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
1m 25s
hbase-server in the patch failed.

28m 12s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ebe5dd6f2437 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59031ab661

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/testReport/

Max. process+thread count
87 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
checkstyle
1m  5s
master passed

+1 :green_heart:
spotbugs
2m  2s
master passed

-0 :warning:
patch
2m 10s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  9s
root in the patch failed.

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
hadoopcheck
2m  6s
The patch causes 23 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 10s
The patch causes 23 errors with Hadoop v3.2.1.

-1 :x:
spotbugs
0m 35s
hbase-server in the patch failed.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 44s
root in the patch failed.

-1 :x:
compile
1m 15s
hbase-server in the patch failed.

-0 :warning:
javac
1m 15s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m 33s
patch has 23 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 47s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
1m 20s
hbase-server in the patch failed.

27m 36s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 35cb544429f0 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 59031ab661

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/testReport/

Max. process+thread count
88 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
checkstyle
1m  7s
master passed

+1 :green_heart:
spotbugs
2m  0s
master passed

-0 :warning:
patch
2m  9s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 21s
root in the patch failed.

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
hadoopcheck
2m 25s
The patch causes 23 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 44s
The patch causes 23 errors with Hadoop v3.2.1.

-1 :x:
spotbugs
0m 38s
hbase-server in the patch failed.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 46s
root in the patch failed.

-1 :x:
compile
1m 10s
hbase-server in the patch failed.

-0 :warning:
javac
1m 10s
hbase-server in the patch failed.

-1 :x:
shadedjars
5m 17s
patch has 23 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
1m  4s
hbase-server in the patch failed.

27m 19s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d10334596681 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 61a7468df7

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/testReport/

Max. process+thread count
97 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
checkstyle
1m  4s
master passed

+1 :green_heart:
spotbugs
1m 59s
master passed

-0 :warning:
patch
2m  7s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 19s
the patch passed

-0 :warning:
checkstyle
1m  2s
hbase-server: The patch generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 23s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
199m 54s
hbase-server in the patch failed.

228m 23s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c04ecda15b9c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b2ec4c1ea0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/testReport/

Max. process+thread count
3596 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/7/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  1s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
master passed

+1 :green_heart:
checkstyle
1m 17s
master passed

+1 :green_heart:
spotbugs
2m 13s
master passed

-0 :warning:
patch
2m 21s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m  8s
root in the patch failed.

-0 :warning:
checkstyle
1m  9s
hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
hadoopcheck
2m 25s
The patch causes 14 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m 56s
The patch causes 14 errors with Hadoop v3.2.1.

-1 :x:
spotbugs
0m 40s
hbase-server in the patch failed.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 16s
root in the patch failed.

-1 :x:
compile
0m 59s
hbase-server in the patch failed.

-0 :warning:
javac
0m 59s
hbase-server in the patch failed.

-1 :x:
shadedjars
4m 52s
patch has 14 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 56s
hbase-server in the patch failed.

24m 28s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e22272eceb40 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 16116fa35e

Default Java
1.8.0_232

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/testReport/

Max. process+thread count
78 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
5m 52s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in master failed.

-0 :warning:
patch
6m 46s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 39s
root in the patch failed.

-1 :x:
compile
1m  6s
hbase-server in the patch failed.

-0 :warning:
javac
1m  6s
hbase-server in the patch failed.

-1 :x:
shadedjars
6m 32s
patch has 14 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 48s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
1m 23s
hbase-server in the patch failed.

26m 21s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2609c97a868c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 16116fa35e

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/testReport/

Max. process+thread count
99 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/8/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 21s
master passed

+1 :green_heart:
checkstyle
1m  3s
master passed

+1 :green_heart:
spotbugs
1m 57s
master passed

-0 :warning:
patch
2m  6s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 18s
the patch passed

-0 :warning:
checkstyle
1m  2s
hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 38s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
6m 31s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
201m 52s
hbase-server in the patch failed.

231m 15s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux da2bc09aaccb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66452afc09

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/testReport/

Max. process+thread count
3631 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/9/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
checkstyle
1m 12s
master passed

+1 :green_heart:
spotbugs
2m  6s
master passed

-0 :warning:
patch
2m 14s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
the patch passed

-0 :warning:
checkstyle
1m  8s
hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  9s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 43s
hbase-server in the patch failed.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 54s
the patch passed

+1 :green_heart:
javac
0m 54s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
143m  4s
hbase-server in the patch failed.

166m 36s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/10/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 691d51b503c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66452afc09

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/10/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/10/testReport/

Max. process+thread count
3838 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/10/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
spotbugs
2m 32s
master passed

-0 :warning:
patch
2m 41s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
the patch passed

-0 :warning:
checkstyle
1m 17s
hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 45s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
219m 40s
hbase-server in the patch failed.

250m 20s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ceda0e85c17a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66452afc09

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/testReport/

Max. process+thread count
2799 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
6m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

-0 :warning:
patch
6m 55s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
233m 41s
hbase-server in the patch failed.

260m 49s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 477a74b399a7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66452afc09

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/testReport/

Max. process+thread count
2812 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/11/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@gkanade Can you please check test failure locally? I am not getting NPE on master branch. However, last couple of builds have consistent failures:
java.lang.NullPointerException
	at org.apache.hadoop.hbase.master.procedure.TestServerRemoteProcedure.testSplitWALAndCrashBeforeResponse(TestServerRemoteProcedure.java:117)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 58s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 30s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

-0 :warning:
checkstyle
1m 20s
hbase-server: The patch generated 5 new + 13 unchanged - 0 fixed = 18 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
13m 58s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

39m 58s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux f7625d22c572 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fbf033735b

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/12/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/12/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/12/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani @anoopsjohn i made the fix and now verifies this works locally (the issue was one of the tests was not initializing zk instance for HM so i just put a null check around my code), this should work plz review

+1
Once next build is green, good to commit.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 37s
master passed

+1 :green_heart:
compile
1m 10s
master passed

+1 :green_heart:
shadedjars
6m 23s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in master failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 34s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 48s
hbase-server in the patch failed.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
master passed

+1 :green_heart:
checkstyle
1m 20s
master passed

+1 :green_heart:
spotbugs
2m 31s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
the patch passed

-0 :warning:
checkstyle
1m 22s
hbase-server: The patch generated 6 new + 13 unchanged - 0 fixed = 19 total (was 13)

-0 :warning:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 39s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

+1 :green_heart:
shadedjars
7m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
217m 58s
hbase-server in the patch failed.

253m 52s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1841

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 749b1cfdb542 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9d0baa91b2

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/testReport/

Max. process+thread count
2592 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/13/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The build is green for us (failed QA is not relevant).


LDAP not working in docker with a windows nano server image

We are currently hosting Exceptionless inside of an NanoServer docker image.
We found out, that your ActiveDirectoryLoginProvider implementation is very platform specific. That is, curently the namespace System.DirectoryServices doesn't work with NanoServer-images (see this example):
https://github.com/exceptionless/Exceptionless/blob/master/src/Exceptionless.Core/Authentication/ActiveDirectoryLoginProvider.cs
To fix this issue, you could consider to use a more platform independent solution. We re-implemented the provider using the "novell directory ldap" nuget-package and indeed it does work, because it doesn't rely on any existing dlls inside the hosting windows system.
https://www.nuget.org/packages/Novell.Directory.Ldap.NETStandard/
Unfortunately I can't show you our implementation (NDA) and I dont have any ldap enviroment set up at home, but I still wanted to let you guys know, that there is a constellation, that isn't working right now.

I will close this one, I saw the linux issue, that seems to be similar.


Improved german translation

@larsgrefer do you know another German person that could sanity check these? Just another set of eyes to check for spelling mistakes, grammar, etc.

Hey, I am from Germany too. @larsgrefer have replaced "Problem" with "Tickets" what is absolutely right. I think it can merge...
Other git hosts (can I say the name? :-)) have translated 'issues' with 'tickets' (for German) as well...


ignore more messages from v12

Ahh.. Thanks! However it's not enough and there are more messages. Also dstx a tx with additional payload so I guess it should be parsed (should be fine to parse it as tx and ignore the rest). So I just submitted this https://github.com/UdjinM6/darkcore/commit/1355e0f39852bc7969260f2382feb6fd9c41eef9 to add everything I just mentioned.
However I didn't test it... Would really appreciate if you could confirm if it's ok or not :blush:

Great , It's working fine , btw, I see 'notfound' and 'ix' messages may need to be parsed/ignore.

Good eye! https://github.com/UdjinM6/darkcore/commit/15f8f03ab49dd2b6eb6049829b3397eb7b223617


chore: update googleapis circa 20240125

Pick up storagecontrol BUILD.bazel updates.
Update required new api proto lib for google/api/field_info.proto
Update required removing unecessary substitution in the generator.

This change is

Don't forget to include the "PiperOrigin-RevId" from the first commit in the squashed description.


Autogenerate "id" for NIP46.Request objects

It would be nice if there was a way to construct a NIP46.Request object with a constructor like: new Request(method, params) and have the id randomly autogenerated.
NOTE: It seems from my testing this generated id must be a hex string, or else it won't work with nsec.app. Not sure if this is true but it seems to be the case.

You can use UUIDs for randomly generating ids.
--
Sent with Tuta; enjoy secure & ad-free emails:
https://tuta.com
10 Apr 2024, 02:18 by @.***:

It would be nice if there was a way to construct a NIP46.Request object with a constructor like: > new Request(method, params)>  and have the > id>  randomly autogenerated.
NOTE: It seems from my testing this generated id must be a hex string, or else it won't work with nsec.app. Not sure if this is true but it seems to be the case.
—
Reply to this email directly, > view it on GitHub https://github.com/tcheeric/nostr-java/issues/137> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABQMG7BO45VTQQ3M645YJLTY4SHOJAVCNFSM6AAAAABF7RJ4NOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTINJWHA2DKNI> .
You are receiving this because you are subscribed to this thread.> Message ID: > <tcheeric/nostr-java/issues/137> @> github> .> com>


Correct typo in Ubuntu changelog

When run "debuild -uc -us" command, we meet a warning mesage as follows.
debuild: warning:     debian/changelog(l5): badly formatted trailer line
This commit is to fix a typo in Ubuntu changelog. We have to use double
white space before weekday.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

:memo: Version: 1.20180820. Thank you for submitting PR #243. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://invain.mooo.com/.


Clear KubeVirt configmap after testing custom SMBIOS settings.

Manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/3292

Using a new utility function to clear data on configmap.
Signed-off-by: Igor Bezukh<EMAIL_ADDRESS>Release note:
NONE

/cc @enp0s3

/lgtm

/approved
according to the lgtms above

/approve

Rebased to head of branch.

/lgtm

/retest


Update labels and milestones script

simplified script
milestones: removed 4.1 and added 4.3

Should we move scripts that run locally and not on gh itself to a dev/gh-scriptsor something?

Sure, I'm open to that. But I think dev/scripts/ suffices if we want to move it out of the .github folder, I don't think a separate gh-scripts folder is neccessary.

dev/scripts is ok for me.

done


Let HOIs add SAML for separate production authentication instance

In first phase, contact HOIs to set up SAML for new production instance of authentication service.
Then move the current "staging" instance to the staging service and set up the new one on the production server.
Use for the production instance a new subdomain auth.studieplekken.ugent.be, this subdomain is already created by DICT.
As the SAML files are now gitignored, it should not be a problem to have different SAML files per instance git-wise.

Closing this as I finished this already a while ago.


Cannot find module '@airbnb/config-babel'

While following the Building Custom Viz Plugins in Superset v2 (Updated for Monorepo) article, at the step of running npm run build I get an error.
How to reproduce the bug

Follow the steps from the article until building the custom viz

Stacktrace
><EMAIL_ADDRESS>build-cjs
> babel src --extensions ".ts,.tsx,.js,.jsx" --copy-files --out-dir lib

Error: /private/tmp/superset-plugin-chart-hello-world/babel.config.js: Error while loading config - Cannot find module '@airbnb/config-babel'
Require stack:
- /private/tmp/superset-plugin-chart-hello-world/babel.config.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>    at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
    at Module._load (node:internal/modules/cjs/loader:920:27)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/private/tmp/superset-plugin-chart-hello-world/babel.config.js:1:23)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Module.require (node:internal/modules/cjs/loader:1141:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/private/tmp/superset-plugin-chart-hello-world/babel.config.js',
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>  ]
}

Environment

browser type and version: not applicable
superset version: latest
python version: none
node.js version: 18.15.0
any feature flags active: no

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

I'm not sure if this is still an issue in current versions of Superset (3.x). If it is, we can re-open this, or feel free to open a new issue with updated context and a reproducible case using example data. We're no longer supporting Superset 2.x or prior, and it's been a while since this thread saw any activity, so I'm closing this as stale.


does this client support batch consume?

What do you mean by batches? The API will give you one message at the time,
but internally it consumes batches for increased performance.
On Tuesday, 1 March 2016, 曹春晖<EMAIL_ADDRESS>wrote:

—
Reply to this email directly or view it on GitHub
https://github.com/wvanbergen/kafka/issues/89.

Then can I control the inner batches size?
I haven't found a option to configure.

Yes. The config struct includes the Sarama config struct, which includes
several variables to control the batching process. Look it up in the Sarama
docs.
On Wednesday, 2 March 2016, 曹春晖<EMAIL_ADDRESS>wrote:

Then can I control the inner batches size?
I haven't found a option to configure.
—
Reply to this email directly or view it on GitHub
https://github.com/wvanbergen/kafka/issues/89#issuecomment-191068405.

thx!


Critical Bug: Undefined URLs

While using the latest version of vue and single-spa, i found that the url builder was adding undefined to the URL.
For me this happened when i went several levels below the current page.
This code avoids adding "undefined" to the URL when the "to" is undefined, when i want to return to the root of the SPA without doing a page refresh.

+1 on this, please merge.

described in https://github.com/vuejs/router/issues/1507

Thanks for the PR but do you have a boiled-down repro or at the very least more information as to why or how to ends up being undefined?

Thanks for the PR but do you have a boiled-down repro or at the very least more information as to why or how to ends up being undefined?

It is really hard to replicate this in a new project (i am still trying), but i can provide more information in the meantime.
There are times when the currentState.current becomes undefined

That means either:

Another lib or code is modifying the history and erasing the state: in which case the code should ensure the state persists so vue router can work
Vue router is running while another router should be in charge: See https://github.com/vuejs/router/issues/1270

In both cases, the fix is not in vue router

That means either:

Another lib or code is modifying the history and erasing the state: in which case the code should ensure the state persists so vue router can work

Vue router is running while another router should be in charge: See https://github.com/vuejs/router/issues/1270

In both cases, the fix is not in vue router

@posva i completely understand your position, I will continue to try to identify the reason why the state has been somehow overridden by another MFE.
But when the history has been lost shouldn't we still navigate to the route?
I added a commit to reflect this case.

But when the history has been lost shouldn't we still navigate to the route?

The history cannot be "lost". The router expects to be the only one interacting with it or to be manually deactivated when it's not active. In the issue mentioned above, people were also using single-spa and it seems things worked out for them, so you might want to ask them.
Good luck!

@posva  After several days debugging i found out that this error happens when i go to an angular app and the return to a vue app.
Added the repository with the error, https://github.com/brunomartinspro/single-spa
I will continue to try to find a solution that does not require any change in the vue-router.


Feature/rework wrap per rpc credentials

Descriptions
Added few changes to grpcfd, made grpcfd.(*wrapPerRPCCredentials) to implement FDSender interface instead of FDTransceiver
Issue
related to https://github.com/networkservicemesh/sdk/issues/1118

@edwarnicke Could you, please, take a look.


Improved test coverage of diff mode and fixed memory error

This PR improves test coverage of diff mode:

test vertical, horizontal, iwhite and icase values of 'diffopt' option
test  normal commands "dp" and "do" with a buffer number

Interestingly, the newly added tests Test_diffopt_horizontal() and
Test_diffopt_vertical() uncover a bug with the asan build in Travis
(heap overflow). Bug is not introduced my my PR since PT only
adds tests. Function foldmethodIsManual(...) is called with
wp->w_p_fdm being an empty string, so access to
wp->w_p_fdm[3] causes a memory error at fold.c:308:
    306 foldmethodIsManual(win_T *wp)
    307 {
!!!!308     return (wp->w_p_fdm[3] == 'u');
    309 }

We could check that length of wp->w_p_fdm is
at least 4, but I suppose that w_p_fdm should never
be an empty string so, so it would be a workaround.
I don't have a fix for this yet.

Codecov Report

Merging #1685 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
+ Coverage   74.85%   74.93%   +0.07%
==========================================
  Files          76       76
  Lines      124942   124903      -39
==========================================
+ Hits        93521    93590      +69
+ Misses      31421    31313     -108

Impacted Files
Coverage Δ

src/diff.c
81.85% <100%> (+4.83%)
:arrow_up:

src/version.c
79.29% <0%> (-1.02%)
:arrow_down:

src/if_py_both.h
75.31% <0%> (-0.71%)
:arrow_down:

src/message.c
68.07% <0%> (-0.21%)
:arrow_down:

src/channel.c
83.71% <0%> (+0.04%)
:arrow_up:

src/move.c
85.98% <0%> (+0.08%)
:arrow_up:

src/screen.c
74.24% <0%> (+0.13%)
:arrow_up:

src/term.c
53.37% <0%> (+0.17%)
:arrow_up:

src/evalfunc.c
81.1% <0%> (+0.2%)
:arrow_up:

src/gui_gtk_x11.c
47.39% <0%> (+0.2%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4475b62...23db732. Read the comment docs.

Test_diffopt_horizontal() and Test_diffopt_vertical() uncover
a bug with the asan build in Travis (heap overflow).

The heap overflow found by new tests is now fixed in this PR.

Dominique Pellé wrote:

This PR improves test coverage of diff mode:

test vertical, horizontal, iwhite and icase values of 'diffopt' option
test  normal commands "dp" and "do" with a buffer number

With a sequence of changes like this, I can't possibly tell when it's
done.  Please add a comment when this is ready to include.
Also, a comment at that start that it's not ready yet would avoid
including it too early.

"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

With a sequence of changes like this, I can't possibly tell when it's done.
Please add a comment when this is ready to include.

PR is ready to be included.

Dominique wrote:

With a sequence of changes like this, I can't possibly tell when it's done.
Please add a comment when this is ready to include.

PR is ready to be included.

Thanks, I'll add it to the list.
--
"I love deadlines.  I especially like the whooshing sound they
make as they go flying by."
-- Douglas Adams
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Last note in the list not fully visible if sidebar is over 100vh

idk why I thought this was fixed
I actually fixed it just now


Need to create a marketplace for community tools

We need to create a marketplace for community tools with guidelines on how to contribute. The user can see the number of tools installs, upvote, downvote, add comments etc.

Marketplace for tools will be live today!


Render with password protected CA root key fails

Following https://coreos.com/kubernetes/docs/latest/kubernetes-on-aws-render.html I created my own CA key and certificate.
kube-aws render credentials --ca-cert-path=/path/to/ca-cert.pem --ca-key-path=/path/to/ca-key.pem displays invalid file error when ca-key.pem is password protected.
Steps to reproduce:

Create CA key: openssl genrsa -aes256 -out private/ca.key.pem 4096
Create CA certificate: openssl -key private/ca.key.pem -new -x509 -days 7300 -sha256 -extensions v3_ca -out certs/ca.cert.pem
kube-aws render credentials --ca-cert-path=/path/to/ca-cert.pem --ca-key-path=/path/to/ca-key.pem

Password protecting IS highly recommended, so probably more users will run into this. At least the error message should say that the key file must NOT be password protected.

@leontebbens Thanks for the feedback 👍
I'd definitely like to fix that.
Would you mind providing me your expectation on kube-aws's behavior to support password-protected keys?
Probably you'd like to protect all the keys with passwords? Then just adding a command-line flag like --key-password to kube-aws won't work but --ca-key-password, --worker-key-password, controller-key-password etc would work?

Indeed all key files are password protected for security reasons. But flags for each seems quite cumbersome and insecure (plaintext passwords on the commandline). I would except kube-aws to detect a pwd-protected file and then prompt me to enter the password. Would that be possible?

@leontebbens Thanks for your reply!
I'm ok with prompting for manual input when passwords are not provided.
On the other hand, regardless of that, I'd also like to provide way(s) to tell kube-aws which passwords to be used for automation. Do you have any idea/preference on how to do that? For example, do you think env vars like KUBE_AWS_CA_KEY_PASSWORD instead of command-line flags would be preferred?

Env vars seem even more insecure as the are long living. Not a good place for plaintext passwords.

@leontebbens Thanks for your comment!
Then, how about:

recommending users who wants to automate things in exchange of security to pass them via shell variables like KUBE_AWS_CA_KEY_PASSWORD=... kube-aws up?
Then, one can limit the lifetime of insecure plaintext passwords in a single kube-aws up run, which is better than env vars set via export KUBE_AWS_CA_KEY_PASSWORD=....
recommending users who wants security the most to not automate kube-aws up and provide passwords manually via the prompt

Agree

We'd like to use this during an automated process. Was the switch above from command line flags to shell variables intended as a way of preventing the password from being logged/stored in shell history etc? Understand that putting it in a separate set of variables makes it logically separate from a user perspective, does it end up being much different from the perspective of security?

AFAIK, no; Using shell variables won't prevent passwords from being logged to the history and being visible from /proc/<kube-aws's pid>/environ. If someone could crack into root or the linux user kube-aws is run, I believe that he/she can still peak into plain-text passwords. If he/she could crack into root, prompting for user input is still vulnerable in my understanding though.

I think we should offer two options:

a more secure one: prompt user for typing a password
a less secure but automatable one: passwords in Shell variables
I see both options in other tools. I do not see often plain text passwords as command line params.

Thanks. I'll leave this open for pull request(s) 👍

@tomas-edwardsson I just saw your effort on this! Any chance you could submit a PR for this? 😄


importing Window seems to clobber kivy.clock.Clock.schedule_once() in some way

I'm trying to use Clock to schedule my app startup after the display of an animated splash screen, but the timing of schedule_once() seems almost random.
Here's a program that illustrates the buggy behavior:
from kivy.base import EventLoop
from kivy.clock import Clock
from kivy.core.window import Window

import time

def callback2(*args):
    print '2', time.time()

def callback1(*args):
    print '1', time.time()
    Clock.schedule_once(callback2, 2.0)

print 'start', time.time()
Clock.schedule_once(callback1, 3.0)
EventLoop.run()

Here's a run of this simple program.  Note that the first callback is supposed to occur after 3 seconds, but actually occurs after about 1.8 seconds.
% python t.py
[INFO              ] [Logger      ] Record log in /home/wjanssen/.kivy/logs/kivy_16-03-18_70.txt
[INFO              ] [Kivy        ] v1.9.1
[INFO              ] [Python      ] v2.7.11 |Continuum Analytics, Inc.| (default, Dec  6 2015, 18:08:32)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
[INFO              ] [Factory     ] 179 symbols loaded
[INFO              ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2 (img_pil, img_ffpyplayer ignored)
[INFO              ] [OSC         ] using <multiprocessing> for socket
[INFO              ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored)
[INFO              ] [GL          ] OpenGL version <3.0 Mesa 11.0.2>
[INFO              ] [GL          ] OpenGL vendor <nouveau>
[INFO              ] [GL          ] OpenGL renderer <Gallium 0.4 on NV96>
[INFO              ] [GL          ] OpenGL parsed version: 3, 0
[INFO              ] [GL          ] Shading version <1.30>
[INFO              ] [GL          ] Texture max size <8192>
[INFO              ] [GL          ] Texture max units <16>
[INFO              ] [Window      ] auto add sdl2 input provider
[INFO              ] [Window      ] virtual keyboard not allowed, single mode, not docked
start<PHONE_NUMBER>.62
1<PHONE_NUMBER>.44
2<PHONE_NUMBER>.44
Killed
%

If we replace Window with a simple dummy event listener:
from kivy.base import EventLoop
from kivy.clock import Clock

class Listener(object):
    def dispatch(self, *args):
        pass

listener = Listener()

EventLoop.add_event_listener(listener)

import time

def callback2(*args):
    print '2', time.time()

def callback1(*args):
    print '1', time.time()
    Clock.schedule_once(callback2, 2.0)

print 'start', time.time()
Clock.schedule_once(callback1, 3.0)
EventLoop.run()

the timing is more or less what we expect:
% python t.py
[INFO              ] [Logger      ] Record log in /home/wjanssen/.kivy/logs/kivy_16-03-18_71.txt
[INFO              ] [Kivy        ] v1.9.1
[INFO              ] [Python      ] v2.7.11 |Continuum Analytics, Inc.| (default, Dec  6 2015, 18:08:32)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
[INFO              ] [Factory     ] 179 symbols loaded
start<PHONE_NUMBER>.51
1<PHONE_NUMBER>.41
2<PHONE_NUMBER>.42
%

I can reproduce your behavior, I've edited your example a bit so it's easier to compare results.
from kivy.base import EventLoop
from kivy.clock import Clock
from kivy.core.window import Window

import time

def callback2(*args):
    second = time.time()
    print('2', second - start)

def callback1(*args):
    first = time.time()
    print('1', first - start)
    Clock.schedule_once(callback2, 2.0)

start = time.time()
Clock.schedule_once(callback1, 3.0)
EventLoop.run()

1 2.1312689781188965
2 4.134382009506226

I looked at the code, but I couldn't see anything obvious.  I was testing on Darwin.

I'm on Windows, it's probably universal.

Can you test with Clock.get_time() instead of time.time().
That would be a more accurate time as it starts from when the ivy.Clock initiates i.e after the event loop initiates. As time.time() is from when python time instance started

Using https://kivy.org/docs/api-kivy.clock.html#kivy.clock.ClockBase.get_boottime
Running the following example::
from kivy.base import EventLoop
from kivy.clock import Clock
from kivy.core.window import Window

def callback2(*args):
    print('2', Clock.get_boottime())

def callback1(*args):
    print('1', Clock.get_boottime())
    Clock.schedule_once(callback2, 2.0)

Clock.schedule_once(callback1, 3.0)
EventLoop.run()```

I get::

('1', 2.99849796295166)
('2', 4.9996349811553955)

That program hide the problem, though.  The problem is that the first schedule_once does not get triggered 3 seconds after it's set.  Even if you use Clock.get_boottime().  Here's another example:
import time
from kivy.base import EventLoop
from kivy.clock import Clock
from kivy.core.window import Window

def callback2(*args):
    global starttime
    print('2', Clock.get_boottime(), time.time() - starttime)
    EventLoop.quit = True

def callback1(*args):
    global starttime
    print('1', Clock.get_boottime(), time.time() - starttime)
    Clock.schedule_once(callback2, 2.0)

starttime = time.time()
print('0', Clock.get_boottime(), starttime)
Clock.schedule_once(callback1, Clock.get_boottime() + 3.0)
EventLoop.run()

With this, I get:
('0', 0.0,<PHONE_NUMBER>.490209)
('1', 3.0041370391845703, 2.559940814971924)
('2', 5.008002996444702, 4.563763856887817)

I've been told that scheduling before the event loop is started could be unsafe, we should also look into that.
Let's reopen this, if the behavior turns out to be expected, we could document it.

We've had a discussion with the team, @akshayaurora and @Kovak proposed to explicitly drop schedules created before the clock has started.

When is the clock started?  When EventLoop.run() is called?  Can you then schedule something after you've called it?  And, out of curiosity, why doesn' t this odd behavior happen if you register a user event listener, instead of loading Window?


Add custom serviceaccount functionality  to Sonarqube

Signed-off-by: Aaron Mell
What this PR does / why we need it:
Adds  a custom serviceaccount to the Sonarqube chart
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x] DCO signed
[ x] Chart Version bumped
[ x] Variables are documented in the README.md

/assign @rjkernick

/retest


Fix for segfault in Array.copy_to in case of empty Arrays

This fixes #4172 by adding a simple guard expression. The reason for the crash was that _ptr can be NULL when the Array is instanced as empty Array, e.g. let x: Array[I32] = []

The release notes appear to be for a different change. For a test, please add a unit test to builtin_tests not a runner test.

The release notes appear to be for a different change. For a test, please add a unit test to builtin_tests not a runner test.

The release notes are still the one from another PR I submitted for this release. I will submit release notes momentarily.
Since this PR fixes a segfault, I assumed the test was supposed to show that's gone. However, I am not clear on how to test for the absence of a segfault outside a runner test. Could you give me some hints?

A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test.

@stefandd  have you read the how to contribute doc? It has good pointer like "use a different branch for each PR"

A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test.

So If I add such a test, you'd like me to remove the segfault-is-gone test?

Yes please

A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test.

So If I add such a test, you'd like me to remove the segfault-is-gone test?

Yes please

A test that calling copy_to with an uninitialized array leaves the destination array unchanged is a sufficient test.

So If I add such a test, you'd like me to remove the segfault-is-gone test?

Yes please

Will do. But for my understanding: why would such a test be sufficient? What if that test segfaulted? Is that being caught?

It doesn't matter if it segfaults. It matters that it does the right thing for a given test case.
That it segfaults currently isn't of much interest. It matters that there's no test coverage to show it does the correct thing.
If someone were to reintroduce the bug, the unit tests for the standard library would crash and we'd know something was wrong.
There's plenty of ways that code could be wrong. So it's the "is it right" test that is important.
There's compiler bugs that we need runner tests for and compiler features we need runner tests for. This isn't like that though. A good old unit test gives us all the coverage we need.

Small nit. This isn't a bug with empty arrays. It's with uninitialized ones. If you initialized an array but let it empty, it wouldn't have segfaulted.

This still has the extra release notes from a previous PR.

After this PR is merged, @stefandd, you are going to want to delete your fork and start over because the changes you'll need to make to remove the old release notes file is going to potentially cause issues in the future. But, not until after this PR is merged.

I made a number of suggestions that should address most issues. I also added an additional test for "empty" which wasn't covered. What was covered was "uninitialized" which is slightly different. I'm not sure that we have the second case correctly implemented.

@stefandd FYI, I've found other bugs in copy_to but I want to address them in other PRs.

After this PR is merged, @stefandd, you are going to want to delete your fork and start over because the changes you'll need to make to remove the old release notes file is going to potentially cause issues in the future. But, not until after this PR is merged.

Yes, I will do and will make it a habit to do so before every PR.

I made a number of suggestions that should address most issues. I also added an additional test for "empty" which wasn't covered. What was covered was "uninitialized" which is slightly different. I'm not sure that we have the second case correctly implemented.

Just submitted a small fix: the dest2 Array needed to be declared outside the try .. end for it to be in-scope for the assert.

I've realized that this is a subset of #4174. The issue isn't really that we are working with an initialized array, it's that "we are reading past the end".
If we were correctly checking  that the length wasn't greater than the size then the alloc check wouldn't be needed at all as our size of 0 would preclude any copying.

I've realized that this is a subset of #4174. The issue isn't really that we are working with an initialized array, it's that "we are reading past the end".
If we were correctly checking that the length wasn't greater than the size then the alloc check wouldn't be needed at all as our size of 0 would preclude any copying.
I think that's a strong case for keeping the tests from this PR and adding them to the tests that are part of a larger fix for #4174.
Or rather taking what is being tested in terms of scenarios and verifying that an error is raised as the larger fix for #4174 makes it partial.

@SeanTAllen I adjusted the fix to also fix #4174

@stefandd there's no passing tests that address everything noted that should be tested per #4173 to verify that such a fix is complete. Full tests of known problems are required at this point. I think we should leave this until more core team members way in on what the proper response to "bad input" should be. I'm strongly in favor of making copy_to partial.

@stefandd if we moved forward with this PR for address #4174 then release notes etc would need to be updated as well. But again, I think it is reasonable to table this for now until #4174 is discussed.

@stefandd if we moved forward with this PR for address #4174 then release notes etc would need to be updated as well. But again, I think it is reasonable to table this for now until #4174 is discussed.

Well this fixes both issues, but if you feel it is not ready to be included it is fine. If you change your mind, I'd like to ask you to adjust the release notes here to reflect both issues since you manage to be more concise.

This is lacking test coverage to be accepted for 4174. The release notes should be updated, and it still has an extra release notes file that needs to be removed.
If we moved forward with this fix rather than making partial, all of the above would need to be fixed and the PR title would need to be updated.

This is lacking test coverage to be accepted for 4174. The release notes should be updated, and it still has an extra release notes file that needs to be removed.
If we moved forward with this fix rather than making partial, all of the above would need to be fixed and the PR title would need to be updated.

Could I win you as a contributor for this? How could I give you write rights to my branch?

Some happy path tests I would want to see:

[ ] copy into destination so that it doesn't all fit within the destination where you want to copy something in that is greater in size than destination space
[ ] copy into the front of destination so copied amount fits within existing destination
[ ] copy onto the end of a destination so that copied amount fits within the existing destination's space
[ ] copy into the middle of a destination


Add MinMaxDifferenceTransform

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes
Look #952.
Closing issues
Closes #952.

Codecov Report

Merging #955 (fea18ba) into master (76b8081) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   85.37%   85.43%   +0.05%
==========================================
  Files         148      148
  Lines        7933     7951      +18
==========================================
+ Hits         6773     6793      +20
+ Misses       1160     1158       -2

Impacted Files
Coverage Δ

etna/transforms/math/__init__.py
100.00% <100.00%> (ø)

etna/transforms/math/statistics.py
99.35% <100.00%> (+0.06%)
:arrow_up:

etna/models/utils.py
100.00% <0.00%> (ø)

etna/models/nn/mlp.py
100.00% <0.00%> (ø)

etna/models/nn/rnn.py
100.00% <0.00%> (ø)

etna/auto/runner/utils.py
100.00% <0.00%> (+50.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Break out device apps

Break out the device apps to their own repos:

[ ] blink
[ ] nx
[ ] random
[ ] rng_stream
[ ] signer
[ ] timer

Take special care of signer and include the hash in -apps and the checks there so we don't change the resulting binary unnecessarily.

signer now here: https://github.com/tillitis/tkey-device-signer
Not yet removed from apps.


Add a new argument for TaskChain requests (RequestSubType)

As a follow up from the last Workflow meeting, we would like to start using a new parameter in TaskChain request so we can distinguish different types of workflows using TaskChain request type. The suggestion would be "RequestSubType", where the requestors could set it to "ReDigi", "ReReco", "LHEStepZero", "MonteCarlo", "MonteCarloFromGEN", "RelValMC", "RelValData", for example.
Later on we would use this information in the monitoring tool in order to properly filter requests.
Thanks, Alan.

Closing this issue since nothing needs to be added on the service side, just add it yourself and be happy :)


Update package release.json bootstrap URI once cloudfront changes land

Once chanzuckerberg/single-cell-infra#780 has landed (creating a permalink for the release.json bootstrap URL), update the python code to match.
CC: @mlin - at some point, you will want to do the same for R, but it does not need to be immediate as the old URI will continue to work for the time being.

Closing as completed.


The current release version v1.0.0 is not the latest code.

The v1.0.0 version code lags behind the master branch code, there will be this bug:#20  #21 .
We need a version of the latest master branch. By the way, update the https://github.com/apache/apisix/blob/master/rockspec/apisix-master-0.rockspec#L59  file in APISIX.

PR is welcome!

PR is welcome!

We should first release a version of the master branch code, right?  Such as: v1.1.0

We should first release a version of the master branch code, right?  Such as: v1.1.0

Since there is only fix after release, 1.0.1 is enough.

Since there is only fix after release, 1.0.1 is enough.

vote for 1.1, I think that is fine

vote for 1.1, I think that is fine


investor-foxy: Wrong releaseTime

Overview
Taking over https://github.com/shapeshift/web/issues/2103
Currently in investor-foxy, getTimeUntilClaimable sometimes returns a wrong releaseTime:
https://github.com/shapeshift/lib/blob/d8e9491743d26e19192d6a0a2e2ef6ad9e03e6cb/packages/investor-foxy/src/api/api.ts#L985
The high-level reason for that is investor-foxy mimics the FOXy contract methods / state and has potential for a wrong reconciliation.
We should fix it so that getTimeUntilClaimable returns us the correct release time, making sure we don't disable the claim button when claims are actually available.
References and additional details
https://github.com/shapeshift/web/issues/2103
https://github.com/shapeshift/lib/blob/d8e9491743d26e19192d6a0a2e2ef6ad9e03e6cb/packages/investor-foxy/src/api/api.ts#L985
Acceptance Criteria

The right releaseTime is return by getTimeUntilClaimable
getWithdrawInfo doesn't throw if user is available to claim

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

@NeOMakinG Assigning you so you can add some context to this

We need to figure out the timeframe this is happening.  I'm suspecting that a current rebase is pending, which would block the user from being able to claim.  In V2 I added a rebase before the user claim.  One way we could solve this is adding a rebase to the gelato bot if this is the reason.  We really need more information to help debug this.  When a user reports this we need their address so we can check the coolDownInfo and see what epoch their claim should be.  If the epoch is correct then it is a problem in lib, but if not then adding a call to rebase on the gelato bot will fix this.

@toshiSat you want this as a bounty?

I am finishing up 3 projects right now and am taking a much needed vacation.  If this is still open after my break I can pick it up as a bounty.  We will need to look into someones address that this is currently happening.  I don't see how this could be wallet related as the description suggests.


After sorting, empty strings are at the beginning of the sorted array

Code:
const SmartSort = require('smart-sort');

const emptyStringTestArray = [
  { title: 'b' },
  { title: '' },
  { title: 'a' }
]

console.log(SmartSort.naturalSortBy(emptyStringTestArray, 'title', true, 'asc'))

Output:
[
  { title: '' },
  { title: 'a' },
  { title: 'b' }
]

Expected output:
[
  { title: 'a' },
  { title: 'b' },
  { title: '' }
]

Since it's sorting by string alphabetically, I'd expect to see empty string at the end of the array, not at the beginning.

In my opinion this behaviour is correct, the empty string should appear first. If you consider also two chars, for example
a
ab

Then you can see a as a + '', and the empty string comes before that b.
Hence I think current behaviour is correct.


Installation of Plugin for NOMAD OASIS

Hi everyone,
I try to install a plugin for Nomad OASIS, which is installed on my local machine. I use instructions described under Option 2 from here
I had to adjust the Dockerfile in order to let Docker to find the source code for the build and then I received the following error message:
[+] Building 9.6s (8/9)                                          docker:default
 => [internal] load build definition from Dockerfile                       0.0s
 => => transferring dockerfile: 322B                                       0.0s
 => [internal] load metadata for gitlab-registry.mpcdf.mpg.de/nomad-lab/n  0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 2B                                            0.0s
 => [1/5] FROM gitlab-registry.mpcdf.mpg.de/nomad-lab/nomad-fair:latest    0.0s
 => [internal] load build context                                          0.0s
 => => transferring context: 3.64kB                                        0.0s
 => CACHED [2/5] RUN pip install build                                     0.0s
 => CACHED [3/5] COPY     src/nomad_greenlightparser     tests     README  0.0s
 => ERROR [4/5] RUN python -m build --sdist                                9.5s
------
 > [4/5] RUN python -m build --sdist:
0.757 * Creating isolated environment: venv+pip...
0.769 * Installing packages in isolated environment:
7.017   - setuptools-scm>=8.0
7.017   - setuptools>=61.0.0
7.017 * Getting build dependencies for sdist...
9.311 running egg_info
9.311 error: error in 'egg_base' option: 'src' does not exist or is not a directory
9.398
9.398 ERROR Backend subprocess exited when trying to invoke get_requires_for_build_sdist
------
Dockerfile:13
--------------------
  11 |         .
  12 |
  13 | >>> RUN python -m build --sdist
  14 |
  15 |     RUN pip install dist/nomad-schema-plugin-example-*.tar.gz
--------------------
ERROR: failed to solve: process "/bin/sh -c python -m build --sdist" did not complete successfully: exit code: 1

My dockerfile:
FROM gitlab-registry.mpcdf.mpg.de/nomad-lab/nomad-fair:latest

RUN pip install build

COPY \
    src/nomad_greenlightparser \
    tests \
    README.md \
    LICENSE \
    pyproject.toml \
    .

RUN python -m build --sdist

RUN pip install dist/nomad-schema-plugin-example-*.tar.gz

I run Nomad OASIS using the docker image downloaded from the Website on my Linux machine (POP! OS). Therefore I just can't build the package directly (that works) and install it via pip, since it uses another Python environment. So how do I install a Plugin originated from this template?

The docs are unfortunately a bit out of date, can you try some of the methods described here

Your proposed solution works for the command line tool, but I how do I install the plugin such that it can be seen in the GUI of NOMAD OASIS?