LND has some very old inflight payments without associated HTLC

Background
My lnd has many really old inflight payments (status = 1) which have no associated HTLC or invoices.
These payments can not be deleted because they are inflight.
And there is no chance these payments will ever succeed since they are so old.
Questions :

Why does LND hang on to these very old payments?
When and how these are removed, or progressed (marked failed 3 or unknown 0)

Here is an example of one such payment which is nearly a year old.
{
    "payments": [
        {
            "payment_hash": "378b9a32beacfbf7a07c03e9e0e98c0872c28e3a644a16185ca262ac95190cee",
            "value": "381220",
            "creation_date": "1628853635",
            "fee": "0",
            "payment_preimage": "0000000000000000000000000000000000000000000000000000000000000000",
            "value_sat": "381220",
            "value_msat": "381220000",
            "payment_request": "",
            "status": "IN_FLIGHT",
            "fee_sat": "0",
            "fee_msat": "0",
            "creation_time_ns": "1628853635111808994",
            "htlcs": [
                {
                    "attempt_id": "33997",
                    "status": "IN_FLIGHT",
                    "route": {
                        "total_time_lock": 695915,
                        "total_fees": "44",
                        "total_amt": "381264",
                        "hops": [
                            {
                                "chan_id": "764495932519350272",
                                "chan_capacity": "4000000",
                                "amt_to_forward": "381225",
                                "fee": "39",
                                "expiry": 695875,
                                "amt_to_forward_msat": "381225524",
                                "fee_msat": "39122",
                                "pub_key": "035b1ff29e8db1ba8f2a4f4f95db239b54069cb949b8cde329418e2a83da4f1b30",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "758977483516018688",
                                "chan_capacity": "381225",
                                "amt_to_forward": "381224",
                                "fee": "1",
                                "expiry": 695835,
                                "amt_to_forward_msat": "381224143",
                                "fee_msat": "1381",
                                "pub_key": "03037dc08e9ac63b82581f79b662a4d0ceca8a8ca162b1af3551595b8f2d97b70a",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "760774085596282881",
                                "chan_capacity": "381224",
                                "amt_to_forward": "381222",
                                "fee": "1",
                                "expiry": 695795,
                                "amt_to_forward_msat": "381222762",
                                "fee_msat": "1381",
                                "pub_key": "033d8656219478701227199cbd6f670335c8d408a92ae88b962c49d4dc0e83e025",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "763749364046626817",
                                "chan_capacity": "381222",
                                "amt_to_forward": "381221",
                                "fee": "1",
                                "expiry": 695755,
                                "amt_to_forward_msat": "381221381",
                                "fee_msat": "1381",
                                "pub_key": "0254b942f214919603f852ddba66610a0d2365a6a411f61ef79ed4bb9798468bfa",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "764633371377139712",
                                "chan_capacity": "381221",
                                "amt_to_forward": "381220",
                                "fee": "1",
                                "expiry": 695715,
                                "amt_to_forward_msat": "381220000",
                                "fee_msat": "1381",
                                "pub_key": "027ecdd3c509f7db2d8ade67381bb2e8ed88ccbfab8805d24076c4a0fd131f71ff",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "764458549095170049",
                                "chan_capacity": "2000000",
                                "amt_to_forward": "381220",
                                "fee": "0",
                                "expiry": 695715,
                                "amt_to_forward_msat": "381220000",
                                "fee_msat": "0",
                                "pub_key": "03c5528c628681aa17ab9e117aa3ee6f06c750dfb17df758ecabcd68f1567ad8c1",
                                "tlv_payload": false,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            }
                        ],
                        "total_fees_msat": "44646",
                        "total_amt_msat": "381264646"
                    },
                    "attempt_time_ns": "1628853635136165915",
                    "resolve_time_ns": "0",
                    "failure": null,
                    "preimage": null
                }
            ],
            "payment_index": "31889",
            "failure_reason": "FAILURE_REASON_NONE"
        }
    ],
    "first_index_offset": "31889",
    "last_index_offset": "31889",
    "total_num_payments": "0"
}

Your environment

version of lnd :    "version": "0.15.0-beta commit=v0.15.0-beta"
which operating system (uname -a on *Nix) Linux umbrel 5.10.17-v8+ #1421 SMP PREEMPT Thu May 27 14:01:37 BST 2021 aarch64 GNU/Linux

Steps to reproduce
lncli listpayments --index_offset 0 --paginate_forwards --max_payments 1 --include_incomplete
and continue until you find the first inflight payment.
Expected behaviour
LND should mark the payment failed when associated HTLC timeout.
Actual behaviour
LND has many very old inflight payments which are effectively orphan.

Related https://github.com/lightningnetwork/lnd/issues/6249 ?

I have one on my node. The payment is from two months ago. No HTLCs pending on the alleged outgoing channel involved, but lncli listpayments shows payment as being IN_FLIGHT.
{
    "payments": [
        {
            "payment_hash": "0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b",
            "value": "184527",
            "creation_date": "1654506732",
            "fee": "0",
            "payment_preimage": "0000000000000000000000000000000000000000000000000000000000000000",
            "value_sat": "184527",
            "value_msat": "184527000",
            "payment_request": "<redacted>",
            "status": "IN_FLIGHT",
            "fee_sat": "0",
            "fee_msat": "0",
            "creation_time_ns": "1654506732861871759",
            "htlcs": [
                {
                    "attempt_id": "69812",
                    "status": "IN_FLIGHT",
                    "route": {
                        "total_time_lock": 739649,
                        "total_fees": "36",
                        "total_amt": "184563",
                        "hops": [
                            {
                                "chan_id": "<redacted>",
                                "chan_capacity": "2000000",
                                "amt_to_forward": "184545",
                                "fee": "17",
                                "expiry": 739609,
                                "amt_to_forward_msat": "184545452",
                                "fee_msat": "17935",
                                "pub_key": "<redacted>",
                                "tlv_payload": true,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "<redacted>",
                                "chan_capacity": "10000000",
                                "amt_to_forward": "184527",
                                "fee": "18",
                                "expiry": 739569,
                                "amt_to_forward_msat": "184527000",
                                "fee_msat": "18452",
                                "pub_key": "<redacted>",
                                "tlv_payload": true,
                                "mpp_record": null,
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            },
                            {
                                "chan_id": "<redacted>",
                                "chan_capacity": "1000000",
                                "amt_to_forward": "184527",
                                "fee": "0",
                                "expiry": 739569,
                                "amt_to_forward_msat": "184527000",
                                "fee_msat": "0",
                                "pub_key": "<redacted>",
                                "tlv_payload": true,
                                "mpp_record": {
                                    "payment_addr": "c1b5f59db2671773ce3ab3c279c431315fb35ceaab9e138727f4ab0a2d56aa13",
                                    "total_amt_msat": "184527000"
                                },
                                "amp_record": null,
                                "custom_records": {
                                },
                                "metadata": null
                            }
                        ],
                        "total_fees_msat": "36387",
                        "total_amt_msat": "184563387"
                    },
                    "attempt_time_ns": "1654506733245416832",
                    "resolve_time_ns": "0",
                    "failure": null,
                    "preimage": null
                }
            ],
            "payment_index": "18627",
            "failure_reason": "FAILURE_REASON_NONE"
        }
    ],
    "first_index_offset": "18627",
    "last_index_offset": "18627",
    "total_num_payments": "0"
}

The payments are in inflight because they have inflight HTLCs that need to be updated. There's a related fix in #6683. After which I will work on this "payment stuck due to HTLCs not being updated after timeout" issue.

The payments are in inflight because they have inflight HTLCs that need to be updated. There's a related fix in #6683. After which I will work on this "payment stuck due to HTLCs not being updated after timeout" issue.

There does not appear to be any inflight HTLC (for the example I presented at least).

For me the issue disappeared for payments created after 24 May 2022, which corresponds to lnd v0.15.0-beta.rc3. It looks like older versions had the issue, and the corresponding older data about in-flight payments still needs to be cleaned up. As far as I understand the situation (there are multiple GitLab issues), @yyforyongyu is working on that cleanup mission?

@yyforyongyu is working on that cleanup mission?

The plan is to merge #6683 first to understand why these payments are stuck and once the reason is known we will make another fix.

I have a rather recent (Sat Oct 15 2022 16:54:47 GMT+0000, i.e. almost 11 days ago) payment that's pending. All HTLCs known by lnd are failed (temporary channel failure). There's no non-failed HTLC. The timelock values are below the current block height. The only outgoing channel doesn't have any pending HTLC. When I invoke lncli trackpayment HASH I do not get any output until I press CTRL+C.

Strangely, I also have this:
2022-10-15 18:56:49.138 [INF] IRPC: Canceled invoice HASH

Could this be the cause?
https://github.com/lightningnetwork/lnd/pull/6545
@yyforyongyu

@C-Otto unlikely as that only changes how SendToRoute behaves? Will look into this issue once itest is fixed, should be next week.

Alright. I think I can reproduce the issue by using lnd-manageJ's top-up feature, which sends out MPPs using the fix in #6545 (some of the shards failing, some payments not settling at all). Let me know if you need further information.

In order for a payment to have the status "failed", there are two conditions. First, there must not be any HTLC that's still in flight (not failed/settled). Second, the payment's failure reason needs to be set. This second criterion is not met for one of the should-be-failed payments that bothers me.
The payment's failure reason is persisted (only) in payment_control.go:Fail (lines 505, 543). This is invoked from control_tower.go:Fail (lines 236, 242).
For this, there are several invocations. One of them is in router.go:sendToRoute (lines 2180, 2304), which is conditional on !skipTempErr.
Code not making use of skipTempErr is able to deal with failed payments, for example in payment_control.go:InitPayment (lines 111, 148): "We allow retrying failed payments.".
With skipTempErr we do not want to mark payments as failed if just one shard failed. However, we also don't tell lnd that we won't try another shard (in my case, that's application logic outside of lnd). As such, lnd needs to mark a payment as failed on its own, for example after some timeout passed.

I pored over the logs for the singular case present on my node and here is what I can report:
The payment details is as per my previous post in this issue.
payment_hash = 0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b
When the payment was first sent, it was added to the outgoing channel as HTLC 3533. There is a corresponding entry for queuing keystone ADD packet but the channel link failed before the usual removing ADD packet from mailbox:
2022-06-06 17:12:13.213 [DBG] CRTR: Payment 0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b in state terminate=false, active_shards=0, rem_value=184527000 mSAT, fee_limit=74000 mSAT
2022-06-06 17:12:13.213 [DBG] CRTR: PaymentSession(0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b): pathfinding for amt=184527000 mSAT
2022-06-06 17:12:13.214 [DBG] CRTR: Pathfinding absolute attempt cost: 284.527 sats
2022-06-06 17:12:13.243 [DBG] CRTR: Found route: probability=0.5281999999999998, hops=3, fee=36387 mSAT
2022-06-06 17:12:13.243 [DBG] CRTR: Pathfinding perf metrics: nodes=5, edges=2254, time=30.285311ms
2022-06-06 17:12:13.711 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): queueing keystone of ADD open circuit: (Chan ID=0:0:0, HTLC ID=69812)->(Chan ID=<outgoing_short_chan_id>, HTLC ID=3533)
2022-06-06 17:12:13.711 [DBG] CRTR: Payment 0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b (pid=69812) successfully sent to switch, route: hop1 (184563387 mSAT) -> hop2 (184545452 mSAT) -> hop3 (184527000 mSAT), cltv 739649
2022-06-06 17:12:13.711 [DBG] CRTR: Payment 0181d246f8de9f69a8e9a151c4b841308f05364c1be01d0160d78b58d705727b in state terminate=false, active_shards=1, rem_value=0 mSAT, fee_limit=37613 mSAT
2022-06-06 17:12:13.713 [DBG] HSWC: Subscribing to result for paymentID=69812
2022-06-06 17:13:14.042 [ERR] HSWC: ChannelLink(<outgoing_channel_point>): failing link: unable to complete dance with error: remote unresponsive
2022-06-06 17:13:14.042 [INF] HSWC: ChannelLink(<outgoing_channel_point>): exited
2022-06-06 17:13:14.042 [INF] HSWC: Removing channel link with ChannelID(<outgoing_long_chan_id>)
2022-06-06 17:13:14.042 [INF] HSWC: ChannelLink(<outgoing_channel_point>): stopping
---
2022-06-06 17:16:32.108 [INF] PEER: disconnecting <outgoing_node_pubkey>@<outgoing_clearnet_address>:51509, reason: peer <outgoing_node_pubkey>@<outgoing_clearnet_address>:51509 no answer for 5m0s -- disconnecting
2022-06-06 17:16:32.108 [INF] PEER: unable to read message from <outgoing_node_pubkey>@<outgoing_clearnet_address>:51509: read tcp <IP_ADDRESS>:9735-><outgoing_clearnet_address>:51509: use of closed network connection
2022-06-06 17:16:32.108 [INF] NTFN: Cancelling epoch notification, epoch_id=885
2022-06-06 17:16:32.308 [DBG] FNDG: Cancelling all reservations for peer <outgoing_node_pubkey>
2022-06-06 17:16:32.309 [DBG] FNDG: No active reservations for node: <outgoing_node_pubkey>
2022-06-06 17:16:32.309 [INF] DISC: Removing GossipSyncer for peer=<outgoing_node_pubkey>
2022-06-06 17:16:32.309 [DBG] PRNF: PeerNotifier notifying peer: <outgoing_node_pubkey> offline

When the channel link recovered 30 minutes (-ish) later, the channel initiated with start_htlc_id of 3533 and HTLC 3532 was failed.
2022-06-06 17:43:56.829 [INF] SRVR: New inbound connection from <outgoing_clearnet_address>:59885
2022-06-06 17:43:56.829 [DBG] BTCN: Canceling: <outgoing_node_pubkey>@<outgoing_clearnet_address>:9735 (reqid 800)
2022-06-06 17:43:56.829 [DBG] BTCN: Canceling: <outgoing_node_pubkey>@<outgoing_tor_address>:9735 (reqid 801)
2022-06-06 17:43:56.829 [INF] SRVR: Finalizing connection to <outgoing_node_pubkey>@<outgoing_clearnet_address>:59885, inbound=true
2022-06-06 17:43:56.830 [DBG] PRNF: PeerNotifier notifying peer: <outgoing_node_pubkey> online
2022-06-06 17:43:56.852 [DBG] LNWL: ChannelPoint(<outgoing_channel_point>): Restoring 0 dangling remote updates
2022-06-06 17:43:56.852 [DBG] LNWL: ChannelPoint(<outgoing_channel_point>): Restoring 0 local updates that the peer should sign
2022-06-06 17:43:56.852 [INF] PEER: NodeKey(<outgoing_node_pubkey>) loading ChannelPoint(<outgoing_channel_point>)
2022-06-06 17:43:56.852 [DBG] CNCT: New ChainEventSubscription(id=36) for ChannelPoint(<outgoing_channel_point>)
2022-06-06 17:43:56.852 [INF] HSWC: Removing channel link with ChannelID(<outgoing_long_chan_id>)
2022-06-06 17:43:56.853 [INF] HSWC: ChannelLink(<outgoing_channel_point>): starting
2022-06-06 17:43:56.853 [INF] HSWC: Trimming open circuits for chan_id=<outgoing_short_chan_id>, start_htlc_id=3533
2022-06-06 17:43:57.037 [INF] HSWC: Adding live link chan_id=<outgoing_long_chan_id>, short_chan_id=<outgoing_short_chan_id>
2022-06-06 17:43:57.037 [INF] NTFN: New block epoch subscription
2022-06-06 17:43:57.037 [INF] PEER: Negotiated chan series queries with <outgoing_node_pubkey>
2022-06-06 17:43:57.037 [INF] DISC: Creating new GossipSyncer for peer=<outgoing_node_pubkey>
2022-06-06 17:43:57.037 [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(<outgoing_channel_point>)
2022-06-06 17:43:57.037 [INF] HSWC: ChannelLink(<outgoing_channel_point>): HTLC manager started, bandwidth=1089729235 mSAT
2022-06-06 17:43:57.038 [INF] HSWC: ChannelLink(<outgoing_channel_point>): attempting to re-synchronize
2022-06-06 17:43:57.258 [INF] HSWC: ChannelLink(<outgoing_channel_point>): received re-establishment message from remote side
2022-06-06 17:43:57.258 [DBG] LNWL: ChannelPoint(<outgoing_channel_point>): sync: remote's next commit height is 13690, while we believe it is 13690, we owe them a commitment
2022-06-06 17:43:57.259 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): removing Add packet (Chan ID=<some_other_short_chan_id_2>, HTLC ID=1826) from mailbox
2022-06-06 17:43:57.455 [INF] HSWC: ChannelLink(<outgoing_channel_point>): sending 2 updates to synchronize the state
2022-06-06 17:43:57.456 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): loaded 1 fwd pks
2022-06-06 17:43:57.456 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): removing completed fwd pkg for height=13689
2022-06-06 17:44:03.018 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): settle-fail-filter &{1 [0]}
2022-06-06 17:44:03.018 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): Failed to send 74798110 mSAT
2022-06-06 17:44:03.019 [DBG] HSWC: Closed completed FAIL circuit for 33e5564d53e8cc15e7ca1496354790073179e8ea66b623692522ac1ab025e5de: (<some_other_short_chan_id_2>, 1826) <-> (<outgoing_short_chan_id>, 3532)
2022-06-06 17:44:03.019 [DBG] HSWC: ChannelLink(<some_other_channel_point_2>): queueing removal of FAIL closed circuit: (Chan ID=<some_other_short_chan_id_2>, HTLC ID=1826)->(Chan ID=<outgoing_short_chan_id>, HTLC ID=3532)
2022-06-06 17:44:03.636 [DBG] HSWC: ChannelLink(<some_other_channel_point_2>): removing Fail/Settle packet (Chan ID=<some_other_short_chan_id_2>, HTLC ID=1826) from mailbox

The next payment I sent out via the channel then apparently re-used HTLC 3533:
2022-06-06 17:49:56.213 [DBG] CRTR: Payment 6a6f1e6254b9442e71ab2f66a5d67dbd23b896c6fed4a2a2ac946de072363412 in state terminate=false, active_shards=0, rem_value=184527000 mSAT, fee_limit=74000 mSAT
2022-06-06 17:49:56.213 [DBG] CRTR: PaymentSession(6a6f1e6254b9442e71ab2f66a5d67dbd23b896c6fed4a2a2ac946de072363412): pathfinding for amt=184527000 mSAT
2022-06-06 17:49:56.214 [DBG] CRTR: Pathfinding absolute attempt cost: 284.527 sats
2022-06-06 17:49:56.244 [DBG] CRTR: Found route: probability=0.5281999999999998, hops=3, fee=36387 mSAT
2022-06-06 17:49:56.244 [DBG] CRTR: Pathfinding perf metrics: nodes=5, edges=2166, time=30.454277ms
2022-06-06 17:49:57.559 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): queueing keystone of ADD open circuit: (Chan ID=0:0:0, HTLC ID=69814)->(Chan ID=<outgoing_short_chan_id>, HTLC ID=3533)
2022-06-06 17:49:57.560 [DBG] CRTR: Payment 6a6f1e6254b9442e71ab2f66a5d67dbd23b896c6fed4a2a2ac946de072363412 (pid=69814) successfully sent to switch, route: hop1 (184563387 mSAT) -> hop2 (184545452 mSAT) -> hop3 (184527000 mSAT), cltv 739654
2022-06-06 17:49:57.560 [DBG] CRTR: Payment 6a6f1e6254b9442e71ab2f66a5d67dbd23b896c6fed4a2a2ac946de072363412 in state terminate=false, active_shards=1, rem_value=0 mSAT, fee_limit=37613 mSAT
2022-06-06 17:49:57.562 [DBG] HSWC: Subscribing to result for paymentID=69814
2022-06-06 17:49:58.187 [DBG] HSWC: ChannelLink(<outgoing_channel_point>): removing Add packet (Chan ID=0:0:0, HTLC ID=69814) from mailbox

Therefore, I am guessing the payment tracker is still waiting for the original HTLC 3533 to fail, but it was half-sent in the first place and was abandoned somehow by the channel link. So, the payment remains IN_FLIGHT till this day.

could this also be causing bloating sphinxreplay.db ?

Most of the data in sphinxreplay.db is just garbage, see #7107. With my fix I was able to reduce my sphinxreplay.db to 11 MByte.

when merge to master?


core: GetBucketPolicy API should return all errors.

GetBucketPolicy should return exact error received
from the server and let the caller manage it.
Fixes #664

Is it possible to add a functional test that simulates the issue being fixed here?

Functional test added as well.


Adding titles to CLI doc.

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@pcuenca this is all generated, it's easier to fix the script directly :)


Adding default app ID to socket url

As per the documentation here, adding a default application id for myo.js. In the future it would be good to expose this so individual apps can easily set their own ids.

This feature has been added in the 2.1.0 release. Thanks for the suggestion @smngreenberg!


Updated to new pySerial 3.0 interfaces

I have a style question on these changes. Since the 'getters' and 'setters' are attributes, they don't need to be invoked as functions anymore. Maybe the references should something like this:
s = self.port.dsr
self.port.rts = False

I don't believe it's merely the pySerial client's stylistic choice - using it with and without the parenthesis represent different operations.  In one case you're directly reading/write a value from an objects "member values"; in the other case you're calling a function defined by the object to return the value to you.  The latter is far more flexible to the object creator - you only need to have the value be valid when the 'get' function is called.
Sure enough, though, it looks like the pySerial package is set up to use the direct access style you'd favor:
def setDTR(self, value=1):
    self.dtr = value

which is to say, calling the old-style "setDTR(True)" function is simply changing the value of 'dtr' as passed.
I've updated the change to read as you suggested, which looks like the ONLY correct way to use the new PySerial interfaces.

This works fine. Thank you. Merge at will!

I haven't taken the time to look at the PySerial code, but is it possible that they used @property to set up the member value with a getter/setter that are used when you access it? The @property decorator was added in Python3. With that, port.dsr might not be directly reading/writing the value, it might be going through get/set methods.

Python3 added the decorator to make python code easier to read/write while still allowing classes to encapsulate class attributes.

Not even something I was aware of.  Looks like a member value reference, turns out to be a function call... Hmmm, not sure I'm fond of the style but it certainly works!

They did it because one of Python's tenets is to make code easy to write
and clear to read. At the same time, they wanted to support encapsulation.
The hope is that by using this feature it makes the client code easy and
clear and it's fine because the client doesn't need to know if processing
is being done or not when the value is accessed.
C# has always had this same capability (easily add set/get code to member
value access). In C# code you shouldn't have any 'get'/'set' methods - most
style checkers have a rule to flag these methods as it clutters the client
code with unnecessary '()' pairs.
On Mon, Aug 3, 2020, 11:32 AM Patrick Dirks<EMAIL_ADDRESS>wrote:

Not even something I was aware of. Looks like a member value reference,
turns out to be a function call... Hmmm, not sure I'm fond of the style but
it certainly works!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/MorseKOB/PyKOB/pull/124#issuecomment-668176551, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AETPXOYV345WSR4WTJI5TMLR637EBANCNFSM4PSY4JBQ
.


[feature] Decompiler

Just an request for an sibling block to the printer, where it decompiles items into XP at about 1/4th the cost it would take to PRODUCE the item,
say STONE takes 13 bottles of enchanting, (12 for example),
decompiling Stone returns 3 bottles of enchantings worth of xp
make the recipie like, the same as the Printer, but take a printer instead of a diamond block, (for balancing reasons)

Interesting idea. I have a few questions, though:

What power do you think the Decompiler would run on?
Do you have any visual appearance for the block in mind?
Since it only produces one thing, there'd be no need to display an item being printed. The input item could perhaps be displayed with another screen on the block, or it could be a traditional machine with a GUI you could open like a furnace; any preference?

The 3/4ths experience of the item that you dont get back (technically, or could use TechReborn power)

not really? was thinking close to the printer, but with a red top, and DOES NOT automatically decompile, requires redstone pulse to trigger (like a button) incase you put something you dont want to decompile into it. (another redstone pulse could cancel it at any point between activation and finishing)

maybe displayed on screen and as an "Hologram" but with the reverse animation, instead of "fade in", it "fades out",
the screen could probably show an red bar behind the item as it "decompiles" showing the progress


Integration suggestion for else-if statement

It seems that recently the only way to write else-if clauses is to write it as two blocks -

I have a suggestion on integrating such into one using 又若 (= or if) or something similar:

(The screenshot is edited using image editing software, not the display of the IDE)

或若，君以为何如？

@lymslive My original idea was to use 或若, but 或若 could be used independently meaning only "if" (as in 《敦煌變文集· 前漢劉家太子傳》：“汝緣年少，或若治國不得， 有人奪其社稷者，汝但避投南陽郡。”), so I chose 又若 that carries the character meaning "and".

I don't think it's problem.
不能拘泥于某篇古文献“或若”曾有“if”用意，就否定，只要在 wenyan-lang 中不会有语法解析歧义就可考虑，而且我觉得“或若”这词的古风意境比“又若”更适合 wenyan-lang

I think neither 又若 nor 或若 is conventionally used to mean "else if", so we can probably decide based on the semantic of the characters themselves (unless someone come up with another phrase). Among the two, I personally prefer 或若 slightly more, since I feel like 或 hints the fact that it's an "either-or" relation, whereas 又 is more like "additionally". But I'm happy to hear more discussion :)

Here update argument.
Actually in C, there is no so called "else if" statement, only "if else" statement.
if (cod1) {
    state1;
}
ese if (cod2) {
    state2;
}
else {
    state3;
}

is truely equivalent to
if (cod1) {
    state1;
}
ese {
    if (cod2) {
        state2;
   }
    else {
        state3;
   }
}

Because else can only accept one statement without {} block. So the second if else is just the only one statement for the previous else, and since there is no other statement, there is no need for extra {}.
Now back to wenyan-lang, else if can just view as 若非若, let me reformat your sample code(I ignore the single quote for identifier as poor input method):
若甲不大于五者
 　　乃得“小”
若非若甲不大于十者
　　乃得“中”
若非
　　乃得“大”
也也

The only strange view may end with tow 也s .
While on other hand, we can easily know how many if branch have written through counting the number of 也, they must be matched. （用写中文文章的章法来说，这叫前后呼应）So it may not be  too bad. If you have to write too many 也s, that means you have designed too many branches, that won't be beautiful code anyway.
Then it's term for editor plugin to reformat 若非若 .

@lymslive You're exactly right. Languages like C and JavaScript gets else if for free because single statement does not need to be enclosed by {}. Languages that got rid of the {}'s such as python, ruby, lua pay a price and had to define separate elseif elif or even elsif keywords.
I think 也也也 is very ugly and sounds like "yeah yeah yeah" or "yay yay yay" and goes against the philosophy of this language. We can mitigate the issue by using 云云 and 也 alternatingly (that's in fact why 云云 is added as an alias keyword).
I understand your point that code with too many branches are ugly anyway, but I think a series of else-if's are sometimes necessary, especially since we don't have switch statement yet.
In summary I think a separate elseif keyword like in python, ruby, etc. would be more readable, but I'm also happy to discuss other alternatives.
Thanks!

Thought it may not related to this issue, I'm curious 云云 is alias to what keyword? I want get more ideal about your thought on design wenyan-lang,however I'm js expert since not used often in daily work, and so have not read the source.
I have heard someone said the 云云 may something map to } .That's not good way if try to do such  direct mapping, it definitely can't void multi `}}`` block.
And no matter how to implement, I image that it is still hard to treat nest loop and if case. For example, two for loop is very common in practical coding, end with two } if no extra statement in the outer loop. Then in wenyan-lang we must say 云云云云,  that also not sound good as 也也也也.
Some times we seams no way to tolerate, and balance tradeoff.

@lymslive 云云 is alias to 也,  so }} case is never a problem. You can spot this usage in many ./examples. When there are three or more }, I would recommend repeating the 云云 and not the 也, because 云云 In classical Chinese is a bit similar to 等等 ("and so on"), and such repetition (等等等等) is much more acceptable.

I agree 云云  can means "and so on", that's good used in loop, but not so good in condition if.
Especially when only one if, you use one 也, but when two or more if, suddenly replace with 云云云云, that's not consistent. After all, normal user cannot notice that 云云 is alias to 也, that is technique detail or tricky.

我还是用中文跟你讨论一个有关汉语的特有现象吧，前面看到你说 "alternatingly" 还以为你是想要找那样一个可轮换叠韵且意义相同的词组。
汉字大部分是单音节字，一个汉字能表示一个意思，但也有极少部分是双音节词（多音节词就更少了），它单独一个字没法表示意义，须两个字合起来才能表达意义，例如：

忐忑
叮咚 嘀哒 这可能不很准确，拆开来单用似乎也可以，但多为联用
'蝴蝶 也奇怪，蝶单独使用，但蝴`没见过单独使用的

我以为你要为多层嵌套的 if 结束符 }}}.... 找一个类似 叮咚叮咚叮咚…… 或 嘀哒嘀哒嘀…… 的词组，两个同义的字轮换使用，不致音律太单调，然后在任何一个音节停止也不致太违和。
这种语义说起来其实是很适合多层 if ... else if ... else if ... 的程序条件，因为后者看起来也像是不确定地轮换跳跃着，但最终落到一个分支上。
但古汉语中有没有类似的词组，我也一下子想不起来，集思广义吧。
噫吁戲这样的虚词，算是多音节词，其中单字不用或少用。但它不是叠韵的，不可重复使用。
以也字开头的多音节虚词，暂只想到元杂剧有 也么哥, 不过这偏口语俚语，不那么有古意，不过试着朗读下：
兀的不痛杀我也　　　　　　　// }
兀的不痛杀我也么　　　　　　// }}
兀的不痛杀我也么哥　　　　　// }}}
兀的不痛杀我也么哥也　　　　// }}}}
兀的不痛杀我也么哥也么　　　// }}}}}
兀的不痛杀我也么哥也么哥　　// }}}}}}
兀的不痛杀我也么哥也么哥也　// }}}}}}}

（开心娱乐下 ^_^）

也            // }
然也          // }}
然也哉        // }}}
然也然也      // }}}}
然也矣哉      // }}}}
然也然也矣哉  // }}}}}}

:smile:


[24.05] opentelemetry-collector: apply patch for CVE-2024-36129

Description of changes
https://github.com/advisories/GHSA-c74f-6mfw-mm4v
I avoided to backport the whole upgrade because there are other BC announced in upstream release notes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

error: hash mismatch in fixed-output derivation '/nix/store/jpmvcvyfaf1zcrq78z7n8bcfvb43wwfv-opentelemetry-collector-0.101.0-go-modules.drv':
         specified: sha256-jl+yDdHlfairqbB5mONFSnQoEiz+3PfB+TRQZlniA2M=
            got:    sha256-Bay8D+jEj5iXedsbWQPFY+n1/li75bWGEtanllS/APQ=

I get the same hash then the one you get. I think I got the hash before the last change I made to the modRoot :thinking:

Does this need applying to the -contrib copy too?

Does this need applying to the -contrib copy too?

Hum good catch. Do you see a way to that in a reasonable way? The dep is pulled via go mod https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/c0b51136575aa7ba89326d18edb4549e7e1bbdb9/cmd/otelcontribcol/go.mod#L208


Admin - Revise Docker and docker-compose build

Description
Revised docker-compose setup that supports:

[x] Completely automated deployment of the stack on a workstation or public host
[x] Use by workstation developers, where it will support development without requiring development tools past docker-compose
[ ] Consolidate logs from running services
[x] App permissions for Laravel directories
[ ] Ability to use the same app image in development and deployment
[x] Hosted in its own GCTC-NTGC repo

Resolved by https://github.com/GCTC-NTGC/tc-docker


Use Set to detect banned teapot segments

The previous implementation was O(n^2) where this implementation using a Set is O(n).

Thanks @jc00ke! As @astronaut-wannabe pointed out, there are a couple Rubocop little changes needed, otherwise this looks great. 🎉

Awesome.


Fuzzy testing

Add a fuzzy testing framework and tests.
You can start by creating a fuzzer folder, with a skeleton structure of a fuzzer, like we do in the VM
https://github.com/lambdaclass/cairo-vm/blob/95d2c88fcd4ef799ff64fc392efd633c05fa37e4/fuzzer
For the moment I think is too much work to start fuzzing a .sierra program, but making the skeleton structure plus adding some useful functions will work fine

Hello!
I am interested in this one, could you please provide me more details?

@jbmkahdeksan You have another issue assigned no?

@jbmkahdeksan You have another issue assigned no?

I believe he commented on this issue during the last odhack

yes, that is correct
I commented on this one on the last OD Hack, 2.0
you may take it @hhamud
cc. @pefontana
thanks for your consideration and for giving me another issue!


packaging: bump rpm version to 0.21.0

skip skydive-go-fmt
skip skydive-functional-tests-backend-elasticsearch
skip skydive-functional-tests-backend-orientdb
skip skydive-scale-tests
skip skydive-cdd-overview-tests
skip skydive-unit-tests
skip skydive-compile-tests
skip skydive-k8s-tests
skip skydive-ppc64le-tests

run skydive-build-copr

run skydive-create-docker-image

run skydive-create-docker-image

run skydive-create-docker-image

merge this PR before the v0.21.0 tag https://github.com/skydive-project/skydive/pull/1503


CLA Section replaced with DCO description

This pull request pertains to issue #82(Community -> Contributing -> CLA section is outdated)

I apologize for the error. I will close this pull request as I incorrectly signed off.


Fix squad V2 metric script

The current squad v2 metric doesn't work with the squad (v1 or v2) datasets. The script is copied from squad_evaluate in transformers that requires the labels (with multiple answers) to be like this:
references = [{'id': 'a', 'answers': [
    {'text': 'Denver Broncos', 'answer_start': 177},
    {'text': 'Denver Broncos', 'answer_start': 177}
]}]

while the dataset had references like this:
references = [{'id': 'a', 'answers':
    {'text': ['Denver Broncos' 'Denver Broncos'], 'answer_start': [177, 177]}
}]

Using one or the other format fails with the current squad v2 metric:
from datasets import load_metric
metric = load_metric("squad_v2")
predictions = [{'id': 'a', 'prediction_text': 'Denver Broncos', 'no_answer_probability': 0.0}]
references = [{'id': 'a', 'answers': [
    {'text': 'Denver Broncos', 'answer_start': 177},
    {'text': 'Denver Broncos', 'answer_start': 177}
]}]
metric.compute(predictions=predictions, references=references)

fails as well as
from datasets import load_metric
metric = load_metric("squad_v2")
predictions = [{'id': 'a', 'prediction_text': 'Denver Broncos', 'no_answer_probability': 0.0}]
references = [{'id': 'a', 'answers':
    {'text': ['Denver Broncos' 'Denver Broncos'], 'answer_start': [177, 177]}
}]
metric.compute(predictions=predictions, references=references)

This is because arrow reformats the references behind the scene.
With this PR (tested locally), both the snippets up there work and return proper results.

The script with changes is used and tested in #8924. It gives the same results as the old evaluate_squad function when used on the same predictions.

merging since the CI is fixed on master


use explicit call index

https://github.com/paritytech/substrate/pull/12891

Codecov Report

Merging #865 (9f4db77) into master (dc39cfd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   78.84%   78.84%
=======================================
  Files         102      102
  Lines       10546    10546
=======================================
  Hits         8315     8315
  Misses       2231     2231

Impacted Files
Coverage Δ

asset-registry/src/lib.rs
91.86% <ø> (ø)

auction/src/lib.rs
90.32% <ø> (ø)

authority/src/lib.rs
82.35% <ø> (ø)

bencher/test/src/lib.rs
0.00% <ø> (ø)

benchmarking/src/tests.rs
96.77% <ø> (ø)

currencies/src/lib.rs
48.98% <ø> (ø)

gradually-update/src/lib.rs
88.75% <ø> (ø)

oracle/src/lib.rs
76.36% <ø> (ø)

payments/src/lib.rs
83.17% <ø> (ø)

tokens/src/lib.rs
82.65% <ø> (ø)

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot access data whose model name begins with a lowercase letter

#16

As a workaround until the bug is fixed; you can use @@map("real_table_name") to separate the model name from the table name, which will solve this problem.
(Don't forget to re-run prisma generate in the Docker component after the schema modification.)
model User {
  id                        String                   @id
  logs                      Log[]
  @@map("tbl_User")
}

model Log {
  id             Int      @id @default(autoincrement())
  type           LogType
  message        String?
  createdAt      DateTime
  user           User @relation(fields: [userId], references: [id], onUpdate: NoAction)
  userId         String

  @@map("tbl_Log")
  @@index([userId])
}

enum LogType {
  SUCCESS
  FAILED
}

It appears that I was mistaken on this issue.
The problem did not reproduce itself and I was able to access the data without any problem.

s.


TSlint extends are ignored

Quite likely related to #30. Blocking #32.
Spent almost the whole day on debugging why prettier compatible rules are not applied, causing tests to fail.
It seems that "extends" rules from tslint are not applied when we call lint(). To reproduce, checkout the repo, keep only "extends" rule/s in tslint.json and run npm run build && npm run test:typescript-no-prettier. You'll get an error saying No valid rules have been specified for TypeScript files (but not exit 1!)

This could mean that we have a bunch of recommended rules disabled on all projects using resin-lint.

Resolved


ls command doesn't support Chinese character filename, will return empty result

Alluxio Version:
2.5.2
Describe the bug
when ls on a directory, if the directory contains Chinese character(unicode 16 I suppose), the ls will return empty result which confuse user.
To Reproduce
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs  mount --option aws.secretKey=aeef4e8cce5a6e8b55548b4788741bd3   --option aws.accessKeyId=57d71c51a2dae1ea --option alluxio.underfs.s3.endpoint=http://jssz-boss.bilibili.co /cache s3://cv_data/chenweidong/
Mounted s3://cv_data/chenweidong at /cache
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs ls /cache
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs cat /cache/fpmodel_v2.py
import torch
import torch.nn as nn
class FPModel(nn.Module):
def init(self, inp, hp, cls_num):
....
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs ls /cache/imdb
11705       PERSISTED 12-21-2021 07:20:20:891  DIR /cache/imdb/00
10005       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/11
16641       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/01
20982       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/12
16449       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/02
17814       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/13
12423       PERSISTED 12-21-2021 07:20:20:892  DIR /cache/imdb/03
...
root@jssz-coeus-alluxio-01:~# aws --endpoint http://jssz-boss.bilibili.co s3 ls s3://cv_data/chenweidong/
.....
2020-12-08 12:20:37     144978 人脸关键点标注数据介绍.pdf

I test which are all right with alluxio version 2.5.0-2, 2.6.0 and 2.7.0. Can you give some server logs?

@ljl1988com
Yes, using Alluxio fs ls can see the file, but the fuse POSIX list return empty.
I provide example in above description:
'''
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs ls /cache
root@jssz-bigdata-datanode-2050:/opt/alluxio-release-2.5.0-2-SNAPSHOT# alluxio fs cat /cache/fpmodel_v2.py
import torch
import torch.nn as nn
'''

@Nizifan I test fuse mount with newest version. Command ls in the mount path is right.

Maybe I can share some experience about this issue.
We have several alluxio clusters and there are users accessing it through alluxio-fuse.
Our users encountered the exception InvalidPathException: Malformed input or input contains unmappable characters several times when there are files with Chinese character names.
This exception may be thrown from the AlluxioMaster, AlluxioWorker and AlluxioFuse processes.
I made some investigation and found that LANG=en_US.UTF-8 needs to be set in the environment of the shell while starting these process. I added export LANG=en_US.UTF-8 to conf/alluxio-env.sh and it resolved this issue.
One more thing to take care is that the environment variable LANG may be override by locale settings like LC_ALL, LC_NAME. So it is better to set locale related variables to en_US.UTF-8 too.
Hope this helps.


Exception traceback incorrect within a context manager

The exception traceback is incorrect within a context manager. Very annoying when trying to debug pip failures.
Repro code:
import contextlib

@contextlib.contextmanager
def test_context():
    try:
        yield
    finally:
        pass

def test():
    def testA():
        testB()
    def testB():
        testC()
    def testC():
        raise Exception
    with test_context():
        testA()

test()

Expected traceback:

Traceback (most recent call last):
File "", line 1, in
File "", line 9, in test
File "", line 3, in testA
File "", line 5, in testB
File "", line 7, in testC
Exception

Actual traceback:

Traceback (most recent call last):
File "", line 1, in
File "Lib\contextlib.py", line 35, in __exit__
File "", line 4, in test_context
Exception

Simplified repro:
import sys

def gen_exc(type, value, traceback):
    def generator(): yield
    gen = generator()
    try:
        gen.throw(type, value, traceback)
    except:
        pass

try:
    raise Exception
except:
    gen_exc(*sys.exc_info())
    raise

Expected traceback:

Traceback (most recent call last):
File "", line 2, in
Exception

Actual traceback:

Traceback (most recent call last):
File "", line 5, in gen_exc
File "", line 0, in generator
Exception

Ok, I think the underlying issue is that our frames/traceback are stored in our exceptions so when an exception gets rethrown the original traceback gets clobbered. Here's the final repro:
def trycatch(e):
    try:
        raise e
    except:
        pass

try:
    raise Exception
except Exception as e:
    trycatch(e)
    raise

Expected traceback:

Traceback (most recent call last):
File "", line 2, in
Exception

Actual traceback:

Traceback (most recent call last):
File "", line 3, in trycatch
Exception


feat(backend)(1): implement CSV to Postgres data importer

Description
This PR adds the process flow to seamlessly import data from CSV file to Postgres database.
Test plan
Checkout branch
git fetch && git checkout nishant/implement-csv-to-postgres-importer

Change directory
cd backend

Install dependencies
npm i

Start services using Docker
docker-compose up -d

Start script to extract New York trees data from remote server to Postgres
npm run import-ny-trees

Note: the above command may take a few minutes to process
💡 Verify if the import was successful by accessing trees table
Related Issues
Parent task:

#1  ✅

Sub-tasks:

#2  ✅
#3  ✅
#4  ✅

tACK. Self-reviewed.


Decouple DevChat with a workspace in VS Code

When I don't open a workspace or a project, the underlying DevChat actually uses the user home folder to create .chat and can work properly. Should we support use of DevChat not in any project/workspace instead of raising the following issue? There are new users who have just installed and started VS Code.

Can we just set the user settings in this case? Of course, if the user opens a workspace, we can also copy to workspace settings.

This has fixed in pre-release 2023.08.28.


Push notification not received on Android when app is 'force closed' by user

Hi all,
I am trying to send a push notification to an Android device that is force closed by the user. I've seen several posts about this topic, but even after trying different suggested possible solutions I am not experiencing any success. The push notifications do pop up on IOS when it is force closed by the user, but for Android this does not seem to work. However, the push notifications are received when the app is in background, and after opening the app and checking the data that was sent with the push notification I can see that the data ('force-start', 'priority') is sent with the push notification. Anyone else experiencing similar problems. Solutions are more than welcome :)
Expected Behaviour
Push notification received on Android
Actual Behaviour
Nothing happens
Reproduce Scenario (including but not limited to)
Sending a push notification from server with the following JSON data:
{
'registration_ids' => ['bla-bla-bla']
'data': {
'badge': 1,
'message': 'New questions available',
'force-start': 1,
'priority': 1,
'title': 'My App Name',
'notId': 1,
},
'time_to_live': 600,
}
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 6.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Huawei P5 Lite
Cordova CLI version and cordova platform version
Cordova 6.4.0
Cordova platform version 6.0.0
Plugin version
1.9.2
Sample Push Data Payload
{
'registration_ids' => ['bla-bla-bla']
'data': {
'badge': 1,
'message': 'New questions available',
'force-start': 1,
'priority': 1,
'title': 'My App Name',
'notId': 1,
},
'time_to_live': 600,
}

@TheBurgerShot I'm pretty sure you are running into this:
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#huawei-and-xiaomi-phones
Try what is documented there and let me know.

@macdonst Fortunately there are always others with a sharp mind. Thanks a lot!


[bugfix] add empty namespace

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ea1fef6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   96.96%
  Complexity        ?        7
=========================================
  Files             ?        1
  Lines             ?       33
  Branches          ?        0
=========================================
  Hits              ?       32
  Misses            ?        1
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1fef6...0090ea2. Read the comment docs.


Add LaSalle College Vancouver

Add my institute to the list: http://www.lasallecollegevancouver.com/
both Students and Instructors uses the @lasallecollegevancouver.com email

@lcheunglci Pull request merged. Thank you!


Update package.json dependencies to avoid ionic-app-scripts issue #212

Short description of what this resolves:
Updates changelog to avoid issue https://github.com/driftyco/ionic-app-scripts/issues/212.
Changes proposed in this pull request:

Dependencies updated to match https://github.com/driftyco/ionic2-app-base/blob/master/package.json.

Thanks!


Update aws_lambda filter , set aws lambda function region as default host

set aws lambda function region as default host
fix for  #11292.
Risk level: N/A
Testing: N/A
Signed-off-by: StevenSu<EMAIL_ADDRESS>

@mattklein123  I found azure pipeline error "PARSE ERROR: Argument: --bogus-flag"  , but my code only include aws lambda filter part.  I have no idea why macOS build failed ,   could you help me out ?
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/40389/logs/105
2020-05-24T01:07:33.2892440Z PARSE ERROR: Argument: --bogus-flag
2020-05-24T01:07:33.2901410Z              Couldn't find match for argument

/retest

@stevensu1977 just to re-iterate what I mentioned in the issue. I don't see why this change is needed. I used the configuration you provided in the original issue as is, changed the target Lambda function ARN, and it worked as expected.


Dependency Updates for SFNO

Earth2Studio Pull Request
Description

Closes: https://github.com/NVIDIA/earth2studio/issues/53
Confirmed these are the missing makani deps for SFNO on multiple machines today. Adding to TOML in optional installs.
I also fix onnx version here, for some reason 1.18.0 runtime seems to have some issues.
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[x] An issue is linked to this pull request.

Dependencies

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci

/blossom-ci


Start of day fails to handle change from daylight saving

Steps to reproduce
Timex.parse!("2022-10-29 09:17:42.642885+01:00 BST Europe/London", "{ISO:Extended}")
|> Timex.Timezone.convert("Europe/London")
|> Timex.shift(hours: -8)
|> Timex.shift(days: 1)
|> Timex.beginning_of_day()
This returns:
** (Timex.ConvertError) unable to convert value, insufficient date/time information
(timex 3.7.9) lib/datetime/map.ex:41: Timex.Protocol.Map.beginning_of_day/1
We actually used Timex.now("Europe/London"), but the above recreates the issue
Description of issue
I expected it to return the start of the day as would have happened an hour later.
#DateTime<2022-10-30 00:00:00.000000+01:00 BST Europe/London>
Timex.parse!("2022-10-29 09:17:42.642885+01:00 BST Europe/London", "{ISO:Extended}")
|> Timex.Timezone.convert("Europe/London")
|> Timex.shift(hours: -7)
|> Timex.shift(days: 1)
|> Timex.beginning_of_day()
#DateTime<2022-10-30 00:00:00.000000+01:00 BST Europe/London>
The values for -7 and -9 are correct, it only fails for -8

I had failed to handle AmbiguousDateTime.


chore: Move basic Int lemmas earlier

A bunch of lemmas about Int can be moved to Data.Int.Defs at little cost. This PR moves them and deletes the now empty Data.Int.Div and Data.Int.Dvd.Basic.
The story is that those lemmas used to rely on lemmas proved for algebraic order structures, hence required the algebraic order instances on Int to be available. In Lean 4, those preliminary lemmas have been special-cased to Nat and Int, so there is no need for the general instances anymore (at least in basic files).

bors merge


Update README.md + Translations

Now we don't have config.env anymore, we now use config.json inside props folder

Oh, thank you so much for that! I have renamed your PR, since you are also adding translations to the project.
Also, I will do more testing on my side to see if I need to change some things on your code. I will put your name in the credits, since you are contributing so much with the bot. Thank you!
~ Lucas

I made some little checks and I'll approve your pull request. Ty for the submission!


Query regarding addition of deep learning based image transformations

Dear Sir, @smaranjitghose
I wanted to know whether can we add deep learning based image transformations, like those done by StyleGANs or such, to create interesting results on various images. An example of such an image transformation based on the image given in the readme could be seen below,

The art style is that of  Wassily Kandinsky, and such results could be obtained by various implementations of StyleGANs. With your permission I would like to work on the same and contribute the code related to acquiring such results.
I was trying out such models and intend to implement them and contribute to open source via the DWOC programme.

Dear Sir, @smaranjitghose
I wanted to know whether can we add deep learning based image transformations, like those done by StyleGANs or such, to create interesting results on various images. An example of such an image transformation based on the image given in the readme could be seen below,

The art style is that of Wassily Kandinsky, and such results could be obtained by various implementations of StyleGANs. With your permission I would like to work on the same and contribute the code related to acquiring such results.
I was trying out such models and intend to implement them and contribute to open source via the DWOC programme.

Wow! I didn't expect much of the participants to be interested in GANs let alone StyleGAN. Sure, I am looking forward to your contributions @C3Suryansu

Any updates @C3Suryansu . It's been almost 3 weeks

Any updates @C3Suryansu . It's been almost 3 weeks

Extremely sorry sir, I have been busy with college exams and work, hence been unable to work and submit the code for the same. I shall make a PR regarding this within few days.

Extremely sorry sir, I have been busy with college exams and work, hence been unable to work and submit the code for the same. I shall make a PR regarding this within few days.

Extremely sorry sir, I have been busy with college exams and work, hence been unable to work and submit the code for the same. I shall make a PR regarding this within few days.

I totally understand your position being a senior year undergrad myself. Just let me know if you are busy from next time onwards so that I am aware you are willing to continue with this issue meanwhile I let others try😊

Extremely sorry sir, I have been busy with college exams and work, hence been unable to work and submit the code for the same. I shall make a PR regarding this within few days.

I totally understand your position being a senior year undergrad myself. Just let me know if you are busy from next time onwards so that I am aware you are willing to continue with this issue meanwhile I let others try😊

Hello sir, I don't think I will be able to work on this before February first week due to semester exams. Please go ahead with assigning this issue to others. Really sorry for this.

Hello sir, I don't think I will be able to work on this before February first week due to semester exams. Please go ahead with assigning this issue to others. Really sorry for this.

I would like to work on this issue. I am DWoC participant. @smaranjitghose can you please assign this to me?

I would like to work on this issue. I am DWoC participant. @smaranjitghose can you please assign this to me?

I would like to work on this issue. I am DWoC participant. @smaranjitghose can you please assign this to me?

This is just a discussion issue. If you know how to use StyleGan2 raise a new PR for it

I would like to work on this issue. I am DWoC participant. @smaranjitghose can you please assign this to me?

This is just a discussion issue. If you know how to use StyleGan2 raise a new PR for it

Hello sir, I don't think I will be able to work on this before February first week due to semester exams. Please go ahead with assigning this issue to others. Really sorry for this.

Its' fine. I can understand

Hello sir, I don't think I will be able to work on this before February first week due to semester exams. Please go ahead with assigning this issue to others. Really sorry for this.

Its' fine. I can understand


CNN model locks up PC

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code : Yes (https://github.com/briansp2020/kaggle_quora/blob/master/kernel-cnn.ipynb)
OS Platform and Distribution : Ubuntu 18.04 ROCm 1.9.1
TensorFlow installed from (source or binary): pip install tensorflow-rocm
TensorFlow version (use command below): 1.11
GPU model and memory:

You can collect some of this information using our environment capture [script]
$ cat tf_env.txt
== cat /etc/issue ===============================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
VERSION="18.04.1 LTS (Bionic Beaver)"
VERSION_ID="18.04"
VERSION_CODENAME=bionic
== are we in docker =============================================
No
== compiler =====================================================
c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
== uname -a =====================================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
== check pips ===================================================
== check for virtualenv =========================================
False
== tensorflow import ============================================
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named tensorflow
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
NVIDIA-SMI has failed because it couldn't communicate with the NVIDIA driver. Make sure that the latest NVIDIA driver is installed and running.
== cuda libs  ===================================================
== cat /etc/issue ===============================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
VERSION="18.04.1 LTS (Bionic Beaver)"
VERSION_ID="18.04"
VERSION_CODENAME=bionic
== are we in docker =============================================
No
== compiler =====================================================
c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
== uname -a =====================================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
== check pips ===================================================
== check for virtualenv =========================================
False
== tensorflow import ============================================
tf.VERSION = 1.11.0
tf.GIT_VERSION = merge-180917-prev-912-g174d355
tf.COMPILER_VERSION = merge-180917-prev-912-g174d355
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
NVIDIA-SMI has failed because it couldn't communicate with the NVIDIA driver. Make sure that the latest NVIDIA driver is installed and running.
== cuda libs  ===================================================
== cat /etc/issue ===============================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
VERSION="18.04.1 LTS (Bionic Beaver)"
VERSION_ID="18.04"
VERSION_CODENAME=bionic
== are we in docker =============================================
No
== compiler =====================================================
c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
== uname -a =====================================================
Linux Ryzen1800X 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
== check pips ===================================================
== check for virtualenv =========================================
False
== tensorflow import ============================================
tf.VERSION = 1.11.0
tf.GIT_VERSION = merge-180917-prev-912-g174d355
tf.COMPILER_VERSION = merge-180917-prev-912-g174d355
Sanity check: array([1], dtype=int32)
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
NVIDIA-SMI has failed because it couldn't communicate with the NVIDIA driver. Make sure that the latest NVIDIA driver is installed and running.
== cuda libs  ===================================================
Describe the current behavior
The performance of CNN mode is very low and locks up the PC when using larger batch size. The jupyter notebook at (https://github.com/briansp2020/kaggle_quora/blob/master/kernel-cnn.ipynb) locks up my PC when using batch size of 256. Reducing the batch size to 16 allows it to run on my local machine but it takes 3+ hours.
Describe the expected behavior
The same code in Kaggle environment takes about 25 minutes per training epoch using batch size of 256.

I don't believe this is an issue with tensorflow-rocm. Is your GPU responsible for rendering your desktop environment? Does your desktop become completely unresponsive or just very slow to respond? Are you able to interrupt the Python kernel to regain responsiveness?

Is your GPU responsible for rendering your desktop environment?

Yes.

Does your desktop become completely unresponsive or just very slow to respond?

Completely unresponsive. I admit, though, that I only waited a few minutes before hitting a reset button to reboot the machine.

Are you able to interrupt the Python kernel to regain responsiveness?

No.
Ben,
Do you have access to VEGA FE? If you don't mind, could you try running the code on your setup and see if you can duplicate it? I got my VEGA FE from ebay. I've noticed some weird issues when using it under Windows. But since it worked OK so far under Linux, I just assumed that it was Windows driver problem. Do you think there maybe hardware problem?
BTW, do you work for AMD? I appreciate your help and guide.
Thanks!

I actually already ran your code on my Vega FE, and didn't have any issues. I don't use the Vega to render my desktop, however. (I recently switched from using a GTX 960 as my display driver to using my CPU's integrated graphics, specifically because I wanted to use the 960 for ML / compute purposes.)
One thing you might try: run the notebook and then try switching to TTY3 (CTRL + ALT + F3) and logging in to your user. If you're able to get there, you can try running rocm-smi or htop to see GPU or CPU usage, respectively, and kill the python process if you need to.
If you're unable to switch to TTY3, the last option would be to try a "soft reboot" by holding ALT + Print Screen while typing s, u, b. (Your computer should start rebooting once you press b.)
If your computer doesn't respond to anything, then perhaps this is an issue that should be considered by the dev team. I imagine some students / developers / researchers might only have access to their local GPU, and would like to train large networks without the system freezing...
Also, no, I don't work for AMD. I'm just particularly excited about this repository, and hope its community will keep growing. :+1:
P.S. Have you looked at this Keras tutorial? (Specifically the model at the bottom of the page.) It looks a lot like what you're working on. I'm not sure your current implementation is very efficient (i.e., Why Conv2D? Why such large convolution kernels?)


Fix clean test output

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[ ] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.
[ ] I've added or updated relevant unit tests.

Motivation and Context

Description
Still trying to get the test output to only display . or X in minified mode.
Remains

plenty of xcodebuild errors like this one

2023-11-24 19:18:08.713 xcodebuild[3270:11980] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore

Testing Steps

Ready for review
Almost all errors are hidden on CI. Remains one issue, but it comes from Security::InternetPassword.


Meeting 2019-04-22

Last weeks's news:

haproxy: released a small fix.

https://github.com/sous-chefs/java/pull/541 should be ready to release java cookbook 4.0

manually merge ancient PRs from https://github.com/sous-chefs/reprepro

Closed https://github.com/sous-chefs/chef-stunnel/pull/26 because it was for a feature that's been removed from stunnel.


added pt_br translation

Will take a look soon! Thank you!

I'm currently working on the next update for Nemo's Copper, will add it then


Fixed build failures

Updated CMSIS headers to v4.30.
Adding missing CM0+ and CM4 CMSIS headers.
Added missing include path for ./source to nrf51xxx, efm32gg, emf32ggxxxf1024, and template yaml files.
Corrected some bad #define macros in the MK20D5 register header.

With this patch, all targets build successfully. Note that there are still a couple warnings produced when building a few of the LPC targets, via a #warning directive.

Thanks @flit


Write a Python program to convert string to vowelcase

Description
Write a Python program to convert string to vowelcase
Vowelcase is a style of writing in which all vowels are converted to uppercase and all consonants are converted to lowercase.
Input  : "hello world"
Output : "hEllO wOrld"

How to contribute

Save the solution in program/convert-string-to-vowelcase.py file
Add convert-string-to-vowelcase.py file in convert-string-to-vowelcase folder

Is this still active ?  I like to contirbute to this issue

assign

Closes #9151
What's being changed:
Added PY file with the function of vowelCasePy

Closed:
#9151
What being changed:
Added a py file with vowelCasePy function


Button with ShadowStyle.Opaque is broken

Somewhere in the last few PRs (probably the event one), I broke the 3D effect of Button::

The only way to prevent code from breaking is to use colored assertions in unit tests. But you seem to avoid them.

This one could have been caught without a color test.
But, you're right I avoid the color tests because I find the api extremely confusing.

This one could have been caught without a color test.
But, you're right I avoid the color tests because I find the api extremely confusing.

Initially it seems very confusing but if you focus and remember that you just have to create an Attribute array with the colors that your test will use and create a string representing a rectangle with the respective array indexes of expected colors, it becomes much more easy.
Later, if there is a definitive change in the behavior of the colors in the respective test, then you will have to change it in the test to reflect these changes.
It's the only way to test the colors because the colors are not echoed to the console like when running normally.

It's the only way...

There is very rarely only one way to do something. Are you sure we couldn't engineer something different?

There is very rarely only one way to do something. Are you sure we couldn't engineer something different?

I don't think so. We can only map the colors to return another type of object, but we also need to make sure they are being output in the correct row and column, so the mapping should only return one character of length one or two for wide characters, for each color. You could just use the color and position return, which is what it actually does, and assert these values, but it would be much more difficult to check whether the values are completely in the correct values and positions. Therefore, a string that contains the characters that represent the colors in the correct positions is much more advantageous.
0 = Color0
1 = Color1
0000000000
0111111110
0000000000
We immediately obtain the information that Color1 is between positions (1,1) and (1,8).
But I'm curious if it's really possible to use another, more direct approach to testing colors in a more real and direct way.


RemainingRayCallRule with php 8.4

Describe the bug
When i run phpstan with php 8.4 with the rule RemainingRayCallRule, it breaks
Internal error: Call to undefined method PhpParser\Node\Expr\Variable::getParts() while analysing file
Versions
"spatie/ray": "^1.41",
PHP version: 8.4
Expected behavior
To not give errors
Desktop (please complete the following information):

OS: macOS
Version 14.4 (23E214)

Hey @striderxfossility try updating to the latest tagged version 1.41.4 this should resolve your issue.


Proposal: allow union type extension to help address the Expression Problem

In Clojure protocols are open for extension.  You can define new types that conform to an existing protocol.  This works because each type is defined independently rather than as part of a closed set as is the case with Elm's union types.
If my program defines a union type then I can extend it directly. If I want to use some popular third-party library for payment processing, however, and also support bitcoin I'd have to
type Payment = CreditCardPayment | PayPalPayment -- in third-party library
type ExtendedPayment = Payment | Bitcoin -- in my library

but I would prefer
extend type Payment = (..) | Bitcoin

Obviously, I would then have provide a similar extension to each of the functions that accept the type
show : Payment -> String
extend show pymt =
  case pymt of
    Bitcoin -> "One-million dollars!"

When you consider that someone else might come along and want to extend my library with yet another option you can see how wrapping and rewrapping union types can make it unnecessarily awkward to share and reuse code.
type ExtendedExtendedPayment = ExtendedPayment | StockOptions

While permitting extension makes the compiler's job more difficult, it doesn't break static type checking.  Rather it allows types that may belong to some union to be added in modular fashion similar to partial classes in C#.  Complex union types could be split across several files so that all of the logic for a particular union subtype could be neatly bundled together allowing each file to speak to a separate concern.
This design could also allow the hot reloading of union types.  Think dynamic plugins!  Developers love writing extensible products.  Take any of the popular text editors.  Many can load and apply plugins without having to restart the editor.  The same would be possible in Elm.
The problem with union types is that all of the participants in the set must be known at compile time.
type Plugin = ParanMatching | AutoComplete | Snippets -- what about those not yet written?

With extensible union types that set could remain open.
type Plugin = (..)

activate : Plugin -> Plugin
activate plugin = (..)

deactivate : Plugin -> Plugin
deactivate plugin = (..)

The set might start off as empty and at run time, per user configurations, be extended as the chosen modules (plugins, components, widgets) are loaded.  Each module, during its own packaging process, would have already been been statically checked for completeness keeping all of the compile-time benefits of Elm intact.

I think this would be more suited for the elm-dev mailing list.

OK.  The checklist didn't mention what to do with proposals so I wasn't sure and I did see other proposals reported this way.


WIP:  testes no warehouse

Codecov Report

Merging #26 (c747f3b) into main (4e56fcc) will increase coverage by 2.19%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   23.15%   25.35%   +2.19%
==========================================
  Files           8       10       +2
  Lines         652      777     +125
==========================================
+ Hits          151      197      +46
- Misses        495      574      +79
  Partials        6        6

Impacted Files
Coverage Δ

cmd/server/handlers/warehouses.go
0.00% <0.00%> (ø)

internal/product/repository.go
0.00% <0.00%> (ø)

internal/warehouse/repository.go
0.00% <0.00%> (ø)

internal/warehouse/service.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e56fcc...c747f3b. Read the comment docs.


fix: correctly update dynamic binding pathlist

Description
Fixes #7121
Fixes #6768
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Jest
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/dynamic-binding-pathlist-bug

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.91 (0.02)
36.59 (0.01)
33.63 (0.02)
55.44 (0.01)

:green_circle:
app/client/src/sagas/ActionSagas.ts
11.38 (0.47)
0.78 (0.09)
4.17 (0.47)
13.95 (0.66)

:red_circle:
app/client/src/utils/DynamicBindingUtils.ts
83.52 (-6.41)
69.52 (-14.02)
75 (-3.26)
82.69 (-5.86)

/ok-to-test sha=1775932


Create fibonacci.py

@krishiv8190 I'm closing the PR as it is not fulfilling the requirement...you can send a PR again after maintaining all the steps and eligibility criteria for a valid PR...


Scrape and cross-check JHU county-level data

Just got added: https://github.com/CSSEGISandData/COVID-19/blob/master/csse_covid_19_data/csse_covid_19_time_series/time_series_covid19_confirmed_US.csv

Wow, this is amazing, we can basically map their values to fips:${FIPS} and be done with it!

@hyperknot see the branch I started putting together to scrape it, you can work off of that to merge with FIPS codes.

OK, let's merge FIPS codes first and then base the branch on the new master.


load from UCR fix

Reference Issues/PRs
Fixes #1603
What does this implement/fix? Explain your changes.
A few minor fixes

corrects a bug in contracted rotation forest: this was only a problem with small contracts and should not effect testing.
casts the target variable to numpy strings rather than Series strings when loading the concatenated train and test using load_UCR_UEA_dataset (#1603). This is needed to fix the problem in STC with numba, and it is more consistent, since these are returned when either train or test is loaded
removes the deprecation warning is data.io. tbh there is a lot in here that could be improved, so I think a gradual move over, with duplication is preferable
change the default return_X_y in load_UCR_UEA_dataset to True. I think its a legacy of Weka conversion to append the target variable, This could conceivably break something somewhere, although I cannot think of a reason to do it and the variable can still be set to False so its a very edgy edge case.

Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
I think (4) is the most controversial?

Unless there are no plans to move any of the data_io functions in the next few months, it may be best to keep them deprecated?
If it's undecided whether they are going to be moved at all that's fine.
I support (4), but am aware that it may impact anyone using the current default as its public. I doubt it would be a significant fix for anyone who does so though.

Yeah good point, I'll put them back in


Invalid syntax highlighting inside string literals - it detects /* as a starting line for a comment

Copy-pasteable:
const init_env =`
    for i in \`ls ${process.env['LAMBDA_TASK_ROOT']}/bin/*\`; do
        echo $i
    done
`;

I guess this can then also be closed.

On Wed, Mar 29, 2017 at 4:07 PM, Charles E Campbell
<EMAIL_ADDRESS>wrote:

Simon Cornelius P. Umacob wrote:

examplejs
https://cloud.githubusercontent.com/assets/128593/24188811/b74f1c68-0f1d-11e7-856c-2c1f19b44564.png
Copy-pasteable:
|const init_env = for i in \ls
${process.env['LAMBDA_TASK_ROOT']}/bin/*`; do echo $i done `; |

Hello:
Some questions for you...

what language is this for?
I don't even see a /* in the example, so I don't see how that could
be affecting the highlighting

There is /\ at the end of the backtick-quoted text, but AFAICT it is
not within single- or double-quoted text. That /\ and everything
following it are highlighted in blue.

have you tried contacting the maintainer of the syntax highlighting
supporting whatever language you're using?  (look into the syntax
highlighting file, you'll likely find a "Maintainer" comment therein)

Regards,
Chip Campbell

Best regards,
Tony.


style: fix Bad Smells in org.assertj.core.internal.RealNumbers

Repairing Code Style Issues
Non-Protected-Constructor-in-Abstract-Class

A non-protected constructor in an abstract class is not needed because only subclasses can be instantiated
Changes:

Constructor org.assertj.core.internal.RealNumbers() is now protected instead of public

Constructor org.assertj.core.internal.RealNumbers(org.assertj.core.internal.ComparisonStrategy) is now protected instead of public

Check List:

Fixes #??? (ignore if not applicable)
Unit tests :  NA
Javadoc with a code example (on API only) : YES / NO / NA
PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.

Reading the failure message, I have to ask if this is a bug in your test code.
Expecting actual:
  23:59:30.415119537Z
to be strictly before:
  00:01:10.427289267Z

It seems like you compare two dates generated while running the CI and if the CI start short 0 UTC, the second date is generated after 0 UTC and the test fails?

Integrated. Thanks, @MartinWitt!


I can modify the recognized categories by modifying the calculator（TfLiteTensorsToDetectionsCalculator）

Due to hardware reasons, MediaPipe tracks too many objects at the same time causing the frame rate to drop, and it is hoped that the categories of recognition and tracking can be reduced by modifying it。
I wonder if it is possible to modify the value class of "object_detection_gpu.txt“: "TfLiteTensorsToDetectionsCalculator"，like ”num_classes“
node {
calculator: "TfLiteTensorsToDetectionsCalculator"
input_stream: "TENSORS_GPU:detection_tensors"
input_side_packet: "ANCHORS:anchors"
output_stream: "DETECTIONS:detections"
node_options: {
[type.googleapis.com/mediapipe.TfLiteTensorsToDetectionsCalculatorOptions] {
num_classes: 91
num_boxes: 2034
num_coords: 4
ignore_classes: 0
sigmoid_score: true
apply_exponential_on_box_size: true
x_scale: 10.0
y_scale: 10.0
h_scale: 5.0
w_scale: 5.0
min_score_thresh: 0.6
}
}
}

Hi @tisaud,
We are revisiting older issues. Please let us know if you still need assistance with this issue or if it is no longer required.
Thank you!!


[UI] Configurator feature + style enhancements

Signed-off-by: Gaurav Chadha<EMAIL_ADDRESS>Description

[x] Adds the "integer" as a "number" type text field
[x] Set the range of numbers from 0 to 100 max
[x]  Schema additional property type to string
[x] Single text field for #4938
[x] Removed extra unwanted space in the global RJSF fields and components
[x] Some style refinements to the configurator items

This PR fixes #4939
This PR fixes #4938
Notes for Reviewers
2nd issue is in progress, having some query will ask in meetings/slack
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4954 (f2fc21b) into master (5f7eb3f) will not change coverage.
The diff coverage is 72.46%.

@@           Coverage Diff           @@
##           master    #4954   +/-   ##
=======================================
  Coverage   32.45%   32.45%
=======================================
  Files          61       61
  Lines        5025     5025
=======================================
  Hits         1631     1631
  Misses       2990     2990
  Partials      404      404

Flag
Coverage Δ

e2etests
∅ <ø> (∅)

gointegrationtests
9.33% <5.79%> (ø)

integrationtests
?

unittests
25.87% <72.46%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/perf/apply.go
42.04% <68.42%> (ø)

mesheryctl/internal/cli/root/perf/profile.go
45.71% <73.07%> (ø)

mesheryctl/internal/cli/root/perf/result.go
68.90% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55d9a6...f2fc21b. Read the comment docs.

If you want to make changes to how the additionalProperties are displayed, you will have to use uiSchema to do that.

Let's discuss on the meshery dev. call @Chadha93

Let's discuss on the meshery dev. call @Chadha93

Sure

Marge conflict...

Update:

Added the the properties and ranges with the required fields of the schema
Wrapped additional properties to properties to use the custom Text field

Note: In future we need all separate custom components for each desired fields and properties for enhancements and use globally with RJSF
https://user-images.githubusercontent.com/65453826/151677555-d092bc7e-54db-476b-9133-3c6c2a87d9a7.mp4

@sudo-NithishKarthik updated the pr, ready for review : )

Since we already have field validation do we really need a specific range? If it's just going to be a text field we don't need it to say "<=100" right? @Abhishek-kumar09 what do you think?

Since we already have field validation do we really need a specific range? If it's just going to be a text field we don't need it to say "<=100" right? @Abhishek-kumar09 what do you think?

Context (if helpful): For certain inputs (e.g. percentages), it would be nice to display a slider.

@leecalcote so I think that can be added in @Abhishek-kumar09's PR itself. I think the Percentages have the data type "number" in the schema so instead of using the same widget for integers and numbers, we can just specify a separate widget for "number". CC @Abhishek-kumar09

@Chadha93 let's discuss updates on the meshery dev call.

@Chadha93 let's discuss updates on the meshery dev call.

sure, sounds good

@sudo-NithishKarthik @Abhishek-kumar09 are we good to go with this now?

Rest looks fine to me @Chadha93 👍
@Abhishek-kumar09 , any comments ?

@sudo-NithishKarthik you might want to update your review status on this PR.

@Chadha93 , this change would only reflect on Meshery application workload as u've directly edited its schema..

@sudo-NithishKarthik yes it's desirable because as we discussed that, setting range in UIschema component won't work here for now as it was modifying all the string fields, and as per RJSF docs it's the best approach to set the range properties in the schema itself(yes currently it's for Meshery apps schema) to prevent change in all components.

@sudo-NithishKarthik yes it's desirable because as we discussed that, setting range in UIschema component won't work here for now as it was modifying all the string fields, and as per RJSF docs it's the best approach to set the range properties in the schema itself(yes currently it's for Meshery apps schema) to prevent change in all components.

I was talking about the additionalProperties field

okay, yes it's also relevant for additional properties, it works for Apps schema for now.

Gents, why can't this be applied universally?

@Chadha93 , We should create a custom widget to render the additionalProperties field rather than modifying the schema. Modifying every single schema is not practical, even if we try to automate the process.

@Chadha93 , We should create a custom widget to render the additionalProperties field rather than modifying the schema. Modifying every single schema is not practical, even if we try to automate the process.

yes @sudo-NithishKarthik , having a separate new custom component for additional properties make sense, just to confirm is there an example in rjsf to get the deep fields for the additional properties? Because for properties we are currently simply using custom components.

Merge conflicts to address. Where are we at with this?

Merge conflicts to address. Where are we at with this?

The first issue is addressed here correctly, the second one is still pending a defined solution to add it globally in UISchema.

@leecalcote @sudo-NithishKarthik are we in a position to take these changes in this PR forward for now and then circle back asap when we get a ui-schema solution for this, as the first issue is addressed completely.

// @NikhilSharma03 Did you find any fixes for 2nd issue for UI schema RJSF condition?

Closing this as 1st is resolved via #5304


Add android as a supported platform

Adding these lines will make the packaged android version work as well.

Sorry for long reply, good work, thx!


Use the interface of compilation.preparedChunks also for compilation.entries

Use the interface of compilation.preparedChunks also for compilation.entries to allow plugins and loaders to get the entry name before a chunk is added to preparedChunks
Hi,
this pull request allows plugins and loaders to check if a NormalModule is an entry point of this compilation and get that entry points name before it is added to preparedChunks.
this.entries.push({
  name: name,
  module: module
});

This IS an API change - however all tests pass* and I couldn't find any place which is using compilation.entries. Third party code might use this information however the migration path is a simple map function: compilation.entries.map(function(entry){return entry.module}});.
* the i18n module is broken but this was also the case before changing the code
The interface is the same as compilation.preparedChunks:
https://github.com/webpack/webpack/blob/3201dc333d8863ff752d6ab9f62d9d6bb752106a/lib/Compilation.js#L431-L434
this.preparedChunks.push({
  name: name,
  module: module
});

Please let me know what you think

It would also be possible to add the entry object as well:
this.entries.push(entry);

This might be an even smarter approach as entry has all information and there is no other way to access the SingleEntryDependency information from a plugin or loader.

entry.name contains the name of the entry point
entry.module contains the module

https://github.com/webpack/webpack/blob/master/lib/SingleEntryPlugin.js#L8-L10

This is essentially required to address webpack/less-loader/#69.

old


Could not pass event PlayerInteractEvent

Could not pass event PlayerInteractEvent to Multiverse-Portals v3.0.0-SNAPSHOT-b788
org.bukkit.event.EventException: null
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:309) ~[spigot.jar:git-Spigot-518
206a-a5b9c7b]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-51820
6a-a5b9c7b]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:500) ~[spigot.jar:git-Spigot-51
8206a-a5b9c7b]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:485) ~[spigot.jar:git-Spigot-51
8206a-a5b9c7b]
        at org.bukkit.craftbukkit.v1_13_R2.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:2
99) ~[spigot.jar:git-Spigot-518206a-a5b9c7b]
        at org.bukkit.craftbukkit.v1_13_R2.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:2
66) ~[spigot.jar:git-Spigot-518206a-a5b9c7b]
        at net.minecraft.server.v1_13_R2.PlayerInteractManager.a(PlayerInteractManager.java:110) ~[spigot.jar:git-S
pigot-518206a-a5b9c7b]
        at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1162) ~[spigot.jar:git-Spigot-518
206a-a5b9c7b]
        at net.minecraft.server.v1_13_R2.PacketPlayInBlockDig.a(SourceFile:40) ~[spigot.jar:git-Spigot-518206a-a5b9
c7b]
        at net.minecraft.server.v1_13_R2.PacketPlayInBlockDig.a(SourceFile:10) ~[spigot.jar:git-Spigot-518206a-a5b9
c7b]
        at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.a(SourceFile:10) ~[spigot.jar:git-Spigot-518206a-a5b
9c7b]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_201]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_201]
        at net.minecraft.server.v1_13_R2.SystemUtils.a(SourceFile:199) [spigot.jar:git-Spigot-518206a-a5b9c7b]
        at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:895) [spigot.jar:git-Spigot-518206a
-a5b9c7b]
        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:417) [spigot.jar:git-Spigot-518206a
-a5b9c7b]
        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:830) [spigot.jar:git-Spigot-518206a
-a5b9c7b]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:728) [spigot.jar:git-Spigot-51820
6a-a5b9c7b]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_201]
Caused by: java.lang.NullPointerException
        at com.onarandombox.MultiversePortals.listeners.MVPPlayerListener.playerInteract(MVPPlayerListener.java:168
) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_201]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[spigot.jar:git-Spigot-518
206a-a5b9c7b]
        ... 18 more

Same issue, all the time.

Think I found a temp solution, what version of spigot are you running?

Basically instead of using the latest dev build, just go on bukkit Multiverse-core or SpigotMC, and download the correct multiverse-core for your version.

I confirm I have this issue too.

As mentioned, make sure your MV-Core and MV-Portals versions are matching. Also, please open this ticket on the correct issue tracker if you continue to have this problem.

Gonna be like 3:22 when I get out
Sent from my iPad
On Apr 15, 2019, at 1:41 PM, Jeremy Wood<EMAIL_ADDRESS>wrote:
Closed #1980 https://github.com/Multiverse/Multiverse-Core/issues/1980.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Multiverse/Multiverse-Core/issues/1980#event-2277522434,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATHyACl6DoterXi3ITPlDgjA3toiMSqSks5vhMftgaJpZM4cAr6T
.

Happened to me though I don't have MV-Portals

I've got the same issue. 2020 is now, Still no solutions, guys?

Up ?

Same problem it spams console almost every time someone says something


Codespace debanshu005 expert fortnight r44pr9wjqgfx74p

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

This looks like an accidental PR since the only changes are customizations for your personal use case, so I'm closing this.


Investigate why a PR didn't trigger GitHub Actions

https://github.com/booyaa/wifiscanner/pull/27
The only thing I can see is that that the PR author committed their changes directly to the master branch on their fork.

Quick fix: https://github.com/booyaa/wifiscanner/commit/2cdf3ef2df58061eb9d619d6272bbedebb0b35df


Modifying existing descriptor sets with DescriptorWrite and DescriptorCopy?

Hello guys,
Is it possible to modify existing descriptor set (e.g. bind another buffer instead of previously used) in Vulkano?
E.g. when user has a complicated computational shader with a dozen of bound buffers and images, and only a couple of resource bindings should be changed from one dispatch to another, creating a completely new descriptor set looks like a waste of memory and time.
In a raw Vulkan (via C++) I was able to do it by constructing VkWriteDescriptorSet and VkCopyDescriptorSet objects and then passing them to vkUpdateDescriptorSets() call.
As I can see in Vulkano sources, here is a DescriptorWrite structure that can be useful here, but it is only used implicitly when creating PersistentDescriptorSet and FixedSizeDescriptorSet without any possibility to modify them in future.
In terms of Vulkano's design how this issue should be solved?
Modifying DescriptorSet trait' interface to provide a mutable access to UnsafeDescriptorSet inside that does not look like a good solution. Also what to do with copying descriptors between descriptor sets?

Seems to be useless in terms of current Vulkano state.