Improve error message

Just a little bit more info about the threshold difference.

Thanks for the PR, @bodeamariuscosmin. Would you be up for adding a test for this?

I am happy to help Michael!
I do not think it is needed to have a test for failure. It will be
displayed if there will be any failed test. Only if you strongly insist to
have the test added, I will do. Else, this can be merged!
Best regards,
Marius
În joi, 2 apr. 2020 la 16:44, Michael Herman<EMAIL_ADDRESS>a
scris:

Thanks for the PR, @bodeamariuscosmin
https://github.com/bodeamariuscosmin. Would you be up for adding a test
for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mjhea0/cypress-visual-regression/pull/31#issuecomment-607855791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQP7PQZ3AO74WVIHGE2QW3RKSJENANCNFSM4LXP456Q
.

--
MariusB

I am happy to help @mjhea0 !
I do not think it is needed to have a test for failure. It will be displayed if there will be any failed test. Only if you strongly insist to have the test added, I will do. Else, this can be merged!
Best regards,
Marius

I've been wanting to add some jest tests. This is an excuse to get them added sooner rather than later. Want to help?

I have wrote some jest test before, but was not a cypress but a puppeteer
framework. I will write the negative test for this PR.
If there are anything else I can do let me know!
I would also like to be able to select a different source for base and
actual images. Sometimes the base lines may be stored in aws or a directory
outside of project. What do you think?
În sâm., 4 apr. 2020 la 23:16, Michael Herman<EMAIL_ADDRESS>a
scris:

I've been wanting to add some jest tests. This is an excuse to get them
added sooner rather than later. Want to help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mjhea0/cypress-visual-regression/pull/31#issuecomment-609083471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQP7PWQP66UWNYBT3G4VJTRK6ITTANCNFSM4LXP456Q
.

--
MariusB

I have wrote some jest test before, but was not a cypress but a puppeteer
framework. I will write the negative test for this PR.

Are you setting up Jest for this? Do you need help?

I would also like to be able to select a different source for base and
actual images. Sometimes the base lines may be stored in aws or a directory
outside of project. What do you think?

Good idea. Want to open a separate PR?

@mjhea0 let me try to make a workaround for the second idea and leave jest for somebody else.

@mjhea0 can we close this before I start other PRs? Thank you!


Borrowed Cow<'_, [u8]> fails if raw bytes not valid utf8

I thought I was going crazy for a while, so I might still be, but this seems to be a bug in bincode or serde?
This code:
extern crate bincode;
extern crate serde;
#[macro_use]
extern crate serde_derive;

use std::borrow::Cow;

#[derive(Debug, Serialize, Deserialize)]
pub struct X<'a> {
    #[serde(borrow)]
    pub field: Cow<'a, [u8]>,
}

fn main() {
    let original = X { field: [255, 255, 255, 255][..].into() };

    let ser = bincode::serialize(&original).expect("expected serialization to succeed");
    let _: X = bincode::deserialize(&ser).expect("expected same encoded bytes to decode");

}

fails with:
thread 'main' panicked at 'expected same encoded bytes to decode: InvalidUtf8Encoding(Utf8Error { valid_up_to: 0, error_len: Some(1) })', libcore/result.rs:945:5

I'm not serializing or deserializing any strings, so I am assuming this is a bug. If it's not, could there be another way to fix this?
It does work correctly (accepting invalid UTF8 bytes) if I use either Vec<u8> or &'a [u8].
Thanks!

This is super weird.  I can't find any code in bincode or serde that would do this.
CC @dtolnay

Could be https://github.com/serde-rs/serde/blob/master/serde/src/private/de.rs#L191?
I'll try changing that and see if it fixes anything.

Yes I had just found the same thing. That does fix it. Want to send a PR?

Sure, will do.


If capabilities are explicitly added then also add them to the ambient set.

This change makes it so that we add capabilities to the ambient set if they are explicitly added. So in kubernetes if we add a capability to the container securityContext then that capability will be added to the ambient set in addition to the inheritable, effective, permitted and bounding sets. This will allow users to run a container as non-root while giving it just the capabilities it needs, without having to apply file capabilities and allowing privilege escalation.
If ALL capabilities are added then we don't add ALL capabilities to the ambient set because that would make a non-root user essentially root. We also don't add the defaultUnixCaps i.e. the default capabilities that are always added to inheritable, effective, permitted and bounded sets to the ambient capability set as that will also make non-root user as power full as root.

/cc @qiutongs

/cc @tallclair

/cc @mikebrow

Adding @mikebrow - this is RE: https://github.com/kubernetes/enhancements/pull/2757

/ok-to-test
Tagged this as "impact/changelog" as this does change the behavior for non-Kubernetes users of the containerd client library who are setting capabilities.

So in kubernetes if we add a capability to the container securityContext then that capability will be added to the ambient set in addition to the inheritable, effective, permitted and bounding sets.

I remember that the reason we want a K8s/CRI api change for the ambient set, is to make the api backward compatible, and avoid underlying behavior change.
Assuming users already have a pod adding some capabilities for a non-root pod by mistake, this would change the behavior for them unexpectedly?

Assuming users already have a pod adding some capabilities for a non-root pod by mistake, this would change the behavior for them unexpectedly?

Wouldn't it make the behavior what the user expected to happen? An in a user would assume adding a capability to the securityContext of the container should add the capability in a form that it is usable.

Wouldn't it make the behavior what the user expected to happen?

The problem is that we don't know whether users do it intentionally or by mistake. The behavior has been there for so long, that we may not be able to treat it as a bug fix. :/

gut says a feature gate in k8s and a new bool/mask over CRI to /f ambient..

See https://github.com/containerd/containerd/blob/main/pkg/cri/server/container_create_linux.go#L238

Woops! haha I forgot to update that. Good catch!

Closing due to inactivity, feel free to re-open the pull request anytime if you continue working on this.


add border-radius to buttons

I added some border-radius to the buttons in the CSS so that the button looks UI friendly.
The border-radius has been set to 50px.

@googlebot I signed it!


The site functionality should be unavailable on days that Hacktoberfest is not running (for 11 months of the year)

Feature Request
Describe the solution you'd like
Display a different markdown driven content page when the event is closed.
Additional context
Perhaps a 3rd page should be displayed in the month leading up to October.

Can I try to do this? or are you managing yourself doing it?

I was going to do this one :)

oh ok 👍


Issue with k8s.io/docs/tutorials/stateful-application/basic-stateful-set/

replace kubectl error message with the related output
Fixes #15507

/lgtm
/approve

Don't full fix:
Remove this sentence:

Ignore the error. It only indicates that an attempt was made to create the nginx

Because now we don't get error.


Using SetFit for regression tasks?

I was curious about using SetFit for ordinal Likert scale outcomes (ie IMDB movie reviews). It doesn't seem like an obvious option in the SetFit API. Has anyone tried using SetFit for regression tasks?

Can you provide some more details about what you're trying to do I might be able to help : ).  If you have ordinal data you could treat it like a multiclass problem and setfit should 🤞 just work for that problem.  I haven't tried this but taking a look it appears you can set the head of the setfit model to be whatever you want so you could do something like:
`
from sentence_transformers.losses import CosineSimilarityLoss
from setfit import SetFitModel, SetFitTrainer
from sklearn.linear_model import LinearRegression
from sentence_transformers import SentenceTransformer
Choose a sentence transformer for your embedding
model_body = SentenceTransformer("sentence-transformers/paraphrase-mpnet-base-v2")
Choose whatever head you want for regression
model_head = LinearRegression()
Load a SetFit model from Hub
model = SetFitModel(model_body=model_body, model_head=model_head)
Create trainer
trainer = SetFitTrainer(
model=model,
train_dataset=train_dataset,
eval_dataset=eval_dataset,
loss_class=CosineSimilarityLoss,
metric="accuracy",
batch_size=16,
num_iterations=20, # The number of text pairs to generate for contrastive learning
num_epochs=1, # The number of epochs to use for constrastive learning
column_mapping={"sentence": "text", "label": "label"} # Map dataset columns to text/label expected by trainer
)
Train and evaluate
trainer.train()
`
I haven't tried it but I suspect instead of using the default LogisticRegression model head you could replace it with any other reasonable estimator from sklearn.  Let me know if you want additional help I'd be happy to take a look if you provide some example input and output data you're struggling with.

The ability to add a different head would be a nice addition to the documentation actually

I can open a PR if folks want with examples.

My work (sorry can't share data) involves looking at mental health patient audio journals (vastly longer than 512 tokens) that have some self report emotional rating scale attached to them "How sad were you today (rate from 1-5 with 1 being not at all to 5 being extremely sad)?" Generally stuff like that - our biggest hurdle is that we have long texts/transcripts and also small sample size, so I've been trying to think about how we can use something like SetFit in our lab.
My apologies for the late reply!

But @nbertagnolli SetFit model, associates /pair the instances sharing same label (0 or 1) to augment the set size, which underlies contrastive learning. For the regression problem, we pass numeric values instead of 0/1 labels. How do you expect the models associates/pairs the instances!


[Task]: fix MqttIO flaky test

What needs to happen?
The recently added MqttIO testReadWithMetadata test is flaky.
here is related context
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[X] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Infrastructure
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take-issue


WIP: CI: use gnome image

This can't work as we can't install new things inside the image :/ Will figure out something else using the current image we have.

Can't we use it as a base image and install other things on top of it?


Xamarin Audio - I don't understand a word.

All I want to do is generate an Audio Tone when an event occurs, but where ever I go to get information on this I get hit with GOBLY GOSH, explanations that are in an over the top language that I have no idea on what is being said.
I can follow all the other subjects in this tutorial except AUDIO.
AudioGraphs and AudioFrames - no idea on what is described.
What about    tone(1000); equals an output tone of 1000Hz.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 589e2eda-b495-126e-553d-65ebee87bd3c
Version Independent ID: a850ef9a-9d08-64a2-dd6b-584d2059f392
Content: Audio graphs - UWP applications
Content Source: windows-apps-src/audio-video-camera/audio-graphs.md
Product: uwp
Technology: audio-video-and-camera
GitHub Login: @drewbatgit
Microsoft Alias: drewbat

Hello, the AudioGraph APIs are intended for more sophisticated audio processing applications. If you just want to play a sound when an event occurs, I recommend just using MediaPlayer. It requires your tone to be in an audio file, but you can play a sound back with just a few lines of code. For more information, see Play audio and video with MediaPlayer.

Thankyou drewbatgit the Play audio and video with MediaPlayer is just what I needed. Thanks again.


Liquidsoap for Icecast AutoDJ doesn't work

Hello.
There is an IceCast server. It works correct.
I want to configure AutoDJ on the Linux server to play tracks from the / Home / Music folder.
So, I tried Liquidsoap. But it doesn't work.
So what did I do?
I have Debian 10.9.0.
apt install icecast2
In the .xml file I created MountPoints:

/autodj
test123
500
3600
/tmp/dump-live.mp3

ISO8859-1
1
TestRadio
It's TestRadio!
http://ip:8000/autodj.mp3.m3u
Other
128
application/mp3
mp3
65536
4096

/live
test123
500
3600
/tmp/dump-live.mp3

/autodj
1
1
ISO8859-1
1
TestRadio
It's TestRadio!
http://ip:8000/live.mp3.m3u
Other
128
application/mp3
mp3
65536
4096

I used different ways to install Liquidsoap. With apt install Liquidsoap, opam and deb package.
It didn't run, so I used the template:
https://github.com/Renaud11232/icecast-autodj
git clone https://github.com/Renaud11232/icecast-autodj.git
cd icecast-autodj
mkdir -p /etc/liquidsoap
cp configs/dj.liq /etc/liquidsoap
chown -R icecast2:icecast /etc/liquidsoap
chmod 660 /etc/liquidsoap/dj.liq
cp systemd/liquidsoap.service /etc/systemd/system/
systemctl daemon-reload
systemctl enable icecast2
systemctl enable liquidsoap
systemctl start icecast2
systemctl start liquidsoap
dj.liq:
#!/usr/bin/liquidsoap -d
#set("init.daemon",true)
#set("init.daemon.pidfile",false)
set("log.file",false)
#set("log.file.path","/var/log/liquidsoap/basic.log")
#set("log.stdout",true)
#set("log.level",4)
set("decoder.file_decoders",["META","MAD","OGG"])
set("decoder.file_extensions.mad",["mp3","mp2","mp1"])
set("decoder.file_extensions.ogg",["ogv","oga","ogx","ogg","opus"])
set("decoder.mime_types.ogg",["application/ogg","application/x-ogg","audio/x-ogg","audio/ogg","video/ogg"])
set("decoder.mime_types.mp3",["audio/mpeg","audio/MPA"])
def update_title(m) =
title = m["title"]
if title == "" or title == "Unknown" then
content = m["filename"]
content = basename(content)
content = get_process_output("STR=""^content^""; echo ${STR%.*}")
content = string.recode(out_enc="UTF-8", content)
[("title", content)]
else
sArtist = string.recode(out_enc="UTF-8", m["artist"])
sTitle = string.recode(out_enc="UTF-8", m["title"])
[("title", sTitle),
("artist", sArtist)]
end
end
set("tag.encodings",["UTF-8"])
music = nrj(playlist(mode='randomize', reload_mode='rounds=1', '/home/music'))
mount = "autodj",
encoding = "ISO-8859-1",
default,
host = "ip", port = 8000, password = "test123",
genre="other",
name="TestRadio",
fallible = true,
icy_metadata="true",
public=true,
url="http://ip",
description="It's TestRadio!")
But, after executing systemctl start, I open http://ip:8000/autodj, and it doesn't work.
What's wrong? Please help me!
Thank you in advance!

Closing due to inactivity


fix: ads banners permission name

Coverage increased (+0.0%) to 72.47% when pulling 548738c71cd1a72c85bd26b251cbbc0650dd6420 on itowtips:fix-ads-banner into 29b6a9ffd5affd50b8b96d0efcc527e7c3e09fe8 on shirasagi:master.


Making Badger skill field a string instead of a list

Pre-flight checklist

[x] Unit tests
[x] GraphiQL tested
[ ] Client app tested
[x] Gif added


Add a lenient flag in constructors for blaze-client

This just adds some constructors and convenience functions for https://github.com/http4s/blaze/pull/32

Blocked by http4s/blaze#32 and/or http4s/blaze#36, but not forgotten.

Now that https://github.com/http4s/blaze/pull/36 is merged, is this good enough? :)

I believe this needs a blaze release to work, which I believe can happen pretty soon.
Another concern: do we need a default lenient client? The same could be asked for the non-lenient client. At a minimum I think they should be lazy.

@clayrat, feel free to bump the blaze dependency to 0.12.0-SNAPSHOT: I don't think we'll do a blaze release until something bigger happens or http4s is going to do a minor release.

#542 added this.


Ruby 3.2 compatibility for Capistrano 2

In Ruby 3.2 the method "=~" has been removed from Object. Make sure receiver is a Regexp to avoid errors.

Thanks for this PR and sorry for the delayed response.
I am not sure this project can accept PRs for the legacy 2.x branch at this point. It has been 10 years since Capistrano 3 was released and 7 years since there was any commit activity on 2.x.
@leehambley do you have a recommendation?
FWIW I cannot even get the tests to run for 2.x. 😅

I am not sure this project can accept PRs for the legacy 2.x branch at this point. It has been 10 years since Capistrano 3 was released and 7 years since there was any commit activity on 2.x.

We're still using it in production, so it would be great to merge this PR as it would remove the need to use a custom fork. But I understand it's old stuff 😅.

legacy-v2 test suite fixed by #2127

@intrip would you mind rebasing this PR on top of the chores/2.x-test-suite branch? I'd like to see if the tests all pass locally on 3.2.

@mattbrictson rebased now

@intrip I found one more place where =~ is leading to a test failure on this branch. Could you also include this fix in this PR?
--- lib/capistrano/configuration/actions/invocation.rb
+++ lib/capistrano/configuration/actions/invocation.rb
@@ -248,7 +248,7 @@ module Capistrano
           prompt_host = nil

           Proc.new do |ch, stream, out|
-            if out =~ /^Sorry, try again/
+            if out.to_s =~ /^Sorry, try again/
               if prompt_host.nil? || prompt_host == ch[:server]
                 prompt_host = ch[:server]
                 logger.important out, "#{stream} :: #{ch[:server]}"
@@ -256,7 +256,7 @@ module Capistrano
               end
             end

-            if out =~ /^#{Regexp.escape(sudo_prompt)}/
+            if out.to_s =~ /^#{Regexp.escape(sudo_prompt)}/
               ch.send_data "#{self[:password]}\n"
             elsif fallback
               fallback.call(ch, stream, out)

You should be able to run the test suite locally to confirm things are working (ignore the warnings):
$ bundle install
$ bundle exec rake

The output should end with something like:
Finished in 0.380973 seconds.
--------------------------------------------------------------------------------------------
619 tests, 1536 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
--------------------------------------------------------------------------------------------

@intrip merged!
One last request: Please try using the legacy-v2 branch in your project and confirm everything is working. After that I'll push a 2.15.10 release to rubygems.

@mattbrictson can confirm that everything works well. Thank you for the help 🙌!

@intrip released: https://rubygems.org/gems/capistrano/versions/2.15.10


Support for multiple composition layers, additional composition layer types

Needed for nice display of UI panels/quads, skyboxes, etc.
Prototype in composition-layers branch, this will need a rework to the viewer setup, swapchain creation, etc,

Quads implemented - Skybox and similar need additional composition layers, as optional extensions

KHREquirect and KHREquirect2 (extension) layers now present.
Displaying any RenderGraph on a composition layer also now possible - Need to demo a RenderGraph for a simple image copy or similar.
Imgui worked for proof of concept, in vsgimgui-prototype branch -> Will need to make vsgimgui a bit more flexible for the display side there, and add some helpers for mapping intersections to mouse input etc.


Some Repo Stuff

Since the plugin is now called IETVNOW, Rename the repo to IETVNOW.
Add the Summary from the Addons.xml to the Repo Description.
:+1:

Hi, I'll take all of those comments on board :)


Updated the documentation

Description

Added the favicons
Added some graphic images to make the whole generated website look nicer
Added the pages regarding the local and public testnets
Added the page for the installation
Updated the README.md

Checklist

[x] Targeted PR against correct branch.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote tests.
[ ] Added an entry to the CHANGELOG.md file.
[x] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    77.4%   77.4%
======================================
  Files          18      18
  Lines         832     832
======================================
  Hits          644     644
  Misses        174     174
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df3833...29ba1f7. Read the comment docs.

Add a disclaimer that this is not related to Desmos Graphing Calculator


Add license to userscript headers

The template is missing license field that is required by many userscript storage services. Let it be there now

Sorry, due to my mistake, this PR merge was lost. I will make this modification again on the new commit. I will still use the changes of your PR, please see here for details.


v9 compatibility?

Describe the bug
Toggling a lighting effect from EQUIPMENT does nothing. The player illumination does not change.
To Reproduce

Select Token
Select hand icon
Select EQUIPMENT
Select Torch to toggle effect

Expected behavior
The player should be illuminated per the item toggled
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Have reduced all modules enable to only DFREDS Convenient Effects

Known issue, see #93.


Fixes for xmtowav example

Writes the data chunk size in the correct spot, and specifies to open the output file as binary (so it works on Windows systems).
I also have two other branches, one with a few modifications for building on Windows with MSVC and another that adds support for generating 16-bit PCM samples. Let me know if you're interested in merging either of these.

I also have two other branches, one with a few modifications for building on Windows with MSVC and another that adds support for generating 16-bit PCM samples. Let me know if you're interested in merging either of these.

Sure! Although I will not be able to maintain (or even test) the MSVC stuff. I thought CMake could generate a VS project for Windows?


Polycode::Mesh constants cause linker errors when used

I can put this line of code in my program and it builds successfully:
ScreenMesh *s = new ScreenMesh(Mesh::TRIFAN_MESH);

This line of code also builds:
ScreenMesh *s = (triangle ? new ScreenMesh(Mesh::TRI_MESH) : new ScreenMesh(Mesh::TRIFAN_MESH));

This line of code however causes a failure at the link stage:
ScreenMesh *s = new ScreenMesh(triangle ? Mesh::TRI_MESH : Mesh::TRIFAN_MESH);

The linker error:
"Polycode::Mesh::TRIFAN_MESH", referenced from:
      svgloader::loadXml(TiXmlElement*, svgtransform const&) in svgloader.o
  "Polycode::Mesh::TRI_MESH", referenced from:
      svgloader::loadXml(TiXmlElement*, svgtransform const&) in svgloader.o
ld: symbol(s) not found
collect2: ld returned 1 exit status[/code]

I am compiling with XCode 3 on Snow Leopard.
I notice PolyMesh.h defines a bunch of static consts in the class definition in the header file. Is that altogether legal? Average Software on TIG http://forums.tigsource.com/index.php?topic=1733.msg659828#msg659828 claims:
"It's legal, but if you do anything which requires the constant to actually exist in memory, rather than just be substituted as a compile time constant, the constant must be also defined in a source file somewhere.  This is a bug in the library."
I don't know if this is actually something Polycode is doing wrong or just a quirk of my compiler, but if there exist compilers that will treat the code like this, maybe it should not be done this way.
I think there are other source files where this same constant-defined-in-header idiom is used also.

PolyPhysicsScreenEntity.h (ENTITY_RECT etc) appears to also have this issue


Invalid hook call. Hooks can only be called inside of the body of a function component.

I am using the reactjs plugin with react hooks, first of all the documentation on making use of such plugin with functional components (react hooks) is very poor, secondly when I try to use any of the hooks that this package provides, like for example: useAppInsightsContext() by using it as follows:
import { useAppInsightsContext } from '@microsoft/applicationinsights-react-js';

function BaseLayout(props) {

    const reactPlugin = useAppInsightsContext();

    return (
    );
}

export default BaseLayout;

I get the following error: Invalid hook call. Hooks can only be called inside of the body of a function component. If I copy the code of such hooks in my project then I can use them just fine.
Anyone has encountered such issue please?
Maybe @aaronpowell can you help please?
Steps to Reproduce

Install the reactjs plugin
Import a hook
Make use of it

Expected behavior
I should be able to make use of the imported hook

Are you able to provide a sample repo with the error you're experiencing, I haven't been able to reproduce it.
Have you set up the AppInsights connection as per https://docs.microsoft.com/en-us/azure/azure-monitor/app/javascript-react-plugin#basic-usage first?
Here's a basic implementation using React context: https://codesandbox.io/s/intelligent-drake-r1cvz?file=/src/AppInsights.js

Can you compare your approach with the documented approach - https://docs.microsoft.com/en-us/azure/azure-monitor/app/javascript-react-plugin#using-react-hooks


Crash with API samples on minimizing the window

All but two API samples (hello_triangle and hpp_hello_triangle) are crashing on minimizing the window.

Hi @asuessenbach, I just tested this bug locally and didn't get a crash.  Which OS are you on and which sample is giving a crash?  I'm testing in Ubuntu so am guessing this bug happens in windows?  I tested the instancing sample will test a few others.

As said, I get the crash with all but two samples. And you're guessing right, it's on Win10.
First, the validation layer fires on vkCreateSwapchainKHR in swapchain.cpp, line 419:
Validation Error: [ VUID-VkSwapchainCreateInfoKHR-imageExtent-01689 ] Object 0: handle = 0x17332c7e680, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x13140d69 | vkCreateSwapchainKHR(): pCreateInfo->imageExtent = (0, 0) which is illegal. The Vulkan spec states: imageExtent members width and height must both be non-zero (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkSwapchainCreateInfoKHR-imageExtent-01689)
Then it throws a runtime_error in find_image_type (core/image.cpp).

I can reproduce this. To avoid this in my samples, I don't resize or update if the window is minimized. I think we need to add that to our framework too.


Logo Design

Added my submission for the logo design issue!

@deeptea22  this is nice actually, can you give us a version without books at the bottom and founded section ? and it will be  founded 2019. thank you

@Swarnimashukla Thank you! Sure i have added the new logo design with the requested changes in Pull request #79


test(client): simplify and standardize the test code about dataset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.715%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5557

Relevant Lines:
6638

💛  - Coveralls


Add missing links to Quickstart

Added links that were missing in the quickstart.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@strickvl is there a possibility we merge this after the merge of the model registry?

@strickvl is there a possibility we merge this after the merge of the model registry?

👍


Cancellable operations

To wait for the incoming request is cancellable, but the execution of the parameter delegate is not.
Also the outgoing requests return delegate is not cancellable.
The outgoing request is awaited by the scope without cancellation, this is a third place for an optional cancellable Task.

Orleans has cancellation support: https://github.com/dotnet/orleans/issues/1516


Styles at the bottom

You’re linking to your CSS at the bottom of your document, which is a pretty big performance no-no (delayed CSSOM construction and FOUC).
I’m not sure if there’s a reason for doing this (there doesn’t appear to be a JS dependency or similar), but if not then I would move them to as close to the top of your HTML as possible :)

Thanks for the audit, PR very welcome!


supper kerberos

I rewrite TSaslTransport for kerberos of GSSAPI by github.com/jcmturner/gokrb5 for my project
but I not sure Should I to comit ,because is different OPTION

I rewrite TSaslTransport for kerberos of GSSAPI by github.com/jcmturner/gokrb5 for my project but I not sure Should I to comit ,because is different OPTION

Hi
I also encountered some problems related kerberos
could you share your codes about this?
thank you very much

Hi
could you share your codes about this?
thank you very much

Hi
could you share your codes about this?
thank you very much

Hi
could you share your codes about this?
thank you very much

I rewrite TSaslTransport for kerberos of GSSAPI by github.com/jcmturner/gokrb5 for my project but I not sure Should I to comit ,because is different OPTION

Hi I also encountered some problems related kerberos could you share your codes about this? thank you very much

Hi
could you share your codes about this?
thank you very much

I rewrite TSaslTransport for kerberos of GSSAPI by github.com/jcmturner/gokrb5 for my project but I not sure Should I to comit ,because is different OPTION
Hi
could you share your codes about this?
thank you very much


Saying "no" to enabling MacAddressSpoofing still enables it

"Mac address spoofing isn't enabled, nested guests won't have network!"
"Would you like to enable? (Y/N)"
N
... still enables MacAddressSpoofing

@mebersol for heads up

Ping @theodthompson @mebersol.
Re-sending issues as people get back from the holidays.

@theodthompson I think a fix was merged in, correct?


Update handlers_general.go

print max and min shard uptimes in seconds rather than ns
idk what im doing i prob broke this

yeahhh thats not gonna work

didnt think so lmfao


Update Netatmo, add webhook support

Description:
This PR updates the netatmo dependency (pyatmo) to version 1.8. I actually don't know what else has been changed, but I added helper methods to allow support for using webhooks for cameras. This webhook support is also what I have added in the component.
In its current form the webhook support only fires events on the bus like such:
Movement:
DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event netatmo_webhook_received[L]: home_name=myhome, event_type=movement, webhook_id=mysupersecretwebhookid, camera_id=00:11:22:33:44:55>

Person:
DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event netatmo_webhook_received[L]: home_name=myhome, message=John seen, event_type=person, id=aaaaaaaa-bbbb-1111-a1a1a1-abcdef123456, webhook_id=mysupersecretwebhookid, name=John, camera_id=00:11:22:33:44:55, is_known=True>

I chose not to interact with the sensors this component (optionally) generates because there are no off-events for when motion stops or a person hat not been seen for a while. Besides that we also need periodic updates for the required refresh token to be refreshed (pyatmo does that on every update).
I have tested this with a Netatmo Welcome camera, and the existing functionality has not been broken. I also have the weather station with it's various sensors, and they seem to keep working like before as well. For other device types I can't make any statements. If anything breaks, that's due to changes in pyatmo I'm not aware of. But I doubt that there will be any trouble.
I'll take care of the documentation as soon as this PR generally gets accepted.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
netatmo:
  api_key: YOUR_CLIENT_ID
  secret_key: YOUR_CLIENT_SECRET
  username: YOUR_USERNAME
  password: YOUR_PASSWORD
  webhook_url: https://hass.example.com/api/webhook/mysupersecretwebhookid

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

I'll probably also change the types of events that are being fired. They should be different depending on what type of event actually happened in my opinion because that also affects what data is available.

This will only support the Welcome camera event types, Presence will send event types of movement, human, vehicle, and animal.
Let me know if it will be helpful to provide the body to any of those, I can certainly do that.

Sure, that would be great.

Here you go :) https://gist.github.com/andersonshatch/dec84cb83608002e69bfc2759e019c96

@andersonshatch
I have added the events. The possible events on the bus are now:

netatmo_person
netatmo_movement
netatmo_human
netatmo_animal
netatmo_vehicle
netatmo_other

Except from the netatmo_person event all events contain the following data:

event_type
home_name
camera_id
message

For netatmo_person there will be an event for each person with the additional data:

id
name
is_known

The netatmo_other event will be used for all other possible events we might not know of yet or will be added without our knowledge. I have seen topology_changed in the past, which happened when I took it off the power and plugged it back in. There may be other interesting events, and with this solution we are able to monitor them, and eventually add the important ones here as dedicated events.

I have now also added services to add and drop the webhooks. Adding webhooks is particulary useful because they can get banned. Being able to (re)add the webhook via service removes the need to restart Home Assistant in case the webhook has been banned.
It's also possible to define an URL with the addwebhook service. The catch is, that the handle_webhook callback won't be subscribed during setup. So people who manually define a webhook as a workaround have to manually work with the received data.

@andersonshatch
Could you please try out my latest changes? The automation code I have posted above (now removed) did not work for some reason. I have to admit that I have copied an automation that did something similar and just adjusted it without properly testing it.
What I thought would work:
- alias: "Daniel Welcome"
  trigger:
    platform: event
    event_type: netatmo_person
    event_data:
      name: Daniel

I do get the matching event. But for some reason the automation won't fire. 😕

Other than the one set of changes I annotated, it seems to work okay, though I only tested so far with a dummy event of one type.
I'm confused as to whether I would need to call netatmo.add_webhook when I have:
netatmo:
  ...
  webhooks: true

Is it expected that the webhook is not registered until the service is called? So I would need to create an automation to call this service after hass startup?

No, you don't need to call the service. I first added it to be able add and drop during runtime while testing this. In practice it will be irrelevant for me, except if the webhook got banned. In that case you have to go to the dev-panel from Netatmo and unban the app. Afterwards you would need to restart Home Assistant to subscribe again. Using the service lets you do that without restarting Home Assistant.
On top of that the webhooks: true only really works with a generic exposed setup. It probably won't work for people with special reverse proxy setups where the auto-generates URL is incorrect. These users then could manually create a working webhook they can work with and add that one by using the service. So essentially it can be ignored by the mayjority of users, but a few wouldn't be excluded just because they expose HASS as usual.
I'll take care of the documentation now.

@andersonshatch
Could you please give me a description of what snapshot_url and vignette_url are for the documentation?

Sure!
Snapshot_url points to the full frame image captured at the time of that event, whereas vignette_url points to a cropped+zoomed image that focuses on the thing in that event, so if it was an animal event for example, the vignette image will show you just the part the camera believed was an animal.

@balloob
To me this seems fine now. Do you agree? Documentation has been taken care of as well.


Unclear "obsolete" description in Crosshair.cs - use LineColor instead of Color

https://github.com/ScottPlot/ScottPlot/blob/5ed3178403e56283dfd583b05890893d1d9ab2f0/src/ScottPlot5/ScottPlot5/Plottables/Crosshair.cs#L22
It should be "Assign values to LineColor" instead of "Assign values to Color". There is no Color property in CrossHair.
public Color LineColor { set { HorizontalLine.LineColor = value; VerticalLine.LineColor = value; } }

I just updated the NuGet packages to 5.0.26 and tried to change it from myCrosshair.LineStyle.Color to myCrosshair.Color which doesn't work. ;)

Oof, yeah, some of these definitely should be updated... thanks for pointing this out!
https://github.com/ScottPlot/ScottPlot/blob/5ed3178403e56283dfd583b05890893d1d9ab2f0/src/ScottPlot5/ScottPlot5/Plottables/Crosshair.cs#L22-L26

In a pinch, this should work
myCrosshair.HorizontalLine.LineColor = Colors.Blue;
myCrosshair.VerticalLine.LineColor = Colors.Blue;

No problem, that works also:
myCrosshair.LineColor = Colors.Blue;

But not the mentioned
myCrosshair.Color = Colors.Blue;

But not the mentioned
myCrosshair.Color = Colors.Blue;

Because this is a typo in the Obsolete comment, it should be LineColor and not Color 😉
Color would be too ambiguous:

text forecolor?
text backcolor?
line color?
...


Upstreaming of bevy_kira_audio.

What problem does this solve or what need does it fill?
The current bevy_audio is quite bare-bones, and bevy_kira_audio would add a lot of new flexibility / features.
What solution would you like?
Upstreaming bevy_kira_audio into bevy, after making sure the APIs are similar enough.
What alternative(s) have you considered?

Additional context
I am a relatively new contributer, and have discussed this on discord in #audio-dev.

Resolves #1304


Panilla execptions and tps drops with crashers guys

https://timings.aikar.co/?id=26723260cccd475bb4103c74d188574e
I see my server there are a lot of chestcracher and tps keep to going down a lot i am using 1.17.1 paper
plus trìowing a lot of exceptions,full log:
latest.log

Please reopen if this is still an issue. I am doing issue cleanup.


Merge sync 7666871

Summary
Sync to latest upstream #a82e284

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 8 committers have signed the CLA.:white_check_mark: dkstyle:x: jkowalleck:x: chenxsan:x: alexownejazayeri:x: snitin315:x: vankop:x: Matin297:x: JounQinYou have signed the CLA already but the status is still pending? Let us recheck it.


Update copyright year

Update the copyright year in the site footer.
I'm not sure if this should be "2019-2020" or just "2020"? Or if we want to add a bit of JS that'll automatically display the current year? 🤷♂
Motivation
It was the wrong year :)
Test plan
N/A

A bit of javascript to display the current year as the upper bound seems reasonable to me 👍

I haven't actually tested this yet out of laziness, so you'll want to run CI and check the test site it builds :D


Favicon.ico

We use DatoCMS 'SEO Preferences' (/editor/settings) to manage a project's favicon image. The DatoCMS API then enables us to use that image for various favicon and other icon meta tags.
However it does not produce a favicon.ico (DatoCMS' image service Imgix doesn't support .ico as an output format) which is often a file a browser looks for (and often shows up as 404 in analytics). So should we generate a favicon.ico during build-time (using some npm package)?

Discussed with @Siilwyn and @decrek that the situation in which the favicon from DatoCMS is not served is very rare and not worth adding extra tooling (and complexity) for. Simplest alternative would be using a very tiny favicon.ico as placeholder. But for now, I'm simply closing this issue.


auto_squash_enabled event support missing

Could not get pull-request #28: Serde Error: unknown variant `auto_squash_enabled`, expected one of `added_to_project`, `assigned`, `automatic_base_change_failed`, `automatic_base_change_succeeded`, `base_ref_changed`, `base_ref_force_pushed`, `closed`, `commented`, `comment_deleted`, `committed`, `connected`, `convert_to_draft`, `converted_note_to_issue`, `converted_to_discussion`, `cross-referenced`, `demilestoned`, `deployed`, `deployment_environment_changed`, `disconnected`, `head_ref_deleted`, `head_ref_force_pushed`, `head_ref_restored`, `labeled`, `line-commented`, `locked`, `mentioned`, `marked_as_duplicate`, `merged`, `milestoned`, `moved_columns_in_project`, `pinned`, `ready_for_review`, `referenced`, `removed_from_project`, `renamed`, `reopened`, `review_dismissed`, `review_requested`, `review_request_removed`, `reviewed`, `subscribed`, `transferred`, `unassigned`, `unlabeled`, `unlocked`, `unmarked_as_duplicate`, `unpinned`, `unsubscribed`, `user_blocked`

cref. https://github.com/XAMPPRocky/octocrab/issues/647 in release https://github.com/XAMPPRocky/octocrab/pull/671

This should be fixed with #5. Please test and reopen in-case it's not fixed yet. I don't know which repository you were using - so I can't test it.


Does it work for private/closed groups?

Yes! As long as the access token you configure belongs to a user with access to those groups.


Fix the situation that the first returned cert is NOT root cert

Fix #70
spdm_verify_certificate_chain_buffer：
No longer assume that the first certificate is the root certificate.
spdm_verify_peer_cert_chain_buffer:
Add handler of the situation that the first returned cert is NOT root cert.
Add unit-test case.
Signed-off-by: yi1 li<EMAIL_ADDRESS>

I also recommend to change peer_cert_chain_provision to peer_root_cert_provision.

I also recommend to change peer_cert_chain_provision to peer_root_cert_provision.

Got it


Commit message sent via webhooks has double quotes not escaped

Hello, using webhooks I found that double quotes in commit messages are not properly escaped, resulting in malformed JSON.
This is a piece of the submitted JSON payload, as you can see "internal" double quotes are not escaped.
"message": "added link "contactus" in "support" menu",

Closing this issue because is too old.


Munitions Crafter, Ammunition Crafting

In GitLab by @Velara on Nov 29, 2021, 17:25
At present when a Gunslinger with the munitions crafter feat adds an ammunition formula such as Rounds (Jazail) to their advanced alchemy section. An error message is displayed "Item is not compatible with crafting entry trait requirements, must match one of [["alchemical, bomb"], ["alchemical"]
Moreover, when crafting ammunition or Black Powder doses, they are treated like normal alchemical items and cost 1 reagent per 2, while level 0 ammunition should instead cost 1 reagent per 10 rounds.  Per the Munititions Crafter feat. "If you use a batch of infused reagents to create basic level-0 ammunition such as black powder cartridges or black powder doses, you produce 10 rounds of ammunition."
Awesome job on the crafting window, by the way. Love it.

And just for info, there has been a regression of some sort as the warning for incompatible item when adding rounds is back.

Reproduced again, link to discussion on Discord.

There's no item:subtype:ammo, even though the Consumable Type is "Ammunition".


Feature request: Browsre compatibility rule

Hello,
Thank you for the plugn.
Do you have rules to disallow features based on browser support?
For example:
https://caniuse.com/?search=RegExp%3A lookbehind
Lookbehind is not supported by some modern browser. So, it would be good to have a rule that disallows this feature alltogether.

Do we really need a new rule for that? Couldn't you just use "parserOptions": { "ecmaVersion": 2017 }?

ecmaVersion does not work with typescript parser and typescript does not transpile regexps.
However, I found this discussion:
https://stackoverflow.com/questions/63792948/typescript-eslint-parser-parseroptions-ecmaversion-ignored-not-linting
that refers to eslint-plugin-es.
eslint-plugin-es already have the necessary compatibility check.
So, new rule is really not needed.
Thx for your work.


DOC shifting to new template etc..

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
15 unchanged lines in 7 files lost coverage.
Overall coverage remained the same at 91.531%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/evolve/likelihood_function.py
1
96.3%

.nox/test-3-11/lib/python3.11/site-packages/cogent3/core/alignment.py
1
94.37%

.nox/test-3-11/Lib/site-packages/cogent3/evolve/likelihood_function.py
1
96.3%

.nox/test-3-10/Lib/site-packages/cogent3/maths/scipy_optimize.py
3
84.92%

.nox/test-3-11/Lib/site-packages/cogent3/maths/scipy_optimize.py
3
84.92%

.nox/test-3-8/Lib/site-packages/cogent3/maths/scipy_optimize.py
3
84.87%

.nox/test-3-9/Lib/site-packages/cogent3/maths/scipy_optimize.py
3
84.87%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
235582

Relevant Lines:
257380

💛  - Coveralls


Change hostname to certname where applicable

Certain column headers were referring to a node's certname as its
hostname. This commit corrects that by renaming the column headers.
If the intention was to display the hostnames instead of the certnames then please close this PR and I'll create a new one.

Changes Unknown when pulling 6e81fa4aa062f4fbf84eb174e3f23780a3e149c8 on thejandroman:fix_nodes_column into ** on voxpupuli:master**.


Remove logic around finding a configuration file inside directories

Thanks alot @stsewd for reviewing. I wanted to know that if find_all is removed should the tests check number of files or check if there are multiple files?

@sriks123 I don't fully understand your question, but new tests should only find one top level file, no more finding files inside directories.

@stsewd can you please review the changes that I made ?

@stsewd I made some changes as you suggested I aml working on including on that extra case can you please review this ?


Level 2 Concept

@RuinedKingg I'm focusing on the art and code today.
Would be nice if you could come up with some ideas for a second level after Yellow Brick Road.
The first level will be fairly simple. Just a green map with yellow bricks to walk on and grass/brush work on the side that makes it harder to walk.
Admittedly, I haven't read The Wizard of Oz in a long time so I have no reference what might come after.
If you know your way around GDScript, maybe we could also figure out how to make the mob spawns follow the player.
I'll be online all day later, after my next appointment.

I once did a vampire like. I have the remains of the code with the mechanics of spawning enemies and them following the character. We can look at this code

Regarding the level concept. In the story, after the road, she ended up in the forest, where she was looking for an oil can for Tin Woodman. We can make a forest location with trees that have a collision. And where once every N minutes an oil can will spawn on one of the quadrants, which must be picked up, otherwise the game will be lost

I once did a vampire like. I have the remains of the code with the mechanics of spawning enemies and them following the character. We can look at this code

That would be awesome.

Regarding the level concept. In the story, after the road, she ended up in the forest, where she was looking for an oil can for Tin Woodman. We can make a forest location with trees that have a collision. And where once every N minutes an oil can will spawn on one of the quadrants, which must be picked up, otherwise the game will be lost

I like that idea. The oil could set the forest ablaze. Probably easy enough to implement once we have finished the first level mechanics.

I made some changes and try to push it. But i get remote: Permission to The-Plot-Twist-of-Oz/Oz_Demo.git denied error

I made some changes and try to push it. But i get remote: Permission to The-Plot-Twist-of-Oz/Oz_Demo.git denied error

Lemme check. Maybe I need to change permissions

Alright. Try now, @RuinedKingg

Finnaly push it. I have 2 first commit with other mail and i just reclone and recommit all my changes

I think we needed individual issue for it

I usually do a git commit --amend --reset-author when I have issues like that.

I think we needed individual issue for it

For the swarm AI? Agreed


Handle introns in UTRs correctly in sequence export

Currently the sequence section of the gene pages doesn't include the introns that are within UTRs in the output even if you tick the "Include introns" box.

@mah11 said this was done. can close?

I did not comment on this issue.

 Clearly got lost.
Initially I thought  when i first commented this was to do with
https://github.com/pombase/website/issues/397#issuecomment-313048692
but I now think this is a separate issue. I see this is about introns in UTRs.
We should probably discuss. There are problems here because introns in UTRs are often unknown/unannotated. Not sure what the best behavior is nut not had time to think about it yet....

I thought this ticket was just saying that, where we do have introns annotated, the sequence retrieval doodad isn't handling them correctly.

I haven't tested it myself, but I would expect UTR introns to be handled as introns because, well, they are.

Tell the user explicitly if the sequence includes introns in the UTRs.  We should say something like "(Includes 2 introns in 5'UTR)" if a UTR and intron options are selected and there are UTR introns.

See also: #461.

I've made it explicit that we include UTR introns when the user selects the UTR and intron checkboxes.
The message is only shown when there actually are introns in a UTR.
I think this issue is done now.


[Enhancement] Input widget: password type icon should change to web standards

Description
The input widget with type password show an icon which is not a standard we should replace this with eye-open in password hidden state & eye-off in password show state (blueprint icons)

I would love to work on this issue, since I already have experience in this domain. Please assign it to me.

If this isn't already assigned, I would love to work on it.

Can i work on this issue?

I'd like to work on this issue

@vibhandikyash lets implement this as part of the Input widget design audit


Fixed failing unit tests #146

Removed arrow functions and moved done callbacks

Remove async/done from tests they aren't necessary #148

Hey,
Thank you for the effort, but this issue has already been solved by @ArcticZeroo at #177


Import Error When Running odc.stac on Colab

Hi there,
I hope this message finds you well. I encountered an issue while trying to use odc.stac in Google Colab. It seems there's an import error related to dask.typing. Below is the code snippet and the full traceback of the error:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
/tmp/ipykernel_12981/1875870462.py in <cell line: 3>()
      1 import geopandas as gpd
      2 import json
----> 3 from odc.stac import stac_load
      4
      5 # # Define the bounding box for Beijing

2 frames
/usr/local/lib/python3.10/dist-packages/odc/loader/_builder.py in <module>
     30 from dask.base import quote, tokenize
     31 from dask.highlevelgraph import HighLevelGraph
---> 32 from dask.typing import Key
     33 from numpy.typing import DTypeLike
     34 from odc.geo.geobox import GeoBox, GeoBoxBase, GeoboxTiles

ImportError: cannot import name 'Key' from 'dask.typing' (/usr/local/lib/python3.10/dist-packages/dask/typing.py)

It appears that there might be an issue with the compatibility between odc.stac and the current version of dask being used. Any guidance on resolving this issue or updating the package to be compatible with the latest versions of dask would be greatly appreciated.
Thank you very much for your time and assistance!

looks like the real issue is that we started using dask.typing.Key but have not updated minimal bound on dask. This was added to dask with dask/dask#10485
Not sure what version of Dask is in colab, but it's not latest, latest one should have it. You should be able to update dask to a more recent version, or alternatively downgrade odc-stac.
Work item for odc-stac is to figure out oldest version of Dask that has dask.typing.Key available and update dask bounds here:
https://github.com/opendatacube/odc-stac/blob/cf7b897eadd352d46c96ba80625a7a94e9823b6f/setup.cfg#L43
and also on conda-forge. I don't think we can afford supporting old versions of Dask, error is in packaging and should be fixed there.

Thank you! Your suggestion to upgrade Dask was spot on! I updated Dask to the latest version (dask-2024.7.0), and it resolved the problem perfectly.


Timeout option in puppeteer.launch not working

Steps to reproduce
Tell us about your environment:

Puppeteer version: 0.13.0
Platform / OS version: Ubuntu 16.04.3 LTS / macOS 10.13.2
URLs (if applicable):

What steps will reproduce the problem?
Please include code that reproduces the issue.

The code

async init() {
    // const browser = await puppeteer.launch();
    this.browser = await puppeteer.launch({
        timeout: 120000,
        headless: false,
    });

    console.log('Warning up...');

    this.page = await this.browser.newPage();
    this.page.setViewport({ width: 1024, height: 768 });
    return true;
}

async crawl_list(url) {

    console.log('Getting list...');

    try {
        await this.page.goto(url);
        await this.page.waitFor('.bodyMain li a');
    } catch (err) {
        console.log('Timeout! Get list failed.', err);
    }

    const list = await this.page.evaluate(() => {
        let _list = [];
        const links = document.querySelectorAll('.bodyMain li a');
        links.forEach(function(e, i) {
            _list.push(e.href);
        });
        return _list;
    });

    // console.log('url list:', list);

    return list;
}

According to the document, timeout  Maximum time in milliseconds to wait for the Chrome instance to start. Defaults to 30000 (30 seconds). Pass 0 to disable timeout.

But the timeout option in waitFor is functional.

await this.page.waitFor('.bodyMain li a', { timeout: 120000 });

What is the expected result?
Wait timeout for 120000 milliseconds.
What happens instead?
Warning up...
Getting list...
Timeout! Get list failed. Error: waiting failed: timeout 30000ms exceeded
    at Timeout.WaitTask._timeoutTimer.setTimeout (/Users/knowlet/crawler/node_modules/puppeteer/lib/FrameManager.js:593:58)
    at ontimeout (timers.js:469:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)

@knowlet the timeout option you're referring to is for the browser startup. This is used when puppeteer starts a browser instance and waits for it to initialize.
The exception you have happens in the page.waitFor function. It is unrelated to the browser startup timeout; you'll have to define it explicitly for every page.waitFor call you do.
Hope this helps!

@aslushnikov I would like to make this a feature to where you can set a default timeout for all waitFor calls instead of having to do it explicitly for every one. Could you provide me with a few pointers and info on how to get started?

Looks like i was a memory issue for me, I increased the memory in Google Cloud function console


added accounts module,added jwt provider, added register and login handler, added user manager error extension,fix jwt, refactoring DependencyInjection.cs, added script migrations-add-and-update.cmd

Jwt забыл в секреты кинуть


Wiki for chrome debugging protocol

Other than the website. I wasn't able to find any wiki to understand the API. For example I am not able to understand what Target API is and how it is different from using the Page API.
Can you please provide some links where I can find this info.

I'm in no way responsible of the API of the Chrome debugging protocol so I cannot maintain a proper wiki about it. I can just add examples for the most common use cases. I'm going to add an example about the Target domain. In the meanwhile:

Target manages targets (e.g., tabs) and provides a more advanced API with respect to CDP.New() and similar, for example, it allows to manage browser contexts that are like incognito tabs but you can have more than one session.

Page instead, is about the actual wepage navigation, DOM access, printing/screenshotting and more.

Here it is, hope it helps.

Thanks for the info and thanks for creating chrome-remote-interface


Buildbot is broken

Or rather, when I try to run buildbot create-master on a recent unstable (or even 14.12, I think), it complains as follows:
$ buildbot create-master
updating existing installation
creating /home/copumpkin/master.cfg.sample
populating public_html/
populating templates/
Traceback (most recent call last):
  File "/nix/store/4hag5dbmb9gq83r2cp6b9zhfn7gz9ls1-python2.7-Twisted-11.1.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1181, in unwindGenerator
    return _inlineCallbacks(None, gen, Deferred())
  File "/nix/store/4hag5dbmb9gq83r2cp6b9zhfn7gz9ls1-python2.7-Twisted-11.1.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1039, in _inlineCallbacks
    result = g.send(result)
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/scripts/create_master.py", line 152, in createMaster
    yield createDB(config)
  File "/nix/store/4hag5dbmb9gq83r2cp6b9zhfn7gz9ls1-python2.7-Twisted-11.1.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1181, in unwindGenerator
    return _inlineCallbacks(None, gen, Deferred())
--- <exception caught here> ---
  File "/nix/store/4hag5dbmb9gq83r2cp6b9zhfn7gz9ls1-python2.7-Twisted-11.1.0/lib/python2.7/site-packages/twisted/internet/defer.py", line 1039, in _inlineCallbacks
    result = g.send(result)
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/scripts/create_master.py", line 138, in createDB
    yield db.setup(check_version=False, verbose=not config['quiet'])
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/db/connector.py", line 101, in setup
    basedir=self.basedir)
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/db/enginestrategy.py", line 249, in create_engine
    return sa.create_engine(*args, **kwargs)
  File "/nix/store/8dvlxfbbyx9vxxhn5ff1rpcahmqbgcib-python2.7-SQLAlchemy-0.7.10/lib/python2.7/site-packages/sqlalchemy/engine/__init__.py", line 338, in create_engine
    return strategy.create(*args, **kwargs)
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/db/enginestrategy.py", line 203, in create
    self.check_sqlalchemy_version()
  File "/nix/store/r4ydwphvpfqgxmgmjqj4w84akr4p7qjs-buildbot-0.8.10/lib/python2.7/site-packages/buildbot/db/enginestrategy.py", line 198, in check_sqlalchemy_version
    "SQLAlchemy-Migrate version %d.%d.%d" % (version, mvt[0], mvt[1], mvt[2]))
exceptions.RuntimeError: SQLAlchemy version 0.7.11 is not supported by SQLAlchemy-Migrate version 0.6.1

So the package builds fine, but fails at runtime due to a b0rked version. I think the issue actually lies in sqlalchemy_migrate.
Given that this thing manifests itself as a runtime error, perhaps some sort of extra test is warranted going forward?
cc:

@bjornfor for maintaining buildbot
@domenkozar for general knowledge about python ecosystem
@mlieberman85 for having a vested interest in the outcome

Apart from fixing the sqlalchemy version, we should fix the test (remove doCheck = false from buildbot expression).

Uhm, our sqlalchemy-0.7.10 seems to really contain .11 version, as seen in the above error message and here:
$ nix-build -A pythonPackages.sqlalchemy
/nix/store/kdd76a90v4wk3qc3y98k7xpbp2ji3k15-python2.7-SQLAlchemy-0.7.10

bfo@talisa ~/nixpkgs [git:master]
$ tree -L 4 /nix/store/kdd76a90v4wk3qc3y98k7xpbp2ji3k15-python2.7-SQLAlchemy-0.7.10
/nix/store/kdd76a90v4wk3qc3y98k7xpbp2ji3k15-python2.7-SQLAlchemy-0.7.10
├── lib
│   └── python2.7
│       └── site-packages
│           ├── python2.7-SQLAlchemy-0.7.10-nix-python-propagated-native-build-inputs.pth
│           ├── sqlalchemy
│           └── SQLAlchemy-0.7.11-py2.7.egg-info
└── nix-support
    └── propagated-native-build-inputs

Upgrading buildbot 0.8.10 -> 0.8.12 didn't change anything (might as well fix the issue before pushing that update).

Oh, @domenkozar is listed as maintainer for sqlalchemy-migrate [1]. Waiting for his input on version dependency between sqlalchemy and sqlalchemy-migrate. It might be a general issue (not related to buildbot at all).
[1] https://sqlalchemy-migrate.readthedocs.org/en/latest/

Sigh, wish they used alembic instead of sqlalchemy-migrate. We have to bump sqlalchemy as dependency, but most importantly start to use fixed point correctly in nix+python ecosystem

What's the plan for this? @domenkozar, it sounds like this is an example of a broader problem? Is there a quick fix that will get this working until we have the better solution in place? If you tell me what it is, I don't mind taking a go at implementing it.

@copumpkin short-term: override and bump sqlalchemy dependency for buildbot
long-term: use fixed point to provide better flexibility overriding packages in python ecosystem

This is now fixed in 11086

Thanks!
On Sat, Nov 21, 2015 at 12:08 Domen Kožar<EMAIL_ADDRESS>wrote:

Closed #8909 https://github.com/NixOS/nixpkgs/issues/8909.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/8909#event-471166388.

Looks like it's broken (still? again?)

Anyone tried the RC?
https://pypi.io/project/buildbot/

https://github.com/NixOS/nixpkgs/pull/17699 fixes buildbot (0.8.12 -> 0.8.14) and init 0.9.0rc1

0.9.0rc2 is merged in d86114cbd57de9e821c35cd2a1bfcf4bad2b0a5f

can we close this?

Yup but I can't get to the github UI right now

On Sep 19, 2016, at 07:31, Frederik Rietdijk<EMAIL_ADDRESS>wrote:
can we close this?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


How to fix the size of the clipping area

Overview
I am using Brightroom and I find that the default crop area can be changed by the user.
I want the cropping area to be fixed in size.
How to achieve it?
Reproduce version
latest

@Rookie131
Hello, thank you for using this library.
Which component are you using?
ClassicImageEditViewController or PhotosCropViewController or something else?

Hi @muukii
I use PhotosCropViewController

Hi @muukii
thank you for your reply
Now I can fix the size of the crop region, but I cannot specify the specific width and height of the crop region, such as I want the crop region to be the width and height I specify

Hi @muukii
I want this effect.
https://raw.githubusercontent.com/wangwangok/PhotoCutter/master/photo_cutter.gif

@Rookie131
so, you want to crop the image by specified pixel height and width exactly?

@muukii
yes.
How do I use Brightroom to do this

@Rookie131
Sorry, currently UI does not support cropping by specific pixel size. but render does support.

Hi @muukii
Will you consider implementing it?
I really like Brightroom, but I need to specify the pixel height and width precisely.

@Rookie131
not sure. currently, I don't have time to implement that especially.


Undo stack includes final newline being removed and inserted on every save in json files with files.insertFinalNewline = true && editor.formatOnSave = true

VSCode Version: 1.25.1 (also reproducible in 1.26.0-insider)
OS Version: arch linux

When saving a json file while both files.insertFinalNewline and editor.formatOnSave are set to true, the editor will remove (if present), then re-add the final newline on every save. Trying to then undo changes made before saving the file first undoes the newline re-insertion on first try, the newline deletion on the second try, and only then the actual change before saving the file. This is especially inconvenient in large files, where the view scrolls to the end of the file when the newline changes are undone.
I would guess that this could be fixed by not removing the final newline when formatting json if files.insertFinalNewline is set to true.
Steps to Reproduce:

Set files.insertFinalNewline and editor.formatOnSave to true
Create or open a json file (just {} suffices)
Do some modifications
Save the json file
Try to undo the previous modifications with Ctrl+Z

Does this issue occur when all extensions are disabled?: Yes

Okay, this is indeed a duplicate, but the old issue doesn't explain why this is an issue and hasn't received any attention more than 1.5 years. Not sure how to proceed, so I'll leave this open for now.

duplicate of #17359


Using the library with in-memory objects

Hi,
I have a model with some calculated fields that must be searched but since they do not exist in the schema naturaly  had a System.NotSupportedException: 'The specified type member 'FieldName' is not supported in LINQ to Entities. Only initializers, entity members, and entity navigation properties are supported.' thrown at https://github.com/AlexanderKrutov/DataTables.Queryable/blob/80398b19897ee92f7b08eaa48a9a38874425c4b7/DataTables.Queryable/DataTablesQueryable.cs#L84
I am aware of the purpose of this library, the intention is relying on data context.
So my question is, what would be the path to use the library with in-memory objects e.g. List<MyMode> ? My dataset is not too big so it won't hurt. Any tips?

Hi @pskrtr
Could you please explain more detailed the problem you trying to solve? It will be good if you share some piece of code with sample data model.

Thanks for the reply @AlexanderKrutov, sure.
Here's an example model to demostrate the issue.
public class Person
{
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public int Id { get; set; }
    [MaxLength(50)]
    public string Name       { get; set; }
    [MaxLength(200)]
    public string Description { get; set; }

    public string ReversedName => string.Join("", Name.Reverse());
}

Id, Name and Description are existing in my table. ReversedName on the other hand is a calculated field as you can see.
The library has no problem with a default DataTables view, displaying and pagination just works.
However when it comes to search something or sort by a column, this calcuated field leads the exception. That's why I'm asking another way to use the library with an in-memory set, e.g.;
public class MyController : ApiController
{
    public JsonResult<object> Get()
    {
        var request = new DataTablesRequest<Person>(Request.RequestUri.Query);
        using (var ctx = new MyContext())
        {
            // fetch all table to filter nor sort in app, not via linq to entities
            var personsInMemory = ctx.Persons.ToList();

            // this of course does not work
            var persons = personsInMemory.ToPagedList(request);

            var response = new
            {
                recordsTotal = persons.TotalCount,
                recordsFiltered = persons.TotalCount,
                data = persons
            };
            return new JsonResult ... ;
        }
    }
}

I hope I can explained well.

@pskrtr got it.
Try this:
var personsInMemory = ctx.Persons.ToList();
var persons = personsInMemory.AsQueryable().AsDataTablesQueryable(request).ToPagedList(request);

@pskrtr hope my previous advice helped to solve your issue, so I'm going to close the case. If no please just reopen it.

@AlexanderKrutov It worked flawlessly, thank you so much.


Fix NullPointerException when message is missing

What
Where/Who

People Involved
@hborisoff

Closing PR because issue was reproduced in older version and it is not related to current SDK.


feat(main): clean feature #81 no.4

Describe what this PR does / why we need it
#81
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

registry container name is “sealer-registry”


Multi Provider App Installations

We should look into multi provider installations and check what we need to tackle to make these possible.
For a start we need to think of all challenges that might occur when having a CAPZ MC and installing Apps on CAPV WC.
@ljakimczuk already did some initial investigations into this, but we should have another look to come up with a plan to make this possible (not only for the CAPZ / CAPV combination but in general)

App Admission Controller release PR: https://github.com/giantswarm/app-admission-controller/pull/460
App CRD update PR: https://github.com/giantswarm/management-cluster-bases/pull/132

Closed as completed


--source pika

Original Discussion / PRD: https://github.com/pikapkg/snowpack/pull/205
This PR is now ready for review.
Background
Snowpack is a post-install tool. It runs after npm install, and it essentially exists to convert your npm packages (in your "node_modules/" directory) into JS files that run in the browser without a bundler (written to a "web_modules/" directory). Because of this flow, Snowpack has an implicit dependency on npm/yarn and a direct dependency on Rollup, Babel, etc.
Pika CDN is a hosted CDN of npm packages. Whenever an npm package is requested, it is built into a JS file that run in the browser without a bundler (served in the response). If it helps, you can think of it has hosted Snowpack or Snowpack-as-a-Service.
Investigation
The question that I've been exploring over the last couple of weeks: If Pika CDN is already a hosted, pre-built source of Snowpack-built packages, can we just pull code from the CDN instead of installing/building locally every time we run Snowpack?
 Snowpack can manage your frontend dependencies for you.
Implementation

If --source pika: Run a pre-pass step to resolve each webDependency on the Pika CDN. If it succeeds (dependency exists on the CDN) store the response in a local cache to use later.
On install, check our local cache for CDN-resolved dependencies. If found, read it from there and resolve any sub-dependencies through the CDN as well. Otherwise, fall-back to a lookup in your local node_modules directory.
On finish, write a "lockfile" (import map) to the current working directory. On future installs, Snowpack will read the URLs from this lockfile instead of re-resolving them and potentially pulling in new dependencies.

Documentation

/cc @dangodev @alex-saunders @monchi @stramel
@NotWoods you might like this as well, given our conversation the other week :)

This works great! And in a sample project it was pretty fast (and basically instant on subsequent re-runs 🏎)
One potential cache thing: earlier I reported a bug where it didn’t finish installing (because of a Pika CDN thing? or something). But I think snowpack.lock.json was still created and something still got cached even though it failed. As a result, when I tried again, the install failed.
However, clearing the cache (blowing away node_modules) worked and it ran first try. I’m not sure by staring at this code, but if any part of the install fails, does any part of it get cached? Should we blow away the cache on error? It could possibly prevent some weirdness.

@dangodev I think when you last ran it we didn't protect the cache from bad responses as well as we do now. Now that should be impossible, but I can confirm.
It would be great to have a self-healing cache, but for our own sanity as contributors we should add a --reload flag to clear the cache before running.

Thanks everyone for reviewing! I added --reload support to bust a broken cache, and added an "experimental" warning with --source pika so that we can merge and continue to experiment before locking in support.


navigateToRoute return signature change - no longer a Promise?

Overview of the Issue: router navigateToRoute() previously has a return signature type of Promise<PipelineResult | boolean>, then NavigationResult and most recently boolean (version 1.7.1).
Motivation or Use Case:

Upgrading from earlier versions to latest results in build failure in projects enforcing tslint rule "await-promise".
Code relying upon navigateToRoute as an awaitable function require refactoring

Library Name and Version(s): aurelia-router, router.ts version 1.7.1 (current)
Browsers and Operating System: N/A (build issue)
Reproduce the Error: Build an application with lines below using aurelia-router version 1.7.1 and tslint "await-promise" rule turned on
Related Issues: None found
Suggest a Fix: Revert return signature change, or explain reason for change to return type boolean.

https://github.com/aurelia/router/blob/893b768f01aea842ee57db4222e66aa572f24404/dist/aurelia-router.d.ts#L300

Ping @davismj

If i understand correctly, returning a Promise is incorrect, since it's not what the history navigate returns

The typing is in fact wrong. After quickly tracing through, I want to say it should be boolean | Promise<PipelineResult> but it might be boolean | Promise<boolean | PipelineResult>.

Thanks for the initial investigation @davismj

@davismj  @EisenbergEffect I'd be happy to submit a PR for this.  I'm not sure where the CLA is that I need to sign.  The CONTRIBUTING.md in this project sends me to:
http://goo.gl/forms/dI8QDDSyKR
Which says "Sorry, the file you have requested does not exist.":

Please feel free to submit a PR :) When you submit the PR, Github will check our CLA sig list and prompt you with the proper way to sign. Sorry about the bad link. I thought I had that updated everywhere after we switched over to CLA Assistant. I'll get that fixed soon.

Hi, and again...
Aurelia version:
> au -v
Local aurelia-cli v1.2.3

method this.router.navigateToRoute and this.router.navigate are return both a  Promise not the boolean :(
but:
/**
	 * Navigates to a new location corresponding to the route and params specified. Equivallent to [[Router.generate]] followed
	 * by [[Router.navigate]].
	 *
	 * @param route The name of the route to use when generating the navigation location.
	 * @param params The route parameters to be used when populating the route pattern.
	 * @param options The navigation options.
	 */
	navigateToRoute(route: string, params?: any, options?: NavigationOptions): boolean;

If the bug is fixed how i can update aurelia-router.d.ts?

@Calabonga let me have a look at this. From what I remember, the signature was wrong, and boolean was a fix

@bigopon The change I had proposed for this I eventually abandoned because @davismj indicated that he had identical changes (as a Promise) in a local branch that hadn't yet been pushed,  which he would carry forward.

@bigopon , @matthewcorven  Thanks for your quick answers, but...

What's the correct type for return in fact?
When will I can download the correct version?

@Calabonga I think this is the best-matching signature, but ultimately I'm looking to @davismj and @bigopon to validate.
https://github.com/aurelia/router/blob/17258378e92201481e41064c16449b579c1c4fd0/src/interfaces.ts#L323

@bigopon I think so too! Thanks. I'll be waiting.

@matthewcorven @Calabonga @davismj on the surface, boolean is the sufficient return type as it's the contract that History guarantees. However, the implementation of History doesn't conform this, and actually returns a different type: it's eventually: Promise<PipelineResult> if the pipeline ran successfully, or Promise<void> if there was an error in the pipeline. So final typing could be something along this line, I believe.
export type NavigationResult = boolean | Promise<PipelineResult | void>;

It's not too far off compared to what we have at the moment in the comment https://github.com/aurelia/router/issues/648#issuecomment-582686325, so I think we can keep it in the current shape for now. We could refactor more, but there's concern that big refactoring without major semver change would destabilize the router, while providing not big enough value to justify it.
We will still fix critical bug though. So, ... sorry for the issue 😓

Thanks. I'll try to refactor my logic yet.

Any update @Calabonga ?
CC @bigopon


v2.3.6 amd64 image missing

The amd64 variants are missing on dockerhub for v2.3.6.

the image is currently under construction
https://doi-janky.infosiftr.net/job/multiarch/view/images/view/traefik/

Thanks, didn't know 🤦♂  So my renovate bot was to fast


Lime-126, Issue 148: Use else if in withdrawLiquidity

Description
Stacked pull request on #199
The if conditions in Pool.withdrawLiquidity are distinct conditions on the pool status.
Therefore, else if is semantically equivalent but more gas efficient.
Integrations Checklist

[ ]  Have any function signatures changed? If yes, outline below.
[ ]  Have any features changed or been added? If yes, outline below.
[ ]  Have any events changed or been added? If yes, outline below.
[ ]  Has all documentation been updated?

Changelog

Using else if instead of if conditions to save gas in Pool.sol.(Issue 145: DoS when depositing collateral
Ref: https://github.com/code-423n4/2021-12-sublime-findings/issues/145)

Event Signature Changes
Function Signature Changes
Features
Events

Codecov Report

Merging #200 (d34b9fa) into lime-95 (8897654) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           lime-95     #200   +/-   ##
========================================
  Coverage    15.94%   15.94%
========================================
  Files           16       16
  Lines         1737     1737
  Branches       321      321
========================================
  Hits           277      277
  Misses        1460     1460

Impacted Files
Coverage Δ

contracts/Pool/Pool.sol
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8897654...d34b9fa. Read the comment docs.


show locals in the debugger

create a new MTree component
use it to show local variables in the execution view
extend the debug model to know about values (DebugValue)

@danrubel

LGTM


[WIP] Markdown documentation experiment

The goal of this experiment was to see if we could generate markdown files to integrate with ducusaurus. Because sphinx provides more flexibility we have decided to keep the current process.


Language server duplicated

Type: Bug

Open both .py and .ipynb files in vscode
Write some codes and find two same objects in code prompt window
Also, check the dropdown menu of OUTPUT (Ctrl + Shift + U), there are "Python Language Server" and "Python 3.XX.X ()-languageserver"

Is there any way to manually shutdown the language server launched by Jupyter?
Extension version: 2022.9.1303220346
VS Code version: Code 1.73.1<PHONE_NUMBER>f055b99068d3688932416f2346dd3b, 2022-11-09T04:27:29.066Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.4.0-91-generic

@ywnien
Please could you install VS Code insiders and the latest pre-release version of the Jupyter, Python and Pylance extensions and confirm this still repros.

The problem is solved when I only changed to pre-release Jupyter (v2023.1.1003411034). Python, Pylance and VS Code are all stable version.
Weeks ago the pre-release Jupyter was unstable and keep crashing. Now it seems to be stable and seccessfully run on Windows10, WSL2 (ubuntu 20.04) and ssh remote server (ubuntu 20.04).
Thanks a lot!


Add flight check for undergraduate courses when candidate has a degree

Context
TDA is an undergraduate route into teaching, and applications are primarily for those who do not have a degree.
Those who have a degree are still able to apply, however there are other quicker and more suitable routes into teaching for them.
This commit is to add a flight check to TDA applications where the candidate has added at least one degree, to encourage them to consider alternatives.

 TDA Application: Add flight check when submitted a TDA application if the candidate has a degree


[Releases] Streamline the release process

Objective
Streamline the release process of PATH.
Origin Document
https://discord.com/channels/824324475256438814/1263851886486880356/1314302316266000414

Goals

Share patterns & logic across poktroll, PATH, PADS
Enable anyone to tag & create new releases
Automate the right amount of the release process and keep the rest manual

Deliverables

[ ] Docker image

[ ] Build and publish docker image on every merge to main
[ ] Attach the main & latest tag to the latest docker images (ephemeral tag)
[ ] Attach the sha to each one (static tag)
[ ] For official releases, attach the corresponding sha as well
Example: https://github.com/pokt-network/poktroll/blob/main/.github/workflows/main-build.yml

[ ] Tagging new releases

[ ] Create Makefiles for tagging new releases manually
[ ] One for minor releases (git tag + git push + helper to create the release)
[ ] One for major releases   (git tag + git push + helper to create the release)
Example: https://github.com/pokt-network/smt#release-tags

[ ] Publish artifacts

[ ] Publish artifacts automatically for multiple environments every time a new release is published
[ ] Mimic the results of this release process (i.e. 4 types of binaries): https://github.com/pokt-network/poktroll/releases/tag/v0.0.11
Example: https://github.com/pokt-network/poktroll/blob/main/.github/workflows/release-artifacts.yml

The following will be done by @Olshansk and copy-pasted across the different repos.

[ ] Document all of the above in a new page in docusaurus

[ ] Reference the docker image ghrc repo
[ ] Example of how to pull the docker image
[ ] Explain the makefiles available
[ ] Explain when to use the makefile targets
[ ] List the environments supports
[ ] Link to the existing releases

Creator: @Olshansk
Co-Owners: @commoddity @HebertCL @okdas

@commoddity @HebertCL @okdas Please 👍 this message if the deliverables above align with everything we discussed.
Leave a comment if something is missing or unclear.


ci: Fix versions_checker.sh

Version checker does to work today

Allow to detect stabe branches

Fixes #1581
Signed-off-by: Jose Carlos Venegas Munoz<EMAIL_ADDRESS>

/test


Fix Disappearing Horizontal Executions in OnTheFlyMerging

Description
OnTheFlyMerging ignored dependencies (reads after writes) between vertical loops. This could cause disappearing horizontal executions and assertion failures in subsequent optimization passes. Found while analyzing #450.
Requirements
Before submitting this PR, please make sure:

[x] You have run the code checks, tests and documentation build successfully
[x] All fixes and all new functionality are tested and documentation is up to date
[x] You looked at the review checklist

Additionally, if this PR contains code authored by new contributors:

[x] All the authors are covered by a valid contributor assignment agreement,
signed by the employer if needed, provided to ETH Zurich
[x] The names of all the new contributors have been added to an updated
version of the AUTHORS.rst file included in the PR

bors try

Nice find. Does this resolve the issue too?

Thanks for the review! I think it does not resolve issue #450, but it is certainly required to investigate further.


[Suggestion] Space Travel

do you plan to create space travel and you can piloting the spacecraft manually to reach planet in the space dimension?

Planning that as part of hardmode

ah very good!

Folded into #2036


Unify matrix assembly+solve in backends

The storage of matrix data, and the operations on matrices (i.e. matrix assembly and matrix solution), have not been implemented in a consistent manner.
The main problem was that matrix assembly was managed by a matrix_assembler type provided by the back end, which had views on information that it required to perform assembly. Specifically, the views were on properties like face_conductance, model state like voltage and current, and on the underlying matrix storage d, u and p.
This was not a good solution because

there was a hidden dependence of the assembly on model data. e.g. if the voltage storage was reallocated, the reference in the matrix_assembler would become stale.
if we want back end specific optimizations that require a different data layout to that used elsewhere in the back end, this layout should be shared with the solver, but there is no obvious mechanism for doing that.

This patch addresses this by making a matrix_state type in the back end.

stores the matrix state opaquely, allowing back-end specific optimizations
provides interface for performing operations on the state, namely assemble, solve and get_solution.
stores fields such as face_conductance and cv_capacitance that were stored in the fvm_multicell, despite being used only in matrix assembly.
takes voltage and current as parameters to the assemble interface, removing the hidden reference to model state.

The actual data layout has not been changed in this PR. Instead, the interface has been refactored and hidden references removed so that it is now possible to implement back-end specific optimizations cleanly.

Looks great! When you have a chance, it would be good to update the comment about the face conductance (or I will at some point.) Will merge.


WebApp - Allow to use Migration Polkadot App to attach Ledger account

Describe the task
Allow to use Migration Polkadot App to attach Ledger account
Refer: #3307 #3402

Version test : https://bb2ae5ca.subwallet-webapp.pages.dev/accounts/connect-ledger

[ ] Update color item according to list pool blocked

[ ] Arrange un-select items down

Version test : https://be47c535.subwallet-webapp.pages.dev/home/tokens
Validation passed
Link checklist : https://www.notion.so/subwallet/Check-list-Migration-Polkadot-App-to-attach-Ledger-account-b330154648ab4bdf85958379755ef9d3

Handle case XCM for legacy app -> Releated to issue https://github.com/Koniverse/SubWallet-Extension/issues/3531


hashing to primes

In https://github.com/poanetwork/vdf/blob/master/vdf/src/create_discriminant.rs#L60 you choose a prime of the form  n + m x  where m has many small prime factors https://github.com/poanetwork/vdf/blob/master/vdf/build.rs#L82
How does m having many prime factors improve uniformity for the prime?  You site https://eprint.iacr.org/2011/401.pdf  but I do not really know that literature so no explination jumped out at me.
I suppose the second hashing-to-a-prime function hash_prime in https://github.com/poanetwork/vdf/blob/master/vdf/src/proof_wesolowski.rs#L112 can use a simpler algorithm because it generates only 128 bit primes.

I'm not sure about it, but I think it's not about making the primes more uniform, but rather about speeding up the prime number generation by picking a number that is likely to be a prime (because m has many factors and n is coprime to them).
I believe it was inspired by Chia's inkfish.
I'm also confused by that comment at the end, though.

We'd create an extremely non-uniform distribution of primes found if we used p = n + 2 x where x is incremented by 1 each time.  I could imagine making them more uniform could become important, except maybe we've so many starting positions n that even 2 creates a secure distribution.  I would not precompute the VDF for some number of very high probability primes, but maybe some more informed attack can exploit the bias.
It appears the hash_prime function worries about this for smaller primes, but the sieve scheme is surely faster for larger primes created for the discriminate. I'd kinda imagine p = n + (log n) x should avoid any bias, although I had no proof of this fact.  It's quite a mystery why p = n + m x avoids bias with such a small m, but..
Thank you for linking inkfish though.  I'd missed the link earlier in the file.  In fact, the inkfish file links https://eprint.iacr.org/2011/481.pdf so maybe @DemiMarie simply miss-copied the reference?


Zenith: Adds descriptions & comments for Python SDK init

To match https://github.com/dagger/dagger/pull/6720 and #6742
Builds on  https://github.com/dagger/dagger/pull/6729
ruff format seems happy.
Similar to Go and TS, I'm not putting a comment on the Class.
With pylint that throws
src/main.py:19:0: C0115: Missing class docstring (missing-class-docstring)

which someone could quiet down with something like this in their .pylintrc:
[MASTER]
disable=
    C0115, #missing-class-docstring

@jpadams Python SDK lint error seems legit: https://github.com/dagger/dagger/actions/runs/8055979358/job/22004049415?pr=6741#step:6:596 (just need an extra newline before the closing """ I think)
The other errors are unrelated, will be fixed by https://github.com/dagger/dagger/pull/6745

@jpadams Python SDK lint error seems legit: https://github.com/dagger/dagger/actions/runs/8055979358/job/22004049415?pr=6741#step:6:596 (just need an extra newline before the closing """ I think)
The other errors are unrelated, will be fixed by #6745

Got it. Also fixed the error orign on line 600 where ruff and others want an extra line.

I just merged the other PR to fix docs lints, will rebase this one and let CI run to be extra careful and merge after if all green


Notifications for users and Admins

When a Order is commited. The Admin will notified.
When the order is adminclosed the User will be notifies

admin und user werden nun informiert


Edits to Dockerfile to enable paramiko to install

The edit adds imports to the Dockerfile that allow paramiko to be installed as a dependency without causing build errors.

This should solve issue #871

oh, also, would it be possible to add a section in the docs about how one would run a workflow on a remote host? As a subsection of the "Docker" section would be a good place to write this: https://github.com/getpopper/popper/blob/master/docs/sections/cn_workflows.md#docker

Hello @ivotron! We reverted the changes the IDE made to the docstrings, implemented your suggested fix to the Dockerfile, and re-added the section in the docs regarding running a workflow on a remote host from the commit reverted in issue #871. Is there anything else we can do to repair this issue?

sounds good, I've merged it! Thanks a lot for your contribution 🎉


Refactor server implementation

New implementations have been tagged on for some time now, and while doing so, new insights have been gained. It makes sense to do some clean-up in the near future before cutting a 1.0 release.
Some thoughts:

Split off models into their own model directory (similar to what was done for the web-client in 2d9bc81bec96ae606c2680090469376f3926b68a).
Enable same linters as in web-client, and fix any issues (such as missing documentation).
Split off processor deserialisation and template parsing into its own module, to make it easier to test.
Speaking of tests, extend the test coverage (severely lacking right now).
Improve worker logic, look into using an existing worker library, and support parallel running of jobs.
Improve Diesel ORM integration to properly compose SQL queries, reducing the need to pass around a connection object, and reducing N+1 queries.
Remove the Content-Length header work-around, now that https://github.com/actix/actix-web/issues/930 is fixed.

I've taken a first step towards solving this issue in 3932d5595a5705e3117d9f3535660cd912c066bc.
Specifically, I've introduced the first model, and made the query methods composable so that you don't have to pass in the database connection object to each different method, but chain what functionality you need and then at the end perform the query.
See: https://github.com/blendle/automaat/blob/3932d5595a5705e3117d9f3535660cd912c066bc/src/server/src/models/global_variable.rs#L14-L32


React.createFactory deprecated

Hi, I'm getting such warning in my browser developer tools:
React.createFactory() is deprecated and will be removed in a future major release. Consider using JSX or use React.createElement() directly instead.
Is it ok? Thanks for reply!

Is there any pull request for this?

I've created a pull request for this:
https://github.com/tabler/tabler-react/pull/516