Consider automatically attaching user credentials

I think it might be worthwhile automatically configuring this for developers using this package.
The grand majority of developers are going to be using Laravel's built-in authentication functionality so adding support will be beneficial to most people. In addition I don't think most developers are aware of this functionality provided by Sentry so they just gloss over it in the docs.
Laravel can be configured to username or email authentication and it's easy to get this stuff out of it. At the very least I think it should be fine to report the user's primary key and identifier (username/email). If a developer did want to send additional user information then they could opt to configure this feature manually.
Would you be open to automatically attaching the active user to error reports with this package?

Hey @dwightwatson,
Thanks for your suggestion, this is actually already a feature. This is where the user_context key is for in the configuration. See here the code that add's the user's primary key to a Sentry event:
https://github.com/getsentry/sentry-laravel/blob/a978c2110c4d49660b0de2a18800de4ea4e08acc/src/Sentry/SentryLaravel/SentryLaravelServiceProvider.php#L112-L116

Ah - gotcha. Looks like I have an older copy of the configuration file before this functionality was added, just re-published and it's good to go. Thanks for getting back to me.


item embedding and user sequence item embedding can not use the same embedding variable

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): mac m1
TensorFlow version and how it was installed (source or binary): binary
TensorFlow-Recommenders-Addons version and how it was installed (source or binary): 0.7.2 binary
Python version: 3.9.6
Is GPU used? (yes/no): no

Describe the bug
File "/opt/python/tensorflow/lib/python3.9/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
raise e.with_traceback(filtered_tb) from None
File "/opt/python/tensorflow/lib/python3.9/site-packages/tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_optimizer.py", line 739, in apply_gradients_strategy_v2_lagacy
return self._distributed_apply(strategy, grads_and_vars, name,
File "/opt/python/tensorflow/lib/python3.9/site-packages/tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_optimizer.py", line 204, in _distributed_apply
update_op = distribution.extended.update(var,
File "/opt/python/tensorflow/lib/python3.9/site-packages/tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_optimizer.py", line 172, in apply_grad_to_update_var
_apply_op = self._resource_apply_sparse_duplicate_indices(
tensorflow.python.framework.errors_impl.InvalidArgumentError: {{function_node _wrapped__ResourceScatterAdd_device/job:localhost/replica:0/task:0/device:CPU:0}} indices[758] = 758 is not in [0, 758) [Op:ResourceScatterAdd] name:
A clear and concise description of what the bug is.
This problem occurs when the user behavior sequence features reuse embbeding from item, but not when used separately
当用户行为序列特征复用item的embbeding时会出现这个问题，分开使用时没有问题
Code to reproduce the issue
for f in sparse_cols:
    _input = sparse_inputs[f]
    embeddings[f] = de.keras.layers.Embedding(
        embed_dim, initializer=keras.initializers.RandomNormal(seed=25), name=f"emb_{f}",
        # init_capacity=lookups[f].vocabulary_size(), restrict_policy=de.FrequencyRestrictPolicy
    )
    input_embed[f] = Flatten()(embeddings[f](_input))

for f in varlens_inputs:
    _input = varlens_inputs[f]
    mask = Masking(mask_value=0).compute_mask(_input)
    embedding = embeddings["bid"] if "_bids" in f else de.keras.layers.Embedding(
        embed_dim, initializer=keras.initializers.RandomNormal(seed=30), name=f"emb_{f}",
        # init_capacity=lookups[f].vocabulary_size(), restrict_policy=de.FrequencyRestrictPolicy
    )
    _embed = Reshape([-1, embed_dim])(embedding(_input))
    out_embed = MeanPoolLayer(axis=1)(_embed, mask)
    input_embed[f] = out_embed

Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

TFRA Keras Embedding layers could not be called twice and more for now. Please concat all inputs in one tensor and then lookup. If you use GPU kernel, this would also be better performance.


Add support for Qwen2Audio

Qwen2Audio huggingface docs
I see there's been a couple requests for vision-language model support like LLaVa:
https://github.com/unslothai/unsloth/issues/491
https://github.com/unslothai/unsloth/issues/158
For Qwen2Audio, the methodology is the same as LLaVa but works on audio rather than images. It uses a large pre-trained audio model (Whisper) to generate and project embeddings into the language model space. The embeddings are then injected into the input sequence of the language model.
I think we can still get some performance benefits by using Unsloth just for the language model for now (a lot of these models have the vision/audio towers frozen anyway) unless you see some conflicts or areas it could break? https://github.com/huggingface/transformers/blob/main/src/transformers/models/qwen2_audio/modeling_qwen2_audio.py#L858-L870

Looking into it, seems like the language model differs a bit in the architecture from the normal qwen2 models looking at the config.json so maybe this will need work from the Unsloth side.

Will look into this!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:30: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:37: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:37: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_a68olgo3fn/clone/recipe/meta.yaml:37: missing_description: The recipe is missing a description
Errors were found


Unable to use DDC controls on Dell U4320q, macos M2 although it should work.

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Read through the Monitor-Troubleshooting Wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the issue
I am having an issue using DDC controls on my monitor for Volume and Brightness. The reason I believe this should work is because I saw an issue where @waydabber mentioned that he wrote the tool at https://github.com/waydabber/m1ddc/blob/main/m1ddc.m as a toy program for the support he hadded in MonitorControl here https://github.com/MonitorControl/MonitorControl/blob/main/MonitorControl/Support/Arm64DDC.swift.
I built tried out the tool m1ddc and it works as expected: I am able to control Volume and Brightness through that tool. However when I try MonitorControl, it says in the settings that it is using "Software" and DDC is greyed out. I am unable to control volume and brightness. What could be the issue here ?
The exact same configuration is used during the two tests (same cable, same computer, same monitor, etc.)
Thanks,
Amat
Expected behavior
MonitorControl should be able control Volume and Brightness on M2 devices.
Anything else?
No response
Environment Information (please complete the following information)
- macOS version: 13.2.1
- Mac model: MacBook Pro (16-inch 2023) M2 Max
- MonitorControl version: 4.1.0
- Monitor(s): Dell U4320q
- Monitor Cable(s)/Connection(s): USB-C
- Apple Silicon/M1 (yes or no):yes

Hi there, unfortunately MC does not support M2 Pro macs as of now. It's interesting that m1ddc does wok, but the framebuffer is there, MC and Arm64DDC would need some refactoring, m1ddc is maybe a bit more relaxed and probably by chance finds the right port on your config.
You can use BetterDisplay, it basically has all the features MC has regarding DDC and brightness/volume control + a lot more and all DDC/brightness/volume stuff is free and unlimited and it has official M2 Pro support.

Thanks for your quick reply, tried out BetterDisplay and it seems to work perfectly. Thanks a lot!


Addition information in logInfo

Hello and thank you for this amazing inspector!
I try to integrate it into our project and faced with necessity to add some information into console.log(), which printing at: https://github.com/lahmatiy/component-inspector/blob/5ea4afc6dca8ad0f9bad24b7b1d89dae58743112/src/inspector/dom-viewer/index.js#L137-L144
Is it possible?

And just one more question.
Can I add determine to templates? For example, create one more link to here: https://github.com/lahmatiy/component-inspector/blob/5ea4afc6dca8ad0f9bad24b7b1d89dae58743112/src/inspector/dom-viewer/template/window.tmpl#L12

What sort of information you want to add? Probably we can add extra API method to customise information for console.log() or even override logInfo method logic.

Can I add determine to templates? For example, create one more link to here:

I guess you can. But I need to know what problem are you solving. Probably will be suitable to override info panel rendering at all.
Keep in mind, that backbone and react integrations are merely examples. You can hack inspector as you want. But if you see some ways for improvements that can be halpful for others - let's extend basic functionality.

In our project we using BEM and opportunity to print entering BEMJSON-tree would be helpfully. Somiteimes this tree is very big, what the reason that printing him in the component-popup is uncomfortable.

Are you use API free build? If we add extra methods to customise console output does it solve the problem?
Another possible solution is add custom panel (with overflow) to Inspector sidebar. Are you sure it's not suitable?

Yes, we use API free build.
Customizable console output will solve our problem in whole. And I think, that it would be useful for any other needs in the future.
Custom panel – interesting thing and it is can solve our problem too. But I'm afraid, that it will hard in realization and inspector may become monstrous due so bulky interface.

Component Inspector 1.3.0 is out. It has new methods to customize logging and helpers to create custom info sections (see Custom info sections).
I believe it meets your needs ;)

Cool and so fast! Thank you :-)


(Fix) Nifty Wallet restyling

Closes https://github.com/poanetwork/metamask-extension/issues/37

@patitonar yes, I wasn't focused on the update of e2e tests. @natlg started to fix them in a separate PR. Following this comment, https://github.com/poanetwork/metamask-extension/pull/55#issuecomment-409763379 let's merge this PR first if there are no critical remarks.


Use a consistent tracking pose between CockpitLook and ddraw VR rendering

I have come back to XWA after some busy times, and re-started the campaign.
In some of the missions, the performance drops heavily, regardless of graphics settings. During this phases, the VR tracking degrades too much, and the reprojection features of SteamVR and Oculus are not working as they do in other games.
The problem
Currently, the rendering performed internally by the XWA engine uses the 3D pose obtained in the last call to WaitGetPoses() performed in the previous frame. (SteamVR.cpp#L143). This is executed at the beginning of the frame, before any geometry calculation in the legacy engine.
However, the poses used by ddraw.dll to render the final image of that frame are obtained again directly from OpenVR during the Direct3DDevice::Execute(), through a new call to WaitGetPoses(). Since this happens after all the CPU work in the XWA engine has finished (just before the D3D11 rendering), this pose is different than the one used by the hook.
When the performance is good (frame time is low), the difference between those poses is negligible (<10ms). However, when the performance drops in the XWA engine (due to its intrinsic limitation of not using the GPU), the time between the execution of the hook, and the Execute() increases to multiple VSYNCs. In VR, this level of latency for the tracking is very noticeable.
Also, it probably messes up the tracking prediction algorithms.
I believe this is one of the, if not the main reason behind the jitter/shaking visible on game world objects when moving the head during low framerate periods.
One evidence supporting my hypothesis is that the HUD is totally stable and smooth (thanks to ASW-reprojection), even during framerate drops. I believe the HUD is rendered completely by ddraw.dll so the outdated pose used in the hook does not affect it. .
The solution
The pose needs to be calculated at the very beginning of the frame, just before the geometry calculations are started. In the current engine, that means at the CockpitLook hook before the CPU rendering starts.
Then, at the time of VR re-rendering, instead of obtaining again a new pose, the pose obtained by CockpitLook hook should be used.
The pending question
What is the best way to pass that information from the hook to the ddraw.dll?
Since they are 2 different modules, I believe it's not possible to use a simple global variable.
Probably the best alternative would be to create a function in the hook dll and call it from the ddraw.dll, after referencing it as external library.
@Prof-Butts what do you think?

I was actually looking at an old branch (maybe it would be good to merge the latest commits to master?)
After my last PR, in fact the Hook uses GetLastPoses().
But it should be using instead the updated poses from GetDeviceToAbsoluteTrackingPose(), and then maybe ddraw.dll can just call GetLastPoses() to obtain the same.

Right, the master branch is a bit behind -- sorry about that. Both the CockpitLook dll and ddraw share the same heap, so it's easy to have them talk to each other with, say, a memory-mapped file. Plus we wouldn't need a mutex either since XWA evaluates the Cockpitlook before the 3D path.
I think we can try the approach you're suggesting, but we need to be careful. The rendering thread must call the right APIs or nothing will show up. But, by all means give it a try! If it doesn't work, we'll just use a memory-mapped file to share the pose between these dll's.

I have tested this by moving the call to WaitGetPoses() to Hook_CockpitLook.dll->SteamVR.cpp, and using GetLastPoses() in ddraw.dll instead.
The performance is definitely worse, in terms of FPS, but the tracking feels a lot more consistent. The game world objects don't jump around so much. They're just low FPS to update.
To implement it properly, I need use GetDeviceToAbsoluteTrackingPose() in CockpitLook and leave the sync call to WaitGetPoses() in ddraw.dll.
But as I thought, we need to implement a way to pass the pose info from Hook_CockpitLook.dll to ddraw.dll, because we can't rely on GetLastPoses() (it doesn't take the GetDeviceToAbsoluteTrackingPose() into account, it will give the poses from the last frame).
I will try to do it by storing the pose in a global variable and a method to access it in Hook_CockpitLook.dll and calling it from ddraw.dll.

I managed to implement a first version:
https://github.com/morallo/xwa_ddraw_d3d11/commit/fc21161a97a5031a628ddb8e0e243b1118e87bc2
I also had to do some changes to the Hook_CockpitLook, but I haven't pushed them yet (I am struggling to compile the latest UDP branch). @Prof-Butts can you confirm that's the latest I whould be using?
The disappointing news is that the performance is again quite bad, and the tracking is consistently stuttery now, which means it impacts all elements on screen (including the HUD). I need to do more tests and analyze some XPerf captures with GPUView to find out the root cause.

Yeah, the latest version of the CockpitLook hook is in the UDP branch. Sorry, I really need to clean up my branches.

It turns out the fault was not in my code, but because I was using Virtual Desktop (wireless VR streaming) to play in Oculus Quest 2. When I changed back to Oculus Link (the official USB mode to use Quest2 on PC), I got the performance back.
I fixed an issue with the tracking in 2D mode and I think it's ready for beta-testing. I tried again with your latest beta from October and I can clearly notice an improvement. The tracking is much smoother with my latest code.
I will upload the compiled DLLs and post in the beta thread of the forum to ask for testers.
To ease the linking between ddraw and cockpitlook DLLs, I added the hook as a reference in ddraw solution.
Since both codes need to be in sync for everything to work properly, @Prof-Butts do you think we could include the hook in the ddraw repository as a submodule, and set it up so that everything is built together?

Hey @morallo!
Let me fix my mess and get the master branch up to date. I've just got a minor concern with your proposed fix. There are many people that don't like the effects in ddraw that much, but would like to use TrackIR. For those guys I usually tell them to remove my ddraw and just keep the CockpitLook hook. In your fix above, it looks like ddraw will now be needing a function from the CockpitLook hook through a static link. I think the approach is fine, but we need to use run-time linking instead. That way, the function in CockpitLook only gets loaded if people are running the SteamVR path.
Also, another minor point: can you drop the log_debug in the error path (when the pose isn't valid)? Logging induces a very noticeable penalty in performance. We can put that line inside a #define DEBUG or something like that.

@morallo: I keep thinking about this and I'm not sure run-time linking is a great idea either as it would introduce another dependency. Both DLLs see the same heap, so it's just a matter of sending a 32-bit pointer between them and that's it. However, let's go ahead and test this for now -- just bear in mind that we'll probably come back later to polish it a little bit :)

Thanks for the feedback!
I have removed the log_debug(). It was there before these latest changes. I thought there was no impact unless you had a listener actually capturing the messages, but it's not really necessary in such a performance critical function.
About linking I agree that dynamic linking would be a better option, but the function exported does not need to be used by the dll if it's not needed. So there is no dependency unless you are using SteamVR. I have tested, and the SteamVR tracking still works when using Jeremy's dll.
In terms of performance, would the shared heap be more efficient?

For dynamic linking you don't need to include the hook's headers in ddraw, you just need the function declaration itself. Since it's only one function, it probably makes sense to just copy the declaration. You're right that there shouldn't be any static link dependencies and the DLL reference is only loaded for SteamVR.
Using the shared heap would be faster than calling a function from another DLL because it's just a regular read from memory. I'm looking for options on how to do this, and this looks like a nice approach:
https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2008/h90dkhs0(v=vs.90)?redirectedfrom=MSDN
Perhaps we can use a shared data segment to store the SteamVR pose.

OK, both the CockpitLook hook and ddraw master branches have been released and tagged appropriately. Can you update your PRs? Also, can you explain again how you'd like to keep working in the future? I'm used to having the master branch as the stable release at all times and do experiments on other branches. My mistake is that I seldom refresh the master branch. I'll keep making experiments on the Release_1_1_5 branch for now.

PRs updated. We can discuss about branching strategy in #15

Giving another thought and some reading about the linking... I think I understand now better your first comments. There are 2 scenarios:

User wants CockpitLook tracking without effects (original Jeremy's dll)

This works with either static or dynamic linking, since Jeremy's dll will never import or call the exported function in the hook.

User wants effects without tracking

Static linking: ddraw.dll will need the hook even if will never be used. This can complicate merges back into Jeremy's, if that ever happens.
Dynamic Linking: will only try to load the DLL if the user wants to use tracking.

So, dynamic linking is the best option and should be easier to implement, until we implement any other shared memory option.

Well, it turns out that sharing stuff between these two DLLs may be rather easy. I just wrote the address of a char[32] to disk, from the CockpitLook hook, then I read that same address in ddraw and assigned it to a char* and it worked. Also, Jeremy just told me that there are some offsets in the PlayerData table that are unused so we can use that to share pointers as well. In other words: we may not even need dynamic linking at all.

@morallo: I just updated the CockpitLook hook to use the LocalProperties (I removed a couple of hard-coded paths as well). Let me implement the shared memory option as I think that would avoid any dependencies between these DLLs and it's faster anyway.

I have re-implemented it with the memory sharing functions, but it´s still not ready.
I created a new branch and a draft PR #35 (WIP).

@Prof-Butts as you merged #35 I think this issue can be closed, unless you think that there is something pending.


Enable Codecov

Hi Lauri, in case no one enabled codecov yet, I just did it for this project.
To use it in actions:
- name: Upload coverage reports to Codecov
  uses: codecov/codecov-action@v3
  env:
    CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

I set the secret name as recommended, above.
Cheers,
Alex

Thanks for the tip. I think I would like to avoid using an external service for the coverage reports.


Automatically create and style links for urls (draft/discussion)

if a user pastes a url, style it. if a user types a url, style it as soon as they hit space after typing the url.
Notion does this, Tana does not. so maybe something to discuss first.
600 weight, underline, color #067C9E which is Teal-600, still building out the teal palette otherwise. color passes contrast standards.
figma:
https://www.figma.com/file/NqOs6jwm1LQpEvwTAaZKJ7/Treehouse-Design-Library?node-id=399%3A8657&t=pRnOMyF5bFEPjAyt-1

going to move to the notion idea board


Add href to dependent pull requests

Preview:

This href will link to the dependent pull request's base branch (outlined above)

QA 🟢


add test for skip_values in DictionaryDecoder and fix it

Which issue does this PR close?
Related #2079
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #2105 (0c7cfb5) into master (2541e2c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   83.73%   83.74%   +0.01%
==========================================
  Files         225      225
  Lines       59412    59458      +46
==========================================
+ Hits        49748    49796      +48
+ Misses       9664     9662       -2

Impacted Files
Coverage Δ

...et/src/arrow/array_reader/byte_array_dictionary.rs
86.97% <100.00%> (+2.51%)
:arrow_up:

arrow/src/datatypes/datatype.rs
64.05% <0.00%> (-0.36%)
:arrow_down:

parquet/src/encodings/rle.rs
92.78% <0.00%> (+0.19%)
:arrow_up:

parquet_derive/src/parquet_field.rs
65.98% <0.00%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2541e2c...0c7cfb5. Read the comment docs.


[Wallet] Changes to Simplex cash in

Description
Implement the changes discussed in this thread: https://celo-org.slack.com/archives/CL7BVQPHB/p1605212144230400

Open Simplex webpage instead of using a webview.
Selection: right now, seems like the selection for cUSD/CELO is dependent on the method selected vs the country (eg CELO should always be selectable, but then only provide the option for ‘cryptocurrency exchange’
Debit Card copy change-- update “Debit, Credit, or Bank Account” to “Debit Card or Bank Account”

Tested
Manually

Still working on getting iOS tests passing

Hi @tarikbellamine i Have verified this issue latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5<PHONE_NUMBER>) and observe the following

User redirected to web page ( Valoraapp.com ) when user tap on  next button after selecting "Celo Dollar" & Debit crd or bank account" or "cryptocurrency exchange"
User redirected to exchanges page when user tap on next button after selecting "Celo" & cryptocureency echange"

Devices: iPhone 6+ (12.4.5) , Vivo v11 pro (10)
Can you please let us know if we need to test anything else in this task


Docs state Xcode 12.4 or higher, yet IDE complains that 13 does not equal 14

Why no support for the latest Xcode?

Hi. We actually support Xcode 13.4 for development, Read.me is outdated. Xcode 13 and Xcode 13.2 had issues with SPM for macOS so we used Xcode 12.4. We will move to Xcode 14 and will update Read.me. Thanks.

It’s not just the readme. The ide will not function on Xcode 13.Sent from my iPhoneOn Sep 27, 2022, at 1:02 PM, Kristalev Danil @.***> wrote:
Hi. We actually support Xcode 13.4 for development, Read.me is outdated. Xcode 13 and Xcode 13.2 had issues with SPM for macOS so we used Xcode 12.4. We will move to Xcode 14 and will update Read.me. Thanks.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

@jhoughjr what do you mean? Did you see the issues after trying to build the project using Xcode 13? Could you please share building errors here?


How to remove text on AxixY?

Hi. How can I remove text from the AxisY? I want to disable this function from my chart

You can use a axis value subclass that doesn't return labels:
class EmptyAxisValue: ChartAxisValueDouble {
    override var labels: [ChartAxisLabel] {
        return []
    }
}

And pass an empty axis title.
In case you would also want to remove the line, you can simply not pass the y axis layer to Chart.

Thanks for your response! And where need I use this snippet? I've added it under the class, where I'm using charts, but it did not make a sense. I think I do something wrong

Yes you have to replace ChartAxisValueDouble with EmptyAxisValue there. You also don't have to pass labelSettings then.

Thanks, but it still fills the place on my view. It's empty, yes, but it fills the place as it there

You have to set all the relevant settings to 0 in ChartSettings (leading, labelsToAxisSpacingY, axisTitleLabelsToLabelsSpacing). I think after that it still reserves a bit of space for the title. You can pass a negative value to leading to make it shift to the left or also shift the view where the chart is in to the left.

Thanks for you response!


Add an "% screen" parameter for xfreerdp

I would like to know if it's possible to size the screen based on the percentage of the monitor (like in rdesktop using the parameter "-g 90%" which opens a window based on 90 percent of the resolution) for example. So it would be easier to configure an script without worry about the resolution of the user monitor.
And if not, if it would be possible to implement in a future update.
Thank you!

@FurtadoPires that's already implemented on master and will be part of the 2.0 version.
Maybe it is also interesting for you that you can now use the percentage of width or height only if required.
From the commit  (4592deee724e2be837c5c3439ed78f16f2c797e9)  message:
    If the size parameter is used with a percentages like /size:50% now
    an additional 'w' or 'h' can be appended (like /size:50%w) to specify
    where the percentage should be applied. If both or none are set the
    behavior is like it was before and the percentage is applied to width
    and height.


Adds a couple of orphaned pages to the side-bar

This will also fix broken links to these pages (pages aren't compiled unless they're in SUMMARY.md)
See the broken links at the bottom of the following page for example
https://brooklyn.apache.org/v/latest/blueprints/winrm/

LGTM

LGTM, thanks for this @nakomis


crash

crash when i type a number on the x

crash log please

crash log please

2024-12-09_14-00-49.log
I'm new to github, sorry if I make any mistakes

should already be fixed in the next version just wait for it to be accepted on the index


Sorting file and folder in file browser

Hi. Is there any way to sort files and folders so that folders are always at the top and files at the bottom, like in Midnight Commander or TotalCommander?

You can do so by settings grouped = true in the telescope settings.
require("telescope").setup({
  extensions = {
    file_browser = {
      -- your settings...
      grouped = true,
    },
  },
})

Doing this makes the file browser use plenary's scandir functionality over fd so it's will be slower. Personally, it's not a noticeable difference.

Thanks @jamestrew :)
Closing unless there's further questions. For future reference, the documentation for these options is available at :h telescope-file-browser.picker.
One further note -

Doing this makes the file browser use plenary's scandir functionality over fd so it's will be slower. Personally, it's not a noticeable difference.

This would primarily become relevant in very, very large directories or setting depth (depth of folder levels to browse) to a large value.


[Run] Update tooltip styling

Update styling and color scheme for tooltip added in fix for #3173 and #3419

@somil55 I just checked out the latest master - and I wonder about the following:
The context menu buttons use the default WPF tooltips - I don't think we want to introduce another tooltip style in the same part of UI?

We can stick to the default WPF tooltip style.
We define a tooltip style (based on the UWP tooltip style) for both the context menu tooltips and the tooltip for app name / path.

I'd opt for the second option since we can use theming. Do you agree?

@niels9001 I agree that the second option would be better.

We just released 0.20 and this should be resolved there.  Please try it out.


Foreground notification event not being fired

React native version: 0.60.5
Platform: iOS
Version: 2.0.6
Background notifications are working fine, but the event handler for notificationReceivedForeground isn't being fired. I am only trying this library today, not upgrading from any other version.

I have this working now. I think there was an issue with rn-firebase still being linked in the project and still picking up this method.


portfolio page footer needs to be sticky

to reproduce go login and click on portfolio
the footer comes up until  the portfolio loads

can i work on this issue?

sure, please go ahead.
and make sure to gatsby build it locally to see the effect better.

any update on this? is @GQuirino working on it?

I could look into this if @GQuirino isn't anymore. I'm actually trying to run gatsby develop and it errors out with Error: Cannot find module '../config/env.json

Thank you everyone for your interest.
There have been some changes with the navigation, so this issue might be nonexistent.
I will go ahead and close this issue for now.
Feel free to re open this issue if you think it was closed by mistake.
Thank you


test-proxy feature-requests (JS/Go)

From JS:
Scoping of Transforms/Matchers:

[x] attach a transform to either all further requests for the session OR allow individual adjustments on a recordingId level.

Matching :

[x] For MSAL requests, we don't want to match on body at all. Example of what these look like

Simple Transforms:

[x] Regex replacement of body/header attributes

Regex replacement of request URL.
Complete removal of certain headers/body attributes.

More Complicated Transforms:

[x] Request A comes in, response includes id that will be sent in Request B. Client should not be aware of what's going on here.

Sync multiple header/body values across multiple request/response. Currently this is implemented as a common callback in your node tests.

From Go
Add functionality to Record/Playback start to allow record/start/<fully-qualified-test-name> instead of needing to always use the header
Did you consider enveloping the upstream request inside a proxy request rather than modifying the upstream request?

might be less fragile then having to make specific changes to the upstream request that could evolve over time.
stashing the whole upstream request as-is keeps is purely 1:1 with what would have really been sent to the live service
the envelope request can evolve to contain any arbitrary metadata required for recording/playback

From Python

[x] Omit Oauth from Recordings
[x] Omit Authentication from Recordings
[ ] Implement sanitizers from Python

[x] GeneralNameReplacer
[ ] DeploymentNameReplacer
[ ] GeneralNameReplacer
[ ] SubscriptionIdReplacer

Leaving body side manipulations for when JS encounters them. Need some solid examples to unit test against.


MongoDB with Prime?

Firstly, thanks for building this amazing CMS.
I know how good PostgreSQL is, but I am not very familiar with it
and I use MongoDB for most of my projects.
Can I use MongoDB with Prime? or Any roadmap? Thanks.

I guess MySQL isn't supported because of the use of JSONB.
Also I'm not sure if Mongo is possible because the IDs and usage of TypeORM is slightly different:
@ObjectIdColumn()
id: ObjectID;

With the ability to create embedded documents: https://typeorm.io/#/mongodb/defining-subdocuments-embed-documents
Also agree that RethinkDB is awesome :)

RethinkDB would be great! I love rdb
But I am open for any suggestions for allowing other databases, even if it means modification of how to configure prime.

@birkir have you heard about FaunaDB's Graphql support? they have a generous free plan and I'd like to use it to run a serverless graphql CMS.
You can upload and update the IDL schema and it takes care of everything else, but it has some custom directives.
do you think I can run prime on a Lambda, or does it need to be a long-running process on a server?

To be able to support webhooks (and my long term plan for real-time updates), it would need a long running process.
It could be solved differently though.
Thanks for the tip, I'll take a look at FaunaDB's GraphQL support!


[Feature]: Refactor configuration file for improved inference

To whom is this feature for?
End user
Why is is this feature needed?
As of now in the configuration file of the miden-node file we have some dependencies between components:
[block_producer]
endpoint = { host = "localhost", port = 48046 }
store_url = "http://localhost:28943"
verify_tx_proofs = true

[rpc]
endpoint = { host = "<IP_ADDRESS>", port = 57291 }
block_producer_url = "http://localhost:48046"
store_url = "http://localhost:28943"

[store]
endpoint = { host = "localhost", port = 28943 }
database_filepath = "miden-store.sqlite3"
genesis_filepath = "genesis.dat"

block_producer and rpc have the url of the store for example.
This could lead to easy mistakes when typing out the configuration or by having wrong url's.
A way to solve this would be to let the components infer the url of the other components from the configuration file as follows:
[block_producer]
endpoint = { host = "localhost", port = 48046 }
verify_tx_proofs = true

[rpc]
endpoint = { host = "<IP_ADDRESS>", port = 57291 }

[store]
endpoint = { host = "localhost", port = 28943 }
database_filepath = "miden-store.sqlite3"
genesis_filepath = "genesis.dat"

How is this feature used?
This will enable to have slimmer and more readable configuration files, it will also reduce the amount of possible errors.
Anything else?
Initial comment here: https://github.com/0xPolygonMiden/miden-node/pull/323#discussion_r1574248236

Closed by #401.


libvim: shift + J doesn't report a buffer update

Reported by @Muream :
https://cdn.discordapp.com/attachments/427875245169573900/593152954782056463/JRI4p3Ym7k.mp4
Repro:

Press J (shift + J)

Expected:
Should see joined line
Actual:
Looks like line disappears
It seems like a bug in libvim - we should be getting a buffer update for the above line, but we aren't in that case.

Fixed with https://github.com/onivim/reason-libvim/pull/33

This also impacted several other commands, like gq

Fix is in via #367


UP-4929 : Build unit test cases for org.apereo.portal.portlets.account

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included
[ ] documentation is changed or added
[ ] message properties have been updated with new phrases
[ ] view conforms with WCAG 2.0 AA

Description of change

Adding new unit test cases for org.apereo.portal.portlets.account package

I checked with @bjagg and @nisithdash offline, there are no additional changes requested. :white_check_mark:
Merging now, thanks @nisithdash! :bowing_man:


Add overrides with userID

Changes proposed in this pull request:

Add overrides with userID (to the create-runtime step). UserID (which is a user email sent from CIS in ERSContext block) is passed to override to the cluster-users Kyma component. UserID will be assigned to super admin ClusterRole.

/retest

deprecated, replace by #722


Clean up staging tests considering limited capacity

Due to limited capacity in staging, there is no need to run every single test (in prod) here.
As of now, all mac_android and mac_ios tests are enabled in staging pool, whereas only a limited number of linux_android test is running.
We need to limit the number of test in staging and leave capacity for those that have to run here:

tests (https://github.com/flutter/flutter/issues/88296) that need to be run in staging and upload benchmark metrics.
new tests that need to be run in staging, which need to be validated unflaky before enabled in prod.

This bug tracks to clean up unnecessary tests in staging.

/cc @CaseyHillers

Let's keep them all in staging until we move the M1s to prod.

Closing as obsolete.


feat: migrate tauri to v2

Most notable changes include:

More fine grained permission system with files under capabilities (I placed each set of permissions into their own file respectively)
Update mechanism changed slightly
Access to store changed slightly

Tested on Linux, if needed, I can also test on Mac

@curtisy1 I have tested it on my local(Linux-PopOs) & everything looks good. Can you please test it on your Mac to see everything is working? Can you please also update the README to point it to Tauri V2?

Took a while since I'm not used to using macOS :smile:  Tested it on macOS with a few basic containers and images. Was able to start them, delete them, view stats and logs. UI also looked the same as with Tauri v2.
Also updated the README link to point to v2


Installs translation modules

This PR just downloads Entity Translation and Title module
Modules will be installed and enabled as a dependency for DoSomething Global feature module.
On the contrary to #4768, it will not affect US users.

I updated Title module to dev branch because of an issue with table layout on content type manage fields page.
Here's alpha:

And dev:

:+1:


general question about display_object_detections

regarding display_object_detections method
Is there an option to only show predictions of a particular class?
For example, show predictions of detection_class="Person".
(So that for every image bounding boxes are drawn for predicted objects of type person but not for predicted objects of any other type.)

Do not think so.
From: haghad<EMAIL_ADDRESS>Sent: Friday, April 05, 2019 1:56 PM
To: sassoftware/python-dlpy<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [sassoftware/python-dlpy] general question about display_object_detections (#126)
EXTERNAL
regarding display_object_detections method
Is there an option to only show predictions of a particular class?
For example, show predictions of detection_class="Person".
(So that for every image bounding boxes are drawn for predicted objects of type person but not for predicted objects of any other type.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/sassoftware/python-dlpy/issues/126, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkXhu1rsTctE2DTA8pX7FqlaMn9zU-HUks5vd449gaJpZM4cfcHi.

@haghad you can achieve something similar by filtering the resulting detection table (e.g., where='Object0=="Person"').
That said, if you think this is an important for this and future projects of yours, we can mark this as 'future'.
Please let us know.
Thanks

@haghad can we close this issue? do you have any further questions?

@haghad closing the issue. if you have any further questions, please open a new one, or re-open this one. thanks


HHH-18780 Use column type information to generate union subclass null casts

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-18780

Note that tests are currently failing because this requires https://github.com/hibernate/hibernate-orm/pull/9335


BrannBronzeBeard target selection

Our current implementation triggers battlecries N times on the same targets when brann bronzebeard is active.   Should you instead be able to select targets N times?

If it's targeted, then it's N times on the same target. If non targeted,  N
random valid targets.
On Sat, Apr 24, 2021, 10:20 PM Jeremy Salwen @.***>
wrote:

Assigned #53
https://github.com/JDBumgardner/stone_ground_hearth_battles/issues/53
to @jazzcs https://github.com/jazzcs.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/JDBumgardner/stone_ground_hearth_battles/issues/53#event-4640610767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEEW7LDV37TRGW4KR67IDPDTKN355ANCNFSM43QYEESQ
.

Ok great, this is already what we have!


Discovery Client

Is there any available plugin to register the current service in a Discovery Server and providing in return a Discovery Client? Specifically for Netflix Eureka?
Something to basically do the heavy lift of creating the needed classes and handling parameters and defaults?

@m-rossini Nothing that I am aware of. Are you talking about something similar to this? https://spring.io/guides/gs/service-registration-and-discovery/

Yes, I am. I just wrote a simple, very simple plugin that I can reuse. Thinking about that I am not sure if Javalin should provide that or some 3rd party contributors. BTW is there any module such as javalin-3rd-party available or planned?

@m-rossini we are working on a plugin marketplace for Javalin 5:

The idea is that people will be invited into the Javalin organization, and allowed to create a repository for their plugin there. If you are interested in sharing your Eureka plugin, I can create javalin/eureka and make you an admin for it.

That sounds great

I've created https://github.com/javalin/javalin-eureka and made you a maintainer :)


Update golang to 1.21.0

What this PR does / why we need it:
Update golang to 1.21.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Lakom binaries are now build with golang 1.21.0.

The verify step says that make revendor should be ran


secrets.provider value is lost on page reload with vscode not running

When VSCode is running in code serve-web - secrets.provider will be lost if backend is offline during page load.
Version: 1.93.0
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: server-distro
Steps to reproduce

Run code serve-web
In the browser set local storage value to something using devtools - see code snippet below. This simulates a plugin storing some value using storage API.
While VSCode is still running close your browser window.
Without re-opening the browser stop VSCode (e.g. with ctrl+c)
Without re-launching VSCode open the browser. The page is cached and javascript will run, but since the server isn't running it will fail with the following error (expected): "An unexpected error occurred that requires a reload of this page. The workbench failed to connect to the server (Error: WebSocket close with status code 1006)"
Launch VSCode again and refresh the page, read the value in the devtools localStorage.getItem("secrets.provider")

Full snippet to get a properly encoded value - the logic comes from https://github.com/microsoft/vscode/blob/be0d1775008364fe1fb74c7f7a1f37e9fb6a9950/src/vs/code/browser/workbench/workbench.ts#L111

const iv = window.crypto.getRandomValues(new Uint8Array(12));

const clientKeyObj = await window.crypto.subtle.generateKey({
        name: 'AES-GCM',
        length: 256
    },
    true,
    ['encrypt', 'decrypt']
);

const clientKey = new Uint8Array(await window.crypto.subtle.exportKey('raw', clientKeyObj));

const res = await fetch("/_vscode-cli/mint-key", {
    credentials: 'include',
    method: 'POST'
});
if (res.status == 200) {
    const serverKey = new Uint8Array(await await res.arrayBuffer());
    const keyData = new Uint8Array(32);

    for (let i = 0; i < keyData.byteLength; i++) {
        keyData[i] = clientKey[i] ^ serverKey[i];
    }

    const key = await window.crypto.subtle.importKey(
        'raw',
        keyData, {
            name: 'AES-GCM',
            length: 256,
        },
        true,
        ['encrypt', 'decrypt']
    );
    const dataUint8Array = new TextEncoder().encode('{"foo":"bar"}');

    const cipherText = await window.crypto.subtle.encrypt({
            name: 'AES-GCM',
            iv
        },
        key,
        dataUint8Array
    );
    const result = new Uint8Array([...clientKey, ...iv, ...new Uint8Array(cipherText)]);

    localStorage.setItem("secrets.provider", btoa(String.fromCharCode.apply(null, result)))
} else {
    console.log(res)
}

Expected behavior
I expect the sequence of steps above to "work", in the sense that the secrets.provider value isn't lost and can be used by the plugin when VSCode is back online.
Actual behavior
On step (5) when the browser is opened with VSCode offline - the page is still cached, so the javascript is running - it tries to communicate with the server, specifically make a getServerKeyPart (https://github.com/microsoft/vscode/blob/be0d1775008364fe1fb74c7f7a1f37e9fb6a9950/src/vs/code/browser/workbench/workbench.ts#L116) call that fails (since the backend isn't running) - which results in a panic and secrets.provider value is wiped out of the local store.
As a result when VSCode is back online, whatever information was expected to be present by the plugin on step (6) is now missing, which results in things like having to re-authenticate with 3rd party services, etc.

We should handle transient network errors and not delete secrets from local storage when they happen. I think this:
https://github.com/microsoft/vscode/blob/084f480478532eb71ab4af59f01e8504e48db230/src/vs/code/browser/workbench/workbench.ts#L143-L164
could throw a well known error that we catch here:
https://github.com/microsoft/vscode/blob/be0d1775008364fe1fb74c7f7a1f37e9fb6a9950/src/vs/code/browser/workbench/workbench.ts#L189-L190


Backend AI integration with main

Changes for review:
backend directory:

Logick for server using express
API call for AI found in main-ai.mjs
AI configuration
Details found in backend_instructions.txt

Root directory:

Two test files named aitest.html and aitest.js for testing backend with frontend. These can be deleted, but should be kept for development purposes.
.env file added for setting port and api key (Noroff teachers will fix API key so everyone can test)
Package.json has some changes:

installed cors, dotnev, express, nodemon and undici
For scripts, start-server and start-server-dev are added and can be run to start the backend server

CONCLUSION
Backend works! express server works, communication with the AI-bot/AIMOT works with the aitest.html & aitest.js, personality of the ai is set in AI.personality.mjs and scripts are added in package.json NB! Cannot test AI API call without API key in .env file. Teachers must fix this.

There's a minor typo in AI-personality.mjs ("Alays" should be "Always").


Include global class resources in Resource property inspector

Much like how script defined global classes can be created from the
"New Resource..." button in the FileSystem panel, this allows the
creation of script defined resources to be embedded.

looks good, i thought it was working already but i guess i may have been wrong

Thanks!

Look at again for 3.1.2

Cherry-picked for 3.1.2.


[Trivial] Update gym notebook for online doc integration

Slight modifications to gym notebook for good integration in online doc thanks to PR #85:

The name is prefixed by 2_ to be seen as second notebook
The description is slightly modified (the order of sentences changed,  "three reasons" changed to "two reasons" as there are only 2 stated

Approved for merge (after linting)!


msn animated logo disappears when you click on any server

it appears all the images i have used for buttons and such are missing! im going to find a website to host them instead of discord and ill get back to you

@CogumeloDoZap let me know if it works!

it keeps the same.

i hate to ask but have you downloaded the updated discordlivemessenger.theme.css ? i made some changes so you wont have to install each new update manually 😅 sorry!

i should copy discordlivemessenger.theme.css into Custom CSS editor, right?

that works too! but you can also download it as a theme as well

seems to work partially when i copy dlm-general.css into custom css editor

what does your discord look like right now?

Discord didn't changed with discordlivemessenger.theme.cs

strange 🤔

okay i found out the solution
better discord doesn't accept raw links, and i need to switch my links to github pages instead.
getting on that now

this icon wasn't visible a second ago, just appeared after sometime with discord running.

its finally working 😩 try copying these and lemme know if anything happens
@import url('https://numoder.github.io/dlm7-theme/dlm-general.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-icons.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-server.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-friends.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-settings.css');

Sorry if i say something that might sound rude, my english is not one of the best

omg this shouldnt have taken so long 😭 try copying these and let me know if it works
@import url('https://numoder.github.io/dlm7-theme/dlm-general.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-icons.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-server.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-friends.css');
@import url('https://numoder.github.io/dlm7-theme/dlm-settings.css');

seems it's working well now. Issue closed?

yep! gotit


[ko] Translate 'distributed-system'

Relevant with: https://github.com/cncf/glossary/discussions/1116#discussioncomment-3230672

Hi @Chiwon-Park
Thank you for the contribution.
I think your feature branch is not based on dev-ko branch. (maybe the base is main)
When you try to merge commits into upstream/dev-ko branch, your local feature branch should be dev-ko branch.
So, please update this PR :) .. or you can close this PR and open a new PR with an appropriate configuration.

In addition, please use -s option (git commit -s -m "xxx") to provide the signoff of you to your commit. :)


replace ConnectionInstructions with  ConnectionURI

Now that we have ConnectionURI to allow a direct SSH session
manager connection we no longer need the ConnectionInstructions

replacing this PR with PR https://github.com/Sage-Bionetworks/service-catalog-library/pull/174


Switch submodule from ssh to https

This change does not affect the code, but it allows you to "go get" or "dep" without the need to register the ssh-key in the github. Without this I was getting errors:
go get github.com/k33nice/go-livr
Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:koorchik/LIVR.git' into submodule path '/Users/pavel.boev/go/src/github.com/k33nice/go-livr/test/livr' failed Failed to clone 'test/livr' a second time, aborting package github.com/k33nice/go-livr: exit status 1

@R4scal Yea, you'r right! Thx for fixing this 👍


Are there plans for another release?

I just wanted to check if there were plans for a release sometime soon. The last one was seven months ago and there have been many changes since then that I would love to take advantage of!

@UnsolvedCypher there have only been some new PRs merged in the last week with some updates. I am sure @levithomason will be shipping another update but I do not know what else we will want to include in the release specifically. If you are subscribed to the repo for releases, you'll get a notice when something new goes out.

@UnsolvedCypher Once I will complete #3919 there will be a release to get rid of there warnings.

<EMAIL_ADDRESS>was released 🎉


"Not-found.tsx" file not working in "src/app/(app)" folder

Link to reproduction
No response
Payload Version
3.0.0-beta.32
Node Version
20.13.1
Next.js Version
14.3.0-canary.37
Describe the Bug
Hi,
I tried adding a "not-found.tsx" file inside my "src/app/(app)" folder, but this doesn't seem to work. It still shows me the default 404 NextJS page.
Am I missing something or putting the file in the wrong directory?

Reproduction Steps
Put a "not-found.tsx" file in the "src/app/(app)" folder.
Adapters and Plugins
No response

this is a problem related to next.js multi layout: https://github.com/vercel/next.js/discussions/50034

Hey @dmvdven I went ahead and tested this just now and @domenico-ruggiano is right in that this is a Next.js issue. There is, however, a workaround posted in that discussion which worked for me as a temporary solution.
From victorandree:

You can add a dynamic catch-all route to catch all and in this route you can call notFound. This triggers the closest not-found.tsx.

app
├── (app1)
│   ├── [...not-found]
│   │   └── page.tsx
│   ├── layout.tsx
│   ├── not-found.tsx
│   └── page.tsx
└── (app2)
   ├── admin
   │   └── page.tsx
   └── layout.tsx

In (app1)/[...not-found]/page.tsx:
import { notFound } from 'next/navigation';

export default function NotFoundDummy() {
 notFound();
}


CSS Variable Support

When using a SSR'ed page with dark mode support, as WebAssembly bundles are non render blocking content, users that defaults to dark mode will see a flash of light mode page.
The solution is to use CSS Variables (alongside a small render blocking JavaScript script to help detect which theme to use) which can be loaded before the page is rendered.
However, I find it difficult to ensure a globally unique css variable name across the entire application.
This issue aims to introduce a CssVariables derive macro that helps with the implementation.

It seems generating unique names will be needed more often. I've also needed it to generate unique names for animations. It could make sense to have a more general setup, if it's not too complicated with the different naming schemes.

I thought we are adding a keyframes! to generate keyframes?

I think a full variable management system is worth the R&D.
In general, I've seen a use-case for this, and it's faster to let the browser update via variables? (#79)
Here's a use-case I've battled with, and I'm not sure if there's a better way.
I set a global variable for font size, :root {--ff: 1em}, and upscaled for media queries, @media (min-width: 768px) { :root { --fs: 1.04em } }.
I'd love a way to respond to the variable changes, and use these variables in other classes, e.g.
#[function_component(Icon)]
pub fn icon(props: &Props) -> Html {
    let font_size = variables::get("--fs");
    html! {
        <i class={css!("height: ${fs}; width: ${fs};", fs=font_size)}>
            /* Icon SVG Mask */
        </i>
    }

The best way I've circumnavigated this, so far, is I've actually stored my font sizes in my theme context and used the theme to set my icon's SVG height and width, but I can't get different sizes relative to the media queries this way.

I have implemented what described in this issue a couple month ago but only had time to copy the implementation into this repository last week.
You can find the work under the branch css-vars.
Feel free to give it a shot and let me know how it works.
The css_var! macro is not documented and can be used with css_var!(theme.color).

Brilliant, I may have time to give this a shot and give feedback.

do you have an example of how to use css_var! with yew?


Got some questions.

Hello, I'm Sairam, I'm implementing your todo's right now, as I went on checking the todo, I saw there're three options which I'm unable to understand right now.
They're:

Follow Camera
Picture in Picture
Jump to random location.

Would you like to clear them out?, so I can implement them as well, in my PR.
I'm happy to implement others, and make a pull request soon.
Thank you very much for making this awesome RTS Camera.

No longer maintained?

I had made this rts camera as a small project, I didn't know people were interested so kinda stopped working on it. But since you are I am willing to start it again. I am really happy to see someone check my repo. I'll try to work on it again, thanks to you.

I am extremely sorry I did not see your comment from a month ago.

That's alright. I wanted to contribute something.

Would you like to clarify my doubts? So I can start the work.

Yea sure ask me anything, ill try my best to answer it.

Follow Camera
Picture in Picture
Jump to random location.
Would you like to tell me how these work?

Follow Camera: This means that if, let's say you have many people moving around on the screen, or like multiple cars or any other moving object if you control + click on that the camera would start following it.
Jump to a random location: This would mean if you control + click on any place on the ground or the map the camera would jump to that position.
Picture in Picture: By this, I meant that you could have a second camera on command, which would either be static or follow an object moving around.

Cool, but little confusing.


Repeated creation of scan-vulnerabilityreport pods

Hi,
after upgrading to the latest version of the operator, we've stumbled upon the following behaviour:

vulnerability-report pods were spawned continuously

$ kubectl get pods

NAME                                                             READY   STATUS      RESTARTS   AGE
scan-vulnerabilityreport-54cfcf859c-pzj92                        0/1     Init:0/1    0          42s
scan-vulnerabilityreport-66fc6b4dcc-cpqbc                        0/1     Init:0/1    0          46s
scan-vulnerabilityreport-6b44d4cb75-w9g8n                        1/1     Running     0          12s
scan-vulnerabilityreport-76f5956dbf-gk5bx                        0/1     Completed   0          46s
scan-vulnerabilityreport-7f8d7cf6fd-dhpgj                        0/1     Completed   0          49s
scan-vulnerabilityreport-8596cc7758-xp6rh                        0/1     Init:0/1    0          8s
scan-vulnerabilityreport-9fdbbb4d8-6fd9z                         0/1     Init:0/1    0          43s
scan-vulnerabilityreport-c66b9cf44-z8n2g                         0/1     Init:0/1    0          41s
scan-vulnerabilityreport-d48d95446-9vx9w                         0/1     Completed   0          47s
scan-vulnerabilityreport-db88687bd-mhrpz                         0/1     Init:0/1    0          9s
trivy-operator-57f76cd687-2nr78                                  1/1     Running     0          51m

Even after several hours, the same behavior persisted

there were no new deployments on that cluster
I've inspected the scan-vulnerability pods to check, whats going on

$ kubectl logs scan-vulnerabilityreport-78569dffcb-wrvpd

{
  "SchemaVersion": 2,
  "CreatedAt": "2024-01-25T08:24:15.355624798Z",
  "ArtifactName": "/sbom-celery/sbom-celery.json",
  "ArtifactType": "cyclonedx",
  "Metadata": {
    "OS": {
      "Family": "debian",
      "Name": "11.7"
    },
    "ImageConfig": {
      "architecture": "",
      "created": "0001-01-01T00:00:00Z",
      ...
}

all those reports had a relating "sbom" artifact name
After configuring sbomGenerationEnabled: false , this behaviour stopped

Environment:

Trivy-Operator version

Chart version 0.20.2
App version 0.18.2

Kubernetes version v1.28.3

@szEvEz can you please provide more info/context on log ?

are vulnerability reports get generated ?
is it reproducible. ?

@szEvEz node the reconciliation do not happen only on a new deployment it also happen when report TTL has exceeded.
the scan job (above) is triggered when report TTL exceeded and it reusing the existing sbom to make scanning faster rather then downloading image again and inspecting it.

We have the same problem. In our case, disabling the flag 'clusterSbomCacheEnabled' helped in stopping the continued spawning of new scan-jobs. Have you any news on this issue?


Traffic shaping with Calico and k8s

Hello,
I have been trying to test the traffic shaping feature based on the test provided in #797 and the result is different than what is expected. I am suing k8s version 1.21.1 and the calico version 3.14. The cluster was created using kubeadm and I am using a VM for as a worker node and another VM as the controller in OpenStack
The /etc/cni/net.d/10-calico.conflist contains:

the result with traffic shaping enabled and setup to 1M on the iperf-server pod is:

and without traffic shaping the result is:

Also bandwidth file exists in /opt/cni/bin/ path as well.
As seen in the results, the bandwidth is more than the setup threshold and I was curios to know what could be the reason.
Could you please help me resolve the problem?
Thank you so much

Update:
I set the threshold to 50 Mbits/sec and the first measurements seemed too far from the threshold. However, the next bandwidths were within the setup range. Any ideas why this might be happening that only the first connection is consuming way more bandwidth than the threshold?

I noticed that you mention you're using OpenShift, and reading through the discussion on the issue you linked this comment:
https://github.com/projectcalico/calico/issues/797#issuecomment-494028690
Suggested that the bandwidth feature was originally only supported with docker as the container runtime, though I'm not sure what the state of the bandwidth feature is today with respect to various different runtimes.
Are you able to run tc qdisc show in your iperf-server pod to verify if the rules were installed correctly?

Is this enabled by default now? if not is there a documentation on how to do it for AWS EKS installation of calico?


Drop Python2.7 support.

I was just going to comment on super() :+1:
There's also the following:

A couple of files (setup.py, and a couple of the migration files) with the utf coding comment at the top.
a __future__ import in cleanup_django_defener.py which can be removed


Automated Package Upgrade

:tada: This PR is included in version 12.4.148 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature] Bring back old voice chat UI

Before Requesting

[X] I found no existing issue matching my feature request

Describe the feature you'd like!
the new background/rectangles outside the circle pfp is just annoying and takes so much space, is there a way to bring back the old one?
images are for reference
Anything else?

This is something a theme can do. Not something for BD to do


Uncaught TypeError: convert.metric is not a function

I got an error like

Uncaught TypeError: convert.metric is not a function

when I executed
convert.metric(1, "cm", "m");
in js console, as it is mentioned in the readme.md. It worked fine when I used this instead.
convert.Metric(1, "cm", "m");  // 0.01
I think you just need to update the readme.md file.
Thanks!

Thanks.
Update Readme.md convert.metric --> convert.Metric


Validation - Multiple issue fixes

Docs Build status updates of commit eab2e29:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/articles/bing-maps-on-azure-marketplace.md
:bulb:Suggestion
View
Details

BingMaps/sdk-native/map-control-concepts/user-location.md
:bulb:Suggestion
View
Details

BingMaps/spatial-data-services/query-api/query-options.md
:bulb:Suggestion
View
Details

BingMaps/articles/bing-maps-on-azure-marketplace.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 53, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-maps/' will be broken in isolated environments. Replace with a relative link.
Line 54, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-maps/quick-demo-map-app' will be broken in isolated environments. Replace with a relative link.
Line 60, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/bingmaps/' will be broken in isolated environments. Replace with a relative link.

BingMaps/sdk-native/map-control-concepts/user-location.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

BingMaps/spatial-data-services/query-api/query-options.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 60, Column 2: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b780249:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/articles/bing-maps-on-azure-marketplace.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-concepts/user-location.md
:white_check_mark:Succeeded
View

BingMaps/spatial-data-services/query-api/query-options.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bc70db4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/articles/create-an-optimized-itinerary.md
:warning:Warning
View
Details

BingMaps/articles/bing-maps-on-azure-marketplace.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-concepts/user-location.md
:white_check_mark:Succeeded
View

BingMaps/spatial-data-services/query-api/query-options.md
:white_check_mark:Succeeded
View

BingMaps/articles/create-an-optimized-itinerary.md

Line 72, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'yuan_starting_image.png' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 81, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'charlie_starting_image.png' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 90, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'andre_starting_image.png' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c1f5dcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/articles/bing-maps-on-azure-marketplace.md
:white_check_mark:Succeeded
View

BingMaps/articles/create-an-optimized-itinerary.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-concepts/user-location.md
:white_check_mark:Succeeded
View

BingMaps/spatial-data-services/query-api/query-options.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@stevemunk  @eriklindeman
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!

@stevemunk @eriklindeman
Friendly reminder that this PR is ready for final review. Please let me know if there are any additional changes that you would like to see.
Thanks.


IE11 fullscreen fix

Fixes the fullscreen buttons for IE11, which has its own set of prefixes:

Entering fullscreen
Fullscreen change event
Exiting fullscreen

IE versions before and after 11 shouldn't be affected.

IE 11 is pretty well-behaved. I used a polyfill to handle this in my own fork.


testing nav doc

No intention to be merged as is, it's more showcasing "enhanced" navigation on the default UI of antora.
PR show the addition of nav.adoc file + multiple named module to split the wiki.
One per faq, and, and regrouped with the one in ROOT.
On the default UI it will look like that. Menu could be full extended

On a page you will have context breadcumb + outlined menu item that maybe nice to have

Will remove the javascript hack to generate FAQ section to have them in easy to modify/understand nav.adoc file. (A file could be referenced multiple time)
Will cost the move of file + nav.doc creation redirect maybe using :page-aliases:
Will cost the the modification of UI to "enchance" our layout to a one with some of the antora default.

This I guess could be extended to the tutorials later.

How It may looks like NetBeans l&f (very rough)


hitting OSError: [WinError 126] The specified module could not be found on example run

do I need to install the rust packages also?

EDIT: turns out the answer is yes, this should be included in install instructions

When you run code_generation.py, as mentioned in the install instructions, the rust packages are installed.


Feature: Route to Component Directive

Angular is fully heading to a component-driven architecture. The Angular 1.4 and 2.0 router (same router) will allow routing to components (aka directives with a template and controller). This was actually a great idea from the core team! It makes a lot of sense. I think ui-router would benefit from being able to route to a 'component' as well. With the new angular.component proposal it will be easier for the average developer to make components.
E.g.
$stateProvider.state('home', {
    url: '/',
    component: 'home'
})

angular.directive('home', function(){
    return {
        template: `
Home Sweet Home

                         <ui-view></ui-view>`,
        controller: function($state) {
        }
    }
})

Just an idea...

Would this really be that much different than doing
$stateProvider.state('home', {
    url: '/',
    template: '<home />'
})

angular.directive('home', function(){
    return {
        template: `
Home Sweet Home

                         <ui-view></ui-view>`,
        controller: function($state) {
        }
    }
})

Or would that not work?

@timkindberg nice to see ya!
I agree we should provide a shorthand for components in both angular 1.x and 2.x, although that still seems to be a moving target at this point.
@eddiemonge I don't know all the details, but if you look at the tutorials around ngNewRouter, there seem to be a few ways to define a component in 1.x and 2.x and they don't all seem to involve directives.  I'd say this should be an "open issue" and thanks Tim for bringing it up

With the introduction of (ng-forward)[https://github.com/ngUpgraders/ng-forward] I want to bring this issue back.
I started a corresponding issue https://github.com/ngUpgraders/ng-forward/issues/42 so we can start to discuss what can be done to make this happen.

Yeah, sounds good. I've seen one or two @State implementations in different A1/ES6 projects. I skimmed the discussion in the other issue. Let me know what you guys need from us.

The Angular Core team introduced the component method in AngularJS 1.5.0.
@timkindberg's original post now makes even more sense.

its definitely on my radar for 1.0+

This landed a while ago, so closing


Terraform Example Code Optimized

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@ocofaigh can you please review this too. Thanks

/run pipeline

/run pipeline

In PR test TestFSCloudInSchematics, need to pass region and prefix variable value.

@ocofaigh can you please try rerun the pipeline, i have added the prefix value in test

@marifse This has conflict again - to avoid this please do not commit updates to the common-dev-assets git submodule in your PRs

@ocofaigh can you kindly rerun the pipeline, have fixed the conflicts.

/run pipeline

@marifse can you address failing pre commit hooks please?
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/go.mod
Fixing tests/go.sum

/run pipeline

@marifse Now that prefix and region are required variables, you will need to update the TestFSCloudInSchematics test here to pass the prefix like so:
{Name: "prefix", Value: options.Prefix, DataType: "string"},
{Name: "region", Value: options.Region, DataType: "string"},

@ocofaigh variables added, can you please rerun

/run pipeline

:tada: This PR is included in version 1.21.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


W-13670063-Review Design an API Specification tutorial - CP

Closing this PR since changes will be recorded at https://github.com/mulesoft/docs-code-builder/pull/55

more improvements will be needed for next beta and GA. We'll make those in a new PR.
Thanks everyone for these contributions!


High cpu usage from watch tasks

When running gulp serve the cpu usage is very high. I think this is connected to the watch tasks.
With 5.0.0 we introduced polling on Windows machines to significantly decrease the tasks runtime, which is causing this issue: Without polling ~20%, with polling ~60%.
Without polling some tasks are taking longer and longer with each execution.
Possible solution is to use polling and reduce the interval time (see https://github.com/gulpjs/gulp/issues/634#issuecomment-53163488)

Reducing interval time to 500ms changes cpu usage to ~30%

fixed with #19


when will it update to 1.20?

when will it update to 1.20?

Hello!
I think I can try to update the mod later, do you need the 1.20 or 1.20.1 version?

1.20.1 version

plsss 1.20.1 versioonn

Mod updated to 1.20.1


Using flow, Record#set and Record#merge return intersection types (v4)

What happened
In trying to upgrade draft-js to 4.0.0-rc.7 (and flow 0.57.1), I ran into many errors all around the fact that calling .set() or .merge() on a Record returns an intersection type that then causes errors for any other typing that refers to the original Record, or in the case of draft, that refers to a class that extends the Record, which is the common pattern in that codebase. For example:
[ContentState.js](https://github.com/facebook/draft-js/blob/master/src/model/immutable/ContentState.js), the Record-based class:
const defaultRecord: {
  entityMap: ?any,
  blockMap: ?BlockMap,
  selectionBefore: ?SelectionState,
  selectionAfter: ?SelectionState,
} = {
  entityMap: null,
  blockMap: null,
  selectionBefore: null,
  selectionAfter: null,
};

const ContentStateRecord = Record(defaultRecord);

class ContentState extends ContentStateRecord {
  ...
}

[updateEntityDataInContentState.js](https://github.com/facebook/draft-js/blob/master/src/model/transaction/updateEntityDataInContentState.js):
import type ContentState from 'ContentState';

function updateEntityDataInContentState(
  contentState: ContentState,
  key: string,
  data: {[key: string]: any},
  merge: boolean,
): ContentState {
  const instance = contentState.getEntity(key);
  const entityData = instance.getData();
  const newData = merge ?
    {...entityData, ...data} :
    data;

  const newInstance = instance.set('data', newData);
  const newEntityMap = contentState.getEntityMap().set(key, newInstance);
  return contentState.set('entityMap', newEntityMap);
}

Which leads to:
Error: src/model/transaction/updateEntityDataInContentState.js:32
 32:   return contentState.set('entityMap', newEntityMap);
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ intersection. This type is incompatible with
 23: ): ContentState {
        ^^^^^^^^^^^^ ContentState
  Member 1:
  1395:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ `this` type. See: node_modules/immutable/dist/immutable.js.flow:1395
  Error:
  1395:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ RecordInstance. This type is incompatible with the expected return type of. See: node_modules/immutable/dist/immutable.js.flow:1395
   23: ): ContentState {
          ^^^^^^^^^^^^ ContentState
  Member 2:
   60: const ContentStateRecord = Record(defaultRecord);
                                  ^^^^^^^^^^^^^^^^^^^^^ type parameter `Values` of function call. See: src/model/immutable/ContentState.js:60
  Error:
  1387:   get<K: $Keys<T>>(key: K): $ElementType<T, K>;
                                    ^^^^^^^^^^^^^^^^^^ element type. Indexable signature not found in. See: node_modules/immutable/dist/immutable.js.flow:1387
   23: ): ContentState {
          ^^^^^^^^^^^^ ContentState

Is there a way to cast the result of every set and merge operation somehow to ensure that the value can still be typed as the original record type? Or any other recommended way to get around this issue?
Also, @leebyron, is opening issues here a useful way for me to report issues I come across as I work through getting draft.js upgraded (facebook/draft-js#1439)? @flarnie mentioned that you were open to suggestions or questions; if there’s a better venue for that, please let me know. Thanks!

These intersection types are a feature of v4 to get much better Record typing, though unfortunately there are still tradeoffs. One of those tradeoffs is that Record subclassing is not very well supported.
Essentially every new Record factory is a constructor of a subclass of RecordInstance, but Flow does not have a way to dynamically create subclass types, so the work around is this intersection type which emulates a subclass.
Typically these Record subclasses are just collections of methods, one strategy for updating them might be to convert the subclass into just a collection of functions which takes a Record as a first argument. Though I know that could be a really invasive change to Draft.js which heavily relies on record methods.
I'm definitely open to suggestions for improving the types for Record subclassing if you have ideas

I've asked @calebmer to help figure out a way to improve this, since I understand subclassing is a really common existing pattern.
So far we've realized that the this binding in the resulting class is not what we expected: https://flow.org/try/#0CYUwxgNghgTiAEkoGdnwBrwN4Ch72RABcAKASgC54iALAS2QG4cBfHHUJOeAMwFcAdmCJ0A9gPgAlcKJjByVAMLRUAHnQA+ZjjDjkReAE14AXiky55bUlTwAWvBAAPIiAHA0xrGxwkBIAHd7cgA6QlJKezJmIA

One work around I've figured out is to override the problem methods directly to the subclass:
class ContentState extends ContentStateRecord {
  set(k, v): this {
    return super.set(k, v);
  }
}

The root issue is that Flow misunderstands the type this refers to for the subclass, and overriding removes that misunderstanding, even though it's not doing anything new.

Is this related to
call of method `set`
Method cannot be called on any member of intersection type
intersection

@athomann - hard to know without more information

@leebyron Here is a sample reducer that reproduces the issue.  I have some Records that have deeply nested Records
// @flow
import { Record, type RecordOf, type RecordFactory } from 'immutable';

type State = {
  nest: RecordOf<Nest>,
};

type DeepNest = {
  foo: number,
};

const deepNest: RecordFactory<DeepNest> = Record({
  foo: 0,
});

type Nest = {
  deepNest: RecordOf<DeepNest>,
};

const nest: RecordFactory<Nest> = Record({
  deepNest: deepNest({}),
});

const initialState: RecordFactory<State> = Record({
  nest: nest(),
});

function testReducer(state: RecordOf<State> = initialState(), action: Object) {
  switch (action.type) {
    case 'ACTION_TYPE':
      return state.setIn(['nest', 'deepNest', 'foo'], 5);
    default:
      return state;
  }
}

export default testReducer;

The error occurs on return state.setIn(['nest', 'deepNest', 'foo'], 5); and I receive
call of method `setIn`
Method cannot be called on any member of intersection type intersection
Member 1: type application of class `RecordInstance`
Error: call of method `setIn`
Function cannot be called on any member of intersection type intersection
Member 2: type parameter `Values` of call of method `setIn`
Error: property `setIn`
Property not found in object type

Does setIn not work for deeply nested Records?  Are records not intended to be used in this way?

@athomann - that definitely looks like  a typing bug, but I'm not certain what it is yet. Either way it's different from this one - would you mind opening a new issue?

@leebyron I tried your workaround of overriding set and merge directly on the Record subclass, and that does prevent flow from reporting errors when invoking set() and merge() on instances of the class. However, I now am seeing errors when constructing a new instance:
Error: src/model/paste/DraftPasteProcessor.js:55
                                     v
 55:         return new ContentBlock({
 56:           key: generateRandomKey(),
 57:           type,
...:
 60:         });
             ^ object literal. This type is incompatible with the expected param type of
1399:   constructor (values?: Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>): void;
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ union: type application of identifier `Iterable` | type parameter `Values` of function call. See: node_modules/immutable/dist/immutable.js.flow:1399
  Member 1:
  1399:   constructor (values?: Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>): void;
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type application of identifier `Iterable`. See: node_modules/immutable/dist/immutable.js.flow:1399
  Error:
                                       v
   55:         return new ContentBlock({
   56:           key: generateRandomKey(),
   57:           type,
  ...:
   60:         });
               ^ object literal. This type is incompatible with
  1399:   constructor (values?: Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>): void;
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ $Iterable. See: node_modules/immutable/dist/immutable.js.flow:1399
    Property `@@iterator` is incompatible:
      1399:   constructor (values?: Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>): void;
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ property `@@iterator` of $Iterable. Property not found in. See: node_modules/immutable/dist/immutable.js.flow:1399
                                           v
       55:         return new ContentBlock({
       56:           key: generateRandomKey(),
       57:           type,
      ...:
       60:         });
                   ^ object literal
  Member 2:
   48: var ContentBlockRecord = Record(defaultRecord);
                                ^^^^^^^^^^^^^^^^^^^^^ type parameter `Values` of function call. See: src/model/immutable/ContentBlock.js:48
  Error:
                                       v
   55:         return new ContentBlock({
   56:           key: generateRandomKey(),
   57:           type,
  ...:
   60:         });
               ^ property `characterList` of object literal. Property not found in
   57:   merge(obj: Object): this {
                             ^^^^ ContentBlock. See: src/model/immutable/ContentBlock.js:57

Happy to see progress.
Is there more to that error message? Flow's identifying that it's not Iterable, but I'd expect something to say about the $Shape as well. Maybe I'll flip those back since constructing from a $Shape is probably more common.
Anothing thing we've noticed before is that Flow has trouble pinning down the type of values in the Record. We added some new utility types to help with this. I'm not sure if that's the issue at hand, but it might help:
import type { RecordFactory } from 'immutable';

type ContentBlockFields = {
  key: string,
  type: DraftBlockType,
  text: string,
  characterList: List<CharacterMetadata>,
  depth: number,
  data: Map<any, any>,
};

var defaultRecord: ContentBlockFields = {
  key: '',
  type: 'unstyled',
  text: '',
  characterList: List(),
  depth: 0,
  data: Map(),
};

var ContentBlockRecord: RecordFactory<ContentBlockFields> = Record(defaultRecord);

class ContentBlock extends ContentBlockRecord {
  // Override problematic Record methods directly in the subclass
  // https://github.com/facebook/immutable-js/issues/1388#issuecomment-337316952
  set(k, v): this & ContentBlockFields {
    return super.set(k, v);
  }

  merge(obj: Object): this & ContentBlockFields {
    return super.merge(obj);
  }

  ...
}

That’s the whole error message (no mention of $Shape), which is strange.
But either way, good news! Using RecordFactory along with the this & Fields refinement on the set and merge proxy methods got rid of around 60 errors, so it looks like a viable workaround on the whole.

I spoke too soon. Making the above changes did greatly reduce the total error count, but flow still has all kinds of complaints about those subclassed Records.
Error: src/model/immutable/SelectionState.js:47
 47:     return super.set(k, v);
                ^^^^^^^^^^^^^^^ intersection. This type is incompatible with
 46:   set(k: string, v: any): this & Fields {
                               ^^^^ SelectionState
  Member 1:
  1418:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ `this` type. See: node_modules/immutable/dist/immutable.js.flow:1418
  Error:
  1418:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ RecordInstance. This type is incompatible with the expected return type of. See: node_modules/immutable/dist/immutable.js.flow:1418
   46:   set(k: string, v: any): this & Fields {
                                 ^^^^ SelectionState
  Member 2:
   47:     return super.set(k, v);
                  ^^^^^^^^^^^^^^^ type parameter `T` of call of method `set`
  Error:
   40: var SelectionStateRecord: RecordFactory<Fields> = Record(defaultRecord);
                                               ^^^^^^ object type. This type is incompatible with the expected return type of
   46:   set(k: string, v: any): this & Fields {
                                 ^^^^ SelectionState

Error: src/model/immutable/SelectionState.js:47
 47:     return super.set(k, v);
                ^^^^^^^^^^^^^^^ intersection. This type is incompatible with
 46:   set(k: string, v: any): this & Fields {
                               ^^^^ some incompatible instantiation of `this`
  Member 1:
  1418:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ `this` type. See: node_modules/immutable/dist/immutable.js.flow:1418
  Error:
  1418:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
                                                               ^^^^ RecordInstance. This type is incompatible with the expected return type of. See: node_modules/immutable/dist/immutable.js.flow:1418
   46:   set(k: string, v: any): this & Fields {
                                 ^^^^ some incompatible instantiation of `this`
  Member 2:
   47:     return super.set(k, v);
                  ^^^^^^^^^^^^^^^ type parameter `T` of call of method `set`
  Error:
   40: var SelectionStateRecord: RecordFactory<Fields> = Record(defaultRecord);
                                               ^^^^^^ object type. This type is incompatible with the expected return type of
   46:   set(k: string, v: any): this & Fields {
                                 ^^^^ some incompatible instantiation of `this`

Error: src/model/immutable/SelectionState.js:47
 47:     return super.set(k, v);
                          ^ some string with unknown value. Property not found in
1418:   set<K: $Keys<T>>(key: K, value: $ElementType<T, K>): this & T;
               ^^^^^^^^ object type. See: node_modules/immutable/dist/immutable.js.flow:1418

Error: src/model/immutable/SelectionState.js:51
 51:     return super.merge(obj);
                ^^^^^^^^^^^^^^^^ intersection. This type is incompatible with
 50:   merge(obj: Object): this & Fields {
                           ^^^^ SelectionState
  Member 1:
  1420:   merge(...collections: Array<Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>>): this & T;
                                                                                ^^^^ `this` type. See: node_modules/immutable/dist/immutable.js.flow:1420
  Error:
  1420:   merge(...collections: Array<Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>>): this & T;
                                                                                ^^^^ RecordInstance. This type is incompatible with the expected return type of. See: node_modules/immutable/dist/immutable.js.flow:1420
   50:   merge(obj: Object): this & Fields {
                             ^^^^ SelectionState
  Member 2:
   51:     return super.merge(obj);
                  ^^^^^^^^^^^^^^^^ type parameter `T` of call of method `merge`
  Error:
   40: var SelectionStateRecord: RecordFactory<Fields> = Record(defaultRecord);
                                               ^^^^^^ object type. This type is incompatible with the expected return type of
   50:   merge(obj: Object): this & Fields {
                             ^^^^ SelectionState

Error: src/model/immutable/SelectionState.js:51
 51:     return super.merge(obj);
                ^^^^^^^^^^^^^^^^ intersection. This type is incompatible with
 50:   merge(obj: Object): this & Fields {
                           ^^^^ some incompatible instantiation of `this`
  Member 1:
  1420:   merge(...collections: Array<Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>>): this & T;
                                                                                ^^^^ `this` type. See: node_modules/immutable/dist/immutable.js.flow:1420
  Error:
  1420:   merge(...collections: Array<Iterable<[$Keys<T>, $ValOf<T>]> | $Shape<T>>): this & T;
                                                                                ^^^^ RecordInstance. This type is incompatible with the expected return type of. See: node_modules/immutable/dist/immutable.js.flow:1420
   50:   merge(obj: Object): this & Fields {
                             ^^^^ some incompatible instantiation of `this`
  Member 2:
   51:     return super.merge(obj);
                  ^^^^^^^^^^^^^^^^ type parameter `T` of call of method `merge`
  Error:
   40: var SelectionStateRecord: RecordFactory<Fields> = Record(defaultRecord);
                                               ^^^^^^ object type. This type is incompatible with the expected return type of
   50:   merge(obj: Object): this & Fields {
                             ^^^^ some incompatible instantiation of `this`

Yeah - this is the same error as before but now locallzed to your override fix. You can tell Flow to leave you alone since we're already doing silly things to work around it that we know are safe:
  set(k: string, v: any): this & Fields {
    return (super.set(k, v): any);
  }

@acusti - I just put up a PR that should make this considerably easier after brainstorming with some folks on the Flow team. Take a look at the examples in there and let me know if they look reasonable to you


Delete manifests/w/WHTA/Tamara/2<IP_ADDRESS> directory

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://download.tamara.app/2<IP_ADDRESS>/installer.exe
OK
(Automated message - build 911)


Adjust the message for empty table of quality alerts and investigations

As a User of Trace-X
I want to have clear informations displayed for empty tables of quality alerts/investigations
so that I know if there are issues or just no alerts/investigations existing.
Hints / Details

Current state with message "NO RESULTS FOUND. Please try again later." is confusing since it is not clear whether there are technical issues and a reload of page could help or just no quality alerts/investigations existing.
See current message for empty table view:
Proposal for table "received quality alerts" could be e.g. "No quality alerts received yet.".

Acceptance Criteria

[ ] Message for empty quality alerts/investigation tables has been adjusted

Out of Scope

...

Will be handled with the new Concept