Fix NE label

Not entirely sure this is correct, but trying to run the Ginza conllu conversion script failed when it found an L- tag. It looks like the tag parser was looking for an E- tag, and changing that to L- allowed conversion to run without issue.
I guess this was an oversight in moving between tag schemes, but let me know if something else is going on.

Thank you @polm
I've fixed this problem locally but not pushed. Sorry for that.


Cannot override sorting

The component dispatches a copy of the original event, which makes it impossible to call preventDefault on the original.
// In RevoGrid.svelte
const onEvent = (e) => {
  e.stopPropagation();
  dispatch(e.type, e.detail);
};

My current workaround:
<script>
	import { RevoGrid } from '@revolist/svelte-datagrid';

	let grid: RevoGrid;

	$: if (grid != null)
	{
		const gridInstance = grid.getWebComponent();
		gridInstance.addEventListener('beforesorting', onBeforeSorting);
		gridInstance.addEventListener('beforesortingapply', onBeforeSortingApply);
		gridInstance.addEventListener('beforesourcesortingapply', onBeforeSourceSortingApply);
	}
</script>

<RevoGrid bind:this={grid} />

Note:

Component events created with createEventDispatcher create a CustomEvent. These events do not  bubble and are not cancellable with event.preventDefault().

Maybe the original event could be included in the detail, something like this:
// In RevoGrid.svelte
const onEvent = (e) => {
	e.stopPropagation();
	dispatch(e.type, { ...e.detail, originalEvent: e });
};

<script>
	//...
	function onBeforeSorting(e)
	{
		e.details.originalEvent.preventDefault();
		//...
	}
</script>

<RevoGrid bind:this={grid} on:beforeSorting={onBeforeSorting}/>

Not very pretty but might work.

Please post in Revo-grid repo.

This is a Svelte component specific issue, though?


Hbmayes

Added the folder that has my raw files for the image I made. FYI: I used Illustrator.

That was fast, thanks! I don't have illustrator presently, but lots of people do, and at least this way we can't lose it if we ever need it for something. :)
I'll be submitting around 8 or 9 am my time I expect (and offline for a chunk of time between 6 and 6:30 or 8), so if you feel inspired to do any more cleanup feel free. I have another PR in progress that I'll wrap in the next 30 minutes.


add a stub of etcdctlv3 auth enable

This PR  adds a stub of etcdctlv3 auth enable. Related RPC stubs are also implemented.

remove the binary etcdctlv3? (probably add that into gitignore?)

@xiang90 sorry, removed the binary and added the gitignore file

@xiang90 updated the description of auth command

LGTM

defer to @heyitsanthony

lgtm


Missing eventType in the callback payload

My bot received events from MS Teams when I added the bot into a team on MS Teams. However, the callback payload doesn't include the "channelData.eventType" as described in https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/conversations/subscribe-to-conversation-events?tabs=json#team-members-added
Is there anything changes recently or do I miss something? I was included before (a few months back when I tested it)
Here is an example of the teamMemberAdded event
{
  "membersAdded": [
    {
      "id": "29:1YZSGx5JxZvVJTpCfTfjZjUtQ...",
      "aadObjectId": "0ce19686-..."
    },
    {
      "id": "28:79def875-6a91..."
    }
  ],
  "type": "conversationUpdate",
  "timestamp": "2021-02-17T14:20:26.0378605Z",
  "id": "f:1c7aa642-f63b....",
  "channelId": "msteams",
  "serviceUrl": "https://smba.trafficmanager.net/de/",
  "from": {
    "id": "29:1YZSGx5JxZvVJTpCfT...",
    "aadObjectId": "0ce19686-..."
  },
  "conversation": {
    "conversationType": "personal",
    "tenantId": "3ad9c09f-...",
    "id": "a:1I4SKOBkbyT0gxr40tIyZXS..."
  },
  "recipient": {
    "id": "28:79def875-6a91...",
    "name": "Bob"
  },
  "channelData": {
    "tenant": {
      "id": "3ad9c09f-ab9d-..."
    }
  }
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a6d00a4-dd28-33c4-002e-2e8e7c653ce2
Version Independent ID: 0856927a-25f4-b1e0-5f1b-d55dc61796f3
Content: Subscribe to conversation events - Teams
Content Source: msteams-platform/bots/how-to/conversations/subscribe-to-conversation-events.md
Product: msteams
GitHub Login: @WashingtonKayaker
Microsoft Alias: anclear

We are not able to repro the issue at our end. Please check the below screen shot. Also please check this sample for more info.


x/net/http2: decide what to do about Transport.CancelRequest

The net/http.Transport.CancelRequest method is an old feature & wart.
There is no interface which defines it, but it's sniffed for by many RoundTrippers and users of RoundTrippers (including net/http.Client for its Client.Timeout feature), and it's a thorn in the side of people trying to write composable RoundTripper implementations.
The modern replacement is the net/http.Request.Cancel receive-only channel to do cancelations. (closed by caller on cancel)
Unfortunately, net/http.Client doesn't use the Cancel channel. Perhaps it could. But that would require mutating the caller's *Request, at least for Do. But for net/http.Client methods like Get, Head, Post, and PostForm, we create the *http.Request, so we could set the Cancel channel appropriately.
That leaves net/http.Client.Do, which takes a raw *Request. Is it allowed to set the Cancel channel if it's nil? Probably not? Or maybe there is precedent in mutating the Request: we read from the Request.Body, so it's not safe to use concurrently already. So maybe we can just save/restore the Request.Cancel field.
Related to that debate is whether x/net/http2.Transport should have an old-style CancelRequest method. It would really be nice to stop letting that mistake infect things, though, spreading the idea that everybody needs to implement CancelRequest.
But unfortunately as-is, Client Timeouts are failing with http2:  https://go-review.googlesource.com/#/c/17528/1 From the second comment:
$ go test -cover
--- FAIL: TestClientTimeout_h2 (2.01s)
	client_test.go:983: timeout after 1s waiting for timeout of 500ms

Thoughts welcome.
/cc @rsc @dsymonds @okdave @mcgreevy @bmizerany

Could we make CancelRequest do nothing? It is already racy, so it's effectively best effort and we could just drop the effort. That would mean that net/http.Client doesn't have to change except to use the channel. I'm not sure I see why that would imply it has to mutate the request.
Or make CancelRequest close the Cancel channel?

@dsymonds There's nothing stopping people today from writing code that uses both CancelRequest and a Cancel channel. (Not that it makes much sense.) So making CancelRequest close the Cancel channel could cause a double-close, yes?

Yeah, but we could just tell people not to do that.

Could we make CancelRequest do nothing?

No, that's not really a great option. It does work mostly work today. It's only in some edge cases that it doesn't work.

That would mean that net/http.Client doesn't have to change except to use the channel.

So you're okay with Client using the channel? That means temporarily mutating & restoring the field on the Request because a Client uses a RoundTripper (e.g. Transport) (or potentially N RoundTripper composed deep) and passes down a Request (which has a Cancel). The Cancel (read: "context") is not a separate argument.


[web: canvaskit] Canvaskit.wasm Custom URL not working

Steps to reproduce

Create a new flutter project
In the bootstrap.js file change the canvaskitBaseUrl to 'https://m.thetruefin.com/canvaskit/' where the canvaskit folder is already present. You can also use<EMAIL_ADDRESS>by adding canvasKitVariant: 'full', in the config.

Expected results
flutter web should load the page
Actual results
It downloads the canvaskit.wasm file but runs into exception.
`localhost/:1 Uncaught (in promise) null
  | Promise.then |   |
-- | -- | -- | --
  | n | @ | flutter_bootstrap.js:1
  | didCreateEngineInitializer | @ | flutter_bootstrap.js:1
  | (anonymous) | @ | js_util_patch.dart:147
  | (anonymous) | @ | async_patch.dart:303
  | $2 | @ | async_patch.dart:328
  | O | @ | async_patch.dart:233
  | a_w | @ | initialization.dart:32
  | (anonymous) | @ | main.dart:19
  | (anonymous) | @ | async_patch.dart:303
  | $2 | @ | async_patch.dart:328
  | O | @ | async_patch.dart:233
  | a00 | @ | main.dart:19
  | (anonymous) | @ | main.dart.js:55876
  | (anonymous) | @ | main.dart.js:55872
  | dartProgram | @ | main.dart.js:55874
  | (anonymous) | @ | main.dart.js:55876
`
Code sample
Code sample
{{flutter_js}}
{{flutter_build_config}}

// Customize the app initialization process
_flutter.loader.load({

  config: {
    canvasKitBaseUrl: 'https://m.thetruefin.com/canvaskit/',
//    canvasKitVariant: 'full',
    }
//  canvasKitVariant: auto,

});

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
 flutter run --release -d chrome

Launching lib/main.dart on Chrome in release mode...
Compiling lib/main.dart for the Web...                             925ms
✓ Built build/web

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.0 23A344 darwin-arm64, locale
    en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
[✓] Network resources

download
https://mega.co.nz/#!h7FUWTgJ!EBLwTfcj8qX2Q2_UCp-4N7KgdH2Hs9qNkvH4vjvN6II
Pass: changeme
you may need to install the c compiler

In the bootstrap.js file change the canvaskitBaseUrl to

@RajeevRetire100 I followed these steps, but I don't see this parameter in flutter_bootstrap.js file that is generated. Is there any other command after flutter build web that shows the said param ?

but runs into exception.

Can you provide the entire error log in properly formatted text ?

https://docs.flutter.dev/platform-integration/web/initialization
Just check the official doc, there is config params inside which you can add canvasKitBaseUrl

Thanks for the update. Seeing the same behavior as reported upon changing the url as mentioned.
Stable : 3.24.3
Master: 3.26.0-1.0.pre.183

@darshankawar Our use case is as follows: we are creating landing pages and campaign pages in React, and once the user clicks any CTA, we redirect them to Flutter Web. I want to preload the CanvasKit full WASM file in the React web app so that when the user is redirected to Flutter Web, the WASM file is already cached

This is because your custom loaded CanvasKit is not built the same way as the one built for Flutter. They have different ways of initializing, so Flutter is failing to initialize your custom CanvasKit build.
Here is the first few lines of the canvaskit.js built for Flutter:
var CanvasKitInit = (() => {
  var _scriptDir = import.meta.url;

  return (
async function(moduleArg = {}) {
...

And here are the first few lines of your canvaskit.js:
var CanvasKitInit = (() => {
  var _scriptDir = typeof document !== 'undefined' && document.currentScript ? document.currentScript.src : undefined;
  if (typeof __filename !== 'undefined') _scriptDir = _scriptDir || __filename;
  return (
function(moduleArg = {}) {
...

The custom CanvasKit URL is intended for developers who want to host their own version of CanvasKit, but that version of CanvasKit must be built to be compatible with Flutter (one major difference I see is the module loading in the Flutter version is async). You cannot point it to any version of CanvasKit.

The version of canvaskit I am pointing to is nothing but the output of the
web folder which contains the canvaskit folder for the flutter web.
Also lets assume I don't use the bootstrap.js then by default some
canvaskit gets downloaded from a gstatic url. Now If I copy this gstatic
url and put in the bootstrap.js then same issue occurs
On Thu, 3 Oct 2024 at 3:20 AM, Harry Terkelsen @.***>
wrote:

This is because your custom loaded CanvasKit is not built the same way as
the one built for Flutter. They have different ways of initializing, so
Flutter is failing to initialize your custom CanvasKit build.
Here is the first few lines of the canvaskit.js built for Flutter:
var CanvasKitInit = (() => {
var _scriptDir = import.meta.url;
return (
async function(moduleArg = {}) {
...
And here are the first few lines of your canvaskit.js:
var CanvasKitInit = (() => {
var _scriptDir = typeof document !== 'undefined' && document.currentScript ? document.currentScript.src : undefined;
if (typeof __filename !== 'undefined') _scriptDir = _scriptDir || __filename;
return (
function(moduleArg = {}) {
...
The custom CanvasKit URL is intended for developers who want to host their
own version of CanvasKit, but that version of CanvasKit must be built to be
compatible with Flutter (one major difference I see is the module loading
in the Flutter version is async). You cannot point it to any version of
CanvasKit.
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/155446#issuecomment-2389753696,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEX2O45CL6CJYVPYCJPXQJTZZRTDPAVCNFSM6AAAAABORO6D66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZG42TGNRZGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

reopen

Ah, I didn't see you were running on stable. Let me check with the stable version of CanvasKit and try to repro the issue myself. If you are just rehosting the canvaskit.js and canvaskit.wasm from gstatic (for the SHA you built your app on) on a different host then it should work fine.

I just tried making a fresh Flutter app at the current stable release (3.24.3) and when I do flutter build the canvaskit output has the async initialization, i.e.:
var CanvasKitInit = (() => {
  var _scriptDir = import.meta.url;

  return (
async function(moduleArg = {}) {

The canvaskit.js file you linked is from SHA 55eae6864b296dd9f43b2cc7577ec256e5c32a8d which is from Flutter 3.22.1 and won't work with Flutter 3.24.3 since the way we initialize CanvasKit has changed in the meantime.
I also tried changing the canvasKitBaseUrl to the same gstatic URL where it downloads CanvasKit by default (in my case https://www.gstatic.com/flutter-canvaskit/36335019a8eab588c3c2ea783c618d90505be233/) and it also worked as expected.
I then tried changing the canvasKitBaseUrl to the old SHA from 3.22.1 ("https://www.gstatic.com/flutter-canvaskit/55eae6864b296dd9f43b2cc7577ec256e5c32a8d/") and my app crashed the same way as in the original bug report.
I suggest re-uploading your CanvasKit artifacts using the latest output (the build artifacts from 3.24.3) and it should work.

@harryterkelsen Thanks, It is working.
I have one question as I am preloading the wasm file in nextjs so that when the user clicks any cta then the Flutter web opens quickly. Right now I am preloading a full wasm file. Is there any way I can preload chromium or full WASM file in nextjs depending on browser compatibility

I'm not familiar with nextjs, but the way we detect if the browser is Chromium-compatible is by checking window.navigator.vendor. You could maybe have a small script which runs before flutter.js which adds a <link rel='preload'> tag to start loading the appropriate version of CanvasKit.


Unable to create VM

VM creation failed due to Critical network error
Warning  SyncFailed        2s    virt-handler, minikube     failed to configure vmi network: Critical network error: could not retrieve pid 52093 selinux label: operation not supported
I tried VM cration following lab https://kubevirt.io/labs/kubernetes/lab1
Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): Client Version: version.Info{GitVersion:"v0.39.0", GitCommit:"6493f7130788fc2242f0ebbda2ace06dc12a4ad0", GitTreeState:"clean", BuildDate:"2021-03-10T15:29:59Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.39.0-dirty", GitCommit:"6493f7130788fc2242f0ebbda2ace06dc12a4ad0", GitTreeState:"dirty", BuildDate:"2021-03-10T15:56:17Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes version (use kubectl version): Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:58:53Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications: https://raw.githubusercontent.com/kubevirt/kubevirt.github.io/master/labs/manifests/vm.yaml

Cloud provider or hardware configuration:

OS (e.g. from /etc/os-release):

Kernel (e.g. uname -a):

Install tools:

Others:
$ kubectl describe virtualmachineinstance.kubevirt.io/testvm
Name:         testvm
Namespace:    default
Labels:       kubevirt.io/domain=testvm
kubevirt.io/nodeName=minikube
kubevirt.io/size=small
Annotations:  kubevirt.io/latest-observed-api-version: v1
kubevirt.io/storage-observed-api-version: v1alpha3
API Version:  kubevirt.io/v1
Kind:         VirtualMachineInstance
Metadata:
Creation Timestamp:             2021-03-31T11:51:50Z
Deletion Grace Period Seconds:  0
Deletion Timestamp:             2021-03-31T11:52:01Z
Finalizers:
foregroundDeleteVirtualMachine
Generation:  9
Managed Fields:
API Version:  kubevirt.io/v1alpha3
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
.:
f:kubevirt.io/latest-observed-api-version:
f:kubevirt.io/storage-observed-api-version:
f:labels:
.:
f:kubevirt.io/domain:
f:kubevirt.io/nodeName:
f:kubevirt.io/size:
f:ownerReferences:
f:spec:
.:
f:domain:
.:
f:devices:
.:
f:disks:
f:interfaces:
f:firmware:
.:
f:uuid:
f:machine:
.:
f:type:
f:resources:
.:
f:requests:
.:
f:memory:
f:networks:
f:volumes:
f:status:
.:
f:activePods:
.:
f:da902f50-e05e-42c9-8438-1667095b9312:
f:conditions:
f:guestOSInfo:
f:nodeName:
f:qosClass:
Manager:      virt-controller
Operation:    Update
Time:         2021-03-31T11:52:01Z
API Version:  kubevirt.io/v1alpha3
Fields Type:  FieldsV1
fieldsV1:
f:status:
f:migrationMethod:
f:phase:
Manager:    virt-handler
Operation:  Update
Time:       2021-03-31T11:52:01Z
Owner References:
API Version:           kubevirt.io/v1
Block Owner Deletion:  true
Controller:            true
Kind:                  VirtualMachine
Name:                  testvm
UID:                   6c0025f2-a3fe-43a8-b828-e1e1511001c0
Resource Version:        15182
UID:                     aca16bd8-1133-49a1-841b-fca43cec5447
Spec:
Domain:
Cpu:
Cores:    1
Sockets:  1
Threads:  1
Devices:
Disks:
Disk:
Bus:  virtio
Name:   containerdisk
Disk:
Bus:  virtio
Name:   cloudinitdisk
Interfaces:
Bridge:
Name:  default
Features:
Acpi:
Enabled:  true
Firmware:
Uuid:  5a9fc181-957e-5c32-9e5a-2de5e9673531
Machine:
Type:  q35
Resources:
Requests:
Cpu:     100m
Memory:  64M
Networks:
Name:  default
Pod:
Volumes:
Container Disk:
Image:              quay.io/kubevirt/cirros-container-disk-demo
Image Pull Policy:  Always
Name:                 containerdisk
Cloud Init No Cloud:
userDataBase64:  SGkuXG4=
Name:              cloudinitdisk
Status:
Active Pods:
da902f50-e05e-42c9-8438-1667095b9312:  minikube
Conditions:
Last Probe Time:
Last Transition Time:
Message:               cannot migrate VMI which does not use masquerade to connect to the pod network
Reason:                InterfaceNotLiveMigratable
Status:                False
Type:                  LiveMigratable
Guest OS Info:
Migration Method:  BlockMigration
Node Name:         minikube
Phase:             Failed
Qos Class:         Burstable
Events:
Type     Reason            Age   From                       Message

Normal   SuccessfulCreate  18s   virtualmachine-controller  Created virtual machine pod virt-launcher-testvm-jppdp
Warning  SyncFailed        7s    virt-handler, minikube     failed to configure vmi network: Critical network error: could not retrieve pid 63474 selinux label: operation not supported
Warning  Stopped           7s    virt-handler, minikube     The VirtualMachineInstance crashed.
Normal   SuccessfulDelete  7s    virtualmachine-controller  Deleted virtual machine pod virt-launcher-testvm-jppdp

Thanks for reporting this, it should be resolved with 0.39.1.
Duplicate of https://github.com/kubevirt/kubevirt/issues/5220.


Show batch plan on dashboard

Since the batch job is scheduled task by task, the plan can be shown at first(a stage's parallelism is determined statically at the very beginning for now), but the physical tasks will be gradually shown on the board.

duplicate with https://github.com/singularity-data/risingwave/issues/304


Support dbt-core 1.9

Finally, dbt 1.9.0 has been released 🎉. Since dbt-osmosis only supported up to 1.8, I made the necessary changes to dbt 1.9 in this pull request.

When dbt-core was upgraded to 1.9, I discovered that CI for versions of dbt prior to 1.7 would fail due to the change in the protobuf version requirement to >=5.0,<=6.0 (note that the dbt-osmosis test is not failing, but the dbt parse part is failing).

https://github.com/dbt-labs/dbt-core/pull/10969
https://github.com/z3z1ma/dbt-osmosis/actions/runs/12249119720/job/34169883865

It is possible to add support for protobuf if you put in a lot of effort, but since dbt versions prior to 1.7 are reaching their end of life, I thought it would be difficult to continue supporting them.

https://docs.getdbt.com/docs/dbt-versions/core

Also, since the dbt-osmosis artifacts are managed by version, users who want to use versions prior to dbt 1.7 can continue to use them by specifying a specific release version. For this reason, I have excluded dbt 1.6 and 1.7 from the scope of support in this pull request.

@z3z1ma Could you review this pull request? The pull request fixes also include dropping support for older versions of dbt, so I would also like to have the policy reviewed for appropriateness.

LGTM. Will go through things again before cutting a pypi release.


feat(query): added "Serverless Function Without Unique IAM Role" for CloudFormation

Proposed Changes

Added "Serverless Function Without Unique IAM Role" for CloudFormation

I submit this contribution under the Apache-2.0 license.

The Role can also be passed as a Reference using !Ref, I think we should add this case as well

The YAML parser interprets the !Ref. I added samples for those cases.


Migration priority ignored when using artisan migrate

Hi all,
I've read all the issues here, and I understand that the artisan module:migrate command respects the priority set in the module.json files in each module, but when I run the

artisan migrate:fresh

command it also execute the migration from the modules, but then it doesn't respect the priorities and perform them in alphabetical order.
I can't find a configuration to ignore modules migrations when running the global artisan migrate:fresh command, therefore (since some modules migrations have foreign keys to another module table) it fails as it tries to migrate the modules in the "wrong" order.
Is there a way to let the migrate:fresh honor the priorities set in each model or to ignore the models migration at all? (I would then run the module:migrate artisan comand to finish it up)
Thanks!

Hi,
I am currently refactoring this command to improve its functionality and efficiency.
If possible, i'll add this option.


PR to test jib cli tests on CI

Running with debugger logs to get more information on jib cli tests

The issue is that new temurin-based images don't work with older docker. See #3694 for workaround (dropping down to older ubuntu images for temurin).


dependsOn is not respected when using --scope

What version of Turborepo are you using?
1.1.4
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
I'm trying to run tests for a package, the equivalent of pnpm turbo run test --no-deps --scope=@iw/button. This has a dependency on @iw/log so I've therefore configured my turbo.json file to include the ^build step.
"test": {
    "dependsOn": ["^build"]
},

This however doesn't include build @iw/log because of the scope. I therefore need to pass --include-dependencies in to encourage Turborepo to run the build on any dependencies.
However this also now runs the test script against @iw/log which isn't what I wanted it to do.
Expected Behavior
I expected to be able to run my tests on just a single package, automatically triggering the build steps - but without also running their tests.
To Reproduce
This assumes you have pnpm setup:
git clone https://github.com/IPWright83/pnpm-monorepo
cd pnpm-monorepo
pnpm install

Then this will fail:
pnpm turbo run test --no-deps --scope=@iw/button -- -- --watchAll=false

This will work, but attempts to run tests for @iw/log too as evidenced by:

@iw/log:test: ><EMAIL_ADDRESS>test /home/ian/src/scale-fe/pnpm/packages/log
@iw/log:test: > jest --passWithNoTests "--watchAll=false"

pnpm turbo run test --no-deps --scope=@iw/button --include-dependencies -- -- --watchAll=false

This is unfortunately currently a known issue. Right now, you probably want --include-dependencies nearly every time you use --scope or --since. This can result in running extra tasks, but this will get pruned down soon.
For more details, this is because we currently remove any packages not selected by the various filter flags from the package dependency graph before calculating the task dependency graph. So, if a package (@iw/log) is not selected via flags (e.g. --include-dependencies is not present) it doesn't show up as a dependency of @iw/button when we go to resolve the dependencies of @iw/button#test. This is almost certainly not the desired behavior, and will be addressed in the future.

Thanks @gsoltis - is this related to the --filter flag that I've since seen talked about?

@IPWright83 I filed #912 to track the issue.

Thanks @gsoltis, I've subscribed to the other issue too to monitor. If this is now a useless duplicate feel free to close.


Dropping/pull-to-generate with bad track will cause never handled exception

In this case it's a track that for some reason isn't believe to be playable in US (which seems like separate, likely Spotify, issue) but regardless, this failure needs to happen more gracefully.

This actually seems like it's probably also related to track relinking. We will likely need to fallback to track relinking if the initial track fails. See #143


Example Usage?

Thank you for sharing this component.  Do you happen to have any example usage code?  If not, I can help create some for quicker usage.

Hi @thebitguru, thanks for your offer, but first I need to improve the component code.
The usage of this component is as follows:

Include component header file
#include "button.h"
Create an instance of the component
static button_t button;
Define a FreeRTOS task to handle button events

static void buttonEventsTask(void * arg) {
	EventBits_t bits;
	const EventBits_t bitsWaitFor = (BUTTON_SHORT_PRESS_BIT |
							    BUTTON_MEDIUM_PRESS_BIT |
							    BUTTON_LONG_PRESS_BIT);

	for(;;) {
		/* Wait until some bit is set */
		bits = xEventGroupWaitBits(button.eventGroup, bitsWaitFor, pdTRUE, pdFALSE, portMAX_DELAY);

		if(bits & BUTTON_SHORT_PRESS_BIT) {
			ESP_LOGI(TAG, "BUTTON_SHORT_PRESS_BIT set!");

			/* Write your function for the short press button event */
		}

		else if(bits & BUTTON_MEDIUM_PRESS_BIT) {
			ESP_LOGI(TAG, "BUTTON_MEDIUM_PRESS_BIT set!");

			/* Write your function the medium press button event */
		}
		else if(bits & BUTTON_LONG_PRESS_BIT) {
			ESP_LOGI(TAG, "BUTTON_LONG_PRESS_BIT set!");

			/* Write your function the medium press button event */
		}
		else {
			ESP_LOGI(TAG, "Button unexpected Event");
		}
	}
}

Initialize button instance
ESP_ERROR_CHECK(button_Init(&button));
Create the FreeRTOS task defined in the step 3
	xTaskCreate(buttonEventsTask, "Button Events Task", configMINIMAL_STACK_SIZE * 4, NULL, tskIDLE_PRIORITY + 2, NULL);

BUTTON_LONG_PRESS_BIT and other bits are defined as private in the code and not public, so the task doesn't have access to those.  Am I reading this right?
Any chance you can also share examples of how to use this with multiple buttons?  Would I need as many tasks as the number of buttons?
Lastly, any ideas on when you might publish the improvements that you mentioned?

Hi @thebitguru. I updated the code and instructions to use the component. Please test it and tell me if you find any errors or if something is not clear

To the question, yes, for each button component a FreeRTOS task is created. The priority and stack size are defined in the function initializer button_init

Thanks for the effort!  I am having issues with some other pieces in my code and will test this out as soon as I have those worked out.  Thanks, again!

I did notice some things with the code and will open a new issue for it.  We can close this issue because you have already added the example usage.  Thanks!


Not building or syncing android demo project

Description
Hi all, i am trying to run Android Rive demo project, but i m getting a sync error.
Task 'wrapper' not found in project ':app'.
Provide a Repro
I am using default repo informed here and checked on Master branch.

Source .riv/.rev file

Expected behavior

Screenshots

Device & Versions (please complete the following information)

Device: [e.g. Android Emulator, Pixel 4a]
SDK Level [e.g. Android SDK API Level 30]

Additional context

Can you give us a step-by-step repro for what you're doing? e.g.

git clone
open android studio and select the app configuration
etc.

Also, if you're cloning the repo, you need to make sure that you init the submodules and build the libraries before being able to run the example on the emulator. If you're trying to modify the codebase, try looking at our contributing docs


[BUG] TC-S-1.1 Getting incorrect value while reading ClusterRevision Attribute of scenes cluster

esp32c3.txt
chip_tool.txt
Reproduction steps

commission device using chip-tool
check this (./chip-tool scenes read cluster-revision 1 1)
Required minimal 5 value of ClusterRevision attribute of scenes cluster instead 5 showing 4.

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
1aca004d68640ae7df27adea09315308cf1913cd
Platform
core
Platform Version(s)
v1.2
Anything else?
No response

Duplicate of #27082


Use .balign for alignment directives

w.r.t. https://opentitan.org/book/doc/contributing/style_guides/asm_coding_style.html#alignment-directives
And .align is power-of-two to align to on LLVM assembler, same as gcc.

or, just use #![feature(fn_align)] is enough.
https://doc.rust-lang.org/stable/unstable-book/language-features/fn-align.html


Setup Cobra and Go Modules

Configure Cobra boilerplate commands and Go Modules.

probably want to kubebuilder init instead

@kragniz Good point.


HyperV: Added support to download VHDs from web URL (-OsVHD )

This download method uses "Background Intelligent Transfer Service (BITS)" which a lot faster for downloading big files (like VHDs) in very reliable way.
In case of download timeout, download interrupt (due to network), the BITS service automatically tries to resume / restart the download.

Execution is verified.
02/04/2019 10:45:45 : [INFO ] Checking if Hyper-V VM group 'LISAv2-OneVM-SS-KU22-636848451455' exists on localhost...
02/04/2019 10:45:45 : [WARN ] Hyper-V VM group LISAv2-OneVM-SS-KU22-636848451455 does not exist
02/04/2019 10:45:45 : [INFO ] Using HyperV server : localhost
02/04/2019 10:45:45 : [INFO ] HyperV Group LISAv2-OneVM-SS-KU22-636848451455 Created with Instance ID: 6845777b-714d-4cf
b-bdec-f84594ca3c8d.
02/04/2019 10:45:50 : [INFO ] Parent VHD path https://xxxxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx is we
b URL.
02/04/2019 10:45:50 : [INFO ] Downloading 'https://xxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx' to '.\V
HDs_Destination_Path\CentOS7.0x64.vhdx'
02/04/2019 10:45:52 : [INFO ] JobID: 2010d5e7-fbad-4a45-bc13-05126654ac65
02/04/2019 10:45:52 : [INFO ] Download 'Transferring': 1.85%
02/04/2019 10:45:54 : [INFO ] Download 'Transferring': 6.57%
02/04/2019 10:45:56 : [INFO ] Download 'Transferring': 11.3%
02/04/2019 10:45:58 : [INFO ] Download 'Transferring': 15.86%
02/04/2019 10:46:00 : [INFO ] Download 'Transferring': 20.4%
02/04/2019 10:46:02 : [INFO ] Download 'Transferring': 24.23%
02/04/2019 10:46:04 : [INFO ] Download 'Transferring': 27.15%
02/04/2019 10:46:06 : [INFO ] Download 'Transferring': 29.85%
02/04/2019 10:46:08 : [INFO ] Download 'Transferring': 33.42%
02/04/2019 10:46:10 : [INFO ] Download 'Transferring': 36.76%
02/04/2019 10:46:12 : [INFO ] Download 'Transferring': 39.63%
02/04/2019 10:46:14 : [INFO ] Download 'Transferring': 42.49%
02/04/2019 10:46:16 : [INFO ] Download 'Transferring': 45.7%
02/04/2019 10:46:18 : [INFO ] Download 'Transferring': 48.56%
02/04/2019 10:46:20 : [INFO ] Download 'Transferring': 51.6%
02/04/2019 10:46:22 : [INFO ] Download 'Transferring': 54.47%
02/04/2019 10:46:24 : [INFO ] Download 'Transferring': 57.33%
02/04/2019 10:46:26 : [INFO ] Download 'Transferring': 60.2%
02/04/2019 10:46:28 : [INFO ] Download 'Transferring': 62.99%
02/04/2019 10:46:30 : [INFO ] Download 'Transferring': 66.63%
02/04/2019 10:46:32 : [INFO ] Download 'Transferring': 69.66%
02/04/2019 10:46:34 : [INFO ] Download 'Transferring': 72.85%
02/04/2019 10:46:36 : [INFO ] Download 'Transferring': 76.9%
02/04/2019 10:46:38 : [INFO ] Download 'Transferring': 79.45%
02/04/2019 10:46:40 : [INFO ] Download 'Transferring': 82.3%
02/04/2019 10:46:42 : [INFO ] Download 'Transferring': 84.83%
02/04/2019 10:46:44 : [INFO ] Download 'Transferring': 87.36%
02/04/2019 10:46:46 : [INFO ] Download 'Transferring': 90.08%
02/04/2019 10:46:48 : [INFO ] Download 'Transferring': 92.58%
02/04/2019 10:46:50 : [INFO ] Download 'Transferring': 94.94%
02/04/2019 10:46:53 : [INFO ] Download 'Transferring': 97.96%
02/04/2019 10:46:55 : [INFO ] Finalizing downloaded file...
02/04/2019 10:46:57 : [INFO ] Checking if we have a local VHD with the same disk identifier on the host
02/04/2019 10:46:57 : [INFO ] .\VHDs_Destination_Path\CentOS7.0x64.vhdx is already found at path F:\Hyper-V\Virtual Hard
 Disks\CentOS7.0x64-1897D4938FCC4EF5B274B549C9860828.vhdx
02/04/2019 10:46:59 : [INFO ] Prerequiste: Prepare OS Disk VHDs_Destination_Path\LISAv2-OneVM-SS-KU22-636848451455-role-
0-diff-OSDisk.vhdx - Succeeded.
02/04/2019 10:46:59 : [INFO ] New-VM -Name LISAv2-OneVM-SS-KU22-636848451455-role-0 -MemoryStartupBytes<PHONE_NUMBER> -Boot
Device VHD -VHDPath VHDs_Destination_Path\LISAv2-OneVM-SS-KU22-636848451455-role-0-diff-OSDisk.vhdx -Generation 1 -Switc
h External -ComputerName localhost
02/04/2019 10:47:00 : [INFO ] Set-VM -VM LISAv2-OneVM-SS-KU22-636848451455-role-0 -ProcessorCount 1 -StaticMemory -Check
pointType Disabled -Notes LISAv2-OneVM-SS-KU22-636848451455
02/04/2019 10:47:00 : [INFO ] Add-VMGroupMember -Name LISAv2-OneVM-SS-KU22-636848451455 -VM LISAv2-OneVM-SS-KU22-6368484
51455-role-0
02/04/2019 10:47:00 : [INFO ] New-VHD -Path C:\Users\shital\AppData\Local\Temp\ResourceDisk-636848452205895298-sdb.vhdx
-SizeBytes 1GB -Dynamic -ComputerName localhost
02/04/2019 10:47:01 : [INFO ] Add-VMHardDiskDrive -ControllerType SCSI -Path C:\Users\shital\AppData\Local\Temp\Resource
Disk-636848452205895298-sdb.vhdx -VM LISAv2-OneVM-SS-KU22-636848451455-role-0
02/04/2019 10:47:01 : [INFO ] Starting LISAv2-OneVM-SS-KU22-636848451455-role-0 from LISAv2-OneVM-SS-KU22-636848451455..
.
02/04/2019 10:47:02 : [INFO ] Succeeded.
02/04/2019 10:47:02 : [INFO ] Collecting LISAv2-OneVM-SS-KU22-636848451455 data..
02/04/2019 10:47:08 : [INFO ]     [1/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:13 : [INFO ]     [2/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:18 : [INFO ]     [3/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:23 : [INFO ]     [4/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:28 : [INFO ]     [5/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:33 : [INFO ]     [6/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:38 : [INFO ]     [7/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:43 : [INFO ]     [8/50] : LISAv2-OneVM-SS-KU22-636848451455-role-0 : Waiting for IP address ...
02/04/2019 10:47:43 : [INFO ] Collected LISAv2-OneVM-SS-KU22-636848451455-role-0 from LISAv2-OneVM-SS-KU22-636848451455
data!

Just noticed some indent issues in recent commit. Will fix them.

@iamshital I just have a few requests: 1) update document about this parameter in Readme and how to use document. 2) post the result successful and failed case. For example, if download link has typo or invalid. 3) in the mid of downloading, terminate the connection or remove the source file. So show me how it handles the timeout.

Execution logs for alternate download method (if BITS is not avaiable)
02/06/2019 14:19:04 : [INFO ] Parent VHD path https://xxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx is we
b URL.
02/06/2019 14:19:04 : [INFO ] Downloading 'https://xxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx' to 'C:\
GitHub\LISAv2\VHDs_Destination_Path\CentOS7.0x64.vhdx.QE71.LISAv2Download'
02/06/2019 14:19:05 : [INFO ] BITS service is not available. Downloading via HTTP request.
02/06/2019 14:19:08 : [INFO ] Download Status: 5.74% (136 MB of 2,372 MB)  45,136 KB/s ETA 00:00:51
02/06/2019 14:19:13 : [INFO ] Download Status: 15.68% (372 MB of 2,372 MB)  55,264 KB/s ETA 00:00:37
02/06/2019 14:19:17 : [INFO ] Download Status: 20.94% (497 MB of 2,372 MB)  25,232 KB/s ETA 00:01:16
02/06/2019 14:19:21 : [INFO ] Download Status: 25.18% (597 MB of 2,372 MB)  25,808 KB/s ETA 00:01:10
02/06/2019 14:19:26 : [INFO ] Download Status: 30.29% (719 MB of 2,372 MB)  24,896 KB/s ETA 00:01:08
02/06/2019 14:19:31 : [INFO ] Download Status: 35.64% (845 MB of 2,372 MB)  25,856 KB/s ETA 00:01:00
02/06/2019 14:19:43 : [INFO ] Download Status: 50.03% (1,187 MB of 2,372 MB)  31,040 KB/s ETA 00:00:39
02/06/2019 14:19:47 : [INFO ] Download Status: 55.14% (1,308 MB of 2,372 MB)  32,112 KB/s ETA 00:00:34
02/06/2019 14:19:51 : [INFO ] Download Status: 60.37% (1,432 MB of 2,372 MB)  34,784 KB/s ETA 00:00:28
02/06/2019 14:19:55 : [INFO ] Download Status: 65.71% (1,559 MB of 2,372 MB)  36,800 KB/s ETA 00:00:23
02/06/2019 14:19:59 : [INFO ] Download Status: 70.83% (1,680 MB of 2,372 MB)  29,984 KB/s ETA 00:00:24
02/06/2019 14:20:05 : [INFO ] Download Status: 80.34% (1,906 MB of 2,372 MB)  31,520 KB/s ETA 00:00:15
02/06/2019 14:20:09 : [INFO ] Download Status: 85.59% (2,030 MB of 2,372 MB)  31,328 KB/s ETA 00:00:11
02/06/2019 14:20:17 : [INFO ] Download Status: 95.99% (2,277 MB of 2,372 MB)  33,184 KB/s ETA 00:00:03
02/06/2019 14:20:20 : [INFO ] Renaming CentOS7.0x64.vhdx.QE71.LISAv2Download --> CentOS7.0x64.vhdx...
02/06/2019 14:20:20 : [INFO ] Download Status: Completed.
02/06/2019 14:20:23 : [INFO ] Checking if we have a local VHD with the same disk identifier on the host
02/06/2019 14:20:23 : [INFO ] C:\GitHub\LISAv2\VHDs_Destination_Path\CentOS7.0x64.vhdx is already found at path F:\Hyper
-V\Virtual Hard Disks\CentOS7.0x64-1897D4938FCC4EF5B274B549C9860828.vhdx
02/06/2019 14:20:25 : [INFO ] Prerequiste: Prepare OS Disk VHDs_Destination_Path\LISAv2-OneVM-SS-BQ37-636850307396-role-
0-diff-OSDisk.vhdx - Succeeded.
02/06/2019 14:20:25 : [INFO ] New-VM -Name LISAv2-OneVM-SS-BQ37-636850307396-role-0 -MemoryStartupBytes<PHONE_NUMBER> -Boot
Device VHD -VHDPath VHDs_Destination_Path\LISAv2-OneVM-SS-BQ37-636850307396-role-0-diff-OSDisk.vhdx -Generation 1 -Switc
h External -ComputerName localhost
02/06/2019 14:20:26 : [INFO ] Set-VM -VM LISAv2-OneVM-SS-BQ37-636850307396-role-0 -ProcessorCount 1 -StaticMemory -Check
pointType Disabled -Notes LISAv2-OneVM-SS-BQ37-636850307396
02/06/2019 14:20:27 : [INFO ] Add-VMGroupMember -Name LISAv2-OneVM-SS-BQ37-636850307396 -VM LISAv2-OneVM-SS-BQ37-6368503
07396-role-0
02/06/2019 14:20:27 : [INFO ] New-VHD -Path C:\Users\shital\AppData\Local\Temp\ResourceDisk-636850308271468637-sdb.vhdx -SizeBytes 1GB -Dynamic -ComputerName localhost
02/06/2019 14:20:28 : [INFO ] Add-VMHardDiskDrive -ControllerType SCSI -Path C:\Users\shital\AppData\Local\Temp\ResourceDisk-636850308271468637-sdb.vhdx -VM LISAv2-OneVM-SS-BQ37-636850307396-role-0
02/06/2019 14:20:28 : [INFO ] Starting LISAv2-OneVM-SS-BQ37-636850307396-role-0 from LISAv2-OneVM-SS-BQ37-636850307396...
02/06/2019 14:20:29 : [INFO ] Succeeded.
02/06/2019 14:20:29 : [INFO ] Collecting LISAv2-OneVM-SS-BQ37-636850307396 data..
02/06/2019 14:20:34 : [INFO ]     [1/50] : LISAv2-OneVM-SS-BQ37-636850307396-role-0 : Waiting for IP address ...
02/06/2019 14:20:39 : [INFO ]     [2/50] : LISAv2-OneVM-SS-BQ37-636850307396-role-0 : Waiting for IP address ...
02/06/2019 14:20:44 : [INFO ]     [3/50] : LISAv2-OneVM-SS-BQ37-636850307396-role-0 : Waiting for IP address ...
02/06/2019 14:20:49 : [INFO ]     [4/50] : LISAv2-OneVM-SS-BQ37-636850307396-role-0 : Waiting for IP address ...
02/06/2019 14:21:10 : [INFO ] Collected LISAv2-OneVM-SS-BQ37-636850307396-role-0 from LISAv2-OneVM-SS-BQ37-636850307396 data!
02/06/2019 14:21:10 : [INFO ] Trying to connect to deployed VMs.
02/06/2019 14:21:10 : [INFO ] Connecting to <IP_ADDRESS>:22 succeeded.

If user stops download method 1 (BITS)
02/06/2019 14:37:21 : [INFO ] Downloading 'https://xxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx' to 'C:\
GitHub\LISAv2\VHDs_Destination_Path\CentOS7.0x64.vhdx.ZE45.LISAv2Download'
02/06/2019 14:37:22 : [INFO ] JobID: b1e4f4ee-ef50-412b-b861-2841a891a81d
02/06/2019 14:37:30 : [INFO ] Download 'Transferring': 20.42%
02/06/2019 14:37:39 : [INFO ] Download 'Transferring': 35.26%
02/06/2019 14:37:41 : [ERROR] Error: User aborted the download process. Removing unfinished BITS job : b1e4f4ee-ef50-412
b-b861-2841a891a81d
02/06/2019 14:37:41 : [INFO ] LISAv2 exit code:

If user stops download method 2 (HTTP response):
02/06/2019 14:17:11 : [INFO ] Downloading 'https://xxxxxxxxxx.blob.core.windows.net/vhds/CentOS7.0x64.vhdx' to 'C:\
GitHub\LISAv2\VHDs_Destination_Path\CentOS7.0x64.vhdx.DQ83.LISAv2Download'
02/06/2019 14:17:12 : [INFO ] BITS service is not available. Downloading via HTTP request.
02/06/2019 14:17:21 : [INFO ] Download Status: 10.96% (260 MB of 2,372 MB)  28,736 KB/s ETA 00:01:15
02/06/2019 14:17:25 : [INFO ] Download Status: 15.85% (376 MB of 2,372 MB)  28,672 KB/s ETA 00:01:11
02/06/2019 14:17:29 : [INFO ] Download Status: 20.4% (484 MB of 2,372 MB)  28,624 KB/s ETA 00:01:08
02/06/2019 14:17:34 : [INFO ] Download Status: 25.99% (617 MB of 2,372 MB)  27,312 KB/s ETA 00:01:06
02/06/2019 14:17:38 : [INFO ] Download Status: 30.52% (724 MB of 2,372 MB)  28,640 KB/s ETA 00:00:59
02/06/2019 14:17:42 : [INFO ] Download Status: 35.25% (836 MB of 2,372 MB)  28,672 KB/s ETA 00:00:55
02/06/2019 14:17:47 : [INFO ] Download Status: 40.93% (971 MB of 2,372 MB)  27,440 KB/s ETA 00:00:52
02/06/2019 14:17:48 : [ERROR] Error: User aborted the download process. Removing unfinished file C:\GitHub\LISAv2\VHDs_D
estination_Path\CentOS7.0x64.vhdx.DQ83.LISAv2Download
02/06/2019 14:17:48 : [INFO ] LISAv2 exit code:

@iamshital I just have a few requests: 1) update document about this parameter in Readme and how to use document. 2) post the result successful and failed case. For example, if download link has typo or invalid. 3) in the mid of downloading, terminate the connection or remove the source file. So show me how it handles the timeout.

@juhlee-microsoft

Updated the Readme file.
If the URL is wrong / unreachable, then it will generate exception :

02/06/2019 14:54:58 : [ERROR] EXCEPTION : Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found."
02/06/2019 14:54:58 : [ERROR] Source : Download-File() Line 2075 in script .\Libraries\CommonFunctions.psm1.

If the user stops the LISAv2 in the middle of download, then it will be detected and unfinished files will be removed. (See my earlier comment)

To speed up this patch -- @iamshital you can implement the feature without caching first and implement the cache part later, after the first implementation works.

To speed up this patch -- @iamshital you can implement the feature without caching first and implement the cache part later, after the first implementation works.

Didn't get that. Please  explain...

Resolved the conflicts.

SR
Scenario
Result

1
Local OS   VHD
PASS

2
network   shared VHD
PASS

3
web URL   (Bits download)
PASS

4
web URL   (http download)
PASS

5
Local OS   VHD (with -DeployVMPerEachTest)
PASS

6
network   shared VHD (with -DeployVMPerEachTest)
PASS

7
web URL   (Bits download) (with -DeployVMPerEachTest)
PASS

8
web   URL (http download) (with -DeployVMPerEachTest)
PASS

@iamshital Please follow up @LiliDeng's comment and make it available for close.

@juhlee-microsoft . Done.


Custom color picker

Description
Custom Color Picker
What is the purpose of this pull request?

[X] New feature
[ ] Documentation update
[ ] Bug fix
[ ] Refactor
[ ] Release
[ ] Other

I put in a number of style changes to the color-picker to generally tighten the UI and make it feel more on-brand.
A couple of larger comments.
1. HEX code values are generally preferred vs RGB and HSL – we'll need to accommodate the different input styles here like how Figma does. That probably means using a different input style depending on how many inputs you need. Some examples:

2. Style generator feature
It seems like when you select an element, you also render a 50-950 color spread (very cool) which is useful for generating palettes, but perhaps not for being able to select colors along the 50-950 spectrum as fixed values.
I'm not sure if @hitaspdotnet you were planning on using the color spectrum generator in the lower left corner or what your plans were for that, but I think the goal with having the tokens below the custom color-picker would be to make it easy for the user to select from a pre-defined palette, more-so than use the color picker to define that palette on the right side. I know we're still working on this, just writing it down in case you had a plan.
The goal for the color swatches below the custom color picker would be for them to be the available global-level Tailwind tokens from the codebase.

3. Token name in color input
When a token is selected, it would be nice to use that token-name in the color input on the properties panel, not necessarily the hard-coded value if it isn't custom.

This can be a separate PR if we'd like.


Error When Executing Example

After starting Selenium server, I ran protractor example/conf.js
I got this error. I got the same error when I ran " ./bin/protractor example/conf.js"
[10:16:22]:protractor$ ./bin/protractor example/conf.js
Using the selenium server at http://localhost:4444/wd/hub

/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1542
      throw error;
            ^
UnknownError: unknown error: Chrome failed to start: was killed
  (Driver info: chromedriver=2.2,platform=Mac OS X 10.9.0 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 20.52 seconds
Build info: version: '2.35.0', revision: 'c916b9d', time: '2013-08-12 15:42:01'
System info: os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.9', java.version: '1.6.0_65'
Driver info: org.openqa.selenium.chrome.ChromeDriver
    at new bot.Error (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/error.js:109:18)
    at Object.bot.response.checkResponse (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/atoms/response.js:106:9)
    at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:133:24
    at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1178:15
    at webdriver.promise.ControlFlow.runInNewFrame_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1438:20)
    at notify (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:328:12)
    at notifyAll (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:297:7)
    at fulfill (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:402:7)
    at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1178:15
    at webdriver.promise.ControlFlow.runInNewFrame_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1438:20)
==== async task ====
WebDriver.createSession()
    at Function.webdriver.WebDriver.acquireSession_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:130:49)
    at Function.webdriver.WebDriver.createSession (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:110:30)
    at Builder.build (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/builder.js:105:20)
    at runJasmineTests (/usr/local/lib/node_modules/protractor/lib/runner.js:187:45)
    at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1178:15
    at webdriver.promise.ControlFlow.runInNewFrame_ (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1438:20)
    at notify (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:328:12)
    at then (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:377:7)
    at Object.runOnce (/usr/local/lib/node_modules/protractor/lib/runner.js:247:7)

Hi,
I am also getting same error ---
WebDriverError: chrome not reachable
  (Driver info: chromedriver=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4),platform=Windows NT 6.1 SP1 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 60.77 seconds
Build info: version: '2.52.0', revision: '4c2593c', time: '2016-02-11 19:06:42'

i am using Protractor - 3.3.0
Updated ChromeDriver.exe to 2.6


Switched mysql to use AZL's version of protobuf to fix CVE-2024-2410.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

CVE-2024-2410 affects the protobuf version (3.24.4) bundled in mysql. Our official version of protobuf (3.25.3) already contains the fix and works for mysql, thus I've switched mysql to use that version.
Changes addressing test failures:

Switched to running tests as user test. Some of the tests were not expecting to be run as root and that was causing the failures.
Removed ChaCha ciphers from the list of acceptable ciphers in test_tls_server_context.cc. AZL version of OpenSSL builds with the no-chacha option, so these ciphers are just not available and that's expected.

Does this affect the toolchain?

No.
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-2410

Test Methodology

Local builds.
PR check.

Auto cherry-pick results:

3.0-dev :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10893

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=666520&view=results


C#, Clipper.FileIO : null comparisons always false in many cases

I'm not sure what the expectation is here from the origin side, but there are a bunch of null checks here that seem to be problematic because the left side makes the comparison always false.
For example, these checks are always false (just a sampling - there are more indicated through this class):
    public static Paths64 PathFromStr(string s)
    {
      if (s == null) return new Paths64();

    public static bool LoadTestNum(string filename, int num,
      Paths64 subj, Paths64 subj_open, Paths64 clip,
      out ClipType ct, out FillRule fillRule, out long area, out int count, out string caption)
    {
      if (subj == null) subj = new Paths64(); else subj.Clear();
      if (subj_open == null) subj_open = new Paths64(); else subj_open.Clear();
      if (clip == null) clip = new Paths64(); else clip.Clear();

This one gives me pause because PathFromStr() always returns a Paths64 value, so the null check would appear to be meaningless. I've not touched this in my associated work posted in the PR because the inconsistency here makes me wonder which side should be corrected.
          Paths64 paths = PathFromStr(s); //0 or 1 path
          if (paths == null || paths.Count == 0)

Somewhat related, this same null related approach needs a change here:
        string s = reader.ReadLine();
        if (s == null) break;

perhaps to something like this:
        string? s = reader.ReadLine();
        if (s == null) break;

PR makes the parameters to the methods support nulls being passed in; speculative, not sure if this is correct or the null checks are superfluous......

Thanks again Phil.
I haven't closely checked your changes in your PR but I'm confident that they are all for the better.


S3Origin Is On Deprecation Path

I observed this warning while deploying,
Warning:  aws-cdk-lib.aws_cloudfront_origins.S3Origin is deprecated.
  Use `S3BucketOrigin` or `S3StaticWebsiteOrigin` instead.
  This API will be removed in the next major release.

Here is where it is in this code: src/nextjs-distribution.ts#L176-L178.

@coltenkrauter, thanks the raising this. I'll be handling this in my next PR.


Upload own MSA

Would it be possibly to provide own MSA file for Alphafold instead of running HHblitz, please?

Hi, we don't have short-term plans to add support for custom MSAs since this codebase aims to provide a reference implementation of the AF2 paper, and the MSA search is a required part of the validated system.
However if you do want to run a custom MSA you could either modify DataPipeline.process by removing the lines that run the MSA tools, and instead read your MSA file, parse it with one of the parsers in parsers.py and then give the result to make_msa_features, like we do for the usual MSAs.
Alternatively you can replace any of the MSA tool outputs with your custom MSA by creating a file with the appropriate filename in the MSA output directory (e.g. bfd_uniclust_hits.a3m) and running with --use_precomputed_msas. If you opt for this option then note that you'll also need to provide MSA files for the other MSAs, even if they're blank. Also note that they should be located in a directory called msas within the output directory specified when running using the --output_dir flag.


Compatibility issue with combat carousel control button

The combat carousel icon (on the bottom) isn't made smaller.

Hi @yjeroen thanks for reporting this
Not my intention to sound blunt, but Minimal UI does not make any particular distinction between control buttons. Adding a particular exception for Combat Carousel would be unfair from my side. This should be reported over to Combat Caroussel, so the module owner uses standard Windows properties, like the rest of the buttons.

Understand your point!
I've also opened an issue on their end:
https://github.com/death-save/combat-carousel/issues/125

Thank you, I hope this can be resolved on the other side of the story! It is indeed a nice module. Ping me again if you get resistance on the other side, I can consider some hacky wacky stuff, but hopefully not!


fix: type conversion for primary keys in create/update

IMPORTANT: This PR is a requirement for merging this PR
Changes in this PR:

added a type conversion of the primary key to the create/update resolvers

An integration test is missing, will be added soon


[BUG]: PGLiteWorker does not work

What version of drizzle-orm are you using?
0.33.0
What version of drizzle-kit are you using?
None
Describe the Bug
Cannot instantiate a drizzle pglite based instance with PGLiteWorker. This seems to be due to a structured cloning error.
This is caused by trying to send the functions over the broadcast channel here https://github.com/drizzle-team/drizzle-orm/blob/c8359a16fff4b05aff09445edd63fc65a7430ce9/drizzle-orm/src/pglite/session.ts#L34-L51.
Once I removed those functions it works fine.
If there's interest in fixing this I'd be happy to submit a quick PR for either just removing those lines or having a separate implementation for the worker type.
Expected behavior
PGLiteWorker (multi tab instance) should work as well as the in memory PGLiteWorker (
Environment & setup
No response

I'm having the same issue

I had started the process of writing a patch for this, but had the foresight to check https://github.com/electric-sql/pglite. Turns out they're aware of the issue, and have already fixed it in v0.2.6 with https://github.com/electric-sql/pglite/commit/ef57e10686dbe83fa00d293c44dfe91e53b79bd7.
I can confirm that it works in my project.


Add support for FluffOS dynamic include paths

A function in the master file can dynamically add include paths to each file. These get added to the list of global include paths.
string *get_include_path (string file) {
    string *path = explode(file, "/") - ({ "" }), *paths = ({ ":DEFAULT:" });
    switch (path[0]) {
        case "domain":
            paths += ({ "/domain/" + path[1] + "/include" });
            break;
    }
    return paths;
}

The language server will need to support this to properly resolve macros used in these affected files.
More details here: https://www.fluffos.info/apply/master/get_include_path.html

Closed by PR #22. Will be released in v1.0.17


Send "Unmute" on volume change

My monitor requires sending "Unmute" command over DDC after a volume change for that change to take effect.
I've added an option into the UI to enable this behavior.
Might fix problems for some people in this issue - https://github.com/MonitorControl/MonitorControl/issues/1369

My 2c, as an end user: the setting may be somewhat confusing.
If it's only a single monitor that needs this hack, I would consider following:

check if monitor firmware can be updated
ask on mastodon/reddit/twitter to see if monitors of other models / from other manufacturers need this
add some kind of clarification, e.g. send unmute on volume change (fixes Macintosh 512K display) or a url link to github issue where folks can report their monitors

I'm having an issue where after muting os doesn't unmute displays until fill restart. hopefully fixes my issue too, would be cool to test a build. running 27UK850 over USB-C

@zv0n - I'll close this PR as honestly I am somewhat undecided whether to add it or not. Also, there is no new app release planned anytime soon. However it is clear that this change is useful to some, so I recommend having a fork with this available and maybe provide an alternate build in your repo + open a discussion with a link over there about it in this repo. I can pin the discussion so it does not get lost. Does that sound fair?


Cache fixes

Fixing cache polution when putting an item with the same key multiple times
Making shift() to reduce the current size of the cache

wow, didn't know the cache had bugs all along!

yeah, it happens so that I have this other issue that I have templates with whitespace in the beginning that started putting a lot of items in the cache, this is how I found it :)


Compatible with XCode 10 and Swift 4.2

Compatible with XCode 10 and Swift 4.2
NSAttributedStringKey' has been renamed to 'NSAttributedString.Key
Replace 'NSAttributedStringKey' with 'NSAttributedString.Key

Hi, I am going to review the pull requests and release a branch or 4.2 next week.

Hello, Can i know when you are going to release a new version ?

My super mega popular app crashed. Could you please update lib to swift 4 and xCode 10

I am sorry this library is already Swift 4.0 and it is compatible with XCode 10. You just need to keep "compile with Swift 4.0" in your pod. Your entire project (codes and other pods) can be compiled by Swift 4.2 while ActiveLabel is still on 4.0 without any problem.
I just released a new version of my app with the same situation without any crash nor problem. Your crash must have some other reasons.
I do agree the version 4.2 is a must and as soon as I come back from my trip when I have my dev resources I will finish it, but you can do as I mentioned if it is mandatory to go with Swift 4.2.

@maziyarpanahi thank you

Hi guys,
Here is the release: https://github.com/optonaut/ActiveLabel.swift/releases/tag/1.0.1


Better usability for other Projects

For other projects, some adjustments have to be done.

Can be closed or still in progress?


Todo: Protocol Override

todo, protocol override feature.
protocol.register.override.csv
ie,
snre_v1.7.holding_registry_map.override.csv
so that users can override specific registers or variables without having to copy a protocol into .custom. allowing for updates to user edited protocols.
would use a two key approach.
primary key would be the documented name, secondary would be the register address.

46094b4ca99881411a23439481ce71f341ca1a91
56b8c6b132b10cd38bcacd918c519323905ab29e
implemented, but i'm not sure how stable it will be. i don't feel entirely confident in the implementation.
the two key approach should work...
8ac4a56ee4b3c80ed5e3f456461e67aaf382a9b1
added to the readme to explain things...
not the most clear.

Where exactly should I place it? In protocols/srne/ beside the original one?

yup

Funny it's not working.
➜  docker exec -it addon_local_python-protocol-gateway ls -la /app/protocols/srne
total 56
drwxr-xr-x    1 root     root          4096 Oct 30 22:55 .
drwxr-xr-x    1 root     root          4096 Oct 30 22:55 ..
-rw-rw-r--    1 root     root          2936 Oct 30 21:53 srne_2021_v1.96.holding_registry_map.csv
-rw-rw-r--    1 root     root           104 Oct 30 21:53 srne_2021_v1.96.json
-rw-rw-r--    1 root     root         13780 Oct 30 21:53 srne_v1.7.holding_registry_map.csv
-rw-r--r--    1 root     root           636 Oct 30 22:41 srne_v1.7.holding_registry_map.override.csv
-rw-rw-r--    1 root     root           104 Oct 30 21:53 srne_v1.7.json
-rw-rw-r--    1 root     root          6222 Oct 30 21:53 srne_v3.9.holding_registry_map.csv
-rw-rw-r--    1 root     root           104 Oct 30 21:53 srne_v3.9.json

➜  /config docker exec -it addon_local_python-protocol-gateway cat /app/protocols/srne/srne_v1.7.holding_registry_map.override.csv
variable name,data type,documented name,writable,values,unit
,,Battery Over Voltage,RW,36~62,0.2V
,,Limited Charge Voltage,RW,36~62,0.2V
,,Equalizing charge voltage ,RW,36~62,0.2V
,,Boost Charge Voltage Or Lithium Over Voltage,RW,36~62,0.2V
,,Float Charge Voltage Or Lithium Over Charge Return Voltage,RW,36~62,0.2V
,,Boost charge return voltage ,RW,36~62,0.2V
,,Over discharge return voltage ,RW,36~62,0.2V
,,Under_voltage warning voltage ,RW,36~62,0.2V
,,Over discharge voltage ,RW,36~62,0.2V
,,Limited discharge voltage ,RW,36~62,0.2V
,,Mains switching voltage ,RW,36~62,0.2V
,,Inverter switching voltage ,RW,36~62,0.2V

In logs:
INFO:classes.protocol_settings:loading override file: protocols/srne/srne_v1.7.holding_registry_map.override.csv
INFO:classes.protocol_settings:loading override file: protocols/srne/srne_v1.7.holding_registry_map.override.csv

BTW I released a new version of the add-on with support for adding any file to /config/python-protocol-gateway: b65abffbfed9affd56dd6ffd7ae27d6df1dc194a.

oops, i fail. the code right above was the unit bit.
d79fdb7195b1624c4cdb19298b799fb26eaa5412
bit of re-arranging and bug fixing. should work now.

Awesome, it worked now. All good.


Add consistent metadata for docker images produced by egeria

Egeria's docker images initially tended to carry additional metadata in the form of
# Image metadata following http://label-schema.org/rc1/
LABEL org.label-schema.name = "RangerAdminForEgeriaVDC"
LABEL org.label-schema.description="Apache Ranger Admin service to support Egeria VDC demos"
LABEL org.label-schema.url="https://github.com/odpi/egeria/"
LABEL org.label-schema.vcs="https://github.com/odpi/egeria/tree/master/open-metadata-resources/open-metadata-deployment/docker/ranger-admin"
LABEL org.label-schema.version="0.2.0"
LABEL org.label-schema.schema-version = "1.0"

(This example was from ranger)
Over a few changes metadata has been dropped from some images, but it's a good opportunity to review what is actually useful.
http://label-schema.org/ proposes some standards upon which these were based - but egeria images were very early on in the dev cycle
Some thoughts

build-date helps consumers understand when a docker image was built
urls and description are good for general info
vcs references are useful, though it can sometimes be tricky to determine which vcs revision to use. The build process for the docker image can contribute a version easily, but since many images work by downloading git assets, that may be a better version, yet tricky

etc...
Raising in ref to https://github.com/odpi/egeria/pull/1043#issuecomment-492979761

build-date helps consumers understand when a docker image was built

I'm not convinced...  Docker already tracks this independently of the labels (ie. you can see the age of an image on Docker Hub, locally via docker images, etc), and even the MicroBadger site gives the creation date irrespective of whether it was in a LABEL in the image or not.  I'm thinking it might be more trouble to try to work out injecting this label consistently as part of an automated build, and then leaving people to wonder whether this label or the other dates from Docker itself are correct, creates more trouble / confusion than it's worth (?)

The label-schema.org proposal has now been superceeded by the OCI container spec
https://github.com/opencontainers/image-spec
Suggest going with the commit above go retrofit/improve the original labels, then leave this to understand the OCI spec better... there are other related aspects here such as docker alternatives & build pipelines

Are you sure these are equivalent?  OCI image spec looks much more like the technical description of the contents of the image itself -- eg. akin to what you see when you do a docker image inspect <image> and get an output of its filesystem layers, etc.  (Which is all built for you automatically as part of the docker build ... process...)  I'd put the responsibility on the build process to automatically construct such detail, ie. if possible on docker itself to conform to the OCI image spec standard (?)

I should have been more specific
https://github.com/opencontainers/image-spec/blob/master/annotations.md
And yess... there is investigation needed, hence the suggestion we keep this open until we investigate more fully.


working on jupyter but not jupyterhub

I love the idea of sorting and filtering my dataframes in the notebooks directly. i tried to install qgrid on my local and on a remote system on jupyterhub. without success.
what i did
I did pip3 install qgrid and after importing qgrid I tried a qgrid.show_grid(df) right away. no success, no output.
so i additionally ran: qgrid.nbinstall(overwrite=True)  i read about in the demo.
symptoms are

it can't access the css and js files: https://blabla.com/hub/nbextensions/qgridjs/lib/slick.grid.css Failed to load resource: the server responded with a status of 404 (Not Found) in the chrome console and I receive a 404 in the logfiles of jupyterhub for those files:
if i use jupyter notebook with jupyter notebook instead of jupyterhub on my local system it works and everything is loaded correctly
if i use jupyterhub and start show_grid with show_toolbar=True parameter and click on Export. qgrid is loaded all of a sudden and everything is loaded.

any idea where i can look into? thanks

I have the exactly same issue.
Functions call by clicking on "Export" toolbar are : display_html and display_javascript
while show_grid call function display
any idea ? thanks

Thanks for the detailed report.  I haven't tried qgrid with jupyterhub yet, but based on what I'm reading online, it seems widgets that work with jupyter notebook should also work on jupyterhub.  Did you happen to try any other widgets to see if you could get them working? If other widgets are working and qgrid is the only widget that's not then there's probably a bug I need to fix.
If you're not able to get widgets working with jupyterhub at all, this thread might be helpful: https://groups.google.com/forum/#!topic/jupyter/n-GI5uNuHNU

I suspect that @rushtehrani is correct. This is happening for us on multiple JupyterHub servers and it only affects qgrid.

I got exactly the same problem when running with jupyterhub.
All other widgets are working. And I definitely have the same python running.
Is there a workaround to correct the url-path?  It sounds easy to fix, but I don't know where to do that.

Thanks for all the info.  I was able to reproduce this, and I'm working on a fix for it.  I don't have a quick fix in mind but I have another larger project in progress that I know will fix it.  Basically I'm going to update the packaging/deployment so that it behaves just like other widgets, which will also make it work in jupyterhub.
In the meantime you can get around this issue by setting the remote_js option to True before attempting to call show_grid in your notebook.  If you've already called show_grid with remote_js set to it's default value of false, you may need to clear all cell output and refresh the page (using your browser's refresh button) for this workaround to take effect.
Since you'll always want remote_js to be True, the easiest way to do this is probably to execute  qgrid.set_defaults(remote_js=True) in any notebook in which you want to use qgrid.  You can also pass this option into the show_grid function itself, as described in the docs here: http://qgrid.readthedocs.io/en/latest/#qgrid.show_grid

Great! This worked for me. Thanks.

I am (I think( running into this issue. I am running Jupyter via Jupyter hub and I all I get when I do show grid is a little X where the widgets go.  I tried the remote_js and it's still not working here... where should I look for logs that can help me troubleshoot? My jupyter notebook server doesn't having any glaring entries that concern me...

@JohnOmernik if you open up your browser's developer tools (on Chrome and OS X it's under View -> Developer -> Developer Tools) and then click on the Console tab you might see some errors there that could help us diagnose the issue.

So I see a request for
https://jupyterhub-mainhub-prod.marathon.slave.mesos:22443/hub/nbextensions/qgridjs/lib/slick.grid.css
Which I get a 302 found with a location of /hub/nbextensions/qgridjs/lib/slick.grid.css
Which then I get a not found (404) request for: https://jupyterhub-mainhub-prod.marathon.slave.mesos:22443/hub/nbextensions/qgridjs/lib/slick.grid.css 404
(Also for qgrid.css) Does that help?

Yea that's helpful.  It seems like the remote_js=True setting has not taken effect in your notebook.   I would expect qgrid to be attempting to load those css files from https://cdn.rawgit.com/quantopian/qgrid/ if remote_js=True was working.  I think maybe what's happening is you have another cell in your notebook where rendering qgrid failed, and the output from that cell is saved with your notebook.  To clear that cell output, and make sure it's javascript doesn't run again you can try the following steps:

In the notebook menu, clear all cell output:

Save the notebook (with all your cell output cleared).
Click the refresh button on your browser to refresh the page.
Before attempting to call qgrid.show_grid, execute a cell with qgrid.set_defaults(remote_js=True)
Now try and render your qgrid with a call to show_grid or by constructing a QGridWidget directly and displaying it.

If that doesn't work it might be that your browser is doing some aggressive caching so you might try disabling caching in your browser temporarily while you're going through these steps.  Normally the way I do this is by enabling Disable cache (while DevTools is open) in the settings for Chrome's dev tools, and then leaving the dev tools panel open while I'm troubleshooting.

Ok, walking through all of that got working.  So for Jupyterhub, the trick is to use remote_js=True (and ensure things aren't cached).

Yea that's the situation for now.  The next release I'm working on will eliminate the need for this workaround.

Hi,
I have the same problem with JupyterHub. No errors but the grid doesn't show.
Unfortunqtely using qgrid.set_defaults(remote_js=True) did not solve the problem. Any other suggestions ?
Thanks !

@hbensalem I just discovered that qgrid is not working with ipywidgets 7.x (it only works with 6.x).  I have a new branch of qgrid that will work with 7.x, and I'll likely merge it soon in light of this discovery.
Could you check your version of ipywidgets, and if it's 7, try using 6 instead if possible?

This is fixed in qgrid 1.0, which is currently available in beta form.  See the installation instructions on the updated readme page.
To use qgrid with Jupyterhub, simply install it according to the installation instructions on the readme in the same environment where you're running Jupyterhub. The special steps I've listed above should now be unnecessary.


0.27 release do not work with iOS Share Extensions

Since 0.27 version, we're not able to use RestKit because the AFNetwork version dependency isn't compatible with iOS Share Extensions (refer to this issue).
The version that RestKit is supporting of AFNetworking isn't updated to support iOS Share Extension, because it doesn't care about the definition of AF_APP_EXTENSIONS. I'm not very familiar with the dependency of AFNetworking here, but is there a possibility to move to 3.x version of AFNetworking?
The errors:
AFURLConnectionOperation.m:302:25
/Users/rafaelks/Projects/WHI/Pods/AFNetworking/AFNetworking/AFURLConnectionOperation.m:302:25: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.

AFURLConnectionOperation.m:365:53
/Users/rafaelks/Projects/WHI/Pods/AFNetworking/AFNetworking/AFURLConnectionOperation.m:365:53: 'sharedApplication' is unavailable: not available on iOS (App Extension) - Use view controller based solutions where appropriate instead.

Since 0.27 version ...

The AFNetworking version hasn't changed, it's still 1.3.4. It has only been wrapped.
Are you trying to use RestKit or AFNetworking in your extension?
I am not sure this was working before either, if it was for you, could you please describe your project setup?
Also, the error you are getting are from AFNetworking files with AF prefix. Everything has been renamed AFRK.
You can now install AFNetworking 3.0 and do whatever you like with it, meanwhile RestKit will continue use 1.3.4 internally.
So if you just want to use AFNetworking I don't see the issue here.

@valeriomazzeo You're complete right. AFNetworking 1.3.4 was from another dependency in the project. I got confused, lol. It's all fine now, thank you!

Although, if you want to use RestKit directly in an extension and for some reason it doesn't work, please add an example project to the repository and we can have a look :)

Sure! I'll make the changes here and see if works. If not, I'll send the report. Thank you!

@valeriomazzeo RestKit is really not working with Share Extension. I've created an example project so you can take a look on the problem: RestKit Share Extension.zip

Hi @rafaelks, thanks for reporting this.
I am afraid I won't be able to look into this anytime soon.
In the meantime a pull request that adds share extensions support is definitely welcome.

@valeriomazzeo That's fine. The problem is inside the AFNetworking dependency, maybe we can wait until RestKit migrates to AFNetworking 2.0 or 3.0?

The problem is that AFNetwoking is using  sharedApplication to update the network indicator and background download. A simple fix (if you can live without it) is to branch RestKit, use this as your Pod and comment out then offenders.
  [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:[self isNetworkActivityIndicatorVisible]];


caddy: 2.7.6 -> 2.8.1

Description of changes
Updates caddy from version 2.7.6 to version 2.8.1. This commit also adds the nobadger build tag, which prevents the badger-db implementation of NoSQL from being compiled.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4010

I'm not sure we should actively migrate code over to another code formatter. At least, I'd leave it up to the individual package maintainers for now.
Squashing it into the same commit that does a bump makes this very hard to review. Please make it two separate commits at least, or leave the reformatting up to the maintainers, or a tree wide formatting, if that happens at some point.

Done! I made them separate commits.

Thanks! Bump changes LGTM, but let's have the package maintainers decide about the PR.

CI check fails because of a trailing comma and still missing the release note links in the commit message.
It's fine if you only change the CI check failure. I can squash-merge your commit and fix the commit message that way.

CI check fails because of a trailing comma and still missing the release note links in the commit message.
It's fine if you only change the CI check failure. I can squash-merge your commit and fix the commit message that way.

All done! Sorry for the formatting issues and thousands of force-pushes!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1707

Bumped up to 2.8.2.

You previously had a vendorHash mismatch, but you seems to have fixed it as part of the 2.8.2. That's good.
Now it actually builds :)
However, 2.8.3 will get released soon, so I'd propose to wait for it first.
We could merge 2.8.2 but that would leave us with an unnecessarily buggy version 🫣

and thousands of force-pushes!

No worries, even thousands of force-pushes are fine.
Arguably GitHub does not handle it all too well, but nixpkgs decided to use force-pushes anyway, so that just how it is :)

https://github.com/caddyserver/caddy/releases/tag/v2.8.4

Updated to 2.8.4!

Please check the failing CI output, you now introduced trailing whitespace.

Please check the failing CI output, you now introduced trailing whitespace.

Fixed. The text editor I use needs to get EditorConfig support QUICKLY.


Fixed controller and closing issues

Two things were fixed here:

Some of the channels were triggering an exception when closing (copied from @qsz13's fork).
Missing sequence_num on some packets, which made the input not work at all.
Y axis were inverted and all analog were overflowing when trying to send the packets, so I've (poorly, granted) limited them.

Tested on Xbox One S with client being Ubuntu 20.04 LTS and a Xbox 360 wireless controller through an USB adapter.

Hey @rgsilva - sorry for the late response, I didnt get a notification.
Thanks for bringing these issues and @qsz13's fork to my attention.
Could you please install the branch https://github.com/OpenXbox/xbox-smartglass-nano-python/tree/merge/qsz13_contribs and give it a try. It should contain all the needed fixes
Why an own branch and not simply accept the current PR?
I would simply like to keep the original fork's git history.


Training cost

Could you please tell me the training cost for this project, i.e. how many GPUs, how long to finish the training process?

It costs about 1.5 days to train a ConcatResNet model on the Event dataset with a single V100 GPU card. Training a model with the same settings on View costs three times of time.


Date Localization for axis type "time"

Feature Requests
Checklist

[ Yes ] My feature request is specific to victory-native. (Feature requests that do not specifically address native functionality should be opened here)

[ Yes ] I've read through the Docs and Guides to make sure this functionality doesn't already exist

[  Yes ] I've searched open issues to make sure I'm not opening a duplicate issue

Description
Can we add Date Localization for axis type "time" ?
I went through the documentation and couldn't get any reference to it.

You can format your tick labels using the tickFormat prop. Here's more information:
https://formidable.com/open-source/victory/docs/victory-axis/#tickformat


Sort query by positive - negative

Hi @hauntd ,
The new attributes and the behaviours are great, I've been able to get them to work - thanks.
Your interfaces make it easy to get negative, positive statically and with two calls we can compute positive - negative. However I've not been able to figure out how to sort a query output with the voting result (The position of each entry in the result is the result of the expression positive - negative). This will make it possible to sort lists based on up down votes of users.
Is this possible? Or can this be achieved only by making changes to getVoteAggregate in VoteBehaviour?
Regards,
Adam

Let's say you have following module configuration:
'modules' => [
    'vote' => [
        'class' => hauntd\vote\Module::class,
        'controllerMap' => [
            'default' => 'app\controllers\VoteController',
        ],
        'entities' => [
            'itemLike' => [
                'modelName' => app\models\Item::class,
                'type' => hauntd\vote\Module::TYPE_TOGGLE,
            ],
        ],
    ],
],

Item model code:

use hauntd\vote\behaviors\VoteBehavior;
use yii\db\ActiveRecord;

class Item extends ActiveRecord
{
    public static function tableName()
    {
        return '{{%item}}';
    }

    public function behaviors()
    {
        return [
            VoteBehavior::class,
        ];
    }

    public static function find()
    {
        return new ItemQuery(get_called_class());
    }
}

ItemQuery code:

use hauntd\vote\behaviors\VoteQueryBehavior;

class ItemQuery extends \yii\db\ActiveQuery
{
    public function behaviors()
    {
        return [
            VoteQueryBehavior::class,
        ];
    }
}

Sort items by "likes" (desc):
$query = Item::find()
    ->withVoteAggregate('itemLike')
    ->withUserVote('itemLike')
    ->orderBy('itemLikeRating desc'); // or orderBy('itemLikePositive desc')

$dataProvider = new ActiveDataProvider([
    'query' => $query,
    'pagination' => [
        'pageSize' => 50,
    ]
]);

Hope this helps.

Hi @hauntd ,
Thanks for the response, I believe that approach covers Sorting items by "likes" or even "Favorite".
My question goes to sorting items by "Vote" considering that the voting result is managed separately in the attributes positive and negative.
if the entity definition is as follows;
'modules' => [
'vote' => [
...
'entities' => [
'itemVote' => common\models\Item::class,
],
],
],
Remember we want to sort items by the result of positive - negative (to get an item's true position in the list, an item can have 13 positive votes and 200 negative votes so its position will be 13 - 200 = -187 )
Will the following query be valid?
$query = Item::find()
->withVoteAggregate('itemVote')
->withUserVote('itemVote')
->orderBy('itemLikePositive - itemLikeNegative desc')

@dbd5, oh I see. Well, this should work:
 $query = Item::find()
    ->withVoteAggregate('itemVote')
    ->withUserVote('itemVote')
    ->addSelect('(itemVoteAggregate.positive - itemVoteAggregate.negative) as rating')
    ->orderBy('rating desc');

(vote table alias = "{entity}Aggregate", in this example itemVoteAggregate

Perfect, I will test and revert
Thank you

It works great, thanks!


[CHE-245] iOS SDK Vault fixes 🏦

CHE-245
What this PR does
This PR updates the vault feature of the iOS SDK to fix some bugs and refactor part of the SDK.
Notable decisions & other stuff
This is part of the ongoing refactoring work for the SDK and aligns with upcoming changes to the official documentation.
Before merging
QA

[x] I manually tested this with a demo application (simulator)
[ ] I manually tested this with a demo application (real device)
[ ] I wrote unit tests for each new util-like function
[ ] I wrote at least basic e2e tests for the new functionalities or new paths
[ ] If this PR introduces UI changes, I manually tested this PR on iPhone 8 (iOS 10, 12, 14), iPhone 12, and iPhone 12 Max
[ ] If this PR modifies the behavior of an API, I did my best to make my new API backward compatible
[ ] If this PR modifies the API, I attempted to implement the feature with an example

Documentation

[x] If this PR modifies the API, I updated the API Reference.
[x] If this PR adds new options to the API, I wrote some documentation or guide in the online documentation
[ ] If the PR modifies the API, I wrote some documentation to deprecate it

After merging

Make sure a new release has been pushed to Cocoapods trunk

I’m just leaving a couple of notes before I close the PR
PrimerSessionFlow.default.vaulted changed from true to false and default uxMode from .vault to .checkout. Is that the desired behaviour?
If that is what we need, then all the rest seem good 💯

I’m just leaving a couple of notes before I close the PR
PrimerSessionFlow.default.vaulted changed from true to false and default uxMode from .vault to .checkout. Is that the desired behaviour?
If that is what we need, then all the rest seem good 💯

Yeah, that's what we want :)


Add cloudflare-dyndns chart

Tagged as WIP because I want to make sure everything is good before going ahead with the merge.

@billimek I am currently deploying this without a chart as seen here
https://github.com/onedr0p/k3s-gitops-arm/tree/master/deployments/default/cloudflare-ddns
It's up to you if you want to pull this into your repository, not sure how many others would benefit from this.
Do you think the way secrets are handle would allow for seal-secrets or vault to control them? I am ignorant of how that happens in a chart like this.

Thanks for submitting this!  I think the secrets handling is fine.


amazing rotating cube animation

Describe the Feature you want to end

i want to add this amazing rotating cube animation
Expected behavior

Screenshots (optional)

https://github.com/pranjay-poddar/Dev-Geeks/assets/120590200/ef22714c-6152-4b71-8dbb-fc12af296939
Additional context (optional )

@MohitGupta121  @TusharKesarwani please assign this issue to me

@MohitGupta121 @TusharKesarwani please assign this to me

@MohitGupta121 @TusharKesarwani please review it asap


Improve UI of Login and Registration Page

The UI of the Registration and Login can be improved

I would like to work in this issue

@deoruchi Yes please proceed 😇.

@deoruchi ?

please review my PR


Add Azure build badge

Use the following template for your PR (make sure you follow our
guidelines:
Title:
[Descriptive but using as few words as possible]
Description:
[Link to the GitHub issue it solves (if any)]
Summary:
[Include a brief summary of your changes]

Hi @ryjones - thanks for the PR. We currently use AZP for code coverage calculation in this project. The primary tests are still being run by Actions (see https://github.com/hyperledger/aries-framework-go/pull/1001/files#diff-04c6e90faac2675aa89e2176d2eec7d8R5).


Add a environment var step in container app creation

Fixes https://github.com/microsoft/vscode-azurecontainerapps/issues/32
The UI for the step:

Proposal to make this a codicon we can use in the "Skip for now" step:


Trailing commas are not removed from arrays when target is ES3

TypeScript Version:
this is a regression from TS 1.0
Code
var x = [1,]
console.log(x.length);

Expected behavior:
length is 1
Actual behavior:
On ES3 engine length is 2, on an ES5 one length is 1.

+1

+1


fix(ui): only show on-chain transaction fee widget for onchain transactions

Description:
Only show fee widget for onchain transactions
Motivation and Context:
Transaction fee widget was recently added to the pay form, but it's currently showing up if you try to pay a lightning invoice with a zero amount. It should only show for onchain transactions.
This PR ensures that it only shows for onChain transactions.
How Has This Been Tested?
Try to pay a LN invoice with a 0 amount, eg https://tippin.me/@mrfelton and verify that the onchain transaction fee widget does not show.
Types of changes:
Bug fix
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.005%) to 21.073% when pulling a840e58e8a0dec9b2b62c338c121e06addf48489 on mrfelton:fix/only-shew-fee-widget-for-onchain-transactions into 28ef4e6e278ec4b2c8a2d63d8d302e522b490108 on LN-Zap:next.

Coverage decreased (-0.005%) to 21.073% when pulling a840e58e8a0dec9b2b62c338c121e06addf48489 on mrfelton:fix/only-shew-fee-widget-for-onchain-transactions into 28ef4e6e278ec4b2c8a2d63d8d302e522b490108 on LN-Zap:next.


[WIP] vscode-extensions: auto-update many

Motivation for this change
Keeping extensions updated is normally a thing you want to do,
but I'm too lazy as to do it manually on a daily basis so I'm:

Extending a little bit the current script with a feature flag that updates the code in-place and even do the commit
Updating my extension set to their latest version
If you agree, I could work on applying this strategy to more packages, similar to what niv and nixpkgs-updated do. With small refactors auto-updating is easy
This PR seems big, but read it 1 commit at a time and it'll be easier

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127741 at 814b40da run on x86_64-linux 1

7 packages built successfully:

vscode-extensions._4ops.terraform
vscode-extensions.coenraads.bracket-pair-colorizer-2
vscode-extensions.haskell.haskell
vscode-extensions.ms-python.python
vscode-extensions.ms-python.vscode-pylance
vscode-extensions.ms-toolsai.jupyter
vscode-extensions.tamasfe.even-better-toml

@jonringer can you review this?

do you mind adding a doc/languages-frameworks/vscode.section.md with some instructions on how to update the extensions?

do you mind adding a doc/languages-frameworks/vscode.section.md with some instructions on how to update the extensions?

Actually I really like the idea, I'm gonna work on it

@kamadorueda you can maybe take some inspiration from https://github.com/NixOS/nixpkgs/pull/113280#issuecomment-871937609 where I also wrote documentation on VSCode extensions.
For what it's worth, I'll maybe see if I can just add another shell script or so which let's users update extensions from STDIN rather than getting them from VSCode, which is a bit brittle. I think the current script doesn't even consider all possible binary names.
So in other words, my typical use case is "foo.bar" | update_ext rather than always updating all of them at the same time.


Rename xdf-Python to xdf-python

I know this is a tiny nitpick, but could we rename this repository to xdf-python (with a small p)? It kind of hurts my eyes everytime I look at it (which is admittedly a very subjective argument), and not mixing upper and lower case in names also causes fewer problems (e.g. on non-case-sensitive file systems that are still used e.g. on macOS by default).

Looks good to me. IIRC Github will automatically redirect the old URL to the new one when moving the repository, but I don't know if it also does it when renaming it. Still, better now than later.

In this case it doesn't even matter, because https://github.com/xdf-modules/xdf-python is already working (URLs are generally not case-sensitive).

i second it, good idea to change to lower-case.

Alright, then I'll make the change. @cboulay @tstenner @agricolab you might want to change xdf-Matlab as well.


URL link overlaps

Description
when creating a very long URL it overlaps
Screenshots

Additional information
No response

Hello @origranot can you assign the issue to me.
Regards,

That's a good catch, I assigned you to this issue 👑


Wrong path in config option

The usage output says gnmic.yaml instead of .gnmic.yaml.
--config string            config file (default is $HOME/gnmic.yaml)

Also the documentation page does not mention anything about the default configuration file name.

you are right, the usage output is outdated.
the documentation page that explains the config files name and location is here

Thanks a lot for providing the correct documentation and fixing the usage text.


clicking links ( elements) with href omitted or with an empty href incorrectly generates External UrlRequest's

Empty links, i.e. a elements without a href attribute or with href "" will cause External UrlRequests to be generated, and if handled as suggested in the Elm guide will cause page reloads.
This can be handled in update if you know about it, but is non-standard behavior that I think would surprise most people. it is also behavior that a lot of code depends on, among them  elm-bulma, and it miight therefore not be immediately apparent what the cause is.
As far as I can understand, the standard behavior is:

When href is omitted it should not be considered a hyperlink (source)
When href is an empty string, it should be considered a reference to the beginning of the document (source)

My suggestion is to simply not emit a UrlRequest if href is omitted, and to emit an Internal UrlRequest if it is an empty string.
Here's a minimal, complete and verifiable example:
module Main exposing (main)

import Browser
import Browser.Navigation
import Html exposing (..)
import Url

type alias Model =
    ()

type Msg
    = UrlRequested Browser.UrlRequest
    | UrlChanged Url.Url

init () _ _ =
    ( (), Cmd.none )

update msg model =
    case msg of
        UrlRequested (Browser.Internal _) ->
            ( model, Cmd.none )

        UrlRequested (Browser.External url) ->
            ( model, Browser.Navigation.load url )

        UrlChanged _ ->
            ( model, Cmd.none )

view model =
    { title = ""
    , body = [ a [] [ text "click to reload" ] ]
    }

main =
    Browser.application
        { init = init
        , view = view
        , update = update
        , subscriptions = \_ -> Sub.none
        , onUrlRequest = UrlRequested
        , onUrlChange = UrlChanged
        }

My solution/workaround is to add a branch in update to do nothing on External "". For others coming across this looking for an easy fix, here's the fixed update function:
update msg model =
    case msg of
        UrlRequested (Browser.Internal _) ->
            ( model, Cmd.none )

        UrlRequested (Browser.External "") ->
            ( model, Cmd.none )

        UrlRequested (Browser.External url) ->
            ( model, Browser.Navigation.load url )

        UrlChanged _ ->
            ( model, Cmd.none )

As far as I can tell:

clicking test does nothing (.href === undefined)
clicking test</test> is like refreshing the page (.href === location.href)

clicking test is like refreshing the page (a.href === location.href)

Hmm, indeed. I'm not able to read that from the spec(s), though it seems Elm kind of accidentally does the right thing then. And while it would still seem technically correct to generate an Internal UrlRequest, perhaps that would just make it more cumbersome to get the expected behaviour. I'm not even sure what I'd consider expected behavior in an SPA though.

This was reported on browser already: https://github.com/elm/browser/issues/34

Ah, thanks @MethodGrab! And a proposed fix is in elm/virtual-dom, so it seems the issue is well-covered.
I'd close this if it weren't for the issue with empty (as opposed to omitted) hrefs that's not covered by that issue and fix. I'll happily migrate this issue to a more suitable project though.