WIP: Twig 2.x support

This PR adds support for Twig 2.x.
This makes the package no longer compatible with Twig 1.x and requires PHP 7.0+, so it will require a new major release if merged.
Already passes test suite and seems to work fine in a minimal hello world app, but I still want to test this with some real apps in the next couple of days.

Better late then never I suppose. Updated the branch-alias to 0.11 so we can test that.


[FSunstone] Expose individual disk restores

Description
Ability to select which disks should be included in a VM restore operation.
Use case
Easily select one or multiple disks from a datatable when restoring a backup.
Interface Changes
Add a new subtab Disks under the detailed container view in the Storage/Backups tab.

Additional Context
This functionality has already been added in OpenNebula/one#6269. The plan is to add the DISK_IDS  to the backup image's metadata. This way no additional API changes are needed in FireEdge.

Progress Status

[x] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

Needs tests + docs


[add] types to kitsu input

Motivation for changes:
Kitsu input doesn't support the types from the API, so if someone needs to add the series in one list and the movies in another one are pretty hard, this adds the type option similar to my_anime_list input.
Detailed changes:

Adds type option to filter the results

Documentation of Options:

Types strings[]:

type.ona "ONA"
type.ova "OVA"
type.TV "TV"
type.movie "movie"
type.music "music"
type.special "special"

Looks good to me, thanks!


Inserting picture using Tempblob.FromBase64String doesn't work anymore

Previously inserting a picture from a Base64 string worked fine using TempBlob.FromBase64String.
I used this for initiating a setup table like this:
begin
    IconText := 'Base64 string';  //To long for this example
    Clear(TempBlob);
    TempBlob.FromBase64String(IconText);
    Record.Picture := TempBlob.Blob;
end;

Looking in the record it shows the bytes for this field but picture is not shown on page.
Versions:

AL Langauge: 2.0.48254

Business Central: 25789

Issued is solved. Apparently find and replace is not always your friend. In this case it corrupted my Base64 strings.
Sorry.


HTML

User Story
As a bootcamp student
I want the prework note to be structured on a webpage
so that I can easily find and read information
##Acceptance Criteria
Given a Prework Study Guide website
WHEN I visit the website in my broswser
THEN I see four boxes titled HTML,CSS,Git, and JavaScript with associate notes listed

html issue completed


Fix build warnings

Depending on the dsdl definition files, the libcanard compiler can generate code with warnings. This patch remove all warnings for dsdl files found in libuavcan repository (tests, and standard uavcan)/
What it does:

mark a lot of function parameters as maybe unused, to suppress gcc warning
use two differents macros for signed and unsigned saturation

I agree with you. This is cleaner with smaller lines


Update specification Eastron SDM 720-MC

$${\color{green}\space ' + specnames + '\space validated\space successfully}$$
Specifications 'eastronsdm720-m.yaml' have no issues


release: v0.3.0

Description

Resolve the issue about external dependency injection.

Checklist

[x] Add labels and reviewers ?
[x] Are you fully explaining what you changed ?
[x] Did you check that there is no conflict with the base branch ?

nice welcome 0.3.0~!!!


VSCodeInsider_Settings_AI4D : (Code - Insiders/text '') The Name property must not contain any characters in the private Unicode range.

The following accessibility issue needs investigation.
App: Code - Insiders
Steps to Reproduce

Launch Visual Studio Code application.
Navigate to the "Settings" button in the left navigation bar and select "Settings" from the flyout that appears.
Select the "Extensions" option under the "Commonly Used" setting and expand.
Select any of the extensions from the list then details would appear at the right.
Launch the AI4D and inspect the right panel.

Element path: text ''
Issue Details: The Name property must not contain any characters in the private Unicode range. Section 508 502.3.1
How To Fix: Modify the Name property, removing all characters in the range U E000 to U F8FF and replace them with meaninful, standard text content.
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.
Attachment:

This is a false positive. The content of that element is a character for a custom font that shows an image, so there is no text content. I see the same warning all over the app.


Custom Phone field

Hi, i'm trying to hide the country code and custom a circle flags. How can i do that . Thanks

Open the file intl_phone_field.dart and check for the text widget of the country code and you can remove it
About the circle flag, unfortunately, the package uses flags as characters not images.


libGLEW SIGABRT

I'm new to rbfx. Built with no problems but starting Editor got SIGABRT signal with message:
free(): invalid pointer
Rebuilt in DEBUG mode and found out that problem is in the glew.c at line 13380
free(extStart);   // rbfx: Fix memory leak.
Commenting out this fixes the problem.

What platform did you test on? I suspect we are facing an inconsistent driver behavior.

Ubuntu 20.04 x64. Nvidia 450.80.02 drivers.

This change was reverted a while back.

This change was reverted a while back.


[Github] Fix error with consecutive cart proccesing

Get extension from original promotion LineItem and assign it to new LineItem

1. Why is this change necessary?
If a promotion LineItem was added to the cart the extension was not added correctly, because of which an error
occurred when the processor was called again.
The LineItem (the discount) was added again because the processor looked for the id
in the extension which wasnt there. All this led to an error when saving the cart, due to the promotion LinteItem  being duplicated.
2. What does this change do, exactly?
The PromotionDeliveryCalculator searches the oldCart for the promotion,
if it already exists it adds the extension to the new LineItem.
3. Describe each step to reproduce the issue or behaviour.
Prerequisites:

Create a Promotion which discounts the shipping costs by 100% and set it to active. (Shopping basket rule could be
value>100)

Execution:

Go to admin page and open order overview page
Open existing order or create one with atleast one item and open it
Add another item to the cart (should still trigger the promotion)
Add another item to the cart (Price will not be calculated)
Try saving the order -> error

'Line item with identifier "018faf405d697431beb99530f3145ab0" is not stackable and the quantity cannot be changed.'

(The discount Item)
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfill them.

Imported from Github. Please see: https://github.com/shopware/shopware/pull/5420

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-40015, comment 524909]

[public]

Priority changed to: High

Thank you for your report. Based on the information in this report, we have decided to investigate this issue in more detail and are planning to provide a fix for this issue. Although we are always eager to solve such problems as soon as we can, we can't give you a more specific time frame right now. We appreciate your patience and thank you for your understanding.
[created from NEXT-40015, comment 524910]


Long desired state attribute name overlaps in Resource Details views

We should probably make the name wrap to the next line when it's really long.

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @Stijnkool @wouterdb


CB-14223 Install NiFi Registry Gateway on all hosts with NiFi service…

…. Added NiFi Registry Gateway role to Flow templates 7.2.12. New role will be installed on hosts with NiFi, we need that to get NiFi Registry url from NiFi.
See detailed description in the commit message.

@doktoric could you please review/merge this PR? We need it asap, because it's release blocker. Thank you.


[mesheryctl]Adding dashboard command to mesheryctl system

Signed-off-by: Ayush PS<EMAIL_ADDRESS>Description
This PR aims to fix #3035
Tasks

[x] Base command to display the endpoint in the terminal
[x] Base command to open the endpoint in the browser
[x] Testing connection to UI
[ ] For Kubernetes if not accessible initial kube proxy tunnel

Notes for Reviewers
Not Ready for review yet
Signed commits

[x] Yes, I signed my commits.

@DantrazTrev This issue got to be platform-dependent. We need to implement a Kube proxy tunnel in case of Kubernetes as a platform.

@piyushsingariya I'm waiting to hear something about the bug related to UI endpoints in kubernetes env https://layer5io.slack.com/archives/C019426UBNY/p1625136547045900?thread_ts=1625136547.045900&cid=C019426UBNY
But yeah I would try to implement that meanwhile

@DantrazTrev This issue got to be platform-dependent. We need to implement a Kube proxy tunnel in case of Kubernetes as a platform.

Hei @piyushsingariya can you help me with the kube-proxy part , I'm not sure what's the exact command to use ?

Codecov Report

Merging #3375 (d5701ed) into master (51f242e) will increase coverage by 4.18%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage    7.65%   11.84%   +4.18%
==========================================
  Files          33       36       +3
  Lines        2716     2812      +96
==========================================
+ Hits          208      333     +125
+ Misses       2461     2412      -49
- Partials       47       67      +20

Flag
Coverage Δ

e2etests
?

gointegrationtests
?

integrationtests
?

unittests
11.84% <3.22%> (+5.50%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/dashboard.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/stop.go
1.08% <0.00%> (ø)

mesheryctl/internal/cli/root/system/system.go
68.00% <100.00%> (+1.33%)
:arrow_up:

mesheryctl/internal/cli/root/system/check.go
1.94% <0.00%> (-34.96%)
:arrow_down:

mesheryctl/pkg/utils/healthcheck.go
18.75% <0.00%> (-7.34%)
:arrow_down:

mesheryctl/internal/cli/root/system/channel.go
18.82% <0.00%> (-1.69%)
:arrow_down:

mesheryctl/internal/cli/root/config/config.go
1.04% <0.00%> (-1.19%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.50% <0.00%> (-0.54%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.50% <0.00%> (-0.04%)
:arrow_down:

mesheryctl/pkg/utils/helpers.go
0.00% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39efa8e...d5701ed. Read the comment docs.

@DantrazTrev, I get excited each time I look at the subject line of this PR. Don't tease me like this. 😉
In all seriousness, it would be great to have this command. I believe that implementation here will need to use or enhance MeshKit's capabilities. // @Aisuko

Hei @leecalcote I believe there is just one major step left which is setting up a kube proxy tunnel for k8s when needed.  However this part is the one where I've been facing a few issues since simple kube proxy tunnels don't really work and also the endpoint for k8s is often incorrect so the tunneling would happen either way .
I'll try my best to solve it although some dependent issues might need to be figured out first.

Thanks for ping me, sir @leecalcote . If I understand right by the context, we want to achieve the feature is localhost open an proxy the dashboard. I believe that similar with the osm dashboard  command.
https://github.com/openservicemesh/osm/blob/7ef0c4723cc52a17feb8b8b744960a497e067d59/cmd/cli/dashboard.go#L65

Right. Or another example is linkerd dashboard

Thanks for this review, @Aisuko. What do you think, @DantrazTrev?

@Aisuko, perhaps, you'd like to carry this forward?

@leecalcote No problem sir, I will do. Mid month I will move the home between two cities. I would schedule this after that.

Thank you @Aisuko This needs some thought put into it to make sure that we get the correct endpoint. We would have to work to enhance the function in MeshKit.

@Aisuko @leecalcote I'm closing this PR as this would be reworked.

@navendu-pottekkat No problem.


Add tests for project.load_module_recursive() method

Description
Added tests for project.load_module_recursive() method.
closes #3208
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in 568f786aad7594cb9a91ced32aae6b2c08316528


Font size dropdown?

Right now it seems like any changes to font size has to be done with Header H1, H2, H3 tags.  But I see there is a working font size functionality that accepts double or int (https://github.com/singerdmx/flutter-quill/pull/487/commits/0c3fb6ff1a90bbb68f1f183a63e34f784ce657a6).  That one works very well
Is it possible to get a drop down selector to directly select font sizes (eg. 12, 13, 14, 15, 16, 17, etc..)

@mark8044 Not a lead dev here, just commenting from the side. This can be planned as a future feature. I suppose for the moment the desire was to have as few taps as necessary. At the moment if you really want multiple selection of styles in a dropdown you will have to implement a custom Toolbar that recycles all the buttons from the existing one and then add the dropdown yourself wherever you want it. Fortunately each single button from the Toolbar is encapsulated in it's own Widget so they can be easily reused. On the other editor side you can override the default styles using the customStyleBuilder property in QuillEditor. At some point in time I might spend time on this feature since I desire it myself for my own project. Also something nice to have would be the ability to switch between several styles. If you want to hear updates on the progress join the unofficial Quill discord server that I run.
Ex:
  DefaultStyles _quillStyles() => DefaultStyles(
        paragraph: _textStyle(),
        placeHolder: _textStyle(
          overrideColor: widget.placeholderColor,
        ),
        h1: DefaultTextBlockStyle(
          TextStyle(
            fontSize: 28,
            color: _theme.mainTextColor,
            height: 1.7,
            fontWeight: FontWeight.w600,
          ),
          const Tuple2(70, 20),
          const Tuple2(0, 0),
          null,
        ),
      );

Thanks for the reply!  I'm not meaning multiple selection of styles, but a new button, similar to say the Bold or Italic button, except it would give a font-size to the text.  Font-size is already fully functional within quill, it just needs a button to be able to access it.  In this case, the button would ideally present some kind of drop-down with choices.
I guess that brings up a side question, do we have the ability to add our own buttons in?

Not sure if in the default Toolbar but for sure you can create a new toolbar using the existing buttons + new custom buttons

Not sure if in the default Toolbar but for sure you can create a new toolbar using the existing buttons + new custom buttons

Yes that's 100% possible, but it seems like it should be integrated into flutter_quill since the core functionality is already there and works wonderfully.
@singerdmx If I try to make a pull request with a separate font-size dropdown widget, would you be against merging that into flutter_quill?

Go ahead

@singerdmx
Hi I think I have gotten it to work.
I am just finalizing a few things to give user ability to input the range of values they want, it should only take a short little while longer.
I saw that class QuillDropdownButton is marked as depreciated, so I refactored it for this purpose and I'm using it successfully here, are you ok with that?

Ok I aded this pull request, lets see what you all think. https://github.com/singerdmx/flutter-quill/pull/790

Ok it got merged 🥇


‘dev’ branch compilation issues

Discussions for https://github.com/aspnet/Announcements/issues/150

@victorhurdugaci Are you going to update the myget feed with latest developer versions before the transition to the CLI. They have not been updated for a month currently and it will really help people like me who are building ASP.NET packages and using a lot of the framework's infrastructure classes and interfaces. Thank you for your answer in advance.

@ivaylokenov Converting ASP.NET and EF packages to use dotnet CLI has been disruptive as called out in the announcement post, and we are working through several issues, including build and test failures. This is the main reason why aspnetvnext feed has not been updated in a while.
If you're willing to play with the bleeding edge, you can try the packages from our dev feed (aspnetcidev). Be warned though, these packages are unsigned, and also they are not tested at all. So things may or may not work.

@muratg Sadly, that (the cidev) feed seems to be stuck in time as well

@ericstj Last set of packages are 5 days old, I think that's recent enough for if you really want to play with the latest bits.  The packages in aspnetcidev feed are considered "coherent", meaning that we at least know the packages have matching versions and their dependencies between themselves are correct.
For more details about our feed details, please see @victorhurdugaci's notes here.

@muratg Thanks, will take a look at the cidev feed!

@muratg I'm on the CI feed with dotnet cli projects. Talking about "dev branches" isn't very specific. Is this Announcement primarily referring to changes with the aspnetvnext feed? ... or should those of us on the CI feed also be freezing package references for a bit?

@GuardRex This announcement is about the stability issues in dev feeds across all aspnet repos. These issues prevent us from creating tested and signed packages to feed into aspnetvnext feed.
If you've been using asnetcidev feed for development, you're already on the bleeding edge. The packages there are not tested or signed.
As soon as we're unblocked with these changes, aspnetvnext would have tested/signed packages that you can move to.
For more information about the feeds and how they're used, feel free to check out this: https://github.com/aspnet/Home/wiki/NuGet-feeds

Whoop! Its alive...

:tada: Congrats to the team! :tada:

:fireworks: Congrats! :tada:

Now to have a date for the actual RC2. :wink:

:clap: :confetti_ball: :tada:

Anyone have repro steps to build? I've cloned the Home repo and tried running dotnet restore with dotnet run with no luck in samples/latest/{HelloMvc,HelloWeb}.
Just for science.

@mikehaas763 we didn't update the samples in the Home repo yet. Sorry. Try the ones in entropy

https://github.com/aspnet/cli-samples

:+1: to what @davidfowl says. I have been keeping cli-samples in the working state.


BasicRelationalConverter.writeValue(…) assumes eager entity conversion [DATAJDBC-476]

Mark Paluch opened DATAJDBC-476 and commented
Calling writeValue(…) attempts first to write an entity through its identifier. Only if no entity information was found, the write value conversion falls back to simple types.
In other store modules (such as MongoDB), write value conversion attempts a simple value/simple conversion approach first and then falls back to entity conversion.
Eager entity conversion comes with undesired effects such as if a PersistentEntity gets created for a simple type, the conversion treats the simple type as an entity

Reference URL: https://github.com/spring-projects/spring-data-r2dbc/issues/283
Issue Links:

DATAJDBC-450 Storing non root entities in serialized form

This was addressed via #1593


System::type_id Consistency

Objective

Fixes #11679

Solution

Added IntoSystem::system_type_id which returns the equivalent of system.into_system().type_id() without construction. This allows for getting the TypeId of functions (a function is an unnamed type and therefore you cannot call TypeId::of::<apply_deferred::System>())
Added default implementation of System::type_id to ensure consistency between implementations. Some returned Self, while others were returning an inner value instead. This ensures consistency with IntoSystem::system_type_id.

Migration Guide
If you use System::type_id() on function systems (exclusive or not), ensure you are comparing its value to other System::type_id() calls, or IntoSystem::system_type_id().
This code wont require any changes, because IntoSystem's are directly compared to each other.
fn test_system() {}

let type_id = test_system.type_id();

// ...

// No change required
assert_eq!(test_system.type_id(), type_id);

Likewise, this code wont, because System's are directly compared.
fn test_system() {}

let type_id = IntoSystem::into_system(test_system).type_id();

// ...

// No change required
assert_eq!(IntoSystem::into_system(test_system).type_id(), type_id);

The below does require a change, since you're comparing a System type to a IntoSystem type.
fn test_system() {}

// Before
assert_eq!(test_system.type_id(), IntoSystem::into_system(test_system).type_id());

// After
assert_eq!(test_system.system_type_id(), IntoSystem::into_system(test_system).type_id());

I've added some unit tests which cover exclusive function systems, and function systems. They ensure that the TypeId value is consistent between System and IntoSystem implementations, and also consistent with TypeId::of::<T::System>() where T is the IntoSystem type. I've also updated the description of this PR to explicitly call out exactly what cases will require some kind of migration work.


crictl can't pull images with proxy

when I pull an image with crictl, like
crictl pull docker.io/library/alpine:latest

There was an error:
FATA[0030] pulling image failed: rpc error: code = Unknown desc = failed to resolve image "docker.io/library/alpine:latest": failed to do request: Head https://registry-1.docker.io/v2/library/alpine/manifests/latest: dial tcp <IP_ADDRESS>:443: i/o timeout

crictl version info:
Version:  0.1.0
RuntimeName:  containerd
RuntimeVersion:  v1.1.0
RuntimeApiVersion:  v1alpha2

I have already exported http_proxy on my machine, and other commands like wget, curl works well, ctr also woks well, like:
ctr images pull docker.io/library/alpine:latest

ctr does use golang HTTP_PROXY. https://github.com/containerd/containerd/blob/master/cmd/ctr/commands/resolver.go#L88
For crictl we can't support it on the client side, because CRI doesn't have a proxy parameter. However, we can support containerd daemon level HTTP_PROXY config.
I'll do it.

For crictl we can't support it on the client side, because CRI doesn't have a proxy parameter. However, we can support containerd daemon level HTTP_PROXY config.

Agreed. crictl doesn't need proxy because it only talks to local runtime's unix socket while the image is actually pulled in runtimes.

@Random-Liu Thanks a lot:)

Close.

Is there any update on this or any PR that fixed this ?

Never mind.. setting containerd service file as mentioned here https://github.com/containerd/cri/issues/834 worked for me.


Demonstrate gating an image on CIS audit failure

In order to meet container scanning criteria, we want to demonstrate removing an image from the ECR if it fails a CIS audit.
Acceptance Criteria

[ ] If an image fails a CIS audit, ~it is removed from ECR~ it is not promoted to production
[ ] An image CIS failure in staging triggers an "alert" for review

Security considerations
Removing the image from the ECR will improve security by not allowing use of an image that isn't properly hardened.
Implementation sketch

[ ] Update code to disallow the promotion of images from staging to production if they fail the CIS Audit
[ ] Upon failure of CIS Audit an alert is sent out via Slack and Email with the offending image and resulting scans

@pburkholder or @Chiakao should confirm requirements here, we may not need to re-do compliance scans for images in 'prod' since compliance doesn't age out (until there's a new OS).

Summary of progress so far:

Script to audit hardened containers is here: https://github.com/cloud-gov/container-scanning/blob/audit-gating/ci/audit-ecr-container.sh (note the topic branch)
That bash script calls this python script: https://github.com/cloud-gov/container-scanning/blob/audit-gating/ci/parse_cis_audit_html.py

Items to do:

Possibly modify script to change printing failure to exit 1 or similar
Gate image promotion based on script results
Alert on audit failure

Rather than using python or grype, maybe xmllint is the way to go?
xmllint --xpath "//*[name()='score']/text()" Would get us the score value from the xml file.
This does require us to install xmllint on the image

Created a ticker for deleting files after running usg tasks to a separate ticket: https://github.com/cloud-gov/product/issues/2596 since this doesn't actually apply until we are running the audit script before creating the image.


add unit of time (ms) to log basic log format latencies's properties

https://getkong.org/plugins/tcp-log/ (in all logging plugins)

Is this issue still open or has it been resolved?

This issue has been addressed.


[Bug]: defineProperty behavior is inconsistent with reality in JSDom

Version
29.7.0
Steps to reproduce
/**
 * @jest-environment jsdom
 */

describe('test', () => {
  it('test', () => {
    const obj = {}
    Object.defineProperty(obj, 'tt', {
      writable: false,
      value: 1,
      configurable: true
    })
    expect(obj.tt).toBe(1)
    Object.defineProperty(obj, 'tt', {
      writable: false,
      value: 2,
      configurable: true
    })
    expect(obj.tt).toBe(2)
  })

  it('jsdom', () => {
    Object.defineProperty(window, 'tt', {
      writable: false,
      value: 1,
      configurable: true
    })
    expect(window.tt).toBe(1)
    Object.defineProperty(window, 'tt', {
      writable: false,
      value: 2,
      configurable: true
    })
    expect(window.tt).toBe(2)
  })
})

Expected behavior
expect consistent behavior of defineProperty on window
Actual behavior
jsdom test case not pass
Additional context
I thought it was a jsdom problem, but I only used jsdom for testing and the result was ok
const jsdom = require('jsdom')
const { JSDOM } = jsdom

const dom = new JSDOM(`<!DOCTYPE html><p>Hello world</p>`)

Object.defineProperty(dom.window, 'JSB', {
  writable: false,
  value: undefined,
  configurable: true
})
console.log(dom.window.JSB) // undefined
Object.defineProperty(dom.window, 'JSB', {
  writable: false,
  value: 1,
  configurable: true
})
console.log(dom.window.JSB) // 1

Environment
System:
    OS: macOS 13.4
    CPU: (10) arm64 Apple M1 Pro
  Binaries:
    Node: 18.20.4 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 6.14.16 - /opt/homebrew/bin/npm
    pnpm: 7.29.1 - ~/Library/pnpm/pnpm

Well, I looked at the code of jest-enviromment-jsdom and found that it was caused by instantiating the jsdom configuration. This seems to be a problem with jsdom. I have submitted an issue on jsdom.


feat/custom-metadata

A question, and a feature request if there is no easy answer.
I want to add custom metadata to my documents, for example a uuid for each doc from some custom mapping function.
Not sure what the 'right solution' is, but it seems like having a 'metadata phase' in the pipeline where we get access to the doc and some mapping function to generate and inject metadata
Describe alternatives you've considered
I considered pulling from a datasource like OpenSearch (i see i can get meta and doc id from OpenSearch as default) but I have binary full docs to be parsed, while it seems like the OpenSearch connector only expects text documents to partition/chunk.
I would want the OpenSearch connector to allow me to retrieve the binary doc, and then parse it as per its type (docx, pptx, pdf, html...)
maybe there are solutions, I haven't found in the docs.

How are you using unstructured? Like directly via calls to partition_{doctype}() in Python? Or maybe using the ingest CLI or the API?

@scanny
I am using the Python methods, using a runner, with partionner etc... to process batches of docs.
I have docx, pptx, html and pdfs docs, which I want to parse, OCR when there are images etc... and chunk
but I also need the full docs or page by page index.
for context, I'm doing RAG with the docs, with hybrid search. In hybrid search, we want to do semantic search on embedded chunks, but it is not effective to do lexical search on those same chunks, because lexical search gives best results when done on larger size docs (because TF-IDF can promote the weight of the uncommon words, but can't do that well on small chunks)
So, I want/need multiple indices for each doc in the end:

the full doc, which can be referenced and downloaded
page by page docs text, which can be used for lexical search
chunks, embedded, for semantic search.
Problem is, the only common thing I have to work with is the filename, and this is not a very robust way of referencing documents.
Especially in my case I have multiple languages, and files names sometimes get weird depending on encoding set on the machine processing them. Also, sometimes the docs are translated, and the filename is also translated, yet I want to reference it as the same doc id.
Ideally I want a unique uuid for each doc.
Ideally I want to process a single doc in multiple ways (full doc binary, page by page binary and text, embedded chunks) and send them to multiple indices.
I don't see a way to do this but by processing the same file with multiple pipelines, but then the globing, etc... is outside of my control, and so is the id set for the doc.
I'm thinking if I can inject some metadata somehow, I'd be able to set a uuid as metadata, it would be a more robust way to reference the file in the final datastore, in any index, than using the filename.

@streamnsight it sounds like you would like access to interim pipeline work-product, like maybe being able to register an event handler like after_partitioning(elements: list[Element]) -> list[Element] function that gets called by the pipeline once for each document after it's been partitioned or something, does that sound about right? Such that you could enhance the metadata for each element before it proceeds to the next step?
Nothing special about the partitioning step of course, there could be "after" events and maybe "before" events for each step in the pipeline with document granularity I suppose.
Is that the sort of thing you're proposing?

@streamnsight can you provide a sketch of the code you're using? Not all the details, just the top-level. like 10-15 lines at most with ellipses for lower-level details.
I have another idea that might work with the current capability. Basically breaking the pipeline into two sections where you partition the batch to disk, make changes to that copy, then feed them into the "tail-end" pipeline.

@scanny
It's really very simple:
            processor_config=ProcessorConfig(...),
            connector_config=SimpleLocalConfig(
                input_path=folder,
                recursive=True,
                file_glob=['*.pdf', '*.docx', '*.pptx']
            ),
            read_config=ReadConfig(),
            partition_config=PartitionConfig(...),
            chunking_config=ChunkingConfig(...),
            embedding_config=EmbeddingConfig(...),
            writer=OpenSearchWriter(...),
            writer_kwargs={},
        )

This is for semantic search chunks. For the other indices I actually just load and dump into OpenSearch, with an extra step with PDFReader to extract the pages / page text.
Ideally, I'd want a system that can do
Read from file --─> Parse -> chunk -> embed -> Write to 'chunks' (for semantic search)
               ├─> Parse -> split on page -> extract page text -> Write binary encoded page + text / meta to 'pages' (for lexical search)
               └-> binary encode -> Write to index 'full-docs'

or eventually I can do
Read from file -> binary encode -> Write to index OpenSearch 'full-docs' (with meta uuid ...)

then
Read from 'full-docs' -> get object + meta -> parse binary encoded object -> chunk -> embed -> write to 'chunks'
Read from 'full-docs' -> get object + meta -> parse binary encoded object -> split on page -> write to 'pages'

so the pipeline is linear (as I understand unstructured runner do not run a DAG but a linear set of stages.)
Anyway, from what I understand, for this kind of flexibility I should just be importing the raw methods and build my own DAG / pipeline.

I think you'll need a certain amount of your own "pipeline" code, just a question of how much leverage you can get from what's already there.
I'm not an expert on the ingest code, but from what I can tell there are 3 + N steps:

get documents from source, e.g. download them from s3 or load them from local filesystem
partition the documents, each to a list[Element] serialized to JSON
run N reformatter steps
write the documents to the destination, e.g. a database or whatever.

So the flexibility afforded is in source and destinations chosen, the 0..N reformatter steps (includes chunking, embedding, etc.) specified, but also in the possibility of using "null" steps.

There is a download_only option in the source config somewhere which allows the prior-to-partitioning steps to be run by themselves.
Partitioning a JSON file simply deserializes the elements in that JSON file, so this essentially skips the partitioning step if you have some customized way to produce the list[Element] normally produced by a partitioner as JSON.
I expect there are ways to add customized reformatter steps by implementing a defined interface.

So by combining "partial" runs or creating custom reformatter steps perhaps you can get the results you're after.


Update qarmin.czkawka.cli.installer.yaml

Resolves #140367

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

No errors to post.

(Automated response - build 794.)

@wingetbot waivers Add Validation-Executable-Error


onl: clean up build and reduce amount of variables needed

Make use of the ONL build system to autodetect build paths, which allows
us to reduce the amount of variables significantly, basically reducing the
need to define any ONL_* variables by machines.
For each platform in ONL there exists a package named onlp-.
Using the ONL package manager (onlpm), we can find out where in the
filesystem this package is located, and do not need to hardcode the path
to it anymore.
Sideeffect is a slight increase in build time, as it needs to build its
package database on the first invocation, which delays the build by a
few seconds.
Signed-off-by: Jonas Gorski<EMAIL_ADDRESS>

Build fails with the following error on the 4630 platform.
make: Leaving directory '/tmp/accton-as4630-54pe/work/accton_as4630_54pe-poky-linux/onl/1.1+gitAUTOINC+dd61cc1792_8621a0bab7_4bd372b724-r0/git/packages/base/any/onlp/builds/onlpd'
Traceback (most recent call last):
File "tools/onlpm.py", line 23, in <module>
       import lsb_release
       ImportError: No module named lsb_release
WARNING: exit code 1 from a shell command.
ERROR: Execution of '/tmp/accton-as4630-54pe/work/accton_as4630_54pe-poky-linux/onl/1.1+gitAUTOINC+dd61cc1792_8621a0bab7_4bd372b724-r0/temp/run.do_compile.23331' failed with exit code 1

This python2 thing is getting annoying. Let's fix it. Will rebase onto #52, then this won't be an issue anymore.

Updated and rebased on master with the switch to python3:

fixed some leftovers in the python3 conversion patch
removed the need for the lsb_release python module
dropped BISDN_ONIE_PLATFORM


remove-helm-keep-on-mp

What this PR does / why we need it

Remove "helm.sh/resource-policy": keep annotation from node pool resources to properly delete them when it is removed from helm values.

/run cluster-test-suites

/run cluster-test-suites


Fix prestissimo to ignore curl error message unless error code is set

There's currently a bug in curl 7.64 where it puts host not resolved errors in the error buffer even though the host has been found and the download was successful.
This bug is causing prestissimo to claim that it failed to download most of its packages, thus causing composer to download them again serially.
While the bug is in curl, according to the libcurl man page, the error buffer should be ignored unless an error code is returned, so prestissimo shouldn't be checking the error buffer when determining whether a download succeeded.  This patch contains the fix.

Coverage increased (+0.09%) to 81.527% when pulling 9e1705a56aa8f76a5d786ff3e575f40ec2084d4a on jonathandieter:master into 783cd5ccc1c6840c33fa798bda327ebb146cf738 on hirak:master.

Coverage increased (+0.09%) to 81.527% when pulling 9e1705a56aa8f76a5d786ff3e575f40ec2084d4a on jonathandieter:master into 783cd5ccc1c6840c33fa798bda327ebb146cf738 on hirak:master.


quickwit: 0.8.0 → 0.8.1, init module

Description of changes

https://github.com/quickwit-oss/quickwit/releases/tag/v0.8.1

Adds a module and tests for Quickwit.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[X] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There seems to be some merge conflicts, otherwise this looks good to me

Fixed.


cook: equip installer windows with always-on-top attribute

It is annoying that wine windows are not handled properly by some WMs when being hidden.
Better make them always visible during install!

how can this be done?

Check out xdotool for that...

this issue has vanished in more recent version of Mate. No idea which DEs will have that issue, so closing for now....


Update CHANGELOG.md

trivial fix to changelog entry

jk, I think this was fixed in #3935 right?

you got it


Adding StructBot to Mergo in the wild section

I've recently released StructBot aimed at simplifying struct initialization for test cases. The patch functionality contained in the library leverages Mergo under the hood so I thought this would be a worthy addition.

@tjpnz Nice project, thanks!


Create Quiz game in python

plz merge my file

Hi, your game isn't made in pygame and can't be merged (as per contribution guidelines written in README file).


[Feature Request] Ability to change what shows on the attributes gui

Hey there I wanted to be able to change what attributes could be shown on the gui pages.
I have a mod that supplies my with a new attribute projectile damage and I wanted to be able to show that in the place of the bonus ranged damage that this mod supplies as this attribute lets me scale the damage as i wanted. when i found out my only option was to change this in the mod myself it felt a bit silly for something this minor.
If this is not something you are willing to do I understand. It just makes sense to me that you would be able to show any attribute on the gui

Hi there,
My apologies for the late reply. You are correct in that to have your attribute displayed on the gui page you would need to develop an addon mod. I understand this frustration, especially when everything else is completely configurable - however, under the hood gui changes are much harder to add configuration for, and harder still when considering things like text scaling, localisations, and adding vs. overriding text.
That said, whatever scaling is implemented for your new projectile damage attribute, the existing bonus ranged damage attribute can likely be configured to scale in the same way and do the same things, which would negate the need to have a new attribute displayed.
Thanks.


storage/stream: Add persistent write progress to stream_flash

Add additional API to stream_flash that can be used to make
stream write progress persistent using the settings subsystem.
This functionality makes it possible to resume a write operation
after it was interrupted, e.g. by power loss.
Signed-off-by: Jonathan Nilsen<EMAIL_ADDRESS>

@nvlsianpu @de-nordic could you please take another look?

@hakonfam can you revisit?


Fix/2110 new filename

Summary of the changes
Moves to a more choherent naming convention.
Related issue
Fixes #2110
Checklist
General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.

Hi @evenstensberg, thank you for your contributions! Please consider picking up a ticket from our backlog for future contributions. Issues that labelled are "Good first issue" and have the status: "Ready for dev"   are a good place to start. These are tickets that have gone through our triage process and have been assessed as work we'd like to do

Okay 👍🏾

Closing as this change is not needed

@GCHQ-Developer-112 The reason for these small PRs is that I had some nitpicks that might improve the project such as adding nvmrc etc. It's optional to merge them, meaning the commits are not significant for the project, but sometimes nice to implement.

@evenstensberg we appreciate external contributions and appreciate the value these changes can bring 😀
Where there are changes, such as the file name change in this PR, that don't offer much value, we're more likely to close them. PRs such as the cspell PR on the other hand are useful as it's clear so spelling mistakes have been missed during our review process.
To prevent time being spent on an issue that we may decide is not the direction we want to go in, I advise waiting for the issue you've opened to be triaged. Through the triage process, we decide whether we think the work is of value or not. If it's work we plan to do, its status will be changed to design to do, in refinement or ready for dev. If not, the issue will be closed. This was the reason I directed you to our issues that labelled are "Good first issue" and have the status: "Ready for dev"

Gotcha. Will fix the cspell PR then have a look at the kanban board.


update pca docs

doc updates for PCA
esp clarify use of sparse matrices and add more examples

closing because just see the PCP needs edits too.
will combine the 2 in later pull request


Adjust PR CI

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Adjust PR CI info
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


Fix for #5750 - Refuse to use regexes with g or y flags in contexts

What kind of change does this PR introduce?
Fix for #5750. Adds a warning if the g or y regex flag is passed to a context, and causes the context to become empty.

Did you add tests for your changes?
No. Does this warrant a new test?

If relevant, link to documentation update:
No new documentation. The error message copy is "Contexts can't use RegExps with the 'g' or 'y' flags."

Summary
Using the g or y flags causes files to be missing from a context. See #5750.

Does this PR introduce a breaking change?
Previously, using the g flag could output garbage, now it always outputs a warning and an empty context.

Other information
Nope

If I generate the error in ContextModuleFactory.resolveDependencies, I can't easily get the code location of the error. Is this version I just pushed ok?

Thanks


About model transfer

Here you said "we use the pretrained model's weight from this project and have converted the weight to adapt our model", could you share the code how to convert the weight to adapt the model? Thank you very much.

In fact, some committed codes in train.py are used to convert the weight from another pre-trained model


Tracking issues of StreamPark 2.2.0

This issue intends to track some features in streampark version 2.2, We plan to release this version before 2024. If you are interested in some part of this issue, please feel free to walk in and take it. Let’s make streampark to be a better project
Feature

[ ] 1. pyflink support
[x] #3280
[ ] 3. refactor deploy flink on k8s with flink-k8s-operator
[x] #3281
[ ] 5. flink cluster state tracking
[ ] 6. code-style-and-quality Improve
[ ] 7. integrate StreamPark with Sql Gateway
[ ] 8. job state auto-probe
[ ] 9. blog i18n support
[ ] 10. Improve k8s documentation

Improve K8S documentation

https://github.com/apache/incubator-streampark/issues/3218 finsh

@wolfboys Flink-Kubernetes-V2 support flink1.18


Merge dev

Description of change
Merging dev into v2.
Type of change
Choose a type of change, and delete any options that are not relevant.

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix

How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.

[] My code follows the contribution guidelines for this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes

LGTM


Support Ubuntu 16.04 and PHP 7

By default it's hard coded to php5
Also get this error:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter include on Apt::Source[newrelic] at /etc/puppet/modules/newrelic/manifests/params.pp:44

Not sure about Ubuntu 16.04 but I was able to overwrite the php5 modules directory in hiera like this:
----
newrelic::agent::php::newrelic_php_conf_dir: '/etc/php/7.0/mods-available'

I'm installing PHP7 on Ubuntu 14.04 and this seems to work.

    class {'newrelic::agent::php':
      newrelic_license_key  => 'somelicensekey',
      newrelic_ini_appname  => $newrelic_name,
      newrelic_php_conf_dir => '/etc/php/7.0/mods-available',
    }


Update React element creation to be faster (probably)

Remove _store and update order of object keys to always match the order used by React itself (https://github.com/facebook/react/blob/v16.0.0-rc.2/src/isomorphic/classic/element/ReactElement.js#L123) and by babel-plugin-transform-react-inline-elements (https://github.com/babel/babel/blob/v6.26.0/packages/babel-helpers/src/helpers.js#L51)
Switch to a function making the objects at a single callsite which should have a lower parse cost and be better for hidden-class-ness in engine optimizations (the reason React.createElement itself is slow-ish is that it loops over the props and copies them to a new object, which we avoid here)
Require that the key is already a string or null (which React expects) and add casts in reactFor and list/table output to cast ints to strings explicitly (casting to string could also be done inside reactElement)

Thanks! Super excited for reactElement to be simplified.
Sorry for the delay; I had life & was stalling on rebasing my local changes on top of this <3


Feat/kukai embed

Test WebGL build with sample: https://static.turborouter.keenetic.pro/unity/
(Note: first load is not so fast due to server bandwidth)

Resolves #70


Not working without an internet connection

i have downloaded the model on device

Can you provide any error/log messages you're seeing?

Error: Model not found. Please check the model or repo name and try again.
Error: Error Domain=NSURLErrorDomain Code=-1009 "The Internet connection appears to be offline." UserInfo={_kCFStreamErrorCodeKey=50, NSUnderlyingError=0x300170bd0 {Error Domain=kCFErrorDomainCFNetwork Code=-1009 "(null)" UserInfo={_kCFStreamErrorDomainKey=1, _kCFStreamErrorCodeKey=50, _NSURLErrorNWResolutionReportKey=Resolved 0 endpoints in 1ms using unknown from cache, _NSURLErrorNWPathKey=unsatisfied (No network route)}}, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <3FB8886B-5E9F-4F5A-9AD6-ECA1FE4D9554>.<2>, _NSURLErrorRelatedURLSessionTaskErrorKey=(
"LocalDataTask <3FB8886B-5E9F-4F5A-9AD6-ECA1FE4D9554>.<2>"
), NSLocalizedDescription=The Internet connection appears to be offline., NSErrorFailingURLStringKey=https://huggingface.co/api/models/argmaxinc/whisperkit-coreml, NSErrorFailingURLKey=https://huggingface.co/api/models/argmaxinc/whisperkit-coreml, _kCFStreamErrorDomainKey=1}

Is this from the WhisperAX app we distribute on TestFlight or in your own project where you depend on WhisperKit as a package?

depend in it as a package

If you're using it locally, you need to pass a modelFolder into the init function, otherwise it will attempt to download the model based on its name. Here is the relevant code: https://github.com/argmaxinc/WhisperKit/blob/c2f1b57266bee2deeeac1d7014e1c05bcd32119a/Sources/WhisperKit/Core/WhisperKit.swift#L251
let localPipeline = try await WhisperKit(modelFolder: "path/to/your/model/openai_whisper-tiny")

It is working now thanks.


Option to skip initial build when using watch flag

Feature request

Option to skip initial build when using watch flag.
What is the expected behavior?
When --watch --skip-initial-build, the skip-initial-build flag tells webpack not to build initially, but instead build on subsequent detected changes.
What is motivation or use case for adding/changing the behavior?
When working with mono-repos that have multiple packages where some packages depend on higher level packages, developers must build the top level dependencies first, then watch everything.
So imagine there are two packages a and b
b depends on a, so to successfully build b, a must already be built.
Developers would:
build a
watch a && watch b
b will automatically rebuild when it detects a change to a, which the initial build from watching a will produce.
This triggers a waterfall of builds when starting.
a, b, a, b
You can only imagine how bad it gets in projects with a few too many packages
If a developer could skip the initial building on a watch the flow would be
build a
build b
watch skip a && watch skip b
How should this be implemented in your opinion?
Are you willing to work on this yourself?
Added a pull request
https://github.com/webpack/webpack/pull/9735

We can't skip the initial build as it's needed to figure out dependencies that need to be watched.
We could skip the initial emit.
But I think the better way to solve this is to avoid emitting assets if it matches the file on disk. This won't require a flag and will speed up all builds when assets already exist.

That's fair. The change in my PR only skips the initial emit behind a flag.
Great idea. Any clues on where that belongs? I might spend some time trying to add it in.

Alright, I have changed the option in my PR to watchOptions.skipInitialEmit = false and added tests to cover the behaviour.
https://github.com/webpack/webpack/pull/9735

Hey, any updates on this?

updates on this? very needed

+1

+1

Don't know how long this request will take. I wanted the feature so I had a look at the merge request.
The request itself is fairly simple. Though it's not recommended, you can apply the changes yourself. Just be aware that these changes will be overwritten during webpack updates
https://github.com/webpack/webpack/pull/9735/files#

Bump

Bump

I want to close it in favor https://github.com/webpack/webpack/issues/4991, because duplicate

I want to close it in favor https://github.com/webpack/webpack/issues/4991, because duplicate


Fork failure with FI

$ hub fork
Error creating fork: Length Required (HTTP 411)

Thanks @kergoth. Try it now with hub from master, I think I've fixed it

That fixed it, thanks!


Automated Package Upgrade

:tada: This PR is included in version 2.2.166 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Storing tasks for a long time can hold onto the ExecutionContext which can leak memory (like the HttpContext)

MVC has a couple of places where it stores Tasks in the MemoryCache or a dictionary for a long period of time. That can result in capturing the HttpContext and other ambient async locals which may result in a memory leak (see https://github.com/dotnet/coreclr/issues/20273).
The potential leak exists here:

https://github.com/aspnet/Mvc/blob/b156dee4f175406a7cdcaaeb2b2a393f2a6abca0/src/Microsoft.AspNetCore.Mvc.TagHelpers/CacheTagHelper.cs#L116
https://github.com/aspnet/Mvc/blob/07cc9e66c6d936cbf5f8ddf1d37fa625ab3fb365/src/Microsoft.AspNetCore.Mvc.Razor/Internal/RazorViewCompiler.cs#L196

cc @pranavkm

Just out of curiosity, while reading into this issue, I saw a TaskCompletionSource which was not created with TaskCreationOptions.RunContinuationsAsynchronously as was advised recently here.
e.g.:
https://github.com/aspnet/Mvc/blob/b156dee4f175406a7cdcaaeb2b2a393f2a6abca0/src/Microsoft.AspNetCore.Mvc.TagHelpers/CacheTagHelper.cs#L111
I know this is not always needed, and you probably know your code better than me, just want to make sure this is not overlooked...

It's probably needed 😄

Thanks folks.
@pranavkm, this is all yours!

The Task created by TaskCompletionSource<> does not capture context, so the cached task in RazorViewCompiler is OK. CacheTagHelper caches the result of this method: https://github.com/aspnet/Mvc/blob/release/2.2/src/Microsoft.AspNetCore.Mvc.TagHelpers/CacheTagHelper.cs#L218-L227, which effectively produces a Task.FromResult(new CharBufferHtmlContent(writer.Buffer)). No context is captured in this case either.
Specifying the TaskCreationOptions seems to be the only work to do here.

Hmm, I could have another look, but I tried looking at the CapturedContext on the Task (with and without debugging) and it consistently turned up as null. @davidfowl recommended injecting an IHttpContextAccessor since that seems to be a common theme with these kinds of memory leak and I did not see any values being captured in the context.

The Task created by TaskCompletionSource<> does not capture context

Are you sure about that?

Tasks created by TaskCompletionSource do not capture ExecutionContext: it's only captured when there's actually something to execute by the task, which is not the case when it's used purely as a promise, as it is with TCS.
And for other cases (e.g. Task.Run) we also now clear out ExecutionContext even when it was captured, so there shouldn't be any issues here moving forward.
https://github.com/dotnet/coreclr/pull/20294

OK DOPE - I can probably simplify the code in routing then.


parquet-tools: 0.2.9 -> 0.2.12

Diff: https://github.com/ktrueda/parquet-tools/compare/refs/tags/0.2.9...0.2.12
Changelog: https://github.com/ktrueda/parquet-tools/releases/tag/0.2.12
Description of changes
Fix build (https://hydra.nixos.org/build/206967962)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 212773 run on x86_64-linux 1

1 package built:

parquet-tools


Remove src directory from npm install material-ui package

npm install material-ui creates lib and src directories. The examples all show importing/requiring from the files in the lib directory. Some developers on my project have imported from the files in the src directory. I assume that this is incorrect. I think you can remove the src directory from the npm install package and reduce confusion and file size.

I think this is a good idea. We should also discuss this with the owners :grin:

Yeah. I think that it's a good idea to add src to the .npmignore. It would make the npm install a bit faster too.

Yeah :+1:

If we're going to do this, I think 0.15.0 is a great time to do it. :+1:

I'm cool with this. :+1:


Bug report. Span not close when ClientAbortException: java.io.IOException: Broken pipe

For some reason  throw the org.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipe(ex. client timeout).  The TraceFilter not close the span.
I have a sample application to test it. The /normal-request return a normal content and httpstatus is 200.
The ClientAbortException throw from AbstractJackson2HttpMessageConverter.writeInternal. Then exception propagate to TraceFilter. After that, In detachOrCloseSpans
TraceFilter:
if (httpStatusSuccessful(response) && tracer().isTracing()) {
				if (log.isDebugEnabled()) {
					log.debug("Closing the span " + span + " since the response was successful");
				}
				if (exception == null || !hasErrorController()) {
					tracer().close(span);
					clearTraceAttribute(request);
				}
			}

The status is 200 and exception is not null, cause span not close.  So the exception propagate to StandardHostValve.invoke
StandardHostValve:

protected void throwable(Request request, Response response,
                             Throwable throwable) {
        ......
        // If this is an aborted request from a client just log it and return
        if (realError instanceof ClientAbortException ) {
            if (log.isDebugEnabled()) {
                log.debug
                    (sm.getString("standardHost.clientAbort",
                        realError.getCause().getMessage()));
            }
            return;
        }
        ....

Tomcat ignore the ClientAbortException. So that request not forward to the /error.
After all, Span have no chance to close.
Version
spring-boot-starter-parent 1.5.14.RELEASE
spring-cloud.version Edgware.SR4
My Workaround
use HandlerExceptionResolver to handle this. Then return normal ModelAndView. But this bug mabye need fix.

test-duplicate-trace-id.zip

Care for a PR ?

Ok. I'm trying to fix it.

Fixed via https://github.com/spring-cloud/spring-cloud-sleuth/commit/707f3714d60bf280133b43bbfbc2ef84e1a2455f

@mm23504570 I add an override the method#getStatus() and make it always return 200 to fall into below line.  Or it won't trigger this branch.
https://github.com/spring-cloud/spring-cloud-sleuth/blob/707f3714d60bf280133b43bbfbc2ef84e1a2455f/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/TraceFilter.java#L244

@marcingrzejszczak which version of spring-sleuth-core has this fix?
We are using spring-sleuth-core 2.2.0.Release and still having ClientAbortException issues.
Also the classes  from PR are not found in 2.2.0.Release Jar.


Dropdowns in firefox ‘reappear’ after clicking them second time

Expected result
Dropdowns should hide after clicking them twice.
Actual result
Dropdowns ‘reappear’ after clicking them second time (in Firefox).
Steps to reproduce

open Luigi sample app in Firefox
open dropdown (context switcher for example)
close it by clicking it again
dropdown hides for a moment and then reappears again

Fixed by #301


Where does the BaseCPUCost value came from?

I'd love to use this project on our Cluster, but in order to get that approval I've to able to explain each and every number shown in here.
What I haven't been able to find is how is the BaseCPUCost from aws.json calculated in first place? Where did you get the value 0.031611 from?

Hi @ingcsmoreno, BaseCPUCost is used as described in "How do you determine RAM/CPU costs for a node when this data isn’t provided by a cloud provider?" in our Q&A.
This default price is calculated on the average marginal cost of a CPU based on analysis when we first launched this product. The value is fully configurable. Let me know if I can provide more info or clarify. Also, we would be interested to hear if your team has or prefers a different approach!

Hi @dwbrown2, I've been reading the source code for a while now (awesome work BTW), and I think I got how it is used, but I couldn't find any where why it got that value assigned.
Now that you mentioned that you based that value on previous analysis, I'd like to ask you if you could share more info about that. I'm currently working with a 20 nodes OpenShift cluster and more than 800 pods running in it, so I've been working on different approaches to try to understand how to calculate the cost per container, and yours look very promising, but I need to be able to understand every number, and if possible, calculate them from our current cluster as well.
So, could it be possible for you to tell me what kind of analysis did you previously run to determine the BaseCostCPU value, I'll be glad to try it our myself and share the results.

Carlos, my apologies for the delay. We're now actively revisiting this methodology for potential improvements. We should have an update here soon. Feel free to reach out to<EMAIL_ADDRESS>if you want be involved in these discussions or if you want to talk directly.

Carlos and I discussed offline some. We implemented this new methodology last month. Please feel free to reopen this issue to continue the discussion!


Chainable projections

I would be great if one could chain projections, for example with operator| since it's already used to chain transformations in range-v3 and Boost.Range:
cppsort::sort(collection, proj1 | proj2);

Several questions that can be answered as we go:

Apply proj1 first then proj2 or the opposite? IIRC if we follow range-v3, it will be proj1 first then proj1. The pipe should work as a pipe operator or a then, hence proj1 is applied before proj2.
Can we use static assertions to ensure that the projections are chainable for the given type?
Wrapper class à la sorter_facade or projection base class to provide the mechanism?
Make usual projections customization points?
Is it possible to make operator| accept something like  &user::name | lower with bidirectional overloads?

After having forgotten to think about it for the last 3 years, the operator| design sounds good enough. The following set of features is probably enough to get something working:

[x] A projection_interface from which projections inherit, which implements operator|.
[x] Make sure operator| works in both directions with any suitable callable.
[x] Tweak utility::as_projection so that the returned function object inherits from projection_interface and can benefit from operator|.
[x] Add tests.
[ ] Add documentation.

I ended up calling it utility::projection_base instead of projection_interface but the design is otherwise pretty much the one described in the original post.


Can run the entire project from docker compose.


Update README

Problem
The README needed a little lovin'
Solution

Wonder if this ever gets merged? ;-p

Ha I didn't notice it was here, it'll be merged shortly!


Initial CODEOWNERS for governance repo

Initial list is the TSC as of March 2022 + me.

@sanfern mentioned on today's TSC call that he's seeing errors while reviewing these. I don't see any sign of errors on this end.
Santhosh, any chance you could give us more information about what errors you're seeing?

@sanfern mentioned on today's TSC call that he's seeing errors while reviewing these. I don't see any sign of errors on this end.
Santhosh, any chance you could give us more information about what errors you're seeing?

@vmbrasseur we see following errors in the file:
Unknown owner on line 11: make sure @dthaler exists and has write access to the repository
Unknown owner on line 11: make sure @erictice exists and has write access to the repository

@sanfern mentioned on today's TSC call that he's seeing errors while reviewing these. I don't see any sign of errors on this end.
Santhosh, any chance you could give us more information about what errors you're seeing?

@vmbrasseur we see following errors in the file: Unknown owner on line 11: make sure @dthaler exists and has write access to the repository Unknown owner on line 11: make sure @erictice exists and has write access to the repository

I gave them write permissions, they should accept the invite to collaborate.

I see Jason requested a change (replace his name with Karan's).  Is that change being made?


[DO NOT MERGE] Enable sysdig everywhere

Sysdig is an extremely useful tool for diagnosing any OS level issues.
It is something that should be a default tool at our disposable in our systems. A reboot would be required to enable it, but we should organically let it be enabled over time as instances are rebooted.
https://trello.com/c/3y6WEkin/821-check-sysdig-repository-and-add-back-in

There seems to be an issue with the snapshot on apt-1. This will have to be resolved before proceeding with this.
It's also worth bearing in mind that there is a race condition with enabling this on apt-1 before the repository works.

I'm going to close this for now and we can come back to it.


Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision)

https://github.com/flutter/engine/compare/a90c45db3f13...234ab4c1e9c4
2022-12-22<EMAIL_ADDRESS>Roll Skia from cd149aaa33bd to f1610a251e3a (5 revisions) (https://github.com/flutter/engine/pull/38456)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Verified correct hash with https://github.com/flutter/engine/commits/main

There is also a link to a git compare in the first line of the comment (I accidentally originally submitted it as a copy from the closed roll, but went back and updated it with the right commits being compared).


Update how-to-identify-required-appliances.md

Updated Corporate Max committed devices - 12K
Updated iDRAC to iLO for HPE appliances

@arielsaghiv : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Build failure - MavenReportException: Error while generating Javadoc

It looks like in the elasticity branch, the build is failing. It looks like it started failing after 20bfabab5b1e07437a6f54ec4a51e3228ae9e4df. It might be a case of a dependency update from 2.1 or main causing issues when it was merged up into elasticity but I'm not sure what is causing it yet.
A command that causes the error is mvn -B -V -e -ntp "-Dstyle.color=always" -DskipFormat verify javadoc:jar -Psec-bugs -DskipTests -Dspotbugs.timeout=3600000
Here is the error message:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.2:jar (default-cli) on project accumulo-core: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1
[ERROR] /home/runner/work/accumulo/accumulo/core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:560: error: unexpected heading used:
, compared to implicit preceding heading:

[ERROR]      *
Example 1

[ERROR]        ^
[ERROR] /home/runner/work/accumulo/accumulo/core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:577: error: unexpected heading used:
, compared to implicit preceding heading:

[ERROR]      *
Example 2

[ERROR]        ^
[ERROR] /home/runner/work/accumulo/accumulo/core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:593: error: unexpected heading used:
, compared to implicit preceding heading:

[ERROR]      *
Example 3

[ERROR]        ^
[ERROR] 3 errors
[ERROR] Command line was: /opt/hostedtoolcache/Java_Adopt_jdk/17.0.9-9/x64/bin/javadoc -J-Xmx512m @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/runner/work/accumulo/accumulo/core/target/apidocs' dir.

Fixed via #4104


Output tomtom geometries for  a selection of providers set of frequent service routes

this is mostly done here:
https://github.com/MetropolitanTransportationCommission/RegionalTransitDatabase/blob/04b13cedd10ce1e280d6ad90ccc6479b54b807be/python/network_analysis.py
pending completed processing.

the draft data are here: http://services3.arcgis.com/i2dkYWmb4wHvYPda/arcgis/rest/services/draft_high_frequency_bus/FeatureServer
arcmap threw an out of memory error mid-processing.


make gim compatible with kernel >= 5.0

kernel 5.0 removed some deprecated timespec/timeval functions
so conditionally convert everything to timespec64
Signed-off-by: Dominik Csapak<EMAIL_ADDRESS>

Hi flumm
You’d better make your change compatible with pre-5.0 kernel:
<EMAIL_ADDRESS>Look your change would break old kernel , e.g. 4.13
Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE
/Monk
From: flumm<EMAIL_ADDRESS>Sent: Tuesday, June 25, 2019 4:06 AM
To: GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization] make gim compatible with kernel >= 5.0 (#24)
kernel 5.0 removed some deprecated timespec/timeval functions
so conditionally convert everything to timespec64
Signed-off-by: Dominik Csapak d.csapak<EMAIL_ADDRESS>
You can view, comment on, or merge this pull request online at:
https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24
Commit Summary

make gim compatible with kernel >= 5.0

File Changes

M drv/gim_adapter.chttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-0 (38)
M drv/gim_adapter.hhttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-1 (36)
M drv/gim_dma.chttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-2 (8)
M drv/gim_irqmgr.chttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-3 (8)
M drv/gim_monitor.chttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-4 (2)
M drv/gim_monitor_ioctl.chttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-5 (2)
M drv/gim_monitor_ioctl.hhttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24/files#diff-6 (2)

Patch Links:

https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24.patch
https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24?email_source=notifications&email_token=AG4GO4LSGZ7OV5LRK6CMPDDP4HGVDA5CNFSM4H3FR5X2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3PGZ7A, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG4GO4IEY3IFW3V46RDFKDTP4HGVDANCNFSM4H3FR5XQ.

Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE

but i am doing exactly this?
in gim_adapter.h i define TIMESPECTYPE as timespec for kernels < 5 and as timespec64 for kernels >= 5
i did this to avoid dozens of
#if LINUX_VERSION_CODE <... .. #else ... #endif
blocks.
also i can build and load it here on an debian stretch with kernel 4.9.0 without problems

oh, sorry,didn't look into othe files yet
获取 Outlook for Androidhttps://aka.ms/ghei36

From: flumm<EMAIL_ADDRESS>Sent: Wednesday, June 26, 2019 3:35:01 AM
To: GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization
Cc: Liu, Monk; Comment
Subject: Re: [GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization] make gim compatible with kernel >= 5.0 (#24)
Maybe you can use MACROS to differentiate whether use timespec or TIMESPECTYPE
but i am doing exactly this?
in gim_adapter.h i define TIMESPECTYPE as timespec for kernels < 5 and as timespec64 for kernels >= 5
i did this to avoid dozens of
#if LINUX_VERSION_CODE <... .. #else ... #endif
blocks.
also i can build and load it here on an debian stretch with kernel 4.9.0 without problems
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization/pull/24?email_source=notifications&email_token=AG4GO4M7JNKL4X67AORAW53P4ML2LA5CNFSM4H3FR5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYST55Q#issuecomment-505757430, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG4GO4OVW7Q7YYMC5E6HLSLP4ML2LANCNFSM4H3FR5XQ.

Oh no problem

Pretty please @ljymonk ?

Does gim support 5.x kernel?

Does gim support 5.x kernel?

well i'm using it with this pull request since quite some time up to kernel 5.4 (cannot say for newer kernels), so i'd say it works, but since nobody from amd commented yet, i do not know if its 'supported'

Could you please make GIM compatible with newer Kernels? 5.9+
https://github.com/fabianishere/pve-edge-kernel
Thank you.


Update tutorial to support Lambda Provisioned Concurrency

Provisioned Concurrency, announced Dec 2019, takes some steps towards alleviating the cold start problem.
This means polling hacks can be removed.
The proposal therefore is to update the guide to at the least mention provisioned concurrency, and/or as part of it, demonstrate how to use it, and how it improves latency.

Yeah I think it's worth showing how to use it.
But I'm curious about the polling hacks. I don't think we do that in the guide?

Hi @jayair -- not in the coding parts of the guide, no, but there are various mentions throughout the doc on cold starts. So maybe the first increment would be to add a note in the narrative section initially, and then maybe later a more advanced element.

I see. Thanks for the feedback!


Improve sample data - add dependencies; better data for metrics

Improve sample data - add dependencies; better data for metrics

PR: https://github.com/NationalSecurityAgency/skills-client-examples/pull/14


Files in the mods folder are listed as resource packs

As the mods folder is a rift-only folder i cannot blame vanilla MC for that. Sorry.

Mods are resource packs. They can have everything a resource or data pack has, and they can also have code on top.

I'm used to Forge and there the mod files are not shown in the resourcepacks folder. There you only see what normal MC users think resourcepacks are: Graphic and sound files and all the files which really are in the resourcepacks folder. And the mod.jar files are not in that folder, whether they are resource files or not: They have their own "mods" folder. But they are shown as if they were situated in the resourcepacks folder.
I can live with that. No problem. But I strongly believe that I will not stay the only one to report this.
You to decide. It is the best modding option for 1.13 atm. Nobody will drop Rift for that as long as Forge is not out yet.

Mods are resource packs in Forge too, but it seems like Forge hides them from the list for some reason (at least in 1.12, it may change in 1.13).
Listing them in the resource pack and data pack lists also has the practical advantage of letting the player sort them in case two mods override the same vanilla (or other mod's) resource.
Most importantly, I'd like for Rift mods should be considered an extension of vanilla resource and data packs. They could contain only resources, but can also contain code on top. This fits with the idea that the Rift API is designed mainly to extend vanilla with new content such as blocks, items, biomes, entities, dimensions, commands, etc.

Of course you're right. It fits well into the "keep-it-simple" concept of RIFT. I can see the advantages.
It's not a bug - it's a feature. Thanks for responding and thanks for the good work.


Generated type of JSON fields is Object only.

Bug Report
Payload generates an JSON field type strictly as Object, however JSON can be top level array as well by specification RFC 4627 or any JSON value ({}, [], number, string... etc) by specifications RFC 7159, RFC8259, ECMA-404.
Other Details
"payload": "^1.6.10",

Hey there - this is a good call. We will update this accordingly.
Thank you!

Additional finding to consider when implementing this.
When I ignored the type and forced the top-level Array into JSON field it crashes with a loop at payload\src\utilities\deepCopyObject.ts:18:20 during collection update.  It's probably being infinitely duplicated.


Native support for attributes

It would be nice to have first-class support for attributes on vNodes even-though attributeHook is a pretty straightforward work-around and properties already cover most use cases.
Maybe something like:
h('div', { attr-foo: "bar" })

Looks like Matt-Esch/virtual-dom now supports attributes. Thanks! Closing this issue.


Error in code section 'protected internal' page

The second code example on this pagecontains an error. A line of code is out-commented, which should not be.
I suggest you change:
// Assembly2.cs
// Compile with: /reference:Assembly1.dll
class DerivedClass : BaseClass
{
    static void Main()
    {
        var baseObject = new BaseClass();
        var derivedObject = new DerivedClass();

        // Error CS1540, because myValue can only be accessed by
        // classes derived from BaseClass.
        // baseObject.myValue = 10;

        // OK, because this class derives from BaseClass.
        derivedObject.myValue = 10;
    }
}

To:
// Assembly2.cs
// Compile with: /reference:Assembly1.dll
class DerivedClass : BaseClass
{
    static void Main()
    {
        var baseObject = new BaseClass();
        var derivedObject = new DerivedClass();

        // Error CS1540, because myValue can only be accessed by
        // classes derived from BaseClass.
        baseObject.myValue = 10;

        // OK, because this class derives from BaseClass.
        derivedObject.myValue = 10;
    }
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 650c563e-748e-7ad7-fea9-0504549a56ab
Version Independent ID: ad6dac17-6e62-1447-e85d-e502ae39a343
Content: protected internal - C# Reference
Content Source: docs/csharp/language-reference/keywords/protected-internal.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @sputier
Microsoft Alias: wiwagn

Note: I realize this style of out-commenting lines of code that triggers errors is quite common. However on some pages, such lines are not out-commented, see for example:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/internal#example-2
// Assembly2_a.cs
// Compile with: /reference:Assembly2.dll
public class TestAccess
{
   static void Main()
   {
      var myBase = new BaseClass();   // Ok.
      BaseClass.intM = 444;    // CS0117
   }
}

adding @tdykstra
We are inconsistent here. Do we have any guidance for all of docs as to which style (commented out, or uncommented) for examples of code with errors?

Not that I know of.  The appropriate place for that, if we had it or if we add it, is the code-in-docs article -- internal  and external.

@BillWagner I can add something to that doc, but which direction should we take?

Code that causes compile errors -- comment out, include explanation in text and code comments
Code that is not recommended but compiles -- don't comment out, include warning in text and code comments

@tdykstra

Code that causes compile errors -- comment out, include explanation in text and code comments

I have a slight preference for this option. That's because it will make it easier for us to have our CI build work correctly. It's a slight preference though.

I'm closing this as by design. We want the code that introduces errors to be commented out.