Driver API review/cleanup/rework

This issue will be used to track all driver subsystem rework/cleanups:

[x] spi:  Issue #5797, #5839, PR #5921

[x] adc: PR #7691 #8857

[x] counter/rtc: Issue #5895, #8331. PR see issue. API complete

[x] display PR: #7833

[x] watchdog: Issues #10913, #10914, #10916, #10917 DONE: Issue #3994, PR #1260, #7007

[ ] i2c  Issue:  #4040 PR: #5224 (merged)

[x] gpio Issue #10339 #10741 #15611

[x] pinctrl: PR #5799

[x] pinmux

[ ] Advanced sensor API #1387, #13455 #14008

[ ] General inconsistencies and common guidelines for APIs

[ ] serial Issue: #1682 #8243 #11535 PRs: #8306 #8307 (@jarz-nordic). PR #10820

[ ] dma #8974 #8928

[ ] pwm: Issues  #6958 and #9507

[ ] battery: Issue #2542

[ ] led Issue: #8946

[ ] clock_control Issues: #11107 #12039 #14008

[ ] console (console.h? clarify with @pfalcon)

[x] usb

[ ] aio

[x] bluetooth:  internal to bt subsystem

[x] crypto

[x] entropy

[x] ethernet:  internal to net subsystem

[x] flash

[x] i2s

[x] ieee802154: internal to net subsystem

[x] ipm

[x] pci

[ ] system timer: interface to kernel, no exported header file

[x] sensor

[x] interrupt_controller

[x] shared_irq

Notes from API meeting:
https://docs.google.com/document/d/1lv-8B5QE2m4FjBcvfqAXFIgQfW5oz6306zJ7GIZIWCk/edit?usp=sharing

@galak @carlescufi Can we add LED API to this issue?

@Mani-Sadhasivam done, is that what you meant?

@carlescufi No, I mean to add LED entry to the list of API's here. I will work on extending the API further.

@carlescufi Moreover, issue #8946 belongs to LED API and not LED Strip.

Issues related to the PWM API: #6958 and #9507

@mbolivar to move this PR into a project.

@galah @carlescufi  flash driver documentation issue: flash: should write_protection be emulated?

@mbolivar to move this issue into a project.

Finally got around to this: https://github.com/zephyrproject-rtos/zephyr/projects/18
Is that pretty much what people are expecting? Should we close this if so?

I think we need clarity on what is going on with the new async serial API, and the old CONFIG_UART_INTERRUPT_DRIVEN API, as seen here: https://github.com/zephyrproject-rtos/zephyr/pull/14854

@galak Does this issue still provide value or can it be closed?

@galak Does this issue still provide value or can it be closed?

going to close it.  We can re-open if needed.


[SPARK-37019][SQL] Add codegen support to array higher-order functions

What changes were proposed in this pull request?

This PR adds codegen support to array based higher order functions except ArraySort. This is my first time playing around with codegen, so definitely looking for any feedback.
A few notes:

Disabled subexpression elimination for lambda functions (this already was the case because it was CodegenFallback). I plan to explore supprting subexpression elimination inside lambda functions later on, as it will require special handling.
I set the AtomicReference for all lambda values as well in case a child expression reverts to interpreted evaluation for any reason (CodegenFallback or otherwise)

Why are the changes needed?

To improve performance of array higher-order function operations, letting the children be codegen'd and participate in WholeStageCodegen
Does this PR introduce any user-facing change?

No, only performance improvements.
How was this patch tested?

Existing unit tests, let me know if there's other codegen-specific unit tests I should add.

Can one of the admins verify this patch?

@viirya @HyukjinKwon @cloud-fan any thoughts or know who might have thoughts?

@Kimahriman just out of curiosity, how much did the performance improve?

It's hard to say because when I tested this out on my production jobs (actually still actively using it), I had several other changes too. I'm not sure if there are any benchmarks involving HOFs? Though it's highly dependent on what the lambda function is, and honestly that's one of the main benefits, the lambda functions themselves can be codegen'd instead of eval'd.
I also have a larger goal to support subexpression elimination inside lambda functions, because that's where I've found our biggest problem is. https://github.com/apache/spark/pull/34727 is also part of that goal.

There seems to be a lot of repetition. Wish it could be avoided somehow but can't help though (beside nit-picking).

Thanks for the review! I tried to get as much common code in the parent classes as I could, can take another pass to see if anything jumps out for deduping

More nitting 😉

Yeah I struggle with the right formatting for multiline things in scala, tried to update all the suggestions, thanks for the tips!

@Kimahriman just out of curiosity, how much did the performance improve?

I just wanted to add to the above response that I've implemented a compilation scheme here, as part of Quality, and we saw perf boosts of up to 40%, after that adding further lambdas triggered the cost of code generation being higher than the saving.  It's definitely usage dependant though, the more work done in the function the higher the cost, a small boost is noticeable on removal of the atomic under similar ideal circumstances.


Add SAMSum Corpus dataset

Did not spent much time writing README, might update later.
Copied description and some stuff from tensorflow_datasets
https://github.com/tensorflow/datasets/blob/master/tensorflow_datasets/summarization/samsum.py

also to fix the check_code_quality CI you have to remove the imports of the unused csv and os

@lhoestq Thanks for the review! I have done what you asked, README is also updated. 🤗
The CI fails because of the added dependency. I have never used circleCI before, so I am curious how will you solve that?

I just added py7zr to our test dependencies

merging since the CI is fixed on master

Thanks! 🤗


Error when running Deformable DETR

Hello,
Thank you for this work and making the code available public to help us with our research purposes.
I have been trying to run Deformable DETR with multiple feature levels for swinb. I get the following error. But I have been able to run it successfully with resnet50. Can you please help me with that ?
File "main.py", line 301, in main
model, criterion, data_loader_train, optimizer, device, epoch, args.clip_max_norm)
File "/netscratch/govindan/transvod_lite/TransVOD_Lite/engine_single.py", line 44, in train_one_epoch
outputs = model(samples)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/parallel/distributed.py", line 596, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/netscratch/govindan/transvod_lite/TransVOD_Lite/models/deformable_detr_single.py", line 151, in forward
src = self.input_projl
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/container.py", line 117, in forward
input = module(input)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/conv.py", line 423, in forward
return self._conv_forward(input, self.weight)
File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/conv.py", line 420, in _conv_forward
self.padding, self.dilation, self.groups)
RuntimeError: Given groups=1, weight of size [256, 512, 1, 1], expected input[4, 256, 71, 125] to have 512 channels, but got 256 channels instead

Hi, @goku-krish10 ,
Sorry for the late reply. Did you use the same implementation of our code or directly modify the Deformable DETR?
Are you trying to pass multi-scale features coming from the Swin_b backbone to Deformable DETR as [Sairam13001] done in this issue: https://github.com/qianyuzqy/TransVOD_Lite/issues/10?
In our code,  we upsample and aggregate the features of swinb to a single scale feature,  since we want to use each frame of the video clip as a 'scale' in the multi-scale deformable attention. We have not tried to pass multi-scale features coming from the Swin_b backbone to Deformable DETR yet.
Thanks for your interest in our work.

I did not make any changes. I used the same code for Deformable DETR with num of features as more than 1 and I got this error.


adding ssh-agent support

for issue https://github.com/Batix/rundeck-ansible-plugin/issues/242 and https://github.com/Batix/rundeck-ansible-plugin/issues/252
Adding support for ssh-agent in order to use private keys with a passphrase

Hi @mcassaniti,
One of the use cases is using encrypted private keys, and pass the passphrase through Rundeck (using the key storage or a Secure Remote Authentication option from a job).
I will work on docs
Luis


Log verbosity environment variable

Feature/Improvement Description
I wanna see the responses in the agent you can tell if the agent is hallucinating and also its just fun to watch it work...
Proposed Solution
add an option to enable this
Acknowledgements

[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for everyone to understand why this feature request is needed in AGiXT.

Added in #1180 with details on how to change it.


Support for variadic func

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(ios): message sent to deallocated instance

Provide an example of how to test the change
I had some EXC_BAD_ACCESS crashes in my app without an useful stack trace. After enabling zombie mode I was able to get the following log:
[RCTVideo retain]: message sent to deallocated instance 0x10c530890

I checked the code and eventually figured out that [_player removeObserver:self forKeyPath:externalPlaybackActive context: nil]; is not called upon dealloc.
I am not 100% sure this results in the crash. However after adding that line to dealloc I was not able to reproduce this issue with the simulator or my testing device. I will also send out a new testflight in order to verify that this is the case.
The crash seems to occur when you are quickly mounting and unmount video components e.g. through quick navigation.

Okay testflight users cannot reproduce this issue anymore.


move subsample selection tags from log into file

dumping those 1e6 tags in the logs does take time and makes watching the logs less fun
i am curious whether we need those to be dumped separately considering that the actual subsample contains that information already

Removed from log.   Yet to put in file.


Import Swift 3 overlay from swift repo

import Dispatch overlay and apinotes from swift-3.0-preview-2-branch of github swift repo
add new overlay sourcefiles to src/Makefile.am (does not build)

Awesome!


How can I change the default xinput_string_product whose default value is "XInput STANDARD GAMEPAD"

Environment

Firmware Version: v0.7.1 and I add some code by myself to change xinput_string_product
Name of device: PicoFightingBoard
Is this a custom build?: Yes , I add some code by myself to xinput_string_product
Operating System: Ubuntu 20.04

Expected Behavior

xinput_string_product can be changed in PicoFightingBoard

Current Behavior

xinput_string_product can not be changed in PicoFightingBoard

I find the Controller descriptor string always  "XInput STANDARD GAMEPAD"，although I change it in my code.  I also flash flash_nuke.uf2 file every time I flahs my own uf2 file.

Hi @zeyingzheng-linux ,
Changing line 51 in XInputDescriptors.h does change it but some programs and applications will still show the generic listing.
As an example, I updated it to TEST and https://hardwaretester.com/gamepad still shows it as:
Xbox 360 Controller STANDARD GAMEPAD
In Mac terminals it shows up as:
XInput TEST:
Product ID:	0x028e
Vendor ID:	0x045e  (Microsoft Corporation)
You may get further by changing the PID and VID.  I am going to close this issue.

Hi @zeyingzheng-linux ,
Changing line 51 in XInputDescriptors.h does change it but some programs and applications will still show the generic listing.
As an example, I updated it to TEST and https://hardwaretester.com/gamepad still shows it as: Xbox 360 Controller STANDARD GAMEPAD
In Mac terminals it shows up as: XInput TEST: Product ID: 0x028e Vendor ID: 0x045e (Microsoft Corporation)
You may get further by changing the PID and VID. I am going to close this issue.

Thanks for your reply.
I don't think the problem is the programs and applications show the generic listing.
I find windows show the string  "GP2040-CE(PS4)" or "XIput STANDARD GAMEPAD" or the other string .  If windows show the generic listing via PID/VID ，GP2040 device must regisgter in USB-IF (https://www.usb.org/). I think the string descriptor must transfer by GP2040 device.
Is it possible save the string descriptor in other flash region but not code region, so my modified code didn't work .
Could you give me some suggestion.

Hi @zeyingzheng-linux ,
We have no plans to change the location of this code at this time.
May I ask what the use case is for changing this?

Hi @zeyingzheng-linux ,
We have no plans to change the location of this code at this time.
May I ask what the use case is for changing this?

I just change the code then try to understand the code logic , and I find it go against my understanding.
I do this for the purpose of showing my personal string when I plug the GP2040 device .
Finally , I can change the code by myslef , I just want to know why it cann't work when I change the string descriptor .Could you tell me why ?

That is correct, however it would rely on the person never having plugged in a device with that generic PID/VID/Name descriptor.


Get Viahtml ready for deployment

All changes required to get it to deploy

Looks good. The reference to old via has been removed.


Playground 502 http status generate.handler is undefined or not exported

Describe the bug
Seems like Modelina Playground fails to load https://modelina.org/playground
How to Reproduce

I tried to fix it last week, but was unsuccessful, still trying to figure it out why it all of the sudden broke 🙃


This issue, about payment fails because of decimal numbers, still exists using the nuget package

The checkout fails for checkout payments with decimals (eg 12.99). If I use payments with no decimals, the payment will pass.

please note I am using the Android 5 on an emulator.

I am getting exactly the same problems than you @kevinleungwork

@fcogutierrez - Thanks for your message. Definitely our issues are related (probably similar).
I have been trying various workarounds with this, but without success. The problem is passing the paypalitem array to the API for payment, where it will total to a decimal value and I suspect that this decimal total, is not to 2 decimal places. I tried converting all the paypalitem values to decimals , string then decimal ..etc but it seems there is nothing that can be done on our implementation (seems it's inside the nuget package).
@AlejandroRuiz - do you know how to fix this or point us to a solution? By the way, I tried to check the paypal.forms projects but there is an object reference error (to Xamarin.IOS) which prevents the solution from compiling.  I really like the work you did on this, because there are not many proper Xamarin payment solutions out there (I tried Judo but they are not good at all, and stripe is really inconvenient), but your solution is the best one I have found (well, up to payments with 2 decimal places).

Please refer to https://github.com/AlejandroRuiz/PayPal.Forms/issues/5 for the work in progress about this issue.


fix typo

mixed up ARM vs A64

because ARM was valid heh

ARM was valid, but you have 2 identical if clauses, IDE usually catches such cases

I don't know if I have the Scala stuff enabled in idea tbh


Fixed CS

Pull Request Test Coverage Report for Build 52

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 50:
0.0%

Covered Lines:
21

Relevant Lines:
21

💛  - Coveralls


secret.txt remains in the same directory after any script is performed

Frankly speaking, it's too insecure not to delete file with login/password after finishing a session.

I'll delete secret.txt file after logout.

If the secret.txt is necessary, can we hash it so it's more harmless?

we need a raw username and password to login the app. But i think there is a way to save the session and use it instead of relogin every time we restart the script.

by the way, for multiple account, secret.txt like now more convenience.
so, if we want to use multiple account, just make another folder with remaining script.
but yes, it feel insecure.

Saving session is not safer because it can be stolen. In the end we need either to ask user for password (instagram password, or the one to decrypt encrypted session in some way) or just save it in secret.txt.
I suppose that we need to add some kind of key argument, for example
python instabot script.py

will ask for credentials and won't store them, and
python instabot -s script.py

will save session in some way.
That makes the module safer by default.

Another thought is to use some unique static identifier (CPU model, MAC address or stuff like that) of a machine that runs the module as a encryption/decryption key. It's not the best but clearly better than plaintext.

already fixed


Create parachain runtime with excluded Zero/GameDao pallets

did you decide it is faster to build a  lean one and then new features are added step by step and added via feature flags? @vasylenko-yevhen

did you decide it is faster to build a lean one and then new features are added step by step and added via feature flags? @vasylenko-yevhen

Feature flags are good to have, however I think we should work on them at a later stage. There are few reasons why:

Audit. Even if feature flags will control which packages and pallets are installed/available, those should still be described in the runtime source code meaning they are present even if not used.
Having pallets present in the source code, even without actual usage of them, requires to support this source code even if it is not installed via feature flags. This looks like unnecessary overhead for unused features.

I would suggest to skip feature flags for now and start working on them just before we would release official first version.

we want feature flags for runtimes. Make sense to me.
we want to have not only release tags, but also somehow describe stability (experimental, development, stable). Also agree that we should somehow mark unstable releases.

we will always work on all pallets, either in 203489572 separate repos or in one consolidated codebase
we will add much more complexity maintaining many repos and keeping stuff in sync and finding working combos than having one repo containing all runtimes, nodes and pallets so we can build what we need any time.

Nobody suggested changes or splitting stuff. What do you mean?

how to treat e.g. orml?

What's the context? It's an external dependency.

we need to build version and tag as we go and add it to the network upgrade procedure and respective voting process

It already works like that with the release tag except for the voting, no?

we already run official versions so to say, this is nothing we talk about "in the future", as we are already in the process of public release (rococo, slot auction, etc) and need to set these things up without cluttering everything up on the last mile (suggestion)

Could you elaborate on this? Not clear what's the suggestion about.

we need to make better use of tags, they can also be experimental, development, latest, stable

Sounds good. So far, we have only a release tag, but it's not clear if this release is stable or not.
@2075 or @vasylenko-yevhen?
cc: @DarkNebula0


adds FoundationNetworking import for linux

fixes issues I was experiencing on Ubuntu 18.04 with Swift 5.2 (see issue #115)

Looking good @daSkier
Thank you 🙏


feat: Implement ExactSizeIterator for events::Iter

The size of events::Iter is known. The method Iter::size_hint
returns the same lower and upper size. It fulfills the invariant of
ExatSizeIterator and thus it allows us to implement
ExactSizeIterator with the default implementation for len and
is_empty safely.
In most usecases, using ExactSizeIterator::len is more appropriate
than Iterator::count because it doesn't consume the iterator.

Tests look good. Clippy is raising errors, which are fixed in https://github.com/tokio-rs/mio/pull/1501, I can cherry-pick the commits if needed.

Also see https://github.com/tokio-rs/mio/pull/1271.

Thank you for the cross-link. However, I don't see how it impacts this PR exactly. The current Iterator::size_hint implementation returns the same value for both the lower and upper size, so ExactSizeIterator can be implemented for free, with no more modification of the code.
Moreover, it would allow to know the size of Events without having to consume the iterator, which is nice in more usecase.
Is there anything I've missed here?

Sorry @Hywan I should have given a bit more context. The pr #1271 has more or less the same changes as this pr; letting users determine the number of events in Events. The problem is that we might want to supports OSes which can't determine how many events are collected. That has been the main factor in deciding against it. Furthermore the usefulness of such implementations is somewhat limited; few people actually put the events as-is in a another collection, this is where Rust can optimise using traits such as ExactSizeIterator.

Closing this due to age.


Detection IDs are different in repo to those in Sentinel

Describe the bug
Within the detections folder in this repository, each yaml file has an ID. This ID is different to the ID assigned when you deploy the alert through Sentinel.
This makes using the Repository (Preview) function for content management very difficult. If you deploy the alert through Sentinel, it will show when a version update is available. However, if you create the alert with the ID in the yaml files, it will not show when an update is available.
To Reproduce
Steps to reproduce the behavior:

Deploy 'Authentication Methods Changed for Privileged Account' alert through Sentinel.
The ID assigned when deployed is '24436335-bd9f-452a-9382-f6152049f29f'
Go to the part of the repo where this alert is stored:
https://github.com/Azure/Azure-Sentinel/blob/a02403e37dbecb4f2eb8f67817f62fd17a13bf50/Detections/MultipleDataSources/AuthenticationMethodsChangedforPrivilegedAccount.yaml
The ID within the yaml file is '694c91ee-d606-4ba9-928e-405a2dd0ff0f'

NOTE: This is one example, all alerts have the same issue
Expected behavior
The IDs should be the same for easy management of version control for each alert within Sentinel

Hi @LiamCloudGuard, the yaml ID is mapped to the alertRuleTemplateName property of the resource. You can find this when you export the rule and view the json file. The ID you see in the GUI is the reference to the resourceId of the rule in your Sentinel deployment.
I suspect you are using some tool to deploy directly from GitHub or a YAML to JSON converter and it might be stripping the alertRuleTemplateName as that was the case for me.
For your reference, you can't just add the values to the alertRuleTemplateName property if you have already deployed it without the value (yaml template ID). It will error out saying something like "This is an existing resource and was not deployed using a template". Therefore, you will have to re-deploy the resource and make sure it's there.

Hi @kevincaballerox15,
I created a script that would pull the alerts from the Azure-Sentinel repo, and convert the yaml files to JSON/ARM templates. Then using the repositories (preview), I connect Sentinel to the new repository containing the new JSON files.
I want the alerts to act as if they were deployed from the GUI as seen in the screenshot below. I assumed this was because the id of the alert was different.
What steps do I need to take to ensure the alert acts the same as if it was deployed from the GUI?
Many Thank!

@LiamCloudGuard, I would inspect the output of your script that converts yaml to ARM/JSON templates and make sure it doesn't strip out the alertRuleTemplateName property in the template.
A quick way to check this to export a rule that is generated by your yaml to json converter and another for one that is deployed from the GUI.
I suspect that the yaml to JSON converter is stripping out the alertRuleTemplateName or having the value as "null"
See example secreenshot for what I mean.

is what you need in your JSON template to associate your rule as if it was deployed from the GUI. If it doesn't exist, you need to update your templates to include it to achieve what you want.

If you have already deployed the rule in a sentinel workspace without the alertRuleTemplateName defined in the JSON, you would need to delete the rule from the GUI and re-deploy it.
Hope that helps!

@kevincaballerox15
Thank you, that clears things up for me. I appreciate you taking the time to help me with this.


[17.11] normalize "aarch64" architectures to "arm64"

Cherry-pick https://github.com/docker/swarmkit/pull/2411.
git cherry-pick -s -x 9d702763118b132cbe9005a80625ba2160089c3d
Cherry-pick was clean.

Ping @anshulpundir @thaJeztah

@anshulpundir since the SwarmKit vendoring wasn't updated in moby/moby in a while, several commits are missing from the release, so we're having to backport.

Makes sense. So 17.11 is based off of swarmkit master ? @nishanttotla

@anshulpundir the 17.11 release was cut when the vendored SwarmKit branch was 872861d2ae46958af7ead1d5fffb092c73afbaf0. This is several commits behind master. Instead of just bringing it up to date with master, we're trying to make sure that

there are no regressions
all useful bugfixes/features that were merged in SwarmKit in the last few weeks are actually included


transfers: refactor Receiver status check back into transfers package

Previously this check was shoved into remoteach (a package for http ACH operations) which is a completely wrong package for this check.

Codecov Report

Merging #440 into master will decrease coverage by 3.70%.
The diff coverage is 47.05%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   59.32%   55.61%   -3.71%
==========================================
  Files          92       92
  Lines        7751     7759       +8
==========================================
- Hits         4598     4315     -283
- Misses       2479     2819     +340
+ Partials      674      625      -49

Impacted Files
Coverage Δ

internal/remoteach/files.go
61.90% <ø> (+4.01%)
:arrow_up:

internal/transfers/transfers.go
55.22% <47.05%> (-1.70%)
:arrow_down:

internal/customers/client.go
12.92% <0.00%> (-55.06%)
:arrow_down:

internal/accounts/client.go
10.52% <0.00%> (-53.51%)
:arrow_down:

internal/database/mysql.go
11.60% <0.00%> (-41.08%)
:arrow_down:

internal/filetransfer/sftp.go
26.49% <0.00%> (-32.06%)
:arrow_down:

...depository/verification/microdeposit/repository.go
38.46% <0.00%> (-12.83%)
:arrow_down:

internal/filetransfer/outgoing.go
55.32% <0.00%> (+0.76%)
:arrow_up:

internal/filetransfer/controller.go
58.18% <0.00%> (+2.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40c924...b4bbca5. Read the comment docs.


Last day of the month shows as "L of the month" in lists and intervals

According to Live Demo:
0 20 L * * = At 08:00 PM, on the last day of the month (OK)
0 20 15,L * * = At 08:00 PM, on day 15 and L of the month
0 20 1-10,20-L * * = At 08:00 PM, on day 1 through 10 and 20 through L of the month

Fixed and released as 0.10.8

Thanks!


Feature request - [French Language VAD Model]

🚀 Feature
I want to know if there is any vad model for the french language to use with silero
Pitch
I need the vad for detecting speech / non speech in audio stream for embedded application
Additional context
target device  : raspberry Pi 4 running the last (at that time) version of rasbian bullseye 64 bit

The VAD should work with any language.


update definition of relevant electronic resources

Currently:
structured comment name = url
item name = relevant electronic resources
definition =

There is no definition included for this item.
my suggestion:
Any web address of an associated resource, e.g. a genome browser. The value should include the protocol (http, https or ftp).

discussed at zoom call Feb 8th:
"URL" is a reserved term so should not be used as the structured comment name.
Can we use a Darwin Core term here instead?
DWC have:
https://dwc.tdwg.org/terms/#dwc:associatedMedia
https://dwc.tdwg.org/terms/#dwc:associatedReferences
https://dwc.tdwg.org/terms/#dwc:associatedSequences
Can we change the structured comment name to "Associated_resource" which is an aggregate of those terms?

Can we change the structured comment name to "Associated_resource" which is an aggregate of those terms?

That would be useful in the GBWG DwC MIxS mapping task team - the mixs:associated_resource would be the union of those DwC terms (unless MIxS wants to split them too)

Resource relationship can also be expressed in RDF - which is similar to resource relationship extension of Darwin Core:
https://dwc.tdwg.org/terms/#dwc:resourceID
https://dwc.tdwg.org/terms/#dwc:relationshipOfResource
See more: https://dwc.tdwg.org/terms/#resourcerelationship

The tdwg working group GBWG has started dwc-mixs mappings, and this is the ticket referring to our URL term.
It suggests our URL maps to DWC's references
The DWC details are:
URI - http://purl.org/dc/terms/references
Label - References
Definition - A related resource that is referenced, cited, or otherwise pointed to by the described resource.
Comment - This property is intended to be used with non-literal values. This property is an inverse property of Is Referenced By.
Type of Term - Property
Subproperty of - Relation (http://purl.org/dc/elements/1.1/relation), Relation (http://purl.org/dc/terms/relation)

Do we agree?
Should we rename our "URL" [MIXS:0000091] term to be "references"?
Personally I think no, because the name "references" to me suggests that its like a reference list of a manuscript which is not the sort of thing we want in a MIxS checklist. I prefer the earlier suggested name of "Associated_resource"

Current term details
Term name - relevant electronic resources
Term ID - MIXS:0000091
Structured comment name - url
Definition -
Expected value - URL
Value syntax - {URL}
Example - http://www.earthmicrobiome.org/
Preferred unit -
Package(s) - CORE

Suggested update(s)
Update the structured comment name, definition, expected value and syntax:
Term name - relevant electronic resources
Term ID - MIXS:0000091
** Structured comment name - associated_resource **
** Definition - A related resource that is referenced, cited, or otherwise associated to the sequence. **
** Expected value - reference to resource **
** Value syntax - {PMID} | {DOI} | {URL} **
Example - http://www.earthmicrobiome.org/
Preferred unit -
Package(s) - CORE

@lschriml @ramonawalls are the suggested updates to Structured Comment, Definition, expected value and value syntax all OK to go ahead and make?
I think they are.

@only1chunts
Looks good.
One thought for the structured comment name, what about 'web resource'  ?

I think the discussion above suggests that Associated Resources was chosen to align better with the DWC terminology

update made in spreadsheet, MIxS_only_v6, and MIxS6 Core to Edit, and MIMAGS, MISAG and MIUVIG checklist sheets.


[WIP] Fix to include ng-included html

the template loader is somehting else I need to try. This doesn't work, but I hoped to avoid webpack hell.


Streamlined support for new app modules (step 1)

WHY are these changes introduced?
This is the first PR in the project to improve how app modules / extensions are defined in the CLI.
We are moving away from a set of 3 categories (ui, theme, function) to a generic "Extension" approach.
This will allows to introduce new extensions more easily and add support for new ones outside of the current categories.

WHAT is this pull request doing?
This PR does many small things, but if focuses on the part of defining extensions and loading them from disk, there are no relevant changes to dev/deploy or any other big command.
The most relevant changes are:

Remove FunctionSpecification and FunctionInstance
Remove ThemeSpecification and ThemeInstance
Transform UIExtensionSpecification and UIExtensionInstance into a generic ExtensionSpecification and ExtensionInstance(check the specification.ts file)
Simplified loader.ts, we load everything in the same way, and find extensions using the pattern *.extension.toml
The App object now has an allExtensions object with an array of generic extensions. The previous arrays for ui/function/theme are derived from the allExtensions one to not break any command.
Introduces the concept of features in the Extension specification. This will be relevant in step 2 to update the dev/deploy flows.

How to test your changes?
Create a lot of extensions/functions and make sure everything keeps working!

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

really good change, I'm happy with it, left a bunch of minor comments, LGTM


A few minor cleanups in pkg/reconciler/pipelinerun/pipelinerun_test.go

Changes
These just mildly annoyed me, so I thought I'd clean them up.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes
NONE

/retest


Extensions - loading assets doesn't work with just config

Currently, I have specified the following config file for HMCTS Frontend:
{  "assets": ["/assets/images"] }
This alone is not enough for the kit to be able to reference the static assets and load them in the browser.
There are three ways to solve this that I’m aware of.
Option A
(This is what HMRC Frontend does)

Create a prototype kit sass file inside the package:  which is responsible for changing the paths to something the extension stuff understands
Reference that sass file in the config file:

{
  "sass": [
    "/_prototype-kit.scss"
  ],
}

Option B
(This is what I’ve currently opted for)

Add the following line into the server.js file in the prototype kit

app.use('/assets', express.static(path.join(__dirname, 'node_modules', '@hmcts', 'frontend', 'assets')))
Option C
Change the way the config file works so that not only can you specify the location of the assets but also where they should be mounted
{ "assets": [{ mountPath: “/assets”, path: “/assets/images" }]
Or something like that.
I strongly recommend C because I don’t believe packages should have to change anything in their source code to make the prototype kit work beyond the config file.

Thanks @adamsilver, really useful to get feedback on Extensions, we want to get it right before launching it.
Option A is currently our preferred approach as there are problems with B and C:
B: this requires the end user to make changes to server.js - we want the experience for end users to be as simple as possible - hopefully just npm install [extension name]
C: we can't allow extensions to use /assets - we need to namespace them in some predictable way so files can never clash. If two extensions did what's proposed in option C, and had the same file name in each, only one of them would work.

Currently, we (authors of packages) are not told how to develop the packages.
So for example, HMCTS Frontend doesn't (yet) namespace the paths to the macros. Similarly, the path to the assets are specified as /assets. It just so happens that we follow the same good practice as GOV.UK Frontend by making that path configurable with a SASS variable—but technically we don't have to and nobody makes us do so.
So while namespacing etc is a good idea, it's not enforced upon us.
To note, I've not come across any problems so far in the last 10 months or so any conflicts with HMCTS Frontend and GOV.UK Frontend having the same asset path.
The beauty, as I see it, with the config file, is that all package authors have to do is include and configure just one single file and the rest is magically handled by the prototype kit. But currently, there is no way to configure the asset path to which the assets are mounted within the config, leading us to have to use option A.
If the config did allow the asset mount path to be configured, the problem would be solved without forcing the package authors to do extra works in the source code beyond the config file. My point is that the config file should be enough on its own to accommodate the varying nature of how packages could be built.
Can we explore this option together?

sure, it's a good direction!
If you could define it inside config that would be nice, but I’m not sure how we could communicate that path back to the scss
Maybe the extensions shouldn't define their own assets path like hmrc-frontend does, maybe the kit should. The kit could say, ok, you’re hmrc-frontend, your assets will be mounted at /extension-assets/hmrc-frontend.
Problem is, in their scss they would have something like this:
background-image: url("#{$hmrc-assets-path}icon-chevron-left.svg");
We’d need to know the variable name is $hmrc-assets-path, or whatever it was in other extensions.
Maybe we could set a convention - tell people to use the variable $assets-path?
Maybe extensions could tell us what that variable name is, in the config?
asset-path-variable: "hmrc-assets-path"

I don't think we should enforce a convention like that.
I was thinking that if HMCTS Frontend SASS file sets the asset path to /hmcts-assets then I will setup the config file like this:
{ assets: [{ mountPath: '/hmcts-assets, ... }] }`
That cool?

@nataliecarey for your consideration

we'll see if this comes up in our upcoming user research


Laravel 5 compatibility

PhpTalView currently cannot be used with Laravel 5, which would be very nice.
Problem 1
- Installation request for niterain/php-tal-view dev-master -> satisfiable by niterain/php-tal-view[dev-master].
- niterain/php-tal-view dev-master requires laravel/framework ~4.2.11 -> no matching package found.

Updated.
Could you test out the changes.


Use the new mangling for reflection

It also uses the new mangling for type names in meta-data (except for top-level non-generic classes).
lldb has now support for new mangled metadata type names.

@swift-ci Please test and merge

This broke our internal ASan bot. Erik, I'll send you the error.


Make a local test and take contribution

Hi there,
I forked ur project and ready to tested locally but I do not know how to make a pull request to you as scrnshot below:

As u can see, it needs test url and scrnshot. How can I test locally?
Mr. Alice,
Mr. Poon's Studio

Welcome to GitHub, please refer to the contributing.md file in the repo. When opening a PR there are also instructions in the text field.
The "test URL" is just a regular GitHub URL where your PR is making changes.


Clue glitches

As you can see in the photos below the —tt flag is showing I have 14 elite caskets.
The =open command says I only have 4.

Also just noticed —tt says I have 24 masters and open says 33

Fixed


Add a feture to clone modules via SSH keys during terraform_validate stage

It would be great to add a feature to be able to clone modules via SSH keys during terraform_validate stage.

That's from https://ukrops.slack.com/archives/C3R001CHW/p1659634407658399
TL;DR Possible solution: apk add --no-cache openssh in the last Dockefile stage.

@MaxymVlasov @yermulnik Wanted to get your thoughts on implementation here before I start working this...I think this moves out of just the terraform_validate hook, since terraform init gets called in common::terraform_init by at least terraform_validate and terraform_providers_lock currently.  Please let me know if I'm missing a simpler solution here.
Primary issues are getting SSH keys and public SSH host keys inside the container.
I think my preference initially is to provide ssh-agent access via docker bind (and having a section in the README about running the container with SSH access), but not support binding the user's .ssh directory (since those keys would be more likely to have a passphrase).  And for the known_hosts, I think the 2nd option I list below (ssh-keyscan), though needing more code in _common.sh, is better than binding a known_hosts file as the hooks will then run even if the user has not previously connected to the host.
For keys:

If ssh-agent is running when docker is called, we'd probably want to give access to that instead of trying to copy in key files (which may not even exist in the case of running the container on a remote system, where ssh-agent access is passed through ssh -A or similar).  So having the user execute something like:

docker run -v ${SSH_AUTH_SOCK}:/run/ssh.socket -e SSH_AUTH_SOCK=/run/ssh.socket

would be necessary.

If there's no ssh-agent, the user would have to provide a passphraseless key, either by binding it via the docker run or maybe passing via an environment option, but neither of these seem ideal.

For public host keys:

Require the user to provide a known_hosts file that contains the remote host signatures via binding

or

Before running terraform init, we have to scan for any source = URLs that match the three SSH styles supported by terraform:

  source = "git@github.com:hashicorp/example.git"
  source =<EMAIL_ADDRESS>  source = "git::username@example.com:storage.git"

it's easy enough to parse out the hostnames from these, and run ssh-keyscan with output to a temporary known_hosts file.  But it does add complexity to the common::terraform_init function.  This would work even if the user is using a private custom SSH git repo.

Well, yeah, that's a bit of a hassle 🤔
Mounting auth socket would mean some of the headless setups might fail as they might not have ssh agent running (or ssh keys added to it).
On the other hand mounting .ssh dir (or explicitly priv/pub keys only) would mean a need to provide a passphrase if key requires it, which again might be a point of failure for headless setups.
There's another option to globally replace GIT URLs to use https://, which might not work for some setups with self-hosted GIT implementations where access via HTTPS isn't provided.
I'm leaning to an option to mount .ssh dir (or explicitly priv/pub keys only) along with requirement for users to provide passphrase-less key in case they're running pre-commit-terraform Docker container against GitHub-hosted Terraform modules. This would allow headless setups to get provided with such a key to access GH via SSH protocol. Kinda a big caution message in the README on how to do that with as less hassle as possible (plus what Max wrote re ssh installation into Docker image).
What I actually mean is that we should not interfere with any user-related stuff, but only provide an option on how to overcome GitHub's limitation with user-side actions.
Does it make sense to you folks?

I spent some time experimenting with this, and I think @yermulnik's plan for just providing documentation on how to solve this (with openssh-client installed in the image) is workable.  Especially trying to follow @MaxymVlasov's thoughts on nocode.  Depending on what exactly the user needs, it might take some setup on their side, but once setup I think it would work well.  We could also provide a doc section on binding the ssh-agent socket where useful.
We could put a simple plan in the README, but having a full explanation on some of the setup options may necessitate a separate file (or a wiki entry if the project had one).
I've put notes below (primarily for myself), but if agreed that @yermulnik's plan makes sense, I can put together a pass at docs and the minor Dockerfile change.  What are thoughts on having a separate file for more thorough documentation vs a wiki?
Notes
For host keys, while not ideal I think using SSH option StrictHostKeyChecking=no might be acceptable, since we're already using passphraseless keys.
If the user wants to bind their existing .ssh directory, and not have to modify their config, they can use -e GIT_SSH_COMMAND="/usr/bin/ssh -o StrictHostKeyChecking=no" when running the container, and the host key problem should be resolved.
On Github this plan would allow using read-only repository level deployment keys, or account level SSH keys.  Other systems (private hosted git repos, Codecommit, etc) shouldn't have an issue either.  One issue with Github repository deployment keys is they have to be unique per repository, so if there are multiple private github repos referenced in the code, the source = statements have to refer to a separate Host entries for each repository.  I put an example of how I think this would have to be handled below.
As an example, let's say I have 2 Github repositories, tofupup/private-tf-security-group and tofupup/private-tf-vpc.  For read-only deployment keys for each repository:

(optional) create a .ssh directory for this project

$ PROJSSH="/home/john/src/proj-sshdir"
$ mkdir -p $PROJSSH

Create passphraseless SSH keys for both repos:

$ ssh-keygen -t ed25519 -C "github_security_group_buildkey" -N "" -f "$PROJSSH/id_github_security_group_buildkey"
$ ssh-keygen -t ed25519 -C "github_vpc_buildkey" -N "" -f "$PROJSSH/id_github_vpc_buildkey"

Add keys to respective repositories (via web or gh CLI)

$ gh repo deploy-key add "$PROJSSH/id_github_security_group_buildkey.pub" -t "john security_group buildkey" -R tofupup/private-tf-security-group
$ gh repo deploy-key add "$PROJSSH/id_github_vpc_buildkey.pub" -t "john vpc buildkey" -R tofupup/private-tf-vpc

Create ssh config

❯ cat $PROJSSH/config
Host gh_security_group
        Hostname github.com
        ControlMaster no
        IdentitiesOnly yes
        IdentityFile ~/.ssh/id_github_security_group_buildkey
        StrictHostKeyChecking no

Host gh_vpc
        Hostname github.com
        ControlMaster no
        IdentitiesOnly yes
        IdentityFile ~/.ssh/id_github_vpc_buildkey
        StrictHostKeyChecking no

source statements in module must reference these new hostnames:

  source = "git::ssh://git@gh_security_group/tofupup/private-tf-security-group"
  source = "git::ssh://git@gh_vpc/tofupup/private-tf-vpc"

A separate file is OK, put it in the docs/ folder.
Wiki has lack of search, so for me it is useless.
I could introduce the mkdocs->gh-pages integration later, if we will have many docs

+1 to file instead of wiki.
@tofupup Thanks for your time and effort. What you wrote in the latest post looks reasonable and good to me.
The only usual nitpick bit would be to wrap var into double quotes mkdir -p "$PROJSSH" 😂


[intel-mkl] Support Linux

Support search in linux.
Fixes #15204.

Prepare for #15208.

@BillyONeal To delete the linux failure entry of the port in the baseline, we must install Intel-mkl on the linux pipeline machines.

The links to intel-mkl we currently install for Windows aren't publicly accessible; someone who cared provided them for our scripts but I don't know how to get to an associated download page. As such, ci.baseline.txt seems appropriate for now: there's no reason it couldn't work, but we don't have great means to test it. Someone who cares would need to give us instructions we could add to provision-image.sh to deploy it.

@BillyONeal We should add several commands:

wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
rm GPG-PUB-KEY-INTEL-SW-PRODUCTS-2019.PUB
sudo sh -c 'echo deb https://apt.repos.intel.com/mkl all main > /etc/apt/sources.list.d/intel-mkl.list'
sudo apt-get update
sudo apt-get install intel-mkl-2020.0-000

currently #15204 is not fixed by this PR.

currently #15204 is not fixed by this PR.

@Neumann-A  That's why I changed this PR to draft.

@Neumann-A  That's why I changed this PR to draft.

portfile.txt
I used the above portfile. You can probably simply merge the Linux/Windows Paths by simply adding the linux path to find_path

portfile.txt
I used the above portfile. You can probably simply merge the Linux/Windows Paths by simply adding the linux path to find_path

@Neumann-A
https://github.com/microsoft/vcpkg/pull/15233/commits/967f60ad7bff8dd0d14ad2628b22af88ee253beb
Is that what you mean?

@Neumann-A
https://github.com/microsoft/vcpkg/pull/15233/commits/967f60ad7bff8dd0d14ad2628b22af88ee253beb
Is that what you mean?

@JackBoosY No with the current patchset it still wouldn't be found.

@JackBoosY No with the current patchset it still wouldn't be found.

Close this PR temporary.

Is there a way to locally test changes?

Is there a way to locally test changes?

You can pull Jack's branch

Dropping vm update tag since there are no vm update changes in the pr

Close this PR temporary.

FYI: intel-mkl can now be installed on OSX
I'm running into this issue, and tried the PR, no luck.  I know it's not Linux, but I'm getting the same error as described in https://github.com/microsoft/vcpkg/issues/18222  (I initially installed intel-mlk with their installer, but vcpkg install intel-mkl --allow-unsupported also seems to work
I executed the following:
git clone git@github.com:JackBoosY/vcpkg.git
cd vcpkg
git checkout origin/dev/jack/15204
./bootstrap-vcpkg.sh
export MKL_ROOT=export MKL_ROOT=/opt/intel/oneapi/mkl/2021.4.0
./vcpkg install arrayfire --x-cmake-args=--trace-expand > ./install-arrayfire-out.log

results: install-arrayfire-out.log
just in case it matters, I'm on an M1 Mac, running BigSur
uname -a
Darwin Airtemis.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:20 PDT 2021; root:xnu-7195.141.6~3/RELEASE_ARM64_T8101 x86_64 i386 MacBookAir10,1 Darwin

@ultrasaurus It seems that intel-mkl was succesfully installed, right?

sorry, I upgraded XCode to 13.1 and ran into https://github.com/microsoft/vcpkg/issues/20993 -- now in your branch vcpkg doesn't build, but master does.

turns out it wasn't too hard to switch back to prior version of Xcode... will post more info

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

Note that this is likely to cause changes in which implementation if Lapack is selected because CMake's built in FindLAPACK seems to prefer MKL over what we currently are trying to use, OpenBLAS. See https://cmake.org/cmake/help/latest/module/FindLAPACK.html / https://cmake.org/cmake/help/latest/module/FindBLAS.html#blas-lapack-vendors

So should we fix lapack issue first? https://github.com/microsoft/vcpkg/pull/21479

Okay, according to the feedback in https://github.com/microsoft/vcpkg/issues/15204, this PR is just waiting for https://github.com/microsoft/vcpkg/pull/21479 merge.

In favor of https://github.com/microsoft/vcpkg/pull/29437


Cannot run krypta example on Linux

In running cargo run --example krypta, I get
thread 'main' panicked at 'Failed to initialize any backend! Wayland status: NoCompositorListening X11 status: "backend disabled"', /home/brettw/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/mod.rs:719:9

That would not be related to this crate. It looks like you are running this over ssh. Run it locally

I did the following in a local terminal:

git clone https://github.com/zaycev/bevy-magic-light-2d.git
cd bevy-magic-light-2d
cargo run --example krypta

I got the above error. My distro:
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.5 LTS
Release:	20.04
Codename:	focal

I assume the Cargo.toml disabling all bevy default features and requiring wayland might not work if I'm on X11 (as double-checked by XDG_SESSION_TYPE.

Can you run other examples?

No, unfortunately, as per #14.

No I meant the actual Bevy repo, not bevy magic light. Have you successfully run any Bevy app before

Yes, I have. I just pulled the latest bevy main, and ran examples from that.
On bevy-magic-light-2d I did cargo add bevy --features x11 which adds the x11 feature back in and the krypta example compiles and runs. Disabling all default features and defaulting just to wayland is the issue for some Linux setups.


[SPARK-26879][SQL] Standardize one-based column indexing for stack and json_tuple function

What changes were proposed in this pull request?
This PR is to standardise the column indexing of stack and json_tuple function,to follow one-based indexing.(as discussed on PR #23748 )
There is inconsistency in default column names for functions like stack and json_tuple. stack and json_tuple uses col0, col1 etc. (i.e. 0-indexed columns), while other functions like inline uses col1, col2, col2, etc. (i.e. 1-indexed columns).
How was this patch tested?
Added unit test.

Can one of the admins verify this patch?

@maropu  Please review.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ISTM the title and description mismatch yoru fix. CreateStruct is used in many places, but this fix only affects inline and stack?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8765/
Test PASSed.

Test build #103326 has started for PR 24051 at commit 1958726.

Test build #103326 has finished for PR 24051 at commit 1958726.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103326/
Test FAILed.

Which one is more widely used by other DBs? 1-indexed or 0-indexed?

Hi, @maropu  ,Updated the title and description. This fix is basically for the struct function(as inline internally uses struct).  But from the UT failure it seems that,hive uses one-based column indexing  for the struct function. Is it ok to make this change?

How about to standardize the column indexing to 1-indexed column?

Can you check if we can use the 1-based index on all the places?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8851/
Test PASSed.

Test build #103431 has started for PR 24051 at commit 33b973d.

Test build #103432 has started for PR 24051 at commit 23f2c13.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8852/
Test PASSed.

@maropu  @viirya  Thanks,that is good idea. Only stack and json_tuple uses zero based column indexing.So,I have changed both functions to follow one-based indexing.

Test build #103431 has finished for PR 24051 at commit 33b973d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #103432 has finished for PR 24051 at commit 23f2c13.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103431/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103432/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8854/
Test PASSed.

Test build #103434 has started for PR 24051 at commit bf26840.

Test build #103434 has finished for PR 24051 at commit bf26840.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103434/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8912/
Test PASSed.

Test build #103499 has started for PR 24051 at commit 5ce5414.

Test build #103499 has finished for PR 24051 at commit 5ce5414.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@maropu  @viirya  please review

@chakravarthiT are there more functions to fix? If this is the only last one, I guess it's fine.

@chakravarthiT are there more functions to fix? If this is the only last one, I guess it's fine.

@HyukjinKwon sorry for my late response.Yes this is the last one,rest all functions follows one based indexing.

last question, @chakravarthiT. What does Hive's json_tuple returns for the column names? I think we matched the column names with Hive when we added this long time ago.

@chakravarthiT can you update the migration guide, too? cc: @gatorsmile

Can one of the admins verify this patch?

ping @chakravarthiT to update or close

Can one of the admins verify this patch?

I'll close this because of the author's inactivity.


Edit Modal Not Working

When I select a row and click on edit, the Edit modal pop up comes. It displays column names correctly but it does not display field values.
Instead of holding current value, the fields store nothing (i.e. they are blank).

This is not true in the online examples (see e.g. https://luca-vercelli.github.io/DataTable-AltEditor/example/02_in_memory_objects/example2.html)
Can you provide some more details, or some jsfiddle?

This is not true in the online examples (see e.g. https://luca-vercelli.github.io/DataTable-AltEditor/example/02_in_memory_objects/example2.html)
Can you provide some more details, or some jsfiddle?

Yes, you are right, @luca-vercelli.
It is working perfectly in examples. However, it wasn't working as expected when I was using it in my project. I have fixed it now.
I was loading data from a local JSON file. The problem was that my "data" label in "columnDefs" had space in the name. I changed it by using underscores and it works.
Original Format :
var columnDefs = [
{ data: "Category ID", title: "ID",},
{ data: "Category Name", title: "Name",}
];
NewFormat (This works):
var columnDefs = [
{ data: "Category_ID", title: "ID",},
{ data: "Category_Name", title: "Name",}
];
Thanks a lot for the plugin. Great Work!!!


System table in distribute mode

Background
In standalone mode, datanode creates system table and regions during it's first startup, and registers these tables to catalog.
But in distributed mode, all regions of system tables should be treated equally. For example , for system table scripts, when frontend received a insert into scripts request, it should forward the create request to all datanodes, instead of forwarding by partition rules.
Proposal
Frontend should be able to distinguish system table request. System table names should be retrived from metasrv.
For insert request, system table insert requests should bypass current writer splitter logic and forward to all datanodes.
https://github.com/GreptimeTeam/greptimedb/blob/5abff7a536ece42cbe53e96c4205b9625e923a49/src/frontend/src/spliter.rs#L19
For query requests, we should implement a SystemTableScan exec plan that forwards request to all datanodes.
API change
Not applicable.

Maybe we can create another table implementation in frontend just for system table? The new table implementation act as a "fan-out" adapter to its designated tables, and loop through them upon writing and reading.

Maybe we can create another table implementation in frontend just for system table? The new table implementation act as a "fan-out" adapter to its designated tables, and loop through them upon writing and reading.

I think it's more like a specialized physical plan that scans all regions (from all datanodes), maybe we should add a optimize rule for this.


#4249 Support offline running productpage by packing js and css in image

Packed Bootstrap CSS and jQuery JS into image to make it able running offline.
Response to #4249

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yubingjiaocn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: venilnoronha
If they are not already assigned, you can assign the PR to them by writing /assign @venilnoronha in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @yubingjiaocn. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Make DateTimes more flexible

Date times are shifted to ParserUtil class now

Codecov Report

Merging #182 (b8ed5e7) into master (af4bb87) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #182   +/-   ##
=========================================
  Coverage     72.19%   72.19%
  Complexity     1199     1199
=========================================
  Files           167      167
  Lines          3845     3845
  Branches        511      511
=========================================
  Hits           2776     2776
  Misses          922      922
  Partials        147      147

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
95.27% <100.00%> (+0.16%)
:arrow_up:

...address/model/person/supplier/DeliveryDetails.java
94.73% <100.00%> (-1.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4bb87...b8ed5e7. Read the comment docs.


Pass Arguments Directly

Commands: []*urfave.Command{
{
Name:    "clear",
Aliases: []string{"cls"},
--> Arguments: []string{"oneline","all"},
Action: func(ctx *urfave.Context) error {
clearTerminal()
return nil
},
},
}
Also availability to make it required or optional.
In Action have availability to check if arg present like isSet func isArgSet
Another feature that would be nice is to have is availability to make any one flag required out of 2 or more.

@str1ngs-bytes the one flag required out of 2 or more is covered by issue #1222 . Also I really fail to see the value of providing Args. Cant the Action check if len(ctx.Args()) == 0 and then use a preset value.

@urfave/cli any ideas on this ?

I need a more complete example to get what's going on. What is the required interface?
app clear <oneline|all>

No response from original issuer. Closing


What is your seed for generating the blue dog?

Some results
python fusedream_generator.py --text 'A photo of a blue dog.' --seed 1234

python fusedream_generator.py --text 'A boy is reading papers.' --seed 1234

python fusedream_generator.py --text 'A woman wearing lipstick.' --seed 1234

Hi Tiankai,
Thank you for sharing with us your results!
I don't remember exactly the seed I used for that dog, but the default parameters in our colab should give you a good blue dog. Setting 'latent_noise=False' will give dogs with sharp edges with slightly smaller AugCLIP score.
Link to the colab: https://colab.research.google.com/drive/17qkzkoQQtzDRFaSCJQzIaNj88xjO9Rm9?usp=sharing


NTI: cannot cast to type HTMLElement

Using NTI (new type inference) I'm unable to get rid of the warning "Property offsetHeight never defined" on this fragment of code.
    var docElement = /** {@type !HTMLElement}*/(document.documentElement);
    var /** null */ n = docElement;
    var documentHeight = docElement.offsetHeight;

The assign to n is to confirm what type the compiler infers.  Produces these errors:
src/test/Engine2DTestRig.js:361: WARNING - The right side in the assignment is not a subtype of the left side.
Expected : null
Found    : Element

    var /** null */ n = docElement;
                        ^^^^^^^^^^

src/test/Engine2DTestRig.js:362: WARNING - Property offsetHeight never defined on docElement of type Element
    var documentHeight = docElement.offsetHeight;
                         ^^^^^^^^^^^^^^^^^^^^^^^

Here is an online example on the appspot debugger
Same inability to cast in OTI, but OTI doesn't provide the warning "Property offsetHeight never defined".

Did you mean @type {!HTMLElement}?


Mrksr avoid tile in ekernels

Codecov Report

Merging #330 into master will increase coverage by -0.01%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   99.73%   99.73%   -0.01%
==========================================
  Files          28       28
  Lines        2254     2253       -1
==========================================
- Hits         2248     2247       -1
  Misses          6        6

Impacted Files
Coverage Δ

GPflow/ekernels.py
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6745ccd...aad0532. Read the comment docs.

Closing due to 0 diff.


[BACKLOG-2192] JobEntryCopyFilesDialog changes for UX & extensibility

@e-cuellar review (carefully) and test as you did earlier today with other changes

@e-cuellar this commit is related to, and required for https://github.com/pentaho/big-data-plugin/pull/346


Use the current locale to sort country names

Fixes #258

Countries with an accent in their names aren't correctly sorted. (For example "États-Unis" (USA in French) is at the end of the list, making it harder to find.

(see also the gif available here: #258)
Screenshot of the fix

Description of the changes:
std::wstring::operator< does a very basic comparison of strings based on the value (int) of the characters without taking into account accents, diacritics, etc...
To fix this issue, we will use std::collate with the current locale, it will not only ignore accents and diacritics but use locale rules to sort the string (for example ch in Czech is between  h  and i)
How changes were validated:

tested in french, spanish and english.

I just solved conflicts with Master, so ready to merge if you are ok with this PR!


small bug in help documentation

if you type trousseau help set you will get

NAME:
set - Set a key value pair in the encrypted data store
USAGE:
command set [command options] [arguments...]
OPTIONS:
--file, -f 	Write key's value to provided file

Should be: Read key's value from provided file

Fixed


feat: fix for Radio Button

Why do we need this prop? We have setWhichIsChecked, doesn't it cover this functionality?


Component does not perform section animation.

I've setup my sections and objects as following
`
class CheckinItemsSection: NSObject, BMAUpdatableCollectionSection {
public var uid: String = ""
public var items: [Any] = []

public override func isEqual(_ object: Any?) -> Bool {

    if  object is CheckinItemsSection {
        let c = object as! CheckinItemsSection
        return self.uid == c.uid
    }
    return false
}

override var hash: Int {
    return uid.hash
}

init(uid:String, items:[Any]){
    super.init()
    self.items = items
    self.uid = uid
}

}
`
and actual object i'm rendering  is
@interface APGCheckin : MTLModel<MTLJSONSerializing,BMAUpdatableCollectionItem>

...
-(void)setRef:(NSString *)ref
{
    self.uid = ref;
    _ref = ref;
}

@end

I'm passing old and new model in BMACollectionUpdate.calculateUpdates method it performs row animations file but does not perform section animations.

This is expected as because of internal limitations it's not possible to do both row and section animations simultaneously. The solution works w/ animations for situations where sections are not changed.

@vmagaziy ok, I understand why it not working simultaneously for both rows and section. But why it ignores section animations when completely new section inserted or removed?

@RomanTruba thank you for pointing out on this.
When we were implementing this algorithm we faced several issues when we had section's insertions/removals and items animations in the same batch update.
In order not to overcomplicate algorithm by handling possible edge cases and also because in our case we didn't need support for this behaviour, we decided to go with simple reloadData in case if section change occurred.
As a workaround I would suggest to have a fixed number of sections which might be hidden if they are empty. Merging algorithm will work well in this case.
Otherwise you can patch it and implement proper handling for your particular case.

I'll close this issue for now, because there is no plans to add this logic from our side in near future.


increase hypercore replication limit (256)

If someone wants to export this limit as require('hypercore-protocol').MAX_FEEDS or as an constructor option we could solve this for good :)

6.8.0


Ability to deploy new charts with predefined values.yaml

Hello,
I have some applications that don't require to run all day long. A UI that will help to store and deploy,uninstall some charts. would be really nice feature.
A kind of launcher in fact.
Happy to discuss further if needed.

This sounds interesting, but I did not understand it fully. Do you mean that you want to remember values.yaml for the chart when you uninstall it, and then offer it once you install it again?

Yes. Exactly. See it as an application launcher. In Lens for exemple you :

register your chart (git / helm repo)
load the definition and install/update the chart

Benefits:

it is installed in k8s so anyone with access can do this fast
store the values
Resource usage.
one interface endpoint for many admin application

I'm not sure if it's the same with this use case, but it'd be nice if we can have predefined non-default values file that we can select via UI and will automatically load into the user defined panel.
My example use case would be if we have a chart that has multiple database engine that we can choose
Default values.yaml
mysql:
    enabled: false
    # configurations

postgres:
    enabled: false
    # configurations

Then in my predefined values.mysql.yaml
mysql:
    enabled: true
    # configurations

and my predefined values.postgres.yaml
postgres:
    enabled: true
    # configurations

@appdirect-kasidit This schema of "values.mysql.yaml" - is it some sort of de-facto standard? Or is it your custom thing?

@undera it's custom thing for me, just a way to identify which file we need to add during helm install like for example
helm install . -f ./values/values.mysql.yaml

I think this is valuable feature idea. Just one more question: how would these files map to different charts? Don't you worry to show irrelevant values files for other charts?

If we store multiple values files into the same chart directory, I think it should be sufficient enough, or perhaps offer some sorts of directory that we could store this in, for example, it could be something like
helm-charts
├── chart-1
│   ├── charts
│   │   └── ...
│   ├── templates
│   │   └── ...
│   ├── .helmignore
│   ├── Chart.yaml
│   ├── values.yaml
│   ├── values.mysql.yaml
│   └── values.postgres.yaml
├── chart-2
│   ├── charts
│   │   └── ...
│   ├── templates
│   │   └── ...
│   ├── .helmignore
│   ├── Chart.yaml
│   ├── values.custom.yaml
│   └── values.yaml
...

or
helm-charts
├── chart-1
│   ├── charts
│   │   └── ...
│   ├── templates
│   │   └── ...
│   ├── values
│   │   ├── values.mysql.yaml
│   │   └── values.postgres.yaml
│   ├── .helmignore
│   ├── Chart.yaml
│   └── values.yaml
├── chart-2
│   ├── charts
│   │   └── ...
│   ├── templates
│   │   └── ...
│   ├── values
│   │   └── values.custom.yaml
│   ├── .helmignore
│   ├── Chart.yaml
│   └── values.yaml
...

Do you work like this with --local-chart option?

yes

im not exactly sure how this would translate into remote cluster though

I would implement it the following way:

Create an LRU cache, backed by file in our cache dir
Limit number of entries in cache to 5-10 per-chart
Store per-chart the values snapshots
Offer a drop-down with cached snapshots.
Maybe use explicit button of "remember as" instead of implicit


pingora-limits - Rate Estimator hashes & slots configuration

closes: #362

Thanks for the PR! It has been accepted into our internal repository. Once it's approved there it will reappear in this repo soon in a weekly sync. When that happens, this pr will be closed, and the commits associated with it will appear (squashed) in the main branch credited to the original author(s).

This landed in 760dda4fa881157e4ef930c2288412126afc320f, thanks for your contribution!


Refactor constraint evaluation.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#696  👈
#679
#669 : 2 other dependent PRs (#671 , #677 )
#667
#664
#662
#646
#644 : 1 other dependent PR (#654 )
#642
#639
#638
#637
#636
#651
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on  Graphite

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#696  👈
#679
#669 : 2 other dependent PRs (#671 , #677 )
#667
#664
#662
#646
#644 : 1 other dependent PR (#654 )
#642
#639
#638
#637
#636
#651
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.11%. Comparing base (32defad) to head (7f1a422).

Additional details and impacted files
@@                             Coverage Diff                              @@
##           06-26-implement_from_qm31_array_for_qm31     #696      +/-   ##
============================================================================
+ Coverage                                     90.10%   90.11%   +0.01%
============================================================================
  Files                                            75       75
  Lines                                          9973     9987      +14
  Branches                                       9973     9987      +14
============================================================================
+ Hits                                           8986     9000      +14
  Misses                                          904      904
  Partials                                         83       83

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add 'like' support

API now supports liking photos: https://unsplash.com/documentation#like-a-photo

:tada:


reminder re add/1

Recently, both the C and Go implementations of jq have added add/1.
The point of add/1 of course is to take advantage of jq's stream-orientation and avoid an allocation, as illustrated by jq's implementation:
def add(f): reduce f as $x (null; . + $x);

Thanks for pointing this out! This is a good idea.


Changes to VSCode Extension

Purpose

Use the module template feature in the ballerina add comment for providing Ballerina-Integrator templates to users.
Remove the placeholder functionality which was previously provided. Separate conf files will be used inside template modules for this purpose.
Remove the default snippet functionality, since it would be provided separately in align with Ballerina snippets.

Goals

Allow a user to create a new Ballerina project through the extension.
Allow a user to create a new Ballerina module using a template.
Display the list of available Ballerina-Integrator template modules.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support Adapters that interact with authenticated services

We have Tiled Adapters that interact with filesystems and databases. We have long planned Adapters that interact with services, but we have not yet implemented one.
To implement one, we seem to require two things:

The addition of "session state" to stash information that can be used to access the service. https://github.com/bluesky/tiled/blob/2862817d4e36e84ed8807344a95390712eb90cf3/tiled/database/orm.py#L184-L205
A way to pass session state to an Adapter

For (2) I propose this:

Implement a new interface, which implements the method with_session(session) (name negotiable). That method should return an Adapter to an external service, and said Adapter should be passed the session info, including session state.
In the server, when we are traversing the URL path to find the entry of interest, check for the method with_session and, if it's there, call it with the current session. This kind of thing is currently implement with hasattr, which is probably fine for now, but we should use protocols later: #449.

Just to be clear...for 1), you're proposing adding a column called session_state? Then maybe in the Authenticator class, one could optionally add to the session row? This will also require that Authenticator also be enhanced to have some knowledge of the session?

Currently, Authenticator.authenticate(...) returns the username as a string. What if it instead returned a model (could be dataclass or pydanticornamedtupeordict...) to make room for usernameandsession_state` and whatever else we might want later. This avoids coupling the Authenticators to the database but enables them to pass information to the database here:
https://github.com/bluesky/tiled/blob/2862817d4e36e84ed8807344a95390712eb90cf3/tiled/server/authentication.py#L663-L665
I remember, when drafting the Authenticators, think that I would eventually want a model with username and (other stuff) but I kept it simple to start.

I like that.


Avoid PTR lookup in GCP

Allocation to shared hosts currently fails with:
Failed allocating address on active host h2583.prod.gcp-us-central1-f.gcp-cd.vespa.yahoo.cloud allocated to hosted-vespa.tenant-host as 'container/tenant-host/0/8': Could not resolve IP address: 2600:1900:4000:b633:0:10:1:0 (NodeCandidate)

Which happens because findAllocation() tries to resolve PTR records for IPv6 addresses that are assigned to newly provisioned Public CD GCP hosts (flag).

This should not be needed once we get PTR records for IPv6 in GCP noclave.


Eats a lot of CPU

Hi, I'm using the sample code in the README file and I noticed that it consumes up to 30% of CPU usage on my desktop PC and more than 60% on my laptop.
Is there a way to fix this?
I don't need the program to always listen for a message, every 10 seconds are good enough.
Thanks

After a bit of Debugging I discovered an error in my code, it was my fault.


Mechanism to refresh dynamic credentials for providers

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
In many production scenarios, cloud provider credentials may be retrieved from external entities like Vault. Refresh doesn't instantiate the pulumi program and providers are instantiated from state which might mean using stale credentials if the dynamism is encoded in the Pulumi program. CLI users have mechanisms such as https://github.com/pulumi/pulumi/issues/4981#issuecomment-655881330 to workaround this but this is not supported in autonomous systems like the Operator. This prevents operator users from using mechanisms like auto-refresh added in https://github.com/pulumi/pulumi/pull/8071 for their stacks and might require manual intervention for refreshing credentials.
Approaches discussed so far are to add support one of the following in the stack specification:

Support a pre-flight script which can be used to fetch credentials from external entities and populate things like files, environment variables etc. supported by the underlying cloud provider.
Support a mechanism to allow stack authors to selectively target specific URNs for update before running refresh. This is essentially the equivalent of running pulumi up -t <provider> as in the CLI workaround mentioned above. With this the credential refresh code could live within the pulumi program and leverage the pulumi sdk instead of in a hand-coded script.

Affected area/feature

Some additional qualifications:

this is an issue with first-class providers specifically, because the problem arises when you explicitly construct a provider in order to do further work; since a constructed provider is a resource, its inputs are captured in the stack.
any solution must account for multiple "hops"; that is, must work when a provider is used to construct another provider.

Pre-flight script
If this is an arbitrary shell script, you have to make sure the container image has all the executables that might be invoked in the script. That's API clients for all the cloud platforms, clients for other tooling like Vault. The list is endless, so in practice is means some combination of dumping things in the released container image to cover the 80% needs, and people having to construct their own bespoke images.
Targeted pulumi up
I would expect this to put some restrictions on the way the program is written (and I would love to understand in detail what they are! :-)
If it is onerous to write a program which serves for pulumi up -r as well as pulumi -t for providers, perhaps it would be better to have two separate programs, one for doing provider construction, and one for using the providers; and a mechanism for making the latter program depend on the former.

I think using pulumi up -t is the more conservative change, so all else being equal, I would go for that one.


Unable to create ExternalSymbols in non-PE views

Version and Platform (required):

Binary Ninja Version: 4.1.5403-dev Personal (45205530)
OS: Ubuntu Linux
OS Version: 22.04
CPU Architecture: x64

Bug Description:
When in a non-PE view, symbols of type ExternalSymbol will not get created.
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

In an ELF view or empty file create a section with SectionSemantics.ExternalSectionSemantics
Define a symbol in that section with SymbolType.ExternalSymbol
The log will output an analysis update, but the symbol does not render in the view. It seems like it doesn't get created in any way.

Expected Behavior:
I would expect an ExternalSymbol to be created and rendered in the section. If doing the above steps on a PE binary, you get the expected results.
Additional Information:
Doing these steps through the API or GUI gives the same results. This is also the same result if created with define_auto_symbol or define_auto_symbol_and_var_or_function
I maintain binaryninja-xbe which loads PE-like binaries

These external symbols are created during view finalization. In other words, they must be created by the binary view type itself, and cannot be added afterwards.
I am not entirely sure whether this is the case you are discussing. If you are creating these symbols within the view creation (and thus before the binary view finalization), then it sounds like a bug. Please provide us with concrete repro steps (e.g., the binary view type code and a binary file), so that we can better triage it

Thanks for the reply! Yes, this is during view creation, or at least that's my intention. Here is where I define the external symbols, but the section ends up looking like this:

if I make them data symbols the symbols show up, they're just not the right symbol type of course.

Thanks for the reply! Yes, this is during view creation, or at least that's my intention. Here is where I define the external symbols, but the section ends up looking like this:
if I make them data symbols the symbols show up, they're just not the right symbol type of course.

You should not be creating the external section by yourself. Instead, you just need to create symbols with the extern semantics, and after view creation, binja core will scan for all such extern symbols, create a extern section, and put them into it

Should removing these lines be enough? I did that, but still don't see an extern section being created. Am I still missing something?


Not work on MacOS

Here is my code:
use global_hotkey::{
    hotkey::{Code, HotKey, Modifiers},
    GlobalHotKeyEvent, GlobalHotKeyManager,
};

fn main() {
    // initialize the hotkeys manager
    let manager = GlobalHotKeyManager::new().unwrap();

    // construct the hotkey
    let hotkey = HotKey::new(Some(Modifiers::SHIFT | Modifiers::CONTROL), Code::KeyV);

    // register it
    manager.register(hotkey).unwrap();

    let received = GlobalHotKeyEvent::receiver().recv().unwrap();
    println!("{:?}, {:?}", received.id, hotkey.id());
}

run it and nothing happend
OS version: 12.1

did you try the examples in the repo? you need an event loop to get the events.


Should we use BoundingBoxInput type in goldfinch?

At present, we are using a string and converting to a box internally. Might need to use the BoundingBoxInput so that we can link it to Phoenix.

our version of pheonix will work with BoundingBoxInput type. This has been tested with an updated version of EMU. The extent of the bbox has to be defined in the crss attribute
class Box(Process):
    def __init__(self):
        inputs = [
            BoundingBoxInput('bbox', 'Bounding Box',
                             abstract='Bounding Box Input.',
                             crss=['-170, -90, 160, 90,epsg:4326x'],
                             min_occurs=0)
        ]

@antony-wilson can you give me an example of an input that you would expect the client to send.
What should the bbox value look like in the request URL?
-10,45,1,60,epsg:4326x or -10,45,1,60 - or either?

@agstephens It looks like emu is recieving a POST when a job is submitted from phoenix
<IP_ADDRESS> - - [16/Nov/2020 13:34:44] "GET /wps?service=WPS&request=GetCapabilities&version=1.0.0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [16/Nov/2020 13:34:44] "POST /wps HTTP/1.1" 200 -

the emu code is https://github.com/bird-house/emu/blob/master/emu/processes/wps_bbox.py

@antony-wilson @jhaigh0 @cehbrecht I have forked pywps to monkey patch the way that the input BoundingBox is parsed. The original code only works with XML inputs, whereas my version accepts a string and just uses the first 4 values as the bounding box limits (left, lower, right, upper):
https://github.com/cedadev/pywps/commit/53f5ec16b85256689e6a15a1ac1055cc382758b6
This patch is required to support the BoundingBox input type in our goldfinch implementation.
@cehbrecht : Thoughts?

I'm not sure if I understand the issue. The problem is that the bbox (using BoundingBoxInput) can not be set on the client side (phoenix)? Or do you have troubles reading the bbox values (left, lower, right, upper) on the server side (goldfinch)?

I'm testing it with Emu WPS. I think you have the issue that the bbox is not correctly handled in pywps ...

@cehbrecht, yes - the issue is that the pywps library will fail if it receives a URL with a BoundingBoxInput that does not have attributes: [datainput.minx, datainput.miny, datainput.maxx, datainput.maxy]
Since we are providing a simple string input (in a URL query string) then we need something that will parse a string looking like: x1,y1,x2,y2
My fix in the fork does this. Do you think this is adequate? Do you know anyone who actually uses the Bounding Box Input type in their WPS?

@agstephens I have made a patch for pywps to fix this:
https://github.com/geopython/pywps/pull/551
The Post request should have worked before but the Get request failed. In the current PR the CRS is not parsed from the Get request.

@cehbrecht That looks brilliant. Let me know when it has been merged and we'll pull from master.
Thanks for sorting this out. It will really help us.
Tagging @antony-wilson @jhaigh0

@agstephens @antony-wilson @jhaigh0 I have merged the bbox fix:
https://github.com/geopython/pywps/pull/551
You need to use the pywps-4.2 branch (master will not work):
https://github.com/geopython/pywps/tree/pywps-4.2
Maybe we need to patch more ... but I can make a new pywps release when needed ... end of this month.

We are using this. It works!


onDeeplink() called too early on Android

Hi, thanks for the knowledge and code you have shared 👍
I have encountered an issue where if I use a deep link to start my app on Android, the intent parameters that I pass will not 'make it through' to the app, when it is started 'from cold'. If however they app is already running, and I click the same deep link, then all 3 of the parameters in my  href link reach the app.
I think this may be a timing issue with onDeeplink() being called before the Unity App has fully loaded? I think my parameters and scheme must be correct as they do indeed reach the app and get displayed if it is already running. They are in the following format:
MyApp
Thanks in advance,

Ah interesting have not tried it with this version of Unity yet - where did you place the try/catch?


feat: migrate to esm

This improvement requires updating algosdk to version 3 or higher in this repository. Earlier versions (<3) contain an incorrect package.json configuration, which prevents proper module handling in ESM contexts.


Elyra looks amazing. Interest in helping us develop Flyte pipelines integration?

Elyra looks great and is absolutely a missing piece. At Flyte we provide the infrastructure to run and orchestrate data and ML workflows at scale. We would love to explore the integration of Elyra with Flyte (for both - batch job and pipeline execution)

@kumare3 thanks for your interest in Elyra and willing to work with the community to add support for Flyte. It would great to enable Elyra to run pipelines into Flyte, and looking at a high level, it would probably be a similar effort to what we did for Kubeflow Pipelines and Apache Airflow as Flyte seems to follow a similar pattern and have similar SDKs

A good place to start looking would be:
https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/processor.py
https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/processor_kfp.py
And some direct integration with KFP is located on its own module, but we are looking into refactoring it to leverage container inits, etc
https://github.com/elyra-ai/kfp-notebook
We have our community dev meetings on Thursday's morning at 9 AM PST, maybe you could come to one of these and demo Flyte for the community, we could also schedule a more specific call or use this issue to discuss details/questions your team might have.

@lresende sorry for the late response. This sounds awesome. I would Love to demo. Maybe a week from now - Thursday 30th July?

@kumare3 Please let us know (or just show up) if you still want to demo it on our Thursday's meetings. I am also available for any technical discussion around this.

hi - ohh this fell off my radar as we got a little busy on our end. We are also working on a major overhaul of our python sdk, but a demo is a great idea to start collaboration.  I will try to message you on "gitter"

Additional info about how Flyte runs notebooks jobs


L<>s in =SUBTITLE do not work

I'm not sure if C<> and friends are affected as well.
If you look at http://docs.perl6.org/type.html, you'll notice some of the text in the right column is abridged:
class   Backtrace::Frame    Single frame of a ??? class   Tap     Subscription to a ??? role    X::Proc::Async  Exception thrown by ???
Looking at the actual POD for those classes, it seems the =SUBTITLE has an L<...> with the thing in side the angled brackets missing from the types list.

The mentioned page looks fine to me now. Can you please check?

I think L<> were simply removed, but the point is that it should work.

But if they've been removed here, we should open an issue about this
somewhere else and...
... you guessed it...
close this one, right?

This is also related to #1823. SUBTITLES are processed there. I wonder if we should create a label for that.

All Pod markup has been removed from the SUBTITLEs, so this is no longer an issue here. It might be a POD processing issue, but perl6/problem-solving#69 was created for that. So please address all additional requests there or in Rakudo proper.


Master Max Cape

🚀 Feature Proposal
Recently the Master Max Cape has been added to RS3 which is obtained by achieving level 120 in all skills (3000 Total Level). My proposal is to add the same cape for reaching 500m xp in all skills. There are currently less about 100 users who have level 120 in all skills, and far less people who have 500m xp in all skills so it would be pretty exclsusive, but a nice reward for the grind.
The cape would need the 4 previous expert capes costing a total of 25B, as well as maybe something extra to create this one (cash sink, leagues points, new suggestions?)
RS Wiki Link: https://runescape.wiki/w/Master_max_cape

BSO has the comp cape now which pretty much handles all of this.


Fixing sphinx doc strings and syntax. Standardized various parts of t…

…he doc strings.
Refs: https://openscience.atlassian.net/browse/SVCS-396
Purpose
fix up the doc strings in baseprovider. Standardize them and a few other syntax changes
Summary of Changes
fixed up the doc strings. Added the :class: flag to many variables so they properly link and format. Truncated many class paths. Fixed a table and a few notes.
QA notes
No QA should be needed

Coverage remained the same at 76.68% when pulling 685ca6d359b7d1e681bf01df4ee1d6aafa896d3a on AddisonSchiller:feature/document-cleanup into 701ff16b65c3ff75699ebf592cf14e45fe625a40 on CenterForOpenScience:develop.


reoder lineage fields

Now the lineage fields are reported in an order where first the names of all ranks are listed, following by the taxon IDs of all ranks. It would feel more natural to list them in alternating order, as a kind of (taxon_id, name) pairs. Actually, they are (taxon_id, name, rank) triplets, if the field header is taken into account.
Original issue by @pdawyndt on Thu May 08 2014 at 21:04.
Closed by an unknown user on Mon May 12 2014 at 08:28.

I know this is a detail, but it would feel more natural to me to have the columns listed as (taxon_id, name) pairs. Now they are listed as (name, taxon_id) pairs.
@tvwillem : do you intend to keep the -l option to show the complete lineage for each taxon ID in the output, or have we agreed on replacing it by the -a option for consistency with other command in the Unipept command line suit. Maybe I'm mistaken, and we need both the -a and -l options
Original comment by @pdawyndt on Sun May 11 2014 at 21:14.

@pdawyndt I've reorderd them as you suggested.
I've replaced all -l options with -a (which will be released as unipept 0.4.0 as it is not backwards compatible)
Original comment by ghost on Mon May 12 2014 at 08:28.


VS Code keeps re-ordering my "last in-focus" window

If I have 2 windows opened, let's call them Window 1 and Window 2, and let's say I have Window 1 currently in focus. If I alt+tab to another application outside of VS Code, and then alt+tab to get back to VS code, for some reason Window 2 comes in focus. I can visually see Window 1 for a split second, and then Window 2 comes in focus.
It's almost like it doesn't remember which window was in focus prior to shifting to another application, so it just automatically puts window 2 in focus instead of window 1, which is where I originally alt+tabbed out of.
Not sure if this is a setting or something, but I don't have this issue in the non-beta VS Code. Only VS Code - Insiders.
Version: 1.60.0-insider (Universal)
Commit: c08913337cb8b95493be8e99d62e0b3241563f6b
Date: 2021-08-19T05:17:33.223Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0 (macOS Big Sur v11.5.2)

Sounds like https://github.com/microsoft/vscode/issues/131218

Does this still reproduce?


fix: tensorrt.cc typo

Thank you for this pull request! If you haven't yet, could you submit a CLA (Contributor License Agreement, see here) so that we can review and merge this?

@cyLi-Tiger Please let me know when you submit your CLA. Thanks!

This typo correction was merged in https://github.com/triton-inference-server/tensorrt_backend/pull/74.


How to set ssl_context for werkzeug?

How I can I start the dev server (sls wsgi serve ) on HTTPS instead of HTTP?

This is not supported at the moment

There's a --ssl flag now

Great! Thanks @logandk