Reformat code with clang-format-18

This is a second attempt at reformatting our first-party sources with a newer version of clang-format. The first was #4938. That PR was created shortly before Ubuntu LTS 24.04 was released, and internally we decided to hold off on a flag commit like this until the new LTS was available in GitHub Actions, letting us easily update to an even newer version of clang-format (18 instead of 15). That day has come.

Confirmed that the pre-commit hook still works.


Disable warning for tasks inside callouts if they're not tagged with the global filter

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
When you interact with a task inside a callout, Obsidian Tasks will print a warning stating that it won't work with tasks items within callouts. However, it will still issue that warning even if the task items don't include the global filter.
I request the possibility to either toggle the warnings off entirely or to have them triggered only when interacting with tasks that are tagged with Obsidian Plugin's global filter.
✔ Solution
Disable the warning for non-tagged tasks within callouts.
❓ Alternatives

Toggle the warning off entirely (temporary fix if the main solution would be more work than expected)
Maybe, in the future, add the ability for the plugin to work with tasks inside callouts. (Not really a necessity, at least for me)

📝 Additional Context
The warning I'm referring to:

I looked at doing this, and it is currently not possible.
The warning is caused by Tasks not being able to work out which line the task was on that you toggled. Therefore it is impossible for it to know whether the unknown line you toggled contains the global filter.
If it became possible to identify the line you clicked on, we would actually be able to fix the behaviour, rather than worrying about disabling the warning.
There is an alternative request to be able to turn the message off altogether. Please feel free to up-vote that - see #1010.
I am therefore going to close this as 'not planned'.

I have logged #1768 to fix the underlying issue.


Store ontology using OWL functional syntax?

Need some feedback from Bill on this. If I recall he saves ontologies using OWL Functional Syntax because it preserves the order of statements in the file so change management using GitHub can be done. Just want to make sure I'm remembering correctly before I do that because I usually don't use OWL Functional syntax

Funny ... I just commented on this here. :)
Yes. In the OHD (and other OBO ontologies), the directory structure is set up like this:
<repo name>
  - src
    - ontology
      - <ontology name>-edit.owl (e.g., ohd-edit.owl)

The <ontology name>-edit.owl is saved in functional syntax. This allows for diffs to be viewed more easily (though not perfectly).
During the release process, the ontology is saved to the root directory in RDF/XML (although a TTL file can be created too). The date of the release is added to the ontology version IRI.


Deploy management failed - AZURE_CREDENTIALS set as GitHub secret

Describe the bug
We upgraded the OSS version to 0.7.0 and now we are facing this issue when we deploy using CI:

I reviewed this PR:
https://github.com/microsoft/AzureTRE/pull/2654
and created AZURE_CREDENTIALS as a GitHub secret in the mentioned format:
{
"clientId": "xxx",
"clientSecret": "xxx",
"tenantId": "xxx",
"subscriptionId": "xxx",
"resourceManagerEndpointUrl": "management.azure.com"
}
Steps to reproduce

Run Deploy Azure TRE workflow

Do I miss something? Could you please help us because this is currently a blocker for us?

@dusan-ilic-mhra please verify that the format & values corrosponds to the example given here.
I think you should try the change the resourceManagerEndpointUrl

@tamirkamara Where I can find resourceManagerEndpointUrl?

Following your comment to take a look at this link https://github.com/marketplace/actions/azure-login#configure-deployment-credentials
I run a command for the existing App Reg:
az ad sp create-for-rbac --name "App_Reg_Name" --role contributor --scopes /subscriptions/Subscription_ID/resourceGroups/management_rg_name --sdk-auth
and I’ve got this output:
{
"clientId": "xxxxxxxxxxxxxxxxxxxx",
"clientSecret": "xxxxxxxxxxxxxxxxxxxx",
"subscriptionId": "xxxxxxxxxxxxxxxxxxxx",
"tenantId": "xxxxxxxxxxxxxxxxxxxx",
"activeDirectoryEndpointUrl": "xxxxxxxxxxxxxxxxxxxx",
"resourceManagerEndpointUrl": "https://management.azure.com/",
"activeDirectoryGraphResourceId": "xxxxxxxxxxxxxxxxxxxx",
"sqlManagementEndpointUrl": "xxxxxxxxxxxxxxxxxxxx",
"galleryEndpointUrl": "xxxxxxxxxxxxxxxxxxxx",
"managementEndpointUrl": "xxxxxxxxxxxxxxxxxxxx"
}
I put this output in as AZURE_CREDENTIALS in GitHub secrets and still getting this error:

@tamirkamara  You can close this issue as we solved it by adding new secrets:
MGMT_RESOURCE_GROUP_NAME
MGMT_STORAGE_ACCOUNT_NAME
As their name has been changed in the new version.


Item filters are lost when breaking exporters

Issue description:
Item filters do not drop/are destroyed when breaking exporters
What happens:
When breaking an exporter with a filter installed, the filter does not drop and is lost.
What you expected to happen:
The filter should drop with the broken exporter.
Steps to reproduce:

Place an item filter in an exporter
Break exporter

...
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: 1.12.2-<IP_ADDRESS>7 (although have had this happen on several older versions as well)
Refined Storage: 1.5.22 (again have noticed this on older versions as well)

Does this issue occur on a server? [yes/no]
Unsure, single player only.
If a (crash)log is relevant for this issue, link it here:
No crash.
[pastebin/gist/etc link here]

That is intended. Item filters aren't meant to be retained when the inventory is broken, even if you can get them out again.


Added transferred_classes to migrations config

Fixes #2305

Looks like this issue closes https://github.com/cloudflare/wrangler2/issues/2305 ?

Do you want to clean this up and get it landed @geelen ?

hi @geelen :)  do you still plan to loop back to this PR? if not, we'll plan to close it

@lrapoport-cf: Glen's OOO until end of October at least, fyi

hey @geelen :) i believe you're back in office now so wanted to check in on this -- do you still plan to loop back to this PR? if not, we'll plan to close it


[GitHub Codespaces] There is no response when executing "Start Streaming Logs" action for a Linux Function App

Environment: GitHub Codespaces (Remote/Local)
Build Version: 20240829.1
Regression: Previous Release (v1.15.1)
Repro Steps:

Create a Linux Function App.
Right click this Linux Function App and execute "Start Streaming Logs" action.
Check whether it opens the live metrics stream in the portal or not.

Expect:
It opens the live metrics stream in the portal.

Actual:
There is no response when executing "Start Streaming Logs" action.
More Info:

This issue does not reproduce for a Windows Function App.
This issue does not reproduce in non-codespaces environment.
This issue also reproduces on the previous released functions extension v1.15.2 and v1.15.3.
This issue does not reproduce on the previous released functions extension v1.15.1.

This issue also reproduces when executing "Browse Website" action for Function Apps in GitHub Codespaces environment.


Adding more info after compilation finishes

Feature Request
Is your feature request related to a problem? Please describe.
For newcomers to the project, after compilation finishes nothing is displayed so it can be confusing knowing which port to use.
Describe the solution you'd like
Maybe considering adding something like https://github.com/Drawbotics/initial-webpack-message

Close in favor of release v0.2.4


Added RuntimeJob.queue_info() method

Summary
Added support for retrieving queue info for the current job.
This code was copied from qiskit_ibm_provider.
Details and comments
Fixes #1161.

Do we want to keep the RuntimeJob._queue_info field, or should we rather retrieve the queue_info from the backend whenever the queue_info() method is invoked?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 72 (31.94%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 55.565%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/runtime_job.py
4
15
26.67%

qiskit_ibm_runtime/utils/queueinfo.py
19
57
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
2486

Relevant Lines:
4474

💛  - Coveralls


[MARKET Protocol] Ongoing Support

User Story
Why Is this Needed?
Summary:
Description
Type:
Current Behavior
Expected Behavior
Reproduction
Solution
Summary:
Definition of Done
Additional Information

Issue moved to MARKETProtocol/planning #23 via ZenHub


[$500] Lenguage - Device language preference doesn't take effect

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Change the browser's language preference
Navigate to sign up page (https://staging.new.expensify.com/)

Expected Result:
Site language should be changed to Spanish
Actual Result:
Site language is English
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/c120a3f9-e070-4e02-a6dc-b1eabc9aa095
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016a79bfd0a9d947de
Upwork Job ID:<PHONE_NUMBER>264826880
Last Price Increase: 2024-01-10

Proposal
Root cause
We are not using the GetUserLanguage method to fetch default language, we only use it for apple locale script.
Solution
We should use the GetUserLanguage method

Proposal
Please re-state the problem that we are trying to solve in this issue
Language - Device language preference doesn't take effect
What is the root cause of that problem?
This is happening as we are not listening to language changes in language in SignInPage.
What changes do you think we should make in order to solve the problem?
We can use listener provided by react-native-localize
POC:
RNLocalize.addEventListener('change', () => {
    App.setLocale(getDevicePreferredLocale());
});

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Language - Device language preference doesn't take effect
What is the root cause of that problem?
Currently we are always getting preferredLocale from Onyx, even though the preferred language is changed, preferredLocale has already been set and has a value so it will not update preferredLocale in Onyx
https://github.com/Expensify/App/blob/f15ed75b0b4133a8c02617d20a09e29d72825a4d/src/pages/signin/SignInPage.js#L159-L164
What changes do you think we should make in order to solve the problem?
In my opinion, when we need to distinguish between prioritizing the language taken from the device or prioritizing the language that the user has previously set.
For example: When initially opening the page, the machine language is en, then preferredLocale is also en. Then if the user changes the device language to es, preferredLocale will update accordingly. But in case the user has actively changed the language, we should prioritize keeping the user's chosen language instead of updating according to the device language.
So we can add an IntendSetLocate key in Onyx to determine where the preferred language will come from when loading this page:
   IntendSetLocate: {
        key: ONYXKEYS.INTEND_SET_LOCATE
    }

At the setLocale function, we add an intend variable with the default value true, to determine whether this function is called by default or by user action to update INTEND_SET_LOCATE.
    if (intend) {
        Onyx.merge(ONYXKEYS.DEFAULT_LOCALE, true);
    }

Here we will check to see if it was an intentional set from the previous user and will skip updating the preferredLocale [ [here(https://github.com/Expensify/App/blob/f15ed75b0b4133a8c02617d20a09e29d72825a4d/src/pages/signin/SignInPage.js#L159C1-L165C1)
    useEffect(() => {
        if (preferredLocale && intendSetLocate) {
            return;
        }
        App.setLocale(Localize.getDevicePreferredLocale(), false);
    }, [preferredLocale, intendSetLocate]);

What alternative solutions did you explore? (Optional)

Updated proposal.
Added alternative solution.

I don't think we supposed this feature, and if that's the case, then it's not a bug. I've asked in Slack for confirmation.

Confirmed that this was never a feature we built, so this is a feature request as opposed to a bug. Closing for now.


Forbes video download (hosted on Brigthcove)

Possible to add? example: http://www.forbes.com/video/5118388570001/

Get the userid + token here

And then get with the header
https://edge.api.brightcove.com/playback/v1/accounts/{userid}/videos/{videoid}
ex : https://edge.api.brightcove.com/playback/v1/accounts/2097119709001/videos/5118388570001
Curl command :
curl 'https://edge.api.brightcove.com/playback/v1/accounts/2097119709001/videos/5118388570001' - -H 'Accept: application/json;pk=BCpkADawqM0-G5-DWC1YBItrQpbHMmduUmORMn1zqXbI51aL_8oYgnW6FKK6tG4YKHnTYr3j89gv68LY_J3PFJtW3hWfBV4TFF0nj1tOhpF5RqiIgeEWEij0gE1eSgiwnGWDyRJRa23G7Qjz'
Good JSON 💃

Just posting here as a reminder or if someone wants to implement it  ;)

Here's a simipler way. Check this line in webpage source:
<meta name="twitter:player" content="https://players.brightcove.net/2097119709001/598f142b-5fda-4057-8ece-b03c43222b3f_default/index.html?videoId=5118388570001" />

And download it:
youtube-dl "https://players.brightcove.net/2097119709001/598f142b-5fda-4057-8ece-b03c43222b3f_default/index.html?videoId=5118388570001"

Yes, but if we want different sources (480p,720p), description,duration etc..
It'll be easier to parse the json.

Well, those JSON parsing stuff are already in brightcove.py
$ youtube-dl -vF "https://players.brightcove.net/2097119709001/598f142b-5fda-4057-8ece-b03c43222b3f_default/index.html?videoId=5118388570001"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-vF', 'https://players.brightcove.net/2097119709001/598f142b-5fda-4057-8ece-b03c43222b3f_default/index.html?videoId=5118388570001']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.11.02
[debug] Git HEAD: cc99a77
[debug] Python version 3.5.2 - Linux-4.8.4-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.2, ffprobe 3.2, rtmpdump 2.4
[debug] Proxy map: {}
[brightcove:new]<PHONE_NUMBER>001: Downloading webpage
[brightcove:new]<PHONE_NUMBER>001: Downloading JSON metadata
[brightcove:new]<PHONE_NUMBER>001: Downloading m3u8 information
[info] Available formats for<PHONE_NUMBER>001:
format code                extension  resolution note
hls-meta                   mp4        multiple   Quality selection URL
hls-511                    mp4        480x270     511k
http-streaming-511k-270p   mp4        480x270     511k , MP4 container, H264, 29.45MiB
http-511k-270p             mp4        480x270     511k , MP4 container, H264, 29.45MiB
hls-792                    mp4        640x360     792k                                                                                hls-993                    mp4        640x360     993k
http-streaming-994k-360p   mp4        640x360     994k , MP4 container, H264, 57.10MiB
http-994k-360p             mp4        640x360     994k , MP4 container, H264, 57.10MiB
hls-1291                   mp4        960x540    1291k
hls-1825                   mp4        960x540    1825k
http-streaming-1825k-540p  mp4        960x540    1825k , MP4 container, H264, 104.63MiB
http-1825k-540p            mp4        960x540    1825k , MP4 container, H264, 104.63MiB
hls-2623                   mp4        1280x720   2623k                                                                                http-streaming-3123k-720p  mp4        1280x720   3123k , MP4 container, H264, 178.86MiB
http-3123k-720p            mp4        1280x720   3123k , MP4 container, H264, 178.86MiB (best)

$ youtube-dl --get-description "https://players.brightcove.net/2097119709001/598f142b-5fda-4057-8ece-b03c43222b3f_default/index.html?videoId=5118388570001"
COO and marketing chief talks Hamsters, Soul and why TV advertising still scores big for the brand.

oh, my bad, so yes it's easier 😀

Hey, im looking into this one, how are you getting the account ID?


The msg_type argument in the node.subscribe method is unclear. (Python gz.transport14)

I am attempting to use the node.subscribe method to subscribe to a topic. It appears to require three arguments, msg_type, topic and callback. I have not been able to find in what way the msg_type variable should be passed. There does not appear to be any reference to msg_type in the documentation https://gazebosim.org/api/transport/14/messages.html.
What values of msg_type can be passed?

The msg_type is the class that is generated from the gz-msgs proto. I believe it's covered in the python tutorial https://gazebosim.org/api/transport/14/python.html


OHRI-1172 Latest pregnancy information displayed

@kajambiya did you see the build error?

@kajambiya did you see the build error?

Yah, hadn't rebased on latest dev but have pushed a commit

@samuelmale I've addressed the suggestions as per your comments. Kindly confirm


How many epoch did you train on this dataset?

How many epoch did you train on this dataset?

10 epochs


Zigbee2mqtt: Actuators management

Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

[x] If your changes affects code, did your write the tests?
[x] Are tests passing? (npm test on both front/server)
[x] Is the linter passing? (npm run eslint on both front/server)
[x] Did you run prettier? (npm run prettier on both front/server)
[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
[ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Please git rebase origin/zigbee2mqtt-service (or git merge) to resolve conflicts.

It's OK for me. I don't see any conflict anymore.


[GH-10035] Added the cypress spec for cancel out leave a team modal

Summary
Added the cypress test for the case "cancel out leave a team modal"
Ticket Link
https://github.com/mattermost/mattermost-server/issues/10035
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

@saturninoabril made the changes. Kindly review


Add visualize command

Kafka JVM example topology:
Somewhat more complex topology:
Fixes #22.
Note: The code is based on dask's dot module.

Coverage decreased (-1.008%) to 44.936% when pulling 2897a01679a9ffb21eb9cc38b4a77c2feb7327f3 on feature/visualize into 738c058e8db244ae825a15ecc136bf80ee14bd7b on master.


Added a PortSchemeResolver to fetch the schemeType from serverConfiguration

Considered adding a ServerLifeCycleListener, and using the serverStatus method to derive the portScheme using which serviceProvider shall be built. The issue was, by this time, the lifecycle listener would have been invoked, (loadbalancers like traefik etc could have registered this),and on a failure of a serviceProvider creation, server would stop abruptly - may load to 502s from calls coming from load balancers and proxies during the sigterm.
Given it is a dropwizard app, relied on ServerFactory instead. The default resolver is written to get the port, which will suit most dw applications. The default factory that dropwizard creates itself is a DefaultConnectionFactory, and using the first applicationConnector to do the portSchemeMapping. - If you have multiple, you'll anyway need to create multiple sd-bundles, since serviceProvider accepts only one scheme anyway. It was the same I would have done for the resolver too.
Added tests for the same. @santanusinha : Please let me know if you want to fallback onto the ServerLifeCycleListener (if the small window of failures are actually not all that jarring, TBF - this implementation is to avoid them if we can). Both of them work of user configs only (one before starting and one after). So I thought it sane to rely on serverFactory instead to fail fast on serviceProvider creation errors if any. (There is a risk here too, if the serviceProvider is created but the rest of the code fails, then ranger 502s, but that can be solved by initial stalenessThreshold or marking the node healthy only after server starting).
Let me know which way you want to proceed. Either can be done.
[UPDATE]

After discussion changed to ServerLifecycleListener the 502s that may occur are tolerable and can be lived with, as opposed to cost of every developer understanding what stalenessThreshold is etc.

Also @santanusinha can you pls once run a format code, according to your style guide pls, I use the style guide, https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml - And I have tried to adjust to your style
guide, seems like there may be some misses, would be helpful if you could run a style guide once.

Have formatted it according to, https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml. It seems to be matching your old code style. So resolved the format comments. Lmk of anything pls. @santanusinha


0.8 is not on crates.io yet

Maybe this is intentional, but in case it's not, see this as a friendly reminder :)

Done. My mistake. I was planning to publish 0.8 and work on the new API in 0.9.


Allow tweaking environment of run_audit.sh script

Pull request details
Overall Review of Changes:
Allow tweaking environment of run_audit.sh script. It is related to the issue created in RHEL8-CIS repository
Issue Fixes:
https://github.com/ansible-lockdown/RHEL8-CIS/issues/186
Enhancements:
Changes in this PR do not modify default functionality and only allow for modifying previously static values in run_audit.sh.
How has this been tested?:
It has been tested by setting audit_out_dir to something other than default value.

hi @pavloos
Great change we really appreciate the work and helping to improve this product.
Regards
uk-bolly


Revert "Remove windows from the list of supported platforms"

Reverts docker/docker#10290
See https://botbot.me/freenode/docker-dev/msg/31616675/ for the promise from @ahmetalpbalkan that it'll be fixed in 1.6 and we'll actually get to release it. :wink:

yay @ahmetalpbalkan :)

LGTM

LGTM

LGTM

LGTM


Validation regex

Update validation regex such that

Name can only take alphabets and spaces
Phone numbers can have an additional '+' in front for international number codes
Module names cannot be blank

Closes #117

Codecov Report
Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...n/java/seedu/address/model/person/ContactType.java
75.00%
0 Missing and 1 partial :warning:

Files with missing lines
Coverage Δ
Complexity Δ

...in/java/seedu/address/model/person/ModuleName.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

src/main/java/seedu/address/model/person/Name.java
92.85% <ø> (ø)
6.00 <0.00> (ø)

...rc/main/java/seedu/address/model/person/Phone.java
92.85% <ø> (ø)
6.00 <0.00> (ø)

...n/java/seedu/address/model/person/ContactType.java
72.22% <75.00%> (+1.63%)
9.00 <3.00> (ø)


[explorev2] fix textfield and druid bug

Bug:

when textfield is empty, it is set to true/false in reducers
fetch_datasource_metadata was broken for druid

Solution:

differentiate checkbox with text/select by identifying undefined action.value
remove time_grains for druid when fetching metadata

Tested in staging:

@ascott

LGTM 🚢


docs: fix typos in comments and documentation

Description
fix typo to comment and document

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I apologize for any inconvenience my inadequate response may have caused. I appreciate your response! I wish "vite" all the best in its development✨

I apologize for any inconvenience my inadequate response may have caused. I appreciate your response! I wish "vite" all the best in its development✨

Oh, what? Why you think it was inadequate?
Everything is fine, fixing typos like this is very welcome 🙏


GitHub issues exporter

Exports GitHub issues to a file that can be read by radicle:
stack exec radicle-github-issues -- oscoin radicle -o githubissues.rad -t <github-token>

Then you can access these issues in radicle, transform them, sign them, submit them to chains, etc.:
rad> (def issues (read (read-file! "githubissues.rad")))
()
rad> (nth 0 issues)
{:author-github-username "jkarni"
 :body "Something like \r\n\r\n```\r\n(def send-signed!\r\n  (fn [pk sk url expr]\r\n    (send! url {:payload   expr\r\n                :author    pk\r\n                :signature (gen-signature! sk (show expr))})))\r\n```\r\n\r\nAnd a corresponding `verify-sig`. In addition to simplifying things, this helps ensure signing and verifying signatures are done in a similar way.\r\n\r\nNote that then `rad/chains/issues.rad` and `rad/chains/issues-remote.rad` can be changed to use this."
 :comments []
 :created-at "2018-11-13T10:30:13"
 :github-assignees []
 :labels []
 :state :open
 :title "Version of `send!` that signs all expressions"}

Nice!


Fix logic around "Too Many Requests" status code

Right now we catch if a KP returns a 429 "Too Many Requests" response, but immediately call the service again. There's code in there to set a delay on requerying, but we don't actually use it. We should be nicer to the KPs.

All of this logic was removed in #413 because we can't spend the time to send another query to the kp. We need to return answers quickly.


Update dev-ko with main branch

Code review is not required :)

GitHub says that we need to resolve conflicts (caused by #922) to merge this PR. 😅


Why erizos stats aren't included in publisher stats?

I just wanted to try to have some stats of a publisher only scenario.
What i got was this:

I was very surprised to not have any information about, especially for jitter.
So I looked into the StatsHandler.cpp and I was very confused by these lines:
https://github.com/lynckia/licode/blob/5b49a126c3332eb5c8aed2e70fc1ba3e0bdfa6d6/erizo/src/erizo/rtp/StatsHandler.cpp#L111
https://github.com/lynckia/licode/blob/5b49a126c3332eb5c8aed2e70fc1ba3e0bdfa6d6/erizo/src/erizo/rtp/StatsHandler.cpp#L147
Is there any reason to do this?
Since we generate feedback (RR and REMBs) from licode to the publisher, these stats could be helpful to know the actual jitter of the packets and the packets lost from the publisher to the server.
Am I wrong?

There is no other reason that we didn't need it before, but it makes a lot of sense. You're free to add that info to the stats object if you want to do it. If you can't we can schedule some time in the future to do it.

One big problem with erizo stats I figured it out is that the network issues in the subscriber side affect the publisher's stats and vise versa. It makes the stats report completely useless.

The stats report is really useful for Simulcast since subscriber side rarely affect publisher side, and it's not completely true in general since we keep measuring some metrics in Erizo side (REMB, packet losses, etc.) and we can see where the issues come from.


Remove incorrect debug_assert from ed25519_pub_key_from_bytes

What
Remove an assertion that does not hold.
Host::ed25519_pub_key_from_bytes contains an assertion about the length of the provided pubkey:
    pub(crate) fn ed25519_pub_key_from_bytes(&self, bytes: &[u8]) -> Result<PublicKey, HostError> {
        debug_assert!(bytes.len() == 32);
        self.charge_budget(ContractCostType::ComputeEd25519PubKey, None)?;
        PublicKey::from_bytes(bytes).map_err(|_| {
            err!(
                self,
                (ScErrorType::Crypto, ScErrorCode::InvalidInput),
                "invalid ed25519 public key",
                bytes
            )
        })
    }

    pub fn ed25519_pub_key_from_bytesobj_input(
        &self,
        k: BytesObject,
    ) -> Result<PublicKey, HostError> {
        self.visit_obj(k, |bytes: &ScBytes| {
            self.ed25519_pub_key_from_bytes(bytes.as_slice())
        })
    }

Why
A guest can trigger this assertion in the host by providing a BytesObject with incorrect length to the Host::verify_sig_ed25519 syscall:
    fn verify_sig_ed25519(
        &self,
        _vmcaller: &mut VmCaller<Host>,
        k: BytesObject,
        x: BytesObject,
        s: BytesObject,
    ) -> Result<Void, HostError> {
        let public_key = self.ed25519_pub_key_from_bytesobj_input(k)?;
        let sig = self.signature_from_bytesobj_input("sig", s)?;
        let res = self.visit_obj(x, |payload: &ScBytes| {
            self.verify_sig_ed25519_internal(payload.as_slice(), &public_key, &sig)
        });
        Ok(res?.into())
    }

By removing the assertion, the function will return an error that can be correctly propagated instead of panicking.
Known limitations
No tests. I attempted to add a test to soroban-test-wasms but could not get the wasms to build and pass existing tests - there seem to be some transitional changes to AuthorizationContext and BytesN/Address that need to be implemented, and which I could not figure out.

Thanks, I generally don't feel great about debug assertions in the code at all .. I see we have a few, but I think they might be worth removing. Especially in cases where it's possible for user input to violate them, "what do we actually want to do here if this is wrong" should have an answer better than "oh well in a non-debug build we just ignore it". If it's an important invariant we should probably return an error!


Feature: Add launch for generic app start

This should start the remote application as though it were started normally. This effectively should mimic the start of the regular app.
The intent here is to allow for a simple UI testing library rather than the hassle of recreating the app.xaml and main window startup (which may not be reasonably possible with things like DI).

No longer relevant, though probably should be documented.


Added ListDatasets

So all I added was the get request on /pool/dataset to list datasets then ran ./generate.sh it seemed to change a fair few files :shrug:

Hm, something must have changed in openapi generator, let me try re-generate this with newest version of it later today and that should hopefully cleanup your pr

Hey @dariusbakunas any luck on the re-generating?

sry, took a while, re-generated using v0.6.1 generator, update your branch and it should clean things up

Could you run go mod tidy that should probably fix current failure https://github.com/dariusbakunas/truenas-go-sdk/runs/7398416686?check_suite_focus=true

Good spot, that seems to have updated go.sum. I think after running ./generate.sh it removes a fair amount from go.sum so might be worth adding in go mod tidy to the generate script.


c_macos_opt.bins/opt/dualstack_socket_test failure in Master

https://grpc-testing.appspot.com/job/gRPC_master_macos/1635/testReport/junit/(root)/c_macos_opt/bins_opt_dualstack_socket_test/
D0221 01:27:38.823204000<PHONE_NUMBER>46976 test_config.c:379]            test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1
D0221 01:27:38.828297000<PHONE_NUMBER>46976 ev_posix.c:107]               Using polling engine: poll
I0221 01:27:38.845119000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1116 client=<IP_ADDRESS>:1116 (expecting success)
D0221 01:27:38.847375000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1116'
I0221 01:27:38.862348000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1304 client=[::ffff:<IP_ADDRESS>]:1304 (expecting success)
D0221 01:27:38.863461000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1304'
I0221 01:27:38.868373000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1256 client=ipv4:<IP_ADDRESS>:1256 (expecting success)
D0221 01:27:38.869493000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1256'
I0221 01:27:38.874220000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1086 client=ipv6:[::ffff:<IP_ADDRESS>]:1086 (expecting success)
D0221 01:27:38.875640000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1086'
I0221 01:27:38.880739000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1225 client=localhost:1225 (expecting success)
D0221 01:27:38.882774000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1225'
I0221 01:27:38.889211000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1294 client=<IP_ADDRESS>:1294 (expecting success)
D0221 01:27:38.890693000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1294'
I0221 01:27:38.895641000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1143 client=[::ffff:<IP_ADDRESS>]:1143 (expecting success)
D0221 01:27:38.898159000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1143'
I0221 01:27:38.902426000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1324 client=ipv4:<IP_ADDRESS>:1324 (expecting success)
D0221 01:27:38.903861000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1324'
I0221 01:27:38.908636000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1151 client=ipv4:<IP_ADDRESS>:1151,<IP_ADDRESS>:1151,<IP_ADDRESS>:1151 (expecting success)
D0221 01:27:38.909828000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1151'
I0221 01:27:38.915056000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1218 client=ipv6:[::ffff:<IP_ADDRESS>]:1218,[::ffff:<IP_ADDRESS>]:1218 (expecting success)
D0221 01:27:38.916516000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1218'
I0221 01:27:38.921071000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1037 client=localhost:1037 (expecting success)
D0221 01:27:38.923254000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1037'
I0221 01:27:38.928055000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1239 client=[::1]:1239 (expecting success)
D0221 01:27:38.929780000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1239'
I0221 01:27:38.935111000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1131 client=[::1]:1131 (expecting success)
D0221 01:27:38.936396000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1131'
I0221 01:27:38.941012000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::]:1173 client=ipv6:[::1]:1173 (expecting success)
D0221 01:27:38.942263000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1173'
I0221 01:27:38.946456000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1111 client=ipv6:[::1]:1111 (expecting success)
D0221 01:27:38.953985000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1111'
I0221 01:27:40.993094000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1264 client=<IP_ADDRESS>:1264 (expecting success)
D0221 01:27:40.994209000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1264'
I0221 01:27:40.998836000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=<IP_ADDRESS>:1326 client=ipv4:<IP_ADDRESS>:1326 (expecting success)
D0221 01:27:40.999835000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv4:<IP_ADDRESS>:1326'
I0221 01:27:41.007430000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::1]:1159 client=[::1]:1159 (expecting success)
D0221 01:27:41.008466000<PHONE_NUMBER>46976 dualstack_socket_test.c:235]  got peer: 'ipv6:[::1]:1159'
I0221 01:27:41.016173000<PHONE_NUMBER>46976 dualstack_socket_test.c:154]  Testing with server=[::1]:1098 client=<IP_ADDRESS>:1098 (expecting failure)
E0221 01:27:42.526575000<PHONE_NUMBER>46976 dualstack_socket_test.c:251]  assertion failed: status == GRPC_STATUS_UNAVAILABLE

ping

Happened again https://grpc-testing.appspot.com/job/gRPC_master_macos/2150/testReport/junit/(root)/c_macos_opt_native/bins_opt_dualstack_socket_test/

Closing for bankruptcy (and not a P1).


Please provide distfiles

Original issue 176 created by<EMAIL_ADDRESS>on 2012-05-07T15:06:39.000Z:
Creating packages for google-authenticator is hard because there are no official distfiles (aka release files) that can be downloaded.  Telling end users to "git clone" might be borderline-appropriate, but it's just not an usable mechanism for packaging systems (whichever they are).
As a matter of fact, I packaged google-authenticator yesterday for NetBSD and was forced to create one of such files myself: run git clone, create a .tar.gz file, upload it to the NetBSD servers and use such distfile in our package.  After a bit of searching, I noticed that FreeBSD encountered the same problem and they had to resort to the same "solution".  This is not only for BSD though: any Linux distribution willing to create a package will encounter the same problem... which is a pity!
Upstream really needs to provide distfiles if they want packaging systems to include reproducible, deterministic packages.  This is very important.  (When I created my custom distfile yesterday, I had no idea if git head was supposed to be in a stable or not, for example.)
So, my request: could you please provide such distfiles?  If you don't want to commit too much resources to them, it's as easy as creating a monthly tarball and uploading it to the Downloads section of your code.google.com project.  If you did this, you'd end up with file names like google-authenticator-0.0.20120506.tar.gz.  However, I'd suggest going towards a more formal release procedure and start naming your releases like google-authenticator-1.0.tar.gz etc.  With a more formal release procedure, you'd need to include a NEWS file in your package explaining what the major changes between versions are.
No matter which option you choose, please do not reuse published distfile names nor ever change them once public.  Each distfile must have its unique name (tagged with the date or with a version number as shown above) and it must remain unchanged (as otherwise external checksums would break).

The https://google-authenticator.googlecode.com/files/libpam-google-authenticator-1.0-source.tar.bz2 tarball seems to have recently disappeared. Now that this project is being hosted on GitHub, would it be possible to use GitHub's Releases feature to make releases? The libpam directory is still getting updated frequently and it would be great to have known-good commits (or tarballs, etc.) we can build from.
I wouldn't worry too much about how to publicize releases - interested parties like myself can always manually check, GitHub autogenerates Atom feeds for Releases, and that process can always be improved later. It's most important IMO to start having anything at all to point to as a release.

Will do. I created #576 to do this, since this bug is full of legacy codesite discussion.
And then I can finally get around to putting the PAM stuff in its own repo, since that's long overdue.
https://github.com/google/google-authenticator/issues/575


config check

Removed the config flag in start.js
Added start-config.js containing the config flag
pinokio.js checks if config.json is present and launches IO Paint accordingly with or without the flag
Settings will be always displayed to point the user to the possibility to set a config file (can be easily missed due to autostart)
Switched to torch for cuda 12.4
Added numpy 1.26.4 for windows amd since torch-directml uses numpy 2.x as dependency which causes incompatibility
Removed the flag for web-config.js to use the default file name config.json for the config file

Closes #1


Mark some variables as non temporal

Is there a way to mark certain variables as non temporal? That is, their value does not change and remains the same as it was at Time 0.

Not really, this is also a nice extension. Mixing temporal and non-temporal variables.
But you can easily simulate these settings by using standard temporal variables which do not depend on any variable in the previous time step. When providing evidence you copy the value from Time 0 to all the following time steps.

Ok. But while generating samples, the value of non temporal variables keeps changing. This is another use case

OK. I think I get your point. I propose you the following hack:
a) Define your variable X at time 0 as you like.
b) Define you variable X_t conditioned to X_t-1 and hard code a deterministic relationship. E.g. if X_t is binary then p(x_t=0|x_t-1 = 0) = 1, p(x_t=1|x_t-1 = 0) = 0, p(x_t=0|x_t-1 = 1) = 0 and p(x_t=1|x_t-1 = 1) = 1.
Then, the sampled value at time 0 will not change in the time sequence.


Add a syntax to express the new _Class and _Native class layout constraints

The syntax is "T: _Class" and "T: _NativeClass".

@swift-ci please smoke test and merge


Create a modal library for interactions that require user input.

User Sory:
As a user
I want to be able to input grocery expiration dates manually
Acceptance Criteria:
WHEN I click on the "+" button,
THEN a modal form will appear asking for the item name, quantity, and expiration date
WHEN I click on the "Add Item" button in the form
THEN user input will be saved to local storage
WHEN I view the grocery list
THEN I see all the items I have added
WHEN I click on the "Delete" button next to the item
THEN item is removed from the grocery list
WHEN I refresh the page
THEN the saved tasks persist


Working test case of Data Center with compute as a package.

The data center test case is now working with the latest changes.

Tested and pushed a minor fix - only two clients were used since three of them had the same name.


🔄 synced file(s) with seedcase-project/.github

synced local file(s) with seedcase-project/.github.

Changed files

synced local  .vscode/settings.json with remote  .vscode/settings.json

This PR was created automatically by the repo-file-sync-action workflow run #9127784943

This turned up in my Inbox, is a review needed, or is this something that just gets sorted automatically?

@K-Beicher nope, all good!


Incompatible with rocket-0.5.0-rc.4

Full changelog
I guess these is the relevant changes:

Route Forward outcomes are now associated with a Status.
Outcome::Failure was renamed to Outcome::Error.

error[E0308]: mismatched types
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket-basicauth-2.1.1/src/lib.rs:166:35
    |
166 |             0 => Outcome::Forward(()),
    |                  ---------------- ^^ expected `Status`, found `()`
    |                  |
    |                  arguments to this enum variant are incorrect
    |
help: the type constructed contains `()` due to the type of the argument passed
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket-basicauth-2.1.1/src/lib.rs:166:18
    |
166 |             0 => Outcome::Forward(()),
    |                  ^^^^^^^^^^^^^^^^^--^
    |                                   |
    |                                   this argument influences the type of `Outcome`
note: tuple variant defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket-0.5.0-rc.4/src/outcome.rs:111:5
    |
111 |     Forward(F),
    |     ^^^^^^^

error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket-basicauth-2.1.1/src/lib.rs:169:34
    |
169 |                 None => Outcome::Failure((Status::BadRequest, BasicAuthError::Invalid)),
    |                                  ^^^^^^^ variant or associated item not found in `Outcome<_, _, _>`

error[E0599]: no variant or associated item named `Failure` found for enum `Outcome` in the current scope
Error:    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rocket-basicauth-2.1.1/src/lib.rs:171:27
    |
171 |             _ => Outcome::Failure((Status::BadRequest, BasicAuthError::BadCount)),
    |                           ^^^^^^^ variant or associated item not found in `Outcome<_, _, _>`

Some errors have detailed explanations: E0308, E0599.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `rocket-basicauth` (lib) due to 3 previous errors
Error: warning: build failed, waiting for other jobs to finish...
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Closed by #8


Management of include paths

This is a complement to point #175
In the current spec we can:

either declare an entire directory as header ==> this directory must be considered when buidling
or declare a precise list of header files

It seems that in both cases, when it comes to the build system, the CMakeLists.txt is generated with a directive like:
set(INC_PATHS
   "c:\myheaders_path"

This means that the user code can access any header file from the Inc folder.
This is not only a matter of public and private header files, it is also a matter of making sure we include only what we are supposed to include.
Does it mean that each component must have its own Inc/ folder to keep a proper access control?

@massonal

From a build perspective there is no difference whether the component specifies an include path or a header file, because the header file needs to be added to the project explicitly via an include "<header file>" statement in the source module that requires access to the component. The specified header files of a component act as a contract between the consumer and the provider and the component version must reflect the compatibility of this contract over time.
Tools should guide the user to locate the header file(s) for a component. In order to keep things simple, a single header file is ideal. E.g. in the uVision editor there is a context menu item (Insert "#include file") that lists the header files of all selected components with the component they belong to. Once the user chooses one, the corresponding include statement is added to the source code.

Speaking from my past experiments with GCC, I have gotten to know about quite a few flags managing includes, but there are limitations to what's possible (probably by design, so they are unlikely to evolve):

you can use -I/-isystem/... to add a headers search directory in scope for the preprocessor;
you can use -include to force-include a header file before the compiler starts on the regular input files;
BUT you there is no option to put a single header "in scope": it's either a directory or nothing. So you have to group your headers in directories by "recipient", no matter what tools "above" the compiler do.

All this gets me to think, maybe the file categories "include" and "header" should have differing purposes entirely?
Like, "include" would translate to a compiler flag, whereas "header" would just serve to list the files that are part of the component?
And, to go back to #175, "include" could have a public/private attribute to manage access rights -- but not "header", that would not be its point.

Let's not break the 30380 component descriptions described in 841 packs and retain the way we describe header files today (a header file with a public include path).
Proposal

for specifying "private" include paths we introduce the additional file categories:

includePrivate
includeAsmPrivate
includeCPrivate
includeCppPrivate
includeLdPrivate

Note: The existing include* file categories are always treated as public include paths, as already today.

for (optionally) listing all header files belonging to the component, we add a new file category headerPrivate. Adding separate categories per Asm, C, CPP and Linker seems overkill but could be done for consistency.
Note: csolution shall list these files in the *.cbuild.yml but not in the CMakeLists.txt.

Please provide your feedback. Am I missing any aspects?

Let's not break the 30380 component descriptions described in 841 packs and retain the way we describe header files today (a header file with a public include path).

👍
Backward compatibility is essential, of course!

Proposal

Your proposal is totally in line with what I had in mind; I think it's one of the most straightforward ways to solve the issue at hand.

An other solution I had envisioned is an optional attribute on files, e.g.,
<file category="header" name="Inc/my_internal.h" visibility="internal"/>

And, for compatibility, the default visibility being "public".
(The wording being, of course, flexible: "visibility", or "scope", or ... // "internal", or "private", or ...)


Terminology, Formatting & Typos

Find & replaced EMET with Windows Defender Exploit Guard - NOTE - We need to add guidance around how exactly to configure this. Could be that the configuration from the latest MS Security Baselines is sufficient.
A number of formatting, grammar and typo fixes.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: clconlin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

(ref. #901)


Migrating to Kotlin 1.3

There are some issues when updating Kotlin to 1.3, mainly the entire coroutine support failing.
See #294  and #286.
This PR is not one to be merged, but to be able to experiment and track some of the issues that arise.

Issues are resolved when the fix for https://github.com/mockito/mockito/pull/1501 is applied.


Update CoC and add CONTRIBUTING file

Update the CoC to align with other Swift CoC projects we maintain and add a CONTRIBUTING file.

Added the template and will start using it here 😉


Update prime-router to target JVM 19

This PR updates prime-router to target JVM 19.
Test Steps:

Run all tests and build processes and verify there are no failures.

Changes

Remove use of deprecated Locale(String) constructor.
Update project configuration to target JVM 19.

Checklist
Testing

[x] Tested locally?
[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

This may be closed in favor of #7539.


Add Group Metadata

Summary

The proto format for group metadata and associated policies

@richardhuaaa I've removed the not_condition, since it was unused and has no immediate use-case.

@richardhuaaa I've removed the Add/Remove installation policies, so the policies are just for members right now.


search app: faceting based on a boolean column

Cell_Line has a few boolean columns. When I click on those columns in order to specify the faceting criteria, nothing shows up under them.

This should have been fixed now through the commit 8b590dd454614f82add813b8b4f0e6a22adc8949

@chiragsanghvi please help me review this fix on rbk-dev.


conda-forge recipe breaks

Hi nbsphinx team! I'd like to submit an nbsphinx recipe to conda-forge, so that I can build another package (i.e. PyMC3) in its totality, but I noticed that the build keeps breaking because of an import error. [PR].
More specifically, conda-forge scripts require at least one test to be run, (please see here), but I wasn't sure what would be the appropriate test to run after building and running. Would you be kind enough to advise please?

I remember seeing the import error when doing import nbsphinx in an interactive session. When called by Sphinx, the module sphinx.errors seems to be imported already.
Can you please make a PR for the missing import?
I guess a import sphinx.errors should be sufficient, right?
The thing with the tests is a bit more involved, see #58 and #57.
It's quite laborious to make proper tests, because test cases would have to be Jupyter Notebooks (or their in-memory representation) and the resulting HTML/LaTeX files would have to be parsed to see if they have the expected contents (and if they even exist).
Probably Sphinx's own tests (https://github.com/sphinx-doc/sphinx/tree/master/tests) could be somehow re-used, but I don't really know if that's feasible.
Either way, I don't have the time nor the stamina to make proper tests.
If you want to do that, go ahead, I'd like to see a PR for that.
In the meantime, if importing isn't enough, I think it would be easiest to make some kind of dummy test for the conda recipe
test:
  imports:
    - nbsphinx
  commands:
    - true  # [unix]

If you want, you can also try to build the nbsphinx docs as a test, the command python setup.py build_sphinx should do that, see CONTRIBUTING.rst.
I don't know if that'll work on the CI server, though ...

@ericmjl I just made a new release (0.2.11) including the missing import.

@mgeier: thank you for the help! I'm sorry I didn't get to this earlier on, grad school got busy. I will try the new release and report back.

@ericmjl Any news?

@mgeier: apologies again! Grad school... There's a recipe for 0.2.13 up on conda-forge. I think this can be closed!

OK, thanks!


BigQuery: bugs with insert_overwrite+partitions

Describe the bug
When you run incremental model in BigQuery with incremental_strategy='insert_overwrite' and specifying partitions has two bugs:

it raises type error
it tries to insert data out of specified partition

The detail is explained in the later section.
Steps To Reproduce

Setup profile to use BigQuery
Write model like this{{ config(
    materialized='incremental',
    incremental_strategy='insert_overwrite',
    partition_by={'field': 't', 'data_type': 'timestamp'},
    partitions=['20210101'],
)}}
select
    1 as v
    , current_timestamp() as t

Execute dbt run twice (to make it run in incremental mode).

The result is
Type error
Database Error in model xxx (models/xxx.sql)
  No matching signature for operator IN for argument types TIMESTAMP and {INT64} at [18:56]
  compiled SQL at target/run/letstry_dbt/models/xxx.sql

The actual SQL run was (whitespaces are formatted by me):
merge into `rmp-dmg-dev`.`tmshn_work`.`xxx` as DBT_INTERNAL_DEST
    using (
        select
            1 as v
            , current_timestamp() as t
    ) as DBT_INTERNAL_SOURCE
        on FALSE
when not matched by source and timestamp_trunc(DBT_INTERNAL_DEST.t, day) in (20210101)
    then delete
when not matched
    then insert (`v`, `t`) values (`v`, `t`)

The problem happens at in (20210101) part, which comes from
https://github.com/dbt-labs/dbt/blob/b37f6a010e549f1f0150846e9f74526099e55a3f/plugins/bigquery/dbt/include/bigquery/macros/materializations/incremental.sql#L26
Maybe it should be something like
{% for p in partitions %}
{{ "parse_timestamp('%Y%m%d', '%s')" % v }}{{ "," if not loop.last}}
{% endfor %}

(should be changed based  on partition_by.data_type.)
Insert data out of partition
In addition to the above problem, the rendered SQL indicate that it insert all the data from query result, which might include data out of the partition; the specified partitions is used only for deleting data (is it the user's responsible to filter out such data?).
Expected behavior
Query runs without an error, and only related partitions are modified (in the above simple example, nothing should be changed since it's not 20210101 now).
Or, as another possible choice, we should have an error saying "you should not use partitions with insert_overwrite because partitions are naturally determined only by SQL, so we don't need to specify partitions".
Screenshots and log output
If applicable, add screenshots or log output to help explain your problem.
System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[x] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
$ dbt --version
installed version: 0.20.0
   latest version: 0.20.1

Your version of dbt is out of date! You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation

Plugins:
  - bigquery: 0.20.0
  - snowflake: 0.20.0
  - redshift: 0.20.0
  - postgres: 0.20.0

The operating system you're using:
macOS
The output of python --version:
$ python --version
Python 3.7.6

Additional context
The discussion is branched from https://github.com/dbt-labs/docs.getdbt.com/issues/776

Thank you for the clarification and pointing out the corresponding document!
I still have a feeling that this is a bad UX because the inconsistency of the format between materialized='table' vs. materialized='incremental' surprised me.
However, I understand this is perfectly expected behavior, and actually the former form will be removed (or deprecated) sooner or later. Thanks.


Increases width of charts / tables on IE

Increases the width of charts / tables on IE to 80% of the container

 Fix charts on Edge and IE


[RFE] Cloud Credentials Expiry field support

Is your feature request related to a problem? Please describe.
To support https://github.com/rancher/dashboard/issues/11332, corresponding backend changes are needed.
Describe the solution you'd like
From RFC 010:

Rancher’s backend will add an annotation (for example, cattle.io/expiryTime) indicating when the cloud credential will expire. This annotation will be defined as an epoch time, allowing for credentials to be sorted by expiration. Support for this annotation will at first be limited to Harvester Cloud Credentials, but may be expanded to other Cloud Credential types (e.x. Digital Ocean, AWS, Azure) if possible.

Describe alternatives you've considered
Service account type based solution is tracked per https://github.com/rancher/rancher/issues/44912 / https://github.com/rancher/dashboard/issues/11271
Additional context
N/A

This is validated as a part of https://github.com/rancher/rancher/issues/47667 and should be okay to close.
@m-ildefons please confirm and reopen if needed.

That's correct.


Recorded video seems to be of bad quality.

I am experiencing a bad quality video output from VideoCapture sample.
I tried setting a higher bitrate(which I got from CameraProfile class) but it still doesn't help.
Is this a bug or something I'm doing wrong ?

Hi @MarsVard
I think it is in the constructor of VideoFormatAndroid,

public VideoFormatAndroid(String mimeType, int width, int height) {

    if (width > 1280 || height > 1280) {
        if (width > height) {
            width = 1280;
            height = 720;
        } else {
            width = 720;
            height = 1280;
        }
    }
    this.mediaFormat = android.media.MediaFormat.createVideoFormat(mimeType, width, height);
    setVideoFrameSize(width, height);
    setVideoCodec(mimeType);
}

I dont know reason of 1280*720 limitation, but it is OK when remove it.

I've changed this code at  org.m4m.android.graphics.EglUtil.java.
Just try it!
GLES20.glTexParameterf(textureType, GLES20.GL_TEXTURE_MIN_FILTER, GLES20.GL_NEAREST);
GLES20.glTexParameterf(textureType, GLES20.GL_TEXTURE_MAG_FILTER, GLES20.GL_LINEAR);
to
GLES20.glTexParameterf(textureType, GLES20.GL_TEXTURE_MIN_FILTER, GLES20.GL_LINEAR);
GLES20.glTexParameterf(textureType, GLES20.GL_TEXTURE_MAG_FILTER, GLES20.GL_NEAREST);


Forum forgets that one is logged in when clicking "updated topics"

This is now becoming ridiculous. I'm logged in on the main page, click updated topics and get redirected to the main page because the system thinks that I'm not logged. Login again (need to provide credentials), need to refresh page after that so I see updated topics, click it and the story repeats.
I never had too many problems with the logins and could live with it but this is totally ridiculous.
Firefox 84.0.2, Windows 10. I did clear cookies and restarted Firefox.
Android plus Chrome still seems to be OK.

I haven't experienced the issue for a number of hours now.
Not sure what changed.

I haven't experienced the issue for a number of hours now.
Not sure what changed.

Maybe it is CACHE related ?

Maybe it is CACHE related ?

It would be strange that it would automatically resolve itself if it was a cache issue. But I indeed did not clear the cache. Something to remember for the next time.

It would be strange that it would automatically resolve itself if it was a cache issue. But I indeed did not clear the cache. Something to remember for the next time.

Mosts OS and browsers have a set CACHE limit so occasionally they may clear on a FIFO basis.
Makes some issues a pita to chase unless you deliberately clear cache on a regular basis and on purpose as is the case here.

Ah, thanks

Thanks so much for the report @sterretjeToo!
Since you reported that the issue had resolved itself and there have been significant changes to the forum, I'm going to close this. Please feel free to comment here if the issue is still happening and I'll reopen.


Browsing MilkDrop presets

It is not clear how to navigate/change/upload MilkDrop presets from the GUI. I am trying the online version at https://webamp.org. Is that documented somewhere?

Not really. We've tried, where possible, to mimic the behavior of actual Winamp, and assumed that those who are looking for the feature would be familiar with the Winamp controls.
To quickly answer your question (for you) you can focus the Butterchurn window and press "L". From there arrow keys and enter are your friends. There are more controls too but, like you said, they are poorly documented.
Out of curiosity, where did you look when you were looking for documentation? Maybe that can help us understand where we should be putting these things.
FYI @jberg

Thank you for the information! I hardly remember the interlace for using Milkdrop in the past, so I did not know the shortcuts.
I've looked at

webamp README: no information, except "We intend to make this part of the public API soon"
the twitter thread mentioned therein ("Check out this Twitter thread for an illustrated list of features"): It does not mention MilkDrop
Github issues: here I found that indeed it is possible to navigate presets, but it is never mentioned how (I suppose everybody in the conversation know how to)
Finally, I went to winamp documentation. I did found some shortcuts ( not "L") that did not work, so I gave up.


Not Converting dynamic data

Hi , @Gkemon
First thanks to your work.
I can create pdf file using XML, But If add dynamic data to my layout views, it not reflect in pdf. Again it is showing static layouts data . data is came from previous activity using Intents.

Hi, @suryanadiminti99
Did you manage to solve this issue? I think I am facing something similar, I have a layout with DataBinding, I do inflate the layout, set the binding, but non of the binded texts appear in my pdf.

I'm facing same issue using RecyclerView, then i use LinearLayout and my data is printed to pdf output

Hi , everyone. First thanks for using my library. Here I illustrated how to print pdf for dynamic content ( For example - An invoice or Report) https://github.com/Gkemon/Android-XML-to-PDF-Generator#how-to-print-an-invoice-or-report- . If you anyone of you can't get this then knock me again. Thank you.
Tagging: @suryanadiminti99  @poetrasapoetra  @fazekasarn

Hi @suryanadiminti99 @poetrasapoetra @fazekasarn
Thank you all for the support. Please kindly star and fork and send me the app links you all are using it. If there is no confidentiality then I will list them in my readme.md file.

Hi, @Gkemon
Sorry for late reply and many thanks for your work. I used this library to make app named karst survey, but until now that app not yet finished (I don't know if it will be) because I no longer working on this app. This library is very helpful to make report like this.


[Feature Request] maximized != fullscreen, maximized = (fullscreen - taskbar height)?

Can there be an option that differentiate between "maximized window'" and "fullscreen", like on Windows? Apps tend to have buttons on the bottom that are blocked by Taskbar. The "hide taskbar" button feels like a band-aid solution to this for the time being.

@bearoxo It's not the feature that Taskbar can do. It's a feature that needs the Android variants you use to implement it because the title/caption bar of the window is implemented by Android OS.

maybe it'd make more sense to have it like the macos dock or windows "automatically hide the taskbar feature" on full screen, as in you'd have to move your cursor to the bottom of the screen to access it. altho this wouldn't be possible on touch surfaces, so idk if there's a solution there. either way it's better than the rather ugly arrow button we currently have.

(wait I completely misread the question sorry)


Followed up #6743

What was the end-user problem that led to this PR?
#6743 was failed with ruby core repository and ignored working example.
I fixed them.

@bundlerbot r+


Pattern-based topic names breaks Kafka healthchecks (KafkaBinderHealthIndicator.java)

The health checks fail in the KafkaBinderHealthIndicator.java because this topic name is not valid when using a pattern-based topic name (i.e. .*myDynamicTopicName).
error: "org.apache.kafka.common.errors.InvalidTopicException: Topic '.*myDynamicTopicName' is invalid"
This happens because we fetch partitionData from the kafka cluster for these dynamic topics and the Fetcher can't handle these patterns.
https://github.com/apache/kafka/blob/4f25f1fb7118825384f89ed9d00c08a54870e3aa/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java#L297

Thanks for reporting this.
We should either make the health-checks and the pattern based binding mutually exclusive or look into why the health-indicator is relying on the topic. It should only be looking to make sure the connection can be successfully established.

Maybe a combination of the two - if consumer property destinationIsPattern is true, just use the admin to check if the broker is accessible.

@ngbalk Did you try what @garyrussell suggested? Are there any further updates to this issue?

?
My comment was about the code changes we should make.

@garyrussell My bad. I misunderstood. Please ignore.
On Thu, Sep 20, 2018 at 11:54 AM Gary Russell<EMAIL_ADDRESS>wrote:

?
My comment was about the code changes we should make.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/430#issuecomment-423235244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyhIv4X0rsIg3aeId1lCY68KRiRP3IBks5uc7oxgaJpZM4WAlBT
.


Move Serialise* instances to the core library

There are dependencies / imports of Orphans () just for these instances. They may be removed as well.

Good point. I'm doing this in https://github.com/IntersectMBO/lsm-tree/pull/176/commits/252c6bc2c28ccb69da734a8750542ae4212b77e7


Fix: deploy command no longer ignores -f option (#7254)

Pull request opened by the merge tool on behalf of #7254

Merged into branches iso7 in c300316bb2ceade2d569acac1f085103c398cc39


Split the E2E tests into smoke/cassandra/es

Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

This change is

PR updated, @kevinearls would you please give it a quick look before I merge it?


gulp trust-dev-cert must be run from the project folder, otherwise you get an error

Category

[ ] Question
[ ] Typo
[ ] Bug
[x ] Additional article idea

Expected or Desired Behavior
Install and trust certificate
Observed Behavior
Error: "No gulpfile found"
Steps to Reproduce
Follow setup instructions and install the developer certificate without changing folders (no instructions to change folders in the article).  Going into a newly created project folder where you generated a new project using yo and running gulp trust-dev-cert returns a successful status.
Submission Guidelines

Hi @samboustani
It should be a easy fix, I presume you have navigated to wrong path.
You should use CD to navigate the specific project folder. Once you have navigated to correct project folder, you will find gulpfile.js if you use DIR to check your project folder
Than, you can install and trust certificate.


[Enhancement]: Fix broken dependency automatically when  reruning the pipeline.

Is there an existing issue for this?

[X] I have searched the existing issues

What would you like to be added?

Towhee version(e.g. v0.1.3 or 8b23a93): 0.4.0
OS(Ubuntu or CentOS): Ubuntu 18.04

It would be better if towhee can automatically repair broken dependencies when I re-run the pipeline.
When I first run
>>> eb_pipline = pipeline('image-embedding')
>>> output = eb_pipline('towhee.jpeg')

It starts to install the dependent python packages.
Unfortunately, the installation of torchvision(0.10.0) failed due to insufficient disk space.
After I cleaned up my disk space, I rerun the above command again, and the dependencies were not automatically repaired.
It prompts
>>> output = eb_pipline('towhee.jpeg')
2022-01-06 20:57:20,885 -<PHONE_NUMBER>31328 - thread_pool_task_executor.py-thread_pool_task_executor:77 - ERROR: Traceback (most recent call last):
  File "/home/czs/miniconda3/envs/towhee/lib/python3.8/site-packages/towhee/engine/thread_pool_task_executor.py", line 69, in execute
    op = self._op_pool.acquire_op(runner.hub_op_id,
  File "/home/czs/miniconda3/envs/towhee/lib/python3.8/site-packages/towhee/engine/operator_pool.py", line 105, in acquire_op
    op = self._op_loader.load_operator(hub_op_id, op_args)
  File "/home/czs/miniconda3/envs/towhee/lib/python3.8/site-packages/towhee/engine/operator_loader.py", line 82, in load_operator
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/czs/.towhee/operators/resnet_image_embedding&towhee$main/resnet_image_embedding.py", line 17, in <module>
    import torchvision
ModuleNotFoundError: No module named 'torchvision'

Why is this needed?
Can make the product easier to use
Anything else?
No response

This issue and several similar issues will be fixed once issue#431 is resolved, therefore closed and remain issue#431 only.


Fix for OnSuccessStepId in New-DbaAgentJobStep

Recent change broke the functionality of New-DbaAgentJobStep. When specifying "-OnSuccessAction GoToStep -OnSuccessStepId 2" it would fail and say: "Parameter OnSuccessStepId can only be used with OnSuccessAction 'GoToStep'."
The line used to say "$OnSuccessAction -ne 'GoToStep'" but now says "$OnSuccessAction -in 'GoToStep', 'GoToNextStep'". When you choose GoToNextStep it will work with a OnSuccessStepId specified but it won't actually use it.
I also updated some of the help info to match and set OnFailStepId = 0 to match how OnSucessStepId starts.

Type of Change

[x] Bug fix (non-breaking change, fixes #4312)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Fix #4312. Allow OnSuccessAction to use GoToStep again.
Approach
Revert to having a -ne comparison instead of -in.
Commands to test
New-DbaAgentJob -SqlInstance $myserver -Job "myTestJob"
New-DbaAgentJobStep -SqlInstance $myserver -Job "myTestJob" -StepId 1 -Subsystem TransactSql -StepName "myFirstStep" -Command "select 'oh, hello'" -OnSuccessAction GoToStep -OnSuccessStepId 2

ohh look at that, the tests are back 💯  should be soon.

test failures were on our part. fab job, thank you, @rickloveslamp /cc @sanderstad


Replace should to must for custom keyword error message?

Should we replace should to must for custom keyword error message to align with other validation error messages?
https://github.com/ajv-validator/ajv/blob/b5642ea8655c3922de7f2403cc99d668871d35fb/lib/compile/errors.ts#L9

yes - makes sense - thanks!


SPARKC-105: Fix setting custom connection factory which was blocked by t...

...he new configuration check system. Provided a way to set custom auth config and connection factory properties.

LGTM


STOR-1794: add location for azcopy logs

azcopy tool needs a writeable location for logs:
Before fix:
sh-5.1$ azcopy
2024/03/04 12:41:21 Problem making .azcopy directory. Try setting AZCOPY_LOG_LOCATION env variable. mkdir /.azcopy: permission denied
sh-5.1$ export AZCOPY_LOG_LOCATION=/tmp
sh-5.1$ azcopy
2024/03/04 12:41:34 Problem making .azcopy directory. Try setting AZCOPY_JOB_PLAN_LOCATION env variable. mkdir /.azcopy: permission denied
sh-5.1$ export AZCOPY_JOB_PLAN_LOCATION=/tmp
sh-5.1$ azcopy
AzCopy 10.22.1

After fix:
$ oc describe pvc/pvc-1-clone
Name:          pvc-1-clone
Namespace:     default
StorageClass:  azurefile-csi
Status:        Bound
Volume:        pvc-89a7a986-45e9-4357-a497-1a4fbd2dd229
Labels:        <none>
Annotations:   pv.kubernetes.io/bind-completed: yes
               pv.kubernetes.io/bound-by-controller: yes
               volume.beta.kubernetes.io/storage-provisioner: file.csi.azure.com
               volume.kubernetes.io/storage-provisioner: file.csi.azure.com
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      1Gi
Access Modes:  RWO
VolumeMode:    Filesystem
DataSource:
  APIGroup:
  Kind:      PersistentVolumeClaim
  Name:      pvc-1
Used By:     <none>
Events:
  Type    Reason                 Age                From                                                                                Message
  ----    ------                 ----               ----                                                                                -------
  Normal  Provisioning           36s                file.csi.azure.com_ci-ln-gq9mbdb-1d09d-xzg2r-master-0_5c14d541-1cc2-4733-afed-2db2cafab886  External provisioner is provisioning volume for claim "default/pvc-1-clone"
  Normal  ExternalProvisioning   35s (x2 over 36s)  persistentvolume-controller                                                                 Waiting for a volume to be created either by the external provisioner 'file.csi.azure.com' or manually by the system administrator. If volume creation is delayed, please verify that the provisioner is running and correctly registered.
  Normal  ProvisioningSucceeded  28s                file.csi.azure.com_ci-ln-gq9mbdb-1d09d-xzg2r-master-0_5c14d541-1cc2-4733-afed-2db2cafab886  Successfully provisioned volume pvc-89a7a986-45e9-4357-a497-1a4fbd2dd229

# cat /tmp/azcopy/5745cdd2-5add-5041-4b01-7de392942e6c.log
2024/03/04 12:28:13 AzcopyVersion  10.22.1
2024/03/04 12:28:13 OS-Environment  linux
2024/03/04 12:28:13 OS-Architecture  amd64
2024/03/04 12:28:13 Log times are in UTC. Local time is 4 Mar 2024 12:28:13
2024/03/04 12:28:13 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2024-03-04T12:28:08Z or --include-after=2024-03-04T12:28:08Z
2024/03/04 12:28:13 ==> REQUEST/RESPONSE (Try=1/28.00806ms, OpTime=66.817338ms) -- RESPONSE SUCCESSFULLY RECEIVED
   GET https://clusterxkbyc.file.core.windows.net/pvc-89a7a986-45e9-4357-a497-1a4fbd2dd229?restype=share&se=2024-03-05T12%3A28%3A08Z&sig=-REDACTED-&sp=rwl&spr=https&srt=sco&ss=f&st=2024-03-04T12%3A28%3A08Z&sv=2020-02-10
   X-Ms-Request-Id: [1fa3485e-301a-0005-222f-6e2341000000]

2024/03/04 12:28:13 Any empty folders will be processed, because source and destination both support folders
2024/03/04 12:28:13 Job-Command copy https://clusterxkbyc.file.core.windows.net/pvc-55255a01-b115-4084-b06e-9102e87a1580?se=2024-03-05t12%3A28%3A08z&sig=-REDACTED-&sp=rwl&spr=https&srt=sco&ss=f&st=2024-03-04t12%3A28%3A08z&sv=2020-02-10 https://clusterxkbyc.file.core.windows.net/pvc-89a7a986-45e9-4357-a497-1a4fbd2dd229?se=2024-03-05t12%3A28%3A08z&sig=-REDACTED-&sp=rwl&spr=https&srt=sco&ss=f&st=2024-03-04t12%3A28%3A08z&sv=2020-02-10 --recursive --check-length=false
2024/03/04 12:28:13 Number of CPUs: 8
2024/03/04 12:28:13 Max file buffer RAM 4.000 GB
2024/03/04 12:28:13 Max concurrent network operations:  will be dynamically tuned up to 3000 (Based on auto-tuning limit. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2024/03/04 12:28:13 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2024/03/04 12:28:13 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2024/03/04 12:28:13 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2024/03/04 12:28:13 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2024/03/04 12:28:13 Max open files when downloading: 1048047 (auto-computed)
2024/03/04 12:28:13 No transfers were scheduled.
2024/03/04 12:28:13 Final job part has been created
2024/03/04 12:28:13 Trying 4 concurrent connections (initial starting point)
2024/03/04 12:28:15 PERF: primary performance constraint is Unknown. States: W:  0, F:  0, S:  0, E:  0, T:  0, GRs:  4
2024/03/04 12:28:15 100.0 %, 0 Done, 0 Failed, 0 Pending, 0 Skipped, 0 Total,
2024/03/04 12:28:15

Diagnostic stats:
IOPS: 0
End-to-end ms per request: 0
Network Errors: 0.00%
Server Busy: 0.00%

Job 5745cdd2-5add-5041-4b01-7de392942e6c summary
Elapsed Time (Minutes): 0.0333
Number of File Transfers: 0
Number of Folder Property Transfers: 0
Number of Symlink Transfers: 0
Total Number of Transfers: 0
Number of File Transfers Completed: 0
Number of Folder Transfers Completed: 0
Number of File Transfers Failed: 0
Number of Folder Transfers Failed: 0
Number of File Transfers Skipped: 0
Number of Folder Transfers Skipped: 0
TotalBytesTransferred: 0
Final Job Status: Completed

2024/03/04 12:28:15 Closing Log

cc @openshift/storage

/retest

/test all

@RomanBednar you need to update csi-operator!

@jsafrane Moving there: https://github.com/openshift/csi-operator/pull/200


Fix overview not diplaying properly

closes #120  introduced in https://github.com/ChainSafe/Multix/pull/110

it happens, I should have checked more carefully. I did see the change, but didn't actually check the UI


Better monitoring for chunk state

As part of understanding & fixing #61 and making sure it doesn't happen again, we want to gather data on:

[ ] how big the backlog of flushes for chunks
[ ] (maybe) how many chunks there are in the system
[ ] how many chunks we're dropping

(maybe) how many chunks there are in the system

That's just cortex_ingester_memory_chunks.

how many chunks we're dropping

That's rate(cortex_ingester_chunk_store_failures_total[1m]). During normal operation, failed stores are simply retried infinitely, but during shutdown, it's a one-shot thing.

how big the backlog of flushes for chunks

Backlog can be inferred from the various metrics now.


Language (Translation) feature for the EM Framework

Hey guys,
So, I did it ... as briefly discussed with Mark over at the community site. I have added support for INI-Style language files for External Modules, similar to how REDCap core does it.
The implementation is totally transparant for existing modules. To use the new features, they have to opt. Strings ("name", "description" fields) can be translated without breaking backward compatibility. To use the language feature in module code (via a tt() function) will require the EM framework version 2 and REDCap >= where the language feature is implemented (so 9.0.1 the earliest ;).
How does it work?

Add a "lang" folder with translation files (such as English.ini) into the EM's folder
To translate config stuff, add "tt_name" or "tt_description" fields containing the key from the language file.
To translate text in module code, use the tt() function provided by the framework version 2 (I added a forwarding from AbstractExternalModule via __call). Call as tt($key) or tt($key, $value1, $value2, ...) or tt($key, $valueArray) to get string interpolation, e.g. when the text corresponding to the key is e.g. "{0} are {1}." and $values = array("Apples", "red") this will give "Apples are red.". tt($key) without values would just pass through the original string (nice when interpolation happens in the browser).

What is missing?

A corresponding JS function replicating tt for interpolation in the browser. I will work on this asap.

How does this look in a module?

Head over to the nedCAPTCHA external module and have a look, focus on the lang directory and on config.json. Use of tt() is made in NEDCaptchaExternalModule.php around line 600. Complete English and German translations are available (I should have picked another module to showcase this ... there was a LOT to translate).
Install it with the update EM framework to see it in action.

Let me know what you think!
Cheers,
GR

This looks fantastic.  Thanks very much for contributing this @grezniczek!  I have not had time to do any work on growing the framework for the past month, but am hoping to get caught up within the next couple of weeks and review this (really just for long term support concerns).

Hello @mmcev106, good to hear :)
I just did some more work towards localization of the EM Framework itself, i.e. extracting translateable strings. All PHP stuff is done. JS is still to do (need to get the JS-version of tt working -- also, probably need to think a bit more about sanitation and maybe revisit a few places).
But the strings are there, in English.ini, which ultimately should get merged with REDCaps main language file (for now, I am appending them to global $lang when the EM framework is initialized).
I will open up a new pull request from a different branch I created (probably should have done this from the start) - this will include all changes, so probably you can get just ignore this pull request (not a GitHub expert, but I am learning).
I also found a few minor bugs, one was an implode() with parameters reversed leading to only show first module author on the system manager.


change check for msg.channel

Changed check for msg.channel to this: isNaN(msg.channel)
Added isNaN check for program change message send
device was already being checked in this.run so extra device checks seemed unnecessary.(?)

Sorry I checked my messages after pushing X(


broken link

On the readme it says https://github.com/susam/emfy/raw/main/.emacs, but that returns a 404 error. Maybe github changed the url for the raw version of files? When clicking the 'raw' button for .emacs I get https://raw.githubusercontent.com/susam/emfy/main/.emacs.

The URL https://github.com/susam/emfy/raw/main/.emacs works fine for me both in web browsers (Firefox, Chrome, Safari) as well as via curl.
$ curl -sSI https://github.com/susam/emfy/raw/main/.emacs | grep -iE "http/|location:"
HTTP/2 302
location: https://raw.githubusercontent.com/susam/emfy/main/.emacs

$ curl -sSI https://raw.githubusercontent.com/susam/emfy/main/.emacs | head -n 1
HTTP/2 200

$ curl -sSIL https://raw.githubusercontent.com/susam/emfy/main/.emacs | head -n 1
HTTP/2 200

I don't see a 404 error in any case. Do you have a screenshot or terminal session output that would help me to see exactly what you see?

The url is no longer 404ing for me! I guess it was a problem on github's end.


Skins not coming up

I cannot get skins when I use the name < shark > My Name or < cougar >My Name.( without spaces in angular brackets) Also I Didn't understand how to add one . Can someone help me how to do that ?

Premium skins have been patched almost a year ago now. So skins using <> will not work anymore. Though, I wish they did.

@Agarian perfect timing lmao

Also, do you happen to know any clients that still use <> skins?

Yes I Know one, can I Drop links in here ?

https://www.youtube (dot) com/watch?v=_gdggDbxASo

aka https://www.youtube.com/watch?v=_gdggDbxASo

Dude it's already been established that premium skins got patched on agar.io
I'm looking for OTHER clients that still have premium skins. Note: <> skins = premium skins

Okay, thanks a lot, and can I get the older ogar version ( to play with skins ) which is not patched? I Had the ogar unlimited which dosen't works now.

Getting an older version will not help. Miniclip themselves patched the use of premium skins on agar.io

Ohkk. Thanks for helping , Agarian,,


BRTFS Snapshots

BRTFS snapshot to be allowed to rollback, or even using astOS to get immutability https://github.com/lambdanil/astOS

I wanted to switch to BTRFS but have discarded that.
On the one hand, because you have to use grub or refind and I just love systemdboot because of the simplicity and integration.
And on the other hand, because I would like to keep ArchOS as simple as possible (also with regard to rescue & recovery). In 5 years of daily use, my system has only crashed once after updating and I was able to repair it with just a few commands. That's why this is not planned for the time being.

Sounds interesting. I'll leave the ticket open. If I find the time, I'll take a look at it.


Is it possible the assembly to be strong-name/signed?

While looking into how to sign .net core assemblies, I found https://github.com/dotnet/docs/issues/22412 which relates to microsoft's assertion that strong-naming adds no benefit here based on that github issue, it looks like they are getting rid of strong-naming. As a result of this, I have no reason to sign this assembly. In fact, I have a reason not to do it. Do you want to provide some justification for why you'd like it strong named?

@CamW out of curiosity, what are the reasons that you have for not signing the assembly? I had the same dilemma before, and I ended up signing the assembly. From my perspective, the issue only comes when a signed assembly uses an unsigned assembly, as it might blow up. But, if your assembly has no references, or only uses signed assemblies, there's no real issue there.
Btw, .NET Core assemblies all have strong names now.

Reason not to: "For .NET Core and .NET 5+, strong-named assemblies do not provide material benefits. The runtime never validates the strong-name signature, nor does it use the strong-name for assembly binding." from here. Are you using .NET Framework and not Core?

I asked not because I use Noam but because I stumbled upon this issue from it being linked elsewhere. I just see that Npam targets .NET Standard, which makes it usable by .NET Framework-based software. I just shared my experience from a few years back when I decided to make the RestSharp assembly signed by default to avoid issues with references from signed assemblies on .NET FW.

Hi,
we are referring NPam from strong named assemblies in our ODOS framework (https://www.missionware.com/odos/). Because it is framework and comes from many years ago it can be used both in legacy and new .NET. Currently we have to sign it ourselves with a tool we have but it would be better if it was signed directly inside the nuget package.

We have signed the assembly and offer it here as nuget : https://www.nuget.org/packages/Missionware.ThirdParty.Npam
I can't find any reason not to sign such a package, even if typically is something from the past.
In case it is signed from you we will gladly unlist it.


Improve Growable by avoiding virtual function call.

I figured out that dyn growable runs by a slice iterator.
 let mut growable = growable::make_growable(&[lhs, rhs], false, lhs.len());
        let mut start_falsy = 0;
        let mut total_len = 0;
        for (start, len) in SlicesIterator::new(predicate.values())
  ...
}

what if we can put the iterator inside the growable trait?
 fn run(&mut self, iter: SlicesIterator  ) -> Box<dyn Array>;

Sounds like a great idea! I would call it extend_from_iter<I: Iterator<Item=(usize, usize, usize)> or something.


请问您试过在redhat6.7版本中编译tensorflow serving么？

Not really an issue of this project.
Close it now and feel free to contact in another way.


[WIP][SYSTEMML-1819] Added keras2caffe parsing python script and Keras2DML…

… skeleton code

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1936/

Thank you for working on this @FuturizeHandgun! Note that the keras2caffe.py file needs the Apache license added to the top of it (the build failed the apache-rat-plugin license check).

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1940/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1960/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1973/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1984/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1995/Failed Tests: 1SystemML-PullRequestBuilder/org.apache.systemml:systemml: 1org.apache.sysml.test.integration.functions.indexing.RightIndexingMatrixTest.testRightIndexingDenseCP

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2006/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2031/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2087/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2095/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2101/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/2105/

Thanks @dusenberrymw for giving me the opportunity to make something this cool!

Merged.  Thanks, @FuturizeHandgun!


INTMDB-144: deleted omitempty for scopes of database users

Description
Delete the omitempty for scopes parameter so it can send an empty array of scopes in json request.
Link to any related issue(s):
Type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[ ] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

Further comments

@marinsalinas with two approvals I merged but noted I didn't have a 2nd DoU review. Can you just double check this for us?  Thanks!


Reproducing Llama results from the paper

Hey there,
firstly, thanks for the nice work!
I am attempting to reproduce the results from the paper. I re-ran the experiments with 10 seeds (averaging the results). However, I am only reproducing the numbers for 5 of 7 of the tasks, which do not require an LLM judge.
My results are the following:

BioASQ
BioRED
DiscMT
EvInf
MultiCite
SciERC
SciFact
SciFact

F1
F1
BLEU
"Fuzzy" F1
F1
F1
F1-Label
F1-Token

Llama-3-8B-Inst. (original)
43.3
40.3
37.3
13.5
37.9
25.4
42.3
40.1

Llama-3-8B-Inst. (reproduced)
43.1 ± 1.5
40.1 ± 1.1
36.8 ± 2.6
15.2 ± 1.7
34.9 ± 8.2
13.2 ± 4.6
22.0 ± 7.7
20.6 ± 7.2

I am uncertain what the reason could be that the reproduced results for SciERC and SciFact are different compared to the original. Do you know what could be the cause of this?
There is a slight change in the --model_args due to memory issues. I added gpu_memory_utilization or max_model_len and removed tensor_parallel_size. I am running the following command:
python -m lm_eval \
  --include_path ./sciriff/eval/eleuther_templates/general \
  --model vllm \
  --model_args pretrained=meta-llama/Meta-Llama-3-8B-Instruct,dtype=float16,gpu_memory_utilization=0.85,max_model_len=5120 \
  --gen_kwargs max_gen_toks=1024 \
  --tasks bioasq_list_qa,biored_ner,discomat_te,evidence_inference,multicite_intent_classification,scierc_ner,scifact_entailment \
  --batch_size auto \
  --output_path results/ \
  --seed 42 \
  --predict_only \
  --log_samples

And I am using the following seeds: 42, 1337, 9876, 12345, 999999, 98765, 5555, 2024, 267, 10.
I am running experiments on a single RTX A6000 (48 GB) using CUDA 12.4, driver version 550.90.07, and Python 3.10.13 with the following versions of the packages:
huggingface-hub==0.24.5
jinja2==3.1.4
jsonschema==4.23.0
https://github.com/EleutherAI/lm-evaluation-harness.git@e74ec966556253fbe3d8ecba9de675c77c075bce
nltk==3.8.1
openai==1.37.2
pandas==2.2.2
pyyaml==6.0.1
rouge_score==0.1.2
spacy==3.7.5
vllm==0.5.4

Hi,
Thanks for reaching out.
Seems like you are not passing in a prompting template, which is essentially no template, and that could be a major reason for the discrepancy.
We provide an example template for Llama 3 series in the latest push so try again with --chat_template llama3 \

Hey,
thanks for your response.
As I understand it, the template is actually passed as an argument to the --include_path flag (see here). This is what my code above is passing directly to lm_eval.
Your recent update #3 is now adding the --apply_chat_template flag.

True, but I guess the real question I am asking is if the numbers in the preprint (https://arxiv.org/abs/2406.07835) used no template (i.e., general), as described in the README, or one specific for the underlying model. Do you know which is the case?

Thanks for pointing this out.
For your question, we did not use any template for Llama models in the preprint (which is not correct). Our results reported misaligned with yours because we did not set the EOS token correctly for non-tulu finetuned model, so the model would keep generating and repeat itself until hitting the max tokens. Sometimes the model generates a few versions of answer, which mistakenly push the score higher after parsing.
Your results without template are correct (I reproduced the same score w/o templates). The right way of doing these experiments is using templates.
Here are our new scores on Llama2-7B and Llama3-8B with corresponding templates for reference (Tulu models in the preprint are fine):

Task
bioasq
biored
discomat
evidence_inference
multicite
mup
qasper
qasper
scierc
scifact
scifact
Mean
Median

Metric
f1
f1
bleu
f1_overlap
f1
lm_judge_reference
lm_judge_answer
f1_evidence
f1
f1_label
f1_evidence_token

Llama-2-7b-chat-hf
34.48
19.78
35.57
13.32
27.27
77.25
7.94
2.29
6.88
50.41
31.68
27.90
27.27

Meta-Llama-3-8B-Instruct
44.28
47.06
59.47
0.15
50.08
85.50
55.14
41.19
28.76
68.36
53.36
48.49
50.08

This EOS issue won't happen in the recent push with new lm-eval dependency. In our latest version of the paper, we have already remade this table and will update our preprint soon.
Thanks again for pointing out. Let me know if you have further questions!