Update datalad_registry_client to remove DeprecationWarnings

There are numerous ``DeprecationWarningwhen running thetools/populate.pyscript, which is built on top ofdatalad_registry_client`.
❯ python tools/populate.py --start 60 --stop 65
/Users/isaac/.pyenv/versions/3.9.16/envs/datalad-registry/lib/python3.9/site-packages/boto/plugin.py:40: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
/Users/isaac/.pyenv/versions/3.9.16/envs/datalad-registry/lib/python3.9/site-packages/datalad_catalog/webcatalog.py:5: DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.
  from jsonschema import (
/Users/isaac/.pyenv/versions/3.9.16/envs/datalad-registry/lib/python3.9/site-packages/datalad_catalog/validate.py:18: DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.
  from jsonschema import (
/Users/isaac/.pyenv/versions/3.9.16/envs/datalad-registry/lib/python3.9/site-packages/datalad/interface/utils.py:223: DeprecationWarning: datalad.interface.utils.eval_results is obsolete. Use datalad.interface.base.eval_results instead
  warnings.warn("datalad.interface.utils.eval_results is obsolete. "
/Users/isaac/.pyenv/versions/3.9.16/envs/datalad-registry/lib/python3.9/site-packages/datalad/interface/utils.py:223: DeprecationWarning: datalad.interface.utils.eval_results is obsolete. Use datalad.interface.base.eval_results instead
  warnings.warn("datalad.interface.utils.eval_results is obsolete. "
Submitting 5 of the total 5112 active GitHub datasets to the datalad-registry.
registry-submit-urls(ok): [Registered https://github.com/NCCR-SYNAPSY/ds-NeuroDataPubOSFTest4.git]
registry-submit-urls(ok): [Registered https://github.com/NGenetzky/academic-oss-elc.git]
registry-submit-urls(ok): [Registered https://github.com/NGenetzky/balena-phusion.git]
registry-submit-urls(ok): [Registered https://github.com/NGenetzky/bitbake.bblayer.git]
registry-submit-urls(ok): [Registered https://github.com/NGenetzky/datasets.datalad.org.git]

Out of these five ``DeprecationWarnings, four of the them occurred when just import datalad.api as dlwith the working directory set to the repo directory ofdatalad-registrywhich contains thedatalad_registry_client` source.
>>> import datalad.api as dl
/Users/isaac/.pyenv/versions/datalad-registry/lib/python3.9/site-packages/datalad_catalog/webcatalog.py:5: DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.
  from jsonschema import (
/Users/isaac/.pyenv/versions/datalad-registry/lib/python3.9/site-packages/datalad_catalog/validate.py:18: DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.
  from jsonschema import (
/Users/isaac/.pyenv/versions/datalad-registry/lib/python3.9/site-packages/datalad/interface/utils.py:223: DeprecationWarning: datalad.interface.utils.eval_results is obsolete. Use datalad.interface.base.eval_results instead
  warnings.warn("datalad.interface.utils.eval_results is obsolete. "
/Users/isaac/.pyenv/versions/datalad-registry/lib/python3.9/site-packages/datalad/interface/utils.py:223: DeprecationWarning: datalad.interface.utils.eval_results is obsolete. Use datalad.interface.base.eval_results instead
  warnings.warn("datalad.interface.utils.eval_results is obsolete. "
>>>

import datalad.api as dl did not produce any warning when the working directory is set outside of the repo directory of datalad-registry.

It seems that these warnings only show up "because of" some imports from the datatad_registry package when writing or using a Datalad extension as illustrated below.
https://github.com/datalad/datalad-registry/blob/32cf5b55832d761c7af18f3a1cb34088f15371c0/datalad_registry_client/get_urls.py#L67
https://github.com/datalad/datalad-registry/blob/32cf5b55832d761c7af18f3a1cb34088f15371c0/tools/populate.py#L12-L16
@yarikoptic Any idea?

Never mind, the warnings are not related to Datalad extensions. They can be recreated just by running the above import statements in a new Python console.

just address the ones appearing from datalad-registry (imp) and possibly file issues in datalad-catalog but do not spend much tim one this please.


Web canvas breaks down when bigger than the device/browser max size

when the canvas dimensions are set to larger than supported by the device/browser, various bad things happen
set the width / height to something large such as 3840x2160
either the browser can fall over, clip any drawing outside its max dimension, scale the canvas to fit given dimension or other weird stuff such as in this screen shot from a 4K monitor
 the scrolbar is placed incorrectly and when the flags are scrolled the viewport changes position rather than the flags
this is more of an issue with 4K HD monitors but possibly also for high pixel density devices
this will not be a straight forward fix as canvas vendors (browsers) do not expose the limits at runtime
here's some reference materials
Spec: 2.2 & 2.3
Docs: Maximum canvas size
Stackoverflow: Maximum size of a  element
GitHub: canvas-size

the screenshot above may be misleading and due to "There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings" - will update further on investigation

the bug reported was actually caused by a temporary local setup issue
whilst the issue with web canvas having a maximum size and openstrat not having a way to negotiate this is still theoretically possible - im closing this issue until it can be reproduced


Cherry-pick: fix Jenkins testing 1.3.x

I missed a few commits in my last cherry-pick to fix Jenkins testing v1.3.x
CC @apolcyn

Performance differences noted:
Benchmark                                        cpu_time    real_time
---------------------------------------------  ----------  -----------
BM_ErrorCreateAndSetIntAndStr                      +43.50       +43.50
BM_ErrorCreateAndSetStatus                         +41.50       +41.50
BM_HpackEncoderInitDestroy                        +220.50      +220.50
BM_IsolatedFilter<ServerDeadlineFilter, NoOp>       +7.00        +7.00
BM_SliceReIntern                                    -9.00        -9.00

Tests look like they're running properly.


Implement two missing tests in sequencer-client -> l1-publisher.test.ts

There are two empty tests named:

'waits for fee distributor balance'
'fails if contract is changed underfoot'

This task simply consists in implementing them.
Those tests are related to the following TODOs:
https://github.com/AztecProtocol/aztec-packages/blob/c5f734a68e2f727a631a4d4e6f5d9681fb9ca28f/yarn-project/sequencer-client/src/publisher/l1-publisher.ts#L193
https://github.com/AztecProtocol/aztec-packages/blob/c5f734a68e2f727a631a4d4e6f5d9681fb9ca28f/yarn-project/sequencer-client/src/publisher/l1-publisher.ts#L199

I'm simply going to remove these tests. I think they probably came over with the code ported from AC.


segwit v1 test

Pieter Wuille posted a segwit v1 address here https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2020-October/018254.html and I added a parsing test.
The attached test fails on the script which I am not sure but I would expect should start with 01 (version 1) but it starts with 51 (OP_PUSHNUM_1)
here is a mainnet tx done with aqua wallet, which is based on rust-bitcoin
https://blockstream.info/tx/b48a59fa9e036e997ba733904f631b1a64f5274be646698e49fd542141ca9404?expand

Now I read the comment:
 // Since we passed the [is_witness_program] check,
// the first byte is either 0x00 or 0x50 + version.

So everything should be ok (and anyway 0x51 is in the source address)

Please test using the BIP173 test vectors. They cover this.

BIP173 test vectors are already there https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/address.rs#L653
sorry for the mess


Missing angles.min.js in the bower package

There is no min file in the bower package. It would be nice to have.

@gonewandering if you dont want to check-in the .min.js file maybe you could use
https://github.com/blog/1547-release-your-software
And Bower will take care of that for you.
https://github.com/bower/bower/issues/584
Thanks for this lib !!!!

related with #72

this is no longer relevant


split/tab mappings

The issue https://github.com/ThePrimeagen/harpoon/issues/381 was closed but it doesn't seem to be addressed. There was a comment about a PR that had just been closed but there was no link so I couldn't see what was meant. Maybe it is fixed but not anywhere I can see. Since I can't reopen it I'll make a new issue here.
Harpoon would not be useful to me without the ability to open files in (v)splits and tabs. If there is a way to configure keymaps through options then that would need to be documented somewhere.

I haven't documented it but feel free to look at the code, it's quite simple.
config.lua (on phone, not easy to get links)
You will see a option bag passed into select
Select is called from the list
Pass an option into the list method select
I'll get on documentation at some point.

Rockin!

@ThePrimeagen This is closed in error. Just to be clear, the goal here is to set keymaps such that opening in (v)split or tab can be set by whatever key you like. Right now forcing config.lua:116 to run 'vim.cmd("vsplit")' does nuffink! Pressing Ctrl+v in a harpoon list tries to set a visual block. Attempts to set options have failed to show in the logger output. Doesn't seem simple to me!

@ThePrimeagen This is closed in error. Just to be clear, the goal here is to set keymaps such that opening in (v)split or tab can be set by whatever key you like. Right now forcing config.lua:116 to run 'vim.cmd("vsplit")' does nuffink! Pressing Ctrl+v in a harpoon list tries to set a visual block. Attempts to set options have failed to show in the logger output. Doesn't seem simple to me!

The issue is fixed by #399, which was also closed in error. The menu needs to be closed before the list's select method is called.

Wait.. I'll look into this. My bad, my bad
Let me review this because I am skeptical that order should matter like this.  Must be another issue

I put together a working pr here - https://github.com/ThePrimeagen/harpoon/pull/430

Wait.. I'll look into this. My bad, my bad
Let me review this because I am skeptical that order should matter like this. Must be another issue

@ThePrimeagen I have done a little debugging and the underlying issue is caused by the BufLeave autocmd. Order definitely matters when it comes to autocmd trickery.
When you call vsplit a new split window is created with the current buffer (the menu buffer). When you call nvim_set_current_buf the BufLeave autocmd is executed, the menu is closed, and nvim_buf_delete is called before the new buffer is set in the window. nvim_buf_delete closes the windows containing deleted buffers, meaning that the window is closed before it ever contains the new buffer.
No split appears to be created, even though one was created for maybe a few milliseconds, because the splits are always closed immediately by nvim_buf_delete.
The options, as far as I can tell, are:

This fix
vim.schedule_wrap the BufLeave autocmd callback to ensure the menu is only closed after select_menu_item is executed.


TS doesn't check the implementation of the overloaded function whether match its signature.

TypeScript Version:  2.5.2
Code
TS only check the function signature whether is compatible with that overloaded function's signature. If not, TS report Overload signature is not compatible with function implementation.. It actually doesn't check the function's implementation, only the signature's compatibility. In the example below:
class Animal { }
class Dog extends Animal { }

function test(d: Dog): string
function test(d: Animal): number
function test(d: Animal | Dog): number | string {
    if (d instanceof Dog) {
        return 42
    } else {
        return '苟'
    }
}

If we call test as:
const o = test(new Dog())

o is inferred as the string type, but actually, it's number type, eventually, cause the runtime error.
Expected behavior:
Report the first and second test function doesn't be implemented. The third test function signature pass. TS should be able to check the implementation with these signatures which are overloaded, we have done the type narrowing.
Actual behavior:
no errors

The check is only to ensure that the signatures are sufficiently compatible. The overloads are a promise you're making to API consumers, while TypeScript allows you to be as flexible as possible to fulfill each of those signatures in the implementation.
Unfortunately we don't really have any simple ideas about how to perform this check efficiently.

how to perform this check efficiently

In case OP wonder why the check is prohibitively expensive:
It's TypeScript's design limitation. TS has a structural typing system, that is, the assignability between two types relies solely on their property types. (e.g. your example function test isn't "correct" because Dog and Animal has the same shape). No shortcut can be used during checking.
In order to check if a branch return value is compatible to the signature, the compiler will have to check all signatures from top to bottom until one signature matches. The complexity is about O(mn) where m is the number of branches and n is the number of signatures. For nontrivial overload functions, this complexity will easily trigger out of memory error or too time consuming.

@HerringtonDarkholme What if adding some annotations which are required on branches? We manually tell TS this branch match which signature.  Inside the function, TS just check the narrowed type and return type. Outside, TS check if all the signature functions have their annotations in the function implementation?

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

Is there any plan for breaking this limitation?


done with Display Current Player in Tic-Tac-Toe Game

Tic-Tac-Toe Game
Description
Enhanced the Tic-Tac-Toe game by adding a feature to display the current player's turn.
Changes Made:

HTML Update: Added a <div id="currentPlayer"> to show the current player's turn.
JavaScript Logic:

Implemented updateCurrentPlayerDisplay() to update the displayed player.
Called this function during board initialization and after each move.
Ensured the display resets to Player X when restarting the game.

Nice work.

mention this PR in the issue.


[Bug]: deploy Phi-3-mini-128k-instruct AssertionError

Your current environment
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A
OS: Ubuntu 22.04.1 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.29.0
Libc version: glibc-2.35
Python version: 3.11.8 (main, Feb 26 2024, 21:39:34) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-6.2.0-39-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.1.66
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 4090
GPU 1: NVIDIA GeForce RTX 4090
Nvidia driver version: 530.30.02
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.4
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.4
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             32
On-line CPU(s) list:                0-31
Vendor ID:                          GenuineIntel
Model name:                         13th Gen Intel(R) Core(TM) i9-13900K
CPU family:                         6
Model:                              183
Thread(s) per core:                 2
Core(s) per socket:                 24
Socket(s):                          1
Stepping:                           1
CPU max MHz:                        5800.0000
CPU min MHz:                        800.0000
BogoMIPS:                           5990.40
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1 xsaves split_lock_detect avx_vnni dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req hfi umip pku ospke waitpkg gfni vaes vpclmulqdq tme rdpid movdiri movdir64b fsrm md_clear serialize pconfig arch_lbr ibt flush_l1d arch_capabilities
Virtualization:                     VT-x
L1d cache:                          896 KiB (24 instances)
L1i cache:                          1.3 MiB (24 instances)
L2 cache:                           32 MiB (12 instances)
L3 cache:                           36 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-31
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] torch==2.3.0
[pip3] triton==2.3.0
[pip3] vllm-nccl-cu12==<IP_ADDRESS>.1.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] torch                     2.3.0                    pypi_0    pypi
[conda] triton                    2.3.0                    pypi_0    pypi
[conda] vllm-nccl-cu12            <IP_ADDRESS>.1.0             pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.2
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    CPU Affinity    NUMA Affinity
GPU0     X      PHB     0-31            N/A
GPU1    PHB      X      0-31            N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
🐛 Describe the bug
python -m vllm.entrypoints.openai.api_server --port 8681 --served-model-name chatglm3-6b-32k --model /home/hua-project/models/microsoft_phi3/LLM-Research/Phi-3-mini-128k-instruct --gpu-memory-utilization 0.4 --trust-remote-code

Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/home/hua-project/vllm/vllm/entrypoints/openai/api_server.py", line 184, in
engine = AsyncLLMEngine.from_engine_args(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hua-project/vllm/vllm/engine/async_llm_engine.py", line 350, in from_engine_args
engine_config = engine_args.create_engine_config()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hua-project/vllm/vllm/engine/arg_utils.py", line 528, in create_engine_config
model_config = ModelConfig(
^^^^^^^^^^^^
File "/home/hua-project/vllm/vllm/config.py", line 125, in init
self.max_model_len = _get_and_verify_max_len(self.hf_text_config,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/hua-project/vllm/vllm/config.py", line 1163, in _get_and_verify_max_len
assert "factor" in rope_scaling
^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Phi-3 support is already in main branch, maybe it's not in the pip package yet so I think you should build it from source

I tried it again using the following method and it was the same problem

I tried it again using the following method and it was the same problem

+1, it seems the issue was fixed in 4323 however reappear.

Phi-3 support is already in main branch, maybe it's not in the pip package yet so I think you should build it from source

Phi-3-mini-4k-instruct can work normally, but Phi-3-mini-128k-instruct can't. Can you confirm it again？

+1

For me, it appears to be working fine in the model commit bb5bf but is broken in the latest model commit d548c

+1

Still happening on 0.5.1

Is this issue fixed in the current version of vLLM?

Closing as fixed by #9250


fix: apply keepalive config to h2c entrypoints

What does this PR do?
Moves the keepalive middleware before the H2C handler so that in H2C traffic scenarios, where HTTP requests are hijacked by the H2C handler, they can still be processed by the keepalive middleware.
Motivation
While H2C is not generally recommended, there are scenarios where H2C setup is needed, such as for prototyping or for communications between non-critical internal services. During testing, we observed that the keepalive middleware for entrypoints behaves differently with H2C traffic.
In the current setup, the order of handler application is keepalive -> H2C. However, in H2C scenarios, subsequent requests are hijacked by the H2C handler, which changes the processing order to start with the H2C handler. This prevents the keepalive middleware from processing the request.
Reordering to H2C -> keepalive ensures that the keepalive configuration is consistently applied, even in H2C traffic scenarios
More

[x] Added/updated tests
[ ] Added/updated documentation

Additional Notes

This looks like a bug fix but since so few people using H2C so I treat it as a enhancement after thought.

Hello @davefu113 and thanks for your contribution,
As this pull request is a fix, could you please rebase it on branch v2.11?

Hello @davefu113 and thanks for your contribution,
As this pull request is a fix, could you please rebase it on branch v2.11?

@kevinpollet Apologies, I accidentally closed this PR while attempting to rebase it onto v2.11. I have submitted a new PR here. Please take a look, thank you.


[Enhancement] - Notification Row Animations

What

When the notification row is clicked the notification button will do a bounce animation.

Why

Because it's cool and Danny designed it!

See

 Notification buttons and animations ANDROID

@eoji I see what you're saying, I did pair with @dannyalright on it and he said it was good to go but we could give it another look to see if we should fix it.

@Rcureton @eoji I must have missed that when we paired! Would be great if it gets fixed (i.e. does not get clipped) before going public

Cool. @Rcureton code looks great! (I have to figure out how to approve) @dannyalright, I worked on this screen initially, so I can take a look and open a separate PR!


OriginalNameProperty Purpose?

What exactly does OriginalNameProperty do? I set it to another StringField and I still don't get the file name of the file I am trying to upload. I need to save the original file name for audit reasons.

see here https://github.com/volkanceylan/Serenity/issues/1005

Thanks but that didn't work. I have a strigfield in my row named uploadname I set OriginalNameProperty='uploadname' in the attribute where the FileUploader is. Do you have an example? Thanks

That's case sensitive.


make signing agnostic of key tweaking

i found that the signing protocol can be made agnostic to key tweaking.
basically, one can prepare the key share and public key ahead of time, and then run the same protocol as without tweaking.
i think this would simplify the code a bit. if there is interest, i can give it a shot and create a pr with the relevant changes. wanted to check here first, if this is desired / what others think.

Hi @matthiasgeihs, can you go a little bit more into detail how that'd look like and what the trade-offs are API-wise?

Hi @matthiasgeihs, can you go a little bit more into detail how that'd look like and what the trade-offs are API-wise?
EDIT: you may want to bring up the idea in the FROST-signing draft BIP

see here: https://github.com/jesseposner/FROST-BIP340/compare/main...matthiasgeihs:FROST-BIP340:feat/pre-tweak
this shows that the aggregator can be made agnostic of key tweaking (if i'm not mistaken)


2021.3.x fix recordlist configuration after yaml import

When using a recordlist, the selected fields in FieldPicker.vue is an array of object.

But when a page that contain a recordlist is exported (with server export), and then imported from yaml provision,
this.fields (used in selectedFields computed)is an array of string instead of a an array of object

FieldPicker don't handle it and don't display the selected columns
To fix it, we can use field (that contain the name when the page is imported) when field.name is undefined
The same goes for availableFields otherwise the Columns available will also contain the selected fields

@SGG-ThibautDepond thanks a mil for the contribution!
@tjerman please review this PR.

@SGG-ThibautDepond @zmija this is an issue with the exporting logic which is now resolved with https://github.com/cortezaproject/corteza-server/commit/3eaa56f3132fa58c81268195818b54738fa4008a (will be in the .3.13 patch release).
Closing the PR as this case should not occur in the future. Let us know if you need a hand with fixing the selection, but a simple re-selection of the fields should do the trick.


[5.0] [Serialization] Use full target architectures for swiftmodule files

Explanation: Swiftmodules in frameworks are stored under the name of their "major architecture" (the name used by #if arch(…)), but that creates complications for platforms that have more than one architecture variant per major architecture, like armv7 and armv7s, even if the content is "the same".

Scope: In practice, only affects how the compiler imports frameworks, which only Xcode builds.

Issue: rdar://problem/45174692

Risk: Low. This change is backwards-compatible for all shipping Apple platforms, and non-Apple platforms don't use multi-architecture Swift modules.

Testing: Passed regression tests and the source compat suite.

Reviewed by: @rjmccall, @jakepetroules

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 8b3b79c597e6ce8172a677a003e047a3a021b69a

*sigh* Resolved the master/5.0 differences wrong.
@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 8b3b79c597e6ce8172a677a003e047a3a021b69a

Build failed
Swift Test OS X Platform
Git Sha - 8b3b79c597e6ce8172a677a003e047a3a021b69a

Source compat failures are UPASSs; what's more, they're UPASSs in SwiftPM projects, which are not affected by this.


⚠ SkipTheCommericals has degraded performance

In 1b182be, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 4032 ms

Resolved: SkipTheCommericals performance has improved in 30b5cfa.


Clear button don't work

Desktop tabby don't work clear button.

What clear button exactly? Lesson or task? You have to press and hold both button to delete.

What clear button exactly? Lesson or task? You have to press and hold both button to delete.

 Work perfectly!


✨ ABC Provider

Description
This PR prepares the camply code-base for easier implementations of new providers. In particular, #208 is coming :tada:
This PR also implements fake-useragent as part of that - so this PR partially fixes https://github.com/juftin/camply/issues/178.
The use of ratelimit partially closes https://github.com/juftin/camply/issues/191
This code change will lead to a more concise diff on #208
Has This Been Tested?
Yes.
Checklist:

[x] I've read the contributing guidelines of this project
[x] I've installed and used .pre_commit on all my code
[x] I have documented my code, particularly in hard-to-understand areas
[x] I have made any necessary corresponding changes to the documentation

:tada: This PR is included in version 0.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setting for transfer learning

Hi, I have a question.
In train_transfer_learning.sh, I used RN50X4, COCO. But I had 4 gpu, so I changed num-gpus to 4 and changed IMS_PER_BATCH to 4. Then, the score written in the paper does not come out. In this case, what part should I change to get the score written in the paper?

@th0214 What score did you get after finetuning? If you decrease batch size to half, then you need to decrease learning rate to half accordingly.

I got a score like
[11/24 14:36:18] d2.evaluation.coco_evaluation INFO: AP50_split_target AP: 0.3522030598755359
[11/24 14:36:18] d2.evaluation.coco_evaluation INFO: AP50_split_base AP: 0.5863819732395625
[11/24 14:36:18] d2.evaluation.coco_evaluation INFO: AP50_split_all AP: 0.5251351805135863

@th0214 Did you follow the suggestions above to re-train the model? The maximum iteration & steps when learning rate decreases are important in your case.


locale switching does not trigger rerender

hello and thank you for your package!
we use it since first releases and happy now with removing state from provider and new ref implementation. bug with stale dict affected us too.
for now we noticed one more bug and it looks like it is connected with refs implementation.
the t function from useI18n hook is not changing when locale is switched.
so if we have something like:
const navigationItems = useMemo(
  () =>
    navigation.map(({ name, url }) => (
      <Link
        href={url}
        key={name}
      >
        {t(name)}
      </Link>
    )),
  [navigation, asPath, t]
)

return {navigationItems}

and then if we switch locale - the hook is not rerunning and page is not rerendered. workaround here is explicitly add locale from router to useMemo deps array:
const {locale} = useRouter()

const navigationItems = useMemo(
  () =>
    navigation.map(({ name, url }) => (
      <Link
        href={url}
        key={name}
      >
        {t(name)}
      </Link>
    )),
  [navigation, asPath, t, locale]
)

return {navigationItems}

but this workaround causes eslint-react-hooks error since locale is not used inside hook but still present in its deps array. it looks like t function should change in locale change.
in examples below assuming that navigation is something like:
const navigation = [
  {
    name: 'navigation.foo',
    url: '/foo'
  },
  {
    name: 'navigation.bar',
    url: '/bar'
  },
]

and our locale is:
const locale = {
  navigation: {
    foo: 'Foo Page',
    bar: 'Bar Page'
  }
}

Hi @asyncink
Looks like a valid reason to revert https://github.com/useflyyer/next-rosetta/pull/25
In the meantime you can go back to version ^1.0.0 where t changes when locale changes.

Hi @lopezjurip
Thank you for your reply!
I think that implementation with refs is quite good since it fixes bug with stale dict during next  transitions.
Unfortunately I have no time right now to figure out how to fix t func in next-rosetta codebase, but I will try later!
It looks like we should add locale to deps somewhere inside provider/hook and then return new t every time locale changes.


System status

Add an indicator that displays whether the backend is alive/down.

Note: requires implementation for the root'n'roll platform.


Add k8s events support

ecc4be572f4e3e7cfdfe45f34552135483f89587 - add support for k8s events
1793de2c34a970c8d3f7cc3673381418ac47d430 - vendor package github.com/golang/groupcache/lru

it compiles now, but I have not tested the code.

I think I want to wait until #188 is merged, so that the newer v1 Event API can be used instead of v1beta1.

This looks good to me, and I've updated #188 which can hopefully merge soon

@seanmalloy #188 has merged now, so you should be able to use the new event api

/assign @damemi
I updated the code to use the v1 Event API. I believe this PR is ready for review now. I have successfully tested this code against OpenShift v3.11 to confirm that k8s events are successfully created. See below screenshot from the OpenShift web UI that shows the successfully created events.

IMPORTANT NOTE: I was not able to successfully add a new package to the vendor directory using glide. See the commit message for commit 1793de2 for additional details. @mcandre and I tried several different glide commands, but every attempt resulted in a compile error. See also #198.

@seanmalloy thanks, I'll review this but it's interesting that glide wouldn't add that dependency for you, I would think that glide up should do it. I do see that that is the first commit though, which could be the problem. Glide looks for dependencies in the code to automatically add them, so I'm not sure how to manually add one without the code being there. I would recommend trying to reset your 2 commits, cherry-pick the actual change, then run glide up -v

@seanmalloy have you had a chance to try what I suggested? Your PR looks good but we shouldn't attempt to manually add dependencies to the vendor directory. I've tried the following commands locally on your branch which compiled for me, if you run them and push back to your branch it should be in an approve-able state:
$ git reset --hard HEAD~2
$ git cherry-pick ecc4be572f4e3e7cfdfe45f34552135483f89587
$ glide up -v
$ git commit.....(add your commit message)

/hold
for dep update

@damemi I was able to update the dependencies in the vendor directory using your instructions. Thanks for the help!
e3d06d154140010b8473bead940669e874facdc4 - code changes to add event support
6654aeff997a428ea6b6fb583bf3aa255ab3e4d9 - vendor dependency updates using "glide up -v"
I confirmed that the code compiles, and also ran the descheduler against an OpenShift v3.11 cluster. Everything is working fine from my perspective.
Let me know if any additional changes are needed.

@seanmalloy thanks for the update, glad I could help. Will need someone to approve this but I can lgtm
/lgtm

/hold cancel

/approve


Remove basic-auth-file it is deprecated

We should remove the basic-auth-file argument and move any entries to the tokens file.

@ktsakalozos I believe this is good issue to start with for beginner like me. Do you mind if I take this issue ?

Thank you for volunteering @vbmade2000. Yes, it is a good first issue to get you familiar with the code. Here are some notes you might find helpful.

In https://github.com/ubuntu/microk8s/tree/master/microk8s-resources/default-args we keep the default arguments that are copied under /var/snap/microk8s/current/args upon installation. You should remove the basic-auth-file entry (https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/default-args/kube-apiserver#L4) from there.
The password created in the install script  (https://github.com/ubuntu/microk8s/blob/master/snap/hooks/install#L24) should be added as a token to the known_tokens file as we do for example for the controller (https://github.com/ubuntu/microk8s/blob/master/snap/hooks/install#L47).

Do not hesitate to reach out in case you need help.
Many thanks.

Sounds good. Thanks.
Will check and reach out to you in case of query.

@ktsakalozos Can you please point me to the architectural docs for microk8s ? I checked https://microk8s.io/docs/ but looks like it shows usage mostly. I want to understand how it sets up a single node k8s cluster.

@ktsakalozos Can you point me to the architectural documents for microk8s if any ?

@vbmade2000 there is no architectural doc. To understand how we setup a cluster, fist look at the basics of snaps [1] (MicroK8s is a snap package). Then read through the daemons and commands defined in spancraft.yaml [2]. The commands and daemons are wrappers [3] around the (k8s) binaries we package.
The single node cluster is straight forward as the daemons start with the default arguments [4] and the certificates generated during installation [5, 6]. The case of forming a cluster is a bit more involving so a few python scripts are used [7].
You are however on point, we need to put more time and effort on the dev docs.
[1] https://tutorials.ubuntu.com/tutorial/create-your-first-snap#0
[2] https://github.com/ubuntu/microk8s/blob/master/snapcraft.yaml#L19
[3] https://github.com/ubuntu/microk8s/tree/master/microk8s-resources/wrappers
[4] https://github.com/ubuntu/microk8s/tree/master/microk8s-resources/default-args
[5] https://github.com/ubuntu/microk8s/blob/master/snap/hooks/install
[6] https://github.com/ubuntu/microk8s/blob/master/snap/hooks/configure
[7] https://github.com/ubuntu/microk8s/tree/master/scripts/cluster


Python wheel does not get updated on a Databricks cluster

When working in a persistent environment, sometimes building a new Python wheel and updating it in DBFS does not result in the new library getting picked up on Databricks cluster if the cluster is already running.
This seems to be a result of caching that occurs on Databricks cluster.
Known mitigation is to terminate the cluster and restart the data pipeline job.
Another known mitigation is to increase the version number in the python toml file.
I think tainting the Databricks cluster terraform resource each time we deploy a pipeline should work as a fix.

@tanya-borisova to add notes.

I have tried to taint a resource in Terraform so that the cluster gets recreated by Terraform each time, but this didn't work - the old version of the code was still sometimes getting picked up by Terraform.
I think the only way to properly fix this is to ensure that each new version of the library has a different name. For example, we could implement the versioning proposal (https://github.com/UCLH-Foundry/FlowEHR-Data-Forge/issues/31), or a simpler version of it, when we always add a hash the path of any wheel uploaded to DBFS, and then check that it doesn't exist already before uploading.

if the library had a different name, does that get picked up by the running cluster without needing to restart / destroy it?

Yes, it does. Same with setting a different semantic version of the library in toml file, this also works.

that sounds good then - definitely want to avoid restarting  / rebuilding the cluster so that's good news. could using the name / toml version to indicate a change of code also mitigate #261 , rather than using the md5 hash?

Terraform uses md5 internally to see whether a file has changed, and this behaviour cannot be modified by the user.
What specifically in #261 you feel needs to be mitigated?

yea this sounds a good idea, and mitigates both issues then, nice!

@tanya-borisova did this get fixed? I can't remember

No, this one isn't fixed unfortunately. I wanted to implement the versioning proposal for this, and suffix each new wheel with a version number, but it didn't get implemented.


backdrop-filter can't discern

VSCode Version:1.12.2
OS Version:win10
vscode show [css] Unknown property.
Steps to Reproduce:

1.Just type it in a css file

backdrop-filter is still an experimental feature.
You might want to change "css.lint.unknownProperties" to "ignore",


Values after attr_accessor return guards should not be considered nil

Input
→ View on sorbet.run
# typed: true
class Book
  extend T::Sig

  sig { params(price: T.nilable(Integer)).void }
  def initialize(price: nil)
    @price = price
  end

  sig { returns(T.nilable(Integer)) }
  def total_cost
    return unless price

    price + 30 # <- Method + does not exist on NilClass
  end

  sig { returns(T.nilable(Integer)) }
  attr_reader :price
end

Book.new(price: 30).total_cost

Observed output
Method + does not exist on NilClass component of T.nilable(Integer)

Expected behavior
I believe the compiler should report no errors.
Current fix
→ View on sorbet.run
# typed: true
class Book
  extend T::Sig

  sig { params(price: T.nilable(Integer)).void }
  def initialize(price: nil)
    @price = price
  end

  sig { returns(T.nilable(Integer)) }
  def total_cost
    tmp_variable = price
    return if tmp_variable.nil?

    tmp_variable + 30 # no errors
  end

  sig { returns(T.nilable(Integer)) }
  attr_reader :price
end

Book.new(price: 30).total_cost

Methods defined like with attr_accessor are no different to the type system than any other methood. There's more on this at https://sorbet.org/docs/why-nil . In particular, this is working as expected.


TOO Map: Make regions, wires, lyphs and other objects easier to select

@jrmartin @vidhya-metacell if you import this super simple model I was able to create to replicate the issue, you will see that
{   "id"  : "jointTreesAtSoma",   "name": "Omega trees joint at Soma",   "description": "Demo model with two generated omega trees connected to a common lyph",   "author": "Natallia Kokash",   "nodes": [     {       "id": "n1"     },     {       "id": "n2"     }   ] }
As you can see in the video the raytracing returns an array everytime the mouse is hovered in any of the two objects, so it's not a selection issue what's taking place but a object indentification issue within the ray traced objects, this is IMO the part that fails:
https://github.com/MetaCell/open-physiology-viewer/blob/master/src/components/webGLScene.js#L550
according to the intersectObject documentation:
https://threejs.org/docs/#api/en/core/Raycaster
"Checks all intersection between the ray and the object with or without the descendants. Intersections are returned sorted by distance, closest first."
it makes sense that it's pulling inex 0 from the Array (closest), I think we just need to give some context to what context is in this case. Will take a look at it further.
Once this is fixed then we can take a look at what's still failing for real low width objects like wires, maybe we see some improvements there too.
https://user-images.githubusercontent.com/5366927/137558448-d1ff1709-bd1d-4ca3-902e-0ef0ea8240fc.mp4


Key Error.

Hi, I run the code. It raised up a key error

. How can I fix it?

Which dataset are you trying to use?

I use CMU-Mosi dataset.

I went thtough the file 'process_data.py' from the error report, but did not find out the reason.

@Timrashford could you try running the code 2 times back-to-back by avoiding the error?

@lobracost  Yes, I try couple of times but, the error remained.


Proposition: Put JFoenix site on the repo as branch

It doesn't have to be GitHub Pages pinned to a domain by record. But branch with website would give contributors possibilities to improve it. ;)

we created a new repository for JFoenix website:
https://github.com/jfoenixadmin/JFoenix-Website

That's great, thanks!


Post being update with public_folder; not media_folder

My Jekyll is hosted on a sub url e.g. www.mysite.com/documents/
My netlify config looks like this:
media_folder: "assets/images"
public_folder: "documents/assets/images"
As far as I can tell, this is right.  In the repo images are found via assets/images/1.jpg, but on the website they are found via documents/assets/images/1.jpg
netlify's UI works as expected; the images show in the media browser, editor etc.  But when updating the page the diff appears to use public_folder; rather than media_folder.  As such Jekyll can't find the files and they appear as broken links e.g. the diff looks like

date: 2018-01-11T00:00:00.000Z

image: assets/images/1.jpg
+image: /documents/assets/images/2.jpg

media_folder is used by Netlify CMS to locate the file in your repo, public_folder is used for outputting a link to the live location of the file on your site; what you're describing is by design.
You're saying Jekyll is trying to find your images - are you sure? That isn't default behavior.


Save output of cellrank.pl.aggregate_absorption_probabilities

It would be great if we could access the data plotted in cellrank.pl.aggregate_absorption_probabilities, e.g. as a pd.DataFrame.

Unfortunately, we currently don't have capacity to implement this, feel free to open a PR though @MUCDK


Set usage on transient image based on format

Avoids setting the color attachment bit for depth stencil formats to prevent crash

Author jfthibert not on autobuild list. Waiting for curator authorization before starting CI build.

CI Vulkan-Tools build queued with queue ID 19493.

CI Vulkan-Tools build # 761 running.

We were seeing the issue on slightly older versions of amdvlk ICD where an update of vulkaninfo caused the crashes, we haven't seen that behavior on any other application so far. Are there any cases where it would make sense to have depth format also be used as color attachment? I agree the logic is slightly hard to follow, it might make sense to extract additional usage bits for transient outside of the tiling check?

Since you are seeing real crashes, and since color & depth_stencil usages are usually mutually exclusive, I'm going to merge it.


Support Vertica on ARM

Is your feature request related to a problem? Please describe.
Vertica is currently moving towards supporting ARM processors. We need to support Vertica and other development containers (Spark, Hadoop, etc) on ARM as well to avoid performance issues.
Describe the solution you'd like
Once the version of Vertica that supports ARM is released, create an ARM-based Docker images for Vertica, Spark, Hadoop, etc.
We also want to run all of our tests to ensure the Spark Connector does not have any issues when run on ARM against a Vertica (also on ARM).
Additional context
Note that we may need to go to our current images, such as Bitnami Spark, and build ARM versions ourselves since most images do not currently provide ARM versions.

Wait until VERTICA, Bitnami, and hdfs are available on arm.  Bitnami images look like they might have been released recently.

Once issue is priorities - need to consider ticket - https://github.com/vertica/spark-connector/issues/472


[thought] context/state-aware clack type for managing sequences

Today I came across the thought that it would actually be nice to have a context-aware Clack (or whatever) type where state can be maintained throughout a longer dialogue sequence.
Something like:
let clack = Clack;
clack.intro("We're gonna do some stuff!");
clack.select("Please choose something!").from(["Eenie", "Meenie", "Miney", "Mo"]).interact()?;
clack.outro("We're done!");

This doesn't say much in itself, but allowing components to be aware of where they are in the chain (automatically) would make some conditional rendering possible based on last state.

@cylewitruk How is your example different from what is there now?
intro("We're gonna do some stuff!");
select("Please choose something!").from(["Eenie", "Meenie", "Miney", "Mo"]).interact()?;
outro("We're done!");

@cylewitruk How is your example different from what is there now?
intro("We're gonna do some stuff!");
select("Please choose something!").from(["Eenie", "Meenie", "Miney", "Mo"]).interact()?;
outro("We're done!");

The example doesn't give context -- but where it becomes useful is when everything doesn't necessarily happen within the same function.
Upon further reflection this could also be the basis for introducing the builder pattern for forms.
This issue is mostly a discussion topic for me -- but discussions aren't enabled for this repo 😊

@cylewitruk This can implemented on your own as a wrapper based on cliclack. It should not be in the crate.


Test triagebot

This should be enabled now so let's give it a whirl...

@rustbot claim

@rustbot release-assignment

Swell, working nicely


Resolution is off in bitmap output

From what I've gathered, the page dimensions as reported by PdfiumViewer are off by a factor of 1.3 which ultimately leads to an incorrect size of the bitmap output.
The default DPI value for PDF documents is 72 DPI. I used ImageMagick output to confirm that that is also true for my test PDF file.
It looks like you are getting the page dimensions from the native library. So I am not sure whether this actually is something you can do anything about.
Here is what I am currently doing to work around that (and to output resolutions other than 96 DPI):
var dpiTarget = 150;
var pdfDpiDefault = 72D;

float systemDpiX;
float systemDpiY;
using (Graphics graphics = Graphics.FromHwnd(IntPtr.Zero))
{
    systemDpiX = graphics.DpiX;
    systemDpiY = graphics.DpiY;
}

var pageWidthPixels = (int)pdf3.PageSizes[0].Width;
var pageHeightPixels = (int)pdf3.PageSizes[0].Height;

var cX = systemDpiX / pdfDpiDefault;
var cY = systemDpiY / pdfDpiDefault;

var dpiX = (int)(dpiTarget * cX);
var dpiY = (int)(dpiTarget * cY);

var factorX = dpiX / systemDpiX;
var factorY = dpiY / systemDpiY;

var renderWidthPixels = (int)Math.Round(pageWidthPixels * factorX, 0, MidpointRounding.AwayFromZero);
var renderHeightPixels = (int)Math.Round(pageHeightPixels * factorY, 0, MidpointRounding.AwayFromZero);

using (var image = pdf3.Render(0, renderWidthPixels, renderHeightPixels, dpiX, dpiY, false))
{
    // ...
}

I also tried using the other Render signatures for getting the correct output resolution (i.e. Graphics.FromImage(bitmap) but using a value other than 96 dpi screwed up the output (e.g. incorrect font sizes and/or incorrect output size (lots of white space)). So I think that something is not quite right about the transforms in that method.

I'm not really sure what you mean. Are the dimensions of the output image different from the dimensions you specify to the Render call? That shouldn't be. For the Render overload that returns an Image, the height and width are send to the Pdfium library verbatim. The X and Y DPI aren't even used.

I attach to the subject because I have problem with rendering page as image with resolution different than 96 dpi. When I set dpiX and dpiY as 300 final image still has vertical and horizontal resolution 96 dpi. I think that problem is in method: RenderPDFPageToBitmap in PDFFile class. You have dpiX and dpiY parameters but not using them.


blank image

I tried the example from README and the image pops up, but it's blank and empty.
Also after a while, it displayed the following.
Error executing vim.schedule lua callback: vim/shared.lua:0: invalid type name:
nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_extend'
        ...e/pack/packer/start/hologram.nvim/lua/hologram/image.lua:59: in funct
ion 'display'
        ...te/pack/packer/start/hologram.nvim/lua/hologram/init.lua:56: in funct
ion 'buf_render_images'
        ...te/pack/packer/start/hologram.nvim/lua/hologram/init.lua:17: in funct
ion <...te/pack/packer/start/hologram.nvim/lua/hologram/init.lua:17>

I had a similar issue while trying to run the README example. I fixed it by using an absolute path to the image instead of a relative one.

No, but I'm installing it now. Aren't you supposed to download the tarball file & extract it. The application in bin is not executable.

I have the same problem. I am using the Kitty terminal, and I can display images in the shell. In an nvim buffer, hologram just gives me a blank space.


this error has fixed?

https://github.com/shimat/opencvsharp/blob/446a566dc89bdd5f6bf3d2d8f506e5359e8939e7/test/OpenCvSharp.Tests/text/TextDetectorTest.cs#L46

This is fixed in the latest version (4.2.0) .


[modify][cms] always show "branch save" if page is public

Coverage increased (+0.001%) to 84.979% when pulling 223323e6a448a598e6581fbc3acd4dc80e4d9267 on pr-show-save-as-branch into a43a90e3360ab0a00fe3c1a100cecd8df019200a on master.


Release Google.Cloud.Talent.V4 version 1.0.0

Changes in this release:
No API changes since 1.0.0-beta02.

Created release for Google.Cloud.Talent.V4-1.0.0

Created release for Google.Cloud.Talent.V4-1.0.0


Unexpected behavior when using 'builtin_box_drawing: false'

Contour Terminal version
0.4.3
Installer source
GitHub: release page
Operating System
win11 23h2
Architecture
x86
Other Software
vim9.1 and nvim0.95
Steps to reproduce
The minimum configuration
platform_plugin: auto
# Word delimiters when selecting word-wise.
profiles:
    main:
        font:
            # Initial font size in pixels.
            size: 16
            locator: native
            text_shaping:
                engine: native
            builtin_box_drawing: false
            render_mode: lcd
            strict_spacing: true
            regular:
                family: "SauceCodePro Nerd Font Mono"
                weight: regular
                slant: normal
                features: []
            bold: "SauceCodePro Nerd Font Mono"
            italic: "SauceCodePro Nerd Font Mono"
            bold_italic: "SauceCodePro Nerd Font Mono"
            emoji: "emoji"
        draw_bold_text_with_bright_colors: false

Expected Behavior
No response
Actual Behavior

Additional notes
No response

You need to set builtin_box_drawing to true to get better box drawing, this is what i see when print boxes into terminal directly
with builtin_box_drawing=false

with builtin_box_drawing=true


Hot fix

Remove the scroll of the body when a recipe is open and get back the scroll when the recipe is closed
Limit the with of the recipe to 700px in desktop view
Fix the load more UI error

Looks good to me!


docs: update README-pt-BR.md

docs: update README-pt-BR.md

Closing this because it's been open for a long time. But feel free to reopen if you want.

You on youtube with the game genie codes i been fixing messed up codes
trying to toss better ones so easy gameplay found a few lost MMO player
cause game not help player get stuff sent to me Developers are unkind
lately.
Michael Russell
On Fri, Oct 2, 2020, 12:39 PM Igor Guastalla<EMAIL_ADDRESS>wrote:

Closed #324 https://github.com/nostalgic-css/NES.css/pull/324.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nostalgic-css/NES.css/pull/324#event-3834990685, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALFK4CR3EVLQHGMZH5EMM2DSIYF5PANCNFSM4G7TRIUQ
.


tusd binary file not created

Question
tusd binary file not created on command "go build -o tusd cmd/tusd/main.go" ?
Checked go/bin folder tusd binary file dont exist.

The command you are using does not place the binary inside $GOPATH/bin. It places the generated tusd binary in your current directory. You should be able to find it at ./tusd.

Thanks. Solved


workflows: replace component images by key instead of array index

the previous replacement was pretty fragile already, after a new env was
introduced it broke. this fixes the issue for good.

/cherry-pick redhat-3.6


"Update from URL" should also update URL

If the "update from URL" function is used and a new url is entered in the popup (ie, url url hadn't already been entered for that event),  then date, location, etc. updates as expected.
The url field itself should also update.

Although the import_from_url script updates the URL filed, the url itself is not returned from the event_import view.
I have suggested a fix at #748.
Cheers!

@maneesha I think you used "Skip non-empty fields.", but you should use "Overwrite" to overwrite existing URL.

@maneesha let me know if you want to do something about this behavior, for example change the default option from "Skip" to "Overwrite".

@maneesha I think you used "Skip non-empty fields.", but you should use "Overwrite" to overwrite existing URL.

This bug is encountered when the URL field for an event is empty.
Since it is the first time that the URL field is being populated, choosing the "Skip non-empty fields" seems to be the right choice as the user is only interested in updating the empty fields, including the URL field.
Please manually test the Update from URL functionality on an event with empty URL field.

@narayanaditya95 you're right.
The solution is to remove data. part from JS code in a proper place.
I'd like to also evaluate empty object.url to empty string instead of None in event_import_update_from_url.html line 29.
@narayanaditya95 I feel like you should make the changes and submit a new PR, since you already fixed this issue once. Will you? If you're busy I can do that.
Thanks for the help!

On it.


Added missing </code> in test text string

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

@mattschlosser Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


As an operator I want my promotion to link to the Terms and Conditions so that customers can get more information about the promo

[ ] User sees a field with the label "Terms & Conditions URL" underneath the PDP Call to Action field in the Promotion Messaging section
[ ] User can enter URL text in the T&C field
[ ] Terms and Conditions URL is not required for saving the promotion

Mockup: Promotions / Detail Page https://www.figma.com/file/vWot2cXXgjcsLpMq4SAX90/Kinetic?node-id=2020%3A54523&t=sFagdUnSMbq5ZIJn-0

Thanks @vannguyenn I updated the ticket to reflect your feedback, having the link active is not critical enough to make any changes around it so I removed that criteria


Chore/updates

Depends on a new release for https://github.com/ipfs/js-ipfsd-ctl/pull/47

Just released 0.8.0 of js-ipfsd-ctl, can you bump the version on this PR so that Travis becomes happy again?

@diasdavid done

thank you @Dignifiedquire :)


Nested LXD fails with error when asking for available resources

Required information

Distribution: Ubuntu
Distribution version: 18.04
The output of "lxc info" or if that fails:

Kernel version:5.3.0-28-generic #30~18.04.1-Ubuntu SMP
LXC version: 4.0.0
LXD version: 4.0.0
Storage backend in use: zfs

Issue description
A nested LXD within an unprivileged fails to determine available resources when calling the /1.0/resources API endpoint
Steps to reproduce

Create a LXD container lxc launch ubuntu:b c0
Install LXD snap within that container lxc exec c0 -- snap install lxd
Try to fetch resources from LXD

$ curl --unix /var/snap/lxd/common/lxd/unix.socket s/1.0/resources
{"error":"Failed to retrieve system information: Failed to read \"/sys/class/dmi/id/product_uuid\": open /sys/class/dmi/id/product_uuid: permission denied","error_code":500,"type":"error"

Yep, I sent a PR to fix that already, we'll cherry-pick it ASAP.

Nice, thanks @stgraber

Also added a test for it and validate on all architectures for good measure.


dsc_service doesn't refresh on notify

The dsc_service doesn't appear to support the “refresh” action when a dependency changes via notify.  It does, however, ensure a service is running when stopped.
Therefore, I have to use the native service type as well to handle this situation.
  service { $service_name:
    ensure    => running,
    enable    => true,
    subscribe => Dsc_service[$service_name],
  }

  #Prevents user from changing service to run as Local System account
  dsc_service { $service_name:
    dsc_name       => $service_name,
    dsc_credential => {"user" => "${service_user}", "password" => "${service_pass}"},
  }

@ktreese This is likely related to the DSC resource itself not having a good way to query the state of the service (this boils down to Get, Test, Set) and Microsoft's prior focus on not worrying about Test as much as Get and Set. Expect things to come up more to speed as the underlying DSC resources get better.

@ferventcoder Thanks for that.  Though use of service and dsc_service works just fine, it felt kludgy.

I was corrected. It was Get that was not a focus awhile back. So sometimes things come back empty or without data.

Likewise, dsc_service doesn't pick up on user password changes and update services using said account.

@ktreese out of curiosity - is there a deficiency in the Puppet service type that made you want to use the DSC one?

@Iristyle yes.  The native service type does not support configuring service dependencies or account to run as.  As such, I was looking to control drift / prevent a user from changing a service to run as the Local System account.

Should this be closed? It looks like it still happens.
Will there be no changes required in puppetlabs-dsc once the DSC resource comes up to speed?

@c22 I had closed the issue since the use of the native service type coupled with the dsc_service resource type gave me what I needed. Ultimately, that in itself is still an issue, as is the inability to recognize password changes. I'll reopen

Hi,
Puppet will be shutting down the github issues tab in this repository as there already is a publicly accessible issue tracker on March 24th, 20017.
If you want to continue the discussion from this issue, please follow the ticket already created from this issue (typically MODULES-XXXX) in our issue tracker.
If you would like to file a new issue, please follow the template here to create a new ticket.
Thanks,
James Pogran

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.\n\nWe're going to close it but please do raise another issue if the issue still persists. 😄


Bugfixes and features in the AgalTranslator. (Needs testing)

Fixed constant register usage.
Added Cos and Sin.
Added an horrible optimization pass for temporary registers.

Could use some testing (don't really have alot of shaders here to test it with).

Uh, I like it.


implement convert_string in PAL for non-windows platforms

The two convert_string PAL functions (UTF-8 -> UTF16 and UTF16 -> UTF8) are only implemented for windows. The version in common_string_convert.cpp simply throw today.

#81 addressed this.


feat(#36): add forgot password functionality

Description

Related Issue

#36
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Looking great!
Remember to add a note to docs regarding how to setup the emails in Spree (that they should point to the frontend at a certain URL)


Feature: Filter by glob or extension in cli

I'm sick and tired of these bad less watchers. Those has lead me to here. I still need a way to define file filter to use this instead.
Example:
watch "lessc style.less style.css" --globFilter **.less
globFilter would make my life so much easier. Thanks.

Closing this, this is duplicate. Apologies.

Honest question, are you sick and tired enough to help me a better one?  I'm a recent new contributor here and hope to make a better watch package.  If you'd like to see this one become that package, it would be great to get some PR reviews and input on the ideas being put forward.  Thanks much!

@levithomason I'm sick and tired of LESS (the css preprocessor) watchers — not this one! Though unfortunately I found what I needed already: https://github.com/queckezz/watch-run

Thanks for the clarification, I've heard some good things about watch-run.  Will check it out.


Backporting #1245 (Unpermitted parameters) to 7.1.x

Backporting #1245 to 7.1.x
I'm opening a PR since there where a few conflicts.
Pings:
@cheerfulstoic
@subvertallchris

Seems good to me, but I think that this would be when you add functionality in a backwards-compatible manner which would be a minor update according to semver.org
Shall we release as 7.2?  I've been trying to release patch versions whenever there's something to be released which leads us up to .15 sometimes, but I feel like we hold back on minor updates

Since this fixes this bug:
https://github.com/neo4jrb/neo4j/issues/1244
I considered it as a "bugfix", but instead it's a feature.
So, for me it's ok to release a 7.2.x version ;)

Current coverage is 97.24% (diff: 100%)

Merging #1271 into 7.1.x will increase coverage by 0.01%

@@              7.1.x      #1271   diff @@
==========================================
  Files           168        170     +2
  Lines         10426      10482    +56
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          10137      10193    +56
  Misses          289        289
  Partials          0          0

Powered by Codecov. Last update abc2cbc...f7ae0f1


i18n-lang-js-chunks.js is deprecated

Updated enb, in my make file I use tech i18n-lang-js-chunks.js which is deprecated in new version.
Could you please point me to the alternative tech?
Thank you!

Move tech to enb-bembundle package: https://github.com/enb-make/enb-bembundle/pull/3.
Deprecated tech in this package: https://github.com/enb-make/enb/pull/173.


Fix for user resolving from resident organization when user is deleted

Purpose

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3603406575

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3604448475
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3606179592

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3606179592
Status: success


Fix a drawText regression introduced with 31a68e2

This PR fixes a regression from 31a68e21a51ee378c3698354523d185eef52f543
Previously the relevant lines looked:
  if (this.text_ === '' ||
      goog.isNull(this.textState_) ||
      (goog.isNull(this.textFillState_) &&
       goog.isNull(this.textStrokeState_))) {
    return;
  }

after 31a68e21a51ee378c3698354523d185eef52f543
They look like
  if (this.text_ === '' ||
      !this.textState_ ||
      (this.textFillState_ &&
       !this.textStrokeState_)) {
    return;
  }

I think it should be
  if (this.text_ === '' || !this.textState_ ||
      (!this.textFillState_ && !this.textStrokeState_)) {
    return;
  }

Please review.
Thanks @jmekaelthas for noticing this in #4240.
Fixes #4240
/cc @tschaub, @ahocevar

Looks good. Please merge.
I think this deserves a 3.10.1.

I aggree, we should probably release 3.10.1. I cannot do it, sorry.

Releasing 3.10.1 now.

Done.

Merci beaucoup! And sorry for introducing the bug


Fixing the FileSystemOutputCache feature

Fixes #6115

Caching keys for filenames to prevent too long paths
Separating metadata from content storage to optimize some scenarios
Fixing retry logic

TODO: Don't use BinaryFormatter to serialize the output

Tested and it fixed encoding issues with long blog post URLs as well as Tags with multi-word keywords


Is the repo compatible with TensorFlow 1.0.0 ?

Hi, I recently upgraded my tensorflow to 1.0.0 and tried to install tensorflow fold with tensorflow 1.0.0 (rather than 1.0.0rc0), but got some error with bazel when installing from source.
Installing from source
I've tried to install this tensorflow fold from source following https://github.com/tensorflow/fold/blob/master/tensorflow_fold/g3doc/sources.md, and everything works well. However, when I tried to replace the tensorflow submodule with the master tensorflow (rather than 1.0.0rc0) and run bazel build --config=opt //tensorflow_fold/util:build_pip_package, I got the following error:
ERROR: Failed to load Skylark extension '@io_bazel_rules_closure//closure:defs.bzl'.
It usually happens when the repository is not defined prior to being used.
Maybe repository 'io_bazel_rules_closure' was defined later in your WORKSPACE file?
ERROR: cycles detected during target parsing.
INFO: Elapsed time: 2.703s

So it seems that the bazel setup of fold is not compatible with tensorflow 1.0.0. It there a way to fix it?
Installing from binary
I also tried to install from binary following https://github.com/tensorflow/fold/blob/master/tensorflow_fold/g3doc/setup.md, but installed tensorflow 1.0.0 (instead of 1.0.0rc0) by pip install tensorflow-gpu.
After installation, I found that python -c 'import tensorflow_fold' works, and that my can run. But I'm still worried that is the provided binary in the setup.md compatible with tensorflow 1.0.0, since (I assume) it was compiled against tensorflow 1.0.0rc0).
So is the provided fold binary tensorflow_fold-0.0.1-py3-none-linux_x86_64.whl compatible with tensorflow 1.0.0 binary? Or is there a way to build fold against tensorflow 1.0.0? Thanks in advance!

If you install both TensorFlow and Fold from binaries, then there will be
more wiggle room -- TensorFlow maintains at least some degree of binary
compatibility between similar release numbers, although I don't know how
much.  In general I'd say that if it runs without crashing, then you're
probably okay.  :-)
The problem with building from source is that Fold references the internal
build files used by TensorFlow, and those can change even between minor
point releases.  Feel free to experiment if you want, but we only test
against the particular point releases listed when building from source.
On Sun, Feb 26, 2017 at 5:05 PM, Ronghang Hu<EMAIL_ADDRESS>wrote:

Hi, I recently upgraded my tensorflow to 1.0.0 and tried to install
tensorflow fold with tensorflow 1.0.0 (rather than 1.0.0rc0), but got some
error with bazel when installing from source.
Installing from source
I've tried to install this tensorflow fold from source following
https://github.com/tensorflow/fold/blob/master/tensorflow_
fold/g3doc/sources.md, and everything works well. However, when I tried
to replace the tensorflow submodule with the master tensorflow (rather than
1.0.0rc0) and run bazel build --config=opt //tensorflow_fold/util:build_
pip_package, I got the following error:
ERROR: Failed to load Skylark extension '@io_bazel_rules_closure//closure:defs.bzl'.
It usually happens when the repository is not defined prior to being used.
Maybe repository 'io_bazel_rules_closure' was defined later in your WORKSPACE file?
ERROR: cycles detected during target parsing.
INFO: Elapsed time: 2.703s
So it seems that the bazel setup of fold is not compatible with tensorflow
1.0.0. It there a way to fix it?
Installing from binary
I also tried to install from binary following
https://github.com/tensorflow/fold/blob/master/tensorflow_
fold/g3doc/setup.md, but installed tensorflow 1.0.0 (instead of 1.0.0rc0)
by pip install tensorflow-gpu.
After installation, I found that python -c 'import tensorflow_fold'
works, and that my can run. But I'm still worried that is the provided
binary in the setup.md compatible with tensorflow 1.0.0, since (I assume)
it was compiled against tensorflow 1.0.0rc0).
So is the provided fold binary
tensorflow_fold-0.0.1-py3-none-linux_x86_64.whl compatible with tensorflow
1.0.0 binary? Or is there a way to build fold against tensorflow 1.0.0?
Thanks in advance!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/fold/issues/22, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGbTWBlDkFZLeRwMVX7-hxyEtkSnhu6ks5rgiFJgaJpZM4MMmHW
.

--
DeLesley Hutchins | Software Engineer |<EMAIL_ADDRESS>|<PHONE_NUMBER>

Thanks! I'll use the TF 1.0.0 binary then.


Any way to get the value of an input/select?

I'm trying to make sure that a select box is rendered with the proper value selected.  I don't see any hooks into value in the docs for shallow or render. Is there an obvious thing I'm missing?

@kwhitaker wrapper.find('input').props().value should get you what you need
Though I wouldn't be opposed to adding a .val() shortcut...

@lelandrichardson thanks for the tip, but sadly that selector comes up as undefined.
Here's the full props from wrapper.find('select').props():
{6   -_-_-_-_,------,
  "defaultValue": "en-UP",
  "id": "locale-selector",
  "children": ["  ""
    {
      "type": "option",
      "key": "en-US",
      "ref": null,
      "props": {
        "value": "en-US",
        "children": "English (US)"
      },
      "_owner": null,
      "_store": {}
    },
    {
      "type": "option",
      "key": "en-UP",
      "ref": null,
      "props": {
        "value": "en-UP",
        "children": "English (Uppercase)"
      },
      "_owner": null,
      "_store": {}
    }
  ]
}

Wait duh. I wasn't explicitly setting value in my component. Blah.

@lelandrichardson This works well when you want to test that the prop as an argument is correct, but doesn't work well when you are wanting to test the rendered output. In my case, I am auto-formatting a value as part of the render function as part of the implementation of the component. I might be missing something, but when I try to use a mounted component, inputs never render the value:
const TextInput = (value, autoformat) =>
  <div>
    <input type="text" value={autoformat(value)} />
  </div>

const NumberInput = props => <TextInput autoformat={commas} {...props} />

mount(<NumberInput value={1000} />).find('input').html() // <input type="text"/> instead of <input type="text" value="1,000"/>
shallow(<NumberInput value={1000} />).find('input').html() // Error: This method is only meant to be run on single node. 0 found instead

In many cases, I'm able to use shallow rendering and it is fine, but some of my components are extensions of lower-level components, and thus mount appears to be required.

@lelandrichardson Any thoughts on this?

@ljharb I just wanted to ping you on my question above, since you are the number 2 contributor to the library - is this something we can expect to change?

@tshelburne what does mount(<NumberInput value={1000} />).debug() and shallow(<NumberInput value={1000} />).debug() output?

@ljharb Thanks so much for the quick response.
I randomly decided to check what version I was on (2.2.0), and then to update to the latest version to run your request, and now this appears to be working. Sorry for the mistake.

@tshelburne Checking the value prop of the input component as above is enough, because at that point you're relying on React to do it's job (if the value of an input component is 'foo', then it must be foo in the DOM too, otherwise it's a serious bug in React).

@trusktr Can't disagree with your reasoning from a technical perspective, but when I'm asking my designers / new developers to update and write unit tests for components, it's a much more reasonable expectation for them to compare HTML strings than to consider the underpinnings of React (simple though it may seem).
We have a robust pattern library in it's own NPM module that is backed by React components, and it's not intended just to be a JS developer's playground, but something accessible to everyone on the team. I'm all about making systems that enable developers at every level, and being able to reliably check the rendered HTML has already been a meaningfully helpful tool.

@trusktr My scenario to test, Am I given the right state property name to the input element's value attribute. like, i have my state property name as "firstName", but i specified as <input type="text" value={**this.state.fName**}. Will this make sense to test the above case

@kwhitaker wrapper.find('input').props().value should get you what you need
Though I wouldn't be opposed to adding a .val() shortcut...

I think getting it with prop() also makes sense
wrappedContent.find('Form Input[id="client_edit_id"]').prop('value')


Scaffolding fails System.IO.FileTooLongException

Visual Studio 2015
ASP.NET core 1.1
.NET framework 4.6.2
If there are nested folders in your project that exceed max file/path length scaffolding will fail on the Build step. I used Visual Studio to try to scaffold a Entity Framework Controller. I had a node_modules folder that had folders nested way too deep.
Verified that when I deleted the node_modules folder I was able to add a EF controller.
Excluding node_modules from my project.json didn't change anything.
I now realize I can call dotnet aspnet-codegenerator with a --no-build flag. I didn't try it but because I get the error in a build step I'm pretty sure that would solve my problem.

Thanks for the heads up, passing --no-build in this situation (after having otherwise built your application) is the appropriate course of action


Significant drop of bandwidth in presence of link delay

I added a DelayInjector device to the benchmark example to simulate links with delay. Here is my code, and here is the results:

Delay(ms)
TCP buffer size
Bandwidth(Mbps)

1
65535
60.533

10
65535
29.770

100
65535
4.870

1000
65535
0.534

1
65535000
141.416

10
65535000
133.220

100
65535000
78.142

1000
65535000
22.957

2000
65535000
12.503

Without DelayInjector
65535000
179.809

Without DelayInjector
65535
185.707

5000 and more
any
Connection timeout

I don't think that huge amount of buffer is needed in the reader mode to use the bandwidth of the link, since packets are coming in order and we can deliver receiving packets immediately to the application. In the writer mode, the huge buffer is needed since we need to buffer sending data until receiving the ack, so we need a buffer of size RTT*Bandwidth.
Am I right? Is it possible to solve this problem without changing the buffer size?

I don't think that huge amount of buffer is needed in the reader mode to use the bandwidth of the link, since packets are coming in order and we can deliver receiving packets immediately to the application.

a big buffer is needed in the reader because it controls the advertised window size. The writer will not send data unless it knows the reader has buffer space for it.
The expected bandwidth is min(rx_buffer, tx_buffer) / rtt. The results you're getting are roughtly in that order of magnitude.
In theory you could hack the reader to advertise a much bigger window size, hoping that when data does arrive the application will have consumed earlier data and there'll be buffer space. If there's not, it'd be forced to drop the data on the floor, which would be seen as packet loss by the sender which would trash performance, so it'd be tricky to get right. I'm not aware of any network stack doing that.

Thanks for the response. It makes sense. I will close this issue as it doesn't seems correct to do it.
Do you find an example containing link delay helpful? If so, I can clean up my changes and make a PR.
Another question: Is it possible to make the buffer growable for applications that can afford heap allocation? To make buffer big only for sockets that actually need that.


Does it support windows/linux desktop?

Hi, Does it support windows/linux desktop?
flutter support desktop now.

No, doesn't as of now..


Invalid file

final path = await recorderController.stop();
final String finalPath = path!.substring(7);
File file = File(finalPath);
bool filepresence = await file.exists();
print(filepresence);

This is giving me invalid file and player controller is also saying invalid file path

If you are using an emulator it might not require the substring part else can you share which device you are using?

If you are using an emulator it might not require the substring part else can you share which device you are using?

Done the issue was bad format of the path you are returning  the path was returned like

@HytenoTech thank you for providing this. and I will update this.


Helper script failures don't make busted fail

I wrote a helper script that throws an error if the environment is not suitable.
Busted logs the error, however it doesn't prevent it from running tests, nor does it exit with a non-zero code.

busted: error: Cannot load helper script: spec/helper.lua
spec/helper.lua:28: Locale not available

I worked around this with os.exit(1) for now... https://github.com/daurnimator/lua-http/commit/4f4d7194f128dff903d44c18e39da769e54a4308

ran into this myself today, fix in #638


[NoQA] fix: update Gemfile.lock to fix e2e builds

Details
This PR didn't update lock file and because of that e2e build fails now: https://github.com/Expensify/App/pull/46377
In this PR I re-run bundle install and committed update file.
Fixed Issues

$ https://github.com/Expensify/App/actions/runs/10177739235/job/28150404575
PROPOSAL: N/A
Tests

Run e2e build pipeline and be sure it's green again

Offline tests

N/A
QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Julesssss may I ask you to review this PR?
Asking because you were reviewing a very similar PR (also e2e build fixes) PR before 😅

Yep, no problem. I see we don't have an issue, can yo post back to this PR after we verify the fix? Thanks

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add shared python setup action

Add a "common" python setup task and use it
Add integration tests to github action (one test fails though @pankajroark, I am not familiar with truss, but I think it was already there
Move pre-commit to dev dependencies

There is a lint error in pr.yaml that's worth fixing before landing.


[misc] improve cloudpickle registration

improves over https://github.com/vllm-project/vllm/pull/6751
config is the only custom class we pass across processes, and we can move the function call into get_config , where the first import of transformers_modules happen.
I use cloudpickle to serialize the whole VllmConfig rather than the single ModelConfig, so that even if people move hf_config outside of ModelConfig, the code can still work.
Also added some example code for when transformers_modules will be available.

cc @tjohnson31415 @njhill

Thanks @youkaichao


Prepare for 3.12.0 release

Signed-off-by: Michael Carroll<EMAIL_ADDRESS>🎈 Release
Preparation for <3.12.0>release.
Comparison to <3.11.1>: https://github.com/ignitionrobotics/ign-common/compare/ignition-common3_3.11.1...ign-common3

Needed by https://github.com/ignitionrobotics/ign-launch/pull/97
Checklist

[ ] Asked team if this is a good time for a release
[ ] There are no changes to be ported from the previous major version
[ ] No PRs targeted at this major version are close to getting in
[ ] Bumped minor for new features, patch for bug fixes
[ ] Updated changelog
[ ] Updated migration guide (as needed)
[ ] Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Actually, I need to expand the changelog for this, give me a few minutes.


Found a possible security concern

Hey there!
I belong to an open source security research community, and a member (@geeknik) has found an issue, but doesn’t know the best way to disclose it.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

Responsible disclosure instructions are for projects people use… no one uses Kuroko in an exploitable capacity, so just post the bug as an issue report and stop wasting my time.


chocolatey_package matchers are missing

I'm working on a PR for this.
Chef-Client 12.7 introduces a chocolatey_package resource.
ChefSpec should include a set of chocolatey_package resource matchers.

@sethvargo I'm working on a PR for this. Which version should I use for the @since on the chocolatey_package Matchers module - 4.6.0?
Here's an example for WindowsPackageMatchers
module ChefSpec::API
  # @since 0.5.0
  module WindowsPackageMatchers
    ChefSpec.define_matcher :windows_package
<snip>

@dougireton awesome! The next version will be 4.6.0, since this is introducing a new API :smile: :heart:


Creation Date

Thankyou for a wonderfull wraper, is there a way to filter contact using their creation date in device.
Thanks in advance.

Hi,
Unfortunately this information is not exposed by the Contacts framework, but you could try to subscribe to the Contacts History events - it's a public but undocumented API.
Apologies.


Allow users to add/override fields

This allows users of this action to specify additional fields through the
file at $BUILDEVENT_FILE. Any values specified in there override the
defaults provided by gha-buildevents.
This fixes #3.

The test run (see link above) did surface the additional platform value from the BUILDEVENTS_FILE as configured in the workflow:


Launching process under lldb fails in WSL

Microsoft Windows [Version 10.0.16299.125]
I have lldb 3.8.0 installed
On regular Ubuntu, I can use it successfully to run a process, eg:

On WSL Ubuntu doing the same thing seems to hang ... Ctrl C and Ctrl Break do not do anything, hitting enter just moves the cursor down. I have to pkill lldb from another terminal:

strace suggests it's a process launch issue:
dan@danmose2:~/dotnetU$ strace -o lldb.strace -f lldb echo 1
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/lldb/__init__.py", line 123, in <module>
    import six
ImportError: No module named six
(lldb) target create "echo"
Current executable set to 'echo' (x86_64).
(lldb) settings set -- target.run-args  "1"
(lldb) run
error: process launch failed: 'A' packet returned an error: 8

Is this scenario supported on WSL?

#2028 PTRACE_TRACEME


New home page

I would like to suggest creating a home page to list all groups.
Currently, we are showing the where operator when the pages open. My suggestion is to create a home page listing all groups using cards/buttons in a grid layout.
This approach is more mobile-friendly than a side list.
An example of the proposed layout can be seen in the Flutter widgets documentation. There is a title (in our case will be the operator group) and a short description.

Short clarification:
Would you remove the whole sidebar navigation? Or, like the Flutter widgets documentation, we would keep the Groups (like Aggregation, Filtering, ...) and move the operators themselves into the grid?

My idea is to keep the sidebar, but it would start hidden.
The navigation using the grid could be:

Open the page at index / and show all groups on the grid.
Clicking on the Aggregation group we are forwarded to /aggregation page that lists all the operators of aggregation type in grid layout as well.
Clicking on the Count operator we are forwarded to /aggregation/count to see the Count operator detail like it is now.

So resuming the idea is to offer a complete navigation using the grid layout like buttons.
To implement it may be necessary to move the titles and routes to a dedicated service to control it. So the service could be accessed by all pages to get the specified route.

I like the idea. One last question: The search bar would stay inside the navigation bar and would work like in its current state?

I don't see the necessity to implement search on these grid elements right now. The grid implementation will naturally improve the readability.
The search bar can be kept untouched for the side menu.


Polish the new app screen

Summary
Continuation of #24687

Issue: Polish the "new app screen"
This is the pull request for the new intro screen proposal in react native as directed by @cpojer

This PR was created because the previous one could not be pushed to for some reason. I cleaned up a few small things and added the component as an example to RNTester so we can keep iterating. My plan is to land this, and then polish it and make it the default in a follow-up.
Changelog
[General][Added] - New Intro screen, Icons

Removed Lottie Integration
100% React Native 💥
Test Plan
npm run ios should build the template app similar to this:

@eliperkins @elucaswork @gengjiawen do you have any current feedback before landing this? If not, please approve it. I can then land it, and if you like you can send more PRs to polish it.
@orta could you give this a spin and tell me whether it matches your mockup to the point where you feel comfortable shipping it?

Yeah, this looks good to me.
I don't know if it's your plan, but I'd love it if the index.js from this was the file in the template in your app, so you see some examples on how to do styling, platform checking, ScrollViews etc. ( e.g. not just render() { <NewAppScreen/> } in user-land code)

@orta I'm trying to figure out what a good middle ground is for the App template. On one hand I don't want to increase the app size a lot or bloat the template but on the other I do want there to be more than a single React component that is inlined. Do you have any recommendation on a good balance?

My opinion, based on the idea that this is also "sample code" for when you first see react native. Move anything too 'complex'  into react-native which is privately exported (and not considered the API):
Making the index.js' header more like:
import {View, Text, StyleSheet, ImageBackground} from 'react-native';
import {Header, Section, LearnMoreLinks, colors} from 'react-native/components/new-app-screen';

Which would contain the components we see today:

Header
Section
Learn More Links
colors
An abstraction that combines the Fragment, and the two SafeAreaViews?
I'm 60/40 on moving ReloadInstructions and DebugInstructions into it too.

If this is the sample code to give you a feel for what your React Native app will look like, then it's good to show:

Using a ScrollView
Using a StyleSheet (and how it hooks up to the style prop)
Using a Text and understanding how the text is a child of it
(Ideally) Using a TouchableOpacity to show how to do something which interacts (from reading the current code, this looks tricky)

As these are kinda the primitives for making an app at all.  Given that RN ships untranspiled, an editor should be able to jump to the 'hidden' components in RN to read.