[Feature] MongoDB Atlas: Adds search index commands and tests/examples of metadata filters

Description
Adds utility functions to create/update/drop search indexes without having to go through the Atlas UI.
For technical reasons, this currently is only available for clusters of size >=M10, thus not the free sandbox M0's.
Fixes # (issue)
N/A
New Package?
No
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[X] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
In addition to local unit/integration tests, we have a CI that we run nightly connecting to Local Atlas deployment.

[X] Added new unit/integration tests

Suggested Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I ran make format; make lint to appease the lint gods

Hi @logan-markewich, we've refactored to expose the search index helpers on the MongoDBAtlasVectorSearch class.

Hi @logan-markewich, @blink1073  I think we're good to go. You coverage is failing because you'd need a secret or two from us. This is what I get on my side.
---------- coverage: platform darwin, python 3.9.20-final-0 ----------
Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
llama_index/vector_stores/mongodb/__init__.py        2      0   100%
llama_index/vector_stores/mongodb/base.py          138     18    87%
llama_index/vector_stores/mongodb/index.py          56     10    82%
llama_index/vector_stores/mongodb/pipelines.py      47      9    81%
--------------------------------------------------------------------
TOTAL                                              243     37    85%


Bump stomp dependency to 1.4.4 and add dev instructions

Stomp 1.4.4 incorporates two bug fixes we've been carrying in
puppet-agent packaging. 1.4 also included a rewrite that broke SSL that
has now been fixed with this release.
Add instructions for running spec and acceptance tests, and setting up a
local environment.

CLA signed by all contributors.

Those docs are great; after spending just an hour or so reading about the general structure and concept of MCO, they're definitely enough to get me going if I wanted to test something. Thanks for this!

Following the instructions through end to end, I was able to get this up and running! Going to merge so others can do the same.


docs: highlighting warning in README

Updating the README to highlight the allowlist warning.
Updating the link to point to shortened form, so if there
are any changes in the future, we won't need to update
the README again.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Created from wrong account. Will create a separate PR from the correct account for CLA.


Improved visiblilty in sidebar of about

I have been assigned to improve the visiblity of About sidebar in issue #494
Before

After

@Deepanshu0703 dont add inline styles

Changed that @JasonDsouza212


Added a Fullscreen error popup

When the OCR triggers, if Warframe runs in fullscreen, it will popup a window to inform the user it will not work as intended.
The popup have 2 buttons :

"Disable Overlay" - will open the settings, letting the user choose by himself which mode he wants
"Change game display" - just close the window

note : this window only triggers on the FIRST activation after the launch IF the display mode is on overlay

Have not tested it but from reading the code it looks good.


SIMPLE_DATE_FORMAT is not honoring output granularities

SIMPLE_DATE_FORMAT does not take into account output granularities.  This causes group by queries to incorrectly bucket timeseries data.
For example-
inputFmt: 1:MILLISECONDS:EPOCH
outputFmt: 1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS
outputGranularity: 15:MINUTES
given a time of<PHONE_NUMBER>233L  currently returns 2018-04-12 19:16:38.233 instead of the expected output: 2018-04-12 19:15:00.000.
The fix appears to be very simple.  BaseDateTimeTransformer.transformMillisToSDF just needs call transformToOutputGranularity before being passed to the outputDateTimeFormatter.
Unless anyone has an objection I would be happy to put together a PR to fix this.

No bucketing in case of simple date format was intentional. Also, there are notes in BaseDataTimeTransformer.java line 30: "NOTE: time size, time unit and output granularity does not apply to simple date format."
Please refer to the comments in #2659

@Jackie-Jiang thank you for pointing me to that. The specific use-case I am after is allowing customers to query their data at different granularities and timezones as determined at query time.  For example Druid has support for querying in this mannor: http://druid.io/docs/latest/querying/granularities.html
@kishoreg sure thing thanks.

@kishoreg My initial PR has bucketing for SDF, but @npawar pointed out that we should not bucket for SDF, so I don't know if this would affect the current use case. @npawar Can you please verify that?

@Jackie-Jiang @kishoreg Here is my take on this- https://github.com/linkedin/pinot/pull/2738

Bucketing was left out, as it doesn't work correctly when timezone comes into the picture.
inputFmt: 1:MILLISECONDS:EPOCH
outputFmt: 1:MILLISECONDS:SIMPLE_DATE_FORMAT:yyyy-MM-dd HH:mm:ss.SSS tz(America/Los_Angeles)
outputGranularity: 1:DAYS
In this case, convert inputFmt to millis and then millis to outputFmt works
But convert inputFmt to millis, bucket to days, convert millis to outputFmt will not work for some hours of the day
UTC millis April 18th 2018 10am  should convert to 2018-04-18 00:00:00
UTC millis April 18th 1 am should convert to 2018-04-17 00:00:00
If we bucket it first, both will return 2018-04-17, which is not desirable.
If you plan to bucket it even in SDF case, you will need to handle bucketing with time zone knowledge

Great point about handling timezone for sdf conversion. So looks like if the output format is sdf, we should first convert inputFmt to a DateTime (not millis) and call the right API on the DateTime to truncate.
https://stackoverflow.com/questions/4133682/jodatime-equivalent-of-dateutils-truncate

@kishoreg @npawar If input and output have different time zone, which one should we pick to apply the bucketing? IMO, maybe always apply bucketing on epoch time is acceptable, we just need to document that.

@Jackie-Jiang bucketing on epoch time would be wrong. It will fail for the example I provided. Input in millisSinceEpoch but output in sdf with timezone changed was exactly the usecase why we added timezone support. In such cases it would be right to apply bucketing with timezone knowledge, or, do the bucketing after applying the output format conversion perhaps (inputFormat -> millis -> outputFormat -> bucket)

@npawar So you mean bucketing should always based on the output time zone right? I thinks that make sense to me.

+1 on @npawar comment. Do the bucket after converting it to the outputformat. @subprotocol, what do you think

yes, that's sounds right.


Critical dependency: the request of a dependency is an expression

I get these warnings every time I run yarn testnet.

this is resolved on my machine. can you guys confirm?

It's resolved for me too. Did the downstream dependency update to fix this?


feat(console): help view modal

Adds a help modal which is available on every view. The help help modal
can be accessed by pressing ? and overlays the current view. To leave
the help modal, the user can press ? or Esc.
This PR is based on #243 originally authored by @bIgBV. The previous PR
has been dormant for around a year.
Currently the help modal only displays a vertical list of controls. This
is the same information that is available in the controls widget on each
view.
Here is an example of the tasks view with the help view modal active:
connection: http://localhost:6669/ (CONNECTED)
views: t = tasks, r = resources
controls: select column (sort) = ←→ or h, l, scroll = ↑↓ or k, j,
view details = ↵, invert sort (highest/lowest) = i, scroll to top = gg,
scroll to bottom╭Help──────────────────────────────────────────╮t = q
╭Warnings───────│controls:                                     │───────────────╮
│⚠ 1 tasks have │  select column (sort) = ←→ or h, l           │               │
╰───────────────│  scroll = ↑↓ or k, j                         │───────────────╯
╭Tasks (12) ▶ Ru│  view details = ↵                            │───────────────╮
│Warn  ID  State│  invert sort (highest/lowest) = i            │t      Location│
│       19 ▶    │  scroll to top = gg                          │::task console-│
│       22 ⏸    │  scroll to bottom = G                        │::task console-│
│⚠ 1    23 ⏸    │  toggle pause = space                        │::task console-│
│       24 ⏸    │  toggle help = ?                             │::task console-│
│       25 ⏸    │  quit = q                                    │::task console-│
│       74 ⏹    │                                              │::task console-│
│       75 ⏸    │                                              │::task console-│
│       77 ⏸    │                                              │::task console-│
│       78 ⏸    ╰──────────────────────────────────────────────╯::task console-│
│       79 ⏹      wait      11s    4ms   56µs    11s 2     tokio::task console-│
╰──────────────────────────────────────────────────────────────────────────────╯

However, the idea is that the help modal can provide contextual
information depending on the view and the state of the application being
observed. This will allow us to provide more details about any lints
which are currently triggering and also to reduce the height of the
current controls widget to just one line (perhaps optionally) as the
full list of controls can be accessed from the help view.
Co-authored-by: bIgBV<EMAIL_ADDRESS>

My idea with the trait was to eventually do the same for the main view. It seemed like it would simplify things if we could return an object that implements MainView + HelpView or something like that and then render one or both depending on context.
I don't know if this is overengineering things though.

My idea with the trait was to eventually do the same for the main view. It seemed like it would simplify things if we could return an object that implements MainView + HelpView or something like that and then render one or both depending on context.
I don't know if this is overengineering things though.

That makes sense! If you're planning on continuing down this path in a subsequent PR, I think adding the HelpView trait now seems reasonable. If we try out a trait-object-based design and it doesn't work out, we can always change this code later, but I'm fine with merging this PR as-is.


tip doesn't compile

https://github.com/golang/go/commit/837984f37291f4fc48f9c99b65b0ab3f050bf4b9 broke tip:
......
cmd/link/internal/ld
cmd/asm
cmd/nm
cmd/objdump
# os/user
os/user/listgroups_unix.go:29: cannot use _cgo0 (type interface {}) as type unsafe.Pointer in argument to _cgoCheckPointer0: need type assertion
os/user/lookup_unix.go:56: cannot use _cgo0 (type interface {}) as type unsafe.Pointer in argument to _cgoCheckPointer0: need type assertion
os/user/lookup_unix.go:144: cannot use _cgo0 (type interface {}) as type unsafe.Pointer in argument to _cgoCheckPointer0: need type assertion
cmd/pack
cmd/internal/pprof/plugin
# net
net/cgo_unix.go:100: cannot use _cgo0 (type interface {}) as type unsafe.Pointer in argument to _cgoCheckPointer0: need type assertion
net/cgo_unix.go:144: cannot use _cgo0 (type interface {}) as type unsafe.Pointer in argument to _cgoCheckPointer0: need type assertion
cmd/internal/pprof/symbolz
cmd/internal/pprof/report
cmd/internal/pprof/symbolizer
......

Fix is in progress: https://go-review.googlesource.com/#/c/23961/

And fixed (sorry, I submitted before I saw this issue) (and sorry for the breakage).


Security issue fixes for sdk-generation-pipeline

Fixed the following critical dependabot issues:
https://github.com/Azure/azure-sdk-tools/security/dependabot/112
https://github.com/Azure/azure-sdk-tools/security/dependabot/147
https://github.com/Azure/azure-sdk-tools/security/dependabot/148

/check-enforcer override


Listings do not download files directly

Is your feature request related to a problem? Please describe.
It's weird when you're in a listing and you click a file link and a download starts. Especially when the listing has files and pages mixed together. It has no indication that a list item is a file.
Describe the solution you'd like
The link to the file should not download the file but go to the file view. In Plone Classic it's like this.
Describe alternatives you've considered
The downloadableObjects setting should be empty by default.

This is intentional (it's annoying to make users click through an extra screen to download the file) but note that similar to the Link content type, the intended behavior is different based on whether or not the user has permission to edit the item. Users who can edit the file should be taken to its view; other users should get the download immediately.
It's a fair point that we might want to make it more clear that the link will start a download.

@davisagli other systems deal with this better by having the link have on hover option to edit instead or an edit icon next to the link but only if you have permission to edit. Normal users just see the link. This means that the link does the same thing no matter who you are. This is less confusing.

This is intentional (it's annoying to make users click through an extra screen to download the file) but note that similar to the Link content type, the intended behavior is different based on whether or not the user has permission to edit the item. Users who can edit the file should be taken to its view; other users should get the download immediately.
It's a fair point that we might want to make it more clear that the link will start a download.

@davisagli if only it was that smart,
https://github.com/plone/volto/blob/481b9957b9e7cf5eeaed9a32e96a815f6a21a4c0/packages/volto/src/components/manage/UniversalLink/UniversalLink.jsx#L56
We don't really use any permission checking, we just have the check for token thus assuming this is how any logged in users should see something. This is something that I think Volto needs to develop better, an easier pattern of checking for permissions alongside a beefier validation system.
@wesleybl there is nothing special right now regarding listings and display of links,  everything goes through UniversalLink and there you have the downloadableObjects option.
I would be in favor of bringing behavior parity between Volto and Plone Classic but if this is a no go we should see about having maybe an icon added within UniversalLink to indicate that it's a download like there are icons to indicate it's an external link.
Don't know how the Volto team feels about this, worst-case scenario you add it to your own project but if you mockup something I'm sure it can get at least the conversation going.

@ichim-david I'd take that idea further and have a clock on that icon (or another one) let the logged in user view the content object. Clicking on the list itself then would work the same for everyone. This is much less confusing

@davisagli @wesleybl @djay I am all in favor of having options to change a default behavior in order to suit the needs of the users.
We could even have an option within the listing or search block to pass the downloadableObjects options and as such have it enabled on a case by case as needed.
Unfortunately unless we some more input from the @plone/volto-team I don't know what would be accepted by the larger core team. I expect most are busy now preparing for the Beethoven sprint.
I know that if someone has an idea it would be worth recording a video or posting some screenshots in order to see if there is any feedback on that proposal especially if we are talking about introducing front-facing changes for anonymous users.


Update workflow.yml

Added codecov to GitHu Action

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Need more robust information to explain why a response from the model was invalid and know I'm not in an undefined loop

Describe the bug
After asking a question to intercede on the initial (unsatisfactory plan), it seems as if I'm in some sort of loop :
"Invalid response from the model, trying again...
24.04.02 10:50:32: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 71202}
24.04.02 10:50:52: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 70863}
Invalid response from the model, trying again...
24.04.02 10:50:52: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 71760}
24.04.02 10:51:08: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 71385}
Invalid response from the model, trying again...
24.04.02 10:51:08: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 72300}
"
To Reproduce
Steps to reproduce the behavior:

Ask a question
Ask another question when it is Active
See above.

Expected behavior
I expect more console output to explain what is happening and when it is happening--a config VERBOSE="true" would be useful.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu
Browser Firefox
Version [e.g. 22]

ooof token usage :D

24.04.03 00:43:51: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 291755}
Invalid response from the model, trying again...
24.04.03 00:43:51: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 297391}
24.04.03 00:43:58: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 294960}
Invalid response from the model, trying again...
24.04.03 00:43:58: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 300647}
24.04.03 00:44:05: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 297908}
Invalid response from the model, trying again...
24.04.03 00:44:05: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 303749}
24.04.03 00:44:14: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 301448}
Invalid response from the model, trying again...
24.04.03 00:44:14: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 307070}
24.04.03 00:44:23: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 305445}
Invalid response from the model, trying again...
24.04.03 00:44:23: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 310729}
24.04.03 00:44:30: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 308266}
Invalid response from the model, trying again...
24.04.03 00:44:30: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 313969}
24.04.03 00:44:41: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 313296}
Invalid response from the model, trying again...
24.04.03 00:44:41: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 318104}
24.04.03 00:44:47: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 315421}
Invalid response from the model, trying again...
24.04.03 00:44:48: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 321234}
24.04.03 00:44:54: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 318597}
Invalid response from the model, trying again...
24.04.03 00:44:54: root: INFO   : SOCKET tokens MESSAGE: {'token_usage': 324387}
I also encounter the same problem, how to solve it?

Check your account with your LLM provider. They have hard limits on number of requests, context window, token usage, etc. Sometimes their error message in the API is cryptic like the one you're seeing. Also these LLMs go up and down randomly when heavily used during peak hours.

Describe the bug After asking a question to intercede on the initial (unsatisfactory plan), it seems as if I'm in some sort of loop : "Invalid response from the model, trying again... 24.04.02 10:50:32: root: INFO : SOCKET tokens MESSAGE: {'token_usage': 71202} 24.04.02 10:50:52: root: INFO : SOCKET tokens MESSAGE: {'token_usage': 70863} Invalid response from the model, trying again... 24.04.02 10:50:52: root: INFO : SOCKET tokens MESSAGE: {'token_usage': 71760} 24.04.02 10:51:08: root: INFO : SOCKET tokens MESSAGE: {'token_usage': 71385} Invalid response from the model, trying again... 24.04.02 10:51:08: root: INFO : SOCKET tokens MESSAGE: {'token_usage': 72300} " To Reproduce Steps to reproduce the behavior:

Ask a question
Ask another question when it is Active
See above.

Expected behavior I expect more console output to explain what is happening and when it is happening--a config VERBOSE="true" would be useful.
Screenshots
Desktop (please complete the following information):

OS: Ubuntu
Browser Firefox
Version [e.g. 22]

which model are you using??

I am using open llama local models. There is no token limit.
On Wed, Apr 3, 2024 at 3:22 PM James Snodgrass @.***>
wrote:

Check your account with your LLM provider. They have hard limits on number
of requests, context window, token usage, etc. Sometimes their error
message in the API is cryptic like the one you're seeing. Also these LLMs
go up and down randomly when heavily used during peak hours.
—
Reply to this email directly, view it on GitHub
https://github.com/stitionai/devika/issues/307#issuecomment-2035407421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFACJ5RGE3EY4ELKWBFVZWDY3RJGJAVCNFSM6AAAAABFTSX432VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGQYDONBSGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The same error

same...

fixed. fetch the latest changes. for more read the changelog in discord.


Chef Infra Client 16 Release

This is an epic to track the work and development effort associated with the Chef Infra Client 16 release.

SHIPPED!


Support pathlib.Path where file paths are expected

Hey hey :wave: would be cool to support pathlib.Path when paths to files are expected, e.g. in apply_file (probably in other functions, too). Workaround right now: str(Path("mypath")).
With a pathlib.Path we fail type checking right now:
Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/src/app/danisahne/cli/__main__.py", line 92, in <module>
    main(parser.parse_args())
  File "/usr/src/app/danisahne/cli/__main__.py", line 80, in main
    handler.apply_file(args.map)
TypeError: apply_file(): incompatible function arguments. The following argument types are supported:
    1. (self: osmium._osmium.SimpleHandler, filename: str, locations: bool = False, idx: str = 'flex_mem') -> None

Not urgent, not blocking; just :cherries: on top of the :cake: :hugs:

This is a Python3 only library. I'll leave this for after the next release when Python2 support gets dropped.


KOGITO-6181: Stunner-based editors are loosing focus when asked for the SVG

Hi @romartin can you review this PR? As discussed, unselection is disabled for SVG, PNG, JPG and PDF

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

@romartin @yesamer Hi guys! What's the status of this PR?

hey @tiagobento
As far as I know @inodeman is checking if export goes well again, as it's supposed selected elements should stay after export, but the exported image should not contain the selection stuff (eg: toolbox).
Please @inodeman let us know when this PR is ready for review again, or if you have any concerns please ping me.
Thanks!

Hi @tiagobento @romartin currently there are a couple of issues 1) It exports the toolbox 2) It selects the node in blue. See screenshot. I will let you know once it is fixed.

Hi @LuboTerifaj ready for review again. You can find Vsix here. in VSCode you export SVG from Menu: View->Command Palette-> Type svg and select "Generate SVG without any notification". A couple of nodes. Currently the selected nodes are exported to SVG File, this is a side issue that was present before. We can file a new Jira for it if needed. Thanks, let me know

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

Thanks @inodeman
@LuboTerifaj as Jaime commented above, this PR just fixes the elements being unselected once exporting. PLEASE this is a blocker issue, can you please give it some priority? Release is tomorrow.... Thanks a lot in advance!
Also I created a new ticket and assigned to @inodeman , about the already existing issue once exporting, which does not removes the blue borders. See https://issues.redhat.com/browse/KOGITO-6271
Thanks guys!

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

Hey @inodeman could you please check the failed build, or upload some vsix otherwise, so @LuboTerifaj can go ahead with tests? Thanks!!

Hi @romartin sorry seems the link did not paste before. Here it is https://drive.google.com/drive/folders/1G5UfG5aHqBHFX1RRYHErgnVNER9Felrw?usp=sharing

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

I added myself as reviewer to check DMN once PR is ready, reading comments it seems it is not ready for review yet.

Hi @ederign @jomarko @romartin please find Vsix for the build. I have tested it and to the best of my knowledge it complies with what we discussed on the call. Let me know. I will push changes shortly after I run all tests. https://drive.google.com/drive/folders/1G5UfG5aHqBHFX1RRYHErgnVNER9Felrw?usp=sharing

Hi @romartin tested the scenarios you mentioned and to the best of my knowledge, it is ready for review. Thanks

Hey @jomarko
Thanks for the pointer. In fact, the export (svg, png, etc) just "exports" what is in the canvas itself, so if at some point the DRDs are visible, it will export those. On the other hand, ti's a good Q - what should be really exported?
Anyway I would say just to create a ticket for this, this is not a regression and we're not chaning any scope here, so it's something that we should discuss properly, out from scope from this work IMO.

@LuboTerifaj @ederign
Wanna git it a try? Artifacts are generated properly. Would be nice having your checks as well please :)
Thanks!

Hello @romartin , @inodeman  thanks for the reminder, I am sorry but I was busy with other work as I already mentioned on our meeting. I will get to it this week. Thank you guys!

Hello @inodeman , could you please have a look at my comment in the KOGITO-6181 jira? Thanks!

Hi @LuboTerifaj added steps on Jira, let me know how it goes.

Hi @LuboTerifaj about the last issue reported, I did not change anything on the toolbox, I am pretty sure this bug also exists on main, so a new bug should be reported, let me know.

Hello @inodeman , I cannot reproduce the issue in the latest BPMN editor release version (Kogito Bundle VSCode extension v0.15.0).

Closed and reopened on new Repo


[WIP]test 12 dev rebase master

Build Failed  with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2025/

Build Failed  with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2026/


solidity language implemented for verify part lib in Ethereum

take the zk-rollup scenario is considered,  we may deploy the gnark verify part code in Ethereum, and L2 provide proof and public input and verify them in ETH.
so, maybe it is necessary to deploy the gnark verify lib by solidity code in ETH.

like the https://github.com/ConsenSys/gnark-tests/blob/main/solidity/contract.sol,
but seems it just for test purpose


Execute JS code when loading the page: in-context data is not accessible

The problem I think is that the action is called before the page finishes loading


PhanUnanalyzable example

phan is reporting "PhanUnanalyzable Expression is unanalyzable or feature is unimplemented." on the line I've highlighted with <<<< below.
$post should be an object (although it isn't type-hinted), which I suspect is the issue.

    /**
     * Work with post data after it is saved
     *
     * @param $post
     * @param null $oldPostStatus
     * @param null $oldPostPublishedAt
     * @param array $postData
     */
    protected function processAfterEvents($post, $oldPostStatus = null, $oldPostPublishedAt = null, $postData = []) {

        if (array_key_exists('republish', $postData) and isset($postData['republish'])) {
            $this->postRepublished($post, $oldPostPublishedAt);
        }

        if ($oldPostStatus === $post::POST_STATUS_PUBLISHED) {  // <<<<
            return;
        }
    }

I will be the first to agree that the code is pretty shitty. 😉
I'm just reporting the issue as instructed by phan.

Thanks! The shittier the code the better.

Harsh, man.  Harsh.  ;)

The following is a simpler expression of the unanalyzable code.
<?php
function f($p) {
    return $p::CNST;
}

I'm going to close this issue, as there just isn't much we can do with it.

Is static constant access from an object not supported in Phan? It's not a syntax error for PHP.

Its not supported in so far as Phan doesn't track values. Only types.
Its perfectly reasonable and correct PHP code, but outside of Phan's skill set.

Static constant access from a string isn't supported in phan. There's nothing we can do about that in the general case, phan tracks types, not string values
($p = 'MyClass'; return $p::CNST would emit PhanUnanalyzable)


v1.9.0 does not seem to be able to handle AWS Secret Manager secrets that are not KV (i.e. Plaintext)

Describe the bug
Cannot render secrets stored in AWS Secret Manager as type Plaintext (versus as JSON key/value), like so:
aws secretsmanager get-secret-value  --secret-id My-Secret-Plaintext
{
    "ARN": "arn:aws:secretsmanager:us-west-2:redacted:secret:My-Secret-Plaintext-vmapi",
    "Name": "My-Secret-Plaintext",
    "VersionId": "<REDACTED>",
    "SecretString": "myusefulinfohere",
    "VersionStages": [
        "AWSCURRENT"
    ],
    "CreatedDate": "2022-02-21T14:10:10.332000-05:00"
}

To Reproduce
Simple expansion YAML (numerous iterations attempted, including annotation-style):
kind: Secret
apiVersion: v1
metadata:
  info: <path:My-Secret-Plaintext#My-Secret-Plaintext>

Expected behavior
The SecretString, myusefulinfohere should be rendered.
Screenshots
Usage and error given:
./argocd-vault-plugin generate -s argocd-vault-plugin-credentials ./test.yaml
Error: Replace: could not replace all placeholders in Template:
invalid character 'c' after top-level `value`

I think you're running into the same issue reported here: https://github.com/argoproj-labs/argocd-vault-plugin/pull/182 - your secret string isn't JSON and therefore it can't be unmarshalled into a map, thus the cryptic error message.
At that the time we didn't accept that PR because we wanted to solve the problem in a better way. Not sure if @werne2j has had a change of thoughts since then. You can work around this by putting your secret into a JSON string and extracting the key you need with the jsonPath modifier, something like this: <path:My-Secret-Plaintext#My-Secret-Plaintext | jsonPath {.key-with-plain-value-you-need}

Ah yes, my mistake and apologies for opening a separate thread.

@barryib THX for mentioning. We moved away from vault-plugin to external secrets because of this issue.
I'd still promote my PR as a simple and clean solution for this problem.

Thanks @mms-gianni for your feedback. In our case, it's not possible for a particular use case to move to external secret because external secret support only secrets objects and not custom objects, while we do want to inject some parameters in CRD. This is why we can't for now move off avp.
In that way, Is it possible to reopen https://github.com/argoproj-labs/argocd-vault-plugin/pull/182 ?


Metric updates when timeout occurs

This PR fixes the following:

[X] #2451
[x] #2467
[X] #2469
[ ] "There is an inconsistency between send packets count and acknowledgements count in the displayed metrics."

This is Anca's comment from #2451, need to investigate further

[ ] Discover phase as described in #2451

Description

Even after a channel is cleared, oldest_* metrics can remain to the same value (i.e., not reset to 0).

I think we should clarify what the oldest_timestamp is, it seems this field is a local timestamp to the Hermes process, not an on-chain packet timestamp (when the packet was created), which is not clear from the telemetry help message, specifically:

There is an inconsistency between send packets count and acknowledgements count in the displayed metrics.

Previously, oldest_* metrics were not updated when a timeout would occur. The oldest_* metrics take their values from the sequences_histories map which was updated only when an ACK was received.
This PR handles the case of a timeout by calling record_ack_history when a timeout occurs.
The description of the oldest_* metric is also updated to incorporate the fact that the oldest_* is not only updated when an ACK occurs.

PR author checklist:

[x] Added changelog entry, using unclog.
[ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[x] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

I tested again and the bug is correctly fixed.


Synonymous Insertion before stop codon annotated as non silent insert

Testcase, genome GRCm38 over transcript ENSMUST00000086738
##fileformat=VCFv4.1
#CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO	FORMAT
# Synonymous Insertion of an AA and new stop codon before the original stop codon:
# TTC ATC TGA -> TTC ATA TAA ATC TGA
chr1	100484695	.	C	CATATAA	5000	.	.	.

Varcode annotates this as
Insertion(variant=chr1 g.100484695_100484696insATATAA, transcript_id=ENSMUST00000086738, effect_description=p.1291insI)
* aa_mutation_start_offset=1291
* aa_mutation_end_offset=1292
* aa_ref=''
* aa_alt='I'

This should instead be a Silent() effect.

In case you're wondering, I the variant that showed this bug in the cosmic VCF files, (GRCh38).
14   38210558     C       CGCTCTGAGCCCGGGCCACGCAGGG

Also, although this might seem far fetched, if the variant caller has a low gap penalty, it could choose to produce this kind of indel instead of a bunch of SNPs close by.


Error while evaluating property 'hasLocalAarDeps' of task ':camera_deep_ar:bundleDebugAar'

Error while evaluating property 'hasLocalAarDeps' of task ':camera_deep_ar:bundleDebugAar'
Direct local .aar file dependencies are not supported when building an AAR. The resulting AAR would be broken because the classes and Android resources from any local .aar file dependencies would not be packaged in the resulting AAR. Previous versions of the Android Gradle Plugin produce broken AARs in this case too (despite not throwing this error). The following direct local .aar file dependencies of the :camera_deep_ar project caused this error: /Users/nuoxmini/fahad/development/flutter/.pub-cache/hosted/pub.dartlang.org/camera_deep_ar-0.0.2+3/android/lib/deepar0.aar
gradle error

I am also facing the same problem and I am unable to find the solution.
Execution failed for task ':camera_deep_ar:bundleDebugAar'.

Error while evaluating property 'hasLocalAarDeps' of task ':camera_deep_ar:bundleDebugAar'
Direct local .aar file dependencies are not supported when building an AAR. The resulting AAR would be broken because the classes and Android resources from any local .aar file dependencies would not be packaged in the resulting AAR. Previous versions of the Android Gradle Plugin produce broken AARs in this case too (despite not throwing this error). The following direct local .aar file dependencies of the :camera_deep_ar project caused this error: C:\src\flutter.pub-cache\hosted\pub.dartlang.org\camera_deep_ar-0.0.2+3\android\lib\deepar0.aar

I have founf the solution you have to use lower version of gradle ie
Hi, if you do want to use this plugin set the following:
Your project build.gradle classpath :
classpath 'com.android.tools.build:gradle:3.5.0'
set your app.gradle to:
compileSdkVersion 29
minSdkVersion 21
targetSdkVersion 29
set your gradle/wrapper/gradle-wrapper.properties to:
distributionUrl=https://services.gradle.org/distributions/gradle-6.7-all.zip
this is a customized library for a particular feature i freely open-sourced!


Unable to create file \part_A_final/train_data\ground\IMG_1.h5

No description provided.

Do you have resolved the problem?

Did you get the solution for this issue? I am currently facing the exact same error.


Redirect after Request to Install submission for Slack App

After a Slack user submits a Slack app for review to install to the Slack workspace admins, that user gets redirected to the Slack App Directory page, instead of the specified redirect_uri in the OAuthSettings.
How can we fix that?
Reproducible in:
django-slack==5.19.0
slack-bolt==1.18.1
slack-sdk==3.26.1
Python 3.11.6
ProductName:            macOS
ProductVersion:         14.4.1
BuildVersion:           23E224
Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000

The slack_bolt version
slack-bolt==1.18.1
Python runtime version
Python 3.11.6
OS info
ProductName:            macOS
ProductVersion:         14.4.1
BuildVersion:           23E224
Darwin Kernel Version 23.4.0: Fri Mar 15 00:10:42 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6000
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., setup.py))
Slack OAuth configuration in our backend:
class SlackOAuthHandlerAPI(APIView):
    """API to handle slack oauth"""

    def get(self, request: HttpRequest) -> HttpResponse:
        """HTTP GET method"""
        success_url = f"{settings.FRONTEND_BASE_URI}/admin?slack_installation=success"
        failure_url = f"{settings.FRONTEND_BASE_URI}/auth/login"
        app = App(
            signing_secret=signing_secret,
            logger=log,
            oauth_settings=OAuthSettings(
                success_url=success_url,
                failure_url=failure_url,
                install_page_rendering_enabled=False,
                install_path="/api/oauth/slack/install/",
                redirect_uri_path="/api/oauth/slack/oauth_redirect/",
                client_id=client_id,
                client_secret=client_secret,
                scopes=scopes,
                user_scopes=user_scopes,
                # If you want to test token rotation, enabling the following line will
                # make it easy:
                # token_rotation_expiration_minutes=1000000,
                installation_store=DjangoInstallationStore(
                    client_id=client_id,
                    logger=log,
                ),
                state_store=DjangoOAuthStateStore(
                    expiration_seconds=120,
                    logger=log,
                ),
            ),
        )

        handler = SlackRequestHandler(
            app=app,
        )

        return handler.handle(request)

Configure a Slack workspace to require admin approval for installing a Slack app
Visit the App installation page: install-page.ngrok.app/api/oauth/slack/install/

Press "Submit"

Expected result:
Use the specific redirect_uri_path for redirecting the user.
Actual result:
User gets navigated to the Slack App Directory page for the Slack app.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @kennym, thanks for submitting this question, and we're sorry about our slow response here.
Unfortunately, there is no way to customize the behavior in this scenario. We can bring your feedback internally to the product management team, but I cannot tell whether and when some enhancement will come for this use case.
I understand this is not a satisfactory answer, but I hope this helps clarify.


Removed CICD docs.

Moving these docs to a repo that CI maintainers will have access to.

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+


Some quality-of-life enhancements

Make an actual Sequence
Support keys with .__index__()
Be more vague about allowed types

Actually, I think making it a real Sequence means this now works?
x, y = Vector2(4, 2)
assert x == 4 and y == 2


Update Gradle wrapper to 4.1

@friederbluemle
Could you update binary wrapper to the one from official gradle repo: https://github.com/gradle/gradle/blob/v4.1.0/gradle/wrapper/gradle-wrapper.jar
with following checksum
sha256sum gradle-wrapper.jar
2fe666278c4c937bef200572781334e4513237f74ad4c93f29247a3273f8b12b

@dotsbb Thanks for the reply. The gradle-wrapper.jar you linked is not the final version 4.1. It is the wrapper used by the Gradle project itself. They used to build 4.1, and it happens to be 4.1-rc-1, as you can see by looking at the associated .properties file:
https://github.com/gradle/gradle/blob/v4.1.0/gradle/wrapper/gradle-wrapper.jar
The gradle-wrapper.jar file I included in my PR was auto-generated by the wrapper task. There is a timestamp file inside of this jar, which is why the checksum changes every time it is generated. You can easily reproduce this locally by repeatedly running:
./gradlew wrapper --gradle-version 4.1 --distribution-type all

I think the issue is that someone could submit a malicious binary (unknowingly or intentionally)?

@d4rken yes. but in the same time I think about using something like https://github.com/int128/gradleupdate - Automatic Gradle Updater

@d4rken yes. but in the same time I think about using something like https://github.com/int128/gradleupdate - Automatic Gradle Updater

Google Cloud dependency doesn't sound too nice.
Anyways, we can merge this, while one should always be suspicious of binary files, I trust @friederbluemle here.


Add a slide about broadcasting to the presentation

I tried to keep it concise, let me know if it isn't clear enough.

Thanks, it seem good. Can you update the slide 6 to include in the list of what we will talk broadcasting and regenerate the pdf? amend the commit to prevent the git repo to become to big with binary files.

Oh, I missed that. I've updated the commit.

thanks


feat: fetching retrieves non-revoked keys for a payment pointer

Changes proposed in this pull request

When fetching payment pointer keys only non-revoked keys are returned

Context

fixes #1760

Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[ ] Documentation added
[x] Make sure that all checks pass
[ ] Postman collection updated

I have updated the getKeysByPaymentPointerId service function. I wasn't sure if I needed to include any filtering in the routes file where keys are returned based on deps.config.paymentPointerUrl === ctx.paymentPointerUrl
  deps: ServiceDependencies,
  ctx: PaymentPointerKeysContext
): Promise<void> {
  if (ctx.paymentPointer) {
    const keys = await deps.paymentPointerKeyService.getKeysByPaymentPointerId(
      ctx.paymentPointer.id
    )

    ctx.body = {
      keys: keys.map((key) => key.jwk)
    }
  } else if (deps.config.paymentPointerUrl === ctx.paymentPointerUrl) {
    ctx.body = {
      keys: [deps.jwk]
    }
  } else {
    return ctx.throw(404)
  }
}```

@JoblersTune good q, I would say we don't add any filters here because this is the key that is "issued" for the Rafiki instance itself (used when making inter-Rafiki requests, for example to get grants from another Rafiki instance). The key shouldn't be revoked, or some things might break.


s/Ctype/C./

I'm getting the following build errors with Go1.12beta1.
Also, goimports altered some whitespace.
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:22:17: identifier "_Ctype_xmlDocPtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:33:18: identifier "_Ctype_xmlNodePtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:45:18: identifier "_Ctype_xmlNodePtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:49:23: identifier "_Ctype_xmlAttrPtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:53:23: identifier "_Ctype_xmlNsPtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:65:18: identifier "_Ctype_xmlNodePtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:69:23: identifier "_Ctype_xmlAttrPtr" may conflict with identifiers generated by cgo
vendor/github.com/jbussdieker/golibxml/xml_wrapper.go:73:23: identifier "_Ctype_xmlNsPtr" may conflict with identifiers generated by cgo

I see that a few tests failed on travis, but I get the same failures locally with Go 1.11.4 on a643db2.

Thanks!


app/build.gradle does not seem to get updated

Hi! I would like to use this plug-in to update our versionCode and versionName using GitHub Actions, but I do not seem to be getting any results. I am new to using GitHub actions, and so I could be doing something wrong. The file I created is .github/workflows/android-version-action.yml and looks like this:
name: Bump the version code
on: [push]
jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - name: set up JDK 1.8
        uses: actions/setup-java@v1
        with:
          java-version: 1.8
      - name: Bump version
        uses<EMAIL_ADDRESS>        with:
          gradlePath: app/build.gradle # or app/build.gradle.kts
          versionCode: ${{github.run_number}}
          versionName: 1.0.0

This is the output of the "Bump version" step in the workflow:
Run<EMAIL_ADDRESS>  with:
    gradlePath: app/build.gradle
    versionCode: 4
    versionName: 1.0.0
  env:
    JAVA_HOME_8.0.302_x64: /opt/hostedtoolcache/jdk/8.0.302/x64
    JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.302/x64
    JAVA_HOME_8_0_302_X64: /opt/hostedtoolcache/jdk/8.0.302/x64
Gradle Path : app/build.gradle
Version Code : 4
Version Name : 1.0.0
Successfully override version code 4
Successfully override version code 1.0.0

I would expect the build.gradle file to contain versionCode 4 and versionName 1.0.0 but nothing seems to have happened. Thanks for making this plug-in and I appreciate any help or support!

Hi, would like to check is the output apk updated with the new version code and version name?
can check with this command
$ANDROID_HOME/build-tools/28.0.3/aapt dump badging app/build/outputs/apk/app.apk

Hi! I ran the command and the output was:
package: name='com.example.app' versionCode='5' versionName='1.0' compileSdkVersion='30' compileSdkVersionCodename='11'
5 and 1.0 are the values that I specified in the build.gradle file.

yap that sounds good,
this plugin is to override the version code and version name without making changes to the repository code, it will not update build.gradle file

Understood! I was wondering; where would the APK be located? We currently don't upload our builds to any hosting server, so I'm not sure where to find the APK that has the updated versionCode and versionName. Thanks again for making this plugin!

You will need another plugin to upload the apk to the github action storage and download it from the action dashboard
Github Action Upload Plugin : https://github.com/marketplace/actions/upload-a-build-artifact
Attached a sample workflow snippet for your reference
    - name: Bump version
      uses<EMAIL_ADDRESS>      with:
        gradlePath: app/build.gradle.kts
        versionCode: ${{github.run_number}}
    - name: Build debug APK
      run: ./gradlew assembleDebug --stacktrace
    - name: Upload a Build Artifact
      uses<EMAIL_ADDRESS>      with:
        # Artifact name
        name: debug-${{github.run_number}}.apk # optional, default is artifact
        # A file, directory or wildcard pattern that describes what to upload
        path: app/build/outputs/apk/debug/*.apk

Thank you so much @chkfung ! I will give this a try shortly!

Hey @chkfung ! I was able to use your plug-in successfully! For reference, this is the YAML file that I used, and which uploaded an .APK file to GitHub successfully:
name: Bump the version code and upload an APK file
on: [push]
jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2
      - name: set up JDK 11
        uses: actions/setup-java@v2
        with:
          java-version: '11'
          distribution: 'adopt'
      - name: Build debug APK
        run: ./gradlew assembleDebug --stacktrace
      - name: Bump version
        uses<EMAIL_ADDRESS>        with:
          gradlePath: app/build.gradle
          versionCode: ${{github.run_number}}
          versionName: 1.0.0
      - name: Upload a Build Artifact
        uses<EMAIL_ADDRESS>        with:
          # Artifact name
          name: app-debug_${{github.run_number}}.apk # optional, default is artifact
          # A file, directory or wildcard pattern that describes what to upload
          path: app/build/outputs/apk/debug/*.apk

Awesome work! My team will be very happy!

Glad it helps,
thanks for the feedback and will check for the error you hitting

Hey @chkfung, thanks for the plugin.
Is it feasible for you to put replaceAll in place of newGradle = newGradle.replace(versionCodeRegexPattern, $1${versionCode}); and same for versionName because we have multiple productFlavours with each flavour having its own versionCode and versionName, but it only replaces just the first occurrence.


I can't return my own errors class in onError interceptor

Request Statement
So, I don't want to have to extend DioException. I want to be able to use interceptors to handle DioException errors with my own error class that extends Exception without dying trying. But it definitely doesn't work. There is no information about this in the documentation. I have a package that is an api and I don't want the applications that use it to have to install Dio just to handle DioException or in the worst case if I changed to Dio for whatever we would have to make a big change.
Solution Brainstorm
// ##########################
// # ErrorHandle Middleware #
// ##########################

interceptors.add(
  InterceptorsWrapper(
    onError: (DioException error, ErrorInterceptorHandler handler) {
      switch (error.type) {
        case DioExceptionType.badResponse:
          // throw ApiException.fromBadResponse(response);
          return handler.reject(_handleBadResponse(error));
        case DioExceptionType.connectionError:
          // // throw ApiException.fromBadResponse(response);
          return handler.reject(_handleConnectionError):

        default:
          return handler.reject(error);
      }
    },
  ),
);

Thanks, duplicate of https://github.com/cfug/dio/issues/1950 - please follow up there.


structs in included files are marked as "unresolved imports"

How can I ask rust-analyzer to look at the contents of rust code I have include!-ed?

I have a lot of unresolved imports for which I cannot use Goto definition
Also I don't get suggestions for imports from these included files

(I am not using VSCode though I guess that is not relevant here most probably. Also these files will compile properly -- its just that rust analyzer needs to be made aware of these included files)
Interestingly CLion will allow you to goto definitions in included source and I believe it also gives import suggestions from included files.

Do you use env!("OUT_DIR")? If so you need to set "rust-analyzer.cargo.loadOutDirsFromCheck": true.

Thank you. I believe this would need to go into settings.json perhaps? Where do I put this settings.json so that rust analyzer picks it up? (I'm not using VSCode)

The place where you have to put settings depends on your editor, so I'd recommend consulting the documentation of (the LSP integration of) that editor.

Sorry if I should create a new issue instead of necroing this one, but I'm running into this issue using VSCode v1.51.1 and Rust-Analyzer v0.2.408.
I'm using rust-bindgen with a wrapper file bindings.rs:
#![allow(non_upper_case_globals)]
#![allow(non_camel_case_types)]
#![allow(non_snake_case)]

include!(concat!(env!("OUT_DIR"), "/rust_bindgen.rs"));

I'm getting unresolved imports from this line in another source file:
use crate::bindings::{foo, bar};

Specifically the foo and bar parts are failing, bindings resolves properly. I have "rust-analyzer.cargo.loadOutDirsFromCheck": true, in my workspace file and cargo build passes when run from the shell.
Interestingly, if I Ctrl+Click (go to definition) on foo it will open up rust_bindgen.rs at the correct location.

@dfarley1 A new issue would probably be better, and it'd be great if you could provide a full example reproduction of the problem.

@flodiebold Turns out I didn't have "rust-analyzer.procMacro.enable": true set, I got the hint from the list of known issues in the "New Issue" template, thanks!


Enhance to get a random ID functionality

The getRandomID method of the IDUtils class of the nstarlike.javautils.credential package returns a random ID which are suffixed four random numbers. I feel not quite satisfied with this. I think we should make it better to get more relevant IDs with the input ID. But we have a limitation, for example we cannot include a huge dictionary. So I think we should just make some core funtionality with some sample data. After that, as changing the interface, we can use this functionality in production perfectly.
First of all we need some algorithm to get a relevant word or something.
And then we have two options for nominees.
First, we can use a Database system.
Secondly, we can use a file or files. (I think this is more proper.)
Good luck!

Previously I said that we could use a file but on second thought, using a file is not good. Because we should check if the recommendations are not used by other users.

Finally, I decided how we would develop this.
After a long fondering, it is better to write interfaces for interfacing with databases or files.
Therefore, we need to write an interface to get candidates, and of course, implementations of the interface, too.
And then we need to write an interface to pick out used ids from candidates.
Let's play~ :joy:


CentOS 7.1 won't run ubuntu containers with overlayfs

Couldn't find this issue filed elsewhere, could be related to 10294, but it doesn't seem to have anything to do with XFS.
When running docker 1.8 on CentOS 7.1 with the overlay storage driver, it won't start any ubuntu containers.  This is always the output:
Error response from daemon: mkdir /var/lib/docker/overlay/935550f5b524ff8835c5a6c1512cd1d5cf4a43125fd6da9c50361ce888908dd1-init/merged/dev/shm: invalid argument
Tried ubuntu:14.04 and phusion/baseimage which is based on that, both have the same error.  CentOS 6 and 7 containers seem to run fine.  I tried with both an ext4 and an xfs filesystem, and they both have the same error.
Docker info:
docker version
Client:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:19:43 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:19:43 UTC 2015
 OS/Arch:      linux/amd64

docker info
Containers: 4
Images: 17
Storage Driver: overlay
 Backing Filesystem: xfs
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.10.0-229.7.2.el7.x86_64
Operating System: CentOS Linux 7 (Core)
CPUs: 4
Total Memory: 15.52 GiB
Name: vcp-centos7
ID: F5GZ:V72D:2KI6:3HXS:SAGQ:VFYV:SLYQ:IDGE:LEBE:XOP7:DCGC:ZJQF

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Overlay seems broken in CentOS 7.1. Same error in docker 1.7.1 as well.
Simple reproducer:
mkdir lower upper work merged
mount -t overlay overlay -olowerdir=lower,upperdir=upper,workdir=work merged
touch lower/foo
rm merged/foo
mkdir merged/foo <- Invalid argument

I see no differences from #10294, I think we can close this.

Agreed. I'm going to close this issue as it is a duplicate of https://github.com/docker/docker/issues/10294. @vbtnickn you can subscribe to that issue (using the subscribe button), to get notified of changes there

I have subscribed to the other issue.  The only reason I had filed this one is that 10294 seemed to be about overlay not working with xfs.  But it doesn't seem to be about xfs at all.  Overlay does work in some situations, but not others.  Like I said, I can run and remove CentOS containers on CentOS with overlay just fine.

I am seeing this on Ext4 as well.  So it seems as if 10294 should be merged into here, instead of the other way around.

https://bugzilla.kernel.org/show_bug.cgi?id=108811


Java Concurrent plugin not handling ScheduledExecutorService.schedule

Made a dummy application using Scala:
package me.milan.debug

import java.util.concurrent.{Executors, TimeUnit}

import co.elastic.apm.api.ElasticApm
import co.elastic.apm.attach.ElasticApmAttacher

import scala.jdk.CollectionConverters._

object ScheduledES {

  val configuration: Map[String, String] = Map(
    "service-name" -> "apm-playground",
    "application_packages" -> "me.milan",
    "log_level" -> "INFO"
  )

  ElasticApmAttacher.attach(configuration.asJava)

  def main(args: Array[String]): Unit = {

    val transaction = ElasticApm.startTransaction()

    transaction.activate()

    println(s"Started: ${ElasticApm.currentTransaction().getId}")

    val f = Executors.newScheduledThreadPool(2).schedule(
      new Runnable {
        override def run(): Unit = println(s"Scheduled: ${ElasticApm.currentTransaction().getId}")
      },
      1,
      TimeUnit.SECONDS
    )

    while(!f.isDone) {
      println("Waiting")
      Thread.sleep(500)
    }

    println(s"Finished: ${ElasticApm.currentTransaction().getId}")

    transaction.end()

  }

}

gives
2020-04-14 11:25:04.970 [elastic-apm-server-healthcheck] INFO co.elastic.apm.agent.report.ApmServerHealthChecker - Elastic APM server is available: {  "build_date": "2020-03-26T04:23:50Z",  "build_sha": "8827b43d24eaf42391ea815bb9fa12bdef5d6bce",  "version": "7.6.2"}
2020-04-14 11:25:09.995 [Attach Listener] INFO co.elastic.apm.agent.util.JmxUtils - Found JVM-specific OperatingSystemMXBean interface: com.sun.management.OperatingSystemMXBean
2020-04-14 11:25:10.077 [Attach Listener] INFO co.elastic.apm.agent.configuration.StartupInfo - Starting Elastic APM 1.15.0 as ScheduledES on Java 13.0.1 (AdoptOpenJDK) Mac OS X 10.15.3
2020-04-14 11:25:10.085 [elastic-apm-remote-config-poller] INFO co.elastic.apm.agent.configuration.ApmServerConfigurationSource - Received new configuration from APM Server: {}
2020-04-14 11:25:10.087 [Attach Listener] INFO co.elastic.apm.agent.impl.ElasticApmTracer - Tracer switched to RUNNING state
Started: 0b58537471862cc0
Waiting
Waiting
Waiting
Scheduled:
Finished: 0b58537471862cc0
2020-04-14 11:25:14.931 [elastic-apm-init-instrumentation-shutdown-hook] INFO co.elastic.apm.agent.impl.ElasticApmTracer - Tracer switched to STOPPED state
2020-04-14 11:25:14.931 [elastic-apm-init-instrumentation-shutdown-hook] INFO co.elastic.apm.agent.report.ApmServerReporter - dropped events because of full queue: 0
2020-04-14 11:25:14.942 [elastic-apm-init-instrumentation-shutdown-hook] INFO co.elastic.apm.agent.report.IntakeV2ReportingEventHandler - Reported events: 1
2020-04-14 11:25:14.942 [elastic-apm-init-instrumentation-shutdown-hook] INFO co.elastic.apm.agent.report.IntakeV2ReportingEventHandler - Dropped events: 0
2020-04-14 11:25:14.943 [elastic-apm-circuit-breaker] INFO co.elastic.apm.agent.impl.circuitbreaker.CircuitBreaker - Stopping the Circuit Breaker thread.

The tracing context is not passed on a schedule method. Would this make sense to add to the java-concurrent plugin?

Propagating the context for java.util.concurrent.ScheduledExecutorService#schedule(java.lang.Runnable, long, java.util.concurrent.TimeUnit) makes sense, I think.
I'm a bit sceptical about java.util.concurrent.ScheduledExecutorService#scheduleAtFixedRate and java.util.concurrent.ScheduledExecutorService#scheduleWithFixedDelay, however.

Is there a specific reason you are sceptical about the repeating scheduled actions?
I've never used it but I can imagine that someone may want to trace for example a health-check by starting a transaction, and then schedule a repeating request to make sure an external service is healthy.

I'd argue that those repeated health checks are traces that stand on their own. When looking at the trace for the initial transaction that has started the health check, would you like to see a waterfall that possibly spans multiple days?

No, I agree with what you just said :)

@felixbarny As I understand from https://github.com/elastic/apm-agent-java/pull/1206, this issue can be closed as well now?

Indeed


Specify branch/tag of a repository when generating the definition for a new module

Preparing the provisioning in AWS, with this addon for KubeVela, we need to be able to generate new componentdefinitions of a module in GitHub based on a branch/tag.
Currently we can only specify the url of the repository and the path of the module.
Can you consider adding this new functionality to your roadmap?
Could be an example?
apiVersion: terraform.core.oam.dev/v1beta1
kind: Configuration
metadata:
  name: aws-s3
spec:
  remote: https://github.com/kubevela-contrib/terraform-modules.git
  branch: your_branch
  path: aws/s3

  variable:
    bucket: "vela-website-aws-202101019"
    acl: "private"

  providerRef:
    name: aws
    namespace: default

  writeConnectionSecretToRef:
    name: s3-conn
    namespace: default

Hi @davma-io! This is reasonable. I'd like to add this to roadmap. But due to the time I can't guarantee the time to complete. Would you like to help?

I would like to help, but my knowledge of low level addon operation is limited. I would not have time available until the beginning of August. And after that it would be limited. I could especially contribute with the consolidation tests.

@davma-io You can use the v0.8.0 to do the test. https://github.com/kubevela/terraform-controller/releases/tag/v0.8.0 Any feedback are welcome :)

Hi @chivalryq
In order to test it, I need version 0.8.0 to be available to deploy from the helm terraform-controller chart.
Either that or I can deploy it with the official addon from KubeVela if the docker-controller image is updated. We need a more updated version of terraform to use some modules.
I leave a pull request to review, if you consider it, in the docker-terraform repository.
#https://github.com/oam-dev/docker-terraform/pull/22
Currently I have the addon deployed as follows:`
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: terraform-controller
  namespace: vela-system
spec:
  components:
    - name: terraform-controller
      type: helm
      properties:
        repoType: "helm"
        url: "https://charts.kubevela.net/addons/"
        valuesFiles:
          - "values.yaml"

replicaCount: 1

image:
  repository: oamdev/terraform-controller
  tag: 0.7.10
  pullPolicy: Always

gitImage: alpine/git:latest
busyboxImage: busybox:latest
terraformImage: ghcr.io/activa-prefapp/docker-terraform:1.5.5
controllerNamespace: ""

# "{\"nat\": \"true\"}"
jobNodeSelector: ""

resources:
  limits:
    cpu: "500m"
    memory: "500Mi"
  requests:
    cpu: "250m"
    memory: "250Mi"

backend:
  namespace: vela-system

githubBlocked: "'false'"

featureGates:
  # Enable the feature of allowing to delete a configuration whose cloud resources is not fully provisioned, or error happens
  # This guarantees that the partial cloud resources will be deleted when the configuration is deleted
  # Default value is true
  AllowDeleteProvisioningResource: true

"https://charts.kubevela.net/addons/" is no longer maintained and is depracated. New charts repo: https://github.com/kubevela/charts. See usage in it. I'll check the PR.

Thank you. All updated and deployed to version 0.8.0. I will run the tests tomorrow and post the results here if they are correct.

Hi @chivalryq
The PR has been effective, now we can select different references from the repository to deploy.
But we can only use this new feature if we directly apply a kind:Configuration.
If we try to configure a new module for terraform by means of a ComponentDefinition the result is the following one:

Error from server (BadRequest): error when creating "/modules-definition/terraform-aws-s3.yml": ComponentDefinition in version "v1beta1" cannot be handled as a ComponentDefinition: strict decoding error: unknown field "spec.schematic.terraform.gitRef"

Could you modify core.oam.dev/v1beta1@ComponentDefinition to support these changes?

https://github.com/kubevela/kubevela/pull/6363 Will do this.


Shoot deletion should not wait for ControlPlane if it already has a deletionTimestamp

How to categorize this issue?

/area ops-productivity robustness
/kind bug
/priority 3
What happened:
When a Shoot is deleted and the corresponding extensions.gardener.cloud/v1alpha1.ControlPlane resource already has a .metadata.deletionTimestamp then we should not wait for its reconciliation to be finished.
This is intended to be implemented here and was introduced with https://github.com/gardener/gardener/pull/3960: https://github.com/gardener/gardener/blob/38ad556a7dec689b35c3ee6dd3cf59bd64b5c705/pkg/gardenlet/controller/shoot/shoot_control_delete.go#L643-L648
However, this only returns false when the kube-apiserver deployment is not found.
What you expected to happen:
It should return false even if the kube-apiserver is still running and not wait for a ControlPlane reconciliation.
Environment:

Gardener version: v1.32.0
Kubernetes version (use kubectl version): all
Cloud provider or hardware configuration: all

I just have a worry that this might cause a problem when #4584 is merged. I will have time to test it out today file a PR if there are no issues.


Mobile bot not detected

Hi Guys,
Today we just had a request from a client why google isn't detecting our mobile websites and we tracked down the problem to the User_agent.php library.
It seems CI isn't able to detect a mobile client if it's a bot as first it checks for bot and if bot found it will simply exit and not continue checking and so it will never recognize it as mobile if it is a mobile bot.
This bug affects both CI Stable and Dev version and can be easily fixed by checking for mobile user agent too even if bot is recognized:
CI 2.2.1
system/libraries/User_agent.php - _compile_data() # 148
if ($this->$function() === TRUE)
{
break;
}
CHANGING to will fix the problem:
$this->$function();
You can check the functionality of this bug/fix here:
https://www.google.com/webmasters/tools/mobile-friendly
Regards,
Julius

I consider this lack of a feature, not a bug - a robot is not a mobile device.
Anyway, this feature was added in CI3.0. You'll have to upgrade if you want to use it.

Hi Narfbg,
Can you please point me to the fix in CI3 that you are talking about? also if I may ask, how isn't this a bug? isn't we (CI) doing something wrong for not detecting the mobile bot on google? I don't think you can say that google is the one to blame on this.
Regards,
Julius

I'm not pointing you to a "fix" so you can copy-paste it - that would be to encourage a user to manually modifying the system/ files and I don't want to do that, especially given that there already is a newer version of the framework that you can simply update to.
And no, skipping the mobile check for a robot is not something wrong, I already explained why in my previous comment. And I'm not blaming Google either, as I said - it's a feature that simply doesn't exist in CI2, not a bug.

I'm not requesting for the fix on CI3 to copy/paste (have better things to do than modifying system files that's why I report you guys the problems so I don't have to touch core files) the reason I ask for you to point me to a fix is that I can see how you fixed it and what you did.

Ok, I see what you did, you added
$this->_set_mobile();
to the _set_robot() method too if it founds out it is a robot which is great, tested in CI3 and can confirm that it works there but may I know why you aren't willing to fix this in CI2? did you give up on CI? as if you remember my other case it isn't as easy as you say to upgrade to CI3 and if you did give up on CI2 we will need to fork CI3 and start to work on that ourselves.
Regards,
Julius

What's with the accusations? narfbg and the volunteers to this did not "give up" on CI2. As any worthwhile versioning system goes; enough changes were made to CI that CI2 is and or will be no longer supported.
Do you and your clients a favor and update to the new CI version.

Hi LouisMilotte,
Ok, got it, that's what I wanted to know that you indeed gave up support on CI2. I don't mind at all as it's your choice so you can do it freely without any problem I just needed to know this as we have around 500 sites running on CI2 and I can't upgrade them to CI3 just by replacing system files as for e.g. you dropped controller recognition for lowercase files in CI3 so that means we will need to rename all those files for each website not to mention some other changes in CI3 that you dropped so it won't be backward compatible.
But again, I'm not accusing you guys of anything, it's your project so you can take whatever road you wish I just needed to know that CI2 won't be supported anymore.
Thanks,
Julius

Fixing is for things that are broken, and for the 3rd time - it's not a bug, it's not broken, it's just a feature that you wish it had.
And if you're asking if we've given up on including new features into CI2 - yes, we've given up on that years ago and not a single new feature has been included into the 2.x version tree since 3.0 development started. New features go into newer versions, not the old ones - it's as simple as that.

Hi Guys,
Got it and thanks for the update, exactly what I wanted to know!
Regards,
Julius


Load the locker on first run

When adding the rebble account when setting up the app for the first time, after you are done with initial setup, the locker is empty. It should be prefilled with contents of the locker from the server

+1


literally v2

101 additions and 1,678 deletions.

👓 @schwers and @nramadas
Nukes old-src, moves lodash and superagent to peerdeps, nukes reddit-text-js and implements markdown processing directly.
Plan is to set npm latest tag to 1.x, and tag this as next. Use this diff to create a "2.x" branch.

disregard, re-PRing without restcache


⚠ Processors has degraded performance

In d4bf804, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 57 ms

Resolved: Processors performance has improved in 1316ef6.


CVE-2022-22950: Spring Expression DoS Vulnerability

Description:
In Spring Framework versions 5.3.0 - 5.3.16 and older unsupported versions, it is possible for a user to provide a specially crafted SpEL expression that may cause a denial of service condition.
Package: lib/runtimes/cxf3/spring-beans-5.1.2.RELEASE.jar
Is the product affected by this vulnerability? If so, is it possible to provide a mitigation or the steps required to upgrade the library?
Affected product version:
API Manager 3.1.0 / 3.2.0 / 4.0.0
Identity Server 5.10 / 5.11

Any news about this?

Hi,
Spring upgrades are done in the latest API Manager updated packs (ex: APIM 4.0.0 latest updated pack has spring-beans-5.3.18) . Please take the latest updated packs to resolve this.
https://updates.docs.wso2.com/en/latest/updates/overview/

Hi.
Thanks for the answer. Anyway, what about the WSO2 Identity Server?
Even if we upgrade the APIM components, as per compatibility matrix we must use the version 5.11, wich is affected by the vulnerability.

Hi,
Latest updated packs of WSO2 Identity Server 5.11.0, as well as 5.10.0, has this cxf version upgrade


Circular dependency between tasks caused by Spring Boot native build

🐛 Describe the bug
When Spring Native build is used ("org.graalvm.buildtools.native") Gradle complains about circular dependency.
⚠ Current behavior
Circular dependency between the following tasks:
:classes
\--- :compileJava
     \--- :compileKotlin
          +--- :ktfmtCheckAot
          |    \--- :processAot
          |         +--- :classes (*)
          |         +--- :compileJava (*)
          |         +--- :compileKotlin (*)
          |         \--- :resolveMainClassName
          |              +--- :classes (*)
          |              +--- :compileJava (*)
          |              \--- :compileKotlin (*)
...

✅ Expected behavior
I expect it to pass
💣 Steps to reproduce
Clone https://github.com/lukas-krecan/ktfmt-native and run ./gradlew check
The project was genberated by https://start.spring.io/ and ktfmt plugin added, nothing special.

Thansk for the repro @lukas-krecan, this was really valuable in helping me fix this.


Explore bugs happening in the state right after git init

This is a notoriously weird state of the repo:
➜ 22:45 /tmp/foo $ git init
Initialized empty Git repository in /tmp/foo/.git/
➜ 22:46 /tmp/foo master $ cat .git/HEAD
ref: refs/heads/master
➜ 22:46 /tmp/foo master $ ls .git/refs/heads/
➜ 22:46 /tmp/foo master $

So HEAD points to master... but master is not even a branch yet 🤦🏻
There's surely gonna be a bunch of bugs around this state... one that I could see is that Discover dialog shows an empty tree but still asks to Save/Save&Edit. Discover action could be just disabled in that state (and a few other actions possibly as well).

@mkondratek can we consider this closed?

Yes. As I mentioned in the PR - now all the bugs will be consistent with the ones from IntelliJ VCS 😆


1.17 Fabric?

Description
As far as I'm aware, this mod is only for 1.16 for fabric. When is it getting 1.17? I haven't tested it yet though
Proposed behaviour
It gets support for 1.17

I think it works tho, even tho the actually API depend is not updated to 1.17, as long as no breaking change I don't see an issue.

I think it works tho, even tho the actually API depend is not updated to 1.17, as long as no breaking change I don't see an issue.

No, I saw that there was a recently (27 days ago) merged patch that fixed a crash for 1.17 but afaik it's not in any release version.

Yea its fixed and can be downloaded at https://luckperms.net/download

so why does it still say 1.16.4?

API dependency is not updated to 1.17, so officially it's not running on 1.17. But there is no change that is breaking. (or at least those has been workaround as you stated) Are you facing an issue with luckperms on fabric?

Nope.


fix: click subgrid commands

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (updates to documentation, formatting, etc.)

Description
Updates the selectors in use to find subgrid command bar buttons.
Issues addressed
Resolves #1196. A recent update has caused this functionality to break.
All submissions:

[x] My code follows the code style of this project.
[x] Do existing samples that are effected by this change still run?
[x] I have added samples for new functionality.
[x] I raise detailed error messages when possible.
[x] My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

@ewingjm I had the same issue for main CommandBad ClickCommand:
Could you plase apply the ame fix for:
internal BrowserCommandResult ClickCommand(string name, string subname = null, string subSecondName = null, int thinkTime = Constants.DefaultThinkTime)

@ewingjm - Do you know if this was Release Wave 2 specific? or a different update? I noticed the commits mention Release Wave 2, however some of your other PRs specifically stated it was not tied to RW2.
If this is not tied to RW2, please let me know as soon as possible.

@ewingjm - Do you know if this was Release Wave 2 specific? or a different update? I noticed the commits mention Release Wave 2, however some of your other PRs specifically stated it was not tied to RW2.
If this is not tied to RW2, please let me know as soon as possible.

Hi @TYLEROL. Sorry, I should've been more explicit on this one. None of my pull requests at the moment are to do with wave 2. They've all been tested on a UK region environment over the last couple of days on 9.2.21091.00134.
I have a separate branch I'm working on to resolve all of the wave 2 issues that our automated test suite has caught.


Clans Enemy / Ally Remove Ability Not working

When i try and do either "/clan enemy remove clanname" or "/clan ally remove clanname" it comes up with an internal error. I have made a fresh new instance of clans with the new update to test but im getting the same result.

Fixed in discord support.


Remove travis multi-os configuration

Multi OS support is a beta product and as a result it has to be requested and enabled for specific repositories. This makes it difficult for a user when they fork with the intention of submitting a PR. This change removes this dependency & instead just sets language to objective-c as this will ensure that an osx environment is used and since fsevents needs an osx environment and no other this results in the same behaviour.

There seems to be an issue preventing me from authorizing clahub so I am unable to sign the CLA.

Still having trouble with the CLA? @bajtos is this something you can help with?
The PR LGTM

@es128 yep still unable to get it to work correctly. Is see the below after authorizing my account via Github.

Wish I could help. Someone @strongloop is going to have to address it.

fsevents is an adopted project so I don't think we need a CLA.  @rmg Can you turn off the CLA check for this repo?
The PR itself LGTM but I'm not a Travis expert.

I'll see about removing it. It is unfortunate that what seems to be causing the trouble is the switch to an unprivileged scope for the GitHub auth.

I've removed the project from our CLA, but the failure status on this PR won't be reset unless a new commit is pushed.

Prob doesn't matter. We can just merge, right?

Ya, just ignore the CLA warning.


fix gateway with different bind to have same host

fix https://github.com/istio/istio/issues/40268
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @shonecyx. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@shonecyx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shonecyx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
46673bc2cc1ae8ec61174b77071bdd4422b294f2
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali PTAL

LGTM. @howardjohn PTAL

/cherrypick release-1.14

/cherrypick release-1.15

@GregHanson: new pull request created: #40461

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GregHanson: new pull request created: #40462

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


@azure/apimanagement-custom-widget-scaffolder

created new package "@azure/apimanagement-custom-widget-scaffolder"

/azp run prepare-pipelines


Certain URLs cause Maximum call stack size exceeded

domutils/lib/traversal.js:22
exports.getName = function(elem){
RangeError: Maximum call stack size exceeded
at Object.exports.getName
This also occurs with some of the other urlmetadata modules on npm, specifically node-MetaInspector

This appears to still be an issue

It is. https://lnkd.in/gVeYnv7 is an example that causes this error.

This appears to still be an issue

It is. https://lnkd.in/gVeYnv7 is an example that causes this error.


update projets to .netstandart2.1 and .netcoreapp3.1 (Signed-off-by: H de Labareyre<EMAIL_ADDRESS>

Just update framework target as these .net libraries are about to be not supported.

Hello,
According to this documentation, .NET Framework is far from being deprecated. Updating to netstandard2.1 would entirely drop its support, and this is not something we want. That said, netcoreapp2.0 is indeed deprecated, and upgrading the test project to netcoreapp3.1 makes sense.
Regarding the .NET Standard version, were you motivated by a specific need? As far as I'm aware of, any project that is compatible with netstandard2.1 will be compatible with netstandard2.0, but there might be a case I don't see. 🙂

Hi,
Indeed thank you for the precision!
.netcoreapp2.0 is the framework that is deprecated. If we wish to update the test project to netcoreapp3.1, we must update the library to netstandard2.1according to this documentation.
I don't see any regression using .netstandard2.1, and I have executed unit tests.
What motivated me to do this were 2 reason :

Using the project for a solution made up of other netcoreapp3.1 projects
Execute the unit tests on VS 2019 as test execution did not work when the project was compiled with netcoreapp2.0

Ok for the sign-off part, I've modified the pull request. Do you wish to have it in the commit comment or in the pull request title ?
Regards,

The documentation you linked lists the minimum compatible versions:

netstandard2.0 is compatible with all versions of .NET Core after netcoreapp2.0
netstandard2.1 is compatible with all versions of .NET Core after netcoreapp3.0

Which is equivalent to:

netcoreapp2.0 is only compatible with netstandard2.0
netcoreapp3.0 is compatible with both netstandard2.0 and netstandard2.1

In your situation, you should be able to use this library on a netcoreapp3.1. 🙂 have you experienced issues installing the NuGet package?


[TK-12] Add the "View Author" page

Pull Request
Story ID: [TK-12]
Title: Add the "View Author" page
Card URL: https://trello.com/c/1WWUFWh6
Author: @flukekd

Delete author


Add components composer file descriptions

Hi!
Regarding Issue #423 this PR adds specific description for each component composer file.
Please let me know if anything needs to be changed as I don't have a full understanding of each of their responsibilities.
Thanks!

Thanks! This is a good start, I'll probably finetune it along the way :)


Convert to CommonMark for README display

Currently using iwasrobbed/Down but with a view to remove this dependency in favour of just swift-cmark without the overhead.
Switched away from using Ink in favour of the latest swift-cmark.
Switched away from swift-cmark in favour of libcmark_gfm which adds GFM support (tables, task lists, and more) to libcmark.
This resolves many of the display bugs seen in README's but is not yet perfect.
TODO:

[x] Add tests
[x] Maybe add environment variable to switch between cmark and ink? (To be confirmed)
[x] Check a variety of READMEs and identify list of remaining problems.

KNOWN PROBLEMS:

Anchor links don't work

This feels like a really minor feature and not something we should prioritise.

Relative URLs don't work

Need to handle relative URLs for both resources and direct links. These are different but addressed the same?
This might require us to do some sort of RegEx to detect relative URLs and then prefix it with an appropriate URL.

Various Styling Issues

Already known before this - I believe it's on Dave's to do list.
Need to do some CSS voo-doo to prevent images from exceeding the width of the container.
Blockquotes and inline code might want to be emphasised a bit differently!
Headers need to have their sizes updated
Tables need some sort of dimension!

TIL tables aren't part of CommonMark - genuinely thought they were standardised!
For the test I've dropped a markdown file into the Fixtures folder and done snapshot tests for desktop and mobile as well as just the pure HTML for the content. Markdown file isn't exhaustive but got some of the most common stuff in there (and can easily expand)

Okay so really we have three versions that could be enabled with trivial changes (it might be worth making this an environment variable?):

Ink
CommonMark
CommonMark + GFM

Currently got the latter one enabled which is a huge improvement over Ink!
Going to open it for review to get some feedback from @finestructure and @daveverwer 😄

Staging
Branch

This looks great! Thanks, @Sherlouk
I think the only reason to ship two MD parsers would be mutually exclusive feature sets. Dave and I discussed this and if cmark can handle all the other MD parsing we're doing we'd swap out Ink entirely. So we don't really need a switch to handle both.
I'll take that out then if you don't mind. I also noticed that I seem to be able to push to your branch? And it triggers CI, so I'll just fiddle around a bit this morning :)

The other open issues link relative links etc we can address in a follow-up, I'd say. This is already much improved for viewing on staging.

Let me know if anything is waiting on me btw 👍  More than happy to pick up further improvements (probably going to end up looking at the relative URL issue soon enough!)


Add a law-abiding version of Damerau-Levenshtein distance

There are two versions of the Damerau-Levenshtein distance. It looks like strsim only provides the first version, which is not a formal metric. It would be nice if strsim provides the second version as well, as this version does have the metric property.
As for why I need this: I'd like to use this library with a BK-tree, which needs a metric to work.

Cool! I'll take a look at what implementing the second version will take once I have some more free time.

Sorry for the delay. The implementation should be fixed now, and the original implementation has been renamed to osa_distance. It's published on Crates as version 0.6.0.


Minimalist usage tracking

I'd love to know if anyone uses the game, but I wouldn't want to impose a heavy library or break privacy with ga/insights/etc.

trying goatcounter... oh the end of the internet!

Done in cc3c99f
Results are public at https://dimaqq.goatcounter.com/


Latest update breaks mod loading

LogOutput.log
Disabling RiskyMod makes the modpack load fine

Ok so, after 4 hours, the game works fine. It might have been some weird caching issues, but now it's fixed

Sorry but the issue wasn't coming from a caching error, but from StarStorm 2. Enabling it with RiskyMod causes this issue

Thanks for reporting this.
I've uploaded a fix. Seems like the SS2 compatibility code in the previous update was causing MSU to hang up and throw errors before RiskyMod could load.
Seems like I'll need to scrap the fix for Gunner Turrets/Drone Refabricators for now.
Let me know if it the mod runs now.

Did more looking in to it, and managed to fix the Gunner Turret compatibility thing. Version 1.5.19 should show up on Thunderstore soon.

I can confirm it works !


About generating text mask

How to generate the mask of text in the image? I don't understand the code in Python 3

Please check here:  https://github.com/ankush-me/SynthText/issues/209

thanks! How to output the final text_mask of the picture_ Where's the mask? I tried for a long time, but there was no result

@heping0307 did u manage to get mask of text?

Yes, but it didn't work
------------------ 原始邮件 ------------------
发件人:                                                                                "ankush-me/SynthText"                                                                                @.>;
发送时间: 2021年12月2日(星期四) 晚上10:14
@.>;
<EMAIL_ADDRESS>主题: Re: [ankush-me/SynthText] About generating text mask (#218)
@heping0307 did u manage to get mask of text?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

how did u get it?


Fix keycodes not corresponding to 1 key on windows

Also seperates control, alt, and enter keycodes
Fixes #77
Details on the fix (except the control, alt, and enter fix) is in the above issue

I forgor to mention that this change will break compatibility in windows programs (especially those that also compile for linux)


Issue with docs.zowe.org/stable/user-guide/cli-installcli

Description
The installation instructions for CLI Version: v2.12.x LTS reference downloads and package names for vNext.
Pages to Update
https://docs.zowe.org/stable/user-guide/cli-installcli#install-zowe-cli-from-a-local-package
Screenshots

Expected behavior
Names should specify v2.12-specific links and files.
Additional context
None

We're changing vNext references to X.X.X to indicate that this is a variable to represent the latest version of Zowe.


Microsoft Entra Workload ID not supported (update packer plugin)

Description
Issue based on suggestion from Januari 2024 to solicit a response from team.
Lack of support for Microsoft Entra Workload ID is blocking conversion of our service connections.
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[X] Windows Server 2019
[X] Windows Server 2022

Image version and build link
20240901.1.0
Is it regression?
No
Expected behavior
GenerateResourcesAndImage.ps1 runs successfully when used in a pipeline within the context of a WIF based service connection.
Actual behavior

Pipeline fails with following error:
==> Some builds didn't complete successfully and had errors:
--> azure-arm.build_image: adal: Refresh request failed. Status Code = '401'. Response body: {"error":"invalid_client","error_description":"AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app '***'.
Repro steps

Create working pipeline based on service connection (SPN/Secret)
Modify pipeline to use service connection based on WIF

@donk-msft Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.


Add filtering API to filter proof requests by issuer-selected proof request name

... and use it in integration tests.

Codecov Report

Merging #132 into master will increase coverage by 0.05%.
The diff coverage is 43.67%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   50.68%   50.74%   +0.05%
==========================================
  Files         151      152       +1
  Lines       22991    22812     -179
  Branches     6071     6041      -30
==========================================
- Hits        11654    11575      -79
+ Misses       7758     7668      -90
+ Partials     3579     3569      -10

Flag
Coverage Δ

#unittests
50.74% <43.67%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libvcx/src/api/mod.rs
30.00% <ø> (ø)

libvcx/src/aries/handlers/connection/agent_info.rs
66.66% <ø> (ø)

libvcx/src/aries/mod.rs
8.67% <0.00%> (ø)

libvcx/src/api/filters.rs
4.34% <4.34%> (ø)

libvcx/src/filters.rs
48.78% <48.78%> (ø)

libvcx/src/disclosed_proof.rs
67.51% <50.00%> (ø)

...aries/handlers/proof_presentation/prover/prover.rs
48.11% <66.66%> (+2.02%)
:arrow_up:

libvcx/src/lib.rs
33.39% <85.71%> (ø)

libvcx/src/api/disclosed_proof.rs
44.29% <100.00%> (ø)

libvcx/src/utils/uuid.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b3eed...418ac69. Read the comment docs.


[Maps] Pre-release update

Packages impacted by this PR

@azure-rest/maps-search

Issues associated with this PR
Describe the problem that is addressed by this PR
Update the release date in CHANGELOG for release.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.