Function valued property erasing calls

In this code:
    type TestFuncProp() =
        member this.Id = fun x -> x

    let wrong = TestFuncProp().Id 0 = 0

The expression body of wrong is just reported by FCS as new TestFuncProp(()).get_Id(()) 0 (printed by printExpr in ExprTests.fsx). Even if TestFuncProp().Id 0 is nested in multiple calls, it erases everything around it.

This is probably the same as this one: https://github.com/fsharp/FSharp.Compiler.Service/issues/544

Fixed by https://github.com/fsharp/FSharp.Compiler.Service/pull/549

Fix is in <IP_ADDRESS>


Text in the 'Contact Us' box is invisible in Dark Mode

As you can see in the below attached picture, the text in the 'Contact Us' form's boxes are not visible in the dark mode because it has black font color and the background color of the boxes also change to black. The font color should be changed so that it is visible in the dark mode. Please assign me this issue so that I can fix this problem.

Hi! Please assign this issue to me. I will do all the necessary things for contact us page in all the theme dark or light and rectify all the issues related to contact us page all together. Please assign this issue to me.
.


[FlatButton] (and all buttons) lacks target property

Problem description
You can specify an href for buttons, but you can't specify a target (ie target="_blank"), so you still need to write extra code if you want a button to open a separate tab (ie for a help button)

From the Tabs/Tab official documentation, there is Controlled example showing how to switch between tabs programmatically, setting the Tabs.state.value referencing each Tab.

Hey @toddmedema, thanks for openning an issue!
I think the issue here is aiming tabs on a browser environment, @Sharlaan, not the component itself.
I think this is a valid feature request and also a good first issue, we would be glad to review a PR for it!

I have just merged #5491 documenting where the no listed properties are going to be applied.
E.g. the target property is going to be applied on the root element. I don't think that we should be adding target explicitly in the docs as the list of interesting properties we could add is very long. I would rather educate users regarding this general behavior on all the components.

Should this be closed? I see jvhoven submitted a PR that does exactly what this issue describes.

Thanks for the reminder.


Add support for implicit / explicit operators on destination type when deserializing if source value is a primitive (for consistency with .NET library)

(Hopefully!) fixes issue #154

The only thing I missed was a test case identical to the one provided in the report. I just went ahead and created it. It is nice to have the provided test case in unit tests, as it helps to see that the reported case ultimately works, and we get an association in the code between the scenario and github issue involved. Nevertheless, I believe the "happy case" ones you provided also enriched a lot the tests and are perfectly placed!

@fabriciomurta Glad that you like it! And I quite agree about including a test case for the original example - that makes a lot of sense!


Use Go Modules

initialize go modules config
update travis settings to use latest go version

Coverage remained the same at 100.0% when pulling 293f74fd6ee9f9d066251b83c26d49b5738304a4 on iwittkau:gomod into 06d9e15c60caec5ddcca9abad8e4a552e9e66fdb on eduncan911:master.

@eduncan911 I saw you preparing a new release. Maybe it is a good time to introduce go modules to the project?

Honestly, I've been removed from Go development for a few years and need to read up on Go Modules.
But I agree, it's the way to go.  I just need to make sure this PR fits with my development methodology (able to develop locally, without internet access).

What does Go Modules buy us over the /vendor folder?

But I agree, it's the way to go. I just need to make sure this PR fits with my development methodology (able to develop locally, without internet access).

Should be no problem if you have downloaded the dependencies. You only need internet access if you want to update dependencies. So this should work as before.

What does Go Modules buy us over the /vendor folder that already has the deps?

The folder can be removed entirely because the dependencies are locked in the go.mod and go.sum files.

Ok, I read something on the Internet on go modules and I am now an expert.  /s

Should be no problem if you have downloaded the dependencies.

Which is problem 1.  Some of workflows involve distributed tarballs on disconnected VMs and labs (think pin testing and virus debugging).  Though it's a stretch to say this Podcast repo would be affected by that, there are other Go tools I use that would directly affected by " if you have downloaded the dependencies."  So yes, this violates my workflows across all of my projects since it is not pre-packaged.

The folder can be removed entirely

Which is problem 2, see above 1.  I prefer to have a distribution package that includes all dependencies, which with Golang, means a /vendor folder.
The good news is I see that go mod supports the creation of, and updating of, the /vendor folder.  (though Go Modules themselves ignore vendor folders when in module mode, according to the docs).
So yes, i can see the benefit of including go mod in this PR!
However, I use SEMVER in this repo.  Which means I guaranteed backward compatibility with the 1.x branch (I've updated the docs in the develop repo, which will be in the README and release notes soon when I release).  go mod is only supported on 1.13 (1.11/1.12 experimental support).  This would break older installs that are not running on 1.13.
With that said, having go modules support the /vender folder would negate that, as older runtimes should continue to work.
So... Here's the way forward with this PR...

Has the potential for a breaking change, which means it may need to be delayed until the 2.x branch is ready - or extensive testing is performed (see next bullet point).
I am finally getting around to adding Github Actions to this repo, to replace travis.  With it, I can setup parallel builds that will build and test under multiple go runtimes - including the 1.6 version that this 1.x branch was originally released under to guarantee support.

If the latter proves it works flawlessly under 1.6 and above, then I can earmark this for a 1.4.x release (not the new 1.3.2 I am working on right now to release).  However, if something breaks in the CI for older versions/runtimes, then it will have to be deferred to a 2.x release.
Make sense?
So yeah, let's keep this PR open.  Btw, I am getting rid of the develop branch here as gitflow is not really needed.  This doesn't affect this PR; however, it limits my ability to merge this PR and test it out - since it lives in your fork.  Would you mind granting me access to your forked repo?  I may add the github actions there.  Either that, or make a new PR against the develop branch so i can test things there after I merge.

Ok, fixed up the develop branch and got it back inline.
Edited this PR to go against the develop branch,
But now, there are a few conflicts...  Sorry about that.
I recommend rebasing, not merging, from the develop branch back to yours.

Merged this in with #25, so closing this particular PR.
Thank you!

@eduncan911 nice! And also thank you four this library!

No problem.  I need to finish my blog about this minimalist testing strategy that yields 100% coverage.  "Minimalist" as in, low effort vs high coverage.
It's why I wrote this library - to demonstrate the patterns in a single example.

Btw, I'd love to hear how it's being used on your side.

I want to build a podacast hosting service for self-hosting. But I don't have anything to show off atm.
In general it just makes me happy that this library exists because it is good to have open accessible stuff in the podcasting ecosystem.


onSelectSlot callback is called instead of onSelectEvent (sometimes)

Sometimes, clicking on an event will execute the onSelectSlot callback (instead of onSelectEvent)
This is caused by the document.elementFromPoint (in isEvent function of Selection.js) which will return the span contained in the rbc-slot-selection div...
Removing the following code from DayColumn.js fixed that issue but I'm not sure 100% that it's the better way to do it. rbc-slot-selection does not seems to be used
&& _react2.default.createElement(
'div',
{ className: 'rbc-slot-selection', style: style },
_react2.default.createElement(
'span',
null,
_localizer2.default.format(selectDates, selectRangeFormat, culture)
)
)

Sorry folks I can't reproduce on the examples, perhaps it was inadvertently fixed recently

@jquense it's not fixed I guess. I am facing the same issue!
It's on the demo page as well!
Reproduce:

Go to DEMO
Navigate to the Selectable event tab
Click on the events there

Events in all day group seems to be working just fine. But the events underneath aren't working!
Click a couple of times on different parts of the events e.g., Click on Time, Click on any place other than the title...
The solution by SamHurne in https://github.com/intljusticemission/react-big-calendar/issues/630 seemed to have fixed the issue previously. But we updated the package recently and that fix is not working either!

@jquense the issue occurs on some events in different scenarios!

I had this problem. Resolved it very simple: I gave the event class z-index:999 so when clicking an event it will catch the event and not the slot below.

This issue is still happening for me.
@noagani that fix did not work for me

@noagani that was the first thing I tried. Did work for sometime. But recently, after upgrading to the latest version, the z-index stopped working for me.

Also still happening for me.


Migrate foreign key & unique constraint docs to introspection tutorial

I've started work on this.

I have this pull request where I just changed existing database workflow for PostgreSQL to use introspect: https://github.com/prisma/docs/pull/824
Is what you want to actually remove sections from database workflows and try to improve the "getting started" tutorial?


Issue starting with iex

I get this error when trying to run a node with iex. Strangely it does not happen when started using elixir
~/D/d/c/backend (master↑3|✚2) > env PORT=5000 iex --name<EMAIL_ADDRESS>--cookie abc -S mix
Erlang/OTP 21 [erts-10.1.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe] [dtrace]

Compiling 55 files (.ex)
[info] [swarm on<EMAIL_ADDRESS>[tracker:init] started
[info] Worker enabled: YES
[info] Endpoint enabled: YES
[info] IP:
[info] Node name<EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:ensure_swarm_started_on_remote_node] nodeup<EMAIL_ADDRESS>[info] [libcluster:empd] connected to<EMAIL_ADDRESS>[info] [libcluster:empd] connected to<EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:ensure_swarm_started_on_remote_node] nodeup<EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:cluster_wait] joining cluster..
[info] [swarm on<EMAIL_ADDRESS>[tracker:cluster_wait] found connected nodes<EMAIL_ADDRESS><EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:cluster_wait] selected sync node<EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:syncing] received registry from<EMAIL_ADDRESS>merging..
[info] [swarm on<EMAIL_ADDRESS>[tracker:syncing] local synchronization with<EMAIL_ADDRESS>complete!
[info] [swarm on<EMAIL_ADDRESS>[tracker:resolve_pending_sync_requests] pending sync requests cleared
[debug] [swarm on<EMAIL_ADDRESS>[tracker:handle_replica_event] replica event: untrack #PID<14553.1892.0>
[debug]<EMAIL_ADDRESS>Unknown last execution time, using now
[info] Application cogo exited: Cogo.start(:normal, []) returned an error: shutdown: failed to start child: Cogo.Scheduler
    ** (EXIT) exited in: :gen_statem.call(Swarm.Tracker, {:track, Cogo.Scheduler.TaskRegistry, %{mfa: {Quantum.TaskRegistry, :start_link, [%Quantum.TaskRegistry.StartOpts{name: Cogo.Scheduler.TaskRegistry}]}}}, 15000)
        ** (EXIT) time out
** (Mix) Could not start application cogo: Cogo.start(:normal, []) returned an error: shutdown: failed to start child: Cogo.Scheduler
    ** (EXIT) exited in: :gen_statem.call(Swarm.Tracker, {:track, Cogo.Scheduler.TaskRegistry, %{mfa: {Quantum.TaskRegistry, :start_link, [%Quantum.TaskRegistry.StartOpts{name: Cogo.Scheduler.TaskRegistry}]}}}, 15000)
        ** (EXIT) time out

Hmm realized that this problem is not deterministic. It sometimes happens. It looks like a node with the same name is shut down earlier.

Possibly related to this: https://github.com/quantum-elixir/quantum-core/issues/397

I also use iex to run our code and we use --name web@POD_IP_HERE, we also get tons of these errors
Elixir.ErlangError: Erlang error: {:noproc, {GenServer, :call, [{:via, :swarm, MyApp.Scheduler.TaskRegistry}, {:running, #Reference<0.708728538.4023648258.94093><EMAIL_ADDRESS>5000]}}
  File "lib/gen_server.ex", line 979, in GenServer.call/3
  File "lib/quantum/executor.ex", line 94, in anonymous fn/3 in Quantum.Executor.execute/2
  File "lib/enum.ex", line 2934, in Enum.filter_list/2
  File "lib/quantum/executor.ex", line 94, in Quantum.Executor.execute/2
  File "lib/task/supervised.ex", line 90, in Task.Supervised.invoke_mfa/2
  File "proc_lib.erl", line 249, in :proc_lib.init_p_do_apply/3

could this be related?

Replaced by #411


Fix incorrect example command in README

A command in the Quick Start section of the README is broken. If I type the command, this is what I get:
$ djangocms -p -f . my_demo
usage: djangocms [-h] [--config-file CONFIG_FILE] [--config-dump CONFIG_DUMP]
                 [--db DB] [--i18n {yes,no}] [--use-tz {yes,no}]
                 [--timezone TIMEZONE] [--reversion {yes,no}]
                 [--permissions {yes,no}] [--languages LANGUAGES]
                 [--django-version {1.4,1.5,1.6,1.7,1.8,stable}]
                 [--cms-version {2.4,3.0,3.1,stable,develop}]
                 [--parent-dir PROJECT_DIRECTORY] [--bootstrap {yes,no}]
                 [--templates TEMPLATES] [--starting-page {yes,no}]
                 [--list-plugins] [--dump-requirements] [--no-input] [--filer]
                 [--requirements REQUIREMENTS_FILE] [--no-deps]
                 [--no-db-driver] [--no-sync] [--no-user]
                 [--template TEMPLATE] [--extra-settings EXTRA_SETTINGS]
                 [--skip-empty-check] [--utc]
                 project_name
djangocms: error: argument --parent-dir/-p: expected one argument

The -p and -f arguments are flipped. The correct command is this: djangocms -f -p . my_demo. This PR fixes this bug.

@gfairchild great, thanks. @evildmp do you think we should fix this all way down to 3.0 branch? Develop is the default on both github and RTFD

@yakky let's merge into develop right away, no real need to get it into 3.0 - 3.1 maybe

Come. Thanks @gfairchild!

Coverage remained the same at 29.2% when pulling c42485c741f1f715e44fa93dc73d3489a0a3b436 on gfairchild:develop into dccab14ffc0990e3a9e2a2da9a3275f2552fb5b8 on divio:develop.


Adding metadata for the Czech Republic in integration

@Wynndow
Haha yeah I've seen that article. It is the official name adopted by the Czech Republic, however.... Even Google Maps calls it Czechia! I think @jakubmiarka doesn't like it, though 😅
I just used it cos it's shorter 🙃

I just used it cos it's shorter 🙃

How often do you plan on typing it @CharlesIC ?

Of course Wikipedia has a whole page dedicated to the issue of the name of the country of the Czech Republic... 😅
https://en.wikipedia.org/wiki/Name_of_the_Czech_Republic
"Czechia" is the official name used at the UN so I see no issue with using it.
The official UK country register lists "Czechia" as the name:
https://country.register.gov.uk/records/CZ.json
official-name | "The Czech Republic"
name | "Czechia"

Compare to the UK:
https://country.register.gov.uk/records/GB.json
official-name | "The United Kingdom of Great Britain and Northern Ireland"
name |  "United Kingdom"

And the case is the same for many other countries - say "The Italian Republic" and "Italy" in the register.
We use the short version of country names so I feel it's legit to use "Czechia" too 🤷♂


Documentation - Triple Exponential Average

@Cal231995 can you help with this build error I am unable to make any commits possibly due to some errors in test_api.py .

@Cal231995 can you help with this build error I am unable to make any commits possibly due to some errors in test_api.py .

Hi @bi-kash Kindly asking for your assistance. Thank you

@Cal231995 please review the documentation for TRIX strategy. If there are any changes required do let me know.
@bi-kash can you please verify if the defaults mentioned for this strategy are aligned with the code. I was not able to find code for this strategy in allocations.py. Thanks.

@Cal231995 please review the documentation for TRIX strategy. If there are any changes required do let me know.
@bi-kash can you please verify if the defaults mentioned for this strategy are aligned with the code. I was not able to find code for this strategy in allocations.py. Thanks.

@fhashim you can refer to this: https://github.com/ta-oliver/infertrade/pull/169
You need not see the entire code. You can verify whether aligned or not using dictionaries at the bottom.


Add Usage instructions for OpenTracing shim package

Add some basic example how to use the shim.

@bg451 would you be willing to make a stub on this? :)


Integrate with cryptoscamdb.com

Not Polkadot specific, cryptoscamdb has many scam sites across the ecosystem. It's maintained by MyCrypto.
We should check against their DB for scam sites and put any new ones we find.
API documentation:
https://documenter.getpostman.com/view/4298426/RzZ7nKcM#2e918352-80e6-4784-b14e-ce3814aa1f3c

It is already used as a check. https://github.com/polkadot-js/phishing/blob/master/packages/phishing/src/crosscheck.spec.ts (along with eth-phishing)

Ah, cool! So, we pull any polkadot or kusama sites into our blacklist. My thinking was that we check any site the user visits also against their DB for a broader protection. But perhaps this is out of the scope of the protection the extension offers?
Do we also push our blacklisted urls to their DB? It would be nice to contribute.

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.


tcl-tk: Tk depends on X11

I've been trying to install tk part of the tcl-tk (installation of tcl part proceeds smoothly).
Things I've found so far:

with-x11 option uses incorrect syntax --with-x for configure command: it should be --with-x=DIR.
patch: DATA checks if MacOS.version < :leopard which should be prepended with OS.mac? &&
To find Xlib.h (actually, we need X11/Xlib.h), I used:
rpm -ql libX11-devel | grep Xlib.h
(system is CentOS 6.6), which returned
/usr/include/X11/Xlib.h
So, we need the compiler to know about /usr/include folder. If we append /usr/include to the CFLAGS using ENV.append_to_cflags "-I/usr/include" then the compiler finds an old tcl.h and installation fails. So, I create a link to that X11 folder using
system "ln", "-s", "/usr/include/X11", Dir.pwd
as the first step of the tk-building phase (before the configure command).
At this point the build process fails with an error about missing libX11.so. In my case it is in /usr/lib64. So, I append this path to cflags with ENV.append_to_cflags "-L/usr/lib64".
At this point the build process fails with an error message about unknown libxcb.so....
And this is where things seem weird:

$ ldd /usr/lib64/libX11.so
	linux-vdso.so.1 (0x00007fffd37ff000)
	libxcb.so.1 => not found
	libdl.so.2 => [linuxbrew-folder]/Cellar/glibc/2.19/lib/libdl.so.2 (0x00007f14b0c24000)
	libc.so.6 => [linuxbrew-folder]/Cellar/glibc/2.19/lib/libc.so.6 (0x00007f14b08aa000)
	[linuxbrew-folder]/Cellar/glibc/2.19/lib64/ld-linux-x86-64.so.2 (0x00007f14b0e2c000)

$ /usr/bin/ldd /usr/lib64/libX11.so
	linux-vdso.so.1 =>  (0x00007fffb9fbd000)
	libxcb.so.1 => /usr/lib64/libxcb.so.1 (0x0000003625400000)
	libdl.so.2 => /lib64/libdl.so.2 (0x0000003622c00000)
	libc.so.6 => /lib64/libc.so.6 (0x0000003622000000)
	libXau.so.6 => /usr/lib64/libXau.so.6 (0x0000003624800000)
	/lib64/ld-linux-x86-64.so.2 (0x0000003621c00000)

Any ideas why Linuxbrew's ldd does not see libxcb.so.1? Should I add /usr/lib64 to rpath? How can I do that? Any suggestions how to proceed?

Linuxbrew isn't particularly well tested with X11. My suggestion is to create a fake xorg keg and symlink files into that, like so:
mkdir -p `brew --cellar`/xorg/7/{include,lib}
ln -s /usr/include/X11 `brew --cellar`/xorg/7/include/
ln -s /usr/lib64/lib[xX]* `brew --cellar`/xorg/7/lib/
brew link xorg

Any ideas why Linuxbrew's ldd does not see libxcb.so.1? Should I add /usr/lib64 to rpath? How can I do that? Any suggestions how to proceed?

I recommend trying to keep Linuxbrew isolated from the libraries provided by your host, to prevent version conflicts like you experience with tcl.h. If you want to experiment, you can add /usr/lib64 to the dynamic library search path like so:
echo /usr/lib64 >>`brew --prefix glibc`/etc/ld.so.conf
ldconfig

Linuxbrew isn't particularly well tested with X11.

Right, this is exactly why I've started this topic. I want to be able to compile tk on a Linux machine.
Fake keg + pristine tcl-tk formula do not work.
So, Linuxbrew's ldd does not see /usr/lib64 and, therefore, does not find libxcb - right?
There is no ld.so.conf file in the $(brew --prefix glibc)/etc/ (but there is ld.so.cache).
I've touched ld.so.conf, then:
$ ldconfig
$ ldconfig -v
ldconfig: Path `[linuxbrew-folder]/Cellar/glibc/2.19/lib64' given more than once
ldconfig: Can't stat [linuxbrew-folder]/Cellar/glibc/2.19/libx32: No such file or directory
[linuxbrew-folder]/Cellar/glibc/2.19/lib:
	libutil.so.1 -> libutil-2.19.so
	libnss_compat.so.2 -> libnss_compat-2.19.so
	libnss_nisplus.so.2 -> libnss_nisplus-2.19.so
	libnss_nis.so.2 -> libnss_nis-2.19.so
	libnsl.so.1 -> libnsl-2.19.so
	libnss_hesiod.so.2 -> libnss_hesiod-2.19.so
	libnss_db.so.2 -> libnss_db-2.19.so
	libnss_files.so.2 -> libnss_files-2.19.so
	libnss_dns.so.2 -> libnss_dns-2.19.so
	libanl.so.1 -> libanl-2.19.so
	libresolv.so.2 -> libresolv-2.19.so
	libcidn.so.1 -> libcidn-2.19.so
	libpcprofile.so -> libpcprofile.so
	libSegFault.so -> libSegFault.so
	librt.so.1 -> librt-2.19.so
	libpthread.so.0 -> libpthread-2.19.so
	libcrypt.so.1 -> libcrypt-2.19.so
	libmemusage.so -> libmemusage.so
	libdl.so.2 -> libdl-2.19.so
	libm.so.6 -> libm-2.19.so
	libc.so.6 -> libc-2.19.so
	ld-linux-x86-64.so.2 -> ld-2.19.so
	libthread_db.so.1 -> libthread_db-1.0.so
	libBrokenLocale.so.1 -> libBrokenLocale-2.19.so

I remember seeing a similar thread on tcl-tk but could not find it...

Any idea why /Cellar/glibc/2.19/lib64 is given more than once?

$HOMEBREW_PREFIX/Cellar/glibc/2.19/lib64' is probably hard-coded into the search path of ldconfig`.
Did you try adding /usr/lib64/ to ld.so.conf? It's not my recommendation, as I prefer to keep the two systems separate, but you can test it for troubleshooting purposes.

Fake keg + pristine tcl-tk formula do not work.

Fake keg is what I use. It should work. What error do you see?

I take it back — fake keg actually works. What happened before was that linking phase was failing while trying to link libxml2 (I've installed libxml2). I assumed that it failed to link just that library, but it turned out all the libraries were not linked. So,  I did brew unlink libxml2 && brew link xorg && brew link --overwrite libxml2 and after that I was able to build tk! I think you should create that fake-xorg keg that would do just those 4 lines of code. People will fix this formula for their Linux distros.
I think fake-xorg should have only the necessary stuff: libX.so*, libxcb.so.1, and so on...

That's in fact not a bad idea, as a stop gap measure. I was hoping someone would package the Xorg client libraries for Linuxbrew. Until that happens, a fake-keg linking to the host libraries isn't a bad plan. It's not a priority for me right now, as I don't much use X11 with Linuxbrew. I'll tag this issue "help wanted" for now, and see if someone would like to pick it up. I'm glad to hear that the fake keg worked for you.

So, for true xorg libraries, someone  has to follow the steps from here?
For a fake formula, this is the list of header files and libraries that were necessary for tcl-tk to be built on the CentOS 6.6 system that I use:
# Symlinks in $(brew --cellar)/xorg/7/include/X11/
/usr/include/X11/cursorfont.h
/usr/include/X11/keysymdef.h
/usr/include/X11/keysym.h
/usr/include/X11/Xatom.h
/usr/include/X11/Xfuncproto.h
/usr/include/X11/X.h
/usr/include/X11/Xlib.h
/usr/include/X11/Xmd.h
/usr/include/X11/Xosdefs.h
/usr/include/X11/Xproto.h
/usr/include/X11/Xprotostr.h
/usr/include/X11/Xresource.h
/usr/include/X11/Xutil.h

# Symlinks in $(brew --cellar)/xorg/7/lib/
/usr/lib64/libxcb.so.1
/usr/lib64/libXau.so.6
/usr/lib64/libX11.so

So, for true xorg libraries, someone has to follow the steps from here?

Yep, that's right.

Ok. Let's keep this issue open. If I find time to work on it, I'll do that.

That'd be great, Maxim.

Kicking this to let you know others are interested.
Also, the fake keg solution allowed me to install qt (and pyqt), in addition to tcl-tk.

Here's my list of linked libraries in the fake keg.
libX11.so               libxcb-randr.so         libxcb-xf86dri.so
libX11-xcb.so           libxcb-record.so        libxcb-xfixes.so
libXau.so               libxcb-render.so        libxcb-xinerama.so
libICE.so               libxcb-res.so           libxcb-xselinux.so
libSM.so                libxcb-screensaver.so   libxcb-xtest.so
libxcb-composite.so     libxcb-shape.so         libxcb-xvmc.so
libxcb-damage.so        libxcb-shm.so           libxcb-xv.so
libxcb-dpms.so          libxcb.so               libXext.so
libxcb-dri2.so          libxcb-sync.so          libXrender.so
libxcb-glx.so           libxcb-xevie.so         libXt.so

I don't think you need all of them. The way I determined mine was that I started with nothing linked and then ran installation gazzillion times to figure out which libraries are requested. I could debug installation and grep header files from within the installation directory, but smart ideas come last.

Just for myself...
$ ldd ~/.mozilla/plugins/libflashplayer.so
        linux-vdso.so.1 (0x00007fffbf1c6000)
        libgthread-2.0.so.0 => not found
        libX11.so.6 => not found
        libXext.so.6 => not found
        libXt.so.6 => not found
        librt.so.1 => [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib/librt.so.1 (0x00007f0eb8891000)
        libXcursor.so.1 => not found
        libXrender.so.1 => not found
        libssl3.so => not found
        libsmime3.so => not found
        libnss3.so => not found
        libnssutil3.so => not found
        libplds4.so => not found
        libplc4.so => not found
        libnspr4.so => not found
        libpthread.so.0 => [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib/libpthread.so.0 (0x00007f0eb8671000)
        libdl.so.2 => [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib/libdl.so.2 (0x00007f0eb846d000)
        libgtk-x11-2.0.so.0 => not found
        libgdk-x11-2.0.so.0 => not found
        libatk-1.0.so.0 => not found
        libpangoft2-1.0.so.0 => not found
        libgdk_pixbuf-2.0.so.0 => not found
        libpangocairo-1.0.so.0 => not found
        libcairo.so.2 => not found
        libpango-1.0.so.0 => not found
        libfreetype.so.6 => not found
        libfontconfig.so.1 => not found
        libgobject-2.0.so.0 => not found
        libgmodule-2.0.so.0 => not found
        libglib-2.0.so.0 => not found
        libm.so.6 => [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib/libm.so.6 (0x00007f0eb8176000)
        libc.so.6 => [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib/libc.so.6 (0x00007f0eb7dfd000)
        [LINUXBREW-DIRECTORY]/Cellar/glibc/2.19/lib64/ld-linux-x86-64.so.2 (0x00007f0eba00d000)

Closing in favour of #892.


Add another Node.js course

What does this PR do?
Add resource
For resources
Description
Node and Express Tutorial by John Smilga
Why is this valuable (or not)?
I am personally benefitted from this course. I think this course deserves to get enlisted here.
How do we know it's really free?
This video tutorial is hosted on YouTube. Just click the link and verify.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Followup

Check the output of Travis-CI for linter errors!

Don't know why 2 checks were not successful and what to do in order to pass these 😕

For youtube, we prefer "playlist" links and the name of the producer/creator. We don't link to authors.

Be sure to check the output of Travis-CI for linter errors. Alphabetical order and spacing are the most common problems.


Fixes javadoc errors

This pull request makes the build fail.

This pull request makes the build fail.

retest this please

SonarQube analysis reported 28 issues

 18 major
 3 minor
 7 info

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolResponseMessage.java#L93: Constructor has 9 parameters, which is greater than 7 authorized.

All is well.

SonarQube analysis reported 23 issues

 13 major
 3 minor
 7 info

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ProtocolResponseMessage.java#L209: Constructor has 9 parameters, which is greater than 7 authorized.

All is well.


Deploying the smart contract to Ropsten

The smart contract so far only works on a local ganache blockchain. For the smart contract to be available to a public, we need to deploy it on a test network. You can deploy the smart contract to any test network, but I recommend the Ropsten one.
This article outlines how to do that: https://hackernoon.com/the-git-way-to-deploy-a-solidity-contract-on-ropsten-with-truffle-yje3z7m
The repository should already have truffle configured as that is what I used for this project.
Once the contract has been published to Ropsten, we can start working to host the interface on Github pages

I deployed the smart contract to the Ropsten network. The contract address is 0xc38925b4688ff0101A40317c8d64ADD74723aa7e. The code in the interface still needs to be updated though


Add support for handling NaN values when converting nx to cypher

Added additional configuration to handle NaN values when converting from nxGraph to Cypher queries. The default configuration raises NanException. Additional handle for Nan values is provided - yielding null if nan occurs, therefore the property will not be added when injecting queries to Memgraph.

Sorry to bother this much, but I would like to express concern about how the API would look once we have Config object (meaning I was wrong the last time). After this iteration user has an option to call the API method with the config object as a calling parameter, meaning that he has no idea at all about whether that contains the index or not. @jbajic @Josipmrden After seeing both, what do you think the best approach is?

Why wouldn't he see that in the config there is an option to create the index?

Can this be merged?


Replace splashes to remove OmniWallet branding

This PR replaces the splash screens for the QT UI.

Ah.. "This branch is out-of-date with the base branch".
Can you please rebase? :)

This is really a bit annoying, sorry. I'll take some time later and setup a dummy repo to play around with the settings. I hope we can preserve the "no forced pushes" and "must pass CI" properties, but without this rather silly requirement.

Rebased :)

Awesome, thanks! Then I'm going to merge this one, then the (again rebased hehe) release notes, afterwards the version bump and then I'm going to tag 0.0.10-rc1! :)

Awesome!


Replace Colors.JS with Chalk

Pull Request Test Coverage Report for Build 103

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 102:
0.0%

Covered Lines:
218

Relevant Lines:
218

💛  - Coveralls


ShiftIt upgrade to 1.6.1

The appcast sha256 must be update as well, right?
It is  31b00662480244b9c2a739e342154fbfa52e50d29bd9c3a4fd683e6f7e905a04

@adius Appcasts aren't yet functional, so it doesn’t matter for now.


⚠ DesiTorrents has degraded performance

In b79424f, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 3175 ms

Resolved: DesiTorrents performance has improved in 1ff184c after 12 minutes.


HTTPS

A suggestion to switch to HTTPS encryption, as every website running HTTP will be flagged as "not secure" by browsers in the coming months.

This should definitely be done in the near future but we need to wait for @shiffman since I don't have the necessary privileges to change the settings.

I set HTTPS up already a couple weeks ago - https://thecodingtrain.com/ - the question is whether or not we want to force HTTPS on the site. I can't really see any downsides except maybe really old browsers? But it's unlikely to have any negatives.
I left it as an option because I don't know why we would prefer to force HTTPS - we don't have any forms or anything like that

I'm happy to force HTTPS. The only issue I think we might run up against is any examples that query a non HTTPS API?

I agree. The API references in the HTML files would then have to be changed to HTTPS, as mixed content errors between HTTP and HTTPS might occur. CDNs nowadays practically all support HTTPS (cloudflare, cdnjs, etc.), so I assume using their HTTPS equivalent should pose no problem?

https://github.com/shiffman/shiffman.net/pull/56 is a mixed content error, if HTTPS is introduced all references would have to be changed to HTTPS

I'd gladly accept a pull request to fix all the references!

I inspected the HTML pages in the repo and didn't find any faulty references. The current HTTPS version works just fine without errors, so I think forcing HTTPS is safe.

I think this can be closed! Let's re-open if I'm wrong.


Possible CrossEntropy optimization

I have noticed that the CE bwd kernel loads the elements of the dloss tensor from HBM to the SM memory. From some experiments, it seems to me that the dloss tensor is always filled with the scaling used for reducing the losses. For example, assuming no ignored tokens, it would be a tensor filled with 1/seq_len.
My team and I are using a custom version of the bwd kernel where we just pass the scaling constant, and avoid loading the dloss tensor elements. In our case we scale with something like 1/(non_ignored_tokens * acc_steps), but regardless it passes all of our numerical tests with regards to correctness.
I was wondering if there's ever any situation where loading the dloss elements makes a difference? I suppose someone could use custom weighting for each token, although I'm not familiar with any technique that does it. In the current repo code it seems that the default behavior is to reduce all the non-ignored tokens, so in this case it should be a tensor filled with the same values everywhere.

Oh interesting! Let me check and get back to you! Thanks for the idea!!


Visualization Tool: Search using regex

The user can search through the scanned resources using their names and IAM policy roles with emails.
So one improvement is to implement another search mode where the user can search using a regex expr through resource names and other text attributes for resource.

Hey, do we want a separate button to enable the regex search in the search box, or something like if the search box has a valid regex expr then we find results accordingly?

yep, the second option sounds reasonable for me. No need for a separate button. Thanks for chiming in on this bug.

Understood, I have made the relevant changes and raised a PR: https://github.com/google/gcp_scanner/pull/301. Please let me know if any changes are required.


jersey-common missing from external dependency in readme

I believe jersey-common is necessary but it is missing from the readme
https://github.com/docusign/docusign-esign-java-client?tab=readme-ov-file#dependencies
        <dependency>
            <groupId>org.glassfish.jersey.core</groupId>
            <artifactId>jersey-common</artifactId>
            <version>3.1.5</version>
        </dependency>

Hi Walker, thank you for this information, I will contact our development team to let them know about this discrepancy.
Eric | DocuSign

Hello Walker,
I want to confirm that jersey-common is not a direct dependency, rather a transitive dependency.
Hence it need not be documented in readme.
Hope this clarifies.
I shall be closing this issue, please feel free to raise a new one if you find anything else which is valid and missing in our ReadMe.
Our team shall be more than happy to incorporate the same.
Thank you,
Vinay


Cannot build target robust on macosx 10.14 and 10.15

I'm having trouble installing OpenSFM in Mac OS X 10.14 and 10.15. Everything works up until trying: python setup.py build.  I cannot figure out how to get pass this. Can someone help?
[ 94%] Built target robust
make: *** [all] Error 2
Traceback (most recent call last):
File "setup.py", line 49, in
build_c_extension()
File "setup.py", line 45, in build_c_extension
subprocess.check_call(['make', '-j4'], cwd='cmake_build')
File "/usr/local/Cellar/python/3.7.6_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/subprocess.py", line 363, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-j4']' returned non-zero exit status 2.

Same issue here!

Update: Assuming most people already know this but using opensfm-docker-base is an easy workaround here. Gets everything working without fighting macos.

Try running reinstall/installing LLVM brew install LLVM. I ended up doing this and it recovered my installing issues on 10.15.4.

brew install LLVM worked for me. Thanks!


"Cannot locate specified Dockerfile: Dockerfile" if .dockerignore contains Dockerfile

Not sure if this is a dockerfile-maven bug or a docker bug.
But either way dockerfile-maven hides what's really happening.
https://github.com/docker/compose/issues/1329

I found why. My .dockerignore file contains the Dockerfile.
Is that a bug or a feature? :)

If you add Dockerfile to your .dockerignore it breaks the plugin.
But not sure I want Dockerfiles hanging around inside my docker images ....

To clear up something, .dockerignore controls what is sent in the "build context" to the docker daemon. The files present in the context are not necessarily a part of the produced image unless you ADD or COPY or otherwise include them. So in other words, your Dockerfile file is not going to be in the produced image unless you somehow add it.
Looks to me like docker itself is smart enough to be able to build the image if .dockerignore contains Dockerfile:
$ cat Dockerfile
FROM ubuntu
RUN ["echo", "hi"]
ADD foo.txt foo.txt

$ docker build .
Sending build context to Docker daemon  2.048kB
Step 1/2 : FROM ubuntu
 ---> 20c44cd7596f
Step 2/2 : RUN echo hi
 ---> Running in ae176412cf2e
hi
 ---> 841e179191a1
Removing intermediate container ae176412cf2e
Successfully built 841e179191a1

$ echo Dockerfile > .dockerignore

$ docker build .
Sending build context to Docker daemon  3.072kB
Step 1/2 : FROM ubuntu
 ---> 20c44cd7596f
Step 2/2 : RUN echo hi
 ---> Using cache
 ---> 841e179191a1
Successfully built 841e179191a1


Continue to implement BatchDict

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.38 :tada:

Comparison is base (e6df29e) 99.15% compared to head (624eb82) 99.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   99.15%   99.53%   +0.38%
==========================================
  Files           9        9
  Lines        1067     1086      +19
  Branches      100      108       +8
==========================================
+ Hits         1058     1081      +23
+ Misses          9        5       -4

Impacted Files
Coverage Δ

src/redcat/batchdict.py
93.24% <100.00%> (+9.60%)
:arrow_up:

src/redcat/batchlist.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature Request: Different Color Slack Notifications

I noticed that with the Victim Removed and Site Down colors both being yellow, doing a visual grep on notifications in Slack can be a bit annoying.
I'd like to suggest using a different colored bar for site down versus victim removed -- Using blue for a new victim and red for errors is great. Maybe use green for victim removed and yellow for site removed?
Great work so far!

Great suggestion, thank you! I can definitely make the colors more distinct, I agree they are much too difficult to tell apart.


Pass a Genesis string to agent config instead of a file path

Currently the agent receives a genesisPath to a file. This is not convenient for dynamic configurations. It should be able to receive a string.
If a genesis file is included it is trivial to read it and pass the resulting string.

I'm afraid that indy-sdk requires path to file according to createPoolLedgerConfig.
I don't know why or if it's really necessary 🤷♂

I have done a trick for that, use the native part of the library -I work on react native- to create a "temporary" file to init the Indy library. I know this is a "hack" but it makes sense for me not to "force" the user to have a file when the library only needs the content.
I think this is an implementation detail of Libindy that should be hidden. But I admit it is a convenience issue, not a "must".

I agree! I already allowed to pass a url in the mobile wallet. Problem is that storage depends on the environment. This means we need to add RN specific + nodejs specific code and libraries to the framework which is not that ideal...

Does anyone know if there are plans to change this in Indy? If not a possible solutions is to abstract it away from the framework. For example define something like a GenesisProvider interface where its implementations are responsible for handling the platform specific storage stuff.
That being said, it's not a sexy solution either, so it might be worth opening an issue on the Indy side of things, since we all don't seem to understand the reasoning behind it...

@karimStekelenburg it's easy to solve in javascript/typescript. I used a couple of convenience methods -copied from @TimoGlastra who wrote them here- and then you can pass a path to a file, a url to download the file or the string itself.
Maybe we could include this in this framework? 🤷🏻♂ Hence we will hide this implementation detail to final users
          let genesisPath = props.agentConfig.genesisPath;
          if (props.agentConfig.genesisUrl) {
            const genesis = await downloadGenesis(props.agentConfig.genesisUrl);
            genesisPath = await storeGenesis(genesis, 'genesis.txn');
          } else if (props.agentConfig.genesisString) {
            genesisPath = await storeGenesis(
              props.agentConfig.genesisString,
              'genesis.txn',
            );
          }


Update W1D2_Tutorial2.ipynb Main model function

Description for params['filterwindows'] assumes first position for visual and second position for vestibular signals but the rest of the tutorial (and the widgets) assume the opposite. Also missing the 's' in 'filterwindows'

Hi @gumadeiras , per the contributing guidelines, we would prefer that all problems with the content (even very simple ones like this) be reported as issues rather than PRs so that we can involve the original content creators and keep the PR queue clear for content finalization. Thank you for helping make Neuromatch content better and for understanding — I know it's frustrating to put in the time submitting a PR and then having it closed.


DNN fallback CPU ops

In GitLab by @corepointer on Mar 18, 2022, 11:31
We have most of our neural network operators (convolutions et al) implemented as calls to
cuDNN. An initial (pooling) operator is ported from SystemDS. The other operations need a
C++ implementation (or porting), test cases and ideally a comparison to the Java version.

Motivation: Deep neural networks (DNNs), such as convolutional neural networks (CNNs), are widely used in machine learning. They consist of multiple layers, which consist of basic operations. DNN workloads are often executed on hardware accelerators (e.g., GPUs). In fact, DAPHNE offers many typical DNN operations and CUDA-based GPU kernels for them. Nevertheless, it would be helpful to have purely CPU-based implementations for the most important DNN operations, as they would allow users who don’t have a GPU set up to still play around with DNNs in DAPHNE (at least on small data).
Task: This task is to implement (in C++) kernels for at least the following typical DNN operations: convolution, pooling (max, avg) (already implemented), bias add, and batch normalization. These operations should be supported for the forward pass and the backward pass. That is, kernels for the following DaphneIR ops are expected: Conv2DForwardOp, Conv2DBackwardFilterOp, Conv2DBackwardDataOp, MaxPoolForwardOp, AvgPoolForwardOp, MaxPoolBackwardOp, AvgPoolBackwardOp, BiasAddForwardOp, BatchNorm2DForwardOp, and BatchNorm2DBackwardOp (some of these operations still need to be added to DaphneIR).
The kernels should work on DAPHNE's DenseMatrix data type. For the data layout, the typical N x C*H*W format shall be used, i.e., each of the N rows in a matrix contains the data of one image. Each image has C channels (could be, e.g., RGB) and a size of HxW pixels. In memory, all pixels in a channel are stored contiguously; within a channel, the data is stored in row-major format.
In addition to the kernels, new unit test cases should be added in test/runtime/local/kernels/ (akin to the existing ones).
Optional extensions of the task (if desired and time is left):

Implement a small DNN example (inference and/or training) in DaphneDSL (e.g., as a script-level test case in test/api/cli/).
Support the DNN ops in DAPHNE's vectorized engine (for parallelism and cache-consciousness).
Implement specializations of the DNN ops' kernels for CSRMatrix (sparse matrices).

Hints:

Get familiar with DaphneIR's DNN ops in src/ir/daphneir/DaphneOps.td (search for Deep neural network).
Read the guidelines on implementing a built-in kernel.
For those operations that already have a CUDA-based implementation, please use the same interface as the CUDA variants (see src/runtime/local/kernels/CUDA/). For the others, take inspiration from the existing ones.
The kernels should not utilize multi-threading internally (DAPHNE's vectorized engine would do that from outside).
Inspiration can be taken from the corresponding operations in Apache SystemDS, both in terms of the documentation and their implementation. It is permissible to translate the core parts of the implementations in SystemDS (whereby these can be significantly simplified due to the focus on dense data and single-threaded execution in this task).
It is a good idea to compare the outputs of the new kernels to those of SystemDS (can be tried by writing small DML scripts).
Make sure to register any new test case cpp-files in test/CMakeLists.txt.

A PR/commit solving this issue should also update the DaphneDSL built-in function reference (doc/daphnedsl/Builtins.md), which currently says "Note that most of these operations only have a CUDNN-based kernel for GPU execution at the moment."


Feature request: Loading indicator Boolean

Is your feature request related to a problem? Please describe.
I'm using ngx-tweet as the focal point of a dialog component. The dialog pops up before the Twitter scripts are inserted, so I would like to include a loading animation to notify users.
Describe the solution you'd like
I'm new to Angular, so take it with a grain of salt. Most of the solutions for this type of logic include a simple boolean on the component. Set the a boolean like this.loading to true when the component is constructed, and set this.loading = false; after loading completes.
I tried to fork and implement, but I ran into an issue. ngx-tweet is currently using the ngAfterViewInit() method to insert the Twitter scripts into the DOM. If I try to change my loading boolean to false in that lifecycle hook, I end up with an ExpressionChangedAfterItHasBeenCheckedError
Describe alternatives you've considered
None.
Additional context
Here's what I tried to do with your ngx-tweet.component:
export class NgxTweetComponent implements AfterViewInit {
  loading = true;
  @Input()
  public tweetId: string;

  constructor(private _elementRef: ElementRef, private _ngxTweetService: NgxTweetService) {
    console.log('Constructor loading ' + this.loading);
  }

  public ngAfterViewInit(): void {
      this._ngxTweetService
          .loadScript()
          .subscribe((twitterData: any) => {
              twitterData.widgets.createTweet(this.tweetId, this._elementRef.nativeElement, {});
          });
    this.loading = false;
    console.log('after init loading '  + this.loading);
  }
}

And here's the error:

Have you considered such a feature? Do you see a clean way to implement? Thanks.

Hello there!
First of all, thanks for your interest in this project.
I didn't consider this feature in a first because I had no need for it.
Now if you need it, I'll see what I can do.
Get back to you soon.

OK, I've added a feature allowing to provide loading content that will get transcluded when necessary.
You can use it like this for example:
<ngx-tweet tweetId="xxxx">
Loading...
 </ngx-tweet>
Hope you'll keep up the good work!
If you have any feedbacks I'm all ears.

Thanks for the quick response!
Did you package your changes on npm already? From what I'm seeing, I believe these changes should be available in ngx-tweet 2.0.3. Is that correct?
If so, I'm struggling to use it correctly. Here's a StackBlitz that's similar to my use case.
To try and test the loading indicator functionality, I'm using Chrome Dev Tools to throttle the load speed to a "Slow 3G" connection. The loading text does not appear. Eventually I'd like to get an angular-material mat-spinner component to work.
Am I using this correctly? Thanks again.
I've got a screenshot of my StackBlitz/devtools, but Github won't allow me to post it. Let me know if that would be useful and I can try to get it to you.

I’m gonna check this ASAP.
Not sure about what you’re experiencing though. On mobile, I can see the loading message being displayed.
As soon as I get access to a computer I’ll let you know!

I think I've got a better handle on what's going on.
The first time you use that StackBlitz, the loading indicator is there. However, there's a significant period of time between when the loading text is disappears and when the Tweet is rendered. I'm guessing that the loading indicator vanishes when the Twitter scripts make their requests. There is then some latency as the Twitter scripts download the new content, which results in neither the loading indicator nor the Tweet being rendered.
When you relaunch the dialog using the button without a page reload, the loading text is not there. I'm guessing that all of the load time in this scenario can be attributed to the Twitter scripts.
Does that make sense?

Yes that is correct. The loading text is displayed while Twitter script is loading. But we only load it once, therefore not displaying loading text ever again (which makes sense as it is pointless to download the same script over and over again).
Your assumption is correct: the latency you experienced is due to Twitter downloading its tweet content. Unfortunately, there is not much I can do about it in this library without adding some ugly code, as it was not meant to solve this issue.
However, I believe that you can hook yourself into Twitter's event loop and get notified once everything is loaded. Then you will have the ability to show/hide your loader.
Hope you'll find what you need, friend!

Thanks, man. Keep up the good work!

Same issue here. I found a way that can be quite useful, and waits for the twitter-widget to be loaded:
import * as $ from 'jquery';

// this function is declared in your controller (source: https://gist.github.com/chrisjhoughton/7890303)
waitForEl(selector, callback) {
    if ($(selector).length) {
      callback();
    } else {
      setTimeout(() => {
        this.waitForEl(selector, callback);
      }, 500);
    }
  }

// then on the ngOnInit just wait for the twitter-widget to appear
// if you want to wait for a specific tweet id, add to the selector [data-tweet-id=123]
ngOnInit() {
    this.tweets_loading = true;
    this.waitForEl('twitter-widget', () => {
      this.tweets_loading = false;
    });
  }

Cheers,
Martino


Remove Float64 -> Float32 cast in IPC Reader

Which issue does this PR close?
N/A
Rationale for this change
Address unresolved comment from #4412
What changes are included in this PR?
Removes Float32 -> Float64 reinterpret cast in create_array.
Are there any user-facing changes?

Thank you


Start Ryuk lazily pt. 2

fix in-docker scenario
start on createContainerCmd

Follow-up of #2056

Should we move this back to Draft? 😄

@rnorth yes, need to find time to work on it and sync with the latest changes we had :) Moved to a draft state

Going to rework


stray prints in the tests

There were a couple of stray prints in the tests, this PR removes them.

Codecov Report

Merging #1648 (ab88445) into main (eaf8569) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   79.91%   79.91%
=======================================
  Files         197      197
  Lines       21731    21729    -2
  Branches     4339     4339
=======================================
- Hits        17366    17365    -1
  Misses       2213     2213
+ Partials     2152     2151    -1

Flag
Coverage Δ

py-unittests
79.91% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

tests/test_cmx_3600_adapter.py
99.59% <ø> (-0.01%)
:arrow_down:

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf8569...ab88445. Read the comment docs.


Determine/document procedure for local testing with remote debugging

When developing/testing, it's useful to run the Safari Web Inspector on a laptop against a connected iPhone running the web app (https://developer.apple.com/library/archive/documentation/AppleApplications/Conceptual/Safari_Developer_Guide/GettingStarted/GettingStarted.html).
However, this only really works with the app that's deployed to GitHub Pages. That's because the development server and tile server proxy aren't being served over HTTPS. The browser is okay with this when the server is localhost, but when it's a different device on the network, it refuses to allow Geolocation API calls on a non-HTTPS pages. If we serve the page with HTTPS, then the Fetch API will fail for the tile server proxy, because it is unencrypted.
Would a few self-signed certificates allow us to run a development server on a laptop and access from a different device (like a phone) on the same local network?

The solution here is to use a tunnel that can serve over HTTPS, such as ngrok or any number of alternatives. I'll add that to the README.


Graph API to disable user sign-ins and installation of an app

[Enter feedback here]
Can you please provide Graph API to Disable user sign-ins for an enterprise app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f07ca31-dd65-9b05-186b-429eb48f91f8
Version Independent ID: 3229b6cb-5833-cc86-ac18-95ce512182ff
Content: Disable user sign-ins for an enterprise app in Azure AD
Content Source: articles/active-directory/manage-apps/disable-user-sign-in-portal.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@avpdm
Thanks for your feedback! We will investigate and update as appropriate.

Thanks @avpdm!
To request this, please add the ask in User Voice and share the link to the feature request on this thread, and I will also create an internal request. https://feedback.azure.com/
User voice is the best place for these types of requests.


add markdown lint

to avoid any future broken links.

/azp run dotnet-aspire

I've verified that bad markdown does break the build.
One note in case it's useful to anyone -- the markdownlint extension in VS Code does not work well for me: I can't get it to respect the configuration files, so it flags things I've suppressed in files I've marked to ignore. Instead, to run markdownlint locally I did
npm install -g markdownlint-cli
markdownlint -c .markdownlint.json "**/*.md"

and this seems to match what happens in CI.

build broken
##[error]samples\dapr\AppHost\DaprAppHost.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.Extensions.ObjectPool from 8.0.0 to 8.0.0-rtm.23524.15. Reference the package directly from the project to select a different version.

/azp run

/azp run

https://www.nuget.org/packages/Microsoft.Extensions.ObjectPool/8.0.0 does exist...

/azp run

we can presumably remove this too
    <!-- Required as https://github.com/dotnet/runtime/pull/89509 did not get backported to .NET 8 Preview 7 -->
    <add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />

/azp run dotnet-aspire

Not sure why it's not showing here, but PR has passed now: https://dev.azure.com/dnceng-public/public/_build/results?buildId=469639&view=results. Manually merging.


Main Window flickers in incorrect location prior to rendering in v11.1.0-beta1

Describe the bug
When a main Window is opened for an app, it can briefly show its titlebar and frame in a certain location, then it moves to another location and displays fully-rendered.  This behavior was first observed in v11.1.0-beta1 and @grokys narrowed the change that caused it down to this PR.
To Reproduce

Follow steps here to download and open our sample solution:  https://github.com/Actipro/Avalonia-Controls#download-and-run-samples
In the /Samples/SampleBrowser/References/Avalonia.References.props file, update AvaloniaVersion to 11.1.0-beta1.
Do a full solution rebuild.
Run the app and see if you notice the ghost window flicker before the main window shows properly.
Revert AvaloniaVersion back to 11.0.7 (or a later 11.0 build) and full rebuild solution and run again.  You won't see the flicker.

Expected behavior
There should be no flicker when the main window is opened.
Avalonia version
11.1.0-beta1
OS
Windows
Additional context
This flicker was observed on latest Windows 11.

@TomEdwardsEnscape any idea how #14470 might have caused this, and what the fix might be?

Looks like even though SetWindowPos will restore a minimised window, it will not show one that has not yet been shown. This means that a change in behaviour snuck in via #14470 when an unshown window is resized.
The problem is noticeable in the Actipro repo because their window takes a long time to open, then removes window decorations and centres itself on-screen. But it's replicable in any window if those conditions are replicated.


expressions are not callable at line 9 character 4

I'm getting this error when compiling in VERBOSE level:
JSC_NOT_FUNCTION_TYPE: * expressions are not callable at line 9 character 4
I managed to reproduce it in  https://closure-compiler.appspot.com
Here is a quick link to the sample code:
Sample code on closure-compiler.appspot.com
// ==ClosureCompiler==
// @compilation_level SIMPLE_OPTIMIZATIONS
// @warning_level VERBOSE
// @output_file_name default.js
// ==/ClosureCompiler==

// ADD YOUR CODE HERE
/**
 * @param name
 * @return {*}
 */
var require = function(name) {};

var e = require('e');
a = e();

Any help is greatly appreciated.
Thanks

This is working as intended, * means e can be any possible type. Since the Compiler can't prove it's a function, it won't let you call it. The following code works:
// ==ClosureCompiler==
// @compilation_level SIMPLE_OPTIMIZATIONS
// @warning_level VERBOSE
// @output_file_name default.js
// ==/ClosureCompiler==

// ADD YOUR CODE HERE
/**
 * @param name
 * @return {Function}
 */
var require = function(name) {};

var e = require('e');
a = e();

@return {Function} works if I'm only returning a function. But this require function can return any other type also.
So what I which to define this type as @return {Function|*} which would produce the same warning since it basically means the same thing as *.
Is there a way to define the type so it can understand anything, including functions? Or is it better in this case to just cast e, var e = /** @type {Function} */ (require('e'));

If this require function can return any type, how are you certain that e is a function? You can always use type cast but then you might get TypeError at runtime.

Agreed. This seems to be a fully untyped function that can return anything and it is impossible to know at compile time what its returning. It feels like the proper type for this function is the UNKNOWN type {?}.
Then use type casting to 'partially' check the rest of the app.
Thank you @Dominator008 for all the help.

Yes, uising ? and type casting should work in your case. Is this trying to require a CommonJS module? Not sure if this is the require function you are talking about.

Yes. This is exactly what I'm talking about. I'm trying to add closure compiler type checking in my project. I'm trying to understand the best way to integrate this where it can do full (or as much as possible) type checking without modifying/fixing third party source code. So, I'm using externs to do this.


auto/configure support python 3.1x

if we would like to support
python3.1x
maybe the code line here https://github.com/vim/vim/blob/5cf94577cf2045fec87344d7d89422fe6dfce62f/src/auto/configure#L6676
should be
print("{}.{}".format(sys.version_info.major, sys.version_info.minor))
?

Yes, that is more reliable.  Using 3.1 for 3.10, 3.11, etc. might work, but it looks wrong.


Make a changelog

It would be nice to have a changelog.md at the root of the repo, and also have a way to view it, rendered, on the site itself (perhaps next to the GitHub button at the top-right). Extra points if we put a little notification bubble on it if there have been unseen changelog updates since the previous visit!
Also we should consider if we really want version numbers - there's a 0.2 milestone here on GitHub but I'm unsure if version numbers are really worth it for a website.

It's kinda unclear to me how this would work. many things we do to the repo won't be really interesting to an end-user, so is the changelog for users of the site or users of the project? And how do we organize the changelog if we're not using a version system? I changed it to dates in the branch we're working on currently, but that's also misleading because the date we finish something isn't necessarily the date it goes live

I think the one on the site should be for users of the site, not people attempting to clone the repo and run it locally. We might not even need dates for this - just have bullet points of user-facing new features and highlight any that haven't been seen yet.


Could I use with "decimal number"?

Could I use with "decimal number"?
123456.789

Currently it's not supported. I'm considering this for 2.x.

@marlun78 Please is the v2.x out? Because i need the decimal number.

Hey @marlun78, the decimal part should be easier than the normal ones. I will look through your code and work on this. What would you want to be the output if someone requests an ordinal of a decimal number? The digits after the decimal point don't matter, right?

Hi, for 25.42 I would like twenty-five point four two

@tofutim Ah! No, I never got to this actually. 😭 👍

Hi. Is there any progress on that?

I just added a PR to do this. Feel free to pull from my repo if you're desperate for this, but I don't plan to maintain my fork -- better to keep track of this one.
https://github.com/grahampcharles/number-to-words


DNS 2020 Dataset

I downloaded and extracted the file https://dns3public.blob.core.windows.net/dns3archive/datasets-interspeech2020.tar.bz2
but it seems that the files are corrupted.
I get the following error:
"This file isn’t playable. That might be because the file type is unsupported, the file extension is incorrect, or the file is corrupt."
Is there another link to 2020 dataset?
Thanks!

Theres a branch for the 2020 data in this repo, the dataset can be downloaded via git LFS directly.
Best, Serafin

Theres a branch for the 2020 data in this repo, the dataset can be downloaded via git LFS directly. Best, Serafin

Downloading the dataset via git LFS is too slow. It takes about 70 hours at least. Do you have any suggestions about that? Thanks a lot.

Hmm. You could download the noise via git LFS (only a couple of GB) and collect the speach data from the single sources.

Hmm. You could download the noise via git LFS (only a couple of GB) and collect the speach data from the single sources.

Thank you! I've solved the problem by using VPN to download the data.

Hmm. You could download the noise via git LFS (only a couple of GB) and collect the speach data from the single sources.

Thank you! I've solved the problem by using VPN to download the data.

could you please tell me what VPN position you use

Hmm. You could download the noise via git LFS (only a couple of GB) and collect the speach data from the single sources.

Thank you! I've solved the problem by using VPN to download the data.

could you please tell me what VPN position you use

Hi, have you finished downloading? If you have downloaded it, could you share the non-blind test set with me please? I only need the non-blind test set, it would take too long to download the entire dataset.


session.addHandler: errors when trying to add a closure

It might work with system.rawProc(someHandler). Haven't tested.

It's possible to work with GC unsafe code now, but closures are not valid handlers.


Where are missing power pins on LAN9513

The question. LAN9513 chip has 5 power ports VDD33IO, but there is only pin19 on the schematics. Are there any other pins, or they are missed?

To make the schematic more clean those pins are hidden "behind" pin19. So all those pins get connected.


Range parsing for da, tm, dt

Hello Eduardo,
please review these methods for parsing date ranges.
They all return a tuple of 2 Options, where a None means no upper or lower range.
Hope they are Ok
Thanks

Thank you for your review. Tried to correct and learned about error matching in tests.

Hey @jmlaka, the code formatting resulted in a conflict, but it should be easy to resolve.

Hello,

In case of two equal DT,TM,DA input values,  we shall return two equal
Ok values then ?

I noticed the conflict after committing, how can I avoid it in the
future?

Thanks
Juraj Mláka
Dňa pi 30. 7. 2021, 23:12 Eduardo Pinho @.***>
napísal(a):

@.**** requested changes on this pull request.
Aside from the conflict, I just found a few more matters worth looking
into.
In core/src/value/deserialize.rs
https://github.com/Enet4/dicom-rs/pull/145#discussion_r680215700:

@@ -29,10 +31,28 @@ pub enum Error {

 InvalidNumberToken { value: u8, backtrace: Backtrace },

 #[snafu(display("Invalid time zone sign token: got '{}', but must be '+' or '-'", *value as char))]

 InvalidTimeZoneSignToken { value: u8, backtrace: Backtrace },

#[snafu(display("No Range Separator Present"))]

⬇ Suggested change

#[snafu(display("No Range Separator Present"))]

#[snafu(display("No range separator present"))]

In core/src/value/deserialize.rs
https://github.com/Enet4/dicom-rs/pull/145#discussion_r680216057:

@@ -29,10 +31,28 @@ pub enum Error {

 InvalidNumberToken { value: u8, backtrace: Backtrace },

 #[snafu(display("Invalid time zone sign token: got '{}', but must be '+' or '-'", *value as char))]

 InvalidTimeZoneSignToken { value: u8, backtrace: Backtrace },

#[snafu(display("No Range Separator Present"))]

NoRangeSeparator { backtrace: Backtrace },

#[snafu(display("End {} before Start {}", end, start))]

⬇ Suggested change

#[snafu(display("End {} before Start {}", end, start))]

#[snafu(display("End {} is before start {}", end, start))]

In core/src/value/deserialize.rs
https://github.com/Enet4/dicom-rs/pull/145#discussion_r680218716:

@@ -291,9 +305,140 @@ pub fn parse_datetime(buf: &[u8], dt_utc_offset: FixedOffset) -> Result<DateTime

     .context(InvalidDateTimeZone)

}
+macro_rules! check_range {

($s: expr, $e: expr) => {

   if $s == $e {

       RangeIsZero {

According to PS3.4 C.<IP_ADDRESS>
http://dicom.nema.org/medical/dicom/current/output/chtml/part04/sect_C.<IP_ADDRESS>.html,
equal ends are OK, and the match is inclusive. For instance, a range such
as 20210730-20210730 would simply match one date.
The error variant RangeIsZero should then be removed, and the tests be
updated accordingly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Enet4/dicom-rs/pull/145#pullrequestreview-719456872,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWGC3EUVGWMR7XZC77C7G3T2MITVANCNFSM5A4TSA3A
.

Hello, 1. In case of two equal DT,TM,DA input values, we shall return two equal Ok values then ? 2. I noticed the conflict after committing, how can I avoid it in the future?

On 1, we can go with a Result<(Option<Date>, Option<Date>).
Regarding 2, this happened because the branch to be merged is based on an outdated revision. You can either rebase or merge the branch against origin/master; and then update the branch by pushing it again. GitHub also provides a web interface for resolving conflicts, as an alternative.

I managed to rebase, corrected the code.
I wanted to "squash" the commits to one, but still have to learn that one :)

Corrected as you suggested.
Does "squashing" mean that you, when accepting a pull request, can make all my small commits into one ?

Does "squashing" mean that you, when accepting a pull request, can make all my small commits into one ?

That is a possible option when merging, yes, but it is one that I generally to not feel the need to do.
For what it's worth, squashing commits together leads to some information loss (of the sequence of operations done by the author over time), with the main benefits of discarding mistakes in this sequence (which are not very useful for the revision process) and simplifying the revision history once merged.
For these reasons, this project currently does not have a strict commit squashing policy.

Hello,
Thanks for looking at the pull request. I'm happy to learn from a
professional and maybe one day something useful will pop up from my code 😁
You are absolutely right.
I've been only using PyDicom before I stumbled upon your library. And
Pydicom has no such thing as range parsing. Which is kinda bad if you need
to handle c-find requests...
Let's see if I figure something out.
Regards
Juraj Mláka
Dňa so 14. 8. 2021, 18:20 Eduardo Pinho @.***>
napísal(a):

@.**** requested changes on this pull request.
Thank you very much for the initiative of extending this PR to the value
API. I only have one minor technical recommendation (see comment), but I
would like to bring a major concern to the table regarding this feature.
Suppose the following date range: 2020-2021
With the current implementation of to_date_range, both components are
given default values for the unspecified components (month becomes January,
and day becomes 1), so this range is deserialized into (Some(2020-01-01),
Some(2021-01-01)). The standard states (and what users would naturally
expect) that this range should cover all dates in the year 2021, but with
what we have right now, all dates from 2021-01-02 to 2021-12-31 would be
outside the range.
This means that an accurate representation of ranges will need to consider
the presence of null components and actually encode them in the various
core types Date, Time, DateTime, and respective range types (#55
https://github.com/Enet4/dicom-rs/issues/55). Either this or use
different defaults for the second member of the range, but it would not be
consistent with how two elements are converted into a date, and I suspect
that this would not be very reliable anyway.
I picture that a better strategy for handling ranges is to work on #55
https://github.com/Enet4/dicom-rs/issues/55 first, and then come back
to this to introduce accurate and useful implementations of date-time range
matching. What do you think?
In core/src/value/deserialize.rs
https://github.com/Enet4/dicom-rs/pull/145#discussion_r688943704:

+macro_rules! check_range {

($s: expr, $e: expr) => {

   if $s > $e {

       RangeInversion {

           start: $s.to_string(),

           end: $e.to_string(),

       }

       .fail()

   } else {

       Ok((Some($s), Some($e)))

   }

};

+}
We can replace this macro with a function using the right set of parameter
types and constraints.
⬇ Suggested change
-macro_rules! check_range {

($s: expr, $e: expr) => {

   if $s > $e {

       RangeInversion {

           start: $s.to_string(),

           end: $e.to_string(),

       }

       .fail()

   } else {

       Ok((Some($s), Some($e)))

   }

};

-}
+fn check_range(s: T, e: T) -> Result<(Option, Option)>
+where

T: ToString,

T: PartialOrd,

+{

if s > e {

   RangeInversion {

       start: s.to_string(),

       end: e.to_string(),

   }

   .fail()

} else {

   Ok((Some(s), Some(e)))

}

+}
(All uses of this macro should be replaced with function calls as well)
In core/src/value/primitive.rs
https://github.com/Enet4/dicom-rs/pull/145#discussion_r688944654:

   }

}

/// Retrieve a DateTimeRange from this value and given FixedOffset.

///

/// If the value is represented as a sequence of exactly two date-times,

/// it is returned.

///

/// If the value is a string, or sequence of 1 string, or sequence of U8 bytes,

/// it is decoded (range separator '-' is detected), potentially failing.

///

/// If the value is a sequence of exactly two strings,

/// it is converted to a sequence of two date-times and returned.

///

/// 2 equal date-times are valid input.

/// If date-times are not time ordered, operation fails.

⬇ Suggested change

/// If date-times are not time ordered, operation fails.

/// If the date-times are not monotonically ordered in time,

/// the operation fails.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Enet4/dicom-rs/pull/145#pullrequestreview-730102664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARWGC3DDCSVZ4Q7YHFFLH5DT42JT7ANCNFSM5A4TSA3A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Make all WeeksPanel components resizable

Most of the component implementation in the WeeksPanel class is pretty much just rushed garbage. Week and hour labels were implemented to "look right" rather than be aligned properly and they cannot resize/scale properly with the window. The goal is to fix and improve this.

Wario voice I won. But at what cost?


how to add server name on custom hud

ive been trying to add server name and idk the code, wondering if you could tell me, thanks

Do you mean the name of the server you give it, or its address? If it's the address, it's {address}

i meant the variable so thanks i was looking for address.


Signals proposal for JavaScript

I imagine you'd be interested in this. Looks like a great idea IMO https://github.com/proposal-signals/proposal-signals might be worth tracking it.

Ah this should be a discussion not an issue, sorry


Allow setting HTTP headers and parameters during schema upload

Description
Useful for sender to annotate additional information for observability and auditing

Codecov Report

Merging #6270 (1b49e43) into master (1beaab5) will decrease coverage by 2.31%.
The diff coverage is 45.12%.

@@            Coverage Diff             @@
##           master    #6270      +/-   ##
==========================================
- Coverage   66.44%   64.13%   -2.32%
==========================================
  Files        1075     1243     +168
  Lines       54773    58950    +4177
  Branches     8168     8739     +571
==========================================
+ Hits        36396    37808    +1412
- Misses      15700    18389    +2689
- Partials     2677     2753      +76

Flag
Coverage Δ

unittests
64.13% <45.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <0.00%> (+9.52%)
:arrow_up:

.../main/java/org/apache/pinot/client/Connection.java
35.55% <0.00%> (-13.29%)
:arrow_down:

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <0.00%> (-51.10%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
73.80% <ø> (+0.63%)
:arrow_up:

.../apache/pinot/common/exception/QueryException.java
90.27% <ø> (+5.55%)
:arrow_up:

...pinot/common/function/AggregationFunctionType.java
98.27% <ø> (-1.73%)
:arrow_down:

... and 1082 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a53fbe...1b49e43. Read the comment docs.

@Jackie-Jiang Thanks for the review. Comments addressed.


Led PWM sample

Added another cute little part to the sample logic and added two more overlay files

sample.yaml and README.rst need to be updated I would also consider doing the increase-then-decrease in a single loop to avoid duplicating code

I updated the files.
Regarding the single loop - I think it would just make the code less readable. If you have a suggestion for a way to make it look good and in one loop I'm all ears.

@kartben Can we merge?

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@yishai1999 It looks good to me but can you add the changes to release-notes-4.1.rst ? Thanks in advance ! :)

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@yishai1999 It looks good to me but can you add the changes to release-notes-4.1.rst ? Thanks in advance ! :)

@simonguinot what changes? There is nothing in there that's "release note worthy", or did I miss something important?

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@yishai1999 It looks good to me but can you add the changes to release-notes-4.1.rst ? Thanks in advance ! :)

@simonguinot what changes? There is nothing in there that's "release note worthy", or did I miss something important?

@kartben the change of behavior of the LED PWM sample ?

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@yishai1999 It looks good to me but can you add the changes to release-notes-4.1.rst ? Thanks in advance ! :)

@simonguinot what changes? There is nothing in there that's "release note worthy", or did I miss something important?

@kartben the change of behavior of the LED PWM sample ?

Yeah, not really something that anyone really cares about seeing in the release notes IMO :) FWIW we're actually trying to document better what belongs to release notes and what doesn't so that it's clearer for folkdst https://github.com/zephyrproject-rtos/zephyr/pull/82542

@bbilas @Mani-Sadhasivam @nashif @simonguinot Can you take a look?

@yishai1999 It looks good to me but can you add the changes to release-notes-4.1.rst ? Thanks in advance ! :)

@simonguinot what changes? There is nothing in there that's "release note worthy", or did I miss something important?

@kartben the change of behavior of the LED PWM sample ?

Yeah, not really something that anyone really cares about seeing in the release notes IMO :) FWIW we're actually trying to document better what belongs to release notes and what doesn't so that it's clearer for folkdst #82542

ah ah ah :)


version return 0+unknown

I use versioneer in both of my packages pyMannKendall and pyHomogeneity. It works great when I build my packages. It's correctly added version number in dist/wheel file. But, the problem is, when I install this dist file or install from pip and import and call __version__ like below, it returns '0+unkonwn'.
import pymannkendall as mk
mk.__version__

What is the problem? How can I fix this?

Problem Solved
cmdclass=versioneer.get_cmdclass(), missing in setup.py file. So it couldn't generate version number properly.


better CMake integration

Each folder should have a CMakeLists txt and then integrate them to the main CMakeLists.txt in root dir.

Using cmake libraires so other CMake project can request components seems the way to go.
Having several CMakeLists.txt maybe nice, one per independent sub-projects, like the library, the plugins, ...
Inside the library, you may want to have components that can be enabled disabled.
In any case, I would suggest to avoid GLOB completely as this is only evaluated at configure time, so any further changes but developers for example would be omitted.

This is closed as CMake integration is fine for now


v1.2 backports 2018-08-09

PRs backported:

#5139
#5117
#5109
#5108
#5099
#5098
#5096
#5092
#5090
#5083
#4994
#4981
#4913

This change is

test-me-please