Loads forever on some devices

🐛 Bug Report
We have several android users who is experiencing it loads forever when trying to fetch the location.
It does not happen on all android versions, and not on iOS at all.
Expected behavior
Should not load forever (also LocationAccuracy.lowest should work on all android versions, but it seems like it doesnt)
Reproduction steps
    final position = await Geolocator.getCurrentPosition(
      // On android .lowest does not work for some reason. Use LocationAccuracy.best instead, or it will load forever.
      desiredAccuracy: Platform.isAndroid ? LocationAccuracy.best : LocationAccuracy.lowest,
      timeLimit: Duration(seconds: 20),
    );

Configuration
Version: 9.0.2
Platform:

[ ] :iphone: iOS
[x] :robot: Android

Possibly related: https://github.com/Baseflow/flutter-geolocator/issues/949

OnePlus 9pro
Android version 13
Apparently it worked to clear Storage and Cache from the app, and then trying again. Very strange issue.

@simplenotezy,
Do you have the output of flutter doctor -v


Mining tweaks

So we have pickaxe, drill, crusher, and PKA (projectiles). The tier list in terms of mining speed should go:

PKA
Crusher
Pickaxe
Drill

As a result:

Nerfed PKA firerate to 0.5 and bumped damage (slight DPS nerf due to meta).
Crusher bumped to 1 hit per second as PKA is still more common and also to make it better at mining.
Pickaxe is 1 hit per second and also gets structural (fireaxe should still beat it by a little bit) so it's better to break stuff than crusher but worse in combat.
Drill is 1.5 hits per second but otherwise weak.

2 reasons for this:

PKA shouldn't just be the end-all be-all for carrying around constantly.
Expeditions timer reduction means need tools with faster mining speed.

:cl:

tweak: Tweak PKA, crusher, pickaxe, and drill. Overall adjusted the mining speed from lowest to fastest in that order. Additionally buffed crusher attackrate and pickaxe structural damage.

pickaxe needs wielded sprite


npm package

Will a npm package be published for this repo?

Also is there an install method for this package?

Package has been on npm since 2011 https://www.npmjs.com/package/test
And no there is no install script for it


adding testing with minikube to cri-dockerd release

hello ! after the https://github.com/Mirantis/cri-dockerd/issues/163 I thought maybe we could add a github action to cri-dockerd repo to install minikube with Cri-docker from head and do some basic testing with minikube, to avoid surprises in the future

this would be helpful to prevent this https://github.com/Mirantis/cri-dockerd/issues/172 too


Move emit_to_memory to MachCompileResult

This small refactoring makes it clearer to me that emitting to memory
doesn't require anything else from the compilation Context. While it's
a trivial change, it's a small public API change that shouldn't cause
too much trouble, and doesn't seem RFC-worthy. Happy to hear different
opinions about this, though!

I don't necessarily like the unsafe aspect of emit_to_memory. It feels out of place in a crate that otherwise has no unsafe code: the details of putting the bytes where they are needed should be in the hands of the embedder. In my mind the ideal interface is to expose the machine code as a &[u8] off of the MachCompileResult; this more closely mirrors reality (the struct owns the bytes as a Vec, and is a value representing the result of compilation, so this is just a projection of that part of the value) and feels more idiomatic.

This is an artifact of the old way Cranelift worked before machinst. It was possible to calculate the size of the necessary buffer before actually emitting any bytes, so bytes could be emitted in place without requiring any reallocation. With machinst this is no longer the case. As such it should indeed expose an &[u8] now IMHO.

We have an accessor .compile_result() on the Context (this feels like a little thing, but methods are generally more obvious than public fields) that still returns an Option<&MachCompileResult>; but more importantly,

This one I don't necessarily agree with, but...

We return a CodegenResult<&MachCompileResult> from compile(). The CodeInfo (the current return value) is already accessible from the compile result object with .code_info(). This then enables something like: copy_into_jit_memory(ctx.compile(isa)?.machine_code()).

...this one I definitely do agree with.

And while we're at it, I might bikeshed the struct type name MachCompileResult a bit. I came up with it when initially doing the machinst framework where types were often distinguished with the Mach prefix (MachInst, MachBuffer, ...) but IMHO it's a bit of an antipattern now. I also don't necessarily like CompileResult because it sounds more like the "type alias of Result with a particular error type" idiom. Maybe something like CompiledCode ?

Sounds great! I am hesitant when I hear CompiledCode: does it mean the final code mmapped to its final executable region, or the code with relocations? (and it's the latter)
No obvious better name comes to mind, though. For instance, CompiledPicCode or PicCode aren't so self-explanatory, and the Pic bit is a topic for discussion. That's only a renaming and quite easy to change later, though, so I'll start with CompiledCode for this PR.

Implemented all the ideas mentioned here that would make this move forward. In particular, returning a ref to the compiled result from the compile funcs turned out a bit worse than anticipated in 670dcab, so we could decide to get rid of that instead.
We have a common pattern in the code base of doing:
ctx.compile(...).map_err(|err: CodegenError| pretty_anyhow_error(&ctx.func, err))?;
let result = ctx.mach_compile_result();

which becomes, with the naive change of just returning &MachCompileResult from the compile function:
let result = ctx.compile(...).map_err(|err: CodegenError| pretty_anyhow_error(&ctx.func, err))?;

but now, ctx is mutably borrowed even in the map_err function's body (because result is a reference into ctx's fields), so borrowck says we can't immutably read ctx.func in the prettifier method.
The solution I opted for was to have a thin wrapper for the compile functions, that contained both the CodegenError and the reference to the Function we're trying to compile, so this code becomes:
let result = ctx.compile(...).map_err(|err: CompileError<'_>| pretty_anyhow_error(&err.func, err.inner /* the CodegenError */))?;

but that's a bit of cognitive overhead for relatively low-value, so would be happy to hear opinions if it's something we want to keep or not.


Duplicated response

This is happening in my two OSs. WSL 2 on Windows 11 and EndeavourOS (arch based). Both bash.
Look at the section "Your script". It shows the command twice separated by the "script" word. This happens 100% of the times, prompt independent. If I run or edit the command, ai-shell show the correct response.
[me@pc ~]$ ai --version
1.0.9
[me@pc ~]$ ai install ssh client

┌  AI Shell
│
◇  Your script:

sudo pacman -S --noconfirm opensshscript sudo pacman -S --noconfirm openssh

•
│
◇  Explanation:

1. Run the script with superuser privileges using sudo.
2. Use the package manager pacman to install the package openssh.
3. Skip the confirmation prompt by using the --noconfirm flag.

•
│
◆  Run this script?
│  ● ✅ Yes (Lets go!)
│  ○ 📝 Edit
│  ○ 🔁 Revise
│  ○ 📋 Copy
│  ○ ❌ Cancel
└

I found the cause of this issue:
https://github.com/BuilderIO/ai-shell/blob/ce1fcfba66cacf33221e8bad4b1151a3d57a155d/src/prompt.ts#L123

The fix was merged.


BMI calculation bug fix

Describe the bug
Unable to get  the bmi -> The BMI calculator is not working properly
To Reproduce
Steps to reproduce the behavior:

Will modify the code to display the output

Expected behavior
A page showing the bmi results
Additional context
Here is the site :
https://github.com/TusharKesarwani/Front-End-Projects/blob/main/Projects/BMICalculator/style.css

Can I try that

ig it is showing output correctly. What is the error?


Feat: scrap data formal shirt for men from flipkart

Describe the feature
data scrap for formal shirt for mens.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

@nikhil25803 have a look!

Go ahead @Sushilverma002
Note

Create a separate module for this, as per the folder and project structure
Do not use the `selenium web driver as it is not compatible with all devices as well as cloud platforms.
Before making any changes, check if the module you want to add already exists or not. If yes, then add your functionality as a method only else make a separate module and class for it.

All the best 👨💻


[Hotfix][st-engine] Fix client cannot be stopped when submit jobs to cluster exception

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@ashulin @Hisoka-X @EricJoy2048 PTAL

Check out #3142

#3142


When making multiple selections in Autocomplete, the searched text is reset after each selection. Is it possible to prevent this with a prop?

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
When making multiple selections in Autocomplete, the searched text is reset. Is it possible to prevent this? The user wants to select all the lines returned as a result of the searched text.
I am writing a text to autocomplete.
The results with the text are listed.
After making 1 selection, old unfiltered long list comes and my search text disappears.
I want to preserve this search term.
Examples 🌈
No response
Motivation 🔦
No response

Can I take look?

You can acheive the behaviour you described by converting inputValue to controlled inputValue
working sandbox: https://codesandbox.io/s/wonderful-neumann-7eit9m?file=/demo.tsx
code
import * as React from "react";
import Chip from "@mui/material/Chip";
import Autocomplete from "@mui/material/Autocomplete";
import TextField from "@mui/material/TextField";
import Stack from "@mui/material/Stack";

export default function Tags() {
  const [val, setvalue] = React.useState("");
  return (
    <Stack spacing={3} sx={{ width: 500 }}>
      <Autocomplete
        multiple
        inputValue={val}
        id="tags-standard"
        options={top100Films}
        getOptionLabel={(option) => option.title}
        defaultValue={[top100Films[13]]}
        renderInput={(params) => (
          <TextField
            {...params}
            onChange={(e) => setvalue(e.target.value)}
            variant="standard"
            label="Multiple values"
            placeholder="Favorites"
          />
        )}
      />
    </Stack>
  );
}

// Top 100 films as rated by IMDb users. http://www.imdb.com/chart/top
const top100Films = [
  { title: "The Shawshank Redemption", year: 1994 },
  { title: "The Godfather", year: 1972 },
  { title: "The Godfather: Part II", year: 1974 },
  { title: "The Dark Knight", year: 2008 },
  { title: "12 Angry Men", year: 1957 },
  { title: "Schindler's List", year: 1993 },
  { title: "Pulp Fiction", year: 1994 },
  {
    title: "The Lord of the Rings: The Return of the King",
    year: 2003
  },
  { title: "The Good, the Bad and the Ugly", year: 1966 },
  { title: "Fight Club", year: 1999 },
  {
    title: "The Lord of the Rings: The Fellowship of the Ring",
    year: 2001
  },
  {
    title: "Star Wars: Episode V - The Empire Strikes Back",
    year: 1980
  },
  { title: "Forrest Gump", year: 1994 },
  { title: "Inception", year: 2010 },
  {
    title: "The Lord of the Rings: The Two Towers",
    year: 2002
  },
  { title: "One Flew Over the Cuckoo's Nest", year: 1975 },
  { title: "Goodfellas", year: 1990 },
  { title: "The Matrix", year: 1999 },
  { title: "Seven Samurai", year: 1954 },
  {
    title: "Star Wars: Episode IV - A New Hope",
    year: 1977
  },
  { title: "City of God", year: 2002 },
  { title: "Se7en", year: 1995 },
  { title: "The Silence of the Lambs", year: 1991 },
  { title: "It's a Wonderful Life", year: 1946 },
  { title: "Life Is Beautiful", year: 1997 },
  { title: "The Usual Suspects", year: 1995 },
  { title: "Léon: The Professional", year: 1994 },
  { title: "Spirited Away", year: 2001 },
  { title: "Saving Private Ryan", year: 1998 },
  { title: "Once Upon a Time in the West", year: 1968 },
  { title: "American History X", year: 1998 },
  { title: "Interstellar", year: 2014 },
  { title: "Casablanca", year: 1942 },
  { title: "City Lights", year: 1931 },
  { title: "Psycho", year: 1960 },
  { title: "The Green Mile", year: 1999 },
  { title: "The Intouchables", year: 2011 },
  { title: "Modern Times", year: 1936 },
  { title: "Raiders of the Lost Ark", year: 1981 },
  { title: "Rear Window", year: 1954 },
  { title: "The Pianist", year: 2002 },
  { title: "The Departed", year: 2006 },
  { title: "Terminator 2: Judgment Day", year: 1991 },
  { title: "Back to the Future", year: 1985 },
  { title: "Whiplash", year: 2014 },
  { title: "Gladiator", year: 2000 },
  { title: "Memento", year: 2000 },
  { title: "The Prestige", year: 2006 },
  { title: "The Lion King", year: 1994 },
  { title: "Apocalypse Now", year: 1979 },
  { title: "Alien", year: 1979 },
  { title: "Sunset Boulevard", year: 1950 },
  {
    title:
      "Dr. Strangelove or: How I Learned to Stop Worrying and Love the Bomb",
    year: 1964
  },
  { title: "The Great Dictator", year: 1940 },
  { title: "Cinema Paradiso", year: 1988 },
  { title: "The Lives of Others", year: 2006 },
  { title: "Grave of the Fireflies", year: 1988 },
  { title: "Paths of Glory", year: 1957 },
  { title: "Django Unchained", year: 2012 },
  { title: "The Shining", year: 1980 },
  { title: "WALL·E", year: 2008 },
  { title: "American Beauty", year: 1999 },
  { title: "The Dark Knight Rises", year: 2012 },
  { title: "Princess Mononoke", year: 1997 },
  { title: "Aliens", year: 1986 },
  { title: "Oldboy", year: 2003 },
  { title: "Once Upon a Time in America", year: 1984 },
  { title: "Witness for the Prosecution", year: 1957 },
  { title: "Das Boot", year: 1981 },
  { title: "Citizen Kane", year: 1941 },
  { title: "North by Northwest", year: 1959 },
  { title: "Vertigo", year: 1958 },
  {
    title: "Star Wars: Episode VI - Return of the Jedi",
    year: 1983
  },
  { title: "Reservoir Dogs", year: 1992 },
  { title: "Braveheart", year: 1995 },
  { title: "M", year: 1931 },
  { title: "Requiem for a Dream", year: 2000 },
  { title: "Amélie", year: 2001 },
  { title: "A Clockwork Orange", year: 1971 },
  { title: "Like Stars on Earth", year: 2007 },
  { title: "Taxi Driver", year: 1976 },
  { title: "Lawrence of Arabia", year: 1962 },
  { title: "Double Indemnity", year: 1944 },
  {
    title: "Eternal Sunshine of the Spotless Mind",
    year: 2004
  },
  { title: "Amadeus", year: 1984 },
  { title: "To Kill a Mockingbird", year: 1962 },
  { title: "Toy Story 3", year: 2010 },
  { title: "Logan", year: 2017 },
  { title: "Full Metal Jacket", year: 1987 },
  { title: "Dangal", year: 2016 },
  { title: "The Sting", year: 1973 },
  { title: "2001: A Space Odyssey", year: 1968 },
  { title: "Singin' in the Rain", year: 1952 },
  { title: "Toy Story", year: 1995 },
  { title: "Bicycle Thieves", year: 1948 },
  { title: "The Kid", year: 1921 },
  { title: "Inglourious Basterds", year: 2009 },
  { title: "Snatch", year: 2000 },
  { title: "3 Idiots", year: 2009 },
  { title: "Monty Python and the Holy Grail", year: 1975 }
];


feat: add Gitpod support

Changes proposed in this pull request:
Add Gitpod support so contributors can start developing in one click
To try https://www.gitpod.io/#https://github.com/bigint/snapshot/tree/gitpod-support

/cc @bonustrack

@bigint Not too familiar with Gitpod, is this something you use?

Yup @bonustrack, gitpod saves my day 😄
One-click to start snapshot within ~10 seconds


Remove scaling from DTW gesture recognition example?

It might be creating lots of false positives against background / resting data.

I believe I did this at some point.


In linux yank command always updates both PRIMARY X selection and CLIPBOARD

Expected behavior:

yank: copy to PRIMARY, don't touch CLIPBOARD
"+y: copy to CLIPBOARD, don't touch PRIMARY

goneovim --version
nightly-1-g531049e

Opened by mistake.
Work fine according 'Clipboard' parameter in settings.toml


Use static lambda in config

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
❌

Don't know if we need any more changes due to the version bumping.

👍


lookupFiles not work with workspace folder

I work with multi projects and expect only scan current workspace folder when editing file. Here is my vscode configuration, but it doesn't work
settings.json
  "cssVariables.lookupFiles": [
    "${workspaceFolder}/**/*.css",
    "${workspaceFolder}/**/*.scss",
    "${workspaceFolder}/**/*.sass",
    "${workspaceFolder}/**/*.less"
  ]

vscode workspace
workspace
-- project1
---- index.css  // expect only scan css files under project1
-- project2
-- ...

Is there any workaround for this?


boot2docker google group

I have created boot2docker google group https://groups.google.com/forum/#!forum/boot2docker
That could make more easier to post questions there and etc

Closing as the google group has been removed.  If you feel this issue was closed in error, please comment and let us know.


Document guidelines for new WASI proposals

I've attempted to summarize our thoughts from last week's meeting here
to jot down the suggested guidelines for adding a new WASI proposal to
this repository. I've also filled it out a bit with the two proposals we
support at this time.

These guidelines look great!
But is the idea to keep full implementations of proposals within the wasmtime tree (as it seems to be the case for wasi-nn), or just wasmtime-specific glue to more generic code that could be shared with other runtimes?
Nobody's using wasi-common beyond wasmtime. This is sad. Each runtime wrote their own implementation instead, even runtimes written in Rust.
Maybe something we don't want to repeat for other proposals; it is not going to scale well as the number of proposals keeps growing. Having full, and wasmtime-specific implementations of WASI proposals here may not be optimal if we want them to get adoption in the WebAssembly world at large.
So, maybe it would be worth clarifying what exactly would be maintained in the wasmtime repository?

But is the idea to keep full implementations of proposals within the wasmtime tree (as it seems to be the case for wasi-nn), or just wasmtime-specific glue to more generic code that could be shared with other runtimes?

That is the idea, yes. Or at least it's one way to organize things, not the only possible one. But in the interest of full disclosure, I've argued for doing things this way, because I think there's a lot of benefit to it. In particular, we should make it as easy as possible to experiment with proposals, ideally by enabling them by default in the binaries we provide, so content authors don't have to configure and compile their own runtime. That is made significantly harder by keeping the proposals external, to the point that I don't think we should take on that burden.

Maybe something we don't want to repeat for other proposals; it is not going to scale well as the number of proposals keeps growing. Having full, and wasmtime-specific implementations of WASI proposals here may not be optimal if we want them to get adoption in the WebAssembly world at large.

I agree that there's a cost to it, yes. However, there's also a very strong upside, that in my opinion wins out. The standardization process for WebAssembly with good reason requires multiple independent implementations of all features before stabilizing them in the spec. There are multiple reasons for this, and which ones are crucial depends on the nature of the proposal in question. For WASI, I think most of the time the most important one is demonstrating the viability of multiple independent implementations. I know that both in the Wasm context and for JS, this requirement has caught fundamental problems with proposals in the past. And I know that not enforcing it has caused features to be standardized that then turned out not to be implementable. In JS, one of those still exists in the spec and is still shipped by a single vendor.

content authors don't have to configure and compile their own runtime

I am in favor of @tschneidereit's point of making it really easy for users to test new WASI proposals. And I am also not opposed to having a separate repo for the sake of re-use. In wasi-nn's case, re-use is complicated by 1) the fact that the wasi-nn implementation is highly dependent on wiggle and wasmtime-wiggle, 2) Wasmtime provides wiggle/wasmtime-wiggle yet would depend on wasi-nn (a cycle), and 3) that no one is asking to re-use wasi-nn 😄.

And I am also not opposed to having a separate repo for the sake of re-use.

To clarify, I most definitely don't want to say that we should somehow actively oppose separate repos and discourage re-use. While there are risks attached to that, ultimately the decisions around those need to be managed by proposal champions, and aren't something we can somehow address in general guidelines on the Wasmtime side.

In wasi-nn's case, re-use is complicated by 1) the fact that the wasi-nn implementation is highly dependent on wiggle and wasmtime-wiggle, 2) Wasmtime provides wiggle/wasmtime-wiggle yet would depend on wasi-nn (a cycle), and 3) that no one is asking to re-use wasi-nn 😄.

This gets more to the heart of the issue ☺ If we want to encourage use of our tooling around WASI APIs — which seems highly desirable, because it's good tooling 😛 — then these issues seem to apply, and are quite hard to resolve. Until someone goes and does the probably pretty hard work to get them resolved, I think we should assume them as part of the context, and structure our guidelines accordingly.

Ok I've pushed up some stronger wording, and RFC requirement, and explicitly stating what's possible depending on the phase of the proposal.

This is quite out of date at this point, I'll push this up in the future if I get around to it with a rebase.


Restart troubleshooting documentation.

End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Restart troubleshooting documentation.

Give a summary of what the PR does, explaining any non-trivial design decisions
Restarting this documentation with up to date information. Will try to fill this up appropriately. Ideally it should not be filled with bugs that can be resolved through code.

Link of any specific issues this addresses

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:0be1496-nikolaik   --name openhands-app-0be1496   docker.all-hands.dev/all-hands-ai/openhands:0be1496

Alright this is ready now. After chatting with Robert, I kept the documentation in place but removed the README bit. We can point people to the doc if they want to persist that.
I was told this is generally on the radar and in the medium term we are hoping to resolve it.


Decide Bech32 HRP

We need to change the following variables in chainparams.cpp.
bech32HRPs[SAPLING_PAYMENT_ADDRESS]
bech32HRPs[SAPLING_FULL_VIEWING_KEY]
bech32HRPs[SAPLING_INCOMING_VIEWING_KEY]
bech32HRPs[SAPLING_SPENDING_KEY]

そうですね，アドレスはkotoから始まります
PRすれば登録されるかもしれませんが，SegwitのためではないのでSLIP173に該当するかは
悩ましいところですね．

Two notes:

SAPLING_SPENDING_KEY is being replaced by SAPLING_EXTENDED_SPEND_KEY in https://github.com/zcash/zcash/pull/3492 (as we are making every Sapling address deterministic from the beginning).
You'll also need to change the BIP 44 coin type (once you rebase onto 2.0.0+) to match yours (as registered in SLIP 44).

Thanks.
We will modify the above information until Koto 2.0 release.

Nice to see developers of Zcash forks being proactive about avoiding address conflicts, thanks.


Install QIIME 2 Artifact API without full QIIME2 installation.

I'm currently prototyping a python-based microbiome analysis library—just something simple to automate the generation of custom taxa plots and perhaps some scikit-learn based PCA analysis. I wondered if there was a way to access the Artifact API without doing a complete QIIME2 installation? Specifically, I'm interested in being able to open feature-table and taxonomy .qza files.
My core questions are the following:

How would I install just the core QIIME2 framework to support the Artifact API without unnecessary plugins and underlying programs?
Is this download possible through Conda?
Would I have to create a second Conda installer that only installs the python package contained in https://github.com/qiime2/qiime2?
Would there be a workaround for parsing the table out of a .qza file without the Artifact API?

I'm currently prototyping a python-based microbiome analysis library—just something simple to automate the generation of custom taxa plots and perhaps some scikit-learn based PCA analysis.

This sounds awesome! Please share with us when you're ready, we would love to see.

I wondered if there was a way to access the Artifact API without doing a complete QIIME2 installation?

Definitely! I'll post some details below. We are also actively working on rebuilding https://library.qiime2.org to assist with building these kinds of custom deployments, more on that later this year!

How would I install just the core QIIME2 framework to support the Artifact API without unnecessary plugins and underlying programs?

conda create \
  -n my-custom-qiime2-env \
  -c qiime2 \
  -c conda-forge \
  -c bioconda \
  -c defaults \
  --override-channels \
  qiime2

If you want common data types, include q2-types in that list above.

Is this download possible through Conda?

Yes! Please see above. https://anaconda.org/qiime2

Would I have to create a second Conda installer that only installs the python package contained in https://github.com/qiime2/qiime2?

Please see my response above with the conda create ... command.

Would there be a workaround for parsing the table out of a .qza file without the Artifact API?

QZA files are just ZIP files: mv my-table.qza my-table.zip && unzip my-table.zip.
If you have additional questions it might be helpful to move the discussion over to our Developer Discussion channel on the QIIME 2 Forum, that way more of our community can get involved.

@thermokarst Thanks for the information. When I get the library more fleshed out I'll let you know.


Figure Out How to get systemd to Look at a zpool

Issue Description
Steps to Reproduce (If applicable):
Acceptance Criteria (How do we know when this is done?)
Related Tickets
Additional Info
Output of uname -a:
Environment (physical, VM, cloud provider, etc.):
Other Relevant Info:

Passed to nshalman since he's already found some of the needed hooks.

/etc/systemd-mutable/system -> /data/services


chore: Refactor

Closes #88
Summary

Refactor internal code to make it more reusable, scalable and easier to read

Lol, did you want to support if people do vx.x.x.x? (4th set)
Im not trying to shut you down

i would want the regex to support any version possible lol. before i was like "we should only support v1.2.3 or 1.2.3 because that's the standard" but really it's not the standard. we don't know what the standard should be so we should be inclusive to modules that use wack ass versioning

we can address this in another issue, whilst my opinion is "use v.x.x.x", we probably should add support for it


There are many mistakes in this project

A useless project,  I don't know if it was the author's intention. Some places annotated the code, which made it unable to run.
someone familiar with similar projects can be used for reference, to run it need to change a lot of places.

reference this: https://github.com/Dian-Yi/EverybodyDanceNow-Temporal-FaceGAN/blob/master/README.md


MigrationBuilder::$maxSqlOutputLength is always 0

Any plans to use it? Or possible use it outside the pakage?
https://github.com/yiisoft/db-migration/blob/1ec213d71cd3bf88415ce8f70536b03955252a0b/src/MigrationBuilder.php#L20-L24
Used in one place
https://github.com/yiisoft/db-migration/blob/1ec213d71cd3bf88415ce8f70536b03955252a0b/src/MigrationBuilder.php#L50-L52
Initialized in one place
https://github.com/yiisoft/db-migration/blob/1ec213d71cd3bf88415ce8f70536b03955252a0b/src/Migrator.php#L157-L160

This option must be configurable. Suggest so way:

Add to Migrator constructor:

private ?int $maxSqlOutputLength = null

$maxSqlOutputLength in MigrationBuilder make mandatory.

Add this parameter to package configuration.

Done by #211


Disallow saving branches of foreign scene child nodes  [3.x]

Pops up an error if attempting to save a branch as a new scene if it is the child node of either an instanced or inherited scene. 3.x backport of #56425

@akien-mga Updated this along with the same changes requested for the 4.0 version of this PR

Thanks!

Cherry-picked for 3.4.3.


fix: Fixes storage behavior

Closes #1946
Closes #852
Signed-off-by: Andrii Soluk<EMAIL_ADDRESS>

@soluchok it seems like the test cases are duplicated among the stores. We should have all test cases in one place and subject all implementations to those.

@soluchok it seems like the test cases are duplicated among the stores. We should have all test cases in one place and subject all implementations to those.

I moved common tests to pkg/storage/store_test.go. If I remove duplicates it will decrease test coverage. The idea is to keep common tests in pkg/storage. (responsible for behavior). And each storage implementation should have its own unit tests.


Logtrail support 7.7.1 ?

Could you add support for Kibana 7.7.1 ?
thanks

Might you also please support Kibana 7.8, which just came out? The ELK stack at 7.8 is the first release where all three components support RHEL/CentOS8, see: https://www.elastic.co/support/matrix

@berrywirattama 7.7.1 - https://github.com/sivasamyk/logtrail/releases/download/v0.1.31/logtrail-7.7.1-0.1.31.zip
@ryebread157 7.8.0 - https://github.com/sivasamyk/logtrail/releases/download/v0.1.31/logtrail-7.8.0-0.1.31.zip

thankyou @sivasamyk

Thank you so much @sivasamyk !!!


Support for ctx.todo()

Clear and concise description of the problem
I am using vitest-cucumber which is great. An upcoming release will support the Vitest ctx.skip() option by passing the ctx into the test (like Vitest does) like this:
Then(`the result of test "<id>" should be <result>`, (ctx) => {
      ctx.skip()
})

I know in Vitest this is possible: test.todo('unimplemented test') but that can't be done in vitest-cucumber.
Suggested solution
I would love the option of ctx.todo(myMessage) so I can write all the Gherkin, set the tests to have ctx.todo() then have them work like the test.todo('unimplemented test') does, with the addition of an optional custom message.
Then(`the result of test "<id>" should be <result>`, (ctx) => {
      ctx.todo('Waiting for the client to ok this idea')
})

I think this would be of use to non-BDD testers too.
Alternative
No response
Additional context
Anyway, thanks for a great library!
Murray
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I don't really understand where the optional message is reported? ctx.skip just marks the test as skip and keeps its name.

What I am proposing is that the additional message could appear on the report. Remembering that with BDD the feature files and step definitions are often written before any code and non-developers are often part of that spec development process.
At present, with ctx.skip() it says:
Then the result of test "three" should be 35 [skipped]

What I am suggesting is something like:
Then the result of test "three" should be 35 [ToDo: Waiting for the client to ok this idea]

or just:
Then the result of test "three" should be 35 [ToDo]

meaning this feature is not yet written, or whatever else the team decides it means.
This way, if the client or other non-developers are part of the BDD process they would see these comments in the report. Also, developers have more information about why a test is not executing, rather than just [skipped]. ie all the same reasons for test.todo(), just with more detail.
And, of course, if messages were also allowed in skip() devs could say why it was skipped, and others who cannot see the comments in the test implementation would have more information.
Thanks,
Murray


WIKIDATASEARCH broken when wrapped in with ARRAYFORMULA

Hello!
I am a new volunteer for my local library helping with large-scale data processing. In order to hand off an easy-to-use Google Sheet template for them, I have been relying on ARRAYFORMULA for auto-population of rows. However, it seems like WIKIDATASEARCH breaks when wrapped in ARRAYFORMULA.
Problematic formula where nothing loads: =ARRAYFORMULA(WIKIDATASEARCH(A3:A7))
Similar formula that works: =ARRAYFORMULA("Length of string: " & LEN(A3:A7))
Simplified, reproducible Spreadsheet: https://docs.google.com/spreadsheets/d/1gW_NZp6nd2HsZlO9FaVDAbQOT7F0unmSYNNX1kemjYU/edit#gid=0
Thanks in advance for your help!

Hey Thomas!
Ha, I should've figured that'd be the outcome :) I can certainly try, although I basically have never done JS development [or open source development] haha. But based on the Google App Script docs, it should be very straight-forward.
I believe these would be the AIs:

I don't see any tests for WIKIDATASEARCH, so maybe I'll start with WIKIDATAQID, especially since it seems simple.

QUESTION: Is there an easy way to test my changes in an Google Sheets? Basically, deploy "locally"? It seems the existing tests only confirm the formula produces a non-empty string.

Once I confirm that works, I'll write tests for WIKIDATASEARCH, then upgrade it

FYI: It seems that an example of =WIKIDATASEARCH is missing from your example Google Sheet.
FYI: It seems many of your formulas already produce array results. I'm not sure what format you'd like those formulas to output. (We can also circle back to this later.)

Cheers!

Ha, I should've figured that'd be the outcome :) I can certainly try, although I basically have never done JS development [or open source development] haha. But based on the Google App Script docs, it should be very straight-forward.

Yeah, I'm sorry. I have stopped developing this library myself since it turned into a huge time sink, but I'm happy to merge PRs and review code.

I believe these would be the AIs:

I don't see any tests for WIKIDATASEARCH, so maybe I'll start with WIKIDATAQID, especially since it seems simple.

Yeah, if there's no test, it's probably just an oversight. Sorry for that.

QUESTION: Is there an easy way to test my changes in an Google Sheets? Basically, deploy "locally"? It seems the existing tests only confirm the formula produces a non-empty string.

My flow always was to execute the test file in the code editor. I am not sure if there's a better flow now. I didn't really look into it for too long.

QUESTION: More generally, how do you set up a dev environment for this?

I think https://issuetracker.google.com/issues/36763437?pli=1 is still not fixed. I have just copied and pasted my functions into a new sheet, as unsatisfactory as it was.

Once I confirm that works, I'll write tests for WIKIDATASEARCH, then upgrade it, and upgrade other functions.

Thank you <3

FYI: It seems that an example of =WIKIDATASEARCH is missing from your example Google Sheet. I'll add that in too.

Perfect, just granted you editing rights.

FYI: It seems many of your formulas already produce array results. I'm not sure what format you'd like those formulas to output. (We can also circle back to this later.)

Yes, some of them do. I have no clue what the output would look like in such cases and if it would even be possible. We'll see…

Yeah, if there's no test, it's probably just an oversight. Sorry for that.

Not a problem! They should be super easy to write!

My flow always was to execute the test file in the code editor. I am not sure if there's a better flow now. I didn't really look into it for too long.

Yup, that's fine too.

Perfect, just granted you editing rights.

FYI, inserting a new column caused a data re-load of all existing columns, and not all columns were re-populated with data 😰. The no-results formulas say "Loading..." for a while before showing no results, which implies a timeout issue.

FYI, inserting a new column caused a data re-load of all existing columns, and not all columns were re-populated with data 😰. The no-results formulas say "Loading..." for a while before showing no results, which implies a timeout issue.

This is a super annoying bug, tracked as https://issuetracker.google.com/issues/36759198. It might also be a quota issue. In case an error returns, I return the empty string, which isn't great, but better than returning an error string that might be misinterpreted. I'm not sure if there is a better way to make this fail gracefully.

I have been using these functions for years. Very grateful for them and any improvement in their performance. In the spreadsheet with the examples, I have detected a problem. Cell S2 [=WIKIDATAFACTS("en:Berlin")] returns a #REF! error because there is a function in S9 [=WIKIDATAFACTS("de:Berlin")] 'Array result was not expanded because it would overwrite data in S9'

Thanks Ernesto for the information! I think that was leftover text when I
was trying to debug why no values were showing up. In fact, I don't see the
ERR cell b/c they're still not working for me. Anyway, I've fixed the
problem I caused and removed the text from that cell. Thank you!
On Wed, Sep 1, 2021, 00:24 Ernesto Barrera @.***> wrote:

I have been using these functions for years. Very grateful for them and
any improvement in their performance. In the spreadsheet with the examples,
I have detected a problem. Cell S2 [=WIKIDATAFACTS("en:Berlin")] returns a #REF!
error because there is a function in S9 [=WIKIDATAFACTS("de:Berlin")]
'Array result was not expanded because it would overwrite data in S9'
[image: QJMFsX4rXl]
https://user-images.githubusercontent.com/44771579/131520165-e82c2a78-6ec0-496b-b42a-775357ab401d.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomayac/wikipedia-tools-for-google-spreadsheets/issues/41#issuecomment-909287302,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI5OV3SU3SYMILSZWQWEUATT7TQ3DANCNFSM5CY7PP5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Configure security context of the istio-csr deployment

Description

Our Kubernetes cluster requires deployments to have as minimal of a security context as possible, including infrastructure components
This issue proposes we set the privileges of the Deployment template to a minimal one like Istiod

Will draft a PR later to support this.


When I use the quickstart with python 3.9, it does not work

Here is my code
import discord
from discord_slash import SlashCommand
client = discord.Client(intents=discord.Intents.all())
slash = SlashCommand(client, sync_commands=True) # Declares slash commands through the client.
guild_ids = [789032594456576001] # Put your server ID in this array.
@client.event
async def on_ready():
print("Ready!")
@slash.slash(name="ping", guild_ids=guild_ids)
async def _ping(ctx):
await ctx.respond()
await ctx.send(f"Pong! ({client.latency*1000}ms)")
client.run("my_bot_token_here")
but I get this error
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 969, in _wrap_create_connection
return await self._loop.create_connection(*args, **kwargs)  # type: ignore  # noqa
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/asyncio/base_events.py", line 1081, in create_connection
transport, protocol = await self._create_connection_transport(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/asyncio/base_events.py", line 1111, in _create_connection_transport
await waiter
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/asyncio/sslproto.py", line 528, in data_received
ssldata, appdata = self._sslpipe.feed_ssldata(data)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/asyncio/sslproto.py", line 188, in feed_ssldata
self._sslobj.do_handshake()
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 944, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/bag/disocrdcommands/main.py", line 19, in
client.run("ODE4NDEwMjk1NTI5NzAxMzg3.YEXp-w.lhaizxGl9FINV8SRp4i_AysYfO8")
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/client.py", line 718, in run
return future.result()
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/client.py", line 697, in runner
await self.start(*args, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/client.py", line 660, in start
await self.login(*args, bot=bot)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/client.py", line 509, in login
await self.http.static_login(token.strip(), bot=bot)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/http.py", line 293, in static_login
data = await self.request(Route('GET', '/users/@me'))
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/discord/http.py", line 185, in request
async with self.__session.request(method, url, **kwargs) as r:
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/client.py", line 1117, in aenter
self._resp = await self._coro
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/client.py", line 520, in _request
conn = await self._connector.connect(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 535, in connect
proto = await self._create_connection(req, traces, timeout)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 892, in _create_connection
_, proto = await self._create_direct_connection(req, traces, timeout)
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 1051, in _create_direct_connection
raise last_exc
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 1020, in _create_direct_connection
transp, proto = await self._wrap_create_connection(
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/aiohttp/connector.py", line 971, in _wrap_create_connection
raise ClientConnectorCertificateError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorCertificateError: Cannot connect to host discord.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)')]
Could you tell me what I did wrong.
Kind Regards,
Jakob

mac os?

navigate to your Applications/Python 3.X/ folder and double click the Install Certificates.command to fix this

Not related to this lib.


can you make a vid on how to do this to make it easier add the vid in readme

please it would be ez

![image](https://user-images.githubusercontent.com/80005071/110379259-9ad8a780-8024-11eb-9406-4778a6485791.png)

use the other one that is a template. it is more up to date and easier to modify. please dont spam all my repositories or i wont help you.

please stop spamming. i wont help you. figure this out yourself. literally all you need to do is download the code, get all the requirements, and run it.

?

ok


ignore failed optional deps (not ready)

okay, so this will ignore failed optional deps by just eating the errors.  however, the optional packages are counted towards the total package count, and the object is passed on thru the promise chain as if nothing bad occurred, which might not be what we want.
IMO ignoring the failures is probably sufficient (instead of trying to prune the tree), because if we're running on CI, who cares, right?
what'd be your preferred strategy to test this behavior?
I had to nest the promises or the tap() calls wouldn't work.

Closing this in favor of #27, which does all the smart tree building and removal stuff. I had to go and write npm-logical-tree and do a mark-and-sweep GC to get this working right, so I think it was a bit bigger than originally though. Sorry about that.
Seriously, though, thanks for the contribution! I really hope to see more patches from you in the future. This was super appreciated. <3


Feature request: Session/Total Total

First of all love the idea.
is it possible to calculate the session total in NOK and a "Total Total"?
Example output:
Prices fetched for period 2023-02-25 02:00:00 - 2023-02-25 23:59:59
2023-02-25 12:00 - 12:59 @ 0.8986 NOK (+0.7275%)
2023-02-25 13:00 - 13:59 @ 0.8907 NOK (+0%)
2023-02-25 14:00 - 14:59 @ 0.8986 NOK (+0.7275%)
Session Average: 0.8960 NOK
Session Total: XXX NOK
----------------
Total Average: 0.8960 NOK
Total: XXX NOK

First, I take it you like the project, thank you. :-)
Second, I like your suggestion and see the value in knowing the estimated cost. I'll put it on my todo list. :-)


hx-get (post. etc...) can't work with th:fragment return

When I return html by fragment (EX:  "/tour/sub/detail :: dayFragment" ) then hx-get in fragment (dayFragment) can not run.

Can you elaborate on what exactly you are trying to do and what does not work? What do you mean exactly with "hx-get can not run"?

Closing due to missing information. Feel free to re-open if you can give more information.


review authorizeOps.listAuthorizations

I think the current implementation of authorizeOps.listAuthorizations may be misleading and should be replaced by something else.
The intended use case
When displaying a form we may want to enable or disable certain features (buttons, fields...) based on the actions available to the current user on a specific resource.
Instead of doing multiple calls to the access endpoint we created an endpoint and a function to return all available actions
Shortcomings of the current version
We can only return the available actions as they are inserted into the user policies, this mean that we can't "explain" wildcard actions because udaru doesn't have knowledge about which actions that wildcard group.
This will cause the client using this method to either miss some actions or implement a part of iam js on its side.
Example
Consider a blog with an user (id: user1) with the author policy with statements as follows:
[{
  Effect: 'Allow',
  Action: ['blog:posts:*'],
  Resource: ['/blog/post/23']
}]

The interface shows a form to edit post 23, with a button to publish the post (action: blog:posts:publish), a button to save (action: blog:posts:save) and one to delete (action: blog:posts:delete)
In order to enable or disable those 3 buttons the ui makes a call to the list authorisations endpoint for user1 and resource /blog/post/23.
Our endpoint will return ['blog:posts:*'] which means that the ui:

will disable the buttons (even if the user is actually authorized to use them) if there's no specific code or
have some specific code to check if the user has the correct action or a wildcard (which can easily get out of hand if we also consider blog:* or *, or
implement part of the iam matching algorithm on the client side too

Proposed solution
I propose to remove the list authorization endpoint because it is misleading and it's hard to document those shortcomings and replace it with a version of the access endpoint that accepts multiple actions instead of just one.
This will serve our use case.
In the example above, the ui would call this new endpoint with user1, resource  /blog/post/23 and actions blog:posts:publish, blog:posts:saveand blog:posts:delete.
The endpoint will respond with something like:
{
"blog:posts:publish": true
"blog:posts:save": true
"blog:posts:delete": true
}

@dberesford can you check that I nailed the use case?
@p16 can you check that I correctly interpreted the current state of the list authorizations endpoint?

@paolochiodi I think you are right on the endpoint limitations. At the same time I think we will need to wait a concrete use case to modify it. Your solution seems fine, lets see what comes up in the near future ;)


Scanning on web version is not working?

Scanning on web version is not working?

fixed scan issue on home page


Waking up the target system with WOL

It would be nice to have a feature where the target system can be turned on from a shutdown state using Wake-on-LAN.
Requirements:

Target system supports WOL (mostly motherboard and network card)
Target system is on a wired connection, not on WLAN
Target system and tinypilot device are in the same network/broadcast domain

I could probably implement this. There's a library to do the actual WOL stuff: https://pypi.org/project/wakeonlan/
There are some design decisions to make though. For example, where is the MAC address stored?

Option 1: MAC address has to be entered manually every time from the web interface. Might be inconvenient when the user doesn't know the MAC address but needs to start the system
Option 2: MAC address is hardcoded in a config file. Simple solution, user only needs to configure it once
Option 3: MAC address can be changed from web interface and is stored somewhere permanently. Elegant but slightly more complex solution. This would require some sort of permanent storage, which I don't think exists yet (?)

Cool, this would be interesting. I'd like to go with the simplest solution first and then iterate on it, so Option 1 sounds best.

Thinking about this more, I'd prefer to go the route of connecting directly into the target computer's motherboar. WOL requires fewer connections, but it's an incomplete solution since it can't turn off power or turn on motherboards that are disconnected from the network or don't support WOL.

Connecting tinypilot to the motherboard makes this a way less portable/turnkey solution.
I agree that the ability to turn the system off is an advantage generally, but imo it's not an ideal solution for all users. Normally, the system can be turned off from the OS.
There might also be issues with warranty when opening up systems to connect tinypilot to the motherboard.

Crazy Idea but what about something like an ESP32 in the case connected over bluetooth?


Repro .NET CLI content failing with .dotfiles

This is a bug on Linux that we need to demonstrate and file against .NET CLI.

@andschwa Still relevant?

I don't think so. This was reported by @JamesWTruher and we intended to provide a repro so it could be fixed... but .NET CLI has undergone so much churn we'd have to see if it's even still a bug.


Length of an array

Title of programme
Write a GO programme to find the length of an array.
Additional information
No response
Code of Conduct

[X] I have read and agree to the Codinasion project's Code of Conduct

I can pick this up.


Merge master into sigma

Integration tests still fail. Will fix it on Tuesday.

This pull request fixes 3 alerts when merging 2f337b3c770915cb8f161525fb8065a7533eab67 into<PHONE_NUMBER>1abd8fbed98f6f5547d58e0a94e8eb - view on LGTM.com
fixed alerts:

3 for 'import *' may pollute namespace

Comment posted by LGTM.com

This pull request fixes 3 alerts when merging 4fe8965fe8e0e9566e108cddef81d7241eb78cfa into 8a33b1378a6c91033025307d6d4b2a1f202894b8 - view on LGTM.com
fixed alerts:

3 for 'import *' may pollute namespace

Comment posted by LGTM.com

Putta please fix conflicts.

@levonpetrosyan93 after discuss with @thebevrishot I think we don't need this fore the first release so I will fix it after the first release.

This pull request fixes 3 alerts when merging<PHONE_NUMBER>f561e0f4f425eede52936a085e88c6 into 8b7d49ef63387ab7b813ea95844369fb08995ef4 - view on LGTM.com
fixed alerts:

3 for 'import *' may pollute namespace

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

This pull request fixes 3 alerts when merging 7fd1ba79872c3060b7253c751fcaa455a35816f9 into 8b7d49ef63387ab7b813ea95844369fb08995ef4 - view on LGTM.com
fixed alerts:

3 for 'import *' may pollute namespace

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

Seem like we need this before mainnet release otherwise the Zerocoin disable patch will not there.

Is this PR ready to be merged or anything outstanding?

This one is ready to merge just but need two reviewers.


[DNM] Benchmark Follower Read

Signed-off-by: 5kbpers<EMAIL_ADDRESS>For test.

/bench tidb=pr/14017 +ycsb
  workload:
    workload: workloade
    mode: mysql

/release

/bench +ycsb
  workload:
    workload: workloade
    mode: mysql


Chips Demo in Gallery not accessible

For the chips with the delete button you can only focus on the delete button. You can't focus the chip text.
The focus frame around the different titles of this page are also to big.
/cc @gspencergoog

In another app with chips I noticed that the entire button is tappable instead of just the X

@jonahwilliams was that a Flutter app?

I've improved the tap handling of the demo - however we should consider updating the demo to not use the "X" icons.

How would that work exactly?  They need to have delete buttons for the demo to function (part of the demo is removing things and seeing the available actions change).  Or do you just mean to literally use a different icon for the delete icon?

From the internal guidelines - chips on touch devices should not show the secondary trailing affordance by default.  I think it is probably okay since it is really just a demo of the capabilities.

This is mostly done, but I have not implemented the semantics for chips with 2 or more actions since they are not supported for accessibility on mobile devices

The material chips on android have separate semantic nodes for the delete button on all chips (they also show a demo of a chip that is both selectable and deletable)

Closing since the gallery works as expected. But opened https://github.com/flutter/flutter/issues/48739 for better behavior when there is a delete option


fix(reactivity): optimising getDepFromReactive

ObjectRefImpl in toRef depends on getDepFromReactive

Avoiding ?. is intended to reduce the file size, but it looks like this has increased it by 3 bytes. I was curious about why...
It looks like the ?. version gets inlined into the get dep getter in ObjectRefImpl. Even though it expands to something fairly verbose, the inlining shaves off lots of bytes. Removing the ?. seems to prevent that inlining, leading to a larger build.
I did a bit of experimenting, and the best I could do just by rewriting getDepFromReactive was this:
export const getDepFromReactive = (
  object: any,
  key: string | number | symbol,
  depMap = targetMap.get(object),
): Dep | undefined => {
  return depMap && depMap.get(key)
}

It's a bit hacky, but it got it down from +3 to -8.
But this still doesn't benefit from the inlining seen with the original code.
So I tried just rewriting the get dep in ref.ts:
  // `import` changes not shown

  get dep(): Dep | undefined {
    const depMap = targetMap.get(toRaw(this._object))
    return depMap && depMap.get(this._key)
  }

This got it down to -26, with small improvements in the zipped versions too:

File
Size
Gzip
Brotli

runtime-dom.global.prod.js
101 kB (-26 B)
38 kB (-16 B)
34.2 kB (-43 B)

vue.global.prod.js
160 kB (-26 B)
58 kB (-15 B)
51.5 kB (+12 B)

The downside being direct access of targetMap in ref.ts.
I'll let others decide whether any of this matters... :laughing:


[TC-437] - adds the ability to generate an ISO to the api / traffic portal v2

Can one of the admins verify this patch?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/4/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/6/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/7/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/8/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/9/

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/10/

The ISO created was verified in this manner:
sudo mkdir /mnt/iso
sudo mount -t iso9660 -o loop this-is-the-iso-created.iso /mnt/iso/
df -h
cd /mnt/iso
sudo cat ./ks_scripts/password.cfg
sudo cat ./ks_scripts/network.cfg
sudo cat ./ks_scripts/disk.cfg
sudo cat ./ks_scripts/state.out


ModuleNotFoundError: No module named 'src.dependencies.FRNN'

I tried running the demo on Colab notebook, I am getting the following error:
superpoint_transformer-master/src/utils/neighbors.py in
      1 import torch
      2 import src
----> 3 from src.dependencies.FRNN import frnn
      4 from torch_scatter import scatter
      5 from torch_geometric.utils import coalesce

ModuleNotFoundError: No module named 'src.dependencies.FRNN'

This means FRNN has not been properly installed. Likely a compilation issue. Check out the other FRNN-related issues in this project to debug your case.
Although I must warn you, we have not tested installing this project in a Colab, and we do not provide support for it.
PS: if you ❤ or use this project, don't forget to give it a ⭐, it means a lot to us !


Cannot Run Wisdom-tree --

Tried almost everything on google nothing works

After a lot of fixes stuck here

Uninstalled Python and installed old version 3.0.8
also
BIOS virtualization on
pip install virtualenvwrapper --upgrade


Controller observables incorrectly mapped in WebXR

Bugs
Repro playground: https://playground.babylonjs.com/#AM07G2#21
Note: In that playground, the usual "view in headset" button doesn't work for some reason. Click the color picker GUI instead.
I'm using an HP Windows Mixed Reality Headset on Chromium-Edge 79. In XR mode, you can see in the console that the observables hooked up to the gamepad controller don't map sensibly to the observable names. I'm getting this:
hardware trigger --> pad observable
hardware grip button --> trigger observable
hardware touchpad --> main button observable
hardware thumbstick --> secondary button observable (only on click)

The WebXR API is actually using the gamepad API at the moment. Is it the same in WebVR? or is it just an issue with XR?

I'm only seeing an issue in WebXR.

very interesting :-)
But I am very happy to read that I can use my mixed reality with edge now. Just downloaded edge canary, I will check and let you know.

I can confirm the mapping is different on my device as well.
I will create different classes for the XR controllers and make the old ones deprecated.
I can't find a reason why anyone will decide to change the mapping, unless it is related to OpenXR (not sure it is) and standardizing the gamepad buttons. I'll give'em the benefit of the doubt :-)

Not yet implemented

@RaananW is there an ETA on when this fix will make it to a release?

Working on that today, will probably be done by the end of the day


Fix: website crashes on rinkeby search

Closes: #901
Changes proposed in this PR:

Using optional chaining on the description to stop the market crashing when there is an asset without a description (this happens sometimes on test nets)

The website crashes at the moment with searches on Rinkeby. To replicate, search for "RUMNAR-48" while on Rinkeby. See here for example.


Single tech/databricks 146 vnet injection

Purpose

ADB workspace is deployed in a dedicated VNET

Note: We decided to have a separate task to organize README so I didn't update the documentation for this task.
Does this introduce a breaking change?

[ ] Yes
[x] No

Validation

create the following environment variables:
export DEPLOYMENT_PREFIX=<PREFIX FOR RESOURCE NAMES>
export AZURE_SUBSCRIPTION_ID=<SUBSCRIPTION ID TO USE>
export AZURE_RESOURCE_GROUP_NAME=<RG NAME>
export AZURE_RESOURCE_GROUP_LOCATION=eastus
export DELETE_RESOURCE_GROUP=false

cd sample2_enterprise_azure_databricks_environment
./deploy.sh

cd sample2_enterprise_azure_databricks_environment
./destroy.sh

Author pre-publish checklist:

[ ] Added test to prove my fix is effective or new feature works
[x] No PII in logs
[ ] Made corresponding changes to the documentation

Issues Closed or Referenced

Closes #146

As we discussed in the call, I put all variables at the top to avoid duplication.


Connection Placements

I can not add any connections to grid after swapping from placing features, to select, back to placing features.

I think I figured out why this was happening. I addressed it in commit - d401afe. Now I reset the tool states on exiting so it should be ok.


Sync to upstream/release/559

Fix autocompletion of if-then-else expressions
Fix a potential crash surrounding improper use of %* in a string format specifier

Probably worth noting:

addition debug output in bytecode compiler to help with ???
Python 3 binary now mandatory for all scripts


Design doc for desired API

Example Response
{
    "roll": "2d6+3d4+3",
    "result": 17,
    "rolls": [
        {
            "roll": "2d6",
            "result": 7,
            "rolls": [
                {
                    "roll": "d6",
                    "result": 6
                },
                {
                    "roll": "d6",
                    "result": 1
                }
            ],
            "expression": "6+1"
        },
        {
            "roll": "3d4",
            "result": 7,
            "rolls": [
                {
                    "roll": "d4",
                    "result": 1
                },
                {
                    "roll": "d4",
                    "result": 4
                },
                {
                    "roll": "d4",
                    "result": 2
                }
            ],
            "expression": "1+4+2"
        }
    ],
    "expression": "(6+1)+(1+4+2)+3"
}

The request handler should recurse and dogfood itself.
Die struct is already available but unimplemented.

roll properties could become size integers or remain a toString()-style representation

Request Flow

Request for 2d6+3d4+3 is broken down into child rolls: 2d6 and 3d4.
Handler calls the API to roll 2d6 and 3d4 individually.
Handler's requests are broken down to down into child rolls: two (2) d6 rolls and three (3) d4 rolls,
Child requests made again to roll the individual d6 dice and d4 dice (5 child requests total)
Child roll results are summed/evaluated and returned back up through the handler stack:

2d6 is replaced with (7+1)
3d4 is replaced with (1+4+2)

Original request is evaluated: (6+1)+(1+4+2)+3 → 17
Final 17 is returned to the requester along with full roll stack.

Revised API
Roll Dice

Method
Path

POST
/roll

Parameters

dice (string: ) - Dice notation string to evaluate. Since dice notations often have URL-unsafe characters sending the payload to roll via a POST payload would be ideal.

Sample Payload
{
  "dice": "1d20, 2d6+1"
}

Sample Response
...

Roll Dice via GET

Method
Path

GET
/roll/:dice

Parameters

dice (string: ) - URL-safe dice notation string to evaluate. This should be limited to creating and rolling dice sets XdY that do not possess modifiers.

Advantage

Method
Path

POST
/adv

Parameters

roll (string: ) - Dice roll to evaluate twice and return the higher result.

Sample Payload
{
  "roll": "1d20+1"
}

Sample Response
{
  "result": 16,
  "rolls": [
    {
      "roll": "1d20+1",
      "result": 9,
      "rolls": [
        {
          "roll": "1d20",
          "result": 8
        }
      ],
      "expression": "(8)+1"
    },
    {
      "roll": "1d20+1",
      "result": 16,
      "rolls": [
        {
          "roll": "1d20",
          "result": 15
        }
      ],
      "expression": "(15)+1"
    }
  ],
  "expression": "max(9, 16)"
}

Todo

[ ] blind parameter request only the result of the roll and not the full roll stack.
[ ] return HTTP 400 for malformed requests.


Check information retrieval and display

Describe the task
Check information retrieval and display
Actual: Some information is displayed very slowly

Staking detail information

Version test: v1.0.7(187)
Devices test: IP 11
Validation passed.


can't emit import when overwrite declare

TypeScript Version:  3.2.0-dev.201xxxxx

Search Terms:
Code
import hashSum = require('hash-sum');
import shortid = require('shortid');

declare function shortid(): string
declare function hashSum(input): string

export function hashAny(seed?, ...argv): string
{
	if (!seed)
	{
		seed = shortid()
	}
	else if (typeof seed !== 'string')
	{
		seed = hashSum(seed)
	}

	return String(seed)
}

export default hashAny;

Expected behavior:

output js file include

const hashSum = require("hash-sum");
const shortid = require("shortid");

Actual behavior:

miss require hash-sum, shortid

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
function hashAny(seed, ...argv) {
    if (!seed) {
        seed = shortid();
    }
    else if (typeof seed !== 'string') {
        seed = hashSum(seed);
    }
    return String(seed);
}
exports.hashAny = hashAny;
exports.default = hashAny;

Playground Link:
Related Issues:

If you declare the hash-sum module (e.g., declare module 'hash-sum'; in a separate file), then you get an error, Import declaration conflicts with local declaration of 'hashSum'.  There are no guarantees on whether the import is emitted in the presence of that error.  I think the bug is that you don't get the error about the conflict when the module can't be found.

Aye, we should still be issuing the error that it overwrites the import even if the import is amy from being not found, ideally. This is probably a follow on error that's worth keeping.


Implement parser for rational literal types

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution. I'm mostly +1 with the above comments from @cd1m0. If there would be any blockers for you to introduce the changes, just inform us. I will consider picking up the branch and doing the rest in that case.

Thanks, should be good to go?


unable to merge ovalues

Seeing this message in carbonzipper logs:
request: /render/?format=protobuf&from=1488213577&target=big.long.metric.name&until=1488299977: unable to merge ovalues: len(values)=8640 but len(ovalues)=1440
Not sure what to do here, or what info you need to diagnose. Any help would be appreciated.

Your carbonzipper is receiving (at least) 2 series for big.long.metric.name in the from=...&until=... window.

A: has 8640 points (10s)
B: has 1440 points (60s)

When A has a missing value it attempts to fill it in from B. Since these two series have different sizes carbonzipper can't trivially find the corresponding point in B and so warns in the log and performs no merging; you get just A.
If you actually have 2 copies of big.long.metric.name that are at different retentions it would be best to choose one and make them the same.
But it seems likely that your requests are right on a rollup boundary and you are seeing a race where one store is returning the high-resolution (10s:1d) version and another the low-resolution (60s:7d perhaps). Extending your query just beyond the boundary (from=-1d1s&until=now) should force the stores to choose a consistent retention band. If that helps then you can work to reduce the race by improving write throughput/latency and time sync.

Thanks for your response @nnuss , I really appreciate it. :)
This is actually sumSeries(big.long.*.wildcard.series.name), and as we're using Grafana for visualization the timespans of the queries often do fall on the aggregation boundaries. Does that change things at all? Or perhaps the series being summed are of different storage schema retentions?

Also, if I'm not able to find any discernible different in the storage schema retentions, what should I look for?

Another piece of interesting information is that if I point carbonapi right at carbonserver, data for the last 24 hours (which is coincidentally the first aggregation window) just doesn't show up, but everything prior to that does (e.g. in a 7 day view, last arbitrary 24 hours is gone).

Another interesting piece of information is that if I point carbonapi directly at carbonserver, I only get data beyond the last 24 hours.

It's worth noting that none of this happens when I source data via Graphite-Web.

sumSeries(some.*.glob.{or,brace}) doesn't change this situation.

Carbonzipper never sees the function, that is parsed and handled by carbonapi, graphite-web, grafana, etc.
Carbonzipper passes the glob expression to the store to resolve. The results are actual names and data.

If the storage-schemas.conf are consistent you can check carbonzipper.example.com/info/?target=some.specific.series shows the hosts' files have consistent definitions. We would expect they do - but if one happened to be written when a prior config was in place and not cleaned up they could still vary.
When you request now-7d from carbonapi<->carbonserver the result does not have points 24 hours old or newer?

The data displayed in the /info path brought into question an architectural decision I made: I had multiple carbonserver back-ends configured in carbonzipper.json, me thinking I was being super clever by running many processes in parallel. After reducing the back-ends to one, the errors about merging ovalues have disappeared from the carbonzipper logs.
It also looks like I made an observational error -- data served from the carbonserver/carbonzipper/carbonapi stack is truncated at a very specific date/time, yesterday at ~4:28pm local time, whereas Graphite-Web seems to disagree and render everything received since then.
Check this out: http://imgur.com/a/EnuJg

Can you post what /info says in this case?
In our setup we also have all carbonserver (actually it's go-carbon now) configured as backends for carbonzipper and this was actually a purpose for creating zipper.
Also is graphite-web also talks to carbonserver or carbonzipper?
And one more thing - you have the files with the same retention on all the storages, right? Or different backends have different retentions?

@Civil
Thanks for your reply. :)
{"http://<IP_ADDRESS>:5004":{"name":"big.long.series.name","aggregationMethod":"Average","maxRetention":31536000,"xFilesFactor":0,"retentions":[{"secondsPerPoint":10,"numberOfPoints":8640},{"secondsPerPoint":60,"numberOfPoints":20160},{"secondsPerPoint":300,"numberOfPoints":8640},{"secondsPerPoint":1800,"numberOfPoints":8640},{"secondsPerPoint":3600,"numberOfPoints":8760}]}}

The same block was spammed in /info for each configured back-end when I had multiple carbonserver back-ends in play.
We're also using go-carbon (technically this is a POC of go-carbon vs carbon-cache.py). The Graphite-Web instance talks to go-carbon via the Carbonlink listeners at the moment.
We're only using one carbonserver back-end at this point. I have quintuple-confirmed in a couple different ways now (/info, whisper-info.py) that all the DBs I'm working with here have the same storage schema retentions configured. :)

Welp, looks like I was actually querying graphite-web powered by carbon-cache.py on a different server in that Imgur link. When I query graphite-web powered by go-carbon it does the same thing with the truncation of the data at ~4:28pm on 2/27. Seems to isolate things to go-carbon at this point.


Add local preview documentation and message

As discussed in #89, this PR adds documentation on how to preview the html files locally, and adds to the build message a full path link to the html files.

done 👍

perfect - thanks so much for the patch :-)


The run test button not working

Describe the Issue
The run test buttton is not responsive on several test if not more on the JavaScript Algorithms and Dara Structures certification
This is a list of test where the button is not ### working(There may be even more test that are not working, they all need to be checked):
-Appending Variables to Strings
-Finding the length of a string
-Use bracket notation to find the first character in a string
-modify array data with indexes
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures
Your code

const myArray[0] = 45;
Expected behavior
[45, 64, 99]
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

@thebestprince could share your code for a specific challenge? From what you've shared, it looks like the tests aren't running because the code has a syntax error.
Since the error is shown in the console, I don't think there's anything we need to fix.

Hello, I checked multiple tasks on Javascript Algorithms and Data Structure certification, but I don't find the issue you mentioned. The button is responsive and working. Please check again, and if you face the issue do share the specific task link.
Thank You

Thanks for reporting @thebestprince, I don't think there's an issue here either. As far as I can tell, the code has a syntax error and the expected behavior is happening.
With that, I am going to close this. If you think I'm wrong, let me know and we can reopen it. Thanks that happy coding 🎉

Hey Tom I keep trying to put the solution in on my computer and I am not
even getting the error message.
On Thu, Jun 22, 2023 at 11:13 AM Tom @.***> wrote:

Thanks for reporting @thebestprince https://github.com/thebestprince, I
don't think there's an issue here either. As far as I can tell, the code
has a syntax error and the expected behavior is happening.
With that, I am going to close this. If you think I'm wrong, let me know
and we can reopen it. Thanks that happy coding 🎉
—
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/50723#issuecomment-1602950336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU3TKAEOVNBCQ7HQFLEJGDDXMRVK5ANCNFSM6AAAAAAZITVF54
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
United Airlines
Japanese Interpreter
DePaul University '15
Kansai Gaidai University '14
Japanese Studies  Intercultural Communication

Can you share the challenge you are on and the code you are trying to use?

Yes, I will.
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/modify-array-data-with-indexes
On Thu, Jun 22, 2023 at 4:23 PM Tom @.***> wrote:

Can you share the challenge you are on and the code you are trying to use?
—
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/50723#issuecomment-1603335361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU3TKABUPEQC6WXKBIL5BITXMSZVRANCNFSM6AAAAAAZITVF54
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
United Airlines
Japanese Interpreter
DePaul University '15
Kansai Gaidai University '14
Japanese Studies  Intercultural Communication


Implement multi-value Wasm proposal

Closes https://github.com/paritytech/wasmi/issues/308.
Note that this PR does no real implementation as it turned out that multi-value is already pretty much supported. So the only thing that this PR does is to allow to enable multi-value Wasm proposal support via the wasmi_v1::Config type. Also this PR integrates the Wasm spec testsuite tests for the multi-value Wasm proposal.

Codecov Report

Merging #357 (fae6a2b) into master (8830ee3) will increase coverage by 0.12%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   78.70%   78.82%   +0.12%
==========================================
  Files          96       96
  Lines       10852    10867      +15
==========================================
+ Hits         8541     8566      +25
+ Misses       2311     2301      -10

Impacted Files
Coverage Δ

wasmi_v1/src/engine/mod.rs
83.19% <90.90%> (+0.62%)
:arrow_up:

tests/spec/v1/context.rs
77.98% <100.00%> (ø)

tests/spec/v1/mod.rs
100.00% <100.00%> (ø)

tests/spec/v1/run.rs
72.84% <100.00%> (ø)

wasmi_v1/src/module/parser.rs
78.18% <100.00%> (+0.13%)
:arrow_up:

wasmi_v1/src/engine/func_builder/mod.rs
92.18% <0.00%> (+0.13%)
:arrow_up:

wasmi_v1/src/engine/exec_context.rs
96.80% <0.00%> (+0.16%)
:arrow_up:

wasmi_v1/src/module/compile/block_type.rs
95.45% <0.00%> (+20.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8830ee3...fae6a2b. Read the comment docs.


HTTP semantics specify "trailer" header SHOULD be sent in response when trailers are expected.

It is not clear to be how the gRPC HTTP/2 specification should be interpreted and I believe it can be clarified which would be useful for client and server implementors.
https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
I believe it's expected the client should include te: trailers in the request. This appears to be suggested in the linked doc.
What's not clear, is how the response should specify trailers.
The HTTP core semantics (which would be a good reference for HTTP/2 proxy implementations handling gRPC traffic) states:

6.5.2. Processing Trailer Fields
The "Trailer" header field (Section 6.6.2) can be sent to indicate fields likely to be sent in the trailer section, which allows recipients to prepare for their receipt before processing the content. For example, this could be useful if a field name indicates that a dynamic checksum should be calculated as the content is received and then immediately checked upon receipt of the trailer field value.

And more specifically:

6.6.2. Trailer
The "Trailer" header field provides a list of field names that the sender anticipates sending as trailer fields within that message. This allows a recipient to prepare for receipt of the indicated metadata before it starts processing the content.
Trailer = #field-name

For example, a sender might indicate that a signature will be computed as the content is being streamed and provide the final signature as a trailer field. This allows a recipient to perform the same check on the fly as it receives the content.
A sender that intends to generate one or more trailer fields in a message should generate a Trailer header field in the header section of that message to indicate which fields might be present in the trailers.

This seems to imply that gRPC response should include at the very least, trailer: grpc-status, grpc-status-message to be well formed w.r.t. the above http-core document.
The alternative would be to explicitly call out that gRPC does not use or require the trailer header so at least we understand that it deviates from the HTTP specification in this regard.
There is some additional discussion about the problems this introduces for conforming HTTP/2 clients here: https://github.com/socketry/async-http/pull/92
Any clarification in this regard would be most appreciated.

Craig, Can you help to provide clarification here and maybe you know some history here.


Bug: the list of solutions of a challenge remains accessible from the next one using the keyboard shortcuts

Original report.

@Atervanda I can't seem to reproduce this, is it working consistently on your side?

I can't reproduce this anymore either. So, fixed? ¯\_(ツ)_/¯

Thanks for checking, I guess it is then!


Feature/713/services

Initial services implementation for dockstore/dockstore#2450 by basically putting a bunch of if statements in the workflow components
Started using unmodified prettier for HTML and slightly modified (single quote, max-length 140) prettier for Typescript so
Remove whitespace changes when viewing diff
Additions/Modifications:

Service component has fewer tabs than the BioWorkflow equivalent
Service component has no forms to edit values
Service component's info tab got stripped
My Service component only has the new "Manage on GitHub" button
My Service component also has a "Modify Organization on GitHub" button for each organization the user belongs to + themselves (i.e. I can use GitHub apps on the Dockstore organization and myself garyluu)
There is now a /services route that behaves similar to /workflows (but pull services instead)
/services/:id behaves the same as /workflows/:id
CI: Reset the DB in a way that's more similar to the webservice
githubCallback route that redirects to the correct page
dockstore/dockstore#2546

TODO:

Polish
Better error handling
Better tests (use real services)
User actions on services (starring, registering, etc)
Variable for app name

Undoing the formatting changes will take far too long at this point I don't believe it's remotely worth it

There was an attempt: https://github.com/dockstore/dockstore-ui2/pull/678

There was an attempt: #678

How does it look after running kdiff3 on the easy merges?

way too many conflicts

https://git-scm.com/docs/git-mergetool has a few other possibilities meld and emerge I've never tried.
Failing that, I've heard some have had success with an interactive rebase claiming that it can be easier to work through conflicts commit by commit rather than in one big merge)


Invalid deployment name when it contains a / (forward slash)

Description
Hi.
We are currently using codepush to create deployments for each branch and we use the current branch name as the deployment name.
The command we use the following
appcenter codepush deployment add -a <ownerName>/<appName>  --token $BRANCH_NAME
When the branch name contains a / (forward slash) e.g. feature/my-new-feature the command fails with
[{"field":"name","message":"Field is invalid"}]
Not 100% sure this is a bug, but I didn't find any documentation regarding allowed names for the deployment
W
Repro Steps
Please list the steps used to reproduce your issue.

Create a brand new app name
Add a user token
Run the command appcenter codepush deployment add -a <ownerName>/<appName>  --token test/this-will-fail

Expected behavior
Expected the command to succeed and a deployment with name test/this-will-fail to be created
Details

Is there a particular beacon/command that you are having trouble with?

appcenter codepush deployment

Which version of the App Center CLI are you using?

appcenter version 2.10.8

Which OS version did you experience the issue on?

macoS Monterey 12.1

What command line/shell are you using?

default macOS terminal, zsh

What version of Node.js and NPM/Yarn are you using?

npm version 8.3.0, node version v17.3.0

Additionally, you can provide verbose logs of a CLI command by using DEBUG="appcenter-cli:*" before the command, for example, DEBUG="appcenter-cli:*" appcenter apps list. Include the logs here, don't forget to omit any personal/sensitive data.
See https://gist.github.com/allisothebys/86a2660e575877a09fcb142a17acdd99

Hi @allisothebys , thank you for reaching out to us!
We are currently investigating this issue. I will updated you on the progress.

Hi @allisothebys , we filed a bug on our board. It will be addressed on the backend side, but no ETA at this moment.

@DmitriyKirakosyan Thanks for the update 👍

Any update to share? @DmitriyKirakosyan

Unfortunately, no updates. The team is busy with other high priority tasks.

Hi @allisothebys , actually, this is not a bug, but a feature we don't support.
We are not planning to add this functionality, so I'm closing it as an expected behaviour.
I'll update the command description to make it visible and clear from the command line.

Thank you for the clarification 👍


chore: Make sure discard changes for git is applied even if client exits the flow before server responds

Fixes #11665

/ok-to-test sha=73a0b75


Consume new error/problem payload

This is the UI counterpart issue for zalando/pazuzu-registry#41.
A new error payload structure has been implemented in pazuzu-registry in accordance to application/problem+json which now needs to be properly consumed by the UI. Example payload:
{
   "type" : "http://pazuzu.io/error/fency_exception",
   "title" : "This is a fency exception",
   "status" : 400,
   "detail": "Request was not fency enough to be fulfilled"
}

The mapping from the previous structure looks like following:

"code" is now returned as part of the "type" URL
"message" is now returned as "title"
"detailed_message" is now returned as "detail"

Resolved in #60


Spellchecking related changes remove entities

I just noticed that when I have an entity applied to a range and then use the browser's spellchecking functionality to change a word, the entity is removed. PR to fix this issue: https://github.com/facebook/draft-js/pull/276

Let's be sure this works as expected for all mutability types, as discussed in Slack. :)

@hellendag It works for MUTABLE and SEGMENTED but it fails for IMMUTABLE. For IMMUTABLE I assume we'd want to remove the entity when a change occurs - right now it keeps it even though the text changes.

@johanneslumpe I think that's correct, yeah. If it's an IMMUTABLE entity, setting null is probably more appropriate.

@hellendag With the latest commit the entity gets removed correctly if it is IMMUTABLE, but when using ctrl+z to undo it, the block content is copied from the beginning of the entity to the end of the block and applied to the end of it. A gif might explain it better:

Does your current PR commit resolve the issue above?

Unfortunately it does not. I haven't yet been able to figure out what the issue is with immutable entities and undo.

@hellendag Thinking about this more: I just fun for re-read the explanatory text in the gif above. And in that case we shouldn't remove the whole entity but only from a sub-range?

If a character is added within an entity:

IMMUTABLE entity: remove the entity, insert the character
SEGMENTED entity: same as above

If a character is deleted within an entity:

IMMUTABLE: remove entire entity string
SEGMENTED: remove segment of string, delimited by whitespace

To see this in action, use a Facebook input and mention two things: 1) a Page and 2) a friend. Pages are IMMUTABLE, and friends are SEGMENTED.

@hellendag The culprit for the weird insertion at the end of the content is this:
https://github.com/facebook/draft-js/blob/master/src/component/handlers/edit/commands/keyCommandUndo.js#L28
If we let the browser handle the undo, then it will insert the content at the end of the block due to the changed DOM structure I believe because it cannot figure out where to put it. When I removed that part, the undo feature worked fine, which would mean that I only need to fix segmented entities as they currently do get partially removed when a character within them is removed.
Let me know what your thoughts on this one are. I personally think that correct handling of entities is more important than trying to have the browser not suggest a change again.

Ah, that makes sense. Nice sleuthing.
I think you can get around this by using apply-entity as the EditorChangeType (instead of spellcheck-change) in editOnInput.js, for the SEGMENTED and IMMUTABLE cases. This way, when undo occurs, it will not fall through to the browser.

@hellendag Check out the latest version of https://github.com/facebook/draft-js/pull/276 - I think I fixed all possible cases for entities!


Access to fetch at 'https://backend.mydotcom.com/authentication' from origin 'https://frontend.mydotcom.com' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Hello everyone, thank you in advance for reading. My app works fine locally but I'm running into CORS troubles in the production servers. in my expressjs backend server I have:
const cors = require('cors');
app.use(
  cors(
		{ origin: 'https://frontend.mydotcom.com',methods: 'GET,PUT,POST,OPTIONS', allowedHeaders: 'Content-Type,Authorization' , credentials: true }
  )
);

and in the front end server that servers the REACT app , I have
const cors = require('cors');
app.use(cors(
  {
    credentials: true
  }
));

But I get the error : Access to fetch at 'https://backend.mydotcom.com/authentication' from origin 'https://frontend.mydotcom.com' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
I have tried many different configurations but I am unable to get it working. Please help !!!!!!

I am pretty sure:
app.use(cors(
  {
    origin: 'http://example.com/',
    credentials: true
  }
))

Covers options too, right?

Yes, it does. In order to determine what is wrong with the OPs issue, we need to OP to paste all the headers in the preflight request.

Is there any solution ? as I am still facing the same problem

Might be related: https://github.com/expressjs/cors/issues/230#issuecomment-916982872

To me, this problem happens when the request takes too many time to respond.
I think that is a preflight problem!

I just faced this problem, after configuring the express app to use the cors configuration. Added callback functions to see what was being logged, everything looked well.
...then I realized, I initialized some routes prior to configuring the express app to use cors. So I post this here in case anyone misses this like I did.  Check the execution of everything in your index file (wherever your express object is initialized), in case you have some routes lurking about that were initialized prior to adding the cors configuration being used.

Since it has been months and haven't heard back from my request for more information from the OP, I'm going to close this issue. If other are having the same issue, open your own issue and include all relevant details to your specific situation.


Update ReadMe Documentation

Problem Statement

The ReadMe should highlight that this action is simple to use, but still flexible.
Proposed Solution

Update the ReadMe to highlight the usage.

[ ] Create a new "Usage section right after the overview

[ ] Highlight that inputs are not required for the basic config but can be used to customize the build config.
[ ] Document the basic conda config required to run the action
[ ] Add an example of simple usage in a workflow

[ ] Add notes and an example workflow showing how to use a custom yml conda build env description file.

Alternatives Considered

Proposed Action Plan

[ ] 1. Update the ReadMe using the guidelines described in the solution.
[ ] 2. Add a test case which uses a custom build.yml env definition file.

this is what i have so far for the readme, wasn't sure how to call the specific action --> working on finding that now
@curtisma

Ok, go ahead and commit what you have.  I'll go in and edit it.


Put t or f when default is a boolean

Boolean defaults somehow gets a blank value when generating migrations.  Here's a simple patch to have have 't' or 'f' when it's a boolean value.

Ah, this one relates to #79. Awesome! Thanks so much for the PR.
Shouldn't it rather put true/false in than 't'/'f'? Or perhaps 1/0?

I can confirm, in PostgreSQL, that 't'/'f' and 1/0 works while using true/false doesn't.  Using true/false results in the empty string ''.  I think 't'/'f' is more readable than 1/0.
On Wednesday, October 26, 2016 4:32 PM, Bernhard Breytenbach<EMAIL_ADDRESS>wrote:

Ah, this one relates to #79. Awesome! Thanks so much for the PR.Shouldn't it rather put true/false in than 't'/'f'? Or perhaps 1/0?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Awesome, will test it on MySQL

Ok, so 't'/'f' doesn't seem to work in MySQL, only 1/0. Also, when generating migrations from MySQL, they seem to return 1/0... So maybe this is only on Postgres?

Ok, I assume Postgres returns True/False, which then ends up being converted to empty strings.
I think your solution is a good one, but I would prefer using 1/0 instead of 't'/'f'. Do you want to update it, or should I change it?
Thanks for fixing this!

I guess there is still a bug with default value for boolean. I got this:
$table->boolean('success', 1)->default('b\'0\'');
PS: Im using MySQL


Add support for range as argument to contains

The documentation states

range: semantics are similar to those of Python 3 even in Python 2: a range object is returned instead of an array of values. The only permitted use of range is as a callable function (cannot pass range as an argument to a jitted function or return a range from a jitted function)

Thus, I would assume I can use range just like in python. A simple example shows that this is wrong:
In [1]: import numba

In [2]: @numba.jit(nopython=True)
   ...: def test(i):
   ...:     return i in range(1, 8, 3)
   ...:
   ...:

In [3]: test(2)

Yields the error:
TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Invalid use of Function(<built-in function contains>) with argument(s) of type(s): (range_state_int64, int64)
 * parameterized
In definition 0:
    All templates rejected with literals.
In definition 1:
    All templates rejected without literals.
In definition 2:
    All templates rejected with literals.
In definition 3:
    All templates rejected without literals.
In definition 4:
    All templates rejected with literals.
In definition 5:
    All templates rejected without literals.
This error is usually caused by passing an argument of a type that is unsupported by the named function.
[1] During: typing of intrinsic-call at <ipython-input-2-3e00fb68c4e2> (3)

File "<ipython-input-2-3e00fb68c4e2>", line 3:
def test(i):
    return i in range(1, 8, 3)
    ^

This is not usually a problem with Numba itself but instead often caused by
the use of unsupported features or an issue in resolving types.

I would welcome the implementation of range in Numba. If this is not planned, it should be stated in the documentation. That this feature is not available.

@DerWeh the issue is not due to range not being implemented in numba. What does not appear to be supported is the contains method for a range type and an integer. So you can't check if i is in range(1, 8, 3), but you can certainly iterate over that range and operate on its elements. For example:
@nb.njit
def test(i):
    s = i
    for k in range(1, 8, 3):
        s += k
    return s

Thanks @synapticarbors, good diagnosis.

And just as a side note, you could code the functionality yourself as something like:
@nb.njit
def test(i):
    found = False
    for k in range(1, 8, 3):
        if i == k:
            found = True
            break
    return found

@synapticarbors wondering if you would be interested in fixing this? I think it's a question of @overloading operator.contains with an impl for types.RangeType. I've added https://github.com/numba/numba/pull/4110 to help with some shortcutting cases/general maths.

@synapticarbors brilliant, thanks very much!

Thanks for the clarification, for me it simply belonged to the functionality of the range object.
But please keep in mind that the implementation you gave is not good. After all, if I wouldn't care about performance I wouldn't bother with numba. Something of the like
@numba.jit(nopython=True)
def in_kind(number):
    return number < stop and not (number-start) % step

should be used instead, we want O(1) not O(N) for a simple in.
I would appreciate an implementation, as I found replacing generator relatively often takes such constructs.

@DerWeh indeed, that's similar to the CPython implementation mentioned by @synapticarbors here, however, it's not possible to write that at present because range.{start, stop, step} isn't implemented in Numba and so the workaround mentioned was literally all that was available to users. A couple of days back I wrote https://github.com/numba/numba/pull/4110 to expose these attributes on range and an implementation for operator.contains with arguments of type range and <anything else> will be written in due course, rest assured it'll be O(1) complexity.

I didn't doubt that the implementation will be right, I just think a suitable workaround should be found for people with the same problem ending in this thread.
Thus, a O(1) solution should be stated. But thanks for all the good work.

@synapticarbors https://github.com/numba/numba/pull/4110 is now in master, if you are still interested in implementing a fix for this, a PR would be most welcome :) Thanks!

@stuartarchibald I actually started working on it last night and just pushed a preliminary PR in #4129

@synapticarbors brilliant, thanks :)

Closing this issue as it seems to be resolved by https://github.com/numba/numba/pull/4129 (thanks @synapticarbors :)). If this is not the case please re-open with a comment about any item that appears to be unresolved. Many thanks.


chore: fix names

Forward-port leanprover-community/mathlib#18921 and leanprover-community/mathlib#18924

bors r+