Problem to create flatten intraday tables

I have this error that appears in  ga-flattener-deployment-cfintraday cloud function logs when trying to create flatten tables for intradays tables:
`2022-02-09 06:59:53.568 PSTga-flattener-deployment-cfintradayex4immrg5l14 Exception on /_ah/push-handlers/pubsub/projects/[my_project]/topics/ga-flattener-deployment-topic-intraday [POST] Traceback (most recent call last): File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 2073, in wsgi_app response = self.full_dispatch_request() File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1518, in full_dispatch_request rv = self.handle_user_exception(e) File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1516, in full_dispatch_request rv = self.dispatch_request() File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1502, in dispatch_request return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) File "/layers/google.python.pip/pip/lib/python3.7/site-packages/functions_framework/init.py", line 171, in view_func function(data, context) File "/workspace/main.py", line 159, in manage_intraday_schedule input_event = InputValidatorIntraday(event) File "/workspace/main.py", line 16, in init self.method_name = message_payload['protoPayload']["methodName"] KeyError: 'methodName'
Exception on /_ah/push-handlers/pubsub/projects/[my_project]/topics/ga-flattener-deployment-topic-intraday [POST] Traceback (most recent call last): File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 2073, in wsgi_app response = self.full_dispatch_request() File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1518, in full_dispatch_request rv = self.handle_user_exception(e) File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1516, in full_dispatch_request rv = self.dispatch_request() File "/layers/google.python.pip/pip/lib/python3.7/site-packages/flask/app.py", line 1502, in dispatch_request return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) File "/layers/google.python.pip/pip/lib/python3.7/site-packages/functions_framework/init.py", line 171, in view_func function(data, context) File "/workspace/main.py", line 159, in manage_intraday_schedule input_event = InputValidatorIntraday(event) File "/workspace/main.py", line 16, in init self.method_name = message_payload['protoPayload']["methodName"] KeyError: 'methodName'
`
Any tips ?

Hi @pierrehabte2017, thank you for submitting the issue, we'll investigate and get back to you.

@pierrehabte2017, I'll close this issue due to inactivity, but if you need further assistance, please provide the details above. Have a great weekend!


Add 'platformName' to selenium-grid scaler

platformName included in the selenium grid scaler metadata so that it is possible to specify the desired platform to run the automated test considering that there are multiplatform nodes such as linux, Windows 10 available in the hub.
Checklist
~- [ ] When introducing a new scaler, I agree with the scaling governance policy~

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements

~- [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)~

[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #4038

Documentation updated: kedacore/keda-docs#1039


adv dupes wont load

something is not working right every time i wanna load the hoverscooter "https://garrysmods.org/download/1571/hoverscooter-driveable" give me a error

i hope that is getting fix

I'm on it

good then

See if this fixes it https://github.com/thegrb93/advdupe2/archive/legacy-check-fix.zip

@gobaoscar

Nvm I see the dupe file. I'll test it.

Ok, should be working now

Fixed


refactor(metrics): metrics provider implements controller

Metrics exporting requires a clear policy about when to export. While
MetricsProvider holds all meters created, it can act as a Controller
role to integrate better export strategies like pulling.

Which problem is this PR solving?

MetricsProvider should act as a Controller to determine when to collect all metrics values.
Related #796.
Go impl: https://github.com/open-telemetry/opentelemetry-go/blob/a485d0ec64a48f6b7d5344790ba6c4b85f154e8e/sdk/metric/doc.go#L156

Short description of the changes

Add a new PushController implements api.MetricsProvider as a default MetricsProvider.
Update the PullController to implement api.MetricsProvider.
Add public installExportPipeline function to @opentelemetry/exporter-prometheus.
Add public installExportPipeline function to ConsoleExporter in @opentelemetry/metrics.

Codecov Report

Merging #1017 into master will decrease coverage by 21.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1017       +/-   ##
===========================================
- Coverage   95.00%   73.90%   -21.11%
===========================================
  Files         212       71      -141
  Lines        8813     1571     -7242
  Branches      796      271      -525
===========================================
- Hits         8373     1161     -7212
+ Misses        440      410       -30

Impacted Files
Coverage Δ

packages/opentelemetry-core/test/utils/url.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...ckages/opentelemetry-core/test/platform/id.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...s/opentelemetry-core/src/platform/node/sdk-info.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...pentelemetry-core/src/platform/node/performance.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...pentelemetry-core/test/internal/validators.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...ntelemetry-core/test/trace/NoRecordingSpan.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...telemetry-core/test/platform/hex-to-base64.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...elemetry-core/test/trace/spancontext-utils.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...lemetry-core/test/trace/ProbabilitySampler.test.ts
0.00% <0.00%> (-100.00%)
:arrow_down:

...try-core/test/trace/fixtures/test-package/index.js
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 136 more

I am little confused about the this PR (esp. MeterProvider -> PushController), is this something enforced by the specs?
Currently, Meter instance encapsulates the Controller logic. I think it should only be responsible for creating and recording metrics. And we should have separate export pipeline using either PushController or PullController.
Basically, users have to do the following things:

Create meter using MeterProvider
const meter = new MeterProvider();
Define the Contoller which will take meter and exporter to export the data at some interval.
const controller = new PushController(meter, exporter, interval);
OR
const controller = new PullController(meter, exporter);

Looks like this is similar to Python's implementation. See: https://github.com/open-telemetry/opentelemetry-python/blob/master/docs/examples/basic_meter/basic_metrics.py#L66

@mayurkale22  an alternative could be the pattern opentelemetry-go is using:
(the example is written in JavaScript to illustrate possible API shapes)
import prometheus from '@opentelemetry/exporter-prometheus'
import { metrics } from '@opentelemetry/api'

prometheus.installPipeline(); // registers the PullController as globalMeterProvider.
const meter = metrics.getMeter('example-meter');
const counter = meter.createCounter('foo');
// ...

In this example, end users of @opentelemetry/api/@opentelemetry/metrics may not aware the controller/MeterProvider, these are taken care of by the exporters since those exporters do care about how the metrics are going to be collected.
The python example does work. But dangling a variable like pushController doesn't seem to be a best practice to me (they are ref-ed by hosts, cool, but confusing).
WDYT? @mayurkale22 @obecny

so the exporter decides to install push or pull controller as the global meter provider?

Woudn't it mean that one meter provider can only be pull or push based, so you wouldn't be able to use two exporters at the same time that use each method ?

so the exporter decides to install push or pull controller as the global meter provider?

Yes, push or pull strategy is based on how the metrics are exported. So I think this is more intuitive.

Woudn't it mean that one meter provider can only be pull or push based, so you wouldn't be able to use two exporters at the same time that use each method ?

As a matter of fact, MeterProvider in @opentelemetry/metrics doesn't support multiple exporters already. Though the exporter can act like MultiSpanProcessor passing the metric records to all subsidiaries.

@dyladan @mayurkale22  @obecny @vmarchaud  hey, I've updated the PR to address the comments. Maybe there can be another round of review?

@dyladan: Minor issue: with the naming change, it may not be obvious to users that the controller is the meter provider.

I've appended more ts-doc on controllers to explicitly indicate that those controllers are capable of been installed as the global metric provider.

Maybe we can resolve naming confusion by naming the controllers PullControllerMeterProvider and PushControllerMeterProvider.

Maybe we can resolve naming confusion by naming the controllers PullControllerMeterProvider and PushControllerMeterProvider.

I would keep the naming the same as in spec to avoid any confusion (MeterProvider) but then maybe some option can decide if that is a push or pull  strategy ?.
const provider = new MeterProvider('pull'); // default to 'push' as it was
const provider = new MeterProvider({controller: 'pull'}); // default to 'push' as it was
const provider = new MeterProvider({strategy: 'pull'}); // default to 'push' as it was
...

What is the status of this? It has 3 reviews, but open comments from a maintainer.
@obecny you are the only one with remaining open comments here.

What is the status of this? It has 3 reviews, but open comments from a maintainer.
@obecny you are the only one with remaining open comments here.

My main concern is that why this is done different then what spec says. Spec says about MeterProvider, not PushController.
I think @mayurkale22 had the same concerns.

@obecny I've updated the PR the revert the changes made to MeterProvider naming.
Since this update, the PR can be summarized as:

metrics.MeterProvider exposes a new method collect that similar to metrics.Meter.collect, collecting all metrics of all meters that the meter provider creates.
Renamed Controller to PushController, and the new PushController accepts a metrics.MeterProvider but not a metrics.Meter.
Add public installExportPipeline function to @opentelemetry/exporter-prometheus.
Add public installExportPipeline function to ConsoleExporter in @opentelemetry/metrics to install a push controller on global api.metrics.

Example usage of the new pipeline:

import { ConsoleMetricExporter } from '@opentelemetry/metrics'
import { metrics } from '@opentelemetry/api'

// Install the export pipeline before all subsequent call to metrics.
ConsoleMetricExporter.installExportPipeline();
// Identical to:
(function installExportPipeline() {
  const exporter = new ConsoleMetricExporter();
  const meterProvider = new MeterProvider({ ...meterConfig, exporter });
  const controller = new PushController(meterProvider, config);
  api.metrics.setGlobalMeterProvider(meterProvider);
})();

const meter = metrics.getMeter('example-meter');
const counter = meter.createCounter('foo');

First, thank you for the work you have put into this. I know this has been a lot and the review process has been lengthy, but this is a large PR and there is a lot to unpack here. First, I have a couple of questions.

Why did you decide to go with this model, rather than the simpler route of adding a pull controller to the existing model? This is a large change from what we previously had. A smaller change would be something like this:

interface PullingExporter extends Exporter {
  registerPullController(): void;
}

const pullingExporter = new Exporter1(); // implements pulling exporter
const pushingExporter = new Exporter2(); // implement exporter

const provider = new MeterProvider();

provider.addController(new PullController(pullingExporter));
provider.addController(new PushController(pushingExporter);

provider.register();

In addition to being simpler, this would also have good symmetry with the tracing API.

This looks similar to the go and python implementations with one notable exception. As you can see here, the export pipeline installation method is on the MeterProvider in Python, where you decided to put it in the exporter. Can you please explain why you decided to add the function to the exporter rather than the provider? I can easily see a situation where the user writes the following code and is confused why it doesn't work:

const provider = new MeterProvider();
metrics.setMeterProvider(provider);

const meter = provider.getMeter("myapp");

const exporter = new Exporter();
exporter.installExportPipeline();

const counter = meter.createCounter();

// use counter in some way, metrics are not exported, user is confused

Because this PR has the installExportPipeline create a new MeterProvider, the user's counter in this case would not work with the export pipeline and the user would see no metrics. In some ways, this is a documentation issue, but we should also do our best to avoid situations like this where it is so easy to misuse the API.

@dyladan Thanks for the questions.
The idea behind the metricExporter.installExportPipeline is that metric exporter has to decide their metric collection frequency to reduce costs (reduce proactive metric collections like system resources utilization) at their best efforts. My experience is some APM vendors do only collect metrics with a limit set of time periods, like 5s, or 15s. If the pipeline is installed by users, like the python example, the users have to decide the intervals of metric collections. In that way, the exporter may have to implement their own caching mechanism to not flushing their servers if the user sets quite a short interval. However, if the exports do support arbitrary intervals (or strategies), they can provide options to alter that if the installExportPipeline is implemented by the exporters.
However, I found I'm fallen into a thought trap while reviewing the first question. My initial thought is that we can lift the decision like the strategy the exporter should use. Yet I found the symmetry between the metrics and tracing you mentioned is interesting idea on how the metrics export pipeline should be defined, regardless of how currently go or python SDK is implemented.
My thoughts on the symmetry can be: Aggregator & Controller <-> Sampler. Which aggregator to use is decided by the batcher, which is installed at the construction of MeterProvider. Similarly, samplers will be installed on the construction of BasicTracerProvider. So for controllers, I'm wondering if the current approach is the right way to keep symmetry between metrics and tracing. I'm opening to revert the current changes to only migrating Controllers on the main branch to bind with MeterProvider rather than single Meter instance (so that this PR can be split into smaller ones), and continue the export pipeline installation discussion in another PR (or issue).

The export pipeline user interface may be hard to be a stable design as the metric record export pipeline of metrics SDK specification is still been drafting actively. Closed now and keep tracking on https://github.com/open-telemetry/opentelemetry-js/issues/1528.


Rule to validate links via https://github.com/tcort/markdown-link-check/

I've been using https://github.com/tcort/markdown-link-check/ as a separate check to validate links in markdown. I was starting to see if I could leverage the .markdownlint.json as a config format for that project too and realized maybe it might make sense to just add that functionality as a rule in this project.
Because it can go out and create network requests, I think having it off by default would make sense.
I may just do it as a custom rule in the end, but I figured I'd check to see if there is interest in this as a core rule.
Example config schema:
    "valid-links": {
      "description": "MD###/valid-links - Validate links",
      "type": [
        "boolean",
        "object"
      ],
      "default": true,
      "properties": {
        "link_types": {
          "description": "Types of links to validate",
          "type": "string",
          "enum": [
            "all",
            "internal",
            "external"
          ],
          "default": "internal"
        },
        "ignore_patterns": {
          "description": "RegExp for ignoring links",
          "type": "array",
          "items": {
            "type": "string"
          },
          "default": []
        },
        "http_headers": {
          "description": "Url and HTTP header pairs when URLs need additional parameters",
          "type": "array",
          "items": {
            "type": "object"
          },
          "default": []
      },
      "additionalProperties": false

/cc @tcort @timmkrause

Love the idea! This comes up from time to time, so definitely worth thinking about. I think it would be pretty straightforward to implement as a custom rule, especially because the parser will have already pulled out each of the URLs.
What I’d like to do is start everything as a custom rule, see how it does, then look at pulling successful ones into the core library. (With the caveat that I try hard to avoid new dependencies, so maybe attempt this using only the core Node.js modules.)
If you prototype something here, I'd be happy to answer any questions that come up!
(See also https://github.com/DavidAnson/check-pages for a project of mine that checks links.)

Sounds good, I'll see if I can figure out setting up a separate rule repo.
Any advice on naming conventions and namespacing for rules, just to avoid any future issues if you decide it would fit in core?

Don’t assign an MDxxx name, just use a name like validate-links and it should be possible to pull it in pretty much as-is. Some other guidance here: https://github.com/DavidAnson/markdownlint/blob/master/doc/CustomRules.md

Just wanted share my experience. I'm using both markdownlint-cli and textlint in my documentation projects. The following rule in textlint takes care of link validation:
https://github.com/textlint-rule/textlint-rule-no-dead-link

Just going to note that even a subset of this feature, which would be checking local links like see [below](#another-heading) would be quite useful.

Upcoming rule MD051 will implement this behavior for local links (#something).
https://github.com/DavidAnson/markdownlint/commit/33ee1cd85ee1eeaaca4ba4d7f18e7e2edf67a48d

Update: I published a new npm package to add this custom rule (validating "dead" relative links): https://github.com/Divlo/markdownlint-rule-relative-links.
Contributions are welcome! :hugs:

FYI the markdownlint-rule-relative-links plugin has been updated to support links to anchors like MD051 does.


Rook deployment and command namespace discrepancy

In the rook documentation the operator is deployed on the default namespace
metadata:
  name: rook-operator
  namespace: default

But in the docs the check command uses the rook namespace
kubectl -n rook get pods

I'm not sure what's best practice. Maybe @galexrt could chime in?

@pstadler @GaruGaru The operator should be deployed in rook-system (or any other namespace) (that should also has been clarified in the lastet master documentation) because it will create certain objects in it to keep track of PV mounts, etc which should not simply be deleted.
The example cluster namespace is rook.
Staying "true" to the defaults should be the "right way" here though to keep it simple for any debugging ;)

@pstadler Separated namespaces may not apply to your specific use case of only one storage backend (e.g. Ceph) used here, though for people potentially using another storage "backend" (e.g. upcoming Minio and/or CockroachDB) it is recommended to use separate namespaces. This is also caused by the current limitation of being able to create/deploy only one storage backend per namespace.
Example namespace list when using more than one storage backend/cluster:

Namespace for Rook operator(s) rook-system
Namespace for Ceph Cluster SSD ceph-ssd
Namespace for Ceph Cluster HDD ceph-hdd
Namespace for Minio 1 namespace minio-1

If you only use one storage backend (e.g. just Ceph), you can put the operator and cluster (aka storage backend) into one namespace together, though I personally would just use two namespaces as they should not hurt the performance of Kubernetes.
At least I know of a clusters with more than 100+ namespaces and not having a problem with latency because of it.

This is now fixed.


Add boolean and string preference

Current coverage is 59.91%

Merging #33 into master will increase coverage by +6.58% as of db71ee9

@@            master     #33   diff @@
======================================
  Files           11      14     +3
  Stmts          195     227    +32
  Branches        16      18     +2
  Methods          0       0
======================================
+ Hit            104     136    +32
  Partial          7       7
  Missed          84      84

Review entire Coverage Diff as of db71ee9

Uncovered Suggestions

+2.64% via ...LayoutViewPager.java#26...31
+2.20% via ...ew/ToolbarUtils.java#16...20
+2.20% via ...LayoutViewPager.java#38...42
See 7 more...

Powered by Codecov. Updated on successful CI builds.

+1 but please resolve conflicts


Keybase not added to Windows path by default

Hello,
When installing Keybase using the Windows installer for the Keybase application (I think it is build 386/version <IP_ADDRESS>), the Keybase application doesn't seem to be added to the Windows PATH variable (either the user or the system variable). This prevents users from using Keybase from the command line without adding Keybase's home folder (\AppData\Roaming\Keybase) to a PATH variable.
Thankyou,
psgs :palm_tree:

It's possible that this issue might be due to a change in the path of the Keybase home folder that might have changed when the GUI application was released.
It seems that packaging/windows/doinstaller_gui.cmd defines KeybaseBin as "c:\Program Files (x86)\Keybase\keybase.exe", whereas packaging/windows/doinstaller_wix.cmd defines KeybaseBin as "%APPDATA%\Keybase\keybase.exe".

Rather than add to the global path, the installer adds a shortcut to a CMD console, now called "Keybase Shell", with keybase in the path in its environment.

Yeah, would be nice for power users (presumably the target demo at this point anyway) who have non-CMD (powershell, msys-git bash, and soon native bash immediately come to mind) shells already set up for heavy use not to have to completely switch context just to use the application.
There's nothing special about the CMD console and I'm able to use keybase just fine after adding the location to my path anyway, so this isn't a matter of any technical reason blocking this as a feature, just something that would be awesome to have in addition to the current shortcut.

Can you tell us how to manually set up our windows path if the installer didn't do this for us, automatically?

@jtsmith0101 Check out the instructions here: http://windowsitpro.com/systems-management/how-can-i-add-new-folder-my-system-path
I'd suggest adding it to your user path, personally, but either user or system path will work.

@zanderz This is inconvenient, because Windows people use a variety of shells and shell management tools (powershell, cmd, cygwin, msys, conemu, cmder, console2, WSL bash, it goes on and on and on), and I don't usually open up a new window for the express purpose of working with a particular tool. It is not bad citizenship for an installer to add something to the PATH env var, although typically installers make this an optional feature.

The command line tools definitely have a discoverability problem on Windows.
Neither https://keybase.io/docs/the_app/install_windows or https://keybase.io/docs/command_line/basics mention anything about a "Keybase shell", so I never thought to look for that. I ended up needing to Google around for "keybase windows command line" before finding it.
I would recommend an on-by-default installer option "Add Keybase command line tools to the PATH". This is a pretty common approach, and if anyone objects they can uncheck it.
Would also recommend updating docs/website to describe where to find the command line tools on Windows.


pg Schema name upper case is dropped to lowercase in init_replica.

Using a schema name like "CamelCaseSchema" in the configfile.yaml, creates a schema "camelcaseschema".  When the replication is actually run though, the script again looks for "CamelCaseSchema", which it then doens't find and an error is generated.

fixed in commit 28be9a


plugin Leaflet.draw

Any ideas on how to incorporate the Leaflet.draw plugin or how to make the layers editable

I would also be interested in this functionality.  I'll need to learn how to wrap js APIs in blazor but I'd be willing to help implement it once I understand what is involved.

Regarding wrapping, see my response in the other ticket. I would guess this is a fairly large amount of code to add, though. So,

as a pull request, I really wouldn't start with that one if you're just learning :-)
given that it's a plug-in on the Leaflet end, I think I would also like if this is a separate NuGet package BlazorLeaflet.Draw on the Blazor end (@Mehigh17: thoughts?)


App 3 0 nav panel connect

This PR:
dependent on #296 merge

creates sidebar toggle
renames and consolidates connection components into ConnectionPanel

ConnectionIndicator is always visible, handed connection status "light"
ConnectionInfo renders connect button, or connection information / disconnect button

implements mcous chore branch to introduce interface specific state/actions

Looks like this PR depends on #296. @IanLondon and @astaff that one is still waiting on your review. This one will be easier to review if we're able to merge that and rebase here. Thoughts?

Closing in favor of #308


vpi: fix quickstart example for mcode build; add ref to CoCoTb-pygame demo

Running on Mac...installed ghdl via homebrew. That binary was build for mcode generation. Thus, this example did not work.

I also added an example interactive GUI I whipped up by using cocotb and python.

@chuckb would you mind partially rewriting the GHDL-CoCoTb example description to address the following details?

Add "GUI" to the title. That's a very meaningful feature of your demo, because most GHDL + CoCoTb examples don't provide a GUI.
I suggest: "It provides a testbench and a matching GUI with I/O peripherals for testing a design, instead of examining waveforms; similar to the GHDL VPI virtual board example or the VGA (RGB image buffer) examples".
Mention "pygame". E.g. "Using Python (CoCoTb and pygame) makes interactive GUI creation more dynamic than using a compiled language (such as C++)". Let's let users decide what is "easier" for them.

Moreover, if you want, your article might be contributed as a section to the docs of this repo, along with adding the sources as an example. I believe we might test it in CI with xvfb. That'd be in an upcoming PR, of course; no need to handle it now.

Yes, I will make the changes are you suggest. I would very much like to have the example included within the docs somehow, as there are not many GUI-related examples...none really with Cocotb as you mentioned. Fusing Cocotb and pygame was an interesting exercise and kind of fun.
I should have split up the PR, I recognize...

I did a minor style fix, I rebased and I merged. Thanks!

would very much like to have the example included within the docs somehow, as there are not many GUI-related examples...none really with Cocotb as you mentioned.

You can start creating subdir vpi/cocotb/pygame in a branch, and adding the sources of the example there. Then, we can iterate on that to add it to CI and to the docs.
BTW, https://twitter.com/unaimarcor/status/1476772035728715782

Thanks for the kind mention. I also integrated this example into a FuseSoC core...lots of open source goodies to explore. https://github.com/chuckb/alchitry-au-fusesoc


Support for Angular 2

Are you going to support it in the next months?
Thanks.

We are missing something restmod on angular 2 world too, but is not on our priorities for now. Sorry.
I don't see it coming.


Outstanding Problems with external libraries

External libraries should be fairly well supported, but not without a few limitations.  This issue will document those limitations and I likely wont be trying to fix them since some of it is out of my control.

If you are targeting a version of netstandard before 2.1, it will not work

Why: because of malformed xml documentation (https://github.com/dotnet/standard/issues/666)
Workaround: Upgrade to 2.1 or later

If the external library doesn't have xml documentation, it wont work (no workaround)
The xml from the external library may be formatted weird (no real workaround either)
Xml documentation doesn't appear to be super well supported in the analysis context... maybe? (https://github.com/dotnet/roslyn/issues/23673).  Though it does appear to work, so maybe this isn't an issue

This issue is also a bit of a consolidation of the  (probably mostly fixed) issues #1 , #4 , and #9 .

closing this issue since there doesn't appear to be much I can do, but this can serve as a reference


[EVENT REQUEST] Allow multiple users with the same salesperson code

Some salespersons have multiple dispatchers which should all have the same salesperson code. This is not allowed. We need this event:
        field(10; "Salespers./Purch. Code"; Code[20])
        {
            Caption = 'Salespers./Purch. Code';
            TableRelation = "Salesperson/Purchaser";

            trigger OnValidate()
            var
                UserSetup: Record "User Setup";
                IsHandled: Boolean;
            begin
                if "Salespers./Purch. Code" <> '' then begin
                    ValidateSalesPersonPurchOnUserSetup(Rec);
                    OnBeforeFindDuplicateSalesPerson(IsHandled);
                    if not IsHandled then begin
                        UserSetup.SetCurrentKey("Salespers./Purch. Code");
                        UserSetup.SetRange("Salespers./Purch. Code", "Salespers./Purch. Code");
                        if UserSetup.FindFirst then
                            Error(Text001, "Salespers./Purch. Code", UserSetup."User ID");
                    end;
                    UpdateSalesPerson(FieldNo("Salespers./Purch. Code"));
                end;
            end;
        }
...
    [IntegrationEvent(false, false)]
    local procedure OnBeforeFindDuplicateSalesPerson(var IsHandled: Boolean)
    begin
    end;

Please include object name in the request next time. I assume this request is for User Setup table, but sometimes it's not this easy to find out.

Thank you and sorry, I meant the user setup.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


fix: draft message edit issue

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38539
PROPOSAL: https://github.com/Expensify/App/issues/38539#issuecomment-2005561937
Tests

Send a message

Hover or long press on this message
Choose edit message
The draft edit message remains as is

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Send a message

Hover or long press on this message
Choose edit message
The draft edit message remains as is

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/113963320/cb840f78-55f3-43f3-8ab8-ecbe1eb52f5d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/5ca8738b-6091-4529-91da-1a23bd5aaeab

iOS: Native

https://github.com/Expensify/App/assets/113963320/37517579-3ebd-4e83-988c-0239040dbccf

iOS: mWeb Safari
https://github.com/Expensify/App/assets/113963320/fd3a3370-4c21-4e18-a5d9-95fb1773d9ef

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/7cc11f59-6632-466a-b2dc-e0bd318e4e88

MacOS: Desktop

https://github.com/Expensify/App/assets/113963320/8b9cd401-622b-4592-b56b-7f974482fb54

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


run Demo  on local machine without local server

Hi.
Is that any way to run demo on local machine without local server .Its is giving the following error
No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access.
Thanking you in advance

Hi -- unfortunately due to web browsers' Cross-Origin Resource Sharing (CORS) security rules, it is not possible to run the demo from the local file system without a web server. For this reason we recommend using either the python -m SimpleHTTPServer command, or a similar alternative such as http-server for node.js. Let us know if you have any issues with that approach.

Hi.
i have one demo of tangram (example) and then i am try to use with phone gap android. In phone gap we just put the js ,css  and html in android  and load the index.html page and in this yaml file not working .So how it is possible in android phone gap without server

Interesting, we haven't had any inquires about that use case before, but I can see how it makes sense for  completely embedded/contained environments.
I suggest you put your scene file YAML into a data URI (as is common for embedding images in CSS), which you can then use directly as your scene file URL when initializing Tangram.
There are converters such as http://dataurl.net/ and http://dopiaza.org/tools/datauri/index.php.
I tried this with a simple proof of concept and it worked (I did encounter some UTF-8 encoding issues when I used a much more complex scene YAML that included non-Roman characters, though from some quick reading this appears to be a general issue with data URI base64 encoding and UTF-8).
Give that a try and let us know how it goes.
Thanks,
Brett


examples game_of_life not update animation in windows

examples game_of_life not update animation in windows

can provide more details like screen recording, system/os info, druid logs


Fix Image

Not sure if it's alright to link to Github profile picture... Just ignore if not.  Fixes the image though! :)

thanks!


Investigate how dev mode container mode works with other containers

We need to determine how users can set up DM4C to communicate with other containers (ie. database container, another service container, etc).
Once we understand how this process works, we need to determine if there is anything else that needs to be done for DM4C to make this process easier for users.

Scenario 1: Use the default docker network bridge.  See https://docs.docker.com/network/bridge/
As-is Steps:

Have two microservice projects, where the first connects to the second using MP Rest Client, and the URL of the second service is defined using MP Config in the src/main/resources/META-INF/microprofile-config.properties file of the first service.  Sample project (generated from MicroProfile Starter): https://github.com/ericglau/devc-multi-container/tree/bridge
Run mvn liberty:devc in first service's folder to it
Run mvn liberty:devc -DskipDefaultPorts in second service's folder to start it without binding ports.

Observation 1: devc gives errors saying the ports are not mapped, even though I intentionally did not map the ports since they will be accessed from within the Docker network only.

[ERROR] Unable to retrieve locally mapped port. Docker result: "Error: No public port '9081/tcp' published for liberty_dev_1". Ensure the Docker ports are mapped correctly.
[ERROR] Unable to retrieve locally mapped port. Docker result: "Error: No public port '9444/tcp' published for liberty_dev_1". Ensure the Docker ports are mapped correctly.
[INFO] ************************************************************************
[INFO] *    Liberty is running in dev mode.
[INFO] *        To run tests on demand, press Enter.
[INFO] *        To rebuild the Docker image and restart the container, type 'r' and press Enter.
[INFO] *        To stop the server and quit dev mode, press Ctrl-C or type 'q' and press Enter.
[INFO] *        Liberty debug port mapped to Docker host port: 57112
[INFO] ************************************************************************

Observation 2: The above message does not tell me the (internal) container port numbers that Liberty is listening on, which would be useful when using Docker networks.

Run docker network inspect bridge to find out the IP addresses of the containers.
Look for the IP address of the second container from:

        "Containers": {
            "8f954e99851f41b8a50994e36a8fb6eefc770c1ce62cbd40e0025c2f54a4a816": {
                "Name": "liberty_dev",
                "EndpointID": "e9f8656967203712c43f5f28aae689c21ea57d6897d5ffe2d3012367184f5a83",
                "MacAddress": "02:42:ac:11:00:02",
                "IPv4Address": "<IP_ADDRESS>/16",
                "IPv6Address": ""
            },
            "9b2af1983520a97cc1a7732a3ef9967318e6673e2eb3caf0022b2c53b3140f65": {
                "Name": "liberty_dev_1",
                "EndpointID": "c608ff11a4ddd4935525bfd14f46cf5c2c81c70269a90b223e0c0ec060454338",
                "MacAddress": "02:42:ac:11:00:03",
                "IPv4Address": "<IP_ADDRESS>/16",
                "IPv6Address": ""
            }
        },

Observation 3: It's hard to know which container name (and hence IP address) corresponds to which project that I started.

Use the IP address in first service to connect to the second service.  e.g. set this in the MP config properties file:

com.example.demo.client.Service/mp-rest/url=http://<IP_ADDRESS>:9081/data/client/service

Hit the URL in the first service which depends on calling the second service.  e.g. http://localhost:9080/data/client/test/testparam -- it returns without error.

Conclusions:

Change these kind of messages to WARNING instead of ERROR: [ERROR] Unable to retrieve locally mapped port. Docker result: "Error: No public port '9081/tcp' published for liberty_dev_1". Ensure the Docker ports are mapped correctly.
On dev mode startup, print the internal container ports, regardless of whether they are bound to Docker host ports.
On dev mode startup, print container name and/or container IP address.

Scenario 2: Use a custom Docker network.
As-is Steps:

Create a Docker network e.g. docker network inspect devnet and configure its networking however you want.
Start first service with a custom container name, so you can use the same container name in production later on. mvn liberty:devc -DdockerRunOpts="--net=devnet --name=container1"
Start second service with a custom container name, so you can use the same container name in production later on. mvn liberty:devc -DskipDefaultPorts -DdockerRunOpts="--net=devnet --name=container2"

Observation 4: Dev mode still tries to set its own container name, but the user-defined one overrides it.  e.g. Dev mode runs: docker run ........ --name liberty_dev --net=devnet --name=container2 ....
Observation 5: Dev mode tries to look for the Docker host port using its own container name instead of the user provided name, so it encounters an error: [ERROR] Unable to retrieve locally mapped port. Docker result: "Error: No such container: liberty_dev_1". Ensure the Docker ports are mapped correctly.

Update the URL in the first service's MP config properties using the second service's container name:

com.example.demo.client.Service/mp-rest/url=http://container2:9081/data/client/service

Hit the URL in the first service which depends on calling the second service. e.g. http://localhost:9080/data/client/test/testparam -- it returns without error.

Observation 6: If I did not set custom --name above and dev mode uses liberty_dev_1 as the name of the second service and I set that as the hostname in the URL in MP config properties, then when I access the first service, it does contact the second service but the second service encounters the 404 error below.  Seems the underscore in the container name is causing an issue with the app https://github.com/ericglau/devc-multi-container/tree/bridge which was generated by MP Starter - there is no issue if using a container name without underscores.  Underscores are not a valid character for hostnames.

[10/15/20 23:55:26:987 UTC] 0000003a com.ibm.ws.opentracing.OpentracingJaxRsEMCallbackImpl        W CWMOT0009W: The OpenTracing exception mapper detected and is handling an unhandled exception from the JAX-RS application.
                                                                                javax.ws.rs.ClientErrorException: HTTP 404 Not Found
	at org.apache.cxf.jaxrs.utils.SpecExceptions.toHttpException(SpecExceptions.java:117)
	at org.apache.cxf.jaxrs.utils.ExceptionUtils.toHttpException(ExceptionUtils.java:167)
	at org.apache.cxf.jaxrs.utils.JAXRSUtils.findTargetMethod(JAXRSUtils.java:561)
	at org.apache.cxf.jaxrs.interceptor.JAXRSInInterceptor.processRequest(JAXRSInInterceptor.java:251)
	at org.apache.cxf.jaxrs.interceptor.JAXRSInInterceptor.handleMessage(JAXRSInInterceptor.java:87)
	at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:316)
	at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:123)
	at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:273)
	at com.ibm.ws.jaxrs20.endpoint.AbstractJaxRsWebEndpoint.invoke(AbstractJaxRsWebEndpoint.java:136)
	at com.ibm.websphere.jaxrs.server.IBMRestServlet.handleRequest(IBMRestServlet.java:146)
	at com.ibm.websphere.jaxrs.server.IBMRestServlet.doGet(IBMRestServlet.java:112)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
	at com.ibm.websphere.jaxrs.server.IBMRestServlet.service(IBMRestServlet.java:96)
	at com.ibm.ws.webcontainer.servlet.ServletWrapper.service(ServletWrapper.java:1230)
	at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:729)
	at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:426)
	at com.ibm.ws.webcontainer.filter.WebAppFilterManager.invokeFilters(WebAppFilterManager.java:1226)
	at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:5037)
	at com.ibm.ws.webcontainer.osgi.DynamicVirtualHost$2.handleRequest(DynamicVirtualHost.java:314)
	at com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:1007)
	at com.ibm.ws.webcontainer.osgi.DynamicVirtualHost$2.run(DynamicVirtualHost.java:279)
	at com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink$TaskWrapper.run(HttpDispatcherLink.java:1134)
	at com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink.wrapHandlerAndExecute(HttpDispatcherLink.java:415)
	at com.ibm.ws.http.dispatcher.internal.channel.HttpDispatcherLink.ready(HttpDispatcherLink.java:374)
	at com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.handleDiscrimination(HttpInboundLink.java:546)
	at com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.handleNewRequest(HttpInboundLink.java:480)
	at com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.processRequest(HttpInboundLink.java:345)
	at com.ibm.ws.http.channel.internal.inbound.HttpInboundLink.ready(HttpInboundLink.java:316)
	at com.ibm.ws.tcpchannel.internal.NewConnectionInitialReadCallback.sendToDiscriminators(NewConnectionInitialReadCallback.java:167)
	at com.ibm.ws.tcpchannel.internal.NewConnectionInitialReadCallback.complete(NewConnectionInitialReadCallback.java:75)
	at com.ibm.ws.tcpchannel.internal.WorkQueueManager.requestComplete(WorkQueueManager.java:504)
	at com.ibm.ws.tcpchannel.internal.WorkQueueManager.attemptIO(WorkQueueManager.java:574)
	at com.ibm.ws.tcpchannel.internal.WorkQueueManager.workerRun(WorkQueueManager.java:958)
	at com.ibm.ws.tcpchannel.internal.WorkQueueManager$Worker.run(WorkQueueManager.java:1047)
	at com.ibm.ws.threading.internal.ExecutorServiceImpl$RunnableWrapper.run(ExecutorServiceImpl.java:239)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:821)

Conclusions:
In addition to the observations and conclusions in the previous scenario above, this scenario also involves the following:
4. (Not necessary, but for correctness) Dev mode should skip setting its own --name if the user already provided it in dockerRunOpts
5. Dev mode should look for the Docker host port corresponding to the user provided container name (if provided in dockerRunOpts).
6. Change dev mode's container naming convention to not use underscores, since underscores are not a valid character for hostnames.

Opened 6 issues.  Closing this investigation item.


Expose a function to obtain cargo's installation root

Problem
I have an application that needs to know where binaries installed via cargo install are located in the system. I can roughly assume it will be in $HOME/.cargo/bin, but according to this, when we do cargo install the location will be determined by, in order of priority:

--root option
CARGO_INSTALL_ROOT environment variable
install.root Cargo config value
CARGO_HOME environment variable
$HOME/.cargo

My idea was to use cargo as a library crate (although I need to see the impact in terms of dependencies) to obtain this location. I assume cargo already has some internal function that does that, as far as I checked it uses a resolve_root function, but that function is not public.
In summary: it would be nice to have a function in cargo (as a library) that given a current working directory, could give me the installation root.
Proposed Solution
If I understand correctly, making resolve_root public would suffice.
Notes
No response

Could you go into detail on why you need to know where the install directory is?  That can help making sure we talk about a solution that is relevant to your problem.  For example, if the user sets --root, then I don't think we track that for you.  If they set it via config, then looking it up is dependent on what directory you are in.

Hi, thanks for the quick feedback! So, given a certain system-wide available binary x I need to be able to tell if x was installed via cargo, or not. The reason is that we want to take different actions depending on that. My idea was to compare the output of something like which x with cargo's install root to be able to say "yes, it was installed via cargo". I'm doing this in a "best-effort" basis, so it's ok if I miss the case when the user used --root or something of that sort.
I just noticed that I can also do cargo install --list to get the names of executables installed by cargo (although that would require me to shell -- for context, I'm doing this from rust code). That is enough to solve my problem, so if this feature is too niche, feel free to close the issue.

So the request isn't "list of binaries cargo installed" but "list of binaries installed into the common location", right?
That reduces your look up to

CARGO_HOME environment variable
$HOME/.cargo

which is covered by home::cargo_home.
We might be adding more paths in the future for XDG support (see https://internals.rust-lang.org/t/pre-rfc-split-cargo-home/19747) but that would likely be a more specific entry point in home (e.g. cargo_install_dir)

Shouldn't I also check CARGO_INSTALL_ROOT, in case the user has modified that?

That depends.  CARGO_INSTALL_ROOT is exactly the same as install.root and most users who want it more permamently set would likely use install.root instwad, so I see CARGO_INSTALL_ROOT as more of a transient property which means you likely can't rely on it.


Support csv upload

Description

As a user i need to be able to upload CSV files for some of the objects from the UI, complementary to XML uploads.
requires: https://github.com/CSCfi/metadata-submitter/issues/221
Note: Not all objects will support CSV upload
DoD (Definition of Done)

CSV upload is possible from the UI.
Testing

unit and integration testing

Upload XML should be turned into Upload Data or Upload Files and it should be done before #324


App doesn't ask for authentication at all anymore

observed on app v1.10.3

Actually wrong, it does ask in case we want to delete accounts. So the question is, now that we have actually resolved the issue that it is mandatory to ask for PIN because we need to decrypt the private keys. When should we actually ask for the authentication?
I suggest to always ask:

If transferring > 0.5 * UBI
Deleting account

But never ask for:

un/-registering
sending attestation
endorsing
etc

Consensus:

ask the first time per app session when needing the private key in general
Always ask for deleting an account or all accounts
Always ask when exporting mnemonic


ci: fix: unexpected token

Codecov Report

Merging #3165 (4f3c6e9) into develop (670da44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3165   +/-   ##
=======================================
  Coverage     6.19%   6.19%
=======================================
  Files          248     248
  Lines        12439   12439
=======================================
  Hits           771     771
  Misses       11668   11668

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Suppress Python warnings in production

We should not log Python warnings in production.

Completed in #178 .


Using the casual model with 24 kHz results in the process being "Killed"

🐛 Bug Report
Using the casual model at 24 kHz results in the process being killed after ~10 seconds. It doesn't matter if the language model  --lm is used or not. The 48 kHz mode works as expected.
To Reproduce
I've used the following command and got these results:
python3 -m encodec -r -b 1.5 --lm '/home/user/Downloads/Audiofile.wav' '/home/user/Downloads/Audiofile_EnCodec.wav';
Downloading: "https://dl.fbaipublicfiles.com/encodec/v0/encodec_24khz-d7cc33bc.th" to /home/user/checkpoints/encodec_24khz-d7cc33bc.th 100.0%
Downloading: "https://dl.fbaipublicfiles.com/encodec/v0/encodec_lm_24khz-1608e3c0.th" to /home/user/checkpoints/encodec_lm_24khz-1608e3c0.th 100.0%
Killed
user@user:~$
I even deleted the checkpoints folder to make sure that this isn't an issue. I've tested with a 16 and 24 bit PCM WAV with mono channel. Using --hq and --lm together works as expected so I believe the 24 kHz is the culprit.
Expected behavior
It should not kill the process and result in a properly encoded and decoded file.
Actual Behavior
It kills the process.
Your Environment

Python and PyTorch version: Python 3.11.0, PyTorch: 1.13.0
Operating system and version (desktop or mobile): Ubuntu 24.04.01 LTS
Hardware (gpu or cpu, amount of RAM etc.): Virtual machine (AMD 5900X, RTX 3080, 16 GB RAM assigned to the VM)

Hello @Macusercom , what is the duration of the wav file you are trying to compress ? We are not trying to be too smart about long files, and a lot of intermediate state will be held in memory so this could just be OOM.

Hello @Macusercom , what is the duration of the wav file you are trying to compress ? We are not trying to be too smart about long files, and a lot of intermediate state will be held in memory so this could just be OOM.

It is about 15 minutes long. Ubuntu is showing 7 GB of RAM and 40 GB storage space left but shorting the file to about 5 minutes worked. So probably OOM as you've said. I'm happy I got it working now, thanks!

I'll be closing the issue, I've added a FAQ section in the readme to mention that specific point.


Error running "npm install"

Running npm install (bash on ubuntu 14.04) resulted in the following error:

<EMAIL_ADDRESS>install /path/to/wagtail
pushd ./client; npm install; popd
sh: 1: pushd: not found

Due to this issue I wasn't able to build the static assets for the wagtail admin UI. It took me a while to figure out what was causing the problem. As stated in http://stackoverflow.com/questions/5193048/bin-sh-pushd-not-found/5193092#5193092 pushd is a builtin function in bash, but node uses sh by default.
I finally changed
"install": "pushd ./client; npm install; popd",
to
"install": "bash -c 'pushd ./client; npm install; popd'",
in package.json.
I have no idea how to fix this issue for all operating systems, as I think my workaround will only work on linux.

Reported separately here: https://groups.google.com/d/msg/wagtail/iWl9IVd87Cg/VjbWA2ZEAwAJ . I think it's worth fixing this for 1.4, to avoid anyone else getting caught out by it - @JoshBarr / @justinvdm, please could you take a look? (I guess cd ./client; npm install; cd .. would be a more portable alternative, assuming the npm install doesn't do any further directory changing of its own...)

Ah, ok. Never used pushd and popd before. cd should do the trick, except node changes directories itself as mentioned in https://github.com/torchbox/wagtail/issues/2313#issuecomment-192991512.

Fixed in #2314


HeavyModelSelect2TagField

Add a test for HeavyModelSelect2TagField in the testapp.
The labels for selected options aren't displayed correctly in the test - I updated HeavySelect2TagWidget to override render_inner_js_code, and now it seems to work properly.

@bcail thanks for the contribution, and thanks for starting with a test commit. I squashed our PR onto master.


Cannot navigate between months using keyboard.

The calendar does not change to the next month when keyboard navigates to a date from previous/next month.
This used to work before, so it could be related to this pull request: #1780

@johnnyRose @Eonasdan Does this sound related?

@shreya07 off the top of my head I would say no, but I haven't looked into it. Do you have a fiddle?


trace: Expose Span.tracing

Span.tracing returns whether or not things are currently being traced.
It should be exposed so that callers can determine whether to store the TraceID, alternatively, the TraceID should be "" when this function returns false.

We should probably consistently return empty string for spans that are not traced.
I think we also need to revise which spans we are auto-generating a trace ID/span ID for. In the following example, span has a trace ID even though the request was not traced:
req, _ := http.NewRequest("GET", "https://users.service/users", nil)
span := traceClient.SpanFromRequest(req)

Blocked, because we haven't reached to consensus for the behavioral change at https://code-review.googlesource.com/c/11311/.

I am thinking about exporting Header from the trace package, see https://code-review.googlesource.com/c/11414/.
func (s *Span) Header() string {
	return spanHeader(s.trace.traceID, s.span.ParentSpanId, s.trace.globalOptions)
}

Header might rather be the following instead. So we don't have to increase the API surface to add a Traced() bool method.
func (s *Span Header() (header string, traced bool)

Perhaps changing the signature of the TraceID function in the same fashion
would be useful too ?
On Mon, Mar 13, 2017 at 6:37 PM, Jaana B. Dogan<EMAIL_ADDRESS>wrote:

I am thinking about exporting Header from the trace package, see
https://code-review.googlesource.com/c/11414/.
func (s *Span) Header() string {
return spanHeader(s.trace.traceID, s.span.ParentSpanId, s.trace.globalOptions)
}
Header might rather be the following instead. So we don't have to increase
the API surface to add a Traced() bool method.
func (s *Span Header() (header string, traced bool)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-go/issues/533#issuecomment-286184298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUXAFxsvquYp8nBqhqxVm8bQu7W8T5lks5rlX7pgaJpZM4MNBUw
.

Yes, we can apply the same to the TraceID method.

Mailed https://code-review.googlesource.com/c/11417/. We won't return an empty string, but will set ok to false.


test: Add test case for know failure on switching from DHCP to static

When switching from DHCP without DHCP server to static IPV6(IPv4
disabled), the nmstate will fail with verification failure showing IPv6
is still disabled.
The keys to reproduce the problem:
* Dummy cannot work. Need to be veth.
* Need to be newly created profile with DHCPv6 enable.
Modifying existing profile to enable DHCPv6 cannot trigger this
problem.
Add test case as xfail to track this problem in CI.

Coverage remained the same at ?% when pulling 3f61f0dd645725da2b47c3b99db62bc834f6ace3 on cathay4t:verification_refresh into e7b7c6abea8fdbe3adc6260f8ad0b7d483a1a674 on nmstate:master.

Please note the format error

Please note the format error

Thanks. Fixed.

The fixture is failing for me.
            )

        if len(self._action_queue):
            err = _MainLoop.RUN_EXECUTION_ERROR
            raise error.NmstateLibnmError(
>               f"Unexpected failure of libnm when running the mainloop: {err}"
            )
E           libnmstate.error.NmstateLibnmError: Unexpected failure of libnm when running the mainloop: run execution

/usr/lib/python3.6/site-packages/libnmstate/nm/nmclient.py:178: NmstateLibnmError
------------------------------------------------- Captured log setup -------------------------------------------------
nmclient.py                201 ERROR    NM main-loop aborted: Connection activation failed on device eth1: error=nm-manager-error-quark: The device 'eth1' has no connections available for activation. (2)

Which command you used to create eth1?
If that's veth, you need to bring the both end up via ip link set up <nic> and also set eth1 as managed in nm via sudo nmcli device set eth1 managed yes

Which command you used to create eth1?
If that's veth, you need to bring the both end up via ip link set up <nic> and also set eth1 as managed in nm via sudo nmcli device set eth1 managed yes

Thank you, this is working when not using run-tests.sh.

The CI failed due to known failure of NM which is not related to this PR.


fix bug of NumberInput component

Pull Request Test Coverage Report for Build 115

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.154%

Totals

Change from base Build 114:
0.0%

Covered Lines:
88

Relevant Lines:
94

💛  - Coveralls


Support babel-sublime syntax

Support the Babel package syntax : https://github.com/babel/babel-sublime

Duplicate of PR #73


Add set_summary

Hi.
This PR adds a utility function set_summary that allows to set the job summary.
References for job summaries are here and here.
I've already tested the function (manually, i.e. defining it in the script) in https://github.com/python-telegram-bot/python-telegram-bot/pull/3508.
Let me know what you think :)

Thanks for the PR! Looks good to me and definitely in scope for the action.

This feature was released in v1.6 and the v1 tag has also been moved forward.


Nixpkgs manual: rename channel nixpkgs to nixpkgs-unstable

Description of changes
Updated the Nixpkgs manual preface to rename channel nixpkgs to nixpkgs-unstable and refer to "nixpkgs repository" consistently.
Based on the repo branches
and channel status I don't believe there is
a nixpkgs channel.  This confused me as a Nixpkgs beginner.
Rename to nixpkgs-unstable, which does exist.
Make the capitalization and "code quoting" consistent when referring to
the repository itself.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you for the fix!

Happy to!

Please update your PR title

I had read and tried to follow the commit conventions, but I'm not sure what change the pull request title needs?  Should I change "Nixpkgs manual:" to "doc:"?  Happy to make any changes here.

and squash the commits to follow the commit conventions.

For what it's worth I originally had these changes as one commit, but the first commit convention said "create a commit for each logical unit" I had interpreted to mean that a separate commit was needed for each logically-different change.
In any event, this pull request is now squashed!

@cpick

Should I change "Nixpkgs manual:" to "doc:"? Happy to make any changes here.

Yes.

I had interpreted to mean that a separate commit was needed for each logically-different change.

Thank you for the feedback! I'll clarify that text (and also clarify that the title of the PR should also follow the commit conventions) to explain what is meant by logical unit there.

Thank you
Pull request title has also been updated.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2024-02-01-documentation-team-meeting-notes-107/39146/1


Run error on windows in China: requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x02FF68F0>: Failed to establish a new connection: [WinError 10060]

from translate import *
love = translator('en', 'zh-TW', 'I love you')
print(love)

translate\translator.py", line 48, in connection
    response = session.send(prepare, verify=True)
  File "C:\Python3\lib\site-packages\requests\sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "C:\Python3\lib\site-packages\requests\adapters.py", line 437, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='translate.google.com', port=443): Max retries exceeded with url: /translate_a/single?q=I+love+you&dt=t&client=a&oe=utf-8&tl=zh-TW&ie=utf-8&sl=en (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x02FF68F0>: Failed to establish a new connection: [WinError 10060] 由于连接方在一段时间后没有正确答复或连接的主机没有反应，连接尝试失败。',))

How to set proxy? Thanks!

Visit directly: https://translate.google.com/translate_a/single?q=I+love+you&client=a&dt=t&ie=utf-8&tl=zh-TW&sl=en&oe=utf-8
我们的系统检测到您的计算机网络中存在异常流量。请稍后重新发送请求。为什么会这样？
IP 地址：<IP_ADDRESS>
时间：2016-04-02T04:32:00Z
网址：http://www.google.com/

Hi
We don't currently support routing through http/https proxy at this time. However another Python project GoSlate does, although I am not sure that will fix the problem with Google timing out
https://pypi.python.org/pypi/goslate#proxy-support

@jjangsangy Thanks. But now it says I have exceed used. Is google translate api not for free, isn't it? How to use it for free?

The Official Google Translate API isn't free.
https://cloud.google.com/translate/docs
This app actually parses the output of the Google Translate web app, which until recently wasn't under speculation by Google. The error message that you're currently seeing is likely because this app now isn't covered by Google TOS

Sorry here is a list for the pricing.
https://cloud.google.com/translate/v2/pricing

@jjangsangy Thanks so much!  But still :
Our systems have detected unusual traffic from your computer network. Please try your request again later. Why did this happen?

IP address: <IP_ADDRESS>
Time: 2016-04-05T17:21:15Z
URL: http://www.google.com/

And that with proxy library is also error:
    translation = gs_with_proxy.translate("hello world", "de")
  File "D:\Py27\lib\site-packages\goslate.py", line 409, in translate
    return _unwrapper_single_element(self._translate_single_text(text, target_language, source_language))
  File "D:\Py27\lib\site-packages\goslate.py", line 334, in _translate_single_text
    results = list(self._execute(make_task(i) for i in split_text(text)))
  File "D:\Py27\lib\site-packages\goslate.py", line 203, in _execute
    yield each()
  File "D:\Py27\lib\site-packages\goslate.py", line 332, in <lambda>
    return lambda: self._basic_translate(text, target_language, source_lauguage)[0]
  File "D:\Py27\lib\site-packages\goslate.py", line 251, in _basic_translate
    response_content = self._open_url(url)
  File "D:\Py27\lib\site-packages\goslate.py", line 181, in _open_url
    response = self._opener.open(request, timeout=self._TIMEOUT)
  File "D:\Py27\lib\urllib2.py", line 410, in open
    response = meth(req, response)
  File "D:\Py27\lib\urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "D:\Py27\lib\urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "D:\Py27\lib\urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "D:\Py27\lib\urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 503: Service Unavailable

Process finished with exit code 1

@gclsoft I guess it has nothing to do with the library. It is due to your own proxy.

Great, good to know


isBitstreamType property of Type always throws an exception

Attempting to read the isBitstreamType throws due to type signature mismatch. The other (numerous) properties of Type seem fine. This was found incidentally while traversing the AST.
I'm pretty sure this is because in slang Type.h the accessor takes a default argument. This must make pybind11 interpret it as a function taking an argument vs. no argument (other than self). I could think of a couple fixes, but I'm not sure what is "right" and whether the destination argument is interesting to python:

wrap it in a lambda in the pybind defintionto force the default argument to be used?
change it from a property into a proper method with argument in the python binding?
make a property and a method?

#!/usr/bin/python3

import pyslang

t = pyslang.SyntaxTree.fromText("module top(); wire a; endmodule");
c = pyslang.Compilation()
c.addSyntaxTree(t)
ast = c.getRoot()

# wire a symbol type (logic)
a = ast.topInstances[0].body[0].type

# fine
print(a.isFourState)

# ok
print(isinstance(a, pyslang.Type))

# throws
print(a.isBitstreamType)

# never reached
print("oops")

Output:
True
True
Traceback (most recent call last):
  File "/home/anders/work/pyslang/./crash3.py", line 20, in <module>
    print(a.isBitstreamType)
          ^^^^^^^^^^^^^^^^^
TypeError: (): incompatible function arguments. The following argument types are supported:
    1. (arg0: pyslang.Type, arg1: bool) -> bool

Invoked with: logic

Version Info:
anders@hostname:~/work/pyslang$ uname -a
Linux hostname 6.0.0-6-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.0.12-1 (2022-12-09) x86_64 GNU/Linux

anders@hostname:~/work/pyslang$ git log -1
commit bb2068673da88ced966b26fcd0ab7f752b309712 (origin/master, origin/HEAD, github/master, master)
Merge: f7f14b6 e8f6f56
Author: github-actions[bot]<EMAIL_ADDRESS>Date:   Fri Mar 8 02:55:06 2024 +0000

    Merge pull request #269 from MikePopoloski/dependabot/submodules/slang-9df2ea8

    build(deps): bump slang from `ea14f8a` to `9df2ea8`

anders@hostname:~/work/pyslang$ git -C slang/ log -1
commit 9df2ea8e7f9ca164565721ece49c0297e1df5611 (HEAD, origin/master, origin/HEAD)
Author: Michael Popoloski<EMAIL_ADDRESS>Date:   Thu Mar 7 20:42:30 2024 -0500

    Update CHANGELOG.md

Fixed upstream in 1b1e09b7977d91f7239b836f3ac73e19a6956aaa


Web Apps Aren't Listed When serverFarmId Is Undefined

Per conversation in #370, the serverFarmId in the SiteClient constructor can return as undefined, causing the Web App List in the explorer pane to return an error and not display the available web apps.
Going to review the code and submit a PR when a better solution is found (other than the solution submitted in #370).

@sunmorgus FYI - we just released an update to the extension that includes this fix.
Thanks again for the contribution!


PR: Fix code editor background color

Description of Changes

[x] Wrote at least one-line docstrings (for any new functions)
[x] Included a screenshot or animation (if affecting the UI, see Licecap)

From Qt documentation, it is said that QPalette should not be used in conjunction with QtStyleSheets, because the later override the former.
Since custom stylesheet are propagated to the children when applied to the parent, this means that the background and foreground color of the TextEditBaseWidget need to be set with a stylesheet extended with an ID Selector if we want this to be robust instead of doing it by setting a new a color palette.
Moreover, some styles do not use the palette for all drawing such as the Windows Vista and macOS styles.
https://doc.qt.io/qt-5/qapplication.html#setPalette
https://doc.qt.io/archives/qt-5.8/stylesheet-syntax.html#selector-types

Issue(s) Resolved

Fixes #9248
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jean-Sébastien Gosselin

@jnsebgosselin, thanks a lot for your help with this! You can see that I was on the right track with my hacky solution but I didn't have the time to come up with a proper fix.
This is good for me, but Azure seems to have some problems right now. I'll merge after they are fixed.

Thanks for working on this @jnsebgosselin great fix!


Javascript highlight syntax error

Hi,
For a valid js code snippet, zulip highlights in red box.
for (var i = 0; i < newKeys.length; i++) {
    var oldVal = oldData[newKeys[i]]; //assuming order is same in both
    var newVal = newData[newKeys[i]];
    if (oldVal != newVal) {
        Iot_alrtOut["alerts"][newKeys[i]] = newVal;
    }

}

console.log(Iot_alrtOut);

//update new data as old data
newData = oldData;

Kindly help. It would be better if zulip at least highlights in a tool tip or mouse over, whats wrong in those places.

I can’t reproduce this. Also, the text you copied and pasted is different from your screenshot in a number of ways, so it’s hard to be sure you didn’t crop something else out that’s relevant. Are you sure you specified the language as ```javascript (or ```js)? In any event, our syntax highlighting comes directly from Pygments, so we are limited in what we can realistically change.

Closing as not reproducible.

I can’t reproduce this. Also, the text you copied and pasted is different from your screenshot in a number of ways, so it’s hard to be sure you didn’t crop something else out that’s relevant. Are you sure you specified the language as ```javascript (or ```js)? In any event, our syntax highlighting comes directly from Pygments, so we are limited in what we can realistically change.

yes, I am sure I use  ```javascript


Missing !help command

Describe the bug
Missing help command
To Reproduce
Steps to reproduce the behavior:

Issue !help

Expected behavior
A chat message showing available commands is displayed in chat

I'd like to work on this


Running commands to self-hosted instance seems to always fail

Hi,
I've been trying to use the v1.0.0 version of the CLI but can't seem to get it to work. When I run the following commands I always seem to get exceptions for a dependency error.
I've installed the CLI via the npm today (16/02/2023 13:00GMT+2).
$ tolgee compare --project-id 4 --api-url https://translate.[redacted].com/ --api-key [redacted] translations

🐭✅     Analyzing code...
🔴 An unexpected error occurred while running the command.
🔴 Please report this to our issue tracker: https://github.com/tolgee/tolgee-cli/issues
TypeError: undici_1.Request is not a constructor
    at Requester.request (/usr/local/lib/node_modules/@tolgee/cli/dist/client/internal/requester.js:62:25)
    at Requester.requestJson (/usr/local/lib/node_modules/@tolgee/cli/dist/client/internal/requester.js:81:21)
    at ProjectClient.fetchAllKeys (/usr/local/lib/node_modules/@tolgee/cli/dist/client/project.js:16:14)
    at Command.compareHandler (/usr/local/lib/node_modules/@tolgee/cli/dist/commands/sync/compare.js:18:50)
    at async Command.parseAsync (/usr/local/lib/node_modules/@tolgee/cli/node_modules/commander/lib/command.js:935:5)
    at async run (/usr/local/lib/node_modules/@tolgee/cli/dist/index.js:136:9)

tolgee push --project-id 4 --api-url https://translate.[redacted].com/ --api-key [redacted] translations
🐭✅     Reading files...
🐭🔴     Deleting import...
🔴 An unexpected error occurred while running the command.
🔴 Please report this to our issue tracker: https://github.com/tolgee/tolgee-cli/issues
TypeError: undici_1.Request is not a constructor
    at Requester.request (/usr/local/lib/node_modules/@tolgee/cli/dist/client/internal/requester.js:62:25)
    at Requester.requestVoid (/usr/local/lib/node_modules/@tolgee/cli/dist/client/internal/requester.js:99:32)
    at ImportClient.deleteImport (/usr/local/lib/node_modules/@tolgee/cli/dist/client/import.js:44:30)
    at ImportClient.deleteImportIfExists (/usr/local/lib/node_modules/@tolgee/cli/dist/client/import.js:52:24)
    at prepareImport (/usr/local/lib/node_modules/@tolgee/cli/dist/commands/push.js:61:70)
    at Command.pushHandler (/usr/local/lib/node_modules/@tolgee/cli/dist/commands/push.js:106:26)
    at async Command.parseAsync (/usr/local/lib/node_modules/@tolgee/cli/node_modules/commander/lib/command.js:935:5)
    at async run (/usr/local/lib/node_modules/@tolgee/cli/dist/index.js:136:9)

My "translations/" folder contains these files: https://gist.github.com/nielsvermaut/183cc776a1143e4665851cb7ed2d91a3
What could I be doing wrong or is this an actual bug?

It seems Undici (one of the dependencies) isn't exposing the Request object, which I suspect is due to an outdated version of NodeJS installed on your system.
Can you double check your Node version is 18 or greater? If it isn't, you'll need to update NodeJS using your system package manager, as the Tolgee CLI officially supports Node 18+ only.

The error is quite different this time: now, the error seems to indicate the fetch calls fails to reach the target server at all, indicating whatever URL its trying to reach is unreachable (network error).
Can you please try and run the command again with verbose logging enabled (--verbose), so the CLI will log more information about what's going on? It should log more information about the failing HTTP call for a better troubleshooting.

Hi there, it's been a while since the last update on this issue, so I'll close it as stale.
If you're still experiencing issues with the CLI, feel free to comment on this issue or drop a message on the community Slack.


Swagger ui not working

Swagger Ui is not working. Please is this intended or I'm doing something wrong ?
I get this message in the browser when I hit the swagger docs url wrong number of parameters: 0 expected 1 And I get 404 in console.

I'm seeing the same issue here with the latest 3.5.0 version of utoipa and swagger-ui 3.1.5

As for me I got it working by having this in my Cargo.toml
utoipa-swagger-ui = { version = "3", features = ["debug-embed", "actix-web"] }
Also be sure not to forget the trailing slash at the end of the URL.
http://localhost:8000/swagger-ui/ (the trailing slash is important)
I don't understand why it not possible to fully customise the urls and still have it working.

Yep, that also did the trick for me. Thank you.

One could try to change the URL as follows to serve Swagger UI without the last slash /.
SwaggerUi::new("/swagger-ui{_:.*}"). Note! After the swagger-ui there is no slash. However I'm not sure whether this actually will work. This is in actix-web, for other frameworks this will be different if even possible.
You can change the URL for the SwaggerUi as you wish and also the URLs where the OpenAPI spec will be served from, but you need to change the Config for the Swagger UI also accordingly. See more about the topic here https://github.com/juhaku/utoipa/pull/274.
But in short the SwaggerUi is designed to work from root of the web server, thus nesting will be quite difficult e.g. serving the Swagger UI  from nested / sub router. This is because the SwaggerUi will create the operation handlers according to the given URLs.
So as seen in the example below. The handler for Swagger UI will be created for the /swagger-ui/...rest  and the OpenAPI spec will be served from /api-docs/openapi.json. If this router / service config is to be nested under path /v1 then the SwaggerUi will be served from /v1/swagger-ui/...rest and the OpenAPI spec from /v1/api-docs/openapi.json. But because of .url("/api-docs/openapi.json"...) the Swagger UI does not know that the ApiDoc is actually served with  prefix /v1/... In order to make SwaggerUi to know about this nested routing we need to change the config for the Swagger UI manually.
SwaggerUi::new("/swagger-ui/{_:.*}")
  .url("/api-docs/openapi.json", ApiDoc::openapi())

Let the Swagger UI know that the OpenAPI spec is served from different route than to the one given to the .url(...) method call.
let config = Config:from("/v1/api-docs/openapi.json");
SwaggerUi::new("/swagger-ui/{_:.*}")
  .url("/api-docs/openapi.json", ApiDoc::openapi())
  .config(config)


Add global variable for defining use of all-custom color shades, in place of individual custom parameters for btn generator

Petal currently uses global shade generator (.colorset()) in many places to utilize a shade of a specified base color to emphasize or differentiate from base color. The button generator (.generate-btn) mixin apparently was made before the global shade generator mixin, and it uses a separate 'custom' parameter to use custom-defined shade variables instead of using auto-generated shades.
In a generic use case, if one wants to use manually set color shades, it's likely that he will do so for all colors instead of just specific colors, so using a global variable like @disable-auto-shade-generator that controls the behavior globally would make more sense than having the 'custom' parameter in just button generator. (It simplifies the button generator mixin as well)

Resolved with release of 0.9.0 and 0.9.1


DL: Add training for multiple models

This commit adds a new function to train multiple models in parallel
with model hopping method.
Model hopping method involves the following steps:

Train models in parallel for a single epoch using the data local
to each segment.
Move the models to the next segment in round-robin fashion.

This method ensures that all of the models visit the entitre dataset,
which eliminates the need to average the model at the end.
This commit also fixes an issue with the regular fit function where
excessive amounts of threads were being created and left over by keras
sessions. It is fixed by reusing the same session and the same
computational graph throughout the process.
 Will create a separate PR instead.


Making the probes' initiaDelaySeconds configurable for the text2vec-transformers module

For those of us who are building our custom text2vec-transformer models, the probes' initialDelaySeconds might need to be adjusted (increased), as some of these models can be really heavy to load.
The readinessProbe's initialDelaySeconds being hard-coded to 3 seconds was especially an issue, so I have made the initial delay configurable for the two probes of the text2vec-transformers module, so anybody can adjust them depending on the load time of their transformer models.

I agree with the CLA

Thank you for your contribution @zoltan-fedor


Update builds and badges after renaming repo

I changed the repo name to protons, as discussed. I've updated the builds, links, badges, and readmes. I added quantifiedcode to the repo as well.

Presuming all builds pass, this will be ready for review and merging.  Summarizing:
Updated links to point to new protons name.
Added quantified code checks.
Replaced coveralls by codecov, similar functionality, but easier to work with.

Current coverage is 81.00% (diff: 100%)

No coverage report found for master at 9e7cdbe.

Powered by Codecov. Last update 9e7cdbe...dff1753

Thanks! This looks fine, but I have to say that I'm concerned about the technical debt we incur the farther this repo structure drifts from the standard way we set up projects in the lab.
I think it's fine to experiment with things and find better solutions, but at some point, we are going to either have to deploy your improvements lab-wide or eliminate the deviations from our standard lab practices. This is part of a larger conversation about how we should develop code in the lab, though.

Thanks John! We should definitely have a discussion at some point.


access_loggers: add Fluentd access logger extension

Additional Description: Adding Fluentd access logger extension for logging access logs using the Fluentd protocol
Risk Level: low (new extension)
Testing: unit tests, integration tests
Docs Changes: access logs API, docs, stats
Release Notes: none
Platform Specific Features: none

/assign @envoyproxy/first-pass-reviewers

/assign-from @envoyproxy/first-pass-reviewers

Also tagging @wbpcode for review as senior extension maintainer

/wait

cc @envoyproxy/dependency-shepherds

/lgtm api


Stopped working

Hello it hasn't been working anymore, hope you still can fix it :/

@Rodrigo-Ayam Is this because of a change on Chrome version 100? Keep in mind this extension has been untouched for months.

Yes, I saw it hasn't been updated in a while, is there any change you still work on it? Must be cause of some chrome update probably yeah. Well at least reinstalled it and seems to be working again, will hope it still does cause it is so much necessary, chrome has been worst each day, wasn't for mine lots of extensions been used would have migrated to another browser already.

Yes, I saw it hasn't been updated in a while, is there any change you still work on it?

@Rodrigo-Ayam The code for this extension is very simple, it just tells Chrome to set every tab as not autoDiscardable, there's no potential update I could make.

Either Chrome bypasses this extension or there is some interaction from users to make this work as I am unsure if I need to change anything in this Discards page mentioned at the Chrome Store or not. Auto Discardable has a Toggle option, I assume this is to turn off the extension, and in Actions there are 2 options, Urgent and Proactive.  I had hoped the Readme would tell us how to use, but it is only a sentence or 2 for me. Is this dead or am I missing some user action to make it work?
Facebook keeps refreshing page whenever open a tab or use an app on computer.
So if you leave page to research something to make an informed comment you lose your place...
Any tips to use this or dead?


Switch statements should discriminate by class prototype

TypeScript Version:  Nightly (4.0.0-dev.20200505)

Search Terms:

switch
control flow
discriminated union
untagged union
disjoin
prototype
constructor
2339

Code
class Failure {}

class Success {
    constructor(readonly value: string) { }
}

function main(result: Failure | Success): void {
    switch (result.constructor) {
        case Success:
            console.log(`Success! Your value is ${result.value}`); // Property 'value' does not exist on type 'Failure | Success'.
            break;
        case Failure:
            console.log('Oh noes');
    }
}

main(new Success("🍆"));

Output
"use strict";
class Failure {
}
class Success {
    constructor(value) {
        this.value = value;
    }
}
function main(result) {
    switch (result.constructor) {
        case Success:
            console.log(`Success! Your value is ${result.value}`); // Property 'value' does not exist on type 'Failure | Success'.
            break;
        case Failure:
            console.log('Oh noes');
    }
}
main(new Success("🍆"));

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided
Expected behavior:
No compile-time error. result.value should be of type string. That's what is happening in runtime.
Actual behavior:
We get a type error.
Property 'value' does not exist on type 'Failure | Success'. (2339)

Note that it works if you use if statements.
class Failure {}

class Success {
    constructor(readonly value: string) { }
}

function main(result: Failure | Success): void {
    if (result instanceof Success) {
        console.log(`Success! Your value is ${result.value}`);
    }

    if (result instanceof Failure) {
        console.log('Oh noes');
    }
}

This code doesn't work in the presence of e.g. class GreatSuccess extends Success { ... } - is this an intentional gap?

It's not — I haven't considered subclass relationships.
A bit of context. I'm using classes to construct value objects. They are never inherited from. My program yields well-defined results such a Success<T>, Failure, or a Timeout. These types form a union. I was looking for a neat way to disjoint that union. A switch statement seemed appropriate.

Duplicate #16035


Inconsistent error format across backends

Report by @axelboc
The format of the response on errors (404, 403) is not consistent across backends:

tornado: returns a string with the traceback
flask: a HTML page
fastapi: a JSON of the form {detail: <msg>} where <msg> is the error message we set

This makes difficult to implement a consistent treatment of the error on the front-end part. We could change the code in the different ..._utils files to have the same response format (ex: a JSON {message: <msg>}). This would also allow to demonstrate the different error handling schemes.

Fixed by #73


strictJSON and nested objects

I have a number of models which have nested objects that contain required properties. I had assumed that if I used strictJSON and marked those objects as required that the initializer would fail if that nested object was invalid but this is not the case.
For example - I have an appointment which has a client object associated with it. Client requires id, first_name, last_name - but if I initialize appointment with strictJSON the required properties of client are ignored and an invalid client can be associated with the appointment. I had assumed by marking client as "required" it would also perform a strictJSON initialization on it and bail out if the client was invalid.

The behavior I'm looking for is achievable by overriding the default fromJSON implementation of the model in question like so:
extension Client: JSONTransformable {
    class func fromJSON(json: JSON) -> Client? {
        return Client(strictJSON: json)
    }
}

I understand now that required in ModelRocket essentially just means that the key isn't null, but it might be worth noting somewhere so others don't assume that it means it will use the strict initializer.
Thanks!