Can't see logging in dashboard when using nested functions

Hi there,
I have the following code:
// Old method
public void TaskMethod()
{
    TaskMethod(arg1, arg2, null);
}

public void TaskMethod(PeformContext context)
{
     context.WriteLine("MyTask Starting");
     /// do something
     context.WriteLine("MyTask Finished");
}

If I call the following method, I do not see any output, even though the task works and I can see the output on the console window, but not on the dashboard
RecurringJob.AddOrUpdate(jobId, () => Jobs.TaskMethod(), Cron.Minutely);

If I call with null everything works as normal
RecurringJob.AddOrUpdate(jobId, () => Jobs.TaskMethod(null), Cron.Minutely);

In the documentation you mention that HangFire substitutes the null does do I have to do something differently if I don't want to pass null from my program calling code?

Hangfire substitutes null with a PerformContext when it calls the task method, but it knows nothing of any calls your method does internally, so there's no any substitutions possible there – if you pass null, it will get null. Hence, there's nothing logged.
There's nothing you can do without a valid PerformContext, as Hangfire.Console needs it for logging. You may try to make it the last argument with default null value, so it will look like there's no argument specified, but you need to check if Hangfire supports optional arguments first. I've never tried it actually, so I'm just speculating here.

Thanks for your explanation, as it turns out HangFire doesn't support optional arguments I did try doing that. Was just trying to make my methods as clean as possible but I guess I will need to have the PerformContext in all my methods.


user has disabled cellular data usage for the app.

when user has disabled cellular data usage for the app，return reachable ...

Some more details would be helpful for this. Please provide details @QiuZhiFei or close this issue.

If a user has disabled the use of cellular data in their device settings
Reachability *networkReachability = [Reachability reachabilityForInternetConnection];
NetworkStatus networkStatus = [networkReachability currentReachabilityStatus];

networkStatus equals NotReachable even though an internet connection does exist on the device. Is this by design?


Update matcher examples

While the documentation for the matchers themselves was updated, we
missed the examples.
I propose to merge this into the release-0.22 branch so that it gets
included in the ongoing release.
cc: @asquare14

This looks really good. Thanks a lot for working on it !


batlopez post

@batlopez this recent post isn't displaying correctly http://silshack.github.io/spring2016/Nat'sMilestones.html

@eah13 fixed! (i think?)


Contribute

Hey... I see that you are actively working on this project and I wonder if I can contribute? I played Ultima Online for more than 10 years, I don't play anymore but would be nice to work in such a project.
Let me know, thanks!

I am a software developer engineer and I have 9 years of professional experience with c#, very basic experience with XNA/Monogame to be honest.
It would be good to work with such an exciting project.
Thanks!

We are using discord internally. Can you send me your name/id?

Degelo#6800


MINIFI-107 - Process group support

Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] - N/A - If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] - N/A - If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
[x] - N/A - If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing

Also should probably update the default config.yml to include empty values for the new keys.

@JPercivall added validation that no input/output ports exist at top level

+1
Visually verified cod and did a contrib check build.  Ran a number of tests with templates -> config.yml verifying cascading PGs are correctly working (as well as running the configs) and all worked as expected. Thanks @brosander for bringing us one large step closer to feature parity with NiFi. I will merge it in.


Rename annotations to cluster-annotations

Renames annotations to cluster-annotations in charm config.

Some checks have failed in the PR. Resolve and this is g2g


Log when native transports are unavailable

Motivation:
When native transports aren't available where one might expect them to be, it'd be useful to have a log line about why. In particular, I've come to find out that our io_uring transport isn't available in our CI builds, and I'd like to know why.
Modification:
Add debug logging code when initializing the Epoll, KQueue, or IoUring classes, and include the complete stack trace when trace logging is enabled. Also enable trace logging for those classes for our tests.
Note that the stack traces are only shown when trace logging is enabled, because many people run with debug logging enabled, and they might get scared to see an unfamiliar stack trace in their logs.
Result:
It should now be clear why, when a native transport isn't available.

IoUring support is not available: failed to create io_uring ring fd: Operation not permitted
Maybe the docker containers don't have the right capabilities.

IoUring support is not available: failed to create io_uring ring fd: Operation not permitted
Maybe the docker containers don't have the right capabilities.

🤷 ... Maybe we should just use ubuntu directly to run the io_uring tests without docker in the mix. This is what we do in the incubator repos as well:
https://github.com/netty/netty-incubator-transport-io_uring/blob/main/.github/workflows/ci-pr.yml#L97

Yeah, I was looking at the docker builds for the incubator as well, to see if we missed any special configuration in the porting, but turns out:
2024-07-23T17:42:00.0619610Z [INFO] Results:
2024-07-23T17:42:00.0620068Z [INFO]
2024-07-23T17:42:00.0620650Z [WARNING] Tests run: 43, Failures: 0, Errors: 0, Skipped: 42

No, the incubator docker builds also skip nearly all their tests.
I think the reason is that docker disabled all the io_uring syscalls in their default seccomp profile, back in November 2023: https://github.com/moby/moby/pull/46762
So it used to work, but now it no longer does.
The fix should be to add a --security-opt seccomp=unconfined argument to the docker run, except we use docker-compose, so it might look a little different.

Let's see if we can get the builds fixed in a separate PR.


Possible config mismatch between TGI and transformers (hidden_act vs. hidden_activation)

System Info
n/a
Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
I just wanted to raise a potential config mismatch between TGI and transformers: namely, hidden_act vs. hidden_activation for gemma2 (and most likely other models):

in Transformers (main), hidden_act is legacy and is overridden by hidden_activation (link)
in TGI (main), hidden_act is only used (link)

Expected behavior
hidden_activation should be supported in TGI, taking precedence over hidden_act if both are specified.

Thank you @xenova 🫡
Should this be changed across all models or just gemma2?

I encountered this first for gemma2, but looking at the transformers source code (and seeing how new models are added), it looks like this is indeed a global change 👍 (maybe not for some legacy models)

This is fixed for gemma models in this PR: https://github.com/huggingface/text-generation-inference/pull/2381
I'll still keep this open until the other models have been gone through as well.

I've checked now these:

Cohere: hidden_act
Deepseek: hidden_act
Gemma 1: hidden_act
Llama 3: hidden_act
Mistral: hidden_act
Mixtral: hidden_act
Neox: hidden_act
Phi : hidden_act
Qwen : hidden_act
StarCoder : hidden_act
Idefics 1 : hidden_act

So for now I think we should be good 👍 I'll close the issue, feel free to open if other ones come up!


include declaration to allow building with default clang options on iOS-arm64

This fixes the build for iOS-arm64. Jeremey will be empowered to build the SDK with this change.

ship it!


Popup semantic ui possible bug

there is a strange problem with semantic ui popup. I create a dynamic content in my page, this is a div with a popup.
container = $('<div/>',
            {
            'width': 50,
            'height': 40,
            'data-content': 'some content',
            'data-variation': "tiny",
            preserve: false
            });

then, in another section of page, i activate the popup
container.popup({
                silent: true,
                hoverable: true,
                title :'some title'

            }).popup('show');

All works fine, but in my page i've also a horizontal scroll. So, if i show the popup and the scroll to right, the popup still remain in the same position while the container move to left.
http://stackoverflow.com/questions/43283235/popup-semantic-ui-possible-bug

You need to use inline: true and attach the popup to some other element than body

@kmd1970 no, this not fix the issue.

it would help if you posted a jsfiddle example of the issue.

ok, i try to replicate it on a fiddle @kmd1970

take a look at this https://jsfiddle.net/kmd1970/0qtm2424/

@kmd1970  i see your fiddle, but with inline:true doesn't change anything

@kmd1970 maybe it happen because i've this error
Popup: Popup does not fit within the boundaries of the viewport
and i've set silent :true ?

@kmd1970  no, i've tried with the same html code and an horizontal scrollbar but there isn't this error. Maybe in my code there is a little conflict

Hi, please provide a test case as per our contributing guidelines; you can fork this JSFiddle.

Closing the issue until there’s a test case.

I am quite certain of it. Popup has a lot of bugs also with positioning. In my case, I created a popup with a button to show it in navigation bar. Once I scroll the page horizontally, the popup continues to move while the button it was suppose to stick with is somewhere else.


Negative test cases , Wait / Expect

Hi @jan-molak,
Greetings,
Thank you for all the efforts for bringing 2.0. I am currently trying to migrate 1.0 version to 2.0, and have started working with the protractor-cucumber template . I have started to move my test scenarios to the latest serenity 2.0 and changing the imports and conditions where ever needed and its really easy thanks to you.
The question i had was in previous version, 'Is' was available to work with conditions like,
Wait.upTo(Wait.duration.ofSeconds(30)).until(BasePage.loading, Is.invisible()),
please help me change this line to test it for negative scenarios where i would like to wait until that element goes invisible from the screen. I saw isVisible() is available. Please help me here. Thanks.
Best Regards,
Abhineet Sharma

Hi @AbhineetSharmax!
All you need to do is compose not and isVisible:
import { not } from '@serenity-js/assertions';
import { isVisible } from '@serenity-js/protractor';

Wait.upTo(Wait.duration.ofSeconds(30)).until(BasePage.loading, not(isVisible())),

Let me know if this helps!
Best,
Jan

Thank you @jan-molak i'll try it out Thanks again. 😊


[core] multipart/form-data: add support for extra file upload data types

Generated RLC code now supports these types for file uploads in multipart/form-data. We need to support all of them:

[x] File
[x] Blob
[x] Uint8Array
[x] NodeJS.ReadableStream
[x] ReadableStream

Should we add resettable streams to the mix?

close it as should have supported.


CGO_ENABLED=0  build fails on go 1.12

What version of Go are you using (go version)?

$ go version

go version go1.12.1 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
kernel version Output
$ uname -a
Linux thinkpad 5.0.3-arch1-1-ARCH #1 SMP PREEMPT Tue Mar 19 13:09:13 UTC 2019 x86_64 GNU/Linux

go env Output
$ go env
GOARCH="amd64"
GOBIN="/home/ward/go/bin"
GOCACHE="/home/ward/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ward/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/ward/go/src/bitbucket.org/factionxyz/test-env/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build544707537=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ CGO_ENABLED=0 go build -a
# bitbucket.org/factionxyz/test-env
loadinternal: cannot find runtime/cgo

What did you expect to see?
Go compiles without issues like it did with 1.11.

$ CGO_ENABLED=0 ~/Downloads/go1.11.6.linux-amd64/bin/go build -a

What did you see instead?
Compilation exited with errors.
loadinternal: cannot find runtime/cgo

Please give us the exact steps to reproduce this issue. Thanks.

Ok, I found I actually have https://www.archlinux.org/packages/community/x86_64/go-pie/ installed. I must have missed the package change.
I guess this issue can be closed.
But as a follow-up question. Is a build with CGO_ENABLED=0 supposed to work when PIE is enabled?

/cc @ianlancetaylor for cgo

We don't currently support PIE when not using cgo.  There is some background at #18968.


Optimize openType load

https://github.com/TakWolf/nico-font-tool/blob/b37c4ac5b48e6f052120821b582ff90591259fd8/src/nico_font_tool.nim#L21-L27

raise to: https://github.com/treeform/pixie/issues/539


minor tweaks in doc

Tweaking docs of command-line interaface

Can one of the admins verify this patch?


Startup policy implementation

Implementation for https://github.com/kubernetes-sigs/jobset/pull/244

For reviewers, this is not ready.  Just wanted to put it up here as I work on it.
I would like to keep design discussions on the KEP PR for now.  I just find it hard to visualize all these items without some kind of implementation.
Integration tests are needed and there are a few bugs I gotta work out.

/test pull-jobset-test-integration-main

/test pull-jobset-test-e2e-main-1-28

/hold
Something is not yet right with this code. Tests should pass now but need to enhance them.

Is this ready for review

Is this ready for review

Yea, there is still a bug when manually testing it. I hope to find some time to look into this.

@ahg-g thank you for the review. I am afraid I am busy with KEP work and preparing for FOSDEM. I will get to this sometime soon but it may be sparingly.
I am actually presenting a talk at FOSDEM about JobSet and Job so its sorta related. ;)

/restart

/retest

Thanks Kevin!
/lgtm
I will leave approve to Daniel.

/label tide/merge-method-squash

@danielvegamyhre i think https://github.com/kubernetes-sigs/jobset/pull/246#discussion_r1484803940 is the last thing to address. I’ll push a change on Monday.
/hold cancel

@danielvegamyhre @ahg-g I think I've addressed all outstanding items. PTAL when you can.

/hold

Thanks for the changes, LGTM! Appreciate your work on this @kannon92!

/hold cancel


Remove nowcast

Remove directory nowcast and everything in it.
Remove nowcast from python-ci and create-release.

See https://github.com/cmu-delphi/delphi-epidata/pull/1323 for more details.

Made a tag here.


Added background, and color css declarations for table tfoot

Fix for this: #8802 and in favor of PR #8821

@denisahac Thanks this looks good to go!
Merging...


[Docs] EVP_RAND-SEED-SRC Example fails (uninstantiated Seed Src)

Version: 3.0.12
sha256: 9a7a7355f3d4b73f43b5730ce80371f9d1f97844ffc8c4b01c723ba0625d6aad

The example in https://www.openssl.org/docs/man3.0/man7/EVP_RAND-SEED-SRC.html fails
...
EVP_RAND_instantiate(rctx, strength, 0, NULL, 0, params); // ret = 0
...

After some digging, the problem is that the fetched seed is uninstantiated, when its child rctx is in the process of instantiating.
So I presume the simple fix is to instantiate seed after its creation, i.e.,
  /* Create a seed source */
  rand = EVP_RAND_fetch(nullptr, "SEED-SRC", NULL);
  seed = EVP_RAND_CTX_new(rand, NULL);
  EVP_RAND_instantiate(seed, strength, 0, NULL, 0, NULL); // add this line
  EVP_RAND_free(rand);

Would you like to create a pull request correcting this issue?

Would you like to create a pull request correcting this issue?

Sure :)


Create way to see other registered users in dummy app + add as friend.

I think this functionality would be useful to others who are using parse to build a social network. Also will be nice to how many people are using this demo app to sign up.
As an extra it would be nice to add these as a friend when logged in and see who you have as a friend.

I've addressed the beginning of this in my pull request.


Make html

Added all of the Angulars

Lol, miss you guys
On 2 Jun 2017 9:08 am, "Stephen Parker"<EMAIL_ADDRESS>wrote:

Closed #42 https://github.com/wdi-hk-sep-2014/PepperLunchClone/pull/42.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wdi-hk-sep-2014/PepperLunchClone/pull/42#event-1107300349,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7QamEl0rZGbJcNe_Y-wCKD9vsqNlaqks5r_7TmgaJpZM4C6hTC
.

Haha miss you.too mate!! When you back in hk?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/wdi-hk-sep-2014/PepperLunchClone/
pull/42#event-1107300349>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7QamEl0rZGbJcNe_Y-
wCKD9vsqNlaqks5r_7TmgaJpZM4C6hTC>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/wdi-hk-sep-2014/PepperLunchClone/pull/42#issuecomment-305718493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHseCOjGJVUFGZfB9LRocZ71F9mZHvA9ks5r_8GRgaJpZM4C6hTC
.


Debugging mode is not working

What steps will reproduce the problem?

When I run the code in debugg mode it simulates 2-3 lines and becomes irresponsive.
I need to restart spyder or reset kernal to use spyder again

Hi @VinayKillamsetty and @sguysc if you are using conda I would suggest you to create a new environment using only conda-forge packages to get the latest Spyder version. This is necessary since the default channel is stuck in Spyder 5.1.5 (a more than nine month old Spyder version which is broke do new dependencies versions available on the default anaconda channel like qtconsole or jupyter_client) and we don't have control over that unfortunately :/. To create the new env, you should run from an Anaconda  prompt something like this:
conda create -n spyder-env -c conda-forge spyder

That should get you the latest Spyder version (currently 5.3.1) installed. Also, in general, mixing channels by for example installing things with conda-forge on your base environment can cause issues and mess up your Anaconda installation.
If you use Windows or MacOS I would also suggest to try our standalone installers available at our release page: https://github.com/spyder-ide/spyder/releases/latest
Let us know if something of the above helps.

I installed via your command and got no errors, activated the spyder-env and ran spyder. This is what I get:
Traceback (most recent call last):
  File "/home/userrr/anaconda3/envs/spyder-env/bin/./spyder", line 7, in <module>
    from spyder.app.start import main
  File "/usr/lib/python3/dist-packages/spyder/app/start.py", line 14, in <module>
    import zmq
  File "/usr/lib/python3/dist-packages/zmq/__init__.py", line 47, in <module>
    from zmq import backend
  File "/usr/lib/python3/dist-packages/zmq/backend/__init__.py", line 40, in <module>
    reraise(*exc_info)
  File "/usr/lib/python3/dist-packages/zmq/utils/sixcerpt.py", line 34, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/zmq/backend/__init__.py", line 27, in <module>
    _ns = select_backend(first)
  File "/usr/lib/python3/dist-packages/zmq/backend/select.py", line 28, in select_backend
    mod = __import__(name, fromlist=public_api)
  File "/usr/lib/python3/dist-packages/zmq/backend/cython/__init__.py", line 6, in <module>
    from . import (constants, error, message, context,
ImportError: cannot import name 'constants' from partially initialized module 'zmq.backend.cython' (most likely due to a circular import) (/usr/lib/python3/dist-packages/zmq/backend/cython/__init__.py)

Seems like this error comes from the previous actions you tried (installing Spyder in your base env using  pip install --user and using the conda-forge channel on your base env). Maybe check if there are any Python related things at ~./local and remove them. If that doesn't help, I would suggest to reinstall anaconda and create again a new env with only conda-forge packages to get the updated Spyder version. Besides this suggestions I think there is not much more we can do to help, sorry :/

Hi, dalthviz.
Your suggestion helped me to resolve the problem.
But, I am still unable to properly install PyTorch in this environment.
i tried to install pytorch using
conda install pytorch torchvision torchaudio cudatoolkit=11.3 -c pytorch
It got successfully installed.
But later I am unable to import pytorch in my code


PRO-3923 Add persistence option to run-qemu script

Didn't realize the run-qemu script was in meta-updater too.

@tkfu What is the point of having it in both places? @cajun-rat made the copy, so perhaps he knows if you don't.

@patrickvacek I'm not sure, but @cajun-rat is on vacation until next week. @OYTIS, do you know why this got moved?


Preconfigure PKE in pre-cached images

Is your feature request related to a problem? Please describe.
When creating a cluster using a pre-cached image with PKE already installed, I don't want:

PKE to be installed again
Container runtime and Kubernetes installed again
Container runtime and Kubernetes configured again

Describe the solution you'd like to see
Store some PKE configuration in images that PKE can use to configure the node (eg. container runtime). This configuration could be created by a user data script on base images without PKE.

Config (eg. /etc/banzaicloud/pke.yaml):
kubernetes:
    version: 1.18.2
    installed: true

containerRuntime:
    type: docker
    installed: true

Machine image: generate config
User data script: generate config if not already present
PKE command: do not use the above flags


installation error

the following error was generated when I follow the installation steps. Could anyone help? Thanks!
ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /content

For colab users, do
'''
!git clone https://github.com/lindermanlab/ssm
%cd ssm
!pip install numpy cython
!pip install -e .
'''


Any interest in a Client based on aioredis?

I think it would be nice if there were a RediSearch asyncio Python Client, specifically, one based on the aioredis asyncio (PEP 3156) Redis client library. Looking at the redisearch-py code, it seems like this would only require implementing a new Client class based on aioredis with async methods, rather than making a whole new library. Is this something users would be interested in? Are the maintainers open to adding support for asyncio? I'm willing to tackle the initial implementation and make a pull request. Let me know.

@alancleary thanks the nice suggestion, yes we'll be welcome such a PR.

Hey there. Sorry for the long delay on this. I went through and ported the whole client and auto_complete classes into aio code but then got hung up on how to set up testing and installation. I guess testing isn't strictly necessary since the classes are implementing the same API but I'm not sure how to handle installation since aioredis supports Python 2 and aio is a Python 3 feature.
Let me know if you have thoughts on this or if I should just go ahead and make a PR with just the aio classes.

@alancleary Mind sharing a link? We've recently started unifying a client to combine async, sync, and the various connection options (pools, sentinel, etc). I'd love to work with you on it if you're interested - especially as we haven't yet started the async side yet!

@chayim Here's a commit that adds an AioClient class (with AioBatchIndexer) and an AioAutoCompleter class: https://github.com/alancleary/redisearch-py/commit/ed3da46bc2a17b9060d0480c12954bec270b3d50. These are the only classes that needed to be ported because they're the only classes that use a Redis connection.
The classes use the aioredis module, which implements the same API as the redis module, so other than adding async and await in the correct places, the only difference is how the classes are initialized and destructed.
For initialization, I used the same initialization pattern as the aioredis module, so you can instantiate the classes with or without using await. For example:
from redisearch import AioClient

def main():
    client = AioClient("my-index")

async def main():
    client = await AioClient("my-index")

Instantiating a class using await initializes the aioredis Client (i.e. it actually connects to Redis), whereas omitting the await does not initialize the aioredis Client (i.e. it instantiates the aioredis Client but does not connect to Redis). This has the advantage of allowing users to instantiate the classes outside of the aio event loop. Notice in the code, though, that the classes' asynchronous initialize methods aren't called anywhere besides the __await__ method. This is because __await__ is simply calling the aioredis Client's initialize method. The aioredis Client actually calls its initialize method every time it sends a command to Redis, so if we don't explicitly initialize the aioredis Client when instantiating a redisearch class we know the aioredis Client will initialize itself when we start using it to send commands to Redis.
Initializing the aioredis Client as early as possible is nice, though, because it gives users an early exit if the connection fails. If a user has to instantiate a class outside of the aio event loop but wants the early exit, then they can call a redisearch class's initialize method themselves once inside the even loop. For example:
import asyncio
from redisearch import AioAutoCompleter

async def main(auto_completer):
    await auto_completer.initialize()

if __name__ == '__main__':
    auto_completer = AioAutoCompleter('ac')
    asyncio.run(main(auto_completer))

Those were the only additions to the redisearch API.
Regarding class destruction, I had to update the AioBatchIndexer's __del__ method to account for the event loop. Specifically, I used the same destruction pattern as the aioredis module, which checks if the event loop is still running and tries to run a new loop if it's not. The problem with this approach is that in some cases the event loop will be stopped and you won't be able to start another, meaning the last batch commit will not happen. aioredis gets around this by using the asynchronous __aenter__ and __aexit__ context manager magic methods, which guarantee that the event loop will still be running when the class's context is exited. Here's an example of what using such a context manager might look like:
client = await AioClient("my-index")
async with client.batch_indexer() as indexer:
    pass

Not only does this guarantee that the last commit will happen, it will also be at a much more predictable time, i.e. when the indexer block is exited, instead of whenever the heck the interpreter decides to call __del__. In fact, I think predictability is a good reason to add a similar context manager to the existing BatchIndexer class as well (and maybe even the (Aio)Client and (Aio)AutoCompleter classes).
Anyway, let me know if you have any questions or anything about the commit. I'm excited you're interested in adding aio support and I'm willing to help out however I can.


Backprojector

This PR contains the back projector for MBIRCONE.
Interface design

Implementation
I modified the C function "backProjectlike3DCone" to "backProject3DCone", and put a python interface on top of that.
Other than that, none of the existing C or python functions are modified.
Testing
test script: "test/test_backproject.py"
Test results:
Phantom:

Back projection:

Ok.  I approve.


Better Cupertino Icons

Looks like the Flutter team has some Cupertino icons in a font, but does not expose all of them yet. Watch for updates to the Flutter repo and use the better icons when available.

Which Icons do you have in mind?


Update notification message when starting KA Lite server in windows application.

Summary

This will notified the user to wait, When starting the KA Lite server.

Issues addressed
Fixes #456

@mrpau-richard build failure is because of the Travis update, I've fixed it in the latest master a 0.17.x branch, so if you update your PR, it will work.

@mrpau-richard see above regarding getting the tests to work ^

@radinamatic I think the user must manually set it's duration. I found some of instructions here

Ok, thanks for investigating this!

Merging this.


[DONOTMERGE] ciao-controller: increase code coverage

This pull requests has a series of commits to increase/improve the code coverage for ciao-controller.
Fixes #349
Signed-off-by: Leoswaldo Macias<EMAIL_ADDRESS>

Coverage increased (+0.1%) to 64.831% when pulling 702d734df9caff02bdf207a61d7816b7fddd57b8 on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.1%) to 64.817% when pulling bb9d7afdedcec3b2c81504d99ab8d569c2aeee75 on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.07%) to 64.783% when pulling bb9d7afdedcec3b2c81504d99ab8d569c2aeee75 on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.1%) to 64.831% when pulling a9f3c9554c2a727770bb9749158993789d0a28bb on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.09%) to 64.803% when pulling a9f3c9554c2a727770bb9749158993789d0a28bb on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.2%) to 64.906% when pulling cdd46a4e6a21576e597c5015c3a752b722b6f8fc on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.2%) to 64.885% when pulling 157b143c648d0bb98edcae6946f4cf5518d473cc on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.2%) to 64.919% when pulling f6fc79b79680e00a1d47ea42be3b44e55f7fc5c3 on leoswaldo:leoswaldo/ciao-controller/testcoverage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

Coverage increased (+0.1%) to 64.837% when pulling 24b7c2da710db69b1b65c45eda424ec863e113de on leoswaldo:leoswaldo/ciao-controller/testcoverage into dd98c8947fcf0431c4606760491c81c64576703e on 01org:master.

Coverage increased (+0.6%) to 65.302% when pulling a00d0cc232e2c2248a6ce55d32d637eee27f5a25 on leoswaldo:leoswaldo/ciao-controller/testcoverage into dd98c8947fcf0431c4606760491c81c64576703e on 01org:master.

Coverage increased (+0.6%) to 65.343% when pulling 419fd8d930ebba63a3ef38eac32114fd4694108f on leoswaldo:leoswaldo/ciao-controller/testcoverage into dd98c8947fcf0431c4606760491c81c64576703e on 01org:master.

That one looks good to me, thanks @leoswaldo.


LongArray in input param cause java.lang.IllegalArgumentException

Hi
my sample code that cause Exception
@Composable
@Destination
fun TestScreen(
    input: LongArray,
) {
    ///rest of my code
}

after calling navigator.navigate(TestScreenDestination(input = longArrayOf(152L,152L,152L,3256L,362L,362L))
this exception thrown
 java.lang.IllegalArgumentException: Navigation destination that matches request NavDeepLinkRequest{ uri=android-app://androidx.navigation/test_screen/[152,152,152,3256,362,362] } cannot be found in the navigation graph NavGraph(0x78dcd1ef) route=root startDestination={Destination(0x142feed7) route=splash_screen}
thanks for your good job

I did a change on all nav types except long array 🤦
Fixed! It will be in the next release! 🙂
Thank you for reporting 🙏

Please try 1.5.11-beta (should be up soon on maven central) and let me know if it fixed this for you!
Thanks again for reporting! 🙏


HTTP: support DNS failover

Implement failover when one IP becomes unreachable but we got multiple DNS records.
http://serverfault.com/questions/327708/how-browsers-handle-multiple-ips

ping @landro

Thanks @slandelle . I'll give it a test drive as fast as I can.


[Fix]: overflow-issue #8686

Fixes Issue #8686
Closes #999
Changes proposed
removed self closing span tag and added classes break-all in min-320px and break-normal in min-425px

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

I can see that the Issue that this relates to has not yet been triaged, so in accordance with the project's Contributing Guide I am closing this PR.
@vedantnaik1008 I suggest you familiarise yourself with this project's guidelines so that any work and time you spend is not wasted.


Fix double executed rule function

This PR fix double execution on rule function.

@JonathanSudibya can you give me an example case when we re-use the engine?
IMO, right now we use rules engine like this:
e := fished.New(nil)

// ...set rules, rule functions & facts

// and then run
e.Run()

I don't see there's need to re-use from above case. Since, we also doesn't have function to clean-up rules, fact, and rules function?

The generic Idea is to use re-initiate the engine as less as possible because it is very expensive.


Leaky Relu Activation

Hi again :)),
Leaky relu activation isn't in SUPPORTED_ACTIVATIONS, but it's not in UNSUPPORTED_ACTIVATIONS as well.
Does DeepExplain support leaky relu or not?

It should be indeed.

I added the LeakyRelu to SUPPORTED_ACTIVATIONS, and installed it using ````python setup.py install``` but I faced some more errors.

Is anyone able to resolve the issue? Is LeakyRelu supported by DeepExplain?

It should be indeed. As a quick fix, you can try to add it to SUPPORTED_ACTIVATIONS

Are you sure? Awaiting your reply!


feat: Default fill property set to path for React components

For React component selections, I think there should be default fill props for path's fill property.  Every time that property comes with "#eaeaea" value, and we have to change it manually. But as it's not the svg, we can't change it directly through component's props, so it's either going to be hardcoded or we'll define fill property to pass it as props on component. Since hardcoding is not the best practice, I assume this approach would be better for everyone. Thank you.
Suggested usage:
export function Heart(props, { fill }) {
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      width="1em"
      height="1em"
      viewBox="0 0 24 24"
      {...props}
    >
      <path
        fill={fill}
        d="m12 21l-1.45-1.3q-2.525-2.275-4.175-3.925T3.75 12.812T2.388 10.4T2 8.15Q2 5.8 3.575 4.225T7.5 2.65q1.3 0 2.475.55T12 4.75q.85-1 2.025-1.55t2.475-.55q2.35 0 3.925 1.575T22 8.15q0 1.15-.387 2.25t-1.363 2.412t-2.625 2.963T13.45 19.7z"
      ></path>
    </svg>
  )
}

Current usage:
export function Heart(props) {
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      width="1em"
      height="1em"
      viewBox="0 0 24 24"
      {...props}
    >
      <path
        fill="#eaeaea"
        d="m12 21l-1.45-1.3q-2.525-2.275-4.175-3.925T3.75 12.812T2.388 10.4T2 8.15Q2 5.8 3.575 4.225T7.5 2.65q1.3 0 2.475.55T12 4.75q.85-1 2.025-1.55t2.475-.55q2.35 0 3.925 1.575T22 8.15q0 1.15-.387 2.25t-1.363 2.412t-2.625 2.963T13.45 19.7z"
      ></path>
    </svg>
  )
}

React code samples use currentColor for fill, so your current usage example is incorrect.
Using currentColor makes it easy to style icon by adding style={{color: '#eaeaea'}}. No need to add extra properties.
Furthermore, using fill is incorrect because not all icons use fill. Many icons use stroke. Your solution would work only for a subset of icons. Using fill as prop for icons is a bad idea.


Remove unused skiplist types

@fabxc These aren't used anywhere - of course it's entirely possible that you intend to use them somewhere in the future, in which case feel free to close the PR.

Probably not in the near future. So this can go.


Try to remove panic=abort patch

https://github.com/meta-rust/meta-rust/issues/343

We delay work on that issue as RUST_PANIC_STRATEGY seems not to work on newer Yocto distros. As a temporary solution we will use unwind strategy that is set using patch.


models(gallery): add phi-3 vision

Description
This pull request adds new configurations and descriptions for the Phi-3 model family in the gallery. The most important changes include adding new entries for the Phi-3.5-vision model and creating a configuration file for the phi3-vision model.
New Model Entries and Descriptions:

gallery/index.yaml: Added new entries for phi-3-vision:vllm and phi-3.5-vision:vllm, including detailed descriptions and URLs.

Configuration Files:

gallery/phi-3-vision.yaml: Created a new configuration file for the phi3-vision model, specifying parameters such as backend, model, and templates for chat and completion messages.

Notes for Reviewers
Part of #3670
Signed commits

[ ] Yes, I signed my commits.

Demo of this available at: https://demo.localai.io/chat/phi3-vision


[Feature Request]table prefix support

All my tables had same prefix like xxx_, for example:
xxx_users
xxx_posts
xxx_tokens

The generated codes like model,  dao, routes all have xxx included, like XxxUser , GetAllXxxUser and /xxxuser, /xxxuser/:argId.
I wanna request a new feature like adding something like a param named prefix and auto stripping the prefix when generating codes. The ideal model, dao, routes look likes following User, GetAllUser, /user and /user/:argId

Works perfect.
Thanks @alexj212 .


TypeError: e.join is not a function

Describe the bug
To Reproduce
Expected behavior
Screenshots
Applicable Versions:

Netlify CMS version<EMAIL_ADDRESS>Git provider: git-gateway
Browser version: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.150 Safari/537.36

CMS configuration
publish_mode: editorial_workflow
backend:
  name: git-gateway
  branch: main
public_folder: /images/uploads
media_folder: /images/uploads
collections:
  - sortable_fields:
      - commit_date
      - title
      - date
      - commit_author
    view_filters: []
    meta: {}
    name: blog
    slug: "{{slug}}"
    folder: posts
    view_groups: []
    publish: true
    label: Blog
    fields:
      - label: Layout
        name: layout
        widget: hidden
        default: blog
      - label: Title
        name: title
        widget: string
      - label: Publish Date
        name: date
        widget: datetime
      - label: Image
        name: image
        widget: image
      - label: Rating (scale of 1-5)
        name: rating
        widget: number
      - label: Body
        name: body
        widget: markdown
      - label: Tags
        name: tags
        widget: list
    create: true
slug:
  encoding: unicode
  clean_accents: false
  sanitize_replacement: "-"

Additional context

Hi @OlenaSakhno can you share a screenshot of the error and potentially a public repo reproducing it?


Issues With Pseudo Parameters When Using LanguageExtensions

CloudFormation Lint Version
0.79.1
What operating system are you using?
Debian
Describe the bug
cfn-lint raises various errors when using pseudo parameters along with the LanguageExtensions macro. I'll provide two examples:

AWS::RegionTransform: AWS::LanguageExtensions
Resources:
  MyNestedStack:
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL: !Sub https://mybucket-${AWS::Region}.s3.${AWS::Region}.amazonaws.com/my-nested-stack.yml

❯ cfn-lint nested.yml
E1029 Found an embedded parameter "${AWS::Region}" outside of an "Fn::Sub" at Resources/MyNestedStack/Properties/TemplateURL
nested.yml:6:7

AWS::AccountIdTransform: AWS::LanguageExtensions
Resources:
  MyBucket:
    Type: AWS::S3::Bucket
    Properties:
      BucketName: !Sub "my-bucket-${AWS::AccountId}"

❯ cfn-lint bucket.yml
E1029 Found an embedded parameter "${AWS::AccountId}" outside of an "Fn::Sub" at Resources/MyBucket/Properties/BucketName
bucket.yml:6:7

E3031 BucketName contains invalid characters (Pattern: ^[a-z0-9][a-z0-9//.//-]*[a-z0-9]$) at Resources/MyBucket/Properties/BucketName
bucket.yml:6:7

For both of the above examples, remove Transform: AWS::LanguageExtensions removes the errors.
Expected behavior
We use a template like the one with the nested stack in production and has been working flawlessly and even used to be deemed valid by previous cfn-lint versions so I would expect that newer versions of cfn-lint still think it's valid.
Reproduction template
Transform: AWS::LanguageExtensions
Resources:
  MyNestedStack:
    Type: AWS::CloudFormation::Stack
    Properties:
      TemplateURL: !Sub https://mybucket-${AWS::Region}.s3.${AWS::Region}.amazonaws.com/my-nested-stack.yml

I also noticed this just now.

@nVlast this should be fixed.  Can you validate?

0.79.3 fixed the issue for me

I believe this to be fixed we can re-open as needed.

Hi @kddejong, thanks for working on this! Do you have any idea when this lands on homebrew? The current version there is 0.79.1

@nVlast this should be fixed. Can you validate?

Thank you, @kddejong. The issue is now fixed!


Implement HTTP Archive query to assess usage of block themes.

Fixes #9
This query identifies sites using a block theme by checking for the <div class="wp-site-blocks"> tag which is present in all such sites, as controlled by WordPress core.
Query results

Row
client
with_block_theme
total_wp_sites
pct_total
wp_gte_59

1
desktop
7190
4241264
0.0016952493407625651
3393158

2
mobile
13074
5703734
0.0022921826298351222
4471610

Based on November 2022 dataset

@vishalkakadiya @ankitrox Could you please review this? It's relevant to several analysis, but particularly was called out for the lazy-loading research and the web fonts API research.
Overall, this data shows that, at least as of November, only ~0.2% of all WordPress sites were using a block theme.

@felixarntz The query looks good to me though I haven't run it as it is processing more than 1TB of data. Thank you!

@felixarntz Approved now!

Thanks!

@mukeshpanchal27 @vishalkakadiya FYI see https://github.com/HTTPArchive/custom-metrics/issues/61 for adding a custom metric to HTTP Archive so that we will be able to run a much simpler version of this query in the future.


about your trained model.

about the trained model you provided, "model_seed1_39.pth",  "model_seed2_39.pth",  "model_seed3_37.pth"
what's mean the seed?
when I try to test loca_evaluation, must be used all three model files?

We trained each model 3 times with different random seeds to build an ensemble.
The seed in the name of the file is just an index for the training run (e.g. seed 1 is the model from training run 1, etc.).
The 39 / 37 denote the epoch used.
If you want to reproduce the numbers in the main table you should use all 3 models, yes.
You just need to place them in the same folder and the code will automatically load all three models and average their predictions.

Thx for your reply.
I have one more question.
What is the train set used to make the model you offered?
is that "left ll lr right rl rr s1 s3 s4 s7 s8 s9 s10" total 13 zip files that I can download?


Keep data of home tab.

Dear Developers,
I have a problem which related keeping data.
When user click home tab again fragment is re-created again and data is loaded again.
I'd like to keep data previously same Youtube app.
Could you have any solution for this problem with Navigation?
Thank you very much for your tuts.

Fragment re-creation is intended behavior, see this bug.
You'd need to persist your data state somewhere, such as a shared view model or a database. For a simple implementation of data persistence with Room, you can check out the Room with a View codelab


Video

https://github.com/user-attachments/assets/06b365f7-20c5-4a48-8966-e3151d2bd66b

https://github.com/user-attachments/assets/54ef4510-f103-466b-a253-c5652abba928


Protected circuits leak traffic

When creating a protected circuit between a Nokia and a Juniper, the primary circuit will leak multicast and broadcast traffic into the protection circuit and back, eventually causing a broadcast storm.
The current circuit where this is an issue is MWHJ (LBNL-JGI).

There's a commit that fixes a priority issue that likely caused this.


Create a notification / RSS feed connected to data action (add record, edit record)

Reviewed issue with esri on 9/12/23. Tech support suggested integration with Power Automate as a possible solution.
An alternative solution is to turn on the edit log feature for the editable project layers (settings), which stores last edit info as an attribute of the data. From there, maybe we can use a built-in widget to display that data in a feed.

Submitted issue to Esri Tech Support. Ticket info copied below:
Esri Case #03448832 - Experience Builder: how to trigger an alert when a record is added, removed, and/or changed, e.g. via RSS feed or other
Hello Patrick,
I've been doing some research and Experience Builder does not have built in functionality or a widget solution to trigger an email alert or RSS feed when a feature is added/deleted/modified.
However, I did locate the following Esri technical article:
Create a webhook with Make which sends an email notification when a feature service is updated
https://support.esri.com/en-us/knowledge-base/how-to-create-a-webhook-with-make-which-sends-an-email-000023798
This may get you what you need.
Furthermore, if you think the Experience Builder functionality can be improved, I would like to recommend visiting the ArcGIS Ideas Portal at https://community.esri.com/t5/custom/page/page-id/arcgis-ideas and submitting your idea.  This portal is where enhancement recommendations can be submitted and allows anyone to view and vote for them.  The more votes obtained for an enhancement request, the more likely that enhancement will be implemented by the Development Team.

Desired functionality is featured in the Open Litter App.
See demo here (min. ~20)
Founder, Sean, is part of the JOGL community and can be reached via Slack or email.

Contacted Sean on JOGL Slack on 10/6.


[flutter_tools] Make flutter upgrade --verify-only display framework version differences instead of commit hashes

Description
This PR changes the display message when one runs flutter upgrade --verify-only, having an available update; namely, replacing the commit hashes with the framework versions.
Related Issues
Fixes #69417.
Tests
I modified the following tests:

Test to check whether the upgrade message is printed with correct user and update versions of flutter.

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@christopherfujino I've changed GitTagVersion to be able to construct from a given revision, and likewise updated Future<String> fetchRemoteRevision() to Future<FlutterVersion> fetchLatestVersion().
I've not updated the tests for now, which is why they are failing. Let me know your thoughts about the approach and then we can discuss on the tests.

@christopherfujino I've changed GitTagVersion to be able to construct from a given revision, and likewise updated Future<String> fetchRemoteRevision() to Future<FlutterVersion> fetchLatestVersion().
I've not updated the tests for now, which is why they are failing. Let me know your thoughts about the approach and then we can discuss on the tests.

Sorry, I missed this. Taking a look now!

Also it looks like this branch has a merge conflict with upstream.

I saw this PR and understood it.
I think your suggestion looks good.
Amend your suggestion to #68421.
Should I wait until this PR is merged?

Should I wait until this PR is merged?

@karamage I think it would be better if you do.

@christopherfujino I've updated the tests, PTAL when you have time.

@christopherfujino I've updated the tests, PTAL when you have time.

it looks like they're failing on CI:

it looks like they're failing on CI

Could you point out what is causing this problem? Or anything I should do in my fork?

Could you point out what is causing this problem? Or anything I should do in my fork?

I know the CI build logs are not exactly intuitive. This issue has more details about investigating test logs: https://github.com/flutter/flutter/issues/64208. Please try to investigate and resolve yourself. If you are still stuck, I will try to make time for this next week.

Could you point out what is causing this problem? Or anything I should do in my fork?

@RoyARG02 The CI logs are hard to navigate.  Your test failure is:
03:02 +425 ~4 -1: test/general.shard/runner/flutter_command_runner_test.dart: FlutterCommandRunner run version checks that Flutter toJson output reports the flutter framework version [E]
  NoSuchMethodError: The getter 'exitCode' was called on null.

Thanks @christopherfujino for assisting me in landing this PR.


Fix regression caused by #170  (fix devel:LEO xml)

Instead of forcing the / we provide it in the xml as a suffix.

Hm, I am not sure if it is really needed. After make test_regen_all I see in read_files.sh: rsync -4 --list-only $rsync_pwd_option obspublish-other::openqa/devel:LEO/images/*//*ALP-ftp-POOL*/  - it is ending on / already

Hm, I am not sure if it is really needed. After make test_regen_all I see in read_files.sh: rsync -4 --list-only $rsync_pwd_option obspublish-other::openqa/devel:LEO/images/*//*ALP-ftp-POOL*/  - it is ending on / already

Right, I tested locally too... not sure why it was introduced in https://github.com/os-autoinst/openqa-trigger-from-obs/pull/170/files then


Add isMetaMask set to true by default

Also added tests for overwriting request

Tests are still failing though.


Updates for Crystal 0.28.0

Pretty sure our only use of deprecated API was Time.utc_now & Time.new with location.

@RX14 Will this be merged? @meew0 ?


XY Grid - align-stretch has no effect with grid-margin-y

How to reproduce this bug:

Create a horizontal grid with vertical margins: grid-x grid-margin-y.
Add align-stretch.

What should happen:
The cells height should stretch.
What happened instead:
The height is enforced to by .grid-margin-y > .cell and therefore do not stretch.
Browser(s) and Device(s) tested on:
Chrome
Foundation Version(s) you are using:
develop-branch
Test case link:
https://codepen.io/anon/pen/xrOMNP?editors=1100
Related: https://github.com/zurb/foundation-sites/pull/10157

@brettmason One remaining issue that I can think of with this. The base .cell class is linked to .grid-margin-x/y - specifically their width/height whish is outputted at 100% (minus the margin). Could this cause issues in certain configurations?

See @brettsmason, that's why i said we need to integrate flex alignments with the grid ( #10117 )
This way we will get to know the bugs too!


Crash when try to talk npc and get quest

after 2022/11/23 title update 3 in Monster hunter rise the game keep crash when I talk to NPC Chichae for getting into the mission board. The causing issue was reframework I remove "dinput8.dll " file and the game properly worked.
(re2_framework_log.txt)
https://drive.google.com/file/d/1W-J5FwMBDHUtIQocoX0VVWnHR0IDLyYz/view?usp=sharing
second link is reframework_crash.DMP. you may need to drag link and post on google...
I am post these crash log first time if i post wrong place then i am so sorry.

Try deleting the RiseQuestLoader.dll in the reframework/plugins directory.

ty so much it worked.


Updated dependency to powerbi-visuals-webpack-plugin 2.3.0

Updated dependency to powerbi-visuals-webpack-plugin 2.3.0, needed for CV modal dialog support.

@AsafMozes, the build is failed, please take a look

I could not fix the tests that failed.


Add De/Serialize for Qoute3

The Quote3 type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.

Motivation

Future Work

Current dependencies on/for this PR:

main

PR #365

PR #366

PR #367   👈

This comment was auto-generated by Graphite.


Pre-optimism regenesis transfers and transferRoots loop through populate...() functions repeatedly on a new sync

With a new sync, pre-optimism regenesis transfers and transferRoots loop through populate...() functions repeatedly. You can see this on the 2f51ac4bd89013b2a23ebc4e9ec20a21b6b461f8ede2b8ae54cddeacf5cbfa2a log stream of the ETH bonder by searching for "populating" and observing the same ID or root being populated repeatedly. This is non-blocking and everything continues to work, however, I believe many, many RPC calls are used in this case.
I believe the intended behavior is to ignore the IDs and roots if the populate...method() after attempting a populate one time.
To reproduce, perform a fresh sync (of ETH) and then watch the logs attempt to populate the DB items repeatedly.

In the case of pre-regenesis transfers and roots, I think it'd be best to store the list of transfer ids and transfer root ids in a file and have the db getters ignore them so it doesn't attempt to process them at all to save resources since we know that they won't exist and can't be processed at all.
For any other transfer ids or transfer root ids, they can be marked as notFound after initial attempt failure (not due to rate limit error)

For any other transfer ids or transfer root ids, they can be marked as notFound after initial attempt failure

I believe this is the intended behavior, but, I believe the logs at this time show that this is not happening as expected. I believe this is the piece that needs to be understood and resolved, as this is what I believe the intention is even before this issue was opened.

In the case of pre-regenesis transfers and roots

I believe we need to design it in such a way that we should be able to function fine even with a regenesis. I know Optimism is planning at least one more and xDai/Gnosis have multiple regenesis on their roadmap. I'd imagine all other chains will do something similar too.
I think just marking as notFound is totally fine here and we can ignore the manual list. This may just be premature-optimization-thinking though. Curious about your thoughts here.

For example, searching for "expected timestamped key. incomplete transfer" in the current ETH running log stream b274c3658a3ff4613eda2caa2b51939f73941d264e07089bdeb79cbe821889c0 will produce many items that I would not expect to be there.

Closed by https://github.com/hop-protocol/hop/pull/376


Setting Up WiFi using myCobot 280 M5

Hello,
I am trying to set up my 280 M5 to connect to WiFi using the set_ssid_pwd() function on my Windows computer. I am afraid I cannot find any instructions on how to do this on your GitBook or any documentation. I derived the usage below based on your coding comments.
from pymycobot.mycobot import MyCobot
import time

print("   Activating Cobot...")
mc = MyCobot('COM3', 115200)
mc.power_on()
time.sleep(5)
print("   Cobot is now active.")

mc.set_ssid_pwd("wifi_ssid", "wifi_password")

print(mc.get_ssid_pwd())

This is using pymycobot version 2.8.1 and miniRobot version 2.0.
Is this correct? If so, the get_ssid_pwd() function is printing an empty list, and the WiFi credentials are not being sent to the cobot.
Output:
   Activating Cobot...
   Cobot is now active.
[]

Update 7/28/2022:
I have only gotten this to work once, but the cobot was still unable to connect to WiFi. All other attempts to set up a WiFi connect have still failed. See the debug output below.
   Activating Cobot...
11:23:13.740 DEBU [pymycobot.generate] _write: [254, 254, 2, 18, 250]
11:23:13.750 DEBU [pymycobot.generate] _write: [254, 254, 2, 16, 250]
11:23:18.759 DEBU [pymycobot.generate] _write: [254, 254, 2, 32, 250]
11:23:18.780 DEBU [pymycobot.generate] _write: [254, 254, 2, 176, 250]
11:23:18.781 DEBU [pymycobot.generate] _write: b"'wifi_ssid'(wifi_password)"
11:23:18.782 DEBU [pymycobot.generate] _write: [254, 254, 2, 177, 250]
   Cobot is now active.
11:23:18.883 DEBU [pymycobot.generate] _write: [254, 254, 2, 17, 250]
[]

@HCurrence Please update pymycobot to the latest version and try again


Event logs broken in ANCM v1 private builds

Event logs are broken when using a private build of ANCM v1, in either of these scenarios:

Install v1 hosting bundle, build ANCM v1 aspnetcore.dll locally, copy local build to C:\windows\system32\inetsrv
OR
Install aspnetcoremodule_x64_en.msi built from aspnetci

Here's the broken event log:
> get-winevent -ProviderName 'IIS AspNetCore Module' | format-list -property *
get-winevent : The specified resource type cannot be found in the image file
At line:1 char:1
+ get-winevent -ProviderName 'IIS AspNetCore Module' | format-list -pro ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-WinEvent], EventLogException
    + FullyQualifiedErrorId : The specified resource type cannot be found in the image file,Microsoft.PowerShell.Commands.GetWinEventCommand

Message              : Cannot retrieve event message text.
Id                   : 1001
Version              :
Qualifiers           : 0
Level                : 4
Task                 : 0
Opcode               :
Keywords             :<PHONE_NUMBER>8963968
RecordId             : 107
ProviderName         : IIS AspNetCore Module

Event logs seem fine when using a private build of the ANCM v2 module and outproc request handler.
Note that event logs may appear fine in the GUI Event Viewer app, but the powershell get-winevent command will fail.  Maybe the powershell command is more strict about something than the GUI.

The PR got approved for 2.1.5.


Low Opacity shows up as white

See #19498
Data is on the SCF in /usr/workspace/visit/visit/bug_data.
Check out the merged mili data set there and create a filled boundary plot; portions of is will be white in color.
This is new behavior in 3.4.1 as opposed to 3.3.3.

The white transparent geometry only happens when all the data is on rank 0 and running on more than one processor and using scalable rendering. If you run in serial, then the image looks normal.

This

I enabled some debugging support with the scalable rendering and transparency to better understand what was going wrong. To do this I uncommented
#define ProgrammableCompositerDEBUG
#define NetworkManagerDEBUG

in the file src/engine/main/NetworkManager.C.
This results in the following files being generated when run with 2 processes.
0_acomp_out.vtk
0_geom_in.vtk
0_trans_in.vtk
1_geom_in.vtk
1_trans_in.vtk

I then used the following script that generates 2 transparent blue circles one on top of the other so that I could determine what the calculation was for the color and alpha values.
OpenDatabase("/usr/gapps/visit/data/globe.silo")
# First slice
AddPlot("Pseudocolor", "w", 0, 0)
AddOperator("Slice", 0)

s = SliceAttributes()
s.originType = s.Intercept
s.originIntercept = 0
s.axisType = s.ZAxis
s.project2d = 0
SetOperatorOptions(s, 0, 0)

pc = PseudocolorAttributes()
pc.SetOpacityType(pc.Constant)
pc.opacity = 0.75
SetPlotOptions(pc)

# Second slice
AddPlot("Pseudocolor", "w", 0, 0)
AddOperator("Slice", 0)

s = SliceAttributes()
s.originType = s.Intercept
s.originIntercept = 5
s.axisType = s.ZAxis
s.project2d = 0
SetOperatorOptions(s, 0, 0)

pc = PseudocolorAttributes()
pc.SetOpacityType(pc.Constant)
pc.opacity = 0.75
SetPlotOptions(pc)

# Turn off annotations.
a = AnnotationAttributes()
a.userInfoFlag = 0
a.databaseInfoFlag = 0
SetAnnotationAttributes(a)

r = RenderingAttributes()
r.scalableActivationMode = r.Always
SetRenderingAttributes(r)

DrawPlots()

The following command runs the script on rzwhippet in a sxterm.
build/bin/visit -np 2 -l srun -s test4.py

Looking at the contents of 0_trans_in.vtk shows us the color components and alpha values for the transparent geometry.
Here is the blue component.
The yellow outer ring corresponds to 0.74902
The inner red circle in the center corresponds to 0.937255

Here is the alpha component.
The light blue outer ring corresponds to 0.188235
The inner darker blue circle in the center corresponds to 0.0588235

transparency in OpenGL is implemented using blending. It is described
here.
When using OpenGL, the function glBlendFunc controls how the colors are blended. The result color is computed as follows:
C_result = C_source * F_source + C_destination * F_destination

The C_source and C_destination are the incoming color and the color already in the frame buffer. The form of F_source and F_destination are set by the 2 arguments to the glBlendFunction call.
My belief is that the arguments to glBlendFunc should be (GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA).
This would give:
C_result = C_source * src_alpha + C_destination * (1 - src_alpha)

In our case we have C_source = (0, 0, 1, 0.74902), C_destination = (0, 0, 0, 1), src_alpha = 0.74902, which gives:
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
1.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.74902
0.74902 * 0.74902 + 1.0 * (1.0 - 0.74902) = 0.81201

for the outer ring and
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
1.0 * 0.74902 + 0.74902 * (1.0 - 0.74902) = 0.74902 + 0.18799 = 0.93701
0.74902 * 0.74902 + 0.81201 * (1.0 - 0.74902) = 0.56103 + 0.20380 = 0.76483

for the inner blue circle. The blue values look ok, but the alpha values are way off.

When I do the same thing with VisIt 3.3.3, I get the same values for alpha as for blue.

I added some tracing information to vtkglBlendFunc and vtkglBlendFuncSeparate in VTK-9.2.6/Rendering/OpenGL2/vtkOpenGLState.h and VTK-9.2.6/Rendering/OpenGL2/vtkOpenGLState.cxx and it looks like glBlendFuncSeparate is being called with:
glBlendFuncSeparate(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA, GL_ONE, GL_ONE_MINUS_SRC_ALPHA)

This would give
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
1.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.74902
0.74902 * 1.0 + 0.0 * (1.0 - 0.74902) = 0.74902

for the outer ring and
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
0.0 * 0.74902 + 0.0 * (1.0 - 0.74902) = 0.0
1.0 * 0.74902 + 0.74902 * (1.0 - 0.74902) = 0.93701
0.74902 * 1.0 + 0.74902 * (1.0 - 0.74902) = 0.93701

for the inner circle.
This is consistent with what VisIt 3.3.3 gives. Now, the big question is, why doesn't it?

I found that the way that VTK 9 handles transparency has changed and that is the cause of the transparency issues we are seeing with scalable rendering. It used to do straight alpha blending as described above with the assumption that the geometry was sorted. They have switched to a new method that leverages some of the depth peeling functionality to allow the geometry to be unsorted. Unfortunately, the alpha values it generates are different, which messes up our scalable rendering.
It is fairly easy to modify VTK 9 to use the old mechanism since the old code is still present and the new code just needs to be replaced with a single call to the old function that does the alpha blending.
Replace the following code in Rendering/OpenGL2/vtkOpenGLRenderer.cxx in the function vtkOpenGLRenderer::DeviceRenderTranslucentPolygonalGeometry at line 540:
  if (!this->UseDepthPeeling)
  {
    // old code
    // this->UpdateTranslucentPolygonalGeometry();

    // new approach
    if (!this->TranslucentPass)
    {
      vtkOrderIndependentTranslucentPass* oit = vtkOrderIndependentTranslucentPass::New();
      this->TranslucentPass = oit;
    }
    vtkTranslucentPass* tp = vtkTranslucentPass::New();
    this->TranslucentPass->SetTranslucentPass(tp);
    tp->Delete();

    vtkRenderState s(this);
    s.SetPropArrayAndCount(this->PropArray, this->PropArrayCount);
    s.SetFrameBuffer(fbo);
    this->LastRenderingUsedDepthPeeling = 0;
    this->TranslucentPass->Render(&s);
    this->NumberOfPropsRendered += this->TranslucentPass->GetNumberOfRenderedProps();
  }

with
  if (!this->UseDepthPeeling)
  {
    this->UpdateTranslucentPolygonalGeometry();
  }

and it works as before.
I suggest that is the way we proceed. The alternative is we could try and modify the scalable rendering code so that it doesn't depend on the alpha values. I think this is possible, but more investigation would be required.

Just curious if you think it feasible to create our own TranslucentPass (perhaps based off vtkOrderIndependentTranslucentPass) that does what we expect with Alpha ?
I am concerned about the maintainability of the patch if VTK should away with the UpdateTransparentPolygonalGeometry method in a future version.

Here is a link to a paper on using Dual Depth Peeling for order independent transparency. This may be useful in understanding how the new rendering works.
https://developer.download.nvidia.com/SDK/10.5/opengl/src/dual_depth_peeling/doc/DualDepthPeeling.pdf

@brugger1 thanks for this paper. Very interesting. I wonder...is our goal for transparency in VisIt one of visual pluasability or numerical correctness?  Reason I ask is that there are telltale signs in that article that computed values in all pixels may not be "perfect" but are instead only "plausible". The article also describes some "good approximations" which are faster such as single pass and weighted sum. I wonder which thing VTK is actually doing under the hood. Does VisIt control the number of passes being used? If I understand things, memory requirements go up with number of passes...we basically need a framebuffer's worth or RGBA values for each pass.
I found an NVIDIA slide deck that helped me understand the algorithm a bit better.

VisIt is still sorting the transparent geometry, so the order independent transparency rendering that VTK is now doing by default doesn't really impact us.
We do have a depth peeling option in our rendering options where we explicitly enable depth peeling and we do give the user control over the number of passes.


Make the root logger off by default

Purpose
The default root logger which prints ballerina-lang related errors to
the console is made to be off by default. To enable use the CLI
parameter -e b7a.log.console.loglevel=[LOG_LEVEL]
Approach

Change config

Samples

N/A

Remarks

N/A

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18626 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18626   +/-   ##
=======================================
  Coverage   15.15%   15.15%
=======================================
  Files          48       48
  Lines        1254     1254
  Branches      197      197
=======================================
  Hits          190      190
  Misses       1050     1050
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac71da...5d39ac4. Read the comment docs.


chown: changing ownership of '/tmp/ccache': Operation not permitted

docker_entrypoint: Creating user UID/GID [1000/1000]
docker_entrypoint: Creating user UID/GID [1000/1000] - done
docker_entrypoint: Copying .gitconfig and .ssh/config to new user home
docker_entrypoint: Copying .gitconfig and .ssh/config to new user home - done
docker_entrypoint: Creating /tmp/ccache and /aosp directory
chown: changing ownership of '/tmp/ccache': Operation not permitted
chown: changing ownership of '/aosp': Operation not permitted
how can i do this？ id repeat？

The same problem happen. Can you give some tips?

Same problem. Need help!

sudo chmod -R 0777 ~/aosp-root


SSL Certificate for 52calls-52weeks.com

Registered api.52calls through Let's Encrypt so it can be used with API gateway
Registered www.52calls and the bare domain through Amazon Cert Service for use with CloudFront


Added the ability to display the yearly calendar as a heatmap.

Hello. First of all, thanks for creating this handy module.
I have made a small change and I'd like to contribute it back to your project. I have added the ability to view the yearly calendar as a heatmap. I think this is a simple change, but I am a complete newbie to react so there is probably room for improvement.
I have modified the Calendar class so that it has a new property called dayToCSSClass. This is a map/dictionary whose keys are string dates (as might be created by a call to moment().toISOString()) and whose values are CSS class names. Then, in the _monthDays() function, when looping over all of the days, we check to see if the current day is a key in dayToCSSClass and if so, we add the value into the classes[] array for that day.
I have included a new example in examples/colordays that shows how one might use this.
Thanks again!

Hey Chuck,
Many thanks for your contribution! This partially covers Issue #4, so it's definitely helpful :)
The only issue I see here is that checking the 365-entries dictionary on every render cycle can be a little bit too expensive, so I'll look into this before merging it.

Thanks. I hadn't noticed that issue. Anyway, I look forward to seeing the improvements you make to this project. As I mentioned, I'm a noob at React so this has been a great learning experience for me! Cheers!

Hey Chuck! would you mind re-creating this pull request against branch v1.1 instead of master? This way I could integrate your changes without losing you as a contributor.
Thanks!


Fixes path issue in php grammar file

Based on how file import happens here, grammar.py was checking for php_generated.txt in the root of the project, rather than in the php directory.

You are right, but looking at the code you linked, I'm thinking that perhaps a more natural fix would be to change the behavior of _include_from_file and use self._definitions_dir rather than os.path.dirname(os.path.abspath(__file__)). WDYT?

That makes sense. I'll do a quick look over the other grammars, and make sure that change doesn't cause them to break.

That should work. I've tested it on all the provided examples (canvas, jscript, php etc), and it seems to work properly. The only exception is mathml, which seems to have a non-standard build compared to the others.

Cool, thanks!


docs: adding context to timeuuid using v1 feature

Motivation
I decided to give more context for newcomers that want to try Timeuuid in the Rust Driver. Since I didn't had that much experience in the beginning and struggled for a while until understand how to use it.
Also I still didn't understand when and how I should generate the the node_id on uuid::new_v1([]) parameters and IMHO it would be a great addition to the docs.
Fixes

[x] Add context to uuid::v1 usage
[ ] (Optional) Add context to new_v1() node_id numbers

Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[x] I have provided docstrings for the public items that I want to introduce.
[x] I have adjusted the documentation in ./docs/source/.
[x] I added appropriate Fixes: annotations to PR description.

Unfortunately, the error message from CI tells me nothing. As it's Sphinx task-related, it's @dgarcia360 who should have a clue about that.

Also I still didn't understand when and how I should generate the the node_id on uuid::new_v1([]) parameters and IMHO it would be a great addition to the docs.

My impression (I'm not an expert in CQL, though) is that it is only ScyllaDB itself that should generate Timeuuid values, and the driver side should have no interest in creating their own ones; the driver should probably only use Timeuuid as opaque identifiers.
@nyh Am I right?

@annastuchlik Can you drop a review on it? Just in case I missed something :p

Ready to merge!


Can you describe it like that instead?

Since there is only one "modifier", should I just say revert?
I'm not 100% sure how you wanna write it but I'll push up something.

Also I'm maintaining the module conventional-changelog used by you guys.
what do you expect conventional-changelog to do to this? I would simply parse it as a type so it will look the same as other types.
## Bug Fixes
...

## Reverts
...

Well at the moment, we are not actually using your package, Instead we use an script inside the angular.js project, changelog.js. And in this script you can see that we ignore all commits that do not start with fix, feat, perf or contain the word BREAKING. See https://github.com/angular/angular.js/blob/master/changelog.js#L194
The general idea, though, as far I am concerned, is that reverted commits should be removed from the changelog. So assuming that the original commit is also in the current release then we should simply ignore both commits. If it is reverting from a previous release, then I agree that we should have some kind of ## Reverts section.

Yup, that script is actually the very first version of conventional-changelog. You guys should definitely use the package once I release v0.1.x. It's much better :)
I agree with you. So far it's not smart enough to remove both commits within one release. Thanks for the feedback @petebacondarwin
Let me know what you think of the docs.

One thing I found about the commit message guide is that it's actually not very strict:

It doesn't say what's optional what's not.
The exact format of a part.
For example, it doesn't say how Breaking Changes should be written. The sentense should start with Breaking Change:  and there are optional two newlines between Breaking Change:  and the content of it.

This applies to the google doc you link to in the file. It gives more examples but still not very strict.

I added two commits just to support my points (Maybe they should be in different PR but they kinda related and I need your opinions). Let me know what you think. Thanks.

ping @petebacondarwin

Fun fact: According to the validate-commit-msg.js file, revert is considered a valid type since Nov 2012 (and there are tests that verify it - which probably no one runs :smiley:).

hm... lol. conventional-changelog treats revert as a type too (if it reverts a commit that's not in the current release) and it works well. There is no need to make an exceptional rule for it.
for validate-commit-msg.js I think it should verify the reverted commit actually exists.

LGTM!

Thanks @petebacondarwin , @gkalpak anything you would like to add here?

Would be great if you guys could update the docs on google docs
https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
Or, even better, create a git repo just for the conventions?

Thanks @petebacondarwin

@stevemao I have also updated the google doc.

Nice, will check it out


stfpm model

hello，I would like to ask why my model is STFPM and MAX_EPOCH  chooses 100, but the epoch will be random during training, sometimes ending in 13 epoch and sometimes 16 epoch？

Thank you very much for your help


Install Angular CLI by default if project type is angular.

It can be a great feature if someone testing the code of some other repo and want to install angular cli just because the project is based on Angular CLI. This mundane task can be done by devcontainer itself at the time of container build.
For example if script find that project have angular.json this means they have used angular in the project. The version of angular can be find from package.json, container can install the cli of same version and it will save a lot of time for people who just run the code of other to check the project.

Relates to: <Codespaces | Remote - Containers | Both>

Thanks for opening. Did you have specific container definitions in mind to update?

A new container can be created with a definition based on the NodeJS definition. It can have commented code for MongoDB (if the project depends on Mongodb it can be avail by just uncommenting the code)
Earlier I was using a dev container definition that I create myself. I was using Nodejs definition with postCreateCommand.


GH-34056: [C++] Add Utility function to simplify converting any row-based structure into an arrow::RecordBatchReader or  an arrow::Table

Are these changes tested?
The following tests are provided:

basic usage
const ranges
custom struct accessor
usage with std::variant

Closes: #34056

@wjones127 If you could take a look, thanks.

Just two minor changes, then I think this is ready to go.

Committed the last 2 suggested changes, let me know if there is anything else you would like to see updated @wjones127

@gringasalpastor There seems to be one CI failure that is legitimate. Could you address that?
/arrow/cpp/src/arrow/util/rows_to_batches.h:107: error: The following parameters of arrow::util::RowsToBatches(const std::shared_ptr< Schema > &schema, const Range &rows, DataPointConvertor &&data_point_convertor, RowAccessor &&row_accessor=detail::MakeDefaultRowAccessor(), MemoryPool *pool=default_memory_pool(), const std::size_t batch_size=1024) are not documented:
  parameter 'pool'
  parameter 'batch_size' (warning treated as error, aborting now)
1

@gringasalpastor There seems to be one CI failure that is legitimate. Could you address that?
/arrow/cpp/src/arrow/util/rows_to_batches.h:107: error: The following parameters of arrow::util::RowsToBatches(const std::shared_ptr< Schema > &schema, const Range &rows, DataPointConvertor &&data_point_convertor, RowAccessor &&row_accessor=detail::MakeDefaultRowAccessor(), MemoryPool *pool=default_memory_pool(), const std::size_t batch_size=1024) are not documented:
  parameter 'pool'
  parameter 'batch_size' (warning treated as error, aborting now)
1

@wjones127 Thanks, I just pushed a new commit to add documentation for these.


Peak detection comparison to PhysIO

PhysIO Toolbox is a MATLAB toolbox for physiological data preprocessing for fMRI. In the manuscript, they refer to a two-stage automated peak detection algorithm. I noticed that the peak detection algorithm in peakdet (see below) has two stages as well. I'm just curious, is the method the same? Has anyone done a head-to-head comparison?
Tagging @rmarkello.
https://github.com/physiopy/peakdet/blob/b1166910c9ec7a2ff80a3aeaba3404c5291742be/peakdet/operations.py#L125-L136

The methods are not the same. We were originally basing peakdet off of PhysIO, but then scipy integrated their own algorithm and I just went with that because 🤷♂
We do (I believe) do a two-pass peak detection to try and get a better bound on the distance between peaks but we don't use the same procedure for the actual peak detection (i.e., the template matching).
That said, template matching is very good and I'd strongly encourage someone who has the time + energy to integrate it do so!

Not from experience, no. I do remember a paper showing  that template matching is great and can yield impressive temporal resolution boosts even when data are undersampled (trying to find that reference now).
I would argue that the template matching + manual peak removal/QC aren't mutually exclusive. Even if you have what you believe to be a top-of-the-line algorithm the manual QC is still important cause even one or two missed (or extra) beats can really mess with your derived metrics.

That helps, thank you. I started looking into this mainly because there are open issues about incorporating physio info (specifically using PhysIO) into fMRIPrep. Given the need for manual QC, even with the best algorithms, that doesn't seem like a good idea. At least not without the ability to integrate other derivatives (which could include manual QC) the way they do Freesurfer.

On the peakdet side, I think we will want to do a head-to-head comparison with other physio tools as part of validating the toolbox at some point. Then again, we've also had plans to do that for tedana for a while now, and no one's actually gotten around to it...

I mean, the manual QC bit is gonna vary based on who you ask. If you ask a neurophysiologist type, of course they're gonna tell you that you need manual QC; if you ask a  the answer will probably differ. I can't think of terribly many neuroimaging studies that report manual correction of physio data even when they include e.g., heart rate and respiratory regressors (though I know, for example, Jonathan Power has always made a point in his studies to highlight that this is a necessary processing step).
That said, I do think including physio is super important in fMRI preprocessing (for obvious reasons), so even if you can't integrate the manual QC immediately I'd rather see physio included than not 🤷♂
Re validating the toolbox: my goal with peakdet was never to provide "better" algorithms but to come up with a solution where manual QC + intervention could be transparently + reproducibly (via peakdet.Physio.history) integrated into a physio processing workflow. I'd be happy to see it evolve beyond that (again, I've ceded all decision-making power here 😅), but I think that retaining the reproducibility of the manual QC is important.

That makes sense. I'd generally agree that supporting physio in standard workflows is more important than having perfect physio data. On the other hand, at least for some approaches (e.g., computing RVT, convolving with RRF, and then regressing it out in the first level GLM), physio can safely be applied after fMRIPrep's minimal preprocessing. If that's the case for all physio denoising approaches, then I'd lean toward leaving it out of fMRIPrep and simply making sure that users are aware of tools that can handle that step (e.g., the physiopy suite).
But then, even though fMRIPrep devs are concerned about feature creep, they do include a lot of confounds that could easily be calculated after minimal preprocessing (e.g., FD, AROMA components), so I don't know what their preference will be.


Add installer for TastyIgniter extensions and themes

@niksamokhvalov here's the new PR :)

@niksamokhvalov here's the new PR :)


Fix OnIntent with ActionScope_Goto_OnIntent test

Change to the base implementation.

Pull Request Test Coverage Report for Build 96954

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 78.426%

Totals

Change from base Build 96804:
0.4%

Covered Lines:
13276

Relevant Lines:
16928

💛  - Coveralls


dependsOn in array is not working properly with resolver

Hi,
I've created a Form with couple of array's. One of them has three dropdown where the second depends on the first and the third on the second.
I've created a resolver for this to get the right values for the dropdowns from a existing hierarchical object with three dimensions.
This is working like expected so far.
But the datastore is not updated like it should.
After I added the first item in the array, all three values are present in the datastore if I check them with getData(). Then with adding the next item, the issue starts. After adding the item to the array the previous entry in the datastore has no property two and three anymore, booth are deleted by adding the next item to the array.
First item added:
{   "gender": "Female",   "services": [     {       "category": "Beauty & Wellness",       "service": "Beauty Salon",       "specialization": "Nail Salon"     }   ] }
Next Item added
{   "gender": "Female",   "services": [     {       "category": "Beauty & Wellness"     },     {       "category": "Beauty & Wellness",       "service": "Hairdresser"     }   ] }
And this repeats on every adding. Only the last added item has the properties two and three the previous one are losing the properties.
Here is my resolver:
`        const resolver = function(names, data, cb) {
let schemas = [];
let schema = [];
        let i = data.services.length - 1;
        let category = data.services[i].category;
        let serviceDef = false;
        if (names[0] === '$.services[#].specialization' && data.services[i].hasOwnProperty('service')) {
            serviceDef = data.services[i].service;
        }

        let serviceObj = [];

        if (names[0] === '$.services[#].service' && services[category]) {
            schema.type = "string";
            Object.keys(services[category]["services"]).forEach(function(key, value) {
                serviceObj.push(key);
            },services[category]["services"]);
        } else if (serviceDef && services[category]['services'][serviceDef]) {
            schema.type = "string";
            services[category]['services'][serviceDef]["specializations"].forEach(function(key, value) {
                serviceObj.push(key);
            });
        }
        if (serviceObj.length === 0) schema.type = null;
        schema.enum = serviceObj;
        schemas[names[0]] = schema;
        setTimeout(function(){cb(schemas)},500);
    };

`
This resolver handles booth dropdown dependencies. I tried already to use the selector '$.services[$].service' instead of '$.services[#].service', so I thought this will just catch the last element in the array, but with this the dependencies are not builded correctly anymore.
I hope I can manage to set up a jsfiddle environment with the whole setting, so it will be easier to check it. Maybe it's also a problem in my resolver, maybe I set a wrong schema here?
Any help will be appreciated.
cheers

Ok, I had a deeper look into the topic. Seems that this will not work at all at the moment. As there is no information about the added array Elements in the schemaMap, there is no possibility to address the certain array element. Which results in the issue that for cleanData the id of the array is given and therefore all array elements are cleaned up on dependencyChange and not only the actual chosen one. The only solution I see here, to fix this, is to integrate array Elements in the schemaMap and add the id in the input.

I'm in the same boat here...

I altered onDependencyChanged to add the source variable to the shemaresolver output, but it's pretty useless.  the source element ID doesn't reflect the heirarchy of the data attributes.

This is a real PITA.  I had an idea about using the source variable I passed to the resolver to find a parent element with the class "item-index" which would give me i+1 on the data - but that's apparently unselectable.  I can't get parentNode from the element, it's like the element isn't part of the DOM.

OK, I have a solution but it requires some modifications to the BrutusinForms class.

The ID assigned to input elements is not valid HTML - it contains a "#" which prevents any DOM traversal.  As soon as I replaced "#" with "_" everything started falling into place.  This change is made about 12 lines into the BrutusinForms.create function.

var formId = "BrutusinForms_" + BrutusinForms.instances.length;
The only other change is to add the source variable to the resolver output as I mentioned above.
In onDependencyChanged, change the resolver function to look like this:
obj.schemaResolver(arr, obj.getData(), cb, source);
Now you're prepared to find your item id
In your resolver, here's how you get your item index:
var idelement = $(source).parents('tr.item').children('td.item-index');
var textvalue = $(idelement).text();
var id = parseInt(textvalue)-1;
Now you can data.fieldname[id].subfield

https://github.com/brutusin/json-forms/blob/master/README.md#status