rank 0 GPU OOM while  multi-machine training with DDP

not sure this issue is usual.
when multi-machine training with two 8-gpus(Nvidia 3090), the rank 0 (the first one in master machine) process will be killed by system after several hours. I have monitored the memory using of each gpu. the rank 0 require a lot of system memory approach the break point. refer as follows:
2022-03-23 23:57:28,855 DEBUG TRAIN Batch 0/185100 loss 4.577072 loss_att 4.222489 loss_ctc 5.404430 lr 0.00065741 rank 0 RSS MEM USE: 5.11G
2022-03-23 23:57:43,632 DEBUG TRAIN Batch 0/185200 loss 5.362794 loss_att 4.925412 loss_ctc 6.383353 lr 0.00065721 rank 0 RSS MEM USE: 5.11G
2022-03-23 23:57:57,979 DEBUG TRAIN Batch 0/185300 loss 7.436929 loss_att 6.969763 loss_ctc 8.526984 lr 0.00065704 rank 0 RSS MEM USE: 5.11G
2022-03-23 23:58:12,914 DEBUG TRAIN Batch 0/185400 loss 9.745964 loss_att 7.788527 loss_ctc 14.313314 lr 0.00065687 rank 0 RSS MEM USE: 46.51G
2022-03-23 23:58:27,353 DEBUG TRAIN Batch 0/185500 loss 7.055099 loss_att 5.558590 loss_ctc 10.546951 lr 0.00065670 rank 0 RSS MEM USE: 105.61G
2022-03-23 23:58:41,824 DEBUG TRAIN Batch 0/185600 loss 21.082787 loss_att 17.530172 loss_ctc 29.372223 lr 0.00065650 rank 0 RSS MEM USE: 161.09G
2022-03-23 23:58:56,216 DEBUG TRAIN Batch 0/185700 loss 4.324765 loss_att 3.620107 loss_ctc 5.968966 lr 0.00065633 rank 0 RSS MEM USE: 212.04G
2022-03-23 23:59:11,208 DEBUG TRAIN Batch 0/185800 loss 5.875733 loss_att 5.488202 loss_ctc 6.779974 lr 0.00065616 rank 0 RSS MEM USE: 268.65G
2022-03-23 23:59:25,299 DEBUG TRAIN Batch 0/185900 loss 7.695665 loss_att 6.738754 loss_ctc 9.928459 lr 0.00065600 rank 0 RSS MEM USE: 314.05G
2022-03-23 23:59:40,244 DEBUG TRAIN Batch 0/186000 loss 9.930955 loss_att 8.650377 loss_ctc 12.918968 lr 0.00065580 rank 0 RSS MEM USE: 368.19G
2022-03-23 23:59:53,885 DEBUG TRAIN Batch 0/186100 loss 9.757288 loss_att 8.881466 loss_ctc 11.800873 lr 0.00065563 rank 0 RSS MEM USE: 412.03G
2022-03-24 00:00:07,981 DEBUG TRAIN Batch 0/186200 loss 10.991848 loss_att 8.944845 loss_ctc 15.768186 lr 0.00065546 rank 0 RSS MEM USE: 462.48G
2022-03-24 00:00:21,908 DEBUG TRAIN Batch 0/186300 loss 5.258793 loss_att 4.664874 loss_ctc 6.644607 lr 0.00065529 rank 0 RSS MEM USE: 508.47G
2022-03-24 00:00:37,008 DEBUG TRAIN Batch 0/186400 loss 6.789611 loss_att 6.216270 loss_ctc 8.127404 lr 0.00065509 rank 0 RSS MEM USE: 560.11G
2022-03-24 00:00:51,764 DEBUG TRAIN Batch 0/186500 loss 7.544255 loss_att 6.040744 loss_ctc 11.052447 lr 0.00065493 rank 0 RSS MEM USE: 616.43G
2022-03-24 00:01:07,753 DEBUG TRAIN Batch 0/186600 loss 7.861217 loss_att 6.178774 loss_ctc 11.786919 lr 0.00065476 rank 0 RSS MEM USE: 672.18G
2022-03-24 00:01:48,785 DEBUG TRAIN Batch 0/186700 loss 10.188281 loss_att 8.669827 loss_ctc 13.731339 lr 0.00065459 rank 0 RSS MEM USE: 707.11G

some key infos:
dist_backend="nccl"
init_method="tcp://ip:port"
pytorch version: 1.10
i have tried:

change the master machine
change the rank 0 GPU
reduce the worker_number

still same issue occur.  the batch number of break point is random and single machine train with same traing data is ok.

I think you can try:

make it works on single card
reduce the batch_size

I think you can try:

make it works on single card
reduce the batch_size

i train with same trainging data in single node, which is normal.   it didnot work to reduce the batch size and worker number.
Yesterday, i got following error after 14 epochs:
envs/wenet/lib/python3.8/multiprocessing/process.py:108: ResourceWarning: unclosed file <_io.BufferedReader name='xxxxxxx/shards_000000512.tar'>

it runs normally with a wenet-docker cluster.maybe there is something wrong related to hardward, which is hard to find out.
close the issue!


Why is azure cognitive search missing?

Azure Cognitive Search appears to be missing from all documentation here, why is that? Even a small section explaining why its missing would be helpful I think.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 471c94dc-0175-5575-0d82-484e9c8db0b4
Version Independent ID: f441d4c5-cd5c-0557-bdf0-e97c18cf5597
Content: Use Azure Cognitive Services Containers on-premises - Azure Cognitive Services
Content Source: articles/cognitive-services/cognitive-services-container-support.md
Service: cognitive-services
GitHub Login: @aahill
Microsoft Alias: aahi

@justinmchase
Thanks for your feedback! We will investigate and update as appropriate.

@justinmchase
Please see the below link for your reference. It's explained about Azure cognitive search details
https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/innovate/best-practices/cognitive-search

@RamanathanChinnappan-MSFT Sure, thank you for the link but I mean specifically why isn't it listed in the "Azure Cognitive Services containers"? Its a cognitive service and I need it in a container so I can run it locally for debugging purposes, just wondering where the documentation is on how to run it in a container.

@justinmchase
Thanks for your contribution. Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)

@justinmchase just to add some additional information here, "Cognitive search" is a separate product than "Cognitive services" (although the naming is similar) which is why we don't list it on this page. - I checked with the team and they currently do not provide a docker container, though I've forwarded this suggestion to them.

Ok, it used to be called Azure Search and was renamed to Azure Cognitive Search recently and it seems like a lot of these indexers are related so its been super confusing.


fix(attach): no crash at mappingKey with null and comment

? # 123
: # 123

TypeError: Cannot read property 'trailingNode' of undefined

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #55   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          26     26
  Lines         530    532    +2
  Branches      103    104    +1
=====================================
+ Hits          530    532    +2

Impacted Files
Coverage Δ

src/transforms/mapKey.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9de82d...eb99d98. Read the comment docs.


Encountered exception when adding a server to a group

SQL Operations Studio Version: 0.25.4

Steps to Reproduce:
Made several server groups for prod I right clicked the server group and clicked add new connection, the other ones I used the new connection button at the top.  When connecting to a database where I don't have full access (while connected to a database in another server group) I received the following exception stacktrace:
System.IndexOutOfRangeException: Index was outside the bounds of the array. at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior) at Microsoft.SqlTools.ServiceLayer.Connection.ConnectionService.d__37.MoveNext() in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Connection\ConnectionService.cs:line 309 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SqlTools.ServiceLayer.ObjectExplorer.ObjectExplorerService.d__37.MoveNext() in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\ObjectExplorer\ObjectExplorerService.cs:line 510

Closing since we don't have an internal repro.  Please reactive if you're still hitting this on current builds.  Thanks!


Server Blacklist

Changes Made

add test for list support in Document
add ServerSwitchConfigTest
implement ServerSwitchConfig in ProxyPluginConfig
create base class for SwitchServer
add check for black & white list server
supply serverSwitchConfig for listeners

Reason for Changes
Include a config entry that allows servers to be blacklisted so that if the party leader joins this server, the party is not pulled along.
It would make sense to support explicit server names, as well as the beginning of a server name. As an example, all servers whose names begin with "Lobby" are directly blacklisted.
Issues Resolved
Now possible to configurate in config Black and Whitelist for server swapping with enable option
Checklist

[ ] I have tested these changes locally
[X] (Optional) I have updated the tests accordingly
[X] My code follows the established code style guidelines
[X] I have added/updated necessary comments to my code

Issue: #7

Please also remember to test your update locally!

There is no need for test locally, as long as unit test pass.
I was already done.
Just added the missing test as the testing engine in gradle is here now. And I didn't want to add my own test build in gradle files before.

Please remember to resolve the conversations when you've made the changes, and if you have any complaints about any change I'm proposing, please post that in the appropriate conversation as well.

In the last push on the master branch, string lists for the configs were added. Please use this and please think about the pending change requests. :)

I am no longer working on the project


Override Registrations Controller -

I am trying to override Registrations so that i can have two seperate signup forms. I want to make use of two seperate login and register pages (one normal login/register and a seperate one for my checkout login/register). I am setting a session variable on the checkout/sign_in page.
Right now, if i try to sign in from my checkout/sign_in page and i have validation errors it pushes me back to the default devise sign_in page. Any help is appreciated
Routes
devise_for :users, path: 'account', controllers: { confirmations: 'confirmations', registrations: 'registrations'}
  devise_scope :user do
    patch "/confirm" => "confirmations#confirm"
  end

My override controller. Notice the else if resource does not persist.
class RegistrationsController < Devise::RegistrationsController

  def create
    build_resource(sign_up_params)

    resource.save
    yield resource if block_given?
    if resource.persisted?
      if resource.active_for_authentication?
        set_flash_message :notice, :signed_up if is_flashing_format?
        sign_up(resource_name, resource)
        respond_with resource, location: after_sign_up_path_for(resource)
      else
        set_flash_message :notice, :"signed_up_but_#{resource.inactive_message}" if is_flashing_format?
        expire_data_after_sign_in!
        respond_with resource, location: after_inactive_sign_up_path_for(resource)
      end
    else
      #IT SEEMS THIS DOES NOT WORK, EVEN IF I PASS IN THE PROPER LOGIN PATH PATH
      respond_with resource, location: after_sign_up_path_for(resource)
    end
  end

  private

    def after_sign_up_path_for(resource)
      session[:login_url] || root_url
    end

end

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.


is there a line limit for files to still be parsed for tasks?

I have a rather large md-file (over 1450 lines) and apparantly tasks added in there with a due date are not displayed in the task-calender-wrapper, but show up when filtered using tasks  and also in the time ruler. Might this be due to the size of the file?

actually, I just tried to split the note in half and having under 1000 lines  now leads to the tasks showing up again -> is it possible to still parse large files or maybe there's a maximum of tasks that can be in a file?

Hi @sarahwarchhold thanks for the report. There is not file size limit in this plugin because this plugin reads information from the obsidian cache and it starts loading after the obsidian cache resolved. I will do some digging and see why this issue would happen.

This is happening to me too.  I just did a test and it stopped working when the file size got to 65539 (2^16 + 3) bytes.
Tasks (plugin) and Dataview queries work fine.

It looks like obsidian-tasks-calendar-wrapper is being built with an older version of Obsidian-Tasks-Timeline.  The one that I see in main.js does not wait for the cachedRead Promise chain to complete.  My guess is that large files take longer to read because I saw (in the debugger) the promise for those being executed after the rendering is complete.
The current version of taskadapter.ts does await those promises but for whatever reason version 0.2.7 (I guess built last week) didn't pick it up even though await has been in taskadapter for over 6 months.  I don't know how builds for Obsidian plugins work but just made it work locally by editing generateTasksList in my local .js file (.obsidian/plugins/tasks-calendar-wrapper/main.js -- around line 36346) to look like this (it's just the two lines with "await").
  async generateTasksList(includeFilter, pathFilter, includeTags, excludeTags) {
    this.tasksList.length = 0;
    const files = app.vault.getMarkdownFiles();
    let filteredFiles = files;
    if (includeFilter.length !== 0)
      filteredFiles = filteredFiles.filter(this.includePathsFilter(includeFilter));
    if (pathFilter.length !== 0)
      filteredFiles = filteredFiles.filter(this.pathsFilter(pathFilter));
    if (includeTags.length !== 0)
      filteredFiles = filteredFiles.filter(this.fileIncludeTagsFilter(includeTags));
    if (excludeTags.length !== 0)
      filteredFiles = filteredFiles.filter(this.fileExcludeTagsFilter(excludeTags));
    await Promise.all(filteredFiles.map(async (file) => {
      const link = Link.file(file.path);
      await this.app.vault.cachedRead(file).then((content) => {
        var _a;
        const cache = this.app.metadataCache.getFileCache(file);
        (_a = cache == null ? void 0 : cache.listItems) == null ? void 0 : _a.forEach(
          this.fromItemCache(link, file.path, content, cache.sections, cache.links, cache.frontmatter, cache.tags)
        );
      }).catch((reason) => {
        console.error("Read file from obsidian cache failed: " + reason);
      });
    }));
  }

Hopefully the next build will include the more recent taskadapter.ts -- otherwise I'll just reapply this patch.

Hi @rodneychu , thanks for your report and the fix. Please do free to summit a pr, I am sorry that I am currently too busy with my graduation thesis and I might do not have enough time to dig the issue this month. I guess there are some mistakes in my last update to optimize the blocking issue.


Code cleanup

Code cleanup

Thanks, but as stated in the README, we're not accepting changes to the code which is being preserved as a historical record, warts & all.


Extend<Pair<&..>> and Pairs::cloned supports for Punctuated

This is designed to make it easy to extend a Punctuated from an iterator over another Punctuated:

Auto-insert extra punctuation if extend-target does not have trailing comma. This is a breaking change due to the extra Default bound, so I may need to remove it.
Support extension from reference types.
Support cloned over a Pairs iterator.

The last two are redundant with each other, from the POV of the motivation.

BTW I'm waiting on comment before looking at CI failures. Quite possibly the Default bound needs to be removed?

I picked up two of these changes in #1255 and #1256. Thanks!
The rest is too far into diminishing returns I think. For example .map(Pair::cloned) supersedes the need for a new ClonedPairs iterator type.


test if backend can handle empty arrays

it should never happen I dont think, but good to prevent it from crashing backend anyways


Silent exit when first used in a thread other than the main thread

On Windows 7 32-bit, Ruby 1.9.3-p545 (obtained from RubyInstaller.org).
Using the libxml-ruby gem version 2.7.0 for the x86-mingw32 platform (I installed the binaries, not compiled from source), obtained from rubygems.org.

The following program works fine:
require 'libxml'
z = LibXML::XML::Parser.string('<?xml version="1.0" encoding="UTF-8"?><root></root>').parse()
worker = Thread.new { LibXML::XML::Parser.string('<?xml version="1.0" encoding="UTF-8"?><root></root>').parse() }
worker.join
puts "Done successfully"

The following program prints nothing (it exits silently, no exception raised):
require 'libxml'
worker = Thread.new { LibXML::XML::Parser.string('<?xml version="1.0" encoding="UTF-8"?><root></root>').parse() }
worker.join
puts "Done successfully"

The difference is that in the second program, the first use of LibXML is on a thread other than the main thread, whereas in the first program, the first use of LibXML is on the main thread.
If the library must do some initialization on the main thread, this should be rolled into the code that gets executed when you run require. It should not be necessary to parse a trivial XML document on the main thread in order to be able to use it in a child thread.
Furthermore, this problem is particularly egregious, because it silently terminates the process, without giving the programmer any indication of what is wrong. Even a segmentation fault and the accompanying stack dump provides much more information than your process exiting without a peep. Nothing to stdout, nothing to stderr, no exceptions thrown in Ruby, no worrisome signals being emitted by the process to the calling shell, nothing. This can make the error extremely difficult to detect, necessitating a careful step through of all Ruby code to find this error. Please see if you can handle this error in some way other than calling exit().

This is fixed in bd529e995f0ccd29f10f6067760bc55f738065c2.

Also see #58.


Cranelift aarch64 backend: improve filetest situation by matching individual instructions

Right now, the vcode filetest matches the pretty-printed assembly with the filecheck directives. To test the new aarch64 backend, we've written a bunch of filetests that match against a golden compilation. This works for now, but is somewhat brittle: if regalloc heuristics change which registers are used, the tests need to be updated. In addition, it requires us to match the whole function body to ensure that nothing else was generated, when all we really want to do is to assert that a particular operation was implemented by only these N instructions. We should look into porting or building an equivalent of the old backend's "assert this instruction has this encoding" functionality, and its register constraints that make tests more robust.

Did you know about the regex match functionality of filetest?
https://github.com/bytecodealliance/wasmtime/blob/86ff6d7aef8017da4b77b9b8d69a71c4a2b443cb/cranelift/filetests/filetests/regalloc/coalesce.clif#L5
https://github.com/bytecodealliance/wasmtime/blob/86ff6d7aef8017da4b77b9b8d69a71c4a2b443cb/cranelift/filetests/filetests/regalloc/coalesce.clif#L40-L41

FWIW one technique which has worked out really well for the Rust project and others I've seen is to have exhaustive assertions about the output (like it seems you're describing is the current state today), but also having a way to auto-update the assertion. This means that at a glance you can always see the complete output of something (such as the full function in all its glory) but if you make a minor tweak to epilogue generation you can easily update the whole test suite. Reviewing is generally quite easy too because you're either looking at something entirely new in which case you can review it in detail, or you're reviewing changes to what was already there so you can easily spot things which may have accidentally changed but shouldn't have.
The way this typically works is there's some sort of opt-in "bless" option. With rust-lang/rust it's ./x.py test --bless but with some projects I've worked on it's just BLESS=1 cargo test. My workflow is generally to write a test and then always use BLESS=1, reviewing the output manually to make sure it looks ok.
I'd be happy to help prototype this if folks think it's a good idea.

This issue is going to be a major headache for any attempt to fix #1148 in the AArch64 backend.


datasets‘ problem

when I run the train_net.py on JHMDB datasets, it occurs error that: RuntimeError: Caught "[Errno 2] No such file or directory: 'data/jhmdb/videos/prelinger_LetsBeGo1953_pick_f_cm_np1_fr_med_8/00041.png'" when loading data/jhmdb/videos/prelinger_LetsBeGo1953_pick_f_cm_np1_fr_med_8/00041.png.
is it because the JHMDB dataset's frame directory have changed? how can I solve it? it is really important to me, wait for your reply!

Do you have the requested file at data/jhmdb/videos/prelinger_LetsBeGo1953_pick_f_cm_np1_fr_med_8/00041.png? Please make sure its there

Do you have the requested file at data/jhmdb/videos/prelinger_LetsBeGo1953_pick_f_cm_np1_fr_med_8/00041.png? Please make sure its there

thank u, I found it out, there is not 00041.png in the directory, only 40 images in this directory, but there are some other hidden files so it confused the program.

Do you have the requested file at data/jhmdb/videos/prelinger_LetsBeGo1953_pick_f_cm_np1_fr_med_8/00041.png? Please make sure its there

I have dealt with that, but I meet new problem in the end of the program. When it evaluation on jhmdb_val, it finished the inference successfully but occurs FileNotFoundError in the function testlist_to_dict, there is no ‘data/jhmdb/annotations/testlist.txt’. How can I fix that? Looking forward to your reply. Thank you.


Reset status when dataSource is updated

Is it possible to reset to the first 'slide' when dataSource has changed? I'm using dyanmic data (with tabs) and when I press the first tab that has 2 items and slide to the 2nd... Then I press the 2nd tab that has only 1 item you won't see anything because it is on the 2nd slide with only 1 item.

That would be great, when could this be implemented?


Enhance Aggregation Fuzzer to test abandon-partial-agg code path

The added coverage helped reproduce double-free bug in GroupingSet::toIntermediate.
See #6224

@bikramSingh91 Bikram, thank you for review. I'm landing the fix separately. It is included here because without the fuzzer dies.


Partial Soft Credit Role should be picklist to match OCR Role

npsp__Partial_Soft_Credit__c.npsp__Role_Name__c is of type Text(255).  However, both npsp__Account_Soft_Credit__c.npsp__Role__c and OpportunityContactRole.Role are configured as picklist data types.
The standard "New" button displays the Role as a free text field when on a Partial Soft Credit list view.  The User has the ability to enter any value in that field, and the value is then saved to npsp__Partial_Soft_Credit__c.npsp__Role_Name__c and also to the OpportunityContactRole.Role picklist as an inactive value.  This clutters the options and does not create good data consistency.
The URL "Manage Soft Credits" button, however only provides selectable values from the OpportunityContactRole.Role picklist.
It is also important to note that the NPSP Settings > Customizable code also reconciles to the OpportunityContactRole.Role picklist.
Current workaround: hide "New" button on Partial Soft Credits so the user is forced to use the "Manage Soft Credits" functionality.  And create a validation rule on the Partial Soft Credits object that disallows any value not configured in the OpportunityContactRole.Role picklist to prevent data imports from inserting non-configured values.  The latter not being a great because if a new value is added to the OpportunityContactRole.Role picklist, the validation rule must also be manually updated to accommodate the new value.

Steps to repeat:

Login as user
Create new Opportunity
From Opportunity, select Partial Soft Credits related list quick link
New
Add a Contact and enter a bogus Role
Save
View the Contact Roles related list quick link and see bogus Role
Confirm inactive OCR Role picklist value but navigating to Settings > Object Manager > Opportunity Contact Role > Role

@jenniferbodiford-bbbsa Thanks for reporting and the great idea and steps, however, this is a request for an enhancement and not a bug so please create an Idea for this on the IdeaExchange if one doesn't already exist. Thank you!


msbuild /pp output in section for PROCESSOR_ARCHITECTURE has incorrect comment

When I run msbuild /pp:out.txt I'm seeing the following section:
<!-- Msbuild runs as an x86 process.
If its running on a 64-bit machine, correctly set the PROCESS_ARCHITECTURE. -->
<PropertyGroup>
  <PROCESSOR_ARCHITECTURE Condition="'$(PROCESSOR_ARCHITECTURE)' == 'x86' and '$(PROCESSOR_ARCHITEW6432)' == 'AMD64'">AMD64</PROCESSOR_ARCHITECTURE>
</PropertyGroup>

Shouldn't it be

set the PROCESSOR_ARCHITECTURE

rather than current

set the PROCESS_ARCHITECTURE

?

Oh, I see. It comes from Environment.props which is a part of Microsoft internal MsBuild.Corext. Now I'm wondering how to report this issues to them. Do you know who are the owner of this package?

Replied offline since it's MSFT-internal. Thanks for the report!


Dan/2023/03/add a check registration step

Same as this PR (closed in favor of this one), but it also adds a check registration step.

Codecov Report

:exclamation: No coverage uploaded for pull request base (horsefacts/execution-check@7301317). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@                      Coverage Diff                       @@
##             horsefacts/execution-check     #1064   +/-   ##
==============================================================
  Coverage                              ?   100.00%
==============================================================
  Files                                 ?        46
  Lines                                 ?      2414
  Branches                              ?       354
==============================================================
  Hits                                  ?      2414
  Misses                                ?         0
  Partials                              ?         0

Flag
Coverage Δ

production
100.00% <0.00%> (?)

reference
100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Parser Failing on Large Messages.

watchseries-go-logs-1677001203954.txt Logs.
Unmarshalling Fails on Long Messages :(

{"message": {"id": "d4cb6686-6ef7-46da-87d7-df16abbec928", "role": "assistant", "user": null, "create_time": null, "update_time": null, "content": {"content_type": "text", "parts": ["The term "911" is commonly associated with the emergency"]}, "end_turn": null, "weight": 1.0, "metadata": {"message_type": "next", "model_slug": "text-davinci-002-render-sha"}, "recipient": "all"}, "conversation_id": "45e1a523-c85a-4d11-96c5-b91e38f0ee83", "error": null}
The double quotes of the "911" string need to be translated, and are missing now, as caused by the following line of code
···
line = strings. ReplaceAll(line, \", ")
···


[BUG] Loupe in search bar should be a button

Describe the bug
Loupe icon should be a button and should do the same as enter key.

It's storefront-ui issue. reported as a feature loupe feature


[Expression] Add resolve function for resolving TimexProperty values to string values

fixes: #4425
timex.resolve can resolve the timex values to string values.
for example:
timex.resolve('2012-12-30T14') -> "2012-12-30 14:00:00"
timex.resolve('T14') -> "14:00:00"
timex.resolve('2012-12-30') -> "2012-12-30"
for the senario in the reported issue.
#ResolveDateTime
- ${formatDateTime(concat(timex.resolve("2009-01-23"), "T", timex.resolve("T14")))}

it will return "2009-01-23T14:00:00:00.000Z"
Also in this PR, all timex prebuilt functions now have a prefix "timex".
for example:
"timex.isDefinite";
"timex.isTime";
"timex.isDuration";
"timex.isDate";
"timex.isTimeRange";
"timex.isDateRange";
"timex.isPresent";
"timex.getNextViableDate";
"timex.getPreviousViableDate";
"timex.getNextViableTime";
"timex.getPreviousViableTime";
"timex.resolve";

we should backward support the notion without prefix like "getNextViableTime", for at least one release i guess.

@EricDahlvang - Could you please review this PR as it is a customer reported issue.

@chrimc62 My level of familiarity with this library is minimal.  Does this look good to you?

@chrimc62
Hi Chris, I removed the prefix of all timex functions. Could you take a look? Thanks a lot.


Test result sent to beforeInvocation() of skipped test differs from what onTestSkipped() receives

TestNG Version

6.14.3
Behaves as expected with TestNG 6.10

Expected behavior
For skipped test, the same test result object should be sent to beforeInvocation() and onTestSkipped()
Actual behavior
For skipped test, beforeInvocation() and onTestSkipped() receive differing test results.
(Point of fact, it appears that beforeInvocation() receives a semi-initialized "dummy" result.)
Is the issue reproductible on runner?

[ ] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[ ] Eclipse
[ ] IntelliJ
[ ] NetBeans

Test case sample
package org.example;

import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;

import java.io.File;
import java.lang.reflect.Method;
import org.testng.IInvokedMethod;
import org.testng.IInvokedMethodListener;
import org.testng.ITestContext;
import org.testng.ITestNGListener;
import org.testng.ITestResult;
import org.testng.SkipException;
import org.testng.TestNG;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
import org.testng.internal.IResultListener;
import org.testng.xml.XmlSuite;

public class Issue1602ReproTest {
    @Test
    public void reproduceIssue() {
        TestNG testNG = new TestNG();
        testNG.setTestClasses(new Class[]{ExampleClass.class});
        testNG.setConfigFailurePolicy(XmlSuite.FailurePolicy.CONTINUE);
        MethodListener methodListener = new MethodListener();
        ResultListener resultListener = new ResultListener();
        testNG.addListener((ITestNGListener) methodListener);
        testNG.addListener((ITestNGListener) resultListener);
        testNG.run();
        String file = TestNG.class.getProtectionDomain().getCodeSource().getLocation().getFile();
        System.out.println("TestNG v" + new File(file).getParentFile().getName());
        assertEquals(methodListener.skippedTest, resultListener.skippedTest);
    }

    static class ExampleClass {

        @BeforeMethod
        public void beforeMethod(Method method) {
            if ("test1".equals(method.getName())) {
                System.out.println("beforeSkipped");
                throw new SkipException("beforeSkipped");
            }
        }

        @Test
        public void test1() {
            assertTrue(true);
        }

        @Test
        public void test2() {
            assertTrue(true);
        }
    }

    static class MethodListener implements IInvokedMethodListener {
        ITestResult skippedTest = null;

        @Override
        public void beforeInvocation(IInvokedMethod method, ITestResult testResult) {
            if ("test1".equals(method.getTestMethod().getConstructorOrMethod().getName())) {
            	skippedTest = testResult;
            }
        }

        @Override public void afterInvocation(IInvokedMethod method, ITestResult testResult) { }
    }

    static class ResultListener implements IResultListener {

    	ITestResult skippedTest = null;

		@Override
		public void onTestSkipped(ITestResult arg0) {
			skippedTest = arg0;
		}

		@Override public void onFinish(ITestContext arg0) { }
		@Override public void onStart(ITestContext arg0) { }
		@Override public void onTestFailedButWithinSuccessPercentage(ITestResult arg0) { }
		@Override public void onTestFailure(ITestResult arg0) { }
		@Override public void onTestStart(ITestResult arg0) { }
		@Override public void onTestSuccess(ITestResult arg0) { }
		@Override public void onConfigurationFailure(ITestResult arg0) { }
		@Override public void onConfigurationSkip(ITestResult arg0) { }
		@Override public void onConfigurationSuccess(ITestResult arg0) { }
    }
}

@sbabcoc - Can you please check if the problem exists in TestNG 7.0.0-SNAPSHOT as well ?

Appears to work as expected in TestNG 7.0.0-SNAPSHOT

In that case, can we close this issue off ? You would need to wait for TestNG 7.0.0 to be released.

And oh btw, friendly advice.. dont rely on the apis under org.testng.internal package. They are meant to be internal TestNG APIs and will change without any warnings or any deprecation strategies because they were never meant to be consumed by anyone else apart from TestNG.

I get the same broken behavior with ITestListener. I was merely using this "internal" interface because it also extends IConfigurationListener. This wasn't necessary here, but was an artifact of the origin of the repro code.

Scott
Am a bit confused now. So are you saying the problem goes away in the 7.0
series or are you saying the problem exists ?
Can you please also help update the same to use the public interfaces that
TestNG provides as listener interfaces ?
Thanks & Regards
Krishnan Mahadevan
"All the desirable things in life are either illegal, expensive, fattening
or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

How long until 7.0.0 is released? This version has issues with tests that are skipped or fail in @BeforeMethod methods. Version 6.14.3 fails in the same scenarios, but with somewhat different behavior.

Sorry for lack of clarity... I get the same broken behavior in 6.14.3 if I implement the "public" ITestListener interface instead of the "internal" IResultListener interface. This is unsurprising, since IResultListener extends ITestListener.

It's gonna take sometime before 7.0 comes out because we are still
iterating over bugs refactoring code etc.
So if this issue is resolved by using TestNG 7.0 let's close it. For any
other issues with TestNG listeners you maybe experiencing let's open up
distinct issues. That way it's easy to focus and fix them one at a time.
--
Thanks & Regards
Krishnan Mahadevan
"All the desirable things in life are either illegal, expensive, fattening
or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/
My Technical Scribbings @ http://rationaleemotions.wordpress.com/

If no further fixes will be offered for the 6.x releases, I'll just stick with 6.10. No point in opening issue reports if no new 6.x releases will address them. I can open an issue report for the 7.0.0 behavior.

We don't plan a new 6.x release unless someone wants to support it and backports fixes from the 7.x branch ;)

@sbabcoc - The example you shared in this issue, runs fine without any failures when tried on the latest snapshot of TestNG (7.0.0-SNAPSHOT). So I am closing this issue. If there are any other issues with listeners, please file new issues for them.


keepassxc.org

Hi, I've opened #17 because keepassxc.org is the offical website of KeePassXC.
It's quite a popular fork of the standard KeePass.

Hello anyone here?
I was just made aware that keepassxc.org is on this list. I am a maintainer of the project and can say with confidence that keepassxc.org is indeed our official website. The same is true for keepassxc.info and keepassxc.net. keepassxc.com, on the other hand, is indeed a fake domain and belongs on the list.

Ping @rfdevere.


WIP: Notebook Edit Support

Notebook Edit Support

Running into some layering issues
Reading git index versions...
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/api/common/extHostCodeMapper.ts: line 14, col 29, Warning - Bad layering. You are not allowed to access browser from here, allowed layers are: [common] (local/code-layering)
/Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/api/common/extHostCodeMapper.ts: line 14, col 29, Warning - Imports violates 'vscode or vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/api/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminalContrib/*/common/** or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

2 problems
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingService.ts: line 27, col 43, Warning - Imports violates 'vs/base/{common,browser}/** or vs/base/parts/*/{common,browser}/** or vs/platform/*/{common,browser}/** or vs/editor/{common,browser}/** or vs/editor/contrib/*/{common,browser}/** or vs/workbench/{common,browser}/** or vs/workbench/services/*/{common,browser}/** or vs/workbench/contrib/*/{common,browser}/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or @xterm/xterm or @xterm/addon-* or vscode-textmate or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatEditingService.ts: line 18, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatModel.ts: line 22, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem
[17:32:22] /Users/donjayamanne/Development/vsc/vscode/src/vs/workbench/contrib/chat/common/chatService.ts: line 17, col 43, Warning - Imports violates 'vs/base/common/** or vs/base/parts/*/common/** or vs/platform/*/common/** or vs/editor/common/** or vs/editor/contrib/*/common/** or vs/workbench/common/** or vs/workbench/services/*/common/** or vs/workbench/contrib/*/common/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

1 problem


Swagger UI example request not being properly executed if mounted at /some/path

If, for example, you mount itty-router-openapi as a child endpoint inside a hono application, for e.g:
import { OpenAPIRouter } from '@cloudflare/itty-router-openapi'
import { Hono } from 'hono'
// import exampleFetch etc

const router = OpenAPIRouter({
  docs_url: "/doc",
})
router.get('/example', ExampleFetch)

const app = new Hono()
app.mount('/api', router.handle)

Request to the /api/example would succeed, but running the examples from the swagger ui mounted at /api/doc would result in misrouted errors.
Adding api as basepath to the OpenAPIRouter would only trail the error.
A solution could be to add a execution_basePath property like
const router = OpenAPIRouter({
  docs: {url: "/doc", execution_basePath: "/api"}
})

Ofc this can be worked around by mounting on / and adding the /api as a basepath in the itty router, but not as ideomatic

This happens due to an implementation detail on Honojs (docs here), basically they "manipulate" the request url before calling the inner mounted router, for the inner router to think they are at the root of the request.
TLDR: /api/docs renders correctly, but points to a non-existing /openapi.json schema that is actually located at /api/openapi.json
I will think in a way to fix this issue, but currently the workaround is to disable the docs_url option, and to build your own docs page pointing to the correct path, then telling openapi that all routes should be prefixed with the base url.
Here's a working example:
import { OpenAPIRouter, getSwaggerUI } from '@cloudflare/itty-router-openapi'
import { Hono } from 'hono'

const router = OpenAPIRouter({
  docs_url: null,
  schema: {
    servers: [{
      url: '/api',
    }],
  },
})
router.get('/test', (request) => new Response(request.url))

router.original.get('/docs', () => {
  return new Response(
    getSwaggerUI('/api/openapi.json'),
    {
      headers: {
        'content-type': 'text/html; charset=UTF-8',
      },
      status: 200,
    },
  )
})

const app = new Hono()
app.mount('/api', router.handle)

export default app

Just as additional info. It's possible to set basepath to /api and hono.mount('/', router.handle
Everything would work fine, but it's not very ideomatic and every request would pass through the openAPIrouter first

Hello @carafelix in the latest version of Hono this issue is solved, all you need to do is set the base parameter in itty-router-openapi and pass this function when mounting the router in Hono:
app.mount('/api', router.handle, {
  replaceRequest: (req) => req,
})

Here is a full working example running in Hono v4.4.3
import { OpenAPIRoute, OpenAPIRouter } from '@cloudflare/itty-router-openapi'
import { Hono } from 'hono'

export class ToDoCreate extends OpenAPIRoute {
  static schema = {
    tags: ['ToDo'],
    summary: 'Create a ToDo',
  }

  async handle(
    request: Request,
    env: any,
    context: any,
    data: any,
  ) {
    return Response.json({ success: true })
  }
}

const router = OpenAPIRouter({
  base: '/api',
})
router.get('/example', ToDoCreate)

const app = new Hono()
app.mount('/api', router.handle, {
  replaceRequest: (req) => req,
})

export default app

Then openning the browser at http://localhost:8787/api/docs shows the correct swagger ui

Wow that was fast! Thank you very much.
I have noticed other things in the router. like not supporting Authorization headers and such. Should I open an issue?
I think on taking a look at the inner workings of the router in the near future, so I could help with development

I'm already working on a very big revamp for this library, that will make it "router" agnostic.
This is a big push to make this work natively on Hono
You can see a preview of the changes on this pull request #151
I already have much better type inference working, and a lot more improvements done

I'm planning on releasing this new revamp version in the next weeks, so after that i'm happy to review and discuss additional changes 😄


error: could not register hotkey

win xp
error: could not register hotkey
Newly installed system

that means there is already a program running that uses the same hotkeys


rake default should not depend on host system config

I had some invalid config lying around in my old system in ~/.rubocop.yml. Running bundle exec rake default in rubocop project (before contributing a fix) fails.

Expected behavior
rake default should use its own config rather than depending on host system config. Disabled cops in host system can lead to inconsistent checks in local and CI.
Actual behavior
Rake task fails complaining about invalid config file in home directory.
$ bundle exec rake default
....<log from other checks skipped>
Running RuboCop...
Error: The `Layout/IndentHash` cop has been renamed to `Layout/IndentFirstHashElement`.
(obsolete configuration found in /Users/tejas.bubane/.rubocop.yml, please update it)
RuboCop failed!

Steps to reproduce the problem
Create ~/.rubocop.yml with following content:
Layout/IndentHash:
  Enabled: false

Run bundle exec rake default in rubocop project directory.
RuboCop version
$ [bundle exec] rubocop -V
0.68.1 (using Parser <IP_ADDRESS>, running on ruby 2.6.3 x86_64-darwin18)

Hello there
I am trying to get this resolved, but in the Rakefile there is nothing mentioned about using the default.yml file config if the argument is default, is that the required behavior? and can I do this if I got that right ?

I've had created a duplicated issue: https://github.com/rubocop-hq/rubocop/issues/7132
So I'm closing the other issue to keep this in one place.
Just to add, this doesn't only happen on rubocop project, but on any project.
Here's the issue's content:

My ~/.rubocop.yml requires rubocop-rails. However, when I tried to run bundle exec rake default (essentially rubocop) in rubocop git repo's root, I received the following error:
$ bundle exec rake default
Running RuboCop...
cannot load such file -- rubocop-rails
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader_resolver.rb:15:in `require'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader_resolver.rb:15:in `block in resolve_requires'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader_resolver.rb:11:in `each'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader_resolver.rb:11:in `resolve_requires'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader.rb:45:in `load_file'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader.rb:107:in `add_excludes_from_files'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_loader.rb:92:in `configuration_from_file'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/config_store.rb:44:in `for'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/cli.rb:180:in `validate_options_vs_config'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/cli.rb:48:in `run'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/rake_task.rb:44:in `run_cli'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/rake_task.rb:28:in `block (2 levels) in initialize'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/file_utils_ext.rb:59:in `verbose'
/Users/viktor/Developer/gems/rubocop/lib/rubocop/rake_task.rb:26:in `block in initialize'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:273:in `block in execute'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:273:in `each'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:273:in `execute'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:214:in `block in invoke_with_call_chain'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:194:in `invoke_with_call_chain'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:238:in `block in invoke_prerequisites'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:236:in `each'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:236:in `invoke_prerequisites'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:213:in `block in invoke_with_call_chain'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:194:in `invoke_with_call_chain'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/task.rb:183:in `invoke'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:160:in `invoke_task'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:116:in `block (2 levels) in top_level'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:116:in `each'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:116:in `block in top_level'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:125:in `run_with_threads'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:110:in `top_level'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:83:in `block in run'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:186:in `standard_exception_handling'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/lib/rake/application.rb:80:in `run'
/Users/viktor/.rvm/rubies/ruby-2.6.3/lib/ruby/gems/2.6.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/Users/viktor/.rvm/rubies/ruby-2.6.3/bin/rake:23:in `load'
/Users/viktor/.rvm/rubies/ruby-2.6.3/bin/rake:23:in `<main>'
/Users/viktor/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `eval'
/Users/viktor/.rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `<main>'
RuboCop failed!

Steps to reproduce the problem
mv ~/.rubocop.yml ~/.rubocop.yml_bak # backup your rubocop config if any
echo "require: 'rubocop-rails'" > ~/.rubocop.yml
rubocop # or bundle exec rake default, depending where you are

Since rubocop repo has its own .rubocop.yml, the ~/.rubocop.yml in my home directory should be completely ignored.
This makes it really hard to work on any project that doesn't have rubocop-rails as a dependency, even if it has its own .rubocop.yml config file.
RuboCop version
$ [bundle exec] rubocop -V
0.71.0 (using Parser <IP_ADDRESS>, running on ruby 2.6.3 x86_64-darwin18)

I can reproduce this as and tried to reduce the problem via bundle exec rake internal_investigation down to
➜  rubocop (master) bundle exec rubocop --debug
...
AllCops/Exclude configuration from /Users/buehmann/.rubocop.yml
Error: The `Layout/IndentHash` cop has been renamed to `Layout/IndentFirstHashElement`.
(obsolete configuration found in /Users/buehmann/.rubocop.yml, please update it)
...

The AllCops/Exclude line leads to this spec which was introduced in https://github.com/rubocop-hq/rubocop/pull/295

Get config parameter AllCops/Excludes from highest config file in path

Sure enough, my rubocop checkout is in a directory below my home directory:
➜  rubocop (master) pwd
/Users/buehmann/dev/rubocop

So that's what happens … Not sure what the right solution is.

Adding --ignore-parent-exclusion to the rubocop options in Rakefile would be one option. See https://github.com/rubocop-hq/rubocop/issues/4328

@buehmann I already tried it, does not work. It only ignores Exclude from parent. My parent config has an invalid cop name. Not sure but I think we might need another flag which disables parent inheritance entirely.

You're right, my mistake. --ignore-parent-exclusion still loads ~/.rubocop.yml.

Does it? Not for me. When I add --ignore-parent-exclusion the problem goes away.
 /tmp/7032$ (find . -type f; echo ~/.rubocop.yml) | xargs head
==> ./.rubocop.yml <==
AllCops:
  DisabledByDefault: true

==> ./example.rb <==
puts 1

==> /home/jonas/.rubocop.yml <==
Invalid
 /tmp/7032$ rubocop -d
For /tmp/7032: configuration from /tmp/7032/.rubocop.yml
Default configuration from /usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/config/default.yml
AllCops/Exclude configuration from /home/jonas/.rubocop.yml
Malformed configuration in /home/jonas/.rubocop.yml
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:227:in `load_yaml_configuration'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:42:in `load_file'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:117:in `add_excludes_from_files'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:93:in `configuration_from_file'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/config_store.rb:44:in `for'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/cli.rb:126:in `apply_default_formatter'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/lib/rubocop/cli.rb:40:in `run'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/exe/rubocop:13:in `block in <top (required)>'
/usr/local/rvm/rubies/ruby-2.6.3/lib/ruby/2.6.0/benchmark.rb:308:in `realtime'
/usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/exe/rubocop:12:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.6.3/bin/rubocop:23:in `load'
/usr/local/rvm/gems/ruby-2.6.3/bin/rubocop:23:in `<main>'
/usr/local/rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `eval'
/usr/local/rvm/gems/ruby-2.6.3/bin/ruby_executable_hooks:24:in `<main>'
Finished in 0.0699394969997229 seconds
 /tmp/7032$ rubocop -d --ignore-parent-exclusion
For /tmp/7032: configuration from /tmp/7032/.rubocop.yml
Default configuration from /usr/local/rvm/gems/ruby-2.6.3/gems/rubocop-0.82.0/config/default.yml
Ignoring AllCops/Exclude from parent foldersInspecting 1 file
Scanning /tmp/7032/example.rb
.

1 file inspected, no offenses detected
Finished in 0.11776560500220512 seconds

@jonas054 I am unable to reproduce this issue with rubocop 0.82.0. Not sure when & how this got fixed though. Closing.


Settings for default questions

Default questions can't be deleted but they can be modified or deactivated.

Done


incorrectly reporting possibly undefined value

// @flow

type Props = {
  options?: {
    label?: string,
  }
};
const props: Props = {}

const {options} = props;
const condition = !!options;

if (condition) {
    console.log(options.label || 'default label');
}

if (!!options) {
    console.log(options.label || 'default label');
}

There's an error in the first case: property 'label'. Property not found in possibly undefined value

This is technically correct, but I don't think it's reasonable to expect Flow to remember how each variable calculated its value. It just knows that condition is true or false, not why it's true or false.

Wait, what's the bug here? This code would result in an error. So flow is correctly reporting this.
TypeError: Cannot read property 'label' of undefined

@EugeneZ Take the || true off his condition.
const condition = !!options will set condition to true only if options is not null.
Doing:
if (condition) {
  /* treat options as an object */
}

should be valid, since condition is literally equal to !!options, and it should be interpreted exactly like:
if (!!options) {
  /* treat options as an object */
}

However, the latter example (if !!options) will work fine in Flow, while the former (if condition) will not, despite condition being a constant that is equal to !!options and even options being a constant.

@EugeneZ I've fixed the original issue, there was a mistake as @CharlesStover did
@CharlesStover so is that impossible to remember how even for optional properties?


CSS fix for having profile box appear over nano-slider scrollbar

Alternatively, did you by anychance look at the nano-scroller z-index? Here

I figured the z-index: 10000 was there for a reason, but it does seem to work fine without..

Awesome.


Clean up some volatility_ref related code

Now that #6313 made newrel always clear volatility_ref, we can get rid
of a bunch of code that was doing that explicitly.

I marked it for backport to 4.x because I think it's low risk and it might save us from a few merge conflicts in the future, but feel free to decide not to backport if you don't think it should go in, @aljazerzen


Adds the Persian language and prefixes field with its table name

Fixes #2392

Both Arabic and Persian are RTL languages, I simply translated English locale file into Persian, But for a better translation, I need RTL version of Voyager, I will improve the translation as soon as you release RTL support.


Allow oauthClient to optionally use open id discovery / metadata

Or else provide alternative way of signing out at issuer.

This is done!


Yaku doesn't work if div with id="process" exists

This is the weirdest glitch I've found in my entire existence.
If you add a <div id="process"> to the DOM, it breaks.
The problem is that Yaku checks for window.process, which seems to be defined in some browsers as $("#process"). Yaku then tries to use process.nextTick, which of course doesn't exist.
This doesn't happen in all browsers; not sure why.

😂 What a shame.

Thanks to your report, new version is now available.


[FALSE-POSITIVE]

Domains or links

edje.com
https://edje.com/cmspagephotos/80-dj774h8dFY/Valid

How did you discover your web site or domain was listed here?

ImunifyAV shows that the domain (edje.com) is listed in the Mitchell Krog phishing database.

Have you requested removal from other sources?

No

Additional context

I have removed the offending files which were redirecting to the official PayPal site. This is fixed, please remove the domain from the database. Thanks!

Hi! Any update on this? Is there any more information I can provide to get our domain removed from this database?


SLA notifications

This PR adds functionality to receive SLA pre-breach/breach notifications, based on the SLA settings defined.
2 modes:

A celery default crontab is added (arbitrary)
A manage.py command is introduced

The CLI invocation looks like:
$ docker exec -ti madchap_ddojo_uwsgi_1 bash -c 'python3 manage.py sla_notifications'

The regular notification system is used, with the addition of a new "type" -- sla_breach.
You can see it at the Product notifications level:

Or in the System/Personal notifications screen:

There is a caveat whenever a finding is linked to a JIRA issue. A comment can be posted to the JIRA issue then, and this is opt-in in the JIRA configuration settings, at the bottom:

results in something like:

Some settings changed to drive the notification behavior:
# Setting SLA_NOTIFY_ACTIVE and SLA_NOTIFY_ACTIVE_VERIFIED to False will disable the feature
SLA_NOTIFY_ACTIVE = False  # this will include 'verified' findings as well.
SLA_NOTIFY_ACTIVE_VERIFIED_ONLY = True
SLA_NOTIFY_WITH_JIRA_ONLY = False  # will only process findings that have a JIRA associated
SLA_NOTIFY_PRE_BREACH = 3  # in days, notification until date of breach.

This is a first shot at it. Useful to me at least, just to push comment out to issues in JIRA ;-)
Enhancements can certainly be made.

@valentijnscholten any potential feedback?

Seems my crontab task is not getting registered and does not get triggered. Checking..

There was a template exception. Now OK.
Also added documentation in the companion PR https://github.com/DefectDojo/Documentation/pull/112

From a performance point of view, I have 600K findings loaded, and only 1500 are in-scope of the SLA notification either being active or active-verified, based on the settings. It takes roughly 5 minutes to process them on my workstation (5yr old cpu).

Thanks for the approvals :)
I will correct the conflicts and merge when I am 110% good to go, and after discussing some more with @valentijnscholten on this one as he requested changes ;-)


kube-proxy.yml in Antrea Windows doc doesn't work on some Windows OS

Describe the bug
As stated here: https://github.com/antrea-io/antrea/blob/main/docs/windows.md#add-windows-kube-proxy-daemonset, we use the kube-proxy.yml from https://github.com/kubernetes-sigs/sig-windows-tools/releases/download/v0.1.5/kube-proxy.yml with some modifications to deploy kube-proxy-windows. But from v0.1.5 they changed the spec.containers.command from using powershell to pwsh. In some Windows OS, for example, our testbed:
OS Name:                   Microsoft Windows Server 2019 Standard
OS Version:                10.0.17763 N/A Build 17763
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Server
OS Build Type:             Multiprocessor Free

It can't recognize the command pwsh.
I wonder if we should `sed 's/pwsh/powershell/g' or check/add environment var before using this file?

Maybe @XinShuYang has more context and ideas.

Thanks Grayson for this information. It seems 'pwsh' is not a valid command before powershell v6.0. You can either install a new version or use 'powershell' in yaml if commands work well. I think add this reminder in doc is a good idea. @GraysonWu


fips: make EdDSA unapproved for FIPS

Likewise for the related ECX key exchanges.
NIST is mandating this until FIPS 186-5 is finalised.
They are blocking things until this is addressed.

Likewise for the related ECX key exchanges.
NIST is mandating this until FIPS 186-5 is finalised.
They are blocking things until this is addressed.

Cant this just be done via security policy, rather than break peoples apps.

For 3.0, it can be done via policy (& will be).  For 3.1, it can't.

So branch tag needs to be changed

Depends if we want to merge to 3.0 for programmatic enforcement or not.

I wasn't aware NIST was going to accept EdDSA as a FIPS standard... that's actually quite nice. Maybe one day we will be able to get Ed25519 WebPKI certificates...

FIPS 186-5 introduces these curves as a standard.
They've been allowed in the past but not approved.

Should we at least informally discuss this in OTC as this is kind of feature break for 3.1 beta?

This pull request is ready to merge

Merged to 3.1 and master.

Note for OTC: this is an unavoidable API change in 3.1.
Question for OTC: should we merge this to 3.0 as well?

OTC: not going to 3.0


permission.request() callback never Called

On :head, permission.request() is broken, completion is never called.
With version 1.1, it works as expected (completion is called)
Test: Put this in you app delegate didFinishLaunching :
        let permission: Permission = .LocationWhenInUse
        print(permission.status) // => "NotDetermined"

        permission.request { status in
            switch status {
            case .Authorized:    print("authorized")
            case .Denied:        print("denied")
            case .Disabled:      print("disabled")
            case .NotDetermined: print("not determined")
            }
        }

Only .NotDetermined is printed

I'm on my phone and can't give it a test now but after peeking into requestLocationAlways|WhenInUse, there is definitely something wrong indeed 😨
I'll fix it later in the day (hopefully) and release a new version short after.
But just for info, you did add a NSLocationWhenInUseDescription in your .plist, right?

I did. I also tested with .Contacts, same failure.

Ok I found the bug :)
In internal func callbacks(), I call self.callbacks instead of self.callback
Could you please fix this typo and fill a PR please (I'm still on my phone).
Thanks

Fixed in 9cb2581ff88ab735bfe7a81181395c9d76ffe4a6
Thanks for the issue!

I saw you just fixed it. Awesome, thanks !


[Event Request] Table 5600 "Fixed Asset"- OnBeforeGetNoSeriesCode

Hi Team,
In table 5600 "Fixed Asset" , we need to have Integration event in  OnInsert procedure . Adding an event with handling in this procedure will solve our problem.

trigger OnInsert()
var
IsHandled: Boolean;
begin
IsHandled := false;
OnInsertOnBeforeInitSeries(Rec, xRec, IsHandled);
if not IsHandled then
if "No." = '' then begin
FASetup.Get();
FASetup.TestField("Fixed Asset Nos.");
NoSeriesMgt.InitSeries(FASetup."Fixed Asset Nos.", xRec."No. Series", 0D, "No.", "No. Series");
end;
    "Main Asset/Component" := "Main Asset/Component"::" ";
    "Component of Main Asset" := '';

    DimMgt.UpdateDefaultDim(
      DATABASE::"Fixed Asset", "No.",
      "Global Dimension 1 Code", "Global Dimension 2 Code");
end;

[IntegrationEvent(false, false)]
local procedure OnInsertOnBeforeInitSeries(var FixedAsset: Record "Fixed Asset"; xFixedAsset: Record "Fixed Asset"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


fix the quarter parse failure

I think the expect result is the first day of current quarter's last month, it will be cracked when the month is 1, 2.

We're in the process of throwing up a new release, we're going to include this pr in that release.  Hold this pr open for a bit so we don't lose it!


Removes autodrinking

About the PR

This is a quick and easy PR to disable autodrink until a better solution is decided upon. Instead of waiting for the best solution, I figured that it would be a good idea to get something out now and improve it later.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Centcom has agreed to temporally disable the vacuums on drinks for now.

yeah people seem to really hate this think we just need a better solution

I see how it could be useful if you want to get a drink out of a vending machine and just need to drink something, but in mrp situations it is very useful to be able to drink slowly.

i do like shlorpin at my own speed

I've seen quite a lot of people complain that they accidentally drank copious amounts of meds, while they only intended to sip once.
Is it possible to make auto drink toggle able?

Why do we need auto drinking again?

This seems like just some TG gamer tier thing, don't like it personally.

#15434 is the preferred change for this at the moment, unless you add item cooldowns to food/drink in this PR.

Why is this the preferred change?
It is kind of unintuitive to have to click twice to stop drinking something and instead chug the whole thing - and even then, I don’t really see why auto drinking and eating needs to exist, other than thatIt’s good QOL; however, I don’t think it should be the default. Many, many players I’ve played with recently agree that this sucks, especially on Salamander.
I can see the use of auto drinking but I don’t think it should exist until it’s either toggleable or isn’t the default - so for example your preferred solution PR inverts things so it’s two clicks to autodrink.

Idea: Pressing use once let you drink/eat like before. HOLDING down use autodrinks/eats

#15434 is the preferred change for this at the moment, unless you add item cooldowns to food/drink in this PR.

The idea is to have this be merged as a quick fix, and then enhance the behavior later.

I think that a single drink should be the default behavior. and double clicking should autodrink, but that is not for this PR.

#15434 is the preferred change for this at the moment, unless you add item cooldowns to food/drink in this PR.

Why is this the preferred change?
It is kind of unintuitive to have to click twice to stop drinking something and instead chug the whole thing - and even then, I don’t really see why auto drinking and eating needs to exist, other than thatIt’s good QOL; however, I don’t think it should be the default. Many, many players I’ve played with recently agree that this sucks, especially on Salamander.
I can see the use of auto drinking but I don’t think it should exist until it’s either toggleable or isn’t the default - so for example your preferred solution PR inverts things so it’s two clicks to autodrink.

We're experimenting with how repeated doafters could be applied and currently food and drink are the best way to test because tools are nowhere near ready yet to accept it. People want a cancel button for the repeat so hitting the button twice is the better solution than to comment it out. A user pref is on the horizon but not ready yet.
There are some cases where we found that having an item cooldown would be better than a doafter. Depends if they're on self vs other, how short they are, etc. Food and Drink (for self) is a candidate for that and will be the accepted solution.

#15434 is the preferred change for this at the moment, unless you add item cooldowns to food/drink in this PR.

The idea is to have this be merged as a quick fix, and then enhance the behavior later.

This is not game breaking and it's not the accepted quick fix. Please make the changes requested.

We're experimenting with how repeated doafters could be applied and currently food and drink are the best way to test because tools are nowhere near ready yet to accept it. People want a cancel button for the repeat so hitting the button twice is the better solution than to comment it out. A user pref is on the horizon but not ready yet.

Why not this https://github.com/space-wizards/space-station-14/pull/15613 ?

Also, if this is not the accepted quick fix what is? It seems like most people want it gone for drinks entirely or to have it activate depending on a key combination or something else. I personally don't think that repeatable doafters work well for drinks at all and would rather have it removed entirely.

We're experimenting with how repeated doafters could be applied and currently food and drink are the best way to test because tools are nowhere near ready yet to accept it. People want a cancel button for the repeat so hitting the button twice is the better solution than to comment it out. A user pref is on the horizon but not ready yet.

Why not this #15613 ? Also yes it is a better solution, but this solution is ready right now, and the other one isn't last time I checked.

That still needs to be reviewed and to check to see what healing items it effects.
This solution is just not going to be accepted unless the changes are made to remove it and replace it with an item cooldown.

Considering there is another solution waiting to be merged and that changing the doafters to be cooldowns is much to hard for me to do with my limited c# knowledge, I will be closing this PR. I hope that there is some change to the behavior soon.

to be a cooldown give it UseDelayComponent and _useDelay.BeginDelay(uid, useDelay); after checking _useDelay.ActiveDelay(uid, useDelay) (for self drinking only)

To be honest, I am not really focused on this PR at the moment as many other people have taken interest in this themselves. I will not being updating this PR with new updates.


use filename without ".roc" as name for the binary

.exe extension should be added on windows
no extension should be used on linux and macos for the binary
as a first PR, I suggest we still allow specifying the app name but just don't use it for anything

If this is the case should the tutorial be updated to reflect how the binary is named? For a beginner the current text is confusing:

The line app "hello" states that this module defines a Roc application, and that building this application should produce an executable named hello

Good catch @guydunton! I'll update the tutorial


Not possible to write clients with ES5 syntax

Using require is not possible in the client, which prevents me from writing tests without using babel. I think it is because the plugin is using ES6 syntax and two do not mix.
Is it possible to write the plugin in ES5 syntax?
Or any other suggestions to fix this besides installing babel-cli just for one test case?
Thanks.

@moltar this plugin is a superset of Nuxt where you write in es6 syntax. Not sure why you can't import modules with the require syntax, I do that quite often.

I am talking in a context of a unit test. I cannot require this module with import statements without transpiling it first.

@moltar did you try to use AVA for testing? That is what I use for my tests in general, there ES6 is running out of the box. I don't plan to change the concept of how this module is included for each Nuxt project.

@moltar v4 provides a new way to wire up your apollo-config. I am closing this issue now as there has been too many changes internally and hopefully with AVA tests everything should work


XCURSOR_SIZE in .wslgconfig is not working

According the code https://github.com/microsoft/wslg/blob/main/WSLGd/main.cpp#L76, It seems that we can set any env variable in config file.
but when I set XCURSOR_SIZE , It seems not working
C:\ProgramData\Microsoft\WSL.wslgconfig
[system-distro-env]
XCURSOR_SIZE=48
/mnt/wslg/versions.txt
WSLg ( x86_64 ): 1.0.24+Branch.main.Sha.b42023b5fed7567955f4c6c36123a5cf22e9292a
Mariner: VERSION="1.0.20210224"
FreeRDP: b05321cd4e6a862aef76163a69db4e1910245736
weston: ed4f3bbbf5efbd5bde880704bc03497f2446c3f2
pulseaudio: 2f0f0b8c3872780f15e275fc12899f4564f01bd5
mesa:
ver:
Microsoft Windows  10.0.22000.100

Hello,
Just a comment based on what I am seeing. Looks like the environment variable is applied to the system distro, but XCURSOR_SIZE should be defined in your own distro to take effect no? What happens if you use WSLENV?
Regards,
Carlos

Hello,
Just a comment based on what I am seeing. Looks like the environment variable is applied to the system distro, but XCURSOR_SIZE should be defined in your own distro to take effect no? What happens if you use WSLENV?
Regards,
Carlos

Thanks for your replay,  You are right，set XCURSOR_SIZE  in .wslgconfig only affect the border and title's cursor （I'am using Idea）， the main interface 's cursor still 16*16， after install xcursor-themes and config in dconf-editor, some apps( gedit/gnome-tweaks etc.) are OK now. but still not work in Idea.
Any sugguestion?

If you set this variable in your distro, for example in .bashrc, does it change anything?

If you set this variable in your distro, for example in .bashrc, does it change anything?

Not really. I doubt it's a problem related to the java swing or RDP.
when I set some env variables in .profle/.bashrc.  idea window title's cursor is expected. (the black one is much small, but the photo is scaled)

and gedit

but failed in idea main interface.

What happens if you set the environment variable GDK_SCALE=2?

What happens if you set the environment variable GDK_SCALE=2?
More info here: https://intellij-support.jetbrains.com/hc/en-us/articles/360007994999-HiDPI-configuration

Thanks a lot. I'd tried, but there are more problems  about window scale solution(ide.ui.scale or GDK_SCALE). Idea's will crash or display blank window.

I ran into the same problem. But even more, I tried to set the env XCURSOR_SIZE and also tried to tweak the options in dconf-editor, but none of them have any effects. I don't even get a larger cursor in gedit, neither at title or not

Any ideas? Thanks in advance.


hotfix: fixed image format validation

The image validation assumed that the registry/domain name of an image contains a dot (.) as domain usually do. However this doesn't work for images coming from private registries like 'private-registry:3000'. Making the dot optional also doesn't fix the problem since for image like 'path/to/image:tag', 'path' would be recognized as a domain name. Thus the validation has been change so that domains that do not contain a dot, necessarily need to specify a port in order for them to be recognized as domains.
fix #114

Cherry on the cake: Test that when there's no dot, a port specification is required.

I take that back; that's a different case for which there are already tests.


Probe rewrite fails if path does not start with "/"

Bug description
If you define livness probe where path does not start with / istio-proxy fails to rewrite probe requests from kubelet with en error :
error	Failed to create request to probe app parse "http://localhost:8001foo": invalid port ":8001foo" after host, original url /app-health/liveness-http/livez

[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Probe rewrite succeeds, container does not get restarted.
According to k8s path does not need to start with /. Without sidecar it works, kubelet handles such requests.
Steps to reproduce the bug
I have used livness-http example from probe rewrite docs, but I've modified the path :
kind: Service
metadata:
  name: liveness-http
  labels:
    app: liveness-http
spec:
  ports:
  - name: http
    port: 8001
  selector:
    app: liveness-http
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: liveness-http
spec:
  selector:
    matchLabels:
      app: liveness-http
      version: v1
  template:
    metadata:
      labels:
        app: liveness-http
        version: v1
      annotations:
        sidecar.istio.io/rewriteAppHTTPProbers: "true"
    spec:
      containers:
      - name: liveness-http
        image: docker.io/istio/health:example
        ports:
        - containerPort: 8001
        livenessProbe:
          httpGet:
            path: foo
            port: 8001
          initialDelaySeconds: 5
          periodSeconds: 5

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
client version: 1.6.0
cluster-local-gateway version:
pilot version: 1.6.0
data plane version: 1.6.0 (5 proxies)

How was Istio installed?
istioctl manifest apply --set profile=demo --set values.global.mtls.enabled=true  --set values.gateways.istio-ingressgateway.sds.enabled=true --set values.sidecarInjectorWebhook.rewriteAppHTTPProbe=true
Environment where bug was observed (cloud vendor, OS, etc)
GCP

Discussion for @piotrmsc and @istio/wg-user-experience-maintainers
I propose Istio treat foo as /foo.
That seems better than skipping the rewrite or trying to block the deployment with a validation.
Thoughts?

Interesting, does k8s implicitly add a /? if so we should of course do the same

In general, it's a minor, if you have control over resources applied it's easy to add this /. I found it when running dapr and its sidecar, dapr sidecar injector does not provide this slash, however, IMO it's not a bid deal to change it ;-) I will ask them about it.
@howardjohn  When it comes to kubelet, after parsing url  missing / is added.
👍 for me to adopt this in istio like @enis mentioned.

https://github.com/istio/istio/pull/24412


custom templates

Hey... really nice idea
I was missing scaffold from way/generators badly and you made it.
as in original generators (way/generators).. do you have custom templates option?
Thanks.

Hi @lorvent,
not yet.. but for now, you can change the files .stub in /vendor/laralib/l5scaffold/src/stubs/
Thanks.

how easy to convert this into core code
i.e. instead of using it as a composer package, i want to hard code into my application.
is that tough?
thanks.

@lorvent I think your question might be unclear.

Sorry, i meant to say....
Instead of using package, i want to hard code its complete code into my project.
I am asking how easy it is to achieve above thing.

Composer is a nice way to go, it's very simple. I recommend it. Does composer not work for you? or have you tried it?

@lorvent Fork the project, change the stub files and install your fork via composer :)


UI Tags column in Run List missing a value.

Looking at the run list I see the Tags column is empty.

Hi, unless this is just a remark as you want to fix the issue yourselves the information above is insufficient. Tags can be empty if you don't specify any accessor in test configuration (General tab) or if it doesn't match.

The accessor values are visible in another column.
For some reason unknown to me this tag column has started showing today.


Crash when a text start with a space in Hebrew localization

Steps to Reproduce:
  Text(" שלום")

Target Platform: Android / iOS
Logs
No logs. App close with "Lost connection" message.
Workaround:  use trim(); on the text data.
P.S. The same problem with TextField

Oh right, didn't pay attention that hebrew is right to left. @LeonidVeremchuk please try it on master or dev, the fix went to v1.10.6

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


update mklml version to make it consistent with mkldnn.

We found mkldnn version was updated in https://github.com/tensorflow/tensorflow/commit/13440cc25460113c4828f4355bcc7544a613daa1 but did not update the mklml version.
This PR update the mklml to latest version to make it consistent with the mkldnn version.

@penpornk It’s important to use latest mklml especially in GEMM function.

@guizili0 Thank you for the info!
@wt-huang Could you please help pull the PR? (Windows Bazel GPU test doesn't really work right now and I think we can ignore its failure.) Thank you!


Change icon of updateable packages

Latest paket has api to retrieve all updateable packages. Would be awesome if this would be used. See https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/PublicAPI.fs#L116

how?
I can do the background task, but how can I change the icon?

It should be possible to just called node.SetValue(DgmlNodeProperties.Icon, new icon (e.g. updated pacage)), but I haven't tried it.

Wow... possibly need to call context.OnCompleted first... I have no idea :)
On Wed, May 13, 2015 at 3:58 PM, Steffen Forkmann<EMAIL_ADDRESS>wrote:

[image: image]
https://cloud.githubusercontent.com/assets/57396/7610868/7bdbe526-f980-11e4-8140-fa9100a31895.png
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/14#issuecomment-101654446
.

Yeah. Probably.
On May 13, 2015 3:01 PM, "Igal Tabachnik"<EMAIL_ADDRESS>wrote:

Wow... possibly need to call context.OnCompleted first... I have no idea :)
On Wed, May 13, 2015 at 3:58 PM, Steffen Forkmann <
<EMAIL_ADDRESS>wrote:

[image: image]
<
https://cloud.githubusercontent.com/assets/57396/7610868/7bdbe526-f980-11e4-8140-fa9100a31895.png
—
Reply to this email directly or view it on GitHub
<
https://github.com/fsprojects/Paket.VisualStudio/issues/14#issuecomment-101654446
.

—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/14#issuecomment-101655077
.

adding myself to discussion


Pipelines with software decoding

When constructing pipelines that use software decoding on systems with available hardware-accelerated decoding and rendering, hardware-accelerated rendering in samples via fpsdisplaysink and autovideo sink may crash

On the systems with integrated GPU available, use hardware-accelerated decoding. Directly specify parameter ‘video-sink = glimagesink’ for fpsdisplaysink element.


BotFramework Carousel CardAction Button Doesn't OpenUrl in Skype Channel

Hi,
unable open link in skype channel.. I need to open http only.. can u please suggest?

I'm sorry, this is just for WebChat issues. Please use Stack Overflow for general Bot Framework questions.


⚠ Bofrost.lu has degraded performance

In 58b1c4f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1804 ms

Resolved: Bofrost.lu performance has improved in 7cb7c6d after 57 minutes.


chore: update package metadata

Adds package metadata including description and keywords

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 468c915bdd7c0e0672262e260f9fc1ee852a6c59
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Readme Update

Update the course information on AIStudio

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Colorpicker example crashes when the clear button is pressed

examples/widgets/colorpicker.py
 Traceback (most recent call last):
   File "E:\dev\prs\kivy\examples\widgets\colorpicker.py", line 230, in <module>
     MainApp().run()
   File "E:\dev\prs\kivy\kivy\app.py", line 828, in run
     runTouchApp()
   File "E:\dev\prs\kivy\kivy\base.py", line 487, in runTouchApp
     EventLoop.window.mainloop()
   File "E:\dev\prs\kivy\kivy\core\window\window_sdl2.py", line 622, in mainloop
     self._mainloop()
   File "E:\dev\prs\kivy\kivy\core\window\window_sdl2.py", line 365, in _mainloop
     EventLoop.idle()
   File "E:\dev\prs\kivy\kivy\base.py", line 330, in idle
     self.dispatch_input()
   File "E:\dev\prs\kivy\kivy\base.py", line 315, in dispatch_input
     post_dispatch_input(*pop(0))
   File "E:\dev\prs\kivy\kivy\base.py", line 281, in post_dispatch_input
     wid.dispatch('on_touch_up', me)
   File "kivy\_event.pyx", line 718, in kivy._event.EventDispatcher.dispatch (kivy\_event.c:7726)
   File "E:\dev\prs\kivy\kivy\uix\behaviors\button.py", line 187, in on_touch_up
     self.dispatch('on_release')
   File "kivy\_event.pyx", line 714, in kivy._event.EventDispatcher.dispatch (kivy\_event.c:7681)
   File "kivy\_event.pyx", line 1224, in kivy._event.EventObservers.dispatch (kivy\_event.c:13524)
   File "kivy\_event.pyx", line 1108, in kivy._event.EventObservers._dispatch (kivy\_event.c:12356)
   File "E:\dev\prs\kivy\kivy\lang\builder.py", line 64, in custom_callback
     exec(__kvlang__.co_value, idmap)
   File "<string>", line 89, in <module>
 AttributeError: 'NoneType' object has no attribute 'canvas'

fixed in #4094
The demo crashes when clicking clear button without selecting any image.
Fixed by adding a check on the current_image.
Also fixed the display image name that may happen on different computers.


Migrating from monospice/laravel-redis-sentinel-drivers library

Hello! I'm currently migrating a project from monospice/laravel-redis-sentinel-drivers to this library, but I'm having a really hard time fully understanding how I should adapt all my configs. I would deeply appreciate any sort of help, if possible.
Currently, my database.php file looks like this:
'redis' => [
        'retry_count'    => env('REDIS_RETRY_COUNT', 20),
        'retry_sleep_ms' => env('REDIS_RETRY_SLEEP_MS', 200),
        'client' => env('REDIS_CLIENT', 'phpredis-sentinel'),
        'options' => [
            'cluster' => env('REDIS_CLUSTER', 'redis'),
            'prefix' => env('REDIS_PREFIX', Str::slug(env('APP_NAME'), '_').'_database_'),
        ],

        'default' => [
            'password' => env('REDIS_BROADCAST_PASSWORD', $password),
            'port' => env('REDIS_BROADCAST_PORT', $port),
            'database' => env('REDIS_QUEUE_DATABASE', $database),
            'options' => [
                'prefix' => env('REDIS_PREFIX', Str::slug(env('APP_NAME'), '_').'_default_'),
            ],
            'sentinel_host' => env('REDIS_SENTINEL_HOST', $host),
            'sentinel_port' => (int) env('REDIS_SENTINEL_PORT', $port),
            'sentinel_service' => env('REDIS_SENTINEL_SERVICE', $service),
            'sentinel_timeout' => (float) env('REDIS_SENTINEL_TIMEOUT', 0.1),
            'sentinel_persistent' => env('REDIS_SENTINEL_PERSISTENT'),
            'sentinel_retry_interval' => env('REDIS_SENTINEL_RETRY_INTERVAL', 1000),
            'sentinel_read_timeout' => env('REDIS_SENTINEL_READ_TIMEOUT', 0),
            'sentinel_password' => env('REDIS_SENTINEL_PASSWORD'),
        ],

        'cache' => [
            'host' => env('REDIS_BROADCAST_HOST', $host),
            'password' => env('REDIS_BROADCAST_PASSWORD', $password),
            'port' => env('REDIS_BROADCAST_PORT', $port),
            'database' => env('REDIS_CACHE_DATABASE', $database),
            'sentinel_host' => env('REDIS_SENTINEL_HOST', $host),
            'sentinel_port' => (int) env('REDIS_SENTINEL_PORT', $port),
            'sentinel_service' => env('REDIS_SENTINEL_SERVICE', $service),
            'sentinel_timeout' => (float) env('REDIS_SENTINEL_TIMEOUT', 0.1),
            'sentinel_persistent' => env('REDIS_SENTINEL_PERSISTENT'),
            'sentinel_retry_interval' => env('REDIS_SENTINEL_RETRY_INTERVAL', 1000),
            'sentinel_read_timeout' => env('REDIS_SENTINEL_READ_TIMEOUT', 0),
            'sentinel_password' => env('REDIS_SENTINEL_PASSWORD'),
        ],

There also other entries (like session, broadcasting), but they are essentially the same as cache.
In my cache.php file, I have:
        'redis' => [
            'driver' => 'redis',
            'connection' => 'cache',
        ],

        'phpredis-sentinel' => [
            'driver' => 'redis',
            'connection' => env(
                'CACHE_REDIS_SENTINEL_CONNECTION',
                env('CACHE_REDIS_CONNECTION', 'cache')
            ),
        ],

The relevant part of my .env is:
REDIS_CLIENT=phpredis-sentinel
REDIS_CLUSTER=predis
REDIS_DRIVER=phpredis-sentinel
CACHE_DRIVER=phpredis-sentinel

Since the project is already running, I know things like the host, password, database and etc are correct. What is really confusing me, is how exactly I should add the new driver (phpredis-sentinel) into my configs. For instance, when we were still using the Monospice library, the cache.php file had:
        'redis-sentinel' => [
            'driver' => 'redis-sentinel
            'connection' => env(
                'CACHE_REDIS_SENTINEL_CONNECTION',
                env('CACHE_REDIS_CONNECTION', 'cache')
            ),
        ],

The .env looked like:
REDIS_CLIENT=predis
REDIS_CLUSTER=predis
REDIS_DRIVER=redis-sentinel
CACHE_DRIVER=redis-sentinel

When switching libraries, I first thought that I'd have to switch all my references of redis-sentinel as a driver to phpredis-sentinel, while also defining the client and the other sentinel_* variables mentioned in the README. Thing is, in my cache.php, when I try to use 'driver' => 'phpredis-sentinel, I receive the error Driver [phpredis-sentinel] is not supported. The only driver I managed to make work, is redis.
So, my main question here is: is defining the client in database.php enough, or should I actually be able to manually define the drivers in cache.php and the other files like that (session.php, etc)? If the driver should be defined (and not be simply redis), can you spot any possible reason for why Laravel is returning a not supported message? Library is installed, of course.
Since the README doesn't mention any special configuration for files like cache.php or the .env, I really don't know exactly how should I "simplify" all the past configs to adapt it to the new library. Should I really just stick with redis as a driver for everything and the phpredis-sentinel client defined in database.php will do all the magic?
I will gladly send any other details that might be needed, and even add some more content to the README if you judge it might be interesting for people who might be in a spot like mine.
Regardless of all that, thanks for the awesome library! :)

What Laravel version are you running on?

Currently trying on Laravel 9 since its the stable and working version of the project, but the plan is to put it into Laravel 10 right after making it work. Reason for this is that, since the project is already stable on Laravel 9, we thought it would be easier to make it work first, and then upgrading to 10.

Ok, I see - your upgrade strategy should be no problem at all.
Regarding the configuration:
There are five config files that normally - in one way or another - define or reference the Redis configuration:

config/database.php
config/broadcasting.php
config/cache.php
config/session.php
config/queue.php

The first one, config/database.php, configures the actual Redis connections, while the other four only reference the connections of the former. So CACHE_DRIVER=phpredis-sentinel is wrong and should simply be redis (same for all other occurrences). The only reference to phpredis-sentinel should be the client in config/database.php.
What I also find odd about your configuration is the REDIS_CLUSTER=predis part. The package is entirely incompatible with predis (since predis supports Redis Sentinel out of the box already, as far as I know). Maybe remove this option all-together...

The operation timed out error sounds like a firewall issue to me. Are you sure that you are able to connect from the machine you are testing this on? Maybe run telnet <ip> <port> for both the Redis Sentinel and Redis ports and all IPs.

Maybe as a little more help, here the configuration we've been using successfully.
config/database.php:
return [

    'redis' => [

        'client' => 'phpredis-sentinel',

        'default' => [
            'sentinel_host' => env('REDIS_SENTINEL_HOST', '<IP_ADDRESS>'),
            'sentinel_port' => intval(env('REDIS_SENTINEL_PORT', 26379)),
            'sentinel_password' => env('REDIS_SENTINEL_PASSWORD'),
            'sentinel_service' => env('REDIS_SENTINEL_SERVICE', 'mymaster'),
            'sentinel_timeout' => env('REDIS_SENTINEL_TIMEOUT', 0),
            'sentinel_persistent' => env('REDIS_SENTINEL_PERSISTENT'),
            'sentinel_retry_interval' => env('REDIS_SENTINEL_RETRY_INTERVAL', 0),
            'sentinel_read_timeout' => env('REDIS_SENTINEL_READ_TIMEOUT', 0),
            'password' => env('REDIS_PASSWORD'),
            'database' => 0,
        ],
    ]
];

To conclude all of this: although I couldn't make this library work, I do managed to find a workaround in our project that solved our problems pretty decently. Regardless of that, thank you for all the help! Really appreciate it :)


Save window data

Related to #43. Kinda caused by it.
Need to save NewWindow struct data in the windows vec so that I can re-draw them. This will require a lot of restructuring. I'm thinking if we store a HashMap with another HashMap of the WINDOW and NewWindow, that should work. It probably won't be pretty, though.
RedHat please hire me.

(And also maybe changed the name of that struct).

What if we moved the WINDOW data into the NewWindow data type? (I guess we'll call that WindowData btw).

I guess this is working.

got it working.


Update Nimble options

Current dependencies on/for this PR:

main

PR #1   👈

This comment was auto-generated by Graphite.


Retweeted quote statues does not parse correctly

I found tweepy does not parse it correctly if a quote status is retweeted. For example this statue id:<PHONE_NUMBER>64705536. The status object I get with:
s = api.statuses_lookup([701159606064705536])[0]

gives s.retweeted as False and is_quote_status as True.

The retweeted attribute of a Status/Tweet object indicates whether the Tweet has been Retweeted by the authenticating user.
Instead, to check whether the Tweet itself is a Retweet, you should check for the existence of retweeted_status attribute, which should exist for that Tweet.
For more information, see the linked Twitter API documentation on Tweet objects.


Fixed Favicon Path

Related Issue

Favicon not displaying

Closes: #104
Describe the changes you've made
Fixed the link tag for the favicon, it had the wrong image path.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.

Screenshots
Put any screenshot(s) of the project here.

Thank you for contributing.


introduce docker-images source

Add source of docker images

@termoshtt Thank you, I removed debug code.

I think you should remove /bin/bash in zaw-docker-run because it may not work in case ENTRYPOINT is set.
For example, you can't run the image built from Dockerfile below.
FROM ubuntu
RUN apt-get install -y zsh
ENTRYPOINT ["/usr/bin/zsh"]

As discussed in #68, I think we will be moving to just having links in the readme to more sources.  Do you want to make a repo for this source, @muratayusuke?

Please create a separate repository to reduce maintenance cost :< as discussed in #68
I will close this PR. If anyone needs this source, I can create a separate repository. Please let me know.


Outdated news article for Google ENS security vulnerability

Where to find the issue

In the FAQ News Section EN
https://www.coronawarn.app/en/faq/#google_security_vulnerability "Information about the security vulnerability already fixed by Google in the Exposure Notification Framework"

In the FAQ News Section DE
https://www.coronawarn.app/de/faq/#google_security_vulnerability "Information zur bereits von Google geschlossenen Sicherheitlücke im Exposure Notification Framework"

Describe the issue

This is no longer news. The information is dated April 27, 2021.
The article says that the fix has been rolled out to 98%. This information is presumably outdated and all devices with internet connectivity can be expected to have updated by now.
The title is missing the usual "[Google/Android]:" prefix which all other FAQ articles use for information that only applies to this environment.
There is a typo in the title of the German article "Sicherheitlücke"
Google refers to their system as COVID-19 Exposure Notification System (not Framework) - see https://support.google.com/android/answer/9888358?hl=en

Suggested change

Move to top of Resolved section EN  and Resolved section DE
Change English title to "[Google/Android]: Fixed security vulnerability in the Exposure Notification Framework"
Change German title to "[Google/Android]: Geschlossene Sicherheitslücke im Exposure Notification Framework"
Remove statement about 98%. Just say that a fix has been provided.

Ignore issue about name (ENF / ENS).
Additional information
The security vulnerability was linked to https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-31815 and the article https://themarkup.org/privacy/2021/04/27/google-promised-its-contact-tracing-app-was-completely-private-but-it-wasnt.
The FAQ article was originally published on April 30, 2021 via PR https://github.com/corona-warn-app/cwa-website/pull/1175.

PR #1609 has been submitted to resolve this issue.


Audio Feedback on local viewer

Every time I load the page, the local view window needs to be muted..  other wise, there is wailing feedback on my laptop.
I couldn't find the fix.. any help would be awesome!!

Hi Simon
This fix is not working for me. Add audio="muted" to my local video but it did not fix the issue.

Can you help me out please?
Jonas

hi
here's the link to my index.html
https://www.dropbox.com/s/i93mm7tuvc6x90m/index.html?dl=0
or check the image