Separate async and sync models

Previously, sync and async logics were conflated, such that all Models had to implement a async def _predict* instead of just _predict*.
This is confusing, and leads to a log of magic happening.
Here, I split the models into Model (with sync predict/predict_batch) and AsyncModel with async predict and predict_batch.
This leads to a number of changes:

I create a BaseModel class that gathers all the sync logic that is common between Model and AsyncModel. This comprises the validation logic, description, etc. I then create both Model and AsyncModel from this class.
Neither TensorflowModel nor DistantHTTPModel can automatically pick between the two, or choose at runtime (e.g. using TF_SERVING_MODE="rest-async", or checking for an event loop). I split these models into a sync and an async version too
We want to make sure that a sync colored model can still call an async model. To do so, I wrap async models in a special class that uses asyncio.run to run the coroutines. Since doing so terminates event loops, that forces me to rewrite a bunch of the test code to use pytest.mark.asyncio and run their own event loop.

It might be easier to merge before fixing issues (if any), than reviewing due to the diff size :)


Clean up mapping functions in fclaw2d_map.{c,h}

Originally reported by: Donna Calhoun (Bitbucket: donnaaboise, GitHub: donnaaboise)

Mappings are now all kept in their own separate  files, i.e. fclaw2d_map_torus.c, etc. so they no longer need to be defined in fclaw2d_map.{c.h}.

Bitbucket: https://bitbucket.org/donnaaboise/forestclaw/issue/74

This will get done and appears in other issues

This will get done - but now shows up on project list.


cleaned up GPU consensus calling

This pull request restructures and cleans up the pull request #468 (GPU accelerated nanopolish consensus) by @vellamike so that:

it can be automatically merged; and,
changes to original nanopolish code and behaviour are minimised.

In a summary:

newly added files are : cuda.mk,  src/cuda_kernels/GpuAligner.cu,
src/cuda_kernels/GpuAligner.h and, src/cuda_kernels/gpu_call_variants.inl.

Importantly these files are effective (or compiled) only if make is called with make cuda=1. Those files are completely ignored otherwise.

changes to existing files are :
Makefile - includes cuda.mk if called with make cuda=1
README.md - brief guide on compiling and running for the GPUs
src/nanopolish_call_variants.cpp - option gpu added where as the default behaviour is to follow the CPU code path.
GPU code path generate_candidate_single_base_edits_gpu is only compiled if make cuda=1 is specified, and thus, no impact on the existing code.

I did some benchmarks based on the small chr20 dataset (average coverage of around 30-40X) on three different systems, a server, laptop and a Jetson dev board. On all cases, a speed up of ~5X was observed for the GPU implementation compared to its CPU counterpart (run with maximum threads available on CPU). Importantly, the output from the GPU and CPU are very similar except for a handful of differences, probably due to floating point handling. Further, the implementation was robust, that it ran on these cases without an issue.
The average speed ups for three separate 50kb regions (chr20:5000k-5050k, chr20:5050k-5100k, chr20:5100k-5150k) are as below:

The averages in the graph are based on three executions and the raw time values are as below:

I also checked on a 1M region (chr20:5M-6M) and the speedup on the server with Tesla V100 was even better with ~7X. The raw values are as below:

Given that Nanopolish consensus is known to be very time consuming process for larger genomes, I think this will benefit Nanopolish users.

The compiled binary (with GPU support) is attached if you wish to test on a system with an NVIDIA GPU without the trouble of installing CUDA toolkit.
nanopolish-gpu-bin.tar.gz

Also the test script and the raw outputs and logs are also attached. Just extracting and running simple_bench.sh may work.
test.tar.gz

Hi,
very nice work but i have a question.
I have a PC with 3 GPU, how can i use all of them? Can i set to which card send a region?
additionally, on a multi-thread PC you can use the software parallel to send several process (regions) at the time with little number of nanopolish threads (-t option).
how beneficial is GPU over CPU in this contest?
Cheers
Luigi

At the moment it is the first GPU that is used by default. It is possible to add a command line option to that the user can provide which GPU to execute on - planning to do this in near future.
I did not benchmark the CPU version in that multi process approach so far. However, the mutli threaded approaches I benchmarks had around 70-90% CPU utilisation, so I guess the multi process approach will be slightly faster overall. Infact, in modern GPUs it is possible to launch multiple contexts as well, but these approaches are yet to be evaluated.
@vellamike could give more insights in to these questions.

Hi,
I made some test my self. Considering that on gtx1070 I can lunch 7 process at the time, I was able to make a variant call in 22 minutes compared to 44 on cpu.
I think that with the data set I used, the gpu approach is at least 50% faster.

What was the average coverage of the dataset? Is it a publicly available dataset, if so I can give a try on a v100 as well. And, how did you launch the multiple processes, is it through that nanopolish's make range? If possible share the commands.

@lfaino You can also chose the GPU by setting the CUDA_VISIBLE_DEVICES environment variable. For example, export CUDA_VISIBLE_DEVICES=0 or CUDA_VISIBLE_DEVICES=1. There is no easy way to find which GPU is which device, but in general device 0 will be the fastest GPU on your system.
If you are able to launch multiple processes from the command line, you should set CUDA_VISIBLE_DEVICES differently for each, in your case you have 3 GPUs so you should do
CUDA_VISIBLE_DEVICES=0 nanopolish ...
CUDA_VISIBLE_DEVICES=1 nanopolish ...
CUDA_VISIBLE_DEVICES=2 nanopolish ...
gtx1070 is a relatively old consumer card so a card like a GV100 should be faster.
Multi-GPU support is something we can definitely add in the future.

@hasindu2008
here the command for CPU:
time python3 /data/software/nanopolish/scripts/nanopolish_makerange.py reads.paf.b02.racon1.fasta | parallel --results nanopolish.results -P 20 nanopolish variants --consensus -o cpu/polished.{1}.vcf -w {1} -r barcode02_guppy.fastq -b test.sorted.bam  -g reads.paf.b02.racon1.fasta -t 4 --min-candidate-frequency 0.1
here the gpu:
time python3 /data/software/nanopolish/scripts/nanopolish_makerange.py reads.paf.b02.racon1.fasta | parallel --results nanopolish.results -P 7 /data/software/nanopolish_gpu/nanopolish variants --consensus -o gpu/polished.{1}.vcf -w {1} -r barcode02_guppy.fastq -b test.sorted.bam  -g reads.paf.b02.racon1.fasta --gpu=2 -t 4 --min-candidate-frequency 0.1
i made an error in the cpu command because i used 80 threads in total (-P 20 and -t 4) but i have a system with with 72 threads in total.
i work with a systen with GTX1070 8gb of RAM.
Cheers
Luigi

@vellamike,
my idea was a bit different but i can try to make a work around.
i would like to use parallel with makerange.py and send to one GPU or another based on the fact that one process is finished. in simpler word, control which gpu finished a job and use it again.
just to be clear, is it possible in the future to have something like
python -m torch.distributed.launch --nproc_per_node=4 train_flipflop.py ...
like in the taiyaki script
taiyaki

Hi Luigi, yes this should be possible, could you create a github issue
specifically for this?
On Tue, Oct 8, 2019 at 8:34 AM Luigi Faino<EMAIL_ADDRESS>wrote:

@vellamike https://github.com/vellamike,
my idea was a bit different but i can try to make a work around.
i would like to use parallel with makerange.py and send to one GPU or
another based on the fact that one process is finished. in simpler word,
control which gpu finished a job and use it again.
just to be clear, is it possible in the future to have something like
python -m torch.distributed.launch --nproc_per_node=4 train_flipflop.py ...
like in the taiyaki script
taiyaki https://github.com/nanoporetech/taiyaki
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/pull/661?email_source=notifications&email_token=AALYB7KD3NBLIKTLEYAFDELQNQZZZA5CNFSM4I5DU252YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEATGDJQ#issuecomment-539386278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALYB7KFCQFIFHAG4OT7IT3QNQZZZANCNFSM4I5DU25Q
.

@jts
This version now supports methylation aware polishing for the GPU.
The answers from CPU (left) and GPU (right) for multi-model (-q dam,dcm) considerably match.

The answers from single-model also considerably match.

Experiment details
Reference:
ftp://ftp.ensemblgenomes.org/pub/bacteria/release-45/fasta/bacteria_0_collection/escherichia_coli_str_k_12_substr_mg1655/dna/Escherichia_coli_str_k_12_substr_mg1655.ASM584v2.dna.toplevel.fa.gz
Reads:
https://nanopore.s3.climb.ac.uk/Zymo-GridION-EVEN-BB-SN.fq.gz
https://nanopore.s3.climb.ac.uk/Zymo-GridION-EVEN-BB-SN_signal.tar
Commands:
minimap2 -ax map-ont -t32 ecoli_k12_ms1655.fa Zymo-GridION-EVEN-BB-SN.fq > Zymo-GridION-EVEN-BB-SN.sam
samtools sort  Zymo-GridION-EVEN-BB-SN.sam >  Zymo-GridION-EVEN-BB-SN.bam
samtools index  Zymo-GridION-EVEN-BB-SN.bam
~/nanopolish/nanopolish index Zymo-GridION-EVEN-BB-SN.fq -d  Zymo-GridION-EVEN-BB-SN

Then regions were extracted for region Chromosome:200000-202000
./nanopolish variants --consensus -o $DATADIR/polished_cpu_single_model.vcf -w "Chromosome:200000-202000" -r $DATADIR/reads.fasta -b $DATADIR/reads.bam -g $DATADIR/draft.fa
 ./nanopolish variants --consensus -o $DATADIR/polished_gpu_single_model.vcf -w "Chromosome:200000-202000" -r $DATADIR/reads.fasta -b $DATADIR/reads.bam -g $DATADIR/draft.fa --gpu=1
./nanopolish variants --consensus -o $DATADIR/polished_cpu_multi_model.vcf -w "Chromosome:200000-202000" -r $DATADIR/reads.fasta -b $DATADIR/reads.bam -g $DATADIR/draft.fa   -q dcm,dam
./nanopolish variants --consensus -o $DATADIR/polished_gpu_multi_model.vcf -w "Chromosome:200000-202000" -r $DATADIR/reads.fasta -b $DATADIR/reads.bam -g $DATADIR/draft.fa --gpu=1  -q dcm,dam

The vcf files are here:
vcfs.zip

@jts
Tested on the human genome as well for chr20:5000000-5050000 from the methylation calling tutorial dataset. VCF outputs significantly match for CPU and GPU for both single-model and multi-model.


Follow-up to "Implement unix socket forwarding"

Follow up to #369

$ DOCKER_HOST=unix://$HOME/docker.sock docker run -it --rm alpine
docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:385: applying cgroup configuration for process caused: error while starting unit "docker-f635a58e3ec4f5ff87cdd7b16054f26776c0aba0d6db961c1f1bf3c12cf1fd46.scope" with properties [{Name:Description Value:"libcontainer container f635a58e3ec4f5ff87cdd7b16054f26776c0aba0d6db961c1f1bf3c12cf1fd46"} {Name:Slice Value:"user.slice"} {Name:PIDs Value:@au [5181]} {Name:Delegate Value:true} {Name:MemoryAccounting Value:true} {Name:CPUAccounting Value:true} {Name:IOAccounting Value:true} {Name:TasksAccounting Value:true} {Name:DefaultDependencies Value:false}]: read unix @->/run/systemd/private: read: connection reset by peer: unknown.
ERRO[0000] error waiting for container: context canceled

😞

Just out of curiosity, why is dbus-user-session required? Doesn't loginctl enable-linger already do everything needed to keep the daemon running?

Because runc needs to connect to dbus
https://github.com/moby/moby/issues/42793
https://github.com/opencontainers/runc/pull/3186

Because runc needs to connect to dbus

So why does it work for me even without dbus-user-session with just #369:
$ limactl start --tty=false examples/docker.yaml
[...]
$ DOCKER_HOST=unix://$HOME/docker.sock docker run -it --rm alpine uname -a
Linux 9d6f08041b9f 5.13.0-14-generic #14-Ubuntu SMP Mon Aug 2 12:43:35 UTC 2021 x86_64 Linux

So why does it work for me even without dbus-user-session with just #369:

Looks like it is installed already:
root@lima-docker:~# apt -qq list dbus-user-session
dbus-user-session/impish 1.12.20-2ubuntu2 amd64
root@lima-docker:~# apt install aptitude
[...]
root@lima-docker:~# aptitude why dbus-user-session
i   ubuntu-server Depends  dirmngr
i A dirmngr       Suggests dbus-user-session

dbus-user-session wasn't installed in http://cloud-images.ubuntu.com/impish/20211014/impish-server-cloudimg-amd64.img (sha256:fce2af66787ccfed5eef0de2ac38eaedacdd3d8ee8a645c26d5a736559265478) when containerd.user is set to false.
Maybe your cache revision is different.

Maybe your cache revision is different.

It is:
$ ag -G url impish
download/by-url-sha256/ac74da77a6828e35de7edaa06fdbb33d12ef97cce2726550017e3c1066c88fb1/url
1:https://cloud-images.ubuntu.com/impish/current/impish-server-cloudimg-amd64.img

Still weird that the installed packages are changing, but I think there is little value in digging any deeper....

Even weirder that my cached version seems older, but has a package that your version seems to be missing:
$ ls -l ~/Library/Caches/lima/download/by-url-sha256/ac74da77a6828e35de7edaa06fdbb33d12ef97cce2726550017e3c1066c88fb1
total 1105208
-rw-r--r--  1 jan  staff  565051392  7 Sep 17:09 data
-rw-r--r--  1 jan  staff         79  7 Sep 17:08 url

Not sure how to determine the original download URL; I guess we don't store the endpoint of a redirect chain.


Table: add breakpoint

Breaking change:

Table requires prop breakpoint, used to trigger the sticky column layout.

Preview is available here:http://design-system-pr106.previews.kube001.services.stellar-ops.com/


Add option to change items aftewards

I'm using Yubikeys extensively (go 2FA!) and I would love to have the option to edit each item after I added them.
For example, it would be nice to be able to rename them, so I can name them after the same schema (e.g. "project 1 - appname - user"). Unfortunately I didn't plan ahead when naming my items so now I have quite a few named differently and it's a) quite a mess and b) hard to find the right code for my login.
Another thing is, to be able to activate (or maybe even deactivate, if possible) the "require tap to generate code" after creation. Having to remove and re-add an item everytime I want to change something is a bit tedious.

It is currently not possible to edit the name or settings for a credential stored on the YubiKey, the protocol does not allow it.

Is it possible to make a request to change the protocol to allow at least just renaming?

@nathaniel-holder Thank you for your feedback, this is something we will consider for the future.


Draft: Fix misc errors

Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (1819301) 32.91% compared to head (9488c7e) 32.93%.

Files
Patch %
Lines

ros_bt_py/src/ros_bt_py/package_manager.py
0.00%
11 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #58      +/-   ##
==========================================
+ Coverage   32.91%   32.93%   +0.01%
==========================================
  Files          37       37
  Lines        5405     5405
  Branches     1249     1249
==========================================
+ Hits         1779     1780       +1
+ Misses       3558     3557       -1
  Partials       68       68

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rename tests

Renames the test names to match the blueprint names so the tgz file and the terraform backend state file can be uploaded to the same folder.

/gcbrun


Update dependencies, keep up with API changes

bump github.com/containerd/containerd from v1.7.11 to v1.7.12
bump github.com/docker/docker from v24.0.7 to v25.0.1
bump github.com/fsouza/go-dockerclient from v1.9.7 to v1.10.1
bump github.com/containers/storage from v1.51.0 to v1.52.0
bump github.com/moby/buildkit from v0.11.4 to v0.12.4

The github.com/docker/docker/api/types.AuthConfig type was moved to the github.com/docker/docker/api/types/registry package, and the type alias that allowed us to not care has gone, so our declarations for variables of that type need to be updated.

This blocks https://github.com/containers/buildah/pull/5301.  I expect to tag a release once this is merged.

FWIW, Docker is not using Go modules the usual way, meaning go github.com/docker/… does not update transitive dependencies.
The dependencies are managed in a file named vendor.mod; I usually copy&paste the whole contents into the …/docker/docker caller’s go.mod, run go mod tidy, and then manually clean up.
Doing so here causes a few more (fairly minor) updates.

Oh, I wasn't aware.  Worth doing since there's no automation in this repository for it.

@nalind tests aren't hip

Unit tests are waiting on https://github.com/openshift/release/pull/48288.  I don't have the privileges to see what the errors are in the Go 1.21 build in Travis, but it's passing with 1.20.

Can we keep it at 1.20 for now?

I guess.

/test unit

Unit tests are passing now that https://github.com/openshift/release/pull/48288 is merged, and Travis is only testing with 1.20.
We should probably move off Travis to something where the permissions allow us to view failure logs.


Cannot find package 'vite' (when using pnpm)

Qwik Version
0.0.39
Operating System (or Browser)
macOS
Node Version (if applicable)
18.3
Which component is affected?
Starters / CLI
Expected Behaviour
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite' imported from /xxx/node_modules/.pnpm/@builder.io+qwik<EMAIL_ADDRESS>    at new NodeError (node:internal/errors:377:5)
    at packageResolve (node:internal/modules/esm/resolve:910:9)
    at moduleResolve (node:internal/modules/esm/resolve:959:20)
    at defaultResolve (node:internal/modules/esm/resolve:1174:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:605:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:318:18)
    at ESMLoader.import (node:internal/modules/esm/loader:404:22)
    at importModuleDynamically (node:internal/modules/esm/translators:106:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)
    at sys.strictDynamicImport.sys.dynamicImport (file:///xxx/node_modules/.pnpm/@builder.io+qwik@0.0.39/node_modules/@builder.io/qwik/optimizer.mjs:501:57)

Actual Behaviour
No error.
Additional Information
Relies on hoisting. @builder.io/qwik should depend explicitly on vite as a peer dep.

can you submit a PR?

@vjpr May I ask how have you dealt with this? Pulling hairs right now

https://pnpm.io/package_json#pnpmpackageextensions

Thank you very much! My problem is that vite is installed, but one of its plugins can't find it o.0

Hi @vjpr
Gave it a spin with 0.12.0 and didn't discover any issue like this. Do you still have any issues or could this be closed?

@vjpr did you have time to dbl check it on your end? i'd suggest to close the issue by now and create a new one if needed? cc @shairez 🙏

yeah I think pnpm works now seamlessly
thanks for the ping (and triaging) @zanettin
closing
@vjpr feel free to reopen / recreate if it happens again


Easier JS dependencies

I'm not sure if you have plans to solve this but it would be nice if it was easier to use the javascript dependencies in this project.
Ideally it would be a webjar specified using jsDependencies. I'm not sure if that is possible or not and it may be that there would be multiple webjars for each each dependency? Other problems are, how do you even create the correct webjars? (I noticed there is material-ui webjar but it is an npm webjar, so I assume that won't work.)
This would be nice because everything would end up in scalajs -jsdeps.js
Anyway I needed something that worked now. I looked for existing sbt wrappers around javascript build tools but there doesn't really seem to be much out there.
I ended up creating a small sbt task that integrates with the sbt-web pipeline and calls out to npm (and webpack). I've only tested Material UI.
Task key
val packageReactComponents = TaskKey[Seq[File]]("packageReactComponents", "Package Scala.js React Components")

Project settings
    packageReactComponents := {
      val filename = "sjs-components.js"

      val outPath = WebKeys.webTarget.value / "sjscomponents"
      val outFile = outPath / filename
      val workingDir = baseDirectory.value

      if ( ! outFile.exists()) {
        val commandPrefix = sys.props("os.name").toLowerCase match {
          case os if os.contains("win") => Seq("cmd", "/C")
          case _ => Seq()
        }

        val installCommand = commandPrefix ++ Seq("npm", "install")
        println(s"${installCommand.mkString(" ")}")
        Process(installCommand, workingDir) !!

        val runCommand = commandPrefix ++ Seq("npm", "run", "build", "--", "--output-file", filename, "--output-path", outPath.getAbsolutePath)
        println(s"Creating $filename [${runCommand.mkString(" ")}]")
        Process(runCommand, workingDir) !!
      }

      Seq[File](outFile)
    },
    (sourceGenerators in Assets) <+= packageReactComponents

main.js
var mui = require("material-ui"),
    injectTapEventPlugin = require('react-tap-event-plugin');

injectTapEventPlugin();

window.mui = mui;

package.json
{
  "name": "",
  "version": "0.1.0",
  "description": "",
  "scripts": {
    "build": "webpack --config webpack.config.js"
  },
  "devDependencies": {
    "webpack": "^1.9.10"
  },
  "dependencies": {
    "material-ui": "^0.9.0",
    "react-geomicons": "^2.0.4",
    "react-select": "^0.5.1",
    "react-tagsinput": "^1.3.5",
    "react-tap-event-plugin": "^0.1.7",
    "svg-loader": "0.0.2"
  }
}

webpack.config.js
'use strict';

var webpack = require('webpack');
var CommonsChunkPlugin = webpack.optimize.CommonsChunkPlugin;

module.exports = {
    entry: {
        mainpage: './main.js'
    },
    output: {
    },
    externals: {
      "react": "React",
      "react/addons": "React"
    },
    plugins: [
        new webpack.NoErrorsPlugin(),
        new CommonsChunkPlugin({
            name: "mainpage"
        })
    ]
};

Note the use of externals here, that is because I am depending on the React webjar which already ends up in -jsdeps.js
I'm not sure if there will end up being any gotchas with this (ie dependency ordering issues). (Not sure if it will work long term). Maybe I'll end up not using the React webjar and bundle the one with webpack.
Finally I just include the generated js in my play template
<script src="@routes.Assets.versioned("sjs-components.js")"></script>

I don't know if there is a better way. I think the tooling in this area needs some work still if it has to be done through npm could watch this space and use something like grunt: https://github.com/sbt/sbt-web/issues/27
I'm not that familiar with these tools though.

indeed its a painful issue at the moment . not only for this project, any scala.js project that interop with javascript .
Its out of scope for this project ,it should belong to sbt-web or sbt plugins/wrappers or scala.js jsDeps .... .
I prefer using js world build tools for managing javascript dependencies and builds.. and sbt for scala.js compilation so that we will get best from both worlds !, this approach looks like more work at the begining as there is a learning curve but in long run it'll pay off!
Caution : I have very limited knowledge in sbt/sbt-web so i may be wrong

Fair enough. I guess it really does boil down to needing a bridge from js build tools to something like sbt-web which isn't something that should be solved by this project necessarily. It was just quite painful getting started with the project when I'm used to not having to use anything outside sbt.
This issue may just be a useful reference for a quick hack to get started using sbt-web for someone else.
Hopefully someone writes a nice js build tool wrapper in sbt-web, in which case it could be documented here in the future.

It was just quite painful getting started with the project when I'm used to not having to use anything outside sbt

totally agree , many people in gitter channel also  expressed same concern , wish i have powers to make  a smooth path :(


repair_timing improvements

Don't catch errors from repair_timing. There are many reasons it might
fail and reporting "utilization limit is reached" is just confusing.

Handle options with a list.

These were a couple of suggestions from @jjcherry56


Correct table numbering.

Would it be a good idea to add Group Table info to this?
On Tue, Jan 17, 2017 at 4:39 PM, Josh Bailey<EMAIL_ADDRESS>wrote:

Merged #377 https://github.com/REANNZ/faucet/pull/377.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/377#event-926740560, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABmf8yIajbYWRSv4h1K-JTSSl0V5UV7Uks5rTV8ugaJpZM4LmV4M
.

Certainly, once merged and tested (we are in a freeze heading into NZNOG).
On Jan 18, 2017 1:48 PM, "shivarammysore"<EMAIL_ADDRESS>wrote:

Would it be a good idea to add Group Table info to this?
On Tue, Jan 17, 2017 at 4:39 PM, Josh Bailey<EMAIL_ADDRESS>wrote:

Merged #377 https://github.com/REANNZ/faucet/pull/377.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/377#event-926740560, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABmf8yIajbYWRSv4h1K-
JTSSl0V5UV7Uks5rTV8ugaJpZM4LmV4M>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/377#issuecomment-273348692, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEgZ17-B_CauQzCF9fbaUD9hutHl7em0ks5rTWFjgaJpZM4LmV4M
.


Update airframe to 24.12.0

About this PR
📦 Updates org.wvlet.airframe:airframe from 24.4.3 to 24.12.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.wvlet.airframe", artifactId = "airframe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.wvlet.airframe", artifactId = "airframe" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #169.


Fix issues

Add a package-lock.json for reproducible, deterministic builds.
Use a static import to fix #1.
Use min-height for the sticky footer to fix #2.
Adjust the margins within the footer to fix #3. You can tweak the numbers here to get just the right look. I tried to approximate the screenshot.

I have no idea why your two earlier commits are in this PR… I haven’t touched them!

I see this is the wrong branch to create a PR against!


Snapshot not working

Description
Snapshots don't seem to work.
const { form, errors, enhance, capture, restore } = superForm(data.form);
export const snapshot = { capture, restore };

All other features of Superforms works so the setup is correct. Tainted message on navigation should be disabled according to the docs. It is not, and snapshot is not taken.
Node v20.10.0
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Ah ok, I misunderstood the docs.
After disabling though snapshots still don't work for me. Can't think of anything other than I have beforeNavigate and afterNavigate set up in my layout for smooth scrolling. Can those interfere with snapshots?

It's hard to tell, I recommend creating a MRE here, then I can take a closer look if you are able to reproduce it: https://stackblitz.com/edit/sveltekit-superforms-1-testing?file=src%2Froutes%2F%2Bpage.server.ts,src%2Froutes%2F%2Bpage.svelte
(I hope it's possible to do with Stackblitz)

I couldn't reproduce it. Closing for now.


Pipeline Table Kebab + Delete Pipeline

Closes: #1063
Description

Add the Pipeline Kebab (create run doesn't do anything) and the Delete Pipeline modal.

How Has This Been Tested?

Have a Pipeline => Delete.
Test Impact

No tests on first pass.
Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

/cc @kywalker-rh @vconzola @Gkrumbach07 @lucferbux

/lgtm
walked through with @andrewballantyne


using PyPlot fails to initialize gives  ImportError('No module named version',)

Not sure whether this is more suitable for PyCall or PyPlot
Julia Version 0.4.2-pre+18 (2015-11-26 08:03 UTC)
I have just switched to using anaconda.
I  rebuilt PyCall
ENV["PYTHON"]=""
Pkg.build("PyCall")

Now when I do :
using PyPlot

INFO: Installing matplotlib via the Conda matplotlib package...
Fetching package metadata .......
Solving package specifications: ..........

\# All requested packages already installed.
\# packages in environment at /home/nic/.juliapkgs/v0.4/Conda/deps/usr:
\# matplotlib                1.5.1               np111py27_0
ERROR: InitError: PyError (:PyImport_ImportModule) <type 'exceptions.ImportError'>
ImportError('No module named version',)
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/matplotlib/__init__.py", line 122, in <module>
    from matplotlib.cbook import is_string_like, mplDeprecation, dedent, get_label
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/matplotlib/cbook.py", line 33, in <module>
    import numpy as np
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/numpy/__init__.py", line 175, in <module>
    from .version import git_revision as __git_revision__

 [inlined code] from /home/nic/.juliapkgs/v0.4/PyCall/src/exception.jl:81
 in pyimport at /home/nic/.juliapkgs/v0.4/PyCall/src/PyCall.jl:341
 in pyimport_conda at /home/nic/.juliapkgs/v0.4/PyCall/src/PyCall.jl:432
 in __init__ at /home/nic/.juliapkgs/v0.4/PyPlot/src/PyPlot.jl:212
 in _require_from_serialized at loading.jl:84
 in _require_from_serialized at ./loading.jl:109
 in require at ./loading.jl:219
during initialization of module PyPlot

That's odd, it looks like a problem in Matplotlib itself.  If you run the Conda Python (in /home/nic/.juliapkgs/v0.4/Conda/deps/usr/bin/python, I think?) can it import matplotlib?

What does versioninfo() print?  Have you tried running Pkg.update() in case you have out-of-date packages?

thanks for help, yes, so the same error message comes out of the python console doing import matplotlib.
>>> import matplotlib
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/matplotlib/__init__.py", line 122, in <module>
    from matplotlib.cbook import is_string_like, mplDeprecation, dedent, get_label
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/matplotlib/cbook.py", line 33, in <module>
    import numpy as np
  File "/home/nic/.juliapkgs/v0.4/Conda/deps/usr/lib/python2.7/site-packages/numpy/__init__.py", line 175, in <module>
    from .version import git_revision as __git_revision__
ImportError: No module named version

Updated all packages and have the same thing
Tried a few things like reinstalling Conda.jl and reinstalling matplotlib using Conda.rm/add
versioninfo()
Julia Version 0.4.2-pre+18
Commit eb31eef (2015-11-26 08:03 UTC)
Platform Info:
  System: Linux (x86_64-linux-gnu)
  CPU: Intel(R) Core(TM) i7-2640M CPU @ 2.80GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

Seems like a problem with the Conda installation, then.   Maybe you have some environment variable set that is screwing up your Conda install?  (Type env in the shell and look for anything Python-related.)
cc @Luthaf

just to add - the only thing I can see is a BYOBU_PYTHON=python3, which I guess is set when I start byobu (screen like window manager in ubuntu). Might be something in this - a post on stackoverflow here with similar error msg http://stackoverflow.com/questions/32423793/importerror-no-module-named-version comes down to python3/2 conflict. I tried reinstalling conda.jl and matplotlib through Conda.jl - outside of byobu where this env variable doesn't exist - but doesn't seem to help. Decided to point pycall to a local anaconda python install outside of Conda.jl and all works fine there.

Probably you should file Conda issue since the problem seems independent of PyPlot.


types-{toml, typed-ast}: Join maintainer team

As requested.

On commit message would be best "nbraud" instead of "myself".

I'm not used to this process. It is listing an extra commit:
Merge pull request #3 from nbraud/pr/140627
Did I do something wrong?

I'm not used to this process. It is listing an extra commit: Merge pull request #3 from nbraud/pr/140627
Did I do something wrong? Any tip? At nixpkgs they usually complain if there are extra commits.

  You can rebase your branch to get rid of it  :)


Dapr instances started by Sidekick doesn't show in Dashboard

Expected Behavior
Dapr instances launched by Sidekick show show in Dapr Dashboard
Actual Behavior
Dapr Dashboard is not showing any application in the Dapr Applications table
Steps to Reproduce the Problem

Launch a ASP.Net Core Web API with Sidekick enabled.
Start Dapr Dashboarddapr dashboard

Open Dapr Dashboard in browser http://localhost:8080
Check that Dapr application is not listed

Hey @fbridger thanks for checking out sidekick :smile: - the reason this doesn't currently work is because when running in standalone mode the dashboard identifies active/running dapr apps by ultimately scanning for instances of the dapr cli process (dapr.exe) - as sidekick circumvents the use of the cli all together by only using the runtime executable (daprd.exe) then it is missed by this process scan.
dashboard getStandaloneInstances() - https://github.com/dapr/dashboard/blob/master/pkg/instances/instances.go#L435
standalone.List() - https://github.com/dapr/cli/blob/master/pkg/standalone/list.go#L52
For this to work a change would need to be made to the code base to allow identification of dapr instances via runtime alone (daprd.exe) removing the cli as a dependency..

Got it. Thanks for the detailed explanation.
I've started using Sidekick to be able to improve the development experience in Visual Studio when using Dapr. Incredible work done here! Thanks for allowing us to make use of it!

Wow, this explains why my stuff was no showing up in the dashboard also (pre sidekick).
Do you know if any issue has been opened on the dapr side for this? seems like the dashboard scan should be based on something required, not a helper that runs the required stuff.

Wow, this explains why my stuff was no showing up in the dashboard also (pre sidekick).
Do you know if any issue has been opened on the dapr side for this? seems like the dashboard scan should be based on something required, not a helper that runs the required stuff.

Not that I know of, though I can see you've raised an issue in the dapr/dashboard repo 👍

fingers crossed !

here is the issue opened on the dashboard fyi ...
https://github.com/dapr/dashboard/issues/163


Release Checklist 2.10.0-RC1

OpenShift Pipeline

[ ] cStor
[x] Jiva
[x] cStor-csi
[x] Jiva-csi
[x] LocalPV

Konvoy Pipeline

[x] cStor
[x] Jiva
[x] cStor-csi
[x] Jiva-csi
[x] LocalPV

Native K8s Pipeline

[x] LVM-LocalPV
[x] ZFS LocalPV

Upgrade Pipelines [spc/cstor/jiva]

[x]  1.9 to 2.10.0-RC1
[x] 1.10.0 to 2.10.0-RC1
[x] 1.11.0 to 2.10.0-RC1
[x] 1.12.0 to 2.10.0-RC1
[x] 2.0.0 to 2.10.0-RC1
[x] 2.1.0 to 2.10.0-RC1
[ ] 2.2.0 to 2.10.0-RC1
[ ] 2.3.0 to 2.10.0-RC1
[ ] 2.4.0 to 2.10.0-RC1
[ ] 2.5.0 to 2.10.0-RC1
[ ] 2.6.0 to 2.10.0-RC1
[x] 2.7.0 to 2.10.0-RC1
[x] 2.8.0 to 2.10.0-RC1
[ ] 2.9.0 to 2.10.0-RC1

cspc/cstor csi volume upgrade

[x] 1.10.0 to 2.10.0-RC1
[x] 1.11.0 to 2.10.0-RC1
[x] 1.12.0 to 2.10.0-RC1
[x] 2.0.0 to 2.10.0-RC1
[x] 2.1.0 to 2.10.0-RC1
[x] 2.2.0 to 2.10.0-RC1
[x] 2.3.0 to 2.10.0-RC1
[x] 2.4.0 to 2.10.0-RC1
[x] 2.5.0 to 2.10.0-RC1
[x] 2.6.0 to 2.10.0-RC1
[x] 2.7.0 to 2.10.0-RC1
[x] 2.8.0 to 2.10.0-RC1
[x]  2.9.0 to 2.10.0-RC1

ZFS Upgrade Pipelines

[ ] 1.0.0 to 1.8.0-RC1
[ ] 1.0.1 to 1.8.0-RC1
[ ] 1.1.0 to 1.8.0-RC1
[ ] 1.2.1 to 1.8.0-RC1
[ ] 1.3.0 to 1.8.0-RC1
[ ] 1.4.0 to 1.8.0-RC1
[ ] 1.5.0 to 1.8.0-RC1
[x] 1.6.0 to 1.8.0- RC1
[x] 1.7.0 to 1.8.0-RC1

Migration spc pool to cspc and cstor volume to cstor csi volume

[x] 1.12.0 to 2.10.0-RC1
[x] 2.0.0 to 2.10.0-RC1
[x] 2.1.0 to 2.10.0-RC1
[x] 2.2.0 to 2.10.0-RC1
[ ] 2.3.0 to 2.10.0-RC1
[ ] 2.4.0 to 2.10.0-RC1
[ ] 2.5.0 to 2.10.0-RC1
[ ] 2.6.0 to 2.10.0-RC1
[x] 2.7.0 to 2.10.0-RC1
[x] 2.8.0 to 2.10.0-RC1
[ ] 2.9.0 to 2.10.0-RC1

RC1 images are available
openebs/node-disk-exporter:1.5.0-RC1 ✔
openebs/node-disk-operator:1.5.0-RC1 ✔
openebs/node-disk-manager:1.5.0-RC1 ✔

openebs/zfs-driver:1.8.0-RC1 ✔

openebs/lvm-driver:0.6.0-RC1 ✔

openebs/linux-utils:2.10.0-RC1 ✔
openebs/jiva:2.10.0-RC1 ✔
openebs/jiva-operator:2.10.0-RC1 ✔

openebs/provisioner-localpv:2.10.0-RC1 ✔

openebs/cstor-istgt:2.10.0-RC1 ✔
openebs/cstor-webhook:2.10.0-RC1 ✔
openebs/cstor-pool-manager:2.10.0-RC1 ✔
openebs/cstor-volume-manager:2.10.0-RC1 ✔
openebs/cspc-operator:2.10.0-RC1 ✔
openebs/cvc-operator:2.10.0-RC1 ✔
openebs/openebs-k8s-provisioner:2.10.0-RC1 ✔
openebs/velero-plugin:2.10.0-RC1 ✔
openebs/snapshot-provisioner:2.10.0-RC1 ✔
openebs/snapshot-controller:2.10.0-RC1 ✔
openebs/admission-server:2.10.0-RC1 ✔
openebs/m-upgrade:2.10.0-RC1 ✔
openebs/m-exporter:2.10.0-RC1 ✔
openebs/cstor-volume-mgmt:2.10.0-RC1 ✔
openebs/cstor-pool-mgmt:2.10.0-RC1 ✔
openebs/m-apiserver:2.10.0-RC1 ✔
openebs/cstor-pool:2.10.0-RC1 ✔
openebs/migrate:2.10.0-RC1 ✔
openebs/upgrade:2.10.0-RC1 ✔
openebs/cstor-csi-driver:2.10.0-RC1 ✔

PR / commit for RC1 operator yaml

While Migrate the SPC pool. Migration job got completed succesfully. in the logs getting the messages like below

I0611 10:38:49.783443       1 cstor_pool.go:91] Make sure to migrate the associated PVs, to list CStorVolumes for the PVs which are pending migration use `kubectl get cstorvolume.openebs.io -n openebs -l openebs.io/storage-pool-claim=cstor-block-disk-pool`, and to list CStorVolumes for the migrated/CSI PVs use `kubectl get cstorvolume.cstor.openebs.io -n openebs`

Need to fix the log message.

@nsathyaseelan Raised a fix for the above issue
https://github.com/openebs/upgrade/pull/112


Fix minor typos

This revision includes:

Fix minor typos in codes and docs

Congratulations on the first contribution in sqlx-ts! 🚀


Allow molecule testing to run natively under zuul

In order to improve the UX when running molecule under Zuul CI, it would be useful if zuul can detect which test sequences are enabled and run each of them as a separated zuul task.
This would allow to easily create zuul jobs that run specific molecule scenarios, ones that would produce an output similar with command line usage.
Current use usually involves using tox to install molecule and using pytest-html to encapsulate execution of molecule and produce an ANSI-enable HTML report. This setup can be seen bit complex for many users.
In order to be able to implement this, zuul needs to ask molecule about which steps are setup in current test sequence, likely by calling molecule matrix -s scenario_name.

Could zuul be informed about which scenario is running similar to the Github/Travis/GitLab implementation in #2967 ?

That is harder to implement if we want molecule to appear more natively integrated into zuul as we need to add some ansible module that returns the steps needed to run for particular scenario and make zuul loop over them using ansible. There are lots of issues around, especially as logic around what happens when a step fails, molecule itself knows to run destroy to perform cleanup but zuul would likely not.
For the moment I am focusing on producing HTML reports with molecule 3.2, a feature already present on master branch. If these are well visible under zuul it may be enough for a while.
This being said, if someone wants to start working on this, I will be more than happy to assist and facilitate any kind of molecule internal changes that could make it easier.

Is this still relevant re: https://github.com/ansible-community/molecule/pull/2789?

Is this still relevant re: https://github.com/ansible-community/molecule/pull/2789?

It only matters if others are using ansible under Zuul. Molecule itself doesn't need it, so it is very unlikely to get much effort from molecule devs. (my opinion - I can't speak for any official molecule devs)

It only matters if others are using ansible under Zuul. Molecule itself doesn't need it, so it is very unlikely to get much effort from molecule devs. (my opinion - I can't speak for any official molecule devs)


Add annotations for osbs bundle build

These annotations will be copied into the midstream image file and then be used by osbs when building the operator bundle image.

/lgtm

/label docs-approved
/label px-approved
/label qe-approved


Enrich HTML needed on Biography and Journal tab

https://discord.com/channels/1167985253072257115/1170527390838034552/1170527390838034552
Looks like Document links and inline rolls are not enriched on these tabs for either NPC or PC sheets

For PCs, I've got enrichment on the Journal tab for all sections, but the biography tab only has enrichment on the Background/Bio section:

For NPCs, no enrichment at all,

Enrichment complete!


Table tree/sorting/... state is lost every time a Dialog is open from a clickable cell

Hello all,
Thanks for keeping this project alive !
I am using latest version of @material-table/core.
I have a table with custom rendering in a column, that displays a clickable icon. Every time it is clicked, a state is changed to open a Dialog.
However, everytime it is done, the state of the table is lost, i.e. if any column sortering has been set up, it is lost. Similarly, I am also using tree data, and if some rows have been expanded, everything is collapsed like in initial state.
Do you have any idea of how to avoid this behaviour and keep the current table state ?

Hello! Hopefully this will be fixed today. There is currently another issue open #48 where we pinpointed the root cause.
We will be putting all updates on #48 so I'm going to close this one out.
Thanks for bringing this to our attention! We apologize for the inconvenience.

Hello! Hopefully this will be fixed today. There is currently another issue open #48 where we pinpointed the root cause.
We will be putting all updates on #48 so I'm going to close this one out.
Thanks for bringing this to our attention! We apologize for the inconvenience.

@Domino987 another issue in regards to the table losing state. Looks like it's related to #48

@Domino987 another issue in regards to the table losing state. Looks like it's related to #48

@oze4 Probably yes. This might cause it. The change was introduced to respond to changes to the default prop changes, like initial page etc. If we remove this, these changes of the prop during the lifecycle of the table will be ignored. Maybe we can think of a way to get around it.

@oze4 Probably yes. This might cause it. The change was introduced to respond to changes to the default prop changes, like initial page etc. If we remove this, these changes of the prop during the lifecycle of the table will be ignored. Maybe we can think of a way to get around it.

Sounds good to me.  In that case I will reopen this issue.

Sounds good to me.  In that case I will reopen this issue.

Ok thanks a lot for your awesome work for keeping this project up-to-date.
Cheers guys

Ok thanks a lot for your awesome work for keeping this project up-to-date.
Cheers guys

@Domino987 so this was introduced in case someone wants to start on page 2 (or 5 or 103 or whatever) vs page 1? I'm not sure I follow entirely.

@Domino987 so this was introduced in case someone wants to start on page 2 (or 5 or 103 or whatever) vs page 1? I'm not sure I follow entirely.

All updates will be on https://github.com/material-table-core/core/issues/59
Closing.

All updates will be on https://github.com/material-table-core/core/issues/59
Closing.


fix rabbit_mq

fix versions

Thank you for the support of the project. This is your first PR, welcome to our community. I have verified your changes on the website and everything is correct.


Remove ".generated" and change file name, HOW?

Hello everybody,
I am using Sourcery to build a script to create a project template Architecture, for example, I run a script called "/.create-feature.sh Login" and it will create the folder and class structure needed to start a new feature, which is something like CleanSwift already does. it seems like:
Feature
-- Login
-- ViewControllers -> LoginViewController.swift
-- ViewModels -> LoginViewModels
-- etc...
My problem is the Sourcery generates every file with the "fixname.generated.swift", so:

I want to remove the ".generated." from the file name.
I'd like to specify the name of my file base on the parameter which I pass when the script is executed.

This is because my idea is to auto-generate a structure that will work as a guide to accomplish the architecture thing.
Any help will be appreciated.
Thank you for all

per file annotation in docs https://cdn.rawgit.com/krzysztofzablocki/Sourcery/master/docs/writing-templates.html#per-file-code-generation

Thank you so much, this solved my problem, you saved my life hahaha.

One last question, I promise,
I am trying to link the files to the project, but I looked in the documentation and find only the option when you use the config file and when you use this option you can't use the flags to pass parameters, my script looks like:
sourcery \
--args feature="$FEATURE_NAME" \
--output "$FEATURE_LAYER_PRESENTATION/ViewController" \
--sources "$FEATURE_CONTROLLER_TEMPLATE" \
--templates "$FEATURE_CONTROLLER_TEMPLATE"

So you know some way to the sourcery acepts parameters and config file or some flag to link files to project.
Thank you so much.

I don't really use link feature, maybe @ilyapuchka knows?

we are limited on number of command line parameters we can have, so some more complicated configurations are available only through config files.

Speaking of your use case I use Xcode templates for that without any issues for quite some time already (with a git hook that checks if local templates are up to date with those stored in the repo)

Hello @ilyapuchka, thank you for your response.

we are limited on number of command line parameters we can have, so some more complicated configurations are available only through config files.

I tried to mix the yaml with the params, but if the Sourcery finds the YAML file he ignores the params, or if I omit some properties on YAML and pass by parameters on the command line does not work as well.

Speaking of your use case I use Xcode templates for that without any issues for quite some time already (with a git hook that checks if local templates are up to date with those stored in the repo)

Unfortunately, Xcode template doesn't solve my problem because I want to generate folders and some files on my project in one shot, the other reason I don't use Xcode to develop ahahahah, I use AppCode, so I am not sure if it will work.
But anyway, I am very grateful for your response guys.

I saw here the Appcode has the template as well, but not work the way I need =) .
Thank you for all


Support getting time entries started in a specific time range

Done https://github.com/ta9mi1shi1/toggl-go/commit/0d3836ca114bea3d66e311b090122178bba7469c


Fixing Issue 117 - Duplicate Record exceptions and consistent logging

@lidderupk - Fixed the caching issue we found today, plus the logging - see issue #119 for details.

Resolved with #17. Closing here.


Add replaceRelay and friend

We've found certain interpreters that want to be implemented in terms of other interpreters; however, if those interpreters themselves have Member constraints, they will leak out into the type signature.
replaceRelay allows us to rewrite the head of the effects in terms of some other effect which need not exist in the effect list.  This lets us get around the above issue, and provide leakless abstractions for interpreters.

Thanks!

Can we generalize this so that an effect can be implemented using multiple intermediary effects?

@liskin I’ve been looking into that a little bit. It’s possible, but it’s currently difficult for GHC to infer, and it requires use of type application or extremely verbose annotation. However, I think with generalized support for injective type families, tracked in GHC ticket #10832, it could be implemented without breaking type inference.


[Feature Request]: Create a new page for FAQ

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
There are very less FAQ and are on the same page ..I would like to create a new page for FAQ and  link it ti footer.
Use Case
It will enable user to clear simole doubts.
Benefits
It will enable users to solve simple doubts.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

do it ASAP...its been 3 days..


[FEA] unpin torchmetrics

🚀 Feature request
Would it be possible to unpin torchmetics and use some newer version, e.g. >=0.7?
Motivation
Seems there are some limitations/constraints on using other latest packages, see for example https://github.com/Lightning-AI/lightning/issues/14729
Your contribution
I think we can send a PR with this change.
Also, we could offer to use Ecosystem CI to gain some visibility on future compatibility
see Stay Ahead of Breaking Changes with the New Lightning Ecosystem CI

@karlhigley and @marcromeyn fyi.


support lib crate

I want to use this crate as a lib. Do you have any plans to support a lib crate?

No.

I have the same usage, @vuhe could you find an alternative?

I have the same usage, @vuhe could you find an alternative?

I have found a simple way to solve this problem:

You can use this crate get magnet hash.
Replace hash string to uppercase (only supported v1 sha1 hash).
Request https://itorrents.org/torrent/{torrent_hash}.torrent, {torrent_hash} is sha1 uppercase hash string.

This can solve most problems, but it does not support v2 torrent.

Thanks you :)


TextField with a lot of text (10k+ characters) is freezing the app on iPad

Details
TextField with a lot of text (10k+ lines) is freezing the app for couple of seconds. Freezing happens if you start typing after pasted long text, or if you try and scroll.
Here is the minimal reproducible example:
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Test'),
      ),
      body: const Padding(
        padding: EdgeInsets.all(20),
        child: TextField(
          maxLines: null,
        ),
      ),
    );
  }
}

Target Platform: iOS
Target OS version/browser: iPadOS 15.4
Devices: iPad Air 5th Gen, iPad Pro
Works smoothly on android and ios phones.

Hi @campovski
I'm going to close this issue in favor of https://github.com/flutter/flutter/issues/90063 because it already has the "P3" label (high priority) (please see https://github.com/flutter/flutter/issues/90063#issuecomment-1296495185).
So please follow up on it for further updates. You can leave there your comment and react an upvote to the original comment will help to raise the issue. Thank you!


Strange plant bug

the strange appears to be flashing in and out of hiding
https://user-images.githubusercontent.com/75093127/213285290-0f7c0f8f-bb90-49e2-b468-d1d856642bf3.mp4

I've changed around some of the code so it might be fixed in my latest dev build, but I've had multiple strange plants and have not been able to reproduce this. It looks like it happens while the plant is growing? It should still have the same NpcId though which means that
if (npcId == NpcID.STRANGE_PLANT) {
			return hideAllStrangePlant;
		}

should hide it though.
Will keep this open and will keep an eye out for it.

Still experiencing this same bug but with other random events
https://user-images.githubusercontent.com/75093127/213760798-87f607e2-998f-43fd-945c-e15df2b6b8ad.mp4
https://user-images.githubusercontent.com/75093127/213760864-ea2aa587-5e8e-44fe-aa82-46e4895df245.mp4

The code hasn't changed, so makes sense it hasn't changed (PR waiting for approval). However, I've never had this bug myself. Are you playing on the official runelite client, or some shady fork?

I'm playing the official runelite client through the Jagex launcher

nevermind
https://user-images.githubusercontent.com/75093127/213825327-120381b6-9f44-4369-832f-984dd5697ad3.mp4

Might be related to you being in combat; I'll have to check in the latest devbuild and also in combat. When I'm in combat (raids), randoms usually can't spawn. I'll let you know when the PR gets merged and then you can check again.

@pettrs Could you upload some screenshots? That might confirm my hypothesis (race-y behaviour).

A screenshot of the settings of Random Event Hider
A screenschot of the settings of core (default) Entity Hider
Thanks in advance!

I have entity hider disabled, and it's still happening

alright, I think I've been able to source down the issue. I noticed when I hide attackers (also what random events go under) it seems like when the attack isn't attacking you, like a random event, it flickers.
https://user-images.githubusercontent.com/75093127/213930502-05ccbe82-8273-486d-9172-4f616226a2ee.mp4

The client does indeed not know the difference between "combat" and "interaction", but it's really weird that you also see the attackers and even the 2D elements of players flicker. 3rd party plugins only have the ability to use the shouldDraw function from the RL API, so I'm afraid that's borked for you for some reason, e.g. different plugin interfering(?), bad implementation if you were on a fork etc. If you can get the flickering consistently with entity hider enabled (e.g. Npcs, 2D elements of players), I'd suggest trying safe mode for a while and seeing if it persists.
From RL discord:

Launch RuneLite in safe mode using the following command:
"%localappdata%\runelite\runelite.exe" --clientargs --safe-mode
This temporarily disables all 3rd party plugins which will allow you to confirm the issue is caused by the plugin and isn't a core RuneLite issue.
If the issue is caused by a 3rd party plugin, you should isolate which plugin it is and then uninstall the plugin.

I'm afraid that with the current info, it looks like it's not something I can fix (underlying problem, not a problem of this specific plugin), at least not while I haven't been able to recreate it myself (my entity hider also works perfectly). I'll let you know when the latest update has been merged; maybe that that'll fix it but I doubt it. I'll also try to keep an eye out myself to see if I can recreate this.

Im currently having this same issue with different random events as well.

@YvesW same kind of flickering like Pettrs has, with multiple different events. Core Entity Hider works as intended.

In both. While standing still and on move as well. Thank you!
Jan 31, 2023, 19:08 by @.***:

@YvesW https://github.com/YvesW>>  same kind of flickering like Pettrs has, with multiple different events. Core Entity Hider works as intended.

Is it only in combat, or also out of combat? I'll also give you a ping while the latest dev build has been merged, so you can try it out ans see if it still happens.
—
Reply to this email directly, > view it on GitHub https://github.com/YvesW/random-event-hider/issues/3#issuecomment-1410756669> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A5NSN2PZ6FATFVGYA2WWNVTWVFBJHANCNFSM6AAAAAAT7QNMIM> .
You are receiving this because you were mentioned.> Message ID: > <YvesW/random-event-hider/issues/3/1410756669> @> github> .> com>

@pettrs @ZeiZeiii The update has been merged; restart your client for it to take effect. As a sidenote, I tried to replicate it while afking some vyrewatch sentinels earlier and I could not get the random events to flicker at all.

Seems to be working accordingly now. Thank you sir! :)
Feb 3, 2023, 16:47 by @.***:

@pettrs https://github.com/pettrs>  > @ZeiZeiii https://github.com/ZeiZeiii>  The update has been merged; restart your client for it to take effect. As a sidenote, I tried to replicate it while afking some vyrewatch sentinels earlier and I could not get the random events to flicker at all.
—
Reply to this email directly, > view it on GitHub https://github.com/YvesW/random-event-hider/issues/3#issuecomment-1415976939> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A5NSN2NXWE6VI3FNAE5TPMDWVULB3ANCNFSM6AAAAAAT7QNMIM> .
You are receiving this because you were mentioned.> Message ID: > <YvesW/random-event-hider/issues/3/1415976939> @> github> .> com>


geyser: add more slot statuses like FirstShredReceived, CreatedBank

Problem
It's not possible to implement a fully compatible Solana/Agave WebSocket (PubSub) replacement based on geyser. We only have access to processed / confirmed / finalized but with WebSocket additionally we have access to FirstShredReceived / Completed CreatedBank / Dead (https://github.com/anza-xyz/agave/blob/v2.0.10/rpc-client-api/src/response.rs#L187-L221). For example in https://github.com/Block-Logic/ping-thing-client we rely on FirstShredReceived to benchmark transaction landing and we would like to switch to geyser based tools.
Proposed Solution
Add more statuses to geyser.
cc @lijunwangs

These seems to be some "new" slot status sate. We should be able to support it in Geyser -- will come up with a PR soon.

A related issue in the original repo https://github.com/solana-labs/solana/issues/32958

@lijunwangs looks like all existing statuses implemented? :rocket:

Right. I would recommend verifying against our latest master build. @fanatid


CMake broke handling of CONFIG_MBEDTLS_BUILTIN=n

If defined CONFIG_MBEDTLS without define CONFIG_MBEDTLS_BUILTIN, may
cause cmake error: "Cannot specify link libraries for target 'mbedTLS'
which is not built by this project."
If CONFIG_MBEDTLS_BUILTIN disabled by user in Kconfig but leave
CONFIG_MBEDTLS enabled, may cause make error with the same message.
Solve this by enable CONFIG_MBEDTLS_BUILTIN for default and make it
select and depend on CONFIG_MBEDTLS.
Signed-off-by: Ding Tao<EMAIL_ADDRESS>

Hi @pfalcon
I'm not familiar with cmake.
Should I just close this PR or. set "default y" for MBEDTLS_BUILTIN as a new commit ?

It sounds like CMake no longer supports linking with an external mbedtls.
@miyatsu : Please post steps to reproduce and I will fix this.
Board, sample, conf_file, etc.

Sure @SebastianBoe , you may see the error message do those steps:
sample: /zephyr/samples/net/mqtt_publisher
board: frdm_k64f
edit config file: prj_frdm_k64f.conf, add one line: CONFIG_MBEDTLS=y
Then cmake etc..
By the way, manually disable CONFIG_MBEDTLS_BUILTIN without disable CONFIG_MBEDTLS_BUILTIN, once quit the Kconfig, then never get into Kconfig again.

Here is the output on my conputer
Zephyr version: 1.10.0
-- Generating zephyr/include/generated/autoconf.h
-- Generating zephyr/include/generated/generated_dts_board.h
CMake Error at ../../../cmake/extensions.cmake:663 (target_link_libraries):
Cannot specify link libraries for target "mbedTLS" which is not built by
this project.
Call Stack (most recent call first):
../../../subsys/net/ip/CMakeLists.txt:1 (zephyr_link_interface_ifdef)
-- Configuring incomplete, errors occurred!

Hi, the problem with the proposed solution is that:
CONFIG_MBEDTLS_BUILTIN means you are using a built-in MDEDTLS
MBEDTLS_LIBRARY means you are using an external MBEDTLS
But after the patch, it is not possible to have
MBEDTLS enabled, BUILTIN disabled, and LIBRARY enabled.
Which is the use-case for someone who wants an external mbdetls.
I'm sure we can find some Kconfig that makes sense ...

Thanks for your explanation, I've just notice the kconfig have a "choise", it may can solve this.
I can check it out when I have some free time. But my knowledge are limited, it may take a while for me to solve this alone.

Hi,  @miyatsu , I think I might have a solution: https://github.com/miyatsu/zephyr/pull/1

@SebastianBoe Wait for one second,
I just tested your commit, one bug is still there, its seems can not solve by edit this Kconfig file.
When config external library without specify a valid linkable lib, I still can't re-entry "make menuconfig" after I quit the kconfig GUI.

@miyatsu : Hi, can you see if this patch resolves the issues you have discovered?
https://github.com/SebastianBoe/zephyr/commit/8493db58c34cce3a6423f3609bc46d5b5bbe8139.patch

@SebastianBoe I just tested, it seems still not fixed.
I use the sample "mqtt_publisher" and board "frdm_k64f" without any change but apply your patch.
Here is my test output:
CMake Deprecation Warning at /home/username/project/zephyr/cmake/app/boilerplate.cmake:47 (cmake_policy):
The OLD behavior for policy CMP0000 will be removed from a future version
of CMake.
The cmake-policies(7) manual explains that the OLD behaviors of all
policies are deprecated and that a policy should be set to OLD only under
specific short-term circumstances.  Projects should be ported to the NEW
behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
CMakeLists.txt:3 (include)
-- Selected BOARD frdm_k64f
Zephyr version: 1.10.0
-- Generating zephyr/include/generated/autoconf.h
-- Generating zephyr/include/generated/generated_dts_board.h
CMake Error at ../../../cmake/extensions.cmake:663 (target_link_libraries):
Cannot specify link libraries for target "mbedTLS" which is not built by
this project.
Call Stack (most recent call first):
../../../subsys/net/ip/CMakeLists.txt:1 (zephyr_link_interface_ifdef)
-- Configuring incomplete, errors occurred!
See also "/home/username/project/zephyr/samples/net/mqtt_publisher/build/frdm_k64f/CMakeFiles/CMakeOutput.log".
See also "/home/username/project/zephyr/samples/net/mqtt_publisher/build/frdm_k64f/CMakeFiles/CMakeError.log".
Makefile:896: recipe for target 'cmake_check_build_system' failed
make: *** [cmake_check_build_system] Error 1
I have a plan, we should dismiss all the pre-check on "make menuconfig", then, problem solved. Haha

@SebastianBoe I'm list all my ops, you can recurrence by check this list below:
Step 1:
mkdir -p build/frdm_k64f && cd build/frdm_k64f && cmake -DBOARD=frdm_k64f ./ ../../
Step 2:
make menuconfig
Step 3:
At the kconfig GUI,
enable CONFIG_MBEDTLS
choise CONFIG_MBEDTLS_LIBRARY
leave CONFIG_MBEDTLS_INSTALL_PATH blank
Step 4:
Quit kconfig
Step 5:
make menuconfig
Step 6:
You may see the error message above.

I am unable to reproduce, at step 6 I do not see that error mesage.
I tried with xconfig though, will try with menuconfig ...

Could not reproduce with menuconfig either.
Are you sure this patch applied correctly?
https://github.com/SebastianBoe/zephyr/commit/8493db58c34cce3a6423f3609bc46d5b5bbe8139.patch
Perhaps you could try this branch:
https://github.com/SebastianBoe/zephyr/commits/kconfig-fix-2017-12-11

I’m now in subway back home, I will retry when I get home. May be one hour

@SebastianBoe I just test it, nothing wrong with this branch, bug fixed !!
May be some other commit in master branch that I didn't pull up and merge to the branch I put into test.
I do apply that patch alone with two previous commits of yours and mine into my local master branch, I swear...
Thanks for fix this bug. Time for bed, good nignt~


Questions on implementation

First of all, thank you for the wonderful work! I really enjoyed reading it.
I am currently trying to reimplement your work and got some questions.

Is there any reference to orthogonality regularization? Also, it seems like it is regularized to induce better expressibility for row vector then column vector, which is unorthodox. Is this because the goal of regularization is actually for the latent code than its output whose value eventually some type of "prototype vector" for each class?

https://github.com/deepmind/leo/blob/de9a0c2a77dd7a42c1986b1eef18d184a86e294a/model.py#L40-L41

Is the KL divergence implementation correct? Since our prior and posterior is both Gaussian, there is an analytic formula to calculate it, but the current implementation is using a sample-based approach, and it doesn't represent the KL-divergence; it should be \sum q * (log q - log p), but it is currently \mean (log q - log p). Am I missing something?

https://github.com/deepmind/leo/blob/de9a0c2a77dd7a42c1986b1eef18d184a86e294a/model.py#L269-L274

Currently, $z_n$ is sampled K times from q, and it resulted in K $w_n$ vectors where the mean is taken over logits. Is this to stabilize training caused by reparameterization trick, or is there more than that?

https://github.com/deepmind/leo/blob/de9a0c2a77dd7a42c1986b1eef18d184a86e294a/model.py#L250-L254
Thank you!

Sorry for taking a while to get back to you: your question somehow slipped through my inbox.

I don't have a reference, but our motivation was relatively simple. Decoder maps produced latent codes for each image to the logits for each class. As we would like our (whole) network to be able to distinguish even similar images, we'd like to keep logits for different classes "far away" in some sense. By encouraging decoder weights to be orthogonal, we hope to prevent logits for different classes to be similar. As we backpropagate through the whole network, this may also encourage the latents to be different from each other.
Yes. Indeed, instead of using a closed-form formula for KL of two Gaussians, we use a simple Monte-Carlo estimator (cf. notes). Note that q is implicit (similarly to lack of f_X(x) in the notes): we sample from q, and different outcomes come with different probabilities. Similarly, the sum you are referring to is over different outcomes of the random variable. In our case, even a single-sample estimate: log(q(sample) / prior(sample)) would be unbiased: we average multiple of those to decrease the variance of the estimator.

If I remember correctly, when I was writing this, I thought that if I used a closed-form solution, it would be harder to backpropagate through it back to the network weights, but now that I think about it, it should also work.

The presence of the relation network makes it a little less clear than it could be, but the high-level intuition is that encoder maps each of the NK images to a code, then we average those to get N z_n's (one per class). We need to get back NK weights for the softmax classifier (one per image, as we will be multiplying those by x_n ("image embeddings")), so we sample K times from each classes' Gaussian.

Hope that it makes it clear. Feel free to follow up with any further questions.


Astro examples just say "Upgrade Required"

Describe the bug
Clicking on the "Launch In Stackblitz" button on the astro examples Is just see the message "Upgrade Required" in the ouput window on the right.
https://github.com/snowpackjs/astro/tree/main/examples/starter
https://stackblitz.com/github/snowpackjs/astro/tree/latest/examples/portfolio
Upgrade what? How?
Windows + latest Chrome
Link to the blitz that caused the error
https://stackblitz.com/github/snowpackjs/astro/tree/latest/examples/portfolio
Steps to reproduce
Clicking on the "Launch In Stackblitz" button on the astro examples
Expected behavior
somehting else :)
Screenshots

Platform
Browser name  = Chrome
Full version  = 94.0.4606.61
Major version = 94
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 68390948,
  "usedJSHeapSize": 64432124,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 2c9073eccdf0736e23acc49c5a06b18dd822d7ed

Additional context
No response

Hi @SteveALee! This seems to be a regression on our side. Thanks for reporting! We'll see what we can do.

@SteveALee FWIW, the "Upgrade Required" message you're getting is the response of the server running on port 12321 (as you can see in the URL in the preview bar). We're looking into why the main server is not responsive.

@jrvidal Thanks for the info!

As far as I can see this issue has not been solved. I have been waiting for an hour now and it still shows me "Upgrade Required". Am I missing something here?

@SteveALee Is this for the same blitz or for a different one?

@SteveALee Is this for the same blitz or for a different one?
EDIT: responding to a deleted comment 👻

No it wasn't, but just for completion sake: the issue was that the repo was private and not public. Making it public resolved the issue.


PI Web API Summaries

I believe this may be a bug as well as a feature request. I hope that this is not user error, so forgive me if it is, but I haven't been able to find an explanation of how to utilize the summary options for the PI plugin so I am not sure.
I am attempting to utilize the summary options for PI plugin metrics (any of them). I select my options as can be seen below:

However when queried the graph paints the following:

I checked the query inspector and it appears that the call is successful and correct as shown here:

So here are my two questions:

(Maybe this is the bug.) Am I not configuring these options correctly?
(Maybe this is the feature request.) Is it possible to set the summary duration to null? We want the summary period to be the full timespan of the graph allowing for dynamic responses if the user selects a piece of the graph. This is possible in PI Web API as the summary duration is optional. I tested this on our servers.

Thanks fore the help in advance!

I have decided to resolve these issues myself. I'll send encapsulated PR's shortly.


Add option to track undone balance

What this PR is about

Add checkbox that allow user to track undone balance
While adding such option, it may create confused UX expression where the balance overview does not fully reflect the txn pane list.

closes #322

What this PR is about

Add checkbox that allow user to track undone balance
While adding such option, it may create confused UX expression where the balance overview does not fully reflect the txn pane list.

closes #322

You meant "Without adding such option" right

What this PR is about

Add checkbox that allow user to track undone balance
While adding such option, it may create confused UX expression where the balance overview does not fully reflect the txn pane list.

closes #322

You meant "Without adding such option" right

I don't think this will confuse users, we add the checkbox precisely to avoid confusion that the balance are still showing the incorrect owed owes amount even when certain transactions are done.

Mainly nitpicks for codebase, behaviour of app seems to be as desired. Good job!


prints files and numbers like './build.md:70'

I wanted to be able to list files and numbers of matches so I could do a checklist-type-thing. So now, when you do ag -N "myMatch", (or ag --files-and-numbers "myMatch") it prints out a list of matching files like
file1.cpp:42
file1.cpp:57

file2.cpp:29

and you can use it with --nobreak to get rid of the newlines if you don't like them. It has coloured and uncoloured output and stuff too. :yellow_heart:
By the way, great code! Haven't written C in a long time, the source was very legible and extensible. Let me know if I missed or broke anything!

closing since I never got around to this and it's many many years later :)


Dopamine duplicate Gym functionality

I spent a lot of time trying to understand the colab cartpole Gym example so to apply to a custom discrete Gym environment, which is similar to the cartpole gym environment and works fine with a Keras RL agent. I noticed that dopamine is using gym_lib.py in addition to the actual gym environment. For example, gym_lib.py contains variables already defined in the gym cartpole environment file. such as:
dopamine/discrete_domains/gym_lib.py:
CARTPOLE_MIN_VALS = np.array([-2.4, -5., -math.pi/12., -math.pi*2.])
CARTPOLE_MAX_VALS = np.array([2.4, 5., math.pi/12., math.pi*2.])
gin.constant('gym_lib.CARTPOLE_OBSERVATION_SHAPE', (4, 1))
gin.constant('gym_lib.CARTPOLE_OBSERVATION_DTYPE', tf.float32)

gym/envs/classic_control/cartpole.py:
self.x_threshold = 2.4
self.observation_space = spaces.Box(-high, high, dtype=np.float32)

This is confusing.
OpenaAI gym encompass all the code necessary to create a complete environment object. With all the necessary plumbing//functions/variables, etc.. This approach is difficult to understand and build on.
Would it be possible to make gym a drop-in for dopamine? This would greatly simplify and speed up dopamine adoption.

thanks for your feedback!
when we originally built dopamine for atari, we wrote the AtariPreprocessing class to have everything related to atari preprocessing contained in one place. there are a few things that are standard when training atari agents (see https://github.com/google/dopamine/blob/master/dopamine/discrete_domains/atari_lib.py#L240)
for consistency with that we created GymPreprocessing. we'll see if we can simplify the interface with non-atari gym environments so that it's easier to use.

That would be very helpful.
Thanks!

Hello, is there is a plan to remove the duplicate settings to make it more streamlined and easy to use with GYM?

I'm doing the same thing as @jheffez and i find difficult to adapt the code with all these duplicate settings.
I've successfully adapted my custom discrete gym environment into the rllib library and it works fine; now i'm trying to do the same for dopamine, struggling a little bit.

Echoing @psc-g 's earlier comment, I agree GymProcessing needs some streamlining. This is on our plate but -- if you have a solution ready for GymProcessing in particular, a PR is also welcome.

@mgbellemare , thanks for the update! Ideally, GymProcessing will make Dopamine a drop-in to Gym.
Can you please share with us your roadmap/plans? For example, adding latest RL technics (like Simple) and if Dopamine and  tensorflow/agents  can benefit from synergy?

hi, i've started looking into this. a few points:

we could inherit things like min_vals and max_vals from gym to avoid the redundancy. is that mostly what you're after?
the observation shapes and dtypes are a little trickier, as they need to be defined as gin constants so that we can inject them via the respective gin config files. i think there's a way to get this to fetch the values from gym, but it would add redirection, potentially at the risk of clarity.
with regards to roadmap/plans, we have lots we'd like to do, but limited time :)
we are in discussions with tensorflow/agents to see how dopamine and tf/agents could be more compatible, stay tuned!

Goodluck i am always with dopamine and will try my best to contribute too someday.

Hi @psc-g ,
1, 2. OpenAi Gym exposes all functions. For ex, spaces is easily accessible via env.env.action_space. To get the number of actions:
import gym
from gym import spaces
from gym.utils import seeding
action_dim = env.env.action_space.n
To get state: state_dim = env.get_state_size()
Take a look at this for more examples.
So, it beneficial, and simple, for Dopamine to grab all that good stuff directly from Gym.

Do share...
Great! Synergies are a good thing!


Provide API for apps to query current titles being read

Describe your suggested feature
Maybe an Intent-based API or one based around a custom ContentProvider.
This would allow other apps to query what the user is currently reading or has read.
My use case is a custom app launcher. I am aggregating books and comics from different apps to display them to the user inside a "continue reading" category.
Other details
Most useful would be to provide information like title, description, a cover image, chapter/volume.
A mechanism to tell mihon to continue with the given title where the user left off would be great, too. Probably an Intent.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

Personally I have no interest on this and the use case is also very niche. But I'll keep the issue open since it isn't adding anything to the existing UI


Not able to see APIM Frontend API Traffic in Dynatrace Dashboard.

Hi @rathnapandi ,
Followed all the steps mentioned in the setup instructions.
We can see below services are auto-detected in Dynatrace after the setup:

Policy studio APIs
Axway internal /vordel/apiportal/* APIs
other Axway internal API traffic like /api/router/service/*, /api/topology/version, /api/management/productversion.

But not the API Manager Frontend API Traffic.
Is there any additional setup that we need todo either at Axway or Dynatrace end to see APIM traffic?

Hi @rathnapandi,
Could you help us with please.


Feature/pmg 31

Created generic popup and used it in in logout confirmation.

@talyo94 the name GenericPopupComponent is not good.
I think it would be better to call it ConfirmPopupComponent


Clean up old gauges

There are many expired gauges that are kept in the frontend's source code that should be removed, fo example:
For example:
https://github.com/osmosis-labs/osmosis-frontend/blob/d21075d2c96b890870235d783e0abbf836746431/packages/web/config/feature-flag.ts#L67
I also think we should start adding comments to a gauge when it's added with meta information such as expiration and token denom. (As a comment for example).

Would be ideal to remove this config all together by implementing issue #853

Config removed by PR #1190


UIA3 automation returns UIA2 elements from FindChildren

I've initialized UIA3 automation context. I've requested Google Chrome window and tracked down to document level:

There are few child elements below Document element.
When I'm trying to fetch children elements from code using UIA3 automation, I'm getting one child element:

If I'll open inspector in UIA2 mode I'll see the same as I see in code:

Why FlaUI switching to UIA2 during querying? How to prevent it?

In your code, do you only have UIA3 or also UIA2? Because you can't have both in the same process.

I have UIA3 on my app only. The question is why Inspector shows different result on the same time.

I've started both by admin user, but without special evevation

Do you maybe have multiple chrome windows open and it returns a different window in your code?


Add CI check for demo script

Description
Added a new check to build, install, and run the security plugin with the demo configuration script.
This was built heavily borrowing from https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/workflows/integration-test.yml
Issues Resolved

Resolves https://github.com/opensearch-project/security/issues/1641

Testing
Automatically runs as part of PR and PUSH Github actions
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hit a failure due to version mismatch where we updated a jar version that is behind in the distribution
Caused by: java.lang.IllegalStateException: jar hell!
class: com.fasterxml.jackson.dataformat.cbor.CBORConstants
jar1: /opensearch/plugins/.installing-15168128924324[135](https://github.com/peternied/security/runs/5634491143?check_suite_focus=true#step:11:135)285/jackson-dataformat-cbor-2.13.2.jar
jar2: /opensearch/lib/jackson-dataformat-cbor-2.12.6.jar
	at org.opensearch.bootstrap.JarHell.checkClass(JarHell.java:317)
	at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:212)
	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:676)
	... 11 more

Good contribution! Looking forward to this!

This change is blocked on https://github.com/opensearch-project/OpenSearch/pull/2544 getting merged

One of the tasks failed.
Run curl -XGET https://localhost:[9](https://github.com/opensearch-project/security/runs/5634568266?check_suite_focus=true#step:10:9)200 -u 'admin:admin' -k -v
Note: Unnecessary use of -X or --request, GET is already inferred.

Codecov Report

Merging #1690 (4d6b6e6) into main (e638c76) will decrease coverage by 0.12%.
The diff coverage is n/a.

:exclamation: Current head 4d6b6e6 differs from pull request most recent head 1b1a3b5. Consider uploading reports for the commit 1b1a3b5 to get more accurate results

@@             Coverage Diff              @@
##               main    #1690      +/-   ##
============================================
- Coverage     62.94%   62.81%   -0.13%
+ Complexity     3261     3259       -2
============================================
  Files           253      253
  Lines         18126    18087      -39
  Branches       3258     3246      -12
============================================
- Hits          11410    11362      -48
- Misses         5067     5072       +5
- Partials       1649     1653       +4

Impacted Files
Coverage Δ

...org/opensearch/security/rest/TenantInfoAction.java
77.94% <0.00%> (-10.30%)
:arrow_down:

.../org/opensearch/security/support/Base64Helper.java
67.85% <0.00%> (-4.78%)
:arrow_down:

...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...ecurity/configuration/ConfigurationRepository.java
73.07% <0.00%> (-2.20%)
:arrow_down:

.../org/opensearch/security/support/ConfigHelper.java
80.39% <0.00%> (-1.97%)
:arrow_down:

...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java
49.18% <0.00%> (-1.64%)
:arrow_down:

...ic/auth/ldap/backend/LDAPAuthorizationBackend.java
57.57% <0.00%> (-0.38%)
:arrow_down:

...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java
28.35% <0.00%> (-0.38%)
:arrow_down:

...a/org/opensearch/security/tools/SecurityAdmin.java
45.55% <0.00%> (-0.13%)
:arrow_down:

...search/security/transport/SecurityInterceptor.java
76.15% <0.00%> (+0.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e638c76...1b1a3b5. Read the comment docs.


[Bug]: Add check for self-referencing input in YAML transform

What happened?
The following pipeline will fail
pipeline:
  transforms:
    - type: Create
      name: Source
      config:
        elements:
          - id: 1
      input: Source
    - type: LogForTesting
      input: Source

with following error:
  ...
  File "/Users/jkinard/beam/sdks/python/apache_beam/yaml/yaml_transform.py", line 163, in strip_metadata
    if isinstance(spec, Mapping):
       ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jkinard/.pyenv/versions/3.11.6/lib/python3.11/typing.py", line 1305, in __instancecheck__
    return self.__subclasscheck__(type(obj))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jkinard/.pyenv/versions/3.11.6/lib/python3.11/typing.py", line 1583, in __subclasscheck__
    return issubclass(cls, self.__origin__)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded in __subclasscheck__

Due to self-referencing transform - this should be a more clear error and caught earlier
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[X] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Infrastructure
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take_issue

.take-issue

@Polber ptal https://github.com/apache/beam/pull/33208

.close-issue


Augmenting heading that contains anchor will make original anchor inaccessible

Sometimes a user might want to provide a heading only structured collection of links.
Augmenting these headings will make the links inaccessible to the user.
It would be better to not augment such headings.

better yet would be to split such headings into the original anchor and the actual heading anchor

Closing in favor of #6


Write password in stdin when ssh due to the need of sudo. And workaro…

…und the password issue.

Coverage decreased (-5.5%) to 44.943% when pulling 6e794b124cfcd2c2983f96902573cf12b027e735 on yuye/ssh_sudo_block_issue into d5132e0e5de651227ca244389082d157bd9600f6 on master.

we'd better revert this pr, if we can't solve this issue asap.
https://github.com/Microsoft/pai/pull/657

Did you test it? If you did I will approve.

@hwuu tested. But only deploy part.


TEPHRA-143 Treat Tephra delete markers from existing data as regular cells

JIRA - https://issues.cask.co/browse/TEPHRA-143
Note: the changes are only in hbase-compat-0.98 for now.

LGTM

Thanks Terence. I'll port to other compat modules.

Second commit LGTM.

Thanks Ali. Will squash and merge.


feat!: alternative API

This breaking change is to allow code like these:
module S = Algaeff.State.Make (Int)
module R = Algaeff.Reader.Make (Int)
module S = Algaeff.Sequencer.Make (Int)
module U = Algaeff.UniqueID.Make (Int)

I don't feel the convenience is worth the trouble (which includes manually adding version upper bounds to released forester/asai/yuujinchou), but also why not. I am on the fence about this PR.

But can we try to coordinate the releases of (e.g.) all these packages, including forester? Maybe we delay this until we are ready to do it all at once? Currently forester doesn't have any upper bounds, but this means that it is easy to break it from another package. This might have been a mistake on my part 😆

@jonsterling I don't get the benefit of coordination---no matter a release is delayed or not, we should update what's already in the OPAM repository with upper bounds, and with all upper bounds in the OPAM repository, I don't feel anything could (easily) go wrong? The next release of algaeff will be 2.0.0 due to the breaking change, so you can already add < 2.0.0 now before you use the new algaeff, and for this, maybe it's better to put algaeff 2.0.0 in OPAM first?
On the other hand, I'm of course not against coordination, though I'm not sure how to achieve that. The other option is to use Algaeff2 just like QCheck2, but I prefer not to do this when it's still possible to manually update every package using algaeff.

My imagined plan:

Release the new algeaff as 2.0.0 AND add upper bounds to yuujinchou, asai, and forester in OPAM
Release new yuujinchou 5.2.0 and asai 0.3.0
Release new forester

But maybe we should merge this PR and continue this discussion in a different issue...


TypeScript should allow declarations to be compatible with older versions.

Search Terms
semver
Suggestion
We would like to use TypeScript 3.8 and emit declaration files compatible with TypeScript 3.4
Use Cases
Many of our users can't upgrade their TypeScript version because they are using a version mandated by another tool, especially Angular. We want to be able to use the newest TypeScript on out source to gain additional features, but that should be isolated from the outputs of our project that other projects consume.
The particular motivation for this request is that my project upgraded to TypeScript 3.8, which emits property accessors in declaration files. We have multiple reports from users that this broke their builds with TypeScript 3.4 with the message "An accessor cannot be declared in an ambient context.".
Examples
{
  "compilerOptions": {
    "declaration": true,
    "declarationVersion": "3.4",
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

I haven't personally tried it but, https://github.com/sandersn/downlevel-dts

See #35016

The downlevel-dts tool appears to be written by a TypeScript team member... so it's at least somewhat a recognized problem. Why is it out of scope then?
Combined with TypeScript not following semver and breaking .d.ts changes in minor versions, the current situation leads to some very nasty surprises when we publish what should be a non-breaking change of our project, but it is for TypeScript consumers.
Without this semi-external tool, the only way for a project to be safe is to only upgrade TypeScript minor versions when our project has a new major version. That's not at all a constraint I planned for.

We can't solve every problem in the entire TS ecosystem with code written inside this repository. That's what we mean by "out of scope" - we had hoped someone would write downlevel-dts (since it's fairly straightforward), but we stepped in when that didn't happen.


AWStealth returns version error for AWS Tools for Powershell version 4.x

The code at
https://github.com/cyberark/SkyArk/blob/650138a02278f98449f99430964ac43c81f032ba/AWStealth/AWStealth.ps1#L1139 doesn't work as intended. You should probably just compare the module version to [System.Version]"3.3.330".

Hi @brandond
Thanks for sharing this issue, can you elaborate on this "work as intended"?
Did the scan encounter errors for you and stopped? Did you have a greater/equal version than 3.3.330 and this filter didn't catch this?
Thanks.

The nested version tests don't do what you intend, since they check each part of the version independently. The script itself runs fine, other than printing a big warning about the module version being too old.

Ha ha, suddenly I understood the error you mentioned and this week I fixed that AWS module version validation logic.. Feel free to check it out :)
Thanks @brandond


I think you broke api-proxy.yml

I'm unable to add any new users to api-proxy.yml. I think this might be caused by the latest changes to allow env vars.
To recreate:
add user/password to api-proxy.yml. Restart. Try to use the login and you'll get a 401.

@RohirrimRider i tested it and it is working, i can get the playlist.  Is your yaml file invalid ?
I made some changes to the code, can you pull master and test again.

Clsoing due to inactivity,  tested and working


fixes: #SHA-19- ContentLayer ESBuild warnings

https://linear.app/shadcn-extension/issue/SHA-19/contentlayer-esbuild-warnings-duplicate-keys
Removes duplicated keys for example: breadcrumb-active

I am seeing a new warning in the build after this change --relates to ContentLayer, please verify:
TypeError: The "code" argument must be of type number. Received an instance of Object
    at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
    at Cli.runExit (/Users/knowhow/dev/collabs/shadcn-extension/node_modules/clipanion/lib/advanced/Cli.js:232:26)
    at run (file:///Users/knowhow/dev/collabs/shadcn-extension/node_modules/@contentlayer-temp/cli/src/index.ts:39:3)
    at main (/Users/knowhow/dev/collabs/shadcn-extension/node_modules/contentlayer-temp/bin/cli.cjs:5:3) {
  code: 'ERR_INVALID_ARG_TYPE'
}

I am seeing a new warning in the build after this change --relates to ContentLayer, please verify:
TypeError: The "code" argument must be of type number. Received an instance of Object
    at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
    at Cli.runExit (/Users/knowhow/dev/collabs/shadcn-extension/node_modules/clipanion/lib/advanced/Cli.js:232:26)
    at run (file:///Users/knowhow/dev/collabs/shadcn-extension/node_modules/@contentlayer-temp/cli/src/index.ts:39:3)
    at main (/Users/knowhow/dev/collabs/shadcn-extension/node_modules/contentlayer-temp/bin/cli.cjs:5:3) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Ran the issue through gemini and this is what it had to say. TLDR:

the issue is related to a conflict with the CLI nodemodule script (which we are not currently actively using).
doesn't seem to affect us, but will still need to resolve.

So this issue was related to an underlying contentlayer maintenance issue, and we've decided to Migrate to ContentLayer2 to address this use with the new hard fork of the original which is still maintained.