Constant dictionaries with arrays only appending first key referenced.

Godot version
Godot 4.0 Alpha 9
System information
Windows 10
Issue description
May be related (but posting in case it's not, since it's subtly different): https://github.com/godotengine/godot/issues/61274
Constant dictionaries are only updating the first referenced key, at least in regards to arrays. I believe that constant dictionaries and array are only constant in regards to their size, so I believe this should be allowed.
var dictionaries are working fine.
const dictionary : Dictionary = {"ENTRY1":[],"ENTRY2":[]}

func _ready():
	dictionary["ENTRY1"].append("Hello")
	dictionary["ENTRY2"].append("World")
	print(dictionary) #{"ENTRY1":["Hello", "World"], "ENTRY2":[]}

Expected output is {"ENTRY1":["Hello"], "ENTRY2":["World"]}
Steps to reproduce
Use code above.
Minimal reproduction project
No response

I did some testing and I think I've identified part of the problem, will dig deeper and see
If you instead initialize the dictionary with unique arrays:
{ "ENTRY1":["A"], "ENTRY2":["B"] }
you get a different result, it appears that when accessing a constant dictionary by the subscript it fetches a constant value and that value is indexed by its original value, so in the original case it looks up the empty array, and regardless of key that returns the first entry (seemingly the first empty array as if you create two constant dictionaries the problem extends to that)
I think the problem might lie in the folding of dictionaries or somewhere else there, I'll take a deeper look later today and see

In summary, as far as I read it:
When accessing a dictionary through the subscript operator the analyzer reduces this to a reduced value, and declares it constant, here:
https://github.com/godotengine/godot/blob/21c79d75153733b84533957228d0c267ef340a80/modules/gdscript/gdscript_analyzer.cpp#L3272-L3282
This is then emitted as a constant value in compilation, here:
https://github.com/godotengine/godot/blob/21c79d75153733b84533957228d0c267ef340a80/modules/gdscript/gdscript_compiler.cpp#L247-L249
In codegen this constant value is fetched from an array of constant values, or inserted if not present, and emitted as an address to that constant, in this case it looks up or adds an empty array
The problem seems to be caused by that when using the subscript for the second key the value that is reduced is again an empty array, meaning that it returns the constant address, which points to the first instance of fetching an empty array
In other words, we get, for a dictionary with keys "A" and "B" both holding empty arrays:
dictionary["A"].append("Hello") -> const([]).append("Hello")
dictionary["B"].append("World") -> const([]).append("World")

operating on the same empty array.
I'm not familiar enough with the inner workings of GDScript to propose a solution but I hope this can help anyone who would


PHP Warning:  Undefined array key "storageSize" in /vendor/league/oauth2-linkedin/src/Provider/LinkedInResourceOwner.php on line 176

Since a few days I get a PHP warning when someone tries to login/signup with LinkedIn: PHP Warning:  Undefined array key "storageSize" in /vendor/league/oauth2-linkedin/src/Provider/LinkedInResourceOwner.php on line 176

I have a similar issue as well. Any solutions?


Move all issues from old project

http://code.google.com/p/dbupgrade/issues/list

Finished or not, old repo is gone....


Issue: pagination

Only a limited amount of issues is shown (20 at the moment) - but sometimes you want to view more than just the given amount.
As I noticed in the comment below, there is some pagination in the back-end already. It's just not implemented in the UI yet (dev branch of last week). This would be nice to have.

I see something that indicates pagination in models/issue.go, lines 193 and 194.
In repo/issue.go, lines 97 and 100 parse the page parameter from the URL.
Manually adding ?page=2 to the URL works.
Updated original post accordingly.

Thanks for the report! Will fix this along with new issue UI.

Should be fixed in latest develop branch and can be tested here: https://try.gogs.io/unknwon/gogs/issues

Could you please create more than 20 issues (a few tens would be even better to test large issue queues) on the test site just to see if the pagination is full pagination and not just a previous/next page link?
If it is just only previous/next page links I would say it is not a good idea to close this issue.
In my opinion pagination should be prepared for large issue queues with an easy way to jump several pages at a time.
And a way to decide the number of issues per page, to jump to last page, and to jump to first page would be helpful too though these would be less important and optional.
If it is not a full pagination already sooner or later you will have a new issue in gogs about the pagination usability not being good enough.
By the way, if possible a reference to the commit that solves issues instead of a reference to a full branch would be helpful to look at the code.

Hi @manfer , thanks your feedback!

see if the pagination is full pagination and not just a previous/next page link?

Not sure what do you mean? Test site right now has 11 issues total and show 10 each page.
Agree to other points, but closed issue is because solved what issue describes, and it's true that you can create another issue about pagination usability.


Update Job monitor to show job run metrics

Show service metrics for every job run.
Show GPU metrics when the job run collects GPU metrics.
Add button to delete a single job run.
Rename flask_job_monitor to job_monitor as suggested by @lpelov

very fancy!


:bug: parse object arrays for hf_x

This PR does the following;

Parse hf_x to numeric or datetime if hf_x is an array of dtype object
Update poetry install in CI-CD (see #117)

Note that this parsing removes any time zone information;

[ ] check if this is consistent with plotly behavior

Codecov Report

Merging #116 (836f5e8) into main (5df40fd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   96.93%   96.95%   +0.02%
==========================================
  Files          12       12
  Lines         847      855       +8
==========================================
+ Hits          821      829       +8
  Misses         26       26

Impacted Files
Coverage Δ

...ler/figure_resampler/figure_resampler_interface.py
99.72% <100.00%> (+<0.01%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Have you found any time to look into my remarks @jvdd?

LGTM!
Also tested the basic example notebook and the pandas plotting backend datetime issue is not yet resolved 😢

Squash merged this into main! Do we create a new release?


Compatibility with mkdocs-macros

Is your feature request related to a problem? Please describe.
To be able to write more powerful documentation and avoid repetition, it is very useful to use the mkdocs-macros plugin, but it seems the documentation written inside docstrings is not being processed by the macros plugin.
Describe the solution you'd like
It would be nice if there is a way to make mkdocstrings extract the docstrings before the macros plugin runs, so macros can be expanded also inside the documentation hosted in docstrings.
Describe alternatives you've considered
None really, just avoid using the macros plugin.
Additional context
I could show a way I'm using the macros plugin, but I guess it is irrelevant, as there are many many uses for it, like showing the current git tag, etc.

This has been discussed several times already, let me try to find the relevant discussions.

OK, I did search for macros in the issues and didn't find anything relevant, but I must confess I didn't went through the couple of issues that matched but the title was completely unrelated. :innocent:

Ah, sorry, I missed searching the discussions.
So, it is hard to do but possible if I understand correctly?

So cool haha! :grinning:
What do you mean by including the import statements :thinking:?

Amazing, good to hear! I guess the chimera wasn't ready for public consumption, but I was too eager so I tried out, and sadly it didn't work. I had to change env.config["plugins"] to env.conf["plugins"] (are the mkdocs-macros docs outdated? it seems like env.config holds the configuration of the plugin itself and env.plugin is not defined).

Chimera failing...
INFO    -  Building documentation...
INFO    -  [macros] - Macros arguments: {'module_name': 'docs/_scripts/macros', 'modules': [], 'render_by_default': True, 'include_dir': '', 'include_yaml': [], 'j2_block_start_string': '', 'j2_block_end_string': '', 'j2_variable_start_string': '', 'j2_variable_end_string': '', 'on_undefined': 'strict',
           'on_error_fail': True, 'verbose': False}
INFO    -  [macros] - Found local Python module 'docs/_scripts/macros' in: /home/luca/devel/sdk
INFO    -  [macros] - Found external Python module 'docs/_scripts/macros' in: /home/luca/devel/sdk
Traceback (most recent call last):
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/__main__.py", line 270, in serve_command
    serve.serve(**kwargs)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 86, in serve
    builder(config)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 67, in builder
    build(config, live_server=None if is_clean else server, dirty=is_dirty)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/build.py", line 277, in build
    config = config.plugins.on_config(config)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/plugins.py", line 527, in on_config
    return self.run_event('config', config)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/plugins.py", line 507, in run_event
    result = method(item, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs_macros/plugin.py", line 585, in on_config
    self._load_modules()
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs_macros/plugin.py", line 458, in _load_modules
    self._load_module(module, local_module_name)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs_macros/plugin.py", line 398, in _load_module
    module.define_env(self)
  File "/home/luca/devel/sdk/docs/_scripts/macros.py", line 46, in define_env
    python_env = env.conf["plugins"]["mkdocstrings"].get_handler("python").env
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocstrings/plugin.py", line 297, in get_handler
    return self.handlers.get_handler(handler_name)
           ^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocstrings/plugin.py", line 129, in handlers
    raise RuntimeError("The plugin hasn't been initialized with a config yet")
RuntimeError: The plugin hasn't been initialized with a config yet

@llucax thanks for testing! Try putting mkdocstrings above/before macros in mkdocs.yml.

@pawamoy

What do you mean by including the import statements 🤔?

Sorry, I re-read the code, and there is no need, since it is only defining a filter (btw, env.render should also work).
But, then what would be Markdown/Jinja2 code in the page?

    convert_markdown = python_env.filters["convert_markdown"]
                       ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
KeyError: 'convert_markdown'

I had to fix again config -> conf (not sure what's going on with that). It seems to have advanced more, but still failing:
INFO    -  Building documentation...
INFO    -  [macros] - Macros arguments: {'module_name': 'docs/_scripts/macros', 'modules': [], 'render_by_default': True, 'include_dir': '', 'include_yaml': [], 'j2_block_start_string': '', 'j2_block_end_string': '', 'j2_variable_start_string': '', 'j2_variable_end_string': '', 'on_undefined': 'strict',
           'on_error_fail': True, 'verbose': False}
INFO    -  [macros] - Found local Python module 'docs/_scripts/macros' in: /home/luca/devel/sdk
INFO    -  [macros] - Found external Python module 'docs/_scripts/macros' in: /home/luca/devel/sdk
INFO    -  [macros] - Extra variables (config file): ['social', 'version']
INFO    -  [macros] - Extra filters (module): ['pretty']
INFO    -  Cleaning site directory
INFO    -  Doc file 'SUMMARY.md' contains an unrecognized relative link 'intro/', it was left as is. Did you mean 'intro/index.md'?
INFO    -  Doc file 'SUMMARY.md' contains an unrecognized relative link 'reference/', it was left as is.
ERROR   -  Error reading page 'intro/actors.md': define_env.<locals>.patched_update_env() missing 1 required positional argument: 'config'
[... click stuff ...]
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/__main__.py", line 270, in serve_command
    serve.serve(**kwargs)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 86, in serve
    builder(config)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/serve.py", line 67, in builder
    build(config, live_server=None if is_clean else server, dirty=is_dirty)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/build.py", line 322, in build
    _populate_page(file.page, config, files, dirty)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/commands/build.py", line 175, in _populate_page
    page.render(config, files)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocs/structure/pages.py", line 271, in render
    self.content = md.convert(self.markdown)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/markdown/core.py", line 254, in convert
    root = self.parser.parseDocument(self.lines).getroot()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/markdown/blockparser.py", line 84, in parseDocument
    self.parseChunk(self.root, '\n'.join(lines))
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/markdown/blockparser.py", line 99, in parseChunk
    self.parseBlocks(parent, text.split('\n\n'))
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/markdown/blockparser.py", line 117, in parseBlocks
    if processor.run(parent, blocks) is not False:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocstrings/extension.py", line 125, in run
    html, handler, data = self._process_block(identifier, block, heading_level)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocstrings/extension.py", line 216, in _process_block
    handler._update_env(self.md, self._config)
  File "/home/luca/devel/sdk/.direnv/python-3.11.5/lib/python3.11/site-packages/mkdocstrings/handlers/base.py", line 370, in _update_env
    self.update_env(new_md, config)
TypeError: define_env.<locals>.patched_update_env() missing 1 required positional argument: 'config'

OK I've ran some tests and this is working now :smile:
def define_env(env):
    @env.macro
    def is_it_working():
        return "WORKING"

    # get the `render` method of the macros plugin
    macros_render = env.conf["plugins"]["macros"].render
    # @fralau suggests that `env.render` would work too

    # get mkdocstrings' Python handler
    python_handler = env.conf["plugins"]["mkdocstrings"].get_handler("python")

    # get the `update_env` method of the Python handler
    update_env = python_handler.update_env

    # override the `update_env` method of the Python handler
    def patched_update_env(md, config):
        update_env(md, config)

        # get the `convert_markdown` filter of the env
        convert_markdown = python_handler.env.filters["convert_markdown"]

        # build a chimera made of macros+mkdocstrings
        def render_convert(markdown: str, *args, **kwargs):
            return convert_markdown(macros_render(markdown), *args, **kwargs)

        # patch the filter
        python_handler.env.filters["convert_markdown"] = render_convert

    # patch the method
    python_handler.update_env = patched_update_env

Example module docstring:
"""Debugging utilities.

{{ is_it_working() }}
"""

...getting properly rendered to:
Debugging utilities.

WORKING

Ah, I think I am finally catching up. So you are modifying the mkdocstrings' Python handler, and basically decorating it with env.render(). And you are using env.render() in define_env().
That's bold wizardry. 🫡
When you are happy with it, maybe you want to package that into a pluglet for mkdocs-macros, so that anybody could use it? I would gladly put a reference to it in Mkdocs-Macros doc.

Sorry @fralau I wanted to try and write a better explanation of what we were trying to achieve. If you got it by looking at my final code snippet, that works too!

@fralau I'd like to refactor mkdocstrings a bit to make the patching easier (ideally refactor so that no patching is necessary), and then I'd be happy to provide a pluglet, yes!

@pawamoy just chiming in that it would be great to have some way to hook into the update_env step -- personally I'm going to monkey-patch it so I can set self.env.globals[...] to a Python function that I can later call in my attributes.html template:

Code
def on_pre_build(config: MkDocsConfig) -> None:
    """Monkey patch mkdocstrings-python jinja template to have global vars."""
    import mkdocstrings_handlers.python.handler

    old_update_env = mkdocstrings_handlers.python.handler.PythonHandler.update_env

    def update_env(self, md, config: dict) -> None:
        old_update_env(self, md=md, config=config)
        self.env.globals["pipeline_steps"] = _ParseConfigSteps()

    mkdocstrings_handlers.python.handler.PythonHandler.update_env = update_env

At least for the suggestion:

expose the Jinja env that mkdocstrings uses to render collected data to HTML

Would it make sense to add a mkdocstrings option for some hook to call? Or maybe better, could mkdocstrings look in the standard hooks: location for a specially named function like mkdocstrings_on_update_env(handler: BaseHandler) or similar? Then my snippet above would just become:
def mkdocstrings_on_update_env(handler):
    handler.env.globals["pipeline_steps"] = _ParseConfigSteps()

Hey @larsoner, sorry for the late answer.

expose the Jinja env that mkdocstrings uses to render collected data to HTML

It's actually exposed:
def on_pre_build(config: MkDocsConfig) -> None:
    """Monkey patch mkdocstrings-python jinja template to have global vars."""
    python_handler = config["plugins"]["mkdocstrings"].get_handler("python")
    python_handler.env.globals["pipeline_steps"] = _ParseConfigSteps()

The point of patching update_env is to have access to the Markdown instance used to convert Markdown to HTML, which is the only way to reach docstrings :slightly_smiling_face: If you don't care about docstrings and just want to add globals to the Jinja env, you should be able to use the code right above.

Now that I come to think about it, I would favor the idea of a more general hook.
The solution proposed by @pawamoy works nicely for Mkdocs-Macros, but it wouldn't work as-is for modules that don't have a built-in scripting system like mkdocs-bibtex. They would have to implement the hack directly in their own module.
Would there be a general solution to that issue, especially if there was more than one plugin that required this functionality? For example in the form of a parameter for the mkdocstrings plugin, which would reference a list of rendererers that would have to be applied? 🤔
plugins:
- search
- mkdocstrings:
    post-processing:
      - mkdocs-macros!render
      - mkdocs-bibtex!process # made-up

It would be interesting to make this easy for mkdocstrings+macros, yes. But for other plugins, it looks like most of time their logic could be implemented as a Markdown extension rather than a MkDocs plugin. If they did that, then they would natively work within docstrings and we wouldn't need hacks or extra config, or pre/post-processing.


⚠ T:Riza Api has degraded performance

In 7aa1298, T:Riza Api (https://infra.triza.dev/api) experienced degraded performance:

HTTP code: 200
Response time: 4559 ms

Resolved: T:Riza Api performance has improved in d0ceaf2.


"Use tuple-section" not working?

I seem to be unable to trigger these warnings:
https://github.com/ndmitchell/hlint/blob/213b9bb678393469bbb6b27d9ebd41042b5e85f0/data/hlint.yaml#L267
https://github.com/ndmitchell/hlint/blob/213b9bb678393469bbb6b27d9ebd41042b5e85f0/data/hlint.yaml#L268
With:
f = flip (,) 0

g = (,) 1

I get:
> hlint --language=TupleSections .\Test.hs
No hints

The --language=TupleSections should have no impact at all. For me, I get a hint for the first one, but not the second. However, the second demands ((,) 1) since the idea is that should be (1,) but (,) 1 2 should not become a tuple section. However, having just tried that expression, it isn't matched, so that's a bug in the bracket matching.
As to why it doesn't detect the first, are you using the most recent version? Any custom .hlint.yaml or ignores anywhere?

Ah, I wasn't using the most recent version, or rather the version on my laptop wasn't the same as the one used on the system that receives and checks student submissions...
So I am now seeing what you see, thanks.
The part about brackets being relevant in the matching is good to know. I was going to propose two additional hints related to tuple sections. And I now guess they have to be written like this (no noParen needed on the right-hand sides, contrary to the existing tuple-section hints):
    - warn: {lhs: "\\y -> (x,y)", rhs: "(x,)", name: Use tuple-section, note: RequiresExtension TupleSections}
    - warn: {lhs: "\\y -> (y,x)", rhs: "(,x)", name: Use tuple-section, note: RequiresExtension TupleSections}

Brackets aren't usually relevant, which I'm sure is why I've got them wrong in the matching engine - it usually sees through them.
Those hints look great!

I found the issues with brackets at the root, so patch pushed.

Cool!


Make extra mouse buttons configurable

Currently hard-coded to wheelup/wheeldown, which is horrible.

Done!


[usecase-embeddingapi] Add test for set/getDomStorageEnabled methods

Impacted tests(approved): new 2, update 0, delete 0
Unit test platform: Crosswalk for Android 21.51.546.0
Unit test result summary: pass 2, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/CTS-1820

@Shao-Feng, PTAL


[Error] UPS artillery

Version: 0.11.2
Mods: CBA, TFAR, ACE No medical
Environment: MP dedi.
.rpt attatched? highlight below
have you edited the missionfile?: No
 11:31:59 Error in expression <_Battery",[]])select 0;_batteryunits = _staticteam;{If (alive _x && vehicle _>
 11:31:59   Error position: <_staticteam;{If (alive _x && vehicle _>
 11:31:59   Error Undefined variable in expression: _staticteam
 11:31:59 File mpmissions\__cur_mp.Tanoa\Scripts\UPSMON\MODULES\ARTILLERY\fnc\UPSMON_artillerysetBattery.sqf, line 54

unknown moment, just found on .rpt

90% chance its caused because of despawned mortar team while the script was running. UPSMon errors may appear sometimes, but as long they are not recurrent, I don't mess with them.


Compilation in stages

Description of the Change:

Implements the "compilation in stages" model and user interface discussed in issue #108.
Optimization code moved to program_utils.py
Mocks out hafnian when building the docs
Docstring improvements

@smite @josh146 Other than some relatively minor suggestions/improvements, what is left to address on this?

Maybe just some documentation example updates to demonstrate and tie all the new pieces together?

ready to merge from my side

Ok ready to merge this once tests pass. Let's discuss finalized naming convention in #108


Fixes bug in stateFullNameFromAbbreviation so that it returns the state full name

stateFullNameFromAbbreviation was using the state abbreviation as a key into the stateAbbreviationsMap dictionary.  This always produces nil because the keys for the stateAbbreviationsMap dictionary are the full state names, not abbreviations.
This change fixes stateFullNameFromAbbreviation so that it returns the full state name that is mapped to the input state abbreviation.

Closed this because there are much better pull requests already open fixing the same issue.


Allow pinch to zoom when displaying an image

It would be great if you could support pinch to zoom when opening an image.

This would be great. I'm working on an app that involves pixel art, so it would be helpful if I could zoom in on the images while viewing them. Additionally allowing the scaling algorithm to be configured, so pixel sprites didn't appear blurry when zoomed in.

@bschlenk Same. I working on a similar project that involves < 50x50 pixel mazes. It's very tedious switching back and forth between apps just to enlarge the picture.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

@tinganho @bschlenk @pmartindev how about when you click the image it just enlarges to fill the entire width of the editor? In the same way you can click an oversizes image to show its natural dimensions already.

@bpasero that would be more consistent with the current behavior. But going full width might be too huge for images that are small. What if the image was applied as a background with background-size: contain? That way it would be fully visible in the window.

@bpasero certainly better than today, but not optimal. FYI, there is a pinch to zoom API in Chrome.
Figma are using it:
https://blog.figma.com/building-a-professional-design-tool-on-the-web-6332ed4f1fcc

@tinganho See my pull request, that's exactly what I'm using https://github.com/Microsoft/vscode/pull/38538. But I think @bpasero's comment is more about keeping the interface consistent, not about implementation details.

@bschlenk @tinganho we could have both, clicking to toggle between normal and zoomed size (to be consistent with what we do currently with too large images) and pinching for the incremental zooming.
I think displaying an icon zoomed out of the box is not right because at first it should have its normal dimensions.

I have an idea but it would break the current behavior.
Images start out centered in the page and their natural size, or fit within the window if they are larger. Clicking the image zooms it in by some factor, and alt clicking zooms out (like photoshop). Pinch and ctrl + scroll do more fine grained zooming. This would keep both scenarios (undersized vs oversized images) consistent.
I don't think there is a good way to keep the behavior consistent while keeping the current behavior.


Update ssh public key to machineconfig resource if used 4.8 cluster

With MCO enabled we need to update the ssh key to machineconfig
so it is become part of cluster and also to instance.

/hold
Since we need to revert the MCO changes on snc side.

/hold cancel

/unhold


Reopen #450: Error with Google-Services.json bundle id

Please fill in the following fields:
Unity editor version: 2018.4.3f1
Firebase Unity SDK version: v6.9.0
Source you installed the SDK (.unitypackage or Unity Package Manager):.unitypackage
Firebase plugins in use (Auth, Database, etc.):Analytics, Crashlytics
Additional SDKs you are using (Facebook, AdMob, etc.): Facebook
Platform you are using the Unity editor on (Mac, Windows, or Linux): Mac
Platform you are targeting (iOS, Android, and/or desktop): iOS, Android
Scripting Runtime (Mono, and/or IL2CPP):IL2CPP
Please describe the issue here:
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Suddenly happened! I have finished integrating Firebase yesterday, and everything worked well. But today, it suddenly force me to select a valid bundle ID. I don't know what is happenning!
Please answer the following, if applicable:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
99.999999%

same here: https://github.com/firebase/quickstart-unity/issues/450

I wonder how Firebase get the bundle id and  match it!

Hi @CodeMasterYi,
I would say check this post about ensuring that the Package Name in project settings is the same of your Firebase project.  But it does seem odd that bundle ID in the dialog box is the same as the one in the pull down menu.  Does the app still work if you select Apply?

Hi @CodeMasterYi,
I would say check this post about ensuring that the Package Name in project settings is the same of your Firebase project.  But it does seem odd that bundle ID in the dialog box is the same as the one in the pull down menu.  Does the app still work if you select Apply?

I do choose the right bundle I'd and select Apply! BUT!!! If it appears, it will appear again and again until I restart Unity Editor!!!

@CodeMasterYi
Could you double check a couple of things

What does your Editor log says?
Is the bundle Id under "Player Settings --> Bundle Identifier" matches the one in GoogleServices.plist?
Did you import multiple GoogleServices.plist?
What are other options in that dialog like?

Shawn

@chkuang-g
Hi, thx for your attention!
I search the whole project just now. Here is the result:
There is only one google-services.json and only one GoogleService-Info.plist under folder Assets/PlayServicesConfigurations.
And there is also only one google-services-desktop.json under folder Assets/StreamingAssets.
And there is also only one google-services.xml under folder Assets/Plugins/Android/Firebase/res/values.
our bundle id for android and ios is different, and it is set correctly in the player setting!
and I also check the googleservice configurations downloaded from firebase page!
bundle id for android is right.
bundle id for ios is right too.
Emmm... I didn't check the Editor Log and I don't see the dialog now. I don't know why it appears sometimes.
I dont know what you mean by saying What are other options in that dialog like?.
Tell me to select another bundle id?

What I meant is: when "Please Fix Your Bundle ID" pop-up, from the drop-down menu, how many items are in it and are they the different to your current bundle id?
Since you said that the bundle id in player settings is correct, does that mean this dialog kept prompt to ask you to change to an incorrect bundle id?
Just like to understand the situation here since we cannot reproduce this issue from our side even with both google-services.json and GoogleServices.json presented in the project.

there is two options for the dropdown list
android bundle id(selected as default when it pop-up)
& ios bundle id
Unity project is switched to Android platform.
see this:

this is what the dialog is like when it pop-up, i do not change it.
the strings that i mask are the same. they are all the android bundle id~
How can I locate the code where the dialog pop-up?

Sorry to have let this bug grow so stale!
I have a few questions:

are you still experiencing the issue with the latest (6.15) SDK?
are you able to reproduce this in the Analytics or Crashlytics quickstarts?
In the thread linked above, a user reported solving this by pulling in the generate_xml_from_google_services_json.exe from the 5.3.1 Unity SDK. Can you tell us if that fixes your issue? If it does, I want to keep this open as a bug to investigate, but it could also give you a good temporary workaround.

Since there haven't been any recent updates here, I am going to close this issue.
@CodeMasterYi if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.


Distance and Direction inconsistency with the Clear Graphics button

Distance and Direction
2.1
If it is possible, I would like to see the widget have the same behavior as the add-in. With the add-in, each tab has a "Clear Graphics" button that is used to clear only the graphics created from that tab. In the widget, the "Clear Graphics" button from any tab, will clear all the graphics that have been created with the widget.

Work completed in PR #904
@dfoll please can you verify

verified


Add web to Podcast Guru on Podcast Index - apps page

Podcast Guru, as per the following announcement, now has a "Web app". The current listing for this app on the podcast index app page (https://podcastindex.org/apps) has "Android, iOS".
I am preparing a pull request to be submitted directly to address this update.
To the developers here: thanks for all your great work on the Podcast index. Much appreciated.
Note I am not affiliated with Podcast Guru, I just found the anomaly and wanted to help out here.

From https://podcastguru.io/news/podcastguru-web-app/ they appear to now offer a "Web" option via their "Listen Now" menu item.

Thanks for noticing and fixing!


Do not create a game with empty title using only whitespace

In the "Custom Games" tab, I saw the game with the empty title. The title contains only a whitespace.
Client Version:
2021.10.0

I’ll make a server issue as well. Should there be a minimum length for the title?

Checks for empty titles were added to the server in v1.14.0. Now I am seeing some errors in the log files which means the client' isn't properly sanitizing everything:
WARNING  Jan 06  22:47:22 LobbyConnection                Client error: Title must not be empty.

This is how the checks look on
if not title.isascii():
    raise ClientError("Title must contain only ascii characters.")
if not title.strip():
    raise ClientError("Title must not be empty.")


Handle invalid proportions

See #576

It looks like the runner is trying to execute:
pip install --upgrade pip pip install -r requirements.txt

Which kinda makes sense in light of the error message:
ERROR: Could not find a version that satisfies the requirement install (from versions: none)
ERROR: No matching distribution found for install

That part of the .yml files hasn't changed, but maybe there's a newline issue here that is newly problematic? Mixed dos/unix newlines?

@grahamgower -- I think some of the issue has to do w/the CI being quite out of date.  I saw similar errors in the demes-spec PRs before the CI there got updated.

The docs build seems to be working here. It's also working for me offline, with Python 3.11. Maybe just rebase this and apply fixes for the proportions? We can do the update to Python 3.12 separately.

Oooh, codecov isn't broken, it really is just overloaded!


Suggestion: Send a message via private chat.

To avoid spam, you should only allow sending private chats to those who are following mutuals. The message may contain a link to a post. It is important if you can contain emotions in the messages.
The intention is to warn about an important post or because the person just followed and thanked you.
in portuguse:
Para evitar spam, somente deveria permitir enviar chat privativo para quem estiver seguindo mutuals. A mensagem podera conter link de uma postagem. E importante se puder conter emotions nas msgs.
A intenção e avisar sobre alguma postagem importante ou porque a pessoa acabou de seguir e agradecer.
Thanks

I couldn't understand what you meant, probably due to translation issues.
Any of the following or another suggestion?

Implementation of chat (DM) function in bsky-sh-cli

I am thinking about responding in the future, but I am not considering responding in the near future for the following reasons.

Relatively large implementation scale.
There are other features I would like to implement.
It is difficult to match the chat (DM) function and CLI operations (especially conversation sessions).

You would like to have a private chat with me.

I think open communication is sufficient at this point and private chat is not necessary.

Implementation of chat (DM) function in bsky-sh-cli

Yes !!!

 * It is difficult to match the chat (DM) function and CLI operations (especially conversation sessions).

i understand

You would like to have a private chat with me.

too ;)

I think open communication is sufficient at this point and private chat is not necessary.

ok, i I agree.
Finally I finished the translation.
There were 2 whole days dedicated to this work.
Congratulations on all this development.
I recommend activating the discussion for extra topics and conversations not directed at issues


Netlify site not building

We just started building our contributing site on Netlify, so that folks can preview their changes in PRs through Netlify deploy previews.
https://github.com/thoughtbot/bitters/commit/9cec4aef29760a5b76ea11c1a17810e241280209 was just merged to configure Netlify to build the site using Parcel. However, the build is failing, which seems to be due a Bundler versioning issue:
2:26:16 PM: Fetching gem metadata from https://rubygems.org/
2:26:16 PM: .
2:26:16 PM: Resolving dependencies...
2:26:16 PM: Bundler could not find compatible versions for gem "bundler":
2:26:16 PM:   In Gemfile:
2:26:16 PM:     bundler (~> 1.3)
2:26:16 PM:   Current Bundler version:
2:26:16 PM:     bundler (2.0.2)
2:26:16 PM: This Gemfile requires a different version of Bundler.
2:26:17 PM: failed during stage 'building site': Build script returned non-zero exit code: 1
2:26:16 PM: Perhaps you need to update Bundler by running `gem install bundler`?
2:26:16 PM: Could not find gem 'bundler (~> 1.3)' in any of the relevant sources:
2:26:16 PM:   the local ruby installation
2:26:16 PM: Error during gem install
2:26:16 PM: Error running command: Build script returned non-zero exit code: 1
2:26:16 PM: Failing build: Failed to build site
2:26:17 PM: Shutting down logging, 1 messages pending

I believe the changes in https://github.com/thoughtbot/bitters/pull/367 will resolve this.

Fixed by https://github.com/thoughtbot/bitters/pull/367.


Add Geotriggers sample

Adds the "Display information using Geotriggers" sample to the samplecode repo.

@ldanzinger C++ implementation is good to go, though I may want to clean up the formatting a bit.


When saving a Go file (with either Ctrl-S or from menu) a line near to my cursor position is removed. Does not seem to happen on plain text, just Go, so far.

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:53:14.822Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

Go
lukehoban
0.6.49

Steps to Reproduce:

This issue was moved to Microsoft/vscode-go#615


Docs Language

Can I translate the docs into my native language? Or you wish It to be only in English?

Can I translate the docs into my native language? Or do you wish It to be only in English?

You can translate since you keep English as well and update the documentation too.

You can translate since you keep English as well and update the documentation too.

I'm new to open source. What should I do first?

Don't worry, we'll help you.
1 - Fork the project to your GitHub. 2 - From the main branch create another with a suggestive name, e.g: feature/add-doc-language-<here the language that you're doing it> 3 - After all the work is done, you create a merge request from your repo to ours.
Sounds complicated, but it isn't, the GitHub UI gives you all the support to do that, but if you have any question while you're doing that you can post here and we'll help you out with that.

OK. Thank you for the answer.

Hi, @twistn1! You can contact me if you need some support in Russian
@Messhias I would vote against accepting PR adding docs on other language. By accepting PR we also accept responsibility to maintain these changes relevant. Supporting documentation in multiple languages might difficult without team of active members, who can take this responsibility. As only russian-speaking member, I cannot take this responsibility, at least for now, because of IRL difficulties caused by ongoing situation

Hi, @twistn1! You can contact me if you need some support in Russian
@Messhias I would vote against accepting PR adding docs on other language. By accepting PR we also accept responsibility to maintain these changes relevant. Supporting documentation in multiple languages might difficult without team of active members, who can take this responsibility. As only russian-speaking member, I cannot take this responsibility, at least for now, because of IRL difficulties caused by ongoing situation

@leon0399 Thank you. I will contact you if needed.
Despite if you accepting or not, I will translate it for my russian-speaking colleagues anyways. I understand your concerns, but I hope my translation could help the russian-speaking community.

Hi, @twistn1! You can contact me if you need some support in Russian
@Messhias I would vote against accepting PR adding docs in another language. By accepting PR we also accept responsibility to maintain these changes relevantly. Supporting documentation in multiple languages might be difficult without a team of active members, who can take this responsibility. As the only Russian-speaking member, I cannot take this responsibility, at least for now, because of IRL difficulties caused by the ongoing situation

I believe we don't have to take this responsibility since someone is want to do that, our only responsibility is to keep it as English, I'm a Brazil Portuguese speaker native as well and for me sometimes is hard to work with something without my native language and I understand why he wants to do that, and we're open source, so anyone can contribute, if the documentation in any other XPTO language being outdated or something like that, just go the English as well.
I don't see how this could harm the repository.
But I believe we need to vote on that to decide.
Is there's way to do some votation here on GitHub?


React game

We dont need those .png (sword, crowns...) right? and I can create svg for arrows if you we want.
Do you want to keep the foldres with resources in src?

Those are just temporary ... I will replace them with yours svg shortly.
I think it would be good to have some arrow, so we can show premoves to user. (But maybe in different color?)

Prečo si píšete po anglicky?

Prečo si píšete po anglicky?

Because it is good practice to do so. And now when we are public repository... I think we should write in English...


[Request] CMI Integration (and maybe more on Residence?)

New-ish to the plugin, so my apologies if this has been covered already, but my searches haven't turned up much. With the slow death of Essentials, CMI is posed to be the better replacement. Would love to see integration with that for warps, etc. It is premium (and so worth it), but there's an API section on the Spigot description page with links to a jar that can be used by developers and a GitHub repository.
Less important but would be cool, the same developer is also the current dev for Residence, which we would prefer to still use since we use it on our other servers. It would be really cool if a player's residence also showed up in the recall spell. The existing integration with Residence is also massively appreciated.

Hi, and welcome!
So I don't use Essentials myself, but I wasn't aware it was dying. EssentialsX seems very active and used, does it not?
So unfortunately I generally don't/can't integrate with anything that doesn't have a public Maven-available API. I have looked into Residence before, but it was such a hassle to build that I bailed on the idea.
And I definitely never integrate with premium plugins. How would I even test it?
So I'm afraid to say that both of these are kind of a no, sorry!
For warps, if you want to use Recall, you can use the builtin /mwarp command to add warps that you can use with Recall. I do realize it's a bit of a hassle to have to manage two separate warp lists, but I think that's going to be your best option.

Certainly understood. Thanks for the response and suggestion! I'll definitely look into the /mwarp feature. EssentialsX is the one I meant -- we moved away from it a while ago as well (like many seem to be doing), but while I know there is still occasional work being done, it hasn't received an official update since March and hasn't fully updated to 1.13 -- not dead yet, but seems like it's going that way.


staticinfo: port extension to protobuf

PR #3874 translates the path segment from capnp to protobuf.
To keep the footprint of the PR smaller, the static info was not ported.
Additionally, some files were modified to disable static info. The changes need to be reverted:
(locations should be tagged with a FIXME comment.)

go/cs/beaconing/extender.go
go/lib/infra/modules/combinator/staticinfo_accumulator.go

Done, #3899.

Fixed by #3899


Emy storage problem in docker

Hi,
I'm using soundfingerprinting version 7.5.5 in a asp.net core service on windows server 2019, and I'm using emy storage as a database,
Everything works fine until I get to about 950 songs. after that emy storage stop responding! I have restarted docker, windows and checked everything crossed my mind but Emy is not working anymore, When I tried to lunch emy control panel, browser opens but nothing is displayed and the screen remains white.
Is this because I'm using community version of emy or something else?
The log files in replication folder are about 500 mb in total, Is it normal?
I emailed you twice in the last two weeks to buy the Emy Enterprise version, but unfortunately I did not receive a reply.
Thanks

@AmirHossein484 this behavior is not OK. It is a sign of having not enough RAM allocated for the Docker process. How is your docker configured? Does it have enough memory?

@AmirHossein484 this behavior is not OK. It is a sign of having not enough RAM allocated for the Docker process. How is your docker configured? Does it have enough memory?

Thanks for your help, I'm new to Docker, I increased the RAM in settings and the problem was solved until I reached about 17k audio tracks, now docker container stopped automatically after starting even though docker has been set to use 24GB of my computer's RAM.
System.OutOfMemoryException
The question is, How much RAM is needed for an audio track (about 5 min), Is this normal to face OutOfMemoryException after adding about 17k tracks?
Thanks

24GB of RAM should be enough to fit 2,400 hours of content. 17K audio tracks is with an average of 5 minutes is 1.400 hours so make sure your Docker host is not consuming RAM dedicated to your Docker container.


How do I run it?

How do I test this?

On the bottom of the jupyter notebook, you can run games by running the cells at the bottom.
You can also change the games which are being run.
There is also a cell for training the models, it loads whatever model already trained and then builds on top of it.

Yeah I think I might have time to make this modular


[Theme Switching Migration] Navigation + SignIn + WholeApp Batch

Part of https://github.com/Expensify/App/issues/31677
As part of the Theme Switching Project, we need to migrate the following:

[ ] ModalStackNavigators.js,
[ ] NavigationRoot.js,
[ ] Terms.js
[ ] GrowlNotification/index.js

leaving a comment to be assigned :)

taking care of this one

We can add these files to this batch:
getRootNavigatorScreenOptions.js
src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.js
src/libs/Navigation/AppNavigator/RHPScreenOptions.js
src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.js
src/pages/signin/SignInPageLayout/signInPageStyles/index.native.js
src/pages/signin/SignInPageLayout/signInPageStyles/index.js
src/components/ScreenWrapper/index.js

updated description and assigned @lukemorawski


autogen: more fixes for autogen script

autogen.sh script supports the file .config.args where I put the
following:
--with-stage1=src
--with-stage1-systemd-src=/home/tixxdz/code/github-work/systemd/systemd
--with-stage1-systemd-version=master
So it prints at the end these arguments especially for us who build from
source, this way we don't have to remember them each time.
Signed-off-by: Djalal Harouni<EMAIL_ADDRESS>

Also, in commit message - please use build tag instead of autogen.


local Docker image

I want to check the vulnerability of a local Docker image that is not registered in the "Docker Registry", how can I do that?
If you have any information, please let me know.

See: https://docs.anchore.com/current/docs/engine/usage/integration/ci_cd/inline_scanning/
That is based on anchore-engine but runs locally.

Thank you for your comment.
I checked the URL and ran the following command, but I get the following error.
Give me some advice.
I checked the capacity with "df -h" and "df -i" and there was enough space.
[The following error occurred]
failed to register layer:ApplyLayer exit status1 stdout: stderr: write /var/lib/posgresql/data/pg_xlog/0000000100000000000000074: no space left on device
[The command you executed]
$curl -s https://ci-tools.anchore.io/inline_scan-latest | bash -s  -- -r xxxxxx:1.1.1
xxxxxx : local image names

How to do


feat(test-utils): add option to configure test server port

🔗 Linked issue
#20442
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds an optional port value to the test-utils TestOptions interface.
This value enables pinning the test server's port when calling the setup function.
The feature is required for some integration test purposes, when the tested nuxt based server backend is expected to receive a callback from the service its being tested against. Without knowing the test server's port in advance, its a lot harder to configure these sorts of tests.
Resolves #20442
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

Yes please!


Updates for Scala Native 0.5.1

[x] Waiting on https://github.com/typelevel/paiges/issues/615
[x] PR is progress - https://github.com/typelevel/paiges/pull/617
[x] Paiges is waiting for cats - https://github.com/typelevel/cats/issues/4587
[x] Waiting for Paiges release - changed from draft so it can be reviewed.

Do we want to update Scala.js to the latest?

Do we want to update Scala.js to the latest?

I think that's fine, though probably in a separate PR?

Oh, I was trying to update everything like sbt-ci-release and other things. I can back off and just touch what needs to be updated or all at once which I think might be better.

Oh, I was trying to update everything like sbt-ci-release and other things. I can back off and just touch what needs to be updated or all at once which I think might be better. sbt-native-packager is a weird one because of release problems so not sure on that one.

it would probably be better one by one, but I wonder why it didn't happen via steward

Ok, I will just back off to do only the required upgrades.

Ok, added metaconfig to the repo, that should help in this case. We can wait for the updates to show up, I just run the workflow

That is great thanks - those can all go through as I wait.

@tgodzik I will go ahead and rebase when all the updates get merged.

Should we do a new release?

I wanted to update this in case someone ever gets back to trying to port the Scala Native scalafmt. We have multi-threading now so there could be less changes. The diff(ing) part was asked to be a separate project which seemed to be the biggest part of the angst of the large change.

Och yeah, I did release it separate because of that. I need to return to the PR :|

Och yeah, I did release it separate because of that.

Do you have a link - we might be able to use it in Scala Native for our tools which we are trying to port to Scala Native as part of a potential "native" tool chain.

We release is alognside munit https://mvnrepository.com/artifact/org.scalameta/munit-diff


Create UOZ

Add our university.
http://uoz.edu.krd

@shahabzebare Pull request merged. Thank you!


Remove the imports of settings, tools and helpers layers from components

We plan to remove the imports of the settings, helpers and tools layers from all components in GOV.UK Frontend version 4.0.
We’re doing this to reduce the time it takes to compile GOV.UK Frontend’s Sass to CSS, especially if you’re using the Ruby Sass compiler.

📖  Read the proposal
💬 Add comments to this pull request, or on the proposal itself
✉ If you prefer, send feedback to<EMAIL_ADDRESS>👍 You can also +1 this pull request if you agree with the proposal and have no other feedback to give

This won't work for JavaScript applications that import the scss files directly:
This example is in React (which could be used server side only) but applies to other JavaScript server side and client side frameworks:
App.js
import React from "react";

import "./settings.scss";
import "./component.scss";

export default function Component() {
  return
Test
;
}

component.scss
.my-component {
  border: 1px solid $example;
}

settings.scss
$example: blue

Returns:
Error: Undefined variable: "$example".
        on line 2:21 of /stdin
>>   border: 1px solid $example;

https://codesandbox.io/s/govuk-design-system-architecturepull21-5x5f4
In order to make this work, an application that otherwise doesn't have any custom CSS, would need to manually make an SCSS file for every component they intend to use within their application.
How about, instead, for each component in govuk-frontend, having:

a file called accordian/_accordion.scss or accordian/_index.scss
This file has the required includes and is what users of component only css would use. This file also imports file 2:

another file called accordian/_component.scss or accordian/_accordion.scss
This file contains the component only scss with no imports.

Then have govuk/all only import the component only scss, but leave the existing component only functionality working as it does currently

Thanks @penx – that's really helpful feedback.
We explored something similar in https://github.com/alphagov/govuk-frontend/pull/1752, but we ended up deciding against it. However, we'll take another look in the context of the example you've provided 👍

Just curious and it would be good to have some background on why team are stuck with Ruby Sass?

Hey everyone 👋. I'm wondering how this is going? The due date was quite a while ago, and I expect that may have something to do with coronavirus! It would still be really helpful if we could make some progress here. We're still suffering from slow demos and slow tests.
There only seems to be one blocking issue on this card, related to using the design system in a JS/webpack context, where each import is processed in isolation. Arguably these kinds of use cases are trying to treat SASS like CSS, when they're fundamentally different.

However, we'll take another look in the context of the example you've provided

@36degrees what other approaches were we considering? In case it helps, I have a couple of suggestions, although my knowledge of this domain is quite limited:

If there's a need to consume design system as CSS, could/should we meet that need directly?
Someone else appears to have solved this problem using prependData for sass-loader

In general, it would be good to understand what more we need to do to move forward with this proposal (assuming it's viable).

Hi @benthorner
We're currently working on a revised proposal on the basis of the feedback we got on this proposal. We'll be posting the new proposal in this repo by the end of this week.
Thanks for your patience!

@penx @theseanything @kevindew @benthorner Thank you all for your feedback on this proposal.
Based on your comments, we've changed our approach and raised a new proposal, which replaces this one. It'd be great to get your feedback on it.


Exclude list

Some sites have pages that are temporary, transient, or just don't translate well to printed form (lots of links of videos, or interactive graphs). Being able to provide an --exclude-urls option with a file that lists all URLs to be excluded, or just a full list e.g. --exclude-urls="foo,bar,foo.*" would be great. Notice the regex in the last one.

implemented and close


[Vineyard Operator] Intergrate with the vineyard operator API(vineyardctl) deeply

To make better use of the capabilities(sidecar, scheduler, etc) of the vineyard operator, we want to manage all the vineyard-related components in the current graphscope through the vineyardctl API(the API component of vineyard operator). It mainly includes the following operations.

[ ] Replace the current sidecar with the sidecar API of vineyardctl
[ ] Implement the scheduling of various engines (GAE, GIE, and GLE) through the scheduler API of vineyardctl.
[ ] Provide the upper engine with the ability to backup and restore the vineyard cluster through the backup and recover API of vineyardctl.

@sighingnow @siyuan0322. Do you have any comments here?

Replace the current sidecar with the sidecar API of vineyardctl

I have no problem with that

Realize the scheduling of various engines (GAE, GIE, and GLE) through the scheduler API of vineyardctl.

I think you mean to use a different scheduler? Althrough we could only use default scheduler, it's trivial to make schedulerName configurable, which part could vineyardctl play in this context?

Provide the upper engine with the ability to backup and restore the vineyard cluster through the backup and recover API of vineyardctl.

I thought GraphScope doesn't manage the vineyard cluster, it's ought to be managed by some cluster admin. Why make engines do such management 😂

I think you mean to use a different scheduler? Althrough we could only use default scheduler, it's trivial to make schedulerName configurable, which part could vineyardctl play in this context?

It is mainly used in a workflow(GAE->GIE->GLE). Actually, we don't need to setup the schedulerName for graphscope engines. As vineyardctl supports scheduling the engines outside the cluster which will find the most fittable vineyard node and setup the relevant nodeName for engines. For more detailers about the scheduler, please refer to vineyard scheduler.

I thought GraphScope doesn't manage the vineyard cluster, it's ought to be managed by some cluster admin. Why make engines do such management 😂

Yeah, It's optional, users can also manage the vineyard cluster outside GraphScope. The thought is only to provide some configurations for engines.

Yeah, It's optional, users can also manage the vineyard cluster outside GraphScope. The thought is only to provide some configurations for engines.

Could I see some examples?

Yeah, It's managed by the CRD Backup and Recover referring the doc. If a session of GraphScope wants to backup or recover a vineyard cluster, we could simply create or delete the relevant CR here.


[Bug]: Login button state not updated after successful sign in on desktop

Contact Details
<EMAIL_ADDRESS>What happened?
On login page, the login button is disabled while logging in. In case of error, the button is enabled. However in case of successful sign-in, the state is not updated and thus is stuck at "Logging in..." for future logins.
Image:

Video:
https://www.loom.com/share/d411f7f3d11c464d8998216d066890a2?sid=72934813-89fe-4c97-981e-c181f716c6e5
Steps to reproduce the bug:

Login using email and password
User is redirected to dashboard. Now logout.
User is redirected to login page.
The login button is disabled with "Logging in..." text.

What browsers are you seeing the problem on?
Chrome, Microsoft Edge
Relevant log output
No response
Are you interested in contributing?

[X] I'd like to work on this issue

Code of Conduct

[X] I have used the search function to check if an issue already exists
[X] I agree to follow this project's Code of Conduct

Which program are you contributing in?
gssoc

@pranshugupta54 I would like fix this issue.

@holopin-bot @vinayak-vohra bug-hunter


[feat] Implement P2WSH tests/logic

Bitcoin has many different transaction types, one of them being P2WSH.
In order to support these, we will need to make sure all edge cases and some mainnet P2WSH transactions can successfully be validated by Shinigami.
Since Shinigami's design is heavily inspired by btcd, I recommend looking through all the witness transaction logic there and replicating it inside Shinigami's engine, where needed. Many witness features are implemented, but notably witness signature calculation is not done in OP_CHECKSIG/OP_CHECKMULTISIG/...
The learnmeabitcoin link can be super helpful in understanding Bitcoin P2WSH transactions in depth.
Then, using the learnmeabitcoin P2WSH examples and existing Shinigami transaction tests, create a set of tests to ensure all P2WSH transactions run properly.
Resources
learnmeabitcoin P2WSH
Existing P2PK & P2PKH tests in Shinigami
witness sig btcd

hello @b-j-roberts i would love to work on this issue :)

Hello @b-j-roberts I'm a front-end and a blockchain developer. I will love to work on this

Hi @b-j-roberts, can I work on this?

Hello, I have experience contributing to Kakarot zkEVM and I would love to spend time on this issue

Hi @b-j-roberts can I work on this ?


Contributors

Detials of the feature
@all-contributors please add @yuceltoluyag for code

@all-contributors please add @yuceltoluyag  for contributions. please add @yuceltoluyag  for contributions.

@all-contributors please add @yuceltoluyag for contributions. please add @yuceltoluyag for contributions.

I don't know if this is necessary as this is a niche area with few contributors, if no bot is added to the repo this command will not work. Therefore, I am adding this bot to the repo for you.
test 👯  #24
@all-contributors
please add @yuceltoluyag  for code.
please add @ndhao164  for code.


HADOOP-18711 upgrade to nimbus jwt 9.31

Description of PR
upgrade jar due to problematic embedded json-smart code
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 41s

trunk passed

+1 :green_heart:
compile
30m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
26m  9s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
mvnsite
29m 30s

trunk passed

-1 :x:
javadoc
0m 21s
/branch-javadoc-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root in trunk failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

+1 :green_heart:
javadoc
8m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
shadedclient
30m 52s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
27m 23s

the patch passed

+1 :green_heart:
compile
24m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 37s

the patch passed

+1 :green_heart:
compile
21m 42s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
21m 18s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

-1 :x:
javadoc
8m 36s
/results-javadoc-javadoc-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 1387 new + 0 unchanged - 0 fixed = 1387 total (was 0)

+1 :green_heart:
javadoc
7m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
shadedclient
39m 37s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
4m  5s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 30s

ASF License check generated no output?

308m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5573

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux c83f0d5870bd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 27cded28e44730ae63b000e135d9ef130ef7f636

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/testReport/

Max. process+thread count
190 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/1/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m  2s

trunk passed

+1 :green_heart:
compile
24m 55s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
mvnsite
28m 27s

trunk passed

+1 :green_heart:
javadoc
9m 46s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
shadedclient
39m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
25m  5s

the patch passed

+1 :green_heart:
compile
24m 50s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 50s

the patch passed

+1 :green_heart:
compile
21m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
21m 14s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
9m  0s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
8m  9s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
shadedclient
41m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
764m 17s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 19s

The patch does not generate ASF License warnings.

1064m 48s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.mapreduce.v2.TestMRJobs

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5573

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux e941edf969eb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 38c83e028caaa6eef41d19620566e904cef93419

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/testReport/

Max. process+thread count
2622 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/2/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 14s

Maven dependency ordering for branch

-1 :x:
mvninstall
16m 50s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
25m 11s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 39s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
mvnsite
26m 33s

trunk passed

+1 :green_heart:
javadoc
8m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 24s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
shadedclient
38m 25s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
38m 42s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
25m 51s

the patch passed

+1 :green_heart:
compile
24m 41s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 41s

the patch passed

+1 :green_heart:
compile
24m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
24m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
22m  5s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
8m 11s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
shadedclient
38m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
773m 55s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 25s

The patch does not generate ASF License warnings.

1061m 33s

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.v2.TestMRJobsWithProfiler

hadoop.mapreduce.v2.TestMRJobs

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5573

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux fa47985c98e5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0a56c736d13612993de88ac3d4f4c366ca89800f

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/testReport/

Max. process+thread count
2623 (vs. ulimit of 5500)

modules
C: hadoop-project . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5573/3/console

versions
git=2.25.1 maven=3.6.3 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Patch compile tests were green & the failing tests are failing in the daily builds as well. Merged!!!


Multi column form

I am trying to build a multi-column form and not able to figure how to build a matrix based form. Most of the examples are single column (or single child) with each question stacked to previous one.
Example. A table with 3 rows

Do you have any sample that produces a working form with this layout?

Hi @punitganshani
Your question is related to a design or a form functionality?

I'm looking for a sample that has multi row, multi-column layout

The issues is only for questions related with flutter form builder. A multi column layout is out of scope.
In other hand, maybe Table can help you


Added OAuth to events API

I was getting some nasty rate-limit issues. Addresses the issue I made about it #92.  Please take a look and tell me what you think.  Thanks.

@jwiegley Any thoughts on this?


Error when getting the container up

I am using docker compose to define my multi-container application and when use docker-compose up to start the services I get the following error regarding couchbase server
"couchbase_server_1  | standard_init_linux.go:190: exec user process caused "no such file or directory"
Following is the console o/p and I'm using docker toolbox in windows 10 machine. What could be a possible reason for this?  Can you submit a PR please?
At first glance it seems like perhaps a volume was not mounted?


Remove space between filter and language

Why:
There is an error with the documentation, it doesn't work the way it currently is written.
Closes:

No existing issue.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Removed a space.

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

@reggi Thanks so much for opening a PR! I'll get this triaged for review :zap:


"click" event in Scatter

I tried to enable both of hover and click interactions in Scatter by something like below:
scatter_chart = bq.Scatter(x=x_data, y=y_data, scales= {'x': x_sc, 'y': y_sc})
scatter_chart.interactions={'hover':'tooltip','click':'tooltip'}

def print_name(self, target):
    print("hover")
def print_figure(self, target):
    print ("clicked")

scatter_chart.on_hover(print_name)
scatter_chart.on_click(print_figure)

"hover" works fine. But "click" does not work. Did I do something wrong?

@daviddaileo The behaviour is triggered through on_element_click not on_click. Let me know if the code below works for you:
import bqplot as bq
import numpy as np

x_data = np.random.randn(10)
y_data = np.random.randn(10)

scatter_chart = bq.Scatter(x=x_data, y=y_data, scales= {'x': x_sc, 'y': y_sc})
scatter_chart.interactions={'hover':'tooltip','click':'tooltip'}

def print_name(self, target):
    print("hover")
def print_figure(self, target):
    print ("clicked")

scatter_chart.on_hover(print_name)
scatter_chart.on_element_click(print_figure)

bq.Figure(marks=[scatter_chart])

Thanks. The code works fine. But when I tried to add a button to tooltip, the button does not show at the mouse even
scatter_chart.tooltip_location
'mouse'

I keep everything else the same and redefined print_name as
def print_name(self, target):
    button = ipywidgets.Button(description= "Draw")
    scatter_chart.tooltip = button

Currently, on bqplot Figures are supported in the Tooltips. We should probably allow any Flexbox.


Fix argument error about delegate at Rails 4.2

Fix #193.
Hoe about this?

Fixed in a similar way by https://github.com/cequel/cequel/pull/218

Changes Unknown when pulling d063ef15b6bae07253205e927c2d52682cd8a8d5 on Sixeight:fix/delegate-error-at-rails-4.2.0 into ** on cequel:master**.


Feature/index template

added page structure:

main content card
sub cards for content such as graph and Spotify data
modal to inform user of login requirement
basic content import for users top 5 artists
base stylings to make it look pretty

I fixed the conflicts, the only one that was semi-large was the index page changes, It overwrote the template we started with but since this was the end goal of that template, it should be OK.


Cannot read property 'formState' of undefined

Description
After upgrading from 5.5.13 to 5.5.15, console is full of errors.

Cannot read property 'formState' of undefined

It happens in a fieldgroup with a hiddenExpression.
Bypassing this error (forcing options:{} in the field) I get others error, mainly that model is undefined in the hiddenExpression.
I didn't check in detail yet but I suspect https://github.com/ngx-formly/ngx-formly/commit/32a3a9d9cde62f82fd563784f1799f5dadf81ddd can cause it since the fieldgroup does not have a key.
Your Environment

Angular version: 9.1.1
Formly version: 5.5.15

Hi, could you please provide a reproduction example, here is a starter one https://stackblitz.com/edit/angular-yetvdu
Thanks!

@aitboudad here is one example having the same behavior https://stackblitz.com/edit/angular-yetvdu-5kianv

The provided example throws the following error: [Formly Error] There is no type by the name of "toggle" which not related to this I think, I changed toggle to checkbox and the demo works as expected maybe you didn't save your changes :thinking:

@aitboudad found the cause, a not initialized nested object was causing that, the error is just failling in the whole nested object (model.nestedObject == undefined), if i add defaultValue = {} fo nestedObject it works as expected. So let's change this issue as "error should be more precise about the cause"? Guess it should log model is null and subform can't be init. Wdyt?

Only relevant when passing a string expression, PR welcomed!


Data samples order

⚠ In order for this PR to be merged, https://github.com/SubstraFoundation/substra-tools/pull/43 and https://github.com/SubstraFoundation/substra-backend/pull/344 will have to be merged first.
Main PR: https://github.com/SubstraFoundation/substra-tools/pull/43
Fixes and activates the tests on data samples order.

Like I said on the substra-backend PR, the tests are now passing! Could you update your reviews @samlesu @AurelienGasser  ?

@jmorel I restarted the travis builds, in order to be able to merge the PR. However the tests fail. Maybe the local backend needs some changes?

@AurelienGasser I just launched the CI manually and it's using the 0.6.1 docker images instead of 0.7.0, I'll try again disabling the cache.

@jmorel any update on this?

There were 2 issues:

one with the publication of substra-tools that's been fixed (the 0.7.0 package is available on pypi)
make test-local required an update in substra that wasn't merged and was bundled with other changes. I extracted these changes in a dedicated PR https://github.com/SubstraFoundation/substra/pull/244 that should fix the issue once merged.

I've also rebased your branch @jmorel


64 bit notepad++

Hello,
I don't know why, I can't seem to be able to start your plugin. I'm using Win8 64bit with 64 bit Notepad++.  I can see the plugin with the plugin manager, but other then that I don't know how to launch it.
Thank you.

Thanks to @chcg I've built a 64-bit version, available here: http://phdesign.com.au/npptoolbucket/

See also x64 of PluginManager at https://github.com/bruderstein/nppPluginManager/releases/tag/v1.4.9


Ea awarding 2.1

This change is

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

privatmarket.robot, line 1046 at r4 (raw file):

  sleep  2s
  ${time}=  Convert To Integer  ${time}
  ${left_time}=  Evaluate  ${time}-2

щодо evaluate, то старайтесь уникати його, краще замінити функцією пітонівською

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

privatmarket.robot, line 1048 at r4 (raw file):

  ${left_time}=  Evaluate  ${time}-2
  ${element_state}=  Check If Element Stale  ${locator}
  run keyword if  ${element_state} and ${left_time} > 0  Wait Until Element Not Stale  ${locator}  ${left_time}

Run Keyword If

Comments from Reviewable


Potential fix for: Uncaught TypeError: Cannot read property 'tweensCo…

…ntainer' of undefined
Fixes https://github.com/julianshapiro/velocity/issues/305

Dunno how to handle the minified

I think you missed a check that data was not undefined - just tried this fix and got the following error:
velocity.js:2830 Uncaught TypeError: Cannot read property 'isSVG' of undefined

adding a check (data && ...) fixed it

@brollb You can add line comments on the code itself - but looks like one the original code was missing too, nice catch :-)


how to use with prisma1?

https://nexus.js.org/docs/database-access-with-prisma states that this plugin works with prisma1 (prisma 2 is still in preview)
however, nexus-prisma does not expose the functions mentioned in the docs:
import { makePrismaSchema, prismaObjectType } from "nexus-prisma";

both do not exist. It seems that nexus-prisma introduced a BREAKING CHANGE that was not documented in the release notes.
Which version of nexus-prisma are we supposed to use if we are still on prisma1?

ok, seems like something is wrong with the npm tags.
Currently "latest" on npm is 0.0.1-beta.6,
but this repo suggest its 0.3.7

Its weird as the 0.0.1-beta.x has been updating for this months as the latest version (even in 9 hours ago for 0.0.1-beta.7) but actually 0.3.7 is the most updated one...
What happens in the version management here?

A guess:

0.3.7 is via https://github.com/prisma/nexus-prisma/tree/master/packages/nexus-prisma
0.0.1-beta.x is via https://github.com/prisma/nexus-prisma/blob/next/package.json (note the different branch)

But @jasonkuhrt will be able to tell you more about why this is the case.

@janpio yes, default branch of the git repo is next.
The problem is, that in npm, you can publish any version. If someone npm install / yarn add your package, it will take the "latest" version in the registry, that i is the most recent published one. As far as i now, npm registry itself has no concept of higher or lower version number, so like in this case a 0.0.1-beta.0 can be more recent as a 0.3.7 version.
The only mechanism npm provides are the release tags. Usually you will publish normal "stable" version with the default "latest" tag and beta, alpha or prereleases with a different tag like "beta", "next" or so.
In this case, i think the most recent beta version was accidentially published with the default tag, as the older 0.0.1-beta.5 version was released with the beta tag: https://www.npmjs.com/package/nexus-prisma
This shows the need of a good, automated release-management and its a pitty that npm and github do not offer something better out-of-the-box. but that's off-topic

closing this now, but i think the maintainers should fix the wrong latest version

Let's keep this open for @jasonkuhrt, who works on this, to actually have a look.

Hey 🙂👋 getting the versioning system sorted out and automated is a high priority. I will tackle it this month if not this week.

A guess:

@janpio 👍

i think the maintainers should fix the wrong latest version

@macrozone Agree, and thanks for raising the issue 🙏

What happens in the version management here?

@seed-of-apricot yes its confusing, even to me. We will need to figure out how Prisma 1 & 2 co-exist.
I will use this issue to track fixing the latest tag. I've also created several additional issues  linked to here.

done
❯ npm info nexus-prisma | grep dist-tags -A2
dist-tags:
beta: 0.0.1-beta.7
latest: 0.3.7


Multiple GPU tests run redundantly

Using TensorFlow 2.4.1
Describe the problem
I noticed that some GPU tests are run multiple times redundantly with apparently no need or benefit causing test times to increase.
Example: //tensorflow/core/kernels/mlir_generated:gpu_tanh_test, //tensorflow/core/kernels/mlir_generated:gpu_tanh_test_gpu
As you can see there is a gpu_* test and a gpu_*_gpu test
This happens because tf_cuda_cc_test rule is used which creates a CPU and a GPU test already. However as the test is meant for GPU already and has tags = tf_cuda_tests_tags() set, it will create 2 tests that are both run (only) on GPU
As current master has changed considerably I just did a quick check and found e.g.:
https://github.com/tensorflow/tensorflow/blob/c820e5278288773ef2298b1796164a9826d847cf/tensorflow/core/kernels/mlir_generated/BUILD#L332-L345
This follows the same pattern and should likely be revised. I quick fix would likely be: If the passed tags already contain gpu then the CPU test will not be added.

Hi @Flamefire !
We are checking to see whether you still need help in this issue .  I think the unit test related to tanh moved to gpu_unary_ops_test in 2.8.2 later versions.
I tested with above test in 2.9.2 version and build passed .
Attached gist for reference.
Thank you!

Yes the issue still persists: https://github.com/tensorflow/tensorflow/blob/73e20279c60fc77aa377ce42d36644b832d8a5d6/tensorflow/core/kernels/mlir_generated/BUILD#L450-L470

Ok @Flamefire !
Thanks for the update. But , Did you check my gist too.
Thank you!

Thanks @mohantym for the reply.
Seems you have missed that the issue is not a failing test but rather a redundant test due to a "CPU" test copy created for a GPU test, see the current master: https://github.com/tensorflow/tensorflow/blob/1b32744e65e8fdfb4fd694326fd1fa2fc9613acc/tensorflow/tensorflow.bzl#L1409
I.e. for the above quoted example it will create a test gpu_unary_ops_test_cpu and gpu_unary_ops_test_gpu both with tags = tf_cuda_tests_tags()
See my initial description


Crash on lighting portal with BetterTrims

Is it a mod compatibility issue?
Yes
If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)
BetterTrims:

Modrinth
GitHub

Minecraft version
1.20.1
Describe the issue
When lighting a portal, the game immediately freezes before the portal could be initialized. The game becomes unresponsive and after a while crashes to desktop. In singleplayer worlds, reopening the world shows that no portal link has been established before the crash, thus it is impossible to enter the Nether while both Immersive Portals and BetterTrims are loaded.
On a modded Fabric server, only the modded Minecraft client crashes. Rejoining the server is fine and even shows that the linking of portals was successful.
Both mods work great/fine on their own.
Run on Fabric loader version 0.14.22 for Minecraft 1.20.1, which is run on a Windows 10 computer with an Nvidia GPU.
Mods used during testing:

fabric-api-0.86.1+1.20.1
modmenu-7.2.1
sodium-fabric-mc-1.20.1-0.5.0
bettertrims-1.2.2
immersive-portals-3.2.3-mc1.20.1-fabric

I've attached a log file of the Minecraft fabric client and a crash report.

This is fixed already in the version 2.1.0 of Better Trims, isn't it? https://github.com/Bawnorton/BetterTrims/releases/tag/2.3.1
I'm using Immersive Portals 3.3.7 and BetterTrism 2.3.1 in Fabric 0.16.0 Minecraft 1.20.1 and I didn't have any crash.


Help me about onCompleted()

Okay, I have BlockingSteps, at the last step, the Next Button was changed to Complete, the problem is, the process inside onComplete() is not displaying (ex. Toast). Can somebody help me with this?

@poltographer6  what are you doing in verifyStep() in your Fragment ? If you want the button to be disabled until the user selects a file ( verifyStep will return an error if there is no file selected) you need to manually call verifyStep() when the file is available.

I didn't edit verifyStep().. Next button is always enabled. It works fine until the last step, Complete button doesnt do anything.  I used BlockingStep so that I can use method onNextClicked(). In that method I check for errors. If there's no error, it will call  callback.goToNextStep(); The only problem is the Complete button, It's like there's no listener for that button.

@poltographer6   as discussed in #52  and #83  the last fragment will not call onNextClicked().
So you can either wait for #87  to be approved or find some workaround (#52 mentions some).
You can also look in the sample app and see how OnProcessListener is used.
Another thing, in the source code you provided in #83  I noticed that you didn't set the listener to the stepper layout  (you are missing  mStepperLayout.setListener(this);).

Thanks for this!
mStepperLayout.setListener(this)

But I think we need the request to check if there's no error in the last step before proceeding to onComplete()


Active Peer Discovery

Ask peers for other peers.
https://godoc.org/github.com/libp2p/go-libp2p-discovery

Done in #55


Is it possible to use SelectiveBloomEffect and a HDRJPG Background/Environment and have the background be masked using ignoreBackground or is a different method required?

Description of the bug
Trying to use SelectiveBloomEffect set at a Threshold of 2 to mask out Luminance of HDRJPG background so only the gltf asset with KHR_Emissive_strength set to 10 will be affected, but currently the background is being affected. I have tried setting up ignoreBackground in RenderPass and setting it to true in my SelectiveBloomEffect but it still is blowing out the background. It seems like Bloom is using the Luminance of the HDRJPG background? I would expect if the Threshold is set to 2 then the background would be masked from Bloom.
To reproduce
Use an HDRJPG in scene.Background and scene.Environment and add SelectiveBloomEffect with Threshold 2, Intensity 1, Radius .5, Smoothing .025, and BlendMode set to Screen or Add.
Expected behavior
Expected the background to be masked from Bloom. Like this image but only the teal sphere glowing.

Screenshots

Library versions used

Three: r166
Post Processing: 6.35.5

Desktop
Windows, Chrome, 127.0.6533.88/89

I would expect if the Threshold is set to 2 then the background would be masked from Bloom.

That only works if the luminance of the HDR image never exceeds 2. Judging by the results however, the image seems to contain values that are much greater than that.

I have tried setting up ignoreBackground in RenderPass and setting it to true in my SelectiveBloomEffect but it still is blowing out the background.

SelectiveBloomEffect should mask out the background if SelectiveBloomEffect.ignoreBackground is set to true. RenderPass.ignoreBackground skips rendering the background altogether on a scene rendering level.
I'm moving this to the forum since it's a general question.


System.MissingMethodException for ComWrappers.RegisterForTrackerSupport on startup

I'm not sure if this is something I'm doing wrong, but after updating to the latest C#/WinRT, I'm seeing this exception thrown on startup:
System.MissingMethodException: 'Method not found: 'Void System.Runtime.InteropServices.ComWrappers.RegisterForTrackerSupport(System.Runtime.InteropServices.ComWrappers)'.'
It looks like a reference to that method was added in this commit, but the version of System.Runtime.InteropServices.dll that's being packaged with my app does not have that method in it.  I'm using the version of the .NET SDK listed as required in this commit - possibly more of the change in the previous commit needs to be backed out to accompany the version downgrade?

Yes, the new versions of C#/WinRT require Preview 5. There was a breaking API change to enable fixing some C#/WinRT issues between Preview 4 and 5.

@Llongley - have you been able to confirm that you're referenced .net sdk preview 5?

I thought I was, but it turned out that us installing it to a custom directory was causing problems where it was being picked up some times but not other times.  Moving the install to the default directory looks like it fixed things.  Sorry for the randomization!


docs: fix 2.x link

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the dev branch.
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue-test-utils/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Thanks!


GOOGLE_CLOUD_PROJECT env not supported?

I believe GOOGLE_CLOUD_PROJECT used to be supported, but isn't anymore?
Here, can we change
if (process.env.GCLOUD_PROJECT) {
  defaultConfig.projectId = process.env.GCLOUD_PROJECT;
}

to
if (process.env.GCLOUD_PROJECT || process.env.GOOGLE_CLOUD_PROJECT) {
  defaultConfig.projectId = process.env.GCLOUD_PROJECT || process.env.GOOGLE_CLOUD_PROJECT;
}

We'd would also like this for GoogleCloudPlatform/cloud-profiler-nodejs (google-cloud/cloud-profiler-nodejs).

They are both already supported, unless you found it not to work someplace?

Since we support GOOGLE_CLOUD_PROJECT, I'm going to close. If anyone finds an instance where we don't, let me know!


Changed default PNP timeout to a variable set by env

Description
Set the PNP signer and combiner timout to a variable set by the env. If missing, will default to FULL_NODE_TIMEOUT_IN_MS

Related to #10333, but does may not resolve the issue.


Save as JSON format

Save button that download a formatted file like:
{
  board: [Array], // 1D Array that contains all the board
  words: [Array], // 1D Array that contains all the words in the board
  reverse: bool   // Enable reverse?
}

Can save canvas also in png format with a button