GitBucket development setup - Question

Hi,
I've been using GitBucket and its been great.  I would like to see if I could participate in making some additions to the project in my spare time. Specifically, I'd like to extend the API functionalitty. I've been going through the Developer's Guide, but I am struggling to include the scalatra-forms. I've got the source and I've ran sbt in command-prompt, but the documentation isn't 100% clear to the new commers as to where to add the changes suggested.
Could anyone provide some guidance? I am looking to update the developer's guide to make it easier for people in similar situation like mine.

+1
I would also like to know some more details about how to develop and also extend with plug-ins GitBucket! :).
Since there seems to be so many open issues with feature requests (and many of them seem to be better suited as a plug-in), maybe the community could help more if the entry would not be that steep.

Developer's Guide is here. But we know it's not enough.
https://github.com/takezoe/gitbucket/tree/master/doc
In addition, plug-in system and API are still unstable. So we can not start documentation soon. But of course, we will provide it in the future.

+1 for documentation of the current (unstable) plug-in API.
I think, it's perfectly ok that the API is suspected to change as long as it is stated in the docs. But if nobody experiments with it because of lack of documentation, we won't get any feedback and the API will never get stable.
Nobody required a perfectly written book, but some bullet list covering the most important facts would be really helpful.

By trial and error I have got most of the dependencies installed and I am working on a bullet point list of steps as well as common setup issues (as I've come across some) which I will share with everyone. I am just stuck at solving the scalatra-forms dependency. I got sources from the @takezoe 's repository, but not sure what to do with it and how to do it.

@FlYnN91 Can you explain more about what's tripping you up with scalatra-forms?
Other than being in a separate Maven repo...which is configured in project/build.scala and should be handled transparently by sbt...it should be no different than any other dependency.  And I don't think scalatra-forms is used by any of the API code.  As long as sbt pulls down the binary JAR from @takezoe's repo you should be set to make changes within gitbucket.core.api while mostly ignoring scalatra-forms.

@bfritz I've got it working. Woohoo!

These are my steps to getting GitBucket running on a Windows local machine.

Install Java

Ensure javac and java are accessible from command line

Install Scala
Install Scalatra

Download and Run Conscript Executable JAR
Add cs.bat to PATH
Install giter8 - in command line run cs n8han/giter8

Install sbt

Add Environment Variable GITBUCKET_VERSION with value 3.3

Clone/Pull GitBucket repository
Go to the repository folder, open command line.
Depending on what you want to do choose one of the following set of commands from Developer's Guide

Give couple of minutes to compile project and then visit http://localhost:8080

These steps worked for me very well. Hope it helps someone.

Huh, I'm on Linux, but I thought it is enough to have Java and sbt installed. No need to have a local installation of Scala or Scalatra or giter8. At least under Linux it's not needed.

I did not test without them, but you may be right. If it works without them then that's even better.

No need to have a local installation of sbt. gitbucket epository include sbt jar and sbt.sh ( and sbt.bat ).

Close all questions. If you have any questions about GitBucket, please send them to the gitter room instead of issue according to the Guideline for Issues.


PHP 8 support?

Is PHP 8 supported yet? I just tried 1.2.8 and ran into this issue.
ERROR: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) {"exception":"[object] (Symfony\\Component\\ErrorHandler\\Error\\FatalError(code: 0): Declaration of Doctrine\\DBAL\\Driver\\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) at /www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:86)

From what I can tell the doctrine/dbal dependency seems to be outdated?

same


Space supporter process write permissions

Hello CAPI team,
This is a PR to allow the space supporter role to access POST, PATCH, and DELETE actions on process endpoints. This addresses this issue and is part of the larger track of work to add the space supporter role to CCNG.
Please let us know if you have any feedback.
Thanks,
@galenhammond && @belinda-liu
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

Hey Sarah, thanks for the feedback! We've pushed a commit updating the docs.
In terms of the role specific context, we actually intentionally wanted to call out that the two cases are for the space supporter role. We were unable to use the shared examples for permission checks on the process scale endpoints, so we added these two one-off examples to complete our test coverage for the space supporter role. We think that changing the title of these contexts could potentially be misleading, but we're curious to hear your input!
Best,
@belinda-liu & Galen

We had a quick discussion with @sweinstein22 about the role-specific tests. She pointed out that the tests may be using the wrong headers, which turned out to be true. I just pushed a commit to use the correct headers, with some slight formatting to hopefully make the test more explicit that it's using the space supporter role.


Recorded voicemail link only sent to SMS phone, email box is not getting the same voicemail link

created amazon connect instance
deployed Voicemail package with above instance
sync users on portal from connect instance
Define both email/sms as delivery options
Defined and verified delivery email account in SES

tested the voicemail, only phone received SMS but mailbox is not able to receive voicemail transcript link

This is working as expected in the latest version 1.1.0, please reopen if you continue facing issues.


packit: Drop the COPR jobs

Along with composer I'm proposing we drop the copr steps in packit. We're already building the RPMs ourselves so this doesn't add any value but just wastes CO2.

This does give us testing on architectures we don't support ourselves, and onboarding new os versions with packit is easier than doing our own. So I think we should consider keeping it. If we could one day drop our own mockbuild one day that would of course be even better...

This does give us testing on architectures we don't support ourselves, and onboarding new os versions with packit is easier than doing our own. So I think we should consider keeping it. If we could one day drop our own mockbuild one day that would of course be even better...

Oh, I didn't know. Which archs is packit/copr currently building that we're not building? Would it make sense to limit ourselves to those?

Packit builds also s390x and Fedora rawhide. I don't see much value in building on s390x as osbuild produces noarch packages, thus packages from other arches should the same. I can see some value in building against rawhide, some false negatives are to be expected though.
My main idea behind this removal is that we are not using these RPMs for anything, thus we are only burning CPU cycles (I don't care about our CPU cycles but I feel kinda bad about cycles paid by other teams.) Of course, it would be super-awesome if Schutzbot can use RPMs built by Packit which would make our infra simpler but we're not there yet (we're building against RHEL nightlies and also we would need to write plumbing connecting Packit and Schutzbot).

I have actually used the copr's quite a bit, especially for auto, since they are easier to use than the ones we generate. Especially the one the copr repo that follows main.

PS: I have even used the S390x ones for testing, mostly due to convenience, since @ondrejbudai is right and they are noarch so we in theory need to only build one architecture. I do see the argument about CO2 and duplicated  work but I would still strongly vote to keep the copr builds. I meant to file a bug with Packit to have a feature that lets us integrate Schutzbot with them at least for the fedora builds, but have not gotten around to do so yet, maybe we should.

I'm happy to amend this PR in any way - be it to just close it or to remove all arches apart from one (just need to know which one you'd like me to pick) :)

I would vote to keep packit copr for all arches and focus on other things to improve CO2 waste, like retries in some of the tests that fail more often where we then have to restart and re-run a lot of tests that take long.

Alright - let's keep copr!


Release 4.17

Release date
September 28th, 2020
Announcement draft
This is a concise changelog. Refer to Nuvola News for a more verbose one and to see some screenshots.
What’s New for Users

MusicBrainz Scrobbling: The most popular scrobbling service is Last.fm, which is supported by Nuvola for a long time. There is also a free/open-source alternative Libre.fm, which was reintroduced in Nuvola 4.16. Nuvola 4.17 adds the third service — MusicBrainz [GitHub ticket].

New script - Idagio: IDAGIO is a paid streaming service specializing in classical music. The company is based in Berlin, Germany.

New script - DI.FM: DI.FM (also known as Digitally Imported) is an Internet radio broadcaster consisting of over 90 channels dedicated exclusively to electronic music.

New script - Primephonic: Primephonic is a Dutch-American start-up founded by a team of classical music lovers with the ambition to create a better future for classical music by finally developing a streaming service that gets classical right.

Amazon Cloud Player 5.10:

Add Brazil support [GitHub issue].
Add India [GitHub issue]
Press PlayAll instead of Play after restart [GitHub issue]

Deezer script 3.3:

Fix wrong song data when Deezer is switched to Queue view [GitHub issue]
Disable broken volume management.
Fix the repeat button.
Fix the love button in the queue view.

Google Play Music script 6.3:

Mask as Safari to work around Google sign-in issues. [GitHub issue]

Jupiter Broadcasting 1.5:

Adjust to the Jupiter Broadcasting site redesign.
Add the Friday Stream.
Add Jupiter Extras.
Add Linux Headlines.

Sirius XM script 1.6:

Add Canadian variant [GitHub issue].
Adjust metadata parsing to recent Sirius XM changes.

Spotify script 3.2:

Update a web view screenshot.
Fix playback actions [GitHub issue].
Fix song title and artist retrieval [GitHub pull request].
Fix album art retrieval.
Fix volume management.

Tidal script 1.1:

Widevine support for Tidal [GitHub issue]
Adjust metadata parsing to recent Tidal changes.

YouTube script 2.2:

Mask as Safari to work around Google sign-in issues. [GitHub issue]
Fix parsing of track title and artist.

YouTube Music script 1.4:

Mask as Safari to work around Google sign-in issues. [GitHub issue]
Fix Logout action [GitHub issue].
Fix play/pause buttons [GitHub issue].
Remove broken code to skip ads. Purchasing YouTube Music Premium is a better option.
Skip metadata parsing when an ad is playing.

Installation Instructions Updated

Added: Ubuntu 20.04 LTS Focal Fossa and elementaryOS 5.1 Hera
Improved:  Debian, Fedora, and Arch Linux instructions.
Removed: Various older releases.

Non-media-streaming apps are deprecated. Non-streaming web apps are deprecated and won’t be available in the upcoming Nuvola 5.

Qobuz service needs a new maintainer. The original maintainer lost interest in Qobuz. We are looking for a maintainer residing in the countries where Qobuz is available because we couldn’t overcome very strict geographic checks [GitHub issue]:

Other changes:

Added another allowed URL for Facebook login.
Added instructions on how to use host Nvidia drivers [GitHub issue].
Added workarounds to address Google sign-in issues [GitHub issue].
A bug that prevented the selection of the Adwaita theme was fixed [GitHub issue].
An issue with multimedia keys in KDE was resolved [GitHub issue].
Nuvola now handles network issues better [GitHub issue].
The lyrics’ sidebar is automatically opened when enabled [GitHub issue].
Fixed a crash in preferences dialog during a license key check [GitHub issue].

What’s New for Script Maintainers

We now accept media streaming apps only. Other apps (e.g. Google Calendar and Google Keep) are deprecated [GitHub issue].
Circle CI jobs are robust against network failure [GitHub issue].
Nuvola flatpaks were upgraded to GNOME SDK 3.32 [GitHub issue], 3.34 [GitHub issue], and finally 3.36 [GitHub issue] since the release of Nuvola 4.16.
Nuvola flatpaks were upgraded to use Vala 0.48 [GitHub issue].

Released: https://medium.com/nuvola-news/nuvola-4-17-released-80852f885e90


Random crash

What happened?
Jumped down, 6 to 8 blocks, got damage and Minecraft crashed.
Modloader
Fabric (Default)
Minecraft Version
1.20.2
Mod Version
brb-1.10.0+1.20.2
Relevant log output
java.lang.ArithmeticException: / by zero
	at net.minecraft.class_513.handler$zpn000$brb$render(class_513.java:2056)
	at net.minecraft.class_513.method_2634(class_513.java)
	at net.minecraft.class_507.method_25394(class_507.java:304)
	at net.minecraft.class_490.method_25394(class_490.java:84)
	at net.minecraft.class_437.method_47413(class_437.java:110)
	at net.minecraft.class_757.method_3192(class_757.java:946)
	at net.minecraft.class_310.method_1523(class_310.java:1275)
	at net.minecraft.class_310.method_1514(class_310.java:856)
	at net.minecraft.client.main.Main.main(Main.java:253)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

that sounds insane and impossibly to debug probably packets from the server unlocking or something @TauCubed any ideas

I think it's now the second time that I encounter this bug. Or maybe even the third time.
It comes from the rare side and the priority can be set really low - but I wanted to report 😊

that sounds insane and impossibly to debug probably packets from the server unlocking recipes or something @TauCubed any ideas

It was caused by scrolling with an empty recipe book page.

I noticed that you are using version 1.20.2 (I misread it as 1.20.4) could you please test that this crash happens in that version when the following conditions are met?

You have scrolling enabled
You have "Showing Craftable" enabled
You have no craftable recipes shown
Scroll up or down while hovering the recipe book page

Thank you.

I have to thank you, tested it right now and Minecraft instantly crashed. Good that I know now, what to avoid 😂

Thanks for the fast fix - do you plan to publish this version soon?


RegEx errors in edit version tag

Describe the bug
I noticed several errors in the console when editing a version tag. I assume they're being ignored by the browser, that the browser is not validating the input, but I'm not sure.
To Reproduce
Steps to reproduce the behavior:

Log on to Dockstore
Go to My Tools
Select a tool, then go to versions tab
For a version, click Actions | Edit
See following errors in Developer Tools console

Unable to check <input pattern='[\w-]+((/|.)[\w-]+)*'> because the pattern is not a valid regexp: character class escape cannot be used in class range in regular expression
Unable to check <input pattern='^/([^/?:*|<>]+/)*(([a-zA-Z]+[.])?Dockerfile|Dockerfile([.][a-zA-Z]+)?)$'> because the pattern is not a valid regexp: invalid character in class in regular expression
Unable to check <input pattern='^/([^/?:*|<>]+/)*[^/?:*|<>]+.(cwl|yaml|yml)'> because the pattern is not a valid regexp: invalid character in class in regular expression
Unable to check <input pattern='^/([^/?:*|<>]+/)*[^/?:*|<>]+.wdl$'> because the pattern is not a valid regexp: invalid character in class in regular expression

Expected behavior
There should be no errors in the console
Additional context
[Domain] - https://qa.dockstore.org
Webservice

74674f8

UI

2.12.1-55-gb4a52e78

Deploy

1.15.1-46-ga8934fc

cwlParsingLambdaVersion: n/a
wdlParsingLambdaVersion: n/a
nextflowParsingLambdaVersion: n/a
galaxyParsingLambdaVersion: 0.0.6
checkUrlLambdaVersion: n/a
┆Issue is synchronized with this Jira Story
┆Attachments: image-20240927-135507.png
┆Fix Versions: Dockstore 1.16
┆Issue Number: DOCK-2533
┆Sprint: 146 - Tsim Sha Tsui
┆Issue Type: Story

Follow-up in 1.16.x


Use redux thunk for handling async code

Redux Thunks
Background
Sagas are our current redux middleware used for writing async functions. Although they can be very powerful, they're overkill in most instances and bring about a higher learning curve than other alternatives. Sagas are good for complex async workflows that involve things such as debouncing, cancelling requests, and background threaded behavior – benefits that are generally not needed in our use case.
Description
In an attempt to remove sagas from our code this approach utilizes redux thunks as a middleware for writing async logic as basic functions
Pros

Components don't have to be aware of how actions are implemented (whether synchronous or asynchronous)
Easy to maintain especially when multiple components require the same async logic for updates redux state
Officially recommended by redux

Cons

Somewhat ambiguous not knowing what the action is doing when looking from the react side
Might make mocking for unit tests a little more difficult

/restest-required

Due to this work, authentication tests are being skipped (can be found in PR 3997). Previously, errors in the feature flags reducer file caused integration tests to deceptively pass after the login screen due to this code in MainPage.tsx where the app would get stuck on the loading screen:
// Render Body and NavigationSideBar only when feature flags and permissions are available.
if (isLoadingFeatureFlags || isLoadingPermissions) {
    return <LoadingSection message="Loading..." />;
}

After correcting the issue in the feature flags reducer, authentication tests began failing because required redux properties past the loading screen were not getting setup properly.


Case studies on impact of R training

One of the attendees at RPySoc unconference suggested it would be helpful to write up some case studies of when R training has been beneficial in a team. Particularly in terms of "it saved my team X time or X money".
Do we already have some case studies somewhere? If not, is there a team we could approach to write one?

We had a few success stories which I moved to the blogs for the new site. https://nhsrcommunity.com/blog/#category=Reflections I've heard of time being saved, I think in some talks but I can't remember who said what exactly.


[Bug]: Rest API response - last line is truncated in viewport

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://user-images.githubusercontent.com/94514895/223119984-5d1ee742-6d66-485d-8aaa-1138df6abc1e.mov
Steps To Reproduce

run a rest api request that has a long response
scroll to the bottom
--> see that the last line is truncated

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

@rohan-arthur Can you please assign this to me?

Hi @CKanishka apologies for the delay in response. Thanks for showing interest in contributing to Appsmith. Would you be interested in picking this up ?

@sumitsum Sure will pick this up

Thanks @CKanishka , I have assigned the issue to you.

@sumitsum I have raised the PR for this fix, can you please review it?

fixed with #29534


add -u to apk add command, remove testing from php7

Just a little tidy up

php7 does not need the testing repository anymore
add -u to each apk command to ensure it gets the latest versions

@jakewright just a sanity check as you pointed out the failing builds


fix the typo

Hi!
First of all, thanks a lot of this awesome tool!
I've just installed it and found a little typo in the post-install message, so this quick PR fixes it.
Nothing much really.
Thanks again!

Thank you :)


Add missing includes for <sys/time.h> and

This fixes two separate issues:

With newer GCC versions (>= 7), including <functional> is required when using std::function. Without the include, the build fails with
 error: 'function' in namespace 'std' does not name a template type

See this Fedora build for an example.

On PPC64, using timeval requires to include <sys/time.h>. Without the include, the build fails with
 error: field 'capture_time' has incomplete type struct timeval capture_time;

See this Fedora build for an example.

Hi @morxa, thanks for pointing out these problems.
Could you please review CONTRIBUTING.md

My legal name is Till Hofmann.
I agree to the terms of the Intel® RealSense™ Cross Platform API CLA.


chore: cleanup repository (DEV-447)

resolves DEV-447

Does it make sense to keep .vscode/ folder in git?

I can make a gitignore file as part of my task to make a playground

ok, now. add vscode and dist stuff to gitignore and removed it from the repository.


cli-test.sh waits for CLN block processing to complete before attempting lightning payments

Attempt to fix intermittant CI failure in cli-test.sh where we're mining blocks too quickly (according to Rusty Russell).

Codecov Report
Base: 67.01% // Head: 67.01% // No change to project coverage :thumbsup:

Coverage data is based on head (0f262a0) compared to base (add674b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   67.01%   67.01%
=======================================
  Files          85       85
  Lines       12428    12428
=======================================
  Hits         8329     8329
  Misses       4099     4099

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Can't encode tracks with notes that are less than 12 (C0)

Adding a note like this:
track.note(11, time, duration);

Then encoding like this:
Uint8Array.from(midi.toArray())

Throws this:
ERROR TypeError: Cannot read property '1' of null
    at Object.midiPitchFromNote (scripts.bundle.js:12)
    at Object.ensureMidiPitch (scripts.bundle.js:12)
    at a.addNoteOn.a.noteOn (scripts.bundle.js:12)
    at Array.<anonymous> (scripts.bundle.js:12)
    at i (scripts.bundle.js:12)
    at a (scripts.bundle.js:12)
    at t.value (scripts.bundle.js:12)
    at scripts.bundle.js:12
    at Array.forEach (<anonymous>)
    at t.value (scripts.bundle.js:12)

But by doing
    track.note(12, time, duration);

No problems arise when encoding

moved to midi-file for decoding/encoding and this does not appear to be the case any more


branch develop : compile error ‘fMidiEventURID’ was not declared in this scope

In file included from ../../dpf/distrho/DistrhoUIMain.cpp:26:
../../dpf/distrho/src/DistrhoUILV2.cpp: In member function ‘void DISTRHO::UiLv2::sendNote(uint8_t, uint8_t, uint8_t)’:
../../dpf/distrho/src/DistrhoUILV2.cpp:312:35: error: ‘fMidiEventURID’ was not declared in this scope
  312 |         atomMidiEvent.atom.type = fMidiEventURID;

I did some research on it. The variable got removed in 9d09b5e15b314eba3b96fdd70171e3f1ad1f0072 in ./distrho/src/DistrhoUILV2.cpp .

I have submitted https://github.com/DISTRHO/DPF/pull/261 which should resolve this.

Bug is fixed on develop branch.
I will make that the default branch soon, in preparation for the pugl rework.


environments.txt

environments.txt 怎么创建不了虚拟环境

Sorry for being late, tough months about lots of deadlines.
Any details about the bug log?

Sorry for being late, tough months about lots of deadlines.
Any details about the bug log?


Update NRT_AuthenticationMethodsChangedforVIPUsers.yaml

Fixing issue - https://github.com/Azure/Azure-Sentinel/issues/8187
Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Hello @esfateev, Thank you for raising this PR. This PR will be reviewed and will update you about the same before 26 September, 2023.

Hello @esfateev, Everything looks good. I've repackaged the solution with latest changes.
Please agree the license requirements.

@microsoft-github-policy-service agree


[WIP] Use mut slices

Part of #24.

Needs to be rebased.

Please don't merge, not all of them are translated yet.

Need to run fmt on this.

@axic is this ready for merge?

I think we never made a decision on https://github.com/ewasm/ewasm-rust-api/pull/28#discussion_r239648057, but can merge it without that.
I think it should be ready.

@axic I gave my opinion in the comments, you can make the decision


FormLabel component

This is an issue to track the work to create a form label component. The create job form has a number of form components (text, checkbox, dropdown) that have a label component. This would be a simple component to help with reusability and consistency:

Use a label element.
Be styled using Jupyter's theme CSS properties and the overall style of this extension.

Closing as fixed in main.


chore: update examples and use Terraform test framework

Instead of adding a new section to the README, I'd just update the existing section to use the built-in testing framework instead of Go and Terratest. If the built-in framework covers the same ground as Terratest anyway, I'd just remove the deprecated test directory entirely 👀

Instead of adding a new section to the README, I'd just update the existing section to use the built-in testing framework instead of Go and Terratest. If the built-in framework covers the same ground as Terratest anyway, I'd just remove the deprecated test directory entirely 👀

I was thinking something similar 🎉 I'll implement your suggestion, but first there is some more adjustments we could do in regards to test the apply command. Right now, this test only runs the plan which is in some cases different from apply, and I'd like to go ahead and see if we can get the "mocking" functionality to work 👀

The tests here could potentionally be updated with assert blocks testing different scenarios, but leaving out for now.
run "unit_tests" {
  command = plan

  module {
    source = "./examples/<example>"
  }

  assert {
    condition     = ""
    error_message = ""
  }
}

A more general comment: should we leave the comments regarding using the -verbose flag to output the plan and the -filter flag to run specific tests, or should the README only contain specific instructions to get you up and running with tests (basically "run terraform init then terraform test") and expect users to turn to official documentation if they wish to change the behavior of the terraform test command?

We could do the last option, and link to documentation in the bottom of the section?

Local repository paths don't work in the public registry 🙃 I'd remove this line:

Tests pass 🎉

Local repository paths don't work in the public registry 🙃 I'd remove this line:

Done ✅

The PR is ready although assert blocks is yet to be added 🤔

I don't see any difference between the basic and complete tests, so maybe it would make more sense to create simple_server and simple_database tests? Or something similar.

I don't see any difference between the basic and complete tests, so maybe it would make more sense to create simple_server and simple_database tests instead? Or something similar.

I agree, there is no difference between the tests as there is no difference between the basic and complete examples, and also the reason for there not being assert block added.
I like the idea of creating tests for server and database, as it makes more sense than tests for basic and complete examples.

This PR is still active, although currently on hold due to other tasks.

This PR is still active, although currently on hold due to other tasks.


[BEAM-5449] Add a PostCommit for Reference Runner Python VR tests.

Now that I have Python VR tests for the reference runner, I can make a PostCommit from it.
I was tempted to have it be a PreCommit like the Flink version, but decided it wasn't necessary since the reference runner sees much less usage than the Flink runner does.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 It seemed to work before, but maybe it's flaky and just happened to pass? Either way, I'm setting it to get skipped for now until SDF is properly implemented.

Run Python Reference Runner PortableValidatesRunner

Run Seed Job

Run Python Reference Runner PortableValidatesRunner

R: @swegner or @kennknowles (whoever gets to it first)
CC: @HuangLED


Fix add and remove subcommands for dependencies

Currently add only lets you add one dependency only instead of multiple, remove command deletes the install-deps rule when you remove any one dependency from the list of multiple dependencies instead of only remove that one exact dependency

fixed in #33


Create a contribution heatmap for the README

Eventually would like continuous analysis to update this plot.

Note that one issue I ran into was GitHub's rate limit for unauthenticated API queries -- 60 per hour per IP address. This could potentially cause problems on a CI server where other unathenticated builds had exhausted the API limits.

May be worth noting that this is for unauthenticated requests... it is possible to increase it to 5000 per hour if you authenticate.

I have reviewed the code & figure. :+1: LGTM! Exciting to see this quantified!

@cgreene, I made some additional changes in a new commit (391487f24ebb8464d4ab19ef79ae378f6364c704). Can you review again?

I have reviewed the table. I did not manually verify numbers, but code + table :+1: LGTM.


nickel.yaml patches and Libra2/Sage/Elipsa

@pgaskin
I think some of the comments in nickel.yaml are probably wrong for fw 4.30.18838. See MR post 26 and my reply in post 31.
I can't test but I suspect the Libra2 belongs in the [qApp_deviceIsStorm=true] sections, if/when they exist, rather than the "Dragon" sections.
Similarly, I'd expect the Elipsa to use the values in the "Daylight" sections. I see you've already put the Sage in the "Daylight" sections.
How would you like to proceed?

I might have made some mistakes when rushing to get those updated. I am planning on allowing these to be automatically generated in the future, but I don't know when I'll get around to that.
Regarding the Libra2, @shermp was originally looking into the codenames. His work seemed correct, but I'll check if there are edge cases as soon as I have time.
If you have any corrections you are certain about, feel free to make them, and I'll backport them as necessary.

If you have any corrections you are certain about, feel free to make them, and I'll backport them as necessary.

I can't be certain about them because I don't have Libra2/Sage/Elipsa. I may get a Libra2, but not just yet. I think you said the original LibraH2O is a "Dragon" device, but it's a "Storm" for nickel patch purposes. The Elipsa has the same screen pixels as a KA1 which we know is "Daylight" for nickel CSS patches.
For nickel CSS patches I think screen resolution is probably the main determining factor for which "group" it's in rather than the technicalities of chips and kernel (and other things I don't really understand 😄).
Patches for libnickel may be a different story.

Had another look at libnickel. It seems that between 4.28.18220 and 4.30.18838, Device::isStorm() sprouted a new  bool parameter.
So yeah, for CSS purposes, storm may be the correct class to use for Libra 2. Thanks for investigating this @jackiew1
I'm still rather new to this stuff.

There is now official confirmation on MR that, for at least one nickel patch, the Libra2 uses Storm values not Dragon. That's good enough for me to say that all nickel.yaml comments should point:

Libra2 to Storm if/when it exists, otherwise Dragon.
Sage to Daylight

I'll make the necessary changes to my own file for the latest firmware, i.e.
kobopatch-patches/src/versions/4.30.18838/nickel.yaml/jackie_w.yaml

@pgaskin I have some time today, would you like me to correct the GeoffR and oren64 nickel files too?

Yes, that would be greatly appreciated, since I'm extremely short on time right now.

@pgaskin I have some time today, would you like me to correct the GeoffR and oren64 nickel files too?

Done.
Your nickel.yaml file doesn't need correcting because you were smart enough not to include comments containing device names 😁

Thanks! I'll backport your changes to 4.28.18220+ before the next release.


URLs generated for emojis are missing the emojione cache busting param

This leads to using a different URL when emojioneArea renders an emoji compared to when emojione does.

@stof does it makes some issues?
I think it's not very good idea to use cache busting param in url at all.
Some speed tools marks it at not good practice and I don't use it.
I think the good practice is to use different paths for different versions of assets.
Furthermore cdn url of emoji already consits the version of emojione.
If you want to remove cache busting param for emojione you can do by set it:
emojione.cacheBustParam = '';

Well, the default CDN used by emojione is jsdeliver (when disabling the internal CDN config you have), and the version is not part of the path of images there, so the cache bust param is necessary.
It would be great if I could make emojioneArea use the same URL than my rendering, so that users opening the editor can benefit from their browser cache for some of the emojis at least.

Can you please provide the url of the emoji generated by emojione?

Here is the URL being generated: https://cdn.jsdelivr.net/emojione/assets/png/1f604.png?v=2.2.7

And what is difference with this one https://cdn.jsdelivr.net/emojione/assets/png/1f604.png?v=3.1.0 ?

@mervick is there any plan on this ?


ChemicalSubstance (PUBCHEM.COMPOUND:40466924) - (causes, causes_adverse_event) - Disease

This issue has been created to address https://github.com/NCATSTranslator/testing/issues/82. CAM-KP returns 0 results.

Followed up: https://github.com/NCATSTranslator/testing/issues/82#issuecomment-885667534.


[RESTEASY-1992] Prepare tests for extended support for multivalue @*Param

Add aditionall tests for extended support for multivalue @*Param

Rename (and improve) original MultiValuedParamTest to MultiValuedParamDateProxyTest

This test uses java.util.Date class as multivalue param
This test uses proxy (String parameter is defined in proxy, server uses collections in end-point), proxy is not related with this feature

MultiValuedParamDateNoProxyTest

Same as MultiValuedParamDateProxyTest, but proxy is not used at all in this test

MultiValuedParamCustomClassTest

This test uses custom deployment class

MultiValuedParamCdiTest

Server end-point is defined as a CDI bean

Jira: https://issues.jboss.org/browse/RESTEASY-1992
3.6.1 PR: https://github.com/resteasy/Resteasy/pull/1660
3.6 PR: https://github.com/resteasy/Resteasy/pull/1658

@marekkopecky , very nice.

@ronsigal PR updated, thank you for the review!


catkin build fails - header files not found

Upon building with catkin_tools (catkin build), px4 cannot find the header files, suggesting that the CMake config is somehow not communicating the include path of px4-firmware/src/lib/ecl/
Any ideas on how to change the cmake files?
I am on latest from master.
Note: The root dir is renamed from Firmware to px4-firmware.
Errors     << px4:make /home/me/dev/mavros-ws/logs/px4/build.make.001.log
In file included from /home/me/dev/mavros-ws/src/px4-firmware/src/modules/fw_pos_control_l1/FixedwingPositionControl.hpp:58:0,
                 from /home/me/dev/mavros-ws/src/px4-firmware/src/modules/fw_pos_control_l1/FixedwingPositionControl.cpp:34:
/home/me/dev/mavros-ws/src/px4-firmware/src/lib/ecl/l1/ecl_l1_pos_controller.h:65:21: fatal error: geo/geo.h: No such file or directory
compilation terminated.
make[2]: *** [src/modules/fw_pos_control_l1/CMakeFiles/modules__fw_pos_control_l1.dir/FixedwingPositionControl.cpp.o] Error 1
make[1]: *** [src/modules/fw_pos_control_l1/CMakeFiles/modules__fw_pos_control_l1.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
cd /home/me/dev/mavros-ws/build/px4; catkin build --get-env px4 | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -

I believe this has been resolved. Can you try again?

Hi. I am experiencing the same issue (build fails due to not finding ecl-related header files). This issue happens when using "catkin build" to build the px4 as a ROS package (if I just build it as a regular CMake project it builds fine, so I suspect the error comes from some catkin_tools magic):
/home/ana/ws/src/px4/src/lib/ecl/attitude_fw/ecl_controller.h:51:17: fatal error: ecl.h: No such file or directory

@nolanholden @ana-GT @TSC21 please open an issue in PX4 Firmware and describe exactly how you want to use this. We need to add a basic catkin build test to the continuous integration system (http://ci.px4.io:8080/blue/organizations/jenkins/pipelines) if we want to keep things like this from breaking all the time.

@ana-GT I found no solution but realized I did not need to build it using catkin_tool
Just use the Make targets from px4. (for me it was make posix_sitl_default gazebo). Instruction at my repo here for anyone in need.

Hi Nolan, well, this is by no means fixed, but my workaround was: Revert to the last stable release for px4 (which calls in turn a ecl's specific commit which builds fine).
I know that I could just use the plain make and do all that env stuff, but I prefer to only interact with catkin_tools and not to mess directly with environment variables if possible (in my book that is a bit messy, but that is a personal preference).
I managed to have px4 + sitl_gazebo installed fine as a ros packages (I had to tweak a tiny bit the sitl_gazebo CMake to allow it to find Ogre when being built with catkin_build, but other than that, the process was smooth).

@dagar I am also facing the same issue. I have cloned the latest px4 repo.

@mickey13 Thanks. I did the same. It was working. Do you have a rough idea why it's failing?

There's a problem with the include path. For some reason this is only working outside of catkin. https://github.com/PX4/ecl/blob/master/attitude_fw/CMakeLists.txt#L43
Keep an eye on https://github.com/PX4/Firmware/pull/9679 for a solution.


Initial version of the Ontology for Taxon Concepts and Names

Quoting from the description on the ontology:

The Ontology for Taxon Concepts And Names (TCAN) is an application ontology for expressing, matching, and resolving taxon concepts and their names as encountered in the wild, such as in publications, taxon mentions, clade definitions, etc. One of the key use cases for which it is being developed is for expressing and matching specifiers (in essence taxon concepts) used in clade definitions.
The TCAN ontology is a synthesis of a variety of relevant vocabularies and ontologies, including in particular the TDWG TaxonName, TaxonConcept, and DarwinCore vocabularies; the NOMEN ontology (SpeciesFileGroup); the OpenBiodiv Ontology (Pensoft); and the Comparative Data Analysis Ontology (CDAO).
One of the express design goals of TCAN is to avoid as much as possible creating new terms, whether classes or properties. Hence, there will be few if any terms here that are not already present in its source vocabularies. Instead, TCAN considers its added value in the following.

Provide an ontology for its application domain that stands on its own, meaning all necessary axioms are either directly included, or are imported from locations that resolve automatically and reliably.
Select subsets suitable for its application domain from each source vocabulary, and drop extraneous axioms and annotations.
Apply error corrections and replace non-standard annotation properties with standard ones. Ensure there are no parse nor reasoner errors.
Supplement subclass, type, class expression and other axioms to promote alignment and interoperability between the source ontologies.
Ensure expressity is at least within the OWL-DL, and ideally within the OWL-EL profile.

I came to the need for this ontology in the course of trying to rethink and revamp how we express phyloreferences. I had to realize that the space of already existing vocabularies and ontologies for taxon concepts and taxon names is kind of a mess, with IRIs that don't resolve by themselves, datatype errors, reasoner errors due to missing declarations, spelling errors, and most possible cross-links missing, to name just a few.
Comments welcome on this synthesis.
Closes #10.

@mjy just FYI, in case you are curious. I'm reusing a lot of NOMEN terms here, and putting some class expression axioms on them to promote interoperability.

@hlapp Thanks very much for the ping (and feedback on NOMEN).  Keep poking at me, I need to sit down and do some hard grokking as to how this all integrated.

I'm closing the comment period on this PR tonight. Further comments continue to be most welcome, simply post on issue tracker.


Remove "Q-encoding"

We only use it for csv importer, and it creates super ugly field names. It was a bad idea. It also results in double-escaping in many common workflows.
Instead:

Trim whitespace from ends of input column name
Split on whitespace
Force the resulting word to camelCase

See #1787, which this bug supersedes for background.

Split on whitespace or split on non valid characters?

Duplicate of #2411?

whoops


squiggly heredocs

https://github.com/caskroom/homebrew-cask/pull/39869

Passes style.

Passes style.


Frontend/Backend Implementation + Unit Tests for Coffee Roaster Scenario

This PR contains the full implementation including unit tests and storybook stories. Currently full functionality cannot be guaranteed as the blockchain environment is not working under minifabric on my environment. Unit Tests run successfully and stories render correctly tho.

Please add node_modules to gitignore and avoid to check-in installation artifacts.

node_modules was already in .gitignore, commited with cleared cache again, now it is removed

Looks better now. One final remark: Could you please add a README file with instructions to stand-up storybook, performing unit tests, and run the test system for the webapp (frontend & backend)? That would help Sven and me to integrate it in our CI/CD pipeline later.


Use ruff for linting

We currently use flake8 for linting, but ruff provides a nice way to consolidate linting rules used/defined by various other tools, such as black and flake8. We should also remove the "special" linting cases currently run only as part of CI (see .github/workflows/python-app.yml). Linting should be applied the same way, whether we're contributing code or running CI.

😆 love the new chore label


aztec-wallet not deploying the Counter contract

I am seeing the following error when running this command (aztec-wallet deploy ./target/counter-Counter.json --from accounts:my-wallet --args 1 accounts:my-wallet accounts:my-wallet) with the latest Counter contract. Using the same counter contract artifact in a TS script works.

We need to change initialize method name to constructor in contract code. I guess aztec-wallet code is not up to date

From @Thunkar:
There is a parameter to set the initializer (--initializer IIRC).

Josh - can you confirm that fixes the issue?
If so, can I rename the issue to be improve  (since the error is still misleading)

Just tested this:

Contract artifact name is incorrect, should be counter_contract-Counter.json. It is recommended to use the counter_contract@Counter syntax while in a nargo workspace.
Param is --init. Not using it provides the correct error (fn not found in artifact)

This command works:
aztec-wallet deploy ./target/counter_contract-Counter.json --from accounts:my-wallet --args 1 accounts:my-wallet accounts:my-wallet --init initialize
Alternatively:
aztec-wallet deploy counter_contract@Counter --frommy-wallet --args 1 accounts:my-wallet accounts:my-wallet --init initialize


Exporting the view as link when using a non-standard port

Commit:
Steps to reproduce

Start the server on a different port. For example 8001, i.e.,  http://<IP_ADDRESS>:8001 is the address the server is located at.
Generate a link for a view.
http://<IP_ADDRESS>/app/?config=LBH1piIDRMeVdMmF84KBZg

Observed behavior

The pot number is not added to the link. So, the generated link will direct to the standard http port. Hence the page won't be displayed.

Expected behavior

Seeing the port number in the generated link
For example:
http://<IP_ADDRESS>:8001/app/?config=LBH1piIDRMeVdMmF84KBZg

Fixed in v0.2.32.


Orb parsing directories that should be ignored

Orb version: 3.1.1
What happened:
Hi, I configured the orb to ignore the following folders:
      - shellcheck/check:
          ignore-dirs: |
            .git/
            node_modules/
            dist/

However, the logs show that the directories were considered:
./node_modules/foreground-child/changelog.sh
./node_modules/tape/example/static/build.sh
No ShellCheck Errors Found

Even if I specify with the current directory prefix (e.g. ./node_modules).
Expected behavior:
I would expect that the orb would ignore those directories. Or do the logs only mean that the orb found those shell script files but did nothing with them?

It seems that if the directory is defined as: node_modules/ or ./node_modules/ (with the end slash). The orb will not ignore it.
If I change it to:
     - shellcheck/check:
          ignore-dirs: |
            ./.git
            ./node_modules
            ./dist

It works as expected.


Re-add Persistent Soul

Persistent Soul was an ability I made for Plague Revenant, which is now removed. Add it back to another unit.
Current best idea seems to be a new Revenant unit as an alternative for Abominations.

Closed by #811.


SDK delete protected domain

rAPId api delete protected domain request removes domain but returns error status code and inadequate response message.
url = f"https://rapid.c-af.org/api/protected_domains/{domain}"

response = requests.delete(
    url,
    headers=headers
)
data = json.loads(response.content.decode("utf-8"))

For above code requests response code is 400 and response message is {'details': 'Subject 6hqkf3fqro7v7d8qtlg4nej98v not found in database'}
I tested it twice for existing domain. The message returned was identical. Despite the message domains were deleted.

I found where problem is.
Here  is created aws_cognito_user_pool_client "user_login", but no permissions in dynamodb are created for him in this file
I can make pull request fixing this issue, but I don't know what permissions this user was intended to have, or can it be deleted?


If you installed before 15-Nov-2024 may need to uninstall / reinstall

Still learning with modules and Github, the links I had in module.json were not pointing to the latest release. Sorry about that.

I'm getting a message to update the link every time I update modules, and clicking yes does not stop it from appearing again.


RouteExists should account url_prefixing

This currently returns an error. It's possible to work around it but it seems like it should work as long as the url prefix doesn't produce a conflict:
app = Sanic()
bp = Blueprint("test", url_prefix="/test")
app.blueprint(bp, url_prefix="/test")

@bp.route("/")
def index(request):
    return text("Hello World")

@app.route("/")
def health_check(request):
    return text("OK")

The issue is likely that you can't register the blueprint before defining the routes:
from sanic.app import Sanic
from sanic.response import text
from sanic.blueprints import Blueprint

app = Sanic()
bp = Blueprint("test", url_prefix="/test")

@bp.route("/")
def index(request):
    return text("Hello World")

@app.route("/")
def health_check(request):
    return text("OK")

if __name__  == "__main__":
    app.blueprint(bp)
    app.run()

This works fine, at least on the master branch:
$ curl localhost:8000/test/
Hello World
$ curl localhost:8000/
OK

Going to close this issue but feel free to reopen if you still have problems.


Spelling: Correct title H of reinherit is small

DESC

h should be capitalized

TODOs

[x] fix

implemented


TensorFlow for Jetson TK1 (ARM + Cuda)

I have a gpu-enabled build for Jetson TK1 using CUDA 6.5 runtime and CUDNN 6.5.
This is a link to download the binary for the pip install if someone wants to try it:
https://drive.google.com/file/d/0B1uGKNpQ7xNqeTB4RFE2MXdNWUU/view?usp=sharing
Jetson  TK1 has a limited amount of memory ( CPU+GPU <2GB) so most of the examples will not run without modifications but aside from  Out Of Memory errors, TensorFlow runs just fine.

Thank you for your contribution!  In general we encourage users with nonstandard setup to build their own pip packages from source.  And we are specifically encouraging the CUDA 7 runtime with CUDNN 6.5 because it's one less variable to consider when debugging (and this is the version we use and test with).  Since it doesn't seem like there's any issue, I'm closing / archiving this for now.


No result while looking document for PublishTestResults

I'm looking document for PublishTestResults library but not found any result, please help to check
https://docs.microsoft.com/en-us/azure/devops/integrate/concepts/dotnet-client-libraries?view=azure-devops

@tindecken Clicking on it loads https://www.nuget.org/packages/Microsoft.TeamFoundation.PublishTestResults


What for possibilities does a user have to cancel the stepper?

Maybe I'm thinking wrong....
I see a stepper as an action for users to finish a process with different sequential steps.
eg the process has 5 steps.
A user starts...and finished 2 steps. Now the user is in step 3 - but doesn't want to finish. He wants to cancel the process.
Now my question: Which possibilities do I have as developer to give this feature "cancel the process" to my users?

I'll use the toolbar left button "x". This will cancel the process.


Cumulative Layout Shift, Suspense and loading state

Hi!
I am trying to reduce Cumulative Layout Shift (CLS) in a Nextjs v13 app router app. I see that https://dc.library.northwestern.edu/ have some quick CLS when navigating to a item page and mounting Clover.
Do you have any thoughts on how to mitigate this? Adding a loading state in the next/dynamic config does not really fix this. The clover-iiif loading state takes over after the Next loading state is remove, and it has with no height  set.
const CloverIIIF = dynamic(() => import('@samvera/clover-iiif'), {
  ssr: false,
  loading: () =>
Blæ...

})

I might have missed something, but do you have some advice on this topic?

@tarjelavik Apologies for seeing this just today.
I think this is the way handled this:
https://github.com/nulib/dc-nextjs/blob/deploy/staging/pages/_app.tsx#L97
Note that we wait to render the page once mounted is set to true in our _app.tsx file. This could make it easier for the user's experience though I don't believe it actually renders any further.

No worries :-).
Back from holiday, so need to get into devmode again. I guess i have to figure out how to do some Suspense stuff in the app directory.


Fluidity: Vorto and Media picker

Hi, great plugin (as well as Vorto). Two things bothers me:

I’m trying to implement Vorto inside Fluidity. While the UI is rendered - there is ‘activeLanguage’ missing. I tried with Thread.CurrentThread.CurrentCulture = new System.Globalization.CultureInfo("en"); without success. Is Vorto possible inside Fluidity and how?
Implementing Media picker throw this error:
Message: "The request contains an entity body but no Content-Type header. The inferred media type 'application/octet-stream' is not supported for this resource." Am I missing property converter...

However, I played a bit because it didn't give me peace of mind, and I came to the conclusion that because the vorto is not inside the 'right content tree', this api doesn't get the right data: public IEnumerable GetLanguages(string section, int id, int parentId, Guid dtdGuid). In fact, the problem is in dtdGuid type that requires a Guid, but an 'undefined' string comes inside. Changing Guid to string type (and then try-convert to Guid) solves the problem (I hope no one else shows up :)). The second question still bothers me...


TF400813: Resource not available for anonymous access when creating a build agent.

I'm running .\config.cmd to create a build agent on my build server, but I'm getting TFS400813 error.  See attached screenshot of the PowerShell command and full error message.
I'm on Windows Server 2016. I'm logged into the server as the user whos PAT I'm using to create the build agent.
This is a new server, but on our previous build server I was able to do this with this same PAT and user with no issues. Is there some security setting on the server that allows this to move forward?

@gdodd1977 does your PAT expired? the default is valid for 90 days. try create a new one.

I'm using VSTS.

SSI_TFS_Build

Sorry. Try https://app.vsaex.visualstudio.com

@gdodd1977 not the app.vsaex service url, the real account url, the url that has your git repository.

@gdodd1977 can you share your agent config log? it's under _diag folder under agent root.

Agent_Log.txt

@gdodd1977 are you able to use that PAT to fetch git repository?
i am not able to find any detail trace indicate what's wrong with your PAT, the service just decide return 401 when you make request.

I don't have git on my build server.
Since it's giving 401, it seems to be indicating that it can't authenticate the user from the build server. Is there some command in Powershell to run to get that? Or is it something that needs to be changed directly on the server?

@gdodd1977 make sure the PAT you generate is for the right account.

I figured out the issue. The place that was storing my PATs was capitalizing letters, thus messing up the PAT.
Thanks for your time.

@gdodd1977 how did you get into this situation? the web UI should shows the PAT in lowercase.

Because the app that I store the PAT in for reference was capitalizing them when I pasted them in for some reason.


default menu and modal window

menu bugged, i dont need that edit icon or wtf is it (i think its in index.php)
modal window (admin panel) dont work
opened empty window and i cant scroll website

Closing issue as this is an theme issue and not a WonderCMS core issue.
Please visit our community for any help for creating your own theme.
A few head ups:

Your theme seems to be either missing jQuery or Boostrap, which are currently still required for everything to be functional.
If you want to edit the wcms.admin.css, you will have to fork WonderCMS and modify then include files yourself into your own version of WonderCMS.

If you need help, drop by a message in the community: https://www.wondercms.com/community

If you do so, you will also have to specify which libraries (CSS or JS) your theme is using. Along with browser and OS problem.

Please note WonderCMS is free and open source and does not have employees.

People trying to help you are working in their free time, so it might take a longer time for someone to help you out.

Closing issue as this is an theme issue and not a WonderCMS core issue.
Please visit our community for any help for creating your own theme.
A few head ups:

Your theme seems to be either missing jQuery or Boostrap, which are currently still required for everything to be functional.
If you want to edit the wcms.admin.css, you will have to fork WonderCMS and modify then include files yourself into your own version of WonderCMS.

If you need help, drop by a message in the community: https://www.wondercms.com/community

If you do so, you will also have to specify which libraries (CSS or JS) your theme is using. Along with browser and OS problem.

Please note WonderCMS is free and open source and does not have employees.

People trying to help you are working in their free time, so it might take a longer time for someone to help you out.


But fonts used in these logos are not simple.
Optima is the simplest in these fonts, but i think kobin's image is simpler than the font's image.
So i think you may use simpler font. ex, san francisco , helvetica ...
2nd : corks
Why do you cork a (this logo's) 小瓶(kobin)?
Kobin is not closed, isn't it??
It receive a http requests and respond when developers use kobin's Request and Response object.
And you want a nice pull request on github, are't you??
I think kobin is open. so logo's 小瓶 may be uncorked.
3rd : color
what is kobin's theme color??
i think blue is nice. because i think 小瓶s are floating in the sea.
but this reason is too cheap...

I want to wrote more and more things but i'm sleepy now.
So i suggest more ideas tomorrow... :zzz:

@denari  Thanks for your logical suggestions. Especially I favorited the san francisco and the reason to choice.
I'm looking forward to your further suggestions.

"tomorrow" had come... :bow:
Now I present 3 gifts for you .

Please tell me if you want to use these logos.

@denari May I have your third gift as adobe illustrator style?

here is 3rd gift
https://www.dropbox.com/s/w7q3oxp1pip3cwo/kobin.ai?dl=0

@denari thx!!!!

Good job.


Running ASTRA on Windows or on Colab

Hi,
First of all, thanks for developing this very useful tool!
I have been trying to deploy the algorithm to some 2P recordings from hippocampal astrocytes (I was hoping that your pretrained model would work well for this purpose). However, for this purpose, I have currently a Windows machine available. Unfortunately, I was unable to install ASTRA - I could not install the correct python version (using conda), the correct packages (torch 1.2.0 was not supported by any python version that I was able to install), and has also not sure whether my CUDA driver version would be compatible ...
Therefore, I was asking myself whether it would be possible to run ASTRA on the cloud, e.g., on Colab. Based on my understanding of ASTRA, the input is only a single 2D image, so I don't think that the algorithm will use too many resources (and probably even does not require any sort of GPU). So it should be not too difficult to adapt your code such that it works in Colab. Have you tried so, or can you give some guidance on how you would do this (or whether you foresee any difficulties)?
Looking forward to hearing from you,
Best wishes,
Peter

Hi Peter,
In the "installation" folder, there is a Dockerfile that sets up the entire environment with Python 3.10 and CUDA 12.2. Using Docker, you can leverage your OS and GPUs.
ASTRA processes 2-photon Ca2+ imaging recordings, analyzing and manipulating these videos to create a 2D spatiotemporal map, which is then fed into the DNN.
Regards
Jacopo

Hi Jacopo,
Thanks for the quick reply! Also thanks for the clarification about how ASTRA works; I had been under the false impression that ASTRA only does segmentation of a 2D input - I might have mixed things up with CITE-ON and simply assumed that ASTRA does the same but for astrocytes. I have now read the preprint more carefully.
I would have prefered to make it work without Docker since I had previously mixed experience with Nvidia+Docker, but I will give it a try. I'll let you know if I'd encounter any major problems.
Best,
Peter

Hi @jbonato1,
I have a follow-up question on the installation of ASTRA with Docker.
I have now used the commands to generate docker images (docker pull nvidia/cuda:12.2.2-devel-ubuntu22.04 and docker build -t astro_segm:1.0 .) The images seems to have been generated properly:

But when I try to run the images in Docker-Desktop, I get the following error (see error message on the right hand side), indicating that the installed CUDA version is wrong. It therefore seems to me that the docker container does not really use the docker-nvidia 12.2 version (the system's CUDA version is 11.8, but I pulled the 12.2 version for the nvidia-docker as in your installation instructions):

Also when I run the code in the console (docker run -it -p 8888:8888 --gpus all -v /mnt/c/Users/Titan/Desktop/Sian-Peter-Packages/ASTRA-master astro_segm:1.0 bash), I get the very similar error:
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.2, please update your driver to a newer version, or use an earlier cuda container: unknown.
Do you have an idea what is going wrong here? How can I force the ASTRA container to use the nvidia-cuda image?
Your help would be appreciated!
Best,
Peter

Ok have you tested direcly the nvidia image nvidia/cuda:12.2.2-devel-ubuntu22.04? Does it work properly ?
i.e. RUN
docker run -it --gpus all nvidia/cuda:12.3.1-devel-ubuntu22.04 bash
and inside the running image
nvidia-smi -l
Can you tell me which nvidia-driver do you have? and which GPU?

Thanks for the quick reply. Testing the nvidia image results in the same error:
docker run -it --gpus all nvidia/cuda:12.2.2-devel-ubuntu22.04 bash
results in
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.2, please update your driver to a newer version, or use an earlier cuda container: unknown.
So I cannot really run nvidia-smi -l inside of the image, since I cannot run the nvidia image at all. When I run the command outside of the image, I see that the following drivers are installed: "NVIDIA-SMI 520.61.03    Driver Version: 522.06       CUDA Version: 11.8". The GPU in this computer is an NVIDIA GeForce RTX 3070.
I looks as if somehow the nvidia drivers seen are too old. Unfortunately, I don't fully understand whether nvidia drivers are installed fully inside or outside of the docker environment. If you have any further suggestions, it would be helpful.
P.S. Was there a specific reason why you indicated "12.2.2" in one place and "12.3.1" in another place in your last reply?
Best,
Peter

Sorry for this late reply. The problem is your driver version. 522 nvidia driver are not compatible with cuda 12. So there 2 options: you can use the cuda 12 image from dockerhub but you need to update the drivers (you can still use cuda 11 using docker or make multiple cuda installation in your os), or you can use your environment and install the packages required (most of them are standard in AI like numpy pandas torch opencv). Unfortunately I dont have time to customize everything for your OS and driver vesrion

Hi @jbonato1, thanks for your reply. I also figured out that the driver incompatibility is a problem. Unfortunately, having multiple cuda version installed at the same time does not work. At the same time, I would like to keep the system compatible with already installed software (e.g., DeepLabCut). As you mentioned, this cannot be figured out remotely; I will try my best to find a solution and will report here (as a reference for others) once I've managed to make it work.

Now it seems to work. I've updated the CUDA to 12.5 and the drivers such that they are compatible, both on Windows. With WSL-2, all attempts to install drivers in Ubuntu were not successful. I also don't think that it is possible in all cases to have multiple versions of CUDA working on the same computer in parallel.
After installing CUDA, I created a conda environment, installed the "requirements_updated.txt" with pip on the WSL-2 Ubuntu, and it seems to work now so far. I'm running into some other questions now, but these are unrelated to this current installation issue, and I will open another issue about that.


Cannot load model

Traceback (most recent call last):
File "/root/miniconda3/lib/python3.10/site-packages/IPython/core/interactiveshell.py", line 3553, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
runfile('/root/autodl-tmp/project/ACC-UNet-main/Experiments/test_model.py', wdir='/root/autodl-tmp/project/ACC-UNet-main/Experiments')
File "/root/.pycharm_helpers/pydev/_pydev_bundle/pydev_umd.py", line 198, in runfile
pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
File "/root/.pycharm_helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/root/autodl-tmp/project/ACC-UNet-main/Experiments/test_model.py", line 270, in
model.load_state_dict(checkpoint['state_dict'])
File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2152, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Mamba2Unet:
Missing key(s) in state_dict: "mamba_unet.norm.weight", "mamba_unet.norm.bias", "mamba_unet.norm_up.weight", "mamba_unet.norm_up.bias".
Unexpected key(s) in state_dict: "mamba_unet.classifier.norm.weight", "mamba_unet.classifier.norm.bias", "mamba_unet.classifier.norm_up.weight", "mamba_unet.classifier.norm_up.bias".
Process finished with exit code -1
When I trained your model and then tested it by loading the model, an error occurred during loading. What could be the cause of this error, and how can it be resolved?

Though I am not familiar with that project, I guess that you can just change the keys in state_dict from "mamba_unet.classifier." to "mamba_unet." to solve the problem.
That is:
state_dict = {("mamba_unet." + k[len("mamba_unet.classifier."):] if k.startswith("mamba_unet.classifier.") else k): v for k, v in state_dict.items() }


[Request] Feature - UI - Allow option to toggle light/dark mode

Request: allow option to toggle light/dark mode
Apologies if this is already available and I missed it. Please let me know where to find it if that's the case.
Also, I can maybe take a stab at adding this myself if someone tells me the relevant files to look at (not too familiar with the codebase).

nope not available! you’ll probably want to look at the interface.js and index.js files. theres some css to make each provider dark mode as well inside the providers folder. this isnt a high priority feature for me but if you can figure it out without much guidance youre welcome to work on it

Sounds good. I'm working on it now, thanks for the tips. I'll try and get a PR ready for submission this week sometime.
So far I've made changes to index.js and interfaces.js. Next I need to figure out the changes to make to each of the providers files. I'm also thinking about adding a toggle for the dark mode setting.
It looks like the providers handle the custom CSS for each of the providers, while index.css handles the CSS for the app menubar app itself? So it looks like I won't need to make changes to index.css, but please correct me if I'm wrong.
Progress report:

Opened WIP PR and linked to this issue for visibility. I could use some help figuring out where to find the provider-specific dark mode changes that get made when users enable dark mode for each. I assume that info is available within browser DevTools somewhere, but I'm not sure where to find it.
I'll work more on this PR later this week when I have some free time.

It looks like the providers handle the custom CSS for each of the providers, while index.css handles the CSS for the app menubar app itself? So it looks like I won't need to make changes to index.css, but please correct me if I'm wrong.

correct

this was added in #107
but still not very stable yet i think. needs a bit more testing


Zoom problem

Hi, what are the keys used to zoom in and out in the UI?
kind regards.

vliv is not a standard viewer, zooming in and out are available only for specific image formats, for example TIFFs that are specially processed with pyramidal levels. (and Jpeg) with arbitrary unzoom levels. In Vliv context these are called pages.
You will find the shortcuts in the image menu.
If the image format does not comply with this notion of pages, you will not be able to zoom in or out.
If you want to be able to zoom in/out freely in any image, it is better to use another viewer.
For jpeg images, Vliv uses the ability to load different levels in the libJPEG API.
Remember that the first usage of Vliv is to display gigapixel TIFFs


Test PR, ignore me!

For the bot.

@XiphGitlabBot retry

@XiphGitlabBot retry

@labhub retry

Coverage remained the same at 80.613% when pulling 224f3f4cf0ae0dc9f3ac03c6439a4b0c3cc2b0d3 on ePirat:ePirat-patch-1 into 16ea18ea6eaf3f0e8549a6804ebb45ea37f659fb on xiph:master.

Can this be closed?


fixes compat issue with powershellv2 task, bumps version

Now empty string matches the "inline" type, and applies the same fix to the Windows task version.
Bumps minor version number.
Fixes missing comma in resources.resjson.
Follow-up on PR #9557

@moswald do we still need this? Could you provide some context on why we need it - it breaks compat, right? The PR you link to in your description is this one...

I have no idea what this was doing. Feb 12th? ¯\_(ツ)_/¯ Let's kill it and move on.


IInstantiationStatement.cs:9: 60m/LEAD...

The puzzle 125-d8a4f619 from #125 has to be resolved:
https://github.com/DenisZhukovski/ObjectToTest/blob/d8e39635099e88c532733593a67e2a36ff4d896d/src/CodeFormatting/Syntax/Contracts/IInstantiationStatement.cs#L9-L9
The puzzle was created by Stanislau on 16-Dec-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 125-d8a4f619 has disappeared from the source code, that's why I closed this issue.


refactor to new style and rename all conditions inside match.py so match can be fully used instead be + have

subj

This issue was renamed, because it's tightly coupled with complete refactoring of conditions...
This refactoring was actually started from commits from Commits on May 29, 2024 til Commits on Jun 22, 2024. And from now on, I will try to mark further commits as related to this ticket


Fix markdown typo

Actually, it looks like this attr is not supported.

I think this is the same as PR #118


refactor(dbm-services): update go work sum

关联研发信息
dev_branch: refactor/update_gowork_sum/#1159
target_branch: v1.2.0


(GH-578) Support building when not using git

i.e. when the repository hasn't been cloned, but rather downloaded as a
zip file.
When in this situation, default to some sensible values.
Fixes #578

@AdmiringWorm I believe I have addressed all the feedback that you left here, and this is ready for another review.

@gep13 your changes have been merged, thanks for your contribution 👍


Add support for using the kernel keyring

Allow rkt to use the kernel keyring to store keys, rather than depending on
on-disk storage. System keys should be pre-provisioned in keyrings owned
by root, rkt will add additional keys to its own keyrings.

It seems it needs libkeyutils1 libkeyutils-dev?
To make Semaphore happy, this needs to be updated:
https://github.com/coreos/rkt/blob/master/tests/install-deps.sh#L14

@mjg59 what's the latest on this one?

@mjg59 ping

@mjg59 Ping? we would like to merge this into v0.9.0

It turns out that the kernel keyring has some strange semantics that can cause conflicts when running via sudo. I'm working on attempting to resolve this, and closing this PR for the moment until I can get it working correctly.

@mjg59 any progress on this one?


Pickatime, set max to a value after midnight

In my app I have a requirement to be able to have a timepicker say from 11pm, through 3am.
In previous versions of the library this used to work. After updating to the newest version, it no longer does.

I've created a minimal reproduction, can be seen below. The API worked at the last version I had before updating, which was v3.3.1.
The regression is in v3.5.5.
http://pickatime-v3_3_1.meteor.com
http://pickatime-v3_5_5.meteor.com
Here's the source for the bug reproduction:
https://github.com/patrickleet/pickatime-bug                          - v3.3.1
https://github.com/patrickleet/pickatime-bug/tree/v3.5.5        - v3.5.5

just tested with 3.5.6 and the issue still exists


[Feature] New module geospatial-client for cross-plugin IP enrichment

Description
This is an implementation ticket which follow the discussion of https://github.com/opensearch-project/geospatial/issues/698, to create a new Gradle module for other OpenSearch Plugin to import, in order to make an IP enrichment call to GeoSpatial plugin to resolve GeoLocation data with existing data source.
Hight-level code changes:

A new Gradle module geospatial-client with appreciate Gradle setting files to publish it as a standalone Jar.
A core class ipEnrichmentActionClient which serve as the interface, this is the only way for other Plugin to interact with GeoSpatial's IP enrichment functionality
A collection of classes to support the IP enrichment remote call access IpEnrichmentAction, IpEnrichmentRequest and IpEnrichmentResponse
IpEnrichementTransportAction class which contain the logic for the IP address lookup and register it during the GeoSpatial's bootstrap time

Non GeoSpatial plugin can now interact with the new functionality like below:
IpEnrichmentActionClient ipClient = new IpEnrichmentActionClient(client.getNodeClient());
        try {
          Map<String, Object> geoLocationData = ipClient.getGeoLocationData("<IP_ADDRESS>");
        } catch (Exception e) {
            throw new RuntimeException(e);
        }

Related Issues
Resolves https://github.com/opensearch-project/geospatial/issues/698
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 here is the implementation for https://github.com/opensearch-project/geospatial/issues/698 as we discussed earlier of the week, would you mind to have a look and advise?
Any comment will be appreciated.

@navneet1v I have fixed most of the point except the Mockito, can you have a look a review?
Thanks,

@heemin32 I updated the code to reflect comments, can you have another look.
Also whats your thought on the cluster upgrade scenario?

@heemin32 I updated the code to reflect comments, can you have another look. Also whats your thought on the cluster upgrade scenario?

I think, we can use add versioning on this serialization/deserialization using OpenSearch version.

@Xtansia Could you take a look at this?

I think, we can add versioning on this serialization/deserialization using OpenSearch vers

Just to align on this, what's the expected behaviour in the case when  serializationID doesn't match?
Should we thrown an exception, we attempt to parse it as per the serializationID? (Ex: v1.19.0 version of the plugin serializating the object from v1.18.0...etc)

@heemin32 I updated the code to reflect comments, can you have another look. Also whats your thought on the cluster upgrade scenario?

I think, we can add versioning on this serialization/deserialization using OpenSearch version?

I have updated the code to perform version, can you have a look and advise?
Thx!

Another general comment is if we should implement it as a rest API rather than client? What do you think? @andy-k-improving

Another general comment is if we should implement it as a rest API rather than client? What do you think? @andy-k-improving

We should have it in the long term || as day-2, but I don't think that make sense to bundle it in one PR, as there will be more considerations I foresee (Ex: performance, web-layer security) need to be addressed || discussed ahead of the implementation.
Let me create another issue perhaps?

@heemin32 Also do you foresee any problem to publish the geospatial-client jar?
In local, I see the jar is produced correctly, but not sure will that be the same when publishing to AWS || Maven central.

Let me create another issue perhaps?

No need for that. I was considering either this or that, but not both. Thanks.

@heemin32 Also do you foresee any problem to publish the geospatial-client jar? In local, I see the jar is produced correctly, but not sure will that be the same when publishing to AWS || Maven central.

I don’t have much expertise on that topic. @ylwu-amzn, is there anything specific we should consider when publishing the client? Asking as ml-common already has done it.

No need for that. I was considering either this or that, but not both. Thanks.

If that is the case, then I rather keep this instead of REST.

Rebased again for the JDK 21 changes on main, waiting for CI.

@navneet1v Hi, I have updated the code and tested the build command locally, it should work by now.
Would you mind to have another look and advise?
Thanks,

Updated the code style should be ok for review again.

Hi @navneet1v, would you mind to have another look?
Thanks,

Could you rebase and see if the failing CI will succeed?

@heemin32 done.

@andy-k-improving, thanks for the change. If you don't get response from @navneet1v by next Monday, let me pull in another person to review this PR.


Query balance with a signed permit instead of a viewing key

Usage example:
 const permit = await window.keplr.signAmino(chainId, myAddress, {
    chain_id: chainId,
    account_number: "0", // ignored
    sequence: "0", // ignored
    fee: {
      amount: [{ denom: "uscrt", amount: "0" }], // ignored
      gas: "1", // ignored, must be bigger than 0 for Keplr to accept this
    },
    msgs: [
      {
        type: "query_balance_permit",
        value: {
          permit_user_id: "secretswap.io", // can be revoked by the user
          query_balance_of: myAddress,
          message: "This signature is a permit to query my balance.", // this text is taken from token_info
        },
      },
    ],
    memo: "", // ignored
  });

  const { balance } = await secretjs.queryContractSmart(mySnip20Token, { balance_with_permit: permit });
  console.log(balance.amount);

How it looks on Keplr:

https://github.com/enigmampc/QueryBalancePermitDemo

Does this mean that you will need to sign a tx every time you query a balance? Will this live along side viewing keys as a sort of "one time passcode" for queries that access private state?

@the-dusky

Does this mean that you will need to sign a tx every time you query a balance?

No, you sign it offline (you don't broadcast a tx) and the signature (=permit) is sent with the balance query (like a viewing key) and is reusable for multiple queries. To revoke a permit the user needs to send a "revoke permit" tx.

Will this live along side viewing keys as a sort of "one time passcode" for queries that access private state?

This is an addition, so viewing keys remain untouched. It's reusable, so not exactly a "one time passcode".


Shiva sfml port

Thanks!

@ras0219-msft Also Robert i want to know your opinion on this pull request, this is a good way to import modules automatically you think ? i mean the shiva-sfml portfile.cmake

I think this line is highly suspicious: https://github.com/Microsoft/vcpkg/pull/4011/files#diff-84a3d373c40c330f16e3d9de770d2b8bR21. Did you really mean to search inside the source code?
Otherwise, I don't exactly see what you mean by import modules automatically :(

@ras0219-msft It's because on Linux/OSX plugins are ".so" ".dylib", i manually import it into the lib directory since VCPKG didn't do that for me. After the build of shiva-sfml i got in "bin/systems" directory, 3 dynamic library which doesn't have to be linked since they are DLL, but imported into a binary directory for latter loading

Thanks for the link :)
The import_plugin macro seems serviceable, however for more complicated projects with nested add_subdirectory()s or even nested project()s I think this will break down. The lowest-cost fix for that (afaict) would be to provide the user a macro like shiva_deploy_plugins(<directory>) that they can call in their cmake file which will deploy the plugins to the target directory.

@ras0219-msft Oh i see, thank's for the advice, also there is a VCPKG_VARIABLE to access $VCPKG_ROOT/installed/triplet/lib directory ?

From inside of your shiva-config.cmake file, no. I recommend using a relative path lookup:
file(GLOB RELEASE_PLUGINS ${CMAKE_CURRENT_LIST_DIR}/../../lib/*) #release
file(GLOB DEBUG_PLUGINS ${CMAKE_CURRENT_LIST_DIR}/../../debug/lib/*) #debug

Unfortunately, I still don't quite understand the reason for looking in the ${SOURCE_PATH} for binaries -- as far as I can tell from your repo and cmake files, you should not have any files in that directory.
Are you sure you did not mean something like file(GLOB PLUGINS "${CURRENT_PACKAGES_DIR}/bin/systems/*")?

@ras0219-msft It's appear that when i build shiva-sfml, plugins are generated in ${SOURCE_PATH}/bin/systems -> probably because of https://github.com/Milerius/shiva/blob/master/cmake/module.cmake#L48 , let me know ;)


Fixed buckled players thrashing while speaking in beds

About the PR

Characters no longer briefly appear to stand up when they speak while strapped to a bed.
Why / Balance

Fixes #29427.
Technical details

The movement was happening because RotationVisualizerSystem subscribes to AppearanceChangeEvent on the buckled player, and makes the curious choice of assuming that the player is standing if AppearanceComponent doesn't contain a value for RotationState. Meanwhile, BuckleSystem uses a client-only method of RotationVisualizerSystem to rotate the player while buckled. RotationVisualizerSystem would be happy to bulldoze that rotation when it got a AppearanceChangeEvent.
The problem happens when something else causes an AppearanceChangeEvent on the buckled player. And typing indicators recently became predicted (#29551) using AppearanceComponent to track the indicator state. So when the player types, it sends raises an AppearanceChangeEvent, and the AppearanceComponent doesn't have a value for RotationState, so it gets set to the default Vertical again before getting animated back to Horizontal by BuckleSystem. What fun!
This PR fixes the issue by removing the logic from RotationVisualizerSystem that causes unrelated appearance updates to default to vertical, because that's just asking for more trouble in the future. It then changes BuckleSystem to make deliberate calls to AppearanceSystem to set horizontal/vertical rotation when buckled/unbuckled.
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Fixed characters thrashing when speaking in beds.

I love your detailed writeups they are always interesting to read!


Failed to build librealsense - Invalid command line switch for "cmd.exe" (PATH)

I'm trying to get the nodejs wrapper up and running, and after dealing with a series of problems, I now have one that I'm not sure how to fix.
When running npm i node-librealsense I get the following error which fails the build (newlines added for readability):
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(240,5):
error MSB6001: Invalid command line switch for "cmd.exe". System.ArgumentException: Item has already been added. Key in dictionary: 'Path'  Key being added: 'PATH'
[C:\Users\MyUserName\PathToProject\node_modules\node-librealsense\librealsense\build\ZERO_CHECK.vcxproj]

Things I've done:

Uninstalled and reinstalled Visual Studio Community 2019 with .NET and C++ workflows, and added the MsBuild directory to PATH
Uninstalled and reinstalled the newest version of cmake (3.20.1) and ensured that it's in PATH
Installed the newest version of the realsense SDK (<IP_ADDRESS>56)

I'm running Windows 10, version 20H2 build 19042.928
I don't normally do C++ development so I'm pretty far out of my depth here. I'd never even heard of cmake or MsBuild before today so I don't really know where to start looking to fix this problem. Especially because I get the vibe that the npm package is doing a lot of things under the hood that I don't have much control over.
I've attached the console output when running npm i node-librealsense, as well as the log file that was generated.
Thanks in advance for any help!
error-log.txt
console-output.txt

Hi @lachlansleight   Could you try the npm installation method in the link below please?
https://github.com/IntelRealSense/librealsense/issues/7439#issuecomment-708503008

Hi Marty,
I tried that, but I don't think I really understand exactly what you're asking. I try running that command in my nodejs project, and nothing happens (since there's nothing in my package.json at that point). I tried a few permutations:
Attempt 1:

Built the C++ SDK with Release configuration type
Ran the command you mentioned in wrappers/nodejs folder, and was told that the script couldn't find the dll in "build/Release" folder
Renamed the build folder that was generated by visual studio to the path that the vs configurations seems to want (build/Release), then ran the command again, which seemed to do something
Added that package using npm's file dependency system "dependencies": { "node-librealsense": "file:C:/blahblahblah/wrappers/nodejs" }
Ran npm i inside my project folder (not the SDK folder) - which seemed to import some stuff into node_modules, but fails with the following error (I get the same error when running npm i --vs-configuration=Release)

'librealsense2/rs.h': No such file or directory [C:\PathToMyProject\node_modules\node-librealsense\build\node_libr
ealsense.vcxproj]```

Attempt 2

  * Added "node-librealsense" to package.json manually (using the version that the nodejs wrapper has in *its* package.json) then running `npm i --vs-configuration=Release` (this just produces the same error as I originally got when running `npm i node-librealsense`

I don't really understand how the comment you linked is meant to help (I mean that genuinely, not in a snarky way!) - how would running a install command in the wrappers/nodejs folder do anything to import the package into my project folder? Am I just misunderstanding something fundamental about how to install node-librealsense?

The Nodejs installation instructions are admittedly complex.  It is probably best to follow the sequence of instructions in the prerequisites link below, and then enter the npm install --save node-librealsense command only once the list of prerequisite installation steps has been completed.
https://www.npmjs.com/package/node-librealsense#1-install-prerequisites
Comparing those instructions to your steps, it seems as though you may be missing This step:
1.  Install Python 2.7.xx, make sure "Add python.exe to Path" is checked during the installation.

Hi @lachlansleight  Do you require further assistance with this case, please?  Thanks!

Hi! Yes I suspect I will,I just have an intermediate deadline coming up for this project that I don't need the real sense camera working for so this task is on hold until next week :)

Thanks very much @lachlansleight for the update.  I will keep this case open for a further time period.  Good luck!

Hi @lachlansleight  Do you have an update about this case that you can provide, please?  Thanks!

Case closed due to no further comments received.


Fix checks around session config settings

When checking if the session idle timeout and lifetime are within our
limits, we were not comparing the same time units. Furthermore, this
check was only happening in prod, so we missed this bug in staging.
This fixes the checks so that they compare the same time units, and
allows the checks to run in all deployed environments.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 2dffbf7ca5040f5ddd70d3c1c7a1522eae217bba


No such file or directory issue

Type: Bug
My program keeps telling me that there is no such file or directory for my json file even though they are in the same project file and I tripled checked the directory path and they are the same path so im not sure what the issue is
VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-10900K CPU @ 3.70GHz (20 x 3696)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.92GB (2.64GB free)

Process Argv
--crash-reporter-id 2e08cdd8-75f7-44a1-85c8-cbbb091cab88

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

python
ms-
2023.12.0

vscode-pylance
ms-
2023.7.10

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263cf:30784848
vscaat:30438848
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
pyind779:30671433
89544117:30613380
vscrp:30673768
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
a2ce3375:30757347
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30780429
pythonnosm12tcf:30779713
pythonidxpt:30784022
pythonnoceb:30776495
h7j2d465:30786200

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


My animation is looping

Hello everybody,
sorry in advance if I'm not in the right place.
I'm using animate cc 2015.2 and just create à circle like that:
under Scene 1 Frame 1 (séquence1 ->calque1: image 1):
this.stop();
var s = Snap(400,400);
var circle = s.circle(90,120,80);
The result is multiple circles on the screen.The script  seem to make à loop .
In animate CC i verifying that a looping instruction are not checking without any result.
I thing i don't understand something....
Can someOne help me ?
Sorry for my bad english
-azur-

This is a duplicate of bug #75
I have a fix for this on dev if you replace the published SnapSVGAnimator.js file in your project with the one in dev it should fix the issue.  Also when you create a new Snap instance it will create a new SVG element rather than draw in your current stage SVG element.  You should instead call
this.el.circle(90,120,80);


Is .desktop mandatory in AppDir/usr/share/applications  too or just in AppDir root?

This line says:
https://github.com/AppImage/AppImageSpec/blob/f1631a2ab03703932ec31b6ec6cb1b119d6dcbdd/draft.md?plain=1#L146
However, if we don't ship the desktop file in the "usual" place (AppDir/usr/share/applications), appstreamcli (which is called by appimagetool) fails:
Trying to validate AppStream information with the appstreamcli tool
In case of issues, please refer to https://github.com/ximion/appstream
org.gimp.GIMP.Continuous.appdata.xml
  W: org.gimp.GIMP.Continuous:~: desktop-file-not-found

✘ Validation failed: warnings: 1, pedantic: 2

A desktop file is not mandatory
But according to the AppImageSpec, the AppDir SHOULD contain exactly one $APPNAME.desktop file in its root directory with $APPNAME being the name of the payload application. This can be used by desktop integration tools to know some metadata about the main application (since there could be multiple ones in the AppDir)
And if you want to use AppStream, you also need one in usr/share/applications because that is where AppStream needs it.

@probonopd that's not entirely true. The original ancient AppDir spec from ROX Filer does not mandate them. However, virtually any AppImage related tool mandates their existence. Cf. https://docs.appimage.org/reference/appdir.html. Please refer to such reference documents.

...which is why I wrote

A desktop file is not mandatory

;)


Command Spotlight: Show which other blocks the transaction was found in

By default, we show the canonical, but we might also want to see which other blocks (non-canonical) the transaction was also found in.

There are 3 inputs that potentially can contribute on that page: canonicity, state_hash, and txn_hash. Since we populate the table with either canonical or non-canonical blocks. IMHO, it makes sense to to drill in by including the state_hash and txn_hash. There will be no ambiguity on the results since it will always return the correct result.

This relates to this issue on the indexer: https://github.com/Granola-Team/mina-indexer/issues/1092#issuecomment-2161028157

Moving milestone because that other issue is in another milestone.

This issue is meant to capture a new feature that we haven't developed yet, that would show other state hashes (non canonical blocks) that txn hash was found in. Moving this back to maintenance.


Instrument with OpenTelemetry

It may be worth adding OpenTelemetry instrumentation to the operator (and cli?) for a few reasons:

Metrics for things like nodes connected, early disconnects, update issues or plan retries, etc...
Better debugging when something goes wrong since tracing can highlight dependency interactions in a way that is hard to get from stdout logging
Learn timing of how our component interacts with other components (kubeapi, rancher, network latency between node and operator, etc...)
(opinion) We should be adopting this for more projects and this component might be a lower risk proving ground for the value it can bring

Note: I would not expect that we force everyone to setup jaeger or prometheus. But being able to add the right flags to get the data published would be useful when appropriate.

For reference: https://opentelemetry.io/docs/instrumentation/go/getting-started/

@davidstauffer 👆🏻

Any updates on this?

Hey @krumware 👋🏼
no updates on this.
Adding this to the backlog to not get it out of our radar, but there is no plan to work on this feature at present.

Sounds good thanks for the update. It's starting to come up in convos with Prime customers, so just staying out ahead. Thanks!