Issue with module path/name in imported classes when using from...import on flask.ext.* (Python 3)

There is an issue when importing something inside an extension using Python 3 where Flask imports the classes in such a way that they are no longer equal to the same classes imported inside the extension. The issue occurs when importing from a submodule of an extension using from flask.ext.xxx.yyy import zzz.
The classes imported using from-import get masked as <class 'flask.ext.xxx.yyy.zzz'>, where <class 'flask_xxx.yyy.zzz'> would be expected.
The issue is specific to Python 3.
Example:
Python 3.4.0 (default, Apr  9 2014, 11:51:10)
[GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.38)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from flask.ext.restful.fields import String
>>> from flask_restful.fields import String as String_internal
>>> String == String_internal
False
>>> String
<class 'flask.ext.restful.fields.String'>
>>> String_internal
<class 'flask_restful.fields.String'>
>>> import flask.ext.restful
>>> import flask_restful
>>> flask.ext.restful.fields.String == flask_restful.fields.String
True
>>> flask.ext.restful.fields.String
<class 'flask_restful.fields.String'>
>>> flask_restful.fields.String
<class 'flask_restful.fields.String'>

I just unexpectedly hit the same issue. Should https://github.com/mitsuhiko/flask/pull/1220 be considered normative now, or not until it actually gets merged?

Yes, import directly from the package you installed, do not use the flaskext namespace package or the flask.ext import helper.

Great, thanks.

Closing this as Flask 0.11 added a runtime warning that the flask.ext namespace is deprecated. So it's no longer easy to miss.


New design

New design was where most of the additions were made, so it made sense to merge it to master.


Installing "less than" dependency fails to find the package

[x] I am on the latest Poetry version.

[x] I have searched the issues of this repo and believe that this is not a duplicate.

[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: OS X Mojave. Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64

Poetry version: Poetry 0.12.17

Link of a Gist with the contents of your pyproject.toml file:
https://gist.github.com/MadWombat/a9cf58d94bc0a683c2138dad04a3e8a4

Installing a dependency for Django LTS works fine with pip, but fails with poetry
with pip:
~/project/> pip3 install 'Django<1.12'
Collecting Django<1.12
  Downloading https://files.pythonhosted.org/packages/70/22/237da71dc112f2bba335c18380bc403fba430c44cc4da088824e77652738/Django-1.11.22-py2.py3-none-any.whl (6.9MB)
     |████████████████████████████████| 7.0MB 3.9MB/s
Collecting pytz (from Django<1.12)
  Using cached https://files.pythonhosted.org/packages/3d/73/fe30c2daaaa0713420d0382b16fbb761409f532c56bdcc514bf7b6262bb6/pytz-2019.1-py2.py3-none-any.whl
Installing collected packages: pytz, Django
Successfully installed Django-1.11.22 pytz-2019.1

with poetry:
~/project> poetry add 'Django<1.12'

[PackageNotFound]
Package [Django<1.12] not found.

add [-D|--dev] [--git GIT] [--path PATH] [-E|--extras EXTRAS] [--optional] [--python PYTHON] [--platform PLATFORM] [--allow-prereleases] [--dry-run] [--] <name> (<name>)...

At the moment, you have to do it like so:
poetry add "django:<1.12"

The notation you are using will be supported in the 1.0.0 verson (see #1221)


bedtools slop chromosome boundaries

bedtools slop will check if the output is within chromosome boundaries, but not the input.

this is now fixed in master


🧠 Logic: 🔑 verify_signature/4 predicate

Idea
In the logic module, implements a new Prolog custom predicate allowing to verify a digital signature.
Context
When designing governance rules through Prolog evaluated by the logic module, the ability to check a cryptographic signature through a dedicated predicate could be useful in the perspective where an authority issue some verifiable credentials and one needs to check that these credentials have truly been signed by this trusted authority.
Spec Proposal
Predicate signature: verify_signature(Alg, PubKey, Msg, Sig) is det.
Where:

Alg: The algorithm used to sign the message.
PubKey: The public key derived from the private key who signed the message.
Msg: The message who has been signed.
Sig: The message signature.

Regarding the supported algorithms I think we can give a priority to ed25519.

To be in line with the form of predicates provided by SWI Prolog in that matter, I'd suggest the following naming scheme:
<algo>_verify(+Key, +Data, +Sig, +Options) is semidet

Note that the predicate family is semidet (semi-deterministic) since the predicate has the potential to either succeed once or fail.
For instance:
eddsa_verify(+Key, +Data, +Sig, +Options) is semidet

where Options is:

type( ed25519 ).

And:
secp_verify(+Key, +Data, +Sig, +Options) is semidet

where Options is:

type(secp256k1) or type(secp256r1).


CompareAttribute won't work on records values

The compare attribute when applied to a record parameter give the error message it is only valid on property or indexers.
Issue:
I was using the compare in a record to validate passwords. The error message was display. When I created a custom comparer and added the flag attributes of Parameter and Fields it resolved the issue.
Proposed Solution:
Add the attribute usage flag "AttributeTargets.Parameter". The AttributeTargets.Fields may also need to be added.

This repo is not the right place to report issues, suggest improvements or ask questions about .Net.
That being said, if you want to add an attribute to the property generated from a record primary constructor, you can do it by specifying property: on the attribute, e.g.:
record R([property: Compare("J")] int I, int J);

If you still think CompareAttribute should be changed, the right place to propose that is the dotnet/runtime repo.


Improve performance of Gröbner basis approach

According to my observations SageMath's (PolyBoRi's) calculation of Gröbner bases is (noticeably) faster when given a degree-bound; even if this bound does not affect the computation at all. Since Boolean polynomials are square-free, such a bound is given by the number of variables (of the respective ring), and leads to significant speedups.
(At least on my machine with Sage 9.5 some of the experiments of the README could be solved nearly twice as fast.)

Thanks Julian for your contribution! I just merged it!


UISearchBar重复约束导致 push进入时键盘弹起后马上收起

Swift
iOS13.5
进入页面键盘弹起后马上又收起，调用栈显示系统调用的resignFirstResponder

约束问题
[LayoutConstraints] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want.
	Try this:
		(1) look at each constraint and try to figure out which you don't expect;
		(2) find the code that added the unwanted constraint or constraints and fix it.
	(Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
	<NSAutoresizingMaskLayoutConstraint:0x281df0320 h=--& v=--& UISearchBar:0x1170211e0.minX == 2   (active, names: '|':UIView:0x11701e130 )>,
	<NSLayoutConstraint:0x281d26f30 H:|-(0)-[UISearchBar:0x1170211e0](LTR)   (active, names: '|':UIView:0x11701e130 )>
)

问题解决了吗


Updated email regex

I found the previous regex did not cover including a + symbol in the email (e.g<EMAIL_ADDRESS>- updated to the Swift regex example found at http://emailregex.com

Hey @hkellaway, thanks for the pull request, but the tests are failing. Can you push an update to have all the tests pass?

have yet to find a proper regex

@ThibaultKlein updated this to support plus and period in middle of email (e.g<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@ThibaultKlein Travis isn't failing because of tests but because of verbose output. i recall you knew how to fix that - added you as a collaborator on my fork if you care to push to it in my absence

Thanks for the update @hkellaway, I fixed the issue. You have to add --silent option to pod repo update


Find eradication

The goal is to convert our legacy finders over to using associations

introduce aar_scope to ActAsActiveRecord, so a model can implement that method instead of find.
convert string arguments to just use hashes.
use relation methods instead of :conditions

/cc @matthewd Yay (we need a rails 5 tag)
/cc @gtanzillo @jrafanie @Fryguy FYI

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

cool - only 2 failures. I'll start diving deeper.
Think we may need to add a few to_a in there to reduce query counts. Would prefer to do that later so we can leverage the associations/chains.

ok. so the build failure was a stubbing failure.
I found a few spots that were wrong. Also realize that we may want to add a bunch of to_a entries here.
We'll see

Found a hundred or so find_all_by_XXX(value, :order => "")
Guessing we should do this as a separate PR, but I'm open for suggestions


Too much space wasted for search bar

On home page we have wasted too much space for search bar. See additional space inside text bar plus shadow of text bar.
Device type: OnePlus 7 Chrome.

Attached snap.

Closing due to inactivity.


Error reading harvest data: Socket write error: [Errno 32] Broken pipe

Origin: server.inverters.ModbusSunspec

should be fixed in https://github.com/srcfl/srcful-gateway/commit/8abce9056cc51c4c6891c9ba23c4153c66285ced


新手问题,关联其他数据表的操作。

我的数据结构这样的
type Player struct {
        ID   uint `gorm:"primary_key;AUTO_INCREMENT"`
	Name string `gorm:"not null;unique"`
	Cards []Card `gorm:"ForeignKey:PlayerID"`
}

type Card struct {
	PlayerID uint `gorm:"not null;unique"`
	CardCfgID uint `gorm:"not null;unique"`
	Num uint
}

1.如果想查询一个player的信息,如果一起查询出Cards要这样
var player Player
err = db.Where("Name = ?", "Mike"). Limit(1).Find(&player).Error
	if nil != err {
		fmt.Println(err)
	}
db.Model(&player).Related(&player.Cards)

有没有更简单的方式查出cards等关联信息呢。如果玩家关联很多别的属性，每个属性都加一行related有点麻烦
2看文档说默认保存关联的数据的我的没保存呢.我的代码不知道哪里问题，好像每个玩家只能存一张卡牌，cards加入第二张牌时候就存不上第二张了。 Player结构体里面cards的tag改成这样也一样的结果Cards []Card gorm:"many2many:Cards;"。
下面是保存player的代码。
        card1 := Card{PlayerID:player.ID,CardID:1}
	player.Cards = append(player.Cards, card1)
	card2 := Card{PlayerID:player.ID,CardID:2}
	player.Cards = append(player.Cards, card2)
	db.Set("gorm:save_associations", true).Save(&player)
	db.Save(player)

Try using the ```go ``` tags around your code for better readability :)

Please, can you use english? I'm from Ukraine, for me text in japan is unreadable. Especially because maybe someone will have the same question and will not have opportunity to find it in tracker.

ok,Mykytanikitenko.Let me translate my question into English a few minutes.

Hi,mykytanikitenko.
Here is the English version.:-)
My struct is Here.
type Player struct {
        ID   uint `gorm:"primary_key;AUTO_INCREMENT"`
	Name string `gorm:"not null;unique"`
	Cards []Card `gorm:"ForeignKey:PlayerID"`
}

type Card struct {
	PlayerID uint `gorm:"not null;unique"`
	CardCfgID uint `gorm:"not null;unique"`
	Num uint
}

1.I want to query player info with player's cards info. Here is my code.
var player Player
err = db.Where("Name = ?", "Mike"). Limit(1).Find(&player).Error
	if nil != err {
		fmt.Println(err)
	}
db.Model(&player).Related(&player.Cards)

Is there having some easy way to query player info automatic with cards info,without  additional code db.Model(&player).Related(&player.Cards)
2.The document said it will automatic save cards info when I save player info use db.save(player)
But now, I cannot save player's second card.
And it yet not work to change Cards tag to this Cards []Card gorm:"many2many:Cards;"``
Here is my code
        card1 := Card{PlayerID:player.ID,CardCfgID :1}
	player.Cards = append(player.Cards, card1)
	card2 := Card{PlayerID:player.ID,CardCfgID :2}
	player.Cards = append(player.Cards, card2)
	db.Set("gorm:save_associations", true).Save(&player)
	db.Save(player)

My card table only have one data of card1 in mysql.
And can you read my bad English?

This should automatically save the associations you submit:
db.Model(&player).Association("Card").Append(card1, card2)

多谢，Allendar.
我找到不能加入第二张卡片的原因了。
我需要的逻辑是，playerID和CardCfgID 共同做主键。
每个玩家都可以有很多种卡牌。只有playerID和CardCfgID同时重复才是错误的,其他情况应该都是正确的.
我现在的结构体tag配成了Card有两个主键，任意一个重复就报错，怎么才能把tag改成我需要的逻辑呢？
Thx, Allendar.
I found the reason why I can not add the second card into table.
In my logic, I want to combine Card.PlayerID and Card.CardCfgID as one primary key.
Every player can have many kind of card in the cards table.Both playerID and CardCfgID are duplication is Error else is right.
But not the card table has two unique fields. How can I tag the card's field as my logic?

It sounds like you're trying to achieve a Many2Many relationship? Many Players can have Many Cards? I'm not sure I understand on what level you want to constrict the relationship of the Player and it's Cards.

Thx for your reply.
I do not care what level of relationship of db.I just want to finish requirement lol.
I know for higher level db, I must have Player table, Card Kind table,and Player and Card Kind relationship table.
But in my game, Card Kind table is not in db . It a const configuration which is read by code and limit by code.
So I design  structs like this.can you help me.
type Player struct {
        ID   uint `gorm:"primary_key;AUTO_INCREMENT"`
	Name string `gorm:"not null;unique"`
	Cards []Card `gorm:"ForeignKey:PlayerID"`
}

type Card struct {// It's a Player and Card Kind relation table.
	PlayerID uint //`half key,I do not know how to fill it"`
	CardCfgID uint //`"another half key,I do not know how to fill it"`
	Num uint
}

Anyway,I make my requirement clear now. Can you help me replace the placeholder?
type Player struct {
	ID   uint `gorm:"primary_key;AUTO_INCREMENT"`
	Name string `gorm:"not null;unique"`
	Cards []PlayerCardKindRelation `gorm:"many2many:Cards;"`
}

type PlayerCardKindRelation struct {
	PlayerID uint//xxxxx?????????????? placeholder 1
	CardID uint//xxxxx?????????????? placeholder 2
	Num uint
}

type CardKind struct{
	cardKindID uint `gorm:"primary_key;AUTO_INCREMENT"`
}

It's very good to use constants as type-identifiers, as long as you know for sure they will never be needed in deeper relationship-combinations.
If I understand you right, you want to know how many Cards a Player would be having of a certain type of card?
I think your spec would look something like this:
type Player struct {
	gorm.Model
	Name string `gorm:"not null;unique"`
	Cards []PlayersCards
}

type Card struct {
	base.Model
	Name string `gorm:"not null"` // e.a. Knights of the Round Table
}

type CardKind struct{
	gorm.Model
	Name string `gorm:"not null"` // e.a. Legendary Elder
}

type PlayersCards struct {
	gorm.Model
	Player Player
	PlayerID uint `gorm:"not null"`
	Card Card
	CardID uint `gorm:"not null"`
	Num uint // Amount? or is this meant for something else?
}

Sorry if I'm understand you wrong. If you want control over your Many2Many table (pivot) you need to make it n2M:M2n yourself (PlayersCards) and it's then not a M2M anymore for GORM.
In the above example you do something like player.Cards.Related("Card", "card_kind_id = ?", cardKingID). You should try out what suits for you tho. Maybe I'm totally going off track now :P

Sounds good,and thank you.
let me have a try.

I have two new problems,now.
First there  have a error when I save player.
panic: reflect.Value.Addr of unaddressable value

goroutine 1 [running]:
reflect.Value.Addr(0x6b4860, 0xc042082c40, 0x99, 0x5, 0x0, 0x0)
	D:/Go/src/reflect/value.go:239 +0xba
github.com/jinzhu/gorm.queryCallback(0xc0424acc80)
	D:/GoPath/src/github.com/jinzhu/gorm/callback_query.go:70 +0x3d8
github.com/jinzhu/gorm.(*Scope).callCallbacks(0xc0424acc80, 0xc042107fc0, 0x3, 0x4, 0xc0424acc80)
	D:/GoPath/src/github.com/jinzhu/gorm/scope.go:821 +0x53
github.com/jinzhu/gorm.(*DB).First(0xc042075b00, 0x6b4860, 0xc042082c40, 0x0, 0x0, 0x0, 0x5451b6)
	D:/GoPath/src/github.com/jinzhu/gorm/main.go:271 +0x1e2
github.com/jinzhu/gorm.(*DB).FirstOrCreate(0xc042075b00, 0x6b4860, 0xc042082c40, 0x0, 0x0, 0x0, 0xc04202bd40)
	D:/GoPath/src/github.com/jinzhu/gorm/main.go:353 +0x86
github.com/jinzhu/gorm.(*DB).Save(0xc04213a000, 0x6b4860, 0xc042082c40, 0xc042082c40)
	D:/GoPath/src/github.com/jinzhu/gorm/main.go:397 +0x125
main.Test()
	D:/GoProject1/server_db_examplenew/src/server/main.go:90 +0xac0
main.main()
	D:/GoProject1/server_db_examplenew/src/server/main.go:11 +0x27

Second, how to limit player_id and card_id don't duplicate at the same times in players_cards table.
My game database struct is very similar to  Clash Royale game. Players collect cards.Does it help you know what I want to do lol.
Here's my code lol.
type Player struct {
	gorm.Model
	Name string `gorm:"not null;unique"`
	Cards []PlayersCards `gorm:"many2many:PlayersCards;"`
}

type PlayersCards struct {
	gorm.Model
	Player Player
	PlayerID uint `gorm:"not null"`
	Card Card
	CardID uint `gorm:"not null"`
	Amount uint
	Level uint `gorm:"default:'1'"`
}

type Card struct {
	ID uint `gorm:"primary_key"`
	Name string `gorm:"not null"` // e.a. Knights of the Round Table
}

func Test() {
	db, err := gorm.Open("mysql", "mike:123456@tcp(localhost:3306)/gorm?parseTime=true")
	defer db.Close()
	if err != nil {
		panic("connect db error")
	}
	defer db.Close()

	// 自动迁移模式
	db.AutoMigrate(&Player{})
	db.AutoMigrate(&Card{})
	db.AutoMigrate(&PlayersCards{})

 	// create player named mike
	err1 := db.Create(&Player{
		Name: "Mike",
	}).Error
	if nil != err1 {
		fmt.Println("already exist:",err1)
	}

	// create card with id 1 and name goblin
	err1  = db.Create(&Card{
		ID:1,
		Name: "goblin",
	}).Error
	if nil != err1 {
		fmt.Println("already exist:",err1)
	}

	// create card with id 2 and name Archer
	err1  = db.Create(&Card{
		ID:2,
		Name: "Archer",
	}).Error
	if nil != err1 {
		fmt.Println("already exist:",err1)
	}

	//query player Mike
	var player Player
	err = db.Where("Name = ?", "Mike"). Limit(1).Find(&player).Error
	if nil != err {
		fmt.Println(err)
	}
	db.Model(&player).Related(&player.Cards)

	//mike's has 10 goblin cards.
	playersCard1 := PlayersCards{PlayerID:player.ID,CardID:1,Amount:10}
	player.Cards = append(player.Cards, playersCard1)
	//mike's has 5 Archer cards.
	playersCard2 := PlayersCards{PlayerID:player.ID,CardID:2,Amount:5}
	player.Cards = append(player.Cards, playersCard2)
	//db.Model(&player).Association("Cards").Replace(player.Cards)
	db.Save(player)
}

I found this problem https://github.com/jinzhu/gorm/issues/1037
But I do not know how to fix it.

Don't use composite primary keys for associative m2m tables, just create unique(player_id, card_id) constraint

How to mark go unique(player_id, card_id)  in struct
type PlayersCards struct {
	gorm.Model
	PlayerID uint `gorm:"not null;unique"`
	CardID uint `gorm:"not null;unique"`
	Amount uint`gorm:"default:'0'"`
	Level uint `gorm:"default:'1'"`
}

It's
UNIQUE KEY player_id (player_id),
UNIQUE KEY card_id (card_id),
in sql,
but not unique(player_id, card_id)

It work for unique(player_id,card_id)
type Player struct {
	ID    uint `gorm:"primary_key"`
	Name string `gorm:"not null;unique"`
	Cards []PlayersCards
}

type PlayersCards struct {
	gorm.Model
	PlayerID uint `gorm:"unique_index:idx_name_code"`
	CardID uint `gorm:"unique_index:idx_name_code"`
	Amount uint`gorm:"default:'0'"`
	Level uint `gorm:"default:'1'"`
}

But how to relation player.cards with PlayersCards .playerid.
db.Model(&player).Related(&player.Cards) not work, and db.Save(player) crash.

I mainly avoid defining combined indexes on the objects. Try;
err := db.Model(&PlayersCards{}).AddUniqueIndex(
    "uidx_player_card",
    "player_id", "card_id",
).Error
if nil != err {
    panic(err)
}

Thank you very much.

Problem solved now.
I use golang code solved associations and only use gorm some base functio .

@mykytanikitenko  The language which Mikejinhua first written is Chinese not Japanese

Don't use composite primary keys for associative m2m tables, just create unique(player_id, card_id) constraint

This is Chinese

我遇到同样不能查询出来，文档说了个寂寞，头大，还不是新手才死，太难用了这个框架


modules: hostap: Fix memory leak of network

In "connect" all networks are removed and  new network is always added, but in disconnect the network isn't deleted, so, the memory is unnecessarily held till next connect. This is not exactly a leak, but if someone profiles using "kernel heap" then this can be construed as a leak.
Fix this by removing network during the disconnection (for now "all") so that the memory can be used by someone else.

This conflicts with https://github.com/zephyrproject-rtos/zephyr/issues/77072 but once that feature is implemented then we can modify this to remove only a single network (disconnect -> remove_network)

@krish2718 hostap pr is now merged, please update the manifest

Please rebase on main and resolve any merge conflicts.


Template chooser for menu

As Bootstrap is getting close to a version 4 release, the code has changed. Provide a way to use multiple templates, not only for the entire site but on a component by component basis

Might also be a nice to have a "clean" component. Not all menu's are structured on Bootstrap 🤔


[FEAT] Pomodoro linked opening of card review.

Is your feature request related to a problem? Please describe.
It takes effort to actually do spaced repetition.
Describe the solution you'd like
Could obsidian be set up to automatically pop up a single card every x minutes. 25 minutes is the standard Pomodoro length, but the exact number should obviously be able to be set by the user.
Additional context
Add any other context or screenshots about the feature request here.

Hi @vorpalvorpal
Unfortunately no one else has requested this feature, and isn't likely to be something that would be implemented in the plug-in for the foreseeable future.
Have you considered some kind of macro playback utility? something like:
https://autohotkey.en.softonic.com/
Perhaps that can be configured to wait 25 minutes, bring the Obsidian window to the front, simulate pressing a hot key that would activate the flashcard review window.
(autohotkey - Not a particular product recommendation)
Cheers
Ronny

No worries. I might try using the custom js plugin to get the functionality.


Docs: Svelte reactive, fixed #272

#272

🎉 Released in https://github.com/master-co/css/releases/tag/v2.0.0-beta.172


从9/14开始报错 Starting from 9/14, reporting errors

Run jlumbroso/free-disk-space@main
with:
tool-cache: true
android: true
dotnet: true
haskell: true
large-packages: true
swap-storage: true
docker-images: true
env:
REPO_URL: https://github.com/coolsnowwolf/lede
REPO_BRANCH: master
FEEDS_CONF: feeds.conf.default
CONFIG_FILE: x64.config
DIY_P1_SH: diy-part1.sh
DIY_P2_SH: diy-part2.sh
RELEASE_TAG: X64
UPLOAD_BIN_DIR: true
UPLOAD_FIRMWARE: true
UPLOAD_COWTRANSFER: false
UPLOAD_WETRANSFER: false
UPLOAD_RELEASE: true
TZ: Asia/Shanghai
Run # ======
======
MACROS
======
macro to print a line of equals
(silly but works)
printSeparationLine() {
str=${1:=}
num=${2:-80}
counter=1
output=""
while [ $counter -le $num ]
do
output="${output}${str}"
counter=$((counter+1))
done
echo "${output}"
}
macro to compute available space
REF: https://unix.stackexchange.com/a/42049/60849
REF: https://stackoverflow.com/a/450821/408734
getAvailableSpace() { echo $(df -a $1 | awk 'NR > 1 {avail+=$4} END {print avail}'); }
Package 'dotnet-sdk-7.0-source-built-artifacts' is not installed, so not removed
Package 'dotnet-templates-6.0' is not installed, so not removed
Package 'dotnet-templates-7.0' is not installed, so not removed
Package 'dotnet-apphost-pack-3.1' is not installed, so not removed
Package 'dotnet-runtime-3.1' is not installed, so not removed
Package 'dotnet-sdk-3.1' is not installed, so not removed
Package 'dotnet-hostfxr-3.1' is not installed, so not removed
Package 'dotnet-runtime-deps-3.1' is not installed, so not removed
The following additional packages will be installed:
aspnetcore-targeting-pack-6.0 aspnetcore-targeting-pack-7.0
The following packages will be REMOVED:
aspnetcore-runtime-6.0 aspnetcore-runtime-7.0 dotnet-apphost-pack-6.0
dotnet-apphost-pack-7.0 dotnet-host dotnet-hostfxr-6.0 dotnet-hostfxr-7.0
dotnet-runtime-6.0 dotnet-runtime-7.0 dotnet-runtime-deps-6.0
dotnet-runtime-deps-7.0 dotnet-sdk-6.0 dotnet-sdk-7.0
dotnet-targeting-pack-6.0 dotnet-targeting-pack-7.0
The following packages will be upgraded:
aspnetcore-targeting-pack-6.0 aspnetcore-targeting-pack-7.0
2 upgraded, 0 newly installed, 15 to remove and 16 not upgraded.
Need to get 3045 kB of archives.
After this operation, 1029 MB disk space will be freed.
Get:1 file:/etc/apt/apt-mirrors.txt Mirrorlist [142 B]
Ign:2 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-6.0 amd64 6.0.121-0ubuntu1~22.04.1
Ign:3 http://azure.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-7.0 amd64 7.0.110-0ubuntu1~22.04.1
Ign:2 http://archive.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-6.0 amd64 6.0.121-0ubuntu1~22.04.1
Ign:3 http://archive.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-7.0 amd64 7.0.110-0ubuntu1~22.04.1
Ign:2 http://security.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-6.0 amd64 6.0.121-0ubuntu1~22.04.1
Err:2 mirror+file:/etc/apt/apt-mirrors.txt jammy-updates/universe amd64 aspnetcore-targeting-pack-6.0 amd64 6.0.121-0ubuntu1~22.04.1
404  Not Found [IP: <IP_ADDRESS> 80]
Ign:3 http://security.ubuntu.com/ubuntu jammy-updates/universe amd64 aspnetcore-targeting-pack-7.0 amd64 7.0.110-0ubuntu1~22.04.1
Err:3 mirror+file:/etc/apt/apt-mirrors.txt jammy-updates/universe amd64 aspnetcore-targeting-pack-7.0 amd64 7.0.110-0ubuntu1~22.04.1
404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/universe/d/dotnet6/aspnetcore-targeting-pack-6.0_6.0.121-0ubuntu1%7e22.04.1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/universe/d/dotnet7/aspnetcore-targeting-pack-7.0_7.0.110-0ubuntu1%7e22.04.1_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

+1

+1

@allok1985 @ywt114 @mskyttner Do you still have these issue with v1.3.0? If so, please reopen this ticket.

Thanks, tried switching from kfir4444/free-disk-space@main and got this warning from my GHA:
E: Unable to locate package google-cloud-sdk
Warning: The command [sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel libgl1-mesa-dri --fix-missing] failed to complete successfully. Proceeding...

@mskyttner Thank you so much for the feedback. I can confirm:

the warning is expected and harmless—but thanks to you, I have now fixed it in commit https://github.com/jlumbroso/free-disk-space/commit/d5af243ce7bacb67384aa6c5b1fc5f169e30903e, which will be bundled in the next release (since Google has two names for their package, google-cloud-sdk and google-cloud-cli, we try to remove both, and one of them will fail; we now report this silently through a debug notification rather than a warning);
it should not affect your final image push.

Thanks so much for following up and letting me know how the recent changes affected you! 👌🏻


throw er; // Unhandled 'error' event (on v1.0.7)

Hi, again.
I updated to 1.0.7
however getting almost the same error.
Please help.
$ swagger2pdf -v
1.0.7
$ swagger2pdf -s my_sample_swagger.json -o ./dump/
events.js:182
throw er; // Unhandled 'error' event
^
Error: spawn http-server ENOENT
at exports._errnoException (util.js:1014:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:189:19)
at onErrorNT (internal/child_process.js:366:16)
at _combinedTickCallback (internal/process/next_tick.js:102:11)
at process._tickCallback (internal/process/next_tick.js:161:9)

Error means node can't find http-server. Could you please check did http-server installed globally.
$ which http-server
/usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/bin/http-server

In version 1.0.7 I just update the script to preinstall http-server before swagger2pdf.
If error keeps, please show me the installation info, like:
$ npm install -g swagger-spec-to-pdf

><EMAIL_ADDRESS>preinstall /usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/lib/node_modules/swagger-spec-to-pdf
> npm i -g http-server

/usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/bin/http-server -> /usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/lib/node_modules/http-server/bin/http-server
/usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/bin/hs -> /usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/lib/node_modules/http-server/bin/http-server
+<EMAIL_ADDRESS>updated 1 package in 24.506s
/usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/bin/swagger2pdf -> /usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/lib/node_modules/swagger-spec-to-pdf/bin/swagger2pdf

><EMAIL_ADDRESS>postinstall /usr/local/Cellar/nvm/0.31.0/versions/node/v8.1.0/lib/node_modules/swagger-spec-to-pdf/node_modules/electron-prebuilt
> node install.js

+<EMAIL_ADDRESS>added 153 packages in 122.327s

Quick fix of your issue is manually installing http-server.
Do
$ npm install -g http-server

@MJ17 Please let me know if you want to track this issue or just using the quick fix. If quick fix, I would close the issue.

Hmm, I installed 'http-server' globally
and I'm still getting the same error.
seems that quick fix doesn't work...
btw, I'm running on Windows OS
PS C:\User\pennj\Desktop> Get-Command http-server
CommandType    Name

Application    http-server.cmd
Application    http-server
PS C:\User\pennj\Desktop> http-server
Starting up http-server, serving ./
Available on:
http://{IP_ADDRESS}:8080
http://<IP_ADDRESS>:8080
Hit CTRL-C to stop the server
http-server stopped.
PS C:\User\pennj\Desktop>

Gotcha. Seems it's an issue of windows node. Since I have no windows machine, I cannot test & reproduce.
Maybe you can search "node child_process spawn windows" with google.
Some ref:
child_process.spawn for windows?
child_process.spawn fails on Windows given a space in both the command and an argument

I reproduced this issue with Linux Ubuntu 16.04


Jumping to a nonexistent label causes RGBLINK to crash

Linking this assembly file (test.asm) causes a segfault in rgblink:
SECTION "test",ROM0
entry:
        jr nonexistent_label

Command-line:
rgbasm test.asm -o test.o
rgblink test.o -o test.gb

Output from make develop version:
src/link/patch.c:340:21: runtime error: member access within null pointer of type 'const struct Symbol'
Segmentation fault

This happens with both jr and jp. Haven't tried anything else.

Yeah same problem here. I'm making a wrapper around rgbasm in TRSE (www.turborascal.com), and the assembler doesn't produce any warnings/errors when trying to call / jp to incorrect labels, making debugging very hard to do...

This kind of thing definitely needs a test.

It's really the linker's fault that it doesn't check for nonexistent
symbols. The assembler doesn't know if the label exists or not until the
program is linked.

well - it would be amazing if the linker could provide an helpful error message ("unknown label XXX on line 542") instead of a segfault =) I use the error messages to automatically trace back to the source code

Wut? I'm surprised this isn't caught at all; this should also cause segfaults no matter which expression you use it in, not just jumps.

issotm@sheik-kitty ~% rgbds/rgbasm -V
rgbasm v0.4.0-28-g828edb7-dirty
issotm@sheik-kitty ~% echo 'SECTION"test",ROM0\nentry:\njr noexist' | rgbds/rgbasm -o /tmp/o -
issotm@sheik-kitty ~% rgbds/rgblink /tmp/o
src/link/patch.c:340:21: runtime error: member access within null pointer of type 'const struct Symbol'
zsh: segmentation fault (core dumped)  rgbds/rgblink /tmp/o

Reproduced on current master, I'm as surprised as you are.

It's even more embarrassing to see that an identical case was already handled a couple of lines above...

hehe this is fun! I manage my own IDE with a compiler, parser and assembler, and am completely aware of all the bugs that can / will show up in such a project... but this one is pretty severe indeed. Apart from this, I have no more complaints with rgbasm! yet!

@leuat Does your compiler compile C? I'm interested.

am completely aware of all the bugs that can / will show up in such a project...

If you have a good test base, I'm interested in help with #485, if only to have projects to test the WIP new lexer on.

see https://www.youtube.com/watch?v=xT-8cyqTbnE or https://www.youtube.com/watch?v=H3FQDnNP2m0  (www.turborascal.com) - it's a cross-platform Pascal compiler for the C64, C128, NES, X86 etc. Lots of tutorials and systems. I decided today that it's time to add Z80 support to my compiler, and wanted to use the Gameboy as a test case (similarly to the NES, which I have support for - with image / level / meta sprite resource editing, lots of tutorials etc). So I was kinda surprised when I didn't get any warnings/errors when I tried using incorrect labels etc.
I'm not entirely sure what #485 entails, but TRSE tends to produce massive .asm files when your program grows large, if that helps =)

It's not as much their size as the features they use. Oh well.

yeah that is a problem with my compiler: don't really use that much features, since most stuff is filtered through the parser (like: ifdefs and macros etc are all usesless, since it is supposed to be defined in the Pascal source, not the assember). Sorry about that!


CTHUB - vinpower .net app

Problem Description
ESP data provided us with their vinpower product, which is a .NET app which connects to a local database. We should look into creating a microservice that integrates with (contains) this app.
Solution Needs
For this spike, let's just see if we can, locally, containerize a .NET app (see https://docs.docker.com/language/dotnet/containerize/). This app should just be a simple script that calls the vinpower app (which, in turn, calls the local database) with a VIN and returns decoded information. We should be able to run this script from the command line inside the container.
Timebox

5-8 points?

Outcome
Details describing the outcome of the research

Was it successful? What direction should the work go?
Was it unsuccessful? Discuss next steps with team

Additional Context

The vinpower app (dll), database, and programmer's guide are in teams: Team Zelda -> CTHUB -> Vin Decoding -> vinpower

No longer necessary - we will be working with the java version of vinpower - closing this card.


fix(plugin): improve plugin errors

Some errors were hiding the real reason behind, most of them were exposed
when the user executing the command didn't have permissions to access the
requested resource, now, we also append the error from the API that show
explicitly the error when trying to access the resources.
Closes #5823

/test feature_type=smoke


Work around compiler type checker issue

This refactors a test and disables the RegexBenchmark target to work around a type checker issue in the April 21 development toolchain, used by CI. The test is still running properly with these changes (moved some function-scoped symbols out to the global scope, marked fileprivate).
Related: rdar://126877024

@swift-ci Please test


feat: add value check

Having the cache in the indexer-service raises a small risk though.
We treat indexer-service as a stateless service. So in the case an indexer-service was recently started, it wouldn't be aware of previous recent agora models, and that could lead to wrongly rejecting queries.
However the only other solution to this would be to have the indexer DB do the caching of models, which could be annoying to implement.


remove unused viriables in kubelet.go

What I did:

remove unused viriables in kubelet.go, since nodeNames is never used in code.

Signed-off-by: allencloud<EMAIL_ADDRESS>

This change is

I signed it!

/ok-to-test

oh dear, we're being really flaky
/retest

Thanks for your feedback and help. @DirectXMan12
And I am wondering could we make this move on? 🍺

It's passed.  Merging.


GATEWAY - Have to hit ENTER twice after leaving a BBS

When you are disconnected by the BBS remotely, you have to hit ENTER twice to get the BBS prompt to show up.

This cannot be avoided.  The root cause is described in the "partially open" problem as seen here:
http://www.codeproject.com/Articles/37490/Detection-of-Half-Open-Dropped-TCP-IP-Socket-Conne
The solutions provided are not feasible because the keep alive messages sent to a bbs would be interpreted as input since the BBS doesn't know anything about what's going on in a RAW connection.


FTD Parser not workin

I have some FTD logs not being routed as expected based on the Cisco nopri log parser.
Example:
Apr 25 2022 20:52:39   %FTD-1-430003: EventPriority: Low, DeviceUUID: b3d1a512-9fb2-11ec-a694-c70a1d72e8b8, InstanceID: 32, FirstPacketSecond: 2022-04-25T20:52:39Z, ConnectionID: 62894, AccessControlRuleAction: Allow, SrcIP: <IP_ADDRESS>, DstIP: <IP_ADDRESS>, SrcPort: 59501, DstPort: 443, Protocol: udp, IngressInterface: student, EgressInterface: outside, IngressZone: student, EgressZone: outside, IngressVRF: Global, EgressVRF: Global, ACPolicy: Employee-FTD-ACP, AccessControlRuleName: inside_interface_acl_4, Prefilter Policy: ABCD-Employee-PF, ConnectionDuration: 0, InitiatorPackets: 3, ResponderPackets: 4, InitiatorBytes: 1673, ResponderBytes: 2257, NAPPolicy: Balanced Security and Connectivity

#1667


Console key not working on linux.

Version: Devhead
OS: Xubuntu 18.04
After a bit of testing with @OTHGMars was unable to quickly resolve the problem. turns out there's no response from the key to anywhere.
The current solution is to change the toggleconsole binds to 'shift grave'.

other keys also don't work for example pressing "win" key in options cause a fatal and game crash after pressing ignore.


It is better to use the repository field in Cargo.toml

To allow Crates.io , lib.rs and the Rust Digger to link to it. See the manifest for the explanation.

Thanks for the fix!


upgraded npm packages

see package.json for changes
had to add allowEmpty option to glob since non-matchin singular file globs emit errors in the most recent version of glob-stream

Coverage remained the same at 93.478% when pulling c709d98806f8b16e4f12d3aa095966aceee01277 on feature/npm-dependency-upgrade into 7265b6532fd5c464f0b5cea4f377eef4c0bbe2b1 on master.

Coverage remained the same at 93.478% when pulling 2436a618ae587bd55ef6ae8455bd10530fc2d63d on feature/npm-dependency-upgrade into 7265b6532fd5c464f0b5cea4f377eef4c0bbe2b1 on master.


How to work with another packages that changes DOM too.

Hello.
Please see this issue in another package: https://github.com/armincms/nova-tab/issues/1
I'm using this armincms/nova-tab and as conditional-container changes the DOM, the component tab component does not works properly, because the fields array where changed with conditional-container
Can you please tell us a way to solve this when use conditional-container  alongside other components that changes DOM too?

@wemersonrv Hey I just got some time now to do a quick setup and try it out locally but it`s working for me, I have the following setup:
return Tab::make('tab-name', function ($tab) {

    $tab->group('first-tab-name', [

        Text::make('Name', 'name')->rules('required'),

        ConditionalContainer::make([

            Text::make('Test', 'test')->rules('required'),

        ])->if('name === works'),

    ]);

})->fullwidth()->toArray();

@wemersonrv Hey I just got some time now to do a quick setup and try it out locally but it`s working for me, I have the following setup:
return Tab::make('tab-name', function ($tab) {

    $tab->group('first-tab-name', [

        Text::make('Name', 'name')->rules('required'),

        ConditionalContainer::make([

            Text::make('Test', 'test')->rules('required'),

        ])->if('name === works'),

    ]);

})->fullwidth()->toArray();

Hello @milewski , test here and it works now. looking for their last releases, i realized that in latest releases they fix these erros when using it with another DOOM changer components like yours.
Cool. Liked your both components a lot... they are amazing togheter!

Okay, so the issues were with the other package., closing this for now


Investigate GitHub "Unable to render rich display" error

Recently Github has started being unable to render our backstopjs images and has the error "Unable to render rich display" we need to investigate into this because it is making it more difficult to review PRs without being able to see the visual changes

Moved to Jira: https://jira.ons.gov.uk/browse/ONSDESYS-221


clean dom up properly on disposal

This is possible solution for https://github.com/cyclejs/core/issues/263

I found a bug currently in this fix (while using with live with app), can be fixed with adding endWhen(clean$)  after fold.
.fold(patch, rootElement)
.endWhen(clean$)

@TylorS @staltz take a look at at it please, and give you opinion.

Are you ok with name clean$? maybe cleanUp$ or some other variant?
Are you ok with xs.merge(preprocessedVNode$, clean$)
What about injecting endWhen(clean$) before .drop(1)?

_clean$ just to make it clear it's a framework-internal API.
and 3) I think it could be xs.merge(preprocessedVNode$.endWhen(clean$), clean$)


Merge from master

Codecov Report

Merging #54 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               dev     #54   +/-   ##
=======================================
  Coverage     6.23%   6.23%
  Complexity      17      17
=======================================
  Files           16      16
  Lines          914     914
  Branches       120     120
=======================================
  Hits            57      57
  Misses         844     844
  Partials        13      13

Impacted Files
Coverage Δ
Complexity Δ

...ava/com/webank/wecross/console/common/Version.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91755f...bb82af3. Read the comment docs.


feat: node settings wired to haveno daemon

wired node settings to daemon and storage
updated tests and storybook
refactored for simplicity and code quality

Merged via CLI


Clarity on retrieval results

Hi,
Thanks for the impressive results! I want to have some clarity on the reported retrieval results:

Since you are using VTM loss, during retrieval, do you re-rank the candidates with VTM score among top candidates?
Are the reported number using duel softmax loss and QB-Norm?
Thanks!

Thanks for the clarification!


CoroutineCollection.save has no client session variant

It seems it is not possible to call save(entity, clientSession) on a CoroutineCollection as it is with a normal MongoCollection.
Is this intended?

This is not intended. I'm going to add it.

In case anyone else noticed this too, an easy workaround is to just add an extension function:
suspend fun <T : Any> CoroutineCollection<T>.save(document: T, clientSession: ClientSession): UpdateResult? {
    val id = KMongoUtil.getIdValue(document)
    return if (id != null) {
        replaceOneById(clientSession, id, document, ReplaceOptions().upsert(true))
    } else {
        insertOne(clientSession, document)
        null
    }
}


fix config path in disco-diffusion

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:

[ ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution! Your modification works!

Hey @austin273, please install pre-commit by pip install pre-commit and run pre-commit install before committing your code. Then the lint error will be automatically fixed.

Hi @austin273 ！First of all, we want to express our gratitude for your significant PR in the MMEditing . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution！❤


stage export

Description
export
Fixes # (issue)
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Refactor (refactoring code, removing useless files)
Unit tests (no changes in the code)
Bump-up dependent library (no changes in the code)
Benchmarks (no changes in the code)
Documentation update

Testing steps
Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 57.54% // Head: 57.54% // No change to project coverage :thumbsup:

Coverage data is based on head (13e767d) compared to base (fb65008).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   57.54%   57.54%
=======================================
  Files           7        7
  Lines         855      855
=======================================
  Hits          492      492
  Misses        325      325
  Partials       38       38

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


strange, incomplete polygon rendering at one zoom level and not others

I'm working on some basemap examples and wanted to use a continent layer. What I'm noticing is that at zoom 2, a large chunk of Asia is missing. When I zoom out to 1 or in to 3, the missing portion renders, but then when I'm at zoom 2 again, it disappears.
Not sure if this is isolated to this dataset... haven't noticed it happening with other polygons but just want to point it out in case it is something larger.
thanks!
https://cartodb.github.io/carto-vl/examples/editor/index.html#eyJhIjoiY29udGluZW50IiwiYiI6IiIsImMiOiJjYXJ0b3ZsIiwiZCI6Imh0dHBzOi8ve3VzZXJ9LmNhcnRvLmNvbSIsImUiOiJcblxuXG5cblxuIiwiZiI6eyJsbmciOjg0LjQ5NDc4MjQ5NDM0NDQ2LCJsYXQiOjIuODQyMTcwOTQzMDQwNDAxZS0xNH0sImciOjIsImgiOiJEYXJrTWF0dGVyIiwiaSI6ImRhdGFzZXQifQ==

This is because, by default, the tiler is oversimplifying polygons before sending them through the MVT functions to match the old behaviour we had with Mapnik (because of a bug). In this case the polygon becomes invalid after the simplification and the clipping process in Postgis ends up with a weird geometry. When we detect one of this geometries in Postgis we currently discard it as otherwise things look pretty awful.
Something similar happens in this map around Canada at zoom 2.
This pre/over-simplification is optional and was removed for CartoVL tiles in https://github.com/CartoDB/carto-vl/pull/1148, so this case is working fine in master but not in v1.0.
I also expect this kind of issue to be fixed retroactively in the near future as we are expecting to change the clipping library in Postgis to a more robust one (more tolerant to invalid geometries).
In short, and based on local tests:

Production Postgis + CartoVL 1.0: Broken [Your case]
Production Postgis + CartoVL master: OK
"Next" Postgis + Carto VL 1.0: OK
"Next" Postgis + CartoVL master: OK

thanks for the awesome explanation @Algunenano! glad to hear that it is already taken care of :)


Use Conan 1.64.0 in CI and docker

Follow up to https://github.com/CesiumGS/cesium-omniverse/pull/709

I switched to Conan 1.63.0 because 1.64.0 isn't available yet in choco


avoid panic: entry[pos..] => entry.get(pos..)

I may be wrong but:
We have:
        if line.is_empty() || pos < line.len() {
            return None;
        }

So pos == line.len() && pos > 0.
So I guess that the panic can happen only if history returns an entry that doesn't start with line.
Which seems fine to me.


Fix/1625 Poc automatically pick up scalapb-options.proto filles

This is a poc and i still need to add tests, (i need to have a look for that)
This scans all files for scalapb-options.proto and puts it on the generator path thus it picks up the package options from all dependencies and trasistivie projects.

https://github.com/thesamet/sbt-protoc/pull/286
Good news the maintainer of scalapb is open to the convention 'scalapb-options.proto' for package wide conventions.

I'm not sure if this is the right place but i found another issue with the scalapb module:
FileSystems.newFileSystem is not threadsafe so cannot be used in parallel builds.
we should use this instead:
  override def scalaPBUnpackProto: T[PathRef] = T {
    val cp = scalaPBProtoClasspath()
    val dest = T.dest
    cp.foreach { ref =>
      val jarFs = new ZipFile(ref.path.toIO.getCanonicalFile)
      try {
        jarFs.entries().asIterator().asScala.filter(_.getName.endsWith(".proto")).filterNot(_.isDirectory).foreach { entry =>
          val protoDest = dest.toNIO.resolve(entry.getName)
          Files.createDirectories(protoDest.getParent)
          Files.copy(
            jarFs.getInputStream(entry),
            protoDest,
            StandardCopyOption.REPLACE_EXISTING
          )
        }
      } finally jarFs.close()
    }
    PathRef(dest)
  }

I also couldn't make the scalapbModule work in combination with a mill.Cross because the sources aren't picked up.
val scalaVersions = Seq("2.12","2.13")
trait CommonModule extends ScalaPBModule {

  def scalaVersion = crossVersion match {
    case "2.12" => "2.12.15"
    case "2.13" => "2.13.7"
    case "3" => "3.1.0"
  }
  ...
}
object `common-protofiles` extends mill.Cross[`common-protofiles`](scalaVersions:_*)
class `common-protofiles-module` extends CommonModule

Closing due to inactivity and conflicts. Also, the feature might be implemented in the meantime. Have a look at:

#2126


Revamp UI

This PR completely revamps the crash reporter UI, and adds the ability for the user to provide details about the crash.
The main changes are:

Most elements have moved, most text has been reworded or removed
The crash log is now hidden behind a “Show Details” button
There is now a field for the user to describe how the crash happened

Thank you!

What happens when the button is clicked?
Did you explore the disclosure triangle option?

I modeled the UI after the built-in macOS crash reporter; so I went along with their "Show/Hide Details" button, and the way it reveals the details inline:

That's also where I moved the privacy policy button, which didn't fit in the button row anymore.
A disclosure arrow might make more sense, but might also look less familiar, and make the window feel more cluttered because of how it would stand out.

@Cykelero Alright, fine with me to keep the button that way then.
Does the window height setting fit small screens with zoom?
Asking because the xib shows a window height of 605 and a content view height of ~660. That should not be a problem, but some of my users send screenshots with UI scaling enabled because of poor eyesight, and only then do I notice how weird some parts can look. Windows with fixed or too large  min  height values can grow out of the screen bounds.
If the window would grow taller than fits a 13" MacBook at largest zoom factor, the "hide details" button could disappear out of the screen at the bottom, making it impossible to find the button to shrink the window again; it's also impossible to move the window higher up by grabbing the title bar to get to the buttons.
A more forgivingly auto-shrinking window should work without needing to rearrange buttons or add disclosure buttons.
P.S.: feel free to request a review anytime so I get a notification!

That's a good point, I hadn't thought of that!
I didn't find how to cap the window height to available screen space using Auto Layout (is that possible) so I shrunk it instead; it's now 545 pixels at most. It should fit nicely in the 2020 MacBook Air's 1024×640 scaled resolution.

That also works :)
I guess next it's time for me to replace Travis with GitHub Actions, and maybe check if the PHP script works with CI, too


UI | Improve Search/Explore page - allow complex searching and offer more suggestions

Is your feature request related to a problem? Please describe.
Users are reporting the search page is not good enough. The issues they run into are either:

a slight difference in names cause a resource not to be displayed at all
searching for a service/database/schema does not yield any relevant results (neither a link to the service/database/schema or tables/topic/etc. under it)
getting to a search only in a particular database/schema is still convoluted. Either navigate to it, start typing in search and click "Search in this database/schema" or try setting it the complex search.

Describe the solution you'd like
Some points I would like to tackle:

[ ] The "Complex Search" section should always be below the search in /explore. Users have a hard time spotting the dropdown and using it.
[ ] Users should be able to add multiple filters on the same resource (database/schema/service etc.). Filters for the same resource should be ORd together and ANDed with all other filters.
[ ] Users should be able to freely enter any text in the complex search, not be limited to options.
[ ] Users should receive suggestions for the complex search fields. These suggestions should be aware of the context - the value of other filters - so they offer relevant suggestions.
[ ] Text search should also by default search in a table's database, schema, and service.
[ ] Text search for tables should display as possible results Services, Databases, and Schemas along with the tables (in the main column). They should be clickable to go to the page of the resource or add that resource as a filter.

Another way of handling some of the issues here would be to add search bars on the left-hand side panel of /explore so users can search through resources.
Additional context
I would really appreciate feedback on these suggestions, maybe a design session to find the best way to tackle these issues.

Inspiration:
Jira's search is based on a relatively simple search syntax and offers a simple search (UI-based, easy to use, intuitive, lots of suggestions, etc.) and an advanced search that is a text box, allowing any queries.
Creating a fully custom search syntax would be a very big feature - we should investigate initial implementations.

Regarding the point

[ ] Users should be able to add multiple filters on the same resource (database/schema/service etc.). Filters for the same resource should be ORd together and ANDed with all other filters.

Forcing users into this AND and OR behavior is not a good idea. It makes sense for some use cases and not for others. This is mainly what sparked the Jira query language discussion - allowing users the flexibility to mix and match filters.

Yeah I will look into creating a POC this week

Update:
The design I've been working on is based on using https://www.npmjs.com/package/react-awesome-query-builder.
My idea is to add a UI-based complex query builder (see screenshots) which allows users to combine filters with logical operators to get to the data they are looking for.
The feature is quite big so I will be splitting it up into a number of PRs. For now, the structure should follow:

Extend the search API to support Elasticsearch filters as parameters and move off using EQL to filter results.
Add initial query builder
Update the advanced search field to work in tandem with the new feature

Update: we discussed on zoom and decided to split this feature up into 2 primary PRs:

Adding the improved search API and logical query builder, changes to explore page and facet filters
Refactoring existing search API calls to use the new interface and types

So https://github.com/open-metadata/OpenMetadata/pull/6965 will be closed and a new PR will be open

PR https://github.com/open-metadata/OpenMetadata/pull/8083 has been merged!

Open https://github.com/open-metadata/OpenMetadata/pull/8140 which has the main code fort the Logical Query Builder

Initial implementation of the query builder is merged, closing


Which is better: generate new ObjectIDs; or let the MongoDB driver do it

Maybe let the server make the ID for us? (MongoDB will make one for us automatically when _id is missing, and perhaps in a more cluster-safe manner?)
https://github.com/eshork/go-mongoid/blob/7ee076ee4f8476e6391e08c3a3536143fdd235b6/document_persistable.go#L79-L92

Is the missing ID really created by the server, or is the driver doing it?


7 Days ADS instance Failing Start after AMP Instance Manager v2.1 built 27/01/2021 17:05 update

Bug Report
System Information

Description:    Ubuntu 18.04.5 LTS
[Info] AMP Instance Manager v2.1 built 27/01/2021 17:05
Mainline release

I confirm:

[x ] that I have searched for an existing bug report for this issue.
[x ] that I am using the latest available version of AMP.
[x ] that my operating system is up-to-date.

Symptoms

What are you trying to do?
Start ADS instance for 7days that was working prior to recent update
What are you expecting to happen?
the instance start and then the game server to start
What is actually happening?
when starting via CLI, output states [Info] Instance started in new session. Run 'ampinstmgr View SevenDays01' to view this instances live output. then immediate view request says it is not running [Notice] SevenDays01 is not running.

Reproduction

I have not processed a clean install as i am unsure how to set the next instance to the same exact settings and retain the current map for my players.
CLI output:
~/.ampdata/instances/SevenDays01/AMP_Logs$ ampinstmgr -u SevenDays01
[Info] AMP Instance Manager v2.1 built 27/01/2021 17:05
[Info] Release spec: Release - built by CUBECODERS/buildbot on CCL-DEV
[Info] Upgrading instance SevenDays01
[Info] Using cached archive: /home/amp/.ampdata/instances/AMPCache-2100.zip
[Info] Upgrade successful
~/.ampdata/instances/SevenDays01/AMP_Logs$ ampinstmgr -s SevenDays01
[Info] AMP Instance Manager v2.1 built 27/01/2021 17:05
[Info] Release spec: Release - built by CUBECODERS/buildbot on CCL-DEV
[Info] Starting Instance: 'SevenDays01'
[Info] Waiting for AMP instance to start...
[Notice] AMP instance SevenDays01 is now running.
[Info] You can browse to this instance at http://<IP_ADDRESS>:8085/
[Info] Instance started in new session. Run 'ampinstmgr View SevenDays01' to view this instances live output.
~/.ampdata/instances/SevenDays01/AMP_Logs$ ampinstmgr View SevenDays01
[Info] AMP Instance Manager v2.1 built 27/01/2021 17:05
[Info] Release spec: Release - built by CUBECODERS/buildbot on CCL-DEV
[Notice] SevenDays01 is not running.
Latest Log:
~/.ampdata/instances/SevenDays01/AMP_Logs$ cat AMPLOG\ 2021-01-29\ 21-18-11.log
[21:18:12] [Core Warning]         : Current time zone is set to EST - Servers should ideally be UTC to avoid time-zone related issues
[21:18:12] [Core Info]            : OS: Linux / x86_64
[21:18:12] [Core Info]            : CPU: Intel(R) Xeon(R) CPU E5530 @ 2.40GHz (4C/8T)
[21:18:12] [Core Info]            : AMP Instance ID: ef51c403-e8fc-4889-ae12-af77db1e0cb6
[21:18:12] [ModuleLoader Error]   : Unable to load module SevenDaysModule: Object reference not set to an instance of an object
[21:18:12] [Core Error]           : NullReferenceException
[21:18:12] [Core Error]           : [0] (NullReferenceException) : Object reference not set to an instance of an object
[21:18:12] [Core Error]           :   at SevenDaysModule.SevenDaysApp..ctor (SevenDaysModule.ModuleMain module, ModuleShared.IRunningTasksManager tasks)
at SevenDaysModule.ModuleMain.Init (ModuleShared.IApplicationWrapper& Application, ModuleShared.WebMethodsBase& APIMethods)
at GSMyAdmin.ModuleLoader.LoadApplicationModule (String ModuleName)
[21:18:12] [Core Fatal]           : Failed to initialize application module.

Run ampinstmgr --nocache upgradeall

Can OP please confirm if this remains an issue?

I had tried that and it ended up not working. We decided to start over and killed the instance.


Control

Before anyone else start addressing issue #53, here is somethings I already did:

add tests for python 2.6, this should resolve issue #47
for python later than 2.7 change the menu layout to a tab layout, this is more intuitive
some renaming in ComponentsControl, but not enough
add script to run artview by just typing "artview"
fix quick save file, although I don't understand what is the purpose as we already have savefile
improve roi start (from the components menu) and add help button to roi

Have you tried creating a second status bar? Is this possible?
My thought is to stack 2 status bars at the bottom of each display. The upper status bar would be called something like infobar and could contain the filename, tilt, and field displayed.

I don't think QMainWindow predict two status-bar, but one could force it somehow. Visually I don't like the idea, I already think the actual plot is too small.

Plot being too small in terms of the Display size, area within the Display or the default limits?

the visual area, it is probably less than 50% of the display window

So I was just playing around with this.
After I began messing around with various tools, I am no longer able to get the displays to change to new files via arrow keys or through Opening new file.

the places to change would be here and if plot_type changes here, however the problem is that re-size is proportional and font size is not. So if you put margins too small they will look good in a big display and bad in a small one.

I wonder if we should leave this alone for now, I remember having issues with this when that first went into the program a ways back. I seem to recall also that the tick labels, etc. become an issue when messing with these values.

@gamaanderson I'm going to go ahead an merge this and then make a couple modifications. I'll let you know when I put those through.

Ok, I still have a lot to be done in grid. Unfortunately I depend on pyart modifications.

Okay, I think we can knock out a couple of small updates before that happens.

@gamaanderson @tjlang
I just committed some updates into a new push. Check out and let me know what you think. Nothing major here. Lots of housekeeping. But I did put an information text at the top:

Changes include:

Updated ROI help text.
Update up/down arrow key help.
Added an information field at the top of display.
Updated some plot_grid functions.
Minor change in quick_save.
Extensive spelling/grammar updates.

Thank you very much for taking this @nguy.
about the questions:

yes, set_limts can be removed, as this is being done in self._update_axes()
the 'get' methods, are being use out-side display, in roi.py and pick_value.py. I would like to keep them as they are and add more just if needed

Great, I can remove the set_limits on next go around. And keep the 'get' methods.

Oh and I think we discussed that ROI class can be removed from tools.py?

yes, it can

@nguy what a about a vertical colorbar, I will have to do it with the latitude/longitude slice to get a narrow display to work. I wounder if we could use it also in the radar display (screens now a days are normally longer in the horizontal axis)

I've played with that before, but never liked it. The aspect ratio of the RHI and Airborne plots makes the vertical bar very squat.
That said it's my personal preference there and I expect this request some time down the road.
Hold off on changes for just a bit. I've got a PR I'll put out in just a bit that addresses a couple of points of @tjlang and @pfhein. I also made a couple of tweaks to LongMessage and ROI.

no problem, I must do a pyart PR before updating grid


Allow read-write access to raw WindowEvents within Bevy apps

What problem does this solve or what need does it fill?
While working on an input capture and playback library, @plof27 pointed out that I may be able to capture raw events from winit directly, rather than dealing with the separated event streams.
Unfortunately, the necessary WindowEvent type is not exposed in winit_runner_with, our winit-based app runner.
What solution would you like?

Allow users to read the full list of raw window events sent.
Allow users to send raw window events from within systems, which are then processed by the winit loop.

These should be exposed as a simple Events<WindowEvent>; the complexity comes from ensuring that winit_runner_with responds appropriately.
What alternative(s) have you considered?
I've considered exposing this with a custom runner, however #4537 means this is a tedious and duplication-heavy task.

This is blocked on https://github.com/rust-windowing/winit/issues/1387, as WindowEvent has a mostly pointless lifetime that means we can't effectively store this data without some serious cludgery. Fix is proposed in ttps://github.com/rust-windowing/winit/pull/1456 / , but the PR is very dead.

This isn't quite blocked, the WindowEvent::to_static method exists, and thus WindowEvent<'static> can be used safely. However the problematic variant (scale factor changing) cannot be represented.

Just wanted to chime in and give a +1 to this issue. I recently went down the same rabbit hole of wanting to access raw events before the winit runner had the chance to convert them into bevy events and was unable to do so.
(in my case because I wanted to pass the raw events to egui-winit so that I could use egui without using the bevy renderer and a crate like bevy_egui, but that's beside the point)
I think the interface that would have been most ergonomic for me would be to have been able to pass in an "intercept" function that took in winit window events and done whatever processing I wanted with them and then returned a boolean indicating if that event should be propagated down to the winit-runner or not.

I would also like to +1 this, especially the read access. My use case is for a custom rendering backend that implements egui support transitively via egui_winit (egui_bevy is unfortunately tightly coupled with Bevy's default rendering backend).
So in general, Bevy could be even more modular by exposing winit events directly. I don't see any particular problem with this for the following reasons:

it's very easy to implement, just a few extra lines of code in bevy_winit (the lifetime events described earlier didn't come up for me, winit::event::WindowEvent can just be clone()-ed)
Of course it can be a footgun as most users should not look at these events, but they could be discouraged from using it by wrapping in some aptly named RawWinitEvent struct.


Rewrite for testing

Major rewrite to allow for better testing. It has the added benefit of much better code structure IMO.

It seems that there is a bug with the money command. After printing the report, it gets stuck. I have to use CTRL+C to exit.

I've started testing the assign command today and sometimes it returns this message.
unhandled rejection: { Error: connect ETIMEDOUT <IP_ADDRESS>:443
    at Object.exports._errnoException (util.js:1022:11)
    at exports._exceptionWithHostPort (util.js:1045:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1087:14)
  code: 'ETIMEDOUT',
  errno: 'ETIMEDOUT',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 443 }

I guess it is something related to not being able to connect to Udacity servers on Amazon (the IP belongs to Amazon).

After showing the message above, urcli assign does not update its status.

Thanks for fixing the above issue. I've used today through the whole day it worked flawlessly. I'll keep testing it tomorrow.
Now, something strange is happening with the money command.
Everytime I finished a review, I check the money command to see if everything is alright:
babel-node src money 3

It has never failed me, until now. It is not updating the last review. But, if I call it without argument, it is OK.

And now it is working again. Very strange.
More info on this. I submitted it near 23:30 UTC, and I checked it again after midnight UTC.

@gabraganca I've noticed that two reviews that were submitted close together might have the exact same completed_at time. The conclusion I draw from that is that Udacity does some kind of verification before the review is "accepted". That might sometimes cause submitted reviews to lag behind once in a while.
Since you tested well and found out that the default period works fine, I've changed it so that the current month checks an hour into the future too: moment.utc().add(1, 'h'). I don't know why this is necessary, but it's clearly something on the Udacity side of things, so we'll just have to live with the hack.

Thanks, Mikkel.  I forgot to mention that this only happened if I used the command cited.  When I used with no arguments and the version available on npm it worked fine.

The issue I commented above is happening again, but now with the today command. Very strange bug, but a minor one. I have some ideas on how to track it. :bulb:


Add callbacks option to PathSampling

I have thought (a long) while about how to best implement the on the fly shooting range optimization and I think I finally came to a result that may be worth your time :)
The idea is to add an optional callbacks argument to the PathSampling, which is expected to be a list of PathSamplingCallback (callable objects with an interval attribute), which would then be called by the PathSampling, with the PathSampling as argument, every interval steps. This way one can call custom code every interval PathSampling steps. This enables advanced users to write their own code to select shooting points based on the information from all previous shooting attempts and thereby iteratively improving the efficiency of their simulation.
I already went ahead and wrote a preliminary implementation which defines a PathSamplingCallback abstract baseclass and added the necessary code to the PathSampling at https://github.com/hejung/openpathsampling/tree/pathsamp_callback.
See also the rewritten ShootingRangeOptimizer initially developed at Leiden and now using the callbacks option to be more flexible and lightweight at the same time (https://gitlab.e-cam2020.eu:10443/hejung/sr_shooter/tree/refactor_callback).
Please let me know if this is something that could be accepted into OPS sometime in the future.

What you're proposing here is very similar to something that's already in development. I was using the term "hook" to describe it, thinking of several places in during the process of a simulation step that you might want to add behavior. In addition to use cases like yours, the same approach could be used for things like on-the-fly analysis, or to make some output optional (for example, step number becomes less meaningful when running in parallel). In fact, even storing to a file can be thought of as a "hook" that we add, which can be re-used between different types of simulations. (As you said, this whole approach makes the code both more flexible and more lightweight.)
In other words, I think it is a good idea, and I already started working on it!
The first draft of that is in #755. I think the best approach would be for you to look over that, and see if the structure of hooks implemented there will give you enough flexibility for the ShootingRangeOptimizer -- if not, let me know how to improve it!
In particular, you'll want to look at:

hooks.py
shoot_snapshots.py, especially the .run method
path_simulator.py, methods related to hooks

(Note also that this is all after the refactor of path simulators into multiple files; #754. I would suggest that any work on simulator objects should be based after that change.)
Current status: So far, I've added hooks for "shoot-from-snapshot" (i.e., committor and related) simulations. That's still being tested, and will be followed by some work parallelizing the committor simulation (handling these hooks while parallelizing takes some careful attention). That work is not yet in a PR, but you can see it in the dask_committor branch of my fork, which is still extremely experimental (the file task_schedulers.py is the main one to look at; we're planning to use dask.distributed to handle the parallelization; I would recommend YouTube videos of talks about dask by Matt Rocklin and/or Jim Crist as a great way to get introduced to how dask works).
I haven't added support for hooks to PathSampling objects, but that is coming (if you want to work on it, feel free, just add lots of tests along the way, and make sure that the default behavior is exactly like it used to be. This change will be part of the 1.x series.)
I don't know enough about the shooting range optimization algorithm to know whether the trajectories you launch can be run in parallel or not; if so, you'll need to pay attention to ensuring the task graph has the right dependencies. (That's the tricky part with this parallelization approach.)
But overall, yes, an approach similar to this is exactly what I was planning for the near future.

Great to hear that!
From a first glimpse it looks like the hooks can do everything I need (and probably more).
I will start working on adding them to the PathSampling and see how it goes.
Should I close this Issue and ask everything else that comes up in #755?

Closing this now, the hooks for PathSampling are in the main branch and also in v1.5. @dwhswenson Feel free to let me know/reopen if you think we should not close it yet.


Trouble trying to deploy grid on node 921

Issue
I try to deploy following the readme.md of docker-compose and can't access the website.

# deploy VM (node 921) on tfgrid with ipv4, ipv6, 32GB RAM, 750GB SSD, 32 vcores
# set A record for IPV4 and AAAA record for IPV6 for threefold.pro (Host: @)
# verify DNS records point to threefold.pro

# set the VM

git clone https://github.com/threefoldtech/grid_deployment
cd grid_deployment/docker-compose/mainnet
echo .subkey_mainnet >> .gitignore
../subkey generate-node-key > .subkey_mainnet

cp .secrets.env-example .secrets.env
cp Caddyfile-example Caddyfile

# adjust .secrets.env file with domain, node key (in .subkey_mainnet) and tfchain mnemonics
nano .secrets.env

# launch the script
sh install_grid_bknd.sh

Screenshots

Situation
When we run
install_grid_bknd.sh
and say yes to run the prescript
prep-env-prereq.sh
when we reach the section of the script
    systemctl daemon-reload
    systemctl enable node-exporter
    systemctl start node-exporter
    systemctl status node-exporter

to get out of this we need to do ctrl-c, but then it just stops the script.
Solution?

could just write in the docs that to work with this, you run the install script once and say yes to prep script, then get the systemd status confirmation, do ctrl-c to exit, then rerun the install script and say no to run prep script.

Potential solution in #33.
can be some other fix too.

Following the readme.md now all works. Closing.


Temporary Features not labelled

When a users successfully accepts a changefeed item the UI creates a temporary published feature item based on the API response. There is no full address number label in this response.
Currently the layer employs the Qgis Label Builder to compile a full number label from individual components. However this is failing when Qvariants Null Values are mapped to the layer.
There are several options to solve this and when I pick up this issue I will asses these then:

Resolve Qvariant Null matching in label expression
Remove map temp features Qvaraints to None or other

This problem is not label as high priority as it only affects temp features and when the Data Manager supplies a refresh to the feature layer the feature is labelled

Please retest in 0.8.13

Tested 0.8.16 Passed.


Set autocomplete=false when search button is pressed in address and business name tabs

set autocomplete=true only while user types into input text box.

Good idea. Lets you still access scoring etc. when appropriate.

Autocomplete is only set to true for the auto-completion requests, the search requests do not set autocomplete (it defaults to false).

Done and in Delivery now.

Verified


How to implement filter bar?

How to implement filter bar?

What do you mean by filter bar?

like this:

Dup of #1064. That's swagger-ui 3.x


Escaped slashes unescaped by Gatekeeper proxy

What:
Hello all,
The Gatekeeper proxy unescapes slashes in the URL path.
h3. The problem
A request like:
http://<IP_ADDRESS>:8080/iiif/2/edepot_local:ST%2F00001%2FST00005_00001.jpg/full/1000,/0/default.png
is passed to the upstream as:
http://<IP_ADDRESS>:8080/iiif/2/edepot_local:ST/00001/ST00005_00001.jpg/full/1000,/0/default.png
Note that "%2F" is transformed to "/".
I expect a reverse proxy to not modify the URL to this extend. But the encoded slashes are unencoded at two different points by Gatekeeper now.
If not authenticated the path that is restored after login transforms the escaped slashes.
The proxy code itself transforms escaped slashes to slashes.
h3. Solution
Decoding escaped parts by the proxy seems like a problem to me. I suggest the proxy passes along the URL as is. Possibly by setting a configuration.
I'm not very familiar with GO, but I might be able to open a PR with a possible solution.
Reference:

KEYCLOAK-11276 - Escaped slashes unescaped by Gatekeeper proxy

Fixed in #535

Solved in https://github.com/louketo/louketo-proxy/pull/626. Thanks to @Nuru


 E.g. S3 Bucket

Just need to resolve merge conflicts https://github.com/MinaProtocol/mina/pull/13236. However, this solution will only allow us to get blocks in the transition frontier.

@Isaac-DeFrain My interpretation of this issue is that it is about the hosting of a precomputed blocks bucket. I'll take it.

https://granola-mina-blocks.se-sto-1.linodeobjects.com is now where we host our (corrected) block files. Also, we do not use gsutil to download blocks in our regression suite.
A final step is to create a Mina node that uploads blocks to the bucket in an automated fashion.

Related to https://github.com/Granola-Team/mina-indexer/issues/609


Add reth dump-stage  command

Closes #1183
Example usage. Extract and make a dry-run
reth dump-stage --db ../db execution --from 49794 --to 49796 --output-db newdatabase --dry-run

reth stage --db newdatabase --from 49794 --to 49796 execution

Codecov Report

Merging #1265 (4816df2) into main (e833c86) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   76.66%   76.10%   -0.57%
==========================================
  Files         340      343       +3
  Lines       37830    38532     +702
==========================================
+ Hits        29004    29325     +321
- Misses       8826     9207     +381

Flag
Coverage Δ

unit-tests
76.10% <0.00%> (-0.57%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/cli.rs
0.00% <0.00%> (ø)

bin/reth/src/db/mod.rs
0.00% <0.00%> (ø)

bin/reth/src/dump_stage/mod.rs
0.00% <0.00%> (ø)

bin/reth/src/lib.rs
38.88% <ø> (+31.74%)
:arrow_up:

crates/stages/src/db.rs
84.96% <0.00%> (-4.02%)
:arrow_down:

crates/storage/db/src/abstraction/mock.rs
0.00% <0.00%> (ø)

crates/storage/db/src/implementation/mdbx/tx.rs
91.02% <0.00%> (-3.65%)
:arrow_down:

crates/storage/db/src/tables/models/blocks.rs
84.52% <0.00%> (-3.14%)
:arrow_down:

crates/staged-sync/src/utils/chainspec.rs
23.52% <0.00%> (-26.48%)
:arrow_down:

crates/staged-sync/src/config.rs
57.60% <0.00%> (-11.23%)
:arrow_down:

... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix email rendering bug

TAG_REVIEWER will you please review this?
This PR fixed email link rendering bug by adding additional email regular expressions to the current rules.
Fixed Issues
https://github.com/Expensify/Expensify.cash/issues/990
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

@roryabraham   This is a new PR that has one signed commit.  Please check it out.

@roryabraham   This is a new PR that has one signed commit.  Please check it out.

@roryabraham   This is a new PR that has one signed commit.  Please check it out.

@roryabraham   This is a new PR that has one signed commit.  Please check it out.

@nicodev-git I see you've commented on the commit with the CLA agreement. You should only ever have to fill out the CLA agreement once, so that's not what we're referring to by "signing commits". For more information, see this guide. Please try to retroactively sign this one commit using the command:
git commit --amend --signoff

Then force-push your changes

@nicodev-git I see you've commented on the commit with the CLA agreement. You should only ever have to fill out the CLA agreement once, so that's not what we're referring to by "signing commits". For more information, see this guide. Please try to retroactively sign this one commit using the command:
git commit --amend --signoff

Then force-push your changes


file:remove fails without giving a proper reason in 1.2.13.

Description:
Using file:remove doesn't give a proper reason as to why a file doesn't get deleted. It only gives something like this:
error {ballerina/file}FileSystemError message=Error while deleting /mnt/ballerina-repository/artifacts/ballerina/websub/1.2.0-beta.1/ballerina-websub-java11-1.2.0-beta.1.bala

Steps to reproduce:
Affected Versions:
1.2.13
OS, DB, other environment details and versions:
Alpine - Docker

@hemikak Don't close this issue. we need to do the same fix in SL branch

@daneshk Can't we create an issue in ballerina-standard-library for that?


Make sure we don't clean up an active handle during a next download.

Fixes https://github.com/JuliaLang/Downloads.jl/issues/99

Codecov Report

Merging #101 (b8d1ea0) into master (af6864d) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   92.96%   92.43%   -0.53%
==========================================
  Files           5        5
  Lines         483      423      -60
==========================================
- Hits          449      391      -58
+ Misses         34       32       -2

Impacted Files
Coverage Δ

src/Curl/Multi.jl
94.59% <100.00%> (-1.17%)
:arrow_down:

src/Downloads.jl
83.75% <0.00%> (-0.63%)
:arrow_down:

src/Curl/utils.jl
96.87% <0.00%> (-0.63%)
:arrow_down:

src/Curl/Easy.jl
93.81% <0.00%> (-0.31%)
:arrow_down:

src/Curl/Curl.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6864d...b8d1ea0. Read the comment docs.

Is any of the tests in #99 reproducible in CI?

Yes, I've added the MWE as a test.

Does it also fix #95 or are they completely separate issues? Have you tried enabling HTTP/2 wich this patch?

Does it also fix #95 or are they completely separate issues? Have you tried enabling HTTP/2 wich this patch?

That seems very possible, but I couldn't reproduce with HTTP 2.0 re-enabled (and this patch either disabled or enabled). Could you try on your system?


fallbackToRawString issue

not fully understand why when fallbackToRawString == true
you still throw errors https://github.com/mercari/hcledit/pull/107
then how do we read rawtring properly, we are currently handler error from the caller

@piggybankwang sorry for the late reply.
We return still return the error because it signals that fallback has actually occurred and the caller should treat it as a raw value. hcledit provides the RawVal as a way to distinguish between raw value vs. a normal cty value (normal meaning that the actual value can be read without fallback).
If you know for sure that the value you are reading needs to fallback to the raw string, you can ignore the error. If you are unsure if the value you are reading needs to fallback, you can check if the error is nil and determine if you need to handle it as a raw string or now.


Add event source for Amazon S3

Closes #162
Implementation that receives event notifications from a S3 bucket over a SQS queue.
If the user doesn't provide a queueARN in the spec, a SQS queue is created and configured with an IAM policy which accepts messages from the S3 bucket only.
As for other AWS sources, the required permissions will be documented at docs.triggermesh.io

As a quick demo, here are the events recorded during the creation and deletion of a AWSS3Source:
  Type    Reason           Age      From                    Message
  ----    ------           ----     ----                    -------
  Normal  FinalizerUpdate  81s      awss3source-controller  Updated "sample" finalizers
  Normal  QueueCreated     79s      awss3source-controller  Created SQS queue "https://sqs.us-west-2.amazonaws.com/123456789012/s3-events_triggermeshtest"
  Normal  CreateAdapter    79s      awss3source-controller  Created adapter Deployment "awss3source-sample"
  Normal  Subscribed       76s      awss3source-controller  Configured event notifications for S3 bucket "arn:aws:s3:us-west-2:123456789012:triggermeshtest"
  ...
  Normal  QueueDeleted     94s      awss3source-controller  Deleted SQS queue "https://sqs.us-west-2.amazonaws.com/123456789012/s3-events_triggermeshtest"
  Normal  Unsubscribed     92s      awss3source-controller  Disabled event notifications for S3 bucket "arn:aws:s3:us-west-2:123456789012:triggermeshtest"
  Normal  FinalizerUpdate  92s      awss3source-controller  Updated "sample" finalizers

And some sample event:
☁  cloudevents.Event
Validation: valid
Context Attributes,
  specversion: 1.0
  type: com.amazon.s3.objectremoved
  source: arn:aws:s3:::triggermeshtest
  subject: kn_logo.png
  id: 6b981dc2-6283-4eed-b311-f20eeba45b08
  time: 2021-03-28T03:12:53.6377179Z
  datacontenttype: application/json
Data,
  {
    "awsRegion": "us-west-2",
    "eventName": "ObjectRemoved:DeleteMarkerCreated",
    "eventSource": "aws:s3",
    "eventTime": "2021-03-28T03:12:50.735Z",
    "eventVersion": "2.1",
    "requestParameters": {
      "sourceIPAddress": "x.x.x.x"
    },
    "responseElements": {
      "x-amz-id-2": "Vorf7/UhNcWjFPbeqi/9BH4BGcCMvNAORXEBw3jSSE7WjIdQtyWXpOrg/F5uCQbpDWd5heZ5N9CAnXw6GMkYjtTyTbhfo1cw",
      "x-amz-request-id": "6GZFJ0JCCNMH694S"
    },
    "s3": {
      "bucket": {
        "arn": "arn:aws:s3:::triggermeshtest",
        "name": "triggermeshtest",
        "ownerIdentity": {
          "principalId": "A2MWJ7PRW7U41K"
        }
      },
      "configurationId": "io.triggermesh.awss3sources.default.sample",
      "object": {
        "eTag": "d41d8cd98f00b204e9800998ecf8427e",
        "key": "kn_logo.png",
        "sequencer": "00605FF432C0DA785E"
      },
      "s3SchemaVersion": "1.0"
    },
    "userIdentity": {
      "principalId": "AWS:AIDAQUHRFMYWSR2PNVTVZ"
    }
  }

@antoineco just noticing that this PR did not add the AWSS3SOURCE_IMAGE env variable in the controller.yaml
https://github.com/triggermesh/aws-event-sources/blob/main/config/500-controller.yaml#L58-L77


Publish latest changes to crates.io

Hi, I created a tool last year depending on the version of transitfeed in the repo and I was hopping that it'd get published at some point so I could publish my project on crates.io but that hasn't been the case yet. Do you thing it'd be possible to publish a new release with the changes?
This is my project that depend on transitfeed: https://github.com/vinc/timetable
Thanks!

Of course, will try to get this out on crates today

Done, 0.3.0 is out there


Allow importing multiple files for annotation

NER Annotator works with only one text file at a time. But any serious project will have multiple files for annotations. It would be useful either

allow loading multiple files at the same time or
provide a way to load the next file at the completion of one file

This was all the tags can be exported as a single JSON.
Note
Since the tech is browser based - memory considerations have to be kept in mind

#72 added the option to load the next file, but I can't think of a way to export the annotations of multiple files as a single JSON. Regardless of how we solve it, the data from all of the files would have to be on memory at some point of time, at least so we can combine them.
If we disregard the memory requirements, the simple solution is to store the data from older files. Local storage seems to have a limit of 5MB. Session storage has no limit but data can't be stored across sessions.
If none of these are feasible then I think users will have to use something like the Python script given in #81. But that is bound to lead to repetitive inquiries about this feature.
@tecoholic Opinions on this?

@alvi-khan As you have explained, I see no solution for this feature to be implemented smoothly for both web and desktop the same way.
For desktop, we could leverage Rust part of the Tauri app and write some temporary files (say a project file) and read them back on next start, thus making it available across sessions. But this requires working with Rust a bit.
For web, this SO question seems to suggest that IndexedDB instead of Local or Session Storage seems to be a better option for large amount of data. Maybe we can implement IndexedDB based solution and it might end up working for both wen and desktop?

IndexedDB seems like a viable solution. Will look into this.


Bug: Long running services fail to fetch when session token expires

We have a long running service being hosted in ECS.  After the session token expires, data protection fails to fetch the encryption keys.
It looks like things are getting registered as singletons and my hunch is that this will not get the latest environment variables after the token has expired.

Further digging I've noticed that it should be getting the latest credentials... so maybe ECS isn't refreshing the tokens?
https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Credentials/_bcl%2Bnetstandard/EnvironmentVariablesAWSCredentials.cs#L66

Hi @StummeJ,
You are correct. Temporary credentials have an expiration interval. When credentials expire, any calls made with those credentials will fail. So, application must then request new set of credentials. Please refer the link Using temporary credentials with AWS resources for more details.
Please let me know if this answers the question and if this issue could be closed.
Thanks,
Ashish

Yup, we found a different provider.  I think it would be good to add documentation around running on ecs.

@StummeJ Thanks. I will close this issue. The link How Amazon Elastic Container Service Works with IAM specifies ECS support of using  temporary credentials. It's a general guideline to refresh temporary credentials when they expire.


React Aria: External  incorrectly uses client side routing with React Router

Provide a general summary of the issue here
I am using React Aria with React Router and the Link component behaves not as expected. External links are opened in a new tab prefixed by the URL from React Router. Any help with this issue would be greatly appreciated.
<Link href="https://cds.climate.copernicus.eu/#!/home" target="_blank">
    Copernicus Climate Data Store
</Link>

This Link should open in a new tab and circumvent React Router as is stated here:

Note that external links to different origins will not trigger client side routing, and will use native browser navigation. Additionally, if the link has a target other than "_self", uses the download attribute, or the user presses modifier keys such as Command or Alt to change the default behavior, browser native navigation will occur instead of client side routing.

🤔 Expected Behavior?
Should open a new tab with https://cds.climate.copernicus.eu/#!/home
😯 Current Behavior
Opens a new tab with http://<IP_ADDRESS>:5173/baseurl/https:/cds.climate.copernicus.eu/#!/home
💁 Possible Solution
No response
🔦 Context
Vite
React
react-router-dom
main.jsx
import { StrictMode } from "react";
import { createRoot } from "react-dom/client";
import { BrowserRouter } from "react-router-dom";

import App from "./App";

const root = createRoot(document.getElementById("root"));
root.render(
  <StrictMode>
    <BrowserRouter basename={import.meta.env.BASE_URL}>
      <App />
    </BrowserRouter>
  </StrictMode>
);

App.jsx
import { RouterProvider } from "react-aria-components";
import { Route, Routes, useHref, useNavigate } from "react-router-dom";

import Navbar from "./components/Navbar";
import HomeRoute from "./components/HomeRoute";
import MapRoute from "./components/DifferentRoute";

function App() {
  let navigate = useNavigate();

  return (
    <RouterProvider navigate={navigate} useHref={useHref}>
          <div className="App">
            <Navbar />
            <Routes>
              <Route path="/" element={<HomeRoute />} />
              <Route path="/map" element={<DifferentRoute />} />
            </Routes>
          </div>
    </RouterProvider>
  );
}

export default App;

🖥 Steps to Reproduce
I'm not sure if I can reproduce the behavior with the listed sandboxes, but I included relevant files with a minimal example above.
Version
"react-aria-components": "^1.2.1",
What browsers are you seeing the problem on?
Firefox, Chrome
If other, please specify.
No response
What operating system are you using?
Windows Subsystem for Linux (Debian)
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

I managed to declare the router context twice and just noticed after creating this report 😅 I'm a little bit surprised that it almost functioned as normal


v2/README: add known bugs

For https://github.com/coreos/etcd/issues/518.

/cc @xiang90

LGTM. This also needs to be back-ported to 2.3 release.

Will backport it in the next patch release. Thanks.


ProtoType Go To Implementation For TypeScript

For #10806
Initial prototype of using the TypeScript Go To Implementation Feature. Adds a go to implementation command for js and ts documents.
This has a few issues at the moment:

We likely would want to expose go to implementation for other languages. Therefore, it would make sense to standardize an api for this based on the existing DefinitionProvider api.
The location values that typescript returns are not correct some of the time. I'll double check that this is not a bug on our side, but the feature needs some more testing and polish before we can ship it.

Yeah, I agree that we should have an API for this that integrates it properly into the editor, similar to how the goto definition works

Closing in favor of #18346


[stable/zookeeper] Update api versions to support k8s 1.16

Signed-off-by: Anton Gorkovenko<EMAIL_ADDRESS>Is this a new chart
no
What this PR does / why we need it:
Update api versions to support k8s 1.16
Which issue this PR fixes
no
Special notes for your reviewer:
no
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @lachie83

@antongorkovenko
Need to resolve conflict on incubator/zookeeper/Chart.yaml

@zanhsieh resolved

/ok-to-test

/approve
/lgtm

Thanks