Clarify instruction for building with vcpkg

Mention VCPKGRS_DYNAMIC=1 environment variable,
and the fact that you need to run cargo clean in order to force rebuild.

Would you mind testing the following change:
Add this line:
if cfg!(all(feature = "vcpkg", target_env = "msvc")) {
    println!("cargo:rerun-if-env-changed= VCPKGRS_DYNAMIC");
}

here: https://github.com/jgallagher/rusqlite/blob/master/libsqlite3-sys/build.rs#L133
Add then check that you don't need to clean anymore.

@gwenn
I can readily test it on windows. How can tell cargo to use local git instead of upstream crates source?

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#testing-a-bugfix

Awesome, every time I am gladly surprised how rust developers though through all scenarios in advance.
I would check it!

@gwenn
Your fix works. Pull request updated, thanks!

Thanks.


provide screenshot/video recording of the e2e run on failure

on failure, we should provide either of these, there is screenshot functionality in the tester and this should be easy to implement

closed by #75


Update node_helper.js

More Accurate CPU usage , reflecting what Task manager show.
Calculation is based on 100-  Idle CPU % using top command.

recreating one without conflict


Minor profiler refactor to avoid string construction

std string concatenation allocates. Check if profiler enabled then call EndTimeAndRecordEvent to avoid string construction and allocation.
@pranavsharma
@tracysh

/AzurePipelines run all

Looks like some of the tests failed. Can you rebase?

I would like to close this PR as it has been inactive for a while and similar change was merged.


missing dependant sourcekite tool, please configure correct "swift.path.sourcekite"

I have the same issue as #7 but mine doesn't seem to be resolved using the same steps.
I've installed the extension.
I've built sourckite which is located at /Users/user/xcode/sourcekite
I've added "swift.path.sourcekite": "/Users/user/xcode/dev/sourcekite/.build/debug/sourcekite" to my settings.json in VSCode
I've reloaded / disabled/re-enabled / restarted VSCode
And I get the above error along with:
Error: spawn /Users/user/xcode/dev/sourcekite/.build/debug/sourcekite ENOENT     at _errnoException (util.js:1024:11)     at Process.__dirname.ChildProcess._handle.onexit (internal/child_process.js:190:19)     at onErrorNT (internal/child_process.js:372:16)     at _combinedTickCallback (internal/process/next_tick.js:138:11)     at process._tickCallback (internal/process/next_tick.js:180:9)
and:
The Swift server crashed 5 times in the last 3 minutes. The server will not be restarted.
Any ideas?

Thanks for trying this out!

I've built sourckite which is located at /Users/user/xcode/sourcekite
I've added "swift.path.sourcekite": "/Users/user/xcode/dev/sourcekite/.build/debug/sourcekite" to my settings.json in VSCode

It seems like you placed sourcekite directly into your xcode-folder instead of xcode/dev as you configured within your settings. Or did this error happen when anonymizing the path?

Ugh. No you're right. I mangled the path. This should teach me to work on this kind of thing late at night.
I'm now having trouble getting code completion working, but I'm still investigating that one. Will open another issue if necessary!

No problem! This happens to everyone.
You are always welcome to open an issue, even for questions!
Are you working on an Xcode project? In that case you would need to manually provide autocompletion options (see here). If it is a SwiftPM project, it should usually work out of the box.


Notifications and custom commands are not waiting until complete before moving on to next sequence

Describe the bug
Whenever I call either the notify.alexa_media service or send a custom command to Alexa using this app within a script of automation, HA doesn't wait until Alexa has completed the notification / custom command before it moves on to the next sequence in the script
To Reproduce
Steps to reproduce the behavior:

Create a script
Call the notify.alexa_media service with a long message
Call the media_player.volume_set service for the same Alexa device as step 2
Run the script
Volume will change before the message has been announced

Expected behavior
When step 2 occurs, the script should wait for Alexa to complete its announcement before moving on to step 3
System details

Home-assistant (version): 2022.7.5
Hassio (Yes/No): Yes
alexa_media  (version from const.py or HA startup): 4.0.3
alexapy (version from pip show alexapy or HA startup): 1.26.1
Amazon [2FA is enabled]: yes

This is how Alexa works. There is no way to tell when a command is finished. If you want this behavior, you'll need to use Alexa's built in routines unfortunately.

This is how Alexa works. There is no way to tell when a command is finished. If you want this behavior, you'll need to use Alexa's built in routines unfortunately.

 I follow this because I have an investment in Amazon devices but have pretty much given up on using them even without HA.
However, once a few things are finished up, I would like to see if I could help by testing scenarios etc.
I am sorry I am not sure the best way to contact a developer and especially one that was put in a position to defend themselves. Heck GitHub is new and I am probably type and it will say I am not logged in or something. So many new things to learn in HA.
Let me know if you would like some dialogue and how does one do that in these circles. I thought Discord was for gamers but now I am on that too. All part of the journey!
Well great work alandtse!

Just in case anyone else comes across this issue, I've done a bit of additional testing and alandtse's amazing integration has nothing to do with the issue at all.  Its an Amazon-side issue.
It's actually quite specific to the "read today's calendar" and "read tomorrows calendar" commands, and it's actually something that seems to happen specifically on Echo Show 8 and Echo Show 10 devices (at least).
The same issue happens inside the Alexa app if you create a routine for these commands and manually trigger the routine on either of the devices I mentioned.  All other commands are fine, just these two commands..  Its like these two commands when triggered on these two devices specifically don't seem to wait for the command to finish before moving to the next command that is in some sort of "command queue" or whatever its called.


Not update the last login attempt, the same still the same everytime

Not update the last login attempt, the same still the same everytime
I'm on version 3.0.3
And about Daily Login button, I didnt understand how works and what I need to setup.

same here, you login , time and date not changing after closing the game. if you restart launchbuddy it is updated. bit of a problem when you launch 25 accounts in packs of 4


When searching, sometimes only one result is displayed

Description
When searching a folder using the search box, often only one file will be displayed even if multiple files match the search text. Pressing back and then forward will display the remaining files. So far I've only been able to repro this with folders with large numbers (hundreds) of image files, but I'm not 100% sure it isn't a problem in other circumstances.
Steps To Reproduce

Open a folder with a few hundred image files.
Type some text into the search box that you know matches the names of some of the image files. Press enter to search.
Very briefly (fraction of a second), all of the matching files will be displayed, but then all but one will disappear.
Press back and then forward.
All of the matching files will now be displayed.

Expected behavior
All of the matching files should be displayed without having to press back and then forward.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.318
Windows Version
Edition	Windows 11 Home Version	21H2 Installed on	10/3/2021 OS build	22000.318 Experience	Windows Feature Experience Pack 1000.22000.318.0
Relevant Assets
No response

Thanks for the report. This is fixed in latest code. In the meantime you can refresh the folder (F5) to make the results appear.


WIP: reproduce slow claiming of pidfile in test_pageserver_max_throughput_getpage_at_latest_lsn

refs https://github.com/neondatabase/neon/issues/6473
original case in: https://neondb.slack.com/archives/C06750CD9U5/p1706190798216269
2024-01-25T13:23:25.396882Z  INFO Got SIGQUIT. Terminating in immediate shutdown mode
2024-01-25T13:25:05.948114Z  INFO version: git-env:c9b1657e4ca88f494c0272c8ee259758dadc2953 failpoints: true, features: ["testing"] launch_timestamp: 2024-01-25 13:25:05.897222508 UTC build_tag: build_tag-env:4437
2024-01-25T13:25:21.016900Z  INFO Claimed pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-13-30]/repo/pageserver_1/pageserver.pid"

Looking at the allure report when we start the pageserver after doing all the "python-side on-demand downloads":
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-6483/7659943203/index.html#suites/e26265675583c610f99af77084ae58f1/5eeead04d2794904/
# test_pageserver_max_throughput_getpage_at_latest_lsn[100-6-30]

2024-01-25T21:10:51.196377Z  INFO Got SIGQUIT. Terminating in immediate shutdown mode
2024-01-25T21:12:03.817412Z  INFO version: git-env:a7f8032d28e0b5baea476d13d04294dafe2b7b3a failpoints: true, features: ["testing"] launch_timestamp: 2024-01-25 21:12:03.793218677 UTC build_tag: build_tag-env:7659943203
2024-01-25T21:12:03.817511Z  INFO Claiming pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-6-30]/repo/pageserver_1/pageserver.pid"
2024-01-25T21:12:09.100398Z  INFO Claimed pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-6-30]/repo/pageserver_1/pageserver.pid"

# test_pageserver_max_throughput_getpage_at_latest_lsn[100-13-30]
2024-01-25T21:23:14.276340Z  INFO version: git-env:a7f8032d28e0b5baea476d13d04294dafe2b7b3a failpoints: true, features: ["testing"] launch_timestamp: 2024-01-25 21:23:14.250642233 UTC build_tag: build_tag-env:7659943203
2024-01-25T21:23:14.276863Z  INFO Claiming pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-13-30]/repo/pageserver_1/pageserver.pid"
2024-01-25T21:23:18.467478Z  INFO Claimed pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-13-30]/repo/pageserver_1/pageserver.pid"

So indeed, the claiming of the pidfile seems to be taking long.
It does an fsync inbetween, I suspsect that's the issue here because we create a lot of dirty data with the python-side on-demand downloads.
Will add more logging to prove that hypothesis.

Yay, an actual test failure, like the original one \o/
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-6483/7667141556/index.html#suites/e26265675583c610f99af77084ae58f1/2b88e5f4878e4e9a/
2024-01-26T11:53:17.157665Z  INFO Got SIGQUIT. Terminating in immediate shutdown mode
2024-01-26T11:54:51.104993Z  INFO version: git-env:6aefbb1aa5ff089c42b29b66bc5570880f723921 failpoints: true, features: ["testing"] launch_timestamp: 2024-01-26 11:54:51.076075163 UTC build_tag: build_tag-env:7667141556
2024-01-26T11:54:51.105388Z  INFO Claiming pid file at "/tmp/test_output/test_pageserver_max_throughput_getpage_at_latest_lsn[100-13-30]/repo/pageserver_1/pageserver.pid"
2024-01-26T11:54:51.105496Z  INFO claim_for_current_process: create_exclusive
2024-01-26T11:54:51.105515Z  INFO claim_for_current_process: write_content
2024-01-26T11:54:51.105518Z  INFO claim_for_current_process:write_content: truncate
2024-01-26T11:54:51.105537Z  INFO claim_for_current_process:write_content: write_all
2024-01-26T11:54:51.105541Z  INFO claim_for_current_process:write_content: fsync file and parent
2024-01-26T11:54:51.105544Z  INFO claim_for_current_process:write_content:fsync_file_and_parent_log: fsync file
2024-01-26T11:54:58.104918Z  INFO claim_for_current_process:write_content:fsync_file_and_parent_log: fsync parent
<gets SIGKILLed by neon_local>

So, even just the fsync of the file takes 7 seconds.


Singularity build failing

using commit e0cfa8802e87eea05d5ead5a7b4a2f827c239bf6. Tail of terminal output from singularity build is:
+ mypy --python-version 3.10 viridian_workflow
viridian_workflow/self_qc.py:339: error: Need type annotation for "summary" (hint: "summary: Dict[<type>, <type>] = ...")
viridian_workflow/self_qc.py:470: error: Incompatible return value type (got "Tuple[str, Dict[str, Any], Dict[str, Any]]", expected "Tuple[str, Dict[str, Any], defaultdict[str, Any]]")
Found 2 errors in 1 file (checked 20 source files)
FATAL:   While performing build: while running engine: exit status 1

My master branch can be unstable, this won't effect the iqbal-lab-org repo.
Type checking can be disabled when building images, though when testing from development branches I recommend running a stable singularity image with the PYTHONPATH set to the checked out branch.

To clarify that cryptic (spot the dad joke/reference) comment - i've asked @jeff-k to merge back into the refactor_2020 branch of the iqbal-lab-org repo.
@jeff-k - if we want a container which works and contains cuckoo mode working, what exactly are you recommending? waiting til you merge? This comment
"Type checking can be disabled when building images, though when testing from development branches I recommend running a stable singularity image with the PYTHONPATH set to the checked out branch"
is kind of confusing to me, you seem to be saying
a) theoretically type checking can be disabled (btw, why do type checking and disable it?)
b) but rather than a) you recommend using a stable image - so where is that supposed to come from?

The fix to make cuckoo mode work on my fork is:
-    run(options, force_consensus=options.force_consensus)
+    run(options, force_consensus=options.consensus)

It is not actually required to build an image to try this out. What I recommend for testing small patches is to run a stable singularity image but overriding the path that viridian is sourced from:
PYTHONPATH=viridian_workflow/ singularity exec vwf.img viridian_workflow cuckoo --dump_tsv --tech illumina --consensus ../covid/MN908947.fasta --ref ../covid/MN908947.fasta --outdir /tmp/test/ --reads1 ~/covid/ERR7194000_1.fastq.gz --reads2 ~/covid/ERR7194000_2.fastq.gz --force
Any image will do as long as the installed components (varifier, cylon, etc.) are compatible with what you're testing.
Regarding type checking, you can think of it like unit tests or documentation coverage. You can disable unit tests to build an image if they aren't passing on your development branch but there's something specific you'd like to test. I do not recommend disabling these checks when building images, though. A much more ergonomic development setup is to use the above development method.

Does this resolve the issue?


Fix typo in DotNetCLI publish heading example

Hi @pulkitaggarwl - Could you review this pull request? Thanks.

@pulkitaggarwl any updates on this?

@mijacobs Hi, is there someone on your team who can review this pull request from January? Thanks.


JavaScript engine configuration is inconsistent between app.config.ts and Android native project.

Build/Submit details page URL
No response
Summary
Hello People, I am having a problem with eas update, it tells me that there is inconsistency, which is not real

It is exactly what is in the documentation
If I commented out the jsEngine it throws me the exception

Managed or bare?
Bare
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 12.5.1
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.17.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.15.0 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8815526
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
npmPackages:
@expo/metro-config: 0.3.11 => 0.3.11
@expo/webpack-config: ~0.16.21 => 0.16.27
expo: ^45.0.0 => 45.0.8
react: 17.0.2 => 17.0.2
react-dom: 17.0.2 => 17.0.2
react-native: 0.68.2 => 0.68.2
react-native-web: 0.17.7 => 0.17.7
npmGlobalPackages:
eas-cli: 2.1.0
expo-cli: 6.0.5
Expo Workflow: bare
Error output
[expo-cli] [13:48:54] JavaScript engine configuration is inconsistent between app.config.ts and Android native project.
[expo-cli] In app.config.ts: Hermes is not enabled
[expo-cli] In Android native project: Hermes is enabled
[expo-cli] Please check the following files for inconsistencies:
[expo-cli]   - app.config.ts
[expo-cli]   - android/gradle.properties
[expo-cli]   - android/app/build.gradle
[expo-cli] Learn more: https://expo.fyi/hermes-android-config
[expo-cli] [13:48:54] Error: JavaScript engine configuration is inconsistent between app.config.ts and Android native project.
[expo-cli] In app.config.ts: Hermes is not enabled
[expo-cli] In Android native project: Hermes is enabled
[expo-cli] Please check the following files for inconsistencies:
[expo-cli]   - app.config.ts
[expo-cli]   - android/gradle.properties
[expo-cli]   - android/app/build.gradle
[expo-cli] Learn more: https://expo.fyi/hermes-android-config
[expo-cli]     at maybeThrowFromInconsistentEngineAsync (node_modules/@expo/dev-server/src/HermesBundler.ts:112:11)
[expo-cli]     at maybeAddHermesBundleAsync (node_modules/@expo/dev-server/src/MetroDevServer.ts:214:5)
[expo-cli]     at bundleAsync (node_modules/@expo/dev-server/src/MetroDevServer.ts:247:26)
[expo-cli]     at Object.createBundlesAsync (node_modules/xdl/src/project/createBundlesAsync.ts:100:19)
[expo-cli]     at exportAppAsync (node_modules/expo-cli/src/commands/export/exportAppAsync.ts:85:19)
[expo-cli]     at exportFilesAsync (node_modules/expo-cli/src/commands/export/exportAsync.ts:99:10)
[expo-cli]     at actionAsync (node_modules/expo-cli/src/commands/export/exportAsync.ts:186:3)
Reproducible demo or steps to reproduce from a blank project
"APP_ENV='staging' eas update --branch staging --platform='android'"

The problem is here, the regular expression is very exact... so if you have a linter for the gradlew files and you put single quotes in both hermes and jsc it will fail
This file: https://github.com/expo/expo/blob/main/packages/%40expo/dev-server/src/HermesBundler.ts


Update SDK to include some fixes.

- Bump x-ms-version to 2014-10-01. Old value was not accepted in
certain regions when creating VM deployment.
- Add virtual IP fields in Deployment.
- Make cloud service creating async.
- Deleting cloud service now supports deleting blobs from storage.
- Some bug fixes.

Thanks!  I'm running the tests right now, so far it looks like that didn't break anything, which is always a risk when upgrading to a newer x-ms-version.

Yes I understand the risk. The old 2014-06-01 value was not accepted when I was trying to deploy a DS VM in Southeast Asia region.


⚠ NCAA has degraded performance

In 28d79aa, NCAA (https://www.ncaa.com) experienced degraded performance:

HTTP code: 200
Response time: 568 ms

Resolved: NCAA performance has improved in 4f0beb2.


failure: nixos.tests.boot.biosUsb

https://hydra.nixos.org/build/176455602/nixlog/3
Running nix-build '<nixpkgs/nixos/tests/boot.nix>' -A biosUsb on nixpkgs e680b5 doesn't show the problem on my machine, unfortunately, so it seems some kind of indeterminism
machine # <<< NixOS Stage 1 >>>
machine #
machine # /init: source: line 125: can't open '/nix/store/zb52zilvazsljqr1p20lyvzwv5bdicf2-mounts.sh': No such file or directory
machine #
machine # An error occurred in stage 1 of the boot process, which must mount the
machine # root filesystem on `/mnt-root' and then start stage 2.  Press one
machine # of the following keys:
machine #
machine #   r) to reboot immediately
machine #   *) to ignore the error and continue

line 125 of nixpkgs/nixos/modules/system/boot/stage-1-init.sh is source @earlyMountScript@

Ah, this is a result of the earlier error:
machine # Loading /boot/initrd...cpage out of range (5)
machine # processing error - resetting ehci HC
machine # CHS: Error 0c00 reading sector 86723 (43/0/36)
machine # EDD: Error 0c00 reading sector 86723
machine # CHS: Error 0c00 reading sector 96330 (47/25/4)
machine # EDD: Error 0c00 reading sector 96330
machine # ok

which suggests this is a duplicate of #170803 . Indeed this build was on e680b5 which does not qet have the fix from 218a48c8491968735af9bb2cd87475206a6310e1, so that checks out.
I'm surprised it tries to boot even though the USB transfer failed, though - is that impossible to detect?

I'm surprised it tries to boot even though the USB transfer failed, though - is that impossible to detect?

hmm, or perhaps it recovered from that failure, but there was another undetected corruption caused by the same bug. let's close this.


Torrent option doesn't work on mobile version

Transmssion version: 2.94
Tr Web Control version: Installed using "install-tr-control.sh", so I believe it is the latest (v1.6.0-beta2 )
Browser name & version：Chrome Beta on Android (73.0.3683.75) and Firefox Nightly on Android (67.0a1)
Problem description:

Hi. I access transmission webUI on my Android.
But when I tap the "gear" icon next to the torrent's name, nothing happen.

Sorry, is my problem, this feature has not been done yet. :sweat_smile:

Oh. No problem.
Thanks for the reply :D


Feat/virtual joystick

Feat/virtual joystick
New feature added: Basic Virtual Joystick
Hi, I decide implement this feature because it appears to be in high demand. Hope you find interesting.
Description:

Joystick can be activated by button on bottom (see picture)
For resolutions less than 650px wide it's active by default
When resolution ir less than 650px and chat is active, joystick is hidden because it interferes with the chat

For implement this, I use this component: https://github.com/elmarti/react-joystick-component
Note: This feature will conflict with this PR:  #.62
I can take care of resolving conflicts
Related issues:

#.23
#.60

Hi there,
Thank you for submitting the pull request for the new virtual joystick feature. It's great to see proactive contributions, especially when they're aimed at improving user experience for those on smaller devices. I've gone through the changes, and I have some feedback and questions to ensure we maintain the quality and functionality of our codebase.
General Feedback
Overall, the implementation of the virtual joystick seems to align well with the feature request. The use of react-joystick-component is a good choice for this functionality, and the conditional rendering based on screen resolution is a thoughtful touch. However, there are a few areas that need attention before we can merge this PR.
Specific Feedback
Code Organization and Clarity

The new Joystick.jsx and MobileVirtualJoystick.tsx components are a welcome addition. However, I noticed that Joystick.jsx is a .jsx file while the rest of the project seems to be using TypeScript (.tsx). For consistency and type safety, could you please convert this to a .tsx file and ensure proper typing is applied?

UI/UX Considerations

You mentioned that the joystick can be activated by a button at the bottom, but I couldn't find the implementation for this in the diffs provided. Could you point me to where this is handled, or add the necessary code if it's missing?
Regarding the picture you referenced for the joystick's appearance, it seems it wasn't included in the diffs. Could you please attach the image or provide a link to it so we can review the visual aspect as well?

Responsiveness and Interaction

It's good to see that you've considered screen resolutions and the chat's visibility. However, have you tested these changes across different devices and browsers to ensure the joystick behaves as expected? Cross-browser and device testing is crucial for UI components like this.

Potential Conflicts

You've noted that this feature will conflict with PR #62. It's important to resolve these conflicts before we can proceed. Could you please take the necessary steps to address the conflicts and ensure that both features can coexist without issues?

Code Quality and Best Practices

In MyPlayer.ts and PlayerSelector.ts, you've added logic to handle joystick movement. I recommend encapsulating this logic within a dedicated service or utility to avoid code duplication and to keep the components focused on their primary responsibilities.

Documentation and Comments

While the code changes are mostly self-explanatory, adding comments to new methods and complex logic can greatly improve maintainability. Please add comments where necessary, especially for the joystick movement handling.

Testing

I didn't see any tests included with the PR. It's important to add unit tests for the new functionality to ensure it works as intended and to prevent future regressions. Could you add tests for the handleJoystickMovement method and any other critical logic introduced?

Conclusion
Once again, thank you for your contribution. The virtual joystick is a valuable feature, and with some refinements, it will be a great addition to our application. Please address the points mentioned above, and feel free to reach out if you need any clarification or assistance.
Looking forward to the updated pull request!
Best regards,
[Your Name]

Hi there,
Thank you for submitting the pull request for the new virtual joystick feature in the SkyOffice application. It's great to see contributions that enhance user experience, especially for mobile users. I've reviewed the changes, and I have some feedback and questions to ensure the feature integrates smoothly with the existing codebase.
General Observations

The feature's responsiveness to screen size and chat visibility is a thoughtful touch. It's good to see that you've considered different user scenarios.
The use of react-joystick-component seems appropriate for this feature. However, we need to ensure that adding this dependency aligns with the project's overall dependency management strategy.

Specific Feedback
Dependency Management

You've added react-joystick-component version ^6.0.0. Please confirm that this version is compatible with the current React version used in the project and that it doesn't introduce any breaking changes or conflicts with other dependencies.

Code Organization and Quality

The new file Joystick.jsx uses a .jsx extension, while the rest of the project seems to be using TypeScript (.tsx). For consistency and type safety, consider converting this to a TypeScript file.
In MyPlayer.ts, you've added a joystickMovement property and a handleJoystickMovement method. Ensure that these are integrated properly with the existing movement logic and that there are no conflicts or redundant code paths.
For PlayerSelector.ts, similar to MyPlayer.ts, ensure that the joystick input is handled in a way that doesn't conflict with existing input methods.

UI/UX Considerations

You've made several adjustments to styled components to accommodate the joystick. Please ensure that these changes do not negatively impact the layout or usability of other UI elements, especially on different screen sizes or orientations.
The toggle button for the joystick is a great addition. However, consider adding an accessible label or aria-label for screen readers to ensure the feature is accessible to all users.

Code Compatibility and Conflicts

You've mentioned that this feature will conflict with PR #62. It's important to outline the specific areas of conflict and propose a plan for resolution. If possible, coordinate with the author of the other PR to minimize integration issues.
Ensure that the new setShowJoystick action in UserStore.ts is properly integrated with the rest of the Redux store and that it doesn't introduce any state management issues.

Testing and Documentation

Please provide unit tests for the new functionality to ensure that it works as expected and to prevent regressions in the future.
Update any relevant documentation, including the readme.md, to reflect the addition of the virtual joystick feature and any new controls or interactions it introduces.

Final Thoughts
Overall, the feature seems promising and could significantly improve the mobile user experience. However, it's crucial to maintain consistency with the existing codebase and ensure that the new feature is well-integrated, tested, and documented. Please address the points mentioned above, and feel free to reach out if you need any clarification or further discussion on any of the feedback provided.
Looking forward to seeing the refined implementation of the virtual joystick!
Best regards,
[Your Name]

Thank you for your contribution to the SkyOffice project with the virtual joystick feature. I've reviewed the changes and provided comments where necessary. Please address the feedback to ensure the feature integrates smoothly with the existing codebase. If you have any questions or need further clarification on any of the comments, feel free to reach out.
Good work on considering mobile users and enhancing the user experience with this feature. Looking forward to seeing the final implementation in action!


More Info regarding AWS cloud cost integration using Terraform

I want to integrate AWS-cloud cost to opencost but could not able to find out enough documentation about how we can create different stuff like:

IAM-roles
Policies
Athena Query
S3-bucket

with terraform

The OpenCost Helm chart doesn't do anything related to IAM, Athena or S3. Is the documentation here insufficient? https://www.opencost.io/docs/configuration/aws

I'm going to move this over to https://github.com/opencost/opencost-website and try to give the docs a walk-through to recreate


[$250]  Language - Message of added or invited user to "#admins" chat, doesn't get translated

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.17-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team
Action Performed:

Open the https://staging.new.expensify.com/
website.
Tap on the avatar on the bottom of the screen.
Tap on "Preferences"
Tap on "Language"
Tap on "Spanish"
Tap on the arrow on the top left corner.
Tap on the chats icon on the bottom of the screen.
Check in the "#admins" chat preview, the language in which the invitation message is displayed.
Open the "#admins" chat.
Check the "New user added" message and the language in which is displayed.

Expected Result:
When choosing Spanish as language, all the sections and chats information should be changed to that language.
Things that need to be changed:
Invited 1 user to Chat Report

We already have a translation of the invited user to english into spanish but that doesn't match the screenshot (no number) so seems like we might have this phrase somewhere else.

[ ] update the LHN to use this English copy. Tbh neither I nor Ioni cannot find the copy in the screenshot in the database, maybe it was already updated?
[ ] update English copy to invited member ${to}
[ ] update Spanish copy to miembro invitado ${to}

added <email> as a user

[ ] English should be updated to added <email> as a member
[ ] Spanish translation should be set to agregó a <email> como miembro

Actual Result:
When choosing Spanish as language, the "#admins" chat, still displays information in English.
For example, the message "Invited 1 user to chat report", in the preview of the chat, is not translated as "Invitó a un usuario al chat."
And when opening the chat, the message "Added<EMAIL_ADDRESS>as a user" is also missing translation. The correct translation of this last sentence, would be "Agregó a<EMAIL_ADDRESS>como usuario."
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/76544b0d-f8c0-4cc8-9fcb-ffbe811c46c2

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010023a595aa275ac1
Upwork Job ID:<PHONE_NUMBER>547735883
Last Price Increase: 2024-09-05
Automatic offers:

ZhenjaHorbach | Reviewer | 103526301
nkdengineer | Contributor | 103526302

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

We think this issue might be related to the  #vip-vsb

I don't think it's a bug because almost policy change log actions aren't translated.

@Expensify/design is this a feature or a bug?

Hmm @dylanexpensify is your system message project covering system message translations? Otherwise I'm not too sure what the current expected behavior is for this.

Ahh interesting, technically it was just for silencing them, but we did do some copy updates, and I wonder if maybe we missed this. @deetergp any ideas?

@deetergp bumping Dylan's question. We're wondering if this is expected or a bug

That is not one of the messages we made translatable as a part of the Enhanced System Messages project, so this is not a bug, it is new functionality. For future reference, these were the actions we localized for the project: https://github.com/Expensify/App/blob/11af67b62a0a1ec905d7181ac82a183f1b03bd3b/src/languages/en.ts#L3770-L3799

Thanks Scott!
Ok, so this is not a "bug" but may be a new feature request. Asking in slack if we want to do something about this

Things that need to be changed:

English: change "user" to "member" in added <email> as a member
Spanish: add a translation of added <email> as a member as agregó <email> como miembro
Spanish: add a translation of Invited 1 member to chat report as Invitó a 1 miembro al chat de informe

Confirming translations in slack ⏳

Proposal
Please re-state the problem that we are trying to solve in this issue.
When choosing Spanish as language, the "#admins" chat, still displays information in English.
For example, the message "Invited 1 user to chat report", in the preview of the chat, is not translated as "Invitó a un usuario al chat."
And when opening the chat, the message "Added<EMAIL_ADDRESS>as a user" is also missing translation. The correct translation of this last sentence, would be "Agregó a<EMAIL_ADDRESS>como usuario."
What is the root cause of that problem?
This is a new feature request
What changes do you think we should make in order to solve the problem?
For Invited 1 member to chat report, I'm unsure how we can display this message in the admin room.

We should have a util to get the translated message for POLICYCHANGELOG_ADD_EMPLOYEE action.

function isPolicyChangeLogAddEmployeeMessage(reportAction: OnyxInputOrEntry<ReportAction>): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE> {
    return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE);
}

function getPolicyChangeLogAddEmployeeMessage(reportAction: OnyxInputOrEntry<ReportAction>): string {
    if (!isPolicyChangeLogAddEmployeeMessage(reportAction)) {
        return '';
    }

    const {email, role, name} = getOriginalMessage(reportAction);
    return Localize.translateLocal('report.actions.type.addEmployee', {email, name, role});
}

Then we will add a case in ReportActionItem to display the translated message for POLICYCHANGELOG_ADD_EMPLOYEE action

else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE) {
    children = <ReportActionItemBasicMessage message={ReportActionsUtils.getPolicyChangeLogAddEmployeeMessage(action)} />;
}

https://github.com/Expensify/App/blob/55f67f53ca8ed8596943ce930ec10a3bd6f13427/src/pages/home/report/ReportActionItem.tsx#L654-L655
3. Add a case in SidebarUtils to display the translated message in LHN
else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE) {
     result.alternateText = ReportActionsUtils.getPolicyChangeLogAddEmployeeMessage(action);
}

https://github.com/Expensify/App/blob/55f67f53ca8ed8596943ce930ec10a3bd6f13427/src/libs/SidebarUtils.ts#L427-L428

Add a case in ContextMenuActions to copy the translated message to clipboard

else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.ADD_EMPLOYEE) {
     setClipboardMessage(ReportActionsUtils.getPolicyChangeLogAddEmployeeMessage(reportAction));
}

https://github.com/Expensify/App/blob/55f67f53ca8ed8596943ce930ec10a3bd6f13427/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L460-L461
We can do the same way for other system actions that we need
What alternative solutions did you explore? (Optional)

Invited 1 user to Chat Report

We already have a translation of the invited user to english into spanish but that doesn't match the screenshot (no number) so seems like we might have this phrase somewhere else.

[ ] update the LHN to use this English copy. Tbh neither I nor Ioni cannot find the copy in the screenshot in the database, maybe it was already updated?
[ ] update English copy to invited member ${to}
[ ] update Spanish copy to miembro invitado ${to}

added <email> as a user

[ ] English should be updated to added <email> as a member
[ ] Spanish translation should be set to agregó a <email> como miembro

Decreasing price since this is a simple copy change, making sure a translation exists, and a little bit of searching to confirm where the old translation is coming from. Details here

@ZhenjaHorbach I updated my proposal.

@ZhenjaHorbach sounds good 👍

@sonialiap please give me translations for 2 cases above

@nkdengineer
English - updated the role of <email> from "<role>" to "<role>"
Spanish - actualicé el rol de "<role>" a "<role>"
English - removed <role> <email>
Spanish - eliminado <role> <email>
user - should be changed to member in English. miembro in Spanish
admin - administrador in Spanish

@zanyrenney I'm OOO Aug 19-30, adding leave buddy.
Status: waiting for build

Decreasing price since this is a simple copy change, making sure a translation exists, and a little bit of searching to confirm where the old translation is coming from. Details https://github.com/Expensify/App/issues/46960#issuecomment-2288509737

@zanyrenney This issue not only did a simple change translation but also updated copy case, LHN case, and side bar util case and fixed for some other messages. See the PR for more details. Can you please update the price to the default price, thanks.

I'm unassigning as Sonia came back a few days ago, so you shouldn't need my help here! She has more context on the payment being changed so will leave that convo to her! :)

Hi team, I agree that it makes sense to update the price to the default since this issue ended up growing 👍
Automation didn't run, but the deploy happened 3 weeks ago so I'm issuing payment!
Payment summary:

@ZhenjaHorbach $250 - paid in upwork ✔
@nkdengineer $250 - paid in upwork ✔


GradientTape.batch_jacobian returns the wrong type in case of constant functions

System information
Google Colaboratory with TF 2.3.0, git version v2.3.0-0-gb36436b087
Describe the current behavior
tf.GradientTape.batch_jacobian of a constant function with return type float64 returns a zero matrix of type float32
Describe the expected behavior
return a zero matrix of type float64
Standalone code to reproduce the issue
@tf.function
def foo(val):
  return tf.constant([[3.0],[4.0]],dtype=tf.dtypes.float64)

c = tf.constant([[1.],[2.]],dtype=tf.dtypes.float64)
with tf.GradientTape() as g:
			g.watch(c)
			f = foo(c)

print(g.batch_jacobian(f,c))

Other info / logs
Workaround: setting the option unconnected_gradients to 'zero'
@tf.function
def foo(val):
  return tf.constant([[3.0],[4.0]],dtype=tf.dtypes.float64)

c = tf.constant([[1.],[2.]],dtype=tf.dtypes.float64)
with tf.GradientTape() as g:
			g.watch(c)
			f = foo(c)

print(g.batch_jacobian(f,c,unconnected_gradients='zero'))

I have tried in colab with TF versions 2.3, nightly versions(2.4.0-dev20200908) and was able to reproduce the issue. Please, find the gist here. Thanks!

If let interact the watched c with f it will return the correct dtype:
with tf.GradientTape() as g:
      c = tf.constant([[3.],[2.]],dtype=tf.dtypes.float64)
      g.watch(c)
      f = foo()*c
      print(f)
print(c)
print(g.batch_jacobian(f,c))

@SimonWeitzhofer Can you please check @bhack suggestion and let us know whether the issue resolved for you. Thanks!

The function f in @bhack suggestion is not constant anymore. So, no, if the suggestion is not to use constant functions, then I don't think this is a proper solution.
Actually there is a workaround, namely setting unconnected_gradients='zero' as described in the bug-report.
I would be ok with tensorflow returning None or throwing an exception. Returning a float32 tensor, however, seems wrong to me.

Mine was not a solution it was just to check that when it is not constant anymore the dtype is working correctly.
You problem is related that in the default case unconnect_gradients='null' we are not handling any specific dtype on the source.
https://github.com/tensorflow/tensorflow/blob/31f0b2159751642a146d70561ac5095a3c4722ff/tensorflow/python/eager/pywrap_tfe_src.cc#L2804-L2814
/cc @edloper


dhclient not working on developer edition?

Downloaded the vpnserver/client versions from this repo using a fresh build of raspian OS (2021)
I'm failing to get an IP address when connecting to a virtual hub using the virtual dhcp on the hub
After downloading the arm client from https://www.softether.org/5-download it worked right away?
Is this a bug possibly?
Simple connection to a virtual hub with virtual dhcp enabled, but no ip received on client
using arm linux client (raspberry pi 4)
client status is connected
AccountList command - Get List of VPN Connection Settings
Item |Value
----------------------------+---------------------------------------------
VPN Connection Setting Name |
vpnclient Status |Connected
VPN Server Hostname (Direct TCP/IP Connection)
Virtual Hub |Prayertimetable
Virtual Network Adapter Name|vpnse
The command completed successfully.
So I tried again with the installation of the client from https://www.softether.org/5-download and it works fine I received the address straight away...... bug possibly?

I can't reproduce the issue with both client and server built from the latest commit on master.
Please note that you have to run the DHCP client (e.g. dhclient) manually for the interface, for example:
sudo dhclient vpn_vpnse

Closing in favor of #1298.


Fix tests and checks

Description
updated tests folder to match other cookbooks
updated spec platform to supported version
Issues Resolved
Fixes #64
Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger


Greedy algorithm to find minimum number of coins

💥 Proposal
Greetings sir/Mam,
I would like to contribute the code for this issue in C++/CPP.
The code is ready. I have added the code , along with proper explanation of the algorithm , test cases , time complexity and space complexity of the same, as per the guidelines.
Kindly assign it to me.
This is regarding GSSOC'21.
Regards,
Hitain Kakkar

/assign


add multiselect for 1.2.0

Hi @wesyao, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Wesley Yao). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Node Module updating error everytime i open hyper

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

MacOS Mojave
Hyper 3.0.0-canary.8 (canary)
https://gist.github.com/designMoreWeb/cdc5ef8057a9a5952806a6696aca9124
There are no errors on the console

Issue

Hi I am on the latest version of hyper and every time i open it I get this error popup

and the console shows no errors

should no longer happen with CI builds of canary and the next release


[Feature Request] Directly pasting the selected clip in addition to storing into clipboard buffer

I almost always want to "paste" something from my clipboard history which means in clipmenu's current form I first have to select the clip and then paste manually. It'd be nice if there was an option to do this in one go. One way I can think of implementing this would be doing something like below at the very end:
echo "$chosen_clip" | tr -d '\n' | xclip -selection clipboard
xdotool key Shift+Insert

Hi! This looks like a duplicate of https://github.com/cdown/clipmenu/issues/129. I'd suggest you reply to the existing concerns there :-)


fix: wrong topic_count value for log opcodes

I think the topic_count values of log opcodes are wrong.
Here's a quick example with log0.

The minimum gas cost is 375
The dynamic gas cost is given by the formula dynamic_gas = 375 * topic_count + 8 * size + memory_expansion_cost
It is said that for log0,  topic_count is equal to 0. I think it should be 1 in this case instead.

Thank you for contributing.
This is not the case. See for example here https://medium.com/mycrypto/understanding-event-logs-on-the-ethereum-blockchain-f4ae7ba50378
You can also notice that LOG0 has no topic parameters, LOG1 has 1 topic parameter and so on.
Please check your assumptions before opening a PR :-)
Closing the PR.

Oh I got it wrong, gas_cost = static_gas + dynamic_gas. My bad :(

No worries :-)
Please let us know if we can make it more clear.

I was thinking of something like the following.


Update LICENSE

Adds company info and date to license

@j1mie the company name might be IBM Corp., I believe.


[improve][pip] PIP-377: Automatic retry for failed acknowledgements

Motivation
In the pip-377.md file
Modifications
In the pip-377.md file
Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

Is there a precise step to reproduce the acknowledgment lost?

Is there a precise step to reproduce the acknowledgment lost?

@aloyszhang not yet, there's #22709 and #21958 where it seems that acks get lost.
One possible way that it could happen is due to #23200 where the number of ack holes exceeds the default limit of 10000 and the consumer gets reconnected at this time (client connection breaks or due to load balancing event).
There was a previous attempt to limit the number of ack holes with PIP-299. The problem is that it won't prevent exceeding the limit. The problem described in #23200 is addressed with #23231 (which I'm currently working on).


Consider abstracting raw datatype (i32, i64, f32 etc) via associated types

We currently support four data types- i64, String, f64, bool- via an enum. It may be possible to adjust the enum to work on broader bit depths. The Int variant can take a class with an associated type containing the raw, specific type- i8, i16, i32, etc. One concern here is inefficiency with the extra abstraction layer, especially in the runtime- but the Value::Array float variant could contain an ArrayD as an associated type, which should be a zero-cost abstraction. If handling variants via associated types is sufficiently flexible, then support for each type variant could be handled via macros.
I'm open to other ideas on supporting these types. Also keep in mind that the runtime doesn't need to support all of the data types that the validator supports.

related to #114

This could be done via

I ended up aliasing the elementary types. You can configure the bit depth for most of the library, however, protobuf and noise addition still uses 64-bit ints and floats. This also doesn't provide support for casting between bit depths. If we want to support configurable bit depths for noise addition, we'll need to add some conditional compilation. Not hard, but not seemingly a priority. The vast majority of the library can be plugged with an arbitrary bit depth, which seems to be more than enough functionality at this point.


How do I install the plugin?

I have a softlink for the extension: guacamole-auth-jwt-0.9.14.jar -> /home/ubuntu/custom/guacamole-auth-jwt/build/libs/guacamole-auth-jwt-0.9.14.jar
I build this in gradle build, but feel I am royally missing a step. What am I doing wrong?

I don't get any errors when I restart my server, but the python script just returns 403.

'{"message":"Invalid login","translatableMessage":{"key":"Invalid login","variables":null},"statusCode":null,"expected":[{"name":"username","type":"USERNAME"},{"name":"password","type":"PASSWORD"}],"type":"INVALID_CREDENTIALS"}'
Adding 'GUAC_USERNAME': 'guacadmin' and 'GUAC_PASSWORD': 'guacadmin', to the payload doesn't work/

Oh and nothing was added to my guacamole.properties usermapping

The README file has updated to include installation and configuration content.


Add release-note-experimental as a valid label.

ref #882
@eparis is there any doc I can follow on how to test and rollout changes in contrib?

make help gives a little description. I started to write a README the other day. I often do something like the following for locally testing specific changes:
make mungegithub && ./mungegithub --dry-run --pr-mungers=$MUNGERS --kubernetes-dir=/path/to/dir --token-file=/path/to/token/file --min-pr-number=X --max-pr-number=Y
And making sure the local logs look like it is doing the right thing.
Then I'll do a REPO=docker.io/eparis APP=submit-queue make deploy to test it against a real kube cluster how it would be deployed. If that all looks ok I'll do KUBECONFIG=/path/to/production/kubeconfig READONLY=false REPO=docker.io/eparis APP=submit-queue make deploy to deploy to production.

Got it.  Thanks for the writeup.  Some questions for the very uninitiated:

What is the purpose of the min/max pr args?  Do I just pick some range that includes a couple of PRs?  What is that doing exactly?  Can I leave out one or the other?
When I did run it, I'm not sure what to expect.  It stopped at this point, but I'm not sure if that's a good thing and I should wait?  I ^C'd to see if there were any logs yet, but no.  Is ~10min the expected run-time here?  And what exactly can I look for in the logs that indicates things went 'ok'?

I0531 17:13:19.021779   57813 mungegithub.go:59] Running mungers
I0531 17:13:35.329834   57813 github.go:223] Made 38 API calls since the last Reset 2.330136 calls/sec
I0531 17:13:35.329908   57813 mungegithub.go:74] Sleeping for 9m43.691871175s

min-max is just to make it only tests the PRs you expect to be relevant. In this case no PRs have the experimental label, so you wouldn't expect this PR to do anything...
the bot runs in a loop, once every 10 minutes. So it tested all of the pr's between min/max (or all PRs if you left it out) and then waited for 10 minutes to test those PRs again.
Create a test PR, with the experimental label, then run it 'against' that PR, and read the logs.

Label testing seems to do what it should, AFAICT.
As far as actual deployment, what is the /path/to part of KUBECONFIG=/path/to/production/kubeconfig?  I haven't played with any of this yet.
Do you usually check things in before deploying?  I guess it doesn't really make a difference for this.

You'll have to talk with someone to get the 'production' kubeconfig. I know that at least @lavalamp @mikedanese and @brendandburns have it. We only put HEAD into production. So yes, it would need to be merged before you ran it with READONLY=false

This has been deployed.  LGTM when you get a chance. Thanks everyone for the assist!

This is already deployed in production?

@eparis yes.  It looks like we wanted this merged before however.  Can we merge this now or would we like to roll back?

@david-mcmahon I want to know who helped you, so I can yell at them (and then merge this)

You can yell at me. I misread the last comment and went ahead with the deployment.

bad david. bad.  we've had a number of regressions where people committed (even minor) changes to production without merging. And the next person along accidentally reverted their fix.
If you self push to production, better to self merge. We can roll production back, but silent changes are stinky.

This dev->deployment process could probably benefit from some releng tooling.
Guided processes that enforce policy through tooling certainly can avoid the pitfalls that are bound to happen when in the wrong hands.  I'll file an issue.


Added a script to remove activity on non-campaign nodes.

What's this PR do?
removes all activity (signups/reportbacks) on any of these node types

campaign_group
home
fact
fact_page
image

How should this be manually tested?
run drush --script-path=../scripts/ php-script remove-non-campaign-activity.php signup|reportback
Any background context you want to provide?
no
What are the relevant tickets?
Refs #6232

:+1:


Python docs should embed Pandas DataFrame as HTML table

Currently pweave'ing a pymd file to MD with a Pandas dataframe displays a text only table.
But it would be much more powerful to display the HTML table that one would see in a Jupyter notebook.

One possibility:

if there were an option to output a code chunk without the triple back ticks;
use the dataframe to_html method;
Would still require  some surgery because the mutations we've made to html_formatter in rf_ipython are not being honored.

Another possibility:

A custom function in the docs module to handle the rendering?

Note we demonstrate an example of working around this with @@include and creating a static html of the output
https://github.com/locationtech/rasterframes/blob/develop/pyrasterframes/src/main/python/docs/raster-write.pymd#L57
Not as maintanable but something


Huge lag in new project,

Tested versions

v4.2.1.stable.official [b09f793f5]

System information
Windows 10 - v4.2.1.stable.official [b09f793f5]
Issue description
after opening a new project (im starting at godot), everthing just lags at a unusable level. (this only happens when in a project). I maked some test in my notebook, and didnt notice this lag in other apps or games.
Steps to reproduce
Create a new project, and open it
Minimal reproduction project (MRP)
N/A happens in ever new project

What are your system specs? It's likely you have a GPU issue (e.g. thermal) or broken drivers

There's not enough information provided in the issue. We cannot really do anything with this, especially without hardware details.
If I have to make a light guess, Godot may be running on integrated graphics, which is still not enough for a bug report.

@Zireael07
I use a laptop, he have an Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz   2.81 GHz, and 8,00 GB RAM. and now im finally capable to see the spec about the laptop, i have to say it is a pretty bad laptop.
Idk if this is the real problem, or not, but can be. sry for dont bring the details :(

Could you give the specs of your GPU, if any? If you are unable to find them, it is likely using integrated graphics and this kind of lag sounds about right.

(this only happens when in a project)

I assume this means that the Project Manager is completely fine, which makes sense since it is not really performance-intensive in any way.

weel, im using integrated graphics, sorry for wasted your time. so sorry.

Closing, as this issue lacks actionable information for us to be able to do anything.


Admin/Owner approval for editor changes

When given editor permission, the user is able to make changes to permission nodes through editor, but one must wait for approval from administrators / server owner with (maybe a new) luckperms admin permission before changes are made to the server
Simplified workflow chart:
User with "luckperm.editor" (without admin permission) --> opens editor--> make changes ---> server prompts server admin for changes ---> admins approve/reject changes
server admin my be distinguished by "luckperms.admin"

Don’t give the player the luckperms.applyedits permission. That’s what’s needed to actually make changes.
Though you shouldn’t let players edit permissions anyways.

will that prompt admins for pending changes?
p.s. I'm doing this to allow server managers to edit permissions by their own and wait for my approval so that i could do less but at the same time "knows" what they are attempting to change

You could just give your admins access to the editor, but not the applyedits permission, and ask them to send you the command link, for you to apply it.
Furthermore, the changes they make will all be appended to /lp log, so you could review them there.
I think a queued changes + review system is a bit overkill, and don't think it's really in-scope for inclusion within a permissions plugin.

Maybe a dry run flag, to preview the changes would be doable.

https://github.com/lucko/LuckPermsWeb/issues/34

But like ingame instead of the editor.


Add support for pagination

Pull full API from Petfinder and do pagination internally for better performance.

Won't support...


✨[Feature] Add appsflyer

Overview
Added SDK to more accurately count MAU for both platforms

cc: @azisramdhan

It stands for Monthly Active Users I guess @josikie

🏆 ! yes @azisramdhan and @josikie  MAU = Monthly Active Users.
As mobile developers, it is the most critical way we measure growth of our apps.


Usage of *.pubxml properties with dotnet publish

The documentation states that the following properties in *.pubxml files are not honored by dotnet publish:

LastUsedBuildConfiguration
Configuration
Platform
LastUsedPlatform
TargetFramework
TargetFrameworks
RuntimeIdentifier
RuntimeIdentifiers

However, when I use the command with no options but a publish profile (dotnet publish -p:PublishProfile=MyProfile), it appears to me that at least Configuration, TargetFramework and RuntimeIdentifier are very well honored.
Is the documentation up-to-date in this regard? Unfortunately, I don't have the expertise to cross-check the code base of the utility.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 211afdc7-c796-202d-239d-823f2a499dff
Version Independent ID: 9439897e-dcb3-bc2e-5cae-35c1ca2e0681
Content: dotnet publish command - .NET CLI
Content Source: docs/core/tools/dotnet-publish.md
Product: dotnet-fundamentals
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

They are not fully honored - the timing is such that certain properties that are critical to the build process (especially some build output paths) are not honored. We in the CLI would need to implement a two-phase publish like VS does, where we first identify the Publish Profile to be used, and then use its properties as inputs to the 'real' publish call, before we could change this documentation. This is something I'd like to do for .NET 8 but it is not yet certain if we will be able to do this.


Add PR or commit refs to CHANGELOG.md

Adds references to the specific PR (or commit hash if no PR was made for the change) to the Changelog file.

Would it be okay to make the PR/refs clickable links?

But, GFM...

Would you consider making the PR/refs clickable links?

They are? GitHub will render them as dlickable links

IDK maybe its just something weird on my side then
https://github.com/user-attachments/assets/558b9815-414a-48be-9a98-9f0d1e842053

Mentions don't render on markdown files. Not sure about PRs and commits

Mentions don't render on markdown files. Not sure about PRs and commits

release notes =/= markdown files

Odd
https://github.com/user-attachments/assets/a0059ac8-9725-4c00-8087-b030779add41

Here's what I see in the 0.16.5 release notes

Odd
https://github.com/user-attachments/assets/a0059ac8-9725-4c00-8087-b030779add41

Apparently that only happens in release notes, I swear it happened everywhere. Now I'm not even sure if the PRs will link eventually, that's so dumb.

We could always just use []()

We could always just use []()

Yes, but I'll try one other thing first. Hoping that'll make GitHub show the short links instead of long ones.

Just use full link and it will show correctly even outside of GitHub (i.e. on the website).

It's missing one of my commits 😤 smh
😂😂

It's missing one of my commits 😤 smh
😂😂

Which one? If it happened after the initial changelog creation, it wouldn't be in here.

#1057

#1057

Technically out of scope for this PR but I'll add it later 👍


Present planning challenges identified by SCE at next TSC meeting.

Anthony to deliver this a Feb 2024 meeting.


docs v0.7.1 rename recommended to deprecated

closes #1858

Coverage remained the same at 79.117% when pulling 6b4847036c7990d0b70924c689dbe2f1c4737c79 on mparke:rename-deprecated into b92729fa1ca8e1ea59722bcb805bb9bd4f4e7c55 on linode:master.

Coverage remained the same at 79.117% when pulling 6b4847036c7990d0b70924c689dbe2f1c4737c79 on mparke:rename-deprecated into b92729fa1ca8e1ea59722bcb805bb9bd4f4e7c55 on linode:master.

Coverage decreased (-0.03%) to 79.09% when pulling 6b4847036c7990d0b70924c689dbe2f1c4737c79 on mparke:rename-deprecated into b92729fa1ca8e1ea59722bcb805bb9bd4f4e7c55 on linode:master.


[GC] Add unit tests for GC

Add unit tests for GC to check the client behavior.

#4135 tests the "minus" functionality!  It's a component test, with a full Spark environment for testing.


Browsing frame not working

I deleted the post as its not working. I shared the frame once I clicked on browse, the art disappeared. This is what it looked like:

Video
https://github.com/kodadot/nft-gallery/assets/104380776/798ebbba-e0b8-4e65-96a3-d9d47e163467
Got notified by one artist

also minting frame not working:
https://github.com/kodadot/nft-gallery/assets/104380776/caf7f0de-9708-4924-8d08-209636ed3538

Cc @preschian.
error probably going from koda_image

In the group, we had already faced the same error. I don't know about this one. It seems like an error on the farcaster side
Same with:

https://warpcast.com/bleu.eth/0xa3540200
https://warpcast.com/sadr/0xd0afd369

What should I check for this one?

Oh, it's already posted one month ago. It means the gateway is already resolved. We probably need to check on the frame-workers side

also minting frame not working:

can you share the link pls ?

also minting frame not working:

can you share the link pls ?

https://warpcast.com/morbeck-art/0x20eaf96a


[Supporting Platform - Bot Framework Web Chat - Card Breakfast]: In 200% zoom mode 'White-labelled' control is truncated.

Is it an issue related to Adaptive Cards?
No.
What is the PWD impact?
User Experience:
If content is getting truncated or not visible at 200% zoom, then users with low vision who depend on this feature will not be able to identify these controls and perform actions on them.
Note:
User credentials should not be included in the bug.
Pre-requisite:
Achieve 200% Zoom in Browser Zoom.
What browsers and screen readers do this issue affect?
Windows: Edge with Windows Narrator
Are there any code-based customization done to Web Chat?
No, I am using Web Chat without any customizations except "styleOptions".
What version of Web Chat are you using?
Latest production
Which area does this issue affect?
Others or unrelated
What is the public URL for the website?
https://compulim.github.io/webchat-loader/
How to reproduce the issue?

Open URL: https://compulim.github.io/webchat-loader/ and sign in using valid credentials.
Navigate to web chat page and select 4.18.1-main.20240927.ea7a875 (30/9/2024) version and then select mockBot link under present label and then select open web chat in new window link at bottom.
Navigate to white label experience chat page and type Card Breakfast word in type your message text box.
Navigate to the results.
Verify whether the controls are truncated in 200% zoom mode or not.

What do you expect?
In 200% zoom mode 'White-labelled' control should not get truncated. All the controls should be clearly visible.
What actually happened?
In 200% zoom mode 'White-labelled' control is truncated.
Do you have any screenshots or recordings to repro the issue?

Did you find any DOM elements that might have caused the issue?
No response
MAS reference
MAS 1.4.4 – Resize Text
WCAG reference
No response
WAI-ARIA reference
No response
Adaptive Card JSON
No response
Additional context
No response

#A11yMAS;#A11ySev3;#HCL;#Accessibility;#Benchmark;#BotFrameworkWebChat-Oct24;#MAS1.4.4;#Win11-Edge(Chromium);


Add downloads badge

Proposed Changes

Add downloads badge

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests


Schedule periodic GitHub Actions runs for testing

Task to do
Schedule periodic GiHub Actions runs for all testing/quality actions.
Reason
Running periodic Actions runs will allow early detection of breaking changes from dependencies
Result
GitHub will run Actions to continually confirm code viability
Desired testing timeframes
Weekly on every Monday and Wednesday

PRs pending on all the branches that have Actions

PRs pending on all the branches that have Actions


chore(main): release 2.0.0

:robot: I have created a release beep boop
2.0.0 (2024-11-25)
⚠ BREAKING CHANGES

rename frequencies to be more descriptive

Features

rename frequencies to be more descriptive (1668b81)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.0.0
:sunflower:


Supporting command line arguments for all PSL interfaces.

Opening a discussion thread for reviewing changes on Launcher.java. There are many topics that needs clarification like name of the argument parsing file, helpformatter location, where to check if cli interface has passed all the required parameters needs to create a model etc. Those places marked with TODO and FIXME need special attention.
This code has currently been tested to work on Groovy, Java and CLI examples of simple-acquaintances.

Selected a bad branch. Closing this erroneous PR.


Remove unused query params from getImageSetView

Description
This PR removes query params from getImageSetView. No params are used for this API anywhere in the frontend code, and the corresponding backend API /image-sets/view/:id does not recognize any.
The image set details page should work the same before and after this change.
Fixes # (THEEDGE-2859)
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report
Base: 30.26% // Head: 30.30% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (a2886b2) compared to base (51a3980).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   30.26%   30.30%   +0.03%
==========================================
  Files         127      127
  Lines        2818     2815       -3
  Branches      873      872       -1
==========================================
  Hits          853      853
+ Misses       1798     1795       -3
  Partials      167      167

Impacted Files
Coverage Δ

src/api/images/index.js
25.00% <50.00%> (+1.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prompt to install ipykernel even after we fail the first time

Fixes #9444
& contains tests for this and the PR here https://github.com/microsoft/vscode-jupyter/pull/9455
I didn't want to pollute the other PR, hence this PR with just the new changes (easier for review)

till Sunday/Monday to submit this?

oh yes, as discussed no rush to put this into the release


New features

I've got some ideas for (small) features:
1 - More available angles to rotate gradients;
- Basically, a dropdown with additional diagonal angles (15 and/or 45 degrees) options
2 - Color amount filter:
- Buttons to select only gradients with the specified amount of colors (2, 3, 4, 5...)
3 - The # remove button.
- In some cases we don't need  the # on the Hexa value. And could be an option remove that character from there.
I could implement these improvements, if  would be approved
:smiley:

I would like to add a new feature:
4. There should two new sections -
a. Circular Gradients.
b. Special and Mind Blowing Gradients.


How to display landing page before goto login page

Hi
I want view a landing at the first time user visit, then we have register, login...
How to do that?
many thanks

But how do you know if the user is registered?

@PanJiaChen
I mean we will display Login button on landing page
We always show landing page when user visit site (don't need care about registered or unregistered users)

The page's jump logic control is here.
https://github.com/PanJiaChen/vue-element-admin/blob/master/src/permission.js
You can adjust the logic according to your needs.

@PanJiaChen
Do you have any landing page template create by vue element ?

Hi @ndphuong, I created a class project based on this template. It has landing page and directs to login or sign up. Feel free to use that.
https://github.com/bounswe/bounswe2018group6/tree/master/frontend
Deployed version: http://cultidate.ml/#/

@kirbiyik
Very nice, thank you
I think we should add this landing page to this repository

You're welcome @ndphuong, it's up to author's decision I could make a PR if it is requested. @PanJiaChen I think you can close this issue since sufficient example is provided.

I don't think that the landing page is a general requirement. If you have a requirement, you can add it yourself.


Wrong Y axis values on Spark Line Tile when low is different than 0

Hi Gerrit,
I found some issues while playing around with the Spark Line skin. It seems that the position of the Y ticks are calculated based on the low value. This causes issues, because the higher the low value is, the lower the ticks will go (eventually going out of the tile), while if the value moves lower then the ticks will shift up.
I also noticed that the ticks labels are wrong when starting fresh, by setting min and max values to the tile. I guess it's due to the same thing.
Please see these screenshots as they give a clear description of this behaviour:

Another smaller thing - sometimes when the tile gets resized, the upper tick moves in a wrong position (last screenshot).
If you'd like to try this out, I made a demo with a resizable tile, and an input dialog to set the values manually. I'm attaching the code.
I tried to fix this issue myself, but I decided to post it here after I realized that some bigger changes may be needed.
Please let me know if you need anything.
Cheers!
Alessandro
public class SingleDemo extends Application {

    private static final Random RND = new Random();

    public static void main (String[] args) {
        launch(args);
    }

    @Override
    public void start(Stage stage) throws Exception {
        Tile sparkLineTile = TileBuilder.create()
                .skinType(Tile.SkinType.SPARK_LINE)
//                                   .prefSize(TILE_WIDTH, TILE_HEIGHT)
                .title("SparkLine Tile")
                .unit("mb")
                .gradientStops(new Stop(0, Tile.GREEN),
                        new Stop(0.5, Tile.YELLOW),
                        new Stop(1.0, Tile.RED))
                .strokeWithGradient(true)
                .averagingPeriod(40)
                .minValue(100)
                .maxValue(300)
//                .autoScale(false)
                //.smoothing(true)
                .build();

        TextField input = new TextField();

        Button button = new Button("Click Me");
        button.setOnAction(evt -> {
            sparkLineTile.setValue(Double.parseDouble(input.getText()));
            input.selectAll();
        });

        input.setOnKeyPressed(evt -> {
            if (evt.getCode() == KeyCode.ENTER) {
                button.fire();
            }
        });

        Dialog inputDialog = new Dialog();
        inputDialog.setWidth(200);
        inputDialog.setGraphic(new VBox(input, button));
        inputDialog.getDialogPane().setPrefWidth(200);
        inputDialog.show();

        Scene scene = new Scene(sparkLineTile);

        stage.setScene(scene);
        stage.show();
    }
}

Could you do me a favour and check with the latest committed version from commit (62ea96a7f7fd7f7efa43b8a0c0405e57fde821e6)? I think I've fixed it so far but would be good if you could x-check. If it is ok I will create a new version.

Fixed with version 11.33

Hi Gerrit,
Thank you for the quick fix. It seems to work much better but something is still off: for example I tried by setting min and max 100 and 300. The values that I would set inside that range are not shown, and the values below 100 are displayed at the top edge of the tile. Then when I put in another lower value it gets re-adjusted correctly and it works fine.

Hi Alessandro, I've made further modifications and also added a new property "fixedYScale". If you set this property to true it will always take the minValue and maxValue for the y-scale. If set to false it will calculate the scale based on the minMeasured and maxMeasured values, meaning to say it will be a dynamic scale.
Could you give it another try and let me know if this works better for you?

Perfect now! Thank you very much. I was about to implement the fixed Y scale myself because I needed it.
Off topic: I implemented a function in the plus-minus tile to make it so that the when the buttons are long pressed, the value changes quickly. The longer the button is pressed, the faster the value changes. I pasted the code in a gist, in case you would like to include it in the project.
https://gist.github.com/alessandroRoaro/7e56602b7c6b2b54f80d2dc869f11437
Cheers!

...another off topic thing... I read that you created a little game with javafx that got deployed also for Android and iOS. I'm looking for a mobile cross platform solution, for an utility-social app. How was your experience with javafx for that? Should I do better use something else like flutter or react?
I hope I'm not bothering you with this question.
Thank you
Alessandro

Hey Alessandro, yep I created SpaceFX to figure out how much code I can share between desktop and mobile and I‘m pleased with the result. It really depends on your knowledge, your time and of course the app you have in mind. Ad long as you don‘t need anything very platform specific it should work fine with JavaFX. For me the main advantage was the fact that I can simply run the same code in my IDE that also runs on the mobile device but that‘s the same for the other xplatform frameworks. So I think in the end it really depends on how familiar you are with the technology. For me JavaFX is really productive, I habe not a lot of time to learn new stuff but that might be different for you. Ciao, Gerrit

Thank you for the answer. It would be a quite generic app, without any
particular platform specific requirements, and particular hardware needs
neither. I'm familiar with Java and I used JavaFX for my latest project - a
desktop application, and I liked it! But also, I could take the time to
learn something new as well. So, conclusion, I will peek into the other
options as well and give them a try, and see which one gives me the best
feeling. Thank you again, also for building TilesFX and making it
accessible, it's very useful and well-built. Cheers!
On Tue, May 19, 2020 at 7:04 PM Gerrit Grunwald<EMAIL_ADDRESS>wrote:

Hey Alessandro, yep I created SpaceFX to figure out how much code I can
share between desktop and mobile and I‘m pleased with the result. It really
depends on your knowledge, your time and of course the app you have in
mind. Ad long as you don‘t need anything very platform specific it should
work fine with JavaFX. For me the main advantage was the fact that I can
simply run the same code in my IDE that also runs on the mobile device but
that‘s the same for the other xplatform frameworks. So I think in the end
it really depends on how familiar you are with the technology. For me
JavaFX is really productive, I habe not a lot of time to learn new stuff
but that might be different for you. Ciao, Gerrit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HanSolo/tilesfx/issues/94#issuecomment-630953805, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZPG74S7UXRCPZFCDMPX63RSK33TANCNFSM4M662G7A
.


Update stable version in repo from 0.6.6 to 0.6.7

Think about update stable version to 0.6.7
Version: stable=0.6.6 (51 days old) => latest=0.6.7 (15 days old)
Installs: stable=115 (52.27%), latest=79 (35.91%), total=220
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!
Do not close this issue manually as a new issue will be created if condition for update still exists
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.6.7 but the current stable version is already 0.6.7.
So this issue should be closed.
@mcm1957 for evidence


notification infinite scroll issue

What does this PR?
"load more" button is no more showing.
fetch notifications by infinite scroll.
Steps to reproduce
click on notification icon to see all notifications.
scroll towards the bottom and observe that infinite scroll is working.
Issue number
fixes #1049
Screenshots/Video
https://user-images.githubusercontent.com/106739598/199214028-ea2b8db9-6b7c-439d-8b95-e7fea4c59caf.mp4

@MTSaeed Looking good, for some reason on mobile view and sometimes desktop view, end of list new fetching doesn't work. Can you check height of list also? because we have added css top some padding, it is moving entire modal bottom and last items not visible and maybe sometimes confusing scrolling detection?!


Unable to test JDK12 OpenJ9 builds

Following is encountered when attempting to run tests (either through Grinder job or the Test_openjdk job) against OpenJDK12+OpenJ9 builds ...
10:22:36  AUTO_DETECT is turned on
10:22:36  ant -f ./src/build_envInfo.xml -DJAVA_BIN=/home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdkbinary/j2sdk-image/bin -DJAVAC=/home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdkbinary/j2sdk-image/bin/javac
10:22:36  $ ssh-agent
10:22:37  Buildfile: /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/build_envInfo.xml
10:22:40
10:22:40  build:
10:22:40
10:22:40  clean:
10:22:40
10:22:40  init:
10:22:40      [mkdir] Created dir: /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/bin
10:22:40
10:22:40  compile:
10:22:40       [echo] Ant version is Apache Ant(TM) version 1.10.5 compiled on July 10 2018
10:22:40       [echo] ============COMPILER SETTINGS============
10:22:40       [echo] ===fork:				yes
10:22:40       [echo] ===debug:				on
10:22:41      [javac] Compiling 2 source files to /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/bin
10:22:44
10:22:44  dist:
10:22:44        [jar] Building jar: /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/EnvDetector.jar
10:22:45
10:22:45  run:
10:22:45       [java] System.getProperty('os.name')=Linux
10:22:45       [java]
10:22:45       [java] System.getProperty('os.arch')=amd64
10:22:45       [java]
10:22:45       [java] System.getProperty('java.fullversion')=12+32-201903051003
10:22:45       [java] JRE 12 Linux amd64-64-Bit Compressed References 20190305_21 (JIT enabled, AOT enabled)
10:22:45       [java] OpenJ9   - 01be53f65
10:22:45       [java] OMR      - 845a895b
10:22:45       [java] JCL      - 3371a09453 based on jdk-12+32
10:22:45       [java]
10:22:45       [java] System.getProperty('sun.arch.data.model')=64
10:22:45       [java]
10:22:45       [java] System.getProperty('java.vm.vendor')=AdoptOpenJDK
10:22:45       [java]
10:22:45
10:22:45  clean:
10:22:45     [delete] Deleting directory /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/bin
10:22:45     [delete] Deleting: /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/src/EnvDetector.jar
10:22:45
10:22:45  BUILD SUCCESSFUL
10:22:45  Total time: 7 seconds
10:22:45  make -f makeGen.mk AUTO_DETECT=on
10:22:45  make[1]: Entering directory '/home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig'
10:22:45  /home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig/envSettings.mk:63: *** DETECTED_JDK_IMPL value is hotspot, settled JDK_IMPL value is openj9. JDK_IMPL value does not match. Please reset or unset JDK_IMPL.  Stop.
10:22:45  make[1]: Leaving directory '/home/jenkins/workspace/openjdk12_j9_openjdktest_x86-64_linux/openjdk-tests/TestConfig'
10:22:45  run_configure.mk:37: recipe for target 'testconfig' failed
10:22:45  make: *** [testconfig] Error 2

This is blocking testing of the build output from the JDK12 pipelines being developed.

Example job failure - https://ci.adoptopenjdk.net/view/Test_openjdk/job/openjdk12_j9_openjdktest_x86-64_linux/7/consoleText
Example job failure - consoleText.txt

We should raise an openjdk-build issue, jdk8/jdk11 return java.vendor as "openj9", but jdk12 builds return "adoptopenjdk", which, because we have switched to auto-detecting JDK_IMPL, this is the underlying cause of this failure.

Closing this test item, as the fix will happen in build repo under https://github.com/AdoptOpenJDK/openjdk-build/issues/942 .

@karianna FYA - I think we made an explicit decision to start using adoptopenjdk as the vendor didn't we? Related: https://github.com/AdoptOpenJDK/openjdk-build/issues/935

Whoops - Shelley closed this while I was drafting my reply

Apologies @sxa555 !  Perhaps we can discuss in the build issue, but essentially we need an easy way to determine difference between implementations built at Adopt (which presumably could include straight openjdk-hotspot, openjdk-openj9, corretto, sapmachine, etc).

@lumpfish is currently doing some investigation a couple of desks down from me and will hopefully report in the build issue :-)

Sounds good, worst case, if takes a while to correct the build issue, we can turn AUTO_DETECT=off in testing.


Force Update of Task on VSTS Instances

Hi
I'm not sure if this is the right place to ask. I uploaded a Task yesterday which turned out to be broken. After that I uploaded a fix for the problem, however people still are stuck with the previous (broken) version of the task and it seems that VSTS is not updating it. (see as well the issue on github here: https://github.com/huserben/TfsExtensions/issues/66#issuecomment-381877070)
Do you know when VSTS updates the task/how it can be forced to update?

Sorry I just figured out the problem, apparently I forgot to update the task versions themselves and only updated the version of the extension. That explains why it ain't updating the task.


Test needs to contain assertion for null

https://github.com/softlayer/sl-ember-components/blob/d1cb16dc178d9406339e046e5cf87a6545c66757/tests/unit/components/sl-tooltip-test.js#L38
https://github.com/softlayer/sl-ember-components/blob/d1cb16dc178d9406339e046e5cf87a6545c66757/tests/unit/components/sl-tooltip-test.js#L175

picking this up, as it is related to #397


Await of TakePhotoAsync never returns after photo is taken

Make sure you follow all of the setup directions before posting an issue: https://github.com/jamesmontemagno/MediaPlugin#important-permission-information
If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
NOTE: Android Emulator
This code is reached, the camera opens, I click to snap the photo then the await never returns and the code never continues.
var file = await CrossMedia.Current.TakePhotoAsync(new Plugin.Media.Abstractions.StoreCameraMediaOptions
{
Directory = "Sample",
Name = "test.jpg"
});
Version Number of Plugin: v3.1.3
Device Tested On: n/a
Simulator Tested On:  Nexus 7 (API 26)
Version of VS: 2017  (.NET 4.7)
Version of Xamarin: Xamarin Forms <IP_ADDRESS>0
Versions of other things you are using: n/a
Steps to reproduce the Behavior
Followed your readme to the letter. I run my application and the camera opens when execute the ICommand of the button. I click the capture button of the camera and the photo snaps. I click the checkmark in the camera app to accept the photo and the camera closes and nothing happens. The code I referenced above doesn't return and execution doesn't continue.
Expected Behavior
Await call to finish and move on to next line in your example:
                    if (file == null)
                        return;

Actual Behavior
Nothing happens. Never returns from await.
Code snippet
                    await CrossMedia.Current.Initialize();

                    if (!CrossMedia.Current.IsCameraAvailable || !CrossMedia.Current.IsTakePhotoSupported)
                    {
                        //DisplayAlert("No Camera", ":( No camera available.", "OK");
                        return;
                    }

                    var file = await CrossMedia.Current.TakePhotoAsync(new Plugin.Media.Abstractions.StoreCameraMediaOptions
                    {
                        Directory = "Sample",
                        Name = "test.jpg"
                    });

                    if (file == null)
                        return;

Screenshots

So in my experience it looks as if this was never resolved?


cast interface error when input has a struct

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[x] Foundryup

What version of Foundry are you on?
forge 0.2.0 (736e602 2022-09-18T00:05:01.134898Z)
What command(s) is the bug in?
cast interface
Operating System
macOS (Apple Silicon)
Describe the bug
Running cast interface with the following json:
{
  "abi": [
    {
      "inputs": [
        {
          "components": [
            {
              "internalType": "string",
              "name": "name",
              "type": "string"
            }
          ],
          "internalType": "struct Contract.Setup",
          "name": "structSetup",
          "type": "tuple"
        },
        {
          "internalType": "address",
          "name": "guard",
          "type": "address"
        }
      ],
      "name": "setup",
      "outputs": [],
      "stateMutability": "payable",
      "type": "function"
    }
  ]
}

gives the error an error occurred when formatting an argument. Seems like the struct input is causing the error.
Might be related to #3260.

closed in https://github.com/foundry-rs/foundry/pull/3263 - could you verify that the fix works @hexzerodev ?

@gakonst that fixed it 👍 Cheers!


Add max_read_iterations and character_delay_µs

This change goes with the PR for libabbaurora.

Converted to draft, was testing it this morning and it seems to crash


@ParcelClass doesn't work for class in separate module with annotated constructor parameter

If I create two modules (app and library) and try to process models in library module from app using ParcelClass annotation, then everything works up until my model has a parameter annotated with any annotation. Then Parceler fails with
error: Parceler: No corresponding property found for constructor parameter arg0
error: Parceler: No corresponding property found for constructor parameter arg1
error: Parceler: No corresponding property found for constructor parameter arg2
...

Ah, you'll most likely need to annotate the constructor parameters with @ParcelProperty.  Java discards the names of constructor and method arguments after compilation, unfortunately.

That's what I do now. But why does the version without annotation work, then?

Is this still an issue for you @lwasylkowski ?

Yes, as soon as class in the other module has any annotation, every constructor parameter requires ParcelProperty annotation as well.
I've been told it's javac issue, but I can't tell why the annotation changes anything

Hmm, I'm trying to reproduce this without success.  What version of Parceler are you using?  Can you provide a minimal example project of this failing?

Sure. https://github.com/lwasylkowski/parceler_report_237 Try adding and removing the annotation for ctor parameter in OtherModuleClassWithString and building app module. The weird naming is because initially I thought this is Kotlin issue, and Parceler would complain when there was String parameter for a class. Turns out it's just that Kotlin was adding nullability annotations which triggered this issue.

Ok, this is weird... if you remove the @Depreciated annotation, then parceler is able to pair the constructor inputs to the getter properties.

That's exactly the issue. https://youtrack.jetbrains.com/issue/KT-16792 There's also some discussion here, Yan suggests it's a javac bug

Looks like the related kotlin issue is resolved.  If not feel free to reopen.


Replace stsci.sphere with spherical_geometry; Add missing dependencies

NOTE There has been a minor documentation issue for a while. Looks like spherical_geometry.skyline.Skyline should be stsci.skypac.skyline.Skyline.

This PR broke stsci.skypac - see https://github.com/spacetelescope/spherical_geometry/issues/137

What would be an appropriate label name that has the opposite meaning to "enhancement"?


[dx] Default version doesn't work for mobile builds out of the box

The default version used for generated projects uses 0.0.0 by default, which is not allowed in mobile (at least Android) builds. This adds friction to seeing the first android build, as you have to see the build fail, go edit a file, and then go to rebuild. A reasonable version would be 0.1.0 i believe.

You must change the version in tauri.conf.json. The default value 0.0.0 is not allowed for Android package and must be at least 0.0.1.`

tauri info:
[✔] Environment
    - OS: Mac OS 14.6.0 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.80.0 (051478957 2024-07-21)
    ✔ cargo: 1.80.0 (376290515 2024-07-16)
    ✔ rustup: 1.27.1 (2024-04-24)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 20.16.0
    - pnpm: 9.6.0
    - npm: 10.8.1

[-] Packages
    - tauri [RUST]: 2.0.0-rc.0
    - tauri-build [RUST]: 2.0.0-rc.0
    - wry [RUST]: 0.41.0
    - tao [RUST]: 0.28.1
    - tauri-cli [RUST]: 2.0.0-rc.1
    - @tauri-apps/api [NPM]: 2.0.0-rc.0
    - @tauri-apps/cli [NPM]: 2.0.0-rc.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - bundler: Vite

@chippers 0.1.0 as initial version makes a lot of sense.
Not only is this the version set by cargo when creating a new project, but it would also make sense from a semantic versioning perspective.


Look into Sedona's Join Algorithm

https://github.com/apache/sedona/pull/979
https://github.com/apache/sedona/pull/979/commits/62ee1a07539fafbb745428207da374a8c773b7b6

Seems like Sedona converts raster to a polygon by doing a convex hull (function) and then joining it with vector data. No complex algorithm found so far. There does not seem to be anything for filtering pixel values during the join.
We could look into how it further processes "PixelRecords"


Master admob

Changes

Added Admob adapter
Changed startTracking method to accept only ViewGroup instead of View

👍

👍

u all can kiss my ass....

Coverage increased (+0.2%) to 12.667% when pulling 54bf14e2bc870d0738dd048ba49f98443c115111 on master_admob into 597f7920a4978e6ff2ece8354c9d581ab418130a on master.

👍

Coverage increased (+0.2%) to 12.657% when pulling 4827df828e474d8ad34d51beee10743a2b8da461 on master_admob into 597f7920a4978e6ff2ece8354c9d581ab418130a on master.

Coverage increased (+0.2%) to 12.657% when pulling dce56fa02a8d50e4d7c40be9749438468ab92a60 on master_admob into 597f7920a4978e6ff2ece8354c9d581ab418130a on master.

This got reviewed and approved, merging


Interesting observation with predictions: Blacklist update

I was testing prediction of CTCF in GM12878 on chr1. I noticed that there are several regions of repeating and uniformly distributed predictions near the centromeres. This could indicate problematic repeat regions that are consistently causing issues. This also might be related to the repeats that David Kelley blacklisted in his PLOS com bio paper.

I noticed there was a discrepancy between our ENCODE blacklist and the blacklist available from the Boyle Lab. This blacklist has some of the segmental duplication regions accounted for whereas the basis for our current blacklist Anshul ENCODE Blacklist does not have those included. I will be generating statistics and updating our current blacklist in the next few days. The current files that are going to be used for the new blacklist can be found here: maxATAC Blacklist Files.

There are some differences in the coverage based on the source of the data. Our maxATAC V2 blacklist has the most coverage, because it includes high signal regions identified by Boyle in addition to the other genomic features that we curated. The final coverage is ~8.3% of the hg38 genome has unreliable signal regions.
ENCFF356LFX.bed:
 	 Number of Intervals: 910
 	 Total bps covered: 71,570,285
 	 Percent hg38 covered: 2.17%
hg38-blacklist.v2.bed:
 	 Number of Intervals: 636
 	 Total bps covered: 227,162,400
 	 Percent hg38 covered: 6.886%
hg38_centromeres.bed:
 	 Number of Intervals: 109
 	 Total bps covered: 59,546,786
 	 Percent hg38 covered: 1.805%
hg38_gaps.bed:
 	 Number of Intervals: 827
 	 Total bps covered: 161,348,343
 	 Percent hg38 covered: 4.891%
hg38_maxatac_blacklist.bed:
 	 Number of Intervals: 376
 	 Total bps covered: 217,585,970
 	 Percent hg38 covered: 6.596%
hg38_maxatac_blacklist_V2.bed:
 	 Number of Intervals: 1667
 	 Total bps covered: 275,198,132
 	 Percent hg38 covered: 8.342%
hg38_segmental_dups_chrM.bed:
 	 Number of Intervals: 12
 	 Total bps covered: 36,418
 	 Percent hg38 covered: 0.001%


What’s your experience like so far with this?

I assume you’ve been using this for a project, @paf31. What’s your experience been like so far? Trade offs? What was good, bad, or surprising?
I am still interested in exploring it for scripting. Just limited in time.

Hi Chris!
So far, the experience has been good. I have been trying it out with some low priority ideas I've had, and it's generally been satisfying to use.
The biggest downside I've noticed is a lack of generality - everything currently operates effectively in a ReaderT r IO, which is mostly fine, but excludes some obvious use cases like non-determinism or continuations, without some tricks which might not be semantically what you want. The original version worked with any monad, but you needed MonadFix for recursion, which would also have excluded some useful monads. Even a fully general monadic interpreter is less interesting than something like HOAS or CCCs, where there are even more interesting examples that we could compile to, e.g. automatic differentiation or incremental computations. And really, those are the examples that make the idea most compelling - anything you can do with a IO-based interpreter could probably be done just as easily with a service integration rather than an embedded DSL. I'd like to see if there's any good way to get that level of generality without complicating the API too much. I imagine the simplest approach would be to have a handful of different interpreters in different styles, and not aim to have them be interoperable in any way.
Also, performance - obviously, I've done nothing to optimize this yet, and there's a lot of low hanging fruit. I should first work on adding a benchmark suite (along with more tests). The back-and-forth between Haskell and interpreted PureScript in the core libraries, especially in type-class heavy code, can incur a large performance penalty, and I'm not sure if it'd be easy to improve that. The most obvious solution is to expose more functions as FFI primitives, without the level of polymorphism that the current standard libraries provide.

Thanks for the summary, it gives me a good indication of your priorities.
One wacky idea that’s springs to mind is when Edward Kmett compiled his DSL out to a JIT’d language (or bytecode) and then wrote an interpreter in the DSL for the DSL which was automatically optimized by the JIT. (https://m.youtube.com/watch?v=25RmUl88jSw) While we’re mentioning fun ways to interpret a language, that is.

Thanks for the summary, it gives me a good indication of your priorities.
One wacky idea that’s springs to mind is when Edward Kmett compiled his DSL out to a JIT’d language (or bytecode) and then wrote an interpreter in the DSL for the DSL which was automatically optimized by the JIT. (https://m.youtube.com/watch?v=25RmUl88jSw) While we’re mentioning fun ways to interpret a language, that is.

Actually on looking at it again, it’s not how I remember it. He’s using Truffle.