DepRL expects gym but MyoSuite uses the newer gymnasium

This is the depRL example
from myosuite.utils import gym
import deprl

# we can pass arguments to the environments here
env = gym.make('myoLegWalk-v0', reset_type='random')
policy = deprl.load_baseline(env)
obs = env.reset()
for i in range(1000):
    env.mj_render()
    action = policy(obs)
    obs, *_ = env.step(action)
env.close()

When running it I get
python test.py
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/pygame/pkgdata.py:25: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  from pkg_resources import resource_stream, resource_exists
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/pkg_resources/__init__.py:3154: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('mpl_toolkits')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
  declare_namespace(pkg)
pygame 2.6.0 (SDL 2.28.4, Python 3.8.19)
Hello from the pygame community. https://www.pygame.org/contribute.html
MyoSuite:> Registering Myo Envs
Traceback (most recent call last):
  File "test.py", line 2, in <module>
    import deprl
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/deprl/__init__.py", line 1, in <module>
    from . import custom_agents, custom_mpo_torch, custom_trainer
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/deprl/custom_agents.py", line 3, in <module>
    from .dep_controller import DEP
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/deprl/dep_controller.py", line 5, in <module>
    import gym
ModuleNotFoundError: No module named 'gym'

because it expects gym, when pip installing gym I get another error about shapes not matching so I think there's a lot more broken

Hi @MittelmanDaniel , thanks for raising this issue. Can you please shre more info on which version of MyoSuite, OS and gym you are testing?

Hi Daniel,
Deprl should work with gymnasium. Can you share all versions that Vittorio mentioned?

@Vittorio-Caggiano @P-Schumacher
Hi!
I am on ubuntu 22.04, I have myosuite 2.7.0 because I just did pip install -U myosuite roughly one hour ago.
I have deprl 0.3.2 I just did pip install deprl

To add on when running the myochallenge example
from myosuite.utils import gym
# Include the locomotion track environment, uncomment to select the manipulation challenge
env = gym.make('myoChallengeRunTrackP1-v0')
#env = gym.make('myoChallengeBimanual-v0')

env.reset()

# Repeat 1000 time steps
for _ in range(1000):

    # Activate mujoco rendering window
    env.mj_render()

    # Get observation from the envrionment, details are described in the above docs
    obs = env.get_obs()
    print(type(obs))
    current_time = obs['time']
    #print(current_time)

    # Take random actions
    action = env.action_space.sample()

    # Environment provides feedback on action
    next_obs, reward, terminated, truncated, info = env.step(action)

    # Reset training if env is terminated
    if terminated:
        next_obs, info = env.reset()

I get
MyoSuite:> Registering Myo Envs
    MyoSuite: A contact-rich simulation suite for musculoskeletal motor control
        Vittorio Caggiano, Huawei Wang, Guillaume Durandau, Massimo Sartori, Vikash Kumar
        L4DC-2019 | https://sites.google.com/view/myosuite

/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/gymnasium/utils/passive_env_checker.py:159: UserWarning: WARN: The obs returned by the `reset()` method is not within the observation space.
  logger.warn(f"{pre} is not within the observation space.")
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/gymnasium/core.py:311: UserWarning: WARN: env.mj_render to get variables from other wrappers is deprecated and will be removed in v1.0, to get this variable you can do `env.unwrapped.mj_render` for environment variables or `env.get_wrapper_attr('mj_render')` that will search the reminding wrappers.
  logger.warn(
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/gymnasium/core.py:311: UserWarning: WARN: env.get_obs to get variables from other wrappers is deprecated and will be removed in v1.0, to get this variable you can do `env.unwrapped.get_obs` for environment variables or `env.get_wrapper_attr('get_obs')` that will search the reminding wrappers.
  logger.warn(
Traceback (most recent call last):
  File "test.py", line 18, in <module>
    current_time = obs['time']
IndexError: only integers, slices (`:`), ellipsis (`...`), numpy.newaxis (`None`) and integer or boolean arrays are valid indices
Exception ignored in: <function Renderer.__del__ at 0x7d42c5cc18b0>
Traceback (most recent call last):
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/myosuite/renderer/renderer.py", line 142, in __del__
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.8/site-packages/myosuite/renderer/mj_renderer.py", line 158, in close
NameError: name 'quit' is not defined

Because env is returned as an np array but is being accessed like a dict.
Maybe there's something extremely wrong with my environment but it works with just stable baselines and gymnasium envs

Hey!
can you try again with python==3.10 ? I suspect that an older python version forces an older deprl version which is not compatible with the newest myosuite version.
After installing deprl with python 3.10, please run
pip list | grep deprl
and tell me the deprl version number.
Best,
Pierre

Ohh that may be the case I was on python 3.8 because that's the one the installation docs suggest
https://myosuite.readthedocs.io/en/latest/install.html
I'll check when I get back to my laptop
Thanks so much!

@P-Schumacher
Good news it finds dep!
Bad news it throws a shapes dont match error
(MyoSuite) daniel@daniel-XPS-17-9720:~/myo_challenge$ python test.py
MyoSuite:> Registering Myo Envs
    MyoSuite: A contact-rich simulation suite for musculoskeletal motor control
        Vittorio Caggiano, Huawei Wang, Guillaume Durandau, Massimo Sartori, Vikash Kumar
        L4DC-2019 | https://sites.google.com/view/myosuite

/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/gymnasium/core.py:311: UserWarning: WARN: env.env_name to get variables from other wrappers is deprecated and will be removed in v1.0, to get this variable you can do `env.unwrapped.env_name` for environment variables or `env.get_wrapper_attr('env_name')` that will search the reminding wrappers.
  logger.warn(
Load LegWalk Baseline
Loading experiment from ./baselines_DEPRL/myoLegWalk_20230514/myoLeg/checkpoints
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/utils/load_utils.py:33: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  return torch.load(os.path.join(checkpoint_path, "time.pt"))
Found only the policy checkpoint, the previous run was likely only run with  <'full_save': False>
Only loading policy checkpoint.
Stochastic Switch-DEP. Paper version.

Loading weights from ./baselines_DEPRL/myoLegWalk_20230514/myoLeg/checkpoints/step_150000000.pt
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/vendor/tonic/torch/agents/agent.py:170: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  state_dict = torch.load(path, map_location=self.device)
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/gymnasium/core.py:311: UserWarning: WARN: env.mj_render to get variables from other wrappers is deprecated and will be removed in v1.0, to get this variable you can do `env.unwrapped.mj_render` for environment variables or `env.get_wrapper_attr('mj_render')` that will search the reminding wrappers.
  logger.warn(
/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/vendor/tonic/torch/agents/mpo.py:90: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at ../torch/csrc/utils/tensor_new.cpp:278.)
  observations = torch.as_tensor(observations, dtype=torch.float32)
Traceback (most recent call last):
  File "/home/daniel/myo_challenge/test.py", line 10, in <module>
    action = policy(obs)
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/vendor/tonic/agents/agent.py", line 42, in __call__
    return self.test_step(observation, steps=1e6)
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/custom_agents.py", line 57, in test_step
    return super().test_step(observations, steps)
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/vendor/tonic/torch/agents/mpo.py", line 61, in test_step
    return self._test_step(observations).detach().cpu().numpy()
  File "/home/daniel/anaconda3/envs/MyoSuite/lib/python3.10/site-packages/deprl/vendor/tonic/torch/agents/mpo.py", line 90, in _test_step
    observations = torch.as_tensor(observations, dtype=torch.float32)
ValueError: expected sequence of length 403 at dim 1 (got 0)

This is the depRL version
deprl                                0.5.0

okay, it seems the documentation is outdated on this
Run it like this:
from myosuite.utils import gym
import deprl
from deprl import env_wrappers
import time

# we can pass arguments to the environments here
env = gym.make('myoLegWalk-v0', reset_type='random')
env = env_wrappers.GymWrapper(env)
policy = deprl.load_baseline(env)
obs = env.reset()
for i in range(1000):
    env.mj_render()
    action = policy(obs)
    obs, *_ = env.step(action)
    time.sleep(0.01)
env.close()

The deprl gymwrapper had to be added.

It works now thank you :)


fixed using single quotes

Fixed the possibility of using single quoted strings as text, like:
{ 	  "en": { 	    "title": "Hi, I'm {name}!" 	  } }

Thanks!


Integer keys

The function SimpleCacheTest::invalidKeys() line 58 lists (integer) 2 as invalid key, which leads to a problem:

PHP will read ['0' => 'value0'] as ['value0'] making it impossible to determine whether 0 was an integer or a string at declaration time. Reference: PHP documentation on arrays, stating A key may be either an integer or a string. If a key is the standard representation of an integer, it will be interpreted as such (i.e. "8" will be interpreted as 8, while "08" will be interpreted as "08").
Considering point 1, the test case SimpleCacheTest::testSetMultipleWithIntegerArrayKey() line 225 effectively considers 0 a valid key, contradicting SimpleCacheTest::invalidKeys().
The problem already seems to have surfaced, because there is a fix in SimpleCacheTest::testSetMultipleInvalidKeys() on line 461. However, this does not solve the problem, because the tests using the SimpleCacheTest::invalidKeys() function still consider (integer) 2 an invalid key.

To solve the problem, either integers are considered keys, or the the test case SimpleCacheTest::testSetMultipleWithIntegerArrayKey() line 225 uses another key than '0'.

The current behavior is correct. See my comment for #92

Closing as explained in #92


Show breadcrumb match count and add option to only show bread crumbs matching the filter text

When using the bread crumbs you can start typing to search through the methods. This seems to begin filtering the results however it doesn't remove non matches only brings the topmost match into view.
This can be misleading since you can't see the other matches are even know if there are any and wrongly conclude those items showing must be the ONLY matches when in fact there might be other matching methods farther down the list.
I show example video below where I am searching for a method named onChangedActionType
As I being to type onChanged it shows three method but they are not thing one I'm looking for.  I only could find it by scrolling down or using the arrow keys to see it.
This is why I think the minimal solution is to add a match count number.
A better solution might be to not show items that do not match. I could see the issue with people forgetting that have entered search text and thinking the file has less methods that they can see but I will leave that up to designers and it's why I think it should be optional so people can pick what they like.
Video: http://recordit.co/bqJNC8t7KD

This is fixed in latest insiders by adopting the new tree widget. That allows to toggle between filter and find


SSLProfile Creation, global SSL Policy, and client-cert via AGIC

Is your feature request related to a problem? Please describe.
We have an application gateway today that is fully managed by AGIC after its initial creation EXCEPT the SSLProfile we are using for a listener doing mTLS.  We are able to properly reference a created SSLProfile with this annotation without issue:
appgw.ingress.kubernetes.io/appgw-ssl-profile: "<my-profile-name>"

We also want to ensure the SSL Policy for the entire App GW is set to one we specify.  We would need toe able to upload CA Certs to the App GW.
Describe the solution you'd like
We would like to be able to create a SSLProfile from AGIC.  This would require the ability to upload client Certs to the App GW.  The SSL Profile would then be able to name those certificates and also be able to set a listener specific SSL Policy.  It would also be good to be able to configure the global SSL Policy for the Application Gateway.
Something along the following would be pretty neat for client Certs:
apiVersion: appgw.ingress.azure.io/v1beta1
kind: AzureApplicationGatewayClientCerts
metadata:
  name: my-client-certs-name
  namespace: my-namespace
spec:
  clientCert:
  - name: CA-Cert1
    certFile: <path-to-file>
  - name: CA-Cert2
    certContent: <base64 encoded cert or something like that>
  - name: CA-Cert3
    someOtherUploadMethod: <content>

We could then create an SSL Profile with something like this:
apiVersion: appgw.ingress.azure.io/v1beta1
kind: AzureApplicationGatewaySslProfile
metadata:
  name: my-ssl-profile-name
  namespace: my-namespace
spec:
  clientAuthentication:
  - certName: CA-Cert1
  - certName: CA-Cert2

  sslPolicy:
    enableListenerSpecificPolicy: <true/false, defaults to false>
    type: {Custom, CustomV2, Predefined}
    PolicyName: {AppGwSslPolicy20150501, AppGwSslPolicy20170401, AppGwSslPolicy20170401S, AppGwSslPolicy20220101, AppGwSslPolicy20220101S}
    minProtocolVersion: {TLSv1_0, TLSv1_1, TLSv1_2, TLSv1_3}
    cipherSuites:
    - TLS_RSA_WITH_AES_256_CBC_SHA256
    - TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384
    - etc

This loosely relates to:
https://github.com/Azure/application-gateway-kubernetes-ingress/issues/954
https://github.com/Azure/application-gateway-kubernetes-ingress/issues/773


Licence

Looks like you currently have MIT licence for this repo. It would be advantageous to have one licence for all the planetarypy projects. We should update this to BSD or change pvl to MIT. I'm fine with either.
We should also get a cookiecutter package together for planetarypy. I can put that together if you'd like.

Great suggestion, please do!  @NikhilKalige FYI !!!

Cookiecutter setup here: https://github.com/planetarypy/cookiecutter-pypackage. Feedback appreciated!

Looks good enough to get started, but we should make a point to remember changes we'd benefit from making.

@nikhilkalige, go ahead and use this.

Thanks +wtolson


pubspec version constraints need updating

We're on flutter 3.16.9 and noticed builds were failing when adding this package. It appears that you've already had issues with this before https://github.com/rebelappstudio/accessibility_tools/issues/52 So it might be useful to update your version constraints so flutter picks an older version for outdated flutter builds:
https://github.com/rebelappstudio/accessibility_tools/issues/52#issuecomment-2331628053
I think bumping this to 3.22 should help! Not sure if you can retroactively apply this to previous versions too though...

Hi Thomas, thanks for reporting an issue! Let's bump version constrains to 3.22. I'll also bump Dart version to 3.0.0

Not sure if you can retroactively apply this to previous versions too though...

I'm pretty sure it's impossible :( Would setting specific (older) package version in your pubspec.yaml help? Something like 1.0.1 or 2.0.0?

Fixed in #55 and released in v2.2.2

We've got 2.0.1 working for us with no issue :) Thanks!


文档可以改下，不是3.8以上就行

PS D:\voice\Retrieval-based-Voice-Conversion-WebUI-main\Retrieval-based-Voice-Conversion-WebUI-main> poetry install
The currently activated Python version 3.11.3 is not supported by the project (^3.8,<3.11).
Trying to find and use a compatible version.

im using v3.10.11 and its currently working


Is it possible to add some reference to a type definitions file to the original source code?

Imagine a CSS Modules class like this:
styles.css:
.title {
    color: green;
}

I'm using a plugin for my bundler that will generate this type definitions file:
styles.css.d.ts:
declare const styles: {
  readonly "title": string;
};
export = styles;

Now I can do this:
application.ts:
import styles from './styles.css';
console.log(styles.title); // output css modules generated class name

My question is, is there any kind of reference I could place before the readonly "title": string; line to tell TypeScript "hey, that title property is located on file styles.css at line 1" so that when Alt+Click the styles.title reference I can go to styles.css instead of styles.css.d.ts?

TypeScript supports source maps and will follow them if it finds one for a .d.ts file.

@RyanCavanaugh
Thanks, exactly what I was looking for. However, since my .d.ts files are created manually (not by TypeScript compiler), can you point me to any resource explaining how to manually create source maps?

Source maps are a quasistandard maintained by Google and others. You can try the  https://github.com/mozilla/source-map library as a starter

Thank you :)


verify email endpoint

Hi,
The examples provide usage for setting up the login, register, forgot and reset password endpoints. Does it also support email verification and enrollment functionality?

Hi,
Sorry, e-mail verification is not yet supported.

Workaround:

In public_zone.pages, add a page to the effect of:

{ "name": "verify_email", "custom_template": "templates/verify_email", "route_params": ["verificationToken"], "zoneless: true }

    One thing that is unclear is that `zoneless` is applied to a page after it has been added to an `application` level zone. May I ask why this is an attribute as opposed to a zone separate to `free_`, `public_` or `private_`?

2. Add corresponding  `.html` and `.js` pages for the custom template.  The html template can be empty, the js can be derived from https://gentlenode.com/journal/meteor-20-verify-an-email-with-meteor-accounts/42

    The following example stays on the `/verify_email` page, but `Router.go('/');` can be added to redirect back to the homepage inside the `verifyEmail` callback and the no token clause. You can also augment this with an alerts package.
    ```
    Template.VerifyEmail.created = function() {
        var verificationToken = Router.current().params.verificationToken;
        if (verificationToken) {
            Accounts.verifyEmail(verificationToken, function (err) {
                if (err) {
                    if (err.message === 'Verify email link expired [403]') {
                        console.log('verification link has expired.');
                    }
                    else {
                        console.log(err.message);
                    }
                }
                else {
                    console.log('email address has been confirmed.');
                }
            });
        }
        else {
            console.log('no verification token provided.');
        }
    };

In server_startup code or source file, add the following to change the generated URL for this accounts endpoint:
    Accounts.urls.verifyEmail = function (token) {
        return Meteor.absoluteUrl('verify_email/' + token);
    };

nice! thank you @solace :smiley:

@solace thank you!
"Verify e-mail" functionality is now added and will be available in next version (0.9.43).
@solace @Billybobbonnet  About zoneless - since version 0.9.42, application with user accounts can have all three zones: public, private and free (it was not possible before). "photosharing" example is updated and demonstrates how to add pages into free zone and make it accessible for both authenticated and non-authenticated users.
zoneless property will be removed in near future.

I am closing this issue (fixed in 0.9.43).
If you still find issues related to e-mail verification, feel free to reopen it.

@perak @solace Can we re-open this issue? I'm using version 0.9.54 and even though the app said that the verification email is being send I never received it (checked my spam folder as well). Did I miss something that needs to be set in order to get this to work?

@a4xrbj1 are you doing it in your localhost? If so, e-mail is not sent indeed - it's only printed to your server console (so you can copy & paste e-mail verification URL from terminal). This is for testing only.
If you upload (deploy) your application using meteor deploy ... command, e-mails will be actually sent (meteor hosting sets it up automatically for you).
If you deploy your application to 3rd party service (VPS?) then you are responsible to set proper environment variables and setup e-mail server.

BTW, this is how Meteor works - not related to meteor-kitchen. Anyway, above explanation can be useful to other users in the future.

Thanks @perak - I couldn't find this in the documentation (Getting started) or the API reference at all. It would be nice if this hint is added there (next to some basic information about this feature).

You're correct, all the detailed email information is in the terminal. However, when I copy the URL and paste it into my browser I get a "Page not found". Both for the URL with the token as well as for http://localhost:3000/verify_email/

Well... it is in Meteor docs: http://docs.meteor.com/#/full/email

If MAIL_URL is not set (eg, when running your application locally), Email.send outputs the message to standard output instead.

But, I believe you are using meteor-kitchen to learn Meteor, and maybe I should make my docs in that way (current docs are actually opposite - assumed is that meteor-kitchen user is highly familiar with meteor and uses meteor-kitchen to bootstrap/prototype app...).

Please paste here what you copied and pasted to your browser.
URL usually looks something like this:
http://localhost:3000/verify_email/d0SRIQziQXMgKntxWH6HTaoEfMA24rOyVPwQXTFmmAw

http://localhost:3000/verify_email/2LWnxS-nIlKO-_REFrYS4ElJveA4Y-KJs0BoMOZKvX2

And... it doesn't work? Saying "page not found?". Hum... strange.

Yes, it was still running. The "page not found" was actually displayed in the body of the page

@a4xrbj1 ah... I understand now. you need to add "verify e-mail" page to your application.
In the same place where are your login and register pages, you need to add page with following attributes:
{
  "name": "verify_email",
  "template": "verify_email",
  "route_params": ["verifyEmailToken"]
}

That's it. :)

Ooops - I found a bug - it cannot be done from gui - it doesn't show verify_email in template:  dropdown.
Fixed and will be available in next meteor-kitchen version.
Until then, what you can do is to go to "Edit source" page, and paste this code (for example, after your "register" page:
				{
					"name": "verify_email",
					"template": "verify_email",
					"route_params": [
						"verifyEmailToken"
					],
					"type": "page"
				},

Thanks for the fix...
I placed this code in my .json file,
example-accounts.json
and it created the new page and correct routes
I can confirm it worked.  Much appreciated.  I'll do more testing on production site today.
~ Rob


adding social images to docs layout

Removing old social images
Updating refs for social images where already included
Adding additional meta data to docs layout

closes #132

Works fine in Slack 😄


Reproducing HF model Summaries

I'm trying to reproduce the summaries generated by HF models, namely Phi-2, and Llama 3.2-1B instruct, since the result I'm getting following the described prompt / pipeline is not close to the one in the leaderboard. Comparing the summary generation im getting with the one in the hf dataset, I found that theres a large difference. One thing those models are sturggling with for example that I don't see in HF dataset was sentence reptition.
So my question is is generation config used for hugginface models ? I'm currently using the text-gerenation pipelien setting do_sample=False (as i found mentioned in another issue that 0 temperature was used), if code can be provided it could be also helpeful to see whats giving raise to this variation in results.
Edit, I also can't reproduce the leadeboard score for Llama 3.2-1B using the generated summaries in the HF dataset linked, this is because
1 - I don't know what threshold was used to determine if a response is hallucinated / consisten or not edit : I will use top_k = 1
2 - The dataset includes the ommited samples  (length is 1006 and not 850ish)

Hi @Noor-Nizar, thanks for your interest in our leaderboard.
For the summary generation:

Phi-2 is accessed via LiteLLM Python SDK HuggingFace API with temperature=0.0.
Llama 3.2 1B is accessed via Together AI chat endpoint with temperature=0 and max_tokens=250.

Please note that the leaderboard is scored based on the HHEM-2.1 model, which excels in hallucination detection and is not open-sourced. While we offer HHEM-2.1-Open as an open-source alternative, it may produce slightly different results.


Docker Terminology

What is the proper docker terminology in order to pass the required flags into the container in order to get the container running? I attempted:
docker container run -it [image] ./discord-influx --influxdb-url [URL] --influxdb-org [org] --influxdb-bucket [bucketname]
However was given an error of:
Error: unknown command "./discord-influx" for "discord-influx"
Run 'discord-influx --help' for usage.
unknown command "./discord-influx" for "discord-influx"
Are there Environment Variables instead for me to put the required info in instead?
Thanks!

@that-llama-in-a-tuxedo This should work:
docker run -it [image] --influxdb-url [URL] --influxdb-org [org] --influxdb-bucket [bucketname]

Are there Environment Variables instead for me to put the required info in instead?

At the moment, only flags work for these options.


Not working on vscode 1.78.2 (windows 10)

command not found.

Did you try updating with extenison? Please check what version do you have. Also check that you have all settings in place, recrlently there was support for Azure added, it might be that settings need to be fixed

I'm fully UpToDate.
All setting (api key) are in place.
Please check on your side.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Maxim Saplin @.>
Sent: Friday, June 2, 2023 10:23:41 AM
To: maxim-saplin/cptX @.>
Cc: elich11 @.>; Author @.>
Subject: Re: [maxim-saplin/cptX] Not working on vscode 1.78.2 (windows 10) (Issue #1)
Did you try updating with extenison? Please check what version do you have. Also check that you have all settings in place, recrlently there was support for Azure added, it might be that settings need to be fixed
—
Reply to this email directly, view it on GitHubhttps://github.com/maxim-saplin/cptX/issues/1#issuecomment-1573277834, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE4MWRGELNJFFFD6VABUCLDXJGIH3ANCNFSM6AAAAAAYX5DJNI.
You are receiving this because you authored the thread.Message ID: @.***>

The error popup, is there any detail shown when you click expand arrow?

Sorry, no detail
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Maxim Saplin @.>
Sent: Friday, June 2, 2023 10:42:57 AM
To: maxim-saplin/cptX @.>
Cc: elich11 @.>; Author @.>
Subject: Re: [maxim-saplin/cptX] Not working on vscode 1.78.2 (windows 10) (Issue #1)
The error popup, is there any detail shown when you click expand arrow?
—
Reply to this email directly, view it on GitHubhttps://github.com/maxim-saplin/cptX/issues/1#issuecomment-1573299427, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE4MWRGMZWE4SR3XH4JYPRDXJGKQDANCNFSM6AAAAAAYX5DJNI.
You are receiving this because you authored the thread.Message ID: @.***>

Won't be able to check for another few hours. In the meantime you can try uninstallomg the extension, reloadong VSCode and installing it again

Tried on my Windows 11 VM, indeed right after update had same issue. Uninstalled extension, closed VSCode, opened VSCode and installed extension once again, typed command and picked one - started working. My suspect is that there could be a command cached which was no longer available from updated extension

Works!
Thanks,
Eli
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows
From: Maxim @.>
Sent: Friday, June 2, 2023 3:58 PM
To: @.>
Cc: @.>; @.>
Subject: Re: [maxim-saplin/cptX] Not working on vscode 1.78.2 (windows 10) (Issue #1)
Tried on my Windows 11 VM, indeed right after update had same issue. Uninstalled extension, closed VSCode, opened VSCode and installed extension once again, typed command and picked one - started working. My suspect is that there could be a command cached which was no longer available from updated extension
—
Reply to this email directly, view it on GitHubhttps://github.com/maxim-saplin/cptX/issues/1#issuecomment-1573694220, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE4MWRGHGLPGXMTU3PAXFT3XJHPNNANCNFSM6AAAAAAYX5DJNI.
You are receiving this because you authored the thread.Message ID: @.***>


More test units

Pull Request Test Coverage Report for Build 505

226 of 226 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 87.416%

Totals

Change from base Build 504:
0.4%

Covered Lines:
2216

Relevant Lines:
2535

💛  - Coveralls


Only submit entities if they belongs to us or new ones

We have to check if the entity - we would like to archive - has an accession belongs to us.
If yes we could go and send it to the archive.
If not we should skip it from the archiving process, but we have to report the list of entities not been submitted to the user at the end of archiving and the reason why they have not been archived.
Acceptance criteria:

We should be able to archive new entities without any problem and get back an accession at the end of the archiving process.
We should be able to archive an existing entity that already has an accession AND belongs to us without any problem and get back an accession at the end of the archiving process.
We should not archive entities that already accessioned and not belongs to us. In this case we should return a report to the user why that entity has not been archived at the end of the archiving process.

BioSamples:  it is easy to check whether a sample belongs to us: get the sample by accession and verify that the domain field equals to our AAP domain.
BioStudies: I started a conversation regarding to this problem with their dev team as it seams to me their downloadable JSON payload is not containing any ownership information.
ENA: get the ENA entity from the archive and validate the center_name attribute an the entity.

hey @ke4  - let's rename etc the ticket so that it could be finalised this sprint (only the achievable task)

But we might have a project made up of new samples that we will get accessions for and old samples where the accession has been provided
We can link "other peoples" samples to BioStudies and ENA submission we create so really this should be an expected failure

even better, we could check if a sample that has an accession is "owned" by us before we try to send changes to it's metadata.

in this case the HCA metadata and biosamples metadata might be out of sync, is that okay?

@staticmethod
def filter_samples(samples: List[ConvertedEntity]):
    for sample in samples:
        accession = get_accession_from_hca_sample(sample, ERROR_KEY)
        biosample = get_biosample_from_accession(accession)
        if biosample.domain != config.AAP_API_DOMAIN:
            samples.remove(sample)


Add infos and fix to README.md

Add some import to make origin of objects / module used explicit
Fix #L118:

In [46]: received_base = client.object.get(hash)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-46-8171539461b3> in <module>
----> 1 received_base = client.object.get(hash)

TypeError: get() missing 1 required positional argument: 'object_id'

thanks for these updates Cyril! the readme def needs some updating, so thanks for adding some enhancements and fixes. other than the one comment I made, this lgtm!


Could not find gem 'tzinfo (~> 1.2)' in locally installed gems.

I have installed all "tzinfo", "~> 1.2" and yet I still get this error.

Have you tried running bundle install as the error suggests?
This is a problem with your Jekyll setup and not an issue with tzinfo. I'd therefore suggest posting a question on Jekyll Talk.
I'm closing this as a duplicate of #115.

I tried running bundle install and it gives me this error
An error occurred while installing http_parser.rb (0.6.0), and Bundler cannot
continue

I tried the solution from #115  and it didn't work for me.

http_parser.rb is a (recursive) dependency of Jekyll (and unrelated to tzinfo). I'd look at solving that issue first.


Improvement: Draw map ourselves

If #13 works, we can generate the map dynamically instead of manually. This would decrease the manual workload.

@lkappeler is working on this :)


[Feat]: Display References in a Tree View. (Research)

Is your feature request related to a problem?
Large Language Models work the best when they have the right contextual code. While embedding matching and analyzer helps us automatically extract relevant contextual code from the project, it is not always reliable.
This is why FlutterGPT has an "Add to Reference" feature that allows users to manually mark certain selected code as reference. This reference will later be attached in the prompt.
However, the current way is not the best UX. References take up half of the editor window and are displayed in full.

Describe the solution that you'd like
The ideal experience would be to display the reference somewhere:

Easily findable.
Mentioned in summarised manner.
Ability for user to visit the actual reference code when tapped.
Ability for user to remove one or few references.

It looks like that the Tree View API offered by VSCODE comes quite close to this requirement.

Describe alternatives that you have considered
No response
Additional Information
No response
Acceptance Criteria
The current acceptance criteria only require R&D to see if it's feasible to show references in the tree view and what does the final UX look like.
Once we have a clear idea, we can discuss and see if we want to proceed with this method or find other better options.

Hi @samyakkkk I would like to take up this task

Thanks, assigned.


Added free resources for becoming a front end developer

This course is from Meta (Facebook)

we are not adding coursera paid courses

It's a not a paid course, it's available for free with financial aid and
auditing the course. Can you mark it as hacktoberfest-accepted. I am just
one PR away in completing hacktoberfest
On Mon, Oct 31, 2022, 17:01 Avinash Singh @.***> wrote:

we are not adding coursera paid courses
—
Reply to this email directly, view it on GitHub
https://github.com/avinash201199/Free-courses-with-Certificates/pull/389#issuecomment-1296956199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ6N7GWNGRQATOKH37P7MHLWF6U23ANCNFSM6AAAAAARSMAICU
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

and it's take 16 days to approve , we are only adding free course with certificates though you are one pr away and today is the last day so I'm accepting your pr ! all the best


Problems on the server with displaying the schedule

Checking the week number:

I check the schedule for Thursday using the week_schedule command:

Everything is correct, the schedule corresponds!
I check the schedule for Thursday using the built-in keyboard:

The schedule is incorrect. The third pair of practice will only be in weeks 4 and 6.

I don’t understand what this is connected with. When testing the bot locally, there are no problems. Also, after restarting the bot on the server, the problems disappear. I have attached a screenshot of the local bot, it displays everything correctly:

Maybe it's worth changing the hosting and writing more tests to display the schedule?

@Ilanaya What do you think might be causing this problem and how can it be caught?

I'll check today

What do you mean under restarting the bot? If this fixes a problem we need to know what exactly happens on restart

Also, after restarting the bot on the server, the problems disappear.

I do this via GUI:

I can also look at the build logs and application logs. I'm interested in the second one, but there are no errors there, which is very strange.

I restarted and everything worked correctly, you can verify this by going to Bot

I don't know what was the problem. Maybe something was outdated on the server.
But we definitely need to work on bot's architecture and add more tests

Can this issue be closed? Or you are currently working on tests or smth?
If the problem is reproduced again you can always reopen


Training logs

Hi,
Thank you for providing codes for such great work.
I am wondering when you will release the training logs, it would be great to have the training logs as a reference and check the details of some hyper-parameters.

Hello,
Thank you for your question! What hyperparameters are you looking for? Hyperparameters are defined in the config directory.


Require better screen transition

Fade in out transition between screen gives very weird user experience

Nav host can be updated to this
NavHost(
navController = navController,
startDestination = NotifyScreens.Notes.name,
modifier = Modifier
.padding(it),
enterTransition = {
slideInVertically(
tween(500), initialOffsetY = { -it })
},
popEnterTransition = {
slideInVertically(
tween(500), initialOffsetY = { it })
}
)

Fade in out transition between screen gives very weird user experience

Yeah your are right.

Nav host can be updated to this NavHost( navController = navController, startDestination = NotifyScreens.Notes.name, modifier = Modifier .padding(it), enterTransition = { slideInVertically( tween(500), initialOffsetY = { -it }) }, popEnterTransition = { slideInVertically( tween(500), initialOffsetY = { it }) } )

Can you give some demo video or any resource after implementing this code in BottomNav Bar just wanted to see how it looks.

@aritra-tech A sample code looks like this:
 setContent {
            val navController = rememberNavController()

            NavHost(
                navController = navController,
                startDestination = Screen.Home.route,
            ) {
                composable(
                    route = Screen.Home.route,
                    enterTransition = { fadeIn() },
                ) {
                    HomeScreen(navController = navController)
                }

Check out the documentation for more information.


Raise node update events when focus changes

The cross-platform change tracking code now raises NodeUpdated events when the focus moves, but only if the node in question wasn't already updated as part of the tree update. This allows platform adapters to look for platform-specific property changes on the previously and newly focused nodes, again without duplicate events.

Approved!


After using the action, the cache is stil empty.

Hi, thanks for providing such a cool project 😄
I tried to set up the action and integrate it into our build. However, I am having some trouble to get it to work, I am not sure if the issue is me (most probably), the action, or buildcache itself.
I made this PR to enable the usage on my project:
https://github.com/continental/ecal/pull/503/files
For CMake I am enabling buildcache with CMake variables, like suggested in the buildcache docs.
I build first the branch, then the PR. I assumed that the branch build would store the Cache. Then the PR build could use.
On my Ubuntu build, it says a cache has been stored, but then none was retrieved in the consecutive build.
On Windows, it seems that even after the build, the cache is empty.
Are there any suggestions for me or other resources? Do additional steps need to be taken to successfully restore the cache? Under what circumstances does it work on Window?
Thanks a lot!

Hi there - unfortunately I have none of the answers to your questions :sweat_smile: - I have never used on windows, and when I hit issues I always just turned on debugging then used upload artifacts github action to upload the log so I could inspect

Hi thanks for you help.
Ok, so problem on windows is, it's not using Ninja as CMake generator.
For ubuntu, I get these logs:
buildcache: saving cache with key "buildcache-Ubuntu20-2022-02-01T17:25:38.033Z"
buildcache: no cache for key buildcache-Ubuntu20-2022-02-01T19:22:11.611Z or buildcache-Ubuntu20 - cold cache or invalid key
buildcache: saving cache with key "buildcache-Ubuntu20-2022-02-01T19:34:38.621Z"

Notice that the times are all different. How does it work? Or I shouldn't give a name for the cache?
    - name: BuildCache
      uses: mikehardy/buildcache-action@v1
      with:
        cache_key: Ubuntu20

Hmm - I don't think the cache keys being different is bad, rather I think that is actually important otherwise the cache is never updated since they are immutable, and it's saved against three keys at the same time with increasing specificity - in your case as "buildcache", "buildcache-Ubuntu20" then "buildcache-Ubuntu20-"
https://github.com/mikehardy/buildcache-action/blob/312ec4b4a3b351017a0cdc43456310f3a101a735/src/lib.ts#L70-L95
Clearly something isn't working but I don't think it's the cache keys. That said I do not think PR or branch caches are used in main branch caches, however you indicate you are building branch then PR and to my understanding that should cache

ah ok, I see. Then I will try some more. I expected it to work across branches.


fix: prevent form submit on clicking on translation

@almontasser Thanks for the fix! That solvs the unwanted closing issue.


Callback for Commands / atomic sets of Attribute updates? (CON-392)

Is there any mechanism in the Espressif SDK for Matter to directly receive Matter Commands or to receive atomic sets of Attribute updates generated from a Command?
For example, imagine that a light switch issues a MoveToLevelWithOnOff (Cluster 0x0008, Command 0x04). As best I can tell, this is only propagated through the esp-matter SDK with a series of callbacks to app_attribute_update_cb. The CurrentLevel Attribute (0x0008, 0x0000) may come through first, followed by the RemainingTime Attribute (0x0008, 0x0001) which describes how long the level transition should take. In this scenario, if the application reacted to the CurrentLevel change first before knowing that a transition time was coming later, it will have executed the MoveToLevelWithOnOff Command incorrectly.
I see that the Matter SDK has MatterPreCommandReceivedCallback and MatterPostCommandReceivedCallback callbacks that could partially be used to reconstruct the incoming command. But these do not seem to be incorporated into the esp-matter SDK. Nor do they contain all of the data fields that come in as part of the Command.
So, what is the esp-matter SDK approved way to capture these command transaction semantics?

esp-matter is not doing that, that is simply how the CHIP SDK works. The state machines are here:
https://github.com/project-chip/connectedhomeip/tree/master/src/app/clusters/level-control
https://github.com/project-chip/connectedhomeip/tree/master/src/app/clusters/on-off-server

The Espressif’s SDK for Matter handles the commands being executed by calling the corresponding
callbacks in the Matter repository.
For e.g.: As mentioned, for the command MoveToLeveLWithOnOff, it is handled by calling
emberAfLevelControlClusterMoveToLevelWithOnOffCallback in the CHIP repository.
The state machine for level control is implemented in CHIP and in the case of the example command specified above, as per implementation, it takes into account the transition time when updating the current level attribute.
In case of attributes being updated, the attribute update callback is triggered for each attribute that is being updated .We receive the callbacks with types PRE_UPDATE and POST_UPDATE before and after the attribute is updated
respectively.
In case you want to implement a custom cluster which has some attributes being updated on the receipt of a custom command ,you can use the callback with typePRE_UPDATE to perform some action before updation and update the attributes and based on the attributes changed in PRE_UPDATE, perform required actions in POST_UPDATE.

Can we close this issue if your issue is resolved?

Yes. Thank you both for your assistance.


Support cmake-format

It maybe not directly related, but usually people check native code with clang-format (this script) and cmake files with cmake-format. The tools have relatively similar interface and both of them don't support scanning folders :) While this scripts solves is for clang-format, it would be nice to have the similar wrapper on cmake-format.
Possible options:

Completely different script/repo
Integrate the possibility to run both tools from this script

I think latter will be useful for a lot of people, so there won't be the need to different wrappers and there can be one to rule them all.

I would first try to see if cmake-format cannot it himself, unlike clang-format, it is already coded in python, and the project is smaller, younger, so it's easier to add features to it.


Inserts on common_token_values can cause contention

Describe the bug
When testing with 200 ingestion threads processing new resources, congestion was observed on inserts into the new common_token_values table (issue #1366) .
To Reproduce
Generate a new set of synthetic patient data in COS.
Run fhir-bucket to load the new data.
Observe ingestion performance.
Expected behavior
Better throughput scaling as ingestion thread-count increases.
Additional context
Contention occurs when the same new reference value appears in more than one bundle, and those bundles are processed in parallel. It takes a few seconds to process each bundle and this means that the insert into common_token_values may be blocked for a while until the competing transaction commits. The solution is to capture all the required inserts into this table for the whole transaction, then insert them just prior to the transaction commit. This means fewer round-trips to the database, as well as significantly reducing the amount of time the exclusive locks are held.

Moving to Review Q/A? please move back if not appropriate


Engineering System Improvements for Java

This tracks the Engineering System Improvements for Java for the Azure SDK team

Closing as all associated issues have been completed


Add github-merit-badger worflow

Description
Adding the POC of github-merit-badger
The labels as part of badges are auto created.
Sample tested PR: https://github.com/prudhvigodithi/opensearch-build/pull/51
This github-merit-badger would give better insights to repo maintainers and would enhance the open source community experience.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3305 (4573782) into main (eabc6da) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #3305   +/-   ##
=======================================
  Coverage   91.74%   91.74%
=======================================
  Files         172      172
  Lines        4991     4991
=======================================
  Hits         4579     4579
  Misses        412      412

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I'm open for discussing and changing the thresholds and badges.
badges: '[beginning-contributor,repeat-contributor,valued-contributor,admired-contributor,star-contributor,distinguished-contributor]'
thresholds: '[0,3,6,13,25,50]'

Thank you

@bbarani @gaiksaya  should we add days option? Like number of days the badge is valid?

@bbarani @gaiksaya should we add days option? Like number of days the badge is valid?

Can come as an enhancement. This looks good for now. Will see how this goes and how the community responds.

Can come as an enhancement. This looks good for now. Will see how this goes and how the community responds.

Thanks @gaiksaya if you are good, can you add your approval?

Sorry, I'm late to the party -- are these values that can be set per repo?  Or is it a project-wide thing?
I also like first-time (or maybe new) rather than beginner, but I'm fine with either :)

Hey @CEHENKLE yes it can be configured per repo and we can provider a set of guidelines for the entire org and following are badge categories added to this repo.
first-time-contributor: 0
repeat-contributor: 3
valued-contributor: 6
seasoned-contributor: 13
all-star-contributor: 25
distinguished-contributor: 50

Thanks!  Can we add a set of defaults and let the repos override them?
/C

Thanks! Can we add a set of defaults and let the repos override them?

Yes @CEHENKLE that is possible, we should start a META issue with campaign and allow the repo teams to override the badge list. @bbarani @dblock

super cool :)

this is awesome @prudhvigodithi


Update capitalization of copy to match new guidelines

Fixed Issues
$https://github.com/Expensify/Expensify/issues/169061
Tests
Click around on the site both in spanish and english and make sure the capitalization of the copy is correct. We should only capitalize names, the beginning of sentences and acronyms.
QA Steps
Same, but please try to be on the lookout for any capitalization we missed
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[x] Android

Screenshots

🚀 Deployed to staging by @MonilBhavsar in version: 1.0.88-3 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

FYI: we changed the Terms of Service back to capitalized here because it's a title, rather than a sentence.


In Carbon, remove Cookie Notice in Canada Footer as was done in v18

Description:
In December 2019, a request came to DDS to remove the pop up Cookie Notice that appears only on Canada pages.  DDS fixed that in the v18 code but now DDS needs to do the same in Carbon code.  URX page is now live in Carbon and we noticed that the pop-up is displaying on a URX page viewed in Canada.
-->

Is this a feature request : New request

Is this issue related to a specific component?  Footer

What did you expect to happen? What happened instead? What would you like to see changed?
(see above)

What browser are you working in?
all are impacted

What version of the IBM.com Library are you using?
Would have to check what URX page is using.

Steps to reproduce the issue

Step one: Go to https://www.ibm.com/account/reg/ca-en/signup?formid=urx-19776
Step two: See that the Cookie Notice appears at bottom of form.

Notes: to see implementation working correctly go to any v18 page in Canada and note that Cookie Notice does not appear.
To be resolved:  For now in Carbon, let's leave Ad Choices below the Footer until Design has had a chance to resolve final design in Carbon.

@ljcarot is this still happening?

@ljcarot moving this issue to sprint 20-06.  Just wondering if you have an update?

@Jeff Chew can you check if this is the correct cookie notice that should be displaying on the canada version of URX form?

We never implemented the cookie notice in IBM.com Library. This implementation appears to be from TrustArc.


dotc: add test for struct pointers

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba73cc...3908614. Read the comment docs.


Dev gubalasu frontdoor microsoft.network 2021 06 01

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@rkmanda Most of the comments you left are from the apis copied over from older versions. Can you look at the changes after this commit: "94a0eed75ff04f4305c0bda0d046137910ed9484". For easy viewing for you, these are the only changes as part of the new API version. https://github.com/Azure/azure-rest-api-specs/pull/19578/files/c4fdf0c76beb83e0c376b48bdc8d03741ced24df..9daa5372baa14a3ba23ec47dde489efe5fed612c

@rkmanda I have responded to your comments that are related to the changes I am introducing in this current api version.

@rkmanda Can you please take a look at this now

@gubalasu I am the reviewer for the week, so will take it from here. I think there are two items to update, provisioning state enum values and a nit one.

@gubalasu I am the reviewer for the week, so will take it from here. I think there are two items to update, provisioning state enum values and a nit one.

@jorgecotillo Updated the Provisioning state enum values one. Regarding the other nit one, I wouldnt want to update that name now, as it has been copied over from older version and it will break the older version if I make this update. Can you please look at this now

@ArcturusZhang Can you take a look at this PR to get it merged


Image upload / insert not working

I'm having some difficulty getting the image inserting to work with the editor. When I click the upload button on the modal that pops up, I get the file picker and choose an image. After this however, nothing happens. I don't see any request going to the server or anything else going on. No errors showing up either. Am I missing something or is this currently not implemented yet?

It's not implemented but it's on freatures list :)


Exception not handled when browser could not be open

Exception not handled when browser could not be open, in this case, should ask user to do authorization manually(copy URL to open it in browser).

verified with 1.0.0-rc.10


distinguish scope name for each grammar

I think each grammar could/should have a unique scopeName? My particular use case is for configuring file-types package for directly matching languages based on filename

Did you mean to change the name of the scope on grammars/ect_html.cson to etc3? It would then be the same as grammars/ect_html3.cson

No I didn't - sorry, that was just a careless mistake - I've updated this now

This pull request would be very comfortable to have in the main branch


Apoorv Saxena's Last Request

Issue

Description

Checklist

[ ] Added contributor object in ascending order in contributors.json
[ ] Github action build passing
[ ] No merge conflicts

@Apoorv-Saxena It looks like you deleted all the contributors. Please re-do the changes


User should be informed when restore is invalid

Presently a user could run the following command
ark restore create threefiddy which is a backup that doesn't exist.
Immediately the user receives the following feedback
Restore request "fiddy-20180203165643" submitted successfully.
Run `ark restore describe fiddy-20180203165643` for more details.

Which is true in the technical sense (i.e. the request was successfully completed), but deceiving in that the process will 100% fail because it's a non-existent backup.
For the sake of UX, the command should at the very least check the backup exists, as a circuit breaker, before a success message is displayed on screen.

@rdodev we did change the text from "restore created successfully" to "restore request submitted successfully", and we also made it a validation error if the backup doesn't exist (which you can see with ark restore describe). We can do 1 more thing - as part of ark restore create, we can check if the backup exists, and immediately return an error. Would that work for you?

Yes, as I suggest at the end of the issue above, an existence check on the backup and using that as a circuit breaker would be very helpful to the user and the restore request isn't submitted at all, think of it as a pre-flight check.


Making CVXPY flow faster

Hi!
First off, thanks for creating such an amazing library. I have been using it for a few days now. I am using it for solving a linear programming problem.
My problem consists of a target vector and a set of vectors (let's name it base set). The target vector is assumed to be a linear combination of some of the base set vectors plus noise. The goal is to determine the weights (scalar term in the linear combination) corresponding to each of the base set vectors that would minimize the MSE between the weighted linear combination of base and target vector.
The optimization objective is to minimize MSE between the predicted vector (obtained by using weights determined by cvxpy) and the target vector. The constraints are that each weight should be between 0 and 1, and should sum to 1.
This process becomes time-consuming as the size of base set increases (it can contain about 2000 base vectors). Each vector is of size (3000,1). And in our case, we need to repeat this exercise for ~4000 different base sets/ targets
I have tried ECOS and SCS solvers, but with no major improvements in speed. I'm looking for suggestions/ approaches which can help speed up the above task.
Thanks

You could solve the 4000 different LPs in parallel. cvxpylayers has some functionality for doing this: https://github.com/cvxgrp/cvxpylayers,
but it would probably be easier to do yourself using Python multiprocessing.

corresponding to each of the base set vectors that would minimize the MSE between the weighted linear combination of base and target vector.

Have you tried using the OSQP solver? This might also improve the speed of each individual task. As @SteveDiamond mentioned, it might also be good to solve these in parallel.

@PartheshSoni for parallel computing you can use Dask. See https://github.com/cvxgrp/cvxpy/issues/1021.
I'm marking this issue as closed because its scope isn't well defined (beyond the suggestions made already).


Register fields are different for different roles

The fields of the form in /register vary depending on which role the user has.
At the moment it's the same for everyone

I think pr #39 fixes this issue, plz check :pray:


ServiceMonitors

Description of the change:
This PR adds a helper function to create ServiceMonitor objects by passing a metrics Service objects that already exist. The function does a check to makes sure the ServiceMonitor is registered within the cluster before creating the ServiceMonitor object.
Note: As this is just a helper function, I am not sure if we should add an end-to-end test as for that we need to deploy prometheus-operator as well. Let me know your thoughts.
Motivation for the change:
Closes https://github.com/operator-framework/operator-sdk/issues/789

@estroz @joelanford I addressed your comments can you please have another look, thank you!

@estroz @joelanford Pinging again as it's been a few days :)

@LiliC We might need to design a comprehensive e2e test to check if the metrics are exposed correctly and consumable by the prometheus-operator, but we can do that in another PR.

@hasbro17 Deal, opened https://github.com/operator-framework/operator-sdk/issues/855 for that! Best done after the general metrics PR is merged.


Passing constant instead of zero for mouseButton on mouse move

This is the fix described in #39.

Thanks! Doesn't seem to be any regression, does this resolve an issue for you?

Hmm, I thought it did, but when I try to run the tests again now I'm not able to reproduce any issues with mouse move on master. I think I might have just moved the mouse accidentally while the tests were running the first time, haha.

haha yeah, that happens. Hmm, well, this is technically right. I'll play around with it some.

I'm going to merge this, since it works either way, and kCGMouseButtonLeft looks better than 0.


Removes examples of unscalable sinks from documentation.

These sinks would only work on small data, and do not properly
handle failures.  Users should instead be encouraged to use the
builtin IOs or write their own following best practices documented
in the IO guides.
Incorporated some of the relevant information into the IO page.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

cc: @davidcavazos


Cell Tallies

Added cell tally functionality. Can define a cell in the input deck, and call mcdc.tally.cell_tally() to get the tally for the cell. It should properly output to the h5 file.
Verified it gave the same results as the sum of mesh tally cells using the new sphere_in_cube input deck - a homogeneous pure-fission sphere inside a pure-scattering cube.
(This is my first PR, hopefully I don't break everything!)

Thanks, @ethan-lame !
Note that the black formatting test failed. You can install black via pip or conda, and then do black . on the MC/DC top directory to reformat all the files changed. You can make this process automatic at every commit by (1) pip install pre-commit, and then (2) run the command pre-commit install on the top directory.
Note that the Numba regression tests failed. My recommendation to fix it is to go to MCDC/test/regression/azurv1 and run the test problem manually on Nubma mode, python input.py --mode=numba. It's going to take some time to run as it needs to compile. When it runs, it throws out error messages that would help fix it. Make the necessary fixes until the problem runs without error. Then you go to MCDC/test/regression/ and run python run.py --name=azurv1 --mode=numba to run the regression test only on the selected problem in Numba mode. If it passes, it means most probably the Numba problem has been fixed, and you can make the Git commit and push.

Thanks, Ethan!
This looks great. Ethan, let's move/copy some of the examples you created as part of the test/regression so that the new cell tally capability will automatically be regression tested as well.

I made minor edits and added little improvement other than the calling of the cell tally scoring in kernel.py.
This is good to merge.
 I'll just bypass the branch protections and merge it.)


Restructure endpoint doc

Purpose

Issues

Fixes #126

Maintainers: Check before merge

[x] Manual verification

@AmaliMatharaarachchi , please at these docs to the APIM 4.0.0 docs if applicable.


Contribute a project

Hi, Can I contribute by adding my hacktoberfest project as a part of your?
If it's ok I will work on it.
Thank you.

You can add a project and for more information check contribution.md


escape sequence in click-left action in custom/script

I'm using a module with "type = custom/script" with "exec = $HOME/.polybar/bin/updates" which works perfectly.
But in the "click-left" action in the same module my "$HOME/.polybar/bin/updates -d" gets executed as "* Executing shell command: $HOME/.polybar/bin/updates -d" which does not work due to the escape sequence.
As a workaround I'm currently using the absolute path but I thought this behavior is not expected.
polybar 2.3.5 on Archlinux with i3wm

Until it's been fixed you could use ~/ instead

Fixed by https://github.com/jaagr/polybar/commit/e9db3fab3a84a4ef8f360de15c60f052ef3dd56e


chunks/excludeChunks can match compilation.chunkNames

R: @developit @philipwalton @housseindjirdeh
Fixes #2717
workbox-webpack-plugin provides a way of allow/denylisting the assets in its precache manifest based on chunk names.
When making changes to the webpack plugin for the last major release, we started looking at the compilation.namedChunkGroups property to check for matches in chunks/excludeChunks. This neglects the fact that developers might also expect the names they provide to match against compilation.namedChunks (i.e. the actual chunk names, not the group names).
The code in this PR will still give preference to a match in compilation.namedChunkGroups (so it should be backwards-compatible), but for situations in which there's no match, it will fall back to checking compilation.namedChunks.

Thanks for taking the time to look at this, @developit!

Thanks for taking the time to look at this, @developit!


Error Mysql

Hello
I have 2 servers connected with the mysql database
that's it ss
https://prnt.sc/jqd7f8
Please help

That’s a warning, not an error.
The plugin should operate as normal.

Indeed, should be fine to ignore, although it might suggest that your server is lagging a bit.

The above change will fix the warning message from appearing.
However, it won't fix the underlying issue, which is that your MySQL server is taking a long time to respond.


[CI] Runs report for 8.x

Since Elasticsearch main is now 9.0.0, I created the 8.x branch. This Pull Request updates the GitHub Action for the report to run on 8.x too. Once 8.16 comes out, we'll branch it from 8.x and 8.x will be bumped to 8.17. Just like the old days.
For clients running these tests, we need to target the 8.x branch here for main on our clients, unless the 8.x branch is already created and you've bumped main to 9.0.0.

Since we're using SNAPSHOT versions I don't think that we definitely need this now :thinking:


C2D Docker

Breaking Changes proposed in this PR (requires other repos to be updated):

ComputeAsset interface (will require ocean.js updates) (https://github.com/oceanprotocol/ocean-node/pull/705/files#diff-136208859964be379b346a07cbf27655403475ab701c3f4d0d6f0fa4c37726e8R89)
Changes:  instead of having url, we have fileObject now, so we can support multiple types of non published assets
ComputeStartCommand interface  (will require ocean.js updates) (https://github.com/oceanprotocol/ocean-node/blob/d26a8c50a68ef4812de2291d3c2193b693a2015a/src/%40types/commands.ts#L159)
Changes:  instead of having dataset and additionalDatasets, we merged them all under datasets

Changes proposed in this PR:

new freeStartCompute and getComputeStreamableLogs commands
c2d using docker engine

All additional work should be based on PRs based against this one
Usage:
 export DOCKER_SOCKET_PATH='/var/run/docker.sock'

and then do a directCommand:
{
    "command": "freeStartCompute",
    "consumerAddress": "0xC7EC1970B09224B317c52d92f37F5e1E4fF6B687",
    "nonce": 1,
    "signature": "0x123",
    "datasets": [
        {
            "fileObject": {
                "type": "url",
                "url": "SOME_DATASET_URL",
                "method": "GET"
            }
        }
    ],
    "algorithm": {
        "fileObject": {
            "type": "url",
            "url": "SOME_ALGO_URL",
            "method": "GET"
        },
        "meta": {
            "container": {
                "image": "SOME_CONTAINER",
                "tag": "latest",
                "entrypoint": "python $ALGO'"
            }
        }
    }
}

Changes:  instead of having dataset and additionalDatasets, we merged them all under datasets

FYI, i've created a PR on Ocean JS:
https://github.com/oceanprotocol/ocean.js/issues/1867

Breaking Changes proposed in this PR (requires other repos to be updated):

ComputeAsset interface (will require ocean.js updates) (https://github.com/oceanprotocol/ocean-node/pull/705/files#diff-136208859964be379b346a07cbf27655403475ab701c3f4d0d6f0fa4c37726e8R89)
Changes:  instead of having url, we have fileObject now, so we can support multiple types of non published assets
ComputeStartCommand interface  (will require ocean.js updates) (https://github.com/oceanprotocol/ocean-node/blob/d26a8c50a68ef4812de2291d3c2193b693a2015a/src/%40types/commands.ts#L159
)
Changes:  instead of having dataset and additionalDatasets, we merged them all under datasets

Changes proposed in this PR:

new freeStartCompute and getComputeStreamableLogs commands
c2d using docker engine

All additional work should be based on PRs based against this one
Usage:
 export DOCKER_SOCKET_PATH='/var/run/docker.sock'

and then do a directCommand:
{
    "command": "freeStartCompute",
    "consumerAddress": "0xC7EC1970B09224B317c52d92f37F5e1E4fF6B687",
    "nonce": 1,
    "signature": "0x123",
    "datasets": [
        {
            "fileObject": {
                "type": "url",
                "url": "SOME_DATASET_URL",
                "method": "GET"
            }
        }
    ],
    "algorithm": {
        "fileObject": {
            "type": "url",
            "url": "SOME_ALGO_URL",
            "method": "GET"
        },
        "meta": {
            "container": {
                "image": "SOME_CONTAINER",
                "tag": "latest",
                "entrypoint": "python $ALGO'"
            }
        }
    }
}

Hi @alexcos20 , what if the 'fileObject' is not present on the datasets or on the algorithm ? We need to get it from the service files object? I mean, decrypt the service.files to get these right?
thanks

We should update the documentation to explain how this works and how to set it up.

I tried to test it via the directCommand endpoint but I found it causes the node to crash. I'll give it another go when it's marked as ready for review, as changes are still being made.

Update: it seems to work via the direct command now but I will do some more testing to see if there are any more bugs


manager: Allow user to attach a volume without frontend

If the user wants to revert to a previous snapshot for an existing volume, the frontend shouldn't be enabled since it can cause unnecessary issues on the block device level.
We should allow users to attach a volume without the frontend. And we should only allow reverting to happen in such case.

We can call the option [x]For maintenance for Attach. Essentially it attaches without a frontend.

@shuo-wu Can you document the API for @smallteeths ?

Now Attach operation in volume accepts two fields:

hostId. It's the same as before.
disableFrontend. This is a newly added field. The default value of this field should be false.

@smallteeths ^^

Validation: PASSED
Steps to test:

Create a volume, and attach it to a node with Maintenance checkbox Unchecked, mount it, write some data to it, and compute data's md5 checksum.

Expected Result: in Volume Detail page, Attached Node & Endpoint should contain information about the node that volume is attached to and attachment endpoint.

From Volume Detail page, Create a snapshot.
Write some another data to the volume, create another snapshot.
detach the volume from the node.
re-attach the volume to a node with Maintenance checkbox Checked

Expected Result: in Volume Detail page, Attached Node & Endpoint should be empty.

revert to the first snapshot
detach the volume from the node.
re-attach the volume to a node with Maintenance checkbox Unchecked, mount it and check data's checksum.

Expected result: data checksum should match checksum taken at the first snapshot.


Fix e2e tests

Hi, @bsacharski
I broke e2e tests, please, take a look.
I only added:
usermod -a -G www-data deployer

@antonmedv no problem I will have a look, though it'll have to wait till Monday. I have no access to any pc at the moment.

@antonmedv
I've checked the cause for the failure. When the deployer container tries to fetch http://server.test we get response 500 with following body:
/project # curl 'http://server.test'
<!-- The stream or file "/var/www/html/releases/2/storage/logs/laravel.log" could not be opened in append mode: failed to open stream: Permission denied (500 Internal Server Error) -->
...

I've checked the permissions inside the server container and got following:
root@d530c83d1125:/var/www/html/releases/2/storage# ls -la
total 20
drwxr-xr-x 5 deployer www-data 4096 Sep 27 17:34 .
drwxr-xr-x 3 deployer deployer 4096 Sep 27 17:34 ..
drwxr-xr-x 3 deployer www-data 4096 Sep 27 17:34 app
drwxr-xr-x 6 deployer www-data 4096 Sep 27 17:34 framework
drwxr-xr-x 2 deployer www-data 4096 Sep 27 17:34 logs

So the storage directory (alongside its subdirectories/files) is set ot be writable only by owner (the deployer user).
PHP works with thewww-data user, so it cannot write to log file, which causes the failure.
tl;dr; user www-data needs to be able to write to storage directory and its subdirectories.

Thanks a lot!


Error with the Preplexity AI API

Hi,
I sometimes use other LLMs through a custom API that supports the OpenAI API. I have no issues with Groq AI or Together AI. However, when I attempt to use the Preplexity AI API, I encounter the following error:
Error: 400 After the (optional) system message(s), user and assistant roles should be alternating.
I have also set the variable "vscode-openai.conversation-configuration.assistant-rules" to false, but I still receive the same error.
How can I resolve this issue?
Thanks.

That's a bad request error. Do you have any documentation I can check?

You may check the following link of Preplexity AI docs:
https://docs.perplexity.ai/docs/getting-started
I tried my API Key with python code and it works properly. You may use my API for debugging your code:
API Key: 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

Hi @kavehsfv
Thanks for all the help (and the key) greatly appreciate!
I've fixed the issues for perplexity and it now works with the custom model.
release: v1.6.5


generator/repo: set git branch for tests

Makes the generator/repo tests always run against the sdk-test branch of the generators repo, so tests don't break when the generators' master branch is updated.

@alexppxela done

@all, if you need to launch unit tests on another branch do not forget to cherry-pick 7893ca83152d6d4a4b02d150f25e537bfcec412e


Add zip and gzip MIMEs

As defined in http://www.iana.org/assignments/media-types/media-types.xhtml

@seanmonstar ping


BasicTokenizer: _run_strip_accents

Hello,
I noticed that BasicTokenizer runs _run_strip_accents by default and it's not parameterizable. Is it critical for training Electra? Is it OK to turn it off for training non-English models?
Thanks.

I don't think it is critical. We just used the same tokenization as BERT, which included the _run_strip_accents text normalization.


Broken Recordings link

The link to download recordings to be placed in TTCDist/recordings_21_11_12 doesn't seem to be working.
I found the paper on arxiv and wanted to test it out.

Seems to be working now. Thank you so much! I was really interested in the paper you've written.

Thank you!


Regarding Hacktober Fest 2022

@shubham7668 please assign an issue to me in order to make a valid PR for Hacktober Fest.

Kindly head over to https://github.com/shubham7668/WebDev
This repo has been excluded


[5.2] Fix filesystem unit test cleanup

Changes were applied in this order, see separate commits:

fixed removing the global file /foo/foo.txt
added more required cleanups
moved cleanup code in tearDown() method (which made first two changes obsolete)
all files and folders will be created in common subdirectory __DIR__/tmp

Forgot to fetch upstream changes (wasn't aware the filesystem tests are quite new). Will issue a new PR rebased on current 5.2.


VS Code shows this error, "Volar version is 1.0.3, but workplace vue-tsc version is 0.40.13, there may have different type checking  behavior"

This is showing UP on VS Code, what is this? is this going to be a problem or should I ignore this?

me too, commit with pic

https://github.com/johnsoncodehk/volar/issues/1950#issuecomment-1272245960


Add staticcheck Go linter

golint is deprecated and frozen (see
https://github.com/golang/go/issues/38968), and the recommended (albeit
not drop-in) replacement linter is @dominikh's staticcheck, which this
patch introduces.
The biggest difference I can see, other than different lint results, is
that staticcheck must operate at the module level
(https://github.com/dominikh/go-tools/issues/232), whereas
golint happily operated on individual files. I added the necessary
workaround.
I'm not sure how to run the unit test, and it appears to require either
a go.mod present, or running GO111MODULE=off staticcheck.

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/#no-pull-requests


[ISSUE-630][REFACTOR] Minor change of storage resource quota, include code style, comment unused code etc..

What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

ping @waitinfuture


When laral-ray required in composer, but laravel is not used, ray does not behave as expected

When laravel-ray is composer required, but ray() is run outside the laravel framework, strange things happen because ray() references the laravel version of ray, not the spatie/ray version of ray.
An example is that ray()->disable() does nothing. It does not disable ray, it also does not produce an error.
That explains why ray()->disable() did not change anything here:
Originally posted by @Polfo in https://github.com/spatie/laravel-ray/issues/148#issuecomment-775058169
Versions:
spatie/laravel-ray (1.12.6)
spatie/ray (1.19.4)
php 7.4.9

We recommend to only install laravel-ray in a Laravel app


Unavailable helm install with "--namespace' option

What happened:
I'm wanting to install an application to monitoring namespace, with helm3. For that, I specified monitoring as a namespace in the .pipe.yaml.
apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
  input:
    namespace: monitoring
    helmChart:
      repository: prometheus-community
      name: prometheus
      version: v11.15.0
    helmOptions:
      releaseName: prometheus
      valueFiles:
        - values.yaml
    helmVersion: 3.2.1

But it failed. It seems to not use helm's --namespace option.
Failed to apply manifest: name="prometheus-kube-state-metrics", kind="ServiceAccount", namespace="default", apiVersion="v1" (failed to apply: error: the namespace from the provided object "default" does not match the namespace "monitoring". You must pass '--namespace=default' to perform this operation.  (exit status 1))

What you expected to happen:
How to reproduce it:
Environment:

piped version: v0.6.0
control-plane version:
Others:

@nakabonne
Maybe I've figured out this issue's problem.
It seems like in TemplateLocalChart here
and TemplateRemoteChart here have not set namespace yet.
I have a simple fix here. Could you take a look ? (Already tested successfully on local development)
Thank you !!!!

@tnqv Hey, a big "thank you!" goes out to you! I'm on a trip now, hence I'll happy to take a look next week 😄
We'd love to incorporate your contributions as much as possible, so would you mind opening the PR in this pipe repository? (Thank you if you took care of it! you can feel free to open a PR whatever the content)

@tnqv I'm done checking that it can be installed properly, thank you!


interesting quirk with named currying

Just got bitten by this quirk, but not sure if it's a bug or if we should leave it alone... thoughts?
function foo({x,y,z}) {
	console.log(x,y,z);
}

var f = FPO.curryMultiple( {fn: foo, n: 3} );

f( {x:1,y:2} )( {x:4,z:3} );

What would you expect that output to be? I expected 1,2,3 since x was already curried in the first call, but the result is that x:4 effectively overrides (re-curries?) the x:1. That was surprising to me and caused me a bug.
Should named curry(..) and curryMultiple(..) restrict each input to only being specified once, the first time?
Partially related to #19

Should named curry(..) and curryMultiple(..) restrict each input to only being specified once, the first time?

Yes. Throw otherwise.

hmmmm, throw would sort of violate the current design practice of these methods. why is silently ignoring a bad thing?

Allow me to use your own arguments:

Just got bitten by this quirk

I expected 1,2,3 since x was already curried in the first call,

That was surprising to me and caused me a bug.

I wouldn't throw. I'd silently ignore OR ignore + print a warning/error in the console to inform users..... but, yes, it doesn't make sense to allow overriding a named arg that you've already passed in.


[1pt] PR: Add South Alaska to pre-clip vectors system

Resolves issue #1033 by adding Alaska-specific data to the FIM input folders and updating the pre-clip vector process to use the proper data and CRS when an Alaska HUC is detected. The -wbd flag was removed from the optional arguments of generate_pre_clip_fim_huc8. The WBD file path will now only be sourced from the bash_variables.env file. The bash_variables.env file has been updated to include the new Alaska-specific FIM input files.
Changes
clip_vectors_to_wbd.py

Replaced all CRS inputs with the huc_CRS variable, which is input based on whether the HUC is Alaska or CONUS. Previously, the default FIM projection was automatically assigned as the CRS (which had been retrieved from utils.shared_variables).

generate_pre_clip_fim_huc8.py

Added Alaska projection and links to the new Alaska data file paths that were added to bash_variables.env.
Removed the -wbd argument from the pre_clip_hucs_from_wbd function and made it so that the code gets the WBD path from  bash_variables.env.
Added logic to check whether the HUC is in Alaska and, if so, use the Alaska-specific HUC and input file paths.
Cleaned up the spelling and formatting of some comments

bash_variables.env

Added the Alaska-specific projection (EPSG:3338)
Added file paths for Alaska-specific data (see data changelog for list of new input data)

New Files
All paths are from the root /efs-drives/fim-dev-efs/fim-data/inputs/

/3dep_dems/10m_South_Alaska/23_11_07/FIM_3dep_dem_South_Alask_10m.vrt (derived by Rob)
/3dep_dems/10m_South_Alaska/23_11_07/DEM_Domain.gpkg (derived by Rob)
/nld_vectors/System_Routes_NLDFS_3338_230314.gpkg (System_Routes_NLDFS_xxxx_230314.gpkg, projected to EPSG:3338)
/nld_vectors/3d_nld_preprocessed_230314_3338.gpkg (3d_nld_preprocessed_230314.gpkg, projected to EPSG:3338)
/nld_vectors/Leveed_Areas_NLDFS_3338_230314.gpkg (Leveed_Areas_NLDFS_xxxx_230314.gpkg, projected to EPSG:3338)
/nwm_hydrofabric/nwm_catchments_alaska.gpkg (from NWM v3 Hydrofabric)
/nwm_hydrofabric/nwm_flows_alaska_nwmV3_ID.gpkg  (from NWM v3 Hydrofabric)
/nwm_hydrofabric/nwm_headwaters_alaska.gpkg (calculated using derive_headwaters.py)
/nwm_hydrofabric/nwm_waterbodies_alaska.gpkg (from NWM v3 Hydrofabric)
/wbd/WBD_National_South_Alaska.gpkg
/landsea/water_polygons_alaska.gpkg (landsea water polygons with  non-Alaska area removed and projected to EPSG:3338)
/huc_lists/SouthernAlaska_HUC8.lst (list of all southern Alaska HUCs)
/huc_lists/SouthernAlaska_subset_HUC8.lst (testing subset with 4 of the Alaska HUCs)
/huc_lists/dev_small_test_8_Alaska_and_CONUS.lst (testing subset with 4 of the Alaska HUCs and 4 CONUS HUCs)

Testing
This branch has been tested on the following HUC lists:

/huc_lists/SouthernAlaska_subset_HUC8.lst
/huc_lists/dev_small_test_4.lst
/huc_lists/dev_small_test_8_Alaska_and_CONUS.lst
/huc_lists/SouthernAlaska_HUC8.lst

Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

[x] Informative and human-readable title, using the format: [_pt] PR: <description>
[x] Links are provided if this PR resolves an issue, or depends on another other PR
[x] If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
[x] Changes are limited to a single goal (no scope creep)
[x] The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
[x] pre-commit hooks were run locally
[x] Any change in functionality is tested
[x] Passes all unit tests locally (inside interactive Docker container, at /foss_fim/, run: pytest unit_tests/)
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] CHANGELOG updated with template version number, e.g. 4.x.x.x
[x] Reviewers requested
[x] Add yourself as an assignee in the PR  as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

[ ] Update CHANGELOG with latest version number and merge date
[ ] Update the Citation.cff file to reflect the latest version number in the CHANGELOG
[ ] If applicable, update README with major alterations

Awesome.  Can I get a list of new input sources that are required for this new  tool to be run?  I can get any new input (or adjusted input) files propagated to all enviros before this is merged so it is ready to go. :)


Fixed #8 exception when Response is empty

In addition:

Updated agera to v1.3.0, retrofit to v2.2.0, support libs to v25

Related issue: https://github.com/google/agera/issues/144

@ernstsson According to Agera's design, Result.absent().succeeded() return false, but for example, the DELETE request is actually a success.
So, I am thinking of putting the body into the Result is appropriate?
And how about Result.success(value) accept null value?

@ernstsson There is also a workaround solution:
If response.body() is null, put an empty String into Result: Result.success ("").
What about it?

@mahmoud-elnaggar

Yeah, using an empty string in this case would be preferable.
Agera itself is def. encouraging the use of the null object pattern over passing null

But a empty string cannot cast to the T 🤔

Oh, sorry about that, didn't read the code very closely, I admit.
I see two different solutions;

return an absent, and not only check succeeded() but also isAbsent, on the client side.
or;
provide a parameter as a null object, an instance of T.

Since I haven't used this extension myself, I'm not entirely sure what would be preferable here.

Maybe we could create a class called NullableBody😄, then we could use it to wrap the null body.

It is late at night in China, so the problem will continue to be resolved tomorrow.

@ernstsson I thought for a while, these two solutions are good, I am currently favored in the solution one...

I vote for first solution , it is more reasonable

Thank you very much for the help! We now accept the absentIfNull.

I have uploaded archives, waiting for Maven Central to take effect, it may take several hours.

Thanks very much for fixing this issue


feat: Add disable comment support

This PR adds support for disable comments to the Markdown plugin. It supports all of the variations that ESLint supports:

eslint-disable/eslint-enable
eslint-disable-line
eslint-disable-next-line

While working on this, I discovered a bug in no-html where it was only reporting the first HTML tag in an html node even though there can be multiple. It was also skipping any html node that began with a comment. I also fixed these bugs in this PR, as I needed a good example to test the disable directives.
Note: This PR intentionally does not implement inline configuration comments like /* eslint rule:error */.

Ping @eslint/eslint-team

Note: This PR intentionally does not implement inline configuration comments like /* eslint rule:error */

We don't want to implement this or we'll implement it in another PR?

Ping @aladdin-add


Deploy the Fiori App to Cloud Foundry

Tutorial URL: https://developers.sap.com/tutorials/sapui5-fiori-cf-deploy.html
Please specify the step you are referring to: STEP 2
After I build the project and deploy to SAP Cloud Platform using CF CLI, I get an error and the app never runs in the cloud. See terminal output:
Starting application "products_deployer"...
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Application "products_deployer" started
Proceeding with automatic retry... (3 of 3 attempts left)
Executing task "deploy" on application "products_launchpad_deployer"...
Error executing application "products_deployer": Deployment of html5 application content failed [Deployment Id: deploy-2ce2fe72-a946-11ea-8156-eeee0a9b2d6f] Error: The resources folder is invalid because it contains the file - .DS_Store; the resources folder should contain application folders and/or zip files.
Stopping application "products_deployer"...
Application "products" staged
Starting application "products"...
A step of the process has failed. Retrying it may solve the issue.
Proceeding with automatic retry... (2 of 3 attempts left)
Starting application "products_deployer"...
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Proceeding with automatic retry... (1 of 3 attempts left)
Executing task "deploy" on application "products_launchpad_deployer"...
Application "products_deployer" started
Execution of task "deploy" on application "products_launchpad_deployer" failed.
Download the application logs via the dmol command and check them for more information.
A step of the process has failed. Retrying it may solve the issue.
Error executing application "products_deployer": Deployment of html5 application content failed [Deployment Id: deploy-2ce2fe72-a946-11ea-8156-eeee0a9b2d6f] Error: The resources folder is invalid because it contains the file - .DS_Store; the resources folder should contain application folders and/or zip files.
Stopping application "products_deployer"...
Application "products" started and available at "7e1fa50atrial-dev-products.cfapps.us10.hana.ondemand.com"
A step of the process has failed. Retrying it may solve the issue.
Process failed.

Hi,
the interesting part of the error message is this one:
DS_Store; the resources folder should contain application folders and/or zip files.
Stopping application "products_deployer"...

Your Mac probably created this file when you used finder to browse/edit the data - this happens to me quite often too. You can remove all these files with find . -name ".DS_Store" -delete  before deploying again

Thank you!

Great! Does this mean your issue is resolved and it works now?

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


local tunnel is not availabe - 502 Bad Gateway

it seems the bad gateway issue from a few weeks ago is happening again :(

Same problem here... Yesterday it was working :(

It is working now!! :D

It is working now!! :D

thanks for informing

Thank you for fixing. Much appreciated!