ElectricalMix Simulator using nevergrad

pull request to apply for the Nevergrad competition
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.

You have to check the CLA, this should be easy :-)
Very interesting work, I'll comment in your github repository, this is definitely one of the priorities for Nevergrad!

You have to check the CLA, this should be easy :-)
Very interesting work, I'll comment in your github repository, this is definitely one of the priorities for Nevergrad!

thank you

Hi! :-)
These plots are the results of a simulation based on data from the Toamasina Madagascar Inter-connected Mix. We can distinguish the current and "optimal" use coefficients as well as performance indices (price of electricity production, environmental impact, satisfaction of demand), In the case of satisfaction of demand, a negative number means an overproduction (production> demand) and a positive number means a production deficit (production <demand).
We have two graphs here: the first is based on the OnePlusOne optimizer from nevergrad and the second is based on the sequence of OnePlusOne and DE.
Note: The current values of the usage coefficients are entirely arbitrary (we have not yet received the exact values) and some informations from the dataset are estimated.

Hello, we've just integrated more optimizers from Nevergrad.
Here is the list of available optimizers:
['cGA', 'SplitOptimizer', 'RecombiningPortfolioOptimisticNoisyDiscreteOnePlusOne', 'RecES', 'RealSpacePSO', 'RandomSearchPlusMiddlePoint', 'QrDE', 'QORandomSearch', 'OptimisticNoisyOnePlusOne', 'OptimisticDiscreteOnePlusOne', 'ORandomSearch', 'NoisyOnePlusOne', 'NoisyDiscreteOnePlusOne', 'NoisyDE', 'NoisyBandit', 'NelderMead', 'NaiveTBPSA', 'NaiveIsoEMNA', 'LhsDE', 'FCMA', 'ES', 'DoubleFastGADiscreteOnePlusOne', 'DiscreteOnePlusOne', 'CauchyOnePlusOne', 'CM', 'AlmostRotationInvariantDE', 'TwoPointsDE', 'RandomSearch', 'OnePlusOne', 'DE', 'CMA', 'PSO', 'TBPSA']

hey :-) we've just added a method to compare results from differents optimizers :-)

hey :-) we've just added a method to compare results from differents optimizers :-)

Just a remark: I think you plot the objective values of points obtained through "ask".
This is cool, but this includes points with bad values, just tested for exploration. You might
either use the value obtained by optimizer.recommend() (but this require re-running your experiments), or
simply plot for x-axis t the best value met up to time t, rather than the last visited point.
That's a simple thing and your results will be much cleaner :-)

Hello, we've just integrated more optimizers from Nevergrad.
Here is the list of available optimizers:
['cGA', 'SplitOptimizer', 'RecombiningPortfolioOptimisticNoisyDiscreteOnePlusOne', 'RecES', 'RealSpacePSO', 'RandomSearchPlusMiddlePoint', 'QrDE', 'QORandomSearch', 'OptimisticNoisyOnePlusOne', 'OptimisticDiscreteOnePlusOne', 'ORandomSearch', 'NoisyOnePlusOne', 'NoisyDiscreteOnePlusOne', 'NoisyDE', 'NoisyBandit', 'NelderMead', 'NaiveTBPSA', 'NaiveIsoEMNA', 'LhsDE', 'FCMA', 'ES', 'DoubleFastGADiscreteOnePlusOne', 'DiscreteOnePlusOne', 'CauchyOnePlusOne', 'CM', 'AlmostRotationInvariantDE', 'TwoPointsDE', 'RandomSearch', 'OnePlusOne', 'DE', 'CMA', 'PSO', 'TBPSA']

Interesting :-) you might remove "OptimisticDiscreteOnePlusOne" and "Noisy*" and "TBPSA" because I guess your objective function is deterministic and these algorithms are for the deterministic case.
"NGOpt" could be added as it's the pointer to the best algorithm so far overall (this does not mean that it will be the best here, but it's often a strong competitor!).

hey :-) we've just added a method to compare results from differents optimizers :-)

Just a remark: I think you plot the objective values of points obtained through "ask".
This is cool, but this includes points with bad values, just tested for exploration. You might
either use the value obtained by optimizer.recommend() (but this require re-running your experiments), or
simply plot for x-axis t the best value met up to time t, rather than the last visited point.
That's a simple thing and your results will be much cleaner :-)

Sorry! I was wrong, you are actually correctly using everything.
The result is a bit noisy but this is probably just because there is a single run per x-axis value, without averaging.

hey :-) we've just added a method to compare results from differents optimizers :-)

Just a remark: I think you plot the objective values of points obtained through "ask".
This is cool, but this includes points with bad values, just tested for exploration. You might
either use the value obtained by optimizer.recommend() (but this require re-running your experiments), or
simply plot for x-axis t the best value met up to time t, rather than the last visited point.
That's a simple thing and your results will be much cleaner :-)

Sorry! I was wrong, you are actually correctly using everything.
The result is a bit noisy but this is probably just because there is a single run per x-axis value, without averaging.

Hello :-)
We tried to make it less noisy

The cost you are optimizing is the sum of these 3 costs, right ? maybe a curve with this sum would be cool as it would be a fair comparison between methods.

If the computational cost is an issue maybe there is a solution: if you package your code so that we can pip install it and pip import it, then we can include it inside nevergrad, and it will be run automatically each time someone runs the dashboard (plenty of algorithms, sufficiently replicas for significance). Up to you :-)

The cost you are optimizing is the sum of these 3 costs, right ? maybe a curve with this sum would be cool as it would be a fair comparison between methods.

Actualy we are optimizing the production_cost. But we are using nevergrad register_cheap_constraint() method for the carbon_impact constraint and the demand_satisfaction_constraint

Hello :-) , here is the new list of supported Optimizers from now.
['ASCMA2PDEthird', 'ASCMADEQRthird', 'ASCMADEthird', 'AdaptiveDiscreteOnePlusOne', 'AlmostRotationInvariantDE', 'CM', 'CMA', 'CMandAS', 'CMandAS2', 'CMandAS3', 'CauchyLHSSearch', 'CauchyOnePlusOne', 'CauchyScrHammersleySearch', 'Cobyla', 'DE', 'DiagonalCMA', 'DiscreteBSOOnePlusOne', 'DiscreteOnePlusOne', 'DoubleFastGADiscreteOnePlusOne', 'EDA', 'ES', 'FCMA', 'LHSSearch', 'LhsDE', 'MEDA', 'MPCEDA', 'MetaModel', 'MixES', 'MultiCMA', 'NGOpt', 'NaiveIsoEMNA', 'NaiveTBPSA', 'NelderMead', 'NoisyBandit', 'NoisyDE', 'NoisyDiscreteOnePlusOne', 'NoisyOnePlusOne', 'ORandomSearch', 'OnePlusOne', 'OptimisticDiscreteOnePlusOne', 'OptimisticNoisyOnePlusOne', 'PCEDA', 'PSO', 'PolyCMA', 'QORandomSearch', 'QrDE', 'RandomSearch', 'RandomSearchPlusMiddlePoint', 'RealSpacePSO', 'RecES', 'RecMixES', 'RecombiningPortfolioOptimisticNoisyDiscreteOnePlusOne', 'RotationInvariantDE', 'SplitOptimizer', 'TBPSA', 'TripleCMA', 'TwoPointsDE', 'cGA']
We are still working on the others

If the computational cost is an issue maybe there is a solution: if you package your code so that we can pip install it and pip import it, then we can include it inside nevergrad, and it will be run automatically each time someone runs the dashboard (plenty of algorithms, sufficiently replicas for significance). Up to you :-)

We are currently working on it :-)

If the computational cost is an issue maybe there is a solution: if you package your code so that we can pip install it and pip import it, then we can include it inside nevergrad, and it will be run automatically each time someone runs the dashboard (plenty of algorithms, sufficiently replicas for significance). Up to you :-)

Hello,  you can  now a pip import it :-) the package name is0 "mixsimulator"


Variable typos

Compression, not compreesion :)

You are tearrring it up, thanks so much @LowlyDBA !


About the adaptive attention model.

Does your code can replicate the adaptive attention model. I run your code with max_epoch 30 and the default settings in opts.py. But I did not obtain that high cider in the adaptive attention paper. If you did replicate the result in the paper, I'll appreciate if you tell me the experiment settings in detail. Thank you!

No, I didn't spend time to replicate the result.

No, I didn't spend time on replicating the result. I did remember I got worse result than in the paper.

Thanks!

In order to get the similar number, I find finetuning the CNN is very important. This code use pre-extracted feature, so the number should be lower as reported in the paper.

I noticed that the adaptive attetion model use a fixed att_size 14, is that an optimal choice or just a empirical one?


Ethan: Watch worldwidebulksms.com

Ethan requests the watch of the watch_keyword worldwidebulksms\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by cigien in Charcoal HQ


Allow casting Timestamp arrays into String

Which issue does this PR close?

Closes #587
Rationale for this change

What changes are included in this PR?
there are two commits included in the PR
the first commit shows how it should be possible to implement. But the commit fails to compile with
error[E0599]: the method `value_as_datetime` exists for reference `&array_primitive::PrimitiveArray<T>`, but its trait bounds were not satisfied
    --> arrow/src/compute/kernels/cast.rs:1044:48
     |
1044 |     (0..array.len()).for_each(|ix| match array.value_as_datetime(ix) {
     |                                                ^^^^^^^^^^^^^^^^^ method cannot be called on `&array_primitive::PrimitiveArray<T>` due to unsatisfied trait bounds
     |
     = note: the following trait bounds were not satisfied:
             `T: numeric::ArrowNumericType`

error[E0599]: the method `value_as_datetime` exists for reference `&array_primitive::PrimitiveArray<T>`, but its trait bounds were not satisfied
    --> arrow/src/compute/kernels/cast.rs:1044:48
     |
1044 |     (0..array.len()).for_each(|ix| match array.value_as_datetime(ix) {
     |                                                ^^^^^^^^^^^^^^^^^ method cannot be called on `&array_primitive::PrimitiveArray<T>` due to unsatisfied trait bounds
     |
     = note: the following trait bounds were not satisfied:
             `T: numeric::ArrowNumericType`

error: aborting due to previous error

and compiles fine with second commit. But it feels not correct to use the second commit as the ArrowNumericType and Timestamp* types are not really releated. (Or I do not understand them correctly)

Are there any user-facing changes?
yes (additional ways to cast array) (where do I document this ?)
no breaking changes

Thanks @sum12  -- I plan to check this out tomorrow

Codecov Report

Merging #664 (1f996d8) into master (b38a4b6) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   82.50%   82.45%   -0.05%
==========================================
  Files         168      168
  Lines       47237    47380     +143
==========================================
+ Hits        38971    39067      +96
- Misses       8266     8313      +47

Impacted Files
Coverage Δ

arrow/src/compute/kernels/cast.rs
94.63% <100.00%> (+0.09%)
:arrow_up:

arrow/src/array/transform/utils.rs
95.00% <0.00%> (-5.00%)
:arrow_down:

arrow/src/array/equal_json.rs
85.21% <0.00%> (-3.48%)
:arrow_down:

arrow/src/tensor.rs
85.00% <0.00%> (-2.50%)
:arrow_down:

parquet/src/column/page.rs
97.36% <0.00%> (-1.32%)
:arrow_down:

arrow/src/array/equal/utils.rs
74.00% <0.00%> (-1.00%)
:arrow_down:

parquet/src/record/api.rs
91.60% <0.00%> (-0.88%)
:arrow_down:

parquet/src/file/statistics.rs
93.80% <0.00%> (-0.83%)
:arrow_down:

arrow/src/csv/writer.rs
82.41% <0.00%> (-0.74%)
:arrow_down:

arrow/src/array/array_map.rs
81.50% <0.00%> (-0.69%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38a4b6...1f996d8. Read the comment docs.


Added casper-test network config

As the title says, I added a new network config for the casper-test network. The config will be hosted at https://casper-genesis.make.services

bors merge

bors merge

Bors crashed on merge, had to kick it again.


New variant of Badge - Outline mode

Just like buttons have btn-outline modes can we add outline mode for badges.
Buttons have

btn-primary and corresponding btn-outline-primary
btn-danger and corresponding btn-outline-danger

It would be great to be able to have badges support similar outline mode

badge outline-primary
badge outline-danger

nice idea

I think for the time being, using utilities to accomplish this is the best approach. Closing out for now, but will consider revisiting for v6 and beyond.


Fix postgres probing

Fixes #978
Problem
Postgres PREPARE <name> as <query> expects postional wildcards ($1, $2) instead of question marks (?), see https://www.postgresql.org/docs/current/static/sql-prepare.html
Solution
Replace wildcards in PostgresDialect.prepareForProbing
Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[xd] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

that was fast! 👏


React + Redux architecture

I was wondering why the folder containing the global store, reducer and sagas is named module? Moreover, there are modules in pages alongside to components, container, tests and so on... it is even more confusing.
@cRicateau @tcheymol can you explain it to me here please?

@benja-M-1 From what I have read so far on the subject, my recommandation would be to move toward this pattern: https://medium.freecodecamp.org/scaling-your-redux-app-with-ducks-6115955638be 👍
duck/
├── actions.js
├── index.js
├── operations.js
├── reducers.js
├── selectors.js
├── tests.js
├── types.js
├── utils.js

I would love to have a broder vue of a react + redux + saga application. I propose the following file tree based on the discussions I had today with @lechinoix.
I know that @ghamaide disagree on the split of reducers + actions + selectors, I don't have opinion on that. I simply think that we should have one and only one way of doing things to avoir the burden to ask ourselves if it is time or not to split the concepts on its own file.
src/
|-- components/
    |-- Article/
        |-- Article.container.js
        |-- Article.component.js
        |-- Article.styles.js
    |-- ArticleExcerpt/
        |-- ArticleExcerpt.container.js
        |-- ArticleExcerpt.component.js
        |-- ArticleExcerpt.styles.js
|-- entities/
    |-- Articles/ <-- note the plural form
        |-- Articles.api.js
        |-- Articles.type.js
        |-- Articles.normalize.js
        |-- Articles.sagas.js
        |-- Articles.reducer.js
        |-- Articles.actions.js <-- not defined yet
        |-- Articles.selectors.js <-- not defined yet
    |-- Authors/
        |-- api.js
        |-- type.js
        |-- normalize.js
        |-- sagas.js
        |-- reducer.js
|-- pages/
    |-- Homepage/
        |-- ... here you put routes, page reducers, utils... ?
    |-- Articles/
|-- services/
...

@cRicateau @tcheymol @phacks @antkahn @Paulmolin @Bernardstanislas

@benja-M-1 my pain point is the fact that you have to edit 5 files when you do redux stuff :) In this architecture, where do you put the redux stuff that is used for ui or routing in your app ? Like a side-bar toggle ?
In entities/Authors, I think your file names should be prefixed by Authors like in entities/Articles
By the way, if we build SPAs (single page applications), shouldn't our pages directory rather be called views ? 😇

We looked at what BAM does on investo and it is very clear and easy to use.
components
pages
redux
 |-- Articles
 |-- Modal
 |-- Toaster
services

pages :

are linked to a route
it declares every components in the page

components :

are autonomous UI elements
there are no reducers in components

On Smart Advisor we use an “investo-like” structure and I couldn’t be more happy with it.


Improve DEVELOPING.md with step-by-step instructions and launch.json

Is your feature request related to a problem? Please describe.
I recently encountered an error upgrading from v1.4.3 to v1.5.0 and tried to debug the issue locally. However, it was difficult trial and error to set up a local development environment. I got it going but I'm not sure if there are better solutions so I'd prefer an "official" one.
FYI, my issue was resolved fairly quickly in v1.5.1.
Describe the feature you'd like
Please update DEVELOPING.md with clear step-by-step instructions for setting up a local development environment rather than basically just listing the dependencies. Most specifically, I'd be interested in Visual Studio Code launch.json configs you all use for debugging (or equivalents in whatever IDE you use or generic guidance for being able to set break points etc. with a debugger.).

Note to the AWS team, this existings in the "Using the solution command line interface (CLI)" heading under https://docs.aws.amazon.com/solutions/latest/landing-zone-accelerator-on-aws/managing-resource-dependencies.html

Note to the AWS team, this existings in the "Using the solution command line interface (CLI)" heading under https://docs.aws.amazon.com/solutions/latest/landing-zone-accelerator-on-aws/managing-resource-dependencies.html

That's not really what I'm looking for either.


Tree Details Page: Sort tables (all tabs) by columns

[ ] Individual tests
[ ] Boots tab
[ ] Tests tab
[ ] Builds tab
[ ] Log downloader


Introducing Black to Codebase #784

Hello @edeediong! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file cli/popper/cli.py:

Line 15:80: E501 line too long (81 > 79 characters)
Line 64:80: E501 line too long (80 > 79 characters)
Line 72:80: E501 line too long (87 > 79 characters)

In the file cli/popper/commands/cmd_ci.py:

Line 103:80: E501 line too long (84 > 79 characters)

In the file cli/popper/commands/cmd_dot.py:

Line 66:80: E501 line too long (84 > 79 characters)

In the file cli/popper/commands/cmd_run.py:

Line 23:80: E501 line too long (80 > 79 characters)
Line 85:80: E501 line too long (87 > 79 characters)
Line 113:80: E501 line too long (83 > 79 characters)
Line 167:80: E501 line too long (84 > 79 characters)

In the file cli/popper/config.py:

Line 36:80: E501 line too long (86 > 79 characters)

In the file cli/popper/log.py:

Line 126:80: E501 line too long (82 > 79 characters)

In the file cli/popper/parser.py:

Line 223:80: E501 line too long (84 > 79 characters)
Line 226:80: E501 line too long (86 > 79 characters)
Line 251:80: E501 line too long (85 > 79 characters)
Line 257:80: E501 line too long (84 > 79 characters)
Line 263:80: E501 line too long (84 > 79 characters)
Line 273:80: E501 line too long (87 > 79 characters)
Line 318:80: E501 line too long (83 > 79 characters)
Line 416:80: E501 line too long (84 > 79 characters)
Line 517:80: E501 line too long (86 > 79 characters)
Line 611:80: E501 line too long (80 > 79 characters)
Line 793:80: E501 line too long (80 > 79 characters)

In the file cli/popper/runner.py:

Line 28:80: E501 line too long (85 > 79 characters)
Line 116:80: E501 line too long (87 > 79 characters)

In the file cli/popper/runner_host.py:

Line 183:80: E501 line too long (83 > 79 characters)
Line 196:80: E501 line too long (83 > 79 characters)
Line 340:80: E501 line too long (88 > 79 characters)
Line 359:80: E501 line too long (83 > 79 characters)
Line 414:80: E501 line too long (82 > 79 characters)
Line 416:80: E501 line too long (85 > 79 characters)
Line 420:80: E501 line too long (88 > 79 characters)
Line 448:80: E501 line too long (82 > 79 characters)

In the file cli/popper/runner_slurm.py:

Line 180:80: E501 line too long (88 > 79 characters)
Line 184:80: E501 line too long (83 > 79 characters)

In the file cli/popper/scm.py:

Line 71:80: E501 line too long (101 > 79 characters)
Line 178:80: E501 line too long (87 > 79 characters)

In the file cli/test/test_cmddot.py:

Line 19:80: E501 line too long (86 > 79 characters)
Line 40:80: E501 line too long (84 > 79 characters)

In the file cli/test/test_config.py:

Line 35:80: E501 line too long (83 > 79 characters)
Line 49:80: E501 line too long (83 > 79 characters)

In the file cli/test/test_parser.py:

Line 23:80: E501 line too long (81 > 79 characters)
Line 199:80: E501 line too long (80 > 79 characters)
Line 200:80: E501 line too long (80 > 79 characters)
Line 201:80: E501 line too long (80 > 79 characters)
Line 216:80: E501 line too long (85 > 79 characters)
Line 224:80: E501 line too long (80 > 79 characters)
Line 225:80: E501 line too long (80 > 79 characters)
Line 226:80: E501 line too long (80 > 79 characters)
Line 241:80: E501 line too long (85 > 79 characters)
Line 283:80: E501 line too long (80 > 79 characters)
Line 284:80: E501 line too long (80 > 79 characters)
Line 285:80: E501 line too long (80 > 79 characters)
Line 308:80: E501 line too long (80 > 79 characters)
Line 326:80: E501 line too long (80 > 79 characters)
Line 327:80: E501 line too long (80 > 79 characters)
Line 328:80: E501 line too long (80 > 79 characters)
Line 343:80: E501 line too long (85 > 79 characters)
Line 386:80: E501 line too long (80 > 79 characters)
Line 404:80: E501 line too long (80 > 79 characters)
Line 443:80: E501 line too long (82 > 79 characters)
Line 498:80: E501 line too long (81 > 79 characters)
Line 588:80: E501 line too long (81 > 79 characters)

In the file cli/test/test_runner.py:

Line 71:80: E501 line too long (81 > 79 characters)
Line 77:80: E501 line too long (84 > 79 characters)
Line 94:80: E501 line too long (81 > 79 characters)

In the file cli/test/test_runner_host.py:

Line 134:80: E501 line too long (81 > 79 characters)
Line 166:80: E501 line too long (88 > 79 characters)
Line 275:80: E501 line too long (84 > 79 characters)
Line 293:80: E501 line too long (80 > 79 characters)
Line 314:80: E501 line too long (88 > 79 characters)
Line 317:80: E501 line too long (84 > 79 characters)
Line 331:80: E501 line too long (93 > 79 characters)
Line 342:80: E501 line too long (82 > 79 characters)
Line 350:80: E501 line too long (82 > 79 characters)
Line 354:80: E501 line too long (84 > 79 characters)
Line 365:80: E501 line too long (84 > 79 characters)
Line 399:80: E501 line too long (84 > 79 characters)
Line 427:80: E501 line too long (84 > 79 characters)
Line 430:80: E501 line too long (86 > 79 characters)

In the file cli/test/test_runner_slurm.py:

Line 448:80: E501 line too long (208 > 79 characters)

In the file cli/test/test_scm.py:

Line 21:80: E501 line too long (82 > 79 characters)
Line 62:80: E501 line too long (84 > 79 characters)
Line 130:80: E501 line too long (80 > 79 characters)

In the file docs/conf.py:

Line 281:80: E501 line too long (82 > 79 characters)
Line 321:80: E501 line too long (82 > 79 characters)


I can delete text after setReadOnly

I can delete text after setReadOnly,It may be caused by event that can't listen ‘Del key’ and 'BackSpace key'

editor.setReadOnly(true) ?
can not reproduce in my demo.


open files before broadcast in read.

Fixes the performance of read by using open on the file first. This should have always been the implementation.
@kongdd this PR is a huge improvement to load time without needing the lazy flag. We might still need it, as there is always some memory overhead to using lazy DiskArrays methods. But this is a start.
Also notice that in your timings in #254 you were including compilation time in the first run. The Raster object is a little complicated and takes a few seconds to compile, and GDAL/ArchGDAL also compile in that first run. We can try to fix that too at some stage, but its a separate issue to this one.
For now, the second and following runs are the real load time without compilation.
 Small change, big improvement.
But, actually, I can't figure out why current script improve the performance.

@kongdd to make this even more confusing for you ;)
The PR now alters modify so it happens at a lower level. modify is the DimensionalData.jl way of swapping the internal array of an object for something else, a bit like set but just for the array data. Its another way of making it easier to deal with these imuutable objects.

Codecov Report

Merging #257 (2e15946) into master (e858b28) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Current head 2e15946 differs from pull request most recent head 8d915df. Consider uploading reports for the commit 8d915df to get more accurate results

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   86.37%   86.43%   +0.05%
==========================================
  Files          36       36
  Lines        2577     2587      +10
==========================================
+ Hits         2226     2236      +10
  Misses        351      351

Impacted Files
Coverage Δ

src/filearray.jl
97.67% <100.00%> (+0.23%)
:arrow_up:

src/methods/replace_missing.jl
100.00% <100.00%> (ø)

src/read.jl
92.30% <100.00%> (+1.00%)
:arrow_up:

src/sources/ncdatasets.jl
86.86% <100.00%> (+0.11%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Error when starting on Darwin Arm64 and Windows IA32

Hey, you did an amazing job, thank you very much. Could you tell me how I can get your library to work on Darwin arm64 and Windows ia32? I would be very grateful. I understand that I need to build native modules for these architectures, but I don’t really understand how to do this, I’m new to this. Now when running on Darwin arm64 I get the error:
Uncaught Exception:
Error: No native build was found for platform=darwin arch=arm64 runtime=electron abi=110 uv=1 armv=8 libc=glibc node=16.17.1 electron=22.3.21
loaded from: /Applications/application_name.app/Contents/Resources/node_modules/electron-app-universal-protocol-client
at load.resolve.load.path (/Applications/application_name.app/Contents/Resources/node_modules/node-gyp-build/node-gyp-build.js:60:9)
at load (/Applications/application_name.app/Contents/Resources/node_modules/node-gyp-build/node-gyp-build.js:22:30)
at Object. (/Applications/application_name.app/Contents/Resources/node_modules/electron-app-universal-protocol-client/dist/bindings.js:3:53)
at Module._compile (node:internal/modules/cjs/loader:1141:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1196:10)
at Module.load (node:internal/modules/cjs/loader:1011:32)
at Module._load (node:internal/modules/cjs/loader:846:12)
at f._load (node:electron/js2c/asar_bundle:2:13330)
at Module.require (node:internal/modules/cjs/loader:1035:19)
at require (node:internal/modules/cjs/helpers:102:18)

Hi,
while ia32 seems doable right now, M1 is problematic as GitHub actions support for M1 workers is still pending as of this moment (https://github.com/github/roadmap/issues/528). Nevertheless, as the source code of this package is not being changed a lot right now, I'll provide M1 builds by myself.

Hi,
while ia32 seems doable right now, M1 is problematic as GitHub actions support for M1 workers is still pending as of this moment (https://github.com/github/roadmap/issues/528). Nevertheless, as the source code of this package is not being changed a lot right now, I'll provide M1 builds by myself.

Thanks for the answer, in the end I did just that, I assemble Arm64 on my machine, I’ve already figured out ia32.

@H29A @witcher112 Can any of you two point in the direction of what I have to do to get it running on my mac. I am having the same issue but do not have much experience with this topic. Any help would be appreciated.

@dnlbln I'll post an update next week that should fix the situation for Mac M1.

Sorry it took so long (I was overwhelmed by work, no time for GitHub contributions), and thank you for reminding me about this one! :)
https://github.com/witcher112/electron-app-universal-protocol-client/releases/tag/v1.2.0 - I've just released a new version with darwin-arm64 (M1/M2) support.
I hope it will serve you all well :D
PS. I've also added a section about macOS permissions issue as it occurred to me while creating this update - https://github.com/witcher112/electron-app-universal-protocol-client#macos-development-mode-permissions-issue

Thanks a lot @witcher112! How do I actually get it to load the prebuilds? Still getting the followinr error:
Error: No native build was found for platform=darwin arch=arm64 runtime=electron abi=119 uv=1 armv=8 libc=glibc node=18.18.2 electron=28.0.0-beta.11
    loaded from: /Users/xxx/dev/yyy/apps/desktop/.vite

    at y.resolve.y.path (/Users/xxx/dev/yyy/apps/desktop/.vite/build/main.js:1:2034)
    at y (/Users/xxx/dev/yyy/apps/desktop/.vite/build/main.js:1:1376)
    at /Users/xxx/dev/yyy/apps/desktop/.vite/build/main.js:3:2099
    at Object.<anonymous> (/Users/xxx/dev/yyy/apps/desktop/.vite/build/main.js:3:2127)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32)
    at Module._load (node:internal/modules/cjs/loader:967:12)
    at l._load (node:electron/js2c/asar_bundle:2:13642)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)


Compiling fails on linux

Hi,
I am trying to compile itertools, I get following error.

error: linking with `cc` failed: exit code: 1
  |
  = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/dinesh/projects/practice/target/debug/deps/practice-6b8ddf4c3a6f2ac6.0.o" "-o" "/home/dinesh/projects/practice/target/debug/deps/practice-6b8ddf4c3a6f2ac6" "/home/dinesh/projects/practice/target/debug/deps/practice-6b8ddf4c3a6f2ac6.crate.allocator.o" "-Wl,--gc-sections" "-pie" "-nodefaultlibs" "-L" "/home/dinesh/projects/practice/target/debug/deps" "-L" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/home/dinesh/projects/practice/target/debug/deps/libitertools-80b06c8cc7679f18.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-29fb1fb52cf57377.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librand-32f648f7f7567c6c.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-42efcbbdeb607d44.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-3c10208cdd7e61cb.rlib" "/home/dinesh/projects/practice/target/debug/deps/libeither-c27204e07c1d54bd.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-9cbadc6554202be9.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-618c266cf9124966.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-16f3b02b9a976b94.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-bc70b4efeaeb398c.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_unicode-a0ad42dc8f5856aa.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-21491ce3d14f1ef2.rlib" "/home/dinesh/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-b9713bd7f605c0b2.rlib" "-Wl,-Bdynamic" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util"
  = note: /usr/bin/ld: cannot find Scrt1.o: No such file or directory
          collect2: error: ld returned 1 exit status

Hi, please complete with version of itertools, version of rustc and command used

This is the itertools-num version. I am using a linspace function from from this crate.
itertools-num = "0.1.1"

rustc is 1.20.0.

Just importing the crate gives the error.
extern crate itertools-num

It worked by adding the following in bashrc.

LIBRARY_PATH=/usr/lib/x86_64-linux-gnu:$LIBRARY_PATH
export LIBRARY_PATH

Is there any other way?

Thanks! Itertools-num bugs are over at https://github.com/bluss/itertools-num and that crate is looking to be adopted.
This sounds like an issue of your rust installation and not of the third party crate? Maybe install rust using rustup? If the issue persists, I think you should file a bug with rustup or rust if third party crates don't work for you.
Closing here since it's not related to the itertools crate.


mac_sys_int v1.3 doesn't seem to work with macOS Catalina

I tried running the System Integration v1.3 simulator on macOS v10.15.7 but it just generated the following error: "The application “sys_int” can’t be opened."

Did you fix it? I also had the same issue with you but I don't know how to open the Simulator on Mac. If you did, please tell me the instruction. Thank you so much!

Hi @cfezequiel,
Though we are a little late to respond, we suggest you reach out to Udacity support for user-specific issues. And please go through this thread https://knowledge.udacity.com/questions/400765.
Thanks


Update list of Renegade-X Download Patch Mirrors

This list was completely out of date, I'll attempt to keep this updated anytime there is a mirror list change.
What CDN does this PR relate to
Renegade-X
Does this require running via sniproxy
no
Capture method
As a Renegade-x Developer, I maintain the mirrors.
Testing Scenario
See above :)
Testing Configuration
N/A

Sniproxy output
N/A

Does that mean that all the other rxp-.cncirc.net are now defunct?

Correct, this is the only patch mirrors we have right now.

Well its hard to get a more accurate source for an update so i'll merge this in


chore(deps): update common-dev-assets digest to 0bb740c

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
deab5dd -> 0bb740c

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 2.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


tests: remove unused and obsolete test metadata

metadata.staged: related to a removed tutorial and outdated deployment recommendation
project: related to the removed developer_tool (#1790)
map.json: related to TAP4, which is not supported by python-tuf

closes #2489

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.803%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1358

Relevant Lines:
1381

💛  - Coveralls


factsheet.protocolLimits.maxStringLens.idNumericalOnly

As far as I understand idNumericalOnly, it applies to the following parameters:
order.orderId
order.zoneSetId
node.nodeId
nodePosition.mapId
action.actionId
edge.edgeId
edge.startNodeId
edge.endNodeId
There should be an option to specify which ID-strings are numerical-only.
A system that has numerical nodeIds but all other Ids are available as strings, this idNumericalOnly would have to be set to true. Resulting in only numerical mapIds which is not really intuitive for the user.
The other option would be to not use this entry and reject orders with nodeIds that are not numerical. In my eyes this fails the goal of a factsheet.

You do not buy AGVs with this flag set to true. Because memory footprint and human readability are contrary.


chore(main): release 1.2.9

:robot: I have created a release beep boop
1.2.9 (2024-04-22)
Bug Fixes

deps: bump protobufjs from 7.2.4 to 7.2.6 (#182) (3d3a994)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/JoshAlexis/utils-abstractions/releases/tag/v1.2.9 :sunflower:


support Aqara WXKG02LM_rev2

see https://www.zigbee2mqtt.io/devices/WXKG02LM_rev2.html

Thanks for the addition


HS + CT mode for measure

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I'm wondering if there's a reason why there are two seperate modes for RGB and Color temperature, but no combined one. I mean, sure, there are lights which can do only one of them, but many lights can do both.
Describe the solution you'd like
Would it be possible to add an HS + CT mode, so we just have to start it once, and it will create both files after eachother?
Describe alternatives you've considered
None
Additional context
[?] Select the color mode:
 > ColorMode.HS
   ColorMode.COLOR_TEMP
   ColorMode.BRIGHTNESS

Implemented with #2596

Great, thanks!


Add support for generic types with JsonQualifiers (#92)

Generated JsonAdapters now supports generic properties that use JsonQualifiers.
I'm kinda new to AutoValue extensions, so please let me know if anything could be written better/more logically!

Do we have a rough estimate on how much faster it'll be? If it's just a matter of a few nanoseconds I wouldn't worry about it. On the other hand, we should consider the extreme of a data class with 1000's of properties (however unrealistic that is).
Conceptually, it sounds like a very good idea. It does seem like it'll increase the complexity/readability of the generated code. If it gets implemented it definitely deserves its own PR.

So speed isn't really the main bit for me, rather that what this library offers is actually a route to escape needing to do custom rules for reflection. Agreed that should be a separate change though, since we have existing adapter code already anyway doing this

Basically what I've done in this last commit is modified the makeType method so that it will work with generic types as well. Since makeType was already capable of using the Types class for complex types like List<Map<String, List<Integer>>>, generic types should now be fully supported with this PR. In other words, we can now do something like this:
@AutoValue
public abstract class Foo<T, U> {
    public abstract Map<U, T> bar();
    public abstract List<T> baz();
    public abstract U qux();

    // <adapter factory method>
}

This looks reasonable to me. @rharter do you want to take a look too?

This looks good to me.
It looks like users are going to need to put @Keep annotations on their simple generic types or add rules if they use proguard, since those are fetched by name.  I'm not sure of the best way to handle that, perhaps just a note in the readme?

Is there anything else we need to do before this gets merged?

Oops just saw Ryan's comment! I think just a note in the README should suffice. We could explore possibly adding them ourselves if they're present, but worth a separate PR I think and possibly avoidable if we used something like AutoAnnotation

Thanks @mattbdean!


Tooltip issue

Fixes Issue
#38 Added Tooltip functionality
#25 Fixed pointer Issue
Screenshots

Fixes Issue
#38 Added Tooltip functionality #25 Fixed pointer Issue
Screenshots

Hey @notsoocool, the feature is working well but it's making ui inconsistent
see the difference please fix it that:
After

Before

Hey @notsoocool
Still there is miner Difference between both of them you can see :
After contribution :

Before contribution :

Please fix the issue I will convert this issue into level3

Sure I will update it asap.

Thank you for your contribution @notsoocool


fix: Allow specyfing tlsSecret not only for nginx

When using ingressClass for example traefik along with cert-manager it is impossible to generate certificate.
Allowing setting up secretName for any type of ingressClass fixes it.

Thanks for the PR @dolohow.


Issue with generated xref link text. Different if link uses href versus keyref

Expected Behavior
Should both create the same link text.
Link example xref:
<xref href="rcl1576682021542.xml" ixia_locid="511" class="- topic/xref "/>
Link example keyref:
<xref class="- topic/xref " keyref="second-rcl1576682021542"/>
Both topics in the publication have a navtitle and @locktitle is set to yes:
 <topicref href="rcl1576682021542.xml" ixia_locid="3141" keys="rcl1576682021542"          locktitle="yes" class="- map/topicref ">          <topicmeta class="- map/topicmeta ">             <navtitle ixia_locid="3142" class="- topic/navtitle ">1. Customizing the top toolbar and                tiles</navtitle>          </topicmeta>       </topicref>
 <topicref copy-to="second-rcl1576682021542.xml" href="rcl1576682021542.xml" ixia_locid="3162"          keys="second-rcl1576682021542" locktitle="yes" class="- map/topicref ">          <topicmeta class="- map/topicmeta ">             <navtitle ixia_locid="3163" class="- topic/navtitle ">1. Customizing the top toolbar and                tiles</navtitle>          </topicmeta>       </topicref>
The TOC in tested formats generate the same for both topics
Actual Behavior
In the first the link generates as:
Customizing the top toolbar and tiles
While the second link generates as:

Customizing the top toolbar and tiles

Possible Solution
The code that resolves the keyref link and the xref linking to a file should use the same element to create the link text in the linked topic.
Right now it looks like one is using the  element while the other is using the
Environment

DITA-OT version: 3.3.4
Operating system and version:
Windows
How did you run DITA-OT?
Oxygen
Transformation type:
HTML5, PDF, Webhelp Responsive

I found the issue also exists in dita-ot 3.4


Improve clarity between players index and seat number

Ideally, the players index and the seat number simply coincide. However, since players are independent from one another, ensuring that each player has a unique seat index needs to be done outside of the player constructor somehow, or players need to be re-wrapped. Right now, we rely on users passing in players with valid seat indexes, and these don't necessarily match up with the players index, which is very confusing.

I suspect that there are bugs due to this. We should add tests for this, too. The context here is that, if we were hosting a game, and player in seat 2 left, we may want to update the Players tuple size (e.g., for uniform eltype), in which case the seat number and player index are not the same.


False positive WordPress.WP.PreparedSQL.NotPrepared

I'm getting this error:
Use placeholders and $wpdb->prepare(); found $post_query (WordPress.WP.PreparedSQL.NotPrepared)

Here's the code:
$post_query = "SELECT ID, post_content, post_name, post_title, DATE_FORMAT(post_date, '%%Y/%%m/%%d %%H:%%i') AS post_date
							FROM {$wpdb->posts}
							WHERE post_status = 'publish' and post_type = %s
							ORDER BY post_date DESC";

if ( $limit && is_numeric( $limit ) ) {
	$post_query .= ' LIMIT ' . intval( $limit );
}

if ( $refresh || false === ( $posts = wp_cache_get( 'omniture.posts' ) ) ) {
	$posts = $wpdb->get_results( $wpdb->prepare( $post_query, $post_type ), ARRAY_A );
	wp_cache_set( 'omniture.posts', $posts );
}

I am using $wpdb->prepare().

The sniff isn't smart enough to follow a variable like $post_query back to its source(s). So it doesn't know whether the query in $post_query incorporates user-supplied values or not, i.e., it doesn't know if all of the values incorporated into it have really been prepared.
Ideally, there would be a way to refactor your code so that the query string isn't saved to a variable like this.
Alternatively, now that you've manually reviewed the code and can see that everything is properly prepared, you can whitelist this like so:
    $posts = $wpdb->get_results( $wpdb->prepare( $post_query, $post_type ), ARRAY_A ); // WPCS: unprepared SQL OK

What's a good way to refactor this, given there is a conditional?

I'm not sure there is really a "good" way to refactor it. You could duplicate the query, or you could use a ternary condition (if the sniff supported ternaries—it doesn't). I think those are the only options short of a full-scale SQL query builder.

@JDGrimes What do you think about the feasibility of statically looking back to assignments to the $post_query variable to come up with a raw concatenated string which can be looked at to check for the presence of formats. It still probably wouldn't be able to catch everything.

It is possible, but has its limits. My opinion is that it isn't worth it for what we gain: the ability to write code that is more difficult to manually review. It also opens up more possibility for false negatives.
If we want to build something that complex, we should use the right tool, which in my opinion isn't phpcs. I've toyed with doing it with PHP Parser, but haven't had the time (yet).
If someone else wants to attempt some look-back support, they are welcome to, but I will not be.

Agreed. Whitelisting comment is the solution here.


fix: adjust code base to ZeebeNode#deployResource API responses

Adjusts an oversight from https://github.com/camunda/camunda-modeler/pull/3773.
Previously I did not properly adjust client-side usages of the new response.

@philippfromme I think we missed this with the latest RC? Shall we still get this in?

I'd say let's merge this if otherwise we ship a broken feature.

@philippfromme Consider to incorporate this in a follow-up RC.

I will incorporate this before triggering the next RC.


How to customize the overlay color ?

Sorry, I did not find any other easy way to ask such question.
How to customize the color or  transparency value for the overlay that beneath the dialog?

You can't make dialogs transparent.

@afollestad
I dont mean the diaog itself, I mean the dark overlay underneath the dialog

Ah, that's a system thing that I don't have control over


Include conflicts parameter in doc_options

When a keys array is passed to _all_docs, fabric translates this
to individual open_doc calls. The conflicts=true query parameter is
specified as a view-level option and is not, by default, parsed as
an option that should be passed to open_doc.
As a workaround, explicitly copy the view-level conflict parameter into
the document options before open_doc is called.
An alternative approach would be to address this when the query
parameters are parsed, setting conflicts=true in both #mrargs and
detail of fabric, I elected to make the change here instead.
Fixes #COUCHDB-3264

thanks for the swift review @kxepal. I've made a few changes based on your comments - the naming matches the existing conventions in the module (perhaps not ideal, but consistent).

@willholley Thanks, that looks better (:
+1. Happy New Year! 🎉 🎄 🎅

+1 also.


Add some rudimentary unit tests

From the rOpenSci guide chapter 1.9:

testthat has a function skip_on_cran() that you can use to not run tests on CRAN. We recommend using this on all functions that are API calls since they are quite likely to fail on CRAN. These tests will still run on Travis.

We have some unit tests now, but I'd rather wait until we're using skip_on_cran() for any tests with API calls before closing this issue (as described above)


CB-9836 Add .gitattributes to prevent CRLF line endings in repos

Jira issue

lgtm

Will rebase and update it with common web project template now.

Done.


Docs: In Javascript API reference some links are broken

Describe the bug
Some of linked classes are not exported in the documentation. I tried to read more on AssetLoader methods, but others are not working either: IndirectLight, Skybox. Maybe more, I haven't check all of them.

To Reproduce
Steps to reproduce the behavior:

Open https://google.github.io/filament/webgl/reference.html#Engine
Try to read more on AssetLoader, IndirectLight or Skybox

Expected behavior
Have all classes and methods exported to docs and correctly linked

Thanks, we will soon be removing these docs and instead use the TypeScript bindings as documentation, as described in the comments at https://github.com/google/filament/issues/3250.

@pixelflinger my recommendation is close this and open a new ticket that says: "completely remove our old JavaScript doc system, use tsdoc instead".
In other words, all JavaScript documentation should live in filament.d.ts. The rationale is that the TypeScript declarations file needs to be kept up to date anyway, and it already describes the expected types.  It would be the analogue to  doxygen/C++ and javadoc/Java.
I don't like the JavaScript doc system that I created years ago because it requires Python (and therefore versioning hell) plus the docstrings are scattered everywhere and hard to maintain.


⚠ Tada Website has degraded performance

In 0ef5d17, Tada Website ($WEBSITE_URL) experienced degraded performance:

HTTP code: 200
Response time: 18281 ms

Resolved: Tada Website performance has improved in 6436cda.


Kubernetes 1.8 tutorial target-pool withouth health check reports unhealthy

Hi,
I am following the latest tutorial and cannot verify my Kubernetes Control Plane
> curl --cacert ca.pem https://${KUBERNETES_PUBLIC_ADDRESS}:6443/version
curl: (7) Failed to connect to X.X.X.X port 6443: Connection refused

The ip is the right one.
This is what the target pool looks like in GCP:

I have no http service running on the controllers, so I am not sure what health check to run there.
I checked the firewall rules and tried to access port 6443 of controller-0 from worker-0, which worked.

😔 I've tried this from company and until recently was excempt for firewall filters. Now I ain't any more.


Add a Qwik SDK

Feature Description
Qwik is a new React-compatible web framework built by the founder of AngularJS and his team. It takes the best of AngularJS, React, and Svelte and combines them to provide the best DX and UX speed-wise with a new concept called resumability. This is most probably one of the next major web frameworks out there!
Describe the solution you'd like
Qwik supports JSX, so adding support for it if you already support react is going to be straightforward.

@mysticaltech thank you for this amazing suggestion will look into its integration
Thanks


create spot fixer as generic transformer & apply to missing plant names

With our new ferc1 transform process we are less intense about dropping records. Because of that, I  came across a fair amount of records in the steam table that have "" or 0 as a plant name. Most of these records are truly trash (they have no other data points in them) and thus can be dropped. But some of them actually have some information. I investigated a far number of those bad-name-but-data-full records and was able to pretty easily identify plant names.
a generic-ish spot-fixer
the params would need to include:

some way to identify the specific record to fit
the column(s) and fix(es) required

the func/meth would be a table-wide transformer bc it requires having multiple columns. probably we'd find the records and use map or something like that to replace the values in the specific columns
a steam specific application
Using something like the dictionary below:
{
    "spot_fix": [
            {
                "record_id_ferc1": "f1_steam_1999_12_72_0_1",
                "fixes": {"plant_name_ferc1": "clifty creek"},
            },
            {
                "record_id_ferc1": "f1_steam_2010_12_306_0_1",
                "fixes": {"plant_name_ferc1": "harrison county"},
            },
            {
                "record_id_ferc1": "f1_steam_1997_12_230_0_1",
                "fixes": {"plant_name_ferc1": "hermiston generating"},
            },
            {
                "record_id_ferc1": "f1_steam_1998_12_64_0_1",
                "fixes": {"plant_name_ferc1": "hardee power station"},
            },
            {
                "record_id_ferc1": "f1_steam_2015_12_276_0_1",
                "fixes": {"plant_name_ferc1": "state line"},
            },
            {
                "record_id_ferc1": "f1_steam_2014_12_276_0_1",
                "fixes": {"plant_name_ferc1": "state line"},
            },
            {
                "record_id_ferc1": "f1_steam_2003_12_62_2_3",
                "fixes": {"plant_name_ferc1": "pea ridge"},
            },
            {
                "record_id_ferc1": "f1_steam_2003_12_62_2_2",
                "fixes": {"plant_name_ferc1": "smith"},
            },
            {
                "record_id_ferc1": "f1_steam_2000_12_204_0_1",
                "fixes": {"plant_name_ferc1": "seabrook"},
            },
            {
                "record_id_ferc1": "f1_steam_2001_12_204_0_1",
                "fixes": {"plant_name_ferc1": "seabrook"},
            },
        ]
}

a hydro specific application
{
    "spot_fix": [
            {
                "record_id_ferc1": "'hydroelectric_generating_plant_statistics_large_plants_406_2021_C000617_2583, 0'",
                "fixes": {"plant_name_ferc1": "station 5"},
            },
}

Closed by PR #2254.


[Windows] Add retries to Get-VsixExtenstionFromMarketplace function

Description
Sometimes we face an issue with the VS marketplace — the portal can be unavailable when making a request.
This PR adds retry logic to allow more than one try.
Related issue:
n\a
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019, windows2022


[PLUGIN REQUEST] Comments plugin - Beta with v4 support

Name
strapi-plugin-comments
Link
https://www.npmjs.com/package/strapi-plugin-comments
Status
Work In Progress (Beta released)
Type
Plugin
Author
https://github.com/VirtusLab-Open-Source

Close since it's duplication of #34


Makefile feedback

Excellent job providing instructions on how to create environment and download R packages. Makefile worked on first try. Other than that everything looks good. You do have a space in your Team contract file which should be fixed.

Thanks for your feedback.

Thanks for your feedback.


Autoloader: load plugins on muplugins_loaded

Directly calling loadPlugins wasn't correct since all the autoloaded plugins would be loaded when the Autoloader was loaded. If another muplugin happened to be loaded before it, it wouldn't have access to the
rest of the plugins.
Using the muplugins_loaded action ensures consistency. All the autoloaded plugins will be guaranteed to be loaded at the same part of the loading process now and have access to all regular muplugins.

I don't entirely agree with this change, primarily because muplugins_loaded may be too late in some cases.  Particularly, in a multisite environment, any network-enabled plugin would be loaded first, before the bedrock autoloaded mu-plugins (source).  This would mean that any normal network-enabled plugin would be loaded before an autoloaded mu-plugin.  I see this potentially causing much more problems than the current implementation.
MU plugins should always load before any normal plugin (IMO), as that's one of the key defining features as mentioned in the codex
If a hooked loading is desired for consistency - rather than the current immediate loading (which is more true to a real mu-plugin), I would recommend an alternative:
Add a new mu-plugin named something like zz-bedrock-autoloader-hook.php.  This plugin would contain the hook that the bedrock-autoloader would hook to for loading the plugins (eg: bedrock_muplugins_loaded)
Because mu-plugins are loaded in alphabetical order, the hook plugin would be loaded last, thus making all other mu-plugins available at autoloader-loaded load time, yet still loading before network-enabled or muplugins_loaded.
Alternatively, instead of adding a new plugin file for the hook, bedrock-autoloader.php could be renamed to zz-bedrock-autoloader.php and the hook could be called within the same file.
I would be happy to propose my own PR for this if others are open to considering it?

@aaemnnosttv I get what you're saying and like usual we didn't really think of multisite. Maybe @Foxaii can chime in since this was his suggestion.
One of my problems with your proposal is the zz prefix naming. You get into this problem where someone could have a plugin that starts with zzz for example. Obviously rare, but it could happen.
Really annoying that WP doesn't have 2 distinct actions for muplugins and network ones.

I agree with the weakness of the prefix and the annoyance of the multisite weirdness.  I looked into it a bit more and rather than prefixing with zz it could use a tilde ~, which should be a cross-platform valid filename character, and will always be sorted/loaded after files that start with z.
As a test, I created a few simple mu-plugins (not bedrock autoloaded) to check the load order:
app/mu-plugins/

a.php
b.php
c.php
z.php
~last.php

Each plugin contained the same code to simply output the name of the file to indicate the order they were loaded in

<?php var_dump( basename(__FILE__) ); ?>

Here is what I got:
string(5) "a.php"
string(5) "b.php"
string(5) "c.php"
string(5) "z.php"
string(9) "~last.php"

Thoughts?

It's definitely better than an alphabetical prefix. I'd like to confirm it works on Windows with no issue as well (assuming you didn't test on it).
I think regardless of the solution we need to have some more clear docs in the README showing the usual plugin load order and where the autoloader fits into that.

Windows can have ~ in the file name. It's actually been used by Windows itself since at least the Windows 3.x days as well as Microsoft Office for just as long.

The tilde is and has been supported by Windows as a filename character for a long time as @QWp6t said.  MS Word is one example that still uses it today as the first character in some of it's temporary files.  I can test on Windows, but we should probably have a few others test as well to be certain.

In my opinion, because WordPress has an event-driven architecture, we should tie the auto loader to a standard event, instead of using an obscure filename and creating our own action as an ugly workaround to an uncommon issue.
If you must have an mu-plugin accompanied by a network plugin (or vice versa), why not have two network plugins? Surely both would be controlled the same way?
Can anyone give an example of a popular plugin that can only be modified by mu-plugins? Surely the vast majority of customisations are possible at theme level (i.e. via functions.php), which would make the mu/network plugin load order immaterial.
Ideally WordPress would fire muplugins_loaded, then have a networkplugins_loaded action, but it doesn't, unless someone wants to try their luck on trac.
Whatever is decided I'm happy to better document it.

I don't understand why its not correct to load the plugins as soon as the bedrock autoloader is included.
@swalkinshaw said

If another muplugin happened to be loaded before it, it wouldn't have access to the
rest of the plugins.
I don't see this as a problem, when any plugin is loaded there could still be plugins waiting to be loaded, and since wp doesn't provide dependencies management its the plugin job to postpone its operations until all plugins are loaded if needed.

@francescolaffi I seem to keep going back and forth on this, but I'm leaning towards what you said and keeping it as is. Obviously the autoloader is no different than the current plugin loading process right now.

I agree that the whole alphabetical order thing sounds gimmicky and weird. The event hooks and prioritization exist for a reason.

Keeping this as is.


[BUG] Unable to import mapping

Context

ElasticDump version 6.72.0
Elasticsearch version 7.13.2
Node.js version (note that nodejs v10+ is required for this tool) v14.3.0
Full command you are having issue with (with inputs and outputs)

First I dump the data with

elasticdump \
  --input=http://local:9200/requirement_1 \
  --output=index_mapping.json \
  --type=mapping
elasticdump \
  --input=http://local:9200 \
  --output=analyzer.json \
  --type=analyzer
elasticdump \
  --input=http://local:9200/requirement_1 \
  --output=index.json \
  --type=data
elasticdump \
  --input=http://local:9200/ \
  --output=settings.json \
  --type=settings

Then I docker compose down the image, prune the volumes, delete all related cache and start a new elasticsearch image and try to import the data with

elasticdump \
  --input=index_mapping.json \
  --output=http://local:9200/requirement_1 \
  --type=mapping
elasticdump \
  --input=index.json \
  --output=http://local:9200/requirement_1 \
  --type=data
elasticdump \
  --input=settings.json \
  --output=http://local:9200/ \
  --type=settings
elasticdump \
  --input=index_mapping.json \
  --output=http://local:9200/ \
  --type=mapping

Then I got error like
 Error Emitted => {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"org id cannot be converted form long to int"}],"type":"illegal_argument_exception","reason":"org id cannot be converted form long to int"},"status":400}

Is the restore order matter? Or can you suggest a good practice to restore mapping and data in this case? Cheers,

The mapping failed to apply hence the error. Mapping expects the index to already exist (it does not create the index). Ideally the settings should be loaded first, then mapping, then data

Here is my settings data
"{\"control_1\":{\"settings\":{\"index\":{\"number_of_shards\":\"1\",\"provided_name\":\"control_1\",\"knn\":\"true\",\"creation_date\":\"1624428039141\",\"number_of_replicas\":\"0\",\"uuid\":\"UuUGN5XKSLmnFVtNdMW9AQ\",\"version\":{\"created\":\"7090199\"}}}},\"requirement_1\":{\"settings\":{\"index\":{\"number_of_shards\":\"1\",\"provided_name\":\"requirement_1\",\"knn\":\"true\",\"creation_date\":\"1624428039998\",\"number_of_replicas\":\"0\",\"uuid\":\"EPvrhdAATiuKtIHtOxltSg\",\"version\":{\"created\":\"7090199\"}}}},\"undefined\":{}}"

After I ran elasticdump
elasticdump \
  --input=index_settings.json \
  --output=http://local:9200/ \
  --type=settings

I got error like the following
Wed, 23 Jun 2021 06:03:49 GMT | starting dump
Wed, 23 Jun 2021 06:03:49 GMT | got 1 objects from source file (offset: 0)
Wed, 23 Jun 2021 06:03:49 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [GET, DELETE, HEAD]","status":405}
Wed, 23 Jun 2021 06:03:49 GMT | Error Emitted => {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [GET, DELETE, HEAD]","status":405}
Wed, 23 Jun 2021 06:03:49 GMT | Total Writes: 0
Wed, 23 Jun 2021 06:03:49 GMT | dump ended with error (get phase) => METHOD_NOT_ALLOWED: {"error":"Incorrect HTTP method for uri [/] and method [PUT], allowed: [GET, DELETE, HEAD]","status":405}

The elasticsdump.yml is really straightforward.
cluster.name: "docker-cluster"
network.host: <IP_ADDRESS>

Thank you very much for your help!

The index name must be specified so this should be L:
elasticdump \
  --input=index_settings.json \
  --output=http://local:9200/index_name \
  --type=settings

Thank you very much! It has dumped successfully!


Unit tests for reads

We need some standalone unit tests for the ga4gh/datamodel/reads.py module. Create a new test module called tests/unit/test_reads.py modelled after tests/unit/test_variants.py. Add some unit tests in here:

Create unit tests for parseMalformedBamHeader. We want to have some input strings (basically BAM header values you might see from samtools view -H tests/data/datasets/dataset1/reads/HG00096.mapped.ILLUMINA.bwa.GBR.low_coverage.20120522.bam where tabs have been replaced by spaces), and verify that they are parsed correctly.

Create unit tests for the SamCigar utility class verifying that the mapping is handled correctly.

Create unit tests for the SamFlags utility class verifying that the mapping is handled correctly.

Run the tests using nosetests -vs tests/unit/test_reads.py.

PR #922 is for this issue

https://github.com/ga4gh/server/blob/master/tests/unit/test_reads.py


relationship between spindke checkpoint and chromosome biorientation

I think there should be a relationship between
mitotic spindle assembly checkpoint and
A cell cycle checkpoint that delays the metaphase/anaphase transition of a mitotic nuclear division until the spindle is correctly assembled and chromosomes are attached to the spindle.
mitotic sister chromatid biorientation
The cell cycle process in which mitotic sister chromatids establish stable attachments to microtubules emanating from opposite spindle poles.
"Thus, although Mad2 and Mad3 are required solely for the SAC, Mph1, Bub1, Bub3 and Mad1 might have additional mitotic roles in chromosome bi- orientation beyond the SAC." PMID:26256832
The SAC inhibits anaphase until all chromosomes have biorientated so it must be a part of the biorientation process?

Hi Val,
'mitotic sister chromatid biorientation' (or perhaps more strictly, its parent class "attachment of spindle microtubules to kinetochore") has to happen before the checkpoint is passed. AFAIK, we don't have a relation appropriate to record that beyond the rather weak timing relations (preceded_by etc).

"Thus, although Mad2 and Mad3 are required solely for the SAC, Mph1, Bub1, Bub3 and Mad1 might have additional mitotic roles in chromosome bi- orientation beyond the SAC." PMID:26256832

The SAC inhibits anaphase until all chromosomes have biorientated so it must be a part of the biorientation process?

Don't think having components in common is enough reason to link the processes.  Or am I missing some important detail?
Cheers,
David

When the checkpoint pathway is satisfied it is turned off. But during the period when the chromosomes are not aligned it is turned on. In this respect, although it is negatively regulating the mataphase/anaphase transition via the APC until satisfied,  it must also somehow be part of biorientation, because it is required to signal  when spindle attachment is correctly completed (via aurora kinase I think?).
I'll continue to think about it and update the ticket once I have done a few more of the papers...I can also check with experts.

I thought about this. You are right. The checkpoint is active during attachment but just sensing correct attachment. Closing this one....


ISSUE-114 Extend Podaacpy to OceanColor Data

This issue addresses #114

Coverage decreased (-0.9%) to 95.647% when pulling 10a7f092034acf4d4c70974a9317e48f42ed23d3 on ISSUE-114 into<PHONE_NUMBER>5f02370fdcc4a04db720917cf7d59e on master.

@lewismc one of the test cases that you have added: "test_file_search" is failing for python2.7, please verify if there is any discrepancy. Thanks.

@Omkar20895 are you using Python2.7?

@lewismc No, I did not test on my local system, Travis CI build log shows that there is a test case that is failing for python2.7.


addsubscriberspill : Made error message disappear when user inputs

Previously, when wrong username is entered in the Stream Membership input to subscribe a user then "No User to Subscribe" error is thrown but the error is expected to fade away it remains until successful user is added and the same goes for succesfull messages too
This PR uses the stream_subscription_req_result_elem div which is responsible for showing both error and successful messages and makes the innerHTML to empty when user inputs into the input box which result in removal of message
Fixes : #27438

Screenshots and screen captures:
Screenshots
Before:

After

screen captures
Before:
https://github.com/zulip/zulip/assets/88829894/0ccf3962-9936-4f35-8fbb-77245419eb9d
After:
https://github.com/zulip/zulip/assets/88829894/66e64ca4-c6ff-4bac-90ab-1bfd783200ed

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@alya check this out i have updated the commit and screenshots

@alya i have rectified the test i am unable to ensure why above test is not running aside from that everything is rectified


feat(v2): add Brazilian Portuguese translation for docusaurus-theme-classic

Hey folks,
I added the brazilian portuguese translations.
Greetings
Thiago
Motivation
(I want to i18n my docusaurus application into Portuguese (Brazil).
That's why I translated docusaurus theme classic strings.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I didn't change any code, just translation strings, so the existing tests should be fine.
Related PRs
None.

Thanks! that looks great!
Was wondering if you could also provide pt-PT translations? or is it too different?

Hey @tiago-rr what do you think to help us ? :)

Hey @tiago-rr what do you think to help us ? :)

For sure! I'm going to take a look at it, glad to be helpful!

Thanks :)

Thanks @rdiego26 and @tiago-rr


Change boxShadow values from x and y to offsetX and offsetY

The W3C DTCG draft for shadows specifies the following format for boxShadow tokens:
{
  "shadow-token": {
    "$type": "shadow",
    "$value": {
      "color": "#00000080",
      "offsetX": "0.5rem",
      "offsetY": "0.5rem",
      "blur": "1.5rem",
      "spread": "0rem"
    }
  }
}

That is different to what we specify today:
{
  "shadow-token": {
    "$type": "shadow",
    "$value": {
      "color": "#00000080",
-      "x": "0.5rem",
-      "y": "0.5rem",
+      "offsetX": "0.5rem",
+      "offsetY": "0.5rem",
      "blur": "1.5rem",
      "spread": "0rem"
    }
  }
}

We should make sure that when users are working in the DTCG compliant version that their x and y properties are being saved as offsetX and offsetY, and we pick them up accordingly. We do not have to still listen for the old values, but we should make sure that when users switch to the DTCG compliant version that we transform their properties to offsetX and offsetY, and when they work in the old version that we detect x and y.

Still blocked by https://github.com/tokens-studio/figma-plugin/issues/999

Added to Featurebase Roadmap-	❇ W3C DTCG Spec boxShadow values JSON schema

closing as not planned for now, we can reopen when the time is right.
It is linked to Added to Featurebase Roadmap- W3C DTCG Spec boxShadow values JSON schema


<Content>'s style tag breaks if false

https://github.com/carbon-design-system/carbon-components-svelte/blob/6ec48312ffa1a31c0e366d9bd74b8a1f4d46292c/src/UIShell/Content.svelte#L21

if unsetLeftMargin && 'margin-left: 0;' results to false &&restProps.style wont get applied, because the whole style tag is invalid
one more closing brace

simple repro
Proposed solution:
style="{unsetLeftMargin ? 'margin-left: 0;' : ''} {$$restProps.style}"
I'd make a PR but I couldn't make symlinks to work with yarn berry and don't have time currently to fiddle with it.
Thanks!

Thank you for the repro and suggestion.

Fixed in v0.70.2.


Adopt VT extension "Unscrolling the screen" from Kitty

Description of the new feature/enhancement
Kitty has recently shipped an awesome VT extension to the SD (Pan up) escape code from the VT-420 terminal to tackle the issues with text being lost under the cursor.  I'd like to see this added in Windows Terminal as well. See https://sw.kovidgoyal.net/kitty/protocol-extensions.html#unscrolling-the-screen. As there have been several issues raised in the past surrounding this issue, this appears to be the perfect solution to prevent further issues from being raised about it. Also, since Windows Terminal adopted private extensions from ConEmu to address other issues, I see no reason why we can't also adopt some of Kitty's protocol extensions as well.

Proposed technical implementation details (optional)

@j4james and @skyline75489 since I know this is your thing.

Interesting. For conhost this would be possible (unless the lines were pushed up off the top), but for Terminal it would not. Due to ConPTY maintaining its own buffer which crucially does not have a scrollback, it wouldn't be able to tell Terminal what to put back on the screen.

I actually mentioned this before in issue #9622. I thought it might be a nice way to provide VT applications with equivalent functionality to existing console APIs, and also allow us to forward those console APIs over conpty. But as @DHowett mentioned, it's not currently feasible with the existing conpty implementation (at least I couldn't figure out a way to make it work).
Also, while I'm in favour of an extended scrolling sequence in general, I'm vehemently opposed to the Kitty implementation. The escape sequence that was chosen is pointlessly using a reserved codepoint, and would be much more appropriate as a private parameter prefix on the existing scrolling ops. Then there is an arbitrary limit on how much you can scroll back, which makes it useless for anything other his one use case. I also didn't think switching from a viewport pan to a buffer scroll when it reached the boundary was a good idea, and would limit some of the things that could be achieved with it.
I did raise all of these points when the subject was discussed in terminal-wg, but you can image how well that feedback was received. So if we do ever get around to doing something like this, I think it's almost certain we're going to need to do our own thing (although ideally in agreement with other conpty terminals that could benefit from the extra legacy app support that these sequences could provide).

There is actually a critical design flaw in Kitty's proposal. This modified SD would be incompatible to horizontal as well as vertical margins, which are otherwise we'll defined. Or: how do you fill up the top created lines in such cases?

Yea, I agree, I kinda hate this idea. I trust pretty completely j4james and christianparpart on this subject.
I'll leave this open in the freezer as "maybe this is a valid idea, if someone can actually come up with a sensible implementation", but not as "do the kitty thing".


clarify runtime and design time metadata

cc @ShaneMill1
Provide definitions/discussion on meanings of design time metadata and runtime metadata.

Runtime- EDR core metadata (required)
Design Time- linking out to specific metadata (specific to the domain and optional)
EDR core metadata would align with the OGC-API Records metadata with extension.

Any application could pick up on this metadata in order to operate.

Design Time would be what we see in a MetOcean best practices in relation to OGC-API Records

Can add the extra value to the metadata and would be specific to the domain.

Discussed in 10/22/2020 MetOcean DWG

Discussion 1/21/21 - Pete T.
Need to make it clear that there is metadata for discovery (in finding a collection). But, once you have the collection, we need to be able to describe specifics about the data.
Collection Level Discovery

An example would be looking for rainfall rate as an observation

Once in the collection:
Specific to the data (geospatial object, and its properties)

Is the rainfall measured by a rain gauge, is it derived from radar, etc.

This is important for implementation and a decision tree. This is where link relations are important as well. The ability to refer to other records from within a record.
In OGC API Records, there is the ability to do associations which would be useful to leverage here.
OGC API Records supports keywords. @tomkralidis could propose to have "sets" of keywords (such as metoc: keywords).
A set of these keywords could point to a thesaurus.
Can leverage the link relations and/or associations to allow consumers to make a graph or decision tree.

Discussion 1/21/21 - Pete T.
Need to make it clear that there is metadata for discovery (in finding a collection). But, once you have the collection, we need to be able to describe specifics about the data.
Collection Level Discovery

An example would be looking for rainfall rate as an observation

Once in the collection:
Specific to the data (geospatial object, and its properties)

Is the rainfall measured by a rain gauge, is it derived from radar, etc.

This is important for implementation and a decision tree. This is where link relations are important as well. The ability to refer to other records from within a record.
In OGC API Records, there is the ability to do associations which would be useful to leverage here.
OGC API Records supports keywords. @tomkralidis could propose to have "sets" of keywords (such as metoc: keywords).
A set of these keywords could point to a thesaurus.
Can leverage the link relations and/or associations to allow consumers to make a graph or decision tree.

FYI keyword sets proposal in OGC API - Records can be found at https://github.com/opengeospatial/ogcapi-records/issues/70

FYI keyword sets proposal in OGC API - Records can be found at https://github.com/opengeospatial/ogcapi-records/issues/70

Update on keyword sets proposal from today's OGC API - Records SWG meeting:

keywords should remain as a low barrier freeform list of terms/tags without a specific vocabulary/scheme, in support of broad interoperability
as suggested by the SWG, we could use themes which is part of the core record model like the below (suggested by @pvretano)

"themes": [
    {
       "scheme": "VOCAB1",
       "concepts": ["foo1","bar1","baz1"]
    }
]

I think this would work for our MetOcean BP here, as well as keeping with core OARec.
@chris-little @ShaneMill1 @mburgoyne any objections?  Note that there will be some tweaks to OGC API - Records core that I would undertake as a result.

Update on keyword sets proposal from today's OGC API - Records SWG meeting:

keywords should remain as a low barrier freeform list of terms/tags without a specific vocabulary/scheme, in support of broad interoperability
as suggested by the SWG, we could use themes which is part of the core record model like the below (suggested by @pvretano)

"themes": [
    {
       "scheme": "VOCAB1",
       "concepts": ["foo1","bar1","baz1"]
    }
]

I think this would work for our MetOcean BP here, as well as keeping with core OARec.
@chris-little @ShaneMill1 @mburgoyne any objections?  Note that there will be some tweaks to OGC API - Records core that I would undertake as a result.

@tomkralidis I think this provides a good balance between providing specific metadata vocabularies and simplicity.

@tomkralidis I think this provides a good balance between providing specific metadata vocabularies and simplicity.

@tomkralidis Looks good. So would this be in "Core" and with only one conformance class?

@tomkralidis Looks good. So would this be in "Core" and with only one conformance class?

@chris-little yes this would be in core with a conformance class regarding the OGC API - Records record model.  We will also add recommendations and examples in the specification to this effort.

@chris-little yes this would be in core with a conformance class regarding the OGC API - Records record model.  We will also add recommendations and examples in the specification to this effort.

@tomkralidis I think this looks very good as well.
Consensus on 1/28/21 meeting was that this is a good approach forward because it allows us to use OGC-API Records core without needing to create an extension.
Steve Olson brought up supporting authoritative thesaurus or vocabularies. The following example gives a way to do this using a still generic approach.
https://github.com/opengeospatial/ogcapi-records/issues/70#issuecomment-765731300
(keywords replaced with scheme and concepts)
Another conversation to be had is if we should supply the actual link relations rather than the paths within the concepts.
@tomkralidis will add an example that would represent something from a WMO code list, GCMD example, WIS2 metadata. Could continue to build out examples for different audiences.

@tomkralidis I think this looks very good as well.
Consensus on 1/28/21 meeting was that this is a good approach forward because it allows us to use OGC-API Records core without needing to create an extension.
Steve Olson brought up supporting authoritative thesaurus or vocabularies. The following example gives a way to do this using a still generic approach.
https://github.com/opengeospatial/ogcapi-records/issues/70#issuecomment-765731300
(keywords replaced with scheme and concepts)
Another conversation to be had is if we should supply the actual link relations rather than the paths within the concepts.
@tomkralidis will add an example that would represent something from a WMO code list, GCMD example, WIS2 metadata. Could continue to build out examples for different audiences.

Update: first pass examples published to https://github.com/OGCMetOceanDWG/ogcapi-records-metocean-bp/tree/master/core/examples

Update: first pass examples published to https://github.com/OGCMetOceanDWG/ogcapi-records-metocean-bp/tree/master/core/examples

Relied heavily on examples provided above to create an example for the existing collection:
https://data-api.mdl.nws.noaa.gov/EDR-API/collections/automated_gfs_100_forecast_time0_lat_0_lon_0_Isobaric_surface_Pa/instances/2021-01-19T00:00:00?f=application/json
Addressed in pull request:
https://github.com/OGCMetOceanDWG/ogcapi-records-metocean-bp/pull/9


Remove bash terminal dependencies

@lihaoyi this one should be ready to review. Basic sh is enough for the job.
I'll try to get rid of tput in separate PR as it needs more debugging.

@lihaoyi I've minimised amount of changes here too.

Looks good to me


'Run With PowerShell 7' Right-Click Context Menu Disappears On Windows 10 Updates?

Steps to reproduce
Install powershell 7 core, ask for Right-Click Context Menu

Experience a Windows update

The context menu is gone.

Expected behavior
The context menu shouldn't disappear.

Actual behavior
The context menu disappears.

For some reason this only happens with some Windows Apps? My Radeon settings and Visual Studio code are fine. But everything else got wiped?

How are you installing PowerShell? MSI? Store? Global tool?
What version of PowerShell are you using? What version of Windows? Which update specifically were you installing when this happened?

Any info on why was this issue closed since this is reproducible? It also happened to me on win 11. Enabled right click menu and aftrer PowerShell updates (via the windows update) the right click menu is gone.


Flaky Test: CircleCI e2e-pilot-auth-v1alpha3-v2

Different symptom than https://github.com/istio/istio/issues/7863
https://circleci.com/gh/istio/istio/332939?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link failed because of
2019-02-21T03:46:01.566970Z	info	Running command kubectl delete -n istio-system -f /tmp/istio.e2e.160502611/rule-503test-destinationrule-c.yaml931198571yaml --kubeconfig=
2019-02-21T03:46:02.092243Z	info	Command output:
destinationrule "destination-rule-c" deleted
2019-02-21T03:46:07.092469Z	info	Running command kubectl delete -n istio-system -f testdata/networking/v1alpha3/ingressgateway.yaml --kubeconfig=
2019-02-21T03:46:07.254367Z	info	Command output:
gateway "istio-ingressgateway" deleted
--- FAIL: TestIngressGateway503DuringRuleChange (63.37s)
	ingressgateway_test.go:258: Got non 200 status code while changing rules: map[200:499 503:1]
=== RUN   TestVirtualServiceMergingAtGateway

https://circleci.com/gh/istio/istio/333452?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link failed, same reason, the map was map[200:498 503:2].

https://circleci.com/gh/istio/istio/337405?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link failed as well. I think it should share the same reason. the map was map[200:499 503:1]

After restart the circle ci, it is working now. Maybe it got fixed by others or it appears occasionally

https://prow.k8s.io/view/gcs/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-k8s-latest/1204
Networking folks, can you please reassign appropriately to get it fixed?

Unassigned @rshriram and @andraxylia because we have started a large effort to deflake our tests and I want someone to see this as available and pick it up

The test failed 3 times (https://k8s-testgrid.appspot.com/istio-presubmits-master#circleci-e2e-pilot-auth-v1alpha3-v2&width=5) in the past 2 weeks and all caused by the same error (https://prow.k8s.io/view/gcs/istio-circleci/presubmit/master/e2e-pilot-auth-v1alpha3-v2/439664):
  Warning  Unhealthy              15s               kubelet, default-d4a1c8e2-2676-47b9-a877-c54822075b36  Liveness probe errored: rpc error: code = DeadlineExceeded desc = context deadline exceeded
  Warning  Unhealthy              14s               kubelet, default-d4a1c8e2-2676-47b9-a877-c54822075b36  Readiness probe errored: rpc error: code = DeadlineExceeded desc = context deadline exceeded

This seems very similar to https://github.com/istio/istio/issues/12431

e2e-pilot-noauth-v1alpha3-v2 seems failed due to the same reason (readiness/livness probe failed for galley and sidecar-injector.) for 1 time about a week ago: https://k8s-testgrid.appspot.com/istio-postsubmits-master#circleci-e2e-pilot-noauth-v1alpha3-v2&width=20

@yangminzhu
I opened https://github.com/istio/istio/issues/14847 to track that issue. Apart from that, are there any test failures that you are seeing?

The test is now moved to prow from circle ci: https://k8s-testgrid.appspot.com/istio-postsubmits-master#pilot-e2e-envoyv2-v1alpha3&width=20
It failed several times in postsubmits but it seems it's due to some specific test being flaky, for example: https://prow.k8s.io/view/gcs/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/3292, https://prow.k8s.io/view/gcs/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/3057, https://prow.k8s.io/view/gcs/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/2972
Sometime it failed in early build step which also seems not related to the issue here: https://prow.k8s.io/view/gcs/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/3160
@ozevren let me know if you found anything in Galley.
I will monitor the test for some more time to see if the same failure is happening on prow, we could close this if not which mean it's possibly related to the circle ci networking.

@yangminzhu Any update on this?

The test failed once in the past week:
=== RUN   TestGateway_HTTPIngress/HTTPIngressGateway
2019-07-19T00:03:13.026404Z	error	client request error command failed: "2019-07-19T00:03:12.994627Z\tfatal\tError Get http://istio-ingressgateway.istio-system/c: dial tcp <IP_ADDRESS>:80: connect: connection refused\n\ncommand terminated with exit code 1\n" exit status 1 for http://istio-ingressgateway.istio-system/c in t from primary cluster
2019-07-19T00:03:13.026488Z	info	request counts map[]
2019-07-19T00:03:14.209973Z	error	client request error command failed: "2019-07-19T00:03:14.202873Z\tfatal\tError Get http://istio-ingressgateway.istio-system/c: dial tcp <IP_ADDRESS>:80: connect: connection refused\n\ncommand terminated with exit code 1\n" exit status 1 for http://istio-ingressgateway.istio-system/c in t from primary cluster

https://storage.googleapis.com/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/3967/build-log.txt
It seems it's due to the readiness probe failed for ingress-gateway:
  Normal   Pulled     12m                 kubelet, gke-gke-071819-9hf4abyc1-default-pool-5e3992b1-6kc1  Successfully pulled image "gcr.io/istio-testing/proxyv2:77368ec56a2480e27898ec7048bb36f4bbfc5997-e2e_pilotv2_v1alpha3"
  Normal   Created    12m                 kubelet, gke-gke-071819-9hf4abyc1-default-pool-5e3992b1-6kc1  Created container
  Normal   Started    12m                 kubelet, gke-gke-071819-9hf4abyc1-default-pool-5e3992b1-6kc1  Started container
  Warning  Unhealthy  12m (x17 over 12m)  kubelet, gke-gke-071819-9hf4abyc1-default-pool-5e3992b1-6kc1  Readiness probe failed: HTTP probe failed with statuscode: 503

https://storage.googleapis.com/istio-prow/logs/istio-pilot-e2e-envoyv2-v1alpha3-master/3967/artifacts/pilot-test-ca508d25d3d343318facd53809/istio-ingressgateway-7d85847846-jrf9r_describe.log
I'm not sure if this is any related to this issue or galley or is it just some transient network errors.

closing the issue as the test HTTPIngressGateway is no longer flaky for now, there is some error in istioctl but is not specific or related to this test, https://prow.k8s.io/view/gcs/istio-prow/pr-logs/directory/pilot-e2e-envoyv2-v1alpha3_istio/380:
2019-09-16T18:35:30.767023Z	info	Running command /home/prow/go/out/linux_amd64/release/istioctl --kubeconfig= -n istio-system proxy-config endpoint a-5c745564c6-xbd65
2019-09-16T18:35:31.197500Z	info	Command error: exit status 1
2019-09-16T18:35:31.197624Z	error	istioctl [ istio-system a-5c745564c6-xbd65] failed
2019-09-16T18:35:31.197646Z	error	Failed to get proxy-config endpoint from pod a-5c745564c6-xbd65 in namespace istio-system
2019-09-16T18:35:31.197664Z	error	Failed to complete Init. Error command failed: "Error: error unmarshalling config dump response from Envoy: invalid character '-' after top-level value\n" exit status 1


Adding Manual votes

Add the ability to add in manual votes mailed in. Would be great if it functioned like adding in the nominating mailed in ones where we could add via the "nominating" member profile and select the link "add votes".

@uwbookwyrm can you confirm, I believe this works now.

tested and appears to work :) thanks so much!


Use a looper to manage the hashring command processor

I'm curious if this change (c2a4c3e) is what you were expecting @relistan.
This needs to be rebased after #1 gets merged.

After changes mentioned in person, :shipit:


Duplicate key error for many to many associations

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
go version go1.13.7 darwin/amd64
Which database and its version are you using?
psql (PostgreSQL) 12.2
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/postgres"
)

var db *gorm.DB

// User has and belongs to many languages, use `user_languages` as join table
type User struct {
	Id        uint64
	Languages []Language `gorm:"many2many:user_languages;"`
}

type Language struct {
	Id   uint64
	Name string `gorm:"unique"`
}

func init() {
	var err error
	db, err = gorm.Open("postgres", "user=gorm password=gorm DB.name=gorm port=9920 sslmode=disable")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)

	db.AutoMigrate(&User{}, &Language{})
}

func main() {
	if err := db.Create(&User{
		Languages: []Language{
			{
				Name: "a",
			},
			{
				Name: "b",
			},
		},
	}).Error; err != nil {
		panic(err)
	}

	if err := db.Create(&User{
		Languages: []Language{
			{
				Name: "b",
			},
			{
				Name: "c",
			},
		},
	}).Error; err != nil {
		panic(err)
	}
}

[2020-02-20 15:48:29]  [0.81ms]  INSERT INTO "languages" ("name") VALUES ('b') RETURNING "languages"."id"
[0 rows affected or returned ]

[2020-02-20 15:48:29]  pq: duplicate key value violates unique constraint "languages_name_key"

I've confirmed that the created join table inherits constraints defined on the source models, in my case a UNIQUE constraint was on my ID field.  When removed the join table was no longer generated with UNIQUE constraints on it's columns.


Access to special tokens ids: BOS, EOS, UNK and PAD

hi Eli,
First, thanks a lot for putting this together. I'm working on porting Gemma to GoMLX and go-sentencepiece saved some time already.
Something I'm missing to do the sampler is some of the special tokens, that according to the C++ source code, are also available in the original proto, and presumably saved in the tokenizer.model file (or wherever the sentencepiece model is loaded from).
Namely, the "bos" (BeginningOfSentece), "eos" (EndOfSentence), "pad" and "unk" (Unknown).
I hope it is ok I created this as a feature request.
cheers
ps.: Notice the Python API has the corresponding bos_id, eos_id, unk_id and pad_id methods.

Can you clarify what you need, exactly? Just access to these token values or their IDs?
A sketch of usage would help

I've pushed a new commit that provides this information. The API is slightly different because I wanted to avoid API polution with all these accessor methods, but it's simple enough (see test).
Please let me know if this works for you, and I'll tag a new release.

Thank you @eliben ! It works perfectly.

Thank you for confirming; I've tagged v0.5.0 so this should now be available in go get ...@latest

My dependency is also updated, and I'm already using the new version in my development.


Archetypes: Remove license from generated files (2.x)

To finalize issue #279, it's necessary to remove the license from the generated pom.xml file for the Database SE and QuickStart MP archetypes of Helidon 2.x.
This pull request fixes that.

@felvid thanks for the contribution ! I've also added removal of license header for the generated app.yaml in quickstart-se and quickstart-mp.


Update deps

Check for new deps version

Take a look also at the deprecations, like github.com/golang/protobuf


Downgrade loglevel of responder drops during shutdown

This PR makes the node keep track of when it shuts down a reactor and adjusts the logging behavior accordingly, only outputting debug level messages if this occurs. Testing is unaffected and will still warn as before.
As a result, there should be no false positive error messages in the log due to shutting down a reactor related to requests/responders anymore.
Additionally, pushing items into a sealed queue has been downgraded to debug level logging as well.
Closes #2204, #2207.

I'm wondering how does it affect general performance if we have this single flag that gets checked in multiple places.

Barely at all. We only check it if we have to log specific messages right now, which is a couple of times per day, at most.


Use tree-sitter-glimmer for embedded hbs and

Adds tree-sitter glimmer so that:

hbs teplate literal strings can be highlighted
<template> tags can be highlighted

TODO: find the embedded language map.
for nvim-treesitter, injections are defined here: https://github.com/nvim-treesitter/nvim-treesitter/blob/eb6fdb5085143195925494d5d4adbfb322167a53/queries/ecma/injections.scm#L15
supersedes: https://github.com/github/linguist/pull/5631
Description

Checklist:

[ ] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[x] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

I'll save you some effort, Linguist does not support tree-sitter grammars; TextMate compatible only (first sentence here).
Any references to tree-sitter grammars you may see in the vendor/README.md file or elsewhere are provided directly by GitHub's syntax highlighter.


Missing spacing after "}" conflict with "?"

ktlint error:  Missing spacing after "}"
what ktlint expects: find { it.default ?: false } ?.phone
what idea reformat code do find { it.default ?: false }?.phone
idea reformat is right!

Thank you! Fixed in 0.2.1 (it might take up to 2 hours for Maven Central sync to take place).


Genericize the logo alt tag

Noticed this while adapting the code to my OSPO's needs

I think the test is failing because the checks are run on a PR from a fork, so Actions cannot access the GRAPHQL_TOKEN . This change looks benign so I'll merge it and run tests separately.