hidden redundant lane transitions

in the image above routing detector displays a redundant track transition (in addition to  a useful road transition) from car+tram lane to tram only  lane.
We don't need that.

fixed in https://github.com/CitiesSkylinesMods/TMPE/tree/1564-redundant-transitions

What do  you mean by "redundant"? Should the car+tram lane not be able to reach the tram-only lane?

Question is: what vehicle type the selection represents. If 'both' (car + rail) then it is correct, not redundant

I think redundant is not strong enough. its a bug in routing manager. but path find recovers because it checks the source/target lanes' vehicle types.

There should be no tracked connection to a non-tracked lane. Agreed.
IIRC you added some modifier key shortcuts to toggle between car vs. tracked, and I assume you're holding that key on your keybaord when image is taken? If so, we can't see your keyboard in the image. There's literally nothing in that image that conveys "this is filtered to tracked connections".
So in addition to the identified bug in routing manager, maybe also some enhancecments to the routing diagnostic tool to help illustrate what we're looking at in current view. Either square connectors for tracks, or yellow-text highlight relevant content in the hint panel, or change button icon between road and track...?

you added some modifier key shortcuts to toggle between car vs. tracked

@aubergine10 those modifiers are for lane connection. the tool above is Routing detector. It does not have track/road shortcuts.

enhancecments to the routing diagnostic tool to help illustrate what we're looking

to understand what you are looking at you need to read the text in the hint box (I have pointed to with green and red arrow in https://github.com/CitiesSkylinesMods/TMPE/issues/1564#issuecomment-1121389265).
Its hard to talk about abstract topics. go to the tool and play with it!


Story 00 tobybrad

Put some in order into test regime, adapt existing tests to co-ordinator driven framework.

Reviewed 44 of 44 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 102 [r1] (raw file):
nit: /sucesfully/successfully

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 110 [r1] (raw file):
fyi: PouchDB actually supports promises which in general can be nicer but in this case would make absolutely no difference what so ever.

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 193 [r1] (raw file):
nit: I think it's more idiomatic to use 'null' when you mean 'not truthy' in Javascript land. Also rather than doing all this fancy formatting you really can just stick "doc with error: " + err and get a similar result without the extra line of code. :)

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 204 [r1] (raw file):
Is there any reason to have this line or the bodyParser lines? express-pouchcb includes everything it needs. I think these lines were just there because the postcard app was doing some additional stuff.

Comments from the review on Reviewable.io

Review status: 26 of 31 files reviewed at latest revision, 7 unresolved discussions, all commit checks successful.

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 20 [r2] (raw file):
As near as I can tell tape is never actually defined!

test/www/jxcore/lib/thali-tape.js, line 25 [r2] (raw file):
How would this location work? Does it assume that the serveraddress.json file is in the lib folder? I thought it was supposed to be in the jxcore parent folder?

test/www/jxcore/lib/thali-tape.js, line 49 [r2] (raw file):
/runnign/running

Comments from the review on Reviewable.io

Review status: 26 of 31 files reviewed at latest revision, 10 unresolved discussions, all commit checks successful.

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 23 [r2] (raw file):
Where is the require for mockMobile?

test/www/jxcore/lib/CoordinatorConnector.js, line 11 [r2] (raw file):
This isn't really idiomatic, although technically it is correct. If you look online you will generally find that all emitters follow the exact same pattern.
var EventEmitter = require('events').EventEmitter;
var inherits = require('util').inherits;

inherits(CoordinatorConnector, EventEmitter);

All of your code goes here

function CoordinatorConnect() {
    EventEmitter.call(this);
}

See, for example, here. Note however that I've learned the hard way to put the inherits statement at the top, not the bottom as in the linked examples, because otherwise inherits will override the prototypes you define.

test/www/jxcore/UnitTest_app.js, line 78 [r2] (raw file):
We really want to be able to run these tests on the desktop. So we need to wrap these calls with something like typeof Mobile !== "undefined" or jxcore.utils.OSInfo().isMobile

Comments from the review on Reviewable.io

Review status: 25 of 32 files reviewed at latest revision, 11 unresolved discussions, all commit checks successful.

test/www/jxcore/bv_tests/testThaliReplicationManager.js, line 22 [r2] (raw file):
Where is the fs import?

Comments from the review on Reviewable.io

Review status: 25 of 32 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

test/www/jxcore/lib/thali-tape.js, line 0 [r2] (raw file):
It's in the jxcore/ folder. Just needs to be in cwd which in this case is the same.

test/www/jxcore/UnitTest_app.js, line 78 [r2] (raw file):
Agree.. but not now.

Comments from the review on Reviewable.io


MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

As the "id" is removed from the construction, is it possible to add new ApiKeys instances with incorrect order in the future? the static field ID_TO_TYPE assume all ApiKeys instances are created by id order.

@chia7712 Can you please elaborate? I don't see the assumption you mention. The main assumption is that api keys are dense. I changed the code not to rely on the latter although it doesn't change the behavior.

Can you please elaborate? I don't see the assumption you mention. The main assumption is that api keys are dense. I changed the code not to rely on the latter although it doesn't change the behavior.

I assumed the order of instancing ApiKeys is strict so removing the id may makes it hard to "see" where to put the new ApiKeys in the future. However, it seems the order of instancing ApiKeys is free so the worry is invalid.

Tests passed for JDK 11 and 15. JDK 8 had one flaky failure:

kafka.api.ConsumerBounceTest.testClose failed

@chia7712 Do you have cycles to review this?

JDK8 and 11 passed, 15 had one flaky unrelated failure:

kafka.server.ClientQuotasRequestTest.testAlterIpQuotasRequest


Workspace's Group

Good day to you!
i would like to describe my suggestion for implementation of groupping workspaces (maybe i've peeked it in i3/sway thread)
i think it's the best way to not overload Hyprland with specific functions and also include some useful in many ways tools:

Named workspaces (tags):

 so we can store multiple workspaces > [0..9]

ability to map keybindings by hyprctl:

by default we map keys for `default` group of workspaces and by executing script for switching to another group, we remap this keybindings for another set of workspaces and unbind some, if there is such

like,
# by default
bind=SUPER,1,workspace,default.1
bind=SUPER,2,workspace,default.2
bind=SUPER,3,workspace,default.3
...

and for switching
...
hyprctl bind SUPER,1,workspace,work.ide
hyprctl bind SUPER,2,workspace,work.web
hyprctl unbind SUPER,3

(optional eye-candy) animation for switching workspaces :
i think i've seen it in todolist already

No hurry, no push, just suggestion.
Waiting for feedback
Thank you!

u can already have an unlimited amount of workspaces, you can put even 601274 into the bind and it will make a workspace with the id of 601274.
But yes, I see your suggestion. Sure.

cool.
also reason for implementing named workspaces would be dividing them by their meaning.(useful in rules)
like move all web-apps to web workspace

that's good
Thank you!


Adding note to consider Shared Calling Options for Emergency Calling

@CarolynRowe
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Vangelico - Outside are holes.

Hello, i just noticed that outside Vangelico Jewel Store, the place has a hole and if you walk, you fall into void. And on the stair side you also fall through the void.

Remove the ifruit store map

Looks like it is a MLO problem, nothing to do with ipls.

I don't have a ifruit store map

Hello, i just noticed that outside Vangelico Jewel Store, the place has a hole and if you walk, you fall into void. And on the stair side you also fall through the void.

its not ipl never ipl edit normal ybns you have some maps have problem near there as i know i had one UJ map have this problem check your addon maps


gadgets/snapshot/process: Handle showthreads in server side

snapshot process provides a ShowThreads flag. This commit moves the filtering logic to the tracer to avoid sending a bunch of data to the client that will be discarded later on.

I moved it to the eBPF code because it was easier than I initially thought.


⚠ Bofrost.de has degraded performance

In 3cdf4ff, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1882 ms

Resolved: Bofrost.de performance has improved in 5cf4b08.


Download song covers

You guys should add the song's covers when uou download a song.

This is a duplicate of #72.


Contact Links Not Working

Describe the bug
When we adding our social links like Insta, Github, Linkedin so they working during creation of resume but after export in pdf form they are not working.

What template are you using?
Check out this issue

May 9, 2023

Gengar and CastForm.
Boths social links not working after Export into pdf

check this workaround


Updated ny bikes source

@JotaBlanco do you still need these changes? if not can you close the pr?


CPANFILE: delete flock from cpanfile.

Due to a mistake, I added this requirement into cpanfile that it is
already in perl 5.
https://perldoc.perl.org/functions/flock.html
Fix build: https://circleci.com/gh/3scale/Test-APIcast/57
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

@mikz changes:

Added CI on the PR.
Added CI-Status in the README.
Fix the build :man_facepalming: sorry again!

Should be ok to go!


Mistaken description for AllowInsecureAuthInProduction item

Hi, I think there's a mistake in the following line:
AllowInsecureAuthInProduction. In a production environment, make sure to set this metadata to true
Because a few lines before an xml extract recommends to delete that parameter, like in the following comment:
        <!-- REMOVE the following line in production environments -->         <Item Key="AllowInsecureAuthInProduction">true</Item>
Thanks. Bye

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 781ff5da-dba7-1be3-b310-e74ddf3bbce0
Version Independent ID: d904416e-c5ba-89dd-c6d6-b8e6375b9c63
Content: Token enrichment  - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/add-api-connector-token-enrichment.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

Hi, we are investigating your issue and will update you shortly.
Best,
James


Arrow Flight SQL example server: do_handshake should include auth header

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We should include the authorization header in the do_handshake response.
Describe the solution you'd like
I would like to add the token in the auth header in the response. This is based on the discussion on<EMAIL_ADDRESS>(see https://github.com/apache/arrow-rs/issues/5662)

label_issue.py automatically added labels {'arrow'} from #5666

label_issue.py automatically added labels {'arrow-flight'} from #5666


remove dependency on v1 bindings and authz

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 14 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 22.491%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundles.go
0
14
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
298

Relevant Lines:
1325

💛  - Coveralls


The boldDraw() referenced in the doc, is an unknown method

The doc at https://climate.thephpleague.com/terminal-objects/draw/
shows the following example:
$climate->boldDraw('mug');
but that method is missing
Regards

$climate->bold()

@borgogelli Almost every method is "missing" as they're dynamically called, the main ones are declared in docblocks (using @method) but for compound ones (like boldDraw) there are far too many possible combinations to define them all.
If you want to use the declared methods then you could do $climate->bold()->draw('mug') instead


Add binary for linux-ia32 node 0.13

+linux-ia32-node-0.13/binding.node

@linuxonrails, thanks! See https://github.com/sass/node-sass-binaries/pull/42#issuecomment-76386782.

Hi @linuxonrails. As a rule we don't officially support unstable versions of node.
You can however supply your own binary during the npm install process with the SASS_BINARY_NAME ENV flag.


chore: add runtime context override for amplify sandbox deploy

Description of changes
Added transformer behavior runtime override support so that Samsara CLI command amplify sandbox will enable both destructive updates and replacing table upon GSI change by passing the key value --context amplifySandboxDeploy=true during cdk deploy

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Local cdk app by running
cdk deploy --context amplifySandboxDeploy=true
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

As discussed in https://github.com/aws-amplify/amplify-backend/pull/667 there should be no need to update anything in the CDK construct for this feature


$firebaseAuth().$getAuth()= null when browser refresh after a successful login

Hi,
Angular: 1.4.8
Firebase: 3.0.2
AngularFire: 2.0.1
BTW I'm upgrading from Firebase 2.4.2 / AngularFire 1.1.3 and this feature was working correctly before.
Steps to reproduce
I'm able to successfully login with Google or Anonymous and retrieve the user data. Just after login I can call $firebaseAuth().$getAuth() and I can get a JSON object that contains the AuthData with {"credential": {...}, "user": {...}}
The problem arises when I do a browser refresh. My initial code will call $firebaseAuth().$getAuth() to retrieve the user data in case the user has logged in already but it returns null every time.
I've also tried calling: firebase.auth().currentUser but it also comes back as null
Expected behavior
For $firebaseAuth().$getAuth() to get the AuthData of the current user
Actual behavior
$firebaseAuth().$getAuth()= null  even when the user has login successfully

$getAuth() is a synchronous call to get the current user details, however the nature of angularfire is asynchronous, so by the time that $getAuth() is called it is usually before the page loads completely. So it returns null.
A better solution explained in the docs is to use the $onAuthStateChanged() callback to watch for changes on the auth object. This is a much more reliable way of getting the user since it's a listener and will only return when the event actually takes place.
$scope.authObj.$onAuthStateChanged(function(firebaseUser) {
  if (firebaseUser) {
    console.log("Signed in as:", firebaseUser.uid);
  } else {
    console.log("Signed out");
  }
});

Check it out here.

Thanks iRoachie!
I'm now able to get the logged in user using $onAuthStateChanged.
As a side note: On AngularFire 1.1.3 I was using a synchronous call  with $firebaseAuth(ref).$getAuth() and it was working correctly.


Search in folder

Search in folder option on right-click no longer displayed in 1.17 beta 3.

Seeing the same thing, thanks for the report @mediabeastnz :v:  Can you re-open this in https://github.com/atom/find-and-replace and fill out the issue template?

FYI - https://github.com/atom/find-and-replace/issues/887


Add issue and pull request templates

GitHub introduced issue and pull request templates and it could be a good idea to include them in SUITCSS' repos
https://github.com/blog/2111-issue-and-pull-request-templates
I would put them in the .github/ folder and try to see if symlinks work, if the do we could use a shared one which we'd host in this repo.

Sounds sensible, although not sure how symlinks would work? Perhaps one for a submodule?

Yeah, I don't know why I said symlinks :)
Should we create a new repo .github ?

Yeah, I wonder if GitHub let's you have repos with a dot at the start? If not we can call it templates or something and just give it the .github name when we set up the submodule.
From reading the docs we can also include a CONTRIBUTING.md, but not sure how useful that is

Yeah we can call it github.
To me it is useful to include a CONTRIBUTING.md I always read those.

Okay cool, then I think it's worth adding!

Can you create the repo? I don't think I have the power to do that :)

https://github.com/suitcss/github It lives

Closing because it is not possible to use submodules to do this.


localStorageService.get('settings') will be null at first time

As the title shows,when someone first time run this , localStorageService.get('settings') shows null.
This cause line8 at  root.controller.js  through a exception, js just terminal here.
May be need add some check.

Also I want add some function to this project.May I?
The first thing  I want to add is ROS_LOG view windows.In this way, can quickly take a look of log stream without ssh or other tools.Also add a log level setting will be great.

The issue should be fixed with the latest commit.
Of course, any help is always appreciated! The project is more-or-less a side project and still in it's early stages, but if you have a feature idea or request, you can either open a new issue or make a pull request.


Add lightmap to 1.7 spec and PBR material DOM

Here's an example of specifying lightmap in SDF:
          </pbr>
            </metal>
             ...
             <light_map uv_set="1u">light_map.png</light_map>
            </metal>
          </pbr>

Typically lightmaps use a different texture coordinate set from other maps so added an attribute uv_set to let users specify this. It's optional and defaults to 0.
Signed-off-by: Ian Chen<EMAIL_ADDRESS>

Codecov Report

Merging #429 (131f763) into sdf10 (c1e703d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf10     #429      +/-   ##
==========================================
+ Coverage   87.52%   87.54%   +0.01%
==========================================
  Files          61       61
  Lines        9337     9350      +13
==========================================
+ Hits         8172     8185      +13
  Misses       1165     1165

Impacted Files
Coverage Δ

src/Pbr.cc
98.48% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e703d...131f763. Read the comment docs.


unexpected behaviour when reindexing a Panel with MultiIndex

I was trying to reindex a Panel with a MultiIndex. The ultimate goal is to be able to do slicing like this:
wp.loc[(1,slice(None)),:,:] #Access the panel fixing the first index of the multiIndex

But whenever I try to reindex, like in this example I got this strange behaviour.
wp = pd.Panel(pd.randn(4, 5, 4), items=['Item_1_1', 'Item_1_2','Item_2_1','Item_2_2'],major_axis=['a','b','c','d','e'],minor_axis=['A', 'B', 'C', 'D'])
a=[tuple([int(i) for i in item.split('_')[1:]]) for item in wp.items]
swp=wp.reindex(items=x)

But when I try to access an item of the panel I got;
In [101]: swp[1,1]
Out[101]:
    A   B   C   D
a NaN NaN NaN NaN
b NaN NaN NaN NaN
c NaN NaN NaN NaN
d NaN NaN NaN NaN
e NaN NaN NaN NaN

The current workaround I have found is the following:
def sp(string):
    s=string.split('_')
    return int(s[-3]),int(s[-1])

 wwp=wp.rename(items=sp)
 w=wwp.items.sortlevel(level=0)
 swwp=wwp.reindex(items=w[0])

I don't think that the first is something that is excepted, and the second way is quite complex for nothing, but I might be wrong.
And now it is working at it should.

You don't have a multi-index in the first place. You need to create one explicity.
In [46]: wp = pd.Panel(pd.randn(4, 5, 4), items=pd.MultiIndex.from_product([range(2),range(2)]),major_axis=['a','b','c','d','e'],minor_axis=['A', 'B', 'C', 'D'])

In [47]: wp
Out[47]:
<class 'pandas.core.panel.Panel'>
Dimensions: 4 (items) x 5 (major_axis) x 4 (minor_axis)
Items axis: (0, 0) to (1, 1)
Major_axis axis: a to e
Minor_axis axis: A to D

In [48]: wp.loc[(0,0)]
Out[48]:
          A         B         C         D
a -0.084994 -0.653210 -0.404298 -2.500130
b  0.907593  0.078896 -0.998117 -1.167685
c -0.776501 -0.298755 -0.601618 -0.140084
d  0.370016  1.158117 -0.162282 -1.613040
e  0.852059  0.973698  0.757224 -0.621917

In [49]: wp.loc[(0,1)]
Out[49]:
          A         B         C         D
a -0.020449  1.094973 -1.252915  0.460252
b -1.749595 -0.312298 -0.116360  1.205130
c  1.421608  0.982935 -1.430015 -0.854789
d  1.044343  0.786917  1.527114 -1.098493
e  0.037582  0.744138  0.080397 -0.594863

In [50]: wp2 = wp.reindex(items=[(0,1),(0,0),(1,0),(1,1)])

In [51]: wp2.loc[(0,0)]
Out[51]:
          A         B         C         D
a -0.084994 -0.653210 -0.404298 -2.500130
b  0.907593  0.078896 -0.998117 -1.167685
c -0.776501 -0.298755 -0.601618 -0.140084
d  0.370016  1.158117 -0.162282 -1.613040
e  0.852059  0.973698  0.757224 -0.621917

Further, I would for sure name these levels. And what you are doing is going to require explicty
tuple accessors always, e.g. wp.loc[(0,0)]


issue-5285 Remove eager and unnecessary importing of setuptools and pkg_resources

Thank you for contributing to Pipenv!
Will require a requirementslib change to actually roll this out, but this is a branch that prototypes fixing #5285 and #5290
The underlying reason why we patched Pip to use sysconfig by default for all python versions (https://github.com/pypa/pipenv/pull/5275/files#diff-e154923a3c93acd48d40dd714127c4b90cac776ebd71930770919d539d137f77R44) ~though that appears to be compatible with this fix and so far that patch isn't causing a specific problem so I lean towards leaving it in for now.~  Actually #5290 came in right after I wrote that, so now I am in favor of dropping that patch with this change.
The issue
Some systems have patched sysconfig differently, and from this discussion (https://github.com/pypa/setuptools/discussions/3544) it would appear that importing setuptools packages is problematic

Replaced by:  https://github.com/pypa/pipenv/pull/5228


Returned type in index signature fails to get widened in error message

See https://github.com/Microsoft/TypeScript/issues/3234#issuecomment-104003549.

Think this was closed in error.

A (partial) fix might be available at thttps://github.com/Microsoft/TypeScript/commit/0b1db589bad2a73f606cb616159b9251e8036a53 (branch indexersAndContextualTypesAndStuff).

looks fixed in latest.


feat: Search Schema by Description

When there are enough schemas, we cannot quickly find the schema we need,
In the i18n scenario, we use the description field to explain the purpose of the schema. It is easier to find the schema we need by querying the schema description
Therefore, the query schema is extended here to add support for describing queries

@memotail See https://github.com/IvanGoncharov/graphql-voyager/pull/157.

I closing this as it got slate. Idea is good tho, happy to reconsider.


[release/v1.54] Update to Calico CNI, adjust node readiness checks and use KKP main branch

What this PR does / why we need it:
Backports #1464 and #1459 so the release branch can be properly tested for bugfix cherry-picks.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind failing-test
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

/approve
/lgtm


[Search v2.3] Fix tooltip rendering

Details

Video test:
https://github.com/user-attachments/assets/09387843-ae5d-4ba7-9b6b-e581e7fdee2c
Fixed Issues

$ https://github.com/Expensify/App/issues/49204
Tests

[x] Verify that no errors appear in the JS console

Go to the Search page
Create a saved search
Verify the tooltip is showing
Log out
Go to the search page again
The tooltip should not show again

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

Same as in tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I verified that similar component doesn't exist in the codebase
[X] I verified that all props are defined accurately and each prop has a /** comment above it */
[X] I verified that each file is named correctly
[X] I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] I verified that the only data being stored in component state is data necessary for rendering and nothing else
[X] In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] I verified that all JSX used for rendering exists in the render method
[X] I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

PR is looking good. Let me know once it's ready for review

PR is looking good. Let me know once it's ready for review

Ready for review!

Hi, does it need a c+ review?

Yes, please

@lakchote is the BE PR already on staging/prod?

Sorry, when I meant it was available to review I was speaking of the code, not necessarily the whole flow. More of like a pre-review, if you would.
The BE PR is still pending review, so you won't be able to test the whole flow yet.

I guess the offending PR for this is #44277. Added a comment there to get some 👀 of the author and C+.

Very nice find. It's important to correct this as it does a boatload of unnecessary API calls.

I'm discussing this 1:1 with Lucien, but I think we can probably find a frontend only approach to solve this issue. I think we could rely solely on the length of the savedSearches NVP

We discussed this, and we can go with a frontend only approach to solve this which is good.

@paultsimura @luacmartins ready for re-review, thanks

@lakchote this tests well, there's just one typo fix and we're good to go.

Updated code!

Unrelated JEST tests are failing. I tried to merge main, but it seems broken there too.

Gonna wait for a fix so we can merge this

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Since 1.15.0 'all' browser is not working

What is the Current behavior?
An error is thrown because the parameters give to the browser provider are incorrect.
ERROR Unable to open the "locally-installed:opera" browser due to the following error:

TypeError: Cannot read property 'split' of undefined
    at BrowserProviderPluginHost.openBrowser (/private/tmp/testcafe/node_modules/testcafe/src/browser/provider/built-in/locally-installed.js:7:35)
    at BrowserProvider.openBrowser (/private/tmp/testcafe/node_modules/testcafe/src/browser/provider/index.ts:314:27)
    at BrowserConnection._runBrowser (/private/tmp/testcafe/node_modules/testcafe/src/browser/connection/index.ts:190:33)
    at /private/tmp/testcafe/node_modules/testcafe/src/browser/connection/index.ts:165:37
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

What is the Expected behavior?
All browser are opened to run tests, like it was in 1.14.2
Steps to Reproduce:
mkdir /tmp/testcafe
cd /tmp/testcafe
npm install --save-dev testcafe sirv-cli
echo '
Hello world
' > test.html
echo 'fixture("all browser bug").page("http://localhost:5000");test("test", t => {});' > test.js
npx testcafe all test.js --app 'npx sirv .'

If I run this command it works as expected: npx testcafe opera test.js --app 'npx sirv .'
Your Environment details:
$ npx envinfo --system --binaries

  System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
    Memory: 170.70 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.16.1 - /opt/local/bin/node
    Yarn: 1.22.10 - /opt/local/bin/yarn
    npm: 6.14.8 - /opt/local/bin/npm

$ npm info testcafe version
1.15.2

Error root cause
In the version 1.5.0 the openBrowser functions have been changed from having the browserName to having browserOption, but some providers are not compatible with the new call
(files where the functions call have been changed: src/browser/provider/index.ts, src/browser/connection/index.ts)
From my understanding, src/browser/provider/built-in/path.js, src/browser/provider/built-in/locally-installed.js are affected by this issue

Hello,
Thank you for pointing out this issue.
I have reproduced it locally.


Add SuiSystemStateSummary

Add a flatten type to capture the sui system state.
It's also json-serializable so that we could eventually use it for json-RPC interface as well.
This will help decouple the EpochStartConfiguration type and the SuiSystemState type, and hence makes it a lot easier to evolve over time, and does not get affected much by the change to sui system state type.

Need to iterate a bit more


Use with JRuby

Hi!
is there a way to use polymer-rails with JRuby?  It seems there is a dependency on nokogumbo which tries to compile a C extension.
What is the C extension for?

polymer-rails uses gumbo parser via nokogumbo gem to process component html see https://github.com/alchapone/polymer-rails/issues/15 for details


[API] Enable access to data buffer

Hi,
For microcontrollers with limited memory, we can optimize memory usage by directly passing gp_buff to inference machine instead of copying the data to a separate memory.
For some microcontrollers this is a huge amount of memory and it's a matter of whether the model/runtime fits on device or not. I'll be happy to change the implementation if there is any suggestion.
Thanks.

This looks like a great addition!
My suggestion is that we add this change to the next version of the benchmark and keep v0.5 frozen for posterity.
We should be starting on a new version soon so I'll leave this PR up for now.

@colbybanbury that sounds great. Thanks!
Also I have signed the CLA google form and I think my github account will be added soon.

Hi @colbybanbury,
We could potentially add a tag to the current commit and label it as v0.5 and move forward with the development on main branch. wdyt? We can also discuss it in the next meeting.
Thanks.

Friendly reminder about this PR. We're using this change in our future submission and I appreciate if we can decide if we could merge this to the API.
thanks!


Reorder Nodes

Hello,
I am just wondering if you can reorder a node in a tree? Similar to sortable. Right now I believe you can only drag nodes into groups but you can not reorder them.
Thanks,

Hi @tyler1314371 !

I am just wondering if you can reorder a node in a tree?

Actually, yes, you can with the proper implementation.
I just wrote a code snippet to demonstrate one way to do it :
import React from "react"
import { TreeView } from "bosket/react"
import { dragndrop } from "bosket/core"

import "./reorder.css"

export class ReorderTree extends React.Component {

    selectionPreset = dragndrop.selection(() => this.state.model, m => this.setState({ model: m }))

    state = {
        category: "children",
        selection: [],
        onSelect: _ => this.setState({ selection: _ }),
        // Model items have an order property
        model: [
            { label: 1, order: 0, children: [
                { label: 2, order: 0 }, { label: 3, order: 1 }, { label: 4, order: 2 }
            ] },
            { label: 5, order: 1, children: [
                { label: 6, order: 0 }, { label: 7, order: 1}, { label: 8, order: 2 }
            ]}
        ],
        // I put a placeholder to drop on, to reorder the elements instead of adding to a folder contents
        display: _ =>

                { _.label }
                reorder

,
        strategies: { selection: ["single"], /* and for clarity : */ fold: [ _ => false ]},
        // Sort by order
        sort: (a, b) => a.order - b.order,
        dragndrop: {
            // Use the "selection" drag and drop preset
            ...this.selectionPreset,
            drop: (item, event, inputs) => {
                // If we drop on a placeholder, reorder
                if(item && event.target.className === "order-placeholder") {
                    inputs.selection[0].order = item.order
                    inputs.model.forEach(_ => { if(_.order >= item.order) _.order++ })
                    // Drop on ancestor
                    this.selectionPreset.drop(inputs.ancestors[inputs.ancestors.length - 1], event, inputs)
                } else {
                    this.selectionPreset.drop(item, event, inputs)
                }
            }
        }
    }

    render = () => <TreeView { ...this.state }></TreeView>
}

.order-placeholder {
    border: 1px solid #444;
    border-radius: 5px;
    background: #CCC;
    opacity: 0;
    margin-left: 10px;
    width: 200px;
    transition: opacity 0.2s;
}
li.dragover > span.item .order-placeholder {
    display: inline;
    opacity: 0.6;
}

And when used :

How do you do this with angular?  I can't figure it out from the comments above in react.


fix: add $DISK_NAME to launch-without-cached-state

Motivation
Add missing string replacements missing from #7690, and add the $DISK_NAME variable when launching the container
Solution

Replace all /sbd with /$DISK_NAME
Add $DISK_NAME before docker run in launch-without-cached-state job

Review
Nothing specific
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Running a full-sync here to confirm it starts running: https://github.com/ZcashFoundation/zebra/actions/runs/6461129131
We don't have to wait for this to finish, it's preferred to run the full sync from the main branch

I've bumped this priority down to high so it doesn't interrupt other merging PRs.

@mergifyio refresh

This PR isn't being queued because this rule isn't satisfied:
all of: [📌 queue conditions of queue batched]
any of: [🛡 GitHub branch protection]
check-success=Zebra tip / Run full-sync-to-tip test
But I can see the patch job in the task list:
CI Docker / Zebra tip / Run full-sync-to-tip test (pull_request) Successful in 2s
Required
Details
@gustavovalverde this might be a weird mergify or workflow bug?

@teor2345 I triggered a manual full-sync-to-tip from this branch, and it's still running. That might be the reason (?).

@teor2345 I triggered a manual full-sync-to-tip from this branch, and it's still running. That might be the reason (?).

That seems unlikely, manual syncs have never blocked merging before.
It could be a once-off Mergify bug.


Image uploaded and sent to replicate not appearing on front-end

After uploading my photo for replicate API to do its work, it only appeared serverside and i can only see the photo on replicate but it's not being parsed to the front-end client to view.

Could it be because of the new model Nutolope merged from the pull request?

it seems to

only be appearing in localhost

did you solved this? im havving the same issue

There's something with the new model, I have the same POST Issue and, also this GET issue:
TypeError: Cannot read properties of undefined (reading 'toLowerCase')
at handler (/var/task/.next/server/pages/api/generate.js:124:84)
at async Object.apiResolver (/var/task/node_modules/next/dist/server/api-utils/node.js:372:9)
at async NextNodeServer.runApi (/var/task/node_modules/next/dist/server/next-server.js:488:9)
at async Object.fn (/var/task/node_modules/next/dist/server/next-server.js:751:37)
at async Router.execute (/var/task/node_modules/next/dist/server/router.js:253:36)
at async NextNodeServer.run (/var/task/node_modules/next/dist/server/base-server.js:384:29)
at async NextNodeServer.handleRequest (/var/task/node_modules/next/dist/server/base-server.js:322:20)
at async module.exports (/var/task/___next_launcher.cjs:29:9)

Hey all. I've just simplified the repo to remove auth and payments so you can clone and deploy very easily, only with a Replicate environment variable. Try it out and if you still have any problems, please open a new issue and I will take a look!


[Caloris] Notion page + link from app to explain Query Tables

cc @fontanierh created this to track in Caloris

the page is here :
https://dust-tt.notion.site/Table-queries-on-Dust-2f8c6ea53518464b8b7780d55ac7057d?pvs=25
Not sure where to link it yet

Let's slap a button somewhere in the description of the action in the assitsant builder as first itention

Sounds good, on it


Conflict between CastOperator.Implicit and StaticAbstractsGeneration.MostCommon

Describe the bug
When we use implicit primitive casting and try to generate an IVogen interface, we get an error like this one:

Error CS0535 : 'ToDoItemId' does not implement interface member "IVogen<ToDoItemId, int>.explicit operator int(ToDoItemId)"

Steps to reproduce
Add the following code to an empty project and compile.
[assembly: VogenDefaults(
	toPrimitiveCasting: CastOperator.Implicit,
	staticAbstractsGeneration: StaticAbstractsGeneration.MostCommon)]

[ValueObject<int>]
public readonly partial record struct ToDoItemId;

Expected behaviour
We should be able to provide implicit cast operator with IVogen interface.

Thanks for the bug report @ValeriyGourov .
The issue here is that Vogen is generating both implicit and explicit operators, which isn't allowed in C#.
The defaults for VogenDefaults are explicit casts to and from the primitive. You're specifying an implicit cast to the primitive and also an explicit cast to the primitive by using StaticAbstractsGeneration.MostCommon.
To get this work, use:
                     using static Vogen.StaticAbstractsGeneration;

                     [assembly: VogenDefaults(
                         toPrimitiveCasting: CastOperator.Implicit,
                         staticAbstractsGeneration: ValueObjectsDeriveFromTheInterface |
                                                    EqualsOperators |
                                                    ExplicitCastFromPrimitive |
                                                    ImplicitCastToPrimitive |
                                                    FactoryMethods)]

The compilation errors are not great though, so I've added a check to spot both types of cast and it writes:
error VOG036: ToDoItemId should have either an explicit or implicit cast to or from the wrapper or primitive,
but not both. Check that the global config isn't specifying a conflicting casting operator.
Check 'toPrimitiveCasting', 'fromPrimitiveCasting', and 'staticAbstractsGeneration'. 'staticAbstractGeneration'
defaults to explicit casting, so if you change the default, you need to change it here too. See issue 720
(https://github.com/SteveDunn/Vogen/issues/720) for more information.

This will be in the next beta release.
Thanks again for the report, let me know if there's anything else I can clarify.

@SteveDunn Thanks! 😊


Bootstrap assets are always loaded even if the dependecy is removed

I am trying to change the assets, the first reason for this is because i want to set a custom bootstrap made from less.. for now i am just trying to remove the bootstrap and then load other files that will replace the default bootstrap..
first, i tried removing the line yii\bootstrap\BootstrapAsset' in AppAsset.php, but even without this line, bootstrap is loaded, i thought it was because the server didn't send any header that changes the assets so i pressed ctrl + f5 to force download. but still it is there
the second method i tried was adding this array in the main.php file and also removing the bootstrap dependecy in AppAsset.php
'assetManager'=>[
	'bundles'=>[
		'yii\bootstrap\BootstrapAsset'=>[
			'sourcePath'=>'@webroot',
			'baseUrl'=>'@web',
			'css'=>['css/bootstrap.css']
		],
	],
],

at the first moment i saw that bootstrap was no longer being loaded from the default files, but my custom bootstrap isn't either and the console shows /backend/web/assets/e8b935b7/css/bootstrap.css 404 (Not Found)

'sourcePath'=>'@webroot',

you need to use basePath here. sourcePath will try to publish something.


unify launch plus callback unlocking

I think this should fix #461

graph-size.pdf
Here is a plot showing performance improvement due to this PR.

needs #580 merging first (or more specifically, #580 is part of this that i'd like to appear on master separately)

On digging into callback behaviour a bit more and looking at retry behaviour (which we aren't testing!), it looks like callbacks get lost.
I'll dig into this a little more.

superseded by #600


postEvent should be a no-op if the event stream has no listeners.

See also https://github.com/flutter/flutter/issues/102197
Today, developer.postEvent does json encoding even in product mode. It then makes a native call which eventually checks whether the extension_stream is enabled and bails out early there.
It would be good to:

Expose whether the extension stream is enabled in dart:developer
Avoid doing the JSON encoding if it is disabled

This is desirable for Flutter because we have some events that we post every frame (or almost every frame), and would like to avoid that overhead when doing performance benchmarks that have no listeners.
It would also be good to avoid the overhead of JSON encoding in release mode.

https://dart-review.googlesource.com/c/sdk/+/242081


support list/set when load TEXT file

Although unit-test under normal case can pass,  there still have some problems:

Collections do not support date formats.
In some data formats, the internal order of the collection will change.. (like list)
It's better to add a field in struct.json as the list-data's start and end symbol. (optional)
In theory, CSV file can support list as well, but default delimiter of CSV file is , ,which is conflict with the separator for collection, wonder if there is any good solution?

please merge the two commits into one:
git log # get commit id: COMMIT_1_ID COMMIT_2_ID
git reset {COMMIT_1_ID}
git commit -a --amend
git push mygithub -f


Provide more accurate app start end time

Description
Currently the app start and is tied to SentryFlutter.init which could falsify the result since it's possible to do expensive work even before SentryFlutter.init
Method 1:
// do some processing that take 5 seconds (exaggerated example)
// ...

SentryFlutter.init(...)

// now app start is reported to take 5 second longer

The flutter engine has apis to add a listener
iOS/macOS:  add a view did render callback
Android: using FlutterUiDisplayListener by adding a listener
Now it's decoupled from the initializer and will always be consistent
Method 2:
Use addTimingsCallback and report the very first timing
WidgetsBinding.instance.addTimingsCallback((timings) {
  timings.first.timestampInMicroseconds(FramePhase.rasterFinishWallTime);
});

Might be even more accurate, but needs to be checked if this is feasible since it only triggers approx once every second in release mode
Side notes:
According to this there is a pretty small variance between the two with a p99 of 4.4ms delay however it seems using addTimingsCallback is more accurate so this is preferred

implemented with addTimingsCallback, will be part of 8.11.0


Instructions don't match

The instructions say to go to "Explorer" under "Threat Management" but I don't have the same options. Under "Threat Management", I see

Dashboard
Submissions
Real-time Detections
Review
Policy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58031ac6-a7d2-59ac-59c1-b3e03fbc8f13
Version Independent ID: 82c2a515-4f33-1771-a175-4ed7d9d31276
Content: Use Microsoft Defender for Office 365 together with Microsoft Defender for Endpoint - Office 365
Content Source: microsoft-365/security/office-365-security/integrate-office-365-ti-with-wdatp.md
Product: m365-security
Technology: mdo
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@greggcyrus Thank you for your feedback. I tested that and see Real-time detections only. Later released that you may have Microsoft defender for Office 365 plan 1.
If you have Microsoft Defender for Office 365 Plan 2, then you have Explorer.
If you have Microsoft Defender for Office 365 Plan 1, then you have real-time detections.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @greggcyrus Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


refactor: address-bar.cy.ts

Refactored and optimized the test cases for the address bar functionality.

Improved readability and maintainability of the test cases.
Ensured that all test scenarios retain their original functionality and validations. -Streamlined repeated logic and ensured consistent address checking across different multisig and pure account configurations.

closes #

Submission checklist:
Layout

[ ] Change inspected in the desktop web ui
[ ] Change inspected in the mobile web ui

Compatibility

[ ] Functionality of change validated with a connected account with multisig
[ ] Applicable elements hidden / disabled for watched multisigs / pure
[ ] Looks good for solo multisig
[ ] Looks good for multisig with proxy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Integration tests

We should add some kind of integration tests on release, to prevent such issues as #433. On another hand, it would be hard work, and possibly will not find anything even in long term.
We also don't have unit tests for some parts of our code (like Bedrock part and CLI as well, partially tracked by #371).

Running a few containerized Minecraft servers would be a way to tackle this. I recommend itzg's Minecraft docker images; I've been using those for a while to run servers and they work great. There's an image that runs bedrock too.

I wrote a list of server implementations to test.
Java ones (itzg's docker):

Vanilla
Bukkit
Spigot
Paper
PurPur (7.5% non-vanilla users use it, more than Bukkit has)
Forge
Fabric
Sponge
Mohist
Magma

Bedrock (itzg's docker):

Vanilla
Geyser
Nukkit
PMMP
PowerNukkit

Proxies:

BungeeCord
Waterfall
Flamecord
Velocity
Aegis (maybe, it's not free. But possibly they provide some kind of public server to test)

I tried to include all popular server cores. Maybe it's a lot, and we should cut some of them.

Could be worth including a forge server, or other modded server too

They're under PurPur.


Updated QOS section in readme file

Change Summary

Trimmed the QOS section as it's now separated.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes)
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue(s)

Component(s) name
eos_cli_config_gen
readme.md
Proposed changes

How to test

Checklist:

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated molecule CI testing accordingly
[ ] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Oddly as we have interface defaults and qos, qos-profile merged earlier, they are not in the readme yet.

Oddly as we have interface defaults and qos, qos-profile merged earlier, they are not in the readme yet.


libmongoclient-legacy: add 1.0.2

Update formula.

You need to rebase this against the master branch here and squash it back into one commit before the bot can look at it. It's getting tied up with some of your changes being removed/re-added.

You need to rebase this against the master branch here and squash it back into one commit before the bot can look at it. It's getting tied up with some of your changes being removed/re-added.
I did it and create new pull request.


TensorBoardLogger not saving hparams without metrics

🐛 Bug
log_hyperparams for TensorBoardLogger saves no data with default metrics=None, only hparam entries/names show up in sidebar
To Reproduce
Steps to reproduce the behavior:
import pytorch_lightning as pl
logger = pl.loggers.TensorBoardLogger("./test_logs")
test_dict = {"test":0}
logger.log_hyperparams(test_dict)                      ## no data saved
logger.log_hyperparams(test_dict, test_dict)           ## works
logger.log_metrics(test_dict)                          ## works
logger.experiment.add_hparams(test_dict, test_dict)    ## works but saves in a different events file

Expected behavior
hparams data is saved and viewable via tensorboard with default args
Proposed solution
For default hparams logging without metrics, add a placeholder metric? I can do a PR if this is appropriate.

logger.log_hyperparams({"hp_1":1,"hp_2":2}, {"test_m":0})
### training
logger.log_hyperparams({"hp_1":10,"hp_2":20}, {"test_m":1})

by calling log_hyperparams again at the end of training with the same metric name, the value can be updated... however it does mess up the graph for said metric... so there would have to be a dedicated metric for hparams

This is duplicate of #2406 . The issue we have there, is that usually you log these params at the end, but we cannot guarantee them to be logged for crashes then.

My bad, will move discussions over there


Ability to Blur out environment

A common feature in model viewers is the ability to apply a blur on the environment. This deemphasizes the environment, makes the model pop, more interesting than a flat color, and ability to provide a nicer environment map than the default one generated. I don't think this should change the PMREM generation, such that a very reflective model would reflect the unblurred environment, but curious how other platforms handle this with regard to the corresponding environment map on the model

I think it would be interesting to go beyond blurring to be able to define what the bg looks like. Like maybe you want to use a flat color for the background but use an environment map for lighting.

Maybe just select a mipmap level to display? This does seem to be one of the main differences in our rendering vs filament, if we want those to be more consistent with them.

@cdata this is the single most obvious difference in our fidelity tests with filament, and should be quite a simple fix. Should we add this to the rendering stuff for 0.5?

SGTM


Start systemd symlink service in the role

🗣 Description
This pull request adds tasks to this Ansible role that allow it to start the user-mode systemd service that creates a symlink to the COOL file share.
💭 Motivation and context
We want to enable this service for the VNC user in all our COOL AMIs, not just in cisagov/pca-gophish-composition-packer.
🧪 Testing
All pre-commit hooks and molecule tests pass.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

The Kali-based molecule testing will fail until cisagov/skeleton-ansible-role#92 is merged into this repository.  I'll rebase this branch and re-run the GitHub Actions once that happens.


Make angular and friends dev dependencies

The built static files are all that is needed, right? So there should be 0 runtime deps littering users’ disks.

Added in  commit 52dedb76cbdb5bc403803408a22cce8aeb356fb7 :) Note looking at https://github.com/SignalK/signalk-server/blob/ef7a30bb00ed98f06b64fa95203e48bf3168e4bd/src/modules.ts#L197 I think it might need the "--production" flag to npm to not install dev dependencies :)


jsnext:main

Closes #103.

node resolver defers to jsnext:main in package.json.
webpack resolver will as well, in addition to respecting Webpack's resolve.packageMains field properly.
breaking: import/ignore patterns are checked only once export parsing has yielded no results.
This means node_modules with jsnext:main (i.e. Redux) will have names collected in spite of node_modules being ignored by default.

Wait, why? webpack 1 can't handle ES modules, so there's no point looking at jsnext:main.

It can't, yes, but the original ES6 source is necessary for the plugin to lint correctly

Ah, for named imports?
You should consider adding module there as well, then. It's the slightly more standardized (but still will-never-be-in-Node) successor to jsnext:main.
Most libraries are starting to support it now, and it's what webpack 2 will check by default.

Yep, meaning to do that soon 😅

I'll add it to #475.


Switch AMG to build to using github version and add epoch call

Small updates to amg benchmark in integration/apps

Duplicate PR


"no Route matched" metrics

Is it possible to count no Route matched with those values in order to monitor for misconfigurations and misbehaving Kong instances?

@locao do you know if this is possible to get metrics from? If you point me in the right direction I'd be happy to see if I can get this implemented myself.

Hi @Starefossen based on how Kong's plugin system works a plugin will not run if a request doesn't
match a route. So you can't get it from prometheus plugin.

Hi @Starefossen based on how Kong's plugin system works a plugin will not run if a request doesn't
match a route. So you can't get it from prometheus plugin.

Thanks! Any suggestions on how you would approach this challenge then?

You can probably create a fallback route/service pair (like paths[]=/), if all other routes don't match, it will match the default route.


Add unit tests for Out Of Proc worker

We currently have unit tests for the main extension code itself, but not any for the worker.
It looks like we won't be able to directly add them to the existing unit test project so likely a separate project will have to be made for adding those - but the tests themselves should be mostly copies of what we already have with some minor adjustments made for the differing attributes/libraries.

#661 adds worker unit tests, Closing this.


Valgrind reports jump/move on uninitialized value on map with negative key

Take a look in the valgrind log when running the script below:
Map<Int,String> a = {1: 'ok?', -1: 'fail'};

Clever throws a syntax error:
syntax error, unexpected $undefined, expecting ',' or '}' on line 1

And valgrind complains about leaks.


Update CONTRIBUTING.md

Plunkr link is relative, so clicking in github brings you to the URL https://github.com/mbenford/ngTagsInput/blob/master/plnkr.co/edit/tpl:93P2qxOjYmlcYSqDmo39.
Added https so the link correctly goes to the plnkr website.

Changes Unknown when pulling df5676e77785311b486af48b459b26235c52a565 on jkjustjoshing:patch-1 into ** on mbenford:master**.

@mbenford should I just close this?


RrR Return Database

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Needed before we can address https://github.com/idaholab/HERON/issues/12
DO NOT MERGE before #1459, as this builds on that.
What are the significant changes in functionality due to this change request?
Allows RAVEN interface to permit RAVEN inner to return ND data to RAVEN outer via a database (as an alternative to a CSV from an OutStream)

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

All jobs on 85ae251 : canceled by @PaulTalbot-INL
hold tests until precursor is merged


fix: use claim deposit power threshold at time of aggregate

added to pr 304: https://github.com/tellor-io/layer/pull/304


merge package from arlac77/npm-package-template

package.json

chore(package): add<EMAIL_ADDRESS>chore(package): add<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>
rollup.config.js

chore(rollup): import executable

tests/rollup.config.js

chore(rollup): import istanbul
chore(rollup): add istanbul

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding subdirectories for versioned docs.

Fixes #472.
This accompanies #624 and that needs to be merged before this. (Though the merges should happen at essentially the same time.)

In addition to this, we need to add a "version" page. We can probably borrow from node:

instead of

Coverage remained the same at 100.0% when pulling a5aabf3e870018fc14daa38edb9ac2b6c9ccc80a on dhermes:attempt-docs-latest into f73ad7e8fc877e14e2f9c0b4ec42430f2396f770 on GoogleCloudPlatform:master.

Will also need to update the "back to home" link:
https://github.com/GoogleCloudPlatform/gcloud-python/blob/7c5ffd90d6719a9b61c60a608d39a8df7048e822/docs/_templates/layout.html#L61
when updating versions

@tseaver I'm hoping to push this and #624 through today so we can cut 0.4.1.

LGTM

w00t!
http://googlecloudplatform.github.io/gcloud-python/master/ now has c6718f3 (the current HEAD in master)
and
http://googlecloudplatform.github.io/gcloud-python/ redirects to
http://googlecloudplatform.github.io/gcloud-python/latest/
(Though shortly we'll have a landing page there)


supporting an export data to JSON for applied filters

Can be a nifty use-case for many scenarios. Is it possible to use the scroll API effectively from the browser? How does it work when the data sizes are large?
Reference: http://stackoverflow.com/questions/3665115/create-a-file-in-memory-for-user-to-download-not-through-server

Exporting filtered data now possible. Added in v0.4.1 release and updated in the chrome app.


Ignore missing wind speed observations

If the observations are missing currently, the sensor setup fails. If the observations aren't there for wind speed, this then just sets them to none and continues on with the forecast setup.

#78 was coming up for me, but this should be fixed with this.


Add TestEvent Action

As oneview-redfish-toolkit user interested in using EventService, I am able to test my event callback server by submitting a POST request to "EventService/Actions/EventService.SubmitTestEvent" triggering a test event to all subscribed users.

Since we're using EventService.v1_0_4.json, there is no need for the user to specify each event parameter, we should fill the mandatory ones with fake info.

Redfish-Event-Listener can be used as an event listener.


Sendrcv doesn't seem to work across NATs

I played with sendrcv a bit to make it work with blackmagic hardware and other stuff. It works fine on LAN but when I try to phone to the other office and say "hey, open https://webrtc.nirbheek.in/ and read me the number" it doesn't. The video doesn't appear to either side of the connection.
 But, even if you fix it, there is no guarantees it will work. I recommend adding TURN(Coturn is ok) server or(and) putting your server and Coturn in no NAT env.

@riccardocagnasso ,
Yep. ice connection failed.
So. server couldn't establish connection to client, this is usually caused by clients network environment and is a normal thing. Client couldn't establish connection to server because server didn't passed his srflx candidates.
Recommendations from my first comment should do the job.

@alexlapa Should something like this in webrtc.js be enough? Or some modifications to the gstreamer part are required to use a turn server?
Moreover, is it normal that ice connection fails between two NATted peers without proxy/firewalls and other ugly things? This is a bit meh, because it's quite a common configuration. Would it be possible to integrate UPnP port forwarding in this scenario?

var rtc_configuration = {iceServers: [{urls: "stun:stun.services.mozilla.com"},
{urls: "stun:stun.l.google.com:19302"},
{
urls: "turn:webrtc.foo.bar:3478",
username: "foo",
credential: "bar"
}]};

Here's a couple of things I learned about webrtcbin and STUN, which may help:

The Google STUN server works better than the Mozilla one
Both client and server needs to have a STUN server configured. If you're using the Python version of this demo, it doesn't set a STUN server, so you'll need to add it.

It that fails, I also managed to get a TURN server working ... I did it using ReTurn, and by declaring it on the server (not in the JS). The format has to be:
set_property('turn-server', 'turn://my_name:my_password@my_turn_server_hostname')

Fixed by adding a stun server to the python example in b28e46c0d97cb28e945aa6bbd457c16f48dd0170


Dependency on tk

Hi,
Im trying to build this for Edison and I couldn't proceed,as it some point needs 'tk' which need xlib. Jerryscript needs vera++ and vera++ needs tk. I dont think xlib would be available on edison image any time. Is there a plan on how to go about this?

@sragavan please try again after #517 PR.
vera++ is a part of prerequisites script, which is used to download and build tools needed for code checking. Engine itself has no dependencies on them.

@egavrin Thanks for the rapid action. I will check it up.


Fixed #1314:  yielding a function should not call the function

When rejecting a non-promise value, string.replace is used, and the value is passed as second parameter. But string.replace, if the second parameter is a function, will call that function.
This commit fixes this by using value.toString().

LGTM, @petkaantonov ?

Funny what I just saw in /r/javascript: https://www.reddit.com/r/javascript/comments/5m2e8j/string_vs_tostring/dc0wzr5/

Thanks!


hides internal tags from displaying in meta data

Closes #7348
This is a quick fix for the above issue, a more complete fix would involve a utility function to handle visibility wherever tags are displayed.

Can you please update this to take into account whether the internalTags flag is set? Thanks!

That was an oversight. My bad.

Have rebased & moved the commit to #7379


Value predication: The generated Console App and Web Api projects run failed when using metric "RMSE" or "MSE".

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2022: <IP_ADDRESS>0701 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.3.4)
.Net: 6.0
Describe the bug

On which step of the process did you run into an issue:
The generated Console App and Web Api projects run failed when using metric "RMSE" or "MSE" for Value predication scenario.

Data Source
https://testpass.blob.core.windows.net/test-pass-data/taxi-fare.csv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window.
Choose the C# Console App (.NET Core6.0) project template.
Add model builder by right click on the project.
Select Value predication scenario.
On Data page, select the data source and choose fare_amount column as label.
On the Train page, click "Advanced training options..." link, then choose metric "RMSE" or "MSE" and save it.
Click "Start training" button to complete the training.
Click "Add to solution" button on the Consume page to generate Console App and Web Api projects.
Run the generated Console App and Web Api projects.

Expected behavior
The generated Console App and Web Api projects should run successfully when using metric "RMSE" or "MSE".
Screenshot
RMSE:

MSE:

Additional context:
The generated Console App and Web Api projects can run successfully when using metric "RSquared".

The bug has been fixed on the latest main build: <IP_ADDRESS>1301

Verified on the latest main build <IP_ADDRESS>1301, the bug is only repro for metric "RMSE" when training SQL server data.

Related to #2293

The bug has been fixed on the latest main build: <IP_ADDRESS>2402


Added podspec, Swift 2 Updates

Hey! Checked out the project and it looks really cool! I've updated the code for Swift 2.0 (Xcode stripped some extra spaces, sorry :grimacing:).
I've also created a podspec so that others can find the library and use it easily. I can take care of managing the pod, or you can do it (assuming you've pulled latest from master):
git tag 0.0.1
git push --tags
pod trunk push Unbox.podspec

Open for critiques – just let me know!

Hey @ashfurrow! Just merged the swift2 branch into master, so just rebase against the latest master and we'll be good to go :)

Sure, will do tomorrow!

Cool should be good!

Great stuff! Thanks @ashfurrow!


Update user guide

Added documentation of import, export and all review related commands.
Update UI.png
Removed AB4 team pictures
Minor fixes to language.

Pull Request Test Coverage Report for Build 407

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.051%

Totals

Change from base Build 402:
0.0%

Covered Lines:
1714

Relevant Lines:
2196

💛  - Coveralls


0 star

Its not possible to put star to 0 selection, only when the activity start.

yes, at least not by user interaction. You can put start to 0 selection programmatically.
ratingBar.setCount(0)


Consolidate setup configurations

Currently two configuration files (setup.py and pyproject.toml) are present.  Trim to one.

Completed by #101


Finish multifile train script for Casanovo

What's the status of this issue @CamiloPosso?  I'm changing to backlog since I don't see any updates since October
@pdpiehowski

IS this issue still on the list to accomplish?  @CamiloPosso @pdpiehowski @lamccue


[Magellan] Active class isn't added when scrolling

On 6.4.3, the active class is only added to Magellan links when clicking on them – scrolling through the page doesn't add the class.
Example on CodePen.
I don't really get what's causing the issue, but it seems that data-events="scroll" isn't being added to the Magellan element.

Please test it with the is-active class: https://codepen.io/DanielRuf/pen/EdgpOe

I guess we might have fixed the async initialization issues in the latest RC release.


add benchmark framework for Chainer

I implemented benchmark framework for Chainer using ASV.
Currently the following benchmarks are implemented:

convnet-benchmark
Overall performance of MNIST example
Functions: forward / backward of F.{convolution_2d, sqrt, rsqrt}

I'd like to improve benchmark coverage later.

I discussed with @okuta and decided to prepare a different repos for benchmark code.


Upcoming change to Cloudflare Pages projects

Describe the problem
👋
Hi there. John here from the Cloudflare Pages team.
When a SvelteKit project is deployed to Cloudflare Pages, the server-side code is supported through Pages Functions (currently in beta). Unfortunately, by using Functions, each request must go through the server-side Functions code even if it doesn't need to. For instance, an immutable asset request to https://kit.svelte.dev/_app/immutable/assets/_layout-ab34ca4f.css would first have to route through Functions.
This is problematic since the request would "count" as a request to Functions even though only a static asset was served. Further, there is a slight amount of added latency.
Describe the proposed solution
The Cloudflare Pages team has been rolling out support to customize how project Functions are mounted and thus can save money and latency by providing this metadata on build. The @sveltejs/adapter-cloudflare package should expose a set of includes and excludes based on static files generated. For the time being, I suggest we be conservative and include the Functions worker on all routes but exclude on /_app/immutable/.
If the SvelteKit user uses the hooks functionality, they may need to tune these patterns manually on a case-by-case basis.
Alternatives considered
No response
Importance
nice to have
Additional Information
We (the Cloudflare Pages team) will be contributing the relevant changes.

Thank you for the heads up and the forthcoming contribution!

If the SvelteKit user uses the hooks functionality, they may need to tune these patterns manually on a case-by-case basis.

Just to clarify, hooks only apply to routes, not to static assets, so it's safe to bypass the worker for everything that matches the contents of static, and everything in config.kit.appDir (which defaults to _app) as long as it's still possible to configure the relevant cache headers.

hooks only apply to routes, not to static assets

Ah that makes things much easier. Thank you. ❤

as long as it's still possible to configure the relevant cache headers.

Indeed. We'll do that sort of statically via the _headers file. I say sort of statically because we do need to interpolate config.kit.appDir

it's safe to bypass the worker for everything that matches the contents of static

For now, we're going to be fairly conservative with this, matching only static assets that look like a favicon. The reason being that there may be content in that directory that the user does intend to run through functions (e.g. for gating access to a sensitive document). We may walk back on this in the future, but I think it's better to be conservative and not potentially break a deployment.
I'll have a PR ready soon.


Normal  display for Outlook 2013 DPI 120?

Client is reporting a "white line" on a standard Inky button with Outlook 2013 DPI 120 client. Is this due to the client/litmus?
Litmus test: https://litmus.com/checklist/public/badc73d
How can we reproduce this bug?
Standard syntax of using  with Foundation for Emails project. Testing with Litmus, and looking at Outlook 2013 DPI 120.
Write out the HTML (or Inky code) that causes the issue.
<container>   <row>     <columns small="12" large="12" valign="bottom">       <button href="{{fake-link}}">BUY TICKETS</button>     </columns>   </row> </container>
What did you expect to happen?
No "white line" shown on the bottom of the button.
What happened instead?
A "white line" appears, and can't tell if this is normal or not due to DPI configuration by Litmus?
What email clients does this happen in?
Outlook 2013 DPI 120

Going to try a vanilla install of Foundation for Emails (no other sass stuff).

related: https://mosaico.io/email-client-tricks/outlook-2016-weird-1px-horizontal-lines/
No solution at the moment.

Hmm, frustrating. Thanks for reporting!

When sending an actual test send from the Email Service Provider directly into Litmus, we didn't experience this issue. A pretty wild email client.

Tested on Litmus by pasting in:

Tested by emailing:

Same.
This is even happening with Bulletproof buttons: https://litmus.com/community/discussions/3607-outlook-120-dpi-breaking-my-button
Found more here with potential solutions:
https://litmus.com/community/discussions/151-mystery-solved-dpi-scaling-in-outlook-2007-2013
https://www.emailonacid.com/blog/article/email-development/dpi_scaling_in_outlook_2007-2013

@rafibomb try adding the following:
`

    ......
    `


[Task]: Explore codebase of Google Sheet plugin implementation to identify the scope of change with respect to Datatype Handling

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
No response

I was trying to aggregate the information about what kind of data type each widget supports. IMO, this information will help us identify the right datatype for binding parameters. We should always consider the data type of the widget from where the binding parameter's value is coming from. While doing so I got stuck on the Rating widget. And for a corner case, it blocks the entire application. Reference video in Loom for better understanding.
Use case
Let's say a user is trying to build an application with Appsmith. The user wants to use a rating widget but instead of putting a hardcoded value in the maxValue field of the widget he/she wants to provide the value from some other place e.g. a query, an input widget, etc. If the maxValue gets a larger number e.g. a number with 6 digits then the entire application snaps and it doesn't seem to return to its normal state. And if such value is configured to be populated on page load then there will be no way to escape from it.

Finding
H2 Database in Google Sheet integration?
Why
One exciting finding regarding Google Sheet integration is using the H2 database during fetch operation.
Reason
Google sheet doesn't support filtering through where conditions. In order to provide filtering through where conditions to our users H2 database is used as the intermediate storage after fetching the rows from the Google Sheet. Before the data are stored in the H2 database, the table with the identified data types of the columns is created. Later the where conditions logic is applied to the H2 database which comes in very handy to the users. This is a really perfect example of outside-the-box thinking.

Finding
In Google Sheet integration I have found that three different base URIs are used in different methods.
https://www.googleapis.com/drive/v3/files/ (Used by FileDelete, FileInfo, FileList methods)
https://sheets.googleapis.com/v4/spreadsheets/  (Mostly used by all methods)
“https://docs.google.com/spreadsheets/d/ (Used by FileList method)
The reason behind this is that the APIs are designed in such a way. At first it seems a bit confusing but there's no other choice to make.


Contribute to json language server with a custom language.

Allow extensions to enable the builtin json-language-features extension on their own personal json languageId
PR fixes https://github.com/microsoft/vscode/issues/198025
@aeschli
following the PR of https://github.com/microsoft/vscode/pull/146731 as reference
Extensions wanting to enable the json language server
only need to add 2 things to their package.json file:
"extensionDependencies": [
	"vscode.json-language-features"
],
"contributes": {
	"jsonLanguageParticipants": [
		{
			"languageId": "foobar"
		}
	]
}

I am unsure how to go about sending a allowComments setting to the language server
maybe allowComments could be part of schema?
https://github.com/microsoft/vscode/blob/6f7e102f08acbb75fbdbe4c052b425149f10518a/extensions/json-language-features/server/src/jsonServer.ts#L363 currently I've just hard coded the snippets language in jsonServer.ts#L363
and everything relating to comments in languageParticipants.ts#L17-L21 is currently unused

@aeschli should I remove the allow comments sections?
as I'm not sure how to hook them up with the language server

It would be nice if we can keep it simple an only support extending json, not also jsonc.
If we were to support both, the clean way would be to have jsonLanguageParticipants and jsoncLanguageParticipants. I'd rather not do that, given that jsonc is not an spec'ed language and is intended for internal VS Code setting use.
That said, yes, it's already possible to allow comments via scheme, but again, we consider this a VS Code internal thing.

It e.g. needs it to dynamically register the formatters.

Found it
https://github.com/microsoft/vscode/blob/6f7e102f08acbb75fbdbe4c052b425149f10518a/extensions/json-language-features/server/src/jsonServer.ts#L256
Yeah.. html does hardcode handlebars for its dynamic formatter
https://github.com/microsoft/vscode/blob/6f7e102f08acbb75fbdbe4c052b425149f10518a/extensions/html-language-features/server/src/htmlServer.ts#L255
Tho I still have no idea how to pass the languageParticipants to the server
would you be able to give me a pointer in the right direction?

only support extending json, not also jsonc
we can also give the allowComment

I'm not sure I understand, you don't want to support extending jsonc, but you do want to support allowComment?
Currently I have no difference between json and jsonc other than allowComment

it's already possible to allow comments via scheme
I don't want to hard code the snippets language...

I've double checked that works, so I guess I can safely remove the hard coded snippets from jsonServer.ts#L363
global-snippets.json#L3


freeglut: pull upstream fix for -fno-common compiler

Fixes build failure against upstream gcc (defaults -fno-common).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

freeglut builds in master. Why do we need this?

Why do we need this?

So we can drop this once all packages have been fixed: https://github.com/NixOS/nixpkgs/blob/fe5b774b628837c59299c490dc731f441827410d/pkgs/development/compilers/gcc/common/configure-flags.nix#L224-L226

freeglut builds in master. Why do we need this?

It does not if we use toolchain that uses fno-common. That would be unpatched gcc with a change @prusnak mentioned above or vanilla clang-12 from master:
$ nix-build -E 'with import ./. {}; freeglut.override { stdenv = clang12Stdenv; }'
...
[ 32%] Linking C executable bin/Lorenz_static
/nix/store/v8imx1nvyz0hgvx9cbcmh6gp4ngw3ffj-binutils-2.35.1/bin/ld: lib/libglut.a(fg_gl2.c.o):(.bss+0x10): multiple definition of `fghBindBuffer'; lib/libglut.a(fg_window.c.o):(.bss+0x10): first defined here
/nix/store/v8imx1nvyz0hgvx9cbcmh6gp4ngw3ffj-binutils-2.35.1/bin/ld: lib/libglut.a(fg_gl2.c.o):(.bss+0x18): multiple definition of `fghBufferData'; lib/libglut.a(fg_window.c.o):(.bss+0x18): first defined here
/nix/store/v8imx1nvyz0hgvx9cbcmh6gp4ngw3ffj-binutils-2.35.1/bin/ld: lib/libglut.a(fg_gl2.c.o):(.bss+0x8): multiple definition of `fghDeleteBuffers'; lib/libglut.a(fg_window.c.o):(.bss+0x8): first defined here
...

@prusnak @trofi : Thanks for explaining.


Port #25474 and #25490 to 2.7

Port #25474 and #25490 to 2.7

Completed in #25499. Will be available in next 2.7 release (2.7.11).


Add link to overleaf template

Added overleaf template to get started easily using Overleaf's online latex editor.

Thanks,


Laravel 8 pass attributes down to nested components

Laravel Version: 8.20.1
PHP Version: 8.0.1
Database Driver & Version: N/A

Description:
I have 2 components and I am trying to pass down attributes from one component to the other.
Steps To Reproduce:
File: resources/views/home.blade.php
<x-form-input name="username" />

File: resources/views/components/form-input.blade.php
<x-input type="text" {{ $attributes }} />

File: resources/views/components/input.blade.php
@php
dd($attributes);
@endphp

<input {{ $attributes }} />

Output:
Illuminate\View\ComponentAttributeBag {#1451 ▼
  #attributes: array:1 [▼
    "name" => "username"
  ]
}

As you can see only 1 attribute is outputted even though form-input component added extra atribute type="text"
Expected result should of been 2 attributes type and name
I also tried putting :attributes="$attributes" instead of {{ $attributes }}, but same problem occurs.
Am I doing something wrong or not understanding how the attributes work?

This isn't supported atm but will be supported in Laravel 9.

@Swanty as a workaround until Laravel 9 is released try this:
<x-input {{ $attributes->merge(['type' => 'text']) }} />

https://laravel.com/docs/8.x/blade#non-class-attribute-merging


IPolicyEvaluator.AuthorizeAsync Returns Wording is Not Clear

On the IPolicyEvaluator.AuthorizeAsync Method page, the Returns message states the following:

Returns Success() if authorization succeeds. Otherwise returns Forbid() if Succeeded, otherwise returns Challenge()

The part that is confusing to me is:

Otherewise returns Forbid() if Succeeded

Maybe it should be

Otherwise returns Forbid() if Failed

I'm not sure what the author was trying to say.  I'm happy to submit a PR if someone could clarify what the intent was 😄

@scottaddie

Hi @HaoK - I just realized the comments are coming from the code.  Can you clarify your comments here?  Thanks!

Yeah its a bit confusing...  So basically its doing the following:
If authorization succeeds, AuthorizationPolicyResult.Success is returned.
Otherwise: it returns Forbid if the AuthenticateResult.Succeeded, otherwise it will return Challenge.
Basically if authZ fails, it returns forbid if authN was successful, otherwise it will return challenge.

I think I get it now.  If the policy fails (therefore I don't have access) and If I have been authenticated return Forbid otherwise return Challenge as I haven't been authenticated.

After reviewing the code I noticed there are 2 types involved here, not one.
FYI, when you read the docs on the website it omits stuff I see in the code summary that I think helps clarify to the reader.

vs


Fix bug slip

For MultiFaultCalculator slip output is missing, only 0s shown

No bug, aseismic slip was set to 0


No script was returned when scripting as Create on object StoredProcedure

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 6.1.7601

Steps to Reproduce:

Connect to a VM
Open a database existing in the VM
Check the Programmability -> StoresProcedures
Right click an stored procedure and click on "Script as Create"

@rednaxel22 This is under investigation. Can you confirm that the SP is not encrypted?

Is not encrypted.

This is a duplicate of #115


Example on Android, Mac: Recording Silent When Played Back

Version of react-native-audio-recorder-player
3.5.1
Version of React Native
0.66.3
Platforms you faced the error (IOS or Android or both?)
Android emulator, running on a Macbook (Intel)
Expected behavior
Pressing "Play" (in the Example app) should result in a previously recorded sound being played back, audibly.
Actual behavior
Pressing "Play" (in the Example app), after recording a sound results in silence (for the same duration that was recorded). I have ensured that the volume for the android emulator is at its maximum.
Steps to reproduce the behabior
Reviewing the log statements, it LOOKS like although the Android emulator is the target platform, iOS values are being used for "audioSet" (see below)... Is this expected? Could this be the problem?
LOG  Running "RNAudioRecorderPlayer" with {"rootTag":1}
LOG  write external stroage {"android.permission.READ_EXTERNAL_STORAGE": "granted", "android.permission.RECORD_AUDIO": "granted", "android.permission.WRITE_EXTERNAL_STORAGE": "granted"}
LOG  permissions granted
LOG  audioSet {
 "AVEncoderAudioQualityKeyIOS": 96,   <-- iOS value - but running Android emulator (running on a Mac)
   "AVFormatIDKeyIOS": "aac",                   <-- iOS value - but running Android emulator (running on a Mac)
   "AVNumberOfChannelsKeyIOS": 2,        <-- iOS value - but running Android emulator (running on a Mac)
    "AudioEncoderAndroid": 3,
    "AudioSourceAndroid": 1}
 LOG  uri: file:////data/user/0/com.rnaudiorecorderplayer/cache/sound.mp4
 LOG  file:////data/user/0/com.rnaudiorecorderplayer/cache/sound.mp4
 LOG  onStartPlay
 LOG  file: /data/user/0/com.rnaudiorecorderplayer/cache/sound.mp4 volume: set volume

The same problem.

@YevheniiImpltech, @hyochan - I found that if you enter: adb emu avd hostmicon, it enables audio on the android emulator on MacOS.
I've appended this command to the "android" script in package.json:
"android": "react-native run-android && adb emu avd hostmicon".

This is how i solved the problem -> Extended controls (3 dots in emulator control bar) > Microphone > Virtual microphone uses host audio input
https://stackoverflow.com/questions/5924190/how-do-you-enable-a-microphone-input-in-the-android-emulator

Good to know - thanks for the tip!


Index write benchmark

This PR from PR #46 , Because repo changed to public. using this one instead of #46 .
Compared with nebula1.0, nebula2.0 performance has been greatly improved.
Performance improvement reasons:
Implement a wait-free AtomicLogBuffer PR #16

RowWriter decode and encode
Performance compared with nebula1.0:

V1.0
--total_vertices_size=1000000
============================================
StorageIndexWriteBenchmark.cpprelative  time/iter  iters/s
============================================
withoutIndex                                                  3.42s  292.08m
unmatchIndex                                                  4.64s  215.37m
attachIndex                                                  26.83s   37.27m
duplicateVerticesIndex                                      1.35min   12.37m
multipleIndex                                                57.88s   17.28m
============================================

V2.0
--total_vertices_size=1000000
=============================================
StorageIndexWriteBenchmark.cpprelative  time/iter  iters/s
=============================================
withoutIndex                                                  2.75s  364.19m
unmatchIndex                                                  3.52s  284.10m
attachIndex                                                   8.39s  119.24m
duplicateVerticesIndex                                       23.06s   43.37m
multipleIndex                                                26.67s   37.50m
=============================================

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Close this PR. Because the old branch was deleted by mistake, opened new PR #168 instead of this.


namespaceId in ProjectCreate.cs should be an int

On: gitLabClient.Projects.Create(new ProjectCreate { Name = "MyProjectName" });
Exception: Unhandled exception. NGitLab.GitLabException: GitLab server returned an error (BadRequest): {"namespace":["is not valid"]}. Original call: Post https://gitlab.mydomain.com/api/v4/projects. With data {"name":"MyProjectName","initialize_with_readme":false,"issues_enabled":false,"merge_pipelines_enabled":false,"merge_requests_enabled":false,"merge_trains_enabled":false,"snippets_enabled":false,"wiki_enabled":false,"import_url":"","visibility":"private"}
If I understand the GitLab API Docs. right, the namespaceId prop in ProjectCreate.cs should be of the type int.

Hi @megla-hburdow,
You're absolutely right! Thanks for reporting this. We will correct it shortly.


fix JavaBeans naming convention #1023

Fix for issue #1023
Eclipse and Intellij generate getter and setter for pId as getpId and setpld respectively
while lombok generates getPld and setPId.
When the first character is lowercase and the second character is uppercase in this case 'I' ('I' as an Ice scream), the first character of the field name should not be capitalized.

Yeah, I meet the same trouble with this, I consult the naming convention, and found many existing framework and IDEs like Spring Jackson Eclipse Intellij Netbeans use the naming convention of JavaBeans API specification which in the Chapter 8.8  explain this.Maybe Lombok use the uniform way is better.

As issue #757 explains, due to messups in the spec when javabeans were 'born', 'our' way is also a valid way. Slightly less valid but nevertheless:

10% of the people want geteMail().
6% of the people want getEMail().
10% of the people don't care as long as we don't change it.
74% of the people don't care no matter what we do, because they don't have any fields that have a single lower-case letter followed by an upper case later.

The math says 'leave it as is' wins, 16 to 10 (The current situation is getEMail).
Numbers made up, but unless you have pretty good proof I'm way off base with em I see no reason to doubt them.

NB: Assuming a lot more people complain about this, perhaps we can consider a lombok.config key so you can opt-in to 'geteMail' mode, but check with us first. As is, a pullreq with that change would not be accepted either.


merge from template-sync/template-arlac77-github

.github/workflows/update_package_lock.yml

chore: add<EMAIL_ADDRESS>(jobs.update_package_lock.steps.uses)

.github/workflows/update_readme_api.yml

chore: add<EMAIL_ADDRESS>(jobs.update_readme_api.steps.uses)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.842%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
416

Relevant Lines:
426

💛  - Coveralls