Show images wide, video embed narrow

https://trello.com/c/4kQa7EZO/762-allow-users-embed-videos

Sorry I may be behind as i've been away for a week, but what was the thought around altering the size of the modal depending on whether it's a video or image embed?

So this is mostly an aesthetic thing, which is documented as part of the card e.g. https://trello.com/c/4kQa7EZO/762-allow-users-embed-videos.
There is a functional element to it. In the case of images, we want it to be wider to accommodate cropping, whereas for video it's not ideal, as it means we have really long input fields.


Virus scanner - only load timestamps if !!'since'

We only need timestamps if we're scanning files modified from a certain
date. Loading timestamps can take some time.

On the line further down, logger.info(f'Processing file from {file_meta["last_modified"]}: {file_meta["path"]}'), does last_modified definitely exist if we don't load timestamps?

hmm....no. Good point.

@samuelhwilliams Have updated

Yep, just testing it out


'(U)Int.init(ObjectIdentifier)' should have a 'bitPattern:' label

Int.init(ObjectIdentifier) and UInt.init(ObjectIdentifier) should have a bitPattern: label to be consistent with other similar APIs.
Initial draft.

I think this is good to go!  :shipit:


Kinetics Pre-trained weights

Hello,
Thank you for making this available and easy to use. I was hoping that there would be some model weights from Kinetics available for those of us who don't have the resources to train this ourselves. Any ideas on when pre-trained weights will be available?
Thanks again.

You can find some in the author's repo, in JAX though: https://github.com/deepmind/deepmind-research/tree/master/perceiver#colabs


exit code 0 when there are exceptions prior to tests

This problem is demonstrated by putting the following code in spec/spec_helper.rb of a rails project.
require 'simplecov'
SimpleCov.start 'rails'
raise "some exception in the class loading before the tests start"

When rspec is invoked via rake, the above exception is logged to stderr and no tests are run, but the rake process exits 0 (i.e. success), where it should exit non-zero (failure) as it does when the SimpleCov.start is omitted.
Context:
This is a simplified version of the problem we encountered.  We had a CI box that didn't receive a new config file required by a codebase change.  When rake (rspec) ran, our app initialization code correctly raised an exception to protest but because our test suite was running under simplecov the rake (rspec) task exited 0 (success) indicating a passing build.
Environment:
ruby 1.9.2-p180,
simplecov gem 0.4.2
rspec gem 2.5.0
rubygems 1.6.2
Extra information:
I note that if I register an at_exit handler which does NOT call SimpleCov.result.format!, the exit code is propogated correctly (though of course no report will be produced).  E.g.  SimpleCov.at_exit { puts "simplecov at_exit handler - doing nothing" }
Thanks for any help, and for your work on this gem!

This is included in the new 0.5.4 release, thanks a lot!


Add Katex component

This pull request will expand the vue-katex API to include a KaTeX component that will provide users an alternative to using the v-katex directive to render KaTeX.
Changes

Add KatexElement

A component that will display KaTeX
Supports all options available in KaTeX

Add documentation for KatexElement on readme
Increment version from 0.1.4 to 0.2.0

In accordance with expansion of API

Improve code coverage from 88% to 93.75%

Let me know if you agree with the changes I've made here. If you do, please merge and if not let me know and I'll be happy to make changes to my PR.
Cheers :)
Jake

Codecov Report

Merging #4 into master will increase coverage by 4.86%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   88.88%   93.75%   +4.86%
==========================================
  Files           2        3       +1
  Lines           9       16       +7
  Branches        3        4       +1
==========================================
+ Hits            8       15       +7
  Misses          1        1

Impacted Files
Coverage Δ

src/components/KatexElement.vue
100% <100%> (ø)

src/plugin.js
80% <100%> (+5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fb8dd...dcc1aab. Read the comment docs.


update yarn v2 to reflect documentation

Reasons for making this change:
This PR assumes yarn users are NOT utilizing Zero-Installs.
Reason for not defaulting to Zero-Installs is due to link [2]
Links to documentation supporting these rule changes:
[1] https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
[2] https://next.yarnpkg.com/features/zero-installs#does-it-have-security-implications

Can you provide data on which is the most common use case with yarn? zero-installs or non zero-installs


Parties page styling

Quite a few changes to make picking a party better than ever. Let me know if I missed any states for styling.

It looks like this:

For the blue, it's your call. I tried to match something closer to Rdio. I don't know if that's the right direction, but I think the experience outside of the party room needs a bit of color.

Well, if Marek is ok with the death of his banana, I say let's go for it.


Combining plotting, statistics reporting into a post analysis class

While leaving the ability to do these things separately is nice, it could be potentially cleaner to have a big post analysis class that does the following:

allow for plotting of the fits
do statistics reporting of the fits
flux/fluence calculations.

On point (3): does there exist a way either through astromodels or in the plugin base to compute fluxes? This seems like an essential ability. For one, it would be nice to be able to propagate the fit (covariance or chain) for computing these values rather than just being able to do it for the best fit value.
I may have missed this in the code.

I've added a flux class that is not dissimilar from the plotting class. you specify the unit, energy range, etc. and it returns a pandas dictionary of either the MLE propagated flux and errors or the Bayesian posterior distributions for the flux.


MINOR: allowing for absolute URLs as images

Hello @lorisleiva
thank you for providing this neat helper! Saves me a tone of time! I've noticed an undesirable behaviour I would suggest to fix:
My site has the domain in the theme set ($site.themeConfig.domain) and uses absolute URLs for image (e.g. https://api.imageee.com/bold?text=Launching in five minutes on Owwly&bg_image=https://wheretopost.email/images/owwly/owwly.png). This leads to the domain being prefixed:

You can find the bug in this commit: https://github.com/spekulatius/wheretopost.email/commit/9d5cdc40ef416338ddcb570a276192da1f29fbf5 on my open-sourced website.
The suggested change fixes this by checking if an absolute URL is given. Would be great if you could let me know if this something you would like to merge :)
Peter

Hi there 👋
Well spotted! Thank you for your contribution. 🙂
🍻

Awesome, thank you for merging it in!


lightbox: Modify lightbox to only display valid images and YT Videos.

This modifies the lightbox to only display images inside the
".message_inline_image" class, rather than all images inside the
message body, which currently includes things like the bot icon.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

Merged!  thanks @brockwhittaker!


[Bug]: inconsistent change of type when setting wandb.config with torch.Tensor

Describe the bug
This is with wandb 0.18.6
x = torch.Tensor([1])
print(type(x)) # < class 'torch.Tensor'>
wandb.config.x = x
print(type(wandb.config.sx)) # <class 'str'>

x = torch.Tensor([1,2])
print(type(x))
wandb.config.x = x # <class 'torch.Tensor'>
print(type(wandb.config.x) # <class 'list'>

I'm not sure what exactly the expected behavior is, but I'm pretty sure it's not this.
The way it is now, if you're writing a list to wandb.config and forget to convert it from a Tensor,
you can convert it back with torch.Tensor(wandb.config.x) if it is longer than 1, but if it is length 1 it fails with:
TypeError: new(): invalid data type 'str'

Hi @chedatomasz, thanks for flagging this! I can see the inconsistency this creates, so will raise it with our engineers. Would it work for you to convert to a list if it's length 1, so that you can convert back to a torch.Tensor

Hi @luisbergua ,
That seems like the best course of action. It would also be consistent with the pytorch approach that size 1 tensor is still a tensor, and the number inside should be retrieved by explicitly unpacking with .item()


FR: Support for overriding Firebase Cloud Messaging Endpoint

Describe your environment

Firebase Product: firebase cloud messaging (fcm) service

GO Service trying to send message to FCM.
Step 3: Describe the problem
Unable to do local integration testing with FCM.
Steps to reproduce:

Integrate with FCM Go Library
use messaging.Send() to send the message

At this point I would like to verify if the message has been received properly and I am handling the response properly as well.
As there is no fcm emulator available yet, I wrote a simple HTTP server that can handle the Send API. Now to make this work in local environment, I want to override the messagingEndpoint (https://github.com/firebase/firebase-admin-go/blob/master/messaging/messaging.go#L947)  by using the https://godoc.org/google.golang.org/api/option#WithEndpoint option.
Relevant Code:
Here is the proposed fix:
Introduced ep below in the NewClient method defined at https://github.com/firebase/firebase-admin-go/blob/master/messaging/messaging.go#L911

// NewClient creates a new instance of the Firebase Cloud Messaging Client.
//
// This function can only be invoked from within the SDK. Client applications should access the
// the messaging service through firebase.App.
func NewClient(ctx context.Context, c *internal.MessagingConfig) (*Client, error) {
	if c.ProjectID == "" {
		return nil, errors.New("project ID is required to access Firebase Cloud Messaging client")
	}

	hc, ep, err := transport.NewHTTPClient(ctx, c.Opts...)
	if err != nil {
		return nil, err
	}

	if ep == "" {
		ep = messagingEndpoint
	}

	return &Client{
		fcmClient: newFCMClient(hc, ep, c),
		iidClient: newIIDClient(hc),
	}, nil
}

Clients of this code then call it like so
var opts []option.ClientOption

if emulate {
   opts = append(opts, option.WithEndpoint("http://localhost:3000/v1"))
}

app, err := firebase.NewApp(ctx, conf, opts...)

Question
Is this approach ok?
If yes, I am happy to raise a PR to make this option work.

similar to #298

Already implemented in #373
Although I'd generally recommend a more blackbox testing approach for SDK users, leveraging Go interfaces to swap out the SDK when needed.
type FCMSender interface {
  Send(ctx context.Context, msg *messaging.Message) (string, error)
}


Stack traces for failures now include caller's test code

Thanks for making Detox. We use it quite a bit. Test failures can sometimes be hard to parse though, so this PR adds stack traces that include the caller's test code.
For comparison's sake, here's what a failure looks like on wix/detox (master):
    Error: Cannot find UI element.
    Exception with Action: {
      "Action Name" : "Tap",
      "Element Matcher" : "(((respondsToSelector(accessibilityIdentifier) && accessibilityID('LeftHeaderButtonxxx')) && !(kindOfClass('RCTScrollView'))) || (kindOfClass('UIScrollView') && ((kindOfClass('UIView') || respondsToSelector(accessibilityContainer)) && ancestorThatMatches(((respondsToSelector(accessibilityIdentifier) && accessibilityID('LeftHeaderButtonxxx')) && kindOfClass('RCTScrollView'))))))",
      "Recovery Suggestion" : "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element."
    }

    Error Trace: [
      {
        "Description" : "Interaction cannot continue because the desired element was not found.",
        "Error Domain" : "com.google.earlgrey.ElementInteractionErrorDomain",
        "Error Code" : "0",
        "File Name" : "GREYElementInteraction.m",
        "Function Name" : "-[GREYElementInteraction matchedElementsWithTimeout:error:]",
        "Line" : "124"
      }
    ]

      at Client.execute (node_modules/detox/src/client/Client.js:74:13)

And with this branch:
    Error: Cannot find UI element.
    Exception with Action: {
      "Action Name" : "Tap",
      "Element Matcher" : "(((respondsToSelector(accessibilityIdentifier) && accessibilityID('LeftHeaderButtonxxx')) && !(kindOfClass('RCTScrollView'))) || (kindOfClass('UIScrollView') && ((kindOfClass('UIView') || respondsToSelector(accessibilityContainer)) && ancestorThatMatches(((respondsToSelector(accessibilityIdentifier) && accessibilityID('LeftHeaderButtonxxx')) && kindOfClass('RCTScrollView'))))))",
      "Recovery Suggestion" : "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element."
    }

    Error Trace: [
      {
        "Description" : "Interaction cannot continue because the desired element was not found.",
        "Error Domain" : "com.google.earlgrey.ElementInteractionErrorDomain",
        "Error Code" : "0",
        "File Name" : "GREYElementInteraction.m",
        "Function Name" : "-[GREYElementInteraction matchedElementsWithTimeout:error:]",
        "Line" : "124"
      }
    ]

       6 | export const signUpFlow = async (mailbox: TempMailbox) => {
       7 |   // user can cancel the sign up process
       8 |   await elementByPath('Landing/createAccount').tap()
     > 9 |   await elementByPath('LeftHeaderButtonxxx').tap()
      10 |
      11 |   await expect(elementByPath('Landing/createAccount')).toBeVisible()

      at Client.execute (node_modules/detox/src/client/Client.js:73:28)
      at InvocationManager.execute (node_modules/detox/src/invoke.js:11:33)
      at ActionInteraction.execute (node_modules/detox/src/ios/expect.js:178:29)
      at Element.tap (node_modules/detox/src/ios/expect.js:270:63)
      at _callee$ (__e2e__/signUpFlow.ts:9:49)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:296:22)
      at Generator.prototype.(anonymous function) [as next] (node_modules/regenerator-runtime/runtime.js:114:21)
      at fulfilled (node_modules/tslib/tslib.js:104:62)

Hmm... that's interesting. I think the stack trace is more or less as I'd expect but the highlighted source listing isn't. I don't know how Jest decides what's the client code and what's the test framework code. Maybe it just scans for _callee$ and since the stack trace in travis doesn't have that it shows the most recent frame?
I'm gonna take a look into it and get back to you.

This was a little hard to track down, what's going on is in jest-message-util, there's a function called getTopFrame inside formatStackTrace that decides which frame in the stack trace is worth highlighting, and it does that by skipping all the stack frames that have common things like "node_modules" or "jest" or "." in the string (among others).
So when a user of detox is running their tests, detox will be inside node_modules so it'll skip that and show the user's own code, but when you're running the detox package's tests, it's going to show you the top frame.

https://github.com/facebook/jest/blob/a1adaff21db93517e60be840303518490cd5d51f/packages/jest-message-util/src/index.js#L253

In the test app's case, detox is inside node modules as well, but as a symlink. It only makes sense if jest ignores symlinks (WAT?).
Anyway, merging, I would very much appreciate if you can take a look at detox test proiand help fix it.
Thanks!


Add en locale package

We need to add the glibc en locale package in addition to the minimal one.
Cc @jakirkham

Oops sorry had opened issue ( https://github.com/conda-forge/linux-sysroot-feedstock/issues/48 ). Do you want to keep this one or that one?

Your issue is better! Thank you!


chore: add browser tests for typescript

Closes #130

Adds browser tests for typescript.
Updates the CI setup for typescript to allow headless browser testing.
Updates the contribution doc to show how to manually trigger browser tests in typescript.

More information
You can change this back to test for node js API in the code https://github.com/std-uritemplate/std-uritemplate/commit/146bbfafd04127dc8db278547e1270847c46ce0e

@andreaTP thank you for the feedback. Expectation 1 and 2 is straightforward. For 3, there's a challenge with:

passing the test data along. In the current setup, the data is passed as arguments for bash scripts. In typescript you get to use process.argv (node api) to get the test data and execute. In a browser setup, there's no way I'm aware to pass this data to a script that is being executed apart from importing the file directly from the folders it's in. The idea I have is to create a test script that has all the test data in it, load it into a DOM of a headless browser and execute it. This breaks the current testing setup:
a. all test data is loaded when the test is triggered.
b. all tests will run when this part of the tests is triggered. There's no per file testing.
Is there an expectation to keep the testing setup as it is or does this scenario allow for a different testing pattern?

headless browsers have complex api, hence helpful libraries like puppeteer are used to give the high level apis. I plan to try and run a headless instance, load the scripts and execute. This I'll do directly, if unsuccessful, then with puppeteer. If this proves challenging, is there room to keep using https://vitest.dev? IMO if we allow a testing framework/infrastructure, it's a simple, little config option.

The idea I have is to create a test script that has all the test data in it, load it into a DOM of a headless browser and execute it.

This looks like a pretty viable approach!
Writing a custom test.js you should be able to load the content of template.txt and substitutions.json on a per-run basis instead of the entire test files.

then with puppeteer

I'm fine using tools like puppeteer to ease the implementation of the test infrastructure.
I hope this unblocks you, let me know if you need further discussion.

Fixed in #139 thanks a lot for spearheading the effort @musale !


Training using MSE than finetuning using MS-SSIM but aux loss goes bigger

Following https://interdigitalinc.github.io/CompressAI/zoo.html#training, I first train with mse with $\lambda$ 0.18 and switch to ms-ssim with $\lambda$ 220, but aux loss goes bigger and bigger. Is this normal? Should I finetune the model with ms-ssim using lower learning rate like 1e-5?

aux_loss being large on its own isn't a problem. Typical values I have observed are aux_loss ~= 15 * batch_size, but this varies depending on factors such as the number of channels, and the batch-to-batch stability of the distributions. But if you want to reduce it to 0, you can try https://github.com/InterDigitalInc/CompressAI/pull/231.


Timeout when a phrase has been generated but not collected on the sender

Timeout happens after 30 seconds when a phrase has been generated but not collected on the sender. This seems too short given the effort required to collect a file.
Will add keepalive function so the sender decides when to give up

keepalive added in b8ecf3a


Adding Bin Packing util for Combining scan tasks

This is used in BaseScanTask to combine scan tasks into a BaseCombinedScanTask up to the split size

@TGooch44 are you going to follow up with a commit to actually use this?
Other than that, LGTM (just waiting on checks)

+1


[Installation]: Dockerfile.rocm requires a torch nightly build that's no longer hosted: requires 2024-07-26, earliest is 2024-08-31.

Your current environment
(current environment is irrelevant because this is a replacement for the nightly build reference)
How you are installing vllm
git clone <vllm https URL>
cd vllm
git checkout -b 0.6.1 v0.6.1
podman build -f Dockerfile.rocm -t vllm-rocm .

Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Just go to dockfile.rocm to change the version from the list u can download


feat(api): fi and optimizer functionality integration

Why is this change necessary?

This change mirrors the addition of new requested functionality related to fiab and optimizer products

How does it address this issue?

[x] It utilizes the updated swagger document that was generated with the fi and optimizer change

Why is the change done this way?

Remain consistent with workflow

What side effects does this change have?

Side effects should be minimal

What testing was done to confirm this works?
Testing will happen when this PR generates various PR's on the various language's SDK repo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Hank seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Codeunit 80 "Sales-Post".OnDivideAmountOnAfterInitLineDiscountAmount

Please do parameter SalesLine returnable by VAR.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Attachment - Unable to upload a pdf file

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Navigate to any chat
Tap the "+" button
Select Add attachment > Choose adocument
Select a pdf file

Expected Result:
The pdf file preview is displayed, user is able to send it in chat
Actual Result:
The "Something went wrong" screen is displayed, user is unable to send the attachment
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>-PR:22437
Reproducible in staging?: No
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/7a74a39b-0e19-45a0-a164-65c33e2f3598
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

@tienifr Can you please look into this?

Not an issue


[release-1.11][CVE-2023-44487] Update grpc v1.58.3

Changes

We should have a fixed version as we use grpc for xds and healtcheck.

I will create PRs for 1.56.3 as it has less changes.


feat: support watch in runs

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

80 of 428 (18.69%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 48.497%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/server/handler/stack/utils.go
16
18
88.89%

pkg/server/util/logging/logger.go
5
16
31.25%

pkg/server/manager/stack/execute.go
0
21
0.0%

pkg/generators/appconfiguration/app_configurations_generator.go
3
28
10.71%

pkg/engine/runtime/kubernetes/kubernetes_runtime.go
0
30
0.0%

pkg/engine/api/apply.go
54
313
17.25%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.5%

Covered Lines:
10474

Relevant Lines:
21597

💛  - Coveralls


Possible to block specific methods/controllers?

Thanks for a nice nuget!
Is it possible to configure it so that it is not on an application leven but more detailed, like having specific IP requirements for a controller/method?
Thanks.

+1

This feature is currently not possible but I'm open to suggestions and PRs which could help with that!
What is the workflow that you were hoping for? Configure different restrictions per route from within the middleware or were you hoping for some MVC style attributes on Controller Actions or something entirely different?


fix(ws): Subscriptions async iterator completes and better error handling

Closes #1827

Fixed with<EMAIL_ADDRESS>

Note @n1ru4l, the iterator from makeAsyncIterableIteratorFromSink does not throw when calling sink.error.

Appreciate y’all putting so much into this already! Please ping me directly in the future if you have a PR ready for me as I have notifications disabled, and only tend to check on the weekends now that I’m still trying to take a break from maintaining
I don’t have time to look into whether or not that is a necessary dependency @n1ru4l , is it? Should we just merge and release this patch bugfix, and then drop it in a minor release as a follow up at least?
lastly can you... you actually created the changeset... 🥺😍 omg you guys are the best!


Audit Trail limit Events

For the new pricing we need a limitation of the audit trail. Audit trail means the change log on the specific objects as well as the events search filter. The limit (time) should be able to set per instance
Acceptance Criteria

[ ] ZITADEL is able to get a limit (time) per instance for how many events should be readable
[ ] Limit is applied when the search events is performend
[ ] Limit is applied when the change log of a specific object is requested (user, app, project, etc)

@eliobischof @stebenz I moved the issue to zitadel repo, as I initialy created it in the wrong repository. Can you estimate on this one pleasE?
Some clarifications can be found here: https://github.com/caos/caos-internal/issues/893

@hifabienne failed events are out-of-scope, right?

@hifabienne failed events are out-of-scope, right?

yes


Add SvhnLabelProvider

What changes were proposed in this pull request?
A label provider for datasets at http://ufldl.stanford.edu/housenumbers/.
How was this patch tested?
Currently only manually tested. I could make a unit test, but we'd basically need the original data file (~100 MB) or create a small one with MATLAB, which I don't have access to these days...

Unfortunately Octave doesn't support the HDF5 variant: http://wiki.octave.org/FAQ#Mat-File_format :(
Yeah, probably not worth the effort. It's only to get a neat example running for now.


Powershell script is wrong

[Enter feedback here]
There is a typo error in the powershell script which results in null value exception

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d8113f5-2769-908d-5fe4-36c5c401fbd9
Version Independent ID: f5965772-6b05-55fa-a2d0-7f6ffb035b65
Content: Rehydrate blob data from the archive tier
Content Source: articles/storage/blobs/storage-blob-rehydration.md
Service: storage
Sub-service: blobs
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

@Pr4v33n23 Thanks for pointing this out!
I have updated the document and changes will go live soon.

The PR request has been raised and these changes should be reflected soon. I am closing this out for now. Please let us know if you have additional issues or questions. Thanks again!


Feature/notify channel settled

Fixes #1824
Short description
The notifications looks ugly due to the long addresses...
Definition of Done

[ ] Steps to manually test the change have been documented
[ ] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Looks good again. I don't know what the issue was. I will resolve the conflicts and integrate the fixups now. Expect a rebase.

The codeclimate actions seem to not work anymore. I never responds. Therefore I'll force the merge.


Agilerl tutorials

Description
Adding three AgileRL gymnasium tutorials to the Gymnasium documentation:

LunarLander with TD3
Acrobot with PPO
Cartpole with RainbowDQN

Type of change
Please delete options that are not relevant.

[x] This change requires a documentation update (addition of AgileRL tutorials to the docs)

Screenshots
Please attach before and after screenshots of the change if applicable.
N/A
Checklist:

[x ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[x ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[n/a] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Hey @Kallinteris-Andreas. I'm on the AgileRL team with @mikepratt1. We've previously spoken with @pseudo-rnd-thoughts on Discord about making this PR. We've created similar tutorials for PettingZoo, where we've been very involved in the community, and were encouraged to do the same for Gymnasium.

Tbh I'm very unsure if we should be putting this kinds of tutorials in the docs. This is more of a tutorial on how to use AgileRL, rather than something specific to Gymnasium, and idk if we have reasons to effectively endorse AgileRL like that.

I would add that tutorials in the gymnasium documentation site, should be about using gymnasium, not using other libraries, though I would support linking to them like we do with Comet Tutorials.
@pseudo-rnd-thoughts thoughts?

I understand your concerns. We approached this in the same way we did with the ones we were invited to make for PettingZoo, but I can appreciate wanting to do it differently for Gymnasium. Let us know how is best to proceed!

Hey @Kallinteris-Andreas @RedTachyon @pseudo-rnd-thoughts how can we proceed?

Ultimately, it is @pseudo-rnd-thoughts's decision

Apologies for the lack of communication on my part and for not replying on this earlier.
Currently, all of our gymnasium tutorials are about how to use gymnasium exclusively (and where necessary with a critical library, e.g., PyTorch). The comet tutorial is an exception to this that will be removed in the future.
Therefore, as this tutorial is about how to use AgileRL with Gymnasium then it doesn't fit our style currently.
In the future, if there is a change in the content of our tutorials then we can reconsider.
Part of our current consideration is we would like to avoid the tutorial section being a hundred tutorials about how to use tool X with gymnasium.
That being said, we are highly appreciative of tutorials for Gymnasium to help users integrate it into different projects
Therefore, we would like to add a third-party tutorial page, like the third-party environment page, for projects to link to their tutorial.


Feature/bds 761 list component refactoring

Jira
http://vjira2:8080/browse/BDS-761
Summary
Creating Web Component version of list component.
Details
Retype JS and SCSS to work with Web Components
How to test
Run the branch locally and check pages under Components->List in the navigation.

@sghoweri @adam2661
This PR also has a lot of the card stuff, please separate them out like @danielamorse did with his bolt-link branch.

This work has been rebased on the features/lit-html-renderer branch in PR #965. Closing this PR.


Custom Fill Colors for Ground Item, Ground Marker, and Object Marker Plugins

I added functionality to allow the user to modify the fill colour of highlighted tiles and objects in the Ground Item, Ground Marker, and Object Marker Plugins, rather than being stuck with the stock black. This feature exists in the NPC Indicator plugin so it makes sense to add it here too.

This mainly consisted of altering the renderPolygon functions in each of the overlay managers to include the fill colour.
For the Ground Items plugin, I added a fillColor attribute to the PriceHighlight class and altered the getHighlighted function to return PriceHighlight instead of Color, to easily access both colors from a single object which are then passed to renderPolygon. I had to do something similar for ColorTileObjects of the Object Marker plugin so the "Remember color" feature would work.
The only thing I'm unsure of is the Ground Items config with these new options. Let me know if you think this looks too crowded and I'd be happy to make changes.

Fixes #14233

Good stuff! One thing to make this even better is the plugin has an issue where it lets you set the fills' opacity beyond 255 which causes the fill to not show. You could do this in the config
@Range(
     max = 255
	)
@ConfigItem(
     keyName = "fillOpacity",
     etc..

This would be such a useful feature. Any progress on getting this merged in?

any idea what issues need to be resolved before this can be put in the game?

Any update on this being merged into the main client?

Just commenting to see if anyone has looked at this in the past year. I would very much like this improvement to be made.


The readme for sns-js confuses me.

const snsWrapper: SnsWrapper = await initSnsWrapper({
  rootOptions: {
    canisterId: rootCanisterId,
  },
  agent,
  certified,
});

const { metadata: meta, swapState } = wrapper;
const [metadata, token] = await meta({});

console.log("Summary data:", metadata, token);

What is rootCanisterId?
I tried the Website asset canister(6hsbt-vqaaa-aaaaf-aaafq-cai) for openchat and it shows that Canister 6hsbt-vqaaa-aaaaf-aaafq-cai has no update method 'list_sns_ canisters'.
The SNS1 ledger canister id ( zfcdd-tqaaa-aaaaq-aaaga-cai) also does not work.
What is the correct example?
Speaking of which, why can't sns-js automatically look up the container id for SNS and import it? All the above container ids are a pain in the arse for me to find and import manually.

What is rootCanisterId?

rootCanisterId as the canister ID of the root canister of a Sns. See for example a screenshot of OpenChat on the dashboard.
In the particular case of OC, the root canister ID is 3e3x2-xyaaa-aaaaq-aaalq-cai.

Speaking of which, why can't sns-js automatically look up the container id for SNS and import it? All the above container ids are a pain in the arse for me to find and import manually.

I actually does. See Usage in the README:
sns-js can be utilized with two distinct approaches. The first approach is explorative, where you only need to provide the SNS root canister ID of your project to initialize a wrapper that handles routing the calls to the appropriate canister. This means having a single entry point for all functions.

i.e. if you initialize a wrapper with the root canister id the library will provide a single entry point to which "automatically look up the container id for SNS and import it".
For this purpose though you have indeed to use the appropriate root canister ID.
Hope this answer your question.
For sure if you think the README can be improved, feel free to provide a PR. Contribution much appreciated.

This is probably the curse of knowledge.
The way I looked for the SNS root container was to look for the container ID in the SNS proposal in NNS instead of going to the dashboard, now I know.

The way I looked for the SNS root container was to look for the container ID in the SNS proposal in NNS instead of going to the dashboard, now I know.

Gotcha! Yeah that can be confusing, don't know if there is a schema about what are the default Sns canisters and how they interact together. If they would be one we could reference it in the README...


Pulsar components not starting when user provided zookeepers are used

Describe the bug
Pulsar components not starting when user provided zookeepers are used
To Reproduce
Use the following values.yaml when installing pulsar
namespace: pulsar

components:
  zookeeper: false

volumes:
  persistence: true
  local_storage: false

monitoring:
  prometheus: false
  grafana: false
  node_exporter: false
  alert_manager: false

pulsar_metadata:
  userProvidedZookeepers: "zookeeper.zookeeper:2181"

bookkeeper:
  replicaCount: 2
  volumes:
    journal:
      size: 2Gi
    ledgers:
      size: 5Gi

broker:
  replicaCount: 1

proxy:
  replicaCount: 1

Execute kubectl logs pulsar-bookie-0 -n pulsar -c pulsar-bookkeeper-verify-clusterid and see repeating exceptions
08:28:20.955 [main-SendThread(pulsar-zookeeper:2181)] WARN  org.apache.zookeeper.ClientCnxn - Session 0x0 for server pulsar-zookeeper:2181, unexpected error, closing socket connection and attempting reconnect
java.lang.IllegalArgumentException: Unable to canonicalize address pulsar-zookeeper:2181 because it's not resolvable
        at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:71) ~[org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:39) ~[org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1087) ~[org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1139) [org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
08:28:22.056 [main-SendThread(pulsar-zookeeper:2181)] ERROR org.apache.zookeeper.client.StaticHostProvider - Unable to resolve address: pulsar-zookeeper:2181
java.net.UnknownHostException: pulsar-zookeeper
        at java.net.InetAddress.getAllByName0(InetAddress.java:1281) ~[?:1.8.0_252]
        at java.net.InetAddress.getAllByName(InetAddress.java:1193) ~[?:1.8.0_252]
        at java.net.InetAddress.getAllByName(InetAddress.java:1127) ~[?:1.8.0_252]
        at org.apache.zookeeper.client.StaticHostProvider$1.getAllByName(StaticHostProvider.java:92) ~[org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.client.StaticHostProvider.resolve(StaticHostProvider.java:147) [org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.client.StaticHostProvider.next(StaticHostProvider.java:375) [org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]
        at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1137) [org.apache.pulsar-pulsar-zookeeper-2.6.0.jar:2.6.0]

Expected behavior
Pulsar starts and connects to provided zookeeper.
Additional context
$ helm show chart apache/pulsar
apiVersion: v1
appVersion: "1.0"
description: Apache Pulsar Helm chart for Kubernetes
home: https://pulsar.apache.org
icon: http://pulsar.apache.org/img/pulsar.svg
maintainers:
- email<EMAIL_ADDRESS>  name: The Apache Pulsar Team
name: pulsar
sources:
- https://github.com/apache/pulsar
version: 2.6.0

this was fixed at some point and works in version 2.7.0

this was fixed at some point and works in version 2.7.0


Update branch archngv

When running examples/load_graph_archngv.py we get an import error in this line:
https://github.com/BlueBrain/AstroVascPy/blob/5faf2174d4d475325a3b11bc1f065582fc921318/examples/load_graph_archngv.py#L14
The reason is that we changed the interface on main.
Solution:
We should merge the main branch into the archngv branch.

@StephLisa

https://github.com/BlueBrain/ArchNGV
ArchNGV is public now


RFC: Plugin load metadata

The DX / performance of loading plugin process, it requires to load metadata and then it creates a custom node, what if it will work more like this:
 const ctx = new AudioContext();
 const player = document.getElementById('soundSample');

 const mediaSource = ctx.createMediaElementSource(player);
 const pluginURL = "https://wasabi.i3s.unice.fr/WebAudioPluginBank/WASABI/PingPongDelay3";

// Fetch the plugin module (js module or commonjs/whatever)
 const pluginModule = await fetch(pluginURL);

// Just create a plugin node (optionally it could take options after context) no need to know node
// class symbol, plugin is not aware of how it is loaded, but might have logic for additional resources // load, ex. WA
const pluginNode = new pluginModule.Node(ctx);

 mediaSource.connect(node);
 node.connect(ctx.destination);

When we designed the WAP standard, we had in mind the separation of dsp processing and GUI. HTML imports were the future in that time, that is the reason why we used a factory pattern with load and loadGui methods. Now html imports are dead, so we need to rethink the way plugins will be loaded. The idea of a factory is stilll there as plugins might themselves load other things (i.e sound samples) before being ready to be used. A factory might do this job for us, but your proposal is very attractive too. Let's discuss that for SDK V2 if you're interested...


Renamed picker from Version to Docs

Signed-off-by: thisisobate<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Renamed picker from Version to Docs

Verification
Works on local

@bwplotka @squat
PTAL


Add post-link.sh script

Motivation: Allows for executing python scripts which import FreeCAD modules when the conda environment containing freecad is activated.
LIMITATIONS:
Windows is not supported, but could be added easily if someone can test it.
See the following FreeCAD forum discussion for context:
https://forum.freecad.org/viewtopic.php?p=493282#p493277
@looooo said this was a good idea and would try to integrate it a few years ago, but never did:
https://forum.freecad.org/viewtopic.php?p=493282#p493688
The script should support all major shells: bash, zsh, and fish.
If someone could verify this works before merging, then that would be appreiciated!

have you tried using import freecad` in a conda env. This normally does the Path modifications.

have you tried using import freecad in a conda env. This normally does the Path modifications.

That works too, but requires every script to import freecad before import FreeCAD etc.
I don't think that's ideal as this solution which doesn't require artificial import statements in scripts.

My idea was to switch over to things like from freecad import App instead of import FreeCAD as App. This change would resolve name-clashes (which can occur when you use freecad with other python modules) But this is a big change and maybe should happen after a FreeCAD 1.0 release (forcing this new way of importing freecad libraries).

My idea was to switch over to things like from freecad import App instead of import FreeCAD as App. This change would resolve name-clashes (which can occur when you use freecad with other python modules) But this is a big change and maybe should happen after a FreeCAD 1.0 release (forcing this new way of importing freecad libraries).

I think that would cause confusion for developers since freecad isn't available unless you use the conda environment.
Unless, are you talking about making that available for all of FreeCAD regardless of the user's installation method?
I think Python packages and modules that depend on FreeCAD should run without modification in all environments regardless of how FreeCAD is installed.

Normally it should work also with other installations (not only conda)

Maybe its good to set this to on as default.
https://github.com/FreeCAD/FreeCAD/blob/888dcb574396af5c5943b858929ab3b8ab9f3630/cMake/FreeCAD_Helpers/InitializeFreeCADBuildOptions.cmake#L17

Maybe its good to set this to on as default.
https://github.com/FreeCAD/FreeCAD/blob/888dcb574396af5c5943b858929ab3b8ab9f3630/cMake/FreeCAD_Helpers/InitializeFreeCADBuildOptions.cmake#L17

Interesting. Yes, maybe that's a sensible default.
I didn't realize this could be an option for everyone.
I think it's a good idea to enable that as a default, and socialize the following imports:
from freecad import app as App
from freecad import gui as Gui

Then people wouldn't have any problems with Python not being able to find the freecad module.

As an aside, with FreeCAD, you can do the following imports:
from FreeCAD import Console, Placement, Vector  # ✔ works

It would be nice if we could also import these directly from freecad.app like:
from freecad.app import Console Placement, Vector  # ❌ doesn't work currently

To work around that, we'd have to:
from freecad import app
Console = app.Console
# Placement = ...

hmm I guess it would be best to find a consensus about the future of freecad imports. Because in the end all python relevant modules should be installed into site-packages/freecad (imho).
Actually I just refactored a workbench and I used from freecad import gui, and this works, but I have no idea how. If you try this in a python console vs freecad python console you get different results:
from freecad import gui
FreeCADGui == gui

https://github.com/FreeCAD/FreeCAD/pull/11885


Add examples for the Dailymotion support

@SuperSonicHub1

On it.

#10. Check it.

Seen it. Merged and made release (from now on GitHub automatically uploads to PyPi whenever a release is made)


Add memoization to speed up release-lib.nix

release-lib.nix calls packageSet many times. This
results in lots of repeated work, both during eval stage
and when the jobs are run.
By memoizing the calls here we get a very significant
speedup of the eval time on hydra.
Long term, someone should look into fixing or replacing
release-lib.nix so that it does not call the packageSet
argument any more than is necessary.

How much faster?  The eval time for this PR was 3m.  The shortest eval time I have seen without it has been over 17m.

That is a significant improvement, thanks.
However even a 3 minute evaluation is a long time. Why is the package set taking this long to evaluate?
That slowness is the root cause and it also impacts building things from default.nix and starting nix-shell.
If it's absolutely necessary to memoize the package set, now is the time to add memoization release-lib.nix.


terminal repeat bug

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.93.0
OS Version: windows enterprise 21h2

Steps to Reproduce:

there is some output in the terminal, and this output fills up the terminal window.At this point, using the mouse wheel to scroll down is not possible.
Then, use the mouse to drag the top edge of the terminal downward, compressing a certain number of lines, but don't release the mouse. Drag it back up, and at this point, some blank lines will appear at the bottom of the terminal.
At this point, scroll up a certain distance using the mouse wheel, ensuring that the right side is not at the bottom of the terminal.
At this point, continuously click and hold the top edge of the terminal with the mouse, dragging it up and down to constantly change the terminal's size. A large amount of repeated information and blank lines will then appear in the terminal.

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.
If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Thanks for understanding.
/label upstream terminal-conpty windows

the vision i used is the latest vision.
---Original---
From: @.>
Date: Thu, Sep 12, 2024 14:46 PM
To: @.>;
Cc: "Ye<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] terminal repeat bug (Issue #228311)
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


nodejs 14 is required

is this change really needed?

also, please make pull requests in the development branch

yes this is very important for suto hosts like glitch replit etc if the user dont want wo run locally

this isnt thet necessary, the bot doesnt make use of ES2020 or any node 14 feauture

Doesn't djs v13 require node 14

Doesn't djs v13 require node 14

it does

adding engines on package.json just does impossible installing the package when published to the npm registry, however the bot is not gonna be on npm registry

adding engines on package.json just does impossible installing the package when published to the npm registry, however the bot is not gonna be on npm registry

Reason for close


DMS form element does not have correct link

The DMS form element (see screenshot bellow) from the old schema does not linkt to the correct DMS document but instead only has a link to the DMS (without the document path).
The link is part of the variable loading request for the current task.
This could come from #595
Private Zenhub Image
See internal https://git.muenchen.de/digitalisierung/digiwf-support/-/issues/400
Acceptance criteria

The linkt goes to the correct document instead of the landing page of the DMS

Manuell auf Processes-Test und Demo ausgerollt und warten auf Test-Rückmeldung.
Interner MR: https://git.muenchen.de/digitalisierung/digiwf-ops/-/merge_requests/282


add web identity token configuration to ProviderConfig spec

Description of your changes
Adds support for Web Identity token configuration from ProviderConfig
Fixes #1007
Currently Web Identity authentication configuration is only possible with AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_ARN environment variables set.
This causes confusion and ambiguity in several ways and has limitations:

Although consumers specify the role to assume for Web Identity auth at spec.credentials.webIdentity.roleARN, they still need to specify the same role ARN at AWS_ROLE_ARN environment variable to make it work. As reported in #1007, this seems like the users depend on IRSA annotations, however it is actually a dependency to AWS_ROLE_ARN and AWS_WEB_IDENTITY_TOKEN_FILE environment variables. When consumers do IRSA config, these env vars are automatically set, which satisfies the config.
The token to use for Web Identity cannot be specified via ProviderConfig spec and can only be specified through AWS_WEB_IDENTITY_TOKEN_FILE

Consumers might forgot to set the AWS_ROLE_ARN which emits uninformative errors.
This results in a heterogeneous config UX, where role ARN is provided through ProviderConfig and token through env.
Consumers need to prepare ControllerConfigs (deprecated) or DeploymentRuntimeConfigs to mount token files and inject env vars to provider pods.
Consumers are limited to a single Web Identity config per provider pod. It is not possible to configure tokens & roleARNs per provider config, where consumers want multiple provider configs referring to different Web Identity configs (as reported in https://github.com/upbound/provider-aws/issues/1007#issuecomment-1851229653)

This change expands ProviderConfig API specification with spec.credentials.webIdentity.tokenConfig, with options to reference a secret or filesystem location for the token to be used for AssumeRoleWithWebIdentity operations.
Consumers can specify the token's source (Secret or Filesystem) and set secretRef or fs respectively.

ℹ   The change is backward compatible for consumers relying on old behavior where they set AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_ARN environment variables, to allow a smooth transition
⚠ However, this approach is deprecated now and consumers are suggested to update their provider configs to specify the tokenConfig.

Example Web identity token configuration with Web Identity Token from a secret:
apiVersion: aws.upbound.io/v1beta1
kind: ProviderConfig
metadata:
  name: webidentity-example
spec:
  credentials:
    source: WebIdentity
    webIdentity:
      roleARN: arn:aws:iam::123456789012:role/providerexamplerole
      tokenConfig:
        source: Secret
        secretRef:
          key: token
          name: example-web-identity-token-secret
          namespace: upbound-system

example using a filesystem location. Note that Filesystem source option still needs the token file mounted to the filesystem of the provider pod.
The difference is that new API allows specifying the token file per ProviderConfig, meaning that you can mount multiple tokens to the provider pod and reference the desired one at each ProviderConfig
apiVersion: aws.upbound.io/v1beta1
kind: ProviderConfig
metadata:
  name: webidentity-example
spec:
  credentials:
    source: WebIdentity
    webIdentity:
      roleARN: arn:aws:iam::123456789012:role/providerexamplerole
      tokenConfig:
        source: Filesystem
        fs:
          path: /path/to/token/file

I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Tested with provided examples in the PR description for the new feature and uptest for regressions

/test-examples="examples/iam/v1beta1/role.yaml"

/test-examples="examples/ec2/v1beta1/vpc.yaml"

Manually tested:

web identity with new secret ref token config

valid and invalid token paths

web identity with new filesystem ref token config

valid and invalid paths and tokens

old approach with environment variables AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_ARN

non-web identity methods (for regressions)

access key and secret
IRSA
Upbound

combinations with AssumeRoleChain added

Upbound SaaS is also tested by @turkenf

/test-examples="examples/ec2/v1beta1/vpc.yaml"

/test-examples="examples/ec2/v1beta1/vpc.yaml"


Fix height

@delphinus I’ve implemented the feature using my approach. Could you please review the code and provide any feedback? Your input would be valuable to ensure everything is solid.

Nice work! I see your code and it seems good to me. Thanks.


Highlights get overwritten all the time

Hey 👋🏾
in your README you advertise the option to define the highlights directly in a traditional way without hex color values in the setup function call. I like that. The problem: it doesn't work. I looked into the code and you actually redefine the highlights very time the mode changes. That makes it impossible to set them as user. I set the highlight, the plugins overwrites them.
A very simple but effective solution would be to add the default argument (:help :highlight-default).
But honestly I'm not sure if redefining the highlight over and over and over again makes actually sense. I mean why? Isn't it also performance threatening? Setting a highlight causes a couple of more actions by NeoVim in background.
Looking forward to discuss this. Maybe you actually have a very good reason to do it like that. I'm open to make a PR myself.

Ciao!

in your README you advertise the option to define the highlights directly in a traditional way without hex color values in the setup function call

This was meant for themes, which may or not be relevant. If setting the highlights this way in your neovim config, you may need to set them in an autocmd – similar to overwriting theme values.

I'm not sure if redefining the highlight over and over and over again makes actually sense. I mean why?

This is simply due to my lack of neovim/lua knowledge. I would love to not set the highlights multiple times and will explore ways to avoid this.
Appreciate the feedback; This plugin has (relatively) gained popularity recently and in turn there are more minds contributing ideas and improvements and I plan on working through those now 😌

How about using virtual line ?

How about using virtual line ?

This would simplify the cursorline aspect. Definitely worth exploring 😌
I assume that wouldn't interfere with other virtual text such as diagnostics

Using a virtual line is a nice idea. But honestly it has nothing to do with this issue here.
I'll open a tiny PR that solves the problem for the moment without refactoring anything or touching too much.

This was meant for themes, which may or not be relevant.

That doesn't matter. Themes are just a collection of highlight commands.

That doesn't matter. Themes are just a collection of highlight commands.

The ordering does matter, though. If you use the highlight groups as a user you will need to use an autocmd similar to overwriting any theme.


Add create/delete service broker in acceptance

Add service broker creation in acceptance

in life cycle (1_service_broker_lifecycle.robot): add creation as first step and deletion as last step
on others: add creation in SetUp and Clean all service data in test Teardown

Warning: this must be run in a specific space where you have the correct right. The service broker will be created as a private service broker

You code like a sagoin

@arnaudruffin I know, I am planing to give birth to brutal hardcore programming method


Dropdown not working on focus

Thanks for the nice plugin. Please give support on focus also.

You mean for accessibility?

Actually a new requirement for the WordPress.org theme.  I solved by adding some code.
//add for focus.  line 13
var FucusEvents = ('focus' in document) ? [ 'focusin', 'focusout'] : [ 'focusin', 'focusout' ];
// for focus.  line 79
listItem[action](FucusEvents[0], enterHandler);          listItem[action](FucusEvents[1], leaveHandler);

Will work on this as soon as I get some time.

I don't see a reason why we would have fucusEvents where they are both the same on both sides.


Issue installing ivy-c and jbsim on OSX 10.13

in addition to the error mentioned in #2 I get the following error message when trying to install jbsim
==> Checking out revision c4f7f7ce33aac0b0787a2df20acb05eeab6776b3
==> ./autogen.sh
==> ./configure --enable-libraries --enable-shared --prefix=/usr/local/Cellar/jsbsim/1.0-c4f747
==> make install
Last 15 lines from /Users/jann/Library/Logs/Homebrew/jsbsim/03.make:
  CXX      libModels_la-FGMassBalance.lo
  CXX      libModels_la-FGModel.lo
  CXX      libModels_la-FGOutput.lo
  CXX      libModels_la-FGPropagate.lo
  CXX      libModels_la-FGPropulsion.lo
  CXX      libModels_la-FGInput.lo
FGInput.cpp:180:25: error: ordered comparison between pointer and zero ('JSBSim::FGPropertyManager *' and 'int')
        } else if (node > 0) {
                   ~~~~ ^ ~
1 error generated.
make[3]: *** [libModels_la-FGInput.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [install-recursive] Error 1
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1

I have a similar issue using brew on osx 10.13.4 but with different errors:
==> make -C src -f Makefile.osx PREFIX=/usr/local/Cellar/ivy-c/3.15 install
Last 15 lines from /Users/Kolergy/Library/Logs/Homebrew/ivy-c/01.make:
pcrecpp::string
/usr/local/Cellar/pcre/8.42/include/pcre_stringpiece.h:59:12: note: 'pcrecpp::string' declared here
using std::string;
^
8 errors generated.
make[1]: *** [ivythroughput.o] Error 1
make: *** [tools] Error 2
make: *** Waiting for unfinished jobs....
install_name_tool -id /usr/local/Cellar/ivy-c/3.15/lib/libglibivy.dylib libglibivy.dylib
install -m644 libivy.a		/usr/local/Cellar/ivy-c/3.15/lib/
install -m644 libivy.dylib	/usr/local/Cellar/ivy-c/3.15/lib/
install -m644 libglibivy.a	/usr/local/Cellar/ivy-c/3.15/lib/
install -m644 libglibivy.dylib	/usr/local/Cellar/ivy-c/3.15/lib/
install -m644 libtclivy.a	/usr/local/Cellar/ivy-c/3.15/lib/
install -m644 libtclivy.dylib	/usr/local/Cellar/ivy-c/3.15/lib/
If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/paparazzi/homebrew-paparazzi/issues


🚀 Feature: A method for Projects class to update JWT expiration

🔖 Feature description
There is a feature request https://github.com/appwrite/appwrite/issues/5263 for which we need a separate method on Projects class to update the JWT expiration.

🎤 Pitch
I'm interested in working on https://github.com/appwrite/appwrite/issues/5263. So, creating this ticket for referencing it in the PR later. Please let me know if I'm missing something.
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Unfortunately, this is a read-only repo as the code is generated by our SDK Generator, and changes made only here would be wiped in the next release.


Requesting some help to get started.

Hello, this is Ayush.
I would love to write docs for you guys but, Excuse me if this is a dumb request, I am having trouble getting started with your project so if you could just point me in the right direction, it would be really awesome. Quite new to OSS.

Hi @verma16Ayush  ! Thanks for reaching out. If you could send an e-mail to<EMAIL_ADDRESS>with:

Your resume
Links to any portfolio pieces you have to showcase any technical writing you have written in the past
[Optional]: Links to any pieces of shareable code/software you may have written that you have also documented

Again thanks for your interest and we look forward to hearing from you.

Hello @burrage
I had sent in the mail along with a request to have some discussion with the mentors related to project ideas and get a more concrete expectation of what the project is about. I have not received any response since. I turned in my Statement of Interest yesterday to<EMAIL_ADDRESS>anyway since the last date to hire writers is just a day away now. please let me know if you have already filled in the position or if there is anything else I can do to ensure a positive response from your organisation.


feat:updated env variable [ECO-270]

Title- Updated .env variable [ECO-270] for Vuejs
Changes-Standardize .env name for Vuejs
Story-https://contentstack.atlassian.net/browse/ECO-270

Need to change env name as per discussion.


Removing YAML highlighting lines not supported on docs site

The site https://docs.docker.org does not seem to support highlighting lines (hl_lines) for YAML, so removing them to fix the broken display of those code blocks display on the site.

Proposed changes

Unreleased project version (optional)

Related issues (optional)

This appears to be the same as #11947


fix ASM testcase fail

remove unused class

Current coverage is 39.89% (diff: 100%)

Merging #2235 into master will increase coverage by 0.09%

@@             master      #2235   diff @@
==========================================
  Files          1611       1608     -3
  Lines         55856      55734   -122
  Methods       10964      10942    -22
  Messages          0          0
  Branches       7707       7698     -9
==========================================
+ Hits          22231      22236     +5
+ Misses        33625      33498   -127
  Partials          0          0

Powered by Codecov. Last update 2e8297f...607f18a


How to change data location?

Sorry to ask such junior question,and I can't google it out

Hi @AlexLuya,
you can set a custom database-directory path in arangod.conf by adjusting the line directory = /var/lib/arangodb3 to directory = /path/to/your/directory.
On Ubuntu, this file is located at /etc/arangodb3/arangod.conf when using the standard package installation. The permissions of this directory have to be adjusted for user arangodb, e.g. on Ubuntu:
owner can read, write and execute:
chmod 700 /path/to/your/directory

recursively change owner of folder:
chown -R arangodb:arangodb /path/to/your/directory

Hi @AlexLuya
Just sending a quick followup - was maxkernbach's latest message useful for you?
Looking forward to your reply
Best

Hi @AlexLuya

Hi @AlexLuya
I am closing this issue as solved for now.
Please feel free to comment and reopen in case you have further questions.
Best,

Hi,
I'd like to move arangodb database directory to another location as I don't want to increase the size of FileSystem.
Currently it's /opt/arangodb and I'd like to move it to /opt/apps/arangodb. Is it possible without any corruption?
Thanks,
An

As long as nothing touches the data (i.e. server is fully shut down) moving the files should not pose any problem. However, I recommend to copy the data to the new location, change the configuration, then bring the server back up before deleting the files in the original location. You may also want to create a backup before moving anything. I don't see any reason why corruption caused by ArangoDB could occur if you move the files (as long as the server is not running), but there could be other interfering processes on your system.


Partial update optimism not working for singleton resource

React version 16.11.0
Concurrent mode no
Describe the bug
Optimism is not working on partialUpdateShape for a singleton resource.
To Reproduce
I have a singleton resource implemented as such:
export class MySingletonResource extends Resource {
  static urlRoot = "/singleton";

  pk() {
    return "MySingletonResource";
  }

  static url<T extends typeof Resource>(this: T) {
    return this.urlRoot;
  }

  readonly myProperty: boolean = false;
}

When I do:
const data = useResource(MySingletonResource.detailShape(), {});
const update = useFetcher(MySingletonResource.partialUpdateShape());
update({}, { myProperty: true });

I have to wait for the network request to finish before a rerender with the updated data (myProperty is true) is triggered. This delay is very noticeable.
Expected behavior
I would expect the partial update to be applied instantaneously, instead of needing to wait for the network request to finish.

Thanks for the report!
Clarification: by 'network request', do you mean the PATCH started by calling update({}, { myProperty: true });? In other words, you would like the changes to be reflected before they actually commit on the server?

@ntucker Yes - that's the behavior I've seen from other optimism implementations (like Apollo).

I'd like the option to have this as well

Very interested as well

I'm always open to proposals or PRs on how to get this to work. The challenge that's got me a bit paused on solving this is what exactly to do when the request errors out. Some sort of rollback would be needed. The only solution I can think of is to have users write their own rollback algorithm which seems a bit scary as it can easily break the cache state. Perhaps if we limited the types of updates to just updating one entity record it could be done more automatically. I'd love to hear others thoughts on these challenges and what the most important use cases are for everyone.

@ntucker Frameworks like Apollo and graphql-flutter maintain a list of optimistic patches that are reapplied on every data store update. A patch is removed once its corresponding network action either succeeds or fails.

Ah, that definitely seems achievable. I'll see about getting around to this, but would accept any PRs along those lines for this to happen faster :)

No guarantees, but I'll try digging into this sometime

I thought about design a bit: could probably store like this in cacheprovider:
import { ActionTypes } from '~/types';

export default function CacheProvider({
  children,
  managers,
  initialState,
}: ProviderProps) {
  const useEnhancedReducer = createEnhancedReducerHook(
    ...managers.map(manager => manager.getMiddleware()),
  );
  const [state, dispatch] = useEnhancedReducer(masterReducer, initialState);

  /** additions follow: */
  // maybe this should just be part of the reducer's state so it can be handled completely from dispatches?
  const [optimisticUpdates, setOptimisticUpdates] = useState([] as ActionTypes[]);
  const optimisticState = useMemo(() => {
    let newState = state;
    for (const optimisticUpdate of optimisticUpdates) {
      newState = masterReducer(newState, optimisticUpdate);
    }
    return newState;
  }, [state, optimisticUpdates]);
  /** End additions */

  // if we change out the manager we need to make sure it has no hanging async
  useEffect(() => {
    return () => {
      for (let i = 0; i < managers.length; ++i) {
        managers[i].cleanup();
      }
    };
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, managers);

  return (
    <DispatchContext.Provider value={dispatch}>
      <StateContext.Provider value={optimisticState}>{children}</StateContext.Provider>
    </DispatchContext.Provider>
  );
}


Save button moved above helptext

In the Server power operations page, the save button was below the helptext dropdown. when expanded, the save button moves downwards. This is fixed here.

Signed-off-by: Nikhil Ashoka<EMAIL_ADDRESS>

We should try to get this into FW1050.

Fixed: https://github.com/ibm-openbmc/webui-vue/pull/238


[Bug]: Formula column not working

Contact Details
<EMAIL_ADDRESS>What happened?
I have copied a folder from one vault to another, in 3.0.1 it works fine, in 3.2.1 the formula is empty.
I have tried to update the version of the white vault and it has stopped working correctly.
3.0.1 (white theme)
3.2.1 (black theme)
Formula
${row.number}

What platform were you using?
Desktop
Version of the plugin
3.2.1
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

Commit 38444fa3
Fixed!


ArguementError with align_dlib.py

When running any bit of OpenFace on my server I yield the error below.
(This is running compare.py)
> python2 compare.py ../images/examples{lennon*, clapton*}
> Traceback (most recent call last):
>   File "compare.py", line 58, in <module>
>     align = openface.AlignDlib(args.dlibFacePredictor)
>   File "/home/cdecker/.local/lib/python2.7/site-packages/openface/align_dlib.py", line 90, in __init__
>     self.predictor = dlib.shape_predictor(facePredictor)
> Boost.Python.ArgumentError: Python argument types in
>     shape_predictor.__init__(shape_predictor, str)
> did not match C++ signature:
>     __init__(boost::python::api::object, std::string)
>     __init__(_object*)

PIP2 list

openface (0.2.1)
dlib (19.1.0) [I have this version working with openface on another computer]
scikit-image (0.12.3)
scikit-learn (0.18.1)
scipy (0.18.1)
opencv (2.4.13)

OS

Operating system: 4.8.13-1-ARCH

Hi,
Are you running this from the docker container or just from a git pull and the installed software on your OS?
I'm guessing the latter but would recommend the former.  There are far more dependencies for OpenFace than the ones you've listed - getting the environment right is not a simple thing, which is a very good reason to use docker - it lets one person get those dependencies right and encapsulate them for everyone to easily use.  So I'd recommend you to Install docker, then simply type:

docker pull bamos/openface

Then run by:

docker run -p 9000:9000 -p 8000:8000 -t -i bamos/openface /bin/bash
cd /root/openface

Then play:

./demos/compare.py images/examples/{lennon*,clapton*}
./demos/classifier.py infer models/openface/celeb-classifier.nn4.small2.v1.pkl ./images/examples/carell.jpg

See here for further details.
Andrew

@qacollective
Thank you very much for the fast reply. We realized that our python was compiled with gcc6 while other dependencies were compiled with gcc4.9. We fixed this by recompiling it all with gcc4.9.

@redspart how recompiling python with gcc4.9?


C# Add 'this' keyword to class members

Some guys (like me) prefer to use 'this' keyword to reference the class members.
I developed this code refactoring provider ...
AddThisKeywordRefactor.zip

This overlaps a lot with stylecop.analyzers. That package features already an alayzer and quickfixes for this issue.


Remove callback

Resolves #1
Added XO as well.

Hopefully this is what you mean :).

Let me know if you're ok with the changes, then I'll squash the commits.

This should be it I guess? Squash them all up into one commit?

Awesome, thanks for merging! :beers:

:tropical_drink:


Allow scaling zoom delta in ol.interaction.MouseWheelZoom

For my application, the jumps between zoom levels are too high. I've set constrainResolution to false, but this doesn't help because I'm not using a trackpad. I was hoping for a way to scale the zoom delta value.

[x] I am submitting a bug or feature request, not a usage question. Go to https://stackoverflow.com/questions/tagged/openlayers for questions.
[x] I have searched GitHub to see if a similar bug or feature request has already been reported.
[x] I have verified that the issue is present in the latest version of OpenLayers (see 'LATEST' on https://openlayers.org/).

Documentation indicates this should be possible but I cannot seem to get it working with either version 4 or 5.
https://openlayers.org/en/latest/apidoc/module-ol_interaction.html


XHR request to query data triggered on SHIFT key press

Since issue reopening seems to be not possible, creating clone of #5136
Just noticed that at least with versions 4.0.3 and 4.0.6-rc.0, when SHIFT key is pressed down in searchbox then XHR request is triggered. This naturally causes undesired extra queries into backend.
Howto
0) reload page
Open select2 box (with XHR and searchbox)
When search field has focus, press SHIFT key down
=> XHR request is done on every press
type some letter and press SHIFT key
=> SHIFT key press does not generate extra XHR requests
Delete letter typed in step (3)
When search field has focus, press SHIFT key down
=> Redundant XHR requests are not generated
close and reopen select2 box
When search field has focus, press SHIFT key down
=> Redundant XHR requests are not generated
So it seems that issue occurs when box is opened first time. Seems to happen with various meta keys.
Just change example in https://select2.org/data-sources/ajax to be:
$('.js-data-example-ajax').select2({
  ajax: {
    url: 'https://api.github.com/search/repositories',
    dataType: 'json',
    minimumInputLength: 0,
    // Additional AJAX parameters go here; see the end of this chapter for the full code of this example
  }
});

and issue is triggered

Please do not open a new issue - just edit your existing issue and we can reopen it.


windows: ln -s not working use mklink instead

Creating symlinks in windows is still pain and not working. In a bash on windows in 99% of the cases ln -s silently behaves like cp -r causing trouble as this is something very different.
For #152 we need to use mklink instead. This can still be pain due to UAC or other permission issues but we can echo some hint and exit on error. Then windows users can decide to disable the shared software feature or tweak their OS such that symlinks are working properly with mklink.

Fixed with PR #221


Lack of consistency in subcategories naming and sorting

Hi Boby, I figure out there is no consistency neither in subcategories naming  nor in subcategories sorting.
take a look
FastAPI: 01-Book, 02-Video, 03-Documentation, 04-Awesome FastAPI (which is a repo)
Algorithms & Data Structures: 01-Book, 02-Video, 03-Platform, 04- Repo
Git: 01-Documentation, 02-Video, 03-Book, 04-Website
nonetheless if we care about new upcoming changes we should add a contribution conventions (CONTRIBUTING.md) to show new contributors the ropes.
Regards.

That's a noticeable change. We need a general consistent convention for all @djangoex repositories. We are working on that.
Thanks for your contribution. <3

Great, thanks

Dear @reganto, I completely agree. That's something we're working on. I'm hopeful that we'll be able to find a solution shortly. There is no need to close the issue on this matter till then.


Tab bar icons

Will need tab bar icons for:

Scores (scoreboard)
Standings (trophy)

The two current tabs (scores, standings) has icons. As more tabs are added, more icons will be needed


Make JPEG still capture update buffer

Fixing problem on jpeg capture not being updated on each capture call.

Thanks. I got carried away with the video stream and completely neglected the still part.

Only I pushed the cam.run() one line down since there is no need to capture if client is no longer connected.


Adding tests (closing #13)

Summary

96% of coverage.
All modules tested.
A few validators and helpers are still missing.

Closing #13

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.41%. Comparing base (a61014e) to head (fd7dac9).
Report is 30 commits behind head on main.

Files with missing lines
Patch %
Lines

src/skpm/encoding/ngrams.py
0.00%
1 Missing :warning:

src/skpm/encoding/trace.py
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   31.85%   27.41%   -4.45%
==========================================
  Files          24       28       +4
  Lines         656      715      +59
==========================================
- Hits          209      196      -13
- Misses        447      519      +72

Flag
Coverage Δ

?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Vercel category

Vercel was previously under the "web server" category, but they are actually a Platform that runs Next.js servers.

Thanks!


Text will not center

I'm a noob to jspsych, but have managed to get a very small timeline running. However, the text is not presented in the center. I've looked in the .css file and it seems that it should center. Any ideas on why this is? I'm using jspsych 6.1.0 software and running the experiment in brave browser. To add, I've tested it in other browsers and I have the same problem there.

I haven't tested the CSS in brave. Have you looked to see whether it is different in another browser?

I have also tried Chrome and it’s the same. I’ve send the html to a colleague of mine and he is experiencing the same problem.
Sent from my iPhone

On 25 Sep 2020, at 22:46, Josh de Leeuw<EMAIL_ADDRESS>wrote:

I haven't tested the CSS in brave. Have you looked to see whether it is different in another browser?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Same goes for Safari. It's presented in the upper left corner instead of in the middle.

Are you loading the CSS file? It sounds like the file isn't getting loaded correctly.

I think I am. I've copy-pasted the code below.
<

Pocket TNT Learning Phase

I think I am by having this in my script:
    <link href="jspsych-6.1.0/css/jspsych.css" rel="stylesheet" type="text/css"></link>

That should do it. Can you share the full script?

See below
<

Pocket TNT Learning Phase

Find attached!
PocketTNT_Learning+Rating.txt

You've got an extra < at the very start of the file. Maybe that is causing some weird behavior?

I hadn't even noticed that. I changed it and indeed that was causing the problems! Thanks for your help Josh!


Amplify commands returning nothing in mac terminal

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.17.1
Amplify CLI Version
just installed, but amplify commands aren't working so can't tell
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
api
Amplify Commands
configure, status
Describe the bug
amplify commands are not returning anything at all in the Terminal. They don't throw an error or show any output. They just do nothing.
Expected behavior
Configure and status should show a result.
Reproduction steps
run amplify version, or amplify configure, or amplify status
Result: nothing happens

GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

Hi @indiebloom, did you install Amplify CLI globally? I'm not able to reproduce on mac.
I installed with: npm i -g @aws-amplify/cli

This is resolved by running with sudo. Why is that?

I wouldn't recommend installing with sudo because the Amplify CLI does not require it. You may have a permissions issue on your system, possibly with how node and npm were installed, that is bypassed when running with elevated permissions.

@jhockett I did install globally, yes. I have tried using nvm to fix node and npm with nvm install node, but amplify still doesn't do anything without sudo


Scroll Issue

I have create a "Modal" using absolute position and zIndex. Within there I have several InputGroups.
My modal initially looks like this:

If I click on an Input it then looks like this:

I am trying to push the content up so the input is still visible.

Hi, can you try with the latest release and check if it persists?


Subcommands Can't Use Flags

I can't seem to be able to access the bool flags from within a subcommand. Is this a regression?

When I run go run main.go --xts, it works, but when I run go run main.go encrypt --xts, it returns

I also have global flags (database access details) that I need for my subcommands. Would love to see this implemented in this library.

Reading through the issue - it sounds like there's something we can do here! But I'm not quite sure what that is 🔍  I think it would be helpful if someone wanted to followup here.

@lynncyrin to state this issue more succinctly:
app.Flags should be queryable alongside subcommand-specific flags within the cli.Context that's passed into cli.Command.Action's func.

I was stuck with the same problem and got the solution from @erikh:
You can query the global flags in app.Flags from a subcommand with c.GlobalBool, so instead of c.Bool("xts") it's c.GlobalBool("xts").
You also need to specify the global flags before the subcommand, so this should work:
go run main.go --xts encrypt

I'm actually going to remove the help wanted here, because I think https://github.com/urfave/cli/pull/892/ will fix this issue. I'll keep this issue open until someone can confirm, though

I can confirm that this is not an issue anymore.
package main

import (
	"fmt"
	"github.com/urfave/cli/v2"
	"log"
	"os"
)

func main() {
	app := &cli.App{}
	app.Name = "myprogramname"
	app.Commands = cli.Commands{
		{
			Name: "foo",
			Action: func(c *cli.Context) error {
				name := c.String("name")
				age := c.Int("age")
				eligible := c.Bool("eligible")

				fmt.Printf("Name: %s\nAge: %s\nIs Eligible: %v\n", name, age, eligible)
				return nil
			},
		},
	}
	app.Flags = []cli.Flag{
		&cli.StringFlag{
			Name: "name",
			Aliases: []string{"n"},
		},
		&cli.IntFlag{
			Name: "age",
			Aliases: []string{"a"},
		},
		&cli.BoolFlag{
			Name: "eligible",
			Aliases: []string{"e"},
		},
	}

	app.Action = func(c *cli.Context) error {
		name := c.String("name")
		age := c.Int("age")
		eligible := c.Bool("eligible")

		fmt.Printf("Name: %s\nAge: %s\nIs Eligible: %v\n", name, age, eligible)
		return nil
	}

	log.Fatal(app.Run(os.Args))
}

I tried to execute with this code on the v2 branch with the following commands:
go run main.go --name Ajitem --age 30 --eligible
go run main.go --name Ajitem --age 30 --eligible foo
go run main.go -n Ajitem -a 30 -e
go run main.go -n Ajitem -a 30 -e foo

I was able to access the values of the flags in the subcommands without any problem


DbContext and Async/Await

I started using EF7 with SQL Server in a WebAPI projector following the Async/Await pattern.
For retrieving data I am using ToListAsync extension method, and SaveChangesAsync to save data.
In a method that reads and writes data this way, using the same DbContext, I often get the following error:
New transaction is not allowed because there are other threads running in the session

I've tried scoping the work into a EF transaction, but I also got some other errors, due to the Context being used in different threads.
It seems that EF7 SQL Server driver is not able to handle DbContext being used in different threads, which is what happens in a ASPNET project following the Async/Await pattern.
I was able to get it working creating a new SynchronizationContext to force everything to run in same thread. But this will go against Async/Await goals.

@ac-esousa DbContext instances are not thread safe but it should be possible to use them in different threads as long as the access is not concurrent.
Without a repro it is hard to be sure if there is a problem in EF7 or in the way you are using it, but the particular exception you mention is known to arise when using SQL Server if you try to start a new database transaction while you still have an open resultset from a query in the same connection.
In terms of EF, this exception usually appears if you call SaveChanges() inside a loop that is consuming results from an EF query on the same DbContext:

The EF query is backed a SqlDataReader and that SqlDataReader will remain open until you finish consuming the results
SaveChanges() will try to initiate a SqlTransaction.

There are a few threads in StackOverflow.com that describe the issue (usually in the context of previous versions of EF) and the solution.

The way I am using DbContext with async, there is no concurrent use of the same DbContext. But operations might get continued in different threads.
All data retrieval I am doing prior to SaveChangesAsync, is done by one of the following methods:

FirstOrDefaultAsync
SingleOrDefaultAsync
ToListAsync

All from Microsoft.Data.Entity.EntityFrameworkQueryableExtensions
Is it possible for one of these methods to be leaving a SqlDataReader opened?

The reader should be closed as soon as the Task returned by each method is completed (e.g. you have to use await on each individual call to async methods). That is, unless we have a bug somewhere, in which case it would be useful if you could provide:

The exact version of the EF7 bits you are using.
The full stack trace of the exception.
A complete code listing or application we can use to repro the issue on our end.

Sorry for this post.
After some debugging, I found one FirstOrDefaultAsync which did not had await on it, cause the query to be running on background while SaveChanges was being called.
That was the reason for my issue

@ac-esousa no worries! Glad you found where the issue was in your code and glad to help!

I get this error when using async methods in UserManager called from Startup.Configure. They are there to ensure certain data exists within the database.
`public static void EnsureUsersHaveRoles(this IApplicationBuilder app)
{
var context = app.ApplicationServices.GetService();
if (context.AllMigrationsApplied())
{
var userManager = app.ApplicationServices.GetService<UserManager>();
DbSet users = context.Users;
foreach (ApplicationUser user in users)
{
if (user != null)
{
Task<IList> rolesTask = userManager.GetRolesAsync(user);
rolesTask.Wait();
List roles = new List(rolesTask.Result);
                    if (roles.Count == 0)
                    {
                        Task<IdentityResult> addRoleTask = userManager.AddToRoleAsync(user, Roles.DefaultRole);
                        addRoleTask.Wait();
                        Debug.WriteLine($"*** ADDED USER [{user.UserName.ToUpper()}] TO GROUP [{Roles.DefaultRole.ToUpper()}] ***");
                    }
                    else
                    {
                        Debug.WriteLine($"*** USER [{user.UserName.ToUpper()}] HAS GROUP [{roles[0].ToUpper()}] ***");
                    }

                    if (string.IsNullOrWhiteSpace(user.PrimaryRole))
                    {
                        user.PrimaryRole = roles[0];
                        Task<IdentityResult> updateTask = userManager.UpdateAsync(user);
                        updateTask.Wait();
                    }
                }
            }
        }
    }`

As far as I can see, I'm waiting in all the right parts, but I'm still getting the error.

@kieranfoot I think you need a ToList() on the query you are using to iterate over users:
var users = context.Users.ToList();
foreach (ApplicationUser user in users)
{

Without that, you have an active query until the for loop has completed... then you are spinning off other operations within the for loop.

Indeed, I guess I should have figured that. Context is the still working.
Thanks for the help.

At the same time, a CbContext can only execute an asynchronous method


New version: Kingsoft.WPSOffice.CN version <IP_ADDRESS>68

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


BF: Remove imports of datalad.metadata

The datalad.metadata module was removed from DataLad 0.18 and added to MetaLad 0.4.6. It was imported only once in the catalog codebase (and only to get a single constant). Switching the import will restore compatibility with datalad 0.18.
This also bumps the required patch version of Metalad.
Fixes #238 and should resolve #239.
Note, there are still two matches within the catalog module:
❱ git grep datalad.metadata
extractors/datacite_gin.py:lgr = logging.getLogger("datalad.metadata.extractors.datacite_gin")
workflows.py:    return _describe_metadata_elements("datalad.metadata.extractors")

The second is I think OK, as it refers to entry point name. Not sure about the first, whether the logger should be renamed to datalad.catalog.extractors.datacite_gin or whether it's desirable to keep it. I kept it.

Thanks for picking this up @mslw

Not sure about the first, whether the logger should be renamed to datalad.catalog.extractors.datacite_gin or whether it's desirable to keep it. I kept it.

I am not sure about "desirable", but I basically just copied the approach in the studyminimeta extractor.  Either way is probably fine. So I think we can leave it until there some reason that it should definitely be changed.


[IOS] Firebase Storage: Invalid argument in put at index 0: Expected Blob or File.

First of all, thanks for all of your work, you are doing a great job!
I'm trying to upload a blob to firebase by using the https://github.com/wkh237/rn-firebase-storage-upload-sample and dcworldwide' example here: https://github.com/wkh237/react-native-fetch-blob/issues/44
but no matter what i'm doing i'm getting this kind of error:

Blob verbose: Blob constructor called mime image/png;BASE64 type string length 177
log.js:24 Blob verbose: create Blob cache file from file path RNFetchBlob-file:///var/mobile/Containers/Data/Application/7EC98D41-B3AC-47…ts/RNFetchBlob_tmp/RNFetchBlobTmp_f48f64c8-f627-497a-b10b-6cc72f5cf540.png
log.js:24 Blob verbose: register blob onCreated 0
log.js:24 Blob verbose: invoke create event
log.js:36 Blob error: RNFetchBlob could not create Blob : /var/mobile/Containers/Data/Application/7EC98D41-B3AC-4714-AD90-DAEC405B57F5/Documents/RNFetchBlob_tmp/RNFetchBlobTmp_f48f64c8-f627-497a-b10b-6cc72f5cf540.png v {code: "storage/invalid-argument", message: "Firebase Storage: Invalid argument in put at index 0: Expected Blob or File.", serverResponse: null, name: "FirebaseError"}

I also tried to provide it with base64 static string , and it seems like blob is created , but Firebase doesnt like it or doesn't understand that it is Blob object..
I have:
"firebase": "^3.2.1",
"react-native": "^0.30.0",
"react-native-fetch-blob": "^0.8.0",

Hi @cherniv , do you have a sample code of how you use it ? I've tried the sample app and it works fine. (Though there's a little misleading in content-type). From the log you provided

log.js:36 Blob error: RNFetchBlob could not create Blob : /var/mobile/Containers/Data/Application/7EC98D41-B3AC-4714-AD90-DAEC405B57F5/Documents/RNFetchBlob_tmp/RNFetchBlobTmp_f48f64c8-f627-497a-b10b-6cc72f5cf540.png

I think it failed at this line, perhaps the image does not exist at the given path, you can try to create Blob using BASE64 encoded string and see if that works or make sure the file exists.

My code looks like this:
RNFetchBlob
		  .config({ fileCache : true, appendExt : 'png' })
		  .fetch('GET', 'https://avatars0.githubusercontent.com/u/5063785?v=3&s=460')
		  .then((resp) => {
		    testFile = resp.path()
		    console.log('PATH:', testFile)
		    let blob = new Blob(RNFetchBlob.wrap(testFile), { type : 'image/png;BASE64'})
		  // Blob creation is async, start upload task after it created
		  blob.onCreated(() => {
		    // upload image using Firebase SDK
		    return firebase.storage()
		      .ref('rn-firebase-upload')
		      .child(testImageName)
		      .put(blob, { contentType : 'image/png' })
		      .then((snapshot) => {
		        console.log('SNAPSHOT:', snapshot)
		        blob.close()
		      })
		  })
		})

It doesnt work on both iOS simulator and device

@cherniv , I've tried your code and it works on my environment (both iphone and simulator), I've create a branch that contains sample code which is based on your code.  Please try if that works, thank you !

I realised now that it starts working after adding of these two lines:

window.Blob = Blob;
window.XMLHttpRequest = RNFetchBlob.polyfill.XMLHttpRequest;

but when i'm doing this, the fetch api that i'm using to fetch data from my server stops working for my app at all..
Is there a way to do it in a different way?

Because our XMLHttpRequest replaced original one and RN fetch uses whatwg-fetch which is based on XMLHttpRequest. It is possible to fix this problem but I need to do some tests. An alternative way is use the 'fetch' provided by our module, it's not based on XMLHttpRequest.

@cherniv , I'd like to inform you that a beta release 0.9.0-beta.1 might solve this issue for you
To install beta package use the following command :
$ npm install --save react-native-fetch-blob@beta

Usage
See Document

Hi there, thanks for creating this awesome project!
I'm still having problems with fetch on 0.9.1.
Everything works fine when I comment out
window.XMLHttpRequest = RNFetchBlob.polyfill.XMLHttpRequest
export function fetchMarkers(loc) {   return dispatch => {     dispatch(requestMarkers(loc))     return fetch("https://XXXXX.firebaseio.com/markers.json")       .then(response => response.json())       .then(json => dispatch(receiveMarkers(loc,json)))   } }

@kdedakia , thanks for reporting this issue. I'll look into it and update status in #106.
Besides, have you tried Fetch Replacement ? This is a fetch implementation based on our native network module rather than XMLHttpRequest polyfill 😄

Thanks, that completely fixed my issues!

I tried to use Fetch Replacement, but my fetch are breaking, not even silently failed as before :
Object is not a function (evaluating 'fetch(url, { method: 'post', body: JSON.stringify(comment)})

@mlumbroso , thanks for reporting. Please feel free file an issue if something went wrong 😄


 We currently can close a task but this will not kill it on the workers possibly resulting on hanging tasks and workers. This is partly mitigated with the timeouts implemented but a task kill feature would be nice.

Two tasks:

Implement close_task() for the celery task manager
Add a cli option to the Turbinia API client tool to handle closing tasks.
Create an API endpoint (optional) to close tasks via API


Error when using tape

Description
I copied and adapted your basic ES6 template. But when I run I always get the following error in the browser console:
default_stream.js:5 Uncaught Error: Cannot find module 'through' from 'tape/lib/default_stream.js'

Expected behavior
I should see the test results output to consol
Actual behavior
Get the above error
See https://github.com/OpenDirective/spikes/tree/master/kinvey-tests
Environment

Brunch: 2.8.0
Node:  4.4.3
NPM: 2.15.1
Operating system: windows 10 and using git for windows bash

package.json contents
https://github.com/OpenDirective/spikes/blob/master/kinvey-tests/package.json
brunch config contents
https://github.com/OpenDirective/spikes/blob/master/kinvey-tests/brunch-config.js
Other useful files, when present (log, bower.json etc.)
it simply says compiling 35 files into 3 and takes 5 seconds !!
The tape version and test file worked fine with a simpler browserify config
Thanks

Here's the code form vendor.js causeing the problem
require.register("tape/lib/default_stream.js", function(exports, require, module) {
  require = __makeRelativeRequire(require, {}, "tape");
  (function() {
    var through = require('through');
var fs = require('fs');

I see it's a dynamic require - does that cause brunch problems? Ie does it only do static analysis?

More info.
this seems to be the call that should resolve and so return rather than drop through to the throw causing the exception
    if (has.call(modules, path)) return initModule(path, modules[path]);

I can see through/index.js in the modules map and path is "tape/node_modules/defined"

Actually the through require is static so Brunch should be able to handle it.
I've just cloned your repo locally and was able to build and run in the browser from the brunch folder successfully:

That's on OS X. But a similar one seems to happen on Windows (w/o Bash), albeit with the stream shim (used by through) due to an alias for it not being set for some reason (I'm on it; but this doesn't seem to be related)
Could you please upload your public folder somewhere so I could run your locally and try to debug? As I can't seem to reproduce your issue...

Actually could it be related to the fact you're using NPM 2? We require NPM 3 currently, so that could be what gives, too

@goshakkk I'm, 99% sure I tried with npm 3 and node 5, once I realised that was the issue. I think this and the speed problem did not change. Ditto using cmd. I'll re check everything when back on my pc.

hmm, the skellaton's index.html is missing an opening html tag but that doesn't seem to matter here

Yep, this one is what I mentioned in my comments. I'll get around to seeing where it comes from this weekend

I sent a PR for the with-es6 skelleton

@goshakk dud you find anything interesting for solving this? I would like to try brunch but this is a deal breaker for me.
Thanks

@goshakkk

Thanks Paul!