An error occurred: 'MyPlexAccount' object has no attribute 'watchlist'

Hi there. I found your repo when searching around for a way to batch-remove all items from my Plex Watchlist. It seems to me that your python script can accomplish this, but if I've misunderstood please let me know.
I followed the instructions in your readme and ran the script. It gives me an error (title). I'm not sure how to proceed from here. I can provide any debug details if you want them. If there is a way to fix this I'd be very happy. Thank you.

I just tested it and still works. What exactly are you having problems with?

Interesting. Could it be related to Python version? I'm using Python 3.11.0, on Windows 11. I downloaded the repo as a zip, extracted and opened a cmd inside the folder. Python is in PATH.

Run the command python index.py and it works for about 1 second, then outputs:

Ok I just re-read your Readme instructions, I think I skipped "activating" the virtual env. I started all over, fresh repo download, recreated the .env file with my credentials. Then ran python -m venv env with no cmd result. Then ran env\Scripts\activate with no cmd result. Then ran python index.py and I got a new error:

Alright my friend. try on this GUI I just built.
https://plex-watchlist-cleaner.jaw.dev/
code is also open source.
https://github.com/wajeht/plex-watchlist-cleaner-ui

it will give you all the deleted items in watch list

This looks useful for people planning to achieve the solution manually via UI. However, I was planning on using a command-line approach to this solution, since I am integrating it into a larger automation I am writing.
My goal is to clear my Plex watchlist on a nightly basis, because I have my Plex watchlist auto sync to my Trakt watchlist using a different script, and so on a daily basis (via cmd) I will have that sync, and then I planned to use your script to clear my Plex watchlist automatically after.
Question about the original script: Can I modify it to not require a virtual env, so that it will use my main site-packages? My thought is that the script will work for me if I can either 1) Get the virtual env created properly, or 2) Drop the virtual env and use my main one.

use this.
$ python index.py username password

import sys
import json
from plexapi.myplex import MyPlexAccount

def main():
    if len(sys.argv) < 3:
        print("Missing username or password")
        return

    username = sys.argv[1]
    password = sys.argv[2]

    try:
        account = MyPlexAccount(username, password)
        watchlist = account.watchlist()

        removed_items = []

        for item in watchlist:
            removed_items.append(item.title)
            account.removeFromWatchlist(item)

        print(removed_items)

    except Exception as e:
        error_message = str(e)
        print(error_message)

if __name__ == '__main__':
    main()

I appreciate you trying to help me out here. For some reason it keeps failing on me. 🤦♂
I edited the index.py file with your script above, then ran the command with my user:pass in the command as instructed. I am still getting no response.
I even tried all of this on a totally different machine with a completely clean install of Python 3.12 and installed requirements to it. This is what I get:

It's the same response I get when I used the original venv method, the script returns nothing.
Is there a log output anywhere that I can see how/why this fails? I looked in a few folders but I didn't find a log, but perhaps Python itself outputs a log? Or maybe a verbose arg would do so? Sorry for the trouble, at this point I just cant tell if its me or python.

if you read the code, it will append all the removed items into a list and print them out at the end of the task.
if no watchlist was removed, the list will not contain anything.
[]

if anything was removed, it will look like this.
["Spider-Man", "Barbie"]

I just tested again and it worked! It occurred to me that I was juggling too many things at once while diagnosing the original issue, and I had manually emptied the watchlist to start over, but didn't add anything back to the watchlist again. I thought the output would say it found nothing if it hadn't, so I was assuming the script wasn't working.
My mistake, and apologies for the mixup. Thanks again for helping me iron things out, this script will be a big help to me.


Accuracy drop

Thanks for your great work!
I followed the step and running the code successfully.
Unfortunately, the learning curve image shown below show that the accuracy drop to 60% validation accuracy,
where there is a 30% gap with your learning curve.
I don't understand why there are only four label in your tensorboard visualization.
All in all, I'm wondering what's the performance you get while training for 101 labels of UCF101,
and make sure I got anything wrong. Thanks

Hello, what is the shape of the data input into the model?Thanks

感谢您的出色工作！我按照步骤操作并成功运行了代码。不幸的是，下面显示的学习曲线图像显示准确性下降到 60% 验证准确率，而与您的学习曲线有 30% 的差距。我不明白为什么你的张量板可视化中只有四个标签。总而言之，我想知道您在训练 UCF101 的 101 个标签时获得的性能如何，并确保我做错了什么。谢谢

hello, may I ask your acc was finally raised?


ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

pip3 install mgarch
Complete output (6 lines):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/private/var/folders/95/mcc3f9857xn75vy4y9kdjhrh0000gn/T/pip-install-ylu895gc/mgarch/setup.py", line 32
    )\
     ^
SyntaxError: unexpected EOF while parsing

fixed


Confirm use of HTTP 2

We want to be on HTTP 2 for performance etc.
Looks like axios still does not support it https://github.com/axios/axios/issues/1175
@vkarpov15  can you pls look into if we need to change, what the best alternative is, and make the change ?
@alexleventer  can you pls take a look at this to make sure the typescript client is also doing this (cannot remember how we ended with typescript driver using the exact same code)

Related PR: https://github.com/stargate/stargate-mongoose/pull/153. Sorry, did not see this issue before putting in that PR.

fixed by #153


CocoaPods install fails on canary builds

Issue
The canary builds published to npmjs.org are really usable because pod install always fails because CocoaPods cannot handle handle podspec files with version numbers that are start with all zeros 0.0.0.
The same issue exists upstreams for react-native: https://github.com/facebook/react-native/issues/30036#issuecomment-699177689.
Whatever the solution, we want to be consistent with react-native and the other out-of-tree platforms (Windows).
One solution (as I described in the issue above) is to change the canary builds to use some non-zero version number like 1000.0.0.   Another solution is to change the ruby scripts in all the .podspec's to use the commit hash alone as a version number when they see the package.json version starts with 0.0.0-.

Whatever the solution, we want to be consistent with react-native and the other out-of-tree platforms (Windows).

For what it's worth, I think we've also hit and had to workaround tooling issues related to the 0'd semver.

@chrisglein Got any links to issues/PRs that you could point me to?

@chrisglein Got any links to issues/PRs that you could point me to?

I was trying to come up with some issue/PR #s during triage and couldn't find any :(. Maybe @jonthysell or @NickGerleman might remember some?

RNW stills uses 0.0.0-x for published NuGet and NPM packages. The issues I can think of were when tooling thought 0.0.0 builds were old versions, but we haven't seen too many major issues with it. We did see component governance think react 0.0.0-experimental.foo was old though, which was used in a couple of nightly RN builds.
I worry a bit that publishing 1000.0.0 builds could have the opposite problem, where tooling gets confused and points to them as latest. I rmemebr we've had issues with NuGet before doing things like that. There is precedence of FB using 1000.0.0 builds for local builds, but not anything published to my understanding.

In the realm of NPM there are dist-tags and CocoaPods treats any version with a hyphen as a prerelease. In both those cases these dependency managers should not ever select these versions over stable versions.

Yeah, I think the case where I saw issues before was specifically around NuGet which IIRC doesn't interpret prerelease versions, and doesn't have the concept of the latest dist-tag. We tie NPM version to the version of the NuGet package we publish, but the NuGet package is generally not modified too often, so the confusion would probably just be when going to NuGet.org to look at available packages and it showing the wrong thing for the latest published package.
Adding some more context, the upstream issue mentions RNW using 1000.0.0-canary.xxx which isn't quite correct. We went with 0.0.0-canary.xxx to align a bit more with React and React Native. I'm not familiar with how much effort the other solution would be around changing podspec files to use commit hash directly, but kind of like the idea of keeping 0.0.0 just for consistency with other projects.

I'm not familiar with how much effort the other solution would be around changing podspec files to use commit hash directly, but kind of like the idea of keeping 0.0.0 just for consistency with other projects.

It’s going to require a change to CocoaPods, but I don’t believe it’s a critical change. So I’ll take a look at that avenue now that it’s becoming clear that, from the perspective of consistency, that might be the easier path 👍

PR created https://github.com/CocoaPods/Core/pull/657


error when adding a custom character

Describe your bug here.
basically, when trying to load my character sprite sheet this happens: "flixel/graphics/frames/FlxAtlasFrames.hx (line 246)
editors/CharacterEditorState.hx (line 840)
editors/CharacterEditorState.hx (line 520)
flixel/ui/FlxButton.hx (line 521)
flixel/ui/FlxButton.hx (line 507)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)
Uncaught Error: Null Object Reference". How do I fix this?
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Only thing I did was add my character sprite sheet and .xml file

bruh

why the title so weird?

why the title so weird?

idk what to put :(

why the title so weird?

title fixed

why the title so weird?

idk what to put :(

the hell?

why the title so weird?

title fixed

at least its readable now

why the title so weird?

title fixed

at least its readable now

:/

why the title so weird?

title fixed

at least its readable now
can you help tho?

idk,ask someone else

this is literally why I made the issue

bruh

imagine

https://github.com/LilDrippyMyFnf/FNF-BitEnigne

Not a bug
Missing texture files

Not a bug Missing texture files

wait so how do I fix it?

be

Not a bug Missing texture files

wait so how do I fix it?

he just said it

Not a bug Missing texture files

Not a bug Missing texture files

Not a bug Missing texture files

wait so how do I fix it?

he just said it

bro I low IQ WHAT TEXTURE FILE IS MISSING?

i'm stupid

i'm stupid

XP

Not a bug Missing texture files

Not a bug Missing texture files

wait so how do I fix it?

he just said it

bro I low IQ WHAT TEXTURE FILE IS MISSING?

You definitely have a low iq... the texture you set in the json bro.

huh?..

Not a bug Missing texture files

Not a bug Missing texture files

wait so how do I fix it?

he just said it

bro I low IQ WHAT TEXTURE FILE IS MISSING?


Organizations and Profile page breadcrumbs

https://github.com/NuGet/NuGetGallery/issues/5617
Link to manage organizations on profile page:

Link to edit organization on organization profile page:

Link to profile page on account settings:

Link to profile page on manage packages:

Link to profile page on manage organizations:

@joelverhagen The fix looks great at lg and xs but unfortunately bad at the sizes in between (in all browsers). Not sure how to improve it more but it's definitely an improvement over the previous iteration and I don't want to spend too much time on it.


There are several deprecation messages thrown in browser tests that the source of needs to be identified

DEPRECATION: Calling Ember.get without a target object has been deprecated, please specify a target object.
Identify the tests causing these and create issues for them.

All five of these are coming from Integration | Component | sl grid cell


Make React more consistent / re-use the same components everywhere

I'd love to work on this issue.

On second thought, I'd like to work on some other issues first, and then get back to this, as it seems to be very time consuming.


Migrate to tide 0.15, opentelemetry 0.10

Hi!
First off, thanks for this cool lib. Second, sorry for the huge patch. Jumping from 0.7 to 0.10 was fairly significant which on the upside massively simplifies the API internally in the middleware, and for library users as well as removing a few dependencies but on the downside required fairly significant refactors.
One of the nicer things is now we are able to depend on opentelemetry-semantic-conventions to remove a bunch of consts from the lib, and we don't have to worry about setting up transports and things. I believe this PR has feature-parity bar some removed tags but if I've missed something let me know! Because this is quite large, I've added review comments to explain my reasoning below.
Cheers
Alex

Does this PR (or opentelemetry-tide) supports using the trace's parent from the headers?
Something like:
let parent_cx =
                    global::get_text_map_propagator(|propagator| propagator.extract(&headers));
                let tracer = global::tracer("route_rcon_exec");

@bbigras Not yet, but I have patches ready, which I will push after merge of this one.

@bbigras I updated the crate and release version 0.5.0, which comes with proper propagation support.

I tested it and it's awesome!
Would it be a good idea to make a surf helper/wrapper to include the hearders like in https://github.com/asaaki/opentelemetry-tide/blob/1a84aa618c94e28abcc82d7a4f414df470068270/examples/front-server.rs?

AFAIK surf also supports middleware similar to tide. So I could imagine to have also a very similar approach in surf like this crate.
I haven't used surf that much yet to build something.
I might play around with this idea over the holidays and see if something emerges, but no promises.

@bbigras First stab on a surf version: https://github.com/asaaki/opentelemetry-surf
Thanks to the @http-rs team's awesome foundation, it was quite easy to adapt from tide to surf, since they share very similar interfaces.


Add helm-operator app

Fixes #14
In alexellis/k3sup#157 @alexellis like to have the helm-operator as app in k3sup.
Description
The installation of the helm-operator with arkade follows the install progress of the helm-operator. There no custom values at the moment.
Motivation and Context
alexellis/k3sup#157

[x] I have raised an issue to propose this change (required)

How Has This Been Tested?
Installed a fresh cluster
./k3sup install --ip <IP_ADDRESS> --user ubuntu

Installed the helm-operator
./arkade install helm-operator

Added a helm deployment
kubectl apply -f https://raw.githubusercontent.com/aidun/kubernetes_homelab/master/releases/kube-system/nginx-ingress.yaml

Check if helm knows about the deployment
helm list -A

There should be no effects to the other commands.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hi @aidun we have 4 commits now, so could you please squash down?
I like to use git rebase -i HEAD~4 for that, then in the edit screen I squash there, keeping just one commit.
https://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Alex

@alexellis thx for the help submitting my first real PR. The typos has been fixed. The git part was / is harder than the problem itself. I don't  managed it to squash the commit :/ I found a other way :-)

Please read the contribution guide about how to format a commit message body, this is required for PRs. You'll see what kind of info is required, some manual formatting is needed so that the text wraps correctly.
You also seem to have a typo in the PR title.
Thanks,
Alex

Please also add a --wait flag.

Hi @aidun, yes please use the new method of installing apps. I can see you've been waiting for a while. Please don't rely on me getting a one-off notification, my inbox is flooded.
Best ask the community in #contributors on Slack when you need something like a merge or a fresh review. I'm also more likely to see it there.
Alex

@yankeexe, @tuananh or @nitishkumar71 could you raise a PR that adds the HelmOperator as per above, but using the new app format like cert-manager?

@alexellis I'll work on it

@alexellis I create the PR #254 to address this. Can you help review?


Option to Always Show Parent Directories in File Explorer

The VS Code file explorer is super convenient, but it's also super easy to get "lost" in it.  When you do, you potentially have to scroll back up past hundreds of files, just to access a parent folder (or even to figure out what parent folder you're in).
For example, if I open /home/me/project/thisFolder/thisFile.js, right now at the top of the explorer I might see:
MY PROJECT (WORKSPACE)
^ rootFolder
^ someFolder
^ someOtherFolder
^ thisFolder
js thisFile.js
The UI clearly tells me that thisFile.js is in workspaceFolder/rootFolder/thisFolder, and I can easily access parent folders (eg. to open someFolder or someOtherFolder).
But, what if someFolder is open, and filled with files? I might instead see:
MY PROJECT (WORKSPACE)
js fileA.js
js fileB.js
js fileC.js
js fileD.js
^ thisFolder
js thisFile.js
The open parent files obscure where I am, and make it difficult to access parent folders. When someFolder is a folder like node_modules, that can mean hundreds of folders, and a lot of scrolling!
However, you'll notice that in either case, one "parent folder" is always visible: I always know I'm in the workspace folder.
What if I could right-click on "MY PROJECT (WORKSPACE)", check a box called "Always show parent folder links", and then see:
MY PROJECT (WORKSPACE)
rootFolder
__someFolder
____someOtherFolder
js fileD.js
^ thisFolder
js thisFile.js
I'd always know where I am because of the omnipresent folder names.  Furthermore, those folder names could serve as bookmarks; if I accidentally opened node_modules and had ...
MY PROJECT (WORKSPACE)
rootFolder
__someFolder
____someOtherFolder
^ node_modules
lots of modules
^ thisFolder
js thisFile.js
I wouldn't have to scroll back through lots of modules!  I could just click on someOtherFolder, and VS Code would auto-scroll me to the base of that folder.

/duplicate of #161207

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


[Task]: Create Split Button for different sending flows

Task description

[ ] Create an option for sending L1 -> L2 that can be enabled/disabled with a feature-flag

[x] #4900

Send funds on L1

Send funds to L2

Send NFT (implement this later, not in this issue)

Once you set it, it stays constant as long as you don't switch accounts/log out.
Design can be found here: https://www.figma.com/file/rrTiOHqpjQ54UGhT38nKy0/Wallet-tab-[WIP]?node-id=3348%3A286842
Requirements
#4891
Creation checklist

[ ] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Close, since, we're moving towards a different approach for sending to L2.


Cursor in rename tab window

1.0.0-alpha.62
Double click on the tab opens rename window.
But cursor remains in parent window.
For Settings tab everything works fine.

The problem still exists in 1.0.0-alpha.63


Can't generate images base on images correct

Originally posted by @yangjie1874 in https://github.com/UTokyo-FieldPhenomics-Lab/DODA/issues/2#issuecomment-2209887718
Hello, as shown in the figure, in the image generated by generate_data_for_target_domain.py, the label position I want is very random and almost wrong. I want to know the reason

@yangjie1874 It seems that your controlnet has not converged, or the Control Strength is set too small.
This is the image I got with the pre-trained DODA. For controlnet, how many iterations did you train?

sorry, I using ldm,  I have no training controlnet,

just train ldm in the same way as #2

DODA uses label (layout images in paper) to control the image generation, and the control achieved through controlnet(cldm), so if you only use ldm, it won't use layout images to control the generation, and the label won't match the image.
Training cldm requires boxes annotation, if you don't have the annotation, you can directly use the pre-trained weight to generate data. OR mix your data with GWHD to train the ldm first, then use the annotation from GWHD to train the cldm. As show in Table 3 and Figure 5 of the paper, although there is no annotation from the target domain, this training method can still improve the quality of the generated target domain data.

Thank you very much for your patient answer. You mean I will now use the trained ldm as pre-trained weights to train cldm?

for your dataset, do you have annotation?

yes！

The ldm I trained is unlabeled, but when I use the weights of ldm to train cldm, an error occurs. what should i do ? /(ㄒoㄒ)/~~

Or maybe I didn't notice some problems when I was training ldm?


Y - axis intervals are not coming as expected when no data loads in the graph

Describe the bug
If there is no data loaded in the graph the y axis intervals start from 60 and end at 190 , even when the tick values are specified from 60 till 210. the lower limit is 90 and the upperlimit is 190
ticks: {
values: [60, 70, 80, 90, 100, 110, 120, 130, 140, 150, 160, 170, 180, 190, 200, 210],
}
To Reproduce
Steps to reproduce the behavior:
In the graph input json give the y as
y: {
label: 'y-axis',
lowerLimit: 90,
upperLimit: 190,
ticks: {
values: [60, 70, 80, 90, 100, 110, 120, 130, 140, 150, 160, 170, 180, 190, 200, 210],
},
},
Expected behavior
The y-axis ticks should start from 60 and go till 210.  as the lower, upper limit and the ticks provided.( division should be as per the ticks are given in the values array)
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.
#116

I think its a bug that the 60 should be 90 rather.

But other than that, I think its working as intended. The ticks -> values are supposed to be within the limits. The axis values are re-adjusted only when the content values are an outlier.

Closing this issue since its working as intended. Feel free to reopen if you feel otherwise.


Json file checking

Error checking for json file is not done

If error, preloaded data should be loaded


Add ALSO IoT Platform

Summary

Added ALSO IoT Platform.
Changes

Added ALSO IoT Platform webhook template.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Requested changes done.

hey @epiller I'm so sorry but I somehow managed to mess up this PR :') I replaced it with #88. While waiting for the approval to merge it, do you happen to have any documentation for this?

Opusteno 😂
Our main documentation is here: https://docs.allthingstalk.com and it applies to all of our instances (AllThingsTalk Maker, ALSO IoT Platform, others).

@nejraselimovic I still don't see ALSO IoT Platform on TheThingsNetwork webhooks. Do you have any idea when it will be available? Thanks!

@nejraselimovic I still don't see ALSO IoT Platform on TheThingsNetwork webhooks. Do you have any idea when it will be available? Thanks!

Hey Vanja, it should become available with the next TTS release. I see that the merge deadline for v3.28.0 is October 18, I guess it was postponed a bit because of the conference.


Discuss Navigation pills for mobile

Triggers
The pill would display categories
https://github.com/bitcashorg/masterbots/assets/391270/f127fd94-23c2-4ccb-8963-5888e90b2c6d

consolidating on #133


VS 2017 - Access stored font and color settings - Docs out of date?

Is this still valid when speaking about Visual Studio 2017? The referenced registry key does not exist - so no font/colour info is available there. It is available in C:\Users\user\AppData\Local\Microsoft\VisualStudio\15.0_f92f921eExp\Settings\Exp\CurrentSettings-2018-08-25.vssettings though. What's the correct way to do this nowadays?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed9bc03c-1d5b-e956-7868-645a9c18d923
Version Independent ID: 2b890743-a5fe-b6fb-7632-a5c2baec6f59
Content: Accessing Stored Font and Color Settings - Visual Studio
Content Source: docs/extensibility/accessing-stored-font-and-color-settings.md
Product: visual-studio-dev15
GitHub Login: @gregvanl
Microsoft Alias: gregvanl

Hello,
I'm going to share what I found for others following in my footsteps.
I recently had a problem with VS 2019 settings interfering with my VS 2017 settings. Specifically, my color settings are getting all tangled up between both VS 2017 and VS 2019.
Unfortunately, the CurrentSettings.vssettings file isn't the only place where settings are stored in Visual Studio. This is especially true for the newer versions of VS, like 2017 and 2019.
It is a pain trying to figure out the actual settings storage location for fonts and colors because Visual Studio aggressively caches everything everywhere. Also, don't forget, Visual Studio requires you to sign into your Visual Studio account which can also synchronize settings. This "remote config" adds an extra layer of complexity in determining where and what settings are being applied.
The effective settings storage location for fonts and colors that Visual Studio uses is located at the following location:
%userprofile%\appdata\local\Microsoft\VisualStudio\vshub\Settings
The folder is essentially a mix of XML and SQL lite database files. This is the effective location where fonts and colors are stored in Visual Studio. In fact, there's a dedicated process ServiceHub.SettingsHost.exe launched with devenv.exe that interacts with this folder.
Other suspected and cached (but less effective) locations for fonts and colors include the following locations:

%userprofile%\appdata\local\Microsoft\VisualStudio\16.0_2a8eeedb\ApplicationPrivateSettings.xml
%userprofile%\appdata\local\Microsoft\VisualStudio\16.0_2a8eeedb\privateregistry.bin
Visual Studio's Private Appliation Registry Hive loaded via RegLoadAppKey

(where 16.0_2a8eeedb is your VS version installed)
So, if you're looking for an xcopy, restore file, or "recover from backup", way of restoring your Visual Studio Fonts and Color settings the paths listed above are the files and folders you want to look at to restore your "fonts and colors" in Visual Studio.
Hope that helps.
-Brian
:walking_man: :walking_woman: Missing Persons - Walking in L.A.

Thanks for submitting your feedback and we apologize for the delayed response.  Due to current resourcing and substantial extensibility changes we are currently working on that will result in significant, structural doc changes, we are closing this lower priority issue.  We will return to this issue on a later date and address it based on it's relevance after those extensive extensibility updates are made. Feel free to comment here as necessary.


1.3.5 release was not completed

👋 looks like 1.3.5 release was not completed, any reason why? Thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/180234

the macOS GitHub runner did not complete and I had to finish the release manually. I took off the pre-release tag right now
does homebrew need anything else to unblock them?

yeah, that should be it, thanks!


[5.7] Expose matches, ranges and split

This is based on top off https://github.com/apple/swift-experimental-string-processing/pull/298

It looks like a lot of the commits in between are also included here. Or am I missing something?

@swift-ci please test


HADOOP-18684: Fix S3A filesystem such that the scheme matches the URI scheme

Description of PR
Certain codepaths use the FileContext API's to perform FS based operations such as yarn log aggregations. While trying to reuse the S3A connector for GCS based workloads the yarn log aggregation was not happening. Upon further investigation it was observed that FileContext API have hardcoded URI scheme checks that need to disabled/updated to make S3A compatible with non AWS stores.
How was this patch tested?
The patch was tested against us-west-2
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 44s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 18s

trunk passed

+1 :green_heart:
shadedclient
20m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
20m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 32s

hadoop-aws in the patch passed.

-1 :x:
asflicense
0m 37s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

94m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7a4703377f7b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 15a1551f1ee368e6fb0bca6e744cc22b34162449

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/1/testReport/

Max. process+thread count
692 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 44s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 20s

trunk passed

+1 :green_heart:
shadedclient
20m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
20m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 33s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

96m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 19c7c5611f35 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7a4848a19fcc83939d19177a93c868c1a729c748

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/2/testReport/

Max. process+thread count
556 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 25s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

trunk passed

+1 :green_heart:
shadedclient
24m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 18s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
24m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 32s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

106m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux add2e8f11b7e 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7a4848a19fcc83939d19177a93c868c1a729c748

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/3/testReport/

Max. process+thread count
529 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m  1s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 18s

trunk passed

+1 :green_heart:
shadedclient
20m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 10s

the patch passed

+1 :green_heart:
shadedclient
20m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 25s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

102m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9862111fd6ff 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bddca798790f88d98579ad40e041591e3bf97db

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/5/testReport/

Max. process+thread count
555 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 34s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 11s

the patch passed

+1 :green_heart:
shadedclient
20m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 34s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

102m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0adcfc773b96 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4bddca798790f88d98579ad40e041591e3bf97db

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/6/testReport/

Max. process+thread count
640 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 31s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
20m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m  4s

the patch passed

+1 :green_heart:
shadedclient
20m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 31s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

94m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 92eed210fd34 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bb196ce2040462073eb1b7154b9d154d5eea633a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/7/testReport/

Max. process+thread count
726 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 42s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
23m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 16s

the patch passed

+1 :green_heart:
shadedclient
21m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 34s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

101m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 17f608f8797f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 15aa0cac34ac1ddb4bfb7ef12715492e086fe254

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/8/testReport/

Max. process+thread count
751 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 24s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
20m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m  8s

the patch passed

+1 :green_heart:
shadedclient
20m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 33s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

104m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 76302f6843bc 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 40556941b501c46b4070557d80f750ee66aed17b

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/9/testReport/

Max. process+thread count
557 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5521/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


fix(Case Management): regen service to add Pager

PR summary
This commit contains a re-gen of the service to
leverage the new Pagers emitted by the SDK
generator.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.28.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How could I set width of column in grid?

We can use $grid->xxx() or
$gid->actions( function($actions) {
// blahblah
});
to set up a column in grid.
If I want to assign the fixed width to the column, what should I do?
Thank you.

Please try to read the link below. You can find the solution. GOOD LUCK:
@Extend the column

with extending column you can change only content of column (inside ), but what to change column width? I have similiar question...

what is wrong? (file App/Admin/Routes.php)
The last route is always executed (2 route in the example)
I want to show specific drivers for each function
someone can help me?
I use version 1.4

@qcol
Because AdminLTE has no css for grid. You have to define it by yourself.
Here is a simply sample:

Step1: add a $width property into Admin\Grid\Column.php and generate a getter\setter for it.

protected $width = '1em';

    /**
     * @return string
     */
    public function getWidth()
    {
        return $this -> width;
    }

    /**
     * @param string $width
     */
    public function setWidth($width)
    {
        $this -> width = $width;
        return $this;
    }

Step2: add a funtion into Admin\Grid.php for getting a use-width-feature flg

    public function renderColumnGroupOrNot()
    {
        return $this->option('useWidth');
    }

Step3: in your contorller

    protected function grid()
    {
        ...
        $grid -> option('useWidth', true);
        $grid -> id('id')->setWidth('10em') -> sortable();
        ...
    }

Step4: in your table.blade.php

           ↓↓↓ render colgroup start
            @if($grid->renderColumnGroupOrNot())
                @foreach($grid->columns() as $column)
                    <colgroup style="width: {{$column->getWidth()}}"></colgroup>
                @endforeach
            @endif
           ↑↑↑ render colgroup end

                @foreach($grid->columns() as $column)
                {{$column->getLabel()}}{!! $column->sorter() !!}
                @endforeach

            @foreach($grid->rows() as $row)

getHtmlAttributes() !!}>
                @foreach($grid->columnNames as $name)
                {!! $row->column($name) !!}
                @endforeach

            @endforeach

In lastest dev version:
$grid->created_at()->setAttributes(['width' => ' 300px']);

Hi @z-song ,
May I know which version support this function?
Could you give me version number?
Thank you

1.4.2这些方法setAttributes，style不在Column.php中。可如下解决：
$grid->user('用户')->name()->display(function ($val) {                     return '
' . $val . '
';                 });
生成的html略显丑陋。
还有个方法叫value。功能是一样的。


Add dayofweek Spark Function

dayofweek
dayofweek(date) - Returns the day of the week for date/timestamp (1 = Sunday, 2 = Monday, ..., 7 = Saturday).
Examples:

SELECT dayofweek('2009-07-30');
5

@pedroerp @jinchengchenghh I've resolved all the comments according to your guidance, could you please help to take a look? Thanks.

% looks good, if you can add the example for Timestamp in document.

% looks good, if you can add the example for Timestamp in document.

@jinchengchenghh Sure added a timestamp example from the test case to the doc.

LGTM

Others looks good


Add Wales Census Individual Schema in Welsh

What is the context of this PR?
This adds a translated version of the current wales census individual schema in welsh. This has been manually created for now until we determine a better build process for schemas generated from translations.
How to review
Check the schema appears to be correct. Check you're able to run the new schema when using the cy region code. Ensure that build process continues as normal with the new cy directory.

I can run the new schema when using the cy code, looks OK but I noticed the Guidance tab for the establishment-position page still appears in English.

establishment-position page

Yes. This is one of two missing messages at the moment - good spot though.


[folding] Auto re-fold a region after the cursor leaves it.

Feature Request: Option to automatically re-fold a region after the cursor leaves it.
Say if you're skipping through "Find Next" matches, it will unfold all the code it passes through. It's annoying to have to keep refolding stuff manually.

also to mention, the command Fold All Regions Except Selected doesn't have Fold All Selected Regions option;


Slack interface

This is a little spike into a Slack interface to Empire for https://github.com/remind101/empire/issues/686. Not ready to merge

The way I built it, there's now a cli package that provides a CLI to Empire (whether it's in process or out of process doesn't matter) and there's just a slash handler that serves the CLI to Slack.
Things still todo

[x] Wrap slack server with slash.ValidateToken
[ ] Authenticate slack users against github. (Currently just runs as the slack user).
[ ] Docs

This just came up internally, but we should probably have a way for people to disable certain commands.  Here, for example, we'd definitely not want to allow run over slack, since that goes against some of our security principles.  scale is questionably on that spectrum as well.

Added to the TODO section.

This probably won't get any love anytime soon, so gonna close for now.


terminal size and lines issues

I've been having trouble with lines not wrapping or cursor position going off by a line sometimes, especially when tab completing past a line length, or using the arrows keys to cross a line wrap, but sometimes even just pressing delete a bunch.  This seems to primarily happen when I am ssh'd to another system, so this may be related to a console size issue I noticed which is easier to state:
start a new terminal with bash
$ stty size
25 80
$ echo $LINES $COLUMNS
25 80
$ tput lines; tput cols
25
80
resize the terminal by dragging up, and these will still report 25x80
resize by dragging diagonally
now those values are updated
This causes at least some of the line issues with screen in an ssh session, with the terminal looking truncated.
My windows install: Version 10.0.14393 Build 14393

you can use another terminal, CMD, powershell, or ConEMU

@vwsc2015 , maybe I'm just completely misunderstanding your comment, as what you are suggesting doesn't make sense to me.
bash, cmd, and powershell are shells, not a terminal.  The job of a terminal in windows is probably handled by conhost.  A search seems to indicate ConEMU relies on conhost as well.
So launching powershell, then running the command bash, is not a different terminal.  I checked and the same issue I listed above happens in powershell -> bash.  This seems like a silly check, so I'm worried I've completely misunderstood your comment.  Can you please clarify?

@db0xcc There are tons of conhost bugs atm, and for the moment, I suggest running an X terminal emulator with vcXsrv.  If you roll over to my github page, I have a preconfigured copy of st with a default size hack in the int main  and some color and font patches applied (a pretty minimal fork, since configuration is done through config.h) that works pretty clean out of the box with really no problems so far (I previously suggested rxvt, but that requires a few more steps and hacks).
To build it and have it work right, you need the ubuntu packages
libx11-dev libxft-dev and fonts-powerline.
To get it running, all you need is to do is run vcXsrv, git clone the repo, enter it, make clean, make, sudo make install, and run it with
DISPLAY=:0 st
I put my config on github to share with this WSL forum.  Here's how it looks with oh-my-zsh:

My launch command is DISPLAY=:0 st -e /bin/zsh

@fpqc Thanks, this looks like a great work around while they are fixing up the windows terminal.

@db0xcc Oh btw you should use tmux in st for scrollback support. st does not keep its own scrollback buffer.

 Generally that fixes things for me on resize. My guess is SIGWINCHes are going missing.

It does seem that resizing the height outside an alternate buffer doesn't send the event.
However, I'm not totally sure this is fixable behavior. Right now the console only sends size change events when the buffer size changes, not when the window size does. This is legacy behavior back to... who knows when. So that can't just quickly be fixed unfortunately. We'll have some discussion about investigating this more

Thanks for reporting. As @zadjii-msft says - this may not be soemthing we can easily fix for a number of reasons. We have filed this issue, however, and will take a look at what we might be able to do here.
Note: If you don't pound on the Console and file issues, we'll have a harder time finding and prioritizing bugs. While it may be a little painful in the short term, we greatly appreciate your help finding these issues so that we can log & (eventually) fix them 😜

Changing from bug to feature, as this is actually feature level work and not a simple bug fix.
This is tracked internally as MSFT:8708175

Well, calling incorrect behavior "feature" instead of "bug" won't change anything. While I really appreciate Microsoft for bash on windows, this bug is something that ruins user experience.

@nick4fake Does this still even happen in 1703?

@nick4fake I'm not saying that the behavior is a feature. The "Feature" label is for fixes that require a feature level of work vs a bug level fix - it's a subtle distinction that doesn't really mean anything externally, but it helps us differentiate our work internally at Microsoft.
And actually, looking through the code, I think this got checked in a few weeks back, for a related issue. from the looks of it, it should be in the next Insiders build :)

Thank you for a really quick answer.
Yes, I have 1703. But after you mentioned that this should be already in prod I have checked PowerShell - and it looks like everything is ok. Probably ConEmu developers should update their application as well.

There is same issue with Intellij IDEA terminal. Why does it affect multiple terminals from different vendors?

Because almost all software with embedded console/terminal uses WinPTY as a backend, at least that's my guess.

Well, what I am talking about is that this issue does not look as "fixed", as it still affects various terminal emulators.

@nick4fake "fixinbound" means that the fix for this bug is coming to an upcoming Insider's build soon. I don't believe that it's already out yet, but I'm not sure. If, once the fix is out for conhost, other terminal emulators still don't work correctly, then I'd recommend opening issues on them for not supporting the fixed behavior correctly. As @fpqc mentioned, WinPTY is a good place to start for those issues.

@nick4fake the way that third party consoles work for Windows right now is kind of a huge ugly hack (the console team mentioned that they're working on creating some new plumbing to obviate these hacks).  Basically, the third-party consoles set up a periodic poll on a hidden console window that pauses the window, then reads off all the text on the screen, unpauses, and finally provides the dumped screen in a sort of pty-compatible format.  This hack underlies both WinPTY (used in VSCode and likely IntelliJ) as well as ConEMU/cmder.
Since all of the third-party consoles use the same hack that depends on reading off the screen of the Windows console directly, problems/bugs/unimplemented features in conhost itself will be directly mirrored in the third-party consoles.
I have to say though I am interested by one particular case that doesn't use any hack at all: The proprietary version of Visual Studio and also the powershell ISE both have integrated consoles without using third-party hacks like WinPTY or ConEMU, at least to my knowledge..

Ran into this issue too. I found an admittable hacky workaround, in case this helps others. I noticed that after using Vim, the screen size readjusts properly. So I mapped an alias
alias fix="vim -c ':q'"
in my bashrc. When you run fix from bash, it quickly opens and shuts vim, resetting the column width.

Thanks for the discussion.
Closing. If you have further asks/issues, please file new issues on our Console GitHub Repo.


(FOR REVIEW) (SERVER-303) Remove version-check service

Remove the dujour version-check service and replace it with the
dujour-version-check library.
I've flagged this as for review as I needed to add a new function, get-version-string, to the dujour-version-check library for this to work. That change is present in https://github.com/puppetlabs/dujour-version-check/pull/7. Once that is merged, we can do a new release of the dujour-version-check library and update this from a snapshot dependency.

:+1: with a question on an additional unit test, assuming the dujour-version-check dependency is moved off of a SNAPSHOT, and Travis tests subsequently pass.

@camlow325 I've moved the assertions into the test itself, and am now using the atom to store the values of the parameters passed to version-check-test-fn.

Philosophical ranting aside... +1

@cprice404 @camlow325 I've moved the atom and function into a let block in the version check test. I've also bumped the dependency on dujour-version-check so this should be ready to go now.

:+1: Looks like Travis failed.  Not sure if that's because it was down for maintenance?

kicked travis

@cprice404 @camlow325 I released dujour-version-check to clojars and moved the dependency out of the dev profile and into the main dependencies list. Hopefully travis will pass now.

Okay I think I've finally fixed the Travis failures, we'll see how this new commit does.

@cprice404 @camlow325 It looks like Travis is finally fixed. I've made one new commit, https://github.com/puppetlabs/puppet-server/commit/fe08e87856a748c2a4d7738eb7f236cd5a91a0b6, to fix an issue with the version-check-test.

@jeffmccune I presume that you wouldn't be aversely affected by us going ahead and merging this?

@nwolfe @KevinCorcoran I've addressed your feedback.
One further question: Do we want this to go into master for the 2.0 release? Or do we want this to go into 1.x/2.x, and thus target it at stable?

@nwolfe I've made the changes based on your feedback.

:+1: nice!


Incorrect information regarding Open ID Connect and automatic provisioning

We built our Azure AD integration using Open ID Connect and with automatic provisioning, as stated would work according to this document (see Prerequisites section). Later when we tried to publish our app we were denied because apparently automatic provisioning is NOT supported for Open ID Connect integrations. This should be pointed out very clearly in this documentation, we have now invested a lot of time in to something that is not accepted in the approval process.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 806e36a4-f5ae-bc07-e7e2-ea9d2ab98131
Version Independent ID: 3dea2974-8f2b-0e21-b7a2-b1381cf127b6
Content: List your application in the Azure Active Directory application gallery
Content Source: articles/active-directory/develop/howto-app-gallery-listing.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@mjoensson - I'm very sorry. We'll work to get this information updated. I've escalated this and have reached out to our PMs to help us get an updated list of what's supported so we can reflect that in our documentation.

Hello @mjoensson - Thank you for your patience. I checked with our PMs and confirmed that we don't support dynamic app registration per the OIDC spec. Our multi-tenant model enables you to register an app once and then we provision it for you across multiple tenants. We reviewed the referenced topic and confirmed that it doesn't suggest that we support OIDC provisioning, only user provisioning so there's no doc update needed.

Confirmed with PMs that existing content is correct and added additional info as part of this thread. No doc update needed.
#please-close


Tab completion

Hi,
I'm not sure if it should address OMZ or zsh itself. When I type "cd ..", I would expect to browse the upper directory, without typing a slash. Is this possibly configurable or patchable with OMZ?
Thanks

I believe this is normal zsh behavior. The same thing happens with OMZ turned off. I suspect that .. and .. are being handled specially, and not considered as candidates for completion when it's looking for a directory. (Probably to avoid ".." popping up where you usually wouldn't want it, e.g. as a completion candidate for a path element when you've already provided some leading path elements, or as a high-precedence exact match when you have more complicated completion options enabled, or in the presence of files which start with "..".)
You can look at the _cd function supplied with zsh to see exactly how it's doing the completion. (Though it can be pretty unreadable.) To find it, do for i in $fpath; do ls $i/_cd; done. The first one that's found is probably the one in effect for you.
I don't see an option to control it, so I think this is just normal zsh behavior.

Looks like a duplicate of #3775.

I found the solution: https://github.com/robbyrussell/oh-my-zsh/issues/3775#issuecomment-125536530
Please close the issue if it works

This works perfectly well, thanks!


[5.7] Create new model with configurable states

To resolve completely this issue https://github.com/laravel/framework/pull/26085. I think it's better to create a new model with configurable states that could be changed via getters (public set* methods) such as:

setTable()
setKeyName()
setKeyType()
setPerPage()
setConnection()
setIncrementing()

@mfn Thank you for your suggestions!

Because the previous commit was merged into branch "5.7", I target this pull request to the same branch.
setStateFrom method is a good idea. :) You may implement later if this pull request is merged.

Yeah I think we would need a more concise maybe. Also this doesn't seem to be being driven by a real need in an application its just driven by "I think it would be better". I don't typically like to manage PRs that way.


Add more docs to GRA, MRA and ReachingDefinitionsAnalysis

Add Scala docs to GRA, MRA and ReachingDefinitionsAnalysis.

It would make more sense to write docs for the most recent of these analyses in the yousif-VSA-uptodate branch as there is a lot here that is already out of date


Make CRUD API + pagination treatment consistent across resources (2)

https://github.com/cloudflare/cloudflare-go/pull/138

@elithrar Can you trigger the CI please ?

Travis failed as it seems to have detected 'abuse' (it doesn't say what triggered that determination).
However, there's a lot of changes in here, and the commit messages don't line up. Can you rebase these commits to provide clearer commit messages?

Ok I'll do that next week

@SublimeDamien Let me know when you're ready for me to re-review.

Hi @elithrar I was little busy.
I split the commit in multiple commits

@elithrar I have an error on the following command diff -u <(echo -n) <(gofmt -d .) but I don't understand the goal of this command and why there is a failure

@SublimeDamien Not 100%, but I think that's a check to make sure that code has been run through gofmt before check in? Might just need to run that first?

Correct, it’s gofmt.
On Wed, Nov 29, 2017 at 5:52 AM Michael Warkentin<EMAIL_ADDRESS>wrote:

@SublimeDamien https://github.com/sublimedamien Not 100%, but I think
that's a check to make sure that code has been run through gofmt before
check in? Might just need to run that first?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-go/pull/154#issuecomment-347866218,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABIcHZ1r60VpQ2PfMyELmTAN4PtmxWQks5s7WGmgaJpZM4Qc_0H
.

Thanks @SublimeDamien - going to review later today!

Ok, you're welcome.
I'm waiting your reviews

For the other reviewers, this PR should -

Allow a package user to paginate appropriately, depending on whether they find their results vs. network calls (and thus, time). Users with thousands of records would not want auto-pagination.
Make method signatures as consistent as possible (pointer vs. value return, pointer vs. value args, etc) - this may require some bikeshedding (proposal: value for arg to avoid mutation, pointer for response to minimize copying large responses around)
Return responses for all methods to allow the caller to retrieve IDs as necessary. The PageRules methods were the largest culprit here.

It will break the public API, and thus we'll bump the major version after merging.

@elithrar There is other things to change ?

No sorry! Busy week here. Will make an effort to review and hopefully
merge soon.
(It’s a large PR with multiple breaking changes and thus requires more
eyeballs)
On Thu, Dec 7, 2017 at 3:52 PM SublimeDamien<EMAIL_ADDRESS>wrote:

@elithrar https://github.com/elithrar There is other things to change ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-go/pull/154#issuecomment-350130685,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABIcIQ4XwwMIBF1GOhbzxoX4Ay0lIrbks5s-HopgaJpZM4Qc_0H
.

@cbranch I tried to clean up, say me if it's OK

@cbranch @elithrar Hi guys, what is missing for merge this PR ?

I've been reading through this and I'm not sure what the desired benefit is for returning response objects from Create methods. It seems simpler to pass just the object and error back, if that is possible. Is it the case that some resources don't have an ID and so passing the resource object back is insufficient to do lookups? (all the resource types I looked at so far do have IDs). I might be missing something else? @elithrar ?

@benjvi - I'm OK with your suggested approach here. The approach in #169 LGTM.

@elithrar @benjvi If I understand what you want, for an example
actually there is:
func (api *API) CreateCustomHostname(zoneID string, ch CustomHostname) (*CustomHostnameResponse, error) {
	uri := "/zones/" + zoneID + "/custom_hostnames"
	res, err := api.makeRequest("POST", uri, ch)
	if err != nil {
		return nil, errors.Wrap(err, errMakeRequestError)
	}

	var response CustomHostnameResponse
	err = json.Unmarshal(res, &response)
	if err != nil {
		return nil, errors.Wrap(err, errUnmarshalError)
	}

	return &response, nil
}

to
func (api *API) CreateCustomHostname(zoneID string, ch CustomHostname) (*CustomHostname, error) {
	uri := "/zones/" + zoneID + "/custom_hostnames"
	res, err := api.makeRequest("POST", uri, ch)
	if err != nil {
		return nil, errors.Wrap(err, errMakeRequestError)
	}

	var response CustomHostnameResponse
	err = json.Unmarshal(res, &response)
	if err != nil {
		return nil, errors.Wrap(err, errUnmarshalError)
	}

	return &response.Result, nil
}

@elithrar @benjvi If I understand what you want, for an example
actually there is:
func (api *API) CreateCustomHostname(zoneID string, ch CustomHostname) (*CustomHostnameResponse, error) {
	uri := "/zones/" + zoneID + "/custom_hostnames"
	res, err := api.makeRequest("POST", uri, ch)
	if err != nil {
		return nil, errors.Wrap(err, errMakeRequestError)
	}

	var response CustomHostnameResponse
	err = json.Unmarshal(res, &response)
	if err != nil {
		return nil, errors.Wrap(err, errUnmarshalError)
	}

	return &response, nil
}

to
func (api *API) CreateCustomHostname(zoneID string, ch CustomHostname) (*CustomHostname, error) {
	uri := "/zones/" + zoneID + "/custom_hostnames"
	res, err := api.makeRequest("POST", uri, ch)
	if err != nil {
		return nil, errors.Wrap(err, errMakeRequestError)
	}

	var response CustomHostnameResponse
	err = json.Unmarshal(res, &response)
	if err != nil {
		return nil, errors.Wrap(err, errUnmarshalError)
	}

	return &response.Result, nil
}

@SublimeDamien yes thats how I see it, passing just the pointer to the object and an error