Incorrect TWAI macros (IDFGH-5911)

Environment

Development Kit:
Kit version
Module or chip used:  ESP32S2
IDF version 4.2
Build System: MicroPython
Compiler version 8.4.0
Operating System:  Ubuntu (Linux)
(Windows only) environment type:
Using an IDE?: No
Power Supply:  USB

Problem Description
In the header file components\soc\include\hal\twai_types.h the following macros are defined.
#define TWAI_TIMING_CONFIG_1KBITS()     {.brp = 4000, .tseg_1 = 15, .tseg_2 = 8, .sjw = 3, .triple_sampling = false}
#define TWAI_TIMING_CONFIG_5KBITS()     {.brp = 800, .tseg_1 = 15, .tseg_2 = 8, .sjw = 3, .triple_sampling = false}
#define TWAI_TIMING_CONFIG_10KBITS()    {.brp = 400, .tseg_1 = 15, .tseg_2 = 8, .sjw = 3, .triple_sampling = false}

I believe there is an error in these macros and the tseg_2 field should be a 4 and not an 8. I wrote a script that calculates the brp, tseg1, tseg2 matches all of the rest of the macros in the header file except for these 3. The script returns a 4 for the tseg_2 field. All of the rest of the fields are correct...
If for some reason the 66.6% sample point must stay then the bitrates for TWAI_TIMING_CONFIG_5KBITS and TWAI_TIMING_CONFIG_10KBITS cannot be used as there is no match. I am gathering that an 80% sample point is fine as most other macros are set to an 80% sample point. And if that is the case then a change of the tseg_2 field for each of those would need to be a 4.
I do not have any kind of an example that shows they are incorrect other then the Python script that I wrote to calculate the needed parameters. I have attached the Python script so you can run it and also check if my calculations are correct if you like. I am pretty sure the tseg_2 is incorrect.
can_timing.py.txt

https://github.com/espressif/esp-idf/commit/d604bf05affcbd80e85afde17624bfdec8f0ff9d#diff-0e889d130b589e061b63dc49b8b37ab2df59e0287b8025c1343c7be707297460

Heyyyyy so I wasn't wrong.  It was caught earlier so this issue can be closed.
Maybe someone might consider porting the attached script to C code and adding it to esp-idf. It has the values needed to calculate timing registers for a bunch of different interface IC's and it can be added onto really easily.
It makes it a whole lot easier to be able to plug in the bit rate you want along with a tolerance and have it give the timing registers needed to get to that bit rate. I even went to the extent of automatically calculating what the SJW/RJW should be set to using the transceiver processing delay and the bus physical length. It also takes into consideration oscillator differences and how much of a difference that would be tolerated for the provided bit rate, bus length and transceiver delay.
I also added in CIA compliant sample points for those that do not want to deal with them.
It would be a useful tool to have and maybe add it as a separate module/library called twai_tools or some such thing.

@kdschlosser Auto bit timing calculation is in our future road map. So is hot-plugging bit rate detection. But it's planned for v5.0 because both features will require a change to the TWAI driver's API/programming model.

OK cool. I see there is a kind of add-on repository that has been made. Is that functional? is it public, meaning can I write something and have it added to it?
Bit rate detection is also good to have but isn't it slow?  I thought the only way to do it is the interface has to be set to listen only and then set the bit rate one at a time and check for errors. That is a time consuming process  and you have the issue of how busy the bus is. If it's only a couple of nodes and those nodes don't broadcast then the bit rate detection would fail.  If using an S2 there are 16384 prescalars and if 1/4 of those are unique bit rates you are talking 4096 different bit rates. If it was something that was built into the interface it's self that would be the better way to go about doing it.
I don't know how else an automatic bit rate feature could be done.
I am glad I was correct about those macros being wrong. It means my calculations are working correctly.  Out of question what is the tolerance of the oscillator on the ESP32's? knowing this would help to select a proper sample point and SJW.
Another really nice feature would be interrupts for when a message gets received and also an interrupt if there is no traffic on the bus at all. The interface on the ESP32 seems to be directed at the automotive market and the modules in the vehicle go to sleep when there is no more data being passed on the bus and it wakes when it sees data again. I am pretty sure the wake and sleep re probably pointing to specific frame id's for this. If I put the ESP32 into deep sleep does the interface also get powered down?.. I see there is a bus-off interrupt, can this be used to put the ESP32 into deep sleep and can it be used to wake the ESP32??
I know I am straying from the issue topic figured it is easier to ask those questions here then to try and get a correct answer from the forum.

@kdschlosser

Bit rate detection is also good to have but isn't it slow? I thought the only way to do it is the interface has to be set to listen only and then set the bit rate one at a time and check for errors.

Yes, it would be slow to scan every single bit rate. The more likely scenario would be to only scan the commonly used bit rates (e.g., 10K, 20K, 25K, 50K, 100K, ... up to 100M).

If it's only a couple of nodes and those nodes don't broadcast then the bit rate detection would fail.
Yes that would be true. But it's not uncommon for the network layer protocol (such as CanOpen) to have a Heartbeat/keep-alive message that is transmitted periodically.

I am glad I was correct about those macros being wrong. It means my calculations are working correctly. Out of question what is the tolerance of the oscillator on the ESP32's? knowing this would help to select a proper sample point and SJW.

The peripheral is run off the APB clock which usually operates at 80MHz. I'm not sure about the exact drift tolerance (more details in this thread),  but I think its drift be too small to affect the sample point selection. The propagation delay of your bus (i..e, the length) will probably have a much larger effect on sample point selection.

Another really nice feature would be interrupts for when a message gets received and also an interrupt if there is no traffic on the bus at all. The interface on the ESP32 seems to be directed at the automotive market and the modules in the vehicle go to sleep when there is no more data being passed on the bus and it wakes when it sees data again. I am pretty sure the wake and sleep re probably pointing to specific frame id's for this. If I put the ESP32 into deep sleep does the interface also get powered down?

It wouldn't be too use a timer that triggers an alert if no messages are received within a fixed period of time. For the ESP32S3, IIRC a bus idle interrupt was added so this should make things easier.
I don't think you can put it into light/deep sleep as that will shut down the peripheral. Adding a light/deep sleep wake up from the TWAI peripheral will require a hardware change. Can't use DFS either as DFS will affect the APB clock of the peripheral (thus affect the bit timing).

Note that we've also had similar request regarding TWAI power saving (such as https://github.com/espressif/esp-idf/issues/5883), so we are open to some form of power saving to TWAI in future hardware.

Adding an extra GPIO form the TWAI controller to automatically put the connected PHY to a lower power mode should be trivial
But having the TWAI wake up the chip from deep sleep will be a non-trivial change as the TWAI controller needs to have some form of operation in the RTC domain.
But if there's a significant user base that wants power saving, we are open to adding some form of TWAI power saving feature to HW/SW.


scientific notation problem

I'm getting some numbers in scientific notation
5512940468989 transforms into 5.51294E+12
related to https://github.com/SheetJS/sheetjs/issues/1833
Sheet2JSONOpts
raw: true gives this trouble

That looks like the text under the General number format.  Can you share the cell object corresponding to that cell? For example, if that's cell A3 in your worksheet, console.log(worksheet["A3"])

K3: { t: 'n', v:<PHONE_NUMBER>989, w: '5.51294E+12' },

This is intended and follows Excel's behavior:

var cell = { t: 'n', v:<PHONE_NUMBER>989, w: '5.51294E+12' };
var ws = { A1: cell, "!ref":"A1" };
XLSX.utils.sheet_to_json({A1:, "!ref":"A1"}, {header:1, raw: true})[0][0]

When raw: true is specified, the result is the original number<PHONE_NUMBER>989.
When raw: false is specified, the value is the formatted text 5.51294E+12, which is the entire point -- you're getting back the text that Excel uses.  And since the number format is not specified, it defaults to General.
If you'd like to change the format, wipe out the "w" field and use a different number format:
// this replicates "Number" with no decimal places
var cell = { t: 'n', v:<PHONE_NUMBER>989, z: '0' };
// this replicates "Number" with 2 decimal places
var cell = { t: 'n', v:<PHONE_NUMBER>989, z: '0.00' };
// this replicates "Number" with thousands separator
var cell = { t: 'n', v:<PHONE_NUMBER>989, z: '#,##0' };


Small typo in Example

Thanks a lot for the dictionary implementation!
Found a small typo in your example:
' (Works exactly like Scripting.Dictionary)
Dim Dict As New Dictionary
Dict.CompareMode = CompareMethods.TextCompare

...should probably be:
' (Works exactly like Scripting.Dictionary)
Dim Dict As New Dictionary
Dict.CompareMode = CompareMethod.TextCompare

(removed "s" in CompareMethod)

Thanks @joosthvanderlinden


Swift Compiler Error (Xcode): No such module 'CioInternalCommon'

Whenever I try to run the app on iOS, I get this issue:
`
Uncategorized (Xcode): Command CompileC failed with a nonzero exit code
Swift Compiler Error (Xcode): No such module 'CioInternalCommon'
/Users/ifeanyi/.pub-cache/hosted/pub.dartlang.org/customer_io-1.2.1/ios/Classes/SwiftCustomerIoPlugin.swift:3:7
`

Hi @ifeanyi-earnipay
Thank you for reaching out and apologies for the inconvenience. To fix this error, please update customerio-flutter library to latest version i.e. 1.2.1 and then run pod update --repo-update --project-directory=ios.
Let me know if this works for you.

Works great. Thanks

Still got the error on the lastest version 1.2.2:
Could not build the precompiled application for the device.
Swift Compiler Error (Xcode): No such module 'CioInternalCommon'
/Users/my_user/.pub-cache/hosted/pub.dev/customer_io-1.2.2/ios/Classes/SwiftCustomerIoPlugin.swift:3:7

Still got the error on the lastest version 1.2.2:
Could not build the precompiled application for the device.
Swift Compiler Error (Xcode): No such module 'CioInternalCommon'
/Users/my_user/.pub-cache/hosted/pub.dev/customer_io-1.2.2/ios/Classes/SwiftCustomerIoPlugin.swift:3:7

Closing due to inactivity. If you're still encountering problems, feel free to comment back on issue or send a support request to<EMAIL_ADDRESS>


Update current release only

Sorry, if I missed this feature, but from reading the docs, I couldn't find a simple update role.
What should I do if I want to  update the current release from version control? I don't want to go through usual release process, create a timestamp folder, etc. I need to update my current version if there are only minor changes required, like missing assets, typos, etc.
So, is there a way to do this with ansistrano?

IMHO if anything under version control has changed after a release, when you want to deploy these changes, you should deploy a new (minor) version. If any of these minor changes makes the system unusable, you will want to rollback the project.
Anyway I see two options here:

After releasing the new version, you can manually remove the previous one from the server.
Before releasing the new version, you can set the ansistrano_release_version var to the previous timestamp, so the new release will be deployed to the same directory, but BE CAREFUL as this is not the intended use case and it can break your project.

+1

I cannot see why a typo change should have a different deployment workflow than let's say a big release
Sorry @vitr but I am also :-1: in having such a feature

@ricardclau , sorry, I'm not asking why. If you guys don't see the reason behind it, I'm not going to convince you. It's just a common feature in other deployment tools, e.g. in rocketeer they have
update       Update the remote server without doing a new release
please, just close, if you're not interested in implementing it and thanks for the prompt answer.

@vitr No problem, if lots of people asked for it we might reconsider but at the moment we all agree that this is not something we feel is needed for Ansistrano.
Thanks anyway for reporting and we hope you still give it a try!


feat(docker): no longer download artifacts on devel image

Description
https://github.com/orgs/autowarefoundation/discussions/5007#discussioncomment-10086717

Considering these, I would propose to have an image without artifacts for development and CI purposes.
Version with artifacts can be something that derives from this light image.

Based on this opinion, this PR excludes the artifacts from the devel image. The artifacts still continues to be included in the runtime image.
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/10052443863
Effects on system behavior

Not applicable.
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I'm okay with removing the artifact from the image, but do you have any idea about how the users run ML based nodes with docker?

Users download the artifact every time they start up a new container
Users download the artifact on host and mount when they run the container

I prefer option 2, but in that case, I think we should be updating the instructions in Autoware Documentation as well to tell the user to download the artifacts and mount them with run.sh script if they wish to use perception nodes. https://autowarefoundation.github.io/autoware-documentation/main/installation/autoware/docker-installation/#runtime-setup

@mitsudome-r These reverted PRs need to revert again for the developers.
https://github.com/autowarefoundation/autoware/pull/4864
https://github.com/autowarefoundation/autoware-documentation/pull/571
Note that the runtime image still includes the artifacts.

This PR won't help CI because we are using autoware-universe image in CI, not devel.
And autoware-universe images didn't have the artifacts in the first place.
Also posted here:

https://github.com/autowarefoundation/autoware.universe/pull/7952#issuecomment-2245261637

Hmm, you mean we don't need this PR?

I think it's ok to keep this PR because developers will probably prefer keeping the artifacts outside the image.
But it won't help CI since we use another image for it.


python310Packages.azure-mgmt-reservations: 2.1.0 -> 2.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.azure-mgmt-reservations is: This is the Microsoft Azure Reservations Client Library
meta.homepage for python310Packages.azure-mgmt-reservations is: https://github.com/Azure/azure-sdk-for-python
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.0 with grep in /nix/store/0iwv49pj9y8cyp50xclk2hfdx999w37x-python3.10-azure-mgmt-reservations-2.2.0
found 2.2.0 in filename of file in /nix/store/0iwv49pj9y8cyp50xclk2hfdx999w37x-python3.10-azure-mgmt-reservations-2.2.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
azure-cli
python310Packages.azure-mgmt-reservations
python311Packages.azure-mgmt-reservations

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0iwv49pj9y8cyp50xclk2hfdx999w37x-python3.10-azure-mgmt-reservations-2.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.azure-mgmt-reservations https://github.com/r-ryantm/nixpkgs/archive/388f6fb60d8f330e45601ab51491eaa6416e49f3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0iwv49pj9y8cyp50xclk2hfdx999w37x-python3.10-azure-mgmt-reservations-2.2.0
ls -la /nix/store/0iwv49pj9y8cyp50xclk2hfdx999w37x-python3.10-azure-mgmt-reservations-2.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

azure-cli
python310Packages.azure-mgmt-reservations
python311Packages.azure-mgmt-reservations

Maintainer pings
cc @mwilsoncoding for testing.

@ofborg build azure-cli


Multi-node support?

Is the program supported across multiple nodes and GPUs? (Distributed Data Parallel) @michaelnny

Hi, as mentioned in the README.md file, the project only supports running on a single machine, although it supports multiple GPUs, but it's not the same as DDP.


Improve NetworkPolicy Side Panel View

What would you like to be added:
Change the display of the Ingress / Egress Rules to be clearer which ports relate to each rule
Why is this needed:
It's a bit confusing as the spec says to specify From/To before the port,  but the other way round is also allowed.
Environment you are Lens application on:

Kubernetes distribution: AKS, [Bare-Metal]
Desktop OS:  Windows 10

I think that the above is pretty clear. There is a header for Egress and a header for Ingress.


change README to reflect correct wake-word name flag

Just a quick edit of the README, this part tripped me up earlier and I noticed the flag was different in the code.

Thanks!


Weird CoreOS download with Vagrant install

I've been able to reproduce it on 2 environments
While the vagrant file points to 494.4 the actual loaded OS is 367.1.0 with Docker 1.0.1

@arnos
This usually happens if you directly run vagrant up without using panamax init, since the necessary env variables are loaded only if you run panamax init.
@cakkineniDev

@cakkineniDev Agreed that this is the env variables. but for Windows install method #1 we don't use panamax init

@arnos
Can you try doing a vagrant destroy and vagrant up. Also, we've released a new version of the installer pointing to latest CoreOS 522.6.0. (https://github.com/CenturyLinkLabs/panamax-ui/wiki/Release-Notes)

Closing due to inactivity.


A couple of bugs

1 - Audio files stepping on each other - not queueing up
2- Stop command not firing properly
3 - Some SFX's are missing (bennyhill, canttouchthis, plus maybe some more)
4 - !help isn't firing

Disregard 3 above. I removed them for DMCA


SyntaxError: Use of const in strict mode.

Running on node.js 12.6/Synology
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":">=4.0.0"} (current: {"node":"0.12.6","npm":"2.11.2"})
/usr/bin/ld382 -> /usr/lib/node_modules/ld382.js/bin/ld382.js
<EMAIL_ADDRESS>/usr/lib/node_modules/ld382.js
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>Diskstation2> ld382 -h
/volume1/@appstore/Node.js/usr/lib/node_modules/ld382.js/lib/cli.js:2
const program = require('commander');
^^^^^
SyntaxError: Use of const in strict mode.
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/volume1/@appstore/Node.js/usr/lib/node_modules/ld382.js/bin/ld382.js:2:1)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
I made sure all dependencies were installed first.  None of the searches seems to cover anything relating to this problem.
Diskstation2> npm ls
/root
--<EMAIL_ADDRESS> +--<EMAIL_ADDRESS> +--<EMAIL_ADDRESS> | --<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| --<EMAIL_ADDRESS> --<EMAIL_ADDRESS>

Hey Node 0.12 is pretty old and "const" is a ES6 feature.
Please try Node > 4.0.


slabs: fix crash in page mover

PR #524 speeds up the slab page mover for some situations: if an item
is expired, but not yet reaped (by a fetch, or LRU crawler), the slab
page mover unlinks the item, marks it as free, and doesn't mark the
loop as "Busy". If any items were marked as 'busy' (needing to be
freed, re-checked, or actively being used) the page mover will re-scan
all entries from the top.
With this change the re-scan becomes less likely.
The bug is in the check for chunked items. ch is only set if an
ITEM_CHUNK is detected. If ITEM_CHUNKED is instead detected we also
need to handle it with the full free routine. This was not done. This
frees the header item (CHUNKED), and then leaks all of the chunks
associated with it.
Getting into this situation is hard:

have an expired chunked item in memory that the LRU crawler hasn't
caught.
have the page mover find and move the page specifically with the
header item, not an individual chunk (these are in the small slab
classes).
later on pages with the leaked chunks get moved to other slab
classes. The slab mover thinks they're either free or that it needs to
unlink the orphaned chunks. This should then crash in the page mover
since the next/prev headers may no longer make sense. Or, worse, this
has to go on for a while since the may make sense.

This one liner fixes it.

Now fixes the other issue with the original PR


[@svelteui/core] add Blockquote component

Description
Added Blockquote component.

Before submitting the PR, please make sure you do the following

[x] Read the Contributing guide
[x] Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
[x] Include a description of the changes made in the PR description and in the commit messages.
[x] Include screenshots/videos of the changes made.
[x] Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

Thank you!! :raised_hands:


Set State call On Suggestion Tap

I am trying to call a setState function On Suggestion Tap, but it prevents suggestion overly closing. Any suggestion to get it done? TIA

Hello @ilmirfan, Could you please share a minimal and complete code sample for your usecase?

Hi @maheshmnj Thanks for the reply. Something like this
onSuggestionTap: (value) {
setState(() {
doSomthing();
});
},
I am trying to refresh a listview based on the selected suggestion from SearchField. Without  setState cases it works perfectly. But when I use setState (It's kinda must) inside onSuggestionTap or through a function, the overly suggestion isn't closing. Not sure it's a bug, but if you could suggest me some solution would be great. TIA

@ilmirfan ensure that you using the latest version of the package searchfield: ^0.7.5. And if I understand it correctly tapping the Does the issue reproduce with this example app? it has the similar code sample you are talking about
https://github.com/maheshmnj/searchfield/blob/fb7f9c91afb554e27c4270f2a3d839de5b14f94e/example/lib/country_search.dart#L80-L84
if the issue does not reproduce with the example app, can you modify and share the reproducible code?

Sorry for late. Ye example app works. Should be wrong something in my code. I will inspect and update you. Thanks so much.


redo manager should only clean files of one specified changefeed instead of all changefeeds

Before asking a question, make sure you have

[X] Searched existing Stack Overflow questions
[X] Googled your question
[X] Searched open and closed GitHub issues
[X] Read the documentation

What is your question?
I guess there is a bug about cleaning redo-log files when removing a changefeed:

when removing a changefeed, managerImpl.Cleanup will be called;
then LogWriter.DeleteAllLogs will be called, and all files in the redo-log directory and S3 path will be deleted;
so if several changefeeds share one redo-log directory or S3 bucket, their redo files will be deleted incorrectly.

The bug should effect all versions.

/type bug

/label effects-6.1
/severity majority
/remove-label question

/label affects-6.1
/severity majority
/remove-label question

/severity major
/remove-label question

/remove-label may-affects-4.0
/remove-label may-affects-5.0
/remove-label may-affects-5.1
/remove-label may-affects-5.2
/remove-label may-affects-5.3
/remove-label may-affects-5.4
/remove-label may-affects-6.0
/remove-label may-affects-6.2

/area ticdc

/assign @asddongmen


update template version

After merging, I'll follow these steps:
https://greene-lab.gitbook.io/lab-website-template-docs/advanced/update-your-template#from-pre-release

You can make comments that relate to the template itself and i will respond and consolidate them into an upstream issue if needed.

@d33bs Mermaid and MathJax are now built into the template with Jekyll Spaceship. You may want to convert your blog posts to this simpler syntax (and remove the importing of the js libraries) in this PR.


Guide explaining how to keep compatibility with mkdocs

Guide to help users that weren't pinning a version of mkdocs but were relying on mkdocs==0.15. Since we upgrade our default version installed, they will find that their docs are not building anymore.
This guide helps them to keep building their docs on Read the Docs showing the workarounds needed.
I'm not really happy with the document and how it's written but I think it communicates what we need.
Related to #4041 and #4556

@stsewd thanks! I took your comments.

@davidfischer please, when you have some time, take a look at this PR since you were helping me to understand the underlying problem and find the solution.

Good points!

We should probably strongly recommend that people pin versions of mkdocs. The same problem may arise when we upgrade from 0.17 -> 1.x.

What do you think about adding a warning note in docs/builds.rst::How to build documentation::MkDocs like this:
.. warning::

   We strongly recommend to :ref:`pin the MkDocs version <guides/specifying-dependencies:Specifying Dependencies>`
   used for your project to build the docs to avoid potential future incompatibilities.

This way, if the user select MkDocs for his docs we are warning and pointing him to the right section about how to specify a dependency (which in the near future will be able from the YAML without needing a requirements.txt file).
On the other hand, supposing that we would have had this note in that place, the error would have happened again since in this particular case we need to pin other packages also :/. This note, will be helpful under "some" circuntances only.

This guide has time-sensitive information. In a year, this guide will probably not be needed and in 2 years it definitely won't be. What's the plan for deprecating and removing it?

I don't really have a plan :(
It's hard to remove the time-sensitive information since the user does know anything about the MkDocs version installed right now (because it's done automatically by RTD). So, talking about "Migrating from 0.15 version to X.X" or similar doesn't make too much sense to me. They don't really know that they strictly depend on 0.15.
I was thinking on this guide like a temporal solution to point users if they open issues around this and/or to communicate via email to our .com customers.
This guide could probably completely removed some months after we notify our users/customers I'd say since it will become useless.

We should crosslink to the docs for specifying requirements

I added a new commit for this.

What do you think about adding a warning note

Sounds good to me.


Filter Event Message Update

Do not add all event message updates, only if current narrow would show them.

message_matches_search_term in static/js/filter.js may be useful for this.  Arguably you may want to borrow much of that whole module.


WFLY-17242 Add a CONTRIBUTING.md

Issue: https://issues.redhat.com/browse/WFLY-17242

@bstansberry I have added the CONTRIBUTING.md, Please take a look and let me know if it needs some modifications.

Thanks, @bstansberry for the review comments. I have changed it accordingly.

Thanks @RanabirChakraborty!


BTunnels - Potential RMM Misuse - Addtion

Adding BTunnels, taken from the contribution made via the below Sigma.
https://github.com/SigmaHQ/sigma/blob/1f1f31e99c3c1dd2ac21f471ca7ec67a923c3e87/rules/windows/network_connection/net_connection_win_domain_btunnels.yml#L4

Hey @deFr0ggy thanks for opening this PR.
Unfortunately btunnels isn't an RMM so this PR can't be accepted. In addition to that, copying Sigma rules from SigmaHQ is not something we do.
Just FYI, the detectios here are generated automatically from the YAMLs.
In case of a detection contribution contribute it to SigmaHQ and then link to it via a YAML.


Update progress bar

Hi, I'm using f7-progressbar but the prop :progress='count' doesn't update when count changes.
How can I update the progress bar dinamically?
Thank you

I just checked and it works. Be sure to define count in data. So something like:
data () {
    return {
      count: 0
    }
  },

Then just use it in your code like this.count += 10

@rvanzon 👍


Homu merges to master rather than the branch a PR is open against

This may be out of scope for Homu in general, but it seems like Homu tries to merge approved commits to master, even if the PR was opened against a different branch that isn't master. Am I doing it wrong? Is it just impossible to use Homu on PRs against non-master branches?

Oops, you're right. Homu itself has a configuration option to change the base branch, but http://homu.io/ currently doesn't support such a thing. And also, the configured base branch is applied to all the PRs, regardless of individual branch each PR is targeted for.
I'll tackle this problem soon.

Thanks for reporting!

Whoa, so fast! Thanks! Any idea when I'll be able to use this change with homu.io?

I restarted the server a while ago, so it should have been already applied, I believe.


[sample_decode] Fix rendering issue

Legacy tools have significantly changed since this PR was submitted.  Feel free to resubmit if still an issue.


feat: add lang & timezone support

This commit adds language support by adding lang & timezone to the blog() function.
The default option is English and en-US.

LGTM!!


Can't see reference I gave about my guests

Subject: Can't see reference I gave about my guests
Description:
I wrote a reference yesterday about my guests.
Today they wrote a reference for me.
Results:
The reference my guests wrote about me is visible. But the reference I wrote for my guests is not visible.
The reference I wrote for my guests should be visible.
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:104.0) Gecko/20100101 Firefox/104.0
Page: https://couchers.org/user/maracuja/references
User: peter (528)

They're there now


feat: Move to IAM Policy vs Inline Policy for logs:CreateLogGroup

Description
Move to IAM Policy vs Inline Policy for logs:CreateLogGroup
Fixes https://github.com/terraform-aws-modules/terraform-aws-eks/issues/2439
Motivation and Context
Running AWS Config, a finding that comes up is with the dynamic inline policy logs:CreateLogGroup. Ideally, we would move towards a IAM policy rather than inline policy here so we can remediate this AWS Config finding.
Breaking Changes
No Breaking Changes
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

Thank you but we are not planning to make this change at this time


refac(invoke-preprocessing.ps1): make code shorter and cleaner

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Documentation update
[x] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description

Refactor: tools/Invoke-Preprocessing.ps1
Simplify code and make it shorter
Testing

Test by running compile before and after along with custom Write-Output to ensure that files being processed are the same and that there is no behaviour change
Impact

Issue related to PR

Resolves #

Additional Information

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

CLOSED IN FAVOR OF https://github.com/ChrisTitusTech/winutil/pull/2813
Thanks for the review and advice. I wasn't aware of the other PR. I agree with your recommendation. I shall make suggestions to the aforementioned PR if need be.


fix(fstrim): executing in wrong namespace

longhorn-7768
Which issue(s) this PR fixes:

Issue longhorn/longhorn#7768
What this PR does / why we need it:
RWX volume is executing fstrim in the wrong namespace.
Special notes for your reviewer:
None
Additional documentation or context
None

@mergify backport v1.6.x

@mergify backport v1.5.x


Feature: Add MSTeams and Telegram channels to CLI

I hereby confirm that I followed the code guidelines found at engineering guidelines
^ (access is denied to me)
Affected Components

[x] CLI
[ ] Create CLI
[ ] Test
[ ] Docs
[ ] Examples
[ ] Other

Notes for the Reviewer
Completely unfamiliar with the code base, so consider this my modest attempt at a contribution. It does not look like the Checkly API has native support for Teams/Telegram endpoints, so I went through the Webhook endpoint with templates identical to what the webpage offers.
Open to all feedback and will fix whatever is wrong.

Resolves #995

New Dependency Submission
N/A

Hi @RedOctober117, thanks a lot for the contribution! I've been super busy lately but intend to review this soon.

@sorccu No worries, I look forward to it!


Closed drawer bug on window resizing

<Drawer anchor="right" type="persistent" open={false} >          <div>               Please mask me             </div> </Drawer>
This closed drawer do not stay out of viewport when window resizing. You must reopen and reclose drawer for fix.
In my opinion the problem come from inline-style translate3d rule.
transform: translate3d(calc(100vw - 1319px ), 0px, 0px)

Material-UI: 1.0.0-beta.7
React: 15.6.1
Browser: Chrome

Could you provide a reproduction test case? That would help a lot 👷 .
It could be a code sample or a live example. You can use codesandbox.io or www.webpackbin.com Thanks!


Add support for VM and VMSS

To support AzureMachine and AzureMachinePool in CAPZ, we will need to be able to reconcile the required Azure types.
Virtual Machine, Virtual Machine Scale Sets

closed via #115


routing: disable route cache for non-default requests

The PR attempts to fix the following problem reported by a user:

Hi, I'm trying the new queryroutes command and I'm using it via grpc (python). I'm seeing weird time-dependent behavior. Specifically I'm trying to get routes from queryroutes, try the route and after failure putting the failed channel on the blacklist. However, if I request then another path applying the channel blacklist, I'm getting back the same route as before. With the same code, only by putting a sleep statement,  sometimes I get a different path (but not always), where the blacklisted channel was excluded. Is there some sort of caching active? Thank you!

This fix doesn't address the changing bandwidth hints which may still cause routes to be returned of which we could already know that they'd fail.

I think it is better to remove the route cache alltogether: #2950


Use fingerprint32 over hash32.

fingerprint is platform independent: https://github.com/lovell/farmhash#fingerprint.
Looks like TChannel ran into the same issue: https://github.com/uber/tchannel-node/commit/44a7edbb1facc9f53b29633820a4d7afbb03dc2d
/cc @uber/ringpop

:+1:

As discussed during the standup, this is a breaking change which we will wait to merge until there are other breaking changes to the protocol.
We have no reason to believe that the Hash32 is giving inconsistent results in different installations of node.

@thanodnl This'll be a breaking change, but I'd like to get out ahead of merging this in. How about doing something like the below?
Add in an isCrossPlatform option to the HashRing ctor...
new HashRing({
  isCrossPlatform: true
});

then...
function HashRing(opts) {
  this.isCrossPlatform = opts.isCrossPlatform;
  this.hashFunc = this.isCrossPlatform === true ? farmhash.fingerprint32 : farmhash.hash32;

oh, now I see it's not just the HashRing. We could do:
new Ringpop({
  isCrossPlatform: true
})

and in config.js:
seedOrDefault('isCrossPlatform', false);

and then introduce lib/hash_func.js:
module.exports = function createHashFunc(ringpop) {
  if (ringpop.config.get('isCrossPlatform')) {
    return farmhash.fingerprint32;
  } else {
    return farmhash.hash32;
  }
};

and then in HashRing and Membership:
var hashFunc = createHashFunc(ringpop);
hashFunc(...)

does that make sense?

That makes total sense!
Then it will be merged as a non-breaking change, and when we have a breaking change coming up we can change the default behavior of ringpop so it uses
seedOrDefault('isCrossPlatform', true);

Will start integrating these changes in there.

looks awesome @thanodnl! Merging...


[Editor] "project_settings_override" is merged into "project.godot" when editor opens

Godot version
v4.0.2.stable.official [7a0977ce2]
System information
Windows 10
Issue description
The settings found in application/config/project_settings_override end up being written to the res://project.godot every time the editor is started.
I find this inconvenient, res://project.godot is always on the changelist in git because of this.
I think it would be better if settings with the same value as found in application/config/project_settings_override were persisted in res://project.godot only when set by the "editor interface" or "by code" and not by the "merge" that happens at the start of the editor.
Steps to reproduce

Before opening the MRP in the editor, note window/size/mode value within res://project.godot;
Now open it in the editor and check the res://project.godot, notice that window/size/mode was changed by the contents of res://project_override.cfg (which is the application/config/project_settings_override file).

Minimal reproduction project
Projects Override Merging Into Project Godot.zip

This has been the way it's worked since implemented back in 2018, I believe it to be by design

On second thought this might be related to #30912 but for this override


Remove readme symlink

Depends on #533
It's a real pain that I can't chain PRs if I work on my fork.

📚 Documentation preview 📚: https://earthaccess--534.org.readthedocs.build/en/534/

Tried setting ready for review to trigger RTD build... I thought it would build for draft PRs. :shrug:

Closing and re-opening as a non-fork PR.


@Inject causing failure during Spring Auto Scan

@Processor
@Inject
public void requestCollection(MuleEvent muleEvent, String resource, @Optional @Default("1000") long timeout, @Optional String returnClass,
@Optional Boolean throwExceptionOnTimeout, @Optional @Default("-1") int count) throws MuleException
{
The @Inject annotation needs to be removed and follow the same annotation pattern of the request I believe (unless there is a reason the @Inject is needed here) We enable the spring autoscan in some of our spring components, this causes the spring runtime try to find any spring beans that match this method signature so this causes the application to fail with an unable to find MuleEvent Spring Bean.

This was fixed in the latest release.
Thanks.


Suggestion for abstracting copy_logs_when_finished

Minor suggestion for abstracting the copy log functionality. Feel free to close if not desired.

Hey @ch-kr, are you happy for me to close my open PRs on this repo? They're fairly out of date I think haha.

thanks for following up -- sounds great, thank you!


ISBD Antenna Cable

In need of a TNC-M plug to SMA-M plug coaxial cable (RG-400U) to connect the ISBD Modem to the ISBD Antenna

Excellent, thank you Jordan

3 Cables for you bro

Those are perfect!

132195-713180.pdf

122372-710788.pdf


User Story 33- As a market researcher the population of people, people living in cities, and people not living in cities in each region for future advertising opportunities

tasks to complete
Connect to the existing database.
Add function to retrieve data on population
Add function to retrieve data on cities
Generate report

SELECT name as
city, population
FROM city; -- retrieves city name and population


pipx not finding python interpreter

I have a README.md with the following:
# Dependencies

| Project             | Version |
|---------------------|---------|
| python.org          | ~3.10   |
| pypa.github.io/pipx | =1.1.0  |
EOF

The resulting python version is as expected:
$ python --version
Python 3.10.8

Running pipx in this dev env fails:
$ pipx
/Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/pipx: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/libexec/pipx: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/python: bad interpreter: No such file or directory
/Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/pipx: line 15: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/libexec/pipx: Undefined error: 0

The python interpreter referenced above is a link:
$ ls -l ~/.tea/pypa.github.io/pipx/v1.1.0/bin/python
lrwxr-xr-x@ 1 robert  staff  43 26 Feb 17:21 /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/python -> /Users/robert/.tea/python.org/v3/bin/python

But the python dependency is only found here:
/Users/robert/.tea/python.org/v3.10.8/

Possibly this is because pipx is packaged with a dependency on python 3:
dependencies:
  python.org: 3
  pip.pypa.io: '*'

Note that changing the python dependency in the README.md to match:
| python.org          | ~3   |

does not rectify the situation as it results in python being found in:
/Users/robert/.tea/python.org/v3.11.1

Do you not have a symlink at /Users/robert/.tea/python.org/v3?
If so then that's curious, and a bug. The solution would be to rm -rf python and have tea re-extract and link it (tea python would do)

Do you not have a symlink at /Users/robert/.tea/python.org/v3?

No.

If so then that's curious, and a bug. The solution would be to rm -rf python and have tea re-extract and link it (tea python would do)

Interesting.
After the rm rf python and re-running tea --env && cd . it did create additional symlinks:
v*      v3      v3.10   v3.10.8

Not sure how it got into that state, but I'll see if I can repro.

Do you not have a symlink at /Users/robert/.tea/python.org/v3?

No.

If so then that's curious, and a bug. The solution would be to rm -rf python and have tea re-extract and link it (tea python would do)

Interesting.
After the rm rf python and re-running tea --env && cd . it did create additional symlinks:
v*      v3      v3.10   v3.10.8

Not sure how it got into that state, but I'll see if I can repro.

After some trial and error I can repro and it reflects what I recall happening at the time.
I required a 3.10x python and added it to the README.md, then I triggered the environment as shown below.
As it started to extract, I noticed tea hadn't picked up the change and was extracting the 3.11.1 version so I Ctrl-C'd.
That left a single v3.11.1 symlink in the .tea/python.org directory (no *, v3, v3.11).
Running pipx again appeared to complete the setup, but tea did not detect that not all the required symlinks existed in .tea/python.org so pipx failed.
$ pipx
python.org=3.11.1 extracting
^C

$  ls ~/.tea/python.org
v3.11.1

$ pipx
installed: ~/.tea/pip.pypa.io/v23.0.1
installed: ~/.tea/pypa.github.io/pipx/v1.1.0
/Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/pipx: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/libexec/pipx: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/python: bad interpreter: No such file or directory
/Users/robert/.tea/pypa.github.io/pipx/v1.1.0/bin/pipx: line 15: /Users/robert/.tea/pypa.github.io/pipx/v1.1.0/libexec/pipx: Undefined error: 0

Perhaps tea could catch the SIGINT signal and clean up before exiting?

As it started to extract, I noticed tea hadn't picked up the change and was extracting the 3.11.1 version so I Ctrl-C'd.
That left a single v3.11.1 symlink in the .tea/python.org directory (no *, v3, v3.11).

aah ok. Yes, not cleaning up is a bug.


Publish v0.26.0 Github release

https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.26.0


[Question / Bug]: Cancelling GPG passphrase freezes page

Hey,
I'm not sure if this is a bug, or unavoidable behavior by GPG, but it definitely has something to do with Obsidian.
A few days ago I created a note, test.md. I had opted in the settings for a note to be .gpg instead of .md, so test.md became test.gpg.
I let that note sit for a few days and decided to mess around with this plugin today, and just for testing purposes, I wanted to see what would happen if I clicked on the note to open it, but then cancelled the GPG prompt to enter my passphrase.
Once I clicked cancel, Obsidian will not allow me to click on any other note at all. All it does is just bring up a Obsidian notification which is the typical GPG error about cancelling the operation.
It will let me re-click on the note I originally tried to open and it prompts me for my passphrase again, but clicking cancel starts to loop all over. I can't click on any other note to open it until I actually click on that note and enter the passphrase.
Keeping in mind that the note I clicked cancel on is the only note in the vault encrypted. The rest are not and are just standard .md files.
I can however, open a new tab and start navigating around again, but I'd have to close the original tab because it's now useless unless I actually enter that passphrase.
Once I enter the passphrase for that file, all the pages work as normal.

Hi @Aetherinox
thanks for creating the issue. I have not observed this behavior so far. May I ask what other plugins you are using and which Obsidian version?

I'll have to run some tests today and see if plugins matter.
I just created a new vault, installed the same theme, all the same plugins.
Encrypted a file, and make sure it was labeled "file.gpg" instead of .md. And it gives me the "cancelled operation" and then lets me continue fine.
But it still breaks on my original vault if I cancel.
The only thing extra I notice is when I am on a normal file, the tab has the filename as it should. When I click on the encrypted note to open it and then click cancel, the tab's name changes to "Code Editor". And then that tab is stuck from that point forward unless I actually decrypt the note.
Yet the other vault is fine. Makes no sense.

I found the issue. I'm not sure if you can fix this, or if you need to place a warning somewhere in the documentation. The issue has to do with the plugin https://github.com/lukasbach/obsidian-code-files
If you install Code Files, there's a setting in there to add additional files you can open as code files

I had GPG added to that list because I was opening GPG files. And that conflicts with GPG Crypt.
So what's happening is it's attempting to have your plugin utilize GPG and decrypt the .gpg file, however, the Code Files plugin is trying to open the file as a GPG Code File, so the tab isn't loading and it freezes.
There's two behaviors:
Option 1 (To replicate the freeze)

Install Code FIles Plugin first (with gpgcrypt not installed).
Open Code Files settings and add .gpg to the list of File Extensions
Install gpgCrypt
Open gpgCrypt Settings and set the plugin to use the .gpg extension instead of .gpg
Make an edit to the target file, then right-click and encrypt the file/ make sure converts into a .gpg file instead of it being .md.
Clear your gpg password cache using gpgconf --reload gpg-agent
Click the encrypted file like you're going to open it
Cancel GPG passphrase dialog prompt

The tab will not become stuck

Option 2 (Causes Code Files plugin to error out

Install gpgCrypt first
Open gpgCrypt Settings and set the plugin to use the .gpg extension instead of .gpg
Make an edit to the target file, then right-click and encrypt the file/ make sure converts into a .gpg file instead of it being .md.
Install Code Files Plugin
Open Code Files settings and add .gpg to the list of File Extensions
Relaunch Obsidian Vault, or disable Code Files Plugin and then re-enable Code Files Plugin and you'll get the following error:

So pretty much it's a conflict between The Code Files Plugin, and it trying to open it as a Code File, and then gpgCrypt trying to open it as a regular file.
Obviously I doubt there's anything you can do, because adding GPG to the Code Files list makes no sense when you're using GPG as the extension for actually viewing encrypted notes. But it may help if someone else reports the issue, or if you need to post some type of warning somewhere.

Sure thing. It's a very niche issue that has to have a series of things done in order for it to happen, but I figure somewhere out there, someone will have it happen at some point.
The only reason I caught it is I noticed when i finally did decrypt the note and open it in Obsidian, it showed the line numbers, and I thought that was weird. Then I looked at the plugin settings and sure enough, gpg was in Code Files settings.

Closing this since you've got all the info you need.


Is this still in active development?

I am planning to use dockertest to code my test base for my new golang microservices.
This is a great tool for that.
Besides, are you planning to put kafka into dockertest?

Yes, dockertest is used in almost all of our projects and actively maintained. Version 3.0.0 however might still need some time.
Kafka is not on my list but feel free to contribute, as so many have before! :)

I will close this issue, if you feel the need, create a new issue for Kafka - or an PR :)

Excellent, I will, I will :)


Upgrade oidc-signin-tool

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


vendor, io: fix missing i_domain and o_domain arguments when specializing

Platforms implement the get_io_buffer method to provide vendor-specific implementations of io.Buffer, io.FFBuffer and io.DDRBuffer. Currently several platforms use isinstance to match the type of buffer, then construct a child class of the relevant buffer and return this object. Unfortunately these platforms miss the optional i_domain and o_domain arguments when calling the constructor, thus placing the vendor-specific specialisations in the default sync domain even if an different domain is specified in user code. This is the bug.
Only io.FFBuffer and io.DDRBuffer are affected as these are currently the only buffers with optional arguments in the constructor signature.
This could be fixed by modifying each vendor implementation to pass the optional arguments as required. That might look like this:
DDRBufferSpecialised(buffer.direction, buffer.port, i_domain=getattr(buffer, '_i_domain', None), o_domain=getattr(buffer, '_o_domain', None))

However this pushes more complexity into the vendor implementation and requires maintenance across an ever increasing number of vendor files.
This PR implements a factory method called create_from on the base class. This method is used in the vendor implementations to correctly create the specialised classes.
This is a fix for the new lib.io components, so mentioning the tracking issue here #1210

Arguably this method should also be implemented on Buffer for consistency. Very happy to add that after review.

I've taken a quick look at your PR. Offhand, there are two concerns:

It adds a new public API, which isn't something we do without at least some upfront design.
It raises questions about the design of the existing API as well.

I think this PR should probably be a blocker for the 0.5 release, but other than that we'll need more discussion of the direction first. I'll only be able to get around to that after handling some of the other release blockers first.

Indeed this was a sharp edge on the existing API (as viewed from the vendor implementation) that I have sanded down with this PR, but it may be that a different solution avoids this completely. I can also write this up as an issue (without the solution) if that is easier for the triage process?

The PR is fine.

Awesome that this is fixed now 🎉


User:Group: set persistent/data path permissions/user/group based on the given values

thanks @pwielders for the comments, will check and update

@HaseenaSainul do we still need the exposure of this config object, since we now moved the LinkLibraryPath/SystemRootPath. If nolonger needed, I prefer to keep it hiddden so it can not be abused.


/usr/local/bin/borgmatic calls itself recursively on Fedora

Problem
/usr/local/bin/borgmatic calls itself recursively on Fedora systems
Explanation
This commit has introduced a bug on Fedora systems (and possibly Fedora derivatives like CentOs)
https://github.com/borgbase/ansible-role-borgbackup/commit/b99de011fc040afe3f6c8045f155168f7402707b
For Fedora systems borg_python_packages is not defined, so the pip install never happens.
This results in the first borgmatic in PATH being /usr/local/bin/borgmatic, so when the script calls borgmatic it calls itself.
It seems that Fedora was forgotten when the switch from distro packages to pip occurred, as on Fedora the distro package is still installed.
Proposed Solutions
One solution is to simply define the proper borg_python_packages so that the pip install occurs.
However I want to push back against the "always install from pip" behavior.
Some of use prefer using distro packages when available. I'll create a PR that defaults to pip packages to maintain backward compat with current installs, but allows for using distro packages via a flag.

I see that a PR for fixing the bug directly already exists:
https://github.com/borgbase/ansible-role-borgbackup/pull/71


flatter: 0-unstable-2023-08-10 -> unstable-2024-03-04

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for flatter is: (F)ast (lat)tice (r)eduction of integer lattice bases
meta.homepage for flatter is: https://github.com/keeganryan/flatter
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found unstable-2024-03-04 in filename of file in /nix/store/k24sbib8ymyxd9qh5mk4yy9zrj1w1r38-flatter-unstable-2024-03-04

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
flatter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k24sbib8ymyxd9qh5mk4yy9zrj1w1r38-flatter-unstable-2024-03-04 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flatter https://github.com/r-ryantm/nixpkgs/archive/24e1fe10b2a37e7a8243c2f490c3266a51e09a3e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/24e1fe10b2a37e7a8243c2f490c3266a51e09a3e#flatter

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k24sbib8ymyxd9qh5mk4yy9zrj1w1r38-flatter-unstable-2024-03-04
ls -la /nix/store/k24sbib8ymyxd9qh5mk4yy9zrj1w1r38-flatter-unstable-2024-03-04/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

flatter

Maintainer pings
cc @josephsurin for testing.

Ran passthru.UpdateScript

It isn't a nixpkgs-update issue: https://github.com/NixOS/nixpkgs/pull/280501

Ran passthru.UpdateScript

It isn't a nixpkgs-update issue: #280501

Oops, sorry!

Result of nixpkgs-review pr 294213 run on x86_64-linux 1

1 package built:

flatter


Optionally put control flow statements and non-simple blocks on single line

For examples (all from my own code):
if p.is_null() { return None; }

for &k in kv.iter() { t.insert(k, ()).unwrap(); }

pub fn new() -> Vec<T> { unsafe { Vec { ptr: Unique::new(EMPTY as *mut T), len: 0, cap: 0 } } }

match self.root.insert_with(b, self.depth, k, f) {
   Err(e) => { d(); Err(e) },
   Ok(_) => { d(); Ok(()) },
}

This is https://github.com/rust-lang-nursery/fmt-rfcs question, but wasn't very popular, so I think won't be implemented


Read from File

How to read from a json file?

Use ioutil.ReadFile to read the contents of the file and then use gjson.Get to get the value.

Let me know if you have further questions. Thanks for using gjson.


Rewrite the extension in React.js

Feature description
Hi!  I recently started developing this extension in react.js. I've been working on it for just a couple of days and I think it's coming along nicely. React.js would allow to fix a lot of existing bugs as well as easily add new features.

Code
You can download the zip here: https://github.com/diananova/genderMagReact (instructions are in the readme file). Let me know what you think!

Quick demo
https://vimeo.com/448721573

Discussed offline: Tool will be staying in JS for maintainability since newcomers would need to know/learn react

Discussed offline: Tool will be staying in JS for maintainability since newcomers would need to know/learn react


Equality for univariate polynomials

Hi everyone! I ran into the following behaviour for univariate polynomials. It seems that by default there is no automation for "combine like terms". For example, the polynomials x + x and 2x are treated as non-equal, if created from coefficients. Here is my code that leads to this:
use ark_ff::fields::{Fp64, MontBackend, MontConfig};
use ark_poly::polynomial::univariate::SparsePolynomial;
#[derive(MontConfig)]
#[modulus = "101"]
#[generator = "2"]
pub struct FieldConfig;
pub type FF = Fp64<MontBackend<FieldConfig, 1>>;
fn main() {
let p1 = SparsePolynomial::from_coefficients_vec(vec![(1, FF::from(2))]);
let p2 = SparsePolynomial::from_coefficients_vec(vec![(1, FF::from(1)), (1, FF::from(1))]);
assert_eq!(p1, p2);
}
Is this the desired behaviour?
Best, Maxim

Hi Maxim (nice to see you're exploring Arkworks!). In my opinion, the MWE you present is pathological behaviour. One solution would be to make it clear in the method documentation that such input is not considered (or in API terms: "behaviour ... is undefined"), and leave the code as-is. Another option is to change the code to panic when that situation occurs. Finally, one could group together the coefficients referring to monomials of the same degree. Since sorting by degree happens anyway, the overhead would probably be minimal.
If someone from the Arkworks team makes a decision on this, I'm happy to implement their preferred solution - or even better, let you @msmirnov18 take over and get a contribution in if you are so inclined (or anyone else).

The use case presented is quite rare and as such I'd rather have it documented appropriately than changing how the current behaviour works.

I could add some comments to the documentation. Perhaps another remark regarding this behaviour is that it can interfere with other functions. For example, the polynomial x^2 - x^2 + x would have degree 2.

@msmirnov18 just a follow-up, are you still planning to clarify the docs?

Closed in https://github.com/arkworks-rs/algebra/pull/750


Add command to show all other commands and their usage texts

This could reduce the bot owner's work to set the command completion via BotFather.

/ls is now available for all admins.

Make /help command an alias to /ls. The help link on the profile page of Telegram client directly sends this command.

/help and /ls are now available for everyone.


Ccisse/switch to sort logic offv8

Addition to https://github.com/Brightspace/d2l-my-courses-ui/pull/743.

Let's do it!


Cleanup some code in index creation and add reprocess method

Add some unit tests
Add io.druid.segment.IndexMerger.reprocess for quick re-indexing of data
Add dim-value validation to validation checker (instead of ONLY index #)
General code refactoring to make things a little easier to read

This came about because I was having some validation issues when recompressing some older segments.

Just tested latest commit with old metrics data. Seems to be working. The following query returns results that only differ by X-Druid-Query-Id:
{
  "queryType"  : "topN",
  "dataSource" : "hadoop_tpch",
  "granularity": "all",
  "threshold":100,
  "dimension":"host",
  "metric":"value",
  "context":{"useCache":false,"populateCache":false,"bySegment":false, "finalize":true, "useOffheap":false},
  "intervals": [ "1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z" ],
  "aggregations": [
    { "type": "doubleSum",   "name": "value",            "fieldName": "value" },
    { "type": "count",       "name": "count" },
    { "type": "longSum",     "name": "total_count",      "fieldName": "count" }
  ]
}

Where hadoop_tpch is the datasource I hacked up to get only the metrics segment of interest in there.

we should make https://github.com/druid-io/druid/pull/1306/files#diff-c3e76c346c5a3ffc6cb8a7cf64374086R1032 also
singleValCol = new NullsAtZeroConvertingIntList(vals, true);


[Improvement] Avoid starting unused threads in spark driver

What changes were proposed in this pull request?
Avoid starting unused threads in spark driver

Why are the changes needed?
In Spark RssShuffleManager, for the role of driver, there is no need to start send blocks threads.

Does this PR introduce any user-facing change?
No

How was this patch tested?
No need

Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.

Actually I think it brings extra complexity in order to avoid initializing a thread, it's a little worthless.

OK.

I'll close it, if you have another better solution, you can raise another pr.


GraphQL - Add Queries for Media Search using Algolia

What
Added the ability to search for media that wraps around Algolia.
Checklist

[ ] All files pass Rubocop
[ ] Any complex logic is commented
[ ] Any new systems have thorough documentation
[ ] Any user-facing changes are behind a feature flag (or: explain why they can't be)

[ ] All the tests pass
[ ] Tests have been added to cover the new code

Not the correct way to do this.


adding Persian as a beta language

Summary
Adding Persian as an new official (beta) language to Mattermost
Ticket Link
Related Pull Requests

Has mobile changes

Screenshots
Release Note
Adding Persian as an official supported language (Beta)

Hello @ctlaltdieliet,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Pinging @jasonblais and @cwarnermm

Thank you  @hmhealey ! Peer reviews do matter!

@hmhealey - Thanks! CC'ing @spirosoik for visibility

@ctlaltdieliet There's a snapshot test failing since it's relying on one of the values that you had to change. Would you be able to fix that?

/update-branch

@ctlaltdieliet There's a snapshot test failing since it's relying on one of the values that you had to change. Would you be able to fix that?
@hmhealey Done :)

Thanks!

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/157221

Thanks @ctlaltdieliet
E2E report looks good, no PR related failures
Wondering why Channels and Favorites are localized on the sidebar, but not on the menu

For other strings still shown in English, I assume those are ok and just missing translation at the moment, correct?

I think both those are fine since they're not directly tied to this PR

Wondering why Channels and Favorites are localized on the sidebar, but not on the menu

That seems like a bug since it's also untranslated in other languages which are out of beta. That text probably can't be translated which needs to be fixed in the code.

For other strings still shown in English, I assume those are ok and just missing translation at the moment, correct?

That one's just a missing string. We'll just claim "beta" on that one. It'll be fixed by the translators eventually

Тhanks @hmhealey
I added https://mattermost.atlassian.net/browse/MM-42401 for follow up. Looks good to merge.

/cherry-pick release-6.5

Cherry pick is scheduled.

/cherry-pick cloud

Cherry pick is scheduled.


Reworking - MiniGramMessage replaced with MiniGramUpdate

Will merge it as is. Next time, please separate changes of formatting and important changes in logic.
Anyway ty for pr


Modifications to maven utilities ListDependencies and new utility recipes for managing dependencies(Willing to contribute)

Hello,
Found this project through a talk, and it is fascinating to see all the work you guys did!
We have a requirement for our project that we need to be able to do couple of things with with pom files:
-List all the direct dependencies
-Fetch the newest released versions of these dependencies(a different recipe)
-Upgrade the dependencies to their latest versions(another recipe)
I was going to fork the project, but since these requirements are needed by a lot of people, I first decided to ask whether if you would accept a PR or not.
I was going to ask would you accept a PR to do:
-Add a parameter to maven utilities ListDependencies to list only direct dependencies.
-Add a new scope to scope parameter called "all" to list all dependencies.(I don't know how to implement that properly though)
-Add a recipe for listing upgrades for direct dependencies(including parent and plug-ins)
-Add a new recipe for upgrading the said direct dependencies.
I haven't contributed any code to open source so I have very limited knowledge of how the contributions work 🙂
I am open to discussing the requirements and any changes that you would suggest.

Hi @fatihdogmus, welcome to openrewrite! @tkvangorder is best suited to answer your questions and is very busy, but I'm sure he'll answer asap!

@fatihdogmus Welcome!
These changes would be very useful and we can help you if you have any questions. You will find we are a friendly bunch.

[ ] Adding a parameter to the ListDependencies recipe to only include direct dependencies

In Rewrite, a pom is represented as an XML document that also has a marker on it called MavenResolutionResult.  The marker represents all the semantic information about the Maven build whereas the document is strictly representing the XML for that pom. You can always get to the semantic information, by extracting this marker from the top-level SourceFile, and if you look at the MavenVisitor we have a helper that does just that.
Once you have the MavenResolutionResult, you have access to the "resolved" pom (basically think of this as the final view of the pom, after we have considered its parent, collected properties, resolved dependencies, dependency management, etc.  And inside that resolved pom, you will also find "requestedPom" The requested Pom, is what the pom looked like BEFORE we did any resolution, so it is the requested pom that can be used to find the direct dependencies. Note, the version in the requested may not match what was resolved and this can take some time to get your head wrapped around. But what you can do, is grab the artifact/group from the requested dependency and then consult the MavenResolutionResult to find what the resolved version is.

[ ] Adding a new scope "all"

I think rather than adding an "all" scope, I would treat the absence of scope to mean "all".  So if you have a ListDependencies with an optional scope parameter, if that parameter is not provided, assume all.

[ ] Add a recipe for upgrading all direct dependencies.

This is actually going to be easy, once you have a utility to list all direct dependencies. We already provide a recipe to upgrade a dependency.
The nice thing about this recipe is it allows you to specify the new version as a semantic version selector: 3.1.x, 2.x, etc
This recipe will already look for the most current version and change it appropriately. So, all your recipe would need to do is iterate over the list of direct dependencies and schedule an update dependency for each one.
I think if you start with modifying the ListDependenices, this would be a great place to start and we can help you if you have any questions related to the work or submitting the PR.
Looking forward to working with you!


Topic/urdf refactoring

HPP developers need a way to build a model from an urdf during running time. This PR fixes this problem by adding a visitor. The root joint is now a JointModelVariant.
To fulfil with #263 and others parsers, the urdf parser is now in the lib.

Coverage remained the same at 60.447% when pulling c6a6dec410e2440057da7d628a8a705802ce46a0 on jcarpent:topic/urdf-refactoring into 5e7339c31746e65d7b9fa37be0b6323040490267 on stack-of-tasks:devel.


Feature/agho11

Added the an implementation of the SPS scheme presented by Abe et al.
In addition, a SPSSchemeTester class was added to the unit tests to simplify testing of SPS schemes in general by providing default implementations of common tests.
[1] Abe et. al.: Optimal Structure-Preserving Signatures in Asymmetric Bilinear Groups.
CRYPTO 2011: Advances in Cryptology – CRYPTO 2011 pp. 649-666
https://www.iacr.org/archive/crypto2011/68410646/68410646.pdf

Just removed the unnecessary interface. GenKeyPair(int... messageLengths) now lives in the scheme implementation itself

LGTM


How to use the foreach block to filter the list which match a Regex?

It really confuse me.I use these block show blow, It does not work.

The list is some string:

I want to output the first and second item, and do not output third item.
but it does output only one item, as show.
so what is the problem? how to use the foreach and regex block?

Hi @a14907 the reason this happens is because the regex block only sends it's data the first iteration of the loop, since it is not a part of the for each. The solution to this is to use a create data block, which has a signal port, which means it can be hooked up to the for each to fire with every iteration and give you an output for each value. See the below image:

The only thing I changed from your Flow is swapping the regex block for a create data block and then adding a connection from the output of the for each loop to the signal port of the create data block so that it fires it's pattern each iteration.

perfect！
It works！


Adding selection sort in C

Added a file for selection sort in C. I'm pretty new to open source and programming - thank you for the opportunity to contribute!

@kefournier : : Thanks for Contributing. It would be great if you can add the description along with the issue number.
Feel free to use our contribution guidelines (https://github.com/fnplus/interview-techdev-guide/blob/master/CONTRIBUTING.md) for reference

Thanks for contributing!


Fixes promise handling issues for purchasing.

This resolves this issue: https://github.com/idehub/react-native-billing/issues/60

I believe it's coming from the In App Billing API docs, not at computer right now, and it's been a bit so I've forgotten exactly where I found it.
Fair point about the formatting, I was in a bit of a hurry to get this cleaned up. I'm actually using my own fork of this, but wanted to contribute back to the main line for anyone else who runs into this problem.

I've looked into this a bit more and now I understand where the number is coming from, the library we are wrapping.
Do you actually need to check the requestCode though, since the underlying library method is returned anyway if it isn't the correct code?
If that is not needed, then please remove that bit from the code + docs, and I'll merge this PR so you (and others) don't have to maintain your own fork of this lbirary :)


Update README.md

Is this a readme fix for the pull request #10 ?

Is this a readme fix for the pull request #10 ?

Yes for the change "Put wiki.txt and tag.csv in src folder." to "Put wiki.txt and tag.csv in mountdir/data/".
And, it is a readme fix for the pull request #11 for the removal of "$ find mountdir -type d -exec chmod o+w {} ;".


Set VkApplicationInfo.pEngineName to Filament

Setting the pEngineName helps with the collection of metrics and is generally good practice.

superceded by: https://github.com/google/filament/pull/7756


skadistats.clarity.ClarityException: oops. no provider found for required

I am trying to run the easiest one which is AllChatProcessor, looks very similar to the go version "manta". However I got this errors, is there something I am missing? I just simply click the AllChatProcessor and run as Java application ( replaced the file name with my own replay)
Exception in thread "main" skadistats.clarity.ClarityException: oops. no provider found for required usage point interface skadistats.clarity.processor.reader.OnMessage
at skadistats.clarity.processor.runner.ExecutionModel.requireProvider(ExecutionModel.java:123)
at skadistats.clarity.processor.runner.ExecutionModel.requireEventListener(ExecutionModel.java:135)
at skadistats.clarity.processor.runner.ExecutionModel.requireProcessorClass(ExecutionModel.java:79)
at skadistats.clarity.processor.runner.ExecutionModel.addProcessor(ExecutionModel.java:49)
at skadistats.clarity.processor.runner.AbstractRunner.createExecutionModel(AbstractRunner.java:29)
at skadistats.clarity.processor.runner.AbstractRunner.initWithProcessors(AbstractRunner.java:35)
at skadistats.clarity.processor.runner.AbstractFileRunner.initAndRunWith(AbstractFileRunner.java:37)
at skadistats.clarity.processor.runner.SimpleRunner.runWith(SimpleRunner.java:36)
at skadistats.clarity.examples.allchat.AllChatProcessor.main(AllChatProcessor.java:23)

Hmm I get it running. However the data I got is a bit different from what I expected.
I expected the hero position will be -7500,-7500 to 7500, 7500 and 0,0 will be in the middle of the map.
because I used to write script for dota2.
However CBodyComponent.m_cellX and CBodyComponent.m_cellY are integers around 128.
which is pretty not accurate. am I missing something here?

Here is some example code which shows positions: https://github.com/spheenik/clarity-analyzer/blob/master/src/main/java/skadistats/clarity/analyzer/main/icon/EntityIcon.java#L38-L60


travis: testing only on stable and latest perl 6 releases

Hi!
This PR simply switches the testing bed from 2015.09 to v6.c, which makes sense to me since we probably want to check against stable and latest versions only. As a result, the Travis-CI output (and its badge) should be green again :wink:
Hope it helps! Thanks for this very nice dist!

Makes sense, thanks a lot :)


docs(config): Fix zap log level typo

:tada: This PR is included in version 2.2.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature Request: Add support for OpenAI Assistants

X-post of https://github.com/raycast/extensions/issues/10082
Forgive me if this is a breach of protocol. The idea is to allow free text input into models (not just the pre-defined list in the dropdown) to allow configuration of the model names defined by the Assistant API.

Allowing full text input would allow a custom value to be used like the one generated by the Open AI Assistant API (begins with "asst_").

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
Alex1100, @Madalosso, @arealclimber, @meher345, @holycreeper-h, @7kms, @ysnayal17, @MizukiSonoko, @nofear-js, @overtrue, @Abraham21, @sachalevy, @foonseca, @luojiyin1987, @ajmoorexyz, @erkanercan, @yulodl, @shmlkv, @skyline75489, @521314


[Band of Blades] Replace engagement GIF by PNG

Apparently, the image proxy is still broken sometimes (always?). Replacing the GIF by a static background.

Character Sheet Info Roll20 Internal Use only.


BUG-Charts on_range_changed called in different situations

Description
The callback function set to the on_range_change property of the chart control gets called in many different situations.
The payload parameter gets updated depending on the action:

Pressing the Zoom In or Zoom out buttons, or requesting a box zoom properly calls the callback and set the xaxis.range[0]...yaxis.range[1] of payload to the appropriate new values of the axis ranges;
Pressing the Reset Axes button also calls the callback, and sets the xaxis/yaxis.autorange and 'xaxis/yaxis.showspikes* properties in payload;
Selecting the Zoom, Pan, Box select or Lasso select tools do invoke the callback, with the dragmode property of payload set to whatever the selected tool is;
A lasso selection invokes the callback sets the selections property of payload to a dictionary that describes the shape of the hand-drawn lasso shape;
may be other cases.

I think this is rather unclear: how to simply detect that we indeed are in a 'range change' situation?
How to reproduce
Run the following code:
from taipy import Gui
import random

x = list(range(0, 21))
y = [random.uniform(1, 20) for _ in x]
data = {
    "x": x,
    "y": y
}

def range_changed(state, _1, _2, payload):
    print(f"range_changed: {payload}")

Gui("<|{data}|chart|on_range_change=range_changed|>").run(run_browser=False)

And manipulate the chart, including the buttons in the chart menu.
Expected behavior
The callback should be called only when the range actually changes.
Or its name is very wrong. And the doc... inexistant.

on_range_change is triggered by the onRelayout plotly event ...
Do you think we should filter the events and not callback on some scenarios @FabienLelaquais ?

on_range_change is triggered by the onRelayout plotly event ... Do you think we should filter the events and not callback on some scenarios @FabienLelaquais ?

Because of the naming of the callback, I would say yes.
Then we'll have to add (in the future) another callback or reuse on_change with documented context.
For the time being my problem is I don't know what to document, really.

I find it a bit difficult to limit this. Especially when we have a reference to the relayout event in the doc ...


Fix boxcox_llf

Following up https://github.com/cupy/cupy/pull/6849.
This PR fixes boxcox_llf to return a scalar array of nan instead of float nan when empty data is given as well as improving its tests on the testing tolerance and input ranges.

@emcastillo Failed to backport automatically.

Not cleanly cherry-picked

@emcastillo This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@emcastillo This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@emcastillo This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

No backport needed as #6849 is only in master.


Format-Pester only generating Summary View from Pester results

I am trying to figure out why Format-Pester is only creating a Summary View of the Pester results of my Smoke Test script.  The contents of the Smoke Test script follow this cadence:
Describe
   Context
      It
      It
      It
      ...
   Context
      It
      It
   Context
      It
Describe
   It
Describe
   It

I call my Smoke Test script with the following:
([String]$PesterScriptSource  = '{0}\Build Scripts\Pester Scripts' -f $LibrarySource) | Write-Verbose
([String]$DateStamp           = [DateTime]::UtcNow.ToString('yyyyMMdd.HHmmss')) | Write-Verbose
([String]$PesterResultsFile   = 'SmokeTestResults_{0}' -f $DateStamp) | Write-Verbose
Invoke-Pester -Tag SmokeTest -Script $PesterScriptSource -Passthru | Format-Pester -Path ($PesterScriptSource + '\Results') -Format HTML,Word -BaseFileName $PesterResultsFile

However, when looking at the TEXT file Format-Pester creates, I see basically a summary report:
Table of Contents
------------------------------------------------------------------------------------------------------------------------
1.  Results summary

1.  Results summary
------------------------------------------------------------------------------------------------------------------------

Total Tests Passed Tests Failed Tests Skipped Tests Pending Tests
----------- ------------ ------------ ------------- -------------
         28           28            0             0             0

My Windows 10 host $PSVerionTable
[PS] C:\Users\me> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.0
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.0
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Here are the loaded Modules, minus the module I am using Pester to test with:
[PS] C:\Users\clynch.DOCTORS-LAB> get-module

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Binary     <IP_ADDRESS>    CimCmdlets                          {Export-BinaryMiLog, Get-CimAssociatedInstance, Get-CimCla...
Script     1.3.1      Format-Pester                       Format-Pester
Script     <IP_ADDRESS>   FormatPX                            {Format-Custom, Format-Default, Format-List, Format-Table...}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Computer, Add-Content, Checkpoint-Computer, Clear-Con...
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Security       {ConvertFrom-SecureString, ConvertTo-SecureString, Get-Acl...
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Manifest   <IP_ADDRESS>    Microsoft.WSMan.Management          {Connect-WSMan, Disable-WSManCredSSP, Disconnect-WSMan, En...
Script     3.4.2      Pester                              {AfterAll, AfterEach, Assert-MockCalled, Assert-Verifiable...
Script     <IP_ADDRESS>  pscribo                             {BlankLine, Document, Export-Document, GlobalOption...}
Script     <IP_ADDRESS>   PSReadline                          {Get-PSReadlineKeyHandler, Get-PSReadlineOption, Remove-PS...
Binary     <IP_ADDRESS>   SnippetPx                           {Get-Snippet, Invoke-Snippet}

Am I "doing it wrong?"  Am I missing something?

So, I looked at Format-Pester.ps1, and see at Line 332 your evaluation to generate the Sections seems to be a bit off.  Are you sure that you meant to only generate sections within the report IF the FailedCount root property of the $PesterResult object was greater than 0?

Hello @ChrisLynchHPE , thanks for your feedback!
You're right, i've got the same issue when there's no failed test... Sorry for the lack of testing...
The solution you provide seems to be the good one. I've pushed a new version (1.3.2) on Github and the powershell Gallery.
What's weird is that I don't have any error with PScribo, maybe @iainbrighton could have an idea ?

Heh, "lack of testing"...  That's a good one!  Glad I could help.
As for PScribo, I didn't modify it in any way.  I removed both modules, installed from PSGallary, and all is working as it should!

Thanks for testing Format-Pester! ;-)
Did you find the module useful ?

Sorry for replying to this almost a year later, but yes, the module is extremely useful.  It helps to generate readable reports.


fix: typescript compiler for dynamic routing solution

adds breadcrumb to the Route type from react router
Note:
There may be a simpler way to add Type BreadCrumb to the type Route using an intersection:
but this is what I could get working.
I do not know how to update just the param of a function type in typescript.

Coverage remained the same at 100.0% when pulling 8c1235585bbaad41b8cbe432993e8355854e6c87 on MichaelDimmitt:fix-typescript-for-dynamic-routing into a5a3188977b5daedb3c5c843c87f28ada62a7c63 on icd2k3:master.

@YousefED @icd2k3 , any thoughts on this solution?
anything you want changed.
thanks!

Sorry @MichaelDimmitt - been a busy week - I'll look into this tomorrow, thank you!

This makes sense to me - and if anyone would prefer to import Route directly from react-router instead they can always make their own type for it.


first bullet in Interfaces Summary is peculiar

It seems to me that the first bullet in the Interfaces Summary (here) is kind of oddly worded.  Read in its entirety it essentially states:

An Interface is like an abstract base class, or it is not like an abstract base class.

It could be re-written in a more linear fashion to read:

An Interface is like a base class. It can be abstract, or it can have default implementations for some or all methods

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e982a51-097f-688f-710c-1dfcf313da5e
Version Independent ID: 8691f826-62cb-da0a-8460-a38aa2bc2a70
Content: Interfaces - C# Programming Guide
Content Source: docs/csharp/programming-guide/interfaces/index.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for pointing this out @Patrick5 That should be worded better.
I've added this to our backlog so that we updated it when we next update this article.


More precise description of allowedDeviationXY and allowedDeviationTheta

FYI @cpaulsynaos

Open for discussion: If allowedDeviationXY or allowedDeviationTheta isn't defined it is benefiting to define a default value of zero?
Pro: There is a clear definition in case the vehicle supports this field but the field isn't present in the order.
Con: In present installation this is handled differently to achieve smooth driving of the vehicle in case the field isn't present.

As I consider eliminating any ambiguities and have a clear expected behaviour wherever we can top priority for the 3.0.0 release, I am in favour of having it default to 0.0

Decision to continue with PR #328 for a better corridor support.


Build & test on openjdk7

Use https://gitlab.com/mvysny/openjdk8_openjdk7 to build this project. The project may need to be migrated to gitlab.

Done, moved to https://gitlab.com/mvysny/slf4j-handroid


feat: use route.lazy

Closes #48
React Router has a new feature called Route.lazy. If we use this instead of React.lazy, we don't need to load each handle, loader etc. in individually:

https://reactrouter.com/en/main/route/lazy
https://remix.run/blog/lazy-loading-routes

@penx Thanks a lot for your contribution. I didn't know about the lazy property. It really simplified the code.
The only problem is that I think it introduces a breaking change since the peer-dependency version needs a bump, and also doesn't support the ErrorBoundary export (a convention that I introduced on top of the remix convention because it made more sense to me).
Let's fix the tests and make sure everything works properly, then we can release a major version.

@mammadataei are you still interested in adding this?

Oh, sorry. I was busy back then and then completely forgot about your PR. Merged.
Thanks again for your contribution.

Released in v2.0.0.


Fe fix forms

Add images (base64 encoded)
Common mark to view post
Use Django Forms instead of Ajax

Codecov Report

Merging #110 (4263d0c) into dev (8dd8cc6) will decrease coverage by 2.98%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##              dev     #110      +/-   ##
==========================================
- Coverage   55.40%   52.41%   -2.99%
==========================================
  Files          15       15
  Lines        1074     1120      +46
==========================================
- Hits          595      587       -8
- Misses        479      533      +54

Impacted Files
Coverage Δ

citrus_network/citrus_home/tests/test_urls.py
100.00% <ø> (ø)

citrus_network/citrus_home/tests/test_views.py
100.00% <ø> (ø)

citrus_network/citrus_home/views.py
33.46% <7.14%> (-3.23%)
:arrow_down:

citrus_network/citrus_home/admin.py
100.00% <100.00%> (ø)

citrus_network/citrus_home/forms.py
100.00% <100.00%> (ø)

citrus_network/citrus_home/models.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd8cc6...4263d0c. Read the comment docs.


help-needed: restify instrumentation

Which problem is this PR solving?
This is adding restify instrumentation.
Short description of the changes
Restify has a somewhat similar API to express and is created for the same purpose - building APIs. This instrumentation wraps all handlers to generate a span for each of them.
Help needed
I'm struggling to debug my issue, so perhaps someone can point me to the right direction:

Using the instrumentation with different versions. The relevant parts of the restify API stay the same across versions 4 to 8(current), so there might only be minor adjustments required if any to support all of those versions. I've built and tested everything on version 4, but once I install version 5 in the example(npm install restify@5 --save), the patches are no longer applied and no diagnostics messages are shown. The rest of the setup stays the same and supportedVersions are set to >=4.0.0, so that should not be the problem.

See my TODO comment in the code and below.

Seems to work fine on 5.2.1

I think I addressed everything except two totally valid points @obecny, brought up, I don't necessarily think are worth changing and would like a second opinion on:

Renaming c to constants. Unnecessarily verbose in such a use-case in my view.
Use of lodash.once. I think we should use quality well-known packages and not reimplement utilities, which would be more costly in the long run, especially in the case where some(most?) distros ship tons of instrumentations, used or not, anyways. We cannot avoid bringing in any 3rd party packages and we have done so in the past(shimmer, require-in-the-middle, etc.).

I don't have a strong technical preference in either of those points, more of a question of how much bikeshedding we want to go through in the long run and for me to calibrate how important maintainers generally think such questions are.

I agree with @obecny here on both points:

i prefer verbosity for the sake of readability

our project is open source, so we expect a lot of people will review our code having constants over c make it easy to understand what the variable is specially when reading on github and not within an IDE)

i prefer to not use a dependency to avoid having few more lines in our code

I don't agree with you by comparing lodash.once (which is 5 lines long that anyone could write without specific knowledge) and shimmer/require-in-the-middle which are battle tested with complex problem within NodeJS
Specially in this case i don't think its actually needed, the next callback shouldn't be called twice right ? And even if it did, nothing will happens (it will generate a warning log on the diagnostic logger which isn't logged by default) so its safe to remove it altogether

I don't have a strong technical preference in either of those points, more of a question of how much bikeshedding we want to go through in the long run and for me to calibrate how important maintainers generally think such questions are.

I agree with you on this however: that there are both technical preference. I don't link blocking PR for those kind of choices (so i'll not) but i strongly recommend addressing them.

Specially in this case i don't think its actually needed, the next callback shouldn't be called twice right ?

Yes, it is not supposed to, but restify doesn't error if it is called twice, just ignores it. There are other cases where it's not called at all. That did make me think about the cases with promises. Added checks for those.
Removed lodash.once and renamed c.
Thanks a lot @vmarchaud and @obecny for your input. It's highly appreciated! :pray:

I don't agree with you by comparing lodash.once (which is 5 lines long that anyone could write without specific knowledge) and shimmer/require-in-the-middle which are battle tested with complex problem within NodeJS

I do wonder whether we should come up with another solution than implementing stuff ourselves if we have a utility in 3 instrumentations? 5? 15?

I do wonder whether we should come up with another solution than implementing stuff ourselves if we have a utility in 3 instrumentations? 5? 15?

We generally have them on the core package (https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-core/src/utils) or the instrumentation package itself (https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-instrumentation/src/utils.ts)


Add download link

Adds a download link for when you want to download a media file instead of viewing it.
I wasn't sure what the best ui for this should be, so I made the existing file icon into the link, with an animation to turn into a download icon on hover/focus. Other suggestions for UI would be welcome.

Apologies for the long delay in reviewing this! This looks dope and great use of the <a ... download> attribute! I'll merge it.


Add Belize holidays

Useful links:

https://en.wikipedia.org/wiki/Public_holidays_in_Belize
https://www.pressoffice.gov.bz/public-and-bank-holidays-2022-updated/
https://www.timeanddate.com/holidays/belize/

Implemented in #1181.


add pm2-able cjs script for running prod "storybook" with the html files we have - point doc links to the storybook itself

move dev files into static