Inactive experiments not being displayed properly in the GUI

In GitLab by @jberlin on Jan 3, 2023, 15:52
I noticed that for almost all old and inactive experiments, the tab concerning the configuration displays something wrong:

some examples:
inactive experiment:

https://earth.bsc.es/autosubmitapp/experiment/t0ad
https://earth.bsc.es/autosubmitapp/experiment/t013

Inactive with no folder in esarchive:

https://earth.bsc.es/autosubmitapp/experiment/t01h

If the data needed by a given experiment tab is not present or incomplete, the tab should be hidden, since user will try to interact with such tab and the result will be only errors or wrong information. if all tabs are hidden as a result, a panel should be displayed with a clear message that the  experiment data is no longer available. we can discuss this in the next meeting (handling of old experiments in the GUI/API).
@mcastril @cgutierr @dbeltran

In GitLab by @jberlin on Jan 4, 2023, 09:58
Please create a separate branch that does not include the migration changes so these small fixes can be deployed without too much hassle

In GitLab by @cgutierr on Jan 4, 2023, 10:37
Merge request is done. There aren't any significant changes, most of the fixes are at AS_GUI_NEXT_RELEASE branch at the GUI .

In GitLab by @jberlin on Jan 4, 2023, 10:42
Hi @cgutierr thanks for the quick fix, I will try to fix also this issue #17 so we have it all together and deploy the fixes in one shot

In GitLab by @cgutierr on Jan 4, 2023, 09:30
If this is really important it could be deployed as a single hot-fix, it is just a couple of lines as you can see in the commit.
Bare in mind that the branch I am currently working on is the Python3.7 API which might require some changes in our production machine such as the adding of the new Python or the Creation of a new Python3 virtual env.

In GitLab by @cgutierr on Jan 4, 2023, 10:32
mentioned in commit autosubmit_api@6c5182fb1de112ba16cc29fef93ecca79b21a89e

In GitLab by @cgutierr on Jan 4, 2023, 07:44
I think that the idea of hiding the tabs with incomplete content is a good one. There are a lot of cases where this should be applied, for example, experiments with more than 12k jobs shouldn't be able to display the graph and thus we should get rid of the graph tab.

In GitLab by @cgutierr on Jan 4, 2023, 10:53
Before going into holidays I remember deploying some experiments to do some testing with this issue about the Wrappers Folder.

They're deployed already.

In GitLab by @cgutierr on Jan 4, 2023, 09:19
The 'EXP' error message problem has been solved, as you can see in here the Historical Database is returning an empty configuration.
Probably related to #62 ?

In GitLab by @jberlin on Jan 4, 2023, 09:25
Hi @cgutierr, it may be related to #62 as you mentioned, I will check the current fixes in DEV, we may need to deploy a new patch in production so we have this fixed and also the previous fixes :)

In GitLab by @mgimenez on Jun 8, 2023, 10:36
If this issue happens again, reopen the issue!

In GitLab by @jberlin on Jan 4, 2023, 11:00
great! thanks !

In GitLab by @cgutierr on Jan 4, 2023, 12:37
The problem is that, as @jberlin said, there is missing data. In this case the table experiment_structure from /autosubmit/as_metadata/structures is empty.
[root@vm rocky]# sqlite3 development/autosubmit/as_metadata/structures/structure_t013.db
sqlite> .table
experiment_structure
sqlite> SELECT * FROM experiment_structure ;
sqlite>

When trying to read the table and cast it into a dictionary, it returned None. Now it'll return an empty dictionary.
This has been added into the Hot-fixes branch too.

In GitLab by @cgutierr on Jan 4, 2023, 12:46
mentioned in commit autosubmit_api@de0e408130e67f1e242892921955e52fa535b100

In GitLab by @jberlin on Jan 4, 2023, 11:49
Hi @cgutierr , I also found that in the statistics tab we have a similar issue, happening both in prod and dev:

https://earth.bsc.es/autosubmitapp/experiment/t013
https://bscesautosubmitdev01.bsc.es/autosubmitapp/experiment/t013/stats

I guess is also related to some incomplete or missed data.

In GitLab by @jberlin on Feb 17, 2023, 16:08
unassigned @cgutierr

In GitLab by @mcastril on Jan 4, 2023, 12:24
I agree. Thanks @jberlin for reporting.


Made the readme file, a lot more funky and aesthetically pleasing

I have made the README file more good looking. funky and aesthetically pleasing.
So as to comply with the intent of providing information to the readers with regards to the pdf content of the same repository.
It provides the fundamental details to first time open source contributors and non technical people to help contribute to the repositories across github.
Issue assigned has now been completed

closes #1


Add support for fetching dependencies through package managers

Currently, we cannot fetch Idris dependencies. In order to do this, we will need to use a package manager for Idris. As of July 25, 2022 it appears that pack is the best candidate to support first.

Pack doesn't support the Idris JVM backend right now, so the current plan is to try and add support for installing dependencies through the Idris compiler itself first.
After thinking on this for a while, there also is very little reason to have a main Maven plugin for all Idris projects, so each package management solution will have its own Maven plugin, as outlined in this design document.


Add runtime check, runtime logs and build logs

This PR attempts to add a runtime check as well as runtime logs and build logs to the docker-build-push-dockerhub.yml workflow

Happy to review! I see you're still pushing some things. Give me a heads up when it's ready

@alishaz-polymath one quick thought, for convenience you could create another docker-compose.yml (maybe in a /test folder?), which provides a different command for the calcom container to run, and effectively run unit tests or integration tests instead of the standard start script.
https://docs.docker.com/compose/multiple-compose-files/extends/

@krumware Thank you, I'll give it a go tomorrow, pretty late here 😅

Hey @krumware Can you please review? I think we can revisit the suggestion you left earlier for maybe next week (I will take it up next week), but if you could review the rest, it would be super awesome 🙌

Oh nice catch indeed! I'll take it up tomorrow morning 🙏

For added context: I've tested this with v3.2.8 and runtime test fails (as expected), but goes through fine with v3.0.0 (as expected). 🙏

@krumware Gentle nudge for review 🙏

Sorry for delay, travelling. Looks good, comments included can be addressed in the future. Thanks!


Persistence in DB

Hi, great project by the way, so i have question how can i use database to store the order book? because the order book is save on memory, right?

@AndrewsK30 any updates on that?

@k-vladyslav hey, so we end up using a custom solution with Redis and queue by price, and workers threads to do the matching .

How did you implement the redis persistence?
Would you like to share the hooks?

I am developing a DB Persistence layer based on EclipseLink JPA

Hi @AndrewsK30! As you noted, at the moment everything is purely in memory. In longer term, I have thought about splitting Parity Trading System into Parity POE Gateway, Parity Matching Engine, and Parity PMD Gateway that would communicate e.g. over Aeron. Then persistence could be achieved via event sourcing on the Parity Matching Engine input queue.


RFC 0116: Should IssuerDID be an optional parameter?

In order to ensure that the protocol remains flexible, we must consider the use case whereby a evidence_access_request is required without a dependency on a Present Proof exchange.
Such a situation, is hypothetically conveyed in the Life Insurance Policy story. Under this condition, the Verifier may not know the IssuerDID.

A subtle implication of the Life Ins Policy story is that this protocol could be used at any point after a Pair-wise DID Exchange has been successfully established and is therefore in the complete state.
However, even under this situation, one of the entities in the Pair-wise relationship would be the Issuer of KYC evidence and therefore the other entity would know the corresponding DID for this private relationship. Therefore, it should be possible for the Evidence Exchange Protocol to be used anytime after a DID Exchange has been completed.
My suggestion is that no changes to the protocol are required (i.e.: Make IssuerDID optional) but a clarification in the protocol text is warranted.

I linked some questions around this protocol in #121
I had some questions regarding this paragraph:

However, even under this situation, one of the entities in the Pair-wise relationship would be the Issuer of KYC evidence and therefore the other entity would know the corresponding DID for this private relationship. Therefore, it should be possible for the Evidence Exchange Protocol to be used anytime after a DID Exchange has been completed.

Are you expecting that the verifier, issuer, and holder will setup a n-wise relationship for this protocol? If so, that makes sense in terms of how the verifier would know about the private relationship. However, in the context of two independent (or even 3) pairwise relationship, I don't understand how this would work. As I interpret this the verifier couldn't discover the issuers DID Document and therefore couldn't discover the service endpoints or keys of the issuer. I think I may be misreading what you mean in this case though. Could you provide some clarification around what entity is doing which action?

@kdenhartog The point of the protocol is to ensure that the Verifier need not have a relationship with the Issuer. The Holder is the clue. The Holder has two private pair-wise relationships, one with  the Issuer and and another with the Verifier. The Holder uses the Request Evidence message flow to gather the needed data from the Issuer. With this in hand, the Holder can satisfy any Evidence Access Message Flow interaction with any Verifier.
So effectively, if Alice gathers evidence from Issuer A in support of Credential A, then Alice can now satisfy evidence requests from Verifier B and Verifier C independently of any further interaction with Issuer A.
Please also refer to the Interaction Diagrams as they call out which entity is doing what / when.

Resolved in PR #127


Trying to access array offset on value of type null

Bug report
Title
When any seller tries to create a product in the system from the frontend i got this error

Issue Description
I checked on the issues and it was mentioned to update it to the latest version and till will fix the issue, i did updated to the latest version but its still showing me the same error
Preconditions
Please provide as detailed information about your environment as possible.

PHP v7.4
Bagisto updated to latest

Steps to reproduce
You can re-product this by doing the following
1. create any new seller
2. Go to his profile
3. Add product (this will be saved after validation on SKU)

Fill the second form and this will generate the error.

Expected result
Expected result should be it create the product

[Screenshots, logs or description]

Hi @wasifiqbal1990
You can raise the support ticket regarding this query here https://bagisto.uvdesk.com/en/customer/create-ticket/
Thanks

I have submitted the ticket but i checked and this issue was reported earlier and was asked to update bagisto to latest version and this will be fixed. I did that but I am still facing that issue.

@wasifiqbal1990
Yes right the same issue is already raised here many times, and resolved when update to the bagisto v1.1.2  but in your case marketplace is also installed which also need to be update.
Thanks

@wasifiqbal1990
Hope your query is being resolved at https://bagisto.uvdesk.com/en/
so we are closing this issue.
Thanks.


delay in live stream

Hi,
I am able to do conference call using your code. But problem is this, it is showing ~10 seconds of  delay in audio and showing ~40 seconds of delay in video. This is not acceptable in any case.
Details as given below
Connected User: 2
Downloading speed of client machine ~20Mbps and uploading speed  is ~40Mbps.
I am using AWS server (8GB of Ram and quad core processor), having bandwidth of up to 10GB.
URL: https://mediasoup.galaxysofttech.co.in/?roomId=room1.
Please help me to sort out this issue.

Hi,
It looks like network issues. Usually, the delay is less, than 0.5 sec. if the network bandwidth is enough and connection is stable (without packets loss). If you want, you may try other media servers, but I don't think it's related to MediaSoup.

Hi,
Thanks for replying. But I have solved it by myself by modifying index.js file (newtransport section) i.e.
mediaPeer.on('newtransport', (transport) => {
console.log('New mediaPeer transport:', transport.direction);
if (transport.direction === 'send') {
transport.setMaxBitrate(config.mediasoup.maxBitrate);
}
transport.on('close', (originator) => {
console.log('Transport closed from originator:', originator);
});
});
then I have set lower value of config.mediasoup.maxBitrate in config. I resolved it

Glad to hear you've solved it. Thanks for posting the solution!


added support "Gwiot 7941E" sensor

I tried another sensor at 125kHz, this time it was this one.
It has much better sensitivity than RDM6300 or RF125-PS.
It reliably detects at a distance of about 4 cm.
There is written, that the supply voltage is 5V, but I have also tried 3.3V and it works completely reliably.
I have added support for this sensor also to the rfid125kHz library.
BTW: I am also preparing my own PCB (something similar to @nardev)

Thanks again @Pako2


Help

I'm not super experieneced in using this type of stuff, can someone please help me tho.
How do i include this into my own stub?

You can run the installer, or better yet, the shellcode installer by looking at this and this example.
The shellcode installer is described in the documentation (link on the main page). It allows you to run the whole installation process in memory. You can encrypt this file at compile time, if you want.

Yeah, issue is I dont know how to get the byte array???

There's a ton of tools. After a quick search, I have found this one. Didn't try it, but it should be a simple task to include a file this way.

@TwoBit69 I am probably on the same page as you and I come from a non programming Background.If I get someone to help out, that would be HUGE! Please tell me you got it to work :)


[suggestion] DAEMON as saga's default mode

from #2021
I thought the problem is on saga's default mode: RESTART_ON_REMOUNT
regarding to https://github.com/facebook/react/issues/11106
garaeon saids:

Regarding componentWillUnmont.
The official docs explicitly recommend use of this hook as cleanup, so this will probably break a lot of people unless changed/docs update/some workaround is recommended.
The docs are talking about clean up on the component level. For example listeners added by a component.
What you're talking about is cleaning up global state. This is inherently messy and can get very complicated. You're welcome to file an issue or PR in the docs repo to clarify it.
fire a cleanup action/set a flag to reset a part of the Redux state tree before showing another component that also uses that part of the state tree but needs it to be re-initialized before render
I've written such code myself before but always regretted it. This is brittle. I recommend refactoring away from patterns where you need this.
The easiest way to do so is to not reuse the same part of the tree in such a way. Think about it: components are generally expected to be independent. What happens if you render two such "exclusive" components at the same time? They will conflict. This doesn't seem like the right component thinking.
I understand it is more code to avoid such patterns, but in my experence replacing a single state tree branch with an object or an array was enough. For example you can key it by ID (even a dynamically generated one), and then instead of tearing down the old one in time for the new component mounting, you can just point the new component to the branch with new ID, while keeping the old one alive. Then eventually you can emit an action that cleans up unused state branches and only leaves the one with the most recent ID.

So ejecting sagas with componentWillUnmount is unnecessary. Sagas are on global-level, and It should not controlled by component-level actions. Sagas should only injected just like reducers.
I think we should remove RESTART_ON_REMOUNT options, and set DAEMON as default.
Actually mods are not necessary, if we do this.
How do you guys think about?

Saga injection issue is so sneaky, i think we need experts :)
cc @Dattaya @justingreenberg

I just run into similar issue as in #2132. I was trying to use saga from other container to update data through API. The problem was that the saga was ejected in the middle of the API call and I didn't see any information in the console.
To the topic:
I don't think it's necessary to make all sagas DAEMONS, but I would suggest two things:

Add a global daemon sagas into containers/App/saga.js and mount it in containers/App/index.js like this:

import { DAEMON } from 'utils/constants';
const withSaga = injectSaga({ key: 'appDaemons', saga, mode: DAEMON });
export default compose(
  withSaga,
)(App);

Add more info into documentation

That would IMHO give developers a better understanding and realization that there's something like "daemon" sagas :-)

I have a question. for who saw this comment.
"When do you need saga ejection and remount?"

I use websocket along with redux saga for real-time updates.
The webpage should listen to notification updates all the time (run as DAEMON)
but post updates only when specific pages are mounted (run as RESTART_ON_REMOUNT)
though judging the current uri in saga is possible, RESTART_ON_REMOUNT is a much cleaner way.
@FourwingsY

@heyrict hmm, does notification actions are intended to trigger post updates?

Well, notification is a 'global' stuff that listens to updates when user is browsing the application (e.g. direct messages),while post update is a 'local' stuff that listens to updates when user is browsing a specific webpage(e.g. twitter new posts or "like" updates), which is not needed on other pages (e.g. settings or preferences).-------- 元のメッセージ --------件名: Re: [react-boilerplate/react-boilerplate] [suggestion] DAEMON as saga's default mode (#2121)From: 양현석 To: react-boilerplate/react-boilerplate Cc: heyrict ,Mention @heyrict hmm, does notification actions are intended to trigger post updates?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/react-boilerplate/react-boilerplate","title":"react-boilerplate/react-boilerplate","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/react-boilerplate/react-boilerplate"}},"updates":{"snippets":[{"icon":"PERSON","message":"@FourwingsY in #2121: @heyrict hmm, does notification actions are intended to trigger post updates?"}],"action":{"name":"View Issue","url":"https://github.com/react-boilerplate/react-boilerplate/issues/2121#issuecomment-375661104"}}}

@heyrict Yes, that data or updates will not need for other pages. But what I want to talk about are redux and the state that redux is handling. The state of redux is on global level, not the component or page level. So what I think is both reducers and sagas should be treated as global level codes, even if it is only needed on single page.

Yes, redux store is on a global level. But you may not want an unmounted component to take all actions to update the redux store as a default right?-------- 元のメッセージ --------件名: Re: [react-boilerplate/react-boilerplate] [suggestion] DAEMON as saga's default mode (#2121)From: 양현석 To: react-boilerplate/react-boilerplate Cc: heyrict ,Mention @heyrict Yes, that data or updates will not need for other pages. But what I want to talk about are redux and the state that redux is handling. The state of redux is on global level, not the component or page level. So what I think is both reducers and sagas should be treated as global level codes, even if it is only needed on single page.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/react-boilerplate/react-boilerplate","title":"react-boilerplate/react-boilerplate","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/react-boilerplate/react-boilerplate"}},"updates":{"snippets":[{"icon":"PERSON","message":"@FourwingsY in #2121: @heyrict Yes, that data or updates will not need for other pages. But what I want to talk about are redux and the state that redux is handling. The state of redux is on global level, not the component or page level. So what I think is both reducers and sagas should be treated as global level codes, even if it is only needed on single page."}],"action":{"name":"View Issue","url":"https://github.com/react-boilerplate/react-boilerplate/issues/2121#issuecomment-375720138"}}}

@heyrict What I believe is: It depends on how you dispatch actions on your code, saga does not have to and need to be ejected with unmount. Preventing update store at such situation is developers responsibility. If some other components dispatches the action, and it updates unmounted-page-only-related state, It would be a wrong code design.
If you have to eject saga for preventing updates of unmounted components, I think that is covering wrong component-action design with wrong saga-control design.

Just my 2 cents here:
It is the developer responsibility to make sure the actions are well specified and well targeted. In fact, it is the most important advice and the philosophy behind this boilerplate. So the argument that "we should not use DAEMON mode so that all the pages' saga start picking up unwanted actions" is same as "using a not intuitive approach to solve a not intuitive problem is the intuitive way".
So, I personally feel DAEMON mode is THE intuitive default mode.

I agree with @FourwingsY and @howardya. I got started today with sagas, and using them in react-boilerplate and I intuitively thought that their behavior was similar to what DAEMON mode offers.
A common use case if a page with sub-components, each sub-component injecting the saga, as they are independent from one another. Everything is fine if you only use one component at a time, but if you instantiate more than one, you get multiple sagas running under the same key, which is far from intuitive.
Just my opinion.

Closing as this change has been implemented thanks to @howardya and #2430.


Argo Tunnel error 1033

The problem
I have connected Cloudflared an have configured it, but do not work..., can someone help me?

What version of Cloudflared has the issue?
4.2.0
What was the last working version of Cloudflared?
No response
What type of installation are you running?
Home Assistant OS
Add-on YAML Configuration
external_hostname: home.mydomain.com
additional_hosts: []
tunnel_token: >-
  token

Anything in the logs that might be useful for us?
Add-on: Cloudflared
 Use a Cloudflare Tunnel to remotely connect to Home Assistant without opening any ports
-----------------------------------------------------------
 Add-on version: 4.2.0
 You are running the latest version of this add-on.
 System: Home Assistant OS 10.3  (amd64 / qemux86-64)
 Home Assistant Core: 2023.7.2
 Home Assistant Supervisor: 2023.07.1
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
[19:48:21] INFO: Using Cloudflare Remote Management Tunnel
[19:48:21] INFO: All add-on configuration options except tunnel_token will be ignored.
[19:48:22] INFO: Connecting Cloudflare Tunnel...
2023-07-15T17:48:22Z INF Starting tunnel tunnelID=a2543c1b-2bf2-4eab-847f-41bf9fa3b974
2023-07-15T17:48:22Z INF Version 2023.7.0
2023-07-15T17:48:22Z INF GOOS: linux, GOVersion: go1.19.6, GoArch: amd64
2023-07-15T17:48:22Z INF Settings: map[loglevel:info metrics:<IP_ADDRESS>:36500 no-autoupdate:true token:*****]
2023-07-15T17:48:22Z INF Generated Connector ID: 3937e1e9-3a97-4e4c-ab21-f0817a92c0a8
2023-07-15T17:48:22Z INF Initial protocol quic
2023-07-15T17:48:22Z INF ICMP proxy will use <IP_ADDRESS> as source for IPv4
2023-07-15T17:48:22Z INF ICMP proxy will use :: as source for IPv6
2023-07-15T17:48:22Z INF Starting metrics server on [::]:36500/metrics
2023-07-15T17:48:22Z INF Registered tunnel connection connIndex=0 connection=325dd4c9-a6ce-455a-b14b-8e3d601dca4f event=0 ip=<IP_ADDRESS> location=FRA protocol=quic
2023-07-15T17:48:23Z INF Registered tunnel connection connIndex=1 connection=6467610a-b4da-4a7b-9548-f148be8d1d7f event=0 ip=<IP_ADDRESS> location=VIE protocol=quic
2023-07-15T17:48:24Z INF Registered tunnel connection connIndex=2 connection=9666d074-762b-4323-bc4f-e0cd6dc079fe event=0 ip=<IP_ADDRESS> location=FRA protocol=quic
2023-07-15T17:48:24Z INF Updated to new configuration config="{\"ingress\":[{\"hostname\":\"home.mydomain.com\",\"originRequest\":{},\"service\":\"http://<IP_ADDRESS>:8123\"},{\"service\":\"http_status:404\"}],\"warp-routing\":{\"enabled\":false}}" version=2
2023-07-15T17:48:25Z INF Registered tunnel connection connIndex=3 connection=ccb4f16d-fba9-4100-9d57-fb8e841f6d85 event=0 ip=<IP_ADDRESS> location=VIE protocol=quic

Steps to reproduce the issue
Configured and started, don't work
Additional information
No response

This error happens sometimes if the tunnel is not (yet) connected to the Cloudflare servers. Did you re-check if the connection was working after some time?

If the problem has not been solved in the meantime, could you share your tunnel configuration from the Cloudflare dashboard?
As it looks in the snippet of your log below, you have entered http://<IP_ADDRESS>:8123 as the service for the IP. Instead the following value should be entered here: http://homeassistant:8123.
Please also check this how-to.
{\"ingress\":[{\"hostname\":\"home.mydomain.com\",\"originRequest\":{},\"service\":\"http://<IP_ADDRESS>:8123\"}


test: add unit tests for handlers and repository for each service

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

78 of 84 (92.86%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 44.75%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/api/v1beta1/group.go
67
73
91.78%

Totals

Change from base Build<PHONE_NUMBER>:
1.4%

Covered Lines:
4441

Relevant Lines:
9924

💛  - Coveralls

@Chief-Rishab Can you please take a look at the conflicts.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

152 of 166 (91.57%)  changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.2%) to 49.805%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/store/postgres/serviceuser_credential_repository.go
0
2
0.0%

internal/api/v1beta1/group.go
11
17
64.71%

internal/store/postgres/user_repository.go
28
34
82.35%

Totals

Change from base Build<PHONE_NUMBER>:
10.2%

Covered Lines:
5480

Relevant Lines:
11003

💛  - Coveralls


Bump Redis to 5.0

remove deprecation message Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead. from the redis gem
https://github.com/redis/redis-rb/pull/1134

Hey @taganaka can you please review this ?

@taganaka Also interested in this. Is there any technical reason this won't work with Redis 5?


Prepare release

@bnaul Please do a quick check for me before I tag 0.3.

Can't test anything from my phone but looks good enough to me.
On Thu, Oct 8, 2015, 8:03 AM Stefan van der Walt<EMAIL_ADDRESS>wrote:

@bnaul https://github.com/bnaul Please do a quick check for me before I
tag 0.3.
You can view, comment on, or merge this pull request online at:
https://github.com/mltsp/mltsp/pull/74
Commit Summary

Fix entrypoint for console script
Add version flag to 'mltsp' script
Add test for entry point
Update ignores
Add example config and install
Update and simplify installation instructions
No longer ignore version file
Update version

File Changes

M .gitignore https://github.com/mltsp/mltsp/pull/74/files#diff-0
(2)
M MANIFEST.in https://github.com/mltsp/mltsp/pull/74/files#diff-1
(1)
M Makefile https://github.com/mltsp/mltsp/pull/74/files#diff-2
(5)
M doc/install.md
https://github.com/mltsp/mltsp/pull/74/files#diff-3 (63)
M mltsp/Flask/flask_app.py
https://github.com/mltsp/mltsp/pull/74/files#diff-4 (161)
M mltsp/init.py
https://github.com/mltsp/mltsp/pull/74/files#diff-5 (2)
R mltsp/mltsp.yaml.example
https://github.com/mltsp/mltsp/pull/74/files#diff-6 (4)
M mltsp/setup.py
https://github.com/mltsp/mltsp/pull/74/files#diff-7 (1)
A mltsp/version.py
https://github.com/mltsp/mltsp/pull/74/files#diff-8 (1)
M setup.py https://github.com/mltsp/mltsp/pull/74/files#diff-9
(2)

Patch Links:

https://github.com/mltsp/mltsp/pull/74.patch
https://github.com/mltsp/mltsp/pull/74.diff

—
Reply to this email directly or view it on GitHub
https://github.com/mltsp/mltsp/pull/74.

Why are the tests failing?

@acrellin Because I am now using pip to install dependencies, and some installs are failing.  Working on fixing that now.

Mergin this so that I can tag the release.


GEOPY-892: use argparse and add tests for conversion scripts

GEOPY-892 - use argparse and add tests for conversion scripts

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.0.0@21beac1). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/3.0.0      #29   +/-   ##
================================================
  Coverage                 ?   83.64%
================================================
  Files                    ?       14
  Lines                    ?     1009
  Branches                 ?      158
================================================
  Hits                     ?      844
  Misses                   ?      102
  Partials                 ?       63

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Split the basic block around the callsite.

It turns out the basic block splitting is necessary after all...
If the basic blocks aren't split at each marked callsite, then LLVM may generate code that looks something like this:
Optimized function:
jump to __guard_failure
load format string into some register

Unoptimized function:
load format string into some register
return from __guard_failure
<the format string is nowhere to be found>

Ah, too bad.
You could make a note for your write up that it would be nice to have compiler support for this?


fix(detail): Detail page bug fixed

Problem

Stay on backlog
Detail add an item
Wait for opening the details page of newly created item
Switch to an iteration
URL looks good but the details page is going blank as it is for creating a new item.

Solution

Remove incorrect use of route.queryParams observable and use route.snapshot instead.
Use the advantage of switchMap to queue up the to observable i.e. currentSpace and then route.params

@sanbornsen snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1733-fabric8-planner.int.rdu2c.fabric8.io

@sanbornsen snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1733-fabric8-planner.int.rdu2c.fabric8.io


feat(sbb-overlay): extract sbb-overlay component from dialog

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes #2476
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

extract sbb-overlay component from dialog

Browsers
I tested the build on the following browsers:

[ ] Firefox Desktop
[x] Chrome Desktop
[ ] Edge Desktop
[ ] Safari Desktop
[ ] Chrome Mobile
[ ] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[x] Yes
[ ] No

Other information

Codecov Report
Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@31b5cf5). Click here to learn what that means.

:exclamation: Current head 105e19f differs from pull request most recent head e334514. Consider uploading reports for the commit e334514 to get more accurate results

Files
Patch %
Lines

src/components/core/dom/breakpoint.ts
85.71%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage        ?   93.61%
=======================================
  Files           ?      300
  Lines           ?    24630
  Branches        ?     2077
=======================================
  Hits            ?    23057
  Misses          ?     1540
  Partials        ?       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: add https for notify url

When using the ngx_rtmp_notify_commands for different events such as on_connect or on_publish, we want to notify an authentication service.
We use these directives in the nginx.conf and provide the URL of the authentication service.
However it doesn't work when the authentication service is using https.
This is because the ngx_rtmp_notify_parse_url in ngx_rtmp_notify_module.c method does NOT handle https.
    if (ngx_strncasecmp(url->data, (u_char *)"http://", 7) == 0)
    {
        add = 7;
    }

I propose a very simple fix:
    if (ngx_strncasecmp(url->data, (u_char *)"http://", 7) == 0)
    {
        add = 7;
        port = 80
    }
    else if (ngx_strncasecmp(url->data, (u_char *)"https://", 8) == 0)
    {
        add = 8;
        port = 443;
    }

This fix is very similar to these:
https://mailman.nginx.org/pipermail/nginx-devel/2013-August/004065.html
https://github.com/kaltura/nginx-aws-auth-module/blob/dbbac974f0699328a63f497cd911a4f991faed9b/ngx_http_aws_auth_module.c#L992-L1009

I know this is quite old but everytime I try using it I get, invalid port in url "https://MY_DOMAIN_NAME.com/api/endpoint_here" in /usr/local/nginx/nginx.conf:141
here is my rtmp block aswell if that helps:
rtmp {
        server {
                listen 1935;
                chunk_size 4096;
                allow publish <IP_ADDRESS>;
		allow publish all;
                deny publish all;

                application live {
			on_publish https://MY_DOMAIN_NAME.com/api/endpoint_here;

			live on;
                        record off;
			hls on;
                        hls_path /usr/local/nginx/html/stream/hls;
                        hls_fragment 3;
                        hls_playlist_length 60;

                        dash on;
                        dash_path /usr/local/nginx/html/stream/dash;
                }
        }
}


/free-online-tools/index.md

List of free online tools and resource for web design

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Added a sub-folder with a list of free online tools and resources for web design.

I have read freeCodeCamp's contribution guidelines.


Microfacet BRDF node breaks rendering

Doesn't display in material preview.
Error: invalid model "microfacet_brdf"

Wasn't microfacet removed from appleseed?  It's not in the built in entities list.

It was, yes.

Well it would make sense that its broken in blenderseed then :)

I'll roll this into my BSDF tasks.

Ok, changing the title of the issue.

#87


Ordering of filter choices for Format

They should be listed in this order:
Broadsheet
Folio
Quarto
Octavo
Duodecimo
Sixteenmo

These choices are fetched from formats.json which is generated during build here. If you just reorder things in the json file it will change what's displayed in the dropdown.

I'm not sure how to do this because the items are not actually listed there...


chore(package): update webpack to version 4.15.1

Closes #115

Pull Request Test Coverage Report for Build 513

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.754%

Totals

Change from base Build 510:
0.0%

Covered Lines:
82

Relevant Lines:
83

💛  - Coveralls


[GEOMETRY-105] - Replace the try-catch pattern with assertThrows()

Hi @singhbaljit
I have made all the changes except the import. IMO i't not a good practice use wildcard. could lead to conflicts or errors


Remove jcenter repository

Description
JCenter has been turned off and should be removed as a referenced repository.
Please Remove any direct dependency on jcenter() within a repositories block in gradle files.
Related: https://github.com/opensearch-project/opensearch-build/issues/1456

@opensearch-project/performance-analyzer can this be triaged and prioritized?


Many wrong features in a sector of the municipality of Frontino, department of Antioquia Colombia.

https://mapwith.ai/rapid#background=Maxar-Premium&disable_features=boundaries&map=17.25/6.77153/-76.17401

Hi @JLOSM
Looks like this area has cloud cover in our imagery. We'll rerun it once we get some newer imagery for prediction.
Thanks for letting us know!

En la zona donde reporte, no existen nubes en las imágenes de Maxar.
No me concuerda con la respuesta.

De: jeffdefacto<EMAIL_ADDRESS>Enviado: lunes, 21 de septiembre de 2020 12:23 p. m.
Para: facebookincubator/RapiD<EMAIL_ADDRESS>Cc: JLOSM<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Asunto: Re: [facebookincubator/RapiD] Many wrong features in a sector of the municipality of Frontino, department of Antioquia Colombia. (#178)
Hi @JLOSMhttps://github.com/JLOSM
Looks like this area has cloud cover in our imagery. We'll rerun it once we get some newer imagery for prediction.
Thanks for letting us know!
[image]https://user-images.githubusercontent.com/17914981/93799740-6a2ac000-fbf4-11ea-850c-3c11bce2cb73.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/facebookincubator/RapiD/issues/178#issuecomment-696255831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARCKSHNBOOH5IY6KBFBDBVTSG6DZTANCNFSM4RT2BNCQ.

Hey @JLOSM
Current Maxar Premium has captured this area with clear satellite, but our internal version of the imagery was ingested some time ago and, as you can see in the screenshot above, its cloudy in that area.
Once we ingest the latest imagery from Maxar, it should match what you see in the public Maxar Premium layer.

thanks for the follow up @jeffdefacto - I guess we can keep this issue open until our ML roads data is updated for the area, after our imagery is updated.


Panic when getting entropy

Panic when there is an error from rand.Read as discussed in #9. Effective Go says its reasonable to panic during init.
I moved the fallback MAC address to reduce the number of times a typical program would call rand.Read.

LGTM !
On Sat, Jun 6, 2015 at 7:17 AM, Chris Bandy<EMAIL_ADDRESS>wrote:

Panic when there is an error from rand.Read as discussed in #9
https://github.com/satori/go.uuid/issues/9. Effective Go says its
reasonable to panic during init.
https://golang.org/doc/effective_go.html#panic
You can view, comment on, or merge this pull request online at:
https://github.com/satori/go.uuid/pull/12
Commit Summary

Move epoch initialization out of init
Panic when there is an error getting entropy

File Changes

M uuid.go https://github.com/satori/go.uuid/pull/12/files#diff-0
(31)

Patch Links:

https://github.com/satori/go.uuid/pull/12.patch
https://github.com/satori/go.uuid/pull/12.diff

—
Reply to this email directly or view it on GitHub
https://github.com/satori/go.uuid/pull/12.

Thanks!


Crops: Growth Specs

Build a system that tracks crop growth specs depending on crop type. Use this to determine if a plant grows or not as a day passes.

Water (shouldnt be too low or two high)
Weeds
Pests

Actions taken and levels affect plant happiness. Happiness is the final determiner for growth.

Addressed in branch iss006!


EE-1183: Added Property Testing Around Keys and Stored Values

Ref: https://casperlabs.atlassian.net/browse/EE-1183
This PR

extends property testing coverage of Keys and StoredValues

bors merge


Merge Gitter badge into development branch

The Gitter badge got committed against master, not development.

@psychomario @icb- why do we have Gitter at all? We're the only three who really collaborate on this project (rarely does someone even open an issue); I really don't think this project is big enough to warrant a Gitter (it doesn't even warrant a wiki yet).

We did already help one person in it.

Forgive me but do you honestly think it's justifiable to have a Gitter when it's been active for about two months and we've only helped one person? I could understand if this project had 10+ people working on it 'round the clock and dozens of people were constantly opening issues for petty little questions and troubleshooting information but this project honestly isn't that big. If someone has an issue they can open an issue in the issue tracker, the entire purpose of the issue tracker is to track issues and having them on record makes it easier in the long-run to reference old requests/conversations.
@psychomario I'm not really sure what your opinion is on this (it's your repo after all) but I really don't see the need for a Gitter at this stage. Personally, I think it should be removed entirely; there's really no need for it.

I have no stronger opinion either way. It could have been useful hence why I accepted the PR, but it hasn't really turned out to be so, so there doesn't see to be a benefit of it staying, and it could cause fragmentation of issues if it stays.
Is it going to be easy to revert the master PR?

@psychomario if you are on master and do a git revert 33aed498ca8653670e7ed9838d82c6104366dba3 4f65547e6a4d236b9d1cd378c175db861411e9a4 that will revert the last two commits and create a new one which, effectively undoes the changes in those two commits. You can make the commit message something like "removing Gitter badge" or whatever and then you want to push that commit.

Okay, I can't do this until Sunday but I'll make sure to do so then.

@psychomario I can do it if you'd like?

That would be ideal, thanks.

:+1: I'll take care of it sometime today.

@psychomario I reverted the commit which added the Gitter badge. I think you should revoke repository access to gitter-badger and any remove any/all other traces and/or connections from this repo to Gitter.

I've had a look and I don't think gitter has any access that I can see. It was only a PR so I don't think any permissions are gained when merging.

:+1: I wasn't sure how it found the repo (you gave it access, signed in with your account, etc.) so figured just give it a look over. Thanks.


Fix shape.id.separator regression

Hi!
I created a fork to fix the problem reported here: #740
Regards
Fixes #740

I'll try to backport this and cut a patch release because on main we have dropped Node.js 12 support.


Fix add element to list in zsh if the element contains an environment variable

In particular, avoid to escape the argument of the ensure_quotes function in zsh, as done in bash

Without this fix, msh lines such as:
	sys.list_append("XDG_DATA_DIRS", path.join(env("CONDA_PREFIX"), "share"))

resulted in the following line being generated in bash:
    pathappend "$CONDA_PREFIX/share" XDG_DATA_DIRS

while on zsh:
    listappend "\$CONDA_PREFIX/share" XDG_DATA_DIRS

The fact that the initial $ is escaped actually breaks the correct evaluation of the environment variable, see https://github.com/robotology/robotology-superbuild/issues/779#issuecomment-869785843 . The fix is actually to remove the re.escape calls in ensure_quotes of zsh, to align it with the same function for bash. This modification pass all the existing tests.

Thanks!

I tried to add a regression test for this issue in https://github.com/mamba-org/multisheller/pull/12, but that test is failing on xonsh for an unrelated reason. Unfortunatly I have limited xonsh experience.

I can take a look later, let's leave the other PR open for now


Back end continuous-variable endpoint having trouble with WWARN "publication year"

https://qa.restricted.clinepidb.org/ce.restricted.qa/app/maps/DS_24899fbd90
Try selecting 'Publication year' as marker overlay.
/filter-aware-metadata/continuous-variable
{
	"config": {
		"metadata": [
			"binRanges"
		],
		"variable": {
			"entityId": "EUPATH_0035127",
			"variableId": "MI_0886"
		}
	},
	"filters": [],
	"studyId": "WWARN-1"
}

if this is very important for demo, ill move it up

is this more or less important than the marker config mockups?

var type and shape are right. My next wonder is - when we use other date vars wiht getDiscretizedBins, are we setting the class as date elsewhere? In the normal plot.data functions we have the var map tell us that the var is type=date. One fix could be just checking to see if it's a date and then assigning it's class to 'date'. But i want to make sure its truly just a product of this function being called without any var processing on the input.

The other two "year" vars in this dataset are annotated as integer, continuous, whereas the publication year is date, continuous.
That's why it seems as though two of three year vars are "working".

I think we just ask data loading to make this an int too then. I don't see much benefit to them being dates if we only know the year..


Suggest new UI/UX design for the board

hey, can I contribute to the required UI/UX design? using SCSS and advanced CSS using animation, translation, and transition etc?

@geeks5551 You have commented on multiple issues to work on. We would suggest you to pickup one issue once its solved than move to the next one. Let us know on which issue you want to work on.

if someone is not assigned , can you assign to me ?


[Snyk] Security upgrade debian from bullseye to 11

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile.debug

We recommend upgrading to debian:11, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

****
CVE-2022-1664 SNYK-DEBIAN11-DPKG-2847942
No Known Exploit

****
OS Command Injection SNYK-DEBIAN11-OPENSSL-2807596
No Known Exploit

500
Out-of-bounds Read SNYK-DEBIAN11-PCRE2-2808697
No Known Exploit

500
Out-of-bounds Read SNYK-DEBIAN11-PCRE2-2808704
No Known Exploit

150
Information Exposure SNYK-DEBIAN11-UTILLINUX-2401081
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Huh, false positive from snyk? bullseye and 11 are aliases for the same image?


Can you target "Text" layers as "children"?

Question
I have a Figma component that uses a "Text" layer instead of a property. With code connect, is there a way to target this layer to map to a coded component prop? In my scenario, I'm trying to map this to the label prop in the coded component. I've tried using figma. children() with the name of the layer with no success, I know this isn't the intended here.
Context
Layers
All the nested layers in this tree are either row or column layouts.

Render

Info

Code connect

Hi @l-campbell, right now we don't support this I'm afraid, but it's on our roadmap as we know some design system do use overrides like this instead of props. I'll keep this issue open so we can update you on progress.

Just chiming in here to say that our design team also uses a similar approach in some components, so it's great to hear it will be supported 🎉

+1 for wanting this

Confirmed this works for my above example with Tabs. 🙌
However I'm struggling to get the value for an example that has the text layer nested more deeply. Any solution for this without updating the actual Figma component itself?

Hey @alisonjoseph, happy to hear it's working for you. You should be able to reference this nested layer using figma.nestedProps, something like:
nested: figma.nestedProps("_Number input base", {
  text: figma.textContent("Text")
})

which would then be available as props.nested.text

@tomduncalf-figma Nested property support is 🔥 worked perfectly, thanks!


Fix issues which prevented tinyFaaS from working correctly

Two issues needed to be fixed in order for tinyFaaS to work:

src/gateway had to be renamed to src/endpoint because code referenced src/endpoint  (and uses the name endpoint a lot) but the folder in the repo was src/gateway

/run was missing from here which resulted in responses from the function-handlers being always empty (I hope this bug wasn't a thing during benchmarking)

Thanks for the PR! I added the "/run" and renamed the "endpoint" to "reverse proxy" as in our paper.


Bump NCDatasets to 0.14 and CommonDataModel to 0.3

This bumps NCDatasets to 0.14.
I had to add the ignore to stale_deps check to make the tests run locally.
This is only needed because we need Requires for the extensions in Julia 1.8 or lower.
This is currently failing because of two fails in the NCDataset tests, I can have a look at this on Monday.
Why are there no CompatHelpers for NCDAtaset, is it because it is a weakdep?

Closed in favor of #607


DriverAPI: add isAutoDepthResolveSupported query.

@pixelflinger can you point me in the right direction for the next step?  We need to use this query from PostProcessManager, right?

@pixelflinger this one is ready to go, I think.


Prioritize index.css over the implicit App.css

Hi. I'm under the assumption that index.css is used for global styles not associated with any component. This is where I import 3rd party css libraries as well. However, I noticed that it would override the styles in App.css.

That’s a good catch.

Fixed in latest version. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8


Component methods not found (undefined) in instance()

Hi, so apparently I can't get the methods of a React component using wrapper.instance().normalizeEvents([mockArray])
This is what my code looks like, I have been looking for answers anywhere but still, no luck.
Calendar.js
class Calendar extends Component {
 normalizeEvents = data => {
 let events = [];
    data.map(event => {
      events.push({
        id: event.id,
        title: event.title,
        start: event.start,
        end: event.end,
        color: event.category.color,
        textColor: event.category.textColor,
      });
    });
    return events;
 }
 render() {}
}

export default connect(mapStateToProps, mapDispatchToProps)(withRouter(Calendar));

Calendar.test.js
const wrapper = shallow(<Calendar store={mockStore()}/>);
const instance = wrapper.instance();
console.log(wrapper.normalizeEvents(mockArray));

It shows up an error on my jest test, as TypeError: wrapper.normalizeEvents is not a function
Is there something wrong with the code or?
EDIT:
version lists
"enzyme": "^2.9.1",
"react-addons-test-utils": "^15.6.0",
"jest": "^20.0.4"

Because the instance there is the connected component wrapper which lacks those methods. Try .dive().instance()

@ljharb Thanks for the quick reply, however I've changed my test file into this code, and it stills give me undefined function.
const wrapper = shallow(<Calendar store={mockStore()} />);
const instance = wrapper.dive().instance();
console.log(instance.normalizeEvents);

@denchoooo ah, you're using two HOCs - connect and withRouter. So, you'll need .dive().dive().

I have the same problem without a HoC. Prepared minimal reproducible code fragment:
   class TestComponent extends React.Component {
        render() {
            return (<View/>)
        }
    }

    it("has an instance", () => {
        const wrapper = shallow(<TestComponent/>)
        const inst = wrapper.instance();
        expect(inst).toBeTruthy();
    })

This code ends with:
Error: expect(received).toBeTruthy()
Expected value to be truthy, instead received undefined

Your minimal repro case should pass; and your error is from different code. Can you please provide the exact code that's erroring?

But it is the exact code that's erroring :P
import {shallow} from "enzyme"
import * as React from "react"
import {View} from "react-native-mock"

class TestComponent extends React.Component {
    render() {
        return (<View/>)
    }
}

it("is an instance", () => {
    const wrapper = shallow(<TestComponent/>)
    const inst = wrapper.instance();
    expect(inst).toBeTruthy();
})

[Hyster][Lysy] (master) $ jest instance
 FAIL  app\tests\instance.test.js
  ● is an instance

    expect(received).toBeTruthy()

    Expected value to be truthy, instead received
      undefined

      at Object.<anonymous> (app/tests/instance.test.js:14:14)

@wnadurski expect(received) can't possibly work in your example then, because there's no variable called received in your example test - it's quite clear that it's not the exact code that's erroring.

According to Jest's documentation of the expect (https://facebook.github.io/jest/docs/en/expect.html#expectvalue) it's expected error message when an assertion fails. They gave an example:
test('the best flavor is grapefruit', () => {
  expect(bestLaCroixFlavor()).toBe('grapefruit');
});

which results in error message:
  expect(received).toBe(expected)

    Expected value to be (using ===):
      "banana"
    Received:
      "apple"

Weird; we use chai with jest, so I've never seen that error.
@wnadurski At any rate, what does wrapper.debug() print out? What version of enzyme are you using? Why are you using import * as React from 'react'; instead of the proper import React from 'react';?

@ljharb
1.Output from debug() method is simply: <View />
2. "enzyme": "^2.9.1",
3. That's a good question :P For an unknown reason it's how Intellij resolves imports automatically. I changed the line to proper import React from "react" and still have the same problem :(

Wait, View - that's react native - are you using a version that works with React 15? Enzyme doesn't support React 16 alphas or betas, so we also don't yet support any react-native version that requires a React higher than 15.

Yup, I'm using React 16.0.0-alpha.12 :( Thanks for help

@denichodev, happy to reopen if https://github.com/airbnb/enzyme/issues/1045#issuecomment-317949256 doesn't solve your issue.


why i can not use videojs

why i can not use videojs ? not work

https://github.com/DinoDabs/Google-Drive-Player-Script/blob/master/embed.php

not work format not support mp4 files

http://yoursite.com/embed.php?url=https://drive.google.com/file/d/0ByaRd0R0Qyatcmw2dVhQS0NDU0U/view
it works...


Allow setting authentication client for google-cloud libraries

PR 1207 will implement the capability to impersonate a service account.  That is given a set of source credentials, the implementation will derive a new set of credentials which are eventually intended to call an underlying GCP API.
The implementation there surfaces an object which can be used to make direct REST api calls  (see 28->51.  However, there isn't an easy way to inject this type of a client into any existing google-cloud-* library set.
The only way to do that now is to create a placeholder client (see 57->72 and set that into a library which internally extracts the raw client fromthe placeholder/wraper object
Also, this workaround with the wrapped client will work for some google apis (eg, it will not work for Storage )

This FR is to
Construct a uniform surface to allow injecting authenticated clients into google-cloud-* libraries.  Essentially, it shoud not be necessary to setup the intermediate placeholder/wrapper for the client and also the same final mechanism should work for all libraries (Storage)

Finally there are several flavors of 'clients':

DownscopedClient
ImpersonatedClient

which actually differ in the classes it using:
export class DownscopedClient extends AuthClient {
export class OAuth2Client extends AuthClient {
export class Impersonated extends OAuth2Client {

which means the usage of these clients diverges  (eg, i probably can't use a downscoped client into a google-cloud library even after this FR is done)

Assigning @bcoe for triage.

here is the tmp workaround for impersonated+gcs which was shown to me yesterday:
https://gist.github.com/salrashid123/e5fc03761f62ef6ff213ac3b29661967
note, i manually added in the sign() method to node_modules/google-auth-library/build/src/auth/impersonated.js just to allow impersonated_credentials to issue signedurls

This should be supported as of v7.14.0: https://github.com/googleapis/google-auth-library-nodejs/pull/1372
GoogleAuth now accepts AuthClient: https://github.com/googleapis/google-auth-library-nodejs/blob/b48254490768799e465a8fa4aae13296ddceea53/src/auth/googleauth.ts#L74-L78
Sample: https://github.com/googleapis/google-auth-library-nodejs/blob/main/samples/downscopedclient.js


Recurring IAP "grandfathered" allowed values documentation?

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
When using spaceship to update in app purchases, what are the allowed values for "grandfathered"?  The only value I've been able to find is grandfathered: { value: "FUTURE_NONE" }.  I could guess that FUTURE_ALL is allowed, but I still wouldn't know what either of those mean.   I'm looking to ensure that all our current subscribers are grandfathered in.  @hjanuschka Do you know by chance?
    pricing_intervals: [
      {
        country: "WW",
        begin_date: nil,
        end_date: nil,
        tier: 20,
        grandfathered: { value: "FUTURE_NONE" }
      }
    ],

I looked into this a bit, I found this issue with an additional example: https://github.com/fastlane/fastlane/issues/11169#issue-281078149


[ERD]: Import/Export for Workflows

Hey team! Please add your planning poker estimate with Zenhub @ayushpahwa @srix


[Android] Enable chip_enable_schema_check for android platform.

Signed-off-by: sanghyukko<EMAIL_ADDRESS>Signed-off-by: Charles Kim<EMAIL_ADDRESS>Problem
MAC/Linux already enabled detail info for certification,
We also want to enable detail info of cluster message on Android platform.
Change overview
Enable android platform os on GN build
Testing
Example message detail info after changes.
[1646313566.134637][8200:8200] CHIP:DMG: IM WH moving to [Initialized]
[1646313566.134745][8200:8200] CHIP:DMG: WriteRequestMessage =
[1646313566.134804][8200:8200] CHIP:DMG: {
[1646313566.134861][8200:8200] CHIP:DMG:        timedRequest = false,
[1646313566.134920][8200:8200] CHIP:DMG:        AttributeDataIBs =
[1646313566.134998][8200:8200] CHIP:DMG:        [
[1646313566.135058][8200:8200] CHIP:DMG:                AttributeDataIB =
[1646313566.135128][8200:8200] CHIP:DMG:                {
[1646313566.135195][8200:8200] CHIP:DMG:                        AttributePathIB =
[1646313566.135281][8200:8200] CHIP:DMG:                        {
[1646313566.135349][8200:8200] CHIP:DMG:                                Endpoint = 0x0,
[1646313566.135429][8200:8200] CHIP:DMG:                                Cluster = 0x28,
[1646313566.135519][8200:8200] CHIP:DMG:                                Attribute = 0x0000_0005,
[1646313566.135599][8200:8200] CHIP:DMG:                        }
[1646313566.135682][8200:8200] CHIP:DMG:
[1646313566.135764][8200:8200] CHIP:DMG:                                Data = "te5new",
[1646313566.135877][8200:8200] CHIP:DMG:                },
[1646313566.135955][8200:8200] CHIP:DMG:
[1646313566.136013][8200:8200] CHIP:DMG:        ],
[1646313566.136083][8200:8200] CHIP:DMG:
[1646313566.136141][8200:8200] CHIP:DMG:        moreChunkedMessages = false,
[1646313566.136205][8200:8200] CHIP:DMG:        InteractionModelRevision = 1
[1646313566.136260][8200:8200] CHIP:DMG: },

Change is non-obvious: it says enabling chip_enable_schema_check but instead it changes the default for chip_enable_python_modules

I think we change different file during the commit migration from our code to contribution code because of conflicts. I will fix and update again.

Change is non-obvious: it says enabling chip_enable_schema_check but instead it changes the default for chip_enable_python_modules

Can you check again our final commit? @andy31415


[Feature Request] "Find in opened tabs" functionality

Description
Now we have a Find in project item in a Find menu and in a project context menu. It would be nice to have a Find in opened tabs functionality
Steps to Reproduce

open atom

Expected behavior:
I want to be able to search a text in opened tabs only.
Actual behavior:
There are no such functionality
Reproduces how often:
Always
Versions
$ atom --version
Atom    : 1.21.1
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

Thanks for taking the time to contribute!
We noticed that this is a duplicate of atom/find-and-replace#241. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Only first frame of gif is saved when using log_image

When using log_image and passing a Pillow Image as a parameter which is a gif sequence, only the first image is saved.
The likely fix for this is to set save_all=True in the save() call for the Pillow image if the file extension is .gif

Oh nice, I didn't know that Pillow has an easy way to do this.


Fixes pods text positioning and elide issues, adds ipaddress pod

Fixes for https://github.com/OpenVoiceOS/ovos-PHAL-plugin-gui-network-client/issues/6
Adds IP Address pod to connected network view

closes #6


Poseidon over BN254 support

Hello,
I am looking for an implementation of the MDS matrix for the Poseidon permutation over the BN254 curve. Specifically, I am interested in benchmarking the performance of Poseidon over BN254. Does such an implementation exist, or is there an existing MDS implementation that can be used for this purpose?
Thank you!

there is https://github.com/HorizenLabs/poseidon2/blob/main/plain_implementations/src/poseidon2/poseidon2_instance_bn256.rs for poseidon2 and https://github.com/privacy-scaling-explorations/poseidon for poseidon. I believe poseidon1 and poseidon2 are the same for the usual parameters for bn254, but the implementation is simplified in poseidon2

Something like IntegratedCosetMds should work out of the box, although it's mainly designed for large matrices over small fields; I imagine naive multiplication with some hardcoded low-weight matrix could give better performance for BN254.

there is https://github.com/HorizenLabs/poseidon2/blob/main/plain_implementations/src/poseidon2/poseidon2_instance_bn256.rs for poseidon2 and https://github.com/privacy-scaling-explorations/poseidon for poseidon. I believe poseidon1 and poseidon2 are the same for the usual parameters for bn254, but the implementation is simplified in poseidon2

Thank you for your suggestions. I have tested both implementations of Poseidon and Poseidon2 that you mentioned, and I found that, compared with Poseidon,  the performance improvement of poseidon2 is still obvious for the usual parameters (width=3, degree=5, partial round=56, full round=8). I'm not sure if my conclusion is correct.

Something like IntegratedCosetMds should work out of the box, although it's mainly designed for large matrices over small fields; I imagine naive multiplication with some hardcoded low-weight matrix could give better performance for BN254.

Thank you for your reply. I was wondering why there isn't an implementation of Poseidon over BN254 in Plonky3. Are there any challenges or difficulties in implementing Poseidon over BN254 in Plonky3?

Are you specifically referring to Poseidon1? There is https://github.com/Plonky3/Plonky3/blob/main/bn254-fr/src/poseidon2.rs for Poseidon2

Yes, I am referring to Poseidon1, and there is no MDS matrix implementation for Bn254-fr, which can be used in Poseidon1.


Report the correct print location in the console

Fixes https://github.com/Textualize/textual/issues/3237
I'm undecided about this. It doesn't feel quite right to special-case this, but on the other hand print is a form of logging that seems to work differently in Textual vs the normal logging facility (which seems to do its own dance to handle the call location, before it makes it to devtools).
This does correct the issue, this does ensure that print reports the location the same as any self.log call. So this is a commit made to solicit more detail on the design decisions in the core of Textual.

Throwing out a review request rather than just charging ahead with merging as this is a slightly hacky fix.

I think the way I've dealt with similar issues in the past, is to add a parameter for the offset in to the callstack.

That was going to be my initial approach too, but that meant changing the signature of StdoutRediector.write (albeit in a backward-compatible way), which felt a little heavy-handed for this one particular case. If we're happy with that I'll look to taking that approach instead; it should end up being easier to maintain.

Right, done. Note the change to the description of this PR. Also note that this does not fix https://github.com/Textualize/textual/issues/3237 but it does provide what's needed to fix it within Textual. Once this is live the fix will be as simple as:
diff --git a/src/textual/app.py b/src/textual/app.py
index 2991f51e..5634d8f6 100644
--- a/src/textual/app.py
+++ b/src/textual/app.py
@@ -1161,7 +1161,8 @@ class App(Generic[ReturnType], DOMNode):
             stderr: True if the print was to stderr, or False for stdout.
         """
         if self._devtools_redirector is not None:
-            self._devtools_redirector.write(text)
+            current_frame = inspect.currentframe()
+            self._devtools_redirector.write(text, current_frame.f_back if current_frame is not None else None)
         for target, (_stdout, _stderr) in self._capture_print.items():
             if (_stderr and stderr) or (_stdout and not stderr):
                 target.post_message(events.Print(text, stderr=stderr))

Tagging @darrenburns as just suggested by @willmcgugan


How can add mosaic or stacking?

Any recommendation what would be the best way to add capability to do a mosaic of 4 videos?
The orginial ffmpeg command would like this one
ffmpeg
-i input0.mp4 -i input1.mp4 -i input2.mp4 -i input3.mp4
-filter_complex
"[0:v][1:v]hstack=inputs=2[top];
[2:v][3:v]hstack=inputs=2[bottom];
[top][bottom]vstack=inputs=2[v]"
-map "[v]"
finalOutput.mp4

yes I would also like to know this. The existing examples are great. I just wish there were more of them
ffmpeg -i input0 -i input1 -i input2 -i input3 \
  -filter_complex "[0:v][1:v][2:v][3:v]xstack=inputs=4:layout=0_0|w0_0|0_h0|w0_h0[v]" \
  -map "[v]" output

oooo I think I figured it out just by monkey-on-the-typewriter-ing it
vout = ffmpeg.filter(
    [
        in0.video,
        in1.video,
        in0.video,
        in1.video,
    ],
    "xstack",
    inputs=4,
    layout="0_0|w0_0|0_h0|w0_h0",
)


[CARBONDATA-2593] Add an option 'carbon.insert.storage.level' to support configuring the storage level when insert into data with 'carbon.insert.persist.enable'='true'

When insert into data with 'carbon.insert.persist.enable'='true', the storage level of dataset is 'MEMORY_AND_DISK',
it should support configuring the storage level to correspond to different environment.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?  No

[ ] Any backward compatibility impacted?  No

[ ] Document update required?   No

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6334/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5285/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5172/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6335/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5173/

@ravipesala @jackylk please help to review, thanks.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6351/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5189/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6354/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5192/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5302/

LGTM


[Cluster Test] Some refactors and improvements for the cluster swarm code.

Motivation
This PR provides several small refactors and improvements for the cluster swarm code (to help first timers better understand the code). Namely, the PR:

Moves all the template files to a "template" directory (to match configs and fluent-bit files)
Avoids duplication in service spec and pod spec creation logic.
Extracts commonly used strings, file paths and binary paths to constants to make it easier to reason about and identify important components in cluster swarm.

Note: although the PR offers quite a few commits, you could probably just look at all commits in a single review as the changes are pretty small once flattened.
Also, if you don't feel the refactors are that useful, feel free to close the PR 😄
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
All tests seem to pass locally.
Related PRs
None.

I have mixed feeling about this one

I like commits that replace inline strings with constants 👍
I don't fully understand motivation for replacing inlined include_str with macro like FULLNODE_CONFIG. Can you explain benefit behind this?

Thanks, @andll! 😄
Regarding replacing "include_str(STRING_LITERAL)" with the macro, I was originally hoping to change STRING_LITERAL to be constants, so that we could easily see what template/config files were being loaded at compile time (rather than having to look throughout the file manually.. which is tedious.) Also, it helps prevent bugs, e.g., the JOB_TEMPLATE file is used twice, so it would be nice to have only a single definition of the template file name. Of course, the issue I faced is that we can't use const here because we use a STRING LITERAL so it doesn't work with the "include_str" call.
So it seems like I had two options:

Use a macro to help define these as constants equivalents (e.g., a macro name that maps to the file string).
Change the "include_str!" macro to something else that loads the file at runtime (rather than compile time).

I was unsure about taking option 2, as I'm not sure if the assumption can be made that the files are available at runtime. Hence why I took approach 1. Does that make sense?
If you feel that the macros are overkill, I can refactor the PR to avoid doing this. I also have mixed feelings about having to use a macro for this, so I don't feel super strongly.. 😕

@andll, any response on this? If not, I'm happy to close the PR (as it's only a refactor). But, in general, I think it leaves the code in a better position than it currently is.

@JoshLind I think my gut feeling is that macro replacing include str is overkill, something like includ_str!(file_name_macro!()) is probably more obvious
All other refactorings in this PR are very helpful, thank you!

Thanks @andll 😄

I think my gut feeling is that macro replacing include str is overkill, something like includ_str!(file_name_macro!()) is probably more obvious.

Sure, sounds good. I've done this. The only downside is of course that the macro definitions take up a few more lines when formatted.

Thanks, @andll 😄
/land


clamav: CVE-2015-2170 CVE-2015-2221 CVE-2015-2222 CVE-2015-2305 CVE-2015...

compiled but not tested. TEST first, merge then.
http://www.pro-linux.de/sicherheit/2/30366/mehrere-probleme-in-clam-antivirus.html

cc @Phreedom

I have not tested this but I am merging this now. This is a bugfix-only release so the potential of breaking things at runtime is low. If it still breaks we can revert, but having those security problems fixed has a high priority IMO.


PDS always displays 0.0.0 as version on startup

Problem
PDS always displays 0.0.0 as version on startup - even in released versions which should contain a version other than 0.0.0.
When looking into the MANIFEST.MF of pds-1.0.0.jar it looks like this:
Manifest-Version: 1.0
Implementation-Version: 0.0.0
Main-Class: org.springframework.boot.loader.JarLauncher
Start-Class: com.mercedesbenz.sechub.pds.ProductDelegationServerApplicat
 ion
Spring-Boot-Version: 2.7.11
...

Probably the Implementation-Version should be 1.0.0.
Please check.

I think this is now solved with #2625.
The reason was that the creation of the version data inside gradle-versioning was done too late and the version setup did always fetch the just initialized version data -> always 0.0.0 ...


fix: reading deckfile info

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 21 (38.1%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 65.741%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

getdeck/fetch/fetch.py
7
10
70.0%

getdeck/fetch/utils.py
1
11
9.09%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1349

Relevant Lines:
2052

💛  - Coveralls


Allow extra css_class properties for TabHolder and Tab elements

Specifically done to allow http://openam.github.io/bootstrap-responsive-tabs/ to work, some generalization could allow for the same features.

I'm going to close this as Out of Scope for the moment. Happy to consider documented, tested pull requests. We may have capacity to reconsider in the future.


YARN-1865

https://issues.apache.org/jira/browse/YARN-1865
Could not check the Windows unit tests

check Windows command length

Can one of the admins verify this patch?


Update pull_request_template.md

Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

I am not sure if I am supposed to approve this, but it looks good to me - very simple.
Also note that the traceability check is failing. To make it pass, this PR would need a GUS work item (WI) number in the PR title. You can create a new WI for the task (or you can technically reuse an existing one 😛)


How to render from string?

Hello.
How to render from string?
index.js
res.render('index', {"hello": "world"});

index.ejs
<%- hello %>

We need so:
var hello = '<%- hello %>';
res.render(hello, {"hello": "world"});

It's possible?

Depending on the case, typically you would just use the engine directly. For example:
var hello = '<%- hello %>';
res.send(ejs.render(tmpl, {"hello": "world"}));

@dougwilson This is exactly what I need. Thank you.

No problem :)


Suggestion/Question: Wouldn't be better to use ioredis instead of redis package?

ioredis seem to perform far better then redis
(https://github.com/luin/ioredis)

I am using ioredis with this package.   There was a small monkey-patch I had to do to ioredis to make it work.  ioredis returns buffers via pmessageBuffer instead of pmessage.  The snippet below is a hack I used on the sub instance to make work with socket.io-redis.  The return_buffers and detect_buffers flags are not needed.
While more direct support of ioredis (which is much more current and actively maintainted) would be nice, this seems to be sufficient for my applicaiton's needs.
// WARNING: Use of this will prevent message and pmessage handlers from being unregistered
// since our stub method will be registered instead...
var oldOn = redisClient.on;
redisClient.on = function(event, oldListener) {
    var self = this;
    switch (event) {
        case "pmessage":
            return oldOn("pmessageBuffer", function() {
                if (arguments.length > 1) arguments[1] = arguments[1].toString();
                return oldListener.apply(self, arguments);
            });

        case "message":
            return oldOn("messageBuffer", function() {
                if (arguments.length) arguments[0] = arguments[0].toString();
                return oldListener.apply(self, arguments);
            });

        default: return oldOn.apply(self, oldListener);
    }
}

Any Update ?

Closed by https://github.com/socketio/socket.io-redis/pull/95.


uib-tab + ng-repeat + fn || defer == very nasty results

Hi! Sorry, I couldn't find a better way of giving this problem a title. Well, since I use 'SomeCtrl as ctrl' to my definitions and almost everything (in the system I'm currently working) comes from an asynchronous backend, I tend to use functions to return promises that can be later used. So, I ended up using uib-tabset with the uib-tab element using ng-repeat for a given function. If returning a promise, everything goes dark and I have to kill the tab (or the browser). If I return an array from the function, it calls $digest 10 times and breaks (at least it doesn't kill my tab). If I create a simple array, everything works as expected.

Angular versions 1.4.8 and 1.5.0 (plunkr using 1.4.8);
UI Bootstrap 1.1.2;
Plnkr: http://plnkr.co/edit/f7dVCScn6DZWnKpyrnu6

NOTE: In this plunker, I have commented out (in the HTML and JS) the bug, so no one will get its browser dead (in the worst scenario). Just, feel free to modify and call a function inside ng-repeat.
Resuming:

<uib-tab ng-repeat="tab in ctrl.getTabs()" heading="{{tab.title}}" active="tab.active" disabled="tab.disabled"> breaks if my controller returns an array;
<uib-tab ng-repeat="tab in ctrl.getTabs()" heading="{{tab.title}}" active="tab.active" disabled="tab.disabled"> goes nuts if my controller returns a promise; and
 <uib-tab ng-repeat="tab in ctrl.myTabs" heading="{{tab.title}}" active="tab.active" disabled="tab.disabled"> works great.

Thanks a lot! :)

It should be noted that the tab component has changed significantly in master for the upcoming 1.2.0 release, so I'm not sure if this is necessarily an issue.

Also one should never use a function with ng-repeat. That is a big nono.

Hmm, I just made a workaround. But OK, I didn't knew that functions and ng-repeat are not a good couple. Can you just tell me why, so I can make things "right" ?

@vltr, I fully respect the asynchronous nature of your application, but I'm afraid this just isn't a use-case that we are going to be able to support.  Adding the support of promises to the API would be a huge undertaking and open a massive can of worms for us maintenance-wise, e.g., where would we stop with the support in the rest of the API?  Remember that we're all volunteers doing this in our spare time.

Take a look at the ngRepeat documentation - note the section talking about $watchCollection.
Going to close this as a usage issue.

@icfantv thanks for your feedback. I fully respect your work and mean no trouble. I was just trying to help :)
@wesleycho thanks also! I just read the mentioned section, it does makes sense. I'll go with what's working ;)
Best regards!


packager debugger improvement: support dependencies "file:../"

[enviornment]
react-antive 0.42.3
[question]
If we got dependencies like below:
…… "dependencies": {     ……     "react-native-gifted-chat": "file:../",     ……   }, ……
A example link: file:../
When debug js remotely. The js file in path "file:../" will not be loaded into the debugger viewer.

The problem is invalid. Cause the config file:../ is not working.


Implement generic Simd algorithms Part II

Minimum
Maximum
Equals

This seems can be closed if we all agree with #127

This seems can be closed if we all agree with #127

Part 1: #114

Part 1: #114


libguestfs with appliance by default

Description of changes
This removes the package 'libguestfs-with-appliance', and adds the package 'libguestfsMinimal' without the appliance.
This makes nixpkgs packages use the appliance by default,
which fixes the user experienc of having the "no appliance" error
message in certain cases, for example the 'guestmount' command, and
running 'diffoscope' on disk images.
I'm proposing this because I just kept running into #37540-style issues, often without an easy way out (e.g. diffoscope using the guestfs Python package).
This also re-enables building the libguestfs with appliance on Hydra.
Note: the appliance was disabled by default in #56448 (cc @grahamc if you think this PR is acceptable), and disabled on Hydra a long time ago in ac52817bd90881acf2d27ffca834c78b27551601. We should test if Hydra is fine with it now, but I'm not sure how.
cc @offlinehacker
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

13 packages built:

diffoscope
diffoscope.dist
diffoscope.man
diffoscopeMinimal
diffoscopeMinimal.dist
diffoscopeMinimal.man
libguestfs
libguestfsMinimal
python310Packages.guestfs
python310Packages.guestfs.dist
python311Packages.guestfs
python311Packages.guestfs.dist
vagrant

Add a :+1: reaction to pull requests you find important.

@wegank good catch! Do you know if it's just our package, or if the upstream code really isn't compatible with other architectures?

I am not aware of how other distros do, but our own libguestfs-appliance simply fetches and extracts the prebuilt appliance from upstream (which is x86).

I'll work on building the appliance from source, then. I think I'm close to succeeding, but there's still a weird issue where augeas.c can't find a libxml2 include…

@minijackson I am also interested in supermin support. Have you a branch/something I could look at and try to fix ?

@Et7f3 I've pushed what I have in the guestfs-default-appliance-wip branch of my fork:
https://github.com/minijackson/nixpkgs/tree/guestfs-default-appliance-wip
But it's more complicated than I initially thought. Building the appliance is about building a small image of a given Linux distribution, with some tools installed.
How supermin does it is by using the host's package manager to create a small rootfs, and install extra packages in it. The call to the host's package manager needs internet connection, and assumes the host is configured with repos and such.
That doesn't work for us. I think the best we could do would be to create our own small NixOS appliance with the same tools installed, and the same init script.
For more info in the libguestfs source code:

m4/guestfs-appliance.m4 search for the --with-distro option
appliance/Makefile.am search for:

the HAVE_RPM conditional
the guestfsd.deps target

appliance/packagelist.in
appliance/make.sh.in (the script that builds the appliance)
appliance/init (the init script for the appliance)

On another note, I don't think supermin can work on NixOS without either upstream support for NixOS, or using something like Distrobox. But both would only work in the Nix sandbox by using a fixed-output derivation and fixed repos (like CentOS/Rocky's vault repos), or by using impure derivations.
Thanks for reaching out, I'm quite busy these days, but still open for discussion if you're still interested.


Radio field not selected

Ok, so I am trying to test this out and I am having issue with radio button not being selected when the form is re-loaded. Is there a specific way the radio field is stored on the server side?

Hey there,
This might help: https://github.com/dobtco/formrenderer-base/blob/eda83e794cb3e97bd1c55edf421437df4799572c/test/fixtures/internal.js#L44-L50


Fixing a broken example dag, example_skip_dag.py

This is a fix for https://github.com/airbnb/airflow/issues/1313 that was introduced in https://github.com/airbnb/airflow/pull/1292

Coverage decreased (-0.03%) to 67.426% when pulling b5f8ab5ca197da2acb8e40a70315fe4c50f1069b on r39132:master into 4865ee66ba6d53e4a0b809ccbb60a65b5ede1915 on airbnb:master.


elementexplorer won't work if Chrome Dev Tools is open

When using the elementexplorer typos and other simple errors will cause the following:
There was a webdriver error: UnknownError unknown error: Runtime.evaluate threw exception: TypeError: Cannot call method 'click' of null
Any element find command after this will result in the same error. This results in having to restart the explorer and lose any state you were in when creating the selections. Very frustrating.

Unfortunately, this is a design issue in chromedriver. WebDriver is using the same interface that devtools uses to control the browser.
Thankfully, because it's the same interface, any information you could get from devtools you can also get with WebDriver.


Use changedTouches[0] if present in pointer

So I was dragging along and d3.pointer was working for me on desktop Chrome and Safari, but on mobile Safari, clientX and clientY were coming through undefined, leading d3.pointer(event, this) to return [NaN, NaN]. But it works with the old d3.mouse(this) approach, where mouse.js has:
var event = sourceEvent();
if (event.changedTouches) event = event.changedTouches[0];

But now in pointer.js, it's just:
event = sourceEvent(event);

My example works if I add back the check for changedTouches. But maybe there was a good reason for getting rid of it, I don't know.
Examples:

d3 v5 (working)
d3 v6 (broken)
d3 v6 (fixed)

See the discussion in https://github.com/d3/d3-selection/pull/253

Ah, I should've searched. Inspires me to add proper multitouch to the thing I was trying to do! 😅


Remainder and next character ignored if no spaces are set in javascript

Describe the bug
I just 'carboned' this code: let theta = (i%360)*angleSize; and the result was let theta = (i60)*angleSize; the % was stripped as was the following character
To Reproduce
Steps to reproduce the behavior:

Go to '…'
Click on '…'
See error

Expected behavior
A clear and concise description of what you expected to happen.
I would expect this not to be stripped - I mean I'm happy for you to come back and say 'put a space in it' but I wasn't expecting that.
If there is a fix, let me know - I'm happy to help 👍
Screenshots
If applicable, add screenshots to help explain your problem.
My text editor:

Carbon:

Info (please complete the following information):

OS [e.g. macOS, Linux, Windows, iOS]: macOS Big Sur
Browser [e.g. Chrome, Safari, Firefox]: Chrome
Carbon URL [e.g. carbon.now.sh?bg=pink]: https://carbon.now.sh/?bg=rgba(216%2C211%2C226%2C1)&t=one-dark&wt=bw&l=javascript&ds=true&dsyoff=18px&dsblur=45px&wc=true&wa=true&pv=56px&ph=56px&ln=false&fl=1&fm=Space+Mono&fs=15px&lh=133%25&si=false&es=2x&wm=false&code=function%2520createSpiralCoords(x%252C%2520y%252C%2520itemCount%2520%253D%252060%252C%2520radiusInc%2520%253D%252010%252C%2520angleSize%2520%253D%252010)%2520%257B%250A%250A%2520%2520let%2520coords%2520%253D%2520new%2520Map()%253B%250A%250A%2520%2520for%2520(let%2520i%2520%253D%25200%253B%2520i%2520%253C%2520itemCount%253B%2520i%252B%252B)%2520%257B%250A%250A%2520%2520%2520%2520%252F%252F%2520set%2520angle%250A%2520%2520%2520%2520let%2520theta%2520%253D%2520(i60)angleSize%253B%250A%2520%2520%2520%2520%252F%252F%2520convert%2520to%2520radians%250A%2520%2520%2520%2520theta%2520%253D%2520theta%28Math.PI%252F180%29%253B%250A%250A%2520%2520%2520%2520%252F%252F%2520get%2520radius%250A%2520%2520%2520%2520const%2520r%2520%253D%2520iradiusInc%253B%250A%250A%2520%2520%2520%2520const%2520cx%2520%253D%2520%28r%2520%2520Math.cos%28theta%29%29%2520%252B%2520x%253B%250A%2520%2520%2520%2520const%2520cy%2520%253D%2520%28r%2520*%2520Math.sin%28theta%29%29%2520%252B%2520y%253B%250A%250A%2520%2520%2520%2520coords.set%28i%252C%2520%257Bx%253A%2520cx%252C%2520y%253A%2520cy%252C%2520angle%253A%2520theta%252C%2520radius%253A%2520r%257D%29%250A%2520%2520%257D%250A%2520%2520return%2520coords%253B%250A%250A%257D%253B

This was the whole function I sent to carbon from Sublime Text

Code snippet

function createSpiralCoords(x, y, itemCount = 60, radiusInc = 10, angleSize = 10) {
let coords = new Map();

for (let i = 0; i < itemCount; i++) {

	// set angle
	let theta = (i%360)*angleSize;
	// convert to radians
	theta = theta*(Math.PI/180);

	// get radius
	const r = i*radiusInc;

	const cx = (r * Math.cos(theta)) + x;
	const cy = (r * Math.sin(theta)) + y;

	coords.set(i, {x: cx, y: cy, angle: theta, radius: r})
}
return coords;

};

Hey @Rumyra,
I am a little confused by the issue 🙂 I just went to the link above, added a % in the spot you said it was missing, and then clicked export and got this image:

Here is a link to the source: https://carbon.now.sh/?bg=rgba(216%2C211%2C226%2C1)&t=one-dark&wt=bw&l=javascript&ds=true&dsyoff=18px&dsblur=45px&wc=true&wa=true&pv=56px&ph=56px&ln=false&fl=1&fm=Space+Mono&fs=15px&lh=133%25&si=false&es=2x&wm=false&code=function%2520createSpiralCoords(x%252C%2520y%252C%2520itemCount%2520%253D%252060%252C%2520radiusInc%2520%253D%252010%252C%2520angleSize%2520%253D%252010)%2520%257B%250A%250A%2520%2520let%2520coords%2520%253D%2520new%2520Map()%253B%250A%250A%2520%2520for%2520(let%2520i%2520%253D%25200%253B%2520i%2520%253C%2520itemCount%253B%2520i%252B%252B)%2520%257B%250A%250A%2520%2520%2520%2520%252F%252F%2520set%2520angle%250A%2520%2520%2520%2520let%2520theta%2520%253D%2520(i%252560)angleSize%253B%250A%2520%2520%2520%2520%252F%252F%2520convert%2520to%2520radians%250A%2520%2520%2520%2520theta%2520%253D%2520theta%28Math.PI%252F180%29%253B%250A%250A%2520%2520%2520%2520%252F%252F%2520get%2520radius%250A%2520%2520%2520%2520const%2520r%2520%253D%2520iradiusInc%253B%250A%250A%2520%2520%2520%2520const%2520cx%2520%253D%2520%28r%2520%2520Math.cos%28theta%29%29%2520%252B%2520x%253B%250A%2520%2520%2520%2520const%2520cy%2520%253D%2520%28r%2520*%2520Math.sin%28theta%29%29%2520%252B%2520y%253B%250A%250A%2520%2520%2520%2520coords.set%28i%252C%2520%257Bx%253A%2520cx%252C%2520y%253A%2520cy%252C%2520angle%253A%2520theta%252C%2520radius%253A%2520r%257D%29%250A%2520%2520%257D%250A%2520%2520return%2520coords%253B%250A%250A%257D%253B

So something is stripping that % from Sublime to the browser - any ideas what?


Partial draft of BLS-12-381 specification

For some numbers here related to the G1 vs. G2 discussion:
In our benchmarks for our 12-381 implementation using CGo here: go-bls, we saw:
2018/11/19 12:04:13 Initialize Pairing took 0.000959 seconds to complete
2018/11/19 12:04:13 HashAndMapToG2 took 0.000298 seconds to complete

on average when using Signatures in G1 and Public Keys in G2.

@schaeff: can you check this, given you implemented something similar with https://github.com/ewasm/ethereum-bls12.rs ?


WIP: feat: support for NET Core 2.0

Now NsqSharp targets NET Framework ~4.5~ 4.6.1+ and NET Standard 2.0
New  project NsqSharp.WindowService targeting NET ~4.5.1~ 4.6.1 to keep the BusService static class with support for Window Service, console app and host in IIS
Tests in a NET Core library
All examples reference NsqSharp (net ~4.5~ 4.6.1)

To do:

[ ] Fix CI msbuild issue (Appveyor)
[ ] Generate breaking change version
[ ] Check assemblies signing
[ ] Review Nuget publish
[ ] Rename NsqSharp.WindowService?
[ ] Library for starting up the bus in for NET Core (hosted in Kestrel)?
[ ] Create at least one working NET Core example

Thanks @alex-pollan, I agree .NET Standard 2.0 is the way to go.
Since the Windows Service code will be pulled into another package now is a good time to look again at how that works. I'll do a major version bump of NsqSharp to account for the breaking change.

@alex-pollan I'm also okay dropping support for any .NET less than 4.6.1 per the compatibility matrix https://docs.microsoft.com/en-us/dotnet/standard/net-standard. Users needing earlier .NET support can use 0.5.4 which has been battle tested in Production for quite some time.

@alex-pollan I'm also okay dropping support for any .NET less than 4.6.1 per the compatibility matrix https://docs.microsoft.com/en-us/dotnet/standard/net-standard. Users needing earlier .NET support can use 0.5.4 which has been battle tested in Production for quite some time.

Done, now it only supports 4.6.1+

@judwhite addressed your comments

@alex-pollan @judwhite any updates on this?


Use optional chaining to prevent button reference error.

This is a logged bug that appears to occur after sending a gesture to the simulator and then expand/collapsing the accelerometer module panel. This causes a re-render and the gesture button ref can be undefined. We should also not change the focus if the user's last action was to expand/collapse the module, so this seems a reasonable fix.

We can definitely merge this, but perhaps we shouldn't disable the button at all? E.g. a quick enter, tab is quite confusing. I'm assuming disabling the button is what's preventing focus staying on it. Feels like it needs some kind of reaction though.