Fix unused_mut warning

I see this warning:
warning: variable does not need to be mutable
   --> src\wrapper\strings.rs:112:13
    |
112 |         let mut robj = Strings::alloc_vector(STRSXP, len);
    |             ----^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Do you mean this should actually require mut? If so, I just close this pull request.

Yes!
We create a vector here that we fill out. Usually, you need a &mut to do
so.
But GetSexp only has a get(&self), while it should in fact also carry a
get_mut(&mut self),
that is then fed into SET_STRING_ELT. This is how we unsafely pass around
a pointer,
but ensure exclusive-access is maintained properly.
I've tried a few times to add this, and now that I'm working on the
OwnedRobj/PermanentRobj/RawRobj PR, I might figure out how to add
this properly.
On Fri, Oct 6, 2023 at 3:51 PM Hiroaki Yutani @.***>
wrote:

Do you mean this should actually require mut? If so, I just close this
pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/641#issuecomment-1750718043, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDVSBHCDVN4OBR56O3BTTX6AEHTAVCNFSM6AAAAAA5V3DUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQG4YTQMBUGM
.
You are receiving this because you commented.Message ID:
@.***>

Yes!
We create a vector here that we fill out. Usually, you need a &mut to do
so.
But GetSexp only has a get(&self), while it should in fact also carry a
get_mut(&mut self),
that is then fed into SET_STRING_ELT. This is how we unsafely pass around
a pointer,
but ensure exclusive-access is maintained properly.
I've tried a few times to add this, and now that I'm working on the
OwnedRobj/PermanentRobj/RawRobj PR, I might figure out how to add
this properly.

Okay, I don't feel it really matters whether this mut is left or not, but let's close now. Thanks for sharing.


hvac-schedule not working

Describe the bug
Trying with hvac-schedule to start warming of the car.
To Reproduce
use inject node with msg.topic set to "hvac-schedule"
Expected behavior
Warmer car :)
Version (please complete the following information):
1.4.2
docker container nodered/node-red:latest-16
Additional context
message: "{"errors":[{"status":"Not Implemented","code":"501","title":"Not supported Feature","detail":"This feature is not technically supported by this gateway"}]}"

hi @mapa0402
not all api commands work with all cars and for example for me the hvac is since one year only working if the car is connected to a wallbox.
Does it work for you from the renault app?

hi, yes it works with the official renault app, and when I use the open-source Z.E. Services. That app seems to use "hvac-start" and maybe other services than this library?
https://github.com/chrisstaite/ZEServices/blob/master/zecommon/src/main/java/com/yourdreamnet/zecommon/api/Vehicle.kt

@mapa040you need to use set-hvac-state see
https://github.com/node-red-contrib/node-red-contrib-renault-ze/blob/main/src/renault-ze.ts#L67C33-L67C59
with a temperature so just take 21 as temp

@mapa040you need to use set-hvac-state see https://github.com/node-red-contrib/node-red-contrib-renault-ze/blob/main/src/renault-ze.ts#L67C33-L67C59 with a temperature so just take 21 as temp

that seems to do the task, thank you!


Upgrade to syn 1.0

With syn 1.0 release, a upgrade would be great.

Thanks for the suggestion! I'm happy to accept a PR for this.


RateLimiting implementation

Fixes #370
Signed-off-by: Steve Sloka<EMAIL_ADDRESS>

@zxvdr Thank you for your contribution, however this appears to be #873 pushed as your own branch. I'm going to close this as its probably an error. If you would like to discuss rate limiting please do so on #873 or #843

@davecheney, it wasn't an error. I asked @stevesloka the status of #873 and offered to help get it over the line. He suggested opening a new PR. This is #873 rebased with most of the previous review comments addressed. Apologies for omitting these details earlier.


Docs request: Docker hub image

Is your feature request related to a problem? Please describe.

Trying to directly run LocalAI's Docker container without Docker compose fails, because obviously this is the wrong base image:
> docker run --rm -p 8080:8080 quay.io/go-skynet/local-ai:latest
Unable to find image 'quay.io/go-skynet/local-ai:latest' locally
latest: Pulling from go-skynet/local-ai
docker: no matching manifest for linux/arm64/v8 in the manifest list entries.

Describe the solution you'd like

Can we document how to docker run the LocalAI container, without locally building it?
Describe alternatives you've considered

I don't want to have to clone the LocalAI repo and then run docker compose up.  I would rather just run docker run straight away.
Additional context

running docker compose with the yaml file does what you want docker run to do @jamesbraza

I am trying to avoid building the Docker container myself.  Running docker compose up will also perform a local build step.
I am wondering, is there a Docker hub image already in existence?  How can I avoid the build step on my Mac?

@jamesbraza did you check https://localai.io/basics/getting_started/#docker ? maybe that should go upper as probably it's an easy miss

Thanks for sharing that, following the linked page's instructions:
> docker compose down
> docker system prune --all --force
> docker run -p 8080:8080 -v $PWD/models:/models -ti --rm quay.io/go-skynet/local-ai:latest --models-path /models
Unable to find image 'quay.io/go-skynet/local-ai:latest' locally
latest: Pulling from go-skynet/local-ai
docker: no matching manifest for linux/arm64/v8 in the manifest list entries.

The moral of the story is, LocalAI's Docker can't be run without first locally building.
I am wondering, is there some way I can docker pull a pre-built image from Docker Hub? Something like ollama/ollama on Docker Hub, except for LocalAI

Ah, and I see https://github.com/mudler/LocalAI/issues/1249 requests pre-built containers with ARM support
I think we can make that Docker docs section more findable, perhaps promoting it to its own How To page. I will leave this open until then

@jamesbraza you are super welcome to add a how to for that (or just have one made with a outline for me to edit) <3

I see the docs have changed around since I last was here, like the new changes! I opened https://github.com/mudler/LocalAI/pull/1614 for this.


Adds support for camp-style dsl in TOSCA blueprints

Looks good. Would it take much effort to add test cases?

Thanks a lot @nakomis, it will be ver useful for ChatApplication example.
I have created #16 which is based on this commit for testing ChatApplication. I have adapted the DSL management for supporting DSLs inside of a Map of properties. @nakomis, I do not want to interfere, so if it was necessary, #16 would be closed.

I will merge this since several other pull requests are waiting on it.


Merged DbConnectionClosed, DbConnectionFactory, SqlAuthenticationProviderManager

Contributes to #1261.
This merges the three classes above.  DbConnectionFactory has a few references to the metric reporting processes (which are different between .NET Core and Framework) and I've hidden these behind conditional compilation.

@edwardneal Can you address the conflicts, please?

Thanks @DavoudEshtehari, I've addressed the conflicts. CI is effectively done - there are a few test failures, which seem to be unrelated.

One more conflict after merging your PR. ;)

Thanks - re-merged. The test failures remain unrelated


Ability to manually restart a shard

Reconnecting a specific shard (with optional resuming). This is to trigger the ready event and get a clean state for the shard. In the design of a standalone gateway which send events to a message queue, there could be rare cases when there are too many events in a queue. Instead of processing all of the events, retrieving a clean state directly by reconnecting is more efficient.
Issue extracted from #615.

Done in next, Twilight 0.14


Fortnite removed Hyperion/Byfron Anti-Cheat

Game Title
Fortnite
Status of the Anti-Cheat
🚫 Denied
Tinkering Steps
Fortnite used to have FortniteLoader-Win64-Shipping.dll (Hyperion/Byfron) which decrypted FortniteClient-Win64-Shipping.exe, FortniteClient-Win64-Shipping.exe is now able to load in IDA and not encrypted.
Proof of Mention
https://i.imgur.com/vxzsAqQ.png

Wow I wonder if that's actually intended

I recorded what exactly happens in creative mode and uploaded it to Youtube: https://youtu.be/3ccDbD3NGTg
They had an error pop up every time you opened up Fortnite and it would crash your game soon after in the lobby yesterday, but now it has been fixed!
(https://user-images.githubusercontent.com/43681827/199487810-66bb5d97-f522-4241-b0e7-bdc53a4794a1.png)
There's only like 1 glitch i can see and that is that the intro video tries to play, but it can't so it just shows a black screen.
I really hope that Epic Games will make Fortnite playable on Linux.

I HAVE to try this, what if they actually enabled support

edit: got kicked on wine staging 7.20

We did not had success while using 7.20, but rather on the latest builds of Proton-GE (based on 7.19) instead.

I tried it with proton-ge 7-38 and now it's not working at all, let me try deleting the prefix

This error pops up again now for some odd reason? (https://user-images.githubusercontent.com/43681827/199639804-59ebdbdd-1002-4e27-80af-ed383ee6dc1a.png)
And now it crashes in the lobby before i can even do anything.

:(

Game is running for me under ProtonGE 7-41 launched with the Heroic launcher, only problem being the game isn't stable and will crash often, that being said anti-cheat seems to be working.

Game is running for me under ProtonGE 7-41 launched with the Heroic launcher, only problem being the game isn't stable and will crash often, that being said anti-cheat seems to be working.

did you play through a whole match or at least 5 mins of one?

Do they ban you if they detect you are running the game on Linux?

Do they ban you if they detect you are running the game on Linux?

I haven't been banned while I was experimenting, but they easily have the power to

I got into a game, jumped out of the battle bus, and the game window froze before closing with no mention of any anti-cheat error.

did you play through a whole match or at least 10 mins of one?
this game has been "running" for me like that (unstable and lots of crashing) since 2021, I used lutris wine 6.13 back then to run the game, in fact my friend was on and I joined his lobby and we chatted for like a few mins before telling him that I can't play the game due to it crashing bc of anti cheat

I got into a game, jumped out of the battle bus, and the game window froze before closing with no mention of any anti-cheat error.

that happens because of anti-cheat

Tried running the game both via Lutris and Heroic Games, on both cases the game runs fine (other than some lag, but that's probably the shaders being cached) but it crashes a minute or two after jumping out of the bus. Like @Etaash-mathamsetty said its 50/50, it either crashes directly or it gives you the anti-cheat error then crashes
Tried both with ProtonGE 7.42 and Proton 7.22, also tried to use Steam's EAC Runtime with PROTON_EAC_RUNTIME but unfortunately i've got the same result.

EAC will now trigger a re-validation of game files after the boostrapper fails to load the Linux module and loads the NullClient.
You can get around the first check by simply clicking anywhere on the screen outside the notifcation, but the second time the game is force closed for the re-validation. If you trick the game into skipping the check, the game runs no problem! At least I was able to run around in the LEGO world, build and smash stuff without any issues. You are eventually kicked for the lack of EAC.
Any game deploying EAC without the Linux module enabled on the EAC Developer Portal is just discriminating, which is very sad in this age of inclusion.

Fortnite anti-tamper system always validated critical game files, including game launcher, game executable and anti-cheat loader executable files stored on disk, irregardless of whether anti-cheat is actually working. It is a system that works independently of anti-cheat one and is also activated alongside it.
The message about the need for the game to be restarted is displayed when one of the start-up checks made by the anti-tamper system has failed.


Fix .env related updates during multiroot test phase by using unique files for .env updates.

For #4468 (originally written as a fix within PR #4460).

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] ~Has a news entry file (remember to thank yourself!)~
[x] ~Has sufficient logging.~
[x] ~Has telemetry for enhancements.~
[x] Unit tests & system/integration tests are added/updated
[x] ~Test plan is updated as appropriate~
[x] ~package-lock.json has been regenerated by running npm install (if dependencies have changed)~

From #4468:

One hypothesis is that the tests are failing and being re-run, exacerbating the trouble with async tests accessing the same file.

Knocked that hypothesis out.


Timeout has reached

Geode

[X] I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform
Windows
Geode Version
v3.8.1
Just says "timeout has reached" + not checking for updates and mods that require internet or idk what are they called like (example : the demonlist ,that uses aredl) just not even loading

either the servers are bad or the servers are bad


Extension and compatibility issues

Some Create addons require their own CraftTweaker addons. For example Destroy. It has its own FluidIngredient class, which is required for its recipes to work. I was thinking of extending the CTFluidIngredient, but its constructor is package-private.
Mixin would help, but the only way of attaching a mixin would be a static jar dependency, so it'd be nice to have CreateTweaker uploaded to a repository

Mixin would help, but the only way of attaching a mixin would be a static jar dependency, so it'd be nice to have CreateTweaker uploaded to a repository

CreateTweaker is already hosted on my maven https://maven.blamejared.com/com/blamejared/createtweaker/


Update main.rs to change .about to .help for rust-1.58.1 compiling

See issue #7

I think that is it clap to new version, not hard-coding version in main.rs and revert the version in Cargo.toml

I think that is it clap to new version, not hard-coding version in main.rs and revert the version in Cargo.toml

Yeah that's it thank you. Although just fyi i don't think the new rust version but just breaking changes in clap, not having it pinned to a specific version and most importantly not having the Cargo.lock file in the repo was the problem.


Ad-hoc enable and disable completions

Sometimes I want to disable some sources  in a particular buffer as they get on the way.
I have come up with the following:
      function cmp_sources_list(arglead, _, _)
        -- the API does not allow for the retrieval of sources from cmdline
       -- I am just using the global sources
        local global_sources = require'cmp.config'.global.sources
       -- ideally I would like to get only the sources active in the current buffer
       -- but the following does not work
       -- require'cmp'.get_config().sources
        local out = {}
        for i = 1,#global_sources do
          if global_sources[i].name:find("^" .. arglead) ~= nil then
           out[#out + 1] = global_sources[i].name
          end
        end
        return out
      end

      function disable_cmp_source(name)
          local current_sources = cmp.get_config().sources
          local new_sources = {}
          for i = 1,#current_sources do
            if current_sources[i].name ~= name then
              new_sources[i] = current_sources[i]
            end
          end
          cmp.setup.buffer({sources = new_sources})
      end

      function enable_cmp_source(name)
          local global_sources = require'cmp.config'.global.sources
          local new_sources = cmp.get_config().sources
          for i = 1,#global_sources do
            if global_sources[i].name == name then
              new_sources[#new_sources+1] = global_sources[i]
            end
          end
          cmp.setup.buffer({sources = new_sources})
      end

      vim.cmd [[ command! -nargs=1 -complete=customlist,v:lua.cmp_sources_list CmpDisable lua disable_cmp_source(<f-args>) ]]
      vim.cmd [[ command! -nargs=1 -complete=customlist,v:lua.cmp_sources_list CmpEnable lua enable_cmp_source(<f-args>) ]]

My issue is with regards the completion list generated by cmp_sources_list.
When issuing the command CmpDisable I would like to get the sources of the current buffer auto-completed. However using require'cmp'.get_config().sources does not work. I suspect that this function calls config.get which when run from the cmdline tries to get the command line completions (lines 94 to 109) which is not what I intended.

The get all of registered source is not provided as public api. But you can use internal variable.
See require('cmp').core.sources.


Fails to access the last field in a data class

with the following exception:
Exception in thread "main" java.lang.IllegalStateException: it.accessor must not be null
	at org.litote.kmongo.jackson.JacksonClassMappingTypeService.getPath(JacksonClassMappingTypeService.kt:216)
	at org.litote.kmongo.service.ClassMappingType.getPath(ClassMappingType.kt)
	at org.litote.kmongo.PropertiesKt.path(Properties.kt:34)
	at org.litote.kmongo.FiltersKt.eq(Filters.kt:37)

Code:
findOne(Account::isPatreon eq true)
Data class:
data class Account(
        var email: String,
        var subscriptionEnds: Long,
        val servers: MutableList<Long> = mutableListOf(),
        var isPatreon: Boolean
)

Thanks for reporting. The error comes from the "isX": Boolean syntax.
Workaround: rename var isPatreon: Boolean into var patreon:Boolean
Fixed now in 3.8.1-SNAPSHOT and in 3.8.1 next week


meld: 3.20.0 -> 3.20.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/meld/versions.
meta.description for meld is: '"Visual diff and merge tool"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.20.1 with grep in /nix/store/y06j3chy4cjajk7bndribcqis7g9dbpn-meld-3.20.1
directory tree listing: https://gist.github.com/2d505b742f747735537f26f47d52d2da
du listing: https://gist.github.com/83a87168afede87d908f13c4996e0596

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)
3 package rebuild(s)
3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
gnome3.meld
meld
rabbitvcs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y06j3chy4cjajk7bndribcqis7g9dbpn-meld-3.20.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A meld https://github.com/r-ryantm/nixpkgs/archive/c7990f8add96148ee061905b12d165ca9ed455b0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y06j3chy4cjajk7bndribcqis7g9dbpn-meld-3.20.1
ls -la /nix/store/y06j3chy4cjajk7bndribcqis7g9dbpn-meld-3.20.1/bin

cc @jtojnar @mimadrid for testing.

This will conflict with https://github.com/NixOS/nixpkgs/commit/b22b5a2874a98b37425d2b4846ef47df69ce0f45 on staging.

Reverted in 566d4d934a6d557e5695667156032c752bee78f4

Oops, sorry!

Sorry, I should have closed this sooner with the other r-ryantm PRs. I somehow missed this one.


AzCopy unknown command /source error

AzCopy /Source:https://sourceaccount.blob.core.windows.net/mycontainer1
/Dest:https://destaccount.blob.core.windows.net/mycontainer2
/SourceKey:key1 /DestKey:key2 /S
After using this script to migrate data from one container to another its shows an error:
unknown command "/source:https://karmsa.blob.core.windows.net/newcnt" for "azcopy"
while rest of the commands(copy, sync) are working fine.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94b4c16f-e4ec-d093-8435-f1c4252b4612
Version Independent ID: b56c07db-b3d2-e20f-57f6-fa90546af418
Content: Azure Storage migration FAQ
Content Source: articles/storage/common/storage-migration-faq.md
Service: storage
Sub-service: common
GitHub Login: @genlin
Microsoft Alias: genli

@amitpoonia8142  Please use the latest version of Azcopy which have a different syntax: https://github.com/Azure/azure-storage-azcopy

@Adam-Smith-MSFT  I  am using version 10.3.1. Can you please share the syntax.

Sure, below is an example:
 azcopy cp "https://[srcaccount].blob.core.windows.net/[container]/[path/to/blob]?[SAS]" "https://[destaccount].blob.core.windows.net/[container]/[path/to/blob]?[SAS]"
You can view all examples by typing the following command in cmd, where your azcopy.exe is located: azcopy copy -h , it will provide you with several examples of what is supported. Let me know if this resolves your question to close the case.
Thanks,
Adam

I got it @Adam-Smith-MSFT , you can close the case.
Thanks,
Amit

Might I recommend that attention is given to this link: https://docs.microsoft.com/en-us/microsoft-365/compliance/importing-pst-files-to-office-365#BKMK_NetworkUpload.  The instructions and the version of the AzCopy tool that are linked from these instructions do not align.  E.g. instructions say you should use /Source and /Dest parameters when in actuality you need to use the cp command.

@amitpoonia8142 Please use the latest version of Azcopy which have a different syntax: https://github.com/Azure/azure-storage-azcopy

I have to ask... why?  Why does it have a totally different syntax? Why have you broken half the world's azure deployment scripts?  Why wouldn't you simply give this thing a totally different name?  Let people continue to download the old AzCopy and let others adopt this totally different program you've created in it's place?  e.g... like RoboCopy vs Xcopy vs copy....
What you've done is like making RoboCopy but calling it Xcopy instead. Result headaches for a lot of people.

Changing the syntax is one thing... But then seeing all the current documentation in the Import/Export process in O365, while linking to the new version that uses a totally different syntax... That's a paddling


Release notes for beta-20170330

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/aa8a2f81a287eedeb25d62cfe5447fb18f3a4c47/

@bdarnell, please don't merge this. As soon as it merges, it's published. So I'll just take over the PR and add links and doc updates here.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/56ee3de1c40404d2e3f5ac77fe665726a60f2b50/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5f91fa342a2484d652a1472a41254e674adbd8e4/

LGTM

Review status: 0 of 10 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/437cf97e5c587c8080479df3f3b9a634a329cfc8/


Hidden Route

Rework of #247

Hide routes on map generator and signs
Hide interchanges on route map
Hide routes on system map (Currently it just don't add the route to the data servlet at all, need to think more about that one)

Oh this one is very useful!
Express routes really mess up the system map.


Regression - Basemap picker text not visible

The names of the basemaps in the basemap picker are no longer visible.
Likely due to a change in the Bootstrap CSS overriding the original colour.

Can be fixed by specifying the colour on the .giframeworkMap aside#sidebar-container .sidebar-panels .card.basemaps-selector a rule
color: var(--primary-color);

Ahhh I didn't notice this, despite testing everything... I'll fix it tomorrow, thank you :)


How can I get data  about each transaction in market for all pair with just one websocket client ?

I can only get the price about each transaction when I subscribe tickers channel but miss the amount information.
Nor does history transaction channel provide information about which pair transactions are.
Is there any way to achieve my purpose? please tell me.Thank you.

My private keys have been stollen and use are getting my funds takein


Remote entity doesn't exist

I see that the remote entity does not exist. Is it possible to get it added to the repo?

Absolutely, the Node.js library requires a major update for feature parity with the Python API wrapper.

I wrote the entity and would be willing to help, how would I go about getting access to be able to push changes for review?

I've updated the repository with contribution guidelines and made the first refactoring to catch up with our Python integration library in PR #35. The most notable changes and enhancements are:

setup flow handler callback, no more manual WebSocket calls.
entity command handler callback.
missing entity features and options

The old event notifications for entity commands and setup flow handling are still present and  should be triggered if no callback handler is set.
Since I require the remote-entity for a new integration as well, I'll add it tomorrow, unless you open a pull request today.

Implemented in PR #36


delay when pressing the bubble a second time

I used its dependency to make the bubble and the first time it returns to the foreground quickly but when doing it again there is an annoying waiting time that I can not find a way to fix, sorry for the misspelled writing, I am learning your language

I used its dependency to make the bubble and the first time it returns to the foreground quickly but when doing it again there is an annoying waiting time that I can not find a way to fix, sorry for the misspelled writing, I am learning your language


Update lrz for 320

this PR is being pulled into smaller pieces

OK I will mention it in the tracking Issue, or should we close it?


fix(derived-async): fix unsubscribing from old observable when new value is not observable

Thanks for creating this. Will check it in a bit.

@eneajaho Could you explain why the CI is not working?

@MillerSvt just merge from main and CI should be working. Thank you for your contribution.

@eneajaho can you re-review?

@all-contributors please add @MillerSvt for code


tvg saver: strange preprocessor condition

line 41: #if defined(_MSC_VER) && defined(clang)
shouldn't it be a logical OR ?

@vtorri Thanks, we don't need to address code review for each one here. Please comment here or in our chat (Discord). Otherwise, please submit a pull request (PR) :)

btw, that code is not used at all and it seems no problems on msvc build.


Add a helloworld page to the docs.

Reminder to self: before I merge this, add an issue that reminds me to add a helloworld page to the docs.
Originally posted by @gerhard in https://github.com/dagger/dagger/issues/1817#issuecomment-1075511612

@gerhard I think we can close this issue since we have some onboarding example, WDYT?


Pusj.js keeps asking for permission in Chrome even after "allow" is pressed.

I require a simple desktop notification on a button press but each time I press the button, it repeatedly asks for permission and  does not display the push notification. Upon checking Push.Permission.has(), I find the boolean returns false even when I repeatedly press allow on the chrome permission request. I am using push.min.js and serviceworker.js in my directory and referring to them in a script tag in the html document. I have tried using push.js without serviceworker.js but have had no success.
What do I do? How can I fix this?
Thank you for reading this.

Hi @NamanSharma5. try to start a node server and run your app or try with Firefox, in Chrome you need to start a node server and i think you need a ssl certificate. i hope this info can help you. bye

@NamanSharma5
Please specify the browser you are testing on.
Are you testing on localhost, or is there a url we can visit to see the issue ?
Also it would help if you can make a jsfiddle to demonstrate your issue, incase of the former.
Thanks

@aguileraq Thank you for your help. I will try to run a node server. Do you know if there is any other way to create push notifications in chrome?
Also, in Microsoft edge, no notifications appear even after I grant permission.  Although, unlike chrome , Microsoft Edge only asks for permission once, when the page starts.
I have attached screenshots of the source code.

@theLufenk Thank you for your response.
I am testing on Google Chrome, on which it keeps asking for permission.
In Microsoft edge, the notifications do not appear after granting permission to the webpage.
It works fine in Firefox- is there a way to stop firefox from showing the warning about "prevent this page from creating additional dialogues"
I have attached the code in my response to @aguileraq

@aguileraq @theLufenk
Thank you for responding to my initial query, your support has been invaluable towards my project.


Voting!

I will create one comment per submissions, and we'll use that information to vote on the submissions!

DisarmSelfDestruct - @babysitterd

LightsRound - @SewerynKaminski

TermBreaker - @ArthurSonzogni

Consu - @kmdrGroch

DanteO - RubberDuckEngineer, TrungDinhT, CardellaT

Drag Me aROUND - @oskidan

Grand Rounds - @dholmes215

Minesweeper Marathon - @ebarlas

smoothlife - @baerlux

Sumo - rusticobakko (@ilbakko), grisenti, NeeYume

The links are wrong. They should be prefixed on https://github.com/cpp-best-practices/game_jam/tree/main/Jam1_April_2022, not https://github.com/cpp-best-practices/game_jam/issues.

Should be fixed now


Dynamic library definitions

Boost uses a pattern to have a macro that should be included only when using dynamic library. Do we need to add something like "dynamic definitions"? Current alternatives are that consumer defines macros if using dynamic library or we make a separate, for example, org.boost.log.dll library with the definitions. I like the former better as the latter would force dealing with workaround libraries down the road if we support this.

Now dynamic/static libraries are separate libraries


CameraX: Image Rotation is incorrect

my case is user do not enable auto rotate, have any way to get rotation of image correctly
property rotationDegrees of ImageProxy.ImageInfo in analyze method always return 90 although camera is in portrait or landscape

This repo is for issues with the samples. For questions about usage, please use the android-camerax tag on StackOverflow or start a thread in the developer forums.


Submitting OpenJS.Nodejs 12.8.3.yaml

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

@denelon Any thoughts on making the LTS builds of node a separate package? LTS is what Node themselves recommend most people install, so I think it would make sense. This would also match what is offered on Node's website (and I think other package repos as well).
I'm happy to abandon this PR and submit another one.


Support extended fields defined in the Gateway API

Description:
This epic tracks all the individual issues associated with adding support for various fields within the Gateway API marked as Extended support

[x] https://github.com/envoyproxy/gateway/issues/564
[ ] https://github.com/envoyproxy/gateway/issues/656
[x] https://github.com/envoyproxy/gateway/issues/657

@skriss anything else that needs to be added in here ?

thanks for investigating ! tracking #642 as a top level epic highlighted in the roadmap so probably doesnt need to be included here

/assign


Feature/change login to use password stdin, fixing issue #17

Extracted common AbstractExecutorService as new base for both buildah and podman executor services and extended it with fluent command configuration.
Refactored podman login command to use --password-stdin instead of commandline provided password, fixing issue #17
Rebased on feature/Configure-squash-and-layers

[ ] To be tested with actual podman login command execution

I will take a look at the outstanding task next week. Finally got my development environment back up and running - will be a packed release :partying_face:


Update aws_quantum_job.py to add pattern for create job_name parameter.

Issue #, if available:
N/A
Description of changes:
Added a validation pattern for the create operation job_name parameter.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

If you run tox -e linters and push the changes, that should fix the problem with code format.
In the event, tox is not found, please run: pip install -e '.[test]'

Resolved by #618


devon formatter not having same values like Sonar plugin

If I'm using the devon ide (devon4j) without touching everything I get issues in Sonar though I use the devon sonar plugin also without changes.
Problem description:
As an example here is to take the checkstyle rule which is also part of devon java profile "Intendation". When I look into the profile I see the following configuration.

But if I look into the formatter in the ide there is the following configuration

Therefore Sonar is throwing an issue. There are also other issues like "Import order" or "Line length"
Expectation
Devon ide, devon formatter and devon sonar plugin have the same values and work out of the box without throwing issues.

@rhobolic thanks for reporting this bug.
Indeed this is very odd and kind of frustrating.
I am not sure why this happened now but my assumption is that the defaults changed with a sonarqube or checkstyle update.
After all the default rules and especially the whitespace rules for checkstyle are defined here:
https://github.com/devonfw/sonar-devon4j-plugin/blob/3bd6482d1164e7d915ec4d10779eeda6235316fe/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml#L1082
As we can see these rules rely on the defaults what is never a good idea:
https://github.com/devonfw/sonar-devon4j-plugin/blob/3bd6482d1164e7d915ec4d10779eeda6235316fe/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml#L1085
I will simply change this and set the indentation to 2 instead of 4.
BTW:

If I'm using the devon ide (devon4j) without touching everything I get issues in Sonar though I use the devon sonar plugin also without changes.

As a lot of people seemed to get confused with devonfw artifacts here are some hints to match them properly:

devonfw-ide is the tool to setup your local development environment: https://github.com/devonfw/ide#devonfw-ide - it is very generic and can be used for any kind of project (using Java, or .NET, or python, or NodeJS, or ...).
devon4j is the Java stack of devonfw: https://github.com/devonfw/devon4j#devon4j
sonar-devon4j-plugin is this repo with the sonar plugin for devon4j that you found perfectly and therefore filed the issues in the correct spot.

For the record: There are several very picky checkstyle rules active in our config that should also be discussed:

JavadocTagContinuationIndentationCheck - is that really something to verify and address on the level of SonarQube. Eclipse might format this different from IntelliJ and in the end it does not matter at all for real quality so discussing about things like this is pure waste.
CyclomaticComplexityCheck with a max of 10 might also be kind of dangerous. While in general this is not such a bad idea, the metric is defined in a very stupid way and some case statements or if cascades can easily cause a complexity higher than 10. If this results in developers splitting the code that belongs perfectly together into separate methods just at some random point only for the same of the rule the quality will not increase but decrease.

There might be more in this regard. I can do some testing on this and file a new issue for it if applicable...

I assume that this issue is fixed and can be closed. However, my tests are currently blocked by #141.

Another interesting fact is that the file that I initially created came from here and is still present:
https://github.com/devonfw/ide-settings/blob/master/sonarqube/profiles/Devon-Java.xml
It has correct indentation configured and lots of other differences.
So something went wrong when PR #56 was implemented.

I again have to give up for today:
I step-wise out-commented rule by rule when it was reported as error on startup.
This process was so annoying as we have so many rules, that I automated it step by step.
After full automation all rules had been disabled.
So to give an obvious example:
Caused by: java.lang.IllegalStateException: Rule with key 'devon4j:N8' not found

So SonarQube can not find a rule we define by our own plugin.
To me this means that SonarQube release is broken or changed in an incompatible way.
Our entire quality profile generation stopped working (at least with SonarQube <IP_ADDRESS>424).


Switch streams-test to be JPMS module

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 99.348% when pulling 14c00ec2b4e8537a99fb23626246ba9c3d885c3b on streams-test-as-module into a527ee38a30a64615c772d75ba766b37fcb12d24 on main.


Bleskomat extension for lnbits

This is basically done, but still marked as work-in-progress. My local lnbits setup is using an old version of sqlite3, so some of the database migrations are failing. Once I've had a chance to fully test the extension's UX flow, I will remove the WIP label.

Codecov Report

Merging #146 (49916db) into master (88eb8e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   29.35%   29.35%
=======================================
  Files          26       26
  Lines        1785     1785
=======================================
  Hits          524      524
  Misses       1261     1261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88eb8e0...49916db. Read the comment docs.

Coverage is terrible. Get it to at least 90% so we can merge.

I have now tested the full UX flow and it is working as expected. I've removed the WIP label.

Are there any blockers that I should address with this pull-request?

Is this already ready to merge?
I was waiting for you to finish before reviewing and merging.

Interesting. I should steal the fiat exchange rates code from you for my extensions.
Or maybe that should be a core util in LNbits.

Interesting. I should steal the fiat exchange rates code from you for my extensions.
Or maybe that should be a core util in LNbits.

Sure, it could be extracted into a core component. It's probably something that should be done once and made available to all the extensions.


Add alternative pump for early-game

Title.

Why?

(Though if you aren't playing on the latest builds, other pumps don't need arcane gems anymore)

Oh, playing old version in Horizons Daybreaker, sorry.


ECO flow doesn't insert fill cells

The recent ECO update inserts fill cells in a different place. We used to insert it after ECO was complete, now we insert it inside the
 while {$::env(ECO_FINISH) != 1} { loop. Amongst other things, this means we never insert fill cells if there were no hold violations in the first place to fix up.
I'm also not sure where we would remove the fill cells on a second iteration.

@donn your commit f2f5d8358795a14f3eb1c7c9b0a992b2ab2c49f0 seems to have changed some of the logic:

Previously we'd call reorg_reports.sh in each iteration of the loop, now we don't.
Previously we'd call ins_fill_cells once, after the loop is complete. Now we call it once every loop.

I'm taking a look at it, and I may probably agree with @antonblanchard because I remember we fixed this problem before.

I am happy to help maintain it, but this first version was only supposed to help fix hold in a simple way. Flow could be improved, for instance, to:

replace fast cells on fast paths with slower ones (for power reduction/leakage)
upsize / downsize buffers

Also, I would recommend adding CI checks to ensure updates to the flow do not break the ECO loop.
We will get to these at some point. Anton is doing a fantastic job stressing and maintaining it.

Ah, alright. Sounds good then. I'll look into CI if you can share a design with me that you use for testing the ECO flow.


FlashHelper incompatible with CakePHP 4

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] question

PHP Version: 8.1

CakePHP Version: 4.4.3

Plugin Version/Branch: v4.x-dev

What you did
Tried to load FlashHelper
What happened
Fatal error: Declaration of Bootstrap\View\Helper\FlashHelper::render($key = 'flash', array $options = []) must be compatible with Cake\View\Helper\FlashHelper::render(string $key = 'flash', array $options = []): ?string in /application/vendor/holt59/cakephp4-bootstrap-helpers/src/View/Helper/FlashHelper.php on line 33

What you expected to happen
No Fatal Errors

could you try this version please before i tag it ?
composer require holt59/cakephp4-bootstrap-helpers:dev-fix-10-declaration
Thanks

I tried it and it fixed the issue for me


Brilliant work.. Nothing like this module out there..

Can you add Some effects like saturation, black and white,(scan effects)? again thank you for sharing this..

Hi.. currently im not planning on extended the core native module function to other features. Im focusing on extent it to be used on RN. The native library that used is from ArthurHub/Android-Image-Cropper  - https://github.com/ArthurHub/Android-Image-Cropper


create a new ci flow that is a subset of the kustomize dev flow

see https://github.com/openshift/release/pull/32127#issuecomment-1242010463
admittedly, there is a tad of duplication, but I sided on minimal disruption to the existing dev flow
also, I had to break away from the assumption that the image tag for the operator would always be dev and was not keen on duplicating the image/tag env var splitting that we had to do in infra-deployments
longer term, if this approach for CI remains after the kcp transition for jvm-build-service is complete, or if this just bothers you too much @stuartwdouglas, we can rework this further; my first thought along those lines is the system config config map and other jvm-build-service namesapce items needs to be separated from the items in the base dir which are related to the test namespace
As I have managed to avoid changing any files directly related to the dev flow, I'm inclined to merge this, and iterate of any improvements in subsequent PRs, if I get green e2e's to facilitate retests in my openshift/release PR.
Then again, I would not be shocked if @stuartwdouglas sees this before that happens :-)
Sample output from my local testing (albeit I did not remove every obj like roles iteration to iteration):
JVM_BUILD_SERVICE_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jvm-controller:dev JVM_BUILD_SERVICE_CACHE_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jvm-cache:dev JVM_BUILD_SERVICE_SIDECAR_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jvm-sidecar:dev JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jvm-build-request-processor:dev JVM_BUILD_SERVICE_ANALYZER_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jvm-dependency-analyser:dev JVM_BUILD_SERVICE_JDK8_BUILDER_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jdk8-builder:dev JVM_BUILD_SERVICE_JDK11_BUILDER_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jdk11-builder:dev JVM_BUILD_SERVICE_JDK17_BUILDER_IMAGE=quay.io/$QUAY_USERNAME/hacbs-jdk17-builder:dev ./deploy/openshift-ci.sh
Executing openshift-ci.sh
jvm build service golang operator image:
quay.io/gabemontero/hacbs-jvm-controller:dev
jvm build service jvm cache image:
quay.io/gabemontero/hacbs-jvm-cache:dev
jvm build service jvm sidecar image:
quay.io/gabemontero/hacbs-jvm-sidecar:dev
jvm build service jvm analyzer image:
quay.io/gabemontero/hacbs-jvm-dependency-analyser:dev
jvm build service jvm reqprocessor image:
quay.io/gabemontero/hacbs-jvm-build-request-processor:dev
Running out of ./deploy
subscription.operators.coreos.com/openshift-pipelines-operator unchanged
tekton-pipelines-controller-79969c5f59-j6lhv        1/1     Running     0          6h55m
Tekton controller is running
Error from server (AlreadyExists): namespaces "jvm-build-service" already exists
find: ‘./deploy/operator/overlays/ci-final’: No such file or directory
find: ‘./deploy/overlays/ci-final’: No such file or directory
customresourcedefinition.apiextensions.k8s.io/artifactbuilds.jvmbuildservice.io configured
customresourcedefinition.apiextensions.k8s.io/dependencybuilds.jvmbuildservice.io configured
customresourcedefinition.apiextensions.k8s.io/tektonwrappers.jvmbuildservice.io configured
serviceaccount/hacbs-jvm-operator unchanged
clusterrole.rbac.authorization.k8s.io/hacbs-jvm-operator unchanged
clusterrolebinding.rbac.authorization.k8s.io/hacbs-jvm-operator unchanged
clusterrole.rbac.authorization.k8s.io/hacbs-jvm-operator-view unchanged
clusterrole.rbac.authorization.k8s.io/hacbs-jvm-cache unchanged
deployment.apps/hacbs-jvm-operator created
configmap/jvm-build-system-config unchanged
gmontero ~/go/src/github.com/redhat-appstudio/jvm-build-service  (more-dev-flow-ci-kustomize-pain)$

basic e2e passed for me locally

LGTM, I may have a look at removing the duplication at some point but it is not a high priority imho.

SGTM thanks
appstudio bootstrap fail on the with pruning failure
course, once this merges, if the openshift/release PR gets green, we'll lose both appstudio bootstrap and the separate pruning e2e
merging


fix(projects): remove token when logout

authStore.$reset()  does not clear the token, so we handle it manually

the method ’clearAuthStorage' already does the action of removing token.


Feature/manifest as crd

This PR implements partially #357 and resolves #787.
The Frontend service has been redone to instead of using secret files as Claudie manifests, now it use CRD.
group: claudie.io
version: v1beta1
kind: inputmanifest

List of changes that will change UX:

Secret data has been offloaded from the manifest: Now the inputManifest only reference a secret resource in the provider sections.
The secret placement isn't limited upfront by namespace, it can be created in any namespace. The same goes for InputManifest. There is no need for any additional labels on the InputManifest/Secret resource
Because of the architecture, the validation webhook won't check the provider's section at kubectl apply level. The workflow will be similar to Kubernetes Pods scenario. If a Pod referencing a non-existing secret will be created - it will CrashLoop in an error state, Claudie will generate an error and check again in 60s. (Interval of REQUEUE_AFTER_ERROR const var).
When deleting an InputManifest - the file won't get removed until the cluster won't be removed, because of v1beta1.claudie.io/finalizer read more

# Create a secret
apiVersion: v1
kind: Secret
metadata:
  name: hetzner-1
  namespace: any-namespace
type: Opaque
data:
  apitoken: QSBUWSBDV0FOSUFDWktVCg==
 ---
 # Create an InputManifest
apiVersion: claudie.io/v1beta1
kind: InputManifest
metadata:
  name: hetzner-test-manifest
  namespace: claudie
spec:
  providers:
      - name: hetzner-secret
        providerType: hetzner
        secretRef:
          name: hetzner-1
          namespace: any-namespace
  nodePools:
    dynamic:
      - name: control-hetzner-1
        providerSpec:
          name: hetzner-secret
          region: nbg1
          zone: nbg1-dc3
        count: 1
        serverType: cpx11
        image: ubuntu-22.04

    . . .

  kubernetes:
    clusters:
      - name: hetzner-test-cluster
        version: v1.30.0
        network: <IP_ADDRESS>/24
        pools:
          control:
            - control-hetzner-1
          compute:
            - compute-hetzner-1

ToDo:

Alter test sets, so they will utilise inputmanifest type.

Because of the architecture, the validation webhook won't check the provider's section at kubectl apply level. The workflow will be similar to Kubernetes Pods scenario. If a Pod referencing a non-existing secret will be created - it will CrashLoop in an error state, Claudie will generate an error and check again in 60s. (Interval of REQUEUE_AFTER_ERROR const var).

I don't like this much, but I understand this is the best way.
I wouldn't want the creation of a CRD to be blocked by the absence of the secret.
However, I think the default interval should be much shorter, no more than 5 seconds.

Will the status of the inputManifest be updated by events and errors?

Will the status of the inputManifest be updated by events and errors?
Yes, the inputmanifest .status field will contain the status of the cluster (including errors) + when an error will occur an Kubernetes event will be created with the err message.


Make test cases searchable in TestBrowser

The left area of TestBrowser should use a SearchContainer to allow easily filtering test cases.

I learned "Solves" is no keyword for closing so this is still open. It can probably be closed now?


Check The DeclContext When Retrieving Conforming Decls

Checking for staticness is not enough because top-level decls count as
non-static yet do not have a sufficient curry level to satisfy this
check. Make sure we're looking for decls that reside inside of types.
rdar://75299825, SR-14327

@swift-ci smoke test

Thank you for fixing this! I believe this happens only if T is a module type. In addition to your change, could you rewrite https://github.com/apple/swift/blob/7f1b76557bb60c119113fa56fe4bb4c39912ad42/lib/IDE/ConformingMethodList.cpp#L110-L111 to
if (!T->mayHaveMembers() && !T->is<ModuleType>())
  return;

@rintaro Slava brought up a good point: Can we just bail in ConformingMethodListCallbacks::doneParsing() if the subject type we're looking at is a non-type context?

That's a good point. Yes we can.

@swift-ci smoke test


Replaced references of Pub/Sub with PubSub as per official naming.

Replaced references of Pub/Sub with PubSub as per official naming.

@barnstee, @mregen, @koepalex, I will wait for one of you to approve this as well before merging as you are the domain experts on this.


PInvoke.IpHlpApi.GetExtendedUdpTable give wrong port

Describe the bug and how to reproduce
PInvoke.IpHlpApi.GetExtendedUdpTable give wrong port when compared to the windows command "netstat -ano"
What code is involved
private static List<TCPUDPConnection> GetIpV4UdpConnections(int pid)
{
    List<TCPUDPConnection> udpConnList = new List<TCPUDPConnection>();
    try
    {
        using (var results = GetExtendedUdpTable<MIB_UDPTABLE_OWNER_MODULE>(Vanara.PInvoke.IpHlpApi.UDP_TABLE_CLASS.UDP_TABLE_OWNER_MODULE, Ws2_32.ADDRESS_FAMILY.AF_INET))
        {
            foreach (var r in results)
            {
                if (pid < 0 || r.dwOwningPid == pid)
                {
                    IPAddress ipa = IPAddress.Parse(r.dwLocalAddr.ToString());
                    TCPUDPConnection row = new TCPUDPConnection(Utils.GetLocalHostName());
                    row.Protocol = Protocol.UDP;
                    row.Local = new System.Net.IPEndPoint(ipa, (int)r.dwLocalPort);
                    row.PID = pid;
                    udpConnList.Add(row);
                }
            }
        }
    }
    catch (Exception)
    {
        //Nothing to do here
    }

    return udpConnList;
}

private static List<TCPUDPConnection> GetIpV6UdpConnections(int pid)
{
    List<TCPUDPConnection> udpConnList = new List<TCPUDPConnection>();
    try
    {
        using (var results = GetExtendedUdpTable<MIB_UDP6TABLE_OWNER_PID>(Vanara.PInvoke.IpHlpApi.UDP_TABLE_CLASS.UDP_TABLE_OWNER_PID, Ws2_32.ADDRESS_FAMILY.AF_INET6))
        {
            foreach (var r in results)
            {
                if (pid < 0 || r.dwOwningPid == pid)
                {
                    IPAddress ipa = IPAddress.Parse(r.ucLocalAddr.ToString());
                    TCPUDPConnection row = new TCPUDPConnection(Utils.GetLocalHostName());
                    row.Protocol = Protocol.UDP;
                    row.Local = new System.Net.IPEndPoint(ipa, (int)r.dwLocalPort);
                    row.PID = pid;
                    udpConnList.Add(row);
                }
            }
        }
    }
    catch (Exception)
    {
        //Nothing to do here
    }

    return udpConnList;
}

Expected behavior
I expect that "netstat -ano" give the same results as PInvoke.IpHlpApi.GetExtendedUdpTable. It's not the case here :
Netstat port : 56359
PInvoke.IpHlpApi.GetExtendedUdpTable : 10204
Screenshots
"Netstat -ano" results :

PInvoke.IpHlpApi.GetExtendedUdpTable results :

I expect there is structure sizing problem. Are you running your code as 32 or 64-bit?

Haha. I deleted my last comment. You and I both failed to read the docs for dwLocaPort:

The port number of the UDP endpoint on the local computer. This member is stored in network byte order.

In the next 4.0 release, I've added a new property called dwHostLocalPort that puts dwLocalPort in host order.

Following the newest release (v.4.0.1), MIB_UDP6TABLE_OWNER_PID and MIB_UDPTABLE_OWNER_MODULE does not have any properties calleddwHostLocalPort. Is it normal?

@dahall Following the newest release (v.4.0.1), MIB_UDP6TABLE_OWNER_PID and MIB_UDPTABLE_OWNER_MODULE does not have any properties calleddwHostLocalPort. Is it normal?

I don't see that field (dwHostLocalPort) in either MIB_UDPROW_OWNER_MODULE or MIB_UDP6ROW_OWNER_PID. Both have dwLocalPort.

Thanks for the callout to make all the structures consistent. This is done for 4.0.2


Adding note about shell for Container Jobs

Why:
The default shell for container jobs is sh vs. bash. This can cause run scripts to fail if using bashisms (for example, if statements with double brackets).
Calling this out in the reusable for a job container.
Reference:
https://github.com/actions/runner/issues/1533#issuecomment-1067714605, which references: https://github.com/actions/runner/issues/353#issuecomment-1067227665

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding the content in the blue note:

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

👋 @joshjohanning Thanks so much for opening a PR! I'll get this triaged for review :zap:


Add com.teradata.git.hash to image labels

This is a better way of adding a git hash than pushing a second tag to dockerhub.

I don't see the removal of 'pushing a second tag'. I assume docker-release does this? I think those tags and labels won't conflict (they're different entities), but just wanted to make sure removing the  tag pushing is not needed :)

Just a thought: maybe fix #2  in the same shot? :)

Yeah, I'm opening the PR for not pushing the second tag now against docker-release. Tags and labels are non-conflicting. Labels are metadata contained within the image itself, and can only be set at build time. Tags are a pointer to an image ID.

I'll do the microbadger stuff (#2) in another PR sometime next week, but thanks for pointing that one out.


feat: add section explaining setup of trusted issuer registry

This adds a section explaining our governance setup with the trusted issuer registry smart contract.

superseded by https://github.com/Open-Credentialing-Initiative/OCI-Governance/pull/5


Pinpoint for mule

Description
Hi!,
Does Pinpoint work with mule? I added an agent to mule arguments, but Pinpoint shows nothing. Do I need a custom agent?
Hope you can help me.

Environment

Pinpoint version:
OS, WAS, affected library, etc:
Additional details (e.g. how your collector/web is set up):

Additional Info

Hi @cpresario
We don't support mule currently so I think that's why your not getting any traces.
Unfortunately, none of us are really familiar with mule so it'd be great if you could create a plugin for mule and throw us a PR if you'd like.


Make tests compatible with Vault 0.10

When starting a new, empty Vault server, the mount at /secret will be
the K/V Version 2 backend by default. The API paths are subtly
different, but the new paths happen to also work with the Version 1
backend, so we can just always use the new paths in the test.
See https://www.vaultproject.io/docs/secrets/kv/kv-v2.html#acl-rules

With this patch all tests passed for me with Consul 1.0.6, 1.0.7, and 1.1.0, so this may fix #494 entirely.

hmm, why doesn't codeship pick this one up?

When I change the versions in Makefile
diff --git a/Makefile b/Makefile
index 6d2ff11..3a9ca94 100644
--- a/Makefile
+++ b/Makefile
@@ -27,8 +27,8 @@ GOVENDOR = $(shell which govendor)
 VENDORFMT = $(shell which vendorfmt)

 # pin versions for CI builds
-CI_CONSUL_VERSION=1.0.6
-CI_VAULT_VERSION=0.9.6
+CI_CONSUL_VERSION=1.1.0
+CI_VAULT_VERSION=0.10.1
 CI_GO_VERSION=1.10.2

 # all is the default target

and run make docker-test I still get this:
--- FAIL: TestConsulSource (12.17s)
	source_test.go:240: Starting consul: Consul v1.1.0
	source_test.go:261: Timeout waiting for consul server after 12.0 seconds
=== RUN   TestVaultSource
--- FAIL: TestVaultSource (0.31s)
	source_test.go:305: Starting vault: "Vault v0.10.1 ('756fdc4587350daf1c65b93647b2cc31a6f119cd')\n"
	source_test.go:429: logical.Write failed: Error making API request.

		URL: PUT http://<IP_ADDRESS>:58421/v1/secret/data/fabio/cert/localhost
		Code: 400. Errors:

		* no data provided

Turns out the API isn't directly backward compatible after all. I amended my commit, so that Fabio detects a v2 backend and modifies Vault requests accordingly. It's not exactly pretty but it works. The new methods are almost verbatim copies from Vault's cli implementation.
This makes Fabio support the v2 backend automatically; no config change is required. The Vault policy must be updated, but that's not unique to Fabio. I seem to remember that a working sample policy is documented somewhere (in the wiki perhaps?) but I can't find it right now.
The Consul tests failed because your sneaky readiness check stopped working when they introduced gzip support, and I addressed that too.


gtypist: fix new clang

Description of changes
New clang defaults to C standard higher than 89. Gtypist fails to compile with that.
Explicitly set c89 when compiling instead.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@drupol aarch64-darwin or x86_64-darwin?

Sorry, it only compile on Darwin.

Ping @drupol


gists endpoint

Since it has a repo counter, why not a gist counter also?

Removing yarn.lock since I tried to use it, but cancelled after I've seen that the project was not using it. And I forgot to remove.


I'm getting errors with Redux example

I'm trying to define constants like on the following example:

my code:

And I'm trying to define the actions, however I'm getting the following error:

I'm just following the example on README, any help will be appreciated.
Best Regards.

Looks like you're referencing _ENTHUSIAMS where it should be _ENTHUSIASM.


Edge label

Hi,
Great stuff. But to edge label to an edge?
Much appreciated :-)
Br,
Christian

Thanks for pointing out this feature was missing.


feat: Update policies for AWS LBC v2.11.0

Description
This pull request includes updates to the IAM policy document for the load balancer controller in the aws_lb_controller.tf file. The changes involve adding new permissions related to capacity reservations.
Changes to IAM policy document:

Added elasticloadbalancing:DescribeCapacityReservation permission to the list of actions.
Added elasticloadbalancing:ModifyCapacityReservation permission to the list of actions

Motivation and Context
AWS LBC 2.11.0 needs extra few permissions for describing and modifying capacity reservation.
https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.11.0
Breaking Changes
No breaking changes
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 1.9.0 :tada:


Authentication Error page background color is not consistent with the dark mode

How to reproduce:

Follow the steps in https://github.com/wso2/product-is/issues/14506 to get the issue reproduced
Change the mode to dark mode from toggle button

The error messages is shown with a light pink colour background which is not consistent with the dark mode
Is there any possibilty to change the background clour of this error page to get consistent with dark mode'
As we are planning to provide this sample as the code sample for customers can we change it to support by default

What do you think if we can provide the error page in dark mode with similar background colurs like this which will not get highlighted in a sudden as above
Attaching a sample below

Environment information (Please complete the following information; remove  any unnecessary fields) :
H2 / default

New Message Box for Dark Mode
Success Message

Error Message

Info Message

Warning Message

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


pcm-pcie.x result seems not right

hi ! I tried pcm-pcie.x on my  Intel(R) Xeon(R) CPU E5，but the result(read\write bandwidth) of pcm-pcie.x and iostat was very different：
$sudo ./pcm-pcie.x -B
Skt | PCIeRdCur |  RFO  |  CRd  |  DRd  |  ItoM  |  PRd  |  WiL  | PCIe Rd (B) | PCIe Wr (B)
 0       0           0     155 M   213 M      0       0      30 K          23 G           0
 1     140 K        15 K    26 K   352 K     31 M     0       0            34 M        1986 M
----------------------------------------------------------------------------------------------------
 *     140 K        15 K   155 M   214 M     31 M     0      30 K          23 G        1986 M

$iostat -mx 1
Device:         rrqm/s   wrqm/s     r/s     w/s    rMB/s    wMB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
nvme2n1           0.00     0.00 15554.00    0.00  1860.19     0.00   244.93   209.61   13.42   13.42    0.00   0.06 100.20

Then I tried on another Intel(R) Xeon(R) Platinum, the result(read\write bandwidth) was very different too:
$sudo ./pcm-pcie.x -B
Skt | PCIeRdCur |  RFO  |  CRd  |  DRd  |  ItoM  |  PRd  |  WiL  | PCIe Rd (B) | PCIe Wr (B)
 0       0           0       0       0        0       0       0             0             0
 1      65 K      7644       0       0      312       0       0          4706 K         509 K
----------------------------------------------------------------------------------------------------
 *      65 K      7644       0       0      312       0       0          4706 K         509 K

$iostat -mx 1
Device:         rrqm/s   wrqm/s     r/s     w/s    rMB/s    wMB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
nvme10n1          0.00     0.00 8012.00    0.00   916.97     0.00   234.39     1.28    0.16    0.16    0.00   0.10  81.60

Hi @cooljiansir,
Thanks for reporting. I see two issues to be addressed in pcm-pcie program.

Xeon E5 based machine (prior to Skylake), the PCIe Rd (B) column is reporting wrong number.
Xeon Platinum based machine, the stats is off for both read and write.

To answer 1) Currently, PCIe Rd (B) is estimating bandwidth using sum(PCIeRdCur + CRd + DRd) * 64. CRd and DRd are generally traffics coming from CPU (sometimes service IO requests when BIOS changes PCIe Read to use CRd or DRd coherent flow). We will drop the CRd and DRd from PCIe Rd bandwidth calculation, so CPU traffic will not be estimated in the future.
To answer 2) I think there is a bug that skylake version of pcm-pcie.x is reporting "DDIO miss" bandwidth only by default. Can you please try ./pcm-pcie.x -e and see if you see most of traffic? We'll fix the default bandwidth display in the next release.

Thanks for your reply : )
I tried with ./pcm-pcie.x -e:(Intel(R) Xeon(R) Platinum)
$sudo ./pcm-pcie.x -e
Skt | PCIeRdCur |  RFO  |  CRd  |  DRd  |  ItoM  |  PRd  |  WiL
 0       0           0       0       0     2160       0       0  	(Total)
 0      17 K      1956       0       0     3987 K    24      12  	(Miss)
 0       0           0       0       0        0       0       0  	(Hit)
 1       0           0       0       0        0       0       0  	(Total)
 1       0           0       0       0        0       0    4668  	(Miss)
 1       0           0       0       0        0       0       0  	(Hit)
-----------------------------------------------------------------------
 *       0           0       0       0     2160       0       0  	(Aggregate)

$iostat -mx 1
Device:         rrqm/s   wrqm/s     r/s     w/s    rMB/s    wMB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
nvme1n1           0.00     0.00 2413.00    0.00   245.23     0.00   208.14     0.34    0.14    0.14    0.00   0.11  27.60

@xerothermic  I found that ItoM (Total) is smaller than ItoM (Miss), I'm wondering if we should add the result of PCM::programPCIeMissCounters and PCM::programPCIeCounters?

Hi zhijian,
Yes, that is correct. Would you mind to submit a PR if you think you can do it?
Thanks,
Patrick

On Apr 8, 2018, at 01:50, zhijian<EMAIL_ADDRESS>wrote:
@xerothermic I found that ItoM (Total) is smaller than ItoM (Miss), I'm wondering if we should add the result of PCM::programPCIeMissCounters and PCM::programPCIeCounters?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

hi @xerothermic，I have another question about the hit and miss: on some of my sever, miss counter seems to include  hit counter, but some other sever not.
So how can we get the total bandwidth?(hit + miss or max(hit, miss)?)


Dbadapters

Factors out the DB interaction with DynamoDB and allows us to replace with a local postgresql instance if we choose.

This is an urgent PR.  Straightforward edits and improvements can absolutely be made and are welcomed, but we will have to leave some technical debt  - docs/tests etc... The Jordan stakeholders have been made aware of this and the debt will be recorded in our handover document for Jordan.


Fix some language definitions in DSL v1/v2

Part of #652

Fixes versioning for UsingDirectiveSymbol in DSL v1
Fixes event parameter definition in DSL v2
Fixes ElseBranch sequence fields to be required themselves in DSL v2
Syncs ordered choice for (Yul)Statement across DSLs (helps minimize diff for #650)

I'll probably bundle remaining renames and restructures for DSL v2 in #650 already, but wanted to land this here since it fixes some tests and definitions separately from migrating the parser to DSL v2.

This also retrofits {Error,Event}ParametersDeclaration from v2 to v0/v1 spec.


thread 'main' panicked at 'invalid option'

Describe the bug
The following program gives error thread 'main' panicked at 'invalid option' (with probability, and if no panic, the program will hang forever, which is also not expected) if run with cargo run --release. However it works well with cargo run.
use std::io::Write;
use libzmq::TcpAddr;
use libzmq::prelude::{TryInto, BuildSocket, BuildRecv, RecvMsg};
use std::time::Duration;

fn main() {
    let input_addr: TcpAddr = "<IP_ADDRESS>:9999".try_into().expect("cannot parse zmq addr");
    let mut socket_builder = libzmq::GatherBuilder::new();
    let socket = socket_builder.connect(&[input_addr])
        .recv_hwm(10)
        .recv_timeout(Duration::from_millis(1000))
        .build()
        .expect("cannot build zmq socket");
    loop {
        socket.recv_msg().unwrap();
    }
}

Platform:

OS: Arch Linux (5.4.6-arch3-1)

active toolchain
----------------

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.42.0-nightly (0de96d37f 2019-12-19)

I can replicate the issue and I think this is due to a race condition because:

Its inconsistant (occurs 1/2 times on my pc)
It only occurs in release mode, which faster and increase the chance for a race.

This seems to occurs specifically in the ZMQ_RCVTIMEO socket option (recv_timeout call). I'm also assuming that this is a race condition on the ZeroMQ side, because it wouldn't be the first time.
I'll take a quick look in the ZeroMQ source to see if I can find anything. However, assuming that I am right, finding the source of this race would be unlikely since:

The zeromq codebase is an insane mess
There are multiple known race conditions in ZeroMq that still haven't been fixed, likely because the zeromq codebase is an insane mess

I hid my previous comment because my assumption was wrong. Found UB here:
https://github.com/jean-airoldie/libzmq-rs/blob/a375d2555d99321ada3380a2f316bc9c978c6aea/libzmq/src/core/sockopt.rs#L265-L269
Due to a temporary being as a raw ptr. I'll fix asap and look if this mistake appears elsewhere.

I'll publish a new release.

I'll publish a new release.

Sounds great. Thanks for your help!

A general word of advice, I would recommend against using ZeroMQ unless you are already committed to it. The codebase is unmaintainable and there are tons of API, documentation and implementation issues. There are tons of interesting ideas however, if that's what your looking for. I can't recommend an alternative solution however as I'm using my own closed source stack for the moment. Good luck!

A general word of advice, I would recommend against using ZeroMQ unless you are already committed to it. The codebase is unmaintainable and there are tons of API, documentation and implementation issues. There are tons of interesting ideas however, if that's what your looking for. I can't recommend an alternative solution however as I'm using my own closed source stack for the moment. Good luck!

@jean-airoldie BTW, are you familiar with NNG (https://nng.nanomsg.org/index.html)? Is it any better than ZeroMQ on your forementioned issues? Thanks!

To give some context, I do distributed messaging at a high frequency in rust. Moreover I care about reliable messaging because my messages are not idempotent (aka I can't simply resend the same message if I think it was lost). I used zeromq in production for a while and I came at several conclusion (which can also be applied to nanomsg and nng since they share a similar design).
Problem
TCP is not a reliable transport, neither is HTTP or HTTPS. This is because of 2 things:

TCP uses a 16bit checksum which is really too low for modern application with high throughput. In my case I think I would get 1 corrupted packet undetected by the checksum every 400gb of packet (can't remember the specifics so take it with a grain of salt). In practice, since you are using some sort of encryption over TCP, this means a decryption error which is fatal. This can be a big deal in some cases.
TCP is only really reliable as long as the connection is alive. The problem is that the connection can die at any time, and you will only know when you timeout the peer. Messages sent after the connection died, but before you timed out the peer, are lost. To fix that you either have to:

Wait for a reply after each request (aka. you ACK at the application level) which is really damn slow.
ACK every message in a batched asynchronous manner.  Moreover you need to keep a local copy of every message which increases memory usage.

Solution
I would say that the QUIC protocol solves all of these issues, however its still fairly young and unoptimized. For instance I don't event get 1Gb/sec using quinn where I would get 10Gb/sec using TCP.
Problem
ZeroMQ, nanomsg and nng sockets are stateless by design. This means that updates to the socket states will not be propagated to the user. Turns out this can be a major problem:

You are not notified when the socket connected or reconnected to the peer. This means that if there is a initial application level handshake that you need to do every time a connection is created you are out of luck.
You are not notified when the peer disconnected. This means that you can't implemented a dead man's switch easily.
You are not notified when the zeromq authentication mechanism fails, for instance when you misconfigured your credentials. Good luck debugging that.
And many more!

Solution
Propagate the socket state updates as notification that are forwarded to the user when he calls recv(). That's an integral part of the networking libraries I write and It works well. I don't really understand why zeromq & nanomsg & nng didn't do this in the first place, other than maybe ideology.
Conclusion
I didn't find anything out there that fits my specific needs so I would need to write my own lib on top of QUIC. However, currently I don't strictly need it and I don't have the time & resources to spare for now.

Thanks for your very detailed explanation!

I'll publish a new release.

Hi all!
Did this happen? I'm also running into this bug with 0.2.1 which is expected as it's older than this bug report. Are there beta releases or something that you're using in the meantime? I know about putting { git=... } in Cargo.toml but that won't let me publish.
I'm new to rust & its ecosystem, sorry if I'm missing something.

I'm also running into this bug with 0.2.1 which is expected as it's older than this bug report.

My bad, seems like I didn't actually publish a release. I'll do that right now.

know about putting { git=... } in Cargo.toml but that won't let me publish.

If you put libzmq = { git = "https://github.com/jean-airoldie/libzmq-rs" } this will use the latest master branch commit has a dependency. Then you can run cargo update which will fetch de dependencies etc.

Thanks!


Pylint doesn't allow import of another Azure SDK Package

Package Name:  azure-monitor-opentelemetry
Package Version:  1.0.0b16
Operating System: Windows and CI pipeline
Python Version: 3.x

Describe the bug
Pylint complains about the distro importing the exporter which has a similar module location. The imports are as follows:
from logging import getLogger
...

from opentelemetry._logs import get_logger_provider, set_logger_provider
...

from azure.core.settings import settings
...
from azure.monitor.opentelemetry._types import ConfigurationValue
from azure.monitor.opentelemetry.exporter import (  # pylint: disable=import-error
    ApplicationInsightsSampler,
    AzureMonitorLogExporter,
    AzureMonitorMetricExporter,
    AzureMonitorTraceExporter,
)
...

To Reproduce
Steps to reproduce the behavior:

Run pylint on package. Run the following command from the azure-monitor-opentelemetry directory.
tox -v -c ../../../eng/tox/tox.ini --root .

Expected behavior
Pylint says the import of the exporters are invalid:
azure/monitor/opentelemetry/_configure.py:37: [E0611(no-name-in-module), ] No name 'exporter' in module 'azure.monitor.opentelemetry'
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
At first I thought that perhaps other Azure-SDK need to be imported in the "3rd party" section like the opentelemetry.x imports. But it seems pylint accepts the azure core imports. So, I don't understand what's different about the exporter imports.

My guess is this has something to do with the fact that the exporter's module namespace, "azure.monitor.opentelemetry.exporter", is within the namespace of the distro, "azure.monitor.opentelemetry" while azure core's namespace is further up.

Here is the draft PR where I am trying to enable Pylint

Hi @jeremydvoss, I will take a look and get back to you asap. Thanks!

It seems, like you said, that pylint does not recognize azure.monitor.opentelemerty.exporter as a 3rd party package. It looks like this may also be related to the pylint:disable = import-errorthat  is there already. I would, for now, add no-name-in-module to the disable statement as it is a false positive. I can make an issue in the pylint repo as this is one of their checkers.

Using # pylint: disable=import-error,no-name-in-module does seem to solve the problem locally. Waiting to the pipeline to run in the PR. Thanks! This does seem to be a pylint bug. So, an issue would be good, whether the outcome is a fix or an instruction to move the import somewhere else.


fix: SymptomsTracker spelling error

Spelling of symptom 'soarThroat' changed to 'soreThroat' inside of SymptomsTracker.js component.

Needs rebase off most up-to-date master

I think this can be closed as the changes are already in master


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: monsterenergy22 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Merge


perf: save one ISZERO in _disableInitializers

Minor optimization (2 gas) of _disableInitializers in Initializable.
A JUMP should happen if the condition is false. With != it requires only EQ (3 gas) while with < it requires LT + IZERO (3 + 2 gas).
PR Checklist

[x] Tests
[x] Documentation
[ ] Changelog entry

Hello @MathisGD
Changes like this one should be proposed on the https://github.com/OpenZeppelin/openzeppelin-contracts repository.

Any change there will automatically reflect here.
Any change here will automatically be overwritten by code present there.

Hello @Amxx
Ok, I didn't know about that. Thank you !


TransGCN

您好！打扰了，请问您方便给出您的《TransGCN:Coupling Transformation Assumptions with Graph
Convolutional Networks for Link Prediction》一文的代码，以供我个人学习之用吗?

Hi,
Thanks for asking. I am not the first author of that paper. I will ask the author to see whether she want to publish the code of TransGCN.
Best,
Gengchen


Project dead?

Is this project dead? there haven't been any updates in 4 years and all the versions have been yanked.

Related:

#315
#341


Fix that FLAnimatedImageView will dispatch the completion block into next runloop even for non-GIF image, which may cause some rendering issue.

Add FLAnimatedImageViewSetImagePolicy to control detailed behavior for GIF rendering, this may help for some user who don't need that temp poster image and global queue decoding.
New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
Reason
Some user who use FLAnimatedImageView+WebCache for displaying GIF image face the issue that the behavior for non-GIF image is different from UIImageView+WebCache.
This because of that FLAnimatedImageView use a GCD group and dispatch_group_notify to manage the completion block after image loading. This API will submit the completion block to the notification queue(main queue) into next runloop. However, UIImageView will always call the completion block synchronously at current runloop.
This difference will cause sometime FLAnimatedImageView+WebCache loading a non-GIF image will flash during cell reusing.
So this PR fix that, by firstlly check whether this image is GIF, then use GCD group to dispatch. Or it will fallback as normal UIImageView process and call completion block synchronously at current runloop.
Other change
And also, this PR introduct a new config, to let user to disable a "trick" way of displaying FLAnimatedImage GIF for performance issue. See #2047 . Which may cause some problem for rare case, and user should have control to disable this and just create FLAnimatedImage in the current queue. However, that way can still be helpful for some big GIF images. (Which the decoding process may block the main queue and cause frame drop). So we can keep both of these and let the user to choose one.

Codecov Report

Merging #2374 into master will decrease coverage by 0.77%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
- Coverage   75.44%   74.67%   -0.78%
==========================================
  Files          36       36
  Lines        3837     3961     +124
==========================================
+ Hits         2895     2958      +63
- Misses        942     1003      +61

Impacted Files
Coverage Δ

SDWebImage/UIView+WebCache.m
64.39% <100%> (ø)
:arrow_up:

SDWebImage/SDWebImageImageIOCoder.m
81.73% <100%> (+0.22%)
:arrow_up:

SDWebImage/SDWebImageGIFCoder.m
79.8% <100%> (+0.19%)
:arrow_up:

SDWebImage/SDWebImageWebPCoder.m
84.46% <100%> (+0.13%)
:arrow_up:

SDWebImage/UIImage+MultiFormat.m
73.52% <100%> (+23.52%)
:arrow_up:

SDWebImage/SDWebImageCodersManager.m
71.08% <100%> (+0.71%)
:arrow_up:

SDWebImage/SDWebImageCompat.m
63.33% <50%> (-0.96%)
:arrow_down:

SDWebImage/NSData+ImageContentType.m
48.14% <52.63%> (+1.37%)
:arrow_up:

...age/FLAnimatedImage/FLAnimatedImageView+WebCache.m
51.67% <62.22%> (-8.33%)
:arrow_down:

SDWebImage/SDImageCache.m
64.42% <88.88%> (+0.82%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98a941...bf9b15f. Read the comment docs.

@dreampiggy what's the status with this PR? Does it still apply? If so, you can rebase it and then I can review

@bpoplauschi I seperate some non-FLAnimatedImage related change to #2390 and #2391. After that been merged, I can rebase and create new commit.
I guess that we need to revert the change from #2047 . So this PR's FLAnimatedImageViewSetImagePolicy feature should not been added. We just keep the original implementation from 4.2. People who need the best performance, should enable the cache for FLAnimatedImage, which only decode one time.

@dreampiggy I merged #2390 and #2391

@bpoplauschi OK...Since that two preparation was done. I can create another PR which contains only code for FLAnimatedImage+WebCache.


Improve Carpet plot legend explanation

What would you like changed/added and why?  I'd like better documentation of the color coding for the carpet plots.
Do you have any suggestions for the new documents? Specifically,  it would be helpful to understand what the two different shades of blue correspond to.  I'm going to guess that dark blue is the left hemisphere and light blue is the right hmisphere.  Is that correct?
Thanks for an incredible tool and all your work on it,
Dianne Patterson, Ph.D.

The current legend looks like this:

Now the hemisphere and tissue type are much clearer, I think.

Lovely, thank you!


More reliable field detection

Currently GLAMpipe just inspect the first record for getting the keys. This obviously fails if data is not uniform. Aggregate could be used here.

schema.createCollectionSchema implemented for imports.


no error when type enum is an interface without a function

Steps to repro:

Define an ftl type enum, but with an empty interface

Expected:

This should be an error on the enum, and not product errors everywhere else

What actually happens:

Errors appear every else because everything is now an enum variant because it conforms to the interface

//ftl:enum
type OpenEnum interface{}

// innocent bystander
type DAL struct {
  db *sql.DB
}

error:

unsupported type "*database/sql.DB" for field "db"

😂

we should also validate that the interface function is unexported, i don't think we're doing that right now


add test gateway_trascation_from_starknet_api_transaction

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

Current dependencies on/for this PR:

main

PR #771

PR #767

PR #772

PR #770

PR #773

PR #774

PR #775   👈

PR #763
PR #762

This comment was auto-generated by Graphite.


Background translucency

Pull Request Description
Closes https://github.com/enso-org/cloud-v2/issues/558

Uses the background from the Figma design

Screenshots

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

oops, forgot to test ide build and ide watch, will test very soon

@somebody1234 I had to merge with develop (there was a fix for macos build) but I cant open a dashboard see sreenshot

Can we make the same background for the authentication part?

still not able to test ide build and ide watch, and i was having issues when running lints because i did a ./run git-clean

lints: passing
watch-enso: seems like it works
ide build: ran into issue building again :( it's the "No matching asset for target" issue


Update the labels for buttons to "Share" and "Share with Selfie" in credential share screen

Describe the bug
The labels in the credential share screen need to be modified.

"Accept request and choose ID" to "Share"
"Accept request and verify" to "Share with Selfie"

Pre-requisite
The application should have at least one credential to share.
To Reproduce
Steps to reproduce the behaviour:

Open the application
Click on the QR code scanner
Scan the verifier QR code to connect with the verifier application
Share credential screen is shown below

Expected behaviour
The labels for sharing credentials buttons need to be modified.

"Accept request and choose ID" to "Share"
"Accept request and verify" to "Share with Selfie"

Screenshots

Smartphone (please complete the following information):
Not Applicable
Additional context
Enhancement as discussed with Sasi on 24th Feb 2023.

Labels are changed to "share" and "share with Selfie" in english language.
Translation for other languages required apart from english

Issue merged in the PR - https://github.com/mosip/inji/pull/595

The following PRs implements  text change on the button labels on the consent page:

"Accept request and choose ID" to "Share"
"Accept request and verify" to "Share with Selfie"

PR for mosip/tuvali: #28
PR for mosip/inji: https://github.com/mosip/inji/pull/595, https://github.com/mosip/inji/pull/597
The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

This is fixed as part of release v0.9.1


[BUG, RR1] Prometheus exporter ignores internalErrorCode for rr_http_request_total

If you use internalErrorCode this is not taken into account when incrementing the rr_http_request_total counter.
I tried this code:
http:
  internalErrorCode: 503

Create a slow controller that sleeps for some time, set workers to a low number, allocateTimeout also should be quite low, use bombardier to saturate the server, you need to force roadrunner to produce errors because it can't allocate workers.
Then look at the metrics exporter, you will see something like this:
rr_http_request_total{status="500"} 389

I would expect to see:
rr_http_request_total{status="503"} 389

tested on 1.9.2, I haven't had the opportunity to try 2.0, I'm waiting for https://github.com/Baldinof/roadrunner-bundle/issues/29 to upgrade

@hugochinchilla metrics service from the RR 1.9.2 uses its own HTTP server. This error code likely comes from it, but not from the HTTP service.

To clarify, there are several HTTP servers that are responsible for the services (plugins in the RR2). The HTTP service in the RR1 responsible for the HTTP requests has its own server, but requests to the metrics service are handled by the integrated into the metric service HTTP server.

I think I did not explain this well so I will focus on way I want to achieve instead of a possible solution.
I want to be able to read from prometheus how frequently I'm leaving requests unattended because I don't have available runners.
I did not found a metric for that and thought that maybe I would be able to identify those errors by the status code. So I see two possible solutions:

Create a new metric that increments for errored requests (internal errors, not application errors).
Increment rr_http_request_total using the real status code that was used for the response instead of using 500 for internal errors.

I think I did not explain this well so I will focus on what I want to achieve instead of on a possible solution.
I want to be able to read from prometheus how frequently I'm leaving requests unattended because I don't have available workers.
I did not found a metric for that and thought that maybe I would be able to identify those errors by the status code. So I see two possible solutions:

Create a new metric that increments for errored requests (internal errors, not application errors).
Increment rr_http_request_total using the real status code that was used for the response instead of using 500 for internal errors.

Edited: some errors.

@hugochinchilla It will be better to move this proposal to a separate ticket and close this one since the original description does not relate to the proposal. You can put a reference to this ticket in a new one. Thank you for the proposal.

@48d90782 I'm not sure, don't you think is a bug not using the same status code for the actual response and for the response status counter?
I could create a new feature request for having a new counter just for the internal errors, but still, If i'm getting 503 errors on the client side I would expect to see the counter reflect that.

@48d90782 I'm not sure, don't you think is a bug not using the same status code for the actual response and for the response status counter?

This is not a bug, just a different behavior since these services use the different HTTP servers inside.

I could create a new feature request for having a new counter just for the internal errors, but still, If i'm getting 503 errors on the client side I would expect to see the counter reflect that.

Yes, please, create a new feature request to add shared internal error codes and a new counter.

@48d90782 I think you are focusing to much in a detail implementation. Does it really matter if there are multiple http servers? as a user I just care of it doing the expected thing.
I found where the problem originates. It's not just a matter of reading the configuration object and using the internalErrorCode value instead of hardcoding the status?
        #cmd/rr/http/metrics.go

	case rrhttp.EventError:
		e := ctx.(*rrhttp.ErrorEvent)

		c.requestCounter.With(prometheus.Labels{
			"status": "500",
		}).Inc()

		c.requestDuration.With(prometheus.Labels{
			"status": "500",
		}).Observe(e.Elapsed().Seconds())
	}

I agree that adding a new counter should be another feature request though.

If for some architectural decision the metrics server should not be reading config from the http block then the http server could pass that value in the ErrorEvent.

@48d90782 I think you are focusing to much in a detail implementation. Does it really matter if there are multiple http servers? as a user I just care of it doing the expected thing.

I just try to be on the same page with you and give you an understanding of the internal behavior. For sure, as for the end-user that does not matter, a user sees a bug that leads to the bad UX and that is the problem.
The metrics service should not lay on the HTTP section, because obviously, it can be empty. I am thinking to move all HTTP codes stuff to a different configuration section, thus all HTTP servers inside RR can inherit the same behavior.
I understand your point and your problem, and I will try to help you ASAP. But the original issue was about the bug, which actually isn't a bug. Thus, will be great if you create a new feature request to create a new counter and inherit the same HTTP error codes for the whole app. Thank you for understanding 😃.


bad ux in testset list

in the testset list view when we want to click on one testset to view it or to edit it we don't have the feeling that it's clickable
suggestions to fix :

we display a pointer on the whole row
we make only the name of the testset clickable

@mmabrouk that's what I meant by the first suggestion


Remove eSpeak module

This module is unused and I don't think we have plans to use it in the future. This PR removes it, as well as removing the dependencies it required.
Relates to #398

You should keep this, and make it work.
It was super useful to be able to have the robot say things when it's running on the field and you can't just terminal into it.

While I agree we should keep this, it is currently dependant on hardware that we no longer have

You should keep this, and make it work.
It was super useful to be able to have the robot say things when it's running on the field and you can't just terminal into it.

While I agree we should keep this, it is currently dependant on hardware that we no longer have

So you're advocating keeping this @Bidski?

I mean the hardware you no longer have is literally a speaker... It's not like it's some esoteric weird hardware that we will never have again.
Plug something into the NUC's headphone port and boom you have hardware again
We actually had plans to replace that little radiation symbol on the chest with a little speaker already right @tayloryoung6396

So you're advocating keeping this @Bidski?

I am. Just because a module is not being used, doesn't mean it is useless (or not worth keeping). Just putting it out there that there is a hardware dependency for this module

Roger that. If we think this is worth keeping, that's all good by me. Closing


lanetix/issues#2820 exploit preflight cache

Use the preflight cache so we don't have to send as many options requests.

:necktie:


⚠ Bofrost.be has degraded performance

In 1f3123a, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1474 ms

Resolved: Bofrost.be performance has improved in ea281d2.


Bootstrap columns are not compatible with Firefox 68.11.0esr

Bootstrap 4 is not compatible with Firefox 68.11.0esr (64-bit)

Hello

World

It looks like this in Firefox:

I think you need to use either .card-columns or .row + .col, not both.

I think you need to use either .card-columns or .row + .col, not both.

Correct!

But it works correctly on Chrom!