Selected ListTile background is rendered outside of ListView clip area

Steps to reproduce
Run this app and scroll a bit to observe the clip behavior of the ListTile (behavior is the same on MacOS and iOS):
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'List View Clip Issue',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const DrawerListViewClipIssue(),
    );
  }
}

class DrawerListViewClipIssue extends StatelessWidget {
  const DrawerListViewClipIssue({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Drawer(
        child: Container(
          padding: const EdgeInsets.only(top: 32),
          decoration: const BoxDecoration(
            border: Border(
              top: BorderSide.none,
              right: BorderSide(
                color: Colors.blue,
                width: 2,
              ),
              bottom: BorderSide.none,
              left: BorderSide.none,
            ),
          ),
          child: ListView(
            children: const [
              ListTile(
                title: Text("item1"),
                selectedTileColor: Colors.grey,
                selected: true,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Expected results
I expect the background of the selected ListTile to be clipped at the same location as the "item1" text.
Actual results
The text is clipped at the top of the ListView but the background of the selected ListTile is rendered outside the clip area.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'List View Clip Issue',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const DrawerListViewClipIssue(),
    );
  }
}

class DrawerListViewClipIssue extends StatelessWidget {
  const DrawerListViewClipIssue({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Drawer(
        child: Container(
          padding: const EdgeInsets.only(top: 32),
          decoration: const BoxDecoration(
            border: Border(
              top: BorderSide.none,
              right: BorderSide(
                color: Colors.blue,
                width: 2,
              ),
              bottom: BorderSide.none,
              left: BorderSide.none,
            ),
          ),
          child: ListView(
            children: const [
              ListTile(
                title: Text("item1"),
                selectedTileColor: Colors.grey,
                selected: true,
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale en-GB)
    • Flutter version 3.22.2 on channel stable at /Users/muji/bin/flutter-sdk
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (9 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc4)
    • Android SDK at /Users/muji/Library/Android/sdk
    • Platform android-34, build-tools 35.0.0-rc4
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] Connected device (5 available)
    • sea (mobile)                    • 00008103-001A45A93498A01E • ios            • iOS 17.5.1 21F90
    • star (mobile)                   • 00008030-001428190E8BC02E • ios            • iOS 17.5.1 21F90
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 127.0.6533.89

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for the workaround @SuicaLondon.
FWIW, I had to wrap each ListTile to get the workaround to behave as expected, wrapping the Container in a Material had no effect.
Closing as duplicate of https://github.com/flutter/flutter/issues/89294.

Thanks for the workaround @SuicaLondon.
FWIW, I had to wrap each ListTile to get the workaround to behave as expected, wrapping the Container in a Material had no effect.
Closing as duplicate of https://github.com/flutter/flutter/issues/89294.

You can wrap the whole ListView with one Material. It affects all descendants.

Thanks for the workaround @SuicaLondon.
FWIW, I had to wrap each ListTile to get the workaround to behave as expected, wrapping the Container in a Material had no effect.
Closing as duplicate of #89294.

You can wrap the whole ListView with one Material. It affects all descendants.

That worked, thanks @SuicaLondon 🙏


doc: update decorators tc39 stage

proposal for decorators has been promoted to stage 3 but TS doc still says stage 2.

Thanks, duplicate of https://github.com/microsoft/TypeScript-Website/pulls?q=is%3Apr+is%3Aopen+decorators


JOSS Paper

Creating PR to enable discussion and comments

@KapilDuwadi your updates look great. Good to go to NREL reviews from my perspective!


Where is the doc ?

Where is the doc ?

In repository there is only source for the docs, to generate HTML / epub / whatever you want - you'll need to run sphinx.
To run sphinx (http://sphinx-doc.org/tutorial.html) just go to docs folder and type:
sphinx-build -b html sourcedir builddir or use makefile from my repo (type make html)
I didn't want to generate all the possible output formats for this documentation, that is why there is just the source.


message_feed_ui: Add banner when messages in unsubscribed streams not marked as read.

Added a banner to notify the user that messages in unsubscribed streams were not marked as unread when the user chooses the option "Mark as unread from here" in an interleaved view.
Previously the user was not informed that these messages in the unsubscribed streams were not marked as unread.
Fixes: #23470

@rebeccasod, are you still planning to work on this, or can I take over from here?

Closing in favor of https://github.com/zulip/zulip/pull/26634 for this issue.


SArray.Unpack(...) should support ndarrays

The following doesn't work but should:
In [1]: import turicreate as tc

In [2]: import numpy as np

In [3]: sa = tc.SArray(np.zeros(5))

In [4]: sa.unpack()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-7f501734d1bd> in <module>()
----> 1 sa.unpack()

/Users/tobyroseman/anaconda2/lib/python2.7/site-packages/turicreate/data_structures/sarray.pyc in unpack(self, column_name_prefix, column_types, na_value, limit)
   3420
   3421         if self.dtype not in [dict, array.array, list]:
-> 3422             raise TypeError("Only SArray of dict/list/array type supports unpack")
   3423
   3424         if column_name_prefix is None:

TypeError: Only SArray of dict/list/array type supports unpack

This is still an issue in TuriCreate 6.4


Test failure: LargeUpload

This test fails occasionally with the following error:

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
This test failed on master.
CC @muratg
This issue was made automatically. If there is a problem contact ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this actually a flaky test?

No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
Yes, proceed below...

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

Is there any logging or extra information that we could add to make this more diagnosable when it happens again?

Yes?

[ ] Add the logging (TODO: Link to PR/commit)

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact ryanbrandenburg.

@Tratcher @halter73 @JunTaoLuo Could one you guys pick this up? Thanks.

From the build overview:

failed to publish artifacts: Failed to upload

I was able to download the build log, but the log includes no reference to either MaxRequestBufferSizeTests or LargeUpload.


Improves error message in case of forgotten/wrong edge_based=true/false parameter.

Its easy to forget setting edge_based=true at query time when only edge based CH is prepared.

Thanks!


Fix row-types on Quint operator conversion

#2542

[ ] Tests added for any new code
[ ] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

Codecov Report

Merging #2544 (5082367) into main (5306084) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
+ Coverage   78.54%   78.56%   +0.01%
==========================================
  Files         441      441
  Lines       15546    15576      +30
  Branches     2544     2511      -33
==========================================
+ Hits        12211    12237      +26
- Misses       3335     3339       +4

Impacted Files
Coverage Δ

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
88.77% <73.33%> (+0.43%)
:arrow_up:

...palache/tla/typecomp/unsafe/UnsafeFunBuilder.scala
98.18% <95.00%> (+0.35%)
:arrow_up:

...n/scala/at/forsyte/apalache/io/quint/QuintIR.scala
100.00% <100.00%> (ø)

.../apalache/tla/typecomp/subbuilder/FunBuilder.scala
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

There’s an integration test failing because of a missing fixture generation (I think).


Update google chart URL

Use https://chart.googleapis.com/chart? instead of https://www.google.com/chart?

Sorry, I must have missed this notification when it originally appeared. Thanks for the heads up! Fixed

No problem. Anyway nice code you have
On Jun 20, 2017 8:17 AM, "Doug"<EMAIL_ADDRESS>wrote:

Closed #4 https://github.com/Dolondro/google-authenticator/issues/4.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Dolondro/google-authenticator/issues/4#event-1130110452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMOgIAJGOmd3optjhzY9PZ3MOON-Zxiks5sFw-HgaJpZM4Ne3MY
.


from_array() got an unexpected keyword argument 'inline_array'

What happened?
I got the error: from_array() got an unexpected keyword argument 'inline_array'
for this line in xarray:
data = da.from_array(
data, chunks, name=name, lock=lock, inline_array=inline_array, **kwargs
)
lines 1230 and 1231 in xarray/core/variable.py
What did you expect to happen?
No response
Minimal Complete Verifiable Example
No response
MVCE confirmation

[ ] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[ ] Complete example — the example is self-contained, including all data and the text of any traceback.
[ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[ ] New issue — a search of GitHub Issues suggests this is not a duplicate.
[ ] Recent environment — the issue occurs with the latest version of xarray and its dependencies.

Relevant log output
No response
Anything else we need to know?
No response
Environment

Please edit with an MCVE. More info is in the issue template

Hello, here is the MCVE:
I was trying to follow ICEYE's tutorial to make an icecube:
grd_datacube = GRDDatacube.build(cube_config, test_dir_grds)
and this is the error stack trace:
04/06/2024 06:23:21 PM - sar_datacube_metadata.py - [INFO] - Building the metadata from the folder /Users/_shivi/Desktop/bhumi/icecube/tests/resources/grd_stack using GRD
processing rasters for cubes:   0%|          | 0/3 [00:00<?, ?it/s]
TypeError                                 Traceback (most recent call last)
 in
----> 1 grd_datacube = GRDDatacube.build(cube_config, test_dir_grds)
~/Desktop/bhumi/icecube/icecube/bin/sar_cube/grd_datacube.py in build(cls, cube_config, raster_dir)
78     def build(cls, cube_config: CubeConfig, raster_dir: str):
79         grd_datacube = GRDDatacube(cube_config, RASTER_DTYPE)
---> 80         ds = grd_datacube.create(cls.PRODUCT_TYPE, raster_dir)
81         grd_datacube.xrdataset = ds
82         return grd_datacube
~/Desktop/bhumi/icecube/icecube/utils/common_utils.py in time_it(*args, **kwargs)
111     def time_it(*args, **kwargs):
112         time_started = time.time()
--> 113         return_value = func(*args, **kwargs)
114         time_elapsed = time.time()
115         logger.info(
~/Desktop/bhumi/icecube/icecube/bin/sar_cube/sar_datacube.py in create(self, product_type, raster_dir)
48         # assert_metadata_exists(metadata_object.metadata_df)
49         self.set_xarray_dtype(metadata_object.metadata_df)
---> 50         ds = self.create_by_metadata(metadata_object)
51         self.xrdataset = ds
52         return ds
~/Desktop/bhumi/icecube/icecube/bin/sar_cube/sar_datacube.py in create_by_metadata(self, metadata)
135                     )
136
--> 137                 raster_xrdataset, cur_metadata = self.compute_layer_xrdataset(
138                     raster_fpath, metadata
139                 )
~/Desktop/bhumi/icecube/icecube/bin/sar_cube/grd_datacube.py in compute_layer_xrdataset(self, raster_path, metadata)
112
113     def compute_layer_xrdataset(self, raster_path, metadata) -> Tuple[xr.Dataset, dict]:
--> 114         i_xr_array, grd_metadata = self._create_xdarray_with_ICEYE_GRD(raster_path)
115         return xr.Dataset({NAME_INTENSITY_BAND: i_xr_array}), grd_metadata
116
~/Desktop/bhumi/icecube/icecube/bin/sar_cube/grd_datacube.py in _create_xdarray_with_ICEYE_GRD(self, grd_fpath)
125         # use Dask to load the array
126         array_dask = da.squeeze(
--> 127             xr.open_rasterio(
128                 grd_fpath, chunks={"band": 1, "x": self.chunks[0], "y": self.chunks[1]}
129             )
~/opt/anaconda3/lib/python3.8/site-packages/xarray/backends/rasterio_.py in open_rasterio(filename, parse_coordinates, chunks, cache, lock, **kwargs)
376         token = tokenize(filename, mtime, chunks)
377         name_prefix = f"open_rasterio-{token}"
--> 378         result = result.chunk(chunks, name_prefix=name_prefix, token=token)
379
380     # Make the file closeable
~/opt/anaconda3/lib/python3.8/site-packages/xarray/core/dataarray.py in chunk(self, chunks, name_prefix, token, lock, inline_array, **chunks_kwargs)
1324             chunks = either_dict_or_kwargs(chunks, chunks_kwargs, "chunk")
1325
-> 1326         ds = self._to_temp_dataset().chunk(
1327             chunks,
1328             name_prefix=name_prefix,
~/opt/anaconda3/lib/python3.8/site-packages/xarray/core/dataset.py in chunk(self, chunks, name_prefix, token, lock, inline_array, **chunks_kwargs)
2261             )
2262
-> 2263         variables = {
2264             k: _maybe_chunk(k, v, chunks, token, lock, name_prefix)
2265             for k, v in self.variables.items()
~/opt/anaconda3/lib/python3.8/site-packages/xarray/core/dataset.py in (.0)
2262
2263         variables = {
-> 2264             k: _maybe_chunk(k, v, chunks, token, lock, name_prefix)
2265             for k, v in self.variables.items()
2266         }
~/opt/anaconda3/lib/python3.8/site-packages/xarray/core/dataset.py in _maybe_chunk(name, var, chunks, token, lock, name_prefix, overwrite_encoded_chunks, inline_array)
283         token2 = tokenize(name, token if token else var._data, chunks)
284         name2 = f"{name_prefix}{name}-{token2}"
--> 285         var = var.chunk(chunks, name=name2, lock=lock, inline_array=inline_array)
286
287         if overwrite_encoded_chunks and var.chunks is not None:
~/opt/anaconda3/lib/python3.8/site-packages/xarray/core/variable.py in chunk(self, chunks, name, lock, inline_array, **chunks_kwargs)
1227                 chunks = tuple(chunks.get(n, s) for n, s in enumerate(self.shape))
1228
-> 1229             data = da.from_array(
1230                 data, chunks, name=name, lock=lock, inline_array=inline_array, **kwargs
1231             )
TypeError: from_array() got an unexpected keyword argument 'inline_array'

Sorry — we need a block of text that can be copied into a python prompt and reproduce the error. I appreciate it may take some work, but it is the only way we can engage.
To the extent this is from deep inside icecube, it might be worth addressing this with them

Hi, these are the steps I took:
https://iceye-ltd.github.io/icecube/installation/ - I followed all the steps on this website to install and then
I tried to follow the steps here:
https://iceye-ltd.github.io/icecube/examples/Ex1_SARDatacube/
My code fails at the line "grd_datacube = GRDDatacube.build(cube_config, test_dir_grds)" producing the above error.
Thank you!

OK — we're keen to help, but we need a very small example to assess whether it's a bug with xarray. Otherwise it's not possible for us to prioritize the most important issues.
If anyone can see the issue from looking at the text above, please ofc feel free to comment, but I'll close in the meantime.

For anyone else running into this, the answer is that you need a version of dask >= 2021.01.0 to support this feature
https://github.com/dask/dask/commit/e1301de7b9e1889d3f258efbad15cc2c7f5211f0
for me, it's a mismatch in dask and xarray versions. I have xarray 2024.x but have dask 2020.x


help me

Describe your problem here.
when i uploaded my model to the charter editer when i did it it just show the png look

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

did you reskin another spritesheet? if yes, then make your own sprite sheet by using adobe animate or using this https://gamebanana.com/tools/7136

This is a common problem to new modders. Try downloading a high quality version of the spritesheet and it will work.

BUT IM ER3 MAKEING A MOD THO

IM HELPING ER3

If you don't find anything related to the spritesheet quality, then maybe it's the size of it. Try making your own spritesheet.


Replace Extents with Size in VoxelGI, ReflectionProbe, FogVolume, Decal

I gave it a shot and revived the PR from @ator-dev.
Fixes: https://github.com/godotengine/godot/issues/54449
Supersedes: https://github.com/godotengine/godot/pull/55178
For more context see also: https://github.com/godotengine/godot/pull/44183 and https://github.com/godotengine/godot/pull/49672
Testing appreciated!
Co-authored-by: ator-dev<EMAIL_ADDRESS>

I'm writing an early report of some issues I noticed while testing locally, I will provide more detailed comments on the code itself as well
When dragging a handle on the ReflectionProbe the editor popup is way off. It reports the extents instead of size. The extents are labelled "P", the position is labelled "S" and the entire thing is labelled "Size X" (when dragging the "X" handle). This should just say "Size: " and report the size

Similarly with FogVolumes "Size" reports the extents

Actual size for comparison

FogVolume's gizmo is way off

I also noticed that this change introduces a shader compilation error into FogVolumes. I'll provide specific suggestions on the code momentarily.

I'm writing an early report of some issues I noticed while testing locally, I will provide more detailed comments on the code itself as well

Thanks! I will take a look at it. I'm not super familiar with the 3D part of the engine, much more on the 2D part so this is super helpful!

Update:

I fixed a lot of things I found.
I added Decal now as well, since the logic very close to the rest.
I wonder if it makes sense to change the GPUParticles... nodes in another PR, so this PR does not grow much further?
I have no strong opinion, I can also add them here. :)

I wonder if it makes sense to change the GPUParticles* nodes in another PR, so this PR does not grow much further?
I have no strong opinion, I can also add them here. :)

Yes, it makes sense to do this in the same PR.

Yes, it makes sense to do this in the same PR.

Changed all the GPUParticles*3D as well.

@Maran23 We discussed this PR in our production meeting this morning. The consensus was that we would like to merge ithis ASAP as we don't want this work to go to waste and it is kind of now or never. However, we also want to minimize compatibility breakage (after all, we did promise to minimize compatibility breakage after Beta 1).
To minimize compatibility breakage, we need to add glue code to the _set/_get functions that can read when extents is used and automatically set size accordingly. I.e.:
#ifndef DISABLE_DEPRECATED
bool Decal::_set(const StringName &p_name, const Variant &p_value) {
	if (p_name == "extents") {
		set_size(p_value * 2.0);
		return true;
	}
	return false;
}

bool Decal::_get(const StringName &p_name, Variant &r_ret) const {
	if (p_name == "extents") {
		r_ret = get_size() / 2.0;
		return true;
	}
	return false;
}
#endif

Do you have time in the next 14 hours or so to add this? If not I will happily do it

Do you have time in the next 14 hours or so to add this? If not I will happily do it

I will work on it right now. :)

Here is a test project built in Beta 16 that I will be using to check if extents are properly converted from save files
extents-to-size.zip

Here is a test project built in Beta 16 that I will be using to check if extents are properly converted from save files extents-to-size.zip
Also tested GDScript code that sets .extents directly

Thanks for the project.
I opened it with Godot 16 and a copy with that branch.
Looks good to me:

Thanks!


[10.x] Add a possibility to set a custom on_stats function for the Http Facade

Idea
I was working on a package that logs the transfer stats of the guzzle requests. To support the Http Facade of the framework I intended to do the same here, but the framework overwrites any custom functions, the idea was to add a possiblity to have both.
Functionality
In the sendRequest Method, we check if we have a user function set and then use a closure to do the default and necessary step to add the stats to the response object and afterward call the user function.
Disclaimer
It is my first pull request on a big project, so I'm sorry to bother in the first place.
Not sure if it is appropriate to tag driesvints, but he declined the first PR because the test were failing, but requested a resend of it. This should pass (hopefully)

I'm confused how this isn't already possible? We merge the options. Can't you already set an on_stats option?


https://github.com/adobe/aem-core-cif-components/issues/286

Description
FilterRangeTypeInput doesn't account for *_????. When you filter on price for *_10 you should get a result back of all products from 0_10.
Related Issue
https://github.com/adobe/aem-core-cif-components/issues/286
Motivation and Context

How Has This Been Tested?
Tested locally, and passed CI
Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

@shamrox I added unit tests to cover that part of the code, and now our build properly fails because of the wrong setTo. Please fix this, and also fix the corresponding test that your change will break. I intentionally didn't include your change so that you properly get "credited" for the fix in this PR.

Thank you @shamrox for your contribution. Since you were not responding any more and we wanted to merge this, I created #308 to replace your PR.


Fix render events to pass correct dt values

beforeRender and afterRender events (from noa object) currently pass a dt argument equal to the number of ms elapsed since the last tick. This was done because the physics system needs that info, but general event consumers would expect dt to be the ms since the previous event.
As part of fix, add new noa.positionInCurrentTick property, which gets updated before each tick. That is, if noa.positionInCurrentTick is 0.25, then at the time of that render event the time since the last tick would be 1/4 of the noa._tickRate.

This is fixed in the dev branch as of a week or two ago.


refactor: build the homepage with ISR

This PR enables Next's Incremental Static Regeneration (ISR) for the homepage. This means:

The homepage is generated at build-time instead of rendered by the server on every hit
Load times for the homepage are reduced: In my tests the staging URL loads the DOM in 100 - 300 ms, while stadtpuls.com needs about 1 s
The only "dynamic" elements on the homepage are regenerated every 60 s at most (see ISR docs for details). This is relevant mainly for the stats section. I simulated adding and deleting sensors and the ISR promise of regeneration works as expected.

Note that the effect of ISR is not visible in development.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No module named 'task_datasets'

In sample_dataset.py, an error occurred:
from task_datasets import dataset_class_dict
ModuleNotFoundError: No module named 'task_datasets'

Sorry for missing some code before. It has now been completed in the new pull request #5 and you can pull the new version. But in fact, this part of the code is not really used lol


5.1.1 is not on npm OSS

i see a new release of v5.1.1 on github release
but it seems that it is not on npm OSS :
https://www.npmjs.com/package/react-native-video

@nickfujita

version 5.1.1 is now published to npm as well.

version 5.1.1 is now published to npm as well.


Typescript should be a dev dependency

Hello MangoPay team,
Please change in the package requirements the typescript dependency to a devDependency. Typescript should only be used to compile typescript files into js files. But you are uploading as a requirement to everyone that implements your SDK as a dependency and it supposes around 50MB in size.
Thanks in advance.

Hello @javigines,
Thanks for your feedback. We are reviewing it and we will keep you updated.


Adding support for controller input and method in an array with the n…

…ame of the route

@azakhozhy Would be great if you can summarize the background/aim of this PR in description.
Also avoid changing the spacing style in code comments/documentation..

Sorry I just realised I wrote a review but didn't submit it :facepalm:

Sorry I just realised I wrote a review but didn't submit it 🤦

Lol, happens to me too, I think GitHub should have a prompt to submit before you leave the page..


fix: sort on table

Motivation
https://issues.jboss.org/browse/AEROGEAR-8373
What
Fix Sorting on Columns in Apps Table.
Previous Behaviour

Sort only works once for each column and only ascending

Why
Functionality wasn't working correctly
How
Add sortBy to redux state management
Update this when the sort is called so that the sortBy direction is reversed each time.
Verification Steps
Run the application
Click on the column header for each column multiple times
Sorting should work
Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Functionality
[ ] Serious Clean UP
[ ] Testing

Additional Notes
Pushing this as a draft pr as the functionality is now working but it needs a serious clean up!!
Lots of stuff in there that could be removed/cleaned but wanting to get some feedback on the general approach initially.

Coverage remained the same at 68.895% when pulling 103bd4b1ded91bf2d4ac637736448cc55d9dd405 on laurafitzgerald:AEROGEAR-8373-column-sorting into 1d50f79bf996c6fc62945a507f0f83932e9c27c4 on aerogear:master.

This looks good @laurafitzgerald. Just left some quick comments in the code after a quick scan of it (will take a deeper look in a bit). Verified the sorting works when I ran it locally too.
I see there's some state related to the table/ sorting still not managed through redux - should we fix that in this PR?

@damienomurchu yes we can definitely fix it here. This pr was a first attempt hack to get it all functioning. Definitely some improvements can be made, including the ones you commented above. Going at it again today with a fresh mind to try to clean it up. Will definitely ping you for review also when I have something new pushed. 😄

@damienomurchu I've pushed a clean up of the state management. There is a lot less flows to manage the same state as was managed before. I'm also considering that the reversal of the apps could all be done using the same action. Going to investigate that now but feel free to review what's there for now if you have some time.

Also I toyed with combining reducers at a stage where I had the reducer separated in the same way that the actions are seperated but I'm thinking now that we should have one actions file and one reducer file managing the state for each of the views. It's just a thought at this stage. I initially thought that separating the reducers for app data and ui state was the way to go but after some investigation I'm against that idea for this small app.

I'm also considering that the reversal of the apps could all be done using the same action.

Yes, I was thinking this too - one toggle action should suffice I think, wdyt?

Also I toyed with combining reducers at a stage where I had the reducer separated in the same way that the actions are seperated but I'm thinking now that we should have one actions file and one reducer file managing the state for each of the views. It's just a thought at this stage. I initially thought that separating the reducers for app data and ui state was the way to go but after some investigation I'm against that idea for this small app.

Yes, lets not prematurely optimise. I think we can refactor easily enough if any research we do indicates we should structure the reducers and actions in a specific way - wdyt?

Great work @laurafitzgerald this looks good. One question I had when looking through the code - do we need AppsTableContainer or is it an unneeded abstraction and everything could be housed on AppsTable instead?

By the way this PR is still in Draft mode.

Great work @laurafitzgerald this looks good. One question I had when looking through the code - do we need AppsTableContainer or is it an unneeded abstraction and everything could be housed on AppsTable instead?

Hi @damienomurchu I'm not sure about it but we did chat with @wei-lee around this topic in this thread so I'm happy to take either approach. What I've done here is that I've put all the code dealing with state and logic in the container and passed that down to a UI rendering component. As you said though there may not be enough in the UI component to warrant this. I'm open to others opinions here.

By the way this PR is still in Draft mode.

@craicoverflow I set it as draft mode for the first commit as the Redux stuff needed a serious refactor. I've done this now so does it make sense to change it from draft mode now?

By the way this PR is still in Draft mode.

@craicoverflow I set it as draft mode for the first commit as the Redux stuff needed a serious refactor. I've done this now so does it make sense to change it from draft mode now?

Hmm I'm not sure so. I guess it can be left :)

The tests in the most recent commit will fail. Pushing for review/fresh set of eyes.

@damienomurchu the test is now working. I've pushed it up but will progress with squashing everything and this one should be ready for a final review soon!

@wei-lee thanks for the help with fixing the tests. Would you mind doing a quick review on this one now?

@wei-lee @craicoverflow @damienomurchu thanks for the comments. I've addressed those in the new commit. Would you mind reviewing those before I squash them.


No editor class for the element VehicleBoarding

used in White House. linked by a "Random" element. exact function unknown.

Forces instigators into a vehicle.
Boarding also includes a seating order- White house has it randomized with 4 different versions to move players around a random order.
Needs to be linked to a vehicle unit.


basic cargo fmt -- --check pre-commit hook

@encody For https://near-foundation.atlassian.net/browse/ENG-149 , what do you think about this?
Adding a server-side CI tool looked more complicated than it's worth (for our small team at this point, I think).

@encody Also, maybe you should set up branch protection in this repo to prevent merges to main without approval. Let's have everything go into develop first.

@ryancwalsh I no longer have admin access to this repo since I transferred it to the NEARFoundation org. You'll have to ask Robert to set that up.

Two questions:

Why not simply have the hook run cargo fmt instead of telling you to run it? I think that's how husky (NPM) works.
I think the output is messing with the text formatting—removing the line breaks or something. The commit hook prints:

Please run `cargo fmt` before committing code. Here is the current result of `cargo fmt -- --check`:
Diff in /Users/jacob/Projects/near-contract-tools/src/standard/nep141.rs at line 22: #[derive(Serialize, Event)] #[event(standard = "nep141", version = "1.0.0", rename_all = "snake_case")] #[serde(untagged)] -pub enum Nep141Event<'a>{ +pub enum Nep141Event<'a> {  /// Token mint event. Emitted when tokens are created and total_supply is /// increased. - FtMint{ + FtMint {  /// Address to which new tokens were minted owner_id: &'a AccountId, /// Amount of minted tokens

When cargo fmt -- --check prints:
Diff in /Users/jacob/Projects/near-contract-tools/src/standard/nep141.rs at line 22:
 #[derive(Serialize, Event)]
 #[event(standard = "nep141", version = "1.0.0", rename_all = "snake_case")]
 #[serde(untagged)]
-pub enum Nep141Event<'a>{
+pub enum Nep141Event<'a> {
     /// Token mint event. Emitted when tokens are created and total_supply is
     /// increased.
-    FtMint{
+    FtMint {
         /// Address to which new tokens were minted
         owner_id: &'a AccountId,
         /// Amount of minted tokens

@encody  For 1, I was thinking of doing that since I'd like it handling it automatically, but I worried that there could be corner cases where someone has some modified files that are not staged and are not intended to be part of the commit, and even those would be subject to cargo fmt making edits. Additionally, if somehow someone else managed to push unformatted code to a repo that you then pulled down, then some files that you didn't even work on and weren't thinking about would suddenly be modified automatically as part of this process. There might be some benefit to that being a more discrete/intentional action.
But I don't feel strongly. We could just choose to go with that auto approach if we like it.
For 2, I don't know off the top of my head why it's doing that, but I can explore. Having it print out perfectly is probably not important since we'll all be using IDEs anyway and the most important part is just the blocking of the commit, but yeah that's weird.

Hm, I'm not sure I'm 100% on board with the idea of simply blocking the commits that don't conform. Seems like that could be something that is more of a hindrance than a help.
It doesn't look like cargo fmt or rustfmt support formatting individual files. Since the cargo fmt -- --check also applies to all files, I'm concerned that the "block the commit" hook would also apply in the situation you mentioned: where if someone pushes unformatted code, everyone else who pulls that code would be prevented from committing (outside of using --force) without formatting that code.
I've added an entry to the GH Actions file that should check the formatting. This should simply prevent merging pull requests that contain unformatted code. Caveat: it's difficult (or, I don't know how) to test GH Actions files without simply merging to master and seeing what happens.

Okay, looks like GH Actions is finally happy. Sorry for the barrage of "Run failed" emails.


⚠ ClamAV has degraded performance

In deecc0a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in c82308f.


Missing the changes added with "Add login and identifier auth page changes" commit

Describe the issue:
After the PR https://github.com/wso2/identity-apps/pull/3931 got merged to the porduct, changes added with the PR https://github.com/wso2/identity-apps/pull/3924 had been got reverted. Hence the genericReCaptchaEnabled config is not getting checked when showing the recaptcha.
How to reproduce:

disable recaptcha.
enable generic recaptcha for identifier first.
recaptch won't be visible.

Expected behavior:
The recaptch should be available.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: master branch
OS:Mac
Database: H2
Userstore: jdbc

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Pysolarmanv5 improvements

Hi @StephanJoubert,
As requested, I've reviewed and added a number of fixes to improve the addition of pysolarmanv5 to the Solarman integration.
Note that @cosote had already started to work on this in their fork, so to credit them and avoid duplication, I've based these fixes upon theirs.
Cheers,
Jon

@StephanJoubert Maybe merge this, seems like there are plenty of improvements?

Thanks @jmccrohan much appreciated.


can u help me

I'm interested in your project, but I can't run the program.

'PIP subprocess error' occurred while configuring the environment. I downloaded all the pips in requires.yml, but when I opened spyder (AEB) and ran it for 5 seconds, it will flash back and automatically close spyder.
I am trying to run test_ebs.py using spyder (root) python3.8 and get stuck on 'sklear.utils.linear_assignment_' trying all the methods online without making progress. Can you help me?

Greeting for the day
Thanks for showing interest in my project. I will look into the error and
get back to you ASAP.
Kuldeep
On Wed, May 26, 2021 at 4:05 PM beholder9-1 @.***>
wrote:

I'm interested in your project, but I can't run the program.

'PIP subprocess error' occurred while configuring the environment.
I downloaded all the pips in requires.yml, but when I opened spyder (AEB)
and ran it for 5 seconds, it will flash back and automatically close spyder.
I am trying to run test_ebs.py using spyder (root) python3.8 and
get stuck on 'sklear.utils.linear_assignment_' trying all the methods
online without making progress. Can you help me?
[image: ？1]
https://user-images.githubusercontent.com/75932402/119645817-088cb680-be51-11eb-8b3c-ab491a161f14.png
[image: ？2]
https://user-images.githubusercontent.com/75932402/119645825-0a567a00-be51-11eb-821e-4c04855a8829.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kuldeepbishnoi/Automatic-Emergency-Braking/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQKAORYL62J3S55X5PTGXALTPTFGHANCNFSM45RW3JBA
.


frontend build error

frontend throws this error, any idea to fix it ? It seems related to react-pdf.
./components/Chat/ChatRichContentItem.tsx:200:23
Type error: No overload matches this call.
  Overload 1 of 2, '(props: Props | Readonly<Props>): Document', gave the following error.
    Type 'Element' is not assignable to type 'ReactNode'.
  Overload 2 of 2, '(props: Props, context: any): Document', gave the following error.
    Type 'Element' is not assignable to type 'ReactNode'.

  198 |                       }}
  199 |                     >
> 200 |                       <Page pageNumber={pageNumber} />
      |                       ^
  201 |                     </Document>
  202 |
  203 |                     <div className="flex gap-2 item-center mt-3">

another case
./components/CodeModal/CodeModal.tsx:73:5
Type error: Argument of type 'Element' is not assignable to parameter of type 'ReactNode'.
  Property 'children' is missing in type 'Element' but required in type 'ReactPortal'.

  71 |
  72 |   return createPortal(
> 73 |     <Rnd
     |     ^
  74 |       dragHandleClassName="handle"
  75 |       className="z-[9999] shadow-lg"
  76 |       default={{

maybe it's simple but I have no experience of react and typescript.

so do i,

We have removed pdfjs dependency now. Could you pull the latest and try it again?

Closed as no further discussion. Please feel free to reopen it if needed.


Make people less angry when searching for docs.

Thank you.
I will wait for this until I have found time rewriting more extensive documentation. I'm not yet proud of what we have here. It's important for me however, and it shouldn't be too much work, so I hope to finish it before the summer.
Cheers,
Jonathan

:+1: for this. In the meantime you could at least put a link to the tutorial directory in the readme.

Documentation has been improved a lot, and the link has been added. (It's still work in progress, but already usable.)


a question about weibo dataset

hi~，
I would like to double check if the dataset you are using in the model is weiboNER.conll.train or weiboNER_2nd_conll.train?
The  weiboNER.conll.train is an old version.

Thanks for pointing this out.
Yes, we use the new version and we exclude the word segment information, and we will update the information in README.


add ci integration

could be circle ci, could be github action. either is fine.
should check on both unit tests added in #17 and current e2e tests ran by make test

cc @JonSnow47

could use github Action to do ci testing
refer to https://github.com/iotexproject/iotex-address/commit/efcb81c838b88e98bae3583dd568dffd3786fd06


Replace cookie crashes with regular pixels

Task/Issue URL: https://app.asana.com/0/488551667048375/1204599953020604/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3161   👈

This comment was auto-generated by Graphite.


Restore missing comma to fix build

Fixes https://github.com/tensorflow/tensorflow/issues/52910

@sanjoy @pkanwar23 Can you please review and merge this PR.
It's currently impossible to build TensorFlow because of this bug.

@elfringham Can you please resolve conflicts? Thanks!

Made moot by https://github.com/tensorflow/tensorflow/commit/ad8a18eaab4bf0b6e18272c9e54d8818e5875ac0


Gemini podcast is reading markup verbosely

I noticed a couple of podcast when the hosts were saying "asterisk" and "giggles". It seems like the Gemini speech to text model is not handling this correctly.

I am no longer observing this issue in new release v0.4.0


fix(celery worker): install unzip & wget

SUMMARY

I stumbled upon this issue that the worker was not able to install chrome and chromedriver because wget and unzip were missing. So adding them during worker init will fix the issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before adding:

After adding:

TESTING INSTRUCTIONS

Simply try to init the worker with Kubernetes config, with apt install unzip wget -y added to the command: part.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Just needs a bit of a rebase, otherwise... sorry this didn't get attention sooner! We're trying to get better about keeping PRs on track.

Some people really like having super lean images for production, bloating images has impact on speed of autoscaling/deploys/... It feels we should layer this in a dev or fat image if at all. Seems unzip/wget would support in-docker troubleshooting/debugging, but why can't you just apt-get while in the image? Also realizing we have a fair amount of Dockerfile-type content in docs which seems off, that stuff should be in actual Dockerfiles and layered properly.


kde colour sequence does not match line and hist

Notice that KDE has inverted colours. Is this a bug?
Thanks!
Ygg

Certainly strange.

Code to reproduce:
import numpy as np
import pandas as pd
import hvplot.pandas

size=400

y_target = np.random.normal(0,1.5,size)
y_predictions = np.random.normal(1,1,size)
performance = pd.DataFrame(list(zip(y_target,y_predictions)),columns=['y_target','y_predictions'])

(performance.hvplot.line() + performance.hvplot.kde(alpha=0.8) + performance.hvplot.hist(bins=40, alpha=0.8)).cols(1)

Result:


Roll engine d4be9c1637cf..8405e42966ee (4 commits)

git@github.com:flutter/engine.git/compare/d4be9c1637cf...8405e42966ee
git log d4be9c1637cf..8405e42966ee --no-merges --oneline
2019-10-16<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from oTVah... to ek5iQ... (flutter/engine#13186)
2019-10-16<EMAIL_ADDRESS>Remove redundant call to updateEditingState in sendKeyEvent (flutter/engine#13175)
2019-10-16<EMAIL_ADDRESS>If we get a 'down' event, add that device to the active devices. (flutter/engine#13182)
2019-10-16<EMAIL_ADDRESS>Roll src/third_party/skia 4e11526e3d7e..1dfc77cc08ee (9 commits) (flutter/engine#13183)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6042164542308352

Commit queue failed; closing this roll.


Upgrade LSClient version

Description:
Upgrade LSClient version to enable client capabilities for Language server.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Moved https://github.com/wso2/ballerina-plugin-vscode/issues/43


Data Deletion Policy

Users might want to set a data deletion policy at the event level. For eg, don’t keep events for page view event which are older than 1 year.

User event-driven architecture

We can use click house inbuilt feature


Move patterns into own files

this was attempted here, but it failed: 3c5e8611b72acce5aa18aa7b7096966c56e0605f
this was causing some functions to not properly import downstream. My sneaking suspicion is that if  I export each pattern as a function instead of an arrow function, it'll perform sa expected.

using regular functions does not solve the issue. :(


Storybook: Docs tab code examples are broken in React Storybook

Expected behavior
Consumers can view the Docs tab in Storybook and expand the Show code sections to view the code that generated the corresponding story.
Actual behavior
The Show code section ends up showing what looks like some kind of internal Storybook representation of the story, e.g.:
<[object Object]
  value={{
    prefix: 'storybook'
  }}
>
  <No Display Name />
</[object Object]>

Steps to reproduce the issue

Visit any story in the React section of the combined Storybook or in the standalone React Storybook
Click the Docs tab
On any story, click Show code

Additional information
This likely broke as a result of #501 but I couldn't readily confirm because we don't have historical record of the React Storybook—only the web component Storybook. It would be easy enough (though possibly slow) to confirm locally by going back a few commits (or with git bisect if this turns out to be older).

Fixed as a side effect of #543!

Fixed as a side effect of #543!


added freezeNormals to createRibbon

Added freezeNormals()/unfreezeNormals() methods.
It concerns only ribbon based meshes : ribbons, tubes, extruded shapes.
It skips/unskips the normals recomputation on mesh update when called with CreateXXX(..., meshInstance) (the case where CreateXXX() is used to update an instance instead of creating a new one).
It improves update performances for meshes that don't need normals (emissiveColor only for instance).
Chromium big ribbon (60K vertices) update test :

unfrozen normals = 35 fps
frozen normals = 60 fps

For the sake of comprehension, can you add code comments for these functions ?

its documented here ("more speed" part) : http://doc.babylonjs.com/page.php?p=25096
but I can add comments in the code also if you prefer

Just a really small sentence to prevent users from using it if they are not using ribbons

it will be done, boss.


Could not find a declaration file for module 'react-screen-wake-lock'.

I want to use this package for my React (TypeScript+SWC) app that I created using the npm create vite@latest script.
When I try to import useWakeLock I get this error.

Could not find a declaration file for module 'react-screen-wake-lock'.
'../node_modules/react-screen-wake-lock/dist/react-screen-wake-lock.esm.js' implicitly has an 'any' type.

There are types at '../node_modules/react-screen-wake-lock/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'react-screen-wake-lock' library may need to update its package.json or typings.ts(7016)

While it still works if i set "strict": false, in my tsconfig.json, but I don't want to do that.
Is this something that warrants a fix?

Thanks for reporting the issue, can you try the latest version 3.0.2?

It works, thanks!


Controller support SSM parameter store SecureString type?

Hello,
I wasn't able to find docs or previous issues/questions about this. Does the controller support SSM parameter stores using SecureString? My goal is to keep these values encrypted at rest on parameter store.
Thanks!
EDIT: here's the link a reference link https://docs.aws.amazon.com/kms/latest/developerguide/services-parameter-store.html

Tested with SecureString and KMS. Looks like this feature is working  as long as the controller has permissions to decrypt


add functionality to fetch map and file annotations for an image

also changes code style unfortunately

Please reference a stable parent pom. The most recent stable version is 2.2.5


NPM ERR : get-cursor-position | node-gyp rebuild

Hello !
I'm trying to install a project on my computer but i've this error. I'm working on a Mac (OSX Mojave). I've friend with the same computer, same OS version and it's work for him. So i've unstall Node and NPM but issue still here after reinstall. How can i do ? Thank's !

Node Version: 10.12.0
NPM Version: 6.4.1
Platform: OSX (Darwin)
Compiler:
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
Module: sudo npm install on project folder

sudo npm install

<EMAIL_ADDRESS>install /Users/camille/Dev/viatransit/viatransit-API/node_modules/get-cursor-position
node-gyp rebuild
gyp ERR! configure error
gyp ERR! stack Error: EACCES: permission denied, mkdir '/Users/camille/Dev/viatransit/viatransit-API/node_modules/get-cursor-position/build'
gyp ERR! System Darwin 18.0.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/camille/Dev/viatransit/viatransit-API/node_modules/get-cursor-position
gyp ERR! node -v v10.12.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!       There is likely additional logging output above.
108 verbose exit [ 1, true ]

gyp ERR! stack Error: EACCES: permission denied, mkdir '/Users/camille/Dev/viatransit/viatransit-API/node_modules/get-cursor-position/build'

That's a permissions error. Check that all components are writable. You can rmdir build, node-gyp will recreate it.


New site build

This build of the site corresponds to the Heron 0.14.1 release.
A running version of these changes can be seen here:
http://lucperkins.github.io/heron/

Just clicking around quickly I see a number of pages that still refer to 0.14.0:
http://lucperkins.github.io/heron/docs/getting-started/
http://lucperkins.github.io/heron/docs/developers/topologies/


Examples do not seem to work

Installed on CentOS 6 and tried also on Ubuntu 16.04LTS, it seems to compile fine. I run the fork-echoserv, and the testclient, and they seem to connect, but nothing happens. Pressing ctrl-C on the server causes the client to exit with the "cant get case count". So that indicates to me that they are connecting to each other.
It seems the testclient is hanging at line 425 (epoll_wait), during the call to get_casecnt.
fork-echoserv is on line 418.
the non-fork version (echoserv) seems to give the same results.
Please let me know if you need any more information, or if I'm missing something.

After closer examination, I see that the testclient doesn't seem to be part of the echoserv, but is something altogether different. Sorry for the disturbance.

FTR, testclient is written for Autobahn client test.


Figure out GCP secrets integration with Cloud Run

Instead of setting secrets (encryption key, db username/password) through environment variables in GCP. Figure out how to integrate with GCP's Secrets Manager and Cloud Run. I believe it's pretty straightforward, actually, and should get to this soon as it's important.

using gcloud and you can specify a different service acc if you need to like the below:
gcloud secrets versions access latest --secret="my-secret" \<EMAIL_ADDRESS>\ --project="xxxxxx" > ./secret.key
My Go is a bit rusty, looking for something like this to kick start me in the right direction, but i gotta make use of a Mongo instance, is it much work to migrate from postgres to mongodb ?

Thanks! Unfortunately I've never used Mongo, so so can't really comment...


external forms + SpringAutoDeployment

Hi,
Why contextPath is null when SpringAutoDeployment is used to deploy bpmn process?
Form http response: {"key":"app:forms/custom-form.html","contextPath":null}
url: http://localhost:8080/camunda/api/engine/engine/default/task/9fd23d72-2cf7-11e8-acb5-f85971ac21c4/form
I am using camunda-webapp-tomcat-standalone (version 7.8.0) + bpmn file + external forms (trying to get it working)
Regards

Not sure how this is related to the Camunda Modeler? A better place to ask would be the Camunda forum.


Performance issues using C standard

C++ Weekly
Topics
The C standard is widely used and is also used in C++.
However, some of its code, which should be trivial and fast, is actually slow.
example: https://quick-bench.com/q/ZE1DFYD0jP7DN6t9MtOfpzaGH8Y
a simple "toupper" implementation can be 8x faster on gcc to 22x faster on clang than using the C standard version.
it'd be nice to discuss this in an episode and possibly inspire deeper investigation into which functions are slow and why.
I believe they're slow because the compiler can't inline the function calls.
10 min

Check the example at cppreference.com https://en.cppreference.com/w/cpp/string/byte/toupper.
std::toupper takes into account the current locale as well, which your to_upper function doesn't.

apologies, I though tstd::toupper didn't check the C locale,
I do have another example though, here's a testcase for std::div that's 12x slower than if you'd implement it yourself.
it's less drastic as the previous example, but there's still a performance difference where a custom implementation is 1.3 times faster.
https://quick-bench.com/q/EVx72v42DMw-wq__71nMv0FmrWc

I looked at the implementation of std::div in gcc's standard library, and the std::div_t struct returned, and they are exactly like yours.
The only difference I could spot is that the compiler is able to inline your function, but it doesn't inline std::div.
I don't know the why, so I'll upvote you.
I'd also like Jason to explain the why.

Yes I think you're right about inlining, constexpr evaluation and optimization in general.   See https://quick-bench.com/q/sjj2moXIWRyZ3Iw-V80g_978I4U where I tried to prevent those specific optimizations (so it's closer to how the functions are in the C library).
Same with div(). -- https://quick-bench.com/q/9rzsn8kkXJHpv4HMbE9m7AOsOg4 (note had to change it to GCC for [[gnu::noinline]]).
There are also other hidden performance issues in the C library, especially for strings and global state like locale.    But I imagine something like the math functions are almost as fast as they could be?     What about things like like filesystem API? pthreads? sockets?  So lots to think about.


Private registry dependency in virtual workspace generates malformed config.toml

Describe the bug
I've tried setting up a Nix flake based on the Quick Start for a workspace, while also adding a private registry. The flake file is mostly the same as the quick start one, with the following line:
craneLib = crane.mkLib pkgs;

replaced with this, to enable a private registry (some parts redacted):
craneLibBase = crane.mkLib pkgs;
registryToken = builtins.readFile ./secrets/registry-token;
craneLib = craneLibBase.appendCrateRegistries [
  (craneLibBase.registryFromSparse {
    indexUrl = "http://host.domain:1234/index/";
    configSha256 = "<sha256>";
    fetchurlExtraArgs = {
      curlOptsList = [
        "-H"
        "Authorization: ${registryToken}"
      ];
    };
  })
];

The only other changes from the quick start example involve changing the package and crate names to match my workspace layout.
For reference, outside of Nix I normally just have this in my ~/.cargo/config.toml:
[registries]
myrepo = { index = "sparse+http://host.domain:1234/index/" }

And a corresponding credentials.toml set up. The crate in the workspace refers to its dependency as:
dependencyname = { registry = "myrepo", version = "0.1.0" }

The private registry dependencies get pulled and compiled successfully, but I run into this error:
error: builder for '/nix/store/a79k1hs64lf2s2pqnvaxs6rkh2fsh97k-cargo-package-deps-0.1.0.drv' failed with exit code 101;
       last 25 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/m7gn818lw8pzj3gpn7qyajmci7n0nl5x-source
       > source root is source
       > Running phase: patchPhase
       > Executing configureCargoCommonVars
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > will append /build/source/.cargo-home/config.toml with contents of /nix/store/5bm2b5cvn1ywly38mf95q2qqnmw776xq-vendor-cargo-deps/config.toml
       > default configurePhase, nothing to do
       > Running phase: buildPhase
       > ++ command cargo --version
       > cargo 1.80.0 (376290515 2024-07-16)
       > ++ command cargo check --release --locked --all-targets
       > error: could not load Cargo configuration
       >
       > Caused by:
       >   could not parse TOML configuration in `/build/source/.cargo-home/config.toml`
       >
       > Caused by:
       >   TOML parse error at line 8, column 13
       >     |
       >   8 | [source.http://host.domain:1234/index/]
       >     |             ^
       >   invalid table header
       >   expected `.`, `]`
       For full logs, run 'nix-store -l /nix/store/a79k1hs64lf2s2pqnvaxs6rkh2fsh97k-cargo-package-deps-0.1.0.drv'.
error: 1 dependencies of derivation '/nix/store/pn6vf1b6rmbp3ryi3c1p0ify9fqx4b1k-cratename-0.1.0.drv' failed to build

The config.toml in question looks like this:
[source.nix-sources-911ab032f2ab988395c534628be5bc0dd22d9ba803bf4d3780f9e3e9e5e5b994]
directory = "/nix/store/5bm2b5cvn1ywly38mf95q2qqnmw776xq-vendor-cargo-deps/911ab032f2ab988395c534628be5bc0dd22d9ba803bf4d3780f9e3e9e5e5b994"
[source.nix-sources-c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0]
directory = "/nix/store/5bm2b5cvn1ywly38mf95q2qqnmw776xq-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0"
[source.crates-io]
registry = "https://github.com/rust-lang/crates.io-index"
replace-with = "nix-sources-c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0"
[source.http://host.domain:1234/index/]
registry = "sparse+http://host.domain:1234/index/"
replace-with = "nix-sources-911ab032f2ab988395c534628be5bc0dd22d9ba803bf4d3780f9e3e9e5e5b994"

This seems broken to me - the colon in the URL is not allowed in a key name in TOML.
I think this is emitted by this line: https://github.com/ipetkov/crane/blob/7e4586bad4e3f8f97a9271def747cf58c4b68f3c/lib/vendorCargoRegistries.nix#L127
Where escapeShellArg is not successfully escaping the URL because the escaping rules for TOML are more restrictive than those for Bash.
By the way, it seems odd that name is evaluating to a URL, should it perhaps be evaluating to myrepo? One thing I noticed is that the myrepo name is never associated with its URL in the Nix flake, while it is in the native setup. I presume crane can infer that from the Cargo.lock file, but I'm not sure.
It may be worth noting is that the workspace is virtual, and I had to add this to the workspace Cargo.toml to get rid of a few warnings, as crane would not find the version from the individual crates:
[workspace.package]
version = "0.1.0"

It's also very possible that I simply made a mistake somewhere, as I'm quite new to Nix. If that's the case, then I think the error message could be improved.
Reproduction
I don't have a minimal setup for reproduction yet, because it involves owning and running a private registry, which is non-trivial (the flake fails at an earlier step if the registry is unreachable). I'll work on getting a minimal repro case working from scratch soon.

Hi @Palladinium thanks for the report!

By the way, it seems odd that name is evaluating to a URL, should it perhaps be evaluating to myrepo?

Yes I think you are right, that should be showing up as myrepo and not the URL. Maybe we have a bug with the processing logic :thinking:

For reference, outside of Nix I normally just have this in my ~/.cargo/config.toml:

Just double checking, do you have the same contents defined in the project's .cargo/config.toml? During the Nix evaluation we can't actually read ~/.cargo/config.toml (or any other parent directory's .cargo/config.toml) so this does need to be defined somewhere within the repo
Also as a sanity check, could you run cargo vendor 2>/dev/null and share the output here? I just want to double check what cargo expects the configs to look like (and whether there is any toml sensitization happening or if we're pulling the wrong value somewhere)

It may be worth noting is that the workspace is virtual, and I had to add this to the workspace Cargo.toml to get rid of a few warnings,

These warnings are unrelated to the registry issue at hand so we can ignore them here (feel free to open a separate discussion if you have questions though!)

I don't have a minimal setup for reproduction yet, because it involves owning and running a private registry, which is non-trivial

If you could give me the following, it might help me narrow down the problem:

A minimal reproduction of your configs (namely, I want to see how the registry urls are defined, they can be dummy urls, so long as i can trace them during the evaluation)
A minimal version of Cargo.toml, Cargo.lock, and .cargo/config.toml. Again, feel free to replace the real urls with a dummy domain, but as long as everything else maps accordingly
the output of cargo vendor 2>/dev/null as mentioned above

Just double checking, do you have the same contents defined in the project's .cargo/config.toml? During the Nix evaluation we can't actually read ~/.cargo/config.toml (or any other parent directory's .cargo/config.toml)

I only have a ~/.cargo/config.toml, and I don't think it's being read by a nix build. If I modify it and re-run nix build the nix store paths and the URLs in the error stay the same. I tried copying it as a .cargo/config.toml in my repo, both at the virtual workspace URL and in the individual crate directories, but that had the same result (same store paths, no changes in output even when modified). I double-checked after running nix-store --gc, just in case, and got the same results.
I think the only place the URLs for the registry are being read from is the Cargo.lock file, at least during a nix build. I suspect that a nix shell would pick up on the local config.toml, but I'm not sure since I haven't tried setting one up yet. I've already done development on this registry before using Nix, so my Cargo.lock already has the registry URL baked in, see the snippet below.

A minimal reproduction of your configs (namely, I want to see how the registry urls are defined, they can be dummy urls, so long as i can trace them during the evaluation)
A minimal version of Cargo.toml, Cargo.lock, and .cargo/config.toml. Again, feel free to replace the real urls with a dummy domain, but as long as everything else maps accordingly

~/.cargo/config.toml and .cargo/config.toml
[registry]
global-credential-providers = ["cargo:token"]

[registries]
myrepo = { index = "sparse+http://host.domain:1234/index/" }

Cargo.toml at the virtual workspace root
[workspace]
members = [
    "hakari-hack",
    "foo",
    "foo-api",
    "foo-cli"
]
resolver = "2"

# This is to fix one of the warnings about not finding a version number
[workspace.package]
version = "0.1.0"

[profile.release]
debug = 1

foo/Cargo.toml, the only one using a private registry dependency
[package]
name = "foo"
version = "1.0.0"
edition = "2021"

[dependencies]
my_private_crate = { registry = "myrepo", version = "0.1.0" }
foo-api = { path = "../foo-api", default-features = false }

# CUT: Many crates.io dependencies, some feature flag definitions

Cargo.lock
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3

# CUT: Many crates.io dependencies

[[package]]
name = "my_private_crate"
version = "0.1.0"
source = "sparse+http://host.domain:1234/index/"
checksum = "big checksum string"
dependencies = [
  # CUT: Many crates.io dependencies
];

# CUT: Many more crates.io dependencies

the output of cargo vendor 2>/dev/null as mentioned above

[source.crates-io]
replace-with = "vendored-sources"

[source."sparse+http://host.domain:1234/index/"]
registry = "sparse+http://host.domain:1234/index/"
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

I tried to preserve all the relevant parts from configs, it's a bit hard because the crates have a lot of transitive dependencies so the Cargo.toml and Cargo.lock files are very large.

Hi @Palladinium thanks for the sample data!

I tried copying it as a .cargo/config.toml in my repo, both at the virtual workspace root and in the individual crate directories, but that had the same result

Did you, by any chance, remember to git add -N .cargo/config.toml before trying to build again?
Here's an interesting observation I had: when adding the example files above to a directory (and staging it with git so the flake evaluation would see it), the vendor config would include [source.myrepo]. However, if I removed myrepo = { index = "sparse+http://host.domain:1234/index/" } from .cargo/config.toml, then the vendor config would result in [source.http://host.domain:1234/index/]. I suspect this might be the case for your project as well!

File inclusion/staging bugs aside, I think we should ensure that the registry name/url is properly escaped before rendering it to TOML (escapeShellArg isn't enough here). I'm not certain that would result in a valid config that is accepted by cargo (e.g. because the Cargo.toml files would probably be referring to a non-existent registry), but that would lead to much better error messages than malformed TOML!
I have a work in progress on addressing the escaping issues; will try to wrap it up sometime this week

I did some more testing here, looks like if the registry definition is missing from .cargo/config.toml cargo will refuse to build (cargo vendor also fails). Using dependencies.foo = {version = "*", registry = "https://example.com" } in Cargo.toml also fails as cargo expects this to be a registry name (i.e. only alphanumeric chars along with - and _). I've added some better warnings in https://github.com/ipetkov/crane/pull/716 in case the .cargo/config.toml isn't being picked up (e.g. it's missing or it isn't staged with git) which should help highlight the issue!
I've also changed the vendoring logic to avoid creating malformed TOML format, so at least the appropriate cargo error should surface if anyone hits this in the future

Did you, by any chance, remember to git add -N .cargo/config.toml before trying to build again?

Ah, good catch, I did not :sweat_smile: Adding it fixes the issue! Thank you for improving the diagnostics, that's appreciated.

Did you, by any chance, remember to git add -N .cargo/config.toml before trying to build again?

Ah, good catch, I did not :sweat_smile:  Adding it fixed the vendored TOML, although now I'm running into other issues. I'll keep digging into them, and I'll open a separate issue if I hit a dead end.
It might also be worth mentioning the .cargo/config.toml in the example for using alternate registries, the provided nix-init includes one but the manual steps below don't, which is why I originally missed that step.

Ah great point, I've added a note in https://github.com/ipetkov/crane/pull/721 which should helpfully nudge folks in the right direction and avoid the pitfall you hit!


Support normal fights & CHALLENGE_MODE

Hi, I found your package and it looks very promising to me.
Is it right, that the focus of your package is focused on Arena Matches?
It seems I can't use the logLine.on Event on other events like spell damage.
Would it be possible to support log streaming not only on arena (arena_match_started, arena_match_ended) but also on "CHALLENGE_MODE_START" and "CHALLENGE_MODE_END"?
With this it would be possible to use this amazing package also in M+ Dungeons.
I could also provide a sample log of this or help to implement this, but at the moment I got no real clue where to begin for this.

Just to inform you before you make further investigation. I figured out how to enable the events for CHALLENGE_MODE and I am able to log that Lines.
But I also saw that your module is based on arena and much is missing for PVE Parsing. But I think your module is a good base so I will work in my fork and hopefully I can contribute something.
I began already :)

Just to inform you before you make further investigation. I figured out how to enable the events for CHALLENGE_MODE and I am able to log that Lines.
But I also saw that your module is based on arena and much is missing for PVE Parsing. But I think your module is a good base so I will work in my fork and hopefully I can contribute something.
I began already :)

@b1rdhous3 hi there! you are right that the parser is currently very much optimized for arenas. however from an architecture point of view it's more ideal to have a "base parser" that does nothing else but translating raw logs into structured data, and on top of that we build further modeling of arenas and M+. Please feel free to post your design or early prototypes and we'd be happy to discuss and incorporate changes from you!

@b1rdhous3 going to close this issue as we don't have plans to add support for non-arena modes at the moment. If you have a PR with changes you'd like to see in the baseline parser though we're more than happy to disuss!


Schema directives

Landed in https://github.com/metarhia/metasql/commit/7fffa96ed4a17da18cdd17f21a669908b007181d and https://github.com/metarhia/metasql/commit/1f3daf31a8b92cd35109516779933238c88f0f84


Use concrete step data class when injecting requires

Besides raw data, Step.delegate() can accept data class instance too. Converting prepare step to use this method to provide better type safety.
Pull Request Checklist

[x] implement the feature

/packit build


How to use cosine distance?

Hi! I am using OML 3.1.0 to train a pairwise Reranker model and during metrics computation I noticed that only p-norm (moreover - in KNN it is hardcoded to 2-norm) is used as a distance metric and can't be changed and passed as a parameter somewhere:
https://github.com/OML-Team/open-metric-learning/blob/05842c84c980fa2c34510e3de176cd5c5dae9205/oml/utils/misc_torch.py#L127
Are you planning to add other distance metrics, for example cosine similarity? If you think this is a good feature, I can create a PR with those changes (although there are a couple of questions about the way it can be implemented and tested).

@korotaS Thank you for your interest in OML!
From my practical experience, cosine and p=2 norms cover 80% + of real practical cases, so, I don't want to overcomplicate library and bring more distances except for these two at the moment.
If you want to have cosine norm, you should simply normalize model features, because cosine and p2 distances for the normalised vectors are almost the same (they differ on the constant scale factor equal to 2, which doesn't matter). You may google for the simple proof of this fact.
If you want to contribute, you may do something else. For example, I've left a few comments on another issue created by you about interpolation stuff.

Thanks!
Indeed, there was a solution without changing the code, I've missed it.
Closing the issue


While just cloned the repo and tried to run showed this error.

This issue is mistakenly created. The issue is mainly described and solved in #8.


SW-5795 Use dynamic IDs in facility tests

Remove the remaining hardwired IDs from the facility tests (including device
tests) and remove the ability to insert hardwired facility and sub-location IDs.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2284  👈
#2283
#2282
#2281
#2280
#2279
#2278
#2277
#2276
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


[PoC] feat: add web first assertions (#271)

This is an implementation for web first assertions (#271).
An example of usage is bellow,
assertions := playwright.NewPlaywrightAssertions()

err := assertions.ExpectLocator(locator).ToHaveText("example")
if err != nil {
    // handle error
}

The current implementation still works, but I think there are some areas for improvements.
Belows are some of my considerations.

PlaywrightAssertions interface is possibly unneeded.
It may be simpler to call Expect function directory instead of through PlaywrightAssertions interface.

// example

err := playwright.ExpectLocator(locator).ToHaveText("example")

I'm not sure it's more useful to be integrated with *testing.T.
Current implementation returns error to handle it by ourselves.

// example

assertions := playwright.NewPlaywrightAssertions(t) // `t` is `*testing.T`
// no return value, error is reported in `ToHaveText` method
assertions.ExpectLocator(locator).ToHaveText("example")

There may be other improvements other than the above, so please let me know if anyone has some good ideas!

Hi @masaushi ! Good work!

PlaywrightAssertions interface is possibly unneeded.
It may be simpler to call Expect function directory instead of through PlaywrightAssertions interface.
I agree with you.

I'm not sure it's more useful to be integrated with *testing.T.
I think we need to think about that. In my personal opinion, there may be pitfalls. Therefore, I propose to raise this issue separately.

And I have a few additional questions.

Have you considered the following syntax? Since in golang we do not have methods overloading we can slightly change the methods that return assertion. I suggest this use for page, locator and possibly in the future for apiResponse and screenshot. But your way is also good.
// Locator err := Expect.Locator(locator).ToHaveText("example") // Page err = Expect.Page(page).Not().ToHaveTitle("Simple Domain") ...
As you can see from my example above, I propose to make the "Not" method public. This would allow us to make the "assertions" package more compact while maintaining flexibility of use. It also supports by upstream Docs

The both suggestions is my opinion, it would be great to know what the community think about these moments.

Thank you @StanislavTaran for your great review!

Have you considered the following syntax? Since in golang we do not have methods overloading we can slightly change the methods that return assertion. I suggest this use for page, locator and possibly in the future for apiResponse and screenshot. But your way is also good.

Your way is great!
From your way, I come up with a similar idea that is to have expect package for syntax sugar of current assertions implementation.
// in the expect package

package expect

import "github.com/playwright-community/playwright-go"

var Locator playwright.LocatorAssertions
var Page playwright.PageAssertions

func init() {
    // initialize Locator and Page variables
}

// usage example

import "github.com/playwright-community/playwright-go/expect"

func TestSomething(t *testing.T) {

    // something about locator

    err := expect.Locator(locator).ToHaveText("example")
}

But this is just an idea.

I propose to make the "Not" method public. This would allow us to make the "assertions" package more compact while maintaining flexibility of use.

It's good to have public Not() methods!
As you say, having public Not() method seems better than having Not~ methods of each assertion methods for the future maintaining.


1.1 Create a Product model

Essential task for #5
Attributes:

[ ] Name
[ ] Quantity
[ ] Price
[ ] imageUrl
[ ] Description
[ ] (EC) inXCarts (increment when added to cart?)

imageUrl should have a default value


Feature#854  Add COVID-19 information page

Types of changes

[ ] Bugfix
[x] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
Add COVID-19 static pages.
Steps to Test This Pull Request
Steps to reproduce the behavior:

Go to en-us or zh-hant  homepage.
Click on menu bar 『COVID-19 Guidelines』.
Click on footer list  『Privacy Policy』.

Related Issue
#854
More Information
Screenshots

Codecov Report

Merging #864 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   76.37%   76.37%
=======================================
  Files          70       70
  Lines        2688     2688
=======================================
  Hits         2053     2053
  Misses        635      635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac5276...a7394a4. Read the comment docs.

Do you miss the .po file with your commit? I do not see the trans works on your branch.

I fixed all comment tasks


vtgate batch API

This makes vtgate batch API feature-complete. I've also changed the python client API and the tests to be more practical. The keyspace & keyspace_ids used to be bound to a cursor, which is not convenient for multiple queries. The new API instead allows you to specify those for each query.

PTAL again. I've also included the python client changes.

LGTM but I'd feel better if @dumbunny reviewed the python side too :)

@dumbunny https://github.com/youtube/vitess/commit/7d37338d1257fc89e4bfcdaf94209671b9c4052f is the commit where I change the API.

In the interest of time, I'm going to merge this. We can fix forward any issues in the client API.


Fix #1161: Add Atlas Connector

Describe your changes :
Atlas connector will help move metadata in Atlas to OpenMetadata

Type of change :

[x] New feature

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Closing this since Atlas connector has already been added in #2908


Tensor([ 1, nan]).max() should be nan

Tensor([1, np.nan]).numpy().max() -> np.nan
Tensor([1, np.nan]).max().numpy() -> array([1.], dtype=float32)
Wrong output shape aside, it should be nan, not 1.

I just tested this on all the backends I can test on, and it only has the wrong output on the GPU backend.
CLANG uses ((x>y)?x:y) as its max.
GPU uses opencl max which is undefined when arguments are nan.
If I use CLANG's max on GPU it works correctly.

Nope, I think we can change it on GPU + add a test.

I think the deeper question is what tinygrad will accept as the desired result for BinaryOps.MAX or ReduceOps.MAX.
In the presence of some NaN but not all NaNs, I believe the following MAX behaviors can currently be supported:

BACKEND
MAX is not NaN
MAX is NaN

CPU
Yes (using np.nanmax)
Yes (using np.max/amax)

GPU
Yes (using fmax)
Not easily (vectorized select and isnans)

METAL
Yes (using max/fmax)
Not easily (vectorized select and isnans)

CLANG
Yes
Yes (scalar isnans)

LLVM
Yes
No (don't see how llvmlite can generate this)

TORCH
Not easily (missing torch.nanmax)
Yes (using torch.amax)

There's an issue tracking the lack of torch.nanmax here: https://github.com/pytorch/pytorch/issues/61474, even though there is a torch.fmax. The llvmlite IRBuilder doesn't have NaN detection, but llvm.maxnum matches the return non-NaN operand.
Here's some refs:
CPU: https://numpy.org/doc/stable/reference/generated/numpy.nanmax.html, https://numpy.org/doc/stable/reference/generated/numpy.max.html
GPU: https://man.opencl.org/commonMax.html, https://man.opencl.org/fmax.html
METAL: https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf page 161
CLANG: https://clang.llvm.org/docs/LanguageExtensions.html
LLVM: https://llvm.org/docs/LangRef.html#llvm-maxnum-intrinsic
TORCH: https://pytorch.org/docs/stable/generated/torch.fmax.html
Right now there's no choice that will pass on all backends. @geohot what do you think?

I would assume we're trying to reproduce the same functionality of numpy.max()? Also it makes sense to propage NaNs for all associative operations to signal invalid results.

I would assume we're trying to reproduce the same functionality of numpy.max()? Also it makes sense to propage NaNs for all associative operations to signal invalid results.

It should be noted for WebGPU as well: "Parsing error: no definition in scope for identifier: 'nanf'".
Also, the initial commit for WebGPU skips a couple tests because "WebGPU does not have support for inf/nan"

More info:
I ran some tests on the different variations of 'max' in pytorch, tinygrad, and numpy:
Notes:
tinygrad max doesn't handle nans from what I can tell. So it's currently most like torch.fmax, except torch.fmax takes two tensors and gets max element-wise (ignoring nans).
np.nanmax() uses reduce but only returns nan if all elements in a tensor are nan, otherwise it ignores nan elements.
The original ticket was written up because tinygrad max is not handling nans, like numpy max does:
Tensor([1, np.nan]).numpy().max() -> np.nan
Tensor([1, np.nan]).max().numpy() -> array([1.], dtype=float32)
Wrong output shape aside, it should be nan, not 1.
It seems like the best option is either to add a nan check to the existing mlops Max class, or create a new max function. Calling it fmax could be confusing though.
Pytorch:
t1 = torch.tensor([2, 1, np.nan, np.nan])
t2 = torch.tensor([np.nan, 5, 3, np.nan])
torch.max(t1).numpy()               -> array(nan, dtype=float32)
torch.max(t1, t2).numpy()           -> array([nan,  5., nan, nan], dtype=float32)
torch.maximum(t1, t2).numpy()       -> array([nan,  5., nan, nan], dtype=float32)
torch.fmax(t1, t2).numpy()          -> array([ 2.,  5.,  3., nan], dtype=float32)
np.nanmax(t1)                       -> 2.0
Tinygrad:
t1 = Tensor([2, 1, np.nan, np.nan])
t2 = Tensor([np.nan, 5, 3, np.nan])
Tensor.max(t1).numpy()              -> array(2., dtype=float32)
Tensor.max(t1, t2).numpy()          -> array(2., dtype=float32)  (This is comparable torch.fmax)
Tensor.maximum(t1, t2).numpy()      -> array([ 2.,  5.,  3., nan], dtype=float32)
Numpy:
t1 =np.array([[np.nan, 5, 3, np.nan], [2, 2, 2, np.nan]])
np.nanmax(t1) -> 5.0
t1 = np.array([np.nan, np.nan, np.nan, np.nan])
np.nanmax(t1) -> nan
t1 = torch.tensor([1, np.nan, 5, 3])
np.nanmax(t1) -> 5.0
t1 = torch.tensor([np.nan, np.nan, np.nan, np.nan])
np.nanmax(t1) ->  :1: RuntimeWarning: All-NaN axis encountered -> nan

More info:
I ran some tests on the different variations of 'max' in pytorch, tinygrad, and numpy:
Notes:

tinygrad max doesn't handle nans from what I can tell. So it's currently most like torch.fmax, except torch.fmax takes two tensors and gets max element-wise (ignoring nans).
np.nanmax() uses reduce but only returns nan if all elements in a tensor are nan, otherwise it ignores nan elements.

The original ticket was written up because tinygrad max is not handling nans, like numpy max does:
Tensor([1, np.nan]).numpy().max() -> np.nan
Tensor([1, np.nan]).max().numpy() -> array([1.], dtype=float32)

Wrong output shape aside, it should be nan, not 1.

It seems like the best option is either to add a nan check to the existing mlops Max class, or create a new max function. Calling it fmax could be confusing though.
Pytorch:
t1 = torch.tensor([2, 1, np.nan, np.nan])
t2 = torch.tensor([np.nan, 5, 3, np.nan])

torch.max(t1).numpy()               -> array(nan, dtype=float32)
torch.max(t1, t2).numpy()           -> array([nan,  5., nan, nan], dtype=float32)
torch.maximum(t1, t2).numpy()       -> array([nan,  5., nan, nan], dtype=float32)
torch.fmax(t1, t2).numpy()          -> array([ 2.,  5.,  3., nan], dtype=float32)
np.nanmax(t1)                       -> 2.0

Tinygrad:
t1 = Tensor([2, 1, np.nan, np.nan])
t2 = Tensor([np.nan, 5, 3, np.nan])

Tensor.max(t1).numpy()              -> array(2., dtype=float32)
Tensor.max(t1, t2).numpy()          -> array(2., dtype=float32)  **(This is comparable torch.fmax)**
Tensor.maximum(t1, t2).numpy()      -> array([ 2.,  5.,  3., nan], dtype=float32)

Numpy:
t1 =np.array([[np.nan, 5, 3, np.nan], [2, 2, 2, np.nan]])
np.nanmax(t1) -> 5.0

t1 = np.array([np.nan, np.nan, np.nan, np.nan])
np.nanmax(t1) -> nan

t1 = torch.tensor([1, np.nan, 5, 3])
np.nanmax(t1) -> 5.0

t1 = torch.tensor([np.nan, np.nan, np.nan, np.nan])
np.nanmax(t1) ->  <stdin>:1: RuntimeWarning: All-NaN axis encountered -> **nan**


Polygon holes not working when js debugger off

Is this a bug report?
Yes
Have you read the Installation Instructions?

Actual Behavior
When the debugger is off, it doesn't draw a hole in the polygon. but the hole is only drawning when the debugger is on.
error gif: https://streamable.com/jtf4w
Reproducible Demo
import React, { PureComponent } from 'react';
import { InteractionManager } from 'react-native';
import ClusteredMapView from 'react-native-maps-super-cluster';
import { Polygon } from 'react-native-maps';
import isEqual from 'lodash/isEqual';

import { coverageBorders } from '../../../../library/map';

class Map extends PureComponent {
  constructor(props) {
    super(props);

    this.initialRegion = {
      latitude: props.location.coords.latitude,
      longitude: props.location.coords.longitude,
      latitudeDelta: 0.03,
      longitudeDelta: 0.03,
    };
    this.map = null;
    this.state = {
      data: [],
      currentCoordinates: [
        props.location.coords.longitude,
        props.location.coords.latitude,
      ],
      interactionsComplete: false,
      mapHoles: [],
    };
  }

  componentDidMount() {
    InteractionManager.runAfterInteractions(() => {
      this.fetchMoods();

      setTimeout(() => {
        this.setState({ interactionsComplete: true }, () => this.getMapHoles());
      });
    });
  }

  static getDerivedStateFromProps(props, state) {
    const { latitude, longitude } = props.location.coords;

    if (!isEqual(state.currentCoordinates, [longitude, latitude])) {
      return {
        currentCoordinates: [longitude, latitude],
      };
    }

    return null;
  }

  getMapHoles() {
    const coordinates = this.state.currentCoordinates;
    const radius = this.calculateRadius();

    this.setState(prevState => ({ ...prevState, mapHoles: coverageBorders(coordinates, radius) }));
  }

  fetchMoods() { }

  renderMarker = () => { }

  renderCluster = () => { }

  calculateRadius() {
    let radius = this.props.userRadius;

    if (this.props.units === 'miles') {
      radius *= 1.609;
    }
    radius *= 1000;

    return radius;
  }

  render() {
    const { interactionsComplete, mapHoles, data } = this.state;

    if (!interactionsComplete) {
      return null;
    }

    return (
      <ClusteredMapView
        style={{ flex: 1 }}
        data={data}
        initialRegion={this.initialRegion}
        ref={r => (this.map = r)}
        renderMarker={this.renderMarker}
        renderCluster={this.renderCluster}
        showsUserLocation
        showsMyLocationButton={false}
        showsCompass={false}
        moveOnMarkerPress={false}
      >
        <Polygon
          coordinates={[
            { latitude: -89, longitude: -179.99999999 },
            { latitude: 0, longitude: -179.99999999 },
            { latitude: 89, longitude: -179.99999999 },
            { latitude: 89, longitude: 0 },
            { latitude: 89, longitude:<PHONE_NUMBER>9 },
            { latitude: 0, longitude:<PHONE_NUMBER>9 },
            { latitude: -89, longitude:<PHONE_NUMBER>9 },
            { latitude: -89, longitude: 0 },
            { latitude: -89, longitude: -179.99999999 },
          ]}
          key={Date.now()}
          zIndex={100}
          holes={[mapHoles]}
          strokeColor="rgba(0, 0, 0, 0.2)"
          fillColor="rgba(0, 0, 0, 0.4)"
        />
      </ClusteredMapView>
    );
  }
}

I'm having the same issue

I ran into a similar issue where Circle components won't render with the specified fillColor and strokeColor unless JS debugging is on. If I turn off the debugging, the circle will draw but without the desired color. If I turn the debugging back on, all is fine.
I realize this is a different problem than this issue but I wanted to mention it in case there's some correlation.

Issue still present in react-native: 0.60.5 with react-native-maps: 0.25.0

Is funny, I tried to look in the code for any conditionals indicating if the debugger is ON/OFF, but there seems to be none. I also tried to log/alert the value of holes key in the AIRMapPolygon component and the component does indeed receive the holes parameter, both in the JS and native code and both with the debugger on and off. Not sure why it is simply not rendering the holes when the debugger is off even though the param has a value.

This might be a difference between JSCore and V8 (when debugging the code runs actually in chrome which is has the V8 engine )

it seems like the problem is with zIndex, I got it to work on RN 0.59.2 and latest react-native-maps without debugger.

@bargald can you provide more details on this quick fix?

@bargald can you provide more details on this quick fix?

sure.
first of all, I didn't use the example code given by the Author, so I still don't know if that fixes his problem.
I wrote my own code, and showed a polygon with holes on the map. At first I had the same setup as the Author, with zIndex=100 given to the polygon and the error was duplicated, after removing the zIndex property I can see the holes both in release and debug mode.

@bargald alright! thank you mate! I thought you were removing zIndex from the <AIRPolygon> components  🤣
In my case I didn't have the zIndex prop, but I did have lineDashPattern, when I removed this prop the holes showed in both, when debugger is on and also when off, in iOS and also Android.

@randomBrainstormer awesome, glad it helped


Geyser Bedrock user with ip has disconnected for reason Bedrock client timed out

i'm using geyser on my fabric server 1.19
it work one time but now show this error.
Dump file:
https://dump.geysermc.org/bt8NYGdTKAAtGbxKNg8wB5c9Vw6DPXq7
Mods using:
-Phospor
-Lithium
-Easy Auth
-Fabric API
-Inventory sorter (Server Side only)
-Skin Restorer (Server Side only)
-Fat Experience Orbs (Server Side only)
-Geyser
-floodgate (Disable for personal testing)

Unlikely related to Floodgate. You can reopen this on the Geyser-Fabric repository, following the bug report from the main Geyser repository https://github.com/GeyserMC/Geyser/issues/new?assignees=&labels=&template=bug_report.yml


Breaks or not while handling Lambda filter,mapper errors

This change is

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

humilis_push_processor/lambda_function/handler/init.py, line 113 at r1 (raw file):

    if "{{sns_topic_name}}" == "None":
        logger.error("No SNS Topic name provided, layer push-processor "
                     "needs one to report the errors.")

This should be a CriticalError. Otherwise the error will only show up in the logs, which nobody ever looks at without a notification first.

humilis_push_processor/lambda_function/handler/init.py, line 115 at r1 (raw file):

                     "needs one to report the errors.")
    else:
        sns = boto3.client("sns")

Instead of having sns_topic_name as the parameter for the layer I would have sns_topic_arn. Then you avoid calls to boto3, and you can also simplify a bit the CF resources file. Also, since the SNS topic is not part of this application but something set up externally it makes more sense to use the ARN. What if the user wanted to send the notification to an SNS topic in another AWS region? Or in another AWS account?

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

humilis_push_processor/lambda_function/handler/init.py, line 113 at r1 (raw file):
Previously, germangh (German Gomez-Herrero) wrote…
> This should be a CriticalError. Otherwise the error will only show up in the logs, which nobody ever looks at without a notification first.

Done.

humilis_push_processor/lambda_function/handler/init.py, line 115 at r1 (raw file):
Previously, germangh (German Gomez-Herrero) wrote…
> Instead of having sns_topic_name as the parameter for the layer I would have sns_topic_arn. Then you avoid calls to boto3, and you can also simplify a bit the CF resources file. Also, since the SNS topic is not part of this application but something set up externally it makes more sense to use the ARN. What if the user wanted to send the notification to an SNS topic in another AWS region? Or in another AWS account?

I agree, it makes more sense passing the ARN.

Comments from Reviewable


Is project abandoned?

Actually, the title is pretty much self-explanatory. :)

Not at all - there’s a major refactor going on in #486 which will really
push PicoTorrent forward :) As soon as that is finished I will focus more
on new features and requests.
On Fri, 16 Feb 2018 at 13:53, ownmaster<EMAIL_ADDRESS>wrote:

Actually, the title is pretty much self-explanatory. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/picotorrent/picotorrent/issues/521, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABbDcIgBXxoKgr5jZF2GtcEHiLciCVbWks5tVXo5gaJpZM4SISod
.

I've merged #486 now and will focus on adding features that have been outstanding for a while 😄 I'll see if I can do a release quite soon.