Cannot add node group after create cluster and template

Description
In EKS 1.21, when i create this eks cluster it's always create cluster only and template. not include the nodes group
Versions

Terraform: v1.0.7

Provider(s):

Module:

provider registry.terraform.io/hashicorp/aws v3.60.0
provider registry.terraform.io/hashicorp/cloudinit v2.2.0
provider registry.terraform.io/hashicorp/http v2.1.0
provider registry.terraform.io/hashicorp/kubernetes v2.5.0
provider registry.terraform.io/hashicorp/local v2.1.0
provider registry.terraform.io/hashicorp/null v3.1.0
provider registry.terraform.io/hashicorp/template v2.2.0
provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Reproduction

Steps to reproduce the behavior:
Are you using workspaces? yes
Have you cleared the local cache (see Notice section above)? yes
List steps in order that led up to the issue you encountered:

Create requirements for EKS cluster
The config change instance_type to c5.large
use default all config

Code Snippet to Reproduce
module "eks-cluster" {
  source    = "terraform-aws-modules/eks/aws"
  version = "v17.20.0"

  cluster_name  = var.cluster_name
  cluster_version   = var.cluster_version
  cluster_enabled_log_types             = var.cluster_enabled_log_types
  cluster_log_retention_in_days         = var.cluster_log_retention_in_days
  subnets                               = "${aws_subnet.private_subnet.*.id}"
  vpc_id                                = aws_vpc.main.id
  cluster_endpoint_public_access        = var.cluster_endpoint_public_access
  cluster_endpoint_public_access_cidrs  = var.multiple_public_cidrs
  cluster_endpoint_private_access       = var.cluster_endpoint_private_access
  cluster_endpoint_private_access_cidrs = var.multiple_private_cidrs
  write_kubeconfig                      = false
  workers_additional_policies           = var.workers_additional_policies
  worker_additional_security_group_ids  = "${aws_security_group.eks-cluster.*.id}"
  map_roles                             = var.map_roles
  map_users                             = var.map_users

  worker_groups_launch_template = [
    {
      name                                     = var.lt_name
      image_id                                 = var.image_id
      spot_price                               = var.spot_price
      instance_type                            = var.instance_types
      override_instance_types                  = var.override_instance_types
      on_demand_percentage_above_base_capacity = var.on_demand_percentage_above_base_capacity
      asg_min_size                             = var.asg_min_size
      asg_max_size                             = var.asg_max_size
      asg_desired_capacity                     = var.asg_desired_capacity
      autoscaling_enabled                      = var.autoscaling_enabled
      kubelet_extra_args                       = var.kubelet_extra_args
      public_ip                                = var.public_ip
      suspended_processes                      = var.suspended_processes
      root_volume_size                         = var.root_volume_size
      key_name                                 = var.aws_key_name
    },
  ]

  kubeconfig_aws_authenticator_command         = "aws"
  kubeconfig_aws_authenticator_command_args    = ["eks", "update-kubeconfig"]
  kubeconfig_aws_authenticator_additional_args = ["--name", var.cluster_name, "--alias", var.cluster_name]
  kubeconfig_aws_authenticator_env_variables   = {
    AWS_PROFILE        = var.profile
    AWS_DEFAULT_REGION = var.region
  }

  tags = merge(
    {
      Terraform = "true"
    },
    var.tags,
  )
}

Expected behavior
Still not attached into nodes group on EKS Cluster after created
Actual behavior
all version is latest and default, only spot_price i changed, attach subnet and security groups.
Terminal Output Screenshot(s)
# module.eks-cluster.data.http.wait_for_cluster[0] will be read during apply
  # (config refers to values not yet known)
 <= data "http" "wait_for_cluster"  {
      + body             = (known after apply)
      + ca_certificate   = (known after apply)
      + id               = (known after apply)
      + response_headers = (known after apply)
      + timeout          = 300
      + url              = (known after apply)
    }

  # module.eks-cluster.aws_autoscaling_group.workers_launch_template[0] will be created
  + resource "aws_autoscaling_group" "workers_launch_template" {
      + arn                       = (known after apply)
      + availability_zones        = (known after apply)
      + capacity_rebalance        = false
      + default_cooldown          = (known after apply)
      + desired_capacity          = 2
      + force_delete              = false
      + force_delete_warm_pool    = false
      + health_check_grace_period = 300
      + health_check_type         = (known after apply)
      + id                        = (known after apply)
      + max_instance_lifetime     = 0
      + max_size                  = 5
      + metrics_granularity       = "1Minute"
      + min_size                  = 2
      + name                      = (known after apply)
      + name_prefix               = "XX-EKS-Prod-worker-nodes"
      + protect_from_scale_in     = false
      + service_linked_role_arn   = (known after apply)
      + suspended_processes       = [
          + "AZRebalance",
        ]
      + termination_policies      = []
      + vpc_zone_identifier       = (known after apply)
      + wait_for_capacity_timeout = "10m"

      + mixed_instances_policy {
          + instances_distribution {
              + on_demand_allocation_strategy            = "prioritized"
              + on_demand_base_capacity                  = 0
              + on_demand_percentage_above_base_capacity = 90
              + spot_allocation_strategy                 = "lowest-price"
              + spot_instance_pools                      = 10
            }

          + launch_template {
              + launch_template_specification {
                  + launch_template_id   = (known after apply)
                  + launch_template_name = (known after apply)
                  + version              = (known after apply)
                }

              + override {
                  + instance_type = "c5.large"
                }
              + override {
                  + instance_type = "c5.xlarge"
                }
            }
        }

      + tag {
          + key                 = "Environment"
          + propagate_at_launch = true
          + value               = "production"
        }
      + tag {
          + key                 = "Name"
          + propagate_at_launch = true
          + value               = "XX-EKS-Prod-worker-nodes-eks_asg"
        }
      + tag {
          + key                 = "Terraform"
          + propagate_at_launch = true
          + value               = "true"
        }
      + tag {
          + key                 = "k8s.io/cluster-autoscaler/enabled"
          + propagate_at_launch = true
          + value               = "true"
        }
      + tag {
          + key                 = "k8s.io/cluster-autoscaler/mycluster-eks-testing"
          + propagate_at_launch = true
          + value               = "owned"
        }
      + tag {
          + key                 = "kubernetes.io/cluster/XX-EKS-Prod"
          + propagate_at_launch = true
          + value               = "owned"
        }
      + tag {
          + key                 = "kubernetes.io/cluster/mycluster-eks-testing"
          + propagate_at_launch = true
          + value               = "owned"
        }
    }

  # module.eks-cluster.aws_cloudwatch_log_group.this[0] will be created
  + resource "aws_cloudwatch_log_group" "this" {
      + arn               = (known after apply)
      + id                = (known after apply)
      + name              = "/aws/eks/XX-EKS-Prod/cluster"
      + retention_in_days = 7
      + tags              = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + tags_all          = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
    }

  # module.eks-cluster.aws_eks_cluster.this[0] will be created
  + resource "aws_eks_cluster" "this" {
      + arn                       = (known after apply)
      + certificate_authority     = (known after apply)
      + created_at                = (known after apply)
      + enabled_cluster_log_types = [
          + "api",
          + "audit",
          + "authenticator",
          + "controllerManager",
          + "scheduler",
        ]
      + endpoint                  = (known after apply)
      + id                        = (known after apply)
      + identity                  = (known after apply)
      + name                      = "XX-EKS-Prod"
      + platform_version          = (known after apply)
      + role_arn                  = (known after apply)
      + status                    = (known after apply)
      + tags                      = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + tags_all                  = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + version                   = "1.21"

      + kubernetes_network_config {
          + service_ipv4_cidr = (known after apply)
        }

      + timeouts {
          + create = "30m"
          + delete = "15m"
          + update = "60m"
        }

      + vpc_config {
          + cluster_security_group_id = (known after apply)
          + endpoint_private_access   = true
          + endpoint_public_access    = true
          + public_access_cidrs       = [
              + "<IP_ADDRESS>/24",
              + "<IP_ADDRESS>/24",
              + "<IP_ADDRESS>/24",
            ]
          + security_group_ids        = (known after apply)
          + subnet_ids                = (known after apply)
          + vpc_id                    = (known after apply)
        }
    }

  # module.eks-cluster.aws_iam_instance_profile.workers_launch_template[0] will be created
  + resource "aws_iam_instance_profile" "workers_launch_template" {
      + arn         = (known after apply)
      + create_date = (known after apply)
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "XX-EKS-Prod"
      + path        = "/"
      + role        = (known after apply)
      + tags        = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + tags_all    = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + unique_id   = (known after apply)
    }
     # module.eks-cluster.aws_launch_template.workers_launch_template[0] will be created
  + resource "aws_launch_template" "workers_launch_template" {
      + arn                    = (known after apply)
      + default_version        = (known after apply)
      + ebs_optimized          = "true"
      + id                     = (known after apply)
      + image_id               = "ami-08882641c11f81d96"
      + instance_type          = "c5.large"
      + key_name               = "xxxxxxxxx"
      + latest_version         = (known after apply)
      + name                   = (known after apply)
      + name_prefix            = "XX-EKS-Prod-worker-nodes"
      + tags                   = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + tags_all               = {
          + "Environment"                                     = "production"
          + "Name"                                            = "4IP-eks"
          + "Terraform"                                       = "true"
          + "k8s.io/cluster-autoscaler/enabled"               = "true"
          + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
          + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
        }
      + update_default_version = false
      + user_data              = (known after apply)

      + block_device_mappings {
          + device_name = "/dev/xvda"

          + ebs {
              + delete_on_termination = "true"
              + encrypted             = "false"
              + iops                  = 0
              + throughput            = (known after apply)
              + volume_size           = 50
              + volume_type           = "gp2"
            }
        }

      + credit_specification {
          + cpu_credits = "standard"
        }

      + enclave_options {
          + enabled = false
        }

      + iam_instance_profile {
          + name = (known after apply)
        }

      + metadata_options {
          + http_endpoint               = "enabled"
          + http_protocol_ipv6          = "disabled"
          + http_put_response_hop_limit = (known after apply)
          + http_tokens                 = "optional"
        }

      + monitoring {
          + enabled = true
        }

      + network_interfaces {
          + associate_public_ip_address = "false"
          + delete_on_termination       = "true"
          + security_groups             = (known after apply)
        }

      + tag_specifications {
          + resource_type = "volume"
          + tags          = {
              + "Environment"                                     = "production"
              + "Name"                                            = "4IP-eks"
              + "Terraform"                                       = "true"
              + "k8s.io/cluster-autoscaler/enabled"               = "true"
              + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
              + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
            }
        }
      + tag_specifications {
          + resource_type = "instance"
          + tags          = {
              + "Environment"                                     = "production"
              + "Name"                                            = "XX-EKS-Prod-worker-nodes-eks_asg"
              + "Terraform"                                       = "true"
              + "k8s.io/cluster-autoscaler/enabled"               = "true"
              + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
              + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
            }
        }
      + tag_specifications {
          + resource_type = "network-interface"
          + tags          = {
              + "Environment"                                     = "production"
              + "Name"                                            = "4IP-eks"
              + "Terraform"                                       = "true"
              + "k8s.io/cluster-autoscaler/enabled"               = "true"
              + "k8s.io/cluster-autoscaler/mycluster-eks-testing" = "owned"
              + "kubernetes.io/cluster/mycluster-eks-testing"     = "owned"
            }
        }
    }

Additional context
How configure this module that i can attach nodes group into the eks cluster? Thanks

In general you dont use in your config node groups (you defined worker groups, about difference you can read here)
I recommend you also start from checking examples

Thank you, i will try it.


Implement query complexity analysis #324

#324

@pavelnikolov can you review my PR, please?

Hi, @ne0h12
Sorry for the late reply on this PR. Thank you for your effort but I don't feel that the complexity implementation should look like this. Instead after merging #560, I would like it to be possible for users to define their own @complexity directive on FIELD_DEFINITION and ARGUMENT_DEFINITION. This way each user can assign custom complexity and calculate it based on their needs. This library should not impose a particular solution. Instead it should be extendable and allow the users to define this behavior themselves.


json unmarshal lost some fields with UnmarshalJSON used

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
any

What operating system and processor architecture are you using (go env)?
any

What did you do?
https://play.golang.org/p/RbXnSUVtEx

What did you expect to see?
{map[001:{{100 500} test}]}

What did you see instead?
{map[001:{{100 500} }]}

It's OK: https://play.golang.org/p/rrej4sGnr6
Does that mean the embedded fields is unsupported in this case?

maybe op struct take over the UnmarshalJSON .
Is there some way to set default value on a embedded field?

This is working as intended. Methods of the embedded struct (operation) are promoted to the parent struct (op). json.Unmarshal calls op.UnmarshalJSON.


如何训练对话系统并生成数据集？/ How to train the dialogue system and generate a dataset?

📚 The doc issue
如何训练对话系统并生成数据集？/ How to train the dialogue system and generate a dataset?
看了文档 / Read the document： https://github.com/hpcaitech/ColossalAI/tree/main/applications/Chat
看了数据 / Read the document： https://github.com/XueFuzhao/InstructionWild/blob/main/data/seed_prompts_ch.jsonl

这些都测试数据，没有训练数据格式，更没有多轮对话数据格式？  / Are these all test data without training data format, let alone multi round conversation data format?
问怎么训练多轮对话系统呢？/ How to train a multi round dialogue system?

Hi, @gg22mm, you should use datasets described in this file for actual training; it contains formatted training data.

In reward model training, there are normally multiple utterances like here.

Thank you.


allow passing continuous_update= False

also probably should add an option for throttle and debounce
basically starting here: https://ipywidgets.readthedocs.io/en/latest/examples/Widget Events.html#Continuous-updates and adding options for the final three subheadings on that page

need an equivalent for matplotlib widgets tho :/


Schedule azure ABS ad auth token refresh before expiry.

Currently ABS token refresh happens only on expiry. If there are some requests that are in flight when the token expires, the azure libraries throw UnexpectedLengthException. This fix is an attempt to ensure that token refresh happens before expiry so that inflight requests don't see exceptions.

Is it possible to track the expiration time and do token refresh ahead of the expiration. I am thinking if we can avoid scheduled taks.
if (accessToken.getExpiresAt().toEpochSecond() - OffsetDateTime.now().toEpochSecond() < threshold) {
     refreshStorageClient();
}

Is it possible to track the expiration time and do token refresh ahead of the expiration. I am thinking if we can avoid scheduled taks.
if (accessToken.getExpiresAt().toEpochSecond() - OffsetDateTime.now().toEpochSecond() < threshold) {
     refreshStorageClient();
}

The problem with that is that there are multiple threads using the token at the same time. We will have to proactively check the token expiry every time we make a request to ABS. In case the token is within expiry threshold (meaning we need to expire token because expiry remaining time < threshold), we will have to check if some other thread is already doing the token refresh, and then wait for that thread.
Instead of doing that, with the current logic, all threads will just use the existing the token and make requests to ABS without any checks. The token refresh will happen in the background, and atomically updated so that new requests take the new token automatically. I wanted to avoid the problem of tracking multiple threads and some other multithreading nuances that come with it. Hence this solution.

Is it possible to track the expiration time and do token refresh ahead of the expiration. I am thinking if we can avoid scheduled taks.
if (accessToken.getExpiresAt().toEpochSecond() - OffsetDateTime.now().toEpochSecond() < threshold) {
     refreshStorageClient();
}

The problem with that is that there are multiple threads using the token at the same time. We will have to proactively check the token expiry every time we make a request to ABS. In case the token is within expiry threshold (meaning we need to expire token because expiry remaining time < threshold), we will have to check if some other thread is already doing the token refresh, and then wait for that thread.
Instead of doing that, with the current logic, all threads will just use the existing the token and make requests to ABS without any checks. The token refresh will happen in the background, and atomically updated so that new requests take the new token automatically. I wanted to avoid the problem of tracking multiple threads and some other multithreading nuances that come with it. Hence this solution.

You could potentially use an atomic swap to guarantee only one thread does the operation:
AtomicLong lastRefreshTime;

long lastRefreshSnapshot = lastRefreshTime.get();
long currentTime
if (eligibleForNewUpdate(lastRefreshSnapshot, currentTime)) {
  if (lastRefreshTime.compareAndSet(lastRefreshSnapshot, currentTime) {
    doRefresh()
  } else {
    // we know someone else already did it
  }
}


Extract the filename of a filepath

Example:
ext, err := getFilename(filepath)
if err != nil {
  log.Error(err)
}
fmt.Println(ext)

Acceptance Criteria

[ ] Make the function be part of the internal/utils.go pkg
[ ] If the filepath doesn't exist, return an error
[ ] For logging use https://github.com/Sirupsen/logrus
[ ] Verify the extension doesn't contain any . dots
[ ] Write a unit test
[ ] Make sure there are testable examples
[ ] For specific errors, make the part of the internal/errors pkg as consts

Hints:

You don't need to check if the filepath truly exists.
As an exercise, try to write the test first. Let it fail. Then try to fix it, by writing the actual implementation of the function.
For logging https://linuxhint.com/golang-logrus-package/

Built-in using either

filepath.Base()
See playground

path := "/some/path/to/remove/file.name"
file := filepath.Base(path)
fmt.Println(file)
// Output: file.name

or filepath.Split()
See playground

dir, file := filepath.Split("/some/path/to/remove/file.name")
fmt.Println(dir)
// Output: /some/path/to/remove/

fmt.Println(file)
// Output: file.name


Prepare release v0.6.0

:tada:

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

bors r+

Released to crates.io :tada:


Ensure messages are not displayed and awaited upon in activate methods

When using the IExtensionActivationService interface ensure messageboxes are not displayed and awaited upon in the activate method.
Else this will block loading the extension until the message is dismissed.
Note: We have already created custom linter rules for the extension.
Also note, if the user doesn't dismiss the message, it will get hidden and user will not know why extension fails to load.

Closing as stale


Sometimes, the game crashes because of a negative Aabb or something similar

Observed while:

Zooming in past the maximum distance
Jumping down from the level

Closing for the moment, since I cannot reproduce it since #151
Feel free to re


chore: bdd-spring-1568368142 to 0.0.1

chore: Promote bdd-spring-1568368142 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Install the Application proxy connector in US government cloud

Customer would like much easier access to the page.  He suggested we change the title for example " Install the Application proxy connector in US government cloud". He stated that it took him longtime to find the government instruction on how to install the App proxy connector.
https://learn.microsoft.com/en-us/azure/active-directory/hybrid/reference-connect-government-cloud#install-the-agent-for-the-azure-government-cloud

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f7ed0d10-41ff-a423-f2fe-ad3623531aa9
Version Independent ID: c09b4722-8ece-7420-3595-8fcfca3181e6
Content: Azure AD Connect: Hybrid identity considerations for Azure Government cloud - Microsoft Entra
Content Source: articles/active-directory/hybrid/reference-connect-government-cloud.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@gtoud
Thanks for your feedback! We will investigate and update as appropriate.

@gtoud
Thank you for your suggestion. It would be helpful to provide your ideas in the below link so our product team will work on it.
https://feedback.azure.com/d365community


[CircularProgress] color prop not working as expected

Duplicates

[X] I have searched the existing issues

Related page
https://mui.com/material-ui/api/circular-progress/
Kind of issue
Unclear explanations
Issue description
The docs say the color prop works like this:

But when testing, only certain values work (primary, warning, and success work). For the other values that don't work (inherit, info, error, and secondary), the classes are being applied/the component is rendered when checking the DOM. But, the component is no longer visible to the eye.

Context 🔦
I am trying to render the CircularProgress component in a list. I'd like to be able to change the color of the component, but I don't necessarily need a whole custom theme. The built-in options for the color prop were theoretically fine. I can refer to the docs for customizing this component. Thank you!
There are other issues that reference the color prop with different components and other issues related to the props CircularProgress can receive, but neither seemed identical per se. Please let me know if this should be a comment on one of those issues.

I faced the same issue. Passing the color via the sx works like a charm:
  <CircularProgress  sx={{ color: "white" }} />

It does not use a proper color:
  <CircularProgress color="white" />

@EvgeneOskin white is not supported as a color value for CircularProgress. Please check out the API docs - https://mui.com/material-ui/api/circular-progress/#CircularProgress-prop-color. It works with the sx prop because with that it is CSS color value you are applying.

To bring more context, I have white defined as a custom color in the palette.
color accepts string, so I face no errors or notifications, only no applied color.

@EvgeneOskin Could you create a CodeSandbox example that demonstrates the problem you're facing? You can use the issue template as a helpful starting point. This will ensure that we have a clear understanding of your issue and can assist you more effectively.


TP - removes deep zone coverage file checkbox from cache group form

What does this PR (Pull Request) do?
removes dzcf checkbox as it is not a real indicator of whether or not dczf is enabled on a cachegroup.
also, did some refactoring to clean up how the localization methods are added/removed from the cachegroup object when the checkboxes are clicked.

[x] This PR fixes #3067

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?
The following criteria are ALL met by this PR

[ ] This PR includes tests OR I have explained why tests are unnecessary
[ ] This PR includes documentation OR I have explained why documentation is unnecessary
[ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4881/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4882/


Add topic "PSR-4"

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I'm changing.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

PSRs are a widely used standard for the PHP community.

Something that does not neatly fit into the binary options above

[x] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Same question as #3879 , are these really curation-worthy topics?

Well, it is used in 162 repositories—that's not an awful lot but not nothing. The rule of thumb from the docs just says:

We are likely to consider suggestions to curate a topic or collection that is valuable to GitHub's community. Valuable topics, for example, include those that are already widely used by repositories and could benefit from the addition of important information. When suggesting content, please consider how to make your contribution broadly useful and relevant to others, rather than serving a specific use case.

After all, PSR is a central topic to PHP developers. However, if one doesn't happen to be a PHP developer, that topic is—unsurprisingly—everything but relevant to them. I curated the topics because I already curated other PSR topics and did so for the sake of consistency but refrained from curating PSR topics below three digit repository amounts.

By the way: What do you consider a "sufficiently valuable/curation-worthy" topics in terms of repository count?
Aside from this PR, I would like to add this number (preferably a lower and upper bound) to my tool: https://shaedrich.gitlab.io/github-uncurated-topics/user-topics.html

This is just my opinion, but I like to see more than 1000 repos in the topic. At 500 I feel it's questionable but will probably merge if it is a good PR; under 300 is quite a small niche.

Thanks, I didn't want to make you do anything you doubted. I didn't know, what exactly was the right number—so thanks for clarifying that! I'll keep that in mind for next time.


KAFKA-10173: Fix suppress changelog binary schema compatibility

We inadvertently changed the binary schema of the suppress buffer changelog
in 2.4.0 without bumping the schema version number. As a result, it is impossible
to upgrade from 2.3.x to 2.4+ if you are using suppression.

Refactor the schema compatibility test to use serialized data from older versions
as a more foolproof compatibility test.
Refactor the upgrade system test to use the smoke test application so that we
actually exercise a significant portion of the Streams API during upgrade testing
Add more recent versions to the upgrade system test matrix
Fix the compatibility bug by bumping the schema version to 3

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I'm still cleaning up this PR. I'll call for reviews when it's ready.

test this

Hmm. Still saw the OOME in https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/3134/

Retest this please

Ah, that heap space thing was legit. Fix coming...

Hey @guozhangwang , you might want to take a look at that last fix. The duck-typing code was producing an OOME some times, when it would just interpret a random integer out of the buffer as a "size" (integer) and blindly allocate an array of that size.
I added a Util (with tests) that has a guard to prevent this.

I will follow up shortly to extract the system tests to a separate PR, since we're having trouble running the tests at all right now, and we wouldn't know if they are even more broken.

Ok, @guozhangwang , This is my "final" iteration. I pulled the system tests out, and I'll follow up with another PR later. This PR should be sufficient for the basic purpose, thanks to the new "binary" compatibility unit tests.

Failures were unrelated:
kafka.api.PlaintextConsumerTest > testLowMaxFetchSizeForRequestAndPartition FAILED
    org.scalatest.exceptions.TestFailedException: Timed out before consuming expected 2700 records. The number consumed was 1077.
        at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:530)
        at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:529)
        at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1389)
        at org.scalatest.Assertions.fail(Assertions.scala:1091)
        at org.scalatest.Assertions.fail$(Assertions.scala:1087)
        at org.scalatest.Assertions$.fail(Assertions.scala:1389)
        at kafka.api.AbstractConsumerTest.consumeRecords(AbstractConsumerTest.scala:158)
        at kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition(PlaintextConsumerTest.scala:804)

org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest > testReplication FAILED
    java.lang.RuntimeException: Could not find enough records. found 0, expected 100
        at org.apache.kafka.connect.util.clusters.EmbeddedKafkaCluster.consume(EmbeddedKafkaCluster.java:435)
        at org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication(MirrorConnectorsIntegrationTest.java:217)

kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition

org.apache.kafka.streams.integration.HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores

org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInConnectorStop

backported to 2.6, 2.5, and 2.4. I ran the streams and client tests each time, as well as systemTestLibs.


Ubuntu 20.04

After fixing the wrong python-software-properties package it's not possible to install deps

Building dependency tree
Reading state information... Done
software-properties-common is already the newest version (<IP_ADDRESS>).
The following package was automatically installed and is no longer required:
  libfprint-2-tod1
Use 'sudo apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 55 not upgraded.
==> Found Ubuntu version 20.xx
Reading package lists... Done
Building dependency tree
Reading state information... Done
software-properties-common is already the newest version (<IP_ADDRESS>).
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libgraphicsmagick1-dev : Depends: libxml2-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

It works on my Ubuntu 20.04 after comment one line in install-deps
#sudo apt-get install -y python-software-properties

I am getting:
E: Package 'libqt4-dev' has no installation candidate
E: Package 'ipython' has no installation candidate

I am getting:
E: Package 'libqt4-dev' has no installation candidate E: Package 'ipython' has no installation candidate

Me too, any help please?

I am getting:
E: Package 'libqt4-dev' has no installation candidate E: Package 'ipython' has no installation candidate

I met the same problem. How can I solve it?

Anyone got the fix for that ? The libqt4 has a fix : [https://stackoverflow.com/questions/75017058/torch-ubuntu-install-deps-package-ipython-has-no-installation-candidate](fix here to libqt4)
But Ipython stays a problem. Did anyone figure it out ?

Did you solve the ipython issue?


Migration from stripe 4.0 to latest stripe 8.x

I have not updated stripe from a long time and i now it seems that paymentkit is integrated into stripe. So i have used multiple things from paymentkit and i am not able to find proper thing how to migrate the code. I have some queries below.

I am using PTKCardNumber like
let cardNumber:PTKCardNumber = PTKCardNumber(string:strCardNumber)
PTKCardTypeAmex like to determine which card is it.
PTKTextField for the card like
PTKTextField.textByRemovingUselessSpacesFromString(str as String)

What is used in place of above this all in new stripe?

See https://github.com/stripe/stripe-ios/issues/467


Support multicall3 on pulsechain mainnet

Chain Name
PulseChain Mainnet
Chain ID
369
RPC URL
https://rpc.pulsechain.com
Block Explorer URL
https://scan.pulsechain.com/
Deployment Funds
Yes

@mds1 Hi, could you please take a look?

My understanding from https://github.com/mds1/multicall/issues/43#issuecomment-1516703859 is that pulsechain is a fork of Ethereum, which seems to be confirmed by this:
code1=$(cast code 0xcA11bde05977b3631167028862bE2a173976CA11 --rpc-url https://rpc.pulsechain.com)
code2=$(cast code 0xcA11bde05977b3631167028862bE2a173976CA11 --rpc-url $MAINNET_RPC_URL)

if [ "$code1" = "$code2" ]
then
    echo "Code matches"
else
    echo "Code does not match"
fi

which prints Code matches. If that's correct, then I think I just need to update the deployment file with other pulsechain networks?

Hi @mds1 thanks for your feedback.
Yes, you're right. PulseChain is a fork of Ethereum so we can use the same multicall3 address.
Anw, do you have to release a new version to support the above PR?

Sorry, what do you mean? It seems Multicall3 is currently on pulsechain mainnet at the regular 0xcA11bde05977b3631167028862bE2a173976CA11 address

My understanding is that we have to update this to new version. But I'm not sure about it. Could you please let me know how I can use?

If you can provide a list of (chain name, chain ID, block explorer URL, RPC URL) for all pusechain networks (mainnet/testnet) I can check if multicall3 is on each one and update the deployments list accordingly

For now, only pulsechain mainnet (chainId: 369) & testnet (chainId: 943).

My understanding is that we have to update this to new version. But I'm not sure about it. Could you please let me know how I can use?

Ah I see. I'm not to familiar with the python ethereum ecosystem, but it seems that package is here: https://github.com/banteg/multicall.py
From a quick look at https://github.com/banteg/multicall.py/blob/master/multicall/constants.py#L115-L168, I don't see pulsechain, but you might be able to configure your own contract instance. I'd recommend asking in that repo :)

I've also updated the deployments file to include pulsechain mainnet, so closing this issue

@mds1 thank you. I'm clear for now.


Added check for empty spike train in corrcoef

This pull request adds a check for empty spike trains in corrcoef function of the module spike_train_correlation. With a new option with_nans a user can choose between the old behavior, which performs full calculation independently of presence of empty spike trains, and the new functionality:

If an empty spike train is detected, a UserWarning is raised.
The function returns a boolean array of a length equal number of spike trains with True for non-empty and False for empty spike trains.

Hello @PaulinaDabrowska! Thanks for submitting the PR.

In the file elephant/spike_train_correlation.py, following are the PEP8 issues :

Line 114:77: W291 trailing whitespace
Line 115:77: W291 trailing whitespace
Line 116:78: W291 trailing whitespace
Line 117:35: W291 trailing whitespace
Line 128:77: W291 trailing whitespace
Line 152:1: W293 blank line contains whitespace
Line 173:80: E501 line too long (93 > 79 characters)
Line 196:1: W293 blank line contains whitespace
Line 219:16: E231 missing whitespace after ','
Line 220:16: E231 missing whitespace after ','
Line 287:80: E501 line too long (85 > 79 characters)
Line 346:72: W291 trailing whitespace
Line 347:70: W291 trailing whitespace
Line 353:80: E501 line too long (85 > 79 characters)
Line 357:80: E501 line too long (91 > 79 characters)
Line 393:80: E501 line too long (83 > 79 characters)
Line 411:1: W293 blank line contains whitespace
Line 413:61: W291 trailing whitespace
Line 415:10: E221 multiple spaces before operator
Line 424:51: E201 whitespace after '('
Line 424:79: E202 whitespace before ')'
Line 424:80: E501 line too long (80 > 79 characters)
Line 426:1: W293 blank line contains whitespace
Line 427:1: W293 blank line contains whitespace
Line 428:5: E303 too many blank lines (2)
Line 492:13: E741 ambiguous variable name 'l'
Line 498:13: E741 ambiguous variable name 'l'
Line 601:17: E741 ambiguous variable name 'l'
Line 606:17: E741 ambiguous variable name 'l'
Line 660:1: E305 expected 2 blank lines after class or function definition, found 1

In the file elephant/test/test_spike_train_correlation.py, following are the PEP8 issues :

Line 226:15: E231 missing whitespace after ','
Line 226:17: E231 missing whitespace after ','
Line 226:19: E231 missing whitespace after ','
Line 233:80: E501 line too long (99 > 79 characters)
Line 237:1: W293 blank line contains whitespace
Line 265:1: W293 blank line contains whitespace
Line 296:80: E501 line too long (82 > 79 characters)
Line 325:9: E303 too many blank lines (2)
Line 326:56: W291 trailing whitespace
Line 327:33: E261 at least two spaces before inline comment
Line 331:70: W291 trailing whitespace
Line 333:33: E128 continuation line under-indented for visual indent
Line 333:40: E251 unexpected spaces around keyword / parameter equals
Line 333:42: E251 unexpected spaces around keyword / parameter equals
Line 333:59: E251 unexpected spaces around keyword / parameter equals
Line 333:61: E251 unexpected spaces around keyword / parameter equals
Line 333:71: W291 trailing whitespace
Line 335:33: E128 continuation line under-indented for visual indent
Line 335:40: E251 unexpected spaces around keyword / parameter equals
Line 335:42: E251 unexpected spaces around keyword / parameter equals
Line 335:59: E251 unexpected spaces around keyword / parameter equals
Line 335:61: E251 unexpected spaces around keyword / parameter equals
Line 335:71: W291 trailing whitespace
Line 338:55: E251 unexpected spaces around keyword / parameter equals
Line 338:57: E251 unexpected spaces around keyword / parameter equals
Line 339:54: E251 unexpected spaces around keyword / parameter equals
Line 339:56: E251 unexpected spaces around keyword / parameter equals
Line 341:49: E231 missing whitespace after ','
Line 341:52: W291 trailing whitespace
Line 342:1: W293 blank line contains whitespace
Line 343:80: E501 line too long (81 > 79 characters)
Line 345:33: E128 continuation line under-indented for visual indent
Line 345:40: E251 unexpected spaces around keyword / parameter equals
Line 345:42: E251 unexpected spaces around keyword / parameter equals
Line 345:61: W291 trailing whitespace
Line 346:33: E128 continuation line under-indented for visual indent
Line 346:39: E251 unexpected spaces around keyword / parameter equals
Line 346:41: E251 unexpected spaces around keyword / parameter equals
Line 346:75: W291 trailing whitespace
Line 348:33: E128 continuation line under-indented for visual indent
Line 348:40: E251 unexpected spaces around keyword / parameter equals
Line 348:42: E251 unexpected spaces around keyword / parameter equals
Line 348:61: W291 trailing whitespace
Line 349:33: E128 continuation line under-indented for visual indent
Line 349:39: E251 unexpected spaces around keyword / parameter equals
Line 349:41: E251 unexpected spaces around keyword / parameter equals
Line 357:23: E221 multiple spaces before operator
Line 357:57: W291 trailing whitespace
Line 358:32: E128 continuation line under-indented for visual indent
Line 359:13: E741 ambiguous variable name 'l'
Line 362:1: W293 blank line contains whitespace
Line 364:9: E303 too many blank lines (2)
Line 391:80: E501 line too long (82 > 79 characters)

Coverage decreased (-0.003%) to 87.043% when pulling cd38122a06197f6c35af5bee5bc2e938b8ad1ce0 on INM-6:fix/corrcoef into e54495bbdb3361c5e4ee6bcd5479f3ff1297dad8 on NeuralEnsemble:master.

Coverage decreased (-0.003%) to 87.043% when pulling cd38122a06197f6c35af5bee5bc2e938b8ad1ce0 on INM-6:fix/corrcoef into e54495bbdb3361c5e4ee6bcd5479f3ff1297dad8 on NeuralEnsemble:master.

@mdenker since you are the original author of the corrcoef function and I am also involved in this contribution I would like to have you a look.

Done, no more conflicts for now.

Hi,
I updated the function: with_nans is removed and an array of correlation coefficients is always returned. If some spike train is empty, a warning is issued, respective row and column of the output array filled with nans, and no calculation for this spike train is performed.

The checks fail, but they fail in cross-correlation histogram test case, which I did not touch.

With the fixes in the current master branch, all checks pass again.


Option for making all class as local classes

I dont want to type :local all the times, so I wonder if we can have an option for making all classes as local classes. We can have include option to apply for only some specific folders.

Is the modules parameter what you are after? It outputs local classes by default.

Thanks, I got it. It has been a long time since I used it and I didn't read the docs carefully again. My bad, closing.


Could u upload your annotation file here

When I train ：
File "train.py", line 152, in
train()
File "train.py", line 126, in train
loss_l, loss_c = criterion(out, priors, targets)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/research/pytorch-faceboxes/FaceBoxes.PyTorch/layers/modules/multibox_loss.py", line 107, in forward
loss_c = F.cross_entropy(conf_p, targets_weighted, size_average=False)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/functional.py", line 1970, in cross_entropy
return nll_loss(log_softmax(input, 1), target, weight, None, ignore_index, None, reduction)
File "/usr/local/lib/python2.7/dist-packages/torch/nn/functional.py", line 1790, in nll_loss
ret = torch._C._nn.nll_loss(input, target, weight, _Reduction.get_enum(reduction), ignore_index)
RuntimeError: invalid argument 2: non-empty vector or matrix expected at /pytorch/aten/src/THCUNN/generic/ClassNLLCriterion.cu:32

Hi @lijie2160, could you check if the baiduyun link works for you? It’s at the end of the readme file.

Hi Could you please let me know what is the problem here?
Thanks!

did you solve this problem?if,how to do?Thanks!

hi, i miss the same problem,did you solve it?


Change base ubuntu version in Dockerfile from utopic to vivid

utopic is no longer supported (although still appearing in the docker hub), when running apt-get update inside the docker I get many 404 messages such as:
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/utopic/main/source/Sources  404  Not Found [IP: <IP_ADDRESS> 80]
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/utopic/restricted/source/Sources  404  Not Found [IP: <IP_ADDRESS> 80]
W: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/utopic/universe/source/Sources  404  Not Found [IP: <IP_ADDRESS> 80]

Changed FROM to vivid, everything works as expected now.

Automated message from Dropbox CLA bot
@mtngld, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here and update the thread so we can consider merging your code.

I confirmed that CLA was signed, thanks!
I don't have a Linux environment to test on, but I trust that you tested it as you described.


Support importing v2 snapshot even when global_property_object::proposed_schedule is not empty

PR #7404 introduced the WTMSIG_BLOCK_SIGNATURES protocol feature and in doing so required changes to the global_property_object. The intention of the changes in that PR were to still successfully import old serialized global_property_objects in v2 snapshots and upconvert as necessary to store as the new global_property_object in the state database. However, the code path to handle the legacy version in v2 snapshots does not actually exist. The reason it is still possible to import v2 most of the time (and indeed possible in the tests that explicitly test this) is due to the fact that the serialization of global_property_object in the new and old versions are the same if proposed_schedule.producers is the empty vector.
Code to explicitly add support for importing in the old global_property_object from v2 snapshots needs to be added to controller_impl::read_from_snapshot which will upconvert legacy:: producer_schedule_type to producer_authority_schedule (similar to how it is done already for the block_state). Furthermore, a test should be added (or existing one modified) to verify that import of a v2 snapshot is successful if the proposed_schedule.producers is not empty.

Resolved by https://github.com/EOSIO/eos/pull/7717.


Add support for video files

Issue #125
I have created a simple component for video support.
Please take a look and let me know if there's anything missing or needs improvement.
After

Before

@hatsu38 Merged! Thanks for your contribution!


dts: bindings: video: Add common video interface binding

Currently, there is no common binding for video endpoint interfaces.
Some video driver defines these properties in their own binding, such as https://github.com/zephyrproject-rtos/zephyr/pull/71462.
This binding provides the most common properties needed to configure an endpoint subnode for data exchange with other device. For example, the bus-type property is required by https://github.com/zephyrproject-rtos/zephyr/issues/74353. The data-lanes prorperty is required by https://github.com/zephyrproject-rtos/zephyr/pull/76475, etc.
The endpoint subnodes which use this binding need to remove the "remote-endpoint" phandle property (which is actually not supported in Zephyr) and use the "remote-endpoint-label" property instead as Zephyr devicetree currently does not support circular dependency and will cause compiling errors

Related to https://github.com/zephyrproject-rtos/zephyr/pull/71462

@loicpoulain Could you take a look at this ?
Could someone add an assignee to the PR, please as I don't have right to do it ? @dleach02 @decsny

@loicpoulain Could you take a look at this ?
Could someone add an assignee to the PR, please as I don't have right to do it ? @dleach02 @decsny

Now I can... Done !

@josuah I completely understand why you would want to use the string enum from the Zephyr bindings or even switch some of these to boolean types, but I think one of the project's goals is to strive to be compatible with linux (and other existing projects) bindings. I guess the pipe dream is that people can reuse their linux DT definition to move to Zephyr without any hiccups in DT, I don't know how realistic that is (especially considering there is a ton of other zephyrisms in our DT that totally wreck it anyways) but it's the current aspiration.

one of the project's goals is to strive to be compatible with Linux

Thank you for this beacon! I try to guess the goals, and I get mistaken in the priorities.
Now I know better what to follow: Whenever there is an existing Linux binding, try to stay as close as possible to these. For new bindings, there is more freedom to use more Zephyr-like DT APIs.

technically the DT spec says this should be done also

That sounds like being this page, good to note.
https://docs.zephyrproject.org/latest/build/dts/design.html#source-compatibility-with-other-operating-systems

Zephyr’s devicetree tooling is based on a generic layer which is interoperable with other devicetree users, such as the Linux kernel.

@ngphibang sorry for inviting you towards the wrong direction in these few PRs.
It looks like I was under-estimating the goal of Linux compatibility.
This also answers "how to design the best Zephyr APIs": also strive to be similar (i.e. function naming, mechanisms) with Linux and other systems when possible. :)

@decsny @ngphibang are you two converging so we can move this PR along?

@dleach02 : I am making change according to request from @decsny. Will push soon.

I looked into this a bit and I see the limitation of using child-binding here, and maybe why the other zephyr bindings have compatibles like this, the issue appears to be that the zephyr DT binding syntax doesnt allow declaring nodes as properties like in linux, maybe this is something that should be added to zephyr DT binding yaml language, but for now the PR is fine


Can not find plugins

When deploying k8spacket in our cluster its not able to find the needed plugins, however they are available in the plugins directory
I'm getting this error message
2024/03/27 12:58:02 [k8spacket] [plugins] Cannot find plugin TLSConsumerPlugin, gave up. plugin: symbol TLSConsumerPlugin not found in plugin github.com/k8spacket/plugins/nodegraph
2024/03/27 12:58:02 [k8spacket] [plugins] Cannot find plugin TCPConsumerPlugin, gave up. plugin: symbol TCPConsumerPlugin not found in plugin github.com/k8spacket/plugins/tls-parser

When moving the plugins into the directory where the k8spacket binary lives, I wont get this message. However the application fails to start up with the following error.
2024/03/27 13:29:27 [k8spacket] [api] Serving requests on port 6676
2024/03/27 13:29:27 [k8spacket] INIT inet
2024/03/27 13:29:27 [k8spacket] [inet] Cannot attach tracepoint: neither debugfs nor tracefs are mounted
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1e3e94f]

goroutine 8 [running]:
github.com/k8spacket/k8spacket/ebpf/inet.Init()
	/home/k8spacket/ebpf/inet/inet.go:54 +0x1af
created by github.com/k8spacket/k8spacket/ebpf.LoadEbpf in goroutine 1
	/home/k8spacket/ebpf/loader.go:20 +0x1a

What might be the problem here?
System:
AWS EKS
AmazonLinux 2
Deployed with helm

Additionally, what version of Linux kernel is there on your AmazonLinux VMs?
Remember about the limitation kernel version >= 5.8

Will try to change this.
And we are using 5.10

Tried to change the volume mounts and now I'm getting the following error.
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to s │
│ tart container process: error during container init: error mounting "/sys/kernel/debug/tracing" to rootfs at "/sys/kernel/debug/tracing": mkdir /run/containerd/io.containerd.runtime.v2.task/k8s │
│ .io/k8spacket/rootfs/sys/kernel/debug/tracing: no such file or directory: unknown

when checking the instance itself, the directory is available

Ok, my fault.
The path mounted from the node should be /sys/kernel/debug/tracing, but the container should see it on the path: /sys/kernel/tracing
It should look like:
spec:
  template:
    spec:
      containers:
. . .
        volumeMounts:
. . .
        - mountPath: /sys/kernel/tracing
          name: tracing
      volumes:
. . .
      - hostPath:
          path: /sys/kernel/debug/tracing
          type: ""
        name: tracing

Thanks, that fixed it.
I'm playing around currently with that tool, but when we want to use this in some more automated way, I will need to find a way to configure those values.
Are you open that I should open an PR for that?

Of course.
It is a great idea to add volumes and volumeMounts to values.yaml.

Thank you for this

Thanks for the support. This works now.


macro compile error

Empire Version
2.1 (29 August 2017)
OS Information (Linux flavor, Python version)
Kali Linux 2017.1, Python 2.7
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
TL;DR: Office macro script has a syntax error. Because of that not working.
Attacking machine: Kali Linux 2017.1
Target machine: Windows 7 with Office 2016
There is no communication problem between attacker&target when I use "multi/launcher" or "windows/launcher_bat". But when I use "windows/macro", include it to a Word&Excel file and enabled macro, nothing happens. I tried to trigger the macro by hand, I got following error: https://imgur.com/a/68Fwc
I tried with Obfuscation, without Obfuscation, they all have same error

yeah I see the issue. Failing macro has single quotes vs double quotes. Looking into this. Thank you.

Fixed!

@rvrsh3ll Now I don't get any compiling error but macro still not working. I don't see any connection attempt when I listen the traffic with Wireshark. Any ideas?

Screenshots of your network adapter settings and listener settings please

Well that's weird, when I click "Enable Macros" button nothing happens but if I manually go to Macros tab and run by hand, it works. Probably something with Office 2016 (new update or something), not the Empire.

Same issue for me , but target is Mac OS with Microsoft Word 2011 , when i enable macro nothing happends ; but i go manually in the macro tab and hit play, an agent will connect back :/


fix: handle the sorting of transformed files

We can't use the ext property, since that is transformed, but the history is maintained.
This PR should be merged before https://github.com/freeCodeCamp/freeCodeCamp/pull/44720

So, I managed to confuse myself about what gets polyed where.  To simplify matters, it now all happens as the challenge is built. Then Gatsby can get whatever it needs (history, for instance) whenever it needs it.


ENG-648 add error if sharing with user that has no keys setup

Summary
Currently, if a user tries to share a repo with somebody that doesn't have keys setup using plural crypto setup-key it fails silently. This PR fixes this issue.

Labels

Test Plan

Checklist

[ ] If required, I have updated the Plural documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have added a meaningful title and summary to convey the impact of this PR to a user.
[ ] I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino PTAL


Frequency underestimation problem

Dear Yuzie007,
I just get started to use upho for phonon unfolding. I tested using AlN having WZ structure.
First, I generated a 2x2x2 supercell (32 atoms) from the primitive cell. I used this 32 atoms supercell to calculate phonon dispersion using phononpy, by generating 1x1x1 supercell to get atomic displacements (basicaly keep the same size). The calculation was interfaced with QE. This calculation produced force constants of the supercell.
To run the upho, POSCAR and POSCAR_ideal were created. The POSCAR_ideal contains
X
5.823848962318
1.00000000000   0.00000000000   0.00000000000
-0.50000000000   0.86602540378   0.00000000000
0.00000000000   0.00000000000   1.60812126409
X
4
Direct
0.666666667   0.333333333   0.000000000
0.333333333   0.666666667   0.500000000
0.666666667   0.333333333   0.381069307
0.333333333   0.666666667   0.881069307
The unfolded phonon dispersion has pretty similar pattern with what is assumed for WZ-AlN. The only thing not good is that the phonon frequency is underestimated. Maximum frequency reaches close to 4 THz (figure attached), while it should be 27 THz in the normal phonon calculation.
To check the phononpy calculation, I plotted the phonon dispersion of the supercell, it looks OK in terms of phonon frequency range.
Could you please give me some comments on this problem, I very appreciate.
Thank you!
Best regards,

Dat

Here also comes what the band.conf file contains
DIM =  2 2 2
PRIMITIVE_AXIS = 1 0 0  0 1 0  0 0 1
BAND =   0.0 0.0 0.0 2/3 -1/3 0.0 1/2 -1/2 0.0 0.0 0.0 0.0 0.0 0.0 -1/2
BAND_POINTS = 51
BAND_LABELS =  \Gamma K M \Gamma A
FORCE_CONSTANTS = READ


File changes shown but no local commits

Testing #5100

This is currently by design. We need new git extension API before we can have local commits. Once https://github.com/microsoft/vscode/pull/188500 is merged I will adopt the API here.


⚠ SkipTheTrailers has degraded performance

In 9834fa9, SkipTheTrailers ($STT) experienced degraded performance:

HTTP code: 200
Response time: 2937 ms

Resolved: SkipTheTrailers performance has improved in 0033994.


About Supplementary data files

Thank you for your wonderful works.
I am curious about the precomputed boxes json files under 'posetrack 17/18_precomputed_boxes' folder.
Can you describe how these boxes were computed?
Thank you very much.

I used a Cascaded R-CNN based on ResNeXt-101, which was pretrained on COCO, to extract person bounding boxes.

Thank you 😄

I used a Cascaded R-CNN based on ResNeXt-101, which was pretrained on COCO, to extract person bounding boxes.


Add ability to overwrite mncmd

In Host.popen, user could provide mncmd in kwargs and it will overwrite the default mncmd command options. But in CPULimitedHost.popen providing mncmd will result in duplicate keywords error.
I'm proposing this fix so user could overwrite mncmd when using CPULimitedHost.popen.
It is extremely useful sometimes. For example, by default mncmd creates a new session ID for each underlying process. If the user provides shell=True when using popen, the underlying process will be really hard to kill. Because its PID is not returned (its parent's PID is returned), and it does not belong to any know group. In this case (when running popen with shell=True), I would like to disable -d option in mncmd but now I'm not able to do that.

attribution, my friend. attribution
even though it's just a one-line change i still care. that's the reason why i submit pr


E194: No alternate file name to substitute for '#'

I have a '#' in my file path and it seems to be causing issues.
In the screenshot i'm trying to open the [2] file.

Hi,
Thanks for the report. I can reproduce it on my Win 10 VM. Escaping on Windows is hell: https://github.com/vim/vim/issues/541
I'll look into finding a solution that doesn't break for non-Windows systems.

Hey, it should be fixed now.
Please play around with different paths (and maybe another 'shellslash' value) and see if you can break things! :)


keycloak: 15.0.0 -> 15.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/keycloak/keycloak/releases.
meta.description for keycloak is: "Identity and access management for modern applications and services"
meta.homepage for keycloak is: "https://www.keycloak.org/"
meta.changelog for keycloak is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/.standalone.sh-wrapped passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/standalone.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/.jbossclirc passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/add-user.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/jboss-cli.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/elytron-tool.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/.add-user-keycloak.sh-wrapped passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/add-user-keycloak.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/jboss-cli.xml passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/jdr.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/domain.conf passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/domain.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/.jboss-cli.sh-wrapped passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/common.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/jconsole.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/product.conf passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/wildfly-elytron-tool.jar passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/launcher.jar passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/kcadm.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/wsprovide.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/add-user.properties passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/migrate-standalone.cli passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/migrate-standalone-ha.cli passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/migrate-domain-standalone.cli passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/jboss-cli-logging.properties passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/vault.sh passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/migrate-domain-clustered.cli passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/standalone.conf passed the binary check.

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/kcreg.sh passed the binary check.

Warning: no invocation of /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/federation-sssd-setup.sh had a zero exit code or showed the expected version

/nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin/wsconsume.sh passed the binary check.

1 of 31 passed binary check by having a zero exit code.

29 of 31 passed binary check by having the new version present in output.

found 15.0.1 with grep in /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1

found 15.0.1 in filename of file in /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1

directory tree listing: https://gist.github.com/57497b695b87dc2f8d6f0581c46ea8bb

du listing: https://gist.github.com/a0536102124e56a9e1135b4cf9516c54

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
keycloak
nixos-install-tools
tests.nixos-functions.nixos-test

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A keycloak https://github.com/r-ryantm/nixpkgs/archive/765d5c71e4d113d17d5bfb712a58683298b369f5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1
ls -la /nix/store/c37c0amkqw51g50ib260lxardnsxrh5q-keycloak-15.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

nixos-install-tools

1 package built:

keycloak

Maintainer pings
cc @ngerstle @talyz for testing.

Result of nixpkgs-review pr 133153 at 765d5c71 run on x86_64-linux 1

2 packages built successfully:

keycloak
nixos-install-tools

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/keycloak/default.nix:30:3:
   |
30 |   installPhase = ''
   |   ^


Can't build dylib

I'd like to build curl-rust as dylib (more precisely as shared object *.so).
I added 'crate type' to Cargo.toml and tried to build:
$ git diff
diff --git a/Cargo.toml b/Cargo.toml
index 95621a5..7122360 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -13,6 +13,9 @@ log = "0.3.0"
 libc = "0.2"
 curl-sys = { path = "curl-sys", version = "0.1.0" }

+[lib]
+crate-type = ["rlib", "dylib"]
+
 [dev-dependencies]
 env_logger = "0.3.0"

$ cargo build --release
  Compiling pkg-config v0.3.6
  Compiling libc v0.2.2
  Compiling gcc v0.3.19
  Compiling matches v0.1.2
  Compiling rustc-serialize v0.3.16
  Compiling libc v0.1.12
  Compiling log v0.3.3
  Compiling libz-sys v0.1.9
  Compiling curl-sys v0.1.27 (file:///home/aarbuzov/git/curl-rust)
  Compiling openssl-sys v0.6.7
  Compiling url v0.2.37
  Compiling curl v0.2.13 (file:///home/aarbuzov/git/curl-rust)
error: linking with `cc` failed: exit code: 1
note: "cc" "-Wl,--as-needed" "-m64" "-L" "/home/aarbuzov/.multirust/toolchains/nightly/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/aarbuzov/git/curl-rust/target/release/curl.0.o" "-o" "/home/aarbuzov/git/curl-rust/target/release/libcurl.so" "/home/aarbuzov/git/curl-rust/target/release/curl.metadata.o" "-Wl,-O1" "-nodefaultlibs" "-L" "/home/aarbuzov/git/curl-rust/target/release" "-L" "/home/aarbuzov/git/curl-rust/target/release/deps" "-L" "/usr/lib/x86_64-linux-gnu" "-L" "/usr/lib/x86_64-linux-gnu" "-L" "/usr/lib/x86_64-linux-gnu" "-L" "/home/aarbuzov/git/curl-rust/target/release/build/openssl-sys-f0bee5fb97afc90d/out" "-L" "/home/aarbuzov/.multirust/toolchains/nightly/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/home/aarbuzov/git/curl-rust/.rust/lib/x86_64-unknown-linux-gnu" "-L" "/home/aarbuzov/git/curl-rust/lib/x86_64-unknown-linux-gnu" "-Wl,-Bstatic" "-Wl,-Bdynamic" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liburl-5247f81b4a7b5841.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/librustc_serialize-7ff5bfc027146194.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liblog-35171053ffe7ab96.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libcurl_sys-0d38319d29f4714a.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libopenssl_sys-f0bee5fb97afc90d.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liblibc-540159808ccfa9ab.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libmatches-68291f81832fc22d.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liblibz_sys-3753452b802ce1b9.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liblibc-29adb837ec836726.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libstd-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libcollections-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/librustc_unicode-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/librand-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liballoc-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liballoc_system-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/liblibc-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.3AlOKJZLKvC6/libcore-8cf6ce90.rlib" "-Wl,--no-whole-archive" "-l" "curl" "-l" "ssl" "-l" "crypto" "-l" "z" "-l" "c" "-l" "m" "-l" "dl" "-l" "pthread" "-l" "gcc_s" "-l" "rt" "-l" "pthread" "-l" "c" "-l" "m" "-shared" "-Wl,-rpath,$ORIGIN/../../../../.multirust/toolchains/nightly/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-rpath,/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "compiler-rt"
note: /home/aarbuzov/git/curl-rust/target/release/libcurl.so: file not recognized: File truncated
collect2: error: ld returned 1 exit status

error: aborting due to previous error
Could not compile `curl`.

To learn more, run the command again with --verbose.

What I did wrong? Is it possible to build curl-rust as so-lib ?
Thanks.

This is actually an issue with Cargo because the compiler is both creating libcurl.so and at the same time trying to link to it (as the system also has libcurl.so). Unfortunately there's not much that can be done about this, but when libcurl is built as a dependency and a dylib it should work out just fine.

Could you please advise how I can build dependency (from Cargo.toml) as dylib? Any special keyword?
Brief googling have not got answer.
Thank you.


AFHTTPRequestSerializer: Create default headers only once.

It seems that the headers created in the initializer
preferredLanguages and userAgent are calculated from values that
don't change throughout the entire program execution. Therefore they can
be created only once. This speeds up the creation of an
AFHTTPRequestSerializer which can be significant if for example one
tries to serialize a request in order to get a cached response from
NSURLCache.

😱


Fix S3 delete_keys harder

About this change - What it does

Apparently the fixed code wasn't right either but the tests I ran on it outside were insufficient (they did not notice delete failures due to prefix being omitted as we don't parse the delete_keys response).

Why this way

Now actually added unit tests for the s3 delete_key* and also added prefix parameter to s3 storage tests in general to ensure it is passed along to the API calls that we check. In the future better unit tests would be nice but at least these enforce that the prefix is not dropped (for the covered cases) in the future.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.21 :tada:

Comparison is base (f7837b8) 57.92% compared to head (5c1b3ac) 58.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   57.92%   58.14%   +0.21%
==========================================
  Files          29       29
  Lines        3199     3199
==========================================
+ Hits         1853     1860       +7
+ Misses       1346     1339       -7

Impacted Files
Coverage Δ

rohmu/object_storage/s3.py
53.28% <100.00%> (+4.60%)
:arrow_up:

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Avro key serialization / deserialization support for Kafka module

Purpose

Adding Avro support for key serialization / deserialization support for Kafka module.
Added missing API docs for kafka:AvroRecord.
Renamed external functions to increase readability.
Create separate send classes for different value types.

Fixes #22022
Fixes #21965

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22145 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22145   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6951bc...0be0da1. Read the comment docs.


Adopt Cluster API Spec

To not be marginalised and outrun eventually, we should actively engage with the community and eventually adopt the cluster API spec. See gardener/machine-controller-manager#46.

The spec is in a very early phase and isn't anywhere near to be ready for adoption. We will first focus on the machine API part.


.github/workflows/ansible-lint.yml: fix 'rich' dependency requirement

This PR fixes the test .github/workflows/ansible-lint.yml
Fix found in https://github.com/ansible/ansible-lint-action/issues/59

/uncc @osherdp

@kpouget just FYI
if you'll cc someone on PR description, it will ping him only :smile:

@kpouget just FYI if you'll cc someone on PR description, it will ping him only smile

oh, I didn't know that, sorry for the spam :# :# :#

/ok-to-test
Thanks @kpouget !
Will not enable github actions just yet - but I do want this merged, for the day I enable them.

I pushed minor updates to address the linter issues that were introduced while the Github Action check was down

/test gpu-operator-e2e

@kpouget anything else you want to test?

@sagidayan no, PR good from my POV


Don't rebuild the world when LABEL data changes

LABEL data is stored in a layer in docker images. This means that when it changes, any direct or indirect child images must be rebuilt. This gets expensive for the size images we're building.
This change makes it so that we build child images from an unlabelled layer of their parent images, if the parent image is one that's built from this repository.

@alandpost: for you, assuming Travis passes. You might want to wait though; the code that splits it up for travis is hard to test locally.

Rebased and merged


Add bearer token support

This would add bearer token support to the auth method (both for client and for node).
.auth(accessToken, { type: 'bearer' })

Notice I made pass optional since bearer authorization doesn't need a 2nd argument.

Thanks for the pull request.
@focusaurus what do you think about adding this?

I'm OK with it, as long as people don't interpret it to mean some kind of deep OAuth 2 support.


Discuss: if it is bug on my side or your.

Library Version: 2.8.1
Device: OnePlus 6T Android 9
Describe the Bug:
This bug appears only at the first-time start of the dialog, after the start, I try to choose the first item but the button isn't enabled yet, because of that I choose the second one item. After that button change the availability state to enable and I click on this button for saving the result. But unfortunately, the result isn't properly, because it is the first item, but before I submitted it was the second one.
For better understanding, I uploaded the video on Google Drive.
To Reproduce:

Open Dialog (without predefined choose)
Choose the first item (button state - disabled)
Choose the second item (button state - enable)
Click on the button for saving.

And the result should be incorrect.
Here is my code:
MaterialDialog(this).show {
                title(R.string.car_dialog_fuel_type_title_str)
                listItemsSingleChoice(R.array.FuelType, null, null, getIndexViaString() ?: 0)
                { dialog, index, text ->
                    dialog.positiveButton(R.string.car_choose_dialog_positive) {
                        text.getFuelTypeViaString(this@CarCreateEditActivity)?.let {
                            fuelTypeStringId = it.stringID
                            render(CarCreationModel.RenderFuelType(it))
                        }
                    }
                }
            }

Thank you for your future response and help! Have a nice day/evening!

The button is appearing because you don't call positiveButton until the single choice listener is invoked. This is not a bug in the library.


Created skip-if-no-diff input

Current dependencies on/for this PR:

main

PR #68   👈

This comment was auto-generated by Graphite.


init mud config from existing world

this should be easier with utils from https://github.com/latticexyz/mud/pull/1702

done in https://github.com/latticexyz/mud/pull/3171


notary return 401 when run notary list GUN

dev branch
use content trust
export content trust and content trust server
run notary list ip/repo/image:tag
will get an error"* fatal:  you are not authorized to perform this operation: server returned 401"

root cause is in notary client:
https://github.com/docker/notary/issues/1107
I have a quick fix and will push to upstream, if not we have revisit it later to find other workaournd

My PR to fix the issue has been merged, will close this issue if notary has a new release that contains my fix

The notary is bound to port 4443 now, no more such issue as long as the "-s" is properly set.


feat(login): add wechat signup

Fix: https://github.com/casbin/casbin-forum/issues/97
Refer to QQ login: https://github.com/casbin/casbin-forum/commit/554f5d814a276d9cbd345986e1861d118e8fdfcd

Merged for now.


Capital addition to Vars.. cant be on the same line ?

When trying the new Capital V's i discovered that the capital input AV held with an H will only pass a value to VA when NOT on the same line.

example of the not working arrangement ..
H.R15..VA AV2....?.
example of working arrangement ..
..H.R15...... ..AV3....
VA.. .........3...

not sure the anomoly .. but ill close it now since it does work ? :)


Is there a way to use pouchdb-find when directly accessing couchDB, through pouchDB instance.

var db = new PouchDB('http://admin:admin@localhost:5984/product');
db.find({
      selector: {
             barcode : barcode,
       }
}).then(function(response){ /*...*/ });

Yes it works with CouchDB. Just set the PouchDB database url to point to a CouchDB instance and use the PouchDB-find functionality.
All misspelling thanks to my iPhone

On 30 Oct 2015, at 3:31 AM, havocdrake<EMAIL_ADDRESS>wrote:
var db = new PouchDB('http://admin:admin@localhost:5984/product');
db.find({
selector: {
barcode : barcode,
}
}).then(function(response){ /.../ });
—
Reply to this email directly or view it on GitHub.

Closing this since its not an issue.

Its not working for me, it always returns:

Remote Address:<IP_ADDRESS>:5984
Request URL:http://localhost:5985/monthly_totals/_find
Request Method:POST
Status Code:400 Bad Request

@havocdrake This plugin only works for CouchDB 2.0+, not CouchDB 1.x.


Convert ajax/Billing to TypeScript

Working towards converting NewWorkspaceModal to TypeScript as part of updating it to support importing data into new Azure workspaces. NewWorkspaceModal depends on the ajax/Billing module and has a good bit of logic based on the list billing projects response.
This updates most of ajax/Billing to TypeScript (I didn't get into the spend report types). It also updates the BillingProject type to take advantage of type narrowing.

Do remember to add a ticket for these ajax TS conversions.


Background color can't change (stay black)

The other ui color works perfectly. But the black background won't change.

it should like this (from Nord Screenshot)

Send ur config

is this the config?
[Setting]
spotify_launch_flags    =
check_spicetify_upgrade = 0
prefs_path              = C:\Users\user\AppData\Roaming\Spotify\prefs
inject_theme_js         = 1
inject_css              = 1
replace_colors          = 1
overwrite_assets        = 0
spotify_path            = C:\Users\user\AppData\Roaming\Spotify
current_theme           = Nord
color_scheme            = Spotify
[Preprocesses]
disable_sentry        = 1
disable_ui_logging    = 1
remove_rtl_rule       = 1
expose_apis           = 1
disable_upgrade_check = 1
[AdditionalOptions]
extensions            =
custom_apps           =
sidebar_config        = 1
home_config           = 1
experimental_features = 1
[Patch]
; DO NOT CHANGE!
[Backup]
version = <IP_ADDRESS>2.g1924b088
with    = 2.18.1

You installed online mode or offline mode?

it still doesn't work

Then try resettings Nord. should fix it.

i reset same problem

same problem

Can you send me output of this by running that in Console tab
window.Nord.shared.isLibX

How to open console tab in dev-tools


Standardize deterministic RNG in examples

If we are emphasising that the seeded rng is being used for deterministic purposes, then we kinda shouldn't be using StdRng in the first place. StdRng is documented as being deterministic in output, but not portable, so there is no assurance that the output will be the same on different platforms or different versions of rand. And if we are testing across different platforms, we'd then expect the output to match across all platforms. For further reference from the rand documentation, their documented expectations for portability/determinism.
Given rand minor versions might in the future change the underlying algorithm for StdRng, end users might find their tests breaking if they used StdRng in their tests after basing them on our examples. Better to instead encourage using the algorithm crates directly if they want to have that extra assurance in determinism. Currently, rand_chacha is what is the underlying algorithm for StdRng, specifically ChaCha12Rng. For game dev purposes, ChaCha8Rng would be a better fit to provide higher throughput at the expense of some entropy quality (though it will still be far better than what is probably required).

Originally posted by @Bluefinger in https://github.com/bevyengine/bevy/issues/12593#issuecomment-2011883060
I think a good PR would be to replace all usage of StdRng with ChaCha8Rng, as suggested by @Bluefinger. There are also a few examples that use hashing instead of a proper RNG function that could benefit from switching too.

I can take this one!

I can take this one!

Feel free to open up a PR, then!
(By the way, we don't really do issue claiming; it's a first-come-first-serve system. I appreciate your enthusiasm, though!)

Made a PR but I'm not sure how to add labels to it (if that's the correct workflow)?

Closed in #12644.


Checkov: CKV_K8S_35: "Prefer using secrets as files over secrets as environment variables"

Check: CKV_K8S_35: "Prefer using secrets as files over secrets as environment variables"
FAILED for resource: Job.mas-inst1-pipelines.mas-deploy-job
File: /chart/deploy-mas/mas-deploy/templates/01-deploy-mas.yaml:95-327

Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/kubernetes-policies/kubernetes-policy-index/bc-k8s-33

This issue can not be fixed. Please find below the reason.
The helm chart accepts 2 secret variables (  entitlement_key & authorized_entitlement ) from terraform found in this line https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/6ed2eda03f34bd579c33b1318aa1b935877dbe50/chart/deploy-mas/templates/01-deploy-mas.yaml#L24
These secrets are important for installing MAS. Also their values are already base64 encode in terraform and passed to helm chart. Helm chart will store them as k8s secret and further inject into POD
Hence it is important to have the secret as environment variables in this line
https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/6ed2eda03f34bd579c33b1318aa1b935877dbe50/chart/deploy-mas/templates/01-deploy-mas.yaml#L24
https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/6ed2eda03f34bd579c33b1318aa1b935877dbe50/chart/deploy-mas/templates/01-deploy-mas.yaml#L257
https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/6ed2eda03f34bd579c33b1318aa1b935877dbe50/chart/deploy-mas/templates/01-deploy-mas.yaml#L263


Race hazard in submitForm call

Bug Report
Naja 2.4.0, UIHandler.ts:127 (and the clickForm above) should not be declared async. It should return a Promise from makeRequest synchronously (there is no await in the method body). Async call lead to race hazard. In our case where Naja is bundled with other scripts (so the processing is a bit delayed), well defined input to submitForm is undefined in the UIHandler, as the submitForm is called in another thread due to the async. The issue appeared on Safari in minified code only.
There can be other thread safety issues: I suggest to checkout scenarios where Naja is not called in the main thread.
Code that reproduces the problem
N/A (race hazard in bundled code)

Hi, I'm closing this for inactivity. Feel free to reopen this issue if you have further insights into the problem.


Allow initialization of a Lexer using Abstract Tokens.

See:
https://github.com/kdex/chi/issues/3#issuecomment-287111839

The Lexer makes an assumption that all tokens passed to it during definition are concrete Token types.
This is because a Lexer can only output Concrete Token types, matching by token hierarchies
is the domain of the Parser.
However instead of throwing an inaccurate error message it is much better to automatically filter those abstract tokens during the Lexer's construction instead of assuming the end user would do so.

oops, no bug, move along...


Tutorial updates for extragalactic tutorials

This is a follow-up from the sprint day, where we looked into the updates necessary for the extragalactic tutorials. These include

verifying that the notebooks run
adding options for skysim/roman_rubin catalogs
fixed CCL bug noted in issue #163
updating jupyter-dev links and kernel source links
adding halo_id based method to measure HOD
adding explanatory text

Things that would be good to check before merging:

Eve should confirm the catalogs linked are the most up-to-date versions
Verify that the CCL bug fix works for others
Preferences for merging of rendered/un-rendered notebooks

Thanks both! I just snuck in one last commit to update the matching_fof.ipynb tutorial for matching between the extragalactic and the object catalogs. This just fixed a warning about a deprecated catalog name,  removed an unnecessary column which was causing issues and ran through it to check that it works.


Fix RedisRateLimiter replenishRate and burstCapacity when using incorrect configuration

When using RedisRateLimiter with the following configuration:

ReplenishRate > 2
BurstCapacity < ReplenishRate

So for example (3, 1), the Lua script will not save anything on Redis and therefore there won't be any rate limit, i.e. all request will succeed.
This problem is caused because of the following lines on the Lua script:
local fill_time = capacity/rate
local ttl = math.floor(fill_time*2)
For instance, if we have rate = 3 and capacity = 1:
fill_time would be 0.333
ttl would be 0
And at the end of the script, these are the lines that actually save something in Redis:
if ttl > 0 then
redis.call("setex", tokens_key, ttl, new_tokens)
redis.call("setex", timestamp_key, ttl, now)
end
One simple fix could be making replenishRate = burstCapacity when replenishRate > burstCapacity (and replenishRate > 2 as the minimal viable config could be 2 and 1).
Normally a user would always use burstCapacity >= replenishRate but if by mistake they set it as replenishRate > burstCapacity then what they would have is a rate limiter that actually does not limit anything.

@cristianrb Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@cristianrb Thank you for signing the Contributor License Agreement!

I'd prefer an error if there is incorrect configuration

Throwing an IllegalStateException now when replenishRate > burstCapacity


gmc: add authN & authZ support on fake JWT token

Description
Enable authN and authZ together with Istio and GMC using fake JWT token
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change

[ * ] New feature (non-breaking change which adds new functionality)

create new folder under config to obtain authN, authZ configs
add Istio authentication and authorization policies
provide README for the task

Dependencies
Istio
Tests
Describe the tests that you ran to verify your changes.

@zhlsunshine and @irisdingbj please take a look. This is the version that the router service is not exposed using the istio ingress gateway. If we require the service got exposed the ingress, i can update another version of doc and yamls.