Apply trace patch for CALL trace issue

Description
Fixes #1590
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the relevant labels
[x] I have updated the official documentation
[x] I have added sufficient documentation in code

Testing

[x] I have tested this code with the official test suite
[x] I have tested this code manually

Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it

This is the diff before and after the changes:


When nine cameras are added, five or six cameras are frequently disconnected and then reconnected

Which version are you using?
v0.17.17
ps: I don't use the latest version because the readBufferSize parameter has been removed from later versions and some streams that support H265 will not play.
Which operating system are you using?

[x] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description
Describe how to replicate the issue
When my proxy server added 9 streams, 5 streams would break frequently (about once every 8 or 9 seconds, and then reconnect), with a similar error, not when only 6 streams were added.

start the server
publish with ...
read with ...

Did you attach the server logs?

yes
Did you attach a network dump?

no

Hello, please open another issue about the H265 problem - nobody wanted to remove H265 support, i was not aware of the fact that there are H265 sources that use non-standard RTP packet sizes, and i don't have a non-standard H264 track.
Regarding this issue, it's impossible to understand whether it's still standing or it has been fixed, since you're not using the latest version.


Ability to customise class of option subtext

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Here's an example of the element generated for an option tag:
 	 	 		Option content hereSome subtext content here
The subtext is being pre-styles using bs classes making it hard to change.
Describe the solution you'd like
Using the example above, I'd love it if there could be an option that would generate HTML something like this to allow us to add our own styles to the subtext:
 	 	 		Option content hereSome subtext content here
Describe alternatives you've considered
hacky css, replacement with js (both of which are not ideal)

Hello,
Yes this shouldn't be hard to add and would result in better DX.

why?
wrap whole select in some div, for example, and use
.someclass .bootstrap-select .dropdown-menu li small, .bootstrap-select .dropdown-menu li .small { color: #000000; }
works fine


lbmap: Segfault when disabling IPv6 after adding IPv6 services

I was running K8sService test suite on the latest master, and then when an unrelated test case failed (I was holding the env), I disabled the IPv6 support by setting enable-ipv6: false via ks edit cm cilium-config. Afterwards, I restarted cilium pods and they failed to come up due to the following:
level=debug msg="Kubernetes service definition changed" action=service-updated endpoints= k8sNamespace=default k8sSvcName=test-nodeport-local-k8s2-ipv6 old-service=nil service="frontend:fd03::bb4/ports=[tftp http]/selector=map[zgroup:test-k8s2]" subsys=k8s-watcher
level=debug msg="Upserting service" backends="[]" loadBalancerSourceRanges="[]" serviceIP="{fd03::bb4 {TCP 10080} 0}" serviceName=test-nodeport-local-k8s2-ipv6 serviceNamespace=default sessionAffinity=false sessionAffinityTimeout=0 subsys=service svcHealthCheckNodePort=0 svcTrafficPolicy=Local svcType=ClusterIP
level=debug msg="Resolving service" l3n4Addr="{IP:fd03::bb4 L4Addr:{Protocol:TCP Port:10080} Scope:0}" subsys=service
level=debug msg="Acquired service ID" backends="[]" loadBalancerSourceRanges="[]" serviceID=33 serviceIP="{fd03::bb4 {TCP 10080} 0}" serviceName=test-nodeport-local-k8s2-ipv6 serviceNamespace=default sessionAffinity=false sessionAffinityTimeout=0 subsys=service svcHealthCheckNodePort=0 svcTrafficPolicy=Local svcType=ClusterIP
level=debug msg="Deleting backends from session affinity match" backends="[]" serviceID=33 subsys=service
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1cd5900]

goroutine 147 [running]:
github.com/cilium/cilium/pkg/bpf.(*Map).OpenOrCreate(0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/cilium/cilium/pkg/bpf/map_linux.go:464 +0x40
github.com/cilium/cilium/pkg/maps/lbmap.updateRevNatLocked(0x2b1b5a0, 0xc000b365fc, 0x2b07380, 0xc000ae7e80, 0xc000b365f0, 0x1)
        /go/src/github.com/cilium/cilium/pkg/maps/lbmap/lbmap.go:331 +0x68
github.com/cilium/cilium/pkg/maps/lbmap.(*LBBPFMap).UpsertService(0xc0009f5040, 0xc000b3a1e0, 0x0, 0xc000b47470)
        /go/src/github.com/cilium/cilium/pkg/maps/lbmap/lbmap.go:130 +0x5b7
github.com/cilium/cilium/pkg/service.(*Service).upsertServiceIntoLBMaps(0xc00065a280, 0xc00066b420, 0x421e500, 0x0, 0x421e540, 0x0, 0x0, 0x421e540, 0x0, 0x0, ...)
        /go/src/github.com/cilium/cilium/pkg/service/service.go:749 +0x3de
github.com/cilium/cilium/pkg/service.(*Service).UpsertService(0xc00065a280, 0xc000661a40, 0x0, 0x0, 0x0)
        /go/src/github.com/cilium/cilium/pkg/service/service.go:324 +0xc85
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).addK8sSVCs(0xc000974480, 0xc0009a34c0, 0x1d, 0xc0009b2a96, 0x7, 0x0, 0xc000b22f30, 0xc00012be48, 0x10, 0x7ffff7fb9108)
        /go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:743 +0x47b
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).k8sServiceHandler.func1(0x0, 0xc0009a34c0, 0x1d, 0xc0009b2a96, 0x7, 0xc000b22f30, 0x0, 0xc00012be48, 0xc0009b0390)
        /go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:447 +0xbc7
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).k8sServiceHandler(0xc000974480)
        /go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:490 +0x95
created by github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).RunK8sServiceHandler
        /go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:495 +0x3f

Previously, the test cases provisioned the IPv6 services.

That same segfault is blocking https://github.com/cilium/cilium/pull/14543. I'll try to have a look in the afternoon.

This bug seems to have been introduced by https://github.com/cilium/cilium/pull/14607 and therefore probably affects v1.9.4 as well.

@brb @fristonio Should we return early in upsertServiceIntoLBMaps if we detect it's an IPv6 service but IPv6 is disabled (or the other way around)? https://github.com/cilium/cilium/blob/2b9485df05ec24fe051684ce992a82dabd0b9e56/pkg/service/service.go#L666
The problem here is that we panic when we try to add the backend for the IPv6 service while IPv6 is disabled.

This bug seems to have been introduced by #14607 and therefore probably affects v1.9.4 as well.

/cc @christarazi

Should we return early in upsertServiceIntoLBMaps

Makes sense, just that I'd return even earlier to avoid wasting resources for unnecessary steps - https://github.com/cilium/cilium/blob/2b9485df05ec24fe051684ce992a82dabd0b9e56/pkg/service/service.go#L248.


support Python 3.8.10:

replace argparse.BooleanOptionalAction
as it requires python 3.9, ubuntu 20.04 lts based distros are still stuck on Python 3.8.xx

unfortunately, idk which Python version would now be necessary now :/

btw. got the idea from: https://nono.ma/attributeerror-module-argparse-has-no-attribute-booleanoptionalaction

Thanks, I wasn't aware ubuntu 20.04 is still on python 3.8.
Looking fine, merging


added 2 new functions

mismatch and none_of

Hey @Pranav-Khurana can you fix the indentation in the mismatch algo too ?
#include <vector>
#include <algorithm>
#include <iostream>
int main() {

    std::vector<int> v{1, 3, 5, 7};

	if( std::none_of(v.begin(), v.end(), [](int i){ return i % 2 == 0; }))	{
		std::cout << "No number is  even\n";
	}
    else{
        std::cout << "A number is even\n";
    }
}

There are some extra spaces and alignment problems.


Reorganize unit tests

Currently unit tests are next to the files it runs the assertions against to. I am not 100% sure this is idiomatic in python and certainly, security tools report the usage of assertions unsafe. We should follow what is idiomatic for python.
Ping @shril

Looking into this @jcchavezs


Azure Functions failed to create from new functions app generator

I'm on an m1 Mac, running node v 18.16.1.
Using the generator to create a new functions app causes an error, where the command func init... fails, see below:
 NX   Command failed: func init test-app --worker-runtime node --language typescript

Error: Command failed: func init test-app --worker-runtime node --language typescript
    at checkExecSyncError (node:child_process:885:11)
    at execSync (node:child_process:957:15)

Resolved, I just had to install azure-functions-core-tools and update the package in my package manager


[YARN][SPARK-4929] Bug fix: fix the yarn-client code to support HA

Nowadays, yarn-client will exit directly when the HA change happens no matter how many times the am should retry.
The reason may be that the default final status only considerred the sys.exit, and the yarn-client HA cann't benefit from this.
So we should distinct the default final status between client and cluster, because the SUCCEEDED status may cause the HA failed in client mode and UNDEFINED may cause the error reporter in cluster when using sys.exit.

Test build #25021 has started for   PR 3771 at commit c02bfcc.

This patch merges cleanly.

@tgravescs your comment is much more clear than what I said, I have use it instead of mine.Thx.
when Yarn HA event happens, the previous ApplicationMaster will throw a
java.io.IOException: Failed on local exception: java.io.EOFException

So the yarn cluster the catch the exception and change the final status.
But the yarn client will directly go into the ShutDownHook and cause the problem.
I think it haven't go into the  DisassociatedEvent yet, because the driver is still alive.

Test build #25021 has finished for   PR 3771 at commit c02bfcc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25021/
Test PASSed.

Test build #25154 has started for   PR 3771 at commit c02bfcc.

This patch merges cleanly.

Test build #25154 has finished for   PR 3771 at commit c02bfcc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25154/
Test PASSed.

thanks @SaintBacchus  the changes look good.


modal component, background's opacity not working

this is the markup that i'm using

            <button class="close" (click)="lgModal.hide()" aria-label="Close">
              ×
            </button>

Large modal

                    <button (click)="()" class="btn btn-white" id="zoomIn" type="button"> Zoom In</button>
                    <button (click)="()" class="btn btn-white" id="zoomOut" type="button"> Zoom Out</button>
                    <button (click)="(1)" class="btn btn-white" type="button"> </button>

         content

thanks

Add class show to the to level div.

@slubowsky my bad, was using bootstrap 3, any way to make it works with it?

@gbarrionuevo Its supposed to work with bootstrap 3 too. I have only been using it with bootstrap 4. Take a look at http://valor-software.com/ng2-bootstrap/#/modals which is using 3 and see if anything is different.


animation & wow.js not working

Can any one assist in rectifying this problem? Thanks alot
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.
2angular.min.js:2923
Error: [$compile:ctreq] http://errors.angularjs.org/1.3.7/$compile/ctreq?p0=carousel&p1=slide
at Error (native)
at http://umelas.com/js/angular/angular.min.js:24:20
at L (http://umelas.com/js/angular/angular.min.js:1626:45)
at v (http://umelas.com/js/angular/angular.min.js:1716:115)
at http://umelas.com/js/angular/angular.min.js:1884:33
at http://umelas.com/js/angular/angular.min.js:3244:42
at l.$eval (http://umelas.com/js/angular/angular.min.js:3639:32)
at l.$digest (http://umelas.com/js/angular/angular.min.js:3582:56)
at l.$apply (http://umelas.com/js/angular/angular.min.js:3662:31)
at l (http://umelas.com/js/angular/angular.min.js:2326:69)

Hello @lhcxhj
You might wanna refer to wow.js for help since we are not using the script. Thanks and sorry for the inconvenience.
https://github.com/matthieua/WOW


fix: fix any() for symbols, bigints, null (#10179)

Summary

Adds clauses to expect's Any.asymmetricMatch() to handle Symbol and BigInt analogously to other primitives, i.e., using typeof instead of instanceof. This makes expect.any()'s behavior more consistent across primitive types.
Adds a clause to Any.asymmetricMatch() to exclude null from expect.any(Object). This makes expect.any()'s behavior more consistent with its documentation; null is not created with the Object constructor, and so should not be matched.
Closes #10179.
Test plan

Added checks to the list in asymmetricMatchers.test.ts test('Any.asymmetricMatch())' to cover the changed behavior.

I've added a commit reverting the change to null handling, as requested.
If any(Object) matching null is intended, would there be interest in documenting that? It seems unlikely to me that someone asserting a value is an Object would intend to allow null. This is also an area where Jest differs from Jasmine's original implementation.

@SimenB @jeysal thoughts? I don't have strong feelings about treating null as Object. It's valid from JS point of view, but it's also often confusing. If we're about to change it, we need to do it in a major version bump because it's technically breaking.

typeof null === 'object' is one of my least favorite parts of the language, but I don't think we should deviate from that - I think that'll just cause more confusion


added tick marks and label for rotation angle

@john0005 @tyle8552 I added tick marks and a label to show the rotation angle. Please review.

I feel like the label is not need since it just repeats what the tick marks are displaying. If the label is kept I also feel like it should display 0 when the application first starts because it doesn't display for me until the rotation is changed.
Other than that I really like the addition of the tick marks.

@doneill I agree, the label is unnecessary. If you're worried about the labels/ticks not being easily visible, I suggest adding a semi-transparent black background like many of our other samples. See the Update Attributes (Editing) sample's CSS as an example. Other than that, looks good. Thanks.

@tyle8552 @john0005 I removed the label.  Only added because all other SDK samples label, the tick marks are a nice effect on the JavaFX slider control, agree that it is redundant with the label.

@doneill good to merge.

Going to merge this so I can update the dev site today.


A star

A* is an informed search algorithm on swift

@HellGhost thanks for the contribution, one of our maintainers will get to it soon!

Apologies for the delay @HellGhost. Thanks for contributing the implementation of A*. I'm about to review it.
I like the visual representation of the end result route - the algorithm runs pretty nicely. I like that it's taken into account that a route might not be possible, and there's a bit of demonstrable variation in the example where you make diagonal exploration optional.
My main concern with the implementation is that it's very specific. It works only for graphs which are orthogonal 2D grids measuring exactly 7 nodes by 5 nodes. The two heuristics for measuring known distance to the start point and estimated distance to the end point are baked in. This makes it harder for someone else to read your code and work out what they need to change so they can apply the A* algorithm to their own problem.
Put a different way - what would have to change if the programmer was using a 5-node by 7-node grid? What if the grid was hexagonal rather than orthogonal, or 3D rather than 2D? What if the edges were all different (because the nodes represented train stations and the edges represented connections)?
The README file's quite short; it only provides a general idea of what A* is doing, and doesn't go into how you've implemented it.
To make this contribution a bit more helpful, I'd suggest you look at some of the graph-based data structures already in the SAC repository. Consider implementing an A* heuristic function in an extension to one of those existing data structures, and allowing the programmer to provide their own distance functions. So, perhaps something like this:
extension Graph {
  func aStarHeuristic(startNode: Node, endNode: Node, distanceBetweenNodes: (Node, Node) -> Int, estimatedDistanceToGoalNode: (Node, Node) -> Int) -> [Edge]
}

Hopefully it would then be easier to adapt the algorithm to other types of problem.
I hope that's not too critical. The algorithm itself is fine, even if it's not really clear why you've made certain choices (e.g. why do AStar and ASNode have to conform to NSObject? Would the intent be clearer if nodes were Equatable or Hashable?). I just think it needs to be a bit more general.

@narrativium Hi you can use this algorithm not only with  5 by 7 this only for example and visualization, you can try to create nodes without testData, in this sample i parse test data and create objects on field which have 2 type busy or free then in AStar i select nearest nodes to start point and moves to end without any size dependencies
And I will change inherited class AStar and ASNode, Also plane add 3D support and maybe implement additional to Graph
I will notify you when I do this

This implementation of A* is O(bn^2) instead of the optimal O(bn). I'd be happy to contribute an optimal implementation. See my blog post on this: https://a-coding.com/a-data-structures/ Started implementing the data structure needed on my fork: https://github.com/aleph7/swift-algorithm-club/tree/hashed-heap

Hey guys, since this PR hasn't received any activity in a while, we'll continue with #633 for the A* algorithm.
Feel free to contribute on top of #633 as we work through it. Cheers!


HADOOP-16109. Parquet reading S3AFileSystem causes EOF

HADOOP-16109. Parquet reading S3AFileSystem causes EOF
Nobody gets seek right. No matter how many times they think they have.
Reproducible test from: Dave Christianson
Fixed seek() logic: Steve Loughran

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
29
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1021
trunk passed

+1
compile
32
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
33
trunk passed

+1
shadedclient
672
branch has no errors when building and testing our client artifacts.

+1
findbugs
40
trunk passed

+1
javadoc
22
trunk passed

_ Patch Compile Tests _

-1
mvninstall
26
hadoop-aws in the patch failed.

-1
compile
25
hadoop-aws in the patch failed.

-1
javac
25
hadoop-aws in the patch failed.

-0
checkstyle
16
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1
mvnsite
26
hadoop-aws in the patch failed.

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
654
patch has no errors when building and testing our client artifacts.

-1
findbugs
20
hadoop-aws in the patch failed.

+1
javadoc
19
the patch passed

_ Other Tests _

-1
unit
28
hadoop-aws in the patch failed.

+1
asflicense
21
The patch does not generate ASF License warnings.

2763

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux b3467d524f1e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / dcaca19

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
987
trunk passed

+1
compile
33
trunk passed

+1
checkstyle
23
trunk passed

+1
mvnsite
36
trunk passed

+1
shadedclient
684
branch has no errors when building and testing our client artifacts.

+1
findbugs
44
trunk passed

+1
javadoc
25
trunk passed

_ Patch Compile Tests _

-1
mvninstall
28
hadoop-aws in the patch failed.

-1
compile
27
hadoop-aws in the patch failed.

-1
javac
27
hadoop-aws in the patch failed.

-0
checkstyle
17
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1
mvnsite
29
hadoop-aws in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
729
patch has no errors when building and testing our client artifacts.

-1
findbugs
21
hadoop-aws in the patch failed.

+1
javadoc
21
the patch passed

_ Other Tests _

-1
unit
38
hadoop-aws in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

2867

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 08a0191f4827 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 15098df

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-compile-hadoop-tools_hadoop-aws.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
63
Maven dependency ordering for branch

+1
mvninstall
997
trunk passed

+1
compile
925
trunk passed

+1
checkstyle
185
trunk passed

+1
mvnsite
102
trunk passed

+1
shadedclient
987
branch has no errors when building and testing our client artifacts.

+1
findbugs
141
trunk passed

+1
javadoc
83
trunk passed

_ Patch Compile Tests _

0
mvndep
19
Maven dependency ordering for patch

-1
mvninstall
26
hadoop-aws in the patch failed.

-1
compile
835
root in the patch failed.

-1
javac
835
root in the patch failed.

-0
checkstyle
179
root: The patch generated 6 new + 10 unchanged - 0 fixed = 16 total (was 10)

-1
mvnsite
35
hadoop-aws in the patch failed.

-1
whitespace
0
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
602
patch has no errors when building and testing our client artifacts.

-1
findbugs
25
hadoop-aws in the patch failed.

+1
javadoc
89
the patch passed

_ Other Tests _

-1
unit
502
hadoop-common in the patch failed.

-1
unit
36
hadoop-aws in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

6052

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux ecfb19d4e7fe 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 15098df

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-compile-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/whitespace-eol.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/testReport/

Max. process+thread count
1390 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-common test run => failure. hadoop-aws compilation failure with a file which has been deleted

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
1213
trunk passed

+1
compile
1545
trunk passed

+1
checkstyle
246
trunk passed

+1
mvnsite
161
trunk passed

+1
shadedclient
1271
branch has no errors when building and testing our client artifacts.

+1
findbugs
188
trunk passed

+1
javadoc
119
trunk passed

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

-1
mvninstall
31
hadoop-aws in the patch failed.

-1
compile
1315
root in the patch failed.

-1
javac
1315
root in the patch failed.

-0
checkstyle
236
root: The patch generated 3 new + 10 unchanged - 0 fixed = 13 total (was 10)

-1
mvnsite
46
hadoop-aws in the patch failed.

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
835
patch has no errors when building and testing our client artifacts.

-1
findbugs
42
hadoop-aws in the patch failed.

+1
javadoc
109
the patch passed

_ Other Tests _

-1
unit
569
hadoop-common in the patch failed.

-1
unit
47
hadoop-aws in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

8285

Reason
Tests

Failed junit tests
hadoop.ipc.TestRPC

hadoop.ipc.TestCallQueueManager

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 39a4f52a9a2d 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cb0fa0c

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-compile-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/testReport/

Max. process+thread count
793 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

OK, fun little Yetus issue for @aw-was-here

The unit tests are failing because ITestS3AContractRandomSeek.java won't compile
That file did exist, but was deleted in one of the changes in the patch sequence
Somehow maven is still finding that file in its source tree

@steveloughran , does Yetus perhaps try to test each commit individually?  Since the file is being created in the first commit and deleted in the second commit, it might be worth squashing this PR and seeing if Yetus likes that better.

new patch: address core comments from @mattf-apache , including adding a new test case.
Matt, if you ever look at readByte(), it is just calling read and checking the return value before casting
    public final byte readByte() throws IOException {
        int ch = in.read();
        if (ch < 0)
            throw new EOFException();
        return (byte)(ch);
    }

the first test was effectively doing it. But in case something in future did ever subclass it, I've added the new test case

tested: S3 ireland

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
67
Maven dependency ordering for branch

+1
mvninstall
1001
trunk passed

-1
compile
509
root in trunk failed.

+1
checkstyle
168
trunk passed

+1
mvnsite
98
trunk passed

+1
shadedclient
898
branch has no errors when building and testing our client artifacts.

+1
findbugs
133
trunk passed

+1
javadoc
69
trunk passed

_ Patch Compile Tests _

0
mvndep
22
Maven dependency ordering for patch

-1
mvninstall
27
hadoop-aws in the patch failed.

-1
compile
532
root in the patch failed.

-1
javac
532
root in the patch failed.

-0
checkstyle
176
root: The patch generated 3 new + 10 unchanged - 0 fixed = 13 total (was 10)

-1
mvnsite
36
hadoop-aws in the patch failed.

-1
whitespace
0
The patch has 75 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1
whitespace
1
The patch 19849  line(s) with tabs.

+1
shadedclient
910
patch has no errors when building and testing our client artifacts.

-1
findbugs
28
hadoop-aws in the patch failed.

+1
javadoc
83
the patch passed

_ Other Tests _

-1
unit
497
hadoop-common in the patch failed.

-1
unit
34
hadoop-aws in the patch failed.

+1
asflicense
35
The patch does not generate ASF License warnings.

5550

Reason
Tests

Failed junit tests
hadoop.util.TestReadWriteDiskValidator

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 3b44191e02d6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 45f976f

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/branch-compile-root.txt

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-compile-root.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-compile-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/diff-checkstyle-root.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/whitespace-eol.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/whitespace-tabs.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/testReport/

Max. process+thread count
1717 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

TL;DR: squash and rebase regularly

does Yetus perhaps try to test each commit individually? ... [Later Edit] It looks like maybe a GitHub issue.

Yup.
Yetus gets the equivalent of 'git format-patch' and then calls 'git apply'  or 'patch' or whatever works on top of master (or branch-2 or whatever) with it. This has several downsides, but most of them go away if the patch branch is regularly rebased and commits are squashed.  The latter fixes 99% of the issues.  When commits aren't squashed, you'll see weird stuff like what shows up here.  (Remember, the top of the other tree is moving too....)
It's important to note that git/github really only provides three ways to handle PRs:

git merge
git diff
git format-patch

The first one has lots of issues from a Yetus functionality perspective since it taints the source tree and doing multiple checkouts has other issues (remember: yetus also runs locally!). The second one doesn't work with binary files.  That leaves us with the third one, which has lots of weird idiosyncracies but works when good branch hygiene is in play.  YETUS-724 will enable test-patch to switch to using the git diff IFF the format-patch version of the file can't be applied.

squash and resubmit

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
58
Maven dependency ordering for branch

+1
mvninstall
1121
trunk passed

+1
compile
1117
trunk passed

+1
checkstyle
203
trunk passed

+1
mvnsite
144
trunk passed

+1
shadedclient
1021
branch has no errors when building and testing our client artifacts.

+1
findbugs
150
trunk passed

+1
javadoc
87
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
79
the patch passed

+1
compile
1076
the patch passed

+1
javac
1076
the patch passed

-0
checkstyle
203
root: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10)

+1
mvnsite
125
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
674
patch has no errors when building and testing our client artifacts.

+1
findbugs
179
the patch passed

+1
javadoc
95
the patch passed

_ Other Tests _

+1
unit
558
hadoop-common in the patch passed.

+1
unit
272
hadoop-aws in the patch passed.

+1
asflicense
41
The patch does not generate ASF License warnings.

7145

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-539/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/539

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux b3b35016f438 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / fb851c9

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/6/artifact/out/diff-checkstyle-root.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/6/testReport/

Max. process+thread count
1463 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-539/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Squashed PR is happy. I need to do the full local test run and declare that before I can say this is ready to go in

Tested, S3 london in a versioned bucket, with s3guard. All well

local test w/ s3 london + (s3guard). Failure in test setup of all three the big seek tests, even when parameterized names were used.
[ERROR] testSeekBigFile[0](org.apache.hadoop.fs.contract.s3a.ITestS3AContractSeek)  Time elapsed: 0.557 s  <<< ERROR!
org.apache.hadoop.fs.FileAlreadyExistsException: s3a://hwdev-steve-london/fork-0002/test/bigseekfile.txt-random already exists
	at org.apache.hadoop.fs.s3a.S3AFileSystem.create(S3AFileSystem.java:963)
	at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1130)

...
[ERROR] testSeekBigFile[1](org.apache.hadoop.fs.contract.s3a.ITestS3AContractSeek)  Time elapsed: 0.479 s  <<< ERROR!
org.apache.hadoop.fs.FileAlreadyExistsException: s3a://hwdev-steve-london/fork-0002/test/bigseekfile.txt-normal already exists
	at org.apache.hadoop.fs.s3a.S3AFileSystem.create(S3AFileSystem.java:963)
	at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1130)
	at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1110)
	at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:999)
	at org.apache.hadoop.fs.contract.ContractTestUtils.createFile(ContractTestUtils.java:633)
	at org.apache.hadoop.fs.contract.AbstractContractSeekTest.testSeekBigFile(AbstractContractSeekTest.java:275)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

...

[ERROR] testSeekBigFile[2](org.apache.hadoop.fs.contract.s3a.ITestS3AContractSeek)  Time elapsed: 0.958 s  <<< ERROR!
org.apache.hadoop.fs.FileAlreadyExistsException: s3a://hwdev-steve-london/fork-0002/test/bigseekfile.txt-sequential already exists
	at org.apache.hadoop.fs.s3a.S3AFileSystem.create(S3AFileSystem.java:963)
	at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1130)

Not directly related, but I'll change the creation to overwrite=true to ensure this goes away

the seek contract test in this PR does set overwrite=true; build must have picked up a version of the hadoop-common tests jar from a different branch. A full clean build fixed the test run.
All is good
@mattf-apache you happy with this? You have voting rights....

thanks.
For the record, this was applied via
 dev-support/bin/smart-apply-patch --project=hadoop GH:539

I'll be submitting a followup PR for branch-3.2 and earlier (doesn't compile due to no method removeBucketOverrides(java.lang.String,org.apache.hadoop.conf.Configuration,java.lang.String,java.lang.String)) which I'll have to pull in too, then all the way back to 2.8.x. Joy. This is is the price of getting seek wrong

Thanks, @steveloughran !


CUSTESC-25878 added audit_ssh to gateway actions

Adding anew action to gateway actions and a little more documentation on existing actions

thanks for the update here @rexscaria but the files you've updated are generated artifacts. you can have a read of https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md to see how to make changes to the available fields.


Possible bug in explained variance/ explained variance ratio

The differences I am seeing with explained variance and explained variance ratio between CUDA and Python. Done on a 5000 by 50 matrix with k = 2:
Calculation in Python
h2o4gpu tsvd Explained Variance
[0.08407421 0.09914753]
Sklearn Explained Variance
[0.08407422 0.09914825]

Calculation in CUDA:
h2o4gpu tsvd Explained Variance
[0.08407421 0.08716473]
Sklearn Explained Variance
[0.08407422 0.09914825]

@RAMitchell Any ideas?

Is this still the case or did your latest changes fix it? @navdeep-G

@mdymczyk I need to double check that to see how it behaves in CUDA


Figure out why not all iframes get content scripts injected.

Sometimes there will be one or several frames on a page that don't get a content script injected.
E.g. On google.com the chrome-search frame does not get a script injected.

I am fairly confident the above comment explains the issue.  I will close for now, and reopen if the problem occurs again.


[Dashboard] Recently accessed documents

Update this card to show the list of recently accessed documents

Recently accessed documents

You're required to make a React component for this task

@meet59patel @HemangNakarani Does this require to change the table headings and add some dummy doc file name instead of .html files?

@Aniruddhmuley2001 earlier we had different plans with this component. But now we've decided to show recently accessed files list in here.

Shows Filename (on click will open the file) and last access time of the file
you can remove other fields
Important :  Currently this table is made directly inside views/Index.js, but make the new component (reusing the code) and save component to components/dashboard/RecentlyAccessed.js , and import this component inside views/Index.js
Make sure the data that's shown inside the table comes from a variable (array) something like this:

let recentlyAccessed = [ {
    fileName: 'filename',
    lastAccessed: "Mon, 05 Oct 2020 16:11:10 GMT"
}, more objects in the array... ];

I'll be requiring data implementation part in this way so that we can use the same attributes while making database schema and incorporating fetching from DB becomes very easy.

@meet59patel @HemangNakarani I would like to work on this issue.


Font rendering options/explicit control over antialiasing

Is your feature request related to a problem? Please describe.
I'd like some control over font rendering options. Most pressing issue is the anti-aliasing method.
Describe the solution you'd like
An option for explicit control over font rendering similar to <Image RenderOptions.X>. For example, <TextBlock Text="Settings" RenderOptions.Antialiasing="Subpixel, Greyscale, None">.
Describe alternatives you've considered
An implicit font antialiasing control depending on background properties (if there's transparency). But this might introduce unnecessary complexity, runtime overhead, and/or will limit user control.
Additional context
When using Mica/Acrylic background, Windows disables ClearType due to transparency composition issues.

Other font rendering options might be useful, such as support for color, ligatures, etc.

https://github.com/AvaloniaUI/Avalonia/pull/9584

Sorry, I tried to search with various permutations on aliasing etc, but couldn't find anything besides the image options 😹


Write ADR for IBC testing package++

Summary
The testing package is heavily used by our code base as well as by external IBC applications. It has undergone significant refactors thanks to external feedback along with our own usage. Updating to ABCI++ will require another refactor due to the current block execution structure being incompatible.
The testing package is simultaneously robust and fragile. Many design decisions have been made due to subtle understandings of tendermint and the SDK. These design choices should be documented so we can easier reason about potential changes in the future. Discussion on this ADR will also give us space as a community to discuss the potential improvments/requirements.
Problem Definition
The testing package has accrued a long history and will break with ABCI++. The current and future design decisions should be clearly documented.
This problem needs to be addressed
Proposal
Write an ADR outlining the context of the testing package, its history, and the future changes required for it to align with ABCI++

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[x] Appropriate contributors tagged/assigned

There are now a serious of proposed changes in the Testing package improvements milestone. Maybe we could at least add an ADR documenting all the changes made
The abci++ changes initially are less substantial than I anticipated and has mostly lead to clean up in the testing pkg

+1 for ADR.
Since testing is a package other people use, it might be sensible to loop them in here. One way this is done is via RFCs whereby interested parties can contribute to the discussion. RFC fleshes out the initial details and creates consensus around some specific architectural decision while the ADR will document that final decision.
I am unsure if it is entirely warranted, it might be overkill and not something the team wishes to go through. In general I'd find it beneficial to introduce this separation as I do think having a process that would likely make other voices heard could be beneficial.

Gonna close this issue, as I don't think it makes much sense to dedicate effort to it. Would be nice, but the testing package isn't so complicated


updating import example in readme

Great library! thank you so much.
I got stuck for some minutes due to being unable to import:
from smart_open import open

so updated the docs to refer it as :
from smart_open import smart_open

@mpenkov what's going on with the releases? (smart_open, gensim, sqlitedict)

oops sorry! feel free to close it

@piskvorky I’ve lined up some time on the weekend to do the releases.


[WIP] Integrate encryption into datasource

@rdblue this follows up https://github.com/apache/incubator-iceberg/pull/85

@yifeih, thanks for all the work on this one. It looks close to me. Most of my comments were minor.

Thanks for contributing this, @yifeih! Looks great.


Limit which peer can access network route

Currently, as long as a peer can access the routing peer, it can access devices in the route subnet
My use case is the routing peer belongs to 2 groups A and B, but I only want peers in group A to access the route

Thanks, @deluxghost for your request.
This overlaps with the requests in #463, I will keep the group support for network routes in that ticket.


toggle issue

the toggle function (strike through the text) is only possible outside of the text. If you click on the task text, nothing happens

the toggle function (strike through the text) is only possible outside of the text. If you click on the task text, nothing happens

Which work did you talking about? Can you write the path and be more spesific? If it's function of the "to do" list project in JAVASCRIPT works named "isChecked", i wanted to strike through the text with javascript style property which used css and it works.

sorry, yes exactly. It's about the todo list. If you move the mouse cursor over the text in the list and click, nothing happens. It only works outside. I think that's not wanted, is it?


Auto-sort broke in v8.3.5

Auto-sorter is always off on page load.
TypeError: Cannot read property 'split' of undefined
    at Object.sortContent (esgst.js:1)
    at Object.giveaways_load (esgst.js:100)
    at async Object.endless_load (esgst.js:1)
    at async Object.loadFeatures (esgst.js:1)
    at async n (esgst.js:100)

Is there no way to run a dev version anymore? At least I can't seem to find anything runnable on github/the source code.
That way I can't provide better Stack-traces anymore.

There is, but only through the pre-release (https://github.com/gsrafael01/ESGST/releases). There's no pre-release right now because it's automatically deleted when a new version is released. Maybe I should change that to make it always available.

At least keeping the most recent one yes, that would be nice

There's a new pre-release available and the most recent one will always be kept now.

But when the error trace says the name of the functions where it happened, you don't really need to provide better traces, I can find it easily. For instance, in this case, I could easily find where the error was coming from by checking out what was being splitted in the function sortContent.


Ghost-Desktop unable to find my blog

OS: macOS 10.13.2
Ghost Desktop Version: 1.5.0
Ghost Blog Version: 1.18.0
[07:53:24.914] gh-edit-blog: Validating Ghost url https://blog.alizée.com/ghost/
/Applications/Ghost.app/Contents/Resources/app/node_modules/electron-log/renderer.js:34 [07:53:26.244] gh-edit-blog: Validation result: false
DevTools failed to parse SourceMap: file:///Applications/Ghost.app/Contents/Resources/app/ember/assets/vendor.map
DevTools failed to parse SourceMap: file:///Applications/Ghost.app/Contents/Resources/app/ember/assets/ghost-desktop.map
/Applications/Ghost.app/Contents/Resources/app/node_modules/electron-log/renderer.js:34 [07:55:37.687] gh-edit-blog: Validating Ghost url https://blog.intralizee.com/ghost/
/Applications/Ghost.app/Contents/Resources/app/node_modules/electron-log/renderer.js:34 [07:55:38.276] gh-edit-blog: Validation result: false
[07:57:39.958] gh-edit-blog: Validating Ghost url https://blog.intralizee.com/ghost/
/Applications/Ghost.app/Contents/Resources/app/node_modules/electron-log/renderer.js:34 [07:57:40.516] gh-edit-blog: Validation result: false

Thank you so much for reporting! That's a real bug, but luckily, I managed to fix it (https://github.com/TryGhost/Ghost-Desktop/pull/309).
I'll make a patch release this week that should allow you to use Ghost Desktop. Sorry for the trouble!


Add emailAddress, url TextInputTypes

Adds support for requesting keyboards optimised for email address and URL entry.

LGTM

Related: flutter/engine#3729, flutter/engine#3730

LGTM. In a future commit (or this one) it would be great to add more colour to these docs.

SGTM. Will overhaul the whole lot in a followup patch in a few minutes to avoid touching the others in this one.


plugin: update bozja intl opcode for 6.15

Untested due to the other networking changes rendering the FFXIV_ACT_Plugin unusable, but the opcode should be correct.
Might need further work based on the extent of the changes required.

Update: I just tested it with the beta plugin and it worked as expected! 🎉


Pasting text with a blank line underneath it shows grey text, unable to send message using Enter key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.6-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720744680218859
Action Performed:
Type a message with a word then a blank space under it
Copy the text and space then send message
Paste the text and space into the compose box
Expected Result:
Actual Result: Text is grey and can't send
Expected Result:
Text and space to show as black/normal text and able to send the messge
Actual Result:
Text is grey and can't send using Enter key
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e25072b1-4eb9-4862-b357-7800b02cfb40
https://github.com/user-attachments/assets/01d3bdd9-231f-4adb-953b-5a33b1a7b620

View all open jobs on GitHub

I think its a specific flow with a workaround for the user, the live markdown library is tough to update, we cannot just CP aa library update and we need to deploy so at this state we should demote imho.
@Skalakid @BartoszGrajdek @tomekzaw for visibility
We could apply some patch though temporarily

Yeah agree that I don't think this needs to be a blocker. Would be great if the live markdown experts have a fix! Seems pretty easy to add a test for too once it's updated.

@m-natarajan @dangrous @mallenexpensify I can't reproduce this issue, can you check if it still occurs? I think https://github.com/Expensify/App/pull/44958 might have fixed it

Screen.Recording.2024-07-15.at.19.41.31.mov

I also couldn't reproduce (v9.0.6-8), I have the same result as the video above.

yes this seems fixed for me as well! I'm going to close - but @mallenexpensify if you're still getting it, let us know!


produce doesn't work correctly

IMPORTANT: If you have a question or an idea for a new feature use Github Discussions instead
Describe the bug
Internal produce function doesn't work correctly. In the example component below nothing happens, however if I change to immer produce everything works well.
To Reproduce
export const Component = () => {
  const [stats, setStats] = createSignal<[string, number][]>([
    ['Luck', 5],
    ['Morality', 5],
    ['Strength', 5],
  ]);

  const inc = (index: number) => {
    setStats(
      produce((s) => {
        s[index][1] += 1;
      })
    );
  };

  return (

      <For each={stats()}>
        {([text, value], index) => {
          return (

                {text}: {value}

              <button onClick={() => inc(index())}>+</button>

          );
        }}
      </For>

  );
};```

**Expected behavior**
The list should be updated on button click.

**Reproduction**
If applicable, add a link to a simple reproduction on a site like https://codesandbox.io or https://playground.solidjs.com.

**Additional context**
Add any other context about the problem here.

This is happening because you are destructuring in the function in <For>
This line: ([text, value], index) =>
What's happening is Immer is replacing the whole top level object and in so triggering everything to re-render again. If you did not destructure there, Solid would be able to update just that text without re-running the whole <For>.

@ryansolid Thank you for your answer!
Just a question then: for instance, I want to iterate through object entries:
 const [store, setStore] = createStore({Luck: 5, Strength: 5, Morality: 5});

const entries = createMemo(() => Object.entries(store));

return (
 <For each={entries}>
...
</For>
)

In this case when I change the store (update Luck value), the entire list will be rendered again. How to update only one item in a list?

I'd probably use Object.keys. Entries produces new arrays each time. Then Id use the key to access the value in the object. This should be able to update independently.

Thank you!

It may be simpler to use immer produce function in this case. I have written a helper function for this: https://github.com/myWsq/solid-immer


Initialise Lock in "second step" for MFA

We (CS) are building some rules for using Passwordless as MFA.
Right now, we are going to hack Lock in order to initialise it in the second step (the view which asks for code in SMS) forcing the state of it as if the first step was already completed.
It would be nice to have the ability to set the phone number when we show it, so lock takes care of sending the SMS and asking for the code. Something like this:
var lock = new Auth0LockPasswordless(cid, domain);
lock.sms({phone_number:’….’});

The screen that asks the verification code will need some changes though:

It doesn't have to show the back button.
It needs a way to resend the verification code, see #73.
More importantly, it needs to let the user now that the SMS is being sent and/or allow to recover when something goes wrong.

Instead of having a new option in the sms method I would add a new one like mfa.

Something to have in mind, it shouldn't start a login process. We don't care about authentication in this case, we need a way to verify the code.
So in this particular implementation, we just need to call the callback with the result of the request to /passwordless/verify and this is particularly because we can't start a new authentication process if we stopped the rules pipeline with a redirect (used for the MFA rule).


Fix typo in ale.txt

Just a single letter typo fix--nothing serious, I'm afraid :)

Cheers! :beers:


Add Ember Suave

:+1:

@homu r+

:pushpin: Commit aaa7760 has been approved by poteto

:zap: Test exempted - status


Move functions from test_applications_from_config.py to simtools.testing

The integration test application test_applications_from_config.py contains rather complicated functions to prepare, run, and validate the integration tests.
This PR moves:

all methods to corresponding modules in the simtools.testing area
new modules are testing.configuration and testing.helpers
renamed the module testing.compare_output to testing.validate_output
added unit tests for all modules

Side note: needed to move the pytest package from the test section to the general in pyproject toml, as some of modules in simtools.testing are importing pytest.
I suggest not to do a line-by-line code review, but review the general refactoring and naming. No new functionality has been added, but code moved around. Also not sure if we need a line-by-line review of units tests.
Closes #1174

@tobiaskleiner - I think I've addressed your suggestions. Let me know if there is anything else I can do.
Thanks for the review!


MINOR: remove get prefix for internal DSL methods

Third follow up PR to https://github.com/apache/kafka/pull/16722

@mjsax Could you please fix conflicts


Fix 6481 - unbounded growth in BackupList from failure retries.

[BUG] Longhorn Instance Manager Memory leak #6481
Three changes:

Put in a log to catch runaway growth.
Ensure only one list entry per customer (backup ID).
Do the prune logic for "error" as well as "completed" status.

Could we run a e2e backup related tests for this one before merging? It is even better if run the full e2e test

@james-munson
Shall we remove the backup from the list if failed toDoBackupCreate?
https://github.com/longhorn/longhorn-engine/blob/master/pkg/sync/rpc/server.go#L721

Looks like this is closed in favor of https://github.com/longhorn/longhorn-engine/pull/927


[feature request] launch application windows in vtm desktop through command line

For now, clicking on the taskbar seems to be the only way to launch a new application window on the vtm desktop.
Is it possible to start up new app windows from the command line? For example, run vtm -w vtm -r term vim ~/.bashrc in bash will launch a new window with ~/.bashrc opened in vim.
In this way, I can startup multiple text editors in separate windows from one shell, and edit files without blocking the original shell (just like notepad .\mytext.txt in windows). With the help of some helper scripts, I can also accomplish some useful features, like double-click to open/preview a file in a new window.

Thanks for the great idea. I'll add this option.

I'll try to use Application Scripting Runtime from #393 without external interpreters for now.
vtm monitor (vtm -m) or server in interactive mode (vtm -s) will read their input line by line and execute it.
List of commands
vtm.runapp("class", "param"={}, "user"={}, coor={}, size={})
vtm.exit()
vtm.shutdown()
vtm.users.disconnect("user")
vtm.users.list()
vtm.apps.list()
vtm.taskbar.menu.item.list()
vtm.taskbar.menu.swap("a_id", "b_id")
vtm.taskbar.menu.add.next("prev id", "xml config")
vtm.taskbar.menu.add.prev("next id", "xml config")
vtm.taskbar.menu.remove("id")
vtm.taskbar.menu.run("id", "user"={}, coor={}, size={})
vtm.taskbar.menu.selected.get()
vtm.taskbar.menu.selected.set("id", "user"={})
vtm.config.get()
...

Usage:
printf "vtm.runapp(term, \"vim ~/.bashrc\")" | vtm -m

It seems to me that there is no need to use the vtm -m monitor cli option in the case of input redirection. This makes usage easier:
echo "vtm.run(dtvt, 'vtm -r')" | vtm
echo "vtm.exit()" | vtm

It remains to add synchronization of environment vars and the current directory.

The syntax needs to be changed, since too many parameters are expected for vtm functions.

New syntax (same as in <menu\item ...> in settings.xml):
vtm.run(label="cmd" type=dtvt title="Command Prompt" footer="test footer" notes=" Windows Command Prompt " cmd="$0 -r term" hidden=no fgc=whitedk bgc=0x00000000 winsize=80,25 wincoor=10,5 winform=undefined)

I decided not to use $0 in this context:
echo "vtm.run(type=dtvt cmd='vtm -r')" | vtm
echo "vtm.dtvt(vtm -r)" | vtm
echo "vtm.dtvt(vtm -r vim ~/.bashrc)" | vtm

I think you can test this feature. 😉

I added a new option - the 'cfg=' tag - with it you can set the configuration in xml-format for dtvt-apps:
echo "vtm.run(type=dtvt cmd='vtm -p p' cfg='<config><menu item*><item id=Term type=dtvt fgc=0xFFffff00 bgc=0xFFff0000 cmd=\'vtm -r\'/></menu><client><background tile=\'\' bgc=whitedk fgc=0 /></client></config>')" | vtm

Can I set id in the vtm.run command to categorize app windows in the task bar? In v0.9.56 All window started from command line are arranged under a new category in the taskbar titled the cmd of the first window launched, and clicking this taskbar item will startup new window using that cmd. I think windows launched without id can be displayed separately in the taskbar.
By the way, vtm.dtvt(bash) (bash can be any other executable file under $PATH) will launch a blank window that could not be closed by the taskbar ×.

Can I set id in the vtm.run command to categorize app windows in the task bar?

In the current implementation, the 'id=' tag is completely ignored, it is replaced by the entire command expression, i.e. 'id=vtm.run(...)'. I need to figure out how to integrate it into the existing menu configuration. A possible way is to take an existing menu item by id and launch a derived instance based on it.

By the way, vtm.dtvt(bash) (bash can be any other executable file under $PATH) will launch a blank window that could not be closed by the taskbar ×.

The executable file does not support DirectVT, and then something goes wrong there. I'll fix this bug and make it closeable. Thanks for testing.

Can I set id in the vtm.run command to categorize app windows in the task bar?

I have implemented the following logic to use the 'id' tag.
If a menu item configuration with the specified 'id' already exists and it was created at desktop startup, then the launched window instance will inherit the existing configuration. Otherwise, it will be overwritten before starting a new window instance while preserving the existing windows in the group.

Adding splitters to the taskbar menu does not work yet.

Run vtm desktop with custom menu from bash:
vtm -d; printf "vtm.del()\nvtm.set(splitter id=s2 label=Group1)\nvtm.set(id=mc cmd=mc)\nvtm.set(splitter id=s1 label=Group2)\nvtm.set(id=htop cmd=htop)\nvtm.selected(mc)" | vtm; vtm

Another syntax
vtm --exec "vtm.del()\nvtm.set(splitter id=s2 label=Group1)\nvtm.set(id=mc cmd=mc)\nvtm.set(splitter id=s1 label=Group2)\nvtm.set(id=htop cmd=htop)\nvtm.selected(mc)"

It is necessary to add the ability to invoke several expressions separated by punctuation. One expression per line is not convenient.
vtm.run(); vtm.run()

I think that at this stage the added functionality is enough. We will return to this issue later when we fully implement integration with external scripting engines.


RFP-001 UX overhaul

Complete UX rework with full navigation.
Still need to bind functionalities.

Closing this since this isn't ready for master yet.  Let's keep developing these on our own forks, and when ready for master, we can clean up the history and open a new PR.


Crash in CBMC output parser with aws-lc-sys crate

Steps to reproduce:

cargo new foo
cd foo
cargo add aws-lc-sys
Put the following in src/main.rs:

use aws_lc_sys::RAND_bytes;

#[kani::proof]
fn foo() {
    let mut buf = [0u8; 1];
    let _ = unsafe { RAND_bytes(&mut buf as *mut u8, 1) };
}

fn main() {}

Run cargo kani

with Kani version: 3ea62b5f78f
I expected to see this happen: Verification failed due to call to foreign C function.

Instead, this happened:
$ cargo kani
Kani Rust Verifier 0.56.0 (cargo plugin)
   Compiling libc v0.2.161
   Compiling shlex v1.3.0
   Compiling paste v1.0.15
   Compiling dunce v1.0.5
   Compiling fs_extra v1.3.0
   Compiling jobserver v0.1.32
   Compiling cc v1.1.34
   Compiling cmake v0.1.51
   Compiling aws-lc-sys v0.22.0
   Compiling foo v0.1.0 (/home/ubuntu/examples/tmp/foo)
warning: Found the following unsupported constructs:
             - foreign function (1)

         Verification will fail if one or more of these constructs is reachable.
         See https://model-checking.github.io/kani/rust-feature-support.html for more details.

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.54s
Checking harness foo...
CBMC 6.3.1 (cbmc-6.3.1)
CBMC version 6.3.1 (cbmc-6.3.1) 64-bit x86_64 linux
Reading GOTO program from file /home/ubuntu/examples/tmp/foo/target/kani/x86_64-unknown-linux-gnu/debug/deps/foo-bd670bc017fbc03f__RNvCs1mm3qvRecAw_3foo3foo.out
Generating GOTO Program
Adding CPROVER library (x86_64)
Removal of function pointers and virtual functions
Generic Property Instrumentation
Running with 16 object bits, 48 offset bits (user-specified)
Starting Bounded Model Checking
aborting path on assume(false) at file /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.22.0/src/x86_64_unknown_linux_gnu_crypto.rs line 26929 column 5 function foo thread 0
Runtime Symex: 0.00084355s
size of program expression: 37 steps
slicing removed 23 assignments
Generated 1 VCC(s), 1 remaining after simplification
Runtime Postprocess Equation: 1.8081e-05s
Passing problem to propositional reduction
converting SSA
Runtime Convert SSA: 0.000134294s
Running propositional reduction
Post-processing
Runtime Post-process: 6.23e-06s
Solving with CaDiCaL 2.0.0
66 variables, 66 clauses
SAT checker: instance is SATISFIABLE
Runtime Solver: 5.6502e-05s
Runtime decision procedure: 0.000236986s
thread '<unnamed>' panicked at kani-driver/src/cbmc_output_parser.rs:462:25:
called `Result::unwrap()` on an `Err` value: Error("control character (\\u0000-\\u001F) found while parsing a string", line: 4, column: 57)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Running with --output-format=old reveals that one of the functions has a unicode character in its name:
[foo.unsupported_construct.1] line 26929 call to foreign "C" function `aws_lc_0_22_0_RAND_bytes` is not currently supported by Kani. Please post your example at https://github.com/model-checking/kani/issues/2423: FAILURE

which the output parser is not expecting.

This is the source code of the function: https://docs.rs/aws-lc-sys/0.22.0/src/aws_lc_sys/x86_64_unknown_linux_gnu_crypto.rs.html#26929
It has a link_name attribute with a unicode character.

Here's a standalone reproducer without any dependencies:
extern "C" {
    #[link_name = "\u{1}f"]
    fn f() -> u32;
}

#[kani::proof]
fn main() {
    assert!(unsafe { f() == 1000 });
}

For context, this is due to how rust-bindgen generates bindings for aws-lc-sys. There is an open issue related to it here: https://github.com/rust-lang/rust-bindgen/issues/2935

Ah, thanks for providing the background!


Design of MessageAttributeValue is inconsistent

When I create a MessageAttributeValue, the default constructor has no parameters, yet the property DataType is required. This isn't discoverable until one actually publishes a message with attributes only to see a validation exception that points to a missing data type.
Expected Behavior

I would expect the constructor to ask for all required data before attempting to create an instance. E.g.
var messageAttributeValue = new MessageAttributeValue(stringValue: "value", dataType: "String");
Current Behavior

Possible Solution

Context

I couldn't catch the described issue with a unit test and discovered while looking at application logs.

Your Environment

AWSSDK.Core version used: 3
Targeted .NET platform: netcore21

.NET Core Info

.NET Core version used for development:
.NET Core version installed in the environment where application runs:
Output of dotnet --info:
Contents of project.json/project.csproj:

Thanks for the feedback on this.  I'm going to change the title of the issue to make it more generic


Chore: Github actions for a push to the repository

As a developer,
Whenever I push a commit to the repository acceptance tests need to be run
A/C :
Create a Github actions to trigger acceptance tests.
Use the tests folder/code in the repository for the test.
Create github workflow when a PR is created with master branch

@mailprak We may need to mock the server or start the server in the actions before running the tests. Is that scope covered as a part of this?

@Priyanka-Kotturi Please scope this issue for
Create github workflow when a PR is created with master branch
We will have another issue for :
a. Create a Github actions to trigger acceptance tests.
b. Use the tests folder/code in the repository for the test.