feature:  Support custom commands for keyring

Summary

Adds ability to use a script or program other than keyring with the same interface as keyring to get password.
Based on suggestion/request from https://github.com/vlad-ivanov-name in #2254
Test Plan

I created a script: my-keyring.sh with a couple variants
First:  Wrap actual keyring
#!/bin/bash
keyring get $2 $3

Second:  Wrap gcloud auth command
#!/bin/bash
gcloud auth application-default print-access-token --scopes="https://www.googleapis.com/auth/cloud-platform" --quiet

and tested on a project I knew to be working by replacing --keyring-provider subprocess with --keyring-provider custom --custom-keyring-command ./my-keyring.sh for both variants

Maybe using the keyring namespace isn't the desired way to go and just having a "custom auth script" option is better?  But since it was requested, I figured I'd throw up this easy PR.
The gcloud auth command script in the PR description shows how a custom script can be an easy/nice way to generate tokens for GAR without having to rely on the python keyring dependency for those looking to migrate.

It's an interesting idea but I think it's too soon to include something like this.
Maybe some sort of custom authentication script makes sense in the future? Not sure. There's also requests like https://github.com/astral-sh/uv/issues/1369 I'd like to take into consideration for whatever workflow we come up with.

It's an interesting idea but I think it's too soon to include something like this.
Maybe some sort of custom authentication script makes sense in the future? Not sure. There's also requests like #1369 I'd like to take into consideration for whatever workflow we come up with.

Understandable - feel free to close.


Fix Missing Dependency Issues and Formatting

Changes the Missing Dependency formatting to be clearer to read.
Includes a warning icon for the Missing Dependency screens.
Fixes being able to softlock the game by backing out of the Missing Dependency menu.
Includes extra Japanese locStrings for the Missing Dependency screens.
We should actually test this lmao

Looks like everything's working as intended

After trying the Japanese version of Brute4 I found it was in the wrong text encoding format and updated it to the right one for this, but after trying this PR locally it still falls back to the English text for some reason.

Japanese Localisation should now properly work.
Should be ready to merge.


Support its examples in AggregateFailures cop

This adds support back to RSpec/Aggregate for non-regular 'its' examples. Initial support was removed in #78 since autocorrections would change 'its' examples to regular 'it' comparisons without explicit reference to the subject. These changes handle 'its' examples specially by injecting the subject, handling all 'its' scenarios outlined in the official rspec/rspec-its spec.

Made those suggested changes @palkan, also fixed the rubocop offenses I had introduced initially.

Looks like RuboCop is still unhappy. Let's disabled Metrics/ClassLength cop for the cop class

@palkan added an exclusion for the RSpec/AggregateFailures cop class to the Metrics/ClassLength cop configuration. RuboCop seems to be satisfied now.

Thanks!

Released in 0.7.2.


SideNav not working in Pinegrow!?

Using your blank theme
Adding navbar
Adding sidenav (in navwrapper)
Adding collapse button
Save file
Click on button doesn't bring up the sidenav in Pinegrow
Opening the page in external browser (i.e. Chrome or Firefox) => Sidenav is working with collapse button

And then...

Restart Pinegrow
Open page
Sidenav now working in Pinegrow, too

Furthermore:

When re-opened the example from above...
Remove Navbar out of tree on right side
Adding new navbar not possible anymore, error: "The element can't be placed here because the destination is a dynamic element, created by Javascript code."

I'm so sorry for being late, I'll work on that as soon as I can.


Cache & Crypt Mount: Subfolders disappearing after several minutes

What is your rclone version (eg output from rclone -V)
v1.38-238-g6f1ae00c
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Windows server 2016 64bit
Which cloud storage system are you using? (eg Google Drive)
Google Drive
The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone mount googleenc: X:
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)
When I first run mount, all the files are there and there is no problem.
If I wait about 5 minutes, the issue starts appearing: the sub-folders are all gone.
I also have an error in the logs:
Entry doesn't belong in directory "" (contains subdir) - ignoring
rclone-log-3.txt
I have attached the full log.
Also my config:
[googleenc]
type = crypt
remote = cache:
filename_encryption = standard
password = XXX
password2 = XXX
[cache]
type = cache
remote = gdrive:/Plex-Encrypted/
plex_url = http://<IP_ADDRESS>:32400
plex_username = XXX
plex_password = XXX
chunk_size = 20M
info_age = 24h
chunk_total_size = 180G
plex_token = XXX
Thanks for your great work!

You should close this and move it to #1904 .. it's the same issue.
Also, make sure you've deleted your cache before running the new beta (1.38-238)

Thanks @jrarseneau I'll do that.
I have started from scratch so I did not have any cache when first running the new beta.


ERROR displays in bottom right of Sprikipedia main page

Describe the bug
There is a red error message that displays when rendering the sprikipedia main page.
To Reproduce
Steps to reproduce the behavior:

Navigate to sprikipedia main page

Expected behavior
The page renders cleanly with no error messages.
Actual behavior
A red error message is visible on the bottom right.
Screenshots

This is recaptcha, I'll work to not appear


Relation db login credentials

In springBoot doc 2.3.1 - relational database -> deployment contains command:
oc new-app -e POSTGRESQL_USER=luke -ePOSTGRESQL_PASSWORD=secret -ePOSTGRESQL_DATABASE=my_data openshift/postgresql-92-centos7 --name=my-database
are all the credentials and db name somehow significant? Does a user need to use them somewhere? The docs should answer this.

@metacosm @cmoulliard When creating a new database application for the relational database on the command line, are the specific values above required? will the booster application work with the database even if different values for POSTGRESQL_USER POSTGRESQL_PASSWORD, POSTGRESQL_DATABASE are used? Can the user opt to use different credentials?

Yea the specific values are significant, they are used in the configuration of the applications.

Spring Boot:

https://github.com/snowdrop/spring-boot-crud-booster/blob/master/src/main/fabric8/credentials-secret.yml
https://github.com/snowdrop/spring-boot-crud-booster/blob/master/src/main/fabric8/deployment.yml#L10-L21
https://github.com/snowdrop/spring-boot-crud-booster/blob/master/src/main/resources/application-openshift.properties

Vert.x:

https://github.com/openshiftio-vertx-boosters/vertx-crud-booster/blob/master/src/main/fabric8/credentials-secret.yml
https://github.com/openshiftio-vertx-boosters/vertx-crud-booster/blob/master/src/main/fabric8/deployment.yml#L7-L16
https://github.com/openshiftio-vertx-boosters/vertx-crud-booster/blob/master/src/main/java/io/openshift/booster/CrudApplication.java#L48-L51

WildFly Swarm:

https://github.com/wildfly-swarm-openshiftio-boosters/wfswarm-rest-http-crud/blob/master/src/main/fabric8/credentials-secret.yml
https://github.com/wildfly-swarm-openshiftio-boosters/wfswarm-rest-http-crud/blob/master/src/main/fabric8/deployment.yml#L10-L21

@Ladicek Thank you:) I figured there would probably be reason for having a particular set of credentials, but didn't know where to look:) Thanks for providing context.
I think we could mention in the docs that the booster application is specifically configured to require these credentials.

Yea I think there should be a note about this. Not sure how detailed that should be.

@Ladicek is a ⭐


re-enable EBT on pubs

Fixed underlying issue causing nodes to flap. EBT should work again.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


I thought you might be interested in knowing that your library works with js backend: https://pietroppeter.github.io/nblog/drafts/easyess_js_ball.html
Have a great week!

Hey awesome! Thanks for sharing! It made me really happy to see my toy project being written about xP
I've not personally ever compiled Nim to js, but awesome that easyess works there as well!


partitions(aws-cn, us-gov) support

All resources of task are hard code partition aws. The partition info should be fetched from boto3 client.

We are using below workaround for reference,
from stepfunctions.steps.fields import Field

attrs=getattr(step, ‘fields’)
attrs[Field.Resource.value]=‘arn:aws-cn:states:::glue:startJobRun.sync’
setattr(step, ‘fields’, attrs)

Noted. Thanks for raising this!
Setting Field.Resource.value for Steps such as this one need to be updated.

How test the fixed version, same issue as previous experienced in cn-north-1.
{
"error": "States.Runtime",
"cause": "An error occurred while executing the state 'Extract, Transform, Load' (entered at the event id #2). The resource belongs to a different partition from the running execution."
}

@hlmiao https://github.com/aws/aws-step-functions-data-science-sdk-python/pull/131 hasn't been merged or released yet. If you want to test it out, you can pull the source from the PR's branch.

Got it.

Released in v2.1.0: https://github.com/aws/aws-step-functions-data-science-sdk-python/releases/tag/v2.1.0


Add support for Yammer using OAuth 2

Fix for issue #393

Hey @janstey, since Yammer dropped OAuth1.0 support seems like adding this would be useful for some users. Thanks for your contribution, it looks like your patch is going in.

See https://github.com/fernandezpablo85/scribe-java/issues/460

@fernandezpablo85 cool. Please ignore the fabric* files in this PR as well. Looks like github did a fresh pull when the PR was opened.

Yeah, that sucks, would you mind removing them from the pr? (just delete them and commit, the PR will update automatically)

Done.

Just one more tweak, please remove the JsonTokenExtractor modifications. If you like, you can submit it as a different PR and we can discuss it over there.

outdated. In case it's actual, rebase on the master pls


command/queueDestroyCommand: replace dialog helper with question helper

for https://github.com/easybib/issues/issues/5659
we are using silex 2 and i get an error when i want to run the destroy command
uecode:qpush:destroy <name>

  [Symfony\Component\Console\Exception\InvalidArgumentException]
  The helper "dialog" is not defined.

found informations here to switch it over. Seems like "dialog" is deprecated
https://github.com/doctrine/migrations/pull/193

A new inspection was created.

out of curiosity, why is it saying "commited with @aequasi" ?

A new inspection was created.

A new inspection was created.

The inspection completed: No new issues

The inspection completed: No new issues

What the hell? Why does it say i committed it....?

Yeah, no clue on this one... maybe just a github bug?
Either way, this looks pretty clean to me - thanks @sashless!

yea dunno, thanks for merging !


Adding support for jQuery 2.2.2.

I've just dumb-bumped the jquery dependency in the project, and the bundled "demo" jquery.js to the latest version, as there is a known security vulnerability in jquery 2.0.3 - https://github.com/jquery/jquery/issues/2432.
Please review the pull request, and in case if the version bump of jquery - removing the known vulnerability from angular-tree-control - seems to make sense, consider merging it and creating a security maintenance release for angular-tree-control.
In case if there are any hidden dependencies/issues caused by this pull request, please let me know, and I'll fix them as soon as possible! :) I've checked the updated demo index.html, and it seems like, this change did not introduce any new issues (however there were issues around the "Events" part, but I decided, they are out of scope for this PR.)

@yoavaa, is there anything I can help you with in order to get the PR merged?

@yoavaa ping?

Wow, thanks! :100:


start and stop fe script

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Process OpModule processed as embedded debug instruction like OpLine, OpNoLine

Optimizer: OpModuleProcessed is like OpLine, OpNoLine

It is a debug instruction that can appear anywhere.
Optimizer classes should store and process it like OpLine
and OpNoLine, which have the same properties.

Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/802
Builds on https://github.com/KhronosGroup/SPIRV-Tools/pull/797

FIxed the debug builds.  The function IsDebugLineInst was being used in an assert, but that has been removed and I forgot to rename its use.

I'm confirming with the SPIR WG that OpModuleProcessed should be treated like this: can appear anywhere.

SPIR WG agreed to restrict OpModuleProcessed to a section "7c" in the layout.

Do not merge this.

Withdrawing this PR


JBPM-5233: Data source management

- adds data source management test modules to the kie-bom

Hello @manstis Would you mind review this PR.
Thanks.

Jenkins please retest this.


Update ThemeData's factory method documents

Catch up document. As Material 3 actually use a purple theme.
https://github.com/flutter/flutter/blob/d8cbaf62615497fdb1e51167d0eb306a2d7b7bcf/packages/flutter/lib/src/material/theme_data.dart#L2777-L2856

@kj415j45 thanks for the contribution!


Update gradients.json

@bwin is ocrrect, the ... in the readme is meant to be an example and denotes the gradient above. Also the file to be changed is the gradients.json in the root folder not in the build folder.
@divankin I suggest you make the required changes and resubmit the pull request. Thanks!


'knife user list some-non-option' should error

Chef 12.0.3 (ChefDK current, aka 0.40)
[@rcf-cm-master:/rcf-cm-master/htdocs/chef-misc] 1 $ knife user list noodle
admin
...
jblaine
...
$

The non-option argument 'noodle' should trigger a usage error.

This is true of all knife TYPE list commands. I've updated the bug title appropriately.


Update AdminUserCreator.java

Made several changes in the formatting and added further more comments to the code.

Sorry, the code is already formatted with the standard IntelliJ formatter. There is no reason for me to use a custom formatting on a single file.
Are you using the Micronaut Camunda Integration? If yes, I'd be happy if you contact me<EMAIL_ADDRESS>


Bézier Path point

Hello,
Thanks for this code. It really helpful for me.
This code is perfect but my suggestion is that if u  can move Bézier Path point  so it's more perfect than before....

Hi ronakcc,
I don't follow- can you describe what you'd like in more detail?

Hello,
Thanks for reply!
I mean to say when we set a bezier path point so after we set bezier path point so this point should be movable..
See this image so you will get more idea about this.

Thanks for the suggestion!
Yes, that's something I'd like to add.  My plan for this project is to port it to Swift and create a cocoapod so its easier to use/install.  At that time, I will consider making the points draggable.

Hello John,
I need your help...can you develop draggable point code for me becz i tried a lot bt it was not work properly..so if you have a time so send me early as possible..nd thanx for your positive reply dear..


Deleted entities are not cleaned up

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
I deleted a lot of lights and scenes from my Tahoma, but hours later they are still present in Home Assistant. It seems deleted entities are not cleaned up.
What version of this integration (ha-tahoma) has the issue?
2.9.4
What version of Home Assistant Core has the issue?
2021.11.5
Which gateway / hub do you use?
Somfy TaHoma
Device model
No response
Home Assistant log
No response
Additional information
No response

Thanks for reporting @sdebruyn! Could you perhaps try to reproduce this with debug mode on? This will help us understand if the correct events are fired, and if the issue is in our handling code.
For contributors; it seems that the code here is not working well:
https://github.com/iMicknl/ha-tahoma/blob/bb7e221dbf908fa3e4e107dacbcaed07735c6069/custom_components/tahoma/coordinator.py#L123-L130

2022-02-04 14:31:10 DEBUG (MainThread) [custom_components.tahoma.coordinator] Event(timestamp=1643981463927, name=<EventName.DEVICE_REMOVED: 'DeviceRemovedEvent'>, setupoid=_CountingAttr(counter=402, _default=None, repr=<function obfuscate_id at 0x7f8fa6508c10>, eq=True, order=True, hash=None, init=True, on_setattr=None, metadata={}), owner_key=None, type=None, sub_type=None, time_to_next_state=None, failed_commands=None, failure_type_code=None, failure_type=None, condition_groupoid=None, place_oid=None, label=None, metadata=None, camera_id=None, deleted_raw_devices_count=None, protocol_type=None, gateway_id=None, exec_id=None, device_url=zwave://****-****-2554/2#2, device_states=[], old_state=None, new_state=None)
2022-02-04 14:31:10 DEBUG (MainThread) [custom_components.tahoma.coordinator] Event(timestamp=1643981463930, name=<EventName.SETUP_JOB_COMPLETED: 'SetupJobCompletedEvent'>, setupoid=_CountingAttr(counter=402, _default=None, repr=<function obfuscate_id at 0x7f8fa6508c10>, eq=True, order=True, hash=None, init=True, on_setattr=None, metadata={}), owner_key=None, type=None, sub_type=None, time_to_next_state=None, failed_commands=None, failure_type_code=None, failure_type=None, condition_groupoid=None, place_oid=None, label=None, metadata=None, camera_id=None, deleted_raw_devices_count=None, protocol_type=None, gateway_id=None, exec_id=None, device_url=None, device_states=[], old_state=None, new_state=None)

Thanks @jensihnow!


API spec for new DirectWrite font selection APIs

Thanks! I've incorporated your feedback. Thanks for taking a look!

In reply to: 798475190


How to add and connect to Remote videos?

Hello! I am working on react native project which includes live streaming of remote videos but I am not able to figure out how and where to add remote video url and connect to it.

Is you app using WebRTC? We don't use video URLs, they are just an instrument to connect the stream to the video view.

Yes, I am using webRTC in my app. Then how can i connect to remote video stream ?

Yes, I am using webRTC in my app. Then how can i connect to remote video stream ?

You can see this demo:


Add library for status leds

I don't know if this is useful, but while looking at the address decoder I noticed there were libraries for every one of the peripherals but this one :smile:
Add a library for the system status. Currently this has only one functionality: set the 8 leds on the ULX3S:
void status_set_leds(uint8_t val);

Also add a simple application "blinky" that demonstrates this.

Thanks, this can also serve as a more minimal demo than hello_world which does have a few moving parts.

Updated:

Added initial value for frame
Added doc comment for status_set_leds

Great, thanks :+1:


Add support for NET4.0 to the nuget package

Hello.
Entity framework 6.x nuget package support for NET4.0 and NET 4.5, but EFInitializer has NET 4.5 only.
We can't use it in NET 4.0 project without reference upgrade.
I think, that your initializer will work fine under NET 4.0 framework, so net45 subfolder is useless.

Please check my pull request #8


Improve PCA and spectral inits

A tiny PR that would fix #224, #223, and #180. I am not insisting on any of these changes, but thought I make the PR to make it easier to discuss.

A lot of tests fail because we would need to fix random seeds over there. I'm not doing it for now -- let's discuss first.

I think adding a tiny amount of noise to each initialization is fine if it solves all these issues. I'm used to calling this jitter, so that's what I'll call it. However, I think the user should be able to turn this off. For instance, we could add a general parameter TSNE(..., jitter_initialization=True) so that the user can still turn this off. I would also put this into its own separate function e.g.
def jitter(x, scale=0.01, random_state):
    std = np.std(x[:, 0])
    target_std = std * scale
    return x + random_state.normal(0, std, x.shape)

The we can call this pca, spectral, and any other initializations we have. I definitely wouldn't add this to the rescale function as that could be very confusing having rescale also actually change our initialization. We can turn this off by default for precomputed embeddings, but this might be a pain, because then we'd again need to implement something like jitter_initialization="auto" so we can figure out if we need to jitter or not. Maybe it would be easier to just enable jittering by default for all initializations, and if the user wants, they can turn this off manually. We'd need to document this behaviour in the initialization parameters.

Sure, let me move jitter out of rescale() into jitter().
I also agree that there should be a way to switch it off. What about adding add_jitter=True parameter to pca() and to spectral()? Then the user would be able to switch jitter off by manually calling e.g. pca(add_jitter=False).
I am not so sure about having the global parameter like TSNE(..., jitter_initialization=True), because indeed I think it would make more sense not to add jitter to a user-provided initialization.

What about adding add_jitter=True parameter to pca() and to spectral()? Then the user would be able to switch jitter off by manually calling e.g. pca(add_jitter=False).

Yes, this is exactly what I had in mind. We should add this to both pca and spectral. The other two -- weighted_mean and median can only be used when adding new points to an embedding, and they ignore one another, so it doesn't make any difference if we jitter those, so I wouldn't add the jitter parameter to those.

I am not so sure about having the global parameter like TSNE(..., jitter_initialization=True), because indeed I think it would make more sense not to add jitter to a user-provided initialization.

So you'd want to have jitter on by default for pca and spectral, but have it off for precomputed? The issue I see with that is that the user then can't use standard pca without jitter without having to precompute the initialization, then passing it through the constructor.
It might be fine though. The TSNE constructor has enough parameters as it is, and nobody will notice this in practice, since the added noise should be very small. Okay, I think this is fine for now then, and we'll add the parameter later, if we find any need for it.

Agree. I refactored the jitter code, and also added a test that checks that our spectral init coincides with sklearn spectral embedding. Luckily, it passes :-)
I also had to fix random seeds in some existing tests that used PCA/spectral initializations.

Great, thanks! I'll close the related issues.


Make graphql a peer dependency

I also updated graphql to 0.6.0 since there are no breaking changes and all tests passed with it. However if you don't want to update yet I'll change it back to 0.5.0.
Fixes #50.

Reverted to<EMAIL_ADDRESS>because of npm install failing on Node v4.

Thanks! I don't think the npm install issue was related, but we can update to 0.6.0 in a separate PR. (Travis just fails sometimes, and you have to restart the job)


Deploy the dashboard on DDSC website

The dashboard needs to be deployed on the website in a safe and stable way.

@saattrupdan we should have a discussion on online meeting to figure out how we host the applikation on our domain. We need to consider a few things. First. We cannot deploy the application on some cloud service and expect it to also be accessable through some path on ddsc.io/salary/dashboard for instance. This is due to the fact that the cloud servers are not allowed on our domain for obvious reasons.
What we instead could do is link to some other domain from ddsc.io, but the question becomes, is that what we want? If we where to host the application ourselves we could do so by simply placing it behind an Nginx proxy. Let me know what you guys think about this, cause then I could start trying that out on staging.ddsc.io for you to test etc.

@IIMunchII Let's discuss it later. I don't have time these days to work on it, but there's so rush either. Let's discuss this in a week or two 🙂

Now live at https://ddsc.io/members/salary !


Add LGTM static analyzer

Looks like it works: https://lgtm.com/logs/3f988a87881471699aa47f556c9dbd43480ddd43/lang:cpp

Gonna go ahead and just commit this b/c it's relatively inoffensive and can be easily ripped out if there's objection.


download_all_data.sh: no such file

I ran download_all_data.sh with plenty of hard drive space, and received the following error:
 *** Download Progress Summary as of Sun Dec 12 12:46:25 2021 ***
====================================================================================================
[#1dfa7c 22GiB/32GiB(67%) CN:1 DL:79MiB ETA:2m19s]
FILE: ../data/mgnify/mgy_clusters_2018_12.fa.gz
----------------------------------------------------------------------------------------------------

 *** Download Progress Summary as of Sun Dec 12 12:47:25 2021 ***
====================================================================================================
[#1dfa7c 26GiB/32GiB(80%) CN:1 DL:73MiB ETA:1m30s]
FILE: ../data/mgnify/mgy_clusters_2018_12.fa.gz
----------------------------------------------------------------------------------------------------

 *** Download Progress Summary as of Sun Dec 12 12:48:26 2021 ***
====================================================================================================
[#1dfa7c 30GiB/32GiB(92%) CN:1 DL:55MiB ETA:43s]
FILE: ../data/mgnify/mgy_clusters_2018_12.fa.gz
----------------------------------------------------------------------------------------------------

[#1dfa7c 32GiB/32GiB(99%) CN:1 DL:69MiB]
12/12 12:48:57 [NOTICE] Download complete: ../data/mgnify/mgy_clusters_2018_12.fa.gz

Download Results:
gid   |stat|avg speed  |path/URI
======+====+===========+=======================================================
1dfa7c|OK  |    68MiB/s|../data/mgnify/mgy_clusters_2018_12.fa.gz

Status Legend:
(OK):download completed.
/ebio/abt3_scratch/alphafold/v2/data/mgnify /ebio/abt3_scratch/alphafold/v2/alphafold
gzip: ../data/mgnify/mgy_clusters_2018_12.fa.gz: No such file or directory

 ../data/mgnify/mgy_clusters_2018_12.fa.gz does in fact exist.
Maybe file latency is not accounted for in download_mgnify.sh:
mkdir --parents "${ROOT_DIR}"
aria2c "${SOURCE_URL}" --dir="${ROOT_DIR}"
pushd "${ROOT_DIR}"
gunzip "${ROOT_DIR}/${BASENAME}"
popd

Could you try providing the download dir argument to download_mgnify.sh as an absolute path instead of ../data/?

Maybe it would be best to just get rid of the pushd and popd, since they are not necessary. The output location can be directly set for gunzip

The current script seems to be working for us - could you retry with the suggested DOWNLOAD_DIR argument, and if that doesn’t work we can reopen the issue.

@andycowie I guess that I could make the code more user-friendly myself. Do you accept PRs?


BUG: Allow empty property name with GeoJSON driver

Ref: https://github.com/geopandas/geopandas/issues/1611

Coverage decreased (-0.1%) to 87.06% when pulling 649ab24e156228d77eee3393486f51ecbe6cb5d8 on snowman2:geo_empty into ab48d3ec81561e92d75f65c5165044af9f4bb7e0 on Toblerity:maint-1.8.

@snowman2 the less driver-specific code we have in this part of Fiona, the better, so I hesitate to accept this. I think we must also check with GDAL's maintainer about whether empty field names are allowed in the OGR data model (see https://gdal.org/api/ogrfeature_cpp.html#_CPPv412OGRFieldDefn) or if this only works by accident. Would you be willing to ask on gdal-dev?

I think we must also check with GDAL's maintainer about whether empty field names are allowed in the OGR data model

I did some testing with ogr2ogr and ogrinfo and it seems like the empty string is supported across drivers:
ogr2ogr -f GPKG samplecafe_halfhalfhalfhalfhalfEmpty2.gpkg samplecafe_halfhalfhalfhalfhalfEmpty2.geojson
ogr2ogr -f "ESRI Shapefile" samplecafe_halfhalfhalfhalfhalfEmpty2.shp samplecafe_halfhalfhalfhalfhalfEmpty2.geojson

INFO: Open of `samplecafe_halfhalfhalfhalfhalfEmpty2.gpkg'
      using driver `GPKG' successful.

 I will check the GDAL tests first and if I don't find anything I will post the question there.

From what I can tell from the code, it allows any string for the field name, even an empty one:
pszName is of type char *.
And OGRFieldDefn::SetName doesn't have any constraints on what can be set to the field name, so even an empty field name is allowed.

Based on that, this check for an empty field name could be removed entirely. I will send a note to the list to ask about whether this behavior is intended as I don't see any tests explicitly testing this.

Interesting discovery ... the CSV driver seems to give the field a name based on the index (field_22):
ogrinfo -so samplecafe_halfhalfhalfhalfhalfEmpty2.csv samplecafe_halfhalfhalfhalfhalfEmpty2
INFO: Open of `samplecafe_halfhalfhalfhalfhalfEmpty2.csv'
      using driver `CSV' successful.

Yeah, not super great. How about adding a warning instead? Probably good for the user to know that they are playing with :fire:.

Great idea @snowman2 . A warning would be appropriate and very welcome.

I found that the FeatureBuilder was doing the same thing and modified it so the errors and warnings were the same.

Sure, feel free to adjust as you want 👍

Thanks for the review @sgillies :+1:


BSM PartII Data Redaction

Purpose
The changes in this PR allow the BSMHandler to redact specified fields in the partII section of BSM messages.
Notes

The BSMHandler makes use of the fieldsToRedact.txt file, which is located the project root folder.
Three new tests have been introduced, one to test the RedactionPropertyManager and two to test the partII redaction.
At this time, an instance of the RedactionPropertyManager class is initialized with each BSM message that goes through processing. Each time it is initialized, the fields are loaded in. We may want to consider making this a part of the BSMHandler class if we can to minimize the number of times that the fields are loaded in.

At this time, we only have one test BSM that is getting tested for partII redaction. We might want to add some more.

Looks good!


Try hard to match pulp repo id as well

CLOUDBLD-2817

Signed-off-by: Chenxiong Qi<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request has a link to an osbs-docs PR for user documentation updates
n/a New feature can be disabled from a configuration file

Is this change worth a unittest?

@MartinBasti A test is updated for this change.


Fix UI fingerprint mappings -

Fixes #867

Add openapi doc to website

Merged.
Thanks for your contribution !

@jesperpedersen this failed the CI because of the linter, I need to fix that

@johnaohara Passed locally

The code is ok, but the local test does not run the linter


[ShrinkBorrowScope] Track barrier term successors.

Previously, ShrinkBorrowScope's misbehaved when isDeinitBarrier always returned true, as ought to happen when Swift compiler sources are absent.  In the following example
left:
  br exit
right:
  br exit
exit:
  copy_value %borrow
  end_borrow %borrow

ShrinkBorrowScope would classify the copy_value instruction as ::Copy--a non-barrier classification.  So reachability would proceed to exit's predecessors.  It would then determine that both branches were barriers--because isDeinitBarrier would return true for both.
ShrinkBorrowScope would then attempt to insert one end_borrow per terminator barrier:
left:
  br exit
right:
  br exit
exit:
  end_borrow %borrow
  end_borrow %borrow
  copy_value %original

Here, we add a set of block's at the beginning of which an end_borrow was inserted for this reason.  If one was already added, one cannot be added again.

@swift-ci please test

@swift-ci please test


CI: Move to Google Cloud Storage

How would one update the test data tarball, or is it manual?

Currently manual, though I could look into making it possible through the command line.

No worries, I think it's fine for now


Add styleDestination to pipe(filter) in style task

Adding styleDestination to .pipe(filter) in the styles task to prevent browserSync force reload when working in remote folders.
Types of changes
FIX: reload browsersync properly when working with remoteFolders.
How Has This Been Tested?
In a local environment using WPGulp to modify the behaviour of remote folders.
Checklist:

[YES] My code is tested.
[YES] My code follows the WordPress code style.
[---] My code follows has extensive inline documentation like the rest of WPGulp.

Hey, @kevinmamaqi!
Thanks for the PR but the styleDestination is set in the following line. After that the path is relative to this one.
.pipe( gulp.dest( styleDestination ) )

So, your PR will break it. Which is why I am closing it. We'd love for you to checkout #61 WPGulp 2.0 development.

Thanks, Although in my local environment is not relative, and took me a while to figure it out. I have the following:
var styleDestination        = '../../../mysite/app/public/wp-content/themes/' + theme_name + '/';        // Path to place the compiled CSS file.

// And in the styles task
.pipe( gulp.dest( styleDestination ) )

    .pipe( filter( styleDestination + '**/*.css' ) ) // Filtering stream to only css files
    .pipe( browserSync.stream() ) // Reloads style.css if that is enqueued.

Without the styleDestination in the filter it doesn't reload properly.

Why are you adding '../../../ this before the path? You should have WPGulp inside your theme root and from there you can use ./path to your styles I think and you'll be fine

I do not find necessary/handy to have everything in the same folder. In addition, there's no build function in wp-gulp.

Well, gulpfile.js should be in the root. Otherwise, it won't work.


DO_NOT_MERGE testing vNext_dersim_1134 branch

This change is

PR is added to the queue for testing as 1. task. (5eac790)

Hi @dersim-davaod, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 86472885 build is completed (5eac790)
See https://github.com/ThaliTester/TestResults/tree/864728855eac790_DO_NOT_MERGE_testing_vNext_dersim_1134_branch_dersim-davaod/ for the logs

Test 864728855eac790(5eac790) has failed
See https://github.com/ThaliTester/TestResults/tree/864728855eac790_DO_NOT_MERGE_testing_vNext_dersim_1134_branch_dersim-davaod/ for the fail logs

PR is added to the queue for testing as 3. task. (0b65ede)

PR is added to the queue for testing as 4. task. (3590d1f)

Test (Success) 86472885 build is completed (3590d1f)
See https://github.com/ThaliTester/TestResults/tree/864728853590d1f_DO_NOT_MERGE_testing_vNext_dersim_1134_branch_dersim-davaod/ for the logs

Test<PHONE_NUMBER>90d1f(3590d1f) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/864728853590d1f_DO_NOT_MERGE_testing_vNext_dersim_1134_branch_dersim-davaod/ for the logs

Shouldn't this be to vNext and not master?

Review status: 0 of 293 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[FEATURE] Add a way to stop the livefeed eventloop

Is your feature request related to a problem? Please describe.
Once you've started the home live feed loop with home.start_livefeed(), there is no way of stopping it. This would be useful for unit tests and could be handy in other places too.
Describe alternatives you've considered
Conditional-based approach
Pass a condition or a function that is evaluated every time a message is received. If it is evaluated to True, the loop ends.
# Exit after 10 seconds
start_time = time.perf_counter()
# Note that data will always be first parameter of the condition function.
# This way, the livefeed can exit based on data conditions
def condition(data):
    return time.perf_counter() - start_time > 10
home.start_livefeed(exit_condition = condition)

# Exit when accumulated cost goes above 10
home.start_livefeed(exit_condition = lambda data: data.accumulated_cost > 10)

Time-based approach
Exit after x seconds.
# Exit after 10 seconds
home.start_livefeed(exit_after = 10)

Iteration-based approach
Exit after x amount of iterations.
# Exits after data has been received 10 times
home.start_livefeed(exit_after = 10)

Describe the solution you'd like
The iteration-based approach is more unpredictable because the time at which data is received is not always known or consistent. Also, it could be possible to exit after x amount of iterations by using the conditional-based approach.
The time-based approach does not guarantee that data will be received within the timeframe.
I would therefore suggest adding at least the conditional-based approach and the time-based approach in case a user
would for some reason want to exit after a certain amount of time (which is a bit clunky to do using the conditional-based approach).

Hi @BeatsuDev,
I would just like to add that the livefeed event loop also is not very resilient to outages of the Tibber API or other network issues.  In other words once the feed is interrupted or fail for any reason, it does not restart.  For this reason when one is using this live feed as a long running service it might be better to use this feature you suggest and have the live feed start and poll for a number of secs or iterations and then exit.  If we then put these steps in a loop, we have something that will self recover.
Is there any planning for when this feature might be added ?

Sorry for the late response! I'll definitely look into it as soon as I have time. You have a great point. There's no plan for now, but I'll change some things about it as soon as I can.

Hi @BeatsuDev,
I would just like to add that the livefeed event loop also is not very resilient to outages of the Tibber API or other network issues. In other words once the feed is interrupted or fail for any reason, it does not restart. For this reason when one is using this live feed as a long running service it might be better to use this feature you suggest and have the live feed start and poll for a number of secs or iterations and then exit. If we then put these steps in a loop, we have something that will self recover.
Is there any planning for when this feature might be added ?

Added in 6efb414bd74e7ff533bf3ac28c911c29ff1ac1c2!

As for the issue, I've made this change: https://github.com/BeatsuDev/tibber.py/commit/9f7ac25547ac39d7d178e099dab4602463d74c11, implementing the conditional-based approach described in the issue description. I'll see how it works and run some extra tests tomorrow. If everything works fine, I'll consider uploading both fixes to pypi in version 0.3.0 or 0.2.1 (not quite sure yet) and closing this issue for now.

Added this in version 0.2.1 😄


pull request for e2e test at 12/12/2016 11:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fails to initialise with a HOT_WATER zone

Using a minimal config.json:
{
    "bridge":
    {
        "name":         "Homebridge Tado",
        "username":     "...",
        "port":         ...,
        "pin":          "..."
    },

    "platforms":
    [{
        "platform":     "TadoPlatform",
        "name":         "Tado",
        "debug":        false,
        "user": [{
            "username": "...",
            "password": "..."
        }]
    }]
}

attempting to start homebridge with this plugin results in the following error:
[Tado] An error occured during setting up plugin!
[Tado] TypeError: Cannot read property 'celsius' of undefined
    at Object.add (/usr/local/lib/node_modules/homebridge-tado-platform/src/tado/tado-config.js:126:45)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
    at TadoPlatform.setupPlugin (/usr/local/lib/node_modules/homebridge-tado-platform/src/platform.js:131:29)

Enabling debug reveals that the problem occurs when processing the HOT_WATER zone which does not support any temperature control, so there is no capabilities.temperatures object:
[Tado] Configuration: Checking access token..
[Tado] Configuration: Access token NOT expired
[Tado] Configuration: Using https://my.tado.com
[Tado] Configuration: API request GET /api/v2/homes/329647/zones <pending>
[Tado] Configuration: API request GET /api/v2/homes/329647/zones <success>
[Tado] Configuration: API request GET /api/v2/homes/329647/zones <response> [{"id":0,"name":"Hot Water","type":"HOT_WATER","dateCreated":"2019-05-16T15:57:55.867Z","deviceTypes":["BU01","RU02"],"devices":[{"deviceType":"BU01","serialNo":"BU2976583680","shortSerialNo":"BU2976583680","currentFwVersion":"81.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:46:10.672Z"},"characteristics":{"capabilities":[]},"isDriverConfigured":true,"duties":["ZONE_DRIVER"]},{"deviceType":"RU02","serialNo":"RU2758741760","shortSerialNo":"RU2758741760","currentFwVersion":"82.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:36:32.297Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"batteryState":"NORMAL","duties":["ZONE_UI","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":false,"dazzleEnabled":false,"dazzleMode":{"supported":false},"openWindowDetection":{"supported":false}},{"id":1,"name":"Living/Dining Room","type":"HEATING","dateCreated":"2019-05-07T15:14:31.395Z","deviceTypes":["RU02","VA02","VA02","VA02"],"devices":[{"deviceType":"RU02","serialNo":"RU...","shortSerialNo":"RU...","currentFwVersion":"82.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:36:13.725Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"batteryState":"NORMAL","duties":["ZONE_UI","ZONE_LEADER"]},{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:46:03.776Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-03-27T16:29:37.302Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER"]},{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:43:39.333Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-05-09T07:09:40.890Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER"]},{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:48:00.600Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-11T18:21:13.275Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":8,"name":"Hallway","type":"HEATING","dateCreated":"2019-05-16T15:57:52.838Z","deviceTypes":["RU02"],"devices":[{"deviceType":"RU02","serialNo":"RU...","shortSerialNo":"RU...","currentFwVersion":"82.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:36:32.297Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"batteryState":"NORMAL","duties":["ZONE_UI","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":4,"name":"Office","type":"HEATING","dateCreated":"2019-05-10T15:58:22.057Z","deviceTypes":["VA02"],"devices":[{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:47:57.781Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-11T23:58:52.912Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":3,"name":"Bedroom","type":"HEATING","dateCreated":"2019-05-07T15:21:23.807Z","deviceTypes":["RU02","VA02"],"devices":[{"deviceType":"RU02","serialNo":"RU...","shortSerialNo":"RU...","currentFwVersion":"82.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:40:19.557Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"batteryState":"NORMAL","duties":["ZONE_UI","ZONE_LEADER"]},{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:37:51.220Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-11T19:51:02.414Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":6,"name":"Guest Bedroom","type":"HEATING","dateCreated":"2019-05-10T16:07:42.548Z","deviceTypes":["VA02"],"devices":[{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:48:10.823Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-12T00:31:05.842Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":5,"name":"Bathroom","type":"HEATING","dateCreated":"2019-05-10T16:03:53.514Z","deviceTypes":["VA02"],"devices":[{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:44:30.963Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-02T14:15:22.128Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}},{"id":7,"name":"Spare Room","type":"HEATING","dateCreated":"2019-05-10T16:12:43.121Z","deviceTypes":["VA02"],"devices":[{"deviceType":"VA02","serialNo":"VA...","shortSerialNo":"VA...","currentFwVersion":"79.1","connectionState":{"value":true,"timestamp":"2021-05-09T11:47:11.975Z"},"characteristics":{"capabilities":["INSIDE_TEMPERATURE_MEASUREMENT","IDENTIFY"]},"mountingState":{"value":"CALIBRATED","timestamp":"2021-02-02T14:22:08.102Z"},"batteryState":"NORMAL","childLockEnabled":false,"duties":["ZONE_UI","ZONE_DRIVER","ZONE_LEADER"]}],"reportAvailable":false,"supportsDazzle":true,"dazzleEnabled":true,"dazzleMode":{"supported":true,"enabled":true},"openWindowDetection":{"supported":true,"enabled":true,"timeoutInSeconds":3600}}]
[Tado] Configuration: Checking access token..
[Tado] Configuration: Access token NOT expired
[Tado] Configuration: Using https://my.tado.com
[Tado] Configuration: API request GET /api/v2/homes/329647/zones/0/capabilities <pending>
[Tado] Configuration: API request GET /api/v2/homes/329647/zones/0/capabilities <success>
[Tado] Configuration: API request GET /api/v2/homes/329647/zones/0/capabilities <response> {"type":"HOT_WATER","canSetTemperature":false}
[Tado] An error occured during setting up plugin!
[Tado] TypeError: Cannot read property 'celsius' of undefined
     at Object.add (/usr/local/lib/node_modules/homebridge-tado-platform/src/tado/tado-config.js:126:45)
     at processTicksAndRejections (internal/process/task_queues.js:85:5)
     at TadoPlatform.setupPlugin (/usr/local/lib/node_modules/homebridge-tado-platform/src/platform.js:131:29)

This is with:

homebridge-tado-platform 6.0.12
homebridge 1.3.1
node 12.8.0

Fixed in v6.0.13

I confirm that this issue is fixed in version 6.0.13.
Thank you @SeydX.


TypeInitializationException with NET 4.8 and WWF

I have this very strange issue where I receive a TypeInitializationException whenever the .net attempts to run the ModuleConstructor for the Microsoft.VisualBasic.Activities.Compieler.dll in a very specific scenario.
The scenario:
I have an OData batch request that sends a changeset (transactional request) to the server with 2 requests inside. The first request updates an item and passes successfully. The second requests invokes a xamlx file by loading it and calling the WorkflowApplication.Run() (from WWF). But then the second request fails with a TypeIntiializationException saying that the
"The type initializer for '<Module>' threw an exception." and the module being Microsoft.VisualBasic.Activities.Compiler.dll.
The inner error being:
The C++ module failed to load while attempting to initialize the default appdomain.
The next inner error being:
Type 'Custom.CustomIdentity' in Assembly 'Custom, Version=...' is not marked as serializable.
We have a custom IPrincipal(CustomPrincipal and CustomIdentity classes) set in the current Thread that are used for authentication and authorization.
Once this module fails to initialize further requests for this batch request stay broken until we recycle the app pool.
This was working fine with .net 4.7.2.
The one thing that helped mitigate the problem was this article
Wrapping our custom principal in a MarshalByRef object helps to avoid the problem. However I think there might be some breaking change introduced in the WWF as there were a lot of changes introduced with the .net 4.8 release

Is your CustomIdentity class marked as Serializable ?

Then the bottom error transforms to "Could not load file or assembly 'Custom, Version=...' or one of its dependencies. The system cannot find the file specified"

Years ago, I implemented a CMS system with support for C#/VB and XAML workflows. It has been running code-untouched on 4.5 (what was originally used to write the code) through to 4.8. I am guessing your issue has something to do with how you are loading up your XAMLX.
Could you post some code-extracts of how you are doing this part?

The second requests invokes a xamlx file by loading it and calling the WorkflowApplication.Run() (from WWF)

Specifically which overload(s) of Assembly.Load are you using? And how are you instantiating the Activity? If it helps, here are some pieces from mine:
Assembly load
// CompilerOutputAssembly is a at the point with type Assembly
CompilerOutputAssembly = Assembly.Load(File.ReadAllBytes(primaryAssemblyPath));

Instantiation
System.Activities.Activity v4Activity = (System.Activities.Activity)workflowAssembly.CreateInstance(workflowClassName, true);

Also, since you mention you moved from 4.7.2 to 4.8, ensure that the System.Activities DLL reference is correct. I have had trouble in the early days of it loading one up from the wrong .NET FX.

I checked the reference. It points to 4.8. If I compile my project against 4.7.2, but still have 4.8 installed, the issue is still reproducible.
So my xamlx files are embedded resources and are loaded like so:
private static Activity LoadContentApprovalWorkflow(string workflowServiceVirtualPath)
{
     using (var stream = Abstractions.VirtualPath.VirtualFile.Open(workflowServiceVirtualPath))
               {
                    System.ServiceModel.Activities.WorkflowService service = (System.ServiceModel.Activities.WorkflowService)XamlServices.Load(stream);
                                sequence = (Sequence)service.Body;
                                return sequence;
                }
}

And the code that executes the worklfow:
var activity = WorkflowManager.LoadContentApprovalWorkflow(workflowUrl);

var evt = new ManualResetEvent(false);

var workflowApplication = new WorkflowApplication(activity)
{
	Completed = eventArgs => DisposeWorkflowThread(evt, requiresTransaction),
	Aborted = eventArgs => DisposeWorkflowThread(evt, requiresTransaction),
	OnUnhandledException = OnWorkflowUnhandledException

};

workflowApplication.Run(); // throws error here.
evt.WaitOne();

One interesting observation from the tests I've made is that if I run the second piece of code during application start-up before any batch request gets executed - everything works fine with subsequent batch requests.
It seems to me that some static variable initialization is failing somewhere along the execution of the batch request and then remains broken until app pool recycle. If however this static initialization is done before the batch request, everything works fine. Which led me to attempt to try the following code during app startup (runs the module initializer of the "Microsoft.VisualBasic.Activities.Compiler" assembly)
var assemblies = AppDomain.CurrentDomain.GetAssemblies();

            foreach (var assembly in assemblies)
            {
                if (assembly.FullName.StartsWith("Microsoft.VisualBasic.Activities.Compiler"))
                {
                    var modules = assembly.GetLoadedModules(false);
                    foreach (var module in modules)
                    {
                        RuntimeHelpers.RunModuleConstructor(module.ModuleHandle);
                    }
                }
            }

It did not help, but the interesting thing is that this code does not throw any errors during startup, but if I execute the batch request and achieve the above mentioned error, this same peace of code will throw the same error. This is one of the reasons I think some static variable initialization is failing somewhere.

Instrument and narrow it down? I don't see how anyone can give you further ideas on this...

@Gebov Thanks for reporting this. I looked through the changes we made to Workflow in 4.8 and none of them stand out as something that would impact this scenario. It doesn't look like we changed Microsoft.VisualBasic.Activities.Compiler.dll or the places in the code where we're calling into it.
It sounds like you are hitting a similar problem to what's described in the article you linked. In this case we're also calling into unmanaged code so your custom objects have to get serialized/marshaled. It makes sense that the same workaround works for you.
Unfortunately I'm not sure what we can do unless you can narrow down the cause of the difference in behavior. The error seems to be coming from the "Type 'Custom.CustomIdentity' in Assembly 'Custom, Version=...' is not marked as serializable." error, which turned into "The system cannot find the file specified" if you mark it as serializable. What was happening here when it was working? Was it able to find the assembly location for some reason but it's unable to now? Or did it lose permission to load from that location? Or was it able to serialize/marshal it but for some reason it can't with the new version? If you can understand how this marshaling or serialization was being handled in the working case we can investigate what changed about it to cause this behavior difference.
It sounds like you have a workaround to avoid the issue, which is good because then this shouldn't block you. It would be great if we can narrow down why the behavior is different so we can see if it's something we can fix.

@dasetser Sorry for the late response. I can only speculate that the main reason is the type was not serialized before and is being serialized with the new version. The only reproducible scenario that I have found working is that installing .net 4.8 will cause the exception on the same application that was running fine with .net 4.7.2. It would be very helpful if I could debug the .net assemblies somehow (the debug version of them).  This way I think I can narrow it down. I tried using reference source, but going through the optimized code did not help that much.

@Gebov To my knowledge since this issue is for the .NET Framework all you can do is follow the instructions listed in https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-debug-dotnet-framework-source?view=vs-2019 as well as disabling JIT optimization as specified in https://docs.microsoft.com/en-us/visualstudio/debugger/jit-optimization-and-debugging?view=vs-2019.
Since this is not an open source product, If you need more assistance than that to identify what's going on here I would suggest looking into opening a Microsoft support case for this issue so we can work more closely with you on how to narrow this down and get it fixed. I apologize that I can't be more helpful, but right now we don't have enough information to tell what is causing this.

You could try to debug it with dnSpy. See https://aloiskraus.wordpress.com/2019/09/08/how-net-4-8-can-break-your-application/ how to drill deep into .NET Framework with full locals.

So we finally got to the bottom of this case. There was a check in the .net code if the current user (on the current thread) is not serializable throw an exception. I cannot remember the exact details, but it seemed that our custom iprincipal was somehow lost from the thread. We set it at the proper place and everything worked


Source maps are wrong when using sourceMaps="inline"

Describe the bug
We're running our mocha tests using swc-register and we had sourceMaps: "inline" - since I thought that would make sense for running unit tests. I have just realised (and it took me probably 1 year to do so) that source maps aren't working correctly for nearly all files in the project. I then switched sourceMaps setting to sourceMaps: true and the source maps are correct now - ie they point to the right lines in the original source code.
Input code
No response
Config
{
  "env": {
    "targets": {
      "node": "19.0"
    }
  },
  "jsc": {
    "target": "es2019",
    "parser": {
      "syntax": "typescript",
      "tsx": true
    }
  },
  "module": {
    "type": "commonjs"
  },
  "sourceMaps": "inline" | true
}

Playground link
No response
Expected behavior

Source maps generated with sourceMaps: "inline" should be correct, whereas at the moment they point to the wrong lines in an original file.
I also believe that source maps generated with sourceMaps: "inline" and sourceMaps: true should be identical.

Actual behavior
No response
Version
1.3.35
Additional context
No response

Closing as there's no workable thing


pull request for e2e test at 12/24/2016 21:26:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


When I minimized the chrome window, the recording stopped

I use video-plus-screen-recording.html to record video and screen.
When I minimized the chrome window, the recording paused.
When I oepn the chrome window,the recording will be  Continued.

You can try this:
document.addEventListener('visibilitychange', function() {
    if (document.hidden === true) {
        recorder.pauseRecording();
    } else {
        recorder.resumeRecording();
    }
});


SITL broken on master

I have been unable to track it down yet, but somewhere in the following patch, we broke SITL
https://github.com/PX4/Firmware/compare/4345d8...b3554f
@tumbili, @LorenzMeier

I think this looks suspicious: https://github.com/PX4/Firmware/compare/4345d8...b3554f#diff-0da809c04c1d76a5907b7198828781edL825
The low pass filter is being removed.

I think I found it:
		/* Attitude rates for control state */
+		ctrl_state.roll_rate = _lp_roll_rate.apply(_rates(0));
+
+		ctrl_state.pitch_rate = _lp_pitch_rate.apply(_rates(1));
+
+		ctrl_state.roll_rate = _rates(2);  <------------- OOOPS

+1 for getting SITL running for travis.

Looks like that explains why I broke a few props today :)

Ugh, this was clearly a dev process fail we will debrief.
@kd0aij Would you mind re-checking if its fixed now?

If its not, beta holds a super recent but stable state.

beta flies OK. Will test master next.
Master is now OK on the QAV250.


Bug Report - Trojan in conhost.exe compiled from SOURCE

Environment
Windows build number: [run "ver" at a command prompt] Microsoft Windows [Version 10.0.18922.1000]
Windows Terminal version (if applicable): Thursday 6/27 build from SOURCE

Any other software?

Steps to reproduce
Compiled Thursday build from source.
Expected behavior
Working terminal.
Actual behavior
Get a popup about severe trojan from conhost.exe which was compiled from source.

Possible false positive.
On Tue, 2 Jul. 2019, 2:18 am xpwn3rx<EMAIL_ADDRESS>wrote:

Environment
Windows build number: [run "ver" at a command prompt] Microsoft Windows [Version 10.0.18922.1000]
Windows Terminal version (if applicable): Thursday 6/27 build from SOURCE
Any other software?
Steps to reproduce
Compiled Thursday build from source.
Expected behavior
Working terminal.
Actual behavior
Get a popup about severe trojan from conhost.exe which was compiled from
source.
[image: image]
https://user-images.githubusercontent.com/19785522/60451388-c749e880-9be0-11e9-8bd1-2b3417a06774.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/1760?email_source=notifications&email_token=AIZ5IGAMXWQMNKQJEHQNZZDP5IU4PA5CNFSM4H4T6ZH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4VZHKA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIZ5IGBOFI5ZZWVO5C6UQM3P5IU4PANCNFSM4H4T6ZHQ
.

Likely, but it's either a bug or something that really needs to be addressed.

This is literally the code for the console host executable that ships inside Windows. If your antivirus solution is tripping up on it, it is very likely that the bug is in your antivirus solution. If that happens to be Windows Defender, we can at least work with them to figure out why there’s a false positive.

This is literally the code for the console host executable that ships inside Windows. If your antivirus solution is tripping up on it, it is very likely that the bug is in your antivirus solution. If that happens to be Windows Defender, we can at least work with them to figure out why there’s a false positive.

That was from Windows Defender. The Defender trip also caused a follow up ticket from our Crowdstrike AV system.


Provide access to the value key in nix

I know the point of this library is to keep secrets out of the nix store, but would it make sense to provide the option to embed the value directly in nix if you want?
type secret struct {
	Name            string     `json:"name"`
	Key             string     `json:"key"`
	Path            string     `json:"path"`
	Owner           string     `json:"owner"`
	Group           string     `json:"group"`
	SopsFile        string     `json:"sopsFile"`
	Format          FormatType `json:"format"`
	Mode            string     `json:"mode"`
	RestartServices []string   `json:"restartServices"`
	ReloadServices  []string   `json:"reloadServices"`
	value           []byte
	mode            os.FileMode
	owner           int
	group           int
}

it seems that the value is available as a byte array

Why was this closed?


OBO Dashboard (ROBOT tests): Scope

http://obo-dashboard-test.ontodev.com/swo/dashboard.html
"Scope" currently fails as we are missing a section in our description of SWO on the OBO foundry site.
The Scope test can pass by adding text as outlined http://obofoundry.org/principles/checks/fp_005 and therefore should be straightforward to fix.

As stated at https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1015 this part of the test is currently only for the presence or absence of the domain metadata. It was missing in http://www.obofoundry.org/ontology/swo.html and so I have submitted a pull request.

The domain has been updated with "software" in the markdown file, but it has yet to be reflected in either the dashboard or the SWO html page. See the modification here.


Admin PR - new ixia-c version 3002

New ixia-c version
[https://github.com/open-traffic-generator/ixia-c/releases/tag/v0.0.1-3002]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.423%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1050

Relevant Lines:
1491

💛  - Coveralls

/gcbrun


Add my university domain

website: https://engineering.ucsc.edu/departments/computer-science-and-engineering/
https://grad.soe.ucsc.edu/current-students
email address<EMAIL_ADDRESS>

@Dorrie1041 I am sorry, the domain ucsc.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


expecting }, not IDENT, x

Input:
a.each{;x}

Output:
Error: couldn't format STDIN, please report a bug including the contents of it: https://github.com/crystal-lang/crystal/issues

expecting }, not `IDENT, x`, at :1:9 (Exception)
Error opening file 'crystal' with mode 'r': No such file or directory
Error opening file 'crystal' with mode 'r': No such file or directory (Errno)
Failed to raise an exception: END_OF_STACK
[0x5564583d5fb6] ???
[0x556457bd8299] __crystal_raise +153
[0x556457bd9f8c] ???
[0x556457bea277] ???
[0x556457be3906] ???
[0x556457be2c2e] ???
[0x556457bdf9c2] ???
[0x556457bdc866] main +422
[0x7f718293806b] __libc_start_main +235
[0x556457bd529a] _start +42
[0x0] ???

Version:
Crystal 0.24.2 (2018-03-19)

LLVM: 6.0.0
Default target: x86_64-pc-linux-gnu

/cc @MakeNowJust :sweat_smile:

I fixed this on my local workspace. I'll write tests for this tomorrow. Please wait.


Feature: Translation

Summary
This branch implements a small PoC example of how we can include English-Chinese translation via user-input.
It is intended to work as follows:

User selects a language they want website/Shiny app to appear in.
The website/Shiny app will update with the user selected language

Changes
The changes made in this PR are:

Create translation json file
Create dynamically changing modalDialog by rendering UI within it.

Check

[ ] The text across the website/app changes to English or Chinese according to the user-selected language.
[x] The travis.ci and R CMD checks pass.

Note
This "fixes #36" and "fixes #73".
We do not fully implement the translation across the whole app because:

We need further translations.

 Add better translation

Same as #70 , I was trying to look at the app by running the app.R script. When I ran renv::restore() to make sure I have the right packages, the error message Error: install of package 'nlme' failed appeared. I hope I didn't so something stupid!

Same as #70 , I was trying to look at the app by running the app.R script. When I ran renv::restore() to make sure I have the right packages, the error message Error: install of package 'nlme' failed appeared. I hope I didn't so something stupid!

Thanks for trying! I think I fixed it in #70 after updating my R version to 4.0.2 and then being able to reproduce your error. Other errors were thrown up which I think were to do with the R build for Mac in conjunction with the sf package. I think this has now been resolved now so let me know how you get on! :)

Same as #70 , I was trying to look at the app by running the app.R script. When I ran renv::restore() to make sure I have the right packages, the error message Error: install of package 'nlme' failed appeared. I hope I didn't so something stupid!

Thanks for trying! I think I fixed it in #70 after updating my R version to 4.0.2 and then being able to reproduce your error. Other errors were thrown up which I think were to do with the R build for Mac in conjunction with the sf package. I think this has now been resolved now so let me know how you get on! :)

Thanks for looking into this. I just tested and it worked! The Terms & Conditions page definitely respond to the user's chosen language. Am I correct that the rest of the app will show both English and Chinese for now while we have not had all the translations yet?

Thanks for trying! I think I fixed it in #70 after updating my R version to 4.0.2 and then being able to reproduce your error. Other errors were thrown up which I think were to do with the R build for Mac in conjunction with the sf package. I think this has now been resolved now so let me know how you get on! :)

Thanks for looking into this. I just tested and it worked! The Terms & Conditions page definitely respond to the user's chosen language. Am I correct that the rest of the app will show both English and Chinese for now while we have not had all the translations yet?

Indeed!


Crash on /forge generate command use

Describe the Bug:
Using the command "/forge generate ~ ~ ~ 1000" I was trying to generate chunks on a server. It hangs over 600 but not yet at 700 chunks and then crashes.
How Can We Reproduce the Bug:

Put modpack on new server.
Whitelist/OP as appropriate.
Use command: /forge generate ~ ~ ~ 1000
Crash after a minute of hanging.

Expected behavior:
No crashes and chunks to be generated to allow pregenerated exploration.
If Applicable, Add Screenshots or Video to Explain the Bug:
n/a
Crash Report or Game Log
Link to crash report
Please complete the following information:

Have you checked if your bug has already been reported, including closed issues? : Yes
Have you added or removed any mods, and if so, which?: Added Discord Integration mod
Modpack Version Number : <IP_ADDRESS>
Is OptiFine installed? : No
Does this issue affect Server, Client, or Both? : Both

Additional context:
NOTE: I continued doing this and found that repeated attempts got past this point but it proceeded to crash as I increased the value. It got to 1000 so I increased it to 1500 and it then crashed just over 1200.

Thanks, Vallen, for the report.
Currently the pack is heavier on RAM usage than we'd like. Generikb has some mod devs working on some things to lower that.
Here are a few things that I discovered while pre-generating server chunks:

I found that we needed a minimum of 10GB to successfully pre-generate the Overworld.
forge gen is pretty clunky. I dropped https://www.curseforge.com/minecraft/mc-mods/world-pre-generator in and used that instead, as it has a server config file that lets you select SERIAL or SEMI_PARALLEL generation and how many parallel tasks are done at once.  It also allows pausing generation, and doesn't try to regenerate chunks that have already been generated in case of a crash
You should set "max-tick-time" in the "server.properties"-file to -1 to prevent crashes, because the tick time gets too long while generating chunks. This will keep the server watchdog from just crashing the server if there is a hang, but instead let the server catch up to itself.

We'll keep working on trimming down the server resources needed. Keep an eye out for the next update. It has server-related fixes coming.

Those are some great helpful tips and really useful information. Thanks so much for the pack and help Joel!

This is just a note for users that may be having this same issue that World Pre Generator mod mentioned earlier is included in the pack from version <IP_ADDRESS> and newer.

This seems to have been sufficiently resolved. Closing


Update macos-14-Readme.md

Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

@yaseenaljamal


24h timestamps in chat

Could we have the option for 24h timestamps in the chat instead of the 12h clock with AM/PM? Most of the world does not use AM/PM.
https://travel.stackexchange.com/questions/34950/which-large-countries-use-12-hour-time-format-am-pm

This should keybase add to the list to things need to be added next release


does not replace first character

MacOs 10.12
SublimeText 3208
TabNine 1.0.14
http://cloud.invisible.email/ea92893ccd42

Pretty much makes TabNine unusable, which is a damn shame because it's such a great product when it works.

Did this start happening recently?

Yes, in the last day I think.
Restarting Sublime fixed it (for now).

Ok, please let me know if it happens again. I have the same setup myself (with newer version of macOS and older version of Sublime Text) so if we're lucky I'll reproduce it by accident.
Let me know if you find a reliable way of reproducing the issue.

And it's back :T
Nothing weird that I can see. In sublime's console, I just see tab_nine_substitute

I haven't found the cause of your issue, but I added some logic that should help mitigate it. Let me know if it still occurs. (You can make sure you've received the fix by executing Package Control: List Packages and checking that TabNine is v1.0.4.)

Still happening on TabNine v1.0.5
The behavior has gotten a bit more wacky now. Don't know if this is related or a separate problem (but I have a hunch they're related).
See this gif for a quick example:

Hitting tab multiple times gives the first suggestion, followed by the second one (but the first one sticks around)

FYI, here is my installed packages:
[
		"A File Icon",
		"AceJump",
		"AdvancedNewFile",
		"All Autocomplete",
		"ApplySyntax",
		"AutoFileName",
		"Babel",
		"BeautifyRuby",
		"Better CoffeeScript",
		"BetterFindBuffer",
		"BracketHighlighter",
		"Case Conversion",
		"ColorSchemeEditor",
		"Colorsublime",
		"DA UI",
		"DocBlockr",
		"Dockerfile Syntax Highlighting",
		"Dotfiles Syntax Highlighting",
		"Emoji",
		"Expression",
		"FileClose",
		"FindKeyConflicts",
		"Fix Mac Path",
		"Gist",
		"Git blame",
		"Git Conflict Resolver",
		"GitHub Markdown Snippets",
		"GotoLastEditEnhanced",
		"GotoLineEnhanced",
		"GraphQL",
		"HexViewer",
		"HTML-CSS-JS Prettify",
		"Increment Selection",
		"Indent Respectful Sort",
		"Indent XML",
		"JsPrettier",
		"KeybindingHelper",
		"LESS",
		"Markdown Extended",
		"Markdown Table Formatter",
		"MarkdownEditing",
		"MarkdownPreview",
		"Minifier",
		"Missing Palette Commands",
		"Modific",
		"Monokai JSON+",
		"Neon Color Scheme",
		"Package Control",
		"PackageResourceViewer",
		"PEG.js",
		"Pretty JSON",
		"Pug",
		"QuickSearchEnhanced",
		"RainbowBrackets",
		"Sass",
		"Search in Project",
		"SelectExact",
		"ShellScriptImproved",
		"SideBarEnhancements",
		"SnippetMaker",
		"sql-formatter",
		"SRT",
		"StatusMessage",
		"StringUtilities",
		"StripHTML",
		"SublimeLinter",
		"SublimeLinter-eslint",
		"SublimeLinter-shellcheck",
		"SublimeLinter-tslint",
		"Table Cleaner",
		"TabNine",
		"TabsExtra",
		"Text Pastry",
		"Theme - amCoder",
		"TOML",
		"TypeScript",
		"TypeScript Syntax",
		"WordCount"
	],

And here's my preferences
{
	"added_words":
	[
		"playbook",
		"handoff",
		"mcy",
		"rebase",
		"downcase",
		"online",
		"audiobook",
		"ebook"
	],
	"additional_path_items":
	[
		"/Users/keenahn/.nvm/versions/node/default/bin"
	],
	"always_prompt_for_file_reload": false,
	"always_show_minimap_viewport": false,
	"animation_enabled": true,
	"atomic_save": true,
	"auto_close_tags": true,
	"auto_complete": false,
	"auto_complete_commit_on_tab": false,
	"auto_complete_cycle": false,
	"auto_complete_delay": 0,
	"auto_complete_selector": "meta.tag - punctuation.definition.tag.begin, source - comment - string.quoted.double.block - string.quoted.single.block - string.unquoted.heredoc, text.html.erb ",
	"auto_complete_size_limit": 4194304,
	"auto_complete_triggers":
	[
		{
			"characters": "<",
			"selector": "text.html"
		},
		{
			"characters": ".",
			"selector": "source.js"
		},
		{
			"characters": ".",
			"selector": "source.ts"
		}
	],
	"auto_complete_with_fields": false,
	"auto_find_in_selection": false,
	"auto_indent": true,
	"auto_match_enabled": true,
	"binary_file_patterns":
	[
		"*.dds",
		"*.eot",
		"*.gif",
		"*.ico",
		"*.jar",
		"*.jpeg",
		"*.jpg",
		"*.pdf",
		"*.png",
		"*.swf",
		"*.tga",
		"*.ttf",
		"*.zip",
		"/private/var/www/vhosts/invisible/shepherd/.cache/**"
	],
	"bold_folder_labels": true,
	"caret_extra_bottom": 0,
	"caret_extra_top": 0,
	"caret_extra_width": 0,
	"caret_style": "smooth",
	"close_windows_when_empty": false,
	"color_scheme": "Packages/Color Scheme - Wallaby/Neon-KJ.tmTheme",
	"copy_with_empty_selection": false,
	"create_window_at_startup": true,
	"default_encoding": "UTF-8",
	"default_line_ending": "system",
	"detect_indentation": true,
	"dictionary": "Packages/Language - English/en_US.dic",
	"drag_text": true,
	"draw_centered": false,
	"draw_indent_guides": true,
	"draw_minimap_border": false,
	"draw_white_space": "selection",
	"enable_hexadecimal_encoding": true,
	"enable_tab_scrolling": false,
	"enable_telemetry": false,
	"ensure_newline_at_eof_on_save": false,
	"fade_fold_buttons": false,
	"fallback_encoding": "Western (Windows 1252)",
	"file_exclude_patterns":
	[
		"*.pyc",
		"*.pyo",
		"*.exe",
		"*.dll",
		"*.obj",
		"*.o",
		"*.a",
		"*.lib",
		"*.so",
		"*.dylib",
		"*.ncb",
		"*.sdf",
		"*.suo",
		"*.pdb",
		"*.idb",
		".DS_Store",
		"*.class",
		"*.psd",
		"*.db",
		"*.sublime-workspace"
	],
	"find_selected_text": true,
	"fold_buttons": true,
	"folder_exclude_patterns":
	[
		".svn",
		".git",
		".hg",
		"CVS"
	],
	"font_face": "Fira Code Retina",
	"font_options":
	[
		"dlig"
	],
	"font_size": 12,
	"gpu_window_buffer": "auto",
	"gutter": true,
	"highlight_line": true,
	"highlight_modified_tabs": true,
	"hot_exit": true,
	"ignored_packages":
	[
		"Vintage"
	],
	"indent_guide_options":
	[
		"draw_normal",
		"draw_active"
	],
	"indent_subsequent_lines": true,
	"indent_to_bracket": false,
	"index_exclude_patterns":
	[
		"*.log"
	],
	"index_files": true,
	"index_workers": 0,
	"line_numbers": true,
	"line_padding_bottom": 0,
	"line_padding_top": 0,
	"margin": 0,
	"match_brackets": true,
	"match_brackets_angle": false,
	"match_brackets_braces": true,
	"match_brackets_content": true,
	"match_brackets_square": true,
	"match_selection": true,
	"match_tags": true,
	"move_to_limit_on_up_down": false,
	"new_file_syntax": "MarkdownEditing/Markdown",
	"open_files_in_new_window": false,
	"overlay_scroll_bars": "system",
	"preview_on_click": true,
	"remember_open_files": true,
	"rulers":
	[
		80,
		100,
		120
	],
	"save_on_focus_lost": false,
	"scroll_past_end": true,
	"scroll_speed": 1.5,
	"shift_tab_unindent": false,
	"show_definitions": false,
	"show_encoding": true,
	"show_errors_inline": true,
	"show_full_path": true,
	"show_line_endings": false,
	"show_panel_on_build": true,
	"show_tab_close_buttons": false,
	"smart_indent": true,
	"spell_check": false,
	"spelling_selector": "markup.raw, source string.quoted - punctuation - meta.preprocessor.c.include, source comment - source comment.block.preprocessor, -(source, constant, keyword, storage, support, variable, markup.underline.link, meta.tag)",
	"tab_completion": true,
	"tab_size": 2,
	"theme": "amCoder.sublime-theme",
	"theme_font_options":
	{
	},
	"translate_tabs_to_spaces": true,
	"tree_animation_enabled": false,
	"trim_automatic_white_space": true,
	"trim_trailing_white_space_on_save": true,
	"use_simple_full_screen": false,
	"use_tab_stops": true,
	"word_separators": "./\\()\"'-:,.;<>~!@#$%^&*|+=[]{}`~?",
	"word_wrap": true,
	"wrap_width": 0
}

OK I found something. If I set "tab_completion": false, in my preferences, it seems to work. So I suppose it's a weird interaction with Sublime's default auto complete?

OK nm, that didn't fix it. This is a real stumper :t

I agree that it is probably the same underlying issue -- I think the selection is later in the file than TabNine expects. If TabNine is expecting to replace fi with findUser, it would previously delete the 2 characters before the cursor and replace them with findUser. If the selection is later than TabNine expects, this won't delete the fi, and it could lead to your original problem.
In the patch, I made TabNine check whether the text before the cursor is what it was expecting, and if not it falls back to replacing the word before the cursor. This might explain the new behaviour you're seeing -- my guess is that if you open the developer console with Ctrl+`, you'll see something like:
TabNine expected prefix "fi" but found prefix "  ", falling back to replacing ""
Since I can't reproduce the issue, it's probably caused by an interaction with one of your other installed plugins. Your indentation plugins are prime candidates, since they might bind commands to Tab. Can you try going to Sublime Text -> Preferences -> Package Settings -> TabNine -> Key Bindings (User) and adding the following?
[
    { "keys": ["/"], "command": "tab_nine_leader_key", "context": [ { "key": "tab_nine_leader_key_available", "operator": "equal", "operand": true }] },
]

This will let you use / instead of Tab to accept completions. Let me know if the same issue occurs when you accept a completion using /.

Same issue occurs when I switch to using / as the leader key.
Getting reallllly weird behavior now on repeated tabs. It's like it doesn't know where to properly move the cursor. Should I try downgrading Sublime to a previous version?
This only happens after the editor has been open for a while. On restart, it's fine.

Don't know if this helps, but when I'm experiencing the bug, sometimes I'll move the cursor to an empty spot, and I'll see the predictions for the last thing I was typing.

Still happening. Any thoughts?

Can close this now as it seems all good :)


+Show bnf stack trace on error

Include a list of strings within BNF_SyntaxError for the current BNF term that failed, and what terms it was "called" from. This can then be used to print out better syntax errors, allowing you to more easily debug BNFs due to the fact you can ensure that it is attempting to match the fail point with the correct term.

Added within BNF-parser branch.


ProtobufOutputFormatter error with large integers

Summary: ProtobufOutputFormatter modifies the original bytes generated by protobuf.net resulting in decode error with protobufjs.
Server: WebApiContrib.Core.Formatter.Protobuf 2.1.2
Client: Angular 8.1.0, protobufjs 6.8.8
C# Class:
[ProtoContract]
public class ExampleClass
{
	[ProtoMember(1)]
	public int ExampleInt { get; set; }
}

Proto File:
// model.proto
syntax = "proto3";

package model;

message ExampleClass {
    optional int32 exampleInt = 1;
}

Object to Encode:
var returnObj = new ExampleClass
{
	ExampleInt = 123456789,
};

When the above object is encoded by protobuf.net it results with the following bytes:
8, 149, 154, 239, 58
However 'WebApiContrib.Core.Formatter.Protobuf' returns the following bytes:
8, 239, 191, 189, 239, 191, 189, 239, 191, 189, 58
As a result on the client side protobufjs is not able to decode it correctly. It returns the following on the client side:
{exampleInt: -34643985}
Note how the original value was "123456789" but decoded to "-34643985".
What am I missing? I'd appreciate pointing me in the right direction.

Hi @Exocomp This is a bug in version 2.1.2
https://stackoverflow.com/questions/2152978/using-protobuf-net-i-suddenly-got-an-exception-about-an-unknown-wire-type
I will fix this a s soon as possible. As a workaround, revert to version 2.1.1

fixed now in version 2.1.3


TBS init fail, cannot open office file

I don't have X5 kernel installed on my WeChat, and I can't download it by scanning the QR code. How can I open Office files properly?

腾讯开始收费 应该是用不了了
发自我的 iPhone
在 2023年8月28日，15:03，Penglei @.***> 写道：

I don't have X5 kernel installed on my WeChat, and I can't download it by scanning the QR code. How can I open Office files properly?
—
Reply to this email directly, view it on GitHubhttps://github.com/hanlyjiang/AndroidDocumentViewer/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4A7EE5P6Y3I5C2Z5E7EYLXXQ7D7ANCNFSM6AAAAAA4A6UPPE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


use binary encoding for buffers

Fix for https://github.com/mscdex/node-mariasql/issues/50: buffers should be passed through to MariaDB with binary encoding, not in unicode -- the code in master does not allow for transferring binary data like binary-encoded UUIDs, file contents, etc.
I'm sure this will be a discussion so consider a start of the conversation: should node-mariasql attempt to support binary columns?
Testing:

all unit tests still pass.
used on a local development environment of a @navahq system -- all of our mariaDB use cases and tests pass with the new code.

I think for the hex makes no sense to do escape

ah good point

@repsac-by any chance of getting this merged?

@gabesmed Hello, unfortunately I do not have such authority.
@mscdex what do you think about this?

ping to @mscdex -- is anyone maintaining this library who can take a look at this?

Landed in 7000e0cd0543a36e4635f95247e142b3c573f645. Thanks!


reflectDamageThreshold and stealHealthThreshold not set

control does not set/contain: reflectDamageThreshold or stealHealthThreshold variables
Trying to access variables: https://github.com/wchill/steamSummerMinigame/blob/master/autoPlay.user.js#L1020-L1023
The control: https://github.com/wchill/steamSummerMinigame/blob/master/autoPlay.user.js#L53-L66
Makes me believe why I still have all of these:

The problem was that level was never passed in when useMedicsIfRelevant() was called

Will close this as the pull request fixes it.


Show/hide trigger for only touch devices

I have hover cards on images which doesn't work well on touch devices. I tried "iconTouch: true" but it shows bunch of ? marks behind masonry layout like plain text, though it works when click on any ?.
I think a better solution would be to hover on desktop while touch trigger on mobile. How can i achieve this. Would appreciate the help. Thanks

Hi, in one word: v4. It's on the v4 branch, or you can wait a few more days for its official release.

Thanks for the quick response.. Will wait few more days for official release.

You're welcome. You are actually the first person to ask for this, I'm glad to see I was right to implement it. I am curious to know whether you found it straightforward or complex to customize your set of triggers. Was the documentation clear enough? (if you haven't looked it up already, please tell me when you do).

I'm glad to ask this question. I was hesitating a bit and trying to figure it out by myself.. :)
I looked into new v4 documentation and it's looks really clear and straightforward.. Will try this later today.. Will let you know if i have any problem.
Thanks again for this beautiful plugin.


Add check for low disk space

The number of reports of server owners running out of disk space on small VPSs and such while the server is running is disconcertingly high, and a simple feature to check available disk space on launch would have virtually no downside, especially if made configurable through a startup flag.
While this is out-of-scope with the majority of the project, it could save a lot of people from the above situation. I would have PR'd this rather than open an issue, but I am seeking input as to whether or not this feature should be included at all.

Im not against adding this, but im wondering how many of the people that do not regularly check their disk space would actually read the startup log. There is already the problem that quite a lot of people did not read the Java Version warning, and I would expect even less people to read the disk space warning.

Im not against adding this, but im wondering how many of the people that do not regularly check their disk space would actually read the startup log. There is already the problem that quite a lot of people did not read the Java Version warning, and I would expect even less people to read the disk space warning, so it might not be very useful in the end as the target audience does not read log files anyways.

While you have a very valid point, however the warning for Java 11 worked quite well and I'm inclined to believe more people would have read/listened to the Java 16 warning had there not just been one for Java 11.
Another concern is that, this being in Paperclip, the message would likely be thrown very early, before all the configuration files are dumped to the console, covering it very quickly.
I assume that the developers would be against putting it in the server itself, however, if permitted, this could not only be thrown later without something like a 10 second delay before logging, but also read a config from paper.yml to see if the warning is disabled.

The warning for java 11 comes stupidly late in the startup process so that it can be read, delaying this to appear at a useful time is also not something paperclip can do, paper.yml is also irrelevant and not something paperclip can read either
This also wouldn't really cover any useful places FOR this, e.g. many issues occur while the server is actually running, not during startup, this would not appear in log files either; I think that this feature is entirely out of bounds for the goal here and really would be better off dealt with with a script or some cron tasks or something such as a proper monitoring setup so that people can actually monitor what is going on and take steps to protect the server


@UseGuards is not working on BotGateway method

Describe the bug
UseGuards decorator isn't working / guarding when applied to BotGateway class methods.
@discord-nestjs/common === ^3.0.3,
@discord-nestjs/core" === ^3.0.3,
bot.gateway.ts
...

@Injectable()
export class BotGateway {
  private readonly logger = new Logger(BotGateway.name);

  constructor(
    @InjectDiscordClient()
    private readonly client: Client,
    private helpService: HelpService,
  ) {}

  @On('messageCreate')
  @UseGuards(MessageFromUserGuard, HelpCommandGuard)
  async onHelpCommand(message: Message): Promise<void> {
    this.logger.log(`Message from bot: ${message.author.bot}`);
    this.helpService.onHelpCommand(message);
  }
 ...
}

message-from-user.guard.ts
import { DiscordGuard } from '@discord-nestjs/core';
import { Message } from 'discord.js';

export class MessageFromUserGuard implements DiscordGuard {
  canActive(event: 'messageCreate', [message]: [Message]): boolean {
    return !message.author.bot;
  }
}

help-command.guard.ts
import { DiscordGuard } from '@discord-nestjs/core';
import { Message } from 'discord.js';

export class HelpCommandGuard implements DiscordGuard {
  canActive(event: 'messageCreate', [message]: [Message]): boolean {
    return message.content.split(' ')[0] === '!help';
  }
}

To Reproduce
Steps to reproduce the behavior:

When testing,onHelpCommand is executing even though I have a guard defined just like in the examples and I am receiving messages from the bot, creating an infinite loop since !help is in the !help message response from the bot.

Expected behavior
onHelpCommand should only enter the function if Guards pass, in this case if the message comes from a user and the text starts with !help. I like how the Guard Decorator is quite clean so I'd like to use it but for some reason it is not working.

I was unable to reproduce your issue. Most likely you are importing @UseGuards not from @discord-nestjs/core

Fixed in 3.0.4 version


release for arm imagebuilder

https://github.com/Azure/sdk-release-request/issues/474

@RodgeFu The corresponding sdk release request https://github.com/Azure/sdk-release-request/issues/474 was closed due to inactivity. I would expect this PR to be closed at the same time. Any reason we have this left open?

Let's close it as there's no reponse from service team.