awslogs driver did not create logging group

Currently using awslogs driver with non-existing logging group leads to failing to start a container. Added code that first creates logging group.
Amazon's own awslogs agent is able to create logging group if it does not exist.
Signed-off-by: Didzis Gosko<EMAIL_ADDRESS>

ping @samuelkarp can you have a look at this one?

@didzis Thanks for taking a look at this and @thaJeztah thanks for tagging me!
For some background: I originally decided against this behavior due to the service limit of 500 log groups and to protect against exhausting that limit accidentally by making typos.  However, I'd be happy to defer to the Docker maintainers if this behavior is ultimately desirable.

Thanks for looking, @samuelkarp, I'll try to get some maintainers on this to discuss the design; decide if the 500 service limit is expected to be an issue.

I think i'd rather keep the error in this case.
Since logs are generated for every container on the system, and potentially we end up calling CreateGroup every time, it seems redundant and potentially surprising.

Job: Docker-PRs FAILED:

---

---> Making bundle: validate-gofmt (in bundles/1.11.0-dev/validate-gofmt)
Congratulations!  All Go source files are properly formatted.

---> Making bundle: validate-lint (in bundles/1.11.0-dev/validate-lint)
Errors from golint:
daemon/logger/awslogs/cloudwatchlogs.go:212:11: if block ends with a return statement, so drop this else and outdent its block

Please fix the above errors. You can test via "golint" and commit the result.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs] $ /bin/sh -xe /tmp/hudson8094501994455525506.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
aa0163.
+ ec=125
+ set +x

----------------------------------
ERROR: Failed to build test binary
----------------------------------

-----------------------------------------------
ERROR: Failed with exitcode 125 at Wed Feb 10 16:07:30 CUT 2016.
-----------------------------------------------

INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Wed Feb 10 16:07:31 CUT 2016 (1m 13s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson3185948321975667320.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---

Job: Docker-PRs-Win2Lin FAILED:

---
aking bundle: binary (in bundles/1.11.0-dev/binary)
Building: bundles/1.11.0-dev/binary/docker-1.11.0-dev
# github.com/docker/docker/docker
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

---
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson6324824295749176313.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
f08370.
+ ec=125
+ set +x

----------------------------------
ERROR: Failed to build test binary
----------------------------------

-----------------------------------------------
ERROR: Failed with exitcode 125 at Wed Feb 10 16:13:42 CUT 2016.
-----------------------------------------------

INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Wed Feb 10 16:13:43 CUT 2016 (1m 19s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson8622076729448874870.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---

Job: Docker-PRs-experimental FAILED:

---

---> Making bundle: validate-gofmt (in bundles/1.11.0-dev/validate-gofmt)
Congratulations!  All Go source files are properly formatted.

---> Making bundle: validate-lint (in bundles/1.11.0-dev/validate-lint)
Errors from golint:
daemon/logger/awslogs/cloudwatchlogs.go:212:11: if block ends with a return statement, so drop this else and outdent its block

Please fix the above errors. You can test via "golint" and commit the result.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-experimental] $ /bin/sh -xe /tmp/hudson1676984019483790657.sh
+ set +x

---

Thanks for contributing @didzis, I discussed this with some maintainers, and we prefer to keep this option explicit instead of automatically creating the groups.
I'm closing this PR, but feel free to comment if you disagree :heart:

@thaJeztah One of my latest commits introduces an extra option awslogs-create-group, which must be explicitly set to true for a log group to be created and even then only after create stream has filed because of missing log group - there will be no extra overhead during normal container start when the log group is in place.
Please consider, that without the ability to create a log group, the behavior of awslogs log driver is inconsistent with Amazon's awslogs agent.


TimestampField on createTimestamp or modifyTimestamp raises Exception: a float is required

First Time I used it, I tryed to substitute the Custom Field I showed you here:
https://github.com/django-ldapdb/django-ldapdb/pull/150#issuecomment-403251906
with TimestampField, I got this:

Can I help with more informations?

My fault, just a wrong typing, I used timestamps on a datetime.
Filters works great, thank you


Broken select behavior when using with "Shatur/neovim-session-manager"

Info

Operating System: Ubuntu 24.10
Shell: bash
Terminal: kitty
nvim --version: nightly
fzf --version: 0.42.0
[ ] The issue is reproducible with mini.sh

fzf-lua configuration

require('fzf-lua').setup()

Description
When opening SessionManager load_session command and exiting select ui without choosing any option with Esc wil result in subsequent SessionManager load_session commands to not trigger ui select.
https://github.com/ibhagwan/fzf-lua/assets/130047938/2e64b907-a763-43b7-936b-fb099967a27f

Does the same happen with the default vim.ui.select? I.e. never running :FzfLua register_ui_select?
If you do not select a session, then run :FzfLua deregister_ui_select and try to load another session (using the default UI), will it load correctly?

Does the same happen with the default vim.ui.select? I.e. never running :FzfLua register_ui_select?
It seems to only happen when FzfLua isn't registered to ui select
If you do not select a session, then run :FzfLua deregister_ui_select and try to load another session (using the default UI), will it open the UI again if you run load_session?
After I run :FzfLua register_ui_select the UI is working normally again.

Turn out I got another plugin "stevearc/dressing.nvim" which register select ui automatically without calling :FzfLua register_ui_select which probably was the cause.

It seems I really misconfigured dressing. Sorry for the trouble

Ty for the update @lmquansgt

@lmquansgt, FYI,  https://github.com/ibhagwan/fzf-lua/commit/5474df3a722b0efbeb9f47d0b2fdbce7d2ff258e and the latest dressing.nvim changes makes the plugins play better, I have a feeling might help your orignal issue as well.

@ibhagwan Thank for the heads up. I tried it out again and now it work perfectly without the need to call register_ui_select explicitly. :+1:


Moving into shape with "activate via map note" toggled causes change of visibility of journals in scene

When a drawing with multilevel and the setting "Activate via Map Note" enabled is stepped into by a player, it causes them to be able to see any journals in the scene which they have permissions for. Any permission besides "none" on the journal works to reproduce this bug.
Video of issue: https://imgur.com/a/he3mOZD
I verified that the bug is present when Multilevel is the only active module
Current Foundry info:

Multilevel version: 1.5.4

OK, it's only supposed to auto-show journals with permission inside the drawing (so they can easily click on it). I'll see if I can figure out why that's not behaving as expected.


Set max loop times when consume StateEvent to avoid dead loop influence the thread.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13007 (1e99971) into dev (7336afa) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #13007      +/-   ##
============================================
- Coverage     39.39%   39.35%   -0.04%
+ Complexity     4272     4269       -3
============================================
  Files          1067     1067
  Lines         40118    40088      -30
  Branches       4603     4586      -17
============================================
- Hits          15805    15778      -27
+ Misses        22534    22533       -1
+ Partials       1779     1777       -2

Impacted Files
Coverage Δ

.../server/master/runner/WorkflowExecuteRunnable.java
8.16% <0.00%> (-0.01%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-6.46%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

... and 18 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BUG]: Admin | Sync Template v2 (Model Driven Apps)

Describe the bug
I have 2 new Project Oakdale environments where Im getting the same error in the flow.
Component (please tell us which flow or app you are experiencing issues with):

Solution Core
Version 1.60
Flow Sync Template v2 (Model Driven Apps)

Expected behavior
This flow is generating an error when running against either Project Oakdale environment.  In both cases I'm seeing an error with the Linked Metadata Unique Name
Screenshots

Additional context
Add any other context about the problem here.

Hi there. Thanks for using CoE!
Per #492 , the product does not currently allow access to teams environments wrt MDAs, PVAs and RPAs.
Future versions of the toolkit will have this explicitly blocked.
To update your own while you await the release, add the following after the trigger in the RPA/PVA/MDA sync flows:
Where the left side of the conditional is @triggerOutputs()?['body/admin_environmentsku']

Jenefer...
If I select Environment Sku from the list of dynamic content I see triggerBody()?['admin_environmentsku'].  I'm still relatively new to Flow so I'm not finding how you set the conditional above.

I believe you are saying that you believe you selected the correct thing on the left side of the condition, which can be validated by hovering over it as shown

Then you just write the string Teams in the right side of the condition. No quotes or anything around it. Just as shown here.
That should work.
Happy you are exploring Power Automate. Its a super powerful and efficient tool once you're good at it :)
These sync flows utilize so many features, its a great place to explore and learn.
Please let me know if this works for you.

OK...so I ran a test against a prior failed run that queried the environment with type Microsoft Team but the condition is coming up false.  Here's the raw data and the EnvironmentSku is not Teams.

It looks like this is due to you using an old API version for the "Get Environment as Admin" call. I hadnt noticed you were still on 1.6 which doesn't have that updated.
You'll need to either update this in yours or upgrade to 1.7_2
You can see this API version below:

Thanks for pointing this out.    Apologies as it is not obvious to me how to update the API version.   Maybe the difference is because the Power Platform for Admins connector is still in preview?

No need to apologize. It is absolutely not obvious!
This field is populated in the flow that update the environments themselves: Admin | Sync Template v2
Go to that flow, and edit it.
Expand this scope: Get Environments and store them in the CoE CDS Entity
And edit the API Version here to be as follows: 2020-06-01

That said, it might be easiest to just upgrade to the newest Core, as I'm not sure there wont be other issues from a mismatch if you just update here: aka.ms/CoEStarterKitDownload

Just updated core to 1.70.2

And while it looks like all the templates were modified

When I go to Admin | Sync Template v2, I see that it still has the old API version.

Our local setup test from the download correctly shows the new API, so lets make sure your upgrade worked.
Can you go to the Model Driven Apps flow and validate that you see this scope there. its new this release

Here's what I see...

yep, thats what I thought. your solution did not get overwritten, can you please try again like this:

I now see the updated flow...

But I still see the old API

I just checked the Admin | Sync Template v2 and 'Get Environments' does have the updated API

Good. You can now add that check at the top of the flow and you should be able to catch these cases.
Pasting here again for your convenience:

Just to close the loop on this.  Running core 1.70.2 and adding the check for 'Teams' EnvironmentSku worked and gracefully failed the flow during last night's run.   Thanks again for the help!

Great news, thanks for letting me know.
I'll leave this open until we release the fix generally.
Thanks for using CoE!

This fix is now released. Thanks for providing feedback to help make CoE great!


Play_scraper.details histogram returning none

Hi if I run
play_scraper.details('com.android.chrome')
then the histogram part of the output has None for every value in the dictionary instead of having the number of star ratings.

Several other fields are empty as well, e.g. current_version, developer fields and updated.

@svennickel please provide example app


chore: restrict fluent extensions to assignable targets

Hopefully it isn't too intensive on the checker, closes https://github.com/ts-plus/typescript/issues/63

Even though the extensions no longer show up in the completions list, they still are able to be called

Even though the extensions no longer show up in the completions list, they still are able to be called

It is expected behaviour, I was thinking about it and thought that in the case of an already existing file you may change something and get a type error, but if I filter out the function if there is a type error it will say "sum not existing in Array" instead of showing what's wrong, I guess it's arguable if one is better than the other though

@0x706b fixed, when imposing the check I also notice that generics were not handled properly against base signatures I've switched to inference and instantiation to check generics


Portfolio desktop version

[ ] Added media query to make the desktop version look good.
[ ] Downloaded desktop images and added them to the desktop version of the project.
[ ] Customised the author's section in the readme file.
[ ] Removed the Note section in the readme as is not part of the readme file.
[ ] Done with the optional changes suggested by the previous reviewer.
[ ] Done with the changes to make the project look similar to the Figma template.

This desktop version is now good-looking.


Fix make help command in the source code from the latest release

There is no docker.mk file in the source code from the latest release.
Add check if  docker.mk file exists.

You probably mean there's no docker.mk in the docker4drupal.tar.gz archive from the releases page, that's because we rename it to Makefile. In the source code it named docker.mk because we already have Makefile that's specifically for this project and not needed when you actually use docker4drupal for yourself.

Yes, I meant there's no docker.mk in the docker4drupal.tar.gz.
There are two ways to fix make help:
to add check if docker.mk file exists,
or to add sed 's/docker\.mk/Makefile/g' docker.mk > Makefile in build instructions.

Oh, right, that's very useful.


Assertion Failed: Attempting to inject an unknown injection: 'service:media'

I keep getting this error no matter what I do. I even copied the examples and same thing. I tried having a completely empty table, as well as one only with columns and empty rows. I still get the error. What is this service media - i see it is referenced in one of the mixins - and how do i get it and why do i need to have it if it isn't in the examples?

@gudyo There's likely an error with your installation.
see https://github.com/offirgolan/ember-light-table/issues/367 and let us know if that fixes it

install ember-responsive
light-table uses the media service from ember-responsive since 1.5.0, but the dependency was added only in devDependencies instead of dependencies.

the dependency was added only in devDependencies instead of dependencies.

That should not matter, since properly installing ember-light-table via
ember install ember-light-table

will also call this hook:
https://github.com/offirgolan/ember-light-table/blob/5dccab6a47644eef0381b30004802aa88958f176/blueprints/ember-light-table/index.js#L7-L9
This error can also arise, if you try to use ember-light-table inside an engine and forget to expose the media service to the engine.

The problem can arise quite often if you work on multiple projects and just copy the dependencies from one project to the other and run npm install, or if you just update de dependency directly in the package json for exemple. Yes it works if you ember install the addon everytime, but it's far from foolproof. Foolproof would be to add the project in the dependencies.
Sent from Ninehttp://www.9folders.com/

From: Jan Buschtöns<EMAIL_ADDRESS>Sent: Sunday, May 6, 2018 07:06
To: offirgolan/ember-light-table
Cc: Bobby Mousseau; Comment
Subject: Re: [offirgolan/ember-light-table] Assertion Failed: Attempting to inject an unknown injection: 'service:media' (#476)
Closed #476https://github.com/offirgolan/ember-light-table/issues/476.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/offirgolan/ember-light-table/issues/476#event-1611639205, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGopeY9vbobo_Gfsf4R0k9KHeHJpbWnVks5tvtk4gaJpZM4O3XJK.

That's a valid objection. I can't recall exactly, but I think there's another gotcha with adding it as a dependency.
What do you think about checking that the the addon is installed and throwing an error, if not?

I understand the bad ergonomics that we currently have to deal with, but we need to make sure ember responsive is installed on the top level project -- adding it do our dependencies won't satisfy this.
Currently we do so by staying in our docs that you have to ember install ELT.
If we could enforce this via code and fail the build if there is no ember-responsive at the top level, that would be an improvement that would be quite useful in debugging this frustrating experience.

I'm positive that there are some hooks and helper methods we can use during the initial application boot to verify, that the required dependency is installed.


Get metadata working for stories

It's pretty critical that we have proper titles and descriptions for individual stories. For social sharing.

I'll probably try to take a stab at this. We might want to add as part of the moderation process, the ability to set a meta description field on each story


belongsTo relation with related ObjectId is not working

Laravel-mongodb Version: v3.6.5
PHP Version: 7.4
Database Driver & Version: 4.2.3

Description:
I have this data on the database:
Collection: articles
{
    "_id": ObjectId("5f8a06c2276f0000c1005c52"),
    --- anoher data
    "userId": ObjectId("5ecd2b3fed5d0000dd000dd2")
}

Collection: users
{
    "_id": ObjectId("5ecd2b3fed5d0000dd000dd2"),
    --- anoher data
    "name": "Bob"
}

Then I defined my models as:
class Article extends Model
{
    public function user() {
        return $this->belongsTo(User::class, "userId");
    }
}

If I do:
$article = Articles::find("5f8a06c2276f0000c1005c52");
$article->load("user");

It display a warning

Illegal offset type in isset or empty in \vendor\illuminate\database\Eloquent\Relations\BelongsTo.php on line 188

Also the user property is set to null (no user was loaded)
But if I change the userId to be a string instead of an ObjectId:
{
    "_id": ObjectId("5f8a06c2276f0000c1005c52"),
    --- anoher data
    "userId": "5ecd2b3fed5d0000dd000dd2"
}

The above code works fine.
How can I make the relation to work with ObjectId?

Hello,
Currently it's doesn't work with Object IDs, you need to change your data to string.
Changing relations to work with object IDs by default is a breaking change, see this https://github.com/jenssegers/laravel-mongodb/issues/1974#issuecomment-592857370
Thanks!

@divine Does it support relation with object id now?


Please invite me to the community

Name
Mehul Bhargava
Additional Context
Hi,
I am Mehul Bhargava, a data science professional.
I would like to be a part of this awesome community.
Thank you!

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for the development solutions and enhance creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn development, DevOps, tech, and contribute together and with us 👉💜👈


Delete a thing: Deleting indicators, results, sites, documents -- bounces you out of context to a full page confirmation dialogue

Need to vet this ticket to make sure that warnings are adequate. For example, deleting an indicator or a site has serious implications -- need to outline the consequences in more detail?
Affects:

Indicator setup form: Delete indicator button
Results data record: Delete record button

Issue
When I click DELETE to remove an indicator or data record, I’m bounced to a full page confirmation dialogue, then sent back to the Indicators page with all program rows closed. I lose context and have to navigate my way back to wherever I was.
Deleting indicator: Acceptance criteria

[ ] 1. When I click the Delete this indicator button, I get a standard confirmation pop-up dialogue, just like the one we use for removing all targets on the Targets tab:

[ ] 1.1. The confirmation dialogue says, "Warning: This action cannot be undone. Are you sure you want to delete this indicator?
[ ] 1.2. There is a Cancel button and an OK button.
[ ] 2. If I click Cancel, the confirmation dialogue closes and nothing happens.
[ ] 3. If I click OK, the same dialogue reloads with the message, "Indicator successfully deleted." with an Okay button. (No Cancel button at this point, since there's nothing to cancel.)
[ ] 4. When I click "Okay", the following happens, depending on where I came from.
[ ] 4.1. If I came from the New Indicators page, I'm returned to that page with an empty form.
[ ] 4.2. If I came from the Indicators page, it is just as I left it, in the following ways:
[ ] 4.2.1. I'm returned to the Program row I was on (from which I just deleted the indicator). The program row is open to reveal any remaining indicators.
[ ] 4.2.2. Any Program or Type filtering I had previously done is preserved.

Deleting results: Acceptance criteria

[ ] 1. When I click the Delete results button, I get a standard confirmation pop-up dialogue, just like the one we use for removing all targets on the Targets tab.
[ ] 1.1. The confirmation dialogue says, "Warning: This action cannot be undone. Are you sure you want to delete these results?
[ ] 1.2. There is a Cancel button and an OK button.
[ ] 2. If I click Cancel, the confirmation dialogue closes and nothing happens.
[ ] 3. If I click OK, the same dialogue reloads with the message, "Results successfully deleted." with an Okay button. (No Cancel button at this point, since there's nothing to cancel.)
[ ] 4. When I click "Okay", I am returned to the Indicators page, and it is just as I left it, in the following ways:
[ ] 4.2.1. I'm returned to the Program row I was on (from which I just deleted the indicator). The program row is open to reveal any remaining indicators.
[ ] 4.2.2. Any Program or Type filtering I had previously done is preserved.

Deleting document: Acceptance criteria

[ ] 1. When I click the Delete button, I get a standard confirmation pop-up dialogue, just like the one we use for removing all targets on the Targets tab.
[ ] 1.1. The confirmation dialogue says, "Warning: This action cannot be undone. Are you sure you want to delete this document?"
[ ] 1.2. There is a Cancel button and an OK button.
[ ] 2. If I click Cancel, the confirmation dialogue closes and nothing happens.
[ ] 3. If I click OK, the same dialogue reloads with the message, "Document successfully deleted." with an Okay button. (No Cancel button at this point, since there's nothing to cancel.)
[ ] 4. When I click "Okay", I am returned to the Document list page, with any previously applied filters preserved.

Deleting site: Acceptance criteria

[ ] 1. When I click the Delete button, I get a standard confirmation pop-up dialogue, just like the one we use for removing all targets on the Targets tab.
[ ] 1.1. The confirmation dialogue says, "Warning: This action cannot be undone. Are you sure you want to delete this site?"
[ ] 1.2. There is a Cancel button and an OK button.
[ ] 2. If I click Cancel, the confirmation dialogue closes and nothing happens.
[ ] 3. If I click OK, the same dialogue reloads with the message, "Site successfully deleted." with an Okay button. (No Cancel button at this point, since there's nothing to cancel.)
[ ] 4. When I click "Okay", I am returned to the Sites list page, with any previously applied filters preserved.

Housekeeping

[ ] Unit test/s written wherever applicable
[ ] i18n tags included wherever applicable
[ ] Functionality is accessible to people using screen readers

Fixed in Papaya.


Community Edition Website Updates

Designs will be available here: https://github.com/tallycash/tally.cash/issues/25

Done.


Generate custom project.json file

https://help.form.io/intro/appdev/#creating-your-own-application-template
https://github.com/formio/formio.js/wiki/Form-JSON-Schema

Needs:
Defaults for:

Form Permissions
Form Actions
Role permissions


refs #6 ( https://github.com/JanSchulz/knitpy/issues/6 ) - fixes string ...

...index out of range error for render('./foo.pymd', output='all')

As explained in #6, the fix is unfortunately different than the one proposed here. As the fix is landed in #10, close this PR


Upgrade node-sass to v2

I ran into some issues with advanced SASS features, which could be fixed by upgrading node-sass to v2.0.0-beta. v2 also has some nice features like a list of included files which can directly be used to mark dependencies, and more accurate errors.
A couple of things I'm not really sure about:

Dependencies also have been marked when an error occurred. I removed this, since I don't think it's needed (and node-sass doesn't include a file list on error) but I couldn't really find any documentation for it.
I noticed the tests don't really seem to test the loader but just node-sass.

I've bumped the version to 0.4.0-beta.1, to indicate that we're still relying on the node-sass beta.

First of all, thank you for your pull-request. I'm glad you noticed the new includedFiles-feature, I've implemented it in node-sass :grinning:
We've discussed about marking dependencies. The problem is, that libsass is ignoring the whole module when there's a syntax error. Thus webpack's file watcher will not fire, even after you've fixed the error. This has probably been fixed with a new version of libsass (I recall a discussion about this at libsass). But before we're removing sass-graph we need to assert that all dependencies are marked (even those with a syntax error).
However, I'm willing to publish a beta of the sass-loader which will use the new node-sass version. There will also be custom importers which will integrate nicely with webpack's custom resolving engine.

We can remove sass-graph if libsass with this feature is supported by node-sass
https://github.com/sass/libsass/issues/638.
I will test it see.

Thanks @jhnns for the explanation. If I understand correctly it's possible to do this with libsass 3.1 but the list of files is not included on errors by node-sass yet?
I could revert the removal of sass-graph for the time being, so it would work as expected until node-sass supports this.

That would be great :+1:

Done :grinning:

Very excited for this!

I'm getting an error on node 0.11.14
module.js:355
  Module._extensions[extension](this, filename);
                               ^
Error: Module did not self-register.
    at Error (native)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/jhnns/dev/jtangelder/sass-loader/node_modules/node-sass/lib/index.js:211:15)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

This is probably related to a recent fix at node-sass. I don't think that we can publish the current state because it would break all projects using node 0.11.x.

We should probably also bump our major version, because according to node-sass it is a breaking change.

node-sass 2.0.0 has been released... sass/node-sass#157

Is this going to be released?
Would be cool to not track master to use io.js

Has been published as 0.4.0

:+1: thanks a lot!


Container is able to perform all file system operations, except removing directories

Problem description
I am using a container to build a cordova application, which runs on Ubuntu 18.04.
I run the container in interactive mode and run .sh scripts that I wrote, and I use a volume to add my files to the container.
if I run the following commands
mkdir www
cd www
touch test.js
mkdir assets
cd assets
touch img.png

It all works well, everything is created on the host.
Then I run
rm -rf www/*
rm -rf www

And from there, the files are deleted, but the directories are not.
Worse, when I try to remove them from the host, they can't be deleted, Windows require privileges (and giving them doesn't work) and Ubuntu WSL says "directory not empty" (although it is and I run the command with -rf). I have to restart my computer so that I can safely delete this folder (from the host, the container still doesn't want to)
I have chmoded 777 all of my project files to be sure, but the error still persists.
Other
I am running on a brand new operating system (factory reset two weeks ago) and Docker was the first thing I installed.
I am running on Windows 1903 (OS Build 18362.778), I have installed the WSL Ubuntu "focal" 20.04 and used apt install docker.io (19.03.8) to install docker. I have added the docker user group and myself in it,
I also did everything necessary to be able to run docker from the WSL (TLS and such) and it works great, it's just that rm that is messed up.
I don't really know what other information to provide, so feel free to ask for it !

Thanks for sharing the issue. If you're looking for support, you can try the Docker Community Forums. If you believe this is a bug, please create an issue the the application repo. If there is an issue in the documentation, please let us know.


The emojis appear cutted

My phone is a Samsung Galaxy S9. Maybe it's something related to the screen density?

Thanks for the package! 🙇

I can replicate the issue when I set Settings -> Display -> Display Size to large
I'm not sure if I can detect this setting and adjust the sizes. 🤔  If you set the display size to normal it should be displayed correctly again.

Oh! I just tried it and you're totally right. The issue is related to the font size. The bad news is that I'm using the regular option on my Samsung S9.
So it smells that you're wrapping the Text widgets that show the emojis with a SizedBox with a static size. If that's the case, there are two options:

Don't wrap the Text widgets with anything that forces them to have a specific size, so the Text widget can have the size it wants
Somehow, tell the Text widget not to depend on the font-size value of the device. In native Android, it would be defining the size in dp instead of sp.

If you want to go on with the second option, I think the solution is to set textScaleFactor: 1 to the Text widget. Honestly, I didn't know it existed until now that I searched how to fix it. This is what I found in the Flutter documentation.
If I had to choose, I would ask you to go for the second option: always keeping the emojis the same size. Why? Well, I've tried it, and when you change the font size, the keyboard size doesn't change. So, as you are making a keyboard, you shouldn't either resize the emojis.
Thanks for checking the issue, by the way! 👍

@rocboronat Oh wow, good finding ! Thanks for the research 🙇  textScaleFactor: 1 seems to fix the issue perfectly! I gonna release a new version soon, will take a look on the other issues as well before.

Oh, that's great news! Glad it worked 😄 And thanks for the update and your time! 😊

Fix released with version 1.0.5

Hello! I'm sorry... I bring bad news. With the 1.0.5 version, the issue has improved a lot, but the emojis still appear a bit cut. Here's a screenshot to showcase the issue, and in addition, show the "box" where the emojis are printed.

It's like you are applying a too aggressive padding? Maybe you could just center it with a Center widget and that's it.
Thanks for the fast fix, by the way!

@rocboronat Sorry just saw the comment. Gonna try to replicate 🤔

I can confirm it 😔 Will look into it the next days. Thanks for pointing out !

Zero worries! :·)

@rocboronat I think I found a fix, could you quickly confirm by replacing the dependency in your pubspec with that?
  emoji_picker_flutter:
    git:
      url: https://github.com/Fintasys/emoji_picker_flutter.git
      ref: master

@rocboronat I have release 1.0.6 ! Thanks again for reporting 🙇

Thank you so much for fixing the issue! ❤


Edit to the Phone numbers entry: bugfix and doc'ing it.

Hey @joolswood
While I was doing html bughunting I found that the phone #s shouldn’t be spaced in the href field.
I removed them, but also figured I might document it? Up to you? :)

Ah, well spotted @klepas I can add some text on the page in this PR.

@klepas closing this as have to fix conflicting changes in https://github.com/AusDTO/gov-au-content-guide/pull/78


Release <IP_ADDRESS>

Time for a new release. Changelog:
<IP_ADDRESS>
    This release supports GHC 7.8, 7.10, 8.0, 8.2 and 8.4.

    Breaking changes:

        Remove 'Math.NumberTheory.Powers.Integer', deprecated in <IP_ADDRESS>.

        Deprecate 'Math.NumberTheory.Primes.Heap'.
        Use 'Math.NumberTheory.Primes.Sieve' instead.

        Deprecate 'FactorSieve', 'TotientSieve', 'CarmichaelSieve' and
        accompanying functions. Use new general approach for bulk evaluation
        of arithmetic functions instead (#78).

        Now 'moebius' returns not a number, but a value of 'Moebius' type (#90).

    New functions:

        A general framework for bulk evaluation of arithmetic functions (#77):

        > runFunctionOverBlock carmichaelA 1 10
        [1,1,2,2,4,2,6,2,6,4]

        Implement a sublinear algorithm for Mertens function (#90):

        > map (mertens . (10 ^)) [0..9]
        [1,-1,1,2,-23,-48,212,1037,1928,-222]

        Implement an efficient modular exponentiation (#86).

        Add basic support for cyclic groups and primitive roots (#86).

        Write routines for lazy generation of smooth numbers (#91).

        > smoothOverInRange (fromJust (fromList [3,5,7])) 1000 2000
        [1029,1125,1215,1225,1323,1575,1701,1715,1875]

    Improvements:

        Now factorisation of large integers and Gaussian integers produces
        factors as lazy as possible (#72, #76).

Yay!
On Wed, Mar 14, 2018 at 3:17 PM Bodigrim<EMAIL_ADDRESS>wrote:

Merged #96 https://github.com/cartazio/arithmoi/pull/96.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cartazio/arithmoi/pull/96#event-1521764848, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAQwoQ_tPkadwDWuDlstMYIZ2zkd3w3ks5teWzPgaJpZM4SnRZN
.


[Bug]: Dynamic table cell select options dont appear in new row select

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When i dynamically add select options (from api response) in table cell they do not appear in new row select cell.
Works only with statically added options.
Steps To Reproduce

Create table.
Change cell type to 'select'.
Set options to something like JSDropdownObject.getSelectOptions() (returns valid format options list)
Click on '+ Add new row'.
There are no select options in dropdown.

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Self Hosted 1.9.12

I have been facing the same issue

Select in table, new row.json.zip
I have made a minimal example and exported it, it uses the mock databases users and recreates the description above.
Please  let me know if i can assist further.
/Esben

Just checking in - has this been triaged yet?

Folks this is working for me @darkqq @shantanu1singh @esbenab
The only scenario where it doesn't work is when the table data is empty. In that case, please turn off same options in new row and you can add the query again.
Here's a video describing this - https://www.loom.com/share/d99bc59e98984823acb151fdb8e2b24c
I will update the bug to reflect the right information

Thank you!
The workaround works! i was on a 4 month old version which lacked the options in the video got it all updated and everything is good now.
Thank you for your awesome work!

This works


fnotifystat: 0.02.00 -> 0.02.01

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/fnotifystat/versions.
These checks were done:

built on NixOS
/nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/bin/fnotifystat passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.02.01 with grep in /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01
directory tree listing: https://gist.github.com/403bc6fa2fa6447782c088789925dbfa
du listing: https://gist.github.com/a24a28895d12487f43e6b23117868c75

meta.description for fnotifystat is: '"File activity monitoring tool"'.
cc @womfoo for testing.
Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout cb1fcff6a0c05842e2a99babbf392e6a6f76e5b3 && nix-shell --pure -I nixpkgs=. -p fnotifystat

Success on aarch64-linux (full log)
Attempted: fnotifystat
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01
shrinking /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01/sbin/fnotifystat
gzipping man pages under /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01/sbin
patching script interpreter paths in /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01
checking for references to /build in /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01...
moving /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01/sbin/* to /nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01/bin
/nix/store/0wss8yg3srjybmgk5wajdmkh3ci30i3z-fnotifystat-0.02.01

Success on x86_64-linux (full log)
Attempted: fnotifystat
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01
shrinking /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/sbin/fnotifystat
gzipping man pages under /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/sbin
patching script interpreter paths in /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01
checking for references to /build in /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01...
moving /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/sbin/* to /nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01/bin
/nix/store/bhgmqgb2378111cih2i66xxw8hs437cg-fnotifystat-0.02.01

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: fnotifystat
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Can't log with tags from Erlang shell (without parse_transform)

15:27 < ponton> I wanna log something like: lager:warning([{my_tag, foo}], "Some message")
15:27 < ponton> but from Erlang shell, so parse_transform is not used
15:37 < Vagabond> ponton: lager has a direct API, but its less convienient
15:37 < Vagabond> lager:log(level, self(), "Message ~p", FormatArgs).
15:58 < ponton> Vagabond: but how to pass tags to it?
16:00 < Vagabond> hmm
16:00 < Vagabond> you probably can't
16:01 < Vagabond> you should open a GH issue, and I can try to fix that
16:02 < Vagabond> actually
16:02 < Vagabond> you can do it, but its ugly
16:03 < Vagabond> you can use lager:dispatch_log directly, although its not really supposed to be a public API

I can fix this, but we need #36 merged first.


Implemented ModelSummary total params values

Signed-off-by: George Corrêa de Araújo<EMAIL_ADDRESS>What does this PR do?
Added printing of total num of params, trainable and non-trainable params in ModelSummary.
Fixes #1833
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Had fun 🙃

This is a very nice improvement, however, I feel like ModelSummary could be an external dependency.
Maybe we could rely on a library to avoid all this work. This one comes to mind: https://github.com/TylerYep/torch-summary
What does core think? Do you prefer to keep it in-house?
cc @TylerYep would you be interested?

I took a look at this before, it seems quite doable! I will be sure to take a look in my spare time. Feel free to try porting it over yourself if you want too; the code is not very complicated.

Hello @george-gca! Thanks for updating this PR.

In the file pytorch_lightning/core/memory.py:

Line 279:121: E501 line too long (122 > 120 characters)

If one would add torchsummary as external dependency, where would the torch-summary requirement fit? In the main requirements.txt? Also how would the tests be done? By parsing the string output of torchsummary?

If one would add torchsummary as external dependency, where would the torch-summary requirement fit? In the main requirements.txt?

Yes, in the main one assuming we don't make it an extra dependency.

Also how would the tests be done? By parsing the string output of torchsummary?

Only the integration with the package would have to be tested. The package itself should have a realiable test suite to check the expected string output

Perhaps to move this to its own issue, since this PR is just adding to the existing code and the integration is unrelated. @carmocca , would you like to make this to a new issue?

Yes, creating its own issue is a great idea :+1:. Gives it more visibility. Maybe it is better you create it, considering you are the repository owner

can you tag me on that issue as well?

LTGM ! Mind making a small test ?

it is already there as a doctest :]

@george-gca  i love this!


Inconsistent behavior of $q notify

I have opened an issue in the original Q repo too. Angular implementation also has the same problem.
kriskowal/q/issues/445

with https://github.com/kriskowal/q/issues/445#issuecomment-35825749, it looks like if we want to stay with notify, then we will have to live with this issue. If at a later point in time we want to follow Q use of estimates, then we should use another issue. At the moment, I think it is ok to close this issue


Youtube stream the meeting

I was not able to stream on youtube the meeting.
I also noticed there is not panelist/spectator settings enabled

fixed


Fix unit tests

Summary
Fixed failing unit tests that were failing because of accessing fields of non-existing outcome.
Details and comments
This fixes 59 out of 61 failing tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.102%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2943

Relevant Lines:
5874

💛  - Coveralls

Another question is why are the failing tests disabled in CI? and how do we enable them again?

Another question is why are the failing tests disabled in CI? and how do we enable them again?

Which tests are disabled in the CI? After the backend.run() transition to use the runtime api we skipped a lot of tests which probably should be refactored/enabled it just hasn't been prioritized yet


docs: Fix broken link in endpoints.mdx

Expected to go to the spec, or another page (not the same page, which make the link appear broken). Used the same link to the spec also given at the top of the page.

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[x] No debug or dead code
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[x] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

Thank you for this PR, i added a change size it should link internal to the top section.
The links was IMO broken because of casing issues.


set log level during creation of fonrman so it will be set for sure

Pass the initial log level to frontman.New() to be sure we have one set.
Can be overwritten later by config file or flags.
Closes #22

As we talked in Slack, this approach will not help.
We shouldn't set the default for the flag so we can check if a user really set it or not
We need to have a precedence from lowest to high (default -> config -> flag)
I fixed this in #28, let me know if you are agree

BTW, according to last changes proposed by @troian I think we may want to add log_level to the MinValuableConfig. What do you think?

We shouldn't set the default for the flag so we can check if a user really set it or not

Agree with that


Multiple messages sending on same line

When calling the .log() method in rapid succession, it appears that multiple messages can end up on the same line which then confuses Sumo into thinking they're part of the same message.
I believe this line in sumoLogger.js (55):
body: currentLogs.concat('\n')
Needs to be:
body: currentLogs.join('\n')
Note the difference between concat and join:
Concat:

The concat() method is used to merge two or more arrays. This method does not change the existing arrays, but instead returns a new array.

Join:

The join() method joins all elements of an array (or an array-like object) into a string and returns this string.

Since we're trying to append a new line char to each item in the array (and not at the end of the entire array) I think it should use join.
Does this sound right, or is there a reason it's currently using concat?
Thanks!

Please see the update I posted yesterday, should resolve this issue.

Ah yep that should do it - Missed that since I got it from NPM. Thank you sir!

One more question on this - can we publish this latest version to npm?

Updated NPM version too, thanks for the reminder.

Perfect thank you!
On Thu, Feb 22, 2018 at 10:36 AM William Stuart Lazar <
<EMAIL_ADDRESS>wrote:

Updated NPM version too, thanks for the reminder.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SumoLogic/js-logging-sdk/issues/14#issuecomment-367759527,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ad3ve0SAtCDkC_CQPuosKGUVa52H3Q-Cks5tXaWfgaJpZM4SOijU
.


[feat] Link Component

Make a basic Link component that wraps a link in the classes we need for an internal link usa-link  versus and external link usa-link usa-link--external.
This is another way to encapsulate styles. See  Typography > Links.
By default renders an anchor tag, but has an optional prop to accept a different component.

We could use createElement similar to the work being done for #161

We need further discussion of what kind of user/developer experience we want for handling the customizable component.
Requirements

We want to be able to pass in a different base element to the link and apply styles to it.
We want a clear prop interface (if props are conflicting we should have an agreed upon approach that we communicate through warnings or type/prop errors).
We don't want to lose type safety.   Anchor tag links should still warn if the user doesn't pass in required attributes such as href (required for <a/>) or children (required by jsx-a11y for anchor tags).

Here are two approaches for consideration:

createElement #309
cloneElement #285

I should be clear that after seeing the solution proposed by @haworku I like it way better than the one I worked on.

okay I’m looking at this a little bit and I have some thoughts/questions:

I prefer the syntax of the first option (<Link<MockLinkProps asCustom={CustomLink}...). Having to pass in the custom component as a child feels a little confusing, since the children end up as the returned node instead of its contents.

I don't see why in the first option, we aren't adding the USWDS classes at all if it's a custom component. In that case there doesn't seem to be any reason to use it. I saw this comment:

The custom FCProps might have a variant that has a different meaning in the custom component, so we have to leave styling up to the custom component

and actually I disagree, I think our styling should still take precedent because that is really the only value our Link component provides at all. If someone is using it but has their own variant prop or wants to overwrite with their own styling then I think they should just not use this component.

It seems like there are a few different questions being asked and it's not clear to me that any of these decisions are bound together (but please correct me if I'm wrong...):

syntax to use for passing in custom component (asCustom prop vs. asCustomComponent and children)
whether to use createElement or cloneElement -- I will add there's a third option, which is:const Component = asCustom
return <Component {...linkProps}>{children}</Component>

how to handle conflicting props if passing in a custom component

Ultimately I would keep in mind two things:

I see the primary use case of this feature as if someone's using a routing library like react-router and needs to be rendering their Link component instead of plain ol' a tags. I would focus on that and make use of the example app, which already has react-router set up, to demonstrate test cases and see how the different options feel in a more real life scenario than Storybook can provide.
Just because someone is using this library for USWDS styles doesn't mean they are forced to use our Link component. So I wouldn't worry so much about making it bulletproof, and instead focus on the convenience it provides over making it work for every single scenario.

Thanks for the response and pointing out the separate concerns!  Agree that syntax is a separate issue.  For example, the syntax could change for passing in the custom component. We could use cloneElement with this syntax(<Link component={<CustomLink />} /> instead.
The main question is the prop interface on Link.
createElement (or the const Component = asCustom example) require expanding the acceptable props for <Link />. Maybe this isn't a big deal but the are potential conflicts with that and it seems we lose some type safety. variant isn't that rare of a prop name.  I saw some libraries use   warnings](https://github.com/formik/formik/blob/master/packages/formik/src/Field.tsx) to make sure people use the props accordingly and address conflicting types. That gets to issue 2. But I hear you saying that person shouldn't use our component.

After futzing for a bit, I really don't think it's possible for us to determine if their custom component also uses variant and so I don't think we could warn them.  This would only come into play if their custom component property variant is a string type.  We can document the limitation and live with it, I guess.

@ahobson do you want to rework #309 to handle styles also?? We can rely on typescript to warn and just add a comment in the component file of what it supported.
It should be quick -   I suggest looking at the earlier version  of my original PR from last week since it handles everything with styles and also uses createElement.  It just had messed up typescript because I couldn't figure out typing the way that you have 😄

@haworku I just pushed up a change to #309 that I believe does what we want.

This shipped in #320


Correct misleading sentence on progress for transparent click through

as per https://github.com/atom/electron/issues/1335#issuecomment-169963166
It seems a bit misleading to say its blocked on the chromium bug when the chromium team have said they won't fix it and atom should work around it.

:+1:


Authnet api

Upgraded Authnet API. ARB, CIM, Reporting Authnet APIs are now deprecated:  https://developer.authorize.net/api/upgrade_guide/

Upgraded some deprecated gems in accounting.

TODO:
Not figured out how to get expirationDate for creditcards from authorize.net API. Payment methods that are not created on RL(like Kiosk) will lose expirationDate after this PR.

@tmichaelreis I noticed the authnet API deprecation while I am working on NSF stuff. I have ensured all spec has passed. I gonna merge in and deploy to staging and check several QA items.


Style blocks (part 1)

[x] Heading : https://github.com/djangonaut-space/wagtail-indymeet/blob/develop/indymeet/templates/blocks/heading.html
This heading could be for stand alone or call out large text. It defaults to  When using headings h1,h2,h3,h4, in Rich Text box, style all headings by h so it will be inherited and additional styles can be added to this default heading.
[x] Paragraph : https://github.com/djangonaut-space/wagtail-indymeet/blob/develop/indymeet/templates/blocks/paragraph.html
[x] Quote block : https://github.com/djangonaut-space/wagtail-indymeet/blob/develop/indymeet/templates/blocks/quote-block.html
[ ] Video Embed : https://github.com/djangonaut-space/wagtail-indymeet/blob/develop/indymeet/templates/blocks/video-embed.html

TailwindCSS has a pretty aggressive normalize.css that doesn't allow for easy override. Currently tailwind is implemented in the unsafe temporary version using the cdn. #163 There's a ticket already to create a more production-ready implementation by adding tailwind in node.
I have two options: 1. tackle production tailwind set up now and hopefully the css inheritance allows me to style h1, h2, h3, h4 blocks and we can then use RichText Blocks. or 2. customize each element so we can add custom classes to each.

Went with option two and gutted the features of the RichText Block. It's still beneficial to keep RichText Block for underline, italicized, bold, strikethrough, superscript and subscript text.
The status of all elements can be seen on staging https://staging-djangonaut-space.azurewebsites.net/comms/elements/

Also need to make sure that all of these elements are responsive. Currently they are not.


ceph-mon: fix support for ipv6 on containerized mons

The fact ['ansible_$interface']['ipv4'] is a dictionary where
['ansible_$interface']['ipv6'] is a list. If we use
ansible_default_ipv6|ipv4 is is always a dictionary which allows us to
get the ipv6 and ipv4 address without adding more complexity to the
template.
Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451786

jenkins test kraken-ansible2.2-docker_cluster

jenkins test jewel-ansible2.2-centos7_cluster

With @leseb on PTO I'm going to go ahead and merge


2.0.15

Reformatted code
Removed unused .gitignore
Bumped version in fxmanifest.lua
Improved performance

That's a nice code cleanup! 🙂
I will gladly merge it but there are a few file that have indentations issues (I think they are using tabs instead of spaces).
Could you fix these files?
dlc_executive/apartment1.lua
dlc_executive/apartment2.lua
dlc_executive/apartment3.lua
dlc_finance/office2.lua
dlc_finance/office3.lua
dlc_finance/office4.lua
dlc_high_life/apartment2.lua
dlc_high_life/apartment3.lua
dlc_import/garage1.lua
dlc_import/garage2.lua
dlc_import/garage3.lua
dlc_import/garage4.lua

I would suggest switching from spaces to tabs, but I skipped that to ask you for opinion.

Well I kinda prefer 4 spaces instead of tabs but the most important is consistency ^^
I used to prefer tabs, it entirely depends of the IDE and the language
From what I see you set spaces everywhere but theses files so I think you can use spaces there too :)

Probably only in this file's atom doesn't change my tabs to spaces.
I personally would use tabs like most resources, but If you want spaces that's not a problem.

Np, that's all good, thanks! ;)


Build fails when thrift proxy extensions are disabled

The following build command fails:
bazel test //test/extensions/filters/network/...
.. when the following extensions are disabled in source/extensions/extensions_build_config.bzl:
envoy.filters.network.thrift_proxy
envoy.filters.thrift.router
envoy.filters.thrift.ratelimit
Build failure:
ERROR: test/extensions/filters/network/thrift_proxy/filters/BUILD:11:14: no such target '//test/extensions/filters/network/thrift_proxy:mocks': target 'mocks' not declared in package 'test/extensions/filters/network/thrift_proxy' defined by test/extensions/filters/network/thrift_proxy/BUILD and referenced by '//test/extensions/filters/network/thrift_proxy/filters:pass_through_filter_test'
ERROR: Analysis of target '//test/extensions/filters/network/thrift_proxy/filters:pass_through_filter_test' failed; build aborted: Analysis failed

I believe it is because the target in test/extensions/filters/network/thrift_proxy/filters/BUILD uses envoy_cc_test instead of envoy_extension_cc_test

The build command above succeeds with my local changes.  I will submit a PR

@zuercher: This seems to be related to #12003.


CompareDocs error

I tried running the CompareDocs functionality on the standard SPDX 2.3 example and got the following error:
java -jar tools-java-1.1.6-SNAPSHOT-jar-with-dependencies.jar CompareDocs output.xlsx SPDXJSONExample-v2.3.spdx.json SPDXJSONExample-v2.3.spdx.json
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.
Error opening SPDX document SPDXJSONExample-v2.3.spdx.json: Duplicate document namespace http://spdx.org/spdxdocs/spdx-example-444504E0-4F89-41D3-9A0C-0305E82C3301.  Document namespaces must be unique per specification and for a valid comparison.

That specific namespace is indeed duplicated in the referenceType of acmecorp/acmenator/4.1.3-alpha, something which we might need to adapt in the spec examples?
But the error above persists if I change the namespace so that it does not equal the other one anymore.

@armintaenzertng This error is referring to both documents having the same namespace - if you change the documentNamespace value in one of the to comparison documents to be different it will work.
Just FYI - The message is correct in stating the document namespaces must be unique per the spec, but the real reason for the error is due to a check before the compare takes place.  Before that check, the compare documents acted more like  merge documents and gave unexpected results.

Now that I think about it, we could change this from an error to a warning.
Instead of failing, we could, for the purpose of comparison, change the document namespace for one of the documents to be unique (e.g. add a random millisecond timestamp) and print the a warning like:
Warning - More than one document in the comparison has the same document namespace.  The specification requires
documents to each have a unique namespace.  XXXX was renamed to YYYY for the this compare.

@armintaenzertng - what do you think?  It would actually help me when using the utility for Docfests where we tend to get multiple documents submitted with the same namespace.

Sounds like a good idea, Gary! :)
For context: My intended use case was to compare two documents for actual equality. That is, I actually expect them to have the same namespace because they are the same. There would still be the issue that the output xlsx format would not be very well suited for an automated testing approach. Do you think we could add an stdout line stating whether the documents were equal or not?

My intended use case was to compare two documents for actual equality. That is, I actually expect them to have the same namespace because they are the same.

A different use case than what I've been using it for, but it makes sense.  Changing the namespace for the compare would fix it.  I would choose a slightly different message - more informational than warning.

Do you think we could add an stdout line stating whether the documents were equal or not?

Sounds like a good idea.


[Epic] Enhance CRC extension to allow deployment from setup

Exists here: https://github.com/containers/podman-desktop/issues/1419

During the work on this I found this issues:

https://github.com/containers/podman-desktop/issues/1701
https://github.com/containers/podman-desktop/issues/1695

@evidolob can you describe the severity/impact of the issue. Is it blocking, workaround needed, etc.

Non of them is blocking.
https://github.com/containers/podman-desktop/issues/1695 this is the worst, as it can brake our code execution(set up) if user press "escape" during preset selecting input box.
https://github.com/containers/podman-desktop/issues/1722 this doesn't show preset detailed information, which we provide.
https://github.com/containers/podman-desktop/issues/1723 just break UI of podman desktop status bar, when we add long text(which we do during installataion/setup)
https://github.com/containers/podman-desktop/issues/1701 this is not relevant for us, it just a bug in podman desktop dashboard widget

@evidolob combined the messages to make this clearer


Update CAPZ to v1.11.0 gs.alpha.0 from fork

Towards https://github.com/giantswarm/roadmap/issues/2675
:warning: This has not been tested, do not merge.
Update CAPZ to v1.11.0-gs.alpha.0 from our fork. This update the app to deploy the latest CAPZ v1.10.0 plus custom Giant Swarm changes (private links and private endpoint deletion fixes).
After testing and merging this, we can release CAPZ app v1.11.0-alpha.0. In order to test this and have it working, we probably also need to update cluster-api-app to use newer/latest CAPI version.
:rotating_light: Breaking changes in this PR:

v1alpha3 API types have been removed
v1alpha4 API types have been removed

Outdated. Closing.


Fix Rails/Date and /TimeZone issues in views

RuboCop can't find or fix these because it doesn't examine view files.
Details at https://www.pivotaltracker.com/story/show/174562904

Coverage remained the same at 92.173% when pulling 0e75bb5a532e74fd60cdfacaa1ecd85e01b26bb4 on 174562904-view-date-time into 6ab6a9bf5ad0cfb8ca7fb248a7c0e6141120a295 on master.

Looks good to me.  Shall I merge it?

Thanks so much for reviewing it!
If you feel like pushing it, please go ahead.
Otherwise, I'll do it in the a.m. (I'm heading to sleep in a few seconds.)
On Sat, Aug 29, 2020 at 9:02 PM Jason Hollinger<EMAIL_ADDRESS>wrote:

Looks good to me. Shall I merge it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/653#issuecomment-683373232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFHEWGXJUCDYV65PCDDSDHFMBANCNFSM4QPIVWJQ
.


rpm: mock tweaks

Store the ktdreyer-ceph-installer.cfg file in source control.
make rpm will now use this file directly, rather than assuming the
user has installed it globally in /etc/mock.

Tested on a el7 box and make rpm works with these changes.


config.metricsAdapters should default to an empty array

config.metricsAdapters defaults to an empty hash which causes the getWithDefault to an empty array never to be satisfied which causes filter since it's an Object and not an Array.

Thanks!


BD not loading plugins

So I have been having this issue for a few weeks now, finally out of options/things to try, so here ya go...fix it plox kthx.
Symptoms:
1: discord opens, loads up nice and fast (its installed on an SSD), after a second or 2, it freezes (I know this is an issue with emotes, keep reading)
2: after it unfreezes, it says it has "started" all my plugins, but its actually not starting them at all.
3: going into the plugins menu and turning them off and on again sometimes makes them start, but sometimes it doesnt
4: if you can manage to get them to start, then you hit CTRL+R to refresh discord, they wont start again and then no amount of turning them off and back on again will get them to come back (literally, the plugins either load on the first opening of discord, or its a RIP, quit discord and open again and pray)
List of things I've tried to fix it:
1: updating all plugins to the latest versions available (no dice)
2: removing all plugins, then testing them 1 at a time to see if its a specific plugin causing the issue (no dice)
3: noticed that "Emotes loaded" was taking forever (it used to be super fast, literally the very first thing that popped up before any plugins loaded), figured maybe thats the issue, deleted the Emote cache, turned off downloading emotes, disabled all emotes in the emote menu (no dice, although this does fix the freezing issue, which I also noticed others talking about in a different issue report)
4: using the newest bandagedbd for windows (the new GUI) to run a repair (which literally just reinstalls BD) (no dice)
5: uninstall BD completely (also wipe all BD data) and reinstall fresh, then put plugins back in (no dice)
6: uninstall both BD and Discord completely, and delete all relavent data (including roaming files) and then reinstall both (no dice)
welp, thats about it. Im all out of stuff to try. soooooooo...................can we get a fix sometime soonish???

soooooooo...................can we get a fix sometime soonish???
BBD is still working just fine. It sounds like an issue with the startup of the plugins you have, it is something that plagues plugins on occasion. A list of what plugins you're attempting to load would be helpful.

Lib Discord Internals by Samogot (required for next plugin)
Quoter by Samogot
MemberCount by Arashiryuu
ReadAllNotifications Button by DevilBro
ServerFolders by DevilBro

Is there anything in console about errors?


(WIP) Various fixes and implementations on process_data

Fixes #11, Fixes #26

The daemon requires the output to be packaged in a form that is not particularly useful otherwise

Please write in the header of process_data.py the exact output that is desired: folder name, zip name, what files inside folder (with what names), etc.

@stephaniealley if the current branch does not interfere with the challenge operations (ie people's submissions are processed and results sent back via WMGM script) then we should merge this branch and work on remaining issues in subsequent branches.

@jcohenadad I am testing the branch now to make sure that everything will work. Once I have confirmed, I will let you know that we can merge.

@stephaniealley: this PR is taking too long to be tested (it's been several days now) and people need to be able to reproduce their results from this repository (currently master is outdated). I will merge this PR now, and if you find issues with the WMGM communication script, open a specific issue about it.

That makes sense. The specific problem is not related to this PR. I will open a separate issue.

On May 29, 2018, at 7:35 PM, Julien Cohen-Adad<EMAIL_ADDRESS>wrote:
Merged #28.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Support Monero ransomware payments

Reportedly, approximately 10-20% of ransoms are currently paid in Monero (XMR), with many experts believing this could increase.
Monero support would require:

Support for longer addresses
Links to a different block explorer, such as xmrchain.net or exploremonero.com
Allowing amounts to be denominated in something other than BTC (XMR or the USD equivalent perhaps)

Why tho? Those can not be really tracked, and amounts can be only guessed unless someone starts to monitor chats


Summary statistics of the surface metrics

Is there a way to get the summary statistics for each of the surface metrics? I am looking to get the mean of the thickness, gyrification, and curvature. If you have an example of a script that I could use, that’d be very helpful.

Actually, I have a draft PR that does this (aggregating over subfields) in #178.
It should work (I think I only wanted to add some documentation before merging), but if you are using hippunfold on cbrain you may be better off just running the commands/code separately.
In that case, what I did was to use wb_command on the dscalar and dlabel files to parcellate with the mean value in each label, along with some other shell commands to fiddle with the resulting CSV file.
    shell:
        "wb_command -cifti-parcellate {input.dscalar} {input.dlabel} COLUMN temp.pscalar.nii && "
        "wb_command -cifti-transpose temp.pscalar.nii temp.tpscalar.nii && "
        "wb_command -cifti-convert -to-text temp.tpscalar.nii data.csv -col-delim ,  && "
        "echo 'L Sub,L CA1,L CA2,L CA3,L CA4,R Sub,R CA1,R CA2,R CA3,R CA4' > header.csv && "
        "cat header.csv data.csv > {output.csv}"

Can see more in the #178 PR as well. Let me know if that works.

Thank you for sharing your code. I understood what each line of the shell command is doing. However, I am not sure how to implement this locally on my device.
I checked the documentation of Connectome Workbench and I was not able to figure out how to go through the directories to acquire the surface metric CSV file. Do you have any example script I could take a look at to figure this out?

Connected by e-mail, but closing the loop here in case it is of interest to others too:
This gist has an example of how to calculate surface-based metrics aggregated over subfields and the dentate gyrus:
https://gist.github.com/akhanf/ae2547b7d201d9f303410956a59f4573
I'll keep this issue open as a reminder to include something like this in hippunfold workflow too

Keeping this issue open as I think it's a feature we should still try to incorporate into the pipeline.


Fix build-push-images.yaml

Wrong env variable is used for the password
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

@bnallapeta Please review asap.


initrd static ipv6 does does not work

Describe the bug
It appears to be impossible to configure static IPv6 for the inird.
To Reproduce
Steps to reproduce the behavior:

Configure with these options:

  initrd.network.enable = true;
  boot.kernelParams = [
    "ip=[2a10:xyz:zbc::12]::[2a10:xyz:zbc::1]:64:somehost::off"
  ];

Apply and reboot
See the error ipconfig: can't parse IP address '[2a10'.
Expected behavior
The IPv6 address passed to the kernel would be accepted and configured on the interface.

Screenshots

Additional context
It appears to be a problem here:
https://github.com/NixOS/nixpkgs/blob/740b2f851f95fc5d6390fc6e52c989b2cfbb5e1b/nixos/modules/system/boot/initrd-network.nix#L109-L120
Notify maintainers
@edolstra and @fpletz seems to have been the ones touching the code around the affected line last.
Sadly it has been some time (5 years) since the code was written it seems.
Metadata

(Sorry for the image, I only have console access right now)
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: boot.initrd.network.enable
# a list of nixos modules affected by the problem
module: system/boot/initrd-network.nix

It appears to be impossible to configure static IPv6 for the inird.

This, unfortunately, is still the case in 2023 for the old scripted initrd.
At least out of the box.
You could in theory ip addr add or whatever manually to boot.initrd.preLVMCommands, but this is terrible UX-wise.
Some distributions seem to provide an additional ipv6= kernel parameter besides ip= specifically for IPv6.
There is, however, a different solution in NixOS already: boot.initrd.systemd.enable
It's an alternative to our old scripted initrd and ships systemd-networkd, which allows for much better IP configuration -- including IPv6.
Closing (and sorry for leaving this issue a bit over 3 years open without a response).


BaPCod Installation Issues in Linux : Error with Chrono Library During Installation and Additional Error During Testing #14

I'm sorry, I accidentally closed the previous issues(#14 ), so I created a new one to follow up on the previous problem. Thank you very much for your advice. After updating the gcc version to 10.0.1, I was able to successfully resolve the issue related to the use of the chrono library. However, I am still encountering similar error messages during subsequent DEMO testing. Here are some partial log messages:

Dear HuiChang,
it's a pleasure. It seems that one of the boost dependencies hasn't been linked properly. Can you update your cmake , delete your build folder, and start again, please? In case of an error, can you send me your cmake logs ?
Best regards,
Najib

Dear Najib，
Thank you very much for your help. I have successfully resolved the issue. Please note that after completing all updates, it is necessary to reinstall Boost. Once again, thank you for your assistance!
Best regards,
huichang

Perfect ! Yes indeed, after updating gcc it was important to restart the installation. Thanks for your cooperation!
Best regards,
Najib


#10-Implement "Hero Banner" Block

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Partial fix for #10

Implement "Hero Banner " block styling (xlarge, large, medium, small / Mobile)
Leveraged calcite variables, spacing, font size, colors
Pending: Calcite Buttons

Test URLs:

Original: https://www.esri.com/en-us/about/about-esri/overview
Before: https://main--esri--aemsites.hlx.live/en-us/about/about-esri/overview
After: https://hero-banner--esri--aemsites.hlx.live/en-us/about/about-esri/overview

What should be fixed in this PR:

Performance: Fix CLS issues
Best practices (mentioned in an inline comment on the hero)

Other stuff that's pending:

Fix autoplay (https://gist.github.com/amol-anand/f797e6ab9513898e132987dabcaca262 from https://www.aem.live/developer/block-collection#block-party)
Fixing text style and placement

Note: I've updated the task description from "Fix" to "Partial fix for" to prevent autoclosing the issue when this is merged


Update functions/Copy-DbaLogin.ps1

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose

Update example to reflect current parameter name

fantastic, thank you! 🔥 🚒


Update installation instructions

We've moved to fisher install in 4.x.

@jorgebucaran Thank you for PR!! I didn't know the change.


⚠ Bofrost.fr has degraded performance

In e3dc33e, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1342 ms

Resolved: Bofrost.fr performance has improved in bb8a574.


Table page - Active label

The Table page has a green 'Active' label underneath the data type. What this is supposed to indicate? Can it be removed?

Every column has a time-based "active" window. Two date/time elements can be defined per column to make it active/inactive. I suggest the wording to change to "Enabled/Disabled". Alternatively, only the "Disabled" columns may show a label. Any preference?

Okay, Now I notice the date-time fields when I edit the column heading, and it shows Inactive when I set yesterday's date, though I still don't know what they do, so changing the names to Enabled/Disabled won't help. I agree though that you should only show the label if the column is inactive (or disabled) and perhaps have a tooltip on mouseover explaining the feature?

Good point.

"Active" message will not appear. Only "Disabled" if the column is disabled, and the popup will say "Out of given date/time window. Edit column to enable"

Sounds good.

Solved in Version 2.6.1


Add jablotron to latest

Please add my adapter ioBroker.jablotron to latest.
This pull request was created by https://www.iobroker.dev c0726ff.

@ticaki
All mentioned improvements have been implemented.
You are right with the last topic. There will be states to react on in the future. Therefore, the binding to 'stateChange' has been prepared.

All mentioned improvements have been fixed/implemented.

This adapter has been released to latest repository and should be visible within 24h maximum.
Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " (if not already done) to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.
Note: If an other testing topic already exists, ist OK to continue using this topic too.


Profile shows install server no start server after install

If you switch profiles while installing a server it shows install gain. This only happens if the server isnt istalled completly.
Fix for now: If the server is installed and you switch profiles or relaunch the program the start server button shows up again

Start button will be visible after steam install for now.
So if it isnt installed it gets an error, enshrouded_server.exe not found


Promote a bunch of Swift 3 compatibility access warnings to errors.

This was done back in Swift 3.0.1 or 3.0.2. Let's finally make them errors in Swift 4!
I also fixed up a number of %error entries in diagnostics that can actually happen in invalid code. These are the ones that were already present in the warnings.

@swift-ci Please test

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 6a1b9580ee2aeabefbe947753015542b44412a1d
Test requested by - @jrose-apple

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 6a1b9580ee2aeabefbe947753015542b44412a1d
Test requested by - @jrose-apple

Well, the text changed too, so I don't feel so bad. Thanks, Harlan!

@jtbandes Might also want to get in on this after his last big push for trapping in diagnostics.

Can we add test cases for the “in this context” versions?

(The point of %error was to crash so we could catch it in validation tests, but if these could happen, I guess they weren’t tested properly 😉)

Any places where they could happen before would always fall into the "warning" case; now that's no longer true. Yes, I can add more test cases, though maybe as a follow-up. (They only come up when you violate the model once and then reference that declaration.)

@swift-ci please test
(borrowing this PR to test a test infrastructure issue)


transport: core envoy

Proposal for refactoring in core envoy to allow for seamless use of transport in iOS and Android as well as current server mode.

this is done for 0.2 as part of the Direct API


[10.x] Add increment to Str helper

This PR adds  increment to Str helper.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


CDPS-891: Removing misleading telemetry event

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.45%. Comparing base (7c0de4b) to head (09a2a3e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
- Coverage     84.55%   84.45%   -0.10%
  Complexity      655      655
============================================
  Files           100      100
  Lines          2026     2020       -6
  Branches        193      193
============================================
- Hits           1713     1706       -7
- Misses          193      194       +1
  Partials        120      120

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make line option in regex optional

line group in regex that parses linter output is mandatory now, but can accept empty string as special case, so it treats file path as id line. It's a hack, and we should add more obvious way to make the same.
I suggest to make line regex named group optional, and absent line group means to 'line = ''`

[ ] Make line regex named group optional
[ ] Update docs

Plugins system provides more convenient way to do it, no longer needed


Add Edge support

Can filter lower when Edge browser
lowerThan: 'js:Promise',
or
 lowerThan: 'Edge',

When will this be merged?

We will need this PR to be merged for some project targeting only evergreen browser.
Thanks ;)
/cc @neonox31

Hi there,
We need to analize this asap.
Need to test across all browsers because the plugin need to work in ie6 + and all this changes need to be tested in all old browsers.

For information, I use it with ie8, seems tout work well 😉
On lun. 25 sept. 2017 à 11:18 Kum0ri<EMAIL_ADDRESS>wrote:

Hi there,
We need to analize this asap.
Need to test across all browsers because the plugin need to work in ie6 +
and all this changes need to be tested in all old browsers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/burocratik/outdated-browser/pull/269#issuecomment-331824620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4S6r_V2TMhK3_dwMke7KN_7ziNtSqdks5sl2_hgaJpZM4Ns4tc
.

--
Davin Kevin

Ok, thanks for the input! :)

On 25 Sep 2017, at 11:14, Davin Kevin<EMAIL_ADDRESS>wrote:
For information, I use it with ie8, seems tout work well 😉
On lun. 25 sept. 2017 à 11:18 Kum0ri<EMAIL_ADDRESS>wrote:

Hi there,
We need to analize this asap.
Need to test across all browsers because the plugin need to work in ie6 +
and all this changes need to be tested in all old browsers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/burocratik/outdated-browser/pull/269#issuecomment-331824620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB4S6r_V2TMhK3_dwMke7KN_7ziNtSqdks5sl2_hgaJpZM4Ns4tc
.

--
Davin Kevin
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/burocratik/outdated-browser/pull/269#issuecomment-331838101, or mute the thread https://github.com/notifications/unsubscribe-auth/AOSCRDRkhStcoA38C_H6odsHioazJWv9ks5sl3zogaJpZM4Ns4tc.

@alexprg @brunoamorim  what the hell are you guys waiting for with merging with this project?

@danvaz ?

Hi there @karolyi ,
As said before, we need to check the changes and we didn't found the time to do it.
Tkx,
daniel

@Kum0ri if that helps, I started using this PR's .js file in my production, it works just fine. I targeted IE11 with it, tested before locally (lucky I still have IE11), and can confirm it works.

Proof:

I think that all want see test in ie6 ))) May be you can get screen? I use my version of outdated-browser for all my projects. I don' known why is PR is so long wait approved

hmm, maybe I can pull an older IE. I have an XP virtualmachine.

so I fired up my old XP machine, and IE8 is installed within. however I couldn't test the code since those browsers use such an outdated SSL implementation which my server will not accept.
I guess that's the end of my testing. guys, merge this PR already.

Hey guys,
Merge done, sorry for the delay.
If you can please test it we would appreciate it, and any bug please report back.
thks,
Joao

When testing this, the notice shows in all browsers I try it in. IE, Edge, Chrome, FF on both Win and Mac. Do you know any solution for it?

Any news on this? :)

@esonesson you must have done something wrong. I use this version of the JS file and it works.

@esonesson, I experimented the issue and finally find out why. I installed through bower so I get the master branch where this PR has not been merged yet so take care using the develop branch and then use the non minified js file (the patch has not been applied to the minified file) . Then it should work correctly.

Hi there, tested in Edge / IE 11, Chrome, FF and it works :) Thanks @romanlex

Great to see this merged, but why hasn't the minified version been merged along with the non-minified? I was using the minified version, and wondering what I had done wrong when in actual fact the minified version simply doesn't include the changes made to include lowerThan: 'Edge' support...

After 8 months it would be great to have synchronized version between the minified and non minified version :)

Can we re-open this issue? Edge support is not included in the minified file.


Fix: broken plugin options schema

Well this was a hard one to figure out. Gatsby is using the deprecated version of Joi for which there are no docs. I had changed out plugin options schema to work with the latest joi version (not realizing Gatsby isn't using this) so I could generate our plugin options.. well this resulted in Gatsby swallowing the joi error somehow and the build crashing on something completely unrelated... I finally figured out what was causing it by trial and error (it was a default value in the joi schema that was a string where the actual field is not a string and latest joi allows examples that are strings where the deprecated Gatsby version only allows examples that are of the type of the field...

Should rename this PR something punny. Like "oh the joi of silent failures"

Should rename this PR something punny. Like "oh the joi of silent failures"


basic example

I got run the basic example doing this :
first git clone the repository : https://github.com/tensorflow/tensorboard/tree/javascript
go to following path : tensorboard/tensorboard/examples/plugins/example_basic/
execulte :
python setup.py develop

now go to following directory:

tensorboard_plugin_example/

and run  demo.py
python3 demo.py

now just run copy demo_logs in /tmp/runs_containing_greetings
cp -r demo_logs  /tmp/runs_containing_greetings

now just run tensorboard:
tensorboard --logdir /tmp/runs_containing_greetings

here is a explanation about how plugin on tensorboard works
https://archive.org/details/github.com-tensorflow-tensorboard-plugin-example_-_2017-10-05_18-52-48


Update Navigator

Add the ability to change key mappings on a fly via getActive method ($menu->getActive(['children' => 'dop_menu'])).
Change return data structure from $menu->children() (remove root key 'items' add return data from one more level deep);

PS: Think about implementing some kind of customizable transformation (like API Resources) for quickly remapping and changing the payload.
View::composer('*', function ($view) {
            $menu = \Navigator::buildMenu(config('nav.sidebar'));
            $dopMenu = $menu->getActive(['children' => 'dop_menu']);

            $view->with('sidebar', $menu->children());
            $view->with('dop_menu', $dopMenu->children());
        });

➤ Galymzhan Begimov commented:
$menu->children()->toJson();
$menu->getActive()->children();
$menu->getActive()->children()->toJson();
$menu->getActive(['children' => 'dop-children'])->children();
$menu->getActive(['children' => 'dop-children'])->children()->toJson();


Add ability to provide own customization in AutoMockData

For #24

Unfortunately you haven't provided any tests for the change - unit test on Core assembly level is a must.
Moreover it is implemented only on AutoDataBaseAttribute level - for consistency it should be added to InlineAutoDataBaseAttribute and MemberAutoDataBaseAttribute.

Customization to test method arguments should be done with CustomizeWith attribute - see details.


ansible(slicer): Fix install of extensions

From @muratmaga

Extensions are not installed by default.

slicer_extensions:
  - SlicerMorph
  - SurfaceWrapSolidify

Source: https://github.com/jcfr/exosphere/blob/5f85d93d58c746856019dce43c8686e1eeadcb36/ansible/roles/slicer/vars/main.yml#L14-L16
- name: 'Slicer extensions installed'
  become: yes
  become_user: exouser
  command: "{{ install_dir }}/dist/slicer-download.sh -d {{ install_dir }}/Slicer -v {{ slicer_release_id }} -e {{ item }}"
  loop: '{{ slicer_extensions }}'

Source: https://github.com/jcfr/exosphere/blob/5f85d93d58c746856019dce43c8686e1eeadcb36/ansible/roles/slicer/tasks/main.yml#L82-L86

Extensions are indeed installed:

SlicerMorph
SurfaceWrapSolidify

Issue is that extension manager settings are not current.

Fixed in MorphoCloud/exosphere@57c952b1 and integrated through https://github.com/MorphoCloud/MorphoCloudWorkflow/commit/2c82cc300f958a95be5ec992a31677034b2ee721


[question] Who is joyvan?

Just curious - I keep seeing him / her / it everywhere!

Jovyan : Jupyter :: Jovian :Jupiter
https://en.m.wikipedia.org/wiki/Jovian

ohhhhh! Thank you! I love it <3

This thread sparks joy


install chromium-browser

chromedriver version was out of sync with browser version
updated setup script to install both at the same time - should resolve issue
also a small fix to one test which was using an old selenium function

@alexgillcma not sure why merge is blocked.


Unable add more than one element in RecyclerView

Hi David,
I can't understand "base logic" of FlexibleAdapter for add more than one element in recyclerview (with cardview):
Add item 1 and 2, but createViewHolder and bindViewHolder call once and my recycler view contain only one element:
Log:
I/FlexibleAdapter: Running version 5.0.0-rc2 built on 2017.06.10
I/FlexibleAdapter: Initialized with StableIds=true
D/FlexibleAdapter: addItems on position=0 itemCount=1
D/FlexibleAdapter: addItems on position=1 itemCount=1
I/FlexibleAdapter: Mapped viewType<PHONE_NUMBER> from ObjectItem
Source:
for (ObjectMarker objectMarker : cluster.getItems()) {
objectAdapter.addItem(new ObjectItem(objectMarker.getClientObjectItem(), objectMarker.getClientObjectItem().getName()));
}
objectAdapter.notifyDataSetChanged();
What's wrong?

Hi @rusxakep, there's no strange logic to adding items.
First, did you read the documentation Setting Up?
Then, normally you don't need to call notifyXXX methods anymore, unless you are in a particular case.
It could be a wrong implementation of your equals method in the item, because Java see it equals, so when Java search for the items the first one is always picked up and shown.

Remove any notifyXXX, thank you.
Tested now my equals implementation:

new ObjectItem(new ClientObjectItem(100L, "ddd")).equals(new ObjectItem(new ClientObjectItem(100L, "ddd"))) : true
new ObjectItem(new ClientObjectItem(100L, "ddd")).equals(new ObjectItem(new ClientObjectItem(101L, "ddd"))) : false

What's else, I should be check?

@rusxakep, I have few information now, I can't see what could be your issue.
Try to call updateDataSet(cluster.getItems(), true) for now.
For the rest you need to share something more, like ObjectItem, you could also debug and see what the adapter list contains after the second addItem.

ObjectAdapter contains correct mItems (ArrayList with 2 ObjectItem's) after next addItem ...
Call stacktrace (1,2,3 is unique id):
new Adapter(xxx)
Adapter.addItem(new ObjectItem(1))
Adapter.addItem(new ObjectItem(2))
Adapter.addItem(new ObjectItem(3))
ObjectItem.hashCode (1)
ObjectItem.createViewHolder(1)
ObjectItem.hashCode (1) <---- ??
ObjectItem.bindViewHolder(1)
That's all.
Where is 2 and 3 calls, I don't know.

updateDataSet(cluster.getItems(), true) worked more correct, I testing now and edit message later.

Call stacktrace with updateDataSet:
new Adapter(empty item list)
....
updateDataSet(items, true)
ObjectItem.hashCode (1)
ObjectItem.hashCode (2)
ObjectItem.hashCode (3)
ObjectItem.hashCode (1)
ObjectItem.hashCode (2)
ObjectItem.hashCode (3)
ObjectItem.hashCode (1)
ObjectItem.hashCode (2)
ObjectItem.hashCode (3)
ObjectItem.createViewHolder(1)
ObjectItem.hashCode (1)
ObjectItem.bindViewHolder(1)

Sorry @rusxakep, I do not understand your log, please share adapter logs, and equals and hashCode methods.

Ok @davideas, I debug flexible adapter by myself and edit this post after that.
Thank for reply

Simply test:

@rusxakep, LOL!! Please, scroll up the bottom sheet :bulb:
You are sorry, don't worry.

Yep, you are right.


Add rate limit exception to readme

Approved by @imdadahad via : alphagov/notifications-net-client#10