Unnecessary kernel checks Docker does

https://vpsdime.com/viewticket.php?tid=166125&c=F14mAeDT

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Can you provide a specific problem?
In general kernel version checks only issue a warning.

and they usually doesn't strictly check for specific version but functionalities

Sorry for not being clear on the issue:
VPSDime, a very nice VPS provider claims that Docker makes arbitrary/unnecessary checks on the kernel, which prevents OpenVZ, their virtualization platform to run Docker containers, and therefore they do not allow their clients to do so.

Here's the kernel checking code: https://github.com/docker/docker/blob/master/daemon/daemon_unix.go#L75-L90
Docker does not bail out when the kernel version is not new enough, only warns.
Closing, but if we can find a specific case where this is an issue, please ping here.
Also note, the minimum "supported" kernel is 3.10, not 3.16 as is suggested on the ticket.
Thanks!


filters: fix edge case where on-data receives Envoy's internal buffer

Description: In certain cases - for example, when a previous filter in the chain stopped and buffered the request, and a subsequent filter stops iteration as well - the on-data filter invocation receives Envoy's internal buffer directly. This makes sense, since that's where Envoy has buffered all data, but it means that an attempt to preemptively aggregate new data into the buffer should be skipped: it's already there.
Risk Level: Low
Testing: Local and CI (#1157)
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

Shouldn't https://github.com/lyft/envoy-mobile/pull/1157 be failing without this change?

Yep, it did: https://github.com/lyft/envoy-mobile/pull/1157/checks?check_run_id=1335120176

Ah cool, hadn't yet failed when I was reviewing


Allow for MSAA

Multi-sampling AA allows to smoother edges. Higher values come with higher costs, but it's fairly easy to implement.
The default is at 1 (so only a single sample), but some games offer higher values (2, 4, 8, 16).
It'd be nice if we offered to change this in our RunOpts.
More info here: https://www.youtube.com/watch?v=Pdn13TRWEM0&list=PLRIWtICgwaX0u7Rf9zkZhLoLuZVfUksDP&index=41

Okay, tbh... Either my implementation doesn't work, or it's just not useful for the pictures I tested them with.

@EtienneBruines I'd suspect the latter.

how does this help in 2D?

@Newbrict it will help with lower resolution images looking better; but I guess using a higher resolution image is probably preferred.

When drawing shapes, this matters.
Non-AA

With AA

Fix will be part of https://github.com/EngoEngine/engo/pull/266.


Failed to load resource: the server responded with a status of 500 (Internal Server Error)

Hi, I followed all the steps mentioned in the README.
Finally, when I re-run the SSRS server, I get this error -
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
http://localhost/ReportServer/Logon.aspx?ReturnUrl=/ReportServer/localredirect?url=%252fReports
Am I missing something here ?

Can you check the logs to see what is the error.
Also double check you are using validation Sha1 when generating the keys, or use IIS to generate the keys

Hey @jtarquino. Thanks for replying. I was using AES validation when generating keys, as mentioned here https://github.com/Microsoft/Reporting-Services/tree/master/CustomSecuritySample2016.
But, I also tried using Sha1, but same issue persists.

I have heard some issues generating the keys with that article, please use IIS instead, also can you check the logs and share the error

Hi @JatinKinra what's the solution ? did you find anything ?
can you please help to me? I am also stuck on this.


Bump go.mod version to v2

Summary

To reflect the actual major version and follow the official recommendation regarding go.mod versioning
Use Cases

https://go.dev/doc/modules/version-numbers

A major version update to a number higher than v1 will also have a new module path. That’s because the module path will have the major version number appended, as in the following example:

module example.com/mymodule/v2 v2.0.0

A major version update makes this a new module with a separate history from the module’s previous version. If you’re developing modules to publish for others, see “Publishing breaking API changes” in Module release and versioning workflow.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Hello @pbusko :wave: ! Thank you for your contribution :) Can you describe how consuming the versioned node-start from the node-start module will benefit the node-start module? I'm asking for a little bit of context as this change makes sense for consuming external modules, but I can not find a scenario where the same module would benefit from not consuming the latest version of itself. Also, it seems that this change is adding an extra step during development, as for consuming the latest version of the node-start you will have to make a publish first.

https://github.com/paketo-buildpacks/node-engine/pull/966#issuecomment-2220177727

see discussions on https://github.com/paketo-buildpacks/node-engine/pull/966

Related issue https://github.com/paketo-buildpacks/nodejs/issues/913

Based on discussion in https://github.com/paketo-buildpacks/nodejs/issues/913 we'll land these add hock for now. @pbusko can you rebase and then I'll land.

Thank you @mhdawson, the PR has been rebased

@pbusko unfortunately seems to need another rebase. Will enable auto-merge so it should land as soon as the tests pass. I had started them yesterday but seems there was some change between then and now.

@pbusko can you rebase again?

@pbusko can you rebase once more? I thought the auto merge was enabled and in the mid-time another PR automatically landed. sorry :)


What to Learn to get started with Android App Development with java

Description 📜

Technology and language to learn beforehand or along with app development.
Basically, it will be the roadmap to help beginners starting with android app development with java .

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

I want to work on this issue, through documentation,
In Android Dev branch

/assign document


Remove font-awesome and patternfly from src and resolve as dependency

Right now it's in https://github.com/atlasmap/atlasmap-ui/tree/master/src/app/lib, should be removed and resolved at compile time

@gashcrumb got 404 for font-awesome and jquery while it seems fine for patternfly ... looks weird as I did same for all but it contains node_modules dir in the path for font-awesome and jquery, but not for patternfly. any idea?
[1] 17.10.12 11:57:44 404 GET /node_modules/jquery/dist/js/jquery.min.js
[1] 17.10.12 11:57:44 304 GET /bootstrap/dist/css/bootstrap.min.css
[1] 17.10.12 11:57:44 304 GET /patternfly/dist/css/patternfly.min.css
[1] 17.10.12 11:57:44 304 GET /patternfly/dist/css/patternfly-additions.min.css
[1] 17.10.12 11:57:44 404 GET /node_modules/font-awesome/dist/css/font-awesome.min.css
[1] 17.10.12 11:57:45 404 GET /node_modules/jquery/dist/js/jquery.min.js
[1] 17.10.12 11:57:45 404 GET /node_modules/font-awesome/dist/css/font-awesome.min.css

ugh OK, font-awesome doesn't have dist dir. will check those paths again.


[Bugfix] Avoid "RangeError: Invalid typed array length:<PHONE_NUMBER>" when using more than 2 caveats

I noticed that I get an error when using more than 2 caveats:
RangeError: Invalid typed array length:<PHONE_NUMBER>
Then I found out that the problem is the _grow function of ByteBuffer that always doubles the buffer in size and therefore grows exponentially, even if just one byte is added to the buffer.
My PR fixes this issue as well as two pre-existing bugs (there was a variable this._capacity in _grow that wasn't defined any more and I had to format test/verify.js to make eslint happy).

@hatched can you take a look at this PR please?

Thanks for this pull request @guggero !


Update imports to work properly

Update Dockerfile so API, etc, work

Merging without Jenkins completion to un-break the site.

Whoops, you raised this against vnext-engine.... I'll open a new PR.


xSQLServerSetup: Create integration tests

We should start to create integration tests. xSQLServerSetup would be the ideal resource to start with since all other integration tests are dependent on that working (?). We need a SQL instance to test the other resources on.
If nobody else is up to it I would be happy to try to get some basic integration tests done. It would be a fun challenge.
I looked at @plagueHO's integration tests in xNetworking and also the integration tests in SharePointDsc. And templates are here: https://github.com/PowerShell/DscResources/tree/master/Tests.Template
But... I need a bit more information how this works practically.
@kwirkykat @mbreakey3 @plagueHO or anyone else with experience with this.

To be able to create an integration test for xSQLServerSetup I would need the SQL Server media somewhere accessible, preferably all supported versions, either on the node or in a UNC path. How does this work?
Does the node get clean (new) before each commit to PR? Or is there a need for the integration test to clean up (uninstall SQL in this case) before next commit? (I would guess/hope tests always run on a clean node)
Is it possible to have a node with a pre-installed SQL Server instance (preferably an separate instance for all supported versions) so some integration tests can run aginst that/those so the finish quicker (than waiting for the xSQLServerSetup integration tests to finish).
For some resources we need to use user accounts. It might work with local user accounts, but some resources might need an AD, for example using Failover cluster (?). That means it would need an AD as well. Is that possible? (Preferably the AD could be cleanup after the test run is finished, and not deploy a new AD each run)
For some tests we might need two nodes with failover cluster (for AlwaysOn, and failover installs) to actually test stuff. Is that possible? (Failover cluster could be setup using DSC as well)
How far do we go with integration tests? :)

Ideally, integration tests should test all basic functionality. I'm not entirely sure how much setup is required to run most of the SqlServer configurations, but I would start with just the very simple cases - minimal arguments, etc. - and get those working and then build from there. I would check out our integration tests in PSDscResources to get started.
Go ahead and import any outside modules/plugins you need within the test - just make sure they get cleaned up in the 'finally' block at the end of the test. Each integration test should be independent of the others, so any setup that you need should be done before applying a configuration. (You can use Reset-Dsc to ensure this happens).

Integration tests are a bit more flexible than unit tests since the way to write them can vary based on the nature of the resource, so we don't have as many hard rules on writing them. The main thing is that it's testing the actual functionality of the resource - making sure it really does what it says it does.

Thanks for all the information! I think I need a crash course in AppVeyor. Are these assumptions correct?

Build = every push to a PR in our case?

"Every build runs on a fresh virtual machine which is not shared with other builds and the state of which is not preserved between consequent builds. After the build is finished its virtual machine is decommissioned."
https://www.appveyor.com/docs/build-configuration/#build-pipeline

I can not install each major version SQL Server on a separate clean AppVeyor server, they always need to be installed side-by-side to test more than one major version of SQL?
I can not point some integration tests to run an AppVeyor server with a pre-installed SQL Server instance? (each test need to start with installing SQL Server)
"DSC Team" (Microsoft) will not provide the SQL Server media .iso for each major version, on the AppVeyor server, or on any other location accessible by the integration test?

@johlju - I doubt there is any (easy) way to create integration tests for xSQLServer that will work in AppVeyor because of the dependency on having access to either:

MS SQL Server install media
A AppVeyor build machine with SQL Server preinstalled.

But I still think you could create integration tests that run in your own environment if configured correctly (e.g. the media ISO's were made available).
In answer to your questions:

Yes, every PR would trigger an AppVeyor build to occur.
That is correct as far as I know. Although it would be possible to install SQL Server onto an AppVeyor build worker by including a step that downloaded the MSFT SQL Server Eval ISO (or possibly using some other package management system). It might be worth a try to see what would happen.
The only build worker types that are available on AppVeyor are:

None of them contain SQL Server preinstalled as far as I know.
I don't think the DSC Team could provide this even if they wanted to (although perhaps if all the AppVeyor machines were hosted in Azure it might be possible :smile:).

All that said, it might be worth asking the AppVeyor team if they'd consider including a build worker that contains SQL Server. If they could do this then that might enable integration tests in AppVeyor.

@PlagueHO I saw yesterday that they did have the express installation of each major SQL Server installed on each build server, but the service was not started by default. But if so, then there are already stuff present on the build servers which might make the test unreliable (already SQL stuff on it) or full SQL Server will possible break when installing (never tried that combo). But I will see how far the Express version can be used for some of the integration tests.
I also thought about fetching the eval version of SQL Server. If that works then we could at least test the latest version of SQL Server. But then i preferably would like to have a clean build server.
I will dig into AppVeyor a bit more. I will also checkout Test Kitchen if it can help in any way.
I did activate AppVeyor on my xSQLServer fork so I can test easily with a test branch.
If nothing else I will create a basic integration tests to run on a server and .iso provided by the user. I don't think all contributors will have lab environments to run integration tests, so would have been awesome to actually be able to test on a push. But we have to use what we have and go from there. :smile:

We got simple integration tests going with PR #710. Doing integration testing for the advanced installation options using xSQLServerSetup which depends on a cluster and AD will not work with AppVeyor in the way we use it now.
I'm currently working on option 4.1 for the resource module xFailOverCluster.
Options
Option 1 - Docker - did not work
Setting up a several Docker images in the AppVeyor build worker. Would work if Failover Clustering would run on the server core docker image. It does not (today).
Option 2 - My personal Azure subscription - not secure
Setting up an environment for integration tests in my personal Azure subscription is not secure. There is no secure way to set up a test environment for public use and allow PR's to test against it. Application ID and Password will be available publicly.
Option 3 - AppVeyor Build Cloud - works, but costs money
This would work and be secure using an AppVeyor Build Cloud against Azure, where the configuration against an Azure subscription would be secure in the AppVeyor portal, and then each PR could be tested as well. But that will be a monthly cost of $500 (for open source projects) for the DSC Resource Kit.
But it would enable us to have an a working domain already ready for running integration tests against My thought with this was just provisioning the servers that are needed for the integration test).
Option 4 - Add a new manual testing framework
Option 4.1 - Manual tests in Azure
I'm currently working with the DscConfigurations repository to see if that can be used to able integration testing for xFailOverCluster. xFailOverCluster has similar problems as xSQLServerSetup that it needs several servers for testing (AD etc.). If that works, the same setup can be used here.
Option 4.2 - Manual tests in Hyper-V
Not started work on this. Running the integration tests in Hyper-V, using for example LabBuilder or Lability).

This is from PR #1295 by @codykonior

I ran it on my 5-node lab which can be built with my OftenOn PowerShell module and the script executed in a PowerShell admin console on CHWK01 to reproduce.
...
This separate test is pretty huge and in this gist so as not to clutter up the PR but the final bit which is captured in the gif is easy enough to understand..

@codykonior This is really super awesome work! We should really need to have a manual integration tests that can be run locally. It sounds that you have already done a lot of work for this.
I would be really interested in merging something that, at least starts to, cover option 5.2.


Document --values-for valid keys

For the life of me, I can't find where valid keys are defined or how they're determined.  This information would be particularly handy in the awless show --help output.  FWIW, my immediate use-case is only concerned with EC2 instance "Launch Time".
awless show i-foobar shows an Uptime key but that doesn't work.
$ awless show --values-for Uptime i-foobar
[error]   no values for ["Uptime"]

aws-cli shows a LaunchTime key but that doesn't work either.
$ aws ec2 describe-instances --instance-ids=i-foobar | jq -r '.Reservations[].Instances[]'
{
  "AmiLaunchIndex": 0,
  "ImageId": "ami-foobaz",
  "InstanceId": "i-foobar",
  "InstanceType": "m4.large",
  "KeyName": "foo",
  "LaunchTime": "2020-04-03T16:10:26+00:00",
...

$ awless show --values-for LaunchTime i-foobar
[error]   no values for ["LaunchTime"]

My google-fu can only find examples of ID, name, and PublicIP.  As an aside, the argument appears to be case-insensitive but that's not called out either.

@simcap
Lol -- thanks for the heads up!


Fix 0 model replicas display text

Closes https://issues.redhat.com/browse/RHOAIENG-384
Description

The initial data retrieve on the modal would skip 0 and default to 1 because it was a falsey check and not a nullish check.
I also saw on the model row details it would show "Unknown" for 0, so i did the same fix there.

How Has This Been Tested?

Edit an already deployed model (kserve and/or modelmesh)
Set the replicas to 0 ("Number of model server replicas to deploy" field)
Save
The model row details should show "Model server replicas 0" instead of "Model server replicas Unknown"
Edit the model again
The "Number of model server replicas to deploy" field should display 0 instead of 1

Test Impact

Very minor change so no tests updated
Request review criteria:

Self checklist (all need to be checked):

[X] The developer has manually tested the changes and verified that the changes work
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[X] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve


Type propogation into data variable

Version and Platform (required):

Binary Ninja Version: 3.6.4644-dev Personal, d289b1cc
OS: windows
OS Version: 11
CPU Architecture: x86_64

Bug Description:

File: same as #4758

The real problem is that we are not propagating type info into data variables.
An alternative solution is to detect the type of the argument is a char* and then render it as a string, regardless of the actual data variable type. However, I am not sure that is a robust approach that fits into most cases.
A workaround for now is to press 'A' at the data variable to define a string there, and the HLIL should be able to pick it up.

I am pretty sure we have an issue that tracks "type propagation into data vars", but I cannot find it at the moment. Any idea? @fuzyll

I'm not sure. I also don't explicitly see an issue that tracks that. #4692 is probably related?

It seems %s is not considered as a string.

Duplicate of https://github.com/Vector35/binaryninja-api/issues/4400


Problem compiling in M1 - React Native

I have problems compiling the app on my macbook m1

Is there a solution to this problem?

Hi @estevg and thank you for opening this issue. The next version we will release (6.3.0) will support M1.


styletron 3.0.0-rc.2 is not on NPM

Hello,
It would be nice to have the version 3.0.0-rc.2 of styletron packages published to npm, since it has support for react 16.
Thanks

after a closer look I found out that the styletron-react package is at version 3.0.0-rc.2.
Sorry for the noise


Use openapi-sdkgen for ibm_cloud_resource_controller

Re-create ibm_cloud_resource_controller gem by running prepare_project.sh from the ruby-sdk-template and openapi-sdkgen for the resource-controller/resource-controller and resource-controller/resource-manager APIs
Bump to v2.0.0

https://github.com/ManageIQ/manageiq-providers-ibm_cloud/pull/185 updates the powervs provider


Problem with maintainAspectRatio attribute in Radar Chart

Inverse behavior as expected in Firefox and chrome.
Using:
Chart.defaults.global.responsive = true;
Chart.defaults.global.maintainAspectRatio = true;

Using:
Chart.defaults.global.responsive = true;
Chart.defaults.global.maintainAspectRatio = false;

I think this happens because the initial canvas aspect ratio is not the final canvas aspect ratio

could not reproduce, have a plunker?

Closing in need of test case.


where is the extra_aug.py

I find no extra_aug.py in the project , is this the file I need to write it myself?

in the branch "pt0.4.1", a stable version of mmdet. And you can write your own methods for your dataset.

Thanks a lot .


Where are the client side actions?

I'm trying to use your server side code with an expo (react-native) client side, but I'm little confused about how I would do that, since there are no api endpoints due to Apollo I'm guessing, and also I don't see any client side POST actions that I can mimic.
I suppose it has something to do with new OothClient({ ooth?  Are there any RN boilerplates or tutorials using ooth that you know of?

I tried to exaplain this in the documentation, but let me know if something remains unclear:
General ooth-client stuff:
https://nmaro.github.io/ooth/#ooth-client
ooth-local strategy
https://nmaro.github.io/ooth/#client-1
ooth-facebook strategy
https://nmaro.github.io/ooth/#client-2

By the way ooth exposes a pretty simple REST API endpoint that is structured as follows:
POST <ooth>/<strategy>/<method>
and in the body would contain a json of the needed variables. For example
POST /auth/local/register with body
{   "email": "xxx",   "password": "xxx" }

And no, I don't know of any react native library using ooth. I think there is just the need for someone to take the time and share a reference implementation.
In the slack channel there is a channel called #mobile for people like you.


Scrolling isn't sufficiently fluid

The scrolling on the photo search page doesn't behave as expected. I can scroll and the images do not move fluidly up the page, then seem to get 'stuck' as I move the scrolling bar. The result is that it takes a long time to scroll down a long set of images.
This should be more fluid and behave like a 'natural' scroll bar.

@zmchristensen what is going on with this task? I'm assuming that it has taken a back seat with HDR.


router: Make direct response body size configurable

Commit Message: This patch adds max_body_size_bytes to set the maximum bytes of the direct response body size.
Risk Level: Low, since the default behavior is preserved.
Testing: Updated to test the newly introduced config.
Docs Changes: Updated.
Release Notes: Added.
Fixes #13422
Signed-off-by: Dhi Aurrahman<EMAIL_ADDRESS>

I have no strong preference, I can change it to get the value from a specified runtime_key. cc. @envoyproxy/api-shepherds

I have no strong preference, I can change it to get the value from a specified runtime_key. cc. @envoyproxy/api-shepherds

I don't have a strong opinion on whether we make this a full config field or a runtime field. Do we think people will use this limit on a per-route basis or just want a global override? @alyssawilk any thoughts?

@alyssawilk the use-case presented in https://github.com/envoyproxy/envoy/issues/13422 is to make it larger than the current limit.

Fair, same goes for OOM avoidance avoidance :-P  Unless someone asks to configure it per-route, I think we can have one value.

One value is fine to start with. I'd vote to make it part of the API as it makes it possible to reason about limits consistently, e.g. when looking at a config like https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge

Config sounds good. We could put it at the top level of the route config, or possible on the HCM config and wire it through to the route.

@zuercher I would also like this change to be merged, is there anything I can do to help?

@zuercher I would also like this change to be merged, is there anything I can do to help?

@dio can you open a fresh PR and let's get this merged?

@dio can you open a fresh PR and let's get this merged?

Yes, sure. Sorry this was slipped under my radar :(.

Yes, sure. Sorry this was slipped under my radar :(.


Vulnerability roundup 111: nats-server-2.6.0: 1 advisory [8.8]

search, files

[ ] CVE-2022-24450 CVSSv3=8.8 (nixos-21.11)

CVE details
CVE-2022-24450
NATS nats-server before 2.7.2 has Incorrect Access Control. Any authenticated user can obtain the privileges of the System account by misusing the "dynamically provisioned sandbox accounts" feature.

Scanned versions: nixos-21.11: 2128d0aa28e.
Cc @swdunlop

#160521


Spec for ReadWriteOnce in Eirini Persi

Is your feature request related to a problem? Please describe.
ReadWriteMany storageclasses are not always available.
The kube style of one volume per app replica can be useful.
Describe the solution you'd like
There should be a config that allows the user to fallback to ReadWriteOnce, so they can use a StorageClass that doesn't have support for ReadWriteMany.
The plan name or the service name itself should denote the type of storage the user's getting.
Describe alternatives you've considered
Not doing this.
Additional context
#1173

doing this as part of #1173


⚠ ClamAV has degraded performance

In 13bc234, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: ClamAV performance has improved in 7f2a3f4.


Suggestion: gb vendor fetch supports gb repos

Hi! gb is rapidly getting so much awesomer! I <3 the new gb-vendor fetch. The addition of gb-vendor fetch makes gb that much closer to the dreams I was having for gb a week ago but forgot to say anything.
So I'm filing three tickets. Happy to send pull requests but want to discuss first. Ticket 3/3: It makes me super sad that library repos and gb itself can't actually use gb for their public repository (since developers currently want to make things easy for go get). There's this balkanization it seems like where gb is for projects and gb isn't for libraries. Let's change that!
If we're getting rid of go get anyway, why not have gb vendor fetch understand gb repos? Let's say I have a gb repo at http://github.com/jtolds/mygbproject, and so I have a package at http://github.com/jtolds/mygbproject/src/package1. If I run gb vendor fetch github.com/jtolds/mygbproject/package1, I think it should autodetect that mygbproject is a gbproject and download it and put the files in the right places. It could even support https://github.com/constabulary/gb/issues/139 and get the vendored versions from the manifest into my own vendor folder.
That way we could use gb for libraries too?

Downsides: library creators would have different package imports than library users (package2 vs github.com/me/myproject/package2), which would require import rewriting, which definitely ruins submoduling/subfoldering, etc, which were already ruined since the repo paths would have to change too.

I feel like the benefits here might outweigh the costs? Or maybe there's a way to solve them? For instance I know we hate symlinks but go build totally works with symlinks. It's just that "..." doesn't find anything past symlinks, which might be okay for vendored libs?

Orrrr everyone just uses "package1" and there's even more GOPATH entries.
I'll stop thinking in issue comments now

You can totally use gb for libraries. See #49
On Wed, 27 May 2015 02:30 JT Olds<EMAIL_ADDRESS>wrote:

Orrrr everyone just uses "package1" and there's even more GOPATH entries.
I'll stop thinking in issue comments now
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/141#issuecomment-105593603.

Ohhhh sweet I missed that whole conversation. Thanks!

This is my fault for not writing this up as an faq or an example. To close
#49 I have to do that.
On Wed, May 27, 2015 at 10:15 AM, JT Olds<EMAIL_ADDRESS>wrote:

Ohhhh sweet I missed that whole conversation. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/141#issuecomment-105702154.


Catch TypeError Exception

Addresses recent issue where calling Ticker.info would occasionally result in a TypeError Exception at line 287.
Issue:
https://github.com/ranaroussi/yfinance/issues/1395
Fix:
Wrapped key_stats statement  in a Try block and set variable "v" to "None" on Exception.

Read #1084, you need to branch from dev. Look at "Files changed" tab for clue something wrong.
You can salvage this by rebasing your branch to dev. This is easy, find a tutorial, and remember to force push to your fork.

You didn't need to close this, GitHub would have updated.


fix(components): styling adjustment to cards web component

Description
styling fix for cards that are non-interactive
What's included?

using primary card class only when card has ripple affect and is primary action only

Test Steps

[ ] npm run storybbok
[ ] then navigate to the card story
[ ] finally check make sure everything is ok

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

:tada: This PR is included in version 8.14.4 :tada:
The release is available on:

v8.14.4
GitHub release

Your semantic-release bot :package::rocket:


[Nightly Tests] Installation Guide Test needs to be fixed

The script to test the installation guide run_test_installation_docs.sh has some issues that need to be fixed particularly the first one -

It is parsing the index.md incorrectly for the CPU test for build from source. It is running the GPU make steps with the USE_CUDA flag on. Hence this test fails when I run the CPU test on a CPU only instance.
the script expects a sudo in the docs/install/index.md pip install mxnet steps. The test script should be modified so that it runs the install steps with the right permissions or prepends the sudo before running the install steps. The install guide (index.md) should not be modified
This test script requires 3 parameters - name of the install file, and the start and end line numbers. The first paramater should be enough and the remaining two should be calculated by the test script if required.

Not sure if bug is the correct label for this issue.
@mxnet-label-bot Update [Test, Website, Disabled test]


wireguard: add dependency to luci-proto-wireguard

Installing luci-app-wireguard should also install luci-proto-wireguard, to have it as an protocol for interface setup.
Signed-off-by: Sven Roederer<EMAIL_ADDRESS>

Looks sensible to me, but I wonder why that has not surfaces earlier?
@danrl

Please note that this is not a required dependcy! It is perfectly fine to configure the interfaces via CLI  and have luci-app-wireguard as a monitor. There is nothing in luci-app-wireguard that requires or suggests installing luci-proto-wireguard. This decision is left to the user, who ultimately decides how large they want their installation to be.
Although this might serve as a sane default to most use cases, this change is technically not correct. I don't object, I just want to note it is not a great idea IMHO.

Looking more closely at the app, it is really a pure monitor? and not used in the actual wireguard config?
If so, then technically @danrl is right, but from average user's perspective @SvenRoederer has a point. In general, LuCI apps do install the necessary dependencies and possible protocols, so having luci-app-wireguard to install the related stuff including the protocol helper for LuCI is normal.
I wonder if I should revert this or not, as I semi-accidentally merged it while writing the first note to danrl.

Since there is no "RECOMMENDED:=" that I know of, we sometimes have to make these choices: Include a recommended package or not.
We can leave if as it is. Makes sense for most users I guess and is of little annoyance maybe to the very few who use LuCI mostly for looking at configs, but not changing them. E.g. auto-provisioned systems or what not.
Again, I am not objecting.


reset approvals button now shows snackbar with status and message, an…

…d reloads approvals
Reset approvals success notification:

Reset approvals error notification:

Supplanted by #196


Office staff update

closes #15

@utkarsh-tf141 This is not the kind of link we use in emails, mailto: has to be used. Also, don't put any HTML content inside objects. Render the emails inside anchor tags inside the Description tag.


Windows Server Winet Install

Add Winget to WIndows Server - Likely in the Tweaks Section is where I'd recommend it.
Add something similar to this: https://gist.githubusercontent.com/likamrat/cae833a6e5b3461709f14c093c21c293/raw/ce5a3210262b9a82626b0553e1fcefd809f52ea6/WinGet_WinSrv.ps1
It works well, haven't encountered issues on 2019, 2022, or Preview versions.
It would be useful because by default, Windows Server doesn't support the same "Desktop Experience" that Windows Home/Pro or even LTSC do.

Dig the addition, My current script goes off of PS version 7 and this would be a good detection for switching how winget is installed.
I will also be changing the following: Get-WmiObject is deprecated in powershell core and it should be replaced with Get-CimInstance in case user opened the utility/script from core.


update doctor changes

This PR:

updates documents for new doctor command findBrokenLinks

related: dendronhq/dendron#1718, dendronhq/dendron#1847


fix: mark customEventHandlers as optional

Description
Sorry, my PR above generates a new error as we define a default value for customEventHandlers but at the same time it is marked as required.
Since it has a default value it does not need to be required.
So the error is easily fixed
Related error:
Warning: Failed prop type: The prop `customEventHandlers` is marked as required in `AdvertisingSlot`, but its value is `undefined`.
    at AdvertisingSlot (/node_modules/react-advertising/lib/components/AdvertisingSlot.js:37:17)

:tada: This PR is included in version 4.2.13 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Node HTTP Request adapter with Request js lib ECONNREFUSED Issue

@yasinuslu or @offirgolan did you ever test a POST request using https://github.com/request/request, i get Error: connect ECONNREFUSED <IP_ADDRESS>:4000 even though polly responds with Replayed ➞ POST http://localhost:4000/
Not sure what logs would be more use full for you guys ?
Will post if i make any progress on this. Thanks

@timpur any more info on this?

@offirgolan https://github.com/timpur/bug-pollyjs-node just run npm test
Hope you guys can solve :)

@timpur I was not able to recreate your issue with the steps taken below:

Clone repo
Bump all @pollyjs dependencies to latest
Run npm test --> Recorded ➞ GET https://reqres.in/api/users 200 • 70ms
Run npm test --> Replayed ➞ GET https://reqres.in/api/users 200 • 2ms
Disconnect from internet
Run npm test --> Replayed ➞ GET https://reqres.in/api/users 200 • 2ms

Version 2.0.0+ of the node-http adapter has a completely new implementation than its predecessor so thats where I suspect the issue is coming from. My suggestion is to upgrade all your @pollyjs packages which should solve your issue.

@offirgolan thanks, will confirm and get back to you :)

Confirmed
All works as expected :)


Added support for AzureResourceManager template

Adding Azure template for Artifactory HA installation.

Updated README of root with Azure information.


[SPARK-17729] [SQL] Enable creating hive bucketed tables

What changes were proposed in this pull request?
Hive allows inserting data to bucketed table without guaranteeing bucketed and sorted-ness based on these two configs : hive.enforce.bucketing and hive.enforce.sorting.
What does this PR achieve ?

Spark will disallow users from writing outputs to hive bucketed tables by default (given that output won't adhere with Hive's semantics).
IF user still wants to write to hive bucketed table, the only resort is to use hive.enforce.bucketing=false and hive.enforce.sorting=false which means user does NOT care about bucketing guarantees.

Changes done in this PR:

Extract table's bucketing information in HiveClientImpl
While writing table info to metastore, HiveClientImpl now populates the bucketing information in the hive Table object
InsertIntoHiveTable allows inserts to bucketed table only if both hive.enforce.bucketing and hive.enforce.sorting are false

Ability to create bucketed tables will enable adding test cases to Spark while I add more changes related to hive bucketing support. Design doc for hive hive bucketing support : https://docs.google.com/document/d/1a8IDh23RAkrkg9YYAeO51F4aGO8-xAlupKwdshve2fc/edit#
How was this patch tested?

Added test for creating bucketed and sorted table.
Added test to ensure that INSERTs fail if strict bucket / sort is enforced
Added test to ensure that INSERTs can go through if strict bucket / sort is NOT enforced
Added test to validate that bucketing information shows up in output of DESC FORMATTED
Added test to ensure that SHOW CREATE TABLE works for hive bucketed tables

Test build #75829 has started for PR 17644 at commit 0348a96.

Test build #75829 has finished for PR 17644 at commit 0348a96.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75829/
Test FAILed.

Merged build finished. Test FAILed.

Test build #75838 has started for PR 17644 at commit fc04991.

Test build #75838 has finished for PR 17644 at commit fc04991.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75838/
Test PASSed.

cc @cloud-fan @hvanhovell @sameeragarwal for review

I'll review it after branch 2.2 is cut

Test build #76298 has started for PR 17644 at commit 1b78141.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76298/
Test FAILed.

Jenkins test this please

Test build #76312 has started for PR 17644 at commit 1b78141.

Test build #76312 has finished for PR 17644 at commit 1b78141.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76312/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan : ping !!

A high-level question: if we propagate the bucketing information of a hive table, can we correctly read this table with Spark SQL? Shall we have a config to change Spark's shuffle hash function to use hive hash?

@cloud-fan : Thanks for reviewing !!

if we propagate the bucketing information of a hive table, can we correctly read this table with Spark SQL?

With this PR, HiveTableScanExec still doesn't advertise the table to be bucketed so optimizer wont treat the data as bucketed. tldr: It would be read just like a regular table (as it happens now in trunk).

Shall we have a config to change Spark's shuffle hash function to use hive hash?

Yeah. We need to add that but I will do that in a separate PR. I had a PR from last year but given that there are many changes in SQL land, I couldn't rebase it. Am working on creating a new PR instead after studying the new changes since last year.

Test build #76460 has started for PR 17644 at commit e3c41bf.

Jenkins test this please

Test build #76462 has started for PR 17644 at commit 6e6e767.

Test build #76462 has finished for PR 17644 at commit 6e6e767.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76462/
Test PASSed.

Test build #76460 has finished for PR 17644 at commit e3c41bf.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76460/
Test PASSed.

Build finished. Test PASSed.

Jenkins test this please

Test build #76506 has started for PR 17644 at commit 6e6e767.

Test build #76506 has finished for PR 17644 at commit 6e6e767.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76506/
Test FAILed.

Jenkins test this please

Test build #76515 has started for PR 17644 at commit 6e6e767.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76515/
Test FAILed.

Jenkins test this please

Test build #76529 has started for PR 17644 at commit 6e6e767.

Test build #76529 has finished for PR 17644 at commit 6e6e767.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76529/
Test PASSed.

Test build #76588 has started for PR 17644 at commit ab12943.

Test build #76588 has finished for PR 17644 at commit ab12943.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76588/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins test this please

Test build #76595 has started for PR 17644 at commit 7a0be86.

Test build #76595 has finished for PR 17644 at commit 7a0be86.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76595/
Test FAILed.

Test build #76613 has started for PR 17644 at commit 49040e8.

Test build #76613 has finished for PR 17644 at commit 49040e8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76613/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #76676 has started for PR 17644 at commit 49040e8.

Test build #76676 has finished for PR 17644 at commit 49040e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76676/
Test PASSed.

Test build #76703 has started for PR 17644 at commit 8aaff4c.

Test build #76703 has finished for PR 17644 at commit 8aaff4c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76703/
Test FAILed.

Test build #76758 has started for PR 17644 at commit c7b6260.

Test build #76758 has finished for PR 17644 at commit c7b6260.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76758/
Test FAILed.

Test build #76767 has started for PR 17644 at commit fc9d94f.

Test build #76767 has finished for PR 17644 at commit fc9d94f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76767/
Test PASSed.

Merged build finished. Test PASSed.

Test build #76815 has started for PR 17644 at commit d01c721.

Test build #76815 has finished for PR 17644 at commit d01c721.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76815/
Test PASSed.

Test build #76852 has started for PR 17644 at commit 239beee.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76852/
Test FAILed.

retest this please.

Test build #76860 has started for PR 17644 at commit 239beee.

Test build #76860 has finished for PR 17644 at commit 239beee.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76860/
Test FAILed.

Test build #76882 has started for PR 17644 at commit 10a9fd0.

Test build #76882 has finished for PR 17644 at commit 10a9fd0.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76882/
Test PASSed.

Build finished. Test PASSed.

Test build #76884 has started for PR 17644 at commit d6ce8b5.

Test build #76887 has started for PR 17644 at commit 0aa8539.

Test build #76884 has finished for PR 17644 at commit d6ce8b5.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76884/
Test PASSed.

Test build #76887 has finished for PR 17644 at commit 0aa8539.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76887/
Test PASSed.

Test build #76909 has started for PR 17644 at commit efc8c8b.

Test build #76910 has started for PR 17644 at commit bf306da.

Test build #76909 has finished for PR 17644 at commit efc8c8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76909/
Test PASSed.

Test build #76910 has finished for PR 17644 at commit bf306da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76910/
Test PASSed.

LGTM except 2 comments

Test build #76941 has started for PR 17644 at commit 865711f.

Test build #76941 has finished for PR 17644 at commit 865711f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76941/
Test PASSed.

thanks, merging to master!


Add ddoc example to isImplicitlyConvertible

LGTM

@burner fixed

that was fast

Auto-merge toggled on

Thanks!

thank you


Feature Request: Add ability to rename editor tabs

SQL Operations Studio Version: 0.26.7

Steps to Reproduce:
The default name for any new query tab is SQLQuery1, SQLQuery2 etc.  This provides no useful information.  When you are editing many queries it is difficult to find the editor you need. Allow the user to right click the tab name and enter descriptive text.  It would also be nice if common operations like Altering a stored proc put the name of the procedure in the tab by default.

Please review issue https://github.com/Microsoft/sqlopsstudio/issues/956 when resolving this issue since it appears to mostly overlap, but has a couple additional comments not captured above (e.g. icon colors and keyboard shortcuts).

still open? becaue of these very simple but very handy features missing i miss SSMS... Please make our lives as data analyst/developer easier...

2024 still open...

This would be one of my most used features in ADS for sure.

Please do, do, do work on this feature!

+1

+1

+1

+1

I came across a setting yesterday which I believe resolves this request.  It's is labelled 'Untitled: Label Format' and appears towards the bottom of Workbench > Editor Management section.  I changed this to content and the tab label changes to the first line of the editor window.  Hope this is what you are all looking for.

+1


Update the subscription models to align on CAMARA commonalities

What type of PR is this?
Add one of the following kinds:

correction
enhancement/feature

What this PR does / why we need it:
Update of the subscription-models based on:

https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#12-subscription-notification--event
https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml

Which issue(s) this PR fixes:
Fixes #162

The base url should be with apiName, so 'device-' is missing..  (I can't comment there directly)

As per today discussion over subscription response, would apprecaite if we can include examples in specification that pointed in discussion

@maxl2287 I have a second thought about making the device identifier optional in the subscription.
My point is the following:
For the POST that's fine to not have this device identifier as we have it thru the access token.
But, when the developer check the subscription 10 days later, in the GET /subscriptions response better to have this device identifier present because without it impossible to know what device is targeted....
So... either 1/ we keep the device mandatory or 2/we make it optionnal for the POST request but mandatory in the GET response
I prefer 1/ but perhaps we can have other solution.
cc: @fernandopradocabrillo

@maxl2287 I have a second thought about making the device identifier optional in the subscription. My point is the following: For the POST that's fine to not have this device identifier as we have it thru the access token.
But, when the developer check the subscription 10 days later, in the GET /subscriptions response better to have this device identifier present because without it impossible to know what device is targeted....
So... either 1/ we keep the device mandatory or 2/we make it optionnal for the POST request but mandatory in the GET response
I prefer 1/ but perhaps we can have other solution.
cc: @fernandopradocabrillo

Are you talking about https://github.com/camaraproject/DeviceStatus/issues/173 ?

As per today discussion over subscription response, would apprecaite if we can include examples in specification that pointed in discussion

@sachinvodafone I have added three examples for GET /subscriptions/{subscriptionId} pointing to specific status of the subscription.

As per today discussion over subscription response, would apprecaite if we can include examples in specification that pointed in discussion

@sachinvodafone I have added three examples for GET /subscriptions/{subscriptionId} pointing to specific status of the subscription.

Thanks @maxl2287 , Can we get an example for "GET /subscriptions" where we provide only the subscriptionID for subscriptions with incomplete asynchronous calls and show the full response for the others (synchronous)?

Thanks @maxl2287 , Can we get an example for "GET /subscriptions" where we provide only the subscriptionID for subscriptions with incomplete asynchronous calls and show the full response for the others (synchronous)?

@sachinvodafone
However, this will not align with the specified response for GET /subscriptions.
The response for this endpoint includes a list of only having Subscription components.
There should not be a mix of Subscription objects and subscriptionId values within the same list.

@maxl2287 I have a second thought about making the device identifier optional in the subscription. My point is the following: For the POST that's fine to not have this device identifier as we have it thru the access token.
But, when the developer check the subscription 10 days later, in the GET /subscriptions response better to have this device identifier present because without it impossible to know what device is targeted....
So... either 1/ we keep the device mandatory or 2/we make it optionnal for the POST request but mandatory in the GET response
I prefer 1/ but perhaps we can have other solution.
cc: @fernandopradocabrillo

@bigludo7 I aggree also on letting it mandatory here.

I suggest we do this way - let keep it mandatory. If in future we shift to optional this is not a breaking change.

Thanks @maxl2287 , Can we get an example for "GET /subscriptions" where we provide only the subscriptionID for subscriptions with incomplete asynchronous calls and show the full response for the others (synchronous)?

@sachinvodafone However, this will not align with the specified response for GET /subscriptions. The response for this endpoint includes a list of only having Subscription components.
There should not be a mix of Subscription objects and subscriptionId values within the same list.

@maxl2287 I understand your point that it will only include those subscriptions that have already been created. Thank you.

Thanks @maxl2287 , Can we get an example for "GET /subscriptions" where we provide only the subscriptionID for subscriptions with incomplete asynchronous calls and show the full response for the others (synchronous)?

@sachinvodafone However, this will not align with the specified response for GET /subscriptions. The response for this endpoint includes a list of only having Subscription components.
There should not be a mix of Subscription objects and subscriptionId values within the same list.

@maxl2287 I understand your point that it will only include those subscriptions that have already been created. Thank you.

@sachinvodafone yes, but to be more precise:
The list includes every subscription, which was created by the user, even those which are still in the creation process (see status ACTIVATION_REQUESTED).

Thanks @maxl2287 , Can we get an example for "GET /subscriptions" where we provide only the subscriptionID for subscriptions with incomplete asynchronous calls and show the full response for the others (synchronous)?

@sachinvodafone However, this will not align with the specified response for GET /subscriptions. The response for this endpoint includes a list of only having Subscription components.
There should not be a mix of Subscription objects and subscriptionId values within the same list.

@maxl2287 I understand your point that it will only include those subscriptions that have already been created. Thank you.

@sachinvodafone yes, but to be more precise: The list includes every subscription, which was created by the user, even those which are still in the creation process (see status ACTIVATION_REQUESTED).

Suppose if we have only one subscription and that is asynchronous which still not completed, in this case ,we will get "ACTIVATION_REQUESTED"  if user try for "GET /Subscriptions" . If Yes, then I am having another question.

Suppose if we have only one subscription and that is asynchronous which still not completed, in this case ,we will get "ACTIVATION_REQUESTED" if user try for "GET /Subscriptions" . If Yes, then I am having another question.

You will receive something like:
[
  {
    "sink": "https://endpoint.example.com/sink",
    "sinkCredential": {},
    "types": [
      "string"
    ],
    "config": {
      "subscriptionDetail": {
        "device": {
          "phoneNumber": "+123456789",
          "networkAccessIdentifier"<EMAIL_ADDRESS>          "ipv4Address": {
            "publicAddress": "<IP_ADDRESS>",
            "publicPort": 59765
          },
          "ipv6Address": "2001:db8:85a3:8d3:1319:8a2e:370:7344"
        }
      },
      "subscriptionExpireTime": "2023-01-17T13:18:23.682Z",
      "subscriptionMaxEvents": 5,
      "initialEvent": true
    },
    "id": "550e8400-e29b-41d4-a716-446655440000",
    "startsAt": "2024-07-04T11:44:36.664Z",
    "expiresAt": "2024-07-04T11:44:36.664Z",
    "status": "ACTIVATION_REQUESTED"
  }
]

Suppose if we have only one subscription and that is asynchronous which still not completed, in this case ,we will get "ACTIVATION_REQUESTED" if user try for "GET /Subscriptions" . If Yes, then I am having another question.

You will receive something like:
[
  {
    "sink": "https://endpoint.example.com/sink",
    "sinkCredential": {},
    "types": [
      "string"
    ],
    "config": {
      "subscriptionDetail": {
        "device": {
          "phoneNumber": "+123456789",
          "networkAccessIdentifier"<EMAIL_ADDRESS>          "ipv4Address": {
            "publicAddress": "<IP_ADDRESS>",
            "publicPort": 59765
          },
          "ipv6Address": "2001:db8:85a3:8d3:1319:8a2e:370:7344"
        }
      },
      "subscriptionExpireTime": "2023-01-17T13:18:23.682Z",
      "subscriptionMaxEvents": 5,
      "initialEvent": true
    },
    "id": "550e8400-e29b-41d4-a716-446655440000",
    "startsAt": "2024-07-04T11:44:36.664Z",
    "expiresAt": "2024-07-04T11:44:36.664Z",
    "status": "ACTIVATION_REQUESTED"
  }
]

I have updated the scenario in discussion board here

@bigludo7 can we do here a final review?
I just have added some examples based on @sachinvodafone's feedback.

@bigludo7 can we do here a final review? I just have added some examples based on @sachinvodafone's feedback.

Thanks @maxl2287 - Look good for me. Let's get final review from @sachinvodafone and @akoshunyadi and we're good to go.

@sachinvodafone it is ok for you now? Looking for you thumb up to merge :)
Thanks


Update Korean translation

I filled in the missing parts, and I used more concise expressions throughout the translation to improve the consistency of terms.

Thank you for offering this pull request @ististudio.
I used Google translate on a few of the terms that have been changed, translating both the old text and the new text, and to be totally honest, the translation of the old text seemed to often match the original English intent.
On the translations that you have altered, Are the previous translations wrong in any way or is it a matter of preference or style? Sorry to be questioning this but it's just a little tricky to understand the changes without any knowledge of the language itself.

Some are by preference, some are about orthography. Unlike English, Korean tends to delete subjects. In particular, repeating a subject can sound awkward for Korean readers. I removed the subject if I could see it from the context. e.g. 'email_confirm_success' => 'Authentication succeeded!'
Failure to distinguish "문서 만들기" from "문서 만듦" is a mistake in Google translation. Because "-ᄆ" adds meaning to the present completion, the latter means "The document has now been created." In addition, passive expressions that don't suit the Korean language have been changed to active expressions.
Anyway, I tried not to lose any information in given the context compared to the previous translation.

I think that some part of this commit is weird.
I'm not sure that using noun is proper for notification.
'페이지를 만들었습니다.' is more familiar(?) to me than '문서 만듦'.
and how many people can understand '장철'?

Thank you for your opinion, @hhk7734.
I used sentences ending in a noun only in activity.php for notifications. These expressions will be used in the box that is displayed in the following screenshot.

It disappears in a few seconds. Because of that, I wanted people to read this at once and I used as few characters as possible. These uses themselves are not so unfamiliar in my book. I have also seen them on the Android OS from time to time.
I've seen "장, 절, 장절" being used in TeX, and I thought it was fine. But I agree that these terms look old. I'll change the term "장절" to "챕터" and "서적" to "책자".
If there are any other weird parts you think, I'd appreciate it if you let me know more.

@ististudio
I didn't know when the variable is used. After reading your explanation, I became to understand why you write that.
Others look fine.

Thanks @hhk7734 for giving these a look and thanks again @ististudio for offering these updates.
Will merge now to be part of the next release.


Export raw validator function

Raw validator function can be used for type guard
I want to use multiple validators for type guard
example:
if(rawValidatorForType1(data)){
// do something for Type1
}
else if(rawValidatorForType2(data)){
// do something for Type2
}
And I prefer to use raw validator which does not throw exception for invalid input.

That will be even better:-)
Actually, I have one more idea.
Can we add optional boolean parameter "throwsOnError" to the is${typeName} method?
My usecase
if(isTypeA(data)){
// do something for typeA
}
else if(isTypeB(data)){
// do something for typeB
}
else if(isTypeC(data,true)){
// do something for typeC
// There're no other cases since it throws error on validation failure
}

I think I can just add another function
export function isTypeA(data: unknown, throwsOnError:boolean = false): data is TypeA {
  if (rawValidateTypeA(data)) {
    return true;
  } else {
    if(!throwsOnError){
      return false
    }
    throw new Error(
        ajv.errorsText(rawValidateTypeA.errors, {
          dataVar: "NTEResponseLattice"
        }) +
        "\n\n" +
        inspect(value)
    );
  }
}

I will try to update the pull req when I have spare time. (within 24h)

I had to increase jest test timeout because build-parameters.test.ts fails all the time.

I have cleaned up commits.
I have increased jest test timeout again to pass unit tests.
I believe my change does not affect test time though...

Any feedback?
The pull req is marked as Changes requested, but the request is not valid anymore.
Do I need to create another clean pull req?

I can do nothing about the change request.
Do you want me to recreate the pull req?

Thanks for your patience with this pull request. I think it's a really valuable addition, I've just been struggling to keep up with all the open source stuff lately. This should be automatically released by CI shortly.

:tada: This PR is included in version 2.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Glad that I can help, and thank you for creating such a useful library :-)
TypeScript is not good at handling unknown input, and the library filled the missing piece!!

Thanks. I've added you as a collaborator to this repo in case you're interested in helping out. Please don't merge your own PRs until approved, but feel free to review/approve/merge other people's PRs. In order to trigger a release, the title of the commit title when you squash and merge must start with feat:  or fix:  and to trigger a major version, you use BREAKING CHANGE: <explanation of the breaking change> in the body of the commit message.


basic metadata extraction from ISO, FGDC, and MODS

This implements metadata extraction using fixtures from test-data/
Fixes #38
This PR is ready now. Please review.

Not sure I follow the indexing, and at what level (whole model, each for the possible 3 works types, or per file,etc.)

Nevermind I answered the question I had about the indexing.  But still unclear about what part or parts or whole of the model gets exposed at search.

Fantastic @drh-stanford.  My only concern relates to the cases in which the extraction of metadata might be mapped to multiple File resources returned from #metadata_files (this is the concern voiced by @yulgit1 relating to multiple metadata files).  I've also offered a potential point of improvement, but this is quite trivial (and may not be ideal).

yes, the multiple metadata files is marked as a TODO in the code. i think we can assume that we have one external metadata file for now (i.e., this sprint), but we will need to address this later on. i can put in an assertion if there are multiple metadata files that it's NotImplementedError.

re: metadata model. for this sprint i chose to extract title, bbox, creator as the trial fields. this was based on the required fields we inherited from curation concerns. we will need to be more exact about which properties should/need to be extracted and implement those across the metadata standards when possible.

i've added the metadata extraction to ImageWork and RasterWork, so for all of the works, you can call .extract_metadata and it will populate the properties from the ExternalMetadataFile. I'm also throwing an exception if there's more than one ExternalMetadataFile if the extraction is called.

is this ready to go now?

:+1:

Looks good to me.

Nice metaprogramming @drh-stanford. Two thumbs. :+1: :+1:


android export : apk not signed

Godot version
3.4.4-stable
System information
Windows10
Issue description
when use stable-template apk to export debug apk, apk is not singed
I have setup android sdk and openjdk11.
and tried write debug.keystore in export panel
look this

Steps to reproduce
when use stable-template apk to export debug apk, apk is not singed
I have setup android sdk and openjdk11.
and tried write debug.keystore in export panel
Minimal reproduction project
export-3.4.4-android-bug.zip

Go to apksigner.bat in SDK and append to start of file this:
@echo %* >> C:\Users\<your user>\apksigner_run.txt

Export again
Write in console
type C:\Users\<your user>\apksigner_run.txt

Write in console
cd "<path_to_apksigner_dir>"
apksigner <result of previous command>

Then write here results of commands

I have modfiy the apksigner.bat , But I can't find apksigner_run.txt

maybe apksigner.bat is not been called?

if I use apksigner.bat outside godot.
This apk is signed.

F:
cd sdk\build-tools\30.0.3
apksigner.bat sign --ks E:\debug.keystore --ks-key-alias androiddebugkey --ks-pass pass:android D:\Desktop\work\export-3.4.4-android-bug\debug.apk
pause

If you can't find D:\apksigner_run.txt and apk signed when command runned in cmd, specify correct SDK path in Godot settings. Godot didn't call modified apksigner.bat, THIS should be problem. Did D:\apksigner_run.txt appeared after cmd run?

I think it is right

Did D:\apksigner_run.txt appear after cmd run and do you use debug.keystore (didn't rewrite in project export settings)?
Last question. Have you another version of build-tools (except 30.0.3)?

If you can't find D:\apksigner_run.txt and apk signed when command runned in cmd, specify correct SDK path in Godot settings. Godot didn't call modified apksigner.bat, THIS should be problem. Did D:\apksigner_run.txt appear after cmd run?

Hi I found the apksigner_run.txt
But I think it is written when I use cmd to call it
apksigner_run.txt

Did D:\apksigner_run.txt appear after cmd run and do you use debug.keystore (didn't rewrite in project export settings)?
Last question. Have you another version of build-tools (except 30.0.3)?

Yes I have some different build-tools.

Move all versions, except 30.0.3 to other directory or delete, before exporting in Godot.
If you need to use this versions for another application, generate new SDK and leave this for Godot (with 1 version of build-tools - 30.0.3)

thanks .

I remember old verisons of godot can call apksinger , and I put build-tools (different version) together .

If it works, please close this issue


Disable vibration on toggle select

Is it possible to create a function to toggle vibrate: true/false on a toggle select? I read the docs but could not find it.

The same way with a toggle select, is it possible to stop receiving push notifications? Should I use push.unregister() ?

Thanks in advance.

Sorry to be a jerk but I'm now closing issues that don't follow the issue submission guidelines. This plugin takes a lot of work to maintain and I can't afford the time required to solicit the required info from everyone.
I'm closing this issue but please feel free to re-open the issue if you provide the requested details from the new issue submission guidelines.
https://github.com/phonegap/phonegap-plugin-push/blob/master/.github/ISSUE_TEMPLATE.md


No message available for path: /updateUserSettings

I tried to sync my settings from browser to account, but encountered with 404 error "No message available for path: /updateUserSettings". This also happens when sync opposite direction.

Synology container manager environment. Mapped configs folder and tessdata.
Using login feature.
All other things are working fine, like account management, user settings, PDF functions...

in 0.17.0 !


Unable to use dgca-app-core-android on Android 7 (24) devices

Hi,
I integrated your dgci-app-core-android library in my app which is minsdk 24 (Android 7).
Your decoder is working fine except on Android 7 devices.
What is the reason that your libraries minSDK is 26?
Is there a way to make it work for SDK 24 (Android 7) devices?
Thanks or your feedback!
Best regards
Robert

You use Java 8 time api which is available since api 26.
You could use time api on api < 26 by following the steps in this artice: https://tunesoftware.com/apps/java-8-date-time-classes-in-android-below-api-26/
Don't know if this interests you somehow :)

I month ago try to use Android 7.0, 24 API level, it fine working, expect one thing. Java time API can be fixed over "deshugaring" gradle plugin. But Kotlin reflection API not work correct.
So you need enable, some like, in dependences app level:
coreLibraryDesugaring Deps.desugar_jdk_libs
and in Versions.kt:
const val desugar_jdk_libs = "1.1.5"
and dependences.kt:
const val desugar_jdk_libs = "com.android.tools:desugar_jdk_libs:${Versions.desugar_jdk_libs}"
then instead of ZonedDateTime when running on API 24 it will convert it to DateTime.
One more thing if i remember correct... it is, in file dgc-certlogic-android/engine/src/main/java/dgca/verifier/app/engine/data/ExternalParameter.kt
class ExternalParameter private constructor(
    val validationClock: String,
    val valueSets: Map<String, List<String>>,
    val countryCode: String,
    val exp: String,
    val iat: String,
    val issuerCountryCode: String,
    val kid: String,
    val region: String = ""
) {
    companion object {
        fun createInstance(
            validationClock: ZonedDateTime,
            valueSets: Map<String, List<String>>,
            countryCode: String,
            exp: ZonedDateTime,
            iat: ZonedDateTime,
            issuerCountryCode: String,
            kid: String,
            region: String = ""
        ):ExternalParameter{
            return ExternalParameter(
                validationClock = DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(validationClock),
                valueSets = valueSets,
                countryCode = countryCode,
                exp = exp.withZoneSameInstant(UTC_ZONE_ID).toLocalDate().toString(),
                iat = iat.withZoneSameInstant(UTC_ZONE_ID).toLocalDate().toString(),
                issuerCountryCode = issuerCountryCode,
                kid = kid,
                region = region
            )
        }
    }
}

And create it over factory. The problem was that it did not find the constructor, it tried to look for the constructor with ZonedDateTime and in fact, during the desugaring process, it was replaced with DateTime. Although... I can't now repeat this issue on a device with API level 25, and Android 7.1 right now.
Also has problem with:
@dimen/default_padding
It request level 28, so it need remove....


yi-fuzzy-open build failure

Ping @ethercrow
[1 of 1] Compiling Yi.Fuzzy         ( src/Yi/Fuzzy.hs, dist/build/Yi/Fuzzy.o )

src/Yi/Fuzzy.hs:84:9:
    Non type-variable argument
      in the constraint: Data.String.IsString [a]
    (Use FlexibleContexts to permit this)
    When checking that ‘predicate’ has the inferred type
      predicate :: forall a.
                   (Eq a, Data.String.IsString [a]) =>
                   [a] -> Bool
    In the expression:
      do { names <- getDirectoryContents topdir;
           let properNames = filter predicate names
               predicate fileName = and ...;
           paths <- forM properNames $ \ name -> do { ... };
           return (concat paths) }
    In an equation for ‘getRecursiveContents’:
        getRecursiveContents topdir
          = do { names <- getDirectoryContents topdir;
                 let properNames = ...
                     ....;
                 paths <- forM properNames $ \ name -> ...;
                 .... }

This looks like a typical issue with migrating from ghc 7.8 to 7.10. It should be easy to remedy, either by using the FlexibleContexts pragma, or by providing an explicit type signature for predicate :: [String] -> Bool.

That was already fixed in version <IP_ADDRESS>, which was not released on hackage for some reason. I've just uploaded it, should be fine now.

:+1:


NSTextView port throws error: invalid numeric value to CoreGraphics

When port this lib into NSTextView, using Swift 3.0, as below:
https://github.com/futurist/cutecmd-mac/blob/4486b868cf057713704566deb304a79609632d30/cutecmd-mac/AutoCompleteTextField.swift
I have a bug reported as below:

Nov 23 08:22:25  cutecmd-mac[6516] : Error: this application, or a library it uses, has passed an invalid numeric value (NaN, or not-a-number) to CoreGraphics API and this value is being ignored.Please fix this problem.

This happens when the self.getCompletionArray returned a complete different array as before.
I've googled and told that it's due to NSPopover, but I'm not sure.
To reproduce it, download and run the repo, input
s (will popup Safari etc.)
Backspace (clear the input)
q (this will throw above error)
Xcode 8, macOS  10.11.6
What's going on? help needed for the port into NSTextView

@futurist  in macOS 10.12 Xcode8.0, I can't reproduce the problem

Don't know why, but will appear every time here

Using building completion popup (F5), there's no any error, but it's weak...

The Swift 3.0 update also have this problem in my mac:

I've moved the popover.contentSize calculation into a delegate method (popoverWillShow), and the problem gone here.
https://github.com/futurist/cutecmd-mac/commit/c8f5565fd3f7c65ce15c63e6c7ae559795e35dee#diff-cedb50a79b0833adf206a909638564aaR208

@futurist thanks for your effort.  Would you mind pulling the requests?

If you using javascript, maybe you can check my lib:
https://github.com/cssobj/cssobj
Welcome to give a star! 😄


Add Test Folder to the Type List

Hi Kyle,
Could we add Test Folder to the Type list?
Thanks!
michiko

Seems like we should be able to, since there are already other non-artifact types in there.  TestFolder doesn't really have all that many useful fields to chart on though... What's the usecase?


⚠ Thumbnails API Endpoint has degraded performance

In 09ba53d, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 4207 ms

Resolved: Thumbnails API Endpoint performance has improved in e694985.


Support all services types in the curl subcommand

Required authentication is chosen based on which service is accessed, and if
you have Auth0 or api-key available.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@mpolden - Please take a look at the latest diff. Based on our discussion yesterday I think this follow the simple wrapper idea you had for the curl subcommand.
@oyving - FYI, this should could you the the functionality you asked for.


each output mesh has different vertex ID's

Just came across this issue while I was blending different results in Maya,
vertex count is the same in each mesh and thats expected,
but vertex order is totally different so I had to reorder vertices and transfer VID to other meshes.
Is it possible to get same vertex id's everytime?

This is caused by Trimesh. If we change the process flag to false, it should be the same every time.

This is caused by Trimesh. If we change the process flag to false, it should be the same every time.

This saved a lot of time, thanks


encoding/binary: clarify when ByteOrder can be nil

Proposal Details
this panics as expected:
package main

import (
   "bytes"
   "encoding/binary"
)

func main() {
   r := bytes.NewReader([]byte{1,2})
   var i int16
   binary.Read(r, nil, &i)
}

but this does not:
var i int8
binary.Read(r, nil, &i)

I think the docs should reflect that ByteOrder can be nil if the integer width is one byte.
https://godocs.io/encoding/binary#Read

This does not need to go through the proposal process, feel free to send a CL.

I think the docs should reflect that ByteOrder can be nil if the integer width is one byte.

I'd say it should panic on nil ByteOrder for consistency

I think the docs should reflect that ByteOrder can be nil if the integer width is one byte.

The current documentation says: “Bytes read from r are decoded using the specified byte order and written to successive fields of the data.” To me that does not allow for the ByteOrder to be nil: it says “are decoded” (not “may be decoded”) and “the specified byte order” (not “the specified byte order, if any”).

I'd say it should panic on nil ByteOrder for consistency

In my experience, it is pretty much always a mistake for documentation to promise to panic if an invalid argument is used, because that prevents future changes that give defined behavior to previously-invalid arguments.
If anything, perhaps we should clarify as: “… decoded using the specified byte order, which must be non-nil, and written …”.

I agree with @bcmills - I would prefer nil to be explicitly allowed in some cases, but failing that, documenting that nil must not be used is a good option as well

Adding nil check for int8 case impacts performance by -10%


No "Magento" menu item

I installed trytond-magento module from "develop" branch on Tryton 3.9.0 (I made some PYSON fixes). Module installed successfully. But no menu item "Magento" appears in main menu. If use branch 3.4.1 of trytond-magento then menu item "Magento" appears. Because branch 3.4.1 has file magento.xml which has "menuitem" tag. Develop branch has no "menuitem" tag in any file. So, how are you using trytond-magento?

Current design is based on sale channel.
Refer: https://github.com/fulfilio/trytond-sale-channel


what does radius represent?

In set abstraction layer, there is a config named RADIUS
 RADIUS: [[0.1, 0.5], [0.5, 1.0], [1.0, 2.0], [2.0, 4.0]]
It means Euclidean distance? or a ratio of the number of point(e.g. 0.1*4096)？

This is used in
pointnet2/pointnet2_utils.py, in the init function of class QueryAndGroup(nn.Module):
param radius: float, radius of ball
So it is indeed Euclidean radius.
(Sorry I know t is an old question, but may be useful for others)


Fixed existing test suites, reworked login tests, added more testing for login page with selenium

Changes made:

Mainly reworked test cases test_login.py—alongside a couple of small parameters/variable changes in test_authentication_flow.py, test_registration.py, and test_models.py—in order to keep up-to-date with current backend python files.

Restructured test_login.py to use pytest, rather than the old unittest class approach. I did this mainly because the original test file wasn't formatted to allow pytest to detect and run it as using unittest, and running the file by itself resulted in some annoying module errors. While the tests' end goals have largely remained the same, various HTTP request calls and test implementations/asserts had to be changed, since the original tests either raised errors or weren't implemented correctly as per their original testing goals. The original test_login.py file has been renamed to test_login_old.py and still remains within the ./tests folder for any future needs/reference (pytest won't detect it anyways).

Added two simple tests in test_login.py, focused on testing the static HTML elements within the login page. These closely mirror the HTML element tests in test_registration.py, and may be expanded in the future to include more similar tests if needed.

Added in a new testing module test_login_selenium.py focused on testing the dynamic behaviour of front-end elements on the login page (e.g. errors popping up when an incorrect login attempt is made, submit buttons being unavailable without certain prerequisites being fulfilled, etc.).
These tests make use of the Python selenium and webdriver-manager libraries to create an automated, headless (invisible) Chrome browser, allowing typical user interactions to be simulated and tested (like a user navigating through pages, filling out a form, clicking various page elements, and more). With the continued use of these libraries, future front-end unit tests will not be limited to only testing the initial appearance of webpages, but can also check how they change based off of possible user actions over time.

Updated requirements.txt with selenium and webdriver-manager libraries (another quick pip install needed)

Issues:

From my experience, test_authentication_flow.py throws an PermissionError exception when running test_workflow through pytest:

________________________________________________ ERROR at teardown of test_workflow _________________________________________________

    @pytest.fixture
    def client_tempdb():
        # create a temporary database for tests to avoid creating a database that will remain in the directory
        db_fd, db_fname = tempfile.mkstemp()
        app = create_app({
            'SQLALCHEMY_DATABASE_URI': 'sqlite:///' + db_fname,
            'TESTING': True,
            'SECRET_KEY': 'your_secret_key',
            'WTF_CSRF_ENABLED': False,
        })

        with app.app_context():
            db.create_all()

            with app.test_client() as client:
                yield client, db # client must be created under the app context to ensure that the client can interact with the temporary database when making requests

            # this will execute after the tests are completed to delete the temporary database
            db.session.remove()
            os.close(db_fd)
>           os.unlink(db_fname)
E           PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\<username>\\AppData\\Local\\Temp\\tmpbw9gskyj'

test_authentication_flow.py:29: PermissionError

I'm not sure how to interpret this error as well as if this is something unique caused by my own environment/computer, so i'll just bring this up here so that someone more familiar with this test suite might be able to tackle this.

test_login_selenium.py does not automatically open up another flask server in the background (e.g. using something like subprocesses or pytest-flask's "live server" fixtures), so all related tests will fail if another terminal running the flask server is not already open. For now, to check the status of any selenium tests in this file, open up a separate terminal at the root dir, run the usual flask --app .\app\run_app.py run, then navigate to the tests folder with the main terminal and run pytest.

Thanks for checking over my PR! I tried inserting the two lines you suggested and rerunning the tests, but unfortunately, the same issue still seems to occur. I looked into similar problems people were having online, and it seems like a common fix was to rewrite the mkstemp() line as an entire with block (and omit the os.close() function call, since that's handled by the block). I still had no luck though, so the issue's probably like what you mentioned earlier with Windows' handling of temp files.
For now, I'll just merge the PR, and I'll probably just leave a short comment in test_authentication_flow.py as a reminder to revisit this in the future.


firmaware version confusion?

I've a ZNDMWG03LM with firmware version 1.4.7_0160, and xiaomi app suggest me to upgrade to 1.4.7_0115, but i see version requirements in README:

The following versions are confirmed and supported:
Home Assistant from 2022.8.x to 2023.5.x
Xiaomi Multimode Gateway CN/EU from 1.5.0_xxxx to 1.5.4_xxxx

why xiaomi's latest firmware is 1.4.7_0115 while XiaomiGateway3 requires 1.5.0_xxxx~1.5.4_xxxx?

Might because it requires multiple update to get to the latest version.
You can also try this to flash custom firmware
https://github.com/zvldz/mgl03_fw/tree/main/firmware

It depends on cloud region. Your just not provide update.


Support for service principal when using Azure Blob Storage

I am following https://github.com/kahing/goofys/blob/master/README-azure.md to mount azure blob storage.
I want to avoid using storage key, instead i am using a service principal which has read/write/list/delete access on the container.
As per the README, i have also installed azure cli and login using service principal as follows
az login --service-principal --username $AZURE_STORAGE_SPN_CLIENT_ID --password $AZURE_STORAGE_SPN_CLIENT_SECRET --tenant $AZURE_STORAGE_SPN_TENANT_ID

followed by set subscription
az account set --subscription $SUBSCRIPTION_ID

and then mount -
goofys -o allow_other --file-mode 0777 --dir-mode 0777<EMAIL_ADDRESS>$MOUNT_DIR

2021/05/03 13:55:43.245262 main.FATAL Unable to mount file system, see syslog for details

In syslog i see -
May  3 13:55:42 ws-saswata /usr/local/bin/goofys[1057]: main.FATAL Mounting file system: adal: Refresh request failed. Status Code = '400'. Response body: {"error":"invalid_request","error_description":"Identity not found"}

Does goofys support the azure service principal login credentials?

Any update on this? Has anyone figured out how to use service account with goofys.


【v5】brushFilter interaction not working with ranged interval plots when autoFit: true

G2 Version: v5
Platform: MacOS (Chrome Version 118.0.5993.88 (Official Build) (arm64))
Mini Showcase(like screenshots):

https://github.com/antvis/G2/assets/23740173/523b4633-a606-49ae-a5d7-ee39c1e01cef

CodePen Link: https://codesandbox.io/s/36y5s5

With autoFit: true, the plot data is blank when using brushFilter interaction with ranged interval plots.
May be related to 1st point of #5555 .

Yes, there are related. I'll try to fix it today.

This issue has already been fixed by: https://github.com/antvis/G2/pull/5632 , you can upgrade to 5.1.6-beta.1