Negative durability causes crashes with Grind Enchantments

Grind Enchantments takes into account durability by the looks of it, and in some cases causes a crash due to the negative durability value.

I will post logs shortly

java.lang.IllegalArgumentException:
    at sylenthuntress.unbreakable.event.DisplayShatterTooltip.getTooltip(DisplayShatterTooltip.java:31)
    at net.fabricmc.fabric.api.client.item.v1.ItemTooltipCallback.lambda$static$0(ItemTooltipCallback.java:35)
    at net.minecraft.client.gui.hud.InGameHud.renderHotbarItem(InGameHud.java:645)
    at net.minecraft.client.render.GameRenderer.render(GameRenderer.java:865)
    at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1023)
    at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:699)
    at net.minecraft.client.main.Main.main(Main.java:239)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:601)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

https://github.com/sylenthuntress/Unbreakable/blob/master/src/client/java/sylenthuntress/unbreakable/event/DisplayShatterTooltip.java#L31

I can't reproduce, nor do I know what could possibly be causing that exception, but I optimized the code (since it was one of the first bits of code I wrote x3) in hopes that it might fix the issue in some way. More information (e.g the items that crashed, the enchantments that were removed, client-side mods) would be helpful in fixing this.


[beta] [project] Applied Responsive Web Design Projects: Build a Personal Portfolio Webpage

I opened the example project by Freecodecamp in codepen and 1 of the tests are not passing... is it a bug or is it due to the codepen's layout interfering with the project layout?
The task that is not passing is
#Portfolio tests
#Layout
2. The height of the welcome section should be equal to the height of the viewport.

There may also be a bug with
Applied Responsive Web Design Projects:  Build a Technical Documentation Page
#Portfolio tests
#Layout

On regular sized devices (laptops, desktops), the element with id="navbar" should be shown on the left side of the screen and should always be visible to the user.

@tommygebru please note that in the issue template there is a note that asks campers to open these issues on that project's repo: https://github.com/freeCodeCamp/testable-projects-fcc.
Also, the Personal Portfolio project is passing all 11 tests on the browsers I just tried it in. Please reopen this issue in the correct repository with a bit more information on browser, device, etc.

Thanks peter!!


fix(motion_velocity_planner): use the slowdown velocity (instead of 0)

Description
Currently slowdowns in the motion_velocity_planner are incorrectly setting a velocity of 0.
This PR fixes the issue by using the correct velocity.
Related links
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

I have also tried out local tests in an internal environment. It worked as expected.


Fix autocomplete, autocapitalize and autocorrect in Captive Portal login form

New iOS versions do autocapitalization, autocrrection and/or autocompletion in Web Forms. All three can be annoying when entering always changing usernames with sometimes lower-case first characters, as in the Captive Portal Vouchers' usernames.
This should fix the behaviour and make the portal more graceful towards iOS devices.
Source for the attributes and their values: https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html

@johannrichard looks good, thanks!


Support remaining GEDI collections

We currently support the following GEDI collections:

L2A (10.5067/GEDI/GEDI02_A.002)
L4A (10.3334/ORNLDAAC/2056)

Add support for the remaining GEDI collections:

L1B (10.5067/GEDI/GEDI01_B.002)
L2B (10.5067/GEDI/GEDI02_B.002\r\n): NOTE:, the actual DOI value ends with the literal characters \r\n, which is not a valid DOI. See the CMR entry as well as the DOI link, which redirects to the collection's info page.
L3 (10.3334/ORNLDAAC/1952)
L4A-GW (10.3334/ORNLDAAC/2028): L4A Golden Weeks (@wildintellect, do we want users to be able to specify this one?)
L4B (10.3334/ORNLDAAC/2017)

See the full list of GEDI collections in the CMR.
Acceptance Criteria

[ ] Accept any of the additional "logical" names listed above as values for the doi input
[ ] Enhance validation of doi value by requiring the following to be true about the retrieved collection metadata (throwing a "BadParameter" error otherwise):

[ ] The ShortName property contains (starts with?) "GEDI"
[ ] The Projects property is a list containing exactly 1 element, and that element's ShortName property is exactly "GEDI". For example:[
  {
    "ShortName": "GEDI",
    "LongName": "Global Ecosystem Dynamics Investigation",
    "Campaigns": [
      "GEDI"
    ]
  }
]

Remove L3 and L4B those are GeoTiff and COGs - not point data. Their subsetting is done via rio tiler and rasterio on the fly.
L4A-GW - ask the UWG but probably not since it's Version 1, also this data is in the full set it's just a temporal filter.

This ticket is also a little misleading. Simply enabling the correct DOI doesn't mean a particular collection will work. So I would make a ticket for each collection that needs to be supported, and a task in each is to modify the collection/doi handler to enable it.

Actually, simply enabling the correct DOI, does mean the particular collection will work. There is no logic within the algorithm that is collection-specific (other than being scoped only to GEDI collections).
Therefore, the effort to support the remaining GEDI collections is nothing more than adding the mappings from logical names to DOIs, as listed above (along with a bit more logic to make sure that if a user specifies a DOI, rather than a logical name, the DOI is for a GEDI collection, not for some arbitrary collection).
I have removed L3, L4B, and L4A-GW from the list above.


the netflix repository config does not inform the system about minor updates

Bug report
Your Environment
sorry can't create an issue for the repository project, therefore I create it here
fedora32 64bit
latest git build of kodi 19 ( but this also fails on 18 )
Used Operating system:

[ ] Android
[ ] iOS
[X] Linux
[ ] OSX
[ ] Raspberry-Pi
[ ] Windows

Describe the bug
all works fine except the update notifications
I get updates for 1.x releases.
ie the kodi system updates when the version is increased from 1.7 to 1.8
but when the version increase is a minor one like 1.8.0 to 1.8.1 it will not automatically update.
this has been the case since the beginning of this repository
something seems botched in the repository meta data
Expected behavior
minor updates are also picked up by the kodi system
Actual behavior
minor updates are not picked up by the kodi system
Steps to reproduce the behavior
install kodi
install the netflix repo
install 1.8.0
see if it updates to 1.8.1 ( not yet released but once it does you will see it won't update )
install 1.7.0 to see the automatic update to  1.8.0
Possible fix
Debug log
I'm not sure this is needed and can't really create it since the kodi system sees no errors (not even in debug)
Additional context or screenshots (if appropriate)
Installation
Other information
Screenshots

usually if you install from the repository the add-on is updated automatically
if you install the add-on manually, before installing the repository, it is possible that the installed add-on is not connected to the source repository then it will not updated

In Kodi 19 Kodi devs are performing repository management changes and updates
you should have to ask to kodi devs

just performed a test and the repository work as expected
minor versions are recognized
so your problem is not here
also keep in mind that when Kodi performs a version availability check,
for a subsequent check it is necessary to wait 24h


Document what versions of redis are supported by the cookbook

We need to make our supported versions explicit as more redis 3.0 changes begin to roll in that might not be supported in redis 2.6 or 2.8.

I propose we support Chef 11.x and redis 2.8 and greater for the 2.x.x cookbook releases, and then for v3.0.0 of the cookbook, we drop support for Chef 11.x and redis < 3.0.0. I wouldn't rip settings out to break redis < 3.0.0, but we'd stop testing and warn people it could break in the future. We'd also remove the guards against redis < 3.0.0.
If we ever had an issue in 2.0.0 that was critical or a security issue, we could still issue bugfix releases via a 2.x.x branch.

This seems reasonable. Although should we for a 3.x release do a complete break? We could refactor the cookbook and bring it in line with a lot more modern chef cookbook techniques. It could be a worthwhile endeavor.
Just an idea. :)

Although should we for a 3.x release do a complete break?

Indeed! I don't care how we get there, either by rewrite or fresh start, but yeah; we could, if we felt so inclined, even do cookbook versions that match redis versions. It'd be a pain if you have to merge a fix to multiple cookbook branches, but it would drastically simplify the "if this version, do X, otherwise do Y" logic.

As of 2.6.1, redis 2.4.0+ is supported.
I will drop 2.x support in cookbook version 3.x

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Cblum cleanup

Not tested yet, prettified the distributed_fio server and client yaml files to make them easier to read
@dry923 - this touches mostly your code

Can one of the admins verify this patch?

/rerun all

Results for crc_jjb
No tests to run

@mulbc can you please rebase and resolve the conflicts? Thanks!

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:08:35

I don't see why the test failed, but with the recent Dockerfile update, we have switched to running in python3 now... which have broken a few things in the main.yml.
I have fixed these in my new PR regarding fio in VMs

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:10:07

I don't see why the test failed, but with the recent Dockerfile update, we have switched to running in python3 now... which have broken a few things in the main.yml.
I have fixed these in my new PR regarding fio in VMs

@mulbc Looking at the output it is error-ing when grepping in the logs. This grep has recently become redundant since we check ES for a definitive success and I've opened (https://github.com/cloud-bulldozer/ripsaw/pull/356) to remove them. That said, I don't know if that will fix the issue or just move the error elsewhere. I'll re-test this again once 356 is merged.

Yes this is still relevant and I'm waiting on the tests to pass so that @dry923 can merge it

/rerun all

Results for crc_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:08:11

@dry923 - can you make the output of the tests available to me so I can see that this gets merged?

@mulbc apologies for the delay. We had some major hardware issues and the CI env was down and needed a rebuild. I'm going to re-run this now

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:09:43

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:09:40

/rerun fiod

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:08:35

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_fiod
Fail
3
00:08:44


Creating a pod fails if default service account does not exist with the default service account enabled

Describe the bug
Creating a pod fails if default service account does not exist with the default service account enabled
How To Reproduce
Steps to reproduce the issue:
Under the test directory：
make e2e_test -e E2E_GINKGO_LABELS="assignip"
accidental reproduce
Expected behavior
pod can running normally
Screenshots and log

#584


Images created with mipmap data need VK_IMAGE_USAGE_TRANSFER_DST_BIT applied

I was using Anvil::Image::create_nonsparse() to create an image with mipmap data already assigned, and got back an error from validation layers that I was trying to write to an image that doesn't have VK_IMAGE_USAGE_TRANSFER_DST_BIT assigned to it.
I worked around it by adding it manually, but it doesn't say anywhere in the Anvil docs this is necessary. Anvil should probably either OR the flag in itself, or else tell the user they're required to.

Addressed internally. The fix will be included in the coming update.


feat: support yarn-why packages expansion

Codecov Report

Merging #14 (36a58bf) into main (371e8eb) will decrease coverage by 0.86%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   88.35%   87.48%   -0.87%
==========================================
  Files          15       15
  Lines         790      815      +25
==========================================
+ Hits          698      713      +15
- Misses         92      102      +10

Impacted Files
Coverage Δ

install.sh
98.00% <ø> (ø)

src/lib.sh
94.75% <60.00%> (-1.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371e8eb...36a58bf. Read the comment docs.


Add missing cosmos-kit/types dep in example

thanks! This was fixed in another branch that may become main, thanks for this, stay tuned and we'll know soon the plan of action.


Revise Edit user privileges functionality

UX wireframe @rhu001 "DMP User Accounts (Admin View)"
Additional privileges are visible to Super Admin users (related issue #794)
For example, an Org Admin at UCSF should see a list of UCSF users in the table. When the admin clicks the Edit link she's presented with the modal in the screenshot below and can assign Org admin privileges to any user.

DMP Edit User Role - modal

Update page heading to "User accounts"
Add search box above table (this will be done as part of #815)
Table functional spec: limit visibility to 10 rows, thereafter implement pagination (also #815)
Update column names as in wireframe
Add column for "Current privileges" before "Edit" column
For display purposes in the "Current privileges" column there are two buckets: 1) Org admin privileges, 2) Super admin privileges. If a user has any individual privileges in either of these buckets, then display the high-level bucket name in this column. So, e.g., if I can "Manage user templates" then this column should say that I have "Org admin privileges." If I can also "Grant API access" then this column should also say that I have "Super admin privileges"
For users with no Org or Super admin privileges, the "Current privileges" column should be blank
Blue notepad functional spec: Clicking on Edit link should open a modal that allows admins to assign privileges to other users (second UX wireframe screenshot above)
Ticking the first box for "Org admin privileges" should automatically tick all boxes below it; these can then be deselected individually if desired
Note: add one more privilege tickbox at the end of the Org Admin column to "Use API" (missing from wireframe)

For clarity, here are the descriptors currently used in the database, grouped by the two roles; these should be mapped to the language in the modal screenshot above:
Org admin
Grant_permissions
Modify_templates
Modify_guidance
Change_org_details
Use_api

The same weird behavior is happening when I try to grant top-level Org Admin privileges as an Org Admin (described in related issue #794 ). After the first attempt, all subsequent changes behave as expected.
One change specific to editing privileges as an Org Admin:

I should not be able to click and edit privileges for a Super Admin. Please remove/disable the Edit link next to records for Super Admin users (screenshot below)

updating so that Org Admins cannot change privileges for a super admin and an Org Admin can only grant/revoke privileges they themselves have. For example if an Org Admin is setup to only administer templates, then they cannot give permission to another user to administer guidance.

everything working as expected for Org Admin privileges. closing issue.


Enable strict mode and added new tests

Pull Request Summary
Description:
This pull request introduces several changes and additions to the codebase. Below is a detailed summary of the changes made in each file:
.github/workflows/typecheck.yml

Added a new workflow file named typecheck.yml.
This workflow runs on push and pull request events.
It uses Node.js version 18.x and installs dependencies using the bahmutov/npm-install action.
Finally, it runs the TypeScript type checker using yarn tsc.

src/config/jest-playwright.ts

Modified the browsers property by checking if TEST_BROWSERS exists.

src/csf/transformCsf.ts

Introduced a result variable and assigned the input to it.
Checked if testPrefixer exists, and if so, performed some additional operations.
If result is falsy, it's set to a null literal.

src/csf/transformCsf.test.ts

Created a new test file for the transformCsf function and prefixFunction.

src/playwright/transformPlaywright.ts

Updated the makeTitleFactory function to ensure the returned value is always a string.

src/setup-page.ts

Added conditional logic to check if testRunnerConfig exists before calling the defaultPrepare function.

src/test-storybook.ts

Improved error handling when an error occurs, including checking if the error is an instance of Error and creating an error object with a stack if necessary.

src/util/getCliOptions.test.ts

Added a new test case that checks whether default options are returned when no options are passed.
Added new test cases that check whether string options, boolean options and extra arguments are handled correctly.

src/util/getCliOptions.ts

Updated the handling of boolean and string options, ensuring they are correctly processed.

src/util/getParsedCliOptions.test.ts

Created a new test file for the getParsedCliOptions function.

src/util/getParsedCliOptions.ts

Improved error handling to catch and handle Commander errors.
Added an unknown option handling and warning for unknown options.

src/util/getStorybookMetadata.ts

Updated the getStorybookMetadata function to handle cases where configDir is not provided.

src/util/getTestRunnerConfig.test.ts

Added a new test file for the getTestRunnerConfig function.

src/util/getTestRunnerConfig.ts

Updated the getTestRunnerConfig function to handle cases where configDir is not provided.

tsconfig.json

Updated the TypeScript configuration to include stricter type checking and set noEmit to true.

These changes enhance the codebase and improve error handling and type checking.
From #323

📦 Published PR as canary version: 0.14.1--canary.378.44bae0d.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

@yannbf This is part 1 from the changes proposed in #323
This pr doesn't have any breaking changes. It should be easier to review.

Hey @bryanjtc! Thank you so much for all these contributions! I finally have time to go through them, and will start reviewing, adding work on top of and responding to them.


Should Show "specs" Config Variable in Documentation

I'm having a TON of trouble getting this framework to recognize my files. The README currently says to new users to set the framework config variable, and then tells them to go f! themselves. It's critical to mention that you mention that we need to also set the "specs" option in the protractor config file to look for ".feature" and ".step" files. It would also be nice to know how to actually implement the step definitions since every cucumber implementation is different.

I had configured a boilerplate angular2 project (generated with angular-cli) with cucumber.
Have a look at https://github.com/AlexandrosD/ng2-protractor-cucumber

@AlexandrosD  Thanks, but what am I supposed to be looking at here? Your karma config file is not even set up to run feature files or step definitions: https://github.com/AlexandrosD/ng2-protractor-cucumber/blob/master/config/karma.conf.js

Nope, I am using cucumber, protractor, and chai there

Thanks for your help @AlexandrosD
This configuration is documented in Protractor because it is homogenous to all frameworks (including Jasmine), but I added it in https://github.com/mattfritz/protractor-cucumber-framework/commit/baf47314d6dc70dc4bf20bd97ebdb9afdbed2576 for clarity.
@JimTheMan please try to be more polite when filing issues. This package is simple glue between Protractor and Cucumber, so most of the documentation (such as step definition implementation) is in the Cucumber docs.


alert rule is always set stateChangesOnly

hi， I configure the alert rule on alert-rule-builder of kapacitor which docker container  is kapacitor:1.5.0-alpine.
The email configuration in kapacitor.conf is as follows:
[smtp]
enabled = false
host = "localhost"
port = 25
username = ""
password = ""
no-verify = false
global = false
state-changes-only = false
from = ""
idle-timeout = "30s"
The alertnode of tickscript is always as follows:
var trigger = data
|alert()
.crit(lambda: "value" > crit)
.stateChangesOnly()
.message(message)
.id(idVar)
.idTag(idTag)
.levelTag(levelTag)
.messageField(messageField)
.durationField(durationField)
.email()
<EMAIL_ADDRESS>I have set " state-changes-only = false". Why does the alertnode have "stateChangesOnly()"?

I look forward to your reply! Thanks!

The Chronograf UI does not know what is configured in Kapacitor. That option is probably included by default because it's the less "noisy" method. If you really want to receive an alert on each evaluation, you can just remove it from the script and hit Save.


Opentelemetry: Propegate TraceID and SpanID to steps

Is your feature request related to a problem? Please describe.
The new OpenTelemetry (OTEL) experiment is helpful, but it does not make it possible to get the current traceId and spanId.
If we could get access to these, we can then link our OTEL instrumentation inside each step with the trace that exists for the whole job.
Describe the solution you'd like
Extend the existing BUILDKITE_TRACE_CONTEXT found in https://github.com/buildkite/agent/blob/848a053b3131ebced93d829c3215b31bddd19f72/tracetools/propagate.go to each step, when a tracing backend is used.
Describe alternatives you've considered
I've hacked around the codebase to enable access to TraceID and SpanID as individual variables, but the OTEL libraries are all focussed around propagating from a single trace context.
Additional context
This helps with getting a deeper understanding of what's happening over the course of a whole job. And helps with linking telemetry from each step together.
I'm willing to work on a PR up for this, if it's likely to be merged.

I've found a very relevant issue from the Otel repo https://github.com/open-telemetry/opentelemetry-specification/issues/740.
It goes into a bit of depth about other CI tooling, and how they've mostly settled on using TRACEPARENT and TRACECONTEXT as the envars to share trace information.

hey @ojkelly! this is definitely something that we're looking to work on - it was intentionally left out of the initial release so that we could get something out, but we'll definitely be looking to include it in the near future. There's some internal work that i'm doing that's ahead of trace propagation in the queue, but it will be coming soon.
I've also been across the issue you linked - whatever we end up doing, it'll probably end up being complaint with the (non-) standard laid out there.

Hi everyone,
I am from the product team at Buildkite. Unfortunately this is still in backlog for us, so it will be a while before we pick this piece of work. The team is working on security work like signed agents that will delay this being from picked up. Sorry about that.


Feature: Custom Tags

Something like custom tags would be cool to help sort tasks without having to create collections. Examples can contain:

To Do
Programming
<Year>
Etc.
Custom Tags

Simple CSS that'd look decent enough:

span.badge {     background-color: #ffff9e;     padding-top: 0.5px;     padding-left: 4px;     padding-bottom: 0.5px;     padding-right: 4px;     border-color: #d1d854;     border-style: solid;     border-width: 2px;     border-radius: 10px; }

TC;DR: Collections are the same thing as tags, I'll add the labels to tell you which collection the task is in and add bulk task assignment for ease of use.
I have something like this on my internal to-do list, I actually think collections are perfect for this as long as I add a way to add tasks in bulk as well as keeping the option to add tasks individually from their page. The benefit of collections is that you can share them and view tasks in groups, so I don't really want to make a version of collections with less functionality.
I'm thinking I could add a label (like your example!) to tasks that are in collections, identifying which its in so you don't have to click around to find it. This will be just as effective as tags without having to add a new database table or functionality to sort by tag.

true true but I feel like creating too many collections can be tedious and it'll take space in the "Collections" menu, therefore tags and filters for tags would work better :)
and tags should be applied to collections rather than tasks, as that'd be kind of annoying, I only used tasks as an example lol


Allow platform filter on buses

Solves : https://github.com/morosanmihail/HA-LondonTfL/issues/29

@morosanmihail Can you review this please?

Thanks for your patience! Been far from a personal PC this week and only just got back. This looks ok, will land! Thank you!


Clarify handling of CI branding in public repos e.g. bootstrap library

The baloise-bootstrap repository contains several CI brand artifacts. Weather open-sourcing such libraries makes sense in the first place, is yet to be discussed.
The baloise group logo is referenced in baloise/open-source. If we want to start removing this dependency, we need another public source of this logo. I was only able to find the baloise holding logo on wikimedia.
There is a download page for various baloise logos. However, those urls don't seem to be safe for referencing.


[Bug] SeasonHUD cannot display if Journeymap's minimap has hiddien before game startup.

When setting Journeymap's minimap to disable in default, or just hidden the minimap through shortcut key before turn off the game, seasonHUD will not display anymore even if you turn on the minimap in game.
Even though setting 'enable_show_minimap_hidden' to ture, seasonHUD still doesn't display in game anymore.
Game version: 1.20.1
Forge version: 47.1.47
Journeymap version: 1.20.1-5.9.18
SeasonHUD version: .20.1-1.7.11

I also find another problem when using this seasonHUD with journeymap, the HUD will not turn on and off with the minimap.
When turn off the minimap, the hud stays on the screen, if scaling the game window at this time, the HUD will float in place.

Fixed in 1.7.12 (uploading now)


add challenge to acme

Hello,
I have created: #3950
Would be nice if your created dns challenge could be added to acme. Maybe by doing a pull request there?

Hello,
Thank you for proposing that. But until there is a delete endpoint at zoneedit which is out of my control, I'm not prepared to do a pull request to add challenge to acme at the time being.

I understand!
I have used your scripts from command line and found them helpful, thank you for your work .
On other systems where acme is "part of the system" I went for the acmedns option as on those systems that is fully automated.


Data Feeds UI: S1: Disclaimer Text and overview

User Story
As an Automate user, I should see disclaimer text on below the Title: Data Feeds in Data Feeds Tab Overview Page.
Current View:

New View:

CSS and Other UI Info can be found in Figma Editor
Definition of Done

Page should look like this: figma preview

All things specified in User Story Acceptance Criteria should be fulfilled.
All Exceptions are Handled Properly, with user prompt.
Ensure Console has no Errors and not unnecessary logging in Smoke Test.
UI should exactly match UX design.
Unit Test coverage for every new feature at least 70%
Cypress Coverage for new Feature.
Smoke Test is done.
Ensure Build and Integration Pipelines are Green.
PR has 2 approvers.
All Code Review Comments are Resolved.

Final Page View

The disclaimer section should have some more blank space at the top, please make sure matches the Figma design


Can not play video

I find it can not play video,when I build the project.

@lbytedev The latest version has been fixed🙂


[hotfix][javadocs] Fix typo in RichFunction

Just remove the duplicated two words. of the

Hi @wuchong , PTAL, Thanks.


[Flutter 1.20.1 on iOS] NoSuchMethodError: StatefulWidget

I have an application that runs Flutter in an add2app mode. I have been using it for a while now and it has been working for hot reloading normally until I updated to Flutter 1.20.1. Now whenever I run my application on iOS and the attach the debugger, after hot reloading I get a red screen with the following error:
NoSuchMethodError: No constructor 'StatefulWidget.' with matching arguments declared in class 'StatefulWidget'.
Receiver: StatefulWidget
Tried calling: new StatefulWidget.()
Found: new StatefulWidget.({Key key}) => StatefulWidget

The only way I can get it to work again is by flutter clean and the run all again, it takes too much time to do. Is this a known problem? Is there any other workaround? It has slowed down my productivity a lot.
flutter doctor -v:
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.6 19G73, locale pt)
    • Flutter version 1.20.2 at /Users/leonardosilva/development/flutter/flutter
    • Framework revision bbfbf1770c (4 days ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/leonardosilva/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.8.4

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.13.2

[✓] Connected device (1 available)
    • iPhone de Leonardo (mobile) • ac197a55a52fbad3d364054a4c99dbe29ed46b23 •
      ios • iOS 13.5.1

! Doctor found issues in 1 category.

Hi @lslv1243
Can you please provide  a complete reproducible minimal code sample from flutter module  and native.
You create minimal code sample repository or attach it here in the comment in a zip
Thank you

Similar to #61956

Please check out my response https://github.com/flutter/flutter/issues/61956#issuecomment-688269304

Closing ad duplicate of https://github.com/flutter/flutter/issues/61956


Why forcing all the builtin rules to be configured?

Hey,
I am trying to build a ruleset for Laravel 6 based on this gist, while am trying to make sure that tests pass I faced the problem where many of the default rules are not set within the gist and this test always fails testAllBuiltInRulesAreConfigured.
I was wondering why do you force all the builtin rules to be configured?
Thanks

Hello @linuxjuggler!
Thank you for opening an issue and asking for an explanation.
The idea behind that test is that we want to make sure that all available fixers are either enabled or disabled explicitly. This also helps when receiving updates of friendsofphp/php-cs-fixer, perhaps via Dependabot, which brings in new fixers: the failing test will indicate that new fixers have been provided by the update.
For an example, see https://github.com/localheinz/php-cs-fixer-config/pull/213:

with https://github.com/localheinz/php-cs-fixer-config/pull/213/commits/aee85269c50508fb5d2d977eaa0800d3da207ccf Dependabot opened a pull request updating friendsofphp/php-cs-fixer, pulling in new fixers, which resulted in a failing build
with https://github.com/localheinz/php-cs-fixer-config/pull/213/commits/4ca4f6c3d1904d59c2e10b7b10fe1a800fb67bc1, I disabled the newly added fixers to fix the build
as follow-ups, with https://github.com/localheinz/php-cs-fixer-config/pull/214, https://github.com/localheinz/php-cs-fixer-config/pull/215, https://github.com/localheinz/php-cs-fixer-config/pull/216, https://github.com/localheinz/php-cs-fixer-config/pull/217, https://github.com/localheinz/php-cs-fixer-config/pull/218 I enabled the fixers

On the long run, this helps keeping up-to-date with newly added fixers!
Perhaps you find https://github.com/ergebnis/php-cs-fixer-config-template a better starting point? I also added a Motivation section there, maybe it helps?

Fair enough, thanks @localheinz for the explanation.
I'll check the template and might send a PR once I got my tests to pass.

Thank you, @linuxjuggler!


Revert "Merge pull request #25493: Capture is-a VerificationException as metadata"

This reverts commit 7ad60ec2d451e89251f90875874a98aae42adc69, reversing changes made to 7f70c6bf177d49b9e92afae49753391a9ac86f86.
Context

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Uploading VID_68270811_230826_627.mp4…


Switch to mozilla-django-oidc

If it is well-maintained and works out of the box with Datatracker, it should be a less-code option.

@rjsparks I understand that switching to an OIDC library would be preferable in long term.

Would you say mozilla-django-oidc is a sound option?
If yes, would you say switching to it is a pre-requisite to delivery and delay will be justified? I expect it shouldn’t take more than 2 days to refactor datatracker.oauth module to use Mozilla’s OIDC library.

yes, this is a good change to make and taking an extra couple of days is fine.

I start to believe that switching to Mozilla’s OIDC library unnecessarily increases complexity. The library requires using Django’s authentication system, which brings no real benefit while increasing complexity (and I believe somewhat violates our design goal of keeping PostgreSQL data ephemeral, as it would start keeping user data in a PostgreSQL table).
In theory, the library allows avoiding Django’s user mechanism by providing a custom backend implementation, but its documentation is very sparse. I’m looking into that.

That moves this into "more than a couple of days" territory I think? Since you appear to have solved the issue with the code you have, we should let this rest. We'll address it later.

Yes, it would be a bit longer… And I think it would save complexity if future uses for authentication are better understood before continuing. The existing issues were addressed, but I’ll leave this issue open since the case for switching to third-party implementation of OIDC layer still exists.

Thanks @rjsparks for understanding. I'd just like to clarify a bit of what @strogonoff meant: the BibXML service today does not need Django's authentication system because "authentication" is fully delegated to datatracker. In order to enable Django's authentication system, it would require the BibXML service to maintain a persistent database -- which we do not have a need for right now.

yes, I followed, and I think we should stay with what is currently coded for now. This issue can be closed.

Thank you @rjsparks !

@rjsparks Thus it is no longer necessary to allow redirecting to localhost for these OAuth credentials… That setup ended up for nothing, sorry.

no big deal - thanks for letting me know it can be taken out.


Added: humanification/simulate typing

I am seeing a conflict in Convo.js - please do a forward integration from master to the feature branch

I am seeing a conflict in Convo.js - please do a forward integration from master to the feature branch

done


fix(playwright): npx playwright install --with-deps in GitHub actions

This fixes playwright self-installation for CI.
Playwright needs to have npx playwright install --with-deps on GitHub actions runners. Not entirely sure when this became mandatory, but it's obnoxious, and needs to be done.
https://playwright.dev/docs/ci-intro

https://github.com/garris/BackstopJS/pull/1523


SceneAppPage: Support react elements in subtitle

Closes #170

📦 Published PR as canary version: 0.10.0--canary.196.5054162429.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

@connorlindsey that is already exposed via renderTitle

🤦♂whoops, sorry for missing that


[web]: flutter build web doesn't generate a proper build

My webapp isn't building properly.  It runs fine on Android, and even iOS.  If I peek into the web directory, there's nothing in there but the boilerplate stuff.  If I'm doing something wrong, I'd love to learn what.  If something isn't working as expected, I'd like to see it fixed. :)

The code generated for the index page seems to be boilerplate:
<!DOCTYPE html>
<html>
<head>
  <meta charset="UTF-8">
  <meta content="IE=Edge" http-equiv="X-UA-Compatible">
  <meta name="description" content="A new Flutter project.">

  <!-- iOS meta tags & icons -->
  <meta name="apple-mobile-web-app-capable" content="yes">
  <meta name="apple-mobile-web-app-status-bar-style" content="black">
  <meta name="apple-mobile-web-app-title" content="t4c_companion">
  <link rel="apple-touch-icon" href="icons/Icon-192.png">

  <!-- Favicon -->
  <link rel="shortcut icon" type="image/png" href="favicon.png"/>

  <title>t4c_companion</title>
  <link rel="manifest" href="manifest.json">
</head>
<body>
  <!-- This script installs service_worker.js to provide PWA functionality to
       application. For more information, see:
       https://developers.google.com/web/fundamentals/primers/service-workers -->
  <script>
    if ('serviceWorker' in navigator) {
      window.addEventListener('load', function () {
        navigator.serviceWorker.register('flutter_service_worker.js');
      });
    }
  </script>
  <script src="main.dart.js" type="application/javascript"></script>
</body>
</html>

The web console throws a few errors:
Uncaught TypeError: Cannot set property 'getModuleLibraries' of undefined
    at main_module.bootstrap.js:16
    at Object.execCb (require.js:1696)
    at Module.check (require.js:883)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)
    at Module.enable (require.js:1176)
    at Module.init (require.js:788)
    at callGetModule (require.js:1203)
    at Object.completeLoad (require.js:1590)
    at HTMLScriptElement.onScriptLoad (require.js:1717)
top_level.dart:78 Uncaught (in promise) TypeError: Cannot read property 'app' of undefined
    at Object.app$ [as app] (top_level.dart:78)
    at appNamed (firebase_core_web.dart:22)
    at appNamed.next (<anonymous>)
    at runBody (async_patch.dart:86)
    at Object._async [as async] (async_patch.dart:125)
    at firebase_core_web.FirebaseCoreWeb.new.appNamed (firebase_core_web.dart:20)
    at appNamed (firebase_app.dart:36)
    at appNamed.next (<anonymous>)
    at runBody (async_patch.dart:86)
    at Object._async [as async] (async_patch.dart:125)
    at Function.appNamed (firebase_app.dart:34)
    at configure (firebase_app.dart:58)
    at configure.next (<anonymous>)
    at runBody (async_patch.dart:86)
    at Object._async [as async] (async_patch.dart:125)
    at Function.configure (firebase_app.dart:50)
    at main$ (main.dart:53)
    at main$.next (<anonymous>)
    at runBody (async_patch.dart:86)
    at Object._async [as async] (async_patch.dart:125)
    at Object.main$ [as main] (main.dart:48)
    at main$ (web_entrypoint.dart:8)
    at main$.next (<anonymous>)
    at onValue (async_patch.dart:47)
    at _RootZone.runUnary (zone.dart:1439)
    at _FutureListener.thenAwait.handleValue (future_impl.dart:141)
    at handleValueCallback (future_impl.dart:682)
    at Function._propagateToListeners (future_impl.dart:711)
    at async._AsyncCallbackEntry.new.callback (future_impl.dart:391)
    at Object._microtaskLoop (schedule_microtask.dart:43)
    at _startMicrotaskLoop (schedule_microtask.dart:52)
    at async_patch.dart:168

Here's the pubspec.yaml:
name: t4c_companion
description: A helpful companion for T4C players and a reference for the rest of us.

version: 1.0.0+1

environment:
  sdk: ">=2.6.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  path:
  async:
  basic_utils: ^1.2.0
  provider: ^3.1.0+1
  package_info: ^0.4.0+3
  firebase_core: ^0.4.0+9
  firebase_analytics: ^5.0.2
  firebase_auth: ^0.16.0
  firebase_database:
  firebase_crashlytics:
  flare_flutter: ^1.8.3
  intl:
  cupertino_icons: ^0.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter

flutter:
  assets:
    - assets/
    - assets/images/
    - assets/images/equipment/armor/
    - assets/images/equipment/bow/
    - assets/images/equipment/jewelry/
    - assets/images/equipment/quiver/
    - assets/images/equipment/weapon/
    - assets/images/monsters/
    - assets/images/remorts/
    - assets/images/servers/
    - assets/images/badges/
    - assets/images/skills/
    - assets/images/skills/realmud/

  fonts:
    - family: T4CBeaulieux
      fonts:
        - asset: assets/t4cbeaulieuxV3.otf
    - family: HackNF
      fonts:
        - asset: assets/HackNF.ttf

Hi @skipmeister123
You have to follow Web integration instructions from firebase_core
You might also be using some packages that are not yet supported by flutter on web. Check your dependencies on pub.dev for compatibility.

Hi @skipmeister123
You need create web app in your firebase console and  get the credentials to load web version of firebase in your app
Looking at your index.html, you don't seem to have web configuration for firebase
Please check out this guide
Thank you

After a bit of digging, I found that - even if I manage to lay out the firebase configuration properly - I'm not going to be able to get this working for the web.  My app leans heavily on firebase_database, which currently does not support web.  I'll hang on to these instructions, so that once the card is moved to completed I can try again.


ion-content directive doesn't document has-header attribute

https://github.com/driftyco/ionic/blob/master/js/angular/directive/content.js
It's there in the source though, I'm pretty sure it used to be there.

Greetings, @jayproulx!
My sensors indicate that this issue has been inactive for a while.
Due to this, the issue will be closed in 7 days.
If you believe the issue has not been fixed, please add a comment.
This will notify us so we can assist you, and will prevent the issue from being automatically closed.
Feel free to include the following information about the issue, so that we may assist you:

Can you provide a detailed description of this issue?
How would a robot go about replicating this issue?
What platform does this happen on? (iOS, Android, all, etc.)
What platform versions does this happen on? (Android 4.2, iOS 7, all, etc.)
Is this an issue with the Ionic Framework, or Ionic CLI?

Thank you for allowing me to assist you.

The has-header attribute has long been removed in favor of a has-header class. The class will automatically be applied if there is a header-bar or nav-bar visible. Same thing goes for has-footer and has-tabs.


Prepare components as reusable lib for npm

Hi, first of all, thanks for a great set of components!
There is one issue with lib, I agree to include in my webpack config sass loaders, but I don't agree to include unnecessary deps in my project (react-transform-catch-errors, etc.).
It would be nice if you prepare components as a really reusable lib.

I need to elaborate on this issue. If you don't mind I would like to include React Toolbox components into one of boilerplates here http://helmetrex.com But the tool which is used there has its own webpack and webpack middleware environment configuration. So, I could not build components at all.

Hi @ipselon thanks for your words :)
There are no such dependencies. React Toolbox only depends on React (with ReactDOM and css-transition-group) and normalize. The only limitation of React Toolbox is that you need to include CSS Modules in your workflow. To be able to customize colors and components in an easy way we can't include in the package the css already compiled, that's why you need sass loader... but that's all you need.
There is no need for other packages. Let me know if you can't get it working!
Thanks!

@javivelasco a couple hours ago I install react-toolbox from npm and my webpack threw exception about missing modules. When I looked into the source code of (for example) node_modules/react-toolbox/lib/list/item.js I found the following:
'use strict';
var _reactTransformHmr2 = require('react-transform-hmr');
var _reactTransformHmr3 = _interopRequireDefault(_reactTransformHmr2);
var _react = require('react');
var _reactTransformCatchErrors2 = require('react-transform-catch-errors');
var _reactTransformCatchErrors3 = _interopRequireDefault(_reactTransformCatchErrors2);
var _redboxReact = require('redbox-react');

You are right, I've created the last build without the production env specified and the lib is including development babel settings. Sorry about that, fixing.
Thanks for reporting!

It should be fixed now. We are not still making semantic releases, just hot patches. During this week we will plan the roadmap to get a final version of React Toolbox and start with tagged released.
Closing!


Specifying a cwd to not include the path to the hbs files in the output path fails

To build my source in src/index.hbs so that it builds in dist/index.html and not dist/src/index.html I used cwd to go into src which is valid grunt, however, assemble returns the following error: Fatal error: Unable to read "index.hbs" file (Error code: ENOENT).

Nevermind...I'm a moron.....I keep forgetting to add expand: true

lol it's easy to forget. I do stuff like that all the time


Result List page explanations have the incorrect parameter symbol

On the SWIRL Results List page (http://localhost:8000/swirl/results/?search_id=*), there is a block of test at the top of the page that outlines additional parameters that can be added the Results List URL to reveal additional information.  Three of these explanations indicate that the question mark (?) is required before adding the additional parameter:

?result_mixer=
?explain=
?provider=

As seen here:

This is incorrect for these 3 options; instead, they require the ampersand (&) before the parameter.  For example,  &explain=true is correct and activates query explanation within the Result Lis, whereas ?explain=true gives a 500 error.
The code responsible for generating the text at the top of the Result List page should be update such that the ampersand is presented to users for these 3 options.

Fixed in 1.3_final!

Fixed in 1.3 Final.  Updated text instructions validated:


Change SPI clock?

Is the properties to change the clock frequency for SPI exposed?
Can't find it anywhere.

You can change SPI Clock frequency using -D devisor options
https://github.com/zhelnio/MPSSELight/blob/6155a401f33ba25d77af7e182095234eb4dfcb51/SpiLight/Options.cs#L61-L62


Add support for user-defined rules: Take 4

Codecov Report
Base: 73.61% // Head: 72.97% // Decreases project coverage by -0.64% :warning:

Coverage data is based on head (0a5a8cc) compared to base (5fce502).
Patch coverage: 86.79% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   73.61%   72.97%   -0.64%
==========================================
  Files          17       17
  Lines        6116     6447     +331
==========================================
+ Hits         4502     4705     +203
- Misses       1614     1742     +128

Impacted Files
Coverage Δ

src/Enzyme.jl
84.92% <ø> (ø)

src/compiler/reflection.jl
90.32% <ø> (ø)

src/compiler/interpreter.jl
85.50% <83.78%> (+0.05%)
:arrow_up:

src/compiler.jl
74.01% <86.96%> (+0.53%)
:arrow_up:

src/api.jl
62.74% <100.00%> (+1.05%)
:arrow_up:

src/compiler/pmap.jl
82.85% <100.00%> (+5.31%)
:arrow_up:

src/compiler/orcv1.jl
0.00% <0.00%> (-76.93%)
:arrow_down:

src/compiler/utils.jl
57.53% <0.00%> (-38.36%)
:arrow_down:

src/compiler/validation.jl
57.68% <0.00%> (-4.39%)
:arrow_down:

src/typetree.jl
86.71% <0.00%> (-0.79%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


schedule: fix panic issue after delete the rule

What problem does this PR solve?
Fix https://github.com/pingcap/pd/issues/2478

What is changed and how it works?
check the length.
Check List

Tests

Manual test (add detailed scripts or steps below)

Release note

fix the panic issue after deleting the rule

/merge

Codecov Report

Merging #2513 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   77.12%   77.17%   +0.04%
==========================================
  Files         204      204
  Lines       22002    22004       +2
==========================================
+ Hits        16970    16982      +12
+ Misses       3753     3741      -12
- Partials     1279     1281       +2

Impacted Files
Coverage Δ

server/schedule/placement/fit.go
89.14% <0.00%> (-1.41%)
:arrow_down:

server/kv/etcd_kv.go
84.41% <0.00%> (-3.90%)
:arrow_down:

server/schedulers/random_merge.go
61.19% <0.00%> (-2.99%)
:arrow_down:

server/cluster/coordinator.go
71.95% <0.00%> (-2.12%)
:arrow_down:

server/tso/tso.go
80.29% <0.00%> (-1.46%)
:arrow_down:

pkg/etcdutil/etcdutil.go
86.95% <0.00%> (-1.45%)
:arrow_down:

pkg/btree/btree.go
86.84% <0.00%> (-0.81%)
:arrow_down:

server/schedule/operator_controller.go
81.00% <0.00%> (+0.16%)
:arrow_up:

server/grpc_service.go
59.38% <0.00%> (+0.38%)
:arrow_up:

server/config/persist_options.go
90.90% <0.00%> (+0.45%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7094cb5...6fde835. Read the comment docs.

/merge

/run-all-tests

/run-all-tests


Help with DisplayVideo DV360

Hi,
I tried to use this library to make API call to this DV360 endpoint: https://developers.google.com/display-video/api/reference/rest/v1/partners/list
My code is like this:
        $client = new Google_Client();
        $client->setApplicationName('App name');
        $client->setAuthConfig("credentials.json");
        $client->addScope(\Google_Service_DisplayVideo::DISPLAY_VIDEO);

        $service = new \Google_Service_DisplayVideo($client);
        $result = $service->partners->list();

But I then got an error like this: Call to undefined method Google_Service_DisplayVideo_Resource_Partners::list(). Since there is virtually no user's documentation nor any example I could found for DV360, could anyone help guiding me the right way to make this API call please? Thank you!

Oh, got it. Had to do something like this:

        $service = new \Google_Service_DisplayVideo($this->client);
        $result = $service->partners->listPartners();


Plesk integration

Pleask is one of the best admin control panel in the market. Would not it be nice to have an easy deployment plugin?

This is outside the scope of Flask itself.

Plesk is one of the best admin control panel

I LOL'd :D


File Transfer Progress Bar

For each file transferred, we need to have a progress bar, which shows the state of the file being transferred.

Not relevant anymore

What does this mean?

This issue is not going to be fixed in current cc. Even if it is important enough to have, it should be included in the functionality of subutron.
Do you think I need to keep it open?


SITL with gazebo and px4

Hi,
I'm trying to simulate a drone controlled via a ros node but after a full day of trying, searching and reading i can't get it to work.
I think I have installed everything

mavros
gazebo
PX4 Frimware
jMAVsim

When i try no_sim=1 make posix_sitl_default gazebo it will give me INFO  [simulator] Waiting for initial data on UDP port 14560. Please start the flight simulator to proceed.., so i guess that works fine too. So now i'm at the part of making my .launch file but there seems to be a problem.
The launch file I have:
`
<arg name="headless" default="false"/>
<arg name="gui" default="true"/>
<arg name="enable_logging" default="false"/>
<arg name="enable_ground_truth" default="true"/>
<arg name="enable_mavlink_interface" default="true"/>
<arg name="ns" default="iris"/>
<arg name="log_file" default="$(arg ns)"/>
<arg name="mavlink_bridge_url" default="udp://<IP_ADDRESS>:14551@14555" />

<include file="/home/simon/Documents/masterproef/masterproef_ws/Firmware/launch/gazebo_iris_empty_world.launch">
    <arg name="headless" value="$(arg headless)"/>
    <arg name="gui" value="$(arg gui)"/>
    <arg name="enable_logging" value="$(arg enable_logging)" />
    <arg name="enable_ground_truth" value="$(arg enable_ground_truth)" />
    <arg name="enable_mavlink_interface" value="$(arg enable_mavlink_interface)" />
    <arg name="log_file" value="$(arg log_file)"/>
</include>
<include file="/home/simon/Documents/masterproef/masterproef_ws/mavros/mavros/launch/mavlink_bridge.launch">
<arg name="mavlink_bridge_url" value="$(arg mavlink_bridge_url)" />
<arg name="ns" value="$(arg ns)"/>
</include>
<node pkg="ros_gazebo" type="gazebo_node" name="gazebo_node" output="screen"/>

`
I used the guide from: https://dev.px4.io/en/simulation/ros_interface.html?q=, https://404warehouse.net/2016/07/11/px4-software-in-the-loopsitl-simulation-on-gazebo/ and https://github.com/PX4/Firmware/issues/3368
Can someone help me with this?

Did you solve this issue? I also met this problem


deletion animation

shrink and slide list items into the trash on delete all

use rocket.css

rocket.css and rocket.js have been added, as well as necessary function inside delete trigger, but not sure how to operate it.

Went with animate.css


DST-785 - Implement front-end Sentry error and performance tracking for RaB and Licensing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.01%. Comparing base (c6b1b56) to head (cab5e66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   79.97%   80.01%   +0.04%
==========================================
  Files          77       77
  Lines        2332     2337       +5
==========================================
+ Hits         1865     1870       +5
  Misses        467      467

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Simplification algo appears to cause tile seam artefacts

We had to turn the simplification off as wedges would develop on tile seams preventing the bleed/buffer (grep for buffer) to be correctly applied. My guess is that Douglas–Peucker that you use removes poly edges that we have deliberately bleed out of the tile for proper blending. At least this is my theory.
I am not a tiling expert, but why wouldn't it be appropriate here:
	for _, p := range points {
		dx, dy := c.GetDeltaPointAndUpdate(p)
		//	encode our delta point
		g = append(g, encodeZigZag(dx), encodeZigZag(dy))
	}
	return g

to check whether there dx,dy are different from previous and skip them if they're the same. Wouldn't that serve as oftentimes sufficient simplification?
Here's the offending geometry:
{
  "coordinates": [
    [
      [
        -118.915929794311523,
        34.13671875
      ],
      [
        -118.915929794311523,
        34.08899026424313
      ],
      [
        -118.944625096552102,
        34.08899026424313
      ],
      [
        -118.949598455211159,
        34.090160115815209
      ],
      [
        -118.964824913325486,
        34.096622314681383
      ],
      [
        -118.978246085407733,
        34.105430017405581
      ],
      [
        -118.989346656919466,
        34.11624539420265
      ],
      [
        -118.997699850573255,
        34.128653494887246
      ],
      [
        -119.000850912295292,
        34.13671875
      ],
      [
        -119.002983854653664,
        34.142178092208631
      ],
      [
        -119.003992080688477,
        34.149260049035767
      ],
      [
        -119.003992080688477,
        34.161889212837202
      ],
      [
        -118.915929794311523,
        34.161889212837202
      ],
      [
        -118.915929794311523,
        34.13671875
      ]
    ]
  ],
  "type": "Polygon"
}

with simplification on:

without simplification:

The skipping of dy and dx was the first system we used. But it did not reduce the number of points. One thing I'm trying to figure out how to plumb through is the ability to turn off simplification on a per layer bases. Also, there is a different simplification algo, that I'm planning on implementing; but I think it will have the same effect.

Thanks @gdey for accepting this.
Not sure i follow why skipping dx,yx==[0,0] would not reduce the number of points - at least in the use case we care most of - down-sampling for coarser zooms.
Suppose we have this poly:
{
  "coordinates": [
    [
      [0,0],
      [0.1,0.1],
      [0.2,0.2],
      [0,1],
      [1,1],
      [1,0],
      [0,0]
    ]
  ],
  "type": "Polygon"
}

If you feed it today, if i understand correctly, it will generate:
MoveTo[0,0]
LineTo[0,0] <- noop
LineTo[0,0] <- noop
LineTo[0,1],
LineTo[1,0],
LineTo[0,-1],
LineTo[-1,0]

if the loop I pointed to skipped such dx,dx==[0,0] then, correct me if i am wrong, you should get:
MoveTo[0,0]
LineTo[0,1],
LineTo[1,0],
LineTo[0,-1],
LineTo[-1,0]

and thus you have reduced the number of points if the zoom-informed scaling has floored some of the neighbours to the same int. Which is down-scaling case we care for. Of course this may turn out to be insufficient, but seems like the first useful thing to do. But like i say, i am not a tiling expert.
Thanks again.

Sorry, I was not being very clear in my statements. We did not see a significant amount of point reduction compared to simplification.  In fact part of the makeValid I do this very thing. Just not in encode cmd, though as you correctly point out it would be a noop. So, I will put this back in. But, there are features which are detailed for the low zoom levels that are reduced significantly with Douglas–Peucker to make sense to have simplification. However, if a feature is already simplified the simplification can have an adverse effect on the geometry of the feature.  The other simplification method  (#166) may actually help with this as it works off the largest area instead of a threshold of a distance from a line. We, also, have #165 for plumbing through simplification. Did you use the environmental variables to disable the simplification or did you change out the encoding to skip if dx and dy are zero?

Did you use the environmental variables to disable the simplification or did you change out the encoding to skip if dx and dy are zero?
Well, i discovered this:

DontSimplify: true
&tegola.BoundingBox{Z:... which i guess you need to document (show in the example)

I think it makes a hygienical sense to skip the [0,0] noops and i am not surprised this doesn't serve as sufficient simplification. I am surprised by the very bug and Douglas-Peucker seemingly cutting a distant and crucial aspect of the polygon. Maybe you can simplify skipping the bleed buffer?
thanks again!


Unpin from requests 2.21.0

Version 2.21.0 was released in 2018. Pinning the package to it creates dependency issues since other packages, such as urllib3, can't be updated past a certain version due to this constraint.
This PR opens this up to 2.2x since that picks newer versions but also steers clear of major updates. As of this writing, the latest version is 2.28.1

Excellent submission @kakoma a few issues from the CI report. Valid? CC @mossplix

@raybesiga Thanks. I see this in the failure log:
src/mtnmomo/collection.py:56: in requestToPay
    "Ocp-Apim-Subscription-Key": super(Collection, self).config.collectionsKey
src/mtnmomo/config.py:80: in collectionsKey
    "COLLECTION_PRIMARY_KEY is missing in the configuration")

Haven't follow-through to see what's at the root of this but maybe the team might see something immediately, just looking at it? I'm not able to dig further into it at this point unfortunately

We no longer maintain this library but will see if I can get the requisite support in due course @kakoma


Adding ability to parse Accept headers of different formats

Adds ability to override the accept header subtype validity check by passing a regex in registration options.
Adds ability to override the functionality for version extraction from the header.
Motivation for the addition of these overrides:
We have multiple apps running on different frameworks and we are wanting to get the version string in the Accept header to be consistent across the apps.
For instance we have a hapi app that looks for an Accept header like the following: application/vnd.myapi.v2+json
And we have a rails app that is looking for an Accept header like the following: application/vnd.myapi+json; version=2
Example of options added that would allow an Accept head like the following
application/vnd.myapi+json; version=2
{
  acceptHeader: {
    subtypeTest: /^vnd.[a-zA-Z0-9]+$/,
    extractVersion: function (media) {
      return media.parameters.version;
    }
  }
}

Thanks for your PR. I will look into it in more detail on this weekend...

I reverted the merge of your PR because I recognized it does not take the vendorName option into account. It actually becomes obsolete by your PR and the plugin would not be backwards compatible anymore.

I'm not following how the plugin is not backwards compatible after the changes.  Could you elaborate?

Your changes ignore the vendorName option. Also this option is a required one and has to be specified. If someone relies on this option it is just not taken into account - so not backwards compatible.

The vendorName is still being checked as it is in the current version https://github.com/p-meier/hapi-api-version/pull/5/files#diff-168726dbe96b3ce427e7fedce31bb0bcR49.  Are you saying that the vendorName option would logically need to be grouped with subtypeTest and extractVersion under acceptHeader in the options and that would be a breaking change?
Do you have suggestions on how this functionality could be added in a backwards compatible way?

Sorry. You are right - I just looked at the changes not thorough enough. So this is not a breaking change.
But it still does not feel right. First I think as you already suggested that vendorName should be under acceptHeader. Second I don't like to specify both (vendorName and subtypeTest) when overriding the defaults - specifying subtypeTest should be enough in this case. Here an example of what I have in mind...
Options - using defaults
Specifying the vendorName should be enough.
{
   acceptHeader: {
      vendorName: 'mysuperapi'
   }
}

Options - override
The vendorName is not needed as it should be part of the subtypeTest (something like /^vnd\.mysuperapi\.v[0-9]+$/).
{
   acceptHeader:{
      subtypeTest: /^vnd.[a-zA-Z0-9]+$/,
      extractVersion:function (media)      {
         return media.parameters.version;
      }
   }
}

What do you think?
Also the documentation, example and tests need to be updated.


Pdf renders with artifacts on chrome 113 + Android 13 + Samsung

Attach (recommended) or Link to PDF file here:
https://mozilla.github.io/pdf.js/web/viewer.html
Configuration:

Web browser and its version: Chrome 113.0.5672.134
Operating system and its version: Samsung, Android 13
PDF.js version: N/A, persists on the demo
Is a browser extension: No

Steps to reproduce the problem:

Go to the preview (linked above) using one of the devices

What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)

I do not have an actual image from the preview but the same issues as above appear in it. some pages are blank, a lot of things are black.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
We have tried on the following devices without issue:
Nokia G21 - Android 13 - Chrome 113.0.5672.134
Samsung S9 - Android 10 - Chrome 113.0.5672.134
iPhones in general
The following devices had the issue:
Samsung Galaxy S21 Ultra - Android 13 - chrome 113.0.5672.134
Samsung Galaxy S20 - Android 13 - chrome 113.0.5672.134
The issue was first shown in our system. We then discovered it on the pdf preview on github which shows that its an issue with pdf.js and chrome.

This is slightly confusing, since the PDF document from the screen-shot doesn't actually appear to be included anywhere in this issue.
However, if you actually mean that even https://mozilla.github.io/pdf.js/web/viewer.html (with its default tracemonkey) is broken then that most unfortunately suggests a problem related to e.g. the platform, browser, and/or graphics-driver rather than a bug in the PDF.js library/viewer itself.

@Snuffleupagus Here's an image from the preview:

As said by @Snuffleupagus, it's very likely a chrome issue, so file a bug in the chrome bug tracker:
https://bugs.chromium.org/p/chromium/issues/list
You can try to open https://mozilla.github.io/pdf.js/web/viewer.html in Fenix and see if the rendering is wrong or not: if it's please file a bug in Firefox bug tracker:
https://bugzilla.mozilla.org/enter_bug.cgi?product=Fenix&component=General


Compatibility with Python 3.7

I would like to point out that async queries with datalab do not work with Python 3.7 since in this version async is a reserved keyword (Summary – Release Highlights).
The issue was also reported in the old datalab-client github page (issue 2).
It could be useful to emphasize this incompatibility in the README of the repository and possibly in the documentation.
Thanks for your time.

Async does work. Please be sure to have the latest version of the 'datalab' command:
$datalab version
Task Version:  2.16.0
With it, make sure you are logged in:
$datalab whoami
If it is 'anonymous':
$datalab login
Then, for instance:
$datalab query --sql='select ra,dec from smash_dr1.object limit 10' --async=true
returns a jobID. After a few seconds, check if async job is completed:
$datalab qstatus --jobID=foobar # use the jobid returned previously
and if that is 'COMPLETED', you can retrieve the results via:
$datalab qresults --jobID=foobar # again use previous jobID string.
Please let us know if you still experience trouble.

I did not notice that I had another version! Now it works as I expected. Thanks for the help.


Local NPM Install Fails

Issue report
Running npm i in the project locally on windows fails.
Expected Behavior
npm i successfully installs dependencies
Current Behavior
npm i fails to install dependencies. Specifically Chromium

Possible Solution

Don't use Windows to develop ODS projects

Steps to Reproduce (for bugs)

Open GitBash (Windows 64bit)
Navigate to freshly cloned ODS Button repo
Run npm i
Observe Chromium failed to install

Context
I wanted to contribute to ODS button, but I can't run locally to verify development changes.
Your Environment

Version used: Commit 1e38d96
Browser Name and version: N/A
Operating System and version (desktop or mobile): Windows 10 (desktop) + Git Bash + Hyper.js
Link to your project: OrionStatelessComponents__ods-button

This is an issue I am digging into. There is an issue with PUPPETEER and installing CHROMIUM. There seem to be scenarios where CHROMIUM fails due to network restrictions.
There is not a bug in the code. If you choose other than an internal network connection, mac or windows, it will install as expected.
The only solution I have come up with so far may be related to this issue:
https://github.com/GoogleChrome/puppeteer/issues/2262

I am going to close this issue as it's been temp resolved by removing this dependency.


WIP: add travis testing and new tool installation method

Greg you need to activate travis testing in the github preference setting of this repository. If you do this every additional modification will be tested automatically.

Greg for some reason the installation from the testtoolshed is broken. I added a random tool from the toolshed and this works. So this is just a WIP.

Thanks for taking a look at making this work @bgruening!  Please let me know if there is anything I can do to help out.

Any reason all these packages are not in MTS?
Do you follow TS development and maybe have any hint why installation over the API seems to be broken in TTS?

There are a few things we want to improve in the underlying icqsol package before we move these to the MTS.
I try to follow TS development, although I'm not aware of much that is happening outside of planemo, so maybe I've missed some things.  For the past several weeks I've only installed from my local TS and the Mts and I have not been using the API for installations.  I was installing from the TTS until about the middle of January and don't remember any problems, but I wasn't using the API then either.  So unfortunately I'm not sure when the installation API was broken.  :(

@bgruening I've set up Travis testing for this repository.  I've also made you a collaborator in case that helps.  Thanks for your help with this!

thanks @gregvonkuster!
@davebx do you know what was introduced in the TTS which prevents from installing via the API?

@gregvonkuster travis does not seem to be enabled and I can not change the setting for this repo.
Nevertheless, I don't think these changes will break anything that has worked before. But would be nice to get testing enabled.


[Feature Request] Annotation Region Support

I wanted to add a feature request to add support for annotation regions from clickhouse plugin.
More details are here
Annotation Regions
It would be great to see deployment job start and end as a region along with the metrics rather than individual events.

@mohnishkodnani could you check latest master version? feel free reopen issue if you find any bugs


[DNM] [RFC] drivers: counter: API proposal unifying counter and rtc drivers.

Proposal of the API that would unify rtc.h and counter.h. It is based on existing counter.h and is backward compatible (counter_set_alarm renamed to counter_set_overflow, compatibility define added).
See related issue: #8331
API proposal extends counter.h API by:

adding function for triggering single shot alarms with relative and absolute value
allowing multiple single shot alarms (utilizing multiple capture/compare channels)
clarifying former counter_set_alarm behavior which had vague description and was usually interpreted as periodic overflow (impacting maximum value that can be read by counter_read() ). Renamed to counter_set_overflow().
adding functions for converting milliseconds and microseconds to ticks.

Signed-off-by: Krzysztof Chruściński<EMAIL_ADDRESS>

This change is

CC: @nvlsianpu @kl-cruz

cc @cvinayak

Codecov Report

Merging #8340 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8340   +/-   ##
=======================================
  Coverage   64.53%   64.53%
=======================================
  Files         422      422
  Lines       40265    40265
  Branches     6797     6797
=======================================
  Hits        25986    25986
  Misses      11157    11157
  Partials     3122     3122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a96f2b...96c1430. Read the comment docs.

Can we make some of these APIs available to user mode?

@andrewboie: How do you see handling that in the userspace? Are you thinking about interrupt-like interface (similar to Unix signals) or just about ability to wakeup a thread when event will be emitted?

@andrewboie: How do you see handling that in the userspace?

Same APIs just write handlers for those APIs which can be exposed to user mode. There's lots of example of this in the other driver subsystems.
Looking at this API, you could expose all the APIs which don't take callback functions or struct counter_single_shot as parameters (since we don't allow registering callbacks which run in IRQ context from user mode).
Don't need to do it in this PR, can leave for another day.

I am considering the fact that we may get rid of the ticks/count exposure altogether. Instead user would provide 1 unique parameter: time. Time is something generic that user understands, and thus would not have to manage ticks directly. We have to get decided on µs or ms. I guess there is a use-case for µs so we would have to stick with it, and thus maybe u64_t. Function could return -ERANGE if really it can't handle given time (i.e.: time to ticks below in driver overflows). What do you think?

Time is valid for timer, which is a counter counting clock cycles. But counter could also count some other things. If we would like to have unified API for all type of counters (including timers), we will have to provide access to raw ticks.

Pushed update:

changed counter_us_to_ticks to get u64_t us parameter. Removed counter_ms_to_ticks.
renamed counter_set_single_shot to counter_set_alarm. Changed a bit functionality: alarm parameters contain now duration and period instead of ticks (similar to k_timer_start). So alarm can be single shot or periodic, kept abs flag.

Wonder if the drivers should set a few things like num_counters, and a features bitmask that the counter core would use.
So something like counter_count_up would become:
if (dev->feature & COUNTER_HAS_COUNT_UP)
  return true;
else
  return false;

Do we have any tests for the new apis?

What's the expected mapping of counter to device?  For example, on NXP hardware there is a PIT that has 4 timers, would that be 4 devices, or 1?

@galak, regarding:

if (dev->feature & COUNTER_HAS_COUNT_UP)

I also thought about it but to make that generic it would require change in struct device (one field added). Meanwhile, I will try to make something counter specific. If parameters like frequency, max wrap, count_up, number of channels are defined in API then some functions might be implemented in the header.

include/counter.h, line 217 at r1 (raw file):
Previously, galak (Kumar Gala) wrote…
Confused, is this setting the wrap value, or registering a callback for when wrap occurs?

it's both, however handler might be set to NULL, then function only reconfigures wrap value.

include/counter.h, line 232 at r1 (raw file):
Previously, galak (Kumar Gala) wrote…
this seems not orthogonal with counter_get_wrap()

renamed to counter_set_wrap_alarm()

include/counter.h, line 60 at r1 (raw file):
Previously, galak (Kumar Gala) wrote…
can we add comments about the units of ticks and period.

I've added more description

include/counter.h, line 54 at r1 (raw file):
Previously, galak (Kumar Gala) wrote…
wonder if abs is a bad name, because of stdlib function.

changed to absolute

What's the expected mapping of counter to device

I think each peripheral is one instance so in case of nxp twith 4 timers thats 4 devices.

No, it's one device with 4 channels. Can we add the concept of multiple channels to the API? We've already done this for the watchdog API, for example.

@anangl @pizi-nordic I've applied your comments.

Moved property reading functions above function which call provided api. Added channel limit check to static inline functions in api header (counter_set_alarm and counter_disable_alarm).

with #8743, #9276 and #10025 in review, we are missing port of rtc_mcux.c and rtc_ll_stm32.c

@agross-linaro Can you take a look to make sure this matches with the RTC support you added.

This looks ok.  In some hardware, the RTC is really just a counter, so they can almost be used synonymously.  While these changes capture the frequency, there are some implementation that only increment a register with a 1 second resolution.  They may have a second register that gives some notion of sub second resolution.

updated PR with implementation for nordic RTC and TIMER peripherals. Added counter API tests.

tests/drivers/counter/counter_basic_api needs updating to be able to run for other drivers.  ie it looks like there are assumption on the number of counters in the prj.conf

@galak, i took the approach from adc tests and add boards folder with custom configuration per board (timers and rtc's enabled).
Branch is rebased on latest master.

@nordic-krch : Please rebase your commits on top of master, you seem to have a merge in this branch.

@aescolar, it's rather that PR is to topic-counters branch which is not rebased on master, and i've rebased mine branch since i've missed that PR changed target branch. We need to rebase topic-counters on master (topic-counters has no changes compared to master).

@nordic-krch I've now updated topic-counters with master, but the commits here still show up. If you can address the comments that are outstanding in this PR and send a new one against topic-counters that includes the following:

New API
Removal of old API (so we see which drivers are failing)
nRF implementation of the new API
Tests

recheck


Some packages are not loading

First a disclaimer, I'm new to emacs, so maybe I'm doing something wrong.
Anyhow, when i start my emacs, some packages are not loaded, such as counsel. so by trying M-x i get
Wrong type argument: commandp, counsel-M-x
From what i could understand, you are lazy loading most of the packages, and counsel simply isn't loaded, if i change :after ivy to simply :demand t it works just fine. But i didn't want to lose lazy loading and what i did is use :commands (counsel-find-file counsel-M-x etc...) and that worked for me. But the same thing happen with company-anaconda where i wouldn't get any language completion, only words from the buffer where i typed in, and if i change :after ... to :demand t it works just fine.
So I'm wondering, is this a bug? maybe misuse on my part? should i just ditch lazy loading and go for :demand t as that works just fine
I am using
GNU Emacs 25.3.1
Arch Linux 4.14.3
and all i did was copy init.example.el to init.el, run :
make install
make update
make compile-core
Tnx for all the hard work :)

:demand t shouldn't be necessary, ivy is loaded immediately, therefore counsel should be loaded immediately after. That said, adding :demand t won't hurt either, if that's what got it working for you.
However, this could indicate that something else went wrong before counsel could load. Have you checked the *Messages* buffer to see if any errors crop up (M-x view-echo-area-messages)? Or M-x list-buffers to see if a *Warnings* buffer silently appeared?

I just checked, there are no errors at all. If counsel was the only package affected i wouldn't mind having that on :demand t but i don't relay need company-anaconda to load every time as i won't be editing python all the time, and i didn't relay test this much, but chances are that more packages are affected, maybe I'm missing something here, but it sure seems like :after ... hook doesn't work :/

Could you check to see if use-package-keywords contains the :after keyword (with M=x describe-variable RET use-package-keywords)?
Could you also try replacing the :after ... with :requires ...?

use-package-keywords does contain :after and changing it to :requires makes no difference

Turns out, as of recently, this is expected behavior for use-package.
You may use :demand t in that case. This has some farther-reaching implications for Doom that I will address more comprehensively by 2.0.8. I'll leave this open until it's fixed.

I can confirm that replacing :after ivy with demand t fixed it for me.
# ~/.emacs.d/modules/completion/ivy/config.el

(def-package! counsel
  :demand t
...

After reading this https://github.com/jwiegley/use-package/issues/562 it seem that old approch worked becouse of the bug, all that needs to be done is add :demad t after :after ...., as it will load that package only after condition is met . So it still is lazy loading. I've tested this with python-mode and it worked, anaconda-mode and company-anaconda are loaded only after python mode

I've made some big changes, mainly centered around setting use-package-always-defer back to its default (nil). Something I've meant to do for a while.
It is in develop while I test it, but should resolve your issue.
@bondzula I've found another solution to the problem, but thanks for explaining it to me. That makes sense.
I'll keep this issue open until the fix has be merged into master.

This is now in master, so I'll consider this issue resolved. Cheers!


Provide PR template

Provide PR template that mentions to to update Helm chart version

Should we do this or do we always update versions @ahmelsayed? Maybe best to skip?


fix(accordion): now accepts expandable props per API (#945)

Fixes #945
Description
Expandable props when passed did not behave according to the API docs.

Scope

[x] Patch: Bug Fix
[ ] Minor: New Feature
[ ] Major: Breaking Change

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Choong Kim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @zebralight this was intentional when using the stateful accordion. I suggest using the Accordion component to manage the state yourself if you want that control. Take a look at this code sandbox for an example. https://codesandbox.io/s/6wlzyrx8mn
Going to close this pr, put feel free to continue the thread with questions


Feature/id and json link name

I've not personally used git sub-modules before, so I'm going to do some more research and have a play before merging this, but my initial impression is it looks good. The only small comment is I'd prefer not to check in IDE files like eclipse project config (everyone uses a different IDE).

My bad, I brought in contents of pull request #21 as well.
I have a comment there about eclipse config. I understand that having these in the repo is a matter of taste.

Sorry it's taken so long but I've had time to play around with git submodules now (and I like them). If you can remove the eclipse specific stuff then I'll merge this.


Add Documentation for Loops Destination

Proposed changes
Added documentation for the Loops destination.
Merge timing
ASAP once approved

Hi @askkaz @danrowden - thanks for submitting a docs PR! Unfortunately the branch used to open this PR has organizational branch protections, so I am unable to make any edits. We opened a new, editable PR (#5455) where we'll continue reviewing your docs!


java.security.AccessControlException for loadlibrary

@luben while trying to integrate zstd into apache lucene, i got following error in running a simple unit test case
java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "loadLibrary./home/praveen/Documents/lucene-development/lucene/lucene/codecs/build/tmp/tests-tmp/libzstd-jni168266960372894918
is this a known issue?

The tmp folder has to have permissions to load native libraries from it.

@praveennish  Hi, praveennish, how to give  permission via policies in lucene project?


For/While loop struggles with async calls

I am trying to check element on regular interval and click only if it is present. Some times this element appears in 2-3 minutes. If it is not present, i want to wait for few seconds and then refresh page
Here is what i tried:
for(var i = 1; i < 60; i++){
    element(that.proposalByOrderPath(num)).isPresent().then(function(result){
        if(result){
            console.log(i);
            return element(that.proposalByOrderPath(num)).click();
        }
        else{
            browser.sleep(15000);
            browser.refresh();
       }
    });
}

As an output, it prints 60 twice. It clicks on the element once but tries to look again for the element and throws "element not visible" error.

isPresent just checks that an element is on the page.  It looks like in your example the element is present but not visible.  You'll probably want to check out ExpectedConditions and visibilityOf.
You're getting 60 twice because by the time console.log(i) gets called the for loop has run all the way through.  This is a common weird case of using callbacks inside of loops.

@sjelin element is present and visible, because it clicked on the element and again looking for it and at last gives not found error.

I don't know the details of why the element isn't clickable after the first two times.  I'd have to be actually debugging your app.
As for loops/callbacks, I'd check out the explanation here: http://www.apaxsoftware.com/2012/05/common-javascript-mistakes-loops-and-callbacks/
Also, please ask questions like this on StackOverflow.  GitHub issues are more for bug reports & feature requests and the like.


SQLite blob problem

Hi,
When I was trying to insert some blobs in a SQLite database I noticed some strange behaviours.
First I tried with this DDL:
CREATE TABLE temp (
	mydata BLOB
);

And this happened:

I modified the DLL to:
CREATE TABLE temp2 (
	id INTEGER,
	mydata BLOB,
	CONSTRAINT TEMP2_PK PRIMARY KEY (id)
);

And apparently everything was ok:

But after a refresh the field was NULL:

DBeaver version: 3.5.4 and 3.5.6.

I had no problem using the CLI SQLite (version 3) to save blobs.

Using MySQL + dbeaver I had no problem too.

I made a small program in Java to insert a sample image:
https://github.com/leonelfreire/testsqlite
And the results:

But the same happens if I try to insert a new row using dbeaver:

It is a bug in SQLite driver + DBeaver misfunction.
SQLite driver silently does nothing when DBeaver tries to set BLOB value. As see from Xerial JDBC source code they added exceptions in non-supported API functions. So after next Xerial driver release this issue will be fixed automatically. Current Xerial version is <IP_ADDRESS> (https://github.com/xerial/sqlite-jdbc).
Additionally I'll fix LOB handler in DBeaver. Fix will be in 3.5.7 version.
Thanks for report.

Thanks for your attention.


As a student, I want to drop a course I am enrolled in because I changed my mind and don't want to participate in this course anymore.

duplicate US


Device Tracker

Describe the feature
It would be nice if there was a entity that could take the in the distance and the bearing so this could be plotted onto a map:
so you could see excatly where the heading and the distance would be.
Home Assistant version
No response
Integration version
No response
Acknowledgements

[X] I have searched this repository and API Repository to see if the feature has already been requested.
[X] This featre request is sepecific to the HA Integration.
[X] I have written an informative title.

This is a really clever idea.  I know it can be in bad form to do this, but I really like this and would like to see this at some point.
One thing to consider is capping the number to the nearest 10 storms.  Or something like that.  But I would be happy with anything here.
That said I wonder if there's a way to implement this using templates in HA Core.

Looks like this one got missed as well. Just to be clear you're looking to plot the distance/bearing on a graph to visualise which way a storm is heading?
I'm not totally sure what is 100% possible in HA so will defer to @alexander0042 to see if this would be possible

I assume that's what the OP is saying.
I think it would be one of those things where you'd use the device_tracker and map functionality.  You can give a device_tracker entity GPS coordinate
It could look something like this:

Spot on, this is exactly what is required.

Sorry for never replying to this, was focused on getting some critical historic data stuff working. The good news is that I got this working using the excellent virtual devices add on! I wrote it up as I was doing it, so let me track that down

Depending on how many locations you're trying call for at once, the default 15 minute call should fall well within the free tier, so hopefully that's ok!
The way I got it working was to create a virtual_tracker.yaml file, which when loaded with that integration provides a virtual device that can move around to show the nearest storm on a map. The file is pretty basic, with these contents:
version: 1
devices:
  Test Device_Tracker:
   - platform: device_tracker

Then, I made a new automation using this yaml:
alias: Storm Device Move
description: ""
mode: single
triggers:
  - entity_id:
      - sensor.pirateweatherc_nearest_storm_distance
    trigger: state
  - entity_id:
      - sensor.pirateweatherc_nearest_storm_bearing
    trigger: state
conditions: []
actions:
  - variables:
      current_lat: "{{ state_attr('zone.home', 'latitude') | float * (pi / 180) }}"
      current_lon: "{{ state_attr('zone.home', 'longitude') | float * (pi / 180) }}"
      distance_km: "{{ states.sensor.pirateweatherc_nearest_storm_distance.state }}"
      direction_deg: "{{ states.sensor.pirateweatherc_nearest_storm_bearing.state }}"
      earth_radius_km: 6371
      direction_rad: "{{ direction_deg | float * (pi / 180) }}"
      new_lat: >-
        {{ (asin(sin(current_lat | float) * cos(distance_km/earth_radius_km) +
        cos(current_lat | float) * sin(distance_km/earth_radius_km) *
        cos(direction_rad))) * (180 / pi) }}
      new_lon: >-
        {{ (current_lon | float + atan2(sin(direction_rad) *
        sin(distance_km/earth_radius_km) * cos(current_lat | float),
        cos(distance_km/earth_radius_km) - sin(current_lat | float) *
        sin(new_lat))) * (180 / pi)  }}
  - target:
      entity_id: device_tracker.test_device_tracker
    data:
      gps:
        latitude: "{{ new_lat }}"
        longitude: "{{ new_lon }}"
    action: virtual.move

It assumes

Your Pirate Weather integration is named "pirateweatherc".
The units for the integration are in si
Your device tracker is called "test_device_tracker"

The automation is triggered every time the nearest storm distance or bearing changes, and calls a service to update the location of the device tracker, giving me a map that looks like this:

I'm very open to adding this directly into the integration somehow; however, it would be a little bit of work. The data is definitely there, but because device trackers look reasonably complex, it's not a trivial thing.

nice work!
I'll be traveling for work this week so i'll have some downtime in the hotel to take a look this week hopefully.


ci: update release workflow ubuntu version

resolve https://github.com/fermyon/spin/issues/708

I'm pretty sure this will have broken release binaries on older Linux distros like Ubuntu 18.04 (which is still under LTS). We can talk about what kind of support we want but this was part of the reason for remaining pinned to the old version.

Oh! Sorry! I didn't know this doesn't work on Ubuntu 18.04. I moved the binary from 22.04 to 18.04. It doesn't work. @vdice do we want to revert this? Thanks.
# Ubuntu 18.04
$ spin --version
spin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.29' not found (required by spin)
spin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by spin)
spin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by spin)
spin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by spin)
spin: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by spin)


Atum 1.19.2, 1.19.4 & 1.20.4 crashes on resetting with hotkey

Pressing the reset hotkey crashes the game on 1.19.2, 1.19.4 & 1.20.4, resetting by clicking the menu button works fine.
Probably all versions 1.19-1.20.4 do this, but these are the only versions I tested.
Tested with:
atum-1.2.1+1.19.2.jar
atum-1.2.1+1.19.4.jar
atum-1.2.1+1.20.4.jar
Fabric Loader 0.15.6
Java 20.0.1
With no other mods
Crash log (1.19.2)

this is probably because they changed the KeyOptionsScreen to be separate ControlsOptionsScreen, so i'm doing the wrong cast. thanks!

fixed


add gfortran to clang compiler

quickest way I could think of to set the Fortran compiler for clang builds
should fix the clang-libstdcxx build over at https://github.com/ruslo/hunter/pull/898#issuecomment-317642751

Closing for https://github.com/ruslo/polly/pull/163


Upgrade for 3.x

Hi all. I know a plugin such as this is not a high priority development, but is there any chance you're going to release a version for 3.x?  I want what this plugin does in my project, but don't want to reinvent the wheel (and don't stand much of a chance of being able to do it myself).
If not, no worries, but I thought I'd open an issue nonetheless.

Hi @vaughany, this issue will be being discuted internally and I will let you know as soon as possible.
Thanks.

HI @vaughany this upgrade is on hold by us yet, but if you want to do this you can go ahead. You can fork our repo and to do a PR with the upgrade for us.
By any doubts, pĺease let us know.

Closing issue - Please re-open if necessary!


User Experience:  in Notebooks

Why
question_the_docs.ipynb
The notebook is based on the assumption that OpenAI keys are provided as environment variables.
However, this is not the case for demo. We need to provide at least one way for the user to use its own credentials.
e.g (but not 100% correct)
# Use your credentials
%env OPENAI_API_KEY=<your_key>

if 'OPENAI_API_KEY' not in os.environ:
    raise Exception('Environment variable "OPENAI_API_KEY" not set')

How
No response
What

[ ]

Fixed by https://github.com/SuperDuperDB/superduperdb/commit/a4433a008b808d6ffa8bcdba0cc6adecbe74185c