Support for OData aggregations

Hi, I am creating a new issue since I cannot reopen #138.
In the metadata of my service, the container has the ApplySupported annotation. More precisely, it looks like this:
<EntityContainer Name="Container">...</EntityContainer>
<Annotations Target="test.Container">
     <Annotation Term="Org.OData.Aggregation.V1.ApplySupported">
            <Record>
                   <PropertyValue Property="PropertyRestrictions">
                         <Bool>false</Bool>
                   </PropertyValue>
            </Record>
     </Annotation>
</Annotations>

According to the OData specification, this means that all aggregations are supported for all properties. However, if I do a Group by in the Power BI query editor, the "groupby" is not pushed down to the OData service. Am I missing something?

Hi, this is the query displayed in the Power BI Editor:
let
    Source = OData.Feed("http://localhost:8070/odataweb/DataService.svc/", null, [Implementation="2.0"]),
    BaseAsset_table = Source{[Name="BaseAsset",Signature="table"]}[Data],
    #"Grouped Rows" = Table.Group(BaseAsset_table, {"ItemGroupRef"}, {{"NumberAssetsPerGroup", each Table.RowCount(_), type number}})
in
    #"Grouped Rows"

This results in a request to the OData service that contains no apply option. The request is simply something like
http://localhost:8070/odataweb/DataService.svc/BaseAsset

The metadata of the entity type "BaseAsset" is as follows:
<EntityType Name="BaseAsset">
   <Key>
      <PropertyRef Name="Syscode"/>
   </Key>
   <Property Name="ItemGroupRef" Type="Edm.Int32"/>
...
   <NavigationProperty Name="ItemGroupRef_ItemGroup" Type="test.ItemGroup">
      <ReferentialConstraint Property="ItemGroupRef" ReferencedProperty="Syscode"/>
   </NavigationProperty>
</EntityType>

(The navigation property bit is probably irrelevant, but I added it for completeness.)

Hi, thanks for the answer. Is there a plan to support more aggregations in the (hopefully) near future?

So, if I understand correctly: according to the ODATA specs these features can be supported
http://docs.oasis-open.org/odata/odata-data-aggregation-ext/v4.0/cs01/odata-data-aggregation-ext-v4.0-cs01.html#_Toc378326289
But PowerBI  currently only supports the aggregation methods List.Average, List.Max, List.Min, and List.Sum. So no groupby, and no aggregate count?

There's definitely some support for groupby in the codebase. If you have a case where you think it's not working, please capture a Fiddler trace of the interaction (including the metadata document and any other requests to the server) along with the M query you're trying and send those to us.

Yes, I can confirm that I get folding of groupby.

I tried to add annotation to the entity sets without luck, but when adding the annotation to the entity container PQ started folding the query:


asteroid.userId gives inconsistent returns

Hello, Notice the line Users.methods.usAuthed() and you can see that its calling  !!asteroid.userId . My login form works fine, but I'm trying to make a react-router authorization wall which means the router will load the component when the authorization check returns true.
I've investigated further and Users.methods.usAuthed() returns false after passing a 404 url matching this guide: https://reacttraining.com/react-router/web/example/no-match
/src/components/PrivatePage.tsx
// almost identical to ./PrivateRoute.tsx

import * as React from 'react'
import { Redirect, Route } from 'react-router-dom'
import User from '../data/users'
import Page from './Page'

const PrivatePage = ({ component: Component, ...rest }) => (
  <Route {...rest} render={props => (
    User.methods.isAuthed() ? (  **// after page 'notFound' this returns false**
      <Page>
        <Component {...props}/>
      </Page>
    ) : (
      <Redirect to={{
        pathname: '/redirect',
        state: { from: props.location }
      }}/>
    )
  )}/>
)

export default PrivatePage

/src/data/users.tsx
import asteroid from '../asteroid/'

interface IUsers {
  methods: {
    isAuthed: () => boolean
  }
}

const Users: IUsers = {
  methods: {
    isAuthed() {
      const result = !!asteroid.userId
      console.log({isAuthed: result})
      return result
    }
  }
}

export default Users

/routes/App.tsx
import * as React from 'react'
import { Route, Switch } from 'react-router-dom'

import PrivatePage from '../components/PrivatePage'
import Login from './accounts/auth/'
import About from './root/About'
import Home from './root/Home'
import NotAuthorized from './root/NotAuthorized'
import NotFound from './root/NotFound'

interface IProps {}
interface IState {
  isAuthorized: boolean
}

class App extends React.Component<IProps, IState> {
  render() {
    const Content = () => (

        <Switch>
          <Route path='/login' component={Login}/>
          <Route path='/redirect' component={NotAuthorized}/>
          <PrivatePage
            path='/'
            component={Home}
            exact={true}
          />
          <PrivatePage
            path='/about'
            component={About}
          />
          <PrivatePage component={NotFound}/>
        </Switch>

    )

    return (

        <Content />

    )
  }
}

export default App

Posted to SO: https://stackoverflow.com/questions/45738542/react-router-nomatch-causes-asteroid-userid-to-return-falsey

I think that this is because the express server hiccups b/c universal routing isn't setup.

I think that this is because the express server hiccups b/c universal routing isn't setup.


responded to reviewer comments and added picture for smiles.

--> Please remove all this text before submitting your PR, it's just a checklist to help you :) <--

Give your pull request a good title

e.g. "Fix typo in ansible-galaxy tutorial" or "Add new transcriptomics tutorial covering a new sequencing technology"

Describe your changes in detail, list anything you still need some help with or things that are still TODO
Check that your images are allowed to be re-hosted by the GTN!
Still working on it? Make it a Draft pull request

Once it is ready, choose Ready for Review
Then the automated tests will run and we will know to review and merge it

@wee-snufkin this is ready to be merged :)

merged, thanks for the updates!


Docs aren't published since v4.4.0

The docs hosted at https://www.ember-bootstrap.com/ haven't been published anymore since v4.4.0:
// developers tools when running https://www.ember-bootstrap.com/
JSON.parse(
  decodeURIComponent(
    document.querySelector('meta[name$="config/environment"]').content
  )
).APP.version // "v4.4.0+19ded703"

The build is timing out in CI:

https://github.com/kaliber5/ember-bootstrap/runs/1493307110 (v4.5.0)
https://github.com/kaliber5/ember-bootstrap/runs/1627376802 (v4.6.0)
https://github.com/kaliber5/ember-bootstrap/runs/1664220607 (v4.6.0 restarted just know)

I tried to run yarn run docs:build locally but also got stucked with the same output.

Thanks for reporting, will try to look into this...

Thanks for reporting, will try to look into this...

Should be fixed by #1514. But I would propose to keep this one open until it has been deployed successfully.

Just released v4.7.0, and docs were successfully deployed. So closing this.
Unfortunately there is a regression, also visible in the docs, will try to fix this asap: #1518.


adding winter time correctly in the profile

in the hour of year profile for icon
in the three profiles define whether you want summer time or winter time

It seems that at the moment we simulate only winter time

32f9648483d44b3e9b23e1f3c3ca064d738367dd
Now fixed by using proper timezones when creating icon time profiles


Support Minimal theme line width

Currently, the plugin adjusts the --file-line-width SASS variable. It seems that the Minimal theme relies on the --line-width variable, instead.
This PR introduces two new lines which, in addition to the existing --file-line-width SASS variable, adjust the --line-width variable.
I've tested this on my local Obsidian instance and it seems to work.

Currently, the plugin adjusts the --file-line-width SASS variable. It seems that the Minimal theme relies on the --line-width variable, instead.
This PR introduces two new lines which, in addition to the existing --file-line-width SASS variable, adjust the --line-width variable.
I've tested this on my local Obsidian instance and it seems to work.

It's helpful, thank you very much!


Many continuous spaces provokes a crash in 7.1.6

I have some texts that present many continuous space characters. Since I upgraded markdown-to-jsx to version 7.1.6, parsing these texts crashes the app.
I did some tests and this is what I came up to :

With ~70 continuous spaces, the app starts to noticeably slow down.
Adding a bit more spaces provokes the crash.
It seems to be specific to spaces. I tried with other characters without any issue.
this is specific to 7.1.6, older versions work fine.

also 7.1.7

Downgrading to 7.1.5 did not work :(

also on 7.4.0


Run on Arch Linux fails with 'attempt to subtract with overflow' error

I was running the code of the reddit post but it failed
use speedy2d::Window;
use speedy2d::window::{WindowHandler, WindowHelper};
use speedy2d::Graphics2D;
use speedy2d::color::Color;

struct GameWindowHandler{}

impl WindowHandler for GameWindowHandler {
    fn on_draw(&mut self, helper: &mut WindowHelper, graphics: &mut Graphics2D)
    {
        graphics.clear_screen(Color::from_rgb(0.8, 0.9, 1.0));
        graphics.draw_circle((100.0, 100.0), 75.0, Color::BLUE);

        helper.request_redraw();
    }
}

fn main() {
    let window = Window::new_centered("Cube army", (640, 489)).unwrap();

    window.run_loop(GameWindowHandler{});
}

backtrace:
thread 'main' panicked at 'attempt to subtract with overflow', /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/window.rs:643:39
stack backtrace:
   0: rust_begin_unwind
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:495:5
   1: core::panicking::panic_fmt
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/panicking.rs:50:5
   3: speedy2d::window::position_window
             at /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/window.rs:643:39
   4: speedy2d::window::WindowImpl<UserEventType>::new
             at /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/window.rs:403:21
   5: speedy2d::Window<UserEventType>::new_with_user_events
             at /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/lib.rs:930:27
   6: speedy2d::Window::new_with_options
             at /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/lib.rs:916:9
   7: speedy2d::Window::new_centered
             at /home/juanjo/.cargo/registry/src/github.com-1ecc6299db9ec823/speedy2d-1.0.2/src/lib.rs:887:9
   8: cubes_game::main
             at ./src/main.rs:19:18
   9: core::ops::function::FnOnce::call_once
             at /home/juanjo/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Thanks for reporting this! I've put in a fix here: https://github.com/QuantumBadger/Speedy2D/commit/494800e4a40bf139a4c9d8f46cf3cd2600df94fb
I've just published v1.0.3 with the fix in, please could you let me know if this resolves the problem for you?

Closing as fixed, let me know if you see the problem again.


add a section to EXAMPLE.md to solve sphinx-build detection

many people had problems having the cookbook target available that is due to not detecting the sphinx-build path in cmake.
we should have in https://github.com/shogun-toolbox/shogun/blob/develop/doc/readme/EXAMPLES.md#rendering-locally a small part describing how to tell cmake where sphinx-build is actually residing, i.e. -DSPHINX_EXECUTABLE=<absolute path to sphinx-build>

May I take up this issue, Im facing this problem too so it would be much helpful from user perspective ☺

go ahead no need to ask just send in a pr


⚠ ClamAV has degraded performance

In 346e71c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 202 ms

Resolved: ClamAV performance has improved in e6dfcef.


Add job id to result set footer

Simply adds the executing job id to the footer of the result set.

I wonder if the job name text should be slightly less prominent than the results status.
Perhaps font that is grey and/or slightly smaller size.
The way it is displayed in the SQL Job Manager.

Another idea, perhaps requiring its own PR, would be to add a span to the footer, between the status and the job name, with the caption 'SQL'.  Hovering over it would display the formatted SQL that produced the results.

@davecharron

Edited: Alternate idea would be to have the new span have the caption 'Details', that when hovered over, shows the job name and SQL. This approach de-clutters the footer, and makes adding details later more straightforward.

I like this idea a lot, but it should be a separate PR. Also, I don't know if from a web view we get the same cool hover support like we do with tree views.


Suppress rule 200002 when Nextcloud mobile app accesses shares through API

Issue
When you open Nextcloud iOS app (v3.0.1) it sends the following request:
GET /ocs/v2.php/apps/files_sharing/api/v1/shares?reshares=false&subfiles=false HTTP/2.0
content-type: application/xml

Again this triggers rule ID 200002 ("XML parsing error: XML: Failed parsing document.") as there is no body in the GET request.
Reproduction
Open the Nextcloud iOS mobile app and you can see the rejected request:

Fix
This PR disables 200002 for the aforementioned URL path.

Looks good :-) But I am already using the rule is range in my pr, think we should find a consent for the ids. Please take a look at: https://github.com/coreruleset/coreruleset/pull/1843 . I think I could move my notifications fix into your Api section. And then we could use 9003700 upwards for that?

Maybe as a side note. Why not limit the exclude to only a GET request for this endpoint by using a chain rule?

I think I could move my notifications fix into your Api section.

Yes I think they should be grouped together.

Why not limit the exclude to only a GET request for this endpoint by using a chain rule?

I have done that in my previous PRs where request method was other than GET, but left it out from this as there are plenty of other such rules already in REQUEST-903.9003-NEXTCLOUD-EXCLUSION-RULES.conf.

Thanks @pyllyukko for your contribution! Luckily for us, we had two nice contributions for nextcloud exclusions!
As you already discussed with @ntimo here, we might merge #1843 first. Then you can rebase your changes on top if it.
I'll let you know and guide you with the process if needed :smile:

Roger that.

Monthly Chat meeting September: https://github.com/coreruleset/coreruleset/issues/1869#issuecomment-688474359
Wait for merge of #1873, then rebase and merge this MR.

Will do.

@pyllyukko Hi, we merged #1878 so we are now ready to merge your PR.
Could you rebase it upon the current v3.4/dev branch?
Then we will merge it ASAP.
Thank you!

Done.

That was quick. Thank you very much for your contribution. Merging now.


"Unknown error occurred" Error on the initiial auth login

System Health details
System Information

version
core-2023.4.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.10.10

os_name
Linux

os_version
5.15.84-v8

arch
aarch64

timezone
America/Edmonton

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
4983

Installed Version
1.32.1

Stage
running

Available Repositories
1261

Downloaded Repositories
12

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 9.5

update_channel
stable

supervisor_version
supervisor-2023.04.0

agent_version
1.4.1

docker_version
20.10.22

disk_total
28.5 GB

disk_used
8.5 GB

healthy
true

supported
true

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
File editor (5.5.0), AdGuard Home (4.8.5), Matter Server (4.2.0)

Dashboards

dashboards
2

resources
4

views
6

mode
storage

Recorder

oldest_recorder_run
6 April 2023 at 02:29

current_recorder_run
13 April 2023 at 15:52

estimated_db_size
152.53 MiB

database_engine
sqlite

database_version
3.38.5

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
"Unknown error occurred" Error on the initiial auth login
Reproduction steps

Try to login
2.Error

...
Debug logs
This error originated from a custom integration.

Logger: aiohttp.server
Source: custom_components/ha_carrier/config_flow.py:95
Integration: Carrier Infinity (documentation, issues)
First occurred: 20:42:01 (1 occurrences)
Last logged: 20:42:01

Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 227, in forwarded_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 235, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 146, in handle
    result = await result
  File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 180, in post
    return await super().post(request, flow_id)
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
    result = await method(view, request, data, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
    result = await self._flow_mgr.async_configure(flow_id, data)
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 271, in async_configure
    result = await self._async_handle_step(
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 367, in _async_handle_step
    result: FlowResult = await getattr(flow, method)(user_input)
  File "/config/custom_components/ha_carrier/config_flow.py", line 95, in async_step_user
    await self.hass.async_add_executor_job(api_connection.get_systems)
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/carrier_api/api_connection.py", line 101, in get_systems
    System(
  File "/usr/local/lib/python3.10/site-packages/carrier_api/system.py", line 22, in __init__
    self.status = Status(system=self)
  File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 75, in __init__
    self.refresh()
  File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 82, in refresh
    self.mode: str = self.raw_status_json["mode"]
KeyError: 'mode'

Diagnostics dump
No response

please add your carrier_api debug logs so we can see what your raw_status_json contains

carrier_api debug  is enabled. isn't it the last 3 lines from log I have posted? I can't find anything else related to carrier_api in the log

Sorry, I thought there was logging from the api that was missing.
please try version 1.18.2 with better logging.
What mode is you system current in? and what thermostat model?

Thermostat model is SYSTXCCITCO1-B
Updated to 1.18.2
This error originated from a custom integration.
Logger: aiohttp.server
Source: custom_components/ha_carrier/config_flow.py:95
Integration: Carrier Infinity (documentation, issues)
First occurred: 12:00:55 (2 occurrences)
Last logged: 12:02:48

Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 227, in forwarded_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 235, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 146, in handle
    result = await result
  File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 180, in post
    return await super().post(request, flow_id)
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
    result = await method(view, request, data, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
    result = await self._flow_mgr.async_configure(flow_id, data)
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 271, in async_configure
    result = await self._async_handle_step(
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 367, in _async_handle_step
    result: FlowResult = await getattr(flow, method)(user_input)
  File "/config/custom_components/ha_carrier/config_flow.py", line 95, in async_step_user
    await self.hass.async_add_executor_job(api_connection.get_systems)
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/carrier_api/api_connection.py", line 101, in get_systems
    System(
  File "/usr/local/lib/python3.10/site-packages/carrier_api/system.py", line 22, in __init__
    self.status = Status(system=self)
  File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 75, in __init__
    self.refresh()
  File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 83, in refresh
    self.mode: str = self.raw_status_json["mode"]
KeyError: 'mode'

@myevit what you provided is only the error logs, please generate and add the debug logging messages from the full home assistant logs

here it is (replaced serial numbers with xxxxxxxx):
2023-04-14 15:21:47.829 DEBUG (SyncWorker_9) [carrier_api.profile] raw_profile_json:{'$': {'version': '1.48', 'xmlns:atom': 'http://www.w3.org/2005/Atom'}, 'atom:link': [{'$': {'rel': 'self', 'href': 'https://www.app-api.ing.carrier.com/systems/2222W206659/profile'}}, {'$': {'rel': 'http://www.api.ing.carrier.com/rels/system', 'href': 'https://www.app-api.ing.carrier.com/systems/2222W206659'}}], 'timestamp': '2023-04-14T17:21:33.309Z', 'pin': 'xxxxxxxx', 'name': 'Thermostat', 'serial': 'xxxxxxxxx', 'brand': 'Carrier', 'indoorModel': 'xxxxxxxxx', 'indoorSerial': 'xxxxxxxx', 'outdoorModel': '24KBTU', 'outdoorSerial': '-----', 'samType': 'ING', 'firmware': 'CESR131626-04.31', 'model': 'SYSTXCCITC01-B', 'iduversion': 'CESR131671-05   ', 'idutype': 'furnace', 'idusource': 'gas', 'idustages': 'mod', 'iducapacity': 58, 'pwmblower': 'off', 'odutype': 'none', 'oducapacity': 24, 'ventpresent': 'off', 'sampresent': 'off', 'nimpresent': 'off', 'ewtsensorpresent': 'on', 'zoneboards': {'board': [{'$': {'id': '1'}, 'present': 'off'}, {'$': {'id': '2'}, 'present': 'off'}]}, 'zones': {'zone': [{'$': {'id': '1'}, 'present': 'on', 'sensortype': 'ui'}, {'$': {'id': '2'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '3'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '4'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '5'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '6'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '7'}, 'present': 'off', 'sensortype': 'unknown'}, {'$': {'id': '8'}, 'present': 'off', 'sensortype': 'unknown'}]}}
2023-04-14 15:21:48.183 DEBUG (SyncWorker_9) [carrier_api.status] raw_status_json:{'$': {'version': '1.48', 'xmlns:atom': 'http://www.w3.org/2005/Atom'}, 'atom:link': [{'$': {'rel': 'self', 'href': 'https://www.app-api.ing.carrier.com/systems/xxxxxxx/status'}}, {'$': {'rel': 'http://www.api.ing.carrier.com/rels/system', 'href': 'https://www.app-api.ing.carrier.com/systems/xxxxxxx'}}], 'timestamp': '2023-04-14T18:06:04.745Z', 'pingRate': 15, 'iduStatusPingRate': 93600, 'iduFaultsPingRate': 86400, 'oduStatusPingRate': 90000, 'oduFaultsPingRate': 82800, 'historyPingRate': 75600, 'equipEventsPingRate': 79200, 'rootCausePingRate': 72000, 'serverHasChanges': False, 'configHasChanges': False, 'dealerHasChanges': True, 'dealerLogoHasChanges': False, 'oduConfigHasChanges': False, 'iduConfigHasChanges': False, 'utilityEventsHasChanges': False, 'sensorConfigHasChanges': False, 'sensorProfileHasChanges': False, 'sensorDiagnosticHasChanges': False, 'name': 'Thermostat', 'cfgem': 'C', 'vacatrunning': 'off', 'filtrlvl': 10, 'uvlvl': 0, 'humlvl': 0, 'ventlvl': 2, 'humid': 'off', 'localTime': '2023-04-14T12:06:04.745', 'oprstsmsg': 'idle', 'isDisconnected': False, 'idu': {'cfm': 350, 'opstat': 'off', 'type': 'furnacemodulating'}, 'odu': {'opmode': 'off', 'opstat': 'off', 'type': 'none'}, 'isActive': False, 'zones': {'zone': [{'$': {'id': '1'}, 'name': 'Main Floor', 'enabled': 'on', 'currentActivity': 'home', 'rt': 23, 'rh': 48, 'fan': 'low', 'hold': 'off', 'htsp': 23, 'clsp': 25, 'otmr': None, 'zoneconditioning': 'idle', 'damperposition': 15, 'occupancy': 'unoccupied', 'occupancyOverride': 'off'}, {'$': {'id': '2'}, 'name': 'Zone 2', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '3'}, 'name': 'Zone 3', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '4'}, 'name': 'Zone 4', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '5'}, 'name': 'Zone 5', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '6'}, 'name': 'Zone 6', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '7'}, 'name': 'Zone 7', 'enabled': 'off', 'hold': 'off', 'otmr': None}, {'$': {'id': '8'}, 'name': 'Zone 8', 'enabled': 'off', 'hold': 'off', 'otmr': None}]}}

Thanks those logs are very helpful. Sorry they aren't sanitized, normally we get that information from the device diagnostics in ha which are sanitized but they aren't available until after the initial setup.
Hopefully last question, what is your thermostats current mode?

For what it's worth, I have the exact same error.  The last few lines at least:
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.10/site-packages/carrier_api/api_connection.py", line 101, in get_systems
System(
File "/usr/local/lib/python3.10/site-packages/carrier_api/system.py", line 22, in init
self.status = Status(system=self)
File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 75, in init
self.refresh()
File "/usr/local/lib/python3.10/site-packages/carrier_api/status.py", line 83, in refresh
self.mode: str = self.raw_status_json["mode"]
KeyError: 'mode'
I'm running current HA and ha_carrier app versions but HACS is a little old and I haven't figured out how to pull the debugs above yet.

That’s fine, you are spending your time to drive this project, so sanitizing is the secondary thing. Heating is the mode.

Thanks for helping me understand this field, seems I was confusing the config mode and status mode field which are not really related and while in some systems status mode is interesting it isn't needed and as of 1.18.3 it is optional. Let me know if you run into any other quirks.

Problem solved! Thank you!


routing subsystem refactoring

routing subsystem refactoring

Route object is responsible for path only (endpoint)
handler moved to View object. we can add more matching checks to View, like specific headers, cookies, etc. right now we match only on method.
added system routes that match HTTPException, so we can register view for specific system route, i.e. HTTPNotFound, or HTTPForbidden, etc.

this is first version, for discussion
it is not backward compatible, we can make it backward compatible later when we decide if we want to use this changes.
@asvetlov @kxepal  thoughts, ides, etc

To not write "ok"  for all inline comments, will say that here (:
Looks good for me, at least after reading. Will try to play tomorrow with the fresh head, but I think that's a good step forward with the large room for the improvements.
Also, I didn't get how to register system routes (tests also missed example of such case), but may be I should take a look a bit closer.

System routes are not clear yet. At least Should we allow to replace existing system routes or just allow to set view on it.
Sent from Outlook
On Thu, Jul 9, 2015 at 4:00 PM -0700, "Alexander Shorin"<EMAIL_ADDRESS>wrote:
To not write "ok"  for all inline comments, will say that here (:
Looks good for me, at least after reading. Will try to play tomorrow with the fresh head, but I think that's a good step forward with the large room for the improvements.
Also, I didn't get how to register system routes (tests also missed example of such case), but may be I should take a look a bit closer.
—
Reply to this email directly or view it on GitHub.

@fafhrd91 hm...I think that exceptions are the same base for views as methods:
route = router.add_route('foo', '/bar/baz')
route.add_view(METH_GET, handle_get)
route.add_view(HTTPNotFound, handle_404)
route.add_view(HTTPBadRequest, handle_400)
...

While there are also "default" system routes (actually views) to catch and process these errors when user route doesn't provides own handlers or accidentally reraise the error from own handler.

Oh! I really like it.
Sent from Outlook
On Thu, Jul 9, 2015 at 4:14 PM -0700, "Alexander Shorin"<EMAIL_ADDRESS>wrote:
@fafhrd91 hm...I think that exceptions are the same base for views as methods:
route = router.add_route('foo', '/bar/baz')
route.add_view(METH_GET, handle_get)
route.add_view(HTTPNotFound, handle_404)
route.add_view(HTTPBadRequest, handle_400)
...
While there are also "default" system routes (actually views) to catch and process these errors when user route doesn't provides own handlers or accidentally reraise the error from own handler.
—
Reply to this email directly or view it on GitHub.

I like idea very much but please don't rush with merging.
Let me review carefully.

sure, it is too early for merging.
some ideas.
we can method default to METH_ANY and make it optional.
also we can extract path leaf and use it as view name, something like /path-to-comething/index.html becomes route with path /path-to-comething/ and view with name index.html
would be cool to make this to work route.add_view(HTTPBadRequest, handle_400), we may need context for view registration, but context adds so many complications.

I'm also thinking about nested applications and routers.

Would you think about routing system based on route name? I mean...
router.add_route('foo', '/bar/baz')
router.add_view('foo', METH_GET, handler)
router.add_view('foo', METH_POST, handler)

...where foo is route_name. Yes, Pyramid-like, but... Pros: less variables, simpler code, easy to write. Cons: None.

@tark-hidden This PR allows that, though you'll have to specify route name explicitly via keyword argument:
app.add_route('foo', '/bar/baz')
app.add_view(METH_GET, handler, route='foo')
app.add_view(METH_POST, handler, route='foo')

However, if route name is really mandatory for add_view method, indeed, why not to pass it with the first argument?

Ah, sorry! I've read an example code with route = router.add_route('foo', '/bar/baz') and route.add_view(...). If I can use route variable as route name without unnecessary variables, it is fine! It that case placement of this parameter doesn't matter, and method as first parameter is better choice.

@asvetlov did you have a chance to review this PR

Sorry, I still have no time for exhausting review. I'm busy with preparing to europython. Maybe next week?

As I see new route system is not compatible with existing one, right?
So maybe better to add new router class (UrlDispather2/web_urldispatcher2.py)?
I support splitting into route/view BTW.

@fafhrd91 This branch has conflicts that must be resolved

I do not have time for this change. Anyone wants to work on this change?

count me on for this then

Please coordinate this effort with @asvetlov
Sent from my iPhone

On Dec 7, 2015, at 8:20 AM, Asif Saifuddin Auvi<EMAIL_ADDRESS>wrote:
count me on for this then
—
Reply to this email directly or view it on GitHub.

hi @asvetlov

Hello.
The PR is not backward compatible with existing code.
There are two options:

Make it compatible (preferable solution)
Move new solution into new UrlDispatcher2 class with deprecating UrlDispatcher in future aiohttp releases (adds a burden of supporting two routers in parallel for a while, about 9-12 months long, which is really maintenance nightmare).

i think we should maintain compatibility.

i'm up for point 1

@auvipy please let me know when you will have something to discuss.

@asvetlov at gitter? or mail or here?

I think github is better tool.
We will left a discussion history at least.

ok let me know what u think should be done? I am up for adding a django like deprication utlis module for better management of feature deprication and related stuffs @ aiohttp an then add/depreicate features according to roadmape design plans.

Try to figure out first what changes are required for adding new functionality without breaking any existing test.

OK

Done by #727


Make routability tests runnable

What type of PR is this?
/kind bug
/kind cleanup
/kind test
/area conformance
What this PR does / why we need it:
The new routability tests are not runnable, they are not included in the set of all features and also have various issues

fix manifest file names
gateway names/typos
move to testify require statements to prevent tests to continue to execute when preconditions not met (to prevent panics) and to simplify test logic

Other issues still remain and will be covered in subsequent issues for discussion, this does not make a guarantee the logic of these tests is correct since there is no implementation that supports them yet.
Which issue(s) this PR fixes:
Fixes #2204
Does this PR introduce a user-facing change?:
NONE

/cc @dprotaso

Thanks @sunjayBhatia!
/lgtm
/approve


Bug: Jinja Template response ignores MediaTyoe settings

Describe the bug
Jinja template responses always return content-type: text/html, even when media_type is set to another value.
To Reproduce
In this example handler, I am trying to return a plain text response.  But the actual result is text/html
class FrontEnd(Controller):
    @get("/robots.txt")
    async def serveRobots(self, request: Request, state: State) -> Template:
        return Template(name="robots.txt.j2", media_type=MediaType.TEXT)

Setting the media_type on the route decorator doesn’t work either:
@get("/robots.txt", media_type=MediaType.TEXT)
Additional context
I’m on my phone at the moment, but happy to provide an MRCE if needed.

To reproduce:
from starlite import MediaType, Template, TemplateConfig, create_test_client, get
from starlite.contrib.jinja import JinjaTemplateEngine

@get("/", media_type=MediaType.TEXT)
async def serveRobots() -> Template:
    return Template(name="robots.txt")

with create_test_client(
    [serveRobots],
    template_config=TemplateConfig(engine=JinjaTemplateEngine(directory="templates")),
) as client:
    assert client.get("/").headers["content-type"].startswith("text/text")

Okay so there's a bit of an issue with this.
Currently we force the media type to HTML, because the media type we receive will always be application/json by default. Since this default is passed down to Template, in Template there's no way of knowing if this was the default or deliberately set.
A workaround would be to check if the media type is application/json, assuming that's the default, and setting the media type to text/html if it is.
The proper way to handle this would be to defer media type setting to a later point / enable default media types for response, but I'm not sure how / if this interferes with OpenAPI generation.
@Goldziher WDYT?


fix: Strip spaces from commit description

If commit description contains leading and/or trailing spaces, remove them before put that description into the changelog and release notes.
Fixes: #89

Coverage remained the same at 97.091% when pulling 61fc6771cfcb2082e1b21d4394c8570755c5d348 on fix/89 into 6947d6862d19ea35215e1c03a400d3999e7e9169 on master.


Add 'intx' package

I've followed this guide
step by step carefully. [Yes]

I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":

https://ci.appveyor.com/project/chfast/hunter/builds/24127969
https://travis-ci.org/chfast/hunter/builds/525024802

I have submitted CI configs to https://github.com/ingenue/hunter targeting pkg.template branch,
see this merged pull request https://github.com/ingenue/hunter/pull/361

Testing:

https://ci.appveyor.com/project/ingenue/hunter/builds/24510770
https://travis-ci.org/ingenue/hunter/builds/531915098?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.23.167


fix compose native build redirect

The URL we use in the CLI output is singular, not plural.
fixes https://github.com/docker/docker.github.io/issues/12148
fixes https://github.com/docker/docker.github.io/issues/12150
relates to https://github.com/docker/compose/pull/7978
relates to https://github.com/docker/docker.github.io/pull/11858

@StefanScherer @usha-mandya PTAL 😅

@StefanScherer @usha-mandya PTAL 😅


python3Packages.spectral-cube: add missing dependencies

Motivation for this change
Fixes #136294.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is unfortunately another one of those cases where even pythonImportsCheck wouldn't have helped catch this, because the missing requirements are presumably supplied by the checkInputs, masking the problem.

Result of nixpkgs-review pr 136295 at 7448cab5 run on aarch64-linux 1

2 packages built successfully:

python38Packages.spectral-cube
python39Packages.spectral-cube

Builds & works, nixos x86_64 & macos 10.15


Prepare virtual channels

Closes #9

Codecov Report

Merging #10 (2642a9b) into master (27efac5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   99.00%   99.05%   +0.05%
==========================================
  Files           9        9
  Lines         200      211      +11
  Branches       53       55       +2
==========================================
+ Hits          198      209      +11
  Misses          2        2

Impacted Files
Coverage Δ

contracts/Adjudicator.sol
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27efac5...2642a9b. Read the comment docs.

Please open an issue regarding virtual sub-app-channels, which we should add at some point.

Done, #12


Allow Tracks layer to accept data as a list or pandas DataFrame

Description
This PR adds the ability to pass the data to the Tracks layer as a list or a pandas dataframe.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

References
How has this been tested?

[x] I updated the tests to include list data
[x] all tests pass with my change

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

@quantumjot , does this seem okay to you? I think it would be nice to be able to pass the data as a list. It's nice for simple tests, etc. to not have to import numpy. As a bonus, I think this allows us to pass a dataframe in as well.

I think it would be nice to be able to pass the data as a list. It's nice for simple tests, etc. to not have to import numpy. As a bonus, I think this allows us to pass a dataframe in as well.

Seems reasonable to me. I think that adding the possibility to pass a dataframe is a great addition too.

Seems reasonable to me. I think that adding the possibility to pass a dataframe is a great addition too.

Great! Thanks for the quick feedback, @quantumjot . By the way, I've been playing around with the Tracks layer more while making the tutorials pages - super fun stuff!

@kevinyamauchi - I just noticed a bug when passing a DataFrame for properties:
Traceback (most recent call last):
  File "/home/quantumjot/napari/napari/_qt/event_loop.py", line 79, in gui_qt
    yield app
  File "<ipython-input-15-fdca00748db9>", line 4, in <module>
    viewer.add_tracks(data, properties=properties)
  File "/home/quantumjot/napari/napari/components/add_layers_mixin.py", line 854, in add_tracks
    layer = layers.Tracks(
  File "/home/quantumjot/napari/napari/layers/tracks/tracks.py", line 144, in __init__
    self.properties = properties or {}
  File "/home/quantumjot/anaconda3/envs/trackpy/lib/python3.8/site-packages/pandas/core/generic.py", line 1326, in __nonzero__
    raise ValueError(
ValueError: The truth value of a DataFrame is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

This is the offending line:https://github.com/napari/napari/blob/647d9182a6dc3542521cbc99b8b59beb4f2ba901/napari/layers/tracks/tracks.py#L144
I can open a separate issue if needed.

@quantumjot , thanks for reporting! Would you mind making a separate issue (I think we will address that in a separate PR)? Should be no problem to patch that up!


Add JSON GameData items support for flexibility and modding

Something like this: https://github.com/Tairesh/SpaceAge/tree/main/src/data

[x] make json-loaded structs in hashmap in gamedata
[ ] make Terrain struct for storing in Tile, remove current enum
[ ] same for Item

I'm not actually sure modding support should be a priority now, and separate struct for every terrain and item seems like a very flexible way to implement a lot of features really fast, so I will close this issue for now, but I will surely return to JSON-isation of everything later


Bump swift-argument-parser to 0.4.1

This will be superseded by #3407 (which updates to 0.4.3), so it can be closed.


Provide an interface for the buildkite api to enable Mocking

I know I am probably the only person testing this but it would be handy.
This would relate to Client in github.com/buildkite/agent/blob/master/api/buildkite.go.
Requires a refactor of all consumers similar to what you have recently done, but rather than return in the struct, you return the interface.
Would enable better unit testing inside the agent as well if you choose to do that.
Cheers 😄

Fixed in https://github.com/buildkite/agent/pull/1020


Export new columns from Rowy

Display Name
Background Image
Perspective Shot
In Game Shorts

This contributes to #32


Next query in the login URL will be set to redirect after login accor…

It is done according to the issue: Login should respect the "?next=[url]" query parameter such that the user can be redirected properly upon login completion #13

Sorry can't merge this. The useEffect is not necessary in this code; it is incresing code complexity needlessly. Please use useEffect sparingly.

Also, prefer using existing libraries in the codebase such as react-user-query-params instead of custom solutions.

Hey, could you use https://www.npmjs.com/package/react-use-query-params instead?

NIcely done! Thanks.


Better Flask example

Closes #14

:books: Documentation preview :books:: https://ploomber-doc--18.org.readthedocs.build/en/18/

need one round of review on this code to check if I'm in the right direction. Had added some comments in the issue. I have taken the Walmart sales forecasting dataset. If we want to include a non-Kaggle dataset I'll replace this with some other dataset.
I have included the model creation notebook as well as the model.
Here's one sample input (the form is scrollable and clicking on Submit button displays the value at the bottom of the div)
sample_input = {'Store':9, 'Dept':72, 'IsHoliday':True, 'Type':'B', 'Size':125833, 'MarkDown1':2.5, 'MarkDown2':0.02,
                'MarkDown3':55952.99, 'MarkDown4':14.64, 'MarkDown5':310.72, 'Year':2012, 'Month':11, 'Week':47}

Currently the formatting is not that good, I'll polish it based on the reviews. I have not been able to run it on Ploomber cloud because the Create button is throwing some error.
@edublancas

@lfunderburk please share your feedback on this example for ploomber cloud

@neelasha23 it might take a bit to get this fixed in the cloud. I think you might have better luck with other formats such as this one: https://onnx.ai/sklearn-onnx/ let me know if that works and you can get the zip file down to 10MB

@neelasha23 any updates here? did using sklearn-onnx work?

Hi all!
Submitting a review on this tomorrow. Sorry for the delay

Will be focusing next week to writing and running tests, adding this one to the queue

@neelasha23 any updates here? did using sklearn-onnx work?

I was getting this error:
For operator SklearnRandomForestRegressor (type: SklearnRandomForestRegressor), at most 1 input(s) is(are) supported but we got 14 input(s) which are ['Store', 'Dept', 'Size', 'MarkDown1', 'MarkDown2', 'MarkDown3', 'MarkDown4', 'MarkDown5', 'Year', 'Month', 'Week', 'Type_A', 'Type_B', 'Type_C']

I found one thread: https://stackoverflow.com/questions/63172475/onnx-model-conversion-with-mutiple-input-types
But I'm not able to understand the solution mentioned.
@edublancas

@neelasha23 let's pause this until the file size limit is increased. I'll assign another task

@neelasha23 reported that she was having issues last week. did anything change?

@idomic Maybe if you can create a new Pro account and share the credentials I can try uploading using that account. Mine is not working,

@idomic @edublancas
Please check above comment

@idomic  I just confirmed that this is still broken. I uploaded the app.zip from the flask branch, after the upload finished, I saw the following error

Deployed the app: https://summer-mud-7289.ploomberapp.io/predict
Have removed app.zip as per your suggestion and also added a readme.
@edublancas

Deployed app: https://falling-fog-2625.ploomberapp.io/predict @edublancas

@lfunderburk let's showcase this example as well


build and install dagger from source

fixes #35
Signed-off-by: CrazyMax<EMAIL_ADDRESS>

Codecov Report

Merging #53 (738e964) into main (2e6b230) will decrease coverage by 16.13%.
The diff coverage is 52.63%.

@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
- Coverage   90.00%   73.86%   -16.14%
===========================================
  Files           2        4        +2
  Lines          50       88       +38
  Branches        9       17        +8
===========================================
+ Hits           45       65       +20
- Misses          3       15       +12
- Partials        2        8        +6

Impacted Files
Coverage Δ

src/dagger.ts
72.22% <23.52%> (-22.38%)
:arrow_down:

src/context.ts
70.00% <57.14%> (-6.93%)
:arrow_down:

src/git.ts
77.77% <77.77%> (ø)

src/util.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6b230...738e964. Read the comment docs.

Could you explain what this does? Does it build dagger from source, or does it rely on a binary-as-a-service on the upstream dagger side? Thanks!

It's building Dagger from the version argument using the Dockerfile and then extracting the binary to cache it in GA

Could you explain what this does? Does it build dagger from source, or does it rely on a binary-as-a-service on the upstream dagger side? Thanks!

Yes like @marcosnils says it builds Dagger on-fly using a remote Git context through version input that can be any repository (upstream or fork) that contains the Dockerfile to build Dagger, then extracts built binary in the final stage to the client, cache the file to the hosted tool cache on the GitHub Runner using the official GitHub toolkit. Cache key is the commit sha:
jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      -
        name: Checkout
        uses: actions/checkout@v3
      -
        name: Dagger
        uses: dagger/dagger-for-github@v2
        with:
          # build dagger from PR 2288
          version: https://github.com/dagger/dagger.git#refs/pull/2288/head
          cmds: do test

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      -
        name: Checkout
        uses: actions/checkout@v3
      -
        name: Dagger
        uses: dagger/dagger-for-github@v2
        with:
          # build main from shykes/dagger
          version: https://github.com/shykes/dagger.git#main
          cmds: do test

I don’t want to hood up this feature, so consider this advisory feedback only. It’s not my preference to decentralize the build process, because it introduces fragmentation and is one step towards loss of control of the developer experience. For example, once we merge this, we have just agreed to am implicit API: we must always have a Dockerfile at the root of the dagger repo, and it must follow the following convention: (whatever this code expects). If we break this convention in the future, we break our user’s github actions. This is not great.
One instance is not the end of the world (which is why this is advisory only, also because I don’t like to be the bad guy saying no all the time, I’ve done it for many years and it’s a thankless job). But if this sets an example and every downstream integration starts building their own version… The problem will get exponentially worse. So I’m more worried about the precedent.
This is why I proposed a “binary on demand” service, it allows us to solve this problem once for all platforms, not just Github.
In summary:

Not my preference to do it this way
Ok to merge this anyway
Please no more downstream builds, next time let’s ask for contribution of a binary-on-demand builder instead, that solves it for everyone.

If we break this convention in the future, we break our user’s github actions. This is not great.

This is partially true, correct? Since it will only break for users that have specified @master in their version URL where the Dockerfile doesn't exist at the same location as it was before.

Correct it won’t break all our users all
at once, only some users some of the time.

My second thought here is that this specific use-case of the version field I have the impression that it will mostly be used by advanced users that require the bleeding edge Dagger features which haven't been released yet. If we keep a relatively short release cycle, this will have an ever more diminished impact.

Yes probably true.

It'd be great to have something like gobinaries.com (https://github.com/tj/gobinaries) that we can leverage only for Dagger binaries. I think that right now might not be the moment to allocate efforts into hosting and setting up such service.

Also probably true.

Moving forward I see three possible options:
1 - Merge this "as-is" and live with the possible fragmentation in the short term until we work on either 2 or 3 2 - Setup a binary publishing process into dl.dagger.io for every commit into master and opened PR's 3 - Setup something like gobinaries.com so we can build binaries on the fly for the target platform.
I'd go for 1 for the moment since I personally don't see the fragmentation problem a big issue given the case that it will mostly "potentially" affect a very small subset of advanced users.

Yes option 1 is fine. Fragmentation issues always seem fine in the beginning, it’s a death by a thousand cuts. That’s why it almost always happens. The people warning against it can always be told “come on this instance is not that bad, aren’t you overreacting?”. It’s true this time, and will also be true the next 10,000 times.

As a final reference I was checking how the terraform action versioning worked and they have an option to specify both rc and beta releases here https://github.com/hashicorp/setup-terraform#inputs. I guess the next step would be to follow a similar approach from the Dagger side where we publish snapshot binaries each time a merge is done into main. This will make this source build version feature pretty much a very specialized case.

@shykes @marcosnils Thanks for your feedback!
I agree with you on the drifting part if changes occur upstream and break users workflow. Even if we take care of making it clear to be careful on changes in the upstream Dockerfile, user might still want to make some changes in it that would anyway break his workflow. So yeah chicken and egg situation there.
1 is still valid but 2 is more resilient I agree. We try that in the past in buildx repo by publishing the artifacts in the workflow space using https://github.com/actions/upload-artifact/#where-does-the-upload-go to share them and then use the GitHub API to retrieve the artifact in the action but artifacts were not available publicly atm :disappointed:. This might have changed though :thinking:


AVM-Review-PR

Description

Updated header
Ran pre-commit checks
Updated example

Type of Change

[x] Non-module change (e.g. CI/CD, documentation, etc.)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
[ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all  pre-commit checks

Successful example/default run locally
https://github.com/user-attachments/assets/3fbf1dc0-0368-44e1-a5b6-74594d07dac3


Not there for Ionic again.  =(

I had to restore my Ionic bc of difficulties updating to OS3 and went to reinstall authenticator and it isn’t showing up (again).  I assume this is just for the Ionic but due to the really dumb way the Fitbit app store works (hiding things) can’t really tell.  Help?

I haven't been blessed with the 3.0 update as of yet, so I can't check the store availability for Versa 3.0, but I'm still seeing it in the store. Have you tried searching for my name (Laura) and seeing if it shows up under apps? It's not built for any specific OS version so I wouldn't expect them to suddenly drop it, but if I do see issues in the store I'll release a new build for 3.0.

Hi Laura - yep I tried searching every which way and no dice.  I went back and installed the beta for now.  Fitbit, compared to Pebble, is really turning out to be super disappointing.

Weird, I'll contact fitbit and see if it's not an issue on their end. The beta version and the live version I believe are currently the same, but you can try the direct link to the live version (https://gam.fitbit.com/gallery/app/ff58cce2-1f9d-4a2f-917d-3cb70c11b542) sorry I didn't think of that earlier.
I'm working on a new build that takes advantage of some 3.0 features, so maybe after that it'll pop up in the Ionic store again (if fitbit doesn't fix it first).


Pep8 cleanups

Make function docstrings more PEP8 verb like.

If / when we do merge I'd suggest a Squash and Merge for this one @r0fls


feat(core/datepicker, core/timepicker, core/datetimepicker): add additional properties

Summary

How did you test this change?

@nuke-ellington @goncalosard
Please review changes. What i have done in summary:

Add an alternative output event to the combined string
Add additional types for events
Merge main added @since tags
Use fromFormat and toFormat consistant in the component
add translation of hardcoded string done

Open Points 😶

[ ] Visual Regression?
[ ] Unit tests?
[ ] Improve documentation
[ ] Examples are broken (min-, max- Date is DateTime which is from luxon and not avaiable on global, convert to module type or refactor min max Date (see review comment))

@goncalosard Can you please have a look to the top date navigation of the datepicker:

It seems to be broken


The request body in specification with application/vnd.api+json don't generate json option for request

Describe the bug
The request body in specification with application/vnd.api+json don't generate json request paramers
To Reproduce
Steps to reproduce the behavior:

Example  request body

requestBody:
        content:
          application/vnd.api+json:
            schema:
              $ref: '#/components/schemas/WorkspaceDocument'

generate specification
see in models

def sync_detailed(
    workspace: str,
    *,
    client: Client,
) -> Response[Union[Any, WorkspaceDocument]]:
    """Update a Workspace

    Args:
        workspace (str):

    Returns:
        Response[Union[Any, WorkspaceDocument]]
    """

    kwargs = _get_kwargs(
        workspace=workspace,
        client=client,
    )

    response = httpx.request(
        verify=client.verify_ssl,
        **kwargs,
    )

    return _build_response(response=response)

Expected behavior
request body with application/vnd.api+json
should generate code like belowe
def sync_detailed(
    workspace: str,
    *,
    client: Client,
    json_body: WorkspaceDocument,
) -> Response[Union[Any, WorkspaceDocument]]:
    """Update a Workspace

    Args:
        workspace (str):
        json_body (WorkspaceDocument): JSON:API Document.

            see: https://jsonapi.org/format/#document-structure

    Returns:
        Response[Union[Any, WorkspaceDocument]]
    """

    kwargs = _get_kwargs(
        workspace=workspace,
        client=client,
        json_body=json_body,
    )

    response = httpx.request(
        verify=client.verify_ssl,
        **kwargs,
    )

    return _build_response(response=response)

Desktop (please complete the following information):

OS: [e.g. macOS 10.15.1]
Python Version: [e.g. 3.8.0]
openapi-python-client version [e.g. 0.1.0]

Additional context
Add any other context about the problem here.

application/vnd.api+json support was explicitly added in 0.8.0 via #307


HOME PAGE- No mario face

The mario face makes it look kid-ish and not serious

This change wont significantly improve the website. I think we should keep the original design.


Issue #8: Add PWA features to template

Add PWA features to template

Not ready to merge yet but feel free to comment.


fixed volumes test in cluster test

Why are these changes needed?
Fixes flaky build volume test
Related issue number

Checks

[ x] I've made sure the tests are passing.
Testing Strategy

[ x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

@z103cb, @tedhtchang please take a look
cc @kevin85421

@astefanutti can you take a look


Translate tasks/run-application/run-replicated-stateful-application/ in Japanese

Translate tasks/run-application/run-replicated-stateful-application/ in Japanese
This is a...

[x]  Feature Request
[ ]  Bug Report

Problem:
No tasks/run-application/run-replicated-stateful-application/ in Japanese.
Proposed Solution:
Translate tasks/run-application/run-replicated-stateful-application/ in Japanese.
Copy from en content and Update content/ja/docs/tasks/run-application/run-replicated-stateful-application/.
Page to Update:
https://kubernetes.io/docs/tasks/run-application/run-replicated-stateful-application/

/language ja

/assign

/milestone 1.14-ja.1

/close


Fix: Tag input blur case

What
Fix of the tag input onBlur behavior.
Why
If the user hasn't added a comma as the last input character the last tag would not register.
How
Updated the handleBlur method to also call the handleAddValue.

LGTM 😄
one thing we probably should create an issue on is that a string of only spaces can also be created as a tag, not just here but generally and we should handle that in handleAddValue if that is not the intended functionality. Also we could consider trimming the strings to ensure that trailing or leading spaces are removed. Thoughts @olivermrbl and @srindom?

This is a great point - would probably also be a good idea to trim the strings before creating the tags


Ask current password to user when he / she sets a new password

This is the counterpart of the REST ticket https://github.com/DSpace/DSpace/issues/8255

@tdonohue  we are interested in take also the angular part as we are working on the REST part. Our estimation is 3-4 days (28 hours)

@abollini : Sounds good, will assign to you and add the estimate


C-Shop pages should be reworked to support dynamic loading subpages and their tools

Summary
Because we are removing the C-Shop enum (see #300), there needs to be a way to access volunteer (c-shop) pages that works with a modular value system.
Details

TBD

Not viable


Fix: User profile copy button is not working

Pull Request Checklist
Before submitting a pull request, please make sure that your changes meet the following criteria:

[X] Ensure that your code adheres to our coding conventions and is properly formatted.
[X] Test your changes extensively to ensure that they do not introduce any new bugs.
[X] Confirm that you agree to the code of conduct.

Related Issues
Closes #53
If this pull request is related to any issues, please list them here.
Screenshots
If your changes include any visual elements, please provide screenshots or other visual aids to help reviewers understand your changes.
Additional Notes
If there is anything else you would like to note about your changes or the review process, please add it here.

Hi maintainer! It's my first time contributing to your repo. I look forward to your response and feedback.

Hi maintainer! It's my first time contributing to your repo. I look forward to your response and feedback.

Hello @zt4ff , Welcome to the @OpenSource-Journey community.
Thanks for the PR.
A few things,

Read the contributions guidelines
If you want to work on any issue first ask maintainers to assign it to you, once issue is assigned to you, can start working on it and raise a PR.

@zt4ff, comment on this #53 issue and I will assign it to you.

Hello @zt4ff , Let us know if you are facing any difficulties or have questions. Thanks

Hello @zt4ff, Any progress on this PR?

@Sachin-chaurasiya, sorry about the late response. I was away from my devices for a while now. I am back now and work on the comment you dropped ASAP

@Sachin-chaurasiya, sorry about the late response. I was away from my devices for a while now. I am back now and work on the comment you dropped ASAP

No worries @zt4ff , thanks.

Hello @zt4ff , Any progress?

@all-contributors please add @zt4ff  for Code


Code Challenge - Notification of Assignment of Opportunity

//Assume Issue #236 has been completed
USE CASE #4 - ASSIGNMENT
Given that I am a program area manager
When  I have assigned a new opportunity
Then the opportunity transitions from the "Published" state to the "Assigned" state
Then the Branch Financial Staff is notified by template email to include the following information related to the opportunity:

Unique ID
Vendor's legal name
Vendor's legal address
Vendor's business number
Contact (email)

NB - Ensure that you use a REST endpoint to send the email notification.

Some participants were looking for background information on the BC DevEx application and framework.
I recommend that you:

Review the website; and
Review the previous code challenge at issue #236


sh: 1: at: not found

I have just installed cronkeep getting this error
on Ubuntu 16.04
`Oh Snap!
at is not available on this system. CronKeep uses this slick command internally to run jobs independently from your web server, whenever you hit "Run". This means you could restart your web server and still have the process running in the background.
Here's the raw output from the command that may help you debug this further:
sh: 1: at: not found`

Hey @imrantune,
The message you are seeing is merely a warning that the at command is missing from your Ubuntu installation. at is a standard utility found in Unix-like operating systems used to schedule commands to run once at a particular time in the future.
CronKeep uses it behind the scenes to run your jobs whenever you the hit the "Run" button, but when at is not available it detects that that's the case and fallbacks to invoking the command directly with the downside that if you need to restart your web server and the command is still running, it will be stopped as well (which is what we try to avoid by nicely asking at to run it for us).
You can either install at or dismiss the warning for 3 days (and still be able to use CronKeep just fine). To install at:

Confirm that you don't have it already:

$ dpkg --list at
dpkg-query: no packages found matching at

Then you can install like so:

apt-get install at

You can now see that you have it:

$ dpkg --list at
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                    Version          Architecture     Description
+++-=======================-================-================-====================================================
ii  at                      3.1.18-2ubuntu1  amd64            Delayed job execution and batch processing

Refresh CronKeep and enjoy a warning-free experience :)

Let me know if this worked and if you need more help setting things up.

I've already installed at, removed www-data from at.deny and still happing this


Removal of logging v1

Logging v1 has been deprecated in v3.0 with notification that it will removed after v3.1.
The plan is to do it partially. This issue will track the progress.

[x] Removal of support for v1 from in tree logging backends #46499
[x] Removing v1 from tests #46503
[x] Removing v1 references from samples #46509
[x] Removing v1 references from the documentation #46520
[x] Removing v1 support from the core #46564
[x] Renaming any references to v2 (e.g. log_msg2) #46727
[x] Rename files log_msg2 to log_msg. #46724
[x] Removing all log_strdup calls #46680

@nordic-krch Seems like there are still references to Z_LOG_MSG2_CREATE* , LOG_MSG2_DEBUG, LOG_MSG2_GENERIC_HDR macros in the tree.

@aasthagr thanks for that info, if i find something like that i will be posting small patches.


Issue when using 3.3.0-next.62

Found this amazing release 3.3.0-next.62 from: https://github.com/facebook/create-react-app/issues/7981
Here I come optional chaining, all works but 2 issues when using Typescript 3.7.2

It will stop compiling when using optional chaining, for this ESLint rule:no-unused-expressions, I have to extend ESLint and disable it in order to avoid adding eslint-disable-next-line every time I use it.

  "eslintConfig": {
    "extends": "react-app",
    "rules": {
      "no-unused-expressions": 0
    }
  },

Visual Studio Code ESLint plugin (https://github.com/Microsoft/vscode-eslint) won't work because of the error:

Failed to load plugin '@typescript-eslint' declared in 'client/package.json » eslint-config-react-app#overrides[0]': Cannot find module '@typescript-eslint/eslint-plugin'
Require stack:
- /Users/AlbertGao/codes/test/__placeholder__.js
Happened while validating /Users/AlbertGao/codes/test/client/src/App.tsx
This can happen for a couple of reasons:
1. The plugin name is spelled incorrectly in an ESLint configuration file (e.g. .eslintrc).
2. If ESLint is installed globally, then make sure '@typescript-eslint/eslint-plugin' is installed globally as well.
3. If ESLint is installed locally, then '@typescript-eslint/eslint-plugin' isn't installed correctly.

Ah, the 2nd one is the plugin's issue:
{
  "eslint.workingDirectories": ["./client"]
}

I think 1 should have been solved by https://github.com/typescript-eslint/typescript-eslint/pull/1175, which i don't believe that beta release includes. We've since updated the packages and will do so again before the final release.
For 2 it sounds like you've solved it. Likely you hadn't opened VS code to the CRA root is my guess?

the folder structure is:
---project root
-----------client (bootstraped by CRA)
I started VSC with the project root, because there will be a server folder later,  all in one IDE :D
I think for the plugin I use, I need to specify the path when the .eslintrc is not at the root but another level. :D

Right makes sense. It probably wants to know where to search for TS configuration and node_modules. Sounds like we can close this then?


Participant list forgotten?

I noticed that regardless of the colours used for the chat, the participant list show the participants (which works fine) but the text (participant names) is white... Until you select the zone and... Surprise you see those names in black!
I don't know how that's possible or why it's even behaving like this (nor do the docs mention anything about styling that side) so I assume it's a bug.

Here's the chat section (which didn't show the images but I fixed it after using id instead of author).

Here's the template code:
<beautiful-chat
      :participants="participants"
      :titleImageUrl="titleImageUrl"
      :onMessageWasSent="onMessageWasSent"
      :messageList="messages"
      :newMessagesCount="newMessagesCount"
      :isOpen="isChatOpen"
      :close="closeChat"
      :icons="icons"
      :open="openChat"
      :showEmoji="true"
      :showFile="true"
      :showTypingIndicator="showTypingIndicator"
      :showLauncher="true"
      :showCloseButton="true"
      :colors="colors"
      :alwaysScrollToBottom="alwaysScrollToBottom"
      :messageStyling="messageStyling"
      @onType="handleOnType"
      @edit="editMessage"
    >
      <template v-slot:text-message-toolbox="scopedProps">
        <button
          v-if="!scopedProps.me && scopedProps.message.type === 'text'"
          @click.prevent="like(scopedProps.message.id)"
        >
          <v-icon color="#000">md-thumb-up</v-icon>
        </button>
      </template>
      <template v-slot:text-message-body="scopedProps">

{{ scopedProps.message.data.meta }}

          <template v-if="scopedProps.message.isEdited">
            <v-icon>mdi-pencil</v-icon>
          </template>
          <template v-if="scopedProps.message.liked">
            <v-icon color="#000">fa-thumbs-up</v-icon>
          </template>

      </template>
    </beautiful-chat>

Edit: After looking into the CSS in Vivaldi's devtool, I noticed it was due to Vuetify affecting the colours with .theme--dark.v-application { color: #fff} (turning that off shows the usernames, but that also screws with the text of the app so not an option) which is similar to #102.
Adding:

to the component fixes that problem, I guess this could be closed but it feels like a hacky way to bypass this problem.

Hi @Berkmann18, I have proposed the above solution for this issue. Is there a better way to go about this change?

Resolved, thanks everyone!


Submit AMICI 0.11.11

id: amici
version: 0.11.11
specificationsUrl: https://raw.githubusercontent.com/biosimulators/Biosimulators_AMICI/5eb5181d19e6406120dd74eb6d7c5e147330dd79/biosimulators.json
specificationsPatch:
version: 0.11.11
image:
url: ghcr.io/biosimulators/biosimulators_amici/amici:0.11.11
validateImage: true
commitSimulator: true

Thank you @biosimulators-daemon for your submission to the BioSimulators simulator validation/submission system!
The BioSimulators validator bot is validating the specifications of your simulator, validating your Docker image and committing your simulator to the BioSimulators registry.
We will discuss any concerns with your submission in this issue.
A complete log of your simulator submission job is available here.

Thank you @biosimulators-daemon for your submission to the BioSimulators simulator validation/submission system!
The BioSimulators validator bot is validating the specifications of your simulator, validating your Docker image and committing your simulator to the BioSimulators registry.
We will discuss any concerns with your submission in this issue.
A complete log of your simulator submission job is available here.

The specifications of your simulator is valid!

The specifications of your simulator is valid!

Summary of tests

Executed 36 test cases

Passed 25 test cases:

cli.CliDescribesSupportedEnvironmentVariablesInline
cli.CliDisplaysHelpInline
cli.CliDisplaysVersionInformationInline
combine_archive.WhenACombineArchiveHasAMasterFileSimulatorOnlyExecutesThisFile
combine_archive.WhenACombineArchiveHasNoMasterFileSimulatorExecutesAllSedDocuments
docker_image.DeclaresSupportedEnvironmentVariables
docker_image.DefaultUserIsRoot
docker_image.HasBioContainersLabels
docker_image.HasOciLabels
log.SimulatorReportsTheStatusOfTheExecutionOfCombineArchives
published_project.SimulatorCanExecutePublishedProject:sbml-core/Szymanska-J-Theor-Biol-2009-HSP-synthesis
results_report.SimulatorGeneratesReportsOfSimultionResults
sedml.SimulatorProducesLinear2DPlots
sedml.SimulatorProducesLinear3DPlots
sedml.SimulatorProducesLogarithmic2DPlots
sedml.SimulatorProducesLogarithmic3DPlots
sedml.SimulatorProducesMultiplePlots
sedml.SimulatorProducesReportsWithCuratedNumberOfDimensions
sedml.SimulatorSupportsAlgorithmParameters
sedml.SimulatorSupportsModelAttributeChanges
sedml.SimulatorSupportsModelsSimulationsTasksDataGeneratorsAndReports
sedml.SimulatorSupportsMultipleReportsPerSedDocument
sedml.SimulatorSupportsMultipleTasksPerSedDocument
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroInitialTimes
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroOutputStartTimes

Failed 0 test cases

Skipped 11 test cases:

published_project.SimulatorCanExecutePublishedProject:bngl/Dolan-PLoS-Comput-Biol-2015-NHEJ
published_project.SimulatorCanExecutePublishedProject:bngl/test-bngl
published_project.SimulatorCanExecutePublishedProject:sbml-core/Caravagna-J-Theor-Biol-2010-tumor-suppressive-oscillations
published_project.SimulatorCanExecutePublishedProject:sbml-core/Ciliberto-J-Cell-Biol-2003-morphogenesis-checkpoint
published_project.SimulatorCanExecutePublishedProject:sbml-core/Edelstein-Biol-Cybern-1996-Nicotinic-excitation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Parmar-BMC-Syst-Biol-2017-iron-distribution
published_project.SimulatorCanExecutePublishedProject:sbml-core/Tomida-EMBO-J-2003-NFAT-translocation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Varusai-Sci-Rep-2018-mTOR-signaling-LSODA-LSODAR-SBML
published_project.SimulatorCanExecutePublishedProject:sbml-core/Vilar-PNAS-2002-minimal-circardian-clock
published_project.SimulatorCanExecutePublishedProject:sbml-fbc/Escherichia-coli-core-metabolism
published_project.SimulatorCanExecutePublishedProject:sbml-qual/Chaouiya-BMC-Syst-Biol-2013-EGF-TNFa-signaling

Warnings
cli.CliDescribesSupportedEnvironmentVariablesInline (11.3 s)
Test that the inline help for a command-line interface describes the environment variables that the simulator supports.
Warnings:
The inline help for a command-line interface for a simulation tool should describe the environment variables that the simulation tool supports.

The command-line interface does not describe the following standard environment variables recognized by BioSimulators:
  - 'ALGORITHM_SUBSTITUTION_POLICY'

If the simulation tool implements these variables, they should be described in the inline help for its command-line interface.

Note, support for these environment variables is optional. Simulation tools are not required to support these variables.

Log:

docker_image.DeclaresSupportedEnvironmentVariables (2.1 s)
Test if a Docker image declares the environment variables that is supports
Warnings:
Docker images for simulation tools should declare the environment variables that they support.

The Docker image does not declare the following standard environment variables recognized by BioSimulators:
  - 'ALGORITHM_SUBSTITUTION_POLICY'

If the simulation tool implements these variables, they should be declared in the Dockerfile for the Docker image for the simulator.

Note, support for these environment variables is optional. Simulation tools are not required to support these variables.

Log:

sedml.SimulatorProducesLinear2DPlots (25.3 s)
Test that a simulator produces linear 2D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLinear3DPlots (25.2 s)
Test that a simulator produces linear 3D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 surfaces

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLogarithmic2DPlots (25.0 s)
Test that a simulator produces logarithmic 2D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLogarithmic3DPlots (25.2 s)
Test that a simulator produces logarithmic 3D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 surfaces

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesMultiplePlots (25.2 s)
Test that a simulator produces multiple plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 2 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (2):
      plot_0: 5 curves
      plot_1: 5 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (2):
    Succeeded: 0
    Skipped: 2
    Failed: 0

Summary of tests

Executed 36 test cases

Passed 25 test cases:

cli.CliDescribesSupportedEnvironmentVariablesInline
cli.CliDisplaysHelpInline
cli.CliDisplaysVersionInformationInline
combine_archive.WhenACombineArchiveHasAMasterFileSimulatorOnlyExecutesThisFile
combine_archive.WhenACombineArchiveHasNoMasterFileSimulatorExecutesAllSedDocuments
docker_image.DeclaresSupportedEnvironmentVariables
docker_image.DefaultUserIsRoot
docker_image.HasBioContainersLabels
docker_image.HasOciLabels
log.SimulatorReportsTheStatusOfTheExecutionOfCombineArchives
published_project.SimulatorCanExecutePublishedProject:sbml-core/Szymanska-J-Theor-Biol-2009-HSP-synthesis
results_report.SimulatorGeneratesReportsOfSimultionResults
sedml.SimulatorProducesLinear2DPlots
sedml.SimulatorProducesLinear3DPlots
sedml.SimulatorProducesLogarithmic2DPlots
sedml.SimulatorProducesLogarithmic3DPlots
sedml.SimulatorProducesMultiplePlots
sedml.SimulatorProducesReportsWithCuratedNumberOfDimensions
sedml.SimulatorSupportsAlgorithmParameters
sedml.SimulatorSupportsModelAttributeChanges
sedml.SimulatorSupportsModelsSimulationsTasksDataGeneratorsAndReports
sedml.SimulatorSupportsMultipleReportsPerSedDocument
sedml.SimulatorSupportsMultipleTasksPerSedDocument
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroInitialTimes
sedml.SimulatorSupportsUniformTimeCoursesWithNonZeroOutputStartTimes

Failed 0 test cases

Skipped 11 test cases:

published_project.SimulatorCanExecutePublishedProject:bngl/Dolan-PLoS-Comput-Biol-2015-NHEJ
published_project.SimulatorCanExecutePublishedProject:bngl/test-bngl
published_project.SimulatorCanExecutePublishedProject:sbml-core/Caravagna-J-Theor-Biol-2010-tumor-suppressive-oscillations
published_project.SimulatorCanExecutePublishedProject:sbml-core/Ciliberto-J-Cell-Biol-2003-morphogenesis-checkpoint
published_project.SimulatorCanExecutePublishedProject:sbml-core/Edelstein-Biol-Cybern-1996-Nicotinic-excitation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Parmar-BMC-Syst-Biol-2017-iron-distribution
published_project.SimulatorCanExecutePublishedProject:sbml-core/Tomida-EMBO-J-2003-NFAT-translocation
published_project.SimulatorCanExecutePublishedProject:sbml-core/Varusai-Sci-Rep-2018-mTOR-signaling-LSODA-LSODAR-SBML
published_project.SimulatorCanExecutePublishedProject:sbml-core/Vilar-PNAS-2002-minimal-circardian-clock
published_project.SimulatorCanExecutePublishedProject:sbml-fbc/Escherichia-coli-core-metabolism
published_project.SimulatorCanExecutePublishedProject:sbml-qual/Chaouiya-BMC-Syst-Biol-2013-EGF-TNFa-signaling

Warnings
cli.CliDescribesSupportedEnvironmentVariablesInline (11.3 s)
Test that the inline help for a command-line interface describes the environment variables that the simulator supports.
Warnings:
The inline help for a command-line interface for a simulation tool should describe the environment variables that the simulation tool supports.

The command-line interface does not describe the following standard environment variables recognized by BioSimulators:
  - 'ALGORITHM_SUBSTITUTION_POLICY'

If the simulation tool implements these variables, they should be described in the inline help for its command-line interface.

Note, support for these environment variables is optional. Simulation tools are not required to support these variables.

Log:

docker_image.DeclaresSupportedEnvironmentVariables (2.1 s)
Test if a Docker image declares the environment variables that is supports
Warnings:
Docker images for simulation tools should declare the environment variables that they support.

The Docker image does not declare the following standard environment variables recognized by BioSimulators:
  - 'ALGORITHM_SUBSTITUTION_POLICY'

If the simulation tool implements these variables, they should be declared in the Dockerfile for the Docker image for the simulator.

Note, support for these environment variables is optional. Simulation tools are not required to support these variables.

Log:

sedml.SimulatorProducesLinear2DPlots (25.3 s)
Test that a simulator produces linear 2D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLinear3DPlots (25.2 s)
Test that a simulator produces linear 3D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 surfaces

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLogarithmic2DPlots (25.0 s)
Test that a simulator produces logarithmic 2D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesLogarithmic3DPlots (25.2 s)
Test that a simulator produces logarithmic 3D plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 1 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (1):
      plot_0: 10 surfaces

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (1):
    Succeeded: 0
    Skipped: 1
    Failed: 0

sedml.SimulatorProducesMultiplePlots (25.2 s)
Test that a simulator produces multiple plots
Warnings:
Simulator did not produce plots

Log:
Found 1 SED-ML documents with 1 models, 1 simulations, 1 tasks, 0 reports, and 2 plots:
  BIOMD0000000896_sim.sedml:
    Tasks (1):
      BIOMD0000000896_sim
    Plots (2):
      plot_0: 5 curves
      plot_1: 5 curves

Executing SED-ML file 0: BIOMD0000000896_sim.sedml ...

Bundling outputs ...
Cleaning up ...

============= SUMMARY =============
Executed 1 COMBINE/OMEX archives:
  Archives (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Tasks (1):
    Succeeded: 1
    Skipped: 0
    Failed: 0
  Outputs (2):
    Succeeded: 0
    Skipped: 2
    Failed: 0

The image for your simulator is valid!

The image for your simulator is valid!

Your submission was committed to the BioSimulators registry. Thank you!
Future submissions of subsequent versions of amici to the BioSimulators registry will be automatically validated. These submissions will not require manual review by the BioSimulators Team.

Your submission was committed to the BioSimulators registry. Thank you!
Future submissions of subsequent versions of amici to the BioSimulators registry will be automatically validated. These submissions will not require manual review by the BioSimulators Team.


I have an issue for Visual Studio,  don't know how to report it!

While trying to report an issue I noticed the message:
To report a problem with IntelliCode for Visual Studio, please use the "Report a Problem..." feature built into the tool.
So I realized I should not use this method to report a VS problem, but then I cannot find the "Report a Problem" anywhere on the tool.
How am I supposed to report a problem in VS again?

Thanks!

Help > Feedback > Report a Problem. There’s also an icon near the top right corner for feedback and you can select Report a Problem there as well. Let us know if you still have issues finding it.

I don't see the top right icon, but I saw the option on the Help menu, I was expecting something specifically for IntelliCode not a VS issue, but anyway, I'll submit using that.
Thanks!

Sorry for any confusion @erlis - we are using the general Visual Studio problem reporting system to collect feedback and issue reports. As long as you mention IntelliCode in your report, it will find its way to us. And thanks for trying IntelliCode!
Mark

Thanks for clarifying... you can close this one now ;)


Cannot stringify POJOs with symbolic keys Symbol(Symbol.toStringTag)

Hi,
I keep getting the Cannot stringify POJOs with symbolic keys Symbol(Symbol.toStringTag) error when trying to do the following with Nuxt.js:
  async asyncData({ params, error, payload }) {
    const data = await import(`~/content/articles/${params.slug}.md`)
    return { article: data }
   }
  }```

Then in my template:

```html
<component class="markdown" :is="article.vue.component" />

Is it a know issue?

I couldn't make it work with mode: [Mode.VUE_COMPONENT],. I had to remove the mode and use article.html in my template instead.
Any ideas on how to fix this issue so I can use the Mode.VUE_COMPONENT mode?

This is how I'm generating my build:
// Necessary for the generate
var glob = require('glob');
async function getDynamicPaths(urlFilepathTable) {
  return [].concat(
    ...Object.keys(urlFilepathTable).map(url => {
      var filepathGlob = urlFilepathTable[url];
      return glob
        .sync(filepathGlob, { cwd: 'content' })
        .map(filepath => `${url}/${path.basename(filepath, '.md')}`);
    })
  );
}

  generate: {
    async routes() {

      const articlesRoutes = await getDynamicPaths({
        '/articles': 'articles/*.md'
      })
      console.log(articlesRoutes);

      return articlesRoutes
    }
  },

asyncData on Nuxt supports only primitives. vue.component by VUE_COMPONENT mode couldn't be served through asyncData since that includes some functions.

Hi @hmsk , thank you so much for your response!


Update dotnet install script

This PR provides an update to the following scripts:

src/Misc/dotnet-install.ps1 (Taken from https://dot.net/v1/dotnet-install.ps1)
src/Misc/dotnet-install.ps1 (Taken from https://dot.net/v1/dotnet-install.sh)

@alexander-smolyakov It looks like dotnet-install.sh script is causing test failures on Mac and Linux

@EzzhevNikita, It seems the issue related to the script itself.
I found the related issue: https://github.com/dotnet/install-scripts/issues/136
As I can see, the script was already fixed in this PR: https://github.com/dotnet/install-scripts/pull/137
So now we have to wait until the fixed version of the script will be published on the site.

Fix was published. All CI checks are passed now.

@damccorm, could you please take a look at this PR?


HBorderAndStyle is adding 2 borders to the shape when node is collapsed

It should only have one border.


[BrokenLinksH2] Fix path in link

Fixing broken link
Microsoft Reviewers: Open in CodeFlow

Docs Build status updates of commit dd8104a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/sdk/rendering-cards/react-native/getting-started.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@matthidinger - The C+E Skilling team is fixing broken links on docs.microsoft.com. This will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes/removals and does not change other content. This PR is ready for merge. Thank you!

The links are working as they are.


_underlyingPanzoomInterop null-check on dispose

I used the component in combination with tabs and experienced that DisposeAsync could be called before OnAfterRenderAsync when rapidly switching between tabs, which led to a crash of the site.

Awesome thank you for this. I should have been more careful since it is nullable.

Hey! I'm hit by the same issue. It looks like there is no new release with this fix:

@shaigem any chance you'll release a new version of this library? This bug was patched two years ago but it hasn't been released ;(

@shaigem any chance you'll release a new version of this library? This bug was patched two years ago but it hasn't been released ;(
Edit: It was able to easily clone the source from GH, build the project, and reference BlazorPanZoom from my blazor project (without the nuget reference). It works without throwing the error!

I guess you used the branch feat/panzoom-4.5.1 ?

@PmE8HW0KRfqa could you give a hint what was the fix? I'm experiencing the null ref exceptions on any call of the panzoom component reference method involving _underlyingPanzoomInterop from the OnAfterRenderAsync() method of my component.


comma splice

¯\_(ツ)_/¯

I taught university English for several years. Technically you aren’t supposed to put a comma between two independent clauses. Just sayin’. :)

I believe you that your suggestions is gramatically correct, but I don't believe it really matters in this case 😉


Fix Joint3D and Joint2D warning causing a crash

Fixes #60962.
Fixes #55660.
Introduced by #58641.
This PR fixes the crash, but it's hiding a worse problem.
Joint3D (the same happens for Joint2D) makes the offending update_configuration_warnings call when it's handling the NOTIFICATION_EXIT_TREE notification. The warning signal is received by SceneTreeEditor with the signal connected here. The connect call has the CONNECT_DEFERRED flag, which means the signal may be handled after the Joint3D is freed. Removing that flag doesn't trigger the crash.
As a plus, VariantCasterAndValidate doesn't check if the object is valid, but this may be expected.
In conclusion, any node that calls update_configuration_warnings and right after it's freed can cause a crash.

CC @rburing

I assume it's relevant for 3.x as #58642 was a backport of #58641?
Also, #55660 predates the merge of #58642 so it's a bit confusing, was it really caused by this PR?

Also, https://github.com/godotengine/godot/issues/55660 predates the merge of https://github.com/godotengine/godot/pull/58642 so it's a bit confusing, was it really caused by this PR?

Yeah, I read the diff wrongly. That code was already there before that PR.
It was introduced by #48242 and a 3.x versions isn't needed, if I'm right about the cause.

Thanks!


Add additional methods to power off vapps

This requirement came about from a need to delete all running vApps. vApps need to be powered off before you are able to delete them so I am adding in the functionality to be consistent with other methods.

@surminus I left you some comments :)

Addressed comments. Thanks @ajlanghorn

It would be good to add an integration test similar to the one for #power_on.

@surminus Can you please address the comments above?

stops watching

I am closing this as it's no longer required.