Use objects with x-amz-website-redirect-location for permanent redirects

We ran into an issue where we want more than 50 redirects in our s3 bucket, and there's a hard limit in s3 on the number of routing rules you can set on a bucket.  An alternative is to use the x-amz-website-redirect-location header on an object.  I propose doing that by default for all 301 redirects.
documentation: https://docs.aws.amazon.com/AmazonS3/latest/dev/how-to-page-redirect.html
Happy to add a configuration flag to toggle this behavior off if you'd like.

+1. Fixes #49

All my redirects so far have been of this form:
/blog/some-dasherized-title.extension  => /blog/some-dasherized-title/949ed2b876340360dd560e5eeb518dbd354f5a75.extension
/blog/with_underscores.extension  => /blog/with_underscores/949ed2b876340360dd560e5eeb518dbd354f5a75.extension

I can add some test cases to the with-redirects example, and to the bin.test.ts.  One issue with bin.test.ts is that I couldn't specify an arbitrary bucket name, so I wasn't able to test it myself, due to this line in the examples/with-redirects/gatsby-config.js:
options: {
                bucketName: 'gatsby-plugin-s3-' + process.env.AWS_STAGE,
                region: 'eu-west-1'
            },

Are y'all fine with me changing that up to specify an arbitrary bucket name in test, falling back to using AWS_STAGE if that's not present?

Are y'all fine with me changing that up to specify an arbitrary bucket name in test, falling back to using AWS_STAGE if that's not present?

Could you just specify the AWS_STAGE environment variable when you run bin.test.ts instead? I know it's not fully arbitrary because it still needs to be "gatsby-plugin-s3-" prefixed.
You can of course modify the code to specify any bucket name you like, but committing that change is probably not ideal.

Is there ever a case where protocol is provided but hostname is not, or vice versa?

Any update on this getting merged?

Sorry, this totally fell off my radar. I've done some testing today and I'm happy with how this works now.
I did notice a niche situation where this causes backwards compatibility issues: If the target site does not use S3 Static Website Hosting, visiting one of the redirects will cause the page to be downloaded as an application/octet-stream file. Previously the page would've returned a 404 which could've been handled by CloudFront's custom error handlers and in conjunction with gatsby-plugin-meta-redirect yielded decent fallback behaviour. Of course with this new system it's easy to make an Origin Response Lambda@Edge function that reads the x-amz-website-redirect-location header, but regardless there are some situations where this change is breaking.
Due to this (and the potential that this change causes other issues that I haven't discovered) I think we should have a config value to enable this new behaviour, and if the config value is false the old behaviour should be preserved.  The config value should be false by default until the next major version, when we can make it true by default. This is in-line with our handling of other breaking changes. (See #41)
My apologies for the delay in reviewing this @gburgett. If you can add the config value as described I will do my best to review and merge your changes ASAP.

Ok, the new configuration variable has been added.  By default it uses routing rules for 302s, and generates these:
<RoutingRules>
  <RoutingRule>
    <Condition>
      <KeyPrefixEquals>hello-there</KeyPrefixEquals>
      <HttpErrorCodeReturnedEquals>404</HttpErrorCodeReturnedEquals>
    </Condition>
    <Redirect>
      <ReplaceKeyWith>client-only</ReplaceKeyWith>
      <HttpRedirectCode>302</HttpRedirectCode>
    </Redirect>
  </RoutingRule>
  <RoutingRule>
    <Condition>
      <KeyPrefixEquals>client-only/</KeyPrefixEquals>
      <HttpErrorCodeReturnedEquals>404</HttpErrorCodeReturnedEquals>
    </Condition>
    <Redirect>
      <ReplaceKeyWith>client-only</ReplaceKeyWith>
      <HttpRedirectCode>302</HttpRedirectCode>
    </Redirect>
  </RoutingRule>
  <RoutingRule>
    <Condition>
      <KeyPrefixEquals>blog</KeyPrefixEquals>
      <HttpErrorCodeReturnedEquals>404</HttpErrorCodeReturnedEquals>
    </Condition>
    <Redirect>
      <ReplaceKeyWith>blog/1</ReplaceKeyWith>
      <HttpRedirectCode>301</HttpRedirectCode>
    </Redirect>
  </RoutingRule>
  <RoutingRule>
    <Condition>
      <KeyPrefixEquals>asdf123.-~_!$&'()*+,;=:@%</KeyPrefixEquals>
      <HttpErrorCodeReturnedEquals>404</HttpErrorCodeReturnedEquals>
    </Condition>
    <Redirect>
      <ReplaceKeyWith>special-characters</ReplaceKeyWith>
      <HttpRedirectCode>301</HttpRedirectCode>
    </Redirect>
  </RoutingRule>
  <RoutingRule>
    <Condition>
      <KeyPrefixEquals>trailing-slash/</KeyPrefixEquals>
      <HttpErrorCodeReturnedEquals>404</HttpErrorCodeReturnedEquals>
    </Condition>
    <Redirect>
      <ReplaceKeyWith>trailing-slash/1</ReplaceKeyWith>
      <HttpRedirectCode>301</HttpRedirectCode>
    </Redirect>
  </RoutingRule>
</RoutingRules>

An issue that came up in testing is, this routing rule doesn't appear to match the url-encoded string I'm sending in the spec.  So the spec fails until I set the new config option in the example.
  ● redirects › special characters using WebsiteRedirectLocation

    expect(received).toBe(expected) // Object.is equality

    Expected: 301
    Received: 404

      72 |     test('special characters using WebsiteRedirectLocation', async () => {
      73 |         const response = await fetch(TESTING_ENDPOINT + '/asdf123.-~_!%24%26\'()*%2B%2C%3B%3D%3A%40%25', { redirect: 'manual' });
    > 74 |         expect(response.status).toBe(301);

I assume this is not desirable - 301 redirects should function the same regardless of whether they come from an object or a routing rule.  Is this an issue in the getRules function inside gatsby-node.ts?

@JoshuaWalsh finally got around to your last comments.  Please take another look.

Oh @gburgett , I should've asked you before I merged this sorry, but would you be able to update README.md to document this new option? That way people will be able to more easily discover this feature.

Hi there @gburgett,
The tests appear to be failing on windows, any idea?
https://dev.azure.com/jarizw/jarizw/_build/results?buildId=47

Repro'd, this is caused by forward-slash vs trailing-slash differences on Windows. When I run the build on Windows the redirect object was created with a key of trailing-slash\index.html. It should be trailing-slash/index.html.

@JoshuaWalsh
Ah, yes, we've ran into that before. Should probably be refactored to use the createSafeKey function.
https://github.com/jariz/gatsby-plugin-s3/blob/master/src/bin.ts#L95


Add in options to publish profile

Add in some further options:

allow_drop_tables
allow_drop_columns
allow_drop_primary_constraints
allow_drop_foreign_constraints

Perhaps we should also consider expanding the allow_unsafe_operations so that it is more explicit.

I think each of these likely needs a tri-state: Allow, Error, Ignore.
From there the items we need to consider are:

drop_enum_values
drop_tables
drop_columns
drop_primary_key_constraints
drop_foreign_key_constraints

The last two are a little controversial for index modifications at present however I've now created a ticket to track this (#103)


support python39

Related issues
https://github.com/koxudaxi/fastapi-code-generator/issues/38

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@31ce036). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   94.37%
=========================================
  Files             ?        2
  Lines             ?      320
  Branches          ?        0
=========================================
  Hits              ?      302
  Misses            ?       18
  Partials          ?        0

Flag
Coverage Δ

unittests
94.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ce036...00e52b4. Read the comment docs.


Password Login Authentication

The Satisfactory documentation indicates that third party tools should not use the PasswordLogin API, and instead should have the servers generate a long lived Application authentication token via the console's server.GenerateAPIToken function.
It would be nice if it were an option at init to provide that token directly, instead of providing a password.

I complete agree, thanks for raising this issue. I'll work on this now.

@deadly990 Could you try now using token=xyz?


[DOCFIX] Fix broken links

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10481/
Test PASSed.

LGTM


doc: capitalization change for consistency.

@bors: r+

:pushpin: Commit 734c690871c35ec7d18a42e8c7e41c266f288dc1 has been approved by alexcrichton

:hourglass: Testing commit 734c690871c35ec7d18a42e8c7e41c266f288dc1 with merge 81a49ce3c83186d7acb0431fc470c1e88a8eda70...

:broken_heart: Test failed - checks-azure

Probably due to https://github.com/rust-lang/rust/pull/64041, I can put together a PR in about 30 min if nobody else wants to.

@bors: retry

:hourglass: Testing commit 734c690871c35ec7d18a42e8c7e41c266f288dc1 with merge 9eaddf5bff14ec2e59159b700654258f24f072a9...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 9eaddf5bff14ec2e59159b700654258f24f072a9 to master...


Licensing clarification

Hi - can you please clarify how this package is licensed? I see the reference to "NCSA" in at line 83 on the setup.py file.
Repository licensing: https://help.github.com/articles/licensing-a-repository/
Thanks!

https://opensource.org/licenses/NCSA


fix:buttons

fixed fix position of buttons and minor ui fixes

The buttons are working, and are now moving around as well. @~Chaitanya I would say that for the looks, if you are designing the bubble button, then make it black border, and white background. No shadows. Add a light zinc hover. Otherwise keep it dark zinc as standard color.
Mention, and by default send the Empty .env requirements.


[Feature]: Add Net-Z documentation

Checked Existing

[X] I have checked the repository for duplicate issues.

What feature do you want to see added?
Add documentation about Quazal Net-Z and everything related to it (DO protocol, usage on NEX, its RMC and Action methods...)
Why do you want to have this feature?
This would allow us to have a better understanding on how P2P works on games that use it, which could be useful for viewing communication between players and debugging issues on that regard.
Any other details to share? (OPTIONAL)
There is some documentation about DO on https://github.com/zeroKilo/GROBackendWV/wiki/DO , but it's largely incomplete and not very clear about how the fundamentals work (duplicated objects, duplication master, duplicas...)

not very clear about how the fundamentals work (duplicated objects, duplication master, duplicas...)

Duplicated objects is a fairly common mechanism in my experience for dealing with state managment in p2p connections. I can't find any specific documentation on it, but I've seen a number of game dev content creators bring up the concept when working on multiplayer titles.
The idea is that game state is represented by a series of "objects", which get duplicated across all clients in the session. The client in which the object is created on is the master whereas the copies on other clients are the duplicas. Updates are sent/received as necessary to keep the object state in sync


createThrottledMemo only updates once..

I m trying out createThrottledMemo. But can't get it to update more than once. Is it my mistake or a bug?
function ThrottleMemoTest() {

	const [count, setCount] = createSignal(1)
	const timer = setInterval( () => setCount(count() + 1), 1000 );

	const double_normal = () => count() * 2;						//works, updates
	const double_memo = createMemo( () => count() * 2, 0);			//works, updates
	const double_throttle = createThrottledMemo( prev => count() * 2, 2000);	//runs only once, why is it not updating?

	console.log('double_throttle:', double_throttle)
	onCleanup( () => clearInterval(timer) );

	return html`<div>count:${count}    double_throttle:${double_throttle}</div>`;
}

Hey, thanks for the issue but I cannot reproduce—the primitive seems to work as expected.
Here is code from your snippet in a stackblitz sandbox:
https://stackblitz.com/edit/solid-vite-unocss-c4rf6p?file=index.tsx
And here is another example of the primitives:
https://stackblitz.com/edit/solid-vite-unocss-xmnubd?file=index.tsx
So I'll close this issue, but feel free to reopen it if you still have some issues. It would be helpful to see a reproduction though.


Remove old tiny stack ID

We've switched over to the new stack ID (io.paketo.stacks.tiny) so we can remove this old one.
Related PRs:
https://github.com/paketo-buildpacks/go-compiler/pull/55
https://github.com/paketo-buildpacks/dep/pull/48
https://github.com/paketo-buildpacks/go-mod/pull/59

I don't think we need this PR. That stack ID should get removed when each buildpack updates after your PRs get merged.


preview have a problem

Thank you for this package,It's very nice.
But I found a petty problem
code:
for x in range(1, 11):
    print('{0:2d} {1:3d} {2:4d}'.format(x, x*x, x*x*x))

the first line is doesn't work under the preview:
1   1    1
 2   4    8
 3   9   27
 4  16   64
 5  25  125
 6  36  216
 7  49  343
 8  64  512
 9  81  729
10 100 1000

It's not a problem at all.
Output of kernel is trimmed. And if in your case it breaks indentation, in many other cases it helps a lot. Hydrogen is just kernel runner, so it deals with all kernel differences. For example, some kernels(julia) add newline to any output and some only on special occasions, others don't do it at all. Which you should agree, will look more inconsistent.

thanks a lot for your reply.


OIDC returns claims with wrong encoding

My application creates users with UTF-8 encoding via SCIM2 API. The users are properly sent, received and correctly stored to UTF-8 MySQL database. When I try to get claims via OIDC, non-ASCII characters are returned incorrectly. Example:

Sent via SCIM2: ŠĐČĆŽšđčćž (UTF-8)
Stored in database: ŠĐČĆŽšđčćž (UTF-8)
Returned via OIDC (in JWT token): ÃÂ Ãï¿½ÃÅÃ†ÃÂ½ÃÂ¡Ã‘Ãï¿½Ã‡ÃÂ¾ (???)

Hi @danijelt
Thanks for reporting the issue.
Which version of Identity Server are you observing this issue?

I use IS 5.9.0.


Improve support for multiple filters in file dialogs

We should decide a consistent filter string format to use for lime.ui.FileDialog, then we need to do some testing or improvements to be sure it is supported as well as possible on all platforms.

Was just searching around to see if there was a way to do this, this would be nice to have, as well as a way to specify names for filters.


Oculus Gear VR browser isn't supported

Trying the WebVR-UI with AFrame 0.5, the "Enter VR" button doesn't respond as expected.
Test URL: https://treasure-scraper.glitch.me/
Expected result: When clicking on the "Enter VR" button while wearing the Gear VR headset in the WebVR Oculus browser, it should launch VR mode and the user should be surrounded by the scene
Actual result: clicking on the "Enter VR" button does nothing

The issue is in AFrame 0.4.0 (which is used by webvr-ui): it doesn't support GearVR / Oculus Browser. They added support to AFrame 0.6.0.
I've created two pull requests - one for 0.4.0 and another for 0.5.0 with the fix for the issue in the older versions of A-Frame, but not sure if those will be merged or not.  You may check them out.

You also may quickly try the fixed versions of 0.4.0 and 0.5.0 by using these links for

Perfect, good work!
The Aframe team doesn't do patch uplifts for old versions (as stated here https://twitter.com/dmarcos/status/881637839288455168) but upgrading to v0.6 should fix this problem.
Issue can be closed I guess

I believe there is an issue here and would like more information.
Are you referring to the Samsung Internet browser? Chrome? Or are you referring to the Carmel Developer Preview?
Did you only attempt to use the a-frame example?
thanks

It looks like the issue was related to internal AFrame functions. I tested your WebVR-UI with the AFrame example on Oculus browser (formerly known as Carmel).
It now works with AFrame 0.6 and your library
(Checked with Samsung VR browser and Oculus browser on https://glitch.com/edit/#!/treasure-scraper)

Ah, we should update the example to the newest version of aframe.

I've updated the example to<EMAIL_ADDRESS>it now works in Gear VR.


refactor(module:tabs): refactor tabs to support OnPush

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
#2381
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

close #1822 close #2233 close #2247


Error in alanine_dipeptide_mstis_bootstrap.ipynb

When running this notebook error occurs when creating inter core trajectories at step/cell 40:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-40-79f854d66f52> in <module>()
      7         try:
      8             count += 1
----> 9             tt = engine_high.generate_forward(tt[-1].reversed, core2core)
     10             storage.save(tt)
     11

/Users/bolhuis/git/openpathsampling/openpathsampling/engines/dynamics_engine.pyc in generate_forward(self, snapshot, ensemble)
    236         """
    237
--> 238         return self.generate(snapshot, ensemble.can_append, direction=+1)
    239
    240     def generate_backward(self, snapshot, ensemble):

/Users/bolhuis/git/openpathsampling/openpathsampling/engines/dynamics_engine.pyc in generate(self, snapshot, running, direction)
    311
    312             # Do integrator x steps
--> 313             snapshot = self.generate_next_frame()
    314             frame += 1
    315             if frame % log_freq == 0:

/Users/bolhuis/git/openpathsampling/openpathsampling/engines/openmm/engine.pyc in generate_next_frame(self)
    241         self.simulation.step(self.nsteps_per_frame)
    242         self._current_snapshot = None
--> 243         return self.current_snapshot
    244
    245     def minimize(self):

/Users/bolhuis/git/openpathsampling/openpathsampling/engines/dynamics_engine.pyc in __getattr__(self, item)
    164     def __getattr__(self, item):
    165         # default is to look for an option and return it's value
--> 166         return self.options[item]
    167
    168     @property

KeyError: 'current_snapshot'

This was running after I did a conda update --all

FWIW, I just verified that I get the same error when I run this notebook. Labelling this as "bug".

I will look into this. Note that there is a very strange thing with accessing attributes defined by properties in python:
If you access an computed attribute that is defined using @property and a function then, if there is an error in the execution of the property function python by default returns a KeyError on the property and not the real error that occurred!
So you (or me) have to look inside the current_snapshot property funtion of the engine used and see why it cannot return the current snapshot. I presume there is something going wrong with OpenMM. Not sure

Note that there is a very strange thing with accessing attributes defined by properties in python:

No, this isn't Python. This is because you defined __getattr__ to check a dictionary if no other attribute was found, and then don't transform the raised error into an AttributeError. I fixed this in the external engine PR: https://github.com/openpathsampling/openpathsampling/pull/144/files#diff-1f3c9e17b65986c77f91c9aefb7674d2; I can make a quick PR of the same text if you'd like.

This was just a quick note that I thought about since I had some problems with descriptors that are interpreted wrong under some circumstances. This rare case applies here, I think:
If you try to access a descriptor (like .current_snapshot) which is defined using @property this will call the __get__ method of the descriptor first. If that fails with an AttributeError !! which is the same error, if the attribute would not exist or __get__ is not implemented. Then (and only for AttributeErrors), the getattribute will call __getattr__ as a fallback. Which is happening in this case and then fails because of current_snapshot not being in self.options. It should have been an AttributeError in the descriptor instead but these two cases are indistinguishable.
Bottomline is: You can partially fix it the way you said, but if, for some reason the property fails with an AttributeError you will catch the error in __getattr__ and report falsely that the property is missing and not in options. That is wrong.
I had this before and it took me several hours to realize what is happening. Here a short example.
class A(object):
    @property
    def b(self):
        obj = object()
        return obj.b

    def __getattr__(self, item):
        # If there was an error in `p` I cannot see it here
        # Do something else without knowing about failing in `p`
        raise AttributeError('There is no attribute %s' % item)

a = A()
# access well defined propery `p`
a.p

There is no way to fix this other than to surround your property code (inside the property) with a try except clause and catch AttributeErrors and raise another error to report what is actually happening.
The simpler way would be to look into current_snapshot and try to fix it there. That was my original suggestion. Hope that clarifies my earlier post.
Still, what you suggest makes sense to have so please make a PR and add that.

The thing I was talking about wasn't intended to fix the problem @bolhuis was having. It does not prevent the error. However, it does fix the problem that the error is reporting itself as the incorrect type: there's an AttributeError, absolutely not a KeyError. As you said, if __getattr__ is being called at all, the issue is that an AttributeError has been raised.
I'll go ahead and open a PR for that; tests on the external engine required the correct error type to be raised, which is why I implemented it over there in the first place.
The main problem of this issue, however, isn't that the error was a KeyError. It's that it was an error at all. (It's after running for quite a while, and it only seems to happen in that notebook).

There is no way to fix this other than to surround your property code (inside the property) with a try except clause and catch AttributeErrors and raise another error to report what is actually happening.

Not perfect, but:
class A(object):
    @property
    def bad_property(self):
        obj = object()
        return obj.b

    @property
    def good_property(self):
        return 1

    def __getattr__(self, item):
        if item in self.__class__.__dict__:
            # we should have this attribute
            p = self.__class__.__dict__[item]
            if isinstance(p, property):
                try:
                    result = p.fget(self)
                except:
                    raise
                else:
                    return result
            raise AttributeError("Something went wrong with " + str(item))
        else:
            raise AttributeError("I've never heard of " + str(item))

a = A()
a.bad_property
#---------------------------------------------------------------------------
#AttributeError                            Traceback (most recent call last)
#<ipython-input-3-796e4ba031a2> in <module>()
#----> 1 a.bad_property
#
#/Users/dwhs/example.py in __getattr__(self, item)
#     15             if isinstance(p, property):
#     16                 try:
#---> 17                     result = p.fget(self)
#     18                 except:
#     19                     raise
#
#/Users/dwhs/example.py in bad_property(self)
#      3     def bad_property(self):
#      4         obj = object()
#----> 5         return obj.b
#      6
#      7     @property
#
#AttributeError: 'object' object has no attribute 'b'

a.does_not_exist

#---------------------------------------------------------------------------
#AttributeError                            Traceback (most recent call last)
#<ipython-input-4-11b640528e00> in <module>()
#----> 1 a.does_not_exist
#
#/Users/dwhs/example.py in __getattr__(self, item)
#     22             raise AttributeError("Something went wrong with " + str(item))
#     23         else:
#---> 24             raise AttributeError("I've never heard of " + str(item))
#     25
#
#AttributeError: I've never heard of does_not_exist

How about I modify the code from external engine to do something like that? I'm not sure how to generate a test for the case of "Something went wrong with item" (and the test case for returning a successful result will also be weird.)

Nice solution, that should do it. Go ahead with a PR to fix it.

#516 should have fixed the wrong error message. So, if the error appears again, please let me know. I assume it will be from using 1000K as high temperature for the first initial trajectory. A stepsize of 2fs could be too large.

I found the error (I presume). Problem is to run at high temperatures with stepwise of 2fs. This explodes at some point and there are NaN everywhere. OpenMM throws a
AttributeError: 'module' object has no attribute 'Dataframe'

error which is the source of the Attribute confusion.
I replaced 2fs with 1fs used 1000K and doubled the steps for OPS. Effectively having the same saving time_steps of 40fs now.
I assume this does not happen in other notebooks because we use low temperatures or the simulation is too short for this to happen.

I think we can close this. The wrong error message is solved and the origin of the error was a bad setup.

I think this was fixed by fixing the NaN problem.

Do you find it disappearing with VVVR at 2.0 fs step size? (I hope so!)


File changed in src and root directory

@franciscop  checkout the all the changes are made in project at develop branch.  Also added one external plugin notification

I made quite a few changes:

Each plugin is being built in the folder it is hosted as plugins/NAME/NAME.min.css.
I modified your plugin to follow Picnic conventions (inherit variables, normalizer and fixed a small jQuery bug).
Now the documentation lives in /docs to allow publishing the page from Github easier and not polluting the root folder with .html.

TODO:

A page for all the plugins. This would require ~2h extra that I cannot commit right now.

@franciscop
List of things I am going to work on.

Moving tabs from core to external plugin.
Adding plugins page to docs.

I think we can also update jade to pug.

Sure, the build system was quite old so let's switch to pug. 1. also sounds good, but I'd create a new page called "Plugins" where each one is detailed instead of putting it in "Documentation" (with an appropriate big link in documentation to Plugins).


Memory leaks on exit in some examples.

error(gpa): memory address 0x23b0e220200 leaked:
this is what I get when I exit some of the examples. namely:
clear,
lua,
sprite-animation
might happen in others but not persistently.
Win10 64

full log:
log.txt

Thanks! I'll check these out

@Bananaft are these fixed for you in the latest version? I'm not getting any leak errors when running the examples with --release=safe


Deploying WebJobs from TFS to App_Data causes DeploymentClientServerException

I am seeing the follow exception when deploying to Azure.
An error was encountered when processing operation 'Delete Directory' on 'D:\home\site\wwwroot\App_Data\jobs'.

It is one I have seen before and the belief is that WebJobs are running so there is a file lock which prevents this folder from being deleted.
I can set the DoNotDelete flag as a workaround for now, but I was wondering how I can release the handle of this folder so it can be deleted. Any ideas how to stop the WebJobs?
We deploy an API to a Azure web service and execute a "stop" beforehand, and if I redeploy a failed release, it works the second time.
Any guidance would be much appreciated.

You can try setting WEBJOBS_STOPPED=1 is your Web Apps's App Settings. See https://github.com/projectkudu/kudu/wiki/Web-Jobs#configuration-settings

I'll give that a whirl and let you know the outcome - thanks.

@davidebbo Unfortunately, I still get the intermittent problem. One release works, the second release fails. I will continue to investigate and let you know if I find out what is causing this exception in our environment here.

You can also try fully stopping the site. However, once stopped you won't be able to deploy via git or msdeploy. And once you restart, maybe the lock will be taken again. So not sure it'll help, but something to play with.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Fails at npm run setup

I have downloaded the project, it fails on npm run setup with the following error
info No lockfile found.
[1/4] 🔍  Resolving packages...
error Couldn't find package "rxjs" on the "npm" registry.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Couldn't find package "ansi-colors" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "babel-loader" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "babel-plugin-istanbul" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "browserslist" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "cacache" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "copy-webpack-plugin" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "critters" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "css-loader" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "esbuild-wasm" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "glob" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "https-proxy-agent" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "inquirer" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Couldn't find package "jsonc-parser" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/usr/local/lib/node_modules/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/local/lib/node_modules/yarn/lib/cli.js:750:123)
    at NpmResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:50683:15)

I appreciate any help.


Allow configure a Audio delay at player level

Have you read the FAQ and checked for duplicate open issues? yes
Is your feature request related to a problem? Please describe.

Some Smart TV has an audio delay when there are connected to Soundbars. I would like to be able to configure an audio delay at the player level.
Describe the solution you'd like

Allow to configure the delay level in the player, typically between 0ms and 200ms.

@joeyparrish , I tried to implement it with your comment. But the most of the streams has mediaState.needInitSegment = false, so the timestampOffset is not applied. I tried to put a custom offset in the MediaSourceEngine.setTimestampOffset_ but the stream doesn't load. Any idea?

This request is very old and is no longer necessary. Thanks!


Automated cherry pick of #2219: quota-set 新增 secgroup 字段

Cherry pick of #2219 on release/2.10.0.
#2219: quota-set 新增 secgroup 字段

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@c18cd16). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.10.0   #2220   +/-   ##
================================================
  Coverage                  ?   7.54%
================================================
  Files                     ?     410
  Lines                     ?   63645
  Branches                  ?       0
================================================
  Hits                      ?    4800
  Misses                    ?   58433
  Partials                  ?     412

Flag
Coverage Δ

#aFlag
7.54% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18cd16...aef3d52. Read the comment docs.

/lgtm

/approve


Fix database creation for GTDB r214

As mentioned in https://github.com/soedinglab/MMseqs2/issues/740, the protein FASTA files in GTDB r214 are now individually compressed. Because the mmseqs tar2db command only includes files that finish wirh .faa, the protein files are being ignored and the database is not being created.
This PR just changes this line to change --tar-include 'faa$' to --tar-include 'faa.gz$'.

@apcamargo Thanks for opening this PR. In order for this code to work, I think one more change is also needed, in line 139 (VERSION has now become VERSION.txt):
Current code:
downloadFile "https://data.ace.uq.edu.au/public/gtdb/data/releases/latest/VERSION" "${TMP_PATH}/version"

Revised:
downloadFile "https://data.ace.uq.edu.au/public/gtdb/data/releases/latest/VERSION.txt" "${TMP_PATH}/version"

Mind making this change as well? Thanks!

Done!

Thanks!

Thank you!


How to align the IMU to Lidar? && Problems with the KITTI dataset

I was testing sequence00 on the kitti dataset, and what's happening is that if I don't use the IMU data from the dataset, it end up with a pretty good result, with a little bit of a bias, but when I add the IMU data, it end up with a pretty bad result.
The calibration file of the kitti dataset contains the calibration file of imu_to_velo, which contains a rotation matrix of 3X3 and a translation vector of 3X1. How can I add these data into the program to make the IMU and lidar align correctly?
One more thing, the introduction says “our current implementation for range image projection is only suitable for sensors that have evenly distributed channels.  If the point cloud is not projected properly, you will lose many points and performance.” doesn't the 64-line lidar used in the Kitti dataset have evenly distributed channels? If so, will it affect the loop detection effect of the algorithm? Because when I tested the kitti dataset, it did not have the effect of loopback detection.

Hi，I have the same question,do you solve it?

doesn't the 64-line lidar used in the Kitti dataset have evenly distributed channels?
More information about that lidar can be found here https://velodynelidar.com/products/hdl-64e/

I didn't use IMU with KITTI dataset, sorry can't help you with that.

Thanks for your @TixiaoShan reply! I‘ll try to make a customized range image projection implementation.

The question about IMU, how do you make the IMU and lidar align correctly with your own dataset?Did the IMU and lidar positions almost coincide when you made your own data set?

@zcg3648806
Did the IMU and lidar positions almost coincide when you made your own data set?
Yes, I tape the IMU right on top of the lidar.

Thanks for your @TixiaoShan reply! As you said, I think one of the reasons the imu of the kitii data set didn't perform well was that there was a distance between the imu and the lidar,it's my guess.
But I think it's not the main reason, when i run the kitti dataset , map construction jumps, and I don't know why yet. I'm trying to figure out why.
Again on the imu, when you make your own data set, is the xyz axis directions of the imu aligned with the lidar?

Thanks for your @TixiaoShan reply! As you said, I think one of the reasons the imu of the kitii data set didn't perform well was that there was a distance between the imu and the lidar,it's my guess.
But I think it's not the main reason, when i run the kitti dataset , map construction jumps, and I don't know why yet. I'm trying to figure out why.
Again on the imu, when you make your own data set, is the xyz axis directions of the imu aligned with the lidar?

Yes, my mounting of IMU strictly follows ROS standard.
https://www.ros.org/reps/rep-0103.html
https://www.ros.org/reps/rep-0105.html

@zcg3648806  Hello！May i ask you where i can find the IMU data of sequence00 data of kitti dataset？thank you~

@14212094 Sequences are sourced from odometry datasets, and the odometry datasets are just subsets of the raw data. so If you want the imu data, you can download raw data directly.The raw data for each sequence is listed below(The following Numbers represent the sequence of frames from the raw data)
00: 2011_10_03_drive_0027<PHONE_NUMBER>40
01: 2011_10_03_drive_0042<PHONE_NUMBER>00
02: 2011_10_03_drive_0034<PHONE_NUMBER>60
03: 2011_09_26_drive_0067<PHONE_NUMBER>00
04: 2011_09_30_drive_0016<PHONE_NUMBER>70
05: 2011_09_30_drive_0018<PHONE_NUMBER>60
06: 2011_09_30_drive_0020<PHONE_NUMBER>00
07: 2011_09_30_drive_0027<PHONE_NUMBER>00
08: 2011_09_30_drive_0028<PHONE_NUMBER>70
09: 2011_09_30_drive_0033<PHONE_NUMBER>90
10: 2011_09_30_drive_0034<PHONE_NUMBER>00

@zcg3648806 OK！Thank you so much~

@jmachuca77 , Sorry for the late response.

I couldn't access your video. The link says video unavailable.
I use pixhawn and PX4 (and not ardupilot) and  mavros to get the data in ros format
Imu data from mavros is coming at 100Hz and  in ROS standard frame (ENU) as described by TixiaoShan.

@zcg3648806 hello，the 03: 2011_09_26_drive_0067 can't be found in official website. Do you have this dataset? Or，do you know why it can't be found? my Email<EMAIL_ADDRESS>


refactor(docs): format docs and Markdown files

Branched from #4645. Let's merge that one first.
Ensures formatting for all **.md files and everything in the /docs folder, including prose wrap.

@fforootd why do you think that issue templates should not be formatted?
For example, this one still looks the same when rendered before and after:
https://github.com/zitadel/zitadel/blob/main/.github/ISSUE_TEMPLATE/bug_report.md
https://github.com/zitadel/zitadel/blob/format-docs-and-md/.github/ISSUE_TEMPLATE/bug_report.md

@mffap do you want to review this? What do you think about formatting all .md files with --prose-wrap breaking lines in source code but not on the rendered html?

@mffap do you want to review this? What do you think about formatting all .md files with --prose-wrap breaking lines in source code but not on the rendered html?

tbh. no, I don't 😅 I don't get what's the value of any of this.

Less conflicts on the long run, for example.
But we can also close it if nobody cares.

I will do the review, and I think its worth to enforce linting rules to reduce the spread of different styles.


[Task]: Redeploy infrastructure of Playground to fix terraform state

What needs to happen?
Terraform state of Playground stored in GCS bucket has some missing variables. This blocks automatic deployment via terraform apply. We need to redeploy the infrastructure to fix the state.
Issue Priority
Priority: 3
Issue Component
Component: beam-playground

.take-issue

Not requires anymore since we moved to GKE clusters


minor: Added the support to ordering types

By default RavenDB orders everything lexicographically, with this change the ordering type can be choosen,

Pull Request Test Coverage Report for Build f2a1f26172f83f75c7572ab1aac34391a2339402-PR-25

5 of 6 (83.33%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 86.74%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/rql/query_parser.ex
5
6
83.33%

Files with Coverage Reduction
New Missed Lines
%

lib/connection/executor/request_executor_worker.ex
1
67.92%

Totals

Change from base Build d631b448de19d847e52460d487ba24c0fe54ad75:
-0.2%

Covered Lines:
713

Relevant Lines:
822

💛  - Coveralls


feat(lep): recurring snapshot delete design

https://github.com/longhorn/longhorn/issues/3836

It seems that action create is responsible to create snapshots/backups only while action delete is responsible to delete snapshots/backups only. Then does it mean that users need to launch one create job + one delete job to achieve the effect of the previous recurring jobs?

There is no difference between the new create action and the current recurring job implementation: periodically create snapshot/backup + recurring job owning snapshot purge.
And the delete action periodically purges all snapshots (except the latest backup).

What I am thinking is:

Add a new boolean field to indicate if retain should count the snapshots/backups not created by the current job.

Do you mean we should respect the current job retain?

Add a new boolean field to indicate that a job needs to create any snapshots/backups.

I prefer to deal by action. It can also work if there are more recurring job actions to come, ex: https://github.com/longhorn/longhorn/issues/5186.

BTW, we plan to rely on recurring jobs to trigger snapshot purge periodically. Will we do anything about this? For example, if retain == 0 or the current snapshot/backup count is not greater than retain, the job will blindly send a purge request only. I don't know if there is a separate ticket for it. The ticket I found is actually similar to what you mentioned.

Currently, recurring job cleanup by the cleanupSnapshotNames then follows with the purge. The plan is RecurringJob with delete action will have its own cleanupSnapshotNames so it can be used for purge.

There is no difference between the new create action and the current recurring job implementation:

OK. The action name create is a little bit misleading...

Do you mean we should respect the current job retain?
I prefer to deal by action. It can also work if there are more recurring job actions to come

In your current design, when the action is delete, retain will calculate all kinds of snaps including user created or other jobs created. But when the action is create, retain just counts its own snaps, right?

The plan is RecurringJob with delete action will have its own cleanupSnapshotNames so it can be used for purge.

For this part, the requirement is, having a mechanism triggers the snapshot purge only (without deleting existing valid snapshots). Since some operations like trim may generate removed or system snapshots without a following purge request, or somehow the previous purge/snapshot deletion may be interrupted, having this mechanism can help a lot. Can we achieve this here?

In your current design, when the action is delete, retain will calculate all kinds of snaps including user created or other jobs created. But when the action is create, retain just counts its own snaps, right?

right.

For this part, the requirement is, having a mechanism triggers the snapshot purge only (without deleting existing valid snapshots). Since some operations like trim may generate removed or system snapshots without a following purge request, or somehow the previous purge/snapshot deletion may be interrupted, having this mechanism can help a lot. Can we achieve this here?

Sure, added action purge.

In your current design, when the action is delete, retain will calculate all kinds of snaps including user created or other jobs created. But when the action is create, retain just counts its own snaps, right?

right.

OK. Here I am thinking if we can make it more intuitive... The naming of action create is misleading as well.

For this part, the requirement is, having a mechanism triggers the snapshot purge only (without deleting existing valid snapshots). Since some operations like trim may generate removed or system snapshots without a following purge request, or somehow the previous purge/snapshot deletion may be interrupted, having this mechanism can help a lot. Can we achieve this here?

Sure, added action purge.

Do we need one more action purge? How about asking users to set a delete job with a large retain number? I mean, a snap delete job will send a purge request regardless of the current snap count reaching the retain limit. Will this be tricky?

OK. Here I am thinking if we can make it more intuitive... The naming of action create is misleading as well.

Any ideas?

Do we need one more action purge?

I think there could be two use cases:

user just wants to periodically clean up system snapshots.
user wants to periodically delete all snapshots.

How about asking users to set a delete job with a large retain number? I mean, a snap delete job will send a purge request regardless of the current snap count reaching the retain limit. Will this be tricky?

Not sure if we should consider the delete job cleanup the snapshot of the create job before the create job reached the retaining number. Respecting other retaining is tricky and IMO over complexing the solution.
The assumption is the delete/purge action will not be set to a frequent interval as the snapshot/backup so I prefer to leave this to the user.

How about asking users to set a delete job with a large retain number? I mean, a snap delete job will send a purge request regardless of the current snap count reaching the retain limit. Will this be tricky?

Not sure if we should consider the delete job cleanup the snapshot of the create job before the create job reached the retaining number. Respecting other retaining is tricky and IMO over complexing the solution.

No. I mean, For SnapshotDelete jobs, it will blindly send a snapshot purge request. A purge request won't mark any valid snapshots as Removed, instead, it is just for cleaning up accumulated removed/system snaps. This does not involve respecting other retention.


pdfgrep on PowerShell :: file name not shown

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I'm using pdfgrep  on WSL2 and while on Windows Terminal is working well on PowerShell is not printing the full output.
At the beginning I guessed it was because of the colour of the output and PowerShell background being blue but now I'm not sure
STEPS

apt-get install pdfgrep
pdfgrep -HinR 'SearchedWord' TargetFolder/

Expected Behavior
In WSL2 on Terminal you see the file name:

Actual Behavior
In WSL2 on PowerShell you don't see the file name:

Expected behavior
PowerShell should print the whole output

Actual behavior
Windows Terminal is printing the whole output but not PowerShell

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1320
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Visuals
See pictures above

Try to set TERM env variable to dump or set NO_COLOR env variable to 1.

I think this is a PowerShell 5 problem in the traditional windows console.
By default Windows PowerShell changes the console colour "Dark Magenta" in the old-style Windows console  to a shade of blue, and makes that the background colour.
Looking at the screen shots, the file name is being output in .... Dark Magenta.
if you use $host.UI.RawUI.BackgroundColor = "black"  and then run the command you'll see the text - to get it display in magenta you need to go to the console properties and set the 6th colour back to a dark magenta.
If you use PowerShell core (6 or 7) or if you run Windows PowerShell in the new Windows Terminal the text will be visible (although not very visible on Windows PowerShell's blue background).

"Dark Magenta" was the problem.
$host.UI.RawUI.BackgroundColor = "black" didn't work because you switch to black but then it comes back to blue when you start WSL.
The solution was to install the latest PowerShell through winget install --id Microsoft.Powershell --source winget.
Fixed!


⚠ Bofrost.be has degraded performance

In 64e4e97, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1929 ms

Resolved: Bofrost.be performance has improved in e7262fd.


[VUE] When jumping from one comment area to another, the comments on the previous page are still displayed

How to reproduce:
Enter the following webpage, after the comments are loaded, click "Next Page" in the lower right corner to observe the comments.
https://strapi-community.github.io/strapi-plugin-rest-cache/guide/#frontmatter-title
Display

This is just due to how Vue works and how your website is set up.
https://github.com/strapi-community/strapi-plugin-rest-cache/blob/main/docs/.vitepress/theme/Layout.vue
When you switch to a different page, none of the attributes of the giscus component changes, and Vue tries to be smart by reusing the component, as it thinks the component has not changed.
You need to either use a key attribute with a value that changes when you navigate to a different page, or use other ways to ensure that the component gets re-rendered when the page changes.
https://vuejs.org/api/built-in-special-attributes.html#key

通过:key已解决


⚠ Orpheus has degraded performance

In fad6814, Orpheus ($OPS) experienced degraded performance:

HTTP code: 200
Response time: 1302 ms

Resolved: Orpheus performance has improved in 37993d6 after 8 minutes.


Cherry Pick GA Work

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-search-documents


[LEGACY_BATTERY_STATS]

So here's my theory. My battery manager placed cookies in all media, and photos. With that being said this includes, picture's, music, website's, anything that basically produces a sound or creates friction like taking pictures and the flashlight going off. This also includes High contrast images, SPEN stylists, charging your device, etc. I am having an issue with the RF linking to a spam Ai who poses as a legacy but really is a scammer.

#assign:xelu86

Thanks again for contacting Microsoft. We value your feedback.
We're unable to determine what the intent of your question is. If there are any errors or areas of improvement with said documentation, please let us know so we may better assist.
We're closing this issue but please feel free to reopen it and advise us what revisions may be needed. Thank you and have a most pleasant day. #please-close


Add runtime config support to CLI switch and inspect cmd

Allow CLI to override Job config file's runtime property via --runtime switch.
Every other Job property has this behavior.
Show runtime value in inspect command's output.

cc @spotify/docker-admins

Codecov Report

Merging #1234 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1234      +/-   ##
============================================
+ Coverage     52.73%   52.76%   +0.02%
- Complexity     1624     1627       +3
============================================
  Files           268      268
  Lines         13054    13061       +7
  Branches       1507     1508       +1
============================================
+ Hits           6884     6891       +7
- Misses         5647     5650       +3
+ Partials        523      520       -3

👍


Add an option to auto-trim the RichTextBox contents (i.e. fixed number of lines or paragraphs)

Discussed in https://github.com/serilog-contrib/serilog-sinks-richtextbox/issues/11#issuecomment-912642600

Originally posted by TonyValenti September 3, 2021
add an option to auto-trim the text box. If, after writing, a log entry, the text box has more than X number of paragraphs, remove the first items from the text box until there are less than X

Using a paragraph per log entry simplifies this so that A log entry won't be broken in half.

@augustoproiete -
After a lot of testing, we determined that autotrimming is something that is best implemented in the logger and not in the control itself.
When the control is responsible for trimming, it has to hook into the "Text/Document" Changed event which triggers with every change to the document.  This is bad because:

A single log operation may alter the text box multiple times (resulting in multiple calls to the trimming function).
Even if you consolidate (1) down into a single DOM change per log entry, when lots of log entries output at once, you'll still have multiple invocations of the trimming code.

By implementing scroll and trimming in the logger, you can be much more efficient.  In my PR, if multiple log entries are appended at once:

The log entries are added in batch
The trimming/scrolling code happens once after the batch is processed.

Also, by allowing the logger to implement itself, it keeps the consumer from having to worry about implementation details changing.  For example: "How are log entries separated?"  If the control implements the trimming, then the consumer has to know how the newlines are being appended and respond accordingly.
Imagine how differently people would feel if serilog took the approach "We're not going to create a rolling file logger.  We're going to make everyone be responsible for cleaning up their own logs."  Yes, people would do it (and they'd do it a million different ways with varying goodness), but it is such a common and necessary scenario, it should be built right in (and it is!).
The auto-trim on the text box is essentially the same thing.


2024-12-19_01-36-10_master-next_aws-cli

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10875-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10875-to-kirkstone-next
git switch --create backport-10875-to-kirkstone-next
git cherry-pick -x 130c59b4e149cd7a0afc9ddccff556909aa8a384

Successfully created backport PR for scarthgap-next:

#10877

Successfully created backport PR for styhead-next:

#10878


Showcase inference example does not print results

The example in the showcase for inference:
from fuzzylogic.classes import Domain, Set, Rule
from fuzzylogic.hedges import very
from fuzzylogic.functions import R, S
temp = Domain("Temperature", -80, 80)
hum = Domain("Humidity", 0, 100)
motor = Domain("Speed", 0, 2000)
temp.cold = S(0,20)
temp.hot = R(15,30)
hum.dry = S(20,50)
hum.wet = R(40,70)
motor.fast = R(1000,1500)
motor.slow = ~motor.fast
R1 = Rule({(temp.hot, hum.dry): motor.fast})
R2 = Rule({(temp.cold, hum.dry): very(motor.slow)})
R3 = Rule({(temp.hot, hum.wet): very(motor.fast)})
R4 = Rule({(temp.cold, hum.wet): motor.slow})
rules = Rule({(temp.hot, hum.dry): motor.fast,
(temp.cold, hum.dry): very(motor.slow),
(temp.hot, hum.wet): very(motor.fast),
(temp.cold, hum.wet): motor.slow,
})
rules == R1 | R2 | R3 | R4 == sum([R1, R2, R3, R4])
values = {hum: 45, temp: 22}
print(R1(values), R2(values), R3(values), R4(values), "=>", rules(values))
The print does not output the given values.   Instead, it outputs the following:
print( R1( values ), R2( values ), R3( values ), R4( values ), "=>", rules( values ) )
^^^^^^^^^^^^
File "C:\Users\mysixa\AppData\Local\Programs\Python\Python312\Lib\site-packages\fuzzylogic\classes.py", line 447, in call
index = sum(v.center_of_gravity * x for v, x in weights) / sum(x for v, x in weights)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\mysixa\AppData\Local\Programs\Python\Python312\Lib\site-packages\fuzzylogic\classes.py", line 447, in
index = sum(v.center_of_gravity * x for v, x in weights) / sum(x for v, x in weights)
~~~~~~~~~~~~~~~~~~^
TypeError: unsupported operand type(s) for *: 'method' and 'float'
Is there a correction to the example which will correctly output the values as expected in this example?
Thank you very much

Ah, yes. Sorry about that. The bug is already fixed, but I didn't release it yet. There is a () missing. You can put it in yourself - it's supposed to be v.center_of_gravity()

That fixed it nicely.
Thank you very much

Oh. How embarassing. I used that to debug when I refactored the defuzzification. Just search for print('ohalala') and delete it. There is no instance of that in my current code, so it will be gone in the next release.


Refactor ConsulServerList for extensibility

The ConsulServerList class is not implemented in a way that allows for clients to extend the class and change it's behavior. My company has some rather unusual requirements about how we interact with Consul so having hooks within this class to change it's default behavior would be great for us. We don't want to make massive changes to how it works, so I would rather not copy/paste/update the existing class.

What are the "rather unusual requirements"?

We have multiple data centers and a handful of services run in more of an active/passive pattern so there are certain times where we will want to get a list of services from not the default data center that consul will return
We use the health checks that sometimes use a warning but we want to use healthy services first, and then services with a warning when necessary
We want to have our clients prefer a local instance of a service when available to minimize network latency when it isn't necessary so I would like to be able to sort the returned services in a more precise manner than what Consul would return

Is this helpful? I tried extending the class but ran in to a couple road blocks. If you'd rather not make extending this class the preferred pattern that is OK, I can implement our version from scratch, it's not that much code.

At this point I'd prefer you have a custom ServerList until we see if more people would want this.

Sure, that works too. Just wanted to put this out there in case it was useful for others.


3d plots not working correctly

When I use the pgfplots package and try to render a 3d plot with the function \addplot3, it doesn't show correctly with either the mesh option or the surf option.

I also have this issue, the sampling seems to cut off prematurely, the issue is worse with more samples.


num_MSA_sequences

Does num_MSA_sequences affect the final result? I retrained proteinnpt on assay IF1_ECOLI_Kelsic_2016 with msat, but got spearman 0.614.

Hi @ZhummCrow -- num_MSA_sequences (default 384) will have an impact on the embeddings obtained for each sequence -- it corresponds to the number of sequence sampled from the MSA that is input in MSA Transformer. We use the default MSA Transformer hyperparameter values here. If not running into GPU mem bottlenecks, you may be able to get higher performance by increasing that value to a larger value.
Also note that the final performance you obtain (eg., 0.614 spearman) will vary significantly dependently depending on the particular cross validation scheme you are looking at (eg., random, modulo, contiguous).
Best,
Pascal

Ho @ZhummCrow -- closing this issue as I believe the above addressed your question. Feel free to re-open as needed.
Kind regards,
Pascal


Fix tf.train.AdamOptimizer bug when use with tf.keras.callbacks.ReduceLROnPlateau

fix #20999

still have problem


Improved parsing of SVG coordinate pairs

Seems, some SVGs separate the coordinates not by whitespace, but by commas. This updated code checks which is the case.

This was a quick patch, but I'm actually looking more into the code and might provide another update. For me it seems, the PATH parsing in SVG.js is rather simple and doesn't work with a lot of SVG files.

You should imho not invest much into it. You should change to canvg and/or svg2pdf.js
I am adapting changes of yWorks fork of jsPDF, so that svg2pdf.js is working directly in the original jsPDF. If svg2pdf.js is able to work with this jspdf then probably I will deprecate the svg.js.

Ok, thanks for letting me know. I guess I will wait then as well. I do not want to use a canvas as I'm interested getting my SVGs as vector objects into the PDF to make them scale.

Dont worry. jsPDF has a canvas-adapter, which simulates a canvas and results in vector objects in the PDF.

Dont worry. jsPDF has a canvas-adapter, which simulates a canvas and results in vector objects in the PDF.

So better use addSvgAsImage?

No, check examples/canvg_context2d


Add primitives for loading and saving step results [Step results #3]

Pull Request Checklist
Depends on https://github.com/teemtee/tmt/pull/2977

[x] implement the feature

Blocked on https://github.com/teemtee/tmt/pull/3107 - after swapping phase results for subresults, we can add the actual (step) phase result class.

Unrelated failure, merging.


Portrait Image issue

Greetings
I have an image that i deepzoom with a size of <Size Width="2368" Height="4208"/>
When viewed in the seadragon control it looks like only the upper left hand quadrant is available.
If i then rotate the image and re-deepzoom it works just fine.
Is there a known bug with seadragon that it does not like portrait images? am I doing something wrong?
Regards

No, this should work just fine. Can you share how you're adding the image? Do you have a link to this I can see?

Greetings Ian
you can use this dzi:
https://mediastoreproduction.blob.core.windows.net/78d6cdca-9466-4e26-a965-60f957359068/deepzoom/deepzoom.dzi
Thanks you kindly

http://codepen.io/anon/pen/vOvGLQ
From the console, it looks like a lot of tiles are missing.
How did you generate the pyramid?

I generated them by myself - and I assure you all the tiles are there. It is just that seadragon is not referencing them.
eg here is the tile fro level 12 and a column/row  that is never referenced:
https://mediastoreproduction.blob.core.windows.net/78d6cdca-9466-4e26-a965-60f957359068/deepzoom/deepzoom_files/12/8_4.jpg
attached is the original image
Thank again for your assistance!

I regenerated a pyramid from your image.
Here is the result in OSD:

You can download the pyramid here: https://drive.google.com/file/d/0BzAcRIdakTF0bGVDUnJRUUJNNW8/view?usp=sharing

Greetings avandecreme
would you mind giving the pseudo-code for the algorithm to generate the tiles that you used?
I only generated 12 levels (0-12) is that maybe my error? - just strange that i have no erros with images that are in landscape....
Regards, and thank you all for your investigation, time and assistance.

Thank you all for your help I had a bug in my tile generation that caused an incorrect amount of levels to be generated for portrait images.
It is now working wonderfully.
Regards.

Glad you were able to get it sorted out!


[Bug]: Text styles of bold/italic/underline are not saved in history

Package Version
4.0.4
Flutter Version
3.22.2
Platforms
iOS
How to reproduce?
I was able to create my own bold/italic/underline buttons for the text editor as per your recommendation here:
https://github.com/hm21/pro_image_editor/issues/67
It all works fine and the saved image has the styles (with the exception of bold which still doesn't seem to take effect, see comment here: https://github.com/hm21/pro_image_editor/issues/67#issuecomment-2156307329).
However, the history does not seem to save these parts of the text style. When I reload the history the text has resorted back to the plain style with no underline/italic.
To set underline, I use an AppBar icon that triggers this:
final newDecoration = textEditor.selectedTextStyle.decoration == TextDecoration.underline
    ? TextDecoration.none
    : TextDecoration.underline;
final newStyle = textEditor.selectedTextStyle.copyWith(decoration: newDecoration);
textEditor.setTextStyle(newStyle);

Logs (optional)
No response
Example code (optional)
No response
Device Model (optional)
No response

Thanks for reporting this issue.
To be honest, I didn't see your comment in #67 and thought it's resolved already😅
Anyway, I just released version 4.0.5 which should fix it. Please let me know if this issue still exists by you.

Thanks, fixed!!


Este for npm components workflow

Basically it's the same dev stack, so can be used right now, but I should describe the whole process. I would rather do not create another steida/este-component stack, even though it would be a cleaner solution maybe. As I see it, what we need is a gulp task for "cleaning" project for empty app and empty component.
For component

split deps to dev and general in package.json
write component in "BabelScript", publish it as one build file, the same approach like building app. I believe published component should be minimal. No need to traverse anything or have "readable" source I suppose.
validate package.json, remove private etc.

Hm, is this something we can move to cli now? este-cli new myapp --clean

Well, I think this is no longer relevant when we have cli :)

Yes :-)


Make sure MTRPumpConfigurationAndControlPumpFeature has the right availability annotation

This is being added in https://github.com/project-chip/connectedhomeip/pull/23824

This was fixed in https://github.com/project-chip/connectedhomeip/pull/24503


New logic std

*moved logic from core to logic
*added logic gate operators (AND,NOT,OR) you can implement any gate with a NAND so now all are possible in pure neva
*implented IsGreater and IsEven
*made Range work in reverse also (it would go on forever before)
*added examples for all of these, modified copare values to showcase NOT

I decided to remove the num_comparison example since IsEven got removed which made it pointless (we already have an example for If and Gt doesnt require one)


Refactor tests

Work from this comment https://github.com/grafana/iot-sitewise-datasource/pull/179#discussion_r1190933637
Sample PR: https://github.com/grafana/iot-sitewise-datasource/pull/190

If it's clear to you which tests remain to be refactored, would you add a checklist or something?

closing as not planned


Patch 10.2 LUA error

Please include as much of the following information as possible to help me fix the bug:
Brief Description of Bug
Popped up after handing in profession quest and receiving the rep and Knowledge item.

Just did the same quest on a different character. It is the weekly Alchemy proff quest "Examination Week". It gives Valdrakken and Artisan Consortium rep. Happened on the mining one too which is for the same reps.
Also had same error pop when I did a WQ which gave Dragonscale Explorers rep.
Maybe they changed the rep ids with the additoin of the new rep?

Hmm. Maybe it's more than just the current expansion rep. Just got the same error when I handed in "The Assault Base". This is alliance side Draenor garrison shipyard quest. Rewarded Hand of the Prophet rep.

Can you screenshot your currencies tab for the character?

(I suspect there's a currency in there that's breaking the Journalator code)

Got a workaround:
Journalator-1.68-1-g107c4a9.zip
It looks like a Blizzard API is returning bad values, this will cause them to be safely ignored.

Looks like that fixed it. Just did a WQ and no error :-)

Great. I'll close the issue now - should it reappear comment here and I'll reopen it.


Reduce use of host status more

Add isHostUp() and getAgentInfo() to MasterModel
so that DeadAgentReaper doesn't need to get the entire
HostStatus. This should alleviate pressure on ZK.

Current coverage is 51.39% (diff: 71.42%)

Merging #1037 into master will increase coverage by <.01%

@@             master      #1037   diff @@
==========================================
  Files           275        274     -1
  Lines         13076      13044    -32
  Methods           0          0
  Messages          0          0
  Branches       1695       1694     -1
==========================================
- Hits           6720       6704    -16
+ Misses         5849       5837    -12
+ Partials        507        503     -4

Powered by Codecov. Last update 9cb7082...cc157bb


Replace Params with ctx.UserValues

This PR uses: handle(ctx *fasthttp.RequestCtx)
Instead of: handle(ctx *fasthttp.RequestCtx, ps fasthttprouter.Params)
And
Replaces Params with RequestCtx.UserValues
So that:

Chaining of other fasthttp based middleware functions is much easier.
Removes the only major memory allocation that is happening in fasthttprouter and httprouter

This will break the current API for existing users though...

Coverage remained the same at 100.0% when pulling a4aeb2133700127fdb724f12bacad6bdac831277 on gofury:remove_params into 0729217d031ab353a3e34b94e8544e167f7ce9a4 on buaazp:master.

If anyone is interested, I've made a fork of this change at: https://github.com/gofury/furyroad
It's still very much work in progress, but so far so good using it for work projects.

Interesting. Use fasthttprouter.Params for handler is JUST because I forked from fasthttp in begining. I think compatibility with fasthttp midwares is more important following the original fasthttp repo.
I will merge this PR in a few days.

Awesome thanks. I'll remove my fork once merged.
The original httprouter.Param also had the same compatibility issues with standard net/http middleware and chaining libraries such as https://github.com/justinas/alice. This is where fatshttp library sets itself apart nicely by offering helpful features such ctx.UserValues.

I want to rebase the origin httprouter's latest commits for the first release. To fix the merge conflicts I will force push a new commit to the master branch.
Can you merge your all 3 commits in this PR to one commit? Because I had to fix the boring conflicts.
Or if you have time, you can try to fix them.

Or you can reopen a new PR for this target base on my new master branch.

Woooo. Finally I succ merged your commits into master branch now.
Thanks for your work again~

Sorry haven't been check email often these days, surprised that the rebase resulted in 80+ commits. Thanks for merging.

✌


Website as data source

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

This is not a bug but an inquiry. We have lots of documentation on Confluence, it would be great to feed all of the internal documentation into the private chatbot.
Any idea how to handle that kind of use case?

Yes, I actually talked about that in our live stream today-
Video - https://aka.ms/hacktogether/chatapp/session3
Slides - https://speakerdeck.com/pamelafox/customizing-your-rag-chat-app
So, what I've done in the past is just converted the webpages to PDFs, fed those in the usual way, and then reversed the PDF filenames to figure out what URLs to show in the web UI. I used Playwright to save as PDF, per this blog post: https://blog.pamelafox.org/2024/01/converting-html-pages-to-pdfs-with.html
There are better approaches than that that involve more code, however.

Use Azure Document Intelligence to parse HTML. According to their docs, they now support HTML, so you would just need to modify the prepdocs filestrategy.py script to also look for .html files
Use a local HTML parser, and bring that into the prepdocs scripts. You can see how PR 1195 adds a JSONParser, and make the same change to bring in an HTML parser. Here's a possible HTML parser class you could use.

Thank you Pamela, great video, it helped me a lot on understanding more the code.


Request for dataset！

Nian Shao, congratulations on your paper being accepted by ICASSP 2024!
Could you share the external dataset (7384) and annotation file? I would appreciate it if you can help me!

Hi Harper,
Thanks for the congradulation ; )
As for your request, I am sorry that I cannot provide you all the .wav files. But what I can do is to provide the full annotation file we used in the ATST-SED work.
The strongly-labelled AudioSet is very large, and whether uploading or downloading the dataset is time-consuming. On the other hand, Im not sure if we had the correct license to share them, since most files are downloaded from the Youtube and protected by some policies.  You could follow the instructions here to download the dataset (might take one month to download the entire unbalanced dataset, but if you specify the filenames, I think it would only take days). PS: I would attempt to upload the files and let you know if I can do so.
In the annotation file, I annotated each file with: [train/eval] (from AudioSet) + filename. And the event annotation format kept the same as in the DESED dataset.
Enclosed with the annotation file.
desed_in_audioset_strong.zip

@Harper812 Try (this)[https://saoyear.github.io/post/downloading-real-waveforms-for-desed/]

Nian Shao:
Congratulations again!
I’m deeply grateful to you for organizing and sharing the datasets, which will greatly assist me in academic research.
I hope your research achieves fruitful results in the future!

No problem! Glad to help : )


WIP:Update README, sorting, readme, npm

It seems all the READMEs are quite outdated. I've updated them.
Things to do:

[ ] Add links to Material Design Specs
[ ] Update package READMEs (npm shields, …)

BTW: Can someone please explain to me what's the difference between Bottom Navigation and Bottom Navigation Bar?

BTW: Can someone please explain to me what's the difference between Bottom Navigation and Bottom Navigation Bar?

@FestplattenSchnitzel bottom navigation bar is a new component to draw a bottom navigation bar in matérial design.
bottom navigation is a simple extract of the component from N. the idea is tonbw able at one to remove it from N. as it uses material libs it has its place here.
in the future things could get refactored. but for now it must remain that way for easy transition

@FestplattenSchnitzel bottom navigation bar is a new component to draw a bottom navigation bar in matérial design.
bottom navigation is a simple extract of the component from N. the idea is tonbw able at one to remove it from N. as it uses material libs it has its place here.
in the future things could get refactored. but for now it must remain that way for easy transition

@FestplattenSchnitzel already looks really cool !

@FestplattenSchnitzel already looks really cool !

@farfromrefug this is now ready from my side.

@FestplattenSchnitzel awesome! Thanks a lot!


[Bug]: Deployment fails when using private submodules via Github App Source

Error Message and Logs
When using a private submodule within my repository the deployment fails with
Current behaviour

Main repository clones successfully using HTTPS token authentication<EMAIL_ADDRESS>When GIT_SSH_COMMAND="ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null" git submodule update --init --recursive runs, it fails to authenticate with the private submodule

<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

I think the issue might is caused because git submodule update doesnt have either SSH creds or the access token to properly access the private repo.
Relevant code:
https://github.com/coollabsio/coolify/blob/6987e83912baa9739faa86d43af659ec133c7029/app/Models/Application.php#L936
https://github.com/coollabsio/coolify/blob/6987e83912baa9739faa86d43af659ec133c7029/app/Models/Application.php#L987
Possible solutions:
Configure Git globally to use the token for all HTTPS requests to GitHub:
git config --global<EMAIL_ADDRESS>"https://github.com/"

Steps to Reproduce

Add a private submodule to an existing project
Re-run deployment

Example Repository URL
No response
Coolify Version
v4.0.0-beta.367
Are you using Coolify Cloud?
Yes (Coolify Cloud)
Operating System and Version (self-hosted)
No response
Additional Information
No response

Hi, same bug here. A GitHub deploy only works in a plublic repository.

Hi I also have same issue. For me it was only working with public repos and with https url.

I've implemented a very bad practice solution to get the deployments to work for now.

Add a fine grained access token under https://github.com/settings/tokens?type=beta
Add access to the private submodule repositories you need
Add read-only permissions for Content and metadata
Copy the token
adjust your .gitmodules file to use this token when accessing the repository, replace github_pat_XXX with the actual token

[submodule "packages/my-private-submodule"]
	path = packages/my-private-submodule
	url =<EMAIL_ADDRESS>	branch = main


Safely upgrade compatible with RuboCop AST

User can upgrade upcoming RuboCop safely, even if incompatible APIs are introduced in future RuboCop AST major updates.
The purpose is to safety the runtime impact for users, as it is already specified rubocop-ast in the Gemfile so that development can try the latest.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[ ] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Makes sense! Thanks!


Use this Redfish client without sessions

Depending on your needs, it may be interesting to only call directly the target endpoint, instead of starting with a login (ie. Redfish sessions creation), call only one endpoint then logout to prevent from leaving sessions opened.
I would like to use this Redfish client without sessions in Foreman.
To reach my goal, I used a trick to force Root to consider only basic auth as option.
See https://github.com/theforeman/smart-proxy/pull/895/files
Is there is someone in maintainers interested by this feature?

Thank you for this suggestion, @neomilium.
Unfortunately at this time, we are not taking feature requests. However, we'll be happy to review and merge any PRs that improve functionality and are of sufficient quality.

@matejart I opened https://github.com/xlab-steampunk/redfish-client-ruby/pull/8 a while back. Could you please review it?


AttributeError: 'Keyword' object has no attribute 'teardown'

When i run sherlock on a folder containing a unique and very simple test:
*** Test Cases ***
My test
    Log    Hello test

I get the following error:
Sherlock analysis of Robot Framework code:

Using <my_project_root>/sandbox as source repository
Traceback (most recent call last):
  File "<my_project_root>/.venv/bin/sherlock", line 8, in <module>
    sys.exit(run_cli())
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/__init__.py", line 19, in run_cli
    raise err
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/__init__.py", line 9, in run_cli
    runner.run()
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/core.py", line 37, in run
    suite.visit(code_visitor)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/testsuite.py", line 399, in visit
    visitor.visit_suite(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/visitor.py", line 98, in visit_suite
    suite.suites.visit(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/itemlist.py", line 102, in visit
    item.visit(visitor)    # type: ignore
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/testsuite.py", line 399, in visit
    visitor.visit_suite(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/visitor.py", line 90, in visit_suite
    suite.tests.visit(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/itemlist.py", line 102, in visit
    item.visit(visitor)    # type: ignore
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/testcase.py", line 186, in visit
    visitor.visit_test(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/visitor.py", line 157, in visit_test
    test.body.visit(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/itemlist.py", line 102, in visit
    item.visit(visitor)    # type: ignore
  File "<my_project_root>/.venv/lib/python3.8/site-packages/robot/model/keyword.py", line 65, in visit
    visitor.visit_keyword(self)
  File "<my_project_root>/.venv/lib/python3.8/site-packages/sherlock/visitor.py", line 115, in visit_keyword
    kw.teardown.visit(self)
AttributeError: 'Keyword' object has no attribute 'teardown'
Fatal exception occurred. You can create an issue at https://github.com/bhirsz/robotframework-sherlock/issues . Thanks!

Environment

OS: Ubuntu 20.04
Python: 3.8.10
RobotFramework: 6.1
robotframework-sherlock: 0.2.0

@bhirsz you recently fixed and closed https://github.com/MarketSquare/robotframework-sherlock/issues/92, which I reported at the same time of this issue. This one is a blocker, but you haven't commented on it yet. Is it an oversight, or am I too impatient?

Don't worry, I'm keeping close eye on all issues but I just had time for one issue today and I picked randomly (mostly because it will be released in a few days in single release anyway). I should have more time tommorrow to take a look into this one (though it looks like something I fixed recently).
I also have finally access to real Robot Framework project (I was in company that didnt use RF for some time) so I will try to run some extra tests with Sherlock on bigger projects. It will be a lot easier to spot issues like this one.

I have confirmed that this issue was fixed recently in following PR: #77 The problem was that Robot Framework 6.0 deprecated "teardown" attribute (it's part of the "body" in model now). It will be part of the upcoming release.


A few small grammatical changes

Could also go with just 'add some style' or  'update the style'.

Thank you!


drivers: i2c: stm32_i2c_v2: fix I2C stability issues

Due to various reported stability issues with the STM32 I2C V2 driver in interrupt mode, the controller part is rewritten in an attempt to closely follow documentation found in reference manualand errata sheets. See #70077
A side effect should also be increased performance

Agree, the changes should be split up in different commits as far as possible, at least formatting changes
I have pushed the changes again were i have tried to separate it a bit
This time i didn't really follow the commit message rules, but i guess if it will be merged in future it would be
rewritten anyway in a squash commit


Bag spaces cannot be ungrouped - Bag divisions cannot be disabled

Addon Version
10.2.7 (most recent)
World of Warcraft Version
Retail
Describe the bug
2 issues which seem to be related. In my bank I cannot have spaces where I want them, for eg spaces between items, all spaces are stacked and grouped at the bottom of my bank meaning the items cannot have a space for separation. The only way to allow spaces is to have my bags separately showing as opposed to one big display of slots.
Additionally, when opening bags, whether in the bank or not,  the bag divisions cannot be removed, unless I have the spaces all gathered together at the bottom so I am forced to have bag 1, bag 2 etc with gaps between bags. I checked the options where it says "view one bag" assuming it would combine all my slots into one big bag like before but selecting one bag, forces all the empty bag slots into one stacked section at the bottom.
Thank you for all the years of bagnon also :)
Steps to reproduce
As above, open the bag and select the option

Wrong addon, this isn't Bagnon :)

Wrong addon, this isn't Bagnon :)

Oh sorry, I know that, I was thanking you for bagnon, thinking that you were the same people because Betterbags replaced it, I thought. I am using Betterbags, this is the issue I'm having.
Sorry if I've misunderstood.

BetterBags replaced AdiBags, not Bagnon -- however, I'm not quite understanding your issue. Can you screenshot exactly what you mean?

Hi, sorry for the delay, I've attached screenies, I hope it works..
To try to explain it better, I like my bags to just be one mass space (ie not separated by each bag) but if I click for that, it takes all the empty spaces and condenses them into one at the bottom. Please see first file, bag spaces, I've circled what I mean. I used to have all the bags in one huge bag and I could have spaces wherever in the bank I wanted them, so for eg, I might leave a space to separate fish and meat if you see what I mean.

The 2nd pic shows the bag separation, I can't get the bags away without having the spaces compacted as you see in the 1st pic (circled).

The 3rd pic shows my bank (and I didn't mention this before) but theres no reagent bank, I have to click it separately to see it, I cant see reagent bank and regualr bank at the same time.

I'm sorry to be so much trouble lol, thank you for helping with this.

Renamed issue to be more relevant.

Free spaces can now be expanded and shown as of v.0.1.88.


How diff.changes can become None?

@xged here's how:
>>> next(whatthepatch.parse_patch('--- a\n+++ b\n '))
diff(header=header(index_path=None, old_path='a', old_version=None, new_path='b', new_version=None), changes=None, text='--- a\n+++ b\n \n')
>>>

Yes, @graingert is correct.
Would it make more sense to initialize changes to an empty list?

Closing, no response


How to keep browser opening by the end of the code running?

Is there any way to make browser stay open after a test is finished? （Chromium MacOS ARM version）
Even i use page.Pause() or other WaitFor method, browser still auto close after  about 1 min.
Update: use local Chrome or Edge on MacOS ARM will NOT auto close. Also chromium works fine on Windows. it may some kind of bug on Chromium MacOS arm version.

the problem happened my MacOS ARM , so anyone have resolved ?

I have the same problem with my macos x86. When the logical code is finished, block the process with select{} and the browser will exit after a certain amount of time. Is this a bug?

Maybe this is related? https://github.com/microsoft/playwright/issues/12974
Might be fixed by https://github.com/playwright-community/playwright-go/pull/352


Provide Dotnet 6 Host Image with Bookworm OS.

Azure Functions needs a bookworm based Dotnet Image for downstream applications. This image is not syndicated to sov and will not be released to staged image locations.

https://github.com/microsoft/mcrdocs/pull/47338
MCR docs update for this image.


Android Basics: Forage app

Initial build is failing and it's recommending to upgrade the gradle wrapper.

The starter code is not building and running

You can apply the changes in the open pull request made by user secondsun: https://github.com/google-developer-training/android-basics-kotlin-forage-app/pull/3
I can confirm that these changes fix the build issues and now the starter code works.


contributing.md

Add one

https://github.com/joereynolds/SQHell.vim/commit/3cbd69defd54cf9e1a81dbdeee74cf53f8f8a62a


Typo

Thank you. I updated the script. However, do note that I implemented a new check for ssl after this.


Any chance getting this updated to Node20?

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20<EMAIL_ADDRESS>For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Please try v1.2 and let me know if everything works according your expectations

all good, Thank you!


Optimize LinuxForHealth images for each platform

Optimize images, including the base image used to create each image, the number of layers, etc.  Goals are minimum size and best base image for the container platform or chip architecture.

Duplicate of #28 in images repo.

Duplicate of #28 in images repo.


Outsource docstring parsing?

Candidates/inspiration:

https://github.com/rr-/docstring_parser
https://github.com/rsokl/custom_inherit/blob/master/src/custom_inherit/_doc_parse_tools/napoleon_parse_tools.py
https://github.com/sphinx-doc/sphinx/blob/master/sphinx/ext/napoleon/docstring.py

I think the how of the docstrings are parsed is not an issue as long as there is a consistent internal interface for doing so.

I'm not sure to understand what you mean by "internal interface" :slightly_smiling_face:

Define an abstract interface for docstring parsing and then just implement different versions for various docstring types: google, etc. How the actual parsing happens internally doesn't matter to the rest of pytkdocs. Just that a docstring goes in and the right data structures come out.

Ah yes! Totally.

We could layout the base: an abstract class, and the Google-style implementation. It would a bit more encouraging for those who'd like to contribute a new parser :slightly_smiling_face:

Just opened a PR if you want to take a look.

I think the implementation is good, but I'm not a fan of the parser returning an Attribute. The core is a bit of a monolith, so the intention of various objects and their data is all mixed together. I'd rather the docstring parser just return a construct (or list of constructs) that the main loader has to convert into the appropriate attribute, class description, etc.

Hmmm, are you talking about the attributes parser? The PR I sent is only touching to the docstrings parser (and a few imports, sorry for the confusion).
But you're right, the attributes parser could really be improved. It's still in its first shape, that I threw together as a PoC.

Oh you're right. I'm confusing things.
I'll comment on the PR, but it looks really good.


Add randomness to the block download timer

As @ccjernigan noticed, the block downloading timout interval will cause all clients with synchronized clocks to hit the server around the same time, potentially DoSing the server.
private fun calculatePollInterval(fastIntervalDesired: Boolean = false): Long {
    val interval = POLL_INTERVAL
    val now = System.currentTimeMillis()
    val deltaToNextInteral = interval - (now + interval).rem(interval)
    // twig("sleeping for ${deltaToNextInteral}ms from $now in order to wake at ${now + deltaToNextInteral}")
    return deltaToNextInteral
}

This was done in order so that timing of requests would not leak information about the wallet's state to the server. We can fix the DoS issue without adding a privacy leak by adding a random offset to deltaToNextIntegral in the code above. The random offset should be chosen anew for each poll interval (since a constant offset amount would help the server identify the wallet).

Perhaps we could choose the offset to be random in between -0.25POLL_INTERVAL and +0.25POLL_INTERVAL.