Xamarin.Android linking fails with TargetFramework 7.0

As some people have mentioned in #439, the linking of Xamarin.Android fails with the following error message when using the hosted agent:
2016-12-04T16:39:27.4138913Z "C:\a\1\s\Droid\TestApp.Droid.csproj" (Clean;clean;PackageForAndroid target) (1) ->
2016-12-04T16:39:27.4138913Z (_LinkAssembliesShrink target) ->
2016-12-04T16:39:27.4148783Z   C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018: The "LinkAssemblies" task failed unexpectedly. [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018: Xamarin.Android.XamarinAndroidException: error XA2006: Reference to metadata item 'System.IO.MonoIOError' (defined in 'System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e') from 'System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' could not be resolved. ---> Mono.Cecil.ResolutionException: Failed to resolve System.IO.MonoIOError [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Steps.MarkStep.MarkType(TypeReference reference) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at MonoDroid.Tuner.MonoDroidMarkStep.MarkType(TypeReference reference) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Steps.MarkStep.ProcessQueue() [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4158787Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Steps.MarkStep.Process() [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4168781Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Mono.Linker.Pipeline.Process(LinkContext context) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4168781Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at MonoDroid.Tuner.Linker.Process(LinkerOptions options, LinkContext& context) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Xamarin.Android.Tasks.LinkAssemblies.Execute() [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    --- End of inner exception stack trace --- [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Xamarin.Android.Diagnostic.Error(Int32 code, Exception innerException, String message, Object[] args) [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Xamarin.Android.Tasks.LinkAssemblies.Execute() [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\a\1\s\Droid\TestApp.Droid.csproj]
2016-12-04T16:39:27.4228774Z C:\Program Files (x86)\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1616,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [C:\a\1\s\Droid\TestApp.Droid.csproj]

I set the linker behaviour to SdkOnly. If I disable linking completely the build succeeds but obviously the APK file gets much bigger.
I've currently set the target framework to use the latest installed platform, which causes it to use v7.0. This can I also confirm by the logs. As you can see in #439, it's working for @InquisitorJax and @msimecek if they switch the target framework to version v6.0. I also tried setting the TargetFrameworkVersion to v6.0 and can confirm that it works correctly.
I created a test repo for you to test and confirm the issue. It has a master branch that has it's TargetFrameworkVersion set to v7.0 and another branch named AndroidM that has it's TargetFrameworkVersion set to v6.0
https://github.com/fela98/android-n-vsts-test
Here the settings of the Xamarin.Android build task that I use:

Adding to this for anyone who's having trouble building UI Tests: the MSBuild task doesn't have a JDK Version option, so you need to set it manually as path added to MSBuild Arguments:
/p:JavaSdkDirectory="C:/Program Files (x86)/Java/jdk1.8.0_102"
Not optimal, since it points to a hardcoded path on the build machine, but works for the time being.

@msimecek: Thanks for the workaround, we are looking into updating the hosted build VMs to work for latest Xamarin version by default.

@fela98
The Linker error you are seeing is due the hosted build VMs not having Xamarin.Android 7.0 support though the Android SDK 24 is installed. We will be updating them early next year after the holidays.
Sorry for the inconvenience.
@msimecek
The build issues for Xamarin Android projects targeting Android SDK 24 or higher are due to Xamarin requiring the JDK version to be specified (https://releases.xamarin.com/technical-bulletin-android-sdk-build-tools-24/). We don't have a good way to do that for MSBuild task to build the test projects currently other than the workaround you posted.
Thanks,
Madhuri

Related to https://github.com/Microsoft/vsts-tasks/issues/3237

The Linker error you are seeing is due the hosted build VMs not having Xamarin.Android 7.0 support though the Android SDK 24 is installed. We will be updating them early next year after the holidays.

Hi @madhurig, is there any more detailed ETA when the Android SDK version will be updated?

@jerone: Are you still seeing issues? The update was done in the last week of December, so we expect this to work unless you are using ProGuard (which is still older version).
Thanks,
Madhuri

@madhurig You are right, I can build with Android SDK 24 again!
I was using a separate branch with downgraded version and subscribed to this issue for updates. Looks like this issue can be closed as fixed.

@jerone : Thanks for confirming.


Cannot drag prefab to the scene if it contains a brush

As the title says. I can drag it to the hierarchy, but I can't drag it into the scene view.
This happens whether or not the thing I'm dragging it on is part of a CSG model or not.

Thanks, I'll take a look

Fixed in version 1.545!


chore: remove more circular dependencies

Description
This pull request changes the following:

remove some circular dependencies (got down to 2)

Related Issues

Relates to #928

:tada: This PR is included in version 0.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Changed Readme notes about the ArgumentParser integration via SwiftPM

The ArgumentParser dependency should be specified using the target block, not product.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

Hi @sgl0v! Could you show an example of a Package.swift file with this syntax? I'm not seeing what this fix is meant to address.

Hi @natecook1000 ! Here is the example of a Package.swift:
// swift-tools-version:5.1
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "TestProject",
    platforms: [
        .macOS(.v10_11)
    ],
    products: [
        .executable(name: "TestApp", targets: ["TestTarget"]),
    ],
    dependencies: [
        .package(
            url: "https://github.com/apple/swift-argument-parser",
            from: "0.0.1"
        )
    ],
    targets: [
        .target(name: "TestTarget", dependencies: ["ArgumentParser"])
    ]
)

I've defined a TestApp executable product, that is built with the TestTarget.  The one has ArgumentParser as a dependency.
It might be that I've missed something, but looks like .product(name: "ArgumentParser", package: "swift-argument-parser"), is not the way you can specify a target's dependency. You have to use .target(name: "TestTarget", dependencies: ["ArgumentParser"]) instead.

Ah, I see! The package manifest format has a change in version 5.2 that only allows specifying the target dependency with a string (e.g. "ArgumentParser") when the product has the same name as the package it's exported from. In our case, that's not true — the package is called swift-argument-parser, but the product is ArgumentParser — so we need to use the longer .product(...) syntax.
Here's a larger example (this works with swift-tools-version 5.1 or 5.2):
let package = Package(
    // name, platforms, products, etc.
    dependencies: [
        .package(url: "https://github.com/apple/swift-argument-parser", from: "0.0.1"),
        // other dependencies
    ],
    targets: [
        .target(name: "<command-line-tool>", dependencies: [
            .product(name: "ArgumentParser", package: "swift-argument-parser"),
        ]),
        // other targets
    ]
)

Would you like to add this to the README section instead of just showing the individual lines? That might make it more clear.

Thanks for the explanation. Yes, it makes it much more clear. I've added the code snippet to the README section.

@swift-ci Please test


Mistakes or missing code in Factify2-Baseline

There are numerous mistakes in the code provided in the github, which prevent users from running the code.

The test.csv file that is available for downloading does not contain Category column, which means that no function for datasets (create_dataset or dataloader) works for this split.
There is a code
vis_model = BertViT(device, 5)
which is not initialized or imported anywhere in the code and I was not able to find such a model in transformers library.

Could you elaborate on this and provide explanation or improve the code?
Thank you

We have intentionally removed the labels from the test data to maintain the integrity of the competition. One can request access to the test labels through email.
We have added the definition for BertViT.


fix: track element seen with different payloads

I think this also needs to get implemented for the insights plugin, too - doesn't it?

/review


honor multiple change values

In the case where changes are made to Env, Expose, Volumes, or labels, we should
honor that multiple values are valid.
Resolves: #795
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

LGTM :+1:

@rh-atomic-bot r+


[stable/jenkins] Support additional agents in default JCasC

What this PR does / why we need it:
Add master.JCasC.additionalAgents as a list of additional agents and include these additional agents (podTemplates) in the default JCasC with each inheriting configuration from agent.
Add template jenkins.casc.agent to generate an agent (podTemplate).
Make agent.workingDir configurable.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes helm#20870

Special notes for your reviewer:
The podTemplate definition (kubernetes.templates) in template jenkins.casc.defaults is moved to a new jenkins.agent-jcasc template with the following modifications. See http://mergely.com/2K5B28FF/?ws=1.

name fields moved to the top so they stand out
command quoted when not nil to support empty string (empty string ensures Jenkins doesn't apply a default value such as /bin/sh -c)
empty checks added for resources, resources.limits, resources.requests, and yamlTemplate
workingDir parameterized
volumes added

I chose not to make use of either of the kubernetes plugin casc fields related to agent inheritance.
defaultsProviderTemplate - the agent from which all other agents inherit configuration. Merging agent into the other agents in the JCasC allows all agents to make use of the chart's default configuration for agent. To wait for the kubernetes plugin to merge the values at runtime means each agent would need to set sideContainerName (so container values could be inherited) as well as set any fields which get assigned a default value when nil and thus aren't eligible for inheritance (e.g. command and workingDir).
inheritFrom - indicates from which agent this agent should inherit configuration. I thought an agent.inheritFrom field would look out of place in the chart since the chart only defines a single agent.
helm template tests
I placed the following in stable/jenkins/agent-values.yaml
# volumes and yamlTemplate have trailing whitespace to test trim
agent:
  enabled: true
  podName: default
  customJenkinsLabels: default
  resources:
    limits:
      cpu: 1024m
      memory: 2048Mi
  volumes:
    - name: cache
      configMap:
        name: "{{ template \"jenkins.fullname\" . }}-cache"

  yamlTemplate: |-
    apiVersion: v1
    kind: Pod
    spec:
      tolerations:
      - key: "key"
        operator: "Equal"
        value: {{ .Values.tolerations }}

master:
  JCasC:
    additionalAgents:
      - podName: maven
        customJenkinsLabels: maven
        image: jenkins/jnlp-agent-maven
      - podName: node
        customJenkinsLabels: node
        image: jenkins/jnlp-agent-node
tolerations: 10

for helm 2 use --execute instead of --show-only
auto-reload
default JCasC - single agent
helm template stable/jenkins \
--show-only templates/jcasc-config.yaml \
--set master.sidecars.configAutoReload.enabled=true \
--set master.JCasC.enabled=true \
--set master.JCasC.defaultConfig=true

default JCasC - additional agents
helm template stable/jenkins \
--show-only templates/jcasc-config.yaml \
--set master.sidecars.configAutoReload.enabled=true \
--set master.JCasC.enabled=true \
--set master.JCasC.defaultConfig=true \
--values stable/jenkins/agent-values.yaml

NO auto-reload
default JCasC - single agent
helm template stable/jenkins \
--show-only templates/config.yaml \
--set master.sidecars.configAutoReload.enabled=false \
--set master.JCasC.enabled=true \
--set master.JCasC.defaultConfig=true

default JCasC - additional agents
helm template stable/jenkins \
--show-only templates/config.yaml \
--set master.sidecars.configAutoReload.enabled=false \
--set master.JCasC.enabled=true \
--set master.JCasC.defaultConfig=true \
--values stable/jenkins/agent-values.yaml

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @lachie83

https://github.com/helm/charts/pull/21671 allows for multiple podTemplates in the default casc. I'm going to update this PR to allow for multiple agents in the default casc. I'll probably add an additionalAgents value to support this.

Ok, I've managed to also get the additional agents working using my custom values.yaml file (which contains a looooot of JCasC configScripts).
Now, how do I configure extra fields for the additional agents? Like for being able to configure this agent:
      - containers:
        - args: "cat"
          command: "/bin/sh -c"
          image: "privaterepo.tld/builder-scala:tag"
          name: "scala"
          privileged: true
          resourceLimitCpu: "1"
          resourceLimitMemory: "1024Mi"
          resourceRequestCpu: "400m"
          resourceRequestMemory: "512Mi"
          ttyEnabled: true
          workingDir: "/home/jenkins"
        envVars:
        - containerEnvVar:
            key: "DOCKER_CONFIG"
            value: "/home/jenkins/.docker/"
        - containerEnvVar:
            key: "GIT_AUTHOR_NAME"
            value: "jenkins-bot"
        - containerEnvVar:
            key: "GIT_COMMITTER_EMAIL"
            value<EMAIL_ADDRESS>        - containerEnvVar:
            key: "GIT_COMMITTER_NAME"
            value: "jenkins-bot"
        - containerEnvVar:
            key: "JENKINS_URL"
            value: "http://jenkins:8080"
        - containerEnvVar:
            key: "XDG_CONFIG_HOME"
            value: "/home/jenkins"
        - containerEnvVar:
            key: "_JAVA_OPTIONS"
            value: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap\
              \ -Dsun.zip.disableMemoryMapping=true -XX:+UseParallelGC -XX:MinHeapFreeRatio=5\
              \ -XX:MaxHeapFreeRatio=10 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90\
              \ -Xms10m -Xmx192m"
        label: "jenkins-scala"
        name: "scala"
        serviceAccount: "jenkins"
        slaveConnectTimeoutStr: "0"
        volumes:
        - hostPathVolume:
            hostPath: "/var/run/docker.sock"
            mountPath: "/var/run/docker.sock"
        - secretVolume:
            mountPath: "/home/jenkins/.docker"
            secretName: "jenkins-docker-cfg"
        yamlMergeStrategy: "override"

Another fields we use for example are:

nodeSelector (some agents must run in heavy instances or GPU specific)
workspaceVolume (some agents must use dynamicPVC for getting cached content from previous builds)
annotations (we use kube2iam and must annotate agents to inherit AWS IAM roles)

Sorry if it is documented somewhere, I wasn't able to find it.

@lgg42 These fields will need to be added to the chart. I'll add them in my PR.

* nodeSelector (some agents must run in heavy instances or GPU specific)

* workspaceVolume (some agents must use dynamicPVC for getting cached content from previous builds)

* annotations (we use kube2iam and must annotate agents to inherit AWS IAM roles)

@wmcdona89 thanks!
Only those three fields or all the possible ones provides by the JCasC pod template configurator?

You should be able to use agent.yamlTemplate for any fields not yet supported by the chart.

Well...at least for those fields that you can easily translate to Pod yaml, such as annotation and nodeSelector.

Thanks, but including those fields in agent.yamlTemplate won't make all additional agents inherit such fields?
Say, if I had two additional agents, maven and python, will those two inherit a same annotation field I set in agent.yamlTemplate?

Thanks, but including those fields in agent.yamlTemplate won't make all additional agents inherit such fields?
Say, if I had two additional agents, maven and python, will those two inherit a same annotation field I set in agent.yamlTemplate?

The maven and python agent would inherit agent.yamlTemplate unless they set yamlTemplate to something else.
I'm in need of some valid examples for annotation, nodeSelector, and workspaceVolume to include in the docs so if you have some you could share I'd appreciate it.

Say, if I had two additional agents, maven and python, will those two inherit a same annotation field I set in agent.yamlTemplate?

The maven and python agent would inherit agent.yamlTemplate unless they set yamlTemplate to something else.
I'm in need of some valid examples for annotation, nodeSelector, and workspaceVolume to include in the docs so if you have some you could share I'd appreciate it.

IMHO I think adding support in the chart specifically for annotation, nodeSelector, and workspaceVolume is not the way to go, as teams tend to have many different configurations for their "builder" agents.
I'm sure they'd make more use of a complete yamlTemplate where they define at will what they can and it's available via kubernetes-plugin's casc.
But here are the examples:
annotations
  annotations:
    iam.amazonaws.com/role: role-name
    ad.datadoghq.com/service.logs: '[
      {
        "source": "java",
        "service": "service",
        "log_processing_rules": [
          {
            "type": "multi_line",
            "name": "starts_with_date",
            "pattern" : "\\d{4}-\\d{2}-\\d{2}"
          }
        ]
      }
    ]'

nodeSelector and tolerations (they tend to come together...)
      nodeSelector:
        svc: geometry-builder

      tolerations:
        - key: svc
          operator: Equal
          effect: NoSchedule
          value: geometry-builder

workspaceVolume
usually is emptyDirWorkspaceVolume but we have some dynamicPVC and in the future we'll use also nfsWorkspaceVolume
My point is, I think the user should have complete freedom to declare custom agents as they will and not be limited by the chart's capabilities.
you mentioned:

The maven and python agent would inherit agent.yamlTemplate unless they set yamlTemplate to something else.

Could be kind to provide a quick example of how to implement such yamlTemplate for an additional agent please?

@lgg42 @torstenwalter
I'm really starting to rethink if additional "agents" is the right approach. Historically, Jenkins is a master and agents but on kubernetes, agents are really podTemplates and as we try to improve  configuration for kubernetes, it seems like we're fighting things trying to continue with "agents" vs "podTemplates". I'll go so far as to say perhaps agent could be deprecated and the chart could start exposing podTemplate fields directly and then the translation layer could go away. Let me know what you guys think.

@lgg42 @torstenwalter
I'm really starting to rethink if additional "agents" is the right approach. Historically, Jenkins is a master and agents but on kubernetes, agents are really podTemplates and as we try to improve configuration for kubernetes, it seems like we're fighting things trying to continue with "agents" vs "podTemplates". I'll go so far as to say perhaps agent could be deprecated and the chart could start exposing podTemplate fields directly and then the translation layer could go away. Let me know what you guys think.

I'm liking your idea very much! Take for example JenkinsX's approach to this. And check their values file for some examples on podTemplates.
They have .Values.jenkins.Agent.PodTemplates where one can declare things like:
    PodTemplates:
      Maven:
        Name: maven
        Label: jenkins-maven
        # annotations:
        #   iam.amazonaws.com/role: arn:aws:iam::accountid:role/rolename
        volumes:
        - type: Secret
          secretName: jenkins-docker-cfg
          mountPath: /home/jenkins/.docker
        EnvVars:
          JENKINS_URL: http://jenkins:8080
          _JAVA_OPTIONS: '-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -Dsun.zip.disableMemoryMapping=true -XX:+UseParallelGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=10 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Xms10m -Xmx192m'
          DOCKER_CONFIG: /home/jenkins/.docker/
          # lets disable the noisy download artifact logging messages
          MAVEN_OPTS: -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
        ServiceAccount: jenkins
        Containers:
          Jnlp:
            Image: jenkinsci/jnlp-slave:3.26-1-alpine
            RequestCpu: "100m"
            RequestMemory: "128Mi"
            Args: '${computer.jnlpmac} ${computer.name}'
          Maven:
            Image: gcr.io/jenkinsxio/builder-maven:2.0.1261-601
            Privileged: true
            RequestCpu: "400m"
            RequestMemory: "512Mi"
            LimitCpu: "1"
            LimitMemory: "1024Mi"
            Command: "/bin/sh -c"
            Args: "cat"
            Tty: true

That's actually what we use to have our custom podTemplates:

But we want to move away from JenkinsX since what we really use is Jenkins + Kubernetes-plugin  + custom builders. And I've observed (in #jenkins-x-user channel on kubernetes slack space) there are some people out there looking for this too!
I think having such an easy way of configuring custom podTemplates like in JenkinsX's helm chart would be a GREAT addition to this stable/jenkins chart.

That looks great! Now how best to implement it?
As a chart user, I'd like the chart to allow for minimal configuration by providing sane defaults and giving the option of providing an entire podTemplate as a fallback.
I'm envisioning a top-level kubernetes object in the chart corresponding to the kubernetes plugin casc. I'll think through the entire values structure and propose something.
What do you think?

Dunno about the best way 🤷♂
I'd personally follow the way the JenkinsX guys did it, since they are providing a kubernetes focused CICD solution.
+1 to have a minimal sane default, like the default pod template that's created right now in the master branch.
I doubt if having a top kubernetes object might be inside the scope of this PR. But I like the idea of being able to configure all of posible Kubernetes cloud values.
What about implementing the podTemplates in this PR and continuing the kubernetes object in a new PR?

Hey! Great debate here! And great work both of you (I checked both PRs) I was just looking for this as we also are coming from JenkinsX. I think @lgg42 proposal of just focusing on the podTemplates for this PR is the way to go! So many of my colleagues want this feature so much!!!

@lgg42 Ok...I think we're back to saying these are complimentary PRs and that we should move forward with both. Your addition of agent.podTemplates will satisfy users migrating from JenkinsX who already have the verbose podTemplate yaml and just need a place to plug it in.
My PR will enable those looking to stick with a more agent-centric approach but I'll limit my changes to just moving the podTemplate config to a separate template so users can write their own JCasC for multiple agents. I'm going to remove the additionalAgents field and thus won't add additional agents into the default JCasC. This is the best fit for me at this time but I'm interested in finding a more OOTB podTemplate-centric approach down the road.

Thanks @guilaps82 and @wmcdona89 for your input.
I'm going to move forward my PR in that case. You commented putting the pod templates under master.JCasC.podTemplates but something tells me you'd preffer now agent.podTemplates
So I'm gonna update my PR to use the value agent.podTemplates
Thanks for this hard work! nice cooperation! :muscle:

@lgg42 Just give me a ping when it"s ready to review. I appreciate the discussion taking place here.

@lgg42 Just give me a ping when it"s ready to review. I appreciate the discussion taking place here.

Hi @torstenwalter :wave: !
I don't know if you are referring to my PR https://github.com/helm/charts/pull/21671, in such case, it's ready to be reviewed.

@lgg42 Just give me a ping when it"s ready to review. I appreciate the discussion taking place here.

Hi @torstenwalter  !
I don't know if you are referring to my PR #21671, in such case, it's ready to be reviewed.

I did not notice that we have another Pr for this

@lgg42 Just give me a ping when it"s ready to review. I appreciate the discussion taking place here.

Hi @torstenwalter  !
I don't know if you are referring to my PR #21671, in such case, it's ready to be reviewed.

@lgg42 I did not notice that we already have another PR.

My PR will enable those looking to stick with a more agent-centric approach but I'll limit my changes to just moving the podTemplate config to a separate template so users can write their own JCasC for multiple agents. I'm going to remove the additionalAgents field and thus won't add additional agents into the default JCasC. This is the best fit for me at this time but I'm interested in finding a more OOTB podTemplate-centric approach down the road.

@wmcdona89 Would it be ok for you if we merge #21671 first and you rebase your additional suggestions above on top of it?

@torstenwalter Yep. That's what I was planning to do. Thanks for asking.

@torstenwalter @lgg42 This is ready for review. I had more iterations on the documentation than I care to admit but please let me know if anything is confusing.

/ok-to-test

@wmcdona89 This is pretty coll stuff! I suggest to make add first class support for this directly within the chart so that people don't have to add the template for it to the values file.
I wanted to create a PR for you, but I can't select your fork as target for the PR. I added the changes in https://github.com/syncier/helm-charts/tree/multiple-agents-explicit-support.
You can merge it into your branch and include it in the PR.
What do you think

@torstenwalter Definitely onboard with adding first class support. And I like additionalAgents vs master.JCasC.additionalAgents which I'd proposed in a previous revision. But then I think we should include XML config support as I think that would be expected. I can make the changes. Sound ok?

Absolutely. Adding XML support in another PR would also be fine.

Another remark regarding XML config. I actually want to make JCasC the default. If you're not familiar of how the the XML config works and that the configuration is only applied once and not altered afterwards then one is surprised that altering config has no effect.
We just need to ensure that JCasC config results in an identical setup as XML config.
I described it in https://github.com/helm/charts/issues/16931 It got closed as I did not find the time to work on it, but it's still on my TODO list. PRs like yours help to get there. Thanks for that!

@torstenwalter I updated the xml configuration and tweaked some verbiage in the CHANGELOG and README. I changed "default agent" references to agent as I thought this would be clearer. Hopefully you agree.

@wmcdona89 Thank you very much. This is awesome piece of work!

@torstenwalter @lgg42 It was great collaborating with you on this.


Revert "used constructor to take in input layer"

Reverts Aatmaj-Zephyr/Neural-networks-in-Java#4

rather than constructor, method usage will be better.


Merge conflict

It's seems that this document has a merge conflict.
In the section "Related topics"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5be3773d-783c-115d-4945-9ec79b407877
Version Independent ID: 3993b5ed-9b01-4759-6083-1586c8cf7fdd
Content: Virtual Private Networking (VPN) | Microsoft Docs
Content Source: WindowsServerDocs/remote/remote-access/vpn/vpn-top.md
Service: unspecified
GitHub Login: @shortpatti
Microsoft Alias: pashort

Resolved


feat: guest button

What?
Add Enter as a Guest button inside the login modal

@2fd the Guest button should say "Play as Guest", not "enter" and here is the figma link with the design for that popup adaptation https://www.figma.com/file/feevEf3dpoEMDLLcm5deSs/SignInV1?node-id=1291%3A54

That wasn't specified in the request, @RominaMarchetti WDYT?

Mmm I think it would be a good idea to have both and measure how much people click both buttons before deciding to remove one


Support nested fields

Currently only toplevel keys are processed.

Related to https://github.com/brocode/fblog/issues/16

This should probably be done for the filter logic as well. That would also mean to parse numbers as numbers instead of strings.

Please, add support for nested fields, even if I convert it to string it would be fine

This has been open for so long. I will have a look at it on the weekend.
@Miuler what would you expect how the cli arguments should look like? Especially with
{"a": {"b": 1}, "a.b": "1"}

Because i thought of a.b but in this case I need something extra.

released

Ok needed to more releases for some bugfixing. But not it should work


Active development/Circular dependency isuse

Hi,
Sorry for the the issue being raised, couldn't see an email to contact you with.
Are you still actively working on the router? Any road map? I'm currently playing around with your WIP and was wondering if you could give me any insight for applying the redux middleware.
When I try to apply it I'm getting a circular dependency error (looks like $http). I'm currently one of my angular projects to use a redux backing for fun, but when it comes to hooking everything together with routing it's becoming problematic.
Also with dispatching route changes, I assume I can just import the 'go' action and dispatch one, yes? Or I'm stuck using your angular action factory?
Oh, also your example is a little bit borked, and can't be run out of the box. It's missing some webpack dependencies.
Cheers,
Michael

Hey Michael!
Regarding your issues, is there somewhere we can see your code? Most importantly redux's store creation, and how you consume redux-ui-router action.

I don't currently have a checked in version for applying the router middleware, but you can however check what I have checked in:
Repository:
Store creation (add in the middleware to see the error if you'd like):
https://github.com/madou/armory-ng/blob/with-redux/client/src/app/app.redux-store.js

I don't currently have a checked in version for applying the router middleware, but you can however check what I have checked in (logging redux middleware is turned on):
Repository:
https://github.com/madou/armory-ng/tree/with-redux/
To run:
npm install
bower install
gulp serve
Store creation (add in the router middleware to see the error if you'd like):
https://github.com/madou/armory-ng/blob/with-redux/client/src/app/app.redux-store.js
Root reducer:
https://github.com/madou/armory-ng/blob/with-redux/client/src/app/reducers/index.js
Angular entry point:
https://github.com/madou/armory-ng/blob/with-redux/client/src/app/app.module.js
Not sure if this can help you 100%. I haven't played around with your wip as much as I would have liked, just trying to hack things together as I go. Trying to force myself not to re-write everything in React hehe.
Let me know if you need more info.
Michael

Hey,
Just to be clear i'm not the author of this project :)
Regarding your issue, here is the problem:
ng-redux depends on the middleware you pass it, the router middleware in this case.
The router middleware depends on $state, which in turn depends on things that depends on $http.

We can simplify this to: http-auth-interceptor depends on $http, which is not allowed because this would create a circular dependency.
You can take a look at this Stackoverflow question which seems to be exactly your problem.

Ohh righto. I've run into this before, my mistake. Thanks for having a dig, cheers!

:+1:


ubuntu 22.04 failed to setup depends because package name is wrong

in ubuntu 22.04,
after I run setup depends scripts, I got below error
there are 4 packages name is not correct under ubuntu 22.04
E: Unable to locate package libbpf-devel
E: Package 'bpftool' has no installation candidate
E: Unable to locate package libblkid-devel
E: Unable to locate package zlib
Package bpftool is a virtual package provided by:
  linux-nvidia-6.2-tools-common 6.2.0-1003.3~22.04.1
  linux-lowlatency-hwe-6.5-tools-common 6.5.0-27.28.1~22.04.1
  linux-hwe-6.5-tools-common 6.5.0-27.28~22.04.1
  linux-hwe-6.2-tools-common 6.2.0-39.40~22.04.1
You should explicitly select one to install.

E: Unable to locate package libbpf-devel
E: Package 'bpftool' has no installation candidate
E: Unable to locate package libblkid-devel
E: Unable to locate package zlib
[IOTRACE][ERROR] Cannot install required dependencies

@mariuszbarczak here are new package name in ubuntu
  162  apt-get -y install libbpf-dev
  165  apt install linux-tools-common
  166  apt-get -y install libblkid-dev
  170  apt install zlib1g -y

@gaowayne The fix is coming. You can check if this solve your problem,


[Backport 8.14] Connector SyncJob API spec (#2503)

(cherry picked from commit 9f0dc3db0a0f82ef9ebebb276bcfdcaf28c69e6a)

The only conflict was in output/openapi/elasticsearch-serverless-openapi.json - I re-ran the make contrib before mergin the backport


Async modules not resolved correctly with module federation

Bug report

What is the current behavior?
async modules (e.g. using top-level-await) are resolved into promise by Module Federation
If the current behavior is a bug, please provide the steps to reproduce.
https://github.com/vincenthend/webpack-module-federation-async-modules
Repo above is two webpack apps using module-federation
main-app is importing a function from component-app, where there is a top-level-await in the imported module.
The imported module is resolved as Promise instead of object (even if using import syntax)

What is the expected behavior?
Imported modules from module federation should resolve normally whether it's async modules or not

Other relevant information:
webpack version:  5.61.0
Node.js version: 14.8
Operating System: macOS 10.15
Additional tools: -

Yep, sounds like a bug

Im seeing the same behaviour on a Next.js app

@jorgev259 No need to duplicate, on the top we have example of the problem

It seems the top-level-await should be placed in your main-app instead of component-app according to the doc.

It seems the top-level-await should be placed in your main-app instead of component-app according to the doc.

This solution is different from the expected behavior above. Normal import statement should work normally (no await needed) for async modules as stated here.
While for now, if the async module is within module federation, it resolves into a promise

bump

When working with async modules you need to make sure that your are working only with ESM imports. And also make sure to not accidentically transpile them (via babel) to CommonJs (as shown in the screenhot, (0, _utils).hasRole is how babel transpiles imports)

Imported modules from module federation should resolve normally whether it's async modules or not

Bug report
What is the current behavior? async modules (e.g. using top-level-await) are resolved into promise by Module Federation
If the current behavior is a bug, please provide the steps to reproduce. https://github.com/vincenthend/webpack-module-federation-async-modules Repo above is two webpack apps using module-federation main-app is importing a function from component-app, where there is a top-level-await in the imported module.
The imported module is resolved as Promise instead of object (even if using import syntax)
What is the expected behavior? Imported modules from module federation should resolve normally whether it's async modules or not
Other relevant information: webpack version: 5.61.0 Node.js version: 14.8 Operating System: macOS 10.15 Additional tools: -

I have the same problem, it seems to be a bug?

bump

bump again

Are the remotes in esm format as well?


[+0-all-arguments] Use SILGenBuilder APIs to ensure we put cleanups o…

…n the case result instead of on the cast argument.
Otherwise, we break SILGen tests when they are updated for +0. This breakage
occurs since we use the original cleanup from args[0] instead of forwarding that
cleanup and creating a new cleanup on the result.
rdar://34222540

@swift-ci smoke test and merge


Edit / add data.world details and NC Open Pass challenges

From @bilscanlon: https://docs.google.com/document/d/1h0fT-wXI1i6dw3B80JvrulTUkvTzvI1_B5PMRmKmpcM/edit?usp=sharing

Editing now

Post is edited, entered into WorPress (http://citycampnc.org/?p=2963) and scheduled for Friday 9/22
cc @bilscanlon @natalienoel1

Great. Thank you!
On Tue, Sep 19, 2017 at 9:46 PM, Jason Hibbets<EMAIL_ADDRESS>wrote:

Post is edited, entered into WorPress (http://citycampnc.org/?p=2963) and
scheduled for Friday 9/22
cc @bilscanlon https://github.com/bilscanlon @natalienoel1
https://github.com/natalienoel1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/722#issuecomment-330721424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AaBwV4VCUPOkXfgxXHtq2ydtbaNmbPovks5skG6RgaJpZM4Pc508
.

--
Natalie Noel
Marketing Manager
H/Q Raleigh & Charlotte
www.hq.community
https://twitter.com/HQRaleigh https://www.facebook.com/HubRaleigh
http://www.linkedin.com/company/2783956?trk=NUS_CMPY_TWIT
http://instagram.com/hqraleigh
Is your entrepreneurial team growing? Check out our flexible and affordable
suites at HQ Capital Club https://www.hqcapitalclub.com/! Contact us at
<EMAIL_ADDRESS>to schedule a tour. Make history happen!
Locations: Downtown http://hq.community/find-a-location/hq-raleigh/ | Capital
Club https://www.hqcapitalclub.com/ | HQ Greensboro
https://rb.tc/9ADB#http://hqgreensboro.com/
Partners: Packard Place http://hq.community/find-a-location/hq-charlotte/
(Charlotte) | Tekmountain http://tekmountain.com/ (Wilmington)
Stay in touch: Twitter https://rb.tc/9ADD#https://twitter.com/HQ_Community
| Facebook https://rb.tc/9ADF#https://www.facebook.com/HubRaleigh |
Instagram https://rb.tc/9ADG#https://www.instagram.com/hq_community/
Check out these renderings of our new space at the Capital Club Building
https://drive.google.com/file/d/0B5Hu4xKF4CvaSHN2eG1selZwN00/view?usp=sharing
!


AttributeError: 'Derivation' object has no attribute 'rule'

Im trying to have multiple questions inside a question and for some reason it keeps coming with the same error over and over. The grammar is:
grammar = """
game: GAME string scene_element* -> game
scene_element: "Choice:" choices
choices: "Question" qa
qa: string ":" opt*
opt: string "=" string
| string "=" qa
GAME: "GAME"
string: ESCAPED_STRING -> string
%import common.WS
%import common.NUMBER
%import common.ESCAPED_STRING
%ignore WS
"""
parser = Lark(grammar, start='game', ambiguity='explicit')
The text Im trying to parse is:
GAME "Hello"
Choice: Question
"Whats your name?":
"Jorge" = "Nice name"
"Ena" = "I love it!"
"Claudio" = "Like my dog!"
"I have no name" = "OK":
"Are you sure?" = "Yes"
And the error is:
Traceback (most recent call last):
File "/Users/MyUser/Documents/Python/parser/test.py", line 59, in
print(parser.parse(sentence).pretty())
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/tree.py", line 44, in pretty
return ''.join(self._pretty(0, indent_str))
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/tree.py", line 37, in _pretty
l += n._pretty(level+1, indent_str)
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/tree.py", line 37, in _pretty
l += n._pretty(level+1, indent_str)
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/tree.py", line 37, in _pretty
l += n._pretty(level+1, indent_str)
[Previous line repeated 1 more times]
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/tree.py", line 34, in _pretty
l = [ indent_str*level, self._pretty_label(), '\n' ]
File "/Users/MyUser/Documents/Python/parser/venv/lib/python3.6/site-packages/lark/parsers/earley.py", line 30, in _pretty_label
return self.rule.origin if self.rule else self.data
AttributeError: 'Derivation' object has no attribute 'rule'
Thanks!

I get a similar error, in concatlabel, it is left recursive but ++does not appear anywhere else in the grammar. Here is my grammar.
?item: identifierlist    -> rv      | number          | "-" item               | "(" sum ")"      | (item ("++" item)+) -> concatlabel      | distribution "**" int -> tile      | distribution -> create
Wondering if it is an issue or just a bug in my grammar.

Thanks for the bug report! I pushed a fix to the master branch.

Also pushed a new version to pypi. Upgrading to lark-parser==0.6.4 should do the trick.


How do I colour buttons and where can I find the corresponding descriptions for button() and Response?

I've tried the following:
use bevy::prelude::*;
use bevy_egui::{egui, EguiContexts, EguiPlugin};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_plugins(EguiPlugin)
        .add_systems(Update, (ui_example_system, header_bar))
        .run();
}

fn ui_example_system(mut contexts: EguiContexts) {
    egui::Window::new("Hello").show(contexts.ctx_mut(), |ui| {
        ui.label("world");
    });
}

fn header_bar(mut contexts: EguiContexts) {
    egui::TopBottomPanel::top("header_bar").show(contexts.ctx_mut(), |ui| {
        // Create an array of button labels for easier management
        ui.horizontal(|ui| {
            [
                ("Button 1", egui::Color32::GREEN),
                ("Button 2", egui::Color32::BLUE),
                ("Button 3", egui::Color32::RED),
                ("Button 4", egui::Color32::YELLOW),
                ("Button 5", egui::Color32::DARK_RED),
            ]
            .into_iter()
            .for_each(|(label,color)| {
                if ui.button(label).fill(color).clicked() {
                    // Handle button clicks here
                    println!("Clicked button: {}", label);
                }
            });
        });
    });
}

Which produced the followinge error:
error[E0599]: no method named `fill` found for struct `Response` in the current scope
  --> egui_stuff/src/main.rs:31:37
   |
31 |                 if ui.button(label).fill(color).clicked() {
   |                                     ^^^^ method not found in `Response`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `egui_stuff` (bin "egui_stuff") due to 1 previous error

Unfortunately, I can't find a description for the button() method used here, nor for the Response method used here in the associated documentation, or I don't know what to look for. Can anyone help me?

Hi!
You can construct a button with this API to be able to customise it: https://docs.rs/egui/latest/egui/widgets/struct.Button.html.
For example:
let button = egui::Button::new("Click me").fill(color);
if ui.add(button).clicked() {
  // ...
}

Btw, this is a question about egui itself, not bevy_egui, usually you have a better chance to find a quick answer on their GitHub or Discord server.

This is not readily apparent if you cannot find the relevant references. egui_bevy could just as well call the Button struct of Bevy directly.

There are very few structs, methods that bevy_egui exposes on its own. If you check the EguiContexts documentation, for example, you can see that the Context type it returns already belongs to egui.
All the ui methods, widgets, etc are provided by egui, these don't fall into the bevy_egui zone of responsibility. I understand how it can be a bit confusing, and it's not the first time someone asks questions about egui here. :) So I agree that the documentation can be improved in this regard. In case you have any specific ideas, a comment or a PR are welcome.


[Feature] Trakt progress page

On Trakt you have a TV show progress section (https://trakt.tv/users/<user>/progress/watched/activity) that tells you what the next episode of your unfinished shows is. Would be cool to have this. I think this has already been implemented in this PR: https://github.com/scakemyer/quasar/pull/40 but I imagine some changes will be required as I've seen some major refactoring in elementum.

I will add a check there to skip those items.
Thanks. This is very helpful.

I have used the existing "show unaired episodes" options to influence listing episodes in Progress with "Aired" being after now.
I would be fast if we just use paging and split to usual number per page. But. We are checking each trakt show with TMDB database and some items should be dropped off the list, then we check episode, which also can be not in the TMDB database, and then it can be in the future, so also drop off, so you see you are getting less then required items per page. If it's the first page - it's fine, if not first - it's too ugly.
Bad we can't get multiple episodes/shows/movies by one request :)

@elgatito I made a feature request on their G+ page: https://plus.google.com/104974452270599315078/posts/QpHJJ7y7n3t

@hoshsadiq I have totally loose the point of this issue.
Can you describe how you see the desired progress page and what should be there?
Now it's the same as Trakt's Progress page where you see Next episodes for each show that you watch, sorted by last watched time in descending order. ( https://trakt.tv/users/username/progress )

Yes, sorry, so I think I neglected to mention that I always have the below filter on. I think adding the additional airdate as @burekas7 mentioned, and hiding the items that have future airdates is what my I had in mind. Having those two imo would be enough for this issue to be closed

Changes in v0.0.54:

Added settings for colors, date format, sorting of items on the progress page.
Refactored to use last activities, so now it's not too fast for the first time, then it should be quite fast.

Closing this one. Let it be a separate issue if there is something else to do with the progress page.


What is the color theme on the main site?

Not an issue at all, but wanted to ask what is the color theme on
the main page of your website ( http://jscs.info/ ).
Interested in themes for Sublime, Webstorm and VisualStudio.

@hzoo should know about it, since he did the decoration

Looks like solarized dark, actually.

Oh in the pictures? Yeah its a solarized dark theme for the terminal.


fix staging table id generation

Fix bigquery staging broken in #124
Reverts the behavior of staging dataset and table generation to be equivalent to before #124.

👍


no configuration file provided: not found

Bug description
I am able to run the initial docker image and login but I I am unable to download models
Steps to reproduce
docker compose exec serge python3 /usr/src/app/api/utils/download.py tokenizer 7B
no configuration file provided: not found
Environment Information
Docker 20
Debian Testing
Screenshots
No response
Relevant log output
No response
Confirmations

[X] I'm running the latest version of the main branch.
[X] I checked existing issues to see if this has already been described.

You must be in the directory where you cloned the repo, otherwise docker compose will return no configuration file provided: not found.


What does the hash refer to in the python api tar.bz2 filenames?

What does the hash refer to in the python api tar.bz2 filenames?
From #3255:

When building the Python API on Ubuntu and OSX, the tar.bz2 file seems to have the wrong commit hash in the filename.
Ubuntu build: vapor-3.7.0-h2bc3f7f_0.tar.bz2
OSX build: vapor-3.7.0-ha5a8b8e_0.tar.bz2
Instead of h2bc3f7f and ha5a8b8e, I believe these should be the commit at the head of our main branch, dfa1b14.

If it's not the commit hash of origin/main, what is it?  Conda's documentation seems to indicate that these filenames are custom, and the example does not add any hash.

Bottom line: It would be helpful to have a way to determine the commit that the conda bundle was built upon.  It's not in the filename.  There's ~probably~ definitely a way to do this via the Python API.


No access to my public folder (kbfs)

Getting error that some revoked data detected when writing to my public folder.
my log id: eba86bb5fddcd49cf73b8f1c

@DarthWed it appears you reset your Keybase account today, which revokes all of your previous keys, making it impossible to read the old data since it was signed by now-bad keys.
We are working on something that will automatically fix your folders for this case, but it's not done yet.  In the meantime, we have to manually clear out your old folders, to make way for fresh ones with your new keys.  (e.g. #2780.)
But we need your signed, public permission to reset those folders.  If you want us to do that, please run the following command on one of your devices, and substitute the current date and time as indicated:
keybase sign -m "<DATE_AND_TIME>: Please completely reset folders /keybase/private/wed and /keybase/public/wed because I reset my Keybase account."

and post the output here. Thanks!

Hey strib.
05/10/2016 - 08:45 AM CEST: Please completely reset folders /keybase/private/wed and /keybase/public/wed because I reset my Keybase account.
BEGIN KEYBASE SALTPACK SIGNED MESSAGE. kXR7VktZdyH7rvq v5wcIkHbs41bK3H gDDr6tn3UR2BxSK 0jaccCKrxN0JGaX lnkNEkbjlm2P76J LXgO2fyRD6JbLrK BE0zR576sLtCr9j RNp8OXmroYlKITA vNhR8586PvYao14 wz9p6ulToBlJlE9 kI1zPCCSTDFbTIv ZyyYPITRMNP8ri1 C4ikaUxTDM1JTQ0 kCFZViHrnZ68fDZ G7VApGREKYp5uyL CykIsOSFFCCbySj r4KuRQjifQj5Scl LzgNo2IVsOmlRAr AlAZY4A99DaJm8P ZlUR5xyb2vzs6fW tO3sonCHNAwL9ZK jD6NPQc6Qbkyy1d xnH0mFu8a5caLVR XJ2EcUlWgsOGS38 r1nPtgm2PabTe13 WYmoQB6pbdcO1dW Dr61YEb1onzeSRQ xOHyZ6FolYBUPOn EezICGd3VYiLdQH uHkrAaq04ahFRcD AED9acJ2WsBYLFg . END KEYBASE SALTPACK SIGNED MESSAGE.
Thank you very much! :-)

@DarthWed these are now reset.  Sorry for the delay!  Give those folders a try again and please close this issue if they work now.

Working great, thank you very much!


Support CLUSTER SETSLOT  STABLE

Implement clusterSetSlotStable(int slot) method in Redis Cluster API (for 3.4 and 4.1 versions)

Implemented.


moving the left handle automatically scrolls EditableText to the right handle, which doesn't happen on native

fixes https://github.com/flutter/flutter/issues/105821
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai
@justinmc
please review!

cc @chunhtai

This whole comment assumes that there's no way to drag the right handle without it already being in view. If that's a wrong assumption, then disregard :).
I wonder if this is the correct solution for this problem... The reason why this is not a problem for the second selection handle is that the call to selectionDelegate.bringIntoView in _handleSelectionHandleChanged always does nothing since dragging the second selection handle means the end of the selection extent is already in view. It gets called for both left and right handles, but never ever does anything for the right handle.
if we know that it shouldn't be called when dragging the left handle, and never does anything when dragging the right handle - do we need this call at all? Can't we just delete it and all is well?

@justinmc
thank you for review :) I fixed it based on your review.
but I'm not sure where I should write enum. Where is the most optimal location to write enum?

@antholeole
thank you for your comments!
Why doesbringIntoView exist there originally? actually, I can remove the line and it passed all tests in my local...

If we go with @antholeole's approach, can we get rid of the idea of isEnd altogether?  That would make things really simple.

@antholeole thank you for your comments! Why doesbringIntoView exist there originally? actually, I can remove the line and it passed all tests in my local...

@takassh It was an old implementation of edge scrolling, I think. Edge scrolling was moved elsewhere, but this line was overlooked. I think it is the sole culprit of #105821 . When you said "passes all tests" are you including the tests you wrote for this PR? If so, I think it would be best (i.e. smallest footprint) if this PR was just deleting that line, and the tests you wrote.

@justinmc @antholeole
I see. thank you.
yeah, I said we could remove selectionDelegate.bringIntoView in _handleSelectionHandleChanged.
however, we can't remove other bringIntoView to pass tests. e.g. _editableText?.bringIntoView in _handleSelectionChanged.
it seems selectionDelegate.userUpdateTextEditingValue in _handleSelectionHandleChanged internally calls other bringIntoView also. (in short , as a result, _handleSelectionHandleChanged is calling bringIntoView two times)
therefore, anyway I think we need some flag like isEnd to tell which handle is dragged now.

@takassh So, just to be clear, when you remove the line that I mentioned, https://github.com/flutter/flutter/issues/105821 still happens? I removed that line and this is the behavior I get:
https://user-images.githubusercontent.com/48811365/175373354-d8f78799-61bf-42ee-977a-df2540ea39a1.mov
It looks like it fixes the problem for me, unless I'm testing wrong.

Looks like you're right! The further calls are needed on platforms not iOS / macOS. thanks for this!

@antholeole

So, just to be clear, when you remove the line that I mentioned, https://github.com/flutter/flutter/issues/105821 still happens?

yes
@justinmc
so I think we need the enum. where should I write enum definition?

@justinmc what about changing ‘SelectionChangedCause.drag’ to something like SelectionChangedCause.dragLeftHandle and SelectionChangedCause.dragRightHandle?
Just a thought!

@justinmc
any updates?
Is there anything I can do?

@takassh I'll be taking over the review on this one :) It looks almost done though, good job! I'll look it over right now.

Suggested edit:
diff --git a/packages/flutter/lib/src/widgets/text_selection.dart b/packages/flutter/lib/src/widgets/text_selection.dart
index 30f96187ba..e59d176fd9 100644
--- a/packages/flutter/lib/src/widgets/text_selection.dart
+++ b/packages/flutter/lib/src/widgets/text_selection.dart
@@ -2286,6 +2286,11 @@ class ClipboardStatusNotifier extends ValueNotifier<ClipboardStatus> with Widget
   }
 }

+enum TextSelectionHandleSide {
+  BaseHandle,
+  ExtentHandle
+}
+
 /// An enumeration of the status of the content on the user's clipboard.
 enum ClipboardStatus {
   /// The clipboard content can be pasted, such as a String of nonzero length.

@antholeole
thank you for reviewing!
I fixed bool IsEnd to TextSelectionDraggedHandleSide handleSide.
however, I encountered following CI failure, and it seems not to be my failure, because I didn't touch about flutter_logo in this PR.
| Warning - golden differed less than .06% (0.006202083333333334%), ignoring failure but producing output
| Golden "golden_widget/flutter_logo.string.color_filter.png": Pixel test failed, 0.62% diff detected.
| Failure feedback can be found at /b/s/w/ir/x/t/flutter_customer_testing.flutter_svg.DAWBDP/tests/test/failures
...
| Warning - golden differed less than .06% (0.008170833333333334%), ignoring failure but producing output
| Golden "golden_widget/flutter_logo.string.color_filter.blendmode_color.png": Pixel test failed, 0.82% diff detected.
| Failure feedback can be found at /b/s/w/ir/x/t/flutter_customer_testing.flutter_svg.DAWBDP/tests/test/failures

Could you check the CI failure?

@antholeole
wow, thank you for quick review!!
Code was changed based on your comment without https://github.com/flutter/flutter/pull/105836#discussion_r925632358

how do we feel about configuration objects? Currently I’m just passing around a raw WidgetBuilder as a loupeBuilder, but there may be additional configuration to the loupe down the line that may be added (for instance, currently it’s hard coded that on android the loupe should see the handles but on iOS it shouldn’t - someone who god forbid wants to build their own loupe may want control over that). TextField already has 54 parameters, spamming it with loupe parameters does not feel ideal. Would it be flutter-y to create a LoupeConfiguration object that, for now, holds a small amount of parameters for a little bit of future proofing? Or does it hurt discoverability too much?
Mostly cc @justinmc but also cc @Renzo-Olivares @LongCatIsLooong

Because of combing all commits into one, it seems github requested many reviewers... sorry.

@justinmc
Thank you for your review!
I fixed code based on your comments. And I combined all commits into one to pass test.
I think, finally, we're ready to merge code.

@justinmc
I reviewed my changes from your comments and I found another solution.
Especially, I fixed it to infer the handle, and remove the parameter handleToView and TextSelectionHandleSide enum.
I think it's well organized.
Please review it again 👀

@justinmc
I reviewed my changes from your comments and I found another solution.
Especially, I fixed it to infer the handle and remove the parameter handleToView and TextSelectionHandleSide enum.
I think it's well organized.

@justinmc
sorry for inconvenience.
if you have time, please take a look.

Thank you! glad to hear!
I fixed them from your comments and merge a commit with master.

@justinmc
Thank you! glad to hear!
I fixed them from your comments and merge a commit with master.

@justinmc
Please review again! Thanks

Sorry I lost track of this!  I'm going on leave but I'm adding this to my list to look at when I get back in 2 weeks.
In the meantime you probably need to sync this with master as it's gotten out of date.

@justinmc
hi 👋 long time to see you!
I updated from your new comments and my pr was synched with the latest master branch.

Thanks for the quick response, merged!


Why are section ids read as var u7 in wasmparser?

The spec says that a section id is a byte, why are then the section ids in wasmparser read as a var u7? I know there is no practical difference between the two interpretations as the number of valid section ids are too few to matter but was just curious about this difference.

@yurydelendik do you know this perhaps?

@yurydelendik do you know this perhaps?

Indeed spec says it is one byte but does not define its type in the referenced section.
There is also https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#high-level-structure , which says
id | varuint7 | section code

Indeed spec says it is one byte but does not define its type in the referenced section.
There is also https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#high-level-structure , which says
id | varuint7 | section code

Oh I think at this point BinaryEncoding.md is a bit out-of-date and/or not maintained, but the official spec defines this as a singular byte?

Oh I think at this point BinaryEncoding.md is a bit out-of-date and/or not maintained, but the official spec defines this as a singular byte?

@yurydelendik If the original implementation was based on the document that you shared, that does explain the var u7. Again pardon my nitpick but the spec says that bytes encode themselves . As it doesn't make any difference to the parsed values, and my original question is answered, I'm closing this issue.

@yurydelendik If the original implementation was based on the document that you shared, that does explain the var u7. Again pardon my nitpick but the spec says that bytes encode themselves . As it doesn't make any difference to the parsed values, and my original question is answered, I'm closing this issue.

@alexcrichton I don't know how I missed your last comment. Yes the official spec says that each section starts with a one byte section id.

@alexcrichton I don't know how I missed your last comment. Yes the official spec says that each section starts with a one byte section id.


Add spec, and simplify plugin function sig

This makes it clearer that it's Smith's job to worry about whether the plugin is spec compliant. I'm not sure about this now, but I'm leaving the PR here for discussion... you might have a plugin that wants to react to the specified type in the spec (i.e. pass PluginSpec instead of Spec), or even to something like the type annotations on the object.
I'm also still confused about why we want PluginSpec separate from Spec. Isn't everything simpler if we just have a single 'Spec' object, and just treat it separately depending on the type? What's the advantage of having a separate PluginSpec?
(I've targeted a branch for now so we can see the diff, but I don't want to merge this into the branch)

Addressed in another pr.


Camera position is different from paper

Camera position is maybe different from original paper about deepmind control suite

This problem is solved with these commits.
3eec1ba13d27e2a5d1c417e3c48401fb43229ca5
e5460249398b4291125dc8a1d55f1c593728d65b


Integration tests in ponyc CI to prevent some regressions.

We need a system for integration tests in the ponyc CI to prevent regressions that are difficult to unit-test in-process with the ponytest package.
We would probably want to write an integration test suite in Pony with ponytest that runs subprocesses using the upcoming subprocess package described in #716.

We have been collecting some minimal repro test cases for hard-to-test bugs here.
We can also link to other tickets from this ticket so that we know to write some integration tests for those as well.

We need to integration-test that finalizers are called for all object types (actors, primitives, classes, etc), as we have seen this regress before in https://github.com/ponylang/ponyc/issues/715

Why do we need the process package for this? So that if any individual test crashes, we still run the entire suite?

@SeanTAllen - at least some integration tests would need to parse the output of stdout and/or stderr (such as the finalizer tests).  We could probably hack up something with FFI calls to make this happen, but at that point you've kind of half-written the process package anyway.  Since you've said that the process package is nearly complete (or at least an initial version is nearly complete) it seems more prudent to use that instead of duplicating work.

@jemc makes sense

#772 was merged and we now have the package we need for running subprocesses, so this unblocked.

@jemc should this be labelled as blocked again as ProcessManger doesn't work on Windows?
Also I'm still unclear on how this would work. This isn't really a "RFC thing" but I think that it might benefit from that process or something like it so we have a write up on what needs to be done with a decent level of detail and than we could open an issue for it and someone from the community could undertake.
Thoughts?

Maybe we could use the LLVM JIT framework for this? It would allow us to bundle every "language" tests into libponyc.tests or libponyrt.tests instead of polluting the standard library tests. I can give it a try next week if people like the idea.

@Praetonus - I definitely like the idea of using the LLVM JIT framework for "language tests" aimed at preventing certain regressions.  I don't know if that completely removes the need for "integration tests", but it might.
Also having some rudimentary use of the LLVM JIT under our belt would bring us part-way toward having a REPL, so that's cool.

@georgemarrows is currently working on this, using the JIT test framework that @Praetonus put in place.

@jemc do you think the bad pony tests are good enough to close this?

No, the "bad pony tests" in badpony.cc only test compilation. I believe that these all of the tests we've collected in the above-linked minimal repro subdirectory cannot be tested either by compiler tests or by ponytest tests, since they involve runtime behavior that doesn't necessarily occur within the bounds of a ponytest run (e.g. finalizers)

@jemc I believe with the runner that we recently added to get rid of the jit tests that this can now be closed, do you agree?

Should we keep it open until we add regression tests for the two areas mentioned in these two comments?
https://github.com/ponylang/ponyc/issues/717#issuecomment-207460320
https://github.com/ponylang/ponyc/issues/717#issuecomment-207460915

I've moved 2/3rds of the minimal-cases over. The last 2 are a bit more complicated to automate.

Closing as we don't know how to address the 2 remaining cases. I will leave the minimal cases directory and tests for now.


Update virtual-machines-create-custom.md

Updated the MS Date after reviewing article.

Hi @mmccrory, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@mmccrory There's a merge conflict on this request.  Could you please resolve the merge conflict?  If you need any help feel free to ask me.

Fixed merge conflict and incorporated edits into https://github.com/Azure/azure-content-pr/pull/12260


Simulator not compatible with newer versions of Linux OS

The Linux Term 2 Simulator v1.45 program crashes after clicking Ok in the dialogue box where the resolution and quality are selected.  It crashes about the time that the "Made with Unity" splash screen should appear and before the screen that allows you to select which simulator to run.  It seems to be independent of my project code as this happens before the websocket connection is made.  STRACE says that it crashes on a SIGABRT fault: +++ killed by SIGABRT (core dumped) +++ Aborted   I had this issue on a computer running Fedora 32, on a second computer running Ubuntu 20.04.1, and also on a third computer running a VMWare virtual machine of Ubuntu 20.04.1.  When I tried it on the third computer in a virtual machine running Ubuntu 16.04.7 then it worked as expected.  It also worked in a virtual machine running Ubuntu 18.04.5.  I installed Ubuntu 18.04.5 on the second computer and it works there now too.  I wish I had more details other than a correlation between OS version and the fault, but I hope that gives a good starting point to dig deeper.

@gabesj do u already have a solution for this problem? i also getting the same issue when running the Term3 Simulator v3.12 in my Ubuntu 20.04.1 and Linux Mint 20 CInnamon

@RifkyYP Sorry, I haven't found a solution.  I ended up installing Ubuntu 18 on a second computer and used that computer to run the simulator.

okay, thank you for your response

I have the same problem. A simple workaround I found is running in fullscreen by unchecking windowed. It is a bit disturbing. But at least it works without a problem.

Unchecking windowed. It also works for me.


CORS hook throws errors

Sails version: latest
Node version: irrelevant
NPM version: irrelevant
Operating system: irrelevant

If I define the following in config/routes.js
    '*': {
        cors: true,
    },

A preflight request with an Access-Control-Request-Method header (sent by the latest version of Chrome) triggers the following thrown error in cors/index.js:
TypeError: Cannot read property 'origin' of undefined
  at _sendHeaders (/Users/burke/code/api/node_modules/sails/lib/hooks/cors/index.js:159:35)
  at routeTargetFnWrapper (/Users/burke/code/api/node_modules/sails/lib/router/bind.js:178:5)
  at Layer.handle [as handle_request] (/Users/burke/code/api/node_modules/express/lib/router/layer.js:95:5)
  at next (/Users/burke/code/api/node_modules/express/lib/router/route.js:131:13)
  at Route.dispatch (/Users/burke/code/api/node_modules/express/lib/router/route.js:112:3)
  at Layer.handle [as handle_request] (/Users/burke/code/api/node_modules/express/lib/router/layer.js:95:5)
  at /Users/burke/code/api/node_modules/express/lib/router/index.js:279:22
  at param (/Users/burke/code/api/node_modules/express/lib/router/index.js:351:14)
  at param (/Users/burke/code/api/node_modules/express/lib/router/index.js:367:14)
  at Function.process_params (/Users/burke/code/api/node_modules/express/lib/router/index.js:412:3)

The relevant Sails code is here: https://github.com/balderdashy/sails/blob/master/lib/hooks/cors/to-prepare-send-headers.js#L40-L41
routeCorsConfig is undefined after that, which throws the TypeError later on.
This is only OK because Express 3 catches thrown errors, and the Express 3 options handler ignores errors. I've added braces and a console.log to make this clear (in express/lib/router/index.js):
    // implied OPTIONS
    if (!route && 'OPTIONS' == req.method) {
      console.log('error', err);
      return self._options(req, res, next);
    }

This behavior changes in Express 4 - it generates a 500 server error, which is how I noticed it. It seems bad to be relying on Express's fallback behavior like this, especially because whatever callback that gets registered isn't going to be run.

Here's how we've fixed this on our fork, https://github.com/Shyp/sails/pull/36, you should be able to pull in the test, but you'll need to apply the patch to to-prepare-send-headers.js instead of cors/index.js.

Thanks @kevinburkeshyp, taking a look!


Implement the Vezel.Novadrop.Data library and novadrop-dc tool

This will be based on past experience in Alkahest and Crux.

Partially done in ee1e6dcaefe70bf992509ba6763b3ac744eb29f4.
Still need to:

Implement pack and unpack commands.
Exclude __value__ from DataCenterNode.Attributes.


Reconsider project name?

Even though I know where the project name comes from it appears to me to be dangerously easy to misread.
I am sure there must be alternative mountain passes available in Switzerland that do not suffer from this issue.

I think I already raised that in the past. +1 for a renaming.

Hi, thanks for bringing this up. We have discussed this internally and decided to stick with the current name. As you know, it is indeed a name of a mountain pass in the Italian-speaking part of Switzerland, and the word itself is completely innocent; it's also pronounced something like "neh-jah".
There is indeed a (hopefully very remote!) possibility that someone not familiar with the Swiss landscape or the Italian language will at first glance see something untoward. However, we hope that such an event will be a nice opportunity for people to get to know our beautiful mountain passes and the Italian language better! After all, there are a lot of languages in the world, and a lot of words in those languages will look silly or wrong in other languages. I should know; my native Finnish gets people laughing all the time - some very common phrases we use are obscene curses in Italian, for example...
So we're hoping this can in fact be a step towards diversity and not away from it!
Angina Herrmann, Head of Marketing & Communications, DECTRIS


eval generation path issue

Hello, I'm trying to use your eval pipeline.
I ran ./inference_pipeline.sh -b pubmedqa -c gpt2 -s 0 -m 0 -out_dir out_dir
After it is done with generation I get the following error:
Stored pubmedqa generations to the following path: ../benchmarks/generations/pubmedqa-gpt2.jsonl
Traceback (most recent call last):
  File "evaluate.py", line 475, in <module>
    main(args)
  File "evaluate.py", line 390, in main
    data = load_jsonl(path)
  File "evaluate.py", line 39, in load_jsonl
    with open(filename, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: '../benchmarks/generations/pubmedqa/pubmedqa-gpt2.jsonl'

It looks like the generations are saved in: meditron/benchmarks/generations/pubmedqa-gpt2.jsonl
But eval looks for them in: meditron/benchmarks/generations/pubmedqa/pubmedqa-gpt2.jsonl'

Hi @sia-cerebras have you dealt with this problem? I am facing the same issues right now.

Hi @sia-cerebras have you dealt with this problem? I am facing the same issues right now.

No, I ended up doing the evals with the Eleuther Eval Harness instead.


Feature request: disable organize import on specific lines

I like using the auto organize imports on save feature ("editor.codeActionsOnSave": {"source.organizeImports": true} on settings.json), but I had to disable it for some specific cases for which the import organization would break my code.
For instance, take this React JS file
import 'react-app-polyfill/ie11';
import React from 'react';

const app = () => {
  return

;
};

The React Polyfill import specifically requires to be the first line in the file to provide Internet Explorer compatibility sucessfully. However, if you save the file with import organizing active, the import React from 'react'; line jumps to the top, breaking React Polyfill's functionality. I had to disable the functionality in my settings.json to work around the issue.
What I propose is some kind of comment-disabling feature, like so:
// vs-code-organize-imports-disable-next-line
import 'react-app-polyfill/ie11';
import React from 'react';

const app = () => {
  return

;
};

This has also been mentioned as an issue previously: https://github.com/microsoft/vscode/issues/78553#issuecomment-520929023

Having the same issue when importing global css files that needs to be kept in a specific order :
import "styles/globals.css"; // Default styles
import<EMAIL_ADDRESS>// Theme overrides

They get reorganized in the wrong order, which leads me to having to disable the organize import feature for the all project, which is a shame :(
Being able to ignore a file would solve issues like this.

Would be a good feature to be implemented.
If you were to use nanoid in React Native, you would need to import
import "react-native-get-random-values"; at the top of your file before any other imports.
Organizing imports would push this down causing your build to throw an error.

Just run into this in this context https://github.com/angular/angular/issues/40977#issuecomment-785752667
The import has to be the first line otherwise it causes an error.

+1 for this feature. In Next.js, import order matters when importing CSS files.

+1 for this awesome feature! I need this importing CSS files in React.

Another example why we need this:
To initialize dotenv  you need to run
import dotenv from "dotenv";
dotenv.config();

however that can be shortened as:
import "dotenv/config";

Sometimes we need to initialize the dotenv before importing other modules, and organizeImport can mess this up by putting the import "dotenv/config" after importing other modules

+1 i need 'reflect-metadata' to be the first lib in my file

+1 for example in Nodejs i need to import my controllers after i connect to mongoDB.

@RyanCavanaugh What kind of Feedback are we waiting for?
This feature is very important when we use reorganize import automatically on save. It happens often in projects that we must import something before other imports. I have to use 'Save without formatting' every time I work on a file where the import order is important, it is boring and also difficult to remember for all team members that they should not change the order of imports in that specific file
Here are some use cases

Importing i18n configuration in your entry file before any other component
imports files with mocks in test files before the files that are mocked
CSS order
polyfills

I need it to respect requirements of https://github.com/welldone-software/why-did-you-render

Create a wdyr.js file and import it as the first import in your application.

+1 for this feature. I need it to maintain order of imports when using FullCalendar in Next JS projects with next-transpile-modules package

What does it meant to disable the sorting of one item in a list? e.g. if I wrote
import E from "E";
// organize-imports-disable-next-line
import D from "D";
import C from "C";
import B from "B ";
import A from "A";

and "sort" this list, what is the new order?

Good point. Perhaps pinning an import to the top of the file, as opposed to disabling organizing it, then? Then the others can be normally sorted?

I would even say 'pinning one or multiple imports to the top of the file without changing their order'. I believe that this would handle all the use cases that were cited here.
Something like:
import E from "E";
import D from "D";
// organize-imports-disable-above
import C from "C";
import B from "B";
import A from "A";
``

This feature request could cover this scenario https://github.com/microsoft/vscode/issues/35350

Any updates on this one?
In Inversify, I must have import "reflect-metadata"; as the top import for my server.ts file. Changing this breaks the whole server.

+1 we also need polyfills at the top of the import list.

+1

Can the people +1ing this answer the above question? https://github.com/microsoft/TypeScript/issues/41494#issuecomment-988187118

I too would like this. e.g. I need to make sure react-app-polyfill/stable comes first in my imports but I want the rest of my imports to be sorted after it.

What would folks think if we implemented the rule that each block of newline-contiguous imports sorted independently?
e.g.
import c from "C";

import d from "D";
import a from "A";
import b from "B";

would sort to
import c from "C";

import a from "A";
import b from "B";
import d from "D";

@RyanCavanaugh My concern with the proposed contiguous-imports solution is how it would effect automatic imports. Which group would automatic imports be added to? It gets more confusing when you have more than two groups.
I like the previously proposed solution of disabling above/below as others have mentioned since it seems that users typically want imports pinned to the top or the bottom (can't speak for everyone, but this has been my experience). It also makes it clear that automatic imports would be added in between the organize-imports-disable-above organize-imports-disable-below comments.
import b from "B"
import a from "A"
// organize-imports-disable-above
import e from "E"
import f from "F" // <-- automatic imports get added and organized in this group
import g from "G"
// organize-imports-disable-below
import d from "D"
import c from "C"

@RyanCavanaugheven I am in favor of your suggestion.
I have not stumbled upon the need to pin dependencies to the bottom but feel the urge to visually separate blocks of imports that auto-organize messes up.

I like @RyanCavanaugh's proposal a lot. It's clean and easy to understand. No need for ugly comments.
@robertn702 Automatic imports get added to the last group, which is what is needed in 99% of the cases, as the first groups are usually polyfills. If it's not the case, you can always move the import manually.

Happy to take a PR for "automatically create sort groups based on newlines" behavior

hi @RyanCavanaugh, from the your suggested behaviour above, I create an solution for sort groups based on newlines. It would be great to have your feedback 😀 https://github.com/microsoft/TypeScript/pull/48330

Is this integrated into recent versions of VS Code? Organize Imports collapses groups in 1.67.1 using<EMAIL_ADDRESS>

Hi.
Thanks for the amazing update !
Do you know if there is a way to enable such the same parameter to export organizing?
By default, "organizeImports" also organize exports.
It seems I have the same problem when trying to make group of exports, which are sometimes dependant of previous export (and which should not be reorder globally) :
Example - Before
export d from "D";
export  a from "A";
export  b from "B";

export  c from "C"; //depends on D

Current behaviour
export a from "A";
export b from "B";
export c from "C";  //depends on D which is not currently exported => causes a build error
export d from "D";

Desired behaviour
export a from "A";
export b from "B";
export d from "D";

export c from "C";  //depends on D => no error

@Rlamotte please open a new issue. Thanks!

NextJs 13 app directory needs 'use client' as the 1st line but VC Code moves until after the import statements. How  do  stop the move?

To avoid the following issue https://github.com/microsoft/TypeScript/issues/42873, I import some "unused" types like this
import type { Unused } from "some-dep"

But I am also using source.organizeImports on save, and it removes that line as it is not explicitly used in the code (it's still implicitly used)
I do not want it to remove that line
One fix I have is that I write the following to explicitly use the type
type Unuseds = Unused | ...

Now source.organizeImports no longer removes that line, but it's ugly and now VSCode greys this line out since the Unuseds type is now unused

It is possible to do this. Just add any comment to separate the items to be sorted, and those items in each 'comment block' will be independently sorted by the "Organize Imports" command.  E.g. in this code due to the two lines of comments, there are now actually 3 independent blocks of imports (the first two only containing one import), each block doesn't lose its place, only the imports within it get sorted.


Validate Release notes against template

Currently, we validate that release notes parse properly, but we could go further:
Templates give you a flexible way of specifying which release notes you want included where, but because of the nature of filtering, not all release notes are included if they aren't all covered by a filter. We should add a --validateAgainst field to the release notes tooling to allow specifying a template to validate against. This would then return an error if any release notes are missed.

Also will be good to add validation for missing issue number. I faced this during the 1.9 release. See PR https://github.com/istio/istio/pull/30551

Challenge with a missing issue number is Istio doesn't require GitHub issues, even for user facing changes.

Moving this to the 1.12 milestone due to recent inactivity


Add The Crazy by Gab1239Muzic

Song Name
The Crazy
Artist Name
Gab1239Muzic
Source
Youtube
Youtube Link
https://youtu.be/-N4jf6rtyuw?si=rUWUQoZ_R18LMv8M
Direct File Link
No response
Song ID
6480
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 36357089

reject
the artist is gnarls barkley


Transform improvements

Moved transforms by different files
Added missing lanGoose definitions for transforms

:goose:

@jifeon review it please

@jifeon Can you have a look on TransformPick and TransformGet. Seems they are duplicates.

@maZahaca is it ready for re-review?

I fixed issues, you mentioned before.
For now I just added one more transform.
I've tried to run it on real data, and some transform fail. Gonna fix that issue


Create an operation to add elements from Kafka

The operation handler should stream elements from a kafka queue into Gaffer via the AddElements operation.

Merged into develop.

We have added the following operations:
AddElementsFromFile
AddElementsFromKafka
AddElementsFromSocket
Be default these operations are not registered. We have written handlers for them based on Apache Flink.
In order to make use of the flink handlers you will need to include this dependency:
 <dependency>
  <groupId>uk.gov.gchq.gaffer</groupId>
  <artifactId>flink-library</artifactId>
  <version>${gaffer.version}</version>
</dependency>

You will then need to register the flink operations and their handlers with your store.
You just need to add the following to your store properties file.
gaffer.store.operation.declarations=FlinkOperationDeclarations.json


Airlock - Review VM per airlock request

Is your feature request related to a problem? Please describe.
To make it easier to review request, a new VM per request with the files already exists on it for reviewing is ideal
Describe the solution you'd like
when asking to review, a new vm will be  deployed and data will be downloaded  into

Duplicate of https://github.com/microsoft/AzureTRE/issues/2245


Make CallForm action and campaign configurable in template

This should make it easier to override and add new call endpoints later.

Looks great, thanks!


Crop timer doesn't recognize the outdoor crop in CN version

planting/tending can't record the crop or the bed outside,
while indoor pot can be recognized correctly.

The CN version is on a different game version that I do not have access to. It is not supported. Use one of the CN-specific forks, if they exist.


Merge Hacktoberfest - v4.1

[X] Completed PR - Has all features or fixes that it was meant to and isn't half done
[X] Follows the style guide - Style guide found here
[X] All changes have been tested

Added
Command - usage - example

tempban - _tempban <user> <duration> [reason] - _tempban weeryan17 1d Many spellinz izzues
tempmute - _tempmute <user> <duration> [reason] - _tempmute Charlizard 12h Too much rioting
Reminders! (Beta) - _remind <duration> <reminder> - _r 1d Check feedback on remind command

Changed

Sharding logic again to better suit the new way with JDA
Shardinfo command now shows some more info - websocket ping and VCs
Some permissions stuff - added _permissions reset which will reset all permissions and groups also added _permissions restoredefault which is good when we add new perms BUT will re-add removed perms. Use with caution.
Change the purge command - You can now purge users! New usage _purge <'all'/user> <amount> example: _purge BinaryOverload 50 or _purge all 50
Purge will log to the modlog! It will show who was purged (if applicable), the amount of messages ans who purged.
You can now edit tags using _tag edit <tag_name> <tag_message> as opposed to removing and re-adding! Beta Only
Added a flarebot.playlist.clear permission Highly requested - This is a default permission. Remove it with _permissions group Default remove flarebot.playlist.clear
Selfassign will now accept roles name for add and remove! New usage: `_selfassign add/remove <rolename|id>
Reports creations and report changes now go to the modlog!

Fixed

Internal NPEs
Issue where ban would throw an error if the user didn't exist.
Bug where you'd be DM'd since we can give other bots roles.

Beta
_currency and _convert are now out of beta! Make sure to find any bugs and report them! :)

So how are people supost to check warnings now?

@weeryan17 same way they always did, the one deleted is the "points" one from automod which Ian old and unused.

The outdated request is not outdated, don't ignore it :P

 flarebot.playlist.clear isn't a sub permission

 Add "t" as an alias for tags

 Edit argument for tags

Btw you might want to change the contributing.md to binary and walshy are verry picky. arsen isn't a part of the repo any more. or you chould just say walshy is picky. ether way

Go for it, do it yourself it's a tiny change :P

Can we reopen this pr now

Please tell me how

¯_(ツ)_/¯
We might have to make a new pr.


better handling of unmanageable trees?

Some trees are forests unto themselves, and the user will wait a long time to get any satisfaction if they are lucky with something like: https://funnotate.legumeinfo.org/?family=legfed_v1_0.L_009642
it is probably worth noting that although the tree is large, it actually comes back reasonably quickly in the older app:
https://legacy.legumeinfo.org/chado_phylotree/legfed_v1_0.L_009642
Not sure if the excessive slowness in the new version is a consequence of using lorax or something else. But, at a minimum it might be nice if the gene family descriptor could be displayed before the whole tree is obtained, so the patient user can decide based on that descriptor if the wait is likely to be worth their while.

All Hail MacVyvyan!

It's like adding injury to insult when the page that you waited for so long to load that you started ignoring it and doing other things upon your going back to check on it is giving you the shiny salute:
Disconnected from the server.
Reload

Retrieving the tree takes less than a second, displaying the tree is the bottleneck. I am working on speeding it up.

OK, that's good info- I thought the older app and the funnotate version were basically using the same display engine, so it seems a little weird that this would be the bottleneck, but I'm probably oversimplifying the way things evolved.

It looks like TnT Tree's parse_newick() (which converts the Newick tree to a JSON object) is the problem. I am looking into that, maybe we will have to write our own (faster/more robust) version.

I guess that makes sense. The older version was doing conversion to json server-side, and I think it was using a pre-parsed database representation of the tree structure as well. However, it does seem like newick parsing ought not to be a major bottleneck, though perhaps nested parentheses are more of a syntactical viper's nest than I'm imagining. Anyway, sounds like you're on a reasonable course. It might also be possible to get the data in a non-newick form from intermine (possibly not the json you'd want, however), but being able to handle a standard format seems better.

I suppose we could avoid optimizing the parser if we instead stored pre-JSONified versions of the trees and served them as an option from lorax. Not sure if that would end up being an easier route, but it would be more similar in spirit to how the older app worked. Just a thought, not sure on which side of the fine line it may lie between clever and stupid

On closer examination, the parser is fast but loading the parsed data into the tree for visualization is the bottleneck. (My mistake, they were on the same line.) I am looking for a way around this.

does it differ in some essential way from how the older app did the corresponding thing? the only thing that comes to mind as a possibility (based on my limited familiarity with both old and new apps) would be if perhaps some event handling code  is getting prematurely associated and going through a lot of work firing / receiving before the tree is actually ready for interaction.

There is a line
// wrap in timeout in order to wait to render the tree before computing label bounding boxes
setTimeout(highlightSequences, TIMEOUT_DURATION_MSEC);

but this is for highlighting user sequences, it should not apply to the family-based tree.
I will look at what the legacy code did.

Try it now -

Bitte schnell, nein? But subsequent toggles of the taxa chart and MSA no longer work, it looks like the global copy of the phylotree is not updating properly. I am looking at that now.

Ja, schnell, schnell- aber wo sind deine komplimente?

what did you change to make the improvement?

I just wrapped the tree initialization in a future block (in R). But I think the promise handling really needs to go in the JavaScript itself. No kompliments until then!

Still struggling with this. It needs something like Crossfilter, where we set all the data first and then try to draw the charts.

IIRC, the original phylotree implementation used dc.js which I think uses crossfilter somehow. In any case, maybe best to put production version back to the sometimes slow but always fully functional state? I was actually wanting to look at one of the MSAs today and couldn't (that functionality seems to be completely broken on the legacy site now, although it may be a simple fix there, looks like an error similar to what you helped Ethy get around).

Production version is back where it was.

Thanks, that gave me what I needed.

"The asynchronous processes win, they always do."

Finally figured out how to set the 'hidden' attribute for all MSA sequences simultaneously instead of individually. Fixed in commit 0249277.


Update EDPM services path

fix https://github.com/openstack-k8s-operators/dataplane-operator/pull/203#issuecomment-1573472226

we need to override the CI failure here and merge this one given that https://github.com/openstack-k8s-operators/dataplane-operator/pull/203 has merged.

/lgtm

we need to override the CI failure here and merge this one given that openstack-k8s-operators/dataplane-operator#203 has merged.

we also need to update openstack-operator, I've triggered it here https://github.com/openstack-k8s-operators/openstack-operator/issues/144


Replace print with logger in a couple files

Short Description:
Replace print with logger in a couple files and add myself to contributors
Fixes:

This branch has conflicts that must be resolved

https://github.com/PokemonGoF/PokemonGo-Bot/pull/568/files


suggestion: add "return this;" in Services for chaining capability

For Best Practice of chaining in the return functions on services the function need to return this.
BTW i try to comiit those changes, after i create branch but i dont have permissions :)
how can i get permission for pull requests?
Thanks Oren

services are refactored in the whole app.
thanks 👍


edit single box

is available when pinput allows user to edit a single box?

Hi @vungo99, it's not available yet.

tks for your reply. one more question about the edge case, when 2 or more SMS OTPs are sent at the same time, can pinput detect correctly SMS OTP from the right app's vendor?
thank u so muchh

@vungo99 If you enable smsRetrieverApi it will only read SMS that will have the application signature in the content. Check out the autofill section in the readme for more details.

Can I use smsCodeMatcher to detect OTP when message has many number like : "your account 123456 will receive OTP 654321 and has valid in 300s " => detect otp : 654321

@vungo99 Yes, you can set a regex that will match the OTP instead of account id. Do both OTP and account Id have the same length?

Yes, they have the same length like :
" your id 022C123456 will receive OTP 666666 in 300s".
I write regex OTP\s*(\d{6}) but not work. How can I edit it?

@vungo99 Try this regex  r'\b(\d{6})\b'

smsCodeMatcher: '\b(\d{6})\b', right ?

smsCodeMatcher: r'\b(\d{6})\b'

oh tk u so much !! It work like a charm :D

hi @Tkko , I have the issue :
msg 1 : "TBC: your id 022C123456 will receive OTP 666666 in 300s "
msg 2 : "your id 022C123456 will receive OTP 666666 in 300s"
how can use regex to accept otp from msg1, not msg2

Hey @vungo99, I usually ask regex questions to ChatGPT 🙈

I use it too, but can't apply 🙈🙈🙈


chore(openchallenges): 2024-01-31 DB update

Changelog

Added:

5 challenges:

4 from Grand Challenge (GC)
1 per Luca's request

3 organizations

Updated:

some challenge names (based on latest pull from GC)
challenge end dates
challenge statuses
plot numbers

No Google Form responses were received.

@rrchai I will need your approval too, please 🙏🏼 Thanks, all!