[IMPROVEMENT] Unable to set properties to authentication context from adaptive authentication script

Describe the improvement
Unable to set properties to authentication context from adaptive authentication script.
Additional context
This improvement is vital in order to reduce the amount of customizations we need to do for unique business use cases. If there is no way to set properties to authentication context from adaptive authentication script to be used in a custom claim handler, we have to resort to writing a custom authenticator.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

Should be covered with https://github.com/wso2-enterprise/iam-product-management/issues/284


Fix language issue in search_pubs_query

From Japan search_pubs_query could not get correct 'citedby' because of language issue.
so I added &hl=en to request.

#52 already pull requested


Kotlin Plugin Bindings

Closes https://github.com/polywrap/kotlin-client/issues/31

kotlin bindings moved to https://github.com/polywrap/cli/pull/1795


Build failed for samples

Describe the bug
Build error for samples (ttps://github.com/spring-projects/spring-authorization-server/tree/main/samples)
./gradlew -b samples/demo-authorizationserver/samples-demo-authorizationserver.gradle bootRun
Downloading https://services.gradle.org/distributions/gradle-8.6-bin.zip
............10%.............20%............30%.............40%.............50%............60%.............70%.............80%............90%.............100%

Welcome to Gradle 8.6!

Here are the highlights of this release:
 - Configurable encryption key for configuration cache
 - Build init improvements
 - Build authoring improvements

For more details see https://docs.gradle.org/8.6/release-notes.html

Starting a Gradle Daemon, 1 stopped Daemon could not be reused, use --status for details

FAILURE: Build failed with an exception.

* What went wrong:
Could not open cp_settings generic class cache for settings file '/github/spring-authorization-server/settings.gradle' (/Users/xxxxxx/.gradle/caches/8.6/scripts/8p1dsh50yfy2z8nn9b37nu6aq).
> BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 66

To Reproduce
Got a fresh clone of the repo and ran: ./gradlew -b samples/demo-authorizationserver/samples-demo-authorizationserver.gradle bootRun
Expected behavior
Working samples
If that matters:
The samples worked for me some month ago. I've switched to a Macbook M3 and now have java 22 running.

@konstantinj Maybe this helps
https://docs.gradle.org/8.6/userguide/compatibility.html#java
A Java version between 8 and 21 is required to execute Gradle. Java 22 and later versions are not yet supported.


RegisterJobRequest::new accepts an Option<Job> as an argument, and throws it on the floor

Source ref: https://github.com/rivet-gg/Nomad.OAS/blob/master/clients/rust/src/models/register_job_request.rs#L26-L35
The obvious semantics would be that the job is stored in the job field, but the actual semantics are that the argument is ignored.

Thanks for the report. I'm deprecating this repo in favor of the official HashiCorp repo here.


One less bridge

Motivation and Context
Use inheritance instead of a member variable for the instance of habitat-sim.  This alleviates the needs for _sim._sim to get to methods where a bridge hasn't been built.
The one downside is that inheritance won't allow both habitat_sim.Simulator and HabitatSimulator to have their existing self.config.  The one in for HabitatSimulator was renamed hab_config.
How Has This Been Tested
The existing tests
Types of changes

Docs change / refactoring / dependency upgrade
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Really like the change! Can we use hab_config => habitat_config 4 characters more , but better readability. Thank you!


Show Certificate meta information in the UI.

Currently in certificates listing, only the alias and endpoints are being listed.
It is more useful if the certificate CN/ expiry status can be shown in the UI.

Fixed with https://github.com/wso2/carbon-apimgt/pull/6725/commits/c5d8741773c27725b4a2fdc7007cd13132d3bdcc


show peer dependencies, fixup dependency includes

Fixes up peerDependencies, as follows:

peerDependencies are now always shown as a dashed, grey line (see below).
sub-dependencies of peerModules are not shown, unless the target module is a regular dependency referenced elsewhere in the graph.
Removed UI toggle for hiding/showing dependencies (not actually useful)
Removed UI toggle for hiding/showing peerDependencies (peerDependencies aren't common enough or interesting enough to merit this option)
(code clean-up: renamed useDepIncludes hook and related state to useIncludeDev)

react-hot-loader module is a good module to test with:

And to see how peers render when referenced as a regular dependency, you can do react-hot-loader, react-dom:

attn @stof: Fixes #104

@broofa I don't see peer dependencies being linked in the graph for packages that are not at the root. Is that expected ?

To see a case reproducing it, create a package.json file that has dependencies on react-hot-loader, react-dom and react (i.e. the case of uploading the package.json of your project using those dependencies)


View more is dead, mismatch

The title basically says it all.
The latest commit seems to have broken the "View more" button on profiles.

We're aware, working to fix.

Seems to be fixed. GJ guys.


CIGAR alignment length changed for sequence "*"

A SAM sequence of "*" with a CIGAR aliginment of 10M gets the alignment converted to 0M after passing through cramtools 3.0 (2.1 blows up).  Additionally it computes the checksum differently to htslib, but it is unclear which is incorrect.  In part parts:
Part 1)   Using htslib/test/c1#noseq.sam
jkb@seq3a[htslib/test] /software/bin/java -Xmx4000m -jar /nfs/users/nfs_j/jkb/work/cram/cramtools/cramtools-3.0.jar cram -R c1.fa -I c1#noseq.sam -O _tmp.cram -n -Q --capture-all-tags
jkb@seq3a[htslib/test] /software/bin/java -Xmx4000m -jar /nfs/users/nfs_j/jkb/work/cram/cramtools/cramtools-3.0.jar bam -R c1.fa -I _tmp.cram -O _tmp.sam
jkb@seq3a[htslib/test] grep -n SQ1 c1#noseq.sam _tmp.sam
c1#noseq.sam:4:SQ1      0       c1      1       0       10M     *       0       0       *       *  MD:Z:10  NM:i:0
_tmp.sam:7:SQ1  0       c1      1       0       0M      *       0       0       *       *

It appears to be because it's stored read length 0 in the file, which is the length of the BAM sequence, but not the length that is needed in order to reconstruct the CIGAR string.  Cram_dump shows:
Rec 3/9 at 1,3
BF = 0 => SAM 0x0 (ret 0, out_sz 1)
CF = 10 (ret 0, out_sz 1)
RL = 0 (ret 0, out_sz 1)
AP = 0 (ret 0, out_sz 1)
RG = -1 (ret 0, out_sz 1)
RN = SQ1 (ret 0, out_sz 3)
Detached
MF = 0 (ret 0, out_sz 1)
NS = -1 (ret 0, out_sz 1)
NP = 0 (ret 0, out_sz 1)
TS = 0 (ret 0, out_sz 1)
TL = 0 (ret 0, out_sz 1)
FN = 0 (ret 0, out_sz 1)
MQ = 0 (ret 0, out_sz 1)
If I create the cram file using htslib then Cramtools can decode it and get the 10M back again.  Cram_dump shows the difference:
Rec 3/9 at 1,3
BF = 0 => SAM 0x0 (ret 0, out_sz 1)
CF = 11 (ret 0, out_sz 1)
RL = 10 (ret 0, out_sz 1)
AP = 0 (ret 0, out_sz 1)
RG = -1 (ret 0, out_sz 1)
RN = SQ1 (ret 0, out_sz 3)
Detached
MF = 0 (ret 0, out_sz 1)
NS = -1 (ret 0, out_sz 1)
NP = 0 (ret 0, out_sz 1)
TS = 0 (ret 0, out_sz 1)
TL = 1 (ret 0, out_sz 1)
0: TN= MDZ
id=5063770
0: Val 31 30 00
1: TN= NMC
id=5131587
1: Val 00
FN = 0 (ret 0, out_sz 1)
MQ = 0 (ret 0, out_sz 1)
QS =            (ret 0, out_sz 10)
Note here it has also stored the MD:Z: and NM:i tag verbatim as it cannot be sure that they would be recreated correctly during decoding as it has no sequence to work from.
Part 2)
Decoding the above htslib generated file, cramtools-3.0.jar gives me an error regarding the sequence checksums:
jkb@seq3a[htslib/test] /software/bin/java -Xmx4000m -jar /nfs/users/nfs_j/jkb/work/cram/cramtools/cramtools-3.0.jar bam -R c1.fa -I _tmp.cram -O _tmp.sam
ERROR   2015-04-16 15:07:16     ContentDigests  Content hash mismatch for tag SD, actual: 06607F2A; expected: 8244A410
The actual sequence shown doesn't seem to differ between the input and output files:
jkb@seq3a[htslib/test] cat c1#noseq.sam _tmp.sam
@SQ     SN:c1   LN:10
sq1     0       c1      1       0       10M     *       0       0       AACCGCGGTT      ********** MD:Z:10  NM:i:0
sQ1     0       c1      1       0       10M     *       0       0       AACCGCGGTT      *       MD:Z:10     NM:i:0
SQ1     0       c1      1       0       10M     *       0       0       *       *       MD:Z:10 NM:i:0
sq2     0       c1      1       0       4M1D5M  *       0       0       AACCCGGTT       *********  MD:Z:4^G5        NM:i:1
sQ2     0       c1      1       0       4M1D5M  *       0       0       AACCCGGTT       *       MD:Z:4^G5   NM:i:1
SQ2     0       c1      1       0       4M1D5M  *       0       0       *       *       MD:Z:4^G5  NM:i:1
sq3     4       c1      1       0       *       *       0       0       AACCCGGTT       *********
sQ3     4       c1      1       0       *       *       0       0       AACCCGGTT       *
SQ3     4       c1      1       0       *       *       0       0       *       *
@HD     VN:1.4  SO:unsorted
@SQ     SN:c1   LN:10   UR:/nfs/users/nfs_j/jkb/work/samtools_master/htslib/test/c1.fa  M5:e224bd8a70e5466c6a033be886045c85
@PG     ID:0    PN:cramtools    VN:3.0-b12      CL:java /nfs/users/nfs_j/jkb/work/cram/cramtools/cramtools-3.0.jar bam -R c1.fa -I _tmp.cram -O _tmp.sam
sq1     0       c1      1       0       10M     *       0       0       AACCGCGGTT      **********
sQ1     0       c1      1       0       10M     *       0       0       AACCGCGGTT      *
SQ1     0       c1      1       0       10M     *       0       0       *       *       MD:Z:10 NM:i:0
sq2     0       c1      1       0       4M1D5M  *       0       0       AACCCGGTT       *********
sQ2     0       c1      1       0       4M1D5M  *       0       0       AACCCGGTT       *
SQ2     0       c1      1       0       4M1D5M  *       0       0       *       *       MD:Z:4^G5  NM:i:1
sq3     4       c1      1       0       *       *       0       0       AACCCGGTT       *********
sQ3     4       c1      1       0       *       *       0       0       AACCCGGTT       *
SQ3     4       c1      1       0       *       *       0       0       *       *

Oops, SD is score digest, so it's the quality values not the sequences that claim to differ.

Checking how my code computes this, the above cigar/seq/quality strings are:
10M AACCGCGGTT **********  => checksum ********** (actually "\t" x10 as "*" is Q9)
10M AACCGCGGTT * => checksum <255>x10 (unknown quality is encoded as 255 in BAM format)
10M * * => checksum "" (empty string)
Basically it's checksumming what would be in the BAM file.  For seq "AAC" and quality "*" BAM will store both as length 3 with the quality being <255><255><255>, but for seq * quality * BAM will store both as 0 length.
We need to be explicit in the documentation on this, and agree (obviously!).  How is Cramtools counting quality bases for computing the checksums?

I THINK I fixed it: 8adb5f3df344a906a6fdd5f0c611959af2c857eb

Seems to work, so closing it.


feat: track progress for SourceBackfill

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#18368  👈
#18342 : 1 other dependent PR (#18112 )
#18297
#18296
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on  Graphite


add asm aarch64

Adding a language

[ ] The code displays "Hello World"
[ ] I have updated the readme to include the new language
[ ] I have incremented the language count in the readme

Needs to be “## Languages (812)”

Done


Unable to locate Javascript steps generated from building Typescript files

👓 What did you see?
I am using the VSCode Cucumber plugin within a Typescript project that imports common shared steps from a Typescript npm module that is packaged as Javascript.
The plugin is able to successfully locate step definitions in Typescript from the local src code, but it fails to locate the shared Javascript steps from the dependency.  This seems to be due to the regular expression for matching Javascript step definitions not working for Javascript files that were transpiled down from Typescript.  Here's an example of what one of my steps looks like after it has been built into Javascript:
const cucumber_1 = require("@cucumber/cucumber");
(0, cucumber_1.Given)(/^I login$/, function () {
    return __awaiter(this, void 0, void 0, function* () {
        yield this.login();
    });
});

This seemed like it could be fixed by overriding TSX's defineStepDefinitionQueries value in the Javascript implementation to look for Given|When|Then|Given)|When)|Then) however I get Invalid regular expression: Unmatched ')' errors when testing with it even if I try to escape the parentheses.  I wasn't really sure what else to try in this case.
Any help would be greatly appreciated!
✅ What did you expect to see?
Expected the plugin to find the Javascript steps.
📦 Which tool/library version are you using?

Cucumber VSCode plugin: v1.8.1
Node: v18.17.1
Typescript: v5.3.3
Cucumber: v9.6.0

🔬 How could we reproduce it?
Steps to reproduce the behavior:

Create a JS file with the following data:

"use strict";
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
    return new (P || (P = Promise))(function (resolve, reject) {
        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
        step((generator = generator.apply(thisArg, _arguments || [])).next());
    });
};
Object.defineProperty(exports, "__esModule", { value: true });
const cucumber_1 = require("@cucumber/cucumber");
(0, cucumber_1.Given)(/^I login$/, function () {
    return __awaiter(this, void 0, void 0, function* () {
        yield this.login();
    });
});

Check the Cucumber Language Server output to see if it picks up the new step

📚 Any additional context?

This text was originally generated from a template, then edited by hand. You can modify the template here.

I was having the same problem.
This PR seems to fix it for my projects:
https://github.com/cucumber/language-service/pull/186/files

I was having the same problem.
This PR seems to fix it for my projects:
https://github.com/cucumber/language-service/pull/186/files

This is unrelated to the original issue - it only deals with stripping out js/ts class decorators
I have done the actual fix in PR #222, adding a second javascript tree-sitter query to match compiled js step formats


validationParameters.ValidIssuer: 'http://localhost:8000/' or validationParameters.ValidIssuers: 'null'.

its me again . when I change run casdoor at prod , I could run the consoleApp to get token and some info , but one new error was exposed , it said the issuer is nor match or null , I cant understand I already got the issuer url why it tlod me wrong ? what I got is :

@wuxiao-ling197 I tested this repo (https://github.com/casdoor/casdoor-dotnet-sdk-example) and it runs well. If you have changed the code and make it crash, make sure to restore the code

Make sure all settings and the cert public key and private key are correct


Rename variable after rename file

About:

Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

Steps to Reproduce:

I change the name of my file: Browser.ts to browser.ts (Use F2 key to change)
I tried to change the name of one variable in browser.ts but VS code open new tab named: Browser.ts and change the name of my variable in Browser.ts

Does this issue occur when all extensions are disabled?: Yes

Same root cause as #55655


Period at start of line not escaped

Describe the bug
The following is what I think is going on; I don't know of a good way to tell what swoosh is sending without setting up another SMTP server without encryption. I'm going off of the final resulting email in my inbox.
Periods at the start of a line are not escaped, and they end up being deleted by the email server.
I initially tried fixing this in elixir-mail to mimic other email clients, but it's technically allowed, it just needs to be escaped by the SMTP client.
Steps to Reproduce the Bug or Issue
Send an email in which a period is just over the line length limit so it gets wrapped to the next line.
Expected behavior
The period should be replaced with two periods.
Your reproducible example
No response
Screenshots or Videos
No response
Platform

OTP: 27
Elixir: 1.17.3

Additional context
No response

I just realized that this is more likely a bug in https://github.com/ruslandoga/mua. Feel free to close if you concur.

ping @ruslandoga
;)

👋
Thank you for the ping @princemaple!
Here's what Mua sends for each message: https://github.com/ruslandoga/mua/blob/cf4c45c28939d177cfae9d81e9a21299a0574117/lib/mua.ex#L412-L427
I think it's encoder's (in our case, Mail's) responsibility to escape special characters.
cc @andrewtimberlake

This would cause the issue
Message-ID: <1234567890@localhost>
Date: Fri, 30 Sep 2016 12:02:00 +0200
From: me@localhost
To: you@localhost
Subject: Test message

This is a test message
. with a dot
in a line

It should end on the other side with the . intact.

Thank you! I'll add it to the test suite in Mua.

@chuckwagoncomputing I pushed a temp fix to https://github.com/ruslandoga/mua/pull/66
You can use it with
defp deps do
  [
     # ...
     {:mua, github: "ruslandoga/escape_leading_dot"}
     # ...
  ]
end

I'll work on a proper fix once I have more time. Thank you for the report!

@andrewtimberlake thank you for the test case again!
I wonder if this period-escaping can be done in Mail or if you are categorically against it? :)

I can confirm it is now working in the case that originally failed, thank you very much @ruslandoga.
For posterity, I had to use {:mua, github: "ruslandoga/mua", branch: "escape_leading_dot", override: "true"}
I would argue that for maximum robustness, it should be fixed in both places. Yes, not encoding it in mail is spec-compliant, but so is encoding it.

@andrewtimberlake thank you for the test case again!
I wonder if this period-escaping can be done in Mail or if you are categorically against it? :)

@chuckwagoncomputing Period escaping at the RFC2822 level would not be spec-compliant.
Dot-stuffing is specifically about transmission of the mail, not encoding or decoding, which mail is concerned with.
If we did it at the mail level, then we would produce an encoded email with two periods at the beginning of some lines. A spec-compliant SMTP server would then make it three dots during transmission and it would be reverted back to two dots on the other side, where another parser would not expect to then, again, remove the leading dots.

I see. Thank you for the explanation!

Encoding it with .. in mail would not be spec-compliant, but encoding it with =2E like other clients do would be.


Missing license

I'd like to use stats.py and plot.py in a demonstration project. Would it be possible to add a license file to this project?
Thanks!

Checking back one more time to see if you could add a license to your project that it suitable for using in an open source demonstration project.
Thanks

MIT license added. Thank you.


React to ANCM requestTimeout change for 2.1

Fixes #5264
Internal Review Topic
In the <=2.0 and >=2.1 rendered table content, you only need to look at the requestTimeout row Description column content.

@Rick-Anderson Try it now (that didn't throw a build error) ... Internal Review Topic
WRT it not showing for 2.0 before ... rookie first-timer mistake. I know why it was broken; so if we end up going back to my original two-table approach, it should work.

@guardrex  breaks table rendering. I think I'll squash/merge and open a bug.

@guardrex  can you move he requestTimeout row to the bottom of the table? You could have a he requestTimeout row that said, see the requestTimeout row at the bottom of the table.

@guardrex  I think it's OK that it breaks the table rendering for now - especially if you move it to the bottom of the table.

I'd prefer not to do it based on aesthetics. Why not just two tables (I fixed the earlier 2.0 problem)? Internal Review Topic

I'm thinking they can fix the bug fairly quickly. If not, use 2 tables.

... also my table is alphabetical. It would upset the world order ... Earth may fly off it's axis into the Sun!
I wouldn't want the deaths of billions of humans on my hands. :grinning:

I reverted it ... see if it works now.


Not working with XCode 15.3 and Command Line Tools 15.3 (15E204a)

Thanks @Luckfried  - we likely need to upgrade the tvOS version. Are the other targets (iOS, MacOS) building correctly?

Update. XCode 15.2 works with the following library version.
OPENSSL="3.0.12"        # https://www.openssl.org/source/
LIBCURL="8.5.0"         # https://curl.haxx.se/download.html
NGHTTP2="1.58.0"        # https://nghttp2.org/

I'm upgrafing to XCode 15.3 to see what causes the break. I suspect we may need to change the min SDK versions.

The error that is generated with XCode 15.3:
crypto/ui/ui_openssl.c:273:17: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
static volatile intr_signal;
~~~~~~~~~~~~~~~ ^
int
1 error generated.

Fix required adding int to declaration. I don't know why it wouldn't be there already and why it only impacts tvOS.  A quick sed added to tvOS build:
# Starting with XCode 15.3
LANG=C sed -i -- 's/static volatile intr_signal/static volatile int intr_signal;/' "./crypto/ui/ui_openssl.c"

I discovered a second issue with latest cURL library (8.6.0) that now requires the libpsl library which is not available by default. We have not included this in prior version so I'm using the --without-libpsl for now while I figure out an easy way to get a static cross-compile of the library.
Now working with latest:
curl/8.6.0 libcurl/8.6.0 OpenSSL/3.0.13 zlib/1.2.12 nghttp2/1.60.0


fix(data): align metadata with dataset paths

Manual fix for https://github.com/owid/etl/issues/793. It's likely we'll solve this in a different more automatic way.

covid dataset changed short name from covid19 to covid and version from today's date to latest to match dataset path (we still have data_accessed from source if anyone wants to check the date of latest update)
grapher datasets that changed short_name to match their path will have to be updated in production DB

Datadiff looks ok. It's gonna change metadata in our data catalog, but I don't think anyone would notice. We definitely have to change grapher short names in both production and staging. I can't think of anything other than that.


Bugs & Improvements

You could add a visibility check for AimBot, or an option with Lock Aim Trough walls
You could make the ESP render only when Counter Strike 2 is foreground
You could render the Menu only when Counter-Strike is foreground so that you don't have the menu in all windows (not professional) and there should be a button in ConfigMenu.hpp (or it can be hardcoded too) when the button is pressed, the menu should hide.
The HealtBar could be improved and look much better old school and be vertical, it's super weird to be horizontal.
(OPTIONAL) you could add a silent aim, if it's possible, I haven't really seen external silent aim, but as far as I know it's possible via packets

my visibility check has imperfections, so it will be added after fixing.
i has updated the key to hide or show menu,and added a combo to choose HealthBar Type, like horizontal and vertical.


⚠ Bofrost.de has degraded performance

In 7fe1be8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1241 ms

Resolved: Bofrost.de performance has improved in 3d1afc7 after 8 minutes.


bump ACLAP.DownloadHelperCoApp to 2.0.19

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Possible duplicate of #147461 (but different package name)

Adresses https://github.com/microsoft/winget-pkgs/issues/147477

Possible duplicate of #147461 (but different package name)

Same hash E1AF498F95432A4F2F666A8CBEC7BD6AB9DEB4D1695C6E7CDE7ACB9BD408E600 in

#147461

These PackageIdentifiers should be merged. Thanks for catching this.


Channel override: Ciensación

Channel ID: hodug-hajam
Styling:

[ ] Custom primary color? Default: #016A7F
[ ] Custom secondary color? Default: #016A7F
[ ] Custom thumbnail? Provide JPEG file for the channel card
[ ] Custom icon? Provide PNG that will replace the channel icon uploaded at Kolibri Studio
https://www.dropbox.com/sh/ba7z954fdd1k83y/AACTF6xKKjkSE6BlibnFmnEKa?dl=0

It passes in Narwhal v7.11.0 in spanish pack


Generating Channel Logo when no logo is provided

Using SkiaSharp and Sen font, generating on-the-fly a PNG including the name of the channel (text query param) with etv logo for the channel list and the XMLTV file

Awesome idea, I like it!
Thanks :)

Initially this didn't work for me without adding the SkiaSharp.NativeAssets.Linux package, so we probably want to include that as well.
I will update this too so :)

In cases where the image generation fails (for that reason or other reasons), maybe we could still default to the etv 500 png?
How can we do that without a big try/catch block?


Manage network dns settings properly

This change enables the creation and management of DNS settings through
terraform.
There are still some serious issues with how this is tested, and there
may be unseen problems here. A separate issue should be created to
manage this problem.
Signed-off-by: Erik Hollensbe<EMAIL_ADDRESS>

@someara please test this manually before performing any merge. I am a little worried more work needs to be done here, but I have a less comprehensive way to test it than you do.

@craSH my apologies for taking so much time to get back to you on this. I'll make a note to revise the readme with any additional documentation that needs to occur.


Fix Getting started instruction

Hi guys! I've just tried your new release from branch develop and have some concerns:

In getting started is better to mention that there is possible took release version and not to build yourself.
During the building there is two missing steps in instruction: install grunt-contrib-concat and grunt-contrib-cssmin. Without them isn't working.
Very hard to understand what is necessary to generate the .tsv file, how to use the python script. It isn't mentioned that files has to be placed locally on your computer, not in Yandex.disk. Also not mentioned how to get proper .json file.

Hi, @mihbort. Thank you for your feedback!
Note that the latest version of the system can be found in the develop-toloka branch, and not in the "develop" branch, which is mentioned in the README file.

In getting started is better to mention that there is possible took release version and not to build yourself.

It is actually mentioned in the note after step 7 on the getting started wiki page.

During the building there is two missing steps in instruction: install grunt-contrib-concat and grunt-contrib-cssmin. Without them isn't working.

Thank you, once again. We will check out if npm install grunt-contrib-concat should be added to the instruction.
As for the grunt-contrib-cssmin, it is mentioned as a prerequisite both in the README file, and on the Generating source files for YandexToloka wiki page.

Very hard to understand what is necessary to generate the .tsv file, how to use the python script. It isn't mentioned that files has to be placed locally on your computer, not in Yandex.disk. Also not mentioned how to get proper .json file.

We'll take that into account and will try to reduce possible ambiguities. Although, it is mentioned in the Generating a TSV instruction that path to files is a "relative path to the folder that you uploaded to Yandex.Toloka", which implies that it is stored on your machine.
As for the json, it's structure is described on the Classes and parameters JSON description wiki page.

It is actually mentioned in the note after step 7 on the getting started wiki page.

Please, swap these two Notes. It is likely that person would start doing the first one and only after that reads the second.

"relative path to the folder that you uploaded to Yandex.Toloka"

This part can be formulated the following way: "path to folder on your local machine that you uploaded to Yandex.Toloka. It is needed to specify all it's content in .tsv file"
It may be worth to split generating in more steps.

As for the json, it's structure is described on the Classes and parameters JSON description wiki page.

Add link to this document from Generating instruction.

Hi, thanks for the feedback!

It isn't mentioned that files has to be placed locally on your computer, not in Yandex.disk

In one of the previous steps in the tutorial, you were asked to upload local data files to a specific folder on Yandex.Disk. This implies having a local copy of the files on a computer that you use to generate .tsv, but I agree that it might not be straightforward so we will add it to the docs.

This part can be formulated the following way: "path to folder on your local machine that you uploaded to Yandex.Toloka. It is needed to specify all it's content in .tsv file"

I agree, this is a better way to formulate this.

@mihbort, thank you for your suggestions!

Please, swap these two Notes. It is likely that person would start doing the first one and only after that reads the second.

I have swapped and reformulated the notes a little. At the moment, the "easier" way to get source files for Yandex.Toloka, from releases page, goes first.

Add link to this document from Generating instruction.

I have added a link to the "Classes and parameters JSON description" wiki page to the Generating a TSV guide.

@AlNedorezov @ruslanmustafin

I agree that it might not be straightforward so we will add it to the docs.

Just add it and I close the issue, the rest of the file is good.

@mihbort

Just add it and I close the issue, the rest of the file is good.

I have noted in the Generating a TSV guide, that a path shoud point to the folder on the local machine, and that all of the stated folders content will be specified in a generated .tsv file

All right

Also, what about to delete develop branch? It hasn't been updated for 3 months straight and could confuse newcomers.

Also, talking about branches - why we don't update master with the latest release? Version 1.4 was released 3 days ago while latest commit in master was 21 days ago.

@nmingazov

Also, what about to delete develop branch? It hasn't been updated for 3 months straight and could confuse newcomers.

I have deleted develop branch, as it, indeed, served no purpose, and may have confused newcomers.

Also, talking about branches - why we don't update master with the latest release? Version 1.4 was released 3 days ago while latest commit in master was 21 days ago.

We didn't update master branch with the new release, since we are still working on reducing the technical debt introduced by the new changes. However, I have made a decision to publish a release which contains delayed acceptance, since this feature was requested ASAP, and it's straightforward functionality was tested.
We plan to update master in the few days.

Great, glad that you didn't forget about it :)
Thanks for the speed and ability to adapt though, because the tool is almost ready to serve it purpose. Great job, team!


add Clipboard component for ios and android

add Clipboard component for ios and android
   import Clipboard from 'react-native'

   Clipboard.get((content)=>{
         console.log('here is content in clipboard:%s',content)
   });
   var content = 'here is a string';
   Clipboard.set(content);

Hey. Thanks for working on this.
There is already a Pasteboard component for iOS - https://github.com/facebook/react-native/blob/master/React/Modules/RCTPasteboard.m
For Android, you might want to follow the same API.

cc @dmmiller in case an Android version of Pasteboard is in the works.

@satya164 I know it, but you don't provide js interface. And the version of iOS has not "get" method

@TanTan-TT Yes, but it's called Pasteboard and not Clipboard.  And the method is probably called setString. We shouldn't change the whole API.

@satya164 I change the API
import Pasteboard from 'react-native'

Pasteboard.getString((content)=>{
      console.log('here is content in pasteboard:%s',content)
});
var content = 'here is a string';
Pasteboard.setString(content);

Let's wait for @dmmiller

There's already the iOS Pasteboard module. Why are you adding Libraries/Components/Pasteboard/Pasteboard.ios.js?

Agree with @dmmiller. We're trying to unify iOS and Android APIs as much as possible, and I don't see a good reason to name these differently.
The iOS Pasteboard module is pretty new, and doesn't have a JS wrapper yet, so I'm cool with calling the JS file "Clipboard.js" if people think that's a better name - I can rename the iOS native module later.
As for the missing get method on iOS, just mark that API as Android-only for now and we can add iOS support later.

Clipboard is a more common term I think: https://www.google.com/trends/explore#q=clipboard%2C pasteboard&cmpt=q&tz=Etc%2FGMT%2B8

Yeah, Clipboard is a better name in my opinion too.

@dmmiller sorry, I don't understand your solution, do you mean if There isn't a js wrapper for pasteboard, directly use methods exported from RTCPasteboard?
But in my opinion, if do this, users must import NativeModule instead of react-native?
And I think in Java world RTCPasteboard is a strange class name

@ide @satya164 maybe I could change name of js wrapper to "Clipboard ", then users can import it from "react-native"

@TanTan-TT that sounds like a good approach. Name the JS file and the android class "Clipboard", leave the iOS class as Pasteboard in iOS and in Clipboard.js file do something like:
var RCTClipboard = NativeModules.Clipboard || NativeModules.Pasteboard;

There's no need to add a Pasteboard.ios.js or anything like that.

We do have a pasteboard module internally and plan to open source it:
https://gist.github.com/mkonicek/4556908b269919e1bd31
Please base your code on that.
I agree with others that Clipboard is a much better name both for Android and iOS. Please replace all the occurrences to "pasteboard" you can find, including string constants, Java class and package names, etc.

I am out of the office until 12/06/2015.
For any issues, plz ask Jinhao.Geng for help.
Note: This is an automated response to your message  "Re: [react-native]
add Clipboard component for ios and android (#4384)" sent on 12/3/2015
7:10:21 AM.
This is the only notification you will receive while this person is away.

@mkonicek OK, I will deal with it. But I still have a suggestion about js wrapper file.
Based on v0.16's pasteboard,  users must use this module like this
var pasteboard  = require('NativeModules').pasteboard;

But for other API, code is like
import {ToastAndroid} from 'react-native'

I think above code is more formal than require('NativeModule'), which is like an internal API.

Yeah, I agree that requiring the mdule should be consistent with other things like ToastAndroid.

@mkonicek I have pulled request the newest version(include adding a demo in UIExplore) and I have passed the test both in iOS and Android UIExplore.
But Travis CI told me there are some errors,
Examples/UIExplorer/ClipboardExample.js:20
 20:    Clipboard,
        ^^^^^^^^^ property `Clipboard`. Property not found in
 23:  } = React;
          ^^^^^ Object.create

But indeed it works. I don't know how to handle these errors, and I believe some errors doesn't caused by my code.  But still you can review codes.
Thank you.

Sorry for bringing up yet another thing in the already long opened PR, but do we really want the method names to be Clipboard.getClipboardString and Clipboard.setClipboardString? Personally, I prefer Clipboard.getString and Clipboard.setString, no need for the extra Clipboard.

@satya164 In js API, it indeed is no "Clipboard"

@TanTan-TT Is there any reason it's different in Native?

If we change the Native methods to setString and getString, we can greatly simplify the Clipboard.js file,
module.exports = require('NativeModules').Clipboard;

@satya164 both ios and Android?

@TanTan-TT Yeah :)

@satya164 Fix it!

@facebook-github-bot shipit

@nicklockwood thx

Merging this. I ended up tweaking the Java code a bit.

Looking at the API again, I really think getString should provide an error callback, rather than failing silently if it didn't work. Can you send a separate PR for that once this lands?

@mkonicek OK. Got it.

Can someone make a doc for this please? Thanks!

@sunnylqm I can write, but I don't know how to write this in this WebSite. @satya164 Can you guide me to write a document for Clipboard?

They seems to put doc in a certain format in the component source, like javadoc.

@sunnylqm I know it. But in this scenario, there is not js file and no place for jsdoc.

@TanTan-TT You can write the APIs inside the JS file. We'll need to do that for backward compatibility anyways.


renaming hashFunction

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Rename hashFunction to verificationFunction
Rename hash to verificationData
Rename some function names for consistency
Rename some variables names for consistency
Rename some constants for consistency

What is the current behaviour (you can also link to an open issue here)?
What is the new behaviour (if this is a feature change)?
same behaviour, different variable names
Other information:

Codecov Report

Merging #333 (035591e) into develop (122efa9) will increase coverage by 0.85%.
Report is 84 commits behind head on develop.
The diff coverage is 90.24%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
+ Coverage    83.04%   83.89%   +0.85%
===========================================
  Files           18       18
  Lines          979     1124     +145
  Branches       218      252      +34
===========================================
+ Hits           813      943     +130
- Misses          91       97       +6
- Partials        75       84       +9

Files
Coverage Δ

src/constants/constants.ts
100.00% <100.00%> (ø)

src/constants/interfaces.ts
100.00% <100.00%> (ø)

src/index.ts
77.22% <100.00%> (+0.22%)
:arrow_up:

src/lib/detector.ts
96.00% <100.00%> (+8.50%)
:arrow_up:

src/lib/getData.ts
89.79% <ø> (ø)

src/lib/getDataFromExternalSources.ts
63.33% <ø> (-1.19%)
:arrow_down:

src/lib/provider-wrapper-utils.ts
88.88% <ø> (-0.59%)
:arrow_down:

src/schemas/index.ts
100.00% <100.00%> (ø)

src/types/Method.ts
100.00% <100.00%> (ø)

src/lib/decodeMappingKey.ts
84.21% <60.00%> (-5.54%)
:arrow_down:

... and 4 more

... and 3 files with indirect coverage changes


How to set click menu reload the page with next/router

Code:
import Router from 'next/router'
import { Scrollbars } from 'react-custom-scrollbars'

export default class ChildrenMenus extends React.Component {
    render() {
        return (
            <div style={{flex:1}}>
                <Scrollbars>
                <List>
                    { this.props.menus.map((item,_index)=>{
                        let _st={}
                        if(_index==this.props.selected){
                            _st.style={
                                backgroundColor: "rgba(0, 0, 0, 0.2)"
                            }
                        }
                        _st.onTouchTap=()=>{
                            Router.push(item.href)
                        }
                        return <ListItem key={_index} primaryText={item.text[this.props.local]} {..._st}/>
                    }) }
                </List>
                </Scrollbars>
            </div>
        )
    }
}

when I visit /system/home, it get the home page correctly. But I have many content in the home page, including table with page and charts and so on. I want to click home page menu to reload this page, and I tried add timestamp query like ?t=timestamp to the url , but not worked. So what shall I do?

Based on your description I can't follow what you want to do. If you want to force page reloads just use window.location.href = url.
Please follow the issue template 🙏

Location.href will reload all page resource. I has two leval menu, and each menu has one page. But some pages I have the 'inner page', this 'inner page' just by state coding, they not really a page. No matter it is outer page or inner page, they are from the same route, just by different state. When I was in inner page, and want to back outer page, I just want to click the menu for that. But they are same route, I still in inner page.


Set the endpoint of runners

I want to send a request to the url obtained in the previous step, but runners do not allow setting variables and the following error is reported.

failed to run /books/jobs/xxx/xxx.yml: http request failed on 'xxxxxxxxx'.steps.xxxxxxxxxx: Get "%7B%7B%20previous.res.body.xxxxxxxx%5B0%5D%20%7D%7D": unsupported protocol scheme ""

The runners are set as follows.
desc: xxxxxxxx
if: included
runners:
  myapi:
    endpoint: "{{ previous.res.body.xxxxxx[0] }}"
steps:
  xxxxxxxx:
    myapi:
      /:
        get:
          headers:
            Cookie: xxxxxxxxx
    test: |
      vars.skip_test == true || current.res.status == 200

What should I do if I want to use the url obtained from the previous step?

@beexli Thank you for your report!
There is no solution at this time.
However, we think this was an issue that needed to be resolved.
I will try to resolve this soon.

Allows use of parent runbook values.
https://github.com/k1LoW/runn/blob/749e2efbe6e0ce7b555aef8b26cdee4a29cf37fa/testdata/book/use_parent_store_runners.yml#L4


Accessibility audit changes

Context
The content within the tech docs has been audited to ensure it complies with accessibility regulation before the 22 September 2020 deadline.
Changes proposed in this pull request

Removed inaccessible language like whitelist and blacklist and replaced with "allow list" and "block list"
Split up long paragraphs
Ensured all diagrams and images has alt text or content in surrounding text explaining them

Guidance to review
Check that content and structure makes sense.

Jira ticket: https://payments-platform.atlassian.net/browse/PP-6785


fix(facenet): set face confidence correctly

Thanks for this project!
I was playing with it and I noticed the confidence isn't passed correctly. There was a bug where it would try to get the value from the square box, instead of the original bounding box which contains the confidence.

Good catch!
You are welcome and thank you for the patch.


PlanHub Tags

Tags that are coded into PlanHub but not DaltonTab still appear as "tag not defined" pinkish color...
Example: Prez
CSS Hexing?

@RobotXLabs we could just add them in, but it would be nice if it could get the latest tags somehow. Maybe including utils.js? Hmm...

This was actually fixed a while ago, in 81dd1e4.


How to add edit filter link to grid like in Northwind

Hello, I am stumped trying to add a filter to the bottom of the grid for some of my entities like the one that is on the Northwind/Product and Northwind/Customer grids, whereby a user can select which filters and conditions to apply to the grid. I looked in the Web and Script projects, at the Row and Grid classes, and even searched the Serene repository to find out where I might be missing the code to include the filter in the grid but can't find it. I'm missing something somewhere. Thank you for your help!

Nevermind, I apologize. I just realized that if I add a Filterable attribute to Grid.cs class it will add the filter bar and filterpanel.


Should batch processor emit the batch on AsyncClose()?

Calling Stop() on the stream will try to drain the pipeline - but if you use a batch processor type, it could be holding messages that cannot be flushed, as no message coming into the batch will trigger {time, messages, messagesize} limits.
If there was a way that the batch could emit its held message without having a input message trigger that send - the CloseAsync() call could force the batch the emit its messages. Also, the time based emit could take advantage of this as well, and emit asynchronously.
Similarly, being able to specifically Noack the previously Unack'd messages on shutdown would also help my case of my input source only redelivering messages that have not been acked after a time expiry (gcp_pubsub).

Hey @iluminae, I'm trying to gradually migrate towards batches configured at the input layer (https://docs.benthos.dev/inputs/#kafka_balanced max_batch_count for example) as it avoids this issue entirely. The problem with a batch processor is that if we emit messages asynchronously then we have no mechanism for propagating the acknowledgements back to the input layer.
We could probably do the noack for unacked messages on shutdown though and that sounds like a good suggestion to me. I'll need to think through the implications but we can implement this on an input by input basis.
I can take a look at adding a max_batch_count field for the gcp_pub_sub input for you as that should solve your problems with unacks, would that work for you?

@Jeffail in general I like your direction with that - although the settings of {time, size, #messages} seems more flexible than just max_batch_count available in eg: kafka_balanced.
I wonder if there is a pattern we can develop that integrates a common interface for attaching this batching functionality to inputs? Like attaching a buffer to a input as a child in a way that the input can use the buffer like we want, but the buffer can be pluggable and configurable?

We possibly could but the implementation needs to sit within the input implementation itself otherwise we hit similar problems.
I think for now having max_batch_count on inputs as well as the option for the batch processor covers most use cases. If you need the throughput of batches but also need flushed messages on shutdown then use max_batch_count, if you need granular batch controls like timing and can live with unacks use batch.

@iluminae, I've added the field max_batch_count to the gcp_pubsub input, that gives you a batching option that always results in flushed messages. Batching is always going to be a work in progress but I'm closing this issue for now, feel free to reopen if you have questions or problems with the new field.

Hey @iluminae, just as a follow up, I've refactored batching in Benthos in v3.3.0, it's now much more flexible (for all inputs): https://docs.benthos.dev/batching/


Added Delay Calculator (Calculating the order of reaching of packets)

Issue Id you have worked upon - #412
Briefly explain your program logic -
made Delay Calculator (Calculating the order of reaching of packets)
used the reference (p8-2) first page
https://www.studocu.com/in/document/vellore-institute-of-technology/embedded-system-design/disc-ch-8/51295883
Delay for First datagram:    3200 𝐾𝑚2∗108  𝑚/𝑠 + (3 + 20 + 20) = 59.0 ms
formula => delay of datagram = (pathlength/speed of light) * sum of delay of visited switches)
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @nipun221 on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐

@nipun221,
Amazing work. 👏


Groceries example of NativeScript tutorial - Failed “tns run ios” command

From @drdavidtaylor on February 6, 2017 22:40
Dear, Community of NativeScript!
I'm starting to learn NativeScript with NativeScript TypeScript and Angular getting started guide.

I cloned the repository from: https://github.com/NativeScript/sample-Groceries.git
My branch is master
I opened the project with IntelliJ IDEA
tns run ios
it should be successfull ... but i got this: UIImage.tns_safeImageNamed is not a function

CONSOLE ERROR file:///app/tns_modules/nativescript-angular/zone-js/dist/zone-nativescript.js:344:22: Error: Uncaught (in promise): Error: Error in login/login.component.html:10:4 caused by: UIImage.tns_safeImageNamed is not a function. (In 'UIImage.tns_safeImageNamed(name)', 'UIImage.tns_safeImageNamed' is undefined)

I tried on MacOS Sierra (10.12.3) with IntelliJ IDEA.
Python version 2.7.10
Xcode 8.2.1
ruby-2.3.3
npm 4.0.5
bower 1.8.0
CLI:  2.4.2
package.json:

tns-core-modules 2.5.0
"tns-ios": version": "2.5.0"
"dependencies": {
"@angular/common": "2.4.3",
"@angular/compiler": "2.4.3",
"@angular/core": "2.4.3",
"@angular/forms": "2.4.3",
"@angular/http": "2.4.3",
"@angular/platform-browser": "2.4.3",
"@angular/platform-browser-dynamic": "2.4.3",
"@angular/router": "3.4.3",
"nativescript-angular": "1.4.0",
"nativescript-theme-core": "^1.0.2",
"reflect-metadata": "~0.1.8",
"rxjs": "~5.0.1",
"tns-core-modules": "2.5.0"
},
"devDependencies": {
"nativescript-dev-android-snapshot": "^0..",
"nativescript-dev-typescript": "^0.3.5",
"sass": "^0.5.0",
"typescript": "~2.1.0",
"zone.js": "~0.7.2"
}

Could you give me any advice please? I tried everything ... I think.
Best regards,
David
Copied from original issue: NativeScript/NativeScript#3594

From @tsonevn on February 7, 2017 6:37
Hi @drdavidtaylor,
I tested your case, however, was unable to reproduce problems with building sample-Groceries with latest NativeScript 2.5
Could you update your node to latest LTS version 6.9.5 and your NativeScirpt to 2.5, while following the instructions here?
Then clone again sample-Groceries and try to build it with tns run ios command.

Hi,
You are awesome! Finally it works! I don't know what was the problem exactly but I reinstalled npm for the latest version and now it works! Now i use npm v. 6.9.5!
Thanks a lot!
Best regards,
David


Auto let Fix

Fix missing let decs inner declaration.
I'm not sure if it's needed to fix that breaking return let which won't happen on auto Var as autovar move all variables to top.

If we want autoLet to be a viable option, I think we should fix the return let...

If we want autoLet to be a viable option, I think we should fix the return let...

Return let can be fixed, but it would be only the start as let don’t return value, that means any assignment as an expression should be checked, and hoist to the a proper position (Should be nearest position where can put a let, or maybe just block top to make it possible.) I’m not sure if now AST support to detect the AssignmentExpression’s return value is “used”
I’m checking the PR similar to that for coffeescript: https://github.com/jashkenas/coffeescript/pull/5395

Here's an idea:
When a declaration is in return position prepend it with a simple let ref, then assign the final declaration to the ref, then return the ref.
->
  let a = 1, b = 2
---
function() {
  let ref
  let a, b = ref = 2
  return ref
}

This may be useful for Civet in general to have declarations behave more like expressions.

Nice, yes, maybe we can use this to allow let declarations within if..else blocks (along with return). But it doesn't work with const... An alternative is to wrap in IFFEs, like for and do. This seems more universal.  Hmm, except then it's hard to return out of the block (e.g. if x then return let y = 5).

I think it would be quite normal for following code before how it interact with implicit return
a = b = 3
c = (d = 3)
export default MyReactFC = () => <></>

Anyway, this PR is probably worth merging already, as it fixes some bugs in autoLet. Perhaps should add a comment to the return let example like // TODO This is currently invalid. And we can continue to improve inner declarations in future PRs.

Comment added.

autoVar does hoisting to the enclosing function blocks so a similar mechanism could be used here as well.


[Feature] DDE support/bindings

DDE (dynamic data exchange, DDE docs) is used widely in Windows and it'd be great if there were a way to create (at least) DDE clients and (possibly) DDE servers in Go using windigo.

Oh yes, I remember using DDE a long time ago. Are these the APIs you need?

Oh yes, I remember using DDE a long time ago. Are these the APIs you need?

Sorry, I should've been more specific. These are APIs I'm looking to use in my project, the ddeml.h header.

I've committed the first calls. I believe the API is clean enough:
hdde, err := win.DdeInitialize(
	func(wType co.XTYP, wFmt uint32, hConv win.HCONV,
		hsz1, hsz2 win.HSZ, hData, dwData1, dwData2 uintptr) uintptr {
		return 0
	},
	co.AFCMD_APPCLASS_STANDARD,
)
if err != nil {
	panic(err)
}
defer hdde.DdeUninitialize()

ss := hdde.DdeCreateStringHandle("Hello")
defer hdde.DdeFreeStringHandle(ss)
println(hdde.DdeQueryString(ss))

println("DONE")

Please let me know if they work for you.

I just commited the DdeClientTransaction and DdeFreeDataHandle, but I really have no idea how to test them.
Can you check if are they OK?

This Python code creates a DDE server named py_dde_server and it has one topic my_topic which has one item my_item, that is the current time.
import time
import win32ui, dde
from pywin.mfc import object

class DDETopic(object.Object):
    def __init__(self, topicName):
        self.topic = dde.CreateTopic(topicName)
        object.Object.__init__(self, self.topic)
        self.items = {}

    def setData(self, itemName, value):
        try:
            self.items[itemName].SetData( str(value) )
        except KeyError:
            if itemName not in self.items:
                self.items[itemName] = dde.CreateStringItem(itemName)
                self.topic.AddItem( self.items[itemName] )
                self.items[itemName].SetData( str(value) )

server = dde.CreateServer()
server.Create("python_dde_sever")
ddeTopic = DDETopic("my_topic")
server.AddTopic(ddeTopic)

while True:
    current_time = time.time() # is a number like,<PHONE_NUMBER>.8112526
    ddeTopic.setData("my_item", current_time)
    win32ui.PumpWaitingMessages(0, -1)
    time.sleep(0.5)

Attempting to query the server with this Go code,
package main

import (
	"log"

	"github.com/rodrigocfd/windigo/win"
	"github.com/rodrigocfd/windigo/win/co"
)

func main() {
	hdde, err := win.DdeInitialize(
		func(wType co.XTYP, wFmt uint32, hConv win.HCONV,
			hsz1, hsz2 win.HSZ, hData, dwData1, dwData2 uintptr) uintptr {
			return 0
		},
		co.AFCMD_APPCLASS_STANDARD,
	)

	if err != nil {
		panic(err)
	}

	defer hdde.DdeUninitialize()

	name := win.StrOptSome("py_dde_server")
	topic := win.StrOptSome("my_topic")
	item := win.StrOptSome("my_item")

	// *Error is returned*
	hconv, err := hdde.DdeConnect(name, topic, nil)

	defer hdde.DdeDisconnect(hconv)

	if err != nil {
		panic(err)
	}

	var data []byte

	// 0x1030 = XTYP_ADVSTART
	k, err := hdde.DdeClientTransaction(data, hconv, item, 0, 0x1030, 10)
	if err != nil {
		panic(err)
	}

	log.Println(k)
	log.Println(data)
}

Results in an error;
panic: [16394 0x400a]

goroutine 1 [running]:
main.main()
        C:/Users/Jaden/Desktop/dde/cmd/main.go:34 +0x225
exit status 2

Hopefully it is easier to test with the python -- since it is like the only programming language other than C(++) that has it in its lib. DDE feels so legacy lol.

As far as I could grasp from the documentation, when calling DdeConnect, you must pass the name of an existing service to connect to. Or, don't pass any name at all to connect to any available server.
So, the code below connects without errors:
func main() {
	hDde, err := win.DdeInitialize(func(
		wType co.XTYP, wFmt uint32, hConv win.HCONV,
		hsz1, hsz2 win.HSZ, hData, dwData1, dwData2 uintptr) uintptr {
		return 0
	}, co.AFCMD_APPCLASS_STANDARD)
	if err != nil {
		panic(err)
	}
	defer hDde.DdeUninitialize()

	hConv, err := hDde.DdeConnect(win.StrOptNone(), win.StrOptNone(), nil)
	if err != nil {
		panic(err)
	}
	defer hDde.DdeDisconnect(hConv)

	hData, err := hDde.DdeClientTransaction(
		nil, hConv, win.StrOptNone(), co.CF_TEXT, co.XTYP_ADVSTART, 10)
	if err != nil {
		panic(err)
	}
	defer hDde.DdeFreeDataHandle(hData)
}

However, DdeClientTransaction is returning INVALIDPARAMETER, so now it seems it's just a matter of passing the correct parameters.
Please let me know if it's working now.

@AfricanElephant What's the Python code you're using to query the DDE service?

Where can I find the source code of this Python library? This library is completely different from all native APIs, its author created a whole different abstraction over it. I'll have to dig into the source code to see what APIs are being actually called.

I still don't know exactly what you need, but I found this C++ example, which looks pretty close.
All the needed functions are implemented, is this what you need?


Add Presto Aggregate function: geometric_mean(real) -> real

Fixes #6992

@mbasmanova Can you help review this simple PR?

Please, update documentation to list all supported types.

done


SPP-10421-update-design-system

Description
Following an accessibility audit on SML the Design System team have made a number of changes to fix the issue identified. An update to the latest version is required in order for SML to actually benefit from that work. This pull request will update the design system, and make any adjustments due to breaking changes.
Documentation has not been updated and comments have not been provided since they are not applicable for this pull request.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Technical Enhancements

Checklist:
Definition of Done
Code and merges

[ ] Code to be commented on where applicable
[ ] Documentation updated where required
[x] Have considered non-functional requirements such as Security, Performance, Scalability, and Fault Tolerance
[x] I have linted the code

Testing

[x] All levels of acceptance test are passing (automated, integration, manual, accessibility, etc.)
[x] I have run the behave command to check the selenium behaviour tests pass locally
[x] Acceptance criteria met

Other Checks

[x] I have performed a self-review of my own code
[x] I have checked for spelling errors
[ ] I have commented on my code, particularly in hard-to-understand areas
[x] My changes don't break anything unexpected
[x] I have checked and updated the security.txt file where required
[x] Up to date with the main branch
[x] For a change that needs to be deployed in a release I have a commit with the fix:, feat: or BREAKING CHANGE:
tags and will copy this commit message to the squash
[ ] For a change that does not affect the deployed code I have added a commit with ci:, docs: or test:
depending upon which area of the solution was affected

Note when merging, squash commit must begin with one of the following tags:
"BREAKING CHANGE", "feat", "fix", "ci", "docs", "test"
Usage
BREAKING CHANGE: any change that breaks current functionality and may cause compatibility errors to users upgrading
E.G BREAKING CHANGE: refactored method x to take variable y as input (changed from variable z)
feat: A new feature
E.G feat: adding method x to future methods table
fix: A bug fix
E.G fix: amending page for method x to show correct release version
ci: Changes to our CI configuration files and scripts (Concourse)
docs: Documentation only changes
test: Adding missing tests or correcting existing tests

DEPLOY_URL=https://d16l1gzj7635sf.cloudfront.net/
cloudfront_id=E3BVER8ZW4V1OV

DEPLOY_URL=https://d16l1gzj7635sf.cloudfront.net/
cloudfront_id=E3BVER8ZW4V1OV

DEPLOY_URL=https://d16l1gzj7635sf.cloudfront.net/
cloudfront_id=E3BVER8ZW4V1OV

DEPLOY_URL=https://d16l1gzj7635sf.cloudfront.net/
cloudfront_id=E3BVER8ZW4V1OV

@joepercival I have not reviewed the code yet but I did do a little testing first to see if things are behaving ok.  I found the following, could you take a look please?
Cookies banner:
Clicking on “additional cookies” or “view cookies” is not loading the cookies page.
Cookies link in footer:
Clicking this just flicks the page to the header rather than show me the cookies? Note: it only exhibits this behaviour when the cookies banner is present.
Home
“Useful resources” is a link now that returns 404. On the deployed website this isn’t a link.
Help centre
The H2 headings are slightly bigger than those on the deployed site.  Maybe this is an accessibility change?

Cookies banner: Clicking on “additional cookies” or “view cookies” is not loading the cookies page.
Cookies link in footer: Clicking this just flicks the page to the header rather than show me the cookies? Note: it only exhibits this behaviour when the cookies banner is present.
These seem to be working for me, maybe a cache issue? There was an issue with javascript so it could potentially be fixed if you clear your cache

Home “Useful resources” is a link now that returns 404. On the deployed website this isn’t a link.
This is because we are using a Card component here where we maybe shouldn't be, the design system changed the title on this component to be a link. Easy fix

Help centre The H2 headings are slightly bigger than those on the deployed site. Maybe this is an accessibility change?
Not sure what this is at the minute but I'll take a look

It may be worth pulling main as well @joepercival as the cookies page would have changed now

Cookies banner: Clicking on “additional cookies” or “view cookies” is not loading the cookies page.
Cookies link in footer: Clicking this just flicks the page to the header rather than show me the cookies? Note: it only exhibits this behaviour when the cookies banner is present.

These seem to be working for me, maybe a cache issue? There was an issue with javascript so it could potentially be fixed if you clear your cache

Thanks - yep, it was a cache issue. Reloaded and it works ok.

DEPLOY_URL=https://d16l1gzj7635sf.cloudfront.net/
cloudfront_id=E3BVER8ZW4V1OV


Renames verb to ensure for 'spo retentionlabel set'. Closes #4246

Closes #4246
Renames verb to ensure for 'spo retentionlabel set'.
A minor fix that should be merged before the next minor release, to combine it with #4156. Otherwise we introduce a breaking change.

Hi @martinlingstuyl
Seems like we introduced a broken link in the release notes. Got it fixed in the main branch already, could you rebase your branch onto the main again? After this, the workflow should complete.
Thx!

Check, just did. Thanks!

Ah, totally forgot, thank you!


Doc fixes in "Getting started"

Hey, your package sounds really interesting and I read through the "Getting started" section of the documentation to learn more about it. I copy-pasted the code for the initial examples, and there were a few code blocks that threw errors. This quick PR has fixes for them. :)

Awesome, thank you!


Feature/gh 528: Type Safety second pass for site context module

fixes: GH-528

fixed the failed test


A container to sync k8s events and examples

This is an example of writing a kubernetes events "bridge" to the kubeless kafka.
The container skippbox/k8s-events:0.10.12 will listen to events using the python client and produce messages onto a k8s kafka topic.
Then there is a SLACK function example, which gets triggered on the k8s topic and published the events to SLACK.

This is not completely correct. The fact that watch. stream is based on blocking python function, this will hang as soon as one of the loop is not producing anything, i.e. not getting to the point where they can release yield from asyncio.sleep(0.1)

@mouradmourafiq you are correct
Do you mind fixing it by any chance ? :)
I did do a version with a single watch stream: https://github.com/kubeless/functions/tree/master/incubator/controller

@sebgoa a deployment with multiple containers handling different watch streams is probably the easiest way to do it. Otherwise one could try threads instead of asyncio, since in the case threads, the python scheduler will handle the context switching.

Probably want to fix it in this blog post as well? https://engineering.bitnami.com/articles/kubernetes-async-watches.html

I just found this blog post searching the web for "async kubernetes watch", and I just had to point out that this code is very wrong (although subtly so).
Because Watch.stream() is not async, this code does not actually watch multiple streams concurrently. One of the tasks (eg pods()) will block on Watch.stream() until the next event happens, during which other tasks are not reacting to events; once a pod event happens, Watch.stream() will yield it, allowing the body of the for-loop to execute.
It is only then that asyncio.sleep() will be reached, yielding and allowing another task (eg namespaces()) to execute; that task will block on Watch.stream() in the same way, blocking all other tasks from reacting to events, until a namespace event is received and that other asyncio.sleep() is executed.
In other words, this will look like it works, as long as events keep happening in each category. However it is NOT concurrent, it is NOT asynchronous (it polls, irregularly), and it will deadlock if no event happens on one specific Watch.


Lightning-CLI as a devDependencies

Is possible to add Lightning-CLI ad a dev dependency?
What's the correct syntax?
I need to map the lng commands to npm scripts so I need to be safe that the package is installed.

Currently Lightning-CLI is specifically designed to be a global package. So while using as a local (dev)dependency inside your project might work, it's very possible you will run into issues.
What is your exact usecase?
If your concern is ensuring that Lightning-CLI is installed, you might consider adding the global install command as a preinstall script to your project's package.json.
"scripts": {
  "preinstall": "npm install -g WebPlatformForEmbedded/Lightning-CLI"
}

Thanks for the response.
I concern to ensure that Lightning-CLI is installed for ensuring that my package is more solid.
Actually the solution:
"scripts": {
  "preinstall": "npm install -g WebPlatformForEmbedded/Lightning-CLI"
}

drives to this error:
matti@LAPTOP-FKK5J5IS MINGW64
~/OneDrive/Documenti/projects/GitLab/com.company.app.tictactoe (develop)
$ npm i

> com.company.app.tictactoe@ preinstall C:\Users\matti\OneDrive\Documenti\projects\GitLab\com.company.app.tictactoe
> npm install -g WebPlatformForEmbedded/Lightning-CLI

npm ERR! code 1
npm ERR! Command failed: git submodule update -q --init --recursive
npm ERR! C:/Program Files/Git/mingw64/libexec/git-core\git-submodule: line 21: .: git-sh-setup: file not found
npm ERR!

npm ERR!      C:\Users\matti\AppData\Roaming\npm-cache\_logs\2020-02-19T09_06_34_064Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! com.company.app.tictactoe@ preinstall: `npm install -g WebPlatformForEmbedded/Lightning-CLI`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the com.company.app.tictactoe@ preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\matti\AppData\Roaming\npm-cache\_logs\2020-02-19T09_06_34_169Z-debug.log

This seems works. Please consider documenting this issue.
...
    "scripts": {
        "preinstall": "npm install -g WebPlatformForEmbedded/Lightning-CLI#master"
    }
...


FYI: must save quarto-publish.yml as quarto_publish.yml

In following this tutorial, the initial rendering failed because  it was searching for a _publish.yml file, not -publish.yml. I changed the dash to underscore and was successful.
Also, there is now a different source/branch convention on the GitHub Pages page. You first select "Deploy from a Branch" in the source and then select the branch/root.
Not a major issue, flagging just in case!

Hi, thank you for this feedback, it is much appreciated! We will be able to address this next month, along with #25. Thanks again :)

Hi @TheresaBurnham. I'm part of the Openscapes team. Thank you for opening this issue. I'm reproducing this and then will update the documentation. I have a couple of questions for you.

which method did you use: fork or download?
when you renamed quarto-publish.yml as quarto_publish.yml, do you recall if the entire quarto-website-tutorial appear?

Thank you!

Hi Stefanie -

I downloaded the repository
I can't remember the exact outputs from the renaming! But I was able to follow the rest of the tutorial no problem.

Thanks!

Thank you @TheresaBurnham. I'll ping here when it's updated


module 'keras.backend' has no attribute 'is_tensor'

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the problem.
Describe the problem clearly here. Be sure to convey here why it's a bug in Keras or why the requested feature is needed.
Describe the current behavior.
Describe the expected behavior.
Contributing.

Do you want to contribute a PR? (yes/no):
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Source code / logs.
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

@letranhuy2612 ,
There seems to be some weird compatibility issues between keras and tensorflow.keras. Could you please try with tensorflow.keras instead.
try replace
import keras.backend as K
to
import tensorflow.keras.backend as K
from tensorflow.keras.datasets import mnist
from tensorflow.python.keras.utils import np_utils
from tensorflow.keras import Sequential
from tensorflow.keras import model
from tensorflow.keras.layers import Input, Dense, Dropout, Activation, Flatten
from tensorflow.keras.optimizers import Adam, RMSprop

Thank you!


Diameter of a Binary Tree in C++

want to implement it

Implemented Diameter of a Binary Tree in C
PLease refer PR #480


Introduce ReservableCurrency Trait in Balances Module

Solves https://github.com/paritytech/substrate/issues/2120

Introduced ReservableCurrency trait
Moved "reserve" functions from Currency to ReservableCurrency
Updated existing modules and code to use this new trait
Updated docs to introduce this trait
Updated tests to work with this refactor

hmm after all I think total_balance make more sense in currency itself


Multiple devices supported?

I have set up two connections for implicit messaging. But i only get data from the connection i established first. The connection i establish second only delivers zeros. And it is the same if i swap the order of establishing the connections. Only the first established connection works properly. Is it possible to get data from to connections at the same time?

@RobertRondo I am currently trying to use this library to connect to a PLC, but both explicit messaging (e.g. eeipclient.ListIdentity()) and implicit messaging are not successful. I was wondering if you had to change anything to make it work for you (at least with one device at a time), or if it worked for you right out of the box? Thanks!
(I realize that this is unrelated to the issue, but I do not know where else to ask the question.)


Extensions viewlet keeps coming back

hide extensions viewlet
temporarily show it, select another view and it hides again ✅
temporarily show it, install an extension, reload
🐛 the viewlet is back permanently

Duplicate of #60097?

afaik not a dupe of #60097 because reload reopens a hidden viewlet but doesn't change the hide state


config/meshConfig: New localProxyMode field

Add new spec.sidecar.localProxyMode field for user to
control how mesh traffic gets proxied
Signed-off-by: Keith Mattix II<EMAIL_ADDRESS>
Description:
Part of the fix for #4653

Testing done:

Affected area:

Functional Area

New Functionality
[X]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution? no

Is this a breaking change? no

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Do we want this to be a mesh-wide option? Are there situations where a user might want to use a mix (particularly if they use other OSS services outside of their control)?
Would it make more sense for this to be a pod annotation?

@steeling I think a mesh-wide approach is best for a few reasons:

It's simplest
Making teams choose mesh-wide lowers the possibility of customers wanting us to support the old way when...
...we're eventually going to deprecate localhost proxy mode.

Codecov Report

Merging #4686 (e96b690) into main (bc3ff99) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4686      +/-   ##
==========================================
- Coverage   69.44%   69.44%   -0.01%
==========================================
  Files         217      217
  Lines       15287    15419     +132
==========================================
+ Hits        10616    10707      +91
- Misses       4621     4662      +41
  Partials       50       50

Flag
Coverage Δ

unittests
69.44% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/utils/proto.go
36.00% <0.00%> (-24.00%)
:arrow_down:

pkg/injector/webhook.go
88.37% <0.00%> (-0.04%)
:arrow_down:

pkg/k8s/client.go
93.09% <0.00%> (ø)

pkg/injector/volumes.go
100.00% <0.00%> (ø)

pkg/injector/envoy_config.go
71.79% <0.00%> (+0.07%)
:arrow_up:

pkg/cli/verifier/envoy_config.go
65.97% <0.00%> (+1.54%)
:arrow_up:

pkg/injector/patch.go
75.95% <0.00%> (+2.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3ff99...e96b690. Read the comment docs.


Backport the ReDoS fix in v2.0.0

Hey, @sindresorhus. I know you might not support v2.0.0, but there are so many packages that are still using it: https://www.npmjs.com/package/semver-regex?activeTab=versions
2.0.0
1,955,620

Would it be possible to backport the fix for 2.x too?
Thanks!
PS. the latest npm tag points to v3.1.3, not sure if that's intentional.

I don't plan to backport to v2. v2 is a very old release. I generally only backport one release back.

but there are so many packages that are still using it:

You don't know that. It could be a single popular dependency that never updated.

PS. the latest npm tag points to v3.1.3, not sure if that's intentional.

Thanks for letting me know. Fixed.

The issue for me is this dep chain: bin-wrapper -> find-versions -> semver-regex.
I'm only judging by the numbers, and the numbers are big.

The "vulnerability" does not apply to bin-wrapper.

https://github.com/npm/rfcs/pull/422 would solve this.

Yup, agreed, thanks for the info!
On Sun, Oct 3, 2021, 08:59 Sindre Sorhus @.***> wrote:

npm/rfcs#422 https://github.com/npm/rfcs/pull/422 would solve this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/semver-regex/issues/22#issuecomment-932869257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACVLNN475WNFYNQXVRRO4DUE7WMJANCNFSM5FHGA7VA
.

@sindresorhus I have this dep chain: bin-wrapper > bin-version-check > bin-version > find-versions > semver-regex which audits as vulnerable to ReDoS because it depends on the unpatched semver-regex 2.0.0
Is there something I can do to fix this? It's driving me crazy.


Technically impossible to verify Azure applications using the technique mentioned

The c ontent-type header "application/json; charset=utf-8" is sent by Wordpress, Github pages, and many other web servers, because UTF-8 has been a standard for sixteen years. It is impossible to override. The only way to use this technique to validate a file and return the content-type header without the charset=utf-8 is to host it on Microsoft web servers, which have chosen to break the specification and not comply with HTTP 1.1.
Please, please offer another technique for verification - such as a DNS TXT record - or simply accept the verification file with a content-type header of "application/json; charset=utf-8". Why is that so bad?
David Phipps, VP of Engineering, Radiant Inc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61edea45-b5d6-05b3-33c3-2265ef8cb309
Version Independent ID: c7d5813c-5cf1-44c3-88ff-3c194d3e44ad
Content: Configure an app's publisher domain - Microsoft identity platform
Content Source: articles/active-directory/develop/howto-configure-publisher-domain.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@dphipps4 thank you for this feedback! If you want this to be taken into consideration by the product team, please create a feedback request on User Voice and link it here.
I have also passed your feedback along on my end. @rwike77

Closing this out but please tag me and add the link to the feedback item once you have created it.
If you have further comments or questions feel free to reach out to me over email.

Linking the feedback request created on User Voice as instructed in hopes of speeding this process up:
Allow standard HTTP content-type headers when verifying Azure applications or provide alternative ways

/cc @MarileeTurscak-MSFT @dphipps4


Build Failure on Ubuntu 20.04 (WSL2)

Problem description
I am facing these errors while running make. I have not seen anything similar to this in the issues here. Is it a problem with mingw64?
[21/428] Performing build step for 'arrow_ep'
FAILED: third_party/arrow_ep/src/arrow_ep-stamp/arrow_ep-build third_party/arrow_ep/install/lib/libarrow.a third_party/arrow_ep/install/lib/libparquet.a third_party/arrow_ep/src/arrow_ep-build/thrift_ep-install/lib/libthrift.a
cd /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep-build && /usr/bin/cmake --build . && /usr/bin/cmake -E touch /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep-stamp/arrow_ep-build
[1/249] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/array_primitive.cc.o
FAILED: src/arrow/CMakeFiles/arrow_objlib.dir/array/array_primitive.cc.o
/usr/bin/ccache /usr/bin/c++  -DARROW_EXPORTING -DARROW_WITH_BACKTRACE -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_NO_LIB -DURI_STATIC_BUILD -Isrc -I/home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src -I/home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/generated -isystem /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/thirdparty/flatbuffers/include -isystem /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/thirdparty/hadoop/include -isystem /mnt/c/msys64/mingw64/include -Wno-noexcept-type  -fdiagnostics-color=always  -Wall -fno-semantic-interposition  -O3 -DNDEBUG -O2 -ftree-vectorize -fPIC   -pthread -std=c++17 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/array/array_primitive.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/array/array_primitive.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/array/array_primitive.cc.o -c /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.cc
In file included from /mnt/c/msys64/mingw64/include/corecrt.h:10,
                 from /mnt/c/msys64/mingw64/include/crtdefs.h:10,
                 from /mnt/c/msys64/mingw64/include/sys/cdefs.h:7,
                 from /usr/include/features.h:461,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/os_defines.h:39,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/c++config.h:528,
                 from /usr/include/c++/9/cstdint:38,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.h:23,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.cc:18:
/mnt/c/msys64/mingw64/include/_mingw.h:278:2: error: #error Only Win32 target is supported!
  278 | #error Only Win32 target is supported!
      |  ^~~~~
In file included from /mnt/c/msys64/mingw64/include/pthread.h:64,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr-default.h:35,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr.h:148,
                 from /usr/include/c++/9/ext/atomicity.h:35,
                 from /usr/include/c++/9/memory:73,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.h:24,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.cc:18:
/mnt/c/msys64/mingw64/include/sys/types.h:10:2: error: #error Only Win32 target is supported!
   10 | #error Only Win32 target is supported!
      |  ^~~~~
In file included from /mnt/c/msys64/mingw64/include/pthread.h:69,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr-default.h:35,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr.h:148,
                 from /usr/include/c++/9/ext/atomicity.h:35,
                 from /usr/include/c++/9/memory:73,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.h:24,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.cc:18:
/mnt/c/msys64/mingw64/include/time.h:12:2: error: #error Only Win32 target is supported!
   12 | #error Only Win32 target is supported!
      |  ^~~~~
In file included from /mnt/c/msys64/mingw64/include/time.h:25,
                 from /mnt/c/msys64/mingw64/include/pthread.h:69,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr-default.h:35,
                 from /usr/include/x86_64-linux-gnu/c++/9/bits/gthr.h:148,
                 from /usr/include/c++/9/ext/atomicity.h:35,
                 from /usr/include/c++/9/memory:73,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.h:24,
                 from /home/heartzy/code/Velox/_build/release/third_party/arrow_ep/src/arrow_ep/cpp/src/arrow/array/array_primitive.cc:18:
/mnt/c/msys64/mingw64/include/sys/timeb.h:12:2: error: #error Only Win32 target is supported!
   12 | #error Only Win32 target is supported!
      |  ^~~~~

System information
Velox System Info v0.0.2
Commit: b9a44015d1e446029796f3e30414940db5d2ef09
CMake Version: 3.16.3
System: Linux-<IP_ADDRESS>-microsoft-standard-WSL2
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 9.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 9.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr;/usr/local;/usr/X11R6;/usr/pkg;/opt

CMake log
No response

Hello, thanks for openeing an issue!
Velox does not support Windows yet so you can not use mingw6 to build windows libraries if this was you intention. If this was not your intention it looks like cmake from within wsl2 is picking up the mingw64 toolchain due to your windows drive being mounted in wsl.
Make sure you have the requirements installed by running scripts/setup-ubuntu.sh. If the issue persists afterwards you can try forcing the use of gcc by setting
export CC=gcc
export CXX=g++

If the issue still is not fixed by that you probably have to remove the mingw files from the path/unmount the windows drives. In that case it would probably be much easier to just use docker compose run --rm ubuntu-cpp to build velox using the docker dev container.

@heartzy did you manage to work around this issue?


Story.js missing module module declration

The stories included in this boilerplate are causing hot reload to throw the following error:
Story of "SomeComponent" named "SomeComponentName" already exists
This can be easily fixed by adding the module declaration to storiesOf like this
 storiesOf('RoundedButton', module)
  .add('Default', () => <RoundedButton text="A simple rounded button" />)
  .add('Text as children', () => (
    <RoundedButton>Hello from the childrens!</RoundedButton>
  ));

Is this still happening with 2.4.0?

@jamonholmgren I haven't tried the new version. Let me take a look and will report back

@jamonholmgren I tried testing the new version but I can't even run storybook.
This is the error I'm getting
ERROR in ./storybook/addons.js Module build failed: Error: Couldn't find preset "module:metro-react-native-babel-preset" relative to directory "/Users/jqn/apps/PizzaAppDec/storybook"

I am getting the error too.
ERROR in ./storybook/addons.js Module build failed: Error: Couldn't find preset "module:metro-react-native-babel-preset" relative to directory

Thanks for reporting! Would someone want to submit a PR to fix this? We are focused on Bowser now and not dedicating quite as much time to Andross.

Ever found a fix @hemel-cse? The babel-preset still throws an exception for me, and with the react-native preset no stories are shown in storybook.

Closing this because it works as expected on new version.


Can you review my work ? ^^

Hi barhun. Thank you so much for your work and this library.
I gave it a try on my project and got some issues using it without modifications, since i had import alias managed inside my package.json.
I forked your lib and created this alternative : www.npmjs.com/package/specifier-resolution-node
Would you have some time to review it and give me feedback about its stability ? I saw you added some code to make it works with windows, and i couldn't test it since i'm on Linux.
Anyway thank you for your work which was a good base for my solution :)

I've just added the functionality to handle import aliases as well. Could you please try with the npm package<EMAIL_ADDRESS>Also... I reviewed your work and it seems your resolver would be causing too many unnecessary attempts in order to resolve a module. This could be an issue in large projects with huge amounts of local module imports.
It is easy to figure out whether the specifier contains a known extension or not. If it doesn't, why do you even first try to resolve without an extension? And, again, if the specifier ends with a path separator, the resolver should only be looking for the index files. Too many unnecessary lookups, buddy! (:

See issue #2. This project won't change the default package resolution and deep imports behavior as it may cause other issues due to overriding named exports from the package.json/exports field.

I read further documentation about import & export maps and stuff. This solution I came up with seems to not cause issues with them anyway since, without them, we would end up with a failed resolution. Wanna give it a try with the latest version?

I gave it a try .. aaaaand :1st_place_medal: it's perfectly working on my side !
Great work :)


v9.8 changelog

@amyblais Thanks!
Let's get this merge soon since the https://docs.mattermost.com/upgrade/extended-support-release.html#what-is-the-life-cycle-of-an-extended-support-release is a bit outdated already.

@saturninoabril This PR is planned to be merged on May 16th which is when v9.8 is released and v8.1 ESR goes out of support.

Thanks @amyblais, totally understand since this is for 9.8. I wonder if in the future, the update for source/images/ESR_graphic2.png can be done monthly so the image is regularly up-to-date.


LOVR not buildable with Lua instead of LuaJIT

Looks like math library links in LuaJIT, adding m and ${CMAKE_DL_LIBS} to target_link_libraries(lovr solves this issue.

Was this with CMake on Linux?

Yes ;)
I'll prepare PR with nice fix tomorrow.
Btw, today I've successfully compiled and ran LOVR (but with Lua, not LuaJIT) on e2k processor architecture. Compiled with MCST LCC compiler, runs on Linux. It seems like it's one more available platform for LOVR.


Allow for all possible kinds of references

This entails:

an ActiveSpan is mutable, thus derefencing it as a ChildOf
reference must occur at the end of it's lifetime (ie. we have to carry
it around as a mutable reference)
traced returns the FinishedSpan along with the result of the
traced action, such that it can be used as a FollowsFrom reference
in subsequent traced calls
additionally, pure References may be used as obtained from the
propagation carrier

I'm not entirely sure what the value of FollowsFrom is, but besides that everything looks good!

I'm not entirely sure what the value of FollowsFrom is

I think it's when you don't want to wait for the parent span to complete until all children have completed (see also: https://github.com/opentracing/opentracing-go/blob/master/tracer.go#L183-L207). Contrived example:
users <- traced (spanOpts "getUsers" mempty) $ const getUsers
cache <- async $ traced (spanOpts "cacheUserIds" (followsFrom (tracedSpan users))) $ const cacheUserIds (tracedResult users)
doSomethingElseWith (tracedResult users)
wait cache

If the cache insert happens as a child, the users result is only available after that action has completed (and includes it's timing information).
Obviously, nothing prevents you at the moment to run children asynchronously and don't wait for their completion inside the traced block. I think the resulting trace would look the same.