Allow NULL to be coerced to a pointer to a fused type

Currently, when NULL and a fused type are passed to ExprNodes.coerce_to, the compiler throws the following error:

Error compiling Cython file:
------------------------------------------------------------
...
    char
    wchar_t

ctypedef c_char* c_string

cdef c_string check_ptr(c_string ptr) except NULL:
                                          ^
------------------------------------------------------------

test.pyx:9:43: Cannot coerce to a type that is not specialized

However, this error is a false positive; NULL is assignable to any pointer type, and c_string is a pointer type. This PR avoids the false positive by explicitly allowing NULL to be coerced to a pointer to a fused type.
The only example I know of in which this error is thrown is when attempting to specify NULL as an exception value for a function returning a pointer to a fused type. There are two possible workarounds for this in the current state of Cython. For example, with the following definitions...
from libc.stddef cimport wchar_t

ctypedef fused any_char:
    char
    wchar_t

ctypedef c_char* any_string

One, always checking for errors:
cdef c_string check_ptr(c_string ptr) except *:
    if ptr is NULL:
        raise ValueError("null pointer")
    return ptr

Two, returning the value cast to void*:
cdef void* check_ptr_void(c_string ptr) except NULL:
    if ptr is NULL:
        raise ValueError("null pointer")
    return <void*>ptr

check_ptr(some_string) produces this C code on call:
__pyx_fuse_1__pyx_f_4test_check_ptr(__pyx_v_some_string); if (unlikely(PyErr_Occurred())) __PYX_ERR(0, 30, __pyx_L1_error)

check_ptr_void(some_string) produces this C code on call:
__pyx_fuse_0__pyx_f_4test_check_ptr_void(__pyx_v_some_string); if (unlikely(__pyx_t_4 == ((void *)NULL))) __PYX_ERR(0, 24, __pyx_L1_error)

check_ptr_void avoids a PyErr_Occurred call, but it requires casting the return value from void* to the desired type, which is not type safe. If you instead attempt to return c_string, you get the previously mentioned compliation error.

Seems reasonable. Please add a test case to the fused types tests in tests/run/.

@scoder Test case added, as requested!

On Windows 64-bit, these new tests fail (using VC 14).
----------------------------------------------------------------------
File "A:\conda-build\cython_1523813297084\test_tmp\TEST_TMP\run\c\fused_types\fused_types.pyd", line ?, in fused_types._
_test__.test_fused_pointer_except_null (line 129)
Failed example:
    test_fused_pointer_except_null(1)
Expected:
    1
Got:
    320242256
----------------------------------------------------------------------
File "A:\conda-build\cython_1523813297084\test_tmp\TEST_TMP\run\c\fused_types\fused_types.pyd", line ?, in fused_types._
_test__.test_fused_pointer_except_null (line 129)
Failed example:
    test_fused_pointer_except_null(2.0)
Expected:
    2.0
Got:
    1.89969107482e-27

The Cython function is returning a pointer to a variable allocated on stack (with return &x), which goes out of scope upon exit. Can this test be made more robust?

Just pushed a commit which should fix it. Please test on AntyMew/cython

can the fixed test please be added to cython, the broken testcase is also crashing with gcc-8

in a release branch I mean, you would save distributors quite some trouble by adding it to your next release.

Fair enough, I cherry-picked it into 0.28.x. That doesn't mean that there will be a 0.28.5 release, though.


Sometimes use only name or ref, not both

There are cases where it would be better to ignore the name and only use the ref

http://map.project-osrm.org/?z=15&center=38.868532%2C-77.056947&loc=38.877670%2C-77.040553&loc=38.868248%2C-77.048450&hl=en&alt=0
There are cases where it would be better to ignore the ref and only use the name

http://map.project-osrm.org/?z=16&center=52.518304%2C13.445184&loc=52.517331%2C13.453681&loc=52.522501%2C13.450441&hl=en&alt=0
Doing this is a hard problem, since it requires local knowledge. I do not know how we'd solve this.

There are multiple parts to this problem:

Following a route often means traversing a series of roads with different names. #41 would introduce more contextually appropriate phrasing such as “Keep right at the fork to stay on B 96a” in the event that the previous and current steps share the ref in common.
The George Mason Memorial Bridge example above is a special case in which “stay on” phrasing would leave us with a useless instruction: “Stay on I-395”. OSRM would ideally elide such instructions altogether.
In some jurisdictions, or for some route networks, or for some particular roads, the ref may be more important than the name or vice versa.

This last part is the most intractable, as it requires local knowledge. For example, in some jurisdictions, a freeway’s name may not even be posted prominently enough for use in navigation. The road would be solely identified by a route shield, optionally with destinations:

You might only see the name after driving on the road for several miles:

Or only after stopping at a rest area or roadside attraction:

On the other hand, there are plenty of expressways and surface streets that are primarily identified by name, even if they have route designations:

Lawrence Expy. (shown above) does have a few route shields posted, but a non-local would never be able to navigate using them:

In OpenStreetMap, it’s fairly common to use tags such as official_name for road names that only appear in government documents, or for honorary names that appear alongside more common names in signage, as well as loc_name for road names that are only used by locals and never signposted. However, there’s no standard way to indicate that a name is in widespread use but not signposted consistently enough for navigation.
We could develop heuristics like preferring refs for motorways and names for everything else, but there are too many cases we’d get wrong. I think using contextual clues to omit a name or ref is probably the best way forward on this issue.

I think using contextual clues to omit a name or ref is probably the best way forward on this issue.

@1ec5 how can we begin to do this?

I think using contextual clues to omit a name or ref is probably the best way forward on this issue.

@1ec5 how can we begin to do this?

#41 and Project-OSRM/osrm-backend#3281 are the next steps.
Beyond that:

We could develop heuristics like preferring refs for motorways and names for everything else

However, OSRM doesn't tell us the classification of each road. So we'd have to base this determination on either:

The speed limit (expected distance divided by expected duration). But this won't work when ETAs account for traffic.
The network code in the ref, but this is specific to OSM and also won't scale. An application could decide to treat ref: I * as motorway, but that isn't for osrm-text-instructions to decide.

I believe https://github.com/Project-OSRM/osrm-text-instructions/issues/30 could be a cheap next step to mitigate some of these problems. It would check all ref and name of the steps of the route and decide for each one which to use, based on the weight that they get.

Tracking on https://github.com/Project-OSRM/osrm-text-instructions/issues/133 now.


🐛 [Joplin] Access-Control-Allow-Origin calls for Joplin URL instead of APP_BASE_URL

Joplin

Addon name : Joplin
Addon version : 2.10.4

Set up Joplin and Admin account
Receive a "Forbidden" Warning when trying to edit most elements (like creating new users).

Note: Personal app url below censored as "APPURL"
`Timezone set from Etc/UTC to Europe/Berlin
/etc/cont-init.d/01-custom_script.sh: executing
[16:49:09] INFO: Execute /config/joplin.sh if existing
[16:49:09] INFO: ... no script found
/etc/cont-init.d/99-run.sh: executing
[16:49:09] WARNING: Warning - minimum configuration recommended : 2 cpu cores and 4 GB of memory. Otherwise the system will become unresponsive and crash.
[16:49:09] WARNING: Warning : a custom data location was selected, but the previous folder will NOT be copied. You need to do it manually
[16:49:09] INFO: Using sqlite
[16:49:09] INFO: Mailer Security set
[16:49:10] INFO: Starting Joplin. Initial user is "admin@localhost" with password "admin"

<EMAIL_ADDRESS>start
node dist/app.js
2022-12-28 16:49:15: App: Starting server v2.10.4 (prod) on port 22300 and PID 232...
2022-12-28 16:49:15: App: Skipping NTP time check because MAX_TIME_DRIFT is 0.
2022-12-28 16:49:15: App: Running in Docker: true
2022-12-28 16:49:15: App: Public base URL: APPURL
2022-12-28 16:49:15: App: API base URL: APPURL
2022-12-28 16:49:15: App: User content base URL: APPURL
2022-12-28 16:49:15: App: Log dir: /home/joplin/packages/server/logs
2022-12-28 16:49:15: App: DB Config: {
client: 'sqlite3',
name: '/config/addons_config/joplin/database.sqlite',
slowQueryLogEnabled: false,
slowQueryLogMinDuration: 1000,
autoMigration: true,
asyncStackTraces: true
}
2022-12-28 16:49:15: App: Mailer Config: {
enabled: false,
host: '',
port: 465,
security: 'none',
authUser: '',
authPassword: '********',
noReplyName: '',
noReplyEmail: ''
}
2022-12-28 16:49:15: App: Content driver: { type: 1 }
2022-12-28 16:49:15: App: Content driver (fallback): null
2022-12-28 16:49:15: App: Trying to connect to database...
2022-12-28 16:49:15: App: Connection check: {
latestMigration: { name: '20221020143305_task_states.js', done: true },
isCreated: true,
error: null
}
2022-12-28 16:49:15: App: Auto-migrating database...
2022-12-28 16:49:15: App: Latest migration: { name: '20221020143305_task_states.js', done: true }
2022-12-28 16:49:18: App: Performing main storage check...
2022-12-28 16:49:18: App: Database storage is special and cannot be checked this way. If the connection to the database was successful then the storage driver should work too.
2022-12-28 16:49:18: App: Starting services...
2022-12-28 16:49:18: ShareService: Starting maintenance...
2022-12-28 16:49:18: EmailService: Service will be disabled because mailer config is not set or is explicitly disabled
2022-12-28 16:49:18: TaskService: Scheduling #1 (Delete expired tokens): 0 */6 * * *
2022-12-28 16:49:18: TaskService: Scheduling #2 (Update total sizes): 0 * * * *
2022-12-28 16:49:18: TaskService: Scheduling #3 (Process oversized accounts): 30 */2 * * *
2022-12-28 16:49:18: TaskService: Scheduling #6 (Delete expired sessions): 0 */6 * * *
2022-12-28 16:49:18: TaskService: Scheduling #7 (Compress old changes): 0 0 */2 * *
2022-12-28 16:49:18: TaskService: Scheduling #8 (Process user deletions): 10 * * * *
2022-12-28 16:49:18: App: Call this for testing: curl http://APPURL/api/ping
2022-12-28 16:49:18: ShareService: Maintenance completed in 95ms
2022-12-28 16:50:33: App: GET /admin/user_deletions (200) (140ms)
2022-12-28 16:50:34: [error] App: 404: GET /css/index/user_deletions.css: qrfvScwPkEtUg9hKCCNwjo: Path not found: css/index/user_deletions.css
2022-12-28 16:50:34: App: GET /css/index/user_deletions.css (404) (6ms)
2022-12-28 16:50:34: [error] App: 404: GET /favicon.ico: qrfvScwPkEtUg9hKCCNwjo: Path not found: favicon.ico
2022-12-28 16:50:34: App: GET /favicon.ico (404) (3ms)
2022-12-28 16:50:35: App: GET /admin/dashboard (200) (4ms)
2022-12-28 16:51:14: [error] App: 404: GET /: ::ffff:<IP_ADDRESS>: Invalid origin: http://<IP_ADDRESS>:22300
2022-12-28 16:51:14: App: GET / (404) (2ms)
2022-12-28 16:51:14: [error] App: 404: GET /favicon.ico: ::ffff:<IP_ADDRESS>: Invalid origin: http://<IP_ADDRESS>:22300
2022-12-28 16:51:14: App: GET /favicon.ico (404) (1ms)
2022-12-28 16:51:19: App: GET / (302) (5ms)
2022-12-28 16:51:19: [error] App: 403: GET /home: ::ffff:<IP_ADDRESS>: Forbidden
2022-12-28 16:51:19: App: GET /home (403) (3ms)
2022-12-28 16:51:20: App: GET /login (200) (8ms)
2022-12-28 16:51:22: App: GET /users/me (200) (116ms)
2022-12-28 16:51:24: App: GET /home (200) (11ms)
2022-12-28 16:51:27: App: GET /items (200) (11ms)
2022-12-28 16:51:28: App: GET /admin/dashboard (200) (3ms)
2022-12-28 16:51:29: App: GET /admin/users (200) (104ms)
2022-12-28 16:51:32: [error] App: Middleware error on /admin/users/SbLgSkVx6ofgipM3ZeBpcg: ErrorForbidden: Forbidden
at /home/joplin/packages/server/src/middleware/checkAdminHandler.ts:7:32
at Generator.next ()
at /home/joplin/packages/server/dist/middleware/checkAdminHandler.js:8:71
at new Promise ()
at __awaiter (/home/joplin/packages/server/dist/middleware/checkAdminHandler.js:4:12)
at default_1 (/home/joplin/packages/server/dist/middleware/checkAdminHandler.js:15:12)
at dispatch (/home/joplin/packages/server/node_modules/koa-compose/index.js:42:32)
at /home/joplin/packages/server/src/middleware/ownerHandler.ts:8:9
at Generator.next ()
at /home/joplin/packages/server/dist/middleware/ownerHandler.js:8:71 {
httpCode: 403,
code: undefined,
details: undefined,
headers: {
'Access-Control-Allow-Origin': 'https://joplinapp.org',
vary: 'Origin'
}
}`

Config File could not be found (neither through Studio Code Server nor File Manager nor Portainer)
System: Virtual Machine on Synology 1520+

Supervisor version: 2022.12.1
Host system version:  Home Assistant 2022.12.8,  Operating System 9.4, Frontend 20221213.1 - latest

Hi, this is strange, as it is correctly passed through the addon. Not sure how to help. I've pushed a new version with export ALLOWED_HOSTS="*" in case this helps. Looks like you have defined a domain name but are accessing with a local ip?

No, I definitely accessed it via the domain. If I go via the IP, I only get "Invalid origin: http://<IP_ADDRESS>:22300"
Also, is the update live? My HA can't find it.


Replace 'build' with 'create'

At least for the Java client, it appears the 'build' method was renamed 'create'?
https://prometheus.github.io/client_java/io/prometheus/client/Summary.Builder.html

Will figure out a way to properly redo this PR (e.g. include DCO)...

Thank you for the PR, but this is incorrect a Counter.build() returns a Counter.Builder this has all the methods as shown.
https://prometheus.github.io/client_java/io/prometheus/client/Counter.html
the .register() at the end is inherited from Builder class which creates the class from the builder and then registers it to the default registry.


Remove DSL methods in favor of setters

Fixes review items for REVIEW-6339.

Build still in queue but checked locally.

LGTM


new_hope_events not loaded with new_hope_data.R

Just wanted to let you know that the vignette example for split_flowlines does not load the new_hope_events data frame, so the example doesn't run.
thanks!
Sean

Should be loading here: https://github.com/dblodgett-usgs/hyRefactor/blob/master/inst/extdata/new_hope_data.R#L16 Do you maybe need to install the latest build from github?

Right, my fault! It looks like there's something going wrong on my end during the import
Overwritten PROJ_LIB was /Library/Frameworks/R.framework/Versions/3.6/Resources/library/rgdal/proj
Error: Cannot open "/Library/Frameworks/R.framework/Versions/3.6/Resources/library/hyRefactor/extdata/new_hope_reconcile.gpkg"; The source could be corrupt or not supported. See `st_drivers()` for a list of supported formats.
In addition: Warning message:
In CPL_read_ogr(dsn, layer, query, as.character(options), quiet,  :
  GDAL Error 1: unable to open database file: this file is a WAL-enabled database. It cannot be opened because it is presumably read-only or in a read-only directory.

Interesting. It looks like the way I load the test data won't work if your user can't write to the location the data is loaded?
Can you try installing the latest github build and let me know if it is better?
This should have fixed it: https://github.com/dblodgett-usgs/hyRefactor/commit/636512b06ac33a72a83f3ff8cadc27b7fda04b74

Still getting the same error 🤷♂ . I also tried after a fresh install of sf with no luck

Can you try running what's in this file directly? https://github.com/dblodgett-usgs/hyRefactor/blob/master/inst/extdata/new_hope_data.R
If that works, then we need to make sure that what is installed and getting sourced correctly.
Then we need to make sure that the contents of this directory:
/Library/Frameworks/R.framework/Versions/3.6/Resources/library/hyRefactor/extdata/
Contain all the required files and is getting updated when you reinstall.

Running that script successfully loads the new_hope_events data.frame. However, I'm still getting an error:
> new_hope_catchment <- sf::read_sf(nhpgpkg, "CatchmentSP")
> new_hope_catchment <- sf::st_transform(new_hope_catchment, proj)
> new_hope_flowline <- sf::read_sf(nhpgpkg, "NHDFlowline_Network")
> new_hope_flowline <- sf::st_transform(new_hope_flowline, proj)
> new_hope_fline_ref <- sf::read_sf(nhpgpkgref)
> new_hope_fline_rec <- sf::read_sf(nhpgpkgrec)
Error: Cannot open "/private/var/folders/3_/8vnl60ds0kvbhwrvf9b17ff00000gn/T/RtmpXBQCXu/fileb2a963dde817.gpkg"; The source could be corrupt or not supported. See `st_drivers()` for a list of supported formats.
In addition: Warning message:
In CPL_read_ogr(dsn, layer, query, as.character(options), quiet,  :
  GDAL Error 1: unable to open database file: this file is a WAL-enabled database. It cannot be opened because it is presumably read-only or in a read-only directory.
> new_hope_catchment_rec <- sf::read_sf(nhpgpkgreccat)
> new_hope_events <- sf::read_sf(nhpgpkgev)

I think the error loading new_hope_fline_rec causes source(system.file("extdata", "new_hope_data.R", package = "hyRefactor")) to break before it can get to new_hope_catchment_rec or new_hope_events

Interesting. There must be something wrong with new_hope_reconcile.gpkg
Can you grab it out of your install and see if it's corrupt?
Here's the one from my source directory. Does this work on your machine?
new_hope_reconcile.gpkg.zip

No, I'm unable to read either file into R using sf or rgdal.
I'm not familiar with SQL so I don't know what the next steps would be, but I found an approach that seems to handle the file without breaking. At least it appears to show the contents of the file:
library(RSQLite)
extdata <- system.file("extdata", package = "hyRefactor")
con <- dbConnect(RSQLite::SQLite(), dbname = file.path(extdata, "new_hope_reconcile.gpkg"))
dbListTables(con)

source

My theory is that this is actually related to projection. I just pulled that down and checked -- it is using some really strange projection. No idea why.
new_hope_reconcile.gpkg.zip
This work any better?

That solved it! Nicely done.

Great. Updated files are now checked in too.


Matt bell is safe but I don't know if he wrote the last PR

Hi,
I am making this PR that removes all of the code here, and I will also be tweeting it.
This is in response to a tweet on the Nomic twitter account, leaking Matt's personal information, which unfortunately I think I need to link to.
https://twitter.com/nomicbtc/status/1707652669270065198
Please report this tweet.  the attacker will have a hard time removing a pull request.
Do not click the link in the tweet.
Do not let your guard down until there's a video from matt with a clearly visible background where matt is clearly in control of the call.
Execise maximum caution.

Zaki Manian had a video call with Matt in the last 10 minutes.  Matt is physically safe.  I don't know if the attacker has access to this github.

Thanks Jacob. The attacker did not have access to Matt's GitHub account and I've confirmed these commits came from Matt, so closing this.

Thank you, too.
<3


Error displaying items in the frontend when pagination

When you change the display of the number of elements on the page, the box with the numbers disappear. This happens in the Opera browser, Chrome. In Mozilla Firefox everything is fine.

2. When it comes the number of elements on the page, pagination. By clicking on the "next" and "prev"  button,  nothing happens. No updates to display the desired number of items.
It seems that JavaScript does not fulfill, but when saved after editing the item, then pagination work.

When it comes the number of elements on the page, pagination.
I noticed that on other pages work exactly on this - no.
It does not work because this block is described in the config file:
'page'=>[
'title'=>'На главной или др. странице',
'type' => 'relationship',
'name_field' => 'rustitlepage',
'relationship' => 'page',
],

It turns out she is very sensitive about the word "page", had to change the model name "Page" and it worked.

will mark as bug and have to test this out, thanks.

follow #848 for updates when this is fixed.
@scriptixru you dont need the relationship defined and the type relationship in that stanza.


Fix grammar in queries docs

I believe completeness was the intended word rather than complicity?

Codecov Report

Merging #364 (31e4e6f) into master (fc06759) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #364   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          178       178
  Lines        14811     14811
=========================================
  Hits         14811     14811


Incorrect repo in read me

Hey there, in the read me it says:

git clone https://github.com/hcorona/recsys-101-

It should be:

git clone https://github.com/hcorona/recsys-101-workshop

thanks @ChrisChinchilla should be solved now


Auto add EXTENSION

How i can add the shared_preload_libraries = 'pg_stat_statements' parameter to postgresql.conf;
and create an extension in the postgres itself: CREATE EXTENSION pg_stat_statements.
through helm chart?

How i can add the shared_preload_libraries = 'pg_stat_statements' parameter to postgresql.conf;

The pg_stat_statements is already included in the shared_preload_libraries by default, see:
https://github.com/timescale/timescaledb-kubernetes/blob/master/charts/timescaledb-single/values.yaml#L165
If you want to add more libraries, that would be the thing to change.

and create an extension in the postgres itself: CREATE EXTENSION pg_stat_statements.
through helm chart?

That can be done by using callbacks, they are very flexible, but also quite a lot of moving parts to get where you want.
https://github.com/timescale/timescaledb-kubernetes/blob/master/charts/timescaledb-single/admin-guide.md#callbacks
Issue #102 seems like a relevant one here, adding a post-init script, which would allow you to, for example do
\connect template1 postgres
CREATE EXTENSION pg_stat_statements;


[FLINK-35143][cdc-connector][mysql] Expose newly added tables capture in mysql pipeline connector.

https://issues.apache.org/jira/browse/FLINK-35143

@qg-lin Thanks for your PR.
Please rebase the master branch and resolve the conflicts. Then let's run the CI.
If you need helps, please be free to notice me. Thanks.

@qg-lin Thanks for your PR. Please rebase the master branch and resolve the conflicts. Then let's run the CI.
If you need helps, please be free to notice me. Thanks.

Thanks for your review, I've resolved it.

Got it 👍 I missed that there is doc for the flag, the doc version was already understandable.
Looks good!

@qg-lin It seems that some tests failed. Please take a look at them. Thanks.

@qg-lin It seems that some tests failed. Please take a look at them. Thanks.

@ruanhang1993 Done, please trigger again.


Teams/Outlook - Can't log in with SAML SSO

Describe the bug
I've added Teams and Outlook 365 as services, and for each, put in my company email to log in. This redirects to the company SAML SSO service, which is a URL something like
https://saml03.mycompany.com/adfs/ls/wia?client-request-id=081df3db-63cb-4287-9396-cd4f61100836&wa=wsignin1.0&wtrealm=urn%3Afederation%3AMicrosoftOnline&wctx=LoginOptions%3D3%26estsredirect%3D2%26estsrequest%3DrQIIAeNiNdQz0LPUYjb0M7RSMU01Tk41SzbQNUoyTNM1MbIw1b1IMUnSNTdNTTW3AEJjE7MiIS9B259lOU4ntztNnnbWP1GAw2wWI8MqRrmMk8KCYit9_ZLUxNxivdzM5KL84vy0Er3k_Fz99PwdjIxBlfMDKuYlJJMjQ1sTQ0NtBNNTRM0TVJS0nSTUq1MNY1STFMTDEwTjWzMDW7xcTv71hakmEEIvKLMqtSZzGrGBqnmRsZWiTrGiaZJ-uamBkl6VoamyfpphhZGCYaJpoYpyQmb2JmA9qYm593g5nxETNvUl6OQ1lmVRHYHRdYGF-x8HAwCjBxcCowaLAb8P1gYVzECvTSzAmb1OesmOe2INI0I7dejuEUq36QiWdAYJhzWmJUXoSbj2FuRJ5nsKtZYpKrUViyW1ZYlb5LUlCxV7qveZmjramV4QQ2tlNsTF7FH9gYO9gZdnESCI9bXCJGBkYGugYmukbqCgamVsaWVoYWUQA1&cbcxt=&username=myusername%40mycompany.com&mkt=&lc=
(I've replaced the company name with "mycompany" and my username with "myusername", and replaced some characters in the tokens. It's probably not sensitive but I thought it best to mask it as I'm not sure.)
To Reproduce

Go to "Add new service"
Add a Teams or Outlook 365 service (I get the exact same issue with both)
Open the service and put in email
Click "Next"

-> The web site says "Taking you to your organization's sign-in page", but then nothing happens.
Looking in the service developers tools window, there is a request to the signon URL (similar to the example above).
The request says "0b" and "pending", and nothing more happens.
Expected behavior
Redirection to the SAML SSH service where I can log in.
Desktop:

OS: Fedora 31
Ferdi Version: 5.4.3 (from Flathub)
Server Used: None

Additional context
I would expect I need to add this URL as an allowed one for the service somehow. Apart from a full fix, pointers to where I might be able to put in an exception would be nice. I was not able to find anything like that in the settings for the services.

@bkhl Thank you for the report! 🙏 Could you please share the relevant requests headers as they happen in Ferdi and in your normal browser? The goal being to find the differences like with https://github.com/getferdi/ferdi/issues/359#issuecomment-619546342

Sure, here is this particular request in Chrome:
Request URL: https://saml03.mycompany.com/adfs/ls/wia?client-request-id=dc0756fd-ee4f-4d54-be51-fc977656c0d8&wa=wsignin1.0&wtrealm=urn%3afederation%3aMicrosoftOnline&wctx=LoginOptions%3D3%26estsredirect%3d2%26estsrequest%3drQIIAdNiNtQztFIxgAAjXRCpa5CWZqibnApiIYEiIS6Bv2Hsd_zfhfjuC_wzvSzswI1VjPIZJSUFxVb6-vmlJTn5-dl6-Wlpmcmpesn5ufr55Yn6OxgZLzAyrmIyNzM2NzI2NTczMbM0MjSzNDUw0UuyNEsySrRI1DU1tTTWNQGydS0NTEx1E82TkpNSjU00fcwNbjHx-zuWlmQYgYj8osyq1E9MnGn5RbnxBfnFJbOYY1wii01d850cnX2dIj2idF1SjV28ki2cK0rKQsxDM4NDvNINHC1zPYuMMjOdvFOyM33DIwz9UsJyLLxyS0tTPb3dPNyci7Ij03ycMsNTqkyyky1z8i2DzC3jE33iVzETFTKbmNmA3s3NzzvFzJZfkJqXmfKImTcpL8ehLLOqqAQUFBdYGF-xMBnw_WBhXMQKDMeQKQeb_x71d2iXzlsQIp3DcIpVPznJzzDSsyIwzSLDO82s3D-11LfQMtC01Fffy9BFO6zSzzg1v8BF2y3HMdTWwMpwAhvjBDa2F2yMH9gYO9gZdnESiohbXCJGBkZAh5voGpkrGFhaGVlYmZhHAQA1&cbcxt=&username=myusername%40mycompany.com&mkt=&lc=
Request Method: GET
Referrer Policy: strict-origin-when-cross-origin
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cache-Control: max-age=0
Connection: keep-alive
Host: saml03.mycompany.com
Referer: https://login.microsoftonline.com/
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: cross-site
Sec-Fetch-User: ?1
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.122 Safari/537.36

Meanwhile, in Ferdi:
Request URL: https://saml03.mycompany.com/adfs/ls/wia?client-request-id=bb5bad67-84aa-4b15-a5c9-43c1484a61e7&wa=wsignin1.0&wtrealm=urn%3afederation%3aMicrosoftOnline&wctx=LoginOptions%3D3%26estsredirect%3d2%26estsrequest%3drQIIAdNiNtQztFIxgAAjXRCpa5CWZqibnApiIYEiIS6B9LXRu1e1iHovPel80MMr8fkqRqWMkpKCYit9_fzSkpz8_Gy9_LS0zORUYzNTveT8XP388kT9HYyMFxgZVzGZmxmbGxmbmhoYW5gYGViaGZob6BknpaUZJacm6VqmpJrrmpiYpegmGVsm6RpaGFommhkZmJinmX4i43d3LC3JMAIR-UWZVamfmDjT8oty4wvyi0tmMSe4JJc4ueU7pjs7OgUVpaRUBDsGhvpHmmUn5ZQYxYdVWRiFGvh6RlUlFYdGJDuHFURlhpY4JWV75fsFl6Wau5cF-VYYFoc4hgf5F7tEeXj4-BhmlmaYOWdUlBmmmJWZmuquYiYqgDYxswG9nJufd4qZLb8gNS8z5REzb1JejkNZZlVRCSg4LrAwvmJhMuD7wcK4iBUYnBsDWxQmeD1xm3rIZsbp-H8Mp1j1w8LStCs9IwNczIu1ywwygksr8gKd_UODjVzSKtyccn083KKyMh2dAyNNym3NrAwnsDFOYGN7wcb4gY2xg51hFycR8XGLS8TIwAjodhNdI3MFA0srYxMgigIA0&cbcxt=&username=myusername%40mycompany.com&mkt=&lc=
Request Method: GET
Referrer Policy: strict-origin-when-cross-origin
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US
Connection: keep-alive
Host: saml03.mycompany.com
Referer: https://login.microsoftonline.com/
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: cross-site
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.130 Safari/537.36

Let me know if you want more extensive HAR logs or something like that?

Via https://www.diffchecker.com/

I think we need to properly set Sec-Fetch-Dest and maybe Sec-Fetch-User using modifyRequestHeaders as it was done via https://github.com/getferdi/recipes/pull/137 for Google Hangouts.

Just noticed now that Yammer also has the same issue (also a Microsoft service using the same login method).

I tried this out witht this diff, running the dev version as per the README file.
diff --git a/uncompressed/msteams/index.js b/uncompressed/msteams/index.js
index 918b7b3..dfb1d58 100644
--- a/uncompressed/msteams/index.js
+++ b/uncompressed/msteams/index.js
@@ -1,7 +1,15 @@
 "use strict";

 module.exports = Franz => class MicrosoftTeams extends Franz {
+  modifyRequestHeaders() {
+      return [{
+          headers: {
+              "Sec-Fetch-Dest": "document",
+              "Sec-Fetch-User": "?1"
+          }
+      }]
+  }
   overrideUserAgent() {
     return window.navigator.userAgent.replace(/(Ferdi|Electron)\/\S+ \([^)]+\)/g, '');
   }
-};
\ No newline at end of file
+};

I can see now that it includes the added headers:
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US
Connection: keep-alive
Host: saml03.vizrt.com
Referer: https://login.microsoftonline.com/
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: cross-site
Sec-Fetch-User: ?1
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36

So I guess it's more complicated than just hardcoding them at least.

@bkhl Thank you for giving it a try! Can you please try again removing the overrideUserAgent and override the user agent like this in modifyRequestHeaders?

Tried with this content of index.js:
"use strict";

module.exports = Franz => class MicrosoftTeams extends Franz {
  modifyRequestHeaders() {
      return [{
          headers: {
              "Sec-Fetch-Dest": "document",
              "Sec-Fetch-User": "?1",
              "User-Agent": window.navigator.userAgent.replace(/(Ferdi|Electron)\/\S+ \([^)]+\)/g,"").trim()
          }
      }]
  }
};

The request headers look like:
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US
Connection: keep-alive
Host: saml03.vizrt.com
Referer: https://login.microsoftonline.com/
Sec-Fetch-Dest: document
Sec-Fetch-Mode: navigate
Sec-Fetch-Site: cross-site
Sec-Fetch-User: ?1
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36

Sorry to say that gives the same behaviour.

I tried it again with the most recent version of Ferdi from Flathub (5.5.0), and still see the same issue.

I can confirm that this issue still exists in Ferdi 5.6.0-beta.2. Seems to be a simple window popup issue for the organizational login site.

I can confirm this issue still exists for microsoft teams. Any news on this?

I have been using "Office 365 Outlook Web App" for the past week. I have also deleted the duplicate service recipes. Please upgrade to the latest nightly (in another 12 hours) or upgrade your recipe manually (can be done now itself if you know how / follow the instructions in the website).
This particular issue isn't happening for me.

[...] Please upgrade to the latest nightly [...]

Unfortunately, no joy 😞

@jorneilander - I am running the following versions of the recipes (without any kind of edits):
Teams: 3.1.0
Office 365 Outlook Web App: 1.4.1
You can edit the service configuration in the GUI, scroll down, and you will find the "Recipe version" at the bottom of the page.

I'm running 1.4.1 as well according to the recipe.

Interestingly, if I add https://outlook.office.om inside a Custom Website service, it does actually allow me to sign in...

Unable to reproduce on macos, with the latest ferdi nightly version. Closing the ticket.


Added initial implementation of numpy equivalent for trim_zeros to jax

Hi,
This is my initial attempt to add trim_zeros function from numpy to jax.
One problem I am facing is when I add _CompileAndCheck to the test function, the test fails. I am not sure why this is the case and any help in this regard is appreciated.
Thanks

Hey @gsp-27 , thanks for the contribution!
It turns out that trim_zeros isn't a good candidate for JIT compilation with XLA, because the output shape depends on the values of the input. Because XLA programs have static shapes in their type system, that means we'd need to create and compile a separate program for most input values. That's why you're seeing issues with _CompileAndCheck.
We could still include an implementation of trim_zeros in jax.numpy and just allow it to error when people try to include it in jit functions, but that means the upside here is limited so it might also make sense just to leave it out. If we did want to include it, we'd likely need another implementation technique rather than the Python loop implementation here, perhaps based on lax.while_loop (though I'm not sure about that).
Overall I'd recommend not adding trim_zeros for the above reason.
What do you think?

See also #3499, which stalled during review.

Hi,
I am very new to this. I am happy with whatever you suggest.
Thanks,
Gaurav Pathak

I think it's worth implementing this for now, perhaps with a TODO to use masked output if/when that is more fully supported. It would also be worth replacing the internal _trim_zeros utility here: https://github.com/google/jax/blob/d8de6b61411179dcd2f63d7639bbcd69b30ac15f/jax/numpy/lax_numpy.py#L2848-L2852

Hi Jake,
I looked at #3499
I maybe wrong here, but the suggested use of enumerate creates a problem for the case when array is only [0], in this case numpy returns empty array whereas the jax function will return [0].

Ah, you're right.
It would be nice if we could vectorize this operation somehow, though, to avoid manual python loops over single-item device access which can be much more costly for JAX than for numpy, where this implementation comes from. What about something like this?
def trim_zeros(filt, trim='fb'):
  nz = asarray(filt) == 0
  if all(nz):
    return empty(0, filt.dtype)
  start = argmin(nz) if 'f' in trim.lower() else 0
  end = argmin(nz[::-1]) if 'b' in trim.lower() else 0
  return filt[start:len(filt) - end]

The downside is that it is O[N] even in the best case, where the numpy implementation is O[1] when there are no zeros to trim. But the O[1] element access is quite slow in JAX, so I thin the O[N] vectorized algorithm might be better in practice.
What do you think?

Hi Jake,
I will try this out.
Thanks

Hi,
@jakevdp does the above code look good or did I make some mistake?
Thanks,
Gaurav Pathak


.isValid() method, without marking the element

I need a way to check if an element is valid while only returning true/false, without marking the element with the error class. Similar to, but also unlike .valid() which will actually mark the element with the classname valid/error and update the message.
Does anyone have an elegant solution for this? This is what I came up with for now:
isValid: function() {
    var validator = $( this[ 0 ].form ).validate();
    var cleanElement = validator.clean( this ),
        checkElement = validator.validationTargetFor( cleanElement ),
        result = true;

    result = validator.check( checkElement ) !== false;

    return result;
}

The reason for this is that on my onkeyup function, I wanted to delay the validation by a second or two before it got validated again.
For example:
I have two rules for email, one for required, and one for valid email address. If user tries to submit without a value, the user originally gets the err message is "required". Once focused and they start inputting, even with one key, the err message immediately changes to "not valid". Obviously not UX friendly, the delay's goal is to allow the user enough time to input their correct email.
onkeyup: function (element, event) {
...
clearTimeout(timeout);
if ( $(element).hasClass('error') && event.keyCode !== 9 ) {
    // if the element is valid, validate it as normal
    // .valid() would of validated, we want to check only if its valid first
    if ( $(element).isValid() ) {
        $element.valid();
    }
    // else the element is not valid, give the user a delay on input
    // before returning another error
    else {
        // On each keyup, give user a second to enter something
        timeout = setTimeout(function () {
            console.log('give it a sec')
            $element.valid();
        }, 1000);
    }
}
}

+1

BTW: how this issue can be a duplicate of a later one? :stuck_out_tongue_closed_eyes:

Haha LOL, duplicate one of later issue.

there is a check(element) method which would help you, but it seems it is not part of the public API
https://github.com/jzaefferer/jquery-validation/blob/master/src/core.js#L582

For anyone that finds this page through Google like I did, this is the answer (I missed it when I first saw the page because of the comments after it about duplicates). Check is not in documentation but it does work.
function isValid(el) {
    return $("form").validate().check(el);
}


Adding Payout/Donate only mode to serverpool

use serverpoolconfig.json to enable/disable payout/donate modes
run npm i before running node serverpool.js to run script
paste channel id and token in serverpool.txt

use serverpoolconfig.json to enable/disable payout/donate modes
run npm i before running node serverpool.js to run script
paste channel id and token in serverpool.txt


Log Lookup Information

Description
Is there a way to record lookup information? For example, a Course is taught by an Instructor.  The course has a field of InstructorId storing the Id of the instructor.  If the instructor is changed, from Id 1 to Id 2, by default, it will record InstructorId changed from 1 to 2.  But that is not very good information for the user.  Is there a way to write Audit log of the Instructor name changes like from "Joe Smith" to "Thomas Wilson"?
Thanks.
Exception
If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message:
Stack trace:

Fiddle or Project
Create a Fiddle that reproduce the issue: https://dotnetfiddle.net/zB4SGA
Or provide a project/solution that we can run to reproduce the issue.

Make sure the project compile
Make sure to provide only the code that is required to reproduce the issue, not the whole project
You can send private code here<EMAIL_ADDRESS>
Note: If you are not able to provide code we can run and that reproduce the issue, we will not be able to fix it either.
Further technical details

EF version:3.1.6
EF Plus version:3.0.57
Database Provider:SQL Server

Hello @dongjason ,
I don't think we currently have something that could support this scenario.
We indeed have a Format mechanism, but I don't think we currently allow easily to show the navigation property name.
Do your Course also have a navigation property toward the Instructor or you will need to retrieve it from your Context to get the instructor name?
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

We do have a navigational property towards the Instructor.
I was thinking of calling the format function, say for the InstructorId field, let it return x=>x.Instructor.Name instead of the raw InstructorId value.  Is that a possibility?

Hi, I got it (somewhat) working using the format function override.  Test project is attached.
Please take a look, the location of setting the configuration is not ideal.  If I put the format configuration code in the Context's constructor, it gets an error because the other DBSet is not yet available.
Test.EFPlusCoreMigration LogLookupValue.zip

Hello @dongjason ,
Just to let you know that this request has been completed and will be released during the weekend.
You will be able to automatically add meta property and provide the old and new value as you wish. I will provide you an example when it will be released

Jonathan,
That is great to hear.  Just to sync up our understanding, what we are trying to do is to provide some “context” for the audit information.  Hypothetically, assume we have a model with multiple relations like:  Course – Instructor – Department – University with courses information across multiple universities.  The user wants to report on course changes by university.  So we will need to store a “university-context” of the course audit record by tracing up the property chain to get the Course’s Instructor.Department.University.ID and store it in the audit record.
Is that what this fix may be able to do?
Thanks.
From: Jonathan<EMAIL_ADDRESS>Sent: Thursday, August 13, 2020 10:57 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [zzzprojects/EntityFramework-Plus] Log Lookup Information (#625)
Hello @dongjasonhttps://github.com/dongjason ,
Just to let you know that this request has been completed and will be released during the weekend.
You will be able to automatically add meta property and provide the old and new value as you wish. I will provide you an example when it will be released
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/zzzprojects/EntityFramework-Plus/issues/625#issuecomment-673528247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACA4565NNW4RRFGUOL3TXW3SAP5NJANCNFSM4PU45FYQ.

I believe yes if I understand correctly, but I guess we will see if that perfectly to your requirement very soon

Hello @dongjason ,
The v3.0.59 has been released.
You can now use the MetaProperty options to add additional property such as related names.
For example, if all navigations properties is populated, you can use it this way:
AuditManager.DefaultConfiguration.MetaProperty<Course>("metaName", c => c.Instructor.Department.University.Name, c => c.Instructor.Department.University.Name);

This is a Func, so you can do pretty much anything you want such as using Context.Find, a dictionary or whatever technique you want to retrieve the name corresponding to the Id which was saved before.
So the Id keep being saved but you can add meta information about it.
Unfortunately, I'm missing time for an example but if you have difficulty to implement it, let me know and I will try to find it.
Let me also know if that was what you were looking for.

Thanks a lot.  We will try it. On Aug 18, 2020 5:05 PM, Jonathan Magnan<EMAIL_ADDRESS>wrote:
Hello @dongjason ,
The v3.0.59 has been released.
You can now use the MetaProperty options to add additional property such as related names.
For example, if all navigations properties is populated, you can use it this way:
AuditManager.DefaultConfiguration.MetaProperty("metaName", c => c.Instructor.Department.University.Name, c => c.Instructor.Department.University.Name);
This is a Func, so you can do pretty much anything you want such as using Context.Find, a dictionary or whatever technique you want to retrieve the name corresponding to the Id which was saved before.
So the Id keep being saved but you can add meta information about it.
Unfortunately, I'm missing time for an example but if you have difficulty to implement it, let me know and I will try to find it.
Let me also know if that was what you were looking for.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Awesome @dongjason ,
Don't hesitate to contact us for questions, issues or feedback.
Best regards,
Jon


Conflicting messages

The first Note in this article says that this scenario assumes existence of a vnet but then the 2nd PS script creates one. What am I missing?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d61c0c47-bb1e-5bd4-55ed-92058c3c1e2b
Version Independent ID: 09757b3e-205b-4263-fada-4d0224048f6f
Content: Protect APIs with Azure Application Gateway and Azure API Management - Azure Reference Architectures
Content Source: docs/web-apps/api-management/architectures/protect-apis.yml
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @fabriciosanchez
Microsoft Alias: robbag

@mrochon Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

Good point!  That top note should just be removed.  Typically AAC doesn't even contain instructions like this, so this whole section of the article is a bit "out of place" for Azure Architecture Center. @fabriciosanchez is no longer with the company it appears, @hallihan maybe this can be brought into an ARB in for maintenace?

The above PR has been filed and currently under review.


Dev/test atommaps in reactions

updates the tests a bit to demonstrate the actual problem
Fixes the problem

@greglandrum checks are failing so I’m going to have to do some more work in the morning.

That's an appveyor failure, which is likely just something intermittent and is very unlikely to be relevant (this is on your fork, so the Azure DevOps runs aren't happening)


[feature request]install yurthub component on edge nodes depending on StaticPod cr resource.

What would you like to be added:
As we discussed in proposal: https://github.com/openyurtio/openyurt/pull/1065, we will use StaticPod CRD to manage static pod(like yurthub component) on edge nodes. so yurtadm join should use pod template in StaticPod cr instead of hardcode to install yurthub component.
Why is this needed:
please reference the detail info: https://github.com/openyurtio/openyurt/pull/1065
others
/kind feature

/assign

/assign @y-ykcir


ACCESS-NRI ESMValTool Workshop

There are some materials here that could be adapted for ACCESS:
https://nordicesmhub.github.io/esmvaltool-workshop/


Migrate development out of google organization

Now that I've left Google, there's nobody there who's actively working on this. It's possible to transfer the repo, but the lightest weight process is to fork.
It makes sense for development to continue under my personal github account, but @robinst has been doing much more active development. In addition, I find my hands more than full with open source maintenance work these days. So if Robin wants it, I'd be happy to transfer effective ownership to him. Otherwise, I'll take it and do a minimal job as maintainer.

Hey! What do you think about creating a fancy-regex organization for the repository? I'd be happy to share maintainership.

That would also totally work. I'll get that rolling.

Yay! Would you mind making me an owner?
Also, looks like you forked the repository? That means it will always link back and compare it to the google repo, and code search doesn't work:

Not sure if you can unlink it in settings, or maybe we should instead just create a new repo and push all the branches/tags there. I can take care of that if you give me owner permissions.

Yes, you should be an owner now. I looked and don't think it's possible to unlink in settings. Feel free to migrate as you say, and lemme know if you want me to do anything else.

Thanks, I've created a support request now.

Repository is unlinked now :)!

Closing


Message components follow up

Sorry about missing this in the original PR
This adds in the functionality to get the message component data from an interaction
ApplicationCommandInteractionData now has another case statement to check if it is a command or a component which is necessary to separate out the different data (Since they are basically two entirely different structures in the discord api

Just checking have you tested?

Yes, tested and updated the example to now use the INTERACTION_CREATE event


add Debian installation instructions

Thanks! The README itself needed updating as well — I added this to your change!

ok! I wasn't sure who was supposed to generate README from the template. Thanks!


CUDA Graphs region includes unnecessary "del" symbols resulting in an invalid Python program

🐛 Bug
First, apply the following patch:
diff --git a/thunder/executors/cudagraphex.py b/thunder/executors/cudagraphex.py
index 61e482e5..38bbf81f 100644
--- a/thunder/executors/cudagraphex.py
+++ b/thunder/executors/cudagraphex.py
@@ -155,6 +155,8 @@ class CUDAGraphExecutor(FusionExecutor):
         return fusion_bsym

     def can_fuse(self, bsym: BoundSymbol):
+        from thunder.executors.torchex import item
+
         curr_tracectx = get_tracectx()
         assert hasattr(curr_tracectx, "clear_collection_names")

@@ -180,6 +182,7 @@ class CUDAGraphExecutor(FusionExecutor):
             prims.PrimIDs.RETURN,
             # Data-dependent ops
             prims.PrimIDs.ITEM,
+            item.id,
         }

         if bsym.sym.id in do_not_fuse_sym_set:

Then run the following reproducer:
import thunder
import torch

def func(x):
    return x.sum().item()

a = torch.randn(3, 3, device="cuda")

jfunc = thunder.jit(func, use_cudagraphs=True)
jfunc(a) # Fails with UnboundLocalError: local variable 't0' referenced before assignment

File thunder.computation_4:10, in computation(x)
      6 @torch.no_grad()
      7 @no_autocast
      8 def computation(x):
      9   # x: "cuda:0 f32[3, 3]"
---> 10   [t0] = CUDAGraph0(x)
     11   f1 = Tensor.item(t0)  # f1: "float ?"
     12   return f1

File ~/dev/lightning-thunder/thunder/executors/cudagraphex.py:93, in CUDAGraphCallable.__call__(self, *args)
     89     static_inputs_mask = tuple(isinstance(arg, torch.nn.Parameter) for arg in args)
     91 args_descriptor = to_arg_descriptor(*args)
---> 93 graph, static_inputs, static_outputs = build_cuda_graph(self.fn, args_descriptor, static_inputs_mask)
     95 for static_input, arg in utils.safe_zip(static_inputs, args):
     96     if id(static_input) != id(arg) and isinstance(static_input, torch.Tensor) and isinstance(arg, torch.Tensor):

File ~/dev/lightning-thunder/thunder/executors/cudagraphex.py:62, in build_cuda_graph(fn, args_descriptor, static_args_mask)
     58     static_inputs = tuple(
     59         get_static_buffer(arg) if not is_static else arg for arg, is_static in zip(args, static_args_mask)
     60     )
     61     for _ in range(3):
---> 62         fn(*static_inputs)
     64 stream.synchronize()
     65 torch.cuda.current_stream().wait_stream(stream)

File ~/dev/pytorch/main/torch/utils/_contextlib.py:115, in context_decorator.<locals>.decorate_context(*args, **kwargs)
    112 @functools.wraps(func)
    113 def decorate_context(*args, **kwargs):
    114     with ctx_factory():
--> 115         return func(*args, **kwargs)

File ~/dev/pytorch/main/torch/amp/autocast_mode.py:28, in autocast_decorator.<locals>.decorate_autocast(*args, **kwargs)
     25 @functools.wraps(func)
     26 def decorate_autocast(*args, **kwargs):
     27     with autocast_instance:
---> 28         return func(*args, **kwargs)

File ~/dev/pytorch/main/torch/amp/autocast_mode.py:28, in autocast_decorator.<locals>.decorate_autocast(*args, **kwargs)
     25 @functools.wraps(func)
     26 def decorate_autocast(*args, **kwargs):
     27     with autocast_instance:
---> 28         return func(*args, **kwargs)

File thunder.CUDAGraph0_fn_3:10, in CUDAGraph0_fn(***failed resolving arguments***)
      8 del x
      9 del t0
---> 10 return [t0]

UnboundLocalError: local variable 't0' referenced before assignment

A minimal example was asked for here https://github.com/Lightning-AI/lightning-thunder/pull/214#discussion_r1665520398.

triage review:

this is an executor for only a subset of ops, because of issues in Torch itself with cuda graph-ing some ops
this executor fuses after other executors
this comes up when trying to fix an existing bug in the cuda graphs executor
we shouldn't be deleting tensors inside a fusion region (of cuda graphs executor)

@tfogal , which ops other than data-dependent once are we talking about?
I left a comment about the need to investigate how to handle the islands around data-dep ops since, up until now, we did not have proper use cases for that. We can delete tensors, we just should not delete ones coming from non-fused regions.

It's probably just data-dependent ops, but ping @mruberry who I copied that comment from ;-)

I think this should be fixed now with #888 , so I'm closing. Please reopen if it is not fixing the issue.


[macOS] Open Ferdi in fullscreen mode if it was closed in fullscreen mode

Bug description:

Ferdi is open in fullscreen, you CMD-Q it, you re-open it and Ferdi does not open in fullscreen mode.
Steps to reproduce:

Open Ferdi
Put it in fullscreen mode
Quit it with CMD-Q
Open Ferdi again
Ferdi opens in window mode instead of fullscreen mode

Expected behavior

If you quit Ferdi while in fullscreen mode, next time you open it, it should open in fullscreen mode (like Message or Safari behavior).
Screenshots

Environment:

Operating System: macOS Catalina 10.15.6

Ferdi Version: 5.5.0 (<IP_ADDRESS>6)

Server: Ferdi

Debug information:

Cannot reproduce this on macOS Big Sur. This was probably fixed in the meantime.
Please reply in case this still occurs.


Add Lisbon Hack Week 2018 blog post

Following up to see what's left to get this published. @satazor can I help?

This is pretty much ready. We are waiting for the crdt research blog post to be posted first to update the link to point to it.

#protip: before merging a blog post, make sure to check the blog post dates are correct so that it shows correctly (right now the blog shows this post in the past, no worries I’m fixing it :))

Thanks! Maybe there are docs on this I didn’t find - was just going of
verbal instructions to “just merge it to show up”. I’ll look more closely
for docs to update with this instruction.
On Mon, Mar 25, 2019 at 10:24 AM David Dias<EMAIL_ADDRESS>wrote:

#protip: before merging a blog post, make sure to check the blog post
dates are correct so that it shows correctly (right now the blog shows this
post in the past, no worries I’m fixing it :))
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ipfs/blog/pull/222#issuecomment-476298706, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAlwF5tHOospuZGWoT1A1MyxSS4aX2f-ks5vaQZUgaJpZM4bmi4Q
.


networkaudiod: init

networkaudiod: init at 4.1.1-46
nixos/networkaudiod: init

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132519 at a8998d11 run on aarch64-linux 1

2 packages built successfully:

networkaudiod
nixos-install-tools


Possibility to exclude Google managed service accounts in IAM policy rules

We have an IAM rule which reports primitive roles (viewer/editor/owner) assigned to service accounts, so that we could replace primitive roles with a more fine grained permissions.
We would like to exclude with flag or regular permissions service accounts or groups managed by GCP, e.g.
Service accounts:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Groups:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
However we would like to have default service accounts violations reported, so that we could remove those or limit their IAMs. Examples:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Currently don't have the capacity to work on this. I'll update this ticket if anything will change.


Add sliding window to conda packages

Thanks for the work @adamrehn. I will try to put in a Conda recipe request for this package.
@bw4sz keeping you in loop

Please @adamrehn, comment on the PR to accept, after or if it has passed all tests .https://github.com/conda-forge/staged-recipes/pull/11981

@henrykironde thanks for taking the initiative on this! I've made all of the requested updates to slidingwindow itself, which necessitated bumping the version to 0.0.14 (to trigger the Travis CI build), so hopefully you'll just need to update your Conda pull request to reflect the new version number and the tests will all start passing successfully.

Thanks. We appreciate it.
On Tue, Jun 23, 2020 at 2:25 AM Adam Rehn<EMAIL_ADDRESS>wrote:

@henrykironde https://github.com/henrykironde thanks for taking the
initiative on this! I've made all of the requested updates to slidingwindow
itself, which necessitated bumping the version to 0.0.14 (to trigger the
Travis CI build), so hopefully you'll just need to update your Conda pull
request to reflect the new version number and the tests will all start
passing successfully.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adamrehn/slidingwindow/issues/5#issuecomment-648022484,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJHBLFE3YVTKPWYV6ORRETRYBYH7ANCNFSM4OE62ZTA
.

--
Ben Weinstein, Ph.D.
Postdoctoral Fellow
University of Florida
http://benweinstein.weebly.com/

Thank you @adamrehn. the tests seem to be passing. You need to comment on the PR https://github.com/conda-forge/staged-recipes/pull/11981 as the last step.
@bw4sz do you think we need to adjust the numpy compatibility please check up the PR and let me, numy to  - {{ pin_compatible('numpy') }}

@henrykironde based on https://github.com/conda-forge/staged-recipes/pull/11981#issuecomment-648330502, it looks like it's not necessary for me to comment on the PR as the author of the upstream package, but rather for you to list yourself as the maintainer of the Conda recipe and comment yourself.

Closing this issue, since I can see that the referenced pull request was merged and the Conda package is now live.


TLS should be supported as scheme, like SSL

The gateway-config can currently have ssl addresses, it should really be tls, but for backwards compatibility we should support both.

@irina-mitrea-luxoft (CC @DoruM):
Sorry, there was a miscommunication between me and David. Apparently, this has already been implemented, so please don't work on this.

@justinma246 what is the update on this.  I believe you have already started an implementation of allowing TLS in the config but then just translating it internally to ssl.
@DoruM perhaps you could review Justin's changes once he has a PR

@dpwspoon
I believe I have finished the implementation (worked with all manual tests for gateway-config), but have not finished the unit tests

The PR is here: https://github.com/kaazing/gateway/pull/653

This looks good to me, but I assume there needs to be a EE Pull request

@dpwspoon I added the enterprise.gateway PR

@jitsni (CC:@dpwspoon) We should get Justin's work to be merged in this sprint.

This is not completed, yet. In a meeting with @robinzimmermann and @jitsni , the decision was made that we will not advertise or document this feature until we have figured out a way to implement it properly.
Right now, the implementation is half baked where the scheme socks+tls is internally replaced by socks+ssl and the logs will also show the same. From a customer point of view, it looks bad when they use socks+tls but the logs will indicate socks+ssl, so the work done for this feature will stay in the product but we will not release note it until we fix the issue completely.


SPScreenState.h is not public (Snowplow v1.1.0)

Framework is built using Carthage.
Copying SPScreenState.h from private to public headers fixes the compilation issue.
This seems to be the duplicate of https://github.com/snowplow/snowplow-objc-tracker/issues/132 but in that case there we some issues with podspec.

Would you be able to share the compilation issue, please? It's not clear to me why this header file needs to be public. Thanks!

@mhadam
/path-to-proj/proj/Objc-Bridging-Header.h:17:9: note: in file included from /path-to-proj/proj/Objc-Bridging-Header.h:17:
#import "SnowplowTracker/Snowplow-Bridging-Header.h"
        ^
/path-to-proj/Carthage/Build/iOS/SnowplowTracker.framework/Headers/Snowplow-Bridging-Header.h:12:9: note: in file included from /path-to-proj/Carthage/Build/iOS/SnowplowTracker.framework/Headers/Snowplow-Bridging-Header.h:12:
#import "SPEvent.h"
        ^
/path-to-proj/Carthage/Build/iOS/SnowplowTracker.framework/Headers/SPEvent.h:24:9: error: 'SPScreenState.h' file not found
#import "SPScreenState.h"
        ^
1 error generated.
<unknown>:0: error: failed to emit precompiled header '/path-to-proj/Build/Intermediates.noindex/PrecompiledHeaders/Objc-Bridging-Header-swift_F1K48ZC7Q5VB-clang_1IJPTL83IQYYE.pch' for bridging header '/path-to-proj/proj/Objc-Bridging-Header.h'

Ah ok I see what's going on, thanks!

@iur-kaia this is released now, but let me know if anything else comes up


Feature/cms page priorities

Adds priority parameter for CMS page entity.

So, what is the point of adding just one property to the entity? Is there any additional functionality regarding this? Why it's not presented?

@N3m1s @linasmo @sanis Would you have any further comments on this feature?


Suggestion: Pl3xmap Support

Support for displaying the markers of all plugins (Portals, Regions, Beds...) on Pl3xmap. So like with Dynmap.
(Pl3xmap: Plexmap Github)

Thanks for the suggestion, Pl3xmap looks like a nice project. I will have a look at whats possible with it.


Moving to CircleCi

What are the links to relevant tickets?
WEB-5164
What does this PR do?
Moves the build agent from shippable over to CircleCI.
What functional/unit tests does this PR have?
N/A
How should a developer review this?
Eyes
Any background context you want to provide?
You know... shippable and all that
Screenshots (if appropriate)

Quality checklist (for PR author to complete BEFORE code review):

[x] Bumped version in package.json.
[x] Created circle.yml in project.
[x] Deleted shippable.yml.
[ ] Split any deploy script to deployToStaging.sh & deployToProduction.sh.
[x] Update Readme with new build badge.
[x] Setup GHUSER environment variable in Circle.
[x] Setup GHPASS environment variable in Circle.
[x] Setup GRAPHITE_API_KEY environment variable in Circle.
[x] Setup GRAPHITE_ENDPOINT_PREFIX environment variable in Circle.
[x] Setup slack webhook and quiet mode.
[x] Setup API status token in Circle.
[ ] Added AWS credentials for shortbreaksBuildAgent
[x] Added shortbreaksBuildAgent Deploy Key
[x] I am ready for this to be code reviewed, merged and tested.

Reviewer 1 @philmeehan

[x] I agree with the assumptions made in the quality checklist.
[x] I’ve witnessed the work behaving as expected.
[x] I’ve checked for appropriate test coverage.
[x] I’ve checked for coding anti-patterns.
[x] I've checked this work against the requirements of the Jira.
[x] I don’t believe this work introduces unnecessary technical debt.
[x] +1 from me!

Reviewer 2 @lukefrake

[x] I agree with the assumptions made in the quality checklist.
[ ] I’ve witnessed the work behaving as expected.
[x] I’ve checked for appropriate test coverage.
[x] I’ve checked for coding anti-patterns.
[x] I've checked this work against the requirements of the Jira.
[x] I don’t believe this work introduces unnecessary technical debt.
[x] +1 from me!

Tests pass but I get this error locally
fatal: No tags can describe 'bd8b5d7f931a11315bb9496ebe185b7b6fe682d6'.
Try --always, or create some tags.
App Name: plugin-dispatchr
Current Release:
Local Version: 1.1.0

When I download to another directory it passes. As it seems to be the submodule I have approved this one but have kept my original directory for you to test with (maybe I could airdrop it to you in the office?)


thrift: sniffing thrift filter with request/response stats

Glues together code from previous PRs into a ThriftFilter that counts requests (by type) and responses (by type and result), counts protocol errors for requests and responses, and records timings of request/response pairs.
Risk Level: Low
Testing: unit and manual testing
Docs Changes: trivial documentation of thrift config
Release Notes: introduced envoy.thrift filter
Relates to: #2247

For the router, The transport decodeFromStart and protocol messageStart callbacks will be amended to provide headers when available (e.g., THeaderTransport, TTwitter protocol). The router will buffer the request data until the messageStart and then use the message name + headers to choose a cluster and from there a host.
There's the possibility making the decoder/router short-circuit and fast-forward over the remaining N bytes based on the frame size if the cluster is configured for the same transport & protocol (e.g. no translation needs to occur). I was going to look into that based on actual performance.

@brian-pane switched the active call list to a map, I think that's the last bit and then I'll get another maintainer to take a quick pass.

@mattklein123 do you think you'll have time to look at this today, or shall I look for someone else?


NNCF export to ONNX fails

Describe the bug

Trying to export a  compressed model to onnx and I get the following error:
Traceback (most recent call last):
  File "onnx_example.py", line 13, in <module>
    compressed_model.export_model("/models/compressed_model.onnx")
  File "/openvino_training_extensions/pytorch_toolkit/nncf/nncf/nncf_network.py", line 443, in __getattr__
    return super().__getattr__(name)
  File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 585, in __getattr__
    type(self).__name__, name))
AttributeError: 'NNCFNetwork' object has no attribute 'export_model'

Steps to Reproduce

Install the latest version of  NNCF
Run the following code

import nncf
from nncf import create_compressed_model, Config as NNCFConfig

# Instantiate your uncompressed model
from torchvision.models.resnet import resnet50

model = resnet50()

# Apply compression according to a loaded NNCF config
nncf_config = NNCFConfig.from_json("./resnet_rb_sparsity_int8.json")
comp_ctrl, compressed_model = create_compressed_model(model, nncf_config)

compressed_model.export_model("/models/compressed_model.onnx")

Environment:
Dockerfile along with all necessary steps to reproduce found here: https://github.com/miikargh/nncf_issue

@AlexKoff88 @vshampor @ljaljushkin

Greetings, @miikargh!
This is a mistake in the documentation. Use comp_ctrl.export_model("/models/compressed_model.onnx") instead.


Sign Up page revamp (as asked by you)

Hey i believe I will be able to make the signup page look more appealing and cohesive since I revamped the login page too.
It currently looks like this

Adding in the same background as login page using the same set of buttons and customizing the size and shape of the box are some steps I could follow.
Open to your suggestions as well and feedback too

Thank you so much for assigning me this issue. I have a test tonight will complete this after that

i would like to inform the label is actually hactoberfest-accepted not hacktober fest so you might have to edit it for everyone

I read on the Hacktoberfest website that both hacktoberfest and hacktoberfest-accepted labels are valid for the event, so no worries—just focus on contributing! If needed, I'll try to update the labels as well. Keep up the good work!

Thank you sm. Must be a misunderstanding from my side


Improve auto checker

Landed in https://github.com/HowProgrammingWorks/SelfAssessment/commit/631b8a87c8474f7ad4ad894e7bec659edf4a5994, https://github.com/HowProgrammingWorks/SelfAssessment/commit/cccfd1951d066e2c40fb0e4686ee6b0a375636d9, https://github.com/HowProgrammingWorks/SelfAssessment/commit/a068f0f2a501e7d50c925c7a37b7f9a119db6931, and https://github.com/HowProgrammingWorks/SelfAssessment/commit/6ac74858ab45ea948fa0be8ed794ad09b3f1577e


Subscription topic does not exist

I might be missing something, but didn't find anything in the docs about having to create topics manually.
As soon as my client attempts to subscribe to a topic, it fails with:
(node:12814) UnhandledPromiseRejectionWarning: Error: 5 NOT_FOUND: Subscription topic does not exist
    at Object.exports.createStatusError (.../server/node_modules/grpc/src/common.js:87:15)
    at Object.onReceiveStatus (.../server/node_modules/grpc/src/client_interceptors.js:1188:28)
    at InterceptingListener._callNext (.../server/node_modules/grpc/src/client_interceptors.js:564:42)
    at InterceptingListener.onReceiveStatus (.../server/node_modules/grpc/src/client_interceptors.js:614:8)
    at callback (.../server/node_modules/grpc/src/client_interceptors.js:841:24)

I'm running the emulator locally.

@lohmander Currently the topic does not get created automatically.
You are right this isn't well documented. Will let this issue open to track the docs improvement.
Thanks for the feedback.

@jonas-arkulpa Is this by design or something that could be supported moving forward? Seems like a valuable behavior to be able to create topic/subscription if they do not exist. I would be love to submit a PR with this behavior


Allow local tracks in player

Be able to include local .mp3/.mp4 tracks into the playlist.

+1

+1

+1

+1


Omnisharp c# changes the color syntax

Operating system/version:
VSCode version: 1.63.2

Settings

"workbench.colorCustomizations": {
        "[Gruvbox Material Dark]": {
            "notebook.outputContainerBackgroundColor": "#ff0000",
            "terminal.ansiBlack": "#131414",
            "terminal.ansiBlue": "#108156",
            "terminal.ansiBrightBlack": "#070808",
            "terminal.ansiBrightBlue": "#db9c13",
            "terminal.ansiBrightCyan": "#f8d582",
            "terminal.ansiBrightGreen": "#B8BB26",
            "terminal.ansiBrightMagenta": "#D3869B",
            "terminal.ansiBrightRed": "#FB4934",
            "terminal.ansiBrightWhite": "#FBF1C7",
            "terminal.ansiBrightYellow": "#FABD2F",
            "terminal.ansiCyan": "#8EC07C",
            "terminal.ansiGreen": "#c59a0d",
            "terminal.ansiMagenta": "#D3869B",
            "terminal.ansiRed": "#FB4934",
            "terminal.ansiWhite": "#D5C4A1",
            "terminal.ansiYellow": "#FABD2F",
            "terminal.background": "#131414",
            "terminal.foreground": "#D5C4A1",
            "terminalCursor.background": "#D5C4A1",
            "terminalCursor.foreground": "#D5C4A1"
        }
    },
    "workbench.iconTheme": "gruvbox-material-icon-theme",
    "workbench.list.smoothScrolling": true,
    "workbench.productIconTheme": "icons-carbon",

Steps to reproduce this bug
install Microsoft's c# extension
open a .cs file
Actual behaviour
when you open the .cs sheet the color remains correct for a while until omnisharp's code lens kicks in and it then switches the color
syntax to something unrecognizable
Expected behaviour
the original color syntax remains the same

Try disable semantic highlighting.

The resolved it. Btw thank you so much for this wonderful theme, it's the only gruvbox that I like and it works for go, .net and node. You're an amazing developer


select option for queries

Hey! Just a feature request for: https://tanstack.com/query/latest/docs/framework/react/guides/render-optimizations#select
I'm on my way to building features to use pinia-colada on my project on the future instead of vue-query so I'll work in this. Just creating the issue so we can discuss it here too.

I'm actually not a big fan of select, I don't think it's needed for Vue because the

This is useful for highly optimized data transformations or to avoid unnecessary re-renders.

doesn't apply.
I would personally just write that logic within the query function. I'm open to changing my mind of course.


Changed text

Thank you for your contribution. As mentioned in the README - this is a template repo for the open source bootcamp, so we are not accepting PRs unless they are from the project owners.


run in windows ?

how can I run this cpp code in windows?
I get some library errors.

how can I run this cpp code in windows? I get some library errors.

You should prepare cuda cudnn tensorrt opencv. If some api does not support in windows, you should modify it.

Code can work fine in Windows,I tried

Thanks for your reply！

closed, feel free to reopen it if you have further questions. Thanks!

hello.
Can you tell me the cmake file and cuda cudnn version to run on windows?
Thanks..:)


Adding connectedToTheDom

I found another use case that was letting through backspace-related browser history state changes: If a backspace event results in removing the element being typed in from the dom, the default action ends up being a history change. So in the case a field has been removed from the dom, the default must also be prevented.
I also changed the validInputTypes to an object for performance and readability, and made a number of other minor readability improvements (including taking advantage of function hoisting).

Hi,
I'm not really sure to understand this usecase.
Do you mean that pressing "backspace" actually removes a text input from the dom? How can this happen? Isn't it only possible inside a contenteditable?

"Do you mean that pressing "backspace" actually removes a text input from the dom?"
Yes. I have a situation where I have a list of text fields, and if I delete all the text inside one of those fields and press backspace again, it'll delete the whole field. Pressing enter creates a new field. Because of this, backspace-disabler doesn't currently prevent the default behavior because the input was done inside a text field, but the browser still triggers history changing behavior because the text field is no longer attached to the dom. This should be possible inside a contenteditable or a textfield/textarea.

Yes. I have a situation where I have a list of text fields, and if I delete all the text inside one of those fields and press backspace again, it'll delete the whole field. Pressing enter creates a new field.

Sorry but I don't understand this situation. In which situation pressing enter does a new "field" (btw what is a field? input?)
Can you reproduce this situation in a jsfiddle so that I can understand myself what is happening here? Are your fields inside a contenteditable or not? Also don't understand why you mention textarea as it's not supposed to contain childs as far as I know

Yes it it a contenteditable.
https://jsfiddle.net/663tr51z/

Yes it is contenteditable.
https://jsfiddle.net/663tr51z/

sorry but I don't understand why you don't call preventDefault yourself?
if(event.keyCode === 8) {
     document.body.removeChild(a)
     event.preventDefault()
}

Once the input is removed, you won't go back no?

"why you don't call preventDefault yourself?"
Why would I use backspace-disabler if I have to call preventDefault myself? Isn't the whole point not having to worry about that?

hmmm I think I can see the problem.
Does does this implementation works for you? https://jsfiddle.net/663tr51z/11/
Honnestly I don't really understand your other changes like validInputTypes. Maybe these changes can be on another separate PR that we can discuss

"I don't really understand your other changes like validInputTypes"
The validInputTypes change was for speed - checking an object for containing a key is much faster than indexOf on an array. The rest are simply changes for readability and don't affect either the logic or the performance. It unfortunate the diff can't show where code was moved, because there really weren't that many changes. I moved the exports to the top for readability, but it makes the diff hard to read.

The validInputTypes change was for speed - checking an object for containing a key is much faster than indexOf on an array.

I understand that key hashing might give better perfs than large arrays, but do you have any benchmark for this kind of array size that using object is actually faster?

"do you have any benchmark"
No, but its also easier to read, which I think is more important than the performance.
x.indexOf(whatever) !== -1
vs
whatever in x

made release 1.1.1
thanks

Thanks!


Setting up project with Astro

To create the Astro project, I used the following command:
npm create astro@latest -- --force .

The --force was necessary to bypass the fact that the initial folder was not empty. I wanted to keep the instructions.md and other files that were already located in the folder.
The . at the end indicates the current folder.

Folder structure
/choices-choices-the-tech-stack
│
├── public/             # Static assets like images, fonts, etc.
│   └── favicon
│
├── src/                # Main source code for the project
│   ├── components/     # Reusable components
│ ├── layouts/          # Layouts
│      └── layout.astro # The layout
│   ├── pages/          # Page components (maps to routes)
│   │   └── index.astro # The home page
│   ├── styles/         # Global and page-specific styles
│
├── astro.config.mjs
├── package.json
├── tsconfig.json
├── .gitignore
├── node_modules/
└── package-lock.json


Tutorial example not working

I'm testing sampyl v0.3 in a conda environment running Python 2.7.15. I tried running the simple example shown here http://matatat.org/sampyl/, and I get:
Traceback (most recent call last):
  File "/home/gabriel/Dropbox/python-test/sampyl_test.py", line 13, in <module>
    nuts = smp.NUTS(logp, start)
  File "/home/gabriel/anaconda3/envs/asteca27/lib/python2.7/site-packages/sampyl/samplers/NUTS.py", line 77, in __init__
    super(NUTS, self).__init__(logp, start, **kwargs)
  File "/home/gabriel/anaconda3/envs/asteca27/lib/python2.7/site-packages/sampyl/samplers/base.py", line 32, in __init__
    start = {unicodedata.normalize('NFKC', key): val for key, val in start.items()}
  File "/home/gabriel/anaconda3/envs/asteca27/lib/python2.7/site-packages/sampyl/samplers/base.py", line 32, in <dictcomp>
    start = {unicodedata.normalize('NFKC', key): val for key, val in start.items()}
TypeError: normalize() argument 2 must be unicode, not str

Could this be related to the oldish version of Python I'm running?

I have the same issue in python2, and changing to python3 fixed the issue it should work nontheless as python2 is supported.


Published claims are shown out of order

The Issue
Because of https://github.com/lbryio/lbry/issues/1098, newly published content does not show at the top of the Published list. This causes confusion because the user may think that their item was not published correctly.
Currently, the app takes the output of claim_list_mine and reverses it, which produces incorrect results. We should order the published claims by height when using the "date" ordering mechanism.
Steps to reproduce

Publish a few items
Notice that new publishes may not show at the top of the list

Expected behaviour
Newly published items should be at the top of the Published list
Actual behaviour
Newly published items show randomly
System Configuration

LBRY Daemon version: 0.18.2
LBRY App version: 0.20.0
LBRY Installation ID:
Operating system: Windows

Anything Else

Screenshots

pull request opened for this, https://github.com/lbryio/lbry-app/pull/1018


[ENH] Standardized query result files

Closes #389
See also https://github.com/neurobagel/neurobagel_examples/pull/47

Checklist
This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass
[x] If the PR changes the participant-level and/or the dataset-level result file, the query-tool-results files in the  neurobagel_examples repo have been regenerated

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Summary by Sourcery
Standardize the format of query result files by updating the headers and data structure for TSV files, and update tests to ensure correct data mapping and validation.
Enhancements:

Standardize the format of query result files by updating the headers and data structure for TSV files.

Tests:

Update tests to reflect changes in the TSV file structure, ensuring correct data mapping and validation.

Hey @rmanaem I think you have the PR target mixed up here

The diff also looks a little funny. Would you mind checking what is happening here and then let me know?


Debian package repository incorrect

As mentioned in https://github.com/sbt/sbt/issues/2928 the current guide for installation is incorrect as it's specifying debian-experimental which currently returns a 404. An update for the guide to echo "deb https://dl.bintray.com/sbt/debian /" | sudo tee -a /etc/apt/sources.list.d/sbt.list would resolve issue for debian based distros.

Fixed as a part of #434 (16266fff8d59d78bff008dd3176ddc8e74e67b40 specifically).


Update styling in mentions auto-suggestion component

Details

I took a guess with the margins between the avatar, display name and email, as they were not specified exactly in the issue.
@puneetlath Is the highlighted part of the email name readable enough? It wasn't shown on any of the mocks inside the design doc.
Fixed Issues

$ https://github.com/Expensify/App/issues/18795
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Type in @ into the text input
Verify that the styles of suggestions match the mocks from https://github.com/Expensify/App/issues/18795

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Hm, yeah I agree that is there on the mock, but it looks like we don't do it for emojis today.

Yes, currently the height of the emoji and mention suggestions is exactly the same.

@szebniok would you be able to pick this back up and take it to the finish line this week?

@puneetlath I've updated the padding and the color of the higlighted text. I've updated the screenshots in the first comment.

Ok nice. I notice in your screenshots that it seems to look different on Android though.

Ok nice. I notice in your screenshots that it seems to look different on Android though.

+1

Fixed the font weight on native Android, I believe that now it is consistent.

iOS
Android

Hmm this feels like the styling is still quite a bit off.
Each row should be 40px tall:

The icons that are not avatars should be green. They should be at 16x16. They should also be centered inside of a 24x24 box, this way the box matches the same size as the avatars:

And there should be 8px padding on the left/right side of the rows, and then 8px margin in between avatar + name + subname.

@shawnborton Thank you for providing the exact pixel values. I didn't have access to the Figma. I've updated the PR and posted new screenshots in the first comment

Nice, I think this feels good to me. @puneetlath let me know what you think as well.

@szebniok Looks like you have not pushed the commit yet. I cannot find the commit.

@sobitneupane 😅 pushed it just now.

Looks good to me too!

@sobitneupane just to confirm - you've tested the updated PR on all devices?

@puneetlath Yes, I have. Should I add screenshots?

@sobitneupane yes if you could update the screenshots that would be great. Just because we saw issues with android styling before, so I want to be confident.

@puneetlath Updated the screenshots.

Awesome, thanks!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.25-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.25-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


WIP:  GH-46

DO NOT MERGE
This is raw & extremely WIP.  I am putting this up for some general thoughts on how I've approached it.
I think this is a great improvement to the API of this extension, but I'll admit to being a little biased about this change 😃
To that end, I typically don't care for varying names/return types to express the calling conventions; overloads or refactors have a way of blurring that meaning and the names become less clear.  Probably not the case for this extension, but something I've tried to keep in mind when thinking about how I, as a developer/consumer, want to invoke the aliases we're exposing here.
To that end, I've taken what's already there, the core of it, and refactored toward extensible objects.
In order to converge the implementations to a common invocation, I've introduced a couple of changes.
abstract class XdtSource
{
  abstract Stream GetXdtStream();
}

This type hierarchy can be extended to FilePath, full XML document streams, or any intermediate.  All the object has to do is provide a stream that can be consumed by XmlTransformation .. i.e.,
// local function, just citing the example
void TransformUsingStream(XmlTransformableDocument document) {
  using (var transform = new XmlTransformation(transformation.GetXdtStream(), settings.Logger)) {
      if (!transform.Apply(document)) {
          throw new CakeException($"Failed to transform \"{sourceFile}\" to \"{targetFile}\"");
      }
  }
}

The other change I've made is adding XdtTransformationSettings to express the modes of IXmlTransformationLogger that are currently employed.

Logger
Error Action

null
Behavior consistent with the current optional parameter IXmlTransformationLogger logger = null

UseDefaultLogger()
Default behavior consistent with the current implementation of XdtTransformConfigWithDefaultLogger

UseLogger(IXmlTransformationLogger logger)
Custom behavior defined by implementation

The real intent and power of the pattern is that we don't have to create additional named overloads to modify the way in which the aliases can be called.  It's really just a matter of reading the reference you've already got to the logger.
var fragment = @"<appSettings>
    <add key=""key-name"" value=""key-value"" xdt:Locator=""Match(key)"" xdt:Transform=""SetAttributes"" />
  </appSettings>";

var settings = new XdtTransformationSettings().UseDefaultLogger();

XdtTransformConfig("./web.config", new XdtFragmentSource(fragment), settings);

if(settings.Logger.HasWarning)
{
...

This is generally how I've approached this change.  Given the patterns in play and the commonality with the existing code, we could refactor much of the current XdtTransformation class toward this without any risk of a breaking change, but that's more about polishing than core functionality 👍
I have a few open items around tests that are still to be done, as well as a cleaning of commits/commit messages; this is by no means complete.  I wanted to get something that accurately represents the patterns & implementations up for others to review and provide feedback on before pushing forward with the tests, etc.
(Speaking of tests, I've added a ref to Moq to facilitate some of the stubs)
Please let me know if the patterns make sense and provide a reasonable, extensible solution.  If there are concerns or additional ideas on the approach, let me know.
Thanks.
cc: @augustoproiete

This is pretty much code-complete; I want to work on doing some light integration testing before removing the 'Draft' label, but this is definitely ready for some eyes on it as far as the overarching pattern/implementation & suitability.

@kcamp if you think this is ready to merge, confirm again. I would feel more comfortable making revving the version to 2.0 since this is a big change that I agree is for the better.

@phillipsj I think we're in good shape to proceed with a review, it's code-complete & I'm satisfied with the battery of tests I've thrown at it.  No objection to a major rev with the changes 👍


page_commit, page_stage design, multiple refactorings

addressing #238
Some new stuff, check stage/commit pages. Some alignment finetuning needed but looks nice imho. Also affected db edit page.
lcl_html_toolbar optimized and now can also create onclick anchors (good for forms)
gui can do bookmarks and go back to them - replacement for direct set_page. Will implement for stage later.
file unifiction code in page_stage->constructor() looks strange - is it not possible to unify data structures for local/remote file lists ?
Final effort remains to move stage/commit actions to the router. ... I'm tired of UI ... :)

:+1: will take a look sometime in the afternoon/evening

LGTM
one issue, will create separately


HW: Build flow fixes

Changing the card used doesn't match with the PSL_DCP path!
Can we create 2 variables PSL_DCP_KU3 and PSL_DCP_FGT so that PSL_DCP can be assigned by the configurator to the right one?

When selecting an action using the configurator (make snap_config), the ACTION_ROOT defined in .snap_env.sh doesn't change !!!

Should #440 be included in this update?

Can we assign a release tag for this merge?


Model-level tests ignored when using Custom load method

Cosmos version:
1.1.3
Cosmos config:

    dbt = DbtTaskGroup(
        project_config=ProjectConfig(
            dbt_project_path=DBT_CONFIG['path_project_folder'],
        ),
        profile_config=ProfileConfig(
            profile_name=DBT_CONFIG['profile_name'],
            target_name=os.environ['AWS_ENV'],
            profiles_yml_filepath=DBT_CONFIG['path_profiles_folder'] + "profiles.yml",
        ),
        execution_config=ExecutionConfig(
            dbt_executable_path=DBT_CONFIG["path_dbt_venv_folder"] + "bin/dbt",
        ),
        render_config=RenderConfig(
            load_method=LoadMode.CUSTOM,
            emit_datasets=False,
        ),
        operator_args=dict(
            append_env=True,
            env=ENV,
            dbt_cmd_global_flags=[
                "--no-use-colors",
            ],
            on_failure_callback=slack_fail.handle_callback,
        ),
        on_warning_callback=slack_warn.handle_callback,
    )

dbt model:
version: 2
models:

- name: stg_events_kafka_prod_via_s3_contracts
  config:
    alias: contracts
    schema: staging_events_kafka_prod_via_s3
    elementary:
      timestamp_column: _META_LOADED_AT
  tests:
    - elementary.freshness_anomalies:
        # https://docs.elementary-data.com/guides/elementary-tests-configuration
        # where_expression: ""
        severity: warn
        anomaly_sensitivity: 0.001
        backfill_days: 1
        days_back: 28
        anomaly_direction: both
        time_bucket:
          period: day
          count: 1
        seasonality: day_of_week
        min_training_set_size: 14

The testing Airflow task only gets created if I add a column-level test as well, such as
  columns:
    - name: contract_id
      datatype: "NUMBER(38,0)"
      # description:
      tests:
        - not_null

Excepted outcome
Test task created for even if only model-level tests are defined.

Thanks a lot for reporting this bug, @gbatiz ! Your description is super helpful and detailed and a great step towards the fix.
Would you also like to contribute with a PR to solve this issue?

I would love to, but unfortunately I don't have the time :-(