VPC configuration in cluster.yaml is not honored by kube-aws

# Unique name of Kubernetes cluster. In order to deploy
# more than one cluster into the same AWS account, this
# name must not conflict with an existing cluster.
clusterName: kubernetes-example

# Name of the SSH keypair already loaded into the AWS
# account being used to deploy this cluster.
keyName: example

# Region to provision Kubernetes cluster
region: us-west-2

# Availability Zone to provision Kubernetes cluster
#availabilityZone:

# DNS name routable to the Kubernetes controller nodes
# from worker nodes and external clients. The deployer
# is responsible for making this name routable
externalDNSName: kube.example.com

# Instance type for controller node
#controllerInstanceType: m3.medium

# Disk size (GiB) for controller node
#controllerRootVolumeSize: 30

# Number of worker nodes to create
workerCount: 3

# Instance type for worker nodes
#workerInstanceType: m3.medium

# Disk size (GiB) for worker nodes
#workerRootVolumeSize: 30

# Location of kube-aws artifacts used to deploy a new
# Kubernetes cluster. The necessary artifacts are already
# available in a public S3 bucket matching the version
# of the kube-aws tool. This parameter is typically
# overwritten only for development purposes.
#artifactURL: https://coreos-kubernetes.s3.amazonaws.com/<VERSION>

# CIDR for Kubernetes VPC
vpcCIDR: "<IP_ADDRESS>/16"

# CIDR for Kubernetes subnet
instanceCIDR: "<IP_ADDRESS>/24"

# IP Address for controller in Kubernetes subnet
controllerIP: <IP_ADDRESS>

# CIDR for all service IP addresses
serviceCIDR: "<IP_ADDRESS>/24"

# CIDR for all pod IP addresses
podCIDR: "<IP_ADDRESS>/16"

# IP address of Kubernetes controller service (must be contained by serviceCIDR)
kubernetesServiceIP: <IP_ADDRESS>

# IP address of Kubernetes dns service (must be contained by serviceCIDR)
dnsServiceIP: <IP_ADDRESS>

Then running the command:  ./kube-aws --config="cluster.yaml" render
I get the following output:
{
    "AWSTemplateFormatVersion": "2010-09-09",
    "Conditions": {
        "EmptyAvailabilityZone": {
            "Fn::Equals": [
                {
                    "Ref": "AvailabilityZone"
                },
                ""
            ]
        }
    },
    "Description": "kube-aws Kubernetes cluster",
    "Mappings": {
        "RegionMap": {
            "ap-northeast-1": {
                "alpha": "ami-208db24e",
                "beta": "ami-13f2cc7d"
            },
            "ap-southeast-1": {
                "alpha": "ami-d830fcbb",
                "beta": "ami-0e66aa6d"
            },
            "ap-southeast-2": {
                "alpha": "ami-b3af8ad0",
                "beta": "ami-cd90b5ae"
            },
            "eu-central-1": {
                "alpha": "ami-b22138de",
                "beta": "ami-e4988188"
            },
            "eu-west-1": {
                "alpha": "ami-2cf84d5f",
                "beta": "ami-f961d48a"
            },
            "sa-east-1": {
                "alpha": "ami-602aab0c",
                "beta": "ami-bfc242d3"
            },
            "us-east-1": {
                "alpha": "ami-4b240221",
                "beta": "ami-0c082966"
            },
            "us-gov-west-1": {
                "alpha": "ami-cbfc40aa",
                "beta": "ami-baf448db"
            },
            "us-west-1": {
                "alpha": "ami-d5afdbb5",
                "beta": "ami-72eb9f12"
            },
            "us-west-2": {
                "alpha": "ami-996386f9",
                "beta": "ami-66e30706"
            }
        }
    },
    "Parameters": {
        "APIServerCert": {
            "Description": "PEM-formatted kube-apiserver certificate, base64-encoded",
            "Type": "String"
        },
        "APIServerKey": {
            "Description": "PEM-formatted kube-apiserver key, base64-encoded",
            "Type": "String"
        },
        "ArtifactURL": {
            "Default": "https://coreos-kubernetes.s3.amazonaws.com/v0.3.0",
            "Description": "Public location of coreos-kubernetes deployment artifacts",
            "Type": "String"
        },
        "AvailabilityZone": {
            "Default": "",
            "Description": "Specific availability zone (optional)",
            "Type": "String"
        },
        "CACert": {
            "Description": "PEM-formattd CA certificate, base64-encoded",
            "Type": "String"
        },
        "ClusterName": {
            "Default": "kubernetes",
            "Description": "Name of Kubernetes cluster",
            "Type": "String"
        },
        "ControllerInstanceType": {
            "Default": "m3.medium",
            "Description": "EC2 instance type used for each controller instance",
            "Type": "String"
        },
        "ControllerRootVolumeSize": {
            "Default": "30",
            "Description": "Controller root volume size (GiB)",
            "Type": "String"
        },
        "KeyName": {
            "Description": "Name of SSH keypair to authorize on each instance",
            "Type": "String"
        },
        "ReleaseChannel": {
            "AllowedValues": [
                "alpha",
                "beta"
            ],
            "Default": "alpha",
            "Description": "CoreOS Linux release channel to use as instance operating system",
            "Type": "String"
        },
        "WorkerCert": {
            "Description": "PEM-formatted kubelet (worker) certificate, base64-encoded",
            "Type": "String"
        },
        "WorkerCount": {
            "Default": "1",
            "Description": "Number of worker instances to create, may be modified later",
            "Type": "String"
        },
        "WorkerInstanceType": {
            "Default": "m3.medium",
            "Description": "EC2 instance type used for each worker instance",
            "Type": "String"
        },
        "WorkerKey": {
            "Description": "PEM-formatted kubelet (worker) key, base64-encoded",
            "Type": "String"
        },
        "WorkerRootVolumeSize": {
            "Default": "30",
            "Description": "Worker root volume size (GiB)",
            "Type": "String"
        }
    },
    "Resources": {
        "AlarmControllerRecover": {
            "Properties": {
                "AlarmActions": [
                    {
                        "Fn::Join": [
                            "",
                            [
                                "arn:aws:automate:",
                                {
                                    "Ref": "AWS::Region"
                                },
                                ":ec2:recover"
                            ]
                        ]
                    }
                ],
                "AlarmDescription": "Trigger a recovery when system check fails for 5 consecutive minutes.",
                "ComparisonOperator": "GreaterThanThreshold",
                "Dimensions": [
                    {
                        "Name": "InstanceId",
                        "Value": {
                            "Ref": "InstanceController"
                        }
                    }
                ],
                "EvaluationPeriods": "5",
                "MetricName": "StatusCheckFailed_System",
                "Namespace": "AWS/EC2",
                "Period": "60",
                "Statistic": "Minimum",
                "Threshold": "0"
            },
            "Type": "AWS::CloudWatch::Alarm"
        },
        "AutoScaleWorker": {
            "Properties": {
                "AvailabilityZones": [
                    {
                        "Fn::If": [
                            "EmptyAvailabilityZone",
                            {
                                "Fn::Select": [
                                    "0",
                                    {
                                        "Fn::GetAZs": {
                                            "Ref": "AWS::Region"
                                        }
                                    }
                                ]
                            },
                            {
                                "Ref": "AvailabilityZone"
                            }
                        ]
                    }
                ],
                "DesiredCapacity": {
                    "Ref": "WorkerCount"
                },
                "HealthCheckGracePeriod": 600,
                "HealthCheckType": "EC2",
                "LaunchConfigurationName": {
                    "Ref": "LaunchConfigurationWorker"
                },
                "MaxSize": {
                    "Ref": "WorkerCount"
                },
                "MinSize": {
                    "Ref": "WorkerCount"
                },
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "PropagateAtLaunch": "true",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    },
                    {
                        "Key": "Name",
                        "PropagateAtLaunch": "true",
                        "Value": "kube-aws-worker"
                    }
                ],
                "VPCZoneIdentifier": [
                    {
                        "Ref": "Subnet"
                    }
                ]
            },
            "Type": "AWS::AutoScaling::AutoScalingGroup"
        },
        "EIPController": {
            "Properties": {
                "Domain": "vpc",
                "InstanceId": {
                    "Ref": "InstanceController"
                }
            },
            "Type": "AWS::EC2::EIP"
        },
        "IAMInstanceProfileController": {
            "Properties": {
                "Path": "/",
                "Roles": [
                    {
                        "Ref": "IAMRoleController"
                    }
                ]
            },
            "Type": "AWS::IAM::InstanceProfile"
        },
        "IAMInstanceProfileWorker": {
            "Properties": {
                "Path": "/",
                "Roles": [
                    {
                        "Ref": "IAMRoleWorker"
                    }
                ]
            },
            "Type": "AWS::IAM::InstanceProfile"
        },
        "IAMRoleController": {
            "Properties": {
                "AssumeRolePolicyDocument": {
                    "Statement": [
                        {
                            "Action": [
                                "sts:AssumeRole"
                            ],
                            "Effect": "Allow",
                            "Principal": {
                                "Service": [
                                    "ec2.amazonaws.com"
                                ]
                            }
                        }
                    ],
                    "Version": "2012-10-17"
                },
                "Path": "/",
                "Policies": [
                    {
                        "PolicyDocument": {
                            "Statement": [
                                {
                                    "Action": "ec2:*",
                                    "Effect": "Allow",
                                    "Resource": "*"
                                },
                                {
                                    "Action": "elasticloadbalancing:*",
                                    "Effect": "Allow",
                                    "Resource": "*"
                                }
                            ],
                            "Version": "2012-10-17"
                        },
                        "PolicyName": "root"
                    }
                ]
            },
            "Type": "AWS::IAM::Role"
        },
        "IAMRoleWorker": {
            "Properties": {
                "AssumeRolePolicyDocument": {
                    "Statement": [
                        {
                            "Action": [
                                "sts:AssumeRole"
                            ],
                            "Effect": "Allow",
                            "Principal": {
                                "Service": [
                                    "ec2.amazonaws.com"
                                ]
                            }
                        }
                    ],
                    "Version": "2012-10-17"
                },
                "Path": "/",
                "Policies": [
                    {
                        "PolicyDocument": {
                            "Statement": [
                                {
                                    "Action": "ec2:Describe*",
                                    "Effect": "Allow",
                                    "Resource": "*"
                                },
                                {
                                    "Action": "ec2:AttachVolume",
                                    "Effect": "Allow",
                                    "Resource": "*"
                                },
                                {
                                    "Action": "ec2:DetachVolume",
                                    "Effect": "Allow",
                                    "Resource": "*"
                                }
                            ],
                            "Version": "2012-10-17"
                        },
                        "PolicyName": "root"
                    }
                ]
            },
            "Type": "AWS::IAM::Role"
        },
        "InstanceController": {
            "Properties": {
                "AvailabilityZone": {
                    "Fn::If": [
                        "EmptyAvailabilityZone",
                        {
                            "Fn::Select": [
                                "0",
                                {
                                    "Fn::GetAZs": {
                                        "Ref": "AWS::Region"
                                    }
                                }
                            ]
                        },
                        {
                            "Ref": "AvailabilityZone"
                        }
                    ]
                },
                "BlockDeviceMappings": [
                    {
                        "DeviceName": "/dev/xvda",
                        "Ebs": {
                            "VolumeSize": {
                                "Ref": "ControllerRootVolumeSize"
                            }
                        }
                    }
                ],
                "IamInstanceProfile": {
                    "Ref": "IAMInstanceProfileController"
                },
                "ImageId": {
                    "Fn::FindInMap": [
                        "RegionMap",
                        {
                            "Ref": "AWS::Region"
                        },
                        {
                            "Ref": "ReleaseChannel"
                        }
                    ]
                },
                "InstanceType": {
                    "Ref": "ControllerInstanceType"
                },
                "KeyName": {
                    "Ref": "KeyName"
                },
                "NetworkInterfaces": [
                    {
                        "AssociatePublicIpAddress": false,
                        "DeleteOnTermination": true,
                        "DeviceIndex": "0",
                        "GroupSet": [
                            {
                                "Ref": "SecurityGroupController"
                            }
                        ],
                        "PrivateIpAddress": "<IP_ADDRESS>",
                        "SubnetId": {
                            "Ref": "Subnet"
                        }
                    }
                ],
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    },
                    {
                        "Key": "Name",
                        "Value": "kube-aws-controller"
                    }
                ],
                "UserData": {
                    "Fn::Base64": {
                        "Fn::Join": [
                            "",
                            [
                                "#cloud-config\ncoreos:\n  update:\n    reboot-strategy: \"off\"\n\n  flannel:\n    interface: $private_ipv4\n\n  etcd2:\n    name: controller\n    advertise-client-urls: http://$private_ipv4:2379\n    initial-advertise-peer-urls: http://$private_ipv4:2380\n    listen-client-urls: http://<IP_ADDRESS>:2379\n    listen-peer-urls: http://<IP_ADDRESS>:2380\n    initial-cluster: controller=http://$private_ipv4:2380\n\n  units:\n  - name: etcd2.service\n    command: start\n\n  - name: install-controller.service\n    command: start\n    content: |\n      [Service]\n      ExecStart=/bin/bash /tmp/install-controller.sh\n      Type=oneshot\n\nwrite_files:\n- path: /run/coreos-kubernetes/options.env\n  content: |\n    ETCD_ENDPOINTS=http://<IP_ADDRESS>:2379\n    ARTIFACT_URL=",
                                {
                                    "Ref": "ArtifactURL"
                                },
                                "\n\n- path: /tmp/install-controller.sh\n  content: |\n    #!/bin/bash\n\n    exec bash -c \"$(curl --fail --silent --show-error --location '",
                                {
                                    "Ref": "ArtifactURL"
                                },
                                "/scripts/install-controller.sh')\"\n\n- path: /etc/kubernetes/ssl/ca.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "CACert"
                                },
                                "\n\n- path: /etc/kubernetes/ssl/apiserver.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "APIServerCert"
                                },
                                "\n\n- path: /etc/kubernetes/ssl/apiserver-key.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "APIServerKey"
                                },
                                "\n"
                            ]
                        ]
                    }
                }
            },
            "Type": "AWS::EC2::Instance"
        },
        "InternetGateway": {
            "Properties": {
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    }
                ]
            },
            "Type": "AWS::EC2::InternetGateway"
        },
        "LaunchConfigurationWorker": {
            "Properties": {
                "BlockDeviceMappings": [
                    {
                        "DeviceName": "/dev/xvda",
                        "Ebs": {
                            "VolumeSize": {
                                "Ref": "WorkerRootVolumeSize"
                            }
                        }
                    }
                ],
                "IamInstanceProfile": {
                    "Ref": "IAMInstanceProfileWorker"
                },
                "ImageId": {
                    "Fn::FindInMap": [
                        "RegionMap",
                        {
                            "Ref": "AWS::Region"
                        },
                        {
                            "Ref": "ReleaseChannel"
                        }
                    ]
                },
                "InstanceType": {
                    "Ref": "WorkerInstanceType"
                },
                "KeyName": {
                    "Ref": "KeyName"
                },
                "SecurityGroups": [
                    {
                        "Ref": "SecurityGroupWorker"
                    }
                ],
                "UserData": {
                    "Fn::Base64": {
                        "Fn::Join": [
                            "",
                            [
                                "#cloud-config\ncoreos:\n  update:\n    reboot-strategy: \"off\"\n\n  flannel:\n    interface: $private_ipv4\n    etcd_endpoints: http://<IP_ADDRESS>:2379\n\n  units:\n  - name: install-worker.service\n    command: start\n    content: |\n      [Service]\n      ExecStart=/bin/bash /tmp/install-worker.sh\n      Type=oneshot\n\nwrite_files:\n- path: /run/coreos-kubernetes/options.env\n  content: |\n    ETCD_ENDPOINTS=http://<IP_ADDRESS>:2379\n    CONTROLLER_ENDPOINT=https://<IP_ADDRESS>\n    ARTIFACT_URL=",
                                {
                                    "Ref": "ArtifactURL"
                                },
                                "\n\n- path: /tmp/install-worker.sh\n  content: |\n    #!/bin/bash\n\n    exec bash -c \"$(curl --fail --silent --show-error --location '",
                                {
                                    "Ref": "ArtifactURL"
                                },
                                "/scripts/install-worker.sh')\"\n\n- path: /etc/kubernetes/ssl/ca.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "CACert"
                                },
                                "\n\n- path: /etc/kubernetes/ssl/worker.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "WorkerCert"
                                },
                                "\n\n- path: /etc/kubernetes/ssl/worker-key.pem\n  encoding: base64\n  content: ",
                                {
                                    "Ref": "WorkerKey"
                                },
                                "\n"
                            ]
                        ]
                    }
                }
            },
            "Type": "AWS::AutoScaling::LaunchConfiguration"
        },
        "RouteTable": {
            "Properties": {
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    }
                ],
                "VpcId": {
                    "Ref": "VPC"
                }
            },
            "Type": "AWS::EC2::RouteTable"
        },
        "RouteToInternet": {
            "Properties": {
                "DestinationCidrBlock": "<IP_ADDRESS>/0",
                "GatewayId": {
                    "Ref": "InternetGateway"
                },
                "RouteTableId": {
                    "Ref": "RouteTable"
                }
            },
            "Type": "AWS::EC2::Route"
        },
        "SecurityGroupController": {
            "Properties": {
                "GroupDescription": {
                    "Ref": "AWS::StackName"
                },
                "SecurityGroupEgress": [
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 0,
                        "IpProtocol": "tcp",
                        "ToPort": 65535
                    },
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 0,
                        "IpProtocol": "udp",
                        "ToPort": 65535
                    }
                ],
                "SecurityGroupIngress": [
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 3,
                        "IpProtocol": "icmp",
                        "ToPort": -1
                    },
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 22,
                        "IpProtocol": "tcp",
                        "ToPort": 22
                    },
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 443,
                        "IpProtocol": "tcp",
                        "ToPort": 443
                    }
                ],
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    }
                ],
                "VpcId": {
                    "Ref": "VPC"
                }
            },
            "Type": "AWS::EC2::SecurityGroup"
        },
        "SecurityGroupControllerIngressFromWorkerToEtcd": {
            "Properties": {
                "FromPort": 2379,
                "GroupId": {
                    "Ref": "SecurityGroupController"
                },
                "IpProtocol": "tcp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "ToPort": 2379
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "SecurityGroupWorker": {
            "Properties": {
                "GroupDescription": {
                    "Ref": "AWS::StackName"
                },
                "SecurityGroupEgress": [
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 0,
                        "IpProtocol": "tcp",
                        "ToPort": 65535
                    },
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 0,
                        "IpProtocol": "udp",
                        "ToPort": 65535
                    }
                ],
                "SecurityGroupIngress": [
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 3,
                        "IpProtocol": "icmp",
                        "ToPort": -1
                    },
                    {
                        "CidrIp": "<IP_ADDRESS>/0",
                        "FromPort": 22,
                        "IpProtocol": "tcp",
                        "ToPort": 22
                    }
                ],
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    }
                ],
                "VpcId": {
                    "Ref": "VPC"
                }
            },
            "Type": "AWS::EC2::SecurityGroup"
        },
        "SecurityGroupWorkerIngressFromControllerToFlannel": {
            "Properties": {
                "FromPort": 8285,
                "GroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "IpProtocol": "udp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupController"
                },
                "ToPort": 8285
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "SecurityGroupWorkerIngressFromControllerToKubelet": {
            "Properties": {
                "FromPort": 10250,
                "GroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "IpProtocol": "tcp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupController"
                },
                "ToPort": 10250
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "SecurityGroupWorkerIngressFromControllerTocAdvisor": {
            "Properties": {
                "FromPort": 4194,
                "GroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "IpProtocol": "tcp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupController"
                },
                "ToPort": 4194
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "SecurityGroupWorkerIngressFromWorkerToFlannel": {
            "Properties": {
                "FromPort": 8285,
                "GroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "IpProtocol": "udp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "ToPort": 8285
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "SecurityGroupWorkerIngressFromWorkerToKubeletReadOnly": {
            "Properties": {
                "FromPort": 10255,
                "GroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "IpProtocol": "tcp",
                "SourceSecurityGroupId": {
                    "Ref": "SecurityGroupWorker"
                },
                "ToPort": 10255
            },
            "Type": "AWS::EC2::SecurityGroupIngress"
        },
        "Subnet": {
            "Properties": {
                "AvailabilityZone": {
                    "Fn::If": [
                        "EmptyAvailabilityZone",
                        {
                            "Fn::Select": [
                                "0",
                                {
                                    "Fn::GetAZs": {
                                        "Ref": "AWS::Region"
                                    }
                                }
                            ]
                        },
                        {
                            "Ref": "AvailabilityZone"
                        }
                    ]
                },
                "CidrBlock": "<IP_ADDRESS>/24",
                "MapPublicIpOnLaunch": true,
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    }
                ],
                "VpcId": {
                    "Ref": "VPC"
                }
            },
            "Type": "AWS::EC2::Subnet"
        },
        "SubnetRouteTableAssociation": {
            "Properties": {
                "RouteTableId": {
                    "Ref": "RouteTable"
                },
                "SubnetId": {
                    "Ref": "Subnet"
                }
            },
            "Type": "AWS::EC2::SubnetRouteTableAssociation"
        },
        "VPC": {
            "Properties": {
                "CidrBlock": "<IP_ADDRESS>/16",
                "EnableDnsHostnames": true,
                "EnableDnsSupport": true,
                "InstanceTenancy": "default",
                "Tags": [
                    {
                        "Key": "KubernetesCluster",
                        "Value": {
                            "Ref": "ClusterName"
                        }
                    },
                    {
                        "Key": "Name",
                        "Value": "kubernetes-vpc"
                    }
                ]
            },
            "Type": "AWS::EC2::VPC"
        },
        "VPCGatewayAttachment": {
            "Properties": {
                "InternetGatewayId": {
                    "Ref": "InternetGateway"
                },
                "VpcId": {
                    "Ref": "VPC"
                }
            },
            "Type": "AWS::EC2::VPCGatewayAttachment"
        }
    }
}

This may be an issue of new functionality being prematurely exposed? https://github.com/coreos/coreos-kubernetes/commit/11e75bf0162790f557f4a76a34e7ac7b44a40f76#diff-da222392c29da368a3a2c580c10576e2 indicates that the enhancements to the rendered cfn template to allow setting subnetting parameters went in after the 0.3.0 release.
Any chance of cutting a new release?

I should add that this occurs both in the current release and on master (built from source).

Dear all, unless I got everything wrong, this is not a bug at all. The aws cloudformation template does not change as you hoped that it will merge the values from your yaml. No the template is submitted as is, and whatever you specified is supplied to aws cloudformation as parameter values, that's how they work. If you go aws console and look at cloudformation stack you'll see your parameters.
Given the trend to use immutable resources, the template is FIXED, what you supply is run-time information, thus the parameter stuff.

Now a related issue is what does "kube-aws render" really do, it looks like it just grabbed the file from s3 storage, without doing anything extra, you can do the same with curl or awscli in one line too.

@xied75 - the AWS CFN template in use (the one hosted in S3 by CoreOS, and the one generated by kube-aws render) does not use any passed subnetting parameters when defining network (VPC, subnet, etc) resources. That is the primary cause of the problem, seemingly.
Also, that's not what kube-aws render does. It creates (using a golang cfn library) a CloudFormation template suitable for upload to S3, to be referenced by the kube-aws up command.

@xied75 Yeah, I have to confirm what @jeffb-stell said.  I spent a good 4 hours compiling a custom version of kube-aws to ensure the correct values where being supplied (and they weren't).  I could only get the thing to work by changing the default values in the Golang source to those I needed for deployment.

We have #240 in review now. Should land soon.
TLDR; kube-render will generate all artifacts (now called assets), and kube-up will use those on-disk assets to create the cloudformation. No more S3 intermediary for the artifacts- on kube-aws up everything is pulled from the asset directory created by kube-aws render

This all leaves me to wonder, "What is the point of CIDR prompts in the yaml if the network provisioned in AWS is always the same <IP_ADDRESS>/24?"

As mentioned above, you must use the template.json file created by kube-aws render in order to set the VPC CIDR (as well as the rest of the networking configuration options that have become available since the last release)
We are in the process of cutting a new release, which will change (read: simplify) the way that assets are templated into cloudformation stack. Until then, if you want to use the network configuration stuff you'll have to render your own template.json file and host it in an s3 bucket.

Yes. Sorry for posting the incomplete thought. The point is that if so many people are making this same mistake then maybe it'd be best to add something like "INTERNAL" or "VIRTUAL" or "OVERLAY" in the comments above networking related fields in the yaml.

Note that the template generated by the render command is also incorrect
(does not incorporate CIDR values)
On Fri, Feb 5, 2016, 12:36 AM colhom<EMAIL_ADDRESS>wrote:

As mentioned above, you must use the template.json file created by kube-aws
render in order to set the VPC CIDR (as well as the rest of the
networking configuration options that have become available since the last
release)
We are in the process of cutting a new release, which will change (read:
simplify) the way that assets are templated into cloudformation stack.
Until then, if you want to use the network configuration stuff you'll have
to render your own template.json file and host it in an s3 bucket.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/coreos-kubernetes/issues/259#issuecomment-180207214
.

@jeffb-stell This is not a bug. The cloudformation template only includes the default values for parameters. Even when you render your own template with custom networking parameter values, template.json will only contain the default values. The kube-aws up command provides the custom parameters on the API call for stack creation.
The reason users are experiencing this problem while using the default coreos-hosted artifactUrl is that the v0.3.0 cloudformation template does not include references to the new networking parameters. This means that when kube-aws up is run, the networking parameters simply do not exist in the template and are ignored. This is certainly un-intuitive, and it's easy to see how folks could get confused.
As of tonight, the v0.4.0 release has been cut. The kube-aws binary packaged with that release will by default use the newly uploaded v0.4.0 artifact url, which means that networking configuration works "out of the box" now, and does not require rendering/hosting your own template.

@colhom - I would say that it is not obvious what the intent of the render command is if it does not actually show what the environment would look like with my environment-specific settings applied.  I understand that this is the nature of CloudFormation, but I have to say it seems quite unintuitive.

@rclayton-the-terrible I agree completely. We're currently working through a major revamp of this tool which will alleviate this nasty tangled web of things parameterizing things which parameterize other things.....


Added Hindi (Indian) language in README.md

Added Hindi (Indian) language in README.md

Hi @stephencelis , @mbrandonw, Please review the small PR.
Thanks


Scan hangs running test against target with missing linked files

          Original issue by @micnguyen - Imported from fastlane/scan#96

Hi,
I've been using scan for a bit and it's been working great.
I have recently added a new Target and a new test for that target (that is a duplicate of the 1st test but with the target app changed). When I do CMD+U in Xcode to run, it fails on the test because the new Target didn't have some files linked when you add a file (that checkbox that appears when adding new files to a project). That's all fine - but when I try and run a scan on the project with the missing linked files, it just stalls and doesn't error out on any compilation.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (411/400 (102%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext2.iad.github.net ([<IP_ADDRESS>]:41382 helo=github-smtp2b-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKqt-002kfd-AJ
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:20:22 +0200
Date: Sat, 18 Jun 2016 11:19:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1466273974;
bh=7iRixYsWJiT/vzpqNeeNYgwWdSCdb801IPcC83nJZr0=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=R7wlkBysh1eOuFTNXlvZahh+KtOZ1oNnCxkQAJh0g7tmm4YMQh12TVASjzPBNhgSC
CXjwIuUdRk0fOAV/0XSj1mWbMjLdebxoDTB9IS7TbinK8aO+IuiMDmGsgJCMKq2JgH
ezjnBbXo+EKgRgJLXf/4SkuCiQ6hCTZSJ+Q28Ugo=
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] Scan hangs running test against target with
missing linked files (#1929)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_576590b613534_55543fc9de0b92c031910fc";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3MObiHUbBFUXB2LOmm1IHqdWyF_7ks5qNDa2gaJpZM4IyNCI
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-4.1
X-Spam-Score: -40
X-Spam-Bar: ----
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  This issue will be auto-closed because there hasn't been any
activity for a few months. Feel free to open a new one
if you still experience this problem 👍 [...]
Content analysis details:   (-4.1 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
[<IP_ADDRESS> listed in wl.mailspike.net]
-0.0 SPF_PASS               SPF: sender matches SPF record
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_576590b613534_55543fc9de0b92c031910fc
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity for=
a few months. Feel free to [open a new one](https://github.com/fastlane/=
fastlane/issues/new) if you still experience this problem =F0=9F=91=8D

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/1929#issuecomment-226957189=
----==_mimepart_576590b613534_55543fc9de0b92c031910fc
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity =
for a few months. Feel free to open a new one if you still experience this problem=
 =F0=9F=91=8D
&m=
dash;You are receiving this because you are subscribed to this thre=
ad.Reply to this email directly, view it on GitHub, =
or mute the thread.

----==_mimepart_576590b613534_55543fc9de0b92c031910fc--

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (412/400 (103%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext5.iad.github.net ([<IP_ADDRESS>]:45879 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKqt-002kfz-MV
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:20:24 +0200
Date: Sat, 18 Jun 2016 11:19:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1466273974;
bh=/xuP+KhAZzsh4nOzhv90HjROJMxiLeLLLVrGgTIKG/I=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=fv2JAQIsaSfyk7Q9S0dapYUoOPM5yXRxU44jEFFvYZor/kaVIH4XvKX7jtmLHDRJf
D0qVqEFyibTQ7pDmyPcbdQmpBOfenTMwvoF1OAxJ3B9ifhFGgVn0fM2RPwt12N0F/e
55IW/9AH26wyOaxNpB5VsQUo6IUldkQ9T1Lfz7os=
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] Scan hangs running test against target with
missing linked files (#1929)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_576590b649fc6_37fc3f878aff92bc5587f1";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3MObiHUbBFUXB2LOmm1IHqdWyF_7ks5qNDa2gaJpZM4IyNCI
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-4.1
X-Spam-Score: -40
X-Spam-Bar: ----
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #1929. --- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/fastlane/fastlane/issues/1929#event-696784396
[...]
Content analysis details:   (-4.1 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
[<IP_ADDRESS> listed in wl.mailspike.net]
-0.0 SPF_PASS               SPF: sender matches SPF record
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_576590b649fc6_37fc3f878aff92bc5587f1
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #1929.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/1929#event-696784396
----==_mimepart_576590b649fc6_37fc3f878aff92bc5587f1
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #1929.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_576590b649fc6_37fc3f878aff92bc5587f1--


i18n support

When I hover the pointer on the function or when the quick info shows up in Visual Studio + F# Power Tools, I see the quick info in my local language and even the error messages are shown in local language. Would it be possible to have i18n support in Ionide? Thank you.
Intellisense/Quick info localized message:

Localized error message:

I don't think it's possible for us. Translation in VS is done on VS side, not compiler / language services so we cannot use it (and it's not OSSed anyway). And translating error messages (and maintaining this translation) is definitely not in scope (or possibilities, given limited resources) of Ionide.

I thought this is compiler/language facility as it changes based on my selection of my system locale when I'm using Visual Studio.
Anyway it's not an essential feature. Thanks.


按照文档运行测试程序时报错：ImportError: There is no such entity as whisper.tokenizer.get_tokenizer

装好环境后，运行下面代码
export PYTHONPATH=third_party/Matcha-TTS

from cosyvoice.cli.cosyvoice import CosyVoice
from cosyvoice.utils.file_utils import load_wav
import torchaudio

cosyvoice = CosyVoice('pretrained_models/CosyVoice-300M-SFT')
# sft usage
print(cosyvoice.list_avaliable_spks())
output = cosyvoice.inference_sft('你好，我是通义生成式语音大模型，请问有什么可以帮您的吗？', '中文女')
torchaudio.save('sft.wav', output['tts_speech'], 22050)

cosyvoice = CosyVoice('pretrained_models/CosyVoice-300M')
# zero_shot usage, <|zh|><|en|><|jp|><|yue|><|ko|> for Chinese/English/Japanese/Cantonese/Korean
prompt_speech_16k = load_wav('zero_shot_prompt.wav', 16000)
output = cosyvoice.inference_zero_shot('收到好友从远方寄来的生日礼物，那份意外的惊喜与深深的祝福让我心中充满了甜蜜的快乐，笑容如花儿般绽放。', '希望你以后能够做的比我还好呦。', prompt_speech_16k)
torchaudio.save('zero_shot.wav', output['tts_speech'], 22050)
# cross_lingual usage
prompt_speech_16k = load_wav('cross_lingual_prompt.wav', 16000)
output = cosyvoice.inference_cross_lingual('<|en|>And then later on, fully acquiring that company. So keeping management in line, interest in line with the asset that\'s coming into the family is a reason why sometimes we don\'t buy the whole thing.', prompt_speech_16k)
torchaudio.save('cross_lingual.wav', output['tts_speech'], 22050)

cosyvoice = CosyVoice('pretrained_models/CosyVoice-300M-Instruct')
# instruct usage, support <laughter></laughter>[laughter][breath]
output = cosyvoice.inference_instruct('在面对挑战时，他展现了非凡的勇气与智慧。', '中文男', 'Theo \'Crimson\', is a fiery, passionate rebel leader. Fights with fervor for justice, but struggles with impulsiveness.')
torchaudio.save('instruct.wav', output['tts_speech'], 22050)

报错：
python ./test.py
2024-07-24 16:41:45,844 - modelscope - INFO - PyTorch version 2.0.1+cu118 Found.
2024-07-24 16:41:45,845 - modelscope - INFO - Loading ast index from /home/li/.cache/modelscope/ast_indexer
2024-07-24 16:41:45,945 - modelscope - INFO - Loading done! Current index file version is 1.15.0, with md5 f3b2ecdbd84d4837f6917685088b6d20 and a total number of 980 components indexed
transformer is not installed, please install it if you want to use related modules
/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/torch/_jit_internal.py:726: FutureWarning: ignore(True) has been deprecated. TorchScript will now drop the function call on compilation. Use torch.jit.unused now. {}
  warnings.warn(
/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/diffusers/models/lora.py:393: FutureWarning: `LoRACompatibleLinear` is deprecated and will be removed in version 1.0.0. Use of `LoRACompatibleLinear` is deprecated. Please switch to PEFT backend by installing PEFT: `pip install peft`.
  deprecate("LoRACompatibleLinear", "1.0.0", deprecation_message)
Traceback (most recent call last):
  File "./test.py", line 5, in <module>
    cosyvoice = CosyVoice('pretrained_models/CosyVoice-300M-SFT')
  File "/home/li/workspace/CosyVoice/cosyvoice/cli/cosyvoice.py", line 29, in __init__
    configs = load_hyperpyyaml(f)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 188, in load_hyperpyyaml
    hparams = yaml.load(yaml_stream, Loader=loader)
  File "/home/li/.local/lib/python3.8/site-packages/yaml/__init__.py", line 81, in load
    return loader.get_single_data()
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 116, in get_single_data
    return self.construct_document(node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 120, in construct_document
    data = self.construct_object(node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 147, in construct_object
    data = self.construct_non_recursive_object(node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 188, in construct_non_recursive_object
    for _dummy in generator:
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 633, in construct_yaml_map
    value = self.construct_mapping(node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 429, in construct_mapping
    return BaseConstructor.construct_mapping(self, node, deep=deep)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 244, in construct_mapping
    value = self.construct_object(value_node, deep=deep)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 147, in construct_object
    data = self.construct_non_recursive_object(node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 183, in construct_non_recursive_object
    data = constructor(self, tag_suffix, node)
  File "/home/li/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 491, in _construct_name
    raise ImportError("There is no such entity as %s" % callable_string)
ImportError: There is no such entity as whisper.tokenizer.get_tokenizer

export PYTHONPATH, check faq.md

I have the same issue

I also encountered the same problem

https://github.com/FunAudioLLM/CosyVoice/issues/203#issuecomment-2249831883
see this


Added new method to enable changing user site roles.

I thought these changes were useful for us and wanted to share them back if you are interested.

Thanks for your contribution!

Please note, we have changed our name, and so the repo URL will get updated. Sorry for any inconvenience.


cas: add image locking.

This patch adds image locking like explained in #460.

Rebased on top of #575

I changed the title as it was misleading because the locking is not only around the diskv functions but in future will also cover the blobstore. This is better described as the locking of an "image". Where the image is composed by multiple elements. I also tried to exaplain it better in the patch commit message.
@vcaputo I removed the changed file detection logic from pkg/lock/dir.go and moved it inside pkg/lock/keylock.go. As per the comment on the previous commit, let me know if it's clear or if you see problems with the implementation.

@eyakubovich I updated #574 but forgot to rebase it. Done! Thanks.

@crawford right. The unique need is to check that the file matches the requested type (a dir or a regular file). Would you prefer, instead of duplicating the functions, to just use the current ones with the isDir bool argument converting it to a custom enum type? (like proposed in previous comments by @eyakubovich)

@sgotti oh jeez. I missed that second "isDir" parameter. Nevermind :)

@crawford @vcaputo @eyakubovich I tried using an enum flag to specify the lock type (dir or regfile) instead of using multiple functions for every lock type. IMHO it's cleaner. Before pushing it I made another branch here: https://github.com/coreos/rocket/compare/master...sgotti:casdiskvlockv2

The necessity of the change detection is really annoying. Too bad there isn't an fcntl or something for accessing the open reference count of a file descriptor... then the CleanKeyLocks() could detect a refcount > 1 before attempting to acquire the lock for deletion.

@vcaputo Probably it will not be enough as CleanKeyLocks can take an exclusive locks as there're no opened fds on the file, but, then another locker opens the file descriptor before CleanKeyLocks removes the file.

I really dislike the booleans like:

createAndLock(lockDir, key, true, true)

it's totally ambiguous what the two trues are doing without looking up createAndLock().
Please change this to something contextual, e.g.:

createAndLock(lockDir, key, NonBlocking, Exclusive)
vs.
createAndLock(lockDir, key, Blocking, Shared)

the current code is less readable than C code calling flock(2):

flock(fd, LOCK_NB|LOCK_EX)

@vcaputo I don't like it too also if it's an unexported method. I'll rework it in the next week (also changing some function names as their name doesn't explain that they are related to keylock) as I'll be on vacation.
About the change in pkg/lock/dir.go do you prefer the other way done here: https://github.com/coreos/rocket/compare/master...sgotti:casdiskvlockv2 ? So I'll do something similar also in keylock.go

@vcaputo I changed the boolean arguments to a binary flag mode similar to the flock syscall. Additionally, in the DirLock conversion patch I used the other approach proposed in the above comments to choose the file type.

Updated now that #332 has landed adding locking around the tree store's methods.

@vcaputo could you please review when you have some time?

sure

other than two minor things mentioned lgtm


Add new Rails/RelativeDateConstant cop

We probably do not use relative date from system startup time as constant. This cop checks it.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

.ago and .from_now are the relative date methods I usually see in code.

Looks OK to me apart from my small remarks. I guess it can even have auto-correct.

👍

@bbatsov @sinsoku one of my favorite things is getting a new cop that solves a problem I didn't even know was a problem.  This is fantastic.  Thank you.


Always show the commit title when reviewing commits in a PR

Description
Currently, the commit title is only shown at the very top of the page and scrolls out if the commit contains lots of changes.
The PR title is sticky and stays visible.
It makes sense to move the commit title next to the PR title e.g. in the format PR title > Commit title
Example URLs
https://github.com/refined-github/refined-github/pull/7546/commits

That area is already quite busy and buggy at times.


Mod conflicts with EnderIO Alloy Smelter

Exactly, server randomly crashes with such error: Error Gist
Server doesn't start until backup is restored.
Mekanism v 9.1
Minecraft 1.7.10
Forge <IP_ADDRESS>4

A mod is shipping with an outdated IC2 API.


BEEFC pubkey wrong size

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
A recent commit linked below added a token with an invalid pubkey. I'd suggest it get removed or modified + add a check in the future to prevent invalid information like wrong size pubkeys.

Other information
https://github.com/solana-labs/token-list/commit/e6b220ccc717b66fd9aba671d7d95a3f0b369c82

@beefc

good point. this got automerged


Icon changes on copying the code

Closes issue #317
Inside the eventlistener of iconContainer image source is changed to tick icon and inside the setTimeout function it turns back to previous copy icon.

when clicking on the copy button the tick appears and covers its own height due to which the div expands. Please fix this. Also use a SVG and upload it.


[Question] What's different between output file to temporaryDirectory and AppGroup ?

Hi,
Thank you for providing this source code. I have a question, why you don't save an output video directly to AppGroup?

Hi, Bee
Thank you for good question. You're right, concrete AppGroup-based URL can be used for output.
Temporary directory is rudimental


Add unit tests for CLI commands

Coverage increased (+3.3%) to 66.609% when pulling aa3266c19a6276637660b86f748af2757cb46f7e on clitest into 2aca9406fbfd630d8245407fd1a3aea838a02ae5 on master.


OCPBUGS-7696: Fix empty clusterName references for GenerateMachinePublicIPName

The assignment of MachineConfig.Name with clusterName was removed: https://github.com/openshift/machine-api-provider-azure/pull/47 As such the value resulted in an empty string, which was used in combination with the machineName strings to produce and invalid IP address name.
This should use a valid value for clusterName by fetching it from the infrastructure object.

/approve
/lgtm

/lgtm

/jira refresh

/retest

/retest

/retest

/retest

/cherry-pick release-4.12


Fix session labels

Fixes #75 and updates the test datasets correspondingly.

Pull Request Test Coverage Report for Build 706379041

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 40.123%

Totals

Change from base Build 704932022:
0.4%

Covered Lines:
195

Relevant Lines:
486

💛  - Coveralls

Those changes are ok for me!
Shall we fix at the same time the problem in our rules that @satra pointed out yesterday, i.e that a session named 'ses-Peter_MS21_180720_110037_concat' (as present in @bendichter 's dataset) should not be validated because of the presence of the _ characters... ?

or is it actually the goal of this PR? (sorry, havn't been closely enough in what this PR does, ahah ;) )

Yes, that is exactly what is fixed with this PR for our test datasets and the validator. I also left a comment in #73 that addresses the issue there.

awesome! merging...

Pull Request Test Coverage Report for Build 706379041
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 40.123%

Totals

Change from base Build 704932022:
0.4%

Covered Lines:
195

Relevant Lines:
486

💛  - Coveralls


use a function to get class, but no effect.

if I use 'bg-#999' in the script, it's right, but I use the funciton to get 'bg-#999', it doesn't works.

have you tried to put it into the safelist?

Actually i haven't. But it will be work if i put the 'bg-#999' to the script.
I thought that uno can auto parse the hexadecimal color, but i don't think so now. So i will put it into the safelist. Thank you.

https://github.com/unocss/unocss#scanning
Add // @unocss-include to your script file.


Is there a way to use this with angular server?

http://angular-meteor.com/server
I'm wanting to try out angular server in one of my apps, but it seems awkward when using angular 2 now on the client side. Is it possible to extend it to the server also?

@vacarsu Are you saying that you'd like to be able to do @Service, etc on the server side with angular-server?

For the moment I have no plans to support angular2-now on the server side, as I don't actually use angular-server myself in any of my projects.


Openglobus build error in finding package namespaces and classes in Angular project

Hello, I'm having trouble trying to install Openglobus to use it in an Angular project.
I have followed the exact steps described in the tutorial for framework integrations, but when I try to compile the project (using 'ng build') with the basic example, it shows the following errors (This is a fragment of the full list of errors, but they are all similar):

It seems that is not getting its own imports and exports correctly, because the classes that cannot be found do exist in the correct folders. I can't figure out why, because this error has only happened to me in Angular with this package.
I downloaded the latest stable version of Openglobus: 0.15.1, and the Angular and Node version I am using are the following:

If anyone knows anything about why this problem may occur, I would be very grateful, because this library looks amazing and I would like to love to use it and learn it instead of other map libraries.
Thanks in advance.

@dariodltg did you try with tsconfig.json compilerOptions>strict set to false?

I tried again and I see it not working. There is something wrong in the generated d.ts files.

this is a draft of something which can fix the types generation
https://github.com/openglobus/openglobus/pull/641/files
@Zemledelec

@dariodltg did you try with tsconfig.json compilerOptions>strict set to false?

Yes, I tried with that and still not working

yep @dariodltg
it will require a little bit of work on our side to make it work. I'm discussing with @Zemledelec the best way to solve this issue.


fix(amm)!: buy_price calculation

Description
Fee in buy_price calculation is wrongly assigned to the amount_out. The correct operation order is to compute amount_in first, and then apply fee to this value in the next step.

Btw i dont think this is a breaking change. IT is just implementation change but it does not break anything.

You are right. A change in behavior to fix a bug is not considered as a breaking change.


Option to erase projects

I cannot erase projects created, can you create pls the option?.
Rgds

Thanks for posting this issue :)
Great catch. We're going to implement it, most likely this week.
I will update you on this once it's deployed.


ng-style with background image

Hi there.
Can i use something like this?

{{slide.body}}

Because right now i didn`t see backgound image..

so? any ideas?

Yes you can but ng-style accept an expression, should be like this ng-style="{'background-image': 'url(/images/slides/{{ slide.image}})'}".


Extended the Exec functionality so that it can be used with named parameters.

I think the type Executor interface { .. can be unexported. I don't see a need for this to be exported right now, and would like to keep the API clean.

Agreed and changed.

Thanks!


[fix][function] Fixed error when user starts with the pulsar functions local runner

Fixes #10419
Motivation
Function Local runner: Invalid signature file digest for Manifest main attributes.
Modifications
Add artifactSet to pom.xml for pulsar-functions-local-runner.
Depend on Apache Maven Shade Plugin Doc
Verifying this change

[ ] Make sure that the change passes the CI checks.

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@BewareMyPower I have added this one to 2.8.4, if you have already started the release process, please move it to 2.8.5

@codelipenghui No. I might have time to begin the release process next week. There are only very few PRs that need to cherry-pick, I will confirm all of them this Friday.


Provide unit tests for sha256Validator

Provide unit tests for sha256Validator

Implemented in https://github.com/RedHatInsights/insights-data-schemas/pull/50

Implemented in https://github.com/RedHatInsights/insights-data-schemas/pull/50


WIP: Refactor backend refactor

Ignore most of this for now. I just want to show the new idea for image loading. See packet, pipeline, and preprocessing for examples. The rest is not up to date

Color calibration and rendering have been updated to match

I'm going to do another pass going over target this time, but the rest is a better quality. Please let me know what your thoughts are on this


[manuf] Add support for loading SRAM program from ELF files

See issue #18635 and original PR #18844.
The first 3 commits are that of #18933 since Github does not support PRs on PRs.

Looks like you need to run buildifier on sw/host/opentitanlib/BUILD.

Ah damn I missed the buildifier step when splitting the PR :(


Release Plan

Release plan until Apr 15 / 2017:

[ ] Switch to full Linux environment from OS X.

[ ] Use containers both in development and production.

Moved to: https://github.com/nbusy/biz/issues/1


WIP/Tests | Widen test code coverage

WIP - running this through CI and Codecov to make sure my local coverage figures align.
This PR ensures that the public API surface for SqlDataRecord and SqlMetaData are covered by tests. It also expands coverage of some of the basic data validation on SqlParameter and SqlCommand.

@edwardneal Did you look at the code coverage report for "inspiration" ?

I did; Codecov aligns with it:

SqlDataRecord.cs
SqlDataRecord.netcore.cs
SqlDataRecord.netfx.cs
SqlMetaData.cs

The code coverage for SqlDataRecord is currently ~75%, where I expect this PR will bring it to close to 100% in the code coverage report. The code paths which aren't covered are ones which can't ever be called and are due to be removed; once that happens I expect these two files will hit 100%.
SqlParameter is a much larger class, and it's got a custom TypeConverter which doesn't appear to have test coverage. I've added a few tests for basic validation, but the class will need more work here.


make more descriptions in magic reference

many parameters like this don't have enough descriptions, so it's hard to understand the effect of the parameter
at least show the type of the parameter(boolean etc)

I do wish I can help with the wiki, but that's somewhat difficult when I have no clue what some parameters do at all...

I do wish I can help with the wiki, but that's somewhat difficult when I have no clue what some parameters do at all...

same, that annoyed me su much when i want to make some skills

i bet Nathan doesn't know what they are for either

i bet Nathan doesn't know what they are for either

He likely did at one point, but there are so many obscure parameters like the use_parent_source and the god knows how many unlisted ones like use_target_location, plan: , the one which makes projectiles follow your crosshair, the difference between push and speed, etc...


fix : create flutter admob example

fixes #3
Added the admob and tiki sdk dependency.
Implemented the admob logic but running on test mode for now
Added the tiki dependency.
This is how the app looks and works for now.
https://user-images.githubusercontent.com/90508384/235448312-295258c0-25ca-4856-97e3-77c46c15b393.mp4

When we trigger the opt out button in the settings method of the offer the onAccept() functionality of the offer works as mentioned in the lib/home_screen.dart. This should not happen I guess. (Probably a bug?)

@Harshit933 merged this to a local branch in the repository. I will create a new PR with this local branch for review.


Replace login with log in when used as a verb

Per issue 294 this change changes 'login' to 'log in' when the phrase is used as a verb.

@rriehle thanks!

Just released this under v1.10. Thank you @rriehle !


AccountDetailsFS: History modal does not work properly on different chains

any screenshots

@Nick-1979

WORK IN PROGRESS


Fix issues with Worx Landroid

The obj["state"] contains already several named return states as
following: "grass cutting", "trapped recovery", "searching wire",
"following wire", "searching home", "home", "idle"
And with the batteryChargerState also the "charging"
Fixes #455
Breaking Change:
The worxlandroid sensor
Description:
Related issue (if applicable): fixes #455
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hello @geraldhansen,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

c3a559cb6c6adfd6a0c03a6a91c7b2904dc261e0 - This commit has something that looks like an email address (gerald.hansen@cloud.ionos.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hi @geraldhansen,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I use this change in my custom_components since a while and have for example an alert configured if the mower is in idle for 2 minutes. That means he is trapped and needs manual help.

It seems, that I linked the wrong issue - the correct one will be https://github.com/home-assistant/hassio/issues/455

Hi there, @geraldhansen!
Thanks for opening up a PR! 🎉
However, there are a lot of unrelated commits in this PR. Could you please clean up a bit by rebasing this PR? 👍

Please update the breaking change paragraph to briefly describe what has changed and what the user needs to do to cope with the breaking change.

@geraldhansen any updates on this? :)

How do I comment the breaking change paragraph? Inside the git commit?

You can alter the breaking change paragraph in this PR's body e.g. where it currently says:

Breaking Change:
The worxlandroid sensor

got it.

Thanks!


Wrong display when 'briopt' contains "sbr" and 'nobreakindent'

Problem:  Wrong display when 'breakindentopt' contains "sbr" and
'showbreak' and 'nobreakindent' are set.
Solution: Always reset wlv->need_showbreak regardless of the values of
'breakindent' and 'showbreak', as they aren't checked when
setting wlv->need_showbreak.

Another solution is to check the value of w_p_bri before checking the value of w_briopt_sbr, but that won't be necessary if wlv->need_showbreak is update consistently, and I think it's a bit strange for wlv->need_showbreak to always remain true when some options aren't set.

thanks


lock timepoint mutex

This seems to fix the TSan error reported in #9392.

This won't work - the iree_hal_semaphore_cancel_timepoint method cannot be called with the lock held - it takes the lock itself.

This causes a hang in local-task_embedded-elf_semaphore_test
^C
Thread 1 "local-task_embe" received signal SIGINT, Interrupt.
futex_wait (private=0, expected=2, futex_word=0x7b2800000010) at ../sysdeps/nptl/futex-internal.h:146
146	../sysdeps/nptl/futex-internal.h: No such file or directory.
(gdb) bt
#0  futex_wait (private=0, expected=2, futex_word=0x7b2800000010) at ../sysdeps/nptl/futex-internal.h:146
#1  __lll_lock_wait (futex=futex@entry=0x7b2800000010, private=0) at lowlevellock.c:52
#2  0x00007ffff7e50fe3 in __GI___pthread_mutex_lock (mutex=0x7b2800000010) at ../nptl/pthread_mutex_lock.c:80
#3  0x00000000002d5b00 in pthread_mutex_lock ()
#4  0x0000000000387426 in iree_mutex_lock (mutex=0x7b2800000010) at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/base/internal/synchronization.c:249
#5  iree_slim_mutex_lock (mutex=mutex@entry=0x7b2800000010) at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/base/internal/synchronization.c:503
#6  0x0000000000351479 in iree_hal_semaphore_cancel_timepoint (semaphore=0x7b2800000000, timepoint=timepoint@entry=0x7bb000000060)
    at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/utils/semaphore_base.c:244
#7  0x000000000034f1fb in iree_hal_task_semaphore_multi_wait (wait_mode=wait_mode@entry=IREE_HAL_WAIT_MODE_ALL, semaphore_list=<optimized out>, semaphore_list@entry=0x7fffffffd4a0, timeout=...,
    event_pool=0x7b6400000000, block_pool=block_pool@entry=0x7b7400000070) at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/drivers/local_task/task_semaphore.c:396
#8  0x000000000034b36f in iree_hal_task_device_wait_semaphores (base_device=0x7b7400000000, wait_mode=(unknown: 0x10), semaphore_list=0x80, timeout=...)
    at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/drivers/local_task/task_device.c:353
#9  0x0000000000346ed6 in iree_hal_device_wait_semaphores (device=0x7b7400000000, wait_mode=IREE_HAL_WAIT_MODE_ALL, semaphore_list=0x7fffffffd4a0, timeout=...)
    at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/device.c:283
#10 0x0000000000330f34 in iree::hal::cts::semaphore_test_WaitAllButNotAllSignaled_Test::TestBody (this=this@entry=0x7b0c00000270)
    at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/cts/semaphore_test.h:151
#11 0x00000000003d1e70 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void> (method=<optimized out>, location=0x23d839 "the test body", object=<optimized out>)
    at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2607
#12 testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void> (object=object@entry=0x7b0c00000270, method=<optimized out>, location=0x23d839 "the test body")
    at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2643
#13 0x000000000039c7d0 in testing::Test::Run (this=this@entry=0x7b0c00000270) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2682
#14 0x000000000039e3c3 in testing::TestInfo::Run (this=0x7b4400000a00) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2861
#15 0x000000000039f2ad in testing::TestSuite::Run (this=<optimized out>) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:3015
#16 0x00000000003b5d79 in testing::internal::UnitTestImpl::RunAllTests (this=this@entry=0x7b5400000000) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:5855
#17 0x00000000003d31a0 in testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (method=<optimized out>,
    location=0x22b0ca "auxiliary test code (environments or event listeners)", object=<optimized out>) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2607
#18 testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (object=object@entry=0x7b5400000000, method=<optimized out>,
    location=0x22b0ca "auxiliary test code (environments or event listeners)") at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:2643
#19 0x00000000003b4ec1 in testing::UnitTest::Run (this=<optimized out>) at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/src/gtest.cc:5438
#20 0x000000000034a49c in RUN_ALL_TESTS () at /usr/local/google/home/benoitjacob/iree/third_party/googletest/googletest/include/gtest/gtest.h:2490
#21 main (argc=1, argv=<optimized out>) at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/testing/gtest_main.cc:17
(gdb) frame 6
#6  0x0000000000351479 in iree_hal_semaphore_cancel_timepoint (semaphore=0x7b2800000000, timepoint=timepoint@entry=0x7bb000000060)
    at /usr/local/google/home/benoitjacob/iree/runtime/src/iree/hal/utils/semaphore_base.c:244
244	  iree_slim_mutex_lock(&semaphore->timepoint_mutex);
(gdb) l
239	    iree_hal_semaphore_t* semaphore,
240	    iree_hal_semaphore_timepoint_t* timepoint) {
241	  if (!semaphore || !timepoint) return;
242	  IREE_TRACE_ZONE_BEGIN(z0);
243
244	  iree_slim_mutex_lock(&semaphore->timepoint_mutex);
245
246	  // NOTE: if the semaphore is NULL then the timepoint has already been issued.
247	  // The caller is expected to know it's safe to still use the timepoint struct
248	  // even if such a race is possible.
(gdb) info threads
  Id   Target Id                                             Frame
* 1    Thread 0x7ffff7a1b340 (LWP 3493376) "local-task_embe" futex_wait (private=0, expected=2, futex_word=0x7b2800000010) at ../sysdeps/nptl/futex-internal.h:146
  2    Thread 0x7ffff57ff640 (LWP 3493380) "local-task_embe" 0x0000000000298cfe in __sanitizer::internal_usleep(unsigned long long) ()
  48   Thread 0x7ffff4ffe640 (LWP 3493426) "iree-poller"     0x00007ffff7b0d976 in __ppoll (fds=0x7b6c00000420, nfds=1, timeout=<optimized out>, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:48
  49   Thread 0x7ffff0dff640 (LWP 3493427) "iree-worker-0"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b80000002c8, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff0dbf0d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  50   Thread 0x7ffff17f7640 (LWP 3493428) "iree-worker-1"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000458, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff17b70d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  51   Thread 0x7ffff1ff8640 (LWP 3493429) "iree-worker-2"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b80000005e8, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff1fb80d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  52   Thread 0x7ffff47fd640 (LWP 3493430) "iree-worker-3"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000778, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff47bd0d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  53   Thread 0x7ffff3ffc640 (LWP 3493431) "iree-worker-4"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000908, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff3fbc0d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  54   Thread 0x7ffff37fb640 (LWP 3493432) "iree-worker-5"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000a98, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff37bb0d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  55   Thread 0x7ffff2ffa640 (LWP 3493433) "iree-worker-6"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000c28, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff2fba0d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74
  56   Thread 0x7ffff27f9640 (LWP 3493434) "iree-worker-7"   0x00007ffff7e5b0fa in __futex_abstimed_wait_common64 (futex_word=futex_word@entry=0x7b8000000db8, expected=expected@entry=0,
    clockid=clockid@entry=0, abstime=abstime@entry=0x7ffff27b90d8, private=private@entry=0, cancel=cancel@entry=true) at ../sysdeps/nptl/futex-internal.c:74


docs: added Code of Conduct

To complete the recommended community standards and encourage healthy contributions and build communities.

this is a dirty PR practice, but prefer the community_standards branch
thank you 🙏


Global or context managed threadpools

Sometimes, it's difficult to avoiding doing a bit of blocking computation (e.g., to calculate dtypes #64).
With the current implementation of dask, it takes about 100 ms to start up a threadpool to start executing tasks, unless I manually specify the basic get method. I suspect we could eliminate most of this delay if we only created the threadpool once.
Two possible solutions:

Create a global threadpool the first time the relevant compute method is used. This is a little unclean, but would be highly practical. I think numexpr does something like this.

Create a context manager to mark blocks of computation that should use the same pool, e.g.,
with dask.pooled:
    assert x.dtype == float
    assert (x > 0).all()
    x.store(dest)

We could roll this in to the set_options PR we just merged
pool = ThreadPool()
with set_options(pool=pool):
    ...


Multi-screen FancyZones lay-out

Description of the new feature / enhancement
The possibility for a FancyZones Lay-out that spans multiple screens (or at least 2).
Scenario when this would be used?
I would like my browser window to span (part of) both my two screens. Now I have to manually drag the side of the browser to expand it to two screens. Would be much easier if my browser could just snap to the multiscreen lay-out.
Supporting information
No response

Have you tried these settings yet?

/needinfo

No it hadn't noticed that option. I'll play around with it. Thanks a lot!!Op 17 aug. 2023 om 11:33 schreef "microsoft-github-policy-service[bot]" @.>:This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.>

Hey @Dontrader, does that option resolve your issues? If so I will close this issue in a few days.
Thanks in advance!

Yes it does. Thank you very much!Kind regards,DonVerstuurd vanaf mijn iPadOp 15 nov 2024 om 20:19 heeft Christopher Nguyen @.***> het volgende geschreven:
Hey @Dontrader, does that option resolve your issues? If so I will close this issue in a few days.
Thanks in advance!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Correct all Arabic 4.0 files

Link to hrvatski was missing in all files in footer

This an the Turkish had merge conflicts. I resolved them but I think the originals probably needed rebasing on up-to-date master before pushing.


Copyedit and organize decK best practices documentation

Where is the problem?
https://docs.konghq.com/deck/1.8.x/guides/best-practices/
What happened?
The best practices page for decK is a jumbled list of information. It's hard to parse in its current state and could use some organization. At the same time, it needs a writer's touch to clean up the language for clarity and readability.
File to edit: https://github.com/Kong/docs.konghq.com/blob/main/app/deck/1.8.x/guides/best-practices.md
Examples from the page

A run-on sentence that isn't using proper punctuation:
"Declarative configuration is for … configuration, it is not meant for end-user data, which can easily grow into hundreds of thousands or millions."
"Process" is singular when it should be plural: "Multiple process will step on each other"

What did you expect to happen?
Clear, simple language in accordance with our style guide.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

Can I take this issue please? @lena-larionova Please assign it to me

@lena-larionova I was done with the 2 issues I was assigned to. So, I pretty much picked this up and pushed the required changes for this Issue as well. Feel free to assign this to me.


Adding Sandbox Exporter resource

Adding a utility that allows users to export data from ITS DataHub's CV Pilot data sandbox based on pilot site, message type, and generatedAt date range. The utility will also export the data into a merged CSV or JSON file based on user preference.

Thanks for the feedback! I agree that it's best to remove references to hard coding credentials. Those references have been removed and I've created a GitHub issue for tracking adding of unit tests. I've also made some minor fixes to the code and README to make sure it supports Python 2.7 and Windows. Please review again when you get a chance.


[Question] How to restore a backup after I use backup-to-file and get .qcow2/.raw file

Question
How I restore a volume after I use backup-to-file.yaml and get mybackup.qcow2 or mybackup.raw, must be without using UI? What I need is to know how I restore a volume backup and make it available.
Thanks!

Using S3 to store backups.

Environment:

Longhorn version: 1.1.0
Kubernetes version: 1.20.

Additional context
Add any other context about the problem here.

Check the documentation: https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/recover-without-system/
Any reason you don't use the normal backup & restore with longhorn installed?
https://longhorn.io/docs/1.1.0/snapshots-and-backups/backup-and-restore/create-a-backup/
Or the CSI integration to create longhorn backups?
https://longhorn.io/docs/1.1.0/snapshots-and-backups/csi-snapshot-support/enable-csi-snapshot-support/

Check the documentation: https://longhorn.io/docs/1.1.0/advanced-resources/data-recovery/recover-without-system/
Any reason you don't use the normal backup & restore with longhorn installed?
https://longhorn.io/docs/1.1.0/snapshots-and-backups/backup-and-restore/create-a-backup/
Or the CSI integration to create longhorn backups?
https://longhorn.io/docs/1.1.0/snapshots-and-backups/csi-snapshot-support/enable-csi-snapshot-support/

Thanks for answer,
I need to perform a backup and restore 100% without UI. I know the CLI is in development, until it releases I needed some work around, I will study your links.
You may close this issue.


inputNumber buttons alignment

Steps to reproduce
When you hover on inputNumber component, the buttons appear on right, but if you try to increase o decrease values with these buttons, they appear that invrease button is high than decrease button.
Which browser?

Chrome 62
What is expected?
Seems that when hover over these buttons, an effect increase the button selected, but the size on increase and the size on decrease need to be the same.
What is actually happening?

The size of the buttons on hover are different. Size on increase button are greater that size on decrease button.
Reproduction Link

Easy to see only in the examples on your page.

I though this was on purpose to be honest, lol


Builder mode performance issues

In the following example, the Builder version is 16x slower:
with print_time():
    p = Cylinder(20, 20)
    p += TrapezoidalThread(2*20+2, 2, 60, 10)

with print_time():
    with BuildPart() as p2:
        Cylinder(20, 20)
        TrapezoidalThread(2*20+2, 2, 60, 10)

gives:
0.5091060638427734s
8.107296800613403s

This is very interesting - the difference in time is just in time it takes to call TrapezoidalThread.  The Algebra result also looks correct while the Builder version is missing some of the thread - curious! Some good clues here.

Here's another slightly tweaked version, that predictably works more quickly and interestingly is not missing any thread:
from build123d import *
from bd_warehouse.thread import *
import time
start_time = time.time()
th = TrapezoidalThread(2*20+2, 2, 60, 10)
with BuildPart() as p3:
    Cylinder(20, 20)
    add(th)
print("--- %s seconds ---" % (time.time() - start_time))

Time is approximately 2x the algebra version above.

I think I know what is happening here.  The thread is a Compound/assembly composed of 4 complete loops and a top and bottom loop (6 Solids).  Builder mode extracts the Solids for the fuse operation (while Algebra fuses the Compound) which is causing the performance degradation.  Now I have to figure out why I coded it this way :)


fix(kradio): using !important on inline-block

Summary
Changes the .k-radio element to use display: inline-block instead of display: inline-block !important so it can be more easily overridden.
See also https://github.com/Kong/kongponents/pull/1381.
PR Checklist

[x] Does not introduce dependencies
[x] Functional: all changes do not break existing APIs and if so, bump major version.
[x] Tests pass: check the output of yarn test
[x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
[x] Framework style: abides by the essential rules in Vue's style guide
[x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
[x] Docs: includes a technically accurate README, uses JSDOC where appropriate

Comment: The "Publish Previews" step in the CI will fail whenever you need to re-run "Run Component Tests" because by the second run, there will already be a published version for the current commit. This step should really be skipped in that case.


MCUmgr additions for DirectXIP with revert.

Fromtrees up to a horizon.

a43107299f6d4217f6730ccccf6a0e771357c3ca should probably be here too

a43107299f6d4217f6730ccccf6a0e771357c3ca should probably be here too

Where is that thing, can not find it on main.

commit a43107299f6d4217f6730ccccf6a0e771357c3ca
Author: Dominik Ermel<EMAIL_ADDRESS>Date:   Mon Sep 25 13:47:32 2023 +0000

    doc/release-notes: Add info on downgrade prevention Kconfig

    Adds note on addition of
    MCUBOOT_BOOTLOADER_MODE_WITH_DOWNGRADE_PREVENTION
    to MCUboot Kconfig module.

    Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

https://github.com/zephyrproject-rtos/zephyr/commit/a43107299f6d4217f6730ccccf6a0e771357c3ca

zephyrproject-rtos/zephyr@a431072

Heh, I have skipped the release notes.

Added it now


RpmTest.java:58-63: Meaningful error on broken package....

The puzzle 110-69218d91 from #110 has to be resolved:
https://github.com/artipie/rpm-adapter/blob/c1edca1dd4af55475867d2ec86c4e39d9ace0b45/src/test/java/com/artipie/rpm/RpmTest.java#L58-L63
The puzzle was created by paulodamaso on 12-Jun-20.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@g4s8/z, @olenagerasimova/z please, pay attention to this issue


 This shows that the definition has never been used...

Please don’t do this. This just creates unnecessary conflicts with the glob_array3 branch.

I don't understand, I fix a definition that is not used in Jasmin. How can it create conflict?

The right fix would be to remove the broken dead code. Such a fix has been done in the other branch. I fear that this patch conflict with that patch.

I feel there is a misunderstanding. My fix is for coqword, not Jasmin. I don't know the spirit of coqword, but I guess it is more general than a tool for Jasmin, so maybe this definition makes sense even if it is not used in Jasmin.

Thanks for clarifying. I apologize for my hasty comments.


Rework the way stats are calculated

This may be too big of a change...
I was trying to understand how Grobid evaluates a model, and the best way I found to do that was to refactor the code.  It produces the same results in my limited testing.

No need to apologize.  I too have been busy, and I haven't even addressed the issue caught by CI.

Apparently two classes missing in the PR - LabelStat.java and Stats.java

Gah!  I'll commit them when I get home.

Coverage increased (+0.2%) to 38.528% when pulling 275606b3cc43ea552b2d2ae27b5e62942ff82259 on boumenot:pr-trainer-stats into 42bd35c91aef61d5fd51bef681dad2e9114695dd on kermitt2:master.

Tested on the PMC sample set (~2000 documents) and same results, let's merge, thanks !


Add env var guard

From https://github.com/percy/example-quickstart/blob/master/visual-tests.rb#L6-L12

Hey @joscha — we already do this inside of Percy::Anywhere.run (https://github.com/percy/percy-capybara/blob/master/lib/percy/capybara/anywhere.rb#L17). Did you hit a bug where that didn't work?

Nope, sorry, I didn't know it was integrated already, just saw that one example had it and the other didn't. 👍