[4.0] AnimationPlayer keeps playing audio after stopping

Godot version
4.0-dev (master)
System information
Win 11
Issue description
Reported by @ExquisiterEmil on Discord
I analyzed an issue regarding the animation player - it keeps behaving weirdly when using an AudioStreamPlayer and using the AnimationPlayer. After adding a couple of debug messages and following various weird calls (up to 5 calls to animation process during _stop_internal) I narrowed the issue down to the following use-case:

You have an AnimationPlayer
You have an AudioStreamPlayer within the AnimationPlayer
You position yourself somewhere "non position 0" in the timeline of the animation player (i.e. 'seek')
You try to stop the animation player by pressing the "Stop" symbol (+ it shouldnt be playing in the first place because you haven't pressed 'Play' yet)
The audio keeps playing but the bar resets to 0
You press "Stop" again and it stops the audio.

From what I was able to analyze, the following process happens:

When you click within the animation player, you trigger a _timeline_changed signal, this is being consumed by the AnimationPlayerEditor's "Seek Value changed" function, which in turn "stops" the player, seeks the position, and "starts" the player again. (See animation_player_editor_plugin.cpp:1169 -> animation_player.cpp:1984) -> Assumtion Nr. 1

During the press of "Stop" you basically setting the seek value back to "0", and since this is another change of the seek valuje, it triggers another round-trip of seeking and pausing and unpausing the audioplayer.

If you press once again, since the seek position is now "0", the round trip isn't triggered, and the animation processing isn't started, hence the audio doesn't start playing again. -> Assumtion Nr. 2

Assumtion Nr. 1:

animation_player.cpp _stop_internal doesn't reset "is_stopping" to the proper previous state and just overrides it with "false" upon finish seeking (albeit setting "playing" to false)

Assumtion Nr. 2:

I assume this behaviour like this, due to observing the stack trace of the calls, which only tripped my breakpoint once, here over at _stop_internal

This, in turn, means that frame->set_value(0); does not trigger a seek again, which makes the audio player shut up.

Sadly, I have no idea how we could fix this, maybe instead of checking against the if (!nc->node || is_stopping) { block, we may also add a || !playing? But maybe we are too early for this to trigger - someone with more experience in the animationplayer may be able to help out here.
If I should add anything to my analysis, let me know and I'll try to give more insight!
Steps to reproduce
Listed above, download example project, open, click AnimationPlayer, seek somewhere, try to stop, ...
Minimal reproduction project
AudioPlaybackTrackIssue.zip

I remember changing the editor to preview the audio during seek, but indeed if there is a long audio such as bgm placed, it causes a problem where it keeps playing. There are two possible solutions:

Do not play audio when seeking in the editor in the first place. This should be the same as the previous behavior
Stop the playback by pressing the "stop" button

1.) would be great for consistency, 2.) should work regardless, without having to press it twice. :-)

Alternatively, do you think it would make sense to add a "autoplay" button in the AnimationEditorPlugin? Then anyone could toggle that playback whenever they'd want it or not.

Do you mean the audio preview button? I think it's technically possible, but I'll have to give it some thought to see if it would be clean from an architectural design standpoint.

No, I mean the regular Animation Player. I attached a video, maybe this makes it a bit more clear.
godotaudio.webm

Do not play audio when seeking in the editor in the first place. This should be the same as the previous behavior

Pretty sure previously it would play the audio too. Or at least I remember there was a similar issue with audio tracks.

Thank you @kuhnchris for creating the issue. I'd like to point out, there is a bunch of other concerning things with the Animation player and audio. At first, when positioning somewhere within the range of an Audio key and having LMB pressed, it keeps repeatedly restarting the sound, resulting in very ear-blasting sounds. You can see the issue in this video (don't watch with very high volume!):
https://user-images.githubusercontent.com/53947784/214711467-8b8f1758-9ebd-4380-919e-539346282b11.mp4
I hope this can also be fixed, as to protect the ears of the users 👂

I mentioned a bunch of other usability problems in a new issue because they go far beyond the scope of this thread.


Clarify proxy fallback behavior

I am currently working on #178 and extended the tests for the proxy selection mechanism, especially when the env variables like HTTP_PROXY and HTTPS_PROXY are present. One thing that I've observed is the fallback behavior:

no ENV vars: HTTPS DSNs can fallback to HTTP proxies (see test)
only HTTP_PROXY env var: no fallback for HTTPS DSNs, i.e. no proxy is auto-selected

Is that behavior intended or a bug? In either case, my PR for #178 will also include tests (and potential fixes) for that.

The http_proxy envvar is supposed to be used for HTTPS DSNs (i.e. exact same behavior as with client options in code), so this is a bug.
I'm very grateful that you're working on this! It's been a pain point for many people but it's unclear how to fix it without writing a lot of custom code.


Add wolfictl bump subcommand

From the help text:
wolfictl bump increases the epoch field in melange configuration files

The bump subcommand allows increments version numbers in packages. For now it will only bump epoch numbers but a future version will allow users to control versions expressed in semver.

wolfictl bump can take a filename, a package or a file glob, increasing the version in each matching configuration file

This works by doing a string replacement on the epoch field in the yaml configs. It does no re-marshaling at all as it was causing a huge diff.
Signed-off-by: Adolfo García Veytia (Puerco<EMAIL_ADDRESS>

FWIW related to the above comment, we should be able to use dag to figure out the downstream packages that need their epoch bumped.


Secure storage for the secretKey?

Hello,
as this is a reference application I can't understand why it should be required that the secretKey for the SAP CP Document Repository is stored in a property file:
config.properties. I would think that can't a good example for production code. Isn't there a place in the SAP Cloud Platform Cockpit where such security critical information can be provided to the app in a secure fashion instead of storing it in a versioned file for the source code.
Best regards
Gregor

Hi Gregor,
the repository key has quite some historics and originates from SAP (HANA) Cloud Platform days when it was THE authentication mechanism for apps on their repositories.
Nowadays the main authentication on a document service repository is a dedicated client certificate being present on every app/VM. It is used when establishing the ssl connection to the document service.
A repository created in account A can only be accessed by apps running in account A (but not by apps running in account B) and this isolation is secured by the aformentioned certificate.
Some more details on this can be found here: https://help.sap.com/viewer/b0cc1109d03c4dc299c215871eed8c42/Cloud/en-US/f639d68ff43347e6ac0453541b5daada.html
As account authentication and isolation is enforced by the client cert now, the repository key has "lost" its importance. Theoretically it can be used to e.g. only allow app X in account A to access a repository R and at the same time ensure that app Y in account A cannot access this repository R, but that's a more rare usecase given the fact that typically people who are allowed to deploy app X or App Y can reset repository keys as well or simply redeploy app X or Y again to extract the repository key.
Given that, it's not a security issue to store the repository key in plain text, but I agree that the reference app could be improved by showing the usage of the CP password storage which people might need for other scenarios anyway.
Regards,
Dieter

Thanks Dieter for the detailed information.
The password store usecase is something that we showcased in the Authorization Management API scenario with ESPM. So, i think it would be best when enhancing the app, we can try out the client certificate for espm use case.

Just to be clear: you are already using the client certificate, otherwise you wouldn't be able to access your repository (it's happening automatically, the preprovisioned OpenCMIS clients already take care of the client cert authentication)


Adding "Close All with same type" when right-clicking tabs

Background: Right click an opened tab, we will get some options for closing tabs, like Close, close Others, Close to the Right, Close Saved and Close All;
Feature: Could you consider adding one more option to close all the tabs with the same file suffix, or "Close All with same type"?
Thank you guys.

I'm planning to work on this feature request!

I'm planning to work on this feature request!

Cool~

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


build release tarball: open source it

change it from being given a branch to working on the current checkout
change it to work with create_distro_tarball, which was already opensourced
make it build openssl 1.0.2 if needed

Once this is in I'll backport it to branch 34

@morlovich ready for another round of review

I don't think you actually pushed it?

@morlovich

I don't think you actually pushed it?

Sorry, I did push it, but I forced pushed it because I wanted to squash down to one commit to cherry-pick onto 34 for testing.

I think you could have squashed it afterwards, at the merge step? Anyway, Looking..

Backported to branch 34 as<PHONE_NUMBER>0924420eef235b366b2ab8f8e046cd


python310Packages.dvc: 3.8.1 -> 3.14.0

Diff: https://github.com/iterative/dvc/compare/refs/tags/3.8.1...3.13.2
Changelog: https://github.com/iterative/dvc/releases/tag/3.13.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I am seeing a hash mismatch error now. Did upstream retag?

Result of nixpkgs-review pr 247914 run on x86_64-linux 1

6 packages built:

dvc (python310Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python310Packages.dvc.dist)
python310Packages.dvclive
python310Packages.dvclive.dist

Result of nixpkgs-review pr 247914 run on aarch64-darwin 1

2 packages marked as broken and skipped:

dvc-with-remotes
dvc-with-remotes.dist

4 packages built:

dvc (python310Packages.dvc)
dvc.dist (python310Packages.dvc.dist)
python310Packages.dvclive
python310Packages.dvclive.dist

I cannot reproduce the dvc-task failure on ofborg on x86_64-darwin through Rosetta. I do still see omegaconf failure, but that is unrelated to this change.


Cannot upload IPA to testflight

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Trying to upload via fastlane ends with an exception.
The exception doesn't say much and very not informative.
Tried to run it with --verbose didn't reveal much
Command executed
fastlane upload_to_testflight
Complete output when running fastlane, including the stack trace and command used

[17:00:49]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[17:00:49]: Going to upload updated app to App Store Connect
[17:00:49]: This might take a few minutes. Please don't interrupt the script.
[17:00:50]: [iTMSTransporter] java.lang.reflect.InvocationTargetException
[17:00:50]: [iTMSTransporter] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[17:00:50]: [iTMSTransporter] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[17:00:50]: [iTMSTransporter] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[17:00:50]: [iTMSTransporter] 	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.launcher.Application.start(Application.java:450)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.launcher.Application.main(Application.java:947)
[17:00:50]: [iTMSTransporter] Caused by: java.io.IOException: Could not connect to any repositories
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.misc.RemoteBundleRepository.getRepositoryUriAndEtag(RemoteBundleRepository.java:227)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.misc.RemoteBundleRepository.loadResourcesFromRepository(RemoteBundleRepository.java:141)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.bootstrap.BootstrapperPhase1.downloadNeededBundles(BootstrapperPhase1.java:247)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.bootstrap.BootstrapperPhase1.bootstrap(BootstrapperPhase1.java:97)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.bootstrap.BootstrapperPhase1.bootstrap(BootstrapperPhase1.java:59)
[17:00:50]: [iTMSTransporter] 	at com.apple.transporter.launcher.Launcher.launchBootstrapper(Launcher.java:37)
[17:00:50]: [iTMSTransporter] 	... 6 more
[17:00:50]: iTunes Transporter output above ^
[17:00:50]: The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
+------------------+------------------------------+
|                  Lane Context                   |
+------------------+------------------------------+
| DEFAULT_PLATFORM | ios                          |
| PLATFORM_NAME    | ios                          |
| LANE_NAME        | ios upload_ipa_to_testflight |
+------------------+------------------------------+
[17:00:50]: Error uploading ipa file, for more information see above
+------+----------------------------+-------------+
|                fastlane summary                 |
+------+----------------------------+-------------+
| Step | Action                     | Time (in s) |
+------+----------------------------+-------------+
| 1    | Verifying fastlane version | 0           |
| 2    | default_platform           | 0           |
| 💥   | upload_to_testflight       | 13          |
+------+----------------------------+-------------+
[17:00:51]: fastlane finished with errors
[!] Error uploading ipa file, for more information see above

Environment

➜ fastlane env
[✔] 🚀
[17:03:08]: fastlane detected a Gemfile in the current directory
[17:03:08]: However, it seems like you didn't use `bundle exec`
[17:03:08]: To launch fastlane faster, please use
[17:03:08]:
[17:03:08]: $ bundle exec fastlane env
[17:03:08]:
[17:03:08]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[17:03:17]: Generating fastlane environment output, this might take a few seconds...
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.15.7

Ruby
2.7.2

Bundler?
false

Git
git version 2.24.3 (Apple Git-128)

Installation Source
/usr/local/Cellar/fastlane/2.174.0/libexec/bin/fastlane

Host
Mac OS X 10.15.7 (19H524)

Ruby Lib Dir
<EMAIL_ADDRESS>

OpenSSL Version
OpenSSL 1.1.1i  8 Dec 2020

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
12.4

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
fastlane_version "2.25.0"

default_platform :ios

platform :ios do

    lane :upload_ipa_to_testflight do
      upload_to_testflight(
        username<EMAIL_ADDRESS>        skip_waiting_for_build_processing: true,
        ipa: "xxxxx.ipa"
        )
    end

end

No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.174.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.4.0

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.3

claide
1.0.3

colored2
3.1.2

nanaimo
0.3.0

xcodeproj
1.19.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

plist
3.6.0

public_suffix
4.0.6

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

artifactory
3.0.15

babosa
1.0.4

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.79.0

faraday-net_http
1.0.1

ruby2_keywords
0.0.4

faraday
1.3.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.7

faraday_middleware
1.0.0

fastimage
2.2.2

gh_inspector
1.1.3

json
2.3.0

mini_magick
4.11.0

rubyzip
2.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.1

dotenv
2.7.6

bundler
2.1.4

naturally
2.2.1

simctl
1.6.8

jwt
2.2.2

uber
0.1.0

declarative
0.0.20

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.15.0

signet
0.14.1

memoist
0.16.2

os
1.1.1

googleauth
0.15.1

httpclient
2.8.3

google-api-client
0.38.0

google-cloud-env
1.4.0

google-cloud-errors
1.0.1

google-cloud-core
1.5.0

rexml
3.2.3

webrick
1.6.0

google-apis-core
0.2.1

google-apis-iamcredentials_v1
0.1.0

google-apis-storage_v1
0.2.0

rake
13.0.3

digest-crc
0.6.3

google-cloud-storage
1.30.0

emoji_regex
3.2.1

jmespath
1.4.0

aws-partitions
1.426.0

aws-eventstream
1.1.0

aws-sigv4
1.2.2

aws-sdk-core
3.112.0

aws-sdk-kms
1.42.0

aws-sdk-s3
1.88.0

uri
0.10.0

forwardable
1.3.1

logger
1.4.2

cgi
0.1.0

date
3.0.0

timeout
0.1.0

stringio
0.1.0

zlib
1.1.0

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.2.0

strscan
1.0.3

delegate
0.1.0

fileutils
1.4.1

io-console
0.5.6

open3
0.1.0

singleton
0.1.0

yaml
0.1.0

psych
3.1.0

mutex_m
0.1.0

generated on: 2021-02-17

Even I am unable to upload to TestFlight using fastlane.
Details:
Fastlane version: 2.174.0
Error:
ERROR ITMS-90060: "This bundle is invalid. The value for key CFBundleShortVersionString '.8.12' in the Info.plist file at '${bundlePath}' must be a period-separated list of at most three non-negative integers. Please find more information about CFBundleShortVersionString at
Note: 1. We are using the right version of our app and somehow it is logging wrong error.
2. Issue is failing on upload ie, on pilot.
ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV #"
pilot(
app_identifier: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier),
skip_submission: true,
skip_waiting_for_build_processing: true
)

upload working fine on appcenter

@Suri1044 the ERROR ITMS comes directly from Apple. The short version string is incorrect. It can't start with a . (dot). This has nothing to do with this issue and fastlane.
@yargolan I think there was a similar issue. The problem is that the error message gets truncated and does not show the full issue of ITMSTransporter (Apple's upload tool) Can you upload via the Transporter.app without any problems?


Update datasearch.js with main (handle exceptions in queries)

@CreaturePhil takes care of updating from pokemon-showdown. Thanks for opening this but it will be taken care of when we merge over other updates.

I did add all the other updates @TheFenderStory in my second commit.
It would be kind of u to merge these

what second commit this PR only has one commit


PyPI releases

Currently a few interdependencies between python packages are done as direct git commit references.
We should move to the more standard approach of having packages released on PyPI - ideally automatically when something is tagged - and then use those packages in the downstream tooling.
First part of this is to identify what would be affected.
Second part is to release packages to PyPI
Third part is to update the dependencies to use those PyPI packages.

Work in progress for ontology-utils on branch af-cleanup as part of other changes.


Ignore git tracking of all config files

Feature Request
More of a question open for discussion, but it would be nice to add all configuration files to the git ignore. That way we have to be quite deliberate about updating them. I think this has three benefits:

Any keys will not accidentally be updated (ie. The EIA API key)
Simplifies switching between branches if you want to try config options on different features
Ensures our default config is tested and we know works

Just a suggestion! If other people are not into this, thats fine too! :)
Suggested Solution
I thought I added the api config to the gitignore in PR #238, but mine is still being tracked. I guess I messed it up haha.
Additional Info
No response

Good idea, I support!


Cannot build iOS Xcode after upgrading to Xcode 14

Hi,
There are some errors when I try to build iOS for my project in Xcode after upgrading to Xcode 14.
Flutter version 3.3.2
image_cropper version 3.0.0
Here is the errors messages in Android Studio, How to fix it?
Running Xcode build...
Xcode build done.                                           21.2s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    Writing result bundle at path:
      /var/folders/cc/3b8b8j7s3nd92qwt4_6zgzhh0000gn/T/flutter_tools.r2bQYG/flutter_ios_build_temp_dirKtqe3A/temporary_xcresult_bundle

    While building module 'TOCropViewController' imported from /Users/test/.pub-cache/hosted/pub.dartlang.org/image_cropper-3.0.0/ios/Classes/FLTImageCropperPlugin.m:2:
    In file included from <module-includes>:1:
    In file included from /Users/test/StudioProjects/app/ios/Pods/Target Support Files/TOCropViewController/TOCropViewController-umbrella.h:18:
    /Users/test/StudioProjects/app/ios/Pods/TOCropViewController/Objective-C/TOCropViewController/TOCropViewController.h:137:50: error: unknown type name 'TOCropToolbar'
    @property (nonnull, nonatomic, strong, readonly) TOCropToolbar *toolbar;
                                                     ^
    /Users/test/StudioProjects/app/ios/Pods/TOCropViewController/Objective-C/TOCropViewController/TOCropViewController.h:137:1: error: property with 'retain (or strong)' attribute must be of object type
    @property (nonnull, nonatomic, strong, readonly) TOCropToolbar *toolbar;
    ^
    2 errors generated.
    /Users/test/.pub-cache/hosted/pub.dartlang.org/image_cropper-3.0.0/ios/Classes/FLTImageCropperPlugin.m:2:9: fatal error: could not build module 'TOCropViewController'
    #import <TOCropViewController/TOCropViewController.h>
     ~~~~~~~^
    3 errors generated.
    note: Building targets in dependency order
    warning: Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'PromisesObjC' from project 'Pods')
    warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')
    warning: Run script build phase 'Thin Binary' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')

    Result bundle written to path:
      /var/folders/cc/3b8b8j7s3nd92qwt4_6zgzhh0000gn/T/flutter_tools.r2bQYG/flutter_ios_build_temp_dirKtqe3A/temporary_xcresult_bundle

Semantic Issue (Xcode): Unknown type name 'TOCropToolbar'
/Users/test/StudioProjects/app/ios/Pods/TOCropViewController/Objective-C/TOCropViewController/TOCropViewController.h:136:49

Semantic Issue (Xcode): Property with 'retain (or strong)' attribute must be of object type
/Users/test/StudioProjects/app/ios/Pods/TOCropViewController/Objective-C/TOCropViewController/TOCropViewController.h:136:0

Parse Issue (Xcode): Could not build module 'TOCropViewController'
/Users/test/.pub-cache/hosted/pub.dartlang.org/image_cropper-3.0.0/ios/Classes/FLTImageCropperPlugin.m:1:8

Encountered error while building for device.
Process finished with exit code 1

Hi @blue492, this issue seems like it is coming from the image_cropper plugin and should be reported on their repo.
Closing from here as this is not an issue. If you disagree or are redirected back here, kindly leave a comment below and I will reopen this.
Thank you


[Bug]: Unexpected token ':'

What happened?
Hi,
I'm following this tutorial (https://sibiraj-s.github.io/ngx-editor/introduction/) and I do exactly what it is said
ng new editortest2 (SCSS and SSR: yes)
cd editortest2
npm install ngx-editor

Then I put
import { NgxEditorModule } from 'ngx-editor';
into my component
and I add NgxEditorModule to my imports ... now the error is here.
Version
newest: "npm install ngx-editor" on ubuntu 24.04
Angular Version
newest under ubuntu 24.04
What browsers are you seeing the problem on?
Firefox
Link to reproduce
No response
Relevant log output
Unexpected token ':'

    at new AsyncFunction (<anonymous>)
    at instantiateModule (file:///home/johannes/angular/editortest2/node_modules/vite/dist/node/chunks/dep

20:12:36 [vite] Error when evaluating SSR module /main.server.mjs:
|- SyntaxError: Unexpected token ':'
    at new AsyncFunction (<anonymous>)
    at instantiateModule (file:///home/johannes/angular/editortest2/node_modules/vite/dist/node/chunks/dep-k5wXcrSr.js:54894:28)

20:12:36 [vite] Internal server error: Unexpected token ':'
      at new AsyncFunction (<anonymous>)
      at instantiateModule (file:///home/johannes/angular/editortest2/node_modules/vite/dist/node/chunks/dep-k5wXcrSr.js:54894:28)

Willing to submit a PR?
None (maybe later if I'm more advanced in angular/ts)

May be same as https://github.com/sibiraj-s/ngx-editor/issues/520

Getting the same error using Angular 17.3, did you find a solution? @jowin202

I had the same problem and solved adding
await import('ngx-editor');
at the end of ngOnInit after checking I'm in browser.
I don't know why it works but for me it does.

Yeah the reason it could be working is when you do await import it might excluded in the SSR compilation process.
The reason this happens is because, the underlying library prosemirror doesn't support SSR, reason here https://github.com/sibiraj-s/ngx-editor/issues/520#issuecomment-2010306994


Package request: python310Packages.wikitextparser

Project description
A simple to use WikiText parsing library for MediaWiki.
The purpose is to allow users easily extract and/or manipulate templates, template parameters, parser functions, tables, external links, wikilinks, lists, etc. found in wikitexts.
Metadata

homepage URL: https://pypi.org/project/wikitextparser/
source URL: https://github.com/5j9/wikitextparser
license: gpl-3.0
platforms: unix, linux

This is added in PR #253303.

The package was merged into master.


feat(Ontology): add "View associated genes" link if we don't have chr…

…omosome
Previously in Ensembl, where we have a chromosome, the ontology table offers a link to view xrefs on the karyotype, e.g.'View on karyotype'.
This change offers a link ("View associated genes") to the whole genome view if we don't have a chromosome.
This change also shows titles like "Locations of Genes associated with GO:0005634 nucleus" even if there is no karyotype image.
Related to ENSEMBL-4466.

As discussed with zhicheng and Nick, its better to have title "Gene information" above the table changed to "Genes associated with  .... " when there is no karyotype.
Closing this pull request and zhicheng will send a new PR.


GZip Compression & Nagle algorithm disabled

Disabled the nagle algorithm (which usually leads to better latency in TCP).
Also implemented GZip compression for large packets which increases synchronization speed between days dramatically (when not in lan).
Also added some network debugging code when compiled with NETWORKING_BENCHMARK conditional.

Thank you!


Add camdozaal Golems & update monsters_data.json

Description:
Adds the data for the four golems inside camdozaal.
I have a pr for the Ruins of Camdozaal following this to handle killing them.
Changes:

Adds the four golems from camdozaal.
Updated monsters_data.json.

[X] I have tested all my changes thoroughly.

This is failing the tests.

This is failing the tests.

fixed. issue was aliases weren't lowercase


Custom view for all tabs view

Hi
I want to make the background color of the tabs view to be gradient, how can i set one custom view for all the tabs
Thanks

Hi @stasberkman ,
You can create a xib file with the custom view (with background view and label) as required. And set this custom view as the navigationItem.titleView for each of the View Controllers.
Code snippet follows:
let firstViewController = storyboard
                .instantiateViewController(withIdentifier: "FirstViewController")
            firstViewController.title = "FIRST"

 let view = UIView()
 view.layer.masksToBounds = true
 view.contentMode = .scaleAspectFit
if let customView = Bundle.main.loadNibNamed("TabCustomView", owner: self, options: nil)?.first as? TabCustomView {

                customView.frame = CGRect(x: 0, y: 0, width: 30, height: 5   )
                customView.layer.masksToBounds = true
                customView.contentMode = .scaleAspectFit
                 view.addSubview(customView)
 firstViewController.navigationItem.titleView = view
}
let segmentController = SJSegmentedViewController()
segmentController.segmentControllers = [firstViewController, secondViewController]

Hope this helps!

Yes but if i want a gradient background color for the all segment view, i don't have a control of that.
for example this behaivour:

Currently, we don't have a direct way to work this out, We will try to include this in a new update.


Introduce dismiss event for text-expander-element

This PR is adding a new event, text-expander-dismiss, which the text-expander-element listens to. The event triggers the dismissal of the menu provided through the provider.
This will fix a few of the items specified in https://github.com/github/issues/issues/1119, mostly the ones related to existing suggestions flow.

Escape behavior is handled here since it is useful to have once with the introduction of multi-word
dismissal on pressing ArrowLeft/Right, as well as onClick anywhere outside the menu feels more specific to Github behaviour so it will be implemented on dotcom side (it will use this event)

The PR description needs to be updated to remove text-expander-dismiss event.


[Merge] Progeria with Progeroid Syndrome

Mondo term (ID and Label)
Progeroid Syndrome MONDO:0020732
Reason for deprecation
Listed under progeroid syndrome in the ontology is a list of diseases associated with this group defined by diseases of premature aging and common clinical manifestations. Also listed under progeroid syndrome is a term called progeria with 3 children (3 unique diseases that are also diseases of premature aging). There is no definition of progeria in the ontology. Further, upon looking up progeria, Mayo Clinic https://www.mayoclinic.org/diseases-conditions/progeria/symptoms-causes/syc-20356038 defines this term as a disease of premature aging also known as Hutchinson-Gilford progeria syndrome, however, these two terms should not be identical because not all progeroid syndromes are Hutchinson-Gilford progeria syndrome. Additionally, I do not think the 3 diseases currently listed as children of progeria should not be grouped separately from the other disorders of premature aging, they should be listed under progeroid syndrome and progeria should be merged with progeroid syndrome.
Term to be merged with
Progeria MONDO:0015333
Your nano-attribution (ORCID)
0000-0003-4830-7530

I agree that progeria vs. progeroid syndrome needs a clearer definition, but I do not think it is ontologically correct to merge these two. The "progeria" record reflect the OMIM Phenotypic series, which has only 3 children- HGPS, NGPS and WRS.
My understanding of the origins of the term 'progeroid' is that it describes disorders that are like progeria but somehow distinct; granted it's been a few years since I really worked on this topic, so my familiarity with the field is not current.
Also noting that many of the children of "progeroid syndrome" from @megankraus 's screenshot are no longer showing in the latest release on OLS4 viewer (https://www.ebi.ac.uk/ols4/ontologies/mondo/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FMONDO_0015333?lang=en). You may want to switch to the new ontology viewer. I just remembered this recent ticket, too: https://github.com/monarch-initiative/mondo/issues/1567 (I think this other ticket may also help clarify the distinction between progeria and progeroid)

Thank you @megankraus for creating this issue, and thank you @kanems for your comment.
@nicolevasilevsky we should probably ask experts whether "progeria" is really a different disease. The current MESHxref should definitely be moved to Hutchinson-Gilford progeria syndrome.
If "progeria" is a separate disease, we might need to remove it from being a child of "progeroid syndrome" (there was no evidence for this parentage).

I found a great review of progeroid syndromes here https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4958309/ .
It says " All progeroid syndromes are characterized by similar clinical features (Table 1), but their underlying mechanisms can vary depending on the mutated gene and the pathway that is consequently altered. Below, we have classified progeroid syndromes into two general categories based on the molecular pathway involved. The first group includes those syndromes caused by alterations in components of the nuclear envelope, such as Hutchinson-Gilford progeria syndrome (HGPS), Néstor-Guillermo progeria syndrome (NGPS), atypical progeria syndromes (APSs), restrictive dermopathy (RD) and mandibuloacral dysplasia (MAD). The second group consists of progeroid syndromes induced by mutations in genes involved in DNA-repair pathways, such as Werner syndrome (WS), Bloom syndrome (BS), Rothmund-Thomson syndrome (RTS), Cockayne syndrome (CS), xeroderma pigmentosum (XP), trichothiodystrophy (TTD), Fanconi anaemia (FA), Seckel syndrome (SS), ataxia telangiectasia (AT), ataxia telangiectasia-like disorder (ATLD), cerebroretinal microangiopathy with calcifications and cysts (CRMCC), and Nijmegen breakage syndrome (NBN). A subcategory of this group comprises dyskeratosis congenita (DC) and Hoyeraal-Hreidarsson syndrome (HHS), linked to mutations in components of the telomerase complex (see Box 1 for a glossary of terms) that cause telomere attrition."

@ahamosh could you please review this ticket and let us know your thoughts? Thank you! :)

All,  I am crazy busy for the next week, so can't look or think deeply.  Not sure about the three things in the OMIM PS1766670, but I don't think of short telomere syndromes as the progeroid syndromes.  Can you remind me about this after May 8?  I did ask Joanna to take a look at it.  Sorry!

Hi @ahamosh - no worries! We can discuss it on a future call. Thank you and have a good week!

From meeting with Ada on October 15th, 2024.
"progeria", MONDO:0020732

OMIMPS:176670; Ada said that they (OMIM) will delete this phenotypic series as it is not complete.
All children of this term should become children of "progeroid syndrome"

"progeroid syndrome" vs "premature aging syndrome"

progeroid syndrome = global premature aging (the patient looks like an old person)
premature aging syndrome = could be part of a person (e.g. a tissue) that age prematurely, but the aging is not global)
Note: one needs to be aging prematurely to have a "premature aging syndrome". Therefore, if a patient is born "old", this should not be considered a "premature aging".

Review of terms in the "premature aging syndrome" branch

'premature aging syndrome, Okamoto type' - MONDO:0011149

https://omim.org/entry/601811
old record, it is a "N=1" report.
Consider removing

'Flynn-Aird syndrome' - MONDO:0007624

https://omim.org/entry/136300
This is also an old record (1965)
Consider removing

'Hallermann-Streiff syndrome' - MONDO:0009318

https://omim.org/entry/234100
this disease is not a premature aging syndrome
TO DO: exclude SubClass_Of

'Ogden syndrome' - MONDO:0010457

https://omim.org/entry/300855
the aging-related phenotype is congenital (at birth), therefore this is not a "premature aging"
TO DO: exclude SubClass_Of


Design a send process

In order to achieve #40 we need to design a way of send data.

I have though something like:

For an only text version : sent only a csv file
For binary version send a zip with all the information

Some useful documentation could be

send react native


java.lang.SecurityException

When I ran this command : hadoop fs -mkdir /test1/test2.
I had the java exception : class "org.apache.hadoop.fs.LustreFileSystem"'s signer information does not match signer information of other classes in the same package.
Do you know what problem is.

Sorry for my late reply. There are typos in file src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem. I should use "#" instead of "//" for comments.

The patch is merged.


Update viewer.html for Internet Explorer Compatibility

If your Internet Explorer 11 default compatibility settings are set to "I.E 7 Compatibility", the PDF plugin will not load.  This fix is the same one used by AngularJS to force the browser to use HTML5 mode.

@WilliamRClark After addressing the comment above, please squash the resulting commits into one using https://github.com/mozilla/pdf.js/wiki/Squashing-Commits.

Change this to  to fix a typo.
@timvandermeij I think we can remove this comment.

But I think we enclose the meta inside <!--#if GENERIC --> to avoid polluting for Firefox and Chrome.

Comment changes committed.
 On Monday, August 31, 2015 7:39 PM, Yury Delendik<EMAIL_ADDRESS>wrote:

Change this to  to fix a typo.
@timvandermeij I think we can remove this comment.
But I think we enclose the meta inside  to avoid polluting for Firefox and Chrome.—
Reply to this email directly or view it on GitHub.

For maximum de-cluttering:

@WilliamRClark We don't have IE-specifc builds.

All code review changes should be complete.

@WilliamRClark Looks good. All that needs to be done is to squash the commits into one commit. See https://github.com/mozilla/pdf.js/wiki/Squashing-Commits on how to do that. We can land this patch after that has been done.

Merged by b1515fdd1060e3a68776b9fe022cd830f66e5f7d.
Thank you for the patch.


bug

Microsoft PowerToys version
0.74.0
Installation method
GitHub, Microsoft Store
Running as admin
Yes
Area(s) with issue?
Installer, PowerToys Run, Settings, Welcome / PowerToys Tour window
Steps to reproduce

✔ Expected Behavior
I am enable to uninstall powertoys
❌ Actual Behavior
I can't uninstall it
Other Software
Serial Number: PF43TP93, Product Number: 82H8031DPH, Bios Version: GGCN49WW

does grabbing the 0.74 installer here then allow you to uninstall?   Did you happen to run a 'cleaning / clean up tool'?
https://github.com/microsoft/PowerToys/releases/tag/v0.74.0
/needinfo

thank you so much sir!, I finally uninstalled it!


Logic Gates

Description
Logic Gates
Spangs04
OP
— Today at 2:42 AM
You can link logic gates together to form a infinite loop without needing power and they can be used to toggle things on and off repeatedly (Such as door locks, toggles and lightbulbs). This can be done from your backpack to just them sitting in a locker. This strange bug is formed through logic loops by linking two together and making a NOR into XOR back into the NOR loop. There are a lot more use cases for this but they often revolve around trolling the station in some form as the logic loop also has infinite range on the signal broadcast.
Reproduction
Get 2 logic gates then set one or both to NOR, link one logic gate to the other then that gate which was linked to back into the first. Then cycle through the different gates till you hit one that causes the repeat. The one that I found was a NOR gate into a XOR gate. This causes a pulsing effect to occur.
Screenshots

Additional context

clocks being possible isnt a bug, or cpus irl wouldnt be possible, making them require anchoring to work or making link range apply after linking

I think its a two pronged issue, sure requiring anchoring helps, but they should probably also have a range limit similar to remote signallers.
Buttons too for that point.

Sorry for the confusion about the clocks part I was not attempting to make it seem like the issue. The issue is the infinite range and having no limitations of power/anchoring.


How to access the fan?

Some computers have a fan to prevent the temperature from being too hot, how to access and control the fan speed?

The firmware controls the fan speed, not the OS. What the OS can do however is request the frequency of the CPU to change depending on how much cpu usage there is. For this it needs to follow the ACPI specification to request the firmware/cpu to change the frequency.

firmware controls the fan speed

Laptops may use Lithium battery, which is unstable; So the user should control the power quantity stored in Lithium battery, some researchers say that around 50% power is good for Lithium battery. But Sodium-ion battery is more stable. Can the OS control the power stored in Lithium battery, .e.g, between 45% and 55%? Sodium-based batteries are more stable so it's not important to control power stored in Sodium-based batteris.

Depends on the laptop. There is an embedded controller on the mainboard which controls the charging logic. On some laptops there is an option to set a charging limit through ACPI, but on others there is no way to set a limit at all.

On some laptops there is an option to set a charging limit through ACPI

How to find the memory address (if the ACPI allows) to set charging limit?

There is no specific memory address. Instead you have to interpret AML bytecode that is part of the ACPI tables to set the charging limit. This AML bytecode may write to a memory address or it may trigger an interrupt calling into the firmware depending on how the firmware implemented setting the charging limit. The crates in https://github.com/rust-osdev/acpi may be useful for interacting with ACPI. Just be aware that the specification is a mess and basically everyone has to emulate all bugs in the Windows ACPI implementation to be compatible with common firmware implementations. https://github.com/rust-osdev/acpi does not yet do this (even Linux has trouble with getting everything exactly right), so it may not work on your specific system. You may also want to look at https://github.com/acpica/acpica which is the code Linux uses to interface with ACPI. There are no Rust bindings for this yet though afaik.

If the AML contains newlines, should I write \n escape character or directly press Enter key?

Brave search engine provides AI to answer questions, I searched
battery charging limit using acpi machine language

The AI said:
Method (_SBF, 1)
{
  // Set battery charging limit to 80%
  Store(0x50, ResourceTemplate())
}

Method (_BST, 0)
{
  // Check battery status
  If (BatteryStatus() == 2) // 2 = charging
  {
    // Stop charging when battery reaches 80%
    If (BatteryLevel() >= 0x50) // 0x50 = 80%
    {
      Store(0, ResourceTemplate())
    }
  }
}

Is it correct?

That is the text representation of AML. The actual ACPI tables contain AML in a binary format which is compiled from this text representation.

That is the text representation of AML

Can the parse_table function https://docs.rs/aml/latest/aml/struct.AmlContext.html#method.parse_table parse the text representation to set charging limit?

No, the aml crate doesn't have a compiler for the text representation of AML afaik. You shouldn't need to use the text representation of AML at any point. Instead read the binary version directly from the ACPI tables provided by the firmware of your system. Each firmware will provide different AML specific for the machine it runs on.

Each firmware will provide different AML specific

Is there a universal way to set battery limit? How to know the length to read ACPI? It seems bootloader_api::info::BootInfo only provides rsdp_addr meaning the address.

rsdp_addr points to the RSDP^1, which itself contains the address of the RSDT (ACPI v1) and XSDT (ACPI v2)[^2]. The RSDT/XSDT is the index you can use to find all other ACPI tables. If you use the acpi crate you can use acpi::AcpiTables::from_rsdp to iterate over all ACPI tables.

Can the OS control the power stored in Lithium battery, .e.g, between 45% and 55%?

As @bjorn3 said, it depends on the laptop. Check if the OS that the laptop was designed for (such as Windows or Linux) has a way of controlling battery charging.
I know for some ThinkPads you can set a charging limit so it only charges up to a certain %.
On most Chromebooks you can stop charging, set a charging current limit, and for some Chromebooks you can set a % limit.
I think you would have to communicate with the laptop's embedded controller and send commands to it to control charging (and on Chromebooks you can control the fan too).  I think this is pretty complicated to do in your own OS and you would have to look at the Linux kernel's code.

you would have to look at the Linux kernel's code.

Not to be a party pooper, but you have to be careful when learning or borrowing from the linux kernel. It's GPL licensed, so your kernel would need a compatible license (or you do your own stuff).
Also mentioned here https://wiki.osdev.org/Linux_Kernel_Primer

you can use acpi::AcpiTables::from_rsdp to iterate over all ACPI tables

from_rsdp needs a handler, which needs PhysicalMapping.

You are supposed to implement the AcpiHandler yourself calling into the memory management code of your OS to map/unmap the specified physical memory to some arbitrary location in the virtual address space of the kernel.

Is https://docs.rs/bootloader_api/latest/bootloader_api/info/struct.BootInfo.html the length of my kernel? Can I put user data immediately after kernel_addr + kernel_len - 1? I think it should - 1.

Is BootInfo::kernel_len the length of my kernel?

Yes

Can I put user data immediately at kernel_addr + kernel_len?

No, that location may be reserved by the firmware or hardware. You have to iterate through the memory map in boot_info.memory_regions and search for entries whose kind is MemoryRegionKind::Usable. Those entries indicate memory you are free to use however you want.

Why are start and end in MemoryRegion u64 but not usize?

Not sure of that is the reason, but the page tables use 64bit entries when PAE is enabled, not pointer size entries. The distinction doesn't matter on x86_64 where PAE is always enabled and usize is always 64bit, but it avoids some casting between u64 and usize. On 32bit x86 the distinction does matter however.

search for entries whose kind is MemoryRegionKind::Usable

Does it ensure all entries in MemoryRegions are different so we don't need to worry about if there are 2 Usable entries?


Fix a small typo in security.html

Stumbled over this while reading it :wink:

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks so much, hehe

Uh that was fast :smiley: Yeah it is pretty small.


Disable transmission lines again, they are too often wrong

We generally don't enable these transmission lines on Nextstrain builds, hence disabling for now again


Remove the ability to delete base content.

Remove delete link and modal from /settings/ on all base content
Remove BaseDeleteView and instances defined in content_urls
Remove unused get_object_delete_url definitions

Looking good, r+, let's merge it after travis is happy again. :+1:

Changes Unknown when pulling 577f2bb957e53e23fb37aad74c37b602e3d5f38f on johngian:1159175 into ** on mozilla:master**.


Move Fuchsia content handler out of flutter/engine repository

Writing down one of the asks from @abarth into an issue.
This mostly involves moving the Fuchsia content handler to use @chinmaygarde's new embedder API.  This will also certainly require extending the embedder API to support the necessary cases.
One tricky one which was pointed out to me is that currently SceneBuilder knows about Fuchsia childViews, and presumably that should be factored out such that that code can live in the Fuchsia side of the embedding?

A meta-issue tracking all the embedder specific features that need to be implemented is filed here.

This is done.


Figure out how the application will run on the server

Possible options:

Kubernetes
Docker
No containerization, just a process manager (e.g. pm2)

Reaching out to CSC to discuss options.

CSC Syscom got back to us about this. TL;DR:

Containerization is definitely possible. CSC can provide us with a Kubernetes namespace if we want to containerize our workloads and go that way

Caveat: not recommended if we want to use persistent volumes with our application. Not an issue now, maybe in the future?

As Minerva requires API endpoints to operate, it won't work well with CSC's web servers (e.g. Caffiene). Should be fine to use with the general-use servers (w/ a process manager like pm2, I'd imagine) though.

Decided on using PM2 for now, as it doesn't require anything extra like containers in the case of docker and k8s would require. We can always easily switch over in the future.


Misstype

Also feel free to set the public facing name of your app to Friendly Pix:
on page: https://codelabs.developers.google.com/codelabs/firebase-web/#2
section: Enable Google Auth
should read: Friendly Pix

Thanks for the catch! It's now fixed


Exclude Latest Version of azure-communication-phonenumbers from regression

Due to imcompatible tests. @xiangyan99
Checking for others that have the same issue.

Run with just phonenumbers out

/check-enforcer override


Project enhancement

Hi @Kemcake,
This is a great project, from a starter kit perspective. What I'd like to bring into this starter kit are the following:
Remove:

jest ( damn sllow)
browserify
gulp

Add:

webpack
babel
mocha, chai, instanbul
eslint
sass, less loaders

To give you a little preview of the enhancement, please take a look at the following gif.

Hello @catalinmiron!

Hello @catalinmiron
I agree that this repo starts to become a bit old and could be improved by replacing some parts
I was also thinking about rewriting it with ES6

Yes, I forgot to mention about ES6 syntax.
Good to know that, when using ES6, there are no mixins available. But Parse made a wrapper called ParseComponent for React.Component. I'll push my changes with the webpack implementation and we'll figure a way of making this happen :)
I'd also like to move the tests from jest to a performant branch, as mocha / chai are. So, I'm going to make another PR where I'll do this, what do you think?
PS: Right now I don't have access to the changes since I'm at office, but as soon as I'll be at home I'll push the changes.
Can you think about a future roadmap? Where this project should go? What are the future improvements? Can we make a yeoman generator out of it?

@Kemcake you can check the changes in the PR (https://github.com/Kemcake/parse-react-sample/pull/2)


Add a test case for GRU

Simple PR: a lit test case for GRU with length input.

Jenkins Linux s390x Build #15731 [push] test case (#2957)  Signe... started at 09:23

Jenkins Linux amd64 Build #15728 [push] test case (#2957)  Signe... started at 08:23

Jenkins Linux ppc64le Build #14758 [push] test case (#2957)  Signe... started at 09:35

Jenkins Linux s390x Build #15731 [push] test case (#2957)  Signe... failed after 1 hr 2 min

Jenkins Linux amd64 Build #15728 [push] test case (#2957)  Signe... passed after 1 hr 13 min

Jenkins Linux ppc64le Build #14758 [push] test case (#2957)  Signe... passed after 2 hr 17 min


As Rick I would like to add more context in regards to the code compliance points so that there's less confusion

[ ] Also consider showing a metric on which is open and closed or past due date? Open to interpretation here.

What did he mean by "more context" and/or "less confusion" -- what does he think is confusing, specifically?

I think it's back to the thought of the points on the map not having
context. There's a yellow dot - is it an open compliance case? Closed?
Overdue?
On Tuesday, September 8, 2015, Sophia Dengo<EMAIL_ADDRESS>wrote:

What did he mean by "more context" and/or "less confusion" -- what does he
think is confusing, specifically?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/mdc-feedback/issues/261#issuecomment-138732641
.

I see. For now, it’s just “all violations.” There is literally no context. I’m super happy that they’re asking for it, since the map was initially a “let’s just see what we can do” type thing.
On Tue, Sep 8, 2015 at 4:47 PM, Ernie Hsiung<EMAIL_ADDRESS>wrote:

I think it's back to the thought of the points on the map not having
context. There's a yellow dot - is it an open compliance case? Closed?
Overdue?
On Tuesday, September 8, 2015, Sophia Dengo<EMAIL_ADDRESS>wrote:

What did he mean by "more context" and/or "less confusion" -- what does he
think is confusing, specifically?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/mdc-feedback/issues/261#issuecomment-138732641
.

Reply to this email directly or view it on GitHub:
https://github.com/codeforamerica/mdc-feedback/issues/261#issuecomment-138732962


Added links for San Jose zoning data using CartoDB

Only you can make changes to your pull request.

It seems like to have certain aesthetic choices.
My point was for you to approve the pull and make whatever changes you want.
Date: Fri, 9 Oct 2015 07:47:51 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [HackNightProjects] Added links for San Jose zoning data using CartoDB (#8)
Only you can make changes to your pull request.
—
Reply to this email directly or view it on GitHub.

Correction...
It seems like you have certain aesthetic preferences.
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: RE: [HackNightProjects] Added links for San Jose zoning data using CartoDB (#8)
Date: Fri, 9 Oct 2015 08:22:16 -0700
It seems like to have certain aesthetic choices.
My point was for you to approve the pull and make whatever changes you want.
Date: Fri, 9 Oct 2015 07:47:51 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [HackNightProjects] Added links for San Jose zoning data using CartoDB (#8)
Only you can make changes to your pull request.
—
Reply to this email directly or view it on GitHub.


Fix loop scheduling

Fixes and improves the loop ordering construction, which is in turn used to build the AST (thus impacting the resulting loop tree structure).
A test is added.
@mloubout Can you try this please?

OK, approved by @mlange05 , and @mloubout is happy. So merging...

Merged.


Use random seconds component on remote carb entries.

A user can add a remote carb entry from Nightscout. The input box allows a start date/time to be selected. The "start-time" seconds component is always "00". If a user inputs 2 entries for the same time, this can be a problem. Nightscout expects treatments to have unique "created-date"s (which I believe is derived from "start-time" in the carb entry case). The result is the 2nd remote carb entry will not be visible in Nightscout or Caregiver. The fix here on the Loop side is to add a random seconds component to each incoming remote carb entry which should reduce the chance of collisions (1/60)
There is more information in the attached Caregiver case, including some information from Ben West LoopKit/LoopCaregiver#33

This PR enables a caregiver to send more than one remote carb entry to Loop at the same hh:mm timestamp and have them report in Nightscout (as well as Loop).
Test Details:
Test 1. Tested without this PR
Enter remote carbs through Nightscout Careportal:

02:53, enter 10 g at 02:00 pm
02:54, enter 15 g at 02:00 pm

Loop has both entries at 02:00 pm
Nightscout shows only one entry

in this case 10 g at 02:00 pm shows on plot but 15 g at 02:00 shows in treatments

Test 2. Apply the PR and rebuild Loop.
Enter remote carbs through Nightscout Careportal:

03:13, enter 21 g at 03:30 pm
03:16, enter 17 g at 03:30 pm

Loop has both entries at 03:30 pm
Nightscout shows both entries on both the plot and in treatments
For good measure add a third one and it appears properly in Loop and in Nightscout

03:20, enter 48 g at 03:30 pm

I may be confused about your comment.
I believe the remote entry can come from 2 places:

LoopCaregiver, which has already been modified to include sec and msec
Nightscout Careportal

Even if a change to Nightscout Careportal was modified and released today, it can be years before everyone updates. I think we need some Loop stop-gap measure.
An alternative idea for a Loop bandaid is to compare carb entry time in loop carb store and make sure new entry differs from other entries by at least one second. That removes the 1 in 60 chance we now have of a duplicate _id in Nightscout.

Oh, Caregiver already has a hack for this NS problem, and we're talking about adding another hack to Loop to deal with entries from the NS UI.  I'm sorry, this seems like a Nightscout issue on multiple fronts, and I think it should be addressed there. Any urgency on the matter should be addressed towards NS devs.

I agree this is not the right solution.
Please see: https://github.com/LoopKit/Loop/issues/2134


[Backport v2.9] [BUG] RKE1 Azure node template has Ubuntu 18.04 as default image. Docker fails to install during cluster nodes provision

Backport of https://github.com/rancher/rancher/issues/44944 to v2.9.x line of releases
Note that the change is in https://github.com/rancher/machine which is currently not branched by release line so bumping rancher/machine to version with the changes is the only expectation for v2.9.x PR.

Moving this to next milestone to have more time to sort out https://github.com/rancher/rancher/pull/47700#issuecomment-2442291593

This issue can be validated on the last v2.9-head image


Update password stored as a SHA256 hash in cookie

Describe in detail the problem you had and how this PR fixes it
The authentication password is stored in plain-text in a cookie named password.
Some may not see this as a security issue for automatically generated passwords (although bad practice) but it is definitively an issue when setting a custom password.
Therefore switching from a plain-text stored password to a SHA256 hash is a quick first step in the right direction (aka. I agree it could be better, eg. salted hash).
I saw that there are pull requests providing other solutions (eg. #931 ) for authentication methods which were blocked by GH-857, but really think this pull request should be merged in for the next v1 release.

Is there an open issue you can link to?
Issue #515 (Issue #565)

This PR doesn't really add any security. Sure you can't tell what the original password is but you can still log into code-server with the hash which just acts as the password. Instead, we should hash the password server side and not store it in memory as plaintext and then hash the client side when comparing.

No activity since PR was opened. Closing to keep the PR queue clean.


Binary sensors not visible

I have a vedo only installation (v2.7.3). The integration to control the alarm is working fine (thanks so much!), however with the new release I enabled the binary sensors but they're not exposed in home assistant.
configuration.yaml:
comelit:   vedo:     host: <IP_ADDRESS>     port: 6082     password: ******     scan_interval: 30     binary_sensors: enable
I noticed in a different issue that you mentioned that the port should be 80, but it seems like my comelit installation is setup on port 6082. When I go to http://<IP_ADDRESS> then I get no web page, but when I go to http://<IP_ADDRESS>:6082 then I do get a webpage (where I need to fill out my password).
As you can see there are no sensors here, and neither can I find the sensors when I manually added them in automations starting with "binary_sensor." followed by the names of the zones in comelit.
I can't find any errors in the logs (attached).

home-assistant_2024-08-14T10-42-25.127Z.log

We are having some problems with the binary sensors, they are working on some systems but not on others.
So better debugging of this feature is needed.
Do you think you can help with that?

@gicamm I can help you with enabling debugging. I can program, but I have 0 experience in writing code for HA.

@gicamm I can help you with enabling debugging. I can program, but I have 0 experience in writing code for HA. How do I enable the detailed debugging? I thought I found it somewhere here, but I can't find it anymore.

Do not worry about HA. It's just Python :D.
We expose sensors in this piece of code. Look at line 153.

@gicamm I enabled the debugging:
logger:   default: warn   logs:     custom_components.comelit.hub: info     custom_components.comelit.vedo: debug
However, I don't see any debug line from the SensorUpdater class in the logs (such as "Comelit Vedo status snapshot started"). All I see is this:
2024-09-22 20:25:37.175 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration comelit which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant 2024-09-22 20:25:47.042 INFO (SyncWorker_3) [custom_components.comelit.vedo] Initialising ComelitVedo with host <IP_ADDRESS>, port 6082 2024-09-22 20:25:47.060 WARNING (SyncWorker_3) [homeassistant.helpers.frame] Detected that custom integration 'comelit' accesses hass.helpers.discovery. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from discovery directly at custom_components/comelit/__init__.py, line 82: hass.helpers.discovery.load_platform('binary_sensor', DOMAIN, {}, config), please report it to the author of the 'comelit' custom integration 2024-09-22 20:25:47.060 DEBUG (Thread#BS) [custom_components.comelit.vedo] Comelit Vedo status snapshot started 2024-09-22 20:25:47.205 DEBUG (Thread#BS) [custom_components.comelit.vedo] Logged in, 2024-09-22 20:25:47.702 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': 'Woning', 'id': 0, 'p1_pres': 1, 'p2_pres': 0, 'ready': 5, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.703 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area Woning comelit_vedo_woning 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 1, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 2, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 3, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 4, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 5, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 6, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 7, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.718 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_
When I look in the comelit vedo control panel (on my ip address) on the status of the zones page, I see that this is the result of the zone_stat.json file:
{     "logged": 1,     "rt_stat": 9,     "vedo_auth": [         0,         1     ],     "life": 1,     "status": "0020,0200,0020,0200,0000,0200,0020,0200,0000,0200,0011,0200,0020,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200" }
One window was open, so I think this is the 0011 entry?

@gicamm I enabled the debugging:
logger:   default: warn   logs:     custom_components.comelit.hub: info     custom_components.comelit.vedo: debug
However, I don't see any debug line from the SensorUpdater class in the logs (such as "Comelit Vedo status snapshot started"). All I see is this:
2024-09-22 20:25:37.175 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration comelit which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant 2024-09-22 20:25:47.042 INFO (SyncWorker_3) [custom_components.comelit.vedo] Initialising ComelitVedo with host <IP_ADDRESS>, port 6082 2024-09-22 20:25:47.060 WARNING (SyncWorker_3) [homeassistant.helpers.frame] Detected that custom integration 'comelit' accesses hass.helpers.discovery. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from discovery directly at custom_components/comelit/__init__.py, line 82: hass.helpers.discovery.load_platform('binary_sensor', DOMAIN, {}, config), please report it to the author of the 'comelit' custom integration 2024-09-22 20:25:47.060 DEBUG (Thread#BS) [custom_components.comelit.vedo] Comelit Vedo status snapshot started 2024-09-22 20:25:47.205 DEBUG (Thread#BS) [custom_components.comelit.vedo] Logged in, 2024-09-22 20:25:47.702 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': 'Woning', 'id': 0, 'p1_pres': 1, 'p2_pres': 0, 'ready': 5, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.703 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area Woning comelit_vedo_woning 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 1, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 2, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 3, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 4, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 5, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 6, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 7, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.718 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_
When I look in the comelit vedo control panel (on my ip address) on the status of the zones page, I see that this is the result of the zone_stat.json file:
{     "logged": 1,     "rt_stat": 9,     "vedo_auth": [         0,         1     ],     "life": 1,     "status": "0020,0200,0020,0200,0000,0200,0020,0200,0000,0200,0011,0200,0020,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200" }
One window was open, so I think this is the 0011 entry?

Stesso problema anche da me.rileva solo i radar,però danno sempre come risultato assente.
Da.json invece gli stati sono valorizzati correttamente

@gicamm I enabled the debugging: logger: default: warn logs: custom_components.comelit.hub: info custom_components.comelit.vedo: debug
However, I don't see any debug line from the SensorUpdater class in the logs (such as "Comelit Vedo status snapshot started"). All I see is this:
2024-09-22 20:25:37.175 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration comelit which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant 2024-09-22 20:25:47.042 INFO (SyncWorker_3) [custom_components.comelit.vedo] Initialising ComelitVedo with host <IP_ADDRESS>, port 6082 2024-09-22 20:25:47.060 WARNING (SyncWorker_3) [homeassistant.helpers.frame] Detected that custom integration 'comelit' accesses hass.helpers.discovery. This is deprecated and will stop working in Home Assistant 2024.11, it should be updated to import functions used from discovery directly at custom_components/comelit/__init__.py, line 82: hass.helpers.discovery.load_platform('binary_sensor', DOMAIN, {}, config), please report it to the author of the 'comelit' custom integration 2024-09-22 20:25:47.060 DEBUG (Thread#BS) [custom_components.comelit.vedo] Comelit Vedo status snapshot started 2024-09-22 20:25:47.205 DEBUG (Thread#BS) [custom_components.comelit.vedo] Logged in, 2024-09-22 20:25:47.702 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': 'Woning', 'id': 0, 'p1_pres': 1, 'p2_pres': 0, 'ready': 5, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.703 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area Woning comelit_vedo_woning 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 1, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 2, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 3, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.705 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.705 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 4, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 5, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 6, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.706 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_ 2024-09-22 20:25:47.706 DEBUG (Thread#BS) [custom_components.comelit.vedo] Updating the alarm area {'name': '', 'id': 7, 'p1_pres': 0, 'p2_pres': 0, 'ready': 0, 'armed': 0, 'alarm': 0, 'alarm_memory': 0, 'sabotage': 0, 'anomaly': 0, 'in_time': 0, 'out_time': 0} 2024-09-22 20:25:47.718 INFO (Thread#BS) [custom_components.comelit.vedo] added the alarm area comelit_vedo_
When I look in the comelit vedo control panel (on my ip address) on the status of the zones page, I see that this is the result of the zone_stat.json file: { "logged": 1, "rt_stat": 9, "vedo_auth": [ 0, 1 ], "life": 1, "status": "0020,0200,0020,0200,0000,0200,0020,0200,0000,0200,0011,0200,0020,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0000,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200,0200" }
One window was open, so I think this is the 0011 entry?

Yes, it should be.
Basically, integration assigns this status to the sensors. The Vedo IP returns data in arrays, so you need to assign it by respecting the correct position.


allow to map a vault secret to an environment variable with a different name

Currently when using daytona as entrypoint via --secret-env it injects secrets as environment variables with the same name as the secret in vault.
This forces the user to name vault secrets exactly as the application expects them, which is impractical for applications or services which expect very generic environment variable names like CLIENT_ID CLIENT_SECRET and whose source is not in control of the user.
Writing secrets with the same generic name to vault makes it hard for developers to understand what a particular secret actually refers and where it is coming from (i.e. by which IDP a secret is issues).
For example let's say you have an app which expects an OIDC_SECRET.
In your particular setup this secret may be issued by Auth0, and as such I'd prefer to write this secret as AUTH0_OIDC_SECRET to vault which makes it much clearer where this came from.
So what I'm proposing is to decouple the vault secret name from the environment name and introduce something like DAYTONA_SECRET_ENV_<suffix> to set the environment variable name.
For example:
VAULT_SECRET_AUTH0_OIDC_SECRET=/vault/path/to/secret/AUTH0_OIDC_SECRET
DAYTONA_SECRET_ENV_AUTH0_OIDC_SECRET=OIDC_SECRET

@geekflyer I think this can be trivially accomplished by referencing the original environment variable key and re-declaring to the variable of your choice:
- env:
  - name: OIDC_SECRET
    value: $(AUTH0_OIDC_SECRET)

while the above may work (I haven't tried it) it really makes the whole enterprise unnecessarily verbose (and confusing for anyone eventually having to make changes to the config, and not familiar with Daytona limitation).
It would really be great to have the SUFFIX to be used as the env var name, without having to resort to a workaround.
This is what I had originally reported in another issue (#99):
Furthermore, it seems that it is not possible to store the secret in an "arbitrarily" named env var, the secret key is always used.
In the example above, we cannot store api_key in a TOKEN_API env var.
This is probably "expected behavior" (if one reads the README 3 or 4 times, while experimenting) but it's somewhat limiting:
└─( TOKEN_PATH=~/.vault-token \
VAULT_AUTH_ROLE=... \
VAULT_SECRET_PGUSER=secret/whatever/thing \
VAULT_VALUE_KEY_PGUSER=user \
daytona -k8s-auth -k8s-auth-mount="..." \
-address https://vault:8200 \
-secret-env -entrypoint -- env | grep -i user

....
{"level":"info","applicationName":"daytona","key":"VAULT_VALUE_KEY_PGUSER","value":"value","time":"2023-03-31T10:53:22-07:00","message":"Found an explicit vault value key, will read this value key instead of using the default"}

{"level":"info","applicationName":"daytona","var":"USER","time":"2023-03-31T10:53:22-07:00","message":"Set env var"}

VAULT_SECRET_PGUSER=secret/whatever/thing
VAULT_VALUE_KEY_PGUSER=user

user=myuser-...-zam.iam

while one would wish to have instead a PGUSER env var to be set.


Transition with same from and to values causes error

When using a transition such as:
{
  property: 'left',
  from: '560px',
  to: '560px',
  duration: '1s',
  timingFunction: 'linear',
}

It results in this.resolve is not a function error, which causes the promise to never resolve..  By incrementing the to value by 1 pixel, it fixes it.  Why is this happening?

Thanks for the report @ericsartor,
This was a bug. Fixed and published under new tag "0.0.7"


how can i use the code in my own datasets

thanks for your excellent jobs on this project. Now, I want to know how can i use this code on my own datasets?  What is the structure of your data?

Hi, hope the last two FAQs (https://github.com/hszhao/semseg/blob/master/FAQ.md) can help you.


Fix "manage:team" permissions

Fixed issue reported by @s-mm where org managers could not create team.
Confirmed that there are no other issues with org/team permissions.
Clarified messages for users with view permissions only.

@ewdurbin Pushed tests that I forgot to check in.


Should not list available panes within a global dashboard pane

In the latest version of the data browser we've introduced global dashboards. These reuse parts of the outline manager that also reuses the listing of panes available. This list is probably just confusing in this version, and I propose that we remove this list from the global dashboard panes.

@timbl What do you think is the best way to detect whether the OutlineManager is rendering inside the dashboard?

This issue was deprioritised since there was not a clear way to do this: removing the call to renderPaneIconTray when options.pane.global is true in expandedHeaderTR did remove that list, but it also caused the Pane not to get displayed at all. Since Tim did not consider this Issue that important, we're postponing it for now.
Of course, PRs still welcome if anybody else wants to pick this up :)

Suggest setting the CSS visibility of the header TR to hidden, but leaving the structure of the DOM

It isn't about the outline manager rendering inside the dashboard. It oi=is about the outline manager rendering a global pane, not a view pane.

This was fixed in https://github.com/solid/solid-panes/pull/153


Modify the collector naming url

Coverage remained the same at 23.055% when pulling 5236cb50984cde90cf24ed9b079168ebf0965b91 on ascrutae:fix/naming-service-url into af0b05a5088470ee27dcdb15ce11f51182a2d2f5 on OpenSkywalking:master.

Coverage remained the same at 23.055% when pulling c67e408686a563a730a087611150d45a5046e098 on ascrutae:fix/naming-service-url into af0b05a5088470ee27dcdb15ce11f51182a2d2f5 on OpenSkywalking:master.


Unable to recover seed - funds lost

Sorry if this has been addressed before, but I'm somewhat of a noob here with Sia.
Computer reformatted and Sia installed on Windows 10.
New wallet seed created and sync allowed to proceed.
Did a recover seed and now get:
Sia-UI Wallet Error
error when calling/wallet/sweep/seed: transaction fee exceeds value of swept outputs
I sent some Sia to this address via Poloniex:
be724f5aea918768e92c31d33e9ca8ebbf53dc0fe338309c806ceae239123f1650aba103ef29
Yes, that is the address that is associated with the seed.
Any ideas?

Update:
Did a check using http://explore.sia.tech/ and the above address.  Though Poloniex has it listed as a successful transaction, I don't see that address as having received the required amount.
Ticket put into Poloniex.  Will see what they say.

While waiting for responses, I completely removed the Sia 1.2.1 folder and the files located at C:\users\myname\AppData\Roaming\Sia-UI.
I unpacked a new folder from the ZIP file and once again synchronized.
I stopped and restarted Sia UI
I created a new wallet with a new seed
I ran recover seed from the GUI and once again got the same error:
Sia-UI Wallet Error
error when calling/wallet/sweep/seed: transaction fee exceeds value of swept outputs
I now get this error when I try to recover any of my past seeds.
Ideas?  Anyone?

Sweeping means transferring all the funds from one wallet to another. This incurs a transaction fee. The error message is saying that the seed has less money in it than the cost of sending it to your new wallet.
Generally you should create the wallet using the existing seed instead instead of sweeping into a new seed.

Thanks!  Will give that a try next.  Still, if there are no funds to send to my new wallet, that means that the transfer must not have worked.

Ran a clean install of Sia and synch to blockchain.  Created the wallet using the existing seed, but nothing in it.
A question please:
If I have "swept" an old seed into a new seed, do the hash addresses from the old seed get permanently transferred to the new seed or do they remain associated with the old seed?  Should I be able to see that previous address using a "wallet addresses" command?

1.2.1 has an issue loading seeds correctly, please download 1.2.2, clear your wallet, and try again: https://github.com/NebulousLabs/Sia-UI/releases/tag/v1.2.2

Many thanks in advance.  Will post results when I sync and load the old seed.

Well, 1.2.2 works much better and shows a lot of transactions.  In fact, it seems like there are more transactions there than I actually made!
My other known transactions are indeed listed with the exception of the one that contained the deposit from Poloniex.  A "Wallet Addresses" on the terminal line lists a lot of addresses I didn't even know were associated with this account, but does include the one in question.
Not sure what to do next.  Ticket put into Poloniex, but no response from them.  May need to check it all up to experience on this one.

I suspect that all of the other transactions (debits) were secondary to trying to store a file.  All of them (I believe) occurred on the same day.  Still waiting for Poloniex to respond.  Seems like they're looking into it since that part of my account is locked.

While waiting for Poloniex to respond, I've got a miner PC working on Sia to deliver to the above address.  I figure that if the mined coins are delivered, the problem lies with Poloniex.  If not, then the problem is on the Sia side.  ETA to delivery is about 3 days.  Perhaps this will shed a bit of light on the problem.

Confirmed.  I believe that the problem is with Poloniex.  My miner deposited 5011 SC into be724f5aea918768e92c31d33e9ca8ebbf53dc0fe338309c806ceae239123f1650aba103ef29 which can be verified using http://explore.sia.tech/
Will let you know what they say.

Just had another deposit in the same account from my miner.  The account number is working fine.  Still no record of a deposit from Poloniex.  Still no response from them.

don't mine directly to an exchange! I think Poloniex has that mentioned
somewhere as well. Hope you get it sorted out though :-)
On Sat, Jun 10, 2017 at 3:15 AM Wags56<EMAIL_ADDRESS>wrote:

Just had another deposit in the same account from my miner. The account
number is working fine. Still no record of a deposit from Poloniex. Still
no response from them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NebulousLabs/Sia-UI/issues/612#issuecomment-307532619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE7eDSrno3ajqJrTYMOYPIUqWDVFrRARks5sCe45gaJpZM4Nhrfa
.

Not mining directly to Poloniex. Mining to Sia wallet and checking for deposits there.  Problem was a transfer from Poloniex to Sia wallet using the above address.  The Sia wallet address works fine when mining is sent to it. The address didn't work when transferring Poloniex exchange Sia to the same address.

Final follow up:
I was out of town for a bit, but when I returned and restarted my Sia wallet and it finished synching, the funds from Poloniex were there.  Mind you, this is about 20 days later.
I have heard nothing from them regarding the issue and cannot explain why it might have taken so long to move from their account to my account.
If any Sia representative is interested, the txid is 5f89dfe73379063616ece48c03c3bc0db1e7a9dc7aeccac8aa5d077018b0c366
If anyone has any insight, I'd be interested to hear it.  Will keep this thread open for a couple more days to see if there are any thoughts.  After that, I'll close it out.

Poloniex was experiencing withdrawal problems for a while. We helped them resolve the issue. I assume they are now clearing out a large backlog of orders. See: https://blog.sia.tech/growing-pains-8e7b01c56f7e

Thank you for the explanation.  Growing pains are good, they make for a better product in the long run.  Keep up the great work!


[Feature] Form widget with conditional logic

Summary
Forms often need conditional logic which reacts to a user's choice. Developers might need to hide/show certain options or navigate to a different section of the form.
Motivation
Conditional logic will ensure that users don't see the questions they aren't supposed to answer. It'll make it easier for developers to segment their audience and only show the relevant questions.
Additional Context

Conditional logic in Google forms
Conditional logic in Typeform
Conditional logic in action (in this example, the form widget's length varies depending on options chosen) see the actual form here

Additional features to make conditional logic easier:

Ability to control form properties from a single property pane
Ability to create question-input field pair at a single place
Ability to conditionally show or hide specific question-input field pair

Will be handled as part of #2504


Mac AppStore Unable to Update

Environment

App version? 1.1.0
macOS version? 10.15.5

Bug Information
When updating through the Mac AppStore, Glances never updates.

What are you trying to do?
What's the expected behavior?
What's the actual behavior?

Is there an error message? Does uninstalling and reinstalling work?


Documentation typo

In the version of ECMAScript that you use in the documentation path(args) is not a function, in that case you should use path.join(args)
Replace this:
const file = path(__dirname, './db.json');

With this:
const file = path.join(__dirname, './db.json');

Good catch!


Failed to resolve: com.alimuzaffar.lib:pinentryedittext:1.3.2

Failed to resolve: com.alimuzaffar.lib:pinentryedittext:1.3.2

No version 1.3.2. Use 1.3.3 instead
https://github.com/alphamu/PinEntryEditText/issues/28

Probably because Google now by default includes only the Google maven repo and doesn't specify jcenter any more. In your /build.gradle make sure it says something like:
buildscript {
    repositories {
        jcenter()
        google()
    }
...
}

Sorry, turns out there is no version 1.3.2 as you mentioned. I'll update the readme in the next round of updated.


Inconsistent Structure declaration locations

Some underground structures are declared in the same file as the aboveground structure while the majority of the others are declared in their own files.
This goes against convention of keeping only related classes in the same file as well as a source of confusion.
I suggest moving the structures declared in the same file to their own file to be consistent with the majority.

I would agree with this. Don't have a good justification for this other than "quick and dirty, make it work" sort of crunch.


Some countries are without flags

it's no bug , just the free icon package I use didn't contain all flags. But in oder to use free icon, so ...


vulkaninfo not printing format properties for certain extension formats

We are seeing issues when using vulkaninfo where some format properties are not being output in either the txt or json output.
It appears that the supported_format_ranges list in vulkaninfo.hpp (https://github.com/KhronosGroup/Vulkan-Tools/blob/main/vulkaninfo/vulkaninfo.h#L1877) is missing some of the format ranges from extensions in the spec
From a quick look, I can see the following ranges are missing (This list might not be complete):

VK_EXT_4444_formats (VK_FORMAT_A4R4G4B4_UNORM_PACK16 -> VK_FORMAT_A4B4G4R4_UNORM_PACK16)
VK_KHR_maintenance5 (VK_FORMAT_A1B5G5R5_UNORM_PACK16_KHR -> VK_FORMAT_A8_UNORM_KHR)
VK_NV_optical_flow (VK_FORMAT_R16G16_S10_5_NV -> VK_FORMAT_R16G16_S10_5_NV)
VK_EXT_ycbcr_2plane_444_formats (VK_FORMAT_G8_B8R8_2PLANE_444_UNORM -> VK_FORMAT_G16_B16R16_2PLANE_444_UNORM)

Yep, this has been something that should have been fixed in 2019 when I rewrote vulkaninfo to use autogen, but the difficulty of it stopped me from trying. But since then, several extensions containing formats have been added without any updates here.
I'm working on a fix for it as we speak, and the difficulty isn't as high as I thought ( but some of that is because I'm much more adept at using the vk.xml these days)