VirtualBox: shared clipboard does not work

Describe the bug
Copy pasting from host to guest and vice versa is not working on NixOS 20.03. It was working on 19.09. My host system in MacOS; VirtualBox Versions 6.0.16 r135674 (Qt5.6.3) and 6.0.22 r137980 (Qt5.6.3) both exhibit this problem.
I’ve set all of the below in my configuration.nix
{
  nixpkgs.config.allowUnfree = true;
  virtualisation.virtualbox.host.enable = true;
  nixpkgs.config.virtualbox.host.enableExtensionPack = true;
}

The associated dropdown in the settings pane (“Shared Clipboard”) is set to “Bidirectional”.
Further debugging:
Trying to see what's running:
$ ps aux | grep irtual

klaas      870  0.0  0.0 229464   528 ?        S    13:29   0:00 /nix/store/vvjqmj4ghyfdsvh11j0ysnjy7az2hzgl-VirtualBox-GuestAdditions-6.1.6-5.4.43/bin/VBoxClient --seamless
klaas      872  0.0  0.1 361568  2884 ?        Sl   13:29   0:00 /nix/store/vvjqmj4ghyfdsvh11j0ysnjy7az2hzgl-VirtualBox-GuestAdditions-6.1.6-5.4.43/bin/VBoxClient --seamless
klaas      876  0.0  0.0 229464   528 ?        S    13:29   0:00 /nix/store/vvjqmj4ghyfdsvh11j0ysnjy7az2hzgl-VirtualBox-GuestAdditions-6.1.6-5.4.43/bin/VBoxClient --draganddrop
klaas      877  0.3  0.1 362084  2936 ?        Sl   13:29   0:29 /nix/store/vvjqmj4ghyfdsvh11j0ysnjy7az2hzgl-VirtualBox-GuestAdditions-6.1.6-5.4.43/bin/VBoxClient --draganddrop

Comparing this with the same command on 19.09 reveals that I'm missing lines for --display, --checkhostversion and, most tellingly, --clipboard
Trying to get it to run:
$ /nix/store/vvjqmj4ghyfdsvh11j0ysnjy7az2hzgl-VirtualBox-GuestAdditions-6.1.6-5.4.43/bin/VBoxClient -f --clipboard

Shared Clipboard: Starting X11 event thread
Shared Clipboard: Stopping X11 event thread ...
Shared Clipboard: X11 event thread terminated successfully
Error connecting to host service, rc=VERR_NOT_IMPLEMENTED
Service terminated abnormally with VERR_NOT_IMPLEMENTED
Running service failed: VERR_NOT_IMPLEMENTED

This seems to be the same bug as the following one for Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/virtualbox/+bug/1875160
Notify maintainers
@svanderburg  @m-scr @Ma27 @fabian @B4dM4n

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-20-03-on-virtualbox-shared-clipboard-broken/7560/2

Just for the record, I'm not a virtualbox maintainer :)

@Ma27 sorry about that, I noticed you were one of the past 4 or 5 committers to the package, and the official maintainer hasn't committed since 2011 (!).

This is for the VirtualBox Guest Additions 6.1.6 (just to clarify, since it can be deduced from the above).

Can you try to update the host system's VirtualBox? I suspect the most recent Guest Additions may have developed some incompatibility with older versions of VBox.

@vanschelven: can you try to update the host system's VirtualBox?

I did without success, but did not update the issue's description yet. It's updated now. (to reflect that this is still a problem for 6.0.22 r137980)

The following pages describe similar symptoms (although no fix):

https://www.virtualbox.org/ticket/19234
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946843
https://forums.virtualbox.org/viewtopic.php?f=3&t=96309

I think I have to add, that I do not have any problems with bidirectionally shared clipboard, I'm using the official virtualbox image. Currently on guests additions 6.1.6.
Host is windows 10, but I can't say anything more right now, as I'm not at that computer.
I will try to check with a nixOS host later this evening. Also I'll provide more info about my setup at work tomorrow to narrow this down.

In a further attempt at getting at the source of this I replaced my rather non-standard xmonad setup with a (presumably) more standard gnome setup... but to no avail:
before:
  services.xserver.windowManager.xmonad.enable = true;
  services.xserver.windowManager.xmonad.enableContribAndExtras = true;
  services.xserver.windowManager.default = "xmonad";

after:
  services.xserver.displayManager.gdm.enable = true;
  services.xserver.desktopManager.gnome3.enable = true;

Using the provided OVA (https://nixos.org/download.html#nixos-virtualbox) works for me OotB for the bidirectionally shared clipboard on nixOS host as well after enabling it in the machine settings.
Won't go to the office today, so can't tell more about the windows hosted machine.
Anyway, automatic resize did not work, but thats kind of expected as I neither have installed the patch from the forum, nor the PR from the repo as this was just a 5 minute test machine.
You need to show more of your configuration.

It's working for me in 6.1.10: https://github.com/NixOS/nixpkgs/pull/89798/
but see https://github.com/NixOS/nixpkgs/issues/62980#issuecomment-647117120

I ran into a similar problem with a nixos guest on win10 host. running
VBoxClient-all in the guest made cnp working

Still having this issue, running VBoxClient-all works but needs to be ran after every reboot


Atom keeps crashing when I try to edit python files

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When i try to edit python files the editor crashes
Expected behavior: Not crash every 30s
Actual behavior: Crashes every 30s but only on python files
Reproduces how often: Happens every 30s
Versions
Atom    : 1.25.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0
apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.25.0
python
git 2.9.3.windows.1
visual studio
Additional Information
I have tried safe mode, the crash still occurs.
I have tried reinstalling the editor and it still occurs
I have disabled all the git packages still the error occurs

Do you have the new experimental highlighting mode enabled? It's called Use Tree-sitter Parsers in the settings view.

no its not enabled

Does this happen for any Python file, or specific files? If you only see this on a specific file are you able to share it so we can attempt to reproduce this?

No, it does it for all python files and it crashes after I run the python file either externally or through atom

Could you describe this crash? Are you getting any error messages? If you launch Atom from a CLI (like Command Prompt for example) using atom --safe ., do you get any messages printed when it crashes?

No message comes up

Could you try changing the language Atom is considering the file to something else? You can do this by clicking "Python" in the lower right corner and selecting a different language (eg. "Plain Text").

Nope it still crashes does it have anything to do with the packages I have ?

Can you try temporarily Resetting to Factory Defaults to check if it is anything in your profile? You can easily move the folder back after testing to restore your current profile.

Nope, it still crashed :(

Can you describe the crash you are seeing?

So I'll be editing the code after running the file, then the editor goes white and I get an error telling me the editor has crashed and that I could reload it, close it or keep waiting. If I choose to keep waiting the editor is white screen but, i can access the file options on the top navbar

Every time it reloads it opens a new python task which slows down my computer

Can you make sure that you are trying Safe Mode? Atom by itself doesn't launch any Python processes so that would have to be a community package.

Sorry i forgot to mention the python tasks issue doesn't occur in safe mode

@thatVaddiguy: this means an issue is in a community package, what packages do you have?

I have all these packages
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Python-indent and python-tools look like likely culprits, disable them first and see if it fixes the issue.
If it doesn't, keep disabling packages one by one to see which one is the problem.

I could take a look into this issue if it hasn't already been assigned to someone else.


Set up CI

Currently CI isn't set up on the repo :)

@jkwlui when do you think you'll have time to set up CI? Thanks!

Looks like this is all set :)

🎉


openstack: take defaults from environment

This patch introduces TEUTH_ based environment variables
which can be used to avoid bulky commands while overriding
default values for some of the teuthology arguments.
Make --ceph argument optional for teuthology-suite,
and defaults to 'master'.
Signed-off-by: Kyr Shatskyy<EMAIL_ADDRESS>

@gregsfortytwo ping


Provide detail on the order of the synchronous and asynchronous methods

Description
Small comment:
In the sections on OnInitialized{Async} and OnParametersSet{Async} you don't explicitly say that the synchronous method is called before the asynchronous one.  I may of course have missed the information else!
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/lifecycle.md
Document ID
4871f4f7-9cf6-ac7a-0f21-c65d34bd1119
Article author
@guardrex

Hello @ShaunCurtis ... Yes, we can add something on that if that's always true. We'll need the PU to confirm it tho, so I'll ping Steve now to ask.

Confirmed! (offline) ... Yes, he says go ahead and work this. I'll get to it soon because it will only take a couple of minutes to resolve.


Feature request: support coq_nvim (or: be autocompletion-engine-agnostic)

Hi,
I love the plugin, but recently I switched away from nvim-cmp to coq_nvim due to performance reasons and unfortunately it seems that otter lacks support for coq.
Could support for coq please be added?
Alternatively, why not register a new LSP directly in neovim (in lua) which will simply redirect to other relevant LSPs, instead of having this implementation as a separate autocompletion plugin? I haven't looked into neovim APIs in great detail, but it seems that something along those lines should be possible.
Thanks again for the plugin and your time.

I agree that a language server that performs essentially the functionality of otter.nvim (keep pure language buffers in sync, redirect requests) would be a very clean solution, though it is quite likely to find a bunch of edgcases in lsp and neovim api implementations that may make it less clean. However, I don't currently have the time to write a language server.
As for coq, it looks like a very promising approach and seems to also be extensible similar to cmp. I would be very happy about a PR to otter.nvim if you translate the cmp source there to coq.

I will revisit this once https://github.com/neovim/neovim/pull/24338 or something along those lines is merged. This should make it easier to turn otter.nvim essentially into a language server with the necessary translations included.


Allow to avoid synchronization of files that changed in the target

Well... almost. What I'm thinking about here is the following scenario:

The date T of the last sync was recorded at the target side.
Some files changed in between.
The next sync will overwrite or delete those files (even in case the --update option was set, there is still a risk of both destructive operations).
So I create an exclusion filter to exclude every local file that was updated after T and run the sync.

Now, what I propose is to add an option to avoid modifying files that changed at the target side after T. There is already an option to avoid transferring files that are too new, but that's not exactly the same. And I think the use case is compelling enough that a special flag might be preferable over a list of excluded files.

Thinking a bit more about this I realize it's not only a matter of convenience (exclude list vs apecial option) since it's not feasible to produce exclude lists for every kind of store in a practical way. I believe this should be a primitive: "don't destroy things that changed in the target since this time". It's hard to implement any kind of reliable multiway sync without something like that. Maybe --update-older-than. Also, aborted potentially destructive operations (those excluded by --update or --update-older-than) should be reported in a distinct way, so the user is able to take effective conflict resolution actions (merge, replace, etc.). This may be coupled with my suggestion to add a flag so that rclone asks the user upon destructive operations.

You can do that with copy and skip existing.

No, it's not a matter of files existing or of target files having a newer modification time than respective source files, but of target files having a modification time that's newer than a specified one (for the described use case, that's the time of the last sync). Besides, I'm interested on syncing, not copying.

Doesn't the update option solve this for you ?
-u, --update                            Skip files that are newer on the destination.

Oh sorry do you mean if both files have changed both on source and target ?
And source is still newer than target but they have basically diverged ?
I guess if you save the last proper sync time that might be useful, but you really need to be careful about how to manage those timing.
Also there has to be a warning displayed to the user that files are out of sync since this is something you'll want to manually fix ASAP, or your putting yourself at risk of eventually loosing data

No, newer on the destination is not the same as newer than the last sync date or some other date. The problem here is that you need to check for modifications after some common version (mod date) of a files upon which both sides agreed at the "branching" time. And after thinking more and more about the issue I realized that that date is file dependant, it can't be assumed to be just a single date for all the sync operation, so I'm not sure this proposal is really worthy as a way to implement some limited but cheap form of two-way sync through a shared remote (a la dropbox), at least in the general case. Nevertheless I would use git annex with the rclone remote for serious versioning, but --update-older-than may help implement more robust sync schema than plain --update, albeit not bullet proof.

Just think about this example:

A pulls f
B pulls f
A changes f at time T1 > T (the mod date of f)
B changes f at time T2 > T1
B pushes f
A pulls f with sync --update: A changes get silently overwritten by B changes!!

Yea I thought that what you meant.
Which is actually a two way sync. This can be done by the file update time but I wouldn't trust it.
It would be much safer to keep the hash of the last synced version and not allow overwrites if it has changed.
There is a feature request for two way sync #118  and I guess overwrite protection should be part of it

I will close this since I see you're heading towards a much better and comprehensive solution for 2 way sync using more metadata.
I would like to add that I'm very happily using git annex with the rclone special remote, but that's not to say it wouldn't be useful to get rclone solving simple sync scenarios by itself.


add gcp image list command to CLI

Hey @major @FKolwa ,
I am a bit confused right now. We assign the registered github secret secrets.GOOGLE_APPLICATION_CREDENTIALS to an environment variable GCP_APP_CREDENTIALS, but we never use it.
In the get_google_images function we create an compute_v1.ImagesClient client, is he supposed to use those credentials?
I went to the google docs, but it also didn't really helped me. :)
Can you give me some hints? :sweat_smile:

@miyunari Yup that is correct! It isn't necessary to reference the ENV in code.
In fact you won't find any of the other secrets either (like AWS_ACCESS_KEY_ID).
Most (if not all) cloud provider CLIs authenticate using local configurations that are loaded into ENVs at runtime.
Usually you would use you user credentials to sign into Google Cloud but with an automated service like this a service account can be used.
The fact that "GOOGLE_APPLICATION_CREDENTIALS" is set for the workflow step means that the gcloud cli will be able to read it and use it to authenticate with the cloud provider API. I'll leave you a link in case you want to read more about Google Application Default Credentials (ADC): https://cloud.google.com/docs/authentication/provide-credentials-adc#local-key
A small hint though: The env needs to be mapped to "GOOGLE_APPLICATION_CREDENTIALS" in the workflow context as well for it to properly work.
Hope this helps a little!

Thank you @FKolwa ! That was exactly the information I was looking for :smile:
But now, there is another issue :sweat_smile:  Unfortunately it's now unclear to me, how to test my changes.
I got this reference from major, but I don't see the correlation:
https://github.com/redhatcloudx/rhelocator/blob/b97967e77354d0331f0f7bc4a607c00b4b1eea16/tests/test_cli.py#L77-L103

@miyunari Haha yes this is a bit confusing tbh!
The gcloud implementation is pretty rough at this point. get_google_images currently queries all images in the rhel-cloud project and returns everything that isn't deprecated.
In the scope of this ticket, my requirement for an end to end test would be

query the correct api endpoint by calling get_google_images by using 'runner.invoke'
parse the json data
confirm that all images that are returned do not contain the first level key status with the value 'DEPRECATED'
In this case you can copy / paste most of what @major wrote for the azure test!

For the offline test

copy the structure of the e2e test you just wrote
create a new mock for the google images in conftest (you can take a look at the AWS mockups. You need to create a new list of mocked images in a json format and create a new fixture that is passed to you offline test).

Now for the tricky part: How do you know what data structure to expect from the google API?
Well if you call gcloud and query for projects within 'rhel-cloud' you will receive something like this:
  {     "architecture": "X86_64",     "archiveSizeBytes": "4184623872",     "creationTimestamp": "2022-09-20T16:32:45.492-07:00",     "description": "Red Hat, Red Hat Enterprise Linux, 9, x86_64 built on 20220920, supports Shielded VM features",     "diskSizeGb": "20",     "family": "rhel-9",     "guestOsFeatures": [       {         "type": "UEFI_COMPATIBLE"       },       {         "type": "VIRTIO_SCSI_MULTIQUEUE"       },       {         "type": "SEV_CAPABLE"       },       {         "type": "GVNIC"       }     ],     "id": "2043557223711896434",     "kind": "compute#image",     "labelFingerprint": "42WmSpB8rSM=",     "licenseCodes": [       "7883559014960410759"     ],     "licenses": [       "https://www.googleapis.com/compute/beta/projects/rhel-cloud/global/licenses/rhel-9-server"     ],     "name": "rhel-9-v20220920",     "rawDisk": {       "containerType": "TAR",       "source": ""     },     "rolloutOverride": {       "defaultRolloutTime": "2022-09-25T15:32:42Z",       "locationRolloutPolicies": {         "zones/asia-east1-a": "2022-09-22T04:32:42Z",         ....         "zones/us-west4-c": "2022-09-25T04:32:42Z"       }     },     "selfLink": "https://www.googleapis.com/compute/beta/projects/rhel-cloud/global/images/rhel-9-v20220920",     "sourceType": "RAW",     "status": "READY",     "storageLocations": [       "eu",       "asia",       "us"     ]   }
At this point we don't extract any specific information from this returned data (like we do for AWS) and this is not within the scope of your ticket so feel free to create a minimal test mockup version of this data structure that only contains something like
{ "status": "READY" }

Oh boy, that was my mistake. I must have been looking at two things at the same time and put the wrong variable name in the actions workflow. 🤦🏻♂

@major I think you were right :smile: . I shortened the variable name, because I thought we have to store it in config.py and use it somewhere :woman_facepalming:

Oh, I see I have some merge conflicts, will try to resolve


Support for Changing Spreadsheet Templates (without changing button Actions)

Describe the feature
The current drop-down menu in the Actions for sheets means you need to identify a specific sheet. The problem is if you build out many actions to a specific spreadsheet, but then change spreadsheets, you have to manually go through every action and update which spreadsheet the Action targets.
Usecases
Example is creating a Run Of Show template in Sheets. You then build a whole page of Companion buttons that will trigger based on data in your ROS template sheet.
Then you duplicate the ROS template for the next show, but you want all of your button Actions that you designed in Companion to reference the data in the new spreadsheet.
Currently you'd have to find all Sheet Actions in Companion and manually update each action to the new spreadsheet.
Not 100% sure what the solution is here, but perhaps it is having Actions that are tied to spreadsheet ID numbers (such that if you swap Spreadsheet ID numbers, the Action will still identify the identical Sheet Name within the spreadsheet workbook).

In the next beta version I've attempted to create a solution for this by creating an option in the config to reference spreadsheets by index, rather than ID.
What this means is that by default actions/feedbacks/variables reference by ID, so it doesn't matter which order you provide sheet ids it'll always reference that spreadsheet (as things currently work). If the config option is toggled to reference by index it means you can instead set the Spreadsheet to whichever is the first, second, third, etc... in the space separated list in the config. That way if you want all your actions/feedbacks/variables to work on a different spreadsheet, you can just reorder the spreadsheet ids in the config.

Sounds good, I'll check it out, thanks!


User Activity closes the Warning window

Hello there,
I use the session timeout library with these settings:
$.sessionTimeout({
keepAlive: false,
logoutUrl: '/logout',
redirUrl: '/logout',
warnAfter: 300000,
redirAfter: 330000,
countdownMessage: 'Redirecting in {timer} seconds.'
});
The problem I experience is that after the warning is shown to the user, the modal is closed after mouse move. I expect the modal to stay open until the timer expires or the user click on one of two buttons: Stay Conntected or Logout.
Thanks, Blerim

was going to look into maybe using this but if it reads activity on a mouse move, no way. a mouse could easily be bumped, etc. i would not assume that  means the user is "active" for determining timing out or not. I agree with blerimj about the modal staying until the user make a decision or the timer expires.

I am not sure how to do this the proper "GitHub" way with this repo, but on the bootstrap-session-timeout.js I wrapped the contents of the '$(document).on('keyup mouseup mousemove touchend touchmove', function(e) {' function with 'if (!$('#session-timeout-dialog').hasClass('in')) {' which prevents the user activity from resetting the session timer and closing the dialog.

User activity closing the modal was intentionally added in 1.0.3 with commit 4b5b865edc76d7764d5ea891f977f9b30390b6f2.
However, the readme file says:

On any user action (mouse, keyboard or touch) the timeout timer is reset. Of course, you will still need to close the dialog.

Is there a reason why this behavior was changed?  It is a strange user experience to see the modal pop up and then immediately disappear upon moving the mouse without being able to click on either button option.

Here is the diff from 4b5b865 --> master
This is what was removed
 if( $('#session-timeout-dialog').length > 0 &&
       $('#session-timeout-dialog').data('bs.modal').isShown )
   {
       $('#session-timeout-dialog').remove();

this is what was added
    if ($('#session-timeout-dialog').length > 0 &&
       $('#session-timeout-dialog').data('bs.modal') &&
       $('#session-timeout-dialog').data('bs.modal').isShown) {
       // http://stackoverflow.com/questions/11519660/twitter-bootstrap-modal-backdrop
       $('#session-timeout-dialog').modal('hide');
       $('body').removeClass('modal-open');
       $('div.modal-backdrop').remove();

   }

I'll add a new parameter actionHidesModal which will default to false.  This flag will be used as a condition to determine which logic to use. When false, the modal will not be hidden on mouse movement.

please take a look at https://github.com/powpow12/bootstrap-session-timeout/tree/features/action_hides_modal.  A few things to clarify,

I'll add a new parameter actionHidesModal

This is currently anyActionHidesModal, but I think it will make more sense as hideModalonAction

which will default to false

I don't know if makes more sense to have the current logic be the default or the new "better" logic.  I could go either way on it

When false, the modal will not be hidden on mouse movement.

The only way you can close the modal is via the close, logout, or keep me logged in buttons

The flag is actually called ignoreUserActivity.  So set that to false and the mouse moves don't close the dialog.

With ignoreUserActivity the session dialogue pops up regardless of the user's activity which is a bit annoying for them .. It's a better UX to pop up with no user activity at the timeout.
The way it's working currently makes the dialogue buttons redundant because the user can't click them in time. Or does ignoreUserActivity still reset the timeout?

@blerimj  use ignoreUserActivity:true property

It would be better if there was a specific option to ignoreUserActivity when warning dialog is being shown
For now it looks like ignore user activity will work all the time which is not what i wanted

How to reset the timer or keep alive if mouse and keyboard is in-use. And when idle and pop up, mouse move will not hide the modal? I tried the following but not working. Please help.
$.sessionTimeout({         keepAliveUrl: '../Home/Logout',         keepalive: **false, or 'onStayConnectedClick',**         logoutUrl: '../Home/Logout',         redirUrl: '../Home/Logout',         warnAfter: 2000,         redirAfter: 4000,         countdownMessage: 'Redirecting in {timer} seconds.',         countdownBar: true,         ignoreUserActivity: true     });

I have HideModalOnAction set to false but the modal still closes as soon as I move the mouse.


Phone number format is wrong for Turkey

Summary:
Our linguists are claiming that the national number formatting returned by libphonenumber is incorrect.
Expected:  0xxx xxx xx xx
Returned:  0xxx xxx xxxx
Adding email thread from libphonenumber-discuss group.

Hi Aravind,
I looked at the above links and the results are not definitive. The one proper source is the itu doc (from Information and Communication Technologies Authority of Turkey). I went to their website (http://www.btk.gov.tr/en-US/Pages/Contact / http://www.btk.gov.tr/tr-TR/Sayfalar/Iletisim) and the contact information shows the telephone ending in  xx xx format. Also the ITU directory for Turkey shows the same format (except for fax) https://www.itu.int/ITU-D/icteye/DisplayCountry.aspx?code=TUR.
In any case - it looks like the generally accepted numbering format is the one that ends in XX XX.
Links reported under 3 are american websites - displaying US Numbers - not turkish numbers.
For the google results - I am seeing both in some pages. Could the issue be that libphonenumber is used to format the numbers in the second set of results?
For instance for the top hit from: http://www.istanbulhomes.com/contact - the banner shows the right format
Inline image 1
whereas the body shows the libphonenumber format
Inline image 2
Do you guys have an authority on Turkey who can definitively answer this? Can anyone from Turkey chime in?
Thanks,
/george
GEORGE ABRAHAM
Senior Software Engineer  |  Customer Messaging Platform
On Fri, Aug 5, 2016 at 4:03 AM, 'Aravind Penmetsa' via libphonenumber-discuss<EMAIL_ADDRESS>wrote:
Hi George,
We have done some more investigation on this.
Based on below findings, format XXX XXX XXXX is also widely used to mention Turkish numbers.

"+90 212 100..999 10..99 10..99": 14,800,000 results
"+90 212<PHONE_NUMBER>..9999": 14,700,000 results
Official ITU doc recommends format XXX XXX XXXX
https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000D60001MSWE.doc
Yellow page websites of Turkey also use XXX XXX XXXX
http://www.turkishnyyellowpages.com/index.php?category=14&page=2
http://www.411.com/business/valley-service-center-quitaque-tx

Both the formats are used equally.
Do you have any other evidence that the XX XX is preferred?
Sorry for not checking this earlier. :)
Thanks & Regards,
Aravind
On Thu, Aug 4, 2016 at 1:23 PM, Aravind Penmetsa<EMAIL_ADDRESS>wrote:
Yes, there isn't  a GitHub issue to track this yet.
I think it is better if you create the new GitHub issue (with all these details) so that you get proper notifications to your mailbox.
Thanks & Regards,
Aravind
On Thu, Aug 4, 2016 at 12:15 AM, 'George Abraham' via libphonenumber-discuss<EMAIL_ADDRESS>wrote:
Thanks Aravind.
Will there be an issue to track this? I couldn't find one on the github page. If you point me to the issue - I can follow it to get updated about when we can expect the fix.
Thanks again for your prompt response,
/george
On Wednesday, August 3, 2016 at 4:08:42 AM UTC-7, Aravind Penmetsa wrote:
@George,
Thanks for providing all the details we need! We've accepted this issue and will fix this in an upcoming release.
If the input number contains formatting already, such as spaces or brackets, AsYouTypeFormatter returns the result with no edits.
Ex: For input 0212 319 450 0, AsYouTypeFormatter returns same 0212 319 450 0.
If the input is not in any format, AYTF uses national formatting rules which are defined in metadata.
Ex: For input<PHONE_NUMBER>0, AsYouTypeFormatter returns 0212 319 4500.
We will correct Turkey national formatting rules as mentioned by you.
Ex: 0212 319 45 00
On Fri, Jul 29, 2016 at 11:05 PM, 'George Abraham' via libphonenumber-discuss<EMAIL_ADDRESS>wrote:
Hi All,
Our linguists are claiming that the national number formatting returned by libphonenumber is incorrect.
Expected:  0xxx xxx xx xx
Returned:  0xxx xxx xxxx
Basically they say that in Turkey the last 4 digits are split into two. See some examples at the following links:
http://www.turkcell.com.tr/tr/hakkimizda/iletisim?place=footer
http://www.mfa.gov.tr/contact-us.en.mfa
http://www.citibank.com.tr/gcb/english/footer/contact_us.htm?
Looking at the results it looks like the AsYouTypeFormatter is returning the right format but not the parse
http://libphonenumber.appspot.com/phonenumberparser?number=(0212)+319+45+00&country=TR&geocodingLocale=en-TR
Formatting Results
E164 format   +902123194500
Original format   (0212) 319 4500
National format   (0212) 319 4500
International format  +90<PHONE_NUMBER>
Out-of-country format from US 011 90<PHONE_NUMBER>
Out-of-country format from CH 00 90<PHONE_NUMBER>
AsYouTypeFormatter Results
Char entered: '(' Output: (
Char entered: '0' Output: (0
Char entered: '2' Output: (02
Char entered: '1' Output: (021
Char entered: '2' Output: (0212
Char entered: ')' Output: (0212)
Char entered: ' ' Output: (0212)
Char entered: '3' Output: (0212) 3
Char entered: '1' Output: (0212) 31
Char entered: '9' Output: (0212) 319
Char entered: ' ' Output: (0212) 319
Char entered: '4' Output: (0212) 319 4
Char entered: '5' Output: (0212) 319 45
Char entered: ' ' Output: (0212) 319 45
Char entered: '0' Output: (0212) 319 45 0
Char entered: '0' Output: (0212) 319 45 00

More cases where the number is formatted ending with xx xx.
iPhone formats the number correctly

Hi George,
Thanks so much for all the details provided.
Yes, you are right regarding yellow page websites. These are referring to numbers in US.
I doubt that most of these websites (that uses format xxxx) use libphonenumber.
We generally follow ITU official documents.
Even though xxxx format is the official one, looks like format xx xx have slight edge in terms of usage. We can go ahead with the change (from xxxx to xx) as your linguists say.
You can also create your own custom NumberFormat and feed it to PhoneNumberUtil.formatByPattern(). But this is not recommended as you will miss the latest updates on formats for respective leading digits. You can always raise issues like this and update the library itself.
Please note that you have submitted this information with the knowledge that we
may use, modify, reproduce, publicly display, and distribute the information in
accordance with our open source policies. Please let us know if you did not
intend to submit the information for such use.

Thanks Aravind!

Hi Aravind,
Any updates on when this will be fixed?

Hi George,
As this is not a validation issue we have not prioritized it.
We will prioritize and fix this in an upcoming release.

Thanks

Fixed in v7.7.3: http://libphonenumber.appspot.com/phonenumberparser?number=%2B902123194500


Add ERC20 opt-in migration contract for zOS

Fixes https://github.com/zeppelinos/zos-lib/issues/185

🚀 Description

This PR adds a new contract to onboard legacy ERC20 tokens to an upgradeable one that could be managed by ZeppelinOS. This is the migratable version of https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1054
Additionally, I'm extracting the behavior expected of the StandardToken so we can start reusing it in different test files.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Thanks @frangio , how do you see having this one for oz-zos first and then working on a solution for master?

The thing is that oz-zos should be as close to oz-sol as possible, and to keep things under control I think code should only flow in the direction from oz-sol to oz-zos.
What would be the benefit to merging into oz-zos first? As far as I can tell, the oz-sol version would be just like this one but removing Migratable and the initializer function.

Agree @frangio, I opened another to have this functionality in master (see https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1054). I trust your decision on how these should be merged.

We've split out openzeppelin-zos to a new repo: OpenZeppelin/openzeppelin-zos. We'll merge that over there once #1054 is merged.


Returning Authorization Code Request Notification / Reinstall fails "Unclosed connector"

Describe the bug
After googling and asking on HA Discord channel and trying to delete/uninstall anything connected with Amazon Alexa and reinstall I don't get any further.
The Alexa integration was working fine, then it started asking for a configuration / code authorization process under the notification. I proceeded, became an email with a 6-digit code, which I entered... but then the first message appeared again. I tryed this a few times.... until I found time (and nuts) to uninstall it. So I remove the "Alexa media player" integration by deleting it under HA settings / integrations. Then I removed an existing entry in the "configuration.yaml" file. After a HA restart I filled in email, password and amazon.de, pressed OK then a failure with "Abgebrochen" (Cancelled) came up. The home assistant logfile showed:
2020-07-06 14:07:36 ERROR (MainThread) [homeassistant.core] Error doing job: Unclosed client session
2020-07-06 14:07:36 ERROR (MainThread) [homeassistant.core] Error doing job: Unclosed connector
I tried to uninstall the alexa media player integration over HACS, restarted HA and installed it again over HACS. Still no luck.
Finally full server reboot... no changes... Still error "Cancelled" with the unclosed client session / connector...
To Reproduce
Steps to reproduce the behavior:

Go to integrations
Click on '+' and search for "Alexa Media Player"
Fill in valid email adress, password, and "amazon.de" (advanced debug and the rest of the settings doesn't change a thing)
Click on "Send" and I get a popup message "Abgebrochen" (as I set German as language, "Cancelled")
in the homeassistant/homeassistant.log file I got the above two lines with unclosed client session / connector...

Expected behavior
Working Alexa Media Player integration to be able to use my Echo's again with home assistant...
Screenshots
If applicable, add screenshots to help explain your problem.
System details

Home-assistant (version): 0.112.2
Hassio (Yes/No): (Please note you may have to restart hassio 2-3 times to load the latest version of alexapy after an update. This looks like a HA bug). Yes
alexa_media  (version from const.py or HA startup): 2.9.2
alexapy (version from pip show alexapy or HA startup): 1.10.8

Logs
Please provide logs. We'll be most likely asking for them anyway.
2020-07-06 14:07:36 ERROR (MainThread) [homeassistant.core] Error doing job: Unclosed client session
2020-07-06 14:07:36 ERROR (MainThread) [homeassistant.core] Error doing job: Unclosed connector
Additional context
anything else?

None of those messages are coming from this component. Please provide logs as described in the template.

I've the same problem. Delete the integration and readd it. I get the message https://imgur.com/zD7EzfB. I click on the link in the email and accept the connection. But the message dont hide. Doesnt matter if I click on submit or not..

@ottelo9 I'll need the logs when it's in this state to figure out what's going on. You're describing #807 which isn't what the original poster is reporting. You can either do the workaround by enabling 2FA, or if you want to help us try to fix it, please provide your logs to that issue.

Sorry for the missing Log information. In the meantime I found the solution. The password I used was still correct and my stored Amazon Cookie kept me logged in on website and amazon app on mobile. But after logging out on amazon website and trying to relogin a message came, that I have to change my password. after password change and setting the new password in HA all worked flawlessly again!
Weird behaviour... but definitely not caused by your component :-) Thanks for your great work anyway!

Glad it's working for you. I'll close this then.


Fix minor issues after running it

Hello! Thank you for your PR. Left a comment to explain the changes. A better title for this PR would also help.

Hi, sorry for the delay in reply. I had missed this.


Can´t compile esp32-webserver (IDFGH-1997)

Hi,  I am trying to change the Wi-Fi mode of the FZ2707 (4 realys) module to connect it to my home Wi-Fi. I'm using W10.
I cloned the esp32-webserver and esp-idf repositories from github and installed the ESP tools but I can't build the project! Other projects like "hello_world" are well built.
When I try to build the project I have this error:

What am I doing wrong? Im new to this, any help would be important to me.
Thank you!
Andres

Which esp32-webserver project?

This one...
https://github.com/cyoung/esp32-webserver
Is a firmware for a 4 realy (module  FZ2707 from DIYMALL) based on esp-idf frameword

That project does not support cmake (idf.py), only make.  And it probably has only been tested on older versions of esp-idf maybe ≤3.2.  If you are asking for help with third party projects please open your issue on their GitHub repo or go to the esp32.com forum.

@negativekelvin Thanks for the notes. @yoandresmza Thanks for reporting, for third party issues, please help create a post on our forum at esp32.com. Thanks.


AppService: Updating to use the latest version of SDK

Fixes #10476
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@qwordy can you help me figure out what is missing here since i see this error  in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Hi @panchagnula, according to your code change in the PR, you plan to upgrade the azure-mgmt-web to 0.44.0, and I will assume you want to use v2019-08-01 for AppService related commands. Is this you expected? And I am working on MultiAPI support for AppService and I think I can upgrade the api version for you.

I think the multi-api version is taking longer than expected because the v2019-08-01 is not supported for hybrid & if we can just do the update to use the new SDK directly first & then figure out the multis-api support that would be great. let me know if this is something you can take care of.
Thanks
Sisira
Sent from Outlookhttp://aka.ms/weboutlook

From: Zunli Hu<EMAIL_ADDRESS>Sent: Wednesday, December 4, 2019 22:46
To: Azure/azure-cli<EMAIL_ADDRESS>Cc: Sisira Panchagnula<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-cli] AppService: Updating to use the latest version of SDK (#11476)
Hi @panchagnulahttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpanchagnula&data=02|01|sisirap%40microsoft.com|30152cbb801546ae6f3408d7794ecccc|72f988bf86f141af91ab2d7cd011db47|1|0|637111251661225638&sdata=DeCOGeu9VoVvV6C%2FTsxqpb4%2FpvLDRyxdRTc1DBE0DV8%3D&reserved=0, according to your code change in the PR, you plan to upgrade the azure-mgmt-web to 0.44.0, and I will assume you want to use v2019-08-01 for AppService related commands. Is this you expected? And I am working on MultiAPI support for AppService and I think I can upgrade the api version for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fpull%2F11476%3Femail_source%3Dnotifications%26email_token%3DADJSYDC5M37GDZLZTSPU4RLQXCPSXA5CNFSM4JVOSNLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7V5MA%23issuecomment-561995440&data=02|01|sisirap%40microsoft.com|30152cbb801546ae6f3408d7794ecccc|72f988bf86f141af91ab2d7cd011db47|1|0|637111251661225638&sdata=1gyV9dmsI8ZbQBQHY5qwGZCyShGkNw%2BIXesRYHltaQk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADJSYDHWJIAXTNNIZHUOGG3QXCPSXANCNFSM4JVOSNLA&data=02|01|sisirap%40microsoft.com|30152cbb801546ae6f3408d7794ecccc|72f988bf86f141af91ab2d7cd011db47|1|0|637111251661235594&sdata=AEvyO92kcGseKAeNugoIr99hHVAhSOvntfkIEpzRwSo%3D&reserved=0.

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Try azdev setup -c -r azure-cli-extensions/ to install dependencies correctly. I have met this kind of error, too.

I think the multi-api version is taking longer than expected because the v2019-08-01 is not supported for hybrid & if we can just do the update to use the new SDK directly first & then figure out the multis-api support that would be great. let me know if this is something you can take care of.
Thanks
Sisira
Sent from Outlookhttp://aka.ms/weboutlook
…

Got it!

add to S163.

Hi @panchagnula  are you still working on this?

@Juliehzl / @qwordy/ @yonzhan my current changes should take care of supporting Multi-api support as well however, I cannot figure out the cause for the build failure - can one of you help me here please? Thank you.

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Is it still this error blocking you?

@qwordy can you help me figure out what is missing here since i see this error in dependencycheck "{'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.web.web_site_management_client'",)}"

Is it still this error blocking you?
I've seen the error in CI. ModuleNotFoundError: No module named 'azure.mgmt.web.v2019_08_01.web_site_management_client'

Yes, i got the tests to run & re-record but Linter is failing & Travis CI is failing with the same error as well https://travis-ci.org/Azure/azure-cli/jobs/631223111?utm_medium=notification&utm_source=github_status any ideas how to resolve this?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase  dev branch when it is ready.

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks  - let me know when the fix is in dev I will pull & rebase.

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

@Juliehzl any update on this please? Thanks!

@Juliehzl any update on this please? Thanks!

You can rebase the dev now and re-record for the test. I think it should work now.

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

Tried this & still the same error when trying to re-record          raise CLIError('{} {}'.format(message, code))
E               knack.util.CLIError: Unable to find the resource /subscriptions/e483435e-282d-4ac1-92b5-d6123f2aa360/resourceGroups/cli_test_metric_alert_v23gguxyyliai35ejxeklzrm6ujtf6jxegub4epaxunzrtchixrw7/providers/Microsoft.Storage/storageAccounts/clitestwgbiozzwakiu5pd3p, please confirm that it exists.. [Code: "BadRequest"] .

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Have you rebase the dev branch recently?

@Juliehzl/ @qwordy this PR is ready except for one test "test_metric_alert_v2_scenario"
https://dev.azure.com/azure-sdk/public/_build/results?buildId=223898&view=logs&j=201a69fb-575c-5f90-d252-d1ed1e360cc3&t=fb98e434-311f-5204-eaf4-065ec0de8a99&l=7680
I am unable to re-record this because the storage_account is missing can one of you help me with this- this is the last piece to get the build working. Thanks a lot!
that needs to be re-recorded

Hi @panchagnula, it is caused by storage service in monitor alert. We will do the change in dev branch and you can pull the latest dev and rebase dev branch when it is ready.

Sounds good thanks - let me know when the fix is in dev I will pull & rebase.

you can rebase dev branch now. if there is still problem, feel free to let me know.

Tried this & still the same error when trying to re-record raise CLIError('{} {}'.format(message, code))
E knack.util.CLIError: Unable to find the resource /subscriptions/e483435e-282d-4ac1-92b5-d6123f2aa360/resourceGroups/cli_test_metric_alert_v23gguxyyliai35ejxeklzrm6ujtf6jxegub4epaxunzrtchixrw7/providers/Microsoft.Storage/storageAccounts/clitestwgbiozzwakiu5pd3p, please confirm that it exists.. [Code: "BadRequest"] .

This test needs to be re-recoded with this change since this use Appservice plan command the api-version of which has been updated in this PR. Can I disable this test as a part of this, merge these & someone from the core team re-record this once this is in dev? Please let me know - this has been sitting in PR forever.

@Juliehzl please merge this PR by this week.

Hi @panchagnula, can you use az webapp deployment user show correctly?

Hi @panchagnula, can you use az webapp deployment user show correctly?

haven't checked will take a look. Is there a reason you are checking this? Is there some known issue you are aware of? Thanks!


querier: Added select benchmark

Signed-off-by: Bartlomiej Plotka<EMAIL_ADDRESS>Needed for future measurements. cc @spaparaju @ianbillett

PTAL @GiedriusS @onprem @squat @spaparaju  - I am kind of blocked on this to work on further querier optimizations. 🤗

Thanks, for review, I will fix this in next PR!


Backtrack limit hit with unbalanced parenthesis

Trying to processUrl the string ftp://(123456789012345678 will result in a PREG_BACKTRACK_LIMIT_ERROR (I think it has something to do with this ).
I don't understand why the linkifyUrl regex is trying to match balanced parenthesis, the above URL should be considered valid and there isn't any reason for ( or < to be balanced in an URL. (real life example: http://i.ebayimg.com/00/s/MTYwMFgxMDg5/$(KGrHqYOKjIE6Sv7R)(rBOw8jhvfD!~~60_35.JPG )

Bit late to reply, but the balancing is to cater for cases like Composer (further details at https://en.wikipedia.org/wiki/Composer_(software)) (the second closing parenthesis shouldn't form part of it).

Also with balanced parenthesis this bug occurs:
https://example.com/x_(aaaaaaaaaaaaaaaaa) (17 times 'a') will fail by resulting in a PREG_BACKTRACK_LIMIT_ERROR
https://example.com/x_(aaaaaaaaaaaaaaaa) will successfully return a match (16 times 'a')


'Ignore my visits' checkbox for logged in users

First up, thank you for this awesome project! :rocket:
I'd like an option to disable tracking for logged in users. Primarily I don't want my own visits to be counted when viewing my websites for monitoring/testing purposes. Setting an IP filter each time is not an option because my ISP gives me a new one each day.
If you generally like the idea, I'm happy to put a PR together :)

You can already do that. Just set umami.disabled to true in local storage.

I feel dumb now :laughing:.
Would you take a PR that makes this an option in the settings? Manually setting items in local storage on phones is pretty cumbersome...

You would have to add the value to your website, so having it under the admin wouldn't help.


Refactor OpenSSL 'DSA' EVP_SIGNATURE to also include DSA+hash and ECDSA+hash composites

Add EVP_PKEY_{sign,verify} and EVP_PKEY_{sign,verify}_message support for our DSA and ECDSA
implementations, allowing them to be accessed as composite algorithms.
Tests are added with test_evp stanzas.

This include the commits from #23416.  Only the last three commits are part of this PR

I've still to test ECDSA+hash, therefore this is still a draft.  It shows where things are going, though...

This one is now done and ready for review.  But please, #23416 first!

Rebased on top of a fresher #23416

Rebased again on top of a fresher #23416

Now that #23416 has been merged, time to review this!

Should we even bother with adding composite DSA signatures?

Completeness...  and quite frankly, not that hard

Your new test files obviously need FIPSversion in them for the cross tests

The CI is relevant.

ping @levitte for CI fixes

Needs a rebase now

Please note the previous push failed some provider compat checks and I assume this will fail as well. So this is the last thing to resolve and I'll approve this.

Please note the previous push failed some provider compat checks and I assume this will fail as well. So this is the last thing to resolve and I'll approve this.

Hmmmm...  I though I had made appropriate changes to test/evp_test.c to simply skip if the algo couldn't be fetched.  I'll have another look

Ahhhh, I need to add FIPSversion lines...

Done

@mattcaswell Please reconfirm

Lots of CI failures...

Yeah, I missed a few stanzas when adding "FIPSversion = >=3.4.0"
Hope I got them all now

Should I squash the fixup commits and push that (on top of same base)?  The force-push link will show if anything changed.

Should I squash the fixup commits and push that (on top of same base)? The force-push link will show if anything changed.

IMO no need to.

@levitte please rebase this.

Rebased.

24 hours has passed since 'approval: done' was set, but as this PR has been  updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to the master branch. Thank you.


Create LinkedIn page

Create a LinkedIn "company" page for the project.

The page was created: https://www.linkedin.com/company/enarx/


Add window flag colors32b (and fixes)

Add a new window flag that define each colors channels size to 8 bits
Fix lime.graphics.format.PNG.fromBytes() and lime.graphics.format.JPEG.fromBytes()
Fix android lib path for Android armv7

Is there any questions about that PR that could help merging ?
(Not sure who is the one to ping ?)
@larsiusprime  or @jgranick

I'm not the best person to ask about this :) But in any case, it might help to describe what problem this solves for you?

Oh sorry for the ping then...:)   ( Is there a link with people who administrate a repo ?)
The window flag allow to set Opengl with full color resolution (8bits per canal) instead of the 565 which is used by default.  For some of our games, having full color resolution makes gradients really look different ;)
About the PNG/JPG, it allows a MUCH faster texture loading, since there's no need to make bytes conversion (copy).
That is for the most important adjustments.

Thank you for this! I apologize for the delay in merging this in. It should be available now use <window color-depth="32" />
Do you think we should do this by default? I wonder how many applications need the extra colors, and don't mind the extra memory.


cmd/compile: relax recursive restriction while inlining

package main

func main() {
	f(100)
}

func f(x int) {
	if x < 0 {
		return
	}
	g(x - 1)
}
func g(x int) {
	h(x - 1)
}
func h(x int) {
	f(x - 1)
}

The compiler refuses to inline anything in this example:
$ go tool compile -m=2 tmp.go
tmp.go:7:6: cannot inline f: recursive
tmp.go:13:6: cannot inline g: recursive
tmp.go:16:6: cannot inline h: recursive
tmp.go:3:6: can inline main as: func() { f(100) }

There's no reason to not inline, e.g., g into f.
As long as we're not inlining a function into itself, it should be ok (and even that might be ok, as long as we don't do it an infinite number of times).
This comes up only with mid-stack inlining. When we only inlined leaves, it was perfectly reasonable to abort on recursion. Now we don't have to.
This came up when looking at runtime.pcdatavalue. I had a CL (CL 157799) which modified it, and the modified version should have inlined. It didn't because of this issue, because pcdatavalue it is part of a reasonably large recursive loop.

Nothing planned for 1.13, punting.

I just ran into a similar problem again; also in my case the recursion loop was fairly big and, crucially, it involved non-inlineable functions (both way over budget as well as containing non-inlineable constructs). In the spirit of @josharian CL this would require filtering out not just functions marked as noinline, but also any function that effectively has no chances of being inlined.


user params: source containers: remove filesystem_koji_task_id

This param is unused in case of source containers.

OSBS-8040

Signed-off-by: Martin Bašti<EMAIL_ADDRESS>Maintainers will complete the following section:

[x] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[ ] Pull request includes link to an osbs-docs PR for user documentation updates

no release notes needed, part of unreleased feature


Replace text input on search for G-Cloud services journey

https://trello.com/c/GRm5KiLE/111-2-replace-text-input-component-in-search-for-g-cloud-services-journey-except-keyword-search
Walked through this journey and there's only one form which directly uses text inputs.

/buyers/direct-award/g-cloud/save-search uses toolkit/forms/selection-buttons.html which reveals an inner text input.
/buyers/direct-award/g-cloud/projects/<id>/did-you-award-contract has two text inputs:

One is for currency. I've not converted this one because the Design System Form input prefix/suffix variant is due to be published soon, and we should use that to display the currency symbols.
The other field I've replaced directly with a govukInput macro using existing form data.

[ ] Have run local tests
[ ] Have run functional tests locally

One is for currency. I've not converted this one because the Design System Form input prefix/suffix variant is due to be published soon, and we should use that to display the currency symbols.

That's great news!


"Oops .... Face Verification disabled. Please try again."

Description
I am a new user. Created an account this morning.

Steps to reproduce
Got this (screenshot attached) when trying to claim, despite enabling camera. I get this both on my smartphone and laptop.
Which network did you use?

Supporting data
Screenshot attached.

@jerzybrzoska thanks. should be fixed now


Update documentation and follow best practices

[x] Please follow best practices for documentation, e.g. add information about installation of app generator to "Installation" and add info for different setups.
[ ] Add installations instructions for Digital Ocean and only show standard badge once at Readme.md. if possible find a badge similar size and style as other existing badges. Take out references elsewhere.
[x] Add installations instruction for Google Cloud
[x] Add installations instructions for AWS
[x] Also, please check spelling and punctuation.
[ ] Make screenshots in a row on Readme.md
[x] Add a gitter channel badge
[x] Add info to the mailing list
[x] List supported Android versions and devices tested
[x] Move coding conventions to /docs

Some parts are still left, i'll send a PR for them too :)

Great 👍

@the-dagger Goal of this issue was to follow best practices and make it easier for people to understand the project. We have not achieved this yet. Instead of having a dedicated installations.md for digital ocean you simply renamed documents and it starts to be confusing. Please check how others are doing this regarding installations instructions: https://github.com/loklak/loklak_server/tree/development/docs

Please also update the generator screenshots and add them into the repository instead of outside links.

Ok @mariobehling I'll add a gif file too similar to the webapp outlining the walk-through our generator.

@the-dagger I think this is done, so we can close this.


Prevent cloudwatch logs link opening in the same tab

Improves behaviour as this is a different website, it should open in a new tab.

I agree. Thanks for your contribution.

Can you also confirm that your change is under Apache 2.0?

Yes my change is under apache 2.0


Globally exclude ObjC product and targets for Linux

So that Swift Package Index can recognize the Linux support of the
package.

The test errors on Linux look like a bug on Linux's Foundation to me. I opened a PR there: https://github.com/apple/swift-corelibs-foundation/pull/4861 🤷


Tracking Issue: Linux poses are delayed after awhile.

Description
When playing on Linux after a few moments the pose starts lagging behind the actual pose on the headset until it becomes so late something completely breaks and the headset freezes.
Hardware
GPU:
RX 6700XT
GPU Driver Version:
mesa-git
Installation
ALVR Version:
sync-sockets branch
ALVR Settings File:
SteamVR Version:
1.26.7
Install Type:

[ *] Source

OS Name: EndeavourOS

after the latest commits it no longer freezes but lags and recovers. I think it's still worth having this bug stay open.

Resolved


Remove unused method

Won't Rails run bundle install before suspender does, running it twice?

Yes I think this method is called by the normal rails app generator and we're just putting it off until later.

Yes, I think the intent of this method to prevent Bundler from running twice. If this commit were to be merged, I think we'd revert to that, slower behavior.
We invoke bundle install at the moment we want it, inside the customize_gemfile method, on line 61 of lib/suspenders/generators/app_generator.rb

Oh I'm sorry. Didn't think about inheritance,

If you'd like to update the PR, skip_bundle could be an improvement, making the code clearer IMO.

Agreed on skip_bundle. Clearer, more intentional API.

Ok I'm gonna update it :)

Updated :)

:+1:

Thanks!


LibWeb: Prevent checkboxes from firing change events when losing focus

Toggling the checkbox is committing a specific value so the change event should not be re-fired when the checkbox looses focus.
I think this should also apply to radio buttons but I haven't checked and also never used one, so I'm not including that in this PR for now.
A specific page that is fixed by this is the very bottom 'Developer Options' checkbox at https://battle.crossuniverse.net/settings/index.html which currently incorrectly hides the options it revealed when losing focus.

Can we add a test?

Can we add a test?

Yes, done.


Feature Request: Custom OpenAI API address

I've built my own nginx to reverse proxy api.openai.com to bypass regional access restrictions.
Is it possible to add a configuration to sets the custom API server?

Thanks! Happy to accommodate the change. See feedback in the PR


Type does not change from 'info'

Hi,
I initialize growl this way, as suggested in the docs:
 $.growl(false, {
    delay: 4000,
allow_dismiss: false
});

then, when my own success(message) metod is called I do:
$.growl({
    icon: "fa fa-check-circle-o fa-lg",
    title: " Success! ",
    message: message,
    type: 'success'
});

But the notification is always of type info.
Thanks
Andrea

I'm a dumb, sorry.

Not dump it is the most common mistake made... And is mostly my fault for doing things differently than most plugins.

 I can't even understand why my notification can't change from danger to any other types

Sorry, I'm dumb too. :sob: I typed 'type' twice.


Faster and more stable Docker image mirror sites

It is extremely slow and unstable to download the Docker images from quay.io at least in China even without being behind a firewall or using a proxy. Running env.configure(remotes=1) always ends up with errors immediately or after waiting for dozens of minutes. Would you please set up a Docker registry mirror in China?
docker.errors.APIError: 500 Server Error: Internal Server Error ("{"message":"Get https://quay.io/v2/openai/universe.world-of-bits/manifests/0.20.0: net/http: TLS handshake timeout"}")
universe.remotes.compose.progress_stream.StreamOutputError: read tcp <IP_ADDRESS>:34020-><IP_ADDRESS>:443: read: connection reset by peer
universe.remotes.compose.progress_stream.StreamOutputError: net/http: TLS handshake timeout
docker.errors.APIError: 500 Server Error: Internal Server Error ("{"message":"Get https://quay.io/v1/_ping: net/http: TLS handshake timeout"}")

I think that's a different problem than the China-US connection. The file it's getting an error on (https://quay.io/v2/openai/universe.world-of-bits/manifests/0.20.0) is only 35 kB. I think you are being blocked by a firewall.

I think that's a different problem than the China-US connection. The file it's getting an error on (https://quay.io/v2/openai/universe.world-of-bits/manifests/0.20.0) is only 35 kB. I think you are being blocked by a firewall.

Probably due to the G*W. No VPN available to bypass it.

Probably due to the G*W. No VPN available to bypass it.

An alternative choice is to host on hub.docker.com which has several free mirrors.
DaoCloud Announces Docker Hub Mirror service is permanently free
http://blog.daocloud.io/daocloud-mirror-free/
https://translate.google.com/translate?sl=auto&tl=en&js=y&prev=_t&hl=en&ie=UTF-8&u=http%3A%2F%2Fblog.daocloud.io%2Fdaocloud-mirror-free%2F&edit-text=
https://c.163.com/hub#/m/home/
https://dev.aliyun.com/search.html

An alternative choice is to host on hub.docker.com which has several free mirrors.
DaoCloud Announces Docker Hub Mirror service is permanently free
http://blog.daocloud.io/daocloud-mirror-free/
https://translate.google.com/translate?sl=auto&tl=en&js=y&prev=_t&hl=en&ie=UTF-8&u=http%3A%2F%2Fblog.daocloud.io%2Fdaocloud-mirror-free%2F&edit-text=
https://c.163.com/hub#/m/home/
https://dev.aliyun.com/search.html

We can also push to docker hub. The current versions are there, so
docker pull openai/universe.world-of-bits:0.20.0

works. I tried
docker pull m.daocloud.io/openai/universe.world-of-bits:0.20.0

but that didn't work. Do we have to register the repository with daocloud, or does it work for you by setting registry-mirror?

We can also push to docker hub. The current versions are there, so
docker pull openai/universe.world-of-bits:0.20.0

works. I tried
docker pull m.daocloud.io/openai/universe.world-of-bits:0.20.0

but that didn't work. Do we have to register the repository with daocloud, or does it work for you by setting registry-mirror?

Thanks a lot! It works. DaoCloud needs to be signed in to get a personal mirror ID.
https://www.daocloud.io/mirror#accelerator-doc
curl -sSL https://get.daocloud.io/daotools/set_mirror.sh | sh -s http://MIRRORID.m.daocloud.io
docker pull openai/universe.flashgames:latest
docker pull openai/universe.gym-core:0.20.0
docker pull openai/universe.world-of-bits:0.20.0

Since the automatic local remotes still tries to download from quay.io, manual remotes has to be created which is cumbersome. export OPENAI_DOCKER_REPO=docker.io/openai solved the problem. The flashgames runtime's latest version "0.20.15" has to be replaced with "latest" in runtimes.yml to use the mirror. The document should also be improved.

Thanks a lot! It works. DaoCloud needs to be signed in to get a personal mirror ID.
https://www.daocloud.io/mirror#accelerator-doc
curl -sSL https://get.daocloud.io/daotools/set_mirror.sh | sh -s http://MIRRORID.m.daocloud.io
docker pull openai/universe.flashgames:latest
docker pull openai/universe.gym-core:0.20.0
docker pull openai/universe.world-of-bits:0.20.0

Since the automatic local remotes still tries to download from quay.io, manual remotes has to be created which is cumbersome. export OPENAI_DOCKER_REPO=docker.io/openai solved the problem. The flashgames runtime's latest version "0.20.15" has to be replaced with "latest" in runtimes.yml to use the mirror. The document should also be improved.

@futurely Thanks! We'll make it work seamlessly and document this for other people in China.

@futurely Thanks! We'll make it work seamlessly and document this for other people in China.

I added a note on this to the wiki: https://github.com/openai/universe/wiki/Solutions-to-common-problems#docker-wont-pull-images

curl -sSL https://get.daocloud.io/daotools/set_mirror.sh | sh -s http://MIRRORID.m.daocloud.io
I get "OS not supported error". This seems to be the command line for linux. How do I get it to work on Mac?

daocloud.io did not update the mirrors very timely. Try the official site quay.io first.

@Fredilly , add  http://MIRRORID.m.daocloud.io to Registry mirrors of Mac Docker[Daemon preference], you should get a MIRRORID in daocloud.io. But as @futurely said, daocloud.io doesn't update the mirror timely, so for users from China, the best way to pull the image is to pull the image on a VPN and send the image to your host.

@Fredilly If you want to use DaoCloud, then I guess you are in China, I have written a small article about how to download Docker images through proxies you already set up, maybe it can be helpful: https://zhuanlan.zhihu.com/p/26033249


simplified import logic

I simplified some of the code for importing json and yaml files.
Instead of saving the flags before unmarshalling, we can simply parse the flags again after we've read in the file.

How does this work?  If the flags aren't parsed until after the import file is read then how does the program know what the import path flag is set to?
Does it parse internally and the .Parse() call just does so again?


About player direction

Hello!
Could you plz tell me that the graph below is correct for play direction calculation?

........
info.player_direction =
(movement / GetGameConfig().physics_steps_per_frame).coords;
........
if not,plz tell me the corrent answer!Thank you very much indeed!!!

I have no idea, depends on what all these variables mean :) needs more context..
In general, a direction would be normalized, while movement isn't, so info.player_direction = movement.GetNormalized(0); would make more sense. But it really depends on what you want, where movement comes from, what info.player_direction is, etc..

I have no idea, depends on what all these variables mean :) needs more context..
In general, a direction would be normalized, while movement isn't, so info.player_direction = movement.GetNormalized(0); would make more sense. But it really depends on what you want, where movement comes from, what info.player_direction is, etc..

Hello!The context is below:
void Match::GetTeamState(SharedInfo *state,
std::map<IHIDevice *, int> &controller_mapping,
int team_id) {
DO_VALIDATION;
std::vector &team =
team_id == 0 ? state->left_team : state->right_team;
team.clear();
std::vector<Player *> players;
GetAllTeamPlayers(team_id, players);
for (auto player : players) {
DO_VALIDATION;
auto controller = player->GetExternalController();
if (controller) {
DO_VALIDATION;
if (team_id == 0) {
state->left_controllers[controller_mapping[controller->GetHIDevice()]]
.controlled_player = team.size();
} else {
state->right_controllers[controller_mapping[controller->GetHIDevice()]]
.controlled_player = team.size();
}
}
if (player->CastHumanoid() != NULL) {
DO_VALIDATION;
auto position = player->GetPosition();
auto movement = player->GetMovement();
if (team_id == 1) {
position.Mirror();
movement.Mirror();
}
PlayerInfo info;
info.player_position = position.coords;
info.player_direction =
(movement / GetGameConfig().physics_steps_per_frame).coords;
GetGameConfig().physics_steps_per_frame).coords[0])<<","<<"y:"<<std::to_string((movement / GetGameConfig().physics_steps_per_frame).coords[1])<<","<<"z:"<<std::to_string((movement / GetGameConfig().physics_steps_per_frame).coords[2])<<"\n";
info.tired_factor = 1 - player->GetFatigueFactorInv();
info.has_card = player->HasCards();
info.is_active = player->IsActive();
info.role = player->GetFormationEntry().role;
if (player->HasPossession() && GetLastTouchTeamID() != -1 &&
GetLastTouchTeam()->GetLastTouchPlayer() == player) {
DO_VALIDATION;
state->ball_owned_player = team.size();
state->ball_owned_team = GetLastTouchTeamID();
}
team.push_back(info);
}
}
}

Ahh I see.. but I have no idea about Google's code, and I don't really have the time or energy to put into helping people with custom code. I hope maybe someone else can come along and help you here, so I'll leave this topic open. Good luck :)

Ahh I see.. but I have no idea about Google's code, and I don't really have the time or energy to put into helping people with custom code. I hope maybe someone else can come along and help you here, so I'll leave this topic open. Good luck :)

^_^

Ahh, ya veo ... pero no tengo idea sobre el código de Google, y realmente no tengo el tiempo ni la energía para ayudar a las personas con código personalizado. Espero que alguien más pueda venir y ayudarte aquí, así que dejaré este tema abierto. Buena suerte :)

^ _ ^

you could compile the game


Increase the editor profiler frame history default and maximum limit (3.x)

3.x version of https://github.com/godotengine/godot/pull/61481.
The new default value (1800) allows storing 30 seconds of profiling at 60 FPS.
The new maximum value (10000) allows storing about 3 minutes of profiling at 60 FPS.
The profiler graph will scale accordingly to the chosen setting, so the default value is kept relatively low to prevent the graph from looking too squished on narrow displays.

Thanks!


streamline upstream release process

Feature Request
A clear and concise description of what the problem is. Example: "I have an issue when (...)"
The current release process defined in https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/release.md is manual and error-prone. It would be better to have a more consistent release cycle with less manual steps involved.
Maybe using a workflow with goreleaser like in https://github.com/operator-framework/operator-sdk/blob/master/.github/workflows/deploy.yml could be the right step forward.
Describe the solution you'd like
We can cut more upstream releases faster and in a more automated way

Related to #1812

Related to #2129

I think the spirit of this issue has largely been addressed by the goreleaser changes implemented, closing.


Available Projections?

Hi Stefan,
If memory serves, Deck.GL only supports rendering maps in EPSG:4326 (WGS84). Is this library similarly constrained? I could not seem to get a basemap to render in another projection.
Chris

Yes, MapLibre GL only supports  Web Mercator (EPSG:3857) projection.
btw if you want to mix Deck.GL and MapLibre layers, this is now possible in the latest version:

https://eodagmbh.github.io/py-maplibregl/deckgl/
https://eodagmbh.github.io/py-maplibregl/examples/deckgl_layer/
https://eodagmbh.github.io/py-maplibregl/examples/deckgl_multiple_layers/

Hi Stefan,
I appreciate the clarification! And that is awesome news about mixing Deck.GL and MapLibre layers!


WIP: feat(search): additional wildcard search param

We've found multiple situations where it would be useful to "force" wildcards in certain searches rather than expecting users to append a * every time.

We found a more appropriate place for this search parameter/code to live, closing this request


Manage Discord Channels

Generate channels and Discord permissions based on KAUTH game groups.

Create a channel
Delete a channel
Update permissions to have access for certain groups

Is this even possible?

No need for this.


update opentelemetry external dependencies

update opentelemetry-sdk to version 1.11.0
update opentelemetry-api to version 1.11.0
update opentelemetry-exporter-logging to version 1.11.0
update opentelemetry-exporter-jaeger to version 1.11.0

Looks good to me. The PR did not trigger builds for exporter and attestation. Please run those pipelines too before merging.

/azp run java - attestation - ci

/azp run java - monitor - ci

/check-enforcer evaluate


JQLite .attr('foo', null) sets foo to 'null' on IE9, FF, Chrome

Bug: jqlite's .attr function with null value should remove the attribute (jquery does), but sets it at value 'null' on some browsers.
Repro: angular.element('

').attr('xyz', null) should return

, but returns

.
Affected: IE 9, Firefox 49, latest Chrome
Not affected: IE 10 and 11

This has been fixed on master (with 4e36245), but I am afraid it would be a breaking change to backport to 1.5.x. (One can always use .removeAttr() for removing.)
Does anyone feel it should be fixed in 1.5.x as well?

It doesn't inconvenience me, so I don't mind either way. Documenting the issue and fixing it in the next release seems fine.

We are close to releasing 1.6 now so I vote for not fixing this in 1.5

It's a breaking change so IMO it should wait for 1.6.

We've decided to wait for 1.6.0.

@rjamet there are other issues that I've recently fixed, see e.g. 3faf4505732758165083c9d21de71fa9b6983f4a & 7ceb5f6fcc43d35d1b66c3151ce6a71c60309304. They are described as breaking changes so people reading the migration guide will get that, do you think it should be also documented on the angular.element page? Currently we only have one-line descriptions there, basically saying what a particular jqLite's method doesn't support compared to jQuery or how it differs.

I don't think this is worth updating the docs, since these differences are fairly obviously bugs and not intended behavior? Maybe a pointer to https://github.com/angular/angular.js/labels/component%3A jqLite would be enough instead. The simplicity of the jqlite doc is a good thing IMO :)
I'm working with Jqlite/Jquery ATM, hence why I rediscovered these independently, and I just didn't think of checking whether they were already fixed at head.


Issue with k8s.io/docs/concepts/configuration/secret/ Incorrect references to readOnly

This is a Bug Report

Problem:
Multiple references to readOnly true.    readOnly defaults to true and it is no longer possible to set readOnly to false
Proposed Solution:
Remove references to readOnly
Optionally comment that secrets are not editable within a pod
Page to Update:
https://kubernetes.io/docs/concepts/configuration/secret/

Kubernetes Version:
I'm on 1.15. I believe this change was made in 1.9
Additional Information:
https://github.com/kubernetes/kubernetes/issues/62099
Related, but not the same as https://github.com/kubernetes/website/issues/4491

Thanks for creating this issue, now I also learned about this! The flag ReadOnlyAPIDataVolumes has been removed within k/k PR 67951 since v1.12, see CHANGELOG.
I think the pages about APIDataVolumes, like secret and configMap, these content should be changed.
/language en
/kind documentation

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale


fix: duplicate symbols during link on OsX

As explained in #37, I face strange link errors on my OsX machine.
After some search, it seems to be related to this commit https://github.com/Ponup/php-sdl/commit/1161d7272c553352a8e14cba15334af47ee44137
It moves internal variables from .c files to corresponding .h files, to share them with surface.c. As far as I remember my C, we have to put an extern declaration in header file and to let the concrete definition in .c file, exactly to prevent multiple definitions. But I can't figure why it worked correctly on other environments… is it due to a special configuration on my machine?
Furthermore, why the shown  duplicated symbol is _php_sdl_pixels_ce since the declared symbol is php_sdl_pixels_ce (without _ prefix)? Is it related to a secret Php macro?
What do you think? 🤔
Thanks, have a nice day 😄
fix #37

I think PR #39 is a better fix, more consistent with other objects, using the already existing getter.

Following @remicollet 's advise I am closing this PR and merging #39. Thanks both!


codes generated without corresponding proto provided

I accidentally failed to download google/protobuf/descriptor.proto but fount that google/protobuf/descriptor.ts still be generated by telescope.

I think this is intentional for the super basic protos :)


upload porcoddiocoin images/0x9e6322262bd83920b2ce7692570e30a79f333e66.png

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ ] Filename in the lowercase format
[ ] Image format: png
[ ] Image size: 256 by 256 px

Please upload just one picture


Customize expiry fields

As per docs:
          <div class="modal-content card-js">
            <input class="card-number" name="own-name">
            <input class="expiry form-control"
                   autocomplete="off"
                   required>
            <input class="expiry-month" name="my-expiry-month__card-expiry-month">
            <input class="expiry-year" name="my-expiry-year__card-expiry-year">
            <input class="cvc" name="my-cvc">

card-number field and cvc field names are customized. However, expiry params are send as expiry-month and expiry-year

sorry. This can be closed. I was using old version

No worries. If you find anything else let me know.


quic_multistream_test: Output info about connection close reason

In case the connection close error code is unexpected print out the reason to help with diagnostics.

See also #22485

This pull request is ready to merge


Pathing 2.0

Rebuilt the pathing engine without using Paper.JS. We will continue to built off this new structure for all other features.

We'll ignore the coding standards errors for now, but they are still worth addressing at some point

Okay, Paper has been removed.


Take h_separation into account for label and icon positions (item_rect)

Description
This PR makes it so that when drawing an item_rect the h_separation is taken into account when computing the icon and label positions. The immediate effect is that TreeItem icons in the Editor are no longer drawn "hogging" the item's border, which was specially perceptible when using a Corner Radius greater than 3.
Comparisons

Default with Corner Radius 3

PR with Corner Radius 3

Default (RTL) with Corner Radius 3

PR (RTL) with Corner Radius 3

Default with Corner Radius 6

PR with Corner Radius 6

Also, is there any particular reason on why antialiasing is not enabled by default in the Editor Theme?

I guess the root problem then is that the item_rect themselves don't have a stylebox, right?
They only get one if they're focused and/or selected.
If we were to add a default StyleBox to them, then I guess we could solve this problem through the Content Margins.
What do you think?

Yeah, that sounds like a good idea. Just need to make sure that in the default theme that stylebox doesn't do anything (so existing themes work as expected).

Yeah, that's a good idea.
Working on it right now!

Closing due to https://github.com/godotengine/godot/pull/74321, which implements this feature as discussed.


PackageReference questions

From https://docs.microsoft.com/en-us/nuget/guides/create-net-standard-packages-vs2017#comments-container:
a. How to include additional files?
b. How to use semantic versioning for suffixes?

From https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#comments-container
a. When I try to reference a .NET Standard library with PackageReference to any NuGet package from a classic .NET application it compiles normally but throws FileNotFoundException at runtime. Does it mean that it is not possible to mix .NET Core and classic .NET in the same solution? Or is it a bug?

Customer comment: "How to add library not as reference?"

These have been answered.


DOC add documentation on output formats

Added a table to the documentation detailing the columns that argNorm adds to ARG annotation tools' outputs. Also mentioned how argNorm displays the software version used in the output tsv files.

Hello @luispedro are there any other comments you would like me to address in the PR?


Create Copy String.cpp

@JituJakhar2000 please star the repo if u think this helped u for hacktoberfest :)


Use golangci-lint on lint

:construction:

Codecov Report
Patch coverage has no change and project coverage change: -27.27 :warning:

Comparison is base (841e3b0) 60.91% compared to head (788a3f6) 33.64%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2189       +/-   ##
===========================================
- Coverage   60.91%   33.64%   -27.27%
===========================================
  Files         182      182
  Lines       15204    15207        +3
===========================================
- Hits         9261     5116     -4145
- Misses       4794     9368     +4574
+ Partials     1149      723      -426

Flag
Coverage Δ

acceptance-api
?

acceptance-apps
?

acceptance-cli
31.68% <0.00%> (-25.60%)
:arrow_down:

unittests
8.54% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/api/v1/application/update.go
0.00% <0.00%> (-65.81%)
:arrow_down:

... and 107 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feat: add Waline comment system support

Because of security, I want to add Waline comment system support, and it adapted for dark mode.

Hi @guohoo,
Thanks for your contribution! Can you also write the related docs here? After that I can review it.

Hi @guohoo,
Thanks for your contribution! Can you also write the related docs here? After that I can review it.

OK, but it may not start until this weekend. I am preparing for my exam recently.

Don’t worry, good luck with your exam!
在 2022年3月8日，22:32，Mashiro @.***> 写道：

OK, but it may not start until this weekend. I am preparing for my exam recently.
—
Reply to this email directly, view it on GitHubhttps://github.com/wangchucheng/hugo-eureka/pull/169#issuecomment-1062519902, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEXGNAQBM5GDEBBXUIAVH3U7ALT3ANCNFSM5QEBGMDA.
You are receiving this because you commented.Message ID: @.***>


[docs-only] Add oCIS 1.0 Release Notes

@butonic We have an TODO in the storage features description. Any ideas?


job #9191 masl problem markers

This is a couple bug fixes I made while isolating #9335:
job #9354 Added no-arg constructor
The work done for issue #9316 via pull request https://github.com/xtuml/bridgepoint/pull/388 introduced a new constructor for class PullSynchronizationChanges.java (the implementation for the Sync With Library CME). As a CME, a no-arg constructor is needed for this too. I introduced one in this change. This clears up an NPE that is observed when right-clicking a model in ME. This NPE is caused when the Eclipse infrastructure attempts to see if this CME action should be displayed or not.
job #9354 Ignore problem markers associated with multi-buffer editor
The work done for issue #9191 view pull request https://github.com/xtuml/bridgepoint/pull/375 introduced changes to allow problem markers in the problems view to open the single-buffer masl editor instead of opening the masl file itself. This change causes NPEs to occur any time the masl error finds errors in a ".mod" file. To resolve this, this change causes only error markers for ".masl" and ".xtuml" to be used to associate masl errors with model elements in the ooaofooa.
As part of this change, the file resource that the error is actually coming from is now being passed along into the routine that links the error to a ooaofooa resource.
job #9354 Always create an error marker when xtext tells us
In ModelResourceUIValidatorExtension.java, if we can't find the xtuml resource then use the default marker creation
The is a change associated with #9191 pull request
https://github.com/xtuml/bridgepoint/pull/375 . The work done in #9191 was only considering error found in .masl files where the .masl file
was associated with an error in an xtuml file that was in the same folder. This assumption is bad now that masl projects have been introduced.  This change improves error marker behavior now that masl project support has been introduced.

When you promote this please put a link to this pull request in #9191 to make it easy to see this additional change to that issue.