Parser: introduce endless method syntax

Fixes #9080
Just for fun. Doesn't mean we are going to go with this.
Let's keep the discussions on #9080
But given that Crystal already tries to be succinct... for example we have def initialize(@name), or we have record Point, x : Int32, y : Int32... maybe not having to write a full method body, end included, is nice. Specially for really short methods that are just literals, forwarding, small stuff like that.

Ugh, I have an implementation for this RFC when I opened issue... It is said that early implementation with less discussion makes confusing sometimes, so I keep secret this patch.
Like exhaustive case, I'm sick that my name is missing from my own proposal!

@asterite  I know my wish is selfish, and it goes smoothly if I hand over the baton to you, but... Could you entrust the job to me?

You can send a different PR with the same code or similar, it's fine

It is said that early implementation with less discussion makes confusing sometimes, so I keep this patch secret

You are right. I think it's fine if you send an issue, then a PR saying "this is in case the issue gets accepted".
In my case I was just curious to see how hard this would be to implement, and how it felt using it. Then I sent the PR so it doesn't get lost in case we need it.
But feel free to send a separate PR

Meh, beginners used to C style are able to not fully embrace Crystal style:
def test = (
  a = 0
  a += 1
  a += 2
)

That a "danger" of this proposal, which will defeat its initial purpose of declaring short methods.
Another point, on this implementation, return type annotations are still not valid:
Invalid code:
def test1 : Int32 = 0
def test2(x : Int32) = x

Result for both methods: Error: unexpected token: =

@j8r My implementation allows return type annotation of course. And, I think we should not discuss about the specification in Pull Request. Please go to #9080.

@j8r anyone can write crappy code, even before this proposal

@asterite truer words have never been said

I kinda like this. Will I use it much? Probably not. But I can see why it was added to Ruby.

@watzon Don't discuss about syntax here. Go to #9080.

@MakeNowJust wasn't a syntax discussion. I was voicing my support for the PR. I am fully aware of #9080.

@watzon Sorry for harsh words.


Update poolscpu.json

Added pool Mining4People to PoolPicker.

First request's, please review with that in mind.

I there a reason for the Pull request is not added?


modified sidebar ui

modified sidebar ui

@ i think this is because the contact page itself not responsive. There is a issue in this regard. this will resolve automatically after completing that issue

ok no issues


Handle insertTranspose for beforeinput event

Pressing ^ + T works in Safari since it triggers onbeforeinput with inputType=insertText, while chrome uses inputType=insertTranspose:
fix #2751
https://user-images.githubusercontent.com/132642/182932055-f9a849a7-28f8-40c8-a320-312a2d4afb44.mov

Tested with other Emacs key bindings (i.e. CTRL+A to go to the start of a line) to verify fix works.


Ways to find posts which were not autoflagged

The new autoflagging functionality is awesome, but in order to make it even more awesome, we need some way to find the posts which were still not autoflagged, so that we can analyze them and figure out additional heuristics we could put in the system in order to catch similar posts in the future.
I'm vague on what exactly would be useful, and only posting the use case at this point.  I can think of some ways which should hopefully be reasonably straightforward, by order of (my limited perception of) apparent complexity.

[ ] Similar to the flagged log https://metasmoke.erwaysoftware.com/flagging/logs display a timeline of just the posts which were not flagged
[x] Throughout the system, expose the flag weight in places where currently we display a summary (title, site, timestamp, user, feedback icons, etc) -- this overlaps with issue #50 to some extent
[ ] Expose the flag weight in the search form as a searchable field

#2 084d6ad296530856cce4c4b7c367c10b5e4d7b06

Point 3 was requested again: http://chat.stackexchange.com/transcript/message/34498185#34498185

Would it make more sense to close this and reopen #53?

No, this one works. It's on my radar, just need to find time to do it.

Unless flag weight became a field in posts, I really think this is too expensive to be possible.

Blazer delivers this and much more. Thanks for providing it!
Sent with GitHawk


Create custom comparator for sorting the ArrayList

I would like to contribute to the project , if you are okey i could add this project to the folder structure > Data Structures & Algorithm/Arrays/

sounds good go for it

Thanks I will do it


bower version

please update/add 3.1.5 as last bower version. thx ;)

I am just getting back to this plugin. I switched careers and lost a lot of free time. I am back to programming so my time is more of what I used to be at. I do plan on looking into updating the bower version of this. Please give me a week or so.


Add support for other VisUI features

I will list all features unique for VisUI so we can discuss what will be added to lml-vis.

[x] CollapsibleWidget
[x] NumberSelector (see PR #4)
[x] LinkLabel (see PR #5)
[x] VisValidableTextField and validators
[x] SimpleFormValidator
[ ] FormValidator (missing file validators - not supported on GWT)
[ ] Separator (btw VisTable has addSeparator(), is it supported?)
[ ] ColumnGroup - we will probably skip this, since libgdx has it's own VerticalGroup which is already supported by LML
[ ] GridGroup
[x] TabbedPane
[x] [MenuBar and PopupMenus] (https://github.com/kotcrab/VisEditor/wiki/PopupMenu-and-MenuBar)
[x] Tooltips

DIalogs

[ ] [File chooser] (https://github.com/kotcrab/VisEditor/wiki/File-chooser) - will (probably) be added as an attribute.
[x] [Color picker] (https://github.com/kotcrab/VisEditor/wiki/Color-Picker) - will (probably) be added as an attribute.
[DialogUtils] (https://github.com/kotcrab/VisEditor/wiki/DialogUtils) - not supported; LML is already great at constructing simple dialogs, no need to replicate this functionality when you have more flexible macros.

CollapsibleWidget
If you add support for initial null actor (Table) and add an actor setter in VisUI, we can create a similar tag to container: it basically begins empty and allows to eventually add one actor. Then it could be used like this: <collapsible><table>(...actors...)</table></collapsible>. Or we could extend TableLmlTag, create the table in the tag class and return it as the main widget (allowing children to access table tags), but it would need some extra "hacks" during attaching - we'd need to replace the original actor with out collapsible. I think the first solution would require less work overall.
NumberSelector
Extend VisTableLmlTag, return FloatRangeLmlActorBuilder for initial value, min, max and step size support, cast the builder to create a new instance. Add precision attribute. Pretty straightforward, you can try to do this.
LinkLabel
Extend VisLabelLmlTag, initiate LinkLabel with text from TextLmlActorBuilder and an empty URL. Add an attribute (link, url, uri, ?) that uses `setUrl(CharSequence). No need for a new builder. Easy one.
VisValidableTextField
The actor itself is trivial to add (extend VisTextFieldLmlTag, no additional attributes), but I'd need to add validators as tags or macros.
FormValidator
It can be an attachable tag, kind of like tooltips were implemented. I'll need to look into this.
Separator
Simple non-parental actor, extend AbstractNonParentalActorLmlTag. Use AlignedLmlActorBuilder for initial vertical/horizontal status. However, separators do not use the usual style name schema (default-horizontal/default-vertical), so we might need to do some magic before using a custom style (using AlignedLmlActorBuilder, returning different style names?).
ColumnGroup
Up to you. If you think it adds additional functionalities that are worth the extra effort, we can support these.
GridGroup
Should be based on one of existing group tags (Table, VerticalGroup, Stack, etc.). Appends children to itself. Might need a custom LmlActorBuilder extension to support constructor params.
TabbedPane, PopupMenu and MenuBar
These look complex, I'll need to take a better look at these. I'll probably end up implementing them.
Tooltips
Well, I'm not a huge fan of "native" LibGDX tooltips. I actually implemented my own LML tooltips as well (before they were introduced in LibGDX), but they were removed in LML 0. I think we can support Vis tooltips with visTooltip tag, especially if their behaviour varies from the original ones. But let's leave them for now.
Dialogs
We can add default actions to the parser. Instead of new attributes, you could use old ones to display these - onClick=showFileChooser. Default parser's I18NBundle would be used to support dialog's i18n. This should be pretty trivial, let's focus on other widgets first.
OK, to sum up: I think you can look into NumberSelector, LinkLabel, Separator, ColumnGroup and GridGroup, if you want to. These should be pretty straightforward to implement.

ColumnGroup
VerticalGroup has more features. To be honest I don't remember why it exists. It's either that I didn't know scene2d has it already implemented and made my own or I had problems with VerticalGroup.
Alright, I'll update CollapsibleWidget and look into the 'easy' ones.

CollapsibleWidget now supports creation with null table.

I don't think we're going to support all FormValidator methods (files management) for now, because of lack of GWT support. Though, if they don't cause any problems (when present and unused), adding them would be pretty straightforward - see current validator tags.

I think that constructing simple error or input dialogs is easy enough in LML - actually, if you need to display these very often, you can easily create powerful and more flexible macros, invocable with a single tag. DialogUtils might still be useful when managing UI in Java, but there's pretty much no point in adding separate tags/attributes for these.

FormValidator class is completely excluded from GWT. Trying to use it anywhere would cause missing class error during gwt compile.

I see. I guess we can add yet another syntax (extending VisLmlSyntax) with some additional validators for files (that's what it comes down to: SimpleFormValidator should be handle these just fine), but I don't think that's necessary for now. Let's focus on core widgets and their examples.

Since file chooser is excluded on GWT, we might have to add a separate non-GWT utility that registers extra attributes (file chooser) and tags (file validators). Standard syntax will not support file chooser.

All relevant GWT-compatible features are supported; example templates are present in the tests project. Closing the issue.


Missing Validation Message in untouched form when broadcasting schemaFormValidate

Hi,
I may have found an issue with validators and validation messages.
To make the plunker simple I just checked if the value is empty, but in my real case the validation is more complex.
If I have a field with $validators and broadcasts schemaFormValidate without touching it, the field is set as invalid as expected but the validation message does not appear. To get the error message, I have to type anything in the field and then clear that.
Am I missing something?
Steps to reproduce:

setup a form with sf-schema, sf-form (one text field and one submit button), sf-model

in the text field set $validators (in the example it just checks if the value is empty) and a validationMessage

setup ng-submit in form to a function which broadcasts schemaFormValidate
access the page and click in the submit button

Expected behaviour
I expected that the form would be validated and the error message would appear because the field is empty
Actual behaviour
The form was validated as expected, the field was set as invalid (error feedback appears), but the error message does not appear.
Gist/Plunker/Demo
https://plnkr.co/edit/IuTv9HdwHRJpT1so6J6u
Related issues
I didn't find any report of this issue or something related, sorry if it exists...
@json-schema-form/angular-schema-form-lead

I just found https://github.com/json-schema-form/angular-schema-form/issues/602 it looks like the same issue, sorry. I posted my plunker there.


tests failing on current beta branch (flutter-3.9-candidate.1)

This is first discovered in https://github.com/flutter/flutter/pull/122645/checks?check_run_id=12008937385 by @godofredoc , that several tests are consistently failing on pull requests opened against the beta branch.
It was later triaged by @christopherfujino and @pdblasi-google that a cherry pick is needed.
Creating this issue, so I can refer to this issue on the actual issue for the cherry pick request onto the beta branch.

Closing as obsolete.


Remove useless col class in customer bo

Questions
Answers

Description?
There was a strange spacing inside the customer wishlist block in the BO

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/26780.

How to test?
See issue

Possible impacts?
Customer BO block

Hello @NeOMakinG
The issue is partially fixed.
I detected a problem  when testing this PR on PS1782 & PS178x :
178x without PR :
https://watch.screencastify.com/v/QdrjRk7UHh8fmaVwWyp5
178x with PR (seems like 1782):

https://watch.screencastify.com/v/Dfa2nc2gPWQxUPHuDIZM
1782 with PR :
https://watch.screencastify.com/v/Uke1JBxpJM7j4tT267it
develop without PR :
https://watch.screencastify.com/v/T41kMjHlsBgfO8BQhbQ8
develop with PR : OK
https://watch.screencastify.com/v/xZSud3atElzNosBCKWUk
Also, i noticed that in PS1778 the block of wishlist is totally different from PS1782/PS1782 :
https://watch.screencastify.com/v/6GndhXNLx5nsq7THou0s
Please check and waiting ffor your feedback!
Thanks!

There was a removed row on develop that shouldn't be removed, this PR is useless

@NeOMakinG  Yes! I think it's
 which is missing before
!


Adds new default directory at home level

Addresses #163.
Summary of changes

Automatically assigns data to go into a 'pysatData' directory to be created at the user's home level.
Prompt for user to set a new directory only occurs on initial load of pysat.
Fixed a bug in test_utils.py that would not restore user's data directory after running unit tests locally.
Removed safe_data_dir function in instrument tests, as this should not be needed now.

Notes

I've opted for not actually creating the pysatData directory until after the first data download, largely because this is a pet peeve of mine with software packages.  This way, a potential user is given the chance to assign a directory before anything is created.  However, I'm willing to be persuaded otherwise.
As part of the bug fix in test_utils, I've changed the assert statements for the two set_dir tests.  The goal of both tests is now to see if the initial change holds as well as whether the store option worked for a subsequent reload of pysat.

Coverage increased (+0.03%) to 78.811% when pulling a1c846fbb04071a26140623c1d521450e0195257 on default_directory into 7d1e2828f18f96128704c15b2b74b8feac46d184 on develop.

Ready for review


MSWMS: Display coarse data with a lot of NaNs correctly

I was trying to add MLS satellite data to my MSWMS Server and encountered the following problem:

MLS satellite data is provided as level-2 data on orbits, which I gridded on daily maps on a regular lat/lon/pressure grid. Naturally, a lot of grid points are not filled with data (since interpolation and creation of "real" level-3 data is quite challenging and may impose artifacts). As a result, the netCDF variable contains a lot of NaNs.
The grid sampling I chose was rather coarse, approximately in the range of the best horizontal resolution of the satellite (approx. 1.5°)

As a result, MSWMS shows this kind of data only very sparsely, I think due to the fact that it tries to interpolate the data on a finer grid, the NaNs are interpolated with the available data, which resulted again in a NaN. So only a few data points are shown in the horizontal map (at locations where orbits crossed and more points are available).
As a workaround for this issue, I used a finer grid and repeated all of the satellite measurements to the four neighboring lat/lon points. This helps to show the satellite data on kind-of orbits without too many plotting artifacts.
However, I think this issue should be avoided at all in case of coarse and patchy data, doesn't it? Maybe satellite retrospective data is not the primary data used to set up MSWMS, but I find it very handy to have all relevant data at hand for a campaign...

Is there missing_value or _FillValue attribute defined for the NaNs?

Thanks for the hint! Using missing_value helped in the global horizontal view, but not after zooming in (????), adding _FillValue made everything worse again.
This is how the variable looks like in panoply:

And this is what MSWMS does with it:

I'll send a file to you and @joernu76. It's not big, but I'm not sure about copyright issues, since the data is not from me.
Here are the entries of the mswms_settings.py file, which is used to create the plots:
mpl_hsec_styles.make_generic_class("HS_MyStyle_pl_hno3", "mole_fraction_of_nitric_acid_in_air", "pl", [], []) register_horizontal_layers = None if mpl_hsec_styles is not None:     register_horizontal_layers = [         (mpl_hsec_styles.HS_MyStyle_pl_hno3, ["mls37"]),     ]
Anything else you need?

Ah, I see the issue. The generic plots are doing a contourf plot. Strange that you get any data at all.
You need a plotting class that uses pcolormesh or similar for plotting.

If this works, I will create a feature to allow the choice of either using contourf or pcolormesh for the generic plotting class in the develop branch.

No probs. I can also provide a version for 7.0.8. But it is mostly copy-paste, renaming the class (which isn't actually necessary), exchanging the contourf by pcolormesh and putting and extend into the colorbar call, if I remember correctly.

Thanks again. Here is the example of your file adjusted so it is working for version 7.0.8, just in case anyone else finds this issue:
mswms_settings.py.txt
Hopefully no one will need to use it, since you already are working on a fix :-)


Is it possible to show each line annotated of a function I write myself in an individual file?

Is it possible to show each line annotated of a function I write myself in an individual file?
That is I have main.cpp like this
main.cpp: for(i=0;i<n;i++) { dofun;}
dofun.cpp: void dofun() {line1; line2; line3; ...; line; }
I want to know which part in dofun.cpp costs the largest time.
I try to use "kcachegrind ls.callgrind" but it said function dofun has no cost of current selected type associated with any source line of this function in file '??' thus, no annotated source can be shown.
Thanks!

pprof has --lines option that allows you to attribute profiling ticks to lines. Just be aware that in output of optimizing C/C++ compiler, instruction to line number mapping might be misleading.


pythonPackages.gpyopt: init at unstable-2019-09-25

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[NA] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[NA] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Thanks!


Export Endpoint.toString in a Response.Schema.Record

A possible way to handle #781 that takes a similar approach to what @spockz described here. The only difference is that instead of explicitly calling a method to include the path, we always have it available if the endpoint matches.
I'm suspicious of a couple things with this initial sketch, but wanted to solicit feedback on both the general approach and the following:

I don't think we want to re-evaluate toString on every endpoint call, so maybe pre-computing it is in order
I'm unsure if I'm using StatsReceiver correctly in the docs, as I use Dropwizard metrics at work and am unfamiliar with the gotchas of StatsReceiver.
Calling apply on the Record can yield a IllegalStateException if the endpoint didn't match will raise an exception

I would be interested in hearing what others think about this approach.

Codecov Report

Merging #855 into master will increase coverage by 0.46%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #855      +/-   ##
=========================================
+ Coverage   80.74%   81.2%   +0.46%
=========================================
  Files          50      51       +1
  Lines         727     729       +2
  Branches       33      31       -2
=========================================
+ Hits          587     592       +5
+ Misses        140     137       -3

Impacted Files
Coverage Δ

core/src/main/scala/io/finch/FinchContext.scala
100% <100%> (ø)

core/src/main/scala/io/finch/ToService.scala
100% <100%> (ø)
:arrow_up:

core/src/main/scala/io/finch/Endpoint.scala
76.37% <0%> (+1.57%)
:arrow_up:

core/src/main/scala/io/finch/endpoint/param.scala
77.77% <0%> (+3.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfca1b...07119a7. Read the comment docs.

While trying to implement @ImLiar's suggestion of I've come across something.
The first thing is that in all the metric PR's so far we've used underlying to generate the path, however this is not the endpoint that was matched, it is the entire Endpoint that is passed to toService. This means that every call will use the same metric name no matter what. I've added a failing test to show this.
The second is that its not possible to add the path to the Response's ctx because it doesn't exist. However, we can add it to the initial request's ctx. This feels weird to me, and I'm not sure we want to do this, assuming we can solve the first issue.
I need to think more on how to do this, because we're not accumulating the path, only traversing the remaining pieces of it until there is nothing left.

@rpless I had some ideas on how to populate remainder (i.e., Input.Matched(rem)) with an endpoint being matched (see #784). Maybe we can incorporate something like that here?

@vkostyukov I think that approach might work, but we'd need a way to identify what parts of the path are dynamic and what parts are static. This might be another use case for the meta ADT. Basically if could we accumulated the parts of the ADT that match, we'd probably be in a better place for implementing one of these metrics PRs.

Suppressed by #957.


Add Preference to AutoComplete in Lowercase

I'm unable to find a preference in Dbeaver that would set auto-completion to be performed in lowercase instead of uppercase.
The closest thing I could find is this:

However, it doesn't control the case of auto-completed table-field-names.
As is, dbeaver's auto-completion is very useful for reminding me of the names of fields in a table. However, because I want them to be in lowercase, I still find myself typing out the entire field-name just for the purpose of preventing it from being in uppercase. I know that's silly, but preferences sometimes are.

Formatting case doesn't affect identifiers auto-completion.
You can configure auto-completion case on SQL Editor pref page:

BTW You can post inline images on GitHub by using drag-n-drop in comment text.

Perfect. Thank you.
I overlooked that previously because that entire form was disabled. I've enabled it now. Many thanks.

Honestly i am wondering why it is lowercase by default? Is that really a preference of most users?

I'm not sure, but I do all my sql in lowercase (except 'strings' of course).

@bryan831 for me lowercase was confusing, since I saw almost everywhere uppercase...

Dbeaver already color-codes the keywords for you. I've been writing SQL for almost 20 years. I too capitalized those keywords for the first few years. At some point, I realized that those keywords are not case sensitive, and at that time it took extra effort to capitalize them, so I stopped doing it. At this point I prefer everything to be lowercase except for 'CertainStrings'. I don't care what the default is as long as I have a way to turn auto-capitalization off.

For anyone searching this in current versions, it is under "SQL Formatting" inside the "SQL Editor" tree nowadays.
@Lonniebiz If your project team agreed on using UPPERCASE (like most people anywhere) then it was a major PITA to not be able to copy and paste scripts you wrote in DBeaver to elsewhere. An editor should not be this opinionated.

@kannes : Uppercase is an unnecessary formality. I remember when people did HTML tags in uppercase. Lowercase will win out long-run. If you worked for me, I'd make you do it in lowercase just to make you sad. My management philosophy is: "if an employee is happy, you're doing something wrong". With all this said, know that I'm only joking :)

Uppercase is an unnecessary formality

I would have to strongly disagree!  Uppercasing keywords is key for SQL code readability.  Readability results in maintainability which reduces development cost.  There is a reason why there are SQL standards and they all recommend keywords to be in uppercase.  In any forward-thinking organization, these rules are automatically enforced by linters run by the CI workflow, too.
Going against standards makes sense only if you are proposing a sensible new standard.  In the absence of a meaningful alternative proposal, you are only rebelling against standardization while at the same time you enforce your own custom standard.  Seems incongruent.

it took extra effort to capitalize

It seems this is the only argument you have in favour of your standard.  However, code is read many more times than it is written, so the effort it takes to capitalize keywords is trivial compared to the effort it takes to read poorly formatted code.  As for the actual effort it takes to format properly, you can simply have DBeaver auto-format SQL for you - all it takes is pressing Shift-Ctrl-F.

My management philosophy is: "if an employee is happy, you're doing something wrong"

Sad joke.

@ivaylo-infostrux : Modern SQL editors colorize keywords automatically. Automatically colorized keywords are enough distinction for readability sake. In cases where this is not the case, I agree with you that it does enhance readability. Yet, personally, I like everything to be in lowercase except for when uppercase is required to achieve a particular result set. CaPiTaLiZaTiOn rEqUiReS UnNeCeSsArY EfFoRt.

Thanks for the response, @Lonniebiz, but standards are the exact opposite of personal preferences.  The needs of the team and the organization as a whole quite often outweigh the individual preference.  It's the price we all pay for efficient collaboration.

@ivaylo-infostrux : Thankfully, dBeaver can accommodate all users' preferences (even those of luddites).

The fact that you can use a tool a certain way is not, in itself, an endorsement of your mode of use.
BTW, Luddites would be breaking computers, not using them.

@Lonniebiz Your low effort trolling is really unnecessary. I am glad it is easy to unsubscribe from an issue, maybe you should do the same.

@Lonniebiz your responses are extremely childish and surprising since you've mentioned "writing SQL for 20 years". I think you need to grow up figuratively speaking. Maybe you find it hard to capitalize keywords because your mechanics are bad. That doesn't mean you have to insist your preference is better

For those searching for this setting in 2023:
Preferences > Editors > SQL Editor > Code Completion > Insert Case


Calling haptic too frequently seems to cause crash

Hi,
I'm creating a swipe selector for a project and I was using this library to get a native feedback on iOS device, and it seems that when I swipe too quickly this library is called many times and it is causing some issues, causing the app to crash.
Enqueued from CHHapticEngineDispatchQueue

Anyone got this before ?

Hi, actually the library was enhanced with a queue at version 1.10.0.
Also while trying out i couldn´t reproduce it. If this is still an issue: can you attach the full error message and if available the corresponding xcode log?


Draft Features - accessibility

It is difficult to get developers to implement draft features because we don't have a single authoritative document for the proposal.  How do we fix this?

Discussed on today's TSC call.
My thoughts:

Single Markup doc is better.
I agree that having a single markup document that represents the current state of the draft feature under discussion would be a very good thing. Even in cases where we haven't made the draft public, but it's a substantial and complex new thing being proposed (e.g. alternative schemas, overlays, traits), if that thing takes the form of an issue, as it currently does, people will have a hard time finding the part they should pay attention to, and a hard time being comfortable that it's safe to ignore all of the other accumulated comments in that issue.
Track individual issues against a draft proposal.
Also, once an issue gets a lot of comments, it's difficult to keep track of all of the sub-issues that have been raised in those comments. It's an extra burden on readers and contributors to have to keep combing through comments to find what's relevant and/or what's still under discussion vs. already resolved. Personally, I am reluctant to start piling on new questions or concerns on an issue that already has a sprawling mass of comments.
More prominent list of draft proposals open for comment, ready for implementation.
If we want to draw the community's attention to draft proposals, encourage comments and invite POC implementations, It would really help to have a dedicated page for this, and prominent links to that page. The page should have:

A list of active draft proposals, each with a link to markdown doc, and with a little explanatory blurb or sentence about each one.
A brief explanation of the draft proposal process.
A call to action going out to the community, asking for comments and test implementations.

@MikeRalphson proposed GitHub Projects as a way to help organize issues and tasks around a particular feature we're working on.  Seems well worth a look.
I'm sure there are many other things we could do bring more energy into the draft proposal process. Hackathons came up on the call.  But maybe we can raise those as separate issues, so we don't expand the scope of this issue too drastically.

GitHub Projects is an interesting idea. We should consider that. Myself, I caught myself wondering today whether we do enough to capture the use cases up front when we're defining the solution to a problem. I'd love to see us work that into our process better.

I have an AsciiDoc for Alternative Schema.  Just let me know where to put it (polite answers only please).

@earth2marsh I agree that use cases would be valuable as well. Each use case should be a discretely resource identifiable via a URL. Do we have a place for them?

I  have an AsciiDoc for Alternative Schema.

@cmheazel can we use GitHub-flavoured markdown in preference to AsciiDoc, as elsewhere in the repo?

Just let me know where to put it (polite answers only please).

@OAI/tsc I'd suggest something like /technical-notes/v3.0/draft-feature-alternative-schema if we'd like this in-repo on the master branch. An alternative is in the registry: http://spec.openapis.org/registry/draft-feature/alternativeSchema.html

@MikeRalphson I didn't know GitHub had a preference.  I'll have to convert it.  Might take a few days.

@MikeRalphson Can we create a separate directory for draft features rather than burying it under technical notes?

See Pull Request #1868 for an example using Alternative Schema.


Remove comment which is rendered as css class

The comment has unintentional side effect of appearing in css class over generated tables in html pages. Although it doesn't break anything, it could hurt sometime later.

To verify you can visit
https://pytorch.org/vision/main/models_new.html
right click
view page source and
see line number 382
While do the same on the current build you can do the same through Circle CI artifacts

I had noticed this, but since it doesn't have any effect I kept it.  I still think the comment is useful to provide context to the reader. Without it, we will definitely forget what this file does eventually. If we remove it, the docs will look terrible and we might not notive before it's too late.
@oke-aditya can you please try to see if we can add this comment on the line above? If not, I'd prefer referting this PR.

It's bit bad both the ways. Keeping it means we are injecting CSS which unnecassary (slowing the website) + say torch theme creates a CSS class that uses this. It would mean we are broken as we will override that CSS. I know the comment is crucial but having comment that injects code un intentionally is equally bad.

I'd really like to get this comment back one way or another. Do you mind trying adding it back in the file?

Lemme try adding it above so that it will not go inside CSS.

If it doesn't work, we can put back the comment as
#_Necessary_for_the_table_generated_by_autosummary_to_look_decent
This will never correspond to any css class and we'll be safe. Not amazing, but better than not comment at all.

I think it's possible to fix the HTML and keep the comment. See below:

The configuration file consists of sections, lead by a "[section]" header and followed by "name: value" entries, with continuations in the style of RFC 822; "name=value" is also accepted. Note that leading whitespace is removed from values. ... Lines beginning with "#" or ";" are ignored and may be used to provide comments.

From here.


initial support for Siemens IOT2000

The default settings assume that one is booting from USB.
The integration actually does not work yet, due to this error:
root@iot2000:~# mender
This program can only be run on processors with MMX support.

See this for more information on why. Essentalily golang does not work in the SoC used by IOT2000 board. They do have a fork of golang with a patchset that resolves this, but they only have patches for 1.6 and 1.8 versions of go (1.8 was used in pyro)
But I would still like to merge this, in the hopes that someone see it and fixes it.
Also as the meta-iot2000 uses kas, I have added support for this in meta-mender-community and added a kas.yml for iot2000 board along with a generic one for Mender

See this for more information on why. Essentalily golang does not work in the SoC used by IOT2000 board. They do have a fork of golang with a patchset that resolves this, but they only have patches for 1.6 and 1.8 versions of go (1.8 was used in pyro)

This became to big of a hurdle to workaround and not working any more on this.
Closing, might re-open if there is interested from someone

@mirzak - Thanks for this work so far! I'm interested if there's any thoughts from your side on the current state of the integration with SoC used by IOT2050 board. Any chances if it's possible to tackle integration at all?

Any chances if it's possible to tackle integration at all?

I have not looked at this in a while, but unless anything has changed in regards to go support, it is very steep hill to climb :)

Some references I found back when I worked on this:
https://support.industry.siemens.com/tf/ww/en/posts/golang-1-9-in-iot2020/187790/?page=0&pageSize=10
https://github.com/siemens/meta-iot2000/issues/96

Thanks, @mirzak!

I realized misread your comment. You asked about IOT2050, I know nothing about this one :)

@mirzak - no worries - https://github.com/siemens/meta-iot2000/issues/96#issuecomment-694289753


Fix path to hosts array in new scout config.

Probably fixes #21

Sorry I'm not following, did this changed on the scout repo?

Yes, it's been updated over a month ago. See here: https://github.com/laravel/scout/commit/110145a990fb7b72044baba1a4b059ee3393bab6


Got autodoc "working"

Preview here: wbo-test.rtfd.io
Readthedocs doesn't like to build the autodocs because sphinx autodoc requires that all imported packages such as sqlalchemy and flask be installed on the machine building the docs. Thus, the only way I see that we can have our autodocs up on readthedocs is to manually push them.

If it's only a question of Python modules not being installed, readthedocs supports installing them from a Python requirements file, like this:

The requirements file used by the back end is at backend/requirements.txt.


docs(readme): add nix instructions

Description of change
Flawz has been packaged for Nix/NixOS on the master branch (the very unstable branch) via NixOS/nixpkgs/pull/312751.
~Regardless that, the package still didn't make Its way to nixos-unstable branch yet, which used for the rolling release
you can still use it by specifying the master branch.~

How has this been tested? (if applicable)
i tested the command on my machine :p

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.14%. Comparing base (bfcd4c8) to head (3f3ea58).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #22   +/-   ##
=====================================
  Coverage   8.14%   8.14%
=====================================
  Files         13      13
  Lines        712     712
=====================================
  Hits          58      58
  Misses       654     654

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks bro


Pin b64 to v0.13

base64 crate has been updated to v0.20 last week, breaking the API compatibility. As this new API is still questioned, and migration not yet documented I figure that it is safer to pin the version to 0.13 instead of 0

Given that this crate is still in alpha, I prefer to actually try to move the code forward instead of pinning in the past.


public-network-enabled no longer supported

The argument --public-network-enabled is not supported, but still listed in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c608162e-cf40-9d53-da4a-51f51a0311ea
Version Independent ID: eccbb543-be68-7de2-d41d-abee55c81452
Content: az acr
Content Source: latest/docs-ref-autogen/acr.yml
Service: container-registry
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

routing to appropriate team

@bsherwin
It is supported and we don't have any plans of removing it.  Please try newer version of CLI or share how you installed the CLI

You are correct. I had updated my cli on windows but not on WSL2. I was out of sync.


svc_enable=>false in hybrid mode is not working as expected!

Describe the bug
svc_enable=>false in hybrid mode is not working as expected!
To Reproduce
Deploy kube-vip by setting svc_enable is false in hybrid mode as daemon set
  containers:
  - args:
    - manager
    env:
    - name: vip_arp
      value: "true"
    - name: port
      value: "6443"
    - name: vip_interface
      value: ens192
    - name: vip_cidr
      value: "32"
    - name: cp_enable
      value: "true"
    - name: cp_namespace
      value: kube-system
    - name: vip_ddns
      value: "false"
    **- name: svc_enable
      value: "false"**

Expected behavior
After deploying kube-vip, It should only works for contolplane by using vip address & It should not assign/allocate external IP address whenever we create service type: Load Balancer.
Current behavior
Assigning/allocating IP address of workers nodes!

There was no response in slack, I think no one tried before!

Can you retrieve the logs from the kube-vip pods?
On Fri, 21 Jan 2022 at 01:20, Mahantesh Karadigudda <
@.***> wrote:

There was no response in slack, I think no one tried before!
—
Reply to this email directly, view it on GitHub
https://github.com/kube-vip/kube-vip/issues/353#issuecomment-1018215880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMVAJUOYMQRP7PCSEOHHHDUXD3LTANCNFSM5MOVME7Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This can be closed, Issue was not related to kube-vip. We suppose to disable servicelb while installing k3s.


fix: Fix spelling of Midea in all instances

After experiencing errors in installation (and the large number of issues/PRs), I found that there are many cases where "Midea" is spelled "Mieda". This discrepancy is the root cause of the error in the zip file name causing an inability to install from HACS.
Related issues:
#586 #583 #572 #569 #556 #546 #530 #522 #509 #471 #489 #467 #438

Any chance this can get merged and a new version deployed? @georgezhao2010

as current repo is not active , we have forked it and consider to maintain it in futuer.
https://github.com/wuwentao/midea_ac_lan
PR is welcome
Thanks

as current repo is not active , we have forked it and consider to maintain it in futuer. https://github.com/wuwentao/midea_ac_lan
PR is welcome
Thanks

is it possible to migrate existing devices to this new repo somehow (inside HA) or must delete devices, delete integration and then reinstall from the new repo?

there is no any addition jobs.
just remove old one and install new, all the devices and data will be there.


Add ACCS pros bulletpoints to /trade

Pro bulletpoints were added and pull request was set up

text is merged, but layout still needs to get fixed.


Catch keyboard interrupt in session run

Right now, Ctrl+c does not abort a long session run.

@danijar I want to work on this, pls provide some more info.

A fix for this might need significant changes to C++ part of the runtime.
This is similar to the issue of Dequeue of an empty queue causing an uninterruptible hang.
Python client thread detects ctrl+C, but how to tell underlying C threads to die?
To see an example of complexity, this is the commit that added timeout option to session.run:
https://github.com/tensorflow/tensorflow/commit/fa07bfda6896748b747334e750763f6feea91129
cc: @mrry in case he can see a way for client to interrupt the runtime

Slightly different question (from https://stackoverflow.com/q/45033413):

I wish to add functionality to my code such that if I desire to terminate the code at any point it will safely terminate training and save the variables. Although I've tried searching for a better solution, I think catching a KeyboardInterrupt exception would be my best bet.
Would it, however, be safe? More specifically, would the following code work:

with tf.Session() as sess:
  try:
    for i in range(FLAGS.max_steps):
      sess.run(train_op, feed_dict=some_feed_dictionary)
      # Some other summary writing and evaluative operations
  except KeyboardInterrupt:
    print("Manual interrupt occurred.")

  print('Done training for {} steps'.format(global_steps))
  save_path = saver.save(sess, 'Standard CNN', global_step=global_steps, write_meta_graph=False)

Or is it unsafe and can result in corrupted save files considering the Keyboard Interrupt is free to occur in the middle of any tensorflow operation? Is there an adequate way of doing this?

Is the call to sess.run (or the important parts of it) atomic?
This comment by @petewarden suggests it is.

Any update here?

Any updates?

@danijar Maybe we can Try-Except Block Around session.run():
Enclose session.run() calls within a try-except block to catch the KeyboardInterrupt exception.
TensorFlow 2.x uses a different approach for training, with eager execution and tf.function for defining computation graphs.  TF 1.x is not actively supported so we recommend you to upgrade.
If you still have a concern then please create a new ticket.
Thank you!


Stop menu when reaching the footer

I'm not sure if this is intended but when you have a large footer the nav scrolls past the body and overlaps the footer.
Is there a way to stop the nav from scrolling or hide it when reaching a certain part of the viewport?
See this for a demo:
http://codepen.io/anon/pen/yICcF

Just discovered this issue today. Anyone come across any ideas in the last 2 years ish before I dive in?
Thanks!
I'll report back if I find anything of use.

Ps: My immediate thought on this would be to detect when the nav reaches the bottom of the adjacent container and trigger a class change that changes from position fixed to position absolute, bottom: 0;
This way, the nav would stick to the bottom of that container until you scrolled back up.


Add 'First Letter Tool'

Add a page, perhaps a blog post, showing the first_letter_tool.
A while back, I found this easy text conversion tool, and modified it slightly, and have used it myself to help memorize. Share it publicly now. Use this as an opportunity to explore adding React to this Astro site.

Closed by #21


feat: track user input changes

Title
Track user input changes
Description
Part of the work for this had already been done, the additional functionality is resetting the form values when clicking the 'reset defaults' button. Also, a UI change so that the legend and action button are always visible above the table (may need discussion).
To test
Change some values in table at intervention stage 'Industry Information', then click the 'Reset to default values' button to ensure that the form is reset properly.

merge from develop and should help fix some of the checks above


Program spamming Tempo set at 413793 at second 0.00!

I was just using the program after I chose if the tracks were percussion and how much they were offset it just started spamming tempo set at 413793 at second 0.00! The attachment doesn't support midi files so I am giving you a link were you can download it. http://kylelandry.com/wp-content/uploads/Skyrim-Main-Theme.mid

Good choice in song, I'm interested to get this working. Let me check it out!

Unfortunately, that specific MIDI seems to break Java's internal MIDI parser (it doesn't detect any notes).
No idea why!
But this MIDI works great: http://midicollection.net/songs/index.php?id=18!
I shifted the bass line up 12 steps (track 2) and switched the track from piano to bass in game. Go ahead and try that one!

Thank you so much!
It is incredible how epic this I can play stuff on my piano then actually get it into factorio epic coding skills cheers!

I'll close this, but also leave a note in the readme about broken MIDIs. Thanks!


Feat/add price to limit order

Allow limit orders to be placed by specifying a price instead of a tick
Tests still breaking because of pending rounding changes.

https://github.com/neutron-org/neutron-tests/actions/runs/8702351288

there are a couple of conflicts 🙈

https://github.com/neutron-org/neutron-tests/actions/runs/9025686170

https://github.com/neutron-org/neutron-tests/actions/runs/9229880788

Integration tests are not passing due to some linter error in dev-contracts

please attach a successful test run

https://github.com/neutron-org/neutron-tests/actions/runs/9280203744/attempts/4


OAuthResponse

Hello,
When I get the OAuthResponse, I save it to a static dictionary. If I want to get the OAuthResponse with a method, I allways get null back. In the debugger I can see that the method returns the right object, after setting the local object to the object from the method, the variable is null. Why?

HI
please help me :(
i have the same problem !  in each time i get a new code But its null
http://stackoverflow.com/questions/32579274/instasharp-oauthresponse-not-work


Wrote an article about Yalc

Hey, I like Yalc so much I just had to write an article about it. Would love to hear some feedback before it hits the public :)
https://medium.com/@DanielKrejci/modularize-a-shared-code-with-yalc-6f32031b647f

Hey, this is really great) I myself didn't have time to write about. Thanks a lot!


Hide org password while typing

This feature is aavailable in @2.0.1
hidden: true
Add the above property for the input promt which should be hidden
example:
    - name: password
       prompt: Password
       hidden: true


docs: link in the repo's description is broken

correct is http://kong.github.io/lua-resty-dns-client/topics/README.md.html

just ran into this myself, but I'm not authorized to make those changes...

just ran into this myself, but I'm not authorized to make those changes...

Please ask internally in engineering to get the permission resolved. You are the maintainer of this repository so you should have this access. @kinman or @guanlan should be able to help out.

just ran into this myself, but I'm not authorized to make those changes...

Added you as a maintainer of lua-resty-dns-client repo.

fixed


entrypoint-demoter causes permission denied on /var/run/docker.sock

Running with Docker 19.03.15 on OpenSUSE
Compose:
  backup:
    image: kaiede/minecraft-bedrock-backup
    restart: always
    depends_on:
      - "bedrock"
    environment:
      BACKUP_INTERVAL: "3h"
      TZ: "Europe/London"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - /nas/bedrock/backups:/backups
      - bedrock:/server

Always returns this:
Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/bedrock_bedrock_1/json: dial unix /var/run/docker.sock: connect: permission denied
If I change compose to add entrypoint:
entrypoint: tail -f /dev/null
Then I can exec the container and run entry.sh on its own , and it works fine.
If I run with this though:
/usr/local/bin/entrypoint-demoter --match /backups --debug --stdin-on-term  stop /opt/bedrock/entry.sh
Then we see permission denied on the docker sock.

I’m not sure how I missed covering this in the documentation. entrypoint-demoter will automatically demote the process running ‘entry.sh’ to match whatever user and group owns /backups. Much like how itzg/minecraft-bedrock-server does with the /data folder. Even in docker containers, it’s good practice to avoid running things as root.
This does mean you should make sure that you have a user in the docker group, and have that user own the /backups folder on the host. So something like ‘processor286:docker’ where processor286 is a member of the docker group and has access to docker (can run ‘docker ps’ and see your minecraft containers). See these instructions for more details on how to do that: https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user

My user is already added to the docker group and I manage my daemon as that user, not using sudo or the root account.
I understand the issue I face now though. My problem then becomes that the backups folder is an NFS mount on to my NAS and all the permissions are squashed to oblivion, relying on chmod 755 in the directory to enable files to get created.
That's not your problem though, and I understand why it's done this way.

In that situation, you can use the UID and GID variables in your docker compose file to set the user/group manually, and entrypoint-demoter will use those instead.
Using the folder is the default because it is the correct answer in most cases.


Make hb with each obs message

Adding a heartbeat message to any significance, time, or coincidence message if there were already no heartbeats

might need to check is_test argument for the extra created heartbeat. For now, it doesn't pass anything.

Okay, the tests are failing because now they do not expect to see a heartbeat with other message type creations. The tests needs to be updated.

It's OK for is_valid to return true even with the missing p value?

Yes, I think we said we should not enforce p values, even without that, an experiment should still be able to form a coincidence. That's why they are not in the "required fields" (also formulated like this in the paper) but the validation was (is) treating them as they were a required argument.

Comparing tier to the message class names is awkward, is there a nicer way to do that?
Is this referring to the L504 ? Not sure if there is a nicer way, if you can think of something, I'm happy to implement it.

I didn't test it but I expect that this would still not work. Because, even though I send a heartbeat with every message, they are being sent after the coincidence message. -Well actually, if the 2nd detector does not sent it at the same time, the heartbeat of the first will already be registered at the time of coincidence forming, but the heartbeat of the 2nd one will not yet be registered.
In the production, this should not be a problem, as we should expect detectors to send heartbeats. In worst case, we append a wrong FAR estimation. In any case, we also added a fail-safe in FAR calculation (smt like; if heartbeat cache empty return 0).
TL;DR it won't crash, FAR might still be slightly wrong if the experiments were not sending heartbeats already.

Together with @sybenzvi we implemented this logic on the server side, see this PR https://github.com/SNEWS2/SNEWS_Coincidence_System/pull/123
Now instead of creating 2 messages with snews_pt and sending them separately, snews_cs registers a heartbeat each time it sees a coincidence message in the stream and after that it continues with the coincidence search. This also avoid the problems discussed above.

I'll close this PR as it is no longer needed. I'll make a small patch with another PR for the p value issues this PR was addressing. (i.e. p values are not required arguments for coincidence and time tiers but they still try to validate, and crash if it is None.)


v4.0.1: chore(project): update dependencies

What does this PR do?
Updates all the project dependencies to their latest versions.
How should it be tested manually?
yarn test
# or
npm test

Pull Request Test Coverage Report for Build 56

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 53:
0.0%

Covered Lines:
52

Relevant Lines:
52

💛  - Coveralls


[AppConfig] 1.2.1 Hotfix Release Prep

Summary
The focus of these changes is to remove the public surface added in the 1.3.x line to prepare for a hotfix release based on 1.2.0.   These changes already exist in main and are being brought over to a hotfix branch for release purposes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Data.AppConfiguration

Can we remove the snapshot samples and examples from the readme documentation as well?

Can we remove the snapshot samples and examples from the readme documentation as well?

Good catch.   I completely forgot those were there!

The API View generated for this has a lot of noise due to suppressing the beta Snapshot API surface.   The comparison between this version (1.2.1) and the current GA (1.2.0) can be found here.

/azp run net - appconfiguration - tests


Specify that the color parameter isn't optional

If you do not use the color parameter on the Sketch component, it doesn't work correctly. The color changes but the draggable circle amongst other things do not update in position.
I feel as though you should specify this in the documentation if this is the intended functionality.
See my CodeSandbox for an example, I have remove color={this.state.color} from the component - add it to make it fully functional again.

This is a fantastic point. I am adding it to the 3.0.0 milestone to make sure it gets fixed in the new release


change html of confirm scopes from span and p to dl.

[X] Brief description of changes applied
[X] Test cases for all modified changes, where applicable

Changes to two confirmation pages associated with OIDC login flow.
On these pages, items being confirmed, claims or scopes, are displayed with span, strong, and paragraph tags.
I think that a definition list is a more appropriate tag for the presentation.
The default formatting of dl looks similar and provides indentation making the text more readable.
I also included some css classes in case someone wanted to add custom formatting (the class names are not very original).
A run of functional tests is at https://github.com/rbonatuvic/cas/actions/runs/12381499198

Please provide a few screenshots of the changes.

The file named 'current' is the the view that is currently in 'master'.
The file named 'modified' is the proposed change.

Thank you.
Why do you think a definition list is a more appropriate tag for the presentation? The newer changes make the screen look cluttered and compressed.

Given the list nature of the key value relationship, dl tags would allow for custom styling without colliding with the p tag.
I think the close association of the list gives good separation of the claims from other page elements.
Here is a screenshot where the dl tag is inside the loop.

Makes sense, thank you for the details.


Other Diseases --> Other Endpoints?

One of the headings in the table of contents on the left in the Epidata documentation says "Epidata API (Other Diseases)".
I'm not a fan of "Diseases" because there is indeed COVID data here, e.g., all the HHS endpoints. And not every endpoint is its own disease. So how about just "Other Endpoints"? @RoniRos @capnrefsmmat @krivard

I agree "Other Diseases" is inappropriate, but "Endpoints" isn't ideal either, because I think it is better to describe the content (which is what people are presumably looking for) rather than define it by the access details.
More generally, I find the tree structure confusing.  For example, it implies that CTIS is not part of COVIDcast - is that intended?
I think the root cause of my confusion is that Diseases, Data Sources and Endpoints don't align neatly.

Diseases arguably ought to be the highest-level concept in the tree -- a user coming in knows whether they are interested in Covid, flu, or something else.  They also want to be able to see all the signals related to say, Covid, regardless of which Data Sources or Endpoints they are under.
However, many data sources are used for multiple diseases, e.g. Quidel, Google Search, CHNG.
I think of Endpoints as "dialects" or sub-versions of the API.  The differences between them is in what arguments they require/accept and what data type(s) they return.  Is this correct?  Unfortunately, these dialects cut across both Diseases and Data Sources.

I don't have a good solution currently.  In the meantime, let me suggest a slight terminology change to the first 4 items that might reduce the confusion a bit:
Home
Epidata API: COVIDcast Main Endpoint
Epidata API: COVID-19 Trends and Impact Survey (CTIS) Endpoint
Epidata API: Other Endpoints (COVID-19 and Other Diseases)
Or:
Epidata API Home
COVIDcast Main Endpoint
COVID-19 Trends and Impact Survey (CTIS) Endpoint
Other Endpoints (COVID-19 and Other Diseases)
Either way, the first (home) item should be updated to clearly explain that

COVIDcast is the name for all signals/indicators that are COVID-19 related.
Most COVIDcast indicators are accessed via the COVIDcast Main Endpoint, but some are accessed via the CTIS Endpoint, and others via Other Endpoints.
Epidata also provides access to signals related to other diseases, including flu, dengue and norovirus, which are accessed via the "Other" Endpoints node.

Thanks for the comprehensive analysis/reply!  Just to quickly chime in, that I like your second version:
Epidata API Home
COVIDcast Main Endpoint
COVID-19 Trends and Impact Survey (CTIS) Endpoint
Other Endpoints (COVID-19 and Other Diseases)
and agree we should implement this (along with the explanation on the home page) ASAP.

Just to throw a wrench in: the CTIS page is not about an API endpoint but about the survey itself. It's documentation of the survey questions, coding, data files, and so on. API access to the aggregate data is documented under the COVIDcast endpoint documentation, along with all the other usual data sources (like JHU and Change). That's why it got put under its own section.
So there's a CTIS section with survey documentation, and a separate CTIS page under the COVIDcast endpoint page that explains what aggregate data is available in the API.

Ok, so how about something like this:
Epidata API Home
____COVIDcast Main Endpoint
____Other Endpoints (COVID-19 and Other Diseases)
____Epidata API Development Guide
____New Endpoint Tutorial
The COVID-19 Trends and Impact Survey
Related Work
(The "____" are meant to be indentation / menu items).
The "Home" page should also be further corrected to reflect Alex's explanation.

Hi @RoniRos! Unearthing this as we now have a volunteer @LeonLu2 working on it.
It turns out the engine that turns our plaintext documentation into the API documentation website only supports three hierarchy levels.
We currently have

Home
COVIDcast Epidata API

API Clients
COVIDcast Data Licensing
Data Sources and Signals

COVID Act Now
COVID-19 Trends and Impact Survey
...
USAFacts Cases and Deaths

Signal Changelog
Geographic Coding
...
Inactive Signals

COVID-19 Trends and Impact Survey
Epidata API (Other ~Diseases~Endpoints)

Your recommendation requires a fourth level, which is not currently possible.
There is a fork of our documentation engine that claims to support an arbitrary numbers of levels, but we haven't been able to get it working.
We could:

Keep trying with the fork
Reorganize into three levels
Try a different engine entirely

Thoughts?

I think it's fine to try the fork and see if it provides every other features the same as the one we currently have. Or we can try to keep it in three levels which will make it easier for readers to navigate than four or higher levels. I don't think having a different engine would be the first choice and we might keep it as a last resort I guess?

On additional research, the fork is not ready to be used in production, and is part of an active development effort within Just The Docs.
Recommend the following 3-level organization for now:
Epidata API Home
COVIDcast Main Endpoint
Other Endpoints (COVID-19 and Other Diseases)
Epidata API Development Guide
New Endpoint Tutorial
The COVID-19 Trends and Impact Survey
Related Work

Sorry I am late.  Your recommendation looks good to me.
As part of our strategic / long term planning, I'd like to plan the transition to a more coherent view, per my original tirade above.  I will add it to out so-called "Fall 2022 OKRs" document.


question : how do you get current dir

tried
//<#= Host.ResolvePath("src") #>
<#=System.IO.Directory.GetCurrentDirectory() #>
cant get it.

try this
<#=Environment.CurrentDirectory#>

thanks


Cannot display login page for Microsoft Live Connect

MS recently changed their app registration (https://apps.dev.microsoft.com/) and now whenever I try to display the login UI through the OAuth2Authenticator I get an error message on Android and iOS telling me:

The provided value for the input parameter 'response_type' is not allowed for this client. Expected value is 'code'.

I am providing  OAuth2Authenticator with my ClientId from the Microsoft Application Registration Portal, which is now in the form of a GUID. Along with the authorizeUrl of https://login.live.com/oauth20_authorize.srf and redirectUrl of https://login.live.com/oauth20_desktop.srf

@kazo0 Every find a workaround for this issue?

@sushihangover the issue is that we no longer need to send the client_secret when requesting the access_token.
In my case specifically I just extended the OAuth2Authenticator and overrode OnRedirectPageLoaded

@kazo0 Thanks, I did the same thing. The fact that the current code does not support explicit  code-based auth flow is strange.

work arounds have been used


subdomain takeover at FeedPress not working

Service name: FeedPress
Documentation
Based on the information shared in the hackerone report for FeedPress based subdomain, not able to takeover the ownership. The error message on the URL stated:
FeedPress
The feed has not been found.
You have a blog or a website? Let us handle your RSS feeds.
After creating the account on feedpress, and trying to takeover the subdomain by selecting My Hostname and entering the programs sub-domain, it results in the error message - "The hostname xyz.domain.com is already registered on FeedPress."
Is the sub-domain takeover in such scenario possible?
Thanks

Sometimes the error isn't truly indicative of being able to perform a takeover.
Eg.
This site indicates an error, suggesting that the sub-domain takeover is possible.
https://feed.gradle.org/
However, these sites are completely valid indicating that the domain is actually in use in a way that can't be compromised.

https://feed.gradle.org/blog.atom
https://feed.gradle.org/blog/features.atom
https://feed.gradle.org/blog/events.atom
https://feed.gradle.org/blog/general.atom

All of this being said, the general security of FeedPress isn't all that good. I've been trying to get in contact with their team about other security problems with their site and they aren't responding. Honestly, I would recommend not trusting FeedPress with access to one of your sub-domains as their security practices don't seem to be all that good.

Hello, FeedPress appears to be no longer vulnerable.
The hostname xx.target.com is already registered on FeedPress.
Thanks

I confirm feedpress is not vulnerable. Testing on few domains.

Not vulnerable. Also received a
The hostname xx.target.com is already registered on FeedPress.


Fix for PIN lock bypass when app is killed or repeatedly paused

Several issues reported that the PIN lock can be bypassed, which was related to the onlyBackgroundTimeout setting. The root cause was the logic deciding when the user was last active. This PR fixes these issues.
The issues could be reproduced in the demo app when setting onlyBackgroundTimeOut to true:

Launch the app
Set the expiry to N seconds (or use the default 10 seconds)
Kill the app
Wait N + 1 seconds
Launch the app

Or (not 100% reproducible on all devices)

Launch the app
Set the expiry to N seconds (or use the default 10 seconds)
Send to background via home button
Wait N + 1 seconds
Launch the app
Send to background via home button
Launch the app

This PR keeps the previous functionality and additionally enhances the behavior when onlyBackground is set to true.
Issues addressed:
#130
#153
#131
#99

Do you mind resolving the conflict?

Ah, no problem. just saw that. Will do that today.

OK, rebased.

On my device, this commit broke the onlyBackgroundTimeOut. Now even if I set onlyBackgroundTimeOut to true, I get lockscreen popup in the middle of my activity.

Hey, sorry to hear that.
This is interesting since we also use that on our application. Let me see if I can help you.
I will need some small quick info. What timeout do you use in your application?

I am setting timeout to 1 sec.

That may have to do with how you are transiting from activity to activity. Can you you try a larger timeout as a test in one of your local branches?

Yuh, I will try and let you know.

I will try to reproduce too and see if I can pull a viable fix that does not compromise the security layer, which is the most important aspect of the library and the reason for this PR.

Thanks. Please let me know if you are also able to reproduce this issue.

Hi, I tried setting lock timeout to 1min, and I did not get lock prompt in-between activities. But, I noticed another issue, that after the timeout duration is passed, lock does not prompt up. Sometimes it does come up and most often it does not.

Let me understand the process because we haven't experienced this.
You set the app to lock in 1 minute for example and enable the only in background option right?

Yes. And I tried is:

Set the timeout to 1 min, and pressed the middle button to let the app in background. In this scenario, lock did not prompt up.

Closed the app completely. This time lock occasionally got promoted but most often it does not.

That's weird indeed we never experienced it from any of our users and its in the current state for several months now.


How should I reconstruct 3D model by RGB image and depth image took from realsense.

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Hi, I took some RGB images and depth image by realsense viewer, and trying to reconstruct a 3D model by these images. But I can't recontrusct it correctly. The code I used is as below:
std::string rgb_dir = R"(D:\Work_Files\DMSDev\AutoMeasurementSeg\SAMRealSense\rgb_frames_sub)";
std::string depth_dir = R"(D:\Work_Files\DMSDev\AutoMeasurementSeg\SAMRealSense\depth_frames_sub)";
std::string mask_dir = R"(D:\Work_Files\DMSDev\AutoMeasurementSeg\SAMRealSense\DJ06\mask)";

//Image paths
std::vector<std::string> rgb_path, depth_path, mask_path;
getFiles(rgb_dir, rgb_path);
getFiles(depth_dir, depth_path);
getFiles(mask_dir, mask_path);

// Image names
std::vector<std::string> rgb_names = getFilenames(rgb_dir);
std::vector<std::string> depth_names = getFilenames(depth_dir);
std::vector<std::string> mask_names = getFilenames(mask_dir);

// Camera parameters
double cx = 655.67687;
double cy = 360.57839;
double fx = 910.49139;
double fy = 908.52111;
double depth_scale = 1000;

for (int idx = 0; idx < rgb_names.size(); idx++)
{
	cv::Mat rgb_image = cv::imread(rgb_path[idx], cv::IMREAD_UNCHANGED);
	cv::Mat depth_image = cv::imread(depth_path[idx], cv::IMREAD_UNCHANGED);

	// Calculate XYZ and give them RGB
	PointCloud::Ptr cloud(new PointCloud);

	for (int v = 0; v < rgb_image.rows; v++)
	{
		for (int u = 0; u < rgb_image.cols; u++)
		{
			double d = depth_image.at<uchar>(v, u);
			if (d == 0)
				continue;

			PointT p;
			p.z = d * depth_scale;
			p.x = (u - cx) * p.z / fx;
			p.y = (v - cy) * p.z / fy;
			p.b = rgb_image.data[v * rgb_image.step + u * rgb_image.channels()];
			p.g = rgb_image.data[v * rgb_image.step + u * rgb_image.channels() + 1];
			p.r = rgb_image.data[v * rgb_image.step + u * rgb_image.channels() + 2];
			cloud->points.push_back(p);

		}
	}

	pcl::visualization::PCLVisualizer::Ptr viewer = PCLVisualizers::SimpleVis(cloud);

	while (!viewer->wasStopped())
	{
		viewer->spinOnce(100);
	}

	viewer->close();

}

Is there any information of coordinate system I missed? If there is, could you tell me how to get it?

@MartyG-RealSense Thanks for your reply!! I'll try 'virtual camera' interface


[type: refactor] fix metrics pom

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2998 (024ec4c) into master (4a3348b) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2998      +/-   ##
============================================
- Coverage     59.31%   58.92%   -0.40%
+ Complexity     4374     4339      -35
============================================
  Files           684      684
  Lines         19738    19736       -2
  Branches       1775     1775
============================================
- Hits          11708    11629      -79
- Misses         7050     7124      +74
- Partials        980      983       +3

Impacted Files
Coverage Δ

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

...admin/controller/ShenyuHttpRegistryController.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
42.85% <0.00%> (-12.70%)
:arrow_down:

...in/disruptor/RegisterServerDisruptorPublisher.java
52.94% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
74.79% <0.00%> (-8.95%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
56.38% <0.00%> (-7.45%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3348b...024ec4c. Read the comment docs.


[17.12] vendor: update archive/tar

Backport of https://github.com/moby/moby/pull/35728 (https://github.com/moby/moby/pull/35728/commits/13954b0a6282d919c91626a23967377c19ee7aa2) for 17.12
git checkout -b 17.12-backport-vendor-archive upstream/17.12
git cherry-pick -s -S -x -Xsubtree=components/engine 13954b0a6282d919c91626a23967377c19ee7aa2

no conflicts

ping @tonistiigi @andrewhsu

LGTM

hmm..i see from output of windows pr build job, it needs adjustment:
ERROR: Failed 'VERSION file not found. Is this running from the root of a docker repository?' at 12/08/2017 00:25:33


Question about cumulative updates

Are there no branches or tags for each cumulative update CU1, CU2, CU3 etc.?
e.g. Since I need the docs for CU2, I'd like to avoid newer features.
dynamics365smb is a very wide title imho, Will there be a complete different project when BC140 comes?

Hi there,
We do not currently tag the content based on monthly updates because very few new capabilities are rolled out in these service updates. We encourage you to always get the latest version of the docs from our GitHub repos so that you have the latest bug fixes and other corrections, but if you worry about accidentally adding content for capabilities not present in the on-premises version that you are deploying, then you can always use the content on the on-premises installation media.
I hope this answers you question?


No need to set CORS headers in mantil.go

We are letting HTTP API Gateway to set CORS headers.
And mantil.go is also setting CORS headers on response
That will be removed by API Gateway in this configuration.
| If you configure CORS for an API, API Gateway ignores CORS headers returned from your backend integration.
reference

Solved in commit


It can't find flyway_schema_history but the table is there

Which version and edition of Flyway are you using?
5.0.7
Trying to migrate from 3.2.1
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Maven plugin of the same version.
Maven version is 3.5.2
Which database are you using (type & version)?
Mysql: Server version: 5.7.14-google-log (Google)
But reproduced on h2 1.4.197
Which operating system are you using?
Linux
What did you do?
Migrating flyway from version 3 to 5.
I see that the table name has changed. Also the checksum has changed on version 4 but I skipped v4.
If I mvn flyway:validate, I get a checksum exception.
My goal was to copy the existing schema_version table to flyway_schema_history, keeping both for now, and repair the checksum of the new one.
After the copy, when running validate again, it outputs this:
[WARNING] Could not find schema history table "my_schema"."flyway_schema_history", but found "my_schema"."schema_version" instead. You are seeing this message because Flyway changed its default for flyway.table in version 5.0.0 to flyway_schema_history and you are still relying on the old default (schema_version). Set flyway.table=schema_version in your configuration to fix this. This fallback mechanism will be removed in Flyway 6.0.0.

But the "my_schema"."flyway_schema_history" table has been created. Got the same warning if using flyway.table=flyway_schema_history.
What did you expect to see?
Flyway using the new flyway_schema_history and outputing the same checksum exception.
What did you see instead?
Flyway still querying old  schema_version.
You can check this repo reproducing the issue:
https://github.com/fabiofalci/flyway-from-3-to-5
The first commit uses version 3 to create the database and the second to upgrade to version 5. The database has been commited so you don't need to recreate it.
Just try to run: mvn flyway:validate
Also check that the h2 database has the flyway_schema_history table.

How about https://flywaydb.org/documentation/releaseNotes

Flyway 5.0.0 (2017-12-07)
Important note for users upgrading from Flyway 3.x: This release no longer supports a schema history table upgrade from Flyway 3.x. You must upgrade to Flyway 4.2.0 first before upgrading to Flyway 5.0.0.

I see, so there is no way of skipping v4.

Ok, I was just being cautious in keeping schema_version around.
Now I deleted schema_version and then I was able to repair flyway_schema_history.
Maybe on my live database, I'll rename schema_version when repairing.

Just to add an unlikely scenario.
I renamed the table to flyway_schema_history and seems to be working.
However, if I create a table named schema_version (who knows why), then flyway doesn't work anymore, even if I use flyway.table=flyway_schema_history. Shouldn't flyway forget about schema_version if the new name is found?

Ok, decided to first migrate to 4 because the format of schema_version table has changed, the jump from 3 to 5 didn't work. @panchenko thank you for pointing out the changelog.
Will close this issue as it seems is not relevant.


Grabbed Objects, with Gravity, Stutter when Moving, but not when Stationary

Hey all,
I have objects in my game that can be picked up, and will collide with the environment, as I want. To achieve this, I used the relevant flags on the Throwable script: DetachFromOtherHand, VelocityMovement, TurnOffGravity, and I've tried with and without SnapOnAttach.
The issue I have is that there is a constant stutter when I'm moving with the grabbed object in my hand. I'm using free locomotion, but this also was apparent with teleportation.
It looks as if the hand is always behind my movement, playing catch up, so when I stop stationary, it catches up, with a slight delay, and if I move the object around in my hand whilst I'm stationary, it is absolutely fine. It's just when moving with the object.
For me, this is such an essential aspect to any VR game, to have fluent movement with grabbed objects when moving. This issue has been bothering me for some time, and I have done lots of research, and tried numerous things, to no avail.
I'd be most grateful if someone here can provide a solution for this issue.
Thanks a lot

Seems that when I built my project to test, and with SnapOnAttach enabled this solved the problem. May come in handy for others to take note of.


Fix icons in base layer picker widget

Some of the icons for ArcGIS base layers were changed in #11098. The URLs to these icons in createDefaultImageryProviderViewModel did not have the correct case.

This PR fixes those 3 URLs.

Thanks for the pull request @jjhembd!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Thanks for catching this @jjhembd! The correct casing according to the coding guide is ArcGis. Could you please rename the files instead?

Thanks again @jjhembd!


Baseline adjustment messaging hack

It works! Huzza! :D And HealthGPS is now a lot more flexible. Apologies again for a rather large PR. I'll of course meet to go through it. Ignore the branch name -- this is to do with the baseline adjustment application and messaging to intervention.
In summary, the change moves the baseline adjustment system from the mail HGPS class (this turned out to be rather messy, hence all the scattered changes) into the risk factor classes where they're used. It allows the model classes to control both when it's used, and on which risk factors, and can be run an arbitrary number of times on arbitrary factor sets in a single timestep,
The core part of the PR is the new RiskFactorAdjustableModel abstract class, inheriting from the base RiskFactorModel class, which implements the core simulated mean code, compares against its own stored copy of risk factor expected values, applies the differences to the factors, and ships the adjustments off to the intervention.
If a risk factor model implementer requires baseline adjustment for some/all factors in their model, they would inherit from RiskFactorAdjustableModel instead of the base class, and call adjust_risk_factors(context, vector_of_factor_keys); in their generate_risk_factors or update_risk_factors functions where/when needed.
I did a bit of a tidy up whilst I was in there as well.
Happy to answer questions -- again, sorry for the big one..
Fixes #239

From above:

Are static models expected to have to adjust the risk factors? If no, why do they inherit from RiskFactorAdjustableModel? If yes, where is that adjustment called?

This is just an artefact of having to squash many different functionalities into 'static' and 'dynamic' models. I think the whole static/dynamic model distinction has lost it's meaning and is generally unhelpful now, given that both model types have both initialisation and update methods. I think, from now, just ignore 'static' and 'dynamic', and focus more on the generate_risk_factors and update_risk_factors, and it might be easier to follow.

I see that dynamic models do inherit from RiskFactorAdjustableModel and I see they do use adjust_risk_factors so does it mean that all dynamic models will adjust the risk factors?

The reason one of the 'static' risk factor models (StaticLinearModel) inherits from RiskFactorAdjustableModel is because it eventually will need to use the baseline adjustment feature. For example, in the next step, when the food group risk factors are initialised. Hope that's clearer -- ask away if not.

Actionable items, for my convenience:

Passing explicit values in structures that are needed, instead of whole structure
model_parser.cpp:227: deal with hard coded number (maybe leave it for an issue)
HealthGPS.Test.cpp:409: ASSERT_THROW(RiskFactorModule({}), std::invalid_argument);
riskfactor.cpp:6: use an unordered_map


getProcessList empty on Windows 8.1

I'm trying to use JProcess.getProcessList() in a Windows 8.1 but the result is empty.

Hi, are you getting any error?
Are you using maven? or you have simply downloaded the JAR?

Hi!
No, I'm not getting any error, just the result list is empty.
Yes I install with maven and gradle.

Randomly I get the same proplem on Windows 7, JProcess.getProcessList() return only one idle process

A very simple test to reproduce. After 30 calls JProcesses.get().fastMode(true).listProcesses() returns only one process.
    public static void main(final String[] args) throws InterruptedException {

        final StopWatch stopWatch = StopWatch.createStarted();

        int nb = 0;
        while (true) {

            nb++;

            final List<ProcessInfo> allProcess = JProcesses.get().fastMode(true).listProcesses();

            if (allProcess.size() <= 10) {

                System.out.println("After " + nb + " calls");

                allProcess.forEach(p -> {
                    System.out.println("- " + p);
                });

                break;

            } else {
                TimeUnit.MILLISECONDS.sleep(300);
            }

        }

        System.out.println(stopWatch.getTime(TimeUnit.SECONDS) + " seconds");
    }

Console:
After 30 calls
- PID:0	CPU:null	MEM:24	PRIORITY:0	CMD:
96 seconds

Hi, I am facing the same issue as well on Windows 10,
Are there some plans to fix this?


Don't use external resources

Is your feature request related to a problem? Please describe.
In some countries, it is not really "allowed" (by law) to open connections to other websites. (without consent of users)
e.g.:
  <link rel="icon" href="https://cdn.jsdelivr.net/gh/slidevjs/slidev/assets/favicon.png">

Describe the solution you'd like
So it would be more beneficial to just export these resources as well when building using slidev build.
Describe alternatives you've considered
Download these resources manually and upload them manually to my web space.

I think this is still relevant

@MarcelCoding what country and what law are you referring to ?
Thanks

I am in Germany and currently is there like a thing where website providers that are using Google fonts are being fined for sending their user ips to other countries outside the US. So it would be helpful if all assets would be localized and served from the own web server.

Ok thanks for your response.
What assets are you referring to ?
Is this only for the favicon ?
You can set up a custom favicon using the frontmatter part of the first slide, and if you want to use a local icon just put it inside the public folder and set:
---
favicon: /my-favicon.png
---

See https://sli.dev/custom/#frontmatter-configures

Ok, I did not know this, until now, I just replaced the URL myself in the resulting HTML. But I hope I made you aware of this problem, to that it isn't going to lead to more external (non-configurable) assets.


Add helpers for raw method creation

Feature
Easily write code for manual bindings. The error propagation operator can now be used for error handling.
Let's compare this with the original code.
unsafe extern "C" fn raw_calc(
    this: *mut sys::godot_object,
    _method_data: *mut libc::c_void,
    user_data: *mut libc::c_void,
    num_args: libc::c_int,
    args: *mut *mut sys::godot_variant,
) -> sys::godot_variant {
    (|| {
        let _this = unsafe { Ref::<Reference>::try_from_sys(this)?.assume_safe_unchecked() };
        let user_data = unsafe { cast_sys_user_data::<RawMethod>(user_data)? };
        let mut args = unsafe { Varargs::from_sys(num_args, args) };

        let a = args.next().and_then(|v| v.to::<i64>()).unwrap_or(3);
        let b = args.next().and_then(|v| v.to::<i64>()).unwrap_or(4);

        let result =
            user_data.map(|ud| gdnative::export::catch_unwind(move || a * b + ud.inner));

        Ok::<_, Box<dyn Error>>(result??.to_variant())
    })()
    .unwrap_or_else(|err| {
        log::error(godot_site!(raw_calc), err);
        Variant::nil()
    })
    .leak()
}

List of APIs to add
Most APIs are added to simplify error handling.
Ref::try_from_sys()
Convert from a raw pointer, incrementing the reference counter if reference-counted.
If obj is null, an error is returned.
cast_sys_user_data()
The user_data wrapper can be obtained directly.
Takes an opaque pointer produced by into_user_data and "clones" it to produce the
original instance, increasing the reference count.
If user_data is null, an error is returned.
catch_unwind()
Wrapper function for std:panic:catch_unwind() that returns PanickedError when panicked.
PanickedError displays the contents if the payload passed during panic has type &str or String.
RawMethodBuilder
Builder type used to register a raw method on a NativeClass.
Compatibility
Since this PR only adds an API, there are no compatibility issues.

Thank you for this pull request! 🙂
Maybe before I have a detailed look, could you describe a bit the context and motivation? Where do you need raw methods? Why not the high-level API?
Note also that we removed an entire API around ClassBuilder::add_method() in 0.10.0, see details in https://github.com/godot-rust/godot-rust/pull/828. We specifically did so to direct the user towards the safe and easier-to-use equivalent ClassBuilder::method().

Where do you need raw methods?

My use case is optimization of the wrapper generated by the #[methods] macro.
The current macro generates wrappers that uses dynamic dispatching, which limits optimization by the Rust compiler. Generating wrappers that uses static dispatch is as simple as generating the direct wrappers. So I added the RawMethodBuilder.
Also, some may write user-defined macros for the following reasons.

Create wrappers using method_data.
Rc<T> directly to the engine so that references can be shared with Rust code.

Right now there is no way to access the Arc<T> used in the UserData wrapper.
If I were developing a game with lots of engine interaction, I might have done this.

To do something necessary for asynchronous processing.

Why not the high-level API?

This is due to technical limitations. I don't know how to optimize it other than by creating direct wrappers. :slightly_frowning_face:

Note also that we removed an entire API around ClassBuilder::add_method() in 0.10.0, see details in #828. We specifically did so to direct the user towards the safe and easier-to-use equivalent ClassBuilder::method().

I would not recommend removing the API without an alternative. :sweat_smile:
I think manual binding is mostly used to circumvent the technical limitations of the high-level API. So it is reasonable to provide low-level APIs as ways of manual binding. Well, the side effect is that its API becomes unsafe. :innocent:

Changed from_sys() to properly bounded lifetime. This is a bit of strange definition. :roll_eyes:

bors try

Reports whether RawMethodBuilder methods are marked as unsafe or not.
method_ptr and free_func
These two methods are considered safe because they cannot be passed invalid function pointers.
Of course, it is possible that a method passed may be unsafe, but it will be marked as unsafe inside the implementation.
method_data
This method is considered safe because the passed value is not accessible to Godot engine. It can be accessed by methods registered with method_ptr and free_func, but responsibility for safe handling rests with the registered method.
The passed value must be dropped by a method registered with free_func or leaks of memory will occur, but that is considered safe in Rust.
with_rpc_mode
This is obvious. :monocle_face:

The current macro generates wrappers that uses dynamic dispatching, which limits optimization by the Rust compiler. Generating wrappers that uses static dispatch is as simple as generating the direct wrappers. So I added the RawMethodBuilder.

This was static dispatch since the dyn keyword was not used. Wrong! :dizzy_face:

Create wrappers using method_data.

It seems that if data are included in a structure that implemented Method trait, they can be substituted for method_data.
struct Foo {
    bar: i64 // included data
}

impl Method<Baz> for Foo{
    fn call(&self, _this: TInstance<Baz>, args: Varargs) -> Variant {
        self.bar // use data
    }
}


UTY-189: Mutable View API Review

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
This PR makes some changes to the MutableView API to clean it up by removing unnecessary methods/fields, making things internal where appropriate, and reorganising the methods such that they go in public -> internal -> private order.
List of changes:

Remove all shared component methods on the MutableView as they were not used and a relic of the past.
Remove the connection on the view and the setting of it in the Worker. Systems now access the connection via the worker abstraction.
Added component pools to world commands, this allowed me to remove AddCommandResponse<T>(Entity entity, T commandResponse) and private void AddReceivedMessageToComponent<TMessagesReceived, TMessage>(Entity entity, TMessage message)
Removed one of the HandleAuthorityChange methods as one literally just called the other.
Removed: T GetOrCreateComponent<T>(Entity entity) as it was no longer being used.
Made CreateEntity and RemoveEntity internal. These should not be publicly available for use as they are meant for ops coming off the wire.

Tests
Built and ran locally.
Documentation
N/A
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.
@sami @jessicafalk

For ease of reading these types of prs I'd suggest removed methods, moved methods, and changes should be in separate commits. A lot of looking at removed lines and checking if the method is still somewhere else.

@jessicafalk I think we all agree that the worker/view abstraction needs a redesign, however as that is design work and not just a tidy I would argue that it should be in a different PR.

Yup.. I'm generally in favour of merging the Worker and MutableView abstraction together and trimming it down. That's definitely out of scope of this PR though :)


implement an UNIX socket to send commands

Currently, daemonded can only take commands from stdin. I think it would be very helpful to allow it to read commands from an AF_UNIX socket, so that it could be run under a supervisor and still be driven.

It already does that. You can use it by launching Daemon with plus commands in the command line while an existing instance is already running. Though it may be broken on Linux currently.

It works, we fixed the last remaining bugs as far as I know.

What we may want is a command line option to not start the engine if there is no already running engine, to make sure it is only used as a command forwarder.

Well, then, let me rephrase it: I would like to have a named pipe, that can be changed from command line. This would allow to run the daemon under supervision while still be able to send it commands.
If this exists, then it needs documentation (lol)

There is no named pipe to send command with cat, but there is a pipe the engine uses to send command to existing instance.
# This starts an engine in background
nohup ./daemonded +devmap plat23 &

# This forward a command to the already running engine
./daemonded +devmap parpax

That's useless.
What server owners need is a way to drive the daemonded daemon without a process constantly running. Running under screen is just a hack, a workaround. This ticket is about implementing a proper solution.

Engine already is bad with that "by build default" crash_handler, it's very UNfriendly to server admins that automate things imo. I think it would be nice to improve that, even if opt-in.
I'm ok to implement it myself, if it's accepted as a wished feature, but not important enough to merit senior's attention.

Sounds useful.

I don't understand? You always need an instance of daemonded running if you want to interact with it. The 2nd instance doesn't continue to run. It runs the command and exists immediately.

On my server, I used to have 4 instances of daemonded: SK3, SK5, SK7, and SK9. How can I send commands to a specific instance with the current way?

How can I send commands to a specific instance with the current way?

by setting -homepath I bet

this is certainly very practical.

Correct. The homepath contains the socket, and daemon will look there.

Closing since the feature already exists.


Usability question: how do you add settings for rust_analyzer?

E.g. how can I disable rust-analyzer.completion.addCallArgumentSnippets? I've tried these two versions (both are just inline in the settings):
nvim_lsp.rust_analyzer.setup {
  on_attach = on_attach,
  settings = {
    ["rust-analyzer.completion.addCallArgumentSnippets"] = false;
    ["rust-analyzer"] = {
      completion = {
        addCallArgumentSnippets = false;
      }
    };
  }
}

Neither seems to do anything.
Sort of related to https://github.com/rust-analyzer/rust-analyzer/issues/2344

How about this?
nvim_lsp.rust_analyzer.setup {
  on_attach = on_attach,
  settings = {
    rust-analyzer = {
      completion = {
        addCallArgumentSnippets = false;
      }
    };
  }
}

How about this?
nvim_lsp.rust_analyzer.setup {
  on_attach = on_attach,
  settings = {
    rust-analyzer = {
      completion = {
        addCallArgumentSnippets = false;
      }
    };
  }
}

That's not valid Lua. Since there's a dash in rust-analyzer it has to be ['rust-analyzer'].

OK, I'll debug with rust-analyzer tonight.

@h-michael He's just saying that you need to pt rust-analyzer in the Lua way of specifying special strings or items (which is ['rust-analyzer']). I think your suggestion is good.

The (fixed) suggestion doesn't seem to be working for me though. I have:
nvim_lsp.rust_analyzer.setup {
  on_attach = on_attach,
  settings = {
    ["rust-analyzer"] = {
      completion = {
        addCallArgumentSnippets = false;
      }
    };
  }
}

which doesn't seem to do anything.

OOOPS! Sorry. the settings do work as expected. Sorry for the noise! Thanks for the awesome plugin!
This works:
nvim_lsp.rust_analyzer.setup {
  on_attach = on_attach,
  settings = {
    ["rust-analyzer"] = {
      completion = {
        addCallArgumentSnippets = false,
        addCallParenthesis = false,
      },
    },
  }
}

I wasn't correctly using the most recent version of rust-analyzer that supports these settings.


Search input suggestion and history seems broken/gone

I recall we had working search suggestions?  https://github.com/kodadot/nft-gallery/pull/1576
you can try it here https://deploy-preview-1576--koda-nuxt.netlify.app/rmrk/gallery?page=2196 search for "kusama" for example

Search is broken as well https://beta.kodadot.xyz/rmrk/gallery/?search=kusama&page=10
Ref

#1612

Hmm, I noticed something strange. If you are on the 10th page of a search and search for something new, you go to the 10th page of the latest search result. Happens for collection as well.
Gallery
https://user-images.githubusercontent.com/44033666/150073410-1060e63d-208b-4206-9bac-deac78d3dd5e.mp4
Collections
https://user-images.githubusercontent.com/44033666/150073443-b03afc96-26a1-4838-8d69-6c3f1fbac25d.mp4

Hmm, I noticed something strange. If you are on the 10th page of a search and search for something new, you go to the 10th page of the latest search result. Happens for collection as well.

I've added bug-hunt 🏷, nothing more I can do it rn.
If you would love to crack on that, let's go, bounty is there! :)

hi, I will fix this bug!

Partially this issue was fixed, suggestions are working