fix: MD031 spaces around code fences

Fixes #
Docs for Toolkit PR #
What changes to the docs does this PR provide?

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Correctly picked the right branch to base the change off (master for new features, live for typos/improvements)
[ ] For new pages, used the provided template
[ ] For new features, added an entry in the Table of Contents
[ ] Ran against a spell and grammar checker
[ ] Contains NO breaking changes

Other information

Docs Build status updates of commit 9c108fd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/animations/Expressions.md
:warning:Warning
View
Details

docs/animations/Offset.md
:warning:Warning
View
Details

docs/controls/TextToolbar.md
:warning:Warning
View
Details

docs/controls/datagrid_guidance/keyboard_navigation_selection.md
:warning:Warning
View
Details

docs/controls/datagrid_guidance/rowdetails.md
:warning:Warning
View
Details

docs/controls/datagrid_guidance/styling_formatting_options.md
:warning:Warning
View
Details

docs/controls/wpf-winforms/WindowsXamlHost.md
:warning:Warning
View
Details

docs/high-performance/Introduction.md
:warning:Warning
View
Details

docs/high-performance/MemoryOwner.md
:warning:Warning
View
Details

docs/high-performance/Ref.md
:warning:Warning
View
Details

docs/controls/wpf-winforms/MapControl.md
:bulb:Suggestion
View
Details

docs/controls/wpf-winforms/WebView.md
:bulb:Suggestion
View
Details

docs/controls/wpf-winforms/WebViewCompatible.md
:bulb:Suggestion
View
Details

.markdownlint.json
:white_check_mark:Succeeded

docs/animations/AnimationSet.md
:white_check_mark:Succeeded
View

docs/animations/Blur.md
:white_check_mark:Succeeded
View

docs/animations/CompositionAnimations.md
:white_check_mark:Succeeded
View

docs/animations/ConnectedAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Fade.md
:white_check_mark:Succeeded
View

docs/animations/FadeHeader.md
:white_check_mark:Succeeded
View

docs/animations/ImplicitAnimations.md
:white_check_mark:Succeeded
View

docs/animations/Light.md
:white_check_mark:Succeeded
View

docs/animations/ReorderGrid.md
:white_check_mark:Succeeded
View

docs/animations/Rotate.md
:white_check_mark:Succeeded
View

docs/animations/Saturation.md
:white_check_mark:Succeeded
View

docs/animations/Scale.md
:white_check_mark:Succeeded
View

docs/archive/Bing.md
:white_check_mark:Succeeded
View

docs/archive/HamburgerMenu.md
:white_check_mark:Succeeded
View

docs/archive/ParallaxService.md
:white_check_mark:Succeeded
View

docs/archive/SlidableListItem.md
:white_check_mark:Succeeded
View

docs/controls/AdaptiveGridView.md
:white_check_mark:Succeeded
View

docs/controls/CameraPreview.md
:white_check_mark:Succeeded
View

docs/controls/DropShadowPanel.md
:white_check_mark:Succeeded
View

docs/controls/Eyedropper.md
:white_check_mark:Succeeded
View

docs/controls/ImageCropper.md
:white_check_mark:Succeeded
View

docs/controls/InAppNotification.md
:white_check_mark:Succeeded
View

docs/controls/Loading.md
:white_check_mark:Succeeded
View

docs/controls/RangeSelector.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/customize_autogenerated_columns.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/datagrid_basics.md
:white_check_mark:Succeeded
View

docs/controls/datagrid_guidance/group_sort_filter.md
:white_check_mark:Succeeded
View

docs/extensions/LogicalTree.md
:white_check_mark:Succeeded
View

docs/extensions/VisualTree.md
:white_check_mark:Succeeded
View

docs/helpers/AdvancedCollectionView.md
:white_check_mark:Succeeded
View

docs/helpers/BackgroundTaskHelper.md
:white_check_mark:Succeeded
View

docs/helpers/BluetoothLEHelper.md
:white_check_mark:Succeeded
View

docs/helpers/CameraHelper.md
:white_check_mark:Succeeded
View

docs/helpers/Colors.md
:white_check_mark:Succeeded
View

docs/helpers/DeepLinkParsers.md
:white_check_mark:Succeeded
View

docs/helpers/DispatcherHelper.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

docs/animations/Expressions.md

Line 228, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Intro') are not allowed. You can only have one top-level heading.
Line 269, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'How to: Build Core Components of Expressions') are not allowed. You can only have one top-level heading.
Line 724, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Translating Old World to New') are not allowed. You can only have one top-level heading.
Line 873, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'E2E Building Examples') are not allowed. You can only have one top-level heading.

docs/animations/Offset.md

Line 124, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.
Line 148, Column 5: [Warning-duplicate-alt-text] Alt text 'Use Case 2 Output' is duplicated. Within an article, alt text must be unique.

docs/controls/TextToolbar.md

Line 29, Column 1: [Warning-alt-text-bad-value] Alt text 'TextToolbar' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/keyboard_navigation_selection.md

Line 57, Column 1: [Warning-alt-text-bad-value] Alt text 'Selection' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/rowdetails.md

Line 12, Column 1: [Warning-alt-text-bad-value] Alt text 'RowDetails' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/datagrid_guidance/styling_formatting_options.md

Line 26, Column 1: [Warning-alt-text-bad-value] Alt text 'Gridlines' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 99, Column 1: [Warning-alt-text-bad-value] Alt text 'FrozenColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 112, Column 1: [Warning-alt-text-bad-value] Alt text 'ResizeColumns' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/wpf-winforms/WindowsXamlHost.md

Line 68, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
Line 72, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
Line 78, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.
Line 82, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.

docs/high-performance/Introduction.md

Line 51, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.buffers.arraypool-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 52, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.unsafe' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 53, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.memorymarshal' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 54, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.threading.tasks.parallel' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

docs/high-performance/MemoryOwner.md

Line 12, Column 149: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.buffers.imemoryowner-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 12, Column 367: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.buffers.arraypool-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20, Column 443: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.memory-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20, Column 522: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.span-1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

docs/high-performance/Ref.md

Line 84, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'ReadOnlyRefT>') are not allowed. You can only have one top-level heading.

docs/controls/wpf-winforms/MapControl.md

Line 29, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
Line 182, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/controls/wpf-winforms/WebView.md

Line 547, Column 60: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

docs/controls/wpf-winforms/WebViewCompatible.md

Line 20, Column 53: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
Line 23, Column 156: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
Line 35, Column 692: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.
Line 53, Column 528: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.windows.controls.webbrowser?view=netframework-4.7.2. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


tooltip can not show with method !

i create a jBox instance,type is tooltip.
but i can not use show() method to show it.
the tooltip show with wrong position on my html page .
same code bellow:
body{position:relative;max-width:10rem;margin:0 auto !important;min-height:100%;display:block;}
#page {width: 100%; height:100%; overflow-y:auto; margin: auto; background: #f5f5f5;}
all my ui is in div#page.the html
the html style 'font-size' max is '54px',when it shows on desktop;

by the way .
Tippy.js is workd fine on my project,but it dose have modal and notify,
so if jBox can fix the problem,it's good for me.

The .show() method only works after you have hidden a jBox with .hide().
I just tried to reproduce with your code and I think the problem is that you are resizing the body element: https://jsfiddle.net/StephanWagner/hsmf250k/
That's not best practice, best is to resize a div within the body element, something like that: https://jsfiddle.net/StephanWagner/hsmf250k/8/
Also check out flex-box: https://css-tricks.com/snippets/css/a-guide-to-flexbox/
Maybe that will help to create a layout that fills 100% of the viewport height. Resizing the body element usually creates trouble. It's also best practice to let the body element scroll your page.


Some phone numbers are accepted by validation, but are not saved in database

What I'm trying to achieve
I'm trying to use invalid US phone number: +1<PHONE_NUMBER> in my shippingAddress. It passes validation (I have no error), but it is not saved in the database.
Investigation
It's another consequences of the packages upgrade described in #4086. The new version of django-phonenumber-field calls is_valid method on the phone number before saving it to the database. On the other hand, backend validates shipping address with I18nMixin class, which uses https://github.com/mirumee/saleor/blob/master/saleor/account/i18n.py. There is used a concept of possible_number, not a valid number
Steps to reproduce the problem

Use that phone number in shipping address form in https://pwa.getsaleor.com/
Select shipping method
Phone number disappeared.

What I expected to happen
Invalid phone numbers (like +1<PHONE_NUMBER>) are rejected on validation or, if there is a decision to store possible and potentially invalid phone numbers in the database,
Screenshots

System information
Operating system: n/a
Browser: n/a

I think the problem may be here: https://github.com/mirumee/saleor/blob/d212e1df89f73997138734c8cd6758912fab1e07/saleor/account/models.py#L21-L24
We're explicitly changing the default validators to less strict ones. There is no comment explaining the reasoning behind it though.


improved global memory coalescing

modified the CUDA code such that it uses additional threads whose only purpose (at the moment) is to write out the buffers to global memory with coalesced access.

I tested it on our Quadro RTX 6000, and I still get errors for l=0 (and actually also some other ls, like l=36 for some reason).  Error is triggered outside the cuda code but I suspect it's the usual CUDA weirdness
Traceback (most recent call last):
  File "/home/ceriotti/source/sphericart/benchmarks/pytorch/benchmark.py", line 325, in <module>
    sphericart_benchmark(
  File "/home/ceriotti/source/sphericart/benchmarks/pytorch/benchmark.py", line 88, in sphericart_benchmark
    xyz = xyz.clone().detach().type(dtype).to(device).requires_grad_()
RuntimeError: CUDA error: an illegal memory access was encountered

OK @nickjbrowning and I debugged this and I think it's good to go. Unless someone wants more time to review this, I'll merge later today.

Looks fine to me. It would be nice to have a comment with a high-level explanation of what the different threads are doing.


Next Version & Plugin system

As discussed via PM on twitter with @technopagan and @efegurkan, we should rewrite sqip to be a plugin based system.
This step could be used to refactor the codebase, here is my proposal:
Todo

[x] transform the code into one style via eslint + prettier #31
[x] replace argv with yargs. Allows more complex cli argument parsing.  Replacing this and this #34
[x] split up primitive svg group fix and blur filter to be used as or in plugins, remove unused xmldom and apply group fix via cheerio
[ ] transform api to async api and provide sync method #5  #42
[ ] upgrade all dependencies #42
[x] add tests and aim for ~90% unit test coverage, make some integration/e2e tests. I'd go for jest and nixt
[ ] build the actual plugins #43  -->

Possible plugins

primitive itself (if primitive is a plugin, you can reapply sqip on svgs to use the other plugins without modifying your actual svg content, could straight fix #22, too)
blur filter
loading animation filter (Example: https://axe312ger.github.io/svg-loading-animation/)
svgo (set your own options or just skip it)
.. more? There are many possibilities. Maybe outlined shapes via potrace like https://github.com/EmilTholin/image-trace-loader does?

If you skip the plugins configuration, we just apply the current defaults to achieve simple blurred svg previews.
Current config:
const sqip = require('sqip');

const result =  sqip({
    filename: './input.jpg',
    numberOfPrimitives: 10,
    mode: 3,
    blur: 8
});

New plugin config:
const sqip = require('sqip');

const result =  sqip({
    filename: './input.jpg',
    plugins: [
      sqip.primitive({
        numberOfPrimitives: 10,
        mode: 3
        // just pass everything to primitive
      }),
      // Add blur if you need it
      sqip.blur({
        factor: 8
        // maybe allow other blur types?
      })
      // Blend in shapes over time (Would be my first plugin)
      sqip.loadingAnimation({
        ease: 'easeIn',
        duration: 3000
      })
    ]
});

The progress of this is tracked in the next branch. PR: #35

First of all thank you @axe312ger solid plan.
Since we are planning to become a more complex project with these additions. We should also add tests to these plan as well. It should be simple to write unit tests for most of the code and the plugin system would actually help us on there.
For the integration tests, as far as I remember primitive was not generate the same result always. Not sure how to approach there exactly. In theory if we mock primitive, we can have some integration tests to test parts that does not include primitive.

Thanks Efe, you are very welcome.
I agree with the tests. I'd go for jest since it gives really good DX :)
We could use cheerio for checking the primitive output. Just count the shapes and see if the type of shapes matches the given mode. At least on a minimal level as it is not our job to ensure primitive is working properly.

After #36 is done, the async API can be done with upgrading all dependencies (only svgo missing atm since it is async online since v1)
Straight afterwards we can start creating the plugin api, extracing the blur and make our own plugins. Can't wait to add my svg loading animation plugin 😏

Argh, just realised I will need to implement babel to make proper readably async code for node v6.
I guess there is no way around, I really don't want to nest/chain all the promised. async await is great and is available as soon node v8 gets into LTS... sooo... one year of babel.. I guess we can life with it 😅

Hey Benedikt, I personally wouldn't mind babel stuff. :+1:

Alright cool. Will start with it soonish after my vacation. I will blog about SQIP which may boost this, too :)
On 19. Jun 2018, 14:41 +0200, Efe Gürkan YALAMAN<EMAIL_ADDRESS>wrote:

Hey Benedikt, I personally wouldn't mind babel stuff. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm so excited for this, gonna make my life a lot easier 😄 Also, since almost a year has passed node 6 is going bye-bye 🎉
But since babel is already in, let's not add more work to the pile. Thank you for this lovely library ❤

Closed in favor of https://github.com/axe312ger/sqip/issues/90
@maxnordlund you are very welcome to test our new v1 alpha :)


Fix for zero-sized layers

Closes #18170
Add support for loading an image where one layer is empty - literally zero bytes in the tar file, no padding or anything.  Not sure how we got into this state, I can't reproduce it, but nevertheless there's an image in Dockerhub like this ( matthughes/library-centos:6-2015.03.20 ) so this makes sure we can load it.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

ping @vbatts

LGTM

moved a defer up a little to a better spot - thanks to @MHBauer for noticing.

So interesting. It seems like we hardly need to do more than just return as if the read is done, but this seems fine.
LGTM

counting two LGTM's so moved to "merge"

let's wait for the tests to finish first, just want to make sure the move of the defer doesn't break something

@duglin that's why I applied the label, and didn't press the button :+1:

Why do we do this is tar loading? If such images exist wouldn't they fail on pulls also?

Pulls fine for me:
λ docker pull matthughes/library-centos:6-2015.03.20
6-2015.03.20: Pulling from matthughes/library-centos
17d1436ef796: Pull complete
9c7cb910d843: Pull complete
25445a0fc502: Pull complete
Digest: sha256:aaba82794dff22b95c649cdd03fcdf3929ce5ecc953403718e713336bc6f9a85
Status: Downloaded newer image for matthughes/library-centos:6-2015.03.20

λ docker images matthughes/library-centos:6-2015.03.20
REPOSITORY                  TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
matthughes/library-centos   6-2015.03.20        25445a0fc502        8 months ago        215.7 MB

λ docker history matthughes/library-centos:6-2015.03.20
IMAGE               CREATED             CREATED BY                                      SIZE                COMMENT
25445a0fc502        8 months ago        /bin/sh -c #(nop) ADD file:2b2b26209d285cd1a9   215.7 MB
9c7cb910d843        13 months ago       /bin/sh -c #(nop) MAINTAINER The CentOS Proje   0 B
17d1436ef796        2 years ago                                                         0 B                 Imported from -

@tonistiigi I originally had this fix in that func but then the unit tests failed because there are cases where EOF is a valid return value (error cases) and the unit tests were looking for them. So I moved this logic up a level.  Not 100% sure this is still the right spot but it did seem to fix it.

This change is better to understand now with all the pools gone but I still doubt it's the correct approach.
First, this isn't specific to load. The problem appears when you point empty file to DecompressStream and for this image, in the registry, the blob is compressed so the error doesn't appear. I pushed the same image uncompressed as tonistiigi/library-centos:6-2015.03.20 and it fails on pull just like load does.
Other problem is that if the tar was some random garbage less than 10 bytes, then with this fix we would completely ignore the error.
My suggestion would be that if DecompressStream cannot detect the compression because of an error on Peek() it should just redirect the data as uncompressed and not error by itself. This breaks a unit test TestUntarPathWithInvalidDest but if you look at what the test does, it should really be named TestUnpackingEmptyFileShouldFail, so I'm not sure which behavior we want.
If for some reason we want to have exceptions for pull/load etc. but not change the function we should define DecompressStreamAllowEmpty() or IsEmptyReader() and call that instead in pull/load code.
Also, I'm not sure if we should count empty file as a valid tar's at all. Maybe it's ok to error. Not sure what has caused them in this image.

Removed the "merge" status for now - needs more reviews/work.

@tonistiigi you were correct to push on the validity of the unit testcase. It was passing for the wrong reasons.  Once I fixed that ignoring EOF in DecompressStream does seem to work. The test now, correctly, uses an invalid destination and will fail for that reason, not due to the source tar being empty.
See what you think.

LGTM

@vbatts and @LK4D4 can you guys re-review it, just to be sure? thanks.

@tonistiigi thanks for the help

LGTM on the updated fix

LGTM

Thanks so much @duglin !

@matthughes you're welcome - let me know if it doesn't fix it  :-)


[BUG] VC LDP credential issuance requires the credential.type array to have more than 1 item

The VC data model 1.1 spec states that the credential.type array can optionally have a second type:
VerifiableCredential and, optionally, a more specific verifiable credential type.
https://www.w3.org/TR/vc-data-model/#types
I would recommend to remove the validation on the length == 1 for the credential.type as indicated in the specification.
Happy to provide a PR if this is approved.

PR welcome :-)!


Readme

Hi Michał,
Great work. Can you please provide README.MD with information about project?
Thanks!

Hi Konrad,
Right now I'm in hard development stage, working on awesome features. I will provide README right after I finish (shouldn't take a long time) :)


auto generate article metadata

Auto generate article metadata

[x] slug (from title)
[x] description (from rich-text block)
[x] metaTitle
[x] metaDescription
[x] metaShareImageUrl

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
v1.0.0-beta.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Container enters failed state without any error

Sometimes containers enter 'Failed' state and no error can be found. This is a serious issue. The container is first running properly for a while. However, when the container is terminated due to some unknown error, it is not possible to find the error.
In such cases, the application log also does not contain any error. Interestingly, when the same container is run locally, all works fine. This indicates (not an approval) that the app inside of the container works properly. However, when the same container runs inside of ACI, it fails with no error specified. It seems that the container is terminated by the host, but it is not clear why.
Container state and log output

container instance state (az container show)

"instanceView": {
"events": [],
"state": "Failed"
},

Connect

{"error":{"code":"ContainerGroupStopped","message":"Container Group 'si01-uc12-taf-elparts-fnc' in resource group 'RG-CPDM-DEV' is stopped."}}

Region
Germany West Central

Document Details (Portal click on 'connect')
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab165b0d-5cb2-45dd-8e67-3462210e2815
Version Independent ID: 7f2bf4ef-5354-ed9d-cd19-4bcb6b462d0f
Content: Troubleshoot common issues - Azure Container Instances
Content Source: articles/container-instances/container-instances-troubleshooting.md
Service: container-instances
GitHub Login: @macolso
Microsoft Alias: macolso

@ddobric This issue needs deeper investigation. Support team will be able to check and help on this.
If you have a support plan, requesting you to file a support ticket, else please do let us know, we will try and help you get a one-time free technical support.

@VikasPullagura-MSFT  thanks for the quick response.
I will open a support ticket. However, in the meantime, I have an idea of what the issue could be.
If the container hits the memory limit, the host will terminate it. The problem with this is, that the host should give information about this. That unfortunately doesn't happen.
Additionally, the issue with this is the monitoring, which is probably even not a part of ACI. For example, if the container is limited by 4GB we can follow memory consumption in the group diagram until 3,6 is reached. However, if the container for a short moment of time requests 4,5GB, the memory consumption graph will not detect that peak, because it accumulates the average consumption in a time window, let's say 1 min. While this happens, the ACI service will terminate the container.
Issues

The memory consumption is not good enough to detect such kinds of problems. The same problem was detected when working with App Service and Azure Funtions. It seems to be a general monitoring issue. However, the AppService has additional health-features that sometimes at least notice you about the restart of the App Service.

Terminating the container does not generate any information about the reason of termination.
If the container is terminated, because of the memory limit, it should give us an error message about this.

If my assumption is correct, you should reopen this issue.
Hope this helps.

@ddobric Any update that you can share from the support case you have opened.

Sorry, till now no support ticked opened.
We have many test runs with several containers. The issues are obvious. When the container has a memory peek over the specified limit then:

Container is terminated by the host without any error, that might indicate the reason.
From time to time the container log contains outofmemory exception (code is in .net core).

Expectation: If the container need more REM than specified it is ok to terminate it, but then we want to see an error like:
"Please allocate more memory for the container. Here is the memory usage diagram."

The maximum memory is also not monitored. The maximum memory is all-time under 80%.
However, obviously, some peek occurs that causes the termination.
Expectation:
Accumulated samples of memory consumption sometimes do not sample peek that lead to termination.

The workaround is to increase the memory 30-50% of the current one.

The fact is, logs are truncated. Sometimes we have an application error in the container while developing.
If the stack trace is too long (sure, when using async/await there is a lot of trash in the stack), the log is truncated, so the most important information in the log is missing.
Expectation:
Please take a look at the solution in Azure Functions. Console output might be written to the storage or insights etc.

Many of these points look to me as hosting in ACI still has some gaps, that need to be improved.
Hope this helps.

@ddobric Thanks for the update.
I would recommend you to share the feedback here. Product teams will add comments to your feedback.
I would still recommend to open a support case so that the support team can check and share the cause.
However, I am tagging @macols from product team for visibility on this.


Add readme details for Create & Delete topics

@hgm-king is this still a viable issue? I could take this one if needed.


Fix social char count for open source blueprints

Assuming Generic as the default option, this will be fixed as soon as #274 is accepted.

Fixed as a part of https://github.com/voxmedia/autotune/pull/333


support React 15.6 across packages. make lerna a dev dep.

cc @milesj

Coverage remained the same at 78.306% when pulling 2b60cf829c05d08a14bd571ae20baabe9c59c888 on chris--react-deps into 12627dbdbcfb88a5e2fa1a79f86203c05628d862 on master.

Awesome, thank you!


[DOC, REF] Add TimeSeriesKernelKMeans and TimeSeriesKShapes to clustering/__init__.py and also adds examples to dosctring

Reference Issues/PRs
Solves #942. See also #1091.
What does this implement/fix? Explain your changes.
Adds TimeSeriesKernelKMeans and TimeSeriesKShapes to clustering/__init__.py.
Adds doc string example for:

TimeSeriesKernelKMeans in file _kernel_k_means
TimeSeriesKShapes in file _k_shapes

ah unfortunately there is a problem doing the init for estimators with soft dependencies. iirc if we import in init it means everything in the package then requires the soft dependency to run. Am I remembering correctly @chrisholder @MatthewMiddlehurst ?

I implemented the changes suggested by @MatthewMiddlehurst (thanks!), but I also had to remove random_state=1  from TimeSeriesKernelKMeans.fit( ) so that the Linter would accept the line lenght.
I hope everything is in order now


LTD-3653-Hide-show-CLEs-MLs

Workflow

[x] Ticket exists in Jira https://uktrade.atlassian.net/browse/LTD-3653
[x] Jira ticket has the correct status.

Reviewing help

[ ] Explains how to test locally, including how to set up appropriate data
[ ] Includes screenshot(s) - ideally before and after, but at least after

Housekeeping

[x] Frontend assets have been re-compiled.

Merging

[x] This PR can be merged by reviewers. (If unticked, please leave for the author to merge)

This has been updated to pull mentions using a separate API call.  This is necessary because notes and timelines pulls audit logs. Mentions now uses mentions data from the API using the actual representation of the model as opposed to the audit log.
This still needs some UI tweaks which will be raised as a separate jira and PR , however this won't impact since it's feature flagged.


Infinite Loading of dropdown and clear icons in Search for Facility dialouge box

Describe the bug
The loading state keeps flickering from true to false continuously in Search for Facility Dialogue Box
To Reproduce
Steps to reproduce the behavior:

Go to '/Assets'
Click on Create New Asset
Observe the input field of Search for Facility Dialogue Box
See error

Expected behavior
The icons shouldn't keep flickering and clear icon should appear only if a facility is selected
Screen Recording
https://github.com/user-attachments/assets/22cc3593-fb90-4b51-bdc2-4db1e09187d4
Expected Behaviour:
https://github.com/user-attachments/assets/58cec3fe-31b3-4ebd-9ebe-2334d9daa344
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version Latest

Infinite loading doesn't seem to be an issue on the latest for local.
#9264 addresses the clear button issue.

Got it @Jacobjeevan

@Jacobjeevan I'm on latest codebase too, but somehow I'm facing that infinite load issue 🤔

@nithish1018 Sir can I work on this issue

@Jacobjeevan I'm on latest codebase too, but somehow I'm facing that infinite load issue 🤔

My bad, I hadn't fetched to latest; looks like it's due to changes in AutoCompleteAsync, so @manmeetnagii 's PR addresses the issue.


Typos in example code for pico_display

Typos in the README.md example code result in a failure to compile.
Line 54: 'rect' should be 'Rect'
Line 60: 'point' should be 'Point'

...And the call to set_pen changing the colour to something different that was used earlier for the text_rect so that the text is actually visible is missing from the code.
eg add a pico_display.set_pen( 196, 145, 2 ); immediately preceding the pico_display.set_pen( 196, 145, 2 ); and the example actually works (along with the name capitalization changes others have noted).

Fixed in PR #42


Create an "Add Block" popover widget

The designs have a popover widget that is used to select a block type when adding new blocks to an elemental area. This widget is shown when clicking the add button and also when using the control that appears between blocks (see designs).
Designs
User Story
As a user, I want a way to select a block from a selection of blocks which have been made available to me and add it within a page, so that I can build a page with different block types easily.
A/Cs

[ ] React popover component created that can be opened at an arbitrary point on the page
[x] Popover lists the blocks that are available to be added to a page
[x] The correct icon is used for blocks that are available
[ ] Block options can be tabbed through (ie. keyboard accessible)
[ ] ~Only 8 blocks are shown, and a "Show all blocks" link is provided to show all blocks immediately~

Related issues
(Closed) Previous issue: #293
Show this popover when pressing the buttons: #339
Make this popover do something: #340
Implement the search functionality: #341
Show an "Add Blocks" link/control when no blocks are in an area: #351

Can we remove the AC "Only 8 blocks are shown, and a "Show all blocks" link is provided to show all blocks immediately"? As a first cut, it would be best to just show all blocks in alphabetic order. We will advise on a max-height for the popover and blocks can just scroll within that space. There will be a downside to this (double scroll with page beneath) but makes it an easy start to getting something usable with having to do a "show all" expand area.
Sorry I can't edit the original issue.

So remove the A/C and replace it with "Blocks are shown in alphabetical order and a scroll bar is used when there are many blocks"? Also, I note that the designs say "most used" but we don't have a method to determine the "most used" blocks right now - and it's not really factored into the estimation for this task - Should we separate that out? I note you're talking about blocks in alphabetical order so should we change the title ("most used")?

@newleeland confirmed that we won't show a "Most used" heading for now, but it is something that may be added in the future. For now we won't show a heading.

Could you also include in the designs

I'm pretty keen to get the work that Raissa has already done into master as this issue is blocking 4 other issues that we want to start on this week/next week. @clarkepaul are you okay with transferring the outstanding style touch-ups to a follow up issue?

Sure yup, sounds good.


Add hoursdiff date or datetime validation

[x] Add a validation on hoursdiff() function at c++ level where there can be only exactly two dates or two datetimes on hoursdiff() parameters. (https://github.com/niltonvasques/equations-parser/pull/23)
[x] Add tests
[x] Update Parsec version

@niltonvasques I already added before the tests to check the calculations!
They are in another PR https://github.com/niltonvasques/parsec/pull/32
I used the same tests of the User Story and put a lot more
  def test_datetime_functions
    parsec = Parsec::Parsec
    assert_equal(24, parsec.eval_equation('hoursdiff("2018-01-01", "2018-01-02")'))
    assert_equal(288, parsec.eval_equation('hoursdiff("2019-02-01", "2019-02-13")'))
    assert_equal(4, parsec.eval_equation('hoursdiff("2019-02-01T08:00", "2019-02-01T12:00")'))
    assert_equal(28, parsec.eval_equation('hoursdiff("2019-02-01T08:00", "2019-02-02T12:00")'))
    assert_equal(3.67, parsec.eval_equation('hoursdiff("2019-02-01T08:20", "2019-02-01T12:00")'))
    assert_equal(0, parsec.eval_equation('hoursdiff("2018-01-01", "2018-01-01")'))
    assert_equal(-20, parsec.eval_equation('hoursdiff("2018-01-02T08:00", "2018-01-01T12:00")'))
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff("2018-01-01", "INVALID2")') }
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff("INVALID1", "2018-01-01")') }
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff("INVALID1", "INVALID2")') }
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff(2, 3)') }
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff("2018-01-01", "2018-01-01T12:00")') }
    assert_raises(SyntaxError) { parsec.eval_equation('hoursdiff("2018-01-01T12:00", "2018-01-01")') }
  end


[Turbo] Add support for providing multiple mercure topics to turbo_stream_listen

Q
A

Bug fix?
no

New feature?
yes

Issues
Fix #213

License
MIT

Thank you @norkunas 👍
I guess there were no elegant way to avoid the value/values duo in the controller ?

Thank you @norkunas 👍
I guess there were no elegant way to avoid the value/values duo in the controller ?

Didn't think of a better way without breaking, later the former one could be deprecates

phpstan can be ignored..  are the failue 8.1 related or are they our usual flakky turbo failures ? 😅

are the failue 8.1 related or are they our usual flakky turbo failures ? 😅

some where related due to changed escape, fixed that with feature detection

This PR will definitely make several people happy. 😊

Including myself so I can use it in my project :D

Thanks @norkunas, I've just pushed a minor modification and rebased, I will merge your PR when checks become green.

Thank you @norkunas.

I've hesitated to do that because php 8.1 was declared as min version and phpstorm shown incompatibility


:bug: fix(radio checkbox): multiline solutions

Current Behavior
with multi-line labels in a select button (<bal-radio-group interface="select-button" ... ) the circle indicator is not shown in the middle. Also, in a group of radio buttons, the height should align with the highest element (i.e. expand the smaller ones).
Expected Behavior

[ ] on mobile the have 100% width
[ ] should allow multiline labels and wrap the text and the other option should have the same height and be centered

Steps to Reproduce

on option with a long label

Version
12
Browsers
No response
Device
No response
Code Reproduction URL
No response
Additional Information

As a workaround, we overwrite the styling in our app with the following attributes. (As a help)
::ng-deep {
  .package-selection {
    .bal-radio-checkbox {
      min-height: 4rem;
    }

    .bal-radio-checkbox__label::before, .bal-radio-checkbox__label::after {
      top: inherit;
    }
  }
}

created by @tk
Code of Conduct

[X] I agree to follow this project's Code of Conduct

this issue is already fixed.


Allow specifying a custom BUILD file

We use conda to distribute some non-python code in some projects and having the ability to optionally specify a BUILD file is super useful to us.

Hey, thanks for contributing. Can you provide some simple example of when this would be needed? So that I can understand the context better. I guess in your case you don't need a python_runtime at all, right?


rm sampling_spec_pb2.py from package/BUILD

At this time, it is mandatory remove this line to install the package.

@ecastillot Hi, you may need to complete your CLA before the PR can be mereged.

Thank you again for your contribution. Without the CLA, it was not possible for us to merge it into the repo. Meanwhile, it appears the problem has been fixed, based on @sibonli's advice on PR https://github.com/tensorflow/gnn/issues/15#issuecomment-1007060565. This change is no longer needed.


docs: minor corrections to the docker documentation

The documentation referenced "data volume containers", which were
superseded by named volume support in Docker several years ago.
There were to bind-mounting examples in the docs that are effectively
doing the same thing, but the description of the second was somewhat
erroneous.

Can you add the DCO?

Thanks!


Fix static typing errors

Let's make sure we are at zero-errors as soon as possible!
Remember, today's ⚠ is tomorrow's ❗, and next week's 🐛.

Previous logs
/Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:50:16 - error: Expression of type "(self: object) -> int" cannot be assigned to declared type "None"
    Type cannot be assigned to type "None" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:97:13 - error: No parameter named "model_name" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:124:36 - error: Argument of type "InstanceOf[CacheHandler] | None" cannot be assigned to parameter "cache_handler" of type "CacheHandler" in function "set_cache_handler"
    Type "InstanceOf[CacheHandler] | None" cannot be assigned to type "CacheHandler"
      Type "None" cannot be assigned to type "CacheHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:144:30 - error: "slice" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:149:29 - error: "tools" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:151:38 - error: "invoke" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:157:39 - error: Argument of type "list[InstanceOf[ToolsHandler] | None]" cannot be assigned to parameter "callbacks" of type "Callbacks" in function "__init__"
    Type "InstanceOf[ToolsHandler] | None" cannot be assigned to type "BaseCallbackHandler"
      Type "None" cannot be assigned to type "BaseCallbackHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:212:21 - error: Argument of type "Any | None" cannot be assigned to parameter "llm" of type "BaseLanguageModel[Unknown]" in function "__init__"
    Type "Any | None" cannot be assigned to type "BaseLanguageModel[Unknown]"
      Type "None" cannot be assigned to type "BaseLanguageModel[Unknown]" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:216:35 - error: Argument of type "I18N | None" cannot be assigned to parameter "i18n" of type "I18N" in function "__init__"
    Type "I18N | None" cannot be assigned to type "I18N"
      Type "None" cannot be assigned to type "I18N" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:218:35 - error: Argument of type "I18N | None" cannot be assigned to parameter "i18n" of type "I18N" in function "__init__"
    Type "I18N | None" cannot be assigned to type "I18N"
      Type "None" cannot be assigned to type "I18N" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:220:35 - error: Cannot access member "partial" for type "str"
    Member "partial" is unknown (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:226:25 - error: "bind" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:226:46 - error: "slice" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:232:31 - error: Argument of type "InstanceOf[ToolsHandler] | None" cannot be assigned to parameter "tools_handler" of type "ToolsHandler" in function "__init__"
    Type "InstanceOf[ToolsHandler] | None" cannot be assigned to type "ToolsHandler"
      Type "None" cannot be assigned to type "ToolsHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:233:23 - error: Argument of type "InstanceOf[CacheHandler] | None" cannot be assigned to parameter "cache" of type "CacheHandler" in function "__init__"
    Type "InstanceOf[CacheHandler] | None" cannot be assigned to type "CacheHandler"
      Type "None" cannot be assigned to type "CacheHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agent.py:234:22 - error: Argument of type "I18N | None" cannot be assigned to parameter "i18n" of type "I18N" in function "__init__"
    Type "I18N | None" cannot be assigned to type "I18N"
      Type "None" cannot be assigned to type "I18N" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:41:16 - error: Expression of type "(self: object) -> int" cannot be assigned to declared type "None"
    Type cannot be assigned to type "None" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:72:6 - error: Argument of type "_V2Validator" cannot be assigned to parameter "__f" of type "(type[_T@classmethod], **_P@classmethod) -> _R_co@classmethod" in function "__init__"
    Type "_V2Validator" cannot be assigned to type "(type[_T@classmethod], **_P@classmethod) -> _R_co@classmethod"
      Type "_V2ValidatorClsMethod" cannot be assigned to type "(type[_T@classmethod], **_P@classmethod) -> _R_co@classmethod" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:85:27 - error: Argument of type "AnyType@Json" cannot be assigned to parameter "s" of type "str | bytes | bytearray" in function "loads"
    Type "AnyType@Json" cannot be assigned to type "str | bytes | bytearray"
      "object*" is incompatible with "str"
      "object*" is incompatible with "bytes"
      "object*" is incompatible with "bytearray" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:116:28 - error: "get" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:116:61 - error: "get" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:110:41 - error: Argument of type "InstanceOf[CacheHandler] | None" cannot be assigned to parameter "cache_handler" of type "CacheHandler" in function "set_cache_handler"
    Type "InstanceOf[CacheHandler] | None" cannot be assigned to type "CacheHandler"
      Type "None" cannot be assigned to type "CacheHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:121:52 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:122:59 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:139:26 - error: Function with declared return type "str" must return value on all code paths
    Type "None" cannot be assigned to type "str" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:154:41 - error: "role" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:159:16 - error: Expression of type "str | None" cannot be assigned to return type "str"
    Type "str | None" cannot be assigned to type "str"
      Type "None" cannot be assigned to type "str" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:167:23 - error: "allow_delegation" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/crew.py:170:64 - error: "role" is not a known member of "None" (reportOptionalMemberAccess)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/task.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/task.py:14:16 - error: Expression of type "(self: object) -> int" cannot be assigned to declared type "None"
    Type cannot be assigned to type "None" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/executor.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/executor.py:112:37 - error: Cannot access member "action" for type "AgentFinish"
    Member "action" is unknown (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/executor.py:112:37 - error: Cannot access member "action" for type "List[AgentAction]"
    Member "action" is unknown (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/output_parser.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/output_parser.py:53:9 - warning: Expression value is unused (reportUnusedExpression)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/tools_handler.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/tools_handler.py:15:46 - error: Expression of type "None" cannot be assigned to parameter of type "CacheHandler"
    Type "None" cannot be assigned to type "CacheHandler" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/tools_handler.py:13:27 - error: Expression of type "None" cannot be assigned to declared type "CacheHandler"
    Type "None" cannot be assigned to type "CacheHandler" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/cache/cache_handler.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/agents/cache/cache_handler.py:9:13 - error: Expected type expression but received "(default: Any = PydanticUndefined, *, default_factory: (() -> Any) | None = None) -> Any" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py:23:39 - error: "tools" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py:30:39 - error: "tools" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py:49:30 - error: "errors" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py:52:30 - error: "errors" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/tools/agent_tools.py:61:30 - error: "errors" is not a known member of "None" (reportOptionalMemberAccess)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/i18n.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/i18n.py:45:20 - error: Object of type "None" is not subscriptable (reportOptionalSubscript)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/i18n.py:45:45 - error: Cannot access member "get" for type "str"
    Member "get" is unknown (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/prompts.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/prompts.py:28:41 - error: List expression not allowed in type annotation
    Use List[T] to indicate a list type or Union[T1, T2] to indicate a union type (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/prompts.py:28:41 - error: Expected type expression but received "list[type[str]]" (reportGeneralTypeIssues)
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/prompts.py:32:16 - error: Expression of type "PromptTemplate" cannot be assigned to return type "str"
    "PromptTemplate" is incompatible with "str" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/rpm_controller.py
  /Users/gvieira/Dev/crewai/crewAI/src/crewai/utilities/rpm_controller.py:44:27 - error: Cannot assign member "_timer" for type "RPMController"
    Type "None" cannot be assigned to type "Timer" (reportGeneralTypeIssues)
/Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:68:43 - error: "memory" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:69:40 - error: "memory" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:128:32 - error: "last_used_tool" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:136:32 - error: "last_used_tool" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:219:74 - error: "_iter_next_step" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/agent_test.py:245:72 - error: "_force_answer" is not a known member of "None" (reportOptionalMemberAccess)
/Users/gvieira/Dev/crewai/crewAI/tests/crew_test.py
  /Users/gvieira/Dev/crewai/crewAI/tests/crew_test.py:261:32 - error: "_cache" is not a known member of "None" (reportOptionalMemberAccess)
  /Users/gvieira/Dev/crewai/crewAI/tests/crew_test.py:263:32 - error: "_cache" is not a known member of "None" (reportOptionalMemberAccess)
/Users/gvieira/Dev/crewai/crewAI/tests/task_test.py
  /Users/gvieira/Dev/crewai/crewAI/tests/task_test.py:54:9 - error: No parameter named "allow_delegation" (reportGeneralTypeIssues)
55 errors, 1 warning, 0 informations

New logs
0 errors, 0 warnings, 0 informations

something wrong with the specs, running here in github, but this one should be good to go

something wrong with the specs, running here in github, but this one should be good to go

I want to fix tests before merging. All good! :)

@joaomdmoura the issue with tests was the incompatible langchain version. While we are running 0.1.0, the build was using 0.1.4, which breaks everything. I've fixed the version for now.

Oh boy we might need to update it then, merging this one 😎👉👉

@joaomdmoura we are ready to merge this. Don't wanna break your build, so do it when you feel like it. :)


Edit IDP preferred buttons to have depth and add border around them for visual clarity

Looks like this with 3 buttons and the border:


use hook to get local certificate and verify remote certificate

REF: https://github.com/DMTF/libspdm/blob/main/library/spdm_common_lib/spdm_common_lib_internal.h
Currently, we rely on local_cert_chain_provision to get local certificate and peer_root_cert_provision to verify remote certificate.
Another approach is to allow caller provide hook function to return local cert and return remove cert verification. It is a more flexible way to handle cert.

Other SSL libs use similar way:
openssl: SSL_CTX_set_verify().
mbedtls: mbedtls_ssl_conf_verify().
wolfssl: wolfSSL_CTX_set_verify().


Add support for hardsextube.com

youtube-dl --verbose http://www.hardsextube.com/video/1029401/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://www.hardsextube.com/video/1029401/']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2014.12.03
[debug] Python version 2.7.8 - Windows-7-6.1.7601-SP1
[debug] exe versions: rtmpdump 2.3
[debug] Proxy map: {}
[generic] 1029401: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 1029401: Downloading webpage
[generic] 1029401: Extracting information
ERROR: Unsupported URL: http://www.hardsextube.com/video/1029401/; please report this issue on https://yt-dl.org/bug
Make sure you are using the latest version; type  youtube-dl -U  to update.
Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "youtube_dl\extractor\generic.pyo", line 651, in _real_extract
File "youtube_dl\utils.pyo", line 1411, in parse_xml
File "xml\etree\ElementTree.pyo", line 1300, in XML
File "xml\etree\ElementTree.pyo", line 1642, in feed
File "xml\etree\ElementTree.pyo", line 1506, in _raiseerror
ParseError: mismatched tag: line 33, column 12
Traceback (most recent call last):
File "youtube_dl\YoutubeDL.pyo", line 553, in extract_info
File "youtube_dl\extractor\common.pyo", line 241, in extract
File "youtube_dl\extractor\generic.pyo", line 1044, in _real_extract
ExtractorError: Unsupported URL: http://www.hardsextube.com/video/1029401/; please report this issue on https:
//yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call
youtube-dl with the --verbose flag and include its complete output.

Currently working, but id is way too long, and no extension is extracted

I've added this in #10924.

Works fine with generic extractor.


abstract logic from evtloop

Note: you'll need to "reset" the continueOuter and continueEventLoop logic when you re-enter those loops, which I don't think you were doing before?

Great start. I like the overall intent of this PR!
I'd recommend the following changes:

The various methods, e.g. ProcessAccountCreated, take a *processBlockState as a parameter but then return it. Since it is a pointer value, this seems unnecessary, and should only really be done if you're planning to support .chained().operations().
Since these methods don't actually mutate the Indexer, they actually make more sense as methods on processBlockState rather than on Indexer.
The re-assignment back to local state after calling the methods, as well as the continuation of the outer/event loops should also happen in one place at the end of the switch. This will allow others to rework those methods in the future without worrying about whether they've correctly updated the state re-assignment at all the call sites.

Great start. I like the overall intent of this PR!
I'd recommend the following changes:

The various methods, e.g. ProcessAccountCreated, take a *processBlockState as a parameter but then return it. Since it is a pointer value, this seems unnecessary, and should only really be done if you're planning to support .chained().operations().
Since these methods don't actually mutate the Indexer, they actually make more sense as methods on processBlockState rather than on Indexer.
The re-assignment back to local state after calling the methods, as well as the continuation of the outer/event loops should also happen in one place at the end of the switch. This will allow others to rework those methods in the future without worrying about whether they've correctly updated the state re-assignment at all the call sites.

Implemented recommendations 1 & 3.

The methods don't mutate Indexer but do rely on one of Indexer's internal functions isTracked()


Feature Request: Configure PieChart data starting angle

I noticed the makePieSliceData method uses a private constant AngleCCWTop = -90f to setup the data.
For my usecase, I would like to configure the starting angle, as I actually only want to draw half a PieChart, starting from center left. It would be cool to be able to pass the "startAngle" or "anchorAngle" to the PieChart, then pass it through to the makePieSliceData method in order to allow for more flexible usage of the PieChart.
Might create a PR if I find time tomorrow, as this looks like a smaller change

solved and merged


Unexpected end of input

Hi lramsey,
First of all thanks for your hard work
Every time i try to launch product-demo using node index.js i get an error
begin analysis
undefined:1

SyntaxError: Unexpected end of input
    at Object.parse (native)
    at _buildRecVariables (/home/pi/product/product-recommender/node_modules/product-recommender/node/engine.js:31:22)
    at Socket.<anonymous> (/home/pi/product/product-recommender/node_modules/product-recommender/node/engine.js:24:5)
    at emitOne (events.js:95:20)
    at Socket.emit (events.js:182:7)
    at Pipe._onclose (net.js:475:12)

Hi Iramsey,
I am facing the same issue as well. Please look into this!


Add Kotlin

I just tried this on a different machine, albeit another Mac. Other than "please pick a JDK" it worked out of the box.

If this is okay, then I'll also create a sample solution branch

looks fine, I'll trust that it loads for now, hope to try it out next week (and run it myself). Yes would love to see the solution branch.


Horizontal scroll bug

Do you want to request a feature or report a bug?
A bug.
What is the current behavior?
If the color input has positions about right side. Browser displays horizontal scroll after initial pickr. If I open and close pickr the horizontal scroll leaves. Looks like the problem is pcr-app don't has display: none; property

If the current behavior is a bug, please provide the steps to reproduce.
Move input to the right side.
What is the expected behavior?
Without the horizontal scroll.
Your environment:
Pickr-version: 0.3.1
Browser-version:  Firefox 63.0.3
Operating-system:  Windows 7 64

I've reproduced it and (hopefully) fixed it here 2c7aeef396ba9194165b9fd0f4f5c09e517ada14 :)

I confirm, the bug is fixed. Thank you. Your lib is awesome.


[5.4] Nullable Validation Rules & required_...

If a field has a required_with validation and is present the other field should not be nullable the other field, should not be invalid a null?
'n_brothers'=> 'required_with:brothers_place_of|numeric|nullable',
'brothers_place_of'=> 'required_with:n_brothers|numeric|nullable',

How to validate this?

I don't understand :) Can you share sample data that should pass the validation?

The field type_of_food should be null  only if  lunchor meal or snack are false.
'lunch'=> 'required|boolean',
'meal'=> 'required|boolean',
'snack'=> 'required|boolean',
'type_of_food'=> 'in:crushed,whole|required_if:lunch,1|required_if:meal,1|required_if:snack,1|nullable',

My English is not very good. Sorry

That looks to me like a complex rule that you can use sometimes() for, check http://themsaid.com/laravel-advanced-validation-conditionally-adding-rules-20170110/.

But, if the rule required_if is activated,  the value null should not be valid.
required
The field under validation must be present in the input data and not empty. A field is considered "empty" if one of the following conditions are true:

The value is null.

required_ ...  should works the same way.

I have the same problem and can't find a way to setup proper rules.
I have a dropdown where user can select from different options and a textbox where an url can be entered. The textbox value is only required if 'url' option is selected in the dropdown, but for any other selection textbox's value is not required and will have null as value.
I have setup the following rules:
'dropdown' => 'required',
'textbox' => 'required_if:dropdown,url|url',
If dropdown value is different then 'url' value, the textbox's url validation rule is triggered and returns a failed result.
I have tried sometimes and nullable rules on textbox without success.
If I add nullable rule to textbox then the required_if rule doesn't validate when dropdown's value is 'url' and textbox's value is null.
I'm thinking of creating a new rule for url that doesn't validate null or empty string. I did this with the exists rule (same problem), I wrote my own exists_or_null rule for similar scenario but I don't think this is a good approach to replace current rules just to handle null values.
Is there a better way or does anybody have a suggestion for rules setup?

            'order_product_id' => 'nullable|uuid',
            'description'      => 'required_without:order_product_id|string',

order_product_id === 1
description === null
"description" => array:1 [
    0 => "validation.string"
  ]

This is ridiculous bug!

I'm finding this also in 5.4. Adding nullable negates the required_with rule. In my use case, it's when dealing with array fields:
$rules = [
    'email_address.2' => ['email'],
    'required_with_email_address.2' => ['nullable', 'required_with:email_address.2']
];

Submitting a value in email_address[2] field and leaving required_with_email_address[2] blank does not trigger the required_with error for me.


[Feature] Output logging in rendered output

Is your feature request related to a problem? Please describe.
I am using markdown_exec to have examples which are also run and show their output. Part of this would be nice to display the logging output too.
Describe the solution you'd like
An annotation similar to exec=True except you specify the logging level, i.e. logs=INFO.
Describe alternatives you've considered
I previously injected hidden code into the code blocks that would take the buffer that you overwrite the print builtin with and set this to the outstream of rich.print. I could do something similar for logging but I would prefer not to rely on private functionality.
I recently did so with sessions, injecting in session["__name__"] = "__main__" to run the example script's __main__ block, as well as try solve issues to pickling that occur when using markdown exec but to no avail. A recent PR changed the name of the global variable so it was a good lesson not to rely on the private functionality.
Additional context
The logging from the running examples actually gets streamed to the session running mkdocs --serve which pollutes the build output. It would be good to redirect this anywho.

Hey @eddiebergman, thanks for the feature request.
How do your scripts/examples configure logging? I'm not against a logs option which defaults to None and that, when provided a log level, redirect all logs to our buffer, keeping only the ones with a level greater or equal the specified one.

Lack of info, closing for now.


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1257

Questions ?
Please refer to the Backport tool documentation


For iPython an addition key 'ipython_canary_method_should_not_exist' is added.

Under iPython (Python 2.7 & addict 1.1.0), if we have the following code:
from addict import Dict
d = Dict()
print(d.keys())

We get the following output:
['_ipython_canary_method_should_not_exist_']

Hi @chuanconggao - thanks for reporting this.
I've had some issues with Jupyter / IPython before - I'm not entirely sure how to deal with them. Here's the piece of code in IPython that causes the behavior above. And in #26 you can see an earlier discussion.


2.3.0 and 2.3.1 fail to run without typing_extensions on >=3.10

These two releases fail to run in python >=3.10 environments where typing_extensions hasn't been installed separately with an error like the following:
nox > Running flake8
Traceback (most recent call last):
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/plugins/finder.py", line 296, in _load_plugin
    obj = plugin.entry_point.load()
  File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/importlib/metadata/__init__.py", line [17](https://github.com/FasterSpeeding/Reinhard/actions/runs/5043870059/jobs/9046207679?pr=261#step:7:18)1, in load
    module = import_module(match.group('module'))
  File "/opt/hostedtoolcache/Python/3.10.11/x64/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/tryceratops/flake_plugin.py", line 6, in <module>
    from tryceratops.files.discovery import load_config
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/tryceratops/files/__init__.py", line 1, in <module>
    from .discovery import FileDiscovery, load_config
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/tryceratops/files/discovery.py", line 9, in <module>
    from tryceratops.types import ParsedFileType, PyprojectConfig
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/tryceratops/types.py", line 3, in <module>
    import typing_extensions as te
ModuleNotFoundError: No module named 'typing_extensions'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/bin/pflake8", line 8, in <module>
    sys.exit(main())
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/main/cli.py", line [22](https://github.com/FasterSpeeding/Reinhard/actions/runs/5043870059/jobs/9046207679?pr=261#step:7:23), in main
    app.run(argv)
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 336, in run
    self._run(argv)
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 3[24](https://github.com/FasterSpeeding/Reinhard/actions/runs/5043870059/jobs/9046207679?pr=261#step:7:25), in _run
    self.initialize(argv)
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 302, in initialize
    self.find_plugins(
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/main/application.py", line 1[28](https://github.com/FasterSpeeding/Reinhard/actions/runs/5043870059/jobs/9046207679?pr=261#step:7:29), in find_plugins
    self.plugins = finder.load_plugins(raw, opts)
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/plugins/finder.py", line 370, in load_plugins
    return _classify_plugins(_import_plugins(plugins, opts), opts)
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/plugins/finder.py", line 312, in _import_plugins
    return [_load_plugin(p) for p in plugins]
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/plugins/finder.py", line 312, in <listcomp>
    return [_load_plugin(p) for p in plugins]
  File "/home/runner/work/Reinhard/Reinhard/.nox/flake8/lib/python3.10/site-packages/flake8/plugins/finder.py", line [29](https://github.com/FasterSpeeding/Reinhard/actions/runs/5043870059/jobs/9046207679?pr=261#step:7:30)8, in _load_plugin
    raise FailedToLoadPlugin(plugin.package, e)
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "tryceratops" due to No module named 'typing_extensions'.

Seems like the dep constraint (which only includes typing_extensions for python = "<3.10") and the actual code at https://github.com/guilatrova/tryceratops/blob/52f49300ddf1844e7d754b587581efb144ddd1ae/src/tryceratops/types.py#L3 (which expects typing_extensions to always be present) aren't matching up here.

Thanks for pointing it out. I believe the issue is fixed now.


How to get html  to be valid html with multiple child nodes?

I have some code in my web server.js that looks like this:
import webpageServer from 'react-isomorphic-render/page-server';
import common from '../client/react-isomorphic-render';

export default function (parameters) {
  const server = webpageServer({
    html:
    {
      // Will be inserted into server rendered webpage <head/>
      // (this `head()` function is optional and is not required)
      // (its gonna work with or without this `head()` parameter)
      head: (url) => {
        const script = devtools({ ...parameters, entry: 'main' });
        return (
          <div>
            {__DEVELOPMENT__ && (
              <script dangerouslySetInnerHTML={{ __html: script }} />
            )}
            <script src="https://use.fontawesome.com/0d4417303a.js" />
          </div>
        );
      }
    },
  },
  common);

I get a complaint that  is not a valid child of . Any idea how to work around that? Maybe the head function could return an array of nodes to be added to ?

git comments don't like arrow-brackets < at the moment, what was your error again?

@adailey14 If you look here:
https://github.com/halt-hammerzeit/react-isomorphic-render#miscellaneous-webpage-rendering-server-options
You'll notice that it says:
    head: (url) => React element or an array of React elements

That's one thing.
The other thing is that the <script/> tag is populated automatically from assets inside <body/>.
If you're populating your <script/> in head without async then you're "breaking the web" because you're putting code before content.

Aha thank you very much, sorry I missed that.


[benchmarks] Add benchmarks for appending UTF8 String views to an array

To support testing of a fast path for ASCII from #7262

@swift-ci Please smoke test


cargo-verify tutorial: rvt-klee.bc not found in docker

I'm trying to work through the tutorial to use cargo verify here, with the Docker instructions. I'm able to use cargo test for proptest as expected, but the verify/KLEE backend fails.
I'm running Ubuntu 20.04, Docker version 20.10.7, build 20.10.7-0ubuntu1~20.04.1
Command:
cargo-verify --backend=klee --tests --verbose

Expected result:
Running 1 test(s)
test multiply ... ERROR

test result: ERROR. 0 passed; 1 failed
VERIFICATION_RESULT: ERROR

Actual result:
Checking verify
  Building verify for verification
STDERR:     Finished dev [unoptimized + debuginfo] target(s) in 0.01s
ERROR - FAILED: 'llvm-link-10' terminated with exit code 1.

End of trace with -vvvvvv:
INFO - Running 'llvm-link-10' in '.' with command:
llvm-link-10 -o /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.link.bc /home/rust-verification-tools/runtime/rvt-klee.bc /home/rust-verification-tools/simd_emulation/simd_emulation.bc /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.bc
STDERR: llvm-link-10: /home/rust-verification-tools/runtime/rvt-klee.bc: error: Could not open input file: No such file or directory
STDERR: llvm-link-10: error:  loading file '/home/rust-verification-tools/runtime/rvt-klee.bc'
ERROR - FAILED: 'llvm-link-10' terminated with exit code 1.

Full reproduction:
> cat Cargo.toml
[package]
name = "verify"
version = "0.1.0"
authors = ["ubuntu"]
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]

[target.'cfg(verify)'.dependencies]
propverify = { path="/home/rust-verification-tools/propverify" }

[target.'cfg(not(verify))'.dependencies]
proptest = { version = "*" }

[features]
verifier-klee = ["propverify/verifier-klee"]
verifier-crux = ["propverify/verifier-crux"]
verifier-seahorn = ["propverify/verifier-seahorn"]
> cat src/main.rs
#[cfg(not(verify))]
use proptest::prelude::*;
#[cfg(verify)]
use propverify::prelude::*;

proptest! {
    #[test]
    fn multiply(a in 1..=1000u32, b in 1..=1000u32) {
        let r = a*b;
        prop_assert!(1 <= r && r < 1000000);
    }
}
> cargo test
   Compiling libc v0.2.102
   Compiling cfg-if v1.0.0
   Compiling ppv-lite86 v0.2.10
   Compiling autocfg v1.0.1
   Compiling remove_dir_all v0.5.3
   Compiling fnv v1.0.7
   Compiling bit-vec v0.6.3
   Compiling quick-error v1.2.3
   Compiling quick-error v2.0.1
   Compiling bitflags v1.3.2
   Compiling byteorder v1.4.3
   Compiling regex-syntax v0.6.25
   Compiling lazy_static v1.4.0
   Compiling bit-set v0.5.2
   Compiling num-traits v0.2.14
   Compiling getrandom v0.2.3
   Compiling wait-timeout v0.2.0
   Compiling rand_core v0.6.3
   Compiling rand_chacha v0.3.1
   Compiling rand_xorshift v0.3.0
   Compiling rand v0.8.4
   Compiling tempfile v3.2.0
   Compiling rusty-fork v0.3.0
   Compiling proptest v1.0.0
   Compiling verify v0.1.0 (/home/ubuntu/rust-verification-tools/verify)
    Finished test [unoptimized + debuginfo] target(s) in 10.61s
     Running target/debug/deps/verify-ac0d8570681ea509

running 1 test
test multiply ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

> cargo clean
> cargo-verify --backend=klee --tests --verbose
Checking verify
  Building verify for verification
STDERR:    Compiling verification-annotations v0.1.0 (/home/rust-verification-tools/verification-annotations)
STDERR:    Compiling propverify v0.1.0 (/home/rust-verification-tools/propverify)
STDERR:    Compiling verify v0.1.0 (/home/ubuntu/rust-verification-tools/verify)
STDERR:     Finished dev [unoptimized + debuginfo] target(s) in 8.07s
ERROR - FAILED: 'llvm-link-10' terminated with exit code 1.

Apologies if I set something up incorrectly, and thanks!

I think that there could be two things going on here.

You built the docker image using the experimental 'LLVM11=yes' flag. This is not fully working at the moment so it is not recommended.

You are running cargo-verify directly from your host machine instead of running it inside docker using either "docker run cargo-verify ..." or by opening a new terminal and creating an interactive docker shell by running "docker run".

Thanks for getting back to me!
I am running docker/build with no flags, and looking at the output it seems like LLVM11 is not set:
rust-verification-tools (main) $ pwd
/home/ubuntu/rust-verification-tools
rust-verification-tools (main) $ docker/build &> docker-log.txt
rust-verification-tools (main) $ cat docker-log.txt | grep llvm-link-10
llvm-link-10  build_klee/atexit.o  build_klee/memrchr.o  build_klee/posix_memalign.o  build_klee/pthread.o -o rvt-klee.bc
llvm-link-10  build_seahorn/atexit.o  build_seahorn/memrchr.o  build_seahorn/posix_memalign.o  build_seahorn/pthread.o -o rvt-seahorn.bc
llvm-link-10  build_smack/atexit.o  build_smack/memrchr.o  build_smack/posix_memalign.o  build_smack/pthread.o -o rvt-smack.bc
llvm-link-10  build/lib.bc -o simd_emulation.bc
rust-verification-tools (main) $ cat docker-log.txt | grep llvm-link-11
rust-verification-tools (main) $ cat docker-log.txt | grep LLVM11
To build LLVM11 version, use env LLVM11=yes docker/build

And here's my entering the docker interactive shell (which I was in for all the >  commands in the full trace in the original issue description):
rust-verification-tools (main) $ docker/run
Running docker with sudo because you don't have write access to the docker socket.
Add yourself to the docker group to avoid the need for this in future.
ubuntu@ip-172-31-43-236:~/rust-verification-tools$ cd verify
ubuntu@ip-172-31-43-236:~/rust-verification-tools/verify$ cargo-verify --backend=klee --tests -vvvvv &> run-log.txt
ubuntu@ip-172-31-43-236:~/rust-verification-tools/verify$ cat run-log.txt | grep llvm-link-10
INFO - Running 'llvm-link-10' in '.' with command:
llvm-link-10 -o /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.link.bc /home/rust-verification-tools/runtime/rvt-klee.bc /home/rust-verification-tools/simd_emulation/simd_emulation.bc /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.bc
STDERR: llvm-link-10: /home/rust-verification-tools/runtime/rvt-klee.bc: error: Could not open input file: No such file or directory
STDERR: llvm-link-10: error:  loading file '/home/rust-verification-tools/runtime/rvt-klee.bc'
ERROR - FAILED: 'llvm-link-10' terminated with exit code 1.
ubuntu@ip-172-31-43-236:~/rust-verification-tools/verify$ tail -10 run-log.txt
STDOUT: ---------------- d str.3
STDOUT: ---------------- d str.3.401
STDOUT: ---------------- d str.4
    Found 1 functions
  Linking /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.bc, /home/rust-verification-tools/runtime/rvt-klee.bc, /home/rust-verification-tools/simd_emulation/simd_emulation.bc and [] to produce /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.link.bc
INFO - Running 'llvm-link-10' in '.' with command:
llvm-link-10 -o /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.link.bc /home/rust-verification-tools/runtime/rvt-klee.bc /home/rust-verification-tools/simd_emulation/simd_emulation.bc /home/ubuntu/rust-verification-tools/verify/target/x86_64-unknown-linux-gnu/debug/deps/verify-238da9e126f6d636.bc
STDERR: llvm-link-10: /home/rust-verification-tools/runtime/rvt-klee.bc: error: Could not open input file: No such file or directory
STDERR: llvm-link-10: error:  loading file '/home/rust-verification-tools/runtime/rvt-klee.bc'
ERROR - FAILED: 'llvm-link-10' terminated with exit code 1.

Ah, I was completely misreading the error messages.
I was fixating on llvm-link-10 but the real problem was runtime/rvt-klee.bc.
The fix is to run "$RVT_DIR/docker/init" which builds the missing .bc file.
This should have been done by the docker/build script - but apparently that is not working and I should do a better job of testing from a clean source tree.

$RVT_DIR/docker/init worked for me, thanks so much!

Hurray!


pickle.UnpicklingError: invalid load key, 'v'.

When trying to run inference on my loras and those provided from hf (i.e. after running this command:
python MotionDirector_inference_multi.py --model /workspace/nina-home/MotionDirector/models/zeroscope_v2_576w/  --prompt "A car is running on the road." --spatial_path_folder /workspace/nina-home/MotionDirector/outputs/ready/image_animation/train_2023-12-26T14-37-16/checkpoint-300/spatial/lora/ --temporal_path_folder /workspace/nina-home/MotionDirector/outputs/ready/image_animation/train_2023-12-26T13-08-20/checkpoint-300/temporal/lora/ --noise_prior 0.5 --seed 5057764

I get this error:
[2024-03-01 16:38:56,120] [INFO] [real_accelerator.py:133:get_accelerator] Setting ds_accelerator to cuda (auto detect)
Initializing the conversion map
Traceback (most recent call last):
  File "MotionDirector_inference_multi.py", line 287, in <module>
    video_frames = inference(
  File "/workspace/nina-home/.conda/envs/motiondirector/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "MotionDirector_inference_multi.py", line 174, in inference
    pipe = initialize_pipeline(model, device, xformers, sdp, spatial_lora_path, temporal_lora_path, lora_rank,
  File "MotionDirector_inference_multi.py", line 65, in initialize_pipeline
    unet_lora_params, unet_negation = lora_manager_spatial.add_lora_to_model(
  File "/workspace/nina-home/MotionDirector/utils/lora_handler.py", line 214, in add_lora_to_model
    params, negation, is_injection_hybrid = self.do_lora_injection(
  File "/workspace/nina-home/MotionDirector/utils/lora_handler.py", line 183, in do_lora_injection
    params, negation = self.lora_injector(**injector_args)  # inject_trainable_lora_extended
  File "/workspace/nina-home/MotionDirector/utils/lora.py", line 471, in inject_trainable_lora_extended
    loras = torch.load(loras)
  File "/workspace/nina-home/.conda/envs/motiondirector/lib/python3.8/site-packages/torch/serialization.py", line 815, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/workspace/nina-home/.conda/envs/motiondirector/lib/python3.8/site-packages/torch/serialization.py", line 1033, in _legacy_load
    magic_number = pickle_module.load(f, **pickle_load_args)
_pickle.UnpicklingError: invalid load key, 'v'.

Help is greatly appreciated:)

Have you installed the correct version of the packages indicated in the requirement.txt?


wiki.vg references

As the site wiki.vg is soon ("November 30th") to be sunset, references should be replaced with their own docs or redirects to a another source.
wiki.vg sunsetting post:
https://tkte.ch/articles/2024/11/11/sunsetting.html
References in the docs (at the time of writing, only 3 references, and 2 distinct ones):
https://github.com/search?q=repo%3APaperMC%2Fdocs+wiki.vg&type=code
At the time of writing, it seems possible that wiki.vg will be merged into minecraft.wiki, according to this page, which might serve as alternative:
https://minecraft.wiki/index.php?title=Minecraft_Wiki:Forum/Wiki.vg_merge

I think we should wait until we know more. Replacing it now until Minecraft.wiki merged wiki.vg seems like a unnecessary effort I would say.

Yeah, absolutely, it shouldn't be rushed, I just wanted to raise awareness because the information didn't seem that widespread.


Invoices API - pay & cancel invoice is not working

When using the 'pay' or 'cancel' invoice API get the following response:
Raw error for the API
socket hang up
Pay invoice error:
[04:31:03.996] POST /invoices/pay/invoice HTTP/1.1
[04:31:03.996] Content-Type: application/json
[04:31:03.996] Authorization: Basic
[04:31:03.996] x-bubble-depth: 1
[04:31:03.996] host: private.nexus.io:7080
[04:31:03.996] accept-encoding: gzip, deflate
[04:31:03.996] content-length: 268
[04:31:03.996] Connection: keep-alive
[04:31:03.996] ERROR: Thread : Data Connection: [json.exception.type_error.302] type must be string, but is null
Cancel invoice error:
[04:29:44.528] POST /invoices/cancel/invoice HTTP/1.1
[04:29:44.528] Content-Type: application/json
[04:29:44.528] Authorization: Basic
[04:29:44.528] x-bubble-depth: 1
[04:29:44.528] host: private.nexus.io:7080
[04:29:44.528] accept-encoding: gzip, deflate
[04:29:44.528] content-length: 189
[04:29:44.528] Connection: keep-alive
[04:29:44.528] ERROR: Thread : Data Connection: [json.exception.parse_error.101] parse error at line 6, column 1: syntax error while parsing object key - unexpected '}'; expected string literal

Fixed with commit fb0faf50533afc342be8997923dfee015cbc0c8c and 3c0546d30b5c403348248756b0fef682876fc775


centos 7

Can use modsec and haproxy config on centos 7 bare metal server? i need security config for sql injection and placed on haproxy

This will be a lot easier if you can use a container runtime to run this wrapper, otherwise you'd need to reproduce the same steps of the Dockerfile to compile everything yourself in order to generate a binary compatible with your operating system, since we don't deliver precompiled packages.


Update the regression test logic

This PR closes out #326 by:

Upgrading to the latest NCRegressionTests, which is now more strict
Use the oldest reference dataset with a matching reference counter

I just recently cleared the julia depot path, so this should actually upgrade to the latest versions.

I think I need to break this down, there's too much going on. I opened #370 to first get a handle on upgrading packages in a controlled way.

Alright, I think this is working. I do need to update the MSE tables in order for CI to pass because we'll be comparing with an older (but fixed) dataset until we increment the reference counter.

bors r+


first local test run requires npm run build

A fresh clone of this repo requires npm run build to be run before all the tests will pass. This is an easy thing to forget because you only have to run it once and then npm test continues to work without a fresh build.
One way we can work around this is by adding a pretest script to package.json with a value of npm run build. That way the build will always run first when anyone runs npm test.
That would solve the immediate problem for first-time contributors, but it would also incur a performance penalty every time you run the tests locally, as the build currently takes ~4 seconds to run on my superfast computer. Maybe 4s doesn't matter much in the grand scheme of things... but it would be nice to not incur that cost.
🤔 What are some ways we can solve this?
cc @github/docs-engineering @jeffmcaffer

For the short term, we've also clarified this in the contributing/development documentation: https://github.com/github/docs/commit/054f9abc737948a364af8c7f9e0572e120d8717f

@zeke Why not use the postinstall script in the package.json to run the build script. It only runs once after npm install.
cc: @JamesMGreene @janiceilene

Good idea @FarazzShaikh! That might work. Would you care to give it a try and open a PR if it does?

Will do later today! Could you assign this issue to me so it doesn’t slip my mind? Thank you!

This does indeed work. Adding the script "postinstall": "npm run build" to package.json does build once after installations. However, one test (tests/routing/developer-site-redirects.js) fails when running npm run test but i don't think it's related to this.
Also, you might have to change your Actions workflows as npm ci also calls postinstall thus making the npm run build commands redundant.
@zeke if you're fine with this, I can make the changes to the workflows and the package.json then PR it in.

@FarazzShaikh We're definitely open to that! FWIW, your PR will receive a message saying we don't accept contributions to workflow files but we're willing to make exceptions for small change sets like what you mentoned. 👍🏻
One suggestion, though, would be to use the prepare script instead of postinstall as that more closely aligns with our needs (building/transpiling code).

Sounds good, I’ll make the required changes with prepare And PR it in

We've decided not to implement this behavior for the time being.
For more of an explanation: https://github.com/github/docs/pull/7713#issuecomment-889433189


Dagster failing with source materializations daily

Which area(s) are affected? (leave empty if unsure)
No response
To Reproduce
See the dagster logs
Describe the Bug
Not sure what's happening but materialization schedule is failing but manual calls seem to work? It worked for base. I'll check for the others.
Expected Behavior
Should work

Closed with #2155 #2157 #2160 #2165 #2167


Bug: ACL Packager ignores "Package ACL handling" setting

I believe the ACL Packager is failing to respect the "Package ACL handling" setting.
On this line, the ImportMode should be set based on the FilterSet configuration, but it seems as though the FilterSet never gets import mode set, so it always uses the default REPLACE:
https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/9350d397ecc3269fbcc0660ab98dd640388ff649/bundle/src/main/java/com/adobe/acs/commons/packaging/impl/PackageHelperImpl.java#L334

I still believe this is an issue that deserves attention.  It should not be closed.


[#1766] Increase contrast of input labels on light theme

#1766
Disabled input contrast ratio on light theme was not high enough. This fix changes the text color of disabled inputs and labels in light mode. (Dark mode and high contrast already pass)
See below:

Got a verbal okay on this from @DesignPolice, but lmk if anyone wants to discuss this. At the moment the list of approved greys for Emulator does not have a large selection of text colors that will work with a11y on white.

Thanks, Corina - I think this will be just fine without having to change lots of other moving parts. Appreciate all your help.

Coverage remained the same at 65.564% when pulling 2a5e8f83eba9511bd3d9ecc5cba12faae672bcf4 on corinagum/1766 into 25a136edb35c7f17e5323b8b345146c34fb78ac4 on master.


Deploy Record Linkage Helm through Terraform

Deploys the record linkage Helm chart (of https://cdcgov.github.io/phdi-charts/) to the Kubernetes cluster already created in Azure.
This is a first pass just for record linkage, and will likely be updated later. It may make sense to store some variables, like the image tag, in a separate configuration file.

@DanielPaseltiner - Nick, Gordon and I paired while creating this PR, so I would appreciate a review from someone who has a little more distance 😄 I left some comments on the purpose of new resources and flags, but let me know if you have questions.

@DanielPaseltiner - Nick, Gordon and I paired while creating this PR, so I would appreciate a review from someone who has a little more distance 😄 I left some comments on the purpose of new resources and flags, but let me know if you have questions.

@emmastephenson just went through and left some comments. Everything except that naming convention LGTM. I might just be missing something there though.

@DanielPaseltiner - Nick, Gordon and I paired while creating this PR, so I would appreciate a review from someone who has a little more distance 😄 I left some comments on the purpose of new resources and flags, but let me know if you have questions.

@emmastephenson just went through and left some comments. Everything except that naming convention LGTM. I might just be missing something there though.

@DanPaseltiner Thank you for the through review! The release name we define in Terraform will combine with the names for each Kubernetes resource as defined in the Helm templates. On a deployment to Azure, we'll end up with {our-Terraform-defined-name}-record-linkage-service and {our-Terraform-defined-name}-record-linkage (should maybe change that to record-linkage-deployment on the Helm chart).


Expand on documentation for the current implementation of LIFModel

Run through the current implementation of the LIFModel, describing:
- General form
- Class Structure

Obsolete.


Source folder restructure

A lot of the files that reside in the root src folder should probably be organized better (state.rs, game_manager.rs, level_up.rs etc.)

I'm probably going to add to this problem when i start working on combat controller here soon

I'm probably going to add to this problem when i start working on combat controller here soon

That one is probably handled easily enough by putting your new stuff in a combat folder or similar :)

I'm probably going to add to this problem when i start working on combat controller here soon

That one is probably handled easily enough by putting your new stuff in a combat folder or similar :)

then feel free to move whatever you'd like!


Farming Station and Natura Cotton Crops causes server crash

Issue Description:
Server crashes when Farming Station harvests Natura Cotton seeds on SF3 1.10.2
What happens:
The server will crash when the Farming Station tries to harvest a Natura cotton seed. Upon logging back in, the Farming Station is turned into a chest.
What you expected to happen:
Allow the farming station to harvest Natura cotton seeds with no problems.
Steps to reproduce:

Create a farm of Natura cotton seeds
Place a farming station with power
Input a diamond hoe

Affected Versions (Do not use "latest"):

EnderIO: 1.10.2-3.1.193
EnderCore: 1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge: <IP_ADDRESS>2

Your most recent log file where the issue was present:
pastebin link here

there is sponge in this issue, try without sponge and report it to them if removeing sponge helps this issue probably