Exit code > 0 on gh contrib

Describe the bug
Exit code > 0 on gh contrib but 0 if calling with -D flag
To Reproduce
Steps to reproduce the behavior:

Exec gh contrib; echo $?, see 1

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: macos
Terminal wezterm+tmux
Font: JetBrains Mono Nerd Font
Version

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1, android13]
Terminal [e.g. termux, gnome-terminal, kitty]
Version

On branch main
Your branch is up to date with 'origin/main'.

Thanks for quick response!
Works awesome!


Mining Fees in Header Stuck at 116 sat/vB

Description
The approximate mining fees in the header carousel appears to be stuck at 116 sat/vB
Steps to Reproduce

View page header
Click on carousel until you land on approximate fees

Expected behavior
The mining fees used to follow reality pretty well. But for some reason, it's stuck now.
Screenshots

Logs
N/A
Environment:
N/A
Additional context
Discussed here and here
@ekzyis suggested maybe switching to use mempool.space's API instead of whatever we're doing (querying our LND node, I believe?)
It remains to be determined if the issue is with LND, or something in our app layer itself.

OK well now that I filed a bug, it shows as 43 sat/vB now... Probably still warrants an investigation to see what went wrong, if it may become a persistent issue, etc.

I think our node is just bad at estimating fees. mempool.space seems to be running a custom mempool config since they can show mempools larger than 300MB which is the default.

We are currently getting these fees from lnd. I wonder if there's something we can config to make the estimate tighter.

I might take this on if no one else is?

Go for it! Using something like mempool.space would be okay by me

PR submitted. Apologies if I've not followed any particular etiquette. I've just forked the repo and created the PR back into your master branch. Hope that's the right approach. I have requested to join dev chat.


[FEATURE] Render citations in a readable manner

It would be nice to render \citep, \cite, \citet in a readable manner.
\citep{bun23} -->  (Bunker et al. 2023)
This requires parsing the bibliography, which is very challenging:

bibliography can be a bib file or a part of the document. It can be multiple bib files.
We do not want to compile the source; this creates another suite of issues
(Parsing .bib files should not be too difficult)

A preliminary solution could be to just replace \citex to display nicely.

A preliminary version of citations was implemented in https://github.com/mfouesneau/arxiv_on_deck_2/blob/main/arxiv_on_deck_2/latex_bib.py
It currently works only with .bib references in the tex (i.e. not with \bibitem)


Dialog text margin/padding

See screenshot below:

powerful browser but some UI details r not perfect🍦


Full screen dismiss error

after dismiss, pressing the screen does not work

I encountered this error as well where I had a view controller which has an ImageSlideShow in it being presented on top of another view controller.
detailPage = DetailedEntryViewController() // this vc has an ImageSlideShow subview self.present(detailPage, animated: true)
I'm not sure why it breaks, but a temporary fix I found is to make sure the presented view controller is set to take up the entire screen using detailPage.modalPresentationStyle = .fullScreen.
Hope that helps.

A better solution would probably be this.

same here, I have the same problem. I already tried with the modalpresentation but not work.

I encountered this error as well where I had a view controller which has an ImageSlideShow in it being presented on top of another view controller.
detailPage = DetailedEntryViewController() // this vc has an ImageSlideShow subview
self.present(detailPage, animated: true)

I'm not sure why it breaks, but a temporary fix I found is to make sure the presented view controller is set to take up the entire screen using detailPage.modalPresentationStyle = .fullScreen.
Hope that helps.

Thanks a lot, your solution helped me! :)

My solution
in viewDidLoad {
let gestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(didTapServiceImage))
serviceImagesSlides.addGestureRecognizer(gestureRecognizer)
}
then
@objc func didTapServiceImage() {
let imagesViewController = FullScreenSlideshowViewController()
imagesViewController.inputs = inputsImage
imagesViewController.initialPage = serviceImagesSlides.currentPage
imagesViewController.pageSelected = { self.serviceImagesSlides.setCurrentPage($0, animated: true) }
self.present(imagesViewController, animated: true, completion: nil)
}
one problem: you cannot close the screen with a gesture down

M solution that supports dismiss up and down on a swipe
class ServiceImageFullScreenViewController: FullScreenSlideshowViewController {
var panGestureRecognizer: UIPanGestureRecognizer?
var viewTranslation = CGPoint(x: 0, y: 0)
override func viewDidLoad() {
    super.viewDidLoad()
    panGestureRecognizer = UIPanGestureRecognizer(target: self, action: #selector(panGestureAction))
    view.addGestureRecognizer(panGestureRecognizer!)
    closeButton.setImage(UIImage(named: "close"), for: .normal)
}

override func viewDidLayoutSubviews() {
    super.viewDidLayoutSubviews()
}

@objc func panGestureAction(recognizer: UIPanGestureRecognizer) {
    switch recognizer.state {
    case .changed:
        viewTranslation = recognizer.translation(in: view)
        UIView.animate(withDuration: 0.5, delay: 0, usingSpringWithDamping: 0.7, initialSpringVelocity: 1, options: .curveEaseOut, animations: {
            self.view.transform = CGAffineTransform(translationX: 0, y: self.viewTranslation.y)
        })

    case .ended:
        if viewTranslation.y < -200 {
            dismiss(animated: true, completion: nil)
        }
        if viewTranslation.y < 200 {
            UIView.animate(withDuration: 0.5, delay: 0, usingSpringWithDamping: 0.7, initialSpringVelocity: 1, options: .curveEaseOut, animations: {
                self.view.transform = .identity
            })
        } else {
            dismiss(animated: true, completion: nil)
        }

    default:
        break
    }
}

}
example
let imageViewController = ServiceImageFullScreenViewController()
imageViewController.modalPresentationStyle = .overCurrentContext                imageViewController.inputs = self.inputImages
self.present(imageViewController, animated: true, completion: nil)

just confirming this issue still persists. When fullscreen is presented from the formSheet controller that contains ImageSlideshow - after dismissal of the fullscreen presenting controller does not reappear on the screen. It still works on foreground but does no rendering.

Thanks for reporting this! I can reproduce it on my side, but don't know what the fix could be now. The simple fix is to disable custom ZoomAnimatedTransitioning, as the custom zoom out animation (class ZoomOutAnimator) is what's causing the problem.
I've found references to this problem elsewhere on the internet, so it seems like it could be an iOS 13 bug. If anyone knows a fix or workaround please open a PR!

I think I found a solution in db30f4c2ceb2639d091a4bf9f659bf821cdc4e45. Please give it a try, it should now work properly.

Should be fixed in version 1.9.0. Let me know if it works properly now and reopen the ticket if not.

Confirm. It works ok now. Thank you for a quick response.


Filter appointments with code

This is introducing some filters like:

before 10am
with a female GP
face to face

and using them to build the template context, rather than indexing straight
into the appointments array.

Apologies for the inconsistency with camelCase vs snake_case - happy to resolve as another commit but don't want to rewrite the history just now


Fix Flink job tracking

Closes #110

/cc @elanv

Looks good! Thanks for this work.
When I looked more closely, the job ID was not printed out in version <= 1.9 with blocking mode. (This could be guided by document)

@regadas There is no functional difference, but alternative implementations are likely to be possible.
Job submitter can consist of two containers: submitter and job ID provider.
The second container writes the job ID to the termination log when it catches, then terminates.
In this case, the difference would be getting the ID from the container termination log instead of the log stream.

I actually like the simplicity of this approach. As I pointed out it seems that JobId is present as well for versions 1.9.3 even when running in a non-detached mode
https://github.com/apache/flink/blob/6d23b2c38c7a8fd8855063238c744923e1985a63/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java#L764
Spawning extra containers make things trickier in environments where the resource quotas are tight. Users need to have more understanding of the underlying infra to be able to specify appropriate resource quotas

Looking at the resource quotas, the number of pod can be limited by quota, but not the number of containers. And in this case, IMO, it's effective to apply a pattern that separates the containers that write and read files. I think that the tracking logic is also more efficient and simpler because the operator only needs to check the ID under the condition that the ID provider container in the job submitter is in the terminated state. Getting the log stream of a running container may be affected by the state of that container and the node hosting it. After merging this PR as it is, can I improve it a little more?

Looking at the resource quotas, the number of pods can be limited by quota, but not the number of containers. And in this case, IMO, it's effective to apply the pattern that separates the containers that write and read files.

I know that ... is just that for users when estimating quotas they need to account for the resources used by all the extra containers; It's a minor thing I know but can be relevant in some scenarios.

I think that the tracking logic is also more efficient and simpler because the operator only needs to check the ID under the condition that the ID provider container in the job submitter is in the terminated state.

Yes, it will be a bit more efficient but parsing the log should be fast and we can make it avoid parsing it once we have already the ID.
Another thing that we leverage from getting the log directly is to set the FailureReasons property in case the submission fails; Currently because we rely on the termination log and it's size is limited it needs to be truncated not giving the full picture.
Idk, we can still give the idea of two containers: submitter and job ID provider a try and see how that looks. IMO right now feels a little too many moving pieces to get the JobID but we will see. You can make a PR and becomes easier to discuss.

Getting the log stream of a running container may be affected by the state of that container and the node hosting it

What are you foreseeing here?

Thanks for comments @regadas. That meant that the state of the connection between the operator and the container or node could affect the operator's performance, since the operator gets the logs directly from the container.

Above all, I am concerned that log streaming will affect the performance of not only the operator but also the kubernetes api server when the Flink operator is operated on a large scale. Because the logs are streamed through the k8s api server from the running container. However, I'm not sure if it really affects the k8s cluster because I haven't actually applied log streaming of the k8s API.

@regadas are you working heavily on this branch? I am planning to do some code cleanup especially on the observer and status derivation. Mostly should be backward compatible, just making the condition easier to understand so I can understand the conditions of why some jobs aren't getting properly updated.

I've been fiddling with other stuff and I'm still debating if this should go in or not (while thinking of alternative solutions); I'm leaning towards giving it a try and see how things behave not sure if @elanv is onboard with this though;
You wanted this to go in so you can wrap up your changes?

Maybe its possible to merge into your branch instead? Or work on a common branch in the spotify repo. Basically I want to do three things:

Reduce the amount of noise in the log
Figure out why sometimes the reconcile cycle is much faster than the expected delay
Create a v2 observer and status update based on the current code with much simpler conditions

I did test this branch, and I don't think it fully solves the anomalies of job submissions, there are much more odd status conditions that detemines the job status and conditions.

@regadas I still think it's a good idea to avoid using log streams, but if you think so, it's also ok to go this way as of now and watch things. And if you think it's okay, I'd like to finish my PR next. I think it resolves many issues.


RVIZ display problem

Thanks for your good work!
I encountered a problem.
When I press ctrl+shift+R, rviz has a display problem. And Gazebo is all right.
Could you please tell me how to solve this problem?

The possible reason is that the conversion between base_link and odom_link mutated during the reset.
But how to solve it?

I tried it, it seems like the visual model is reseted to infinite location in rviz XD, maybe the tf have a little problem after we reset the robot in gazebo?

This is because, during the reset process of state estimation, the estimated position of the robot experienced a significant deviation. This does not affect its use.
Perhaps this can be eliminated through some small tricks. Pull requests for improvements are welcome, if someone has a good idea.
这是因为状态估计在重置的过程中，估计的机器人的位置发生了很大的偏移。这并不影响使用。
或许可以通过一些小技巧来消除这个问题。如果有人有好的想法，欢迎提交改进的拉取请求。

Maybe you can try sending the following command before load controllers :
rostopic pub --once /reset_estimation std_msgs/Float32 "data: 1.23"


Invalid item id's being passed

I've had issues with the plugin for a while, finally decided to do something about it.
For whatever reason check within the inventory was not working. Bank and Seed Vault functionality was fine.
The core problem seemed to be with how the item id's were being collected while in the inventory widget, there might have been some RuneLite api change that affected the behaviour. After taking a look at that I changed a few other things too. :P

Item id's now fetched by checking widget rather than option params
ChatMessageManager used to send a formatted response
All data now stored in a Map, couldn't be assed to change the data structure but a Map is a bit more efficient than iterating over id's every time the options are rebuilt.
Removed onMenuOpened, a couple unused methods and fields.

Hey, just wanted to say thanks for making these changes! Honestly wasn't expecting someone to go through the trouble but it's very much appreciated. I sent the pull request to update the plugin so it should be updated with your changes soon. Probably should have asked before but did you want me to add your name to the plugin's description for your contribution?

Haha, its all good, its something I use often.
Nah feel free to leave my name out, that way if it breaks no one accuses me right :P


Wgs/coverage

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation and Context

Description

add coverage
Use cases (Optional)

BC-breaking (Optional)

Checklist
Before PR:

[ ] I have read and followed the workflow indicated in the Contributors.md to create this PR.
[ ] Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[ ] CLA has been signed and all committers have signed the CLA in this PR.

CI参考：https://github.com/DeepLink-org/DIOPI/actions/runs/5747487567


Navigation

Userstory
As a User
I want to have a navigation
so that I can have quick access to important pages
Description
A Navigation menue  and some buttons will be added so that the landing page has a cleaner appearance.
Also user will be able to  access new functionality.

AC

[ ] access different pages
[ ] routing is working correctly
[ ] singlepage application

Tasks

[ ] create new branch
[ ] add router
[ ] add navmenue
[ ] add button for e.g. add new bankaccount and and new transaction

Complexity
easy

Good job on this user story!:thumbsup:


fix: clarify comments in IAM deny policy example

In the example, you're not creating a deny policy "for the service account"; the deny policy is attached to the project, not the service account.

/gcbrun


Implement responsive layout and navigation

The puzzle 1-c7fae5f2 from #1 has to be resolved:
https://github.com/codeforthailand/election-live/blob/2673e914d23a199f89449a155189668e1db9ee88/src/components/layout.js#L6-L6
The puzzle was created by Thai on Cloud9 on 17-Mar-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-c7fae5f2 has disappeared from the source code, that's why I closed this issue.


Add index_id in split metadata

The Split and SplitMetadata structs do not contain the index_id.
It is a bit strange as we store the index_id in postgresql splits table.
But we did not feel need for it as the index_id is already present in actors via the IndexPipelineId. This works as all our actors operate on a given index or pipeline.
But this will not be the case for the delete pipeline where we can have one pipeline working on several indexes.

@fmassot +1 for adding index_id to the split metadata


Add resources that helped you to improve your carrier in web development.

Hello , can you please provide in detail what we actually have to do ?

hey @aayusranjan  can i work on it. also please ellaborate on it

you just need to add some free resources, which you know about so anybody can access it and learn web development for free

everyone is welcomed to contribute on this repo,

Hey, I'll love to work on this issue, Would appreciate it if you assign me.

I created a PR @aayusranjan Please could you review. Thanks.

Hey, I would love to work on the issue. Please assign me the issue.

@aayusranjan  I made a PR. Could you please review it. Thanks.


Controlled Input

It would be ideal if there were 2 different props value and defaultValue to handle both cases controlled and uncontrolled default value.

@tonyspiro It already supports defaultValue prop. Look at this pen – http://codepen.io/sanniassin/pen/GZLQWG


Fix the assertion - currently you can't convert the result back into a float

    #TODO:  Fix the assertion - currently you can't convert the result back into a float

https://github.com/JoeyBream/python-challenges/blob/ea5e0ae0def6e4b07f5793fdc57687fd9e78742c/Challenge%3A Thousands Separator/test.py#L8

I've fixed this now. Once the number was printed correctly as a string then this issue subsided.

I've fixed this now. Once the number was printed correctly as a string then this issue subsided.


Allow clickable links in completion pop-up inside snippet description

It would be nice if links (for example to documentation or other references) inside the description field of a snippet was click-able when presented to the user via the completions pop-up.
"Ctrl + click to follow link" as with links in text/source files would be fine.

It would be helpful to cross reference the duplicate issue when closing. The only related issues I was able to track down were:

https://github.com/Microsoft/vscode/issues/56238
https://github.com/Microsoft/vscode/issues/10561

None of which seem to reference the way this is implemented in Atom. Atom allows for a descriptionMoreURL key/value that can be linked to documentation related to the snippet.
Example snippet structure:
'fs-min-height':
  'prefix': 'fs-min-height'
  'body': """@include fs-min-height(${1:$width}) {
    $2
  }"""
  'description': 'Min-height media query helper'
  'descriptionMoreURL': 'http://threespot.github.io/frontline-sass/documentation/#main-mixin-fs-min-height'
  'rightLabelHTML': '@mixin'

Example UX:


Inaccurate info about Ruby syntax

The language reference seems to imply that cask 'foo' do ... end isn't "strict" Ruby, whatever that means. But that's not true: in standard Ruby syntax, no comma is required between simple arguments and a do block. So I'm suggesting removing the sentence that claims that this is not strict Ruby.

Thanks, no idea what this is supposed to mean either.


Added custom icon functionality, modified examples and updated version.

Now you can use the markerIcon options like this:
<script>
	$('#somecomponent').locationpicker({
		markerIcon: 'http://linktosomeicons.com/icon.png'
	});
</script>

This will use a custom image for the marker.
Note: This also contain the *Merge pull request #28 from brendannee/master* in the dist folder (built with grunt).

Nice one. Thanks Emanuele


Setting Logging Channel doesn't work

The way I tried to set the logging channel doesn't work until you reload the bot. Scrapped that method for now and instead, the bot is now looking for channels named #public-mod-logs.


refactor: use 'put' and 'delete' instead of 'post'

Issue:
In todo routes, post is being currently used to update and delete tasks.
Changes required:
'Post' request need to be converted into 'put' to update tasks and 'delete' to delete the tasks.

Please assign me this issue under hacktoberfest.


MavenPomDownloader - support RELEASE/LATEST version syntax

test case:
    @Test
    void releaseVersion() {
        rewriteRun(
          pomXml("""
                <?xml version="1.0" encoding="UTF-8"?>
                <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
                  <modelVersion>4.0.0</modelVersion>

                  <parent>
                    <groupId>org.springframework.boot</groupId>
                    <artifactId>spring-boot-starter-parent</artifactId>
                    <version>RELEASE</version>
                  </parent>

                  <groupId>bogus.example</groupId>
                  <artifactId>arti</artifactId>
                  <version>0.0.0</version>
                  <packaging>pom</packaging>

                </project>
                """)
        );
    }

This syntax is not nearly as prevalent as its equivalent in Gradle, but it's valid, and may help some projects.

this could also be extended to less-common maven version selection syntax, eg [3.0.0,)

This syntax (using LATEST/RELEASE on parent and plugin versions) is deprecated. It also break the reproducible build concept.

Fixed in https://github.com/openrewrite/rewrite/commit/c4c184e7ebc6eb6c89e2590deabe1158ccce7219


Add build_deb.sh script to build a .deb package

This script is helpful for ubuntu packaging.
In the future this could be hooked up to CI to automatically generate
.deb artifacts on release.

Hey @danobi. Hope you're doing well. This look great, thanks for adding it

Hi @dschatzberg , looks like https://github.com/facebookincubator/below/commit/1c4a01fe3475d3ed725fb0021a596daa3c46dedc blew away some of the Cargo.toml changes. I think you might need to manually add the changes to the internal mapping stuff.

@danobi Should be fixed with https://github.com/facebookincubator/below/commit/69f0e3f8c09454b9f77d12d41268ee3cb53a523f - please let me know if it still doesn't work


@orta: Uses bundler caching

According to the docs, dependency caching doesn't work automatically if you specify a custom install step (which we do). So we need to specify the directory instead.
I'm omitting CocoaPods caching because the cache is accessible to all pull requests, and caching our Pods would cache our Keys, possibly exposing our API keys to a knowledgeable attacker.

Sure


Fix TC_SWDIAG_3_1.yaml test case on Linux

Problem

The test case previously expected used/free heap value of 0.
Now the SDK is implementing heap read properly from Linux when
built with glibc. This made the code return a real value
that fails the test.
Overall, there is no "value" value for heap, we just need
a value.

Change overview

The explicit value was replaced with expecting
a returned value back.
A new script was written with help @vivien-apple to
save time when regenerating ZAP for just chip-tool

Testing
Ran the modified integration test, now passes on Linux

Instead of your own script to regenerate tests, I have opened https://github.com/project-chip/connectedhomeip/pull/15246 that should do what you want (in a faster way)

/rebase


Inability to handle multiple tabs

Browser seems to be struggling when opening more than 8 to 9 tabs, when the same tabs when opened on Chrome or Firefox work just fine.
Hardware : 16 GB RAM, Intel i5
Platform: OS X 10.11.4

Is it just tab-switching you're seeing issues with here? In which case it will probably be fixed by #483


Main.py

Determining how to structure main.py to run modular code
Following meeting today, need to set it to pull and run module -> 5+ via main py whilst maintaining modular structure of the coding blocks.

Tested the use of module import function and can input this for us to get main.py to start calling the modules functions:
First select function of interest in module of interest - I added this one locally into Module 3 for testing:
def debug_import():
print("Hello from Sonja Code")
Then add this in the main.py and run it:
import Modules.module3_VV_LOVD.rev_Sonja_code
import rev_Sonja_code
Temporary debug code to understand main.py calling modules
rev_Sonja_code.debug_import()
Will explain at our meeting in detail, but should get us started

Include central logger for project in main.py and then import into individual modules.


Reset client ?

Let us say my elasticsearch nodes are running as kubernetes pods. It is possible that all the pods may go down and come back again with a different IP. In that case, the client is not running anymore. Is that right?
Is there any way to internally reset the client, may be in a retrier with the new URL(s)?

Okay, that's an interesting problem.
When creating a client with Elastic, you need to pass a URL to at least one node of the cluster so that Elastic has a chance to at least connect. If you enable sniffing (the default), Elastic inspects the cluster and finds all other nodes and stores them as possible targets to send requests to.
However, if at any point in time, all pods are gone, all internal connection states have gone to status "dead". When a request is then sent via Elastic, it tries to pick a connection from the "dead" and retries with the other connections is has according to the configured retrier and backoff.
However, if the cluster comes up again with all nodes having different IPs, Elastic has no way of ever finding the nodes in the re-configured cluster.
 HAProxy or nginx come to mind.
Experiment withdedicated coordinating nodes in Elasticsearch and ensure they don't get removed in the Kubernetes cluster.

The long-term solution would be support in Elastic for different (sniffing) strategies of finding nodes in the cluster (in k8s you could e.g. search for pods with certain tags), along with supporting different LB strategies (currently, there is only round-robin).

But coming back to your original question: Is there a way to reset the client?
Yes, you should simply call client.Stop() to halt all goroutines that started when creating the "old" client, then create a new *Client.
You could also use the stateless elastic.NewSimpleClient, which creates a "throwaway" client.

@olivere Thank you for the quick response.
Regarding the solutions you mentioned.

Use a load balancer / dedicated node

the elastic client becomes more of a simple client as there is no distribution (round-robin) or sniffing required. The requests are always sent to the balancer. Please correct me If i'm wrong.
The problem remains the same if this load balancer is also run as a pod.

Pods can be removed and re-scheduled anywhere in the cluster. K8s does not guarantee anything on that.

I retried resetting the client in retrier when the request fails with an option to let the caller retry the request again which seems to work. I'll explore that option further.

Hmm... may I ask how you run ES on Kubernetes? Do you expose ES via a k8s service with type: loadBalancer? If that is true then you should be able to run Elastic with the service endpoint, no? Just be sure to disable sniffing.

No. We don't want to expose it as a service due to some restrictions.

Do you have a link on the internet which describes how you run ES on Kubernetes?

Not exactly. We have a customized solution using deployment/daemon sets and file-based discovery plugin. The ES cluster is not backed by k8s service today.

Okay. If I understand you correctly, you know the IP addresses of the ES nodes at any time, but they are not accessible by DNS or hostname? Hence you want to create a new ES client once the IPs change?

Yes. That's right.

Okay. Then I think you currently do only have 2 options:

Create a new long-running client with elastic.NewClient whenever your cluster "dies".
Use elastic.NewSimpleClient which is request-scoped.

HTH.


Refactor Server Http2 Implementation

Remove NettyMessageProcessor and reuse client handlers.

Please look at the most recent commit only. This PR is on top of https://github.com/linkedin/ambry/pull/1551.

Codecov Report

Merging #1554 into master will decrease coverage by 0.06%.
The diff coverage is 76.72%.

@@             Coverage Diff              @@
##             master    #1554      +/-   ##
============================================
- Coverage     73.63%   73.56%   -0.07%
+ Complexity     8146     8129      -17
============================================
  Files           572      575       +3
  Lines         44684    44707      +23
  Branches       5645     5643       -2
============================================
- Hits          32901    32888      -13
- Misses        10123    10159      +36
  Partials       1660     1660

Impacted Files
Coverage Δ
Complexity Δ

.../ambry/network/http2/Http2BlockingChannelPool.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...mbry/network/http2/Http2ClientResponseHandler.java
76.19% <40.00%> (-9.00%)
4.00 <0.00> (-1.00)

...github/ambry/server/StorageServerNettyFactory.java
81.81% <50.00%> (ø)
3.00 <1.00> (?)

.../ambry/network/http2/MultiplexedChannelRecord.java
64.84% <60.00%> (-1.03%)
29.00 <0.00> (ø)

...github/ambry/network/http2/Http2NetworkClient.java
81.18% <61.11%> (-2.51%)
13.00 <0.00> (ø)

...mbry/network/http2/AmbryNetworkRequestHandler.java
61.53% <61.53%> (ø)
3.00 <3.00> (?)

...a/com/github/ambry/network/NettyServerRequest.java
90.90% <75.00%> (+6.29%)
5.00 <2.00> (ø)

.../Http2BlockingChannelStreamChannelInitializer.java
76.00% <76.00%> (ø)
2.00 <2.00> (?)

...ava/com/github/ambry/network/http2/Http2Utils.java
88.88% <88.88%> (ø)
2.00 <2.00> (?)

...bry/network/NettyServerRequestResponseChannel.java
72.72% <100.00%> (-2.28%)
6.00 <0.00> (-1.00)

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62264b...c4c4025. Read the comment docs.


Update storage.md

Addition of the NativeStorage plugin:

Eliminates problems that occur when using localstorage

Hey @GillesC, we don't usually feature 3rd party plugins in our docs. Sorry.

Also, the file you modified is build generated from crowdin.
Plugin documentation lives with the plugins.


I want to Update the readme file

To improve the visual appeal and make the README look more professional and engaging.To provide quick statistics and information about the repository, enhancing the readability and providing key metrics at a glance.To improve navigation and allow users to quickly find specific sections of the README.

connect with me on meet before make changes... join discord and fix the meeting timing

These are the thing I want to add :
🚀 Usage
Once you have VigyBag running, you can:

Navigate to http://localhost:8000 to access the web application.
Use the search functionality to find products based on location.
Explore nearby stores and compare prices easily.

🧪 Testing
To run tests for VigyBag, use the following command:
# Run tests
pytest

## 🌐 Deployment

To deploy VigyBag to a production server:

1. Configure your production environment settings.
2. Set up databases and other required services.
3. Ensure all dependencies are installed and updated.
4. Deploy the application using your preferred method (e.g., Docker, Heroku, AWS).

## ❓ Troubleshooting

If you encounter any issues while setting up or using VigyBag, try the following:

- Double-check your environment setup against the installation instructions.
- Search for similar issues in the project's [GitHub Issues](https://github.com/codervivek5/VigyBag/issues).
- Reach out to the community or project maintainers for assistance.

connect with me on meet before make changes... join discord and fix the meeting timing

Sorry I don't have discord . I have provided the updation code if you are ok with ot then only I will make the changes

These are the thing I want to add :
🚀 Usage
Once you have VigyBag running, you can:

Use the search functionality to find products based on location.
Explore nearby stores and compare prices easily.

🧪 Testing
To run tests for VigyBag, use the following command:
# Run tests
pytest

## 🌐 Deployment

To deploy VigyBag to a production server:

1. Configure your production environment settings.
2. Set up databases and other required services.
3. Ensure all dependencies are installed and updated.
4. Deploy the application using your preferred method (e.g., Docker, Heroku, AWS).

## ❓ Troubleshooting

If you encounter any issues while setting up or using VigyBag, try the following:

- Double-check your environment setup against the installation instructions.
- Search for similar issues in the project's [GitHub Issues](https://github.com/codervivek5/VigyBag/issues).
- Reach out to the community or project maintainers for assistance.

these all issues already solved

These are the thing I want to add :
🚀 Usage
Once you have VigyBag running, you can:

Use the search functionality to find products based on location.
Explore nearby stores and compare prices easily.

🧪 Testing
To run tests for VigyBag, use the following command:
# Run tests
pytest

## 🌐 Deployment

To deploy VigyBag to a production server:

1. Configure your production environment settings.
2. Set up databases and other required services.
3. Ensure all dependencies are installed and updated.
4. Deploy the application using your preferred method (e.g., Docker, Heroku, AWS).

## ❓ Troubleshooting

If you encounter any issues while setting up or using VigyBag, try the following:

- Double-check your environment setup against the installation instructions.
- Search for similar issues in the project's [GitHub Issues](https://github.com/codervivek5/VigyBag/issues).
- Reach out to the community or project maintainers for assistance.

these all issues already solved

But these are not updated in the readme file .So want to add them

Can I work on this issue?


Change Button Expand Space

I want to change the space between button that expanded, it can if i have the library. But I can't import the library. I don't kno why. I've tried so many way, many time. Nothing work. Please help.
If there is another way, or trick, just inform.

It's quite simple.
Open or create "dimen.xml" and paste this line :
 %your spacing%


refactor(runner/entrypoint): check for externalstmp

This fixes these annoying messages in the runner logs:
# Authentication
√ Connected to GitHub
# Runner Registration
√ Runner successfully added
√ Runner connection is good
# Runner settings
√ Settings Saved.
Runner successfully configured.
{
  "agentId": 123,
  "agentName": "runner-deployment-123",
  "poolId": 1,
  "poolName": "Default",
  "ephemeral": true,
  "serverUrl": "https://pipelines.actions.githubusercontent.com/123",
  "gitHubUrl": "https://github.com/123",
  "workFolder": "/runner/_work"
mkdir: cannot create directory './externals': File exists
mv: cannot stat './externalstmp/*': No such file or directory
}
√ Connected to GitHub

Current runner version: '2.289.1'
2022-03-27 11:04:41Z: Listening for Jobs

Emphasis:
mkdir: cannot create directory './externals': File exists
mv: cannot stat './externalstmp/*': No such file or directory

LGTM, cheers. I've removed the directory check as it shouldn't be needed and I'm hesitant changing the move logic in case it impacts some edge case


[ServiceBus] add prefix to locks

to improve logging.  This is similar to other existing lock tokens.

API change check
API changes are not detected in this pull request.


Don't preload video prop

It would be really nice if there was a prop you could set to stop video from preloading and only load when play is pressed or on an explicit call to load.
The use case I'm dealing with is that I have multiple videos in one view and it seems they are all loaded into memory even though they are not playing. This causes my app to crash once it reaches a certain number of videos.
I think preventing preloading could probably solve that issue. I propose that the first frame of the video would only be loaded (unless a poster is set) if preload would be true, similar to html5 video

react-native-video is amazing. but i don't see preload. the preload is required to wait for loading video. please add preload. thanks for advanced. 👍

There's no way to do this at the moment, but you can get the same effect by creating a placeholder component that displays a thumbnail or other view and then sets state to load the video when you press it.

how can i sets state to load the video when i press it.

Hate to be the one to necromance such an old thread, but what's the best way to do this in late 2019?

I ended up using expo-av through react-native-unimodules. Which is a bit heavy handed but I was able to get the API to do what I needed.

I just figured out that there is not way to stop loading of videos, i am using it in Flatlist, is there any workaround besides using expo-av as @juanjsebgarcia suggested?
It is real pain to get expo-av working.

@mladenp I would suggest you just move to expo-av this react-native-video package feels abandoned and I found it to be very buggy when I was implementing it. It's a shame, and I hope it does progress given its the most popular video package.

Consolidated into #2668


[Bug]: Incorrect indentation in dsi

Bug Description
Hello,
The following line in the dsi example in the README is incorrect:
vim.cmd.normal { ">" , bang = true }

It should be
vim.cmd.normal { "<" , bang = true }

Relevant Screenshot
No response
Reproduction & Sample Text
.
neovim version
.

Make sure you have done the following

[X] I have updated to the latest version of the plugin.

thanks, fixed

Thank you. Your work on this plugin is very much appreciated :-)


Windows are not draggable on smartphone

Windows are not draggable on smartphone or when we inspect it with developer tools on browser.

Fixed !


Bank tag layouts v1.2

Updates Bank Tag Layouts to v1.2. New features:

Automatically lay out a tag tab based on your current gear and inventory.
Layout placeholders are now draggable.
Minor improvements and bugfixes.

Did you make those icons or did they come from somewhere?

The red x and green checkmark come from screen markers, the shuffle icon is from material.io.


Publish pier as a crate

As someone looking to try out  pier, it would be nice if I could just "cargo install" it, and not have to worry about manually needing to keep it updated.

@bgianfo Coming right up!

@bgianfo See https://crates.io/crates/pier

Awesome, thanks!


How to train model on custom dataset?

Hello, @zhixinwang !
Thank you for your great work!  Is it possible to train frustum-convnet on a custom dataset? What and where should I change in code?

@RocketFlash  Current our code is mainly designed for KITTI dataset. If you want to use it for a custom dataset, the best way is to prepare the data according to KITTI format. For different categories in custom dataset, you can modify the information in datasets/dataset_info.py. The most important thing is you should care more about on the different coordinates.  Contributions are welcomed to support  other datasets.

@zhixinwang Thank you for the answer! I have another question: is it possible to train the network without camera data ? I mean if I have only lidar scans and 3D bboxes ? How is it better then to generate frustums ?

Our method leverages mature 2D detectors in RGB images to provide reliable frustum proposals.
If you don't have camera data, our method may not have an advantage.  However,  there is a possible method to generate frustum without RGB images. Try to first generate frustum proposals from range-view point cloud data. I do not have related experiments about this. You can try by yourself and welcome to share your experiment results.


Wamp?

Am I correct in assuming this isn't a good tool to run on wamp. Should be a lamp stack instead?

I've started running this on Wamp with no real issues so far, what problems are you imagining there to be?


Entra ID / Azure ID authentification wrongly detected

I wrongly receive the warning that Entra ID / Azure ID is not set up.
Steps to reproduce

Setup endpoints with API key authentication
Run powerproxy via VSCode debug config
Make a request using the OpenAI Python SDK, with authentication via API key

Expected behavior
Response from underlying OpenAI model deployment
Actual behavior
Entra ID/Azure AD as authentication method is identified.
openai.BadRequestError: Error code: 400 - {'error': "When Entra ID/Azure AD is used to authenticate, PowerProxy needs a client in itsconfiguration configured with 'uses_entra_id_auth: true', so PowerProxy can map the request to a client."}

Background
It seems that the OpenAI SDK sends the API key additionally via the authentication header (link to code). This triggers the Entra ID/Azure AD check.
With OpenAI SDK version 1.35.1 and powerproxy version 0.11

Hey @luisdreisbach, I did not run into the issue brought up when running the authentication tests included in the repo (using an older package version of openai but also using the latest 1.35.4). Can you please check again and provide code to repro if the problem still persists?

Hey, I think this is not related to the authentication test because I do not want to use Azure AD as authentication at all. To reproduce I use the simple config.local.yaml (no need to put in real secrets, it fails previously)
clients:
  - name: Client
    description: Main client
    key: 04ae14bc78184621d37f1ce57a52eb7
    deployments_allowed: [gpt-4o]
    max_tokens_per_minute_in_k: 500

plugins:
  - name: AllowDeployments
  - name: LimitUsage
  - name: LogUsageToConsole
  - name: LogUsageToCsvFile

# Azure OpenAI
aoai:
  endpoints:
    - name: gpt-4o-deployment
      url: https://___.openai.azure.com
      key: ___
      non_streaming_fraction: 1
      connections:
        limits:
          max_connections: 100
          max_keepalive_connections: 20
          keepalive_expiry: 5
        timeouts:
          connect: 15
          read: 120
          write: 120
          pool: 120
      virtual_deployments:
        - name: gpt-4o
          standins:
            - name: ___
              non_streaming_fraction: 1

start the proxy with
python powerproxy.py --config-file ../config/config.local.yaml

and run
python test/python/test_non_streaming.py --deployment-name gpt-4o

which leads to
Traceback (most recent call last):
  File "/Users/powerproxy-aoai/test/python/test_non_streaming.py", line 28, in <module>
    response = client.chat.completions.create(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/powerproxy-aoai/.venv/lib/python3.11/site-packages/openai/_utils/_utils.py", line 277, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/powerproxy-aoai/.venv/lib/python3.11/site-packages/openai/resources/chat/completions.py", line 590, in create
    return self._post(
           ^^^^^^^^^^^
  File "/Users/powerproxy-aoai/.venv/lib/python3.11/site-packages/openai/_base_client.py", line 1240, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/powerproxy-aoai/.venv/lib/python3.11/site-packages/openai/_base_client.py", line 921, in request
    return self._request(
           ^^^^^^^^^^^^^^
  File "/Users/powerproxy-aoai/.venv/lib/python3.11/site-packages/openai/_base_client.py", line 1020, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': "When Entra ID/Azure AD is used to authenticate, PowerProxy needs a client in itsconfiguration configured with 'uses_entra_id_auth: true', so PowerProxy can map the request to a client."}

It's the same error for openai version 1.30.3 and 1.35.5

Thanks, I will take a look into it.

@luisdreisbach I have just released a new version which fixes the problem.


resources and scopes documentation

This PR adds a documentation on working with multiple resources and scopes in response to #1361 and #1653

@tnorling thanks! Added a section on consent lifetime.

Due to build failure and package-lock file we've copied the doc to #2002 and will pull into dev from there


Using Nunit 3 & SpecFlow 3+ I get NullReferenceException

I'm using NUnit 3.12 and SpecFlow 3.1.82 and when running a test I get a System.NullReferenceException. The given output is from an nunit-console run, but the same happens if I run from Visual Studio.
The output is attached.
nunit-console-output.txt

Hi @xeekworx !
Sorry for the late response.
Can you please make sure you are using the latest version of Ghpr.* NuGet packages?
Also, can you make sure that Ghpr.SpecFlow.Settings.json file is copied to the directory with the tests as well as other Ghpr.* files?
Thank you.


Clone SQL Database or multiple tables to MariaDB?

**Is your feature request related to a problem? I see from DBeaver that there is an option to export data from individual tables from SQL Server. Then I could import that data into a MariaDB database/table. I basically want to be able to clone the "schema"  for a table including the table name AND copy the data in that table from MS SQL to MariaDB. Ideally I would like to do this for all the tables in the database/schema. I would like to be able to copy and paste a database from SQL Server to MariaDB. This is doesn't seem possible right now, as I just get an error message when I try it.

It is a big dream of many users, but cannot be done now. Please use data transfer option to simplify data migration https://github.com/dbeaver/dbeaver/wiki/Data-migration.


fix: Personalize ranking  top bar color

What
Added dark theme for the top bar in Personalized Page.
Screenshot
Dark Theme:

LightTheme:

Fixes bug(s)

#1215

Part of

https://github.com/openfoodfacts/smooth-app/issues/525
(please be as granular as possible)

hi,
If there is any question, do let me know .I would be happy to contribute.
Waiting for the reply!

LGTM 👍

Congrats on your first PR here 🎉


Fix two same 'if' branches with the same implementation

Signed-off-by: João Vilaça<EMAIL_ADDRESS>
What this PR does / why we need it:
This is just to remove some code smells reported by SonarCloud and to see how to contribute to kubevirt
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://sonarcloud.io/project/issues?id=kubevirt_kubevirt&open=AXd36SB0QyRUj9UJ7g5s&resolved=false&rules=go%3AS1871&types=CODE_SMELL
Special notes for your reviewer:
Release note:

NONE

/retest

/retest

@machadovilaca you should ask to be added to the kubevirt org via the mailing list. I'm unsure if there's an automated step you can make to join the org yourself ...

How to become a community member (which includes CI whitelisting) is described here: https://github.com/kubevirt/community/blob/main/membership_policy.md#member


Receiving payment ? possible or not ?

I have the follwoing topology. ZAP having a channel to ACINQ, ACINQ having a open channel to my Eclair LN node. Both channels have local and remote balance.
I can do outgoing payments from ZAP to Eclair LN wallet; but not receive payments. Error message on Eclair "No path found".
Q. can/should this work or not; eg. the channel from ZAP to ACINQ is private, therefore not broadcasted ?
Doing the same with Bluewallet works bidirectional (which of course is another case, I know).

If you are using the built in Zap Neutrino node then any channels that you open from Zap will indeed be private channels (since your Zap node is not setup as a routing node). However, you should be able to send along those private channels to Zap as you invoice contains routing hints. When you have Zap set up in this way, any invoices generated from within Zap will have those routing hints.
So what you are trying to do should in theory work.

From Eclair to ZAP, I get the error message: Payment failed; (local) route not found.
From Bluewallet to ZAP: Payment failed. Does the Receiver have enough inbound capacity? (code10).
and yes, the inbound balance is 1981 sat ! and I am sending 23 sat.

@wdey This is pretty hard to answer without being able to actually inspect your setup. But I would suggest that you open some larger channels. If you only have 1981 of inbound liquidity it may be that the forwarding node is not prepared to send along that channel as it would leave that node with an incredibly low balance on that channel and potentially in a position where it was unable to close the channel with not enough funds for an on-chain transaction.
Also, perhaps there are other nodes in the route that have low channel balances, or perhaps the penultimate hop in the route has badly balanced channels.
There are many reason why routing can fail and I don't believe this is really an issue with Zap (zap is literally providing a UI for your node).

The topology is very simple
ZAP ----private channel --- ACINQ ----public channel---  My Éclair LN node.
ZAP has only one channel, Éclair has 6 (see 1ml.com: wdey)
And here the channel information:
<EMAIL_ADDRESS><EMAIL_ADDRESS>If routing is smart, it should take the least hop route, and then I don’t see why this should not work ?
Von: Tom Kirkpatrick<EMAIL_ADDRESS>Gesendet: Donnerstag, 13. Juni 2019 14:51
An: LN-Zap/zap-desktop<EMAIL_ADDRESS>Cc: wdey<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [LN-Zap/zap-desktop] Receiving payment ? possible or not ? (#2409)
@wdeyhttps://github.com/wdey This is pretty hard to answer without being able to actually inspect your setup. But I would suggest that you open some larger channels. If you only have 1981 of inbound liquidity it may be that the forwarding node is not prepared to send along that channel as it would leave that node with an incredibly low balance on that channel and potentially in a position where it was unable to close the channel with not enough funds for an on-chain transaction.
Also, perhaps there are other nodes in the route that have low channel balances, or perhaps the penultimate hop in the route has badly balanced channels.
There are many reason why routing can fail and I don't believe this is really an issue with Zap (zap is literally providing a UI for your node).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/LN-Zap/zap-desktop/issues/2409?email_source=notifications&email_token=AGJ6CAY7XYC3YLMS7D32EWTP2I7EDA5CNFSM4HXJYSC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTSVCY#issuecomment-501688971, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJ6CA24WBZVUOYM6PFEZT3P2I7EDANCNFSM4HXJYSCQ.

Can you share the LN invoice with me please (You can DM it to me on Slack if you prefer)

lnbc20n1pwsy6c5pp5c0ta4frvgc6vatrja9hhns3c56rrly3t9y297yskfkp9gyg0644sdqqcqzpgxqyz5vqgxuup4fzclqk3jct99zsmwls9w67efpfhxmnr86u6eypgujyl8lp8lm7j6x7r3xtzs225zgekycd2afjv75mvzmgn3chj2yy79zuxwcq876vla
Von: Tom Kirkpatrick<EMAIL_ADDRESS>Gesendet: Donnerstag, 13. Juni 2019 16:37
An: LN-Zap/zap-desktop<EMAIL_ADDRESS>Cc: wdey<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [LN-Zap/zap-desktop] Receiving payment ? possible or not ? (#2409)
Can you share the LN invoice with me please (You can DM it to me on Slack if you prefer)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/LN-Zap/zap-desktop/issues/2409?email_source=notifications&email_token=AGJ6CA7FUK37WSZMYYOCWPLP2JLPNA5CNFSM4HXJYSC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXT43NY#issuecomment-501730743, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJ6CA4GJP5XOCBY75WEUTDP2JLPNANCNFSM4HXJYSCQ.

How did you generate this invoice? It does not have any embedded routing hints

I run ZAP 0.4.1-beta
I go to “Request Bitcoin through LN” enter number of sat, create / copy invoice,…..
Autopilot is off
Only one channel to ACINQ
Von: Tom Kirkpatrick<EMAIL_ADDRESS>Gesendet: Donnerstag, 13. Juni 2019 18:02
An: LN-Zap/zap-desktop<EMAIL_ADDRESS>Cc: wdey<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [LN-Zap/zap-desktop] Receiving payment ? possible or not ? (#2409)
How did you generate this invoice? It does not have any embedded routing hints
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/LN-Zap/zap-desktop/issues/2409?email_source=notifications&email_token=AGJ6CA5FC4JG4YGTYZO5I3LP2JVPFA5CNFSM4HXJYSC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUFUUQ#issuecomment-501766738, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJ6CA5EWWBTMIFR6LR6QA3P2JVPFANCNFSM4HXJYSCQ.

Are you connected to your own lnd node or are you using our built in one?

I am using the built in lnd node !
And my own éclair node uses port 48001 (as their was a conflict with 9735)
Could there be an issue, running ZAP and Éclair / BTC Core on the same node ?
Von: Tom Kirkpatrick<EMAIL_ADDRESS>Gesendet: Donnerstag, 13. Juni 2019 19:23
An: LN-Zap/zap-desktop<EMAIL_ADDRESS>Cc: wdey<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [LN-Zap/zap-desktop] Receiving payment ? possible or not ? (#2409)
Are you connected to your own lnd node or are you using our built in one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/LN-Zap/zap-desktop/issues/2409?email_source=notifications&email_token=AGJ6CA7OTIOGHO6EQOMRPQLP2J675A5CNFSM4HXJYSC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUNWNQ#issuecomment-501799734, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJ6CA7SATA3DKPTDXSLAJ3P2J675ANCNFSM4HXJYSCQ.

FYI: I created a direct channel between ZAP and my Eclair; ingoing / outgoing payments to ZAP work ok !

In 0.4.1 if you are using our built in node then we include routing hints. If you are connected to your own node then we do not.
In the upcoming 0.5.0 when connected to a remote node you will have the option to include routing hints when you create the invoice

The option to mark routing hits was included in previous versions, but now in 0.5.3 beta it has been removed again, I can't received payments from nodes that I am not connected to because those nodes don't know my node since my node and channels are private.
Could you please   tell me how to add routing hints in zap wallet 0.5.3 invoices?

The option is still there - however it's only available when you are connected to an external lnd node. If you are using Zap's internal neutrino lnd node then we always include routing hints for you by default since in that instance we know that all of your channels are private. This was always the behaviour and has not changed in 0.5.3

I am testing sending and receiving funds.
I opened channel with wallet of satoshi node, I can send fund to the custodial wallet on android and to anyone else from that channel, for example I can send fund from my channel to my custodial wallet cobo wallet which is cobo_lnd. But if I want to send fund from my cobo wallet directly to my channel it tells me can't find route.
But if I send fund from cobo wallet to wallet of satoshi and later from wallet of satoshi back to my channel than the payment goes thought.
that could only mean zap wallet is not putting routing hints.

that could only mean zap wallet is not putting routing hints.

It could mean any number of things. You can see if routing hints are included in the invoice by pasting it here:
https://lndecode.com/

lnbc20n1pw6d22kpp5wxqrumvdszp72zzfzsxe3duv0vdq5249aff6gwum36mjjepashxsdqqcqzpgxqrrssrzjqgqyccjavg3y2cr2r63vr35uldz3ddcrk3u5tgmywufuqhly4t43czfylqqqvrqqqqqqqqlgqqqqqqgq9qrzjqtx63sqmyvp7jxlvwnzrpy7478z06s4f2ec6ufals57hml4fk7xqvzfy7qqq2acqqqqqqqlgqqqqqqgq9qrzjqd35hkjfe8zz4lv8dkpg3qpfgtzfuk8masuyfl65k3s5807tdn067zf9pcqqv6sqqqqqqqlgqqqqqqgq9q9y6qtv3gtrdlj30vkfy7xs82xud4qqwywj0u2pf3sfa3kkcf7q336ke98tdcayhdgq2eukh09ka2gnkzl4gy82xyj7yrfzn9mz0j82qq5v30ez

https://lndecode.com/
As you can see - it includes routing hints.

Closing due to inactivity


Coverage - Do not exit on failed tests

As @neomatrix369 pointed out, there is now a way to achieve this using Altcover:
https://github.com/SteveGilham/altcover/issues/53#issuecomment-470513310

This applied to #fsharp and #vbnet as we use the same coverage tool for them.


Added support for CTE in subquery

Fixes https://github.com/iTwin/itwinjs-backlog/issues/986

@soham-bentley though PR validation will test out itwinjs but you should normally build it locally and do rush cover to make sure you did not broke anything in addon or have failing test there.

@soham-bentley though PR validation will test out itwinjs but you should normally build it locally and do rush cover to make sure you did not broke anything in addon or have failing test there.

my last commit should fix the test failures


No discount on prepayment when switching from Paypal

PHP Version: 8.2.26   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Actual behaviour:
We have a 2% discount rule on payment method 'Prepayment' (Vorkasse)
When a customer selects payment by Paypal and aborts the transactioon after login and then switches to prepayment, the 2% discount is not added to the basket.
Expected behaviour:
After switching to from Paypal to Prepayment the 2% discount should be added to the basket.
This works when you haven't logged into paypal yet.
The 2% discount is added and removed to the basket as expected.
How to reproduce:

create a rule for 2% discount on payment method 'prepayment'
Put some items into your basket
Select Paypal as payment method and log into Paypal
cancel the transaction and go back to the checkout
switch payment method to prepayment
although there is a rule to add the discount, it isn't

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39949
[created from NEXT-39949, comment 521605]


Fixed fetchJson throwing on successful non-204 results without contents

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Thanks for having a look, guys!
Re. whether or not HTTP 2xx returns must have a body, from https://httpwg.org/specs/rfc9110.html#status.202 I see

The 202 response is intentionally noncommittal. Its purpose is to allow a server to accept a request for some other process (perhaps a batch-oriented process that is only run once per day) without requiring that the user agent's connection to the server persist until the process is completed. The representation sent with this response ought to describe the request's current status and point to (or embed) a status monitor that can provide the user with an estimate of when the request will be fulfilled.

Note the word "ought" there - seems distinctly different from "MUST" and implies some amount of wiggle room.
But more than a case of any particular code / spec, Jakub and I didn't see a good reason for us to force an exception on a 2xx response.  Now if you're expecting the API to return something and it doesn't, your app code will presumably throw an NPE or some other exception when it attempts to process the return. But that's really a different case - more similar in my mind to an API returning an unexpected schema, or an array instead of an object, or what-have-you.
Main point being, when is it useful to have Hoist step in and insist that something is wrong, vs. giving the app code some more flexibility.
(Note counter-case for 204 NO_CONTENT - there the spec doc says "A 204 response is terminated by the end of the header section; it cannot contain content or trailers." - emphasis mine on "cannot")

@amcclain I think the "ought" can be read as recommending what the "representation sent" should do, not recommending that a representation "ought" be sent, rather than not be sent.  There is no question that a representation is sent, just some wiggle room on what it ought to describe.
But, I can see two reasons to go with the more flexible approach proposed in this PR:
1: some 202 "representations" take the form of a 'location' header with a URI at which the requester can check the status or their original request, with no accompanying body. Maybe a "header only, no body" response is a practice some groups use for other 2XXs.
2: we are probably not the only ones who have discussed whether 2XX (excluding 204) responses MUST or MAY include response bodies, so being flexible about it and accommodating both camps seems like a good choice.


chore(main): release 10.1.0

closes #81
:robot: I have created a release beep boop
10.1.0 (2024-08-25)
Features

add 'release_year' option for episode template (223022e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/lightpohl/podcast-dl/releases/tag/v10.1.0 :sunflower:


ov: 0.36.0 -> 0.37.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/noborus/ov/releases.
meta.description for ov is: Feature-rich terminal-based text viewer
meta.homepage for ov is: https://noborus.github.io/ov
meta.changelog for ov is: https://github.com/noborus/ov/releases/tag/v0.37.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.37.0 with grep in /nix/store/n8a72dsfr50zgkmp5zl743nmiiia6rzf-ov-0.37.0
found 0.37.0 in filename of file in /nix/store/n8a72dsfr50zgkmp5zl743nmiiia6rzf-ov-0.37.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

ov

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n8a72dsfr50zgkmp5zl743nmiiia6rzf-ov-0.37.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ov https://github.com/r-ryantm/nixpkgs/archive/d60f27f889dabda7efe7fc943c630f4323591788.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d60f27f889dabda7efe7fc943c630f4323591788#ov

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n8a72dsfr50zgkmp5zl743nmiiia6rzf-ov-0.37.0
ls -la /nix/store/n8a72dsfr50zgkmp5zl743nmiiia6rzf-ov-0.37.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

ov
ov.doc

Maintainer pings
cc @farcaller @figsoda for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

@NixOS/nixpkgs-merge-bot merge


Allow specifying version update mask using simplified syntax

Description
https://packit.dev/docs/configuration#version_update_mask is Python regex to filter upstream versions. In many cases, software use semantic versioning. In that case, it is possible to understand compatibility just from looking at the version (without the need of regular expressions). For example, Python packaging infrastructure leverage this fact: see hatch, poetry. I am not aware of the standard for version range specification, however it might exist. It would be great to have something similar as an additional option for version_update_mask.
Benefit
Simplify configuration, reduce boilerplate code, lower the entry level for packit users.
Importance
Somewhat important: the need of specifying regular expressions partially holds me back from using Packit for all possible branches (it's quite easy to mix up with them and it is not obvious how to check the correctness).
Workaround

[ ] There is an existing workaround that can be used until this feature is implemented.

Participation

[ ] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Yes, your example looks good to me. Since SemVer doesn't contain compatible version range syntax specification, and there is apparently no widespread cross-language standard for this, relying on Python packaging looks good, since Packit (as Fedora infrastructure itself) so heavily relies on Python. Another popular option would be to have NPM style specifiers, but it is easier to implement just a single version — the one which comes from Python packaging.


Made the statistics print atexit

Fixed some statistics and made them automatically print atexit.

This is failing CI due to something wrong with the build pool. I am going to force a merge.


⚠ Bofrost.lu has degraded performance

In 0f90aa0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1351 ms

Resolved: Bofrost.lu performance has improved in ee5aac5 after 20 minutes.


refactor: aligned config code style

Coverage remained the same at 100.0% when pulling 80af04fbe9bb084a77603f44cf038086635bd2c8 on update-config into 5ae72f444ac89cadf04d046d0aeb5e997ba798c0 on master.


Feature Support array_pushfront function

Proposed changes
Issue Number: close #17538
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[x] Has unit tests been added
[x] Has document been added or modified
[ ] Does it need to update dependencies
[x] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run p0

run p0

run buildall

run p0

run p0

run p0

P0 regression test always failed.

run p0

run p1

LGTM

Can this pr been merged?

run beut


Stop streaming logs if the underlying resource has changed.

This was an easy change but I don't have the time to test it now, so this placeholder can be ignored atm.
From hipchat:
"I believe the issue from this morning is that we didn't print the timeout in the streaming log file and then eventually, after a worker restart, the runIds built back up to 222 and we started updating our old run output output output output with the new run"

Codecov Report

Merging #297 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #297     +/-   ##
=========================================
- Coverage   59.27%   59.17%   -0.1%
=========================================
  Files          90       90
  Lines        6995     7006     +11
=========================================
  Hits         4146     4146
- Misses       2545     2556     +11
  Partials      304      304

Impacted Files
Coverage Δ

runner/runners/local_output.go
17.64% <0%> (-1.8%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f52138...9376d9b. Read the comment docs.


add additional args to yum commands

I think we need this so we can install docker-ce using --nobest argument.

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   87.92%   87.92%
=======================================
  Files          85       85
  Lines        4613     4613
=======================================
  Hits         4056     4056
  Misses        557      557

Impacted Files
Coverage Δ

pyinfra/modules/yum.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb83167...c829f53. Read the comment docs.


Physical flows: additional attributes (candidate list)

There is a desire to improve the richness of data captured around physical flows.  Some of these items may be configured as assessment-ratings others may become built-in attributes of the flows themselves.
Evaluation criteria should be centred around the universality of the attribute.
If it is specific to a particular industry (or client) we should look to direct the attribute towards assessments.
For attributes with a general usage we should extend  theWaltz datamodel.

Attribute
Type
Examples
Description
Evaluation

Initiatiator
Fixed Enum
SOURCE | TARGET | EITHER
Who starts the flow, is it a pull from the target or a push from the source ?
Extend Model

Encryption
Flexible Enum
None | DES | AES256 ...
What type of of encryption (if any) is used on the flow
Extend Model

Closing as these can now all be handled by adding assessments.


feat: AWS glue catalog support for iceberg_scan()

Add support for accessing tables stored at AWS Glue.
Example SQL call:
select * from iceberg_scan('{ "catalog_type": "glue", "region": "us-east-1", "database_name": "test_iceberg", "table_name": "users"}');

Added the framework for more additional external Iceberg catalog:
This JSON object should be of this format:
{
  "catalog_type": "glue",
  "catalog": "1234567890",          // optional - the catalog to use
  "region": "us-east-1",            // required - change to the right region
  "database_name": "test_iceberg",  // required - change to your database
  "table_name": "table_name"        // required - change for each table.
}

Hey @rustyconover! Thanks a lot for the PR's!
To review this I will need to setup some aws glue table table myself to test it out, I will try to find some time tomorrow to do this.
One small comment I do have already is that I'm not sure the json string is the neatest way of passing the configuration to the Iceberg scan function. Maybe we can instead just add all of them as named_parameters to the iceberg table function. I think many of these will be shared among catalog_types anyway and that way the parser will help give meaningful error messages and syntax highlighting of the SQL strings works better.

Hi @samansmink,
I'll look at changing to named parameters and post a revised PR.
Rusty

Hi @samansmink,
I've changed things around to use named parameters and added the support so that the iceberg_metadata() function can also use the same configuration.
Rusty

You can now run queries that look like this:
select * from iceberg_scan('users', catalog_type="glue", region="us-east-1", database_name="test_iceberg");

select * from iceberg_metadata('users', catalog_type="glue", region="us-east-1", database_name="test_iceberg");

@rustyconover - Thank you for this PR and #50.
I have access to Iceberg tables on AWS Glue and can help testing this feature.
Is it possible to provide a binary or docker image for this PR? I'm having issues building Duckdb locally.
If the binary will contain #50, I can test that one as well.

Hi @harel-e,
Thank you for your kind words.
Unfortunately I can't help you build the extension or package it as a Docker container.  You might want to try asking on the DuckDB discord for help building DuckDB.
I'm building it on Mac OS X.  I had to make some changes to vcpkg to work around the fall out of the xz package unavailability with boost.
Rusty

vcpkg should be restored again from the xz debacle afaik! Check out https://github.com/duckdb/extension-template for some instructions on setting up vcpkg for extension builds.

I tested this branch on AWS with several Iceberg tables.
This query pattens works fine:
select * from iceberg_scan('users', catalog_type="glue", region="us-east-1", database_name="test_iceberg");
Hoping to see it in the upcoming 0.10.3
Thank you @rustyconover for this wonderful addition. DuckDB is now one step closer to work seamlessly in AWS

Sorry for the absence here, I've been really busy
There are still some problems remaining with CI here on windows and linux amd64, those would need to be fixed for this to get merged before 0.10.3

I'll take a look at the linux build failures, but the windows ones I don't have access to that platform.

@rustyconover : Does this support Nessie catalog for iceberg?

Any chance to make this PR merged?

We need catalogue support

I think it would be better to add an ICEBERG catalog secret type instead of using name parameters/json.
That way you could just query and not worry about configuration it every time.
Also, same secret can be used for other catalog types (e.g: REST).


Label text disappearing inside a viewport node

When Label autowrap is enabled, the label text dissapears inside the Viewport.
Can be easily tested with  the "GUI in 3D" demo.

Nice catch, it happens with the "clip text" option too.

Issue fixed with this commit https://github.com/godotengine/godot/pull/2719


Inject heartbeat to sematext output

Introduced BatchProcessors which operate on the level of a whole batch of metrics and can modify the batch content
Renamed existing metric Processor interface to MetricProcessor
Implemented Heartbeat processor which periodically (at most once a minute) injects heartbeat.alive metric - this was implemented in a generic way and depends on the presence of metric batches for monitored service. This meant we don't have to implement service specific heartbeat query/request for each possible integration, however, the downside is that it is not completely reliable (it is a similar approach to what we are using in Java AAs)

the downside is that it is not completely reliable

Does this mean that a person may get false positives? i.e., we don't send a heartbeat for >2 minutes, for example.

Does this mean that a person may get false positives? i.e., we don't send a heartbeat for >2 minutes, for example.

It is possible, although extremely unlikely. We know whether a service is alive only by proxy - whether Telegraf's input collected some metrics for it.
Bigger chance is to go in other direction - report that it is still alive, while the service is gone. That would happen if Telegraf's input produces some default metrics even when the service can't be examined. I would consider such behavior a bug in input logic, but we can't be sure how all the possible inputs are and will be implemented.


ANSI color support in edit buffer

Now ANSI colors are supported in the debug console, I'd like to see it in the editor, something like SublimeANSI.

VSCode Version: 1.19
OS Version: macOS

Steps to Reproduce:

open a file which contains ANSI color escape sequence, or simply ls --color | code
colorless raw ANSI code displayed, rather than colored text.

Reproduces without extensions: Yes

On behalf of a friend who is too busy coding to report this problem, this still exists on macOS with VS Code 1.24.1.

hello is the problem with ANSI color solved for editor and how, if it is?
I on windows 7 x64 and have 1.28.2 version of vs code and when I open file with ANSI coloring I get gibberish
vscode!ansi
Apart from this everything is a-ok :)

On behalf of a friend who is too busy coding to report this problem, this still exists on macOS with VS Code 1.24.1.

So vim community solved that problem in 2004.

Here's an extract from another file that I generated with jest --color and for which I'd love to see colors in VSCode:
  ✔ 1-golden-path › DELETE /notes/:id - returns a status 200
  ✔ 1-golden-path › DELETE /notes/:id - did delete the note (140ms)
  ✖ 2-failure-cases › POST /signup without password - returns an error
  ✖ 2-failure-cases › POST /signup without password - returns a status 400
  ✔ 2-failure-cases › POST /signup without password - returns no token

The ✖should be displayed in red, the ✔in green, and the (140ms) in dark gray, like this:

no update?????

Much needed feature

can't believe this feature is still not provided 2+ year after it was raised...
meanwhile, so many useless features have gone through the line...

This awesome feature should be go on!

Any status on this? Its very annoying

This needs to be supported in diffs as well. ie: show the ANSI color in the diff view, rather than ~ {

This would be very helpful if we could read gitlab raw ANSI output logs this way.

The workaround for this issue that I've been using is:

Get the data with ANSI codes in a file (e.g. boot.log)
Use ansi2html.sh to convert it to an HTML file. That can be done from the terminal using cat boot.log | ./ansitohtml.sh --bg=dark > boot.html for example.
Preview the file using any one of the HTML preview extensions in VScode

Of course, the output is read-only but it lets me see the colored data in VScode without needing to switch to vim or Sublime.

@sharm294, thanks for tip.
ansi2html.sh is quite slow and produces big HTML file when processing debug log from CodeceptJS.
So I used similar tool ansi2html from project colorized-logs. It's much faster with smaller HTML output. It can be installed on Ubuntu by apt install colorized-logs.

I was just wondering what all the weird SQL logs for rails meant, then I found this.
This shows the log with ansi colors:
less -r log/development.rb

it's strange to me that this isn't considered basic functionality for a code editor
as an irritating workaround, a whip up a terminal and use cat log.log or less -R log.log

Also (still) interessted in this feature ...

it is the standard raw output of a gitlab log, it would be helpful for it to be considered.

We really would like this feature. Can't believe nobody has been able to add support for this.

we cry out, in anguish! but in a pile of 5000+ open github issues.. nobody can hear you scream! :scream:

My solution for this sole issue is sublime text.

it is the standard raw output of a gitlab log, it would be helpful for it to be considered.

Adding that this is the standard raw output of a Terraform log.

I made a VS Code extension, since I could not find one which provides this feature. It's not perfect, but enough for my use-case. If someone wants to have a look, the repository is here at vt100-syntax-highlighting and the extension is already in the VS Code Marketplace.

@TobiasFaller - This is brilliant!  Thanks 👍
I also added the file association for *.log so it will default to your extension.  Is it at all possible to have it remove the characters instead of just changing them to black?  This would be helpful so when I have to copy/paste some of the logs for troubleshooting to to share with my team, for example json, it includes the characters and makes the json invalid.
"files.associations": {
        "*.log": "vt100",
        . . .
},

@JtMotoX I have not found a method to remove characters from the displayed text yet.
One solution would be to add a command to remove all escape sequences. This would then disable the color highlighting though.
The other solution is to use the color #00000000 for the escape sequences which hides them and leaves only a space.
In the meantime I have found some plugin that uses highlights to change the background color for characters. I will check if this method can be used to implement background colors for the VT100 plugin.

@TobiasFaller The end-goal is to have the characters processed and not shown.  It might only be possible if Microsoft includes builds this into VSC which is what this "issue" was opened for.  Ideally, it would provide the same result that we get in terminal/ssh with cat. When I cat the file, the ANSI is processed and the characters are not shown.  This allows me to select and copy lines and paste them into a document/email.  With your extension, they are still present, and just changing the character's color to #000 still gets copied into the email. Your extension is better than nothing and I appreciate it, but it only takes care of half of this need.

@JtMotoX How about creating a preview panel similar to the one in the Markdown extension: This preview could render the colored text into a web based view and act like a terminal. This would enable to edit the file as raw data in the editor with basic coloring and have the colored preview shown like in a terminal with interpreted escape codes.

@TobiasFaller Now with that we are getting pretty close to the end-goal.  Would be nice if Microsoft could add that built-in without requiring the Preview pane but your idea is probably as close as we are going to get with an extension.

@JtMotoX I have now written a prototype which looks quite promising. The code needs to be refactored and some bugs are still present, but for a first implementation attempt this seems to work fine.

It didn't work for me on MacOS, I'm not sure what I'm missing.
I installed the plugin, and opened an ANSI encoded github log, selected VT100 in the bottom right corner, but it didn't change any colours at all.

The plugin activation is still buggy. Try to open a second editor and then focus the initial editor view.

@JtMotoX @queglay The extension version 0.0.6 is now available. This version introduces the preview panel and fixes most of the activation problems. It would be nice if you could give feedback.

@TobiasFaller Thank you for building this awesome extension! I tried it out and it works, but in the preview panel the escape characters are still shown. Would you make them hidden in future release as discussed above?

@TobiasFaller Thank you for building this awesome extension! I tried it out and it works, but in the preview panel the escape characters are still shown. Would you make them hidden in future release as discussed above?

@cedrusx I tried to reproduce the problem and implemented an additional filter for the preview. This feature will be in version 0.0.12.

I also found https://github.com/iliazeus/vscode-ansi which removes the escape characteres, so maybe both extensions can be improved from each other

I also found https://github.com/iliazeus/vscode-ansi which removes the escape characteres, so maybe both extensions can be improved from each other

@GaboFDC This extension seems to be quite new and has some interesting additional features, like support for using the theme colors and cancellation tokens for the rendering process. I might add these features to my current extension.

@iliazeus You are welcome if you want to contribute to / copy from the existing plugin at https://github.com/TobiasFaller/vscode-vt100-syntax-highlight.

My solution for this sole issue is sublime text.

And what do you do for diff of two files in Sublime? That was quite annoying in sublime ...

My solution for this sole issue is sublime text.

And what do you do for diff of two files in Sublime? That was quite annoying in sublime ...

There is a lot of good useful converation here. However, please, I would ask that people hold off from saying things such as:

So ... vim community solved that problem in 2004.

no update?????

Anything yet?

can't believe this feature is still not provided 2+ year after it was raised...

meanwhile, so many useless features have gone through the line...

Any status on this? Its very annoying

Also (still) interessted in this feature ...

We really would like this feature. Can't believe nobody has been able to add support for this.

we cry out, in anguish! but in a pile of 5000+ open github issues.. nobody can hear you scream! 😱

My solution for this sole issue is sublime text.

And what do you do for diff of two files in Sublime? That was quite annoying in sublime ...

Here's the problem: such comments don't move the conversation forward. They might be off-topic, impatient, or snarky. In any case, they squander people's valuable time and attention.
So, please, let's work together to reduce the signal to noise ratio, not only in this particular issue but across all of our online discussions. Please think about these recommendations:

Read the entire comment thread first.
As you read the comments, react with emoji to weigh in (e.g. you agree or disagree)
After reading all the comments, if you feel like you have something constructive and informative to contribute, please do.
Remember, the standard is not "I want to vent!" but "Will what I write be of value to others?"

Finally, I would like to thank:

TobiasFaller for the vscode-vt100-syntax-highlight extension.
the others who have given Tobias constructive feedback

There is a lot of good useful converation here. However, please, I would ask that people hold off from saying things such as:

So ... vim community solved that problem in 2004.

no update?????

Anything yet?

can't believe this feature is still not provided 2+ year after it was raised...

meanwhile, so many useless features have gone through the line...

Any status on this? Its very annoying

Also (still) interessted in this feature ...

We really would like this feature. Can't believe nobody has been able to add support for this.

we cry out, in anguish! but in a pile of 5000+ open github issues.. nobody can hear you scream! 😱

My solution for this sole issue is sublime text.

And what do you do for diff of two files in Sublime? That was quite annoying in sublime ...

Here's the problem: such comments don't move the conversation forward. They might be off-topic, impatient, or snarky. In any case, they squander people's valuable time and attention.
So, please, let's work together to reduce the signal to noise ratio, not only in this particular issue but across all of our online discussions. Please think about these recommendations:

Read the entire comment thread first.
As you read the comments, react with emoji to weigh in (e.g. you agree or disagree)
After reading all the comments, if you feel like you have something constructive and informative to contribute, please do.
Remember, the standard is not "I want to vent!" but "Will what I write be of value to others?"

Finally, I would like to thank:

TobiasFaller for the vscode-vt100-syntax-highlight extension.
the others who have given Tobias constructive feedback

Thank you all for the feedback.
Version 1.0.0 of the plugin is now published and should be feature-complete (for now).
If somebody needs an additional feature feel free to open an issue on the plugin's repository page.
(If someone has the skills to create a less ugly icon for the plugin then feel free to create a merge request.)
Repository: Link to github.com
Marketplace: Link to marketplace.visualstudio.com
The following features have now been implemented:

Editor: Color and styling support

Now uses the VS Code terminal theme as default (Idea taken from vscode-ansi plugin)
Colors and style can be fully customized

Editor: Snippets to write escape sequences
Preview: Terminal-like preview of the file

Synchronous scrolling with the editor view

Export: Text export without escape sequences (raw text)
Export: HTML export with rendered escape sequences (colored and styled text)

Uses a fallback color theme as the VS Code API has currently some limitations

Can you configure VSC such that it opens *.log files into VT-100 Preview mode by default?  Since preview doesn't allow you to search, I guess I would prefer a way to open log file in normal editor without escape code, but with color highlighting.  I coude make the escape codes invisible with:
"vt100.escape-sequence": { "opacity": "0.0 !important" },
But that still leaves the spaces where the escape codes would be.

As @bsburns mentions, this still doesn't quite solve the issue because in a long .log file, you can't search yet, which is very important. My current workaround is:

Use VSCode "ANSI Colors" extension
In .log file (command palette): ANSI Text: Open Preview.

It's actually fast and allows you to search... I wish there was a better solution, but this is the best I got.

I fixed it using this thread
https://stackoverflow.com/questions/51680709/colored-text-output-in-powershell-console-using-ansi-vt100-codes

Does this preserve ANSI escape codes including colors when saving to a .txt (Plain Text) file?
Because I feel it should, but when I tested saving and reopening a colored text as .txt file, it wouldn't show colors any more.
The colors are just saved as plain character codes, they should survive being saved as Plain Text.

This is really not an solution, but if you just want to see the logs in colored format for debugging purposes like me. Use "less -r file.log" or "type file.log" in windows.

Can you configure VSC such that it opens *.log files into VT-100 Preview mode by default? Since preview doesn't allow you to search, I guess I would prefer a way to open log file in normal editor without escape code, but with color highlighting. I coude make the escape codes invisible with: "vt100.escape-sequence": { "opacity": "0.0 !important" }, But that still leaves the spaces where the escape codes would be.

@bsburns There is now the option to open the preview for *.log files by default (https://marketplace.visualstudio.com/items?itemName=Tobias-Faller.vt100-syntax-highlighting#open-preview-directly-or-by-default).
In a test build I enabled the search option for the WebPanel preview but it segfaults as soon as the document is switched when a search was active. I'll have to report a few bugs to VS Code before I'll be able to add a convenient search function that ignores escape sequences.

This is really not an solution, but if you just want to see the logs in colored format for debugging purposes like me. Use "less -r file.log" or "type file.log" in windows.

@ReetiMauryaCrest Can you evaluate if the updated plugin contains everything for your use-case? Feedback is appreciated.
https://marketplace.visualstudio.com/items?itemName=Tobias-Faller.vt100-syntax-highlighting#open-preview-directly-or-by-default

@ReetiMauryaCrest Can you evaluate if the updated plugin contains everything for your use-case? Feedback is appreciated. https://marketplace.visualstudio.com/items?itemName=Tobias-Faller.vt100-syntax-highlighting#open-preview-directly-or-by-default

Thank you for the updated extension information. This works great for my usecase, I can now easily see my logs with just one preview click, this helps a lot.

Related on Stack Overflow: Can I display a file with ANSI color escape sequences in Visual Studio Code?
@TobiasFaller you're welcome to write an answer showing the capabilities of your extension and how to use it there. Just make sure that if you do, you follow the rules about self-promotion.

Related on Stack Overflow: Can I display a file with ANSI color escape sequences in Visual Studio Code?
@TobiasFaller you're welcome to write an answer showing the capabilities of your extension and how to use it there. Just make sure that if you do, you follow the rules about self-promotion.

Hello @starball5 ,
thank you for the hint. I have added a comment to the post.
Best regards, Tobias Faller

Hello everybody,
just to gauge the interest: Who is interested in having a stripped-down version of the plugin being integrated into VS Code?
I have seen that basic Markdown rendering and preview is included in VS Code by default.
So my thought was that maybe an VT100 / ANSI color preview could be a similar contribution.
Essentially, my thought is to provide a simple editor extension with a preview button.
This would include the following features / limitations:

Always using terminal theme colors
Only color escape codes for foreground / background, maybe 24bit RGB color support

Is there anything else that could be considered "essential" that I am missing?
Maybe a command to remove all escape sequences?
Should the extension be enabled for "Plain Text" documents by default?
Or should it maybe be a separate language? Maybe named "Terminal" / "VT100 Text" / "ANSI Text"?
I would like to hear some feedback / discussion.
Best Regards,
Tobias Faller

This would include the following features / limitations:

Always using terminal theme colors
Only color escape codes for foreground / background, maybe 24bit RGB color support

Is there anything else that could be considered "essential" that I am missing?

I know this issue is mainly about color code support, but I would also consider other text styling escape codes (bold/italic/etc.) to be "essential" and (nearly) as commonly used as colors.

I'd like to advocate for 24bit color to be included in the MVP of this feature.
I use ansi color output in all of my cli scripts, and I also take advantage of Chrome's console log support for colors. I can say that the difference between the core 16 colors and 24bit is substantial in terms of usability. My logging output uses a color schemes based on VSC dark, and the colors (and associated meanings) are easily distinguishable. Example:

Part of the debugging tool chain only supports 16 colors, so I have a nearest color matching mode. The "nearest" color is often surprisingly different from the 24bit, especially if your input colors aren't very saturated. And to state the obvious, several semantic roles with different colors collapse into the same color, which undermines the purpose of coloring.
As a side benefit, there isn't agreement on what the 16 core colors should be. Being able to rely on 24bit gives you consistent output that is portable output across different ANSI environments.
I'm happy to contribute, if that's helpful.


growing line-height in table

newly inserted record is not as high as existing record.
The padding?

Works for me in Contacts (DB) could be a problem with the content (if that is a content).