Allow mixing translation targets

This could occur when either the source is in two different Paratext projects (one for the NT, one for the OT) that would need to be combined, or for backtranslation projects, two different backtranslations in two different projects.  This may not be common - and should be able to be  combined without mixing, but it may be easiest to just implement like the sources are implemented.

Duplicate of https://github.com/sillsdev/serval/issues/352


forward not working when transform field throwing error

Hi, I have this schema.
import * as v from "valibot";

export const RegisterSchema = v.object(
  {
    name: v.string([
      v.minLength(3, "Username must be at least 3 characters."),
      v.maxLength(32, "Username must be at most 32 characters."),
      v.regex(
        /^[a-zA-Z0-9_.]+$/,
        "Username must contain only letters, numbers, underscores, and dot."
      )
    ]),
    displayName: v.transform(
      v.string([
        v.toTrimmed(),
        v.maxLength(50, "Display name must be at most 50 characters.")
      ]),
      (input) => input || null
    ),
    email: v.string([
      v.email("Invalid email address.")
    ]),
    password: v.string([
      v.minLength(8, "Password must be at least 8 characters."),
      v.maxLength(32, "Password must be at most 32 characters."),
      v.regex(
        /^[a-zA-Z0-9!@#$%^&*()\-=_+[\]{}\\|;:'",./<>? ]+$/,
        "Password must contain only letters, numbers, and special characters."
      )
    ]),
    confirmPassword: v.string()
  },
  [
    v.forward(
      v.custom(input => input.password === input.confirmPassword, "Passwords do not match."),
      ["confirmPassword"]
    )
  ]
);

const input = {
  name: "john_doe",
  displayName: "This Long Name Will Throw Error Because It's Very Long",
  email: "john_doe@mail",
  password: "password123!@#$%",
  confirmPassword: "asd"
};

try {
  const result = v.parse(RegisterSchema, input);
  console.log("Validation passed:", result);
} catch (error) {
  console.error(v.flatten(error.issues).nested);
}

I write displayName like that to convert empty string to null. But it will produce this error.
{
  displayName: [ 'Display name must be at most 50 characters.' ],
  email: [ 'Invalid email address.' ]
}

If I remove the v.transform like this.
displayName: v.string([
  v.toTrimmed(),
  v.maxLength(50, "Display name must be at most 50 characters.")
]),

It will show the v.forward error. But I can't convert the empty string to null.
{
  displayName: [ 'Display name must be at most 50 characters.' ],
  email: [ 'Invalid email address.' ],
  confirmPassword: [ 'Passwords do not match.' ]
}

Is this the intended behavior? If yes, what is the workaround?

Yes, this is the intended behavior at the moment. The reason for this is that transform will mark your data as untyped if there are any issues. If we can't be sure that your data is typed, we can't run custom because we guarantee type safety for the first argument of the passed function. With the rewrite in #502, I will provide a fix for this problem soon.

Cool, I'll wait for the fix

The fix will be a partialCheck function (not implemented yet) that allows you to select the fields you want to validate. As long as these fields are typed, Valibot will perform the validation.


pluginlib: 1.10.7-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository pluginlib to 1.10.7-0:

upstream repository: https://github.com/ros/pluginlib
release repository: https://github.com/ros-gbp/pluginlib-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.2
previous version for package: 1.10.6-0

pluginlib
* Provide a script to convert include statements to use new headers (#108 <https://github.com/ros/pluginlib/issues/108>)
* Provide alternative headers for multi distro support (#106 <https://github.com/ros/pluginlib/issues/106>)
* Contributors: Mikael Arguedas, William Woodall

Holding for synchronized release...


[discover][morethantv] Error searching with morethantv: 1,005.98 MB does not look like a file size

Expected behaviour:
(No error)
Actual behaviour:
2016-10-27 19:20 ERROR    discover      get_series      Error searching with morethantv: 1,005.98 MB does not look like a file size
Steps to reproduce:

Step 1: Find something with decimals and dots? :smile:

Flexget Version: 2.3.xx? Somewhat new

Python Version: 2.7.9

Installation method: pip

OS and version: raspbian, jessie

Link to crash log: none

Was fixed in 2.3.35. DENIED.


normal division & configurable ordering for ArithmeticPostAggregator

Fixes #510

@xvrl Are you still thinking about including this feature?

We talked about implementing this a while back. If there is still interest, any feedback is appreciated.

Fwiw, I'm +1 on the idea, though I think it should be implemented as just another entry on the enum instead of adding all of the extra interface stuff.

@cheddar I simplified it to use just another entry in the enum. If that looks good to everyone, I'll add docs.

Other than my one question about defaults, this LGTM

+1, changes seem good to me

+1


Linter auto-fix everything

Key changes:

Disabled angular eslint plugin. It is broken.
Excluded scripts directory for now. Should it have different linter rules? (e.g. ignore no-console?)

FYI I made a PR to eslint-plugin-angular which will fix our crashing issue.
https://github.com/Gillespie59/eslint-plugin-angular/pull/518


Fix deprecated warnings about setvelocity, etc

I was seeing a lot of this sort of warning.
WARNING[Server]: Call to deprecated function 'setvelocity', please use 'set_velocity' at ...
This commit replaces the following:
setvelocity -> set_velocity
getvelocity -> get_velocity
getyaw -> get_yaw
setyaw -> set_yaw
setacceleration -> set_acceleration

Thanks. I have been planning to do this for a long time. :D


Labels rendering outside of map instead of inside overlay container in angular

Everything else in my marker seems to work but the label/message div renders on the page outside of the maps further up the page. I noticed there is an empty overlay container within the map that is empty. I am guessing this is the node my label/message is supposed to get attached to but doesn't. I get the following error. I read something about the node type being incorrect but don't know how to solve this in angular.
TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
at Pm.k.Ok (ol.js:400)
at Pm.b (ol.js:15)
at Pm.Na.b (ol.js:18)
at Va (ol.js:20)
at Pm.k.set (ol.js:20)
at Pm.k.pi (ol.js:402)
at new Pm (ol.js:399)
at createOverlay (angular-openlayers-directive.min.js:31)
at Object.fn (angular-openlayers-directive.min.js:31)
at Scope.$digest (angular.js:14412)
Code:

(function () {
'use strict';
angular
    .module('app.map', ['openlayers-directive'])
    .controller('MapController', MapController);

MapController.$inject = ['userAPI', '$scope'];
/* @ngInject */
function MapController (userAPI, $scope) {
    var vm = this;
    vm.message = 'This is london';
    console.log($scope);
    console.log(vm);
    angular.extend(vm, {
            center: {
                lat: 51.505,
                lon: -0.09,
                zoom: 15
            },
            marker: {
                lat: 42.880596200000010000,
                lon: -8.544641200000001000,
                label: {
                    id: 'label',
                    message: 'Santiago de Compostela',
                    show: true,
                    showOnMouseOver: true
                }
            }
        });
}

})();
Any suggestions would be appreciated.

Turns out I wasn't using OL3. Solved.


Add option to disable foil cards trades

As I understood from the SteamTradeMatcher option it will accept foil-to-foil trades for dupes, however it isn't an obvious trade. Some foils have much higher price than the rest in the set. Looks at this set for example: http://www.steamcardexchange.net/index.php?gamepage-appid-261700

https://github.com/JustArchi/ArchiSteamFarm/issues/209#issuecomment-214378437

With all due respect, but I do want to auto-trade my normal cards, but don't want to trade my foils unless they are from a relatively cheap sets. In case of rare sets statemet that all foils are the same is simply not true. Yet again, just look at that set. So, I want to accept or decline such trades myself without risk to loose a card which I may want to sell later. I seriously don't want to create separate profile just to keep cards there and I actually want to receive trades for them.  -_-

Considering foils are pretty rare I might just exclude them from STM alltogether, and treat the same way as emoticons or backgrounds. Let's say you convinced me :+1:

Thanks.

Done in https://github.com/JustArchi/ArchiSteamFarm/releases/tag/<IP_ADDRESS>


[Compute] Change default Public IP SKU for "az vm create"

Related command
"az vm create"
When customers associate a public IP (using "--public-ip-address")
to the VM as part of creation without defining a SKU type.
Is your feature request related to a problem? Please describe.
Last year, we announced the retirement of Basic IPs and created a warning message to cx who were using this command of the upcoming changes of this command's default SKU for Public IPs. Now we would like to change the default SKU to Standard as part of the retirement.
Describe the solution you'd like
We want to change the default SKU for Public IP from Basic to Standard IP.
Describe alternatives you've considered
N/A
Additional context
Previous ask where we added the warning message last year - #18662

Thank you for opening this issue, we will look into it.

@cburuzie Do we need to remove the Basic option of --public-ip-sku? Currently, it has 2 options: Basic and Standard.


miss 388: Group of countries, shared code

miss 388: Group of countries, shared code, refer to https://www.itu.int/dms_pub/itu-t/opb/sp/T-SP-E.164C-2011-PDF-E.pdf

This change is

Thanks! However, this file is auto-generated. If you think we are missing a country with this country calling code please file an issue instead and if you're right we'll update the xml file.

@lararennie Thanks.


[BEAM-12254] Change nexmark UnboundedEventSource to always calculate backlog bytes.

Previously it was only done so when rate limited and after events were read.  Since
there is a maximum # of events it is possible to calculate when not rate limited.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @kennknowles


Registry key

I don't think that this was intended?

Code reference here?
Installer/BITSManager.wxs
Line 25
<RegistryValue Root="HKCU" Key="Software/BITSManager" Name="installed" Type="integer" Value="1" KeyPath="yes" />


Validate Google login data

Google's OpenID login process sends user data via a browser GET request. Is this request signed? Is the data tamper proof? If not, the email address provided can no longer be trusted.

Deprecated by #134, Google now requires OAuth.


Development

Final release

El excel
https://docs.google.com/spreadsheets/d/1ltCNEg5oQCfpMkfvuWsDmCuPdFKH4OQ_NNqE1FcYcVM/edit#gid=0


chore: expose PrimeField trait

I missed a trait pub::use for sui to use. this should be the last one 🤞

approving, but do we want to expose fields from other libs directly or wrap them then expose?

yeah thats the other route - decide to expose them for now faster development. we can wrap them in the future


Chunking support

When a large ndarray is stored as binary block with compression, then the (beginning of) the whole block needs to be read and decompressed even when only a small subarray is read. "Chunking" remedies this; instead of storing an ndarray as a single binary block, it is stored as a set of smaller blocks that are compressed and stored independently.
Are there plans to support this? Can this be implemented as extension?
One simple approach would be to introduce a new yaml tag core/chunked-ndarray that consists of a yaml map that maps offsets to ndarrays, for example
chunky: !core/chunked-ndarray-1.0.0
  - !core/ndarray-chunk-1.0.0
    offset: [0,0]
     data: !core/ndarray-1.0.0
       source: ... # the usual ndarray stuff here
  - !core/ndarray-chunk-1.0.0
    offset: [100,0]
     data: !core/ndarray-1.0.0
       source: ... # the usual ndarray stuff here
  - !core/ndarray-chunk-1.0.0
    offset: [0,100]
     data: !core/ndarray-1.0.0
       source: ... # the usual ndarray stuff here
  # possibly more chunks here

Has there been any work in this direction?

Thanks for opening this issue.
There has been some work adding support for the zarr storage format within ASDF. This is implemented via an extension: https://github.com/asdf-format/asdf-zarr It's a new package so please let me know if it's something you plan to use "in production" (so we can give it another review, also feel free to give it a try and open issues if you find anything). The extension offers a few options:

storing the zarr data inside ASDF blocks (with a chunk per block, I think most similar to what you described)
referencing external zarr storage (either DirectoryStore "flat files", S3 stores, or any of the many formats zarr supports).

The use of zarr also opens up a second place where compression can be controlled (which can get a bit confusing).

@braingram Nice! We are currently discussing storage formats, and both ASDF and Zarr are contenders that have various advantages and disadvantages. On the surface, using Zarr chunking with ASDF single-file storage seems like an excellent choice. I will have a look.


Frosted navbar

Changes
I have added  background-color: rgba(255, 255, 255, .15); -webkit-backdrop-filter: blur(5px); backdrop-filter: blur(5px); to .navbar class and removed the .bg-dark-subtle because the .bg-dark-subtle class was overriding the  background-color: rgba(255, 255, 255, .15) css

Changes
Removed border and border-dark classes and changed the bg-color of navbar

Changes
Changed searchbar placeholder and bottom border to white.
Increased blur effect of navbar.
Let me know if there's any modifications if required


Coverity fixes

Fixing issues:

1545174: calling risky function
1545175: use after free
1545176: dereference before NULL check

This needs to go to 3.1 after #22210

This pull request is ready to merge

This seems to be merged now. Closing.

Actually still needs to be merged to 3.1 after the fips rng backport

Merged to 3.1


VSI submission: redirect terminal input through socket

This is needed, because on VMS, select() can only be used on sockets.  being
able to use select() on all kinds of file descriptors is unique to Unix.
So, the solution for VMS is to create a layer that translates input from
standard input to socket communication.

This fixes a bug that's been around on VMS since the dawn of time.  CompHP has had this fix for quite some time, but it's not before VSI took over VMS development that we got this feedback.
Note that I will make a PR for 1.0.2 as well.

I think the code in apps/s_client can be simplified -- i.e., fewer ifdefs -- by makefile fileno_stdin variable the same as fileno(stdin) on non-vms.

and maybe have raw_read_stdin take the fileno/stdin param and put only the vms-specific IFDEF in that utility function and not in all places that call it.

Sure.  Will look it over with simplification in mind.

So I did some refactoring in the 1.0.2 variant (#1577), see if you like that better.

+1 nice.

Added a couple of fixups. Two bugs and the formatting that @dot-asm asked for are included.
Reconfirm?

Yes from me

Do fix -Werror=missing-prototypes in --strict-warnings first :-)

Errr, what the hell????
../master/apps/apps.c:2322:5: error: no previous prototype for 'fileno_stdin' [-Werror=missing-prototypes]
 int fileno_stdin()
     ^~~~~~~~~~~~
../master/apps/apps.c:2328:5: error: no previous prototype for 'fileno_stdout'  -Werror=missing-prototypes]
 int fileno_stdout()
     ^~~~~~~~~~~~~

But...  those functions are declared, in apps.h!  And if I do a -E compile and check the output, it does show the declarations before the definitions of those functions.  I must be running blind.  Please help?

But... those functions are declared, in apps.h!

Yeah... Except that declaration should be int fileno_stdin(void);. Yeah, it's essentially ridiculous...

Aaargh...

Okie, issue fixed, both here and in #1577

Seconded.

Merged


authenticate the correct key so bonds can endure across esp32 resets (IDFGH-2879)

Hi,
This is an attempt to resolve #2036 which caused a bonded esp32 to incorrectly set characteristic permissions with ENC_MITM set after a reset. The incorrect key sec_level was checked, so the BTM_SEC_LE_LINK_KEY_AUTHED bit was never set in the security flags. I had the same problem described in #2036 and this appeared to fix it.
Thanks,
Tom

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Weijian-Espressif

This should be closed since the fix is already in https://github.com/espressif/esp-idf/commit/163dbc32007c5f2afc8ada81ed6371fce20c7774.

@AxelLin Thanks for the reminder. @tomx4096 Thanks for your contribution again, changes have been merged with https://github.com/espressif/esp-idf/commit/163dbc32007c5f2afc8ada81ed6371fce20c7774.


Can't VV Station Entity from admin panel

Description
I don't know if there was ever an issue made about this, but the station entity (I think that's what it is at least) just never loads, and will eternally say "Waiting on server..."
Screenshots

The admin panel needs to be updated to use net-entities instead of EntityUids


Holiday calendars from Reference data

With this PR, holiday calendars are resolved from ReferenceData instead of at startup via an extended enum. This allows holiday calendar data to be altered and managed more dynamically. The standard holiday calendars can still be accessed by passing ReferenceData.standard() where necessary.

the "expanded" trade model concept has been renamed to "resolved"
most asset classes have 4 key classes - FraTrade holding Fra, and ResolvedFraTrade holiding ResolvedFra
Unresolved trades, indices and conventions refer to holidays using HolidayCalendarId
conversion from the unresolved to the resolved form requires reference data and performs as much date logic as possible (resolution converts HolidayCalendarId to HolidayCalendar)
market data is looked up using index observation objects, with pre-calculated dates

The overall design now has three lifecycle phases for trades

Conventions and Templates, as seen in CurveNode
Unresolved trades, the standard application definition of a trade
Resolved trades, low level form for pricing

Conversion between phase 1 and 2 uses reference data to calculate the spot date from the trade date. Conversion between phase 2 and 3 uses reference data to lock all the dates for pricing.
Future work will remove the SecurityLink concept, with securities also being resolved from reference data.

Reviewed in person with @jodastephen and @cjkent. Performance impact verified as acceptable with nightly benchmarks.


Hack around weird double scrollbar bug

This PR applies a custom max-height to the wizard body container in order to prevent there ever being "double scrollbars" where two nested containers both have overflowing content relative to their height. See https://github.com/konveyor/forklift-ui/issues/550 for a description of the bug. The arbitrary 286px in the calculation is the total height of the app header, page section header, and wizard footer which are all static heights.
We need to remove this custom CSS and find the real solution to the bug it works around. Capturing that in https://github.com/konveyor/forklift-ui/issues/550.

@vconzola that's correct. The page grows in height to match the height of the entire menu in the dropdown so that you can scroll to the bottom. The limitation is on the height of the container around that because something weird is going on with its padding. The second scrollbar should never appear no matter how many namespaces and no matter the size of the window.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-10-13)
Features

add few classes and interfaces (BasaltToken, KeyGenerator) (9a8c3b9)
Initialising the project (b34c19e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-auth/releases/tag/v1.0.0 :sunflower:


🐛 translation sentense is not reflected

Describe the bug
Translation sentense is not reflected.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://pyvista-doc.readthedocs.io/ja/latest/optional_features.html'

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Translation words is not reflected to po file.
https://github.com/tkoyama010/pyvista-doc-translations/blob/e5d26236160c169de0dc98cd173d7cf03b5eea78/locale/ja/LC_MESSAGES/optional_features.po#L20-L22

Translation words is not reflected to po file.
https://github.com/tkoyama010/pyvista-doc-translations/blob/e5d26236160c169de0dc98cd173d7cf03b5eea78/locale/ja/LC_MESSAGES/optional_features.po#L20-L22


[Feature Request] uploader Promise

Existing Component
Yes
Component Name
uploader
Description
Make uploader.submit  Promise

Sorry, we have no plan to support this.


47 improve and test kni packages

Improve test utilities
Improve KNI test
fix #51

The WIP commit is removed


Update ID scraper to use state's new URL

Closes #644

Looks like these changes were superseded in #656. Closing.


Add support for new Projects Preview API

See blog post for more information:
https://developer.github.com/changes/2016-09-14-projects-api/

While implementing this new feature, I found a few problems with the API.
I contacted GitHub Support and am waiting to hear back from them before starting a PR, as their API and documentation may change as a result.

Here is the thread: https://platform.github.community/t/a-few-issues-ive-had-with-the-projects-preview-api/531

I received great support (as usual) from GitHub... thank you, @bswinnerton!
@shurcooL - this is ready to review whenever you have time.  There is no rush, and this one is rather large... I apologize for the size of it.


Feature: Custom Styles Per Annotation

Moved to https://github.com/Secretmapper/react-image-annotation/pull/46


Step 9 - Typo

Hi!
There might be a typo in the word operating system in Step 9:
Current: [...] can be destroyed by the operative system and recreated [...]
Fixed: [...] can be destroyed by the operating system and recreated [...]
Thanks!

Fixed. Thanks for reporting


Fix incorrect link to wtype, add Qutebrowser, Waybar

Fixed link to wtype (https://sr.ht/~kennylevinsen/greetd/ -> https://github.com/atx/wtype)
Added Qutebrowser to the 'Web Browsers' section.
Added Waybar to the 'Status Bars' section.

Very nice. Thanks.


Enhancement: RenameVariables transformer

We have a requirement to bulk-replace variables, and wondered if we can leverage Robotidy for this.. Simplified test case shown below, our goal would be to replace the variables OLD_SCALAR by NEW_SCALAR, OLD by NEW, OLD_DICT by NEW_DICT, and also OLD_DICT_2 by NEW_DICT_2, but also its keys old_key1 by new_key1.. Obviously this example could also be achieved through regexp substitution, but we would like to explore if Robotidy could do it "better" and "more robust" than a potentially complex regexp.
Really appreciate you looking into this!

*** Test Cases ***
Test
    Import Variables    ${CURDIR}/vars.yaml
    Log Variables
    FOR   ${var}   IN   @{OLD}
        Log   ${var}
    END

    Should Be True   ${OLD_SCALAR}
    Should Be True   ${OLD}
    Should be True   ${OLD}[1]
    Should be True   ${OLD_DICT.a}
    Should be True   ${OLD_DICT}[a]
    Should be True   ${OLD_DICT_2.old_key1}
    Should be True   ${OLD_DICT_2}[old_key1]

    Do something with ${OLD}
    Do something with ${OLD}[1]
    Do something with ${OLD_DICT.a}
    Do something with ${OLD_DICT}[a]
    Do something with ${OLD_DICT_2.old_key1}
    Do something with ${OLD_DICT_2}[old_key1]

*** Keywords ***
Do something with ${var}
    Log   ${var}

vars.yaml content:
OLD_SCALAR: 1

OLD:
- 1
- 2
- 3

OLD_DICT:
  a: 1
  b: 1
  c: 1

OLD_DICT_2:
  old_key1: 1
  old_key2: 2

I apologize for the late reply. This feature wasn't possible before but now with #502 in open PRs we will have all tools available to implement it (new transformer is named RenameVariables but does not rename it like you want, just normalize the name and the scope of variable). After this time you probably don't need it anymore but it may be useful in the future (and also for the others) so I will work on that in the future releases.
It will work similarly to RenameKeywords/RenameTestCases. However I'm thinking about adding reading from the file to allow bulk renaming.
You mentioned vars.yaml file, do you also expect to have your variables renamed here? It could be more tricky than just renaming variables in the robot files.

Hi @bhirsz ! Thanks for getting back to me.. I am still looking for this capability, so still looking forward to it ;-)
I only included the vars.yaml to illustrate what the variable values for my examples would be.. Of course I would not expect tidy to touch .yaml files ;-)


"wlr-layer-shell-unstable-v1-protocol.h"  not found

I wanted to start working on a compositor by forking rootston and using my own Makefile. However, rootston includes <wlr/types/wlr_layer_shell.h> which in turn includes "wlr-layer-shell-unstable-v1-protocol.h". It also gives an error message saying I should add -DWLR_USE_UNSTABLE, but it is unclear to me where I should add that.

You need to integrate wayland-scanner with your build system to compile xml files to protocol headers and put them in your include path. How you specify -DWLR_USE_UNSTABLE also depends on your build system, this is a flag you must pass to your C compiler.

Side note: if this is your project you might consider joining forces with bspwc.


bug report~~code error

Hi brocaar, there must be a code error in fhdr.go:
func (c *FCtrl) UnmarshalBinary(data []byte) error {
if len(data) != 1 {
return errors.New("lorawan: 1 byte of data is expected")
}
c.fOptsLen = data[0] & ((1 << 3) ^ (1 << 2) ^ (1 << 1) ^ (1 << 0))
c.FPending = data[0]&(1<<4) > 0
c.ACK = data[0]&(1<<5) > 0
c.ADRACKReq = data[0]&(1<<6) > 0
c.ADR = data[0]&(1<<7) > 0
return nil
}
it should be:
func (c *FCtrl) UnmarshalBinary(data []byte) error {
if len(data) != 1 {
return errors.New("lorawan: 1 byte of data is expected")
}
c.fOptsLen = data[0] & ((1 << 3) ^ (1 << 2) ^ (1 << 1) ^ (1 << 0))
c.FPending = (data[0]&(1<<4)) > 0
c.ACK = (data[0]&(1<<5)) > 0
c.ADRACKReq = (data[0]&(1<<6)) > 0
c.ADR = (data[0]&(1<<7)) > 0
return nil
}

In C/C++, this seems to be a bug
but in go, it is not，  why?

Well, Go isn't C/C++ ;-) Anway if you think the behaviour is incorrect, could you open an issue at https://github.com/brocaar/lorawan (that is the repo for the lorawan package)?
There are tests too to validate the behaviour of this code:
https://github.com/brocaar/lorawan/blob/master/fhdr_test.go#L72

@yzk0281 do you need more input on this / do you still think this is a bug? Can this issue be closed else?


Fix wrong denormalization context for related resources

Fixes #303

Could you add tests? That way we are sure not to break it again :)

Can't say I didn't see that coming! ;)
Will do when I can find the time to...

As it's an annoying issue I think it can be merged without tests (but test are necessary and must be added after).
What do you think?

@teohhanhui if you are not available yet to write the test, could you just rebase your branch first?

Thank you @teohhanhui, waiting for the test as well :)


Switch to groups for role based outbound provisioning

This issue is a subtask of #11327, thus continues the discussion from there
Currently, role-based outbound provisioning is based on certain roles. This needs to be switched to groups.
For example, say there exists a group named accountants. If the user john is assigned to the accountants group, john should be outbound provisioned.
Tasks

[x] List down groups in the outbound provisioning roles section and change the title of the section to groups based on the b/c config option.
[x] Fix backend validation to be based on the wso2.groups claim.
[x] Fix internal implementation of outbound provisioning to use wso2.groups.

No need to do internal code changes as groups are a subset of roles in the current implementation. From the console app, we will only allow adding groups as the provisioning role and change the headings to reflect the groups term.

Fix mgt console headings

Review comments:

[ ] Change mgt console UI naming from role to group


[BugFix] fix projection been uncorrected rewritten

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
For SQL
with cte_1 as (
    select
        t0.P_NAME as a,
        t0.P_BRAND as b,
        t1.s_name as c,
        t1.s_address as d,
        t1.s_address as e,
        t1.s_nationkey as f
    from
        part_v2 t0
        left join supplier_nullable t1 on t0.P_SIZE > t1.s_suppkey
)
select
    if(
        cte_1.d in ('hz', 'bj'),
        cte_1.b,
        if (cte_1.e in ('hz'), 1035, cte_1.f)
    ),
    count(distinct if(cte_1.c = '', cte_1.e, null))
from
    cte_1
group by
    if(
        cte_1.d in ('hz', 'bj'),
        cte_1.b,
        if (cte_1.e in ('hz'), 1035, cte_1.f)
    );

Error Message:
java.lang.NullPointerException
	at com.starrocks.sql.plan.ScalarOperatorToExpr$Formatter.visitVariableReference(ScalarOperatorToExpr.java:169)
	at com.starrocks.sql.plan.ScalarOperatorToExpr$Formatter.visitVariableReference(ScalarOperatorToExpr.java:129)
	at com.starrocks.sql.optimizer.operator.scalar.ColumnRefOperator.accept(ColumnRefOperator.java:124)
	at com.starrocks.sql.plan.ScalarOperatorToExpr.buildExecExpression(ScalarOperatorToExpr.java:96)
	at com.starrocks.sql.plan.ScalarOperatorToExpr$Formatter.lambda$visitCall$2(ScalarOperatorToExpr.java:522)
	at com.starrocks.sql.plan.ScalarOperatorToExpr$Formatter.visitCall(ScalarOperatorToExpr.java:523)
	at com.starrocks.sql.plan.ScalarOperatorToExpr$Formatter.visitCall(ScalarOperatorToExpr.java:129)
	at com.starrocks.sql.optimizer.operator.scalar.CallOperator.accept(CallOperator.java:203)
	at com.starrocks.sql.plan.ScalarOperatorToExpr.buildExecExpression(ScalarOperatorToExpr.java:96)
	at com.starrocks.sql.plan.PlanFragmentBuilder$PhysicalPlanTranslator.buildProjectNode(PlanFragmentBuilder.java:530)

SQL
with cte_1 as (
    select
        t0.P_NAME as a,
        t0.P_BRAND as b,
        t1.s_name as c,
        t1.s_address as d,
        t1.s_address as e,
        t1.s_nationkey as f
    from
        part_v2 t0
        left join supplier_nullable t1 on t0.P_SIZE > t1.s_suppkey
)
select
    cte_1.b,
    if(
        cte_1.d in ('hz', 'bj'),
        cte_1.b,
        if (cte_1.e in ('hz'), 1035, cte_1.f)
    ),
    count(distinct if(cte_1.c = '', cte_1.e, null))
from
    cte_1
group by
    cte_1.b,
    if(
        cte_1.d in ('hz', 'bj'),
        cte_1.b,
        if (cte_1.e in ('hz'), 1035, cte_1.f)
    );

Error message
java.lang.IllegalStateException: cols {22} have been encoded, but operator [if(31: S_ADDRESS IN (hz, bj), 22: P_BRAND, cast(if(31: S_ADDRESS = hz, 1035, 32: S_NATIONKEY) as varchar))] doesn't support encode optimize

Problem Summary(Required) ：

When the operator has cols been encoded, we need rewrite its projection. The below codes shows the three branch:

add a decode node before the projection
rewrite the whloe projection using dict cols
do nothing

if (projectionNeedDecode(context, projection)) {
    ....
} else if (projection.couldApplyStringDict(stringColumnIds)) {
    ....
} else {
    context.clear();
}

While the projectionNeedDecode(context, projection) method used context.allStringColumnIds to evaluate whether all these scalarOperators can be rewrited and the projection.couldApplyStringDict(stringColumnIds) just consider whether there exists a scalarOperator can be rewrited. So it has three problems:

using context.allStringColumnIds amplifies the optimization range because not all string cols have been encoded. This leads some decode node not being added.
the projection.couldApplyStringDict(stringColumnIds) is too relax, which also leads some decode node not being added.
the couldApplyDictOptimize(operator, encodedStringCols) been invoked many times in this process which is not efficient.

So I reorganized the logic of rewriting the projection

if the projection don't use cols from encoded cols, just return
evaluate the projection whether can be rewrited. All entries in the projection should meet the belowing requirments
1. if it's a pass-through entry like col1 -> col1, we don't care it.
2. scalarOperator don't ref cols from encoded string cols, we don't care it
3. scalarOperator ref cols from encoded string cols  should meet these requirements:
a. all these dict cols of these encoded string cols exist in the global dict
b. can gain benefit from the optimization (couldApplyDictOptimize(operator, encodedStringCols) return true)
If the above two conditions are not met, add decode nodes to ensure correctness.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[ ] 2.3

@Mergifyio backport branch-2.4


MapOutline failed: checkVersion is not defined

Trying to run MapOutline and get the following error below:

Meant to post on ArcPro repo. Will update and post there.


Missing FR key configuration_sconfig_country

1. Why is this change necessary?
In order to show the good label instead of "configuration_sconfig_country"
2. What does this change do, exactly?
add the translation + the key
3. Describe each step to reproduce the issue or behaviour.
use the install wizard in French
https://files.slack.com/files-pri/T011TTK0DMK-F017KN0MEDP/bug.png
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9975
Please use this issue to track the state of your pull request.

Thanks for your contribution :-) @powolnymarcel


Update modal opened when multiple cells are selected

When multiple cells (items, lists) are selected and the user selects "Add [Item|List]", the update modal opens for the first item selected. The only time that modal should open is when 1 cell is selected.
Pseudocode fix:
If 1 cell is selected: open update modal
else: open add modal

Commit: https://github.com/johneastman/todo/commit/ffa09209ed65dfab56377176002639d86129fe76


Docker-in-Docker will not run on Linux

VSCode Version: 1.60.1
Local OS Version: Arch Linux 5.14.3-arch1-1
Reproduces in: Remote - Containers
Name of Dev Container Definition with Issue: docker-in-docker

Steps to Reproduce:

Add Docker-In-Docker to my project folder.
Try to build.
Error occurs.

 I did not modify the config in any way, as I wanted to make sure I could get the plain version working before I tried to modify it.
Here is my docker version output.
Client:
 Version:           20.10.8
 API version:       1.41
 Go version:        go1.16.6
 Git commit:        3967b7d28e
 Built:             Wed Aug  4 10:59:01 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.8
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.16.6
  Git commit:       75249d88bc
  Built:            Wed Aug  4 10:58:48 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.5.5
  GitCommit:        72cec4be58a9eb6b2910f5d10f1c01ca47d231c0.m
 runc:
  Version:          1.0.2
  GitCommit:        v1.0.2-0-g52b36a2d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

@chand1012 I can't speak to Arch, but GitHub Codespaces runs on Ubuntu VMs where this works, so I know the issue is not with general Linux support.
See if the standard docker provided docker-in-docker image works in your setup: https://hub.docker.com/_/docker

One other troubleshooting step you can take is to comment out the ENTRYPOINT line in the Dockerfile and then run dockerd in a terminal once you've connected to see what errors you see.  I suspect you'll see permission errors.

I commented out the line that starts dockerd, rebuilt, and got the same error.
https://github.com/microsoft/vscode-dev-containers/blob/c98c0bc120af58933f8d168cc604fddf1499fab9/containers/docker-in-docker/.devcontainer/library-scripts/docker-in-docker-debian.sh#L227
The official nested docker image isn't going to be the best for my (and my team's) development environment since the tools we use aren't supported in Alpine Linux. I did try to get it running but couldn't as there were permission errors (even though I was root in the container).
WARN[2021-09-16T19:00:19.399445306Z] Running iptables --wait -t nat -L -n failed with message: `iptables v1.8.7 (legacy): can't initialize iptables table `nat': Permission denied (you must be root)
Perhaps iptables or your kernel needs to be upgraded.`, error: exit status 3
WARN[2021-09-16T19:00:19.399483841Z] Failed to find ip6tables: exec: "ip6tables": executable file not found in $PATH
INFO[2021-09-16T19:00:19.404400393Z] stopping event stream following graceful shutdown  error="<nil>" module=libcontainerd namespace=moby
INFO[2021-09-16T19:00:19.404539980Z] stopping healthcheck following graceful shutdown  module=libcontainerd
INFO[2021-09-16T19:00:19.404543510Z] stopping event stream following graceful shutdown  error="context canceled" module=libcontainerd namespace=plugins.moby
WARN[2021-09-16T19:00:20.405301576Z] grpc: addrConn.createTransport failed to connect to {unix:///var/run/docker/containerd/containerd.sock  <nil> 0 <nil>}. Err :connection error: desc = "transport: Error while dialing dial unix:///var/run/docker/containerd/containerd.sock: timeout". Reconnecting...  module=grpc
failed to start daemon: Error initializing network controller: error obtaining controller instance: failed to create NAT chain DOCKER: iptables failed: iptables -t nat -N DOCKER: iptables v1.8.7 (legacy): can't initialize iptables table `nat': Permission denied (you must be root)
Perhaps iptables or your kernel needs to be upgraded.
 (exit status 3)

I tried to run the codespaces-linux image as well and again got the same error that I initially posted. I'm 90% sure that my Docker is running as root but how can I check to be sure? There's no mention of a user in the systemd unit file.

Yeah the docker image was just to verify it still fails. That tells you it's a config problem rather than an issue with this script.
If you've alredy downloaded the huge codespaces image, run:
docker run -it --rm --init --privileged mcr.microsoft.com/vscode/devcontainers/universal bash
and see if it outputs any errors - like complaining about access.
This likely is the real error:
 Running iptables --wait -t nat -L -n failed with message: `iptables v1.8.7 (legacy): can't initialize iptables table `nat': Permission denied (you must be root)
Perhaps iptables or your kernel needs to be upgraded.`, error: exit status 3

One place I've seen those kinds errors is if you're using a x86 image on emulated on arm64 (or vice versea). It can also happen if iptables isn't in the kernel, Arch seems to have it in it by default: https://wiki.archlinux.org/title/Iptables
You could also see it if you're not specifying --init and --privileged from the command line, but the docker-in-docker definition does that.
You'd only be rootless if you set it up that way (using  docker-rootless-extras-bin as explained here https://wiki.archlinux.org/title/Docker)
Arch is highly flexible - so it's a bit hard to know what is going on.

This is the output of the above command.
[chandler@Desktop-Arch ~]$ docker run -it --rm --init --privileged mcr.microsoft.com/vscode/devcontainers/universal bash
Unable to find image 'mcr.microsoft.com/vscode/devcontainers/universal:latest' locally
latest: Pulling from vscode/devcontainers/universal
Digest: sha256:b749ad2fdcaa78c4958a053af36f423194a640facbebc5b3250eb3c0eaaf5b1f
Status: Downloaded newer image for mcr.microsoft.com/vscode/devcontainers/universal:latest
/usr/local/share/docker-init.sh: line 45: /sys/fs/cgroup/init/cgroup.procs: Permission denied

I did double check to make sure I have the correct iptables version, and I have the same one that some of the other containers had.
[chandler@Desktop-Arch ~]$ iptables --version
iptables v1.8.7 (legacy)

And I did install the recommended Docker Arch Linux package when I got Docker up and running (not rootless).

I have same problem in fedora 35.

image: mcr.microsoft.com/vscode/devcontainers/universal:1-focal
vscode log: container stopped, Error response from daemon
container log: /usr/local/share/docker-init.sh: line 45: /sys/fs/cgroup/init/cgroup.procs: Permission denied

@chand1012 I may have stumbled upon a possible cause. There is an updated version of the docker-in-docker script that may fix this problem. Grab the latest docker-in-docker script to see if that works for you.
@hihanley Try the current development version of the codespaces image to see if it resolves your problem: mcr.microsoft.com/vscode/devcontainers/universal:dev-focal
//cc: @chrmarti @joshspicer as FYI
/cc: @joshspicer

Hi, I've got the same problem as I upgraded to Ubuntu 21.10 (on 21.04 I had docker installed with snap)

@Chuxel Thanks! mcr.microsoft.com/vscode/devcontainers/universal:dev-focal is worked.

@Chuxel I just copied the newest code from https://github.com/microsoft/vscode-dev-containers/blob/main/containers/docker-in-docker/.devcontainer/library-scripts and it worked for me too

Great!  I'll close this as resolved and we'll get this deployed with the next update.

Worked for me as well. Thanks!
On Fri, Nov 12, 2021, 9:35 AM Chuck Lantz @.***> wrote:

Great! I'll close this as resolved and we'll get this deployed with the
next update.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-dev-containers/issues/1054#issuecomment-967163979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA23YLWBYY5K3FVIR4FURVTULUQ3BANCNFSM5EFGHZSQ
.


How to compile facil.io

Hi,
i'm not sure, how to compile facil.io,because on your docs any point about this,
[root@raminfp facil.io]# ls
CHANGELOG.md  CMakeLists.txt  dev  docs  Doxyfile  examples  lib  LICENSE  makefile  NOTICE  README.md  scripts  tests
[root@raminfp facil.io]#
[root@raminfp facil.io]# make
Assembler messages:
Fatal error: can't create tmp/./lib/core/defer.o: No such file or directory
makefile:114: recipe for target 'tmp/./lib/core/defer.o' failed
make: *** [tmp/./lib/core/defer.o] Error 1

please help for it,
Thanks,
Ramin

Hi Ramon,
Thanks for pointing this out!
I'm away from the computer, I'll write more later.
Try running make clean to build the folder structure before running make run.
facil.io is a source code library. Theoretically I assumed people would just copy the features they're using into their own project.
B.

Hi @raminfp ,
Thanks again for opening this issue!
I've updated the README to reflect your question. It reads:

facil.io is a source code library, so it's possible to simply copy the source code into a new project.
facil.io also supports both git and CMake submodules.
However, when starting a new project, it's often easiest to simply fork this project and place your own source code in the dev folder, perhaps updating the makefile to make it more compatible with your project's folder structure.
When forking this project, please run make clean to build the tmp folder structure used for compiling. Unless make clean is called, the compiler / linker will fail with a No such file or directory error.

@boazsegev Your Welcome, Thanks for repo!

@raminfp ,
You're welcome 😊
Just a quick note: I noted you're using the version in the master (development) branch.
Although this is the edge version with the most fixes and effort put into it... it isn't stable.
I should probably change the branching scheme as facil.io evolves, since I also push commits to backup my work, which means some things in the master branch might suddenly break as I'm rewriting them (or while I rewrite some other part and didn't test the changes yet).
Once version 0.5.0 is released (the upcoming release), I recommend that you consider using the stable releases (tagged) instead.
B.

@boazsegev sure,Thank you so much, i see your code (libs) very interesting and i use your libs :) , so i was unable to find you twitter do you have twitter account?
Thanks,

@raminfp , I'm happy you're enjoying the libraries.
My twitter account is @bowildmusic ... I'm a musician and I don't really use my Twitter account for anything. I hope I'll use it more often in the future :-)

OMG, Interesting! You have time for programming and music! Excellent talent!

No time... just tons of sleepless nights doing both things that I love :-)
I'm just  dropping a note to let you know I finished fixing up and releasing version 0.5.0. You'll also find a stable branch was created.

Thank you so much @boazsegev

No time... just tons of sleepless nights doing both things that I love :-)

Nice job, good luck 👍
Best Regards,


Logo (for NuGet, documentation, etc.)

Noticed that logo is mentioned in #51 - just had a quick play with something like the attached. If you think it's suitable I can submit a PR with image..

I definitely like the simplicity of it. @Haacked do you know if the official ruby lib has a logo we should adapt for the c# port?

@davezych I'll look into it.

@jason-roberts I like it! Would you state in your PR that you're assigning rights to the image to GitHub, Inc.?

@Haacked done... also included the SVG version so the project can edit in the future if required

Hey all, just to close the loop on this. I talked to our creative team and while we liked the microscope idea,  we realized it didn't capture what the scientist library is about. In part, it's not about zooming in on something, it's about comparing two things (control and experiment).
So we went with something a bit more evocative of that.

256 x 256

128 x 128

64 x 64

Thanks @jason-roberts! We didn't end up using what you created, but I appreciate the work anyways. It helped inspire us to where we ended up.

No worries @Haacked  - I like the new one :)


Performance issues related to Dexie.Observable meta tables

Hello Dexie devs!
First of all, thank you for this amazing library. I have been implementing the Dexie RxJs addon which uses Dexie.Observable to detect changes. The main issue I am running into is that I am noticing a slowndown in performance in my application when query'ing a bunch of data.  I've been reading up on the well documented documentation you have been writing and noticed you mention this performance case (https://dexie.org/docs/Observable/Dexie.Observable) being related to the meta tables (_changes, _intercomm, _syncNodes, _uncommitedChanges).
Doing some extra digging to figure out how the meta tables behave, it seems the _changes tables contains a row for each old row being deleted aswell as the new one being added. So from my naive testing, it seems that if you were to replace all data in all of your tables, this _changes table would have double the amount of rows of all your data because of having the old and the new values for each data piece.  It does clean itself up though over time. Feel free to correct me if I am wrong on any of this, I am just trying to understand the behaviour. 😄
Going back to the performance issue, I believe it stems from indexedDb growing large in size because of the _changes table becoming large. So in my case, the documentation recommends me to avoid using the Dexie RxJs addon and use liveQuery instead together with rxjs from operator to turn the dexie obserable into an rxjs obserable and have access to pipe functionality. I was wondering if there was an alternative way to avoid indexedDb growing in size/_changes becoming large other than refactoring the codebase? Perhaps a way to manually clearing the _changes table or avoid putting data into it? The rows are probably needed in the _changes table to do the whole update mechanic, but I will ask naively just in case. Or do you see the only solution to this issue being the usage of liveQuery?
Thank you so much again!

Hi and thanks! Dexie.Observable tracks changes and stores every change into the _changes table. This was developed many years ago as a basis for Dexie.Syncable - who needed the changes to be persisted. Even though these addons are still supported also in dexie@4, I would not recommend to use Dexie.Observable as it does much more than needed for just the purpose of observing changes.
Don't know too much about dexie-rxjs-addon but looking at its README, it seems that it provides a way to return an Observable from a query instead of a promise. This is a subset of what liveQuery provides. I think that the dexie-rxjs-addon could be rewritten to use liveQuery to provide its APIs and would then be much optimised - both in performance and storage size.
For example, turning a dexie Table or Collection into an observable would be done as follows:
import { liveQuery, Collection, Table } from 'dexie';
import { from, Observable } from 'rxjs';

function observe<T>(collectionOrTable: Collection<T> | Table<T>): Observable<T[]> {
   return from(
      liveQuery(
        () => collectionOrTable.toArray()
      )
    );
}

To use it:
const o = observe(db.friends.where('age').below(100));
o.pipe(
  filter(...),
  map(...)
)

Don't know how much work it would be to convert your codebase but maybe you could mimic what the addon does and create extended properties and methods the same way on the db instance - then you'd get the same API surface.

Appreciate the quick response dfahlander! You are right in your assessment that the dexie rxjs addon could be optimized with the usage of liveQuery. I also appreciate the insight into how the meta tables function, it was a bit difficult to find information on these meta tables 😄
I will look into making use of the liveQuery to solve my performance problems, as it seems to be the longterm best solution rather than figuring out some quick bandaid fix.
Thanks a lot again, have a nice day!

This is a pitfall of dexie, or rather of indexedDB itself. It is simply slow.
In my experience, it's nice to use dexie to manage indexedDB and it's actually a very good library, but it's not a good idea to treat it as a state manager. In our project, after several approaches we finally built a mechanism that caches responses from inexedDb and revalidates the data in the background.
This allows you to take advantage of all the benefits of dexie and at the same time maintain good performance.
The mindset we have developed at the moment is to use indexedDb like a normal database or external API.
I think that if you are using dexie with high frequency (e.g. filling out a large controlled form that you save directly to indexedDB using dexie) then you will not achieve good performance without an additional caching layer.


Fix NodePath::slice() incorrect behavior for subname indexing

Following GDScript code:
var path = NodePath("Parent/Child:prop:subprop")
print("slice(0, 1): ", path.slice(0, 1))
print("slice(1, 2): ", path.slice(1, 2))
print("slice(2, 3): ", path.slice(2, 3))
print("slice(3, 4): ", path.slice(3, 4))
print("slice(4, 5): ", path.slice(4, 5))
print("slice(-1):   ", path.slice(-1))
print("slice(-2):   ", path.slice(-2))
print("slice(-3):   ", path.slice(-3))
print("slice(-4):   ", path.slice(-4))

Behavior on master:
slice(0, 1): Parent
slice(1, 2): Child
slice(2, 3): :prop
slice(3, 4): :prop:subprop     <---
slice(4, 5): :subprop          <---

slice(-1):   :prop:subprop     <---
slice(-2):   :prop:subprop
slice(-3):   Child:prop:subprop
slice(-4):   Parent/Child:prop:subprop

I believe the 3 marked results are not intended.
Behavior after this PR:
slice(0, 1): Parent
slice(1, 2): Child
slice(2, 3): :prop
slice(3, 4): :subprop
slice(4, 5):

slice(-1):   :subprop
slice(-2):   :prop:subprop
slice(-3):   Child:prop:subprop
slice(-4):   Parent/Child:prop:subprop

I updated the unit tests to include 2 subnames, which reveals the problem.

Previously this test existed:

"Slicing on the length of the path should return the last entry."

But this is unintuitive, the last valid index in arrays is always size-1, not size. At least it's not clear to me why one would want this behavior, and it makes iterating through slices non-continuous. So I changed the test, but let me know if there was a reason for this.

This was added in https://github.com/godotengine/godot/pull/81822 so it may be nice to hear @nlupugla 's opinion as well.

Thanks for finding and fixing this! I haven't had a chance to carefully ponder your changes yet, but as far as the reasoning goes, my intention was for the nodepath slice method to have similar indexing behavior to arrays. So I agree with you that slicing on the last index should actually return empty and the last - 1 should return the last part of the path. Your output looks much more reasonable after your fix :)


Build from source dependencies warnings (Windows10)

[X] I've looked at the documentation to make sure the behavior is documented and expected
[X] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[X] I've searched through the issues to make sure it's not yet reported

Steps to reproduce
Steps to reproduce the behavior:
Follow instructions for performing a clean build, ref: https://leafletjs.com/download.html   Scroll down to:

Building Leaflet from the Source
Leaflet build system is powered by the Node.js platform, which installs easily and works well across all major platforms. Here are the steps to set it up:
Download and install Node
Run the following command in the command line:
$ npm install
Now that you have everything installed, run $ npm run build inside the Leaflet directory. This will combine and compress the Leaflet source files, saving the build to the dist folder.

Expected behavior

I'm expecting a DIST build from source
Current behavior

$ npm install
npm WARN deprecated<EMAIL_ADDRESS>this package is now deprecated
npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, fl                             atted is its successor.
npm WARN deprecated<EMAIL_ADDRESS>This module relies on Node.js's internals and                              will break at some point. Do not use it, and update to<EMAIL_ADDRESS>
><EMAIL_ADDRESS>install C:\temp\Leaflet\node_modules\phantomjs-prebuilt
> node install.js

Considering PhantomJS found at C:\Program Files\phantomjs\2_1_1\bin\phantomjs.EXE
Found PhantomJS at C:\Program Files\phantomjs\2_1_1\bin\phantomjs.EXE ...verifying
Writing location.js file
PhantomJS is already installed on PATH at C:\Program Files\phantomjs\2_1_1\bin\phantomjs.EXE
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\karma-rollup-preprocessor\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}                             )
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}                             )

added 578 packages from 1611 contributors and audited 3122 packages in 257.444s
found 7 vulnerabilities (1 moderate, 5 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

(my computer) MINGW64 /c/temp/Leaflet (master)
$ npm audit fix
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}                             )
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\karma-rollup-preprocessor\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}                             )

up to date in 17.589s
fixed 0 of 7 vulnerabilities in 3122 scanned packages
  7 vulnerabilities required manual review and could not be updated

Environment

Leaflet version:  git clone git@github.com:Leaflet/Leaflet.git    12/9/2019 3:30PM PST
Browser (with version):  N/A
OS/Platform (with version):  Windows 10 Home, ver. 1909, installed on 7/19/2019, OS Build: 18363.476

Additional context
$ npm --version
6.10.3
Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

And just to be clear... the build process seems to run okay, but those npm install warnings always make me a bit crazy.  Certainly the ones that are included as dev dependencies in package.json.
Note, not to be ungrateful... many thanks to all of those who actively support this repo.

The installation process of the phantom-prebuild module fails because you already have an installed version in C:\Program Files\phantomjs\2_1_1\bin\phantomjs.EXE, i guess. I would suggest you to delete the previously installed version of phantomjs and try again. If you are not getting support here, post this issue in https://github.com/Medium/phantomjs. Good luck!

Apologies.. I misunderstood... I was thinking the issue was related to wrong version of     "phantomjs-prebuilt": "^2.1.16", in package.json
Thank you for the followup.  Please close this issue.  Many thanks to the Leaflet team.

Issue related to external phantomjs library installed on users drive.  I consider issue closed.  Thanks to ggcaponetto for the constructive feedback.


add chocolatey package

i'd love to install tmctl with chocolatey on my windows hosts

It seems unlikely that we'll be able to support this in the near term.

if u use github releases it's can be automated


It seems that compiled_code is not always available

Traceback (most recent call last):
File "/Users/wilsonk/anaconda3/envs/analytics/lib/python3.10/site-packages/IPython/core/interactiveshell.py", line 3553, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
lineage_map = extractor.build_lineage_map()
File "/Users/wilsonk/anaconda3/envs/analytics/lib/python3.10/site-packages/dbt_column_lineage_extractor/extractor.py", line 127, in build_lineage_map
model_sql = model_info["compiled_code"]
KeyError: 'compiled_code'

right! that could be the case. docs generate takes a long time for our transform project. and I did work on something else in between.

On the other hand, is that possible for the tool to identify that compiled_code is not in, let's docs generate for the node that's being requested?

redo dbt docs generate solved the issue.


chore(main): release react 0.0.19-experimental

:robot: I have created a release beep boop
0.0.19-experimental (2024-11-12)
🐛 Bug Fixes

testing release -- attempt 3 (1bb8ebe)

🧹 Chore

release main (49fe368)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/open-socket/js-sdk/releases/tag/react-v0.0.19-experimental :sunflower:


Review dependencies

In the Readme there is:
npm install -S carbon-custom-elements carbon-components lit-html lit-element lodash-es @babel/runtime

Why the dependencies are not included? To have an easy install like:
npm install carbon-custom-elements

Good question - Basically this project took peerDependencies route to offer a bit more flexibility in choice of libraries and their versions, but I see your point. Something to mull over as the project goes...


[test] Update ClangImporter/enum-anon.swift for Clang improvements

We previously weren't able to import something properly, but now it's working because of some change in Clang. Let's take it!
rdar://problem/46263312

@swift-ci Please smoke test

12:58:32
llvm-config: error: component libraries and shared library
12:58:32
12:58:32 llvm-config: error: missing: /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master-next/buildbot_incremental/llvm-macosx-x86_64/lib/libLLVMTestingSupport.a
12:58:32 CMake Warning at cmake/Modules/CompilerRTUtils.cmake:246 (message):
12:58:32   llvm-config finding xray failed with status 1

Uh, hm. Well, that's unrelated to my change, but it's funny that it didn't happen when I built locally. Oh well.


Update relational data model figure

Description of feature
Update relational data model figure

The datamodel is created using https://dbdiagram.io/ . The tool is exporting to multiple fileformats, but importing them is not working yet. Saving the code which is used to generate the model can be saved in e.g. assets or side by side to the model figure in the documentation directory. Still, the arrangemet of tables need to be done by hand and cannot be saved in any case.

@skrakau What do you think about this arrangement? Is it easier to understand or should I change to the old arrangement? Also for the documentation webpage is it better to have it more vertical?

Updated data model, new arrangement and 1 to n references, as well as visible watermark of dbdiagram.io

PRs addressing this Issue: https://github.com/nf-core/metapep/pull/64 and https://github.com/nf-core/metapep/pull/65


Component re-rendered, but it shouldn't be...

I'm noticing an issue where the last component to have been affected by a mutation is rendered again for the next mutation (even if that mutation did not affect the properties used within that component.)
I made a gif showing what is happening:

Switching from "count" to "ticks" also renders the component for "count." When we press the button again, only the "count" component is rendered. Switching in the other direction, we observe the same effect.
This is the code I'm using:
import React from 'react'
import { proxy, useProxy } from 'valtio'

const state = proxy({
  count: 0,
  nested: { ticks: 0 },
})

function Counter() {
  const snapshot = useProxy(state)
  console.log('render Counter')
  return
{snapshot.count}

}

function Controls() {
  const incCounter = () => {
    state.count++
  }
  const incTicks = () => {
    state.nested.ticks++
  }
  console.log('render Controls')
  return (

      <button onClick={incCounter}>one up count</button>
      <button onClick={incTicks}>one up nested ticks</button>

  )
}

function Ticks() {
  const snapshot = useProxy(state)
  console.log('render Ticks')
  return
{snapshot.nested.ticks}

}

export default function App() {
  return (
    <>
      <Counter />
      <Ticks />
      <Controls />
    </>
  )
}

I understand this behavior. Would you try checking the render count with useEffect and is expected?
  useEffect(() => {
    console.log('render Counter')
  })

The reason behind this is to support Concurrent Mode at best effort.
Valtio is developed to support CM from the ground up.
Technically, render functions are pure and running them extra time is fine as long as it's not committed.
In the future version of Valtio, when React releases useMutableSource hook officially, this behavior would be improved.

Very interesting. I'd never heard of useMutableSource hook. How would that improve this behavior?

The double logging doesn't happen in useEffect, btw. It works as expected.

How would that improve this behavior?

I would expect it would avoid double invoking the render function.
It's currently my best-effort emulation of it with double invoking (same as use-subscription)

Sounds good. Thanks for the explanation.


run boss_train.py error

I user tensorflow 0.12, and I put some pictures in boss and other directories, but when I run boss_train.py ,it report error:
Traceback (most recent call last):
File "/home/zxx/PycharmProjects/BossSensor/boss_train.py", line 176, in
dataset.read()
File "/home/zxx/PycharmProjects/BossSensor/boss_train.py", line 35, in read
X_train, X_test, y_train, y_test = train_test_split(images, labels, test_size=0.3, random_state=random.randint(0, 100))
File "/usr/lib/python2.7/dist-packages/sklearn/cross_validation.py", line 1556, in train_test_split
arrays = check_arrays(*arrays, **options)
File "/usr/lib/python2.7/dist-packages/sklearn/utils/validation.py", line 287, in check_arrays
array.ndim)
ValueError: Found array with dim 4. Expected <= 2
Could you give me some help, thanks.

scikit-learn expects 2d num arrays for the training dataset for a fit function. The dataset you are passing in is a 3d array you need to reshape the array into a 2d.


What is a valid matrix value?

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/learn-github-actions/contexts#matrix-context
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
What part(s) of the article would you like to see updated?
The contents of the matrix context is described as string-valued. But it's not clear if this is always correct. It's also not clear what is legal to provide for a matrix in the first place.
Additional information
e.g. In the example here https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#using-a-matrix-strategy , version is syntactically a number. It's not clear whether one should expect ${{ matrix.version }} to be coerced to a string.
e.g. If I provide an object value to matrix, it's not clear if it should work. The below code seems to set ${{ matrix.foo }} to the object {"key": true}, but the GitHub's workflow editor complains "Matrix options must only contain primitive values":
jobs:
  example_matrix:
    strategy:
      matrix:
        - foo:
          - key: true

@rotu Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:
Also, welcome to the community! 🎉
While this is awaiting review, check our help wanted if you are looking for other ways to contribute.

While this is awaiting review, check our help wanted if you are looking for other ways to contribute.

@cmwilson21 Thanks for the recommendations! Could you please try to get the right eyes on this: https://github.com/community/community/commit/861a04a2da53a507200f1bd2f1ff2ca2be6d9e14#commitcomment-120298975
I tried to contribute what seems to be a simple fix but it looks like this issue is getting lost in the ether and other users have hit the same frustration! The community repo doesn't have an issues page so I'm not sure what the right escalation route is.
https://github.com/community/community/pull/59788
https://github.com/community/community/pull/58479
https://github.com/community/community/pull/58406
https://github.com/community/community/pull/58182

I'll triage this for the team to take a look 👀

@cmwilson21 Has this been triaged? What's the status?

👋 @rotu - It has been triaged and is on the board for review. We had several out for the US holiday last week. A writer will have eyes on it soon ✨
As for your other question about the Communities repo, I'll ask around 👍

@cmwilson21 Original issue was not resolved. This should be a quick documentation fix. Could you PLEASE escalate?

The matrix syntax definitely allows for some pretty handy undocumented trickery, which works just fine even though the syntax checker complains about it.
For example, the matrix we arrived at following that discussion — to build a cross-platform C/C++ project without special-casing the CMake-configure and compile steps for each OS — took this form:
jobs:
  build:
    runs-on: '${{ matrix.os.host }}-latest'
    strategy:
      matrix:
        os:
          - { host: windows, shell: msys2 }
          - { host: ubuntu,  shell: bash  }
          - { host: macos,   shell: bash  }
        compiler:
          - { cc: gcc,   cxx: g++ }
          - { cc: clang, cxx: clang++ }
    defaults:
      run:
        shell: '${{ matrix.os.shell }} {0}'
    env:
      CC: ${{ matrix.compiler.cc }}
      CXX: ${{ matrix.compiler.cxx }}

It almost looks like it shouldn't work, but it does! So much for, "must contain only primitive values".

Thanks for raising this issue. I'm glad to see that the issue_labeler.yml file was fixed since you commented on it.
If we're going to update this section of the docs to specify supported matrix values, I think we should get input from an SME to ensure that we don't introduce any errors. I'm adding the SME flag to request an SME review.

For any experts who may end up reviewing this issue:
Ever since we developed that matrix syntax "hack" (and many, many more like it that followed), I've been the guy walking around spoiling everyone's good time by arguing against becoming too reliant on it continuing to work.
"It's undocumented behavior that GitHub clearly didn't intend to support. The documentation makes absolutely no mention of it, there's not a single example of its kind anywhere in GitHub's provided resources, their syntax checker complains about it, and it's clearly an accident that it even works.1
"We shouldn't treat it like a supported feature, because at any moment they could decide to 'fix' the parser, and make it no longer accept matrix: configurations that were never intended to be valid."
Those are (still) my arguments, but it DOESN'T mean I want them to be correct!
I'd be thrilled if this (widely-used and clearly desirable) syntax was finally made official. Perhaps even alternate forms of the same configuration (see below) could also be supported. That'd be an ideal outcome here.
An undesirable outcome would be for Github to prove me right, and finally "fix" the parser to no longer accept this hack. (Breaking untold thousands of users' workflows in the process.)
Notes

I base that part of the argument on the fact that, while this syntax works (apparently as an accident of the parser implementation):
matrix:
  key1:
    - { subkey1.1: valueA, subkey1.2: valueM }
    - { subkey1.1: valueB, subkey1.2: valueN }
  key2:
    - { subkey2.1: value C, subkey2.2: value O }
    - { subkey2.1: value D, subkey2.2: value P }

... neither of these equivalent syntaxes work:
matrix:
  key1:
    - subkey1.1: value A
      subkey1.2: value M
    - subkey1.1: value B
      subkey1.2: value N
  key2:
    - subkey2.1: value C
      subkey2.2: value O
    - subkey2.1: value D
      subkey2.2: value P

matrix:
  key1:
    -
      subkey1.1: value A
      subkey1.2: value M
    -
      subkey1.1: value B
      subkey1.2: value N
  key2:
    -
      subkey2.1: value C
      subkey2.2: value O
    -
      subkey2.1: value D
      subkey2.2: value P

Three different YAML parsers I've tested all produce identical JSON from each of the three forms:
{
  "matrix": {
    "key1": [
      {
        "subkey1.1": "value A",
        "subkey1.2": "value M"
      },
      {
        "subkey1.1": "value B",
        "subkey1.2": "value N"
      }
    ],
    "key2": [
      {
        "subkey2.1": "value C",
        "subkey2.2": "value O"
      },
      {
        "subkey2.1": "value D",
        "subkey2.2": "value P"
      }
    ]
  }
}

No matter which YAML form I use, it parses to that exact , identical JSON. Yet, while the first works as a GitHub Actions matrix, the latter two will cause Actions to abort with a workflow syntax error.

Ever since we developed that matrix syntax "hack" (and many, many more like it that followed), I've been the guy walking around spoiling everyone's good time by arguing against becoming too reliant on it continuing to work.

Thanks for providing a concrete example! That's exactly why I filed this issue - I saw it a workflow, saw that the syntax checker flagged it, and I didn't know whether it's a feature or a hack.
Related:
https://github.com/actions/runner/issues/1660

@rotu Heh. Well, that second discussion is me. :grin:
The first one is interesting, though. I didn't realize that this form also (reportedly) works:
matrix:
  key1: [
    { subkey1.1: value A, subkey1.2: value M},
    { subkey1.1: value B, subkey1.2: value N }
    ]
  key2: [
    { subkey2.1: value C, subkey2.2: value O },
    { subkey2.1: value D, subkey2.2: value P }
    ]

Running that through my YAML parser... yup. Also identical:
{
  "matrix": {
    "key1": [
      {
        "subkey1.1": "value A",
        "subkey1.2": "value M"
      },
      {
        "subkey1.1": "value B",
        "subkey1.2": "value N"
      }
    ],
    "key2": [
      {
        "subkey2.1": "value C",
        "subkey2.2": "value O"
      },
      {
        "subkey2.1": "value D",
        "subkey2.2": "value P"
      }
    ]
  }
}

@ferdnyc I can confirm the parser intentionally supports complex matrix values and has since 2019. I think it's fairly safe to assume the functionality will not be removed - I imagine it would break a lot of customers' workflows.
When initially added, it was intended to solve scenarios like matching multiple runner labels. I'm happy to see it helped with your scenarios as well (host/shell, etc).
Will help route the issue to address improvements to the docs and validation in the UI editor.

@ferdnyc curiously I was not able to reproduce an error with one of your syntaxes above. This below YAML works for me. Perhaps you had some other syntax error?
on: push
jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        key1:
          - subkey1.1: Value A
            subkey1.2: Value M
          - subkey1.1: Value B
            subkey1.2: Value N
        key2:
          - subkey2.1: Value C
            subkey2.2: Value O
          - subkey2.1: Value D
            subkey2.2: Value P
    steps:
      - run: echo hi

@ericsciple

@ferdnyc I can confirm the parser intentionally supports complex matrix values and has since 2019. I think it's fairly safe to assume the functionality will not be removed - I imagine it would break a lot of customers' workflows.

Oh, that's good to hear! Yes, I imagine it absolutely would.

@ferdnyc curiously I was not able to reproduce an error with one of your syntaxes above. This below YAML works for me. Perhaps you had some other syntax error?

*sigh* It's certainly possible, it's happened in the past. In re-testing just now, I see that, indeed, all equivalent forms work just fine, and I've been spreading lies again. (Oops.)

Will help route the issue to address improvements to the docs and validation in the UI editor.

That would be great, because the implication is still that this is not how things should be done.
Particularly from the workflow editor, which still red-squiggles both os: and compiler: here, with the complaint that "Matrix options must only contain primitive values":

But I've also seen (and of course can't find, now) users trying to work out the correct syntax for their matrix: setup, trying things that are close to the valid syntax, but not quite there, and getting told exactly what the syntax checker says. (Along with, "If you want complex values, use include:". Rather than being pointed to the correct — and apparently, supported! :tada: — syntax for matrix: proper.)

Vjvyctuvy

It looks as if the current behavior in workflows is expected to continue to be available.
Updates to the validation of workflows requires internal work. I've created an internal issue to track both the improvements to the validator and the docs. I'm going to put this issue on hold until we're able to give you an update on the internal work.


Note addition to the Countermeasure section

Description:
As requested in issue ticket #9523 (Please add a note), the aim of this PR is to add a note to the Countermeasure section of the document article "Deny access to this computer from the network".
Thanks to Daniele Bona (dbona75<EMAIL_ADDRESS>for the request.
Proposed change:

Add a Note blob explaining the required Network Logon rights to the domain controllers.

Codestyle & whitespace changes:

Remove any redundant end-of-line (EOL) blanks.
Standardize indent whitespace in numbered lists and bullet point lists to one single blank space.

Additional notes:

The added note could possibly benefit from improved phrasing, I am not sure if the current phrasing is clear enough.
I also updated the article date to 05/19/2021 (from 04/19/2017), but this may be changed to a more accurate date by the person merging this PR.

Ticket closure or reference:
Closes #9523

#sign-off


test_double_download fails occasionally

test_double_download under test_misc fails occasionally, likely due to some race condition. Below is the error log. I believe the problem happens due to _delete_blobs_marked_for_deletion() is called in manage() when db_conn may be closed already.
[ERROR]
Traceback (most recent call last):
File "/home/travis/build/lbryio/lbry/lbrynet/core/BlobManager.py", line 200, in delete_from_db
d = self._delete_blobs_from_db(b_hs)

File "/home/travis/build/lbryio/lbry/lbrynet/core/sqlite_helpers.py", line 19, in wrapper
d = f(*args, **kwargs)

File "/home/travis/build/lbryio/lbry/lbrynet/core/BlobManager.py", line 309, in _delete_blobs_from_db
return self.db_conn.runInteraction(delete_blobs)

exceptions.AttributeError: 'NoneType' object has no attribute 'runInteraction'
tests.functional.test_misc.TestTransfer.test_double_download

Example of build failing here: https://travis-ci.org/lbryio/lbry/builds/209860687

test_last_blob_retrieval also fails occasionally , like for related reason. Error below:
Traceback (most recent call last):
File "/home/travis/build/lbryio/lbry/venv/local/lib/python2.7/site-packages/twisted/enterprise/adbapi.py", line 474, in _runInteraction
conn.rollback()

File "/home/travis/build/lbryio/lbry/venv/local/lib/python2.7/site-packages/twisted/enterprise/adbapi.py", line 52, in rollback
self._connection.rollback()

sqlite3.OperationalError: cannot rollback - no transaction is active
tests.functional.test_misc.TestTransfer.test_last_blob_retrieval
https://travis-ci.org/lbryio/lbry/builds/215692820

fixed in https://github.com/lbryio/lbry/pull/682


Server-side sorting

What's new

Continuation of https://github.com/open-rmf/rmf-web/pull/651, implementing server-side sorting.
Incorporates changes from https://github.com/open-rmf/rmf-web/pull/538, since database migration will be required.
https://user-images.githubusercontent.com/5383623/203946045-035ad1e4-8c31-46df-bb8b-e8b3fecfdca5.mp4

Self-checks

[ ] I have prototyped this new feature (if necessary) on Figma
[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Sorting by state and by assignee doesn't work as i excepted it to work, this one is by state

and this one is sorted by assignee

Thanks for the quick review, I took a look at it by loading the shared data dump, and I can recreate the issue. I think I may have messed something up when I dumped out my migrated database, I'm currently using live data from a simulation and everything seems to be working well, including assigned_to and status.
https://user-images.githubusercontent.com/5383623/205229538-cc275985-427d-43f8-90cf-d5301a6f6a46.mp4

@mayman99  Ah I figured out what's going on now! During the database migration, it only creates empty columns for assigned_to and state, without copying over the data from data, which is a json and originally those columns were populated from that json.
As of now, the reason why the data dump does not sort, is due to those empty database columns. We were essentially sorting empty spaces.
I'll see if the database migration supports copying data over as well.

Just managed to get it working! Will be sending over the modified database in slack, where all the fields are properly populated.
https://user-images.githubusercontent.com/5383623/205282157-f47db76c-d938-4705-a281-356e72062ea1.mp4

lgtm!


JavaScript error

So whenever I open Discord with B.D. active this pops up, i'm not very good with coding or files, so i don't understand what any of it means. B.D. was working when i first downloaded it but I went on to Discord a few weeks later (as the computer I had it on wasn't at my home) & it came up with the "unexpected token in JSON at possition 0" message at the top. I reinstalled both B.D. & Discord and it fixed it but B.D. wasn't working, I have deleted & reinstalled both many more times, but nothing has worked, does anyone know how to fix it?

use this https://github.com/rauenzi/BetterDiscordApp/releases
if you got same error then get https://cdn.discordapp.com/attachments/280806472928198656/406142867749208064/emote_data.zip
and extract it in %AppData%\BetterDiscord\

wow, that was fast

well support server has git channel , anyway that fix your problem? if so you can close the issue

yes i did, and that's a good idea lol


Feature Request: metadata in podTemplates

Our network plugin needs a specific annotation in pod to support reserved ip. It would be very helpful if we support metadata field in podTemplates.
podTemplates:
          - name: mypod
            metadata:
              annotations:
                reserveIP: "true"
            spec:

@slimtom95 , makes sense. We will try to add it to the next release

Added in 0.13.0.


update aws providers

what

support aws 3.x provider
DEPENDENCY: https://github.com/cloudposse/terraform-aws-lb-s3-bucket/pull/20

why

enable using with other modules requiring aws 3.x provider

references

requires 3.x: https://github.com/cloudposse/terraform-aws-ecr/blob/master/main.tf#L30

per https://github.com/cloudposse/terraform-aws-s3-log-storage/pull/38 looks like there is WIP on this so i'll close mine out


The demo doesn't seem to use any  'push' or 'present' methods in VOVCManager

I ran the demo and set some breakpoints in the methods in VOVCManager. It seems that your demo is running based on the original push/pop methods of UINavigationController. Can you show some real  cases of using methods in VOVCManager to route the pages?

Thx.
Now, there are some sample code with push/present methods.


Create a report showing recently published repos

As in PublishEvents of reps moving from private->public

Implemented as db/reporting/db_report_publish.rb

Except it's not working :) It's only showing one row for some reason.

Fixed by dbc8d856a4cf4afa4e76c3f99fec3b617c7584f0


Show internal data on order screen

User story
As a host admin or accountant I want to see all the info associated with a transaction, so that I can follow up compliance and accounting needs.
Best solution for this problem
On a screen like this:

I want to see any data added in these fields:

In this case, checks from Dec 2022 seem to have been added months late in March 2022. There could be an explanation in the internal memo and date field, but I can't see that data.
P2 low frequency, high impact

+1 on this one. This page ends up being really useful, it would be great to make sure it has all the information about the contribution. Related: https://github.com/opencollective/opencollective/issues/6589


#13 Implement unchecked and unchecked() for ThrowingBinaryOperator

Trying to fix/implement #13.

Current coverage is 94.11% (diff: 0.00%)

Merging #17 into master will decrease coverage by 4.34%

@@             master        #17   diff @@
==========================================
  Files            11         12     +1
  Lines           130        136     +6
  Methods           0          0
  Messages          0          0
  Branches          7          7
==========================================
  Hits            128        128
- Misses            2          8     +6
  Partials          0          0

Powered by Codecov. Last update 08cebcb...fcec202

I don't think I fully understand what is the codecov complaint...


Improved provisioning IP discovery

Closing in favor of the approach in https://github.com/openstack-k8s-operators/osp-director-operator/pull/60


Preview target

With this running make preview builds the documentation with Antora and runs the Hugo server to serve the website and Antora content.
This relies on Add Antora built documentation as static resource
This way when running hugo serve the Antora built documentation is available on /docs as well.
Since the output of the Antora built is nested within the website/antora/docs and then copied over by Hugo to public/docs the two build steps and artifacts would no longer work on GitHub Workflows, so this also unifies them to a single build step.

I tried it and it works good. Awesome!!


Too long validation message to honor package push notification settings

Addresses #5838.
Validation taking too long message is now only sent if package push notifications are enabled. Changed the wording in the Gallery for the push notifications to include all push-related notifications, not only "package published".
Rendering of the text:

We also have "short enable notice" in the options, it was left it as is:

@agr Do we also send a mail when a package is unlisted/relisted?

@anangaur, I don't think we send anything on unlist/relist. I don't see any message service method related to those.

Proposed text:
Notify when package is published to NuGet Gallery
This setting enables notifications whenever a package is published to your account. We recommend to enable this setting so that you can inspect whether a package was published intentionally and to be notified if there are unexpected delays in publishing your package.

Thanks @scottbommarito


12 warnings appear in iOS-Fleet-Managemend-SDK

Hi,
I use pod 'EstimoteFleetManagementSDK', '4.31.2'
and I face 12 warnings from EstimoteFleetManagementSDK
https://drive.google.com/file/d/1iVyzedtooepHOyWqp8JuW4shFvO9kHvb

@Mohamedadin thanks for the heads up, we'll throw it into our backlog

@Mohamedadin the link is incorrect I believe 😉

I have bee seeing this since X-Code11 and now X-Code12 is came out. When will you guy fix this warning ?


INT B-19789 fe office user ability to manage docs

B-19789
Summary
This is the frontend work for giving the office users the ability to manage documents(orders, amended orders, and supporting documents). QAE/CSR can only view and will not be able to add or delete documents.
How to test

As a customer -> create a move and finish submitting with any shipment.
As a SC -> find the move -> click View and edit orders button in move details page.
Use the Manage Orders and Manage Amended Orders button on the right sidebar to add/delete documents and see the changes reflected.
Go back to move details page and click the "Supporting Documents" tab.
Use the document component on the right sidebar to add/delete supporting documents.
Repeat for TOO/TIO.
QAE/CSR should not be able to add/delete documents.

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against c151c7ce6126e016cebf681c6db34534aeebcde8

Just here to say I love the picture you uploaded :)

Just here to say I love the picture you uploaded :)

Haha thanks Paul! I totally stole that from an existing move cause I liked it too 😸 .


Add new template

I added a new template into the resume folder. I hope it can be worked on and merged.

Hi @xwang345 thanks for the PR. Please fix the errors so that the CI runs throught.


Failed configuration co2 tariff "ue" / "ü"

Describe the bug
I used "ue" instead of "ü" for type. Could this the reason of the error message?
Steps to reproduce

gruenstromindex (--> error message)

...
Configuration details
tariffs:
  currency: EUR
  grid:
    type: tibber
    token: ""
  feedin:
    type: fixed
    price: 0.08
  co2:
    type: gruenstromindex
    zip: "0xxxxx"

Log details
Feb 29 17:56:48 raspberrypi evcc[14492]: [main  ] ERROR 2024/02/29 17:56:48 failed configuring co2 tariff: invalid tariff type: gruenstromindex

What type of operating system are you running?
Linux
Version
0.124.6

Yes


Playback after recording not working on a Safari ios 16

After getting access rights and recording audio i can see a waveform, but there is no sound when playing.
In Desktop Chrome everything is ok.
Wavesurfer.js version(s):
beta 7
Browser and operating system version(s):
Ios 16 Safari
Mac os Safari 16.5
Code needed to reproduce the issue:
Example have a same issue on Safari:
https://wavesurfer-js.org/examples/#record.js
Steps needed to reproduce the issue:
Go to https://wavesurfer-js.org/examples/#record.js -> start to record -> stop recording -> try to play the recording

When i changed type to { type: 'audio/mpeg' } in a record.ts and player.ts, playback started to work in a Safari.

Nice! Can you submit a PR?

Hey folks, lemme join the party, as I was trying to figure out this issue for past few days as well. And once I found your discussion here, I was able to dig down a bit, and after some experimenting and testing submitted a PR #2892.
Please take a look and let me know if this seems to be working for you 🙏


Text ending in a hash-character incorrectly detected as closed heading

I have a document with some code snippets, one of them being C#:
# Main

## Samples

### Java

foo

### C#

bar

The problem is, that this triggers rules MD003 and MD020 because the validator believes that I am trying to use a closed heading style in the last heading.
Demo sample: https://dlaa.me/markdownlint/#%25m%23 Main

%23%23 Samples

%23%23%23 Java

foo

%23%23%23 C%23

bar

Yes, you need to escape the trailing # as ### C\#

Agreed. Here's your sample with that change: https://dlaa.me/markdownlint/#%25m%23 Main

%23%23 Samples

%23%23%23 Java

foo

%23%23%23 C\%23

bar

Thank you. Didn't know that.


Dashboard 500 Error - error calling GetRepoLink: runtime error: invalid memory address or nil pointer dereference

Description
On a RKE2 cluster, I have Gitea installed using the Helm chart (as a dependency of an umbrella chart).
After an RKE2 upgrade, an Ingress related issue occurred so as a workaround I executed helm uninstall <RELEASE_NAME> -n <MY_NAMESPACE> and then helm  upgrade <RELEASE_NAME> <MY_CHART>  -n <MY_NAMESPACE> --install, which resolved the Ingress issue.
Nonetheless, when verifying the Gitea UI (login with admin user), the default page is rendering:

The 2 menu drop-down's are not working unless I change page first (i.e. as long as I am not on the default page):

The Gitea container logs show:
2024/11/13 14:48:58 ...er/issues/indexer.go:76:func1() [I] PID 7: Initializing Issue Indexer: db
2024/11/13 14:48:58 ...er/issues/indexer.go:153:func2() [I] Issue Indexer Initialization took 31.474µs
2024/11/13 14:48:58 ...xer/stats/indexer.go:41:populateRepoIndexer() [I] Populating the repo stats indexer with existing repositories
2024/11/13 14:48:58 modules/ssh/ssh.go:331:Listen() [I] Adding SSH host key: /data/ssh/gitea.rsa
2024/11/13 14:48:58 ...xer/stats/indexer.go:87:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories
2024/11/13 14:48:58 modules/ssh/init.go:26:Init() [I] SSH server started on :2222. Cipher list<EMAIL_ADDRESS>aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>aes256-gcm@openssh.com]), key exchange algorithms ([curve25519-sha256 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha256 diffie-hellman-group14-sha1]), MACs<EMAIL_ADDRESS>hmac-sha2-256 hmac-sha1])
2024/11/13 14:48:58 ...s/graceful/server.go:50:NewServer() [I] Starting new SSH server: tcp::2222 on PID: 7
2024/11/13 14:48:59 cmd/web.go:304:listen() [I] Listen: http://<IP_ADDRESS>:3000
2024/11/13 14:48:59 cmd/web.go:308:listen() [I] AppURL(ROOT_URL): https://gitea.amp.myco.com/
2024/11/13 14:48:59 ...s/graceful/server.go:50:NewServer() [I] Starting new Web server: tcp:<IP_ADDRESS>:3000 on PID: 7
2024/11/13 14:49:18 ...eb/routing/logger.go:102:func1() [I] router: completed GET / for <IP_ADDRESS>:39990, 200 OK in 2.7ms @ web/home.go:32(web.Home)
2024/11/13 14:49:23 ...eb/routing/logger.go:102:func1() [I] router: completed GET / for <IP_ADDRESS>:39990, 200 OK in 1.3ms @ web/home.go:32(web.Home)
2024/11/13 14:49:24 ...eb/routing/logger.go:102:func1() [I] router: completed GET /explore/repos for <IP_ADDRESS>:39990, 200 OK in 24.8ms @ explore/repo.go:196(explore.Repos)
2024/11/13 14:49:31 ...eb/routing/logger.go:102:func1() [I] router: completed GET / for <IP_ADDRESS>:39990, 200 OK in 7.4ms @ web/home.go:32(web.Home)
2024/11/13 14:49:33 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/login?redirect_to=%2f for <IP_ADDRESS>:39990, 200 OK in 3.6ms @ auth/auth.go:164(auth.SignIn)
2024/11/13 14:49:40 ...eb/routing/logger.go:102:func1() [I] router: completed POST /user/login for <IP_ADDRESS>:39990, 303 See Other in 62.3ms @ auth/auth.go:196(auth.SignInPost)
2024/11/13 14:49:40 ...activities/action.go:207:loadRepo() [E] repo_model.GetRepositoryByID(2): repository does not exist [id: 2, uid: 0, owner_name: , name: ]
2024/11/13 14:49:40 .../context_response.go:88:HTML() [E] Render failed: failed to render template: user/dashboard/dashboard, error: template error: builtin(bindata):user/dashboard/feeds:20:45 : executing "user/dashboard/feeds" at <.GetRepoLink>: error calling GetRepoLink: runtime error: invalid memory address or nil pointer dereference
----------------------------------------------------------------------
							{{ctx.Locale.Tr "action.commit_repo" (.GetRepoLink ctx) (.GetRefLink ctx) .GetBranch (.ShortRepoPath ctx)}}
							                                      ^
----------------------------------------------------------------------
2024/11/13 14:49:40 ...eb/routing/logger.go:102:func1() [I] router: completed GET / for <IP_ADDRESS>:39990, 200 OK in 25.7ms @ web/home.go:32(web.Home)

I have found the issue https://github.com/go-gitea/gitea/issues/24856 that refers to the same runtime error, but it did not provide any  insight on what could be the cause.
Gitea Version
1.22.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
RHEL 8.10
How are you running Gitea?
On a RKE2 cluster
Database
PostgreSQL

Additionally, registering a new user and signing in with it afterward does not result in such error:

This is because some repository has been deleted but the actions related to that repository have been deleted. This could be fixed by running ./gitea doctor check --run check-db-consistency

->  Fix nil panic if repo doesn't exist #32501

A quick workaround could be truncate the action table (or backup it before truncating if you'd like to keep the data)


Potential Memory Leak

We might have a memory leak in Poseidon where memory is not freed correctly. As a consequence, the virtual machine freezer and the service became unavailable.
Memory consumption:

Deployments (including a restart of the Poseidon service):

While the original issue has been fixed with #73, I noticed a regression with this release: Many executions log Error reading client message at the end of their execution. See POSEIDON-T for details (please note that I temporarily reverted the deployment).


Implement private constructor fields

Created from discussion #7088
Follow-up of #7304

Constructor fields should not be private, as mentioned in the edit in the discussion. Closing this issue.


Revisit retrieving fork specific config from spec

In few places especially test fixtures, there is code like:

SpecConfigEip4844.required(spec.forMilestone(SpecMilestone.EIP4844).getConfig());

BeaconBlockBodySchemaEip4844.required(
                spec.forMilestone(SpecMilestone.EIP4844)
                    .getSchemaDefinitions()
                    .getBeaconBlockBodySchema());

spec.forMilestone(SpecMilestone.EIP4844)
            .getConfig()
            .toVersionEip4844()
            .orElseThrow()

It could be worth revisiting to see if there could be a way of simplifying the logic.

Is this related to #6448?

Is this related to #6448?

No, it's different.  I think it's still worth to have a look if the time comes for it to be taken a look at, but nowhere near a priority.


fix: some UI improvements of the pre-request script tab - INS-3711

Changes:

[x] add green dot to pre-request script and doc tab when they are active
[x] re-org and add script snippet menu items

Snapshots:
Menu Items:

Tab title:

I think it would look nicer if the dot could be aligned horizontally with the text

I think it would look nicer if the dot could be aligned horizontally with the text

Sounds reasonable, updated.