Contributing guideline

This issue created to discuss contributing guideline details.
I created raw example adapted from template that I found good:
https://gist.github.com/4rgon4ut/ae068b84a50c1b8ae66cd127337c1b9a
I have several topics to discuss(@bobbinth):

Do we actually need contributing guideline on current stage of the project?

Branching. As I see project have active branch named next and we also have gitbook separated branch, I would like to see your thoughts about which details should be represented.

Versioning. Looks like semver, but would be nice to clarify.

Any other details that should/shouldn't be represented, and guideline structure.

And the last, should I propose raw version to start discussion in proposal page or maybe create discussion in related section?(I mean link to the gist in issue do not looks like best way of doing it)

@4rgon4ut - thank you for bringing this up! @grjte will probably have more comments on this, but a few thoughts from my end:

Yes, I think this would be great to have.
Yes, next is intended to be the branch for developing next versions (v0.2 for now, and when v0.2 is released, nextwill be for v0.3 development). There still could be fixes against themainbranch, but I don't foresee many of these happening, at least in the near future. a. Regardinggh-pagesbranch, I'm actually not sure yet what's the best way for managing going forward. Right now, the docs are coming from thenextbranch, but maybe they should come from themain` branch in the future.
Yes, we use semver.

Hey @4rgon4ut I'm really happy to see this! It would be a great addition and I really like what you've put together. There are a couple things it would be good to discuss here and then after that maybe you can run it through google docs or similar for a quick grammar/spellcheck then open a PR where we can refine the rest. (I have some smaller comments I'd put inline)
I know we don't want to have a high barrier to entry, but I think some guidance is good.

There are certain things that we do consistently, and new contributors might appreciate being able to find about these things easily (like semantic commits or our documentation conventions).
Exposure to good practices (or at least opinionated ones) is beneficial for people who may not have had the opportunity to work in formal engineering environments, and we can link to explainer resources (as is done in the gist sample).

Branch names

Branch name should be a short issue/feature decription in snake case.
For example, if issue title is Fix functionality X in component Y than branch name shuld be smth like: fix_x_in_y.

Bobbin and I both seem to use dashes, so maybe it would be better to specify using hyphens as separators, since that's what we've been doing.
If we're going to standardize this, we could consider prefixing by the issue number, e.g. 300-fix-x-in-y. Do either of you have an opinion on this?

Commit messages
I think a clean & descriptive git log is really important, so I'd like to address this at least at a basic level.
Ideally, I'd like people to:

rebase from next before submitting a PR in case there have been changes. In other words - we'd like to avoid merge commits.
use descriptive commit messages, preferably following the convention we've been using for semantic commit messages.
rebase or squash commits when making changes in response to a code review on a PR (some projects object to this, so people may find it helpful to know our preference)

@bobbinth if you think asking people to rebase raises the barrier to entry too much, we could leave it out, or we could put it in (with link to a tutorial) but not be big sticklers about it during review. I would class this under point number 2 from above :)
Documentation and Code Style
There are a couple of things that we do which aren't written down anywhere which people usually learn at some point during reviews. It might be easier to include them here.

For documentation in the codebase, we follow the rustdoc convention with no more than 100 characters per line.
For code sections, we use code separators of 100 characters like the following:

// CODE SECTION HEADER
// ================================================================================================

I'd love to hear thoughts from other contributors on which of the things above would have helped you vs. discouraged you from contributing @tohrnii @0xKanekiKen and all others :)

Regarding gh-pages branch, I'm actually not sure yet what's the best way for managing going forward. Right now, the docs are coming from the next branch, but maybe they should come from the main branch in the future.

I think docs changes have been happening side by side with design changes we've been making, so it has been organic to have them on the next branch. I don't think forcing docs to happen elsewhere wouldn't have made sense for most of the cases in the past few months. I think I would keep doing docs on the next branch at least until the 0.3 release and then maybe reassess

Bobbin and I both seem to use dashes, so maybe it would be better to specify using hyphens as separators, since that's what we've been doing.
If we're going to standardize this, we could consider prefixing by the issue number, e.g. 300-fix-x-in-y. Do either of you have an opinion on this?

So we finalize on dashes as separators, if no one has any objections.
I'm personally think issue number in branch naming is also good and can save some time. However, we can standardize PR template so that PR description will contain issue number and link. Also would be nice to create PR/issue templates and add references to guide.

use descriptive commit messages, preferably following the convention we've been using for semantic commit messages.

Seems like good practice too but this requirement may lead to constantly having to remind people of this during reviews untill all project become consistent with this convention.

However, we can standardize PR template so that PR description will contain issue number and link. Also would be nice to create PR/issue templates and add references to guide.

Yep, I agree with this! Do you have something in mind already or templates you like?

Seems like good practice too but this requirement may lead to constantly having to remind people of this during reviews untill all project become consistent with this convention.

Yes, any conventions will lead to an increase in requesting that people check the contributor guidelines, so I think we'll see a similar issue with branch naming and doc line length. That said, I think we'd be ok with letting some things slide through for first-time contributors since we don't want to discourage anyone, and those things would probably be branch names, semantic commits, and doc line length. We could point it out for repeat contributors, if needed. (This is basically what we do now, but it would be better because it's more accessible.) With semantic commits - currently most of the full members of the team are doing it but we're not enforcing it generally, so I think it would be good to make a decision & establish consistency at least among all regular contributors
We'll want to hear @bobbinth's thoughts on this though

I agree that pretty much all of this should be "soft requirements" for first time contributors. For example, if someone uses underscores instead of dashes in their first PR, I wouldn't necessarily call them out on that. For repeat contributors we can ask for stricter adherence to the guidelines, but also probably in a gradual manner.
A few specific comments:

Yes, let's use dashes instead of underscores in branch names.
I probably wouldn't require prefixing branch names with issue numbers as sometimes the scope of the PR changes while working on it. But this is not a strong opinion on my part.
I'd probably favor keeping the PR template as light as possible as not to overwhelm people.
I do think we should state that we follow semantic commit naming for commits.

I'd love to hear thoughts from other contributors on which of the things above would have been appreciated vs. discouraged you from contributing @tohrnii @0xKanekiKen and all others :)

When I started contributing, I didn't use to follow all the conventions that we have described above. But I think these things became obvious to me with time by inferring from the existing code base/commits. And TBH, none of the above conventions would take a substantial time/effort on the contributor side.
I second @bobbinth's view that pretty much all of this should be "soft requirements" for the first-time contributor. I'd,though, likely not put "Writing Documentation" in the soft requirement list; we should request the contributor to adhere to our documentation guidelines.

@bobbinth @grjte Thanks for your thoughts. I added some points to the guide(on which consensus has been reached).
There are also things in which we need to come to unity:
1. Prefixing branch names with issue number.
2. Rebase from next before submitting a PR.
As I understand, it is not "flow" disagreement, but rather trying to find right tradeoff between shortness(to not overflow newcommers) and descriptiveness(as all team members agree with this practise(?)). I thing that main part of contributors guide should be detailed enough. Also, we can add TL;DR section with ultra-short example-based soft requirements list to follow such scheme:
Newcommer goes to guide and reading TL;DR section(with minimal base requirements). If one decides become repeat contributor later, he will return and read full guide by himself or will be redirected by team member on review process.(I personally think that full guide is not so long to read even with rebasing explanation, but such scheme may work for some people)

About Issue/PR templates:

Issues
I found some ready to use templates but most of them looks overloaded. I do not think we need issues template on current stage because most of them too narrow-minded, and we have a lot of discussions and design thoughts in issues and we will face classification problem along with template mismatch issues.

PR
I agree with @bobbinth that PR template should be light. It may be good to move "Pre-PR checklist" section from contributors guide to PR template to get something like this:

## Describe your changes

## Issue ticket number and link

## Checklist before requesting a review
- [ ] Repo forked and branch created from `next` according to naming convention.
- [ ] Commit messages and codestyle follow conventions.
- [ ] Tests added for new functionality.
- [ ] Documentation/comments updated according to changes.
- [ ] Tests passed.

Ofc include links to related sections of contributors guide in template.

@4rgon4ut Great! Here are my thoughts on the above.

Prefixing branch names with issue number.

Let's not do this. We'll just keep it simple with the existing kebab-case branch naming as you've described it.

Rebase from next before submitting a PR.

I think we should ask people to rebase. There seems to be agreement from those contributors who have weighed in (you, @0xKanekiKen, and myself) that this is not too much to ask and would not have discouraged us initially. And as stated, we can let it be a "soft" requirement, so we won't make first-timers fix it if they don't get it right. (Although we don't need to state this explicitly anywhere. We'll just keep it in mind within the team)

we can add TL;DR section with ultra-short example-based soft requirements list to follow such scheme

This is a good idea, but actually I don't think it's necessary right now. The new doc version is still pretty short & manageable, and I think the lightweight PR template you described below does the job of providing a TL;DR for people who don't read the whole doc.

I do not think we need issues template on current stage because most of them too narrow-minded, and we have a lot of discussions and design thoughts in issues and we will face classification problem along with template mismatch issues.

Yep, good points, I agree!

It may be good to move "Pre-PR checklist" section from contributors guide to PR template

I like this - I think the PR template you suggested will be helpful without being overwhelming. I would just make a couple minor changes:

include the step to rebase from next
Maybe add a step for clippy and rustfmt passed? If they aren't passing it'll just fail in the PR run whenever one of us starts it, and it might be a bit frustrating to diligently go through the checklist & still have that happen.
I think we could still keep the "Pre-PR checklist" in the contributor doc. There's no harm in having it in both places, since it's useful & basically acts as a TL;DR.

I agree with pretty much everything what @grjte wrote above. One question:
How does having a PR checklist affect number of tasks that Github shows in the summary of PRs? We frequently use checklists to track the progress within PRs, and it would probably create too much noise if each PR has 5 - 6 tasks listed by default.

@bobbinth what about having it as a bullet point list instead of a task list?

I think having bullet points should work. Also, I wonder if for the template:

Instead of Issue ticket number and link section we should just have a bullet point saying something like Relevant issues are linked in the description.
Add the link to "Commit messages and codestyle follow conventions." to the the actual doc.
Get rid of Tests passed. bullet point as I think this is usually implied.

Basically, it could look like this:
## Describe your changes

## Checklist before requesting a review
- Repo forked and branch created from `next` according to naming convention.
- Commit messages and codestyle follow [conventions](./CONTRIBUTING.md).
- Relevant issues are linked in the PR description.
- Tests added for new functionality.
- Documentation/comments updated according to changes.

These are not strong preferences from my end - just suggestions. So, I could go either way.

@bobbinth @grjte I'm added rebase and squashing points to guide and fixed some typos. Would be great to know your thoughts about proposing version. Also, added clippy and rustfmt passing point to Pre-PR checklist.
As you can see I failed with proposing guide through community standards interface because proposing create PR to main with default branch name path-1 which is inconsistent with naming convention. Should I propose through common PR flow?

About PR template
As I see we are all agreed on using bullet point instead of checkboxes. Another thing to clarify: we are going to store PR template(and possible future templates) in .github directory?

Closed by #365 and 62e5889b503bafe601c378c95608969975f55aeb


Fix the column widths in the jobs table. Enable horizontal scrolling.

Move from having fractional column width sizes in the jobs table columns to having a fixed width, populated with sensible default values. Add horizontal scrolling for table overflow in the browser when the table exceeds the browser size.
Fix step towards addressing: https://github.com/G-Research/armada/issues/1480

Will resolve under #1750


Ubuntu CI Failing

The Ubuntu Github action image has updated, bringing with it CMake verison 3.19.
Googletest doesn't support this yet (), which is calling all ubuntu CI runs to fail.
Won't fix it ourselves just yet, hopefully Googletest will be updated in the very near future.
GTest issue: https://github.com/google/googletest/issues/3040
GTest candidate PR: https://github.com/google/googletest/pull/3094 (month old without being merged at time of writing).

Installing a pinned version (3.18.4) is a possible (temporary) fix:
- name: Install Specific Cmake version via Pip.
      run: |
        python3 -m pip install --user cmake==3.18.4
        echo "$(python3 -m site --user-base)/bin" >> $GITHUB_PATH

#427 will be a short term fix for this, until a gtest update is available, and cmake > 3.18 can be used.


PoX algorithm overview

A summary of the PoX algorithm that would help developers/miners/integrators understand the entire process

A short summary of the Proof of Transfer whitepaper, with links to the actual White Paper and a link to the White Paper reading.
Actual figures (as in current Source Code) related to the threshold for Stackers, Initial & Sunset phases, number of blocks per Reward Cycle, maximum BTC addresses per Reward Set etc..
A graphic illustrating the interaction between the various actors and components.

This would be fantastic @joshmatix! Can you create a PR? Happy to help in any way possible. LMK

I created a PR. Is it ok?

thanks @joshmatix - I'll take a look in a bit. I noticed the illustration wasn't included. maybe @jasperjansz could help as part of the upcoming docs week :)

Alex,
Being new to the github process, I wanted to make sure I was doing it
right, before adding more stuff.
Tom ..
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Fri, Oct 30, 2020 at 11:52 AM Alexander Graebe<EMAIL_ADDRESS>wrote:

thanks @joshmatix https://github.com/joshmatix - I'll take a look in a
bit. I noticed the illustration wasn't included. maybe @jasperjansz
https://github.com/jasperjansz could help as part of the upcoming docs
week :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/blockstack/docs/issues/837#issuecomment-719635275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADTSJJSONXKJS6TQEGMASDSNLOLLANCNFSM4TBO7Z3A
.

Added the graphic.
On Fri, Oct 30, 2020 at 11:52 AM Alexander Graebe<EMAIL_ADDRESS>wrote:

thanks @joshmatix https://github.com/joshmatix - I'll take a look in a
bit. I noticed the illustration wasn't included. maybe @jasperjansz
https://github.com/jasperjansz could help as part of the upcoming docs
week :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/blockstack/docs/issues/837#issuecomment-719635275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADTSJJSONXKJS6TQEGMASDSNLOLLANCNFSM4TBO7Z3A
.


Dynamic Dependencies sample does not build correctly

The following sample:
https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/DynamicDependencies/DirectX
shoes the following error when building:
1>C:\WindowsAppSDK-Samples\Samples\DynamicDependencies\DirectX\D3D9ExSample.cpp(13,10): fatal error C1083: Cannot open include file: 'd3dx9.h': No such file or directory
1>C:\WindowsAppSDK-Samples\Samples\DynamicDependencies\DirectX\BackgroundThread.cpp(12,10): fatal error C1083: Cannot open include file: 'd3dx9.h': No such file or directory
Might there be an issue with the sample?

The DirectX sample requires downloading the DirectX SDK and Framework Package (it has extra dependencies): https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/DynamicDependencies

@erik0686 I'm closing this issue under the assumption that downloading DirectX SDK and Framework Package was the fix!


[PDI-14304] Class names refactoring for new TextFileInput and API cha…

…nges needed in BaseFileInputStepMeta for backward compatibility

Already merged as other pull request


Allow customisation of graph fields

Based on #42
This allows any graph field to be specified.

Out of date.


removed "blobColumnSeparators" from the JSON

This parameter is now deprecated and JSONs using with won't be accepted by ADF.

Hi @yoavfrancis, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@spelluru
FYI

#sign-off
From: Ross McAllister<EMAIL_ADDRESS>Sent: Thursday, December 17, 2015 11:45 AM
To: Azure/azure-content<EMAIL_ADDRESS>Cc: Sreedhar Pelluru<EMAIL_ADDRESS>Subject: Re: [azure-content] removed "blobColumnSeparators" from the JSON (#5240)
@spelluruhttps://github.com/spelluru
FYI
—
Reply to this email directly or view it on GitHubhttps://github.com/Azure/azure-content/pull/5240#issuecomment-165505617.


Resolve an issue with CASSANDRA_HOME.

The Cassandra RubyGem and Cassandra itself have different ideas about what CASSANDRA_HOME should point to, so if a custom CASSANDRA_INCLUDE is specified, assume that it will define CASSANDRA_HOME and CASSANDRA_CONF.
The gist of this fix is that if you're trying to use a location for Cassandra other than the default ~/cassandra, the environment variables quickly get you into trouble, since the Gem expects CASSANDRA_HOME to point to the directory above the actually Cassandra root (e.g. ~/cassandra), and Cassandra expects it to point to the root (e.g. ~/cassandra/cassandra-0.8).
The intention of this fix is to assume that if you're using a custom CASSANRA_INCLUDE file, that you know that you need to define CASSANDRA_HOME and CASSANDRA_CONF yourself. This allows you to have a CASSANDRA_HOME defined for cassandra_helper to use, while still allowing that value to be overridden by the CASSANRA_INCLUDE file.
There may well be a better way to resolve this, but this seem like it might cause the least friction. I'm surprised others haven't run into this before, which very well may be a good indication that I'm fundamentally confused about some aspect of how these pieces are supposed to fit together.
In effect, though, what I believe should happen is that the Rakefile should give the include file a chance to override the currently set environment variables. Alternatively, if using a cassandra.in.sh file other than the one that ships with Cassandra, removing the conditional checks for the presence of those environment variables would work, too, and this may be preferable to making the change here.
Either way, it seems to me that the issue of the discrepancy between what the Gem is expecting CASSANDRA_HOME to point to and what Cassandra is expecting should be addressed.
Sorry for the rambling, but my hope is that this request will open up a discussion about what I see as a potential point of confusion.

I am not quite sure that I understand the scenario that you are describing.  Could you describe what you are trying to do?
The cassandra_helper script simply provides a simple way to get up and running quickly.  I wouldn't imagine anyone would want to use these rake functions to manage a live production cluster.
I certainly do not have an issue making the gem use CASSANDRA_HOME in the same way as Cassandra itself.  It seems to me that in almost all cases we ultimately want the actual Cassandra location anyways...

Okay, maybe I'm just misunderstanding what cassandra_helper's purpose is, then.
My goal was to have a directory structure that looked like #{Rails.root}/db/cassandra/cassandra-0.8, with the configuration under #{Rails.root}/config/cassandra. In this case, I'd set the CASSANDRA_INCLUDE to point to #{Rails.root}/config/cassandra/cassandra.in.sh and have that script set up CASSANDRA_HOME to point to #{Rails.root}/db/cassandra/cassandra-0.8 and CASSANDRA_CONF to point to #{Rails.root}/config/cassandra.
The problem, though, is that cassandra_helper (i.e. the Rakefile) relies on CASSANDRA_HOME to point to #{Rails.root}/db/cassandra, which means I have to use a custom CASSANDRA_HOME that does something like this:
CASSANDRA_CONF=`dirname "${BASH_SOURCE[0]}"`
CASSANDRA_HOME="${CASSANDRA_CONF}/../../db/cassandra/cassandra-0.8"

Instead of something more like the default include, which will use the existing environment variables if they're already set:
if [ "x$CASSANDRA_HOME" = "x" ]; then
    CASSANDRA_HOME=`dirname $0`/..
fi

if [ "x$CASSANDRA_CONF" = "x" ]; then
    CASSANDRA_CONF=$CASSANDRA_HOME/conf
fi

Basically, if think if I could set CASSANDRA_HOME to the Cassandra's definition of it then I wouldn't have to resort to using a custom CASSANDRA_INCLUDE.


multi: Set default log level to info and note in readme

Fixes #93.

I was fixing this here: https://github.com/sr-gi/sim-ln/tree/fix-loglevel-required
But your solution is cleaner.
LGTM.


[MODULE] - Credit card number extraction

Description
This module extracts the credit/debit card numbers from a given string. It uses regular expression that parses the card details in a specified format. The credit card number can either be 13 digits(outdated), 15 digits(e.g. American Express) or 16 digits(e.g. Visa or Master Card) and it can be written either one complete number, or separated with spaces, or separated with hyphens.
Implementation
If so, please share it here. For instance:
from typing import Dict
import spacy
import re

def credit_extraction(text: str = None) -> Dict:
    if text is None:
        text = "This is my card details please use it carefully 4569-4039-6101-4710."
    nlp = spacy.load("en_core_web_sm")
    doc = nlp(text)
    regex = re.compile(r"(\d{4}[-\s]?){3}\d{3,4}")

    credit = []
    for match in regex.finditer(text):
        start, end = match.span()
        span = doc.char_span(start, end)
        credit.append([span.start, span.end, span.text])

    return {"credit nr.": credit}

Additional information

Make sure to have spacy installed if running on the local machine since it is used to create the doc object which is a sequence of token objects. This can be installed by running pip install -U spacy.
Since we are tokenizing each word, we also need to make sure that a tokenizer is installed as well. We used en_core_web_sm which can be installed by running python -m spacy download en_core_web_sm.

@divyanshukatiyar I think this one has the wrong return format. In the endpoint,
{
    "text": "This is my card details please use it carefully 4569-4039-6101-4710.",
    "spacyTokenizer": "en_core_web_sm"
}

returns
{"creditCard":[[9,16,"4569-4039-6101-4710"]]}

but it should be
{"creditCard":[[9,16,"CARD"]]}

I found a small spelling mistake in common:
it is written Tupel instead of Tuple


Noncanonical return warning

src/Control/Monad/Managed.hs:159:5: warning: [-Wnoncanonical-monad-instances]
    Noncanonical ‘return’ definition detected
    in the instance declaration for ‘Monad Managed’.
    ‘return’ will eventually be removed in favour of ‘pure’
    Either remove definition for ‘return’ (recommended) or define as ‘return = pure’
    See also: https://gitlab.haskell.org/ghc/ghc/-/wikis/proposal/monad-of-no-return
    |
159 |     return r = Managed (\return_ ->
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

I guess the easiest fix would be to remove the return definition and drop support for GHC < 7.10 / base < 4.8.

Thanks! Could you also bump the lower bound on base to >= 4.8, so Cabal won't try to build with GHC < 7.10?


fix: override default JBS cache resource requests

Description
We've seen issues with jvm build service tests that failed on deploying the JBS cache
After looking at the real resource usage by JBS cache during test I decided to lower the default resource requests (including the PVC size - we're currently using up to ~200 MB)

Issue ticket number and link
Addresses https://issues.redhat.com/browse/STONEBLD-718
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
locally
ginkgo --focus "JVM Build" --v ./cmd/ -- --config-suites=$PWD/tests/e2e-demos/config/default.yaml

Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("[test_id:01] DEVHAS-62 devfile source")
[ ] I have updated labels (if needed)

/retest

/test redhat-appstudio-e2e


Fix to allow installation on FreeBSD 11.1 STABLE

FreeBSD appends Python version numbers to jupyter commands which breaks the IJulia build process. This quick and dirty fix allows installation for Python 3.6 on FreeBSD (the most recent version in FreeBSD 11.1 STABLE).
Are there any alternative workarounds using environment variables? Perhaps there could be a jupyterkernelspec environment variable for this?

jupyter3.6 kernelspec doesn’t work?

No, unfortunately it seems like the closest thing is:
jupyter -kernelspec-3.6


Updating sourcedefinitions with correct subscription id.

Updating sourcedefinitions with correct subscription id since name no longer corresponds to subscription id.
Task editor changes are done in PR: https://mseng.visualstudio.com/DefaultCollection/VSOnline/_git/VSO/pullrequest/51933

Approved, please cherry-pick to M89 as needed


Implement adapter Name and add Name constant

can you fix the code coverage?

you can do unit test trick like extracting the panic checking code
it's easier to maintain 100% coverage than just letting it drops

I don't see reason to simulate code coverage percentage when actual case is not really checked

it's to maintain code coverage
easier to enforce 100% code coverage policy than allowing coverage to be dropped case by case
what we do here is unit test, so IMO it's acceptable to do that, in fact we should make the code unit testable and sometimes it's required repeated refactoring
we must do actual case test when we are responsible for the logic, but for opening connection and etc, it's implemented by driver (and they are responsible for it) so it's okay to just simulate it

IMO, this is not much different than when we mock functions to do unit test

Fixed it a bit different by mocking db.Open and this way actually kind a testing that code path


az cli can not filter on KV items with no label using the --label parameter

According to the docs, you can query for KV items that don't have a label by using label=%00. This does not work when using the az cli.
Example
az appconfig kv list -n $appConfigName --label '%00'

When querying for no label or E-1, only items matching E-1 are returned.
az appconfig kv list -n $appConfigName --label '%00,E-1'

Thanks for reporting this! The document that you mentioned is for restful API instead of CLI.  If you want to query items without a label just do
az appconfig kv list -n $appConfigName --label ""

We do have a bug for listing multiple labels which contains "no label". We will fix this and add examples for query no label items in next release in November.

That syntax didn't work for me (when using powershell) to query blank labels. Running:
az appconfig kv list -n $appConfigName --label ""

resulted in an error
az appconfig kv list: error: argument --label: expected one argument

Instead I needed to use this syntax:
az appconfig kv list -n $appConfigName --label=""

For current CLI implementation, we use empty string to represent null label. However, different command shell has different behaviors parsing the arguments. Doc. CLI framework team is still working on adding more details for quoting issues for powershell.
Regarding to az appconfig kv list  label issue, there is a code review ongoing to fix.

As for clarity you can explicitly filter keys without a label in Powershell or cmd prompt using the \0 value in the label filter :
az appconfig kv list -n myappconfig --label \0


Add auto-fix

We need to add auto-fix for errors:

missedNotDead: add not dead to the end.
countryWasIgnored: add >0.3% to the end (or replace other > query)?
limitedBrowsers: add last 2 versions, not dead.
alreadyDead: remove dead browser

We need to change tool API: lint() => { id, message }[] → lint() => { id, message, fixed }[]

Hi. What do you mean by fixed? Is it fixed part of query?

last 2 version → last 2 versions, not dead
last 2 version → last 2 version, >0.3%
last 1 chrome version → last 1 chrome version, last 2 versions, not dead
defaults, >1%, not IE 11 → defaults, >1%

We need to change tool API: lint() => { id, message }[] → lint() => { id, message, fixed }[]

Where in this signature is the corrected result? always put the fixed version in fixed?

always put the fixed version in fixed?

yes

Wasn't this already fixed in #3?


refactor minigui extensions

I stumbled on some of the copy-pasted code in gtp_extensions and it's a bit tricky to work around with the new hyperparam work.
Can you at some point refactor this so that the search logic code isn't copy-pasted?
One suggestion for how this might work is for strategies.MCTSPlayerMixin.suggest_move can have callbacks registered, and by default those callbacks do nothing, but gtp_extensions can hook into those callbacks to retrieve debug stats.

Yeah, sorry about that :/
I was rushing to get the demo ready in time for the conference.
I'll clean it up this week.

I am halfway through, but I got sidetracked by other things. It's at the top of my list, so I'll likely get to it this afternoon or tomorrow.


Cursor

newCursor isn't implemented
I want to place a table at the place of a paragraphe but without success

A ticket is already open for this issue


Feature/rx

@Truba any news on this?

Also, regarding the presenter interface, what seems nice and descriptive to me would be this method
Example:
func setupBinding(_ input: Login.ViewOutput) -> Login.ViewInput

What do you think?


Separate snapshot store

Should the snapshot store be a separate port? Since business logic can have bugs or will need to be changed over time, snapshots may need to be dropped.  Another scenario I can think of is being able to drop previous snapshots to save on storage costs since they any previous snapshots could be no longer relevant depending on business requirements.
Currently the snapshots are stored in-stream which would cause non-contiguous versioning if a snapshot had to be deleted after a bugfix.  I’m not sure that’s even a problem but something that came to mind.
Also, storing the snapshot in-stream can fail due to concurrency, which probably isn’t a big deal either but wanted to note.

I'm not sure about the type of scenarios you are considering here, but looks like you are trying to backfill aggregate snapshots after fixing bugs or adding features that modify the state. From an accountant's perspective, changing history is usually not desired, and you should probably consider "tagging" the stream when you introduce breaking changes in the aggregate logic. The goal is always the same, being able to replay the aggregate through history, considering bugs and versions as those happened, and you can always use snapshots to shortcut (or tag) the starting point.
If your goal is to save on storage costs, try another accounting strategy => "closing the books" every year or whatever feels like the proper retention time.
The framework should be consistent when storing events + snapshots, using ACID to avoid racing conditions.

These are hypothetical scenarios but consider when a state snapshot is written with bad aggregate logic.  (Of course the events could have been written incorrectly, which is another problem that could cause a loss of historical facts/data in the system)  But when the aggregate internal state calculation is corrected and deployed, the aggregate will not have access to the events before the "bad" snapshot, rendering the log of historical facts useless in deriving a correct current aggregate state.  The current drain implementation does not have the option to ignore snapshots and build the state from and through the complete stream history.

After reading the comment here I realize that a manual way of correcting toxic snapshots would be to create a script to manually load() the stream of each aggregate, ignoring previous snapshots and rebuilding a new correct snapshot and committing it to the stream.

We are probably looking at edge cases here, but you can always recreate streams with options to remove snapshots or merge/split sub-streams... for example, when aggregate logic or aggregate boundaries are redefined. These operations are usually maintenance scripts such as the one you are suggesting.

Very interesting discussion. There are trade-offs in whichever way snapshots are managed.  I share the same apprehension as described here, but having snapshots in the same stream does make the system simpler and perhaps more performant in aggregate hydration.
I am though running into the issue of stream contention when a snapshot is attempted to be written.  My use-case involves catching webhooks events to various streams and sometimes two webhook commands can occur on the same stream very close together in time.  If the first webhook triggers a snapshot but the second webhook write wins on the race to make that commit, the snapshot will fail due to concurrency error.  (I handle the inverse with retry of the webhook command at the application level.)  Perhaps snapshotting should have built in retry?  Of course missing a snapshot is never a bad thing so I guess the errors can be ignored but this sort of contention seems like it can degrade application performance.

In that case, the last snapshot should win the race, all others should fail with concurrency errors.


punycode` module deprecated

Describe the bug
DeprecationWarning: The punycode module is deprecated.
To Reproduce
$ docker compose build

See error
(node:41) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alter
=> => # native instead.

Nor critical but flag a warning when trying to build Dockerfile!

We're not directly dependent upon Punycode so it should not cause any issues.

Súper 👍  and great news !!!Sent from my iPhoneOn Sep 23, 2024, at 8:13 AM, ItzCrazyKns @.***> wrote:
Closed #370 as completed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


CMake regex for Git author/date information extractions can be too greedy

Consider doing this with git log --pretty and perhaps with Python.

Wasn't this solved by #179?

Yes, indeed. Thanks! Closing.


Parameters: [S3DeploymentBucket, S3DeploymentRootKey] must have values into the development of a new plugin

Amplify CLI Version
12.0.3
Question
I am trying to develop a new plugin that will works like Searchable and Algolia.
I created a class OramaSearchableTransformer that extends TransformerPluginBase and implements TransformerPluginProvider.
At the moment I am testing this plugin in a basic Amplify app with a schema like this
type Todo @model {
  id: ID!
  name: String!
}

type User @model @oramaSearchable(schema:{
  id: string,
  name: string
}) {
  id: ID!,
  name: String!
}

the plugin is imported via the /amplify/backend/api/<API_NAME>/transform.conf.json file, the command amplify api gql-compile works fine, but when i try to do amplify push I receive the error
Resource is not in the state stackUpdateComplete
Name: OramaStack (AWS::CloudFormation::Stack),
Event Type: update,
Reason: Parameters: [S3DeploymentBucket, S3DeploymentRootKey] must have values,
IsCustomResource: false

The operations that I am doing inside the plugin are:

create a new bucket that will contain the schema of the entity
create a lambda that will manage the research
create a lambda that will manage the insert/modify/remove
grant all the correct permission to the lambdas
deploy with BucketDeployment a json file on the bucket (this json represent the schema for orama)

I think that BucketDeployment triggers this error because is the code that calls new BucketDeployment is removed there is no error and for what I have seen nobody uses that class on an amplify plugin.
So the question is, how do i deploy my schema on my S3 bucket?

Any suggestion?

Hi @paciops, Thank you for bringing this to our attention. Unfortunately, we do not have any documentation specifically addressing this issue. Based on the error you provided, it seems that the S3DeploymentBucket and S3DeploymentRootKey were not passed to the CloudFormation stack. These keys are typically available in the root-cloudformation-stack.json file and passed through the nested stack via the parameters.json file. We recommend adding the appropriate values for these keys in the parameters.json file and testing if it resolves the issue. Please let us know if you have any further questions or concerns.

Hi @AnilMaktala, unfortunately I cannot specify my S3DeploymentBucket and S3DeploymentRootKey into the parameters.json due to the fact that these two values are generated by the CDK, in fact as you can see here
https://github.com/intales/amplify-category-orama/blob/6a6670a8f320abf8b2ace09ed113f7c25e7604af/src/cdk/create_db_bucket.ts#L15-L22
my BucketDeployment depends on (or at least I think) the previously created Bucket

Hi @paciops
I am not sure if this would help you, but I just spent 2 hours debugging what's is going on, because I was getting the same error when I tried to access a CDK output as a lambda env variable.
At first, I followed https://github.com/aws-amplify/amplify-cli/issues/9087#issuecomment-1454163584
Then I saw this comment here: https://github.com/aws-amplify/amplify-cli/issues/12833#issuecomment-1599049146
And I remembered I have seen this tutorial before: https://gist.github.com/dmost714/e914c865e54f9e77a1e49cda3dc78b20
For me, I forgot to do amplify env checkout dev , so my local did not have the output yet.


KeyError: 'PROVIDE_AUTOMATIC_OPTIONS' (Flask update)

Describe the bug
App won't start after default deployment. I ran the deployment from the Azure OpenAI studio:

This lets you create a WebApp and it deploys it with a link back to this repo.
To Reproduce
Steps to reproduce the behavior:

Deploy the application.
Wait for the deployment to complete as indicated in the studio.
Access the deployed App Service.
Connect to the front end.
Encounter the following application error:

Notice KeyError: 'PROVIDE_AUTOMATIC_OPTIONS' (trying to access missing key from dict).

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Configuration: Please provide the following

Azure OpenAI model name and version:  gpt-4o 2024-05-13
Is chat history enabled? NO
Are you using data? If so, what data source? Azure AI Search
Verify the startup command and runtime configuration by showing the output of the following az CLI command:

az webapp show --name <app name> --resource-group <resource group name> --query "{startupCommand: siteConfig.appCommandLine, runtime: siteConfig.linuxFxVersion}"

Output:
{
  "runtime": "PYTHON|3.11",
  "startupCommand": "python3 -m gunicorn app:app"
}

Logs

If the application is crashing after deployment, please share the application logs using the following az CLI command:

az webapp log tail --name <app name> --resource-group <resource group name>

2024-11-14T09:17:56.079664765Z    _____
2024-11-14T09:17:56.079697797Z   /  _  \ __________ _________   ____
2024-11-14T09:17:56.079704350Z  /  /_\  \\___   /  |  \_  __ \_/ __ \
2024-11-14T09:17:56.079710060Z /    |    \/    /|  |  /|  | \/\  ___/
2024-11-14T09:17:56.079715300Z \____|__  /_____ \____/ |__|    \___  >
2024-11-14T09:17:56.079720950Z         \/      \/                  \/
2024-11-14T09:17:56.079726401Z A P P   S E R V I C E   O N   L I N U X
2024-11-14T09:17:56.079731771Z
2024-11-14T09:17:56.079736890Z Documentation: http://aka.ms/webapp-linux
2024-11-14T09:17:56.079742000Z Python 3.11.8
2024-11-14T09:17:56.079747590Z Note: Any data outside '/home' is not persisted
2024-11-14T09:18:03.601278888Z Starting OpenBSD Secure Shell server: sshd.
2024-11-14T09:18:03.842016356Z WEBSITES_INCLUDE_CLOUD_CERTS is not set to true.
2024-11-14T09:18:03.951547889Z Site's appCommandLine: python3 -m gunicorn app:app
2024-11-14T09:18:03.953459532Z Launching oryx with: create-script -appPath /home/site/wwwroot -output /opt/startup/startup.sh -virtualEnvName antenv -defaultApp /opt/defaultsite -userStartupCommand 'python3 -m gunicorn app:app'
2024-11-14T09:18:04.810544737Z Found build manifest file at '/home/site/wwwroot/oryx-manifest.toml'. Deserializing it...
2024-11-14T09:18:04.812617486Z Build Operation ID: 8f55ad6ea80affdf
2024-11-14T09:18:04.813522496Z Oryx Version: 0.2.20240501.1, Commit: f83f88d3cfb8bb6d3e2765e1dcd218eb0814a095, ReleaseTagName: 20240501.1
2024-11-14T09:18:04.813590012Z Output is compressed. Extracting it...
2024-11-14T09:18:04.818404618Z Extracting '/home/site/wwwroot/output.tar.gz' to directory '/tmp/8dd04876cddf300'...
2024-11-14T09:18:06.699019076Z App path is set to '/tmp/8dd04876cddf300'
2024-11-14T09:18:07.123746780Z Writing output script to '/opt/startup/startup.sh'
2024-11-14T09:18:08.703836260Z Using packages from virtual environment antenv located at /tmp/8dd04876cddf300/antenv.
2024-11-14T09:18:08.703879380Z Updated PYTHONPATH to '/opt/startup/app_logs:/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages'
2024-11-14T09:18:17.261959552Z [2024-11-14 09:18:17 +0000] [73] [INFO] Starting gunicorn 20.1.0
2024-11-14T09:18:17.261994306Z [2024-11-14 09:18:17 +0000] [73] [INFO] Listening at: http://<IP_ADDRESS>:8000 (73)
2024-11-14T09:18:17.262002672Z [2024-11-14 09:18:17 +0000] [73] [INFO] Using worker: uvicorn.workers.UvicornWorker
2024-11-14T09:18:17.266937300Z [2024-11-14 09:18:17 +0000] [75] [INFO] Booting worker with pid: 75
2024-11-14T09:18:17.351235941Z [2024-11-14 09:18:17 +0000] [76] [INFO] Booting worker with pid: 76
2024-11-14T09:18:17.394918174Z [2024-11-14 09:18:17 +0000] [77] [INFO] Booting worker with pid: 77
2024-11-14T09:18:17.412121099Z [2024-11-14 09:18:17 +0000] [78] [INFO] Booting worker with pid: 78
2024-11-14T09:18:17.503306224Z [2024-11-14 09:18:17 +0000] [79] [INFO] Booting worker with pid: 79
2024-11-14T09:18:43.599633576Z /tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/pydantic/main.py:214: UserWarning: A custom validator is returning a value other than `self`.
2024-11-14T09:18:43.599905304Z Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.
2024-11-14T09:18:43.599917096Z See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.
2024-11-14T09:18:43.599924329Z   warnings.warn(
2024-11-14T09:18:43.599930280Z /tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/pydantic/main.py:214: UserWarning: A custom validator is returning a value other than `self`.
2024-11-14T09:18:43.599936743Z Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.
2024-11-14T09:18:43.599942623Z See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.
2024-11-14T09:18:43.599948565Z   warnings.warn(
2024-11-14T09:18:43.659586120Z /tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/pydantic/main.py:214: UserWarning: A custom validator is returning a value other than `self`.
2024-11-14T09:18:43.659714911Z Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.
2024-11-14T09:18:43.659726512Z See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.
2024-11-14T09:18:43.659733435Z   warnings.warn(
2024-11-14T09:18:43.680198019Z /tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/pydantic/main.py:214: UserWarning: A custom validator is returning a value other than `self`.
2024-11-14T09:18:43.680315559Z Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.
2024-11-14T09:18:43.680323744Z See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.
2024-11-14T09:18:43.680330166Z   warnings.warn(
2024-11-14T09:18:43.685571916Z /tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/pydantic/main.py:214: UserWarning: A custom validator is returning a value other than `self`.
2024-11-14T09:18:43.685653559Z Returning anything other than `self` from a top level model validator isn't supported when validating via `__init__`.
2024-11-14T09:18:43.685662916Z See the `model_validator` docs (https://docs.pydantic.dev/latest/concepts/validators/#model-validators) for more details.
2024-11-14T09:18:43.685669969Z   warnings.warn(
2024-11-14T09:18:43.916490090Z [2024-11-14 09:18:43 +0000] [77] [ERROR] Exception in worker process
2024-11-14T09:18:43.916534463Z Traceback (most recent call last):
2024-11-14T09:18:43.916546846Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
2024-11-14T09:18:43.916553539Z     worker.init_process()
2024-11-14T09:18:43.916560572Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/uvicorn/workers.py", line 66, in init_process
2024-11-14T09:18:43.916578105Z     super(UvicornWorker, self).init_process()
2024-11-14T09:18:43.916584226Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/workers/base.py", line 134, in init_process
2024-11-14T09:18:43.916590147Z     self.load_wsgi()
2024-11-14T09:18:43.916595908Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
2024-11-14T09:18:43.916602841Z     self.wsgi = self.app.wsgi()
2024-11-14T09:18:43.916608952Z                 ^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916684393Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/app/base.py", line 67, in wsgi
2024-11-14T09:18:43.916696065Z     self.callable = self.load()
2024-11-14T09:18:43.916702868Z                     ^^^^^^^^^^^
2024-11-14T09:18:43.916707526Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
2024-11-14T09:18:43.916711714Z     return self.load_wsgiapp()
2024-11-14T09:18:43.916715561Z            ^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916719398Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
2024-11-14T09:18:43.916723476Z     return util.import_app(self.app_uri)
2024-11-14T09:18:43.916727313Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916731120Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/gunicorn/util.py", line 359, in import_app
2024-11-14T09:18:43.916735108Z     mod = importlib.import_module(module)
2024-11-14T09:18:43.916738945Z           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916742792Z   File "/opt/python/3.11.8/lib/python3.11/importlib/__init__.py", line 126, in import_module
2024-11-14T09:18:43.916746739Z     return _bootstrap._gcd_import(name[level:], package, level)
2024-11-14T09:18:43.916750617Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916754484Z   File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
2024-11-14T09:18:43.916758902Z   File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
2024-11-14T09:18:43.916763100Z   File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
2024-11-14T09:18:43.916767318Z   File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
2024-11-14T09:18:43.916771305Z   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
2024-11-14T09:18:43.916776505Z   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
2024-11-14T09:18:43.916780593Z   File "/tmp/8dd04876cddf300/app.py", line 885, in <module>
2024-11-14T09:18:43.916784690Z     app = create_app()
2024-11-14T09:18:43.916788548Z           ^^^^^^^^^^^^
2024-11-14T09:18:43.916798957Z   File "/tmp/8dd04876cddf300/app.py", line 45, in create_app
2024-11-14T09:18:43.916802984Z     app = Quart(__name__)
2024-11-14T09:18:43.916806872Z           ^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916810759Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/quart/app.py", line 336, in __init__
2024-11-14T09:18:43.916814757Z     self.add_url_rule(
2024-11-14T09:18:43.916818864Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/flask/sansio/scaffold.py", line 47, in wrapper_func
2024-11-14T09:18:43.916823002Z     return f(self, *args, **kwargs)
2024-11-14T09:18:43.916826859Z            ^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916830696Z   File "/tmp/8dd04876cddf300/antenv/lib/python3.11/site-packages/flask/sansio/app.py", line 641, in add_url_rule
2024-11-14T09:18:43.916834724Z     if "OPTIONS" not in methods and self.config["PROVIDE_AUTOMATIC_OPTIONS"]:
2024-11-14T09:18:43.916838771Z                                     ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-14T09:18:43.916842709Z KeyError: 'PROVIDE_AUTOMATIC_OPTIONS'

Additional context
Recent Flask update is causing this issue: Related Issue #371 on Quart's GitHub Repository

Solved by changing deployment type to manual and pinning Flask[async]==3.0.3 on requirements.txt

Was using it since two weeks in a manual deployment just cloning the repo. Encountered same issue since today. Pinning flask also did it for me.
Thanks for sharing the tip @alvarorgzalonso  !! (I'm newbie on python so really helps)

For me, it's not really solved; the deployment is successful, but when I go to the page, I get this new error:
2024-11-14T12:40:38.7036427Z TypeError: Quart.__call__() missing 1 required positional argument: 'send'
2024-11-14T12:40:38.9551849Z [2024-11-14 12:40:38 +0000] [94] [ERROR] Error handling request /
2024-11-14T12:40:38.9552302Z Traceback (most recent call last):
2024-11-14T12:40:38.9552345Z   File "/tmp/8dd04a8b3abbcdb/antenv/lib/python3.11/site-packages/gunicorn/workers/sync.py", line 136, in handle
2024-11-14T12:40:38.9552375Z     self.handle_request(listener, req, client, addr)
2024-11-14T12:40:38.9555131Z <IP_ADDRESS> - - [14/Nov/2024:12:40:38 +0000] "GET / HTTP/1.1" 500 0 "-" "-"
2024-11-14T12:40:38.9559002Z   File "/tmp/8dd04a8b3abbcdb/antenv/lib/python3.11/site-packages/gunicorn/workers/sync.py", line 179, in handle_request
2024-11-14T12:40:38.9559087Z     respiter = self.wsgi(environ, resp.start_response)
2024-11-14T12:40:38.9559116Z                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I can imagine it's because of a library version mismatch. Is this happening to you, @alexandreweiss?

@alexandreweiss thank you for your response. The second issue was due to my incorrect configuration of the WebApp variables.

Thank you. We had the same issue today and it is fixed by pinning Flask[async]==3.0.3 on requirements.txt.

Confirmed this fix works.

Confirm this fix works 👍


Add Dockerfile, add requirements.txt and update README.md

Hi @h4rm0ny, thanks for submitting this. It would be nice to have a docker file, but I'm not fond of having a requirements.txt. Pip can install requirements just fine without it using the setup.py or via pypi (unless this is a docker specific requirement that i'm not aware of).
Also due to security reasons all commits must be signed in this repository, you can either do this by adding a GPG key to your account or by committing it on GitHub directly.
Closing this one for now.


Some implementations of nppas.subdivide_* produce empty meshes when processing gastruloid

... not sure why.
To reproduce:
import napari_process_points_and_surfaces as nppas
gastruloid = nppas.gastruloid()

subdivided_gastruloid = nppas.subdivide_loop_vedo(gastruloid, number_of_iterations=1)
subdivided_gastruloid

Workaround 1: Use nppas.subdivide_adaptive()
Workarounnd 2: install open3d and use this:
import napari_process_points_and_surfaces as nppas
gastruloid = nppas.gastruloid()

subdivided_gastruloid = nppas.subdivide_loop(gastruloid, number_of_iterations=1)
nppas.SurfaceTuple(subdivided_gastruloid)

nppas.subdivide_linear and subdivide_butterfly appear to have the same issue.
nppas.subdivide_adaptive appears to work though.

Hey Johannes @jo-mueller ,
would you mind taking care of this issue? Also see the related PR. Feel free to use its branch to test things.
Thanks!

Hi @haesleinhuepf ,
I can have a look. Judging from what @marcomusy suggested here, would it be an option to implement the vedo isosurface method in nppas as an option to marching cubes (as opposed to augmenting marching cubes with multiple failsafes)?
Nonetheless, these failsafes should ultimately be available, too.

implement the vedo isosurface method in nppas as an option to marching cubes

Yes, let's do this step by step. If nppas has a isosurface function, we can play with it. If I understand it right, it is an alternative to marching cubes, no? If it does its job well, we could use it, recommend it in the documentation and then deprecate the partially broken marching cubes.


Underline on reference link breaks on the brackets

When being hovered, the underline on reference link breaks on the brackets part. See screenshot, eg. arc() below.
cc @outofambit @davepagurek @limzykenneth @ccanash

Thanks @davepagurek. Tagging the designers @stefanietam @tyler-yin to take a look at this issue, since I wasn't able to find the hover state of the reference page in the design.
I think we can adjust the hover state style because the in current p5.js website reference page, the hovered links won't skip brackets (see screenshot below).

Hi,
Would it be possible to slightly adjust the text-underline-offset property until the underline no longer breaks?
https://developer.mozilla.org/en-US/docs/Web/CSS/text-underline-offset
Thanks!

Thanks @tyler-yin. To keep link style consistent across the website, do you have a recommended offset value in this case?

For text that uses Courier, we recommend text-underline-offset: 15%
For text that uses National Park we recommend text-underline-offset: 10%
However, for National Park, please keep in mind that with this offset value, the descenders will still break the underline. Unfortunately, there isn't really an ideal offset value that will keep the underline unseparated.
Ultimately, we are also fine with the underline being kept as is!

In that case I think we'll keep it. I personally think it adds some character anyway. @Qianqianye @davepagurek What do you think?

sounds good to me!


working with AngularjS2?

Hello,
first of all, nice work dude i love this module.
Actual i want to go forward to AngularJS2, is there a way to get your module working with AngularJS2? Becouse i am planing to update all older AJ1 developments to AJ2.
Please let my know.
Greeting
Dirk

I have a plan to move to angular2 as soon as I found a way to pakage this in angular2


Remove organizations and related concepts

We previously implemented a hierarchy with all users existing under an organization, and organization admins managing the approval/rejection of prospective users, and site super-admins having Power Over All. We are no longer going to use that model; instead, prospective users are Applicants and only super-admins have the power to promote them to Users. Thus, the concepts that can be removed: organizations (Organization), organizational admins (User.admin), and user approval (User.approval).
This PR removes all of that, while updating anything else deprecated by that removal.

Remove Organization model and scaffolding (controller, helper, tests, fixtures, etc.)
Remove deprecated attributes, e.g. User.admin, User.approved, and foreign-key references / indices
Remove deprecated user-approval views, actions, JavaScript, etc.
Update tests, fixtures, and seeds
Update authentication methods to treat super_admin as super_user rather than the organization admin

Testing:

Run rails db:migrate
Run tests
Log in and poke around as an admin (default seed<EMAIL_ADDRESS>and user (user@example.com), particularly the settings screens and archiving a URL

Closes #302

When running tests I got the following:
# Running:

.........F

Failure:
ApplicantTest#test_can_convert_terms-acceptance_attributes_from_database [/Users/christopher/Repositories/Reporters_Lab/zenodotus/test/models/applicant_test.rb:36]:
Expected false to be truthy.

rails test test/models/applicant_test.rb:35

F

Failure:
ApplicantTest#test_cannot_un-accept_terms [/Users/christopher/Repositories/Reporters_Lab/zenodotus/test/models/applicant_test.rb:49]:
Expected false to be truthy.

rails test test/models/applicant_test.rb:47

E

Error:
ApplicantTest#test_can_edit_applicant_without_triggering_acceptance_errors:
ActiveRecord::RecordInvalid: Validation failed: Accepted terms Terms must be accepted.
    test/models/applicant_test.rb:62:in `block (2 levels) in <class:ApplicantTest>'
    test/models/applicant_test.rb:61:in `block in <class:ApplicantTest>'

rails test test/models/applicant_test.rb:58

Is this on me or your code?

For history' sake: we realized Chris was running into those errors because I had modified the migrations on the Applicant work in #313 while it was still safely on the branch. Though untangling that did reveal that the migration from this PR isn't reversible, which is… bad! (It runs into NULL constraints when trying to recreate the organization_id association apparently.) None of us like having a point of no return beyond which we can't reverse migrations. But! We're also pre-launch so calling it okay.


Data Cleaning and Filtering: Ability to see examples of word being used

Ability to double click on a word in either the removed or included list to show a list of documents where that word is being used.
This would help users better familiarize themselves with the dataset as part of their thematic analysis.

Added code to generate a sample of up to 20 documents using a fixed random seed.


Enable using node LTS

Pull request to enable development using the latest node version

Now moodle is able to run with node LTS version, but not on firefox


Tag counts seem to be wrong

http://vimawesome.com/?q=tag:plugin shows three results:

This contradicts the sidebar, which says the tag 'plugin' is used 5 times:

This seems to be due to the fact that we filter out plugin managers for search results (https://github.com/vim-awesome/vim-awesome/blob/master/db/plugins.py#L556-L566) but we don't do the same thing for tag count (https://github.com/vim-awesome/vim-awesome/blob/master/db/categories.py#L28-L37)


Auto Generated Transcripts

Is there a specific way that this needs to be called in order to access them? It seems to have worked locally when I made a native_host.py file to route it, but when I try it on my flaskserver No matter what, I'm getting:
python3 -c "from youtube_transcript_api import YouTubeTranscriptApi; print(YouTubeTranscriptApi.get_transcript('VIDEO_ID'))"
Traceback (most recent call last):
File "", line 1, in
File "/var/www/flaskapp/venv/lib/python3.12/site-packages/youtube_transcript_api/_api.py", line 154, in get_transcript
cls.list_transcripts(video_id, proxies, cookies)
File "/var/www/flaskapp/venv/lib/python3.12/site-packages/youtube_transcript_api/_api.py", line 71, in list_transcripts
return TranscriptListFetcher(http_client).fetch(video_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/var/www/flaskapp/venv/lib/python3.12/site-packages/youtube_transcript_api/_transcripts.py", line 49, in fetch
self._extract_captions_json(self._fetch_video_html(video_id), video_id),
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/var/www/flaskapp/venv/lib/python3.12/site-packages/youtube_transcript_api/_transcripts.py", line 63, in _extract_captions_json
raise TranscriptsDisabled(video_id)
youtube_transcript_api._errors.TranscriptsDisabled:
Could not retrieve a transcript for the video https://www.youtube.com/watch?v=VIDEO_ID! This is most likely caused by:
Subtitles are disabled for this video
If you are sure that the described cause is not responsible for this error and that a transcript should be retrievable, please create an issue at https://github.com/jdepoix/youtube-transcript-api/issues. Please add which version of youtube_transcript_api you are using and provide the information needed to replicate the error. Also make sure that there are no open issues which already describe your problem!
(venv) root@fvtal-host:/var/www/flaskapp#
Does not matter where/how the command is formatted.
So wondering if the point is for it to be able to fetch auto generated transcripts regardless of this issue - why I can't.
Thanks

duplicate of #303


[sbs] Handle SBS News URLs without IDs

Before submitting this pull request I have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Before...
% ./bin/youtube-dl https://www.sbs.com.au/news/are-the-campaigns-working-voters-speak-out
[generic] are-the-campaigns-working-voters-speak-out: Requesting header
WARNING: Falling back on generic information extractor.
[generic] are-the-campaigns-working-voters-speak-out: Downloading webpage
[generic] are-the-campaigns-working-voters-speak-out: Extracting information
ERROR: Unsupported URL: https://www.sbs.com.au/news/are-the-campaigns-working-voters-speak-out

After
% ./bin/youtube-dl https://www.sbs.com.au/news/are-the-campaigns-working-voters-speak-out
[SBS] None: Downloading webpage
[SBS]<PHONE_NUMBER>782: Downloading JSON metadata
[ThePlatform] Vznr2YGb83mF: Downloading SMIL data
[ThePlatform] Vznr2YGb83mF: Downloading m3u8 information
[ThePlatform] Vznr2YGb83mF: Downloading JSON metadata
[download] Are the campaigns cutting through-Vznr2YGb83mF.mp4 has already been downloaded
[download] 100% of 28.64MiB

@dstftw : Do my changes address all of your concerns?

@dstftw Can we please merge or close this?

This PR has been open for over a year and the feedback on it hasn't helped me get it in a state to merge.
I sought some help in the IRC channel but none was forthcoming, so I think I'll just close it.


Webamp context menu can go offscreen

This is something I've solved with my own context menus but it is a problem with Webamp. I mention it here because I might be able to adjust this myself rather than wait for Webamp to fix it. I haven't looked into the events I can hook into, but I am hopeful it's possible.

This is so minor and barely involves me. Closing for now.


Replace fixtures custom admin handling by Agent.as(Agent.ADMIN)

Some users are currently experiencing intermittent failures with the following error: Cannot read property '_module' of undefined.
That seems to be related with Fixtures having its own way of handling user authentication for admin users, which might lead into conflicts and unexpected errors if admin users try to log in twice, where the second login ends up invalidating the first one.
This PR is replacing the custom authentication handling for admin users on Fixtures side and making use of the Agent abstraction instead.
This is also related and should fix what has been reported on: #145

Coverage decreased (-0.3%) to 95.588% when pulling e43e801bb9ac5baba69558278522a9fbd23cab91 on jcsmorais:replace-fixtures-admin-handling into 0a7363a5c701ddce3fc86333874de37e507270c6 on sugarcrm:master.

Coverage decreased (-0.3%) to 95.588% when pulling e43e801bb9ac5baba69558278522a9fbd23cab91 on jcsmorais:replace-fixtures-admin-handling into 0a7363a5c701ddce3fc86333874de37e507270c6 on sugarcrm:master.

Coverage decreased (-0.3%) to 95.549% when pulling e06066510055c05f241d56692d255c9db11f4162 on jcsmorais:replace-fixtures-admin-handling into 0a7363a5c701ddce3fc86333874de37e507270c6 on sugarcrm:master.

Coverage decreased (-0.3%) to 95.549% when pulling ea114ab17b22038cae798c5bd1e79f1d521b96b9 on jcsmorais:replace-fixtures-admin-handling into 0a7363a5c701ddce3fc86333874de37e507270c6 on sugarcrm:master.

Coverage decreased (-0.3%) to 95.549% when pulling e99e84942d4fb8f040e237d58cdaf0bd2c3dd450 on jcsmorais:replace-fixtures-admin-handling into 0a7363a5c701ddce3fc86333874de37e507270c6 on sugarcrm:master.


Merge resources in different configuration?

This can be done together with #29, by adding multiple android_resource rules, and add them into deps of their depender.


register in normal mode pastes in the new line

whenever i do "+p it pastes the result in the new line. Eg. if i have 'bla' in the clipboard and have file:
line[1]
line2

where [x] indicates cursor position in normal mode and i do "+p then i get:
line1
[b]la
line2

instead of:
line1bl[a]
line2

It works fine in the insert mode with Ctrl+v.

Ah, good catch - thanks @pkariz for logging the bug!
I believe this is because we are always defaulting to the MLINE yank register type: https://github.com/onivim/libvim/blob/2eff31df7b8384a93c90222f39140673b3680a75/src/ops.c#L783
I guess, for a single line, perhaps we should be pasting in character mode / MCHAR


[Bug] connot export pdf

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Cloud (https://rxresu.me)
Current Behavior
connot export pdf
Expected Behavior
No response
Steps To Reproduce
No response
What browsers are you seeing the problem on?
No response
What template are you using?
None
Anything else?
No response

Seconding this bug. Was able to download until a few days back, I think, but it is impossible to download as PDF now. Though I've switched browsers and tried Opera and Google Chrome, I was not able to download PDF.

Tripling this bug. Wouldn't work for Firefox either.

The solution for me was removing a special character 'ü' from the resume. It now works on chrome. Still not on firefox but hasn't for a while anyway :) A similar discussion was held here https://github.com/AmruthPillai/Reactive-Resume/issues/2059

New to the project. Literally does not work. Nothing. Anything, Create sample resume, create empty resume and direct export -> about:blank pops out

The solution for me was removing a special character 'ü' from the resume. It now works on chrome. Still not on firefox but hasn't for a while anyway :) A similar discussion was held here #2059

Yes, this is also the problem for me

Same issue for me [Unable to export Resume]
Please let me know if any info is needed

I also encountered this problem. My solution is to change the project name to all English, and then it can be exported. For example, "Frontend".

in my case i need a french resume 😅

I second @Shadowzzh, change the project name to all English

the project name is already in english, i cannt even download the template as pdf

Do you get another blank page ?

same issue apply to blank page with 'test' as project name

same issue applies on chrome and firefox. Pressing the export button just yields a blank page. No ü characters

Same issue here. I just get a blank page, everything is in english. My logs look like this when I try to download, looks like I don't have access to the file? The ECH fallback thing is a cloudflare thing but that's also a possiblilty.
reactive-resume-chrome    |   browserless.io:server:trace  Handling inbound WebSocket request on "/?token=REDACTED" +39s
reactive-resume-chrome    |   browserless.io:server:trace  Found matching WebSocket route handler "?(/),/chromium?(/)" +1ms
reactive-resume-chrome    |   browserless.io:server:trace  Authorizing WebSocket request to "http://<IP_ADDRESS>:3000/?token=REDACTED&launch=%7B%7D" +0ms
reactive-resume-chrome    |   browserless.io:server:trace  Validating route query-params with QUERY schema +0ms
reactive-resume-chrome    |   browserless.io:limiter:info  (Running: 0, Pending: 0) Adding to queue, max time allowed is 10,000ms  +39s
reactive-resume-chrome    |   browserless.io:limiter:info  (Running: 1, Pending: 0) Starting new job  +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> Starting new ChromiumCDP instance +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> ChromiumCDP got open port 34197 +1ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> {
reactive-resume-chrome    |   args: [
reactive-resume-chrome    |     '--remote-debugging-port=34197',
reactive-resume-chrome    |     '--no-sandbox',
reactive-resume-chrome    |     '--user-data-dir=/tmp/browserless-data-dirs/browserless-data-dir-2a5a8f61-56f2-41f1-b951-e1e41dd5c265'
reactive-resume-chrome    |   ],
reactive-resume-chrome    |   executablePath: '/usr/local/bin/playwright-browsers/chromium-1140/chrome-linux/chrome'
reactive-resume-chrome    | } Launching ChromiumCDP Handler +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> ChromiumCDP is running on ws://<IP_ADDRESS>:34197/devtools/browser/b61d39be-0580-4f83-88d9-4dcf05a9e15e +169ms
reactive-resume-chrome    |   browserless.io:router:trace  Running found WebSocket handler. +40s
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> Proxying http://<IP_ADDRESS>:3000/?token=REDACTED&launch=%7B%7D to ChromiumCDP ws://<IP_ADDRESS>:34197/devtools/browser/b61d39be-0580-4f83-88d9-4dcf05a9e15e +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:trace <IP_ADDRESS> Setting up file:// protocol request rejection +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:trace <IP_ADDRESS> GET: https://REDACTED/artboard/preview +4ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:warn <IP_ADDRESS> "net::ERR_ECH_FALLBACK_CERTIFICATE_INVALID": https://REDACTED/artboard/preview +0ms
reactive-resume           | Trace: Error: net::ERR_ECH_FALLBACK_CERTIFICATE_INVALID at https://REDACTED/artboard/preview
reactive-resume           |     at navigate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Frame.js:175:27)
reactive-resume           |     at async Deferred.race (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:36:20)
reactive-resume           |     at async CdpFrame.goto (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Frame.js:141:25)
reactive-resume           |     at async CdpPage.goto (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:585:20)
reactive-resume           |     at async PrinterService.generateResume (/app/dist/apps/server/main.js:13224:13)
reactive-resume           |     at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
reactive-resume           |     at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
reactive-resume           |     at async ResumeController.printResume (/app/dist/apps/server/main.js:13616:25)
reactive-resume           |     at PrinterService.generateResume (/app/dist/apps/server/main.js:13276:21)
reactive-resume           |     at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
reactive-resume           |     at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
reactive-resume           |     at async ResumeController.printResume (/app/dist/apps/server/main.js:13616:25)
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:trace <IP_ADDRESS> Navigation to chrome-error://chromewebdata/ +120ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:warn <IP_ADDRESS> DOMException: SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
reactive-resume-chrome    |     at <anonymous> (:3:15) +35ms
--------------------------------------------------
reactive-resume-chrome    |   browserless.io:limiter:warn  Job has hit timeout after 10,002ms of activity. +49s
reactive-resume-chrome    |   browserless.io:limiter:info  Calling timeout handler +10s
reactive-resume-chrome    |   browserless.io:router:error  Websocket job has timedout, sending 429 response +49s
reactive-resume-chrome    |   browserless.io:limiter:info  (Running: 0, Pending: 0) All jobs complete.  +1ms
reactive-resume-chrome    |   browserless.io:router:trace  WebSocket Request handler has finished. +10s
reactive-resume-chrome    |   browserless.io:browser-manager:info  0 Client(s) are currently connected, Keep-until: 0 +49s
reactive-resume-chrome    |   browserless.io:browser-manager:info  Closing browser session +0ms
reactive-resume-chrome    |   browserless.io:browser-manager:info  Deleting "/tmp/browserless-data-dirs/browserless-data-dir-2a5a8f61-56f2-41f1-b951-e1e41dd5c265" user-data-dir and session from memory +0ms
reactive-resume-chrome    |   browserless.io:ChromiumCDPWebSocketRoute:info <IP_ADDRESS> Closing ChromiumCDP process and all listeners +10s
reactive-resume-chrome    |   browserless.io:server:trace  Websocket connection complete +10s
reactive-resume-chrome    |   browserless.io:browser-manager:info  Deleting data directory "/tmp/browserless-data-dirs/browserless-data-dir-2a5a8f61-56f2-41f1-b951-e1e41dd5c265" +1ms

Same issue here. After changed my resume name from Chinese to English, it was solved.
It seems that special characters (like Chinese) are not supported currently in the name of the resume.

in my case it still only about:blank when i try to download as PDF, on latest docker image

The name of your project should not be Chinese or other specific codes.

Please make sure to read the previous comments since we already indicated that the issue persiste for all languages.
The export feature is broken ⚠

In my case, I have the CV file name as "Español". I just changed the name to : "Spanish". So I think the app doesn't support the ñ.

Please make sure to read the previous comments since we already indicated that the issue persiste for all languages.
The export feature is broken ⚠

Try on PC and make sure you're using only english letters, make a screenshot too

Same issue here. Unable to export PDF and Preview at shared Link broken aswell.

I can quickly help you if you send me one of your resume as json, then I will try to export it and send it to you

I have already converted all the text in the article to English, but it still doesn't work. Clicking on a blank page only results in a blank page. I used both Chrome and Edge browsers, and part of the error log is as follows: react-resume-app-1 | Trace: TargetCloseError: Protocol error (Page.addScriptToEvaluateOnNewDocument): Session closed. Most likely the page has been closed.

I can quickly help you if you send me one of your resume as json, then I will try to export it and send it to you

this is a nice offer, but I think the issue has to be fixed in a high priority manner. It looks to me that this bug breaks the whole software. Whats the point of putting effort into a CV if you can't export it in any kind. Even the public view is broken in my case so it's basically unusable
@AmruthPillai maybe some comment by you as maintainer? Three weeks for a bug like this is a quite long time :D

Yeah I understand

Can you try to rename your resume title in the dashboard?  The Download SIMPLY DOES NOT WORK. No matter the OS, not matter the Browser (Brave (from the video) runs on Chromium). No matter the content, no matter the title.
In the video, I am simply attempting to print A SAMPLE DEFAULT JOHN DOE resume. I receive about:blank.
Logs:
app-1       | Trace: Error [TypeError]: Cannot read properties of null (reading 'cloneNode')
app-1       |     at evaluate (evaluate at processPage (/app/dist/apps/server/main.js:13232:50), :1:50)
app-1       |     at #evaluate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:376:56)
app-1       |     at async ExecutionContext.evaluate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:271:16)
app-1       |     at async IsolatedWorld.evaluate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/IsolatedWorld.js:99:16)
app-1       |     at async CdpFrame.evaluate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Frame.js:342:20)
app-1       |     at async CdpPage.evaluate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:823:20)
app-1       |     at async processPage (/app/dist/apps/server/main.js:13232:39)
app-1       |     at async PrinterService.generateResume (/app/dist/apps/server/main.js:13245:17)
app-1       |     at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
app-1       |     at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
app-1       |     at PrinterService.generateResume (/app/dist/apps/server/main.js:13276:21)
app-1       |     at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
app-1       |     at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
app-1       |     at async ResumeController.printResume (/app/dist/apps/server/main.js:13616:25)
resume_download.webm

+1

+1

Same issue here, self hosted version, throws a blank screen when trying to export the PDF

Same issue here, self hosted version, throws a blank screen when trying to export the PDF
Logs throw this error
Trace: Error: net::ERR_NAME_NOT_RESOLVED at http://host.docker.internal:3000/artboard/preview
at navigate (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Frame.js:175:27)
at async Deferred.race (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/util/Deferred.js:36:20)
at async CdpFrame.goto (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Frame.js:141:25)
at async CdpPage.goto (/app/node_modules/.pnpm/puppeteer-core@22.10.0/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:585:20)
at async PrinterService.generateResume (/app/dist/apps/server/main.js:13224:13)
at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
at async ResumeController.printResume (/app/dist/apps/server/main.js:13616:25)
at PrinterService.generateResume (/app/dist/apps/server/main.js:13276:21)
at async PrinterService.printResume (/app/dist/apps/server/main.js:13171:21)
at async ResumeService.printResume (/app/dist/apps/server/main.js:13969:21)
at async ResumeController.printResume (/app/dist/apps/server/main.js:13616:25)

I fixed this by changing the entries in the docker compose from localhost, to my dockers LAN address
i.e.

      # -- URLs --
      PUBLIC_URL: http://<IP_ADDRESS>:3000
      STORAGE_URL: http://<IP_ADDRESS>:9000/default

This solved it for me! Thanks.

Unfortunately this did not fix it for me, it did make the new tab/window open a lot faster, but it is still showing the about:blank window. I am on Unraid.

It seems like you're facing problems with exporting your document to PDF. Please try the following steps to help resolve the issue:
Step 1: Use the Browser's Built-in Print Function
Instead of using the export button, try using your browser's built-in print function. Make sure you select 'Save as PDF' rather than 'Print to PDF'. Selecting 'Save as PDF' often provides better results for preserving the document's text and structure, ensuring that it remains selectable and searchable.
Please let us know if these steps help or if you encounter any specific error messages during the process!

This works but the result doesn't look great, no icons, no colors, weird footnotes hinting on the original url.


Keys are not aligned

Hello /u/wootpatoot.
I found out this topic: https://www.reddit.com/r/MechanicalKeyboards/comments/89dcin/help_lets_split_row_spacing/
aaand as I am planning to get the PCBs for this lovely keyboard, I double checked the design. So just via checking out the drill file, I can see that keys are misaligned.
I hooked up some small python script and that's what we have:

Python script
from pathlib import Path

data = (Path(__file__).parent.resolve() / 'switch-drills.txt').read_text().split()

xs = []
ys = []

for coord in data:
    x, y = coord.split('Y-')
    x = x.replace('X', '')
    x, y = int(x), int(y)

    xs.append(x)
    ys.append(y)

xs = sorted(set(xs))
ys = sorted(set(ys))

print('used xs:', xs)
print('used ys:', ys)

for x1, x2 in zip(xs[:-2], xs[1:]):
    print(f'x2 - x1 = {x2-x1}')

for y1, y2 in zip(ys[:-2], ys[1:]):
    print(f'y2 - y1 = {y2-y1}')

And:

Extracted drills for main switch holes
X017913Y-018445
X017913Y-033465
X017913Y-041004
X017933Y-025965
X025413Y-018445
X025413Y-025945
X025413Y-033445
X025413Y-040945
X032913Y-018445
X032913Y-025945
X032913Y-033445
X032913Y-040945
X040413Y-018445
X040413Y-025945
X040413Y-033445
X040413Y-040945
X047913Y-018445
X047913Y-025945
X047913Y-033445
X047913Y-040945
X055413Y-018445
X055413Y-025945
X055413Y-033445
X055413Y-040945

Output of "analysis" looks like that:
used xs: [17913, 17933, 25413, 32913, 40413, 47913, 55413]
used ys: [18445, 25945, 25965, 33445, 33465, 40945, 41004]
x2 - x1 = 20
x2 - x1 = 7480
x2 - x1 = 7500
x2 - x1 = 7500
x2 - x1 = 7500
y2 - y1 = 7500
y2 - y1 = 20
y2 - y1 = 7480
y2 - y1 = 20
y2 - y1 = 7480

we should have 6 X coords, we have 7
we should have 4 Y coords, we have 7

Don't get me wrong, this "20" error is like 0.0508 millimeters, so I guess it's not a deal breaker :) as looot of boards got already successfully created. But it's maybe something you would like to address.

Hello @maciejmatczak
I tried resolve this issue #7 .
Could you check it?


About at::Tensor.data<scalar_t>() function in roialign

❓ Questions and Help
AT_DISPATCH_FLOATING_TYPES(input.type(), "ROIAlign_forward", [&] {
    ROIAlignForward_cpu_kernel<scalar_t>(
         output_size,
         input.data<scalar_t>(),
         spatial_scale,
         channels,
         height,
         width,
         pooled_height,
         pooled_width,
         sampling_ratio,
         rois.data<scalar_t>(),
         output.data<scalar_t>());
  });

My question is does the at::Tensor.data<scalar_t>() function transform the tensor to one dimensional array? And what's the purpose of this operation?

hi, i'm also curious about this, have you figured it out?

Hey,
all this does it to get the pointer to the C data.
So input.data<scalar_t>() returns a scalar_t * type.

hi, i'm also curious about this, have you figured it out?

just as the author said, input.data<scalar_t>()returns a scalar_t * type, and you can use this pointer to visit multi dimension tensor data.


Cron Job Problem (Sudo)

Hello, i had a problem about cron job of backup. I wrote a cron job to backup my postgres db. The cron job is for root user.However, the job never worked. I spent almost 3 hours and at the end i figured it out the problem which is (i certainly specified the user(root) to run cron job) sudo. To run backup , it needs sudo , even you specify root. Its non-sense.
I don't know why this happens but i wanted to let you know guys.
Thank you.

Hi @dyrnade, I don't have that particular problem. It all depends on how your ruby is installed, the backup gem is installed, under what user and with sudo or not.
So if configured correctly, everything installed under a non sudo user, you should be able to run it without sudo just fine.


Update explore-data-blob.md

Variable name is different

@iKshitiz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@marktab, you can only sign off in the main PR conversation, not in review comments.

#sign-off


Use graphic instead of list of features

Instead of providing a list of features, test out using a feature graphic.  Check with @dennyglee prior to merging - thanks!

I like this better but I bet we could turn these into a JsonCardDataList and have links to the various material about the features.


Return a non-zero exit-code when a sub-test fails

When running sub-tests explicitly on the command line and that sub-test
fails, the test harness returns 0 from main(). This is problematic
in automated testing environments as failed tests can be hidden.
This patch iterates over all the test results in the resultTestList
after all sub-tests have completed, if any of the tests failed a
non-zero value is returned from parseAndCallCommandLineTests() which
is then propagated up the call stack to main().

@bashbaug I made the changes you suggested, could you approve the PR again if they're what you had in mind?

These changes have been open for a while now and are pretty straightforward.  Merging.


chore: support SDK 9+

Adds support for asset catalog file lookup without hashes (new in SDK 9 - finally). Retains backward compatibility with SDK < 9.

Really thank you @hansemannn !


Filter available sites in flagging conditions, based on user's accounts.

It is currently possible to select sites you don't have an account on, when you edit flagging conditions.
This results in flagging failures, because the system can't select a user based on whether or not they have an account on the site that god spammed.
I propose that the "Sites" dropdown in /flagging/conditions/<id>/edit is filtered based on what sites the user has registered on.
This means that:

The autoflagger won't select users that don't have an account on the target site, eliminating failures due to improperly configured users. (pro)
New accounts won't automatically get added to the filter, a user will have to update their conditions manually. (con)

The SE api exposes the required information at /users/{ids}/associated.
(Note that this request has a max page size of 100).
Additionally, this information could be used to show the user a list of sites they're not yet registered at, linking to site_url/users/join.
(Probably under tools)

Instead of keeping track of the data required for this, I'm doing the next best thing for now: Just completely ignoring those errors. It's extremely fast to cycle to the next eligible user; API calls are cheap and easily sub-100ms from EC2.

I was thinking of a api call on config page load, so you don't have to store it, but that works as well, @Undo1 :+1:
I think this FR can be closed now?

Sounds like it.


Add Sync-AzsdlLabels.ps1 script

I tested this with a couple spcific repos and seemed to work just fine, but have not run it for all repos yet.

/check-enforcer override

There's no other pipelines to run, but check-enforcer was still waiting for...nothing?


integration: restart docker daemon after each test

To be sure that containers from previous tests are not running in the
next test.
The issue was causing failures on master too.

On the failed run https://circleci.com/gh/weaveworks/scope/6648, 106_launch_with_peers_test (1 node) is running after 320_container_edge_cross_host_2_test (2 nodes), and is reusing one of the 2 nodes.
Whereas on the successful run https://circleci.com/gh/weaveworks/scope/6646, 106_launch_with_peers_test and 320_container_edge_cross_host_2_test are started on different CircleCI containers and don't share any GCE nodes.
The scheduler can schedules jobs differently from one time to another.
After a test terminates, all containers (including Scope) are supposed to be stopped by scope_end_suite:
scope_end_suite() {
    end_suite
    for host in $HOSTS; do
        docker_on "$host" rm -f "$(docker_on "$host" ps -a -q)" 2>/dev/null 1>&2 || true
    done
}

This was introduced by https://github.com/weaveworks/scope/commit/8a8520ffc9734b3b64eefab48ec8012e9a6e6f7a ("Stop all containers when test finishes").
Note that if the "docker rm -f" fails to stop the Scope container, we will not know about it and the error is ignored. If that happens, that would explain both why test 106 has two nodes instead of one, and why some ebpf tests have endpoints without ebpf=true (coming from a previous test).
To verify that, I tried to test https://github.com/alban/scope/commit/80911f7edb6ead616a2b15ea310b33fc0416a4df and I got https://circleci.com/gh/alban/scope/120: a lot of tests fail to terminate containers with the error message such as:
List of docker containers on host3-alban-scope-120-0.us-central1-a.scope-integration-tests-158117:
CONTAINER ID        IMAGE                     COMMAND                  CREATED             STATUS              PORTS               NAMES
9acf1f8edc97        peterbourgon/tns-db       "/db db1 db2 db3"        31 seconds ago      Up 30 seconds       9000/tcp            db1
c7a6849e5b73        weaveworks/scope:latest   "/home/weave/entrypoi"   33 seconds ago      Up 32 seconds                           weavescope
Ok, killing all docker containers on host3-alban-scope-120-0.us-central1-a.scope-integration-tests-158117:
Failed to remove container (9acf1f8edc97
c7a6849e5b73): Error response from daemon: {"message":"page not found"}

This is a 404 error. https://github.com/docker/docker/issues/17960 suggests a proxy issue ($NO_PROXY, $HTTP_PROXY) but I don't see any such variables defined on CircleCI. It could be CircleCI specific changes on the client side since they use their own changes. Or it could be an API issue between the docker client (CircleCI) and the docker server (GCE):
# docker version
Client:
 Version:      1.10.0-circleci
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   543ec7b-unsupported
 Built:        Tue Feb 16 17:11:12 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:42:29 2017
 OS/Arch:      linux/amd64

Note that "docker rm -f" does not work when Docker client & server are on CircleCI:
ubuntu@box2121:~$ sudo docker rm -f 9b9982d39009
Failed to remove container (9b9982d39009): Error response from daemon: Unable to remove filesystem for 9b9982d390099c13741daef8f1bd0555cf69a5fa943d383317de0d65f7c2801c: remove /var/lib/docker/containers/9b9982d390099c13741daef8f1bd0555cf69a5fa943d383317de0d65f7c2801c/shm: device or resource busy
ubuntu@box2121:~$ echo $?
1

/cc @2opremio @iaguis @schu

Great job @alban


fixes

Hey I really enjoyed this explanation, but I got stuck several times and noticed your source code has fixes that the book doesn't contain. So I added them in this pr along with some other text fixes + a message that tells people wasm-pack might fail to install on windows currently with a link to avoid that problem.
Another problem I had was that I couldn't get the javascript to run in localhost, telling me it was a text file even though I added the module line in html. It works on github pages though.

You also changed rand::Rng and Unimplemented opcode: {:#04x} not sure what those are about.
Did you write the book and then make more changes? 🤡


Uncaughting Swiper

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/s/atakan-webflow-lds8lv?file=/script.js
Bug description
Uncaught error with CDN install. You can find the Reproduction link at line 226 via the link I provided
Expected Behavior
No response
Actual Behavior
No response
Swiper version
v10.3.1
Platform/Target and Browser Versions
Windows Chrome 117
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


full working support of windows system

The real support of windows system needs another modification. Sorry for not having seen that on the first pull request.

Please merge this pull request.

Hi @christophercliff
Are you willing to merge this request or not?
Is there a problem with my code? Should I improve it in a specific way?

If you do not plan to merge this pull request, I'd be pleased if you can tell me.
If you plan to merge this pull request, please do!

I finally used metalsmith-fingerprint-ignore as I can't get this pull request to get merged.


⚠ dev.minetest.net has degraded performance

In 6d6051f, dev.minetest.net (https://dev.minetest.net/Main_Page) experienced degraded performance:

HTTP code: 200
Response time: 2121 ms

Resolved: dev.minetest.net performance has improved in 15d1cd5 after 40 minutes.


Update font-namdhinggo-sil to 1.004

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as fcd1a55e57483dc627633b1a2623a79cb86782b8.


Use argparser on args

Needed to provide help at a bare minimum even if they are parsed effectively in other ways.

High priority.


Add omnivore extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I'm not sure if you're done yet, but still getting √ Saved 🫠

I'm not sure if you're done yet, but still getting √ Saved 🫠

What do you mean by wrong key? I wrote url safeguard by using new URL().
Are you passing random string or some incomplete URL?

@pernielsentikaer there is not way to have instant feedback after saving fake url, it have to be processed on the omnivore side first. But I've added API key as required field, so you shouldn't be able to save nor search articles before providing the api key.


DBZ-7260 Remove no longer valid note about Mongo tasks.max usage

DBZ-7260 Removed multi-task capability, so I'm removing notice about this function from docs.

Thanks! Merged via https://github.com/debezium/debezium/pull/5621


feat(@kampus-apps/pano): add remix-auth and remix-auth-form strategy

We introduce our own KampusAuthenticator to make sure authenticator.authenticate call is type safe, and autocompletes with the strategies we register when we are creating an instance.
Fixes #241

Merging this as i want to unblock people from writing strategies.