Unable to get KMS inventory and scanner output

Hi,
We are using Forseti release-2.15.0
It seems like KMS inventory and scanner output is not supported. It would be great to have KMS related results.
Thank you,
Abhishek
Note: Could be similar to #2550

Hi Abhishek, could you elaborate what do you mean by KMS related results?

Hi, this is regarding kms_rules.yaml as we were unable to get scanner output and inventory for crypto keys that were not rotated for the given rotation_period

Is it possible for you to share the rules file and let me know what you plan to enforce with that rule?

I have added content of yaml file below (I couldn't attach the file).
We are trying to get cryptographic keys within our organization that haven't been rotated in last one year.
# Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Rule Keys:
# name: The unique name describing the rule
# mode: Depending on whether you want to allow or block in a given situation,
# mode can be whitelist or blacklist
# resource: A mapping of resources that this rule applies to.
#  * type: The type of resource, can be organization, folder, or project.
#  * resource_ids: A list of one or more numeric ids to match, or '*' for all.
# key: The configuration of cryptokey that this rule applies to.
#  * name: The unique name describing the cryptographic key. '*' is also
# supported to capture all the keys in a organization/folder/project.
#  * state: Denotes the state of a key version. Optional, if not included
# state is not compared.
#  * protection_level: Indicates whether cryptographic operations are performed
# in software or in Hardware Security Module (HSM). Optional, if not provided
# protection_level is not
# compared.
#  * algorithm: Denotes the algorithm of that key. Optional, if not provided
# algorithm is not compared.
#  * purpose: Defines the cryptographic abilities of the key. Optional, if not
# provided purpose is not compared.
#  * rotation_range: Denotes the range of the nextRotationTime of multiple keys
# in a project. Optional, if not provided nextRotationTime of cryptographic keys
# is not compared.
#  * rotation_period: Denotes the time period in days to rotate a key. Optional, if
# not provided rotation_range is not compared.
#  * labels: Allows you to group your keys. Optional, if not provided labels are
# not compared.

rules:
  - name: '[CIS_1.8] - All cryptographic keys should be rotated within 365 days'
    mode: blacklist
    resource:
      - type: organization
        resource_ids:
          - '*'
    key:
      - rotation_period: 365

Hi, I double-checked. You should be receiving violations for cryptographic keys that are not rotated in last 365 days or beyond that based on the rule you configured. Please check if you have keys in your GCP environment that were created over a year ago and weren't rotated. If yes, go ahead and check the violations table to see if there are KMS violations.

I have even tried by setting rotation_period as 1 day and didn't see any violations. There are cryptographic keys not rotated for more than 1 day in my environment.

@red2k18 Is there an update on this issue?

@abhishekupadhyaya, yes, I double-checked and it is working for the same rule you posted. I set rotation_period = 1 day. I can hop on a call later today to see what is going on.

@red2k18 lets have a call today.

Is 3:30pm - 4pm PST today a good time to chat?

That works.

I have sent you an invite. Talk to you then.

@red2k18 thank you for the call yesterday. I made changes based on your feedback. However, we are still not seeing any KMS results. We are getting 2019-06-18 17:13:23,036 INFO google.cloud.forseti.notifier.notifier(run): Resource 'kms_violations' has no violations even though we have KMS resources with violations on our organization.

Yesterday you said you're not running Forseti directly. Could you elaborate on how you're running Forseti?

We run forseti on containers using AWS ECS. The database in MySQL (AWS RDS) and bucket is AWS S3.

@abhishekupadhyaya Please check if cai is enabled in forseti_conf_server.yaml and run the below query on the gcp_inventory table to ensure kms_keyring and kms_cryptokey data is in the inventory.
select * from gcp_inventory where resource_type like '%kms%';

MySQL [forseti]> select * from gcp_inventory where resource_type like '%kms%';
Empty set (0.09 sec)
snippet from conf file:
cai:
    # The FORSETI_CAI_BUCKET needs to be in Forseti project.
    enabled: true

Hi,
Is there some setting that we are missing. Feels like we have all the settings, but none of the KMS related resources are getting discovered in the inventory.
Really appreciate any help on this.
Thanks,
Ranga.

@pvangara I can look into this some more.  Is your rule still the same as above: 365 days?

We changed it to 1 day to see if we can some results, but it didn't give any results.

@pvangara Understood.  Because I have keys that are less than a day old, it will be Friday before I have something demonstrable.  I'll provide an update by the end of the day 8/16,

@pvangara @abhishekupadhyaya I was able to use your rule, modify it to BLACKLIST keys older than one day, and received output.  No doubt you have tried this, but please indulge me; could you  re-create your inventory and a new model and re-running your scan?

So, one thing that I can think of is permissions issue. If we have permissions issue while getting the KMS inventory, what error should we look for?

Thanks Ken for looking into this. Really appreciate it.

It may be permissions.  If you run
forseti inventory list

Then
forseti inventory get INVENTORY_ID

Does it show any messages like "PARTIAL_SUCCESS"?
Does Stackdriver show any errors during the inventory create or scanner run steps?

When you install Forseti, required permissions are already granted. No
special permission is needed to run KMS Scanner. Could you answer Ken's
questions from the previous comment? We need to know if you have an
inventory with status SUCCESS. If there is one, please below query on
gcp_inventory table to check if Crypto key is in the inventory.
select * from gcp_inventory where resource_type like '%crypto%';
Let me know how it goes!
Thanks,
Rehana
On Tue, Aug 27, 2019 at 11:57 AM Abhishek Upadhyaya <
<EMAIL_ADDRESS>wrote:

What permission is required to get KMS inventory?
Currently, these are the permissions given to forseti service user:
[image: Screen Shot 2019-08-27 at 11 55 40 AM]
https://user-images.githubusercontent.com/8761854/63787325-9ffe5780-c8c1-11e9-9adb-0ba2f8deec86.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forseti-security/forseti-security/issues/2849?email_source=notifications&email_token=AJ4QVAIYCRV3UB6QQ45CKBTQGVFHNA5CNFSM4HPQQLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IHPHA#issuecomment-525367196,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ4QVAN7DS6MEW76RMIRYXDQGVFHNANCNFSM4HPQQLUQ
.

Thanks for sharing the results! The reason you're not seeing any violations
is because crypto keys are not in the inventory. Could you double check you
have crypto keys created in the same organization?
On Tue, Aug 27, 2019 at 3:21 PM Abhishek Upadhyaya<EMAIL_ADDRESS>wrote:

We see PARTIAL_SUCCESS as the state.
Here is the output of the query on gcp_inventory table:
MySQL [forseti]> select * from gcp_inventory where resource_type like
'%crypto%';
Empty set (0.10 sec)
MySQL [forseti]> select count() from gcp_inventory; +----------+ | count()
|
+----------+
| 60066 |
+----------+
1 row in set (0.02 sec)
MySQL [forseti]>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forseti-security/forseti-security/issues/2849?email_source=notifications&email_token=AJ4QVAI77GL66QKZQLDJ77LQGV5CVA5CNFSM4HPQQLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I2XPI#issuecomment-525446077,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ4QVAMSH4JCRDDQYZUY22LQGV5CVANCNFSM4HPQQLUQ
.

So, as noted by Abhishek above permissions is not an issue. We can use the gcloud CLI with the same credentials to list the keyrings and keys inside it.

Thanks for the information!
Is it possible for you to check the configuration in
forseti_conf_server.yaml to see if CAI is enabled?
[image: image.png]
On Wed, Aug 28, 2019 at 11:11 PM pvangara<EMAIL_ADDRESS>wrote:

So, as noted by Abhishek above permissions is not an issue. We can use the
gcloud CLI with the same credentials to list the keyrings and keys inside
it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forseti-security/forseti-security/issues/2849?email_source=notifications&email_token=AJ4QVAKS4E7GI7IHLNXJH6TQG445ZA5CNFSM4HPQQLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5NCVCQ#issuecomment-526002826,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ4QVAPJRTMTDIPUAS3IEGTQG445ZANCNFSM4HPQQLUQ
.

CAI is enabled in forseti_conf_server.yaml

I can meet with you tomorrow to debug. Please let me know what time works for you. Also, let me know the timezone you are in. Thanks!

Anytime before 4:30pm EST works for me.

We didn't see any data for KMS in gcp_inventory even after enabling CloudAssets API for our test project.

You will need to enable CloudAssets API on the project Forseti is installed.
On Fri, Aug 30, 2019 at 2:32 PM Abhishek Upadhyaya<EMAIL_ADDRESS>wrote:

We didn't see any data for KMS in gcp_inventory even after enabling
CloudAssets API for our test project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forseti-security/forseti-security/issues/2849?email_source=notifications&email_token=AJ4QVANND2MDFL6YYQKCUFTQHFRTBA5CNFSM4HPQQLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SN4MA#issuecomment-526704176,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ4QVAOLPPUDFWAGQSMUYUDQHFRTBANCNFSM4HPQQLUQ
.

@abhishekupadhyaya @pvangara Can you please check the CAI output file?  It should be the GCS bucket in your Forseti project.  You can check the forseti_conf_server.yaml to see which bucket it is.
Once you find the bucket with the CAI output files, open one of the output files and check if your crypto key resources are there.  The data in this file will be imported in Forseti's cloudsql database.
Please let us know.  Thanks.

Hello @abhishekupadhyaya and @pvangara, can you please check the CAI output as mentioned above? If you have a lot of dump files in the CAI export bucket, then it might be easier to lookup the latest resource dump file from the command line (SUFFIX is the unique id generated for the Forseti installation; you will see this on the VM and DB).
gsutil ls -l gs://forseti-cai-export-{SUFFIX}

Then you can copy the last dump file listed locally and open it to see if there are any KMS resources:
gsutil cp gs://forseti-cai-export-{SUFFIX}/{FILE_NAME} ./

To search the dump, you can searching for "asset_type":"cloudkms.googleapis.com.
Please let me know if that helps, I apologize we have not resolved this issue yet.

Hi @abhishekupadhyaya, I'm going to close this issue since we have not heard back. Please re-open if you have any questions/issues. Thanks!

@gkowalski-google sorry, I didn't respond earlier. Could you please re-open this case?

We are getting organizations-134289361963-resource-1569065995.dump file on the CAI export bucket.
We can see "asset_type":"cloudkms.googleapis.com/ resources.

Hi @abhishekupadhyaya, can you please verify a couple of things:
#1: verify the version of Forseti that you are using
logon to the server vm, and run this command

sudo cat /home/ubuntu/forseti-security/google/cloud/forseti/__init__.py

#2: Are you by any chance filtering out specific resources in the forseti_conf_server.yaml file?
Like this:
https://github.com/forseti-security/forseti-security/blob/dev/configs/server/forseti_conf_server.yaml.in#L122-L131
If possible, I would like to schedule a hangout with you.  My hours are 8am PST to 4pm PST.  What time works for you?

@blueandgold thanks for getting back. I will verify those.

@abhishekupadhyaya Any update?

It still doesn’t work!
Sent from my iPhone
On Nov 1, 2019, at 6:05 PM, Gregg Kowalski<EMAIL_ADDRESS>wrote:

@abhishekupadhyayahttps://github.com/abhishekupadhyaya Any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/forseti-security/forseti-security/issues/2849?email_source=notifications&email_token=AFL2WI5MZAT5BXTV6CKFQNTQRSRZ3A5CNFSM4HPQQLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4JBQY#issuecomment-548966595, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFL2WI64DHR4AI74S54XW3LQRSRZ3ANCNFSM4HPQQLUQ.

@abhishekupadhyaya When you get a chance could you verify the below for me?

The version you are on.
Please log on to the server VM and run sudo cat /home/ubuntu/forseti-security/google/cloud/forseti/__init__.py to know what version you are on.

Please run the query below to see if the key rings in your org are retrieved.
select * from gcp_inventory where resource_type like '%crypto%';

Lastly, could you check if you are filtering specific resources in the forseti_conf_server.yaml file as shown here ?

I'm closing this issue as we haven't heard back in a while. Please feel free to reopen this issue with more information.


Latest Add2App changes fail to load flutter test iOS app with plugins

Steps to Reproduce

Create a Flutter Module
Add a dependency that contains a native iOS plugin ex shared_preferences: 0.5.0
Run

Logs
[DEVICE LOG] 2019-08-07 08:39:27.141956+0200  localhost Runner[2036]: (Flutter) [VERBOSE-2:engine.cc(120)] Engine run configuration was invalid.
[VERBOSE-2:engine.cc(120)] Engine run configuration was invalid.
[DEVICE LOG] 2019-08-07 08:39:27.142038+0200  localhost Runner[2036]: (Flutter) [VERBOSE-2:shell.cc(407)] Could not launch engine with configuration.
[VERBOSE-2:shell.cc(407)] Could not launch engine with configuration.

No issues found! (ran in 1.8s)

[✓] Flutter (Channel master, v1.8.4-pre.127, on Mac OS X 10.14.5 18F203, locale en-MT)
    • Flutter version 1.8.4-pre.127 at /Users/dev/Development/flutter
    • Framework revision c08a3c7a0a (63 minutes ago), 2019-08-06 22:38:09 -0700
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.5.0 (build 2.5.0-dev.1.0 574c4a51c6)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.3

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 38.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.36.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.3.0

[✓] Connected device (1 available)
    • iPhone Xʀ • 0121CCE3-D8B9-4BC2-8AFA-02D5DA296B21 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-4 (simulator)

Does step 3 Run mean flutter run from the module directory?  Or are you running from one of the Xcode projects.
I made a new module inside an existing app, added shared_preferences: 0.5.0 and then flutter packages get then flutter run from the module directory and I don't see that error.

Yes, from the module directory.
This is happening on a new standalone module when running the test app inside .ios folder.

And you ran flutter packages get after adding the plugin?

Same issue.
Just tested with a new module to remove any variables.
This is what I did:
flutter create -t module my_flutter
cd my_flutter
flutter run

👍
Then proceeded to add shared_preferences: 0.5.0 to pubspec.yaml
flutter packages get
flutter run

💥💥
[VERBOSE-2:shell.cc(178)] Dart Error: Can't load Kernel binary: Invalid kernel binary format version.
[VERBOSE-2:engine.cc(176)] Could not prepare to run the isolate.
[VERBOSE-2:engine.cc(123)] Engine not prepare and launch isolate.
[VERBOSE-2:FlutterEngine.mm(294)] Could not launch engine with configuration.
vm-service: Error: Unhandled exception:
Unrecognized response: null
#0      new Response.from (dart:_vmservice/message_router.dart:70:7)
#1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
#2      Message.sendToVM.<anonymous closure> (dart:_vmservice/message.dart:216:7)
#3      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

I wasn't able to reproduce your exact error, but I do see a pretty large problem where the local engine isn't being embedded.
Can you try adding install_flutter_engine_pod to your module's .ios/Podfile (not the existing app) target 'Runner'?
target 'Runner' do
  install_flutter_engine_pod
  install_flutter_plugin_pods flutter_application_path
end

That did it :)
Thanks for your help!

@BernardGatt And thank you for your detailed issue! Fix incoming...


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LethuShabzin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Namespace Openstack provider

@blomquisg I think the merge of #3616 is cause issues in a number of PRs including this one.


Ingress route rule compatibility

Tracking some issues with mismatch between ingress and route rule:

ingress consists of many routes; do we map ingress to a list of rules or make route rule a list?
ingress points to a port name on the backend service; do we put port names into the core model?
defaulting is different for ingress proxy; it always replies with 404 and doesn't use sidecar default route rules.

Regarding 1st item: Ingresses in kubernetes do not define any relation (i.e. precedence) between multiple routes/virtual hosts specified within the same ingress resources. Therefore, we don't "lose" anything if mapping a single ingress into an unordered set of route rules. This is the approach I took so far in the ingress controller work.

And I don't think we need to worry about the third one. Even with a
sidecar, we would be responding with a 404 when no routes match. So the
semantics are same between ingress and sidecar. Unless you are thinking of
default routes to an existing service, e.g. by default go to v1. Since
ingress only allows for a single backend per route, that's a bigger
problem.
@zcahana, does the current controller have the ability to parse annotations
?
On Thu, Feb 16, 2017 at 8:15 AM Zvi Cahana<EMAIL_ADDRESS>wrote:

Regarding 1st item: Ingresses in kubernetes do not define any relation
(i.e. precedence) between multiple routes/virtual hosts specified within
the same ingress resources. Therefore, we don't "lose" anything if mapping
a single ingress into an unordered set of route rules. This is the approach
I took so far in the ingress controller work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/manager/issues/151#issuecomment-280327288, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd_p7YOPD4lsEt05wccJ3BIGbESLuks5rdEv-gaJpZM4MCK1C
.

--
~shriram

Regarding 2nd item: adding port (numbers and/or names) into the model (e.g., under WeightedDestination seems to be the only viable way to capture user intent expressed in ingress resources. Aside from ingress rules, this can be used for rerouting traffic transparently between services (i.e., client addresses service-a:80, which is rerouted to service-b:8080 by the proxy).

Regarding 3rd item: ingresses allows to specify a default backend for requests that doesn't match any route. An ingress controller needs to honor that specification. If not specified, we can do anything we dim fit (reply with 404, use sidecar default route rules [what are these anyway], ...). My thinking is that 404 is the proper response for ingress traffic which do not meet any explicit user-provided routes.

I think we need to reconsider if route rule is sufficient for ingress controller. It is not clear how to associate TLS certs, which are bound to specific hostnames, with a route rule or a destination policy. The hostname in ingress spec does not match the destination fields in route rules and policies. Moreover, the destination field in the ingress backend (service name) could benefit from applying route rules to it, to apply client side traffic shifting at the ingress proxy instead of standing up a separate proxy.
Maybe we should make ingress an explicit model element, like the route rule?
Do we lose any features that we get for free if we treat ingress rule like other route rules?
@zcahana @rshriram WDYT?

Why do we need to associate tls certs with routes or policies?
On Mon, Mar 20, 2017 at 5:38 PM Kuat<EMAIL_ADDRESS>wrote:

I think we need to reconsider if route rule is sufficient for ingress
controller. It is not clear how to associate TLS certs, which are bound to
specific hostnames, with a route rule or a destination policy. The hostname
in ingress spec does not match the destination fields in route rules and
policies. Moreover, the destination field in the ingress backend (service
name) could benefit from applying route rules to it, to apply client side
traffic shifting at the ingress proxy instead of standing up a separate
proxy.
Maybe we should make ingress an explicit model element, like the route
rule?
Do we lose any features that we get for free if we treat ingress rule like
other route rules?
@zcahana https://github.com/zcahana @rshriram
https://github.com/rshriram WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/manager/issues/151#issuecomment-287941751, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qdw1W47FNq0OWdNMD0B3Rg45JcMPrks5rnxwXgaJpZM4MCK1C
.

--
~shriram

@rshriram: The Kubernetes ingress spec allows different TLS certs to be used based on host: https://github.com/kubernetes/kubernetes/blob/9497139cb62015905ba5b3d11836f2b0c117ff80/pkg/apis/extensions/types.go#L604
Currently, we map Kubernetes Ingress rules to Istio rules and we need some way to convey that information.

The hostname in ingress spec does not match the destination fields in route rules and policies.

Don't think it's a problem. We use the route rule's headers matching map to match on the host from ingress spec.

The destination field in the ingress backend (service name) could benefit from applying route rules to it

Definitely (#217). Does separating ingress rules and route rules will get us closer to that? I was thinking this could be somehow achieved by the ingressWatcher processing both kind of rule kinds.
One incompatibility that we do have today is that we need to pass the target service port from the ingress spec to the ingress watcher. Today we do that uncleanly via the destination tags.
As for TLS, won't we need some way to specify certs location in the model, regardless of ingress?
Maybe we need to extend the model with some CertificateStore.

For beta, we should define a unified ingress rule definition that covers k8s/extended ingress controllers/Istio use cases. It's clear now that we need a unified model to combine various sources of ingress definitions (k8s, deployment annotations, internal istio) that specifically covers ede traffic concerns (TLS, url/host rewriting) and that plays well with in-cluster routing.
@rshriram @zcahana

The ingress is going nowhere and its a PITA. We should get rid of ingress and create our own front proxy using LB ports. Besides, @kyessenov has managed to combine ingress spec with route rules for most part. Close?


Add Date Picker component

I will add a calendar but it will be just a visual representation.
If you want a fully working date picker input field that you can choose day, month, year and you want the chosen values to be shown in the input field, that's not possible on a CSS-only library.
I suggest using browser's native date input:
<input type="date" class="input">


Always calling override func eventsForDate(_ date: Date) -> [EventDescriptor]

New Issue Checklist

[ ] Use the latest version of CalendarKit
[ ] I've read the Contribution Guidelines
[ ] I've searched for existing GitHub issues

Issue Description
Code I'm using with CalendarKit

[INSERT CODE HERE]

Result I am trying to achieve

[INSERT API OR UI MOCKUPS HERE]

That's correct.

You shouldn't. That's expected behavior. You override that method and populate your own events. The default implementation just returns an empty array.

Thanks mate. I fixed though

Hi there! I'm facing problem that events not generated after the successful call on API from server.
How to sync event call and API data model?


Add support for DNS SRV lookups

Fixes https://github.com/gliderlabs/logspout/issues/270

@michaelshobbs it took me far longer to complete this than I originally intended, but at last, it is ready to go. :-)

No worries. Thanks for the contribution

@michaelshobbs what do you need before this can be merged?

@michaelshobbs can this get merged please?
@mhamann are you still using service discovery in logspout, what are you using instead?

this PR has merge conflicts. happy to merge once the feedback and conflicts are resolved.

@ChrisLahaye I've since moved my environment to Kubernetes. Between k8s services and kube-dns, I no longer need SRV lookups.
I believe I'd originally resolved conflicts and addressed review comments, but I guess it must've fallen through the cracks. Not sure I'll have time to fix this up again, but would be happy for someone else to handle it. Seems like it would still be a good contribution.


KEYVALUE-5 : update to storage 2.0.0

Due to https://github.com/UW-Madison-DoIT/KeyValueStore/pull/11 this needs to change.

HTTP Verbs FTW.

:+1:


Header drop down is cropped.

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
Header should display the whole drop down box.
Actual behavior
The header drop down is cropped.
Reproduction of behavior
Code just copied from the documentation. Please see screenshot.
Environment details

Angular version: 4.0.X

Clarity version: 0.9.0

OS and version: Windows 10 Pro

Browser: [all | Chrome XX

]

@whizkidwwe1217: It looks like the screen is clipping the dropdown. We recommend that you use the bottom-right direction. We have listed the same example on our documentation:

Which example on the documentation did you use? If there is any demo on the website which is not following this example, we will have to fix it. Please let me know.

Hi,
It's now fixed. I was using an outdated code so the dropdown was clipped.
Thanks!


GCC7.5.0 build failed

see https://github.com/abseil/abseil-cpp/issues/1635
and you should change the git tag or commit for absl repo

Do you mind giving a bit more context and explaining what is going on?

Also, MAVSDK doesn't try to support GCC less than 8.


404 while npm install of "textlint-rule-spacing"

I got the following error while installing the textlint rule "textlint-rule-spacing", which was mentioned in Wiki.
404 Not Found - GET https://registry.npmjs.org/textlint-rule-spacing - Not found

Produce
To be certain, I used "node:alpine" Docker container.
$ docker run --rm -it --entrypoint /bin/sh node:alpine
/ # cd
~ # npm install --global textlint
/usr/local/bin/textlint -> /usr/local/lib/node_modules/textlint/bin/textlint.js
+<EMAIL_ADDRESS>added 200 packages from 104 contributors in 16.054s
~ # npm install --global textlint-rule-spacing
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/textlint-rule-spacing - Not found
npm ERR! 404
npm ERR! 404  'textlint-rule-spacing@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR!
Possible alternate package

textlint-rule-preset-ja-spacing @  npmjs.com by @azu
Other search results of "textlint-rule-spacing" @ npmjs.com

Env info
~ # cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.11.5
PRETTY_NAME="Alpine Linux v3.11"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"

~ # node --version
v13.13.0

~ # npm --version
6.14.4

~ # textlint --version
v11.6.3

textlint-rule-spacing is repository name.
textlint-rule-preset-ja-spacing is rule preset name.
To less confuse, We'll change repository name to textlint-rule-preset-ja-spacing.

@azu
Thank you for the quick response! I under stood.
So, I suppose the wiki in textlint needs to be changed as well to avoid 404.

And it was already fixed. Quick job! :+1:


Can't save image data

I'm getting the following error when specifying an output directory.
    ...
    File "drive.py", line 66, in telemetry
        image.save('{}.jpg'.format(image_filename))
AttributeError: 'numpy.ndarray' object has no attribute 'save'

Hi @n1try
Thanks for reporting this.  I think I was saving image frames at some points for debugging purpose but then later stop using it.
Originally, I had image for the PIL image object and image_array for numpy array so calling image.save was calling the PIL save method but later I refactored the code and made image to be numpy array and caused this problem.
I'm guessing you could move the following codes:
        # save frame
        if args.image_folder != '':
            timestamp = datetime.utcnow().strftime('%Y_%m_%d_%H_%M_%S_%f')[:-3]
            image_filename = os.path.join(args.image_folder, timestamp)
            image.save('{}.jpg'.format(image_filename))

to just after the below code:
        # The current image from the center camera of the car
        image = Image.open(BytesIO(base64.b64decode(data["image"])))

So that it will call the PIL image save method like below.
        # The current image from the center camera of the car
        image = Image.open(BytesIO(base64.b64decode(data["image"])))
        # save frame
        if args.image_folder != '':
            timestamp = datetime.utcnow().strftime('%Y_%m_%d_%H_%M_%S_%f')[:-3]
            image_filename = os.path.join(args.image_folder, timestamp)
            image.save('{}.jpg'.format(image_filename))

If you need this functionality, please try this change.  If it works, please send me a pull request for merging.  If no one is interested in this function, I should probably remove it to avoid future confusion.

thanks @n1try !


payload_user_data and RX buffer mismatch

I am running a TX-RX test.
The transmitter runs a 32 bit payload counter. The value of the counter is placed in the first 4 bytes of the payload.
It is also placed in payload_user_data  and both fields of the PTP.
The RX log shows a mismatch of one payload between these values.
This mismatch does not appear in the TX log.
Please let me know what I am doing wrong.
RXlog.txt
TXlog.txt

I reviewed the log files that you have provided. I am not able to understand exactly what is going wrong. I see this in the RXlog.txt file: PayloadCtr 1 VideoCtr   0 GoodCtr    0 BadCtr     1
If the PTP fields and payload_user_data fields match on TX and RX, then I assume that that is a bug in the application that is causing the payload data to be corrupt. Are you reusing the buffer for each payload? If so, it is possible that the application is modifying the contents of the buffer before the SDK has completed and sent its contents for the previous payload.
Please provide additional details if this still is an issue for you.

Thank you Mike for helping me find my mistake.
The wrong code looks like this:
1) Loop forever
2) Increment PayloadNum
3) Fill buffer with PayloadNum
4) Sleep remaining time up to next TX
5) Send buffer
6) End loop
The buffer is being sent in line 5, and immediately after that the next payload is inserted into it in line 3.
To fix the mistake I have moved line 4 before line 2. I also make sure the TX callback was called without error. (See case  #60)


Wrong defer watcher try / catch

https://github.com/amphp/amp/blob/8f903b62db5d3696bdff2c9beab0a9081f372267/lib/Loop/Driver.php#L112 should have the try / catch around the $callback invocation, not around the foreach.

That try / catch block catches exceptions thrown from any watcher invocation, not just defers, as it is also around the call to dispatch. Any watcher callback throwing an exception effectively immediately ends the tick. In this way defers are handled the same as any other watcher.

It makes handling easier, but it won't execute any I/O watchers if there's always one defer throwing.

I can't imagine that happening in an actual app.

Same here, that'd be an extreme edge case, but it might happen, as we use Loop::defer to rethrow errors from promises.

@bwoebi After thinking about this, I realized an app might have a IO, timer, or signal that continually throws that might block another watcher from ever executing that would stop the cycle. I'll update everywhere watcher callbacks are invoked to be wrapped by their own try / catch blocks and continue the tick after calling the loop error handler.


Depereciation warning in pytorch 1.5 (maybe and above?)

Hi! I encountered following warning while I using AdamP for my project
..\torch\csrc\utils\python_arg_parser.cpp:756: UserWarning: This overload of add_ is deprecated:
	add_(Number alpha, Tensor other)
Consider using one of the following signatures instead:
	add_(Tensor other, *, Number alpha)

Might this be relevant to the AdmaP update?

Hi
We implement AdamP based on Torch 1.3
PyTorch 1.5 changes default args of in-place operations such as add_() and addcmul_().
So, following lines of AdamP makes the warnings
https://github.com/clovaai/AdamP/blob/64a63106a2ac62bcbe90627f2a83ec1b488f3416/adamp/adamp.py#L80-L81
https://github.com/clovaai/AdamP/blob/64a63106a2ac62bcbe90627f2a83ec1b488f3416/adamp/adamp.py#L101
If you change it as
 exp_avg.mul_(beta1).add_(grad, alpha=1 - beta1)
 exp_avg_sq.mul_(beta2).addcmul_(grad, grad, value=1 - beta2)

 p.data.add_(perturb, alpha=-step_size)

then the warnings will disappear
But, I'm not sure whether this changes is compatible with old versions. So, I will not apply the changes to master and pip.
You can also find difference in official AdamW.py
Torch 1.4
https://github.com/pytorch/pytorch/blob/74044638f755cd8667bedc73da4dbda4aa64c948/torch/optim/adamw.py#L100-L101
Torch 1.5
https://github.com/pytorch/pytorch/blob/4ff3872a2099993bf7e8c588f7182f3df777205b/torch/optim/adamw.py#L104-L105

thanks for the comments! I'll use the code snippet for torch 1.5

Inplace operation was changed in #7.
Thanks for your contribution.

@Junyoungpark
We just release adamp==0.3.0(https://github.com/clovaai/AdamP/releases/tag/v0.3.0).
Please retry pip install adamp :)


ERIP: Payment Section

User Story
As an employee, I want to be able to access the form and work through it so I can submit the form successfully.
Tasks:
Build the ERIP Payment section of the form.
Link to Miro - https://miro.com/app/board/uXjVKMReQvg=/?moveToWidget=3458764587860184996&cot=14
Acceptance Criteria

[ ] Make the required fields compulsory
[ ] If selected 'Yes', for any of the questions, display the required question underneath - logic required
[ ] Match the content and formatting from this section
[ ] Please show this in the attached PDF after submission

The form is built in DEV and is ready for test.
The form has not been built in TEST yet, since it is down due to maintenance.
I'll move this ticket to the QA column once both TEST and DEV are ready for test.

Ready to test on TEST & DEV

RRSP should only come if Do you want some or all of your ERIP payment to be transferred directly to your RRSP? is Yes. Added this issue to #1781.
Otherwise Payment section looks good


BinaryHeap NullPointerException

Issue details
In prev release 7 march (gdx-1.9.11-SNAPSHOT)  my game worked fine
Reproduction steps/code
BinaryHeap<Node> bh = new BinaryHeap<Node>();
bh.add(new Node(5f));
Node node = new Node(10f);
bh.add(node);
bh.remove(node);
bh.remove(node);

Version of LibGDX and/or relevant dependencies
gdx-1.9.11-SNAPSHOT
gdx-ai-1.8.2
Stacktrace
java.lang.NullPointerException:
  at com.badlogic.gdx.utils.BinaryHeap.down (BinaryHeap.java:156)
  at com.badlogic.gdx.utils.BinaryHeap.remove (BinaryHeap.java:102)
  at com.badlogic.gdx.ai.pfa.indexed.IndexedAStarPathFinder.visitChildren (IndexedAStarPathFinder.java:219)
  at com.badlogic.gdx.ai.pfa.indexed.IndexedAStarPathFinder.search (IndexedAStarPathFinder.java:117)
  at com.badlogic.gdx.ai.pfa.indexed.IndexedAStarPathFinder.searchNodePath (IndexedAStarPathFinder.java:94)
  at com.tpwar.game.maps.pathfinding.TiledPathFinder.find (TiledPathFinder.java:29)
  at com.tpwar.game.screens.MapScreen$InputAdapterExtension.touchUp (MapScreen.java:741)
  at com.badlogic.gdx.InputMultiplexer.touchUp (InputMultiplexer.java:124)
  at com.badlogic.gdx.backends.android.AndroidInput.processEvents (AndroidInput.java:406)
  at com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame (AndroidGraphics.java:476)
  at android.opengl.GLSurfaceView$GLThread.guardedRun (GLSurfaceView.java:1581)
  at android.opengl.GLSurfaceView$GLThread.run (GLSurfaceView.java:1280)

Please select the affected platforms

[X] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[ ] HTML/GWT
[X] Windows
[ ] Linux
[ ] MacOS

It would be helpful if you could supply a sample code that can be used to reproduce the issue.

Are you using the current snapshot now? BinaryHeap was edited recently to fix an ordering bug.

https://github.com/taluks/libgdx-test
this test with 1.9.10 working

I'm going to take a look; I'm curious what the change after March 7 could have done to trigger an NPE...

This is pretty hard to follow. I think part of the issue has to do with the start and end nodes being non-walkable, maybe. It's hard to tell what coordinate offsets are in use because there's cases where identical names are used in different classes with no shared meaning, like how there's two moveMap arrays with different sizes. I printed this out of the JSON/TPMAP file; the origin is in the upper left, +1 x moves to the right, and +1 y moves down.
00000000000000000000
00000000000001000000
00000000000000100000
00000100000000000000
00000000000000001000
00001100000000110100
00001100011100110000
00010000111000000000
00000000011000000000
00000000000000000000
00001100000100110000
00011100000000110000
00000001000000000100
00000010000000000000
00000000000000000000

I'm pretty sure the getNode(int, int) method is indexed starting at 1, because the nodes it gets show different positions than the x and y given to getNode(). If that's correct, then the start and end nodes are both 1, non-walkable. But I'm really not confident enough to say what the start and end actually are, here.
Still, a non-walkable end tile doesn't explain a Node being null inside BinaryHeap, especially if it worked before. I think I'll tinker with this a bit more, and see which positions cause an NPE.

Yes! Not only can I confirm the bug, I can confirm a fix for the bug, and it only needs moving one line in BinaryHeap! The solution is to change, in BinaryHeap.remove(T):
			nodes[node.index] = moved;
			nodes[size] = null;

to
			nodes[size] = null;
			nodes[node.index] = moved;

I believe the issue happened when size and node.index were equal, so nodes[node.index] should have been moved but instead was null.

Ah, that was tricky! Great find @tommyettinger!


Make the optional NodePool.AutoScaling field a pointer

This fixes patch operations against the type where .autoScaling=null.
Depends on https://github.com/openshift/hypershift/pull/28

Needs https://github.com/openshift/hypershift/pull/28 first.
/hold

/hold cancel

/lgtm


a little refactor

reduce SLOC by using CallAsync method
BucketForceCreate optimization: don't decode tnt response

What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):

[ x] Changelog (see documentation for changelog format)

Related issues:

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.02%. Comparing base (17d1ba2) to head (2d912a7).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   68.72%   68.02%   -0.70%
==========================================
  Files          13       13
  Lines        1330     1301      -29
==========================================
- Hits          914      885      -29
  Misses        363      363
  Partials       53       53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


What are the key factors that boost performance?

Dear Dr. Nah:
Thank you for answering my last question! I have one final question. PSNR boosts from 29.23dB (29.08 dB for 3 scales, according to the CVPR2017 paper) to 30.40dB for the single precision model.   After studying this repo and your original repo (DeepDeblur_release) for several days, I become curious about the key factors that boost performance.  I have the following conjectures:
(1) RGB range [0, 1] --> [0, 255]. But why does this work?
(2) Removal of the GAN loss. According to NTIRE 2020 UniA's  paper, GAN loss may not help training. Besides, removal of the discriminator may help training.
(3) Learning rate schedule. Both repos train 1000 epochs using the Adam optimizer. However, the original repo sets the learning rate to its 1/10 on the 150th epoch (code/main.lua), while this code uses 5 warmup epochs and halves the learning rate (default gamma=0.5) on the milestones (the 500th, 750th, 900th epoch). The initial learning rate is 1e-4 (src/option.py, line 92) in this repo and 5e-5 in the original repo (code/opts.lua, line 53).
(4) Augmentation. The augmentation methods in this repo are slightly different from the original ones. First, this repo changes saturation with possibility 1 while the original repo changes saturation with 1/10 possibility (code/donkey.lua, line 59). Second, this repo only rotates 90 degrees while the original repo may rotate 90, 180 or 270 degrees counterclockwise.  Third, this repo uses "flip_v" and "flip_h" which flip vertically and horizontally respectively, while the original repo only uses "flip_h". Both repos use AWGN with sigma=2.
(5) Change from Torch to PyTorch. This seems weird. Maybe the initialization method has changed (not sure)?
CNN is a "black box". Therefore, I believe nobody can answer this question except you.
I am a layman to deblurring. Would you please solve my puzzle? Thanks!

Here are my answers.
(1) The initialized weights could be in a different position with respect to the input images. Also, the average gradient scale might differ. No clear clues but we found the effect when experimenting EDSR.(torch, pytorch)
(2) Removing adversarial loss can bring higher PSNR but I can't say it brings improvements. Adversarial or perceptual loss plays a different role and the evaluation criteria should not be PSNR only.
(3) Usually longer training helps. I found the previous implementation did not meet the convergence point. However, this repository does not guarantee convergence. I would say there still remain rooms to be improved by even longer training. If you read other deblurring papers, they typically train for 2000 ~ 4000 epochs.
(4) Augmentation details are mostly the same except the saturation augmentation and the sharpness preservation probability. The rotation/flipping boolean variables are different but they are designed to perform the same transformations jointly.
I don't think this would cause much difference.
(5) I did not test the exactly the same implementation. Torch used Xavier initialization while PyTorch uses He initialization by default. Other differences may affect the optimization.
(6) Mixed precision training could bring differences in performance.
(7) Different batch sizes lead to different convergence schemes. Larger batches are slower at the very early part of the training but become faster afterward in my experiences.

Thanks for you detailed answers. I have no further questions and sorry for bothering you!

No problem at all.


clean up bpa maintainer roles

Add role to:

@DritonGoxhufi

Revoke role from:

@frank-bee
@Jsyro

[X] Removed @jaredweinfurtner, @usingtechnology, @ianco from the organizational-agent-committers team.
[X] Revoked maintainer role in the organizational-agent-committers team from @frank-bee and @Jsyro
[X] Invited @DritonGoxhufi to the organizational-agent-committers team
[ ] Will add maintainer role to @DritonGoxhufi once the invite has been accepted

In the future, please use the Hyperledger Labs Governance for making these sorts of changes. This will ensure that if I am not available that someone will be able to take care of it.

That was quick, thanks a lot! We were not aware of the governance repo - we will use that in the future.

Completed last item above since invite was accepted.


Open Graph information

[ ] Description
[ ] Image
[ ] Correct pubdate

collection
archive
list
digital
materiality
material
stones
computer
technology
art
design
theory


Rename file in single portable installs

[x] I have signed the Contributor License Agreement.
[x] This pull request is related to an issue.

Partially #3437

This should work for renaming whenever the portable is a loose binary, or when it is not inside of a directory in a zip file. With the way directory extraction works with Zip files, I wasn't able to add just a file entry to move the file since the Desired State entries are not guaranteed to process in order. I'd like some guidance on how that should be handled, perhaps that should be a separate PR?

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-cli/pull/3439&drop=dogfoodAlpha

/azp run

/azp run

@Trenly,
After discussing with the team, we want this change to be included in the next release as a hotfix for the single portable symlink bug. The portable install for the archive scenario is quite complicated and will need to be addressed in our 1.7 release. If you can resolve the merge conflicts and get the build passing, we'll go ahead and check this one in. Thanks for your help!

Sounds good.


Now that there's support for promises in migrations, add an option to the generator that will generate the migration with a promise? (--promise)

Can you show me an example of what that would look like? Thanks in advance.


[MERGE] Adding support for cert-manager certificates to manage webhook TLS

This PR combines changes from https://github.com/kubeflow/spark-operator/pull/1567 and  https://github.com/kubeflow/spark-operator/pull/2079, with the following content:

Merging the changes from dskatz:feature/certmanager
Resolving conflicts (keeping webhook-cleanup-job.yaml & webhook-init-job.yaml deleted)
Upgrading cert-manager.io apiVersion to v1
Adding additional suggestions from https://github.com/kubeflow/spark-operator/pull/2079
Cleaning merge mess and tidying trailers
Bumping operator app and chart versions

This should resolve issue https://github.com/kubeflow/spark-operator/issues/1178

@yuchaoran2011 / @ChenYi015 - I moved over the changes from https://github.com/kubeflow/spark-operator/pull/2079 here due to merge and trailers issues, let me know what else is required.

@yuchaoran2011  / @ChenYi015 - Anything that needs to be done on my side?

@YanivKunda Missed this one earlier. Looks like another set of conflicts has happened. could you fix them?


Add a Stateless Ethereum glossary

Addressing the suggestion in #44, this adds a glossary as a standalone markdown document.
It might be worth integrating with or adding a more robust "introduction" or "background" document that also tries to be a quick resource for newcomers catching up with Stateless Ethereum.
I used V's suggested terms as a starting point but will add more from my notes and as suggested by others here or in discord

Maybe this glossary will eventually be merged with the yellowpaper, appendix A.


Video call is being crashed on samsung tab A on android pie

When I am doing a video call to my application on Samsung tab A which is having android pie as an OS.
when do I click on accept the session started there and application get crashed?
Eventually, there is no log generated for that crash, if there is somebody who can help me out do help.

Update sdk .

Going to close this due to inactivity.
Please reopen if it still crashes on 2.17


Problem in group.all_devices state

Home Assistant release with the issue:
0.84.5
Last working Home Assistant release (if known):
I don't know
Operating environment (Hass.io/Docker/Windows/etc.):
Hassio on NUC
Component/platform:
group.all_devices
Description of problem:
If I restart HA, and all my devices are in a known Zone (in zone.yaml), group.all_devices shows like "unknown", insteed of "not_home".

My devices:

group.all_devices:

When any of this devices come back to home, then the problem fixed if devices leaves again.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

Is this still an issue you are experiencing? Can you pleas try upgrading to the latest version of Home Assistant (0.90) and report back if this is still a problem? Thanks!

I have this exact problem, running 0.91.2

The issue is no longer present for me with 0.93.2.


keepAlive  with Dynamic Components setup  hmr error

Vue version
3.2.37
Link to minimal reproduction
https://github.com/yuntian001/keepAliveError
Steps to reproduce

npm install
npm run dev
editor src\components\HelloWorld.vue const aa = ref('1234') to const aa = ref('hello')

What is expected?
no error
What is actually happening?
runtime-core.esm-bundler.js:38 [Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/core
  at <KeepAlive>
  at <RouterView>
  at <App>

runtime-core.esm-bundler.js:6070 Uncaught (in promise) TypeError: parentComponent.ctx.deactivate is not a function
    at unmount (runtime-core.esm-bundler.js:6070:33)
    at patch (runtime-core.esm-bundler.js:5054:13)
    at sharedContext.activate (runtime-core.esm-bundler.js:2435:13)
    at processComponent (runtime-core.esm-bundler.js:5480:37)
    at patch (runtime-core.esm-bundler.js:5085:21)
    at ReactiveEffect.componentUpdateFn [as fn] (runtime-core.esm-bundler.js:5695:17)
    at ReactiveEffect.run (reactivity.esm-bundler.js:187:25)
    at instance.update (runtime-core.esm-bundler.js:5729:56)
    at callWithErrorHandling (runtime-core.esm-bundler.js:155:36)
    at flushJobs (runtime-core.esm-bundler.js:388:17)

System Info
System:
    OS: Windows 10 10.0.17763
    CPU: (16) x64 Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz
    Memory: 5.56 GB / 15.86 GB
  Binaries:
    Node: 16.15.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.0 - ~\AppData\Roaming\npm\npm.CMD
  Browsers:
    Internet Explorer: 11.0.17763.771
  npmPackages:
    vue: ^3.2.37 => 3.2.41

Any additional comments?
I saw this error mentioned, but it was closed. Please focus on it.

https://github.com/vuejs/core/blob/0841b9b5243acdaf191099b25e9a145b30189dea/packages/runtime-core/src/components/KeepAlive.ts#L306-L315
In this case, the shapeFlag of the modified component is marked as COMPONENT_KEPT_ALIVE because of the presence of the cache, causing the component not to be mounted:
https://github.com/vuejs/core/blob/aa70188c41fab1a4139748dd7b7c71532d063f3a/packages/runtime-core/src/renderer.ts#L1154-L1172
I am trying to fix this issue.

Duplicate of #6809


Error after update

Updated Gitify this morning and now I get this error message popping up every other minute.

I imagine this is fixed by now :)


Bad typing for argument rotation of PDFPageView.update

PDF.js version: 3.5.141
The type of rotation property in argument of PDFPageView.update is marked as null | undefined but it should be number | undefined

Basically, https://github.com/mozilla/pdf.js/issues/16307#issuecomment-1511694758 applies here as well.


sbJson writer support for external contact identifiers

Verified sbJSON supports identifiers:
sbJSON: contacts[]>orcId
i.	Logic: where contactType = “individual” and “orcId” element exists
ii.	contacts block

identifier: orcId
namespace: “ORCID”
version: (not supported)
description: “Open Researcher and Contributor Id”
authority{}: (not supported)

sbJSON: contacts[]>organization
i.	Logic: where contactType = “organization” and “organization” block element exists = true
ii.	contacts block

identifier: directoryId
namespace: displayText
version: (not supported)
description: displayText
authority{}: (not supported)

Example
Contact Type: Person
mdJson
{
  ...
  "externalIdentifier": [{ "identifier": "example-orcid", "namespace": "ORCID" }]
  ...
}

sbJson
{
  ...
  ?
  ...
}

Example
Contact Type: Organization
mdJson
{
  ...
  "externalIdentifier": [{ "identifier": "example-orcid", "namespace": "ORCID" }]
  ...
}

sbJson
{
  ...
  "organization": { "displayText": "ORCID", "displayId": "example-orcid" }
  ...
}

The sbJSON organization example is incorrect. There is no ORCID associated with an organization. The code should trap for any contact with a contactType = "organization". The contactName should be mapped to displayText. The logic comments should reflect the inverse mapping of mdJSON to sbJSON from the perspective of a writer. Example: directoryId = identifier

From https://www.usgs.gov/sciencebase-instructions-and-documentation/item-core-model#contacts
contacts
Datatype: Array of contact objects
The contacts of an item. This is an collection of basic typed contact objects, which have the fields: type, name, highlighted. The type is the type of contact, e.g., Author, Contact, Data Owner, Participant, Principle Investigator, Project Chief, Associate Project Chief, Task Leader, this is a string. The name is the name of the contact, it is a string. Highlighted is whether or not the contact is highlighted, it is a boolean.

CONTACT OBJECT
Most fields in the contact object are self explanatory, but some are explained below. Check out the JSON object containing one person and one organization for full list of fields.

name (Datatype: String) The name of the contact.
contactType (Datatype: String) The type of contact, always "person" or "organization"
type (Datatype: String) An editable type to describe the person or organization.
email (Datatype: String) The email address of a person. Not included in organizations.
firstName¹ (Datatype: String)
middleName¹ (Datatype: String)
lastName¹ (Datatype: String)
jobTitle¹ (Datatype: String)
active (Datatype: Boolean) Whether the person or organization is active.
organization¹ (Datatype: Object with one field: displayText which describes the organization) Person types only.
primaryLocation (Datatype: primaryLocation object)
note² (Datatype: String)
aliases² (Datatype: Array of Strings)
logoUrl² (Datatype: URI)

¹ Only included on contactType "person"
² Only included on contactType "organization"

@dwalt I'm not sure I understand what you're saying about this mapping. I'm looking at this from the mdJson -> sbJson perspective. In terms of sbJson -> mdJson I'm not sure what to look for in sbJson, since I'm not sure what the "external identifier" looks like in sbJson.

Is there a mapping for both people and organizations, or does this only apply to one or the other?
Since an organization is not supposed to have a nested organization object, I'm not sure what you mean by mapping the contact name to displayText. In the case of a person it does not make sense to me to map the person's name to the displayText for the organization object.
I don't see anything about directoryId in the sbJson schema, so I'm not sure I understand where that goes.

@jwaspin What you are likely viewing is publicly accessible documentation of the core sbJSON model available here: https://www.usgs.gov/sciencebase-instructions-and-documentation/item-core-model#contacts.  There are extensions to the core available to USGS users, which is probably what I used.  I would suggest requesting assistance.

The decision for this was to not do anything for an organization, only for a "person" type of contact.


Update Release Guide DockerHub beammaintainers team to beam

We have merged beammaintainers team into beam on DockerHub

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Both website precommit passed though status not updated to GitHub. Merging for now


"The frontend of HACS have been disabled until you restart Home Assistant"

HACS was missing from my side panel for some reason. I've installed it again, now it is shown again, but than I get this message:
"The frontend of HACS have been disabled until you restart Home Assistant."
did several restarts of HA but still the same.
version | 0.99.3
Thanks!

look at your logs ;)

From the log:
Removing unknown panel hacs
Setup of hacs is taking over 10 seconds.
[Expecting value: line 1 column 1 (char 0)] Restore Failed (dont know if that's HACS related)
And the full log:
2019-10-05 23:43:40 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experience issues with Home Assistant.
2019-10-05 23:43:40 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for smartir which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experience issues with Home Assistant.
2019-10-05 23:43:42 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for midea which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experience issues with Home Assistant.
2019-10-05 23:43:48 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for shabbat which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experience issues with Home Assistant.
2019-10-05 23:43:48 WARNING (MainThread) [homeassistant.loader] You are using a custom integration for holiday which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you do experience issues with Home Assistant.
2019-10-05 23:43:51 WARNING (MainThread) [homeassistant.setup] Setup of hacs is taking over 10 seconds.
2019-10-05 23:43:54 CRITICAL (MainThread) [hacs.data] [Expecting value: line 1 column 1 (char 0)] Restore Failed!
2019-10-05 23:43:54 WARNING (MainThread) [homeassistant.components.frontend] Removing unknown panel hacs
2019-10-05 23:44:03 ERROR (stream_worker) [libav.tcp] Connection to tcp://<IP_ADDRESS>:554?timeout=0 failed: Host is unreachable
2019-10-05 23:45:00 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937907 is taking over 10 seconds
2019-10-05 23:45:00 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937902 is taking over 10 seconds
2019-10-05 23:46:01 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_15393162830949 is taking over 10 seconds
2019-10-05 23:46:01 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_10995116311012 is taking over 10 seconds
2019-10-05 23:47:02 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937907 is taking over 10 seconds
2019-10-05 23:47:02 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_10995116311012 is taking over 10 seconds
2019-10-05 23:48:03 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627940276 is taking over 10 seconds
2019-10-05 23:48:03 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937907 is taking over 10 seconds
2019-10-05 23:49:04 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_10995116311012 is taking over 10 seconds
2019-10-05 23:49:04 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_15393162830949 is taking over 10 seconds
2019-10-05 23:49:28 WARNING (MainThread) [homeassistant.components.device_tracker] Updating device list from legacy took longer than the scheduled scan interval 0:00:10
2019-10-05 23:50:04 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627940276 is taking over 10 seconds
2019-10-05 23:50:04 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_15393162830949 is taking over 10 seconds
2019-10-05 23:51:05 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_10995116311012 is taking over 10 seconds
2019-10-05 23:52:06 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937907 is taking over 10 seconds
2019-10-05 23:53:07 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_12094627937907 is taking over 10 seconds
2019-10-05 23:53:07 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.midea_15393162830949 is taking over 10 seconds

Same as https://github.com/custom-components/hacs/issues/476


Bug in conditional configuration for Gson

The GsonMapper is only installed if Gson.class is available and spring.http.converters.preferred-json-mapper=gson. So even if Gson is the only possibility the user still has to provide the flag, which seems dumb.

I agree, and it also looks like we really don't need spring.http.converters.preferred-json-mapper=gson. Right?
Also, i don't think it's a bug, rather enhancement

You would need the flag to disambiguate if Gson and ObjectMapper were both on the classpath.


Java: Fix transaction handling for cluster client.

Issue #, if available:
N/A
Description of changes:

The exec() command (with a transaction as input argument) for cluster clients must be routed to a single node. Multi-node routes are not supported.
Refactor routing handling:

introduced SingleNodeRoute and MultiNodeRoute
compile-time validation for exec
corresponding test updates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please ping when CI is passing / change to draft in the meanwhile

@barshaul


Old sm-cnn has hardcoded paths that match TrecQA

The TrecQA dataset comes in clean- and raw- versions, the sm_cnn main file loads one of these hardcoded prefixes (with a really badly named/described argument to switch between them), code ref, but other datasets (such as WikiQA) don't have these distinctions leading to an exception being thrown:
Traceback (most recent call last):
  File "main.py", line 152, in <module>
    trainer.load_input_data(args.dataset_folder, cache_file, train_set, dev_set, test_set)
  File "/castorini/castor/sm_cnn/train.py", line 51, in load_input_data
    utils.read_in_dataset(dataset_root_folder, set_folder)
  File "/castorini/castor/sm_cnn/utils.py", line 141, in read_in_dataset
    questions = read_in_data(dataset_folder, set_folder, "a.toks", False, stop_punct, dash_split)
  File "/castorini/castor/sm_cnn/utils.py", line 98, in read_in_data
    with open(os.path.join(datapath, set_name, file), encoding='utf-8') as inf:
FileNotFoundError: [Errno 2] No such file or directory: '../../data/WikiQA/raw-test/a.toks'

I'm torn between whether this is the dataset loaders fault, or whether it may just be simpler to change the dataset generation to match TrecQA -- that is, by default if a collection doesn't have the distinction generate everything under the raw- prefix.

If the dataset generator changes then other model files are almost certainly going to break if they were written with a non-TrecQA dataset in mind
Other models written for the TrecQA dataset will almost certainly have a similar problem
Adding a flag for a prefix is yet more flags

Thoughts and comments?

It would be good to have a data-loader class for each dataset. Basically
the train_set, dev_set, test_set "names" need to be set up correctly to
reflect the path to respective sub-folders. TrecQA has 2 kinds of data (raw
and clean) which was an added complication. Yes this does need better
design.
On Fri, Nov 10, 2017 at 10:31 AM Matt Crane<EMAIL_ADDRESS>wrote:

The TrecQA dataset comes in clean- and raw- versions, the sm_cnn main
file loads one of these hardcoded prefixes (with a really badly
named/described argument to switch between them), code ref
https://github.com/castorini/Castor/blob/61c8c0e622caa69e8579174dee429901128dc7e1/sm_cnn/main.py#L135-L137,
but other datasets (such as WikiQA) don't have these distinctions leading
to an exception being thrown:
Traceback (most recent call last):
File "main.py", line 152, in
trainer.load_input_data(args.dataset_folder, cache_file, train_set, dev_set, test_set)
File "/castorini/castor/sm_cnn/train.py", line 51, in load_input_data
utils.read_in_dataset(dataset_root_folder, set_folder)
File "/castorini/castor/sm_cnn/utils.py", line 141, in read_in_dataset
questions = read_in_data(dataset_folder, set_folder, "a.toks", False, stop_punct, dash_split)
File "/castorini/castor/sm_cnn/utils.py", line 98, in read_in_data
with open(os.path.join(datapath, set_name, file), encoding='utf-8') as inf:
FileNotFoundError: [Errno 2] No such file or directory: '../../data/WikiQA/raw-test/a.toks'
I'm torn between whether this is the dataset loaders fault, or whether it
may just be simpler to change the dataset generation to match TrecQA --
that is, by default if a collection doesn't have the distinction generate
everything under the raw- prefix.

If the dataset generator changes then other model files are almost
certainly going to break if they were written with a non-TrecQA dataset in
mind
Other models written for the TrecQA dataset will almost certainly
have a similar problem
Adding a flag for a prefix is yet more flags

Thoughts and comments?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/castorini/Castor/issues/83, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzueJls2aoUL9XNgnRVYdxcv_4ZO2-6ks5s1GxbgaJpZM4QZt2r
.


Move utils from src/utils into src/client/common/utils

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Unit tests & system/integration tests are added/updated
[ ] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fabiane sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Already done in #2749


Add packstream support for element_id fields

Waiting for:

https://github.com/neo4j-drivers/testkit/pull/408
https://github.com/neo4j/neo4j-python-driver/pull/672

Superseded by https://github.com/neo4j/neo4j-python-driver/pull/672


Update CardMedia.d.ts

I changed the extension from HTMLAttributes to AllHTMLAttributes to allow to stlye the div, which is rendered to be more customized, as seen in the demos.

[x] I have followed (at least) the PR section of the contributing guide.

I'm missing a bit of context. Which demos are you talking about? style should already be accepted. Could you add some code that was failing before and is passing with this change?

Yes of course:
The <Cardmedia> Component accepts also all div props, which are spreaded and passed into the root div-child. This is used in the following demos: ImgMediaCard.js, Showcase.js, PageLayoutExample.js, PremiumTheme.js and more. For example like this: <CardMedia               component="a"               href={theme.href}               rel="noopener nofollow"               target="_blank"               className={classes.media}               image={theme.src}               title={theme.name}               data-ga-event-category="premium-themes"               data-ga-event-action="click"               data-ga-event-label={theme.name}             />.
The JS code does not fail, since the props are just spreaded anyway, but the TS code needs to know, which props are acceptable and the div props were not added to the CardMediaProps.
This PR adds the div props to the CardMedia Component.

I would rather see this applied with #15130 so that we can verify that this actually worked. I'm not familiar with AllHtmlAttributes though. Would this reject <CardMedia href="not-on-a" />? If not then we should rather apply #15003.

@Domino987 Thanks.

@Domino987 BTW, thank you for all the German translations! You killed it <3.


Fix incorrect behaviour with negative ranges

This apply the fix in issue https://github.com/kennethkalmer/ember-cli-nouislider/issues/24 that allow to use negative numbers without the slider jumping back to minimal value

Thanks! Sorry for letting this one slip past

v0.12.0 has just been released, thanks for your contributions!


The tweak you entered is not in the correct format, or your not running as root.

dpkg-deb: error: --extract takes at most two arguments (.deb and directory)

This should be fixed in the upcoming update, I think you have spaces in your file names


Link to how one creates user-assigned managed identities

Step one of the steps describes the need to create or use an existing user-assigned managed identity and contains a link describing the purpose of the managed identities as a whole, but takes several clicks from there to learn how to just create one.
I'd suggest that a link be directly provided there to https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-to-manage-ua-identity-portal so users can directly learn how one creates the identity if they don't already have one.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c416d5e-5bfd-c641-e9bb-324dcb921acc
Version Independent ID: 8739a044-d471-c432-3ed1-503539408ae8
Content: TLS termination with Azure Key Vault certificates
Content Source: articles/application-gateway/key-vault-certs.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@WhitWaldo,  Thanks for the feedback!  Your feedback  has been shared with the content owner for further review.

Link updated.
#please-close


refactor: No need for CachedData in library_search and rw?

Previously, Mathlib.Tactic.Cache defined a CachedData data structure
to keep a reference to the CompactedRegion that we get when unpickling
the cache from a file, but it was never used.
It also seems to be the case that keeping that reference is not
necessary to keep the unpickled data alive. (It is the other way around:
The data stays alive until .free is called explicitly, which we do not
plan to do here.)
Therefore, to simplify the code, this PR removes CachedData. This came
out of working on #find in #6363

bors merge


Polish dark theming

Description
Changes proposed in this pull request:

Use theming CSS variables here and there instead of fixed colors
remove the Notification component
use Toast or Luigi.confirmationModal in NotificationContext

Related issue(s)

/test pre-busola-integration-test-k3s

/retest


Add CODEOWNERS to the acir serialization codegen file

Problem
If the serialization changes, then its a breaking change that breaks every backend. Tom pointed out that assigning codeowners would be good so that these changes do not get past code review by one of said code owners.
Comment: https://github.com/noir-lang/noir/pull/2961#issuecomment-1745392692
Happy Case
.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Closing until the need for this pops up due to a lot of people editing the file and not knowing what the repercussions are


Scorecard category issue

A user has reported being unable to select the combination of Behind Enemy Lines, Assassination and A Deadly Performance on the score sheet, and there's been a suggestion that having a category selected in the secondary selector prevents anything from that category being selected directly on the scoresheet.

This issue is becoming irrelevant in v2.43 due to an overhaul of the way secondaries are selected.

This issue is becoming irrelevant in v2.43 due to an overhaul of the way secondaries are selected.


Selection text is dark when main window is blurred

When blurred class is added to body as in when developer tools is active, the selected text becomes dark making it nearly unreadable.

Resolved by #5


Backport UP-4835 Remove Groovy Interactive Shell to rel-4-3-patches

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines

Description of change

Removed the running the groovy in interactive mode code from up-shell ant target and PortelShell.java
Issue link - https://issues.jasig.org/browse/UP-4835

Coverage increased (+0.05%) to 22.191% when pulling 45da7be77438e77ac06d9c36980035cb12dae910 on ChristianMurphy:UP-4835-rel-4-3 into f36f6eacbfb0db75ef26ab9f58c53e7528108253 on Jasig:rel-4-3-patches.


Added code to print longest common subsequence

Have you read the [Contributing Guidelines on Pull Requests]
Yes
Description
I have added the algorithm to print the longest common subsequence between two strings and also it's length.
For example - If the input strings are "QWERTYHU" and "WROPYHUI" , the output will be "WRYHU" and length is 5.
The code has been written in C++.
I have also updated the read me section under cpp.
Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Solves the issue #2948

Could you please review my PR @HarshCasper

@Yukti-1 Duplicate issue. Please checkout #438 .
Happy Coding!

@Yukti-1 Duplicate issue. Please checkout #438 .
Happy Coding!

Actually, I have added the code which prints the subsequence which is longest common and the issue you mentioned just prints
it's length. So, I think they are not same.

The code you mentioned above follows the same DP approach to solve a different problem from the one I submitted though I didn't copy from here nor did I see it before.
The resulting similarities which you found may be because in any DP problem, the general way is to construct a matrix(as far as I know) and store the result somewhere(here matrix) and use it later to avoid computing same subproblems again.
And yeah that's it. @ankitaggarwal23


Binding Signal from GUI drops bound Parameter if targetScript/Node Type changed

Godot version
v4.1.rc2.official [46424488e]
System information
Windows 10
Issue description
Hi,
while changing the targetNode Type from Node to Node3D, all GUI connected signals drop their previously fineworking bound Parameters.
shouldn't they keep it?
E 0:00:14:0292   emit_signalp: Error calling from signal 'button_up' to callable: 'Node3D(human_NeedsAndMood.gd)::setNeed': Method expected 0 arguments, but called with 0.
<C++-Quelle>   core/object/object.cpp:1080 @ emit_signalp()
Steps to reproduce
connect signals (either from direct Childs or otherwise in that scene) with a bound Parameter via the GUI to a Node with a script.
If you change the type of the recieving node (manually in Script as well as the Nodeitself), all connected Signals forget their Parameter.
Minimal reproduction project
NA

Related to: #75105

Can't reproduce in 4.2 dev.


Shoot hibernation fails when there is webhook working on delete pods requests

How to categorize this issue?

/area cost ops-productivity quality usability
/kind bug
What happened:
Shoot hibernation is failing on the step Hibernating control plane as there are still running pods.
In general, this should not be a problem, but in this case the KCM is always failing to delete the pods due to webhook working on delete pods (does not matter if the kube-system namespace is excluded or not) and the pods backing the webhook are already deleted.
What you expected to happen:
One or more of the following

shoot owners to be provided with option the pods backing the webhooks to be deleted last
gardener to not wait all running pods in the cluster to be deleted
shoot hibernation constraints to be enhanced and detect webhooks catching delete pods requests as problematic

How to reproduce it (as minimally and precisely as possible):

Create a shoot cluster
Deploy a pod, e.g. k -n default run alpine --image=alpine
Deploy the following webhook

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
  name: block-hibernation
webhooks:
- admissionReviewVersions:
  - v1beta1
  clientConfig:
    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUREakNDQWZhZ0F3SUJBZ0lVS0RhRkp0Ym5lWmFZcGVURzdFamVscURuRS9Nd0RRWUpLb1pJaHZjTkFRRUwKQlFBd0h6RWRNQnNHQTFVRUF4TVVZMkV0WW14dlkyc3RhR2xpWlhKdVlYUnBiMjR3SGhjTk1qTXdNekE0TURnMApOekF3V2hjTk1qZ3dNekEyTURnME56QXdXakFmTVIwd0d3WURWUVFERXhSallTMWliRzlqYXkxb2FXSmxjbTVoCmRHbHZiakNDQVNJd0RRWUpLb1pJaHZjTkFRRUJCUUFEZ2dFUEFEQ0NBUW9DZ2dFQkFNbWtWS2ZEUTVrdVZBcy8KbnB3Z21CUDgydVVrZTVwMjUzUzBDUGlsVllYcExkTjdaTzRyQ1Y0WGU2c2tFOS91RnlNNS84eUdBckYvNlZwdgplcG9LTUswbzJKdWplNDJhWWF4N0pMbFlDV0RNK0pSamc5eWZhTjhvQU1hNXlrR3ZXQ0JwTW5PWXZwY1QrL2xoCmxkblFZd3pXUi90WWJRbW81b2tLNmhheER4M21RbU1Bb0hISHZiQXdZRlpMTHMyY1dyc01jcHNzb2loVHhpWnQKUUYvSFFlb2YwRERFcEpUMHRWUWpwNEhJQnArQVFtVHZiODVaUGczLytuZ2FGclAxWGFlWVg3UkxXcUpkL0hjNwpvQjRMZi9FeFRxbVBWYzdQQkNhc3VXOGF1SCsxbUIxendMR0lSTGNuM2pUQVRBR3IwWHJvNWQ1ajNFODVMcGc0CmMyUkZoNWtDQXdFQUFhTkNNRUF3RGdZRFZSMFBBUUgvQkFRREFnRUdNQThHQTFVZEV3RUIvd1FGTUFNQkFmOHcKSFFZRFZSME9CQllFRkw4REZ5UGQ4Vm0vQ0Y1aTd4b2dST1FzQmE1a01BMEdDU3FHU0liM0RRRUJDd1VBQTRJQgpBUUJlSERRSHZHREdCTlAxTE9JaFZnTDFZT1NYQWdPWWUxVFAyNUZwZzdsbGJuWTA1YWhaRzkwbTI3cFJNdHBECkU1Z3N0cXhsUE9LM1Q2Z0xEUmhHVVhPT05CQ2gveU1kVDFhZ3IxMTZrQ216aUcwNDFicFpNTWNNOU5uKzdDMWoKM1NWQ0dnQXdBemtwekNTSmRsbDBZNzluWlpua2lJakZOcHhBRTczRnltQkZLRGtLRG5zZVZhckNHa1dMWndyQgo5aklZc0k3SGlrenVYd3o5THJlVC8xYW5GdVd5b21JTDUyeDBiRldabmovVXVVYkZhYU00RW5jZm54d3ZGUzlJCjk4L0R4Y1VPT1ovbDZaWENTWmFsY3h2UkhFb3lQWHhvQ21hYks3ZDlQZFNHWXZKYzNtUHA5SVhkeG1Ca01KZFEKYWVreDM3bnV2RVBiSitlVVdWajlkKzdWCi0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
    service:
      name: webhook
      namespace: block-hibernation
      path: /validate/fail
      port: 443
  failurePolicy: Fail
  matchPolicy: Equivalent
  name: validate.block.hibernation
  namespaceSelector:
    matchExpressions:
    - key: kubernetes.io/metadata.name
      operator: NotIn
      values:
      - kube-system
      - block-hibernation
  objectSelector: {}
  rules:
  - apiGroups:
    - ""
    apiVersions:
    - v1
    operations:
    - DELETE
    resources:
    - pods
    scope: '*'
  sideEffects: NoneOnDryRun
  timeoutSeconds: 10

Trigger shoot hibernation
Make sure it fails on the step Hibernating control plane due to still existing running pods.

Anything else we need to know?:
The step waiting all pods to be deleted was introduced with #1638, maybe it can be also improved to not wait pods, but just the nodes to be deleted, which might also fail if it is done gracefully as node draining also tries to delete pods.
Environment:

Gardener version: v1.65.1
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

/assign

What you expected to happen: One or more of the following

shoot owners to be provided with option the pods backing the webhooks to be deleted last
gardener to not wait all running pods in the cluster to be deleted
shoot hibernation constraints to be enhanced and detect webhooks catching delete pods requests as problematic

Probably only the third proposal is what we should do. The pod deletion is on purpose, so we cannot remove it or stop waiting for the pods to be removed it. Allowing shoot owners to configure the pod deletion order is also possible of course, though it feels "too sophisticated" for such a special/rather rare problem.

Then, We'll also have to mark webhooks catching *op for pods also, right?

Any thoughts @vpnachev  ?

Maybe we shouldn't pursue this solution, even if we mark webhooks with rules for DELETE pods as problematic, this could be breaking for a lot of clusters and they might not even want to use the hibernation feature.
I have a branch https://github.com/shafeeqes/gardener/tree/enh/webhook with this implementation, but for the above said reason, I don't want to go ahead with it.

/unassign
I don't have any better ideas for now.

We discussed this again and don't see a good solution right now (ref https://github.com/gardener/gardener/issues/7614#issuecomment-1569483203).
Hence, we
/close
it as "won't-fix" for the time being.


Multi point hold notes

Closes #486

Note that the multi-point hold note feature has been split up into separate stories. This PR is for checking in the multi-point implementation that follows how osu! implements its sliders. This change should be completely backwards compatible with our existing maps and behavior.
Issue #520 will implement the editor side changes that allows you to actually edit multi-points on hold notes.


Openstack integration

I have still some troubles here (first of all - after update dev branch log_utils have problem with key pkb_label).
I don't run all tests on my environment but errors in this looks like problem with compilation not with driver.
Please review this code

Marcin,
This is great.  Thanks for working on it.  I am including Klaus who
recently did the DigitalOcean provider and can help you polish this up.
I'm also including Eric & Connor who give solid and helpful feedback.
Tony
On Mon, Jun 15, 2015 at 6:07 AM, Marcin Karkocha<EMAIL_ADDRESS>wrote:

I have still some troubles here (first of all - after update dev branch
log_utils have problem with key pkb_label).
I don't run all tests on my environment but errors in this looks like
problem with compilation not with driver.
Please review this code
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305
Commit Summary

template of openstack integration
add openstack base options to command line parser
add network managing and simple VM creating
fix identation
try to setup vm based on ubuntu
remove additional network creation
changes in openstack integration
add possibility to choose network name
add possibility to choose public ip pool name
fix error with keystone unauthorized
remove comments and add new line on EOF
fix cassandra and proxy
little fixes
Merge remote-tracking branch 'remotes/origin/dev' into
openstack-integration
code refactoring

File Changes

M CONTRIBUTING.md
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-0
(51)
M README.md
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-1
(27)
M perfkitbenchmarker/benchmark_sets.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-2
(4)
M perfkitbenchmarker/benchmark_spec.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-3
(21)
M perfkitbenchmarker/benchmarks/object_storage_service_benchmark.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-4
(9)
M perfkitbenchmarker/benchmarks/speccpu2006_benchmark.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-5
(4)
M perfkitbenchmarker/log_util.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-6
(4)
A perfkitbenchmarker/openstack/init.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-7
(0)
A perfkitbenchmarker/openstack/os_disk.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-8
(85)
A perfkitbenchmarker/openstack/os_network.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-9
(54)
A perfkitbenchmarker/openstack/os_virtual_machine.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-10
(153)
A perfkitbenchmarker/openstack/utils.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-11
(110)
M perfkitbenchmarker/package_managers.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-12
(50)
A perfkitbenchmarker/packages/curl.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-13
(31)
M perfkitbenchmarker/packages/fio.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-14
(2)
M perfkitbenchmarker/packages/memtier.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-15
(2)
M perfkitbenchmarker/packages/netperf.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-16
(4)
M perfkitbenchmarker/packages/openblas.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-17
(2)
M perfkitbenchmarker/packages/ycsb.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-18
(41)
M perfkitbenchmarker/pkb.py
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305/files#diff-19
(13)

Patch Links:

https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305.patch
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305.diff
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305.

--
Anthony F. Voellm (aka Tony)
Google Voice:<PHONE_NUMBER>
https://www.google.com/voice/b/0?pli=1#phones
Blog: http://perfguy.blogspot.com/

It'll take me some time to go through it in detail. It looks ok in general, but I think this should be split up into separate pull requests since it has several distinct pieces in it, for example:

adding proxy support - a good idea, but not really openstack specific, and it touches a lot of files. I assume the change from git:// to http/https protocols was to support this?
non-openstack documentation updates and general cleanups
pkb_label issues - we should track down what's going on here. The label should be added by PkbLogFilter automatically, if you're missing it something seems to be going wrong. Shouldn't just remove it from the log messages.
openstack support itself.

The current pull request contains a lot of incremental changes - since it's your branch that (presumably) nobody else is basing further work on, you can rewrite history to clean this up and split it into topic-specific changes. How familiar are you with using "git rebase -i"? If you need help doing repo surgery on this, I can work with you to get this sorted. Specifically, I think it would be best to rearrange the current changes into a series of topic-specific changes, cherry-pick the side ones into separate branches and pull requests (these should be quick to get through), and then revisit the main openstack integration patch once the others are in.
Also, github currently says "We can’t automatically merge this pull request." - can you please pull and re-merge the current "dev" branch? Please use "pull --rebase" to keep your own changes stacked on top of the merge - you may need to drop and re-do the earlier merge to make this work.

Ok, i was created new pull request for proxy setup https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/309

Ok, i was cleared my branch and simple rebase it to dev branch.
Guys i'm going for my honeymoon in wednesday and i plan to be out of internet in next 4 weeks.
In my team i have backup but without access to my github account, then please we can merge it to dev fast and next Mateusz for my team can make fixes for it on demand.
Do you thing it is possible?
Or do you have another proposition what we can do with it?

I'm looking at it now, thank you very much for rebasing and doing the proxy change separately. At first glance I think it seems workable to go ahead with this and iterate since the changes are now isolated well enough to have good confidence it won't break things for other cloud providers.
Since there are likely to be some edits involved, we'd need someone on your side to help verify that the proposed version works for you since we don't have the right environment to test this ourselves. This wouldn't require access to your github account, just pulling changes from a proposed branch and running them would be sufficient.

FYI, we currently have two potentially overlapping pull requests in flight:

https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/305 (Openstack integration by @kivio)
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/336 (Rackspace support by @meteorfox)

Could you please look at each other's proposed changes to see if there's potential for combining common parts? The implementation details differ, for example using the Nova Python API vs the Nova CLI tool, and the Rackspace version has more information about specific deployment options such as zones and machine types.
If the two implementations address different use cases, we can potentially add both, but are there other options such as making Rackspace a subclass of a generic Openstack provider that may be worth pursuing here?

Hi, I will backup Marcin during his vacations. Regarding your comment on Rackspace integration, we think your proposals sounds good to us. Rackspace is such specific installation of OpenStack that it could be added separately.

Hi guys,
together with emaeliena we are covering for Marcin while he's on vacation. Thanks for careful review - I have checked in the fixes so that it is ready to be reviewed again.
Mateusz

FYI, I'm currently working on merging this. There are some conflicts due to a recent refactoring that affects default VM arguments, and some other minor issues. I'll make a separate pull request for comments and testing once it's ready.

Please see https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/353 for the proposed merge which includes some fixes and tweaks - can we continue the discussion there?

Sure - let's continue at https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/353

Merged via https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/353 .


library not found for -lPods

RV,

Downloaded revised version
Installed the pod -  see listing below.
Build the:  RVCalendarWeekView.xcworkspace
ERROR  ld: library not found for -lPods

Does show in the Linked Frameworks and Libraries
Thanks for any help you can provide.
John
POD INSTALL:
iMac:RVCalendarWeekView-master iMac$ pod install
Analyzing dependencies
Downloading dependencies
Installing Collection (1.3.9)
Installing DateTools (1.7.0)
Installing EasyDate (0.7)
Installing Masonry (1.0.1)
Installing UIColor-HexString (1.3.0)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 4 dependencies from the Podfile and 5 total pods installed.
ERROR IN Building the:   RVCalendarWeekView.xcworkspace
Ld /Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/RVCalendarWeekView.app/RVCalendarWeekView normal arm64
cd /Users/iMac/Desktop/RVCalendarWeekView-master
export IPHONEOS_DEPLOYMENT_TARGET=9.3
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.3.sdk -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/Collection -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/DateTools -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/EasyDate -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/Masonry -L/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/UIColor-HexString -F/Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos -filelist /Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Intermediates/RVCalendarWeekView.build/Debug-iphoneos/RVCalendarWeekView.build/Objects-normal/arm64/RVCalendarWeekView.LinkFileList -Xlinker -rpath -Xlinker @executable_path/Frameworks -miphoneos-version-min=9.3 -dead_strip -Xlinker -no_deduplicate -fembed-bitcode-marker -ObjC -lCollection -lDateTools -lEasyDate -lMasonry -lUIColor-HexString -framework Foundation -framework UIKit -fobjc-arc -fobjc-link-runtime -lPods -lPods-RVCalendarWeekView -Xlinker -dependency_info -Xlinker /Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Intermediates/RVCalendarWeekView.build/Debug-iphoneos/RVCalendarWeekView.build/Objects-normal/arm64/RVCalendarWeekView_dependency_info.dat -o /Users/iMac/Library/Developer/Xcode/DerivedData/RVCalendarWeekView-cnfjwuzsyzzxfaceumqcccuvxqtr/Build/Products/Debug-iphoneos/RVCalendarWeekView.app/RVCalendarWeekView
ld: library not found for -lPods
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Are you opening the workspace instead of the .xcodeproj right?

@BadChoice  open RVCalendarWeekView.xcworkspace

@liangjuliu can you check the last commit?
ipad2 simulator is not working yet (I'm trying to figure it out why, but others simulators should)


Enabled grunt shell tab auto-completion

Does not cause a Syntax error as described here: mathiasbynens/dotfiles#224, because it inserted before command -v grunt > /dev/null && alias grunt="grunt --stack".

Does there exist a similar approach for npm and gulp?

@vinkla yes on both.
Using nvm you can enable bash completion for npm with source $NVM_DIR/$(node -v)/lib/node_modules/npm/lib/utils/completion.sh
Gulp bash completion can be enabled with eval "$(gulp --completion=bash)"
@scthi please note that .bash_profile would probably be a better way to put these commands than .aliases dotfile

Cool! Where should I put them? In . bash_profile ?

@thibmaek It was in .bash_profile but was removed, since it caused a Syntax error. Have a look at mathiasbynens/dotfiles#224.
The bash completion only works if added before  command -v grunt > /dev/null && alias grunt="grunt --stack".

@scthi oh ok then. I don't use grunt so I didnt notice.
Works fine for gulp & npm though.

@scthi Is there anyway to speed this completion up? Currently performs quite slow for me.

The completion is provided by the grunt-js team: https://github.com/gruntjs/grunt-cli/blob/4cb7ebf4fe07522e64c6fad85a74404ed6ed4671/completion/bash
I needs to load all defined grunt task and doesn't use any caching in order to support dynamic tasks.
To speed things up, it might help to load required 3rd party npm grunt tasks and other modules only on-demand.
Here is a simple example:
 // js hint task
  grunt.registerTask('jshint', 'Runs jshint validation.', function() {

    grunt.loadNpmTasks('grunt-contrib-jshint');
    grunt.config('jshint', {
      app: '...',
      grunt: {
        files: { src: '...' },
        options: { jshintrc: 'grunt/.jshintrc' }
      },

      options: {
        jshintrc: '.jshintrc',
        reporter: 'node_modules/jshint-stylish/stylish.js'
      }
    });
    grunt.task.run('jshint');
  });


add test for coverall

Pull Request Test Coverage Report for Build 509

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 85.552%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/logic/commands/ApplyCommand.java
2
66.67%

Totals

Change from base Build 506:
0.4%

Covered Lines:
2037

Relevant Lines:
2381

💛  - Coveralls