[TS migration] Migrate 'Details' page to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/25196
PROPOSAL:
Tests

Go to a report (Chat)
mention any user
click on the highlighted mention
Verify that the Details Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a report (Chat)
mention any user
click on the highlighted mention
Verify that the Details Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native-converted.webm

Android: mWeb Chrome
android-web-converted.webm

iOS: Native
https://github.com/Expensify/App/assets/23215729/0302b299-fc35-4da7-84bf-5d248f3c3388

iOS: mWeb Safari
https://github.com/Expensify/App/assets/23215729/009eaf15-663a-4d19-b075-0b2a89bd7ce6

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/23215729/e19324d4-624f-444d-a454-4c87406b52bf

MacOS: Desktop
https://github.com/Expensify/App/assets/23215729/758984d8-d6bf-4936-b8d3-650747f42f0d

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Hey team, there's a Typescript error that occurred after I merged this PR. Possibly due to recent changes on main, as it looks like the commit was made about 1 week ago.

Let's consider this small poem I wrote for this occasion:

Before you merge, take a spin,
Merge main first to win,
Skip this step, you'll bear the scars,
Do this thing on all PRs!

You can try singing it too.

Okey, it's GPT, but it took at least 3 iterations and I fixed some lines

Thanks @cubuspl42. Yeah I'd love for recently merging main to be CI requirement. Unfortunately if we ask for this it can delay the PR by a day 😞

Just messaged @pasyukevich, this should be a quick fix. Let's not revert it @Julesssss  🙏

Thanks, I fixed it myself to save time.

I think you linked the wrong PR @Julesssss

Ah thanks, It's merged now: https://github.com/Expensify/App/pull/36474

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


dont mention @nogc for slices

Just noticed that - it's probably confusing for newcomers.
Btw using /** and */ as comments seems a lot cleaner to me.
We should probably look through all the examples to ensure that they reflect the Phobos style guide - it would be bad to teach otherwise.

Opened bug #43 for this. Phobos seems to be using /** and */ syntax for comments.
Thanks for the PR! Will be merged.


[Bug] Unable to view clipboard contents

Hi this seems like a really useful plugin, if I can get it to work. I have installed the plugin in the path mentioned, and I can see it in the list of Plugins in PowerToys Run, and it is enabled and it's shortcut is set to the default c:. When I click Alt+Space, I can see the clipboard manager listed in the list of plugins, and it shows its shortcut correctly 'c:'. But when I select it, or type c:, the list is empty. I have copied from Windows , notepad, VS Code, my WSL 2 distro, all of it. But it doesn't seem to matter. I can't see anything in the list of clipboard history. I found the other issue on this repo mentioned missing Clipboard entries and you had asked to check the logs. So here is what I found in the logs: (Just a few entries about ClipboardManager):
[2024-09-04 02:44:25.6073] [INFO] [D:\a\_work\1\s\src\modules\launcher\Wox.Plugin\PluginPair.cs::144]
Load cost for <ClipboardManager> is <99ms>

[2024-09-04 02:44:26.4585] [INFO] [D:\a\_work\1\s\src\modules\launcher\Wox.Plugin\PluginPair.cs::56]
Total initialize cost for <ClipboardManager> is <99ms>

[2024-09-04 02:52:20.2244] [WARN] [D:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::229]
PluginManager.QueryForPlugin ClipboardManager. Query cost - 79 milliseconds

There doesn't appear to be any errors in the log file. Just these few entries about ClipboardManager. I found PowerToys had updated after I installed it, I have updated to the latest version, but I'm unable get this ClipboardManager to work.
Please let me know if you need any more information to trouble shoot this issue.
Thansk,

Hi @arunk
Could you first check that you have clipboard history enabled in Windows. You can do this by pressing Windows key + v.
It will give you the option to enable if it isn't already.
If this isn't the case then let me know and I can take a further look into other potential issues!
Thanks!

That was it! I was going to suggest updating the README, but I just checked and realized I missed seeing this under requirements. Sorry about that! This is great! I'll be able to copy and paste all kinds of things between all my editors. Thanks so much for this

I think a couple of people have had this issue too so I've added in some detection in the latest release to check if the windows clipboard history is not enabled and also provide the ability to enable it directly via the plugin.
Hopefully this helps some people in the future!


higher val_loss have higher val_loss, why?

with the training:
Q1: train_acc keep increase but the val_acc oscillation
Q2: higher val_loss have higher val_loss

Q1:
Obviously training accuracy will keep increasing (see overfitting) as that's the data the model uses for weight updates.
Validation accuracy will typically oscillate heavily if the validation data is too small and dissimilar to the training data, but you should always expect it to oscillate. Average the validation accuracy curve and look for positive trends instead.
Q2:
Higher val_loss have higher val_loss? Care to elaborate a bit?

@carlthome
Thanks for your answer!
about Q2:
usually lower val_loss have higher accuracy,
but i meet higher val_loss have higher accuracy.
like this:
epoch 55          val_loss:1.3  accuracy: 85%
epoch 56         val_loss:1.4  accuracy :86%

Smaller loss does not necessarily mean higher accuracy, it can mean that the right predictions were made with higher confidence. This also means that the accuracy can actually increase a bit if the loss increases as well.

@alex-j-j
Thank you very much!


Error when building - directive.js: line 27, col 19, 'drake' is already defined.  1 error

Thanks :+1:


Add helper method IndexManager.tryGetHistory

QLNet

Description of PR
Adds a small helper method tryGetHistory(..) to simplify some IndexManager lookups. It's based on the fairly common Try... pattern in .NET. Will add unit tests if required, but I think this is small enough to omit them.

Thank you for contributing! Take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
You must open an issue before embarking on any significant pull request, especially those that
add a new code or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:

[x] You have followed our contributing guidelines
[ ] Pull request has tests
[x] Code is well-commented and follows project conventions
[x] You only changed necessary files (commits with formatting only changes will be reject, see below)
[x] Documentation is updated (if necessary)
[x] Description explains the issue/use-case resolved and auto-closes related issues
[x] IMPORTANT You have executed the format_code.bat batch in the root of your fork to format the code with qlnet standard.

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch via a Pull Request, you agree to allow the project
owners to license your work under the terms of the BSD3 License.

Use case:
Simplifies my code from
var indexManager = QLNet.IndexManager.instance();
var addIt = true;

if (indexManager.hasHistory(jibar.name()))
{
    var ts = indexManager.getHistory(jibar.name());
    if (ts.ContainsKey(_paymentCalendar.adjust(lastResetDate)))
        addIt = false;
}
if (addIt)
    jibar.addFixing(_paymentCalendar.adjust(lastResetDate), resetCoupon);

to
var indexManager = QLNet.IndexManager.instance();
QLNet.TimeSeries<double?> ts;
if (!(indexManager.tryGetHistory(jibar.name(), out ts)
      && ts.ContainsKey(_paymentCalendar.adjust(lastResetDate))))
    jibar.addFixing(_paymentCalendar.adjust(lastResetDate), resetCoupon);


local_testnet_upgrade_l1.sh

Potential Race Conditions in Network Status
In the part where you're waiting for the validators to be up:
curl -o /dev/null --connect-timeout 5
--retry 10
--retry-delay 10
--retry-all-errors
http://localhost:$VALIDATORS_RPC_PORT_START/status

can you elaborate on this further or propose a better way of doing this? It's quite low priority for us since it's kind of just like a sanity check in a testing script, but I'm willing to make changes if there's something we can do better


Make phone number in test suite configurable.

@markandrus I have a gut feeling that there is likely a better way to make the test phone number configurable. That being said, the below compiles and works.
I'd be glad to iterate on this until we get something up to par in terms of quality.

@StevenXL I think this is a good first pass. Thanks, too, for documenting the test process in the README.md. Travis CI is being finicky, but I think we can merge anyway.


TypeSystemMode.MINIMAL may not work properly

Describe the bug
It appears that CASes serialized using TypeSystemMode.MINIMAL may contain too many files.
To Reproduce
To be investigated.
Expected behavior
In TypeSystemMode.MINIMAL, only types for which annotations exist or which are essential to the definition of other used types should be included.
Please complete the following information:

Version: 0.4.0

Actually, it seems that this mode has not yet been implemented at all...


Implement rule: Is there code present in the repository?

At least one file containing code or with an extension indicating it should contain code exists in the repository.

Implemented this using Pygments' lexer-guessing functionality. See also http://pygments.org/docs/lexers.


[Bug]  Tried to get a wrench or open create creative inventory and crashes (extended cogwheels related?)

Describe the bug
I tried to get a wrench in the creative inventory search and the game crashed. when I tried the creative create inventory, it crashed too. Sorry to bother you.
To Reproduce
Steps to reproduce the behavior:

Launch Minecraft
Join a World
search for a wrench or go to creative inventory to create
See the error

Expected behavior
crashes and error appears (see below of screenshot
Screenshots

Desktop (please complete the following information):

OS: Windows
Minecraft Version 1.19.2
Forge Version 43.0.0
Create: Extended Cogwheels | Rabbitminers | extendedgears-1.19.2-0.5.0g-1.1.2.jar
Flywheel | jozufozu | flywheel-forge-1.19.2-0.6.8.a.jar

Additional context
Sorry to bother

sorry,
create-1.19.2-0.5.0.i.jar
The game crashed whilst unexpected error
Error: java.lang.NoClassDefFoundError: com/cyvack/create_crystal_clear/blocks/glass_encased_cogwheel/GlassEncasedCogwheel
crash-2023-03-17_10.36.55-client.txt
Hope this helps, sorry for the inconvenience.

Can you try to update the version of Forge ?

That Was fix in new update

sorry to bother

I am sorry but still experiencing an error with the Extended Gears mod.
Error: java.lang.NullPointerException: Registry entry not present: createcasing-extendedgears:brass_dark_oak_encased_cogwheel
sorry, the error above (in previous comments) involved the crystal clear mod.
I am so sorry if I am being a nuisance.
crash-2023-03-17_18.35.38-client.txt

Hey, it doesn't matter to make reports, on the contrary it helps the mod to improve

And I know this crash but I don't know where it comes from

That Fix


Pytorch 1.11 Request

Can you provide Pytorch 1.11 for Tesla K40C?
Thank you in advance.

Yes sorry, I've been a bit busy with other stuff. I'll try to have these up in the next few days.

We are looking forward to it!

Thank you so much!


Support Maui Blazor

Is your feature request related to a problem? Please describe.
Hot Reload not working on Maui Blazor projects.
Describe the solution you'd like
Support for Maui Blazor Projects.
Describe alternatives you've considered
There really isn't any.
Additional context
I also get this error the second time I try to build a project:

Hi, first of all I want to say that I haven't used Maui nor do I have the time to look into it, so this answer is based on what I do know regarding Blazor WebAssembly.
We currently don't support the .NET hot reload functionality with scss files. In ASP.NET Core/Blazor server we can work around this by using the sass watch command that will automatically recompile the scss whenever it changes, which can then trigger the hot reload functionality as the .css files have changed.
In Blazor WebAssembly we can't run the watcher as we can't spawn the process to watch the files or even get the files from the file system (as we're in the browser sandbox).
As far as I know there isn't a way for us to hook into the hot reload functionality for custom file extensions.
Regarding the second error you're getting, are you using the latest version? I have seen that before but thought to have fixed it. If you are using the latest version, then it's a bug.

I had not heard back on this yet, any thoughts?

Hi @RacerDelux , Sorry for the delay, I've fixed the issue about the duplicate app.css asset. It seems like maui is more restrictive about duplicate content files as we always included all generated css files in the <Content /> itemgroup, but if they were already generated from a previous build, they would already be in the <Content /> group thus resulting in duplicate entries. For the other applications we've tried it with this wasn't an issue but apparently for MAUI it is. The linked PR should fix this issue and is included in version <IP_ADDRESS>. Please let me know if that fixes the issue for you and if not feel free to reopen the issue.


Powering floppy drive

The instructions seem to suggest that you can power the floppy drive from the PSoC board. Is that really correct? When I do this it doesn't seem like the floppy is really powering on.
Is the other option to provide an external 5V supply and make sure to tie the ground of that supply to the ground of the PSoC?
Thanks,
-Pete

No, that doesn't work --- I need to update the documentation. I was misled by my original test drive, which claimed to draw 400mA, but lied.
Yes, providing an external power supply and tying the grounds together should work.

OK, good to know. It seemed a little magical to think it would work.

I've rewritten the docs. See http://cowlark.com/fluxengine/doc/building.html.


Inference missing issue

I noticed that the example given in the homepage, when you run
lg.run_inference(debug=False)
the "Mean_inferred" of 'C' value is miss,and I'm confronted with same problem as i use all data but the output to predict output,and only get '_'.
could you give me some enlightment?

（） I noticed that the example given in the homepage, when you run lg.run_inference(debug=False) the "Mean_inferred" of 'C' value is miss,and I'm confronted with same problem as i use all data but the output to predict output,and only get '_'. could you give me some enlightment?

of course I've comprehened the exmaple cause 'C' node has no correlation with the evidence node 'A' and 'B'. No wander it gets nothing.
but during my training, this happens that one inference data was missing among a batch of normal inference


Refactor consolidate i18n per component

There's another convention we didn't mention yesterday (sorry 😥)
//the first part of the snake_case key should be the name of the related module
which is important, cause the TranslationService acts as a global registry and we have to avoid key collisions.
The second snake_case_value should be the name of the particular component package.
This means in our case:

olMapProvider -> map_olMap_...
layerManagerProvider ->  map_layerManager_..

We also need an extra provider for infoButton
The keys in contextMenue.provider.js  have also to be adjusted...

a provider for zoomButtons follows..

some minor fixes in naming the keys and introcing zoomButtons.provider.
extend the tests with a check on the translation-map-size


CHANGELOG: prepare for 0.5.2 release

What it says on the tin

Should we consider enabling source caching by default? (Or after cutting this release, so it can be tested on tip for a cycle)
We never really established a timeframe for making it default, but it's been available for 11mos now.
https://github.com/golang/dep/blob/master/docs/env-vars.md#depcacheage

Ah, good idea! I think we do this release, turn it on then do a 0.6.0
release in 3-4 weeks.
Do you want to submit the source caching change?
Kevin
On Wed, May 8, 2019 at 12:47 Jordan Krage<EMAIL_ADDRESS>wrote:

Should we consider enabling source caching by default? (Or after cutting
this release, so it can be tested on tip for a cycle)
We never really established a timeframe for making it default, but it's
been available for 11mos now.
https://github.com/golang/dep/blob/master/docs/env-vars.md#depcacheage
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/pull/2157#issuecomment-490624843, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABZEI2M5KCVY5WLDSX3M63PUMU4NANCNFSM4HLUSQWA
.

--
Kevin Burke
phone:<PHONE_NUMBER> | kevin.burke.dev

Yeah, I'll work on that.


Issue #3

PR resolves issue #3 duties. Add tests for all of the command CLI commands.

Need to specify the genesis files of the environments where the tests need to run.

Files specified in a new .feature file created. Also corrected file names according to the nomenclature. Please check @luyzdeleon

Need to specify the genesis files of the environments where the tests need to run.

Files specified in a new .feature file created. Also corrected file names according to the nomenclature. Please check @nelcolon

Corrected filed addition, changed to one .json file per genesis, and reference in the main pocket-genesis-file.feature file.


[BUG] Description of bug

Describe the bug
Timeline page is blank after clicking on the "university towns: income" link from the main page
To Reproduce
URL: https://staging.datacommons.org/tools/timeline#&place=geoId/0606000,geoId/2511000,geoId/2603000,geoId/1777005,geoId/1225175,geoId/4815976&statsVar=Median_Income_Person
Browser: Chrome
Screenshots

These links also broken:
https://staging.datacommons.org/tools/timeline#&&place=geoId/06085,geoId/06025&statsVar=Median_Income_Person
https://staging.datacommons.org/tools/timeline#&&place=geoId/1304000,geoId/4982950&statsVar=Median_Income_Person
https://staging.datacommons.org/tools/timeline#&&place=geoId/0655282,geoId/0620956&pc=0&statsVar=Median_Income_Person

Maybe a browser cache issue. Can you try hard refresh and see if they work?

Yep, I still see it with my cache disabled.


As a developer, pack build exits cleanly and quickly on ctrl-c when an image is pulling

Acceptance Criteria
When I pack build
And An image starts pulling
And I ctrl-c
Then It exits immediately
And I don't observe network traffic

It seems like this works now that the pull logic has been pulled into pack but it does print a fairly raw (ugly?) error. Are we okay we this? If not what do we want it to look like?
./pack build -p ./acceptance/testdata/node_app/ --builder gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14 node/app
Using user-provided builder image gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14
Pulling builder image gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14 (use --no-pull flag to skip this step)
^CERROR: error during connect: Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.38/images/create?fromImage=gcr.io%!A(MISSING)443%!F(MISSING)cncf-buildpacks-ci%!F(MISSING)packs%!F(MISSING)samples&tag=3.0.0-alpha.3-build.14: context canceled

This story passes acceptance


Fixes and improvements to the UI

Still to be improved, but I'll continue after updating egui library


Added logger property to API.php

Fixes #34

Current coverage is 86.55%

Merging #35 into master will not affect coverage as of c336bab

@@            master     #35   diff @@
======================================
  Files           25      25
  Stmts          595     595
  Branches         0       0
  Methods        129     129
======================================
  Hit            515     515
  Partial          0       0
  Missed          80      80

Review entire Coverage Diff as of c336bab

Uncovered Suggestions

+2.35% via ...SnapshotBitstamp.php#27...40
+2.02% via ...eBitstampCommand.php#15...26
+1.51% via ...tstampTradePairs.php#78...86
See 7 more...

Powered by Codecov. Updated on successful CI builds.


How to create custom metric with more inputs than y_true, y_pred in Keras 3

Previously Keras 2 I can use model.add_metric() to add any arbitrary tensor as my metric.
But Keras 3 removed .add_metric() method from layer and model.  How can I achieve that?
BTW I can't subclass keras.metrics.Metric. because my metric tensor calculation require more tensors  than y_true, y_pred.
Thanks

just as an idea, maybe this could help (custom loop.):

loss_fn = keras.losses.CategoricalCrossentropy(from_logits=True)
optimizer = keras.optimizers.Adam()

epoch_results = [ ]
for step, (x, y) in enumerate(dataset):
    with tf.GradientTape() as tape:
        logits = model(x)
        loss_value = loss_fn(y, logits)

    epoch_results+=my_metric(y, logits,other_args) # <----

    gradients = tape.gradient(loss_value, model.trainable_weights)
    optimizer.apply_gradients(zip(gradients, model.trainable_weights))

print(sum(epoch_results)/len(epoch_results))


Issue with global_position while tween and pivot offset is set with certain values

Tested versions
Godot 4.2.1
System information
Win 11
Issue description
Issue with tween weird behavior:  it keeps moving the square further and further away from the center of the screen
extends ColorRect
var tween:Tween

func _ready():
    self.pivot_offset = (self.size / 2)

    tween = create_tween().set_parallel(true)
    tween.tween_property(self, "rotation_degrees", 15.0, 0.6)
    # tween.tween_property(self, "scale", Vector2(1.05f, 1.05f), 0.6) # also with this

func _process(delta):
    self.global_position = self.global_position

Diminishing the pivot_offset to zero mitigates the issue
Steps to reproduce
single scene with squares colorRect with this script on it
extends ColorRect
var tween:Tween

func _ready():
    self.pivot_offset = (self.size / 2)

    tween = create_tween().set_parallel(true)
    tween.tween_property(self, "rotation_degrees", 15.0, 0.6)
    # tween.tween_property(self, "scale", Vector2(1.05f, 1.05f), 0.6) # also with this

func _process(delta):
    self.global_position = self.global_position

Minimal reproduction project (MRP)
extends ColorRect
var tween:Tween

func _ready():
    self.pivot_offset = (self.size / 2)

    tween = create_tween().set_parallel(true)
    tween.tween_property(self, "rotation_degrees", 15.0, 0.6)
    # tween.tween_property(self, "scale", Vector2(1.05f, 1.05f), 0.6) # also with this

func _process(delta):
    self.global_position = self.global_position

Can't reproduce in 4.3 beta1. Can reproduce in 4.2.2. So looks like it'll be fixed in 4.3.

Can't reproduce in 4.3 beta1. Can reproduce in 4.2.2. So looks like it'll be fixed in 4.3.

true tested also but in the 4.3 beta2 there is a related issue now: with the same code try to scale only with scale:x as so
tween_flip.tween_property(self, "scale:x", 1.0, 0.2)
Notice that the pivot should be and is based on the testing on the center of the object but on scaling:x (not on only scale, that is correct) is now on x=0,

Can't reproduce in 4.3 beta1.

Thanks, indeed its not reproducable anymore. Closed.


Error while trying to  "Undo Receipt" a "Posted Purchase Receipt" that is bind with a cancelled "Posted Purchased Invoice"

Hello.
I have create a Purchase Order with 1 item with quantity 1 and posted this with choice Receipt. After I create and post a Purchase invoice for this receipt and finally cancel this posted purchase invoice. When I'm trying to "Undo Receipt" from the lines of the "Posted Purchase Receipt" getting this error
"You cannot post these lines because you have not entered a quantity on one or more of the lines.".

I also notice that after canceling this particular "Posted Purchase Invoice" the fields value of "Qty. Rcd. Not Invoiced", "Quantity Invoiced" and "Qty. Invoiced (Base)" in the "Posted Purchase Receipt" is not affected/updated.
Versions:

AL Language
Description: Development tools for Dynamics 365 Business Central
Version: 13.0.971907

Business Central:
Version: W1 24.0 (Platform 24.0.18959.0 + Application 24.0.16410.17628)

Hi, this issue is out of scope of for this repository. You should do one of the following:
Open a support request to CSS through the PartnerSource portal
Open a bug in Collaborate
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company.
As a reminder, this repository only handles issues to do with the compiler or VSCode development experience for AL. This issue is on the application.


Feature/task-msgs

Make task-msgs more consistent
Currently, there are a few task types: station, loop, delivery, clean.  The station and loop task messages have a robot_type field.  As documented in the comments, this field can be used to specify a particular robot fleet for the requests.  The delivery and clean task messages do not seem to have that field.  I've made the change to include that field for both the delivery and clean task messages.
Also, I think it'd be more consistent if the clean task message has a task_id field.
I'm not sure whether you want the tow task message to include the robot_type field.  I can include that as well if you want.  Next, do you want to include TYPE_TOW=6 in TaskType.msg?
Thanks.

Oops!  I just saw https://github.com/open-rmf/rmf_internal_msgs/issues/13#issue-874227585.  If the robot_typefield is deprecated, then it should be removed from both station and loop task messages.  I can help with that as well.
If that is the case, what's the proper way to specify a particular robot fleet for a request?

@tongkiat
Yes the robot_type field is actually no longer supported as the assignment of a task to a robot is decided based on bids submitted by the fleet adapters to the dispatcher node. More info here https://osrf.github.io/ros2multirobotbook/task.html
This was done to make task management more intelligent. Now, the operator does not need to be burdened with the decision of assigning a task to a robot. This may not be trivial as the operator needs to decide which fleet is capable of performing the task and then figure out which robot from the fleet has sufficient resources (battery, consumables, etc) to perform the job quickest. Now, RMF takes care of all this.
But we understand that having a way to bypass this framework and directly assign a task to a specific robot is helpful for SIs and expert users. Hence we will introduce a method to do so (we expect to have it ready by the end of this year). You can track this ticket for more information https://github.com/open-rmf/rmf_ros2/issues/8
The task_id field within the Loop, Delivery and Clean msgs are no longer used as well. The task_id is specified in the parent  TaskProfile message https://github.com/open-rmf/rmf_internal_msgs/blob/b5f37660aca63e046e77b3e6e9a82f4b40ff6122/rmf_task_msgs/msg/TaskProfile.msg#L2
We didn't remove this field from the messages to not break any code that was written by our downstream users.
Also we are moving towards a more flexible framework for tasks in RMF where users will not be constrained to the rigid definitions of the Loop, Delivery, Clean and Tow tasks. The idea is to allow users to define tasks based on a sequence of "phases" (building blocks). This is currently WIP and you can follow the discussions here https://github.com/open-rmf/rmf_ros2/issues/107
Once this is ready, the above message definitions will be phased out.

We'll be closing this PR now, since it only makes changes to message types that are now considered deprecated by the new task system.


Could not find a declaration file for module 'vue-js-toggle-button'

Could not find a declaration file for module 'vue-js-toggle-button'. '/home/erick/git-projects/saps-vue/node_modules/vue-js-toggle-button/dist/index.js' implicitly has an 'any' type.
Try npm install @types/vue-js-toggle-button if it exists or add a new declaration (.d.ts) file containing declare module 'vue-js-toggle-button';
87 | const momentjs = require('moment');
88 |

89 | import ToggleButton from 'vue-js-toggle-button'
|                          ^
90 |
91 | Vue.use(ToggleButton)
92 |
Version: typescript 3.5.2

This is a javascript based component, not typescript, you need to create the d.ts file by yourself, I think


How to use a plugin?

I've returned to PHP after a few years and, being a true Kint fan, it was the first thing I installed in my project (which is obviously too tiny for Kint  😆). I am pleasantly surprised by the way Kint has grown over the years, especially the helpers and plugins - Wow!!!
I noticed that there is a JSON parser plugin, which I want to use as I debug my script.
Here's a weird question, which I couldn't answer after scouring the docs... "How are plugins used?" The docs show how to use the helper functions, but not the plugins. For parsers, do they automatically detect?
I feel it will help newcomers if there was an example of the usage of a parser (except for the one-line mention of the Blacklist plugin in the README.
Again, Kint is awesome! My sincere thanks to the developers :-)

Most of the kint-specific 1.x features were moved to plugins in 2.x, and the JSON plugin is actually on by default: if kint encounters a (valid) json string it'll parse it for you (And give you the full expression needed to access specific subitems etc.)
You're right that I apparently forgot to mention how to enable them in the docs, I'll fix that now (Short version: Add the plugin classname or instance to Kint::$plugins)

Most of the kint-specific 1.x features were moved to plugins in 2.x, and the JSON plugin is actually on by default: if kint encounters a (valid) json string it'll parse it for you (And give you the full expression needed to access specific subitems etc.)
You're right that I apparently forgot to mention how to enable them in the docs, I'll fix that now (Short version: Add the plugin classname or instance to Kint::$plugins)

OK, this is just awesome! Firstly thanks for the lightning fast response. Secondly, I'm blown away by the fact that it can auto-detect. However I'm a bit lost, that it isn't doing that. I'm on pure CLI. Do I need to do anything different?

@viharm Yeah most plugins are disabled on CLI - most of it results in multiple different representations of data, for instance you may want to see the JSON unfolded, or you may want to just see the string. You may want to see the exception properties, or you may want to see the stack trace. You might want to see the contents of a SimpleXMLElement or you might want to see the attributes.
Lots of features like that fit into tabs under a single value when you're in the rich HTML view, but if you were to just list them all one after the other in plain text it becomes an impenetrable mess. Take a look at the live demo on the site handles json/colors/tables and then imagine all those tabs (With often duplicate information) being dumped at once and you'll see why plaintext only renders the "Main" value
If you look at TextRenderer you can see the only interesting plugins enabled are the microtime() debug_backtrace() and stream resource ones

@jnvsor , thanks very much for your patient explanation. I understand (& agree with) the approach used. And yes, Kint has indeed come a long way. Unfortunately I am unable to write a plugin to augment the heirarchical JSON output due to time constraints, so will resort to decoding the JSON string, and then dumping it with Kint (I may write something later and suggest a change). Thanks again to the entire team for the hard work.

class JsonValuePlugin extends Kint\Parser\Plugin
{
    public function getTypes(): array
    {
        return ['string'];
    }

    public function getTriggers(): int
    {
        return Parser::TRIGGER_SUCCESS;
    }

    public function parse(&$var, Kint\Zval\Value &$o, int $trigger)
    {
        if ($r = $o->getRepresentation('json')) {
            $o->value = $r;
        }
    }
}

That should do the trick (Not tested at all though)


VODs from this channel do not play

Hi   I am on 0.5.1and tried Chrome and Edge, this was "broken" on 2 consecutive previous releases as well.
Wondering what makes this channel "special"
www.twitch.tv/evah_hhhh

tested right now, works like a charm


Clean b* themes

Description
Clean and lint b* themes
Motivation and Context
https://github.com/Bash-it/bash-it/issues/1696
How Has This Been Tested?
Tested all themes before and after changes.
1 error was detected, resulting in an other PR: https://github.com/Bash-it/bash-it/pull/1789
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[x] I have added tests to cover my changes, and all the new and existing tests pass.

@cornfeedhobo made a good argument in https://github.com/Bash-it/bash-it/pull/1791#issuecomment-761887204, we should not change the code for COMPREPLY array when we know that the string used is safe.
The warning is now disabled only for the appropriate lines.

@cornfeedhobo made a good argument in https://github.com/Bash-it/bash-it/pull/1791#issuecomment-761887204, we should not change the code for COMPREPLY array when we know that the string used is safe.
The warning is now disabled only for the appropriate lines.


Renaming this feature.

Can I just point out I've google urine about 100 times in my last sprint, now everyone's gotta pee, but really?

Grow up

No seriously, have you tried googling autosuggest for this?

Common cheer up, it's kinda funny and it really does autosuggest it if you're concentrating.

I mean this is a great feature, but axboe !== urine - just saying.

FYI I've now diverted accidental autocorrect searches to this repo for innocent developers who just wanted faster IO.

If I google liburing or io_uring, google doesn't suggest anything else and there's no auto suggest that's different.
The name isn't being changed, sorry.

It's not that exact search one sec, I'm actually being a div here.

So it's where you don't use the _ and do io urin and hit enter, common mate it's a joke really, but there's literally 3 of us that keep hitting urine. It was meant to be funny not insult you.

I'll refrain from making the logo red, at least.

If you've got red urine we've got bigger problems than naming conventions!


"KeyError: vicinity"

Thank you for this module!
I have a question.
populartimes.get(“”,[“*”],(,), (,)) is usually executed.
However, depending on the range of the bounding box, an error "KeyError: vicinity" as in the figure.
Can you please tell me the cause of this error, and how to resolve it?

Hey, can you provide the place id from where the error occured? Generally each place should have the vicinity / shortened address, otherwise getting the populartimes data doesn't work.

Thank you for your reply.
Sorry,I don't know exactly which facilities.
When I specify the following range, I'll get a "vicinity" error.
populartimes.get("api_key",["*"],(22.3185,114.160), (22.340,114.161))

Seems like the result contains a whole district, which doesn't have a useable address. The error should now be resolved (if not please reopen this issue).
I'd highly suggest you add a type identifier instead of * to the request. Otherwise you process a large amount of places that probably have no use to you (like the district case above which still counts towards your quota), don't contain the populartimes data anyways and the google maps api can be very costly in some cases. Especially when the nearby endpoint has to be used and areas are very dense.


windows配置

请问windows下好运行吗，具体命令改如何配置呢

@s597735 I tried with Windows alone but took way too long to change all the libraries (and other issues). Much faster to just setup WSL -2 Ubuntu (22.04) (version that the authors have used). "Linux in windows" basically.
https://medium.com/@pintzprajapati/install-wsl-linux-ubuntu-on-windows-10-11-windows-subsystem-for-linux-891b6191c8fe
Run a command at the end to check if everything is fine. You should be promted to set a username and password at the end.
After that I set up the WSL on VS Code and I clone the repo.
https://learn.microsoft.com/en-us/windows/wsl/tutorials/wsl-vscode
Issues that I had:

Had to update windows until I could install WSL
make sure to have anaconda navigator installed on windows itself but save conda on Ubuntu itself, so that when you run the .yml file it goes into Ubuntu

I am still having issues, error in code due to running it with an rtx 2060

我最后也使用了wsl2但装的ubuntu24，可是最后的total score很低，只有0.12，也不知道哪里出了问题


Unexpect result,while pass array params or struct type to the windows dll using (syscall  NewLazyDLL  NewProc)

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7beta1 windows/386
What operating system and processor architecture are you using (go env)?
`set GOARCH=386
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=386
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\gopath
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_386
set CC=gcc
set GOGCCFLAGS=-m32 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\dell
\AppData\Local\Temp\go-build778175466=/tmp/go-build -gno-record-gcc-switches
set CXX=g++
set CGO_ENABLED=1
`
What did you do?
package main

import (
	"fmt"
	"syscall"
	"unsafe"
)

var (
	dll       = syscall.NewLazyDLL("abc.dll")

	proc_add  = dll.NewProc ("myadd")
	proc_aadd = dll.NewProc("foo")
)

func add(x, y int) int {
	r, _, _ := proc_add.Call(uintptr(x), uintptr(y))
	return int(r)
}

func foo(x *byte) uintptr {
	r, r2, e := proc_aadd.Call(uintptr(unsafe.Pointer(x)))
	fmt.Println(r, r2, e)
	return r
}

func main() {
	a := make([]byte, 3)
	a[0] = 20
	fmt.Println(add(6, 11))       // int type ,-----as expected ,out put 17
	fmt.Println(byte(foo(&a[0]))) //byte array ----------not  as expected--failed
}

this is the add.dll  src:   delphi 7.0
library abc;

{$R *.res}

function myadd(a,b:integer):integer;stdcall;
begin
  result:=a+b;
end;

function foo(m:byte):byte;stdcall;
begin
  result:=m
end;

exports myadd,foo;

begin
end.

What did you expect to see?
should like this:
//17
//20 303447572 The operation completed successfully.
//20
What did you see instead?
but:
//------------------------result-------------------
//17
//22 303447572 The operation completed successfully.
//22
`
or other random number

here is the src file ,please help me ,thank  you
testdll.zip

it seems you're asking a question.
Please seek helps using other mediums as the issue tracker is for bug
reports and proposals.
See https://golang.org/wiki/Questions.
Does "function foo(m:byte):byte;stdcall;" really take a pointer as argument?

thanks for your proposal.
this is my first time asking for help in github.com
in fact,I am using a third party dll,which  really take a pointer as argument,but i cant get the result expected.
but the document for "syscall NewLazyDLL NewProc" is very pool.
Do you know where can i find some example? thank you .@minux

Does "function foo(m:byte):byte;stdcall;" really take a pointer as argument?

It does not. There are two ways to pass pointer as parameter:
function foo(var m:byte):byte;stdcall;
begin
  result:=m
end;

or literally
type pbyte = ^byte;

function foo(m:pbyte):byte;stdcall;
begin
  result:=m^
end;

Alex

yes,it works well,Thanks you.  Sorry to interrupt.  Alex.


Alert is closed only if contains "show" class

See https://github.com/thednp/bootstrap.native/blob/master/src/components/alert-native.js#L49
I don't understand why there's a check for a "show" class.
Moreover, I can't find a mention for such class in docs

Some checks have to be in place to prevent triggering events when not make sense.

I see, but don't you think that such additions should be highlighted I documentation?

The .close() method should only work when alert is present in the DOM and visible to the user. Period.
This thing does exactly the same.
https://github.com/twbs/bootstrap/blob/main/js/src/alert.js#L58-L60

The .close() method should only work when alert is present in the DOM and visible to the user. Period.

The point is that alert can be visible to the user even when "show" class is not present.

This thing does exactly the same.
https://github.com/twbs/bootstrap/blob/main/js/src/alert.js#L58-L60

Indeed, Boostrap does not require any "show" class to close an alert.
This issue is just the result of struggling with an alert not closing until I realized this strange requirement.

The point is that alert can be visible to the user even when "show" class is not present.

That is indeed not bootstrap.

That is indeed not bootstrap.

Well, it's you that mentioned "this thing does exactly the same" (by linking bootstrap source)
Anyway, my question stands: don't you think that documentation should report such requirement?

No I mean THIS IS NOT BOOTSTRAP

The point is that alert can be visible to the user even when "show" class is not present.

The original bootstrap component only considers that checking presence of the element in the DOM is enough to prevent execution. My original concern was to prevent the transitionend event from never executing because there was no "show" class to remove and enable the transition. I think this behavior is more healthy for production websites.
Meanwhile I got busy with other stuff, don't afford the time to check every line of JS to write docs, so take it as is.

Well. I see that you care enough to explain that differences exist with Boostrap, and that "for each component these details are fully explained" (written in the FAQs).
I guess that this is a difference it's worth mentioning, for all newcomers.

I said clearly "it's not a perfect drop-in replacement", should I make it bold?
Also this from the FAQs.
Very loud and clear.

I said clearly "it's not a perfect drop-in replacement", should I make it bold?

I never questioned it.
My only concern is how easy is supposed to be such replacement process.
If you agree that this case is worth to be mentioned in docs, I can propose a PR.

Might worth a try, why not.


Playlists support for pinballX frontend

Add playlist management for pinballX

added management of playlist by activate supportPlaylist for pinballX frontend
Implemented load / save of pinballX playlists and favs
concept of fav is  much simpler : a global favorite flag, not linked to playlist. So introduced supportPlaylistExtended in FrontendType to bifurcate between the simple mode of pinballX (false), and the complex one of popper (true)
supportPlaylistExtended = false  basically deactivates the local / global flag per playlist. Favorites playlist is just like any other playlist with no game played restriction
added an optional emulatorId (always null for popper as not set and always not null for pinballX). And when it is set, a game from another emulator cannot be put in the playlist (checkbox disabled)

Fixed with 3.5.0


Multiple selections of nodes are not possible

I missing the key feature of the jstree: selection of multiple nodes in hierarchy eg:
| tree1
| child1
| *child2
| *tree2
Where the * is selected node. This can be made in https://www.jstree.com front page, even with checkbox plugin. But in ngJsTree it is not possible, e.g. in the example http://ezraroi.github.io/ngJsTree/. Or i miss something?

Well i missed something. Its the config:
multiple: true,


[main][feat] Automated Vaults Repurchase

Description
New version of DeltaNeutralVault that allow repurchase process.
Why?
To reduce price impact during rebalancing.
ChangeLogs:

two new strats specific for repurchase
delta04.repurchase()
test files

Link to story (if available)

Repurchase should limit to EOA only.


Bullet: Compound Shape Collision Fix

Background:
Kinematic body collisions resolved with the bullet physics space add together penetration recovery vectors from all shape collisions. The issue is that multiple shapes with the same penetration recovery vector push a kinematic body multiple times when only one push was required. The issue is outlined nicely in this post to the bullet forum in 2014: https://pybullet.org/Bullet/phpBB3/viewtopic.php?t=10843

(taken from the bullet forum post from user: Enhex)
FIX:
This fix is to offset the collision shape by the recovery vector before detecting penetration so that repeat pushes are not detected. The change reverses the lines in this commit which added compound collision support:
https://github.com/godotengine/godot/commit/6dd65c0d67960b0f0b26a24bd2f10fe8d54aa37a#diff-28f7bca21ebbe699cd16802c05d43f4e085331c7d0427c38da0ab3e6d14dc696L1186
https://github.com/godotengine/godot/commit/6dd65c0d67960b0f0b26a24bd2f10fe8d54aa37a#diff-28f7bca21ebbe699cd16802c05d43f4e085331c7d0427c38da0ab3e6d14dc696L1217
I admit i have no idea the consequences for such a change but i assume they should be confined to KinematicBody.
This hopefully fixes a lot of bullet physics jitter issues seen here (from @pouleyKetchoupp bullet issue tracker):
https://github.com/godotengine/godot/issues/29392
https://github.com/godotengine/godot/issues/34596
Test without fix:
https://user-images.githubusercontent.com/44295008/149598368-6af0bd87-e6bd-4c08-bf1f-73acfb651913.mp4
Test with fix:
https://user-images.githubusercontent.com/44295008/149598382-a0e866c1-e75e-4139-8845-d57f21cbd913.mp4
Bugsquad edit:

Fixes https://github.com/godotengine/godot/issues/28438
Fixes https://github.com/godotengine/godot/issues/29392
Fixes https://github.com/godotengine/godot/issues/34436
Fixes https://github.com/godotengine/godot/issues/34596
Fixes https://github.com/godotengine/godot/issues/35713
Fixes https://github.com/godotengine/godot/issues/35780

Could you provide a test project that demonstrates the bug and can be used to confirm the fix?
It would then also be interesting to see how it behaves with GodotPhysics.

@akien-mga
This test demonstrates the bug. It walks two kinematic bodies towards two static body walls. One wall has 1 collision shape and the other has 4 shapes. On 3.4.2 with Bullet physics the kinematic body that collides with the 4 shape wall will jitter while the other wont.
This demonstration shows this issue isnt present in GodotPhysics.
Running this demonstration with this patch the bullet behavior should match the correct GodotPhysics behavior.
test.zip

Sorry for the delay. We've removed the Bullet backend in master since it was disabled for more than a year, and that our aim for 4.0 is to have it provided as a GDExtension plugin instead of built-in.
It's still used in 3.x and this PR seems relevant to merge there, could you redo it against the 3.x branch?

Sorry for the delay. We've removed the Bullet backend in master since it was disabled for more than a year, and our aim for 4.0 is to have it provided as a GDExtension plugin instead of built-in.
It's still used in 3.x and this PR seems relevant to merge there, could you redo it against the 3.x branch?

Sure thing.
Does that require making a new PR against 3.x or can I change this one?
Also I'm very glad we are still supporting Bullet for now :)

It might be easiest to make a new PR targeting the 3.x branch. Otherwise you can indeed change the base branch for this PR as you had attempted (which then tries to merge master + your commit on 3.x, hence a ton of commits), and then you need to force push an update with the commit on top of your local 3.x branch.

Now it should be good to merge, sorry for the delay :)

Thanks so much for your help getting this merged. :))

The change reverses the lines in this commit which added compound collision support:
https://github.com/godotengine/godot/commit/6dd65c0d67960b0f0b26a24bd2f10fe8d54aa37a#diff-28f7bca21ebbe699cd16802c05d43f4e085331c7d0427c38da0ab3e6d14dc696L1186
https://github.com/godotengine/godot/commit/6dd65c0d67960b0f0b26a24bd2f10fe8d54aa37a#diff-28f7bca21ebbe699cd16802c05d43f4e085331c7d0427c38da0ab3e6d14dc696L1217

This is worth highlight for review. This change was done in #27415 together with a lot of other fixes, but I don't see it discussed specifically. @madmiraal did identify this PR as the cause for some of the regressions linked below (https://github.com/godotengine/godot/issues/34596#issuecomment-575632933).

This hopefully fixes a lot of bullet physics jitter issues seen here (from @pouleyKetchoupp bullet issue tracker):
https://github.com/godotengine/godot/issues/29392
https://github.com/godotengine/godot/issues/34596

I tested the MRPs from those two issues respectively in 3.5 RC 1 and this PR and confirmed that this PR fixes them :+1:

#34596: Does seem to be a regression from #27415 which removed those two lines.
#29392: Actually predates #27415 (merged in 3.2 and this is reported against 3.1), but there seems to have been a bug introduced in 3.1 that affected both GodotPhysics and Bullet. This was fixed in #40377 but it was found to only solve the bug for GodotPhysics, despite being implemented in KinematicBody itself - this was likely due to the #27415 change that is being reverted here.

This also seems to fix the following issues which are linked in the above issues or reference #27415:

#28438.
#35780.

There might be more, still testing. I'll update when I've reviewed everything I can find.
Some other related issues which do not seem fixed as of this PR (no change):

#32182: Tested all 3 MRPs linked in that issue.

These might warrant further debugging and might not be related to the 3.1 and 3.2 regressions discussed above.

Thanks a lot, this was a long awaited fix!

I found one issue where behavior seems to have regressed with this fix: #36334.
With the MRP in that issue, enabling "Sync To Physics" on the moving KinematicBody platform as suggested, there's now back and forth on is_on_floor when the platform is moving upwards by being animated.
Here's the updated MRP from that issue which prints is_on_floor(): moving_platform.zip

https://github.com/godotengine/godot/issues/35780 is still not fixed if the KinemeticBody is moving slow enough, it'll get stuck on gaps in gridmaps (both ground and wall colliders).


I having problems to show a custom screen from Microsoft.Identity.Client using CustomTabs

Xamarin.Android Version: 8.0
Operating System & Version : Microsoft Windows [Version 10.0.14393]
Support Libraries Version : API Level 21 Lollipop
Describe your Issue:
An application to connect to Azure using AD to B2C authentication, is using the  Microsoft.Identity.Client, and the version that is working is Custom Tabs 23.3, but when I tried to install through Nudget Microsoft.Identity.Client, this installs version Custom Tabs 26.x.
And when I run the code, it throws  the following error,
12-06 02:09:42.177 D/ViewRootImpl@ec13238MainActivity: MSG_WINDOW_FOCUS_CHANGED 0
12-06 02:09:42.181 D/InputMethodManager( 6553): HSI from window - flag : 0 Pid : 6553
12-06 02:09:42.225 V/ActivityThread( 6553): performLaunchActivity: mActivityCurrentConfig={0 1.0 themeSeq = 0 showBtnBg = 0 311mcc480mnc [en_US] ldltr sw360dp w360dp h668dp 480dpi nrml long port ?dc finger -keyb/v/h -nav/h mkbd/h desktop/d s.53}
12-06 02:09:42.251 D/Mono    ( 6553): Assembly Ref addref Microsoft.Identity.Client[0xdcdc2e80] -> Xamarin.Android.Support.CustomTabs[0xdc48d560]: 2
12-06 02:09:42.270 D/Mono    ( 6553): DllImport searching in: '__Internal' ('(null)').
12-06 02:09:42.270 D/Mono    ( 6553): Searching for 'java_interop_jnienv_get_object_field'.
12-06 02:09:42.270 D/Mono    ( 6553): Probing 'java_interop_jnienv_get_object_field'.
12-06 02:09:42.270 D/Mono    ( 6553): Found as 'java_interop_jnienv_get_object_field'.
An unhandled exception occured.
Steps to Reproduce (with link to sample solution if possible):
Run this code
AuthenticationResult ar = await App.PCA.AcquireTokenAsync(App.Scopes, GetUserByPolicy(App.PCA.Users, App.PolicySignUpSignIn), App.UiParent);

Do you have a reproducible solution you could share as well as more context around the logs (perhaps the full adb logcat output could help)?  Also, have you tried contacting the owners of Microsoft.Identity.Client? Sounds like it could be an issue with their library's compatibility.

No response since dec 2017


Remove nbdev dependency

What does this PR do?
This PR is a follow-up PR of https://github.com/lvwerra/trl/pull/50 - it is an attempt to remove the nbdev dependency from trl
This PR also adds a patch to support the latest version of transformers
Draft for now as I have to figure out how to deal with the documentation
For now testing that everything works with python examples/04-ppo-sentiment.py
cc @lvwerra

Moved all images inside the org https://huggingface.co/trl-internal-testing and fixed all image links on README + notebooks with the correct ones
Also as discussed, I removed the 3 first notebooks ;) Let me know what is missing here!

Seems not possible https://stackoverflow.com/questions/66587174/how-to-remove-generated-from-tag

Thanks for the review!
I should have removed the CI, done the renaming of the files ;-)


Cannot change World Name

Currently using OpenTerrainGenerator-1.10.2-v21 already have my custom type config-ed and everything but when creating single player worlds i cannot change the world name it keeps it at the name of my generator.

Same issue in 1.12.2

Hey there, this is intentional, the world name must be the same as the name of your configs directory (aka the name of your preset in the world creation menu). You can clone a preset to create a world with a different name. Sorry for the inconvenience, this may seem clunky and annoying but it actually prevents far bigger problems.


bot for refreezing

Proposed change

Every once in a while, we want to rebuild the base environments. This is done by running the freeze.py script in the conda buildpack.
Alternative options

keep manually refreezing
Who would use this feature?

Maintainers of repo2docker and folks contributing updates to the base environments who don't want to run refreeze themselves.
One way is to do periodic refreeze, to keep things up to date, as is done with henchbot. Another is to allow pull requests to update the environment spec or other files and then post a comment like @r2d-bot please refreeze.
How much effort will adding it take?

Not sure! Hopefully not too much. Requires writing a bot that talks to the GitHub API. It would need to:

respond to a trigger somehow (e.g. a @refreeze-bot please refreeze comment to update a PR or a new please refreeze Issue to trigger a new PR)
make a commit in an existing pull request and/or open a new pull request

Who can do this work?

Interest in / knowledge of the GitHub API
Interest in / knowledge of writing bots and deploying them somewhere (on heroku, etc.)

References:

henchbot which does pull requests for updates to repo2docker and binderhub for mybinder.org
conda-forge-admin bot which does things like add commits to pull requests to run common commands like @conda-forge-admin please rerender

I'd be happy to take this up, I've been wanting to get more into repo2docker but hadn't found a good entry point yet.
I don't see a "refreeze.py" just "freeze py" in the conda and legancy buildpacks. Am I missing something?
Also, does this depend on builds existing outside of the state of the GitHub repo? One of the reasons henchbot just goes every hour is because the images maybe hadn't made it to Dockerhub yet, so it checks there specifically.

I think it is a typo. freeze.py is what we use to (re)freeze the environments.
I think it uses a miniconda docker image so we shouldn't have the problem where we needto wait for an image to build.

Am I missing something?

@betatim is right. I updated the description: We only want to run freeze.py in the conda buildpack. This will regenerate the eight environment.pyX.Y[.frozen].yml files.

does this depend on builds existing outside of the state of the GitHub repo?

Depends, but mostly no in that there's nothing outside to check. There's no outside event to "check if things are up-to-date", since it's all the packages. If we're doing periodic checks, we should maybe perform a diff of the resulting yaml files (the parsed data, not the bytes on disk), though, because the files will change with the Generated on <DATE> comment, even if the content doesn't change.
Unlike mybinder.org, we don't want this to be constantly updating (a PR for every tiny change would be overkill). Rather, prompting to keep it up-to-date every one, two, or even four weeks.
More useful, I think, will be the bot adding the freeze commit to an existing PR, e.g. one that bumps a dependency in environment.yml, letting the bot do the freezing step. See the two commits in https://github.com/jupyter/repo2docker/pull/354. For the workflow I have in mind, see this PR on conda-forge where there's one commit by hand changing the input, then a second commit from a bot to regenerate derivative files.

Thanks @minrk ! I will start some work on it this week.

So I've been working on this when I get the chance. The bot can run the freeze and create the PR, I'm still working on the PR text.
My next step question will be if anyone knows how we can run this in an environment that has the required Docker? Can Heroku do this? @betatim  ?

I don't think on heroku you can access a docker daemon :-/

Is this still open? If so I would love to give it a go with some Github actions stuff

I think it is!

Cool, so I got a decent start on this - been trying on a repo of my own as I am testing with the PRs and comments.
As I am working  this is the workflow I have come up with based on @minrk description/references:

Someone submits a PR to repo2docker (change environment.yaml for the conda buildpack)
Someone uses trigger work in the PR comments to refreeze based on the changes above (only works if the path  repo2docker/buildpacks/conda has committed changes
Bot commits the newly generated files (or rather updated from the freeze) on top of the PR

I do have some questions:

For step 2 do you want to allow anyone to be able to run the command?
Also, do you want the bot to add a comment with the outcome of the freeze or something similar?
Do you have any preference regarding the format or message for the bot?

For step 2 do you want to allow anyone to be able to run the command?

Can it be anyone with write access to the PR branch (i.e. author + repo maintainers)?

Also, do you want the bot to add a comment with the outcome of the freeze or something similar?

Maybe only on fail with error messages? At the start, at least, a confirmation message that it has received the request and begun the process might be good, but I suspect we won't want this message once it's running reliably.

Do you have any preference regarding the format or message for the bot?

How about @bot please refreeze?

In https://github.com/jupyterhub/repo2docker/pull/958 (WIP) I've got an update.py script that automatically updates one or more dependencies in environment.yml to the latest on conda-forge. I've been playing around with GitHub workflows to try and automate the freeze.py (mostly for my personal curiosity), but if it's useful feel free to take the script.

Right, I was working on this - and got then forgotten as I went on annual leave and been swamped with JupyterCon stuff.
Anyway, I have a working MVP (had to create a separate repo to enable actions though).  Example here. The one piece missing is pushing the refreezed yaml files to the PR head instead of master.
Which I can do on Friday as it's my meeting-free day.
Would it be then suitable for adopting @manicsupdate.py for the dependencies update?

Since your bot is almost ready let's keep that as it is, and after it's merged I'll look at adding my script to it.

righto - will finish this and then we can see how to integrate both 😄

@trallard How are you getting on? I just discovered this GitHub Action: https://github.com/marketplace/actions/create-pull-request
If it works as described you just need to generate the updated files and it should automatically take care of opening the PR

Sorry folks I was swamped with JupyterCon tasks and then with work.
I was having troubles finding the correct reference for the PR and to allow gh actions to add a commit to the PR itself. And could for my life not find something in the docs or the GH actions developer forum. I finally found a way to go around this and should have some time this week to finish off and send the finalised PR. I am so sorry for taking this long but my workload has been a nightmare this year

No need to apologise! I only commented because I just discovered that action, and thought it might be useful if you hadn't reached that stage 😀.

For anyone who is looking at picking this up, https://peterevans.dev/posts/github-actions-how-to-automate-code-formatting-in-pull-requests/ seems to show pushing git changes after a run. I think the default token has push access, but it's a little unclear if it would have access to push to a PR from itself. Seems like the answer is probably. But if it's a cron action, it should have push access.
I was thinking maybe a comment-trigger might be useful, too (e.g. @github-actions please refreeze).

I don't think the token has push access to a PR unless the PR is from a branch in the same fork, which in general isn't the case. Your suggestion of doing it with cron should be good enough, though you may run into the problem of GitHub workflows not being triggered by a push from the default token which means either manually closing/reopening a refreeze PR to force the CI run, or using a secret token instead of the default.


local k3s cluster should not be upgradable in Rancher single install mode

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

run rancher:v2.5.0, single install
edit the local cluster, and there are new k3s version available in the dropdown list

choose a newer version and upgrade

Result:
The local cluster starts the upgrading process which will never finish

Expected Result:
We do not support upgrading the local k3s cluster in a rancher single-install setup.

joy
send one unvalidated byte and the system will crash
scream

This is not an issue in v2.4.x in the docker-install mode

The bugfix is validated on rancher:v2.5-7a10a58973a03121a49f8f4efb1f52292a446b7d-head, docker install
Now there is no upgrade option for the local cluster on the edit page

reopen to wait for the fix available in master-head

Just merged in master.

The bugfix is validated in rancher:master-35e2ab8aad5a06f89c4dde7daeb8ca179c27ae77-head
No upgrade option for the local cluster in docker-install mode.

i hit this bug, may i know the solution to stop upgrading the local cluster ?

@alexfok007 In rancher 2.5.1 it's not possible to hide this but it will be fixed in 2.5.2. In 2.5.1 you might get away with changing the local clusters driver setting to "local" but that isn't tested and it might not stick.

I encountered this issue in single node docker install v2.5.7. Any options to fix besides upgrading to 2.5.8 which is not stable yet?

@cbron This is still an issue, 2.5.7 shows multiple versions you can upgrade a docker run local cluster to.

@dramich we are attempting to fix via UI now. I'm going to close this and re-open: https://github.com/rancher/rancher/issues/30977

Potential fix if you do happen to update your cluster and it gets into a weird waffling state, try editing the cluster's k3sConfig k8s version back to what it was.

My cluster is stuck in upgrading.
Can I somehow revert it to the version that works? I'm guessing that it is persisted somewhere in the k3s cluster, but can't find it.


”Batoș” is listed in the drop-down menu

Description:
"Batoș" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Batoș" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Batoș, MUREȘ".


Multiple Scrollable elements on single page

Many webapps like WhatsApp Web or Facebook Messenger have multiple scrollbar elements on a single page typically there is a left pane with user list and there is a centre pane where all the messages and chats of that user are listed.
I would like to get a scrolling screenshot of the chat scrollable element, but it seems the extension tends to take only the user pane screen shot and then stop.
Is it possible to select the which scrollable element to screenshot?

Bump for this. In these cases, I have had to resort to zooming out really small so the entire page is visible on the screen (the part of the page that doesn't get scrolled by the extension), which kills the resolution. Strangely, I noticed that with different links of the same website (which have the same 2 scrollable elements in the same exact location/setup), sometimes the part of the page that didn't get scrolled before does get scrolled by the extension as I desired. I couldn't see a pattern in when one of the scrollable elements gets scrolled rather than the other. I see this issue hasn't been addressed since first submitted in January but I thought I'd chime in.

Bump for this. In these cases, I have had to resort to zooming out really small so the entire page is visible on the screen (the part of the page that doesn't get scrolled by the extension), which kills the resolution. Strangely, I noticed that with different links of the same website (which have the same 2 scrollable elements in the same exact location/setup), sometimes the part of the page that didn't get scrolled before does get scrolled by the extension as I desired. I couldn't see a pattern in when one of the scrollable elements gets scrolled rather than the other. I see this issue hasn't been addressed since first submitted in January but I thought I'd chime in.

Same for me
I want the red area, but the area on the left side is scrolled and captured.


Implement OCI container bootstrapping ADR (Ireland)

🚀 Feature Request
Relevant Package
Affects most of the EdgeX framework
Description
Implement the OCI container bootstrapping ADR as detailed in the PR for https://github.com/edgexfoundry/edgex-docs/issues/133
Describe the solution you'd like
See ADR
Describe alternatives you've considered
See ADR

Closed as invalid -- has been broken down into sub-issues.


Fixed parameter type hint for iterator_to_array, iterator_count and iterator_apply functions

See https://3v4l.org/enE8p

Thanks a lot for all your contributions!

@andrey-sokolov You're welcome.
I hope new release of JetBrains/phpstorm-stubs will be soon :)


docu:typo-fix-in-gateway.md

Type of change

Documentation update

Description
By referring the issues no #3271
fixes the typo mistake in "Have"--->> "Having"
fix issue #3271
Additional details
Step to resolved issue
Go to website
clickhere
Screenshot :-

Here  i am solved that issue #3271

This way my first contribution to open source project where I am trying to solved that basic issue 🙂

Thank you @PratikKhaire !
The change itself looks really good.
The only additional thing that needs to be done is that you need to sign your commit in order for the DCO check to pass. See instructions at https://github.com/hyperledger/fabric/pull/4310/checks?check_run_id=14876318045