[GMW]: Events BROImport

Ideally all events from a GMW should be added to the gmw/events/ endpoint on import.
The import script should be extended to accomplish this.

Dependent on #150


"MAC IP:PORT" is confusing

Within the "Ports" section of settings the published IP and Port are listed under the "MAC IP:PORT" heading - is there a reason for this? It can be confusing for Windows and Linux users.
Would it not make more sense to have the heading shown as "PUBLISHED IP:PORT", or something similar?

MAC stands for Media Access Control - not the OSX Mac :)
https://en.wikipedia.org/wiki/Media_access_control
However, I'm not opposed to the wording change.


Optimized Rest Parameter -> Spread Operator

Previously, when a rest parameter was referenced with a spread operator, the transformed code would pack and unpack it:
function foo(this: void, ...args: unknown[]) {
    console.log(...args);
}

=>
function foo(...)
    local args = ({...})
    print(unpack(args))
end

This PR optimizes this so that the elipsis operator is used instead. It also prevents generation of the temp local if it is not needed in the function.
function foo(...)
    print(...)
end

This optimization shouldn't be applied if it's used in the inner function:
function foo(...a: any[]) {
    function bar() {
        print(...a);
    }
}

function foo(self, ...)
    local function bar(self)
        print(...)
    end
end

3: cannot use '...' outside a vararg function near '...'

It also shouldn't optimize it in try-catch
function foo(...a: any[]) {
    try {
        print(...a);
    } catch {}
}

and expressions that require IIFE
function foo(...a: any[]) {
    const _ = (0, print(...a));
}

closing to open as a fresh PR since it's changed so radically


Proper EMBA integration

User story

As a developer
I want to script/setup to independently clone emba
In order to make persisting changes on the original EMBA Projekt and keep everything tidy.

Acceptance criteria

Cloning and integrating of emba in embark to get the docker running
Script running atleast on Linux

Definition of done

Code review from peers has been completed and passed

Code is fully implemented and commented
Adheres to coding guidelines
Commits are not squashed
Code is checked into the repository

Unit tests for backend have been written and are passing
Manual performance tests on the browser are passing
No critical bugs are open

Deleted code that was copy-pasted from emba repo while setting up docker
Make a directory emba and clone repo everytime before setting emark up
Update Dockerfile to get installer.sh from inside this emba directory

Merged and done on 28.04.2021


Simple API Classes

We're going to reorganize the repository a bit:

Push current classes into core/
Make a new set of artifact classes in api/
The artifact classes will have reduced methods AND include the transforms()
Super Nice Documentation

Okay, the first revision of the api classes is done and documented. There will be additional modifications going forward but we'll make new tickets for those


Extension debugging has regressed significantly recently

Version: 1.79.0-insider
Commit: 784e72bc4486b7ea5ad3447c506e31d949848592
Date: 2023-05-30T05:20:59.861Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.79.0-insider Chrome/108.0.5359.215 Electron/22.5.4 Safari/537.36
Unfortunately, it's hard to pin this down to a set of steps, but I've (along with other fellow dev) have been experiencing an array of regressions that I believe have started in 1.79.
Here are some of the symptoms:

Stop button stops working or takes a VERY long time -- often seems to get stuck on Webviews, but sometimes it won't even stop but the call stack view shows nothing.
Stop button sometimes actually kills the debugger window -- just disappears, but leave the debuggee open
Restart button often works the first or second time, but then stops
Breakpoint sometimes fail to be hit (and require a VS Code restart), but replacing with a debugger; call works
Variable hovers sometimes fail to show values, and sometimes show the editor hover rather than variables

Some of these issues feel like things we had in the past (like 6-9mo ago) and feel like that are back.
It definitely feels like webview debugging makes things worse.
Also in today's insiders, additional issues with when starting debugging that kicks off the default build task, sometimes it now shows a task picker, rather than just running the default task -- and a VS Code restart fixes it. And it usually starts after stopping a debugging session.

Hey @eamodio 👋 , thanks for the issue. I think that if you can grab a log with "trace": true in your launch config for any of these, it would help us understand whether anything is happening on the debug extension's end. @connor4312 any of these sound familiar to you?

Variable hovers sometimes fail to show values, and sometimes show the editor hover rather than variables

We had a change recently that if there is no debug hover available, then we fall back to showing the editor hover instead. I'd appreciate if you can find a specific example so we can see whether vscode is doing the wrong thing. I think that it is sometimes counterintuitive when the debugger doesn't have hover info for a variable, which can make this look broken.

when starting debugging that kicks off the default build task, sometimes it now shows a task picker, rather than just running the default task

This sounds a bit like https://github.com/microsoft/vscode/issues/173184, and @meganrogge I think I have seen that issue repro, once in a rare while, since the linked issue has been marked fixed. Are you aware of anything else remaining that is related to this?

This sounds a bit like https://github.com/microsoft/vscode/issues/173184, and @meganrogge I think I have seen that issue repro, once in a rare while, since the linked issue has been marked fixed. Are you aware of anything else remaining that is related to this?

I am not aware of anything else related to this. It should've improved this iteration. I would guess it is related to some extension taking awhile, though we've now put several mechanisms in place to prevent that from impacting performance. 🤷🏼♀ . Pls lmk if you have repro steps

I was able to repro it and I opened https://github.com/microsoft/vscode/issues/183989. What's discussed here is a bit different because this is about the debugger trying to kick off the task, but I would bet that they are somehow related.

Variable hovers sometimes fail to show values

Sounds like it could be due to renames on the tooling side of whatever is building the extension. Back in January I reverted some 'improvements' to sourcemap renames that had broken things in some scenarios. There is strong desire to improve renames in the upcoming sourcemap v4 spec.
At least debugger side hovering is quite a straightfoward call of "evaluate $name in the current context", and is not an area we've had bugs with before, which strongly indicates a tooling side thing to me.

Stop button stops working or takes a VERY long time -- often seems to get stuck on Webviews, but sometimes it won't even stop but the call stack view shows nothing... Stop button sometimes actually kills the debugger window -- just disappears, but leave the debuggee open... Restart button often works the first or second time, but then stops

Sound like possible lifecycle issues. There were some fixes made here recently, perhaps something isn't quite working with webview debugging. I'll look into it during debt week.

Breakpoint sometimes fail to be hit (and require a VS Code restart), but replacing with a debugger; call works

Seems unrelated to these other problems, a specific repro and/or trace logs would be helpful.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Release branching workflow revisions

Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
These changes are part of revisions to #56 changes to merge release changes to a release branch before creating the release: https://github.com/devfile/api/issues/1267#issuecomment-1792837116
In addition, one of these changes reverts docker/build-push-action to v1.1.2 the latest v1.1.x version which fixes the silent failures when pushing container images (devfile/api#1328).
Which issue(s) this PR fixes:
Fixes #?
fixes part of devfile/api#1267
fixes devfile/api#1328
PR acceptance criteria:

[ ] Test Coverage

Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

[ ] Gosec scans

Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

[ ] Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Documentation
Does the registry operator documentation need to be updated with your changes?

N/A


Reset or N/A vote option

Endurion (@endurion)
posted 16 minutes ago
Thanks, messages him!
The votes really need a way to reset a given vote. I accidentally hit a star on Overall when I meant to not
vote, and now I can’t withdraw it. The sensible solutions seems to set it to 3, but it feels not right.

To Be Closed
We have this now!


integrate run_transaction into sqlalchemy Session

Would it be possible to integrate run_transaction() into the sqlalchemy.Session() object? I'd much prefer using the standard sqlalchemy patterns for transactions. This will let me switch between backends and not require run_transaction() calls everywhere.
Perhaps you could hijack the begin_nested() function as cockroachdb doesn't support nested transactions anyway.
Then, in the docstring of run_transaction() it says:
def run_transaction(transactor, callback):
    """Run a transaction with retries.
    ``callback()`` will be called with one argument to execute the
    transaction. ``callback`` may be called more than once; it should have
    no side effects other than writes to the database on the given
    connection. ``callback`` should not call ``commit()` or ``rollback()``;
    these will be called automatically.
    ...

Could you explain what no side effects other than writes to the database on the given connection means exactly? I have a web app calling cockroachdb with a single transaction per request. Would passing my entire request handler function to run_transaction() be an anti-pattern?

You can use the regular Session interface on its own, but the problem with doing so is that CockroachDB's transaction model is (partially) based on optimistic concurrency control, so your transaction may be aborted and need to restart (this is possible in any database due to deadlocks, but it's somewhat more likely in CockroachDB). The run_transaction() wrapper takes a callback so it can run the transaction multiple times if necessary. (it also uses our client-side retry protocol to make these restarts a little faster than they would be with a naive restart of the transaction).
By "no side effects other than writes to the database", we mean that you should not do anything externally-visible like sending an email or push notification, because the transaction function may be run more than once. Putting your entire request handler in a transaction would not be ideal (depending on how your web framework works) because you don't want to render your response until after the transaction is committed.
I'm open to suggestions about how to integrate this more naturally with SQLAlchemy - I've never used the Session layer in a real project, just the lower-level query builder. FWIW, I think run_transaction will work with other backend drivers as well, so you can use it whether you're backed by cockroachdb or not.

Thanks @bdarnell that helps a lot already.

@bdarnell I can confirm that run_transaction has no detrimental effect fine on postgresql.


Macroquad Example

I don't know if you've used Macroquad, but I've been trying to get wasm-sockets to work with it's unique build process but haven't succeeded. It would be amazing to have such a simple way of doing multiplayer in the browser with WASM. Could you make a barebones Macroquad example that uses wasm-sockets?

This is a great question, thanks for asking! :)
I've definitely used wasm-sockets with Macroquad before, in fact IIRC I originally developed this library for a multiplayer web game I was developing in Macroquad. I do remember struggling with the compilation process for Macroquad in general haha, but I don't remember having any issues getting it to compile wasm-sockets, so things have probably changed with the compilation process since then. It's currently finals week so I'm a bit busy, but I'll take a look and try to write a quick example when I have a chance.


OpenAI compatibility fix: valid top_p value range is 0.0 to 1.0.

OpenAI compatibility fix: valid top_p value range is 0.0 to 1.0.

Don't error out on OpenAI top_p valid values.

Closes: https://github.com/huggingface/text-generation-inference/issues/2222
Closes: https://github.com/guidance-ai/guidance/issues/945

What does this PR do?
Improves compatibility with OpenAI clients that expect top_p to be valid from 0.0 to 1.0 inclusive.
Fixes:

https://github.com/huggingface/text-generation-inference/issues/2222
https://github.com/guidance-ai/guidance/issues/945

See #2231


Determine what framework the user is using before giving a suggestion

When asking questions about my coding in playwright, co-pilot doesn't notice I have imported playwright and using the playwright framework, instead it gives suggestions based on jest.
I would expect that it would be smart enough to notice what was imported in the file and then give suggestions based on what the user is using and if no framework is detected then default to whatever Copilot would prefer.
I would suggest to default to playwright as its far superior to anything out there in my opinion

What version of the extension are you using?
Do you already have any test file in the project?
What is the naming-scheme of test files, foo.test.js or foo.spec.js or something else?

The issue is no longer there, all I did was restart vscode recently and now it's working much better than before.  A new update must have fixed my issue


Add a doc for add_gate

add explanation of added gates
matrix representation is not displayed(nothing in Safari, just a link file in Chrome)


Canvas context should be saved and restored

From https://github.com/phetsims/circuit-construction-kit-common/issues/728#issuecomment-909578963, we discovered that canvas painters don't save and restore their state.  @jonathanolson said it's best to factor this out so a painter is not responsible for it, and cannot forget it.  It is well-optimized in browsers.

Fixed in the commit.  @pixelzoom can you please review?  I also searched fourier for any save/restore that may no longer be necessary, but I didn't see any.

It might be better to have @jonathanolson review this, since I'm unfamiliar with the optimization that you're trying to address.
But I do have a question https://github.com/phetsims/bamboo/commit/c5d1c499ece95d513d08be680e0433d23ac06a03.  ChartCanvasNode paintCanvas now has this implementation:
  paintCanvas( context ) {
    this.painters.forEach( painter => {
      if ( painter.visible ) {
        context.save();
        painter.paintCanvas( context );
        context.restore();
      }
    } );
  }

If there are N painters, you're calling context.save and context.restore N times.  Is that necessary?

Thanks, I added a comment.

Looks good to me!

Thanks, closing.


esp_wifi_scan_start using blocking fires WIFI_EVENT_SCAN_DONE event (IDFGH-6122)

The code below calls esp_wifi_scan_start with blocking = true and esp_wifi_scan_start with blocking = false.
Both cause WIFI_EVENT_SCAN_DONE to get fired.
This is contrary to: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html
`/*
Demonstrates esp_wifi_scan_start(&config, true) and esp_wifi_scan_start(&config, false)
both cause WIFI_EVENT_SCAN_DONE to get fired.
This is contrary to: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html
Program output:
status = 0, number = 4.
status = 0, number = 4.
*/
#include <string.h>
#include "nvs_flash.h"
#include "esp32/rom/ets_sys.h"
#include "esp_wifi.h"
//#include "freertos/FreeRTOS.h"
//#define EXAMPLE_ESP_WIFI_SSID      CONFIG_ESP_WIFI_SSID
//#define EXAMPLE_ESP_WIFI_PASS      CONFIG_ESP_WIFI_PASSWORD
#define EXAMPLE_ESP_WIFI_SSID      "SSID"
#define EXAMPLE_ESP_WIFI_PASS      "PASSWORD"
/* Handler for all events /
static void all_event_handler(void handler_args, esp_event_base_t base, int32_t id, void* event_data)
{
if (base == WIFI_EVENT && id == WIFI_EVENT_SCAN_DONE)
{
const wifi_event_sta_scan_done_t *pdata = (const wifi_event_sta_scan_done_t *)event_data;
    if (pdata != 0)
        ets_printf("status = %u, number = %u.\n", pdata->status, (uint32_t)pdata->number);
}

}
static void scan(bool block)
{
wifi_scan_config_t config;
config.ssid                 = 0;
config.bssid                = 0;
config.channel              = 0;
config.show_hidden          = false;
config.scan_type            = WIFI_SCAN_TYPE_ACTIVE;
config.scan_time.active.min = 100;
config.scan_time.active.max = 1500;
ESP_ERROR_CHECK(esp_wifi_scan_start(&config, block));

}
void app_main(void)
{
ESP_ERROR_CHECK(nvs_flash_init());
// Create the default event loop
ESP_ERROR_CHECK(esp_event_loop_create_default());

// Register the handler for all event. This will execute if either the timer events or the task iteration event
// is posted to the default loop.
ESP_ERROR_CHECK(esp_event_handler_instance_register(ESP_EVENT_ANY_BASE, ESP_EVENT_ANY_ID, all_event_handler, NULL, NULL));

esp_netif_init();
esp_netif_create_default_wifi_sta();

wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
ESP_ERROR_CHECK(esp_wifi_init(&cfg));

wifi_config_t configSTA;
memcpy(configSTA.sta.ssid, EXAMPLE_ESP_WIFI_SSID, sizeof EXAMPLE_ESP_WIFI_SSID);
memcpy(configSTA.sta.password, EXAMPLE_ESP_WIFI_PASS, sizeof EXAMPLE_ESP_WIFI_PASS);
configSTA.sta.threshold.authmode = WIFI_AUTH_WPA2_PSK;
configSTA.sta.pmf_cfg.capable    = true;
configSTA.sta.pmf_cfg.required   = false;

ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA));
ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &configSTA));
ESP_ERROR_CHECK(esp_wifi_start());

// block first so scan finishes.
scan(true);
scan(false);

}
`

hi @norventa  if block is true, this API will block the caller until the scan is done, otherwise it will return immediately. Both cause WIFI_EVENT_SCAN_DONE event is the desired result.
/home/muhaidong/Pictures/Screenshot from 2021-11-16 17-07-14.png

Yes, I understand that that is desired, however the document:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/wifi.html
says this:
WIFI_EVENT_SCAN_DONE
The scan-done event is triggered by esp_wifi_scan_start() and will arise in the following scenarios:
The scan is completed, e.g., the target AP is found successfully, or all channels have been scanned.
The scan is stopped by esp_wifi_scan_stop().
The esp_wifi_scan_start() is called before the scan is completed. A new scan will override the current scan and a scan-done event will be generated.
The scan-done event will not arise in the following scenarios:
It is a blocked scan.
The scan is caused by esp_wifi_connect().

hi @norventa  It is a blocked scan mean something prevent the completion of scan, which has nothing to do with synchronous and asynchronous block.

Thanks for reporting, feel free to reopen.

hi @norventa It is a blocked scan mean something prevent the completion of scan, which has nothing to do with synchronous and asynchronous block.

the documentation is confusing on this. After reading the comments here, I understand that difference between a blocking scan  esp_wifi_scan_start(NULL, true) when block=true and a blocked scan that was aborted by esp_wifi_connect. but the terminology used in the docs is not consistent
Even the error log when you call esp_wifi_connect prints this: wifi:sta_scan: STA is connecting, scan are not allowed!
here I'm assuming the  blocked scan is used for an aborted on:
The scan-done event will not arise in the following scenarios:

        It is a blocked scan.

        The scan is caused by esp_wifi_connect()

But here the docs clearly uses Blocked for the blocking scan and says the event will not be emitted even though that's not how it's behaving:
Scan in Blocked Mode
If the block parameter of esp_wifi_scan_start() is true, then the scan is a blocked one, and the application task will be blocked until the scan is done. The blocked scan is similar to an unblocked one, except that no scan-done event will arise when the blocked scan is completed.


can't install django-dynamic-scraper with django 1.9 and python 3.6

Hi I cant install it, error message:
path\Wondershare\CreatorTemp\pip-install-5eut7xdz\pillow\setup.py", line 521, in build_extensions
' using --disable-%s, aborting' % (f, f))
ValueError: zlib is required unless explicitly disabled using --disable-zlib, aborting
How could I fixed it please ? :)

This is probably an issue with a too old Pillow dependency, see e.g. here.
Will release a bug fix release soon.

Fixed in 0.13.2-beta release.


Add support to configure the branch where raw md files are kept

Default is kept the old master but newer repos will need to configure
github_branch to main as that's the new default in github

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Will this work for github enterprise as well? I'm noticing the edit link doesn't work on Corp

It should work in github enterprise as well. What error you get @OneCricketeer ?


Remove unused timer.ts file

Fixes #783
any reason why it is still there?
Also, the following files aren't used, should they still be in git?
services/compiler/walkContext.ts
Services/core/integerUtilities.ts
Services/core/istringUtilities.ts
Services/syntax/emitter.ts

thanks!


Reproducing the result of NSFW

Thanks for your excellent works!
I've try your example of Elon Musk and the result is amazing, I try to use the same setting for NSFW erasing but it seems not working.
Can you shares your setting for forgetting prompt "a photo of naked"? Thank you.

I've tried it hard, but the result is totally different from the appearance in the paper. And i catch that the naked template even doesn't exist in the code. What can i do to reproduce the result of NSFW. Sincerely hope solutions provided.


[Python BQ] Retry get_table for quota errors

Python SDK's BigQuery get table method is only retried for server and timeout errors. We should extend this to also retry for quota errors (403: quotaExceeded, rateLimitExceeded).

Run Python 3.8 Postcommit

Run Python 3.10 PostCommit

So obviously I have to ask - can you test it?

You probably need to mock the call like https://github.com/apache/beam/pull/28475/files#diff-a7854eda9da1cdd78ece45e7529978d8296841b84626bee1f925483586b52b14

Yup, added some tests

Run Python 3.8 Postcommit

Run Python 3.10 Postcommit

Thanks for the review @satybald, PTAL

@satybald sorry for the delay, PTAL

stop reviewer notifications


Can't manually close hijacked connections?

I'm new to Golang in general.
The issue I'm facing right now is that I use Gorilla's websocket package to upgrade the http.ResponseWriter and the http.Request to the websocket.Conn.
However after some debugging, I found the underlying websocket.Conn actually has a disowned=true field set. So that I can't manually call Close() on that connection. Doing so, will give me this errClosing = errors.New("use of closed network connection")
In github.com/zenazn/goji/graceful/listener/conn.go
func (c *conn) Close() error {
	c.mu.Lock()
	defer c.mu.Unlock()

	if c.closed || c.disowned {
		return errClosing
	}

	c.closed = true
	c.shard.disown(c)
	defer c.shard.wg.Done()

	return c.Conn.Close()
}

Is there a way that I can manually manage the hijacked connection?

Ooops--this is a bug. Fixed!


Finished the 'Hello, Flask!' homepage.

Pull Request Type
What kind of change does this PR introduce?
[x] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Homepage for the Flask app not showing the "Hello, Flask!" message.
Issue Number: #1050
What is the new behavior?
Now the homepage for the Flask app correctly presents the "Hello, Flask!" message.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


chore: use bcrypt in social network example

Follow security best practices for password storage in social network example.

Great work! Thanks for helping out 😃


Establish Secure Data Exchange Protocols

Implement secure, encrypted data exchange protocols to ensure the integrity and privacy of data when integrating with external or sensitive data sources.

@mahyargorji , need your input on start and end.


Fix backwards compatibility for deprecated logging module

Before submitting

[X] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[X] Did you read the contributor guideline?
[X] Did you make sure to update the docs?
[X] Did you write any new necessary tests?

What does this PR do?
Fixes #798
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Maybe we do not have open an issue if have already fix... And rather write the description here instead...

it seems that it does fix one hole but breaks other compatibility...
import pytorch_lightning.loggers.mlflow
import pytorch_lightning.logging.mlflow
Traceback (most recent call last):
  File "/home/jb/.local/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3265, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-10-8c3cb4802809>", line 1, in <module>
    import pytorch_lightning.logging.mlflow
  File "/home/jb/Applications/pycharm-2019/plugins/python/helpers/pydev/_pydev_bundle/pydev_import_hook.py", line 21, in do_import
    module = self._system_import(name, *args, **kwargs)
ModuleNotFoundError: No module named 'pytorch_lightning.logging.mlflow'

Yeah agreed that making the issues doesn't make sense. I only did it because the PR description prompted me too.
Good point. I'll revise today to fix that too.

@williamFalcon it was not fixed... @tullie wanted to continue on this...

@Borda oh shoot, sorry  didn't  read that last comment. Let's finish this in a separate PR?

Well as you already merged it, it has to done in other PR #815?


Add sub, mul, and div operators

This PR adds those 3 operators, and also asks a lot of questions :)
An example of the wast output (manually modified to import print, call it inside the module, and call the exported test function so that I could check the output in binaryen-shell's interpreter): https://gist.github.com/lqd/44f627530413df83b27815808b953356
First, a comment: I'm not sure about Div. I emitted i32.div at first but that made the binaryen checker/interpreter trap, so I switched to i32.div_s which worked (maybe @kripken could weigh in on this choice ? and I will modify accordingly).
Second: adding the operators triggered some questions/thoughts

The fun_types are a set of rust sigs, however those will be converted to wasm func types, and thus will emit duplicates. Probably not that big of a deal, considering binaryen's optimization passes remove a lot of inefficient wasm patterns (even more so in master than the version used in mir2wasm) even though this specific inefficiency of duplicates and unused func types is not yet handled in binaryen IIRC.
Rust requires those traits & impls to compile, but those operators are wasm "intrinsics", the rust operators' code translated to wasm isn't used (and maybe shouldn't be emitted ? surely not a big deal either, binaryen will optimize them away)
I was working on/fighting with PartialEq: in mir2wasm a lookup was done on PartialEq::eq (eventually, in trans_fn_name_direct) but the impls in the module-to-translate were more like <isize_as_PartialEq>::eq  -- how should this be handled ? (In my own code I hacked around this by returning the isize PartialEq::eq node id when seeing the PartialEq fn defid, but I doubt very much this is how you guys thought it should work :) -- All in all, this personally allowed me to get back to the BinOp Eq/Ne path and make it work, as well as the AddAssign trait)
is there a plan on how the missing things in mir2wasm should work ? and at the same time maybe some "issues" would be interesting, so that we see the things you guys could use some help with ? I talked a bit about that on twitter with @kripken yesterday.
(In my mind I was thinking mir2wasm would maybe use some of emscripten's design to model high level things -- stack frames, memory access, data segments, and so on -- and was waiting for those building blocks to appear before myself contributing on some different topics, having this "plan" and those issues would be helpful in that regard)

First, a comment: I'm not sure about Div. I emitted i32.div at first but that made the binaryen checker/interpreter trap, so I switched to i32.div_s which worked (maybe @kripken could weigh in on this choice ? and I will modify accordingly).

I don't know enough about this to say. In general this code is so early that anything that works is good for progress.

The fun_types are a set of rust sigs, however those will be converted to wasm func types, and thus will emit duplicates. Probably not that big of a deal, considering binaryen's optimization passes remove a lot of inefficient wasm patterns (even more so in master than the version used in mir2wasm) even though this specific inefficiency of duplicates and unused func types is not yet handled in binaryen IIRC.

I guess this table should be keyed by binaryen types? Seems good to me, though wouldn't we have to create the duplicate binaryen type in order to discover that it hashes to the same value as one we've already seen (defeating the potential optimization)?

Rust requires those traits & impls to compile, but those operators are wasm "intrinsics", the rust operators' code translated to wasm isn't used (and maybe shouldn't be emitted ? surely not a big deal either, binaryen will optimize them away)

For primitive types rustc emits the instructions directly and it doesn't matter whether the ops are actually defined, so what you are doing is fine for now.

I was working on/fighting with PartialEq: in mir2wasm a lookup was done on PartialEq::eq (eventually, in trans_fn_name_direct) but the impls in the module-to-translate were more like <isize_as_PartialEq>::eq -- how should this be handled ? (In my own code I hacked around this by returning the isize PartialEq::eq node id when seeing the PartialEq fn defid, but I doubt very much this is how you guys thought it should work :) -- All in all, this personally allowed me to get back to the BinOp Eq/Ne path and make it work, as well as the AddAssign trait)

Perhaps @eddyb @nagisa @solson or @Aatch could help here.
Relatedly, should mir2wasm move to using the item collector now and not deal with monomorphisations itself? Do you have pointers on how to use it?

is there a plan on how the missing things in mir2wasm should work ? and at the same time maybe some "issues" would be interesting, so that we see the things you guys could use some help with ? I talked a bit about that on twitter with @kripken yesterday. (In my mind I was thinking mir2wasm would maybe use some of emscripten's design to model high level things -- stack frames, memory access, data segments, and so on -- and was waiting for those building blocks to appear before myself contributing on some different topics, having this "plan" and those issues would be helpful in that regard)

It would be great to have a plan. Unfortunately, I don't know enough about how either compiler works to know what the steps are. My plan has been to hack things one step at a time by reading the rustc source and bugging the aforementioned people on #rust-internals. Maybe one of them could lay out a vague roadmap.
I would guess that the immediate steps would be to update to Rust master and move to using the item collector to deal with monomorphization (handling monomorphization is one of the biggest sources of ugliness in rustc's old backend, but its new backend has a cleaner way).

I was working on/fighting with PartialEq: in mir2wasm a lookup was done on PartialEq::eq (eventually, in trans_fn_name_direct) but the impls in the module-to-translate were more like <isize_as_PartialEq>::eq -- how should this be handled ? (In my own code I hacked around this by returning the isize PartialEq::eq node id when seeing the PartialEq fn defid, but I doubt very much this is how you guys thought it should work :) -- All in all, this personally allowed me to get back to the BinOp Eq/Ne path and make it work, as well as the AddAssign trait)

I don't quite understand the question.
@brson Does mir2wasm have code for trait method lookup, like this partially-implemented code in Miri which was copied from somewhere in MIR trans?
If not, I think you need that to handle methods like eq properly.

@brson Does mir2wasm have code for trait method lookup, like this partially-implemented code in Miri which was copied from somewhere in MIR trans?

Nope!

First, a comment: I'm not sure about Div. I emitted i32.div at first but that made the binaryen checker/interpreter trap, so I switched to i32.div_s which worked (maybe @kripken could weigh in on this choice ? and I will modify accordingly).

Integer division must be signed or unsigned, and it can trap on things like 0/0 or signed underflow. If you don't want it to trap, you can emit something like a check for 0/0 and avoid the div in that case.
Might be ok to not worry about corner cases for now though. But what was the trap being hit - what values were being divided?

(In my mind I was thinking mir2wasm would maybe use some of emscripten's design to model high level things -- stack frames, memory access, data segments, and so on -- and was waiting for those building blocks to appear before myself contributing on some different topics, having this "plan" and those issues would be helpful in that regard)

There are open questions here I think. One approach is to not use any emscripten bits, which would mean we emit a pure wasm module. And it's 100% up to rust how that works. Alternatively, if we integrate with emscripten, then we can get all its libraries like webgl, websockets, and all the other web integration. If we go that route, then emscripten has some assumptions about how the stack works, etc., which would be a small amount of integration work instead of a lot more work.
In both cases we would need to emit stack handling code here, which means deciding where to store the stack pointer in memory, and emit code to use it in function preludes etc.
For heap allocation, if we integrate with emscripten then we can use it's malloc implementation.
@brson: maybe you could enable issues in this repo, and we'll open issues for the separate topics?

@kripken I must have been doing something stupid, but this was causing an "Abort trap: 6": https://gist.github.com/lqd/cdce63fbbaa6833d9f5040ac95ddc451 while div_s worked immediately.

Issues are enabled.

@lqd: odd, it shouldn't be possible for binaryen to emit that. There is just i32.div_s and i32.div_u, as integer division must be signed or unsigned. (Float division can be just f32.div, on the other hand.) And the functions generating them are BinaryenDivSInt32, BinaryenDivUInt32. How did you get it to emit an integer div without being signed or unsigned?
@brson: thanks!

@kripken I just called the BinaryenDiv extern (https://github.com/brson/mir2wasm/blob/master/src/binaryen.rs#L130) where the other operators are translated. Now the trap makes perfect sense

Oh ok, I see. Meanwhile I also noticed that the names changed, from the ambiguous Div that misled you to the current names which have the full type in them like DivSInt32, DivFloat32, etc., which we'll get when we update binaryen.

In both cases we would need to emit stack handling code here, which means deciding where to store the stack pointer in memory, and emit code to use it in function preludes etc.

I think the "obvious" solution that can easily allow cross-compile-unit interaction is to put a 32-bit stack pointer at 0xffff_fffc and start the stack just below that. That does require initialization, though.
If address 0 is available, using that instead would make some things easier, assuming a default of 0.
If mir2wasm has to do anything hacky in the interim, it should be abstracted into function prelude/return and "allocate space this big for a stack local" (i.e. like LLVM's alloca).

@kripken just to be sure as I'm updating binaryen to a more recent version to have those new names: the currently used binaryen has e.g BinaryenAdd() but emitted i32.add ? (and it's now the job of BinaryenAddInt32())

Yes, in latest binaryen, there is a type on those operations, to remove ambiguity. The old BinaryenAdd could work for all types, and the new way is to use BinaryenAddInt32, for i32 values, etc.

@kripken thank you! So I think the update should be that simple https://github.com/brson/mir2wasm/pull/13


Migrate ci to github actions

It would be nicer if ci and deployment was defined inside github actions.
Create ci with clippy and test checks on every push.
Create publish workflow on workflow_dispatch.

Done


Simpletap bug

Hi, I'm getting the following error in simple tap.

I also have a question regarding auto-update process. I've occasionally deleted it. It's there a command to start it again?

Hi,
Kindly update your code and try again. You can see below the closed issues for people who deleted their auto-update.
https://github.com/thebrumby/HotWalletClaimer/issues/213#issuecomment-2323348698
https://github.com/thebrumby/HotWalletClaimer/issues/221#issuecomment-2343805909


Add iterate() helper to drive stream iteration that is fully integrated with program structure.

Note, this assumes the APIs implied with #696

One of the weaknesses we have when iterating loops is that you either need to use a very manual process for iteration, or you need to use a callback. For example, to iterate the messages on a web socket, you can do it with a for loop.
let sub = yield* on("click", button);

for (let next = yield* sub.next(); !next.done; next = yield* sub.next()) {
  /* handle click */
}

Or, you can use a callback to execute an operation on each one:
yield* forEach(on("click", button), function*(event) {
  /* handle click */
})

The first option has the advantage of being fully integrated into the structure of the enclosing block. In other words, you can break, return, continue, as expected whether that is in a function, and if statement, or even an enclosing while or for loop.
But it is terribly verbose, which is why historically we have used a callback option.
Compare this with the native iteration in JavaScript. To have the best of both words, they have the for...of construct and the for await ..of to drive synchronous and asynchronous iteration respectively. That way, you are not only integrated with your enclosing scope, but the mechanics of the iteration are hidden away from you.
for await (let x of iterable()) {
  /* do async stuff */
}

How can we have the best of both worlds? In a mob session with @neurosnap, @dagda1, @jbolda, and @cowboyd we proposed an iterate helper that would allow you to "project" an Effection Stream into a synchronous Javascript Iterator that could be used with a normal for...of loop. So our previous example of streaming clicks could be written as:
for (let next of yield* iterate(on("click", button)) {
   let click = yield* next;
  /* handle click */
}

This has the advantage of being both concise, but also integrating seamlessly with the enclosing structure. In this example, the first yield* subscribes to the stream, and produces an iteration resource which is a synchronous. Calls to next() return an operation which, when resolved yields the next item.
For "infinite" streams like a click event (Stream<T, never>) this is fine, however, some streams have an "ending" that needs to be handled. In these cases, we need some way of accessing it.  Websockets are like this, where they have the concept of a "close". We can have a result operation on our iterator so that when needed it can be accessed:
let iter = yield* iterate(socket);
for (let next of yield* iter) {
  let event = yield* next;
  /*... handle event */
}

let code = yield* iter.result;

Our iterate helper should be roughly typed:
interface Iteration<T,TResult> extends Iterable<Operation<T>> {
  result: Operation<TResult>;
}

declare function iterate<T, TResult>(stream: Stream<T, TResult>): Operation<Iteration<T,R>>;

This will be tricky to implement because our subscription operation needs to be folded in with the first iteration result. In other words, because we are projecting into a synchronous iteration, we must know the outcome of the first next() before it is called. That way, we can skip the loop entirely if there are no events in the stream.

Implemented with #741


Asset manager

Codecov Report

Merging #13 (49d634d) into master (fd46a61) will decrease coverage by 84.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #13       +/-   ##
==========================================
- Coverage   84.18%   0.00%   -84.19%
==========================================
  Files          11      14        +3
  Lines         569     761      +192
  Branches       95     113       +18
==========================================
- Hits          479       0      -479
- Misses         90     761      +671

Impacted Files
Coverage Δ

contracts/AbstractPowerIndexRouter.sol
0.00% <0.00%> (ø)

contracts/AssetManager.sol
0.00% <0.00%> (ø)

contracts/PowerIndexVaultRouter.sol
0.00% <0.00%> (ø)

contracts/WrappedPiErc20.sol
0.00% <0.00%> (-85.42%)
:arrow_down:

contracts/WrappedPiErc20Factory.sol
0.00% <0.00%> (ø)

contracts/connectors/AbstractConnector.sol
0.00% <0.00%> (-90.39%)
:arrow_down:

...connectors/AbstractProfitDistributionConnector.sol
0.00% <0.00%> (ø)

...tracts/connectors/AbstractStakeRedeemConnector.sol
0.00% <0.00%> (-86.12%)
:arrow_down:

...tracts/connectors/BProtocolPowerIndexConnector.sol
0.00% <0.00%> (ø)

...racts/connectors/BakeryChefPowerIndexConnector.sol
0.00% <0.00%> (-64.29%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd46a61...49d634d. Read the comment docs.


invoke the cache getter function with the resolved key

closed with https://github.com/kurttheviking/orchard/commit/e192ce0c4564127ee2643a15796fea9a2d58e931


Allow wider range of i18n versions for rails 5 compatibility.

This matches the activesupport range i18n (< 2, >= 0.7)

I had merged a previous PR bumping  this to ~> 1.0 but this is probably  a safer bet so that we don't break backwards compatibility. Thanks!


Changing build scripts in package.json

:tada: This PR is included in version 1.1.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add mastodon icon

Oops, that is an odd coincidence. I did push this last week: https://github.com/planet42/Laika/commit/da8e08b230ca18a9e3360b9f2373a225d2283a06 and then forgot to create a PR.
I don't mind which commits we proceed with, both need a little fix. Mine has a red build as I removed unused namespace declarations without adjusting the tests, yours lacks the entry in the icon registry that makes it available in templates via @:icon(mastodon) like here: https://github.com/planet42/Laika/commit/da8e08b230ca18a9e3360b9f2373a225d2283a06#diff-f1fcf8ad892e7ad09579b6db9631276edb4d9b0234b4e9cc1c2e14ba9660adddR72

Oh, nice! Sure, let's go with yours, I think you know what you are doing 😜


When Spitter "Charge Spit" ability runs out (times out) the game displays the expiration message numerous times

Title

PopupClient gaming

Fixed by https://github.com/RMC-14/RMC-14/commit/a060b54b24801bcf33260f8fafcfb3f086163595


Dropdown Not On Top

Does anyone have a quick fix for something like this when the table is small?
https://jsfiddle.net/bshasvbp/2/

Updated https://jsfiddle.net/bshasvbp/3/

https://github.com/twbs/bootstrap/issues/25850#issuecomment-373199401


Error searching messages, API responded with status 401!

Undiscord Version
5.2.3
Browser
Firefox
Extension
Violent Monkey
Reproduction steps
Click author ID, click server ID, click delete.

Error searching messages, API responded with status 401!
{"message":"401: Unauthorized","code":0}
CoreException	{}_

Expected results
I expected this extension to work as usual and delete all my past messages.
Bug affects

[X] DMs
[X] DMs (group)
[X] Channels
[X] Channel (NSFW)

Additional information & file uploads
Nothing more to say here, honestly. Extension Developer, PLEASE FIX THIS EXTENSION!

same issue

what fixed this for me was deleting my save passwords on chrome password manager for discord.

Open advanced settings and "fill" authorization token.

https://github.com/victornpb/undiscord/discussions/627

Open advanced settings and click "fill" on authorization token. Also make sure you don't have any password manager or your browser trying to auto fill any fields, even ones you can't see.

Hey, nothing's working. I've tried this multiple times, and it never works. The developer needs to sign in, fix these issues, and either temporarily disable the app until it's fixed or update it right away.

#627

I tried this solution. Not working, the developer NEEDS to just fix the software themselves!

Been spamming the dev's email for a hot minute. If he values his emails, he should be commenting on this by now...

to everyone that hasn't tried - what fixed it for me was deleting my autofill discord passwords.
possible solutions could include trying a different browser.
this doesn't seem to be an easy fix. and the developer doesn't owe you a fix on a free program.


Add minimal config to enable metrics

The default configData configuration enables the debug server but does not expose it.
The user can enable metrics by setting configData.http.debug.prometheus.enabled:=true
If metrics is enabled the metrics port (default 5001) gets exposed by the pod.
The service and service-monitor configuration is left to the user (for simplicity and security)

+1 for this feature


Long error

So it was working for me for a while. But after restarting act it froze, i tried to add pugin again and i got this error:
https://images-ext-1.discordapp.net/external/ZD8V-o9dNl5zfDNCqZFB2D__whKlIp92L0zHH9XShSI/https/puu.sh/zj2Sq/f7e0f371a2.png?width=356&height=614

Maybe, you can fix it by restarting the PC.


sqlite3 CLI throws "Runtime error: '?' without operand"

sqlite3 CLI throws  "Runtime error: '?' without operand" when using (i?) in WHERE  class, but not in regexp_replace(), and it works in the WHERE clause when using the extension via my GoLand IDE.
The Code
SELECT * FROM
  (SELECT 'Foo' AS f UNION SELECT 'foo' UNION SELECT 'FOO') x
WHERE f REGEXP '(?i)Foo'

The Error
Error: stepping, '?' without operand (1)

The Screenshot

You haven't loaded the extension, hence the error. See How to Install an Extension.

@nalgeon — Not true, unless I misunderstand.
I am using REGEXP, regexp_replace(), regexp_capture(), and regexp_substr() in numerous places in my script, and they are mostly working.
This is the code I use to load the extension at the top of my script:
-- Load REGEXP extension
SELECT load_extension(home_dir.value||'/.sqlpkg/nalgeon/sqlean/regexp.dylib')
FROM config AS home_dir
WHERE key='home_dir';

Let me also emphasize that I am not getting that error when I load the extension and run the query in my GoLand IDE but I am getting that error — on the same script, which includes the load_extension() just before I start using REGEXP.
That is another reason I am pretty sure I have it loaded, because it is working via my IDE but not via the sqlite build that I downloaded from this repo.

For the regexp statement to work in the CLI, you have to load it with .load, not load_extension().
Alternatively, you can use the regexp_like function instead of the regexp statement - it works with load_extension().

Thank you for the reply.

"For the regexp statement to work in the CLI, you have to load it with .load, not load_extension()."

Well, I started my project trying .load but then moved to load_extension().
This is a chicken-and-egg problem, it seems, as the query console of my JetBrain's IDEs does not support .load and only supports load_extension(), but your CLI version requires using .load  and not load_extension().  See screenshot.

Since I am developing a set of scripts that are 1000+ queries, being able to work with the scripts interactively and being able to load a result window in a GUI — vs. doing it all via the sqlite3 command line — is critical for me getting this project done is a reasonable amount of time.
BTW, I also submitted an issue regarding dot commands on JetBrain's bug tracker.

"Alternatively, you can use the regexp_like function instead of the regexp statement - it works with load_extension()."

Yes, thank you for that suggestion, and I had already moved to doing exactly that as a workaround.
Still, it is less than ideal for me (and possibly for others.). For me it adds visual noise and complexity to writing the script — something I can deal with even though I wish were different — but for others they may end up repeating the time I wasted discovering the problem, and then finding a solution/workaround. Or possibly assume your extension does not work and just give up on it.
Yes, you can say "works as intended" and as a fellow open-source developer I can acknowledge and accept that.
OTOH, from a developer experience perspective, not enabling the sqlean extension to be loading and work fully in your sqlite3 build when loading using load_extension() is less than ideal.
Fix this, or not (assuming no technical reason bars you fixing it); either way I will respect whatever decision you make.

not enabling the sqlean extension to be loading and work fully in your sqlite3 build when loading using load_extension() is less than ideal.

It's not something that I do or don't do. It's just the way SQLite CLI works as far as I understand it. Unfortunately, I don't have the capacity to investigate why it doesn't allow overriding the default regexp statement with load_extension.

Unfortunately, I don't have the capacity to investigate why it doesn't allow overriding the default regexp statement with load_extension.

Okay, thanks for the quick reply.
Very fair point.  Then it is what it is. 🤷


Add incomplete development docs

Add docs on porting to a new platform.

TBR so @Mpherman2 can read these.


chore(deps): update plugin org.springframework.boot to v3.2.0

Supercedes https://github.com/candrews/jumpstart/pull/1469


why ParsBert ['UNK'] into English numbers

I try to run a model that uses from pre-trained Bert, I prefer to replace Pars Bert as pre-trained model, because my data is in Persian...
the model's prediction contains some ["UNK"] token's instead of numbers and it make the prediction False( since the model is using the exact match accuracy and the ["UNK"] token's make the prediction differ from the gold_true_value)
as i said here: https://stackoverflow.com/users/10623022/maryami-najafi
is there any body to help?

update:  I try to normalizing data with HAZM , it solve the numbers UNK token but still  I have the UNK problem with also output of model
as you see in below, the first list in dictionary is model prediction and the second list is the true value, my question is that how can I get ride of UNK's of ParsBERT output?
{"conversation581.json_-1": [["flight_search.price_range_ارزانترین [UNK] [UNK] [UNK] [UNK] [UNK] [UNK] [UNK] [UNK]", "flight_search.type_رفت و برگشت [UNK] [UNK] [UNK] [UNK] [UNK] [UNK]"], ["flight_search.price_range_ارزانترین", "flight_search.type_رفت و برگشت"]]}

You can't. This is part of BERT nature! Actually, I didn't get your point! What's your input/output (what do you plan to solve)?
Regarding your first problem, I've added some unused tokens for specific tasks in ParsBERT v2, and perhaps it might be a solution to such a situation.
For the next time, please be more specific!

NO, My ParsBERT is Version 2 :)
I mean:
for each model you have one TRUE data,( some thing like "flight_search.price_range_ارزانترین", "flight_search.type_رفت و برگشت")
and a PREDICTED data, here my data should be like TRUE one (and it IS)
it is like the TRUE + [UNK] tokens
Ofcourse I solve it, i have wrote a code when the token is convert to string and I said that:
when token == "[UNK]" ==> ignore it :)
but I really  curious to know why the estimated output have UNK :)

@MaryNJ
You are going to pass something like this "flight_search.price_range_ارزانترین" as your input?!
And what type of issues you plan to solve (classification, regression, ...)?
For your record, ParsBERT is more a monolingual model than a multilingual one. Consider it (if you're going to deal with other languages, must use mBERT instead)?!
To make things clear, at least for me (just in case of handling the UNK tokens), share your code (on a gist) that covers a sample of your input/output and model. I provided a template for you as bellow:
# data, just a couple of samples
inputs = [
	'دیتای ورودی اول',
	'دیتای ورودی دوم',
]

# in this case a regression problem
# put yours
outputs = [
	0.5,
	1.0,
]

# your tokenizer
...

# your model
...

# your training/evaluation
...

# your prediction
...


refactor(extension): disable continuous adding dataset feature

Overview
Continuous adding datasets on usecase and sample data has an UI issue needs investigate.
This PR temporarily disabled this feature.

Summary by CodeRabbit

New Features

Updated dataset group settings to prevent continuous addition for generic datasets.

Bug Fixes

Adjusted the behavior of dataset groups to ensure compliance with the new addition restrictions.

We reverted previous PR so this one is not needed.


Port setting has no effect on windows

Starting a ruruku session on windows does use the configured port, but seemingly no port at all. The server starts properly, but is not reachable at the address it prints.

no longer relevant


SetPhoto / DeletePhoto

UsersSetPhotoResponse contains profile field of type User.Profile - this is not in API documentation but this is what we get in the response:
{"profile":{"image_24":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_24.jpg","image_32":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_32.jpg","image_48":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_48.jpg","image_72":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_72.jpg","image_192":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_192.jpg","image_512":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_512.jpg","image_1024":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_1024.jpg","image_original":"https:\/\/s3-us-west-2.amazonaws.com\/slack-files2\/avatars\/2017-05-18\/185888967350_e44d439dc32b60bc388c_original.jpg","avatar_hash":"e44d439dc32b"},"ok":true}

Thanks! LGTM.


relation query returning correct objects but with wrong classname/model

I have 2 custom classes, Profile and File
I run this query
return Parse.User.currentAsync((user) => {
var q = user.get('profile').relation('portfolio').query()
return q.find()
})

portfolio is a relation<File> column
logging the items returns [ { className: 'Profile', _objCount: 13, id: '8NJWHiZ0Qk' } ]
the object is correct and i can get the data if i do the usual item.get('field')
but I extended Parse.Object so I have a File model with a custom getField() function that does some additional checks and cannot use that function because it thinks it is a Profile object

What version of the SDK are you using? An error similar to this was resolved in 1.6.13 or 1.6.14, if I remember correctly.

1.6.14

I temporarily fixed it by doing a user.get('profile').fetch()
return Parse.User.currentAsync((user) => {
return user.get('profile').fetch()
})
.then((profile) => {
var q = profile.relation('portfolio').query()
return q.find()
})

i am not sure why fetching the profile fixed it

i fixed it another way that doesn't require a fetch by setting the targetClassName directly
let profile = user.get('profile')
let r = profile.relation('portfolio')
r.targetClassName = 'File'
let q = r.query()

So when the object isn't fetched, the code doesn't know what class name to use for the relation query. If the object is fetched, it does, which explains the divergent behavior. Let me dig into this further.

#179 should fix this

This problem has been bugging me for a while, as well.
Impressed you found how to "fix" it, @ethandt92
Looking forward to release of fix.


Crystal spectra minimum call

Currently the documentation (crystalsim.html) implies that a crystal simulation can be started from a minimum call just specifying Exp.SampleFrame only and both Exp.CrystalSymmetry and Exp.MolFrame take on default values of 'P1' and [0 0 0], respectively. This is not inline with the current logic in pepper line 400, salt line 244, and saffron line 186 (hash: ecd2425a57b251100408707c63b43f85459eb7c8).
For all (pepper, salt, and saffron) specifying just Exp.SampleFrame returns a powder simulation. For pepper specifying one of Exp.CrystalSymmetry or Exp.MolFrame produces a crystal simulation where the Exp.SampleFrame default [0 0 0] is supplied in resfields. For salt and saffron specifying one of Exp.CrystalSymmetry or Exp.MolFrame returns an error for the incorrectly specified SampleFrame.
Given this behaviour together, I think that it might be more consistent if the logic checks isempty(Exp.SampleFrame), then Exp.CrystalSymmetry and Exp.MolFrame are filled in with defaults, if missing. The check for simultaneuous usage with Exp.Ordering will need to be shifted/adjusted accordingly.

Could you please spell out a code snipped here that shows how you think the logic should be implemented?

Sorry for not being clear.
I guess it all hangs on what the minimum call should be and if there is a desire to allow Exp.SampleFrame to be used in contexts other than crystals, for example would a user want to be able to use Exp.SampleFrame with a powder or a partially ordered system? If Exp.SampleFrame can only be used with crystals and the documentation is a correct reflection of how it is supposed to work, with regards to default values, then pepper lines 400--411 could become:
if isempty(Exp.SampleFrame) && (~isempty(Exp.CrystalSymmetry) || ~isempty(Exp.MolFrame))
  if ~isempty(Exp.MolFrame)
    error('Exp.MolFrame cannot be used without Exp.SampleFrame.');
  end
  if ~isempty(Exp.CrystalSymmetry)
    error('Exp.CrystalSymmetry cannot be used without Exp.SampleFrame.');
  end
end

PowderSimulation = ~isempty(Exp.Ordering) || isempty(Exp.SampleFrame);
if PowderSimulation
  if ~isempty(Exp.SampleFrame)
    error('Exp.Ordering cannot be used simultaneously with Exp.SampleFrame.');
  end
else
  if isempty(Exp.MolFrame), Exp.MolFrame = [0 0 0]; end
  if isempty(Exp.CrystalSymmetry), Exp.CrystalSymmetry = 'P1'; end
end

There is probably a simpler/more efficient way to pass through this, but hopefully it is clear.
Alternatively, a crystal simulation could force the user to specify all three SampleFrame, CrystalSymmetry, and MolFrame or SampleFrame in combination with one of CrystalSymmetry or MolFrame (in this case perhaps requiring CrystalSymmetry is preferred?). In this case the documentation (crystalsim.html, userguide_pepper.html#crystals, userguide_salt.html#crystals, and userguide_saffron.html#crystals (and perhaps others?)) will need to be updated as well.

Here is one possible logic:

If given, Exp.Ordering indicates that it's a partially ordered sample. If absent, it's a powder or a crystal.
For a crystal, Exp.MolFrame is required, but Exp.CrystalSymmetry is supplemented if missing.
For crystals and partially ordered samples, Exp.SampleFrame is supplemented if missing. For powders, it is ignored.
For a partially ordered system, Exp.CrystalSymmetry and Exp.MolFrame must be absent.

Here is the full list of input possibilities and the proposed behavior:

Exp.Ordering
Exp.MolFrame
Exp.CrystalSymmetry
resulting sample type
Exp.SampleFrame

-
-
-
powder
disregard

-
-
+
incomplete - error about missing Exp.MolFrame

-
+
-
crystal; supplement Exp.CrystalSymmetry='P1'
use; default to [0,0,0]

-
+
+
crystal
use; default to [0,0,0]

+
-
-
partially ordered
use; default to [0,0,0]

+
-
+
contradictory - error

+
+
-
contradictory - error

+
+
+
contradictory - error

Does this look reasonable?

I think I would consider two different things, for actual crystal simulations, having to specify only the crystal symmetry, and Exp.MolFrame and Exp.SampleFrame defaulting to [0 0 0] does make sense. However, I think it would also be convenient to be able to get a single orientation simulation by specifying Exp.MolFrame only, in cases where someone wants to see what a spectrum for a single orientation of the molecule/the contribution of a specific orientation of a molecule to the spectrum would look like without having to think about crystal symmetries.
I would be in favor of Exp.SampleFrame not being a requirement and just assumed to be [0 0 0] in general, unless users explicitly define this if they want to use this feature.
If the distinction between different samples is crystal/partially ordered sample/disordered (powder) sample, would an Exp.Crystal field with true/false be clean and general enough, or would it then be better to have a field that would cover ordering as well (crystal - single/set of distinct orientations, partially ordered - continuous weighted distribution of orientations, powder - all orientations)?
I'm not sure whether it wouldn't be best to keep Exp.CrystalSymmetry, since a combination of that and Exp.MolFrame is needed to get the information on what orientations need to be considered in the crystal simulation, whereas a single field (Exp.Ordering) is enough to describe the weighted distribution of orientations in a partially ordered sample.

I think my previous suggestions are the least desirable/suitable and think Exp.SampleFrame being not a requirement is the most logical. For a crystal simulation Exp.CrystalSymmetry seems the most straightforward. Although I have had cases that fit in with Claudia's single orientation comment and agree that a concise way to extract single orientations, where considering a single orientation as a crystal might not be obvious, might be convenient.
I'm not sure what the change to Crystal and the true/false options add, does true mask the symmetry and potentially lead to confusion and would the false option be hardly used (presumably people wanting a powder simulation would not be forced to declare false)? If someone had Exp.Crystal = false and supplied an Exp.MolFrame what would happen? Does a user need to explicitly specify the sample types or can this just be inferred from the input.


Strange behavior on WSL2 Debian with SentinelOne

I don't know if other folks have/will run into this or not, but I just want to mark it down.
When I call this library inside my WSL2 Debian box, my WSL session gets killed by SentinelOne due to a windows.penetration event in the detection engine with a "Malware detected!" alert.
SentinelOne is looking into it for further details. I'll update this if I get any meaningful further information.

The normal cause of false positives like this is that some malware makes use of a library, and the AV vendor has just blindly added every single file.
Most of the heavy lifting is done using secrets and hashlib... does your shell get killed if you just fire up a repl and do something like:
import hashlib
import string
import secrets
foo = "".join(secrets.choice(string.ascii_letters + string.digits) for _ in range(10))
print(hashlib.sha1(foo.encode('utf-8')).digest().hex())

Surprisingly (to me, at least) this does not kill it.

From Sentinel they said this was a false positive. The alert was flagged for this:
THREAT INDCATOR(S)
Evasion
•	Attempt to evade monitoring using the Process hollowing technique.
•	MITRE : Privilege Escalation [T1055.012]
•	MITRE : Defense Evasion [T1055.012]


ClassCastException: Response cannot be cast to ObjectResponse

java.lang.ClassCastException: io.getlime.core.rest.model.base.response.Response cannot be cast to io.getlime.core.rest.model.base.response.ObjectResponse
at io.getlime.push.client.PushServerClient.checkStatus(PushServerClient.java:440) ~[powerauth-push-client-0.17.0.jar:0.17.0]
at io.getlime.push.client.PushServerClient.postObjectImpl(PushServerClient.java:407) ~[powerauth-push-client-0.17.0.jar:0.17.0]
at io.getlime.push.client.PushServerClient.createDevice(PushServerClient.java:145) ~[powerauth-push-client-0.17.0.jar:0.17.0]
at io.getlime.security.powerauth.lib.webflow.authentication.mtoken.controller.MobileAppApiController.registerDevice(MobileAppApiController.java:109) ~[powerauth-webflow-authentication-mtoken-0.15.0.jar!/:0.15.0]

Probably invalid, caused by the fact lib was not installed in Maven.


mysql connection does not reconnected by default

backtrace as follows, sounds that connection does not reconnect
ActiveRecord::StatementInvalid - Mysql::Error: MySQL server has gone away: SELECT `admin_users`.* FROM `admin_users` WHERE (username = 'username' AND password = '******'):
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract_adapter.rb:202:in `log'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/mysql_adapter.rb:289:in `execute'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/mysql_adapter.rb:619:in `select'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/connection_adapters/abstract/query_cache.rb:56:in `select_all'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/base.rb:467:in `find_by_sql'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/relation.rb:64:in `to_a'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/relation/finder_methods.rb:143:in `all'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/relation/finder_methods.rb:105:in `send'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/relation/finder_methods.rb:105:in `find'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/relation/finder_methods.rb:101:in `find'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/base.rb:439:in `__send__'
 /usr/local/lib/ruby/gems/1.8/gems/activerecord-3.0.3/lib/active_record/base.rb:439:in `find'
 ./lib/casserver/authenticators/sql.rb:88:in `validate'
 /home/everbox/webapps/cas.everbox.com/releases/20101212123445/lib/casserver/server.rb:346:in `POST /login'
 /home/everbox/webapps/cas.everbox.com/releases/20101212123445/lib/casserver/server.rb:338:in `each'
 /home/everbox/webapps/cas.everbox.com/releases/20101212123445/lib/casserver/server.rb:338:in `POST /login'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:1032:in `call'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:1032:in `compile!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:620:in `instance_eval'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:620:in `route_eval'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:604:in `route!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:656:in `process_route'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:653:in `catch'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:653:in `process_route'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:603:in `route!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:602:in `each'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:602:in `route!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:741:in `dispatch!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:530:in `call!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:706:in `instance_eval'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:706:in `invoke'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:706:in `catch'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:706:in `invoke'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:530:in `call!'
 /usr/local/lib/ruby/gems/1.8/gems/sinatra-1.1.0/lib/sinatra/base.rb:516:in `call'
 /usr/local/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/commonlogger.rb:18:in `call'
 /usr/local/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/runtime.rb:17:in `call'

Any updates on this?  It's quite annoying.

Nope. Although rather than using a cron script to restart the server, you could just have it hit the login page (with curl or wget).
If you want to kill two birds with one stone, set up a URL monitoring system to periodically check that the CAS server is responding properly and alert if it goes down. This will prevent the MySQL connection from getting dropped too, since every hit to the login page creates a new temporary login ticket in the database.

That's unfortunate, but I like your idea about the URL monitoring.

@zuk Can't we have a proper fix in the code instead of having to resort to external "hacks"?

I'm not sure. If you figure out how to do it please do submit a pull request!

If I knew how I would already have :)  I am basically a PHP programmer, my Ruby skills are pretty much non existent.


Add scenario to download GDAS analyses in real-time and other small modifications

Description
This PR adds a separate scenario for the downloading of GDAS analyses (atm, sfc, and sfluxgrb) in near real-time from the NCEP FTP. It adds the necessary task specification and critical path for this stand-alone run that only downloads those data. Also, in this PR are included small changes in the computational requirements of the scenario to run 3denvar OIE120km experiments using 6h IASI observations. The Retry option to search for new observations and GFS analyses was also modified to 10minutes instead of 5minutes in order to decrease the frequency this request is submitted to Casper.
Additionally, it is added the possibility to use the GFS 6-h forecast from previous cycle as the "GFS 0-h forecast" for current cycle, for model space verification purposes. While running a few days the real-time run using RDA data on Cheyenne, it was found out that for some specific days and synoptic hours there is missing the GFS 0-h forecast that we use for the model space verification of MPAS 6-h forecast. Therefore, this will only be of relevance for retrospective experiments using raw data. This was solved by adding an if statement in the script  GetGFSAnalysisFromRDA.csh which will allow us to use the previous 6-h forecast.
Tests completed

[x] 3dvar_OIE120km_WarmStart
[x] 3denvar_OIE120km_WarmStart
[x] 3dvar_OIE120km_ColdStart
[x] 3dvar_O30kmIE60km_ColdStart
[x] 3denvar_O30kmIE60km_WarmStart
[x] eda_OIE120km_WarmStart

If we had a full set of tasks going from GDAS analysis bufr to MPAS x1.init.nc file, then I would prefer to have GDAS added as another kind of externalanalyses with its own set of PrepareExternalAnalysisTasks and Vtable. However, since such a requirement is not needed in the short term, this solution works. Good compromise!

That would be great! We can certainly try that in the future!


Stable Cascade failed when trying to refine with upscaling

Feature Idea
"Use Base" doesn't work. Using some SDXL model slows generation process down significantly and, moreover, changes picture style. So, it would be nice to have "Use Base" that works.
Other
No response

Fixed - cascade now works as a refiner model


Store app token as hashed password

Store app token as a hashed password instead of the raw value.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1836 App token is stored as a plain text


Update Fake.class to support OpenJ9 Field Layout

Currently lombok crashes when building with OpenJ9 JDK as described in #2414
It is due to the override field offset from Fake.class doesn't match actual offset value for AccessibleObject.class in OpenJ9
This change is to support the OpenJ9 Field layout algorithm.

Any updates on this?

No, but neither of the maintainers has been very active of late. Roel
doesn't show up a lot, usually it's Reinier, but since Reinier has a day
job in healthcare apparently he has been so swamped in work that lombok has
fallen by the wayside a bit.
There was some activity yesterday though, so I'm guessing it's just a
matter of time and therefore, patience.
On Mon, May 11, 2020 at 11:17 PM Thiago Henrique Hüpner <
<EMAIL_ADDRESS>wrote:

Any updates on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/pull/2437#issuecomment-626969633,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABIERMX26T6OCJWHCQ34X3RRBTORANCNFSM4MOSFQBA
.

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven

Good find. Thanks!

spring boot 2.3.3 +  lombok 1.18.20 and edge-SNAPSHOT cant running with openj9-0.21.0.
the exception:
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.apache.ibatis.session.SqlSessionFactory]: Factory method 'dsMasterSqlSessionFactory' threw exception; nested exception is java.lang.ClassFormatError: JVMCFRE149 类文件中存在未知常量标记 19；类=module-info，偏移量=68
        at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:189)
        at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:588)
        ... 57 common frames omitted
Caused by: java.lang.ClassFormatError: JVMCFRE149 类文件中存在未知常量标记 19；类=module-info，偏移量=68


OCPBUGS-14824: Bump ibm-powervs-block-csi-driver-operator library-go

Bump library-go
The library-go fix openshift/library-go/pull/1541 merged we also need to bump the library-go dependency for csi drivers operators.
$ go mod edit -go=1.19
$ go get -u github.com/openshift/library-go
go: upgraded github.com/coreos/go-systemd/v22 v22.3.2 => v22.4.0
go: upgraded github.com/go-openapi/jsonpointer v0.19.5 => v0.19.6
go: upgraded github.com/go-openapi/jsonreference v0.20.0 => v0.20.1
go: upgraded github.com/go-openapi/swag v0.19.14 => v0.22.3
go: upgraded github.com/golang/protobuf v1.5.2 => v1.5.3
go: upgraded github.com/google/uuid v1.1.2 => v1.3.0
go: upgraded github.com/mailru/easyjson v0.7.6 => v0.7.7
go: upgraded github.com/openshift/api v0.0.0-20230120195050-6ba31fa438f2 => v0.0.0-20230613151523-ba04973d3ed1
go: upgraded github.com/openshift/client-go v0.0.0-20230120202327-72f107311084 => v0.0.0-20230503144108-75015d2347cb
go: upgraded github.com/openshift/library-go v0.0.0-20230127145903-f99cc633d199 => v0.0.0-20230626162119-954ade536d6d
go: upgraded github.com/sirupsen/logrus v1.8.1 => v1.9.0
go: upgraded github.com/spf13/cobra v1.6.0 => v1.6.1
go: upgraded go.etcd.io/etcd/api/v3 v3.5.5 => v3.5.7
go: upgraded go.etcd.io/etcd/client/pkg/v3 v3.5.5 => v3.5.7
go: upgraded go.etcd.io/etcd/client/v3 v3.5.5 => v3.5.7
go: upgraded go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.35.0 => v0.35.1
go: upgraded golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 => v0.1.0
go: upgraded google.golang.org/grpc v1.49.0 => v1.51.0
go: upgraded k8s.io/api v0.26.1 => v0.27.1
go: upgraded k8s.io/apiextensions-apiserver v0.26.1 => v0.27.1
go: upgraded k8s.io/apimachinery v0.26.1 => v0.27.1
go: upgraded k8s.io/apiserver v0.26.1 => v0.27.1
go: upgraded k8s.io/client-go v0.26.1 => v0.27.1
go: upgraded k8s.io/component-base v0.26.1 => v0.27.1
go: upgraded k8s.io/klog/v2 v2.90.0 => v2.90.1
go: upgraded k8s.io/kms v0.26.1 => v0.27.1
go: upgraded k8s.io/kube-aggregator v0.26.1 => v0.27.1
go: upgraded k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280 => v0.0.0-20230308215209-15aac26d736a
go: upgraded k8s.io/utils v0.0.0-20230115233650-391b47cb4029 => v0.0.0-20230406110748-d93618cff8a2
go: upgraded sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.35 => v0.1.1
$ go mod tidy && go mod vendor
go: downloading github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d
go: downloading golang.org/x/sys v0.7.0
go: downloading golang.org/x/net v0.9.0
go: downloading golang.org/x/term v0.7.0
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/onsi/ginkgo v1.16.4
go: downloading github.com/golang-jwt/jwt v3.2.1+incompatible

/lgtm

/approve


Added pre change transformers to Variables + Clamp Int / Float

This PR addresses #27. Things added in this PR:

Added a list of pre change transformers to AtomVariable
Added docs
Added two AtomFunctions - ClampInt and ClampFloat
Added custom editors for ClampInt and ClampFloat
AtomFunction<T, T> is now part of the generator / regenerate all atoms
Regenerated all the Atoms

reading over the code:

ClampFloatEditor and ClampIntEditor are (almost) identical this could be changed to a single "ClampEditor"
[CustomEditor(typeof(ClampInt))]
[CustomEditor(typeof(ClampLong))]
[CustomEditor(typeof(ClampFloat))]
[CustomEditor(typeof(ClampDouble))]
public class ClampEditor : UnityEditor.Editor
{
// ...

they could implement an interface defining the IsValid call, and 'target' could be casted to the interface.
will check out the commit within the next day, and look into it in more detail

will check out the commit within the next day, and look into it in more detail
(have not done this yet, will edit this post when done)

Fixes in the latest commit:

Created a base class for the editor for ClampFloat and ClampInt. Apparently it is not allowed to have multiple CustomEditor attributes defined for the same class. To implement this I also created an interface called IIsValid (for casting purposes in the editor).
Initialize PreChangeTransformers  at declaration and removed initialization OnEnable
Moved call to RunPreChangeTransformers  from OnEnable to OnValidate. Running it 2 times, once for initialValue and once for value since value can be changed at runtime via editor.
Made the variable PreChangeTransformers private and created a property instead in order to make it impossible to overwrite the list with null from the outside.
Moved ClampInt and ClampFloat in the CreateAssetMenu for Unity Atoms/Functions/Transformers

From this few changes: its super tedious to work with it. you need to create an additional asset for every time you use the clamp function. this should be easier.
Maybe its possible to add an Attribute to a method, scan the assembly for all matching attributes and show a searchable list add the Preprocessor list?
i think in its current state its no fun to work with it.

I get what you are saying. Still think it is neat to have functions as ScriptableObjects, but it would be nice to make the experience working with them better. Will look into the Attribute option and come back. Let me know if you come up with some other solution that we might have missed.

Apparently it is not allowed to have multiple CustomEditor attributes defined for the same class.

Oo thats strange. 🤔 is this a newer change? i thought this was possible.
but you could use the BaseClass, and tell it to use it as "fallback = true" IIRC.

Still think it is neat to have functions as ScriptableObjects

maybe a function. but with this solution, we have each individual function call a object. dozenz of Clamp's. Clamp health, Clamp mana, Max Gold, ...
Maybe using the decorator pattern?
Lets say there is a FloatVariable : AtomVariable<float, ...> and there are
    [Decorates(typeof(FloatVariable))] // maybe not needed
    public class MinFloatVariable : FloatVariable{    public MinFloatVariable(FloatVariable v) // ....

    [Decorates(typeof(FloatVariable))] // maybe not needed
    public class MaxFloatVariable : FloatVariable{    public MaxFloatVariable(FloatVariable v) // ....

Min and Max use the decorator pattern to add logic. in the Variable editor you'd have a dropdown list at the top/bottom which lets you select decorations (can be found with the help of the Attribute). when chosen, this Variable is replaced with a new one (of the decorating type, same name) containing the old one.
the editor of a decorating type, should show the additional fields and then render the editor of the containing type.
I'll test this, this evening.

checked out this branch. went to demo scene and created a new "Function > Clamp Int" named it ClampHealth.
started to throw exceptions:

Is this a problem after the latest commit? Can't reproduce it. Maybe you are running a different version of Unity? It's weird because the error message doesn't either seem to be related to the change.

Ah didn't know about sub assets to be honest. Great to learn something new! This would just work for one decorator per Variable though right? I get that it technically would work with multiple decorators, but the editor will just be shown for the latest one?


Implemented detailedPersonCard in Ui

Coverage decreased (-0.4%) to 86.23% when pulling d00e105b50ec7b5dbdfd3df80a97783d6637d1e8 on V1.3UIRefresh into d5a6ca0b2076667a5c7f3918a84c1f6cb06b42df on master.


Engine requirement

👋 Thanks for creating this. I wonder why the Node.js engine requirement is >= 13?

Good question. Couldn’t find anything relevant in node 13 release notes or corresponding v8. @arv?

No good reason any more
Maybe I added it when we were using JS modules?

@arv I made the change to the code but I don't have access to publish. Can you give me access?

@aboodman invited

Awesome, thanks for making the changes! 👍 @aboodman could you publish the new version?

This is live now as 2.1.0 on npm, sorry it took so long.


feat: code commenting #9369

Description
Adds code commenting in JS objects code editor and JS fields. Users can use Cmd + / on Mac and Ctrl + / on other systems to comment/uncomment code now.
Fixes #9369
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual
Jest

Test Plan

[ ] https://github.com/appsmithorg/TestSmith/issues/2120
[ ] https://github.com/appsmithorg/TestSmith/issues/2121
[ ] https://github.com/appsmithorg/TestSmith/issues/2122

Issues raised during DP testing

[ ] https://github.com/appsmithorg/appsmith/pull/18667#issuecomment-1348354145

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@ravikp7 - you will have to add the title of the PR as  feat:<title> for the semantic PR check to pass.
Also, can we add a detailed PR description, with the shortcut keys described? This helps @theparthacus while preparing our release notes and serves as a future reference for anyone who needs to come back to this PR

@rimildeyjsr Most of the comments on the PR are on the code that I’ve copied from the codemirror comment library, and I know that code is pretty badly written. I just didn’t want to do any modifications to their code as it may introduce some unnecessary bugs. I want to keep it as close to the original code as possible, so I’ve put explicit comments where I’ve added my code or commented out their code. What do you think?

@AnandiKulkarni Can you please help with E2E testing for this?

/ok-to-test sha=2e80158e28d87f23d43cfbe6e76a0c82859557c2

[ ] Autocomplete does not work on a Windows machine. Selecting anything from the dropdown, closes the pop-up but does not insert anything

/ok-to-test sha=07cbc33f99063bde71deefe54c3fa5ffbe6dca56

/ok-to-test sha=0090c53228675f1d82c1bfe0f84044346e78db65

@ravikp7 below commenting in query is wrong
Currently it is working as - select * from us
ers where name = {{ --input2.text,
input.text}}
ex: -- select * from users where name = {{ //input2.text,
input.text}}

@ravikp7 Please find below recording on list widget cmd+l works outside {{}}, which does not evaluate anything but it works only before label and value and not before children, behaviour is very abrupt
https://user-images.githubusercontent.com/80756091/209196871-f295647d-6a15-4e4d-b23c-d90dd09b1d83.mov

@ravikp7 below commenting in query is wrong Currently it is working as - select * from us ers where name = {{ --input2.text, input.text}} ex: -- select * from users where name = {{ //input2.text, input.text}}

@AnandiKulkarni This happened only when the cursor was placed inside the JS binding. Thanks for catching it. I've pushed a fix for it and added another unit test for this case.

@ravikp7 Please find below recording on list widget cmd+l works outside {{}}, which does not evaluate anything but it works only before label and value and not before children, behaviour is very abrupt
Screen.Recording.2022-12-22.at.11.20.18.PM.mov

@AnandiKulkarni I've fixed this issue as well and added unit tests, only the lines with text binding will get commented out with comments inside {{ }}. And, for the rest of the lines commenting will not work where {{ }} is not used because those lines are not JS, but just plain text.

/ok-to-test sha=e0110bb8f6f1f29f05c50b12ec4d3fd1f7decb16

/ok-to-test sha=564de767b24e48424fe5296b642dbeca0e03cb8d

/perf-test sha=564de767b24e48424fe5296b642dbeca0e03cb8d

/ok-to-test sha=aeba6b22199408be4bc3473de29b484179517d94

/ok-to-test sha=4153fe29ea934db0d49bb0d4b8736170876d0331

/ok-to-test sha=004087ad10f4e66dee628a97b33bc5d7a1d3dfd7

/ok-to-test sha=004087ad10f4e66dee628a97b33bc5d7a1d3dfd7

/ok-to-test sha=994350755eb7281653062fed5dc6eed00aabc923

/ok-to-test sha=943ebfd60b255f8be0ec1102656ab7258c516af6

/ok-to-test sha=6b6b26eed7d2342beecb724080e2eb2c3d716bef


Add range queries

I still need to add tests, but datafusion works after I add this and ListObjects support.

@dzbarsky ready to go!

@adamfaulkner-at Oh no! I just tried this and it fails tests:
--- FAIL: TestRangeQuery (0.07s)
    --- FAIL: TestRangeQuery/entire_range (0.00s)
        s3_test.go:245: operation error S3: GetObject, https response error StatusCode: 200, RequestID: , HostID: , deserialization failed, failed to decode response with invalid Http bindings, unable to parse time string, parse errors:
             * "Mon, 02 Jan 2006 15:04:05 GMT": parsing time "07 Feb 24 01:33 +0000" as "Mon, 02 Jan 2006 15:04:05 GMT": cannot parse "07 Feb 24 01:33 +0000" as "Mon"
             * "Mon, _2 Jan 2006 15:04:05 GMT": parsing time "07 Feb 24 01:33 +0000" as "Mon, _2 Jan 2006 15:04:05 GMT": cannot parse "07 Feb 24 01:33 +0000" as "Mon"
             * "Mon, _2 Jan 06 15:04:05 GMT": parsing time "07 Feb 24 01:33 +0000" as "Mon, _2 Jan 06 15:04:05 GMT": cannot parse "07 Feb 24 01:33 +0000" as "Mon"
             * "Monday, 02-Jan-06 15:04:05 MST": parsing time "07 Feb 24 01:33 +0000" as "Monday, 02-Jan-06 15:04:05 MST": cannot parse "07 Feb 24 01:33 +0000" as "Monday"
             * "Mon Jan _2 15:04:05 2006": parsing time "07 Feb 24 01:33 +0000" as "Mon Jan _2 15:04:05 2006": cannot parse "07 Feb 24 01:33 +0000" as "Mon"
             *


Hamburger button bug

On mobile screen size:

Humburger nav bar don't hides when I click outside.
When I click at humburger to close it always redirect me to top of the page.

fixed this in my fork, you can see if you want


Create relationship when subdocument contains _id property

Currently a naming convention of xxx_id (where xxx is a collection name) is used to identify relationships across collections. For example, consider a document in a the customers collection:
{
   "_id": ObjectId(1234),
   "name": "Bob Loblaw",
   "purchases": [
      {
         "products_id": ObjectId(xxx),
         "quantity": 2,
         "date": "03/23/2015"
   }
}

This would create a relationship to a node representing a document from the products collection because we have a property key of products_id.
However, we should also support creating relationships from subdocuments where the key _id is used. For example, we should observe the same behavior with this document:
{
   "_id": ObjectId(1234),
   "name": "Bob Loblaw",
   "purchases": [
      {
         "_id": ObjectId(xxx),
         "quantity": 2,
         "date": "03/23/2015"
   }
}

It sounds like an important feature to add


test-helpers: move most packages in devDependencies to dependencies

The listed devDependencies generally need to be put into the dependencies as they're production dependencies (must be installed for users).

Closed with #21


Auto reload translation

Is it possible to implement hot reload translations then file changes?

Are you using Phoenix with live reload? If so, you can add the locales directory/files to your list of live reload patterns in dev.exs

Yes, i’m using live reload. How to do it? :)

  live_reload: [
    patterns: [
      ~r{config/locales/.*(exs)$}, # add this
      ~r{priv/static/.*(js|css|png|jpeg|jpg|gif)$},
      ~r{web/views/.*(ex)$},
      ~r{web/templates/.*(eex)$}
    ]
  ]

Yes, browser reloads, but still with old translations.


Could not resolve dependency: peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>

Describe the bug
I cloned a repo and run
npm install

and got an error:
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/stripe
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@golevelup/nestjs-stripe
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!

Reproduction
related to npm package stripe
System Info
Windows 11

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

for now, can you try npm install --legacy-peer-deps

I tried with --force and it installed all packages.

Try with pnpm , i didnt get any issue so far

The latest commit should fix this. Closing now. Feel free to reopen

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Display Leaderboard on Map

On each play map page, we should show the levelRanking table for each model

closed in https://github.com/webdevcody/survive-the-night-sim/pull/135


Problems reading binaries linked with mold

elfx86exts has problems reading binaries linked with mold.
Somehow it is unable to detect all or almost all instruction sets. This happens with all compilers and languages, but has some correlation with compiler flags used.

E.g. lets examine elfx86exts itself linked with the default Rust linker outputs:
$ elfx86exts ./elfx86exts
File format and CPU architecture: Elf, X86_64
MODE64 (call)
CMOV (cmova)
SSE2 (movdqa)
BMI (tzcnt)
SSE1 (movups)
AVX (vmovdqa)
AVX2 (vpcmpeqb)
NOVLX (vpcmpeqb)
Instruction set extensions used: AVX, AVX2, BMI, CMOV, MODE64, NOVLX, SSE1, SSE2
CPU Generation: Unknown

Seems legit and indeed I can find say vpcmpeqb in objdump:
0000000000203500 <_ZN6memchr4arch6x86_644avx26memchr3One13find_raw_avx217he5d0877342d03fe8E>:
  203500:	48 89 d1             	mov    %rdx,%rcx
  203503:	48 89 f2             	mov    %rsi,%rdx
  203506:	c5 fd 6f 07          	vmovdqa (%rdi),%ymm0
  20350a:	c5 fd 74 0e          	vpcmpeqb (%rsi),%ymm0,%ymm1
  20350e:	c5 fd d7 f1          	vpmovmskb %ymm1,%esi
  203512:	85 f6                	test   %esi,%esi
  203514:	74 16                	je     20352c

But when linked with mold (i.e. RUSTFLAGS='-C link-arg=-fuse-ld=mold' cargo build --release):
$ elfx86exts ./elfx86exts
File format and CPU architecture: Elf, X86_64
MODE64 (push)
CMOV (cmova)
SSE2 (movdqa)
BMI (tzcnt)
SSE1 (movups)
Instruction set extensions used: BMI, CMOV, MODE64, SSE1, SSE2
CPU Generation: Haswell

AVX is not detected, despite I still can find the same piece of code in objdump:
0000000000636db0 <_ZN6memchr4arch6x86_644avx26memchr3One13find_raw_avx217he5d0877342d03fe8E>:
  636db0:	48 89 d1             	mov    %rdx,%rcx
  636db3:	48 89 f2             	mov    %rsi,%rdx
  636db6:	c5 fd 6f 07          	vmovdqa (%rdi),%ymm0
  636dba:	c5 fd 74 0e          	vpcmpeqb (%rsi),%ymm0,%ymm1
  636dbe:	c5 fd d7 f1          	vpmovmskb %ymm1,%esi
  636dc2:	85 f6                	test   %esi,%esi
  636dc4:	74 16                	je     636ddc

I guess mold does something unusual, which somehow confuses elfx86exts.

A really broken example is btop.
Linked with default GNU ld:
$ elfx86exts btop
File format and CPU architecture: Elf, X86_64
MODE64 (call)
AVX (vzeroupper)
CMOV (cmova)
NOVLX (vpxor)
BWI (vmovdqu8)
BMI (tzcnt)
BMI2 (shrx)
AVX2 (vinserti128)
AVX512 (vmovdqa64)
VLX (vpbroadcastq)
SSE2 (pause)
DQI (kshiftrd)
Instruction set extensions used: AVX, AVX2, AVX512, BMI, BMI2, BWI, CMOV, DQI, MODE64, NOVLX, SSE2, VLX
CPU Generation: Unknown

Linked with mold:
$ elfx86exts btop
File format and CPU architecture: Elf, X86_64
MODE64 (ret)
Instruction set extensions used: MODE64
CPU Generation: Intel Core

Nothing is detected.

Strange! Indeed, mold must be constructing its executables in an unusual way.
At this point, I only have the capacity to maintain this package passively, so I'm afraid that I can't look into this problem myself. But I am happy to accept pull requests and put out new releases. If you look at the source code, this program is fairly simple, and I suspect that this problem might be fixable simply by teaching the program to consider a few additional types of executable-file sections.

Well, I started with simply printing sections and their instruction counts.
ld
$ ./elfx86exts ./elfx86exts
File format and CPU architecture: Elf, X86_64
.init: 8
MODE64 (call)
.plt: 42
.plt.got: 8
.text: 793504
BMI (tzcnt)
CMOV (cmovae)
SSE1 (movups)
SSE2 (pause)
AVX (vmovdqu)
NOVLX (vmovaps)
AVX2 (vpor)
.fini: 4
Instruction set extensions used: AVX, AVX2, BMI, CMOV, MODE64, NOVLX, SSE1, SSE2
CPU Generation: Unknown

mold
$ ./elfx86exts ./elfx86exts
File format and CPU architecture: Elf, X86_64
.plt: 90
MODE64 (push)
.plt.got: 12
.fini: 4
.init: 8
.text: 111
CMOV (cmovs)
Instruction set extensions used: CMOV, MODE64
CPU Generation: Intel Core

Instruction count on .text is obviously very underestimated for binary produced by mold.

Inspecting the problem deeper, I found a possible reason.
But seems like this is capstone-rs fails to decode instructions, so we can't really fix anything here.
I posted a detailed explanation here: https://github.com/rui314/mold/issues/1133#issuecomment-1773365655

Hey, I actually managed to develop a fix! I will make a PR.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_c9rqttfn3j/clone/recipe/meta.yaml:0: jinja_render_failure: The recipe could not be rendered by Jinja2
Errors were found