fix: Unable to create a new line in description field with SHIFT+Enter

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49374
PROPOSAL: https://github.com/Expensify/App/issues/49374#issuecomment-2360047321
Tests

Go to chat.
Click + > Submit expense > Manual.
Enter amount > Next.
Click Description.
Press SHIFT+ENTER
Verify that: A new line will be created

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to chat.
Click + > Submit expense > Manual.
Enter amount > Next.
Click Description.
Press SHIFT+ENTER
Verify that: A new line will be created

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/4a2e5b89-8201-47bd-867e-6025cee54d9f

Android: mWeb Chrome

https://github.com/user-attachments/assets/f3cdabfe-cb59-4afb-92b1-271aa2b25909

iOS: Native

https://github.com/user-attachments/assets/49542af7-9063-4457-aeff-4102d707e07c

iOS: mWeb Safari

https://github.com/user-attachments/assets/59d65bed-b0d8-45bd-8795-cb7dadea1d82

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/d5da7ac2-adeb-4d4a-a1ba-81ad2da093dd

MacOS: Desktop

https://github.com/user-attachments/assets/f576d809-756f-4b7f-be8a-cf48a6de4fe4

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reminder from the updated contributing guidelines

Open a pull request. It is required to complete every step and check every box in the PR Author Checklist. If a box has been checked without the action being taken, it will be a violation of Rule #2 and could lead to a warning being issued.

This item is checked and there's warning on the videos for android native in both the PR author and reviewer checklists. Can you please report it or open an issue for it and link it here?

I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

@cead22 Thanks for your reminder.
Reported two problems:

https://expensify.slack.com/archives/C049HHMV9SM/p1727283923117029
https://expensify.slack.com/archives/C049HHMV9SM/p1727284087625509

Thank you

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


GLES3 (as opposed to GLES2) reflection probes at odd angle and don't seem to reflect objects

Godot version
3.3.2.stable, 3.4.beta4
System information
Linux, Ubuntu 20.04.1, AMDGPU RAVEN2, GLES3
Issue description
More poking reflection probes to see what breaks...
Well, they're broken.
Steps to reproduce
Project below shows both behaviours.
Switching to GLES2 will show the reflection probe working as expected.

Switching to GLES3 will show the reflection on it's side and not reflecting expected objects.
(Cubemap resolution was downsampled due to a severe increase in GPU load on GLES3. The problem persists at higher resolutions.)

Setting the reflection probe update mode to "Once" results in even more broken output.

Minimal reproduction project
lab.zip

Do you get the same behaviour in 3.3.2 or 3.3.3?

Yes.

I ran it in the web editor and the results look good in both GLES3 and GLES2.

This may be a hardware dependent issue, so we will need testing from a few users to see if we can triangulate the problem.

Bug not in 3.1-stable

But is in 3.2-stable

Ok, got something more precise:
Bug not in 3.2-beta1

But is in 3.2-beta2

I have a feeling it is https://github.com/godotengine/godot/commit/cd40154890ba9791b219d66beaf187a7d8dcdba5 but no changes to reflection probes were made in that commit, so it may take a little digging

Updated reproduction project, should show more information for screenshots
lab.zip

Okay, I have a theory, I think that the sky code is accidentally leaving some state set in the cubemap filtering shader. When using texture array at the end these three condiitons are set to "False":
https://github.com/godotengine/godot/blob/16642e28380cf5513fad6ea8591f809e42820382/drivers/gles3/rasterizer_storage_gles3.cpp#L1931-L1933
buuut, when using a regular texture only 2 of the three conditions are set to false:
https://github.com/godotengine/godot/blob/16642e28380cf5513fad6ea8591f809e42820382/drivers/gles3/rasterizer_storage_gles3.cpp#L2067-L2068
So the conditional CubemapFilterShaderGLES3::USE_SOURCE_DUAL_PARABOLOID is left at true
the reflection probe code never touches the conditional so it is left as true
https://github.com/godotengine/godot/blob/16642e28380cf5513fad6ea8591f809e42820382/drivers/gles3/rasterizer_scene_gles3.cpp#L714-L747
The reflection probe code always uses a cubemap source so CubemapFilterShaderGLES3::USE_SOURCE_DUAL_PARABOLOID should always be false.
The solution is to set CubemapFilterShaderGLES3::USE_SOURCE_DUAL_PARABOLOID to false here:
https://github.com/godotengine/godot/blob/16642e28380cf5513fad6ea8591f809e42820382/drivers/gles3/rasterizer_storage_gles3.cpp#L2067-L2068

This bug is fixed as of (at the latest) 76693aa but is likely fixed well before then, closing.


docs(Menu): fix dropdown item augmentation

This PR changes augmentation order so the Dropdown is augmented with a Menu.Item.  I also added the missing MenuItem icon shorthand.  The prop was there but not actually rendered.
Before

After

Current coverage is 98.86% (diff: 100%)

Merging #540 into master will increase coverage by <.01%

@@             master       #540   diff @@
==========================================
  Files           108        108
  Lines          1762       1764     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1742       1744     +2
  Misses           20         20
  Partials          0          0

Powered by Codecov. Last update 7621a1b...94e2bba

Released in<EMAIL_ADDRESS>


read write value, kotlin delegate style

I've been using get_storage and found it very helpful. I think I have a nice implementation to add to make it easier to use.
Inspired by kotlin ReadWrite delegate. So a simple get or set will directly access box.
class MyPref {
  static final _otherBox = () => GetStorage('MyPref');

  final username = ''.val('username');
  final age = 0.val('age');
  final price = 1000.val('price', getBox: _otherBox);

  // or
  final username2 = ReadWriteValue('username', '');
  final age2 = ReadWriteValue('age', 0);
  final price2 = ReadWriteValue('price', '', _otherBox);
}

...

void updateAge() {
  final age = 0.val('age');
  // or
  final age = ReadWriteValue('age', 0, () => box);
  // or
  final age = Get.find<MyPref>().age;

  age.val = 1; // will save to box
  final realAge = age.val; // will read from box
}

age.val = 1; // will save to box
Wow, I really enjoyed that.
I will have to clone the repository because Flutter has a problem in pana that is not letting the tests go, so I will test it locally, but it looks really cool. Thank you for that.

You're welcome, thanks for the awesome lib GetX and Get_storage

I thank you for contributing to this.


No information provided on exactly what is sent to to an external PR status server

Nowhere in any of this documentation is there any information on, or a link to any information on exactly what data about the pull request Azure DevOps sends to an external PR status server.  Apparently the only way to find that out is to build a PR status server and configure Azure DevOps to send PRs to it and then examine its logs.  Since the sample code in the documentation that implements such a server doesn't compile under .NET 6, there is no way to determine what the payload is from Azure DevOps to a PR status server.
  A simple JSON schema document would suffice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb9f18f9-d577-397d-0de1-a9ebdf9cb846
Version Independent ID: 720aee9c-25d9-7033-4adf-c317c76986fe
Content: Pull request workflow extensibility - Azure Repos
Content Source: docs/repos/git/pull-request-status.md
Product: devops
Technology: devops-code-git
GitHub Login: @vijayma
Microsoft Alias: vijayma

@cpdohert -- thank you for your feedback.  Please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@vijayma -- please look into this issue.

"We can't be arsed to document our own product, so go check Stack Overflow" is not an actual answer.  This isn't free software.  My organization pays thousands of dollars for this.


Read configuration from validic.yml - railtie approach

Providing an option to consumer to declare configuration in validic yml so that they can maintain different validic token with respect to their environments.

@allcentury , concerning this issue I opened https://github.com/Validic/validic/issues/36
were you leaning more towards creating a validic-rails gem that just requires validic as a dependency and initializes it, or were you ok with using this approach that only requires the railtie file if ::Rails.defined? to not couple the gem to rails specifically? If your ok with this strategy, I'll go through and code review my teammates pull request.
Thanks,
Alex Bezek


No stream 2020-12-26

Hey guys; there'll be no stream today - it's too close to Christmas.  I will be back to streaming next week, though.

Merry Christmas! :)

Thanks! - hope you also had a good one :D.


CSS is included in reactLazySsrStats.json

I'm using Razzle, and i got css included in reactLazySsrStats.json
{
  "publicPath": "/",
  "chunks": {
    "client": [
      "static/css/bundle.9823d995.css",
      "static/js/bundle.b6483aa5.js",
      "static/js/bundle.b6483aa5.js.map"
    ],
    "src-components-tinymce": [
      "static/js/vendors~src-components-tinymce.44d0aba7.chunk.js",
      "static/js/vendors~src-components-tinymce.44d0aba7.chunk.js.map",
      "static/js/src-components-tinymce.e63dcbc5.chunk.js",
      "static/js/src-components-tinymce.e63dcbc5.chunk.js.map"
    ]
  }
}

It causes error
Uncaught SyntaxError: Unexpected token '<'

because it's rendered as <script> javascript tag.
How to fix this ?

What @revskill10 say is correct... But the problem is not that its adding the CSS files, from my understanding the problem is in chunkExtractor.getScriptTags() which considers everything under that array is a js file and its not.
I've built myself a filter function on top of what we have now to filter those.. If u have not fixed it yet u may take a look:
  const { _chunkFiles, _entryPoints: [entryPoint] } = chunkExtractor;
  const polyfills = _chunkFiles.polyfills.filter((file) => !/\.map$/gi.test(file))
  const entryPointFiles = _chunkFiles[entryPoint].filter((file) => !/\.map$/gi.test(file))
  const cssEntryPointFiles =  _chunkFiles[entryPoint].filter((file) => !/\.css$/gi.test(file))
  const jsEntryPointFiles =  _chunkFiles[entryPoint].filter((file) => !/\.css$/gi.test(file))


LEP-446 restore v7 client involvement type

https://dsdmoj.atlassian.net/browse/LEP-446
Restore client involvement type to v7 of the API
Checklists
Author: (before you ask people to review this PR)

[x] Diff - review it, ensuring it contains only expected changes
[x] Whitespace changes - avoid if possible, because they make diffs harder to read and conflicts more likely
[x] Changelog - add a line, if it meets the criteria
[x] Secrets - no secrets should be added
[x] Commit messages - say why the change was made
[x] PR description - summarizes what changed and why, with a JIRA ticket ID
[x] Tests pass - on CircleCI
[x] Conflicts - resolve if Github reports them. e.g. with git rebase main

Reviewers remember:

[ ] Jira ticket criteria are met
[ ] Migrations - test migration and rollback: rake db:migrate && rake db:rollback

@starswan  is it correct?
Currently assessment > proceeding_types[] -> client_involvement_type is optional
New change  assessment > proceeding_types[] -> client_involvement_type is mandatory

I think it needs to be restored and should be optional in V7

@starswan is it correct? V6 -> Currently assessment > proceeding_types[] -> client_involvement_type is optional V6 and V7 -> New change assessment > proceeding_types[] -> client_involvement_type is mandatory

I think it needs to be restored and should be optional in V7

No it's always required - we removed it in error (its needed for the Domestic Abuse case, where 'A' is the only value where thresholds are waived)


fix link

Type of changes

[X] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Description
I just noticed that somehow a merge in my PR #1920 broke the link of a contributor. Not sure how it happened, but here's the fix.

Suspect that was my fault. Bad merge. Test fails are unrelated. Thanks


Adding auto option to the description of cloud_provider config

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #996 opened

Start Time: 2021-01-05T12:56:29.781+0000

Duration: 3 min 10 sec

:grey_exclamation: Flaky test report
No test was executed to be analysed.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #996 opened

Start Time: 2021-01-05T12:56:29.781+0000

Duration: 3 min 10 sec

:grey_exclamation: Flaky test report
No test was executed to be analysed.


AttributeError: 'module' object has no attribute 'pbkdf2_hmac'

Auth not working because of the above error in auth.py @afischer

Reason: server has Python 2.7.6, pbkdf2_hmac was introduced in 2.7.8

Will upgrade!
@adelq please send me a gist with the code you are using to test SSO as well!

At the moment, I'm simply accessing https://api.pennlabs.org/auth because that is how it will be accessed by the mobile clients.

Ah, ok. So you're just running the mobile server locally to see errors, or are you checking the logs on the server?
--
Andrew Fischer
On December 5, 2015 at 9:14:53 PM, Adel Qalieh<EMAIL_ADDRESS>wrote:
At the moment, I'm simply accessing https://api.pennlabs.org/auth because that is how it will be accessed by the mobile clients.
—
Reply to this email directly or view it on GitHub.

The latter, I'm checking the logs on the server since you can't do any form of auth testing locally ATM.

Fixed with server side updates

For future reference: add-apt-repository ppa:fkrull/deadsnakes-python2.7 && apt-get update && apt-get upgrade -y


feat(rust): add osx vault backed by keychain and secure enclave

This is awesome 🎉   I'll read the code a little bit later in the afternoon.

Looks good for now. But this, I suspect, needs to move to a separate create to keep things modular.


nans taking over the output of get_aacgm_coord_arr

Describe the bug
Sometimes, nan takes over the output of get_aacgm_coord_arr.
To Reproduce
Run the following code:
import aacgmv2 as aacgm
lat = [25.69817439, 19.81656206]
lon = [19.184186, 19.11999446]
alt = [465.28404149,<PHONE_NUMBER>9]
print(aacgm.get_aacgm_coord_arr(lat[0], lon[0], alt[0], dt.datetime(2014,12,7,16,17)))
print(aacgm.get_aacgm_coord_arr(lat[1], lon[1], alt[1], dt.datetime(2014,12,7,16,17)))
print(aacgm.get_aacgm_coord_arr(lat, lon, alt, dt.datetime(2014,12,7,16,17)))

and you get:
(array([21.06023285]), array([91.8062328]), array([17.81449611]))
(array([nan]), array([nan]), array([nan]))
(array([nan, nan]), array([nan, nan]), array([nan, nan]))

Running get_aacgm_coord_arr with method=allowtrace eliminates all the nan values in the above example, implying that setting allowtrace as the default method might help, but the following code also exhibits the same bug:
lat = [25.69817439, 17.14050096]
lon = [19.184186, -4.46442997]
alt = [465.28404149,<PHONE_NUMBER>9]
method = 'geocentric|allowtrace'
print(aacgm.get_aacgm_coord_arr(lat[0], lon[0], alt[0], dt.datetime(2014,12,7,16,17), method=method))
print(aacgm.get_aacgm_coord_arr(lat[1], lon[1], alt[1], dt.datetime(2014,12,7,16,17), method=method))
print(aacgm.get_aacgm_coord_arr(lat, lon, alt, dt.datetime(2014,12,7,16,17), method=method))

This code results in the following:
(array([21.16991252]), array([91.79687939]), array([17.81387255]))
(array([nan]), array([nan]), array([nan]))
(array([nan, nan]), array([nan, nan]), array([nan, nan]))

Expected behavior
I would expect the final print statement in the first example to print (array([21.06023285, nan]), array([91.8062328, nan]), array([17.81449611, nan])) and in the second example to print (array([21.16991252, nan]), array([91.79687939, nan]), array([17.81387255, nan]))
Desktop (please complete the following information):

OS: macOS 10.14.6
Version 2.5.2 (commit e4961ed)

@johncoxon could you test #43 ?  It should be good to go now.

Hi Angeline, I've checked out origin/NaN_bug_get_aacgm_coord and python setup.py install'd it, and I still get the behaviour I've reported above, I'm afraid.

The proposed bug fix actually breaks some existing behaviours, as now get_aacgm_coord_arr returns lists rather than arrays which causes some of my existing code to need modification to cope with that; I've reverted back to master for now so I don't have to write workarounds into my code.

Hi @johncoxon , can you show me the results you got after installing it?  I can't move forward without being able to reproduce your failure.

The proposed bug fix actually breaks some existing behaviours, as now get_aacgm_coord_arr returns lists rather than arrays which causes some of my existing code to need modification to cope with that

Yeah, in order to do this in C, the output has to be a list.  The python wrappers could cast the output as numpy arrays, and from your feedback I am guessing that would be a desired behaviour?

Sorry, I should have said--the results I get after installing are the same as in the initial bug report:
([21.169912518324892], [91.79687938812465], [17.81387254816658])
(array([nan]), array([nan]), [nan])
(array([nan, nan]), array([nan, nan]), [nan, nan])

I do now get two errors which say C Error encountered: <built-in function convert_arr> returned a result with an error set, though, if that helps? I'm confident that I've installed the changed version because I've had to wrap the lists in np.array()s for now.

>>> import aacgmv2 as aacgm
>>> lat = [25.69817439, 17.14050096]
>>> lon = [19.184186, -4.46442997]
>>> alt = [465.28404149,<PHONE_NUMBER>9]
>>> method = 'ALLOWTRACE|GEOCENTRIC'
>>> print(aacgm.get_aacgm_coord_arr(lat[0], lon[0], alt[0], dt.datetime(2014,12,7,16,17), method=method))
(array([21.16991252]), array([91.79687939]), array([17.81387255]))
>>> print(aacgm.get_aacgm_coord_arr(lat[1], lon[1], alt[1], dt.datetime(2014,12,7,16,17), method=method))
(array([nan]), array([nan]), array([nan]))
>>> print(aacgm.get_aacgm_coord_arr(lat, lon, alt, dt.datetime(2014,12,7,16,17), method=method))
(array([21.16991252,         nan]), array([91.79687939,         nan]), array([17.81387255,         nan]))

I pulled the latest changes on NaN_bug_get_aacgm_coord and this is the result, so I think this bug is addressed in that branch. Should be good to merge into the main repo!

Ok, I merged into develop and will prepare the version bump to major next week.


Fix IMC 3D description fields that were not properly updated in #349

@ngehlenborg @jswelling I changed the base branch to dev-integrate because we only use master branch for the final PROD release once everything is tested. And the #349 is only merged into dev-integrate so far.

Replaced with #363.

(@yuanzhou -- Sorry, I didn't realize you had already started on this.)


[CWS] Fix CWS instrumentation user

What does this PR do?

This PR adds a default user for the cws-instrumentation init container as well as the same default user in the injected init-container of the CWS instrumentation admission controller.
Motivation

This change was necessarily to support pods that have a runAsNonRoot security context applied generally (as opposed to security contexts defined per container in the pod definition).
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


After viewing the resource definition, navigating to other pages may trigger unexpected confirmation pop-ups

Describe the bug

Steps to reproduce

Create a general user.
Log in to Walrus as a general user.
Go to Operations -> Resource Definitions. Select a resource definition and view all the tabs.
Go to another page.

https://github.com/seal-io/walrus/assets/26084756/667ebb92-31cb-44ec-92ff-9ad7829afced
Result

After viewing the resource definition, navigating to other pages may trigger unexpected confirmation pop-ups
Expected behavior

No confirmation pop-ups appear if there are no modifications made.
Environment

Walrus version: v0.5.0

Additional context
Add any other context about the problem here.

Environment

Walrus version: main eb8e29d68c15d16e0fe6b1bc95dca3bdab96a454
UI version: dev-bb86dbc

Test Result: pass


Fix VS2005 build environment

Ever since the development tree was placed into GitHub, native code (i.e, non-Java) couldn't be built using a "standard" installation of VS2005, DirectX SDK & SDK6.1.  Once we're first able to fully build using VS2005, it will be much easier to take the next step of replacing VS2005 with VS2015.

I just fixed the one issue I was aware of which was that the solution file didn't have some of the paths to projects correct. They should be correct now in GitHub.
Other than that...there was a dependency on the DirectX SDK BaseClasses; so those needed to be compiled as well. But beyond that it should all build find in VS2005 (and it all did build for me before it was released).  There are currently efforts underway by others on the forums for getting it to build with something much more current than VS2005 and they're making really good progress on it...I know they already have the EXEs built with it.

Although there was some earlier discussion about getting this to work under VS2015, the last I've seen in the Forum was from wnjj on 9/12 who said "that's only part of getting this going. I'm off on something else for now."   There was success with building the exe's, but I never saw any success with building the .ax and .dll files.  I haven't been able to build them from the repo.  Looked for an open Issue where someone else is actively following thru, but didn't spot one.  Definitely don't want to duplicate effort.  Maybe I missed something.
I'm aware that the DirectShow BaseClasses need to be compiled outside the existing Solution, but there still seem to be additional issues.  Although the Solution undoubtably was buildable some time ago,  the existing VS build env. doesn't completely build with a "standard" clean installation of VS2005, the final DirectX SDK (June 2010) and Platform SDK6.1.  In examining the .vcproj files, I see they expected an odd merger of DirectX SDK and Platform SDK files within the same DXSDK_DIR path.  Was that normal in some older version of SDKs?  Or maybe an indication of a rather "creative" toolset installation some time ago?  There were also references to a hard-coded C:\DXSDK path; probably not something MS has done for awhile.  Also, MS has omitted a critical file (dxtrans.h) from the final DirectX SDK (June 2010), so that needs to be taken into account.  I was also planning to commit the missing hcwIRBlast.lib file.  I've written a HOWTO doc for installing and configuring the above toolset and a concise list of the needed environment variables, since the "VS2005 build environment thread" has quite a range of info; some of it conflicting, but nothing all in once place.

Cool, I didn't realize you had been following along on the forums. :)  I
definitely did hardcode the C:\DXSDK path because that's just where I
happened to install the DXSDK many years ago. So there will likely be path
issues that need to be resolved in the build (but looks like your way past
that).
Looking forward to someone committing the fixes to get this built in a
modern environment and having a doc on how to get it all set up! If you
have any other questions for me, feel free to ask.
On Mon, Sep 28, 2015 at 4:25 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

Although there was some earlier discussion about getting this to work
under VS2015, the last I've seen in the Forum was from wnjj on 9/12 who
said "that's only part of getting this going. I'm off on something else for
now." There was success with building the exe's, but I never saw any
success with building the .ax and .dll files. I haven't been able to build
them from the repo. Looked for an open Issue where someone else is actively
following thru, but didn't spot one. Definitely don't want to duplicate
effort. Maybe I missed something.
I'm aware that the DirectShow BaseClasses need to be compiled outside the
existing Solution, but there still seem to be additional issues. Although
the Solution undoubtably was buildable some time ago, the existing VS build
env. doesn't completely build with a "standard" clean installation of
VS2005, the final DirectX SDK (June 2010) and Platform SDK6.1. In examining
the .vcproj files, I see they expected an odd merger of DirectX SDK and
Platform SDK files within the same DXSDK_DIR path. Was that normal in some
older version of SDKs? Or maybe an indication of a rather "creative"
toolset installation some time ago? There were also references to a
hard-coded C:\DXSDK path; probably not something MS has done for awhile.
Also, MS has omitted a critical file (dxtrans.h) from the final DirectX SDK
(June 2010), so that needs to be taken into account. I was also planning to
commit the missing hcwIRBlast.lib file. I've written a HOWTO doc for
installing and configuring the above t oolset and a concise list of the
needed environment variables, since the "VS2005 build environment thread"
has quite a range of info; some of it conflicting, but nothing all in once
place.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/issues/36#issuecomment-143900690.

--
Jeffrey Kardatzke
<EMAIL_ADDRESS>Google, Inc.

Yeah, been lurking in the forums (JustFred) ever since my initial Sage6 installation quite a few years ago.  Really itching to get to the point where I can fix a bug in the channel-scan stuff (introduced in Sage7) that skips a C-QAM channel that has a mixture of clear and non-clear streams.  But gotta get the toolchain working first.

Unfortunately, ae41796cfa9b70e2104ee6ea844ed5d268eedabc introduced changes that are fundamentally incompatible with VS2005 and it's libraries.  That commit breaks the build under the current build environment.  Best resolution is to move forward and migrate from VS2005 to VS2015.  I'm going to close this issue and open another for updating to VS2015.

Yeah, that doesn't surprise me it broke it...but those were essential
changes for 64-bit compatibility. Thanks for taking this on. :)
On Sun, Oct 11, 2015 at 12:07 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

Unfortunately, ae41796
https://github.com/google/sagetv/commit/ae41796cfa9b70e2104ee6ea844ed5d268eedabc
introduced changes that are fundamentally incompatible with VS2005 and it's
libraries. That commit breaks the build under the current build
environment. Best resolution is to move forward and migrate from VS2005 to
VS2015. I'm going to close this issue and open another for updating to
VS2015.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/issues/36#issuecomment-147235682.

--
Jeffrey Kardatzke
<EMAIL_ADDRESS>Google, Inc.


Setting-Question

1- Any prediction of using the character list and not for kakera value?
2 - An option that I have never seen in any is to get a certain type of waifus-only kakera that you have key lvl 10+
I think to make it easier I could have another list that tells you the waifus that has a key level of 10+ and if it appears with, for example, orange kakera the bot picks it up. Because they have a lower kakera power value

1 - I'm not sure what you mean by this one but if you have a formula I could possibly implement it
2 - that could be possible. do you mean like an option to only snipe kakera on soulmate chars ?

1 - Did you mean sniping a character not based on Kakera value ? you wanted to snipe characters via there name or series ?
if so currently I only have implement "Series" based sniping and I left Character name sniping up to wished characters so if
"Message.content" contains your @(user.id) then it also is "claimed"

2 - So im not sure how soulmates work cause none of the servers im in have users with "soulmates" does it only apply to you ? and if it does how does it differentiate between your soulmate and lets say another "Player's Soulmate"
The Idea I have is to still use the same Kakera_list but add a check for :choaskey: within a option that can be set to only snipe key'd characters as that is the only thing that will not change between "language" Versions
This way its more universal and faster than checking a list of characters each time a character is rolled but im unsure how it would not snipe someone elses soulmate kak

Sorry, I'm not without English. I'm using the translator.
1 - List of characters that should be claimed
2 - There is no way to differentiate your soulmate during the roll from someone else, because there is no message.

The only thing I was able to think would be more "easy" would be for the person to define a $ embedcolor for all their soulmates and the bot to react to only these (I don't know if it is possible) and again to be able to define which kakera to take

It is okay I trying to work with you to the best of my ability.
1 - I can implement Character list matching but I will implement char list as "Exact" match only to avoid sniping the incorrect characters
2 - since this feature you want is more "Endgame" or more professional players sided I will not mind implementing that function were is includes a key and includes that embedd color just give me a few secs to work it out on my end and I will let you know if there are any issues

1 - Perfect, if you can not be case sensitive
2- Thank you

1 - yes it will not be case sensitive as It will convert to lower but has to be an Exact match
Ex. Mudae Roll ( Raiden Mei)  Namelist { Raiden: False} { Mei :False }  { raidenmei : False } { RaIdEn MEI : True}
2 - When I implement you will need to test it as I do not have soulmates myself and tell me what is happening to best of your ability

Changes have been implemented. I will close this issue for now
Feel free to reopen if there is a bug or issue that arises from the new code

Thanks for the implementations
I used "SoulmateKakSnipeOnly": "True", and yet he tried to get an orange kakera that was not a soulmate. I thought it was all right, because the first one that appeared was a soulmate kakeraL

"SoulmateKakColorValue":"#0004ff", and this value was set correctly ??

so change that value with $ec and then transfer that value to the settings
and could u send me the one that was tried ? with the Embedd color being part of the picture

Is there a way to define which ones to get out of SoulmateKakColorValue? Because he ignored a KakeraR that did not have embedcolor defined.

I realized that he keeps trying to get kakera even if he has finished the kakerapower, would it be possible for him to use the number informed in "You can't react to kakera for X min. ($ Ku)" so that he makes a new attempt?
I have other servers that I don't play but the bot keeps monitoring and reporting this here all the time

He started to show this error after I added a character in "namelist"
This is my configuration

I deleted the token, channel_id and SoulmateKakColorValue for security

Yes you add the character to the namelist

this is happening because people are calling things like "$vote"

that has a Embed but no name "value" to call .lower() on this is orginally why I didn't add namelist but I will eventually work it out

The embed color was set because orginally you said that you only want to snipe your own soulmates because it uses half power otherwise use the non soulmate function which can be done by setting SoulmatekaksnipeOnly: "False"

If it snipe in the researching channel I think I edited to code to inform you on which channel it rolled
The bot purpose was to be able to snipe on ALL channels as its a Multi-channel bot

there is a method to implement this for example the Rolling method within my code as it would be the only way to check each server but will be less stable since it has to await Mudae response and if someone else is rolling or a response is await it never gets them it will stop sniping kaks as the Kak bg_task() errors out
The Multi channel is a feature as stated in my readme

I personally will not be adding it to the code but

this is how you would code that in if you wanted but I will not be adding that as it could take away features that others enjoy

1 -I would have both options at the same time, defining which ones I want to be caught with SoulmateKakColorValue and also without ?
2 - If I want it to work only on 1 channel, would it be possible to ignore all the others?
3 - At the end of the roll when it reaches the maximum value and receives the message "the roulette is limited to X uses per hour" It runs again not giving this error, and everyone can understand that this is a bot
As he has these actions as well as trying to get kakera even if he does not have kakera power, people soon understand that it is a bot / script

1 -I would have both options at the same time, defining which ones I want to be caught with SoulmateKakColorValue and also without ?

this seems like a very specfic case so
`newvar = Kakeravari.remove("kakerao")
newvar = Kakeravari.remove("kakeral")
if(reaction.custom_emoji and reaction.emoji.name.lower() in newvar):
await asyncio.sleep(kak_delay)
print(f"{reaction.emoji.name} was detected")
await reaction.message.add_reaction(reaction.emoji)
`
somewhere in the on_reaction_add event

2 - If I want it to work only on 1 channel, would it be possible to ignore all the others?
I personally have not code it in but you can add and message.channel.id == channelid  and reaction.message.channel.id == channelid in location in images below

3 - At the end of the roll when it reaches the maximum value and receives the message "the roulette is limited to X uses per hour" It runs again not giving this error, and everyone can understand that this is a bot

It runs again to set wait times as it takes advantage of people tendency to "forget" if you worried about kakera snipes since you are only running it on one server you can add
await asyncio.sleep(x)
X being set to the seconds you wanna wait before you attempt to snipe again

EDIT: I thought the "channel id" - channel id for function / claim And "multichannel" was to put the IDS of the channels that I wanted him to monitor

both these are for "Rolling Features" only

It runs again to set wait times as it takes advantage of people tendency to "forget" if you worried about kakera snipes since you are only running it on one server you can add
await asyncio.sleep(x)
X being set to the seconds you wanna wait before you attempt to snipe again

I'm doing a test on 1 server, but my intention is exactly on 3 and not on more than 10 servers that have this bot, but I don't play, not to mention that these servers usually have 2 rooms, one to roll and one to use $ im and the bot ends up reading this too and reacting to the character in the "namelist"

that these servers usually have 2 rooms
There are several cases where this is not true as one of my servers only have 1 channel both for rolling  and management
but ultimately as the amount of server increase the most stable would be to react to all kakera with maybe like a 10 sec delay
because there are cases in my testing with where someone else was rolling and it basically timedout the task so in regards to stability across all servers keeping it within the on_reaction_add event is more stable

in case of Management servers and rolling servers as stated above

but instead of adding message.channel.id == channelid and reaction.message.channel.id == channelid
to message.channel.id in multiids and 'reaction.message.channel.id in multiids' to their respective locations  or as an
alternative
add a check for embedd color to the name sniping function

 remove ":"

One last question, since I am being very annoying with these questions, if I wanted to change the rolling speed, where can I change it?

await asyncio.sleep(2) >> 2 changed to different
and its fine I'm just trying my best to help while trying to understand your questions but alot of your Request are very specific in terms of what you want which is why I posted the code to add but I didnt want to make it more complicated for other users that are not at your level of play yet
Some users just want basic features and I don't want to overly complicated it for them but also trying to help you get what you want

I am very grateful for all your help, the things I said are really for those who play more hardcore or have their own server to farm level key and soulmate

well if enough hardcore players request features I will implement it or maybe implement a seperate code towards more advance features but as of right now only a few people are using the bot and just been doing this in my free time to see how much I could do using only the discord.py library

I tried to understand how to make it only run on the channel_id that I want, but since I don't understand anything about programming I couldn't, I'll keep using it only when I run it, because if I leave it open, I'll end up banning it on some server.
Thanks again for the help

well if u only want specific servers I let you know what to add in which locations in the code in previous comments
its only adding
and message.channel.id in multiids and  and reaction.message.channel.id in multiids
that code will limit the servers that it will check in

Line 97 change to:     if message.author.id == mudae and message.channel.id in multiids:
line 140 change to:  if (reaction.custom_emoji and reaction.emoji.name.lower() in KakeraVari) and reaction.message.channel.id in multiids :
for the Kak function you want:
insert at top under KakeraVari=:
Nosoulkak = Kakeravari
Nosoulkak.remove("kakerao")
Nosoulkak.remove("kakeral")
line: 152 add code:
if(reaction.custom_emoji and reaction.emoji.name.lower() in Nosoulkak):
await aysncio.sleep(kak_delay)
await reaction.message.add_reaction(reaction.emoji)

You are wonderful, I will try to do that I will give you the feedback, THANK YOU SO MUCH

no problem u will just need to add that code again if I do push more changes that you actually want and if you submit issues or question
please remind me that I informed you to add extra lines of code so im not looking around for the code in question

insert at top under KakeraVari=:
Nosoulkak = Kakeravari
Nosoulkak.remove("kakerao")
Nosoulkak.remove("kakeral")

Would it be this? I just didn't understand how it works
I left it to add this last, so I can follow the correct line

yes it looks correct basically
Nosoulkak = KakeraVari

NoSoulkak = ["kakera","kakerap","kakerao","kakeral"]

noSoulKak.remove("kakerkao")

NoSoulkak = ["kakera","kakerap","kakeral"]

NoSoulkak.remove("kakeral")

NoSoulkak = ["kakera","kakerap"]

that what it does as a example

what can cause this?
Even making the changes I was on another channel that is not "channel_id" and he took a character that I did not put on the "namelist"
In fact I just left it to run, and I didn't put anything in "namelist" or "series_list", in "min_kak": I put<PHONE_NUMBER>00.
Another thing was that he used an emoji ❤, but the bot uses the one below:

A negative point is that I can't see what the bot is doing, I don't know if it is reacting to some kakera / waifu and which channel / server, to make sure the settings are correct.

The issue that cause Channel id rolling to die is that someone else rolled during the bot rolling
so the bot is awaiting for self.user.name to be return with a wait time to be set
for example your rolling $mg but someone else also rolls $mg at the same time it returns his rolls the
Rolling code hits its timeout (This is to avoid constantly spamming the channel) and when it time out its stops the background task to avoid spamming the channel since it does not get the desired "message.content"
/////////////
this is also why I said that its more stable to not run kakera snipes in a background task as background to get the wait feature if it hits a timeout then you have to restart the program

A negative point is that I can't see what the bot is doing, I don't know if it is reacting to some kakera / waifu and which channel / server, to make sure the settings are correct.

this was fixed in the newest version I think cause it should print
like claimed
Waifu in channel.id and then channel.name
unless you are referring to kakera ? I can add it real quick if you just want to know which server is comes from

Another thing was that he used an emoji ❤, but the bot uses the one below:
this is because It set in the code to use that emoji the reason is that ❤ and 💖 are partial emojis and do not have a name

as you see here in the code there is the ❤ icon directly in code and #use_emoji this is to set custom emoji

custom emojis tho can have a name of :Customemoji:4444160910902931:  which only issue with that is that unless you have discord premium  you cannot use custom emoji on server your custom emoji is not on so if you really want to react with 💖
then change ❤ to 💖 in the code because these emoji's have no name and you have to use the emoji in the code itself

same thing with the event reacts you have to add 🕯 if you add :candle: this is invalid even tho they are the same only 🕯 will work in the code

Even making the changes I was on another channel that is not "channel_id" and he took a character that I did not put on the "namelist"

this might because I only told you to add the channel checks in the areas that mattered there might be some residual code that hasn't been filtered out

I added changes to be able to get Kakera snipe cooldowns it still needs testing but I think it should work now

It would be possible to have the following options:
1 - Select only 1 server to monitor
2 - Select 2 or more servers choosing which one
3 - The standard currently where it monitors everything
I realized that he only reacts to the kakera of key 10+ characters when I'm rolling, or when others are rolling right away, but after a while even someone rolle a soulmate of mine the bot ignores.
Would it be possible to appear Name of the server and room? currently it shows the room ID and name, making it impossible to know the server.
Or even choose to receive a notification?
Sometimes there is a crash during the roll, in which case the bot returns after a while or is it necessary to reopen?
Even making the suggested changes, "Free Kakera was detected in" still appears on other servers.
When I make these changes here, the error bot does not open, I kept only the changes from line 97 and 140

I can Implement the Room ID >> into server name but all of the others I have already addressed that you can just add
and message.channel.id in multiids and and reaction.message.channel.id in multiids to each of the respective checks
since new code was added to be less spammy and do checks based on time recieved via mudae
you change in KakeraVari to in Nosoulkak in the code

I've fixed the Channel id name and turned it into the Server Name : Channel Name for ease of understandablity
I've also made changes to the on_reaction_add code so that way if you want to scale it down to specific channels it is as easy as adding a single line of code yourself.

Even with the update he is getting free kakera on any server, so I will end up being banned from somewhere, as I only have an interest in using it on a single server. to use in more than one, it’s more viable for me to open a bot for each one, because each of you will have different waifus or different level of badges

change if message.author.id == mudae: >>> if message.author.id == mudae and message.channel.id in [111111,22222]:

change if user.id == mudae: >>> if user.id == mudae and reaction.message.channel.id in [111111,222222]:
or change [11111,22222] to in multiids and use that variable
those changes should get you what you want
personally this selfbot is a multiserver bot implementing this change would take away from the multiserver portion and add more checks that will ultimately slow down run times the more it scales up

Thanks for the quick support btw, I gladly appreciate that.
Multiserver bot is interesting when you participate in a few servers that have mudae and you play on all of them, but unfortunately I participate on many servers that I didn't even know I had, I found out when I ran this bot and he went there and got kakera free, as well as mudeworld.

yes to limit servers change those to the specific channels that it will check in.
If there are enough users wanting me to change it to limited scope I will change it but right now only two users have requested that and I don't want to make setting up more confusing for the people who use it already

This is normal?

With the update even putting to catch only kakeraO of the soulmates he is catching anyone

with update there is another code that snipes that is why is it sniping any one

not enough information but it seems a non character thing was provided by mudae that doesnt have description tag

with update there is another code that snipes that is why is it sniping any one

So what is the point of having the soulmate sniper if you are going to spend the whole kakera power inefficiently?

not enough information but it seems a non character thing was provided by mudae that doesnt have description tag

The bot is running together with mudefarm and it worked normally
I'm using like this

So what is the point of having the soulmate sniper if you are going to spend the whole kakera power inefficiently
I already explained how you can make edits so it fits what you need it to snipe

again I do not have soulmates so the code is kept in specifically for you I can't test the code , I can't use the code there is no purpose of that portion of code for me hence I can't not make improvements.
as for the second part the error appears because there is a Embed that doesn't have a description field so it errors out
Im unsure what mudae farm has to do with anything with the error ??

Sorry if I looked rude at some point, it was not my intention I am quite grateful for all the help you have been giving.
You don't need soulmate to take the test, just make things work like this:
With embedcolor set pick up kakeraO, KakeraL
Without Embled
KakeraP
KakeraR
KakeraW

Again making it work that like that is very "Specfic" to what you want. other people use this program to and might not only want to snipe P , R , W
anyway i added a new variable that interact with the soulmate kak sniping so u can set it up from there

The old version I have here is already helping this server with soulmate, too bad it doesn't detect the ones that other people roll, the new version is working wonderfully on the server where I don't have to worry about it.
Thank you very much for the bot.


added some languages

This update adds Spanish, French and Portuguese languages from Portugal and has been revised with Google Translate and Bing Translator for better word agreement.

Thans!


[ROCKETMQ-3] Clean up unit tests, remove try...catch, using assertNull etc

Remove try...catch, using assertNull etc

@WillemJiang I am sorry to bother you so many times. A new pr is created for squashing. And I will take care of my commits carefully next time.

There is only one line change here after rebasing the codes. I just commit the patch into master branch.

@shroman cool, we will add code-style parts in website. Every guys could comment it and help us to perfect it :-)

This PR could be closed for the code has been merged into apache master.

Please using the mailing list to discuss the code-style issue.


links: use record's public id i.e. record.id

This fixes some issue experienced generating links when the record doesn't use a pid system field to generate its public id. (e.g. in requests / request events)

Don't merge this in. I wasn't able to install the dependencies locally (too long), so I was hoping the CI would be able, but the CI is breaking on something else (I think?). Needs further investigation.

Faking the interface in invenio-requests is the way to go until this is better defined.


Adding bar search in apps menu

Hello,
Thanks a lot for this solution,
Is it possible to add a bar search (similar to power BI server) allowing users to search apps ?
Thanks,

Hi
We don't have out of the box support for searching for apps. You could implement this yourselves by adding some javascript to the shinyproxy templates. For example, you could use the API to search for a list of applications.
See https://shinyproxy.io/documentation/api/ and https://github.com/openanalytics/shinyproxy-config-examples/tree/master/04-custom-html-template for more information.
I'll keep this issue open as a feature for request for a built-in search function.

Hi,
I don't know if i can help you in some way with my code, but I added this lines to index.html in order to show a search bar:

...

			<input type="text" name="searchbox" id="searchbox" class="filterinput form-control"
				placeholder=" Buscar módulo..."
				style="font-family: FontAwesome, Arial; font-style: normal">

...
...
...

I hope it can help you!


fix: Xcode 12 compatibility

Summary
The latest Xcode 12 fails to build when a module does not depend on React-Core directly. This change is necessary for all native modules on iOS. For details please see: https://github.com/facebook/react-native/issues/29633#issuecomment-694187116

Test Plan

Build an App with Xcode 11.x. Result: The app builds.
Build an App with Xcode 12. Result: The app will not build when depending on React.
Build an App with Xcode 12 with the PR changes applied. Result: The app builds.

What's required for testing (prerequisites)?
macOS with Xcode 12
What are the steps to reproduce (after prerequisites)?
see Test Plan
Compatibility

OS
Implemented

iOS
✅

Android
❌

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Lottie is a Swift library, so you should check if this problem does not occur https://github.com/facebook/react-native/issues/29633#issuecomment-694700346

Lottie is a Swift library, so you should check if this problem does not occur facebook/react-native#29633 (comment)

You are right, @radko93, I re-checked my PR. Thought we updated and tested the change as well in our latest project, but it looks like I confused some package here. Closing this.


executeUpdate only return 1 for mulitiple row insert.

String sqlStr="insert into tab1 values (1, 'a'), (2, 'b);";
int ret = stmt.executeUpdate(sqlStr);
"ret" is always equal to one, it should return 2 for the above example. The same statement returns correct result in "clickhouse-client", that is, "2 rows in set. Elapsed: 0.023 sec."

Fixed on develop and will be released as part of 0.2.6. You'll need to set query parameter send_progress_in_http_headers to true.

hi, @zhicwu
it seems same issue in 0.3.1-patch


Add catAxisMinVal and catAxisMaxVal

Specifically for Scatter/Bubble charts.

Thanks @vrimar !
Added new options to Chart Slide 13: "Using catAxisMinVal/catAxisMaxVal"


Updated interaction model and manifest, renamed HelloWorld intent to QuestionIntent

Also did a tidy up to comments and code lines that were wrongly formatted.

Thank you for the review @inverse! I additionally added a privacy policy and terms of use files that we can use to link in the skill manifest 👍
Will leave this PR open for some time in case some more detail comes up.


Add NWB support for project schema, pre-commit and markdownlint

This PR should be merged after #41
Submission checklist

[x] Reviewed all Files changed prior to selecting Create Pull Request.
[X] Ran and passed all pytests, and ran the pipeline for features not covered by tests.
[X] Ran pre-commit checks, including black, flake8, etc.
[x] Updated the changelog and if making a new release, updated the version.py.
[X] Updated documentation, including concepts.md, tutorials.md, and relevant docstrings.
[x] After merge, I will push a new tag to upstream (test* prefix if no new release).

Submission details
In this pull request, I make the following changes:

Markdown linting: standardize structure of markdown docs

markdownlint.yaml: Specify nature of checks and specify items ignored, consistent across all elements
CHANGELOG - add spacing
CODE_OF_CONDUCT - ensure first line is H1
CONTRIBUTING, README, concepts - hard wrap and add spaces around headings/codeblocks
cspell.json add spellcheck config

Pre-commit: ensure black and various other checks are enforced before each commit - standard across elements

.pre-commit-config.yaml - specify which checks
element_lab/export/__init__.py - ass __all__ for unused import

Changelog - add notes on pre-commit and markdown linting
CONTRIBUTING- update link to new docs
element_lab/export/nwb.py - add support for new project schema. Defaults to pulling from lab tables.
Update documentation and diagram

Thanks @CBroz1 for the effort. Looks good to me.. Is this good to be merged or are we waiting on #41 ?

Yes, still waiting for #41

@CBroz1 Now that #41 is merged.  Please pull from upstream to fast forward this pull request, and I will review and merge.

Thanks @kabilar. I've fetched from upstream

Thanks for your feedback @kabilar. I believe I've incorporated each of your suggestions, updating documentation to reflect other elements

Version 0.2.0 is now tagged and released.


uiua: 0.12.3 -> 0.13.0-dev.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for uiua is: Stack-oriented array programming language with a focus on simplicity, beauty, and tacit code
meta.homepage for uiua is: https://www.uiua.org/
meta.changelog for uiua is: https://github.com/uiua-lang/uiua/blob/0.13.0-dev.1/changelog.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.13.0-dev.1 with grep in /nix/store/j2j4jfj95a1a2k0nf6sqglf7p6mqfhmz-uiua-0.13.0-dev.1
found 0.13.0-dev.1 in filename of file in /nix/store/j2j4jfj95a1a2k0nf6sqglf7p6mqfhmz-uiua-0.13.0-dev.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

uiua
uiua386
vscode-extensions.uiua-lang.uiua-vscode

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j2j4jfj95a1a2k0nf6sqglf7p6mqfhmz-uiua-0.13.0-dev.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A uiua https://github.com/r-ryantm/nixpkgs/archive/162631be2b7a5cd8a2d1d54cc1f0e51d49074ab5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/162631be2b7a5cd8a2d1d54cc1f0e51d49074ab5#uiua

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j2j4jfj95a1a2k0nf6sqglf7p6mqfhmz-uiua-0.13.0-dev.1
ls -la /nix/store/j2j4jfj95a1a2k0nf6sqglf7p6mqfhmz-uiua-0.13.0-dev.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

uiua
uiua386
vscode-extensions.uiua-lang.uiua-vscode

Maintainer pings
cc @cafkafk @TomaSajt @Defelo for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343848 run on x86_64-linux 1

3 packages built:

uiua
uiua386
vscode-extensions.uiua-lang.uiua-vscode

I'll merge when ofborg is done (and/or stuck on darwin passthrou), if I forget feel free to ping me :)


Codegen Message Start Event: Incorrect endpoint generation: endpoint is requiring instance id

Describe the bug
Docs on Message Start Event: https://docs.jboss.org/kogito/release/latest/html_single/#ref-bpmn-start-events_kogito-developing-process-services
Consider a process such as:

This configuration is generating endpoints with:

Based on how Message Start Events are supposed to be used ("to start process instances"), this generated endpoint is unexpected and appears wrong.
Expected behavior
Would expect a POST endpoint to be generated that sends the message and filtered by the specific application and not the process instance, as there would not no instance (as it is a start event)
Actual behavior
The endpoint is generating the following code:
return processService.signalProcessInstance(process, id, null, "My Signal").orElseThrow(() -> new NotFoundException());

which runs:
    public <T extends MappableToModel<R>, R> Optional<R> signalProcessInstance(Process<T> process, String id, Object data, String signalName) {
        return UnitOfWorkExecutor.executeInUnitOfWork(application.unitOfWorkManager(),
                () -> process.instances().findById(id)
                        .map(pi -> {
                            pi.send(Sig.of(signalName, data));
                            return pi.checkError().variables().toModel();
                        }));
    }

This does not seem to be the intended behaviour given it is a Start Event.
How to Reproduce?
No response
Output of uname -a or ver
No response
Output of java -version
No response
GraalVM version (if different from Java)
No response
Kogito version or git rev (or at least Quarkus version if you are using Kogito via Quarkus platform BOM)
No response
Build tool (ie. output of mvnw --version or gradlew --version)
No response
Additional information
No response

This code also makes me ~worry about performance on large number of instances?  What is there were 500,000 active instances of a specific process definition.  Are all of these instances loaded into memory for something like signal?  The underlying process.instances().... code seems to query everything from a concurrentMap

Opened JIRA

As per the performance concern, @StephenOTT, when persistence is active, process.instance() will be translated to a DB query (which I do not know if it worse or not, just kidding), so in real deployment scenario not all process instances will be in memory.

Some further comments that I have added into the JIRA ticket:
Some further thoughts on this:
Experimenting with a Message and Signals with the Codegen, some thoughts on the semantics of the design:
When a Signal or Message is detected in an App's BPMNs:
Should there be generic Message and Signal endpoints generated which allow a Message/Signal Name param (+var inputs).  This would allow easy semantics of Cross BPMN messaging.
Should Message/Signal endpoints be generated under the specific BPMN section of endpoints which allow the same as #1, BUT are filtered for the BPMN definition. + has param to filter against a specific process instance.
The difference between the two are, the detection of messages or signal events in BPMNs means it could be a event sent to one or many instances across one or many definitions, where #1 handles the Multiple BPMN, and #2 is handled for target messaging within a single BPMN scope.
This would also help from a security standpoint: allowing control at the endpoint level to ensure that people who have access to one BPMN are not messaging into other BPMNs.


Different codes between npm and git

Hi.
If I install your module via npm command, there are many typo in your code and required rpio.
However, on your git site, there are different code and dependencies in package.json...
Would you update for npm?
Mitwave

@mitwave I have released 0.0.2 to contain the latest changes that were in master. The library still isn't in a complete state and I've found it doesn't work quite as well as the Python library provided by Pimoroni, however, I believe it can with more work. The transitioning just doesn't appear to be as fluid and I can't work out why and have little time to do so. This is a pet project but I'll hopefully be able to work it out eventually, given time.
Let me know how you get on with it.


Nifi performance

Nifi performance - csv (event) + processor group → python transformer → output csv

I/O1:
Input: csv (school_id, grade_id, count) - count of students by school, grade - 5k records
Output: csv (school_id, count) - count of students by school
I/O2:
Input: csv (Date,school_id, grade_id, total_sudents,students_attended) - percentage of students by grade,
5k records
Output: csv (Date,school_id, grade_id,student_attendance_percentage) - attendance percentage by students present
I/O3:
Input: csv (school_id, semister,grade_id,subject_d,student_id,obtained_marks) -  count of students who has
scored above 35, 5k records
Output: csv ('school_id','semister','grade','subject_id','number_stud_scored_above_35') - count of students
by subject

3 distinct processor groups :

read the input csv
do group by operation
upsert to output csv

Invalid

Moved to JIRA


onEnterRules in language configuration seems to break editor

When a language configuration file contains onEnterRules, the editor seems to choke on them any time the [Enter] key is pressed. I get an error each time says Uncaught Error: e.reg.test is not a function, which sounds like it's attempting to apply the rules but it's not recognizing them as a proper Regular Expression.
The only way I've found to fix this is to delete the onEnterRules. Are these rules explicitly unsupported, or is there something I can do to get them working? It looks like Monaco supports them by default, but perhaps they weren't implemented here when the textMate grammar support was added.

I figured out a bandaid solution to this, as I haven't tried to puzzle through a proper solution. The getProp() and setProp() functions in configuration.ts expect to receive objects, but onEnterRules is an array of objects. Since the objects don't have keys (but do have indexes), my solution was to just define each rule inside the REGEXP_PROPERTIES declaration a bunch of times. Messy, but it does the trick.
const REGEXP_PROPERTIES = [
  // indentation
  'indentationRules.decreaseIndentPattern',
  'indentationRules.increaseIndentPattern',
  'indentationRules.indentNextLinePattern',
  'indentationRules.unIndentedLinePattern',

  // code folding
  'folding.markers.start',
  'folding.markers.end',

  // language's "word definition"
  'wordPattern',

  // on enter actions
  'onEnterRules.0.beforeText',
  'onEnterRules.1.beforeText',
  'onEnterRules.2.beforeText',
  'onEnterRules.3.beforeText',
  'onEnterRules.4.beforeText',
  'onEnterRules.5.beforeText',
  'onEnterRules.6.beforeText',
  'onEnterRules.7.beforeText',
  'onEnterRules.8.beforeText',
  'onEnterRules.9.beforeText',
];


Improve compile times with new Anchorage syntax

This PR improves compile times by using the new syntax provided by Anchorage.
Instead of ==, we now use |==|, for example.
This one change brings compile times from ~4m55s to ~3m22s.

This is amazing!! Thank you!


when will apollo configuration be supported?

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)
no
Describe the solution you'd like (描述你期望的解决方法)
I need apollo configuration
Describe alternatives you've considered (描述你想到的折衷方案)
no
Additional context/screenshots (更多上下文/截图)

Hi, thanks for your issue, but can you provide some detailed information about the apollo configuration?

Hi, thanks for your issue, but can you provide some detailed information about the apollo configuration?

https://github.com/ctripcorp/apollo
Apollo is a reliable configuration management system. It can centrally manage the configurations of different applications and different clusters. It is suitable for microservice configuration management scenarios.
The server side is developed based on Spring Boot and Spring Cloud, which can simply run without the need to install additional application containers such as Tomcat.
But there isn't cpp SDK

I think we will not support apollo in brpc framwork recently. It is not an essential function for brpc.


Assimilate techniques from other install scripts

Probably also seek out other installers.
Phabricator:
https://secure.phabricator.com/diffusion/P/browse/master/scripts/install/install_rhel-derivs.sh
Add more below

Also, Mike's presentation from SMWCon Spring 2015

Also, this may be a good read: http://www.davidpashley.com/articles/writing-robust-shell-scripts/

So we don't need to run the install with sudo (bad practice), but instead can use sudo throughout without having to type in the password all the time, perhaps we should add this to /etc/sudoers:
Defaults    timestamp_timeout=-1
This makes it so the sudo password timeout is infinite, and sudo password will only need to be asked for once. At the end we could set it to 5 minutes or something:
Defaults    timestamp_timeout=5.
Additionally, /etc/sudoers includes this line at the bottom, which may make it easier to temporarily set the timeout to infinite and remove the requirement at the end:
## Read drop-in files from /etc/sudoers.d (the # here does not mean a comment)
#includedir /etc/sudoers.d

Ref: http://apple.stackexchange.com/questions/10139/how-do-i-increase-sudo-password-remember-timeout


'Runner-Swift.h' file not found

We are importing 'Runner-Swift.h' for a native SDK in code.

After adding flavours the default app works fine but the flavoured app throws error:
Lexical or Preprocessor Issue (Xcode): 'Runner-Swift.h' file not found

Hello @Gaurav-CareMonitor , have you tried with this?

Tried didn't work


[ONGOING] Add Resource/Plugin/Widget

Do you know an open-source resource, plugin, or widget that's not already on this list? We'd love to spotlight the members of our community!
Go ahead and create a PR following our Contribution Guidelines
You can tie your PR to this issue. This issue will remain open as an ongoing task.

Can i work on this?

Hi @Rudy-Menekam - is there a plugin, widget or resource that you want to add to the list?

Yes sir @akbarbmirza


Rename UseIIS() to UseIISIntegration()

It looks strange to have UseIIS() and UseKestrel() in the same call chain when this is really about integrating with IIS while still using Kestrel. Plus it means the name lines up with the package name, etc.

/cc @Tratcher

It seems that integration is tied to kestrel anyway or will there be future different combinations.

Kestrel is replaceable. WebListener isn't compatible with AspNetCoreModule right now but we'd like to make it work in the future. You can also plug in 3rd party servers.

Create an announcement.

Updated the prior announcement.

@phenning FYI

@Tratcher close?

@Eilon There's still a few repos to clean up. Templates, Performance, cli-samples, etc..

@Tratcher
Rename UseIIS() to UseIISIntegration()
It seems that this change is in rc3 Package is that intentional?
1.0.0-rc2-20383 UseIIS()
1.0.0-rc3-20540 UseIISIntegration()

It's in both, release is at rc2-20539

Ah I see I am only picking up 20383 on cidev
Thanks

Looks like I should be moving to the vnext feed for the buildup to rc2 now?

As far as I can see vnext is the latest package for rc2 currently
at
1.0.0-rc2-20466

You should use aspnetcirelease if you're tracking the RC2 packages.

Got it thanks now at 20539.  There might be other like me who want to track rc2 to release.  If there is no announcement maybe an issue post in Home?

@mikes-gh I mentioned this on an existing announcement and updated the sample code. https://github.com/aspnet/IISIntegration/issues/105#issuecomment-207051587

@Tratcher  thanks
Actually I was referring to an announcement for the change of feeds to continue using updated rc2 packages
There is an article of feeds but I hadn't realised release was now the active branch (and others might not also).


Fix Pass customImageRenderer to ViewComponent

Passing customImageRenderer like indicated in the docs doesn't seem to work, after passing it to the ViewComponent it works
Usage example:
<ProGallery
  items={items}
  options={options}
  container={{
    width,
    height,
  }}
  eventsListener={eventsListener}
  scrollingElement={scrollingElement}
  customImageRenderer={customImageRenderer}
/>

@guysopher can you take a look.
Notice - do not merge the version change in the package.json. not sure why its in the changed files.

The fix is only relevant for version 2 (it is adding it on
GalleryContainerNew).
I think we should recommend him to upgrade to version 3
On Tue, Feb 9, 2021 at 11:51 AM Yonatan Hattav<EMAIL_ADDRESS>wrote:

@guysopher https://github.com/guysopher can you take a look.
Notice - do not merge the version change in the package.json. not sure why
its in the changed files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wix/pro-gallery/pull/274#issuecomment-775809126, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAV3ETMSP726GOHTJEGHLETS6EARDANCNFSM4XHRIJVQ
.


Fix backwards compat with v2 containerd configs

Closes #3336
The fix here is when containerd config default is called, generate a new v2 config, however, keep the default code set at v1 so that when the containerd main loads, it merges the default config with what is loaded from disk causing a backwards incompat change.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

LGTM

Sorry @Random-Liu

@crosbymichael This solution is perfect. :)
I was hesitated about whether to change default to v1 or not, because I also want containerd config default to recommend v2. :P Now it meets both requirements.

Codecov Report

Merging #3337 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   44.85%   44.85%
=======================================
  Files         113      113
  Lines       12361    12361
=======================================
  Hits         5544     5544
  Misses       5964     5964
  Partials      853      853

Flag
Coverage Δ

#linux
48.77% <ø> (ø)
:arrow_up:

#windows
40.25% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53896d7...31afff2. Read the comment docs.

Codecov Report

Merging #3337 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3337   +/-   ##
=======================================
  Coverage   44.85%   44.85%
=======================================
  Files         113      113
  Lines       12361    12361
=======================================
  Hits         5544     5544
  Misses       5964     5964
  Partials      853      853

Flag
Coverage Δ

#linux
48.77% <ø> (ø)
:arrow_up:

#windows
40.25% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53896d7...31afff2. Read the comment docs.


Properly set electron version in env scripts

Since the console.log() got removed from build/lib/electron.js, the npm_config_target environment variable wasn't getting set to anything.
This PR updates the scripts to call the getElectronVersion() method on build/lib/electron.js.

Oh wow.


GitHub Actions workflow to update downstream dataset repos

Tentative workflow to make a PR to the main branch of dataset-specific repos. The workflow will be triggered whenever a commit is pushed to the main branch of the main mr_proc repo. Since the main branch is protected, this means that it will trigger when PRs are merged to main.
Need to test this on a toy repo before merging.
GitHub Actions used:

peter-evans/create-pull-request
michellewang/auto-approve-action

Fork of hmarr/auto-approve-action

pascalgn/automerge-action

Successfully run in toy repo, see created PRs.

After some further experimentations with the toy repos, I think this should work okay now. The git history should be relatively clean as long as we use merge commits (instead of squashing or rebasing).

I have added a step for automatic approval of the PR created by this action. Note that this requires a second Personal Access Token (which hasn't been added as a GitHub secret to this repo yet), because the person who created a PR is not allowed to approve it (on GitHub the button is visible but can't be clicked). Will look into auto-merging (provided no merge conflicts) later this week.
Test repo is still neurodatascience/mini_proc. New commits to main will automatically create/update PRs in mini_proc-ppmi and mini_proc-qpn.

As long as the request is merging onto main-upstream and not main directly I think removing that rule should work fine. Commits from upstream can still be deliberately merged into main from the upstream branch. I think that protection was deliberately redundant.
Whatever modification can still be tested in the upstream branch before merging to main, lowering the risk of an automatic action breaking a working processing environment (I'm assuming everyone is processing on the main branch of the project repos when they clone them.).

As long as the request is merging onto main-upstream and not main directly I think removing that rule should work fine.

@bcmcpher

main-upstream is updated directly to match neurodatascience/mr_proc:main exactly

As long as the request is merging onto main-upstream and not main directly I think removing that rule should work fine.

@bcmcpher the PR would actually be merged onto main. main-upstream is the head branch from which the changes proposed by the PR come from. Here is what happens:

neurodatascience/mr_proc-[dataset]/main-upstream is updated (and created if necessary) directly to match neurodatascience/mr_proc:main exactly
A PR is created to push the changes on neurodatascience/mr_proc-[dataset]/main-upstream to neurodatascience/mr_proc-[dataset]/main
The PR is approved/merged automatically by GitHub Actions

I don't think merging to main automatically would be a big issue because even if the main branch on GitHub is updated, whatever's on people's local clones isn't updated automatically until they run git pull. Since the common code and the dataset-specific code shouldn't interact in any way it would be unlikely that the mr_proc prime code breaks anything (I think?). Although one exception that I can think of is if we make big changes to the directory structure: that might break things if there are hardcoded paths or something like that.

Whatever modification can still be tested in the upstream branch before merging to main, lowering the risk of an automatic action breaking a working processing environment

Testing on main-upstream would be the same as testing in mr_proc prime since it's an exact copy (it doesn't contain the dataset-specific changes). We could merge main-upstream to another branch that contains the dataset-specific code, then test it there, but this would require a manual merge to main eventually, and I think @nikhil153 wanted to avoid that because if we have a lot of dataset forks it would be tedious to merge the PR in all the forks.

@michellewang Does disabling the branch protection rule "Do not allow bypassing the above settings"  will allow anyone in neurodatascience to push directly to mr_proc-[dataset]/main from their local clone? (e.g. Mohammad working on QPN analysis)?
If that's not the case and it's just us three that can do that, then let's go ahead and disable it.

@nikhil153 it'll only be people with "Admin" role (so the three of us) according to the GitHub docs:

If that's not the case and it's just us three that can do that, then let's go ahead and disable it.

Ok I've disabled it on the PPMI and QPN forks. mr_proc(*) still has that rule but there's no need to disable it right now.

@michellewang sounds good! I have reviewed the PR. i will let you merge it if you are happy with the final changes!


auto create channel

@repeatedly can this be reviewed and merged please

Could you give us a background context about it? we can't get why you need this change.

Could you give us a background context about it? we can't get why you need this change.

@ganmacs  Suppose I want to use this plugin for different source types and  send to HEC endpoint .. then I need to set the channel manually and its not ideal.. auto generating channel is simpler

How about adding auto_generate_channel option to generate the channel name automatically, then?
it's difficult to merge this patch because it has breaking change. Adding such option doesn't affect existing behaivor.

it has breaking change

This point is very important for public library/plugin.

Can you follow the DCO? https://github.com/fluent/fluent-plugin-splunk/pull/26/checks?check_run_id=482405499

Can you follow the DCO? https://github.com/fluent/fluent-plugin-splunk/pull/26/checks?check_run_id=482405499

I cannot... its signing with my official mail id.. which I don't to want to expose


Jon moved to Seqera, no longer Seqera Labs

I'm now at Seqera, and I don't think the company should be referred to as Seqera Labs any more

Thanks @FriederikeHanssen


CI/Hosted Pipelines content-hash : compute-md5sum Step Discrepencies

There seems to be discrepancies with how this step works between the CI and Hosted pipeline. More specifically when –digest-pinning is enabled on the CI pipeline, and pinning has already occurred, the md5sum calculated on the CSV.yaml is not the same value that the Hosted pipeline calculates. This forces the Hosted pipeline to run preflight for operators which cannot be tested in the Hosted pipeline.
Another note, no matter which pipeline runs (or what flags the CI pipeline is run with) preflight's calculations of the hash for the CSV.yaml that it gets from the bundle, is always the same value.
Jira: CLOUDWF-8454

@tamurray Here is the issue for the problem you experienced. I also created an internal Jira.

We (redis-enterprise-operator) have also hit this issue.
Looking further into it, I think the digest-pinning step is creating additional .relatedImages entries in the CSV (e.g., this commit auto-generated by the commit-pinned-digest step).
If no tag-->digest replacements are detected, then the modified CSV isn't commit/pushed upstream, but the modified local file results with a different md5 checksum --> preflight gets triggered on the hosted pipeline.
I'm not sure what's the purpose of these auto-generated .relatedImages entries, but assuming they should be there, maybe the digest-pinning/commit-pinned-digest steps should be updated to detect such changes and commit/push them?

Hey guys, sorry for the late response I am looking at the issue now. All references to remote images need to be pinned by the digests. That is why we have the digest-pinning task that translates tags into digest in CSV. In case you enable this feature by using –digest-pinning flag and the pipeline detects a dirty repository after the pinning step it automatically creates a new commit/branch in your repository commit-pinned-digest and the hashing step uses updated CSV. Then you have to open a PR with the new branch in order to match the hash from CI and hosted pipeline.
Do you have a full output of the CI pipeline so I can analyze where the problem is? Is there a chance that you didn't open the PR with the commit generated by commit-pinned-digest? Thank you

Then you have to open a PR with the new branch in order to match the hash from CI and hosted pipeline.

@Allda Is this documented somewhere that the PR needs to be opened with the new commit-pinned-digest branch? This is the first that I'm even hearing of this.

@acornett21 I am not sure if it is documented :/ If you enable the submit parameter the CI pipeline automatically opens a PR with the new pinned branch. If you don't use this option it is up to you to open PR with a correct commit. I'll check with doc team and potentially add this step to the doc.
Based on this feature do you think the PR could be opened manually with the old commit which caused the mismatch between pipeline hashes?

@zcahana thanks for your last comment, it put us on the track where the issue might be. I was able to rerun the pining step on your branch locally and the .relatedImages section was indeed changed and the md5sum on this file corresponds with logs from CI pipeline. The problem is that we are testing only replacements.json (which is empty {} after the pinning) but the changes are reported in references.json and we should add it to the check if commit is needed.

We have decided to reset git working branch to the state before pin-digest if no actual pinning occurred. This will prevent the md5sum from ci pipeline to be calculated against the files in a different state.
Also, the relatedImages section is always recreated by the pinning tool, so there will be most certainly always some differences/git changes in CSV if it was originally pinned by different tool than the one used by the pipeline.

The issue has been resolved in https://github.com/redhat-openshift-ecosystem/operator-pipelines/pull/449


Add tests for custom aggregators

This PR includes the process for adding a custom aggregator to PaSh. PaSh annotations now support relative paths with rel_path instead of just names (for aggregators that are in the $PATH). Note that an annotation needs to be added for all aggregators (I created one for concat.sh in annotations/custom_aggregator).
There are some issues that I re-realized after working on this PR. Namely, that pure_parallelizable commands require some hardcoding except for the annotations (dfg_node.py and command-classes.yaml). I will create a new PR addressing these issues so that the process is smoother.
This PR can be merged after you review @nvasilakis.


Invalid IP addresses returned when dhcp is not in use

Library generates a malformed ip addresses of type string containing "None.None.None.None" for ip_address, gw_address and dns_address when associated fields are not present in the OS api response.
The 2.1.9 api states that these fields are ignored/(missing) if dhcp is being used. Firmware codebase shows this is true for all non-Arduino platforms (i.e. OSPi).
This PR forces a None result rather than malformed string.

LGTM

Not actively using, just something I bumped into. Can wait for convenient moment.


View Listener

Previously #1062 and #863
TODO

[ ] Documentation

Also worth mentioning @fabpot disliked the typehinting aspect. Happy to take it out, just need a final confirmation.

I'm fine with the typehinting if people like it.

The type hinting is quite useful, IMO. It makes it very easy to return multiple object types from controllers and have the right corresponding view listener "just work".
The branch looks good to me visually, although IMO it could stand some more comments, particularly in shouldRun(). :smile:  The fabbot disagrees though.

:-1: on the typehinting magick. Using a guard isnt that difficult to understand or explain. The magic typehinting is hard to explain and understand.

I like typehinting magic, but Silex doesn't really do it much elsewhere, so for the sake of consistency I'd be inclined to leave it out.

I +1 the typehinting since it's basically the same as the error handler and it's not hard to understand at all.

As Robert said, it's the same logic and largely the same code structure as exception handling already uses.  If it's not confusing for exceptions it shouldn't be confusing for view(), either.

I don't really mind about having the type hinting per se, but I do think in it's present state, this PR is consistent with the existing error handler behaviour, which is itself a kind of special case of view handling.
I've added some docs, comments on those appreciated as well.

Replaced the ridiculously incorrect example, fixed the grammar and totally removed the last example, as I couldn't think of anything that wasn't a foobar type thing. Thanks @fabpot @GromNaN

Thank you @davedevelopment.