error when trying to use sentinel outside of localhost

Hi
This is my first time using sentinel. i got it working locally but when i run it on my kubernetes platform i get this error:
Error: All sentinels are unreachable. Retrying from scratch after 1ms. Last error: ERR unknown command `sentinel`, with args beginning with: `get-master-addr-by-name`, `mymaster`,
2019-06-03T12:17:56.94509194Z     at connectToNext (/usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:55:31)
2019-06-03T12:17:56.945096532Z     at /usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:93:21
2019-06-03T12:17:56.945099944Z     at /usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:127:24
2019-06-03T12:17:56.94510342Z     at tryCatcher (/usr/src/node_modules/standard-as-callback/built/utils.js:11:23)
2019-06-03T12:17:56.945106589Z     at /usr/src/node_modules/standard-as-callback/built/index.js:30:51
2019-06-03T12:17:56.945109714Z     at processTicksAndRejections (internal/process/task_queues.js:89:5)

What does this mean exactly? is this an error that occures on the sentinel host or in my client container?

The error indicated the server didn't recognize SENTINEL command. That is usually caused by using an old Redis version (older than 2.8).
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jesper O. Christensen<EMAIL_ADDRESS>Sent: Monday, June 3, 2019 8:21 PM
To: luin/ioredis
Cc: Subscribed
Subject: [luin/ioredis] error when trying to use sentinel outside of localhost (#880)
Hi
This is my first time using sentinel. i got it working locally but when i run it on my kubernetes platform i get this error:
Error: All sentinels are unreachable. Retrying from scratch after 1ms. Last error: ERR unknown command sentinel, with args beginning with: get-master-addr-by-name, mymaster,
2019-06-03T12:17:56.94509194Z     at connectToNext (/usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:55:31)
2019-06-03T12:17:56.945096532Z     at /usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:93:21
2019-06-03T12:17:56.945099944Z     at /usr/src/node_modules/ioredis/built/connectors/SentinelConnector/index.js:127:24
2019-06-03T12:17:56.94510342Z     at tryCatcher (/usr/src/node_modules/standard-as-callback/built/utils.js:11:23)
2019-06-03T12:17:56.945106589Z     at /usr/src/node_modules/standard-as-callback/built/index.js:30:51
2019-06-03T12:17:56.945109714Z     at processTicksAndRejections (internal/process/task_queues.js:89:5)
What does this mean exactly? is this an error that occures on the sentinel host or in my client container?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/luin/ioredis/issues/880?email_source=notifications&email_token=AAE3H7QDRJHBK2KCRYELGR3PYUEEPA5CNFSM4HSHPSOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXITSZA, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAE3H7QJBRA2I45WKHFRRPDPYUEEPANCNFSM4HSHPSOA.

I have a duplicate environment variable which ment my new port for sentinel got overriden by the old port for redis -.-  my bad! problem solves


add delete next to save button on edit pages

… and maybe have it confirm before doing it's thing

RANT WARNING
Personally, I thing confirming is an anti-pattern. Rage-clicking and drunk-users double click and ignore warnings, if they can even read in the first place.
I prefer undo logic because it retains data state / scope. Here is a good read about the issue:
http://alistapart.com/article/neveruseawarning

you're absolutely right (also alistapart, as usual). i'll remove the warning stuff altogether. if recovery/undo would be desirable at a later stage i could still add something like a trashcan.

delete just got less crappy with proper buttons and functionality. confirmation is still the mode of operation. the trashcan thing will get a bit complex because of related items. so this is non critical to me in light of other bugs and improvements.


No mention on nginx

Not sure whether this is just a documentation issue (i.e. it's supported by one of the other backends i.e. WSGI) or whether it's unsupported.
Sorry if it's obvious to others but this area isn't one of my strong points - hence why I'm looking for a nice abstraction library!

Hi Andy,
it's not supported at the moment, purely as I was initially only doing this for an app deployed behind apache.  If I understand correctly then supporting nginx with accel redirect should be really easy.  Been meaning to get around to it, as I think it's possible to get it working by tweaking the wsgi backend somehow.  Main issue is then documenting that nginx config.
Care to chip in?  Can always meet in Brighton if you want.  Hopefully once baby has settled in better sleep patterns I'll make it out to brightonpy too...
cheers,
John (aka lilspikey)

http://wiki.nginx.org/XSendfile
Shows it really is going to be very similar to wsgi backend, but with X-Accel-Redirect header instead of just Location.

Ah. Small world, fellow BrightonPy'er...
Just got back from an overly long holiday so might be a while until I can be of use. I do however have a real codebase and a live testing server (currently setting X-Accel-Redirect headers directly) if that would be any help.

I'm pretty certain of what needs changing.  Perhaps if I setup a branch and make the changes I reckon are needed you could test it?
Perhaps if you could give me the example of how you're currently doing it - so I can easliy get nginx running locally etc too?

Ok, I've merged the nginx branch into master now, as I've had a chance to test it running with nginx


Conversion to MathJax 3

As discussed in this issue, a move to MathJax 3 is likely to fix the offending obscure MathJax bug.
This was a minor ordeal, but I took the plunge and did it, with some relatively thorough testing to ensure feature parity.
Besides the obvious API changes, there are some major structural changes to the code that I'll outline here for your reviewing convenience:
Loading and Configuration
The story here is quite different. Now the main bundle file does the following as the first JS that runs:

Configures the window.MathJax object
Loads the MathJax script programatically (which reads the configuration).
Renders the main component

This was the best solution I could come up with to resolve loading order difficulties (the config object must exist before the library is loaded, etc.), but you may have better ideas here
Ensure the library is loaded before using the API
The other trouble was with components using the MathJax api before it was ready (particularly apparent when loading from a hash url); I'm much less confident in my solution here since I'm much more of a Vue guy, so I'm not sure if my solution is idomatic in a react-like environment:

Have the main bundle file hook into a ready event from MathJax and re-render App with a prop mathjaxLoaded={true};
This prop gets passed down only two levels to Grid, where it avoids setting the value fields of GridCell and GridArrow unless the prop is true (and of course when it does, a re-render will trigger and the typesetting will appear).

I separated this part into a separate commit in case you have any better ideas on how to tackle this. In general, loading the library asynchronously and enforcing the library's readiness as a precondition is a huge pain in cases like these.

I also have the current build hosted at https://cemulate.github.io/tikzcd-editor, if you'd like to do any testing yourself. Here is a non-trivial hash url to use.

Thanks a lot for your work!

This was the best solution I could come up with to resolve loading order difficulties (the config object must exist before the library is loaded, etc.), but you may have better ideas here

It looks fine.

The other trouble was with components using the MathJax api before it was ready (particularly apparent when loading from a hash url); I'm much less confident in my solution here since I'm much more of a Vue guy, so I'm not sure if my solution is idomatic in a react-like environment

I'm also fine with rendering only when MathJax is ready (so there will be no need for a mathjaxLoaded prop on App). That will be easier to reason about. There can potentially be a flash of blank page but it shouldn't be much of a problem.

Another thing I've noticed by playing with your build is that panning the given nontrivial diagram isn't as smoothly as before. It seems MathJax is forcing a reflow on mouse move. I'm not sure why it didn't do that previously... maybe previously the MathJax queue deferred all updates to a single actual update?

Interesting. When I started investigating that it seems that I get the same behavior on the tip of master, and it's even noticeable on an empty diagram (but obviously moreso with some TeX). Yet, I get great performance on your hosted site at http://tikzcd.yichuanshen.de/. I did a reasonable amount of double checking here to make sure I wasn't crazy, but I can definitely reproduce this behavior on a fresh build from master.
Is it perhaps the case that the production site was built from an older commit? If so, we could bisect and maybe find the culprit.

Hmm, I can reproduce it locally on master as well. The only change that has been done since last release was to update the dependencies. Maybe the performance issue can be tackled separately.
I would still like you to remove the mathjaxLoaded prop on App though, so App will only be rendered when MathJax is completely ready.

Cool, I rebased on master and in the process replaced the second commit (resolving the mathjax ready issue) with a new approach that just renders the main component when MathJax is ready. There's a gap of "blank page" at load but very small.
I'm curious about the performance issue. It seems to be that panning the Grid causes all GridCells to re-render (because Grid re-renders). So I don't know how this issue wasn't present before, but perhaps a prettier upgrade either fixed or introduced a bug that's making the behavior different.

Just FYI on the panning performance issue: I removed the typesetting completely and still got the same lag, so it seems to be a performance issue with preact. In particular, when panning, there is are periodic moments a second or so apart where preact re-renders all grid cells at once, and this is when a noticable freeze/lag happens.

Thanks a lot! The build issue comes from a new prettier version. Just perform a npm i and npm run format to format all files again and you should be fine.
I agree, the lag most likely comes from the preact update.

No problem! I took care of the formatting.


Darwin: Freezes if not reading stdout.

Hello!
I've found a difference in behaviour between Mac and Linux using your module.
package main

import (
	"github.com/creack/pty"

	"os/exec"
	"testing"
)

func TestCommand(t *testing.T) {
	c := exec.Command("./echo.sh", "TestCommand")
	pty, err := pty.Start(c)
	if err != nil {
		t.Fatal(err)
	}
	defer pty.Close()
	err = c.Wait()
	if err != nil {
		t.Fatal(err)
	}
}

echo.sh:
#!/bin/bash
echo $@

If this is run on linux it will pass, on darwin it will freeze.
However If I add a buffer to c.stdout  it will pass.
My guess is that the master file descriptor isn't buffering output from the slave. Which is really strange.
On the otherhand if you replace ./echo.sh to echo it will pass.
I'm not sure what I'm seeing or how to amend it.
My guess is a combination between differences in the os/exec between linux and darwin and file settings differences between darwin and linux regarding the master terminal.
Do you have any idea what this might be?
Best regargs,
Måns Ansgariusson
Go version: 1.14
pty version: v1.1.11

I am sorry, I didn't have time to look into this just yet. Will do asap, I should have time over the weekend.

No stress :)

I managed to reproduce.
To be honest, I am not 100% sure of the reason.
Adding a sink instead of a buffer is probably better (go io.Copy(ioutil.Discard, pty)).
I think you are right and it as to do with some lower-level difference on how the tty driver works between linux and darwin.
That being said, it looks quite specific to bash. if you switch to zsh, it doesn't block.
Do you have a specific use-case where is could cause concern? From the looks of it, I'd be inclined to simply close this as a non-issue.
As a rule of thumb, even in tty mode, when the process writes, something should read it.

Sweet!

Adding a sink instead of a buffer is probably better (go io.Copy(ioutil.Discard, pty)).

This solved it for me as well.

That being said, it looks quite specific to bash. if you switch to zsh, it doesn't block.

That is super interesting! I'll defenetly dig into that, didn't think of testing another shell.

Do you have a specific use-case where is could cause concern? From the looks of it, I'd be inclined to simply close this as a non-issue.
As a rule of thumb, even in tty mode, when the process writes, something should read it.

Yes, close it. I agree that it is expected that something should read what is outputed from the pty.
I was making test-cases for a project of mine when i stumbled upon this.
Thank you for your time debugging this :)
Best regards!


Difference between concat tokens vs without concat tokens

Are there benefits to token concatenation during MDS conversion compared to not concatenating tokens?
For instance, if I intend to conduct experiments with various models, opting for token concatenation would require a tokenizer. As a result, when working with different models, I would consistently have to initially perform MDS conversion using the specific model's tokenizer.
@dakinggg

concatenating tokens allows you to pack sequences together up to the maximum sequence length, which is beneficial for efficiency so that you don't "waste" compute on padding.

Gotcha, thanks.


Check source via autopep8

Run autopep8 in CI to check the source is well formatted. Fix anything that was not yet properly formatted.

I there an easy way to run this locally? A Makefile target maybe (I looked, but couldn't tell if it would be run or not).

I there an easy way to run this locally? A Makefile target maybe (I looked, but couldn't tell if it would be run or not).

make test-src should run it, if you have autopep8-3 installed. Or if you only want autopep8: pytest test/src/test_pylint.py -k autopep8.

I just wanted to say that I love auto-formatters, so this is great! :)

I will fix the comment and name in a follow up later today!


Build failing

It says build is failing. Now I'm not sure whether to use it or not. Can you pleas tell me which version is stable to use
Thanks

The latest version on npm is stable. Don't worry about the build badge, Travis is very unreliable

Thanks for reply. Just wanted to make sure that module is stable before using it  :smile:


Add Redis

Redis in Go

https://github.com/go-redis/redis (selected)

https://redis.uptrace.dev/

https://github.com/gomodule/redigo

Redis Mock in Go

https://github.com/go-redis/redismock (selected)
https://github.com/alicebob/miniredis

Redis in Kubernetes

https://hub.kubeapps.com/charts/bitnami/redis
https://www.callicoder.com/deploy-multi-container-go-redis-app-kubernetes/#creating-the-kubernetes-deployment-and-service-manifest-for-redis
https://cloud.google.com/kubernetes-engine/docs/tutorials/guestbook

Done by #3151


Entity ability to communicate back to super-hands when an interaction is rejected

E.g., when a second hand tries to grab an already grabbed entity, it still thinks it is holding onto that entity and won't be able to hover or grab the entity after it is released.
Resolving this will fix #3

Fixed #37


Does it Work on Windows  ? Otherwise any hope or alternative ?

It does not. I plan to investigate whether it's possible to do something with git bash, but I'm not terribly optimistic. Pseudoterminals are a pretty low level feature of Unix systems, and I don't know of anything equivalent in Windows.

Actually, it looks like it may be possible simply by piping text to and from git bash. There will probably be some limitations.

Any incremental improvement would be nice for Windows users.
Maybe should you target only python3.3+ if it can help reaching a solution.

I'm working on it. The limitations will probably be things like terminal resizing not working. If it works, it should be straightforward to make it work on the same versions of Python that terminado already supports (2.7, 3.3+).

There's a branch here with git bash very roughly working.

Problems I'm aware of:

Subprocesses like Python do not realise they're in a terminal, so they behave as if they were in a pipe. Even using python -i, I can't interact with it. python -c "print(123)" works fine, though.
Shortcuts like Ctrl-C don't work. That's expected - on a Unixy system it's the pty that would handle turning Ctrl-C into SIGINT, and that's what we're missing here. Signals in general are not a Windows thing, so I'm not sure how best to handle this.
Speed: there's a brief but noticeable pause before drawing the next prompt.
Terminal size: I don't know of any way to update it. Then again, that's not such a big issue, because:
Full screen programs like vim show nothing, but lock up the terminal. Something must be translating the curses calls into equivalent Windows API calls, but I don't know where that's happening.
Programs that take control of the full terminal, like vim, do not show up

This library and exe might be useful if someone has the will to take this further: https://github.com/rprichard/winpty

winpty is not on pypi.
I don't find where you or MinRK already said that https://pypi.python.org/pypi/prompt_toolkit was not a good solution either.
==> Droping the request for 'was a disproportionate effort in 2015 to get it right'.

winpty is not a Python package, it's a C++ thing. I'm not entirely sure how we would use it, but it appears to do what we'd want. The setup instructions are pretty complex, though, so I haven't pursued it.
prompt_toolkit is solving a different problem from this.

a glimmer of hope ?

Sorry, I don't plan to take this any further. I don't think I can make it
reliable enough to be worth supporting windows - I don't want to deal with
a steady stream of bug reports I can't resolve.

no problem, better that than a painfull death

I see terminado on jupyter-notebook (setup.py) extras for win32. Is it Working or dropped for this platform ?

Still no windows support. I think it can be installed OK, so it's not a
problem for the notebook to specify it as a dependency on all platforms.
But it can't be imported on windows.

someone just told me some problems may go away for pymux If I use cygwin. Would it also improve situation for terminado ?

I don't know; feel free to experiment, but as we discussed in another thread, we don't generally recommend using Cygwin, and I don't intend to support it for Terminado. We find that it's better to use a full Unix environment (such as your favourite Linux distro) rather than trying to graft a Unix environment onto Windows.

lonely feeling ... https://youtu.be/fhv-4QLGsso?t=1211


cdc_mbim module missing

Trying to use a Sierra-branded Dell DW5811E lte modem, I'm encountering the issue that the cdc_mbim kernel module is missing, and ModemManager hence can't see the device.
Any easy fix for this issue without recompiling the kernel with the module ?
EDIT: might be linked to #109
Thank you !

Further details :
uname -a :
Linux iot2050-debian 4.19.94-rt39 #1 SMP PREEMPT RT Tue Mar 23 07:56:25 UTC 2021 aarch64 GNU/Linux
lsusb :
Bus 001 Device 004: ID 413c:81c2 Dell Computer Corp.
usb-devices :
D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=413c ProdID=81c2 Rev=00.06
S:  Manufacturer=Sierra Wireless, Incorporated
S:  Product=DW5811e Snapdragon™ X7 LTE
S:  SerialNumber=LF92059268021029
C:  #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=500mA
I:  If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#=0xc Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=(none)
I:  If#=0xd Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=(none)
I:  If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
I:  If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)

(Note the absence of drivers)
ModemManager's output :
Apr 06 07:27:21 iot2050-debian ModemManager[2599]: <info>  Couldn't check support for device '/sys/devices/platform/pruss0_eth': not supported by any plugin

If the build passes, you should find a testing image under artifacts at https://github.com/siemens/meta-iot2050/actions/runs/721725051. Rebuilding, at least of the kernel, is unfortunately the only solution of some kernel driver is missing.

Will try to install it as soon as it's built, and will let you know soon after.
Thank you !

The SIM is present and no PIN is enabled. Do you think it could be due to the mPCIe - M.2 adapter not allowing the device to communicate with the SIM tray?

This should work, at least it was tested to work fine with other modems. Already tried to search the web for this error pattern?

Nothing much is showing up with google searches, sadly. Also, nothing seems to happen (either in dmesg or in syslog) whenever I try hot swapping the SIM.
Tried with two different, known working, 4G-enabled SIM cards, without and with reboot, and nothing much seems to happen. I wonder if I may have missed a step.
Perhaps another missing driver ?

@BaochengSu, any ideas? Could that adapter be the issue?

Alright, so after trying with another SIM, I seem to have a link (very low but that's due to the missing 2nd antenna).
So either my adapter is of very poor quality, or the sim tray is damaged somehow. In any case, it seems to not be an IOT or driver issue anymore, and we can add the device to the compabitle list !

Ah, good. Do you have an antenna attached, and is there the option on that adapter to attach one? That may explain poor quality.
PR for the config switch is open https://github.com/siemens/meta-iot2050/pull/114.

I have one antenna only as I only found one MHF4 - RPSMA adapter cable, hence the low quality, but yes I do have two connectors.
...However, 4G connectivity was lost again after a reboot. Sim missing again... Guess I'll try another IOT2050 as soon as I receive one.


ramdisk: Added device IO control support for Windows 10

Added support for the following device IO control codes:

IOCTL_STORAGE_QUERY_PROPERTY
IOCTL_DISK_GET_LENGTH_INFO
IOCTL_MOUNTDEV_QUERY_DEVICE_NAME

Issues addressed: #49 and #44

tchaudev, is that helped and RAMDisk working as normal under Windows 10?

Is that helped and RAMDisk working as normal under Windows 10?
This fix will get the ramdisk working under Windows 10 via PowerShell or CommandPrompt. I explain the issue more clearly here: http://stackoverflow.com/questions/35999668/windows-ramdisk-storage-driver-sample-drive-with-the-name-r-does-not-exist.
Inside of manual for MS RAMDisk exists info about Package project but I not found it inside Solution. Is that normal?
When I forked from Windows-driver-samples, the ramdisk solution never had the package project. Maybe it was added recently. That said, you don't need the package project to build, install, and run the WdfRamdisk project.

Thanks. I see now. Explorer still not understand the driver on your PC too. I have compiled both versions one from MS and your fix - both not working well on my Windows 10 x64/VS2015/ WDK10. But I had one more problem - inf-file do not adds keys to Windows registry. Only when I added registry keys manually then x64-compiled driver was installed and started. Device Manager now have info about the driver and it looks as working normal in Device Manager but R: drive in File Explorer looks like Local Drive and have 0 size.

I see now - the RAMDisk working only under administrators rights. If you have Total Commander installed - Run it  as Administrator. Then youll see working MS-RAMDRIVE as R: disk. Probably reason in x86/x64 compatibility of Windows 10. As I understand - necessary to use Wow64DisableWow64FsRedirection for x86-compiled driver - I have no other idea. :-)

thx for your work, i finally get ramdisk run on win 10.

@Jichao thanks for the tip.

I can't find the .inf file, is it missing?
It doesn't want to install correctly (on a Windows 2016 Server), any tips?

The missing INF file issue happens because ramdisk.inx is not included in the project. Add it to the Driver Files section and rebuild. You will then run into two more errors about duplicate entries - just merge them into one and you will have the expected output files.

Interestingly, I was able to access the R: drive on a physical box but when I deploy the driver to Win10 VM (under HyperV), I get "Incorrect function" error as well.
I will try out the PR and share an update.

I have confirmed that this PR resolved the Incorrect Function issue. Thanks you @tchaudev.

Is there a reason this PR is not merged yet (blocked on owners to merge it)?

Dear, is possible to compile this project under Visual Studio 2017 + WDK 1703? I even can not to open it.

Dear, I tested RAMDisk sample under Windows 10 but found one trouble. Windows 10`s File Explorer defines RAMDisk drive as DVD RW Drive (R:). Any ideas how to change properties of RAMDisk drive from DVD RW to RAM DRIVE?

@Smekalov, I couldn't get RAMDisk to work on Windows 10 file explorer when I posted this pull request, and I haven't touch it since. Try reading Jichao comment?

Yes, the native sample have 'rights' problem. I have fixed it before Jichao message but I had other problems, that is a reason why I not sent this 'rights/security' fix here. Right now I have sources with your IO-fix, L"D:P(A;;GA;;;WD)" security and without FAT12 limitation. The driver working under MS Windows 10 x64. The driver possible to compile under Visual Studio 2015 + WDK 1703. Visual Studio 2017 still not supported WDK. I can sign the driver and install on my MS Windows 10 x64 system but I have some problems when I use it - for example File Explorer understand it like any sort of drive but not RAM drive.
tchaudev, I can send you changed sources but not know how to do this here.
P. S. I still interesting - why RAMDisk code, so usual for xNIX platform, still so secret for MS Windows? We had Win 3.11/95/XP/Me/2000/VISTA/7/8/8.1/10 but we never had normal system RAM disk with user interface like SUBST. So interesting thing still not available for usual users in time when PC have RAM from 6GB to ~.

@Smekalov, maybe you could try opening an issue. I haven't touch this code in over a year, and don't have any system setup to build, or test, windows drivers.

Asking in year 2024:
What's the current status of this PR (and the related issue https://github.com/microsoft/Windows-driver-samples/issues/44 )?


adding some dividers and content to Filtering Data section.

Please let me know if you like the dividers, I think it makes it easier to see each subsection. Also, please let me know if you like the format of the Filtering Data section.

I think it definitely makes it look cleaner. Also, thanks for continuing to contribute here. I'll see what else I can add this weekend and we can publish the v1!


[Model Update]: Material Demand 24.05 changes

Description

Changes for DCM & PURIS standard 24.05. Changes see RELEASE_NOTES.txt
Closes #586

MS2 Criteria
(to be filled out by PR reviewer)

[x] the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check  (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The  SAMM CLI is available here and in GitHub
[x] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[x] the identifiers for all model elements start with a capital letter except for properties
[x] the identifier for properties starts with a small letter
[x] all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
[x] Property and the referenced Characteristic should not have the same name
[x] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[x] use abbreviations only when necessary and if these are sufficiently common
[x] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[x] fields preferredName and description are not the same
[x] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[x] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[x] units are referenced from the SAMM unit catalog whenever possible
[x] use constraints to make known constraints from the use case explicit in the aspect model
[x] when relying on external standards, they are referenced through a "see" element
[x] all properties with an simple type have an example value
[x] metadata.json exists with status "release"
[x] generated json schema validates against example json payload
[x] file RELEASE_NOTES.md exists and contains entries for proposed model changes
[x] all contributors to this model are mentioned in copyright header of model file

MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)

[ ] All required reviewers have approved this PR (see reviewers section)
[ ] The new aspect (version) will be implemented by at least one data provider
[ ] The new aspect (version) will be consumed by at least one data consumer
[ ] There exists valid test data
[ ] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[ ] The model has at least version '1.0.0'
[ ] If a previous model exists, model deprecation has been checked for previous model
[ ] The release date in the Release Note is set to the date of the MS3 approval

One point I found: Maybe it makes sense to update the description of the materialGlobalAssetId to be more abstract (PartAsPlanned is from now on PartTypeInformation). We used:
:materialGlobalAssetId a samm:Property;
    samm:preferredName "UUID of the Part Type Twin"@en;
    samm:description "Identifier used uniquely to identify part type twin."@en;
    samm:characteristic ext-uuid:UuidV4Trait;
    samm:exampleValue "urn:uuid:48878d48-6f1d-47f5-8ded-a441d0d879df".

One point I found: Maybe it makes sense to update the description of the materialGlobalAssetId to be more abstract (PartAsPlanned is from now on PartTypeInformation). We used:
:materialGlobalAssetId a samm:Property;
    samm:preferredName "UUID of the Part Type Twin"@en;
    samm:description "Identifier used uniquely to identify part type twin."@en;
    samm:characteristic ext-uuid:UuidV4Trait;
    samm:exampleValue "urn:uuid:48878d48-6f1d-47f5-8ded-a441d0d879df".

@nhaenis Could you please check this.

not required.


a mistake in SentinelSCGAutoConfiguration

我们鼓励使用英文，如果不能直接使用，可以使用翻译软件，您仍旧可以保留中文原文。
We recommend using English. If you are non-native English speaker, you can use the translation software.
Which Component
spring-cloud-alibaba-sentinel-gateway
Describe the bug
logs wrong content in method initFallback  lines 119
logger.info( 						"[Sentinel SpringCloudGateway] using AnonymousBlockRequestHandler, responseStatus: " 								+ fallbackProperties.getResponseStatus() 								+ ", responseBody: " 								+ fallbackProperties.getResponseStatus());
To Reproduce
Steps to reproduce the behavior:
responseStatus and responseBody display the same
Expected behavior
responseBody shoud be change to fallbackProperties.getResponseBody()
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
version : 2.1.1.RELEASE

Could you create a PR to fix it?

Could you create a PR to fix it?

PR created

It seems you create it in wrong repository.


Add fakes subpackage

Disabled by default, add --generate-fakes to enable. Consolidated LRO/pageable naming.

Why did all the resp rspError change names to respr and resprError?


Adoptopenjdk_repo can only be changed in grinders

This change is to alert jenkins users that non-grinder test jobs will ignore any changes to these two variables.

Hi Shelley,
I think this enforced by the "Pipeline script from SCM" bit in the job config. If you're rerunning a test job manually, the Git repository URL is hard-coded in a normal test job, but set dynamically to the value of the ADOPTOPENJDK_REPO variable in a grinder job.
I recall the team had a discussion about this during one of our calls (bit vague, sorry), and the conclusion was that this was intentional. I proposed adding a comment to clarify the functionality.

Ok, here's the chat: https://adoptium.slack.com/archives/C5219G28G/p1707139690344389

I think what tripped me up at the time was that the aqa-test branch is set dynamically, but the repo is hard-coded.
In normal test jobs, I mean. Like this one: https://ci.adoptium.net/view/Failing Temurin Test Jobs/job/Test_openjdk23_hs_extended.perf_aarch64_windows/

This statement is incorrect. This PR should be closed without merging.

Hi Lan. I agree that the comment could be more accurate, so I've updated it.
Let me know if this works for you.

Close as undesired / not needed.


Added unit tests for setFileType method in FileFilter class. Fixes #14

This PR adds unit tests to verify that the setFileType method in the FileFilter class correctly sets the file type regex.

Added tests for valid file extensions (e.g., txt, pdf).
Added tests for invalid file extensions (e.g., [invalid], empty extensions).

LGTM!

hey @techy4shri,
can you add hactoberfest labels to this pr??


Generate test artefacts for Portugal

Generate test artefacts for Portugal in register-a-birth
The regression tests were failing for Portugal in register-a-birth.
See: https://ci.dev.publishing.service.gov.uk/job/govuk_smart_answers_regressions/6112/console
I think that when PR #2822 was rebased over PR #2820 the shared change
to the GRO text for North Korea needed to be regenerated.

LGTM


PSI returns >0 values where one inclusion group is 0

The return value for the case where one or both inclusion groups is 0 or the minimum coverage isn't met is -1.  However, there are results which are >0 for cases where one inclusion group is 0.
To reproduce:
inclusion_group1 <- inclusion_group1$from_url("http://snaptron.cs.jhu.edu/srav2/snaptron?regions=chr1:94468008-94472172&exact=1&rfilter=strand:+")
inclusion_group2 <- SnaptronQueryBuilder$new()
inclusion_group2 <- inclusion_group2$from_url("http://snaptron.cs.jhu.edu/srav2/snaptron?regions=chr1:94472243-94475142&exact=1&rfilter=strand:+")
exclusion_group <- SnaptronQueryBuilder$new()
exclusion_group <- exclusion_group$from_url("http://snaptron.cs.jhu.edu/srav2/snaptron?regions=chr1:94468008-94475142&exact=1&rfilter=strand:+")

psi<-percent_spliced_in(list(inclusion_group1), list(inclusion_group2), list(exclusion_group), min_count=1)

A few example sample_ids with this issue in that output:
1023
16033
10336

This issue has  been addressed.


Model keys persist in Redis after ActiveRecord::Base model destruction

When using Redis::Objects' very handy model attributes, the redis keys are not cleaned up upon model deletion.
I propose to add a cleanup method which will check Redis::Objects.redis for any keys belonging to the current object and delete any found.
This can then be added as a before_delete hook to active record or similar hooks for other ORMs, keeping it flexible. If this is welcome I will start out by adding failing tests to displaying the current behavior and then implementing my solution as suggested above.
I would love your thoughts Nate.

@nuclearsandwich or @nateware was this ever finished?

I finished a hacked out implementation, but never got the tests passing or cleaned it up, then I got hit with a wave of rough schoolweeks. I am not at the computer with my work on it at this time. Tonight I'll push what I had up to my branch If you're interested in working on it from there feel free. Otherwise I won't get to it until after the new year. But, if you don't beat me to it, I will get to it.
Sorry for the delays all, it was a rough semester.

I'd argue that this feature belongs in a separate gem specific to Redis::Objects integration with ActiveRecord instead of this project.

Closed due to lack of interest by the community in providing a patch.


Question: Are there any plans to support HTTP2 server push?

I recently found myself wanting to take advantage of HTTP2 server push. With now awesome CDN. A search through the docs and on google search indicated that this isn't yet supported https://stackoverflow.com/questions/58596759/http-2-server-push-not-working-with-zeit-now.
Are there any plans to add that in the future?
Thanks for making now. :-)

Not just you. I've been been asking about it since the day I started using Zeit and I even talked about it heavily on Spectrum. Check: https://spectrum.chat/zeit/now/http-2-server-push-not-working-with-zeit-now~f58134c3-1c74-42b4-aa40-cb391a5a44b6
I've also tweeted about it but it seems Zeit team is intentionally paying no head to it.
Checkout the tweet: https://twitter.com/iSaumya/status/1189907174866030593?s=19
HTTP/3 is around the corner. Everyone supports server push except ZEIT. Honestly this is one of the big 👎 for Zeit in my opinion. If it's still not enabled then when it is going to be? After HTTP/3 launch, when we might be taking about some other web perf thing? Good knows....

HTTP/2 is fully supported. Push will be supported in the future, but you have to keep in mind that it might not be as advantageous as you think it is:

https://twitter.com/jaffathecake/status/1191068842249863169
https://twitter.com/addyosmani/status/1191071410631798784

For the ZEIT dashboard we use <link rel=preload> at beginning of our HTML (which gets streamed from our CDN) and we are extremely happy with the results it provides, with a much simpler setup.

@rauchg First of all I have read the articles that you have given link to and still think it is very bad that Zeit doesn't support HTTP/2 Server Push yet (talking about it in Nov 2019, I mean seriously).
Now honestly I do and don't agree with those articles in some extent. If you ever watch a Google Talk or seminar, you will see it is never ever suggested to over use HTTP2 Server Push. It was created only for the critical contents. So that's where it should be used.
Regarding using preload on the HTML head (even I do that) but in this case the browser can only read the preload after getting the HTML and not getting some critical resources along with the HTML.
Also adding HTTP2 Server Push isn't critical if you are using a framework like Nuxt JS or using some serverMiddleware. You simply need to pass a Link header in the response (check the spectrum conversation for the code).
Honestly as Zeit forces to use the Zeit nameservers for domains so I can't keep the domain in Cloudflare and take advantage of HTTP2 Server Push which it supports for ages now. Anyways is there any ETA on when important feature can be expected? In the Spectrum chat one person said it's in roadmap for some time now and other person said no ETA. So, if you can atleast provide some kind of timeline, it would be really helpful.

@isaumya Thanks for sharing your side of the story. I can tell that you're quite a bit frustrated about the matter. I believe though, that it's better to voice your frustration in a more friendly manner. This issue is about sharing not ranting. I don't know about you, but I happen to use now services for free. They don't owe use anything, so friendlyness in Open source is important, otherwise the makers will loose all motivation.
@rauchg Thanks for the update.

@ChristophP man I did explained my frustration in a friendly way. I did not use any bad language or even ranted about anything. I simply stated the facts.  Also if you feel that I am frustrated with this matter, then yes and honestly the reason behind it is that I had spent many days trying to setup HTTP/2 Server Push and after multiple attempts when I could not understand what was happening I checked every possible doc including this page: https://zeit.co/blog/http2-uploads and the crazy thing is not a simple place mention that it is not available or in the roadmap and will be released in future. If it was mentioned somewhere at least I would not have wasted so much time to figure out why it is not working. Also to be very honest in my mind it never came that in 2019 any service can provide HTTP/2 support without server push as almost everyone supports that.
I am really sorry if you feel bad by reading my comments, that was not the intention. The intention was to clarify why I am asking for server push and it is not a bad thing (if implemented correctly).

Thank you for creating this issue!
Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in.
In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on.
For well-explained feature requests (like the one you just posted), please contact us at<EMAIL_ADDRESS>so that we can consider adding it to our roadmap.


Uncaught TypeError: Cannot read property 'getPath' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.0.0
System: Mac OS X 10.10.3
Thrown From: rails-open-rspec package, v0.1.4
Stack Trace
Uncaught TypeError: Cannot read property 'getPath' of undefined
At /Users/user/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:17

TypeError: Cannot read property 'getPath' of undefined
  at Object.module.exports.openSpec (/Users/user/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:17:29)
  at atom-workspace.<anonymous> (/Users/user/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:11:81)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Users/user/Downloads/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Users/user/Downloads/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Users/user/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Users/user/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Users/user/Downloads/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:180:20)

Commands
     -6:50.1.0 core:close (atom-text-editor.editor.vim-mode.is-focused.visual-mode)
     -0:10.8.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.vim-mode.command-mode.is-focused)
     -0:03.4.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:02.1.0 rails-open-rspec:open-rspec-file (atom-text-editor.editor.vim-mode.command-mode.is-focused)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "solarized-light-syntax"
    ]
  }
}

Installed Packages
# User
language-rspec, v0.3.0
rails-open-rspec, v0.1.4
ruby-slim, v0.2.0
vim-mode, v0.54.0

# Dev
No dev packages

[Enter steps to reproduce below:]

...
...

Atom Version: 1.0.9
System: Mac OS X 10.10.3
Thrown From: rails-open-rspec package, v0.1.8
Stack Trace
Uncaught TypeError: Cannot read property 'getPath' of undefined
At /Users/WeLab/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:22

TypeError: Cannot read property 'getPath' of undefined
    at Object.module.exports.openSpec (/Users/WeLab/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:22:23)
    at atom-workspace.<anonymous> (/Users/WeLab/.atom/packages/rails-open-rspec/lib/rails-open-rspec.coffee:18:81)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/command-registry.js:245:29)
    at /opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
    at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands
     -1:05.4.0 core:save (atom-text-editor.editor.is-focused)
     -0:43.5.0 core:copy (atom-text-editor.editor.is-focused)
     -0:43.2.0 core:paste (atom-text-editor.editor.is-focused)
     -0:42.1.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -0:41.6.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:40.9.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:40.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:36.9.0 core:copy (atom-text-editor.editor.is-focused)
  2x -0:34.5.0 core:paste (atom-text-editor.editor.is-focused)
     -0:28.9.0 editor:select-to-end-of-line (atom-text-editor.editor.is-focused)
     -0:28.5.0 core:select-left (atom-text-editor.editor.is-focused)
  2x -0:27.9.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:18.2.0 core:save (atom-text-editor.editor.is-focused)
     -0:17.5.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:17 core:save (atom-text-editor.editor.is-focused)
     -0:02.9.0 rails-open-rspec:open-rspec-file (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "rails-rspec",
      "rails-rspec"
    ]
  }
}

Installed Packages
# User
atom-beautify, v0.28.11
autocomplete-emojis, v2.2.2
language-elixir, v0.5.2
language-haml, v0.21.0
language-rspec, v0.3.0
linter-rubocop, v0.3.4
rails-open-rspec, v0.1.8
rspec, v0.3.2
rspec-snippets, v0.4.0

# Dev
No dev packages


Set HIDE_PRIVATE_SYMBOLS ON for manylinux packages.

This is to workaround an issue caused by conflicting LLVM
versions, first observed by since we updated Pytorch in TVM

Discussion at: https://github.com/apache/tvm/issues/9362

cc @tqchen @areusch @lhutton1 for reviews

@leandron we might also need that for conda packages and mac https://github.com/tlc-pack/tlcpack/blob/main/conda/recipe/build.sh

@leandron we might also need that for conda packages and mac https://github.com/tlc-pack/tlcpack/blob/main/conda/recipe/build.sh

I updated the PR to reflect that.


UncraftingTable-forge-1.2.6 needs MCPitanLibarch-1.5.5 or above but MCPitanLibarch is not on curseforge

to be able to use the mod in a 1.20.1 modpack it needs to have the MCPitanLibarch
lib installed and it is not on curseforge only MCPitanLib but i found it on https://modrinth.com/mod/mcpitanlibarch/

https://www.curseforge.com/minecraft/mc-mods/mcpitanlibarch


Gradle cannot download plugin.

Hi,
My repositories is
repositories {
    inherits true // Whether to inherit repository definitions from plugins

    grailsPlugins()
    grailsHome()
    mavenLocal()
	mavenRepo "https://repo.grails.org/grails/plugins/"
	mavenRepo "http://repo1.maven.org/maven2/"
    grailsCentral()
    mavenCentral()

}
dependencies {
// specify dependencies here under either 'build', 'compile', 'runtime', 'test' or 'provided' scopes e.g.
// runtime 'mysql:mysql-connector-java:5.1.29'
// runtime 'org.postgresql:postgresql:9.3-1101-jdbc41'
	compile 'com.google.http-client:google-http-client:1.22.0'
	compile 'com.google.http-client:google-http-client-jackson2:1.22.0'
	compile 'org.apache.commons:commons-lang3:3.1'
	compile "org.grails.plugins:security-stateless:0.0.9"

    test "org.grails:grails-datastore-test-support:1.0.2-grails-2.4"

	runtime 'mysql:mysql-connector-java:5.1.39'
}

plugins {
    // plugins for the build system only
    build ":tomcat:7.0.55"

    // plugins for the compile step
    compile ":scaffolding:2.1.2"
    compile ':cache:1.1.8'
    compile ":asset-pipeline:1.9.9"
	compile ":barcode4j:0.3"
	compile "org.grails.plugins:mail:1.0.7"

	compile ":spring-security-core:2.0-RC4"
	compile ':security-stateless:0.0.9'

when I do a grails clean - I get the following error
Resolve error obtaining dependencies: Could not find artifact org.grails.plugins:security-stateless:jar:0.0.9
What can I do to resolve this? I am going crazy. Thanks for any help

My mistake was I had this line in the dependencies
dependencies{    compile "org.grails.plugins:security-stateless:0.0.9" }
when I removed that, grails clean and then grails run-app, it all went away.


Comparison between this sample app and the Azure OAI studio's default app sample

Hi,
This is just a general question than an issue.  Currently, we are looking at a few approaches that we can take to work with our own data with Azure OpenAI for a customer demo. First, we took a look at this sample app repo which we can get from OpenAIStudio.
https://github.com/microsoft/sample-app-aoai-chatGPT
And then the sample that exists inside this repo. Inside the above-mentioned repo, the approach that the app has taken is really simpler than the approach that has been taken inside this repo's app. For the above-mentioned app, to use our own data we only need the Open ai studio, Blob storage instance, and a Cognitive Search instance. But in order to function the sample we have inside this repo we have to have a Form Recognizer resource as well. Therefore this app takes one additional resource and additional cost as well.
I would like to know the differences between this sample app and the app that exists in the above-mentioned repo. What are you doing differently in the application that exists in this repo?

@pasindu-pr The other repo is designed for use by customers using Azure OpenAI studio, though I also added azd support for folks who want to deploy it completely from scratch. When you are setting it up in the studio, then you can use the UI there to upload documents, and it takes care of the analysis (I presume, I've only used it from scratch). If you were to deploy this completely from scratch, then you would still need a Form Recognizer for processing the documents locally and indexing them.
So here's how I would describe the differences:

This repo includes multiple RAG (retrieval-augmented generation) approaches that chain the results of multiple API calls (to Azure OpenAI and ACS) together in different ways. The other repo uses only the built-in data sources option for the ChatCompletions API, which uses a RAG approach on the specified ACS index. That should hopefully work for most uses, but if you needed more flexibility, this repo may be a better option.
This repo is also a bit more experimental in other ways, since it's not tied to the Azure OpenAI Studio like the other repo. We are open to changes on this repo that seem to be broadly useful. For example, we may port this repo to Quart, an asynchronous framework, as that's more appropriate for I/O bound web apps.

Hope that helps!

@pamelafox Thanks for the explanation. Is there any flow you can provide , how this works. Like, I had opened a ticket with the support for the Azure Open AI studio playground and I was being told to add an indexer, so new data files can be updated. How does new data files gets picked up by the Model in this case?

@subrotomGitHub I'm afraid I do not know how the Azure OpenAI studio indexer works behind the scene, that's a better question for a support ticket. My expertise is with the open source code in this repository (which uses prepdocs.py).
Closing this issue since I've added this question as an FAQ to the repo README.

@pamelafox Thanks for clearing things up. Could you give us an explanation about one additional thing? This demo creates three model deployments in Azure OpenAI Studio: davinci, chat, and embedding. But on the Open AI default app, it only makes one model deployment. Could you explain how this app interacts with these three deployments?

This app only actually uses chat and embedding deployments, I just removed the no longer used davinci (as that's deprecated). The reason we use embedding is that this sample supports vector search, the other app does not yet support it.

You can look at chatreadretrieveread.py to see how this app calls OpenAI and Azure Cognitive Search, it makes a few calls and chains results together.


write a simple algoridhm

**
*

@pasindu-madhushan I have completed the algorithm.Can you review it.


URL::defaults are permanent and not fallback

Laravel Version: 5.6.28
PHP Version: 7.1.18

Description:
As described here https://laravel.com/docs/5.6/urls#default-values Laravel provides the option of URL defaults. My understanding of default is that there are taken in case the parameter itself is not provided e.g. to the route helper. Unfortunately the default seems to behave like a constant instead of a default. Coding or Documentation is wrong. Means when I add a parameter to the route helper which exists already as URL Default it get attached as GET-Parameter instead of overwriting the default.
Can you please have a look?
Steps To Reproduce:

Define a route with required paramter e.g. testid

Route::group( 'prefix' => 'test/{testid}/', 'as' => 'test.'], function () {
        Route::get('/', 'HomeController@index')->name('home');
});

Setup a middleware which set for this parameter a default, do not forget to register

<?php

namespace App\Http\Middleware;

use Closure;

use Illuminate\Support\Facades\URL;

class UrlDefaults
{
    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {

        URL::defaults(
           [
                'testid'  =>24,
           ]
        );

        return $next($request);
    }
}

Call the route helper with and without this parameter
{{ route('test.home', ['testid' => 12]) }} --> https://xyz/test/24?account=12
{{ route('test.home') }} --> https://xyz/test/24

I can not reproduce this, I get the expected result.  Laravel 5.6.28 PHP 7.2.7
Not sure where account is coming from in your example output.

Corrected the example replace account by testid, but issue remains.

Is your corrected example output the actual output you get now? Or the parameter is being applied only as a default fallback now?


Add in email addresses for Justin, Makena, Josh

Because this has conflicts with the main branch, I updated the changes directly!


Chore/add pr labeling

when utilizing the standard flexbase build workflow, add relevant labels to the PR for automated release management workflows.
process:

branch names will trigger a label
labels are grouped automatically for release management in github in "draft" format

I also removed the trigger for npm publish on PRs, was that meant to be the functionality?


teamcity-service-messages → 0.1.7

Explicit is better than implicit :)
https://github.com/pifantastic/teamcity-service-messages/pull/13
/cc @j0tunn

:ok:


REF DRY polling thread restarts and always start after pubnub

Refactor the Futures code so that we handle thread starts and resets from the same function. Now _begin_tracking is the one function which sets (or resets) both status polling in the thread and PubNub channel listening. Make sure that we always subscribe to PubNub before we poll. This is important because otherwise we might poll, see a running job, and miss that the job completed in between polling and subscribing.
Potential problems fixed in this refactor:

Now always polling after subscribing (the CivisFuture was polling before subscribing)
When unpickling a ModelFuture object, set the polling function before creating the polling thread (we may have gotten intermittent errors when unpickling these objects before)

@keithing , are you able to review this?

@mheilman , I had some trouble thinking of a test. The most relevant thing seems to be testing that the first poll happens after subscribing. When I tried to write that test, I realized that we had been subscribing before polling to begin with. We were setting up the polling thread before subscribing, but we only started the polling thread running the first time that someone asked for status. That can only happen after object creation.
This refactor changes the way thread starting is handled such that we always start the result thread (and therefore the polling) at the same time as we create the thread. So I think this PR doesn't solve any problems, but I still think the refactor is useful.

@mheilman , as we discussed in person, I restored the performance optimization to only start threads when we need to find job status. Tests passing.


which bam file select to invert fastq file?

I have two type of bam files:1.  D192-longissimus.flnc.bam(Split and remove the CCS sequence with primers, further filter to remove the multi transcriptional chimeric sequence)；2.  D192-longissimus.fl.primer_5p--primer_3p.bam(CCS sequences that have been split and primers removed).Therefore I don't know which bam file should select to invert to fastq file as an input file.

You want to convert the split file with primers removed. Ideally, you also want to trim the polyA tail from those reads if they still have it. Mandalorion has a tool for that. It's described in the README.

Thanks,FLNC BAM is ideal bam to fastq


User/Global Program Groups

Mimic the NT 3.x behaviour of having separate user and global program groups.
"Each user has their own set of program groups that they may edit and alter without affecting the groups of other users. There are also global groups where all users will see the same thing. Typically these groups will not be alterable by a regular user." (text copied from http://toastytech.com/guis/nt351.html )

Implementation planned, there's a check mark in the new program group dialog to do this. These groups were formerly called "Common" groups. Once regular group support works this will be added shortly after.

Planned implementation is still in the air... thinking about where to store these groups and how to retrieve them in comparison to standard program groups without things getting in the way, maybe I can read/write to the common groups key (which I would store under HKLM) before then checking and reading/writing the user key for the other groups.

Some sort of indicator a group is a common group besides having (Common) in the title would be nice as well....

Checking NT3.51 and NT4, Common groups have a computer in their default icon, perhaps do that? Admittedly doesn't work with custom icons, but for custom icons a user can probably rely on the "(common)" in the title or their own memory.
Also, maybe add a tooltip on hover so users can read the full group name when the group is minimized, so the "(common)" tag isn't obscured?
[reference screenshots for icons] :
[nt3.51]

[nt4.0]

Sounds like a good plan. Minimized groups are going to appear as title bars since Windows draws them that way at the moment, but once I've learned enough about custom drawing I can draw then 3.x style and then add tool tips.

Different default icon (if icon hasn't been changed in the dialog, change icon to common/user group depending on selected box)
Tool tips on program groups with long names when minimized

Hopefully the user's memory will take care of most of the problem. I can also draw a miniature computer over whatever icon the user picks for more clarity..


ClientCore tracing zero dependencies, no plugins

This is an early prototype of possible tracing implementation in clientcore following slf4j shim philosophy:

it has an ultra thin API wrapper around Otel API, mimicking all the API that we're going to use
it's based on reflection making otel dependency fully optional (it never appears as a dependency, but when on the classpath it just works)
no plugin necessary

TODOs in this PR:

[x] Configurability by users and libs
[x] proper instantiation
[x]  full test coverage
[x] optimization to back off and turn tracing off if something goes wrong
[x] internal logging
[x] benchmark - compare with direct calls

[x] check if there is a better way than MethodHandle.invoke

[x] agent and shading+relocation might need some additional tricks in reflection code, but seem doable
[x] url sanitization
[x] explicit inproc context propagation

[x] polish API

[x] suppression
[x]  code snippets and docs
[x] W3C trace-context propagation over the wire

TODO (follow up PRs):

[ ] Relationship between HttpLogOptions and TelemetryOptions?

[ ] Maybe merge HttpLoggingPolicy and InstrumentationPolicy?

[ ]  Move logging to telemetry package
[ ] Throw away client-request-id - replace with W3C trace context default impl
[ ] HTTP instrumentation policy

[ ] time-to-response

[ ] Metrics
[ ] Maven magic to compile with optional dependency on OTel, but not list it in the effective pom

TODO  later, when necessary:

[ ] we still want to support SPI for tracers/meters, OTel is the default implementation, but another one can be implemented and plugged in
[ ] custom (non-w3c) context propagation

Benchmarks (JAva 21):
Using ReflectiveInvoker.invokeWithArguments
Benchmark                                    Mode  Cnt     Score      Error  Units
TracingShimBenchmarks.directTracing          avgt   15   318.135 ±   84.421  ns/op
TracingShimBenchmarks.directTracingDisabled  avgt   15    34.609 ±    3.394  ns/op
TracingShimBenchmarks.shimTracing            avgt   15  3951.097 ± 1423.879  ns/op
TracingShimBenchmarks.shimTracingDisabled    avgt   15     2.499 ±    0.014  ns/op

using MethodHandle.invoke directly
invoke on method handle
Benchmark                                    Mode  Cnt    Score   Error  Units
TracingShimBenchmarks.directTracing          avgt   15  263.963 ± 0.616  ns/op
TracingShimBenchmarks.directTracingDisabled  avgt   15   15.714 ± 0.104  ns/op
TracingShimBenchmarks.shimTracing            avgt   15  337.979 ± 1.364  ns/op
TracingShimBenchmarks.shimTracingDisabled    avgt   15    2.473 ± 0.009  ns/op

Profiles:

(`ReflectiveInvoker.invokeWithArguments`)

(`MethodHandle.invoke`)

/azp run java - clientcore

API change check
APIView has identified API level changes in this PR and created following API reviews.
io.clientcore:core


HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

Description of PR
HDFS-16827
RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m  6s

trunk passed

+1 :green_heart:
compile
25m 45s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
22m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 31s

trunk passed

+1 :green_heart:
mvnsite
4m 20s

trunk passed

+1 :green_heart:
javadoc
3m 27s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 15s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 34s

trunk passed

+1 :green_heart:
shadedclient
24m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s

the patch passed

+1 :green_heart:
compile
24m 45s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 45s

the patch passed

+1 :green_heart:
compile
21m 59s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 59s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 16s
/results-checkstyle-root.txt
root: The patch generated 1 new + 162 unchanged - 0 fixed = 163 total (was 162)

+1 :green_heart:
mvnsite
4m 12s

the patch passed

+1 :green_heart:
javadoc
3m 17s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 15s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 57s

the patch passed

+1 :green_heart:
shadedclient
24m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 33s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 49s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
43m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 10s

The patch does not generate ASF License warnings.

308m 29s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

hadoop.hdfs.server.federation.router.TestObserverWithRouter

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5088

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 180bba756c18 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fe7ec7f4d050a851408a98222e4054b38983308b

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/1/testReport/

Max. process+thread count
3745 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@simbadzina @omalley Sir, can help me review this PR? Unlike GlobalStateIdContext, RouterStateIdContext should return the StateId of namespaces to Client only when the client needs them. Current, RouterStateIdContext always return the StateId of namespaces to Client, it is wasteful and the Response will be larger with more namespaces.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 56s

trunk passed

+1 :green_heart:
compile
25m 27s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
22m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 26s

trunk passed

+1 :green_heart:
mvnsite
4m 20s

trunk passed

+1 :green_heart:
javadoc
3m 31s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 41s

trunk passed

+1 :green_heart:
shadedclient
24m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s

the patch passed

+1 :green_heart:
compile
24m 44s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 44s

the patch passed

+1 :green_heart:
compile
22m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m 40s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 29s
/results-checkstyle-root.txt
root: The patch generated 1 new + 162 unchanged - 0 fixed = 163 total (was 162)

+1 :green_heart:
mvnsite
4m 29s

the patch passed

+1 :green_heart:
javadoc
3m 32s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 21s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
8m 21s

the patch passed

+1 :green_heart:
shadedclient
25m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 38s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 52s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
43m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

310m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5088

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cc04bae7f0f7 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 05288065e9a7ec53387be1803aab55bb2e42626a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/2/testReport/

Max. process+thread count
3469 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 27s

trunk passed

+1 :green_heart:
compile
26m 57s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
23m 53s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m 40s

trunk passed

+1 :green_heart:
mvnsite
4m 36s

trunk passed

+1 :green_heart:
javadoc
3m 39s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 22s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
9m 19s

trunk passed

+1 :green_heart:
shadedclient
25m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
24m 52s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
24m 52s

the patch passed

+1 :green_heart:
compile
22m  6s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 17s

the patch passed

+1 :green_heart:
mvnsite
4m 16s

the patch passed

+1 :green_heart:
javadoc
3m 20s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 12s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m 58s

the patch passed

+1 :green_heart:
shadedclient
24m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 34s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 47s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
42m 36s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  9s

The patch does not generate ASF License warnings.

314m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5088

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 84ea0850c60c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 78157c9c3677b4bb6eb965b95aa94bbce37b54ac

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/3/testReport/

Max. process+thread count
3467 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5088/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The change looks good to me. Still passes we refactored unit test in TestObserverWithRouter on trunk.

Looks good to me. Just one small typo.

@simbadzina Master, thanks for your review. I have fixed it in the last commit.
@goiri @omalley Sir, can help me review this PR when you are available? Thanks

@ZanderXu    Why this PR was closed?

@ZanderXu Why this PR was closed?

This modification is not intact, so I close it first. I will reopen it after I fix them.


update generate_consumables_item_codes_and_packages script

In past, we merged manual changes in ResourceFile_Consumables_Items_and_Packages.csv, however this supposed to be generated by script generate_consumables_item_codes_and_packages. The script need to be updated to generate the version including the manual changes.

We add here (withinm the commit RF_Cons_Items_Pkgs: add new consumables (Cystoscope, Endoscope, PSA t… ) new consumables into the RF_Consumables_Items_and_Pkgs by the generate_consumables_item_codes_and_packages script. In the PR #1124, it will need to be done manually for now as the script is not updated to generate the current version of the RF, see issue #1274.

Hi @sakshimohan, as we discussed on slack. Once you have time for this, please update the generate_consumables_item_codes_and_packages script to generate the current master version of ResourceFile_Consumables_Items_and_Packages. Feel free to reach to me with any question.
Here,  ResourceFile_Consumables_Items_and_Packages_generated.csv,
is what I think is now generated via generate_consumables_item_codes_and_packages script (only showing the part related to contraception methods as I think that's the only difference):

Intervention_Cat
Intervention_Pkg
Intervention_Pkg_Code
Items
Item_Code
Expected_Units_Per_Case
Unit_Cost

Maternal/Newborn and Reproductive Health
Pill
0
Levonorgestrel 0.0375 mg, cycle
0
7.5
48.25212

Maternal/Newborn and Reproductive Health
Pill
0
Levonorgestrel 0.15 mg + Ethinyl estradiol 30 mcg (Microgynon), cycle
1
7.5
53.35008

Maternal/Newborn and Reproductive Health
Male condom
1
Condom, male
2
120
20.97018

Maternal/Newborn and Reproductive Health
Injectable
2
Depot-Medroxyprogesterone Acetate 150 mg - 3 monthly
3
4
50.9439

Maternal/Newborn and Reproductive Health
Injectable
2
Gloves, exam, latex, disposable, pair
4
4
31.90866

Maternal/Newborn and Reproductive Health
Injectable
2
Povidone iodine, solution, 10 %, 5 ml per injection
5
4
2.00634

Maternal/Newborn and Reproductive Health
Injectable
2
Syringe, Autodisable SoloShot IX
6
4
5.4264

Maternal/Newborn and Reproductive Health
IUD
3
Gloves, exam, latex, disposable, pair
4
3
31.90866

Maternal/Newborn and Reproductive Health
IUD
3
IUD, Copper T-380A
7
1
19.39224

Maternal/Newborn and Reproductive Health
Implant
4
Gloves, exam, latex, disposable, pair
4
2
31.90866

Maternal/Newborn and Reproductive Health
Implant
4
Lidocaine HCl (in dextrose 7.5%), ampoule 2 ml
8
2
52.00062

Maternal/Newborn and Reproductive Health
Implant
4
Povidone iodine, solution, 10 %, 5 ml per injection
5
2
2.00634

Maternal/Newborn and Reproductive Health
Implant
4
Syringe, needle + swab
9
2
7.7469

Maternal/Newborn and Reproductive Health
Implant
4
Trocar
10
0.1
1203.99678

Maternal/Newborn and Reproductive Health
Implant
4
Needle suture intestinal round bodied ½ circle trocar_6_CMST
11
0.2
115.99644

Maternal/Newborn and Reproductive Health
Implant
4
Jadelle (implant), box of 2_CMST
12
0.5
447.22104

Maternal/Newborn and Reproductive Health
Implant
4
Implanon (Etonogestrel 68 mg)
13
0.5
484.97022

Maternal/Newborn and Reproductive Health
Female sterilization
5
Atropine sulphate, injection, 1 mg in 1 ml ampoule
14
1
17.99994

Maternal/Newborn and Reproductive Health
Female sterilization
5
Diazepam, injection, 5 mg/ml, in 2 ml ampoule
15
1
130.47636

Maternal/Newborn and Reproductive Health
Female sterilization
5
Lidocaine, injection, 1 % in 20 ml vial
16
1
149.99712

Maternal/Newborn and Reproductive Health
Female sterilization
5
Lidocaine, spray, 10%, 500 ml bottle
17
0.02
1244.0022

Maternal/Newborn and Reproductive Health
Female sterilization
5
Syringe, needle + swab
9
3
7.7469

Maternal/Newborn and Reproductive Health
Female sterilization
5
Gauze pad, 10 x 10 cm, sterile
18
2
14.72268

Maternal/Newborn and Reproductive Health
Female sterilization
5
Needle, suture, assorted sizes, round body
19
3
600.00276

Maternal/Newborn and Reproductive Health
Female sterilization
5
Suture, catgut, chromic, 0, 150 cm
20
3
3744.0018

Maternal/Newborn and Reproductive Health
Female sterilization
5
Tape, adhesive, 2.5 cm wide, zinc oxide, 5 m roll
21
1
426.10092

Maternal/Newborn and Reproductive Health
Female sterilization
5
Gloves, surgeon’s, latex, disposable, sterile, pair
22
2
137.45928

Maternal/Newborn and Reproductive Health
Female sterilization
5
Paracetamol, tablet, 500 mg
23
8
4.3554

Maternal/Newborn and Reproductive Health
Female sterilization
5
Povidone iodine, solution, 10 %, 5 ml per injection
5
2
2.00634

Maternal/Newborn and Reproductive Health
Female sterilization
5
Cotton swab
24
2
1.9992

Maternal/Newborn and Reproductive Health
Male sterilization
6
Gauze pad, 10 x 10 cm, sterile
18
1
14.72268

Maternal/Newborn and Reproductive Health
Male sterilization
6
Gloves, surgeon’s, latex, disposable, sterile, pair
22
1
137.45928

Maternal/Newborn and Reproductive Health
Male sterilization
6
Lidocaine, injection, 1 % in 20 ml vial
16
1
149.99712

Maternal/Newborn and Reproductive Health
Male sterilization
6
Needle, suture, assorted sizes, round body
19
1
600.00276

Maternal/Newborn and Reproductive Health
Male sterilization
6
Povidone iodine, solution, 10 %, 5 ml per injection
5
1
2.00634

Maternal/Newborn and Reproductive Health
Male sterilization
6
Suture, catgut, chromic, 0, 150 cm
20
1
3744.0018

Maternal/Newborn and Reproductive Health
Male sterilization
6
Syringe, needle + swab
9
1
7.7469

Maternal/Newborn and Reproductive Health
Male sterilization
6
Tape, adhesive, 2.5 cm wide, zinc oxide, 5 m roll
21
1
426.10092

Maternal/Newborn and Reproductive Health
Female Condom
7
Female Condom_Each_CMST
25
120
33.72222

And here, ResourceFile_Consumables_Items_and_Packages_2024-05-15_master.csv, is what we have on the master branch:

Intervention_Cat
Intervention_Pkg
Intervention_Pkg_Code
Items
Item_Code
Item_Code_Avail
Expected_Units_Per_Case
Unit_Cost
Source_Cost_Item
Source_ExpectedUnits

Maternal/Newborn and Reproductive Health
Contraception initiation
164
Pregnancy Slide Test Kit (Human - Chorionic Gonadotrophin (Hcg))_100_MM192300_CMST, strip
2019
2019
1
32.164
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Pill
0
Ethinylestradiol 0.03mg + levonorgestrel 0.15mg_Each_FP000800_CMST, cycle //80% patients//; or Microlut (Levonorgestrel 0.03mg)_Each_FP004200_CMST, cycle //20% patients//
1
1
3.75
492.9423273778
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male condom
1
Condom, male
2
2
30
20.97
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Injectable
2
Medroxyprogesterone acetate injection 150mg/mL, 1mL vial with 2ml syringe with 22g 0.7 X 25mm needle_Each_BB049500_CMST, ampule
3
3
1
481.2
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Injectable
2
Glove disposable powdered latex medium_100_HH077700_CMST, pair
1933
135
1
37.1336
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Injectable
2
Water for injections, 10ml_Each_BB077100_CMST
98
98
1
31.63
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Injectable
2
Povidone iodine 10% solution_200ml_DN004470_CMST, 5 ml sachet
5
5
1
84.78
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Injectable
2
Gauze, swabs 8-ply 10cm x 10cm_100_FF010800_CMST
75
101
1
15.6377
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
IUD
3
Glove disposable powdered latex medium_100_HH077700_CMST, pair
1933
135
2
37.1336
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
IUD
3
IUD, Copper T-380A
7
7
1
26.42
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Glove disposable powdered latex medium_100_HH077700_CMST, pair
1933
135
3
37.1336
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Lidocaine HCl (in dextrose 7.5%), ampoule 2 ml
8
8
2
309.69
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Povidone iodine 10% solution_200ml_DN004470_CMST, 5 ml sachet
5
5
1
84.78
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Syringe, needle + swab
9
6
2
200
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Trocar
10
10
0.1
312
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Needle suture intestinal round bodied ½ circle trocar_6_CMST
11
11
1
178.75
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Implant
4
Jadelle(implant)_Each_FP003700_CMST, 2 rods //50% patients//; or Implanon (Etonogestrel 68mg)_Each_FP004100_CMST, 1 rod //50% patients//
12
12
1
760.11
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Implant
4
Gauze, swabs 8-ply 10cm x 10cm_100_FF010800_CMST
75
101
1
15.6377
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Lidocaine HCl (in dextrose 7.5%), ampoule 2 ml
8
8
1
309.69
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Atropine sulphate 600 micrograms/ml, 1ml_Each_BB006600_CMST //1 unit 50% patients → 0.5 units per case//
307
14
0.5
121.25
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Diazepam 5mg/ml, 2ml_Each_BB024000_CMST
15
15
1
130.36
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Syringe, autodestruct, 5ml, disposable, hypoluer with 21g needle_Each_HH150000_CMST + Alcohol swabs/wipes 70% isopropyl alcohol 100 pieces_100_FF000300_CMST
1960
6
3
153.5155
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Gauze, swabs 8-ply 10cm x 10cm_100_FF010800_CMST
75
101
2
15.6377
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Polyamide monofilament suture sterile 1, on 40mm 3/8 circle reverse cutting needle_12_GG005100_CMST
2676
11
3
178.765
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Catgut chromic suture sterile 0, 75cm, round bodied ½ circle 40mm needle_12_GG000600_CMST
2677
11
3
306.8841667
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Tape, adhesive, 2.5 cm wide, zinc oxide, 5 m roll
21
21
0.25
1558
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Female sterilization
5
Glove surgeons size 7 sterile_Pair_HH080400_CMST
112
135
2
302.24
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Paracetamol 500mg, tablets_1000_AA049500_CMST, tablet
23
23
8
4.38683
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Povidone iodine 10% solution_200ml_DN004470_CMST, 5 ml sachet
5
5
2
84.78
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Female sterilization
5
Cotton wool, 500g_Each_FF007800_CMST
49
24
0.2
2689.81
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Male sterilization
6
Gauze, swabs 8-ply 10cm x 10cm_100_FF010800_CMST
75
101
1
15.6377
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Glove surgeons size 7 sterile_Pair_HH080400_CMST
112
135
1
302.24
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Lidocaine, injection, 1 % in 20 ml vial
16
16
1
260
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Polyamide monofilament suture sterile 1, on 40mm 3/8 circle reverse cutting needle_12_GG005100_CMST
2676
11
1
178.765
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Povidone iodine 10% solution_200ml_DN004470_CMST, 5 ml sachet
5
5
1
84.78
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Catgut chromic suture sterile 0, 75cm, round bodied ½ circle 40mm needle_12_GG000600_CMST
2677
11
1
306.8841667
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Syringe, autodestruct, 5ml, disposable, hypoluer with 21g needle_Each_HH150000_CMST + Alcohol swabs/wipes 70% isopropyl alcohol 100 pieces_100_FF000300_CMST
1960
6
1
153.5155
Malawi EHP 2021
OHT 2016

Maternal/Newborn and Reproductive Health
Male sterilization
6
Tape, adhesive, 2.5 cm wide, zinc oxide, 5 m roll
21
21
0.125
1158
Malawi EHP 2021
Malawi EHP 2021

Maternal/Newborn and Reproductive Health
Female Condom
7
Female Condom_Each_FP003500_CMST
25
25
30
22.16
Malawi EHP 2021
OHT 2016

The columns, Item_Code_Avail, Source_Cost_Item, and Source_ExpectedUnits are only filled in for contraception related items, but now with what you have done and are doing right now, these may not be needed anymore.
The purpose of Item_Code_Avail was to use an alternative item code for availability as these items were not included in the availability RF. But if I remember correctly, you fixed this already and the availability for these is now approximated with availability of similar items automatically, isn't it? If so, I will remove this in separate PR.
If I understand your current work, the unit costs in the RF_..Items_and_Pkgs will be soon updated with the Final_price_per_chosen_unit (MWK, year of original cost), is that so? There you have covered the sources of costs, could be then information about the source of that cost generated into the column Source_Cost_Item? This is where the modellers look up the information on items, so I think it would be helpful to know that too, especially the year of the cost estimate.
And I would still vote on having the Expected_Units_Per_Case, not necessarily filled for all items, but it's essential to be able to use the get_item_codes_from_package_name() fnc. Ideally if expected units coming also from the RF_Costing/consumables if also other information will be generated from there. I used two sources for the Expected units per case OHT 2016, and where not possible Malawi EHP 2021 (as suggested by Emi because the excepted units in EHP where mostly suspiciously weird). So we could add these into RF_Costing, and then only generate the final used source to appear in RF_...Items_and_Pkgs.

@matt-graham, @tamuri, @tbhallett, Could we have a test for Resource Files like this (ie, not created manually, but generated by a script) to assure no one has manually made a change in that RF?
I had no idea it was generated by a script, so I made all the changes manually, but if it caused the test to fail, I might have known.

@sakshimohan, For some reason, which I can't remember exactly, we chose different gloves for some methods than what was originally there. If you want, I think we could return it, because I don't think it's necessary. (This may have been because we wanted to have them all from the same source (EHP 2021).)

@sakshimohan
We added two new items for female sterilisation which are not in the version of RF_Items&Pkgs in the #1298:

'Polyamide monofilament suture sterile 1, on 40mm 3/8 circle reverse cutting needle_12_GG005100_CMST'
'Catgut chromic suture sterile 0, 75cm, round bodied ½ circle 40mm needle_12_GG000600_CMST'

Hence I use what used to be there before in #1298 when re-coding the consumables for contraception:

'Needle, suture, assorted sizes, round body'
'Suture, catgut, chromic, 0, 150 cm'

Would you know if there is difference between these, or should we just go back to the original items? It doesn't seem to me to be the same, but maybe it is close enough?

@sakshimohan We added two new items for female sterilisation which are not in the version of RF_Items&Pkgs in the #1298:

'Polyamide monofilament suture sterile 1, on 40mm 3/8 circle reverse cutting needle_12_GG005100_CMST'
'Catgut chromic suture sterile 0, 75cm, round bodied ½ circle 40mm needle_12_GG000600_CMST'

Hence I use what used to be there before in #1298 when re-coding the consumables for contraception:

'Needle, suture, assorted sizes, round body'
'Suture, catgut, chromic, 0, 150 cm'

Would you know if there is difference between these, or should we just go back to the original items? It doesn't seem to me to be the same, but maybe it is close enough?

Those things look very close to one another to me. If at all possible, I would certainly say to use the items that were defined originally in the ResourceFile without resorting to adding additional items.

@sakshimohan, I think we can close this PR as we do all differently now, ie we are not using the packages to get the consumable item codes in contraception module anymore and all was re-coded to use the existing names from ResourceFile_Consumables_Items_and_Packages.csv , do you agree?

@sakshimohan, I think we can close this PR as we do all differently now, ie we are not using the packages to get the consumable item codes in contraception module anymore and all was re-coded to use the existing names from ResourceFile_Consumables_Items_and_Packages.csv , do you agree?

That being the case, I think we need a PR to roll back the manual changes that were made (but now no longer used) so that we're back to the situation of the ResourceFile being regenerable from the processing scripts.


View delimiter logic in differenz screen sizes

Hey to all,
after a long time of reading manuals, issues, stackoverflow and other sites i built a custom limiter for my rectangular marzipano. My marzipano is not filling out the whole scene, thats why i have to limit the view.
This is the part of my data.js:
`// pitch is vertical moving
  "pitchMin": -0.1,
  "pitchMax": 0.1,
  // yaw is horizontally
  "yawMin": -0.55,
  "yawMax": 0.55,
  // vfov is zooming
  "vfovMin": 0.7,
  "vfovMax": 0.7,`

This is the part of my index.js:
limiter = Marzipano.util.compose(             Marzipano.RectilinearView.limit.pitch(data.pitchMin, data.pitchMax),             Marzipano.RectilinearView.limit.yaw(data.yawMin, data.yawMax),             Marzipano.RectilinearView.limit.vfov(data.vfovMin, data.vfovMax)         );
This is working fantastic on for example desktop monitor with 1920 x 1080.
On a tablet landscape view the scene is not completly visible.
Changing the orientation to portrait the visible marzipano is more cut off.
Now the problem is:
Should i set my parameters for every display resolution?
Is there a mathematically solution to calculate the parameters ?
Or is there a other solution to configure the limiter to diffent display solutions ?
Thanks
Best
Thomas

Duplicate of #134.


emailVerifyFunc: redirect to redirectURL with valid token

tests: add emailVerifyFunc test
Fixes #229
Fixes #415

server/email_verification_test.go:12: imported and not used: "fmt"

You should definitely use https://godoc.org/golang.org/x/tools/cmd/goimports :)

thanks for suggesting goimports, works like a charm :)

@ericchiang hi there, can you review this PR please? it's been a while, so if it's not going to be merged, you can close it.

Sorry can you describe how this redirects with a valid token? I would think that the only way to do so would be for the actual API which sent an email to contain a state argument.

Going to have to look into the actual code to catch up on how emails are actually sent in dex. Will follow up later today when I dig through the code a bit more.


Inject example

Please provide example how to inject packet.
PS: README.md says it is possible to use this library for packet injection but I found that pcap_inject is commented out. Is this intended?
@ebfull  can you clarify this, please?
From src/raw.rs
// pub fn pcap_inject(arg1: *mut pcap_t, arg2: *const ::libc::c_void,
//                    arg3: size_t) -> ::libc::c_int;

Hey,
I just started looking into using this library for my own project yesterday, so I don't have an example for you, but pcap_sendpacket() (src/lib.rs) may do what you want.
From man pcap_inject:

pcap_sendpacket() is like pcap_inject(), but it returns 0 on success, rather than returning the number of bytes written.  (pcap_inject() comes from OpenBSD; pcap_sendpacket() comes from WinPcap.  Both are provided for compatibility.)

@ryan-robeson thanks for pointing me to this. I overlooked it for some reason. I will try it and update this issue as soon as possible but I am on vacation right now. Thanks a lot.

Looks like this can be closed?

To me it looks that #154 provides some clues on packet injection.

To me it looks that #154 provides some clues on packet injection.


etcd cluster TPR's relation with the resources (pods, svcs) it manages

Currently a cluster has the following relations with the pods/svcs it manages:

an etcd pod will have label{"etcd_cluster": $cluster_name, "app":"etcd"}
an etcd service will have label{"etcd_cluster": $cluster_name}
they have some naming conventions making each of unique to one cluster too

Recently we are working on GC and this would make it more necessary for us to have clear definition how to correlate them.
A problem with previous relation graph is that we could have same name cluster created again. For example, cluster "A" was created and then deleted. Then "A" was created again. We want to differentiate them as two. EtcdCluster TPR object's UID would be ideal to differentiate and we could make use of OwnerReference field in pod/svc to construct relation with stronger guarantee.
Another option is to use resource version. For example, all pod/svc that has smaller resource version won't belong to a cluster. However, this is having assumptions on versions.

@xiang90
ListOptions doesn't have a way to List by OwnerRef currently.

EtcdCluster TPR object's UID would be ideal to differentiate and we could make use of OwnerReference field in pod/svc to construct relation with stronger guarantee.

Can we easily select cluster=X && owner.ref.ID!=currentTPR.ID? If yes, probably owner ref is a better approach.

@hongchaodeng
So we need to select all pods with cluster=X, and then scan over them to find all pods with refID!=currentID?

@xiang90
I feel like this is a field selector thing.
My understanding is that this isn't supported in field selector yet. In fact, a lot of fields couldn't..

@hongchaodeng
OK. Probably we should just go with refID and hope we can select in the future? It is a little bit more work than just use resource version, but it followers k8s api design. And we have a hope to directly select the bad items in the future. So I now go towards ref id approach.