folder 'public/css/' is missing

I tried to install this following the steps mentioned in the installation documentation but found that the folder 'public/css/' is missing and hence was not able to check further.

Hi @mangya
Did you make sure to run all the steps? as highlighted in the docs
The public/css folder should be created when you run gulp

Ohh... Yes.. I think I missed the step. Sorry..


weave-kube reclaim is not able to rm a dead peer if a running peer has the same hostname

As seen in https://github.com/weaveworks/weave/issues/3384#issuecomment-418461201, it's possible for a new node to have an IP addr (and a hostname) of a dead node. In this situation, the weave-kube reclaimer won't be able to rmpeer the dead node, because it doesn't identify running nodes by their peer names, but their hostname (https://github.com/weaveworks/weave/blob/v2.4.0/prog/kube-utils/main.go#L114).

Thanks for this issue! Does it mean that the peer name is determined in a unique way (as explained in the doc) but the deletion is just wrong cause it only uses the hostname?

To clarify (as noted in #3384) what is supposed to happen:

Kubernetes has a list of Nodes.
Weave Net maintains a list of Nodes that have been added as "peers" to the Weave Net cluster.

Because we don't get a chance to clean up when a Node is being shut down, we only notice afterwards
that a node has been deleted. Specifically we spot that that a node is in the second list and not in the first list.

This bug is that the 5-6 lines of code which compute the difference of those two lists are doing it on hostname not on peer name.
To cause a problem the hostname re-use has to happen before any Weave Net pod starting up has had a chance to remove it.

An idea to address this:
Store the Kubernetes UID of each Node in the peer list, then we can differentiate new Nodes that have the same name.

Using the Kubernetes UUID sounds like a good idea as we know for sure that NodeName and Hostname are not unique.


Merge pull request #2 from kdk49/master

KDK, modified semantics of current units from MA to MilliAmp, update gui grid header's current units from MA to mA

Everything looks good, will merge and test

Everything worked

psst u should rebase
bye


[PLATFORM-1443] Create an FAQ

Created an FAQ per https://frame-io.atlassian.net/browse/PLATFORM-1443

FAQ for V4 post MAX
Types of changes
This is a new file.
Checklist: Should we create a new one for docs?

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Updated with Julian's comments.

Can we rename this file to index.md inside the FAQ directory?


Auth in example app needs all users' required attributes

Currently when a request to /users/login is made in the social-network example all notNullable attributes must be there or Lux will reject the request due to missing attributes. This is not the expected behaviour when authenticating with, say, an email and password.
Could be fixed in multiple ways of course:

Update the example to use basic auth via headers
Think of a solution within Lux to allow for missing data in some cases

If this is to be "solved" in the example app by using basic auth, I could make a PR.

@nickschot you are not required to supply all not nullable attributes for custom actions. The constraints are only for built-in create and update methods.
IMO, a more appropriate solution is to move to a custom action format rather that adding basic auth.

@zacharygolba when you pass the following POST request to the /users/login route in the social-network example:
{
  "data": {
    "type": "users",
    "attributes": {
      "email"<EMAIL_ADDRESS>      "password": "qwerty12345"
    }
  }
}

You get the following response (and no query is being run in the CLI):
{
  "errors": [
    {
      "status": "400",
      "title": "Bad Request",
      "detail": "Missing required parameter 'data.attributes.name'."
    }
  ],
  "jsonapi": {
    "version": "1.0"
  }
}

This error goes away when you remove the name param from the controller, but that is of course not the desirable thing to do.

I was referring to using the meta property for the request however, that would still require whitelisting via the Controller#query array. Let me think about this one for a bit. I can't determine if this is a bug or a gap in the API.

I have "bypassed" this by creating a separate auth controller. I might update the social-network example in lux-jwt to reflect this change as I think it's a good one. This way all auth stuff like token refresh is accessible via /auth/* and is also easier/more transparently excludable from auth with lux-unless.


Polygon selection doesn't stop in example file

I can't get polygon selection to stop when trying the "Basic example" on my system. Tried clicking on the first point again (completing the loop), pressing enter/esc/space, but It just keep adding new points whatever I do.
Changing to rectangle selection while in polygon selection mode doesn't cancel it either, it just makes possible to create two selections (polygon+rectangle) at the same time:

Rectangle annotations work fine.
Am I doing anything wrong, or is it a bug?
System: Annotorious 2.3.0, Chrome, macOs Catalina, trackpad

Currently, double click closes the polygon. (Clicking on the first point as an alternative is planned.)

Or touch + hold for ~1/2 sec of you're on a touch device.

 Will look into that, thanks!

Nice, that that worked. Thank you!
I should then probably handle keydown events for Esc and Enter to cancel or finish polygon selections. And add some sort of tooltip explaining that double-click/hold finishes selections.

Just fixed the issue that the old tool keeps drawing when switching to a new one: 4b3c4deadd62c56a318245273242198e4e76eca1.


New HUD elements from the Scream Fortress XVI new maps not working correctly

Some of the new elements added alongside the new Scream Fortress XVI maps such as Dynamite, will occasionally break.
This is being actively worked on.

Fixed in e658bd225ffca21cd1e1af40f094d3e04194f1cd


Google independent notification messaging (do not rely on FCM)

With implementation of the BOLT12 it became very important to be online to receive payments.
On GrapheneOS we got this notification warning us:

Instead of relying on Google servers it would be great to have own way of delivering notification in case Google Play Services are not present on the phone.
Market standard seems to be running a foreground service. This is what Signal, Telegram, Element, ... and many other apps are doing.
There is also UnifiedPush but I am not sure if it is usable in this context (there is already issue for it here: https://github.com/ACINQ/phoenix/issues/554)
Sources:

https://github.com/Telegram-FOSS-Team/Telegram-FOSS/blob/master/Notifications.md
https://developer.android.com/develop/background-work/services/foreground-services

add support for UnifiedPush 🙏🙏🙏

The warning message about FCM could let the user choose to run the app as a permanent foreground service. It should not be too hard to do since we are already using a foreground service to run the app in the background. UnifiedPush however would need much more work.

The warning message about FCM could let the user choose to run the app as a permanent foreground service. It should not be too hard to do since we are already using a foreground service to run the app in the background. UnifiedPush however would need much more work.

comon really? Some Foss App devs are able to integrate Unified Push Support, but Aqinq cant? That just sounds like an excuse for me?

PLS add unified Push Support!


Support potential reach filtering

Ad library API calls can now include potential_reach_max and potential_reach_min parameters. Add this functionality. The result should show up in ad-level tables.

this is resolved by #74

this is resolved by #74


安装依赖时候发生错误

Collecting git+https://github.com/huggingface/peft.git (from -r requirements.txt (line 9))
Cloning https://github.com/huggingface/peft.git to /tmp/pip-req-build-rvzurjqe
Running command git clone --filter=blob:none --quiet https://github.com/huggingface/peft.git /tmp/pip-req-build-rvzurjqe
fatal: unable to access 'https://github.com/huggingface/peft.git/': Failed to connect to github.com port 443: Connection timed out
error: subprocess-exited-with-error
× git clone --filter=blob:none --quiet https://github.com/huggingface/peft.git /tmp/pip-req-build-rvzurjqe did not run successfully.
│ exit code: 128
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× git clone --filter=blob:none --quiet https://github.com/huggingface/peft.git /tmp/pip-req-build-rvzurjqe did not run successfully.
│ exit code: 128
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

请问你是怎么解决的？
我的服务器没有代理。

已解决，解决方案是使用sudo权限配置/etc/hosts文件，具体请参考
https://github.com/521xueweihan/GitHub520（记得备份一下hosts）。

已解决，解决方案是使用sudo权限配置/etc/hosts文件，具体请参考 https://github.com/521xueweihan/GitHub520 （记得备份一下hosts）。
Thank you very much for successfully resolving the issue


Adds curl command

This PR will need some work. There are some merge conflicts since yesterday and some error cases that need covering.

I am going to squash this before we merge it 💃


[ENHANCEMENT] Update dark style base map tile contrast

Is your feature request related to a problem?
Follow up from https://github.com/opensearch-project/dashboards-maps/issues/448#issuecomment-1681264523, for the dark tile style, we want to make it more contrast from current picked "Dark Matter" style.
https://openmaptiles.org/styles/#dark-matter

This is looking buggy, and it was reported as a bug when someone saw it here:
https://playground.opensearch.org/app/maps-dashboards/88a24e6c-0216-4f76-8bc7-c8db6c8705da

Can this get fixed for 2.12?

@wbeckler Yes we will have this fixed in 2.12.
@junqiu-lei  will be working on this

Hi @KrooshalUX, we'll need your team's help to prepare a color palette for the higher contrast dark style tile map, thanks!

@junqiu-lei picking up UX on this.

@junqiu-lei can we try this:
os_open_zoomstack_-_night.json.zip

@canascar This looks much better, thank you! @junqiu-lei, i'd love to see an updated in-product screenshot once we've fixed this.
@junqiu-lei, i also notice the overlays on dark mode have what appears to be hard coded colors instead of our OUI variables, leading to the popovers looking a little jank (screenshot attached) -- are we tracking that in a sepparate issue?

@canascar This looks much better, thank you! @junqiu-lei, i'd love to see an updated in-product screenshot once we've fixed this.
@junqiu-lei, i also notice the overlays on dark mode have what appears to be hard coded colors instead of our OUI variables, leading to the popovers looking a little jank (screenshot attached) -- are we tracking that in a sepparate issue?

I think this is (or will be) tracked in another issue @kgcreative

Great thanks @canascar, let me try this new dark style in-product. Thanks @kgcreative call out the overlays on dark mode, we can create one separate issue to track it.

Hi @canascar, after POC on the os_open_zoomstack-night style, I found it's data source is based on it's own scheme, it doesn’t compatible with openmaptiles schema which is used in OpenSearch maps service. Can we provide the styles based openmaptiles schema?
Some styles based on openmaptile schema:
https://openmaptiles.org/styles/
Openmaptiles schema:
https://openmaptiles.org/schema/
UK OS Open Zoomstack schema:
https://docs.maptiler.com/schema/uk-openzoomstack/

Let's try this:
https://api.maptiler.com/maps/a10841d4-071d-4356-991d-1960e9be6ac0/?key=bfrOvtYRq9ECHAjQHuzX#1.0/0.00000/0.00000
Not sure how to get parameters but here's a link to the JSON:
https://api.maptiler.com/maps/a10841d4-071d-4356-991d-1960e9be6ac0/style.json?key=bfrOvtYRq9ECHAjQHuzX

@canascar I tested the latest dark style you provided in maps-dashboards, looks good to me. Shall we update our maps service with it? @canascar @kgcreative

@junqiu-lei here Sent an updated to the map visualization JSON file. Let me know if there are any issues and when it may be able to be added to production. Thanks!

@canascar I'll have a local verification firstly.

Left: new style | Right: existing style


Intermittent failure in test_worker.py::test_compute

We have an intermittent failure in master.  I've been guiltily pressing the reload button on travis.ci to get PRs to be green.  I suspect that this is either a serialization issue or wonkiness with zmq.  Some fairly tediious testing against travis.ci suggests that the blocking line is this the router.send_multipart call in that test.
http://stackoverflow.com/questions/30271066/what-might-cause-a-zmq-router-socket-to-block

link to travis-ci failing on this
https://travis-ci.org/ContinuumIO/dask/jobs/63043536#L776


Update Spanner Database dependencies.

For the spanner database:
Update com.google.cloud:google-cloud-spanner-jdbc to 2.18.
Update com.google.api:gax to 2.48.1.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


VACMS-17226: Implements RateYourExperience component

Description
Closes https://github.com/department-of-veterans-affairs/va.gov-cms/issues/17226

Implements the RateYourExperience component
Adds the component to the Resources and Support template

Testing done/QA Steps

[ ] Ensure newly added tests pass
[ ] Manually ensure R&S pages include this component.

Screenshots

verified via storybook + at https://pr444-yomsglbpxhksa3ebcs802fo896ox8pzh.tugboat.vfs.va.gov/creating-an-account-for-vagov/
thank you!


Describe Queue List Test Failing

The Base_DescribeTaskQueue end-to-end test is intermittently failing because the pollers may not be available yet.  We might need to explore adding a wait in the tests to ensure that poller info is available at the time of request.  The test works when I add a breakpoint and wait about 5 seconds before calling Temporal server with the client.DescribTaskQueue() method.

CLOSING: Temporal is deprecated.  We're waiting for an official client.


Printing Arabic with English

is there any documentation or anyone can help on how to use both arabic, english and barcode in same print ?
thank you

Hi, @joesalloum I had a look at the official Demo application included with the StarSDK, but I can't find any examples of how to print Arabic. The only examples provided are
'US-ASCII' | English
'Windows-1252' | French, German, Portuguese, Spanish
'Shift-JIS' | Japanese
'Windows-1251' | Russian
'GB2312' | Simplified Chinese
'Big5' | Traditional Chinese
'UTF-8' | UFT8
Your best bet is to try UTF-8 or any other encoding, combined with Code Page type i.e  CP864. You can send bytes to the printer representing your characters this way. See how to print the pound £ or Euro sign for usage

please in the {appendBytes:[0x48, 0x65, 0x6c, 0x6c, 0x6f, 0x20, 0x57, 0x6f, 0x72, 0x6c, 0x64, 0x2e]}
working as charm but i need to fill the array dynamically from webservice i'm returning an array of strings and it's not working it has to be without the quotes
["0x6A", "0x61", "0x64"] doesn't work
[0x6A, 0x61, 0x64] works

i need one of the fixes or to allow the appendBytes to work with strings
or to allow the appendRaw to work as the appendBytes when using arabic hex code

Hi @joesalloum, I am afraid that the printer only takes Integers (Numbers 0x6A, 0x61, 0x64) if you send them as strings, the printCommand function thinks you want to print "0x61" instead of the charachter that it represents. You can create a function that loops through the items in your array that you received throgh webservices and then parse them to number.


Refactor: Playbook and SQL loading interface

The PlaybookProvider and SQLProvider interfaces
abstractthe details of loading playbooks and SQL. Doing
so helps keep implementation details regarding, for
instance, Consul separate from the logic of running steps.
These interfaces will also make it easier to add new
sources for sql and playbooks.

Thanks @lritter ! Assigning to @jbeemster to review. @lritter has signed the CLA.

What's the next step on this? I ran some of the stuff in the integration test folder but I don't have Consul and the lack of unit tests makes it a bit difficult to verify my code myself. If there is a documented test regime that I can follow that would be swell.

Hey @lritter the PR looks really good!  Writing a comprehensive test suite is something that we really need to add soon. I will be adding tests much like those in the Snowplow Golang Tracker which should make all of this testing much easier!

Hi. Can this be merged?

Hey @lritter - it is scheduled for the next SQL Runner release. We have a bit of a backlog to clear but yes we hope to get to this soon.


[SECURITY] Fix Partial Path Traversal Vulnerability

Security Vulnerability Fix
This pull request fixes a partial-path traversal vulnerability due to an insufficient path traversal guard.
Even if you deem, as the maintainer of this project, this is not necessarily fixing a security vulnerability, it is still a valid security hardening.
Preamble
Impact
This issue allows a malicious actor to potentially break out of the expected directory. The impact is limited to sibling directories. For example, userControlled.getCanonicalPath().startsWith("/usr/out") will allow an attacker to access a directory with a name like /usr/outnot.
Why?
To demonstrate this vulnerability, consider "/usr/outnot".startsWith("/usr/out").
The check is bypassed although /outnot is not under the /out directory.
It's important to understand that the terminating slash may be removed when using various String representations of the File object.
For example, on Linux, println(new File("/var")) will print /var, but println(new File("/var", "/") will print /var/;
however, println(new File("/var", "/").getCanonicalPath()) will print /var.
The Fix
Comparing paths with the java.nio.files.Path#startsWith will adequately protect againts this vulnerability.
For example: file.getCanonicalFile().toPath().startsWith(BASE_DIRECTORY) or file.getCanonicalFile().toPath().startsWith(BASE_DIRECTORY_FILE.getCanonicalFile().toPath())
Other Examples

CVE-2022-31159 - aws/aws-sdk-java
CVE-2022-23457 - ESAPI/esapi-java-legacy

:arrow_right: Vulnerability Disclosure :arrow_left:
:wave: Vulnerability disclosure is a super important part of the vulnerability handling process and should not be skipped! This may be completely new to you, and that's okay, I'm here to assist!
First question, do we need to perform vulnerability disclosure? It depends!

Is the vulnerable code only in tests or example code? No disclosure required!
Is the vulnerable code in code shipped to your end users? Vulnerability disclosure is probably required!

Vulnerability Disclosure How-To
You have a few options options to perform vulnerability disclosure. However, I'd like to suggest the following 2 options:

Request a CVE number from GitHub by creating a repository-level GitHub Security Advisory. This has the advantage that, if you provide sufficient information, GitHub will automatically generate Dependabot alerts for your downstream consumers, resolving this vulnerability more quickly.
Reach out to the team at Snyk to assist with CVE issuance. They can be reached at the Snyk's Disclosure Email. Note: Please include JLLeitschuh Disclosure in the subject of your email so it is not missed.

Detecting this and Future Vulnerabilities
You can automatically detect future vulnerabilities like this by enabling the free (for open-source) GitHub Action.
I'm not an employee of GitHub, I'm simply an open-source security researcher.
Source
This contribution was automatically generated with an OpenRewrite refactoring recipe, which was lovingly hand crafted to bring this security fix to your repository.
The source code that generated this PR can be found here:
PartialPathTraversalVulnerability
Why didn't you disclose privately (ie. coordinated disclosure)?
This PR was automatically generated, in-bulk, and sent to this project as well as many others, all at the same time.
This is technically what is called a "Full Disclosure" in vulnerability disclosure, and I agree it's less than ideal. If GitHub offered a way to create private pull requests to submit pull requests, I'd leverage it, but that infrastructure, sadly, doesn't exist yet.
The problem is that as an open source software security researcher, I (exactly like open source maintainers), I only have so much time in a day. I'm able to find vulnerabilities impacting hundreds, or sometimes thousands of open source projects with tools like GitHub Code Search and CodeQL. The problem is that my knowledge of vulnerabilities doesn't scale very well.
Individualized vulnerability disclosure takes time and care. It's a long and tedious process, and I have a significant amount of experience with it (I have over 50 CVEs to my name). Even tracking down the reporting channel (email, Jira, ect..) can take time and isn't automatable. Unfortunately, when facing prblems of this scale, individual reporting doesn't work well either.
Additionally, if I just spam out emails or issues, I'll just overwhelm already over taxed maintainers, I don't want to do this either.
By creating a pull request, I am aiming to provide maintainers something highly actionable to actually fix the identified vulnerability; a pull request.
There's a larger discussion on this topic that can be found here:  https://github.com/JLLeitschuh/security-research/discussions/12
Opting-Out
If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called
.github/GH-ROBOTS.txt to your repository with the line:
User-agent: JLLeitschuh/security-research
Disallow: *

This bot will respect the ROBOTS.txt format for future contributions.
Alternatively, if this project is no longer actively maintained, consider archiving the repository.
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin
(see https://developercertificate.org/ for more information).
- Git Commit Signoff documentation

If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.
Sponsorship & Support
This contribution is sponsored by HUMAN Security Inc. and the new Dan Kaminsky Fellowship, a fellowship created to celebrate Dan's memory and legacy by funding open-source work that makes the world a better (and more secure) place.
This PR was generated by Moderne, a free-for-open source SaaS offering that uses format-preserving AST transformations to fix bugs, standardize code style, apply best practices, migrate library versions, and fix common security vulnerabilities at scale.
Tracking
All PR's generated as part of this fix are tracked here: https://github.com/JLLeitschuh/security-research/issues/13

This PR needs a test that fails without the main change, otherwise it's just one commit away from a regression.

This PR needs a test that fails without the main change, otherwise it's just one commit away from a regression.

I agree! The code generator used to generate this PR doesn't have the capabilities to also generate tests. Any of the maintainers of this project are more than welcome to push additional changes to this branch to add tests.

Uh? You created the PR... you can create the test. Don't blame the tool you chose.

Uh? You created the PR...

I used a bot to create the PR on my behalf, as well as generate the fix, as well as generated fixes for 30 other OSS projects with this same bot. I'm currently working through a collection of other vulnerabilities I'm aiming to fix including generating 108 pull request to fix a bunch of OSS projects that are vulnerable to Zip-Slip.

you can create the test.
Unfortunately, this is not something I have time for right now. However, I believe this may fix a security vulnerability, do you agree? If so, consider this a security report from a security researcher, and consider treating it as such, following the Apache standard vulnerability handling profess. If you don't consider this a security vulnerability, and are unwilling to accept this change without a test (which is completely understandable) please feel free to either close this.

Well, we are all busy people, most of us here volunteers to boot; without a test I am -1 to merge, I think this should go on the queue for study and hopefully someone will take the time to create a test.i might even look over the weekend.

@ JLLeitschuh I think I understand the time limitation you have to work privately with organizations, and also to work on tests. What about integrating your tool with another existing tool like Google OSS Fuzz? I am not sure if your tool is a fuzzer, or a static or runtime analyzer that tries to use existing exploits against code bases. Maybe there are other tools like Sonarcloud that also support these analyzers.
The advantage of integrating with a tool like OSS Fuzz, for instance, is that they already have a workflow that is used by organizations like ASF, and a process for private disclosure of issues.
Otherwise, even though I believe fixing these issues is beneficial to users, in the end your pull requests may end up stalled for a long time until a volunteer has time to reproduce, add tests, prepare the CVE/disclosure, etc. And it wouldn't be doing any benefit to users or maintainers in this case.
Cheers
-Bruno

Codecov Report

Merging #371 (8065a17) into master (857a8a2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
- Coverage     85.97%   85.95%   -0.02%
+ Complexity     3089     3088       -1
============================================
  Files           200      200
  Lines          7330     7329       -1
  Branches        905      905
============================================
- Hits           6302     6300       -2
  Misses          778      778
- Partials        250      251       +1

Impacted Files
Coverage Δ

src/main/java/org/apache/commons/io/FileUtils.java
94.49% <100.00%> (-0.01%)
:arrow_down:

.../main/java/org/apache/commons/io/input/Tailer.java
85.57% <0.00%> (-0.50%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.

I am not sure if your tool is a fuzzer, or a static or runtime analyzer that tries to use existing exploits against code bases.

OpenRewrite is a Format Preserving, Abstract Syntax Tree Transformer. Basically, it's performing static code analysis to detect the vulnerability, then creating a fix by transforming the code to fix the vulnerability.
There are Gradle & Maven plugins available: https://docs.openrewrite.org/reference

@JLLeitschuh
I am sure you are well-intentioned but the path you chose (arg, pun) is not the best one for the community, please take the time to read https://commons.apache.org/security.html, specifically, an issue like this one should be reported to the security mailing list before being published in the open.

I am sure you are well-intentioned but the path you chose (arg, pun) is not the best one for the community,

I do appreciate the pun 😂

please take the time to read https://commons.apache.org/security.html, specifically, an issue like this one should be reported to the security mailing list before being published in the open.

Although I had not read the Apache Commons Security disclosure page, I assure you I am very familiar with the Apache Software Foundation's vulnerability disclosure process. I've disclosed numerous vulnerabilities to the ASF in the past. I also have over 50 CVEs to my name.
The problem that I encounter is a matter of scale. I can find tens, hundreds, or sometimes thousands of vulnerabilities in OSS with tools like CodeQL, and GitHub Code Search. The problem that I face is how to actually get those vulnerabilities fixed. I have actually attempted private disclosure to organizations when I encounterd a large scale security vulnerability in the past. It took me months of work (example).
Reporting these vulnerabilities one at a time is impractical due to the scale of the problem. I believe that, when compared with other options, full disclosure with a fix is far superior no disclosure at all.

Otherwise, even though I believe fixing these issues is beneficial to users, in the end your pull requests may end up stalled for a long time until a volunteer has time to reproduce, add tests, prepare the CVE/disclosure, etc. And it wouldn't be doing any benefit to users or maintainers in this case.

This is an unfortunate trade off of this methodology. I don't have any control over the maintainer vulnerability handling timeline. I agree that, the net benifit when looking at this on a project-by-project basis is less than ideal. But when looked at at scale, the value proposition to the entire internet becomes clearer.
I can relate to the plight of the OSS maintainer. I am one myself, although not on one with quite as many users as this project.

This change affects code that tries to exclude some files when copying a directory (to avoid https://issues.apache.org/jira/browse/IO-141). I can see how the change can help to avoid stopping some files being added to the exclusion list when they shouldn't. I tried to take the existing FileUtilsTest for IO-141 (testCopyDirectoryToChild) and to add one based on it but where the source dir is not really a parent dir of the dest dir but the existing check mistakenly thinks it is. I have such a test (below) but it works with and without this PR change.
I don't think there is any security issue here.
    /**
     * Test for https://github.com/apache/commons-io/pull/371. The dir name 'par' is a substring of
     * the dir name 'parent' which is the parent of the 'parent/child' dir.
     */
    @Test
    public void testCopyDirectoryWithPotentialFalsePartialMatch() throws Exception {
        final File grandParentDir = new File(tempDirFile, "grandparent");
        final File parentDir = new File(grandParentDir, "parent");
        final File parDir = new File(grandParentDir, "par");
        final File childDir = new File(parentDir, "child");
        createFilesForTestCopyDirectory(grandParentDir, parDir, childDir);

        final List<File> initFiles = LIST_WALKER.list(grandParentDir);
        final List<File> parFiles = LIST_WALKER.list(parDir);
        final long expectedCount = initFiles.size() + parFiles.size();
        final long expectedSize = FileUtils.sizeOfDirectory(grandParentDir) + FileUtils.sizeOfDirectory(parDir);
        FileUtils.copyDirectory(parDir, childDir);
        final List<File> latestFiles = LIST_WALKER.list(grandParentDir);
        assertEquals(expectedCount, latestFiles.size());
        assertEquals(expectedSize, FileUtils.sizeOfDirectory(grandParentDir));
        assertTrue(expectedCount > 0, "Count > 0");
        assertTrue(expectedSize > 0, "Size > 0");
        Set<String> initFilePaths = getFilePathSet(initFiles);
        Set<String> newFilePaths = getFilePathSet(latestFiles);
        newFilePaths.removeAll(initFilePaths);
        assertEquals(parFiles.size(), newFilePaths.size());
    }

    private Set<String> getFilePathSet(List<File> files) {
        return files.stream().map(f -> {
            try {
                return f.getCanonicalPath();
            } catch (IOException e) {
                throw new RuntimeException(e);
            }
        }).collect(Collectors.toSet());
    }

Hi All:
I added the above (slightly modified https://github.com/apache/commons-io/pull/371#issuecomment-1228927498) test to git master.
I am still -1 to merge this PR until a test is created to prove it indeed fixes something


Drop CI support for Ruby < 2.3

Extracted from:

https://github.com/rspec/rspec-core/pull/2787
https://github.com/rspec/rspec-support/pull/436
https://github.com/rspec/rspec-mocks/pull/1349
https://github.com/rspec/rspec-expectations/pull/1231

Repo PRs:

https://github.com/rspec/rspec-mocks/pull/1355
https://github.com/rspec/rspec-core/pull/2788
https://github.com/rspec/rspec-support/pull/443
https://github.com/rspec/rspec-expectations/pull/1232

NOT DONE (mostly JRuby-related, saved for a subsequent iteration):

Remove continue-on-error: ${{ matrix.ruby == 'jruby-<IP_ADDRESS>' || endsWith(matrix.ruby, 'head') }}
add jruby-9.1, 9.2 in ci.yml (bumps <IP_ADDRESS> to <IP_ADDRESS>)
remove jruby from travis
always use bundler 2         bundler: ${{ (matrix.ruby == 'jruby-<IP_ADDRESS>' && 1) || 2 }}
# For some reason JRuby doesn't like our improved bundler setup
yes | gem update --system --no-document - JRuby fails to install docs sometimes
yes | gem install bundler --no-document
turn on for all rubies? function documentation_enforced {/if is_mri; then

@JonRowe @benoittgt Please take a look.
I've also removed appveyor.yml along with all its traces in pull requests.

No idea why Travis DIFF_LCS builds don't pick up the right branch of rspec-rails to clone or RSPEC_CI=true trick doesn't work:
Bundler could not find compatible versions for gem "rspec-core":

  In Gemfile:
    rspec-core
    rspec-rails was resolved to 4.1.0.pre, which depends on
      rspec-core (= 3.11.0.pre)

Could not find gem 'rspec-core (= 3.11.0.pre)', which is required by gem 'rspec-rails', in any of the relevant sources:
  source at `/home/travis/build/rspec/rspec-core`

Don't think it makes much sense to fix it here.
I'd rather remove the remaining of Travis builds, hope you guys had a chance at moving DIFF_LCS and Rubinius builds over to GHA.

I would leave this PR hanging until we release 4.0.
However, in those four generated PRs I've also cleaned up Appveyor, and I don't feel too amused when thinking that I'll have to re-do this.
It would be wrong to merge those four PRs without merging this one that generated them.
Also, this work has been done. I understand that it's hard work to review the changes, sometimes even more time-consuming than "delete function" hasty removals.
There are also four other pull requests from which I've extracted these changes, waiting. And I'll have to rearrange the numerous commits there to revert the changes to those to sh files. It's not like I wouldn't have to rearrange commits there otherwise, but it feels like some additional work to do.
To sum it up, it feels like a lot of extra work upfront, and also re-doing of the same removals I've done here at a later point in time. I don't feel too enthusiastic about doing that that compared to the overhead of reviewing this.

I'll provide a short summary of what we've been discussing above in the comments.

[ ] follow-up: update rake to 13, cucumber to 2.4, will add diff-lcs to >= 1.4.4
[-] ~rethink define_optimized_require_for_rspec~
[ ] follow-up: fix kwargs delegation (with ruby2_keywords)
[ ] follow-up, probably wait for main and merge it in 4-0-dev: update JRuby to <IP_ADDRESS>/ add JRuby 9.2
[ ] drop .travis.ym: can't do, I need JRuby builds for now
[ ] revert most of the changes to script/functions.sh/script/predicate_functions.sh/script/update_rubygems_and_install_bundler - I'm personally not sold on the tradeoff of redoing vs code review overhead
[ ] remove RSPEC_CI - rspec-rails sub-builds on Travis will break (JRuby are the only ones left)
[ ] inline bundle_install_flags to remove dependency of script/functions.sh on the presence of .travis.yml
[ ] follow-up (the last, since least important): get rid of most of the <<-/chomp/unindent/undent/gsub in favour of <<~
[ ] follow-up (post-4.0?): clean up travis naming in build functions

@JonRowe Do you want me to squeeze in some of the above changes in this PR, or ok with addressing in follow-ups?
Is this PR (and related generated PRs) good to merge as is?

Rebased 4-0-dev on main, and this PR onto 4-0-dev.
Incoming update from main made it possible to remove .travis.yml (no Travis builds left!).
I'll send generated pulls when https://github.com/rspec/rspec-core/pull/2785 is green - rspec-core's 4-0-dev is not yet in line with other repos in terms of CI matrices.


F1 World Grand Prix in windows11

attached is the log

had to apply a nocd crackt to get it to start, but once it does it goes to the menus fine but then crashes when the race is about to start. the game ran fine in windows10 for me. I am hoping there will be a solution for it in windows11
DDrawCompat-F1wgp.log

I'd like to add my considerations to this thread started by Buechnerstod (that I presume is the same guy who started a similar thread on DxWnd forum).
The game is F1 World Grand Prix released in 1999, not to be confused to the later release F1 World Grand Prix 2000, similar name but quite different architecture.
We are testing this game with DxWnd because it seems to need an option to ignore some exception (I'll investigate that apart, since it seems related to the MS Sidewinder Precision Pro) that can be provided by DxWnd, but probably as well as some other shim.
What puzzles me now is that the game has invisible parts (some text in the menus and some sub-menu tabs) that on Win11 affect the game both in native mode, with DxWnd and with DDrawCompat. But curiously dgVoodoo2 is able to fix the problem (though I couldn't make it run the 3D part yet). I am attaching some screenshots taken with DxWnd and the different ddraw wrappers.
I am wondering if you could detect the problem, fix it in DDrawCompat and suggest a solution for DxWnd as well.
P.s. the game is available on MyAbandonw*re.

The crash doesn't seem to be DirectX related to me, or at least I couldn't see any obvious indication of it from debug logs. I don't have time to debug it further for now.
@ghotik I don't have any missing text in the menus with DDrawCompat. Are you sure the issue is not caused by DxWnd? I noticed none of your screenshots are with DDrawCompat alone.

I didn't add a screenshot in native mode because the game has some difficulty to start in this way, so I had to run it with DxWnd using also the tweak to ignore some exceptions. But what puzzled me was the fact that DxWnd alone or DxWnd+DDrawCompat showed the problem while DxWnd+dgVoodoo2 was working correctly, in some way exonerating DxWnd from being the culprit.
Now I repeated the test without DxWnd. The game alone doesn't start, but adding the DDrawCompat ddraw.dll it now starts and shows the same problem. Beware: the problem is not limited to text only and it is better seen in the options menu (in effect, the main menu shows a different problem but the test is perfectly visible there).
I also tried to capture a screenshot with DDrawCompat alone as you wanted, but unfortunately it was not possible: the game selects a video mode that turns all screenshots into a black rectangle.

Strange, I can capture screenshots too. It should work fine with the FullscreenMode=borderless setting. Are you using the latest DDrawCompat release, v0.4.0? Only earlier releases should have the black screenshot problem. Here is one from my system, with the config overlay enabled, just to show that it's running with DDrawCompat v0.4.0:

And you can also see in the background that the text is fine. This is all with default settings.
Please upload the debug logs of DDrawCompat (running without DxWnd).

wow i did not see that there wa sa config overlay - how does one acces that in a game
F1wgp for me though has athe much bigger bigger problem of its AI and car physics being completely broken now in windows11  - it ran fine on my previous asus rog windows10 computer, but now the AI wont drive faster than 40kph upon race start and it basically refuses to do any overtakes, its as though it now thinks every other car that is near it is like some obstacle i must incredibly slow near - its all really weird and makes the game completely unplayable
if you can run teh game Narzoul and if you have windows11 tell me if you find that also.

I see you still haven't read the Configuration wiki, which I pointed out in your other issue also. :) You can show/hide the overlay with shift+f11, like the wiki says.
I have the same experience as you with Win11, the game crashes before entering the race, so I don't know how AI/physics would behave.

yes sorry i havent gotten round to reading th config wiki, but i didnt even imagine it would contain info on an ingame overlay, i just assumed it would be the case thatone makes some text conf file - i hadnt got back to it as i had not gone back to trying to slow down how fast "Napoleon's Battles" plays yet

I start to believe that this game is baffling me (or us).
I run it alone (no DxWnd) with DDrawCompat last release v0.4.0 in debug build (compiled in release profile) and on my computer the game still misses some surface display, same behavior as before. I tried then to get a screenshot and this time I succeeded (who knows why with the non-debug release I got a black rectangle) but the screenshot captured only one tiny part of the screen, by the way the only part where text was visible!
Anyway I got a log for your reading, and maybe an interesting theory: one of the operations that I did while blindly clicking on the missing text was to increase the game resolution from the default 640x480 to a higher value. Is it possible that the different behavior depends on the lower resolution in your testbed (behind the overlay panel I can see a 640x480 resolution value) ? The captured part is 800x600 pixel, another couple of numbers that usually remind something...
Well, I don't know, I suspect that there is some vicious mix of ddraw, GDI32 and windows here, quite a graceful mess.
DDrawCompat-F1wgp.log

I tried changing the resolution setting in the menu, but it doesn't change the menu resolution at all, and the text is still correct for me. Maybe DDrawCompat doesn't work well with old Intel drivers anymore, I couldn't test it in a long time since I don't have such a GPU anymore (my "new" Intel GPU only runs on D3D9On12).
Maybe try changing the DisplayResolution setting in DDrawCompat.ini to "app", in case it's some issue caused by DDrawCompat's display scaling.
I assume your desktop DPI scaling is set to 100%. Anyway, I tried changing that too, but can't reproduce the issue that way either.
Your logs are only release logs (info level). You need to change LogLevel to "debug" in the config, or use the Debug build profile, which defaults to that.

Hmm, the game seems to load those texts via GDI into a ddraw surface, then probably copies it somewhere purely via locks and CPU (I don't see any blits from that surface, even in my own logs), so it's hard to track what's happening.
Just to rule out any driver issues, could you try setting also ForceD3D9On12=on in DDrawCompat.ini? There are some issues with color keying (e.g. with the cursor) when using that, but at least the text still shows correctly for me with it.

Wow, quite a different result: now all the text is visible, the only (new) problem now the black cursor sprite.
And this time it was possible to capture the whole screen.

I went into my copy of f1wgp and wanted to try the overlay but found i didnt have actually ddraw compat in use, so i put it in the game folder and the game graphics are all messed up when i do that
what can you suggest i do to fix this in ddraw compat. If i remove the ddraw.dll file the graphics are back to normal, though the menus are still having issues like ghotik had.
I wanted to see if the fpslimiter in ddrawcompat might fix teh weird physics/ai issue going on
i did try out the overlay despite the weird graphics - if i make change there, is that change applied right awy or does it only work after restarting?

i also dont see the option in the overlay to force d3d9on12 - where is that, and also i wanted to export the ini file but not all the options get exported,
if i want to change the fps from teh ini file, what do i need to type exactly? could you provide perhaps a list of how the text commands should be written if one is using the ini file instead of the overlay?
I did try and change things in the overlay but nothing changed at all regardless of what i did, it was like the overlay was not functioning at all

okay i did some playing aroudn with teh ini file details that show up and the colour issue is fixed - not sure what the trick was  - maybe the ccolour depth set to 32?
i set the fpslimiter to 30 but the ai issues still remain - cars crawl off the start grid and when they eventually decide to start moving their top speed is only around 140-150 - not sure if that that is kph or 140-150mph , but either way it is still much slower than what the cars normally drive at in the game

okay some more weirdness found - if i race some tracks the graphics are fine, ie - I tried Italy and Austria, both fine... but if i try Monaco then the graphics are missing all textures, - i have changed nothing in the settings yet a differnt track completely wrecks the graphics.
this issue does not occur if i am just using Dxwnd,  only if i use ddrawcompat with dxwnd.
If i could just stick with dxwnd for thhis that would be great but ddraw compat actually has now solved the AI issue it seems
I added in the winversionlie = xp line to the compat file and  now the ai runs fine.

this is my log
DDrawCompat-F1wgp.log

Okay - i am having the issue where i got some things working before but then was trying ddrawcompat and now coming back to just Dxwnd, i am finding the game is no longer starting -its just a black screen.
are there some shims elsehwere stored that i need to clear or something?
if though there is someway to ensure that monaco actually works in DDrawcompat that would be great
oddly also dgvoodoo doesnt work for me for this game - crashes when race starts to load everytime

The Monaco one seems to have some fog issue. If you increase the fog intensity even slightly in the in-game graphics menu, it displays fine. It just doesn't work with 0 intensity for some reason.

okay cool i will try that then

Another discovery: the 0 fog intensity is only broken if "D3D Render T&L DLL" is selected in the main menu options. With "D3D Render DLL" it works correctly. It has the same behavior with native ddraw, so at least it's not a DDrawCompat bug.
I think the problem with Monaco is that it initializes fog intensity to 0, which is probably not what it's supposed to be. Other tracks have non-0 fog at the start, and they will also break (when using T&L) if it is manually set to 0. On one of my test runs, actually Monaco started also with non-0 fog, but I couldn't reproduce it again. This might all have to do with those invalid memory access errors when the map is loaded, which is currently skipped by DxWnd (or by the IgnoreException shim in my case). Maybe someone can test on an older system (that doesn't have those exceptions) what should be the default fog settings for Monaco, and if fog is broken at 0 intensity with T&L there too.

Is there anything still unresolved in v0.5.0 here? Besides the game bugs that are not really in DDrawCompat's scope (random exceptions and such).


sequin data obtain

Hi @XueyiDong ,
I would like to use the sequin data, but I am unable to access it through the link provided in the paper. Where can I obtain this data?

Hi @tauChange ,
Thank you for your interest in using our data! I have uploaded the sequin annotation here: https://github.com/XueyiDong/LongReadRNA/tree/master/sequins/annotations.
Best wishes,
Xueyi


Not working as of version 4.19

This plugin no longer works in UE4.19, where I am still having this ID mismatch problem(Despite Epic's insistence that it's been fixed)
When I launch the editor after installing the plugin, a pop up appears stating that the binaries in the plugin are corrupt or incompatible with this(4.19) engine version. I've been bashing my head against manually reassigning element IDs for each and every import for over a year now, it's finally gotten untenable. If there's any chance it's reasonable for you to recompile for 4.19 I'd appreciate it!

Hi @MusaFuchs.
I'm sorry I'm only reading your issue now.
Do you still need this? I guess I could try recompiling it, but I'm not sure it would work since it was designed to fix a specific bug on Unreal 4.14.


✅ Add Unit Tests

Overview
Add unit tests
Motivation
Unit Tests are used to ensure the code performs as it should after any changes. This can prevent bugs from making it into any releases or pre-releases.
Possible Implementations

Microsoft Unit Testing Framework for C++
Google Test
CTest

There's also https://github.com/boost-ext/ut


Add utc-check for campaigns.all time fields

I found out the hard way, that the timezone in the fields before_create_time, since_create_time, before_send_time, since_send_time in the campaigns list view have to be UTC.
You can test this by creating a campaign and then using since_create_time with e.g '+01:00' timezone.
The endpoint ignores the timezone and just checks for the datetime itself in UTC, so it will not find the campaign.
So, the same as it is done in campaigns.actions.schedule, those fields should be added as datetime objects and then a UTC-check could be added.

Our API does not process queryparams arguments at all, as that is expected to be processed be the end user beforehand. We perform processing on any actual post data sent through as those will cause hard errors, but logic errors caused by incorrect queryparams do not technically cause the API to malfunction, it simply returns unexpected results. My plan is to simply update the docstring wherever those queryparams are indicated (which I believe is more endpoints that simply campaigns.all()). If there is dissenting opinion from the other maintainers, we will look into a different solution as needed.


[WIP] region: Add accelerate regions schedule API

Add one new region HTTP API.
What problem does this PR solve?

close https://github.com/pingcap/pd/issues/2593
What is changed and how it works?
Add one new region related http api to accelerate regions schedule by given key range.
Check List

Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note

Support Region HTTP API to promote regions schedule by given key range

/run-all-tests

I think https://github.com/pingcap/pd/issues/2524 wants to solve a similar problem. Maybe we can find a common way to do it?

I think #2524 wants to solve a similar problem. Maybe we can find a common way to do it?

IMO not very alike.

Basically LGTM. But I wonder if we need to support a large number of regions in the range. One optimization method is to directly save the range, and then scan the range with higher priority first when scanning.

@rleungx @disksing  Ready to be reviewed.

/run-test

/run-all-test

/run-all-tests

@sre-bot /merge

/merge

/merge

/merge

LGTM

/merge

LGTM

/merge

/run-integration-ddl-test

/run-cherry-picker


The path is not of a legal form (Superhot)

Today's UtinyRipper
Initialize engine version: 5.3.5f1 (960ebf59018a) according to output_log.txt
Game: Superhot (current Steam version)
UtinyRipper.exe level23

[...]

Export: 'wpn_pistol_fire(AudioClip)' exported
Export: 'TunnelsOutStart(AudioClip)' exported
General: System.ArgumentException: The path is not of a legal form.
   at System.IO.Path.NormalizePath(String path, Boolean fullCheck, Int32 maxPathLength, Boolean expandShortPaths)
   at System.IO.Path.InternalGetDirectoryName(String path)
   at UtinyRipper.FileMultiStream.Exists(String path)
   at UtinyRipper.FileCollection.FindResourcesFile(ISerializedFile ifile, String fileName)
   at UtinyRipper.Classes.AudioClip.ExportBinary(IExportContainer container, Stream stream)
   at UtinyRipper.AssetExporters.BinaryAssetExporter.Export(IExportContainer container, Object asset, String path)
   at UtinyRipper.AssetExporters.AssetExportCollection.ExportInner(ProjectAssetContainer container, String filePath)
   at UtinyRipper.AssetExporters.AssetExportCollection.Export(ProjectAssetContainer container, String dirPath)
   at UtinyRipper.AssetExporters.ProjectExporter.Export(String path, IEnumerable`1 assets)
   at UtinyRipper.Program.Load(IReadOnlyList`1 args)

Same thing happens if trying to rip file level1.
Ripping sharedassets0.assets works.
At the beginning, the following warning shows:
Import: Asset collection has versions probably incompatible with each other. Here they are:
Import: 5.3.5f1
Import: 5.3.4p1
Export: Can't export 'Arial(Font)' because it isn't valid
Export: Can't export 'Font Texture(Texture2D)' because it isn't valid

For some files, there are more export failures for fonts/font textures.

Sorry, I don't think that I can fix it without file, unfortunately.

Should be fixed in f18ba8cd21c3e828b55c284c575e663de5db78d9


Show more on td-message doesnt work anymore

Hi,
On the documentation (https://teradata.github.io/covalent/#/components/message/overview) when I click on show more, nothing happens.
Could you fix the issue?
Thanks

Moreover in the example:
<td-message #message label="Label" sublabel="Sublabel goes here" icon="warning" color="primary | blue | red" [opened]="true">
View More
<button td-message-actions mat-button (click)="message.close()">Close
// .. body goes here

Whatever I put in the body section, it ll never appear.
Could you take a look on it too?


Delta Tables usage using Datasets Library

Feature request
Adding compatibility of Datasets library with Delta Format. Elevating the utilities of Datasets library from Machine Learning Scope to Data Engineering Scope as well.
Motivation
We know datasets library can absorb csv, json, parquet, etc. file formats but it would be great if Datasets library could work with Delta Tables (with delta format) as it has different features such as time travelling, layout optimization, query performance, aids in Data Engineering.
This will help and enhance Datasets library from Machine Learning utility to Data Engineering utilities and expand horizons thereafter. I am totally using Datasets library in all my usecases and as my role expands so does the work, compatibility with Datasets library is something I don't want to lose.
Your contribution
Would love to work on this feature, even if this has to picked up from scratch, including design paradigms and patterns.
I have basic idea about Delta Live Tables, would brush it easily for this feature.

Hi ! Interesting :) Can you provide concrete examples of cases where it can be useful ?

Few example blogs and posts that might help on this -

https://hevodata.com/learn/databricks-delta-tables/
https://docs.databricks.com/delta/index.html

Basically, we are looking at utility of Datasets library with Delta Lake Tables.

datasets can already read/write from parquet from/to a cloud storage using fsspec, if I understand correctly it's should be possible to load parquet files as delat lake tables no ? :) Or is there someting missing ?

@lhoestq Per my understanding, delta lake table is a bunch of paruqet files together with the meta to support ACID. For example file 1 contains v0.1 of record A while file 2 contains v0.2 of record A. I am assuming the Hugging face dataset would delegate the read/write delta table to 3rd party lib, maybe pyarrow. Correct me if I was wrong @reichenbch
And I am assuming, people are asking the versioning of Hugging face datasets. But I am assuming Hugging face delegate this function to github and it is not the key requirement for Public Data set. It actually the key function of ML Ops, I am not sure whether hugging face would like expand to that area.


Add Destination attribute to LogoutResponse

Add Destination attribute to the LogoutResponse to be compliant with the spec.
See section <IP_ADDRESS> and <IP_ADDRESS> of http://docs.oasis-open.org/security/saml/v2.0/saml-bindings-2.0-os.pdf

If the message is signed, the Destination XML attribute in the root SAML element of the protocol message MUST contain the URL to which the sender has instructed the user agent to deliver the message. The recipient MUST then verify that the value matches the location at which the message has been received.

Without the Destination attribute, PingFederate (at least in 6.10) will reject the LogoutResponse.

Thanks for the pull request!  Merged & published as 0.9.2.


Wrong link in CONTRIBUTING.md

The 'General Info' link in Additional Resources section should probably be this

closing this as it's already fixed, just wrong reference in the PR commit


Use fileName instead of Path when dealing with file systems directly

Attempt to fix #7154
Because some times the file name case sensitivity we assumed about the file system is not correct, we should not use canonical paths when dealing with file systems directly, like when watching a file or opening a file.
With this change, the impact of wrongly assumed case sensitivity is limited to the situation where there are two files whose file names only differ in casing. However that situation should be problematic in other ways in the place, so not a very high priority.

:+1:


the code to find the similarity

Hello, first of all, thank you for your work! Where is the code to find the similarity between the images in the support set and the query set? thank you!

Hi, you can find the PCB module here, and this line executes the calibration operation.


schemaPath is different between AWS Lambda and local execution

The version of Ajv you are using
8.11.0
The environment you have the problem with
AWS Lambda
description
when validating invalid data
Results in node.js v8+
also occurs with sam local invoke
,"errors":[{
    "instancePath":"/join_ts",
    "schemaPath":"depot:com.<redacted>/analytics/user_ctx/2-0-0/properties/join_ts/format",
    "keyword":"format",
    "params":{"format":"date-time"},
    "message":"must match format \"date-time\""
}]

Results and error messages in your platform
  "errors": [
        {
          "instancePath": "/join_ts",
          "schemaPath": "#/properties/join_ts/format",
          "keyword": "format",
          "params": {
            "format": "date-time"
          },
          "message": "must match format \"date-time\""
        }
      ]

if schema ID is not part of the schema itself, then it will be taken from the key, so you must be providing a different key in that env - it doesn't seem to be an issue with ajv at all.

the code is exactly the same. I tried modifying it to ensure the schema with $id is at the top-level and now I get the #/... schemaPath in my unit tests.
code is dynamically loading schemas like this:
init:
const ajv = new Ajv({
    allErrors: true,
    async loadSchema(uri) {
      return await depot.get(uri); // <- wrapped http client
    },
  });

fetching schemas:
...
 ajv.getSchema(s) ??
                (logger.debug("fetching schema:", { schema: s }),
                await ajv.compileAsync({ $ref: s })
...

and the modified version is like
...
 ajv.getSchema(s) ??
                (logger.debug("fetching schema:", { schema: s }),
                await depot.get(s)
                  .then((s) => ajv.compileAsync(s))
...

how is schemaPath calculated?
ps: what do you mean by "the key" and how do I pass it to ajv?

in this case ajv.compileAsync uses schema URI as the key, if it is missing in the schema doc. You either need to have the same URIs (probably impossible in different envs), or define schema IDs (that's what I'd do), or you'd have different paths in errors.


feat: handle input arguments and return value of Cairo programs

Cairo functions (even main) can have input arguments and a return value.
Add required logic to parse them, assert them to the memory and validate the types(?).

Hi, is this open for contribution? I'm interested in taking the issue.

Hi sorry, this issue is not open.
But there are hints to be implemented, your contribution would gladly be appreciated :)


Cloudpresser/user details tooltip

Details

Create a UserDetailsTooltip component, which uses 4 props, avatarSource, name, handle, and children
UserDetailsTooltip returns a Tooltip component with a custom renderTooltipContent and passes it's children into it, like this:

const UserDetailsTooltip = props => {
    const { avatarSource, name, handle, children } = props

    return (
        <Tooltip
            renderTooltipContent={()=> (
                    <View>
                        <Avatar
                            containerStyles={[styles.actionAvatar]}
                            source={avatarSource}
                        />
                        <Text>{name}</Text>
                        <Text>@{handle}</Text>
                    </View>
                )}
            children={children}
        />
    )
}

Pass additional props to ReportActionItemFragment for avatarSource, name,  and handle here
https://github.com/Expensify/App/blob/fc30ddc7a6877b3c690fe2ccdb8275403e019c54/src/pages/home/report/ReportActionItemSingle.js#L123-L130

<UserDetailsTooltip {...props} /> will then be used instead of <Tooltip {...props}/> here:
https://github.com/Expensify/App/blob/fc30ddc7a6877b3c690fe2ccdb8275403e019c54/src/pages/home/report/ReportActionItemSingle.js#L103-L110
and here:
https://github.com/Expensify/App/blob/fc30ddc7a6877b3c690fe2ccdb8275403e019c54/src/pages/home/report/ReportActionItemFragment.js#L146-L153

Fixed Issues

$ https://github.com/Expensify/App/issues/20086
$ https://github.com/Expensify/App/issues/20086#issuecomment-1574538614
Tests

[x] Verify that no errors appear in the JS console
[x] Run app on web
[x] Hover over the user name or image on a chat
[x] Verify new tooltip style is being used
[x] Modify defaultProps to use handle as it's not currently being returned:

const defaultProps = {
    avatarSource: null,
    name: '',
    handle: 'testHandle',
};

[x] Verify component renders well with and without a handle and name

Offline tests

[x] Native and mobile platforms do not apply, verify app does not have regressions (no-op)
[x] Verify that no errors appear in the JS console
[x] Run app on web
[x] Hover over the user name or image on a chat
[x] Verify new tooltip style is being used
[x] Modify defaultProps to use handle as it's not currently being returned:

const defaultProps = {
    avatarSource: null,
    name: '',
    handle: 'testHandle',
};

[x] Verify component renders well with and without a handle and name

QA Steps

[ ] Native and mobile platforms do not apply, verify app does not have regressions (no-op)
[ ] Verify that no errors appear in the JS console
[ ] Run app on web
[ ] Hover over the user name or image on a chat
[ ] Verify new tooltip style is being used

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome
Does not apply (component does not render on mobile)

Mobile Web - Safari
Does not apply (component does not render on mobile)

Desktop

iOS
Does not apply (component does not render on mobile)

Android
Does not apply (component does not render on mobile)

Still waiting for a high-traffic account at<EMAIL_ADDRESS>

I have read the CLA Document and I hereby sign the CLA

@cloudpresser let's make sure the tooltip is also getting the proper styling. And can you try setting a handle manually in Onyx to show what it looks like with the handle as well.

@cloudpresser let's make sure the tooltip is also getting the proper styling. And can you try setting a handle manually in Onyx to show what it looks like with the handle as well.

In order for to handle the case with no handle or name, the dimensions of the overall tooltip should probably use paddings instead of a fixed height. Looking at the screenshots I can only guess the value for those margins, could you tell me:

What is the distance from top of avatar to the top of the tooltip
What is the distance from bottom of handle to the bottom of the tooltip

Alternatively I could extract it from the design files, but I'm not sure where or if I can access those.

@cloudpresser For style consistency , we can use same style used in ReactionTooltipContent.js
https://github.com/Expensify/App/blob/5739db4953e1546ba2aa113d0a16d26bfc0c8898/src/components/Reactions/ReactionTooltipContent.js#L44-L59

Are you suggesting I use this for the name? It looks like these styles do not match the ones on the screenshot @puneetlath shared. I was looking at styles.h4 for title and styles.textMicroMuted (to be created) for handle
textMicroMuted: {
        color: themeColors.greenIcons,
        fontFamily: fontFamily.EXP_NEUE,
        fontSize: variables.fontSizeSmall,
        lineHeight: variables.lineHeightSmall,
    },

We have a console warning as well

Just resolved this. Sorry, that got lost in a stash earlier

Are you suggesting I use this for the name?

I am suggesting to use same template , same style classes , change emoji code with avatar , emoji name with handle ...

That makes sense, and saves me from guessing on those paddings. Thank you for the suggestion and for clarifying

@fedirjh  I have not been granted a high traffic account yet. My understanding is I should use that to test cases like the one you found a bug in, is that right? I requested it twice so far on slack<EMAIL_ADDRESS>

@cloudpresser just made<EMAIL_ADDRESS>a high traffic account.

Still working on this. The tooltips I had not accounted for are a bit of a deeper hole than anticipated. Will need to come back to it after lunch time. Expect another update before 5pm EST.

Getting in a groove but my time is out for today. I'll be back tomorrow, expect more updates before 12pm. Realistically, I may have addressed all remaining by 5m EST tomorrow.

How are things going here?

I think variable width is fine, given that email addresses can also be variable. I believe that's how they are today also.

Hey @puneetlath @fedirjh, I am still working on this. Today I was able to implement the tooltip on all the highlighted locations, but have not yet fixed the bug as @fedirjh mentioned here.
Tomorrow, I am planning on focusing on this bug as I have not yet found the source of it, and maybe implement @fedirjh's suggestion because it does seem very good and something I thought of but haven't had enough context to come up with yet.
@fedirjh I'll also be rebasing these commits tomorrow to make sure they're signed.
It really does look to me like we'll be able to close this tomorrow. I'll have the day off on my job too, so more time to focus on this than the last few days.

Ok thanks for the updates!

@puneetlath @cloudpresser I have another suggestion that we can consider. Instead of passing all props down to the UserDetailsTooltip component, we can modify it to only accept the email (login) as a prop. Then, we can connect the UserDetailsTooltip component to Onyx.personalDetails and use the email to retrieve data from personalDetails. I believe implementing this change will enhance the maintainability of the code.

This plan sounds good, however we should use the accountID instead of the email address and use the personalDetailsList object in Onyx instead of personalDetails. We are in the process of migrating from personalDetails to personalDetailsList which is keyed by accountIDs instead of emails. personalDetailsList will contain different data depending on the user. Sometimes it might include their login/displayName/etc. Sometimes it might just have their avatar.
So that would actually work well here. The only case where it wouldn't work is for mentions, which don't currently have an accountID associated with them. But I'm fine with just leaving mentions to use the old tooltip for now.

I think it's not worth it. Mentions will be updated in the near-ish future to be accountID-based. For now I think it's fine to leave them using the old tooltip.

@cloudpresser still on track to have this ready for final review today?

And I just want to be sure, the changes in this PR gracefully handle the scenario where any of these fields aren't set: displayName, login.

Today is not my day. I'll work on this over the weekend.

Ok sounds good. I'll also be working on the weekend, so ping me when you're ready for more review.

I'm also happy to extend the 50% bonus timeline if we can get this merged by Monday.

Sounds good, I'm already working to make that possible

@puneetlath I think I'm ready for further review. I completed:

[x] Fixed bug
[x] Refactored to use accountID
[x] Implemented in details page
[x] Reverted changes mentions, as they are pending refactor
[x] Rebased commits to be signed
[x] Fixed other small issues

For some emails<EMAIL_ADDRESS>the tooltip is not showing , for mentions as well .
Screen.Recording.2023-06-10.at.11.10.45.PM.mov
Screen.Recording.2023-06-10.at.11.19.05.PM.mov

Fixed the<EMAIL_ADDRESS>email scenario. It was an issue with the fallback object. Not sure what happened with mentions because we're no longer touching it in the PR. However, it is possible it was impacted by a fallback absence, because they are working on my local branch after the fix.
https://github.com/Expensify/App/assets/59715908/17a9ded2-96c4-4511-90a2-a64527b47cab

Ok nice! I'll take another look later today. Thanks for the hustle!

@cloudpresser It look like you made some changes to src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js and that's break the mention tooltips. can you please take a look , here is the local PR branch

That doesn't match my current diff, I changed it back in Revert "feat(userDetailsTooltip): use it in mentions"

@fedirjh let's go ahead and file a separate bug for that. I have a vague memory of that being raised and it may even be fixed already.

How are things looking in general to you @fedirjh? Do you feel we are close to merge?
@cloudpresser I see we still have a lint error. Looks like you need to run npm run prettier

do you think we need any style enhancements or the actual result is good ?

Ah, I see that much earlier there was a question about padding. In figma we have 16px on the sides and 12px on top/bottom of the tooltip. And then 8px between avatar and name. Otherwise style looks good to me.

@cloudpresser prettier error again.

Yes, sorry I am very used to doing prettier through eslint. Adjusting my settings...

@puneetlath Code looks good to me. there is one little case , if the user remove their names , the name will fallback to their email , and that will cause the tooltip to display email twice.

I can check if they're the same and hide the greyed out email. I'm committing it now but can reverse if that's not expected behavior.
Like this:

Sounds good. I like that.

Updated

@cloudpresser tooltips looks good and works well for most case , however I found some cases where tooltips doesn’t show , for example if we search for a multi participants conversation let's say 8 , the search result doesn’t have tooltip , IT doesn’t show on header as well , I think we should add a fallbackUserDetails to DisplayNames , we should update ReportUtils.getDisplayNamesWithTooltips to return avatar + login along with displayName and accountID , Note that the tests are with email that doesn’t have an accountID:
Multiple emails:

### Multi Participants Report Header
 Screen.Recording.2023-06-12.at.2.17.22.PM.mov
### Search result
Staging	Dev
 Screen.Recording.2023-06-12.at.2.02.01.PM.mov
 Screen.Recording.2023-06-12.at.2.42.34.AM.mov
### Details Page
 Screen.Recording.2023-06-12.at.2.45.39.PM.mov

Modifying ReportUtils.getDisplayNamesWithTooltips works!

Updated

Search 8 participants with displayName and email

Header 8 participants with displayName and email

Details page
https://github.com/Expensify/App/assets/59715908/34f11a0f-5754-45aa-8834-a80390d48ae2

Thank you both so much for your persistence and urgency on this one! It's really much appreciated. Looking forward to more contributions from you @cloudpresser.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.27-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

I just reported this, but it seems we didn't handle the case for Workspace Avatars https://expensify.slack.com/archives/C049HHMV9SM/p1686821040533159

This PR adds UserTooltip and while testing we failed to catch inconsistency in the user tooltip due to a missing account id from the new task page.


Export enum values from package

It would be very helpful to export the enum values used in the interfaces, so that as a consumer or the library I can avoid hard-coding magic numbers when interpreting the results.

The problem is that this is a mostly-auto-generated API client, and we need the underlayer to expose these for us. We have an issue for this here: https://github.com/googleapis/toolkit/issues/1756.

googleapis/toolkit#1756 looks perfect, thanks for the quick response. Related to this is also a problem with docs, where https://cloud.google.com/nodejs/docs/reference/language/1.1.x/google.cloud.language.v1#.Type is a union of Document.Type and EntityMention.Type, but should presumably be separated.

(Un?)fortunately, this request (https://github.com/googleapis/gapic-generator/issues/1756) was closed, since this was to be addressed via TypeScript.


NaN in longwave radiation flux

We see some NaNs in the longwave radiative fluxes. For example, here is the instantaneous rlut in this run at the last time step before it breaks:

The latest RRTMGP change (v0.16.0) doesn't fix it.

The clear-sky longwave fluxes have NaNs too. Here is rlutcs:

It's because the variable in the sqrt is negative here: https://github.com/CliMA/RRTMGP.jl/blob/b8e6d09b555e4a60d5832f2129d5048d765f10f1/src/optics/Optics.jl#L247

This should be fixed by the latest atmos update #873


Add more content to cni README.md

I've been chasing a bug and looked a bit more at the code - added my notes to the README in case others need to do the same. It's a draft, please let me know if anything is too low level.
Please provide a description of this PR:

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test release-notes

lint_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test release-notes

lint_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test lint

unit-tests_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@costinm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test unit-tests

lint_istio
33d50ce94e34cba6308237c2c3fd54618f549072
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I just documented what I understand from the code - before I forget.
Doesn't mean I like it - or that I understand all the cases, but at least
it's
written down and others can fix what I got wrong..
My hope is that CNI vendors will handle this natively - with some cleaner
API, and maybe with a vendor-neutral fork of istio-cni
providing a polyfill. I think the danger is users installing 2 CNI plugins

and then having the code that attempts to keep
the installer in a certain state and the iptables fight with each other.
But we'll need to clean up our mess.

On Wed, Jul 12, 2023 at 2:40 PM John Howard @.***>
wrote:

@.**** approved this pull request.
In cni/README.md
https://github.com/istio/istio/pull/45952#discussion_r1261750711:

+Istio CNI injection is currently based on the same Pod annotations used in init-container/inject mode.

+TODO: list all supported annotations, which are working on ambient, plans for long-term support as CRD/broader than Istio.
+
+### Selection API
+
+- plugin config "exclude namespaces" applies first
+- ambient is enabled if:

namespace label "istio.io/dataplane-mode" == "ambient" is required (may change for 'on-by-default' mode)

"sidecar.istio.io/status" annotation is not present on the pod (created by injection of sidecar)

"ambient.istio.io/redirection" is not "disabled"
+- sidecar interception is enabled if:

"istio-init" container is not present in the pod.

istio-proxy container exists and

does not have DISABLE_ENVOY environment variable (which triggers proxyless mode)

has a istio-proxy container, with first 2 args "proxy" and "sidecar" - or less then 2 args, or first arg not proxy.

This is definitely not fragile 🙂
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/45952#pullrequestreview-1527270721,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2TYF7ZZC5DJHOJ67F3XP4KUNANCNFSM6AAAAAA2GMKXXI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
c07ee83038589ae5f0e05903b15b5321214a3462
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
7b6419d08c9eaf226eb69101b7b0fa9bdafcb3ea
link
true
/test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote-mc


react/destructuring-assignment should forgive the use of this.props.hasOwnProperty

Destructuring the props is a good practice because it shows at the top of the function scope which parameters are being used. However, the hasOwnProperty is built-in and destructuring it doesn’t reveal much

It definitely shouldn’t, since hasOwnProperty should never ever under any circumstances be called directly on anything. You want Object.prototype.hasOwnProperty.call(obj, key) instead.

That is handled by no-prototype-builtins in eslint core though (although it's not in the recommended preset)

Very true! Hopefully everyone has that rule enabled.
Which, is why I don't think the destructuring-assignment needs any special rules around it.
Separately, there's literally no value in checking if a prop is passed or not - undefined and "absent" should always be treated the same, no exceptions - based on that, I'm going to close this.


Don't Merge! Regression PR perf testing with metadata validation

Docs Build status updates of commit 47794b6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/overview/azure/TestingPullRequest.md
:warning:Warning
View
Details

:warning:Warning

Details

api/overview/azure/TestingPullRequest.md

[Warning-InvalidMetadata] Metadata with following name(s) are not allowed to be set in Yaml header, or as file level metadata in docfx.json, or as global metadata in docfx.json: content_type. They are generated by Docs platform, so the values set in these 3 places will be ignored. Please remove them from all 3 places to resolve the warning.
[Warning-W.UndefinedValue] the value invalid_type is undefined for metadata content_type
Line 7: [Warning-InvalidFileLink] Invalid file link:(~/api/overview/nonexisted1.md).
Line 8: [Warning-InvalidFileLink] Invalid file link:(~/api/overview/nonexisted2.md).
Line 9: [Warning-InvalidFileLink] Invalid file link:(~/api/overview/nonexisted3.md).

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.
[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update IP and MAC tables on administrator->internet site

These tables are updated according to the last radius and dhcp configs. Since we updated these these tables aren't updating at all.

What do we need here exactly?

If we don't want to search in the logs by hand, we could get the user logging in (with their wifi username and MAC address) from the radius log and their IP at the time from the dhcp leases file using the MAC address acquired from the radius log

So the radius log file is located at /var/log/freeradius/radius.log, the leases file at /var/lib/dhcp/dhcpd.leases. Both can be read without sudo. So we just need to write a script getting the mac address from the radius log, linking it with the user, storing it in the database, then opening the leases file and searching for the IP address using the MAC.
Last time we agreed, that the MAC address should be sufficient, as IIG will likely tell us the MAC not just the IP.
I also think, that we should come back to this issue after #158 is ready, otherwise there will be a lot of unnecessary work with it.


Update arc to 0.11.0 and azcli to 0.3.0 - Insiders

Updated arc extension to 0.11.0 and azcli extension to 0.3.0 to go with the Azure Arc enabled Data Services release today.
I will merge in this PR after this one is approved and merged in to bump the version numbers of the extensions in their respective package.json: https://github.com/microsoft/azuredatastudio/pull/17932

@alanrenmsft I'll be gone by the time the VSIX is built for this, can you handle updating the gallery once that's done tomorrow?

@candiceye please remind me tomorrow.

@candiceye please remind me tomorrow.

Will do. To clarify, the reason we must wait for tomorrow is because the vsix files must be generated in the nightly build, right? @alanrenmsft

Yes. If you need to get these updated ASAP then we can figure something out, but otherwise it's generally better just to get the VSIXs from the daily scheduled builds.

gallery updated


Update travis for coveralls

Need to update godeps so build works from a fresh install.  Update .travis.yaml to not require sudo and use new gocoverdir script I wrote to make coverage more dependable.

coveralls is down right now.  Ignore that part being yellow


Slider component missing from v1.0

Current beta is missing Slider component

[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

As per existing Material-UI
Current Behavior

Steps to Reproduce (for bugs)

Context

Currently preventing upgrading to the new generation of material-ui
Your Environment

Tech
Version

Material-UI
v1.0 beta

React
16

Duplicate of #4793