Failed to import asciinema-player (missing "type": "module"?)

Describe the bug
I'm trying to use Asciinema with Svelte. When I try to import * as AsciinemaPlayer from 'asciinema-player';, I get an import error, which Node suggests may be due to an incorrect configuration.
To Reproduce
Steps to reproduce the behavior:

npm i -D asciinema-player
import * as AsciinemaPlayer from 'asciinema-player'; within my Svelte project

(node:118652) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
11:18:02 pm [vite] Error when evaluating SSR module /src/components/AsciinemaPlayer.svelte: failed to import "asciinema-player"
|- /home/migue/Source/portfolio/node_modules/asciinema-player/dist/index.js:4719
export { create };
^^^^^^

SyntaxError: Unexpected token 'export'
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

Expected behavior
I am able to import and use the Asciinema player.
Versions:

OS: Fedora 40
Browser: Firefox Developer Edition 127.0b2
Node: v18.18.2
asciinema player: 3.7.1

Additional context
Note Node's suggestion to fix the issue:

Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.

I have checked, and your package.json does not have a "type": "module" entry in it, which would explain why the export statement is failing.

Opened a PR which will hopefully resolve this. #260


Exception: Unable to download user-data, cookies missing?

Using Python 3.10 (virtualenv), installed hbd through pip.

Obtained the cookie through Chrome (since it easily exposes them), copied it into the clipboard as is.
Copied its value (quoted)
Ran hbd -s $cookie -l library --progress

Got error:
Exception: Unable to download user-data, cookies missing?
Am I doing something wrong or this is just not working currently?
Please note I did a quick search (while logged into my Humble Bundle account, into Library) and I could not find the tag hbd is trying to find in the code.
   logger.debug("Library request: " + str(library_r))
        library_page = parsel.Selector(text=library_r.text)
        user_data = library_page.css('#user-home-json-data').xpath('string()').extract_first()  #i noqa: E501
        if user_data is None:
            raise Exception("Unable to download user-data, cookies missing?")

I exported the cookies from FF, converted them using curl (as in the docs), and I get the same message.

I ran into this also. The quotes in the cookie value are part of the value, so wrap it single quotes
hbd -s '"askdjasldj...asdljk"' -l library --progress

I ran into this also. The quotes in the cookie value are part of the value, so wrap it single quotes
hbd -s '"askdjasldj...asdljk"' -l library --progress

I can confirm that works, thank you. This should be addressed in the code and/or documentation fixed.

I met the same error and had the same thought to escape the quotes as above. Unfortunately, this didn't work for me using Python 3.10 on Windows via Powershell:
hbd -s '"coo...kie"' -l .\HumbleLibrary\ --progress
hbd -s "`"coo...kie"`" -l .\HumbleLibrary\ --progress

In the end I worked around it using an Ubuntu WSL installation that I had handy.
I'm not sure if someone more experienced with Powershell and Python on Windows would know why it didn't work for me?

Wrapping the quote in single quotes worked for me

"""KEY""" worked for me by the way

I had a similar issue, and it appears that the cookie value was old, and would no longer work.
In my case, I copied the data from another browser on a different computer, which had two _simpleauth_sess cookie values:

I chose the most recent value, pasted it into the command on another machine, and everything started magically working.

@Aviv-Galmidi Sadly, that doesn't work for me in Powershell 5.1 and 7.2.1. But...
However, it does work in Command Prompt! That an easier and more accessible workaround than using WSL like I did. 😄

I tried all of the above on a Cygwin installation and it didn't work until I cleared ALL the humble bundle cookies and got a new session key from a fresh login. (I used the single quotes around the key)

I encountered this issue as the cookie value I passed was false: the copy of the value of the cookie in my browser only took a part of the value.


Mvtp permissions doesn't work

Information

Server version: Paper version git-Paper-267 (MC: 1.16.4)

Full output of /mv version -p: https://paste.gg/p/anonymous/8001d8491e4543848ece17521875df86

Help request
Problem
I'm trying to disable access to Nephta_nether world through /mvtp command (but still accessible via NetherPortals) via permissions.
What I have tried
I added permission multiverse.teleport.self.w and disabled multiverse.teleport.self.Nephta_nether permission, but I can still teleport to Nephta_nether.

I tried disabling multiverse.teleport.self.w permission and enabling per world teleport, but when trying to mvtp the plugin says that i'm missing a permission.

I also tried with the permission multiverse.teleport.self.w:WORLDNAME or multiverse.teleport.self.w.WORLDNAME, but nothing works.
Is the problem with the permissions I use ? Or is there any bug ?
(I want to add that my permission plugin works fine with all my others plugins.)
Thank's in advance for your help !

There is no per-world permissions at the moment. Probably only be implemented when we revamp the perm system, but it wont be anytime soon. Basically #1292


Data management - photos

quite the labrinth.  Not all the directories of photos are inventoried here since there are so many and because many are perhaps not that helpful.
Could be mistaken with this initial summary but we can attempt to track corrections in this issue
related to https://github.com/NewGraphEnvironment/mybookdown-template/issues/25 and https://github.com/NewGraphEnvironment/mybookdown-template/issues/26
Site photos
- Resized, sorted and renamed photos are here ~/Library/CloudStorage/OneDrive-Personal/Projects/2023_data/skeena/photos
- Photos uploaded to mergin during field surveys. Resized here - /Projects/gis/sern_skeena_2023/ignore_mobile/photos_resized.  These should
- Initial versions of resized photos from mergin, surveyor cameras and data cards photos - ~/Library/CloudStorage/OneDrive-Personal/Projects/repo/fish_passage_skeena_2023_reporting/data/photos.  NOTE - our past convention of having duplicated "repo" names for directories that are not actually the .git versioned repos we store on github is something that needs to stop as it is ripe for creating confusion.  This will not be the convention in the future.
photos of field cards

fish - ~/Library/CloudStorage/OneDrive-Personal/Projects/2023_data/skeena/fish
fiss site cards - ~/Library/CloudStorage/OneDrive-Personal/Projects/2023_data/skeena/fiss
pscis fish passage assessment cards - I don't think these are amalgamated in a fully time sorted manner in one location at this time.  This would be good practice since we use those for QA and since every once and a while data is collected on paper card only for one reason or another - so will hopefully come back to this.  And edit this line with strikethrough of last sentence and insertion of location. Of relevance - ~/Library/CloudStorage/OneDrive-Personal/Projects/repo/fish_passage_skeena_2023_reporting/data/photos/site_cards has some photos of cards that from quick review appear to be dropped into this directory during hand sorting of the remaining photos.

photos now move from shared drive to repo here https://github.com/NewGraphEnvironment/fish_passage_skeena_2023_reporting/blob/ec3ace3211d67b86be9191fa840815116ba1ab68/scripts/run.R#L9
when photos are added the metadata is also updated with line below


Fixed build on ppc

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
I'm still investigating the further effects of this change.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Instead of using Built-in protobuf, using compiler toolchain 8.* on ppc also fixes the build.


[question] How to manage Git fork

I want to take the API and the Dashboard, for the Storefront, I will develop it from zero with react native, my question is, how do I manage this on git:

I make a fork of saleor-platform repository, remove the storefront and create another repository with my custom storefront and include it as a submodule?
Fork individually each of the repositories that I need (Dashboard and API) and I clone them on my machine and simply create my own storefrond repository and put aside the other ones. In this case what happend with parent saleor-paltform files like docker-compose.yml.

Other associated questions

Why use submodules and why not subtrees?
What is the recommended road according to Saleor to manage this kind of scenarios on git. Where I just want to get some modules(API and Dashboard) and keep them updated with changes made by the source repository, and do the rest myself(Storefront) and mantain that repository on my side.

Why use submodules and why not subtress?

I second your second associated question (no pun intended)
What is the recommended road according to Saleor to manage this kind of scenarios on git
Or, in general, what are people doing here in terms of git setup and flow.

I second your second associated question (no pun intended)
What is the recommended road according to Saleor to manage this kind of scenarios on git
Or, in general, what are people doing here in terms of git setup and flow.

I'm using git clone --bare --mirror for each repo, and editing the config file to point to the new repos. This works as a new recursive git, which can be pushed to, and pulled from.
With this relatively simple setup (emulating the missing git clone --bare --mirror --recurse-submodules), it is possible to fetch any upstream changes (and cope with any merges). In principal, it's possible to fork each repo, then bare mirror them, re populate the recursive structure and push it all back to the fork. It's quite a lot of work to emulate git fork --bare --mirror --recurse-submodules, unless I am missing something obvious.
I've only just started with the clone --bare --mirror setup, so there are bound to be teething issues, but it's passing local CRUD tests, bar no updates have occurred upstream to test against!

... on the other hand, in an ideal world, all saleor development is done using apps, plugins, metadata and runtime environment, so it's best to design accordingly?

Platform now relies only on official Docker images. This should make keeping up with Saleor releases much easier.


Add initial support for data-source to web.xml extension

Add support for the data-source element.
For more information see the jakartaee:data-sourceType definition in https://jakarta.ee/xml/ns/jakartaee/jakartaee_9.xsd

@Thihup This is the initial support for the data-source element in web.xml. Have a try ;)


Filters through merge

Earlier I was talking with @hendrikmakait  about https://github.com/dask-contrib/dask-expr/issues/302 and was wondering what this was all about and why it was not supported yet.
The implementation was pretty straightforward and I ended up taking the test cases from the issue and adding to it. I'm sure there are more edge cases that are not handled well.
One thing that troubles me is that the way I ended up implementing AND concatenated conditions is not working because the optimizer drops one of the conditions. From what I can tell so far this is because the dependents at this point https://github.com/dask-contrib/dask-expr/blob/b588a9e15e90e0567061664ffc01374786686e20/dask_expr/_core.py#L293-L303 are not recomputed. the earlier simplify_up steps could alter the dependents such that they are no longer valid at this point. recomputing this (or breaking) fixes this but this causes all sorts of other things to break. Primarily the stuff with combine_similar in the test name

Moving the filters is still too aggressive, here is a reproducer, it needs to take dependents into account before doing anything
df = pd.DataFrame({"a": [1, 2, 3], "b": 1})
ddf = from_pandas(df, npartitions=2)
df2 = pd.DataFrame({"a": [2, 3, 4], "c": 1})
ddf2 = from_pandas(df2, npartitions=2)
merged = ddf.merge(ddf2, on="a", how="left")
rhs = merged.c.sum()
result = merged[merged.a > 1].assign(c=rhs)
result.simplify().pprint()

this pushes too aggressively, which was the main reason that I didn't add this while we had combine_similar, that would have broken my brain and was one of the motivators that I wanted to get rid of it
 Assign: c=
  Merge: how='left' left_on='a' right_on='a'
    Filter:
      FromPandas: frame='<pandas>' npartitions=2
      GT: right=1
        Projection: columns='a'
          FromPandas: frame='<pandas>' npartitions=2
    Filter:
      FromPandas: frame='<pandas>' npartitions=2
      GT: right=1
        Projection: columns='a'
          FromPandas: frame='<pandas>' npartitions=2
  Sum:
    Projection: columns='c'
      Merge: how='left' left_on='a' right_on='a'
        Projection: columns=['a']
          FromPandas: frame='<pandas>' npartitions=2
        FromPandas: frame='<pandas>' npartitions=2


Make it possible to disable Metrics healthcheck - close #321

New checkbox in "advanced" section:

I updated this PR to includes fixes for the 3 findbugs violations

@vinodkone could you please review this PR ?

@Lucas-C, thanks for you patch. Would you mind updating it to 1.x?

Done
Once this is merged, you may want to add this new field to this list on the master branch for backward compatibility: https://github.com/jenkinsci/mesos-plugin/blob/master/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java#L89


[Discussion] World seed

Should the world seed be public?

I'd suggest keeping the seed private, to prevent people from using structure finders or instantly getting all the great spells.

It's up to you, if you want this server to be more chill, you can make it public, but if you want it to make more difficult, then you can keep it private. I think its just about how server goes

The seed should be private. There's no utility it provides except for people trying to exploit it. While it is possible to find it out regardless through funny techniques, there's no real point to it in my opinion.

I'd suggest keeping the seed private, to prevent people from using structure finders or instantly getting all the great spells.

we (plan on) lootr
so loot is per-player anyways
but eitherway private seed is better


Execution of the command buffer was aborted due to an error during execution. Caused GPU Timeout Error

Details

I have built an app that is available in beta test now for some users, and they all told me that there is a very weird bug when they try to go out of the app on iOS.
-> on newest iOS devices, when you have finished using an app you start swiping up from the edge bottom of the screen until you go back to the iOS Home screen page.
For the first time during debug, i was able to reproduce this behavior and unfortunately i have not come across this again using devtools...
Here is the last trace i have got from this exact issue :
Execution of the command buffer was aborted due to an error during execution. Caused GPU Timeout Error (00000002:kIOGPUCommandBufferCallbackErrorTimeout)
Execution of the command buffer was aborted due to an error during execution. Caused GPU Timeout Error (00000002:kIOGPUCommandBufferCallbackErrorTimeout)
Execution of the command buffer was aborted due to an error during execution. Caused GPU Timeout Error (00000002:kIOGPUCommandBufferCallbackErrorTimeout)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)
Error submitting command buffer: Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)

I spare you the remaining lines.
I am calling few methods in :
@override
  void didChangeAppLifecycleState(AppLifecycleState state) {
    LogManager.w("App state is : $state");
    switch (state) {
      case AppLifecycleState.resumed:
        break;
      case AppLifecycleState.inactive:
        LogManager.d("App is inactive from home");
        method1();
        method2();
        method3();
        method4();
        method5();
        break;
      case AppLifecycleState.paused:
        LogManager.d("App is paused from home !");
        break;
      case AppLifecycleState.detached:
        // TODO: Handle this case.
        break;
    }
    super.didChangeAppLifecycleState(state);
  }

This doesn't happen all the time that's why it's weird, or it means i am always near the edge of the GPU performances...
Does it mean that i am doing something wrong in my app ?
If you could tell me more about it i will really appreciate.
In the meantime, i will try to get this error again using DevTools.
PS : I am not building a game, it's more a chat app with photos and videos and the camera.
Target Platform: iOS
Target OS version/browser: iOS 14 and above
Devices: iPhone XS Max, iPhone 12, iPhone 11 pro, iPhone 13 pro max
Logs

Logs

[✓] Flutter (Channel stable, 2.10.0, on macOS 12.2 21D49 darwin-x64, locale fr-FR)
    • Flutter version 2.10.0 at /Users/foxtom/Desktop/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (5 days ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/foxtom/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.63.2)
    • VS Code at /Users/foxtom/Desktop/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (3 available)
    • Now You See Me (mobile) • 00008020-001204401E78002E • ios            • iOS 15.3 19D50
    • macOS (desktop)         • macos                     • darwin-x64     • macOS 12.2 21D49 darwin-x64
    • Chrome (web)            • chrome                    • web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@Tom3652
Although it's a bit hard to know what exactly could be causing this, but Caused GPU Timeout Error seem to indicate that there could be an error in the process which triggers the log.
Are you using any images, animations or network calls that might be taking a bit time to load ?
A reproducible code or a pattern would be helpful to debug further.
Thanks.

Hi @darshankawar thanks for the explanation.
Yes i am using all of this, especially cache_network_image that downloads photos from ListViews.
But at the moment i am closing the app as mentioned above, i am not doing anything special such as scrolling the ListView or anything so i could even guess that all downloads were finished.
I am also using the ResizeImage after the CacheNetworkImage to avoid extra large images loaded in memory for nothing (inverted oversized images seen using DevTools) but this may come with this price to pay, i don't know...
I am using video_player to play videos in these same ListViews.
I believe i have followed all of the best practises i have found in flutter documentation to set this all up and preventing crashes / OOM.
This error is painful as the smartphone is completely frozen and the user can't do anything for few seconds before it crashes or comes back to normal at the end of the "non-responding" state.
It would be very hard to make a reproductible code sample as it happens let's say 20% of the time in conditions that i can't really figure out myself and in release mode.  I would have provided it here if i had identified a pattern or a specific package that would cause this.
Again as mentioned above, it's the first time i can see the logs of this behavior in debug mode, it's has been one year i am developing this app already and this behavior started to happen when i started to have content in my app, so yes photos - videos - camera.
So based on your thoughts, it would be caused by image - video processing or network calls ? I don't have any animation going on when closing the app this way on iOS.
The only thing i have is the call to these 5 methods when the state is inactive.
These methods are making few network calls actually (they are also all async internally), but why would they block the UI thread ?
My app is a social media app behaving the same as Instagram to give you a better insight.

Thanks for the further details. I see a similar log in this issue, although it's labeled for add2app, but the steps to replicate is something you can try in your app and see if you get the log again: https://github.com/flutter/flutter/issues/61914#issue-662453316

I faced same problem. I'm using video_player and cached_network_images

Hi @PavelSmertin, are you using Native views as well ?
Yes @darshankawar i could try to do this, but i have not native views / pages in my app so i don't think it's the same use case :/

Hi @PavelSmertin, are you using Native views / pages as mentioned in the previous comment ? Yes @darshankawar i could try to do this, but i have not native views / pages in my app so i don't think it's the same use case :/

i don't use any native views

I am using video_player to play videos in these same ListViews.

Are you properly disposing the videoController and making sure that the videos are getting disposed by GC ?

Yes of course, i have actually several lists with several players playing at the same time sometimes but low resolution videos to not load too big files and they are disposed accordingly.
In the build() method i have bool values to tell if the player should be playing or pausing the video that's all.

case AppLifecycleState.inactive:
LogManager.d("App is inactive from home");
method1();
method2();
method3();
method4();
method5();
break;

What is the content of these methods ?
Assuming you are putting app in background when this state is invoked, the engine probably won't render anyting from these methods.

It's only network calls, but you are right in 2 of them have a notifyListeners() from 2 of my providers, it may be the cause then.
I will update this and see if i still get the error, thanks for your help !

It seems indeed this was related to "too intense" UI reload when state become inactive.
I have not frozen my app again, thanks again for your time.

Reopening.

A reproducible code or a pattern would be helpful to debug further.

Along with your latest flutter doctor -v and log.

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-x64, locale fr-FR)
    • Flutter version 2.10.4 at /Users/foxtom/Desktop/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (3 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/foxtom/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.65.2)
    • VS Code at /Users/foxtom/Desktop/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.3 21E230 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 99.0.4844.84

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

The logs are exactly the same as the above, i will try to make a reproductible code sample based on my app's behavior and update here.

I have the same problem I was not using the network to load pictures or videos. I occasionally encountered this error in my demo project. The device is iPhone 12 iOS 15.4
Execution of the command buffer was aborted due to an error during execution. Ignored (for causing prior/excessive GPU errors) (00000004:kIOGPUCommandBufferCallbackErrorSubmissionsIgnored)

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3 21E230 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.10.4 at /Users/liurichao/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (4 weeks ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/liurichao/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.66.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.38.1

[✓] Connected device (4 available)
    • RVL AL09 (mobile)      • JUBNU18715105704          • android-arm64  • Android 9 (API 28)
    • KnightsiPhone (mobile) • 00008101-001A24220CF1003A • ios            • iOS 15.4 19E241
    • macOS (desktop)        • macos                     • darwin-x64     • macOS 12.3 21E230 darwin-x64
    • Chrome (web)           • chrome                    • web-javascript • Google Chrome 100.0.4896.127

[!] HTTP Host Availability
    ✗ HTTP host https://maven.google.com/ is not reachable. Reason: An error occurred while checking the HTTP host: Operation timed out

! Doctor found issues in 1 category.


Update clap to v3.1.5

We have been excluded it from dependabot, not sure how to re-enable it.

@dependabot


Final modifier inheritance in Electrical.Analog sources

It is
model RampVoltage "Ramp voltage source"
  parameter SI.Voltage V(start=1) "Height of ramp";
  parameter SI.Time duration(min=Modelica.Constants.small, start=2) "Duration of ramp";
  extends Interfaces.VoltageSource(redeclare Modelica.Blocks.Sources.Ramp
    signalSource(final height=V, final duration=duration));
  // ...
end RampVoltage;

i.e. signalSource.height is redeclared with a final modifier. However, it is not the case in StepVoltage, e.g.,
model StepVoltage "Step voltage source"
  parameter SI.Voltage V(start=1) "Height of step";
  extends Interfaces.VoltageSource(redeclare Modelica.Blocks.Sources.Step
  signalSource(height=V));
  // ...
end StepVoltage;

Is there a special reason or is this just an inconsistency?

The correct way is to use "final" in a modifier for parameters. However, I guess that there are many places in MSL where final is not used.

The changes of a0d8187286dfdb6b2a0379e11b3e78e8e48b92db broke quite some models of the MSL.
Example Modelica.Electrical.Analog.Semiconductors.HeatingDiode:
The original implementation
extends Modelica.Electrical.Analog.Interfaces.ConditionalHeatPort(useHeatPort=true);
was replaced by
extends Modelica.Electrical.Analog.Interfaces.ConditionalHeatPort(final useHeatPort=true);, so the heat port is always on  -- which is not the intention of the model.
When running the test example Modelica.Electrical.Analog.Examples.HeatingRectifier then Dymola complains that the final parameter heatPort gets overwritten again by
 Modelica.Electrical.Analog.Semiconductors.HeatingDiode HeatingDiode1(       useHeatPort=true) ...;
which is definitely not legal.
I founrd some more broken models:

Modelica.Electrical.Machines.Examples
Modelica.Magnetic.FundamentalWave.Examples.BasicMachines

Do you recommend to revert a0d8187286dfdb6b2a0379e11b3e78e8e48b92db because of the trouble with useHeatPort?
Furthermore, there are some ConditionalHeatPort that take a parametric T_Ref and other that take a literal temperature of 293.15K.

OK, reverted by 501a04def2154c5c4a981596fa2d86f9ce6cc19a.

OK, I think this is good decision for now. Thanks.

New commit 970c5b556c770279698536217211c3f5a5ac4a94 kept the useHeatPort modifications untouched.

Having a look into the model Modelica.Electrical.Analog.Sources.StepVoltage signalSource.height IS redeclared with a final modifier. Are we talking about the same model here?
model StepVoltage "Step voltage source"
  parameter SI.Voltage V(start=1) "Height of step";
  extends Interfaces.VoltageSource(redeclare Modelica.Blocks.Sources.Step
      signalSource(final height=V));
...
end StepVoltage

Having a look into the model Modelica.Electrical.Analog.Sources.StepVoltage signalSource.height IS redeclared with a final modifier. Are we talking about the same model here?

Yes, after 970c5b556c770279698536217211c3f5a5ac4a94 it is.


annotate tab doesn't appear on 'About' page

It appears when you're on all other pages but not on About

I'm unable to duplicate this issue. Might have been caused by a cached version of the 'About' page from before the addition of the annotate tab.


Clean up version number and history following the v1.18.6 release

Leaves the branch ready for a potential subsequent v1.18.7 release.
Signed-off-by: Ryan Hamilton<EMAIL_ADDRESS>

/assign @mattklein123

This is the first of 4 similar PRs I will be sending you. Feel free to only review one of them, if this approach is not correct.

/retest


useBeforeUnload has no context for hook and can't be unregistered

I'd like to achieve the typical 'prompt user if data is unsaved before navigation' scenario using the technique recommended here:
https://github.com/rackt/history/blob/master/docs/ConfirmingNavigation.md
However there is no context available to the listenBeforeUnload hook function (useBeforeUnload.js simply does a beforeUnloadHooks[i].call() without context).
So that excludes putting if dirty logic in the hook function.
Another way I thought may be possible is to unregister the hook. However the registerBeforeUnloadHook / unregisterBeforeUnloadHook functions are deprecated.
This feels like a bug to me, or am I missing part of the technique?

If you're using a ES5 class, the hook is auto-bound. If you're using an ES6 class, you have to bind it yourself, which you'd do for e.g. any other callback anyway.

@taion Of course. The hook successfully fires. But once it is registered it cannot be unregistered nor can the hook determine itself 'if the data is dirty then prompt before navigation'.
For example these don't work:
No 'this' and no way to pass in
unloadHistory.listenBeforeUnload(function () {
   if (this.state.unsavedChanges === true) {
      return 'Are you sure you want to leave this page?'
   }
});

No way to unregister
if (this.state.unsavedChanges === true) {
   unloadHistory.listenBeforeUnload(function () {
      return 'Are you sure you want to leave this page?'
   });
} else {
   ??? unregister or last-one-wins hook ???
}

What? No - you just use hook.bind(this) or your favorite alternative thereof. How is this different from dealing with any other callback in JS?

No 'this' and no way to pass in

unloadHistory.listenBeforeUnload(() =>  {
   if (this.state.unsavedChanges === true) {
      return 'Are you sure you want to leave this page?'
   }
});

// or
var _this = this;
unloadHistory.listenBeforeUnload(function()  {
   if (_this.state.unsavedChanges === true) {
      return 'Are you sure you want to leave this page?'
   }
});

No way to unregister

Seems like it's not documented, but we've been following the convention of returning an unsubscribe function from listen*** methods, i.e.
if (this.state.unsavedChanges === true) {
   unlisten = unloadHistory.listenBeforeUnload(function () {
      return 'Are you sure you want to leave this page?'
   });
} else {
   unlisten()
}

Thanks @taurose, got it


ssh password for VM

Describe the bug
A clear and concise description of what the bug is.
What is the password to enter in ssh in prebuild vm kitt4sme.collab-cloud.eu?
in:
https://github.com/c0c0n3/kitt4sme.live/blob/main/docs/bootstrap.md
after build the virtual machine, say to enter in ssh with follow command:
ssh<EMAIL_ADDRESS>but after a password is required
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

create vm kitt4sme.collab-cloud.eu
ssh<EMAIL_ADDRESS>Password?

Expected behavior
A clear and concise description of what you expected to happen.
default password in documentation
Additional context
Add any other context about the problem here.

Hi @INVENTIOai :-)
The SSH password mentioned in the bootstrap procedure is that Kitt4sme developers use to connect to the cluster where we run our own cloud instance. You, as an open call dev (I'm guessing you are), have to provision your own hardware/OS where to install the Kitt4sme cluster. So you'll have your own SSH credentials---if you use SSH to connect to your cluster.
Sadly, the bootstrap documentation is utterly confusing at the moment since it tries to cater for both Kitt4sme devs and open calls. We should really have separate documents to cater for each target audience. We'll try improving the docs, thank you again for reporting this, much appreciated.
@karikolehmainen, @kostasgrevenitis if we rewrite the docs, then we should consider this issue as well which is similar in spirit

https://github.com/c0c0n3/kitt4sme.live/issues/177

If the procedure of setup with virtual machine is no more valid ( #202), I suppose this shall be not a issue anymore.


NotImplementedError: Unknown launcher none

System Info
Using slurm so not all of this will be accurate (i.e. we are using GPU)
- `Accelerate` version: 0.13.1
- Platform: Linux-5.10.135-122.509.amzn2.x86_64-x86_64-with-glibc2.2.5
- Python version: 3.8.5
- Numpy version: 1.23.4
- PyTorch version (GPU?): 1.12.1+cu113 (False)
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: NO
        - mixed_precision: no
        - use_cpu: False
        - num_processes: 1
        - machine_rank: 0
        - num_machines: 1
        - gpu_ids: all
        - main_process_ip: None
        - main_process_port: None
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - deepspeed_config: {}
        - fsdp_config: {}
        - downcast_bf16: no

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
Launching a job using this command fails
accelerate launch --use_deepspeed --num_processes=$(( 8 * $COUNT_NODE )) --num_machines=$COUNT_NODE --machine_rank $THEID --main_process_ip $MASTER_ADDR --main_process_port $MASTER_PORT --zero_stage=2 --gradient_clipping=0.5 --gradient_accumulation_steps=1 --deepspeed_hostfile hostfile train.py.
with the following error
NotImplementedError: Unknown launcher none

The deepspeed launcher is called with
'['deepspeed', '--no_local_rank', '--hostfile',  'hostfile', '--launcher', 'None', '--num_gpus', '8', 'train.py']
It seems we could check in the deepspeed_launcher if launcher is None and set to a default value if we don't want to raise an error here? Happy to open a PR for this if you think it would be beneficial + could suggest on what a good default launcher would be 😄
Expected behavior
The launcher should either fail and say you need to provide a launcher type or just choose a default.

cc @pacman100

Hello @zanussbaum, Thank you for notifying this issue. As you suggested, a good default launcher is required and it can be "pdsh" launcher which is inline with the DeepSpeed default. Do you want to open a PR with this fix?

Yes added quick PR here! https://github.com/huggingface/accelerate/pull/800
@pacman100


DocumentHandler.saveAndPreviewBase64File does not work with Kitkat 4.4.2

I want to open PDF document in Android Device.
I am using polarcape cordova pugin. My App am receiving Base64 string from the Server API, and I want to open the PDF intent using saveAndPreviewBase64File method of the plugin to achieve this.
I have set the target as Android-23, as suggested earlier, by the plugin development team.
It works for Android, 5.0 onwards.
But it is not working for device having Kitkat (Android 4.4.2)
Can someone help me in working for 4.4.2 Kitkat?

same problem here


deepin.dde-daemon: init at 5.14.122

Description of changes
https://github.com/linuxdeepin/dde-nixos/issues/9
( need help to improve this

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1870

@ofborg build deepin.dde-daemon

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1916


Istio from A to Y

https://staging.a-cup-of.coffee/blog/istio/?
Istio is an open-source service mesh that allows you to connect, secure, control, and observe the services of an application. We will see how to install Istio, and how to use it to secure and monitor our services.

particularly impressed by how you summarized the vast amount of information about Istio on a single page!

Excellent summary of Istio and thank you for the performance comparison.  Glad you like Kiali!  Jay (Kiali dev).


Enhancement: Fixing placeholder and button

Description
The placeholder does not describe the requirement and button dont have proper hover
Screenshots

Additional Information
Would like to make changes to just make it better. @phyleria
Ready to Work?

[X] I want to work on this enhancement

@phyleria

@phyleria may I start work on this

Sure, go ahead ✅


CP-14112: Schema error in GraphMLExtensions.DeserializeAndValidateFromGraphML

From unknown CodePlex user on Thursday, 10 September 2009 20:36:04
If I attempt to use the DeserializeAndValidateFromGraphML(), the following error is presented in the form of an XmlSchemaException:

'SchemaLocation' must successfully resolve if  contains any child other than .

I believe the problem occurs because GraphMLExtensions.AddGraphMLSchema only adds "QuickGraph.Serialization.graphml.xsd" to the reader's schema set, and not any of the other schemas that the file references.
GraphMLDeserialization.zip

Form unknown CodePlex user on Thursday, 10 September 2009 22:33:16
It turns out that this fails when the network is disabled on the executing machine.  If the network is enabled, the referenced schemas are downloaded from the URI given in the schemaLocation attribute.


Replace dependency to resilience4j-all by actually used modules (ratelimiter and retry)

Hello, first of all thank you for providing XChange!
We are looking to migrate our project from the javax to the jarkarta namespace and XChange currently brings a transient dependency to javax's cache API because XChange depends on resilience4j cache.
This PR replaces the resisilience4j dependency to the module that actually seem to be used.

core is the base for every module so I do not see what you gained here
plus we want resilience4j  to be used everywhere
we should check is a newer version of resilience4j  fixed those dependecies

Thank you for looking into it
With the proposed change the dependencies look like this:

And without the change they are:

So in particular the cache-api transient dependency is removed by that change. That one is a bit problematic because projects moving from the javax namespace to the jakarta namespace will find a conflict here.
Since resilience4j-cache (and other resilience4j modules) are not used, we can trim the dependency tree.
As you said there's also the pending upgrade to resilience4j 2.x but it seems like more work is required: https://github.com/knowm/XChange/pull/4631
So I felt like it should be an other Pull Request


Remove QA Test Extension Exemption Data

As an ECMPS user, I want the ability to remove QA Test Extension Exemption data so that I can update data as needed
Acceptance Criteria:
Given I am in the QA Test Extension Exemption data section
When I click on the 'Remove' option
Then I see that the relevant QA Test Extension Exemption data record is deleted
Given I chose to remove QA Test Extension Exemption data
When I click on the 'Remove' option
Then I see a message 'Are you sure you want to remove the selected data?'
And when I click Yes
Then the data is removed
And the update shall be reflected in the QA Test Extension Exemption Data section
When I select Cancel
Then I am returned to the landing screen for QA Test Extension Exemption Data
Testing
Test Case: TC1202
Tester: @JanellC

TC1202
System removes a TEE record


Hermitize the JDK and gradle

Looks like using jdk17 has all the add-opens warnings. We should stick to the existing JDK for now, which according to https://github.com/actions/setup-java/tree/releases/v1 (the github action we're using) pulls from the azul JDK distributions. I've opened a PR to add that JDK 14 distribution to hermit: https://github.com/cashapp/hermit-packages/pull/278


failed calling webhook "sidecar-injector.istio.io" which causes pods failed to start

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
I'm running istio on EKS cluster which we don't have the management access for master nodes, everything is working fine before. And now all the pods which required instio injection failed to start because they can't talk to istiod, the errors like:
Events:
  Type     Reason        Age                 From                   Message
  ----     ------        ----                ----                   -------
  Warning  FailedCreate  18m (x10 over 10h)  replicaset-controller  Error creating: Internal error occurred: failed calling webhook "sidecar-injector.istio.io": Post https://istiod.istio-system.svc:443/inject?timeout=30s: dial tcp <IP_ADDRESS>:15017: i/o timeout
  Warning  FailedCreate  81s (x37 over 12h)  replicaset-controller  Error creating: Internal error occurred: failed calling webhook "sidecar-injector.istio.io": Post https://istiod.istio-system.svc:443/inject?timeout=30s: context deadline exceeded

I also try to telnet and curl the istiod endpoints and API from the worker node and within the pod , eveything is working fine.
(base) root@ubuntu:~# kubectl get --raw /api/v1/namespaces/istio-system/services/https:istiod:https-webhook/proxy/inject -v4
I0115 18:20:16.133854   43395 helpers.go:216] server response object: [{
  "metadata": {},
  "status": "Failure",
  "message": "the server rejected our request for an unknown reason",
  "reason": "BadRequest",
  "details": {
    "causes": [
      {
        "reason": "UnexpectedServerResponse",
        "message": "no body found"
      }
    ]
  },
  "code": 400
}]

Also confirm istiod endpoints exist
(base) root@ubuntu:/home/sentry-github# kubectl get ep -n istio-system
NAME                            ENDPOINTS                                                                 AGE
grafana                         <none>                                                                    30d
istio-egressgateway             <IP_ADDRESS>:8443,<IP_ADDRESS>:15443,<IP_ADDRESS>:8080                 12h
istio-ingressgateway            <IP_ADDRESS>:8443,<IP_ADDRESS>:15021,<IP_ADDRESS>:15443 + 2 more...    12h
istio-internal-ingressgateway   <IP_ADDRESS>:8443,<IP_ADDRESS>:15021,<IP_ADDRESS>:15443 + 2 more...    12h
istio-spike-ingressgateway      <IP_ADDRESS>:8443,<IP_ADDRESS>:15021,<IP_ADDRESS>:15443 + 2 more...    12h
istiod                          <IP_ADDRESS>:15053,<IP_ADDRESS>:15010,<IP_ADDRESS>:15012 + 2 more...   12h

Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.7.4
control plane version: 1.7.4
data plane version: 1.7.4 (4 proxies)
Client Version: v1.19.3
Server Version: v1.18.9-eks-d1db3c
How was Istio installed?
kubectl edit mutatingwebhookconfiguration istio-sidecar-injector
# Please edit the object below. Lines beginning with a '#' will be ignored,
# and an empty file will abort the edit. If an error occurs while saving this file will be
# reopened with the relevant failures.
#
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"admissionregistration.k8s.io/v1beta1","kind":"MutatingWebhookConfiguration","metadata":{"annotations":{},"labels":{"app":"sidecar-injector","istio.io/rev":"default","release":"istio"},"name":"istio-sidecar-injector"},"webhooks":[{"admissionReviewVersions":["v1beta1","v1"],"clientConfig":{"caBundle":"","service":{"name":"istiod","namespace":"istio-system","path":"/inject"}},"failurePolicy":"Fail","name":"sidecar-injector.istio.io","namespaceSelector":{"matchLabels":{"istio-injection":"enabled"}},"rules":[{"apiGroups":[""],"apiVersions":["v1"],"operations":["CREATE"],"resources":["pods"]}],"sideEffects":"None"}]}
  creationTimestamp: "2021-01-15T14:08:00Z"
  generation: 4
  labels:
    app: sidecar-injector
    istio.io/rev: default
    release: istio
  name: istio-sidecar-injector
  resourceVersion: "25841873"
  selfLink: /apis/admissionregistration.k8s.io/v1/mutatingwebhookconfigurations/istio-sidecar-injector
  uid: c9660e41-bcdf-4341-b3a8-57e0cad8e6d1
webhooks:
- admissionReviewVersions:
  - v1beta1
  - v1
  clientConfig:
    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUMzVENDQWNXZ0F3SUJBZ0lRYjJGWVpRQzM5RGRndFhJSUpuNUdNakFOQmdrcWhraUc5dzBCQVFzRkFEQVkKTVJZd0ZBWURWUVFLRXcxamJIVnpkR1Z5TG14dlkyRnNNQjRYRFRJd01UQXlOekE0TXpFek5sb1hEVE13TVRBeQpOVEE0TXpFek5sb3dHREVXTUJRR0ExVUVDaE1OWTJ4MWMzUmxjaTVzYjJOaGJEQ0NBU0l3RFFZSktvWklodmNOCkFRRUJCUUFEZ2dFUEFEQ0NBUW9DZ2dFQkFORHFUTkJENDJvV1R3MWs3bk9qMkd6aXorVkdBZFNzTkRTZ1V1aVkKRHV5VFQwbWpmREFUeDJpOEp5UzJxcHNsR28xTUhGdkwyM1FKTWZoaTRHc1VUbkh5T0t5TFp0WGNLSFI5SWU5ZwpvQWd5TzRZakNkdGdkVmllTjhPU0UzdjN4S0NhSjBGMnMzc2FPODZ0Ym5XU1NaeWNCd3pkblJ4S2tZakJwTXdMCnNiNU1rc0k1cjMzVFZiV1piQWVKcWp0OFNSUDFXayt3d2UxUGMyU21jbnZXbDU4czRoWTN5dWRDL1krby96VzMKV1RHNjdaNCtWMDR5OE0vRDNLTFMzRGN1MldNUWJKNFNjWlk2NXEzckhaVDQxY2RPQWRVN3VaTnhDQkMrRVlRVgpWem1uUzZlOXMrM1czNEZKcjlnS2MxdUV4ZW0zSnJGYW43NVE4dFdkNmtTYkJUOENBd0VBQWFNak1DRXdEZ1lEClZSMFBBUUgvQkFRREFnSUVNQThHQTFVZEV3RUIvd1FGTUFNQkFmOHdEUVlKS29aSWh2Y05BUUVMQlFBRGdnRUIKQUd3WWxWb2lvdXBIb2QrL2VJNk5pT1U4Rkl5YU82NWNLV0hqQlIvdEV0c28vbFRBT0JLV09jSWJDallJY0R4YQpSVDYvcWxLK0krMzVJcXZQVDJVSVF4TWNnbk10VmhWSGRvU3pScEF4Z0xERGtiZS9kbnFrbytaWFJaSHJqb1JzClBzZXB1THprR0RjZjBYeXE2WXVEYXNMTjJlcisyakJGNU9CUkptRnFnc1BEV0V0MmI2Zi9jcFYzYi9DTklJMVAKZktLZ08wdm1meVhzS1pNK0RiQ0RieTVpREpQZEpwNFRDbHhlVmxsdUJpMVZnejlaZ2tTazRGNFpvK2xIdVR6MAp1VkRVS1UyYmg1djVnN0NqMFRoYWwxZlNmTkFCUGg5U3hZRFZnTzQyQzNUMkdHTGVRWTVhSDB3WUUyQTM0T0l1ClR4djdPSEJhUEM3a2pNempDMnlUdHY4PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
    service:
      name: istiod
      namespace: istio-system
      path: /inject
      port: 443
  failurePolicy: Fail
  matchPolicy: Exact
  name: sidecar-injector.istio.io
  namespaceSelector:
    matchLabels:
      istio-injection: enabled
  objectSelector: {}
  reinvocationPolicy: Never
  rules:
  - apiGroups:
    - ""
    apiVersions:
    - v1
    operations:
    - CREATE

Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

This appears to be an issue that is possibly specific to EKS.
It should be caused by kubernetes issue about dead tcp connection https://github.com/kubernetes/kubernetes/issues/80313 and https://github.com/istio/istio/issues/13840#issuecomment-542968020
There also some discussions at https://github.com/istio/istio/issues/13840
Try the workaround:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
spec:
  components:
    pilot:
        k8s:
          env:
            - name: GODEBUG
              value: http2server=0

This appears to be an issue that is possibly specific to EKS.
It should be caused by kubernetes issue about dead tcp connection https://github.com/kubernetes/kubernetes/issues/80313 and https://github.com/istio/istio/issues/13840#issuecomment-542968020
There also some discussions at https://github.com/istio/istio/issues/13840
Try the workaround:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
spec:
  components:
    pilot:
        k8s:
          env:
            - name: GODEBUG
              value: http2server=0

I believe this is fixed by ^. Thanks.


实现一个Vue插件 | steve_911

https://blog.steve911.fun/blog/vuePlugin
Kick off your next, great Gatsby project with this default starter. This barebones starter ships with the main Gatsby configuration files you might need.

测试~~~


TargetFolder does not allow for subfolder creation

Hello, when running the pipeline through Azure DevOps, I am getting an error anything I try to supply a subfolder to the TargetFolder variable
Works:

PLUSGPO

Does not work:

Maximo/PLUSGPO
'Maximo/PLUSGPO'
"Maximo/PLUSGPO"
Maximo`/PLUSGPO
#/Maximo/PLUSGPO
Maximo%2fPLUSGPO
//Maximo//PLUSGPO

No matter what method I try to use to escape the forward slashes, I get the same error message in all cases:
##[error]Error creating folder: MAXIMO/PLUSGWO. Msg: 'The name of the item 'Name contains invalid character '/'' is not valid. The name must be less than 260 characters long. The name must not start with a slash character or contain a reserved character. Other restrictions apply. For more information on valid item names, see https://go.microsoft.com/fwlink/?LinkId=398858. ---> Microsoft.ReportingServices.Diagnostics.Utilities.InvalidItemNameException: The name of the item 'Name contains invalid character '/'' is not valid. The name must be less than 260 characters long. The name must not start with a slash character or contain a reserved character. Other restrictions apply. For more information on valid item names, see https://go.microsoft.com/fwlink/?LinkId=398858.'
The link referenced above by MS is not valid, so I am currently stuck on getting the reports to load into the correct TargetFolder. Is there a trick I am missing to make a subfolder, or is that unsupported?

@siennaphoenix , you can try below configuration,
Reports Folder Path: "Source Folder"
Source Folder can consists sub-folder with reports in it  ex: PLUSGPO/*.(rdl or .rds)
Target Folder: "Maximo"


Timezone is not correct

I'm trying to get the offset from the UTC time at Israel timezone:
TZInfo::Timezone.get('Israel').current_period.utc_offset / (60*60)
The result is 2 hours when 3 hours is expected (http://www.timeanddate.com/time/zone/israel/jerusalem)

utc_offset gives the base offset of the time zone (not taking daylight savings time into account). For the total offset including daylight savings time, use utc_total_offset instead:
TZInfo::Timezone.get('Israel').current_period.utc_total_offset / (60*60)


Added Apache Guacamole (1013 bytes)

Hi, I've added the logo for apache guacamole (https://guacamole.apache.org/), which comes in at 1013 bytes
I currently don't have access to android studio so am unable to make the android versions

Hiya, sorry for the delay. Looks really good - but can you format it like the template in https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md#new-file ?


SASS-2753: Update income tax calculation backend

Description
This PR updates the income-tax-calculation backend so that it can cater for multiple tax years the way V&C does.
SASS-2753
Checklist PR Reviewer
Before Reviewing

[ ]  Have you pulled the branch down?
[ ]  Have you assigned yourself to the PR?
[ ]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of main?

Whilst Reviewing

[ ]  Have you run the tests?
[ ]  Have you run the journey tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current main that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[X]  Have you rebased against the current version of main?
[X]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[ ]  Have you checked the PR Builder passes?

test this please

test this please


Host parser Docker container

The researcher has a Dockercontainer ready for use. It needs to be integrated in the existing Docker Compose network.

I also use Docker Compose, so I may have useful config files for that as well.


conversion .weigth to .h5 make lose confidence

Hi!
I've my .weight file, create from darknet,
I need to convert my-tiny-yolo.weight in output.h5 file.
When I've convert, I obtain very different result.
For example, while in .weight file I've found one box with 100% of confidence, in keras, I've found two boxes, one with 0.93% of confidence and the other with 0.85%, and no one of the keras results have the same coords than the darknet result.
Any ideas?

How do you handle this (converting  .weights created from darknet)?  Because I tried this but on conversion gives an error;   "TypeError: buffer is too small for the requested array. File convert.py, line 143, line 262. buffer==weights_file.read(weights_siz3 * 4)"

Hi @Choneke ,
I've only user it:
python convert.py my-tiny.cfg my.weights model_data/my_output.h5
Are you sure that your config is ok?

Yes, it was ok. I use the same config file.

I run into the same problem. When I use Darknet to test the .weights file I have trained it gave a pretty high accuracy.

However, once I do the conversion to .h5 it just predicted everything as car and lorry.

Any solution to this?

@Chiengify, I have the same problem. do you get any solution to this?
Secondly, in your example, pictures are not the same neither their quality is the same. this might cause any problem

I used to convert.py to convert my .weight to .h5 file. But while predicting from the that keras model I get the different prediction at output (Some diference in the .weight prediction and .h5 file prediction). Please help


Video Cutscenes Crash Mod

Describe your bug here.
When adding a video cutscene to the start of a song, the video loads and plays just fine, but then 9/10 times the game will freeze at the end of the video. The video stays on screen, and the countdown/song don't start. Via trace logs, I know the video is supposedly removed and the countdown function continues, but the game is frozen. I could only fix the issue by replacing 1.0's video player with 0.7.3's video player.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes. New songs and sprites, a Japanese translation, and cutscenes.

I have this issue too, hopefully it gets patched soon before my mod deadline


Should the PythonAnalyzer in PTVS repository now be officially considered deprecated?

Subj.
Should I switch my project, that uses analyzer from PTVS's master to this instead?

Yes. PTVS will be switched to using this repo soon.


docs: from readthedocs.io to docs.reana.io

Move documentation out of readthedocs.io into docs.reana.io.
Keep only what is necessary on readthedocs.io especially if it is auto-generated, e.g. click docs.
Keep redirections from readthedocs.io to the new canonical docs.reana.io documentation site.
(Consider perhaps even redirecting whole domain e.g. reana-job-controller.rtfd.io into docs.reana.io and not keeping any on rtfd.io.)

@mvidalgarcia @diegodelemos Was everything moved already and the remaining issues for more verbose text ticketised? Can we close this epic issue already?

@mvidalgarcia @diegodelemos Was everything moved already and the remaining issues for more verbose text ticketised? Can we close this epic issue already?

https://github.com/reanahub/reana-cluster/pull/268 is slightly related but can be a separate matter. I think the rest is moved.

We are just missing a few repositories because of build problems:

RWC doesn't get triggered in RTFD since ~1 year (see here)
RJC fails in its latest build, error here
REANA fails in its latest build, error here

reana and r-w-controller are now OK; the only remaining repository is r-j-controller. Created an issue there.


Update openweathermap extension

Description

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

I couldn't get it to work with my api keys without signing up for a subscription. The first 1000 requests per day are free and i set a limit on 1000 requests. So technically i won't be needing to pay for anything.

This is what I get with the current store version, I also though that it would work with the default free API key

@larkov I need to add a payment to be able to subscribe, right?

@pernielsentikaer FYI https://openweathermap.org/api/one-call-3

What's the current status of this on, should we just merge it @tonka3000

@pernielsentikaer I think it can be merged . I did not check the readme (sub required).


Filter to boolean and non-required input

I noticed some strange behaviour today:
$input= new \Zend\InputFilter\Input();
$input->setValue("0");
$input->getFilterChain()->attachByName('boolean');
$input->setRequired(false);

$input->isValid(); //return false

The input gets filtered to a boolean value (false) before being validated. Because both allowEmpty and continueIfEmpty are false by default the NotEmpty validator is attached to the validator chain. The value "false" gets passed to the NotEmpty validator which, correctly, marks it as "invalid".
This results in strange "This field is required...." messages after validation on non-required inputs, while boolean false is a perfectly valid, non-empty value for e.g. a checkbox element.

Its better set allowEmpty and continueIfEmpty as true and attach the NonEmpty validator if you need.
$input = new Input();
$input->setAllowEmpty(true);         // Disable BC Break logic related to treat `null` values as valid empty value instead *not set*.
$input->setContinueIfEmpty(true);    // Disable BC Break logic related to treat `null` values as valid empty value instead *not set*.
$input->getValidatorChain()->attach(
    new Zend\Validator\NotEmpty(),
    true                             // break chain on failure

);

I agree it's best to disable the BC break logic on new code.
However, it's not desireable to modify dozens (or even hundreds in enterprise applications) of existing forms/filters after an update to the framework just because the input filter logic itself is broken.
Especially when this can be fixed in a future release.

It can't be fixed.


rework RenderCapture (Kodi)

Hi. Can you please adopt this addon to the newly implemented changes in kodi?
https://github.com/xbmc/xbmc/pull/8613
http://forum.kodi.tv/showthread.php?tid=238393&pid=2193250#pid2193250
TNX

i would also appreciate that ;)

+1 too. Thanks !

Was done


new: ship falcoctl bundled with Falco

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR bundles falcoctl inside Falco; moreover, it adds a new systemd service for falcoctl that will be used during DEB/RPM installation; moreover, the user will be asked (through a dialog) to enable the  automatic feed; by default (when dialog is missing or we are in a non interactive mode), falcoctl is not enabled.
Finally, if no driver is chosen at package installation time, falcoctl dialog won't be shown.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

new!: ship falcoctl inside Falco

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.34.0

CI timed out :/

@LucaGuerra @loresuso @alacuku
Let me know if this works for you, given you are the most active devs on falcoctl :D
Minor refinements might be needed on systemd service permissions; moreover, i am not getting who is supposed to ship:

etc/falcoctl/config.yaml
/etc/falcoctl/follow.yaml

Side note: if we want falcoctl.service to start after (and only IF) falco service, we would need to create a falco.target so that falcoctl.service can have a After=falco.target line, and every falco-*.service will be PartOf falco target.
Do you think this is important?

Side note: if we want falcoctl.service to start after falco service, we would need to create a falco.target so that falcoctl.service can have a After=falco.target line, and every falco-*.service will be PartOf falco target.
Do you think this is important? @leogr @loresuso

@FedeDP
Yes, I think so. Although falcoctl should correctly handle the case falco is not yet ready, I believe we should also enforce that via systemd for consistency.

Ok, i will add support for it :)

Support added in latest commit; basically:

all the falco-X units are PartOf falco.target
falco.target declares how units are installed
falcoctl.service runs after and binds to falco.target; this means that it is run after the falco target and if the falco target is stopped it gets stopped
preuninstall deb/rpm scripts will only the falco.target, that will then stop falcoctl and falco-X services

/hold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Correct additional style issues and remove warnings

This change is a follow-up to post-merge comments in #706 made by @ajkannan and @aozarov. The following changes have been made:

Don't use @Nullable on equals() methods
Don't throws Exception in test methods unless needed
Use incomplete sentences in JavaDoc summary fragment
Capitalize Cloud Storage
Get rid of some one-line JavaDocs
Use @code formatting when appropriate
Remove Paths.get() usages which is deprecated in Java 8
Remove @SuppressWarnings("null") which no one uses

CC: @jean-philippe-martin

Looks good to me, but let's wait to hear from the others.

Question about your bullet point "Remove Paths.get() usages which is deprecated in Java 8".  I couldn't find online a reference that it's being deprecated; did I misunderstand that bullet?  I see that you changed the Paths.get that uses the string as an argument.  If the string argument is deprecated, then I see one more example (line 633 of CloudStorageFileSystemProviderTest) that uses a string.  All other changes look good to me.

Hmm it's possible that the deprecation was added to the JavaDoc only internally at Google. But it makes sense. It seems more readable for us to be doing it the way I refactored it.


FactGenerator, clang-tidy: Google naming style

Rats: clang-tidy auto-fixes resulted in code that doesn't build. Will enable the rules individually and see which ones work.


Hotfix | Make Browse Filter Point to Coveo Prod

Please always provide the Jira Issue your PR is for, as well as test URLs where your change can be observed (before and after):
Jira ID: https://jira.corp.adobe.com/browse/EXLM-1473
Test URLs:

Before: https://main--exlm--adobe-experience-league.hlx.live/en/browse
After: https://coveo-configs--exlm--adobe-experience-league.hlx.live/en/browse

@ahmed-musallam We noticed today that Browse filter using Coveo headless is pointing to Coveo Stage. I see that this unintentional change happened accidently few weeks back. With this hotfix, we got it right. We also made it configurable so that dev & stage EDS points to Coveo stage.
Could you pls review and merge.


[Fix] rpi_boot: call os.sync on all important files replacement

Description

There is report that rpi_boot doesn't replace config.txt properly in the 1st reboot after firmware update, causing 2nd reboot still boots back to old slot. I read through the source code and found that, in common.replace_atomic, os.sync is called only after shutil.copy, os.replace is not covered by os.sync.
This PR fix the common.replace_atomic method, while insert more os.sync on important file preparing like linux images moving and after firmware update to ensure the changes are write to the disk.
Check list

[x] test file that covers the bug case(s) is implemented.
[x] local test is passed.

Bug fix

common.replace_atomic: now os.sync is called AFTER os.replace, ensure that replace operation is also written to the disk.

Other changes

rpi_boot: add more loggings when important files are prepared.

Related links & ticket

RT4-5266

Still need to further confirm, not going to merge it yet.


Raise end-index by 1 when setting parts of Range

This commit fixes a bug in Range, leading to the last line of a Range
not being able to be replaced via __setitem__ as the final
line setting its contents in the buffer the Range is based on assumes the
end-index to be inclusive, which it isn't in Python-slicing-notation.
@justinmk

I checked the failed checks of CI, it's flake complaints unrelated to this PR, therefore I'd say this should be ready for merge nevertheless.

could a test be added to test/test_buffer.py ?

Certainly so. Done.

PR is updated, __setitem__ should now work as intended.
One thing that's still bugging me: I cannot reproduce a similar behavior for __getitem__, but as __getitem__ and __setitem__ are implementet analogously, I would suspect a similar issue in there.
I cannot reproduce that, though, everything looks fine for __getitem__, according to my tests.

@bfredl
ok, cannot reproduce any problems with __getitem__, just seems to be with __setitem__.
So if the test is sufficient for you, the PR is final and ready for merge.


[7 tests] Automate Basic tests

Detail steps are mentioned at https://github.com/vmware/docker-volume-vsphere/issues/957#issue-209840924 & https://github.com/vmware/docker-volume-vsphere/issues/957#issuecomment-282431323

As discussed offline with @shuklanirdesh82, we agree that the test cases described in #957 are quite distinct, so we should move some test scenarios to other test groups. I will file separate issues to track those scenarios. Currently the basic_test group will only include 3 tests: TestVolumeLifecycle, TestBasicVolumeIsolation, and TestVmGroupVolumeIsolation.

Thanks @shaominchen for breaking this down and creating separate issues. for the 0.16 there is only one testcase being tracked for this issue.
Can you please refresh the estimate for TestVmGroupVolumeIsolation ?


fix a bug of TsFileResource updateTime

Bug Description:
When recovering a TsFile's device -> start time and device -> end time map and the TsFile's resource file happens not to exist, the TsFile itself will be read to update the start and end time map instead. It is implemented by TsFileRecoverPerformer.recover as follows:
for (TsDeviceMetadataIndex index : deviceMetadataIndexList) {
  TsDeviceMetadata deviceMetadata = reader.readTsDeviceMetaData(index);
  List<ChunkGroupMetaData> chunkGroupMetaDataList = deviceMetadata.getChunkGroupMetaDataList();
  for (ChunkGroupMetaData chunkGroupMetaData : chunkGroupMetaDataList) {
    for (ChunkMetaData chunkMetaData : chunkGroupMetaData.getChunkMetaDataList()) {
      tsFileResource.updateTime(chunkGroupMetaData.getDeviceID(), chunkMetaData.getStartTime());
      tsFileResource.updateTime(chunkGroupMetaData.getDeviceID(), chunkMetaData.getEndTime());
    }
  }
}

The updateTime function uses the first-coming value as the startTime:
  public void updateTime(String deviceId, long time) {
    startTimeMap.putIfAbsent(deviceId, time);
    Long endTime = endTimeMap.get(deviceId);
    if (endTime == null || endTime < time) {
      endTimeMap.put(deviceId, time);
    }
  }

So when root.vehicle.d0 has a chunkgroup of chunkMetadata listed as:
s3: startTime=3000, endTime=10000;
s1: startTime=1000, endTime=10000;
s2: startTime=2000, endTime=10000;
By the current code, the updated start time will be the first coming 3000, which is not correct.

By the way, I also change updateTime in LogReplayer.replayLogs to updateStartTime and updateEndTime. If there is something I haven't noticed, please tell me.

please add ut to cover this case

please add ut to cover this case

added :relaxed:

Hi, is there an jira issue attached this PR?
We need to manage the solved version on that.

Hi, is there an jira issue attached this PR?
We need to manage the solved version on that.

Added. See IOTDB-172.


Apply configlet fmt

I need to figure out why this fails CI.

Due to your desire for varargs on testing and @glennj's depth testing gone awry

I need to figure out why this fails CI.

The same code passed CI in the PR: https://github.com/exercism/8th/pull/137/checks
But failed when it was merged into main: https://github.com/exercism/8th/commit/068d3be8913863fca1645eac614d7dc4e4015381
It's the same workflow for both paths: https://github.com/exercism/8th/blob/main/.github/workflows/test.yml
I can't figure out where that "false" in the stack is coming from.

I can't even test with docker locally:
$ bin/test
Checking acronym exercise...
Unable to find image 'exercism/8th-test-runner:latest' locally
docker: Error response from daemon: pull access denied for exercism/8th-test-runner, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

I can't even test with docker locally:

That's because the test runner is a private repo as it contains the 8th.zip file which we don't to other people to distribute. If @axtens is happy with it, I could give you access to that repo.

Will that compromise the developer's security? Do I trust@glennj that much?

That's what you need to decide


Fix code style issues.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chinsyo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@Kulsk @RuiqiZhou Please review my submission.

LGTM
Please squash your commits and then I can merge this PR. @chinsyo

@RuiqiZhou Done


[DEP][Spec] Add more examples to introduce the APIs usage

This PR will add three use cases:

Load a depth photo from file system
Load a depth photo from network
Refocus a depth photo

@huningxin Please take a look.

@huningxin Have solved all the comments. Please take another look. Thanks.

LGTM. Merging.


.pac文件中如何设置用户名和密码

这是一封自动回复邮件。已经收到您的来信，我会尽快回复。如有急事，请致电本人，谢谢！Thank you for your email! Please do not reply to this message, as this is an automated response. We will respond as soon as we can!


Possible false positive for IfcSectionedSolidHorizontal

@aothms @civilx64
The informal propositions for IfcSectionedSolidHorizontal says:

If the type of sections is not IfcParameterizedProfileDef (i.e. an arbitrary profile), then the number of points and edges should be the same for two consecutive profiles

The attached file has bridge beams with tapered end blocks where a different number of points are used to define an IfcPolyline for consecutive cross section profiles. This file passes the validation service without error.
Since the informal proposition says "should" instead of "shall", maybe this is ok. Just thought I'd bring it up.
26122.ifc.txt

Hi @RickBrice coincedently we were just discussing this exact rule among others. Simple fact is that most of the informal propositions in the schema are not implemented yet, including this one.

cc @evandroAlfieri


How to validate not nullable sap.ui.model.type.DateTime?

OpenUI5 version: 1.54.8
URL (minimal example if possible): http://plnkr.co/edit/D8EXpuOUmhu5JuI2k508?p=preview

Steps to reproduce the problem:

Input something in DateTimePicker, leave focus
Clear value in DateTimePicker, leave focus

What is the expected result?

When there is not datetime in DateTimePicker, value state is Error and value state text is meaningful.

Meanwhile, keep date check in DateTimePicker:

What happens instead?

set nullable: false did not work both in DateTimePicker & Input, this should work according to https://sapui5.hana.ondemand.com/#/api/sap.ui.model.odata.type ?

set minLength: 1 works in Input, but not in DateTimePicker(no Error State):

Input:

set minimum: 1 works, but with strange value state text:

I did not found minimum in doc, but found it in https://sapui5.hana.ondemand.com/resources/sap/ui/model/type/Date-dbg.js
It seems only constraints validation for minimum and maximum

I also tried this in change event:
onValidateDate: function(oEvent) {
  var oSource = oEvent.getSource();
  var sValue = oSource.getValue();

  // not sure this is the right way
  if (sap.ui.core.format.DateFormat.getDateTimeInstance().parse(sValue)) {
    oSource.setValueState("None");
    return;
  }
  oSource.setValueState("Error");
}

But
if sValue is "", parse() returns null,  value state is set to Error in onValidateDate, but it will immediately changed back(None state) by DateTime validation. Or I can remove DateTime type in xml ? But I'd like to use build in type validation.

Hello @TinaC ,
The DateTimePicker  control covers specific use cases and has custom logic behind. The maxLengthd doesn't have semantic usage because the validation of the control is made by date format not by the number of the characters in it. In DateTimePicker  there are properties as minDate and maxDate which are inherited from the sap.m.DatePicker.
The validation of the DateTimePicker  is handled by the change event  and you can get if the value is valid by the boolean parameter "valid". If you want to validate the DateTimePicker  please use this change event.
Regards, Diana

Thanks @Shtilianova,
Now I understand minLength & maxLength did not work for date. And minimum is use for setMinDate.
change event works for me:
http://plnkr.co/edit/9gxntn9AbstsbwXvQIJd?p=preview
handleDateChange: function(oEvent) {
  var oDP = oEvent.oSource;
  var sValue = oEvent.getParameter("value");
  var bValid = oEvent.getParameter("valid");

  if (bValid && sValue) {
    oDP.setValueState(sap.ui.core.ValueState.None);
  } else {
    oDP.setValueState(sap.ui.core.ValueState.Error);
  }
}

Still have one question, why nullable: false did not work as I expected?

And in Date Picker sample, change event seems not recommend in data binding? I use oData data binding in my DateTimePicker, which in my sample, using view model data binding to simulate.

But sap.ui.getCore().attachParseError did not work in my sample:  http://plnkr.co/edit/IBbgCGfcpW69sz4HHCtU?p=preview
attachParseError & attachValidationSuccess never fired.

Hello @TinaC ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards, Diana

Hi @TinaC,
the problem here is that our framework validation is done asynchronous, and the ValueState set by your onChange handler is overruled. This is just the way our framework does validation, and no bug in my opinion.
IMO the only correct way from framework perspective to achieve what you want is to use the "minimum" constraint, but I agree with you that the shown error message isn't meaningful. I will talk with the responsible colleagues about the error text.
The alternative solution would be disabling the framework validation and do the validation on your own, create own messages (sap.ui.core.message.Message), and add them to the MessageManager (sap.ui.core.message.MessageManager).

Hello @TinaC,
Regarding the nullable I guess you have mixed up two things:
nullable is not supported in the sap.ui.model.type.DateTime
https://sapui5.hana.ondemand.com/#/api/sap.ui.model.type.DateTime
but a concept of the OData types
https://sapui5.hana.ondemand.com/#/api/sap.ui.model.odata.type

Thanks, @clemai @tommyvinhlam
Yes. I mixed up the doc !
sap.ui.model.type.DateTime extends sap.ui.model.type.Date
constraints of type.DateTime are the same as type.Date: only have minimum and maximum
Without nullable, it seems the only solution is do validation & DateTime format on my own...


Fix for Rare BufferOverflow that could cause rcon to become unresponsive core/rcon.js

Bug fix to decoder for rare overflow caused by packet sequence illustrated below,
(reads from random point in the buff to get size of packet that can cause non returning loop)
looking for a packet of L10 and then looking for something on the end that matches 0100000 returns false when TCP has cut packet as shown; the next data will be "fragments". This is compounded because Squad on rare occasions sends 0100000 to denote chat msg breaks and it does not follow spec.

Rework of decoder to better suite OWI Squads rcon flavour. (oversize packets, 0x01, NO 0001000, instead 0100000)
(Note all decode checking I have written is overkill but I have developed it regardless, all bad packets came from the bug above TCP does not break like that at the application layer).
See my simpleRcon examples for underlying logic.
I have 'Wrapped' my rcon client methods in SquadJS-like methods (looking to confirm I've not missed anything)
.execute(){ .once() is achieved by using the packet id as the event id, a new counter this.msgId starts at 20 and is reset at 80, tuned for timeout errors on current map call timeout goes to aprox 10 seconds.
This is my first draft, well tested in sandbox, not yet executed with SquadJS.

This also takes care of the password logging issue by writing to .netconnection directly,
no Socket issues, we use node:net
Improved error logging, you should get less general complaints about strange error/no error logging.
incorrect password will result in connection attempt loop, .net socket is closed by the server without a reject packet... suggest adding timeout to flag => check password.

fixes issues 262, 260, 200

I have sandboxed this against a live server, over 1 million requests and responses with 0% failure.
While legacy version in the sandbox failed within the first 100,000 as the server filled and chat became busier.

this.autoReconnectDelay = options.autoReconnectDelay || 5000; seems incorrect? - followed the core/rcon.js file, however it seems to be passed,
autoReconnectInterval: this.options.rconAutoReconnectInterval from squad-server/index.js

We've been using this for days now and no issues encountered yet.
We'll be monitoring it and see if we can find anything.

Wanted to ask if this is working properly and is it stable, since there has been quite a long time now for it to be tested?
I'd like to use this in sqcp

Wanted to ask if this is working properly and is it stable, since there has been quite a long time now for it to be tested?
I'd like to use this in sqcp

Hi, we've been using this for weeks now and have already tested numerous versions. However, I'm not sure yet if this is the latest version that we've been using.

I hope to push the latest version within a few days, it has had the reject/resolves cleaned up and some other minor tweaks, however for most people outwardly it will work just the same.

Awesome, sounds good to me.
Thanks for the fast response.

Is this going to be merged? Looking to potentially use SquadJS but would like to see these issues closed out first for stability. Thanks!

Is this going to be merged? Looking to potentially use SquadJS but would like to see these issues closed out first for stability. Thanks!

I've used Squad JS well over a year when I had my server, it rarely crashed.
You can use pm2 to auto restart it when it crashes.

Is this going to be merged? Looking to potentially use SquadJS but would like to see these issues closed out first for stability. Thanks!

Why not use SquadJS and use this file instead?
I've been using this for weeks now and no issues so far.
When we were on FTP before, rcon silently dies almost 10+ times a day and I had to restart every hour.

Is this going to be merged? Looking to potentially use SquadJS but would like to see these issues closed out first for stability. Thanks!

I've used Squad JS well over a year when I had my server, it rarely crashed. You can use pm2 to auto restart it when it crashes.

The main issue is not crashing, but the rcon silently dies without crashing.

Is this going to be merged? Looking to potentially use SquadJS but would like to see these issues closed out first for stability. Thanks!

If you are able just swap the files, do that for now. Its a low effort fix :)
In terms of merging I think the authors/maintainers of SquadJS have packages that rely on older versions of Node and are looking at/testing before anything could happen re merge.
I was unaware of this when I wrote this rcon file and it should be used with Node 18+, that said everyone so far who is using it has had success.
It has a lot of good uptime collectively.

Can confirm it runs fine with Node 16.9.0
However I never checked or wrote it using that documentation from that version

@fantinodavide Are these still valid/good PRs?

Conflicts will need resolving now.

Not sure what happened there,
delete 99 to 169,
also I have some minor fixes:
change the oversize buffer value to suit squad rcon (4096 is too small)
if (length > 4154) Logger.verbose("RCON", 1, Error occurred. Oversize, "${length}" > 4154)
There is one minor bug fix to handle possible event listener leak, I can do another pr or you may just do the following;
add
this.removeAllListeners("server");
this.removeAllListeners("auth");
at
async connect() {
return new Promise((resolve, reject) => {
if (this.client && this.connected && !this.client.destroyed) return reject(new Error("Rcon.connect() Rcon already connected."));
this.removeAllListeners("server");
this.removeAllListeners("auth");
this.on("server", (pkt) => this.processChatPacket(pkt));
Or I can do another pr

I understand now, to resolve this conflict by re-adding lvl 4 pwd vBlog;
#sendAuth() {
Logger.verbose("RCON", 1, Sending Token to: ${this.host}:${this.port});
Logger.verbose('RCON', 4, Writing packet with type "${this.type.auth}" and body "${this.password}".);
this.client.write(this.#encode(this.type.auth,<PHONE_NUMBER>, this.password).toString("binary"), "binary");
}

Have made the changes, this is now inline with the version people have been using, + the lvl 4 pw logging etc

@Matttor still getting conflict warnings, you may need to resolve them through the PR/CLI process first. It is still preventing me to do anything currently. If you can't fix I'll take a look later but please don't make another PR. Want to keep everything tidy.

@Matttor just had an issue, the badPacket() method got called after updating the player list, probably too frequently, but setting the condition as follows fixed my issue:
if (bufSize > 6144 || bufSize < 10) return this.badPacket();
6144 is just a random number, we should work on finding the appropriate one, but gets the job done.

@Matttor some important notes here https://github.com/Team-Silver-Sphere/SquadJS/pull/318#issuecomment-1854740474

Sorry, I gave you a bit misleading info yesterday. 11kb package I was receiving was a TCP payload size, not an rcon's packet_size. Biggest packet_size I've seen so far was ~4200b. If you prefer to keep some sort of a safeguard then I'd go with 4096*2 as it would still save you from 99% of the junk yet let obscenely fat legit packages go through. That is strictly optional suggestion though.

Hello, your PR seems to have solved all the problems we've had with regards to RCON in our SquadJS.
However, there's a minor typo/bug on line 149, where if the module recieved a bad packet, it would try to print out the buffer. During the logging it's supposed to call "this.bufToHexString(this.stream)", while the bufToHexString method is named "#bufToHexString"
When this happend, it would cause a crash.

Good spot, thank you @mrkaland95


chore(deps): bump https://github.com/zeebe-io/zeebe-cluster-helm from 0.0.38 to 0.0.39

Update zeebe-io/zeebe-cluster-helm from 0.0.38 to 0.0.39
Command run was jx step create pr chart --name zeebe-cluster --version 0.0.39 --repo https://github.com/zeebe-io/zeebe-full-helm.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: salaboy
If they are not already assigned, you can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix broken images references

Thank you for contribution! The issue must have been resolved by some other change as all images are loaded now correctly.