How to use ErrorProne with Lombok: @Value annotations seem disabled?

Description of the problem / feature request:
I am trying to use ErrorProne and Lombok together.
Various open issues in this repos suggest that this is possible but perhaps difficult or unsupported?
I have found that using ErrorProne seems to entirely disable the "@Value" and "@Data" and similar Lombok annotations, causing compile errors in code that relies on the getters generated by these annoations.
How can I get these two libraries to work together?
Feature requests: what underlying problem are you trying to solve with this feature?
I am trying to use ErrorProne on a codebase that relies on Lombok code-generation annotations.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
I have prepared two simple examples based on the "examples/maven" example in this repos:
The relevant class looks like this:
import lombok.Value;

@Value
public class SomeDataClass {

    public String name;

    @Override
    public String toString() {
        return "SomeDataClass[" + this.getName() + "]";
    }
}

Maven and Lombok together: https://github.com/RichardBradley/error-prone/tree/d3ca8c6716a8cde2b2489f5beafa36837acc54e9/examples/maven-with-lombok

This fails to build with the following message:
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] C:\Work\error-prone\examples\maven-with-lombok\src\main\java\SomeDataClass.java:[11,38] error: cannot find symbol
  symbol: method getName()
[INFO] 1 error

The same code, but with ErrorProne disabled: https://github.com/RichardBradley/error-prone/tree/ccadedda3/examples/maven-with-lombok

This builds fine
What version of Error Prone are you using?
Latest master, 976ab7c62771 (2.3.3-SNAPSHOT)
Have you found anything relevant by searching the web?
Related issues:

#775 : someone using Lombok @Data with ErrorProne, closed as dup
#751 "Lombok & error-prone dont play together ?": closed as dup (of which?)
#690: Lombok breaks NestedInstanceOfConditions and InstanceOfAndCastMatchWrongType - closed as fixed?
#932: seems to be a similar or same question, but was closed without comment

Many thanks,
Rich

Lombok needs to be in the processor path. By default, the processor path is the same as the compilation classpath, so adding Lombok as a project dependency is enough. But as soon as your specify it explicitly (through <annotationProcessorPaths> in Maven), you need to add to it everything that needs to be there, and that includes Lombok.
Specifically, you need to add it as a project dependency so you can use the annotations, and in the <annotationProcessorPaths> so that it can process them (and do its dark magic generating code where it's not supposed to)

Thanks, that's very helpful. I have created PRs with suggested doc improvements to help users with similar issues in the future.
I am now getting "Compilation Failure" with no error info from Maven, but I will keep digging.
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ errorprone-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 3 source files to C:\Work\error-prone\examples\maven-with-lombok\target\classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.907 s
[INFO] Finished at: 2018-11-23T14:38:20Z
[INFO] Final Memory: 24M/981M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project errorprone-example: Compilation failure -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
{

Repro at:  https://github.com/RichardBradley/error-prone/tree/00df8f2a7/examples/maven-with-lombok
I am using javac 1.8.0_151 on Windows 10 x64

I have attempted to run javac using the args passed to it by Maven (determined using mvn -X compile) in the above repro case and I get this output:
A plugin threw an uncaught exception.
Consult the following stack trace for details.
java.lang.NoSuchMethodError: com.sun.tools.javac.util.JavacMessages.add(Lcom/sun/tools/javac/util/JavacMessages$ResourceBundleHelper;)V
        at com.google.errorprone.BaseErrorProneJavaCompiler.setupMessageBundle(BaseErrorProneJavaCompiler.java:202)
        at com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:40)
        at com.sun.tools.javac.main.Main.compile(Main.java:470)
        at com.sun.tools.javac.main.Main.compile(Main.java:381)
        at com.sun.tools.javac.main.Main.compile(Main.java:370)
        at com.sun.tools.javac.main.Main.compile(Main.java:361)
        at com.sun.tools.javac.Main.compile(Main.java:56)
        at com.sun.tools.javac.Main.main(Main.java:42)

Rather strangely, it seems that the "-J-Xbootclasspath/p:..." arg is not printed by maven -X compile. It is not clear to me whether Maven is not passing this arg or if it is passing it but hiding it from the debug output somehow.
If I retry and manually add that arg, then I get this error from javac:
An annotation processor threw an uncaught exception.
Consult the following stack trace for details.
java.lang.NoClassDefFoundError: com/sun/tools/javac/file/BaseFileObject
        at java.lang.ClassLoader.defineClass1(Native Method)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:642)
        at lombok.launch.ShadowClassLoader.loadClass(ShadowClassLoader.java:448)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at lombok.javac.apt.LombokFileObjects$Compiler$2.wrap(LombokFileObjects.java:60)
        at lombok.javac.apt.LombokFileObjects.createEmpty(LombokFileObjects.java:109)
        at lombok.javac.apt.InterceptingJavaFileManager.getJavaFileForOutput(InterceptingJavaFileManager.java:47)
        at com.sun.tools.javac.processing.JavacFiler.createSourceOrClassFile(JavacFiler.java:499)
        at com.sun.tools.javac.processing.JavacFiler.createSourceFile(JavacFiler.java:425)
        at lombok.javac.apt.LombokProcessor.forceNewRound(LombokProcessor.java:289)
        at lombok.javac.apt.LombokProcessor.process(LombokProcessor.java:278)
        at lombok.core.AnnotationProcessor$JavacDescriptor.process(AnnotationProcessor.java:114)
        at lombok.core.AnnotationProcessor.process(AnnotationProcessor.java:164)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.process(AnnotationProcessor.java:59)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:968)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:884)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2200(JavacProcessingEnvironment.java:108)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1206)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1315)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1246)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:922)
        at com.sun.tools.javac.main.Main.compile(Main.java:302)
        at com.sun.tools.javac.main.Main.compile(Main.java:162)
        at com.sun.tools.javac.Main.compile(Main.java:57)
        at com.sun.tools.javac.Main.main(Main.java:43)
Caused by: java.lang.ClassNotFoundException: com.sun.tools.javac.file.BaseFileObject
        at java.lang.ClassLoader.findClass(ClassLoader.java:530)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at lombok.launch.ShadowClassLoader.loadClass(ShadowClassLoader.java:418)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 26 more

It works if you update Lombok to 1.18.4.
[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ errorprone-example ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 3 source files to /tmp/error-prone/examples/maven-with-lombok/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /tmp/error-prone/examples/maven-with-lombok/src/main/java/Main.java:[20,4] error: [DeadException] Exception created but not thrown
    (see https://errorprone.info/bugpattern/DeadException)
  Did you mean 'throw new RuntimeException();'?
[ERROR] /tmp/error-prone/examples/maven-with-lombok/src/main/java/SomethingElse.java:[19,44] error: [GetClassOnClass] Calling getClass() on an object of type Class returns the Class object for java.lang.Class; you probably meant to operate on the object directly
    (see https://errorprone.info/bugpattern/GetClassOnClass)
  Did you mean 'System.out.println(String.class.toString());' or 'System.out.println(Class.class.toString());'?
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.734 s
[INFO] Finished at: 2018-11-23T15:58:38+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project errorprone-example: Compilation failure: Compilation failure:
[ERROR] /tmp/error-prone/examples/maven-with-lombok/src/main/java/Main.java:[20,4] error: [DeadException] Exception created but not thrown
[ERROR]     (see https://errorprone.info/bugpattern/DeadException)
[ERROR]   Did you mean 'throw new RuntimeException();'?
[ERROR] /tmp/error-prone/examples/maven-with-lombok/src/main/java/SomethingElse.java:[19,44] error: [GetClassOnClass] Calling getClass() on an object of type Class returns the Class object for java.lang.Class; you probably meant to operate on the object directly
[ERROR]     (see https://errorprone.info/bugpattern/GetClassOnClass)
[ERROR]   Did you mean 'System.out.println(String.class.toString());' or 'System.out.println(Class.class.toString());'?
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Yep, that works for me.
Thanks very much for your help!


chore: release 4.5.2

:robot: I have created a release *beep* *boop*
4.5.2 (2021-05-31)
Bug Fixes

yaml handler invalid inconsistency prompt (d7df2c0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mili-project-manager/mili/releases/tag/v4.5.2 :sunflower:


[WIP] Changing splitChunks.name default to false for production

Hi people!
Motivated by sokra's comment here: https://github.com/webpack/webpack/issues/8426#issuecomment-442375207. Closes #8426.
I also made a PR to the docs (https://github.com/webpack/webpack.js.org/pull/2672) for the current version - as the false option wasn't documented.
What kind of change does this PR introduce?
A new default value for production builds.
Did you add tests for your changes?
No directly - but there are tests that rely on this functionality (and those are updated). Happy to do more if needed.
Does this PR introduce a breaking change?
Yes, as the default value changes - the PR is made to next.
What needs to be documented once your changes are merged?

Slight update to https://webpack.js.org/plugins/split-chunks-plugin/#splitchunks-name
Update default config on https://webpack.js.org/concepts/mode/

Thanks for the review! Faceplam mistake :). I'm working on the tests - no review needed until they're passing.

We have gone a step further and removed the name: true feature all together. There is chunkIds: "named" as default in dev mode which is better.


Allow manually overriding the found item without validating location

I wanted a way to be able to manually set a reference that complied with the data type without adhering to the location attribute, essentially using Self, Child, etc as fallbacks or default values, but not enforcing those relationships when manually assigned. Setting the Overridable flag automatically sets the editable flag.
I've added an Overridable flag though I'm not in love with the name of the flag, and bypassed some of the validation logic when this flag is set.
Example usage would be something like:
[SerializeField, Child(Flag.ExcludeSelf | Flag.Overridable)] private MyClass myClass;

Thanks for this, I can definitely see that being useful. I agree that I'm not in love with the name, though I can't think of anything that's much better... What do you think of the following?
EditableAnywhere: Allows the user to override the automatic selection, without validating the location.
Could I also trouble you to update the README Flags section with the new flag?

Adjusted the flag name and added an entry under Flags describing the operation


DA Compression

DA-Compression

btw https://github.com/scroll-tech/zkevm-circuits/pull/1157 will be merged soon.   Should have an eye on conflicts.

We can add only several testdata (the new "hex" files) here.  And keep others in submodule or S3.

ci passed.  (the remaining problem is also on develop).


Remove Snake Case use

Hello there.
I've seen a bad pattern here, and it is that snake_case is being used in this library.
This is a total bad practice and breaks patterns that are a standard across JS/TS libraries.
It may be ok to use snake_case with other programming languages (ie: Python), but when working with TypeScript or JavaScript, we should stick to using camelCase, or PascalCase when naming components and objects.
Take a look at any other JS/TS/Svelte library and you'll quickly notice that snake_case is not used anywhere.

@Lucasmiguelmac thank for ur investigation, if u look to react version i clean the code and i will do the same with svelte/solid versions, it  s better to join to my discord if u have any questions + ideas ;) https://discord.gg/cAjxEsHe

Hi @kamalkech
Could you please send a discord invite? this one seems to be invalid.


database_timeout is applied at organization level

Each CARTO user has two timeout limits, one for logged in operations (with api key) and another for public usage (without api key). Right now, the former is applied to the database role, and the latter to the database itself.
In organization, this causes that each time the public limit is changed for a user, it is actually applied to all users in an organization. See https://github.com/CartoDB/cartodb/blob/master/app/models/user/db_service.rb#L640-L644
We should strive to make this consistent. Some options:

Move the public timeout to the organization model, to better reflect what is currently happening.
Apply the public limit to each public user role in the organization (user.database_public_role). For single users, keep applying it to the database (since publicuser is shared). This would make the limit per-user.

The real question to make here is if we want the users to be the same for all users in the organization or we want the possibility to make then different.

IMHO it makes sense to make them different. It's not unusual for an organization to have one "production" account and a few other for testing, particularly if they're developing apps with CARTO.

Closing in favor of https://app.clubhouse.io/cartoteam/story/83541/database-timeout-is-applied-at-organization-level


Play lightsaber sound

Added a function that plays any sound based on the given path.

to test this function just add to the main.js, then click on the first button.
import playSound from './playSound';
const btn = document.querySelector('.btn');
btn.addEventListener('click', () => {
playSound('../assets/sounds/lightsaberSound.mp3');
});


Smpp protocol version

naz - 0.7.3
SMPP protocol in client.py, line 83
interface_version: int = 0x34,
not
interface_version: int = 34.

naz version 0.7.3 , client.py, line 83 is; https://github.com/komuw/naz/blob/c9cc0a4a883d3777384cb8206c4120e3d2e93fe4/naz/client.py#L83
which is 34

34 is 0x22, not 0x34.

Hi @Slavix72
Where are you getting 0x34 from? It is not anywhere in the naz codebase
On Tue, 26 Nov 2019 at 14:54, Slavix72<EMAIL_ADDRESS>wrote:

34 is 0x22, not 0x34.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/komuw/naz/issues/184?email_source=notifications&email_token=ABHMWUJF2MJA3W2Y3PYUEG3QVUFANA5CNFSM4JRLAZXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFFX52I#issuecomment-558595817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHMWUOPZFRPGQDK5H4RVDTQVUFANANCNFSM4JRLAZXA
.

--
Thanks,
KomuW.
https://www.komu.engineer/about

0x34 is from smpp protocol specification..

@Slavix72
naz currently only support version 3.4 of the SMPP spec.
It is stated as much on the readme of this project; https://github.com/komuw/naz#naz

>>> 0x22 == 34
True
>>>

If you however want to try out version 5.2 of smpp spec with naz, you could do;
import naz

client = naz.Client(
    ...,
    interface_version=0x34
)

please do note, however, that naz is yet to be tested with version 5.2 of smpp so I'm not sure how it will behave. Maybe everything will be fine

@Slavix72 can we close this issue?

We can re-open later, if there is any action required from me.


Cryptic error message when physics output frequency is mis configured

I recently came across the error:
Traceback (most recent call last):
  File "scripts/test_config.py", line 11, in <module>
    config_fv3config = config.to_fv3config()
  File "/usr/local/lib/python3.8/dist-packages/runtime/segmented_run/prepare_config.py", line 178, in to_fv3config
    file_configs_to_namelist_settings(
  File "/usr/local/lib/python3.8/dist-packages/runtime/diagnostics/fortran.py", line 158, in file_configs_to_namelist_settings
    raise NotImplementedError(
NotImplementedError: Cannot output physics diagnostics at multiple frequencies.

which is not very helpful. It should say what settings I should change.

Or maybe this configuration should be changed so that there is only a single global configuration.
@spencerkclark How hard would it be to let the fortran use different output frequencies for the physics?

cc @oliverwm1

For some variables it is already enabled but we'd just need to modify their "module" so that this code in fv3net doesn't flag them as a problem (https://github.com/ai2cm/fv3gfs-fortran/issues/175).
For the more standard physics diagnostics like the radiative fluxes, precipitation, surface temperature, etc., it would be a bit of a project to make sure that you could obtain identical results.  Some are simple to convert, others require more care, e.g. the radiative flux diagnostics in particular (I looked into doing this a couple years ago).  If we wanted to do it a few key diagnostics at a time it could be manageable, however.

oh interesting. I encountered this error when trying to save the 3d physics tendency diagnostics at a different interval from the lhf, so the "retagging" mentioned in that issue is directly applicable.

Alternatively, @spencerkclark do you think there is another way we could specify which variables are subject to this constraint? Could potentially have a more specific database of variable names instead of relying on module names.
Either way, a more specific error message would be straightforward to implement.

Yeah, we could do something like that instead.  It would prevent the need to update any existing diag_tables, which might be nice.  The most expedient thing would probably be to create a list of exceptions to this rule -- currently I think the only ones are the per-physics component tendencies -- and allow those to pass through without any restrictions.


Show markdown in summary sections

Fix the layout in the summary sections to show markdown rendering again:
Goes from this:

To this:

These changes need to be made in the markdown generator, vs in the produced markdown, so I'm going to close this PR, and raise an issue instead


Add a global-only parameter to the runtime

This should make it easier to use ocicl in a global-only manner.
Please change the *global-only* to another name if that's more taste-appropriate.
PS: My current pet-peeve is that ocicl tries to create a systems.csv and the systems directory in every damn directory I start the lisp process in. This PR resolves this issue.

Please check


Configure all docker containers ports for all components of Deep architecture

https://discord.com/channels/739430470345031692/970660322853670953/1215993561858838678

https://github.com/deep-foundation/deeplinks/pull/328

https://github.com/deep-foundation/hasura/pull/18

https://github.com/deep-foundation/dev/issues/223 conected issue

for pass multiple ports i used envsubst from discussion this connected issue
https://github.com/deep-foundation/deeplinks/issues/249#issuecomment-1756146442


Improve disable caching reason on DefaultTask

Given that ad-hoc tasks have type DefaultTask, the previous message was somewhat misleading.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Remove Unneeded Modifier in Consumers Pipeline

Incorrectly added retryCountOnTaskFailure: 2 when it was not needed, it also caused a syntax error that's stopping pipeline from running.

Seems like im too late


Embedded services may have different schema/context

For example:
https://iiif.wellcomecollection.org/presentation/b18035723
The search service here:
{
  "service": [
    {
      "@id": "https://iiif.wellcomecollection.org/search/v1/b18035723",
      "@type": "SearchService1",
      "profile": "http://iiif.io/api/search/1/search",
      "label": "Search within this manifest",
      "service": {
        "@id": "https://iiif.wellcomecollection.org/search/autocomplete/v1/b18035723",
        "@type": "AutoCompleteService1",
        "profile": "http://iiif.io/api/search/1/autocomplete",
        "label": "Autocomplete words in this manifest"
      }
    }
  ]
}

Is a valid Search 1.0 service (2.0 introduced the requirement for a services array).
https://iiif.io/api/search/1.0/#service-description-1

Thanks Stephen. I see that the service property can also be an object rather than array of objects.


Toolbox dropdown does not close when clicked outside

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: MacOS
- Continue version: 0.9.244
- IDE version: VS Code 1.96.0
- Model: Claude 3.5 Sonnet
- config.json:

Description
Clicked outside of dropdown the menu should auto close.
To reproduce

Select configured model Claude sonnet
Open toolbox selection
Click outside of dropdown

Log output
NA

I have a fix for this in an upcoming PR! Thanks for the +1.


[Bug] precondition failure for module invariant

🐛 Bug
Encountered the precondition failure of a module invariant when a private function did nothing to violate the invariant, but just called a public function.
To reproduce
Add the following module spec to LibraAccount.move.
spec module {
        invariant Roles::spec_has_libra_root_role_addr(CoreAddresses::SPEC_LIBRA_ROOT_ADDRESS()) ==>
            !exists<Balance<Coin1>>(CoreAddresses::SPEC_LIBRA_ROOT_ADDRESS());
}

Stack trace/error message
Although, it produces multiple errors for precondition failure and timeout, please focus on the following error message:
     ┌── LibraAccount.move:869:9 ───
     │
 869 │ ╭         invariant Roles::spec_has_libra_root_role_addr(CoreAddresses::SPEC_LIBRA_ROOT_ADDRESS()) ==>
 870 │ │             !exists<Balance<Coin1>>(CoreAddresses::SPEC_LIBRA_ROOT_ADDRESS());
     │ ╰──────────────────────────────────────────────────────────────────────────────^
     ·
 630 │     public fun add_currency<Token>(account: &signer) {
     │                ------------ called function
     │
     =     at LibraAccount.move:440:5: add_currencies_for_account
     =         new_account = 0x11,
     =         add_all_currencies = false,
     =         new_account_addr = 0x11
     =     at LibraAccount.move:444:40: add_currencies_for_account
     =     at LibraAccount.move:630:5: add_currency (entry)

What is going is:
Note that add_currencies_for_account is a private function. Boogie starts from
$LibraAccount_add_currencies_for_account_$verify which calls
$LibraAccount_add_currencies_for_account_$def_verify which calls
$LibraAccount_add_currency_$direct_intra which comes from the public function add_currency, and requires the invariant as a precondition as follows:
requires b#$Boolean($Boolean(b#$Boolean($Roles_spec_has_libra_root_role_addr($m, $txn, $CoreAddresses_SPEC_LIBRA_ROOT_ADDRESS())) ==> b#$Boolean($Boolean(!b#$Boolean($ResourceExists($m, $LibraAccount_Balance_type_value($Coin1_Coin1_type_value()), $CoreAddresses_SPEC_LIBRA_ROOT_ADDRESS()))))));

And (I think) this precondition fails because it wasn't assumed at the beginning of the private function add_currencies_for_account.
Expected Behavior
No such precondition failure errors

This is by design because spec module { invariant ... is only applied to public functions. In order to work around, use schema and apply.


Local configuration issue with single quotes

In opposite to the already fixed standard configuration files it is not possible to use single quotes inside a local configuration file.
Example:
${params}['global']['teststring'] : "I am the 'local' configuration"
Causes:
ERROR - Loading local config failed! Reason: Could not set variable 'params['global']['teststring']' with value 'I am the 'local' configuration'!
UNKNOWN - Unknown exception occurs. Details: Could not set variable 'params['global']['teststring']' with value 'I am the 'local' configuration'!

Single quotes should be possible also in local configuration
The log file contains two error messages with mostly the same content. This redundancy should be avoided
The variable name is incomplete (${} is missing): 'params['global']['teststring']' instead of '${params}['global']['teststring']'

Reference:
https://github.com/test-fullautomation/robotframework-testsuitesmanagement/tree/HolQue/task/documentation_updates_and_fixes

Tracket with
https://github.com/test-fullautomation/python-jsonpreprocessor/issues/40


[FLINK-4201] [runtime] Forward suspend to checkpoint coordinator

Suspended jobs were leading to shutdown of the checkpoint coordinator and hence removal of checkpoint state. For standalone recovery mode this is OK as no state can be recovered anyways (unchanged in this PR). For HA though this lead to removal of checkpoint state, which we
actually want to keep for recovery.
We have the following behaviour now:

JobState
Standalone
High Availability

SUSPENDED
Discard
Keep

FINISHED/FAILED/CANCELED
Discard
Discard

I think that change is good in "our" philosophy, just wondering about the following implication:
Some people want to run HA setups without ZooKeeper, simply using an external service to make sure that the JobManager is restarted. The latest completed checkpoint is found via a well-defined path in the checkpoint storage (rather than a well defined path in ZooKeeper).
That works as an HA setup (with the exception of being susceptible to "split brain" behavior in the presence of network partitions.
Would we interfere with such a setup when removing checkpoints on "suspend" in "standalone" mode?
BTW: We should really find a new name for "standalone" more ;-) The term is overloaded.

Thanks for taking a look, Stephan.
Regarding your question: Would we interfere with such a setup when removing checkpoints on "suspend" in "standalone" mode?:
Yes, we would interfere, but what you describe is currently not possible with Flink (that is no one can run it like that). The problem is that recovery on the master is tightly coupled to ZooKeeper (configured via recovery.mode: ZOOKEEPER). I really like your idea and agree that it should be possible to run an HA setup like that. I will open an issue for it. Do you think it's important to fix this for 1.1 already?
Regarding the name standalone:
I fully agree. We have a standalone cluster mode and standalone recovery mode. Our standalone recovery mode (recovery.mode: STANDALONE) actually means NO_RECOVERY. I think that's what also made you assume that what you describe is possible, right?

I think as it is, it is fine.
Let's extend the option for HA in a separate issue. We could have:

high-availability: none (what is currently standalone recovery)
high-availability: filesystem (no protection against split brain partitioning)
high-availability: zookeeper


only the features in the top layer can be selected

When using openlayers3, I have a problem. In our project, we initialize a map with a tile layer and a vector layer, the tile layer is at the bottom and the vector layer is at the top in the map.
Then we add some features to the vector layer and bind select click interaction to them. Util now, everything is ok, we click the feature and the event is triggered.
When the zoom level comes to 9, we initialize another five vector layers and add them to the map by using ol.Map.addLayer(). At the same time, we add features to the new five vector layers respectively and bind select click interafction to them. The features are successfully displayed on the map.
Finally, we find that only the features in the vector layer which is last added to the map can be selected. That means the features in the layers below the top layer both can't be selected?

You can set zIndex to the layers.

@cs09g
That' right, I can set zIndex to all the layers, but my problem is I can't select all the features in different layers.

Can you create a minimal non-working example? And please share some code here.

Closing due to lack of activity.


Reorganize project structure

I’m planning on submitting a priority queue based Dijkstra pull request, so I went ahead and started setting things up.
There’ll need to be a dependency on your SwiftPriorityQueue pod. Don’t imagine you have any issue with that ;) . Because of the way Cocoapods are brought down, there needs to be a Podfile for the example project now. To make this as clean as possible, I have moved the example project into its own directory and added SwiftGraph as a development pod. This project also runs the tests, which are still in the root. My changes bring the structure into line with the current Pod template: https://github.com/CocoaPods/pod-template

Hi @nickswalker,
First, thank you for the contribution and a lot of great ideas for improvement too! I would definitely like to make improvements both to the CocoaPods support and also include SwiftPriorityQueue for dijkstra.
Before you go too far down this path though, I have some concerns about tying the project too closely to CocoaPods (although I love CocoaPods). A lot of users casually download the project and want to be able to just run it without necessarily having CocoaPods. There are also users who just want to manually download the project and copy all of its source files into their own project. Plus there's the need for SPM support. So, I don't want to tie any required files (i.e. the Priority Queue) through a dependency. Also, I don't think users should have to have CocoaPods installed to run the example program or tests.
So here's what I propose:

I'll add SwiftPriorityQueue's single source file to the project directly (this is not something that changes that often, but I can swap in new releases as needed).
I'll change the dijkstra methods to use SwiftPriorityQueue instead of the built-in Queue class.
We can reorganize the example project to have its own directory as you've done but I don't want to make it dependent on CocoaPods.
We can perhaps have the unit tests auto-run from CocoaPods some how? I'm sure there must be a feature for this... Or perhaps setting up some kind of continuous integration is the right avenue.

Thank you again for your work and ideas,
Dave

Just an FYI - version 1.0.6 includes SwiftPriorityQueue in source form and updated dijkstra() to use it.

On not wanting to depend on Cocoapods: that's fair. The standard solution is just to shrink-wrap (track the Pods directory). This is equivalent to bundling the source of the dependency manually, but superior because updates are as simple as pod install. Using Cocoapods in this way doesn't break SPM support. All that's needed to cover the dependency on that front is just to add the dependency declaration to the manifest.


Ubuntu software instructions require enabling universe or multiverse repository

I tried the instructions from the readme on a plain Ubuntu live CD and there were several errors about missing packages. I got around this by adding 'universe multiverse' to each networked repo in /etc/apt/sources.list before doing apt update. After this the procedure worked.
It was an ubuntu 18.04.2 live cd.

I have only used Debian Live for this setup, but this is good to know. Feel free to make a PR adding a note for Ubuntu users.

Isn't it a bad thing to add "community maintaned" software to the repo list? Who compiles these softwares?

still thinking about the community maintained issue


Equalizer: Cannot turn stacking off?

I've tried switching stacking off inside 6.0.6 by setting all equalizeOnStack references to false in the default files, but my columns are still stacking.
Is this a bug? I noticed @zurbrandon mentioned that Equalizer was being rewritten for 6.1, but figured I'd mention it just in case.
:)

Yeah, this is currenrt;y sitting on the 6.1 branch if you'd like to check it out.
We're adding a data-equalize-on="[breakpoint]" so you can use the Foundation named breakpoints to controll this.

That's awesome. Love your work!
:)

Thanks! I'll close this now, since it's all sitting pretty on the 6.1 branch.
Keep the bugs and PRs coming!

Hey @zurbrandon does this mean the equalize feature:
data-equalize-on="[breakpoint]"

Include medium up / small only / large only etc?
Also where does the 6.1 branch reside, if public?


[raster] Make small fonts look good

Since this library now has a raster module...
Recent work (mostly #49 and kas-gui/kas#201) has improved legibility of small fonts to the point that 5-6pt fonts are fairly easy to read, but quality is still lacking compared to more mature systems.
Likely this means grid fitting (instructing) glyphs. There doesn't currently appear to be a Rust library available for this.
Another approach would be to use system-native libraries, possibly via crossfont, though this should be optional (allowing pure-Rust usage).

Examples of current appearance at 5, 6, 8pt (Noto Sans):


Conflict with Munki install

From support ticket 70120
XCreds 4 install via munki during bootstrapping while munki is running in LoginWindow context causes errors/failures in all future munki installs seemingly because rights have changed. XCreds 3 didn’t have this issue.

added hideIfPathExists preference. If that file exists, xcreds does not show until the file disappears.


remove single cell tag from tutorials

I've learned it's bad practice to label a tag the same as the actual page, so let's remove it! Woo!

Also, remove from the Spanish version? There are some linting issues, mainly due to incorrect levels of headings. Otherwise, looks good.

Also, remove from the Spanish version? There are some linting issues, mainly due to incorrect levels of headings. Otherwise, looks good.

Only because we aren't upkeeping them (still waiting on that grant to come through :-P)
But I'm not killing the pages so Spanscriptomics still lives...
But also Jurgi will create a better automated system (hopefully) so all hope is not lost for the Spanish translations

Made more sense when they were in transcriptomics, now that they're in their own category this looks like an improvement!
Would you mind fixing some of the heading level issues while you're here?

Done!

@hexylena I can't figure out the latest linting error...

I can't figure out the latest linting error...

ähm, you find the best failure modes, ¿thank you? for flagging them for us to fix lol

Ok it's due to having tags: rather than tags: [] but that should be caught earlier in the linting process, not this late. But our schema validation library apparently doesn't check types properly, so nil was allowed for a sequence. So I guess we'll be more careful about how we handle tags access and that'll fix it.

I am a magic beast at finding new ways to screw up
Thank you fantastic GTN overlord!


Param Values container $$ are handled incorrectly

Expected Behavior
If param value is Heloo$$World, it should preserve the value as Hello$$World
Actual Behavior
If param value is Heloo$$World, it is interpreted  as Hello$World
Steps to Reproduce the Problem
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: print
  annotations:
    tekton.dev/output_artifacts: '{}'
    tekton.dev/input_artifacts: '{}'
    tekton.dev/artifact_bucket: mlpipeline
    tekton.dev/artifact_endpoint: minio-service.kubeflow:9000
    tekton.dev/artifact_endpoint_scheme: http://
    tekton.dev/artifact_items: '{"print": []}'
    sidecar.istio.io/inject: "false"
    pipelines.kubeflow.org/big_data_passing_format: $(workspaces.$TASK_NAME.path)/artifacts/$ORIG_PR_NAME/$TASKRUN_NAME/$TASK_PARAM_NAME
    pipelines.kubeflow.org/pipeline_spec: '{"inputs": [{"name": "msg1", "type": "String"},
      {"name": "msg2", "type": "String"}, {"name": "msg3", "type": "String"}], "name":
      "print"}'
spec:
  params:
  - name: msg1
    value: 'Hello$World'
  - name: msg2
    value: 'Hello$$World'
  - name: msg3
    value: 'Hello$$$World'
  pipelineSpec:
    params:
    - name: msg1
    - name: msg2
    - name: msg3
    tasks:
    - name: print
      params:
      - name: msg1
        value: $(params.msg1)
      - name: msg2
        value: $(params.msg2)
      - name: msg3
        value: $(params.msg3)
      taskSpec:
        steps:
        - name: main
          command:
          - sh
          - -c
          - |
            set -e
            echo $0
            echo $1
            echo $2
          - $(inputs.params.msg1)
          - $(inputs.params.msg2)
          - $(inputs.params.msg3)
          image: alpine:3.6
        params:
        - name: msg1
        - name: msg2
        - name: msg3
        metadata:
          labels:
            pipelines.kubeflow.org/pipelinename: ''
            pipelines.kubeflow.org/generation: ''
            pipelines.kubeflow.org/cache_enabled: "true"
          annotations:
            pipelines.kubeflow.org/component_spec_digest: '{"name": "print", "outputs":
              [], "version": "print@sha256=31440a8ab18c8ba984932d31ed033270af4f1787c4987762c68930fd032ffeaf"}'
            tekton.dev/template: ''
      timeout: 525600m
  timeout: 525600m

Output from above script
Hello$World
Hello$World
Hello$$World

Additional Info

Kubernetes version:
Kubernetes Version: 1.23

Tekton Pipeline version:
Tekton Version: 0.35

/cc @pritidesai @afrittoli

This is blocking some of our Kubeflow users where inputs with multiple "$" will not pass into the argument list correctly.

I think there are some test cases for the spec.steps.*.script, but not for params.
https://github.com/tektoncd/pipeline/blob/main/examples/v1alpha1/taskruns/step-script.yaml#L102-L118

found the old issue for the double dollar sign: https://github.com/tektoncd/pipeline/issues/3871
and it explains that's expected behavior in Kubernetes: https://github.com/kubernetes/kubernetes/issues/101137
seems for script, this issue is fixed in tekton side. right now the question is how to fix that for the param

cc @Aleromerog

@sbtest I just tried to re-create the error but I cannot. It may have been fixed in one of the recent releases.
chitrang-macbookpro:pipeline chitrang$ kubectl get pr print -o yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  creationTimestamp: "2022-07-29T17:54:15Z"
  generation: 1
  labels:
    tekton.dev/pipeline: print
  name: print
  namespace: default
  resourceVersion: "1671714"
  uid: 8fc3b397-3b6b-4d3b-b9bd-c51ca7865b3e
spec:
  params:
  - name: msg1
    value: Hello$World
  - name: msg2
    value: Hello$$World
  - name: msg3
    value: Hello$$$World
  pipelineSpec:
    params:
    - name: msg1
      type: string
    - name: msg2
      type: string
    - name: msg3
      type: string
    tasks:
    - name: print
      params:
      - name: msg1
        value: $(params.msg1)
      - name: msg2
        value: $(params.msg2)
      - name: msg3
        value: $(params.msg3)
      taskSpec:
        metadata: {}
        params:
        - name: msg1
          type: string
        - name: msg2
          type: string
        - name: msg3
          type: string
        spec: null
        steps:
        - image: alpine
          name: do-something
          resources: {}
          script: |
            echo "$(params.msg1), $(params.msg2), $(params.msg3)"
  serviceAccountName: default
  timeout: 1h0m0s
status:
  completionTime: "2022-07-29T17:54:25Z"
  conditions:
  - lastTransitionTime: "2022-07-29T17:54:25Z"
    message: 'Tasks Completed: 1 (Failed: 0, Cancelled 0), Skipped: 0'
    reason: Succeeded
    status: "True"
    type: Succeeded
  pipelineSpec:
    params:
    - name: msg1
      type: string
    - name: msg2
      type: string
    - name: msg3
      type: string
    tasks:
    - name: print
      params:
      - name: msg1
        value: Hello$World
      - name: msg2
        value: Hello$$World
      - name: msg3
        value: Hello$$$World
      taskSpec:
        metadata: {}
        params:
        - name: msg1
          type: string
        - name: msg2
          type: string
        - name: msg3
          type: string
        spec: null
        steps:
        - image: alpine
          name: do-something
          resources: {}
          script: |
            echo "$(params.msg1), $(params.msg2), $(params.msg3)"
  startTime: "2022-07-29T17:54:15Z"
  taskRuns:
    print-print:
      pipelineTaskName: print
      status:
        completionTime: "2022-07-29T17:54:25Z"
        conditions:
        - lastTransitionTime: "2022-07-29T17:54:25Z"
          message: All Steps have completed executing
          reason: Succeeded
          status: "True"
          type: Succeeded
        podName: print-print-pod
        startTime: "2022-07-29T17:54:15Z"
        steps:
        - container: step-do-something
          imageID: docker.io/library/alpine@sha256:7580ece7963bfa863801466c0a488f11c86f85d9988051a9f9c68cb27f6b7872
          name: do-something
          terminated:
            containerID: containerd://5b51a3a116d57342251b5d212b2012d807d69ab2563539858a7226e25d7faf2d
            exitCode: 0
            finishedAt: "2022-07-29T17:54:25Z"
            reason: Completed
            startedAt: "2022-07-29T17:54:25Z"
        taskSpec:
          params:
          - name: msg1
            type: string
          - name: msg2
            type: string
          - name: msg3
            type: string
          steps:
          - image: alpine
            name: do-something
            resources: {}
            script: |
              echo "Hello$World, Hello$$World, Hello$$$World"

https://github.com/tektoncd/pipeline/blob/main/examples/v1alpha1/taskruns/step-script.yaml#L102-L118

We are seeing this problem when the steps are defined with k8s command and args. For steps.[*].script we confirmed it's working, but it needs to run the place-script init-container which is something we try to avoid for optimizing our pipeline performance.

I see the output you showed when I use command + args indeed. However, as far as the substitutions go, there is no issue there:
  startTime: "2022-07-29T18:17:46Z"
  taskRuns:
    print-print:
      pipelineTaskName: print
      status:
        completionTime: "2022-07-29T18:17:51Z"
        conditions:
        - lastTransitionTime: "2022-07-29T18:17:51Z"
          message: All Steps have completed executing
          reason: Succeeded
          status: "True"
          type: Succeeded
        podName: print-print-pod
        startTime: "2022-07-29T18:17:46Z"
        steps:
        - container: step-do-something
          imageID: docker.io/library/ubuntu@sha256:b6b83d3c331794420340093eb706a6f152d9c1fa51b262d9bf34594887c2c7ac
          name: do-something
          terminated:
            containerID: containerd://90d0f08cc3a04fe81caf28a6e835eb3f1ccbd5ec3977ffcf1636063f3d20f25d
            exitCode: 0
            finishedAt: "2022-07-29T18:17:50Z"
            reason: Completed
            startedAt: "2022-07-29T18:17:50Z"
        taskSpec:
          params:
          - name: msg1
            type: string
          - name: msg2
            type: string
          - name: msg3
            type: string
          steps:
          - command:
            - sh
            - -c
            - |
              set -e
              echo $0
              echo $1
              echo $2
            - Hello$World
            - Hello$$World
            - Hello$$$World
            image: alpine
            name: do-something
            resources: {}

I think it might be something about how we execute command+args vs script that must be different.

I verified that right before the creation of the Pod to run the task, the substitutions are indeed correct. i.e. Hello$World, Hello$$World and Hello$$$World. However, in the entry pointer, if I log the input command and args, I see it update Hello$World Hello$World Hello$$World. That led me to think that it may be a kubernetes thing. Somehow Kubernetes updates the command and args.
So, I tried to create this Pod:
apiVersion: v1
kind: Pod
metadata:
  name: command-demo
  labels:
    purpose: demonstrate-command
spec:
  containers:
  - name: command-demo-container
    image: alpine
    command: ["echo"]
    args: ["Hello$World", "Hello$$World", "Hello$$$World"]

The output I see is indeed affected: Hello$World Hello$World Hello$$World
Seems like Kubernetes is changing the $signs somehow.


Chart preview and music breaks upon changing display name

Describe the bug
If i have chart preview open and change my display name a variety of different bugs occur.
To Reproduce
Steps to reproduce the behavior:

Go to any song
Click on the display name
Change it or keep it how it is
Music breaks, if the song is up/downrated the scroll speed and physical chart difficulty goes weird, especially if its a major rate change, you cant pause the chart

Expected behavior
The chart preview resumes as normal.
Screenshots
I cant use screenshots because the problem isnt noticeable unless its as a video,
Desktop (please complete the following information):

OS: Windows
Version 10
64bit or 32bit 64 bit

Additional context
I found it out originally on connect 1986 but it still applys for other charts

duplicate #878


Fix #79: omit unnecessary quotes in property names

This omits quotes for property names which don't need them, fixing #79. It doesn't touch property names in flow type annotations, since I'm not sure which quotes are semantic there.
There's currently no tests, and no effect on the snapshots. As an example of its effect, currently the below passes through prettier without change:
function f({ "a": b = c }) {}
({ "0": null });
class A {
  ["d"];
  "e";
  "f"() {}
  get "g"() {}
  +"0";
}

With this PR, it becomes
function f({ a: b = c }) {}
({ 0: null });
class A {
  ["d"];
  e;
  f() {}
  get g() {}
  +0;
}

Please take an especially careful look printPropertyKey, since I'm not entirely sure how it ought to be implemented.

I like this idea. We can do small things like this that help teach programmers that they are the same, and are relatively non-controversial. I'm fine merging this, will review.

Cool, thanks!


Additional check for $argv variable when detecting CLI

Description
After checking existence of REMOTE_ADDR and HTTP_USER_AGENT keys in $_SERVER, additionally check if the $argv is set. Please note this will fail if the ini directive register_argv_argc is turned on for non-CLI requests.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

@paulbalandan This seems so solve the issue


Cannot access Google API

Hi there,
I'm having a hard time figuring out how to access a google API through the service accounts with this gem.
Google provides a basic example in python:
https://gist.github.com/solars/4630bd14cddcb5c9bdac
I've got a keys file and try to use the client like this:
client = OAuth2::Client.new(data['client_email'], data['private_key'], :site => apiscope)
However, now I have no idea how to get the service token - can anyone please give me a hint which method to use? I thought token = client.client_credentials.get_token but this results in Error "Unknown"
Thanks a lot,
Christoph

Can anyone help me please?

Once you have a token is just a matter of doing the api calls, for example:
token = OAuth2::AccessToken.new(client, 'your-token-here')
p JSON.parse(token.get('/oauth2/v2/userinfo').body)

Will print the user info.


Question: how I can deal with randombytes dependency of eth-keyring-controller?

Hey! Getting this error when trying to instantiate new eth-keyring-controller class in my background script environment:

So service worker registration fails, I am using "@metamask/eth-keyring-controller": "^10.0.0"
Pls help!

Hi @ko1ebayev. We see some code, but what's the error?

Hey! code that gives an error is just a const keyringController = new KeyringController({}), content on pic is a peace of code after webpack build.
Btw, I solved this. The documentation is not complete regarding the complete lib setup. For complete setup we need a lot of polyfills. Im using Webpack 5 and typescript in my project, so the list of polyfills is:

And the second thing, I used webpack.ProvidePlugin to setup global and process identifiers for my build:

Got it, thanks for posting an update and glad you figured it out @ko1ebayev. I agree about the lack of documentation around polyfills. We are revamping this library, but for the time being I've noted this in #199 so it doesn't get lost. Since I answered your question I'll close this issue now!


Proper Documentation for Multiplexing

Multiplexing needs a little bit more documentation.
I've connected HocusPocusProvider using HocuspocusProviderWebsocket perfectly. And now all my documents is using a single websocket, rather than a new websocket for each document. But I am facing two issues here:

How to disconnect the provider on leaving the document? Because if I will call myProvider.disconnect() it disconnects the websocket as well. and myProvider.close() or setting myProvider as null doesn't update the awareness at all.
Document connects and everything works just fine but after some time I receive [HocuspocusProvider] An authentication token is required, but you didn’t send one. Try adding a token to your HocuspocusProvider configuration. Won’t try again.
Although I am providing sending the token. I've even tried removing the whole Authentication Check on Server side as well. My guess is that it has something to do with Point 1. Because the provider for the previous document isn't closing properly, but I am not sure.

Can you provide some help on this ASAP. Thanks

@develink if you want to disconnect the provider without disconnecting the socket, you can call provider.terminate (HocuspocusProvider, not HocuspocusProviderWebsocket).
About your second point, there's an issue about it here: #566

hi @janthurau thanks for the reply. But there is no function terminate for HocuspocusProvider. I looked into the code also of HocuspocusProvider.

hi @janthurau Thanks for the reply. Unfortunately there is no method as such called terminate for the HocusPocusProvider. I've searched in the github repository code as well for the Provider. Am I missing something here?

Ah sorry, I meant destroy 🤦♀

But destroy actually disconnects the websocket as well. I want to retain the websocket connected but provider disconnected. So that I can open another document on the same websocket connection again.

But destroy actually disconnects the websocket as well. I want to retain the websocket connected but provider disconnected. So that I can open another document on the same websocket connection again.

Ah, yea that doesn't work atm because the server will close the connection once the last document was closed.
So you can either first open the new provider and then destroy the old one, or you create a patch that adds some kind of delay before the server closes the connection (or you wait until someone adds it :))

That's a bump. 2.0 actually created more issues rather than solving anything. Guess I have to go back to 1.0, at least that was somewhat working.


Clicking Pie Chart Slice in Insight with Reverse Lookup Checked Writes Invalid Details Filter

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
In Insight, after turning on Reverse dns and clicking a slice of the pie to jump to Details view, the view shows nothing because the (src) Address filter is invalid. (It is populated with the hostname.)
To Reproduce
Steps to reproduce the behavior:

Go to Insight, Totals tab.
In Top usage ports / sources (bytes) check the Reverse lookup box.
Click a portion of the pie chart that has a resolved address to jump to the Details tab.
Note the (src) Address is populated with the resolved hostname and not the IP, resulting in no data being found.

Expected behavior
I'd expect that (src) Address would be populated with the IP so the Details view can show information.
Environment
OPNsense 20.7.7_1-amd64
FreeBSD 12.1-RELEASE-p11-HBSD
OpenSSL 1.1.1i 8 Dec 2020

https://github.com/opnsense/core/commit/c797bfd220c40e914f3bdd1dbd07c9c4377984f8 should do the trick, to test it should be enough to opnsense-patch on a console and reload the page:
opnsense-patch c797bfd

https://github.com/opnsense/core/commit/c797bfd220c40e914f3bdd1dbd07c9c4377984f8 should do the trick, to test it should be enough to opnsense-patch on a console and reload the page:
opnsense-patch c797bfd

Well, thank you! That was incredibly quick and is now working just as I'd expect. Thank you!

Well, thank you! That was incredibly quick and is now working just as I'd expect. Thank you!


Off-Chain Computation Ideas

A few ideas for off-chain computation:

Tools for computationally heavy tasks (e.g. Fourier transforms)
Oracles (will be better once http requests are merged)
Supply chain (oracle for sensor data + off-chain compute, store result on chain. example: accelerometer measuring shock/vibration in transit, computing FFT off chain, storing ASD (just two short arrays as opposed to long time series) on chain)

cc @tomusdrw

could be cool to make a price oracle that accounted for price slippage; so it would take the T::AccountId's balanceOf (amount staked) as an input and then estimate liquidity conditions (from exchanges) to calculate the price if the given account needed to immediately exit and sell

the justification is that most protocols benefit from instant withdrawals and fast exist (like a dao, or plasma chain)) so it would be cool to provide a tool to check the price based on amount (to improve on the current view of price which doesn't account for the slippage that occurs with large sales/purchases)

could be cool to make a price oracle that accounted for price slippage; so it would take the T::AccountId's balanceOf (amount staked) as an input and then estimate liquidity conditions (from exchanges) to calculate the price if the given account needed to immediately exit and sell
the justification is that most protocols benefit from instant withdrawals and fast exit (like a dao, or plasma chain)) so it would be cool to provide a tool to check the price based on amount (to improve on the current view of price which doesn't account for the slippage that occurs with large sales/purchases)

The problem with this is that block times are much greater than order-book latency, so a trading strategy would be to create an inefficiency by making a strong order book to give the illusion of liquidity, watching for unstaking events, and cancelling orders as soon as the first dust order was filled, removing the liquidity so the actual fill is at a much worse rate. All this could happen in an interval much shorter than a single block.

could be cool to make a price oracle that accounted for price slippage; so it would take the T::AccountId's balanceOf (amount staked) as an input and then estimate liquidity conditions (from exchanges) to calculate the price if the given account needed to immediately exit and sell
the justification is that most protocols benefit from instant withdrawals and fast exit (like a dao, or plasma chain)) so it would be cool to provide a tool to check the price based on amount (to improve on the current view of price which doesn't account for the slippage that occurs with large sales/purchases)

The problem with this is that block times are much greater than order-book latency, so a trading strategy would be to create an inefficiency by making a strong order book to give the illusion of liquidity, watching for unstaking events, and cancelling orders as soon as the first dust order was filled, removing the liquidity so the actual fill is at a much worse rate. All this could happen in an interval much shorter than a single block.

In that case, could create a DEX that enforces some order-book latency greater than the block time. Also, could use a consensus mechanism that trades consistency for availability -- for faster block times with a some relatively higher probability of reversion. I need to understand rhododendron better, but what if we could get block times below order-book latency -- would that patch this attack?
Also, we're going to need a price oracle either way so I think this is a better approach than ignoring liquidity as an input for price for sale/purchase. What we could do is aggregate data from multiple exchanges and use some randomness to make this unpredictable as to make the oracle more difficult to game in the way you described.

what if we could get block times below order-book latency -- would that patch this attack?

Not really possible, for example, a lot of exchanges run on AWS. If you host your trading bot in the same data center as the exchange, latency for placing/cancelling orders is intra-building and only requires a single, one-way message. Latency for consensus is worldwide and involves multiple messages between peers.

Offchain workers have been documented in both the recipes and main Substrate repo. I'm closing this as we switch to the new CMS repo. Feel free to open specific actionable issues about any of these ideas in the new repo.


Read from sqlite in IT and add cache decider IT

Fixes #:
Description of changes:
Read from sqlite in IT and add cache decider IT
sqlite> .tables
HotClusterSummary   HotResourceSummary  RCA
HotNodeSummary      PersistedAction
sqlite> select * from PersistedAction
   ...> ;
PersistedAction_ID  nodeIps      muted       actionName          timestamp      nodeIds     summary                                                                       actionable  coolOffPeriod
------------------  -----------  ----------  ------------------  -------------  ----------  ----------------------------------------------------------------------------  ----------  -------------
1                   {<IP_ADDRESS>}  0           ModifyCacheMaxSize<PHONE_NUMBER>101  {DATA_0}    Update [FIELD_DATA_CACHE] capacity from [10000] to [100000] on node [DATA_0]  1           300000

Tests:
IT
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

can we also start adding how much time this IT is taking currently ?

Added the time taken to the description above.

So these two tests have increased the total runtime by 10 mins ?

Right. These two are taking 10 mins.

Also adding these tests have significantly increased the time for the build (25 mins total). Will create a task to make the cool_off_period configurable so that we can make them operate faster.


I can't run the Example.go

Sorry, been a while since I last used Go. I tried changing the package to main so I could run the Example.go but then I found
Example.go:49:14: undefined: CreateDecisionTable
Then I became stuck as even after using the replace in go.mod to allow me to reorganise the code base I still couldn't figure out how to rn this Example.

Sorry worked out how to fix this locally, although it still doesn't run properly ;-)

Hey @stevef1uk, sorry for the inconvenience, ReadMe and Example.go was not updated to the latest version that supports OMG standard grammar. Should be sorted out now.
The lib is still a work in progress, I guess that you had problems with DateAndTime expressions which are currently being implemented, so I have removed those from Example.go until it is finished.

Many thanks that now runs successfully :-)


Improve MulticlassConfusionMatrixEvaluator

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f5c3477) to head (775c32f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #550   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          131       131
  Lines         3683      3688    +5
  Branches       182       182
=========================================
+ Hits          3683      3688    +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix konnected unique_id computation for switches

Breaking Change:
This will change the internal unique_id for Konnected switches (i.e. siren, buzzer, generic switch). Users will need to manually remove the orphaned switch entities from the entity registry after updating and re-configure any changes stored in the entity registry (i.e. name and entity_id), as their unique IDs will change.
Description:
Previous fix for #22389 used a flawed hashing algorithm to generate unique_id. This simplifies and ensures that unique_id is unique and deterministic.
Related issue (if applicable): fixes #22746
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

@MartinHjelmare thank you for the suggestion. I researched various hashing methods but ultimately decided that the complexity wasn't worth it and a simple unique string by concatenating the configurable characteristics would work just fine.

Adding breaking change label to highlight the user interaction required, even though this is a fix.

Can be merged when build passes.

is it possible to get this into a patch release?

It's already tagged.

I'd like to incorporate this into my current build, but (I'm sorry) I have no idea how.


How about a time picker widget?

Hi, thoroughly impressed with the responsiveness of these widgets, though you are missing a timepicker which is preventing me from using this lib in my hobby project.
Any plans for implementing this?

Thanks to UIkit :)
Definitely yes, although without ETA. We are waiting for UIkit 3 to release Datepicker and see what features will deliver. If no timepicker layout included we would build our own.


Workflows built in SFCP namespace always use latest tag for builder image

Describe the bug
Problem seems to be rooted in SFCP not using  values from:
ConfigMap of operator -> controllers_cfg.yaml
and just use the default builder configmap dockerfile.
Expected behavior
SFCP workflows use the builder image from controllers-config ConfigMap of operator -> controllers_cfg.yaml
Actual behavior
SFCP workflows use the builder image from builder configmap
How to Reproduce?

Deploy SFP with JS and DI postgresql ephemeral

Deploy SFCP in separate namespace and reference above SFP

Create new SF-Greeting in the SFCP NS

Check log of the build ->It will use <builder-image>:latest

Create new SF-Greeting-2 in SFP NS

Check log of the build -> it will use <budilder-image>:9.99.0

Inspect NS where operator is runnning, find configmap of builder

You can see there is a FROM <builder_image>:latest

Change this line to some other image

Repeat from point, but just restart the builds of the SF CR's

Output of uname -a or ver
No response
Golang version
No response
Operator-sdk version
No response
SonataFlow Operator version or git rev
No response
Additional information
No response

@domhanak Actually, the SonataFlowClusterPlatform is a cluster resource, hence it does not have a namespace. What happened here is that the operator created a default SonataFlowPlatform in the namespace of the workflow SF-Greeting. This automatic created platform is missing the default configuration. Please check my PR, it fixed the issue.

@ricardozanini Yea apologies for that, what I meant is simply a new NS on a cluster that has SFCP set. Will take a look.


Maestral GUI fails to run on Fedora 35/Gnome 41 - returns this error:

On a fresh install of Fedora 35/Gnome 41, installing maestral with the gui tag and then running "maestral gui" returns this error:
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
Traceback (most recent call last):
File "/home/ristretto/.local/bin/maestral", line 8, in
sys.exit(main())
File "/usr/lib/python3.10/site-packages/click/core.py", line 1137, in call
return self.main(*args, **kwargs)
File "/usr/lib/python3.10/site-packages/click/core.py", line 1062, in main
rv = self.invoke(ctx)
File "/usr/lib/python3.10/site-packages/click/core.py", line 1668, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3.10/site-packages/click/core.py", line 763, in invoke
return __callback(*args, **kwargs)
File "/home/ristretto/.local/lib/python3.10/site-packages/maestral/cli.py", line 711, in gui
run(config_name)
File "/home/ristretto/.local/lib/python3.10/site-packages/maestral_qt/main.py", line 631, in run
maestral_gui.load_maestral()
File "/home/ristretto/.local/lib/python3.10/site-packages/maestral_qt/main.py", line 192, in load_maestral
self.loading_done = SetupDialog.configureMaestral(self.mdbx)
File "/home/ristretto/.local/lib/python3.10/site-packages/maestral_qt/setup_dialog.py", line 384, in configureMaestral
fsd = SetupDialog(mdbx, parent)
File "/home/ristretto/.local/lib/python3.10/site-packages/maestral_qt/setup_dialog.py", line 81, in init
b.setMinimumWidth(width)
TypeError: setMinimumWidth(self, int): argument 1 has unexpected type 'float'
Not sure where to go from there, hope this is helpful getting it working again on Fedora!
~M

Thanks for the report! This is due to a change in how Python 3.10 passes on floats to extension modules. The issue was already reported in #509 and is currently being tracked with the GUI at https://github.com/SamSchott/maestral-qt/issues/18.


Route address binding failures through logging.

Route address binding failures through logging so that anything scraping stdout can more easily parse the errors.
Additional changes:

Move authentication log messages to LoggingExtensions.
Handle invalid addresses when parsing binding addresses.

Sample output when SSL cert is not configured and when authentication is disabled:
11:57:08 warn: Microsoft.Diagnostics.Tools.Monitor.ExperimentalToolLogger[0]
      WARNING: dotnet-monitor is experimental and is not intended for production environments yet.
11:57:09 fail: Microsoft.Diagnostics.Tools.Monitor.Startup[0]
      Unable to bind to https://localhost:52323. Dotnet-monitor functionality will be limited.
      System.InvalidOperationException: Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found or is out of date.
      To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
      For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
         at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions, Action`1 configureOptions)
         at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions)
         at Microsoft.Diagnostics.Tools.Monitor.DiagnosticsMonitorCommandHandler.<>c__DisplayClass8_2.<CreateHostBuilder>b__11(ListenOptions listenOptions) in D:\src\dotnet\dotnet-monitor\src\Tools\dotnet-monitor\DiagnosticsMonitorCommandHandler.cs:line 231
         at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerOptions.ListenLocalhost(Int32 port, Action`1 configure)
         at Microsoft.Diagnostics.Tools.Monitor.DiagnosticsMonitorCommandHandler.<>c__DisplayClass8_0.<CreateHostBuilder>b__10(WebHostBuilderContext context, KestrelServerOptions options) in D:\src\dotnet\dotnet-monitor\src\Tools\dotnet-monitor\DiagnosticsMonitorCommandHandler.cs:line 239
11:57:09 warn: Microsoft.Diagnostics.Tools.Monitor.Startup[13]
      WARNING: Authentication has been disabled. This can pose a security risk and is not intended for production environments.
11:57:09 warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Overriding address(es) 'https://localhost:52323'. Binding to endpoints defined in UseKestrel() instead.
11:57:09 info: Microsoft.Hosting.Lifetime[0]
      Now listening on: http://localhost:52325
11:57:09 info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
11:57:09 info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
11:57:09 info: Microsoft.Hosting.Lifetime[0]
      Content root path: D:\src\dotnet\dotnet-monitor\artifacts\bin\dotnet-monitor\Debug\netcoreapp3.1\

Are these logs in addition to the ones that ASP.NET is spewing straight to the console?

After this change, I don't see anything written directly to console. Before this change, I didn't see ASP.NET sending anything directly to console; it was our code that was writing directly to Console.Error when we couldn't bind an address.
If you saw something that is writing directly to console, could you send me the console output to me and I can take a look?

it was our code that was writing directly to Console.Error when we couldn't bind an address.

I think I was misinterpreting this code for something coming from ASP.NET.


Swap To Postgresql

Closes #353
Docker changes:
https://github.com/sublinks/sublinks-docker/tree/feature/api-353-swap-to-postgres

We can merge this in once the docker configuration supports it.

There seem to be a fair number of odd whitespace changes and some imports that aren't relevant.
It's not a huge deal, but it would be nice to clean those up.

I will wait and see if federation swaps over to postgresql too, just for organisational side.


Add LLVM/Clang 16.0.0

The new version is out: https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.0 and it would be great to have it available as well.

Support has been added, but they didn't release 16.0.0 for macOS so it won't work on that platform.

@KyleMayes yep, I noticed that. My guess is that they stopped producing binaries for Intel Macs altogether.
Thanks for a blazing fast response and a great action!


prisma dev: Improve rendering for small terminal windows

We could also enforce an absolute minimum size and render something along the lines of "Window not big enough" when it's too small.

Fixed in latest version. I added media queries for the UI and once the terminal window is smaller than a certain row count, it'll be scrollable.


Sort out BundlingSettings

@garrettjonesgoogle @davidtorres
From our meeting last Thursday, I think the decision was

These fields should be set and non-zero

elementCountThreshold
requestByteThreshold
delayThreshold

Delete the rest

I wanted to make sure I get it right to avoid code churn since this is tightly coupled with work in google-cloud-java.

SGTM

One more item needs to be supported: blocking call count threshold. With that added, LGTM.


After deploying on Netlify according to the tutorial, I can log in to the website, but there is no return value.

Describe the bug
没有返回值
Reproduction
没有返回值
System Info
没有返回值

Used Package Manager
npm
Validations

[x] Follow our Code of Conduct
[x] Read the Contributing Guide.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[x] The provided reproduction is a minimal reproducible of the bug.

Have you configured the environment variables?

是不是没有设置openai_api_key

If the request is stuck in pending, you can try regenerating the API key and redeploying.

i have the same situation.

If the request is stuck in pending, you can try regenerating the API key and redeploying.

I did as you said, but still not woking.

We've just added more detailed error message output. You should now be able to see the cause of the error in the UI.


Add ApiClientWrapper methods

tl;dr

Refactors our API Client Wrapper and moves it to its own module, with separate files for MLS and Identity methods
Adds new Identity methods
Adds mocks for Identity API and tests using those mocks

Notes

@insipx I borrowed some pieces of your pending PR that I needed here. Hopefully won't be too annoying with conflicts.
Right now I'm being strict with serialization errors. We should think through how we really want to behave once this goes to prod. One person's bad update shouldn't break the entire group. And we should make sure this is safe to add new features like one-way associations later (since those don't change commit processing).

Issues

https://github.com/xmtp/libxmtp/issues/629

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#668  👈
#667
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on  Graphite

Merge activity

Apr 17, 2:03 PM EDT: @neekolas started a stack merge that includes this pull request via Graphite.


Condense trkmcsim genealogy

@lborrel has seen that we duplicate SimParticle information in the EventNtuple trkmcsim branch. For example:
pdg: [11, 13, -211, 2212, 11, 11, 13, -211, 2212]
genID: [-1, -1, -1, 16, -1, -1, -1, -1, 16]
startCode: [166, 14, 101, 56, 17, 166, 14, 101, 56]

Shows two chains:

POT --> pion --> muon --> conversion electron
POT --> pion --> muon --> conversion electron --> secondary electron

These arise because both the conversion electron and secondary electron make hits that are used in the track fit. This duplication occurs because we use the following algorithm:

for each SimParticle that makes a hit, record its information as well as all the information for all of its ancestors

We should condense this information so that we don't duplicate SimParticle information.
A use case to keep in mind is when we have two real particles, whose hits are constructed as a single track. Then we would expect two distinct genealogies leading to two different POT in the same trkmcsim array

Hi @Andrew Edmonds @.***> , do you know if this issue
originates in EventNtuple or further upstream (SelectRecoMC)?
On Mon, Nov 18, 2024 at 10:46 AM Andrew Edmonds @.***>
wrote:

@lborrel https://github.com/lborrel has seen that we duplicate
SimParticle information in the EventNtuple trkmcsim branch. For example:
pdg: [11, 13, -211, 2212, 11, 11, 13, -211, 2212]
genID: [-1, -1, -1, 16, -1, -1, -1, -1, 16]
startCode: [166, 14, 101, 56, 17, 166, 14, 101, 56]
Shows two chains:

POT --> pion --> muon --> conversion electron
POT --> pion --> muon --> conversion electron --> secondary electron

These arise because both the conversion electron and secondary electron
make hits that are used in the track fit. This duplication occurs because
we use the following algorithm:

for each SimParticle that makes a hit, record its information as
well as all the information for all of its ancestors

We should condense this information so that we don't duplicate SimParticle
information.
A use case to keep in mind is when we have two real particles, whose hits
are constructed as a single track. Then we would expect two distinct
genealogies leading to two different POT in the same trkmcsim array
—
Reply to this email directly, view it on GitHub
https://github.com/Mu2e/EventNtuple/issues/229, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAH57YXEXGXGQUST2CH5CD2BIY2HAVCNFSM6AAAAABSAKH4B6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3DSNJQHEZDCNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
David Brown            @.***
Office Phone<PHONE_NUMBER>
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C)  Berkeley, CA 94720

Thanks Andy.
There's a similar problem with Mu2eEventDisplay in that, if 2 different
fits of the same track (muon and electron say) have the same MC truth th
MCTrajectory is drawn twice.
Does it make sense to have a common utility to compress the MC truth for
both tools?
On Mon, Nov 18, 2024 at 11:24 AM Andrew Edmonds @.***>
wrote:

Hi Dave - I'm pretty sure it's in EventNtuple code. We loop through the
SimParticles in kseedmc
https://github.com/Mu2e/EventNtuple/blob/182dbf87e72eee1acc78e108f68396b9f9e4fd7f/src/InfoMCStructHelper.cc#L182-L184
But then we add SimInfos all the way up the genealogy without checking
whether that specific SimParticle was already added
https://github.com/Mu2e/EventNtuple/blob/182dbf87e72eee1acc78e108f68396b9f9e4fd7f/src/InfoMCStructHelper.cc#L188-L192
—
Reply to this email directly, view it on GitHub
https://github.com/Mu2e/EventNtuple/issues/229#issuecomment-2483915608,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAH577BNNSOOFG42NLKKPL2BI5FNAVCNFSM6AAAAABSAKH4B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTHEYTKNRQHA
.
You are receiving this because you commented.Message ID:
@.***>

--
David Brown            @.***
Office Phone<PHONE_NUMBER>
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C)  Berkeley, CA 94720

So the EventNtuple duplication is more than just the fact we have different fit hypotheses for the same particle. To expand on the example in the first post, say our trk branch has two tracks: one for downstream e-minus and the other for downstream mu-minus. Our trkmcsim branch is a vector-of-vectors so will contain the genealogy for both tracks and each of those have duplicates:
trk: [ dem, dmm ]
trkmcsim.pdg: [ [11, 13, -211, 2212, 11, 11, 13, -211, 2212], [11, 13, -211, 2212, 11, 11, 13, -211, 2212] ]
trkmcsim.startCode: [ [166, 14, 101, 56, 17, 166, 14, 101, 56], [166, 14, 101, 56, 17, 166, 14, 101, 56] ]

So the condensing I'm proposing in this issue is for the inner-most vectors so that we would have:
trk: [ dem, dmm ]
trkmcsim.pdg: [ [11, 11, 13, -211, 2212], [11, 11, 13, -211, 2212] ]
trkmcsim.startCode: [ [17, 166, 14, 101, 56], [17, 166, 14, 101, 56] ]

We could go further and make trkmcsim a vector branch (rather than a vector-of-vector branch) but there are some leaves in trkmcsim such as nhits (the number of hits from that particle in the track) that could be different between the dem and dmm tracks
Certainly a common utility such as a module that checked dem and dmm tracks and removed the obviously worse one would be useful. (Although perhaps not... Having this problem in analyzer's faces means they won't overlook edge cases which a common utility couldn't decide between...)


dont error at deleted secrets

This PR fixes a bug were vkv would end with an error if a deleted secrets returns null.
fixes #62

Codecov Report

Merging #63 (c1f8b0a) into master (048b30b) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   77.33%   77.14%   -0.20%
==========================================
  Files           5        5
  Lines         406      407       +1
==========================================
  Hits          314      314
- Misses         61       62       +1
  Partials       31       31

Impacted Files
Coverage Δ

pkg/vault/vault.go
68.23% <0.00%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048b30b...c1f8b0a. Read the comment docs.


Fix for 'error while loading shared libraries: libsteam_api.so' | Fedora 32 and Manjaro

Description
After you add libsteam_api.so to the directory of the editor binary (as suggested on the GodotSteam site), the editor launches and you can also run your game from the project selector. However, once inside the editor, trying to launch the game (pressing F5 or otherwise) fails with

error while loading shared libraries: libsteam_api.so: cannot open shared object file: No such file or directory

It appears that this is due to the game trying to find libsteam_api.so somewhere other than where the editor is looking.
Fix
Fix tested on both Fedora 32 and Manjaro, however they differ so I'll include them both (both systems have Steam installed).
Manjaro - run sudo cp libsteam_api.so /usr/lib/
Fedora 32 - run  sudo cp libsteam_api.so /lib64/
from the directory where your library is located. The library needs to be in both the GodotSteam binary directory, as well as in the lib one. In order to find where the game might try look for the library on your system, you can use the ldd <bin path here> to find out. Then you can copy the libsteam_api.so there.

This is true and has come up in the past.  If I remember correctly this has something to do with how Steam installs on different Linux flavors.  Or, perhaps, by how Steam is installed.  This issue also seems to affect Steam generally on Linux and other non-Godot games.
That being said, thanks for writing this up!  I will add this to the documentation.

OK, that information has been added to a new Linux Caveats tutorial which outlines this conversation and some others about this particular issue.  It will also serve as a place to put further weird Linux quirks if/when we come across them.  You were also mentioned in the tutorial along with your suggested lines of code!  Thanks again!

Glad to help!

I know this issue is closed but you need your LD_LIBRARY_PATH to include the bin directory in your root godot folder.
Also, a better way than moving libsteam_api to your system library directories would be to move libsteam_api to your projects root directory.  Moving them system wide just screams for problems down the road after you've forgotten about it and no packages have tracked them going there.  However, using this script, you shouldn't need to move then anywhere.  Being in the bin directory and launching godot with this script should be enough.
This is the script I use to launch godot on GNU/Linux which is based on what Godot says about launching Godot on GNU/Linux in their documentation:
`#!/bin/bash
HELP_STRING="-v - Run Godot with the --verbose option."
verbose=""
while getopts hv flag
do
case "${flag}" in
h) help=
echo $HELP_STRING
exit
;;
v) verbose=--verbose;;
esac
done
export LD_LIBRARY_PATH="$PWD/bin/"
./bin/godot.x11.opt.tools.64 $verbose`
If I'm misreading this issue, sorry.

@nuggs You, sire, were not misreading the issue and this is the kind of script I was talking about... though I think I mention it in a related, yet different, thread.  Definitely bypasses the need to symlink or copy the libsteam_api into the system folders.  And the libsteam_api should always be in your project's root directory.  Which, I think and hope, is in the GodotSteam documentation.
Speaking of, do you mind if I include this script in the Linux Caveats tutorial?  With proper crediting to you, of course.
Ultimately it would be best if Valve could fix the Linux Steam installer to put the libsteam_api in the correct places every time but alas we must sometimes fall back to these measures.  On various installations, I have had everything work great 90% of the time with a few times having to resort to one of the methods discussed.

Go ahead and use the script, no credit is needed.  Only thing I did was add the verbose stuff.  Credit the Godot documentation.  :D

OK, I'll get it added; perhaps also as a download or something.  Well, I'll credit you and the Godot documentation.  Seems fitting.  Thanks again!


Use the faster whisper feature extractor in whisper pipelines

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Removed 2 failing tests that were not needed

I found tests that were failing because of removing func functionapp context from InitAction #143.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks @dariuszparzygnat


[IntelliJ Plugin] Add debugger adapter protocol support

Purpose
This PR introduces DAP(Debugger Adapter Protocol) based ballerina debugging support for ballerina IntelliJ IDEA plugin.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[x] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #16980 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #16980   +/-   ##
=======================================
  Coverage   68.85%   68.85%
=======================================
  Files           5        5
  Lines         122      122
  Branches       21       21
=======================================
  Hits           84       84
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2508bf9...3deadfb. Read the comment docs.


Add ability to expand logs request when listening

From BETA user:

“Start API logs streaming” could be much more than a wrapper for stripe logs tail. It would be cool if I could expand each request to see its parameters.

We should probably avoid showing more request logs data than what we currently display. There is a high risk of accidentally leaking PII if we show API request params and response bodies. I think a reasonable tradeoff would be to link to the dashboard like the CLI does, even though it's not the most seamless experience.

Closing. We added links to the dashboard instead of showing logs inside the editor.


Pin karma, karma-mocha dev dependencies

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          18     18
=====================================
  Hits           18     18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760a0ab...f235e99. Read the comment docs.


SonarQube service tests failing

:clock11: When did the problem start?
~October 18th

:camera: Live badge

https://img.shields.io/sonar/coverage/swellaby:letra?server=https%3A%2F%2Fsonarcloud.io

:wrench: Is the live badge working?
Yes, there's no issue with the badges, just with the target SonarQube instance a subset of the services tests were using

:link: CircleCI link
https://circleci.com/gh/badges/daily-tests/672

:beetle: Stack trace
SonarCoverage [live] Coverage [ GET /org.ow2.petals%3Apetals-se-ase.json?server=http://sonar.petalslink.com ]
  ValidationError: message mismatch: "value" with value "inaccessible" fails to match the required pattern: /^[1-9][0-9]?%|^100%|^0%$/

:bulb: Possible solution
For context (especially for those not familiar with Sonar), Sonar is available in two modes: the SaaS/cloud mode (referred to as SonarCloud - https://sonarcloud.io) and the download/self-host mode (referred to as SonarQube - https://www.sonarqube.org/downloads/); note that SonarCloud is the same thing, just as a SaaS offering of Sonar that uses the latest-and-greatest version. The current/latest version of SonarQube is 8.0.
Several years ago there was a major API contract change in SonarQube with the release of version 5.4. Shields supports providing badges for both legacy and modern Sonar versions: the sonar badges accept an optional query param sonarVersion to allow users to indicate they have a "legacy" (pre v5.4) SonarQube instance. If that query param is provided to Shields then Shields will use the legacy API, otherwise Shields will use the "modern" API (Sonar 5.4+).
As such, we've historically had service tests for our Sonar badges that cover both cases. We have service tests that are targeting the SonarCloud instance (latest/modern API) as well as service tests that are targeting a self-hosted SonarQube instance that was the legacy <5.4 version.
The legacy SonarQube instance used in those service tests is http://sonar.petalslink.com/ which has been offline the last few days thus resulting in our failed service tests.
One option for us is to wait to see if http://sonar.petalslink.com/ comes back online (I suppose we could also try to get in contact with them, but I'm not really sure how to best do so)
Another option, and the one I'd suggest, is that we remove the subset of our service tests for the Sonar badges that are targeting that legacy SonarQube instance. The main purpose of our service tests is to validate our integrations with external services and to catch upstream changes quickly. However, that's not relevant IMO for SonarQube <= v5.4; it's a package/released version of software from several years ago, not a live service that can be changed by the vendor at will. The API contracts for those older SonarQube instances cannot change. The service tests for the legacy API will only ever fail if the target instance is offline.
The service tests we have that are targeting SonarCloud will cover the integration we have with that service that can change, and we can replace the service tests targeting the legacy-api endpoint with unit tests to validate any legacy-api specific logic (i.e. transform).
Thoughts?

If http://sonar.petalslink.com/ doesn't come back online and there isn't another obvious public instance running the old version, we could switch the legacy sonar tests to use mocked responses.

If http://sonar.petalslink.com/ doesn't come back online and there isn't another obvious public instance running the old version, we could switch the legacy sonar tests to use mocked responses.

SGTM. It's been about a week and it's still not back online, so I've opened #4251 with an update to mock those service tests. Ever since the SaaS SonarCloud service was launched in ~June 2017, I think it's become far less common for folks to self-host their own SonarQube instance on a server.
As such I'm highly skeptical that we'll find a publicly accessible, self-hosted SonarQube instance that is 3+ major versions old (which we'd need for those tests), so I'd prefer to just get these service tests passing again


Update FormatStringContinuation to use the new f-string tokens

The FormatStringContinuation implementation uses the full lexer for comment handling. It expects only a limited set of tokens (String, Newline, NonLogicalNewline, Comment, Indent, Dedent) which is expected given that the lexing is performed only on the string literals.
Now, with PEP 701, the f-string literal will instead emit FStringStart, FStringMiddle, and FStringEnd. Not only that, it'll also emit other tokens for the expression part of the f-string. This poses a challenge as currently it panics for any unexpected token encountered:
https://github.com/astral-sh/ruff/blob/4ae463d04bb65a39aa8af8fa12523cfda04a5d9f/crates/ruff_python_formatter/src/expression/string.rs#L277

Is this blocking for landing PEP701?

It's one of the failing test in the CI: https://github.com/astral-sh/ruff/actions/runs/6236001637/job/16926357093?pr=7376#step:7:2341
It shouldn't block Ruff in general but the formatter will panic when a f-string is encountered in implicit string concatenation with comments in it. For example,
foo = (
    f"bar"
    # comment
    "foo"
)

I've started looking into it. A basic implementation of using the outermost f-string range and ignoring all tokens within a f-string works but I'll look at if there are any other cases which may break this.

Currently, this is completed in a way so as to not block merging PEP 701. Tracking issue for handling comments and quotes in f-string is at #7594


Newsweek clone

This is a clone of the home page of the newsweek.
It was styled majorly using bootstrap framework and little css and media queries to give it maximum responsiveness.

Pull request currently under review by Michgolden Ukeje (TSE).
Kindly exercise patience 👋


More flexibility for V-SENSOR-I2C

There are four connectors which allow remote sensors to be connected via I2C (J2, J6, J7, J8).  Each of these connectors includes a power pin connected to net V-SENSOR-I2C.  That net can carry either 3.3v or 5v power depending on how resistors are populated.
It would be more flexible to allow the power to each of these connectors to be individually selected rather then force the same power level on all four connectors.  This would allow for more flexibility in what remote sensors can be accommodated.
Replicating the zero Ohm resistors R1 and R2 for each I2C connector would accomplish this.

pullups need to be switched too but we can do this

implemented as described

Confirmed


fix scalapack dependency

Merge upstream changes
https://github.com/spack/spack/pull/39109

Builds are failing due to spack errors


Feature request. Terminal toggle from vs code command pallets.

Can you add a toggle switch in the vs code command pallete (ctrl+shift+p) , that switches between run in external terminal, and run in vs code terminal settings.

Its because of the checks which are being done when the extension loads I am working on it right now. It will be fixed till next week.

Hey do you think you can tell me how i can run java files, with external libraries. Using this extension. I am using the basic java extension recommended by microsoft to run java code.  Then i add the library file to the referenced libraries folder (from java projects). My question is since i am doing all this , and running the file using this terminal extension, does it remember that i imported a library jar file, using the java projects section.
I do not incur this problem with python, since in python i can just setup up environment variables.

There is no functionality to Dynamically run External Libraries with Code Builder as of now.


App Configuration Feature Management - Feature Variants

Description
Updates Feature Management to support Feature Variants
All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
spring-cloud-azure-feature-management

Do we need to update the README.md file?


Suggestion : add link to elm-live in README.md

Thank you for the koans! A suggestion : add a link to elm-live in the README. Using elm-live makes for a much more fluid experience thanks to the automatic reloading.

Thank you for the suggestion @mlevesquedion! I just updated the README in https://github.com/robertjlooby/elm-koans/commit/8c1785d4a4a1fd6d45815fa9818e6a715c7070c4.