No test status when TEST_SKIP in case of InitCL

Hi
I see truncated log from test binary in case of cases for OpenCL 2.X and executed on platform OpenCL 1.X
example:
test_device_timer.exe  Initializing random seed to 0. Requesting Default device based on command line for platform index 0 and device index 0 Compute Device Name = Intel(R) UHD Graphics 605, Compute Device Vendor = Intel(R) Corporation, Compute Device Version = OpenCL 1.2 NEO , CL C Version = OpenCL C 1.2 Supports single precision denormals: YES sizeof( void*) = 8  (host) sizeof( void*) = 4  (device)
This situation is related with PR #628
We should print something on output in situation of return TEST_SKIP;
However I am wondering how and what . The problem is that we do not reach calling function https://github.com/KhronosGroup/OpenCL-CTS/blob/master/test_common/harness/testHarness.cpp#L471
where print_results function is called.
Do you have any suggestion what should be printed in case of
this skip:
https://github.com/KhronosGroup/OpenCL-CTS/blob/master/test_conformance/device_timer/main.cpp#L41
and this:
https://github.com/KhronosGroup/OpenCL-CTS/blob/master/test_conformance/device_timer/main.cpp#L62

I agree we should do something there. This also relates to https://github.com/KhronosGroup/OpenCL-CTS/issues/617.
Instead of exiting on https://github.com/KhronosGroup/OpenCL-CTS/blob/master/test_common/harness/testHarness.cpp#L452 we could just remember an exit code (or lack of need to exit) and have a bit of code to handle that case after the block that currently deals with the return from deviceCheckFn. We know the total number of tests so we could report FAILED x of x tests or SKIPPED x of x tests.

ok I understand then I think we should move deviceCheckFn inside the parseAndCallCommandLineTests rigth ?

I don't think that's necessary just now. We're probably going to need it for https://github.com/KhronosGroup/OpenCL-CTS/issues/617 though.

Without calling parseAndCallCommandLineTests we will be always skip and exit on the first test case in the test_list. Are you ok with this ?

Not sure I'm following, deviceCheckFn controls the execution of all the tests in a given suite.

Then ok. My proposal:
test_device_timer.exe *
Initializing random seed to 0.
Requesting Default device based on command line for platform index 0 and device index 0
Compute Device Name = Intel(R) UHD Graphics 605, Compute Device Vendor = Intel(R) Corporation, Compute Device Version = OpenCL 1.2 NEO , CL C Version = OpenCL C 1.2
Supports single precision denormals: YES
sizeof( void*) = 8  (host)
sizeof( void*) = 4  (device)
Test skipped (requires at least version 2.1, but the device reports version 1.2)  message printed from the main.cpp of the test case
Test skipped while initialization message printed from test harness
PASSED test.

I've pushed out proposal. I this will be accepted I will modify other tests accordingly .
What I see:
There is a need in tests with InitCL cleanup tabs to spaces
More tests need add minimum version 2.0


Error with using redis and cloud-trace-nodejs

My env:

OS: containered node:12.8.0-alpine

Redis version: Google Cloud Platform Memorystore Redis 6.x

NodeJS version: 12.8.0

NPM version: 7.24.0

Package.json:

@google-cloud/trace-agent: "^5.1.6" (also tested on 5.1.3)
redis: "^4.0.0"

How I init cloud-trace:
if (env.NODE_ENV === 'production') {
  const serviceContext = {
    service: pkg.name,
    version: pkg.version,
  }
  require('@google-cloud/trace-agent').start({ serviceContext })
  require('@google-cloud/debug-agent').start({ serviceContext })
}

After container started I see this error:
TypeError: Cannot read property 'prototype' of undefined
    at wrapCreateStream (/var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/plugins/plugin-redis.js:145:36)
    at Object.patch (/var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/plugins/plugin-redis.js:167:13)
    at /var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/trace-plugin-loader.js:93:23
    at Array.reduce (<anonymous>)
    at ModulePluginWrapper.applyPlugin (/var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/trace-plugin-loader.js:87:33)
    at /var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/trace-plugin-loader.js:278:64
    at Module.Hook._require.Module.require (/var/lib/__HIDDEN__/node_modules/require-in-the-middle/index.js:154:32)
    at require (internal/modules/cjs/helpers.js:68:18)
    at Object.<anonymous> (/var/lib/__HIDDEN__/service/redis.js:2:26)
    at Module._compile (internal/modules/cjs/loader.js:868:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:879:10)
    at Module.load (internal/modules/cjs/loader.js:731:32)
    at Function.Module._load (internal/modules/cjs/loader.js:644:12)
    at Module.require (internal/modules/cjs/loader.js:771:19)
    at Module.Hook._require.Module.require (/var/lib/__HIDDEN__/node_modules/require-in-the-middle/index.js:80:39)
    at require (internal/modules/cjs/helpers.js:68:18)
/var/lib/__HIDDEN__/node_modules/@google-cloud/trace-agent/build/src/plugins/plugin-redis.js:145
    shimmer.wrap(redis.RedisClient.prototype, 'create_stream', createCreateStreamWrap(api));

Questions:

How can I disable redis plugin for cloud-trace-agent?
Can you update the redis-plugin to support latest version of Redis and redis lib?

Hey team. Do you need any additional information from me?

Sorry for the delay in responding...
In terms of disabling the plugin, this can be done from the config:
https://github.com/googleapis/cloud-trace-nodejs/blob/d5c7cfdefd47cf14d09668b3ee4f5d6e2d62f19f/src/config.ts#L171
  /**
   * A list of trace plugins to load. Each field's key in this object is the
   * name of the module to trace, and its value is the require-friendly path
   * to the plugin. (See the default configuration below for examples.)
   * Any user-provided value will be used to extend its default value.
   * To disable a plugin in this list, you may override its path with a falsy
   * value. Disabling any of the default plugins may cause unwanted behavior,
   * so use caution.
   */
  plugins?: {[pluginName: string]: string};

Further down in that same file, you can see the defaultConfig:
export const defaultConfig = {
   // ...
   plugins: {
     // ...
     redis: path.join(pluginDirectory, 'plugin-redis.js')
     // ...
   }
   // ...
}

The request to fix this (and support the latest Redis) is reasonable, but I unfortunately cannot commit to any timeline here due to team capacity constraints. Our team can commit to reviewing pull requests, however. If that is not an option and if this is really, really important to you, escalating this through Cloud Support may help in terms of staffing and prioritization at a higher level.

We'll ensure that cloud-trace-nodejs won't error out when used in conjunction with redis v4+. However, we aren't able to prioritize building actual instrumentation support for redis v4+ at this time. Please consider using @opentelemetry/instrumentation-redis-4 instead.


Fullscreen does not go over task bars on top and left on Ubuntu 16.04

Fullscreen does not go over task bars on top and left on Ubuntu 16.04, SFML 2.4.1.
YouTube's and other games' fullscreen modes work normally.
Here is a screenshot of it.
Here is the minimal code:
#include <SFML/Graphics.hpp>

int main (int argc, char* argv[]) {
    sf::RenderWindow window(sf::VideoMode(1920, 1080), "Window", sf::Style::Fullscreen);

    while (window.isOpen()) {
        sf::Event event;
        while (window.pollEvent(event)) {
            switch(event.type) {
                case sf::Event::Closed:
                    window.close();
                    break;
            }
        }

        window.clear();
        window.display();
    }

    return 0;
}

Always thought this is the expected behavior on Unity, although I might be wrong. Only using Linux for occasional test builds, no full time user here.

YouTube's and other games' fullscreen modes work normally like in Windows though.

Okay, then this should probably be changed. By someone actually knowing X11 * shudder *. Any volunteers?

This is very critical for my game. Performance is very poor at windowed mode so fullscreen is a must. Can anyone help with this?

Tried and clearly too much X11/XRandR shenanigans going on for my likings. It seems like we'd have to use XRandR 1.2 and newer the way described here.

I just tested @bloodsword 's commit, it fixes the issue. Please add this.

Wow! This is a clear reason to NOT use SFML in my current project

This fixes the issue for me.  Tested on Ubuntu 16.04.5 (Unity) in Virtualbox.

Using latest version on master (5e10e1f0c9b0a5c095df0f8e9be96914f75297d0), fullscreen takes up the entire monitor as expected.
I chose a build a few commits before the latest master (be3556d76ab956bab63d96b1d117546e6bf9897e) and was able to replicate the issue, fullscreen did not cover the top bar / side bar.

Thanks, forgot to close it this after the merge. 🙂


support acks?

server 0.8.3 is expected to raise an exception on ProduceRequests with ack>1 . See KAFKA-1697
kafka-python should update interface, code, and docs to reflect the new approach to produce request "acks".

I think this is already filed as issue #294 .  please reopen if you disagree!


Improved testing matrix.

This is a rehash of my older testing infrastructure "upgrade" that we reverted soon after. I think this is actually an upgrade this time :-).
This is allows us to spin up new testing nodes quickly when our queue times get long.
I left placeholders for temporarily disabled CUDA 10.1+ tests until we can specify constraints to farm tasks based on the available hardware and drivers.

This was brought in through the sparse attention release #342 . Closing.


Auto Activation of the Email Account, once the user verifies his/her email address

I am a GSSOC'21 Participant and I would like to work upon automating the Account Activation process which is dependent on Admin for the moment. Once the User verifies his/her email address, their account would be activated.

Okay

Should I change the prompt "Now contact your organization head for account activation!" after the user signs up successfully to "Now verify your email address to activate your account"?

Should I change the prompt "Now contact your organization head for account activation!" after the user signs up successfully to "Now verify your email address to activate your account"?

Yes


Falco build for ARM armv7 armv6

Adding some files to the build dir to make it easier to build Falco.
Right now checking out the repository on Linux is a bit confusing.
Now the cmake flags are defined in a convenience scripts /build/init.sh
So they can be easily switched while building.
Note that the true changes needed were mostly cosmetic and related to dependencies with Falco.
If you are using the Sysdig driver with Falco and would like to run Falco on a Raspberry Pi or another similar arm chip you will need to do a few things
Ensure Linux Headers
Ensure you have the linux headers specific for your machine installed for the same kernel version you are using. For instance if you are running arch linux on ARM running on a Raspberry Pi 4 you are giving a few options.
[novix@novix build]$ pacaur -S linux-headers
:: There are 16 providers available for linux-headers:
:: Repository core
   1) linux-am33x-headers  2) linux-armv7-headers  3) linux-armv7-rc-headers  4) linux-clearfog-headers  5) linux-cubox-headers
   6) linux-headers-odroid  7) linux-headers-utilite-dt  8) linux-imx6-headers  9) linux-odroid-c1-headers  10) linux-odroid-xu3-headers
   11) linux-peach-headers  12) linux-raspberrypi-headers  13) linux-raspberrypi4-headers  14) linux-utilite-headers
   15) linux-veyron-headers  16) linux-zedboard-headers

I am running a raspberry pi 4, so I used 13). Use your best judgement here, and feel free to try other potential candidates if things aren't working well or are compiling to the wrong arch (for instance 12) compiles Falco for armv6 wheras 13) compiles falco for armv7.
Use lscpu to find out what chip you have.
Use the patched libsinsp
I opened up a PR here https://github.com/draios/sysdig/pull/1622 with changes for ARM. If you are trying to build this before that patch is merged you can manually make the change in falco/build/sysdig-repo/sysdig-prefix/src/sysdig/userspace/libsinsp/cgroup_limits.cpp
cd falco
emacs build/sysdig-repo/sysdig-prefix/src/sysdig/userspace/libsinsp/cgroup_limits.cpp

and change
constexpr const int64_t CGROUP_VAL_MAX = (1ULL << 42u) - 1;

Use the following cmake flags in the init.sh script in this PR
#!/bin/bash
#
# Copyright (C) 2019 The Falco Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
#

# @kris-nova We have experimental support for ARM and I have tested
# on armv7. Please use this flag as experimental only.
BUILD_ARM=true

cmake ../ \
      -DBUILD_BPF=OFF \
      -DBUILD_WARNINGS_AS_ERRORS="OFF" \
      -DCMAKE_BUILD_TYPE="debug" \
      -DCMAKE_INSTALL_PREFIX="/usr" \
      -DDRAIOS_DEBUG_FLAGS="-D_DEBUG" \
      -DFALCO_ETC_DIR="/etc/falco" \
      -DUSE_BUNDLED_DEPS=OFF

if [ BUILD_ARM ]; then
   driver_config="./driver/src/driver_config.h"
   if ! grep -q "CONFIG_ARM" $driver_config; then
       printf "\n#define CONFIG_ARM\n\n" >> $driver_config
   fi
fi

Signed-off-by: Kris Nova<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #520
Fixes #586
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Adding support for arm architecture for armv6 and armv7 chips (Tested with Raspberry Pi 3/4)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kris-nova
You can assign the PR to them by writing /assign @kris-nova in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please don't merge until I finish working on this - still a WIP

Tested and working with the patch highlighted above on

Raspberry Pi 1B (armv6)
Raspberry Pi 3 (armv7)
Raspberry Pi 4 (armv7)

I will cut a release of the version of arch linux I am using to do this that has all the dependencies dialed in.

/hold

Get out of here with your /hold

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b1f9132 Update build/init.sh

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b1f9132 Update build/init.sh
24899a7 Update build/init.sh

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closing this as I have discovered another 32 bit division issue that will be addressed in another PR

I'm interested in this use-case
This is how far I got compiling on ARM64 with Ubuntu 20 on my RPi4. I'd expect similar errors on AWS instances or on Packet.
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/filtered_re2.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/mimics_pcre.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/nfa.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/onepass.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/parse.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/perl_groups.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/prefilter.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/prefilter_tree.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/prog.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/re2.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/regexp.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/set.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/simplify.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/stringpiece.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/tostring.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/unicode_casefold.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/re2/unicode_groups.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/util/pcre.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/util/rune.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/re2/util/strutil.o
[C]       Compiling third_party/upb/upb/decode.c
[C]       Compiling third_party/upb/upb/encode.c
[C]       Compiling third_party/upb/upb/msg.c
[C]       Compiling third_party/upb/upb/port.c
[C]       Compiling third_party/upb/upb/table.c
[C]       Compiling third_party/upb/upb/upb.c
[AR]      Creating /home/ubuntu/falco/grpc-prefix/src/grpc/libs/opt/libupb.a
ar: creating /home/ubuntu/falco/grpc-prefix/src/grpc/libs/opt/libupb.a
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/decode.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/encode.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/msg.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/port.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/table.o
a - /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/upb/upb/upb.o
[CXX]     Compiling third_party/abseil-cpp/absl/base/dynamic_annotations.cc
c++: error: unrecognized command line option ‘-maes’
c++: error: unrecognized command line option ‘-msse4’
make[4]: *** [Makefile:2968: /home/ubuntu/falco/grpc-prefix/src/grpc/objs/opt/third_party/abseil-cpp/absl/base/dynamic_annotations.o] Error 1
make[3]: *** [CMakeFiles/grpc.dir/build.make:113: grpc-prefix/src/grpc-stamp/grpc-build] Error 2
make[2]: *** [CMakeFiles/Makefile2:848: CMakeFiles/grpc.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:6062: userspace/falco/CMakeFiles/falco.dir/rule] Error 2
make: *** [Makefile:2643: falco] Error 2
ubuntu@ubuntu:~/falco$ uname -a
Linux ubuntu 5.4.0-1015-raspi #15-Ubuntu SMP Fri Jul 10 05:34:24 UTC 2020 aarch64 aarch64 aarch64 GNU/Linux
ubuntu@ubuntu:~/falco$
[1] 0:bash*


Problems running scDALI-Het/Hom

Hello, I am trying to run scDALI on my data. I can run scDALI-Joint without any problems but when I try to run either scDALI-Het or scDALI-Hom I get some errors, even though is the same line of code (I only remove base_rate or cell_states depending on the mode).
This is the error that I get for scDALI-Het:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-48-8ea9456083cd> in <module>()
      1 res = run_tests(A = A.transpose(),D = D.transpose() , model = 'scDALI-Het',
----> 2                 cell_state = cell_states)

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/run_scdali_tests.py in run_tests(A, D, model, X, cell_state, return_rho, base_rate, n_cores)
    108             f,
    109             mat_dict={'A':A, 'D':D},
--> 110             n_cores=n_cores)
    111
    112     out = dict()

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/utils/parallel.py in process_parallel(fun_sequential, mat_dict, n_cores, verbose, show_progress)
     53     if n_cores==1:
     54         # don't invoke joblib
---> 55         results = fun_sequential(**mat_dict)
     56     else:
     57         blocks = np.linspace(0, n_cols, n_cores + 1).astype(int)

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/utils/run_model.py in run_model(model, A, D, init_kwargs, fit_kwargs, callbacks, show_progress, verbose)
     54
     55         # fit model
---> 56         mod.fit(**fit_kwargs)
     57
     58         # run callbacks on fitted model

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/models/glmm.py in fit(self, maxiter, tol)
    127         if self.X is not None:
    128             self.Lh = cho_factor(
--> 129                 (self.W0 * self.X).T @ self.X + JITTER * np.eye(self.X.shape[1]))
    130
    131

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scipy/linalg/decomp_cholesky.py in cho_factor(a, lower, overwrite_a, check_finite)
    151     """
    152     c, lower = _cholesky(a, lower=lower, overwrite_a=overwrite_a, clean=False,
--> 153                          check_finite=check_finite)
    154     return c, lower
    155

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scipy/linalg/decomp_cholesky.py in _cholesky(a, lower, overwrite_a, clean, check_finite)
     25     if a1.shape[0] != a1.shape[1]:
     26         raise ValueError('Input array is expected to be square but has '
---> 27                          'the shape: {}.'.format(a1.shape))
     28
     29     # Quick return for square empty array

ValueError: Input array is expected to be square but has the shape: (8, 1).

And this is the error that I get with scDALI-Hom:

---------------------------------------------------------------------------
SystemExit                                Traceback (most recent call last)
<ipython-input-52-318a46fce7e4> in <module>()
----> 1 res = run_tests(A = A.transpose(),D = D.transpose() , model = 'scDALI-Hom', base_rate = 0.025)

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/run_scdali_tests.py in run_tests(A, D, model, X, cell_state, return_rho, base_rate, n_cores)
    108             f,
    109             mat_dict={'A':A, 'D':D},
--> 110             n_cores=n_cores)
    111
    112     out = dict()

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/utils/parallel.py in process_parallel(fun_sequential, mat_dict, n_cores, verbose, show_progress)
     53     if n_cores==1:
     54         # don't invoke joblib
---> 55         results = fun_sequential(**mat_dict)
     56     else:
     57         blocks = np.linspace(0, n_cols, n_cores + 1).astype(int)

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/utils/run_model.py in run_model(model, A, D, init_kwargs, fit_kwargs, callbacks, show_progress, verbose)
     59         region_results = list()
     60         for cb in callbacks:
---> 61             region_results.append(cb(mod))
     62         results.append(region_results)
     63     return results

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/utils/run_model.py in callback_method(model)
     82     """
     83     def callback_method(model):
---> 84         return getattr(model, method_name)(**kwargs)
     85     return callback_method
     86

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/models/glmm.py in test(self, return_rho)
    148         if len(self.rhos) == 1:
    149             # approximate null distribution using Davies method
--> 150             pvalue = davies_pval(Q_rho[0], Fs[0])
    151             if return_rho:
    152                 return pvalue, self.rhos[0]

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/scdali/models/glmm.py in davies_pval(Q, F)
    351     """Wrapper around davies_pvalue that catches AssertionError."""
    352     try:
--> 353         pval = davies_pvalue(Q, F)
    354     except AssertionError:
    355         print('Warning - Davies pvalue assertion error: zero p-value')

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/chiscore/_davies.py in davies_pvalue(q, w, return_info)
     32         w = w / maxq
     33
---> 34     re = _pvalue_lambda(_lambda(w), q)
     35     if return_info:
     36         return re["p_value"][0], re

/software/teamtrynka/conda/sex_diff_upgrade/lib/python3.6/site-packages/chiscore/_davies.py in _lambda(K)
    102
    103     if len(idx2) == 0:
--> 104         sys.exit("No Eigenvalue is bigger than 0!!")
    105     return lambda1[idx2]
    106

SystemExit: No Eigenvalue is bigger than 0!!

Thanks!

Hey! Following up on this, I am having the same issue with scDALI-Het, it fails about half way through.


[HOPPER] enable flash attention with tma

I am trying to figure out why in a compute ability of 8.0 card, loading data of shape :
Q : D0, BLOCK_DMODEL, Row Major
K : D0, BLOCK_DMODEL, Row Major
V : D0, BLOCK_DMODEL, Row major

is faster in V2 attention attention + memory efficient attention algorithm
https://github.com/openai/triton/pull/3321


wxSVG: 1.5.11 -> 1.5.13

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 1.5.13 with grep in /nix/store/hcf1ibw1hvrwic1zagy3cvi1fc73rfgk-wxSVG-1.5.13
found 1.5.13 in filename of file in /nix/store/hcf1ibw1hvrwic1zagy3cvi1fc73rfgk-wxSVG-1.5.13

cc @AndersonTorres for review

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘wxSVG-1.5.13’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/wxSVG/default.nix:24 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13
shrinking /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13/bin/svgview
shrinking /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13/lib/libwxsvg.so.3.10.5
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13/lib  /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13/bin
patching script interpreter paths in /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13
checking for references to /tmp/nix-build-wxSVG-1.5.13.drv-0 in /nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13...
/nix/store/bx6ngfgmncjjv3m91h1d950qvwb902kl-wxSVG-1.5.13

Success on aarch64-linux (full log)
Partial log (click to expand)
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13
shrinking /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13/bin/svgview
shrinking /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13/lib/libwxsvg.so.3.10.5
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13/lib  /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13/bin
patching script interpreter paths in /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13
checking for references to /build in /nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13...
/nix/store/lzhjgkhz6zk3fxa2ipw6r5j27ra1093a-wxSVG-1.5.13


[task] to resolve aurelia-binding v2/v1 duplication in webpack/jspm bundles

Originated from https://github.com/aurelia/templating/issues/575#issuecomment-407920042
Previously @EisenbergEffect released new parser in aurelia-binding v2 to make it a safe opt-in. But since then, aurelia core libs have been updated to depend on v2.
But if you have some 3rd party plugin (very likely) still asks aurelia-binding ^1.x.x in the package.json, you end up with 2 versions of binding in your node_modules (one direct, another one under the plugin folder).
webpack tries to respect the plugin's dependency, hence bundled 2 versions of aurelia-binding.
The end result is all sorts of weird bugs. The first thing you can notice is the repeat.for creates extra entry on array push. Due to Array.prototype.push has been patched twice.
To solve the problem, based on the audit result of all packages depends on aurelia-binding
Core packages (7) all on ^2.0.0
aurelia-framework
aurelia-i18n
aurelia-templating
aurelia-templating-binding
aurelia-templating-resources
aurelia-templating-router
aurelia-validation

Non-core (7) but on ^2.x.x
aurelia/ux ^2.0.0
aurelia/ui-virtualization ^2.0.0
aurelia-contrib/aurelia-typed-observable-plugin ^2.0.0
bigopon/aurelia-portal-attribute ^2.0.0
bigopon/aurelia-blur-attribute ^2.0.0
zewa666/aurelia-async-binding ^2.1.2
aurelia-ui-toolkits/aurelia-kendoui-bridge ^2.1.1

Non-core (45) on ^1.x.x
Vheissu/aurelia-typescript-plugin ^1.5.0
redeyeapps/aurelia-redeye-design ^1.5.0
aurelia-plugins/aurelia-plugins-password-viewer ^1.7.1
Foursails/aurelia-plus ^1.5.0
aurelia-ui-toolkits/aurelia-syncfusion-bridge ^1.0.4
dtaalbers/au-datatable ^1.2.1
Vheissu/aurelia-google-maps ^1.6.0
ne0guille/aurelia-plugins-google-places-autocomplete ^1.0.9
sketch7/ssv-au-ui ^1.3.0
SpoonX/aurelia-datatable-export ^1.0.0
SpoonX/aurelia-datatable ^1.0.0
heruan/aurelia-persistence ^1.2.1
MeirionHughes/aurelia-template-lint ^1.0.0
aurelia/template-lint ^1.0.0
jdanyow/aurelia-breeze ^1.0.0-rc.1.0.0
Nexbit/aurelia-slideout ^1.0.4
Vheissu/aurelia-modal ^1.0.1
jdanyow/aurelia-computed ^1.0.0-rc.1.0.0
niieani/aurelia-binding-functions ^1.0.0-beta.1.3.0
jdanyow/aurelia-async ^1.0.0-beta.1
Vheissu/aurelia-tabs ^1.0.1
SpoonX/aurelia-pager ^1.0.0
aurelia-plugins/aurelia-plugins-google-places-autocomplete ^1.7.1
aurelia-plugins/aurelia-plugins-google-maps ^1.7.1
heruan/aurelia-components ^1.2.1
Vheissu/aurelia-configuration ^1.6.0
aurelia-contrib/aurelia-knockout ^1.0.0
SpoonX/aurelia-orm ^1.0.0
sidloki/aurelia-onsenui ^1.2.1
justindra/aurelia-facebook-sdk ^1.2.0
aurelia-contrib/aurelia-knockout ^1.0.0
niggoo/aurelia-notifications ^1.2.1
mariaantony-gnanasekaran/aurelia-syncfusion-bridge ^1.0.4
writelinez/aurelia-tinymce ^1.5.0
titou-from-mars/aurelia-tinymce-wrapper ^1.5.0
aurelia-plugins/aurelia-plugins-pagination ^1.7.1
aurelia-plugins/aurelia-plugins-google-recaptcha ^1.7.1
aurelia-plugins/aurelia-plugins-google-places-autocomplete ^1.7.1
aurelia-contrib/aurelia-dynamic-html ^1.0.0
froala/aurelia-froala-editor ^1.0.0
formio/aurelia-formio ^1.5.0

// missing source repo:
aurelia-material-ui ^1.2.1
ferngully-aurelia-tools ^1.0.1
aurelia-froala ^1.0.0-beta.1.0.1
aegis-aurelia-knockout ^1.2.1

release aurelia-binding v1.8.0, make sure it's tagged as latest on npmjs registry.
update all core packages (7) back to "aurelia-binding": "^1.0.0".
reach out to all non-core (7) but on ^2.0.0, to update them back to "aurelia-binding": "^1.0.0".

note most of them are controlled by core team member.

update cli to use https://github.com/darrenscerri/duplicate-package-checker-webpack-plugin

this warns user about duplicated packages.

Note: updating core packages back to "^1.0.0 | ^2.0.0" doesn't solve everything, as you need to ask the same for non-core (7) but on ^2.0.0. So why not just upgrade all of them back to ^1.0.0 to simplify dependency.

Temporary solution: Update webpack.config.js using alias to force one version of binding
module.exports = ({production, server, extractCss, coverage, analyze} = {}) => ({
  resolve: {
    extensions: ['.js'],
    modules: [srcDir, 'node_modules'],

// add alias for aurelia-binding
    alias: {
      'aurelia-binding': path.resolve(__dirname, 'node_modules/aurelia-binding')
    }
  },


Crop for animated images

currently the animated images resize work well, see:
http://localhost:8080/example.gif?x-amz-process=image/resize,w_200

But it doesn't work for crop or fill mode resize.
http://localhost:8080/example.gif?x-amz-process=image/resize,w_200,h_200,m_fill

related issue https://github.com/libvips/libvips/issues/2668

related issue :

https://github.com/imagecodex/govips/pull/9
https://github.com/imagecodex/imagecloud/pull/23


Flutter gives enable by default notification for ios and its quite

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I am creating a new app on latest flutter. What I noticed for ios suddenly the notification is enabled by default and its quite. In my earlier app this was not the case where I set the permission handler.
Expected results
We expected that by default the notification is not enabled for ios.
Actual results
The actual results now is that for ios notification is enabled and is set as quite. So is there any changes to the latest flutter sdk causing this ? Because recently I have updated the sdk.
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(

        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {

      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(

        backgroundColor: Theme.of(context).colorScheme.inversePrimary,

        title: Text(widget.title),
      ),
      body: Center(

        child: Column(

          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
[✓] Flutter (Channel master, 3.11.0-11.0.pre.3, on macOS 13.3.1 22E772610a darwin-arm64, locale en-MY)
• Flutter version 3.11.0-11.0.pre.3 on channel master at /Users/ss/Development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision ab573048e7 (12 days ago), 2023-05-20 11:32:26 -0400
• Engine revision aac0919568
• Dart version 3.1.0 (build 3.1.0-129.0.dev)
• DevTools version 2.23.1
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/ss/Library/Android/sdk
• Platform android-33, build-tools 31.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E222b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
[✓] VS Code (version 1.78.2)
• VS Code at /Users/ss/Desktop/Visual Studio Code.app/Contents
• Flutter extension version 3.64.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-arm64   • macOS 13.3.1 22E772610a darwin-arm64
• Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.90
[✓] Network resources
• All expected network resources are available.
• No issues found!

Hi @newbieflutter. I'm unable to reproduce this. Tested with a new project on the latest master and stable channels and the default is currently "denied". Also, this doesn't seem like something the team would do. Kindly confirm again on your end.

Hi,
I can confirm by creating another new  simple app its enabled by default. I cant recall what version I was before this upgrade.

Hi @newbieflutter. Can you provide a step-by-step action to reproduce this issue including a minimal complete reproducible code sample that prints out notification status?

Hi Ease,
As I have described above the simple example codes is what I exactly do. So nothing else I do which I why I am quite confused why the notification is enabled and quite on ios? There after I check the notification status in the apple phone it show it enabled and quite.

@newbieflutter
Can you elaborate as what do you mean by notifications is enabled by default ? What result do you see ?
Also, can you try the same with native iOS app and see if you get same behavior or not ?

Hi Darshan,
What I mean is that the notification permission is enabled by default so there is no room for the to ask the user permission for notification. I tried the native iOS app but I dont see it in the notification list either. So looks like only from the flutter side this issue is occuring.


Feature Request: isBase should be made less misleading

Describe the solution you'd like
This may be a personal preference thing but to me, Base is 8453... if I want to use a helper to detect if something "isBase", it should only return true if the chain is 8453.
Currently, isBase will return true for Base Sepolia as well.
Perhaps for backwards compatibility, there should be optional parameters passed like:
isBase({ chainId, isMainnetOnly: true })

Describe alternatives you've considered.
it's simple enough for me to make my own "isBaseMainnet" function:
import { base } from "wagmi/chains";

const isBaseMainnet = ({ chainId }: { chainId: number }) => chainId === base.id;

but I feel like someone could stumble over "isBase" returning true for sepolia.

Thank you @mykcryptodev, here a PR https://github.com/coinbase/onchainkit/pull/1221 with isMainnetOnly support.
The logic behind isBase is that we want something that helps us quickly to check a particular chain support. In particular for the CDP APIs, which are mostly bounded for now to Base or Base Sepolia.
I agree with you it can feel a bit confusing, and we specified the scope of the utility in the docs.
Happy to continue reflect on this in V1 if we see more adoption and confusion around this utility.


Bug: very rare crash

Not sure what I've done to do it, other than playing with it.
This is what I got in the logs:
java.lang.IllegalArgumentException: pointerIndex out of range
at android.view.MotionEvent.nativeGetAxisValue(Native Method)
at android.view.MotionEvent.getX(MotionEvent.java:1983)
at com.almeros.android.multitouch.TwoFingerGestureDetector.updateStateByEvent(TwoFingerGestureDetector.java:77)
at com.almeros.android.multitouch.RotateGestureDetector.handleInProgressEvent(RotateGestureDetector.java:136)
at com.almeros.android.multitouch.BaseGestureDetector.onTouchEvent(BaseGestureDetector.java:66)

I'm closing this one since it doesn't look like others have had the same problem and you are not giving us a lot of info about the problem :)

That's because this is all i had.

Need Help in
Fatal Exception: java.lang.IllegalArgumentException: pointerIndex out of range
at android.view.MotionEvent.nativeGetAxisValue(MotionEvent.java)
at android.view.MotionEvent.getX(MotionEvent.java:2136)
at com.rahul.mystickers.multitouch.TwoFingerGestureDetector.updateStateByEvent(TwoFingerGestureDetector.java:76)
at com.rahul.mystickers.multitouch.RotateGestureDetector.handleInProgressEvent(RotateGestureDetector.java:138)
at com.rahul.mystickers.multitouch.BaseGestureDetector.handleInProgressEvent(BaseGestureDetector.java:4)
at com.rahul.mystickers.multitouch.BaseGestureDetector.onTouchEvent(BaseGestureDetector.java:66)

@AndroidDeveloperLB and @androidapkr It would really help if you explained at what time this happens, how do you use the framework, what do you do at the point this occurs... did you debug with a debugger? Can you get more info through logging (just before this happens)?

@Almeros Already explained at what time and what I did till it happened (just playing with it).
Sadly this was a long time ago, and the repository doesn't have a sample, so I can't try again to reproduce it.
If you have a working sample, please share it and I will try again.

@AndroidDeveloperLB OK, well it just gets very hard to find out what causes the bug then I'm afraid :(
Check out https://github.com/Almeros/android-gesture-detectors-example for a working example

OK tried the sample. Can't reproduce. Have the library changed since the report?
Why handle it after 3 years... I can't remember this far...
Even the first reply was after 2 years.

Also, I suggest putting the sample with the library. Most repositories do it, as it makes it easier to try it out.


BUG: sparse: Fix LIL full-matrix assignment

Reference issue
Fixes gh-18202.
What does this implement/fix?
Previously, LIL's __setitem__ would dispatch through IndexMixin.__setitem__, which doesn't currently handle slice-based keys in an efficient way: it converts slices to index arrays. This means that the eventual call to LIL's overload of _set_arrayXarray_sparse would not be able to detect the full-matrix assignment, and would thus densify the sparse matrix every time.
Until we improve the IndexMixin side of things, this solves the issue by moving the fast-path detection higher up in the call stack, before the slices are converted.

Ok, CI was passing and I believe the regression test/reproducer in the original issue was too slow to be practical when I tried it locally.

I suppose we could follow up with an xslow test, though prio on that may be low.


Add openinput driver

WIP https://github.com/openinput-fw/openinput/tree/master
cc @perigoso

Arch is failing due to https://bugs.archlinux.org/task/69563, I believe this should be fixed when the docker image is updated.

I will add support for custom functions in future PRs.


⚠ TiendaEnLinea has degraded performance

In e5a7896, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 5186 ms

Resolved: TiendaEnLinea performance has improved in 40dec70.


AliTV class offers a project accessor

The new accessor sets and returns the name of the current project

Approved

Coverage decreased (-0.02%) to 99.188% when pulling 76585ee528420a8e8b751d62072f860d44b697b3 on hotfix/project_method into f01b7c703e39b2f92798718312c6bc902a88a780 on develop.


Command not found

When I type "/start (duration)" it doesn't show up as a valid command

That's weird. Are you sure that you're using Forge as mod loader? And can you please post logs? (Can be found in ./minecraft/logs) I will help you asap :)

Damn, I'm so sorry. I forgot to change description at Modrinth and CurseForge. Use /ri_start instead


App Configuration Spring - V2 Feature Management Schema

Description
Updates Spring Provider to the V2 Feature Management schema.
https://github.com/Azure/AppConfiguration/blob/main/docs/FeatureManagement/FeatureManagement.v2.0.0.schema.json
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

Do we need to update the FeatureSet.java file?  "FeatureManagement" to "feature_management"?
https://github.com/Azure/azure-sdk-for-java/blob/feature/spring-boot-3/sdk/spring/spring-cloud-azure-appconfiguration-config/src/main/java/com/azure/spring/cloud/appconfiguration/config/implementation/feature/entity/FeatureSet.java


Docker daemon panic when external registry auth service returns 401

Output of docker version:
Client:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:37:01 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:37:01 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 66
 Running: 0
 Paused: 0
 Stopped: 66
Images: 63
Server Version: 1.10.2
Storage Driver: btrfs
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 3.16.0-36-generic
Operating System: Ubuntu 14.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.955 GiB
Name: <edited>
ID: C7NK:RNIQ:BYLM:I52O:EZAK:O7JP:XFZ2:7EPS:SZ4S:3GVO:E6YK:DZWO

Provide additional environment details (AWS, VirtualBox, physical, etc.):
VirtualBox VM
List the steps to reproduce the issue:

Setup distribution/docker version 2.3 with token authentication
Start a push/pull
When the docker daemon tries to get the authentication token, if the service returns the following response:

HTTP 401
ContentType: application/json
{"error": "unauthorized"}

Describe the results you received:
Docker daemon crashes
Describe the results you expected:
It should log an error saying what is wrong with th response
Provide additional info you think is important:
Panic stack:
panic: runtime error: index out of range

goroutine 176 [running]:
github.com/docker/docker/distribution.retryOnError(0x7f44f1ad06b8, 0xc820d65b40, 0x0, 0x0)
        /usr/src/docker/.gopath/src/github.com/docker/docker/distribution/registry.go:143 +0x138
github.com/docker/docker/distribution.retryOnError(0x7f44f1ad06e0, 0xc820d41bc0, 0x0, 0x0)
        /usr/src/docker/.gopath/src/github.com/docker/docker/distribution/registry.go:150 +0x530
github.com/docker/docker/distribution.(*v2PushDescriptor).Upload(0xc820904f00, 0x7f44f1266420, 0xc820905280, 0x7f44f1266460, 0xc820a381e0, 0x0, 0x0)
        /usr/src/docker/.gopath/src/github.com/docker/docker/distribution/push_v2.go:335 +0x12fb
github.com/docker/docker/distribution/xfer.(*LayerUploadManager).makeUploadFunc.func1.1(0xc820a381e0, 0xc820a38060, 0x7f44f1266810, 0xc820904f00, 0xc820a9f7a0)
        /usr/src/docker/.gopath/src/github.com/docker/docker/distribution/xfer/upload.go:108 +0x1a6
created by github.com/docker/docker/distribution/xfer.(*LayerUploadManager).makeUploadFunc.func1
        /usr/src/docker/.gopath/src/github.com/docker/docker/distribution/xfer/upload.go:150 +0x13e

Looking for related issues, I found https://github.com/docker/docker/issues/18569, which isn't panicking, but I spotted that the response that's  returned in that case is different;
{"message":"Unauthorized","details":null}

Thanks @thaJeztah for your answer, actually Docker is still panicking when changing the response to that

@Soulou it's being looked into while we speak; see the conversation on IRC here; https://botbot.me/freenode/docker-maintainers/2016-03-08/?msg=61733440&page=1

Ok got it, I'm in the channel, thanks for notifying me

Tell me if I can do anything to help/give more info

If an attempt to authenticate to the token server fails, the token server should return a 401 > > Unauthorized response indicating that the provided credentials are invalid.

Quoting from https://docs.docker.com/registry/spec/auth/token/
@Soulou this clearly seems your case I suppose. I don't see anywhere any reference about how those errors should be returned to the docker daemon but I believe the format should be:
{
	"errors": [{
		"code": "UNAUTHORIZED",
		"message": "a message",
		"detail": []
	}]
}

I don't know which token service you're using (I suppose it's a custom one), so could you provide with format I gave above?

I got that format from reading the code, I believe the code needs a proper check instead of panicing though

Perfect:
354ec3d6a342: Preparing
52d7ef0f0957: Waiting
17191cd7bd3d: Waiting
f4288da73a4c: Waiting
62429a5c28dd: Waiting
5f70bf18a086: Waiting
e8061ac24ae3: Waiting
3c84ae1bbde2: Waiting
b5f05191d11d: Waiting
unauthorized: no authorization provided

great, let's see if this is reproducible in 1.9 also, I believe now that it's up to the token service to comply with the format docker/distribution expects but I see docs lack wrt this kind of documentation. I'm not sure it's up to docker/docker to handle this - but I believe we could handle this better

distribution config.yml
version: 0.1
storage:
  filesystem:
    rootdirectory: /var/lib/registry
auth:
  token:
    realm: "http://localhost:5001"
    service: "registry"
    issuer: "auth-registry"
    rootcertbundle: /cert.pem
http:
  addr: <IP_ADDRESS>:5000
  secret: thisisasecret

self signed Cert generation
sudo openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout server.key -out server.pem

https://github.com/docker/docker/issues/21027#issuecomment-193788160 /cc @aaronlehmann does it needs to be documented or we could just check if v[0] in retry error is actually filled?

(or both) ;-)

@Soulou I cannot reproduce the panic when pulling could you double check it's an issue at pull time? I reproduced and I'm about to make a PR

I've to try with the pull operation, only tried when pushing so far. (I needed to get a first image in before pulling it ;-) )

@Soulou could you send me an e-mail at<EMAIL_ADDRESS>Wondering if you'd be interested to be added to our "testers" mailinglist

I've to try with the pull operation, only tried when pushing so far. (I needed to get a first image in before pulling it ;-) )

talked on IRC, the panic is only in push (not also pull)
pulls die with:
Error response from daemon: Get http://localhost:5005/v2/busybox/manifests/latest: <nil>

w/o panicing

This is resolved by https://github.com/docker/docker/pull/21030, but will have to be merged back to master after 1.10.3 has been released

@thaJeztah has this been merged back into master? does it need a label?

@runcom oh, good one; I think this was the only PR directly against the bump branch; can you open a PR to cherry-pick it back to master?

sure!

reopening for master


viewport is not a BaseVolumeViewport

I'm utilizing cornerstone3D with reactjs and displaying a DICOM file using the VolumeBasic example from VolumeBasic example . I made a slight modification to the example by using my own ImageIds obtained from an API call. However, I'm encountering the following error.

what have you changed ? only the imageIds?

I mean imageIds and the wadoRsRoot. Can you plz tell me what should be the return type of the DICOM file from the server? I guess you getting 'image/jls' from server.

Change the ViewportType from  ViewportType.ORTHOGRAPHIC to ViewportType.PERSPECTIVE


[LiveComponent] Update CSRF token after component request

Q
A

Bug fix?
yes

New feature?
yes

Issues

License
MIT

When CSRF is enabled on live components, each request will received a new CSRF token in the response. Currently all subsequent requests made by live components will use the initial CSRF token received. This PR solves this, by updating the CSRF token with the one received in the last response.

Hi @tijnema ! Do you thing you could show me a live example of the problem, or a small reproducer?
I've never had problems with csrf tokens but i often use components without so 😅  ..

We see this in various ways, most common however is that CSRF tokens will reset on login (like issue https://github.com/symfony/ux/issues/1150). After login we rerender live components to refresh the tokens. With this PR applied, the actions work normally.

If you have two form on a page "Foo" currently, with csrf tokens. You open another page and log in. You come back on the page "Foo" and submit one of the form. What happens ?

just use a simple live component with action, set session life time short, wait for session to expire and press action

Is this not the same for a classic Form... or am i missing something here ?

With this PR, action still works after session expired

Do we want this ?

We see this in various ways, most common however is that CSRF tokens will reset on login (like issue #1150). After login we rerender live components to refresh the tokens. With this PR applied, the actions work normally.

If you have two form on a page "Foo" currently, with csrf tokens. You open another page and log in. You come back on the page "Foo" and submit one of the form. What happens ?

It depends. If there's a mechanism which reloads the live component (Like the stimulus controller I posted above), it works. Otherwise it will fail with an invalid CSRF.

just use a simple live component with action, set session life time short, wait for session to expire and press action

Is this not the same for a classic Form... or am i missing something here ?

Yes and no. With a classic form, CSRF is usually stored in a hidden input _csrf_token. Updating CSRF after login with JS is as simple as updating this input field, or rerender the whole form server side and it should work.

With this PR, action still works after session expired

Do we want this ?

Yes. It's still safe because the CSRF will be bound to the users' session. It will be the new session which has been started, instead of it's previous expired one.

We see this in various ways, most common however is that CSRF tokens will reset on login (like issue #1150). After login we rerender live components to refresh the tokens. With this PR applied, the actions work normally.

If you have two form on a page "Foo" currently, with csrf tokens. You open another page and log in. You come back on the page "Foo" and submit one of the form. What happens ?

It depends. If there's a mechanism which reloads the live component (Like the stimulus controller I posted above), it works. Otherwise it will fail with an invalid CSRF.

just use a simple live component with action, set session life time short, wait for session to expire and press action

Is this not the same for a classic Form... or am i missing something here ?

Yes and no. With a classic form, CSRF is usually stored in a hidden input _csrf_token. Updating CSRF after login with JS is as simple as updating this input field, or rerender the whole form server side and it should work.

With this PR, action still works after session expired

Do we want this ?

Yes. It's still safe because the CSRF will be bound to the users' session. It will be the new session which has been started, instead of it's previous expired one.

It depends. If there's a mechanism which reloads [..]. Otherwise it will fail with an invalid CSRF.

So currently there is no difference with the behaviour of standard Form, right ?

Updating CSRF after login with JS is as simple as updating this input field, or rerender the whole form server side and it should work.

Is there something here you cannot do with LiveComponent ? You can re-render the whole component too right ?

Yes. It's still safe because the CSRF will be bound to the users' session. It will be the new session which has been started, instead of it's previous expired one.

But the form contains checksum and data from another user.
I'm not convinced for now, so let's wait other opinions on this.

Hello @tijnema!
So it seems the team agrees with you on the concept "If a component send another CSRF token, it should be updated". So waiting was not a bad idea :)
As you see it, is your PR ready or does it need some changes/updates ?

Friendly @tijnema ? Is this PR ready to merge for you ?  :)

Sorry, I was enjoying holiday. Good to hear the team agrees with me :). As far as I'm concerned, this PR is ready to merge.

I'm just waiting for someone else to check/validate and let's merge it !
.... because we may need soon to adapt things here 😅  cc PR 58095  on symfony/symfony
Thank you @tijnema !

It took time, but here we go, this is in now. Thank you very much @tijnema.


doc: update yarn url

just a small PR to fix your package name in yarn since the one mentioned in the docs doesn't exist.

Thx for your contribution 🙏


aarch64: Placeholders and todos!(...)

A list of functions/functionalities that are not properly implemented:

qkernel/src/interrupt/aarch64/mod.rs:

[ ] init() => Set up GIC
[ ] InitSingleton()
[ ] Add check for ESR.ISS.FnV => Sanity check for FAR_El1

qlib/kernel/SignalDef.rs

[ ] VDSO_OFFSET_SIGRETURN => replace with proper VDSO parser
[ ] FP state on signal handling

qlib/kernel/arch/aarch64/arch_def.rs

[ ] SanitizeUser() => FP state
[ ] Reset() => FP state

qlib/kernel/asm/aarch64.rs

[ ] AsmHostID() => No native instruction on aarch64
[ ] fninit() => FPU init

qlib/kernel/loader/loader.rs

[ ] HWCAP for aarch64

qlib/kernel/memmgr/pma.rs

[ ] PageMgr::Clear()

qlib/mutex.rs

[ ] CmpExchg() => No native instruction on aarch64
[ ] LoadOnce()

qvisor/src/vmspace/mod.rs

[ ] HostID()

[ ] backtrace implementation
[ ] SIMD support in kernel (low priority)

NOTE
The placeholders where needed during the porting from x86_64. Because the main branch has also leftovers, before adding implementation check if the function is actually needed or it can be removed.
If you start working on an item of the list

open a new issue
reference this one

to avoid duplication.

if I may add,

the signal handling is ignoring the FP state.
we don't support SIMD in the kernel (should we? saving/restoring vector registers would be quite expensive.)

On Tue May 14, 2024 at 11:23 PM CEST, Tianhao Wang wrote:

if I may add,

the signal handling is ignoring the FP state.
we don't support SIMD in the kernel (should we? saving/restoring vector registers would be quite expensive.)

Thanks, I added them in the list.

not only for aarch64: we want breakpoints and gdb! XD


Bad link in 'Interacting with your Blockchain' doc

From page https://ibm-blockchain.github.io/interacting/
Under step 3 link titled 'Hyperledger Composer playground guide'  points to a url :
https://hyperledger.github.io/composer/stable/tutorials/playground-guide.html
which reports 'Oh no!…there’s no blockchain here :('

Looks to be closed, links now work.


make the gradient code easy to copy directly

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Friend your change is good but it was creating conflicts in the code. I suggest you to write the function for copying the code in such a manner that it will not create conflict.
Other than that your idea is great.


Added webhook example

Description: Extended memcached-operator at https://github.com/operator-framework/operator-sdk-samples/tree/master/go/kubebuilder/memcached-operator , to include example for Webhook configuration.

$ kubectl get deployment -n  memcached-operator-system
NAME                                    READY   UP-TO-DATE   AVAILABLE   AGE
memcached-operator-controller-manager   1/1     1            1           7m44s
memcached-sample                        5/5     5            5           6m40s

$  kubectl patch memcached memcached-sample -p '{"spec":{"size": 4}}' --type=merge -n memcached-operator-system
Error from server (Cluster size must be an odd number): admission webhook "vmemcached.kb.io" denied the request: Cluster size must be an odd number


Add --profile command line option

When expanding an asset path, currently only the "target/release/" prefix could be remapped. By comprehending the build profile, path expansion can happen for "target/". This enables use of both alternative target-triple and build profiles.
For example, given the following asset configuration in Cargo.toml:
[package.metadata.generate-rpm]
assets = [
  { source = "target/my-profile/my-exe", dest = "/usr/bin/", mode = "755" },
]

rpms can be generated for multiple target triples, such as:
cargo generate-rpm --profile my-profile --target x86_64-unknown-linux-musl
cargo generate-rpm --profile my-profile --target i668-unknown-linux-musl

with the paths for the "my-exe" executable expanded correctly to:
target/x86_64-unknown-linux-musl/my-profile/my-exe
target/i686-unknown-linux-musl/my-profile/my-exe

This behavior is consistent with cargo-deb, which also has a --profile option for the same purpose.

Thank you for proposing new feature.

In your PR, source in package.metadata.generate-rpm.assets is supposed to be written in with the value of target specified as an argument instead of release, like target/my-profile/my-exe. I think the source in package.metadata.generate-rpm.assets should be written as target/release/my-exe and it should be expanded to target/my-profile/my-exe or target/x 86_64-unknown-linux-musl/my-profile/my-exe.
That is, I would prefer that profile be treated the same as target.
What do you think?
Could you please update the README.md in addition to the source code? A short addition to the "Cross compilation" clause would be sufficient.

Yes, good suggestion.
I've updated the patch so that the "target/release/" prefix is preferentially remapped while still also looking for "target/{prefix}". This is how cargo-deb does it.
And I've added a paragraph about the '--profile` option to README.md.
Thanks for reviewing this PR. Much appreciated.


New Docker Images?

Are you guys planning on publishing the new docker images? The latest docker image I see is 5.2.2, at the time of writing this 5.3.2 is the latest release of cas.

Yes. At some point.

That was quick, thanks for the info @mmoayyed

Thanks @mmoayyed I really appreciate it.


ReAct module continues moving forward despite getting an answer

I've grabbed the sample code in the docs for ReAct and tried running it.
I discovered 2 things:

it would appear that the ReAct agent need a retrieve module client which isn't documented, in case one of the intermediate actions is Search; I made do with dspy.ColBERTv2
max_iters is set to 5 by default, but sometimes the agent seems to reach an answer before the max iters is which leads to action splitting code to throw an error https://github.com/stanfordnlp/dspy/blob/74ca4ca470c11414cafad915e2e42f47843a39e4/dspy/predict/react.py#L88

Here's the code:
import dspy

def main():
    # setup ollama client to interact with llama2
    llama2 = dspy.OllamaLocal(model="llama2")
    dspy.configure(lm=llama2)

    wiki_abstracts = dspy.ColBERTv2(url="http://<IP_ADDRESS>:2017/wiki17_abstracts")
    dspy.configure(rm=wiki_abstracts)

    # Define a simple signature for basic question answering
    class BasicQA(dspy.Signature):
        """Answer questions with short factoid answers."""

        question = dspy.InputField()
        answer = dspy.OutputField(desc="often between 1 and 5 words")

    # Pass signature to ReAct module
    react_module = dspy.ReAct(BasicQA)

    # Call the ReAct module on a particular input
    question = "Aside from the Apple Remote, what other devices can control the program Apple Remote was originally designed to interact with?"
    result = react_module(question=question)

    print(f"Question: {question}")
    print(f"Final Predicted Answer (after ReAct process): {result.answer}")

if __name__ == "__main__":
    main()

Here's the snippet of agent prompting history:
Prediction(
    Thought_1="Question: Aside from the Apple Remote, what other devices can control the program Apple Remote was originally designed to interact with?\n\nThought 1: Hmm, that's an interesting question. Let me think about it... (pauses) Based on my knowledge of Apple's history and product offerings, I believe the Apple Remote was originally designed to work with Apple's line of personal computers, such as the Macintosh computer. However, I wonder if there are any other devices that can control the program Apple Remote was designed for... (continues thinking)",
    Action_1='Search[query="other devices that can control Apple Remote"]'
)
=== ACTION: Search[query="other devices that can control Apple Remote"]
Prediction(
    Thought_2='Question: Aside from the Apple Remote, what other devices can control the program Apple Remote was originally designed to interact with?\n\nThought 1: Hmm, that\'s an interesting question. Let me think about it... (pauses) Based on my knowledge of Apple\'s history and product offerings, I believe the Apple Remote was originally designed to work with Apple\'s line of personal computers, such as the Macintosh computer. However, I wonder if there are any other devices that can control the program Apple Remote was designed for... (continues thinking)\n\nAction 1: Search[query="other devices that can control Apple Remote"]\n\nObservation 1',
    Action_2='Answer: There are several other devices that can control the program Apple Remote was originally designed to interact with, including:\n\n1. iTunes Remote: This is a software application developed by Apple for iOS devices that allows for remote control of Apple TV or iTunes library in an area with Wi-Fi connectivity using the proprietary Digital Audio Control Protocol (DACP).\n2. Apple Remote Desktop: This is a Macintosh application produced by Apple, first released on March 14, 2002, that allows users to remotely control or monitor other computers over a network.\n3. Siri Remote: This is the remote control device included with the fourth generation'
)
=== ACTION: Answer: There are several other devices that can control the program Apple Remote was originally designed to interact with, including:

As you can see the Action has reached an Answer but the code continues to split the output completely ignoring it.
Suggestion: check if the answer has been returned by the agent before max_iters has been reached.

Hi @milosgajdos , at the moment the ReAct module is configured to only halt at the stopping condition Finish[answer].
It seems like the model is hallucinating a bit from the output \n\nAction 1: Search[query="other devices that can control Apple Remote"]\n\nObservation 1', in Thought_2 which can lead to the corresponding steps to break as well.
I suspect this is due to some incompatibilities with DSPy and chat models (which is currently in-progress to fix), and not due to the ReAct setup itself, but you can add on another tool to check if the Action has reached Answer as well and modify that stopping condition for now.
lmk if this helps or if you have any other suggestions! (ReAct is fairly experimental right now so we'd love any PRs to resolve issues like these!)

Ah, my GH notifications got outta control. Thanks for the response!!
Interesting...I'm wondering, would the instruction optimiser be able to stir the model in the right direction? Or some DSPy assertion suggestion? Sorry about the dumb questions, I'm still very new to this framework


EmailClient.php ignores MAIL_TRANSPORT via mail (php mail function)

Emails are not sent via the built in PHP mail function if it is set in the configs. The Comment in the config file allows the following settings:
// Mail transport available: "smtp", "sendmail", "mail" (PHP mail function), "postmark", "mailgun", "sendgrid"
This may be due to the fact that this setting is not implemented in ./apps/core/EmailClient.php:
"switch (MAIL_TRANSPORT) {
        case 'sendgrid':
            $this->sendgrid->sendEmail($email, $name, $subject, $html, $author);
            break;
        case 'mailgun':
            $this->mailgun->sendEmail($email, $name, $subject, $html, $author);
            break;
        case 'postmark':
            $this->postmark->sendEmail($email, $name, $subject, $html, $author);
            break;
        default:
            $this->smtp->sendEmail($email, $name, $subject, $html, $author);
    }"

I suggest the sth similar to the following:
"switch (MAIL_TRANSPORT) {
        case 'sendgrid':
            $this->sendgrid->sendEmail($email, $name, $subject, $html, $author);
            break;
        case 'mailgun':
            $this->mailgun->sendEmail($email, $name, $subject, $html, $author);
            break;
        case 'postmark':
            $this->postmark->sendEmail($email, $name, $subject, $html, $author);
            break;

        case 'mail':
            $headers  = 'MIME-Version: 1.0' . "\r\n";
            $headers .= 'Content-type: text/html; charset=utf8' . "\r\n";
            mail($email,$subject,$html,$headers);
            break;

        default:
            $this->smtp->sendEmail($email, $name, $subject, $html, $author);
    }"

It's implemented here: https://github.com/fguillot/kanboard/blob/master/app/Integration/Smtp.php#L55-L67 by using the library SwiftMailer.


Unfurl command for docker run

Commands passed to docker run should be unfurled, otherwise they do not work as intended, for example the node snipped from the readme:
  - command:
      - "yarn install"
      - "yarn run test"
    plugins:
      - docker#v3.1.0:
          image: "node:7"
          always-pull: true
          environment:
            - "MY_SECRET_KEY"
            - "MY_SPECIAL_BUT_PUBLIC_VALUE=kittens"

would output:
yarn run test' in node:7
--
  | docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"yarn install\\nyarn run test\": executable file not found in $PATH": unknown.
  | 🚨 Error: The command exited with status 127

This is because its like doing:
docker run --rm node:7 "yarn install" instead of docker run --rm node:7 yarn install
Line:
https://github.com/buildkite-plugins/docker-buildkite-plugin/blob/7c8e01ee90ebc29bb23436a52d924ecf1a2c43fa/hooks/command#L363
should probably change to
[...] docker run ${args[@]}

That's really odd, that is supposed to work 🤔 Let me test this.
For some context, check out "Improved Shell Handling" in https://github.com/buildkite-plugins/docker-buildkite-plugin/releases/tag/v2.0.0 for how it's supposed to work.

This seems to work ok for me. It should be executing:
/bin/sh -e -c 'yarn install
yarn run test'

Which is totally correct.

I'll close this one for now, let me know if I've misunderstood!

Yep, that output would be totally correct. I wonder if this was an error of the node image, as I put on my first comment, that was not the output I was getting out of it.

Yeah, that's really strange 🤔 If you happen to see it again, send us the build and we will investigate!

I tried just now and this is working as expected, im confused as I had a build with it configured as described in the issue desc, but I believe its now removed. If I can replicate again or find the build, ill post here.
For now, this seems to be something else and not the plugin.
Thanks


Using Firebase Phone Authentication without swizzling

[READ] Step 1: Are you in the right place?
Yes
[REQUIRED] Step 2: Describe your environment

Xcode version: 8.3.1
Firebase SDK version: 4.2.0
Firebase Component: Auth
Component version: 4.2.0

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
I'm currently implementing firebase phone Authentication, and can successfully implement the phone authentication using the firebase UI without swizzling, but from my research it seems that implementing firebase phone authentication without swizzling requires the user to allow notifications. I know that firebase sends a silent notification that does not need to be approved through allowing notifications but it seems the only way to get that notification without swizzling is to ask the user to allow notification. Does anyone know how or if its possible to do this without swizzling and without asking the user for notification permissions?
I have added to push notification certificates to firebase, and have added all the needed function listed in the firebase phone ui docs.
Without asking the user for to allow notifications this function listed from the phone auth docs does not get called (the user also has to select allow)
func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) {
  // Pass device token to auth
  Auth.auth().setAPNSToken(deviceToken, type: AuthAPNSTokenTypeProd)

  // Further handling of the device token if needed by the app
  // ...
}

If this functions is not called the setAPNSToken is not set, I will not get the silent notification to continue with phone auth, and I will get the generic error

Authentication error: There seems to be a problem with your project's Firebase phone number authentication set-up, please make sure to follow the instructions found at https://firebase.google.com/docs/auth/ios/phone-auth

Relevant Code:

@marknf94 On iOS 8 and above, because Firebase Auth uses silent notifications, it does not require explicit user permission for notifications to sign in with phone numbers. This is unrelated to whether swizzling is enabled or disabled. The user is not even prompted for notifications in the first place. I wonder why the user sees the prompt for allowing notification in your app? Was it on iOS 7?
Also, if application(_:didRegisterForRemoteNotificationsWithDeviceToken:) is somehow not called, can you check wether application(_:didFailToRegisterForRemoteNotificationsWithError:) is called or not, and if so, what is the error?

@XiangtianDai Thanks for the response, Im aware that they should not be prompted in the first place which is part of my confusion. Only when prompting the user to allow notification though then I am able to get application(_:didRegisterForRemoteNotificationsWithDeviceToken:) to be called.
I added application(_:didFailToRegisterForRemoteNotificationsWithError:) to my project and it was not called either.

@marknf94 Please allow me to understand more about the issue:

This happens on a real device, not on a simulator, correct?
Which iOS version is it, or does the issue appears on all iOS versions?
Does your app, or any of the libraries your app uses, call UIApplication's registerForRemoteNotifications(matching:)? How about UNUserNotificationCenter's requestAuthorization(options:)?
Does enabling swizzling (i.e., removing FirebaseAppDelegateProxyEnabled from plist or setting its value to YES) make a difference?

@XiangtianDai

Yes this happens on a real device
I tested it across 2 devices 1 on iOS 11 and another on iOS 10, same issue on both
I call registerForRemoteNotifications(matching:) , calling UNUserNotificationCenter's requestAuthorization(options:) request notification permission from the user so I do not want to call that on the login screen but it is called later once they have logged in
No, I tried to enable swizzling but still the same issue arrises

@marknf94 What if you don't call either registerForRemoteNotifications(matching:) or UNUserNotificationCenter's requestAuthorization(options:)? When you start the phone auth sign in flow FirebaseAuth automatically calls registerForRemoteNotifications(), which unlike the two previous methods, does not show any user prompt.

@XiangtianDai if FirebaseAuth automatically calls registerForRemoteNotifications() then my breakpoint in application(_:didRegisterForRemoteNotificationsWithDeviceToken:) or application(_:didFailToRegisterForRemoteNotificationsWithError:) and then in func application(_ application: UIApplication, didReceiveRemoteNotification notification: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) should be hit then correct? They currently do not, with and without swizzling enabled

@XiangtianDai  An update:
I turned swizzling back off, and I am now receiving the notification in
func application(_ application: UIApplication, didReceiveRemoteNotification notification: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult)
but it does not let phoneAuth go through because

func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) {

        Auth.auth().setAPNSToken(deviceToken, type: .unknown)

    }

is not getting called first.

@marknf94 In your implementation of application(_:didReceiveRemoteNotification:fetchCompletionHandler:) did you call Auth.auth().canHandleNotification(_:) with the notification you have received? Before attempting to get APNs token, FirebaseAuth tests whether your app delegate forwards notifications to itself, and returns "ERROR_NOTIFICATION_NOT_FORWARDED" if the test failed.

@XiangtianDai Yes my function appears like this and does handle the notification
    func application(_ application: UIApplication, didReceiveRemoteNotification notification: [AnyHashable : Any], fetchCompletionHandler completionHandler: @escaping (UIBackgroundFetchResult) -> Void) {
        if Auth.auth().canHandleNotification(notification) {
            completionHandler(UIBackgroundFetchResult.noData)
            return
        }
        // This notification is not auth related, developer should handle it.
    }

I believe the main issue now is that
func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) {

        Auth.auth().setAPNSToken(deviceToken, type: .unknown)

    }

nor
func application(_ application: UIApplication, didFailToRegisterForRemoteNotificationsWithError error: Error)
is getting called, even though I have added        UIApplication.shared.registerForRemoteNotifications()
before FirebaseApp.configure()  in didFinishLaunchingWithOptions

@marknf94 So neither of your implementations of application(_:didRegisterForRemoteNotificationsWithDeviceToken:) nor that of application(_:didFailToRegisterForRemoteNotificationsWithError:)is called after you explicitly callUIApplication.shared.registerForRemoteNotifications()`? Then it looks your app does not have APNs set up correctly. Please double check the following:

"Push notifications" is enabled in "Capabilities" of your app in Xcode settings.
"Background Modes" is enabled in "Capabilities" of your app in Xcode settings and under it "Remote notifications" is checked.
Your app ID registered on apple developer site has push notification enabled.
(less likely but just in case) "Background refresh" is not disabled on the device or for your app in iOS Settings, and the network is available when testing.

If any of above needs to be change, please delete the app completely from the device before re-compile and run it again, otherwise the change may fail to be picked up by the device.

@XiangtianDai The issue was this point

"Background Modes" is enabled in "Capabilities" of your app in Xcode settings and under it
"Remote notifications" is checked.

Then deleted the app and reinstalled and it worked!
Thanks for the help!

Thanks for confirming, @marknf94!


Remove <details> / <summary> css

Follow-up from: https://github.com/JuliaPluto/PlutoUI.jl/pull/288#pullrequestreview-1880829370
Pending: https://github.com/fonsp/Pluto.jl/pull/2814

Initially I had hoped to allow arbitrary @md/@htl strings, but couldn't guarantee good default behavior for headings/non-inline elements.

After a little noodling I've prototyped a pretty simple solution.

I'll turn your suggestion into an issue and start a new PR for that feature specifically. Thanks for the extra push to try again!

With v0.19.39 released this should be ready to go, yeah?
Binder doesn't seem to be on the latest Pluto version so it doesn't show up right, but after updating Pluto everything looks good with this branch locally (for all the good that does 🙄) in Firefox and Chrome.

Great! Looking forward to the merge!
Is there any particular reason why you prefer display: inline-block; to display: inline-flex;? The difference I see is the position of the triangle at the top or bottom of the block. I prefer it at the top. It seems more natural. Just saying... But I can change this particular behaviour to suit my taste! Thank you very much, once again!


Makefile

This PR adds a Makefile to build, install and uninstall danger-swift. It will not clone or pull sources from GitHub. This Makefile will be used for both manual installation and installation via Homebrew.
Manual Installation
$ git clone https://github.com/danger/danger-swift.git
$ cd danger-swift
$ make install

Uninstall
$ make uninstall

👍


Please compile it for Apple Silicon (ARM)

Unfortunately Mechvibes doesn't have an ARM version so currently on macs with Apple Silicon, it runs via Rosetta, which leads to higher CPU usage, and as a result, higher battery usage.

I will fork the project and recompile it for Apple Silicon.


Using logger.logColor for Karma and Protractor

Codecov Report

Merging #376 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   99.25%   99.25%   +<.01%
==========================================
  Files          72       72
  Lines        1737     1739       +2
  Branches      282      282
==========================================
+ Hits         1724     1726       +2
  Misses         13       13

Flag
Coverage Δ

#builder
100% <100%> (ø)
:arrow_up:

#runtime
94.77% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

config/protractor/protractor.conf.js
100% <100%> (ø)
:arrow_up:

config/karma/shared.karma.conf.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293b9c3...77ff1ab. Read the comment docs.


Replaced http://aka.ms with https://aka.ms.

This PR is a simple text replacement for http://aka.ms links to the corresponding https:// link. The only targets are those files in the /articles/connectors path.

@scovetta : Thanks for your contribution! The author, @ecfan, has been notified to review your proposed change.

Approved by Angela in email.


Remove offsetLeft/offsetTop entirely.

Removing offsets for hints entirely: we don't need them on the chart. The changes can be made with CSS.
This change will solve #14.
@uber-common/data-visualization, please review.

Hm, how will these be done using CSS? I don't think you can mimic this behavior through margins because they're absolutely positioned.

Instead of using offsetLeft and offsetTop (adds some ambiguity), I switched to using CSS classes. Now the hint gets the class rv-hint--orientation-[value], where value is either topleft, topright, bottomleft or bottomright.
Please note, that this pull request contains a breaking fix. Previously values of orientation were corresponding the opposite position. Now this ambiguity is fixed.

lgtm . Might need an FAQ or documentation example to show how to set up offsets


I had set "emmet.syntaxProfiles": {"blade": "html"},but I can't use Emmet In blade file,

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:07:25.676Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
0.7.2

laravel-blade
one
1.8.1

open-html-in-browser
pea
0.0.2

vscode-icons
rob
7.12.0

laravel-5-snippets
sac
2.0.1

Steps to Reproduce:

Reproduces without extensions: Yes/No

Use the setting emmet.includeLanguages instead and read Emmet configuration


Review and extend the process

This modest PR is directed to the non-jupyter pipeline (screen_it_pipeline.py), it covers the full process with harvesting, Pub2TEI and software mention extraction.
This was working well for me. The harvesting worked for the 1500 PMCID, Pub2TEI stuff, and then 50 minutes to process the files (1476 JSON extraction files produced) with GPU.
I had to create a directory resources/ for the harvester and I added the file missing config/comparison_full_set-pmcids.csv.

Awesome. I think I forgot to push some lines I had already; I’ll merge.
I’ll add a docker-compose to run the server locally as well :)


[CI] Issue labeling update

Signed-off-by: Lee Calcote<EMAIL_ADDRESS>Description
This PR is just a maintenance task.

@EleisonC you might like to review this.


Sass does not support @extend

The sass directive @extend can be very useful when creating new styles based on the ones provided by Ionic, though due to https://github.com/sass/libsass/issues/146 the compile did not work properly.
As far as I can tell the version of gulp-sass included is too old, and has old dependencies. We should be using a more recent version.
Workaround:
npm install gulp-sass@latest (no -g)
POC, compile the following:
.item-media {
  @extend .item-avatar;
  > img:first-child {
    border-radius: 0;
  }
}

This requires us bumping gulp-sass up to 1.3.2 in the ionic-app-base.
Let me look into it.

gulp-sass was bumped.


Use resource types for parameter validation

Is your feature request related to a problem? Please describe.
With the user-defined types preview enabled, users can declare custom types and validate that parameters match those type declarations. If a parameter value is passed directly to a resource as a property, however, users need to re-declare the existing type definition as type symbols within their template (or forgo validation).
Describe the solution you'd like
It should be possible to use an existing resource type (or portion thereof) from a built-in or imported namespace. This could be accomplished via typeof function or keyword, such as in typeof('Microsoft.KeyVault/vaults@2022-07-01#properties.accessPolicies[*]').
If we want to leave room for a similar function that gets the assigned type of a variable or parameter, we might need two functions or to require the resource keyword:
param foo { bar: string }
param bar typeof(foo).bar
param accessPolicy typeof(resource 'Microsoft.KeyVault/vaults@2022-07-01').properties.accessPolicies[*]

One thing to keep in mind with provider-supplied types is that the compiler doesn't trust that they are completely accurate (or that they will remain completely accurate during the period between when the template is compiled and when it is deployed). Type checking based on resource types will generate warnings accompanied by links to report type inaccuracies, while type checking based on something defined within the template itself will generate errors.
Consequently, typeof(resource ...) should not have the same representation in the compiled template that custom types explicitly defined by the template author do. Explicitly defined types are compiled into ARM constraints, violations of which cause the deployment to fail. One potential solution here would be to compile typeof(resource ...) derived types into a metadata entry. For example,
param accessPolicy = typeof(resource 'Microsoft.KeyVault/vaults@2022-07-01#/properties/accessPolicies/*')

might compile to:
{
  "parameters": {
    "accessPolicy": {
      "type": "object",
      "metadata": {
        "__bicep_resource_type": "Microsoft.KeyVault/vaults@2022-07-01#/properties/accessPolicies/*"
      }
    }
  }
}

Some open questions with this approach:

What happens if a compiled template being consumed as a module refers to a type that is unknown to the parent template? For example, if the module is using an earlier version of Bicep.
It is possible for resource type definitions to diverge over time. Is it OK if a parent template and a module, compiled using different versions of Bicep, report incompatible types under the same identifier?

On first reading, this looks like it is simply a way of allowing people to declare a variable's type based on an existing type. For example, following the example in there, I can see that if it was in place, then rather than writing...
param serviceBusNamespaceName string

...then I could declare...
param serviceBusNamespaceName typeof(resource 'Microsoft.ServiceBus/namespaces@2022-01-01-preview').properties.name

So we've replaced the direct reference to a string type with an indirect reference to the same type.
However, I've been referred here from #9797 by @jeskew, with the implication that this has an additional behaviour, which I didn't "get" this from reading the proposal, so I wanted to check... @jeskew are you proposing that:
When declaring a parameter by using a reference to a property, the declaration is saying that not only the type of that property would come across to this declaration; but any validation decorators applied to that property would come too. So for example, if the Service Bus name property had 3 validation decorators (e.g. a regex validation, minimum and maximum string length), those would be applied to this parameter.

Yes that's right. Can you clarify why you would not want that? IOW, what are you looking to enable with this typeof() parameter type if not to restrict the input to what that property allows?

Can you clarify why you would not want that?
I didn't say that I didn't want it, I was just surprised :) ... I've used plenty of languages over the years, and I don't recall seeing something like this before (a type declaration which includes specific validation logic); but that doesn't mean it isn't a good idea.

I'm guessing that it probably infers all of the decorators, because there is probably no way to distinguish the validator decorators from the others; and that's probably fine, too.
The derived declaration may want to override some of them, like @description: for example, there might be two parameters both of the same type, and you might want to distinguish between them.
There might need to be a way to prevent something coming across, although I'm not experienced enough with Bicep to give an example... perhaps the @metadata might apply to the original declaration, but not the derived declaration?

To me and our large insurance company's usage even just a typehint to the language server would already help immensely. Currently all var objects are typeless basically, and telling the lang server something simple, that this is indeed a<EMAIL_ADDRESS>(or partial of it) and not just a random object would be really helpful.

Based on a team discussion, the initial implementation will use a slightly different syntax from the proposal described above. Instead of a typeof(resource ...) function, there will instead be a resource<...> utility type (syntax and name cribbed from TypeScript). E.g., instead of typeof(resource 'Microsoft.KeyVault/vaults@2022-07-01').properties.accessPolicies[*], the syntax would be<EMAIL_ADDRESS>


Upgrade Retail SDK Android

LGTM let me know if you're merging this before or after analytics listener work.

@TakaGoto thanks for the review, I will wait till after the Android analytics changes is in before merging this 👍

Hey @TakaGoto we'll merge and release this today as a lot of project work needs this fix from the library


Add a setting that decides if STAFF ADMIN can see draft submissions or not

Related Issue
Related https://github.com/HyphaApp/hypha/issues/2986
User Story
As a staff admin I need to see draft submissions on the platform in order to troubleshoot technical questions.

I see the drafts. Thank you! 💯


Fix NR not accessible to a function with layers defined

I have a service with several functions that were working fine with serverless-newrelic-lambda-layers, but then I added a new function that needed its own layers definition within the function:
functions:
  mySpecialFunction:
    layers:
      - arn:aws:lambda:us-east-1:123456789012:layer:SomeSpecialLayer:1

When I added this new function, it did not have access to newrelic_lambda_wrapper:
Runtime.ImportModuleError: Unable to import module 'newrelic_lambda_wrapper': No module named 'newrelic_lambda_wrapper'

It turns out that if layers is specified under a function, it will override (not merge with) any layers at the provider level.
This should fix things by adding the New Relic layer to functions that have any layers already defined, even if shouldUseProviderLayers is true and provider layers will be used for the other functions.
NOTE: I had to bump the layer versions used in the tests to get them to pass. I hope that's ok.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Alex McHardy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@alexmchardy I'm having the same issue here. Do you have a workaround until this is fixed?
Thanks for the contribution by the way!

@jorenvh1 Yes, for example I added - arn:aws:lambda:us-east-1:451483290750:layer:NewRelicPython38:79 to the layers definition of my function that had other layers specified, and that worked. Other functions that don't have layers defined still work fine with serverless-newrelic-lambda-layers.

@alexmchardy Would you be able to rebase this against the current master branch, and sign the CLA? Then we'd be able to review. Thank you for submitting a fix!

@mrickard I rebased and signed the CLA. Thanks!


Dashboard: Fix base layout

Base layout main content div is set to overflow: scroll when the content displayed in the page exceeds the height of the viewport. However, the div itself is scrolling when the scroll should be happening in the browser.

Fixed: layout is full height with or without activities


#1518279 For all roles that have sui product features adds sui_notifications

https://bugzilla.redhat.com/show_bug.cgi?id=1518279
Those roles with sui or sui_core don't require this product feature to ensure consistent behavior.
This pr has a sister in the sui repo, these combined close thhe bz: https://github.com/ManageIQ/manageiq-ui-service/pull/1293

Gaprindashvili backport details:
$ git log -1
commit 03fe3c2a815b36822b0e8e59bc9e7ca7a0a0dc1d
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Sat Feb 24 17:59:47 2018 +0100

    Merge pull request #16817 from AllenBW/#1518279-update-sui-roles-to-include-sui-notifications

    (cherry picked from commit c57a11b98aae1f89d58fe179149c9f647e001961)

    https://bugzilla.redhat.com/show_bug.cgi?id=1552801


fix: continue if binding.get(&pc).is_none()

Thanks for the contribution though, but we are refactoring the use of source map #372 , and this middleware will be re-written.