popup opening downward if it's "overflowing" north maxBound would be great

First off all, thanks a LOT for all this amazing work!
On stable 0.7.3 I'm using map.setMaxBounds([[90, -180], [-90, 180]]), wich is great to prevent user from navigating through "copies" of the world. And I let the popup.otions.autoPan to default (true).
With this set up, there is one problem : Saying zoom level is very low and a marker is in top of the map (north of Groënland for example), The popup will open > autopan feature will allow for 1/2sec to view the popup (making the view go "over the world") > the setMaxBounds method will in the meantime prevent  this behaviour. Here you can see the problem : http://jsfiddle.net/9zyeyk0a/2/
I see 2 solutions to prevent this "yoyo" effect :
1.to have a setMaxBounds method which only works horizontally.
2.Better : to open the popup below the marker in this case.
I managed to go through the 2nde solution with some "dirty tricks" but it would be great to be something automatic (without these jQuery tricks). I did this :
*** I changed autoPan to false during binding Popups
*** I created a CSS custom class called 'reverse-popup' to have the tip at the top pointing upward :
.reverse-popup .leaflet-popup-tip-container {
position: absolute;
transform: rotate(180deg);
top: -20px;
left: 64px;
}
***And then in the page :
map.setMaxBounds([[90, -180], [-90, 180]]);
map.on('popupopen', function(e) {
if(!e.popup.options.oldOffset) e.popup.options.oldOffset = e.popup.options.offset; // saving old anchor point X Y
var px = map.project(e.popup._latlng);
var heightOpeningPopup = $('#map').find('.leaflet-popup-content').height(); // we calculate popup content height (jQuery)
var temp = px.y - heightOpeningPopup; var temp2 = heightOpeningPopup+42;
if(temp < 100){ // if it will go above the world, we prevent it to do so
e.popup.options.offset = new L.Point(0, temp2); // we make the popup go below the poi instead of above
$('#map').addClass("reverse-popup"); // we make the popup tip to be pointing upward (jQuery)
e.popup.update();
}
else{ // we allow auto pan if the popup can open in the normal upward way
e.popup.options.offset = e.popup.options.oldOffset;
e.popup.options.autoPan = true;
$('#map').removeClass("reverse-popup");
e.popup.update();
}
});
map.on('popupclose', function(e) {
e.popup.options.autoPan = false;
});
Here it is : http://jsfiddle.net/eopfrwdn/2/
Cheers et Bonsoir:)

Duplicate of #2324


runtime: defer statement not executed during panicking

This program should run successfully: https://play.golang.org/p/rms3jZGZcAQ
It does run successfully with gccgo, but it fails with cmd/compile. The problem is the deferred function containing "panic(4)" is never executed.
/cc @danscales @randall77
Found with mdempsky/deferfuzz.

Looks like a duplicate of #43921 actually. It's also fixed by CL 286712, PS 3.

Looks like a duplicate of #43921 actually. It's also fixed by CL 286712, PS 3.


Prevent git from converting linebreaks on windows

Someone on windows should probably verify that this works. (After cloning the repo and running npm test, the linter should not report any linebreak style errors.)

Expected linebreaks to be 'LF' but found 'CRLF'

@Raia Did you do a clean clone or was this from an existing repository checked out?
Also, @not-an-aardvark we should probably do autocrlf=false as well.

@YaManicKill, it's a clean clone.

Ah wait, I think it's because you have to clone master first, and then the branch. Git attributes are a little complicated in that matter. I'll merge this and test it, and see what it does.

Aaactually, I'm not going to merge, because I just tested the branch myself and it worked fine for me.
@Raia Are you sure it didn't work for you?

@YaManicKill, I can try again in the evening. If it worked for you I probably did something wrong.


Upgrade Chez and other packages in nix config

We need to stay on the racket fork, or upgrade to 10.0 to support things like ARM macs

Seems like the issue linked in flake.nix is now closed so using nixpkgs-unstable which gives us Chez 10.x.


External audio stops right after fortune wheel initialization

Navigating to a view controller that hosts a SwiftFortuneWheel stops any external audio that might have been being played within Music application.

https://github.com/sh-khashimov/SwiftFortuneWheel/blob/883669528b6249cf9f5c9edf91e9b581876f6e40/Sources/SwiftFortuneWheel/Utils/Audio/AudioPlayerManager.swift#L36
Commenting the init() of AudioPlayerManager seems to fix this problem. But this might have other consequences somewhere else.
Note: I also need the collision sound effect to be enabled.

I don't have a Macbook/iPad with me right now. Could you please try this on your viewDidLoad:
https://stackoverflow.com/questions/67350148/how-can-i-play-a-sound-in-swift-without-stopping-the-playing-music

try this on your viewDidLoad:

I already tried that but no luck.

It seems to me that AVAudioEngine works differently than the usual AVAudioPlayer.

They both use AVAudioSession.
Try to add it to AppDelegate to didFinishLaunchingWithOptions.
Try other options like here:
https://stackoverflow.com/questions/32198013/avaudioengine-stops-devices-background-audio

If it does not help, the only problem I see is that, after collisions and sounds stop, the wheel should notify others.
try AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation)

The reason for this is that other apps playing music in the background will know when to turn their audio back on when you deactivate yours. Otherwise, your background music won't turn back on.
If you cannot find the workaround, I will look into it in the coming days.

Well, the problem is not with resuming background music from Music app. The problem I wanted to focus is:

Whenever a view controller with SwiftFortuneWheel is opened, all the sounds from other sources stop even before the spinning of the wheel

If other sound would stop when the wheel spinning animation started, that wouldn't be a problem. It's the intended behaviour after all. The issue is, I just navigate to the wheel view controller and sound from other source stops immediately.

Then there is a crash 💥 as per following sequence:

Navigate to a view controller with fortune wheel
Play music from iPhone music player (preferably resuming playback from control centre)
Tap the spin button of fortune wheel
Boom 💥

I found a good relevant  comment here: https://stackoverflow.com/a/55505717/3687801

If you're using AVAudioEngine, defer setting up the engine or connecting anything to the engine's mainMixerNode or outputNode until you actually need to start playing something.

@sh-khashimov Can you please check the PR? Would be nice if you can verify and merge.

I don't have a Macbook/iPad with me right now to check this out. Could you please try this on your viewDidLoad:
https://stackoverflow.com/questions/67350148/how-can-i-play-a-sound-in-swift-without-stopping-the-playing-music

adding this code:

            do {
                try AVAudioSession.sharedInstance()
                    .setCategory(.playback, options: .duckOthers)
                try AVAudioSession.sharedInstance()
                    .setActive(true)
            } catch {
                print(error)
            }

to AppDelegate didFinishLaunchingWithOptions or to

    @IBOutlet weak var fortuneWheel: SwiftFortuneWheel! {
        didSet {
            do {
                try AVAudioSession.sharedInstance()
                    .setCategory(.playback, options: .duckOthers)
                try AVAudioSession.sharedInstance()
                    .setActive(true)
            } catch {
                print(error)
            }
        }
    }

Fix everything. However, the problem caused that instead of an engine.start() there should be an engine.prepare() method.
Thank you for investigating the problem. I appreciate it. 🙏

Would you mind closing this issue?


Result folder created even for "nixos-rebuild switch"

Each time I run "nixos-rebuild switch", there's a result folder created in the current directory. Everything else is normal.

Duplicate of #12665


Freezing layers

There are lots of papers that train neural nets by training a layer, freezing the weights, stacking a layer on top, training etc. How does one implement this with Keras?
e.g.
http://ufldl.stanford.edu/wiki/index.php/Stacked_Autoencoders

+1 for this feature

This is trivial before compilation by setting layer.params and layer.updates to []. **This has to be done after layer instantiation but before adding the layer to the model.** You could develop a shorthand layer constructor argument: freeze=True` for convenience.
It is not possible after compilation.
So what you want to do is create a new network reusing the weights of the previous network (set_weights and get_weights), stack something on top, then freeze the layers you want to freeze via the method above.
PS: do not waste your time reproducing really outdated research like stacked autoencoders... freezing + stacking can have some interesting applications though.

Thanks for the tip, I really looked into a way to do this without changing the core keras code.

In caffe you can define a "learning rate multiplier" per layer.
Maybe this can be done in keras?  That way if you want to freeze a layer
you can just set its learning rate to 0.
On Thu, Sep 3, 2015 at 1:12 PM, Amit Beka<EMAIL_ADDRESS>wrote:

Thanks for the tip, I really looked into a way to do this without changing
the core keras code.
—
Reply to this email directly or view it on GitHub
https://github.com/fchollet/keras/issues/622#issuecomment-137400792.

I kind of liked Lasagne's way of doing this where each parameter can have a number of binary flags set, e.g. trainable=True. That way you don't have to remove the parameters from the list completely and stuff like saving weights still works.

I also need to freeze a few layers in order to fine-tune a network in a multi-stage manner (fine-tune last layers first).
Following previous suggestions, I have added a boolean trainable to the base Layer class which is checked when adding a layer to a container. Also, to avoid redefining the whole network every time a layer becomes trainable or not, I have added a rebuild function:
class Sequential(Layer):
...
    def add(self, layer):
        self.layers.append(layer)
        if len(self.layers) > 1:
            self.layers[-1].set_previous(self.layers[-2])
            if not hasattr(self.layers[0], 'input'):
                self.set_input()
        layer.init_updates()

        params, regularizers, constraints, updates = layer.get_params()
        if layer.trainable:
            self.params += params
            self.updates += updates

        self.regularizers += regularizers
        self.constraints += constraints

    def rebuild(self):
        layers = self.layers
        self.layers = []
        self.params = []
        self.regularizers = []
        self.constraints = []
        self.updates = []

        for layer in layers:
            self.add(layer)

I made a couple tests on the mnist example and it seems to work.
Do you see any possible issue?

@mmmikael I believe this should work (at first glance). But you'll need to recompile your network after rebuild every time.

@mmmikael I believe this should work (at first glance). But you'll need to recompile your network after rebuild every time.

Yes, I have actually added some code at the end of rebuild to invalidate the compiled Theano functions of the model:
    if hasattr(self, '_train'):
        del self._train
    if hasattr(self, '_train_with_acc'):
        del self._train_with_acc
    if hasattr(self, '_predict'):
        del self._predict
    if hasattr(self, '_test'):
        del self._test
    if hasattr(self, '_test_with_acc'):
        del self._test_with_acc

Is it possible to only freeze a subset of weights during training?

@mathDR you can freeze the weights of specific layers with the trainable argument http://keras.io/layers/core/.


nbclassic 0.4.3

Changelog: https://github.com/jupyter/nbclassic/blob/v0.4.3/CHANGELOG.md
License: https://github.com/jupyter/nbclassic/blob/main/LICENSE
Requirements:

https://github.com/jupyter/nbclassic/blob/v0.4.3/pyproject.toml
https://github.com/jupyter/nbclassic/blob/v0.4.3/setup.cfg
https://github.com/jupyter/nbclassic/blob/v0.4.3/setup.py

Actions:

Remove noarch python
Skip py<37
Add new entry_points
Add babel to host
Update run dependencies
Add new commands
Fix home url

conda.exceptions.ResolvePackageNotFound:
  - notebook-shim[version='>=0.1.0']

We need to add notebook-shim >=0.1.0


add border to logging output

resolves #76

All tests are passing and the tool still runs. The logging output is now much easier to read. Good work!


feat: Buffer <-> Blob conversions

This change introduces functions in the Buffer module for converting blobs to buffers and back.

I think it would make sense to introduce a BytesBuffer/BlobBuffer (sub)type with its own (sub)module in Buffer.mo.
This would not convolute the Buffer interface with blob-specific functionality.

I think it would make sense to introduce a BytesBuffer/BlobBuffer (sub)type with its own (sub)module in Buffer.mo. This would not convolute the Buffer interface with blob-specific functionality.

Wouldn't BytesBuffer be 90% the same as Buffer, making it an unnecessary burden to maintain?

I was thinking about something like this:
module {

  // all the buffer related functions + class.

  public type BytesBuffer = Buffer<Nat8>;

  public module Bytes = {
      /// Appends a blob to a byte buffer.
      public func appendBlob(buffer : BytesBuffer, blob : Blob) {
        for (byte in blob.vals()) {
          buffer.add(byte);
        }
      };

      /// Constructs a byte buffer from a blob.
      public func fromBlob(blob : Blob) : BytesBuffer {
        let buffer = Buffer<Nat8>(blob.size());
        Bytes.appendBlob(buffer, blob);
        buffer;
      };

      /// Constructs a blob from a byte buffer.
      public func toBlob(buffer : BytesBuffer) : Blob {
        Prim.arrayToBlob(buffer.toArray())
      };
  };
}

This way the following does not exist:
Buffer.appendBlob(buf, b) // ❌

But the following does:
Buffer.Bytes.appendBlob(buf, b) // ✅


Authority supported test flag now DOES_NOT_SUPPORT

Renames FEATURE_MASK_SUPPORTS_AUTHORITY_HEADER to FEATURE_MASK_DOES_NOT_SUPPORT_AUTHORITY_HEADER. This simplifies the vast majority of fixtures as they no longer need to mention this flag: the only fixture that doesn't support authority header is the Cronet fixture.
Inspired by comments in https://github.com/grpc/grpc/pull/10090

I think there are missing fixes. See test failures.

Yep, updated test/core/end2end/end2end_test_utils.c

Cleaning up old PRs.  If this is still something you want to pursue, please re-open.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @rjshade isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot


Update CommandList.js

Cosmetic changes. Wrong pseudo graphics symbols edited, multiply "console.log" statements removed

+1 for the \n breaks instead of re-writing console.log each time.

@Gimmo Great job! I've never even thought of that before :P


Training Parse Model with torch 1.7.0

Looks like the parse model has an issue training with torch 1.7.0.  torch 1.6.0 should work.
Error message when training with torch 1.7.0
Traceback (most recent call last):
File "./20_Train.py", line 14, in
File "/home/bjascob/Files/Projects/AMR/012_AMRLib_GitHub/amrlib/models/parse_gsii/trainer.py", line 114, in run_training
loss.backward()
File "/home/bjascob/.local/lib/python3.8/site-packages/torch/tensor.py", line 221, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/home/bjascob/.local/lib/python3.8/site-packages/torch/autograd/init.py", line 130, in backward
Variable._execution_engine.run_backward(
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [24, 129, 1536]], which is output 0 of AddBackward0, is at version 2; expected version 1 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

Issue (temporarily?) fixed by replacing chunk with unsafe_chunk in transfomer.py::in_proj_qkv

Complete with release of amrlib 0.2.2


Authentication token request not working

I'm trying to request an access token as described in the documentation: Link.
The following request should be accurate according to the documentation. I tested to remove the redirect_uri, changed "code" with "authorization_code" similar to the example in the documentation, requested new client credentials and created a new API App for entirely new credentials. Nothing worked...
Request:
curl -X POST -H "Accept: application/json;charset=UTF-8" -H "Content-Type: application/x-www-form-urlencoded" -H "Authorization: Basic <Base64encoded(<client_id>:<client_secret>)>" -d 'grant_type=authorization_code&redirect_uri=<redirect_url>&code=<code>' 'https://polarremote.com/v2/oauth2/token'
Resposne: (400)
"error": "invalid_request"

I'm facing the same issue here too. Tried everything - the requests keeps throwing Response: 400.

I was in contact with the Polar help desk regarding this issue. Here are some hints provided by them to solve the problem: (Spoiler: It was not helpful to solve my case.)

Authorization code  expires in 10 minutes. This code must only be used once. If it's used more than once, the request will be denied and ALL issued tokens will be deleted. If an error occurs, this parameters is not present.
You don't need to specify the redirect_uri parameter as the authorization callback domain you specified with the admin tool in client settings will be used anyway. If you use redirect_uri parameter then it must match the authorization callback domain because, unfortunately, dynamic redirect_uris are not supported.
If the request still doesn't work, please make sure you don't have any extra spaces or characters for example in the authorization code.
Also make sure the body content is either plain text or x-www-form-urlencoded

Thank you very much for sharing this @GenBob! I tried these but it did not work for me too. I will keep looking for solutions.

Did polar make a change to their authorization api?
Previously, I used the parameter "redirect_uri" successfully, but now that does not work. However, "redirect_url" appears to work instead.

It's still redirect_uri but (if provided) it needs to match the authorization redirect URL configured for the client. You can use https://admin.polaraccesslink.com/ to modify your existing client and change the redirect URL. By editing the client you can also add multiple redirect URLs in which case the parameter needs to match one of those.
I think that if you use something else, like redirect_url it will be discarded. Basically you would use redirect_uri if you have multiple redirect URLs specified for the client and want to use specific URL. Otherwise the one set as default will be used.


ENABLE_REVERSE_PROXY_AUTO_REGISTERATION seems to not work in <IP_ADDRESS>5

Gogs version (or commit ref): <IP_ADDRESS>5
Git version:  2.1.4
Operating system: debian 8
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

app.ini: https://gist.github.com/dl5rcw/057fa403a81667ebe743a5d066dbf905
gogs.conf (apache): https://gist.github.com/dl5rcw/e506b5db4ff31baa283acc1fdce6597e
Description

I am using gogs with Apache 2.4 reverse proxy mode. Works very well.
I then created the first user and configured the reverse proxy with the REMOTE_USER passed on as described in the gogs project. This also works very well now.
I then configured the option ENABLE_REVERSE_PROXY_AUTO_REGISTRATION in custom/conf/app.ini (and again restarted apache2 + gogs). When I tried to log in as a new user (that successfully authenticates elsewhere used in our intranet), the new user was not created and I was presented the default first page of gogs with no user logged in.
I now tested my first user from different machines to verify that this was still working -> this was the case.
There are no relevant log entries in gogs/log/*log. Even if I put the log level to Trace in the custom/conf/app.ini file (and restart reservices + search the logs). Viewing the source code, there should be an error reported to the log when the user creation fails - so I guess it is not even attempting to auto create the user?
Question: Is this a bug and the config option not interpreted correctly? Did I miss out on something in the config files?

...

I did a copy and paste mistake when reading the gogs threat about PROXY AUTH on #165. When I removed the 'E' in ENABLE_REVERSE_PROXY_AUTO_REGISTERATION -> it works.
Sorry for this false report. Thanks for gogs!


Experiment: Switch RNG from ecuyer1988 to mixmax

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
Experiment to see how viable it is to change RNGs, see #3167 and discussion.
Also needs https://github.com/stan-dev/stanc3/tree/experiment/mixmax-rng
Intended Effect
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

This seems fine up to the performance tests, which don't yet pass on the stanc3_bin_url parameter so can't be run yet.
I had to revert some of the tests to using ecuyer1988 in e026895 because a fair number of tests here seem to have "magic" seeds and assert on certain values, and I cannot tell if those values were derived somehow of if the existing output was just frozen in the tests

Interesting: Up at the performance-tests-cmdstan level, this change had two models fail https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FCmdStan Performance Tests/detail/downstream_tests/391/pipeline
One of them is a data generation model which heavily uses RNGs, so it is expected that it would likely change. The other is low_dim_gauss_mix_collapse (here)

Closing for now, if we ever wanted to make this change it seems like we'd just need to update the magic numbers in a few of our tests


feat: replace by fee

Try out this version of the Hiro Wallet - download extension builds.

This is the PR to implement replace by fee. I had to do some refactoring to how we constructed our transactions from within the extension in comparison to how we did it when constructing them from a request from an app. I've removed the two hooks that were previously used to generate a STX token transfer, or a FT token transfer, and converted them over to atoms which use the same generateSignedTransaction method as an app based tx request.
I've added the functionality in the "Preview" drawer as up until that point, we don't have a signed transaction and thus we're not able to know the current fee. We can do a larger refactor if we want to be able to calculate this before hitting the "preview" button, but I didn't think we could do it in the timeframe requested.
Here are some videos:
https://user-images.githubusercontent.com/11803153/131427312-8cfd5ab5-ba5a-435c-8e43-e8d27e5410a0.mp4
https://user-images.githubusercontent.com/11803153/131427322-9a742bc6-f5d1-4e7f-a7fe-4bbbde139ae3.mp4
I made a lot of progress, but still plenty to do. @kyranjamie or @beguene please feel free to take any of these while I sleep:
Todo:

[ ] add edit nonce functionality
[ ] add validation for when fee increases (if a user hits "send max" we need to recalculate the max they can send and the fee
[ ] fix tests
[ ] add the pending transaction flow (take an existing pending transaction rawtx, serialize it, get the values, and show the nonce/fee drawer
[ ] general clean up

cc/ @aulneau @kyranjamie @fbwoolf

@kyranjamie I am working on

[ ] add edit nonce functionality

Good job @aulneau, I'm going to test Fara's change to connect/wallet, and add the conditional logic to show fee warning in the other PR

I am getting rate limited by the numerous calls to https://stacks-node-api.testnet.stacks.co/v2/fees/transfer. I suspect a multiple rendering issue. Looking into it.

I am getting rate limited by the numerous calls to https://stacks-node-api.testnet.stacks.co/v2/fees/transfer. I suspect a multiple rendering issue. Looking into it.

We won't need to call this endpoint with the forthcoming fee changes fyi

@kyranjamie Do you know where in the code this endpoint is called ? I can't seem to find it...

Looking good 👏
Note that the copy for a new transaction should be different than selecting "replace by fee" for an existing / pending transaction.
Instead of "If your transaction has been pending for a long time, its fee might not be high enough. To speed it up, increase the fees and send it again", let's say: "Apply a higher fee to help your transaction confirm quickly, especially when the network is congested by other transactions."

@kyranjamie Do you know where in the code this endpoint is called ? I can't seem to find it...

Its unfortunately in stacks.js itself

@kyranjamie Do you know where in the code this endpoint is called ? I can't seem to find it...

Its unfortunately in stacks.js itself

Yes indeed, I found out finally ! it's implicitly called from makeContractCall

@kyranjamie Do you know where in the code this endpoint is called ? I can't seem to find it...

Its unfortunately in stacks.js itself

Yes indeed, I found out finally ! it's implicitly called from makeContractCall

Yeah it's in all of the tx builder methods exposed by stacks/transactions

but it only requests if you don't set a fee, right? 🤔

but it only requests if you don't set a fee, right? 🤔

No, I think every time you call it...it's not a great pattern to make the stack.js make a request...it should just return the transaction without side effects

it should just return the transaction without side effects

Agreed.

@beguene @kyranjamie I was mistaken, if we pass a value it should not fetch a fee -> https://github.com/blockstack/stacks-wallet-web/commit/98b96a086b13ffe3dc281cded2122ddb2a5d27da fixes it


Feature add bower js library

no long use /ls/library/*

@varffs what about modules that are not on bower but on npm?

like what? this is for js frontend lib stuff where everything is gonna be in bower

I don't have an example right now but I think it has happened to me before. NPM is not exclusevly for node nor backend.

What if the module is not on either?

then thats a ballache that we have to solve at the time. but as you can install from git repos I'm sure its ok https://bower.io/docs/api/#install

even just urls

rtfm etc etc

Oh cool
What are the steps to do this? should it be in the README?

ah yh def. I'll add that

@varffs check changes and merge


FeatureR: getNodeAt(pos)

FeatureRequest
What did you do?
Tried calling the function getNodeAt(Pos) after the event "oncontext" to get the Node at a certain position.
What did you expect to happen?
Getting the Node
What happened instead?
Method is not implemented
Your Environment
Angular version: 5.1.1
NodeJS and NPM version: 5.5.1

available in version 0.2.0


Can't tap Return on iOS keyboard due to visibility check

What happened?
Attempt to tap the Return button on the iOS keyboard with:
await element(by.label('return')).tap();

fails with:
View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.
The following works fine:
await element(by.label('return')).tap({ x: 20, y: 20 });

The attributes of the element are:
{
  visible: true,
  hittable: true,
  enabled: true,
  className: 'UIAccessibilityElementKBKey',
  label: 'return',
  isAccessibilityElement: true,
  elementSafeBounds: { y: 169, x: 295, width: 98, height: 46 },
  frame: { y: 730, x: 295, width: 98, height: 46 },
  identifier: 'Return',
  activationPoint: { x: 344, y: 192 },
  normalizedActivationPoint: { x: 0.5, y: 0.5 }
}

What was the expected behaviour?
No response
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
Try to tap Return on iOS keyboard on iPhone 15 (iOS 17.5).
In what environment did this happen?
Detox version: 20.25.1
React Native version: 0.71.12
Has Fabric (React Native's new rendering system) enabled: no
Node version: 22.5.1
Device model: iPhone 15
iOS version: 17.5
macOS version: Sonoma 14.6.1
Xcode version: 15.4
Test-runner (select one): jest
Detox logs
Detox logs
paste logs here!

Device logs
Device logs
12:26:00.891 detox[11851] E ws-client get element attributes
12:26:00.893 detox[11851] i user {
  visible: true,
  hittable: true,
  enabled: true,
  className: 'UIAccessibilityElementKBKey',
  label: 'return',
  isAccessibilityElement: true,
  elementSafeBounds: { y: 169, x: 295, width: 98, height: 46 },
  frame: { y: 730, x: 295, width: 98, height: 46 },
  identifier: 'Return',
  activationPoint: { x: 344, y: 192 },
  normalizedActivationPoint: { x: 0.5, y: 0.5 }
}
  origin: at e2e/utils/keyboard.ts:23:36
12:26:00.894 detox[11851] i ws-client send message
  data: {"type":"invoke","params":{"type":"action","action":"tap","predicate":{"type":"label","value":"return","isRegex":false}},"messageId":23}

 RUNS  e2e/tests/organicRegistration.e2e.ts
12:26:00.895 detox[11847] i ws-server@52866 get
12:26:00.895 detox[11851] B ws-client tap:"action","action":"tap","predicate":{"type":"label","value":"return","isRegex"  data: {
    "type": "action",
    "action": "tap",
    "predicate": {
      "type": "label",
      "value": "return",
      "isRegex": false
    }
  }
  stack: closeKeyboard (/e2e/utils/keyboard.ts:20:43)
  processTicksAndRejections (node:internal/process/task_queues:95:5)
  /e2e/tests/organicRegistration.e2e.ts:122:17

 RUNS  e2e/tests/organicRegistration.e2e.ts
12:26:00.895 detox[11847] i ws-server@52886 send
  data: {
    "type": "invoke",
    "params": {
      "type": "action",
      "action": "tap",
      "predicate": {
        "type": "label",
        "value": "return",
        "isRegex": false
      }
    },
    "messageId": 23
  }
12:26:00.908 detox[11847] i ws-server@52886 get
  data: {"params":{"DetoxFailureInformation":{"object":"<UIKeyboardLayoutStar: 0x15805e800; frame = (0 0; 393 233); opaque = NO; gestureRecognizers = <NSArray: 0x600002ade670>; layer = <CALayer: 0x60000239ad40>>","selector":"dtx_assertHittableAtPoint:","lineNumber":546,"file":"UIView+DetoxUtils.m"},"details":"View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.","NSLocalizedDescription":"View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}."},"messageId":23,"type":"testFailed"}
12:26:00.908 detox[11847] i ws-server@52866 send
  data: {
    "params": {
      "DetoxFailureInformation": {
        "object": "<UIKeyboardLayoutStar: 0x15805e800; frame = (0 0; 393 233); opaque = NO; gestureRecognizers = <NSArray: 0x600002ade670>; layer = <CALayer: 0x60000239ad40>>",
        "selector": "dtx_assertHittableAtPoint:",
        "lineNumber": 546,
        "file": "UIView+DetoxUtils.m"
      },
      "details": "View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.",
      "NSLocalizedDescription": "View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}."
    },
    "messageId": 23,
12:26:00.909 detox[11851] i ws-client get message
  data: {"params":{"DetoxFailureInformation":{"object":"<UIKeyboardLayoutStar: 0x15805e800; frame = (0 0; 393 233); opaque = NO; gestureRecognizers = <NSArray: 0x600002ade670>; layer = <CALayer: 0x60000239ad40>>","selector":"dtx_assertHittableAtPoint:","lineNumber":546,"file":"UIView+DetoxUtils.m"},"details":"View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.","NSLocalizedDescription":"View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}."},"messageId":23,"type":"testFailed"}

12:26:00.911 detox[11851] E ws-client tap
  error: Test Failed: View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.
12:26:00.911 detox[11851] E user NameDetails screen - full name split error message is visible after clearing last name and tapping submit
  error: Test Failed: View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.
12:26:00.912 detox[11851] B artifacts-manager onTestFnFailure
  args: ({"error":{"name":"DetoxRuntimeError"}})
12:26:00.913 detox[11851] E artifacts-manager onTestFnFailure
12:26:00.913 detox[11851] E lifecycle test_fn
  error: Test Failed: View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.
12:26:00.915 detox[11851] B artifacts-manager onTestDone
  args: ({"title":"test form validation, screen navigation and components","fullName":"Organic registration test form validation, screen navigation and components","status":"failed","invocations":1,"timedOut":false})
12:26:00.916 detox[11851] E artifacts-manager onTestDone
12:26:00.917 detox[11851] E lifecycle test form validation, screen navigation and components
12:26:00.917 detox[11851] i lifecycle Organic registration: test form validation, screen navigation and components [FAIL]
12:26:00.919 detox[11851] B lifecycle afterAll
12:26:00.919 detox[11851] B device terminateApp
  args: ()
12:26:00.919 detox[11851] B artifacts-manager onBeforeTerminateApp
  args: ({"deviceId":"A5929223-8D2D-4DE0-B55C-103E36EFF83A","bundleId":"uk.co.credabilityapptest"})
12:26:00.920 detox[11851] E artifacts-manager onBeforeTerminateApp
12:26:00.920 detox[11851] i child-process:EXEC_CMD /usr/bin/xcrun simctl terminate A5929223-8D2D-4DE0-B55C-103E36EFF83A uk.co.credabilityapptest
12:26:00.920 detox[11851] i child-process:EXEC_TRY Terminating uk.co.credabilityapptest...

 RUNS  e2e/tests/organicRegistration.e2e.ts
12:26:01.146 detox[11847] i ws-server app exited session 5d87e6e6-90a4-ed5e-0d93-bd6ebfd10932
12:26:01.146 detox[11847] i ws-server@52866 send
  data: {
    "type": "appDisconnected"
12:26:01.146 detox[11851] i ws-client get message
  data: {"type":"appDisconnected"}

12:26:01.151 detox[11851] i child-process:EXEC_SUCCESS uk.co.credabilityapptest terminated
12:26:01.152 detox[11851] B artifacts-manager onTerminateApp
  args: ({"deviceId":"A5929223-8D2D-4DE0-B55C-103E36EFF83A","bundleId":"uk.co.credabilityapptest"})
12:26:01.152 detox[11851] E artifacts-manager onTerminateApp
12:26:01.152 detox[11851] E device terminateApp
12:26:01.152 detox[11851] E lifecycle afterAll
12:26:01.152 detox[11851] B artifacts-manager onRunDescribeFinish
  args: ({"name":"Organic registration"})
12:26:01.152 detox[11851] E artifacts-manager onRunDescribeFinish
12:26:01.152 detox[11851] E lifecycle Organic registration

12:26:01.153 detox[11851] B artifacts-manager onRunDescribeFinish
  args: ({"name":"ROOT_DESCRIBE_BLOCK"})
12:26:01.153 detox[11851] E artifacts-manager onRunDescribeFinish
12:26:01.153 detox[11851] E lifecycle run the tests
12:26:01.161 detox[11851] B lifecycle tear down environment
12:26:01.162 detox[11851] B artifacts-manager onBeforeCleanup
  args: ()
12:26:01.162 detox[11851] E artifacts-manager onBeforeCleanup

 RUNS  e2e/tests/organicRegistration.e2e.ts
12:26:01.163 detox[11851] i ipc dispatching event to  primary-11847 /tmp/detox.primary-11847  :  deallocateDevice , {
  deviceCookie: {
    id: 'A5929223-8D2D-4DE0-B55C-103E36EFF83A',
    udid: 'A5929223-8D2D-4DE0-B55C-103E36EFF83A',
    type: 'ios.simulator'
  }
}

 RUNS  e2e/tests/organicRegistration.e2e.ts
12:26:01.164 detox[11847] i ipc received event of :  deallocateDevice {
  deviceCookie: {
    id: 'A5929223-8D2D-4DE0-B55C-103E36EFF83A',
    udid: 'A5929223-8D2D-4DE0-B55C-103E36EFF83A',
    type: 'ios.simulator'
  }
}
12:26:01.164 detox[11847] B device@0 free: A5929223-8D2D-4DE0-B55C-103E36EFF83A
  data: {}
12:26:01.165 detox[11851] i ipc ## received events ##D2D-4DE0-B55C-103E36EFF83A
12:26:01.165 detox[11851] i ipc detected event deallocateDeviceDone {}
12:26:01.165 detox[11851] E lifecycle tear down environment
12:26:01.166 detox[11851] E lifecycle e2e/tests/organicRegistration.e2e.ts
 FAIL  e2e/tests/organicRegistration.e2e.ts (41.11 s)
  Organic registration
    ✕ test form validation, screen navigation and components (10030 ms)

  ● Organic registration › test form validation, screen navigation and components

    Test Failed: View is not hittable at its visible point. Error: Failed to interact with the screen at point: {639, 361}.

      18 |             .getAttributes()
      19 |             .then((res) => console.log(res));
    > 20 |         await element(by.label('return')).tap();
         |                                           ^
      21 |         // await element(by.label('return')).tap({ x: 20, y: 20 });
      22 |     }
      23 | };

      at closeKeyboard (utils/keyboard.ts:20:43)
      at tests/organicRegistration.e2e.ts:122:17

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        41.377 s

More data, please!
ui.viewhierarchy.zip

await element(by.id('my_input_field')).tapReturnKey()
this worked for me⬆


chore: Added data-test attributes for testing

SUMMARY

Added test attribute for cypress testing.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

I'd merge quickly if checks passed as this is likely to conflict with everything. Wondering why you didn't approach this with a set of smaller PRs to start with.

Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this.

Codecov Report

Merging #11254 into master will decrease coverage by 5.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11254      +/-   ##
==========================================
- Coverage   65.57%   59.81%   -5.77%
==========================================
  Files         831      393     -438
  Lines       39514    24818   -14696
  Branches     3598        0    -3598
==========================================
- Hits        25913    14845   -11068
+ Misses      13492     9973    -3519
+ Partials      109        0     -109

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
59.81% <ø> (-0.95%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/databases/commands/create.py
82.97% <0.00%> (-8.52%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/connectors/sqla/models.py
83.53% <0.00%> (-6.21%)
:arrow_down:

superset/databases/api.py
85.10% <0.00%> (-4.26%)
:arrow_down:

superset/utils/celery.py
82.14% <0.00%> (-3.58%)
:arrow_down:

superset/models/core.py
85.75% <0.00%> (-3.36%)
:arrow_down:

... and 401 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7392e...f0c0528. Read the comment docs.

Is this a re-work of #11254? Just trying to figure out if this needs to be thoroughly reviewed again, or if it's the same stuff, split out. I'd still honestly rather just finish up the prior one, if it's all the same. Not sure if you or others have feelings on this.

I fixed review findings and splitted change related to attribute from #11134 into this PR and next I will submit test code using these attributes. It will be easier now when this will be merged - smaller changes then I think. Please for green light for this and merging to avoid conflicts - real blocker for me in pushing forward.

Aside from the aforementioned tweaks/questions/suggestions, this LGTM. Let's tie up those loose ends and merge this thing! 🚀

I'll merge this if/when the light turns green :D


Develop --> Master

@hasueki Which component is validating this CRD? There are a lot of permutations of possible inputs since everything is optional. Lot of ways for customer to shoot themselves in the foot. e.g. defining serviceInstanceCRN along with an improper resourceGroupName or location. It's unclear from the description the effect that defining one field has on others.

@BobbyRadford From a CRD perspective, I think the most validation we can add will just be a simple string pattern check - which probably is a good idea. Most of the validation you're thinking of will happen in the cluster-image-registry-operator itself, since it is the core component that consumes this API.


[Toyota car bug] openpilot can be engaged at zero speed with no lead

Describe the bug

openpilot can be engaged at zero speed with no lead by releasing the brakes and pressing the cruise control stalk.
How to reproduce or log data

stop on hill without lead
release brakes (car will not move forward as it's on a hill, so zero speed)
engage adaptive cruise
openpilot engages and immediately goes into resume mode (with comma pedal it presses on the pedal and the car goes out of standstill)

Expected behavior

openpilot should display "no close lead" and force acc to disengage
Device/Version information (please complete the following information):

Device: comma two
Dongle ID: 399b1cca765e80b4
Version: all versions seem to be affected
Car make/model: Toyota Prius 2018

Additional context

This has been a problem since I firstly started to use openpilot

Sounds like a bug with the standstill. Got a specific route?

No, unfortunately my device can't upload routes to the servers, I can drop a route to a member on discord if that's fine. This is quite easy to reproduce on a TSS-P vehicle though.

Unfortunately I've seen this on TSS2 as well. On some hills, the car does not respond to our acceleration requests and is unable to get the vehicle moving, not sure if it's related to the car moving backwards.

This is a non issue on stock since the stock system manipulates the lead signal at low speeds, unlike openpilot which sets it to 1 all the time. A very simple solution is that openpilot can just set the lead bit to 0 when the vehicle is stopped (vEgo=0) and there's no lead

The cause of this issue is partially openpilot, but also partially the vehicle. If you send a blank ACC_CONTROL (except MINI_CAR = 1) and engage ACC while stopped without pressing the brakes, the car will also go into resume mode.

We can already cancel cruise when the user is trying to engage without a lead with the brake pressed, so this should be a pretty easy fix

This can be fixed with a one line change in car controller:
lead = hud_control.leadVisible or (CS.out.vEgo < 12. and not (CS.out.vEgo == 0 and not hud_control.leadVisible))

we allow enabling without a lead at a stop, this should be fine to close now. let me know if there's another non-obvious issue here
https://github.com/commaai/openpilot/pull/26632


NFT not showing up under Collectibles

Sent my NFT to my 1wallet, but it doesn't show up under collectibles. I can see it on the block explorer that it has been received.

What's your wallet address, and transaction id for the NFT transfer?

one1ah8kyf4weg08pcpjepeytarre7t55jwnaln4f4
0x1a5c96d7730a4f9d0688989ce65c6aca8b1cfd172ffb430483c43f3e88de217a

When I query your 1wallet address one1ah8kyf4weg08pcpjepeytarre7t55jwnaln4f4, it shows that the wallet has no "tracked tokens". This means the collectible's smart contract in question (ONECAN, at 0xf80790b2afc34390d5af12a3a332d12ff1886b42) does not implement ERC721 standard correctly even though it self-proclaims as a ERC721 NFT, since it does not call  onERC721Received of the recipient's address. See also https://docs.openzeppelin.com/contracts/2.x/api/token/erc721#IERC721Receiver-onERC721Received-address-address-uint256-bytes-
I can add a button later that let you manually track the token, so that it can be displayed in the wallet.

For further reference, the transfer transaction is https://explorer.harmony.one/tx/0x1aa7794df16e98fd8020a791028a6d504f3b853656d94193b7deaf6d6da5a79f?activeTab=2 . It shows a Transfer event was emitted, but the "Internal Transaction" tab shows the contract did not call onERC721Received as required by the spec.

im having the same issue
wallet: one12afme6c9c4m9yll30wktrattvnv6suglan4gae
transaction: https://explorer.harmony.one/tx/0xf59fc775e83448688af1b95e4b3ba3db519d58df8cc3fb2f3d0f9fb0f68571ad

It was for the same reason. Were these things made by the same people?

@polymorpher it may seems that to be the case. but sending the same nft to metamask wallet has nno issue
it will be able to display the nft in the wallet
and if you go to the wallet address in harmony explorer, you will be able to see the HRC721 token in the wallet
im not very clear with the technical intricacies, will you be able to shed some lights on this matter?

The apps (in this case, the NFT websites) generally notifies MetaMask when the NFT is purchased or interacted with using MetaMask. Upon receiving these notifications, MetaMask keeps a local record of what NFTs it should track. When the user enters the MetaMask wallet, it would look up what was tracked, read from the corresponding contracts, and display the NFT and the user's balance accordingly.
In contrast, 1wallet does not get an opportunity to be notified like MetaMask, unless the app specifically implements 1wallet integration to notify 1wallet. Instead of relying on app's voluntary integrations, 1wallet also implements standard interfaces according to the ERC721 and 1155 specs to receive notification on-chain when an NFT is transferred to 1wallet.  See also https://github.com/polymorpher/one-wallet/wiki/Token-Tracking. NFT contracts that implement the ERC721 and 1155 specs correctly would automatically notify 1wallet on-chain upon any event of mint or transfer. But a small portion of NFT contracts may fail to follow the spec when they implement their mint and transfer functions. In this case, the manual tracking solution as I proposed in previous comments should be a sufficient remedy.
The explorer functions differently. It runs on a server, and has the luxury to read, track, and parse all transactions processed on-chain. 1wallet is meant to be server-less and does not hav the luxury. Accordingly, the explorer may monitor on-chain event emissions and compute balance of all accounts (1wallet or not). But since it relies on event emissions, it can be fooled using forged event names and signatures, and so the balance it computes may be inaccurate. For the purpose of block explorer, inaccuracy is acceptable. For wallet, it would not be. Therefore I decided not to use information from the block explorer directly, though in the future I may utilize their APIs to complement tracking. Another downside of the explorer is its monitoring and indexing of the event emissions are often delayed, and may neglect many types of NFTs. During testing, I found many NFTs I implemented for testing was not correctly tracked by the explorer.

Were these NFTs sent with the safeTransferFrom or the transferFrom function?

Were these NFTs sent with the safeTransferFrom or the transferFrom function?

I think I saw signatures of these functions in transaction history / log. Need to double check again.

https://github.com/polymorpher/one-wallet/pull/154 added buttons to let users track/untrack NFT and tokens manually. The tracking is local - so the wallet smart contract won't be able to auto-transfer / auto-recover these NFTs when an upgrade or recovery is triggered. However, I will improve Upgrade process in the future to let users sync local/remote tracking states. I will also add a feature to let users inspect and control pre-upgrade wallets after they upgrade, so they can manually transfer out any asset left over.


Fix Client hanging after Client.destroy is invoked

Please describe the changes this PR makes and why it should be merged:
This PR fixes #1685 by clearing the timeout for resetTimer after the Status is set to DISCONNECTED.
I don't know if there's a better way to do this, but I tested it and it instantly closed after login failed (that is, if nothing else is happening in the backround)
Semantic versioning classification:

[x] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Ok @devsnek, but also, the destroy in RequestHandler is still a error that happens due to destroy not being defined. Want me to close this?


Handle an array of subscriptions?

Hey,
How hard would it be for you to implement handling an array of subscriptions?
I have a case where I have 3+ subscriptions, so I wouldn't wanna create a variable for each one of them.
If you're too busy, I can give it a go.
Thanks

What you are saying could work if we check that the property is an array and then if the values are subscriptions. ( I think it could be expensive unless you have something else in mind )
I would make it optional by passing a parameter to the decorator, something like:
@AutoUnsubscribe({
  includeArrays: true
})

I'd love to see PR.

#https://github.com/NetanelBasal/ngx-auto-unsubscribe/pull/12

Added in version 2.1.0.

@NetanelBasal I like your idea:

(Maybe we can force a name convention like **Subscriptions)

Then it doesn't have to loop through each property on the component? It could just loop through a this.subscriptions array. Thoughts?

Sounds good, would love to see a PR. :)

But it would also make sense to set the array name as option. So by default it would be subscriptions$ (or subscriptions), but user should be able to change that with an additional param.

@BBlackwo you should not prefix with $, it's subscriptions, not observables.


Azure core tracing - provide a context manager

Is your feature request related to a problem? Please describe.
There is the azure.core.tracing.distributed_trace decorator.
It is useful as a decorator, but often I would like a context manager, to be able to use it easily within a function, and to use the span object.
Describe the solution you'd like
Within distributed_trace, there is wrapper_use_tracer, which almost does exactly what I want, except it's internal, and isn't a context manager.
The internals of this method could easily become a context manager that returns a span, and distributed_trace could use that internally.
Describe alternatives you've considered
Currently I am copy-pasting the copy of wrapper_use_tracer, but it is not a good solution for the long run.
Additional context
I can contribute it myself, if there is an indication you want it.

Hi @AsafMah, thank you for the feature request! I'll tag folks from Core who can weigh in on this.


Bump inmanta-dev-dependencies[async,core,pytest] from 2.101.0 to 2.104.0 (#7037)

Pull request opened by the merge tool on behalf of #7037

Merged in ae61aa04b4b53447585a8ef055f5bb874dc6436e


iox-#1906 Use Ubuntu 20 for ROS GitHub action

Pre-Review Checklist for the PR Author

[ ] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Branch follows the naming format (iox-123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

This change is

Codecov Report

Merging #33 (d278407) into master (0487837) will increase coverage by 0.00%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   75.45%   75.45%
=======================================
  Files         383      383
  Lines       15178    15178
  Branches     2148     2148
=======================================
+ Hits        11452    11453    +1
  Misses       3055     3055
+ Partials      671      670    -1

Flag
Coverage Δ

unittests
75.11% <ø> (+<0.01%)
:arrow_up:

unittests_timing
15.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

iceoryx_hoofs/source/concurrent/loffli.cpp
90.90% <0.00%> (+3.03%)
:arrow_up:


Help with Quick Start S3

Hello, I am struggling to get it working with S3 with the quick start guide.
using the command weed server -dir=/mnt/md0/weed -s3 :
I0530 11:22:00.578774 master.go:269 current: <IP_ADDRESS>:9333 peers:
I0530 11:22:00.579036 file_util.go:27 Folder /mnt/md0/weed Permission: -rwxr-xr-x
I0530 11:22:00.579103 master.go:269 current: <IP_ADDRESS>:9333 peers:<IP_ADDRESS>:9333
I0530 11:22:00.579110 file_util.go:27 Folder /mnt/md0/weed Permission: -rwxr-xr-x
I0530 11:22:00.579257 master_server.go:132 Volume Size Limit is 30000 MB
I0530 11:22:00.579386 master.go:150 Start Seaweed Master 30GB 3.67 d3032d1e805ab363242c833d9a61db59b3941f21 at <IP_ADDRESS>:9333
I0530 11:22:00.579672 raft_server.go:118 Starting RaftServer with <IP_ADDRESS>:9333
I0530 11:22:00.579677 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:00.705880 raft_server.go:167 current cluster leader:
I0530 11:22:02.371913 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:02.581724 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:03.583904 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:04.163553 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:04.585436 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:05.586901 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:05.954839 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:06.589505 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:07.591210 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:07.746895 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:08.593247 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:09.539365 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:09.595611 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:10.597189 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 11:22:11.331283 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 11:22:11.598867 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888

Using sudo docker run -p 8333:8333 chrislusf/seaweedfs server -s3 does similar:
Unable to find image 'chrislusf/seaweedfs:latest' locally
latest: Pulling from chrislusf/seaweedfs
4abcf2066143: Pull complete
ca6b3f8259f9: Pull complete
37fec1776bf6: Pull complete
5ba4222983d4: Pull complete
ab509e4d4753: Pull complete
35d6c60aae92: Pull complete
5eb309764255: Pull complete
4f4fb700ef54: Pull complete
Digest: sha256:3a7d52b44301c787b581d7c4f791dd5b694e0c628ffbb9eb1ed23d28fa16de16
Status: Downloaded newer image for chrislusf/seaweedfs:latest
I0530 10:20:00.023275 master.go:269 current: <IP_ADDRESS>:9333 peers:
I0530 10:20:00.023337 file_util.go:27 Folder /data Permission: -rwxr-xr-x
I0530 10:20:00.023437 master.go:269 current: <IP_ADDRESS>:9333 peers:<IP_ADDRESS>:9333
I0530 10:20:00.023590 master_server.go:132 Volume Size Limit is 1024 MB
I0530 10:20:00.023501 file_util.go:27 Folder /data Permission: -rwxr-xr-x
I0530 10:20:00.024105 master.go:150 Start Seaweed Master 30GB 3.67 d3032d1e8 at <IP_ADDRESS>:9333
I0530 10:20:00.024862 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:00.024974 raft_server.go:118 Starting RaftServer with <IP_ADDRESS>:9333
I0530 10:20:00.026113 raft_server.go:167 current cluster leader:
I0530 10:20:01.816442 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:02.024939 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:03.027049 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:03.608051 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:04.028718 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:05.030278 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:05.399747 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:06.032700 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:07.034723 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:07.192204 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:08.035200 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:08.984409 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0530 10:20:09.036732 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0530 10:20:10.039201 s3.go:206 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888

weed version:
version 30GB 3.67 d3032d1e805ab363242c833d9a61db59b3941f21 linux amd64
system:
OS: Debian GNU/Linux 12 (bookworm) x86_64
Kernel: 6.1.0-20-amd64
CPU: Intel N100 (4) @ 3.400GHz
GPU: Intel Alder Lake-N [UHD Graphics]
Memory: 2899MiB / 15770MiB

there are many ports needed https://github.com/seaweedfs/seaweedfs/blob/master/docker/Dockerfile.local#L12


Get.changeTheme does not work in 5.0.0-release-candidate-5

Get.changeTheme does not work in 5.0.0-release-candidate-5, but it's fine in 4.6.6.
  GetMaterialApp(
    onInit: AppState.onInit,
    onReady: AppState.onReady,
    onDispose: AppState.onDispose,
    title: 'Flutter Demo',
    theme: lightTheme,
    darkTheme: darkTheme,
    home: const MyHomePage(title: 'Flutter Demo Home Page'),
  );

  void changeTheme() {
    Get.changeTheme(Get.isDarkMode ? lightTheme : darkTheme);
  }

Flutter Version:
3.16.0
Getx Version:
5.0.0-release-candidate-5

Does it work on the latest version 4.6.6, and do you need a hot reload to see the changes? Because when we use Get.changeTheme, changes apply only on hot reload.

Same here, my theme changes, but isDarkMode every time returns false.


Use standard Promise, drop When

Hello!
Why do we need when?
Developers prefer different implementation of Promises/A+. For example, we prefer Bluebird
But for client, I think better to use standard Promise to decrease bundle size with small polyfill. In any case, it is better not to impose a particular library

Seems like a very round about way of doing things. Personally I want babel to polyfill promises for me.


Problem with bind_addr if private network binds to eth1 interface

When I'm trying to create consul cluster on Soft Layer, it works fine 'cause private network binds to eth0.
But, for example, at Diagital Ocean private network binds to eth1 interface.
So, I see something like <IP_ADDRESS> in address when using consul members.
Mb change bind_addr declaration in consul.json.j2 to:
"bind_addr": {% for host in consul_servers %}{% if host in ansible_all_ipv4_addresses %}"{{host}}"{% endif %}{% endfor %},?

we also had issues because of the hardcoded eth0 logic in both initd/upstart init scripts (in our case actually it works on all hosts that do not have an eth0 .. and the ones that have, it's not THE expected interface , and bam, consul agent listens on a non-sense, non-configured iface)
the proper fix for this is to make a variable like consul_bind_iface to be used instead of all 'eth0' occurrences ...


Importing a glTF model: texture scaling is ignored

Godot version:
3.3.stable.mono.official
OS/device including version:

OS: Windows 10 (64-bit)
GPU: AMD (Gigabyte) Radeon RX 590
GPU driver: <IP_ADDRESS>-201027a-360165C-RadeonProEnterprise
Godot renderer backend: GLES3
Issue description:
Importing a glTF 2.0 model file into Godot does not take into account the scaling factor of materials. A texture that is normally tiled will simply be stretched when imported.
Viewing the model in another program, such as Blender 2.9 or the Windows 3D Viewer, will show the proper tiling.
Left: Windows 3D Viewer | Right: Godot 3.3

Steps to reproduce:
Import a .gltf or .glb file with some texture tiling into Godot.
Minimal reproduction project:

GLTF Import.zip

cc @fire

I and a peer are working on a Godot Engine gltf2 backport for 3.x. I believe this issue is resolved on master.
https://github.com/godotengine/godot/pull/34193
https://github.com/godotengine/godot/pull/46783

That's reassuring; I look forward to the next stable release.


InfluxDB 2.0: There is now way how to get version of InfluxDB from API [area/api]

The InfluxDB 1.7.x has defined /ping endpoint with X-Influxdb-Version header but in the API 2.0 there is no such thing.
The /health endpoint will be useful for that.

Related to https://github.com/influxdata/influxdb/issues/13747

+1

InfluxDB 1.8 "/health" endpoint already returns version:
{
"checks": [],
"message": "ready for queries and writes",
"name": "influxdb",
"status": "pass",
"version": "1.8.0"
}

Whereas the InfluxDB2.0 now returns
{
"name": "influxdb",
"message": "ready for queries and writes",
"status": "pass",
"checks": []
}

Adding a version string to 2.0 will fix this issue and make the health endpoint consistent with 1.8.


./autogen.sh: No such file or directory

Hello,
I'm not familiar with kotlin and gradle build, but I tried to build this lib using ./gradlew :build on my mac m1 (because https://github.com/ACINQ/secp256k1-kmp/issues/44#issuecomment-1094812174) and it results in

% ./gradlew :build

> Configure project :
Kotlin Multiplatform Projects are an Alpha feature. See: https://kotlinlang.org/docs/reference/evolution/components-stability.html. To hide this message, add 'kotlin.mpp.stability.nowarn=true' to the Gradle properties.

Project property 'kotlin.parallel.tasks.in.project' is deprecated.
By default it depends on Gradle parallel project execution option value.
Warning: Kotlin language settings function 'useExperimentalAnnotation' is deprecated and will be removed in next major releases. Please, use 'optIn' instead.

> Task :native:buildSecp256k1Ios FAILED
build-ios.sh: line 8: ./autogen.sh: No such file or directory

> Task :compileKotlinJvm UP-TO-DATE

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':native:buildSecp256k1Ios'.
> Process 'command 'bash'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 555ms
2 actionable tasks: 1 executed, 1 up-to-date
skipping android build%

Any advice for this error? Or is this related to the m1 chip architecture?
Thanks

You could be missing the secp256k1 source code which should be in native/secp256k1. We use a git submodule for that, when you clone the project you have to run:
git submodule init
git submdule update

You could be missing the secp256k1 source code which should be in native/secp256k1. We use a git submodule for that, when you clone the project you have to run:
git submodule init
git submdule update

Hi @sstone . I've done the steps above and also made sure that the https://github.com/bitcoin-core/secp256k1 (submodule) is pointing on master.
But I'm still having the same issue :native:buildSecp256k1Ios FAILED as @Dolu89 .
Thank you

Do you get the same error (build-ios.sh: line 8: ./autogen.sh: No such file or directory) ? Without more details it's difficult to understand what went wrong.

Do you get the same error (build-ios.sh: line 8: ./autogen.sh: No such file or directory) ? Without more details it's difficult to understand what went wrong.

Hello @sstone
It looks like ./autogen.sh: line 3: autoreconf: command not found error for me.
More error is shown here below:
./gradlew :build

> Configure project :
Kotlin Multiplatform Projects are an Alpha feature. See: https://kotlinlang.org/docs/reference/evolution/components-stability.html. To hide this message, add 'kotlin.mpp.stability.nowarn=true' to the Gradle properties.

Project property 'kotlin.parallel.tasks.in.project' is deprecated.
By default it depends on Gradle parallel project execution option value.
Warning: Kotlin language settings function 'useExperimentalAnnotation' is deprecated and will be removed in next major releases. Please, use 'optIn' instead.

> Task :native:buildSecp256k1Ios FAILED
./autogen.sh: line 3: autoreconf: command not found

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':native:buildSecp256k1Ios'.
> Process 'command 'bash'' finished with non-zero exit value 127

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 867ms
2 actionable tasks: 1 executed, 1 up-to-date
building android library

It looks like ./autogen.sh: line 3: autoreconf: command not found error for me.

You need to install the automake package.


Facing issues in AIP while building avs-device-sdk v1.7

Hi,
I am facing issues while building avs-device-sdk version 1.7.
Here are the console logs:-
Scanning dependencies of target KeywordDetectorProvider
[ 72%] Building CXX object KWD/KWDProvider/src/CMakeFiles/KeywordDetectorProvider.dir/KeywordDetectorProvider.cpp.o
Linking CXX shared library libKeywordDetectorProvider.so
[ 72%] Built target KeywordDetectorProvider
Scanning dependencies of target AIP
[ 73%] Building CXX object CapabilityAgents/AIP/src/CMakeFiles/AIP.dir/AudioInputProcessor.cpp.o
/home/harman/1.7_Alexa/sdk-source/avs-device-sdk/CapabilityAgents/AIP/src/AudioInputProcessor.cpp: In member function ‘void alexaClientSDK::capabilityAgents::aip::AudioInputProcessor::executeOnContextAvailable(std::string)’:
/home/harman/1.7_Alexa/sdk-source/avs-device-sdk/CapabilityAgents/AIP/src/AudioInputProcessor.cpp:637:29: error: ‘class alexaClientSDK::avsCommon::avs::MessageRequest’ has no member named ‘addAttachmentReader’
m_recognizeRequest->addAttachmentReader(KWD_METADATA_FIELD_NAME, m_KWDMetadataReader);
^
/home/harman/1.7_Alexa/sdk-source/avs-device-sdk/CapabilityAgents/AIP/src/AudioInputProcessor.cpp:639:25: error: ‘class alexaClientSDK::avsCommon::avs::MessageRequest’ has no member named ‘addAttachmentReader’
m_recognizeRequest->addAttachmentReader(AUDIO_ATTACHMENT_FIELD_NAME, m_reader);
^
make[2]: *** [CapabilityAgents/AIP/src/CMakeFiles/AIP.dir/AudioInputProcessor.cpp.o] Error 1
make[1]: *** [CapabilityAgents/AIP/src/CMakeFiles/AIP.dir/all] Error 2
make: *** [all] Error 2
Platform - ubuntu 32 bit
Version - 1.7
AIP is not able to compile. It tells alexaClientSDK::avsCommon::avs::MessageRequest’ has no member named ‘addAttachmentReader’.
Thanks,
Sumit

What version of gcc are you using?  We only support 4.8.5 and above: https://github.com/alexa/avs-device-sdk/wiki/Dependencies

I am cross compiling it for artik.
C Compiler - arm-linux-gnueabihf-gcc
C++ Compiler -  arm-linux-gnueabihf-g++

When I compile without Wake Word, again the build fails with similiar type of issue.
The logs are:-
Linking CXX executable CustomerDataManagerTest
[ 95%] Built target CustomerDataManagerTest
Scanning dependencies of target RegistrationManagerTest
[ 96%] Building CXX object RegistrationManager/test/CMakeFiles/RegistrationManagerTest.dir/RegistrationManagerTest.cpp.o
Linking CXX executable RegistrationManagerTest
[ 96%] Built target RegistrationManagerTest
Scanning dependencies of target SampleApp
[ 97%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/ConnectionObserver.cpp.o
[ 97%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/ConsolePrinter.cpp.o
[ 97%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/GuiRenderer.cpp.o
[ 98%] Building CXX object SampleApp/src/CMakeFiles/SampleApp.dir/InteractionManager.cpp.o
In file included from /home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:28:0,
from /home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:17:
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/KeywordObserver.h:49:10: error: ‘void alexaClientSDK::sampleApp::KeywordObserver::onKeyWordDetected(std::shared_ptr<alexaClientSDK::avsCommon::utils::sds::SharedDataStreamalexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits >, std::__cxx11::string, alexaClientSDK::avsCommon::utils::sds::SharedDataStreamalexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits::Index, alexaClientSDK::avsCommon::utils::sds::SharedDataStreamalexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits::Index, std::shared_ptr<const std::vector >)’ marked ‘override’, but does not override
void onKeyWordDetected(
^
In file included from /home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:17:0:
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:55:25: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface callManager = nullptr);
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:55:25: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:55:71: error: template argument 1 is invalid
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface callManager = nullptr);
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:236:21: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface m_callManager;
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:236:21: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:236:67: error: template argument 1 is invalid
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface m_callManager;
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/include/SampleApp/InteractionManager.h:55:87: error: could not convert ‘nullptr’ from ‘std::nullptr_t’ to ‘int’
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface callManager = nullptr);
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:32:21: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface callManager) :
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:32:21: error: ‘CallManagerInterface’ is not a member of ‘alexaClientSDK::avsCommon::sdkInterfaces’
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:32:67: error: template argument 1 is invalid
std::shared_ptravsCommon::sdkInterfaces::CallManagerInterface callManager) :
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp: In lambda function:
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:253:23: error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘isCommsEnabled’
if (m_client->isCommsEnabled()) {
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp: In lambda function:
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:263:23: error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘isCommsEnabled’
if (m_client->isCommsEnabled()) {
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:264:23: error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘acceptCommsCall’
m_client->acceptCommsCall();
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp: In lambda function:
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:273:23: error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘isCommsEnabled’
if (m_client->isCommsEnabled()) {
^
/home/harman/WithoutWWE/sdk-source/avs-device-sdk/SampleApp/src/InteractionManager.cpp:274:23: error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘stopCommsCall’
m_client->stopCommsCall();
^
make[2]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/InteractionManager.cpp.o] Error 1
make[1]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/all] Error 2
make: *** [all] Error 2

Can you provide the commands used to do the cmake and the build?
Thanks!

Hi,
Before cmake, export pkg config path where all .pc are present.
export PKG_CONFIG_PATH=/usr/arm-linux-gnueabihf/lib/pkgconfig:$PKG_CONFIG_PATH
The cmake command used while cross compiling:-
cmake -DCMAKE_TOOLCHAIN_FILE=/home/harman/toolchain.cmake /home/harman/1.7_Alexa/sdk-source/avs-device-sdk  -DCMAKE_INSTALL_PREFIX=/home/harman/build_alexa -DCMAKE_PREFIX_PATH=/home/harman/build_alexa -DSENSORY_KEY_WORD_DETECTOR=OFF -DGSTREAMER_MEDIA_PLAYER=ON -DPORTAUDIO=ON -DPORTAUDIO_LIB_PATH=/home/harman/build_alexa/lib/libportaudio.a -DPORTAUDIO_INCLUDE_DIR=/home/harman/build_alexa/include
toolchain.cmake file contents:-
INCLUDE(CMakeForceCompiler)
this one is important
SET(CMAKE_SYSTEM_NAME Linux)
set(CMAKE_SYSTEM_PROCESSOR arm)
#this one not so much
SET(CMAKE_SYSTEM_VERSION 1)
specify the cross compiler
SET(CMAKE_C_COMPILER   arm-linux-gnueabihf-gcc)
SET(CMAKE_CXX_COMPILER arm-linux-gnueabihf-g++)
where is the target environment
SET(CMAKE_FIND_ROOT_PATH  /usr/arm-linux-gnueabihf/)
search for programs in the build host directories
SET(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)
for libraries and headers in the target directories
SET(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
SET(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
This is working till avs-device-sdk v1.6.
Thanks,
Sumit

Hi,
The code base is latest as per 1.7 release and DefaultClient.h and .cpp files are latest as per 1.7 release.
All api's are present in DefaultClient but it is showing the following error:-
error: ‘class alexaClientSDK::defaultClient::DefaultClient’ has no member named ‘isCommsEnabled’
If I am compiling with Sensory Mode = ON, then the same issue is with AIP:-
error: ‘class alexaClientSDK::avsCommon::avs::MessageRequest’ has no member named ‘addAttachmentReader’
When I look into the code, the API 'addAttachmentReader' is already present in the file.
I have already attached the logs for both of the issues.
Is there other issue with namespace in 1.7 release?
Thanks,
Sumit

Hi,
This issue is fixed. There is a problem with include paths.
You can close this issue.
Thanks,
Sumit


Fix UnsignedInt scalar test suite

The UnsignedIntType test suite is failing. Inspect the failing test cases and determine the correct course of action.

Done :)


Happy new year! Update NOTICE year

2019->2020, happy new year :)

@kezhenxu94 @innerpeacez Please update the year of CLI and k8s subprojects too.

Codecov Report

Merging #4158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4158   +/-   ##
=======================================
  Coverage   26.86%   26.86%
=======================================
  Files        1160     1160
  Lines       25377    25377
  Branches     3680     3680
=======================================
  Hits         6818     6818
  Misses      17952    17952
  Partials      607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c20f4a...5f04ef1. Read the comment docs.


Native wayland support for yesplaymusic with newest electron

Electron 12 has native wayland support, wayland support for yesplaymusic would be great because it allows for better dpi scaling.
I could actually lauch the app with some extra options:
yesplaymusic --enable-features=UseOzonePlatform --ozone-platform=wayland, but it didn't funcition properly like a default launch, the title bar didn't appear either.
Thanks for keeping updating this wonderful project :)

We've upgraded Electron to v13.

The  --enable-features=UseOzonePlatform --ozone-platform=wayland flags are not working with electron v13 built from aur electron-13-bin. I tried electron-29-bin and those flags worked properly.


Runtime Error when running Spicetify Apply

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version: 1.1.85
- Spicetify version: 2.9.8
- Windows 11

📝 Description
Installation went fine, but when I ran spicetify apply I get this error:
PS C:\Users\*****> spicetify apply
spicetify v2.9.8
Overwriting raw assets:
OK
Transferring user.css:
OK
Applying additional modifications:
error cannot find symbol for Custom app React Element
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/spicetify/spicetify-cli/src/apply.insertCustomApp.func1({0xc000ab8000, 0x18aa98})
        /home/runner/work/spicetify-cli/spicetify-cli/src/apply/apply.go:220 +0x987
github.com/spicetify/spicetify-cli/src/utils.ModifyFile({0xc00000f040, 0x38}, 0xc0000cb8d8)
        /home/runner/work/spicetify-cli/spicetify-cli/src/utils/utils.go:191 +0x7b
github.com/spicetify/spicetify-cli/src/apply.insertCustomApp({0xc00000f040, 0x3b}, {{0xc00016a060, 0x1, 0x2}, {0xc00016a080, 0x1, 0x2}, 0x1, 0x1, ...})
        /home/runner/work/spicetify-cli/spicetify-cli/src/apply/apply.go:188 +0x90
github.com/spicetify/spicetify-cli/src/apply.AdditionalOptions({0xc00000cae0, 0x2b}, {{0xc00016a060, 0x1, 0x2}, {0xc00016a080, 0x1, 0x2}, 0x1, 0x1, ...})
        /home/runner/work/spicetify-cli/spicetify-cli/src/apply/apply.go:37 +0x4c3
github.com/spicetify/spicetify-cli/src/cmd.Apply({0x65b7f8, 0x5})
        /home/runner/work/spicetify-cli/spicetify-cli/src/cmd/apply.go:72 +0x9ae
main.main()
        /home/runner/work/spicetify-cli/spicetify-cli/spicetify.go:225 +0x77b

📸 Screenshots

Unrelated to marketplace.


Favicon not copied to dist folder

Favicon doesn't get copied to dist folder on production build.
Moving favicon.ico to assets folder solves the issue of course.
Potential solutions are to change blueprint and move file to assets by default or check why copying fails on --prod.
OS?
Windows 7 (others as well, but not tested)
Versions.
angular-cli: 1.0.0-beta.16
node: 5.10.1
os: win32 x64
Repro steps.
Run ng build --prod. Start the app from dist folder
The log given by the failure.
404 in browser for favicon.ico

This has been fixed in #2570 and will be released with beta 18. This issue can be closed.

beta.18 is out today and includes this fix! Just verified in my project.

^ what @grizzm0 and @Splaktar just said 💃
It's worth mentioning that it works because assets now accepts an array, meaning if you have an existing projects and want favicon to be copied, you should add it to the array as shows in #2570.


Is there support of sleep timer?

Most music players have the option of a sleep timer:

sleep after N number of songs
sleep at specified time

Since, the timer should work in background (MediaSessionService), I wanted to know if media3 supports sleep timers? If not, what is the preferred way for sleep timer to work with MediaSessionService?

Most music players have the option of a sleep timer:

An implementation by an app sounds pretty straight-forward to me, where calling stop() or play() would stop or pause the player, which then would take the service out of the foreground which makes the system terminate the service after a given time.
There isn't a way to let the player pause at a given time by API. There are APIs though that can help you do that.

You can calculate from what you put into the playlist and the do

    player.createMessage((messageType, payload)
            -> player.pause())
        .setPosition(mediaItemIndexAtWhichToPause, positionAtWhichToPause)
        .send();

to pause at the given position.

You may don't know the durations of the items you put into the playlist ahead of time. So you can add an listener that is called each time when the media items changes. I assume your app provides a method getSleepTimerEndMs() that gives us the time in millisecond, at which the sleep timer ends:

@Override
public void onMediaItemTransition(@Nullable MediaItem mediaItem, int reason) {
  if (reason != Player.MEDIA_ITEM_TRANSITION_REASON_AUTO) {
    return;
  }
  long nowMs = SystemClock.currentThreadTimeMillis();
  long timeAtWhichCurrentItemEnds = nowMs + player.getDuration();
  long timeAtWhichTimerEnds = getSleepTimerEndTimeMs(); // app knows whether timer is on
  if (timeAtWhichTimerEnds != C.TIME_UNSET && timeAtWhichCurrentItemEnds > timeAtWhichTimerEnds) {
    long positionAtWhichToPause = timeAtWhichTimerEnds - nowMs;
    player
        .createMessage((messageType, payload) -> player.pause())
        .setDeleteAfterDelivery(true)
        .setPosition(player.getCurrentMediaItemIndex(), positionAtWhichToPause)
        .setLooper(player.getApplicationLooper())
        .send();
  }
}

You may want to monitor other events, that cancel, send or update the message in case the user manipulates the player during 'sleeping'.
Keep your message in case the user changes or cancels the timer. The you can call message.cancel().

You can use CountDownTimer and a handler to handle the scenario. I have implemented using the same with 30, 45, 60 mins and an End of Episode sleep timer. When the timer runs out, an onTimerCompleted is called if you use CountDownTimer. Inside the onTimerCompleted, I am simply doing controller.pause() or cotroller.stop() depending use case.


can't use the app

to my existing cms project i tried to use this app with.
(djangocms-template)user@host:~/Dev/Projects/djangocms-template/$ pip install django-cms-themes
put cms_themes in INSTALLED_APPS in settings
set PROJECT_DIR in settings
(djangocms-template)user@host:~/Dev/Projects/djangocms-template/$ ./project/manage.py syncdb
receive error : django.db.utils.DatabaseError: no such table: cms_themes_theme
(djangocms-template)user@host:~/Dev/Projects/djangocms-template/$ ./project/manage.py migrate
receive error : django.db.utils.DatabaseError: no such table: cms_themes_theme

I am reproducing this same issue on CentOS 5.5.
Have you found any workarounds?

yes, however I don't remember successfully producing a complete working demonstration.
I did however move past this particular error.
I will post details in the next few days when I have time off from work.

By the way, I'm not sure it will matter what operating system you use.

Hey airtonix, thanks for fixing this.  Sorry for the delay, but I'll keep a closer eye on my Github notifications going forward.
ryanrca, can you confirm that this resolved the issue for you?

Still got the same problem...
Now tried:
pip install --upgrade django-cms-themes
same error...then tried:
pip uninstall django-cms-themes
pip install django-cms-themes
and still have the error when lunching manage.py syncdb
When I comment out cms_themes', in my settings.py
and relaunch syncdb everything works fine.... :(

@alexsosic Could you post the stack trace in a gist?

@alexsosic Could you post the stack trace in a gist?

https://gist.github.com/1566049

I uninstalled the package via pip uninstall,
then deleted the build/cms_themes directory under my virtualenv
and reinstalled with:
pip install django-cms-themes
The package was cached!
Thanks @MegaMark16 for the support!


[BUG] Keypoint skeleton not showing in the App for videos

When viewing a video in the App that has keypoints, the skeleton is not drawn when specified through dataset.skeletons, only if it is provided through dataset.default_skeleton.
Example
import fiftyone as fo
import fiftyone.zoo as foz

img_dataset = foz.load_zoo_dataset("quickstart", max_samples=1).select_fields().clone()
vid_dataset = foz.load_zoo_dataset("quickstart-video", max_samples=1).select_fields().clone()

skeleton = fo.KeypointSkeleton(
    labels=["point1", "point2"],
    edges=[[0,1]],
)

img_dataset.skeletons["kps"] = skeleton
vid_dataset.skeletons["kps"] = skeleton

kps = fo.Keypoints(
    keypoints=[
        fo.Keypoint(label="test", points=[[0.5,0.5], [0.7,0.7]])
    ],
)

sample = img_dataset.first()
sample["kps"] = kps
sample.save()

sample = vid_dataset.first()
sample.frames[1]["kps"] = kps
sample.save()

session = fo.launch_app(img_dataset)
# Skeleton is drawn for image dataset

session.dataset = vid_dataset
# No skeleton for video dataset

vid_dataset.default_skeleton = skeleton
session.refresh()
# Skeleton is drawn for video dataset

@brimoor  @ehofesmann  The desired behavior is that the named skeleton for a frames.kps field should be kps? Not frames.kps? In other words, these mappings use field names for keys and not field paths?

No I think frames.kps should be provided if a skeleton is to be used for a specific frame field.

Yeah, that's generally how other things work in FiftyOne. But at the moment it seems that frames.kps also has this issue, and seemingly results in vid_dataset.skeletons={} after launching the app in the above example.

Yes, there was certainly a bug. Fixing it now in the new release.


demo(env): add publish_images var

Signed-off-by: nshankar13<EMAIL_ADDRESS>
Description: Add publish_images var for demo as env variable.

Affected area:

Functional Area

New Functionality
[ ]

Documentation
[X]

Install
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Ingress
[ ]

Egress
[ ]

Networking
[ ]

Observability
[ ]

SMI Policy
[ ]

Sidecar Injection
[ ]

Security
[ ]

Upgrade
[ ]

Tests
[ ]

CI System
[ ]

Demo
[X]

Performance
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution?

Is this a breaking change? No

Codecov Report

Merging #3859 (0248813) into main (53e8bc3) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #3859      +/-   ##
==========================================
- Coverage   67.83%   67.77%   -0.07%
==========================================
  Files         199      199
  Lines       11088    11096       +8
==========================================
- Hits         7522     7520       -2
- Misses       3517     3526       +9
- Partials       49       50       +1

Flag
Coverage Δ

unittests
67.77% <75.00%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/osm-controller/osm-controller.go
13.58% <0.00%> (-0.09%)
:arrow_down:

pkg/envoy/ads/stream.go
3.91% <0.00%> (-0.03%)
:arrow_down:

pkg/metricsstore/metricsstore.go
100.00% <100.00%> (ø)

pkg/crdconversion/crdconversion.go
60.86% <0.00%> (-8.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084dc2e...0248813. Read the comment docs.


undefined is not an object (evaluating 'origin.x')

Hi, I am using this code to show lightbox but I have error.

        {/* */}

+1

1

+1

+1

+1

1, react-native v0.32.0. However, it seems that this library is not being maintained, and react native's version is way ahead of this library's support. I guess sticking to modal + scroll view would a better solution for now.

 #31  Like what I say , this issue is relate to your navigator.. FYI.


Streamlined eslint usage

As discussed, cds-typer and cds-types require their own lint config as they are maintained separately from our other tooling. I will review the current config to see if some of the current rules are covered by defaults at a later point in time.


Add Ceph storage driver

jenkins: test this please

Testsuite passed

Testsuite passed

I added a commit to update the tests.
I'm also merging the two last commits together to make things easier to review.
And I'm dropping the lxd/device/disk commit as it's incorrect. It's unfortunate that we have ceph.user.name in storage config but ceph.user_name in device config, but that's how it's documented and currently being used, so it's not a bug and we can't just go renaming the key in lxd/device/disk. We may align the two later, but that will need documentation update, update logic and backward compatibility translation, so for now, lets just keep the two different names.

NOTE: I'm yet to do a full review of the main commits but have confirmed that the ported logic at least doesn't cause any visible regression or rbd device leaks.

Testsuite passed

Most functions are missing their comments and they also aren't in the same order as the other storage backends.

Call to Remove weren't checking for IsNotExist and errors weren't wrapped with errors.Wrapf

jenkins: test this please


[New Port Request]

Library name: KaHIP
Library description: KaHIP - Karlsruhe High Quality Partitioning - is a family of graph partitioning programs. It includes KaFFPa (Karlsruhe Fast Flow Partitioner), which is a multilevel graph partitioning algorithm, in its variants Strong, Eco and Fast, KaFFPaE (KaFFPaEvolutionary) which is a parallel evolutionary algorithm that uses KaFFPa to provide combine and mutation operations, as well as KaBaPE which extends the evolutionary algorithm. Moreover, specialized techniques are included to partition road networks (Buffoon), to output a vertex separator from a given partition or techniques geared towards efficient partitioning of social networks.
Source repository URL: https://github.com/schulzchristian/KaHIP
Project homepage (if different from the source repository): http://algo2.iti.kit.edu/kahip/
Anything else that is useful to know when adding (such as optional features the library may have that should be included): http://algo2.iti.kit.edu/schulz/software_releases/kahipv2.10.pdf

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

Author of kahip here, i am happy to help woth the port.


feat: support log export in export-terraform

This add support for converting KRM log-export blueprints to Terraform blueprints.

I just found that the title of the usage doc doesn't match the function name:
https://github.com/GoogleContainerTools/kpt-functions-catalog/blob/master/functions/go/export-terraform/README.md#export-terraform-resources
Please fix it.

@morgante this should be ready for another review


IOU - Unable to empty the merchant field to set it to default value 'Request'

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify,com
Create a money request with custom merchant
Open IOU report
Click on the merchant
Empty the merchant
Save the merchant

Expected Result:
The merchant is defaulted to 'Request' when it is emptied
Actual Result:
The merchant is not defaulted to 'Request'. It is defauled to data that is set in Step 2
The behavior here is that it defaults to whatever data that is entered in the Merchant field when the IOU is created. But what if I need to delete the Merchant and change it back to default (Request), it does not allow me to set it back to 'Request'
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/a58da3b3-bae5-4c3b-8c92-3aec1ba9d66b
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mountiny Thank you for the clarification