Slovak translation 30.9.

New translation, I hope everything is ok

Codecov Report

Merging #358 into master will decrease coverage by 0.01%.
The diff coverage is n/a.


Added RoleService.GetRoleEquals(string, bool)

I have been working on implementing custom authentication and authorization in MVCForum using Azure AD B2C. When syncing security groups to the role claim I noticed that Contains() extension method was used as predicate. I needed a more "exact" implementation. I also extended the description comments on the methods.

Thanks for this. I think that Contains method should actually be updated to the body of your equals method. I'm not sure why I did .Contains() to begin with! :/
Be very interested in seeing the Azure AD B2c code? And how you got it working too? Is it anywhere I can see?

Thanks for the reply and amazing work you have done!
Then I'll do an update to this PR and remove my added method. I did not want to do this if the contains part was by design for some reason.
About the AAD B2C code, it is hosted in a private GitHub repo since the company I work for owns it, also still in development. Will have a chat with my boss about sharing the code somehow.

@YodasMyDad But I can say this about my auth implementation: I have built it as a web application on top of (referencing) your 1.9.3 release. I used this guide and this code base as a starting point and was inspired by your SSO wiki page. Basically I have hijacked a couple of routes in MembersController to create/get me a user based on the claims I get from AAD B2C and then also sync (create/assign) the role(s) via MS Graph API. So of course, I am still using FormsAuthentication.


Data prerocessing - zero-centering data around hip joint

It is mentioned in the paper in the data preprocessing section that "since we do not predict the global position of the 3d prediction, we zero-center the 3d pose around the hip joint"
I don't understand how and where is that done in the code? Does this also need to be done for the 2d predictions?
Thank you!

I don't understand how and where is that done in the code?

https://github.com/una-dinosauria/3d-pose-baseline/blob/826df8cb1541afd1bb0b80ad6d6ad55ef8b313de/src/data_utils.py#L472-L492

Does this also need to be done for the 2d predictions?

You could, but we do not do that

Thank you for your response.
I got the 3d coordinates.. However I was expecting to get the Hip coordinates to be (0,0,0) since it is supposed to be centered around the hip, yet it isn't. Still a little lost as to what reference system is used to calculate the 3d coordinates? I probably need to manually call this function to obtain coordinates that are centered around the hip, but if I don't. what is the (0,0,0) point in this case.

Closing for lack of activity. Please reopen if the issue is still ongoing.


Add --except-vendor and --only-vendor to artisan list

This PR replaces the default Symfony ListCommand with an extended ListCommand that supports newly introduced --except-vendor and --only vendor flags. This is similar to the functionality available in the artisan route:list command.

Running artisan list normally will include all commands.
Running artisan list --except-vendor will include all commands except those defined by vendors (including Laravel)
Running artisan list --only-vendor will only include commands that have been defined by vendors (including Laravel)

The inclusion of the --except-vendor flag in particular will make it easy for developers coming into a new Laravel project to see what commands are available that are specific to that project.

what is the difference with #42549?

@fgaroby This PR is for the list of commands. https://github.com/laravel/framework/pull/42549 is for the list of routes.

My bad: I didn't read well

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

I usually solve this issue without any additional code by just prefixing all my commands with "app"... then you can just do "php artisan list app"


Autogenerated documentation with Numpy docstring conventions

Problem
The theme doesn't seem to recognize the numpy docstring convention. Sections of the docstrings are formatted differently than in the example shown in the documention
Reproducible Project
These two docstrings, which describe the same thing, render very differently in the theme, where I prefer the second one.

def function_with_numpy_docstring(par1, par2):
    """ This is a function with the numpy docstring

    Parameters
    ------------
    par1: any
        Some parameter
    par2: any
        Some other parameter

    Returns
    --------
    NoneType

    """
    return None

def function_with_other_docstring(par1, par2):
    """ This is a function with the docstring as in the readthedocs sphinx
    theme example

    :param par1: Some parameter
    :type par1: Any

    :param par2: Some parameter
    :type par2: Any

    :rtype: NoneType

    """
    return None

Expected Results
Ideally, I'd like to see numpy docstring formatted in the same way as in the Sphinx RTD theme example.
Environment Info

Python Version: 3.7.2
Sphinx Version: 2.0.1
RTD Theme Version: 0.4.3

I'm having a similar problem. Even when enabling numpydoc, the formatted version is messing up the parameter name a data type. For example, this is the exact same code with sphinx_rtd_theme 0.4.2 (https://www.fatiando.org/verde/v1.1.0/api/generated/verde.distance_mask.html#verde.distance_mask) and 0.4.3 (https://www.fatiando.org/verde/dev/api/generated/verde.distance_mask.html#verde.distance_mask). So this seems to be a new bug in the theme.

This was reported in sphinx here: https://github.com/sphinx-doc/sphinx/issues/5959
and fixed here: https://github.com/sphinx-doc/sphinx/pull/5976
Presumably a similar change to the sphinx RTD theme would take care of this?

Actually, the problem seems to have been fixed for me on RTD itself, I just see it when I try to build the docs locally.  So probably in my case this is something still misconfigured or incompatible on my local build.  The example links posted above also seem to look similar in new and old versions so I suspect this issue has been fixed.

This may be a Sphinx 2 issue; the theme has a number of incompatibilities. @xylar are you using Sphinx 2 locally and a lower version on RTD perhaps?

Of the usable reports here, I don't see major issues. We could use some more information to track this down if you are still experiencing the issue. Agreed that this is probably in part a Sphinx 2 issue.

I'm going to close this due to lack of feedback. I think this will be addressed with some of the fixes for Sphinx 2.

I'm still experiencing this issue with
sphinx==2.4.3
sphinx-rtd-theme==0.4.3/2/master
    Parameters
    ----------
    x_dim : int, optional
        state dimensionality
        Default: 3
    bin_size : float, optional
        spike bin width in msec
        Default: 20.0

Adding
.classifier:before {
    font-style: normal;
    margin: 0.2em;
    content: ":";
}

in css/custom.css and html_css_files = ['css/custom.css'] as mentioned in https://github.com/qutip/qutip-doc/issues/94 has no effect.
Project link: https://elephant-docs-development.readthedocs.io/en/enh-module_doc/reference/gpfa.html#elephant.gpfa.gpfa.GPFA
however, by the time you inspect our url, it might be changed to a different sphinx theme. Although I like rtd-theme, if it doesn't work and I see no updates on this since Oct, we'll stick to a different one.

As another example of the problem, I don't use RTD anymore because my environment requires too much memory but I build my documentation for GitHub Pages using Travis CI and sphinx_rtd_theme, and I'm seeing the issue.
Here is an example of the problem from my docs:
https://mpas-dev.github.io/MPAS-Analysis/stable/generated/mpas_analysis.shared.analysis_task.AnalysisTask.html#mpas_analysis.shared.analysis_task.AnalysisTask
My CI is here if anyone wants to poke around but building the docs is basically just a question of setting up a conda environment including sphinx_rtd_theme and running make html in the docs directory.
https://github.com/MPAS-Dev/MPAS-Analysis/tree/develop/ci

I managed to track down this problem to numpydoc (though not really what in numpydoc causes it). In fatiando/verde#209 we replaced numpydoc with sphinx.ext.napoleon to get roughly the same results but without the bad parameter list (example docstring).

If the issue is the classifier part of the definition list, this is a duplicate of #746 and will be resolved with #838.


Misc Docker + Go version upgrade

As to the Docker image adjustments, I have tested OK:

[x] css.TailwindCSS
[x] PostCSS
[x] Libsass (extended build is now default)
[x] Dart Sass
[x] The hugoDocs (Go modules, Git etc.) and misc others Go modules setups.
[x] It sets ENV HUGO_CACHEDIR=/cache allowing the Hugo cache to survive builds.

On MacOS, an example build line would be:
docker run --rm -v .:/project -v $HOME/Library/Caches/hugo_cache:/cache imagename build

Starting the server:
docker run --rm -v .:/project -v $HOME/Library/Caches/hugo_cache:/cache imagename server --bind="<IP_ADDRESS>"

This is the entry point file:
#!/bin/sh

# Check if a custom hugo-docker-entrypoint.sh file exists.
if [ -f hugo-docker-entrypoint.sh ]; then
  # Execute the custom entrypoint file.
  sh hugo-docker-entrypoint.sh "$@"
  exit $?
fi

# Check if a package.json file exists.
if [ -f package.json ]; then
  # Check if node_modules exists.
  if [ ! -d node_modules ]; then
    # Install npm packages.
    # Note that we deliberately do not use `npm ci` here, as it would fail if the package-lock.json file is not up-to-date,
    # which would be the case if you run the container with a different OS or architecture than the one used to create the package-lock.json file.
    npm i
  fi
fi

exec "hugo" "$@"

If a custom hugo-docker-entrypoint.sh script exists in the root of the Hugo project, that script will be executed instead of the default entrypoint script.

@jmooring I have spent some hours today trying to get up to speed re. the current Docker "scene"; I'm reasonably happy but the Dockerfile setup, and it should support all but 3) in your list in #12885.
I wouldn't mind if we as the next step added a hugo-extras (or something) with Asciidoc etc. added, but I think it would be good to have one base image that covered 90% of the use cases.
On my MacBook Pro M1 the image size increases from 135MB to to 406MB, which I suspect some will complain about, but it's not dramatic enough for me to even consider breaking it up into multiple setups.
What do you think? The entrypoint/npm install setup is a little opinionated, but I think it should work. I have tested it would most of my Hugo projects with a package.json and it seems to work fine (even with the new Tailwind).
What do you think?

I'm taking a look at the build failure, looks like something related to cross-comp with the new Dockerfile

OK so here are some changes that I came up with;

Currently, the final image is based on the base stage which is pinning the platform to $BUILDPLATFORM - we need the final image to use the target platform, so I've decoupled base and final.

I added a GO_VERSION arg to make sure they're both using the same golang version.
It seems like gcc/g++ are also runtime dependencies for libsass and libwebp, so we need to install them in both the build and final stages.

I added clang and lld back for the C cross-compilation. I don't know too much about how this works but they're recommended for use with xx
Re-enabled CGO
Fixed the install_runtimedeps_default.sh script to use TARGETARCH instead of BUILDARCH, since we need different versions in the runtime stage.

diff --git a/Dockerfile b/Dockerfile
index 6da83a3cc..921215c59 100755
--- a/Dockerfile
+++ b/Dockerfile
@@ -2,14 +2,15 @@
 # Twitter:      https://twitter.com/gohugoio
 # Website:      https://gohugo.io/

+ARG GO_VERSION="1.23.2"
+
 FROM --platform=$BUILDPLATFORM tonistiigi/xx:1.5.0 AS xx
-FROM --platform=$BUILDPLATFORM golang:1.23.2-alpine AS base
-FROM base AS build
+FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine AS build

 # Set up cross-compilation helpers
 COPY --from=xx / /
-
-# gcc/g++ are required to build libsass and libwebp libraries for the extended version.
+RUN apk add clang lld
+ARG TARGETPLATFORM
 RUN xx-apk add --no-scripts --no-cache gcc g++

 # Optionally set HUGO_BUILD_TAGS to "none" or "nodeploy" when building like so:
@@ -20,7 +21,7 @@ ARG HUGO_BUILD_TAGS="extended"
 ENV GOPROXY=https://proxy.golang.org
 ENV GOCACHE=/root/.cache/go-build
 ENV GOMODCACHE=/go/pkg/mod
-ARG TARGETPLATFORM
+ENV CGO_ENABLED=1

 WORKDIR /go/src/github.com/gohugoio/hugo

@@ -36,7 +37,10 @@ RUN --mount=target=. \
     xx-verify /usr/bin/hugo
 EOT

-FROM base AS final
+FROM golang:${GO_VERSION}-alpine AS final
+
+# libsass and libwebp also require gcc/g++ as runtime dependencies
+RUN apk add --no-scripts --no-cache gcc g++

 COPY --from=build /usr/bin/hugo /usr/bin/hugo

@@ -60,8 +64,8 @@ VOLUME /project
 WORKDIR /project
 USER hugo:hugo
 ENV HUGO_CACHEDIR=/cache
-ARG BUILDARCH
-ENV BUILDARCH=${BUILDARCH}
+ARG TARGETARCH
+ENV ARCH=${TARGETARCH/amd64/x64}

 COPY scripts/docker scripts/docker

diff --git a/scripts/docker/install_runtimedeps_default.sh b/scripts/docker/install_runtimedeps_default.sh
index 0b6c2c617..4ca88fd67 100755
--- a/scripts/docker/install_runtimedeps_default.sh
+++ b/scripts/docker/install_runtimedeps_default.sh
@@ -4,17 +4,10 @@ set -ex

 export DART_SASS_VERSION=1.79.3

-# If $BUILDARCH=arm64, then we need to install the arm64 version of Dart Sass,
-# otherwise we install the x64 version.
-ARCH="x64"
-if [ "$BUILDARCH" = "arm64" ]; then
-    ARCH="arm64"
-fi
-
 cd /tmp
 curl -LJO https://github.com/sass/dart-sass/releases/download/${DART_SASS_VERSION}/dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
 ls -ltr
 tar -xf dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
 rm dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz && \
 # The dart-sass folder is added to the PATH by the caller.
-mv dart-sass /var/hugo/bin
\ No newline at end of file
+mv dart-sass /var/hugo/bin

I noticed you pushed some more changes, and I also noticed that the way dart-sass is installed could be improved, e.g. we install curl in the runtime image which isn't very good, we only want the dart-sass binary. So I made installing dart-sass a separate stage and copy the artifact from there.
diff --git a/Dockerfile b/Dockerfile
index 6da83a3cc..4455ac8d4 100755
--- a/Dockerfile
+++ b/Dockerfile
@@ -2,14 +2,15 @@
 # Twitter:      https://twitter.com/gohugoio
 # Website:      https://gohugo.io/

+ARG GO_VERSION="1.23.2"
+
 FROM --platform=$BUILDPLATFORM tonistiigi/xx:1.5.0 AS xx
-FROM --platform=$BUILDPLATFORM golang:1.23.2-alpine AS base
-FROM base AS build
+FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine AS build

 # Set up cross-compilation helpers
 COPY --from=xx / /
-
-# gcc/g++ are required to build libsass and libwebp libraries for the extended version.
+RUN apk add clang lld
+ARG TARGETPLATFORM
 RUN xx-apk add --no-scripts --no-cache gcc g++

 # Optionally set HUGO_BUILD_TAGS to "none" or "nodeploy" when building like so:
@@ -20,7 +21,7 @@ ARG HUGO_BUILD_TAGS="extended"
 ENV GOPROXY=https://proxy.golang.org
 ENV GOCACHE=/root/.cache/go-build
 ENV GOMODCACHE=/go/pkg/mod
-ARG TARGETPLATFORM
+ENV CGO_ENABLED=1

 WORKDIR /go/src/github.com/gohugoio/hugo

@@ -36,48 +37,57 @@ RUN --mount=target=. \
     xx-verify /usr/bin/hugo
 EOT

-FROM base AS final
+FROM alpine:latest AS dart-sass
+ARG TARGETARCH
+ARG ARCH=${TARGETARCH/amd64/x64}
+ARG DART_SASS_VERSION=1.79.3
+WORKDIR /tmp
+RUN apk add --no-cache curl
+RUN <<EOT
+    set -ex
+    curl -LJO https://github.com/sass/dart-sass/releases/download/${DART_SASS_VERSION}/dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
+    tar -xf dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
+EOT

-COPY --from=build /usr/bin/hugo /usr/bin/hugo
+FROM golang:${GO_VERSION}-alpine AS final
+
+# libsass and libwebp also require gcc/g++ as runtime dependencies
+RUN apk add --no-scripts --no-cache

 # libc6-compat & libstdc++ are required for extended libraries (libsass, libwebp).
 RUN apk add --no-cache \
+    g++ \
+    gcc \
+    git \
     libc6-compat \
     libstdc++ \
-    git \
-    runuser \
-    curl \
     nodejs \
-    npm
+    npm \
+    runuser

-RUN mkdir -p /var/hugo/bin && \
-    addgroup -Sg 1000 hugo && \
-    adduser -Sg hugo -u 1000 -h /var/hugo hugo && \
-    chown -R hugo: /var/hugo && \
-    runuser -u hugo -- git config --global --add safe.directory /project
+COPY --from=dart-sass /tmp/dart-sass /var/hugo/bin/dart-sass
+COPY --from=build /usr/bin/hugo /usr/bin/hugo
+ENV PATH="/var/hugo/bin:/var/hugo/bin/dart-sass:$PATH"

+RUN <<EOT
+    mkdir -p /var/hugo/bin /cache
+    addgroup -Sg 1000 hugo
+    adduser -Sg hugo -u 1000 -h /var/hugo hugo
+    chown -R hugo: /var/hugo /cache
+    # For the Hugo's Git integration to work.
+    runuser -u hugo -- git config --global --add safe.directory /project && \
+    # See https://github.com/gohugoio/hugo/issues/9810
+    runuser -u hugo -- git config --global core.quotepath false
+EOT
+
+USER hugo:hugo
 VOLUME /project
 WORKDIR /project
-USER hugo:hugo
 ENV HUGO_CACHEDIR=/cache
-ARG BUILDARCH
-ENV BUILDARCH=${BUILDARCH}
-
-COPY scripts/docker scripts/docker
-
-# Install default dependencies.
-RUN scripts/docker/install_runtimedeps_default.sh
-
-COPY scripts/docker/entrypoint.sh /entrypoint.sh
-
-ENV PATH="/var/hugo/bin:/var/hugo/bin/dart-sass:$PATH"

 RUN sass --version
 RUN hugo version

-# Expose port for live server
-EXPOSE 1313
-
+COPY scripts/docker/entrypoint.sh /entrypoint.sh
 ENTRYPOINT ["/entrypoint.sh"]
 CMD ["--help"]
-
diff --git a/scripts/docker/install_runtimedeps_default.sh b/scripts/docker/install_runtimedeps_default.sh
deleted file mode 100755
index 0b6c2c617..000000000
--- a/scripts/docker/install_runtimedeps_default.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/bin/sh
-
-set -ex
-
-export DART_SASS_VERSION=1.79.3
-
-# If $BUILDARCH=arm64, then we need to install the arm64 version of Dart Sass,
-# otherwise we install the x64 version.
-ARCH="x64"
-if [ "$BUILDARCH" = "arm64" ]; then
-    ARCH="arm64"
-fi
-
-cd /tmp
-curl -LJO https://github.com/sass/dart-sass/releases/download/${DART_SASS_VERSION}/dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
-ls -ltr
-tar -xf dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz
-rm dart-sass-${DART_SASS_VERSION}-linux-${ARCH}.tar.gz && \
-# The dart-sass folder is added to the PATH by the caller.
-mv dart-sass /var/hugo/bin
\ No newline at end of file

@dvdksn thanks for the input; one of my goals of this work is to remove (at least most of) the guess work from the Docker setup (e.g. "It seems like gcc/g++ are also runtime dependencies for libsass and libwebp"; we need a libc implementation, but not the full grown compiler).

OK, then I think you can just remove
    g++ \
    gcc \

from the Dockerfile above and it should work

OK, I guess I need to pull out my non-ARM macbook to get this up and running instead of guessing ...

@bep Support for asciidoc, pandoc, and rst can wait for another day. I think this covers > 95% of use cases. I don't have any opinion on size... I suppose if someone wants something thinner they can grow their own, as many have already done.


target_item expected error

I wrote a spider, the code is there https://codeshare.io/5NQXr1.
I just want to retrieve the links in one Item element, I've got a link = AttrField(css_select='a', attr='href'), but when it's called in a async for, i've got a target_item expected error. In the examples you have done in the repo, when calling item with get_items(), they all got a clean_link or clean_title async method. But i don't think it's the issue. Also response.html contains links.

Hi @misterpilou

In this line you should use await RecipeUrl.get_item(html=response.html) instead
More details click here

About this line:

async def clean_link(self, link):
        return link

okay thanks you very much, i will test that now

Yes it work, i need to debug others parts. I will work a bit with ruia, i think i will have others questions. Doing it in issues is imo irrelevant, is there a chat or any others ways to process? Would you be interested to have a new contributor?

Hi @misterpilou :
I am so glad to hear that you want to be a contributor to the ruia project, hope to see your PR Soon.
BTW, we can talk about ruia in our chat romm, click here


Ignore diacritics in autocomplete

Fixes #230
Works for:

Choice
Choice List
Reference
Reference List

This could be extended to the autocomplete in document settings for time zone, locale, and currency, that share a similar logic.
Tested with French, but not with Cyrillic or eastern scripts.

Thanks! I haven’t really looked at the underlining logic yet, so I agree we could deal with that in a separate PR :)


run coverlet as global tool with vstest

I try to run coverlet as global tool with vstest. My command line is:
coverlet {path to test .dll} --target "dotnet" --targetargs "vstest {path to test .dll} --logger:trx" --format cobertura --threshold 80 --verbosity detailed
coverlet response:
..
Hits file:'C:\Users\user\AppData\Local\Temp\Pom2_98c0d86c-7f21-4f7a-9ba5-f3690201c1ae' not found for module: 'Pom2'
Hits file:'C:\Users\user\AppData\Local\Temp\Services_98c0d86c-7f21-4f7a-9ba5-f3690201c1ae' not found for module: 'Services'
Hits file:'C:\Users\user\AppData\Local\Temp\Visualization_98c0d86c-7f21-4f7a-9ba5-f3690201c1ae' not found for module: 'Visualization'
..

for every single referenced assemblies that coverlet collect before:
..
Instrumented module: 'D:\IMSHH\IMSHH\bin\ptc\Release\Pom2.dll'
Instrumented module: 'D:\IMSHH\IMSHH\bin\ptc\Release\Services.dll'
Instrumented module: 'D:\IMSHH\IMSHH\bin\ptc\Release\Visualization.dll'
..

coverlet version: Cross platform .NET Core code coverage tool
<IP_ADDRESS> (installed is dotnet tool install --global coverlet.console --version 1.5.3)
Whats going wrong here?

We've issue with Unload event https://github.com/tonerdo/coverlet/blob/5a139b200f7bf51c21660b93f41906f4571c971b/src/coverlet.core/Coverage.cs#L231 that will be resolved with collectos.
But before some question(maybe silly)

Do you run tests that include that libs?
Same result with test tools(no vstest) https://github.com/tonerdo/coverlet#global-tool?
If you try with msbuild or collector way result are the same?

In case can you provide a repro(or project is open sorce and we can clone)?

Hello @MarcoRossignoli thanks for your response.
1.) No, most of them (>100) looks like indirect depedencies, if there is an option to analyse only direct depedencies, I would prefer that.
2.) Yes I get the same results with coverlet {path to test .dll} --target "dotnet" --targetargs "test {path to test .dll} --logger:trx" --format cobertura --threshold 80 --verbosity detailed and coverlet {path to test .dll} --target "dotnet" --targetargs "--logger:trx" --format cobertura --threshold 80 --verbosity detailed too
3.) Unfortunately I can't share the repository or an project. I know it would be much easier to found out whats going on, sorry.

No, most of them (>100) looks like indirect depedencies, if there is an option to analyse only direct depedencies, I would prefer that.

The issue could be related to this...if you don't use that libs you should exclude from coverage...we don't have at the moment a way to exclude "unused" dll.
We've some on going work on it(actually stale) https://github.com/tonerdo/coverlet/pull/225

That means I have to create a list with all unused .dll and pass them in a array to the --exclude-by-file  variable? For example:
--exclude-by-file @("Pom2.dll", "Services.dll")

Global tool filter sample are here https://github.com/tonerdo/coverlet/blob/master/Documentation/GlobalTool.md#filters

@MarcoRossignoli I try to switch to coverlet Version <IP_ADDRESS> and remarkable is that the coverlet execution stops immediately with the message:
Symbols were found but are not matching the assembly
What should that tell me?

Mmm can you take a screenshot of command line?I don't understand if it's related to coverlet (seem that pdb are not aligned with compilation, try also to run git clean -fdx from repo root before)

@MarcoRossignoli Sorry that I have to mask some parts.

I try both:
coverlet UnitTests.dll --target "vstest.console" --targetargs "project\Release\UnitTests.dll --settings:C:\Users\user\Desktop\CoverageTests\TestSettings.runsettings --logger:trx" --format cobertura --threshold 80
and
coverlet UnitTests.dll --target "dotnet" --targetargs "vstest project\Release\UnitTests.dll --settings:C:\Users\user\Desktop\CoverageTests\TestSettings.runsettings --logger:trx" --format cobertura --threshold 80
it also fails without the --settings property

Can you add coverlet logs? https://github.com/tonerdo/coverlet/blob/master/Documentation/Troubleshooting.md#coverlet-global-tool

@MarcoRossignoli I try to switch to coverlet Version <IP_ADDRESS> and remarkable is that the coverlet execution stops immediately with the message:

Have installed dotnet tool install --global coverlet.console --version 1.5.3?

@MarcoRossignoli How you know it before coverlet <IP_ADDRESS> returns on
UnitTests.dll --target "dotnet" --targetargs "test UnitTests.dll --no-build" --verbosity detailed
--> Unrecognized option '--verbosity'
So I do that with coverlet.console --version 1.5.3 and the detailed verbosity log is splitted in 3 parts:
1. Part Excluded module filter '[xunit*]*'

for each dll of these over 100 dlls (I think there are all referenced by the test-dll) stand the line Instrumented module: 'path of dll'

between that, you found about 3 warning lines with: Unable to instrument module: TableWPF.dll because : Failed to resolve assembly: 'Framework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=13123214134'

-in the end of part 1 I got an UnitTests.dll(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 1, position 1.
2. Part Calculating coverage result...

equivalent to the amount of lines before, I get for each the message: Hits file:'ToolStrip_8bbb009a-0a79-4bc5-8445-127004140251' not found for module: 'ToolStrip'

here, all lines are the same

3. Part Generating report 'coverage.json'
+--------------------------------------------------------------+------+--------+--------+
| Module                                                       | Line | Branch | Method |
+--------------------------------------------------------------+------+--------+--------+
| Module A                                                    | 0%   | 0%     | 0%     |
+--------------------------------------------------------------+------+--------+--------+
| Module B                                                    | 0%   | 0%     | 0%     |
+--------------------------------------------------------------+------+--------+--------+
| Module C                                                    | 0%   | 0%     | 0%     |
+--------------------------------------------------------------+------+--------+--------+
| Module D                                                   | 0%   | 100%   | 0%     |

most entries of the table of Line, Branch and Method coverage have 0%, but in some rare modules there stand 100% Branch coverage

at the end of this part there is a summery with the average coverage (look like he ignoring the 100% Branch coverage before)

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 0%   | 0%     | 0%     |
+---------+------+--------+--------+
| Average | 0%   | 0%     | 0%     |
+---------+------+--------+--------+
To summarize:
I think Part 2 and 3 of the log have nothing to do with my issue. But maybe the MSB4025 is related?

Ok so I infer that this is a .NET framework project(no core) written in vb.
Can you try to use filter(--include) https://github.com/tonerdo/coverlet/blob/master/Documentation/GlobalTool.md#filters to include only your dll(and exclude references that could lead to problems) and make sure that all dll are present in bin\Debug|Release folder?

@MarcoRossignoli One question for my general understanding. Which dll should be include for coverlet? All references I found inside the Project References?

Is it important also include System References?

Or should I only include the references which are the results from the imports of the test classes?

Thanks a lot for your help.

You should include only "your code" for instance suppose to have 3 project A,B,C that generates assemblies A.dll B.dll C.dll and suppose that B and C are libs and A is a WinForm project references B/C and System.Windows.Form(and other system libs). You've also a test project called D.dll.
In this case you should add coverlet package to D and run with filter --include "[A]*,[B]*,[C]*" in this way you're instrumenting only "your code" and not references that coverlet will found in bin\Debug|Release folder, you should confirm that using --verbosity detailed switch and read in console that only ABC libs are Instrumented module: 'path of dll'
for ref https://github.com/tonerdo/coverlet/blob/master/Documentation/GlobalTool.md#filters

@MarcoRossignoli thanks a lot for you explanation, that helps a lot. I think I found something importent about this issue. First of all, I understand now that my particular UnitTest project only works with vstest/vstest.console. test or mstest fails and don't work. (I have a kind of an idea why, but it's hard to explain)

so running
vstest.console Project.UnitTests.dll /Logger:trx
works exactly like expected. All Test get found, executed an passed.
running
dotnet vstest Project.UnitTests.dll /Logger:trx
returns Project.UnitTests.dll no test is available. Make sure that Testdiscoverer and -executor are registered and the version settings for platform and framework are correct, and then try again.
and that is exactly the feedback what I get, when I am running:
coverlet Project.UnitTests.dll --target "dotnet" --targetargs "vstest Project.UnitTests.dll --logger:trx" --verbosity detailed --include "[Project]*"

so obviously dotnet vstest  can't find any tests inside the Project.UnitTests.dll but why vstest.console can? Is there a way to run coverlet with vstest.console? Do you have an idea how I can investigate this issue?

I think you can try with coverlet Project.UnitTests.dll --target "vstest.console" --targetargs "Project.UnitTests.dll /Logger:trx" --verbosity detailed --include "[Project]*"
Dotnet tool run --target as process and pass --targetargs https://github.com/tonerdo/coverlet/blob/master/src/coverlet.console/Program.cs#L80 and before instrument module(Project.UnitTests.dll) and when process closes(tests run ends) collect the coverage.

@MarcoRossignoli with:
coverlet Project.UnitTests.dll --target "vstest.console" --targetargs "Project.UnitTests.dll /Logger:trx" --verbosity detailed --include "[Project]*"
I get the error message (in red):
**The system cannot find the specified file.**
After Step 1 I think. Coverlet intrument/exclude the dlls before

Seems like dotnet don't know vstest.console

Did some test on my repro...it works(missed .exe)
C:\git\marcorossignoli.github.io\src\coverlet\Issue0 (int -> origin)
λ coverlet "C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\CoverletTest.dll" --target "vstest.console.exe" --targetargs "C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\CoverletTest.dll /Logger:trx" --verbosity detailed
Excluded module filter '[xunit*]*'
Instrumented module: 'C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\CoverletSampleLib.dll'
Excluded module: 'C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\xunit.runner.reporters.netcoreapp10.dll'
Excluded module: 'C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\xunit.runner.utility.netcoreapp10.dll'
Excluded module: 'C:\git\marcorossignoli.github.io\src\coverlet\Issue0\CoverletTest\bin\Debug\netcoreapp2.1\xunit.runner.visualstudio.dotnetcore.testadapter.dll'
Microsoft (R) Test Execution Command Line Tool Version 16.3.0-preview-20190715-02
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
[xUnit.net 00:00:00.5781395]   Discovering: CoverletTest
[xUnit.net 00:00:00.6422694]   Discovered:  CoverletTest
[xUnit.net 00:00:00.6484240]   Starting:    CoverletTest
[xUnit.net 00:00:00.8154479]   Finished:    CoverletTest
  V CoverletTest.MyFunTest.Test2 [9ms]
  V CoverletTest.TestClass.Test [9ms]
Results File: C:\git\marcorossignoli.github.io\src\coverlet\Issue0\TestResults\Marco_WS-3_2019-08-14_11_49_48.trx
Test Run Successful.
Total tests: 2
     Passed: 2
 Total time: 1,9266 Seconds

Calculating coverage result...
  Generating report 'C:\git\marcorossignoli.github.io\src\coverlet\Issue0\coverage.json'
+-------------------+------+--------+--------+
| Module            | Line | Branch | Method |
+-------------------+------+--------+--------+
| CoverletSampleLib | 100% | 100%   | 100%   |
+-------------------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | 100% | 100%   | 100%   |
+---------+------+--------+--------+

@MarcoRossignoli tears in my eyes. That was the missing part of the puzzle.
Finally
coverlet Project.UnitTests.dll --target "vstest.console.exe" --targetargs "Project.UnitTests.dll /Logger:trx" --verbosity detailed --include "[Project]*"
works well and returns solid results.
+---------+--------+--------+--------+ |         | Line   | Branch | Method | +---------+--------+--------+--------+ | Total   | 89,92% | 82,12% | 90,82% | +---------+--------+--------+--------+ | Average | 89,92% | 82,12% | 90,82% | +---------+--------+--------+--------+
Thanks for your patience, keep going for your create project.

Glad to hear!Feel free to close the issue!

keep going for your great project.

Credits goes to all contributors and to @tonerdo's idea.


Feature/remove example from copied files

Currently when a user pastes a file like .env.example it becomes .env copy.example or .env.1.example (depending on their incremental naming settings), and just makes more work for the user to rename the file to be just .env.
This change makes it so when a user copies a file that has .example, -example, .sample, or -sample before or after the extension, when the file is pasted it will remove the example or sample part.
If someone pastes an example file and already has what it would resolve to, it will just increment on the resolved name. So if someone already has .env and pasts .env.example it will just become .env copy.
The use case I had in mind was to assist when setting up projects that have example config files because the real ones are ignored (for security, or because they'd change between computers).
Here's a demonstration:

This seems like something that could annoy some people, so I figured it'd be good as a setting. I made it enabled by default, but don't mind changing it to be disabled by default.
I tested this out by creating a few files with example and sample and just copied and pasted them in different ways.
I also did a bit of refactoring for maintainability, since it seemed relevant. I could undo it if it'd be preferred. I'm also open to doing more refactoring if there's anything else that seems relevant.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tegandbiscuits sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thanks for this PR, however before submiting PRs it is usually good to first file an issue so we start a discussion and you do not code up a PR which potentially does not get accepted.
However since you already created a PR we can discuss it here.
I defeinetly do not like this appraoch, I do not see why the -example files would be treated specially and why would this information be hard coded to the explorer who is language agnostic.

@isidorn  Thanks for the feedback.
Sorry, I misperceived the Submitting Bugs and Suggestions page in the wiki, and assumed that I should've created an issue just if I wasn't going to make the code changes.
Unless I'm mistaken, this should be language agnostic already. I used .js in the tests to be consistent with what the other tests for incrementFileName / suggestFileName do. But if explorer isn't a suitable place, I could rework this.
When you say "I do not see why the -example files would be treated specially", do you mean -example vs .example or just this feature as a whole (I appreciate the feedback either way, I'm just trying to get clarity)?
If you mean just -example, then I don't mind making it so - as a separator doesn't do anything.
As for this change as a whole, the use I'm trying to solve is just make things easier when setting up projects that have files which aren't committed but do have example files that a developer needs to copy.
An example would be a project that requires something, say, secrets.json to run. It's a pretty common pattern to instead commit something like secrets-exmaple.json that has the keys and fake values for you need to change.
To me, it seems pretty common when copying and pasting a file called something like secrets-example.json to want to end up having secret.json. This just removes the step of renaming secrets-example copy.json to secrets.json manually.

I mean that example pattern, this is too specific for the explorer, and am not aware of ti being used broadly. I might be mistaken, but for now I will not merge this PR in. In the future we might reconsider this, thus leaving this open.
Idealy this would be handled by an extension, however this functionality is currently not open for contributions though we might change that in the future.

Closing this PR per my previous comment as this feels out of scope.


Misleading error message "Unknown options: '--option', 'value'"

Based on feedback from https://github.com/keycloak/keycloak/issues/10051
When we have user input like --xxx somevalue, and there is no option named --xxx, then picocli also does not know what to do with the somevalue parameter. The error message says "Unknown options", but perhaps this should be refined to:

only say "Unknown options" when all unmatched arguments resemble options
say "Unknown arguments" when none of the unmatched arguments resemble an option
say "Unknown options and arguments" when some but not all of the unmatched arguments resemble an option

Reasonable solutions exist for this.


VM Service: Gather virtual memory mappings from other operating systems

GetProcessMemoryUsage on Linux/Android now adds virtual memory mappings gather from /proc/self/smaps. Together with the VM's own accounting of its anonymous mappings, this explains nearly all the processes's RSS.
On Fuchsia, we can gather similar information by walking zx_object_get_info(zx_process_self(), ZX_INFO_PROCESS_MAPS).
On Windows, some combination of VirtualQuery, GetMappedFileName, EnumModules should provide similar information.
On Mac, we may need to parse the output of vmmap, though this might be unacceptably slow.

//cc @bkonyi


stagegl 8x performance drop on low end phones ?

Hi guys. I know stagegl is in early stages. And we are glad that 2d stage can be moved to webgl easily just by changing stage to stagegl. The most important idea to move everything to webgl was performance gain.
Due to text and single spritesheet limits we had all mostly static gui in 2d canvas rendered over heavily animated gl canvas
Good thing is game somehow works just by simple stage->stagegl word change as mentioned in docs. Unfortunately animations run fast(15 fps framerate anim param seems ignored) also masking doesnt work but must importantly we are seeing nearly 8x drop in fps on low end devices where we need fps  most. The main culprit is I guess inefficient buffersubdata upload to gpu every frame (due to bad drivers on cheap devices ?). having static vertices and modifying them each frame with shader constants each frame is faster at least on my desktop measurements it was 10 times faster.
I am attaching screenshot how much time it took to render two stages (samsung s3 mini) on old and one merged stage on new createjs

I responded regarding framerate in your other thread

Unfortunately animations run fast(15 fps framerate anim param seems ignored) also masking doesnt work

https://github.com/CreateJS/EaselJS/issues/888
Did that help?

having static vertices and modifying them each frame with shader constants each frame

From an architectural point of view, this is not a possibility. The amount of information needed to correctly position each card when stored in a hierarchical display tree requires JavaScript computation or using that much GPU overhead you loose every gain you would get. We push what we can off to the GPU and one of our shortlist items is a "Particle" container which has a shallow depth negating the hierarchical position expenses to allow us to push more onto the GPU and get more speed out.
Usually low end device performance issues come from a problem with too many textures, as texture send rate to the GPU is one of the biggest killers for performance in WebGL, I want to make sure something like that isn't what's going on. Could you turn on StagelGL.vocalDebug = true; and give me a block of what your run-time output of this is console.log("Draw["+ this._drawID +":"+ this._batchID +"] : "+ this.batchReason); ? Vocal debug will make it say that every render, so don't worry about entering the code yourself.
Furthermore, if it really is an efficiency problem with the vertex buffer you could try adjusting the StageGL.DEFAULT_MAX_BATCH_SIZE, this is intended to be externally configurable but I haven't got all my i's dotted and t's crossed for that yet. So you might need to edit the .js file. It controls how much data is being updated to the vertex buffer so depending upon why your batches are ending(the data I asked for above) a smaller or larger number might help? We found pretty good performance with most devices at this value, but if adjusting it yields good results for you I'll prioritize making it configurable.

thx David.
I am new at company and lot of our games are quite old and it looks they were written without any form of Redraw Regions with global stage,update. They were written in a hurry and used just functionality of what createjs provided. Problem is how I refactor them for efficient mobile use.
I wish It was at That time written without global stage.update but unless we implement some form of complex Redraw Regions we are stuck with redrawing all sprites every frame which is extremely inefficient and with a lot of overdraw. I am contemplating at least some form of scene reordering. disabling glclear. rendering static stuff(mostly 12% from canvas edges and border graphics) just once and calling update only on changed stuff. but pretty much 70% of our screen is changing all the time.
Anyway I am trying various DEFAULT_MAX_BATCH_SIZE  values
And maximum I got is 3 fps from value 1000
Draw[1486:2917] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1487:2918] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1487:2919] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1488:2920] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1488:2921] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1489:2922] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1489:2923] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1490:2924] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1490:2925] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1491:2926] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1491:2927] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1492:2928] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1492:2929] : drawFinish
createjs-2017.06.20.combined.js:10897 Draw[1493:2930] : textureOverflow
createjs-2017.06.20.combined.js:10897 Draw[1493:2931] : drawFinish

lannymcnie those animations i responded in #888 . thx a lot it was my fault. Sorry about that. ;(

you are hitting a "textureOverflow" but only one, if there was any way to reduce the number of specific new textures I might recommend that, but that doesn't seem like an easy win for 8x. Was this taken on the problem device? as different hardware has different texture overflow points.
Then again I might also recommend the exact opposite of less textures given one of your other comments. From what I gather sometimes you're drawing a lot of static elements some times and would love a way to not have to not update them? Have you looked into our cache() api?
For the cost of a new texture you can pre-render everything in a container and never worry about rendering it again until something changes, and then you can just updateCache. Caching is also the mechanism to draw unsupported content on StagelGL, but you can use a StageGL to draw the cache and avoid a lot of texture streaming issues. In fact if all the sues of an image are in a cache it no longer gets loaded and could save you from overflowing that way.
var cont = new createjs.Container();
... add things to container...
stagegl.addChild(cont); // we have to do this first otherwise we can't re-use our StageGL instance to perform the cache
cont.cache(0,0, 200,200, 1, {useGL:"stage"}); // cache the appearance of the container using its parent StageGL

Caching isn't wise for something that's under constant animation as it just makes drawing it harder because it's updated every tick, but for something updating sparsely, then it is a huge win most of the time.
Hope it helps.

Yes I am still working on this  low end device (samsung galaxy s3 mini).
We are already using caching due to texts requiring it in stagegl. Ie we converted all our text rendering to call .cache(bounds) after .text=. we collect bounds just once since they dont change.
Yes the text bounds were off but thankfully just height so we just grow height by 20% so i guess we have  like 10% ? waste but this is nothing compared to rest of overdraw happening and cached texts render now.
I guess some overdraw can be mitigated by flattening to one texture as you proposed. problems are those dirty areas. since dynamic text can be over multiple areas that would need to be updated too.
Thx for the tip I try what can be cached. But first I will try to draw static stuff just once by disabling glclear if there is any and. I guess
set visible = false on sprites that didnt change from last scene update.


Update confirm.html

Added show password option so that when user tries to change password he gets an option to view it issue #11948
Please describe the problem you're fixing here. Include the issue number, if applicable.

Thank you, however, this appears to be a duplicate of https://github.com/wagtail/wagtail/pull/11961
I'll give some feedback on that one and close this one.


Not sure what I did wrong, please help

Hi.  I'm not sure what I did wrong, but I just can't seem to get this working for me.  I think that I completed everything correctly, but it doesn't populate the "Units_Transitioning_Out__c" field.  One thing I noticed is that when I look at the trigger, it doesn't include the relationship criteria I specified, but I don't know if it is supposed to or not.  Here is a screenshot of what I entered:

Any help you can provide me will be greatly appreciated.
Thanks,
Matt

Here is a screenshot of the trigger that was created:

The trigger is fine, it reads the config you enter in salesforce dynamically.
Its worth asking in the chatter group (see README for link) about this.
I would try removing the criteria to see if the YEAR check is causing an issue.
Note that when the year changes the tool will not automatically recalc things.
You would have to manually click the Calculate button each rollup for that.


[cleanup] plugin framework: rename rootDir to projectDir

Summary
For the plugin framework, this renames rootDir to projectDir. This change
makes it consistent with the rest of the devbox codebase.
did not change this one, because it may break users. Or are we early enough that
we can change it?
docs/app/docs/devbox_examples/servers/apache.md:HTTPD_DEVBOX_CONFIG_DIR={PROJECT_DIR}

How was it tested?
automated tests

Current dependencies on/for this PR:

main

PR #448   👈

This comment was auto-generated by Graphite.


Can't remove water tile on scenario 74

Affected Scenario(s): [e.g. 6, 10 and 33]
74
Describe the bug
In this scenario we need to add/remove water tile as the game goes. We can remove water tile by using loot action. However, there is no way to remove those tiles in the app.
To Reproduce
Steps to reproduce the behavior:

Launch scenario 74

Add a water tile

Try to remove it...

Launch scenario 74

Immediately try to remove a water tile.

Browser : [e.g. Chrome, Firefox]
Chrome Version 88.0.4324.182

I'll have a look into this one and see if I can find a fix for it.. the release has been really late this time around as I've been working on creating custom scenarios. But I'll try and get it inot the next realease as soon as it's ready


git-checkout: Skip stale .gitmodules entries

Only process .gitmodules entries if they point to a "commit" type object.
Do this because regular git submodule commands behave like that.
Bug: NSL-3880

LGTM


updating ruby-version, refactoring ec_crypto_suite to support OpenSSL…

Updating library to latest version of ruby and refactoring ECCryptoSuite to support OpenSSL 3.0.
Updated dependencies and test suite to support ruby 2.7, 3.0, 3.1, and 3.2. Should we consider dropping support for 2.7?

@ZeroInputCtrl please review - this is ready to be merged and we can cut a new release.

https://github.com/rubocop/rubocop/pull/11469 here's the discussion on Gemfile vs gemspec.


[OTHER] Improve folder/files structure

What would you like to share or ask?
Hi, i want to improve the folder and files structure. It seems a little inconsistent that some components have an index.tsx file and some doesn't. I wanna remove the index.tsx for each folder so that would make the structure more clear.
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

That's a good idea @rupali-codes! :) Let me know when you're ready so I can help you! :)

@CBID2, i'll be working on this today, let me know when u are available on discord

@CBID2, i'll be working on this today, let me know when u are available on discord

Ok


[VEG-1077] Handle case where installation location is a string and not an object

@zendesk/vegemite

Description

zcli apps:server should handle a manifest wherein an installation location looks like this:
"location": {
  "support": {
    "ticket_sidebar": "assets/iframe.html"
  }
},

and serve it locally if ?zcli_apps=true is mounted to a test account.
Currently there is a javascript error presented with the current zcli tag, this is because for whatever reason this usecase was overlooked during development of zcli to date.
We should also continue to support manifest installation locations of the following form:
"location": {
  "support": {
    "ticket_sidebar": {
      "autoHide": true,
      "flexible": true,
      "signed": true,
      "url": "https://myapp.example.org/",
      "size": {
        "height": "220px"
      }
    }
  }
},

References
Developer docs page: https://developer.zendesk.com/documentation/apps/app-developer-guide/manifest/#location.
Checklist

[ ] :guardsman: includes new unit and functional tests

Should packages/zcli/package-lock.json be included in this PR?

It was altered after a yarn install, but I can certainly delete that commit.


Support overriding initial date range via SlickReportView.get_initial().

In a SlickReportView, you can now do:
    def get_initial(self):
        initial = super().get_initial()
        initial['start_date'] = get_n_months_ago(3)
        initial['end_date'] = get_first_of_next_month()
        return initial

(for example, if those two get_... functions are defined elsewhere). This is useful when a specific date range is a characteristic of a given view, and the user won't often need to change it. It addresses the # todo comment in get_initial().

Hello !! Thank you for the PR
I'm planning a merge soon.

Great, thanks!  I'm sorry, I added another commit to this branch to fix another issue - I can try to pull it all apart into a separate branch if you need, but the other addition is small...

Hello @teejaydub
Sorry about the merge conflict, i had many edits in the trunk that i did not merge.
I went to a similar place with start and end date, but i like your way of passing the initial more
Can you revise against the new master ?
Thank you !


Map working

Not sure why DataServlet.java changes are being shown but the only changes I made were to the index.html, script.js & style.css

I think the reason that DataServlet.java changes are showing up is that PR #9 hasn't been merged yet. Can you merge that and then update this PR? I'll do the review after that.

Committed wrong file into branch and do not know how remove. Tried to follow guides that were online but was unsuccessful.

Commenting on the wrong branch sorry


Clean up alert module

Does the pull request solve a related issue?
https://github.com/MichMich/MagicMirror/pull/2679#issuecomment-936231716
What does the pull request accomplish? Use a list if needed.

Switched from manual DOM creation to nunjuck templating
Fix 6 missing translation file references
Cleaned up the code and use more ES6

If it includes major visual changes please add screenshots.
Instead of the black overlay the modules in the background get blurred, similar to MMM-Modal.
Also, the alert and notification style for alert and notification (title and message) were flipped before. Now they use the same.

Codecov Report

Merging #2686 (d0cc0a4) into develop (5ee5fd7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2686   +/-   ##
========================================
  Coverage    69.46%   69.46%
========================================
  Files            8        8
  Lines          262      262
========================================
  Hits           182      182
  Misses          80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee5fd7...d0cc0a4. Read the comment docs.


Edited PR is closed rather than updated

Hello again, I followed your advice to edit the PR to the correct version, however after new changes were merged which required release-plz to update the PR it instead closed the PR and opened a new one. It would be more intuitive if the PR was updated rather than closed, as I'd prefer to be able to update it once and forget rather than needing to remember to edit and release.
https://github.com/XAMPPRocky/octocrab/pull/356
https://github.com/XAMPPRocky/octocrab/pull/362

Hi! I'm sorry you have to open all these issues. I wish release-plz were better and more intuitive. 😅
When release-plz closes a PR?
Release-plz closes the old PR when it contains a commit done by a non-bot account. In https://github.com/XAMPPRocky/octocrab/pull/356 release-plz detected your commits, and so it closed that PR and opened the new one.

Release-plz also closes the release PR when it cannot update it (for example, the force-push fails). (This not the case of this issue).
When release-plz updates a pr?
Release-plz updates a PR when it wasn't updated by a non-bot user.
The update mechanism is simple: overwrite everything and force-push. 💥
Reasoning: changes done by bots are not valuable, so we can overwrite them.
Why release-plz closes a PR?
Release-plz closes a PR instead of updating it (by force-pushing), to prevent loosing precious commits.
If this mechanism weren't in place, release-plz would force-push the new changes, overriding maintainers commits.
Instead, thanks to the closed PR, maintainers can at least cherry-pick their changes in the old PRs and apply them to the new one.
Problem with the current approach

It would be more intuitive if the PR was updated rather than closed, as I'd prefer to be able to update it once and forget rather than needing to remember to edit and release.

I agree that updating it once and forget would be nice.
My approach until now has been different: only look at the release pr when I want to release, do all the changes and merge.

[ ] For sure, there is a gap in the docs I need to document.

Feature request: smart update
What you are proposing is: instead of updating the PR by overwriting everything, release-plz should compare the new changes with the old ones and merge the two.
This involves:

merging the old and the new changelog.
merging the old and the new version.

We need to decide which criteria to use with these merges. I'm not sure it's possible to find good enough rules. I'll give it a try:
Edit changelog
For the changelog, keep the entries that are not duplicated. In this case:

what if people moved the entries from one section of the changelog to another (e.g. from Other to Added)? We would have two duplicate entries.
what if people edit an entry? Again, we would have duplicate entries. Not ideal.

Editing the changelog also implies parsing it properly, which at the moment, we don't do.
The changelog format is not standard (it can be customized with git cliff). Does git-cliff support parsing the changelog? I don't remember now.
Edit version
For the version, we can decide to keep the highest one. E.g. release-plz detects that the next version should be 0.2.1, but the old release pr contains 0.3.0 -> release-plz keeps 0.3.0.
This doesn't work in case of git force-push where somebody rewrites the git-history to remove the breaking commit. Release-plz will always suggest the version (which would be a breaking one).
Conclusion
As you can see, implementing this "smart update" is very difficult, and it can add a lot of complexity in the release-plz codebase.
What do you think?

Hi! I'm sorry you have to open all these issues. I wish release-plz were better and more intuitive. 😅

Don't apologise, real-world user feedback and iterating is how it can become better and more intuitive 🙂 This still a lot better than previous solutions in the space.

What you are proposing is: instead of updating the PR by overwriting everything, release-plz should compare the new changes with the old ones and merge the two.

To be clear, I'm not proposing that. The thing I want as a user is a clear workflow (in the abstract user experience sense, not GitHub workflow) that lets me update the version in the PR, and have that change stick after it updates. For example; I'm totally fine with it not being safe to edit the PR, if there's a workflow for me to update the PR such as the comment we mentioned before.

I agree that updating it once and forget would be nice. My approach until now has been different: only look at the release pr when I want to release, do all the changes and merge.

Yeah, I have a different intention, once I feel like I the automated release PR is good enough, I intend to add a second GitHub workflow that merges these PRs on a regular schedule, completely automating release management out of my hands. So I won't be the "person" merging this PR, which is why for me, if I have to edit the PR, I'd want it to stick and remain the same PR, rather than opening a new one.
 But I think my preferred solution is still having a GitHub comment based interface and requiring all the intended changes to go through that, because it's less complex and more consistent.

Let's go with option 2. I captured this requirement in https://github.com/MarcoIeni/release-plz/issues/704#issuecomment-1606140039


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
17 seconds
sanity-label-check

✅ Succeeded
15 seconds
sanity-optional-label-check

✅ Succeeded
5 seconds
show-summary


Monaco autocomplete colors are incorrect

--dh-color-editor-suggest-fg should be --dh-color-white. Right now we end up w/ black on gray text.

We should also probably add a variable to set --vscode-editorSuggestWidget-selectedForeground to --dh-color-white as well. It is currently set to #ffffff by monaco. This affects the color of the non-matching portion when there is keyboard selection on an autocomplete item.
Might want to set something for the blue colors used in selected/non-selected suggestions as well. Those are --vscode-editorSuggestWidget-highlightForeground and `--vscode-editorSuggestWidget-focusHighlightForeground
Versions

Web UI Version: 0.50.0

Found a "complete" list of Monaco theme variables in an old PR
https://github.com/microsoft/monaco-editor/issues/2622#issuecomment-903632722


performance of gamma sampler with various versions

The PR #1175 greatly improves performance of functions involve many random.split ops. Follow up the discussion there about a regression of gamma sampler, I make a repro script here
from jax import jit, lax, random, vmap
import jax.numpy as np
from jax.config import config; config.update("jax_platform_name", "cpu")

def gamma_one(key, alpha):
    key, subkey = random.split(key)
    boost = np.where(alpha >= 1.0, 1.0, random.uniform(subkey, ()) ** (1.0 / alpha))
    alpha = np.where(alpha >= 1.0, alpha, alpha + 1.0)

    d = alpha - 1.0 / 3.0
    c = 1.0 / np.sqrt(9.0 * d)

    def _cond_fn(kXVU):
        _, X, V, U = kXVU
        return (U >= 1.0 - 0.0331 * X * X) & (np.log(U) >= 0.5 * X + d * (1.0 - V + np.log(V)))

    def _body_fn(kXVU):
        def _next_kxv(kxv):
            k = kxv[0]
            k, subkey = random.split(k)
            x = random.normal(subkey, ())
            v = 1.0 + c * x
            return k, x, v

        key = kXVU[0]
        key, x_key, U_key = random.split(key, 3)
        _, x, v = lax.while_loop(lambda kxv: kxv[2] <= 0.0, _next_kxv, (x_key, 0.0, -1.0))
        X = x * x
        V = v * v * v
        U = random.uniform(U_key, ())
        return key, X, V, U

    _, _, V, _ = lax.while_loop(_cond_fn, _body_fn, (key, 1.0, 1.0, 2.0))
    z = d * V * boost
    return np.where(z == 0, np.finfo(z.dtype).tiny, z)

def gamma_trick_one(key, alpha):
    boost = np.where(alpha >= 1.0, 1.0, random.uniform(key, ()) ** (1.0 / alpha))
    key, = random.split(key, 1)
    alpha = np.where(alpha >= 1.0, alpha, alpha + 1.0)

    d = alpha - 1.0 / 3.0
    c = 1.0 / np.sqrt(9.0 * d)

    def _cond_fn(kXVU):
        _, X, V, U = kXVU
        return (U >= 1.0 - 0.0331 * X * X) & (np.log(U) >= 0.5 * X + d * (1.0 - V + np.log(V)))

    def _body_fn(kXVU):
        def _next_kxv(kxv):
            k = kxv[0]
            x = random.normal(k, ())
            k, = random.split(k, 1)
            v = 1.0 + c * x
            return k, x, v

        key = kXVU[0]
        key, x, v = lax.while_loop(lambda kxv: kxv[2] <= 0.0, _next_kxv, (key, 0.0, -1.0))
        X = x * x
        V = v * v * v
        U = random.uniform(key, ())
        key, = random.split(key, 1)
        return key, X, V, U

    _, _, V, _ = lax.while_loop(_cond_fn, _body_fn, (key, 1.0, 1.0, 2.0))
    z = d * V * boost
    return np.where(z == 0, np.finfo(z.dtype).tiny, z)

gamma_trick = jit(vmap(gamma_trick_one))
gamma = jit(vmap(gamma_one))
rng = random.PRNGKey(0)
alpha = random.uniform(rng, (1000,)) * 2
rngs = random.split(rng, 1000)

then
%time x1 = gamma(rngs, alpha).copy()
%time x2 = gamma_trick(rngs, alpha).copy()
%time x3 = random.gamma(rng, alpha).copy()
assert (np.abs(x1 - x3) > 1e-5).sum() == 0

returns (with JAX 0.1.41)
CPU times: user 2.06 s, sys: 28 ms, total: 2.09 s
Wall time: 2.07 s
CPU times: user 1.41 s, sys: 7.77 ms, total: 1.42 s
Wall time: 1.41 s
CPU times: user 6.01 s, sys: 35.8 ms, total: 6.04 s
Wall time: 6.03 s

To my surprise, time to compile gamma and random.gamma are so different, while the algorithm is the same (modulo precision issues due to using np. vs lax. - I don't understand why precision is 1e-5 but I guess that it is due to how constant values are handled in two implementations). Maybe we should use gamma implementation instead of the current implementation in random.gamma?
In current master branch (after PR #1175), the compiling time of them are
CPU times: user 4.43 s, sys: 11.1 ms, total: 4.45 s
Wall time: 4.42 s
CPU times: user 4.17 s, sys: 31.9 ms, total: 4.21 s
Wall time: 4.2 s
CPU times: user 4.79 s, sys: 16.2 ms, total: 4.8 s
Wall time: 4.78 s

which improves the performance of random.gamma but makes regression for gamma and gamma_trick.
@mattjj I hope the above repro code illustrates some interesting performance issue for JAX/XLA team. :)

Close because gamma sampler is faster with the latest jax release.


Retrieve data from message header

Is there any way to get other data from a message header to oJsonMessage object or just those which are specified? I need to read other values passed there.
Thanks

Or where $mResponse is created for function responseObject($mResponse, $sParent = '', $aParameters = array()) ?


Process manager is changed to PM2 instead of Foreman

use PM2 instead of foreman to  manage rackhd process.
see GG https://groups.google.com/forum/#!topic/rackhd/UfyZ1v9Gdc4
This PR should be merged at the same time with https://github.com/RackHD/RackHD/pull/479  after new version vagrant box be updated.
Related PR:

https://github.com/RackHD/RackHD/pull/478  edit packer script, change foreman to pm2.
https://github.com/RackHD/RackHD/pull/479  edit RackHD readme
https://github.com/RackHD/on-build-config/pull/31 edit Vagrantfile for smoke-test
@panpan0000

what will happen when user issue multiple pm2 start ?

@panpan0000 if use different user , there will be multiple conflicting  process but one user just can start one process for each service.


Fix the response header so that it sets the Kiln pkg version correctly.

Hey noticed that the Kiln pkg version didn't display in the response headers so I fixed it.
I've also tested the solution.  Now it works with this pull request: X-Powered-By: clay v 0.0.1; amphora v 7.5.2; kiln v 8.5.0.  Linting also passed as shown below:
MATL2232LRCOMBS:app rcombs$ npm run lint-js && npm run lint-css

<EMAIL_ADDRESS>lint-js /Users/rcombs/Documents/dev/clay-starter/app
eslint . --cache app.js components search services sites
<EMAIL_ADDRESS>lint-css /Users/rcombs/Documents/dev/clay-starter/app
(for d in styleguides/* ; do stylelint --max-warnings 0 "$d/components/*.css" || exit; done)

Hey @RobCombs ! Nice catch on this one, thank you for the PR. Unfortunately, I don't have the rights to approve this PR 😔 I'll have to bump this to the core team cc: @PedroAlbR @james-owen


Ability to customise generic error message

Versions:

VueJs: v2.5.13
Vee-Validate: 2.0.5

Description:
It would be nice to have the ability to customise the default message. Having The XXX Field is required is not always very user-friendly. The ability to change this message to something like
{
    required: `${1} is required`,
    email: `${1} is not a valid email`
}

Where ${1} is replaced with the field name or the data-vv-as attr.
This would be helpful as we wouldn't then need to generate dictionary files for simple changes like this.
Thoughts? Doable? or not even on the cards?

at the moment its hard to change the messages storage format from getters to static strings but its definitely in the cards. But feel free to submit a PR to make the messages more friendly.


Fixed compilation on UNIX devices

Tested on KDE Neon with 8 gigs of DDR3 and a Celeron J1900. The glitch where the character folder is screwed up until you delete something in it and refresh is gone on UNIX. Nothing else appears to be any different at all.
Remind me to fix the aforementioned glitch on January 2nd. Hit me up if you want my Ubuntu binary otherwise compile with SCons: scons target=editor platform=x11 -j<number of threads your system has or you wanna use>
Contact: https://www.chloecake.com/cont

I didn't mean to do it like that. I usually just use Git but it didn't work for some reason so I used the Github web page which sucks, bye


llamaindex version not updated

installed the latest version, still not find updated llamaindex

We had issues with llamaindex's versions so we fixed it's version to 0.5.24 for now. I will try it with the latest version today and if it's ok, we will make a new release

thats good @ytkimirti , because getting error on vercel deployment issue

Oh I didn't know this was caused by llamaindex, thanks!

We removed llamaindex from our dependencies as it was causing errors @mrsamirr

why not updated llamaindex version to 0.6.2,
as it was mentioned
the llamaindex 0.5.24 causing errors

we are closing the issue as we dropped support for llamaindex.


Start up warnings

Apologies if this has already been reported, I did have a good search but couldn't find anything.
I encountered three minor issues during startup:

npm warning about hubot-maps
connect deprecation warnings
Redis info log gets printed after the first input prompt

$ bin/hubot
npm WARN package.json<EMAIL_ADDRESS>No repository field.
connect deprecated multipart: use parser (multiparty, busboy, formidable) npm module instead node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:56:20
connect deprecated limit: Restrict request size at location of read node_modules/hubot/node_modules/express/node_modules/connect/lib/middleware/multipart.js:86:15
Hubot> [Mon Dec 08 2014 11:36:47 GMT+0000 (GMT)] INFO Using default redis on localhost:6379

Thanks @technicalpickles :+1:


Range Example Glitches upon Resize of the sfGUI Window

The arrow buttons grow to enormous sizes, overlapping each other and being glitchy.

That's because resizing isn't supported unless you explicitly use an sfg::Desktop to manage all your rendering.


DM56 suspect tool issue

When testing DM56 for MY24 support, tool is issuing an incorrect FAIL:

0x30 = ASCII null

0x2A = ASCII '*'
Regardless of using the ASCII * or ASCII null character the J1939-84 tool is issuing a fail.  Below are excerpts from both J1939-73 and J1939-84 text.
J1939-73:

J1939-84:

0x00 is ASCII null.  0x30 is '0'.
BUT, yes, the method the tool uses to check for a null termincator is incorrect.  Your second example should have passed.

The implementation of <IP_ADDRESS>.e was taken very literally: "Fail if engine family has <> 12 characters before first asterisk character (ASCII 2Ah) or “null” character (ASCII 00h)."  I assume this requirement means "Fail if engine family is not exactly 12 characters."  That the field is delimited from another field by *, terminated by null, or terminated by the end of message doesn't matter.

The engine family name is understood to be exactly 12 characters.
This is clear from https://www.epa.gov/ve-certification/information-about-family-naming-conventions-vehicles-and-engines
Which includes

Thus checking for a length of exactly 12 characters after YYYYE-MY (which was defined by CARB) is correct. String termination may be provided by * (2Ah), or null (00h), or omitted altogether.

The response is expected to have 8 + 12 = 20 characters.
A 24 character payload without string termination at byte 21 is incorrect, and should have failed.
The 24 character payload with 2Ah at byte 21 should have passed.
e. Accepts a null (00h) character in addition to 2Ah, in recognition of null’s common use as a string terminator. It appears to be correct.


support tidb to gcs, not suppot gcs to snowflake.

prerequisites:
chomd 777 credential_file__path
export GOOGLE_APPLICATION_CREDENTIALS=credential_file__path

@larry-11 please fix merge master mistake.


x/vuln/cmd/govulncheck: output a final result in json mode

What version of Go are you using (go version)?

# govulncheck  --version
Go: go1.21.0
Scanner<EMAIL_ADDRESS>DB: https://vuln.go.dev
DB updated: 2023-08-23 14:38:50 +0000 UTC

What operating system and processor architecture are you using (go env)?
go env Output
# go env
GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/root/tmp/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build351832300=/tmp/go-build -gno-record-gcc-switches'

What did you do?
执行了以下命令检查漏洞
# govulncheck -json ./...
What did you expect to see?
{
"config": {
"protocol_version": "v1.0.0",
"scanner_name": "govulncheck",
"scanner_version": "v1.0.1",
"db": "https://vuln.go.dev",
"db_last_modified": "2023-08-23T14:38:50Z",
"go_version": "go1.21.0",
"scan_level": "symbol"
}
}
{
"progress": {
"message": "Scanning your code and 48 packages across 1 dependent module for known vulnerabilities..."
}
}
{
"result": {
"status":  true
}
}
What did you see instead?
{
"config": {
"protocol_version": "v1.0.0",
"scanner_name": "govulncheck",
"scanner_version": "v1.0.1",
"db": "https://vuln.go.dev",
"db_last_modified": "2023-08-23T14:38:50Z",
"go_version": "go1.21.0",
"scan_level": "symbol"
}
}
{
"progress": {
"message": "Scanning your code and 48 packages across 1 dependent module for known vulnerabilities..."
}
}

What would be the easiest way for us to reproduce this?

It is also not clear what is being suggested here. The govulncheck command provides streaming json containing the result section. Could it just be that govulncheck did not find anything for your project?

Use the command 'govulncheck-json. /... 'Reproduce.

It is hoped that a key value in the json result of govulncheck can clearly indicate whether there is any vulnerability in the detection result. The current version does not have this key/value, so it cannot be integrated into CI for automation.

govulncheck supports streaming json where typically one will see a config section followed by a progress section, followed by findings. (More info also here). If there are no findings, that means nothing has been found. It is specifically designed for CI automation where the results are communicated as soon as they are computed (hence streaming).
Closing.

Like the following? If the finding property is in, there is a vulnerability; otherwise, there is no vulnerability
root@Ubuntu ~/tmp# govulncheck  -json ./... |jq ".finding" null null null {   "osv": "GO-2021-0113",   "fixed_version": "v0.3.7",   "trace": [     {       "module": "golang.org/x/text",       "version": "v0.3.5",       "package": "golang.org/x/text/language",       "function": "Parse"     },     {       "module": "tmp",       "package": "tmp",       "function": "main",       "position": {         "filename": "/root/tmp/g1.go",         "offset": 189,         "line": 12,         "column": 43       }     }   ] } null {   "osv": "GO-2022-1059",   "fixed_version": "v0.3.8",   "trace": [     {       "module": "golang.org/x/text",       "version": "v0.3.5",       "package": "golang.org/x/text/language"     }   ] }

Yes, and you can have multiple findings.
Each finding will give you the information needed to interpret it. Above, you can see that you have a trace of multiple frames showing you the call stack. That means that the vulnerability was called and the function in the first frame is the vulnerable symbol.
If the trace has only one entry whose function is empty, that means that the vulnerability is only imported.
We plan to write up more detailed documentation about json output.

ok, thanks


Downloaded ckpt_base.pth location

Got the node up and running, thanks!
Looking good.
However, it appears to have dumped .transparent-background/model ckpt_base.pth into the pc's root user folder, which is not optimal.
Is it possible to move that without breaking things to somewhere in comyui's model path, preferably somewhere that can be defined in extra_model_paths.yaml?
Cheers

Hi
Glad you liked it.
I tried to do that but it was more hassle than I initially expected.
Hopefully, I will do it when I find some free time and update the node
Thanks for the suggestion

I tried it, just add one parameter. But need to know it doesn't work for .transparent-background/config.yaml file because it is hardcoded to automatically copy

@lldacing did you resolve this ?

Has been altered https://github.com/john-mnz/ComfyUI-Inspyrenet-Rembg/pull/17

inSPyReNet.pth ? can anyone give me the URL to download this model? it download failed everytime when it started


README.md - clarify IKS01A2 vs. 02A1

Fix for the issue #9 .

https://github.com/AVSystem/Anjay-mbedos-client/pull/11 - probably supercedes this, so probably we could close this one and apply similar changes either as part of (additional commit via #11 ) or do an additional new PR.

@kFYatek #11 - probably supercedes this, so probably we could close this one and apply similar changes either as part of (additional commit via #11 ) or do an additional new PR.

OK, I'll look at #11 first then.


Located milepost markers should be added to a Leaflet GeoJSON layer.

Markers are currently added individually to the map. Set up a GeoJSON layer that will handle the popup logic and add the located points to that layer.

We're migrating from Leaflet to ArcGIS API, so this is no longer applicable.


Templated Repository URL for Git-based catalog URL is not showing rancher

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Run v2.2.0
Open Global -> Tools -> Catalogs

See Git-based catalog URL shown as Git-based catalog URL, e.g. https://github.com//charts.git

Result:
Git-based catalog URL shown as Git-based catalog URL, e.g. https://github.com//charts.git
Expected Result:
Git-based catalog URL shown as https://github.com/rancher/charts.git

Rancher allows us to deploy via helm chats with questions.
Got lab-CI can triggers the rancher envy via pipeline to deploy it.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Sebastiaan van Steenis<EMAIL_ADDRESS>Sent: Wednesday, March 27, 2019 2:17 PM
To: rancher/rancher
Cc: Subscribed
Subject: [rancher/rancher] Templated Repository URL for Git-based catalog URL is not showing rancher (#19215)
What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Run v2.2.0
Open Global -> Tools -> Catalogs

See Git-based catalog URL shown as Git-based catalog URL, e.g. https://github.com//charts.git
[Screen Shot 2019-03-27 at 14 14 46]https://user-images.githubusercontent.com/2620179/55078653-eb0a0980-509a-11e9-9d11-92ce9378ea43.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/rancher/rancher/issues/19215, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ar2AsMJWkl9ZIf35ltH84ZHiHqiTPg_Kks5va29cgaJpZM4cNxbe.

i dont udnerstand the bug @superseb

It should show e.g. https://github.com/rancher/charts.git, appName is not getting translated to rancher in this view.

Note, validated in v2.2.2-rc1 see https://github.com/rancher/rancher/issues/19339#issuecomment-479591530 just needs check again in v2.3 later.

Version: Master (4/4/19) ImageID: 10a1ef90fcbd
I tested again in latest master and had the same findings as in #19339 with v2.2.2-rc1 this is now working.

Open Global -> Tools -> Catalogs
Notice Git-based catalog URL shows example CORRECTLY as https://github.com/rancher/charts.git url

It used to show incorrectly as https://github.com//charts.git


[Project question] Method to Limit gtk.Entry values

gtk.Entey accepts textual data. Is there a way to limit this to numerical values only.  Eg gtk.Entry.SetNumeric(true)

You have:
gtk_entry_set_input_purpose
or
input-purpose
but does not work actually ...
you can handle it manually with signal : preedit-changed

You have:
gtk_entry_set_input_purpose
or
input-purpose
but does not work actually ...
you can handle it manually with signal : preedit-changed

Thanks i found your examples very helpful. I ended up using a gtk.SpinButton. v0.5.2 has the gtk.SpinButton.SetNumeric() method.

Thanks i found your examples very helpful. I ended up using a gtk.SpinButton. v0.5.2 has the gtk.SpinButton.SetNumeric() method.

You have:
gtk_entry_set_input_purpose
or
input-purpose property.
but unfortunately, it does not work actually ...
you can handle it manually with signal : preedit-changed
there is some times, i've made an example it may help you: on 11 Oct 2020
this one uses "inserted-text" signal from de TextBuffer to intercept and change entered values.

Thanks i found your examples very helpful. I ended up using a gtk.SpinButton. v0.5.2 has the gtk.SpinButton.SetNumeric() method.

You have:
gtk_entry_set_input_purpose
or
input-purpose property.
but unfortunately, it does not work actually ...
you can handle it manually with signal : preedit-changed
there is some times, i've made an example it may help you: on 11 Oct 2020
this one uses "inserted-text" signal from de TextBuffer to intercept and change entered values.

Thanks i found your examples very helpful. I ended up using a gtk.SpinButton. v0.5.2 has the gtk.SpinButton.SetNumeric() method.


(DO NOT MERGE) Forbid variable substitution on service's image field

- What I did
Forbid variable substitution on service's image field
- How I did it
Validate the compose file by looking for variables in the image field of the services, group and return an error with all of the infractions
- How to verify it
Use it with a compose that contains a variable in the service's image field.
- Description for the changelog
Forbid variable substitution on services's image field
- A picture of a cute animal (not mandatory but encouraged)

This PR is to be merged as part of #434

PTAL
@silvin-lubecki @simonferquel @rumpl @chris-crone @ijc


Use a separate class to wrap the user queue instead of FSTDispatchQueue

Given the existence of a trivial workaround for the issue motivating this change it seems as if we could just write the equivalent of the FSTUserQueue in C++ directly, no?

@wilhuff If you're okay with the general idea (introduce a separate class, even if it's just a wrapper for dispatch_async, and pass it around to applicable objects), then sure, I can rewrite this in C++.

By the way, I'm a little concerned that if_changed apparently decided this PR doesn't deserve a test run (see Travis run here).

AFAICT this object is largely just the low-level portable interface to dispatch_async that we discussed adding as the underlying primitive we would build the async queue on.

I have a fix forthcoming for travis in #1117.


Add Integration test

Add basic integration test to make sure video compression works

Example run: https://github.com/dhitiwatAgoda/VideoCompress/runs/1159963372


Reset all badges to be based on WeIdentity

Summary

Concisely describe the issue and your solution:
Link to existing issue (type "#" to check):
Specify the tests done so far:

Solutions (Optional)
Please describe the details of your solution if it might be too complicated for reviewers.

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage     49.53%   49.53%
  Complexity     1243     1243
=========================================
  Files           159      159
  Lines          8275     8275
  Branches       1034     1034
=========================================
  Hits           4099     4099
  Misses         3747     3747
  Partials        429      429

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb65e57...8d841b1. Read the comment docs.


Small Correction in Readme

looks good, sorry for the delay on something so simple. It must have escaped us.


Feature/koth update

Patch exploding kings monuments to not die in KOTH. Tested and working.

Tested and working

Tested new unit line and ready to go. Significantly more noticeable than before.

Uploading Age of Empires II_ Definitive Edition 2023-04-22 10-31-21.mp4…
image of new explosion order


Make object-fit and object-position styles important

Description

This adds the !important override to the object-fit and object-position utility classes, much like other utility classes. I suspect those were added later and these two were left behind or forgotten.
Technically a breaking change but I don't think many people if any are using this utility and I believe it's only used in the MudAvatar in MudBlazor. This should be the expected behavior anyway.
Closes #9218
How Has This Been Tested?

visually
Type of Changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

Yeah, it is not a breaking change if it is seen as a bug


Page no longer editable after certain text added to web part configuration

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Regardless of Web Part configuration, when clicking the Edit button on a page in a modern site, the page should go into Edit mode.
Observed Behavior
When a web part is saved with specific text (detailed in steps to reproduce) in the configuration properties, and clicking the Edit button on the page, the following is observed:
A dialog is displayed with:
You cannot edit this page
We're sorry, we encountered an unexpected error. Please try again, if the problem persists please contact your Administrator.
A POST call is made when clicking edit.
POST /sites/ModernSite/_api/sitepages/pages(69)/checkoutpage
The response received has a 500 status code, and a body of:
{"odata.error":{"code":"-1, Newtonsoft.Json.JsonReaderException","message":{"lang":"en-US","value":"Unterminated string. Expected delimiter: \". Path 'properties.description', line 1, position 315."}}}

Steps to Reproduce
Create a Hello World Web Part using all default values:

yo @microsoft/sharepoint
Bundle and Package using the --ship option
Deploy to App Catalog and a Modern Team site
Add the new web Part to a page and set the Description property to:

[[Test]]

Click Save as draft
Click Edit

*Note: This isn't something I could reproduce in the workbench.
Other details
Framework version 1.9.1 with No JavaScript framework.
includeClientSideAssets is true.

Hi @johnguy0, thanks for pointing out that documentation.  I hadn't tried that.
Setting it to isHtmlString: true did indeed fix the Page Corruption issue.  The page can now be saved and edited without issue.
Unfortunately I can't really use that for my scenario, because the data is manipulated within the web part.
After setting the description field to an html string and saving the value [[test]] into that field in the configuration of the web part on a page, the data is changed to
test

So it seems that SharePoint is interpreting [[test]] as a link and converting it.
Here is the update I made based on your info:
protected get propertiesMetadata(): IWebPartPropertiesMetadata {
    return {
      title: { isSearchablePlainText: true },
      description: { isHtmlString: true }
    };
  }

So to summarize, the page no longer being editable is fixed by the propertiesMetadata method and declaring the value as an html string, however since SharePoint manipulates that data, I cannot use it in my web part.
I have changed my solution to use (( and )) and that works ok.  Thanks for your help.

Yes, unfortunately the double brackets are a part of the legacy wiki link syntax.
Another workaround could be to encode/decode the brackets if you didn't want to change your original syntax.


Vacms 9990 refactor staff profile

description

Refactors the Staff Profile Paragraph to its own pure component and adds a dataservice for transforming drupal paragraph data to the display props.
Adds component stories to storybook
Updates component tests for new structure
Updates demo page for new structure

tests
yarn test src/components/staffProfile/staffProfile.test.tsx
yarn run v1.22.17
$ jest src/components/staffProfile/staffProfile.test.tsx
info  - Loaded env from /Users/heffner/dev/next-build/.env.test
warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.

warn  - SWC minify release candidate enabled. https://nextjs.org/docs/messages/swc-minify-enabled
warn  - SWC minify release candidate enabled. https://nextjs.org/docs/messages/swc-minify-enabled
 PASS  src/components/staffProfile/staffProfile.test.tsx
  StaffProfile with valid data
    ✓ renders StaffProfile component (99 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        3.581 s, estimated 4 s
Ran all test suites matching /src\/components\/staffProfile\/staffProfile.test.tsx/i.
✨  Done in 5.54s.
 heffner@MacBook-Pro  ~/dev/next-build   VACMS-9990-refactor-staff-profile ±✚  yarn test src/components/staffProfile/staffProfile.test.tsx
yarn run v1.22.17
$ jest src/components/staffProfile/staffProfile.test.tsx
info  - Loaded env from /Users/heffner/dev/next-build/.env.test
warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.

warn  - SWC minify release candidate enabled. https://nextjs.org/docs/messages/swc-minify-enabled
warn  - SWC minify release candidate enabled. https://nextjs.org/docs/messages/swc-minify-enabled
 PASS  src/components/staffProfile/staffProfile.test.tsx
  StaffProfile with valid data
    ✓ renders StaffProfile component (103 ms)
  StaffProfile with invalid data
    ✓ does not render thumbnail image when prop is null (4 ms)
    ✓ does not render href when linkToBio is false (4 ms)
    ✓ does not render description when prop is null (4 ms)
    ✓ does not render phone number when prop is null or empty (7 ms)
    ✓ does not render email address when prop is null or empty (6 ms)

Test Suites: 1 passed, 1 total
Tests:       6 passed, 6 total
Snapshots:   0 total
Time:        3.6 s
Ran all test suites matching /src\/components\/staffProfile\/staffProfile.test.tsx/i.
✨  Done in 5.37s.

screenshots
demo page - http://localhost:3000/demo/personProfiles

storybook

closed because i got into a rebase loop again... :shrug: