PageView overlayed inside Stack not swiping

I am trying to create a UI that contains a Stack and as children I have PageView and SomeContent(even just a Container is enough to reproduce the issue). When having this kind of configuration then the PageView does not swipe.
Steps to Reproduce
Stack(
fit: StackFit.expand,
children: [
PageView.builder(
controller: _controller,
itemCount: 3,
itemBuilder: (context, index) {
var randomNr = Random().nextInt(400) + 400;
return CachedNetworkImage(
imageUrl: /* it.imageUrl */ "https://picsum.photos/$randomNr",
fit: BoxFit.cover,
);
},
),
Opacity(
opacity: .4,
child: Container(
color: CustomColors.black,
),
),
],
)
Expected results:
The PageView reacts to user input.
Actual results:
The PageView does not react at all

I found a halfbaked solution and that is to add a GestureDetector on top of PageView
like this:
var acceptedDeltaY = MediaQuery.of(context).size.height / 50;
GestureDetector(
onPanUpdate: (data) {
var deltaY = data.delta.dy;
if (deltaY < 0 && deltaY.abs() > acceptedDeltaY) {
_controller.nextPage(
duration: const Duration(seconds: 1),
curve: Curves.easeIn,
);
}
if (deltaY > 0 && deltaY.abs() > acceptedDeltaY) {
_controller.previousPage(
duration: const Duration(seconds: 1),
curve: Curves.easeIn,
);
}
},
child: Stack (...the config above...)
)
I also did add to the PageView
physics: const NeverScrollableScrollPhysics(),
I am nonetheless disappointed that I actually had to face this issue as this should maybe have been just working out of the box. I would not consider the issue solved at this point, I just gave a workaround here for other people that might have the same issue as I have.

Hello @rubinbasha the issue is Opacity is covering the enter stack and its over the pageview so gestures are working with pageview
we can wrap Opacity in IgnorePointer which make pageview to work
Stack(
      fit: StackFit.expand,
      children: [
        PageView.builder(
          controller: _controller,
          itemCount: 3,
          itemBuilder: (context, index) {
            var randomNr = Random().nextInt(400) + 400;
            return Image.network(
              "https://picsum.photos/$randomNr",
              fit: BoxFit.cover,
            );
          },
        ),
        IgnorePointer(
          child: Opacity(
            opacity: .4,
            child: Container(
              color: Colors.black,
            ),
          ),
        )
      ],
    )

@rubinbasha Please check above solution and see if it resolves your issue.
Thanks.

I did try wrapping Opacity in an IgnorePointer but that unluckily did not solve the issue.

@rubinbasha use github markdown, encapsulate your code with three back quotes( ` ).

@rubinbasha
I tried the code sample as mentioned above and was able to swipe properly without any issues.
69247.mp4.zip

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.82, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-IN)
    • Flutter version 1.24.0-4.0.pre.82 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision e5814756a2 (2 days ago), 2020-10-27 01:47:03 -0700
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.11.0 (build 2.11.0-260.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.4 19E2269
      darwin-x64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      86.0.4240.111

• No issues found!

Closing this as non-issue after using the above referred updated code. If you disagree, write in comments and I'll reopen.
Thanks.

@ponnamkarthik thank you for the solution, it works, hip hip hurraaaayy.
@darshankawar yep we can close the issue as now we have a solution for anyone having the same issue. The strange thing is that I have also other things overlaying/covering my PageView but from what I tested more, the Container that has a color is the one actually hijacking the pointer. That is kinda unexpected, to be honest, seems like yet another trick that gets learned only when it hurts and can't be prevented from our devs.
@chinmoy12c thank you for the hint


[Please do not merge] Added flashcard button

Reading through this week's progress reports from classmates, I saw that @ Joshua and @GGilet had said the Add Flashcard button not being there was a stopper for them. I had previously asked Cristopher to handle adding the button and it is currently added in his branch, but there are also other changes there as well. So, I have created this branch, a clean branch, and added an Add Flashcard button for Joshua and Ganaelle. The button will be styled later.
Joshua and Ganaelle,
Please let me know if you are still blocked and/or need anything further. I was not informed that the button not being there was a complete blocker for you.
On a personal note, MVC is pretty easy to manipulate and test changes. You can go to a URL that the Controller creates without having a direct path in the UI to it. Another option would have been to use an existing button and temporarily change its function (this is the route I probably would have gone, as I prefer things to feel more real). Another option would have been to just add the button yourself.

Are we intending to merge this at some point, or is just a placeholder while the button gets added in another branch as part of a bigger feature set?

Hi @dyohn,
Yes, it's just a place holder. @Chriscruzz17 has been working on the finished-out and styled button in his branch. But, I believe that @jpb12d and @GGilet had needed it quicker, so I created this to see if there was anything else that I could do to unblock Joshua and Ganaelle's changes.
Rachel

@rlayman87 Thank you for adding! Much appreciated!!

No problem, @jpb12d!
If you need anything else, please let me or @Chriscruzz17 know!!
Closing the PR.


Building on Windows not requiring Powershell

If one wants to build on Windows, there could be options:

Use WSL when on Windows 10
Use something like Babun to have a better cygwin and there is the pact package manager (an apt-get like thing). This can help in building lots of things.

I will try out the build under WSL.

Manually building dependencies is no longer required. These dependencies are being build automatically on Travis and Appveyor, and now they are fetched after baseline loading.


Crash on Server-Side for 1.20.1

Describe the issue
Server crashes when this and its dependents are installed with FTB family of mods as mentioned in #124

.

Minecraft Version
1.20.1 forge

.

Mod Version
1.11.6 and 1.11.4 at minimum

.

Modloader(Fabric/Forge/NeoForge)
Forge

.

Modloader Version
47.3.12 and 47.3.22

.

Additional Info (Crashlog/Modlist)
Log, modlist, and crashlog

.

Should be fixed in 1.11.7


(BOLT-1154) Remove unnecessary guard conditions in plan functions

BOLT-1131 introduced a guard condition that prevents select plan functions from bein executed in an apply block. Specifically if Puppet[:tasks] is not truthy then an error is raised. This commit removes redundant conditionals to ensure the plan functions are runnable by the plan.

In some cases we would check for Puppet.features.bolt?. Is that something we should keep? It seems that it used to be common to gate on existence of Puppet.lookup(:bolt_inventory) is that a check that pre-dated Pupet.features.bolt? that can be replaced? Is there a case where Puppet[:tasks]would be true andPuppet.lookup(:bolt_inventory or :bolt_executor)` would be false?

CLA signed by all contributors.

I don't think we need to be checking for Puppet.features.bolt?. That just checks that require 'bolt' works, which it must.
These checks would be more relevant if we were shipping boltlib outside Bolt, but we're not. So it must be the case that they're being called from Bolt. In that case, the only meaningful check is for Puppet[:tasks] to determine whether or not we're running as plan code or as apply code.
We can also probably remove the default blocks for the calls to Puppet.lookup, since we explicitly expect that they can never fail.


Suspending the MapViewContent component will crash the map with React 18

https://github.com/nismod/irv-frontend/blob/e32a9ba0fc52b8fff80a25e10c4f9d1f95b08d75/src/map/MapView.tsx#L26-L44
Heads up that the Recoil state here works fine with React 17, but crashes with the new createRoot(node).render() in React 18. Moving the Recoil state down into individual components fixes it. I think that the React Map GL Map component crashes if it renders while suspended, but only with the new concurrent rendering API.
See also:

https://github.com/nismod/irv-jamaica/issues/41
https://github.com/visgl/react-map-gl/issues/1960#issuecomment-2187475808

Moving to React 18 in general would be desirable, however at this point this has been held back by the dependencies of react-spring-bottom-sheet: (see rationale in https://github.com/nismod/irv-frontend/pull/18 ). Does the bottom drawer on a mobile layout work despite that when updating?
If we managed to replace this by vaul as discussed in https://github.com/nismod/irv-frontend/issues/17 - I think that would remove the last blockers to an update.
However, there has been an issue with react-map-gl + deck.gl + react 18 that hasn't been resolved in a long time (something to do with 18's batching of updates and its impact on map interactivity) - we'd have to check if this appears when updating.

I haven't seen any problems on https://jamaica.infrastructureresilience.org, since moving that code to React 18 in June.


Layout switching configuration with dynamic property support

Description
This feature includes,

Switching between 5 different layouts row-left,  row-left-swapped, row-spread,  row-spread-swapped which is similar with ui-text node
Dynamic property support for the newly added layout property
Docs updated for the newly added property Layout and marked dynamic: true in the docs for the existing dynamic properties which haven't marked previously
Necessary E2E tests are added

Related Issue(s)
https://github.com/FlowFuse/node-red-dashboard/issues/1236
Checklist

[x] I have read the contribution guidelines
[x] Suitable unit/system level tests have been added and they pass
[x] Documentation has been updated

[ ] Upgrade instructions
[ ] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

Ready for review @gayanSandamal?

Yes, I was waiting for tests to pass. I'm marking this as ready for review

The PR is updated. only the usual ❌  widgets/control.spec.js fails


[Question] can I put properties for spring cloud bus in confimap?

spring:
  cloud:
      bus:
        refresh:
          enabled: false #disable this because we are going to provide our own refresh listener for testing purposes
        enabled: false

Hello, Can i put the above block of properties in configmap and refresh config with kafka and spring cloud kubernetes config watcher.
But I am concerned about that once i set spring.cloud.bus.refresh.enabled = false I can not make my app reload the conifg with kafka and spring cloud kubernetes config watcher anymore.
Thanks a lot !

Yes if you place that in a configmap with the name spring-cloud-kubernetes-configuration-watcher when the config watcher starts it should pull in that configuration and use it.  If you then make a change to that configuration, for example changing enabled to true the config watcher should reload its configuration from that configmap

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Still asking me to backup when I use "-b"

There's no need to ask whether a user wants a backup when he uses the "-b" arg.

I'll look into it, but I think I can make a quick fix for that

-b should be silent in v1.2.9 now.
https://github.com/taskinoz/RSPNVPK/releases/tag/v1.2.9


Error: Html alias has already been loaded with v3.2.1

Issue from #107
@nrother

dev-master has currently set CakePHP < 3.4.0 as a requirement. Using v.3.2.1.x-dev throws an exception:
The "Html" alias has already been loaded with the following config: array (...) which differs from array ( 'className' => 'Bootstrap.Html', )

When is this exception thrown? Could you show me the code where you load the helpers?
I have changed the names of the helpers in v3.2.1 (Bootstrap.BootstrapHtmlHelper -> Bootstrap.HtmlHelper), but the old names are still there for compatibility so this should not be an issue...
I cannot reproduce the error with a fresh CakePHP 3.4.0 install with v3.2.1.

After a bit of testing, this seems to happens if you load the Bootstrap.HtmlHelper twice, but with different configs, e.g.:
// In your AppController
public $helpers = [
    'Html' => [
        'className' => 'Bootstrap.BootstrapHtml'
    ]
];

// In your AppView
public function initialize() {
    $this->loadHelper('Html', [
        'className' => 'Bootstrap.Html'
    ]);
}

I don't think it is directly related to the helpers... Did you modify anything related to the names of the helpers?

I did not modify any of the settings, I think it must be releated to one
of your last changes... I'll look into this tomorrow.
I just load the helper once in the AppController, but maybe I'm doing
something strange there...
Am 16.02.2017 um 21:53 schrieb Mikaël Capelle:

When is this exception thrown? Could you show me the code where you load
the helpers?
I have changed the names of the helpers in v3.2.1
(|Bootstrap.BootstrapHtmlHelper| -> |Bootstrap.HtmlHelper|), but the old
names are still there for compatibility so this should not be an issue...
I cannot reproduce the error with a fresh CakePHP 3.4.0 install with v3.2.1.

After a bit of testing, this seems to happens if you load the
|Bootstrap.HtmlHelper| twice, but with different configs, e.g.:
// In your AppController
public $helpers = [
'Html' => [
'className' => 'Bootstrap.BootstrapHtml'
]
];
// In your AppView
public function initialize() {
$this->loadHelper('Html', [
'className' => 'Bootstrap.Html'
]);
}
I don't think it is directly related to the helpers... Did you modify
anything related to the names of the helpers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Holt59/cakephp3-bootstrap-helpers/issues/109#issuecomment-280456767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGdQVwoCZxNk4a5vIr_bWz10m71-8xekks5rdLc_gaJpZM4MDh4B.

Could you enable debug and show me the stack trace?

Could you:

Show me exactly how you load the helpers? In particular if you changed something to Bootstrap.Html?
Enable debug and show me a stack trace of the error?
Try to clear the cache and see if the errors persists?

This is how I load the helpers in my AppController:
public $helpers = [
	'Html' => [
		'className' => 'Bootstrap.BootstrapHtml'
	],
	'Form' => [
		'className' => 'Bootstrap.BootstrapForm',
		'widgets' => [
		    'datePicker' => ['DatePicker', '_view'],
		    'static' => ['StaticControl'],
		],
		'templates' => [
		    'staticControl' => '
{{value}}
',
		],
		'columns' => [
		    'label' => 2,
		    'input' => 6,
		    'error' => 4
		]
	]
];

Stacktrace:
⟩ Cake\View\Helper\FormHelper->postLink
⟩ Cake\View\Helper->__get
⟩ Cake\View\View->loadHelper
⟩ Cake\Core\ObjectRegistry->load
⟩ Cake\Core\ObjectRegistry->_checkDuplicate

This line seems to be the problem:
$out .= $this->Html->link($title, $url, $options);

The error is throw at FormHelper::postLink, which seems to be the first call to the FormHelper which is not overridden by the Plugin. The same error is triggered by calling Paginator::numbers(), even though this method is overridden by the plugin...
The problem is fixed by changing all helper names to the new version (without "Bootstrap").

I see where the problem comes from, actually it also happens if you load the standard Html helper together with the Bootstrap ones.
The helpers used internally be other helpers (the Form helper here) are synchronized with the helpers used by the view. Since the Form helpers is using Bootstrap.Html internally, there is a conflict if you use Bootstrap.BootstrapHtml or Html (the standard Cake helper) for your view.
This is something that also happens with 3.1.0 if you use the standard CakePHP helper, so I will try to fix this.

This should be fixed by f4e5bd66c71a62323974fd9a0ebfaf4b125c0edb.
Note: The helpers are now linked to the helpers used by the view, so some restrictions apply:

the Html helper set up for the view must be Bootstrap.Html in order to use the easy-icon feature;
the searchForm() and button() methods of the navbar helper will not work as expected if the Form helper set for the view is not Bootstrap.Form.

I will add these notes to the documentation as soon as possible.

I am closing this since this should be fixed by now, feel free to (re-)open if you still have troubles!


Failed Workflows due to Failure while creating WQE's

Around 50 of these wfs failed after being staged[1] . Upon checking the WorkQueue Error logs for one request[2], it failed due to “input data has no locations”. However the data is transfered in Rucio and is in OK state[3].
The issue happened between staged to acquired transition, so as I understand the workflow wasn't able to get to a agent because no WQE was created, as the wf failed while creating the WQE.
The transferor ms however shows 57.38% transfer completion[4].
Workqueue logs:
INFO:reqmgrInteraction:Processing request pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349 at https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/spec
INFO:reqmgrInteraction:queueWork() begin queueing "https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/spec"
INFO:reqmgrInteraction:Executing processInboundWork with 1 inbound_work, throw: True and continuous: False
INFO:reqmgrInteraction:Splitting /pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/BTV-Run3Summer22NanoAODv12-00043_0 with policy name Dataset and policy params {'name': 'Dataset', 'args': {}}
ERROR:reqmgrInteraction:Terminal exception splitting WQE: {'Status': 'Negotiating', 'TeamName': 'production', 'WMBSUrl': None, 'WMSpec': <WMCore.WMSpec.WMWorkload.WMWorkloadHelper object at 0x7fe322af6e80>, 'RequestName': 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349', 'StartPolicy': {'policyName': 'Dataset', 'SliceType': 'NumberOfEvents', 'SplittingAlgo': 'EventAwareLumiBased', 'OpenRunningTimeout': 0, 'blowupFactor': 1, 'SliceSize': 84656}, 'EndPolicy': {'policyName': 'SingleShot'}, 'OpenForNewData': True, 'Inputs': {}, 'ProcessedInputs': [], 'RejectedInputs': [], 'PileupData': {}, 'ParentData': {}, 'ParentFlag': False, 'Jobs': 0, 'SiteWhitelist': [], 'SiteBlacklist': [], 'Dbs': None, 'Task': None, 'ParentQueueId': None, 'Priority': 0, 'SubscriptionId': None, 'EventsWritten': 0, 'FilesProcessed': 0, 'PercentComplete': 0, 'PercentSuccess': 0, 'TaskName': None, 'ACDC': {}, 'ChildQueueUrl': None, 'ParentQueueUrl': None, 'NumberOfLumis': 0, 'NumberOfEvents': 0, 'NumberOfFiles': 0, 'NumOfFilesAdded': 0, 'Mask': None, 'TimestampFoundNewData':<PHONE_NUMBER>, 'NoInputUpdate': False, 'NoPileupUpdate': False, 'CreationTime':<PHONE_NUMBER>}
ERROR:reqmgrInteraction:Failing workflow "pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349": Invalid WMSpec: 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349': Input data has no locations "/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM"
CRITICAL:reqmgrInteraction:Permanent failure processing request "pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349": Invalid WMSpec: 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349': Input data has no locations "/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM"
INFO:reqmgrInteraction:Marking request pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349 as failed in ReqMgr

[1] https://dmytro.web.cern.ch/dmytro/cmsprodmon/requests.php?campaign=Run3Summer22NanoAODv12&ds_pattern=JMENano12p5
[2] https://cmsweb.cern.ch/reqmgr2/fetch?rid=pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349
[3] https://cms-rucio-webui.cern.ch/rule?rule_id=7c13f7a1b04c46f6bb4811cdf631b682#locks
[4] https://cmsweb.cern.ch/ms-transferor/data/info?request=pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349
@amaltaro @haozturk

If I read the code right the exception happened at this line:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/WorkQueue.py#L1073
The observations comes from missing log entry Work splitting completed after posted Splitting .... Therefore, to understand the issue someone should clarify to me and others how WQ policy works. Since we're dealing with dataset I think  https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/Policy/Start/Dataset.py is used.

@vkuznet Valentin, I didn't check the logs, but usually when we fail a workflow, this is the exception that we hit in global workqueue:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/WorkQueue.py#L1162
To help with this debugging, I would suggest you to take 1 or 2 workflows and:

cross-check the time of workflow acquisition in global workqueue
compare it with what was knew to MSMonitor (check the logs)
check the status of transfers - might be a double check of the step above - using this API (note that you need to replace the workflow name): https://cmsweb.cern.ch/reqmgr2/data/transferinfo/pdmvserv_Run2023C_ZeroBias5_22Sep2023_v4_231019_184341_3923
as you already figured out, depending on the workflow construction, they can have different workqueue start policy. Meaning being: Dataset: the whole dataset is placed as a whole and needs to be available within the same location/RSE; Block: a full block is placed at a given location (but many blocks are likely placed for the same workflow).
IMO it will be important to know if the input data was being retrieved from another Disk endpoint or straight from Tape. For this you might have to contact the DM team.

I would like to connect you with @todor-ivanov and @khurtado as well to provide further assistance to this issue, in case I don't manage to follow this closely.

Alan, to start working on this I need to know the following:

what is workqueue location of the logs, so far I assumed that it is under vocms0750:/cephfs/product/dmwm-logs/workqueue-2023*, is it correct or anything else
I scan already logs in vocms0750:/cephfs/product/dmwm-logs//workqueue-2023111* and I can't find any failed workflow shown in original ticket description. Moreover, I can't find patterns, like "Terminal exception splitting WQE", or "Permanent failure processing request", am I looking into wrong logs or what is proper timestamp of the log I need to look at? We do have zipped old-logs archives but I need to know which date to use
please specify where to check transfer status as I have no idea
to contact DM team about disk/tape transfer which channel I should use (again I never did such activity before and therefore have no a-prior knowledge where to look at).

I checked old-logs and found listed exception. Upon further checks I see strange correlation in WQ logs, like this:
ERROR:reqmgrInteraction:Unknown error processing ahmedmu_ACDC1_Run2022E_ZeroBias_30May2023v2_230829_130657_7479
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/WorkQueueReqMgrInterface.py", line 108, in queueNewRequests
    units = queue.queueWork(workLoadUrl, request=reqName, team=team)
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/WorkQueue.py", line 646, in queueWork
    work = self.processInboundWork(inbound, throw=True)
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/WorkQueue.py", line 1133, in processInboundWork
    work, rejectedWork, badWork = self._splitWork(inbound['WMSpec'], data=inbound['Inputs'],
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/WorkQueue.py", line 1073, in _splitWork
    units, rejectedWork, badWork = policy(spec, topLevelTask, data, mask, continuous=continuous)
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/Policy/Start/StartPolicyInterface.py", line 161, in __call__
    self.split()
  File "/usr/local/lib/python3.8/site-packages/WMCore/WorkQueue/Policy/Start/ResubmitBlock.py", line 70, in split
    Jobs=ceil(float(block[self.args['SliceType']]) /
KeyError: 'NumberOfRuns'
INFO:reqmgrInteraction:Processing request pdmvserv_task_GEN-Run3Summer22NanoAODv12-00377__v1_T_231030_152553_9919 at https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_GEN-Run3Summer22NanoAODv12-00377__v1_T_231030_152553_9919/spec
INFO:reqmgrInteraction:queueWork() begin queueing "https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_GEN-Run3Summer22NanoAODv12-00377__v1_T_231030_152553_9919/spec"
INFO:reqmgrInteraction:Executing processInboundWork with 1 inbound_work, throw: True and continuous: False
INFO:reqmgrInteraction:Splitting /pdmvserv_task_GEN-Run3Summer22NanoAODv12-00377__v1_T_231030_152553_9919/GEN-Run3Summer22NanoAODv12-00377_0 with policy name Dataset and policy params {'name': 'Dataset', 'args': {}}
ERROR:reqmgrInteraction:Terminal exception splitting WQE: {'Status': 'Negotiating', 'TeamName': 'production', 'WMBSUrl': None, 'WMSpec': <WMCore.WMSpec.WMWorkload.WMWorkloadHelper object at 0x7fe2f4413d60>, 'RequestName': 'pdmvserv_task_GEN-Run3Summer22NanoAODv12-00377__v1_T_231030_152553_9919', 'StartPolicy': {'policyName': 'Dataset', 'SliceType': 'NumberOfEvents', 'SplittingAlgo': 'EventAwareLumiBased', 'OpenRunningTimeout': 0, 'blowupFactor': 1, 'SliceSize': 84656}, 'EndPolicy': {'policyName': 'SingleShot'}, 'OpenForNewData': True, 'Inputs': {}, 'ProcessedInputs': [], 'RejectedInputs': [], 'PileupData': {}, 'ParentData': {}, 'ParentFlag': False, 'Jobs': 0, 'SiteWhitelist': [], 'SiteBlacklist': [], 'Dbs': None, 'Task': None, 'ParentQueueId': None, 'Priority': 0, 'SubscriptionId': None, 'EventsWritten': 0, 'FilesProcessed': 0, 'PercentComplete': 0, 'PercentSuccess': 0, 'TaskName': None, 'ACDC': {}, 'ChildQueueUrl': None, 'ParentQueueUrl': None, 'NumberOfLumis': 0, 'NumberOfEvents': 0, 'NumberOfFiles': 0, 'NumOfFilesAdded': 0, 'Mask': None, 'TimestampFoundNewData':<PHONE_NUMBER>, 'NoInputUpdate': False, 'NoPileupUpdate': False, 'CreationTime':<PHONE_NUMBER>}

I checked couple of logs and such behavior is there. I wonder if thrown exception with NumberOfRuns may caused later an issue within the same thread. I do not want to spend too much time on shown exception unless I'll be told otherwise, but it happens over here https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/Policy/Start/ResubmitBlock.py#L70 and I have no idea how/where NumberOfRuns come from. @amaltaro please advise.

The error above is unrelated, see for further information: https://mattermost.web.cern.ch/cms-o-and-c/pl/d9fbh3anfidt5mxsogagocuksw
In addition, you are reporting an error for a workflow that is in staged status, while this ticket report problems with workflows in failed status.

Further digging through the code. The actual exception happen in here: https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/WorkQueue/Policy/Start/StartPolicyInterface.py#L141 which asks spec for Inputs and see that there is no site. According to the log the spec indeed does not show any inputs. Therefore, we need to find out who provided the spec which does not have inputs and where it is constructed. @amaltaro any thoughts on this find?
Another observations:

workqueue log does not record timestamps at all !!! Why is that? Why logs does not have any timestamp?
who generate reqmgrInteractionTask-workqueue log? I found it when I scan for workflow name and it contains timestamp for this workflow 2023-10-30 19:58:05,113 which shows splitting error
according to reqmgr2 json, the staged transition state happen at 2023-10-30 19:49:37 UTC
while, failed status recorded at 2023-10-30 19:58:09 UTC
therefore, if I'll take timestamp of reqmgrInteractionTask-workqueue we have window between 2023-10-30 19:49:37 UTC and 2023-10-30 19:58:05,113 during which wf failed. It is about 10 minutes and I don't know how to check DM side for it.

So, in order to proceed I need to know where Inputs in spec are generated as they were not provided for splitting and according to the code logic the proper exception was thrown.

I checked MSOutput and other MS services for appearance of %2FQCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8%2FRun3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2%2FMINIAODSIM dataset (it should be properly url encoded). And, I found that MSoutput does not have any entries about it, while ms-rulecleaner does, in latter case all requests to rucio were ok. I also checked DAS for dataset presence and it shows that it indeed fully present at T1_DE_KIT (both disk and tape), therefore I would conclude that transfer itself was fine. Said that, as I wrote about it looks like the dataset splitting fail due to missing inputs and so far I have no idea how this is done. @amaltaro any further suggestions?

Valentin, on your question about which log file to use, we need to check reqmgrInteractionTask-workqueue-XXX.log, which is the workqueue cherrypy thread responsible for acquiring work from ReqMgr2 and splitting it into workqueue elements. BTW, you will see it has timestamps.
There is nothing in MSOutput relevant for this debugging, the microservice that I mentioned above is MSMonitor. MSRuleCleaner is performing cleanup, which is irrelevant to this debugging as well.
Looking for data presence in DAS does not give us a good answer either, as it's simply checking data location regardless of who locked the data. For WM, we only care about data that is available under our own rules (locks).
The question that we need to answer is: when the workflow was acquired (or processed) in global workqueue, was the input data requested by the workflow fully available on Disk (under the WM-created rules)?

The MSMonitor uses slashes instead of escaped %2F, that's why I haven't see it. The entries for dataset in question is:
2023-10-30 19:46:15,666:DEBUG:MSMonitor: Rule ID: 7c13f7a1b04c46f6bb4811cdf631b682, DID: /QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM, state: REPLICATING, grouping: ALL, rse_expression: T2_US_Caltech|T2_RU_JINR|T2_EE_Estonia|T2_IT_Rome|T2_BR_SPRACE|T2_ES_IFCA|T1_IT_CNAF_Disk|T2_US_Florida|T2_UK_London_IC|T2_US_MIT|T2_FR_GRIF_IRFU|T2_US_Vanderbilt|T2_US_Wisconsin|T2_US_Nebraska|T1_RU_JINR_Disk|T2_BE_UCL|T2_IT_Pisa|T2_BR_UERJ|T2_FR_GRIF_LLR|T2_US_Purdue|T2_PL_Swierk|T2_CH_CSCS|T2_UK_SGrid_Bristol|T2_US_UCSD|T2_ES_CIEMAT|T2_BE_IIHE|T2_CH_CERN|T1_DE_KIT_Disk|T1_US_FNAL_Disk

which lists T1_DE_KIT site. And, matching ruleid I see that
2023-10-30 19:46:15,666:INFO:MSMonitor: Rule ID: 7c13f7a1b04c46f6bb4811cdf631b682 has a completion rate of: 57.831325301204814%

So, MSMonitor shows 57% of completion. The timestamp is 3 min away from the one shown in  WQ logs. Does it mean that the dataset was not migrated?

I checked another wf: pdmvserv_task_GEN-Run3Summer22NanoAODv12-00361__v1_T_231103_003952_2508 from Dima's list. This uses /G-4Jets_HT-200to400_TuneCP5_13p6TeV_madgraphMLM-pythia8/Run3Summer22NanoAODv12-JMENano12p5_132X_mcRun3_2022_realistic_v3-v1/NANOAODSIM
dataset and it is listed as stated in MSMonitori
2023-11-03 06:16:06,434:DEBUG:MSMonitor: Checking transfers for: pdmvserv_task_GEN-Run3Summer22NanoAODv12-00361__v1_T_231103_003952_2508
2023-11-03 06:16:06,445:INFO:MSMonitor: pdmvserv_task_GEN-Run3Summer22NanoAODv12-00361__v1_T_231103_003952_2508 OK, all transfers completed or above threshold, move it on.
2023-11-03 06:16:06,675:INFO:ReqMgrAux: Update in-place: False for transfer doc: pdmvserv_task_GEN-Run3Summer22NanoAODv12-00361__v1_T_231103_003952_2508 was successful.
6179:2023-11-03 06:16:07,332:INFO:MSCore: MSMonitor updating pdmvserv_task_GEN-Run3Summer22NanoAODv12-00361__v1_T_231103_003952_2508 status to: staged

This is different from pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349 workflow which shows 57% completion in MSMonitor.

and, yet another wf pdmvserv_task_BTV-Run3Summer22NanoAODv12-00056__v1_T_231101_121341_3043
2023-11-01 17:06:51,188:DEBUG:MSMonitor: Checking transfers for: pdmvserv_task_BTV-Run3Summer22NanoAODv12-00056__v1_T_231101_121341_3043
2023-11-01 17:06:54,068:INFO:MSMonitor: pdmvserv_task_BTV-Run3Summer22NanoAODv12-00056__v1_T_231101_121341_3043 OK, all transfers completed or above threshold, move it on.
2023-11-01 17:06:54,692:INFO:ReqMgrAux: Update in-place: False for transfer doc: pdmvserv_task_BTV-Run3Summer22NanoAODv12-00056__v1_T_231101_121341_3043 was successful.
2023-11-01 17:07:07,632:INFO:MSCore: MSMonitor updating pdmvserv_task_BTV-Run3Summer22NanoAODv12-00056__v1_T_231101_121341_3043 status to: staged

which is listed as staged in MSMonitor.

To proceed someone should explain to me how splitting algorithm works. At this point I don't see that for last two workflows we had any issues with Rucio, but yet the Inputs were empty and it caused the exception to terminate the workflows. This leads me only to one direction, to investigate the splitting algorithm. Can someone (@amaltaro  or @todor-ivanov ) explain what splitting means when we have single dataset, what it does or suppose to do, and which codebase is responsible for it.

I scan few more workflows and found very suspicious correlation, that lots of workflows were failed approximately at the same time, e.g.:
pdmvserv_task_PPD-Run3Summer22NanoAODv12-00007__v1_T_231030_173340_87
failed: 2023-10-30 19:59:34 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00042__v1_T_231030_173333_9435
failed: 2023-10-30 19:56:12 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00041__v1_T_231030_173325_3835
failed: 2023-10-30 19:55:17 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00040__v1_T_231030_173328_4644
failed: 2023-10-30 19:58:47 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00039__v1_T_231030_173319_1967
failed: 2023-10-30 19:56:58 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00038__v1_T_231030_173308_6228
failed: 2023-10-30 19:56:08 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00037__v1_T_231030_173314_7744
failed: 2023-10-30 19:56:53 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00036__v1_T_231030_173321_9101
failed: 2023-10-30 20:00:43 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_EGM-Run3Summer22NanoAODv12-00035__v1_T_231030_173301_4127
failed: 2023-10-30 19:58:51 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_BTV-Run3Summer22NanoAODv12-00064__v1_T_231030_173252_227
failed: 2023-10-30 19:59:20 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_BTV-Run3Summer22NanoAODv12-00063__v1_T_231030_173248_8080
failed: 2023-10-30 19:59:18 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_BTV-Run3Summer22NanoAODv12-00062__v1_T_231030_173224_1709
failed: 2023-10-30 19:55:43 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

pdmvserv_task_BTV-Run3Summer22NanoAODv12-00061__v1_T_231030_173219_5947
failed: 2023-10-30 19:58:12 UTC DN: /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=msunmer/CN=852819/CN=Robot: WmCore Service Account

So within couple of minutes lots of workflows failed which may implies that we had some issues with some service/network. I was trying to look at behavior of MS services at this timestamp in CMS Monitoring but turns out that MS service monitoring page https://monit-grafana.cern.ch/d/JIz-EqvVz/wmcore-ms-services?orgId=11&refresh=1m&from=now-7d&to=now does not have any metrics (new CMSMONIT-584 issue which II file to CMSWEB/CMS Monitoring). I need more time to check logs for these workflows. Will update this comment once I get into them.

@vkuznet  Upon a long  review of the logic in WMCore, I do not see this  behavior here as a bug.  WMCore system is doing the right thing here - it simply fails the workflows without intersection between SiteWhitelist and the those having the  datasets (the start policy for those workflows is: with policy name Dataset and policy params {'name': 'Dataset', 'args': {}})
At the same time these workflows are having:   "TrustSitelists": false,

I had a look at the very first workflow reported in this ticket, which is:
https://cmsweb.cern.ch/reqmgr2/fetch?rid=pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349
and here are my observations:

it entered the staged status on 2023-10-30 19:49:37 UTC; and failed ~10min later
it has around 30 allowed sites and a list of 10 or so disallowed sites;
it has TrustSitelists: false
it has TrustPUSitelists: false, it has no pileup
input dataset /QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM has 35 blocks

Global WorkQueue logs (WorkQueueReqMgrInterface thread) are:
2023-10-30 19:58:04,707:INFO:WorkQueueReqMgrInterface:Processing request pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349 at https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/spec
2023-10-30 19:58:04,708:INFO:WorkQueue:queueWork() begin queueing "https://cmsweb.cern.ch/couchdb/reqmgr_workload_cache/pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/spec"
2023-10-30 19:58:04,990:INFO:WorkQueue:Executing processInboundWork with 1 inbound_work, throw: True and continuous: False
2023-10-30 19:58:05,113:INFO:WorkQueue:Splitting /pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349/BTV-Run3Summer22NanoAODv12-00043_0 with policy name Dataset and policy params {'name': 'Dataset', 'args': {}}
2023-10-30 19:58:07,275:ERROR:WorkQueue:Terminal exception splitting WQE: {'Status': 'Negotiating', 'TeamName': 'production', 'WMBSUrl': None, 'WMSpec': <WMCore.WMSpec.WMWorkload.WMWorkloadHelper object at 0x7fe322af6e80>, 'RequestName': 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349', 'StartPolicy': {'policyName': 'Dataset', 'SliceType': 'NumberOfEvents', 'SplittingAlgo': 'EventAwareLumiBased', 'OpenRunningTimeout': 0, 'blowupFactor': 1, 'SliceSize': 84656}, 'EndPolicy': {'policyName': 'SingleShot'}, 'OpenForNewData': True, 'Inputs': {}, 'ProcessedInputs': [], 'RejectedInputs': [], 'PileupData': {}, 'ParentData': {}, 'ParentFlag': False, 'Jobs': 0, 'SiteWhitelist': [], 'SiteBlacklist': [], 'Dbs': None, 'Task': None, 'ParentQueueId': None, 'Priority': 0, 'SubscriptionId': None, 'EventsWritten': 0, 'FilesProcessed': 0, 'PercentComplete': 0, 'PercentSuccess': 0, 'TaskName': None, 'ACDC': {}, 'ChildQueueUrl': None, 'ParentQueueUrl': None, 'NumberOfLumis': 0, 'NumberOfEvents': 0, 'NumberOfFiles': 0, 'NumOfFilesAdded': 0, 'Mask': None, 'TimestampFoundNewData':<PHONE_NUMBER>, 'NoInputUpdate': False, 'NoPileupUpdate': False, 'CreationTime':<PHONE_NUMBER>}
2023-10-30 19:58:07,349:ERROR:WorkQueue:Failing workflow "pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349": Invalid WMSpec: 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349': Input data has no locations "/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM"
2023-10-30 19:58:08,469:CRITICAL:WorkQueueReqMgrInterface:Permanent failure processing request "pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349": Invalid WMSpec: 'pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349': Input data has no locations "/QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM"
2023-10-30 19:58:08,470:INFO:WorkQueueReqMgrInterface:Marking request pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349 as failed in ReqMgr

while MSMonitor logs are:
2023-10-30 19:46:15,658:DEBUG:MSMonitor: Checking transfers for: pdmvserv_task_BTV-Run3Summer22NanoAODv12-00043__v1_T_231030_153236_8349
2023-10-30 19:46:15,665:DEBUG:connectionpool: http://cms-rucio.cern.ch:80 "GET /rules/7c13f7a1b04c46f6bb4811cdf631b682 HTTP/1.1" 200 1367
2023-10-30 19:46:15,666:INFO:MSMonitor: Rule ID: 7c13f7a1b04c46f6bb4811cdf631b682 has a completion rate of: 57.831325301204814%
2023-10-30 19:46:15,666:DEBUG:MSMonitor: Rule ID: 7c13f7a1b04c46f6bb4811cdf631b682, DID: /QCD_PT-15to20_MuEnrichedPt5_TuneCP5_13p6TeV_pythia8/Run3Summer22MiniAODv4-130X_mcRun3_2022_realistic_v5-v2/MINIAODSIM, state: REPLICATING, grouping: ALL, rse_expression: T2_US_Caltech|T2_RU_JINR|T2_EE_Estonia|T2_IT_Rome|T2_BR_SPRACE|T2_ES_IFCA|T1_IT_CNAF_Disk|T2_US_Florida|T2_UK_London_IC|T2_US_MIT|T2_FR_GRIF_IRFU|T2_US_Vanderbilt|T2_US_Wisconsin|T2_US_Nebraska|T1_RU_JINR_Disk|T2_BE_UCL|T2_IT_Pisa|T2_BR_UERJ|T2_FR_GRIF_LLR|T2_US_Purdue|T2_PL_Swierk|T2_CH_CSCS|T2_UK_SGrid_Bristol|T2_US_UCSD|T2_ES_CIEMAT|T2_BE_IIHE|T2_CH_CERN|T1_DE_KIT_Disk|T1_US_FNAL_Disk

As stated above, this workflow did arrive in Global WorkQueue with data partially available on Disk.

The new WMCore tag with changes from #11810 is <IP_ADDRESS>, and it is deployed on testbed.


chore(deps): update terraform terraform-ibm-modules/base-ocp-vpc/ibm to v3.21.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/base-ocp-vpc/ibm (source)
module
minor
3.20.2 -> 3.21.0

Release Notes

terraform-ibm-modules/terraform-ibm-base-ocp-vpc (terraform-ibm-modules/base-ocp-vpc/ibm)
v3.21.0
Compare Source
Features

Add support for OpenShift v4.15 (#423) (9b2250a)

v3.20.3
Compare Source
Bug Fixes

update description for ingress_hostname input variable (#419) (ac6c77a)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.4 :tada:
The release is available on:

GitHub release
v1.4.4

Your semantic-release bot :package::rocket:


ingham.csv

All addresses here are in Naperville, IL; but it is filed under us/mi/ingham

Thanks a ton for bringing this to our attention! @justinelliotmeyers do you mind taking a look?

Will review 1st thing in the morning!

Part 1:
Ingham County, MI - I emailed<EMAIL_ADDRESS>http://ingham-equalization.rsgis.msu.edu/Viewer
WMS:
http://<IP_ADDRESS>/mapserver?SERVICE=WMS&VERSION=1.1.1&REQUEST=GetMap&FORMAT=image%2Fpng&TRANSPARENT=true&LAYERS=parcels%2Cdimensions&MAP=C%3A%2FMapServer%2Fapps%2Fingham%2Fparcel_data_layers_2019.map&EPSG=4326&cross-origin=anonymous&SRS=EPSG%3A3857&STYLES=&WIDTH=1201&HEIGHT=628&BBOX=-9517480.139900437%2C5175398.311132714%2C-9150276.656018449%2C5367408.126185076

I suppose you can just file it under 'IL' instead. The addresses seem correct otherwise:
LON,LAT,NUMBER,STREET,UNIT,CITY,DISTRICT,REGION,POSTCODE,ID,HASH
-88.1184657,41.8024864,4S631,Naperville Rd,,Unincorporated Area,,,,SID-1,9aed439cc87fa43b
-88.1194811,41.8030196,1804,N Naper Blvd,,Naperville,,,,SID-2,f354edba0b7f3c9b
eg: https://geocoder.ca/41.8030196,-88.1194811

@eruci https://github.com/openaddresses/openaddresses/issues/1985 will realign the proper source. I need to research if we have current data in Illinois for the county/ city. Otherwise, let me know your thoughts. Thanks!!

This is honestly a goofy issue! Source: https://data.openaddresses.io/runs/818432/output.txt
Pulls from http://hdgis.ingham.org/arcgis/rest/services/GeneralPurpose/MapServer/2 > http://hdgis.ingham.org/ichd/map.aspx
But data is actually for Naperville. Which splits DuPage and Will County.
This current broken resource has 49,672points.
The current https://data.openaddresses.io/runs/818370/output.txt has 52,102
I think we just fix this and remove the current source. See https://github.com/openaddresses/openaddresses/issues/1985
Does this work @eruci and @ingalls ?

This is honestly a goofy issue! Source: https://data.openaddresses.io/runs/818432/output.txt
Pulls from http://hdgis.ingham.org/arcgis/rest/services/GeneralPurpose/MapServer/2 > http://hdgis.ingham.org/ichd/map.aspx
But data is actually for Naperville. Which splits DuPage and Will County.
This current broken resource has 49,672points.
The current actual Naperville data here https://data.openaddresses.io/runs/818370/output.txt has 52,102
I think we just fix this and remove the current source. See #1985
Does this work @eruci and @ingalls ?

Sounds Good!


Added dynamic classes to previous and next controls

When a previous or next control takes no action (for example, the previous control at the beginning of a non-infinite carousel or the next control at the end of a non-infinite and non-rewinding carousel), a class of 'disabled' is added to it.
Also added minor style updates for next and previous controls for their disabled and hovered states.

@kaylabranch thanks for contributing, I adjusted the commit message and merged your PR after testing. cheers!

@meandmax Wonderful! I appreciate you taking a look & merging it in!


new heron ui doesn't have filter on environment

Previously the heron ui page has a filter on topology environment which allows user to look only production/development topology.
The new heron ui page looks like the following, the filter on environment is missing. This could be a bug in the UI code

probably related https://github.com/twitter/heron/commit/1ff359b12bef4fa581cc64e0deb676ec54aa819a#diff-ae50e69b7e07fc33c6bb1ccfddc1c3f9

@nlu90 this is removed by @cckellogg a year ago: https://github.com/twitter/heron/commit/a412e4b81e51a0868a05d85da91ff4c048f20edf#diff-e49e2896d307ce58674cd955979d8912L303
Removing this from 0.14.7.

@cckellogg can you look into this? It is actually quite useful.


doc: add Upgrading Instruction for v1.6 to v1.7

What type of PR is this?
/kind documentation
What this PR does / why we need it:
doc: add Upgrading Instruction for v1.6 to v1.7
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

succeed: quick click


js link issue

the src, ./js/item-descri,js is not working somehow

in the ebay-popular-up-to-date branch
at the file https://github.com/Team-Lorem-Ipsum/PCBee/blob/ebay-popular-up-to-date/client/item-description.html

fixed


Show error text when a device name choice is invalid

@keybase/react-hackers
The error message I used ("Your device name must have 3-64 characters and not end with punctuation.") is not precise, since there are some punctuation characters that can't be used at all, but the actual rules seem too complex to try to explain in a sentence.

Thanks both, made these changes.


Go to definition not working

What Versions are you running?
OS Version: Ubuntu 17.10
VSCode Version: Version: 1.25.1 Commit: 1dfc5e557209371715f655691b1235b6b26a06be
Puppet Extension Version: v1.11.0
Puppet Agent Version: 5.5.3
PDK Version (if applicable): 1.6.0
What You Are Seeing?
I want to use the "Go to Definition" or "Peek Definition" Feature.
When I try to go to a definition of a module it says: "No definition found for 'module'"
What is Expected?
I expect it to open the module.
How Did You Get This To Happen? (Steps to Reproduce)
Open a .pp file inside your repo. Click an include statement and press F12 (or your binding for "Go to Definition".
Output Log
DEBUG: 2018-07-26T15:01:31.078Z Found a valid Puppet installation at /opt/puppetlabs/puppet
DEBUG: 2018-07-26T15:01:31.078Z Configuring commands
DEBUG: 2018-07-26T15:01:31.079Z [createLanguageServerProcess] Language server found at: /home/sbuesing/.vscode/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/puppet-languageserver
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable RUBY_DIR=/opt/puppetlabs/lib/ruby
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable PATH=/opt/puppetlabs/puppet/bin:/opt/puppetlabs/facter/bin:/opt/puppetlabs/bin:/opt/puppetlabs/lib/ruby/bin:/opt/puppetlabs/sys/tools/bin:/usr/local/go/bin:/home/sbuesing/gopkgs/bin:/home/sbuesing/bin:/home/sbuesing/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/puppetlabs/bin
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable RUBYLIB=/opt/puppetlabs/puppet/lib:/opt/puppetlabs/facter/lib:
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable RUBYOPT=rubygems
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable SSL_CERT_FILE=/opt/puppetlabs/puppet/ssl/cert.pem
DEBUG: 2018-07-26T15:01:31.080Z [getRubyExecFromPuppetAgent] Using environment variable SSL_CERT_DIR=/opt/puppetlabs/puppet/ssl/certs
DEBUG: 2018-07-26T15:01:31.080Z [createLanguageServerProcess] STDIO Server process starting
DEBUG: 2018-07-26T15:01:31.080Z [startLanguageServerProcess] Starting the language server with ruby /home/sbuesing/.vscode/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/puppet-languageserver --stdio --timeout=10 --local-workspace=/home/sbuesing/git/department/puppet-control --enable-file-cache
DEBUG: 2018-07-26T15:01:31.086Z [startLanguageServerProcess] Language server PID:24429
DEBUG: 2018-07-26T15:01:31.086Z LanguageServer Process Started: 24429
DEBUG: 2018-07-26T15:01:31.087Z Starting STDIO client:
DEBUG: 2018-07-26T15:01:31.087Z Configuring language server options
DEBUG: 2018-07-26T15:01:31.087Z Starting language server client (stdio)
DEBUG: 2018-07-26T15:01:31.087Z Configuring language server client options
DEBUG: 2018-07-26T15:01:31.092Z [Puppet Lang Server Client] stdio connected
DEBUG: 2018-07-26T15:01:31.092Z Congratulations, your extension "vscode-puppet" is now active!
DEBUG: 2018-07-26T15:01:31.284Z pdk shell started, pid: 24441
DEBUG: 2018-07-26T15:01:31.818Z Language server client started, setting puppet version

Can you clarify what resource you're trying to find the definition of? It seems from the context like you are right clicking on the word module in your manifest?
If I right-click on file in the example below I can peek or go to the definition:
file {'/home/someone/file':
  ensure => present,
}

I believe peek/go-to only works for specific resources, not overall modules. Does the example here work for you or is the functionality entirely broken on your end?

@michaeltlombardi : The functionality is completely broken. I cant peek or go to definition for standard puppet-resources, as you described, either.
So clicking on file "peek definition" gives the same message as stated above.

I am having the same issue, can't go to definition of any resources at all.

@jpogran Yes this is still an issue on 0.12.

@wiccan2 I apologize, I got confused when replying. Do you have the same platform and versions as the original reporter?
@svenbs Apologies for the confusion, is this still and issue for you? We've recently finished the 0.13 release and I'm adding this to the pile to be investigated now.

So, I spun up an ubuntu 18.04, vscode 1.28, and pdk 1.7.1 and reproduced the issue. @glennsarti I think we have a problem with the file uri being sent, it seems to have one too many slashes after file: I typed a simple file declaration and watched the log and I see the following:
D, [2018-10-24T16:11:25.404160 #34999] DEBUG -- : --- INBOUND
{"jsonrpc":"2.0","id":9,"method":"textDocument/definition","params":{"textDocument":{"uri":"file:///home/james/Documents/foo.pp"},"position":{"line":0,"character":2}}}
---
D, [2018-10-24T16:11:25.418013 #34999] DEBUG -- : --- OUTBOUND
{"jsonrpc":"2.0","id":9,"result":[{"uri":"file:////opt/puppetlabs/pdk/share/cache/ruby/2.4.0/gems/puppet-6.0.2/lib/puppet/type/file.rb","range":{"start":{"line":14,"character":0},"end":{"line":14,"character":1024}}}]}
---
D, [2018-10-24T16:11:25.554092 #34999] DEBUG -- : --- INBOUND
{"jsonrpc":"2.0","id":10,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///home/james/Documents/foo.pp"},"position":{"line":0,"character":5}}}
---

Note the file uri differences between the definition request and the hover request.
I checked the path, and the file is present at that location, so it's not a pathing issue in detecting pdk folders.
I see on line https://github.com/lingua-pupuli/puppet-editor-services/blob/master/lib/puppet-languageserver/manifest/definition_provider.rb#L73 and line https://github.com/lingua-pupuli/puppet-editor-services/blob/master/lib/puppet-languageserver/manifest/definition_provider.rb#L88 we use file:/// there. I think we may need to use a uri builder instead of making our own.

@svenbs you are correct. :)
@wiccan2 @svenbs the fix is merged into master, it will be part of the (0.13.1](https://github.com/lingua-pupuli/puppet-vscode/milestone/17) release, which we should have out next week


readme: fix syntax error in example

grab.Response.Size is a int64 value and not a function
I noticed this problem when testing the example in the readme.
Hopefully this could help others...

Experienced same issue

Could @cavaliercoder update on this??? It has been over two months...

Should be merged.

I know... SMH

Wow!

@Nathan13888 you finally got it merged haahah

Anyone keen to co-own this? I don't get a lot of time for open source anymore.

@cavaliercoder you can always open new organisation and transfer your repo to it. @Nathan13888 and others can be maintainers and you can still have nice oversight (just a suggestion)

This is a good idea. Will take a look on the weekend.


Include text in navigation bar links

Make page links friendlier for screen readers and search engines.
REDMINE-16513

Coverage remained the same at 99.295% when pulling 3025dd20be0352ac32c404fb67ac2c092f490b09 on tf:link-texts into 65c8c47e722013eb656baaafa74bd926473ae259 on codevise:master.


create rib component

This PR contains a new RIB component.
The main goal is making accessible for backend team a component they can render to PDF thanks to playwright.
This file is in RIB folder and named RIBv1 because our backend team needs a versioning of different RIB version for the future.
There is a version prop because our backend team needs a versioning of different RIB version for the future. So if we create a new version, we should add a new type with a different version and we handle it in a different component thanks to ts-pattern
Maybe they could have different versions by installing several version of lake but I'm not sure this is possible.
And it stays easier to just import several files instead of installing several time the same package with different version number.
Also this component doesn't use LakeText neither LakeLabel component because this design define text with a smaller size.

just added Swan logo if partner doesn't set a partner logo in 13bbd630921f752d39144f5dfc624605aea1a201


how to get the network data

Hello ,i have the question about the network data.
In define.h

You define "#define TCP_ORCA_INFO 46 ",
I check the socket.h,46 means SO_BUSY_POLL
"#define SO_BUSY_POLL		46"
I can not understand how use "getsockopt( sk, SOL_TCP, TCP_ORCA_INFO, (void *)info, (socklen_t *)&tcp_info_length );"
get the data of info.
Maybe the question is very silly , i am sorry for that:)

Hey @jialianchen
You are looking at a wrong file for the definition of the TCP Socket Options! You can find the existing definitions for Kernel 4.13.1 here {lines 90-121}: https://elixir.bootlin.com/linux/v4.13.1/source/include/uapi/linux/tcp.h
As you will see, 46 is not reserved!
For more details, you can check out our provided kernel patch file: Orca/linux/linux-4-13-1-orca-0521+c2tcp.patch
You will find out that we patch the file "include/uapi/linux/tcp.h" starting at line 210 and add new TCP_DEEPCC_INFO socket option at line 233.
BTW, be sure that there is nothing called a silly question out there! Questions are either 1) answered ones or 2) unanswered ones!  & your question is now an answered one :-)


scanner: refactor RevListsShas into type

This pull-request refactors the original implementation of the RevListShas method into a type that retains the same behavior.
This is done such that we can easily manipulate a channel of revs coming out of this function. That is not made use of (yet), but will become the case in a subsequent PR.
--
/cc @technoweenie @rubyist @sinbad @sschuberth @larsxschneider

@sinbad thanks for the review! I pushed some more changes out to address your comments 👍

Moving things to a new package gives us another opportunity to examine the interface. The lfs package has a ton of things exported that probably don't need to be. The scanner package's main task is to stream LFS pointers given a range of git commits. With that in mind, do scanner. NameCache, scanner.RevListScanner or even scanner.RevListShas() need to be exported? These seem like implementation details for an LFS object scanner.
Also, I don't think a scanner.RevListScanner needs to take a scanner.ScanRefsOptions in its constructor. What about something like this?
revlistScanner := newRevListScanner("origin", ScanRefsMode)
revlistScanner.SkipDeletedBlobs = true
revlistScanner.Scan(left, right)

If scanner.ScanRefsOptions is going to get removed in a future PR, that's totally cool :+1:

Actually, ignore the last part. I think we still need ScanRefsOptions so callers outside the scanner pkg can set this info. Then let each inner type like a revListScanner use that.

With that in mind, do scanner. NameCache, scanner.RevListScanner or even scanner.RevListShas() need to be exported?

I don't think that these types need to be exported. To keep these PRs small, I think it makes sense to export the same functions that exist in lfs/scanner.go until we've moved all of the code over. Once that's done, I figure we can reduce this package down to a single public function, and leave all of the implementation private.
I did, however, make the nameCache type private in https://github.com/github/git-lfs/pull/1595/commits/d900abdda13933434b4b3a2387cb8abe65f7d3d4, since that doesn't need to be exported today.

This is done such that we can easily manipulate a channel of revs coming out of this function.

Can you provide some example of how this will work, and why a type is needed? The type shares all of the same properties of ScanRefsOptions. It looks like all that was changed is RevListShas() calls (*RevListScanner) Scan(), which is broken up to a few smaller funcs like refArgs() and scanAndReport(). Seems like RevListScanner is unnecessary, and definitely does not need to be exported.

Can you provide some example of how this will work, and why a type is needed?

Sure. When I started this refactor, the presence of the ScanRefOptions argument to the function was a smell that indicated there might be a type to extract that would be more appropriate than a large function.
My first inclination was to extract a 2-3 smaller, static functions, and call those, but I hit another smell of passing that ScanRefOptions argument all the way down. I then extracted a type that has the same fields as ScanRefOptions. This is still a smell, but temporary one.
Since there is code from the lfs package that uses the ScanRefOptions type, and I wanted to keep this change isolated, I decided to de-structure the data on that type into fields when we construct the RevListScanner type. Eventually, when all of the stuff that was in lfs/scanner.go is in the scanner package, then I'll remove the type, and each of the three types that I'm proposing will only have the information they need.
I think having three types (one that scans refs, one that does the batch check, and one that converts blobs into LFS pointers) is a good idea in that each is isolated in their concern, and doesn't have access to data that they don't need. This makes the types easily testable, and compose-able, which I think is a solid step forwrad.

I see ScanRefOptions as something similar to http.Request (with worse type names). If a caller wants to scan for lfs objects, it creates a new ScanRefOptions, calls Scan(), and gets back a result. It only has 3 immutable properties (I'm purposely ignoring nameCache, which I think we both dislike). Destructuring it just feels overkill to me.

The three classes are private, and closely related right now.
There are three because Git doesn't give us a better way to scan a repo. What if they did, an we could drop it to 1 command? Definitely isn't changing any time soon though.
Adding a property to ScanRefOptions would require also adding it to the 3 commands that need it. Also unlikely.

One upside, is if the three types end up with similar method names, they won't need prefixes to keep them apart:
revListScannerScan()
catFileBatchScan()

(*revListScanner) Scan()
(*catFileBatch) Scan()

If you really want to add the types, go for it. I was just asking a question. Some times I wish I would've gotten more questions about types I've written. If you do keep this, I still think RevListScanner should be private. I don't think anything uses it outside of the scanner package.

Eventually, when all of the stuff that was in lfs/scanner.go is in the scanner package, then I'll remove the type (ScanRefOptions), and each of the three types that I'm proposing will only have the information they need.

If you do that, then you'll need a public Scan function with 3 positional args:
scanner.Scan(scanner.ScanAllMode, "origin", false)

Positional args, especially for optional ones like SkipDeletedBlobs, are not my favorite. So I think it'd make more sense to just rename lfs.ScanRefOptions to something like scanner.Options, instead of removing it in one PR, and bringing it back in another.

Thanks again for this feedback 👍 . I didn't do a great job of articulating what I'm going for in this series of PRs, which I think can make it difficult to look at each by itself. I did my best at responding to some of your questions below.
My inclination is to merge this PR and introduce the type after changing the name of ScanRefOptions to scanner.Options, and making the RevListScanner a private member of the package. I think this is a good idea, but if this does become overkill after all of the PRs in this series have been merged, then I definitely agree that we can change it fairly easily.

If a caller wants to scan for lfs objects, it creates a new ScanRefOptions, calls Scan(), and gets back a result.

I may be misunderstanding you, but my thinking is that the type could be made private so the entrypoint to this API is simple. More importantly, the caller doesn't have to concern him or herself with the implementation, or existence, of the *RevListScanner. I started working towards that here, but still need to make the type private to finish it off.

There are three because Git doesn't give us a better way to scan a repo. What if they did, an we could drop it to 1 command?

I think in either case we'd have to change a lot of the internals of the code, but I agree that this isn't a likely thing to happen in the near future.

Positional args, especially for optional ones like SkipDeletedBlobs, are not my favorite.

I definitely agree. In the final iteration of this series of PRs, I'm imagining that something like ScanRefOptions (maybe called *scanner.Options) will still exist, but we'd de-structure the fields on that struct into the fields that each component needs, that way they only have access to what they need to do their jobs.

If a caller wants to scan for lfs objects, it creates a new ScanRefOptions, calls Scan(), and gets back a result.

I may be misunderstanding you, but my thinking is that the type could be made private so the entrypoint to this API is simple. More importantly, the caller doesn't have to concern him or herself with the implementation, or existence, of the *RevListScanner

I'm referring to scanner.ScanRefs() (scanner.ScanTree(), scanner.ScanIndex(), scanner.ScanUnpushed(), etc,  are already simple). You're going to revert back to 2 positional and an optional arg? I'm not talking about RevListScanner, which has never been exported.

Hi, all. I wanted to post a quick update after I've given some thought to this PR over the weekend.
First of all, I'd like to thank @technoweenie and @sinbad for their feedback, and for asking hard questions.
My goal with this series of PRs was for them to be small, and easily digestible in pieces. I failed, however, to clearly articulate my vision and reasoning behind removing/adding some code in both the comments and PR description. I will try and further articulate my vision in the future.
For now, I am going to close this PR. My thinking here is that we have code in lfs/scanner.go that works, and is simple. Let's start by moving that code over to the scanner package, making it work in a parallel fashion (where there are no individual bottlenecks that can't be solved by increasing the parallelism), and then refactor later, if necessary.
I think this allows us to keep the simple code that we already have while making small, incremental changes moving us towards our goals. My new plan, going forward, is:

In three separate PRs, move over the code from lfs/scanner.go into package scanner, leaving the lfs/scanner.go code to delegate into the new package.
In the next PR, apply small, calculated refactorings as described above.
Transition all calling code to use the scanner package, instead of the lfs/scanner.go functions.
🎉

Once again, I really do appreciate the feedback, and can't wait to get cracking on the rest of the PRs in this series. 🤘


BitDefender Antivirus Free Edition blocking and deleting wsl-terminal 0.9.0 exe files

Hi,
I'm using BitDefender Antivirus Free Edition on a Windows 10 box, and it prevented to download the 7z archive for the wsl-terminal 0.9.0 release. I was able to download the zip file but then BitDefender blocked it saying vim.exe, run-wsl.file.exe, open-wsl.exe contains Trojan.GenericKD.33433992.
It's probably (I hope :) ) a false positive and will try to report to BitDefender

I've submited the zip to https://www.bitdefender.com/submit

that is rather odd. I have a paid subscriptionfor bit defender and I never had issues. On the other hand the version I use is build from the source and not the release. I will try that exact binary and report back :)

1584889113_1_01.txt
1584889145_1_01.txt
1584889253_1_01.txt
1584889261_1_01.txt
I have attached the logs of bit defender for all the binaries I downloaded from the download section:
https://github.com/mskyaxl/wsl-terminal/releases/download/v0.9.0/wsl-terminal-<IP_ADDRESS>z
https://github.com/mskyaxl/wsl-terminal/releases/download/v0.9.0/wsl-terminal-0.9.0.zip
https://github.com/mskyaxl/wsl-terminal/releases/download/v0.9.0/wsl-terminal-tabbed-<IP_ADDRESS>z
https://github.com/mskyaxl/wsl-terminal/releases/download/v0.9.0/wsl-terminal-tabbed-0.9.0.zip
And all of them are clean.
Are you sure everything is ok with your machine?

Further updates:
More over scanning all the links with virustotal.com shows once again that the source is clean:
https://www.virustotal.com/gui/url/9d80932b89ccccecdebee36d292babfbcf2ca39c277280bfe00e8132d7e403bc/detection
https://www.virustotal.com/gui/url/398b76c9bb66e26c9dcff215650eea861aec493aed3116dc060710aa2537b70f/detection
https://www.virustotal.com/gui/url/99571425321ddd7fb4e474b97b52b086ed4a2232907a9e307629f11eef03de9a/detection
https://www.virustotal.com/gui/url/5b041393fd5374f72dcdc3bbccf4437595dc1b506c81f566780b4cf8bf9c8916/detection

Are you sure everything is ok with your machine?

Sorry for the delay but yes my system is fine and as you can see on https://www.virustotal.com/gui/file/3f321c489edf42116484acd748c88aee0308c97ccfa4b988b7beda5c97316975/detection the sha256 of the file is the same as on https://github.com/mskyaxl/wsl-terminal/releases/tag/v0.9.0: 3f321c489edf42116484acd748c88aee0308c97ccfa4b988b7beda5c97316975 (it's even the identifier in the virustotal URL:
So let's assume it was a temporary (?) false positive


ViterbiDecoder pads  tag instead of  tag in end of sequence

In inference.py line 60, self.start_tag should be self.end_tag

yes, i agree with you.


Use of the double quote (") character

I am using Mail Merge to send out Usernames and Passwords created for a project.
If the password contains the " character, it throws a JSON token error.
Should I encapsulate the " character with double " ??
My workaround is to simply replace the " character with some other character, however this is very time consuming as it means that I have to manually go back to the accounts that Google created automatically and change the passwords before sending out.
Your guidance will be appreciated.

@Robin1824 thanks for flagging this. I've added some code to this solution to escape cell data to make JSON safe. I've opened a pull request https://github.com/gsuitedevs/solutions/pull/130


Missing HTML Component Composition

Currently .html files for components embedded within others aren't carried alongside their respective .go portions; those struct fields are the only ones that carry over.

Added template embedding: https://github.com/mrmiguu/coco/commit/9a415ce2a938ae94c4c6a89bc2dbd9ef0db776f7.


Ability to sub in Botania prismarine blocks for temple generation

I would like the temples, but not two types of prismarine.

They are ore dictionary compatible. You can use them in the same recipes and should even be able to store them in the same barrels

Nevermind then. I just thought it would be a bit weird having blocks that look the same together in a world.


Provide an async ParquetWriter for arrow

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As it is nice to be able to read parquet files using rust async IO https://github.com/apache/arrow-rs/issues/111, it would be nice to write them as well
Describe the solution you'd like
A async writer similar in spirit to the reader created in https://github.com/apache/arrow-rs/issues/111

Thanks @xudong963  - I personally suggest starting with the API design. As in write an example program showing how you would use the feature. Something like the following (sorting out what types to use for streams, etc):
async fn main() {
  // get output stream
  let writer = AsyncParquet::new(...);
  // write batches to the writer somehow (not sure how??)
  for batch in batches {
    ....
  }
}

Thanks for your nice suggestion! @alamb, I'll start the task tomorrow.

I felt the need to provide these new APIs and structs.
pub struct AsyncArrowWriter<W: W: AsyncWrite + Unpin + Send> {
    writer: FileStream<W>,
    ...
}

pub struct FileStream<W: AsyncWriter + Send + Unpined> {
    writer: W
}

impl <...> FileStream {
    pub async fn write(&mut self, ...) -> Result<> {
        // 1. firstly, write header
        write_header().await?;
        // 2. secondly, write rowgroups
        write_row_groups().await?;
        // 3. thirdly, write metadata
        write_metadata().await?;
    }
}

I noticed that we have a buffer optimization in the sync write part. I'm not sure if we need to keep the buffer in the async write part.

I noticed that we have a buffer optimization in the sync write part. I'm not sure if we need to keep the buffer in the async write part.

Are you referring to the buffer added in #1214 as it would be really cool to keep that if possible? RecordBatch are likely significantly smaller than the ideal size for a row group

@tustvold Yep, thanks! I'll take a look at #1214 and reorganize my thoughts.

@tustvold Hi, this feature will help us a lot if it is implemented. Is there anyone working on this issue? I'm glad to try it if not.

@ShiKaiWi Thanks!  Feel free to try it. I'm busy with other things.

@tustvold Thanks for your quick response. Here are my some thoughts about your proposal:

This would then allow providing a Vec as the writer, and then periodically gaining access to it and flushing its contents asynchronously. We could provide an AsyncWriter that encapsulates this logic, but we could also just provide a code example in a doc comment.

I guess the periodically gaining access is not an elegant way (but it indeed can solve the problem we encounter), because the polling frequency can't be determined easily, that is to say, polling with high frequency may introduce overhead and with slow frequency may lead to high memory usage by the inner writer Vec<u8>.

The nature of parquet is that an entire row group is buffered up and written in one shot, as data for different columns cannot be interleaved, so I'm not sure it is possible to do better than this

For now, I doesn't know the details of the writer very well, but I guess the buffer logic can still be kept in the async writer.

because the polling frequency can't be determined easily

Checking after each call to write should be fine. A more sophisticated writer could track the number of written rows and only check once they exceed the max row group size, in practice this is highly unlikely to be make a tangible performance difference

may lead to high memory usage by the inner writer Vec

Assuming a single RecordBatch does not exceed the maximum size of a row group, the above approach should be optimal in this respect.

guess the buffer logic can still be kept in the async writer

If we can share as much between the sync and async implementations as possible, that would be beneficial. The separate async read path, whilst a necessary evil, is a non-trivial maintenance burden

Checking after each call to write should be fine. A more sophisticated writer could track the number of written rows and only check once they exceed the max row group size, in practice this is highly unlikely to be make a tangible performance difference

👍. This way is good enough to solve the problem we encounter.

share as much between the sync and async implementations as possible
After digging into the code, I find this is the hardest part to implement async writer.

I guess your suggested way is the best workaround before the most codes of the sync and async implementation can be shared.

@tustvold Maybe I can solve this issue by implementing your proposal:

We could provide an AsyncWriter that encapsulates this logic, but we could also just provide a code example in a doc comment.

Please let me know when you make the decision.

Please let me know when you make the decision.

How about we implement an AsyncWriter and see what it looks like, using the buffering approach, and see what it looks like

Please let me know when you make the decision.

How about we implement an AsyncWriter and see what it looks like, using the buffering approach, and see what it looks like

Ok. I'll give it a try.

Please let me know when you make the decision.

How about we implement an AsyncWriter and see what it looks like, using the buffering approach, and see what it looks like

@tustvold I find it is hard for me to implement the AsyncWriter by sharing the codes with current sync writer. And I try the initial proposal by you, which looks simple and pretty: https://github.com/ShiKaiWi/arrow-rs/commit/40f9d5a7e2fb7818decb0dffa00dff2b39be7eb1
What do you think about the demo?


filePath must lead to a file error on existing file

I am getting this error message on a file that exist in the given path (report_container_metrics_cAdvisor.sl), when I rename the file to hello_word it works fine.
https://github.com/openscore/slang-content/pull/26

did you try to run it with the backslash reverse ?
like this :
C:/dev/sources/seffy-branch/org/openscore/slang/docker/maintenance/report_container_metrics_cAdvisor.sl
It seems to work.. the other way around () seems to be the issue..

so the issue is with the "\r" chars of the flow path , which makes spring-shell to parse it the wrong way.
For a quick soultion you can use "/r" instead, and it will solve this..
we need to think on a better soultion for this (it does not seem to be solved easily, since it is a JLine issue according to @avimora ),
or at least document this... @avimora @meshipeer @orius123 WDYT ?

Documenting doesn't sound like an acceptable solution in my POV. Either we fix it or we fix it..

ok, it works thanks,
I suggest at least to change the error message...

I think that if we will verify that slashes / works in path for both windows and *nix, we should document to use it.

*nix slashes always work, and this is the recommended way...

Added to the docs in openscore.github.io/3d86558a78903ca4816da7a0dfe545df54dbd6bc.

pending #120 -replacing CLI FW


Add tree to a commit object

Hey man, love this project!
I added a couple of things to the Github schema.

tree linked to a Commit object
last_commit in the TreeEntry object
limit as an argument of commits

Let me know if it looks good :)

This is great, the tree view is super helpful - left some comments, but very awesome!

Both your comments are right on, I'll fix those issues shortly! ;)

There you go man, I also added repo.owner while I was there.

:ship: should be live in a few minutes, thanks again!

Great, thanks! :)


Remove deprecations in sequence

This removes/cleans up deprecations introduced in #9967 and #10239.

@Abe27342 @anthony-murphy Are there plans to remove the SparseMatrix, which I think is also deprecated?

@Abe27342 @anthony-murphy Are there plans to remove the SparseMatrix, which I think is also deprecated?

@alex-pardes is working on moving all of the random extra cruft in sequence to its own package (potentially in experimental folder, since we don't really want to maintain AFAIK). I wasn't planning on deleting it or personally, but I don't have much of the context on how likely that is to trouble people that might still want to use it for whatever reason.


Exam Programming Exercise Participation: Number of reported building/failing submissions always 0, and can't restart failed builds.

Describe the bug
On the participation overview for a programming exercise in an exam (i.e. exams/XXX/exercise-groups/XXXX/programming-exercises/XXXXX/participations), "Building submissions" and "Failing submissions" are always 0, even if some submissions are building or failing, respectively. It is also impossible to use "Trigger failed".
This problem does not occur on regular exercises within a course.
To Reproduce
Create an exam with a programming exercise and a submission, let the submission build. Check the participation page and see that 0 submissions are building.
Let the submission fail. Check and see that the number of failing submissions is 0. Try to restart failing submissions.
Expected behavior
Building and failing submission counts should be displayed, and failing submissions should be restartable.
Screenshots

A number of submissions should be failing here
Which version of Artemis are you seeing the problem on?
7.6.0
What browsers are you seeing the problem on?
Chrome, Firefox
Additional context
It appears as though the "Trigger failed" button collects failed builds client side, which is anyway not great if something changes on the server in the meantime, and should perhaps be done server-side.
Relevant log output
No response

Additional context: This is a blocker for us for releasing the FPV exam grades of the retake.

We have now taken other measure to resolve this for FPV.


After upgrade the table views have changed (for worse)

Bug report
What I did
Upgraded to 5.0 from 4.1
What I expected to happen
Table views to basically remain the same
What happened
Table views have changed: the search box moved, details buttons appeared in place of the "three dots" and spacing in the page size selector has disappeared:

What I've already tried to fix it
Try to find an explanation in the docs, not found.
Is it a bug in the latest version of Backpack?
Yes
Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
PHP VERSION:
PHP 7.4.9 (cli) (built: Jul  5 2021 13:33:00) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Zend OPcache v7.4.9, Copyright (c), by Zend Technologies
LARAVEL VERSION:
v8.82.0@411d5243c58cbf12b0fc89cab1ceb50088968c27
BACKPACK VERSION:
5.0.0@c4eb4aeb55dfaf29ecd3f5e0e35ba4321d9c004a

The CSS for the "new" details button appears to be coming from this file:
packages/datatables.net-responsive-bs4/css/responsive.bootstrap4.min.css

Fixed it for me!, Thanks!

Thanks @pxpm , I will try that first thing tomorrow. I did indeed publish the assets when troubleshooting some CSS earlier on.

@pxpm fixed it for me as well. Thanks!


Add action to ODocument main widget to change its type

Not possible due to: https://github.com/orientechnologies/orientdb/issues/4848


[Y] Is the commits history nice and clean?

@AbdulAlmaz1488 Khabib dagestan goat


Provide a template format when GB doesn't contain any items

Please merge #3107 before this one as this is branched from that one
If there are no assignments to export, provide some examples
Remove Student ID and Student Name from translations as these are magical
Updated javadoc as these methods return an empty list, not null.
This is part of #1396

Boo conflicts after 3107 was merged 🚒

Oh 💩😷. Fixed 👍 .

Hey @steveswinsburg, now I'm all paranoid about Travis. It's failing but seems to be unrelated? Permission to ignore Travis? 🎱

Kicked it off again, see what happens :)

I re-ran this yesterday and it passed. It's failing again on unrelated problems so I say merge 🎉 🏁


Added FRITZ!Box and ChatGPT logo

added two new logos

These icons are added in the #353 PR, and will be merged soon.


Can't log in after adding authorization code until AuthorizeRouteView is added

In chapter 6, the instructions talk you through adding the authorization code. It then says that you should run the program, register, and login. But after logging in, an exception occurs (p.printErr | @ | blazor.webassembly.js:1)
To fix this, simply follow the rest of the instructions. When it gets to the point where you add an AuthorizeRouteView, the program starts working again.
I don't understand why it requires a AuthorizeRouteView, since it's not trying to display a route that requires authorization. Perhaps someone could explain why this is happening? But regardless of the reason, I'd suggest that the instructions need to be changed to use the AuthorizeRouteView much earlier on, before attempting to register a user and login. Unless I've done something wrong, of course.

The console error is: Unhandled exception rendering component: Cannot read property 'completeSignIn' of undefined

The error in the console is: Unhandled exception rendering component: Cannot read property 'completeSignIn' of undefined

You are quite right. I’ve edited my comment to include the correct error message. Thanks


subscription not working

flutter version: 1.5.9-pre.223
graphql_flutter version: 1.0.1-beta7
flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.5.9-pre.223, on Mac OS X 10.14.4 18E226, locale en-KH)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[!] Android Studio (version 3.2)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] VS Code (version 1.33.1)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

The init code
// inside lib/app.dart
...

  @override
  void initState() {
    super.initState();

    this._inMemoryCache = graphql_flutter.NormalizedInMemoryCache(
      dataIdFromObject: _typenameDataIdFromObject,
    );

    this._graphQLClient = ValueNotifier(
      graphql_flutter.GraphQLClient(
        cache: this._inMemoryCache,
        link:
          graphql_flutter.WebSocketLink(url: subscriptionEndpoint)
            .concat(AuthLink(openIdToken: this.widget.idToken)
            AuthLink(openIdToken: this.widget.idToken)
              .concat(graphql_flutter.HttpLink(uri: apiEndpoint) as graphql_flutter.Link)),
      ),
    );

    graphql_flutter.SocketClient(subscriptionEndpoint);
  }

subscription query
const String echoListenSub =
   '''
   subscription EchoListenSub {
     echoListen
   }
   ''';

The subscription just basic "hello world" stuff and absinthe as elixir graphql server. The subscription works when testing it on graphiql, below are the schema of the subscription on the server.
// inside lib/app_server_web/typedefs/hello.ex
...
  object :hello_mutations do
    field :echo_message, :string, complexity: 20 do
      arg :message, :string

      resolve &Resolvers.Hello.echo_message/3
    end
  end

  object :hello_subscriptions do
    field :echo_listen, :string, complexity: 20 do
      config fn _args, _info ->
        {:ok, topic: "*"}
      end

      trigger :echo_message, topic: fn message ->
        message
      end

      resolve &Resolvers.Hello.echo/3
    end
  end
...

// inside lib/app_server_web/resolvers/hello.ex
...
  def echo(message, _, _) do
    {:ok, message}
  end

  def echo_message(_, %{message: message}, _) do
    Absinthe.Subscription.publish(AppServerWeb.Endpoint, message, echo_listen: "*")

    {:ok, message}
  end
...

I am doing a chat application, so how it works is I am using google_sign_in, after it is signed in, I init the graphql client, send google idToken to my server and return back access tokens, then it will go to main screen where I will be querying for list of friends and subscribe to it so that adding friend will response in realtime. Before going to subscribing to list of friend ids, I am testing with simple "hello-world" subscription, right now the sign in works, initially getting list of friend ids work, but not the subscription part.
Here is the output on the client console:
...
I/flutter ( 5693): Connected to websocket.
I/flutter ( 5693): done
I/flutter ( 5693): Disconnected from websocket.
I/flutter ( 5693): Scheduling to connect in 5 seconds...
I/flutter ( 5693): Connecting to websocket: ws://<IP_ADDRESS>:4000/sub/websocket...
I/flutter ( 5693): Connected to websocket.
I/flutter ( 5693): done
I/flutter ( 5693): Disconnected from websocket.
I/flutter ( 5693): Scheduling to connect in 5 seconds...
I/flutter ( 5693): Connecting to websocket: ws://<IP_ADDRESS>:4000/sub/websocket...
I/flutter ( 5693): Connected to websocket.
I/flutter ( 5693): done
I/flutter ( 5693): Disconnected from websocket.
I/flutter ( 5693): Scheduling to connect in 5 seconds...
I/flutter ( 5693): Connecting to websocket: ws://<IP_ADDRESS>:4000/sub/websocket...
I/flutter ( 5693): Connected to websocket.
I/flutter ( 5693): done
I/flutter ( 5693): Disconnected from websocket.
I/flutter ( 5693): Scheduling to connect in 5 seconds...

and output on the server console:
[info] Replied AppServerWeb.UserSocket :ok
[error] Ranch listener AppServerWeb.Endpoint.HTTP had connection process started with :cowboy_clear:start_link/4 at #PID<0.2014.0> exit with reason: {:function_clause,
[{Phoenix.Socket.Message, :from_map!, ["{\"type\":\"connection_init\"}"], [file: 'lib/phoenix/socket/message.ex', line: 24]}, {Phoenix.Socket, :__in__, 2, [file: 'lib/phoenix/socket.ex', line: 549]}, {Phoenix.Endpoint.Cowboy2Handler, :websocket_handle, 2,
[file: 'lib/phoenix/endpoint/cowboy2_handler.ex', line: 76]}, {:cowboy_websocket, :handler_call, 6, [file: '/Users/xxx/projects/chatapp-server/deps/cowboy/src/cowboy_websocket.erl', line: 471]},
 {:cowboy_http, :loop, 2, [file: '/Users/xxx/projects/chatapp-server/deps/cowboy/src/cowboy_http.erl', line: 233]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 249]}]}

[info] CONNECT AppServerWeb.UserSocket
  Transport: :websocket
  Connect Info: %{}
  Parameters: %{}
[info] Replied AppServerWeb.UserSocket :ok
[error] Ranch listener AppServerWeb.Endpoint.HTTP had connection process started with :cowboy_clear:start_link/4 at #PID<0.2014.0> exit with reason: {:function_clause,
[{Phoenix.Socket.Message, :from_map!, ["{\"type\":\"connection_init\"}"], [file: 'lib/phoenix/socket/message.ex', line: 24]}, {Phoenix.Socket, :__in__, 2, [file: 'lib/phoenix/socket.ex', line: 549]}, {Phoenix.Endpoint.Cowboy2Handler, :websocket_handle, 2,
[file: 'lib/phoenix/endpoint/cowboy2_handler.ex', line: 76]}, {:cowboy_websocket, :handler_call, 6, [file: '/Users/xxx/projects/chatapp-server/deps/cowboy/src/cowboy_websocket.erl', line: 471]},
 {:cowboy_http, :loop, 2, [file: '/Users/xxx/projects/chatapp-server/deps/cowboy/src/cowboy_http.erl', line: 233]}, {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 249]}]}

Please tell me how to debug this or any possible action to apply to this to find the solution.

I found out the problem is from the absinthe package, I tried using the same code on flutter but change the subscription endpoint to node apollo-server and it works as expected.

@xxhenglyxx did you find what was wrong with the absinthe package. I am having the same issue but I cannot switch my backend.

@xxhenglyxx , @vikram25897 any news since 2019 ? :)

@redDwarf03 new issue please!


Mapping to the KITTI raw dataset

Hi @hzxie
Thanks for the great work !!
Can you please share the mapping of your processed KITTI dataset to the KITTI RAW dataset.
Basically I want to know, which log/ city/ frame each object is coming from.
Thanks !!

Please refer to the answer in the PCN repo: https://github.com/wentaoyuan/pcn/issues/45

Hi @hzxie
Thanks a lot for the quick reply.
Your answer helped find the exact mapping here: https://github.com/wentaoyuan/pcn/tree/master/data


hardcode linear FC to 1.2 for biosets filtering

Fixes issue #204

Removed line 275 as discussed.
I will make a branch for putting the linear fold change thresholds (for significant DEGs and for biosets) soon, but this is a quick fix for now.


west: flash: sysbuild: Add single user commands per board and waiting for board reset

This takes just the single command per set of boards and single reset per set of board features for flash runners from https://github.com/zephyrproject-rtos/zephyr/pull/53443 without the board priority part.
Includes:
west: runners: Add single-use commands per board flash

This adds supports for flashing images with sysbuild where there
are multiple images per board to prevent using the same command per
image flash which might cause issues if they are not ran just once
per flash per unique board name. This can be enabled per-board by
creating a `flash_runner.yml` file in the board directory with a
list named `board_single_commands`, e.g. to prevent the --recover
command being used multiple times when flashing a board, the file
contents would be similar to:

board_single_commands:
  - --recover: [
    nrf9160dk_nrf9160,
    nrf9160dk_nrf9160_ns,
  ]

and
west: runners: Add option to allow/prevent board reset

This adds supports for specifying if boards should be reset or not
after an image has been flashed, this is most useful for sysbuild
where multiple images are flashed and having one boot before all
are flashed causes the debug interface to be disabled or faults,
preventing correct operation of the firmware. Existing reset
priority of runners that supported it has been maintained.

This can be enabled per-board by creating a `flash_runner.yml` file
in the board directory with a list named `board_delay_reset`, e.g.
to delay an nRF5340 board from resetting whilst network core images
are being flashed, or whilst application core images (secure and
non-secure combined) are being flashed, the file contents would be
similar to:

board_delay_reset:
  - [
    nrf5340dk_nrf5340_cpuapp,
    nrf5340dk_nrf5340_cpuapp_ns,
  ]
  - [
    nrf5340dk_nrf5340_cpunet,
  ]

Also fixes #53487 by using the correct argument for the
stm32cubeprogrammer tests of "--reset-mode" instead of "--reset".

and changes to nrf5340dk_nrf5340, thingy53_nrf5340 and nrf9160dk_nrf9160 boards. Includes command updates for west flash test scripts.

[X] Code updates
[X] Board updates
[ ] Documentation
[X] Release notes
[ ] Decide if the resetting once per board should be opt-out instead of opt-in
[ ] Update code to make reset once per board opt-out if needed
[ ] Update release notes as above

Fixes #50421

@nordicjm what's the best way to test this PR, both in terms of verifying what went wrong before, and that it's fixed afteR?

@mbolivar-nordic Sure, some steps for building, if you go to /samples/subsys/mgmt/mcumgr/smp_svr and build e.g.
mkdir build
cd build
cmake -GNinja -DBOARD=nrf52840dk_nrf52840 -DAPP_DIR=.. -DSB_CONFIG_BOOTLOADER_MCUBOOT=y -Dmcuboot_CONFIG_NRF_APPROTECT_LOCK=y -Dsmp_svr_CONFIG_NRF_APPROTECT_LOCK=y ../../../../../../share/sysbuild/
ninja

At this point, you can flash both images using west flash, but there seems to be an issue because readback should be active but for some reason is not, so the issue with the reset part cannot be demonstrated here (if it was working, doing a west flash without this patch would flash mcuboot and reboot, enabling readback protection, then the application would attempt to be flashed which would fail), but the other issue can - if you use west flash --recover then in the new system, the device will be recovered, mcuboot will be flashed then smp_svr, if you try that without this patch, the device will be recovered, mcuboot will be flashed, the device will be recovered and then smp_svr will be flashed - the device will not boot because the bootloader has been erased.

Added DNM while we are settling on the scope of this PR

@nordicjm you mentioned you wanted me to take another look at this. I am still waiting for:

the issue description we agreed you would write describing the scope of the problem and proposed overall solution
internal discussion on this and agreement about scope and solution

the issue description we agreed you would write describing the scope of the problem and proposed overall solution

This is described in the linked bug: https://github.com/zephyrproject-rtos/zephyr/issues/50421


[Flake] Bucket integration test fails with FAILED_PRECONDITION

This was on GCB (I do not think it is GCB specific):
https://pantheon.corp.google.com/cloud-build/builds/46079ece-a688-46c1-9d18-a66dced058ed;step=2?project=cloud-cpp-testing-resources
2021-04-15T01:09:39.879026049Z [INFO] <140206593213440> GetBucketMetadata() << GetBucketMetadataRequest={bucket_name=cloud-cpp-testing-bucket, ifMetagenerationMatch=4, projection=noAcl} (google/cloud/storage/internal/logging_client.cc:46)
2021-04-15T01:09:40.000934334Z [INFO] <140206593213440> GetBucketMetadata() >> status={"Precondition Failed (metageneration = 5 vs metageneration_match = 4)"
 [FAILED_PRECONDITION]} (google/cloud/storage/internal/logging_client.cc:51)
[  FAILED  ] BucketIntegrationTest.GetMetadataIfMetagenerationMatchSuccess (410 ms)

Note that the bucket is queried just before using the gcs::IfMetagenerationMatch() pre-condition, but the bucket is a shared resource, not unique to this test, so it can be changed externally!
We need to create a new buffer for this test.

btw, that GOOGLE_CLOUD_CPP_EXPERIMENTAL_LOG_CONFIG=lastN,100,WARNING that shows the extra logging data is really cool.

I could imagine these maybe happening more with all the GCB + Kokoro tests running at the same time.

Here is one on GCB: https://pantheon.corp.google.com/cloud-build/builds/424819a8-edd3-4b50-8669-c2b8c9f56f2c;step=2?project=cloud-cpp-testing-resources

https://pantheon.corp.google.com/cloud-build/builds;region=global/0754d0de-ea2e-4f03-81a8-64774fc1fc03;step=3?project=cloud-cpp-testing-resources


Promtail is currently hard-coded to amd64. Needs to support arm64 as well

See https://github.com/canonical/loki-k8s-operator/blob/cc073c4f9aeb79255b598e0230aa62a2384bcfab/lib/charms/loki_k8s/v0/loki_push_api.py#L454-L466

After discussion with @simskij an additional requirement is that the LogProxyConsumer should be able to detect if the Consumer charm is providing a Promtail resource and in this case the Promtail binary should not be downloaded from the release page. This allows for air gapped deployments.

@balbirthomas closed in #158 ?

Closing this since we have extensibility to add new architectures but are lacking binaries to do so. I created #163 to track upload of new binaries and update Loki library.


Add keybinding for adding a category

Figure out why global keybindings can't access local React hook state.

Why not add accesskey to the button?  Is there a reason why not to do it?
How about this in AppSideBar.tsx?
-<button className="add-category-button" onClick={newTempCategoryHandler}>
+<button className="add-category-button" onClick={newTempCategoryHandler} accessKey='c'>

Fixed in #21