How to update internal phone number value when using a textComponent

I want to use the various methods such as isValidNumber(), getNumberType(), getValue(), getISOCode()` etc.
When I use the textComponent prop to customise the UI, how do I pass the value from this custom TextInput into the PhoneInput's state to be used by those methods?
<PhoneInput
    allowZeroAfterCountryCode={false}
    initialCountry="gb"
    // onChangePhoneNumber={test => console.log(test)}
    onSelectCountry={() => this.setState({ countryCode: this.test.getCountryCode() }) }
    onSubmitEditing={() => console.log('111')}
    ref={ref => this.test = ref}
    textComponent={() => (
        <>
            <Text>Mobile number</Text>
            <View>
                <Text onPress={() => this.test.onPressFlag()}>+{this.state.countryCode}</Text>
                <TextInput
                    keyboardType="phone-pad"
                    onChangeText={text => this.test.setState({ inputValue: text })}
                    placeholder="7123456789"
                />
            </View>
        </>
    )}
/>

<PhoneInput
ref={ref => {
phoneno = ref;
}}
onChangePhoneNumber ={(num)=>{
setPhone(num)
}}
style={{marginLeft:"20%"}}
initialCountry = 'us'
textProps={{
placeholder:I18n.t('phone'),
returnKeyType: 'done',
keyboardType: 'phone-pad',
style:(styles.input)
}}
/>

That's because you are not using the textComponent prop.

Hey, based on this line , some probs such as the change listener are passed to the component, so instead of using your own onChangeText, you could try to pass the probs to the underlying element like:
textComponent={(**props**) => (
        <>
            <Text>Mobile number</Text>
            <View>
                <Text onPress={() => this.test.onPressFlag()}>+{this.state.countryCode}</Text>
                <TextInput
                    keyboardType="phone-pad"
                    // onChangeText={text => this.test.setState({ inputValue: text })}
                    placeholder="7123456789"
                    **{...props}**
                />
            </View>
        </>
    )}

same issue. any one find an answer?

Any updates on the issue? I even cannot get the value from the phone input using onChangePhoneNumber once I am using custom textComponent

I had the same issue but then I figured out that I was using textComponent like that:
textComponent={() => ( <MyInput /> )

while I actually had to pass props:
textComponent={(props) => ( <MyInput {...props} /> )

I had the same issue but then I figured out that I was using textComponent like that:
textComponent={() => ( <MyInput /> )

while I actually had to pass props:
textComponent={(props) => ( <MyInput {...props} /> )


prototype for ssh and virtualization detection

Hello,
#335 brought me on some ideas so I've written some custom functions.
You can find the code at the end. It would be nice if this would find a way into the next release :) I just wanted to type down a rapid prototype for it. Maybe I will implement it if I find some time.

Functions
zsh_detect_virtualization will detect the type of virtualization. In case of no virtualization nothing will displayed. It uses the systemd-detect-virt-feature. So it should work on most of the Linux distributions (Debian, Ubuntu, Arch Linux, CentOS, Fedora..).
zsh_detect_ssh will detect if the current session is in SSH. It just scans if SSH_TTY or SSH_CLIENT exist.
Known Problems

due to the reason we use systemd for the virtualization detection it will not work on systems without systemd. For example Devuan, Gentoo (if run with openRC), Voidlinux and many more. We could write a fallback function for it but i doubt that our fallback function would be such precisely as systemd-detect-virt. We would also need a fallback function for BSD or Mac OS X systems.
the ssh detection does only work with the first user in the ssh session. If you change the user inside of the ssh host you will lose it, because sshd exports SSH_TTY and SSH_CLIENT only for the first user. A workaround would be to set one of the environment variables manually... but this way somebody could also just tag ssh in the powerline manually...

TODO

include it in the project
Find some nice icons for it

zsh_detect_virtualization(){
    local virt=$(systemd-detect-virt)
    local color='%F{yellow}'
    if [[ "$virt" == "none" ]]; then
        if [[ "$(ls -di / | grep -o 2)" != "2" ]]; then
            virt="chroot"
            echo -n "%{$color%} $virt"
        else
            ;
        fi
    else
        echo -n "%{$color%} $virt"
    fi
}

zsh_detect_ssh(){
    local color='%F{yellow}'
    if [ -n "$SSH_CLIENT" ] || [ -n "$SSH_TTY" ]; then
        echo -n "%{$color%} ssh"
    fi
}

POWERLEVEL9K_CUSTOM_DETECT_VIRT="zsh_detect_virtualization"
POWERLEVEL9K_CUSTOM_DETECT_SSH="zsh_detect_ssh"
POWERLEVEL9K_CUSTOM_DETECT_VIRT_BACKGROUND="black"
POWERLEVEL9K_CUSTOM_DETECT_SSH_BACKGROUND="black"
POWERLEVEL9K_RIGHT_PROMPT_ELEMENTS=(status root_indicator background_jobs history time custom_detect_virt custom_detect_ssh)

Thanks so much for putting this together, @shibumi!
I like the idea of detecting virtualization a lot. The primary issue here is that we have a lot of OSX users, so we'll need something in there that works for them, as well.
SSH detection is currently built into the context segment (see here), but it probably makes sense to break it out into its own function.
You raise an interesting point about things not working if the $USER changes within the SSH session... it's interesting that there isn't some sort of environmental awareness of this carried forward. I wonder if there is and we are just unaware of it.
This is a great idea to get into the next major release. Let's iterate and get it merged. I do recommend we move this to a PR =)

@bhilburn

I like the idea of detecting virtualization a lot. The primary issue here is that we have a lot of OSX users, > so we'll need something in there that works for them, as well.

Maybe I am wrong. But do we really need this? I mean most of the OSX doesn't virtualize OSX. They just run powerlevel9k on their Macbook without virtualization. Therefore they would just see 'none' virtualization in their powerline.. More important would be a solution for BSD. Although if we solve BSD, I think we will solve OSX, too.

SSH detection is currently built into the context segment (see here), but it probably makes sense to break > it out into its own function.

Are you sure checking for SSH_CLIENT is enough? I would also check for SSH_TTY. Some SSH_CLIENTS may not set SSH_CLIENTS.

You raise an interesting point about things not working if the $USER changes within the SSH session... >it's interesting that there isn't some sort of environmental awareness of this carried forward. I wonder if >there is and we are just unaware of it.

Well, I thought about this for a while.. I solved this on my Server with using su -p and sudo -E this way the environment will be preserved. But this is really unclean and nobody should do this.. I  thought about writing a temporary file somewhere so that powerlevel9k would know about an SSH Session. But how to make sure to delete it after the SSH Session was closed? I really doubt that there is a better way to detect SSH than our current way.. For most of the people it will be enough they just log in on their server with root access and work in a root shell..
For BSD I found several solutions. Solution 1 is to use dmidecode -s system-product-name. Solution 2 would be to convert this into a shellscript: https://github.com/chef/ohai/blob/master/lib/ohai/plugins/bsd/virtualization.rb

Maybe I am wrong. But do we really need this? I mean most of the OSX doesn't virtualize OSX. They just run powerlevel9k on their Macbook without virtualization. Therefore they would just see 'none' virtualization in their powerline.. More important would be a solution for BSD. Although if we solve BSD, I think we will solve OSX, too.

Oh, I see your point. Yes, I agree, nobody is virtualizing OSX. If someone using OSX, though, has a local Vagrant Linux virtualization, that is something we would want to work. That would still work with the above, though, as this code works with Linux. 👍

Are you sure checking for SSH_CLIENT is enough? I would also check for SSH_TTY. Some SSH_CLIENTS may not set SSH_CLIENTS.

You're right. That's an important improvement.

Well, I thought about this for a while.. I solved this on my Server with using su -p and sudo -E this way the environment will be preserved. But this is really unclean and nobody should do this.. I thought about writing a temporary file somewhere so that powerlevel9k would know about an SSH Session. But how to make sure to delete it after the SSH Session was closed? I really doubt that there is a better way to detect SSH than our current way.. For most of the people it will be enough they just log in on their server with root access and work in a root shell..

Agreed. I think we are just going to have to accept this limitation.

For BSD I found several solutions. Solution 1 is to use dmidecode -s system-product-name. Solution 2 would be to convert this into a shellscript: https://github.com/chef/ohai/blob/master/lib/ohai/plugins/bsd/virtualization.rb

I don't know anything about BSD, but it looks like dmidecode is standard on BSD OSes. Let's roll with that.
Can you put all of this together and submit a PR against next? Excited to get these improvements merged.

And, actually, let's try to get #335 integrated into this, as well.

Merged!

Wait, no - only partially. We can now detect SSH, but not other types of virtualization. @shibumi still has some great ideas, here, that could be added to P9k.

@bhilburn mh? I have added detection for virtualization via systemd long ago. Or what are you talking about? ^^

@shibumi - No, you're right, I was confused, hah.


Removed nodes not correctly cleaned up

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Deploy a 3 node custom cluster with roles all and wait for the cluster to stabilize
Delete one of the nodes

Result:

Docker and k8s containers continue to run on the deleted node.
etcd is still trying to reconnect to its peers, and in one test even able to do so and continued on as the master (though we've not reproduced this since).
/etc/kubernetes/ssl has not been cleared.
When I restarted the node it rejoined the cluster as a worker

root@ip-10-0-4-253:/home/ubuntu# docker ps
CONTAINER ID        IMAGE                                 COMMAND                  CREATED             STATUS                          PORTS               NAMES
3d658f8790c4        70f311871ae1                          "/coredns -conf /etc…"   45 seconds ago      Up 44 seconds                                       k8s_coredns_coredns-7c5566588d-m585c_kube-system_bd1af8ea-f647-43ca-8c80-57020d261e1e_3
887b4fdf0ccb        rancher/kube-api-auth                 "/bin/sh -c 'kube-ap…"   29 hours ago        Up 29 hours                                         k8s_kube-api-auth_kube-api-auth-6l5ms_cattle-system_25c77d6e-59ef-40a6-9b52-4527bb14a53f_0
87d115b009f9        069831ff8196                          "run.sh"                 29 hours ago        Up 29 hours                                         k8s_agent_cattle-node-agent-r4lp7_cattle-system_93160240-7dac-4bf5-ae1a-51b1d4b349c4_0
e52cd9e1081c        rancher/pause:3.1                     "/pause"                 29 hours ago        Up 29 hours                                         k8s_POD_kube-api-auth-6l5ms_cattle-system_25c77d6e-59ef-40a6-9b52-4527bb14a53f_0
e859429fd2cf        rancher/pause:3.1                     "/pause"                 29 hours ago        Up 29 hours                                         k8s_POD_cattle-node-agent-r4lp7_cattle-system_93160240-7dac-4bf5-ae1a-51b1d4b349c4_0
09a50ab9643f        rancher/nginx-ingress-controller      "/usr/bin/dumb-init …"   29 hours ago        Up 29 hours                                         k8s_nginx-ingress-controller_nginx-ingress-controller-nnjrv_ingress-nginx_c02dbebc-230d-45d0-864d-11e2e9229f6c_0
2e030f5a770f        rancher/pause:3.1                     "/pause"                 29 hours ago        Up 29 hours                                         k8s_POD_nginx-ingress-controller-nnjrv_ingress-nginx_c02dbebc-230d-45d0-864d-11e2e9229f6c_0
af9bbea7e426        rancher/coreos-flannel                "/opt/bin/flanneld -…"   29 hours ago        Up 29 hours                                         k8s_kube-flannel_canal-5fh2c_kube-system_c5497df7-ead8-4680-8e42-9cda428f92b7_0
47fab53b94be        rancher/pause:3.1                     "/pause"                 29 hours ago        Up 29 hours                                         k8s_POD_coredns-7c5566588d-m585c_kube-system_bd1af8ea-f647-43ca-8c80-57020d261e1e_3
2d0bb687dfc0        rancher/calico-node                   "start_runit"            29 hours ago        Up 29 hours                                         k8s_calico-node_canal-5fh2c_kube-system_c5497df7-ead8-4680-8e42-9cda428f92b7_0
7a37f606e86b        rancher/pause:3.1                     "/pause"                 29 hours ago        Up 29 hours                                         k8s_POD_canal-5fh2c_kube-system_c5497df7-ead8-4680-8e42-9cda428f92b7_0
fe55b79e5404        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 29 hours                                         kube-proxy
728d643f7880        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 29 hours                                         kubelet
16adc313d1bc        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 16 hours                                         kube-scheduler
819a18e106fc        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 5 minutes                                        kube-controller-manager
41c2555b9ac5        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 29 hours                                         kube-apiserver
c8c25f103d58        rancher/coreos-etcd:v3.4.3-rancher1   "/usr/local/bin/etcd…"   29 hours ago        Restarting (0) 22 seconds ago                       etcd
root@ip-10-0-4-253:/home/ubuntu# ls /etc/kubernetes/ssl
certs                                    kube-apiserver-requestheader-ca.pem  kube-controller-manager.pem   kube-etcd-10-0-4-36-key.pem  kube-proxy.pem                      kubecfg-kube-apiserver-proxy-client.yaml      kubecfg-kube-scheduler.yaml
kube-apiserver-key.pem                   kube-apiserver.pem                   kube-etcd-10-0-4-196-key.pem  kube-etcd-10-0-4-36.pem      kube-scheduler-key.pem              kubecfg-kube-apiserver-requestheader-ca.yaml
kube-apiserver-proxy-client-key.pem      kube-ca-key.pem                      kube-etcd-10-0-4-196.pem      kube-node-key.pem            kube-scheduler.pem                  kubecfg-kube-controller-manager.yaml
kube-apiserver-proxy-client.pem          kube-ca.pem                          kube-etcd-10-0-4-253-key.pem  kube-node.pem                kube-service-account-token-key.pem  kubecfg-kube-node.yaml
kube-apiserver-requestheader-ca-key.pem  kube-controller-manager-key.pem      kube-etcd-10-0-4-253.pem      kube-proxy-key.pem           kube-service-account-token.pem      kubecfg-kube-proxy.yaml

ubuntu@ip-10-0-4-253:~$ sudo su
root@ip-10-0-4-253:/home/ubuntu# docker ps
CONTAINER ID        IMAGE                                 COMMAND                  CREATED             STATUS                         PORTS               NAMES
84c1d3e7c322        ff281650a721                          "/opt/bin/flanneld -…"   16 seconds ago      Up 15 seconds                                      k8s_kube-flannel_canal-9vhpj_kube-system_65faa90a-e36d-4b7e-bba3-0872b98d5e30_0
00518ce87b49        d6abb567faf1                          "start_runit"            16 seconds ago      Up 16 seconds                                      k8s_calico-node_canal-9vhpj_kube-system_65faa90a-e36d-4b7e-bba3-0872b98d5e30_0
ae97fcc7a59c        069831ff8196                          "run.sh"                 19 seconds ago      Up 18 seconds                                      k8s_agent_cattle-node-agent-hlvlb_cattle-system_c6f00bbf-a1ad-4b63-8ad8-d9feb36b21e6_0
f987b9b339c8        rancher/pause:3.1                     "/pause"                 19 seconds ago      Up 19 seconds                                      k8s_POD_cattle-node-agent-hlvlb_cattle-system_c6f00bbf-a1ad-4b63-8ad8-d9feb36b21e6_0
d14008227485        rancher/pause:3.1                     "/pause"                 19 seconds ago      Up 19 seconds                                      k8s_POD_canal-9vhpj_kube-system_65faa90a-e36d-4b7e-bba3-0872b98d5e30_0
4bbf35e946e9        rancher/rancher-agent:v2.3.4          "run.sh --server htt…"   29 seconds ago      Up 27 seconds                                      mystifying_gould
fe55b79e5404        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 31 seconds                                      kube-proxy
728d643f7880        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 31 seconds                                      kubelet
16adc313d1bc        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 31 seconds                                      kube-scheduler
819a18e106fc        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 31 seconds                                      kube-controller-manager
41c2555b9ac5        rancher/hyperkube:v1.17.4-rancher1    "/opt/rke-tools/entr…"   29 hours ago        Up 31 seconds                                      kube-apiserver
c8c25f103d58        rancher/coreos-etcd:v3.4.3-rancher1   "/usr/local/bin/etcd…"   29 hours ago        Restarting (0) 4 seconds ago                       etcd
root@ip-10-0-4-253:/home/ubuntu# ls /etc/kubernetes/ssl
certs                                    kube-apiserver-requestheader-ca.pem  kube-controller-manager.pem   kube-etcd-10-0-4-36-key.pem  kube-proxy.pem                      kubecfg-kube-apiserver-proxy-client.yaml      kubecfg-kube-scheduler.yaml
kube-apiserver-key.pem                   kube-apiserver.pem                   kube-etcd-10-0-4-196-key.pem  kube-etcd-10-0-4-36.pem      kube-scheduler-key.pem              kubecfg-kube-apiserver-requestheader-ca.yaml
kube-apiserver-proxy-client-key.pem      kube-ca-key.pem                      kube-etcd-10-0-4-196.pem      kube-node-key.pem            kube-scheduler.pem                  kubecfg-kube-controller-manager.yaml
kube-apiserver-proxy-client.pem          kube-ca.pem                          kube-etcd-10-0-4-253-key.pem  kube-node.pem                kube-service-account-token-key.pem  kubecfg-kube-node.yaml
kube-apiserver-requestheader-ca-key.pem  kube-controller-manager-key.pem      kube-etcd-10-0-4-253.pem      kube-proxy-key.pem           kube-service-account-token.pem      kubecfg-kube-proxy.yaml

Expected Behavior

All containers on the host to be stopped
All secure information (including /etc/kubernetes/ssl) should be removed
The node should not rejoin the cluster when restarted

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.4

Cluster information

Cluster type: Custom cluster hosted on EC2 nodes
Kubernetes version: v1.17.4

gz#9282
gz#10636
gz#11132
gz#12206
gz#14041

I re-ran the delete and reboot on a second node to capture screenshots before and after the reboot.
Before:

After:

This bug caused a production outage because kube-scheduler and kube-controller-manager were left behind. Due to the "zombie" scheduler grabbing the leader election but being unable to schedule anything due to overlay not being available on the deleted node.
Error:
Internal error occurred: failed calling webhook "admission-webhook.windows-gmsa.sigs.k8s.io": Post https://gmsa-webhook.gmsa-webhook.svc:443/mutate?timeout=30s: context deadline exceeded; Deployment does not have minimum availability.
Workaround:
docker rm -f kube-scheduler
docker rm -f kube-controller-manager

Containers that are being left behind.

Here are all the containers that are being left behind on a deleted node.

I believe we are seeing this when people destroy clusters using Terraform.

@maggieliu I think this might be an RKE issue instead of Rancher.  Could we get a review to be sure?

Related issue https://github.com/rancher/rancher/issues/21299

related to this: https://github.com/rancher/rancher/issues/17893

related to: https://github.com/rancher/rancher/issues/17893#issuecomment-466129353

I was able to reproduce this issue with v2.5.1 released

Steps to reproduce

At Rancher UI, bring custom clusters k8s with roles( etcd, control plane, worker) enable in each node
Once the cluster is running and stable,
delete one of these k8s nodes
The "delete" didn't completely delete the rancher configuration on the deleted node
Reboot the k8s node which was deleted from the cluster, the node joined as a worker node in the cluster again.

Expected behaviors, delete operations should completely prune all config information from the deleted node to avoid this behavior. Reboot/restart operation on the node shouldn't automatically join the deleted node in the cluster.
Execute the following command on the terminal of the deleted nodes,
buntu@ip-172-31-0-248:~$ sudo docker ps
CONTAINER ID        IMAGE                                  COMMAND                  CREATED             STATUS                          PORTS               NAMES
cf972c9b3ffc        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   5 minutes ago       Up 5 minutes                                        kube-apiserver
91d4d65ae2d1        rancher/coreos-etcd:v3.4.13-rancher1   "/usr/local/bin/etcd…"   6 minutes ago       Restarting (0) 18 seconds ago                       etcd
d7224ffdf9eb        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   11 minutes ago      Up 11 minutes                                       kube-proxy
cd8b50cdb415        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 12 minutes                                       kubelet
1ef0e245d961        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 7 minutes                                        kube-scheduler
4591ffb78d83        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 7 minutes                                        kube-controller-manager
A few minutes later
ubuntu@ip-172-31-0-248:~$ sudo docker ps
buntu@ip-172-31-0-248:~$ sudo docker ps
CONTAINER ID        IMAGE                                  COMMAND                  CREATED             STATUS                          PORTS               NAMES
cf972c9b3ffc        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   5 minutes ago       Up 5 minutes                                        kube-apiserver
91d4d65ae2d1        rancher/coreos-etcd:v3.4.13-rancher1   "/usr/local/bin/etcd…"   6 minutes ago       Restarting (0) 18 seconds ago                       etcd
d7224ffdf9eb        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   11 minutes ago      Up 11 minutes                                       kube-proxy
cd8b50cdb415        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 12 minutes                                       kubelet
1ef0e245d961        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 7 minutes                                        kube-scheduler
4591ffb78d83        rancher/hyperkube:v1.19.3-rancher1     "/opt/rke-tools/entr…"   12 minutes ago      Up 7 minutes                                        kube-controller-manager
SSL dir has the pem.keys
ubuntu@ip-172-31-0-248:~$

I have the same issues on my 2.5.5 clusters.

Reproduced the issue on 2.5.6

Deploy a cluster - 3 nodes all roles
Delete a node. Cluster goes into Updating state.
Docker ps on the deleted node shows:

docker ps
CONTAINER ID   IMAGE                                  COMMAND                  CREATED          STATUS                          PORTS     NAMES
082d505d886a   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   15 minutes ago   Up 15 minutes                             kube-proxy
57efa4ee9441   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   15 minutes ago   Up 15 minutes                             kubelet
a8cd9c208dd3   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   15 minutes ago   Up About a minute                         kube-scheduler
ec6e4be2e175   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   15 minutes ago   Up About a minute                         kube-controller-manager
f59565155eb5   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   15 minutes ago   Up 15 minutes                             kube-apiserver
d8c96cb0fac8   rancher/coreos-etcd:v3.4.14-rancher1   "/usr/local/bin/etcd…"   17 minutes ago   Restarting (0) 23 seconds ago             etcd

kubectl get nodes on the cluster does not list the deleted node.
Reboot the deleted node
Node joined bacck to the cluster as worker nodes
docker ps on the node shows

docker ps
CONTAINER ID   IMAGE                                  COMMAND                  CREATED          STATUS                          PORTS     NAMES
ee52e9d038b0   0bfefe9f649b                           "/opt/bin/flanneld -…"   28 seconds ago   Up 27 seconds                             k8s_kube-flannel_canal-p6l4s_kube-system_81c92878-f838-4eba-8434-4b57176630a6_0
d58d15e9b372   5a3c598c81d5                           "start_runit"            28 seconds ago   Up 27 seconds                             k8s_calico-node_canal-p6l4s_kube-system_81c92878-f838-4eba-8434-4b57176630a6_0
09c468c4bf2a   4cd72bf2d36b                           "run.sh"                 31 seconds ago   Up 30 seconds                             k8s_agent_cattle-node-agent-fwpk6_cattle-system_00446b79-d0ad-421a-b888-187845ac58fc_0
72edaeb8cb89   rancher/pause:3.2                      "/pause"                 32 seconds ago   Up 31 seconds                             k8s_POD_cattle-node-agent-fwpk6_cattle-system_00446b79-d0ad-421a-b888-187845ac58fc_0
150470fa6018   rancher/pause:3.2                      "/pause"                 32 seconds ago   Up 31 seconds                             k8s_POD_canal-p6l4s_kube-system_81c92878-f838-4eba-8434-4b57176630a6_0
6527f9e70129   rancher/rancher-agent:v2.5.6           "run.sh --server htt…"   50 seconds ago   Up 49 seconds                             silly_elbakyan
082d505d886a   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   18 minutes ago   Up 51 seconds                             kube-proxy
57efa4ee9441   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   18 minutes ago   Up 51 seconds                             kubelet
a8cd9c208dd3   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   18 minutes ago   Up 50 seconds                             kube-scheduler
ec6e4be2e175   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   18 minutes ago   Up 50 seconds                             kube-controller-manager
f59565155eb5   rancher/hyperkube:v1.20.4-rancher1     "/opt/rke-tools/entr…"   18 minutes ago   Up 50 seconds                             kube-apiserver
d8c96cb0fac8   rancher/coreos-etcd:v3.4.14-rancher1   "/usr/local/bin/etcd…"   20 minutes ago   Restarting (0) 12 seconds ago             etcd

Reproduced the issue on v2.5.6:

Created a custom cluster with 3 nodes all roles on ember UI
Once the node is up and active, deleted one of the nodes
On the removed node, for docker ps

On kubectl get nodes:

Once the node is rebooted and has come active, it joined the cluster back as a worker node:

Verified on the rancher version: b2f8824
Scenario1:

Created an rke1 custom cluster from ember UI - 3 nodes all roles enabled on all 3 nodes.
Once the cluster is active, delete one of the nodes
On the deleted node, docker ps:
all containers were removed

Restarted the node that was deleted from ember UI and verified that it was not added as a worker node
Scenario2:

Created an rke1 custom cluster from explorer - 3 nodes all roles.
Once the cluster is active, deleted one of the nodes and the docker ps has no containers running except for the following. Rebooted the node and see that the node is not added back as a worker node.

CONTAINER ID        IMAGE                                                                        COMMAND                  CREATED             STATUS                          PORTS               NAMES
959e737abcb2        rancher/rancher-agent:master-b2f88241d8a5194b5a3a39cc84de0b0a046f8b7e-head   "run.sh --no-registe…"   2 hours ago         Restarting (1) 20 seconds ago                       share-mnt

Re-opening the tickte for the issue seen:
Scenario3:

Create an rke1 custom cluster from the dashboard UI with 3 nodes all roles.
Once the cluster is up and active, remove two nodes and verify the docker ps has no containers but the following and when we reboot the nodes they are not added back to the cluster.
Now remove the remaining 1 node as well with all roles as well. Following are the docker ps cotainers:

CONTAINER ID        IMAGE                                           COMMAND                  CREATED             STATUS              PORTS               NAMES
8e49757d47cc        rancher/hyperkube:v1.20.7-rancher1              "/opt/rke-tools/entr…"   8 minutes ago       Up 8 minutes                            kube-apiserver
14b5d7655cc9        rancher/mirrored-coreos-etcd:v3.4.15-rancher1   "/usr/local/bin/etcd…"   9 minutes ago       Up 9 minutes                            etcd
5edb7d6782f0        rancher/hyperkube:v1.20.7-rancher1              "/opt/rke-tools/entr…"   2 hours ago         Up 2 hours                              kube-proxy
1406aea831a2        rancher/hyperkube:v1.20.7-rancher1              "/opt/rke-tools/entr…"   2 hours ago         Up 2 hours                              kubelet
d1083e0c9ef1        rancher/hyperkube:v1.20.7-rancher1              "/opt/rke-tools/entr…"   2 hours ago         Up About an hour                        kube-scheduler
ba51a771e4dd        rancher/hyperkube:v1.20.7-rancher1              "/opt/rke-tools/entr…"   2 hours ago         Up 9 minutes                            kube-controller-manager

If we reboot the node, once it comes up, it is added back in the cluster as a worker node.
docker ps:
CONTAINER ID        IMAGE                        COMMAND             CREATED             STATUS              PORTS               NAMES
e18140a0a853        rancher/mirrored-pause:3.2   "/pause"            11 minutes ago      Up 11 minutes
         k8s_POD_canal-45hnb_kube-system_895cfacd-d9f4-4e27-ab16-c04e81bbd732_1

After sometime, the cluster goes into error state with the following logs in rancher server:
2021/06/07 17:31:12 [ERROR] error syncing 'c-bx4cm/machine-285t6': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing

Verified on master-6b430f31afb9cfc5493f686279a97dd79c54ad88-head
Scenario2 from above comments:

Created an rke1 custom cluster from explorer - 3 nodes all roles.
Once the cluster is active, deleted one of the nodes and the docker ps has no containers running .
Rebooted the node and see that the node is not added back as a worker node.

Scenario3 from above comments:

Create an rke1 custom cluster from the dashboard UI with 3 nodes all roles.
Once the cluster is up and active, removed two nodes and verified the docker ps has no containers running and when we reboot the nodes they are not added back to the cluster.
Now removed the remaining 1 node as well with all roles. All the docker running containers were removed.
Rebooted the node and it was not added back as worker node

Scenario4 - new

Created an rke1 custom cluster from ember UI with 3 etcd nodes, 2 cp nodes, 3 worker nodes
Removed 1 etcd node and verified all the containers from the node were removed and once we reboot, it is not added back as worker node
Removed 1 worker node and verified all the containers from the node were removed and on rebooting it was not added back
Verified the same step as above with 1 control plane node.


TypeError: self._verifyPermission is not a function when connecting over USB

I did not see a bug template or anything sorry, so I will try to give all the info I have here.
Bug
When trying to use the web editor I am running into the following error:

I don't see self being referenced anywhere else in the codebase, should it be a this?
Reproduction

Connect via USB to Pico W
Click "open" or "save" actions
Should infinite spinner and error in console

Info
Adafruit CircuitPython 8.0.0 on 2023-02-06; Raspberry Pi Pico W with rp2040
Board ID:raspberry_pi_pico_w
UID:E66141040356482F
MAC:28:CD:C1:04:37:4B

Yes, good catch. It's probably due to too much switching back and forth between python and javascript. :) Especially since I was working on a python/javascript interface at the time.

Also, good idea on adding issue templates.


Error Deploying Istio with HELM v3

Hello @hickeyma Martin
When I tried to deploy Istio using Helm v3 following the read me I get the following Error: create: failed to create: Request entity too large: limit is 3145728
Context: I'm deploying on EKS v1.17
Thank you by advance

Do you accidentally include any .tgz or any other large file in the chart directory?

No !
I even deleted some files :
$ du -sh ./istio/*/*
144K	./istio/crds/crd-all.gen.yaml
4.0K	./istio/crds/crd-operator.yaml
8.0K	./istio/templates/clusterrole.yaml
4.0K	./istio/templates/clusterrolebinding.yaml
4.0K	./istio/templates/crds.yaml
4.0K	./istio/templates/endpoints.yaml
4.0K	./istio/templates/role.yaml
4.0K	./istio/templates/rolebinding.yaml
4.0K	./istio/templates/serviceaccount.yaml
4.0K	./istio/templates/services.yaml
4.0K	./istio/templates/validatingwebhookconfiguration.yaml

@abhassine Where did you get the charts from? Is there a manifests/charts directory?

Hello @hickeyma
I used this charts https://github.com/abhassine/istio/tree/master/manifests/charts/base but without success.
Finally, I was able to deploy ISTIO with Helm3 through ISTIO Operator.
I just included the configuration profile manifest under istio-operator/templates into ISTIO OPERATOR charts removed namespace.yaml
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: demo
EOF

by this
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: {{ .Values.nameProfile }}
spec:
  profile: {{ .Values.Profile }}

and I was able to deploy successfully 👍
COUW3026476:charts abenhassine$ kgpoall
NAMESPACE              NAME                                                        READY     STATUS    RESTARTS   AGE
istio-operator         istio-operator-5b7798f566-5gq7n                             1/1       Running   0          19s
istio-system           istio-egressgateway-6488cc97fc-qql7s                        1/1       Running   0          20m
istio-system           istio-ingressgateway-6bd9856d48-gf9sx                       1/1       Running   0          20m
istio-system           istiod-69fd878578-jkwrs                                     1/1       Running   0          20m

Thanks


Release version 0.3.0

Can you please release version 0.3.0 (or later)?
Ideally, it would be great if you could publish to hex, but if you just tag a release that would be sufficient too.
The lack of releases is making things rather difficult for distribution packagers and other users of hamcrest-erlang.
Thanks!

Apologies @candrews, as you can see I've not been maintaining this for quite some time now. If you let me know what needs to be bundled and/or changed, I can tag it. Publishing to hex will have to wait as I don't have a working development environment for rebar3/erlang/hex at the moment and don't have time to set one up.

I will appreciate a lot if you could tag latest commit, the same as you did this for tag/release 0.1.0 in 2012.
Thanks in advance!


[Add a Play]: Two Play Rock Paper Scissors

What's the Play about?
This play is a typical dual-player rock paper scissor game.
What ReactJS concept will be used to create this play?
Components and Hooks
Are you willing to take it up for implementation?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you update me on the progress of this particular issue?


WAIT UP TO 1 SECONDS.

WAIT UP TO 1 SECONDS.

push channels implemented, https://github.com/abaplint/transpiler/blob/main/packages/transpiler/src/statements/wait.ts
but the basic WAIT is todo


CI: add reusable actions

Describe your PR, what does it fix/add?
Allows reusing actions across the org, meaning less copied code and less
chances of errors slipping in when a change is made.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Untested, will let the CI run.
Is it ready for merging, or does it need work?
I also want to create a conditional job:

when wlroots gets updated, don't run Nix builds
when there's no wlroots update, run the builds

FYI, there is a tool called act that lets you run and debug github actions locally, it's in nixpkgs I think.

Damn, didn't know that. Thanks. However I think I've mostly finished this PR.

Ok, so if there are both a pull_request and a push trigger, the wlroots update action will fail for one of them. Doesn't affect builds at all though. This should happen very rarely, only if vax decides to bump wlroots inside a PR. I think it's good enough for now.
Alternatively I could make it so that pull_request is never run if the PR ref is from this repo, but it's not worth the complication.

Maybe add a condition to skip this job in PR?
wlroots / wlroots
Secret PAT is required, but not provided while calling.

Oops. Okay, I'll fix it.

if: ${{ !startsWith(github.ref, "refs/pull/") && !endsWith(github.ref, "/merge") }}

I came up with something like this
name: Nix

on: [push, pull_request, workflow_dispatch]

jobs:
  wlroots:
    if: github.event_name == 'push'
    uses: ./.github/workflows/nix-update-wlroots.yml
    secrets: inherit

  build:
    if: always() && !cancelled() && !contains(needs.*.result, 'failure')
    needs: wlroots
    uses: ./.github/workflows/nix-build.yml
    secrets: inherit

since we still want the packages to be built even if wlroots updating was skipped.


[Bug] When using Uniq model, we can't update a part of columns, i.e.  replace_if_not_null is invalid.

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
dev-1.0.1
What's Wrong?
Step 1:
CREATE TABLE test1 (
goods_id bigint(20)   ,
goods_name varchar(200),
day_sale int(11) ,
date date
)
UNIQUE KEY(goods_id)
DISTRIBUTED BY HASH(goods_id) BUCKETS 10
PROPERTIES
(
"replace_if_not_null" = "true"
);
Step 2:
INSERT INTO test1 ( goods_id, goods_name, day_sale, date )
VALUES
( 1, "good1", 10, '2022-04-20' ),
(2, "good2",12,'2022-04-20');
MySQL [test]> select * from test1;
+----------+------------+----------+------------+
| goods_id | goods_name | day_sale | date       |
+----------+------------+----------+------------+
|        2 | good2      |       12 | 2022-04-20 |
|        1 | good1      |       10 | 2022-04-20 |
+----------+------------+----------+------------+
2 rows in set (0.01 sec)
Step 3：
INSERT INTO test1 ( goods_id, goods_name, day_sale, date )
VALUES
( 1, NULL, 11, '2022-04-20' ),
(2,NULL,13,'2022-04-20');
MySQL [test]> select * from test1;+----------+------------+----------+------------+
| goods_id | goods_name | day_sale | date       |
+----------+------------+----------+------------+
|        2 | NULL       |       13 | 2022-04-20 |
|        1 | NULL       |       11 | 2022-04-20 |
+----------+------------+----------+------------+
2 rows in set (0.01 sec)
Expect:
MySQL [test]> select * from test1;
+----------+------------+----------+------------+
| goods_id | goods_name | day_sale | date       |
+----------+------------+----------+------------+
|        2 | good2      |       13 | 2022-04-20 |
|        1 | good1      |       11 | 2022-04-20 |
+----------+------------+----------+------------+
2 rows in set (0.01 sec)
What You Expected?
MySQL [test]> select * from test1;
+----------+------------+----------+------------+
| goods_id | goods_name | day_sale | date       |
+----------+------------+----------+------------+
|        2 | good2      |       13 | 2022-04-20 |
|        1 | good1      |       11 | 2022-04-20 |
+----------+------------+----------+------------+
2 rows in set (0.01 sec)
Expect it could implement part columns updating.
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I remember replace_if_not_null is a aggregate method?
use aggregate table and replace_if_not_null

refer to: https://zhuanlan.zhihu.com/p/394878570
Actually it doesn't work.


RHELAI-969: Revert "Fix long container startup times"

This reverts commit 2f2d608f71d82c433e7016199b9d5ab69466d50f.
We're reverting because ilab wrapper fails when running podman commit, as it tries to write in /usr/lib/containers/storage container-storage, which is read-only:
Error: copying layers and metadata for container "4f45cf68b00c7dcce075f1fb784435accd1db1b725281d9baef3e1e4af1c400b": initializing source containers-storage:reverent_maxwell: extracting layer "05bbf1431815e7eceec338385e6bc33036661c66a7f702fd23898d9b0c85811e": unmounting layer 9e50616152e3b65bd1764bc87294cbd44869020820007dfc454dc4606485e8c3: removing mount point "/usr/lib/containers/storage/overlay/9e50616152e3b65bd1764bc87294cbd44869020820007dfc454dc4606485e8c3/merged": read-only file system

/cc @fabiendupont
/cc @kwozyman
/cc @n1hility

/cc @cdvultur

@n1hility PTAL

Looking into this but we need a good build so reverting for now


gdrive not working

I launched the dreambooth_runpod_joepenna.ipynb, but could not log in to gdrive. after executing the request and opening the generated link in the browser, I see this:
The out-of-band (OOB) flow has been blocked in order to keep users secure. Follow the Out-of-Band (OOB) flow Migration Guide linked in the developer docs below to migrate your app to an alternative method

I was linked to this docu page: https://developers.google.com/identity/protocols/oauth2/resources/oob-migration

A workaround using another repo:
download credentials from google console, call it "credentials.json"
pip3 install --upgrade gupload to install the repo
create a folder in Gdrive and "share" it public
Copy the ID of the folder
gupload --to FOLDERIDHERE --file nameofthefileyouaresavingas.ckpt /workspace/Dreambooth-Stable-Diffusion/trained_models/nameofthefiletoupload.ckpt

A workaround using another repo:
download credentials from google console, call it "credentials.json"
pip3 install --upgrade gupload to install the repo
create a folder in Gdrive and "share" it public
Copy the ID of the folder
gupload --to FOLDERIDHERE --file nameofthefileyouaresavingas.ckpt /workspace/Dreambooth-Stable-Diffusion/trained_models/nameofthefiletoupload.ckpt

why do I need to download the credentials? It looks like I never use them later.

got this error, where do i put the json file?


Only max of 2 browser instances are running

I'm only seeing two instances of PhantomJS running at a time. With -s, I see more instances. I'm not sure if this is a bug in ember-exam or testem.js.
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Command:
ember exam --split=10 --parallel --silent

What is your Testem config? Specifically, what is the value of parallel inside your testem.js or testem.json file?

@trentmwillis good question. I saw a bunch of configs with parallel: -1 and didn't know that I needed to add that to my config.
After adding parallel I saw >2 browser instances.
Closing.


The sidebar disappeared

As the picture shows, the left sidebar disappeared.
My Browser is Google Chrome 91.0.4472.164.

But the strange thing is that in private browsing mode, it works very well.

The problem is solved. The extension "Mate Translate" leded to this problem, but the specific reason is not clear.


IMU rate for calculating discrete-time noise parameter

Hello，Dr. Shan. Excellent Work!  With respect to imu preintegration,  you use gtsam's implementation. The question is that  where can we  offer the imu rate for calculating discrete-time noise parameter? I didn't find the imu rate setup in your code.  And I assume the imu nosie parameter in params.yaml is in continuous-time. Am I right? Thank you very much

IMU rate doesn't need to be provided. GTSAM will integrate all the available measurements. The imu noise in params is calibrated using Kalibr when I put IMU static for at least 2 hours.

IMU rate doesn't need to be provided. GTSAM will integrate all the available measurements. The imu noise in params is calibrated using Kalibr when I put IMU static for at least 2 hours.

Thanks!

For this issue, I find that in the GTSAM class PreintegratedImuMeasurements , the method called integrateMeasurement have a parameter called dt, which allows to pass from continuous time noise to discrete time noise.  dt can be calculated liked the imuPreintegration.cpp line 357. So IMU rate doesn't need to be provided.


history-improvements

Summary by CodeRabbit

New Features

Improved user history page with added query and sorting functionality for a better user experience when viewing sessions.

Bug Fixes

Fixed user authentication issues by updating the user declaration to use the latest getCurrentUser() method.

@coderabbitai  resolve


[CPU] Enable data-tiling for mixed float types.

Fixes https://github.com/openxla/iree/issues/15816

It saves 1h30m for benchmarking.
Sample: https://github.com/openxla/iree/actions/runs/7112645304/job/19364712347

97.23%↓ deserves some kind of an award :)

really.. this is without even micro kernels right? Thanks a lot Hanhan! And really, ill buy you a drink tonight for this.

97.23%↓ for ukernel path, and 92.36%↓ w/o ukernel!


Rare server autosave error with foreach and tile entities.

Via misario:

can easily be fixed by saving keys to an array here and using for instead

Unfortunately saving the keys to an array will also cause a concurrent modification exception.
After looking very briefly through the threaded save and play callback, I'm calling out a fundamental threading architecture problem. The world can be modified (in any way) mid-save, which can cause the loaded file to be inconsistent (regardless of runtime crashes). The takehome is always call save and shutdown your sever properly, because actually fixing this is beyond our scope.
The naive stopgap solution is to just lock on all modifications to the dictonary, however there may be too many places in the code that maintenance and slowdown becomes annoying,
A better solution is to snapshot the tile-entity and other dictionaries on the main thread and store them in temp variables before the save call is invoked on the threadpool.
I'll note that there are other locations which could have the same issue, SaveWeightedPressurePlates SaveTownManager etc but vanilla gets away with these (and tile entities) because they're so rarely modified that the chances of them colliding with the save loop is very low.
There are many locations for small inconsistencies in save files to appear in other parts that won't throw an exception as well. For example, in several locations, an npc is set to active = true, before being assigned all its valid data, so it could end up getting saved in the middle of this process, causing an invalid npc to be spawned on load. Vanilla tends to be written (especially old code) in such a way that it makes very few assumptions about the state of the fields of its objects. If an entity is saved with a location, or id, or data, or something else that's 'corrupted' it generally just spazzes out or despawns.
Of course, vanilla also gets away with this for the most part because loading a world from autosave rarely happens unless the game crashes or is forcibly closed, and then it has the backup so that if an exception is raised during loading it can use the previous save.
All these measures mean that the chances of a world being irreparably damaged are very low indeed, but not zero, and things like mods using more entities and tile entities only increases the chances of encountering these flaws.


[ENH] Output simple streamz

hvplot currently handles streamz dataframes.
Ordinary streamz streams display as self-updating text in a notebook, using jupyter repr hooks (see streamz.Stream._ipython_display_). It would be very nice to be able to display these things in a Panel and include them in layouts.

Now added Streamz pane which handles all streamz output.

Wooop! I hope you demo this sometime.


Java Chatter REST API in maven repository

Can this be pushed to maven repository which will be very convenient to use it?

Hi @samuel-pt, thanks for you request. I like your idea, although I've personally never actually pushed anything into the maven repository (like Maven Central) - I'll have to do some investigation on how that process works.
If you have some experience, I'd be happy to take your suggestions as well!

Hi @jasperroel, I've done it once using Sonatype Nexus repository. May be you can use that as well. Refer http://www.sonatype.org/nexus/2015/01/08/deploy-to-maven-central-repository/ and https://maven.apache.org/guides/mini/guide-central-repository-upload.html for more details.


stylistic edits

Thanks! The HA flags changed "recently", we forgot to update this part of the documentation.

Thanks!


Pulse instructions should be scheduled with delays

What is the expected enhancement?
Currently, all pulse.Instructions are stored in a Schedule with a two-tuple containing the (start_time, Instruction). While this makes it clear the explicit starting time of every pulse it leads to convoluted internal data structures such as TimeslotCollection for tracking the time of all instructions.
It also encourages inefficient operations such as taking the union of two schedules. At first glance this operation should be efficient since all one needs to do is specifying the starting time of the instructions, but this requires verification that no instructions overlap in time in the two schedules resulting in expensive checks.  The requirement for such a check to merge two schedules is obvious within the relatively schedules model, as one must look to make sure a delay exists in the first schedule for all instructions of the second schedule to merge.
Furthermore, explicit timing of instructions will become confusing with the introduction of control-flow to quantum programs as it would become difficult to program experiments containing loops that are not unrollable.
We should move to a model where instructions are explicitly scheduled with Delays (think NOPs) of a given duration. This will:

Make appending two schedules a much simpler operation as the dependency of instructions will be specified by their order on operands

This will allow a simple transformation to a DAG representation of a basic pulse schedule block

Have positive performance impacts.
Have implications for the current pulse API. I believe this should be mostly internal-facing and that not many changes will exist for users.

Requirements for closure of this issue include:

[ ] Approved RFC
[ ] Implementation

RFC started (only a draft now). RFC link added to description. https://github.com/Qiskit/rfcs/pull/16

This has long since merged. Closing.


Doc should be clear that BluePrint only creates new components, doesn't support updates

I've just started using BluePrint and after reading the doc, "it's common to simply reuse the draft.yaml file over and over again to continue to generate code for your application", I was (wrongly) under the impression that I just could define a column and have my model updated.
I had to read many issues to finally find this one.
I probably shouldn't believe in magic anymore, but I can't help...
I think the doc should make clear that models can't be updated, and/or give any clues to bypass this.

How about:

While you are welcome to create separate draft files, it's common to simply reuse the draft.yaml file over and over again to generate code for your application.

Updated in b68b094


Portal Interrupted by Enemy Collision

Bug report
What is the current behavior?
The Player enters the Portal and the scene begins to fade out / change to the next scene. This process is interrupted, however, if an Enemy collides with the Player during the fade out, resulting in the Player's death. Since the Portal scene transition is relatively slow, there is a decent window of time in which the Enemy can collide with you.
You can (barely) see the Pause/Player Died menu overlay through the mostly-opaque ColorRect that was fading in-- screenshot attached.
What is the expected behavior?
Ideally, entering the Portal should pause any enemies on the current level.
Tell us the steps to reproduce the bug, and if possible share a minimal demo of the problem.

Position your Player near the level's Portal.
Wait for an Enemy to approach, and enter the Portal shortly before collision with the Enemy
Watch as chaos ensues ;)

I coded along step-by-step with the Youtube series, just FYI

Thanks for the report, it's fixed now


Unable to use "<{NICK}> " in RemoteNickFormat for IRC

I'm using matterbridge (0.6.0-beta2) for mattermost <-> IRC. It's working nicely except for one thing.
I wanted to set my own RemoteNickFormat in [IRC] section of matterbridge.conf, but when I've specified my selected format then the messages from mattermost were not shown on IRC.
After some tests I've noticed that when my configuration is:

RemoteNickFormat="{NICK}: "

then everything works and messages are passed correctly, but when it's:

RemoteNickFormat="<{NICK}> "

then the messages are not shown.

Hi, I can't reproduce this. (I actually also use RemoteNickFormat="<{NICK}> " for my own bridge)
Could you paste your complete matterbridge.conf ? (redact servers/logins if necessary)

Hello.
I feel quite embarrassed, but the problem is my fault and it's completely unrelated to matterbridge. I've once set a quite broad ignore rule for messages in irssi, so they were received correctly but not displayed by the IRC client.
Thanks for your time and sorry for the trouble.


fix syntax highlighting

There is no language called node.js
It's just javascript for both
node.js and browser runtime.

@timaschew : Thanks for your contribution! The author, @cynthn, has been notified to review your proposed change.

Verified changes to code fencing.
@timaschew Thanks!


$api->resoure () report an error，flushMiddlewareGroups method not work

Q
A

Bug?
yes

New Feature?
no

Framework
Laravel

Framework version
8.57.0

Package version
3.0.7

PHP version
7.3.29

Actual Behaviour
In routing admin.php, $api->resoure () reports an error Dingo\Api\Routing\Router::resoure method is not defined, but $api->get () is normal

The following is the error code, line 24.

Expected Behaviour
Online search found that the solution to the problem in the issue of the dingo/api github project is vendor\dingo\api\src\Routing\Router.php Finally, the flushMiddlewareGroups method is added, and the bug is fixed after v3.0.6. My current version is 3.0. 7, and there is flushMiddlewareGroups method in this version, it still doesn't work, also try to downgrade to 3.0.6 and still report the same error.
Steps to Reproduce
Just use $api->resoure () ，I tried to reinstall Dingo/Api midway, but nothing worked.

Sorry，I found that resource is written as 'resoure'.


aurutils.t improvements

[x] Split aurutils.t in several files to not repeat everything on a single failure
[X] Remove temporary files on exit
[ ] Test package/database signing
[ ] Use a pacman temporary database instead of sudo to root

Re-adding to milestone since I accidentally broke package signing…

Moved to separate test branch.


[Debian]  Hotkeys does not work

Hello!
Thnks for read this Issue,
I have a problem with the HotKeys, I can not configure it, I tried to reset with "Escape" key but it does not work, I have a keyboard with Special  Keys (multimedia) but neither I can use it.
I tried running with sudo and reconfigure the Multimedia Keys.
Raul Pinedo
SO = Linux Debian 7
Problem = Can not set the HotKeys

I would close this and merge into #413 - it seems to be the home for hotkey issues

@raulpinpla Multimedia keys do not need to be configured, they should work by default.
Hotkeys are set by typing the hotkey while you are focused in the hotkey box.
So click in a box, and perform a hotkey like "Control + Shift + "P" and it will set the hotkey

@MarshallOfSound Hi thanks for your answer, let me see the thread 413, is there a limitation of the keys that we can use for the HotKeys?
I can set it with control, thnks, but I prefer to use the Multimedia keys and it does not work.
Thnks

Multimedia keys should work by default via dbus. What version of the player are you using, and how did you install it?


Upload more files at the same time

Is it possible to upload more files at once? Like adding them to a queue?

The queue is there, but it will upload one file at a time.


Weird particle effects whenever opening an EnderIO GUI

Issue Description:
What happens:
Whenever an EnderIO GUI is opened weird particles show up in the background. Initially occured in Celestial Journey, however tested it with basically just EnderIO installed and it's still happening. See this GIF: https://media.giphy.com/media/SAOdns9fgu2QZPczKr/giphy.gif
What you expected to happen:
Not get particle effects in the background when opening an EnderIO GUI
Steps to reproduce:

Install EnderIO and open a GUI.

Affected Versions (Do not use "latest"):

EnderIO: EnderIO-1.12.2-5.1.55.jar
EnderCore: EnderCore-1.12.2-0.5.73.jar
Minecraft: 1.12.2
Forge: forge-<IP_ADDRESS>54
SpongeForge? No
Optifine? No
Single Player and/or Server? Tested on singeplayer.

Your most recent log file where the issue was present:
https://pastebin.com/Ty0S6xkc

Never mind, space day.

Correct :wink:


Plot false positive rates.

Friendly ping - is this done now and should we be closing this PR?. :)

@jetpack Ok to close this PR?

probably :)


[Feature Request] Redis::Instance - Set default unixsocket

For the new implementation of separate Redis instances, if a unixsocket is not specified, each redis::instance will use the same .sock file. I'm not sure if this poses as an issue, but would like to submit a feature request to append each Redis instance name as the default value for the unixsocket attribute:
(e.g unixsocket => "/var/run/redis/redis-${instance}.sock",)

Yeah, seems reasonable, feel free to open a PR 👍

Disregard. This is happening on the latest version of the module.


English documentation?

Hello
Do you plan to translate the documentation?

I will, when I have time to do so...


August 5th, 2024 Community Meeting

Please add a topic in this thread and add a link to the GitHub issue associated with the topic.
Please make sure you give folks enough time to review/discuss the topic offline on GitHub before coming into the meeting
(optional) Paste the image of an animal 😸

Looking forward to a review on a few website PRs:

https://github.com/shipwright-io/website/pull/115
https://github.com/shipwright-io/website/pull/112

Automation for Tekton bumps: https://github.com/shipwright-io/build/pull/1657

As discussed shipwright-io/build#1657 works fine as tested by @SaschaSchwarze0, however, the fork leads to permission issues while creating the automated PR. As agreed, @apoorvajagtap will approve the PR, so we can merge it and observe the behavior.
It'll be helpful if @HeavyWombat or anyone with the b/w can review website PRs.
@SaschaSchwarze0 is working on the automation to fetch the images, detect the vulnerability, and raise the alert. The question is, whether we want the vulnerabilities to be reported via issues or security alerts. We agreed to bring this up during the next community call to talk more about it.


User profile

Very basic user profile, for milestone 3. Edit buttons don't work yet

lgtm, merging cause video


Test PR

Background

Fixes

Change Summary

Additional Notes

Testing Procedure

Related PRs or Issues

It seems this was created this way by mistake, could you please correct it?

what would the corrected code look like?


Unable to parse image at URL when ran inside Docker container

RTesseract.new takes the path to the image to be processed as shown:
image = RTesseract.new('./img.png')
puts image.to_s

=> text found in the image

Now let's consider the image hosted at this url: https://via.placeholder.com/150

When ran locally, RTesseract appears to be able to take the URL as an image path.
image = RTesseract.new('https://via.placeholder.com/150')
puts image.to_s

=> 150x 150

However this does not work when ran inside an alpine docker container.
Traceback (most recent call last):
	3: from main.rb:3:in `<main>'
	2: from /usr/lib/ruby/gems/2.6.0/gems/rtesseract-3.1.2/lib/rtesseract.rb:41:in `to_s'
	1: from /usr/lib/ruby/gems/2.6.0/gems/rtesseract-3.1.2/lib/rtesseract/text.rb:8:in `run'
/usr/lib/ruby/gems/2.6.0/gems/rtesseract-3.1.2/lib/rtesseract/command.rb:57:in `run': Error, cannot read input file https://via.placeholder.com/150: No such file or directory (RTesseract::Error)
Error during processing.

I've set up a small project where all this can be seen here:
https://github.com/abardallis/tesseract-test.git
To be honest, I'm a little surprised that it works locally and it not working in the docker container makes a little more sense seeing as how passing in a url isn't mentioned in the documentation for rtesseract.
However, it does work locally and I would really enjoy it if it could work on this docker container as well given that I'm hoping to deploy this thing and do not want to store images locally first in order to be able to run them through rtesseract (for reasons).
This might be an underlying issue in how I'm building my docker image and have nothing to do with rtesseract, but I figure this is a good place to start. If there's no way of getting the thing to work on docker, and you could at least provide some context on why this thing is working locally, that would at least help me sleep at night.
Thanks!

@dannnylo any thoughts on this issue?

@dannnylo any thoughts on this issue?

Hello @abardallis, the better way to run rtesseract is with the image already download.
It's a surprise this works on your local, I made some tests, and didn't work for me with URIs.

Hello @abardallis, the better way to run rtesseract is with the image already download.
It's a surprise this works on your local, I made some tests, and didn't work for me with URIs.

I ran into the same issue - it could read the image from the URL on my mac, but the same code failed when ran from within Docker. It looks like in my case I had tesseract 4.1.1 installed on my mac, but 4.0 in Docker - https://stackoverflow.com/a/63316975/772309

Interesting... thanks for the info @ryangrush
I'll check that out and if I remember what I saw staring at the console output during docker build I'm pretty sure you're spot on about the versioning.


Question: how to mark text to not parse it by Markwon

Markwon version: {4.6.0}

I have a question: Is it any way to mark a specific part of text with markdowns to say Markwon not to parse this part of text?

Hello @alexander-smityuk ,
the most effortless solution would be not passing that part of text to markdown parser. For example, you can pre-process your input and extract parts that are not to be passed to markdown parser. I created a sample that you can inspect as a reference

@noties Thank you for the answers and the example. I will check.


Endpoint_status: fix reimport

Solution for https://github.com/DefectDojo/django-DefectDojo/issues/5943
Core of fix was small change of
eps, created = Endpoint_Status.objects.get_or_create(
    finding=finding,
    endpoint=ep,
    date=finding.date)

to
eps, created = Endpoint_Status.objects.get_or_create(
    finding=finding,
    endpoint=ep)
if created:
    eps.date = finding.date

I added also migration, the test of migration and I disabled the old migration tests. Any future changes of code should not affect these tests and they are quite slow. Disabling should not bring any problem and it should speed up unittesting.
TODO:

[x] unittest

This of code
        ep = None
        try:
            ep, created = endpoint_get_or_create(...)
        except (MultipleObjectsReturned):
            pass

        eps = None
        try:
            eps, created = Endpoint_Status.objects.get_or_create(...)
        except (MultipleObjectsReturned):
            pass

has been in DD for a really long time. It doesn't follow best practices.
I suppose we did a lot of improvements (migrations and processing of endpoints) which should avoid situations when this can ever happen. So I'm going to finally remove it.
Please report it as a bug and feel free to assign it directly to me if you will ever receive MultipleObjectsReturned in this part of the code.

 ep = None
        try:
            ep, created = endpoint_get_or_create(...)
        except (MultipleObjectsReturned):
            pass

Instead of pass, we could maybe add some "self healing" code that merges all the endpoints / statuses into one?
For the rest of the PR:

Is there a test case for reimport that covers the fixed behaviour? i.e. endpoint_statuses with different dates (no longer) being created?
Could you look at skipping the migration test usings @skip or similar instead of commenting it out?

 ep = None
        try:
            ep, created = endpoint_get_or_create(...)
        except (MultipleObjectsReturned):
            pass

Instead of pass, we could maybe add some "self healing" code that merges all the endpoints / statuses into one?
For the rest of the PR:
* Is there a test case for reimport that covers the fixed behaviour? i.e. endpoint_statuses with different dates (no longer) being created?

* Could you look at skipping the migration test usings `@skip` or similar instead of commenting it out?

@valentijnscholten, good idea, thanks.
I will implement a "self-healing" code.
Tests are in todo list.

@valentijnscholten, do I need to implement migration if I will implement self-healing? There will be the same piece of code.

@valentijnscholten, I added
        constraints = [
            models.UniqueConstraint(fields=['finding', 'endpoint'], name='endpoint-finding relation')
        ]

I suppose, there will be no change for MultipleObjectsReturned

Thanks @kiblik for all the work. I think it looks OK, but there is of course some risk that the migration will fail to add the unique constraint. And we might run into exceptions where duplicate endpoints or endpoint statuses are created. So I think we would need someone to test it on real life data soon if we want to include it in the release next week.

Thanks @kiblik for all the work. I think it looks OK, but there is of course some risk that the migration will fail to add the unique constraint. And we might run into exceptions where duplicate endpoints or endpoint statuses are created. So I think we would need someone to test it on real life data soon if we want to include it in the release next week. @Maffooch are you able to test this branch maybe on a copy of some real life data? I myself am not using endpoints (yet).

No problem, I will wait for the test.

@valentijnscholten, so can I remove this?
try:
    ...
except (MultipleObjectsReturned):
    ...

I think so as the new unique constraint should  assure there is at most 1 matching row.

I would recommend testing with the sample data dataset https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/fixtures/defect_dojo_sample_data.json and using the management command to create the statuses (assuming they are not already there) https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/management/commands/create_endpoint_status.py

I think the real hair would be in testing with real life data as that might contain the duplicate rows that are too be fixed by this PR. The sample data will already be correct by itself so won't trigger the important code paths.

Ouu, PATCH and PUT need to be fixed and tested as well


Change the way to handle coverage

Properly enable compose cache
Better name jobs
Use alpine version of rabbitmq
change the way to handle coverage (and remove one job)

Coverage remained the same at 97.192% when pulling 7d0129ba20ba4cf26db974a51fc97a95df69f834 on fix/change-coverage-ga into 5c2493abbeaeeca2dafb91cc6ca548298438cc13 on master.


pumpjack cranks sometimes render pitch black without using shaders

to reproduce:

install create
install any version of Create: Diesel Generators, even the forge version
create a superflat world
place down one or multiple pumpjack cranks
at least some of them will probably render completely black

at least on an amd gpu.

this is circumvented by using iris shaders, so it's most definitely a lighting issue


3.5.8 下 tooltip 的 follow : false 未生效

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
https://antv.alipay.com/zh-cn/g2/3.x/demo/component/tooltip-fixed-position.html#
Steps to reproduce
g2 的链接改成：
https://gw.alipayobjects.com/os/antv/assets/g2/3.5.8/g2.min.js
What is expected?
follow: false 时固定不动
What is actually happening?
样式发生了改变， position 变成了 absolute

Environment
Info

g2
3.5.8

System
任意

Browser
chrome

3.5.9-beta.2 已经修复


Adds an option to use StubRunner from classpath

without this change there's no option to use Stub Runner to pick stubs from classpath
with this change we're adding that option. It's enough for the user not to provide netiher the repositoryRoot nor workOffline. If that's the case then Classpath scanning will take place.
fixes #282

Codecov Report

Merging #284 into master will decrease coverage by 0.77%.
The diff coverage is 3.96%.

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
- Coverage      58.6%   57.82%   -0.78%
- Complexity     1552     1556       +4
============================================
  Files           220      221       +1
  Lines          6510     6608      +98
  Branches        857      870      +13
============================================
+ Hits           3815     3821       +6
- Misses         2214     2305      +91
- Partials        481      482       +1

Impacted Files
Coverage Δ
Complexity Δ

...oud/contract/stubrunner/ClasspathStubProvider.java
0% <0%> (ø)
0 <0> (?)

...tract/maven/verifier/MavenContractsDownloader.java
64.15% <0%> (-2.52%)
10 <0> (ø)

...act/stubrunner/spring/StubRunnerConfiguration.java
83.87% <0%> (ø)
6 <0> (ø)
:arrow_down:

.../verifier/messaging/stream/StreamStubMessages.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ud/contract/stubrunner/BatchStubRunnerFactory.java
73.33% <100%> (+6.66%)
4 <0> (ø)
:arrow_down:

...ract/stubrunner/StubDownloaderBuilderProvider.java
50% <33.33%> (-21.43%)
5 <2> (+2)

...k/cloud/contract/stubrunner/StubRunnerOptions.java
82.35% <0%> (+5.88%)
10% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea4ecc...de80f4f. Read the comment docs.


CPU-mode not supported?

Under the assumption that I can try out Unicorn with some pre-trained models, I tried to install it on a Mac and a PC, both w/o nVidia GPU. In step 3 when executing bash make.sh, setup.py is called which is testing for torch.cuda.is_available() and is raising an exception if the function returns false. So running in CPU-mode is not foreseen?

Hi, Unicorn uses Deformable Attention for feature interaction. Unfortunately, this operation is not supported to run on the CPU for now.


Error (Xcode): ../../../.pub-cache/hosted/pub.dev/pinput-2.2.17/lib/src/pinput_state.dart:339:14: Error: The method 'FocusTrapArea' isn't defined for the class '_PinputState'.

Error (Xcode): ../../../.pub-cache/hosted/pub.dev/pinput-2.2.17/lib/src/pinput_state.dart:339:14: Error: The method 'FocusTrapArea' isn't defined for the class '_PinputState'.

Duplicate of https://github.com/Tkko/Flutter_Pinput/issues/98


Update api

use shecodes api

close with no changes - location information is less specific for current location (i.e city for 'pensford is bath and ne somerset)


Undefined is not an object

I just updated to the newest version of react-native-icons, and am running react-native v 0.8.0.
Code that was previously working is no longer. Specifically, TouchableHighlights of the icons present an error, whereas a <Text> equivalent works.
Here is the error:
undefined is not an object (evaluating 'this.refs[ICON_REF].setNativeProps')

setNativeProps
SMXIconImage.ios.js:39

_showUnderlay
TouchableHighlight.js:185

...

and here is my code:
            <View style={styles.footerNav}>
            <TouchableHighlight onPress={this.goToCamera}>
              <Icon
                name='fontawesome|camera'
                size={32}
                color='white'
                style={styles.icon}
                />
            </TouchableHighlight>
            <TouchableHighlight onPress={this.goToSearch}>
              <Icon
                name='fontawesome|plus'
                size={40}
                color='white'
                style={styles.icon}
                />
            </TouchableHighlight>
            <TouchableHighlight onPress={this.goToAddWeight}>
              <Icon
                name='fontawesome|balance-scale'
                size={38}
                color='white'
                style={styles.icon}
                />
            </TouchableHighlight>
            </View>

Any ideas? Thanks a lot!

@wheycool I've just fixed this and published v0.3.4 to NPM

Nice work – thanks a lot!


Sushiswap - part 1

Support 100+ pairs / tokens, periodically updated list, and swapping from ONE to tokens and tokens to ONE. Token to token will come in  part 2.
For testing purposes, tokens to ONE is temporarily disabled.

Looks good. Issues: tokens don’t auto transfer to new wallet after upgrade, because purchasing or swapping tokens on SushiSwap don't cause the tokens to be "tracked" on 1wallet. Only spending those tokens inside 1wallet would track the tokens on the 1wallet smart contract. However, since the new wallet (post-upgrade) can ask the old wallet to transfer the tokens to new wallet, and several functions were designed to do exactly that (partly to deal with this potential pitfall), we can leave this problem to be solved later.

Another issue is daily limit on the 1wallet contract does not restrict the amount of ONE sent via contract call right now.  I will make another majorVersion upgrade (v11) to fix that, before deploying and make Swap available to everyone in production.


feat(core): switch database to Redb

Motivation

Description

Closes #738

In the storage module we have tests that run the full test suite against the different engine implementations, we should add one for redb too. We just need to add this test:
#[test]
    fn test_redb_store() {
        test_store_suite(EngineType::Redb);
    }

Nice!, added the test here 404f388


[RFC] Sealer delpoy dragonfly plugin

This means let sealer delpoy dragonfly, or make sealer's image distribution use dragonfly? I think they are quite different? @gaius-qi

I have separated two issues:

https://github.com/dragonflyoss/Dragonfly2/issues/1301
https://github.com/dragonflyoss/Dragonfly2/issues/1307


Adjust bricks with change in heights of bricks, dynamically.

I am using angular-masonry .is it possible to push down the brick, if above brick height increased?

Were you able to fix this? I'm stuck with the same issue

@vmontazeri , Whenever the layout needs to be refreshed, call $scope.$broadcast('masonry.reload');
Thats how i managed this task..

Thanks! It worked.


Enhance Clip_Score to calculate similarities between same modalities [WIP]

What does this PR do?
Fixes https://github.com/Lightning-AI/torchmetrics/issues/2865

Before submitting

[x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--2875.org.readthedocs.build/en/2875/

@Borda @SkafteNicki Kindly share your feedback on this implementation whenever possible. Thank you


[3.0.0] Error trying to add class or race

Foundry: 315
DnD5e: 3.0.0
Modules active: 0
(It's a new installation)
Edit:
Chrome
Version 120.0.6099.227 (Official Build) (64-bit)

Firefox
115.6.0esr

When I create an actor and try to drag and drop class or race to the actor sheet, I can go through the steps however when I click on complete i'm getting the error below:
Uncaught DOMException: Element.querySelectorAll: '.items-section:has(.item-list .item:not([hidden]))' is not a valid selector
    _applyFilters item-list-controls.mjs:264
    _applyGrouping item-list-controls.mjs:286
    connectedCallback item-list-controls.mjs:22
    jQuery 6
    _replaceHTML foundry.js:5991
    _render foundry.js:5822
    _render foundry.js:6532
    _render character-sheet-2.mjs:161
    render foundry.js:5769
    render foundry.js:7111
    render foundry.js:14259
    _onUpdate foundry.js:14363
    _onUpdate foundry.js:19131
    _onUpdate document.mjs:98
    _onUpdate actor.mjs:3005
    callback foundry.js:13737
    documents foundry.js:13711
    #handleUpdateDocuments foundry.js:13711
    _updateDocuments foundry.js:13458
    update commons.js:8677
    updateDocuments commons.js:8001
    update commons.js:8098
    _complete advancement-manager.mjs:680
    _forward advancement-manager.mjs:572
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464
    render foundry.js:5769
    render advancement-manager.mjs:457
    _forward advancement-manager.mjs:571
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464

If i keep clicking on continue I get this error:
Uncaught (in promise) TypeError: this.step is null
    _forward advancement-manager.mjs:540
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464
    render foundry.js:5769
    render advancement-manager.mjs:457
    _forward advancement-manager.mjs:571
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464
    render foundry.js:5769
    render advancement-manager.mjs:457
    _forward advancement-manager.mjs:571
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464
    render foundry.js:5769
    render advancement-manager.mjs:457
    _forward advancement-manager.mjs:571
    activateListeners advancement-manager.mjs:493
    jQuery 9
    activateListeners advancement-manager.mjs:479
    _render foundry.js:5842
    _render advancement-manager.mjs:464

Chrome
Version 120.0.6099.227 (Official Build) (64-bit)
Firefox
115.6.0esr

another issue, probably same root cause. When I try to import the compendium to the world
foundry.js:68326 Cannot read properties of undefined (reading 'length')
fetch @ foundry.js:68326
advancement-manager.mjs:695 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'length')
    at Preprocessor.advance (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/preprocessor.js:138:35)
    at Tokenizer._consume (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:270:34)
    at Tokenizer._runParsingLoop (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:221:29)
    at Tokenizer.write (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:248:14)
    at parseFragment (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/index.js:42:22)
    at cleanHTML (/home/ubuntu/foundryvtt/resources/app/dist/database/validators.mjs:1:209)
    at HTMLField.sanitizeHTMLField [as sanitize] (/home/ubuntu/foundryvtt/resources/app/dist/database/sanitization.mjs:1:1235)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7729)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7956)
    at Item.sanitizeUserInput (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7436)
3advancement-manager.mjs:540 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'flow')
    at AdvancementManager._forward (advancement-manager.mjs:540:32)
    at HTMLButtonElement.<anonymous> (advancement-manager.mjs:493:25)
    at HTMLButtonElement.dispatch (jquery.min.js:2:43184)
    at y.handle (jquery.min.js:2:41168)
foundry.js:68326 Cannot read properties of undefined (reading 'length')
fetch @ foundry.js:68326
items-collection.mjs:28 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'length')
    at Preprocessor.advance (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/preprocessor.js:138:35)
    at Tokenizer._consume (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:270:34)
    at Tokenizer._runParsingLoop (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:221:29)
    at Tokenizer.write (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:248:14)
    at parseFragment (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/index.js:42:22)
    at cleanHTML (/home/ubuntu/foundryvtt/resources/app/dist/database/validators.mjs:1:209)
    at HTMLField.sanitizeHTMLField [as sanitize] (/home/ubuntu/foundryvtt/resources/app/dist/database/sanitization.mjs:1:1235)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7729)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7956)
    at Item.sanitizeUserInput (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7436)
foundry.js:68326 Cannot read properties of undefined (reading 'length')
fetch @ foundry.js:68326
game:1 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'length')
    at Preprocessor.advance (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/preprocessor.js:138:35)
    at Tokenizer._consume (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:270:34)
    at Tokenizer._runParsingLoop (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:221:29)
    at Tokenizer.write (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/tokenizer/index.js:248:14)
    at parseFragment (/home/ubuntu/foundryvtt/resources/app/node_modules/parse5/dist/index.js:42:22)
    at cleanHTML (/home/ubuntu/foundryvtt/resources/app/dist/database/validators.mjs:1:209)
    at HTMLField.sanitizeHTMLField [as sanitize] (/home/ubuntu/foundryvtt/resources/app/dist/database/sanitization.mjs:1:1235)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7729)
    at Item._sanitizeFields (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7956)
    at Item.sanitizeUserInput (/home/ubuntu/foundryvtt/resources/app/dist/database/backend/server-document.mjs:1:7436)

I was getting the same error. FWIW, I was able to "fix" it by deleting the world, uninstalling the dnd system, restarting my foundry server, reinstalling dnd5e, and making a new world.

@mrcomac The second issue is almost certainly because you need to update the version of Node. V11 requires at least Node 18 and throws errors like that if it is running on an older version.

Hi @arbron
node version is v18.19.0
As mentioned by @hardythedrummer, I just restarted the server and it is working now :) .
Thank you guys


Align how http proxies are handled when fetching gpg keys for download verification

I noticed while trying to run a dev-container setup behind a corporate proxy that git-lfs was getting stuck waiting for gpg keys.
It downloads the collateral file from, mostly, github and then checks to make sure the hashes match up with what is expected. Due to how the proxy was being handled through the install scripts it would either failure to download the collateral (http proxy not correctly setup in container environment) or would fail to verify the collateral (http proxy setup correctly, but gpg not being passed proxy values).
To solve this I went through and aligned all of the features which use gpg checking with how the python feature does it.
I also removed the httpProxy parameter from the features which had it as anyone using it would have already had to have had the proxy correctly setup in order to download the collateral initially. I was one the fence about this change and would remove it if it is deemed no backwards compatible. I didn't see any documentation on how this type of removal should be handled.
Affected features:
git-lfs
git
github-cli
kubectl-helm-minikube
python
ruby
terraform

Thanks for your PR, I came to the same conclusion and it avoids duplicate work.


nit: renaming utxo.account to utxo.address

can we call the optional persistent address field of a utxo address instead of account?
we'd be using address in the client & program, which will then also be consistent with the naming of the uncompressed equivalent in the new web3js Account.address type

Done!


Commit message from COMMIT_EDITMSG not saving

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.2 (Universal)
OS Version: macOS Monterey 12.3

Steps to Reproduce:

Set VS code to core editor for git git config --global core.editor code
Make a change to project and add to commit
git commit in terminal which opens VS code COMMIT_EDITMSG
Type commit message, save and close COMMIT_EDITMSG

What happens:

git status in the terminal shows the file has not been committed
git log has no record of the commit

Oh I fixed it. I had tried git config --global core.editor code --wait and git config --global core.editor "code --wait" but neither of these worked. However, going into the config file itself and manually setting editor = code --wait has done the trick.


bug in alphanumeric of additional methods

Letters, numbers, spaces or underscores only. However, a string containing spaces cannot pass validation .
The regular expression /^\w+$/ should be /^[\w\s]+$/

Agreed. The message says that spaces are allowed, so they should be.
test("alphanumeric", function() {
var method = methodTest("alphanumeric");
ok( method( "123" ), "Valid digits" );
ok( method( "abc" ), "Valid letters" );
ok( method( "ab_ c" ), "Valid underscores and spaces" );
ok(!method( "A23.0.0,0" ), "Invalid punctuation" );
});


WIP: Use longer hash from the result of the fetch

Working on using longer hashes. This seems to provide hashes from the nix-prefetch-git, but i'm new to this codebase so I have no idea what else i'm breaking.
Fixes #29 (in progress)

Then this change in nixpkgs seems to make the system work:
diff --git a/pkgs/development/go-packages/generic/default.nix b/pkgs/development/go-packages/generic/default.nix
index 2de234c9a1e..e710ee04ab5 100644
--- a/pkgs/development/go-packages/generic/default.nix
+++ b/pkgs/development/go-packages/generic/default.nix
@@ -49,8 +49,8 @@ let
     {
       inherit (goDep) goPackagePath;
       src = if goDep.fetch.type == "git" then
-        fetchgit {
-          inherit (goDep.fetch) url rev sha256;
+        builtins.fetchGit {
+          inherit (goDep.fetch) url rev ;
         }
       else if goDep.fetch.type == "hg" then
         fetchhg {

Relevant: https://github.com/NixOS/nix/pull/3408

@tomberek Is this still required after the recent changes?


Updated : Automorphic number and Kaprekar number in C

Have you read the Contributing Guidelines on Pull Requests?
Yes.
Description
I have added 2  updated programs in C on Automorphic number and Kaprekar number as assigned by @shraddhavp and i have made a separate PR as told by @yashaswibiyahut
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Related Issue: #1643
Related PR: #1657

@Tausif121  please add time complexities for the programs added

@Tausif121 please add time complexities for the programs added

@shraddhavp , Time complexity added for both the programs.

@Tausif121 Add your program link in C/README.md not in C/math/README.md . Also, format your code using code formatter.

@iamrajiv  Now i have updated C/README.md and also formatted my 2 prorams using code editor.
sorry for the mistake, this is my first code contribution

@iamrajiv , so sorry I just realised my mistake and thank you for helping.

@all-contributors please add @Tausif121 for code


Client cleanups

I would have rather you left these comments on the original PR. I've already tagged 0.2.0.

wah wah

for posterity: I mentioned consolidating the clients in the other PR.  The want of a variadic Get didn't emerge til I wrote this...  Cleanups are of the lowest priority, tagging a version is irrelevant WRT to this.

LGTM

The reason I brought up the tagging was because I generally like to ship the latest code in the OS; regardless of what the changes are.

You might want to re-evaluate that approach, because cleanups are basically 100% risk with 0% end-user benefit.

Then why are you doing the clean-up in the first place?

More maintainable/easier to read code, of course, why do any cleanup or refactor?  It's to make our lives easier.  End-user impact is realiezd in the long-term, and generally harmful in the short-term.  You know this.

I agree. But why wouldn't you want to includes those changes in the original PR and in the latest release? You are arguing that we shouldn't ship the latest code because it is high risk, but it's only high risk because you made the changes in two passes.


[Android] Add download mode support in XWalkActivityDelegate

Insert a meta-data named "xwalk_enable_download_mode" to AndroidManifest
to enable download mode.
Related to XWALK-5121

@lincsoon @halton Please take a look, Thanks!

I will leave the code review to @lincsoon
Do we have JIRA number related? If so, please add in git log, related to or BUG=

@halton No, this is a sub feature implementation of the download mode feature. Should we create JIRAs for all sub features of a big feature?

If you have download mode JIRA, you can mark this PR as Related to XWALK-xxx, that is what I meant.

ping @lincsoon

A few more questions:

Should we provide a interface to let user cancel the background update in XWalkActivity?
It's okay that download mode and other modes share same complete command. But in other modes, if the update failed, the user will get UI promption. How to deal with this situration in download mode?
XWalkActivity is a one-stop solution that doesn't need more interaction with the developers, and it clearly conflict the principle of download mode. So is it necessary to let XWalkActivity support download mode?

Should we provide a interface to let user cancel the background update in XWalkActivity?

Won't provide such a API. for more fine grain control, developer should use XWalkInitializer/XWalkUpdate instead.

It's okay that download mode and other modes share same complete command. But in other modes, if the update failed, the user will get UI promption. How to deal with this situration in download mode?

could be showing a toast and then quit by default.

XWalkActivity is a one-stop solution that doesn't need more interaction with the developers, and it clearly conflict the principle of download mode. So is it necessary to let XWalkActivity support download mode?

The primary purpose of making XWalkActivity support download mode is to make Web App packaging with make_apk.py support download mode.

I suspect whether the onXWalkUpdateProgress interface in XWalkActivity is necessary, as you said, the developers can use XWalkInitializer if they want more control.
On the other hand, we need to provide the interface for handling failed error. Because it's background download, we must keep all silent instead of showing something in foreground.

I think cancel command and complete command are necessary for shared mode, and failed command and complete command are necessary for download mode. There's no need to add extra listener to XWalkActivityDelegate

Moved all changes to XWalkActivityDelegate to support download mode, for update failed case, showing a Toast to notify "Crosswal Runtime Update failed" and then call cancel command to quit.

@lincsoon

@lincsoon

LGTM