How to upgrade

Hi.
I see there is a new version now.
How do I upgrade to this new version without breaking existing installation?
Thanks

@GD-Dal If you didn't make any modifications to the code you should just be able to pull the latest version as no DB changes took place.  Note, you'll need to remove the initial installer.php and installer.inc.php file that will re-install when you pull the latest version.

Thanks, but how do I remove 2 files from a pull?

I'd just manually remove them after you pull the code down.

I did a pull, and now the site isn't working.
It just displays a lot of text:
set_encryptionKey($encryptionKey); //START-[DO NOT REMOVE] - EMPTIES/REMOVES ENCRYTION KEY/DB PASSWORD VARIABLE $encryptionKey = ""; $dbPassword = ""; unset($encryptionKey); unset($dbPassword); //END-[DO NOT REMOVE] - EMPTIES/REMOVES ENCRYTION KEY/DB PASSWORD VARIABLE //START-[DO NOT REMOVE] - REMOVES PASSWORD FROM $_POST $inputPassword = (isset($_POST['inputPassword'])) ? $_POST['inputPassword'] : ''; unset($_POST["inputPassword"]); //END-[DO NOT REMOVE] - REMOVES PASSWORD FROM $_POST //System Sid Variable $systemSID = $baseSid."-".$orgSid."-".$systemSid; $sanitizedInput = sanitizeGetModuleInput($subModuleRegEx); //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:SUCCESS;ACTION:ADMINLOGIN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); if($sanitizedInput["inputUsername"] != "" && $inputPassword != "" && is_numeric($sanitizedInput["authDirectory"])){ if($sanitizedInput['authDirectory'] == "0"){ if($ipskISEDB->authenticateInternalUser($sanitizedInput["inputUsername"], $inputPassword)){ $authorizedGroups = $ipskISEDB->getPortalAdminGroups(); //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:SUCCESS;ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); if($authorizedGroups['count'] > 0){ for($count = 0; $count < $authorizedGroups['count']; $count++){ for($userCount = 0; $userCount < $_SESSION['memberOf']['count']; $userCount++){ if($authorizedGroups[$count] == $_SESSION['memberOf'][$userCount]){ $_SESSION['authorizationGroup'] = $authorizedGroups[$count]; $_SESSION['authorizationGranted'] = true; $_SESSION['authorizationTimestamp'] = time(); //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:SUCCESS;ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); $ipskISEDB->addUserCacheEntry($_SESSION['logonSID'],$_SESSION['userPrincipalName'],$_SESSION['sAMAccountName'],$_SESSION['logonDN'], $systemSID); header("Location: /adminportal.php"); die(); } } } //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{1}[user_authz_failure];ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=1"); }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{2}[no_authz_groups];ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=2"); } }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{3}[user_authn_failure];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=3"); } }else{ if(is_numeric($sanitizedInput["authDirectory"])){ if($ipskISEDB->getLdapDirectoryCount() > 0){ $ldapCreds = $ipskISEDB->getLdapSettings($sanitizedInput["authDirectory"]); if($ldapCreds){ $ldapClass = New BaseLDAPInterface($ldapCreds['adServer'], $ldapCreds['adDomain'], $ldapCreds['adUsername'], $ldapCreds['adPassword'], $ldapCreds['adBaseDN'], $ldapCreds['adSecure'], $ipskISEDB); //START-[DO NOT REMOVE] - REMOVES PASSWORD FROM $ldapCreds unset($ldapCreds['adPassword']); //END-[DO NOT REMOVE] - REMOVES PASSWORD FROM $ldapCreds $authorizedGroups = $ipskISEDB->getPortalAdminGroups(); $validUser = $ldapClass->authenticateUser($sanitizedInput["inputUsername"], $inputPassword); if($validUser){ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("ldapCreds"=>$ldapCreds), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:SUCCESS;ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); if($authorizedGroups['count'] > 0){ for($count = 0; $count < $authorizedGroups['count']; $count++){ for($userCount = 0; $userCount < $_SESSION['memberOf']['count']; $userCount++){ if($authorizedGroups[$count] == $_SESSION['memberOf'][$userCount]){ $_SESSION['authorizationGroup'] = $authorizedGroups[$count]; $_SESSION['authorizationGranted'] = true; $_SESSION['authorizationTimestamp'] = time(); //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("ldapCreds"=>$ldapCreds), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:SUCCESS;ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); $ipskISEDB->addUserCacheEntry($_SESSION['logonSID'],$_SESSION['userPrincipalName'],$_SESSION['sAMAccountName'],$_SESSION['logonDN'], $systemSID); header("Location: /adminportal.php"); die(); } } } //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("ldapCreds"=>$ldapCreds), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{1}[user_authz_failure];ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";".$authorizedGroups['count'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=1"); }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("ldapCreds"=>$ldapCreds), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{2}[no_authz_groups];ACTION:ADMINAUTHZ;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=2"); } }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("authorizedGroups"=>$authorizedGroups), Array("ldapCreds"=>$ldapCreds), Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{3}[user_authn_failure];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=3"); } }else{ //START-[DO NOT REMOVE] - REMOVES PASSWORD FROM $ldapCreds unset($ldapCreds['adPassword']); //END-[DO NOT REMOVE] - REMOVES PASSWORD FROM $ldapCreds //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{4}[invalid_ldap_directory];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=4"); } }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{5}[no_valid_auth_directories];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=5"); } }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{6}[invalid_auth_directory_input];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=6"); } } }else{ //LOG::Entry $logData = $ipskISEDB->generateLogData(Array("sanitizedInput"=>$sanitizedInput)); $logMessage = "REQUEST:FAILURE{7}[invalid_form_input];ACTION:ADMINAUTHN;USERNAME:".$sanitizedInput["inputUsername"].";AUTHDIRECTORY:".$sanitizedInput['authDirectory'].";"; $ipskISEDB->addLogEntry($logMessage, __FILE__, __FUNCTION__, __CLASS__, __METHOD__, __LINE__, $logData); header("Location: /index.php?error=7"); } ?>
Is there something else that needs to be done?

That looks like what would happen if your web server wasn't set to render php files properly.  Just moving files shouldn't have impacted anything with your web config.  Are you able to look at the web config?

I think something went really bad when Ubuntu was upgraded from v20 to v22
Where is the web config located?

I renamed the IPSK-manager directory and did a new git clone.
This is how the login page looks like now:

I assume you're using apache as the web server?  Should be in like /etc/apache2 directory.   You should look to make sure the PHP module is being loaded and not commented out.

Yeah, it seems that PHP does not work on the server anymore.
I have tried several guides on how to uninstall / purge apache2 and php, but nothing works.
Probably have to reinstall the server it seems

FINALLY got it to work.
I noticed that php8.3 was in /etc/apache2/mods-available but not int /etc/apache2/mods-enabled
So I manually created 2 symlinks:
sudo ln -s /etc/apache2/mods-available/php8.3.conf /etc/apache2/mods-enabled/
sudo ln -s /etc/apache2/mods-available/php8.3.load /etc/apache2/mods-enabled/
and ran sudo service apache2 restart
Which gave me the error:
apachectl[1807]: [Wed Nov 29 13:48:27.603178 2023] [php:crit] [pid 1807:tid<PHONE_NUMBER>64288] Apache is running a threaded MPM, but your PHP Module is not compiled to be threadsafe.  You need to recompile PHP.
So after some searching on the internet, I did:
sudo a2dismod mpm_event
sudo a2enmod mpm_prefork
sudo service apache2 restart
And now it seems to work with Ubuntu 22.04 and PHP 8.3 :)

Good to hear, I'm going to close this issue then :)


Can not compile it even with "Any CPU"

I'm talking about msbuild
I've added the rtmp-sharp library and removed the XMPP string from the solution
Are you still working on it?
I just want to play around with it (:

Here's an update:
I'm missing the file
\packages\System.Data.SQLite.Core.<IP_ADDRESS>\build\net45\System.Data.SQLite.Core.targets
What am I supposed todo?

Update 2:
Now I got the files: https://www.nuget.org/packages/System.Data.SQLite.Core/1.0.94
Extracted to the package folder
And renamed it to <IP_ADDRESS>
Now the compiler clearly detects it but I still get that error..

I've managed to make it work! (after 6 hours lmao)
If someone in the future needs help just send me a message


Synchronize user role retrieval from DB and adding it to user role cache

Purpose
This PR introduces thread synchronization to the process of 'user role retrieval from DB and adding it to user role cache' to avoid multiple threads querying the user roles from DB for the same user concurrently, and update the user role cache with the same value retrieved from DB concurrently.
Resolves : https://github.com/wso2/product-is/issues/10869

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/493905882

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/493905882


Constants from DataObject

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #852.
What are the significant changes in functionality due to this change request?
Adds the ability to take values for "constants" in a Sampler from a DataObject.
To do this, the user must specify a "ConstantSource" Assembler object with a data object, then a constant can be used to pick values from the source. Multiple ConstantSources can be added for any Sampler.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

Checklist passed... Comments addressed...
Merging...


Remove disable-replica-rebuild setting

longhorn/longhorn#4997
This would look cleaner if we followed my suggestion in https://github.com/longhorn/longhorn/issues/5131#issuecomment-1544541401, but there may good reason not to do so. For now, I left a local copy of the setting in upgrade/v120to121/upgrade.go so the project will build.

However, we also need to delete this setting after users upgrade to 1.5.0, so need to cover in 1.4.x -> 1.5 upgrade path. The same we need to do for mkfs-ext4, longhorn/longhorn#4914.

I thought it was a little more maintainable to remove all settings that longhorn-manager no longer has definitions for. I tried the latest commit out on an upgrade from v1.4.2 -> master-head and it removed the two settings we expect (disable-replica-rebuild and mkfs-ext4-parameters). Obviously the upgrade added and changed some settings as well.
eweber@laptop:~/longhorn> diff 1.4.2_before_upgrade master-head_after_upgrade
9a10,11
> backup-compression-method                                         lz4
> backup-concurrent-limit                                           5
18,19c20,21
< current-longhorn-version                                          v1.4.2
< default-backing-image-manager-image                               longhornio/backing-image-manager:v1.4.2
---
> current-longhorn-version                                          v1.5.0-dev
> default-backing-image-manager-image                               longhornio/backing-image-manager:master-head
22,23c24,25
< default-engine-image                                              longhornio/longhorn-engine:v1.4.2
< default-instance-manager-image                                    longhornio/longhorn-instance-manager:v1.4.2
---
> default-engine-image                                              longhornio/longhorn-engine:master-head
> default-instance-manager-image                                    longhornio/longhorn-instance-manager:master-head
26c28
< default-share-manager-image                                       longhornio/longhorn-share-manager:v1.4.2
---
> default-share-manager-image                                       longhornio/longhorn-share-manager:master-head
28d29
< disable-replica-rebuild                                           false
35a37
> guaranteed-instance-manager-cpu                                   12
39d40
< mkfs-ext4-parameters
52a54
> restore-concurrent-limit                                          5
60a63
> storage-reserved-percentage-for-default-disk                      30

I can certainly do it instead in the 1.4.x -> 1.5.0 upgrade path if you prefer. Copying @derekbit, since he most recently refactored the upgrading.


Adding row in edit data messes up the table

Azure Data Studio Version: 1.26 RC1

Steps to Reproduce:

Right click on a table in data explorer
Click on Edit data
Add a table row (tab through cells while entering the data)

Data Entered in Edit Data:

Data Actually Displayed in Table:

Seems to be a regression. Moving it to February milestone.

Tried running the Edit Data command on an existing table, and it does not work.  I put more data and hit Run, but it doesn't show up when I query the DB.

@cssuh Hitting run doesn't do anything for Edit Data at the moment, its only meant to edit the data as with SSMS. The results table will show up when you query the top 1000 results.

moving to backlog as it cannot be reproduced

@aasimkhan30 if this can no longer be reproduced should we close the issue?


Resilient journal

@aaudiber @gpang
This PR is still in progress. Will keep you updated. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17535/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17918/
Test PASSed.

Merged build finished. Test PASSed.

@aaudiber
This PR implements the feature "resilient journal" that allows Alluxio to recover from HDFS datanode failures. Could you PTAL? Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17932/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17955/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17963/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18009/Build result: FAILURE[...truncated 1805 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.7.0-SNAPSHOT/alluxio-keyvalue-common-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.7.0-SNAPSHOT/alluxio-keyvalue-common-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.7.0-SNAPSHOT/alluxio-core-server-worker-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.7.0-SNAPSHOT/alluxio-logserver-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.7.0-SNAPSHOT/alluxio-core-client-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.7.0-SNAPSHOT/alluxio-core-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.7.0-SNAPSHOT/alluxio-core-server-proxy-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.7.0-SNAPSHOT/alluxio-tests-1.7.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18012/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18024/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18026/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18027/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18033/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18048/
Test PASSed.

@aaudiber
Could you PTAL? Thanks!

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18050/Failed Tests: 1org.alluxio:alluxio-core-common: 1alluxio.underfs.options.OpenOptionsTest.equalsTest
Test FAILed.

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18065/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18067/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18070/Build result: FAILURE[...truncated 1772 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.7.0-SNAPSHOT/alluxio-keyvalue-common-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.7.0-SNAPSHOT/alluxio-keyvalue-common-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.7.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.7.0-SNAPSHOT/alluxio-core-client-fs-1.7.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.7.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.7.0-SNAPSHOT/alluxio-core-common-1.7.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.7.0-SNAPSHOT/alluxio-core-server-worker-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.7.0-SNAPSHOT/alluxio-logserver-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.7.0-SNAPSHOT/alluxio-core-client-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.7.0-SNAPSHOT/alluxio-examples-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.7.0-SNAPSHOT/alluxio-core-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.7.0-SNAPSHOT/alluxio-core-server-proxy-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.7.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.7.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.7.0-SNAPSHOT/alluxio-shell-1.7.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.7.0-SNAPSHOT/alluxio-tests-1.7.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18071/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18072/
Test PASSed.

@aaudiber Can you PTAL? Thanks

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18085/
Test PASSed.


[Bug]: Qwen2.5-Math-RM-72B Online Inference Fails

Your current environment

The output of `python collect_env.py`
Collecting environment information...
PyTorch version: 2.5.1+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.5 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: 14.0.0-1ubuntu1.1
CMake version: Could not collect
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov  6 2024, 20:22:13) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-6.5.0-1025-gcp-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.4.131
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 80GB HBM3
GPU 1: NVIDIA H100 80GB HBM3
GPU 2: NVIDIA H100 80GB HBM3
GPU 3: NVIDIA H100 80GB HBM3
GPU 4: NVIDIA H100 80GB HBM3
GPU 5: NVIDIA H100 80GB HBM3
GPU 6: NVIDIA H100 80GB HBM3
GPU 7: NVIDIA H100 80GB HBM3

Nvidia driver version: 550.90.07
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      52 bits physical, 57 bits virtual
Byte Order:                         Little Endian
CPU(s):                             208
On-line CPU(s) list:                0-207
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Platinum 8481C CPU @ 2.70GHz
CPU family:                         6
Model:                              143
Thread(s) per core:                 2
Core(s) per socket:                 52
Socket(s):                          2
Stepping:                           8
BogoMIPS:                           5399.99
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx_vnni avx512_bf16 arat avx512vbmi umip avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid cldemote movdiri movdir64b fsrm md_clear serialize tsxldtrk amx_bf16 avx512_fp16 amx_tile amx_int8 arch_capabilities
Hypervisor vendor:                  KVM
Virtualization type:                full
L1d cache:                          4.9 MiB (104 instances)
L1i cache:                          3.3 MiB (104 instances)
L2 cache:                           208 MiB (104 instances)
L3 cache:                           210 MiB (2 instances)
NUMA node(s):                       2
NUMA node0 CPU(s):                  0-51,104-155
NUMA node1 CPU(s):                  52-103,156-207
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI Syscall hardening, KVM SW loop
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.4.127
[pip3] nvidia-cuda-nvrtc-cu12==12.4.127
[pip3] nvidia-cuda-runtime-cu12==12.4.127
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-ml-py==12.560.30
[pip3] nvidia-nccl-cu12==2.21.5
[pip3] nvidia-nvjitlink-cu12==12.4.127
[pip3] nvidia-nvtx-cu12==12.4.127
[pip3] pyzmq==26.2.0
[pip3] torch==2.5.1
[pip3] torchvision==0.20.1
[pip3] transformers==4.47.1
[pip3] triton==3.1.0
[conda] Could not collect
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.6.5
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	GPU2	GPU3	GPU4	GPU5	GPU6	GPU7	CPU Affinity	NUMA Affinity	GPU NUMA ID
GPU0	 X 	NV18	NV18	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU1	NV18	 X 	NV18	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU2	NV18	NV18	 X 	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU3	NV18	NV18	NV18	 X 	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU4	NV18	NV18	NV18	NV18	 X 	NV18	NV18	NV18	52-103,156-207	1		N/A
GPU5	NV18	NV18	NV18	NV18	NV18	 X 	NV18	NV18	52-103,156-207	1		N/A
GPU6	NV18	NV18	NV18	NV18	NV18	NV18	 X 	NV18	52-103,156-207	1		N/A
GPU7	NV18	NV18	NV18	NV18	NV18	NV18	NV18	 X 	52-103,156-207	1		N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

CUDA_ROOT=/usr/local/cuda
LD_LIBRARY_PATH=/home/sam_passaglia_elyza_ai/easy-evals/vllm_server/.venv/vllm-server-3fpuUD1n-py3.10/lib/python3.10/site-packages/cv2/../../lib64:/usr/local/cuda/lib64:
CUDA_INC_DIR=/usr/local/cuda/bin:
CUDA_MODULE_LOADING=LAZY

Model Input Dumps
No response
🐛 Describe the bug
Using the example script from the original implementation PR now leads to the following error:
openai.BadRequestError: Error code: 400 - {'object': 'error', 'message': 'pooled_data should b
e a 1-D embedding vector', 'type': 'BadRequestError', 'param': None, 'code': 400}

The error can be traced back to the pooling API refactoring in https://github.com/vllm-project/vllm/pull/11129/
Reward Models usually use AllPool, which usually returns one output per token per prompt as a list[tensor](See also: https://github.com/vllm-project/vllm/pull/10820).
But the EmbeddingOutput dataclass expects pooled_data.ndim = 1 https://github.com/vllm-project/vllm/blob/a491d6f535d96939d17e5290991dc975495c9580/vllm/outputs.py#L407-L408
cc @DarkLight1337
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

This is an intentional change because we should now use LLM.encode() for reward models while LLM.embed() should be used for embedding models (not reward models). Sorry I didn't fully consider online inference since there's no alternative to that yet.

I am not very familiar with the internal structure of VLLM, but since offline inference for reward modeling and embedding follow a different entrypoint (LLM.encode() vs LLM.embed()) and yield a different output type (PoolingRequestOutput vs EmbeddingRequestOutput), then it sounds like the API server should also send RM and embedding requests down a different code path. Does it make sense to have a serving_reward module alongside the existing serving_embedding and serving_score modules?

I'm thinking of setting up a new encode endpoint for this.

Since currently task needs to be specified at server launch time, it might be easier at first to simply overload the embedding endpoint but change the code path based on task

I have added /pooling API in #11457 which should solve this.

@DarkLight1337  Thank you!


Support multiple possible answers

Cool game to learn the CSS grid! Thank you very much for the hard work!
Currently it seems every level have single answer even though their can be multiple answers to achieve the same thing.
ex: I was stuck on 28 even though I had the correct answer. ( grid-template: 1fr 50px / 20% 80%) but the expected answer is grid-template': '1fr 50px / 20% 1fr
Seems others are also facing the same.

Hey @kaushalyap, the game is set up in a way that multiple answers can be marked correct. I tested your answer and it worked for me.
If it's not working for you, can you tell me your operating system and browser?


Ctrl + hover creates a note, it should only create one on Ctrl + Click

Describe the bug
Ctrl + hover creates a note, it should only create one on Ctrl + Click
To Reproduce
Steps to reproduce the behaviour:

Create a note,
Paste an image in it
Hover it while ctrl is pressed
watch the note being created

Expected behavior
Just show the preview of the asset, do not create a note.
Desktop (please complete the following information):

OS: WIN 10
Browser n/a
Version [0.21]

I believe the Doctor command also creates blank notes; whatever the decision is for this issue, I think Doctor 's behaviour should be consistent.

Thanks for the report. Images are great but fake image notes are not. We'll take care of it for the new years release!
@tsnieman as for Doctor, Doctor used to create blank notes but it shouldn't anymore. Let me know if that's not the case

I think this also broke my workflow with the draw.io extension.
Previously i was able to create a link to an non-extisting .dio.png file and following the link, it would open the editor.
Right now, when i CTRL+Click on that link, i get directed to a .dio.png.md file, obviously without the drawio editor loaded.
Example link:  ![](/assets/images/diagram.dio.png)
Ctrl+Click creates: /assets/images/diagram.dio.png.md

I think this also broke my workflow with the draw.io extension.
Previously i was able to create a link to an non-extisting .dio.png file and following the link, it would open the editor.
Right now, when i CTRL+Click on that link, i get directed to a .dio.png.md file, obviously without the drawio editor loaded.
Example link:  ![](/assets/images/diagram.dio.png)
Ctrl+Click creates: /assets/images/diagram.dio.png.md

Would it be possible to make a toggle to disable the feature until you have a final fix? This is getting really tedious to undo the changes on each commit. :cold_sweat:

😉 Thanks in advance

Would it be possible to make a toggle to disable the feature until you have a final fix? This is getting really tedious to undo the changes on each commit. :cold_sweat:

😉 Thanks in advance

Yes! That much I can do!
On Fri, Jan 22, 2021 at 7:45 AM BC<EMAIL_ADDRESS>wrote:

Would it be possible to make a toggle to disable the feature until you
have a final fix? This is getting really tedious to undo the changes on
each commit. 😰
[image: image]
https://user-images.githubusercontent.com/1516035/105512058-ee8b6d80-5cd0-11eb-9146-add53baa2388.png
😉 Thanks in advance
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/430#issuecomment-765497038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADD52IBPJECZMFUSDWWMM3S3GMTJANCNFSM4VMG4ETQ
.

Yes! That much I can do!
On Fri, Jan 22, 2021 at 7:45 AM BC<EMAIL_ADDRESS>wrote:

Would it be possible to make a toggle to disable the feature until you
have a final fix? This is getting really tedious to undo the changes on
each commit. 😰
[image: image]
https://user-images.githubusercontent.com/1516035/105512058-ee8b6d80-5cd0-11eb-9146-add53baa2388.png
😉 Thanks in advance
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/430#issuecomment-765497038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADD52IBPJECZMFUSDWWMM3S3GMTJANCNFSM4VMG4ETQ
.

So turns out the fix to not go to definition was pretty simple. This should be fixed now @generic-user

Thanks, seems to work fine now! 👍

As discussed in discord, looks like this is only mitigated by the setting
<!--configs-->
noAutoCreateOnDefinition: true

More details here:
https://wiki.dendron.so/notes/f83c1d87-eac0-48f3-a5cf-8a69989d8ec1.html#noautocreateondefinition

@kpathakota the section you mentioned is currently partially missing.
I'm also not sure if this is supposed to work for my workflow.
Previously i was able to create a link to an non-extisting .dio.png file and following the link by CTRL+Click, it would create the file and open the editor (draw.io integration).
Example link:
I understood that dendron's behavior has changed and uses it's own "goto note" command now.
But even with that, i'm not able to create a new file when following a link to a non-existing file. I tried so far:

create link to new diagram, e.g.
use the Dendron: goto note command -> note does not exist error
try ctrl+click -> nothing happens
try F12 -> "no definition found" error

is there any way to make my workflow work again? it is cumbersome to manually create empty .dio.png files in the assets folder before linking to them.


question: is valuable expected to work with tracing macros?

I was expecting valuable to work out of the box with tracing's macros (info, debug etc). However, I get an issue saying Value is not implemented for my type (i.e. there is no blanket implementation covering all types that implement Valuable). This currently seems like the only way to make tracing happy:
for (service, old_state) in removed {
    info!(service = &service as &dyn Valuable,"Service unit removed");
    self.service_state.remove(&service);
}

Please let me know if this was an oversight, or if there's a fundamental limitation preventing the compiler from auto-coercing my type (RemoteServiceId) that implements Valuable to Value?

First you need to enable the tracing_unstable rustc flag and the valuable feature in the tracing crate. Ref.
Then you need to call .as_value() on the value before using a tracing macro, e.g.:
tracing::info!(service = service.as_value(), "Service unit removed");


Compilation issue - Linux

When I try to compile FlatUI on Linux I have an issue:
myuser@user:~/dev/sample-jni/flatui$ ndk-build APP_ABI=all
Android NDK: android-10 is unsupported. Using minimum supported version android-14.
[generic] Generate       : jni/libs/src/../../../gen/include/flatui/flatui_generated.h
[generic] Generate       : /usr/local/google/home/dmabin/dev/sample-jni/flatui/jni/libs/freetype/../../../dependencies/flatbuffers/../fplbase/jni/../gen/include/common_generated.h
[generic] Generate       : /usr/local/google/home/dmabin/dev/sample-jni/flatui/jni/libs/freetype/../../../dependencies/flatbuffers/../fplbase/jni/../gen/include/materials_generated.h
[generic] Generate       : /usr/local/google/home/dmabin/dev/sample-jni/flatui/jni/libs/freetype/../../../dependencies/flatbuffers/../fplbase/jni/../gen/include/mesh_generated.h
[generic] Generate       : /usr/local/google/home/dmabin/dev/sample-jni/flatui/jni/libs/freetype/../../../dependencies/flatbuffers/../fplbase/jni/../gen/include/shader_generated.h
[generic] Generate       : /usr/local/google/home/dmabin/dev/sample-jni/flatui/jni/libs/freetype/../../../dependencies/flatbuffers/../fplbase/jni/../gen/include/texture_atlas_generated.h
[arm64-v8a] Compile++      : flatui <= flatui.cpp
[arm64-v8a] Compile++      : flatui <= flatui_common.cpp
[arm64-v8a] Compile++      : flatui <= flatui_serialization.cpp
[arm64-v8a] Compile++      : flatui <= font_buffer.cpp
[arm64-v8a] Compile++      : flatui <= font_manager.cpp
[arm64-v8a] Compile++      : flatui <= font_systemfont.cpp
[arm64-v8a] Compile++      : flatui <= font_util.cpp
[arm64-v8a] Compile++      : flatui <= glyph_cache.cpp
[arm64-v8a] Compile++      : flatui <= hb_complex_font.cpp
[arm64-v8a] Compile++      : flatui <= hyphenator.cpp
[arm64-v8a] Compile++      : flatui <= micro_edit.cpp
[arm64-v8a] Compile++      : flatui <= script_table.cpp
[arm64-v8a] Compile++      : flatui <= version.cpp
[arm64-v8a] StaticLibrary  : libflatui.a
[arm64-v8a] Compile++      : fplbase <= asset_manager.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= gpu_debug_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= input.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= material.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= mesh_common.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= mesh_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= precompiled.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= preprocessor.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= render_target_common.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= render_target_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= renderer_common.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= renderer_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= renderer_hmd_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= shader_common.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= shader_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= texture_common.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= texture_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= type_conversions_gl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= utilities.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= version.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile        : fplbase <= gl3stub.c
[arm64-v8a] Compile++      : fplbase <= async_loader.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= environment_sdl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= input_sdl.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] Compile++      : fplbase <= renderer_android.cpp
warning: unknown warning option '-Wno-literal-suffix'; did you mean '-Wno-literal-range'? [-Wunknown-warning-option]
1 warning generated.
[arm64-v8a] StaticLibrary  : libfplbase.a
[arm64-v8a] Compile++      : fplutil <= android_utils.cpp
error: invalid argument '-std=c99' not allowed with 'C++/ObjC++'
make: *** [obj/local/arm64-v8a/objs/fplutil/src/android_utils.o] Error 1

I'm using the latest ndk r14

When I try using the FPLUtil method I have that error:
user@user:~/dev/sample-jni/flatui$ ./dependencies/fplutil/bin/build_all_android.py
Android NDK: android-10 is unsupported. Using minimum supported version android-14.
Android NDK: WARNING: APP_PLATFORM android-14 is higher than android:minSdkVersion 9 in ./AndroidManifest.xml. NDK binaries will *not* be comptible with devices older than android-14. See https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md for more information.
make: Entering directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/mathfu/unit_tests/vector_test/no_simd'
[armeabi-v7a] Install        : libvector_no_simd_test.so => libs/armeabi-v7a/libvector_no_simd_test.so
[armeabi] Install        : libvector_no_simd_test.so => libs/armeabi/libvector_no_simd_test.so
[x86] Install        : libvector_no_simd_test.so => libs/x86/libvector_no_simd_test.so
[x86_64] Install        : libvector_no_simd_test.so => libs/x86_64/libvector_no_simd_test.so
[mips] Install        : libvector_no_simd_test.so => libs/mips/libvector_no_simd_test.so
[mips64] Install        : libvector_no_simd_test.so => libs/mips64/libvector_no_simd_test.so
make: Leaving directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/mathfu/unit_tests/vector_test/no_simd'
Android NDK: android-10 is unsupported. Using minimum supported version android-14.
make: Entering directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/jni/sdl'
[armeabi] Install        : libSDL2_empty.so => libs/armeabi/libSDL2_empty.so
[armeabi-v7a] Install        : libSDL2_empty.so => libs/armeabi-v7a/libSDL2_empty.so
[mips] Install        : libSDL2_empty.so => libs/mips/libSDL2_empty.so
[x86] Install        : libSDL2_empty.so => libs/x86/libSDL2_empty.so
install -p /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/armeabi/libSDL2_empty.so /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/armeabi/libSDL2.so
install -p /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/armeabi-v7a/libSDL2_empty.so /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/armeabi-v7a/libSDL2.so
[x86_64] Install        : libSDL2_empty.so => libs/x86_64/libSDL2_empty.so
install -p /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/mips/libSDL2_empty.so /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/mips/libSDL2.so
[armeabi] StaticLibrary  : libSDL2.a
install -p /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/x86/libSDL2_empty.so /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/x86/libSDL2.so
[armeabi-v7a] StaticLibrary  : libSDL2.a
[mips] StaticLibrary  : libSDL2.a
install -p /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/x86_64/libSDL2_empty.so /usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/libs/x86_64/libSDL2.so
[x86] StaticLibrary  : libSDL2.a
[x86_64] StaticLibrary  : libSDL2.a
make: Leaving directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplbase/jni/sdl'
Android NDK: android-10 is unsupported. Using minimum supported version android-14.
Android NDK: WARNING: APP_PLATFORM android-14 is higher than android:minSdkVersion 9 in ./AndroidManifest.xml. NDK binaries will *not* be comptible with devices older than android-14. See https://android.googlesource.com/platform/ndk/+/master/docs/user/common_problems.md for more information.
make: Entering directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/mathfu/benchmarks/vector_benchmark/no_simd'
/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/build/core/build-binary.mk:688: Android NDK: Module vector_no_simd_benchmark depends on undefined modules: gtest
/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/build/core/build-binary.mk:701: *** Android NDK: Aborting (set APP_ALLOW_MISSING_DEPS=true to allow missing dependencies)    .  Stop.
make: Leaving directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/mathfu/benchmarks/vector_benchmark/no_simd'
Subprocess returned 2
Caught buildutil error: Error 2 running /usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build as: ['/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build', '-j12', '-C', '/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/mathfu/benchmarks/vector_benchmark/no_simd', 'NDK_OUT=/usr/local/google/home/dmabin/dev/sample-jni/flatui/libs'], stderr: {*not captured*}

After removing the line "libgtest " inside the file android_common.mk in the folder "dependencies/mathfu/benchmarks" I now have the same error as the compilation without fplutils:
[armeabi] Compile++ arm  : flatui <= font_manager.cpp
[armeabi] Compile++ arm  : flatui <= font_systemfont.cpp
[armeabi] Compile++ arm  : flatui <= font_util.cpp
[armeabi] Compile++ arm  : flatui <= glyph_cache.cpp
[armeabi] Compile++ arm  : flatui <= hb_complex_font.cpp
[armeabi] Compile++ arm  : flatui <= hyphenator.cpp
[armeabi] Compile++ arm  : flatui <= micro_edit.cpp
[armeabi] Compile++ arm  : flatui <= script_table.cpp
[armeabi] Compile++ arm  : flatui <= version.cpp
[armeabi] Compile++ arm  : fplutil <= android_utils.cpp
error: invalid argument '-std=c99' not allowed with 'C++/ObjC++'
make: *** [/usr/local/google/home/dmabin/dev/sample-jni/flatui/libs/local/armeabi/objs/fplutil/src/android_utils.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui'
Subprocess returned 2
Caught buildutil error: Error 2 running /usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build as: ['/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build', '-j12', '-C', '/usr/local/google/home/dmabin/dev/sample-jni/flatui', 'NDK_OUT=/usr/local/google/home/dmabin/dev/sample-jni/flatui/libs'], stderr: {*not captured*}

It seems that removing the two mention of -std=99 in the file "Android.mk" under the folder "dependencies/fplutil/jni" helps

I still have that issue:
1 warning generated.
[armeabi-v7a] StaticLibrary  : libgtest.a
[armeabi-v7a] SharedLibrary  : libtest_index_allocator.so
/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/iostream:74: error: undefined reference to 'std::ios_base::Init::Init()'
/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/sources/cxx-stl/gnu-libstdc++/4.9/include/iostream:74: error: undefined reference to 'std::ios_base::Init::~Init()'
/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplutil/libfplutil/src/print_cxx.cc:26: error: undefined reference to 'std::cerr'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [/usr/local/google/home/dmabin/dev/sample-jni/flatui/libs/local/armeabi-v7a/libtest_index_allocator.so] Error 1
make: Leaving directory `/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplutil/libfplutil/unit_tests/test_index_allocator'
Subprocess returned 2
Caught buildutil error: Error 2 running /usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build as: ['/usr/local/google/home/dmabin/Android/Sdk/ndk-bundle/ndk-build', '-j12', '-C', '/usr/local/google/home/dmabin/dev/sample-jni/flatui/dependencies/fplutil/libfplutil/unit_tests/test_index_allocator', 'NDK_OUT=/usr/local/google/home/dmabin/dev/sample-jni/flatui/libs'], stderr: {*not captured*}

I'm not trying to fix it, it seems that libflatui.a was generated. I'll try with that, wish me luck (^_^)


Bump num-traits, num-complex

This is a breaking change since num-complex is a part of ndarray's a public API

@bluss friendly ping

I haven't heard from @bluss in quite a while, so I'm going ahead and merging this.
Thanks @alexbool.


Turn on Bandit CodeClimate plugin

Bandit is a tool designed to find common security issues in Python code.
Turning this on will result in 110 new issues. Mostly around uses of subprocess. Refactoring away from direct calls to subprocess will mitigate most of the issues.

Enabled in c1d5df90ba83646b503062a108bd3d60f25978dd


Fix uses of pickBy

pickBy is being used to remove properties with undefined or null values, but it's being used in a way that zeroes and empty strings are being removed as well.
Example (but there are many others):
https://github.com/OpenZeppelin/openzeppelin-sdk/blob/269f097b368aee7ddfa97cdbc6058a2fc0d746ad/packages/lib/src/utils/Logger.ts#L89
The reason is that the iteratee argument in pickBy has a default value of lodash.identity. The fix is to use pickBy(..., isNil) with isNil = require('lodash.isnil').

isNil returns true for null-like values, so what we actually want is
pickBy(..., x => !isNil(x))


Softening prescription for numerical stability might be wrong

To avoid dividing by very small numbers, a lot of methods in the lens classes do something like this:
th = (x ** 2 + y ** 2).sqrt() + self.s
where self.s is a softening parameter, with typical default of 0.001. This is different than lenstronomy, which does this instead:
th = np.maximum(th, self.s)
Our current approach shifts all radial coordinates by self.s, not just coordinates close to the lens center which would lead to numerical instabilities. This biases our implementation with respect to lenstronomy by a global rescaling of our coordinates.
I suggest that we use torch.maximum(th, self.s) as a safeguard against very small radii.

Some of the lenses like sie have a softening prescription that is analytic as a cored profile. We can look into this for the others. First we'll need to list out which ones this applies to.

One other challenge is that torch.max eliminates autograd


Change FlowFilter values in WebClient

You write
"In FlowFilter fields, a user can enter a filter value via the user interface in the application that will affect the calculation of a FlowField."
For example the "Date Filter" in the Item table has effect on how the "Inventory" Field is calculated.
How a user can do this in the business central web client?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b86d301-cf03-0dd0-abdd-9a73743b4285
Version Independent ID: 4e4d4219-2c2f-0324-6166-414f31158224
Content: Meet Microsoft Dynamics Business Central - Business Central
Content Source: business-central/index.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Closing this issue on behalf of owner, since the misleading wording appears to have been removed. For more information about filtering, see "Sorting, Searching, and Filtering Lists" at https://docs.microsoft.com/en-us/dynamics365/business-central/ui-enter-criteria-filters


FROG-4546

Documentation to Pull Request "Add beta services" by OzanA

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add option to make assembly wait till completion

fixes #28
also please advise on any other assembly statuses that should be regarded as "FINISHED". See here cc @tim-kos @Acconut

In the Go SDK, the wait method is implemented by checking whether the assembly is still uploading/executing instead of testing if it has finished already:
https://github.com/transloadit/go-sdk/blob/19fc9db1b8bd5067f31f8fd9ef4d4f74985a3b5d/wait.go#L24
IIRC, we choose this implementation based on a recommendation by @kvz. Anyways, the advantage is that you don't have to deal with request aborted/assembly error/assembly cancelled statuses and it's more future-proof.

@Acconut I thought there's a state that Assemblies usually are when it is waiting for Tus uploads to begin? I don't remember, but I don't think it is ASSEMBLY_UPLOADING. 🤔

I thought there's a state that Assemblies usually are when it is waiting for Tus uploads to begin? I don't remember, but I don't think it is ASSEMBLY_UPLOADING.

No, there is no such additional status. The only two states an unfinished assembly can in are ASSEMBLY_UPLOADING and ASSEMBLY_EXECUTING. The tus integration was designed to introduce little changes to the SDKs, so we are also using the ASSEMBLY_UPLOADING state for it.

Marius is right. Let's change the implementation here and check for ASSEMBLY_UPLOADING and ASSEMBLY_EXECUTING instead.

Let's change the implementation here and check for ASSEMBLY_UPLOADING and ASSEMBLY_EXECUTING instead.

I have changed as suggested.

@tim-kos @Acconut to merge or not to merge?


Missing license

Could you please select and add a license for this code? (preferably a copy-left license like the GPL-3?)

Added MIT License in b38d00528e3df75f1a75ac3c70958a455fc4feec

Thanks!


Ion-Content/ngIf bug - when using the ion-modal-controller with an ion-content inside the modal, Angular's ngIf directive stops working

Bug Report
https://github.com/Yoobic/stencil-bugs/tree/ion-content-ngIf-bug
Ionic Info
NOTE: from the time this bug was originally reported, they have since updated and are still experiencing this issue
@ionic/cli-utils: 2.0.0-rc.6
ionic (Ionic CLI): 4.0.0-rc.6

System:
- NodeJS: v8.9.4
- npm: 6.1.0
- OS: macOS High Sierra

Bug Description
Version Affected: MOBILE
When using the IonModalController to open a component as a modal, if the component has an ion-content inside of it all the *ngIf statements inside of it break. Any *ngIf controlled code outside the ion-content works as expected. Upon inspecting the DOM the following appears:
Removing the ion-content and replacing it with a <div> fixes the issue. When inspecting the DOM, we can see that the *ngIf controlled code works correctly. Inspecting the DOM, we can see that the statement is broken.
Steps to Reproduce

Initialize the repo
Serve the mobile app --> ng serve --project operations-mobile
Go to `https://localhost:6003/
Navigate to the News Feed tab
Press the button to open the modal - this will open the faulty modal
Close the modal.
Click on the circle on the top left of the ion-toolbar to open a working version of the modal (without ion-content)

Can the repo please be updated so it builds, or simplified down to only the issue? I'm running into too many build errors in order to reproduce a debuggable version.


Canvas Component

Is there some sort of Canvas component which gives users access to a piet::RenderContext?
I'm working on a demo for my arcs project and was wondering if it'd be feasible to write it as a native GUI application using druid.

Lol, ignore me. Looking deeper at the Widget trait the paint() method gets a piet_common::Piet, which will be resolved to the correct RenderContext for the current platform.
I'm guessing I'll need to do some coordinate transforms to make sure things are drawn at the correct location (i.e. we want the "origin" to be drawn at the top-left corner of our component, not the window), but that's not too difficult.

Yes, just creating your own custom widget is probably what you want to do here. I believe the parent of your custom widget will already take care of the transformations and offset calculations for you. You could look at the Flex widget to see how positioning and painting of child widgets is done.


baseline-PP

Hello, it is an excellent repo for navigation. I am wondering in your paper( https://arxiv.org/abs/2103.07119) you mentioned baseline algorithm- PP. I have two questions.

The path planning part uses the Dijkstra algorithm, but what control algorithm is used by the control layer to make the vehicle track the path?
Is the travel time mentioned in the paper the time it takes for the vehicle to track the path planned by Dijkstra algorithm？
I hope to receive your reply. Thank you very much.

But the Dijkstra algorithm needs a proper plan before exploring,  so is it necessary to obtain all map information to adopt this algorithm?

That's not entirely so. You can obtain an initial naive plan without exploration. A grid map has known free, known occupied, and unknown elements. By using move_base we can allow planning through unknown parts of the map, so an initial plan will be obtained. Then when executing it, the unknown parts will become known, and the original plan will be re-planned. Since that takes time, we used heuristics instead and show that through the time that it takes to get to the final goal.

Thank you very much for your answer. I think I should understand what you mean. You are using the Dijkstra planning algorithm, and the control layer comes with move_base and ROSARIA. Without the need to build a map in advance, when the car is driving, the lidar senses the surrounding environment, the unknown becomes known, and then the algorithm adjusts the planned path according to the established environment, is this true?


Add XKCD colours

Summary

Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Made this a draft, there is a few duplicates I need to fix, so I wonder if splitting in their own files could be worth it

There are some duplicates.  I might separate them in classes, just like ext.colors

There are some duplicates.  I might separate them in classes, just like ext.colors

Duplicates as in names? If so, I believe you should just add like new_ or something to the beginning of the added ones, that way there is more options.

Why, this just bloats the lib..
If you want a specific color you can look up the hex value yourself?

Why, this just bloats the lib..
If you want a specific color you can look up the hex value yourself?

It used to be an enhanced-dpy feature to include more colors. Tho I can agree it bloats the lib yeah. I guess either not adding them or maybe add a small portion such as the material colors.

Discord.py (and by extension edpy) is a wrapper for the discord API, if the discord API/Client does not have a colour, it shouldn't be in the lib.

Discord.py (and by extension edpy) is a wrapper for the discord API, if the discord API/Client does not have a colour, it shouldn't be in the lib.

Tho I agree, since this is enhanced-dpy I think it's fine to be a little more loose with non-api provided features. Doesn't mean every tiny thing should be added, but a couple QoL additions here and there doesn't hurt

Anyway, If we every decide to add more colors (#bikeshedding ?), I'll implement them differently, so I'm gonna go ahead and close this PR for now.


fix: add named arrow function for request and response handlers

cherry-pick #804

Current coverage is 100% (diff: 100%)

Merging #805 into v2.x will not change coverage

@@           v2.x   #805   diff @@
==================================
  Files         4      4
  Lines       418    420     +2
  Methods      80     80
  Messages      0      0
  Branches    100    100
==================================
+ Hits        418    420     +2
  Misses        0      0
  Partials      0      0

Powered by Codecov. Last update 2a16426...8db28b1

named arrow function const ab = () => 42; console.log(ab.name); only work on node >= 6.

named arrow function const handleResponse = () => {} only work on node >= 6.

o i c. i'm thinking maybe when we actually release koa v2, we only support node >= 8 since that's where await is native. or maybe this is a feature that can only work on node >= 6 and let it be known that it does not work on node v4

@jonathanong Its a nice idea only support node >= 8. Backward compatibility is not always good.

going to merge this and only support node 7.6+ :)


OCPBUGS-41576: Use CAPO v0.10 and API v1beta1

Manual backport of https://github.com/openshift/cluster-capi-operator/pull/203.
This fixes a crashloop when deploying on OSP because the version of CAPO we deploy no longer serves v1alpha7.

/jira refresh

/lgtm
/approve

/label backport-risk-assessed

/label cherry-pick-approved

/retest-required

/test security

@sdodson, can you help with the needed staff-eng-approved label?

@mandre Doesn't look like this is being backported to previous releases and it's not declared as a release blocker so we'll just wait until 4.17 GA is finalized and the label requirement is removed.

@mandre Doesn't look like this is being backported to previous releases and it's not declared as a release blocker so we'll just wait until 4.17 GA is finalized and the label requirement is removed. If this doesn't merge automatically by Monday run /tide refresh

Indeed, this should not go further than 4.17. It has already merged in 4.18 and showed that the operator no longer enters a crashloop, but as the feature is currently still TP, it might indeed not be a release blocker. I discussed this with @mdbooth in the morning and we think it's fine to wait for the first z-stream.

/tide refresh

/refresh

/retest required

/jira refresh

/retest-required

/test security

The security presubmit is not even for release-4.17, not sure why it is asking for it here. See https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-capi-operator/openshift-cluster-capi-operator-release-4.17.yaml

@mandre either we override the security job or we try close and reopen the PR (this will re-trigger all the presubmits) to see if we break out of this stall.

If you have the power to override the security job, that's probably best.

/override ci/prow/security


Add support for mycanal.fr

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.12.23. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2017.12.23

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)

[X] Site support request (request for adding support for a new site)

[ ] Feature request (request for a new functionality)

[ ] Question

[ ] Other

Single video: https://www.mycanal.fr/sport/interview-de-clement-grenier-cfc/p/1474402

youtube-dl.exe -v https://www.mycanal.fr/sport/interview-de-clement-grenier-cfc/p/1474402
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.mycanal.fr/sport/interview-de-clement-grenier-cfc/p/1474402']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.12.23
[debug] Python version 3.4.4 - Windows-10-10.0.16299
[debug] exe versions: ffmpeg 2.8.4, ffprobe N-81045-g450cf40, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 1474402: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 1474402: Downloading webpage
[generic] 1474402: Extracting information
ERROR: Unsupported URL: https://www.mycanal.fr/sport/interview-de-clement-grenier-cfc/p/1474402
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp27__tkx0\build\youtube_dl\YoutubeDL.py", line 784, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp27__tkx0\build\youtube_dl\extractor\common.py", line 438, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp27__tkx0\build\youtube_dl\extractor\generic.py", line 3063, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.mycanal.fr/sport/interview-de-clement-grenier-cfc/p/1474402

It was.
I think that mycanal adopted a new system to distribute its videos and I think they use a DRM protection like widevine now.
You should open a new issue to report it but there are poor chances that it will be treated.


Generated stubs create type-mismatch

After I was able to circumvent other problems, already reported here (#66, #67) I do now get the errors below. I have not touched the generated stubs.

Compiling NIF crate :spacecolony_nif (native/spacecolony_nif)...
   Compiling spacecolony_nif v0.1.0 (file:///home/nobbz/projects/elixir/space_colony/native/spacecolony_nif)
error[E0308]: mismatched types
 --> /home/nobbz/projects/elixir/space_colony/_build/dev/rustler_crates/spacecolony_nif/debug/build/spacecolony_nif-ecbe9ff9de559671/out/lib.rs:9:29
  |
9 |     Ok((num1 + num2).encode(env))
  |                             ^^^ expected struct `rustler::NifEnv`, found reference
  |
  = note: expected type `rustler::NifEnv<'_>`
  = note:    found type `&'a rustler::NifEnv<'_>`

error[E0308]: mismatched types
  --> src/lib.rs:15:1
   |
15 | include!(concat!(env!("OUT_DIR"), "/lib.rs"));
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `rustler::NifEnv`, found reference
   |
   = note: expected type `fn(rustler::NifEnv<'a>, &std::vec::Vec<rustler::NifTerm<'a>>) -> std::result::Result<rustler::NifTerm<'a>, rustler::NifError>`
   = note:    found type `fn(&'a rustler::NifEnv<'_>, &std::vec::Vec<rustler::NifTerm<'_>>) -> std::result::Result<rustler::NifTerm<'a>, rustler::NifError> {add}`
   = note: this error originates in a macro outside of the current crate

error: aborting due to 2 previous errors

We are in the middle of some really big changes, and I usually update the templates before a release.
If you want to use the generator, I can update it for you now.

It should be enough if you could provide a working example in the README
and rustdoc. That is usually my next stop after generated files don't work.
Hans Elias J<EMAIL_ADDRESS>schrieb am So., 15. Jan. 2017 um
17:31 Uhr:

We are in the middle of some really big changes, and I usually update the
templates before a release.
If you want to use the generator, I can update it for you now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hansihe/Rustler/issues/68#issuecomment-272706175, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADmR4GBKL2szMIN4Y76FvDH77BCNOa0ks5rSkn0gaJpZM4Lj7Uw
.

I have some work in progress to update the templates.
On Sun, Jan 15, 2017 at 10:44 Norbert Melzer<EMAIL_ADDRESS>wrote:

It should be enough if you could provide a working example in the README
and rustdoc. That is usually my next stop after generated files don't work.
Hans Elias J<EMAIL_ADDRESS>schrieb am So., 15. Jan. 2017 um
17:31 Uhr:

We are in the middle of some really big changes, and I usually update the
templates before a release.
If you want to use the generator, I can update it for you now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hansihe/Rustler/issues/68#issuecomment-272706175,
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AADmR4GBKL2szMIN4Y76FvDH77BCNOa0ks5rSkn0gaJpZM4Lj7Uw
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hansihe/Rustler/issues/68#issuecomment-272707020, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADQGiYoIl4W9l_RMIhQw58SMDl_HCwxks5rSkz5gaJpZM4Lj7Uw
.

May I ask on which branch they reside @scrogson?

It's not published yet. I can push it up as soon as I get on my computer.
I'll post back here to let you know.
On Sun, Jan 15, 2017 at 11:40 Norbert Melzer<EMAIL_ADDRESS>wrote:

May I ask on which branch they reside @scrogson
https://github.com/scrogson?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hansihe/Rustler/issues/68#issuecomment-272710695, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADQGqabKsdVBqSOQIglBjHxcoJxZ7u6ks5rSloigaJpZM4Lj7Uw
.

@NobbZ the PR is here: https://github.com/hansihe/Rustler/pull/69

Thank you! that was enough for me to get me up and running.


Create uk_ua.json

I have no idea why this translation doesn't work when I try to add it via the resource pack. Anyway, I translated through crowdin and all strings should be correct

Thank you for the lang PR!


WatchX Stops Working Inside StreamBuilders

If WatchX is used inside a StreamBuilder, it does not update and never rebuilds the widget.

Can you please the code of of your Widget please?

Will add test project.

I've created a sample project at https://github.com/searchy2/get_it_mixin/tree/ray-streambuilderissue
The file with the StreamBuilder issue is at main_streambuilder.dart.
I've identified the exact line of code that causes issues and here is the relevant code.
class CounterApp extends StatefulWidget with GetItStatefulWidgetMixin {
  @override
  _CounterAppState createState() => _CounterAppState();
}

class _CounterAppState extends State<CounterApp> with GetItStateMixin {
  static StreamController<int> counterController = StreamController<int>();
  Stream<int> counter = counterController.stream;

  @override
  void initState() {
    super.initState();
    Future.delayed(Duration(milliseconds: 1000), () {
      counterController.add(1);
    });
    Future.delayed(Duration(milliseconds: 2000), () {
      counterController.add(2);
    });
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        StreamBuilder(
          stream: counter,
          builder: (context, snapshot) {
            print('Build Stream');
            if (!snapshot.hasData) return SizedBox.shrink();
            // This line breaks child widgets WatchX rebuilds.
            if (false) return Text('Empty');
            int counterValue = snapshot.data as int;
            return Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                Text('Stream Counter: ' + counterValue.toString()),
                GetItCounterInStreamBuilder(),
                GetItCounterOutsideStreamBuilder(),
              ],
            );
          },
        ),
      ],
    );
  }
}

Is this what you meant by the functions must always be called and in the same order on every build?

I've created a sample project at https://github.com/searchy2/get_it_mixin/tree/ray-streambuilderissue
The file with the StreamBuilder issue is at main_streambuilder.dart.
There are multiple issues with StreamBuilders that are quite confusing. I've isolated the issues as best as possible.
Issue 1: WatchX Outside Stream builder fails on hot reload rebuild
https://www.youtube.com/watch?v=7asv6UfZRbY
StreamBuilder Hot Restart Issue
```dart
class StreamBuilderHotReloadIssue extends StatefulWidget {
  @override
  _StreamBuilderHotReloadIssueState createState() =>
      _StreamBuilderHotReloadIssueState();
}
class _StreamBuilderHotReloadIssueState
extends State {
static StreamController counterController = StreamController();
Stream counter = counterController.stream;
@override
void initState() {
super.initState();
Future.delayed(Duration(milliseconds: 1000), () {
counterController.add(1);
});
}
@override
void dispose() {
counterController.close();
super.dispose();
}
@override
Widget build(BuildContext context) {
return Column(
children: [
GetItCounterOutsideStreamBuilder(),
StreamBuilder(
stream: counter,
builder: (context, snapshot) {
print('Build Stream');
if (!snapshot.hasData) return SizedBox.shrink();
int counterValue = snapshot.data as int;
return Column(
mainAxisSize: MainAxisSize.min,
children: [
Text('Stream Counter: ' + counterValue.toString()),
GetItCounterInStreamBuilder(),
],
);
},
),
],
);
}
}
</details>

Issue 2: Stream Rebuild with Conditional Breaks WatchX Rebuilds.
![ezgif com-video-to-gif (1)](https://user-images.githubusercontent.com/19896174/95783778-27f71a80-0c98-11eb-8162-4392457d5394.gif)
<details><summary>StreamBuilder Rebuild Issue</summary>
```dart
class StreamBuilderRebuildIssue extends StatefulWidget
    with GetItStatefulWidgetMixin {
  @override
  _StreamBuilderRebuildIssueState createState() =>
      _StreamBuilderRebuildIssueState();
}

class _StreamBuilderRebuildIssueState extends State<StreamBuilderRebuildIssue>
    with GetItStateMixin {
  static StreamController<int> counterController = StreamController<int>();
  Stream<int> counter = counterController.stream;

  @override
  void initState() {
    super.initState();
    Future.delayed(Duration(milliseconds: 1000), () {
      counterController.add(1);
    });
    // This triggers a StreamBuilder rebuild and breaks WatchX.
    Future.delayed(Duration(milliseconds: 2000), () {
      counterController.add(2);
    });
  }

  @override
  void dispose() {
    counterController.close();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        StreamBuilder(
          stream: counter,
          builder: (context, snapshot) {
            print('Build Stream');
            if (!snapshot.hasData) return SizedBox.shrink();
            int counterValue = snapshot.data as int;
            return Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                Text('Stream Counter: ' + counterValue.toString()),
                GetItCounterInStreamBuilder(),
                GetItCounterOutsideStreamBuilder(),
              ],
            );
          },
        ),
      ],
    );
  }
}

Actually the latter makes completely sense to be because the builder has it's own context. So probably won't work together with the mixin or wit hooks. So better don't mix them inside one widget tree.

Just confirmed with Remi. My hunch was right. it can't work inside most builders. And the idea of the mixin is not to have to use builders to make you code more readable.

Concerning the hot reload I have to look.

I fixed the Hot reload. Please give it a try. And I added to the readme that you can't use it with Builders

Amazing, will test and confirm!


Add continuous deployment (CD) pipeline

Summary

the current version of MRpro is now defined in src/mrpro/VERSION
the current version format is 0.YYMMDD (no semantic versioning yet)
mrpro.__version__ is now defined
the CD pipeline will be triggered if the VERSION file is changed
if VERSION is changed in a dev branch, only a TestPyPi deployment is triggered
for TestPyPi releases, the format is .pre (which will be automatically converted to rc (e.g. 0.241009rc1728492371)
if merged to main, both, a TestPyPi and PyPi release is triggered
if you build the package locally with modified files compared to the current branch, the version will be +dirty (e.g. 0.241009+dirty8c038f38)
you can check which version will be used for the build process using python -m setuptools_git_versioning

from mrpro  import __version__ as project_version
config = SphinxConfig("../../pyproject.toml", globalns=globals(), config_overrides = {"version": project_version})

Everything should work as expected now. The version for the PyPi release seems to be correct (check https://github.com/PTB-MR/mrpro/actions/runs/11270262817/job/31340730315?pr=439). If we merge to main, the deployment step (which is currently the only one that is skipped to ensure everything else works as expected) should be executed as well.
Last thing I will change now is to trigger the whole pipeline only when the VERSION file is changed. This was disabled for test purposes atm.

any idea why it says "@schuenke schuenke deployed to pypi 1 hour ago — with  GitHub Actions"

👍

have we already added "MRpro Team" and more generic email address?

have we already added "MRpro Team" and more generic email address?

Nope, didn't do it yet. I can add it tomorrow.

VERSION=$(cat VERSION)
SUFFIX=${MRPROVERSIONSUFFIX#.
RCVERSION="${VERSION}${RC_SUFFIX}"
pip install some-package==${FULL_VERSION}
(assuming we change the MRPROVERSONSUFFIX from pre to rc)

This PR should now be ready for final review @fzimmermann89 and @ckolbPTB

On testpypi we have got some versions without rc in the name and they are always shown as the latest version. Is it possible to delete those versions from testpypi?

On testpypi we have got some versions without rc in the name and they are always shown as the latest version. Is it possible to delete those versions from testpypi?

Done ✔
Deleted the files with the wrong version style uploaded during debugging and marked 0.0.1 as a Yank Release


A bit of refactoring in UploadQuestion

Current dependencies on/for this PR:

main

PR #49

PR #50   👈

PR #51

This comment was auto-generated by Graphite.


Add flag to remove horizontal dashed line in stacked bar chart

Option to remove horizontal dashed line in stacked bar chart.

you can just do withInnerLines={false}

@cezzzanne the <StackedBarChart /> doesn't have that prop


Pass meta with add:client

Fixes #95

Hmm.... no idea why this build failed.
plugin latest and next all point at the same version of seneca, 3.4.2 and 4.x passed fine for the others.
Is this a flaky test?  Looks like some kind of stress test which might not work very well under travis?


Message when switch scenes

This message appears when I switch from a scene to another:
Switch Scene Tab
servers/visual/visual_server_canvas.cpp:762 - Condition "pointcount < 3" is true
It seems to be an error that occurs only in the editor, and doesn't seems to have relevant effects, but I think it wasn't supposed to be there.
I'm on Ubuntu and the project is saved in another partition that is emulated (maybe it's relevant because it caused another error in the past).

Does it happen with any scene? This looks like the error that shows for empty (Collisiion)Polygon2D nodes.

@kuryart When reporting bugs, please fill in the issue template instead of replacing it. This way, we can know which Godot version you're using. Also, try to upload a minimal reproduction project if possible.

@KoBeWi That's exactly what caused the error. Fixed, sorry for the inconvenience, I'll try to search more before opening a bug thread.
@Calinou Sorry, didn't know that. Gonna follow the issue template henceforward.

That's exactly what caused the error. Fixed, sorry for the inconvenience

Does this mean the issue is resolved and can be closed? (just want to make sure, since you didn't close it yourself)

@KoBeWi Is there a bug report for those error messages being displayed for no reason?

Nope. Also it would be weird if this showed without any polygon.

That's exactly what caused the error. Fixed, sorry for the inconvenience

Does this mean the issue is resolved and can be closed? (just want to make sure, since you didn't close it yourself)

Yes, I'm closing it.


Suggest linking to the new webpack plugin

I suggest adding something like this https://github.com/tomwayson/esri-webpack-babel/commit/8f5311664022e268c0e064f6ffe6bf77845ac04f to the README to inform people about the newer techniques.

Done!  Finally ;)


Add a pipectl command to generate key pair used for secret management feature

What would you like to be added:
Why is this needed:

Ref: https://pipecd.dev/docs/user-guide/managing-application/secret-management/#prerequisites


[Request] SuperSlicer

Package Request
The prusaslicer and slic3r slicers are already in this bucket. It would make sense to also include their emerging competitor and fork (which is already well-appreciated in the 3D printing community), SuperSlicer. This app manifest will be unofficial. I'm planning on writing this app manifest, basing it off of the prusaslicer manifest.
Information
Name: superslicer
Description: G-code generator for 3D printers (Prusa, Voron, Creality, etc.) SuperSlicer is based on PrusaSlicer by Prusa Research. PrusaSlicer is based on Slic3r by Alessandro Ranellucci and the RepRap community.
Homepage: https://github.com/supermerill/SuperSlicer
Download link(s): https://github.com/supermerill/SuperSlicer/releases
Some indication of popularity/repute: 1.7k stars on Github, coverage on Hackaday, All3DP

https://github.com/ScoopInstaller/Extras/pull/7438


Splash screen sample scale factor

the image positioning does not work when the display is set at 125% like on an 8inch tablet.
How can we know if the ResolutionScale is real or fake?
In the zoomed case we don't need to scale the image.

There have been a number of fixes to the splash screen sample with respect to scale factor.


empty deafult value

is it possible to set empty value as a default for a date picker?

Yes, pass null to the value. You can find such example in the datetimepicker examples


Polyfill 3.17.0 service update - UIWebView on IOS stopped loading

Hi,
I hope you may be able to help.
We are using webviews within a native IOS app, using UIWebView. We have a live app and have been using your service for polyfills for about 6 months with no problem (we run reactJS as the primary js library). Today we have started seeing users fail to load pages. I'm getting the app developer to try and get more info, as i realise i'm not giving you much to go on.
Just wondered if there could be anything in the latest release that could unsettle IOS UIWebView on IOS10? As out problems seemed to coincide with your release, but it could just be coincidence!
Thanks in advance for any help,
Regards,
Matt

Seem here.

@matt-ville What is your App's User Agent?

So, not sure if this is related, but it seems like more than a coincidence... My Electron web app broke yesterday, too, due to its User Agent being identified as "unknown". As stated above, it had been working successfully until around middle of yesterday. The user agent is:
UA detected: electron/1.4.0 (unknown/unsupported; using policy unknown=polyfill)
Should I split this off into a separate issue?

Please open a new issue for the electron detection :-)
On 16 Mar 2017 19:33, "Ruben Martinez Jr."<EMAIL_ADDRESS>wrote:

So, not sure if this is related, but it seems like more than a
coincidence... My Electron web app broke yesterday, too, due to its User
Agent being identified as "unknown". As stated above, it had been working
successfully until around middle of yesterday. The user agent is:
UA detected: electron/1.4.0 (unknown/unsupported; using policy
unknown=polyfill)
Should I split this off into a separate issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Financial-Times/polyfill-service/issues/1121#issuecomment-287167176,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfxa3bEQTekW2FmR5fQIpsbr7EtJ2MHks5rmY6AgaJpZM4Mej8U
.

@matt-ville @lepture @rubencodes Thanks for reporting this.  First of all, if you have production sites relying on our CDN service it's a good idea to regularly run against our QA service in your CI or test environment so you can be warned if we release something that inadvertently breaks your app.  You can swap out polyfill.io or cdn.polyfill.io for qa.polyfill.io to get the QA service.  All our minor and major releases are made available in QA for 7 days before being promoted to production.
Obviously please don't use the QA service in production, it is not highly available.
Regarding this issue, we are ideally looking for the console log of the error that you're seeing, the UA string of the browser that is exhibiting the problem, and a reduced test case in JSBin.com that we can use to reproduce the problem on the affected browser.

I think I have managed to reproduce this (see Safari debugger screenshot):

The UA is being faked as Mozilla/5.0 (iPhone; CPU iPhone OS 10_1 like Mac OS X) AppleWebKit/602.2.14 (KHTML, like Gecko) Mobile/14B72

@callumj This should be fixed in the next release of the service

@JakeChampion can you link the PR or issue in which we're tracking the solution?

PR is scheduled for release in 3.18


last_edited_at fixups

Trello card: https://trello.com/c/QJPHGeQf/738-add-last-edited-at-timestamp-to-content-items-small-ish
Previous pull request: https://github.com/alphagov/publishing-api/pull/365
These commits fix some mistakes in the documentation, and fix setting last_edited_at for new content items (as well as fixing the test coverage for this).
@elliotcm who worked with me on the last pull request
@tuzz (as the RFC author)
@alphagov/team-publishing-platform (who need to be aware of this work)

LGTM 👍


Adds missing functionality to logs

The larametrics config file specifies logsWatchedExpireDays and logsWatchedExpireAmount values but they are not defined in the code base. Added the to the log creation process to check before the log is added.

Looks good! Thanks for catching this.


Observatory UI never comes up if there is no vm service at the expected port

E.g., if running from pub and trying to connect to a Dartium page at an unpredictable port.

Navigating to #/vm-connect will allow you to enter an ip address. It used to be automatic.

@alan-knight


Update for Issue 59 Check for template updates

Update for Issue 61 max size of template JSON
See full descriptions on comments from Mayank Agrawal here:
https://github.com/rdbrck/jira-template-injector/issues/59
https://github.com/rdbrck/jira-template-injector/issues/61

Dev is Mayank Agrawal: @mynkgrwl


Unconditional markForCheck

Since moving to OnPush, root.ts, rule.ts, rules.ts and filter.ts all do an unconditional markForCheck on any action change.
Is this necessary?

Fixed in 1.2.0