Tensor conversion requested dtype int32 for Tensor with dtype float32

When I try to load a model (keras.models.load_model()) that was saved by Keras using tensorflow 1.1 on a tensorflow 1.2 based keras I got following error:
/usr/local/lib/python3.5/dist-packages/keras/models.py in load_model(filepath, custom_objects, compile)
    231             raise ValueError('No model found in config file.')
    232         model_config = json.loads(model_config.decode('utf-8'))
--> 233         model = model_from_config(model_config, custom_objects=custom_objects)
    234
    235         # set weights

/usr/local/lib/python3.5/dist-packages/keras/models.py in model_from_config(config, custom_objects)
    305                         'Maybe you meant to use '
    306                         '`Sequential.from_config(config)`?')
--> 307     return layer_module.deserialize(config, custom_objects=custom_objects)
    308
    309

/usr/local/lib/python3.5/dist-packages/keras/layers/__init__.py in deserialize(config, custom_objects)
     52                                     module_objects=globs,
     53                                     custom_objects=custom_objects,
---> 54                                     printable_module_name='layer')

/usr/local/lib/python3.5/dist-packages/keras/utils/generic_utils.py in deserialize_keras_object(identifier, module_objects, custom_objects, printable_module_name)
    137                 return cls.from_config(config['config'],
    138                                        custom_objects=dict(list(_GLOBAL_CUSTOM_OBJECTS.items()) +
--> 139                                                            list(custom_objects.items())))
    140             with CustomObjectScope(custom_objects):
    141                 return cls.from_config(config['config'])

/usr/local/lib/python3.5/dist-packages/keras/engine/topology.py in from_config(cls, config, custom_objects)
   2448
   2449         for layer_data in config['layers']:
-> 2450             process_layer(layer_data)
   2451
   2452         name = config.get('name')

/usr/local/lib/python3.5/dist-packages/keras/engine/topology.py in process_layer(layer_data)
   2443                 if input_tensors:
   2444                     if len(input_tensors) == 1:
-> 2445                         layer(input_tensors[0], **kwargs)
   2446                     else:
   2447                         layer(input_tensors, **kwargs)

/usr/local/lib/python3.5/dist-packages/keras/engine/topology.py in __call__(self, inputs, **kwargs)
    567                                          '`layer.build(batch_input_shape)`')
    568                 if len(input_shapes) == 1:
--> 569                     self.build(input_shapes[0])
    570                 else:
    571                     self.build(input_shapes)

/usr/local/lib/python3.5/dist-packages/keras/layers/embeddings.py in build(self, input_shape)
     99             regularizer=self.embeddings_regularizer,
    100             constraint=self.embeddings_constraint,
--> 101             dtype=self.dtype)
    102         self.built = True
    103

/usr/local/lib/python3.5/dist-packages/keras/legacy/interfaces.py in wrapper(*args, **kwargs)
     85                 warnings.warn('Update your `' + object_name +
     86                               '` call to the Keras 2 API: ' + signature, stacklevel=2)
---> 87             return func(*args, **kwargs)
     88         wrapper._original_function = func
     89         return wrapper

/usr/local/lib/python3.5/dist-packages/keras/engine/topology.py in add_weight(self, name, shape, dtype, initializer, regularizer, trainable, constraint)
    389         if dtype is None:
    390             dtype = K.floatx()
--> 391         weight = K.variable(initializer(shape), dtype=dtype, name=name)
    392         if regularizer is not None:
    393             self.add_loss(regularizer(weight))

/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py in variable(value, dtype, name)
    319         v._uses_learning_phase = False
    320         return v
--> 321     v = tf.Variable(value, dtype=_convert_string_dtype(dtype), name=name)
    322     if isinstance(value, np.ndarray):
    323         v._keras_shape = value.shape

/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/variables.py in __init__(self, initial_value, trainable, collections, validate_shape, caching_device, name, variable_def, dtype, expected_shape, import_scope)
    198           name=name,
    199           dtype=dtype,
--> 200           expected_shape=expected_shape)
    201
    202   def __repr__(self):

/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/variables.py in _init_from_args(self, initial_value, trainable, collections, validate_shape, caching_device, name, dtype, expected_shape)
    287         else:
    288           self._initial_value = ops.convert_to_tensor(
--> 289               initial_value, name="initial_value", dtype=dtype)
    290           shape = (self._initial_value.get_shape()
    291                    if validate_shape else tensor_shape.unknown_shape())

/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py in convert_to_tensor(value, dtype, name, preferred_dtype)
    674       name=name,
    675       preferred_dtype=preferred_dtype,
--> 676       as_ref=False)
    677
    678

/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py in internal_convert_to_tensor(value, dtype, name, as_ref, preferred_dtype)
    739
    740         if ret is None:
--> 741           ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
    742
    743         if ret is NotImplemented:

/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py in _TensorTensorConversionFunction(t, dtype, name, as_ref)
    612     raise ValueError(
    613         "Tensor conversion requested dtype %s for Tensor with dtype %s: %r"
--> 614         % (dtype.name, t.dtype.name, str(t)))
    615   return t
    616

ValueError: Tensor conversion requested dtype int32 for Tensor with dtype float32: 'Tensor("embedding_1/random_uniform:0", shape=(5000, 60), dtype=float32)'

same problem

Not sure if this is the general case, but I observed this error when training models using Keras 2.0.5 and loading in Keras 2.0.6. If I retrain the model in 2.0.6, I can successfully reload the model using  keras.models.load_model().

Same problem.

Same problem

I get the same issue when using model saved in Keras 2.0.5 and loading in Keras 2.0.6

The workaround I found is to save only weights and recreate the model in the code and load just the weights.
It seems that the problem is cased by TF upgrade (from 1.1 to 1.2) rather than Keras though I might be wrong.

is there work around for this issue

switching to Keras 2.0.5 worked for me

What is really the solution for this issue? I am facing the same problem.

update and retrain

@ft512835 What do you mean by "update and retrain"? How can I fix the error?

@HangsunKim what version of your Keras and Tensorflow?

@ft512835
I'm using keras 2.1.2 and Tensorflow 1.1.0 as the backend.

@HangsunKim Is it possible that you trained the model using a different version of Keras and Tensorflow? I observed this problem, after switching to a new version of Keras..

Hey,
The error seems to come due to Keras version and not the backend as I have tried changing the backend from Tensorflow to Theano and different versions of both.
One line reason: If you have trained a model on Keras <= 2.0.5 and trying to load on Keras >2.0.5. It is going to throw and error.
One line solution: If you still have the data, re-train the model on Keras > 2.0.5 else install  Keras <= 2.0.5
Thanks,
Aditya

I think @adityac8 is right, roll back to the low version of Keras work for me.

If any one is still facing this issue even after training and loading on the same version of Keras and Tensorflow, (which I did), just casting it manually to dtype float32 worked for me.
here is a sample code snippet resembling my original problem (using the Functional API):
var = tf.constant(1, shape = [64,512])
inp = Input (tensor = var)
inp1 = Lambda (lambda x: tf.cast(x, tf.float32))(inp)
dense = Dense(1, activation = 'sigmoid')(inp1)

model = Model(inp, dense)
model.compile(...)
model.fit(...)

The lambda layer is used to convert a Tensorflow tensor to a Keras one.

Any workarounds to this problem. I have the entire model instead of the weights.

i m trying to train images with train.py using tensorflow getting same error can someone tell me when and why this error occurs?
ty


make linke turbidity fixed in tests

See discussion in #31.

Ok, we have three tests with errors now, but the error message states that the error is raised, because scipy is missing. So it seems ok for now.
I opended a new issue on this topic: #36


Prometheus is not compatible with the changes in K8s v1.16

Bug Report
What did you do?
I installed the stable/prometheus helm chart with some minor changes proposed at https://github.com/helm/charts/pull/17268 to make it compatible with Kubernetes v1.16
After installation, none of the Kubernetes grafana dashboards show correct values.  I am using 8769 (https://grafana.com/grafana/dashboards/8769) dashboard which provides many information on cpu, memory, network, etc. This dashboard is working properly on older k8s versions but on v1.16 it shows no results. I also randomly tried some other dashboards (8588, 6879, 10551) but they either just show the requested resource for each pod and not the live usage or showing nothing.
What these dashboards do is they send a promql query to prometheus and get the results. For example this is the promql query for cpu usage from 8769 dashboard:
sum (rate (container_cpu_usage_seconds_total{id!="/",namespace=~"$Namespace",pod_name=~"^$Deployment.*$"}[1m])) by (pod_name)

I don't know if I have to change the promql or the problem is somewhere else.
What did you expect to see?
Correct and live resource usage like how it works with older k8s versions.
What did you see instead? Under which circumstances?
I described above.
Environment
A 5 node k8s cluster running k8s v1.16

Prometheus version:
Based on the helm chart that I am using:2.11.1

Alertmanager version:
v0.18.0

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


create a gitter8 template for zio-spark and Scala3

added the repo here : https://github.com/univalence/zio-spark.g8
it doesn't work yet for Scala3 due to #284


What happens when only one Lighthouse is in sight?

I need to get an accurate (<10cm error) position of one robot relative to another robot. I'm considering placing a Lighthouse on one robot, and this sensor on the other. I don't need depth, only X and Y.
Would this still give position within 10 cm even with only one lighthouse unit?

No, currently both base stations must be in sight to get pulse
synchronization. This problem is technically solvable, just requiring a
rewrite of the synchronization module.
Having the above in mind, with just one base station the only thing you'll
be getting is two angles from the line along which the base station is
"looking". If depth is constant and base station is overlooking the area
where your robot is moving, then you should be able to convert it to XY
coordinates, but I'm not sure how you can do that with base station on
another robot.
Basically, if you have two robots moving in the same plane, then this won't
work at all.
--
Alexander Shtuchkin
On Sat, Jul 22, 2017 at 4:34 PM, DanielArnett<EMAIL_ADDRESS>wrote:

I need to get an accurate (<10cm error) position of one robot relative to
another robot. I'm considering placing a Lighthouse on one robot, and this
sensor on the other. I don't need depth, only X and Y.
Would this still give position within 10 cm even with only one lighthouse
unit?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/30, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAmVHX9mXbCvZbzkLzg3yweIzR8VsCimks5sQobqgaJpZM4OgT3b
.

I appreciate your perspective, thank you. I don't need the robots position, there are other sensors for that. I'm looking for accurate relative position between two robots, say for them to dock for instance. If I can get an accurate vector from one robot to another; then this sensor would be perfect. I don't care about coordinates as much as I do the angles between robots.
Any first thoughts on where I should look if I want to disable pulse synchronization and just use the pulses from one Lighthouse?

O
k, I trust you know what you're doing.

This is
the piece of sync algorithm that uses both stations to classify the cycle
phase depending on the large pulse widths:
https://github.com/ashtuchkin/vive-diy-position-sensor/blob/master/src/cycle_phase_classifier.cpp#L31
Having two stations simplifies the algorithm significantly, so I chose to
do it this way. It's possible to change it to work with only one base
station, but that would require rather significant rewrite of that module.
I'd assess it would take at least a week to do that, which I don't have atm.
--
Alexander Shtuchkin
On Sat, Jul 22, 2017 at 5:02 PM, DanielArnett<EMAIL_ADDRESS>wrote:

I appreciate your perspective, thank you. I don't need the robots
position, there are other sensors for that. I'm looking for accurate
relative position between two robots, say for them to dock for
instance. If I can get an accurate vector from one robot to another; then
this sensor would be perfect. I don't care about coordinates as much as I
do the angles between robots.
Any first thoughts on where I should look if I want to disable pulse
synchronization and just use the pulses from one Lighthouse?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/30#issuecomment-317218570,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmVHXv6uNcfarPNI5A1sSFvAJdP94Byks5sQo2qgaJpZM4OgT3b
.

Okay, what about this for a workaround; how about if there were two lighthouses right next to each other; would that run and at least try to estimate position?

The lighthouse won't stay on if it detects its moving, so unless the robot is moving steadily at snail pace I would look for a different solution altogether. Your constraints are not too high (only azimuth and relatively low accuracy of 10cm), so you could consider making a rotating laser fan mechanism yourself.
Another reason to make your own version in this case is that the sync flashes would likely need 360 degrees coverage, but the basestations are limited to less than 180 degrees. Because you only need a single axis, you can get away with just a single flash at a constant interval however, no encoding/decoding of pulse lengths needed. Although, if multiple robots were equipped with a lighthouse-style tracking solution, you need to think about multiplexing. The easiest solution would be time division multiplexing, could use a cheap radio to communicate between robots who is allowed to emit light signals.
At this point however, it might be better to consider using a camera and OpenCV combined with some LEDs. The camera could be mounted on a servo to get 360 degree coverage, or you can use about 3 cameras with wide angle lenses.

Very interesting, thank you @BoyHolthausen! I was thinking the same thing using wide angle cameras and a visible laser. I'll think about this! Thanks


recognize cancellation tokens for async methods

Some of the cancellation-tokens of the public api where ignored (e.g. WriteAsync, ReadAsync, ...) which is fixed in this PR.
There were also some public async methods without a cancellation token parameter. They now also have a cancellation token parameter.
This solves #824 and should prevent any "hanging" tasks like descriped in #785 (this will not fix the root cause).

Thanks for the PR!
Unfortunately the Mac build is failing, but I don't think this is caused by your changes. The relevant warnings/errors are:
warning MT0079: The recommended Xcode version for Microsoft.iOS 17.5.8018 is Xcode 15.4 or later.
The current Xcode version (found in /Applications/Xcode_15.2.app/Contents/Developer) is 15.2.
[/Users/runner/work/dotnet-bluetooth-le/dotnet-bluetooth-le/Source/BLE.Client/BLE.Client.Maui/BLE.Client.Maui.csproj::TargetFramework=net8.0-ios]

error MT0180: This version of Microsoft.iOS requires the iOS 17.5 SDK (shipped with Xcode 15.4).
Either upgrade Xcode to get the required header files or set the managed linker behaviour to
Link Framework SDKs Only in your project's iOS Build Options > Linker Behavior (to try to avoid the new APIs).
[/Users/runner/work/dotnet-bluetooth-le/dotnet-bluetooth-le/Source/BLE.Client/BLE.Client.Maui/BLE.Client.Maui.csproj::TargetFramework=net8.0-ios]

Sounds like we need to update the XCode version used in the GHA build on Mac. I can look into that.

Sounds like we need to update the XCode version used in the GHA build on Mac. I can look into that.

... and for that we probably need to update the build host to MacOS 14 (it is currently using 13.6.8).
See:

https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

Fixed the build problems via #881 & rebased this one on top of it  ➡  all builds succeed ✅ 🥳

@minno726 @bcaceiro Does this fix #824 for you?
@softeip @sschoeb Does it fix #785 for you?
Could anyone of you guys test this PR and report if it works for you? You can download the nupkg from https://github.com/dotnet-bluetooth-le/dotnet-bluetooth-le/actions/runs/10338642672#artifacts

This would be a nice win. I've been frustrated when trying to cancel a call, only for the token to be ignore.

It's really hard to cancel token after calling ICharacteristic.WriteAsync() since it gets executed fast enough.
I could not catch any hanging issues that I had mentioned in #785 which I expected to bump into to help testing cancellation - the token would be automatically cancelled in this case by CancelAfter(10000)
I tried passing already cancelled token and I got no exception thrown by ICharacteristic.WriteAsync() method - is it expected behavior is this case or have I done something wrong?
All I can confirm regarding 3.1.0-6-gffd5b3d is that my app works as stable as it does with 3.1.0.

I tried passing already cancelled token and I got no exception thrown by ICharacteristic.WriteAsync() method - is it expected behavior is this case or have I done something wrong?

@srruu Maybe one should add a corresponding check and throw a System.ArgumentException for that case? What do you think about that?
Otherwise I'm happy with this PR by now (after you have address my previous review comments). 😃

All I can confirm regarding 3.1.0-6-gffd5b3d is that my app works as stable as it does with 3.1.0.

Thanks for testing, @softeip ! 👍

I tried passing already cancelled token and I got no exception thrown by ICharacteristic.WriteAsync() method - is it expected behavior is this case or have I done something wrong?

@srruu Maybe one should add a corresponding check and throw a System.ArgumentException for that case? What do you think about that?
Otherwise I'm happy with this PR by now (after you have addressed my previous review comments). 😃

@srruu Any comment here? If not, I'll just merge this as is (probably on the weekend).

Works perfectly on my app too 😄

Alright, I have just merged this now (sorry for the delay).
Thanks for the contribution, @srruu !


Updated href for contact button

Contact eResearch button

now goes to:
https://qutvirtual4.qut.edu.au/group/research-students/conducting-research/specialty-research-facilities/advanced-research-computing-storage

The envelope icon also needs to be removed

Done


Fix/fs fail error 24 + Submission Table Enhancements

Fix for fs fail issue raised here: https://github.com/AmericanRedCross/OpenMapKitServer/issues/78

Submission table enhancement using jQuery data tables (with material styling) for filtering, sorting and pagination

Great work @ahmedOpeyemi. I'll review and merge soon.

Awesome!


Error on a new installation

CET worked once, by what miracle I did not then impossible to make it work...
I tested this on a brand new GOG installation
And I have this error:
[2021-09-06 14:21:51 UTC+02:00] [info] Cyber Engine Tweaks is starting...
[2021-09-06 14:21:51 UTC+02:00] [error] E7
[2021-09-06 14:21:51 UTC+02:00] [error] 28
[2021-09-06 14:21:51 UTC+02:00] [error] D7
[2021-09-06 14:21:51 UTC+02:00] [error] 5D
[2021-09-06 14:21:51 UTC+02:00] [error] B8
[2021-09-06 14:21:51 UTC+02:00] [error] F9
[2021-09-06 14:21:51 UTC+02:00] [error] 79
[2021-09-06 14:21:51 UTC+02:00] [error] 4D
[2021-09-06 14:21:51 UTC+02:00] [error] 89
[2021-09-06 14:21:51 UTC+02:00] [error] 76
[2021-09-06 14:21:51 UTC+02:00] [error] 16
[2021-09-06 14:21:51 UTC+02:00] [error] 64
[2021-09-06 14:21:51 UTC+02:00] [error] AB
[2021-09-06 14:21:51 UTC+02:00] [error] 1E
[2021-09-06 14:21:51 UTC+02:00] [error] A0
[2021-09-06 14:21:51 UTC+02:00] [error] 47
[2021-09-06 14:21:51 UTC+02:00] [info] Unknown Game Version, update the mod

I tried to do the file verification option but gog shows me no modification

They just released a dumb patch with the same name, update in a few minutes


Pre-unifying type constructors with type variables does not work

Pre-unify Either a b with x y z does not work. The reason is that the former is internally represented as TyConApp Either [a,b] whereas the latter is represented as AppTy (AppTy c d) e. Test case:
type family F a b  = r | r -> a b where
  F a      IO      = IO a   -- (1)
  F Char   b       = b Int  -- (2)

Fixed using splitAppTy_maybe.


Set data does not save when rest timers are enabled

Hey,
I seem to be having the opposite problem to Issue #17.
When rest timers are enabled, the rest timer activates, however the set data does not seem to save. Disabling the rest timer allows the sets to save as expected.
Cheers

This is why I shouldn't be doing updates with a wrist injury. Embarrassing.

Honestly I need better tests

You're all good, these things happen.
I'm liking the project so far, keep up the good work.

I still have this issue on the latest version from F-droid.

It's fixed in 1.0.61 onward. F-droid will take longer to get recent updates than the Play store + github releases.

I got the update from GitHub instead of play store.


Add immutable rootfs and grub docs

This commit adds some reference documentationf or the immutable rootfs
dracut module and in addition adds few details about the GRUB2
configuration.
Fixes rancher-sandbox/cOS-toolkit#237
Signed-off-by: David Cassany<EMAIL_ADDRESS>

That's great!


Refactoring module initialization and classifying flags

Codecov Report

Merging #1471 (5fdcc7c) into main (14b9203) will increase coverage by 0.24%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   59.14%   59.38%   +0.24%
==========================================
  Files         131      132       +1
  Lines       21981    21923      -58
==========================================
+ Hits        13001    13020      +19
+ Misses       7423     7348      -75
+ Partials     1557     1555       -2

Impacted Files
Coverage Δ

cmd/gateway.go
26.36% <30.76%> (-3.09%)
:arrow_down:

cmd/mount.go
64.09% <58.19%> (-8.44%)
:arrow_down:

cmd/flags.go
94.44% <94.44%> (ø)

cmd/mount_unix.go
48.07% <100.00%> (-6.17%)
:arrow_down:

cmd/webdav.go
64.10% <100.00%> (-14.03%)
:arrow_down:

pkg/meta/redis.go
71.15% <0.00%> (+0.13%)
:arrow_up:

pkg/meta/sql.go
68.64% <0.00%> (+0.51%)
:arrow_up:

pkg/vfs/writer.go
79.66% <0.00%> (+1.01%)
:arrow_up:

pkg/chunk/cached_store.go
73.52% <0.00%> (+2.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b9203...5fdcc7c. Read the comment docs.


Add tests for random

https://github.com/pulumi/pulumi-terraform-bridge/issues/1849
This PR adds tests for the following resources:
index_randomstring
index_randomshuffle
index_randombytes
index_randomuuid
index_randompassword
index_randomid
index_randominteger
index_randompet
It also adds upgrade tests for the resources.

@iwahbe this one is ready, LMK what you think and I'll merge the others as they are ready if this one looks ok.


add GetFileType stub

because I'm planning to break miri again https://github.com/rust-lang/rust/pull/103360
See GetFileType

Thanks. :)
Unfortunately we are struggling with getting Miri changes synced back to rustc, but still seems better to land this here.
@bors r+

:pushpin: Commit aed5ce665690a11696608b886e636d683f45ebc2 has been approved by RalfJung
It is now in the queue for this repository.

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing ed66a62397847d7e7135a6634f26bb7b51b41b75 to master...


Update sbt-coveralls to 1.3.12

About this PR
📦 Updates org.scoverage:sbt-coveralls from 1.2.7 to 1.3.12
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-coveralls" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-coveralls" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

Superseded by #64.


Terraform 0.13.6 breaks qhub

QHub code allows minor releases of terraform 'v0.13, but v0.13.6results in an error with the s3 backend. Reverting tov0.13.5` caused the problem to go away.
I propose we only support a single version of terraform at a time. The latest confirmed working version of terraform is v0.13.5

this issue was fixed by PR #280


Type narrowing inconsistency with different union type definitions

🔎 Search Terms
type narrowing, union type, conditional type, discriminated union, type inference
🕗 Version & Regression Information
This is the behavior in every version I tried, and I reviewed the FAQ for entries about type narrowing and discriminated unions.
⏯ Playground Link
No response
💻 Code
// Worked!
function test1(value: { type: 'a' } | { type: 'b' }) {
    if (value.type === 'a' || value.type === 'b') { }
    else {
        // @ts-expect-error
        throw new Error(`asdf ${value.type}`)
    }
}

// Not Worked!
function test2(value: { type: 'a' | 'b' }) {
    if (value.type === 'a' || value.type === 'b') { }
    else {
        // @ts-expect-error
        throw new Error(`asdf ${value.type}`)
    }
}

### 🙁 Actual behavior

In test2, TypeScript fails to narrow the type of value within the if statement, even though the condition explicitly checks against all possible values of value.type. The else block, therefore, does not produce a type error, despite logically being unreachable. The @ts-expect-error directive is ignored. This is inconsistent with the behavior in test1, where the equivalent logic does correctly narrow the type. The only difference is the way the union type is defined: { type: 'a' } | { type: 'b' } versus { type: 'a' | 'b' }.

### 🙂 Expected behavior

TypeScript should consistently narrow the type in both test1 and test2. The else block in test2 should produce a type error, just as it does in test1, because the condition ensures that the else block is logically unreachable. The @ts-expect-error directive should correctly reflect this. The type narrowing behavior should not depend on the syntactic form of the union type definition.

### Additional information about the issue

This inconsistency leads to unpredictable behavior and reduces the reliability of TypeScript's type safety features. A consistent and predictable type narrowing mechanism is crucial for writing robust and maintainable code.

Duplicate of #31404.


Fixed error in joins used in a nested select

Wrongly createdOrderedTopNProjection (outputs where Fields instead of InputColumns) caused
by wrong copy of the Fields of MultiSourceSelect in RelationNormalizer.

Codecov Report

Merging #5447 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #5447      +/-   ##
============================================
+ Coverage     82.32%   82.41%   +0.08%
- Complexity    11278    11294      +16
============================================
  Files          1359     1359
  Lines         44304    44309       +5
  Branches       5558     5558
============================================
+ Hits          36473    36516      +43
+ Misses         5225     5195      -30
+ Partials       2606     2598       -8

Impacted Files
Coverage Δ
Complexity Δ

...io/crate/analyze/relations/RelationNormalizer.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

.../main/java/io/crate/analyze/MultiSourceSelect.java
87.5% <100%> (+2.5%)
19 <2> (+2)
:arrow_up:

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
75% <0%> (-10%)
2% <0%> (ø)

...crate/planner/projection/MergeCountProjection.java
63.63% <0%> (-9.1%)
5% <0%> (-1%)

...io/crate/planner/projection/ProjectionVisitor.java
35.29% <0%> (-5.89%)
6% <0%> (-1%)

.../java/io/crate/blob/TransportDeleteBlobAction.java
75% <0%> (-5%)
4% <0%> (-1%)

...te/blob/pending_transfer/PutHeadChunkRunnable.java
76.71% <0%> (-4.11%)
12% <0%> (-2%)

...ava/io/crate/data/AsyncOperationBatchIterator.java
85.91% <0%> (-2.82%)
23% <0%> (ø)

...a/io/crate/operation/fetch/NodeFetchOperation.java
83.83% <0%> (-2.03%)
14% <0%> (ø)

...c/main/java/io/crate/jobs/JobExecutionContext.java
90.51% <0%> (-1.73%)
22% <0%> (-1%)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a425791...c3a2f03. Read the comment docs.


⚠ haccp has degraded performance

In 0ca9a4f, haccp (https://www.haccp.or.kr) experienced degraded performance:

HTTP code: 200
Response time: 10355 ms

Resolved: haccp performance has improved in b3e313e.


Better documentation when it comes to webflux and spring boot

Is your feature request related to a problem? Please describe.
I am an intermediate java developer that spent 3 hours reading about graphql, i am at the moment developing a webflux application and i though about implementing graphql in my webflux application. I try first to find a webflux implementation which is hard enough and when i find one here, sadly there is no documentation about it.
In my googling i found a feature request for a webflux implementation and that brought me to the kickstart project, it was implemented in november last year, and that issue links to a sample project:
Webflux sample
I also found another webflux project under examples:
example-webflux
No documentation found about these projects or on the kickstarter page whatsoever about webflux, only servlet and spring boot, but not explicitly about webflux in the spring boot section. Both semple/example projects implement 2 dependencies in their gradle files:
graphql-kickstart-spring-boot-starter-webflux
graphql-kickstart-spring-boot-starter-tools

The first dependency i understand, the second one, no documentation why it is needed. I do find that in order to use the graphQL DSL you need the "GraphQL Java Tools" could the second dependency be that? i have no idea, since there is no documentation. Digging into the pom.xml i do find that the second dependency is dragging in graphql-kickstart-spring-boot-autoconfigure-tools that in turn is dragging in the graphql-java-tools so yes.
When booting up the spring boot application won't start.
Description:

Parameter 0 of method graphQLSchemaProvider in graphql.kickstart.spring.webflux.boot.GraphQLSpringWebfluxAutoConfiguration required a bean of type 'graphql.schema.GraphQLSchema' that could not be found.

The following candidates were found but could not be injected:
	- Bean method 'graphQLSchema' in 'GraphQLJavaToolsAutoConfiguration' not loaded because @ConditionalOnBean (types: graphql.kickstart.tools.SchemaParser; SearchStrategy: all) did not find any beans of type graphql.kickstart.tools.SchemaParser

Action:

Consider revisiting the entries above or defining a bean of type 'graphql.schema.GraphQLSchema' in your configuration.

Disconnected from the target VM, address: '<IP_ADDRESS>:60904', transport: 'socket'

Process finished with exit code 1

It needs some sort of bean, but there is no documentation about what bean, and the purpose of the bean, or how to declare it etc.
in the sample application, no bean is declared, only schema files, i spend some time digging but can't figure out how the sample project works because no bean is declared there.
in the example project there is a bean declared:
    @Bean
    GraphQLSchema schema() {
        return GraphQLSchema.newSchema()
            .query(GraphQLObjectType.newObject()
                .name("query")
                .field(field -> field
                    .name("test")
                    .type(Scalars.GraphQLString)
                    .dataFetcher(environment -> "response")
                )
                .build())
            .build();
    }

But there is no declaration as to what this bean is, it looks like it is declaring a schema. There is no documentation about this bean on the kickstarted spring boot webpage either, i actually can't find a single word about the GraphQLSchema object in the entire documentation.
Describe the solution you'd like
I wish there to be more user friendly documentation as to how to get started from scratch.  And if that is so i apologize because that could be also be a fact.
I'd gladly write some more documentation and submit a PR to the documentation repo, as soon as i start getting things.

I have spent two hours chasing how to make a working spring boot example :( still no luck.
Quite a quest with cross links and examples that don't actually use .graphqls files. Dozen of articles on the internet using outdated dependencies doesn't help either.

I have a working application using the libraries you mentioned, Mykola, please let me know if you still need it.
@oliemansm I'm facing issue when I try execute unit tests. I tried run the application as JUnit application in Eclipse, and also run tests using Maven. In both scenarios the tests are executed, but it seems the GraphQL itself is not running. I created a very simple test where I try to do a POST call to http://localhost:8080/graphql but I always receive "connection refused", the GraphQL is not running. The application starts, the tested are called, but the GraphQL doesn't respond.
Any ideas?
Thanks

I too am trying to implement webflux based application using below dependency as showing in the sample : https://github.com/graphql-java-kickstart/samples/tree/master/spring-boot-webflux
The query "hello" is returning the toString() value of Mono and not the String that Mono is holding:

Would appreciate any sample/pointer on using webflux with GraphQL,.

@SJ052020 those type of questions are more suited for Stack Overflow than here. In this git repo we address bugs, feature requests, improvements etc.


iOS 9 Issue: Unexpected CFBundleExecutable Key

Getting this issue when trying to build for iOS 9 with the newest XCode.
I've tried installing the newest version of the plugin to make sure.

Disable bitcode, and remove the key. Check http://stackoverflow.com/questions/32096130/unexpected-cfbundleexecutable-key

Removing the plist entry for that specific problem will fix the issue. Google has fixed this in SDK Version 1.10.2, we're on 1.9.2. Will see how I can update this.

Updated Plugin to 1.3.0, which includes iOS SDK 1.10.2
Please read README.
In order to install the new version, you have to:
1) Delete plugin
> cordova plugin rm plugin.google.maps

2) Delete Google Maps iOS SDK
> cordova plugin rm plugin.google.maps

3) Re-Install plugin from master (follow wiki for Mac/Linux/Windows)
> cordova plugin add https://github.com/wf9a5m75/phonegap-googlemaps-plugin --variable API_KEY_FOR_ANDROID="YOUR_KEY" --variable API_KEY_FOR_IOS="YOUR_KEY"

FYI: While uploading the App to itunesconnect this Error is still in the newest plugin version. But just the Unexpected CFBundleExecutable Key. Delete the entry fixed the problem....

This is a google issue, which was fixed in 1.11.1, which was released today. Will update tomorrow

Master will grab SDK 1.11.1 now - which will fix the problems.
$> cordova plugin rm plugin.google.maps
$> cordova plugin rm com.googlemaps.ios
reinstall...


Hyperparameters to tune?

Hi,
Thanks for your amazing work!
I'm trying to use your code for a small project I'm working on, trying to detect scene endings in sports.
I have a decent size dataset, yet I can't get past the 80% F1 score.
I was wondering, what model hyperparameters would you suggest I try playing with?
Thank you so much!

Also, is there a way to track my validation F1 score during training?

I would suggest focusing on the training data - the most important aspect. You may need to generate additional scenes artificially.
With respect to the validation metrics... feel free to update the code to track whatever you need:)


Not available in vscodium by default

I love the sweet themes you make but it is not currently available on vscodium by default.
Would you consider publishing it to the Open VSX Registry?

pls

please do it 🙏🙏🙏

+1

I added sweet-vscode and sweet-vscode-icons to Open-VSX, so they are now both available in VSCodium, feel free to check it out!
https://open-vsx.org/extension/Letgamer/sweet-vscode-icons
https://open-vsx.org/extension/Letgamer/sweet-vscode
https://github.com/Letgamer/sweet-vscode
https://github.com/Letgamer/sweet-vscode-icons
@stepanzak @roudra-das @Alex-Anev @forlornidealist @HugoGranstrom @Kevadroz


Browsing a repository throws DNU versionFor:

Iceberg throws a DNU when we select a repository. IceRepository>>doesNotUnderstand: versionFor:
To reproduce:

take a fresh pharo 6 image
evaluate

Metacello new
    repository: 'github://demarey/cargo/repository';
    baseline: 'Cargo';
    load: 'tests'.

Metacello new
  baseline: 'Iceberg';
  repository: 'github://npasserini/iceberg:master';
  load.

then run Iceberg and add a repository (clone git@github.com:demarey/cargo with subdirectory repository).
you will see a red box with the error in the package view

I think is not there anymore (I cannot reproduce it)


xpdf buttons aren't coded

Some of the handlers for the xpdf buttons aren't included.  Example:  The open button handler isn't present.


Why do I start a blog | Karobben blog

https://karobben.github.io/Others/Whyblog.html

Enjoy~

Comma separated before:
P1 "and WPS"
P4 "because, you know" -> as you know
Insert "And"  before:
P3 "what vs is"
P5 worse -> worset
P5, recompose the end sentence
P6 white paper -> blank paper


Client Allocation Request for: Eliovp!

Client Allocation Questions
Core Information

Name: Eliovp
Website / Social Media: Eliovp / Filecoin.be
DataCap Requested: 10TiB
Addresses to be Notarized: f3uzckly5va5fxwww3h6qmkj7yuys3umkv4m6jf5el3wv64gugw3aw5eoejmojykkfqijv7giumjk3c7erb7dq

So what's going on here?
Requested datacap more than 2 weeks ago, no reply whatsoever.
Why are there certain parties receiving weekly datacap or more?
Is this a political program?

@Eliovp - as discussed on Slack, @philippbanhardt is not accepting applications for DataCap at the moment. Would suggest reaching out to different notaries. Thanks!


Fix AppVeyor CI

It’s been broken for a few days.
You can look at CI failures in all recent PRs and try to figure out what happened.

The lerna team mentioned there may be async contention issues on Windows, maybe we can try setting the concurrency flag to 1 for AppVeyor.

@Timer, setting concurrency to 1 didn't fix the issue (#1868)

You set the concurrency for AppVeyor, the flag I was referring to was a flag you need to pass to Lerna itself. 😄

Sorry, my bad! Added the concurrency flag to Lerna commands. Will check if this fixes the AppVeyor issue, if yes, will add logic to enable this flag only on AppVeyor to avoid unnecessary slowdowns otherwise.

Setting concurrency to 1 on Lerna still didn't fix the issue unfortunately

I believe it may have fixed the erratic failures, but the curl is not found is a new error.

Looks like it's a known problem, AppVeyor updated Git and this regressed, see https://github.com/appveyor/ci/issues/1426.

Great job nailing it down.

Unfortunately that is just for the master branch, 0.9.x is still failing.

Can we cherry pick the same fix there?

I actually cherry-picked the fix from 0.9.x. There is something else going on in that branch.

Let's keep it open for now then

This issue has been fixed by https://github.com/facebookincubator/create-react-app/pull/1876 and https://github.com/facebookincubator/create-react-app/pull/1868.

Perfect! Any remaining issues are due to lerna bugs which are less present on VS2017 image.
Can you keep us posted for when they fix the curl path issue? Thanks!
I want to close this since further improvement is unactionable by us (unless if we switch from lerna bootstrap to a lerna exec npm install with concurrency 1 then bootstrap).
I just want to make sure the lerna team is aware of this issue. I believe they are. Could you double check for me? I'm tied up for a few days.

As for the curl path issue, I'll keep an eye on this.
As for the Lerna issue, it seems that there are some issues open already but all are mentioning yarn. The failing builds were all using npm, and all failed at the same exact place. Opened issue https://github.com/lerna/lerna/issues/716 on the Lerna repo.
It might also just be a memory issue as mentioned in https://github.com/lerna/lerna/issues/338.
In the meantime, take a look at this commit https://github.com/darrenscerri/create-react-app/commit/564eee5ed24659ef046530ef797007804ec02eee. There's a script that adds the concurrency=1 flag in lerna.json just for AppVeyor. Let me know if this might be worth merging.

If that consistently fixes the problem it may be worth implementing in a slightly different way. We should handle it in the e2e test files (sh), not as a node script.

I will run the build multiple times to confirm that it consistently fixes the problem and will report back.
Check out the latest commit https://github.com/darrenscerri/create-react-app/commit/19cda22c594a645aeadd07b801374fc59e6e1356. I moved the script in the tasks directory.
Since this is AppVeyor-specific, I don't agree with putting this logic in the e2e sh files when AppVeyor provides a hook to execute arbitrary commands before the build. Otherwise we would have to add conditional logic in the shell script to check whether we are inside an AppVeyor environment. And it will be quite overkill and inappropriate to use a shell script to modify a JSON file.

Seems like it’s fine now.


Added: GCSArgumentSetter

cherypick-release-0.15-gcs-argument-setter
Jira Ticket: https://issues.cask.co/browse/PLUGIN-168
Cherypick of: https://github.com/data-integrations/google-cloud/pull/262

we should wait for https://github.com/data-integrations/google-cloud/pull/314 to be merged


index 0 is out of bounds for axis 0 with size 0

Could you tell me how to fix this problem? thanks
if: Expression Syntax.
then: Command not found.
2018-10-01 08-21-52 salt-detection >>> creating metadata
neptune: Executing in Offline Mode.
0%|          | 0/2 [00:00<?, ?it/s]
Traceback (most recent call last):
File "/ddn/home/kaggle/salt_identification/main.py", line 770, in
prepare_metadata()
File "/ddn/home/kaggle/salt_identification/main.py", line 351, in prepare_metadata
depths_filepath=PARAMS.depths_filepath
File "/ddn/home/kaggle/salt_identification/common_blocks/utils.py", line 134, in generate_metadata
depth = depths[depths['id'] == image_id]['z'].values[0]
IndexError: index 0 is out of bounds for axis 0 with size 0

Hi there @OsloAI and sorry for late response.
It seems that you are pointing to an empty directory of images in your neptune.yaml:
parameters:
  # Data Paths
  train_images_dir: PATH/TO/YOUR/salt/data/train
  test_images_dir:  PATH/TO/YOUR/salt/data/test

Make sure that those two paths are correct.


Flashing pre-compiled hex file

Hi RCayre,
I flashed the nRF52840 Dongle with pca10059.hex using nRF Programmer app.
The dongle was detected by my virtual box as below.

It seemed correct because the dongle changed its name to "Mirage Toolkit [0001]".
But when I used "lsusb" to show info about the dongle, it didn't display "Mirage Toolkit ButteRFly".

Was there something wrong?

Hi, I'm sorry, I'm not familiar with this kind of setup, I can't tell you if this behaviour is normal or not in a virtual machine.
Did you try to run Mirage ? Is the dongle detected and functional ? Can you provide me the output of sudo mirage ble_info INTERFACE=butterfly0 ?

Hi RCayre,
Sorry for the late reply. Here is the screenshot.

Hi, everything looks fine on your screenshot, it means that Mirage is able to interact with the dongle.
You should be able to run the various supported modules, the missing name is probably a weird bug linked to your VM setup.
I close the issue for now, let me know if you encounter any issues.


gmtp: pass --datapath in the wrapper

Motivation for this change
Some icons (locales maybe too...?) are missing. Seems like a minor change that could perhaps be included in 18.03 as well?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

Success on x86_64-linux (full log)
Attempted: gmtp
Partial log (click to expand)
make[1]: Leaving directory '/tmp/nix-build-gmtp-1.3.11.drv-0/gmtp-1.3.11'
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin/gmtp
shrinking RPATHs of ELF executables and libraries in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11
shrinking /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin/.gmtp-wrapped
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11/bin
patching script interpreter paths in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11
checking for references to /tmp/nix-build-gmtp-1.3.11.drv-0 in /nix/store/m5ir8jnyjhfjsjl1zzlw15v7p87n1gdd-gmtp-1.3.11...

Failure on aarch64-linux (full log)
Attempted: gmtp
Partial log (click to expand)
   Compiling rustc_allocator v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_allocator)
   Compiling rustc_mir v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_mir)
   Compiling rustc_lint v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_lint)
   Compiling rustc_passes v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_passes)
building of '/nix/store/whsyh46wr0zfkw420xcc8ffgahszsd80-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/nfjkyviyyy9ly6hq1pj5wzy6qxmd491n-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bbqaq71xj30lggbbbf6calm3g7g56c02-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0hjhsl89xb2yh8m4w00jk2jg1kbqhjzs-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lk0hcjg8zmd5ckh5ldhg76jrva97inb9-gmtp-1.3.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lk0hcjg8zmd5ckh5ldhg76jrva97inb9-gmtp-1.3.11.drv' failed


Java process still using Liberty files after installing features on Windows

Clone the gradle branch of https://github.com/OpenLiberty/demo-devmode
Run gradle installFeature
Run gradle clean

The following error occurs:
Execution failed for task ':clean'.
> java.io.IOException: Unable to delete directory 'C:\Users\Eric\git\demo-devmode\build'
    Failed to delete some children. This might happen because a process has files open or has its working directory set in the target directory.
    - C:\Users\Eric\git\demo-devmode\build\wlp\dev\api\spec\com.ibm.websphere.javaee.jsonp.1.0_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\dev\api\spec
    - C:\Users\Eric\git\demo-devmode\build\wlp\dev\api
    - C:\Users\Eric\git\demo-devmode\build\wlp\dev
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.config_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.crypto.passwordutil_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.install.map_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.install_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.kernel.boot_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.kernel.feature_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.kernel.service_1.3.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.logging_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.org.apache.aries.util_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.org.eclipse.equinox.metatype_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.org.glassfish.json.1.0_1.0.35.jar
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib\com.ibm.ws.product.utility_1.0.35.jar
    - and more ...
    New files were found. This might happen because a process is still writing to the target directory.
    - C:\Users\Eric\git\demo-devmode\build\wlp
    - C:\Users\Eric\git\demo-devmode\build\wlp\lib

The build directory cannot be deleted until you manually end the Java process using Windows Task Manager.
Environment info:

Windows 10 (the issue does not occur on Mac)
Happens in both Gradle 5.6.4 and 6.0.1.
java -version:

openjdk version "1.8.0_232"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)

There is a resource leak in the URLClassLoader used in ci.common's InstallFeatureUtil which I tried to fix here https://github.com/ericglau/ci.common/tree/filelock-try2 , but the issue still occurs.  A similar resource leak occurs in Open Liberty's InstallMap class at https://github.com/OpenLiberty/open-liberty/blob/b06d50f7a356766796ccdd08be19cee940b5a626/dev/com.ibm.ws.install.map/src/com/ibm/ws/install/map/InstallMap.java#L543

Opened an issue in Open Liberty: https://github.com/OpenLiberty/open-liberty/issues/10178

Closed this issue for ci.gradle, but the issue will still be apparent until a newer Liberty version is released that includes the fix for https://github.com/OpenLiberty/open-liberty/issues/10178


Secrets Management Proposal

This PR adds a proposal for an improved secrets management architecture to address both application and client secrets (resolves #99).
I liked the structure @RickHawesUSDS created for the Auth Proposal in #273, so I followed that structure for this proposal. I also took feedback from our engineering sync on 1/11 and made some changes.
What to Focus on When Reviewing

Does the overall proposal make sense?
Are there aspects of the proposal where it's not clear the work that will be done from a high level?
Am I using the correct and consistent terminology for what we call things in the Data Hub?
Do I adequately address the technical requirements in the proposal?
Do I adequately address security concerns in the proposal?
Do I adequately address auditing concerns in the proposal?
Any thoughts on encrypting the secrets with an HSM key before storing them in Azure's Key Vault? Additional details below...

HSM Keys in Azure
I'm having a hard time understanding if Azure's premium tier of the Key Vault is encrypting secrets using a hardware key or a software key. I've been unable to find any white papers on their Key Vault implementation and their phrasing is confusing regarding the premium tier:

Azure Key Vaults may be either software-protected or, with the Azure Key Vault Premium tier, hardware-protected by hardware security modules (HSMs). Software-protected keys, secrets, and certificates are safeguarded by Azure, using industry-standard algorithms and key lengths. For situations where you require added assurance, you can import or generate keys in HSMs that never leave the HSM boundary. Azure Key Vault uses nCipher HSMs, which are Federal Information Processing Standards (FIPS) 140-2 Level 2 validated. You can use nCipher tools to move a key from your HSM to Azure Key Vault.

The phrasing does not specifically address if secrets in Key Vault use HSM or if they fall under the software-protected keys. The Azure console and APIs do not provide the option to specify a key used for secret encryption, so if they are using an HSM key for secrets, key management is abstracted away, as the documentation makes clear:

All secrets in your Key Vault are stored encrypted. This encryption is transparent, and requires no action from the user. The Azure Key Vault service encrypts your secrets when you add them, and decrypts them automatically when you read them. The encryption key is unique to each key vault.

Furthermore, there is a line in the secret management overview that basically says for added security you should do your own encryption:

For highly sensitive data, clients should consider additional layers of protection for data. Encrypting data using a separate protection key prior to storage in Key Vault is one example.

There is also this line on the pricing page, regarding secrets:

Finally, Azure Key Vault is designed so that Microsoft does not see or extract your data.
Secrets are data (under 10_KB) such as passwords or .PFX files that your application can store and retrieve in plaintext. The Key Vault service persists secrets encrypted using an HSM-backed key, and provides an access control layer over them.

So, what I'm thinking is happening is all secrets are encrypted using Azure's own HSM regardless of tier.
Assuming secrets are encrypted using an HSM, what I'm debating from a security standpoint is Azure's line about doing our own encrypting prior to storing them in Key Vault. If we encrypt secrets prior to storage with an HSM, how can we do that in a way that reduces or removes an attack vector?
If someone (either external or an internal actor) compromises the Azure Key Vault data store, they only have the encrypted data. They would still need the key. If they were able to further compromise the Azure system to get access to the keys, at that point, have they not fully compromised the Azure infrastructure that they would be at risk of gaining access to the HSM we used to encrypt the secrets anyway?
My thinking is the only benefit to doing our own encryption with an Azure Key Vault HSM is if we are storing secrets outside of Azure's Key Vault, such as in our database. Beyond that, if we wanted to encrypt with an HSM prior to storing in Key Vault, we would need to do so with an HSM outside the boundary of Azure, so if Azure is compromised, our HSM would not be compromised as well.
Thoughts on my understanding of Azure's HSMs?
Next Steps Once Approved

@ronaldheft-usds to break up this proposal into tickets
@ronaldheft-usds to start on the local portion of secrets management, as he does not have access to the Azure environment yet

Just pushed a change. Fixed some typos and added some additional details around HSM use and how we will enable auditing of secrets access.

Just pushed a change. Fixed some typos and added some additional details around HSM use and how we will enable auditing of secrets access.

Thanks for this work Ron. Look's good enough to proceed.

Thanks for this work Ron. Look's good enough to proceed.


typo: winevt debug messages had type INFO

Someone just had a copy-pasta error.

It doesn't appear that Win32::EventLog has a DEBUG_TYPE - https://github.com/djberg96/win32-eventlog/blob/ffi2/lib/win32/eventlog.rb

Oh frell... it doesn't exist in Windows. Really?  https://msdn.microsoft.com/en-us/library/windows/desktop/aa363679(v=vs.85).aspx
sigh


feat: builds json field and updates code field editor

Description
Adds new JSON field type (using monaco editor) and updates the existing code field.
NOTE: The JSON field schema is currently set to object (src/bin/generateTypes.ts and src/fields/config/schema.ts), need to discuss the correct way to set this.

[X] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Looks like we could remove some deps here:

react-simple-code-editor
prismjs (and @types/prismjs)

Looks like the docs will need to be updated as well, they call out both of these packages currently.


Add some quick documentation for debug()

Thanks, perfect timing. This was one of the blockers for release.


Indicate number of to-dos in calendar view

Currently, the dots in the calendar view denote the number of words in the corresponding daily notes. Is it possible to somehow show the number of uncompleted to-dos within a daily note? For instance, if there are three uncompleted to-dos, which can be denoted by something like [ ] or #ToDo, within a daily note, then there would be two circles corresponding to that day in the calendar view.
The menubar calendar Itsycal uses this method to show the number of events on a specific day:
https://github.com/sfsam/Itsycal

Thanks for the itsycal reference, haven't heard of it before!

First, just wanted to confirm that you're running a newer version of the calendar. In version 1.3.0+, a hollow dot should appear on days that have incomplete tasks (- [ ] or * [ ]). It doesn't show a number but it does give you some indication.
As for adding the number, I like this idea and it's something I've been thinking about for a while. In an attempt to keep the UI minimal, I chose to make the Hollow Dot binary - either you have incomplete TODOs for that day or you don't.
Reason being: Dots don't scale well (it's common to have a lot of TODOs for a day) and each day already has a number on it so showing more numbers looks visually cuttered/confusing.
I'll revisit this again when I have a clear picture for what I want it to look like going forward. It's a tough UI challenge that I want to get right.

With the latest version of the plugin, now I see the hollow dot indicating to-dos. This is cool!
I totally understand the UI concern. To not make the UI too confusing, could a number indicating the number of completed/uncompleted to-dos be an option? For instance, below a certain day, there are dots showing the number of words; above a certain day, the number of to-dos may be indicated with something like [5] (or the rendered rectangle with the number 5 inside), meaning that the number of uncompleted to-dos is 5 for that day.

To not make the UI too confusing, could a number indicating the number of completed/uncompleted to-dos be an option?

Totally. I can see the calendar evolving more towards that (i.e. A Task Management companion). I'll give this some more thought. Thanks for the ideas!
In the meantime, play around with the hollow dots and let me know if you have any thoughts~ I personally have found it helpful to just know "there are incomplete todos for Day X" even without seeing an exact number. So I'm interested in hearing more about your workflow.


Bug in FreeType lib for certain fonts

There's a bug in FreeType lib that manifests only for certain fonts:
https://github.com/axmolengine/axmol/blob/d8343ea6ad914790c6cedc2b31661dba65771f6b/3rdparty/freetype/src/sfnt/sfobjs.c#L1357-L1365
face->os2.fsSelection & 128 should be face->os2.fsSelection & 64. Even the comment says it should test bit 7, but it's testing bit 8. This sets wrong font ascender, descender and height.
I'll raise the issue with FreeType devs, but we should fix it locally too.
Issue on FreeType repo: https://gitlab.freedesktop.org/freetype/freetype/-/issues/1286

Nevermind, the code is correct, since the bits start counting from 0...


Add "like" features for blog posts

It will be a great enhancement if we add a like post feature to the site.
It will be better if we do asynchronous with javascript.
To store the likes count in the database we will add "post_likes_count" to the 'posts' table. Make a query according to that.
For  more queries feel free to ask,
Thank you! Keep Contributing.

Hello, can i work on this ?

Yes go ahead @kristonela


Fix GQL 2.0 Schema Resolve Bug

After updating to the latest GQL 2.0 gem we've run into a bug
where dynamic field types such as Unions cannot be resolved
correctly.  This is because the resolve_type method on the
schema class returns a two element array / tuple where the first
element is the type and the second element is the value.
This code hooks into this possibility and correctly initializes
the object so that that the GraphQL::Decorate::TypeAttributes
can wrap it.

👍


add application component name duplication check in webhook

Fixes #1703
Add the repeat verification of application component names to the webhook to compare with the existing application, but will not compare with the component resources created by no applications.

LGTM


Update Blade Ally Effects

Closes #2867
Adds Critical Specialization Rule Elements to Effect: Blade Ally x
Update ChoiceSet with "flag":"weaponSelect"
Updated all REs to use new flag.
Update Effect: Blade Ally Disrupting Rune note RE
Update several REs to predicate on correct traits (evil, good etc.)

:blush:


Issue 17066

Fixed #17066 it used the box-shadow mixin for the outline, thus the box-shadow was not enabled when the $enable-shadows global was set to false.

Hi @cornedor!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

The CNAME file should never be modified.
Changes must be made to the original Sass or Less source code file(s), not just the compiled CSS file(s).
Changes must be made to the original JS source code file(s), not just the generated concatenated JS file(s).

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)


BUG - Attributes with default values should be populated

When creating a new config section ( DataNodeConfig , TaskConfig, ... ), The attributes with a default value (in the schema) must be automatically populated with the default value in Studio Config Builder.
Related question:
This means all attributes with a default value automatically appear on Studio when creating a section.
Do we want to add more attributes (like function for TaskConfig, that have no default value)?

For now, Studio-config defines the list of properties added when a new element is created.
the default value is also proposed when adding a property to an element


Add distribute nodes for storage notes

To prevent single node failure, we should have the ability to expand notes service to mutiple storage nodes.
and easier to switchy between the node.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This may be an enterprise feature.


Web additions: ogv and jar

What does this PR do? Please provide some context
adding ogv video and jar archive to the gitattributes for web.
Where should the reviewer start?
n/a. Short review.
How can this be manually tested? (brief repro steps)
Using the gitattributes in a project with ogv or jar files. For example,

clone https://github.com/edx/edx-platform
replace the gitattribute file
follow instructions from https://help.github.com/articles/dealing-with-line-endings/#refreshing-a-repository-after-changing-line-endings

What are the relevant Github Issue Number(s)? (or Jira, TFS, etc)
N/a.

Thanks!


Hello,
I don't think chmod natively exist on Windows (example it doesn't on Powershell).

Hello,
I don't think chmod natively exist on Windows (example it doesn't on Powershell).

Yeah, I'll get rid of it as it's required only on *NIX systems.

Thanks Umair! @allcontributors add @umairhm for infra


Workaround to make django-constance work in multi-DB project

This is an attempt to fix the issue described in #210. What this PR does is add a CONSTANCE_DBS setting to the Django settings file. This is an interable that says which databases should be affected by the django-constance post-migration signals.
Not sure if this is the best way to fix this, but it seems to work for me ¯\_(ツ)_/¯
Totally open to better name suggestions than CONSTANCE_DBS :+1:

Thank you


OIDC with wikijs report "invalid email / username or password"

I added the OIDC of Casdoor using the authenticator on Wikijs, and the email claim field was filled in as 'email'
When I log in with the username or email in casdoor, it prompts Invalid email/username or password. How do I adjust it

@sunyajie0829 is password correct? You can check the "User" table in Casdoor DB

yeah,the password is wrong.
but after i set correct password,after redirect,wikijs says 'oops,something went wrong,you are not authorized to login'

@sunyajie0829 can you try to connect wikijs with other SSO solutions like Keycloak or Okta or Auth0?

close

@sunyajie0829 why close?


Design ActiveServices Interface

Description
The interface name may change during design, but this will take the v2.config and a list of all plugins (from AllAvailablePlugins defined in #878), and return instances of all ProxyService instances that need to be started (it instantiates the objects but doesn't call the Run method on them).  The code in #853 will be written to invoke ActiveServices to get the list of proxy services to start and then actually start them.
This may be just a simple function.  TBD during design.
AC:

[ ] The final ActiveServices Interface or function signature.
[ ] There is a test for activeservice to ensure that only http connectors are allowed to listen on the same socket

I think we will not be needing this as a separate interface after all.   The logic will exist in Secretless.

Should this issue be closed?


Current release breaks Jest + JSDOM testing

This is already fixed in canary but it isn't possible to create Jest tests for components that use Stitches right now because this change isn't released yet:
https://github.com/modulz/stitches/commit/3fe265d8e97accfdbc27734fec2bc2af03a1f74d#diff-9731eac31947a9ee3816b17a76ad0bad
ownerNode isn't implemented correctly in JSDOM, which means that the __variables__ sheet isn't created and causes all tests to fail at this line.

Maybe I shouln't have closed the issue yet 😂 but yes, this is a duplicate of https://github.com/modulz/stitches/issues/137, it is working in canary and should (🤞) be released on Monday 💪

This is fixed in 0.0.2
Thanks!


Laravel 11 support

Laravel 11 has been released (https://laravel-news.com/laravel-11). Unfortunately, this package does not currently support it. Please add support for Laravel 11. Thank you!

On it!


Show active tab in main menu

I presume you're just looking for an indicator like the text being highlighted when one is on a specific tab, like here in the storage service listings?

Yes, exactly. Some Bootstrap/jQuery tweaking needed here.

Added PR for this: https://github.com/artefactual-labs/AIPscan/pull/220

PR merged!


cleanup to preprocessing

          nit: already in the `iree_compiler` namespace, can simplify this?

    : public Preprocessing::impl::ApplyPDLLPatternsPassBase<

I see a bunch of these public iree_compiler:: in the Preprocessing/ folder, could clean those up too (in a separate PR to keep this one focused)
Originally posted by ScottTodd in https://github.com/iree-org/iree/pull/17144#discussion_r1578436244

Would be good cleanup! The style we hold is that iree_compiler can be omitted because all IREE code is in it, and then any dialect references require explicit specification (so "IREE::Flow::TensorReshapeOp", not "iree_compiler::IREE::Flow::TensorReshapeOp", "Flow::TensorReshapeOp", any using namespace of IREE-prefixed namespaces, etc). I've been trying to clean some of these up as I find them but more help would be appreciated!


How to make link as bold

Markwon version: 4.6.2

Expected Behaviour- Make link as bold only in markdown text
Currently after applying bold whole markdown text is becoming bold

Text

Is there any way to make it using code. I have a text from BE that doesn't have this format for links

I got it. Thanks. I believe this is the right approach.


Using IAM client to retrieve policy document?

In Java blue print,
public Map<String, Object> getPolicyDocument() {}
I am wondering if retrieving policy document using IAM sdk would be easy option? why is it not preferred here?
For example AmazonIdentityManagementClient.GetRolePolicyResult() .getPolicyDocument()

Authorizers are not related to IAM. Consumers can store policies wherever they want; hard code, in a database, whatever.
IAM policies are associated with IAM users/roles. Authorizers allow customers to use other authentication methods besides IAM.


publish<EMAIL_ADDRESS>

Requested by: @bmckerry
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).
Targets

[ ] github
[ ] pypi
[ ] sentry-pypi

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

#retract


refactor(*): remove unneeded async and result on parse_error

Rationale for this change

No need for parse_error to be async
No need to return a Result

What changes are included in this PR?
removes unneeded async and Result from parse_error()
improve encapsulation of parse_error
Are there any user-facing changes?
No

@Xuanwo this is the continuation from https://github.com/apache/opendal/pull/5128.
Turns out it was more changes than I thought, sorry for any rebase headaches.
Review and merge when the time is right :+1: .


Import RuleDetails from @redhat-cloud-services/frontend-components-advisor-components

TBA

Codecov Report

Merging #227 (ac1a128) into master (4431d92) will increase coverage by 2.53%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   80.16%   82.70%   +2.53%
==========================================
  Files          27       24       -3
  Lines         983      925      -58
  Branches      364      331      -33
==========================================
- Hits          788      765      -23
+ Misses        195      160      -35

Impacted Files
Coverage Δ

src/Components/RecsListTable/RecsListTable.js
74.38% <ø> (ø)

src/Utilities/intlHelper.js
91.66% <85.71%> (-8.34%)
:arrow_down:

src/Components/RuleDetailsLocal/RuleRating.js

src/Components/RuleDetailsLocal/RuleDetails.js

src/Components/Recommendation/RuleDetails.js

src/Utilities/Rule.js
100.00% <0.00%> (+70.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4431d92...ac1a128. Read the comment docs.

:tada: This PR is included in version 1.3.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Travis-ci: added support for ppc64le build along with amd64

Hi,
I have added support for ppc64le build on travis-ci in the branch . The travis-ci build log can be tracked on the link :https://travis-ci.com/github/sanjaymsh/djoser/builds/186542267 . I believe it is ready for the final review and merge.
Please have a look on it and if everything looks fine for you then please approve it for merge.
Thanks !!

How exactly is this beneficial for a project that does not require compilation?

Hi @dekoza This package is included in the distros for ppc64le - we are trying to make sure that integration into the distros is pain free by making sure they have a clean bill of health from their development community. This simplifies the integration process for ppc64le based distros.So it may require in future.
Thanks !!

@sanjaymsh but we use Travis only to run the tests, not to build anything. Python packages that don't use specialized C-compiled components are generally distributed as noarch packages. I'm sorry but this is a first time I have encountered such request and I want to understand the subject :slightly_smiling_face:
@haxoza I will need your opinion on this topic.

@dekoza understand and appreciate you inputs here, thanks!
I think @sanjaymsh 's intention here is to make sure that we are running the full test suites on Power so that we are sure that what is included in the distro has been fully tested and continues to be, not necessarily to re-use the builds from here. It shouldn't take much in terms of investment to enable this for Power as the Travis service is free and I don't expect any maintenance overhead.
I do agree that if this is all pure python code with no native code or dependencies (and never shall have any) , then it may not be very useful to test it on all architectures, but then we have hit a few cases in the past where we ran into issues originating from failures in the dependencies rather than the main package itself, so may still be good to catch those early.
Thoughts?

@seth-priya thanks for the insight, I really appreciate that.
Right now I can think of one good reason that prevents me from merging this PR. Suppose we add a dependency that will fail only on Power for some reason. This way Travis would report a faulty test pass. Additional configuration would be required to ignore those tests and that would contradict the essence of testing. Plus that would make our team responsible for escalating the problem to original culprit so that our tests could pass again.
On the other hand if the people packaging djoser for a Power-based distribution would find the failure during tests on their side (specific for the architecture), they could escalate the issue to the original culprit.
In other words: if djoser required compilation, I'd gladly add tests for all platforms possible. But since we don't do that, I'm hesitant.

Thank you all for extensive comments.
I totally agree with @dekoza, we should not take the responsibility of maintenance any particular architecture since we are pure Python package.

We won't add it. This is pure-Python package and we don't want to take responsibility for maintaining what should be taken care of either upstream or downstream.


Direct dependency is incorrectly treated as indirect dependency

We incorrectly treat numpy as a transitive instead of a direct dependency, which means we don't emit the correct diagnostic about a missing lower bound:
[project]
name = "dummy"
version = "0.1.0"
description = "Add your description here"
requires-python = ">=3.9"
dependencies = [
  "numpy",
]

Relevant log line from RUST_LOG=uv=debug uv lock:
DEBUG Adding transitive dependency for dummy==0.1.0: numpy*

We need to change this check to consider workspace packages:
https://github.com/astral-sh/uv/blob/30e11c6debf2ceb53710fdfbafcb87c6d478aa1b/crates/uv-resolver/src/resolver/mod.rs#L2163

I was trying to reproduce this issue using posted pyproject.toml file but seems it's working as expected:
uv/target/debug/uv pip compile example/pyproject.toml -o example/requirements.txt
...

DEBUG Adding direct dependency: numpy*
INFO add_decision: example @ 0a0.dev0

Try using uv lock instead of uv pip compile.

I am setting this type of diagnostic message,

Is this the required behavior or somethingelse

We should treat numpy as a direct dependency here, which means we should show the The direct dependency {package} is unpinned. message here for numpy: We should have an additional check that the for_package isn't a workspace member.

How should I check if it's a workspace member? Should I need to explicitly define that these are the workspace members or something else?

ResolverState::workspace_members has this information


Add supoort for BF.INSERT operation

Hey really excited to see the module in golang finally.
But was going to use it in my project but couldn't find the INSERT command which I wanted  to use.
Would be great if you could add that or I might take that up if required

Hi there @ms10398, thank you for the message. Do you want to kick off the support of BF.INSERT it and we review/push it with you?

Sure @filipecosta90 I would love to do it would be sending off the PR by tomorrow

@ms10398 Hi~ Are you still flow this issue?

Yes sorry got stuck up in lot of stuff will send off a PR today/tomorrow

@filipecosta90 @dengliming can you guys go ahead was stuck with some issues

@ms10398 Please feel free to submit a PR.

@ms10398 May I ask if you will continue this PR. If not, I will submit it by the way.

@dengliming can you please go forward as suggested by the above comment

@ms10398 Sure. Will submit the PR today later. And Welcome to share your opinion. : )

hi there @ms10398, #21 added BF.INSERT support. Thank you guys for raising this up and thank @dengliming for opening the PR with the fix :+1:


Passing a state that contains a semicolon

I want to preserve the requested URL by passing a state as described in the docs, but it fails for URLs that use matrix notation, e.g.:
this.oauthService.initImplicitFlow('/heroes;id=15;foo=foo');

tryLogin() splits the state on the semicolon character.  Even using encodeURIComponent() isn't a solution because the method automatically decodes the URI component.
Maybe an option passed into tryLogin() like tryLogin({parseStateNonce: false}) could solve this issue?

Thx for pointing this out. The next version which will be released soon will take care about this.


async tasks info, gcloud update no longer need with 244+

While the bootstrap script runs it may look frozen at this step:
To take a quick anonymous survey, run:
  $ gcloud alpha survey

Added messaging that it may not be stuck.

thanks @agmsb for the gcloud 244+ callout


[UpdatePlugin]  atxsinn3r BinjaHLILDump 1.1

Please update my plugin:
Author: atxsinn3r
Repo name: BinjaHLILDump
Release: 1.1
Link: https://github.com/atxsinn3r/BinjaHLILDump/releases/tag/1.1
This update corrects the following:

Filters outs reserved filename characters on Windows. (thanks @tekwizz123)
Ensures file path does not exceed a certain length on Windows.
Ensures string encoding is normalized.

Thanks! Updated.


Thanks for your groundwork

Just wanted to thank you for the groundwork you laid down for us to follow and try out Dinit (even if you aren't anymore).
i have been using what you shared with Dinit v0.18 (beta 3).. i think we are very close to a version 1.x !! Very little has changed (not surprisingly) with the Runit core-services so everything ran out of the box! (i have only been on Dinit a few days :).
i had to change very little of the services you defined -- only the network service to work with my conversion of Runit's sv-netmount service for Dinit (there was a timing issue between the two services causing netmount to not mount my nfs4 shares.. it was a good exercise for me to figure out what was going on and fix it for my usecase).
i found the performance of Dinit to be on par with Runit,the big delay for both system inits being the udev settle. To remove this delay, i moved "udev-settle" to boot.d and removed the "depends-on" dependency in the "console-setup" and "filesystems" services -- this is probably not advisable but appears to work on my system. Boot times to login prompt dropped from 12s to less than 2s -- have only been running this way since this morning but no issues with the many reboot cycles to see if anything breaks.
i've looked at Artix and Chimera. Their Dinit service descriptions appear to be much more granular but i think you nailed it with your balanced logically grouped approach following Void's Runit service organization. Much thanks again.

Thank you for your comment, I'm really pleased to hear that this repository was useful for you. Dinit seems to strike a great balance between features and simplicity, and I found it really easy to learn coming from Runit. Enjoy your Dinit system!


Update who.md

update supporting team

Thank you, your ancestors are proud of you now
Em qua., 31 de jan. de 2024 às 15:02, Artur Corrêa Souza <
@.***> escreveu:

Merged #29 https://github.com/arcstur/iol2024-website/pull/29 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/arcstur/iol2024-website/pull/29#event-11659468377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFXU3K7SG4WDBIPCBRC6AF3YRKBLLAVCNFSM6AAAAABCS72OTCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY2TSNBWHAZTONY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Composite crowdsale (WIP)

to solve crowdsale.js

@fiiiu do you think we can close this issue in favour of the already implemented https://github.com/OpenZeppelin/zeppelin-solidity/issues/739?

@palla, yes, closing this now.
@shakkaist, @jakub-wojciechowski thanks for your contributions! After playing around with many flavors of the models involving inheritance and composition, we reached the solution in #739, published in v1.7.0.


recursive process.nextTick broken in latest io.js and node.js

I'm unsure as to why ncp is not throwing this error, but node is supposed to throw when writing an recursive function that uses process.nexTick.
(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.
It looks like the current implementation found at --> https://github.com/AvianFlu/ncp/blob/master/lib/ncp.js#L55-L61 is blocking the thread... makes me sad.
I'm looking at ways to fix this, but commenting out the three lines that call to defer does stop ncp form breaking on iojs and node 0.12
/cc @AvianFlu

This appears to be a dupe of #79
The broken "modern" check is what is causing this bug as well, since process.nextTick is being used instead of setImmediate


Added coinflip command

Added coinflip command.

What is lint. build and deploy check?

@ItzLukaDev why did you close this?

Yeah i couldn't just get myself to fix it and I lost my will halfway


feat: return object id on object operations

What kind of change does this PR introduce?
feature
What is the current behavior?
currently is not possible to create relationships from the client side to an object because the id is never returned
What is the new behavior?
object id is returned on the following operations:

createObject
copyObject
updateObject

Additional context
Reimplemented this PR. https://github.com/supabase/storage-api/pull/197
One remark, when testing this locally I had problems with RLS. I couldn't insert anything because it always failed with a RLS new row violates row-level security policy for table "objects".
What a problem is, is the RLS. Because by removing the returning: 'minimal'. You need the select permission to insert a file right now.
I don't know if that's a problem?

What is the intent with storing the object id versus just path in your associated tables?  It is true you also have to save bucket name if the bucket is not fixed for your structure and save a bit of database space.  But the cost is you have to read the storage table directly to do any followup storage-api call.
The object id has no operation it can be used for directly.  My fear in dealing with user issues, is that if this is implemented, it further gives users the impression they can just delete the storage.objects row and the associated s3 file data is deleted also.  Which is not the case.

This is now being implemented


[9.x] Introduce MissingAppKeyException for missing APP_KEY

This PR introduces a new MissingAppKeyException.
It offers an easy way to catch this specific error.
I am building an application with an interactive installer and this should be the trigger for the setup.

I think this would best be targetted at 8.x?

We're not gonna merge too much anymore at this point.

Send it to 8.x branch if you want it on 8.


Feature/refactoring broadcast

code refactoring wrt sendEvent and sendBroadcastEvent

@michaelcfine, rebased with main. Kindly approve it again in order to merge it.

rebasing with main requires approval


onnxruntime: fix evaluation with cudaSupport

Description of changes
I don't understand how this slipped in #260745 (great work @autrimpo, tanks!), but my config refused to evaluate after updating pos that PR.
lib.cmakeFeature requires both its arguments to be strings, not derivations. This fixes that.
Things done
(import ./. { config = { allowUnfree = true; cudaSupport = true; }; }).onnxruntime now evaluates.
I'll also test whether it builds on x64 and whether it does anything productive, but that'll take time (and this PR does not change anything about that).

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you for this, you are right! I believe the PR should be targeting the master branch, not sure if it's possible to change it or whether you'll have to make a new PR.

Changing the base should be fairly easy.

Mark this PR as a draft
Change the merge base (See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request)
If the "Reviewers" panel isn't filled with a lot of people and your PR still has just one commit, mark it as ready again

You could rebase this commit too, but I don't think that will be needed when switching from nixos-unstable to master

@autrimpo Yes, should be master! And sorry, I got a bit distracted ...
@Scrumplex Thank you for the detailed instruction!

@NiklasGollenstede @autrimpo @Scrumplex thanks all!

I don't understand how this slipped in https://github.com/NixOS/nixpkgs/pull/260745 (great work @autrimpo, tanks!),

Ah... that's because the cuda variant isn't evaluated by Ofborg. We probably checked the patch manually, updated something, and never rechecked

Yes, I think originally it was only lib.cmakeBool for the cuda flags and then we added the lib.cmakeFeature calls towards the end


Create GHuser profile

I would like to have my profile 👍

here you go :) https://ghuser.io/open-source-explorer


winrt::resume_on_signal() does not timeout immediately for all negative inputs

SUMMARY
winrt::resume_on_signal() does not do an immediate timeout for all negative inputs. This does not match the documented behaviour.
For example:
// Expected: immediate timeout
// Observed: infinite timeout
co_await winrt::resume_on_signal(handle, TimeSpan::min());

// Expected: immediate timeout
// Observed: infinite timeout
co_await winrt::resume_on_signal(handle, -TimeSpan::max());

The code in winrt::resume_on_signal() that converts the timeout for use with SetThreadpoolWaitEx() is incorrect.

DETAILS
The documentation for winrt::resume_on_signal() states that an immediate timeout occurs if a negative timeout is passed as a parameter. However, for many negative timeout values the current implementation behaves as if the timeout were infinite (not zero).
Notation:

now = immediate timeout
never = infinite timeout
later = finite timeout (relative time, some time span after now)
when = absolute timeout (absolute time, independent of now)

The resume_on_signal() function uses the following curious conventions for the timeout parameter:

negative = immediate timeout (now)
zero = infinite timeout (never)
positive =  finite timeout (later)

Internally this function calls SetThreadpoolWaitEx(), which uses the following different curious conventions:

negative = finite timeout (later)
zero = immediate timeout (now)
positive = absolute timeout (when)
null = infinite timeout (never)

Correct Timeout Conversion
The correct way to convert the timeout from resume_on_signal() conventions to SetThreadpoolWaitEx() conventions is therefore:

resume_on_signal -> SetThreadpoolWaitEx
now: negative -> zero
never: zero -> null
later: positive -> negative

Current Timeout Conversion
However, the current resume_on_signal() implementation does this conversion:

resume_on_signal -> SetThreadpoolWaitEx
now negative -> zero positive (when)
never zero -> null
later positive -> negative

Note that when a negative timeout is specified (timeout now), the actual behaviour is an absolute timeout (timeout when). It is then interpreted as an absolute time (in 100ns clock periods since the Win32 FILETIME epoch, 1 January 1601).
In practice this means that timeouts closer to zero than -(2^56) work correctly, but timeouts further from zero than around -(2^57) work incorrectly. This is because 2^56 represents a FILETIME in the distant past (19th century), whereas 2^57 represents a FILETIME in the distant future (mid 21st century).
Depending on the current date/time and system clock, there is a particular bit representation somewhere between -(2^56) and -(2^57) where the current implementation switches from succeeding to failing. The exact value is the negative value of the current system clock measured in 100ns periods since 1601.
0xffffffff'ffffffff = -epsilon           succeeds
0xff000000'00000000 = -epsilon * 2^56    succeeds
0xfe000000'00000000 = -epsilon * 2^57    fails
0x80000000'00000001 = -TimeSpan::max()   fails
0x80000000'00000000 = TimeSpan::min()    fails

where epsilon = ++TimeSpan::zero()

Most importantly, the most convenient timespans for specifying a negative value, namely TimeSpan::min() and -TimeSpan::max(), both behave incorrectly.

POTENTIAL FIX
This issue can be fixed by changing the implementation await_suspend() in the function local struct resume_on_signal()::awaitable.
Current Implementation:
int64_t relative_count = -m_timeout.count();
int64_t* file_time = relative_count != 0 ? &relative_count : nullptr;

Fixed Implementation:
int64_t timeout = m_timeout.count();

int64_t now = 0;
int64_t later = -timeout;
int64_t* never = nullptr;

// Convert timeout from resume_on_signal() conventions to SetThreadpoolWaitEx() conventions.
int64_t* file_time =
    (timeout < 0) ? &now :
    (timeout > 0) ? &later :
    never;

The fixed implementation has been tested locally and winrt::resume_on_signal() appears to behave correctly for all negative inputs tested, including TimeSpan::min() and -TimeSpan::max() and various negated powers of two.
When using the current implementation, an infinite timeout (in practical terms) was observed for TimeSpan::min(), TimeSpan::max() and for values further from zero than -(2^57).

C++/WinRT is built on the Windows thread pool and a zero timeout isn’t supported by the thread pool. For that you can use WaitForSingleObject. I talked about that here:
https://docs.microsoft.com/en-us/archive/msdn-magazine/2011/november/windows-with-c-thread-pool-synchronization

This issue has been discussed and resolved offline (thanks all).
Because the function does not immediately timeout for all negative inputs, the documentation has now been updated to accurately reflect this. It no longer says that an immediate timeout occurs, and now says that behaviour is undefined.
https://docs.microsoft.com/en-us/uwp/cpp-ref-for-winrt/resume-on-signal

timeout An optional timeout value. If you pass a timeout of 0, that's treated as infinite. Behavior is undefined if you pass a negative timeout.

The implementation has been left unchanged to avoid further development/testing costs and introducing backward compatibility issues.


[Feature request] default pdf metadata for generated pdfs

Would it be possible to add a new settings (or environmental variable) to set the pdf metadata for all pdfs generated by S-pdf (i.e Author, Subject, Title Etc.).
You could also set S-pdf as the default Creator/Producer.

Good ideas I was going to make change to correctly maintain metadata for the files edited
Adding custom metadata values for all jobs is a bit awkward api wise I'll have to think about it best way to do it
Also this kind of stuff would get annoying if the localstorage expires
Might have to be part of the userID/accounts update I will be doing
Alternatively this could also be a config file setting

I like the Idea of a config file, but docker environmental variables could also work. I'll leave it with you.


Epic: set up infra for periodic perf tests with bigger databases

Right now we have some infrastructure to run periodic tests, but it needs more love. For some amount of time safekeepers were not capable of automatically deleting WAL, so we avoided big databases as they were causing disk overflow on staging. Now safekeepers can clean their WAL so let's start doing more realistic tests.
As result we want to have the following:

Grafana overview dashboard with one panel for each test -- panel shows each test result as a single number (seconds or transactions) against test competition time.
Links to per-timeline dashboard for each test run.

Approximate steps:

[x] bring existing periodic perf tests to life: https://github.com/neondatabase/neon/pull/2037
[x] update runner (or use k8s runners): https://github.com/neondatabase/neon/pull/2037
[x] put results to s3 instead of git (or it is stored in postgres? -- find out)
[x] increase scale up to 50GB https://github.com/neondatabase/neon/pull/2612
[ ] increase scale up to 300GB
[x] increase run time to a few hours: https://github.com/neondatabase/neon/pull/2077
[x] set up / fix grafana dashboards

https://github.com/neondatabase/neon/issues/2221 is required to continue

during the meeting today @hlinnaka  mentioned that  we're ready  to increase the scale up more towards the 300GB, e.g. 50GB first?

is this still blocked by neondatabase/neon#2221 ?

during the meeting today @hlinnaka mentioned that we're ready to increase the scale up more towards the 300GB, e.g. 50GB first?

I've experemented with pgbench -i, setting up a 50 GB (scale 3424) database took ~ 1h (with enabled prefetch):
------------------------------ Benchmark results -------------------------------
test_pgbench_remote_init[3600-3424].scale: 3424
test_pgbench_remote_init[3600-3424].init.start_timestamp:<PHONE_NUMBER>
test_pgbench_remote_init[3600-3424].init.end_timestamp:<PHONE_NUMBER>
test_pgbench_remote_init[3600-3424].init.duration: 3,778.830 s
test_pgbench_remote_init[3600-3424].init.drop_tables: 0.030 s
test_pgbench_remote_init[3600-3424].init.create_tables: 0.130 s
test_pgbench_remote_init[3600-3424].init.client_side_generate: 1,419.680 s
test_pgbench_remote_init[3600-3424].init.vacuum: 1,607.980 s
test_pgbench_remote_init[3600-3424].init.primary_keys: 750.590 s

https://github.com/neondatabase/neon/actions/runs/3226525705/jobs/5280150287
A couple of clarifying questions:

Should we replace 10GB test with 50GB or run it in addition? We could run them alternately (one day 10GB, next day 50GB)
Currently we don't have 50 GB project for reusing. Should I prepare it?

@hlinnaka what do you think?

is this still blocked by https://github.com/neondatabase/neon/issues/2221 ?

Now with creating projects via API it doesn't really blocked by it.
I believe with increasing db size we could be blocked by https://github.com/neondatabase/cloud/issues/1872

Hey folks, we were trying to deploy neon tech for 10 TB+ data would we need 10 TB storage on the page server ?

this is is Alexander's backlog, still in progress

@bayandin should we just close it and open another issue if something else is needed?

Removing from the infra board as I don't think there is anything for us to do at this time. If I'm mistaken I'd just ask for a concrete action item description so we can follow up on it 🙂

We're tracking multi-TB databases in a separate issue — https://github.com/neondatabase/cloud/issues/14727
This can be closed


support for custom github endpoints

What is this PR for? This PR is to allow customization of the endpoint for github OAuth via the GitHubEndpointURL setting in the config.yml file (or GUS_GITHUB_ENDPOINT_URL env variable)
This fixes #113

Pull Request Test Coverage Report for Build 396

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 12.697%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/handlers/auth/github.go
0
9
0.0%

Totals

Change from base Build 395:
-0.07%

Covered Lines:
161

Relevant Lines:
1268

💛  - Coveralls

This LGTM; @mxschmitt I'll leave the final approval/merge to you.

LGTM, thanks!