Nx.stack(..., axis: 1) on a large dataframe can OOM

I'm having an unexpected issue at work. I have a large dataframe:
DF.shape(df) #=> {15_653_051, 122}

This OOMs:
Nx.stack(df, axis: 1)

but this works:
n_rows = DF.n_rows(df)
num_slices = 10
size_slice = div(n_rows, num_slices)

0..(num_slices)
|> Stream.map(& &1 * size_slice)
|> Stream.map(fn start_index -> DF.slice(df, start_index, size_slice) end)
|> Stream.reject(&(DF.n_rows(&1) == 0))
|> Stream.map(&Nx.stack(&1, axis: 1))
|> Enum.reduce(&Nx.concatenate([&2, &1]))

It surprises me that the bare Nx.stack call consumes so much more memory than breaking apart the computation. Is this expected?
I apologize but I haven't had enough time to dig into the details. Also happy to close and move to the forums, slack, etc if preferred.

That's definitely weird, it should be zero copy. Can you confirm that calling Enum.map(df.names, fn name -> df[name] end) does not cause a big impact on memory? And then what about Enum.map(df.names, fn name -> Series.to_tensor(df[name]) end)? Those should all be light weight references.

@josevalim Yeah both are pretty instant.

That's definitely weird, it should be zero copy.

In this case I do expect some churn. Polars is a column store, and Nx.stack with axis: 1 is effectively doing a transpose.

Which backend are you using? EXLA or BinaryBackend?

Also, can you try Nx.concatenate instead of stack? I just want to rule something out quickly.

BinaryBackend, unfortunately :(
My intention is to pass this to EXGBoost.train, but EXGBoost has some issues with non-binary backends.
I've tried using the EXLA backend -> serializing -> deserializing but that didn't work. (There were many steps to the process so I might've messed something up.)

Oh sorry missed your earlier message.

Also, can you try Nx.concatenate instead of stack? I just want to rule something out quickly.

Will do. I'm already trying this in the background to see if it's Nx or Explorer:
transposed = Nx.stack(df) # worked pretty much instantly
Nx.transpose(transposed)  # currently working hard...

Will try your thing once it's done.

In any case, I think we should make Nx.stack a default callback, so when invoked for EXLA, it does not perform several copies. I will open up a separate issue.

Nx.transpose(transposed) OOM'd.
Nx.concatenate(df) succeeded pretty quickly (though it has shape {1_909_672_222}). Did you want me to pass any options to Nx.concatenate/2?

I guess we can close this. We have optimized concatenate in Nx for the default backend and there is an open issue to optimize stack too.

Agreed!
For posterity, these additions to Nx made stack(..., axis: 1) no longer OOM and take 3.5 mins on my VM:

https://github.com/elixir-nx/nx/commit/3791bdc02f6dd241ea0da552cd25cb6d8ec5bb5a
https://github.com/elixir-nx/nx/commit/5d3a5ee23354a0cc2007d770f4d563e560cb86b2

My work around was taking ~11.5 min, so this is a great improvement.
Further improvements should come from addressing this issue:

https://github.com/elixir-nx/nx/issues/1441


webkitgtk: 2.14.11 -> 2.16.3

Motivation for this change
security fixes: https://webkitgtk.org/security/WSA-2017-0004.html
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Ugh, major versions of WebkitGTK are incompatible with each other AFAIR. I'll try to build this on my machine.

IIRC at least some of the "major" bumps after 2.4 weren't too problematic.

I succeeded in running nox-review wip so let's merge. Thanks!
Closed by https://github.com/NixOS/nixpkgs/commit/3de90b259cfdb2da93fd49c296d1ee5625ead2e1


Separate Cluster Roles and Cluster Role Bindings

What would you like to be added:
Separate Cluster Roles and Cluster Role Bindings from Roles and Role Bindings under "Access Control".
Why is this needed:
For consistency. It is counterintuitive that these are combined today, since they are technically separate resource types.
Environment you are Lens application on:

Kubernetes distribution: EKS 1.16
Desktop OS: macOS 10.15.7

The cluster role and cluster role bindings are lumped together with the role and role bindings, by default the cluster ones are shown at the top. We can consider adding a type column to the listing to help with the distinction.

That seems pretty counterintuitive and inconsistent to me. You should move them into separate items under "Access Control", since they are technically a separate resource type.

Yes, I think that is reasonable. But right now you don't have to switch to the CLI to see them.

I've changed the issue title and description in light of this.


Released versions contain test data

While reviewing some updates to our dependencies I noticed that the last version (3.9.0) of os_info uploaded to crates.io contains unnecessary test data in src/linux/tests. While this is not a problem on it's own it is at least wasteful as these data need not to be there for having a correctly working crate.
Cargo allows to exclude such files via an entry in your Cargo.toml file: https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields
See the diff here: https://diff.rs/os_info/3.8.2/3.9.0/
If you are interested in addressing that I'm happy to contribute a PR for this.

This seems reasonable, thanks for the suggestion! If you want to do that - go ahead, I would be happy if this is addressed.


Add bucketName and bucketRegion to S3Bucket

QQ - what is the use case for this one? :)

I think it's useful in cases where:

you want to log where stuff is going
you have multiple different buckets where things can go and want to keep track of where the thing went


Code cleanup

Refactored and cleaned up code. Did not add/remove functionality. Should have no effect on existing Llama Table implementations.

:+1:


Support for ${configDir} syntax

Since typescript 5.5, it is possible to use the ${configDir} variable inside include/exclude clauses to reference the directory path where the current tsconfig is located, but unfortunately vite-tsconfig-paths does not support this feature yet, so path aliases are not set when using it.
Example
/* tsconfig.base.json */
{
  "include": ["${configDir}/src"],
  "exclude": ["${configDir}/dist", "${configDir}/node_modules"],
}

/* tsconfig.json */
{
  "files": [],
  "references": [
    {
      "path": "./tsconfig.app.json"
    },
    {
      "path": "./tsconfig.vite.json"
    }
  ]
}

/* tsconfig.app.json */
{
  "extends": "./tsconfig.base.json",
  "compilerOptions": {
    "paths": {
      "@components/*": [
        "./src/components/*"
      ],
      /* ... */
    }
  },
  "include": [
    "src"
  ]
}

If I remove the "include": ["src"] at the end of tsconfig.app.json, the path aliases stop working in vite, but it shouldn't since ${configDir)/src expands to ./src

I had the same problem in my monorepo and was forced to fall back to Vite resolve aliases:
Base tsconfig.json:
  "include": [
    "${configDir}/**/*",
     // include hidden files (Example: Remix .server directories or config files)
    "${configDir}/**/.*",
    "${configDir}/**/.*/**/*",
    "${configDir}/**/.*/**/.*"
  ],
...

Local tsconfig.json
  "extends"<EMAIL_ADDRESS>  "compilerOptions": {
    "paths": {
      "@/*": ["./src/plugins/admin/app/*"]
    }
  }

Local vite.config.ts:
import { fileURLToPath, URL } from 'node:url';

export default defineConfig({
......
  resolve: {
    alias: [
      {
        find: '@',
        replacement: fileURLToPath(new URL('./src/plugins/admin/app', import.meta.url)),
      },
    ],
  }
});

Alternative (yet incomplete) solution.  I am only using vitest for a back-end monorepo.  I have several packages with multiple aliases (all declared globally in a base tsconfig).  Discovered that order matters (e.g., @scope/package-a will match if it is before @scope/package-a/module-a) if trying to map over these aliases.
Not wanting to enforce a string order in my tsconfig, I resorted to just importing the tsconfig and clamping each alias with a regex.
This doesn't account for wildcards, so if you need those, additional work will be needed.
Also does not follow project references or support alias reuse (e.g., @ for current package).
import path from 'path';

import tsconfig from './tsconfig.base.json';

const alias = Object.entries(tsconfig.compilerOptions.paths).map(([module, modulePath]) => ({
  find: new RegExp(`^${module}$`),
  replacement: path.resolve(import.meta.dirname, modulePath[0]),
}));

+1 - I ran into this as well

This was added upstream in https://github.com/dominikg/tsconfck/pull/172. Try refreshing your lockfile and let me know if it works already.

Same issue. Installed version of tsconfck is 3.1.4. Tracked the issue, here is my findings :
Setup
/home/[redacted]/workspace/tsconfig.base.json (excerpt) :
  "include": ["${configDir}/app", "${configDir}/gen"],
  "compilerOptions": {
    "paths": {
      "~/*": ["${configDir}/app/*"],
      "~gen/*": ["${configDir}/gen/*"]
    }
  }

/home/[redacted]/workspace/apps/accounts/tsconfig.json :
{"extends": "../../tsconfig.app.json"}

/home/[redacted]/workspace/apps/accounts/app/routes/_auth.tsx includes ~/gen/types (which resolves to /home/[redacted]/workspace/apps/accounts/gen/types/index.ts). Note that tsc has no issue with the setup, the error arises when starting build with vite.
The issue
The isIncludedRelative test fails (https://github.com/aleclarson/vite-tsconfig-paths/blob/master/src/index.ts#L320) :
if(id === "~gen/types") console.log({id, project: project.tsconfigFile, baseUrl, paths, configDir, importerFile, relativeImporterFile, included: isIncludedRelative(relativeImporterFile), include: config.includ, include: config.include});

{
  id: '~gen/types',
  project: '/home/[redacted]/workspace/apps/accounts/tsconfig.json',
  baseUrl: undefined,
  paths: {
    '~/*': [ '/home/[redacted]/workspace/apps/accounts/app/*' ],
    '~gen/*': [ '/home/[redacted]/workspace/apps/accounts/gen/*' ]
  },
  configDir: '/home/[redacted]/workspace/apps/accounts',
  importerFile: '/home/[redacted]/workspace/apps/accounts/app/routes/_auth.tsx',
  relativeImporterFile: 'app/routes/_auth.tsx',
  included: false,
  include: [
    '/home/[redacted]/workspace/apps/accounts/app',
    '/home/[redacted]/workspace/apps/accounts/gen'
  ]
}

The issue is that the globs are absolute, not relative :
if(path2 === "./app/routes/_auth.tsx") console.log({path2, includers});

{
  path2: './app/routes/_auth.tsx',
  includers: [
    /^\.\/?\/home\/[redacted]\/workspace\/apps\/accounts\/app\/((?:[^/]*(?:\/|$))*)$/,
    /^\.\/?\/home\/[redacted]\/workspace\/apps\/accounts\/gen\/((?:[^/]*(?:\/|$))*)$/
  ]
}

The fix
Replacing
    const isIncludedRelative = getIncluder(
      config.include,
      config.exclude,
      outDir
    )

with
    const isIncludedRelative = getIncluder(
      config.include.map(path => relative(configDir, path)),
      config.exclude.map(path => relative(configDir, path)),
      outDir
    )

Fixed the issue for me.

Great sleuthing, @sloonz! 👏
Fixed in v5.1.1


libffcall: 2.1 -> 2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libffcall/versions.
meta.description for libffcall is: "Foreign function call library"
meta.homepage for libffcall is: "https://www.gnu.org/software/libffcall/"
meta.changelog for libffcall is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/38578a11c84070ab9830b8576a7c47b7

Rebuild report (if merged into master) (click to expand)

25 total rebuild path(s)

10 package rebuild(s)

10 x86_64-linux rebuild(s)
10 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
apostrophe
clisp
clisp-tip
gtk-server
libffcall
manim
ne
nuweb
texlive.combined.scheme-full
texlive.combined.scheme-medium

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ziw9xc8h65lhvbaq68c67cilx39jkjnh-libffcall-2.2.tar.gz \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libffcall https://github.com/r-ryantm/nixpkgs/archive/c3db2d3a1b37562e547aaf7d2dd57575b69d34ae.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ziw9xc8h65lhvbaq68c67cilx39jkjnh-libffcall-2.2.tar.gz
ls -la /nix/store/ziw9xc8h65lhvbaq68c67cilx39jkjnh-libffcall-2.2.tar.gz/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

@ofborg eval

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 111207 run on x86_64-linux 1

13 packages marked as broken and skipped:

gnuradio3_7Packages.ais
gnuradio3_7Packages.gsm
gnuradio3_7Packages.limesdr
gnuradio3_7Packages.osmosdr
octave-jit
octavePackages.fem-fenics
octavePackages.vibes
octavePackages.vrml
openems
python38Packages.python-csxcad
python38Packages.python-openems
python39Packages.python-csxcad
python39Packages.python-openems

2 packages failed to build and are new build failures:

clisp-tip: log was empty
manim: log was empty

136 packages built:

afterstep
alsa-tools
apostrophe
bumblebee
clisp
crowbar
csound
csound-qt
cubicsdr
dillo
ensemble-chorus
eureka-editor
exrdisplay
faust2csound
fldigi
fllog
flmsg
flpsed
flrig
fltk (fltk13)
fltk14
flwrap
gama
giac-with-xcas
giada
gmsh
gnss-sdr
gnuradio3_8Packages.ais
gnuradio3_8Packages.limesdr
gnuradio3_8Packages.osmosdr
gqrx
gtk-server
hyper-haskell
ja2-stracciatella
jwm-settings-manager
libffcall
librsb
limesuite
liquidwar
lmms
minc_widgets
mup
ne
new-session-manager
nuweb
octave
octaveFull
octavePackages.arduino
octavePackages.audio
octavePackages.bim
octavePackages.bsltl
octavePackages.cgi
octavePackages.communications
octavePackages.control
octavePackages.data-smoothing
octavePackages.database
octavePackages.dataframe
octavePackages.dicom
octavePackages.divand
octavePackages.doctest
octavePackages.econometrics
octavePackages.financial
octavePackages.fits
octavePackages.fpl
octavePackages.fuzzy-logic-toolkit
octavePackages.ga
octavePackages.general
octavePackages.generate_html
octavePackages.geometry
octavePackages.gsl
octavePackages.image
octavePackages.image-acquisition
octavePackages.instrument-control
octavePackages.interval
octavePackages.io
octavePackages.level-set
octavePackages.linear-algebra
octavePackages.lssa
octavePackages.ltfat
octavePackages.mapping
octavePackages.matgeom
octavePackages.miscellaneous
octavePackages.msh
octavePackages.mvn
octavePackages.nan
octavePackages.ncarray
octavePackages.netcdf
octavePackages.nurbs
octavePackages.ocl
octavePackages.octclip
octavePackages.octproj
octavePackages.optics
octavePackages.optim
octavePackages.optiminterp
octavePackages.parallel
octavePackages.quaternion
octavePackages.queueing
octavePackages.signal
octavePackages.sockets
octavePackages.sparsersb
octavePackages.splines
octavePackages.statistics
octavePackages.stk
octavePackages.strings
octavePackages.struct
octavePackages.symbolic
octavePackages.tisean
octavePackages.tsa
octavePackages.video
octavePackages.windows
octavePackages.zeromq
paulstretch
posterazor
pothos
python38Packages.fipy
python38Packages.soapysdr-with-plugins
python39Packages.fipy
python39Packages.soapysdr-with-plugins
qradiolink
rakarrack
rtl_433
sdrangel
seaview
soapysdr-with-plugins
solfege
texlive.combined.scheme-full
texlive.combined.scheme-medium
tigervnc
urh
virtualgl
virtualglLib
welle-io
xautoclick
yoshimi
zettlr
zynaddsubfx-fltk

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

afterstep:

warning: unknown setting 'extra-trusted-public-keys'
When evaluating attribute ‘afterstep’:
warning: attribute-typo
A likely typo in the sourceName argument was found, did you mean sourceRoot?
Near pkgs/applications/window-managers/afterstep/default.nix:13:3:
   |
13 |   sourceName = "AfterStep-${version}";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/window-managers/afterstep/default.nix:54:5:
   |
54 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md


Disable automatic switch for power adapter but not battery

Macos combines the "automatic switching" setting for both battery and power adapter.
Would it be great if gswitch could add an option to monitor whether a power adapter is plugged in and if so disable switching and trigger discreet graphics.
So end result could be:

If running on battery, permit dynamic switching
If power is plugged in, switch to discreet gpu

Cheers

Duplicate #73

Duplicate #73


Improve epoch table calculation

The Epoch table contains a row per epoch for like the following:
select * from epoch where no = 250 ;
 id  |      out_sum      |    fees     | tx_count | blk_count | no  |     start_time      |      end_time
-----+-------------------+-------------+----------+-----------+-----+---------------------+---------------------
 251 |<PHONE_NUMBER>2564141 |<PHONE_NUMBER>4 |   192598 |     20991 | 250 | 2021-02-24 21:44:51 | 2021-03-01 21:44:44
(1 row)

When db-sync is syncing the row is updated once per epoch via an SQL query that aggregates the data for the epoch and then writes a row to the database.
When db-sync is following the chain tip, the row for the current epoch is updated after every block, also via an SQL query.
The syncing query (once per epoch) is of zero concern. However, when following the chain tip, running this query for every single new block is suboptimal.
When following the chain we would like to avoid doing an SQL query per block. It should be possible to grab the info out of each block to update a cache and the cached value is written to the database. At the end of an epoch the SQL query can be run again to validate that the epoch row from the query matches the value accumulated during the epoch.
Probably need to get real numbers on how long it currently takes to get the epoch table entry via an SQL query,

A Cache table was introduced in db-sync which can be extended to cache this value. Also since this is an updated value in memory, rollbacks require special treatment. IMO the best aproach is to just delete the cached version and recreated after the cache miss.

Additionally to this, I believe there is a related bug related to restarts for the epoch table. If a value is inserted because db-sync follows the chain and then db-sync restarts, this value may never be updated.

Currently blocked as unable to test locally as there seems to be an issue with cardano-node when building with MacOs Ventura / M1 https://github.com/input-output-hk/cardano-node/issues/5122


Update README to include hint on USD.command

The README included with Apple's prebuilt USD Toolkit seems to specify incorrect paths to have python load the appropriate modules correctly. There is an included USD.command script included with their toolkit though that I thought would be helpful for other developers to know about after I had trouble trying to manually configure the correct paths.

Thanks @adrianbautista!


PMID:15298676 meiotic kinetochores

abnormal meiotic centromere clustering resulting in centromere-spindle pole body colocalization

please change to
abnormal meiotic centromere clustering resulting in centromere-spindle pole body colocalization  during prophase.
This is normal after prophase.  Here  the centromeres remain clustered when the telomers are clustered.
"When meiosis was induced by Pat1 inactivation at the G1 phase of mitosis, telomeres clustered to the SPB as per normal meiosis, but in most cells the centromeres remained partially associated with the SPB. When meiosis was initiated at the G2 phase by Pat1 inactivation, both telomeres and centromeres retained their mitotic nuclear positions in the majority of cells"
Then for:
normal meiotic centromere clustering during meiotic prophase I

change to
-> normal meiotic centromere clustering during meiotic prometaphase 1
and for
FYPO:0007108	abnormal meiotic centromere clustering during meiotic prophase I
this normally occurs drug prometaphase I
so instead say
instead  “incomplete meiotic centromere clustering during meiotic prophase I”

it happens at the end of prophase before metaphase
also this change makes it clearer that it is not happening correctly at the right time (some kinetochores remain unclustered)

changed as requested
edit file: 64b181e14ace28def2001b8bd2549a30e9a7a59d
release: f1383ca6022a9ae20ada50c46ae1d0c7410f04c7


PORTALS-3195 - SRC Utilities, finished SageAccountWeb and synapse-oauth-signin

Refactor looks great.  As discussed, we agreed to hold off on merging this change until after the critical Synapse ToS changes


WebVTT timestamps after 24 hours will parse as -1

Web VTT spec allows to have subtitles after 24 hours.
see: https://developer.mozilla.org/en-US/docs/Web/API/WebVTT_API#Cue_timings

This code here https://github.com/AlexPoint/SubtitlesParser/blob/febe41daae152e0e8eccfc3bbadf55e3511185ea/SubtitlesParser/Classes/Parsers/VttParser.cs#L171 should parse hour numbers greater than 24 fine. What was the timecode that gave you the -1 error?

file i used to test
`
WEBVTT
00:01.000 --> 00:04.000
Never drink liquid nitrogen.
00:05.000 --> 00:09.000
— It will perforate your stomach.
— You could die.
23:00:05.000 --> 23:59:59.999
— It will perforate your stomach.
— You could die.
24:00:00.000 --> 55:00:00.000
— It will perforate your stomach.
— You could die.
`
See that 23:59:59.999 wil be parsed correctly
but 24:00:00.000 wil be -1

This is a good point!
I just fixed this behavior and published a new package (1.4.9) to nuget with this fix.
That must be one hell of a movie with subtitle items at more than 24 hours though! ;)


Request users to register after 2 weeks of usage

If user did not yet register and FirstAssets and posthog property exists and is over two weeks old show a notification (IDE - Jetbrains notification)  to the user requesting to register
Text:
Please register to continue using Digma
Digma is free! But we'd appreciate if you register if you love using the product
Click the link below to enter your name and email
[Register]
Clicking the register link will open up the recent activity panel with the register option
Show again once a day

@kshmidt-digma
https://github.com/digma-ai/digma-ui/issues/393

see closed duplicate
https://github.com/digma-ai/digma-intellij-plugin/issues/1671


Fix issue medium css

Hello @nikohoffren, I wanted to let you know that I have also addressed the #355 issue. Could you please take a look at my changes and let me know if there's anything else that needs to be done before merging them? Thank you!

Hello @nikohoffren, I wanted to let you know that I have also addressed the #355 issue. Could you please take a look at my changes and let me know if there's anything else that needs to be done before merging them? Thank you!

The card looks good, well done!

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Added clarification and fix the Metrics doc

Clarified why pipelinerun level metrics aren't recommended. Also, fixed the documentation for a type.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/lgtm

/assign @lbernick

/assign @vdemeester

It's merged. I will raise some metrics pr soon, I would then take @afrittoli's comment into account.


IOError: [Errno 13] Permission denied: u'.bumpversion.cfg'

I would very like to hide .bumpversion.cfg to make make my project root more clearer (i always hide all auxiliary files).
But bumpversion doesn't allow that, falls with error in the issue caption.
OS - Windows 7.

You'd have to help me with that, I have no idea how that works on windows.

Look here: https://stackoverflow.com/questions/13215716/ioerror-errno-13-permission-denied-when-trying-to-open-hidden-file-in-w-mod


Generate list of high trafficked pages

This is a...

[x] Feature Request
[ ] Bug Report

Generate list of high trafficked pages (from Google Analytics) to help prioritization and place list somewhere contributors can access it. We'll need to update it after the site is completely revamped.
@jaredbhatti

Top 100 pages from the site: https://docs.google.com/spreadsheets/d/1pXfrCs2YlYjoFK5Z0mUmgSx_stMryhI-OmtGU8GXGN4/edit#gid=2130667426&vpid=A1

Thanks @jaredbhatti


streamable (and resumable) s/mime encryption (plus signature)

Create a S/MIME implementation that reads the input mime stream only once and writes the result to an output stream.
(no temp files, just reading from the input stream and writing to the output stream)

Make it resumable, i.e. it can be stopped, it keeps the (serializeable) state (symmetric session key, nonces/salts, ...) - later it can restart at any offset and the pieces of the output stream when combined (and no gaps) make a valid smime encrypted message
(just for reference: your sha256 appears to fulfil 1 and 2)

the same for s/mime signatures

what would it cost if the bouncycastle core team were to implement this (say 1 + 2)?

I'm please to say this is now done. Thanks to Ralf and PrivaSphere for supporting this.

Regarding 1.: Am I correct to assume, that this is done by calling transferTo on the inputstream? Are there any tests?
For 2. I found: https://github.com/bcgit/bc-java/blob/master/mail/src/test/java/org/bouncycastle/mail/smime/test/JournalingSecureRandomEncryptTest.java
Are there any other tests, for the 3 points?

Are there any committs that could be referenced to make it easily accessible ?

see also https://issues.apache.org/jira/browse/PDFBOX-4297

see also https://issues.apache.org/jira/browse/PDFBOX-4297

and see https://issues.apache.org/jira/browse/PDFBOX-2776  (would that also work for LARGE ?)


[Issue-2380] Add script for issue 2380 [internal review]

ATF Test Scripts to check FORDTCN-12049
This PR is [ready] for review.
Summary
New ATF scripts to check the issue.
ATF version
develop
Changelog
Added new scripts
Updated test set for the issues in scope of 7.2 release
CLA

[x] I have signed the CLA

@dboltovskyi Thank you for the review, all comments have been processed c9fdadd


Perturbation space signature implementation

PR Checklist

[x] Referenced issue is linked
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes

Technical details

Additional context

@Zethson can i merge?

I'll take a look at it later today/tomorrow and then merge. No worries!

Thank you!


add default entity filter & use 1.30 FE syntax

Checklist:
Follow up from new FE compatibility work, ensure the announcements plugin, when using the new FE system, includes a filter to publish the entity content to components & systems only by default. This can be overridden.
Also updates the new FE architecture to be compatible with backstage 1.30, following steps here.

[X] I have updated the necessary documentation
[X] I have signed off all my commits as required by DCO
[ ] My build is green

Interesting patterns. I haven't had the time to familiarize myself with the frontend past some of these changes. @alex-mckay, this has no impact on users on the old frontend system?

correct, no affect at all on old system! Really just a follow-on from Mark's work here - since the latest backstage release (> 1.30) introduced some new syntax to the new FE only

Interesting patterns. I haven't had the time to familiarize myself with the frontend past some of these changes. @alex-mckay, this has no impact on users on the old frontend system?

correct, no effect at all on old system! Really just a follow-on from Mark's work here - since the latest backstage release (> 1.30) introduced some new syntax to the new FE system only.

fantastic, thank you!


log on rank_zero only while saving last checkpoint.

What does this PR do?

log on rank_zero only while saving last checkpoint.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

is there some problem with tests?? ##[error]The operation was canceled. never seen this before.

comes from master, some logger test hangs.

@rohitgr7 do you see this message multiple times? because it should save only on rank 0 anyways.

@awaelchli yes, in case of TPU. Yeah, it's saving on rank_zero but this message should also log on rank_zero too.

yeah sorry, this is in on train end. makes sense.

@rohitgr7 It was fixed here #3483

I wonder why is it marked as a warning. Should be a simple info log.


Rule blocked: CORERULES-1637

Attach test dataset files that can be used to test the new feature
Replace the "###" in the issue title with the primary JIRA ticket number for the rule.
Fill in the following information

Links to related JIRA Tickets

https://jira.cdisc.org/projects/CORERULES/issues/CORERULES-1637
https://jira.cdisc.org/projects/CORERULES/issues/CORERULES-

Rule Information

Standard: ADaM
Rule ID: 6
Rule Description:
A variable with a suffix of FL is present and a variable with the same root and a suffix of FN has a value that is not  0, 1 or null

Describe the problem
A clear and concise description of the problem.
need to be able to check for:
1.Presence of any variable ending in 'FL' (ADaM rule 5 - ticket logged)
2.Check is there a root variable present that ends with 'FN'
2.1 .Root = string characters up to 'FL' of step 1
3. if root variable exist check record values
Describe the solution
A clear and concise description of how this problem could be solved.
as above
Proposed rule logic
Replace this with an example of how the new solution could be written as a rule

something like :
Check:
  all:
    - name: variable_name ending in 'FL' # (1)
      operator: exists
    - name: (ROOT|FN)
#Explanation of ROOT|FN : substring(length(1)-2) -> substring/cut up to 'FL' defines root), append chars 'FN' and this check if variable (ROOT Concatenated to 'FN') exists
      operator:  exists
    - name: (ROOT|FN)
      operator: not_contains_all
      value: (0,1)
    - name : (ROOT|FN)
      operator : non_empty

**Screenshots**
If applicable, add screenshots to help explain your problem and solution.

requires resolution of ADaM check 5 (https://jira.cdisc.org/browse/CORERULES-1636)


set to 3 digit version number

Version check for 2.3.0 is only 3 digits long.  Set the check to that.

ci check this


Support accessing NASA NEX CMIP6 using STAC

Hi @EglantineGiraud @joemoorhouse,
As part of the UK EO data hub (EODH) project, we would like to refactor this repository so as to use STAC as input/output metadata for the hazard data (both input and ouput), rather than using dataset specific custom code like is being done at the moment.
A first step towards this refactoring goal is to update the code so as to access the current input dataset being used (NASA NEX CMIP6) through STAC metadata (that we are going to create for a sample).
Following the 'contribution' documentation and what I am understanding from past PRs, I am going to create a personal fork of this repository and submit a PR to main from there.
Any input/comments are very welcome, thank you !

Hi @emileten,
Sounds good! Would definitely be better to use STAC where possible for such inputs. And indeed a PR to main is perfect.
We are converting hazard to use pdm and update Actions in parallel by the way (it is lagging behind the other repos) but should not affect your change too much.
Thanks,
Joe


Port bisect wrapper to act-tester?

In act-bash, we have a set of bisection tools that are useful for lifting the tester into act-fuzz's bisector.  There are a few issues with these, though:

they're written in bash, which is quite hard to maintain;
they don't have a particularly pleasant user experience;
they don't have knowledge of act-tester's plan format, and so rely a lot on manual specification of things that can be gleaned from a plan file;
the low-level runner could arguably benefit from being a single self-contained shot of the director, rather than a script tying together lots of other programs (this'd likely need measuring but I bet there's some overhead).

This issue tracks the possibility of:

rewriting bisect-driver as a director invocation, likely by making it possible to change the fuzzer used by the director, cap the number of times it runs experiments, and strip away some of the chrome;
rewriting bisect as a Go tool that takes a plan file and sets up the invocation of the driver from that plan file's information.

The FuzzRunner being implemented as part of the coverage testbed generator seems like it'd be a good place to start for making a 'lean' single-file runner, which would also be useful here (instead of using the full director).


Add a tipps & tricks section

How to load JSON
How to load libraries
How to click on things
How to use the context in before functions

Will be done via branch "tutorial"


var --> let to eliminate warning

Which toolchain version is getting this warning?  We don't see to be getting it.

coming from 1.7.0, sorry about that!
https://github.com/tensorflow/swift-models/blob/a3bcac81b45fb94cf52ecaf273978cf45dd7158d/Package.swift#L39

still hitting this when building swift-models packages, fwiw.  used 1.9.0 checkout and still getting same error:
/home/skoonce/swift/swift-models/.build/checkouts/swift-protobuf/Sources/SwiftProtobuf/BinaryDelimited.swift:198:7: warning: variable 'readBuffer' was never mutated; consider changing to 'let' constant
var readBuffer = UnsafeMutablePointer.allocate(capacity: 1)
let
/home/skoonce/swift/swift-models/.build/checkouts/swift-protobuf/Sources/SwiftProtobuf/BinaryDelimited.swift:198:7: warning: variable 'readBuffer' was never mutated; consider changing to 'let' constant
var readBuffer = UnsafeMutablePointer<UInt8>.allocate(capacity: 1)
~~~ ^
let
/home/skoonce/swift/swift-models/.build/checkouts/swift-protobuf/Sources/SwiftProtobuf/BinaryDelimited.swift:198:7: warning: variable 'readBuffer' was never mutated; consider changing to 'let' constant
var readBuffer = UnsafeMutablePointer<UInt8>.allocate(capacity: 1)
~~~ ^
let

Looking at your mentioned tensorflow/swift-models#569, it doesn't update Packages.resolved, so aren't you still using the old version?

deleted Packages.resolved + .build directory, ran, still seeing this!

What toolchain version, os, etc. are you on since we don't seem to be seeing this?

Linux 18.04, s4tf master build (tweaks + 5.3 tip), swift-models master branch.
swift --version
Swift version 5.3-dev (LLVM a2905f3b8d, Swift 112f6d30ba)
Target: x86_64-unknown-linux-gnu

which swift
/home/skoonce/swift/swift-source/swift/swift-nightly-install/usr/bin/swift

I wonder if this is specific to the s4tf build in some way…

Thanks!


Drag and drop doesn't work from vscode to webview

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.0
OS Version:  MacOS Monterey 12.5

Drag and drop doesn't work from vscode to browser, but it works from the finder to the browser. Is it by feature or there are some limitations because of which this is not working?
I did try to play around with current implementation of dataTransfer object that we are generating in ondragstart, compared it with the one generated by the macOS finder. But could not find a way to attach a file in a similar way as the finder is doing. Even though I attach a file, in the drop handler the event does not contain the file.
Website used: https://codesandbox.io/s/react-drag-drop-files-forked-6pc3wc

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Drag and drop appears to work fine here, it's just the the app isn't handling the different mime types
When dragging from VS Code's explorer, we set a uri-list mime entry on the data transfer. We don't set files like you get when dragging from the OS


SSH2Stream: parseKey appended comments in parsed public key output.

Yes, I agree. I have to fix it manually. Please update the pks also on npm.

Sorry for the delay, landed in 749e9723969. Thanks!


Migrate UI bundles to required components

Almost all of our bundle types have been migrated to required components after #14791. However, UI bundles have not been done yet.
#15550 will conflict with that, but since that PR needs more time to bake, we should press on with this work for the 0.15 release.
The strategy to do so is laid out here: https://hackmd.io/@bevy/required_components/%2FpuAA8c18TzeMhjclo36vEQ#Combined-Proposal-1-Conservative-Port-no-major-reworks-Selected

Ah I'm stupid I was worried this was going to be terrible but I hadn't realised required components could be nested until now 😅
It think though that Style might be better a choice instead of Node for the primary component. I've been thinking of a few things where it might be useful to have unstyled Nodes. We might want to support alternative layout algorithms as well and it'd be easier if they could output Nodes and use the existing UI extraction setup.

I think though that Style might be better a choice instead of Node for the primary component. I've been thinking of a few constructions where it might be useful to have unstyled Nodes. We might want to support alternative layout algorithms as well and it'd be easier if they could output Nodes and use the existing UI extraction setup.

I think most of Style's fields should be migrated to Node, the rest should be moved elsewhere, and Style should be removed. So in a way, I agree.

I think most of Style's fields should be migrated to Node, the rest should be moved elsewhere, and Style should be removed. So in a way, I agree.

Do you want to do that now, or wait for 0.16? I firmly agree about the ultimate action though.

Do you mean that Style and Node should be consolidated into one component containing both the layout constraints and the resolved layout values? Or is it more like Style being renamed to Node and the resolved layout values being moved somewhere else.

I also prefer more granular UI components, i.e., keeping Node and Style separated. I'm waiting for community consensus before migrating the examples (there are approximately 300 examples that need to be migrated) in the PR.

Do you want to do that now, or wait for 0.16? I firmly agree about the ultimate action though.

I think we should do the conservative port as outlined in the hackmd and do more involved changes in a later release.

Do you mean that Style and Node should be consolidated into one component containing both the layout constraints and the resolved layout values? Or is it more like Style being renamed to Node and the resolved layout values being moved somewhere else.

I think Node should be the "driving" public facing interface containing all of the "styleable" properties inherent to a UI node. For computed values (such as calculated_size), we should move those to one or more separate components.
There should be no more generic Style component. You "style" fields on specific components, you don't set Style.

I think Node should be the "driving" public facing interface containing all of the "styleable" properties inherent to a UI node. For computed values (such as calculated_size), we should move those to one or more separate components.

That sounds good. I've never liked how we keep the relatively non-distinct geometric layout constraints in a component called Style
It still bothers me though that the ouput component containing the computed layout is going to be the primary defining component, even if it's only intended to be temporary it doesn't feel very pleasant. Couldn't we do a renaming with Style becoming Node (and the primary component) and Node becoming ResolvedNode (or whatever) to go along with the required components migration?

I'd really try to reduce breaking changes for right now: this migration is already going to be really painful.

If we don't want breaking changes then Style could be the central component for now, using Node (without changes) doesn't make sense with the new require api. Required components is meant to make it unnecessary to explicitly spawn essential nonconfigurable components but since it's relatively uncommon to spawn completely unstyled UI nodes VitalyAnkh's migration PR is full of code like:
commands
.spawn((
                Node::default(),
                Style {
                    width: Val::Percent(100.),
                    height: Val::Percent(100.),
                    ..default()
                }
))

That seems obviously wrong to me, but I realise its not really that important and it will be fixed in 0.16. I'll leave this alone now and go work on fixing some bugs.

Last thing, we could put require on both Style and Node?

It's frustrating to see numerous instances of Node::default() following a Style in the examples. But this approach makes migration to Bevy 0.15 more intuitive for users. We could fix it early in 0.16.0-dev.

It's frustrating to see numerous instances of Node::default() following a Style in the examples. But this approach makes migration to Bevy 0.15 more intuitive for users.
@ickshonpe Are you proposing that we make Style require Node and use Style as the public interface? If we pursue this approach—moving most of Style's components into Node and using Node as the public UI interface in 0.16—we'd be creating an awkward transition (Node -> Style in 0.15, then Style -> Node in 0.16).
I suggest we either make no changes beyond the required component migration, or implement a comprehensive overhaul. A middle ground approach might lead to unnecessary complexity.

Exisiting users should be much more familiar with the Style component I think than Node which is normally only used internally.

@ickshonpe You're right. I totally agree with you. I will update the PR. Thanks!


How to publish screen sharing audio?

I see the 'SCREEN_SHARE_AUDIO' parameter in TrackSource, but I really can't find a way to share the screen sound
Or maybe now that I've got the screen share sound, like buffer or something, how do I publish it?

We don't support audio sources other than the microphone at the moment. We're looking to add in that functionality soon though.

Implemented in v2.10.0 by #528.


Replace nodenv, rbenv, nvm, rvm et al with asdf-vm

It purports to be an all-in-one solution.
https://asdf-vm.com

Switching to asdf-vm... is this the next thing? What do we want to recommend to our clients? That's what we should use internally.

@kmayer ASDF is meant to be a plugable handle-all-kinds-of-things version manager.
In my experience, it's missing some feature as compared to rbenv (what I use for ruby version). Specifically, it doesn't auto-rehash when changing versions. So, technically it can do it all, but at least for ruby, it doesn't do it as well. My experience is dated, so maybe this is not a thing anymore?
@mattbrictson tried it recently I think. Matt, any thoughts?

See https://github.com/asdf-vm/asdf-ruby/issues/63

I was unhappy with asdf and eventually switched back to a combination of rbenv and nodenv. In my experience:

asdf was noticeably slower at invoking ruby (compared to rbenv)
I had the re-shim issue @christiannelson linked above
The nodejs plugin doesn't handle default-packages properly
The java and maven plugins both have bugs that prevent JAVA_HOME from being set correctly

rbenv and nodenv are very similar (nodenv is actually a fork of rbenv), which makes that combination nice. If you learn one of them you've basically learned both.


Exclude Flyway Step

First of all, thank you very much for this plugin. We have been using it extensively and it got us using jOOQ quickly with a seamless DX.
We're using this plugin mainly to generate jOOQ classes for a database that belongs to the application, where the migration scripts live in the source code.
We're now adding another database (we followed the Multi-database setup example of the README.md). However, that database doesn't belong to the application, and is readonly access.
When we run the task, we get the following error:
Found non-empty schema(s) "public" but no schema history table. Use baseline() or set baselineOnMigrate to true to initialize the schema history table.

We tried customising the Flyway properties, but it seems they're being ignored. Here's an example of what we tried:
flywayProperties.put("flyway.baselineVersion", "2") // our migrations only has version 1
flywayProperties.put("baselineVersion", "2")
flywayProperties.put("flyway.enabled", "false") // Unknown configuration property: flyway.enabled
flywayProperties.put("enabled", "false")

Here's how the task looks like:
tasks.register("generateForExternalDatabase", GenerateJooqClassesTask.class) {
    basePackageName.set("com.sample.database.external")
    flywayProperties.put("flyway.baselineVersion", "2")
    flywayProperties.put("flyway.enabled", "false")
    includeFlywayTable.set(false)
    withoutContainer {
        db {
            username = ""
            password = ""
            name = ""
            host = ""
            port = 5432
        }
    }
}

When we run the task with a higher baseline version, or flyway disabled, we still get the same error of non-empty schema. Is it possible to disable Flyway for a single database configuration in a multi-database setup?

The flywayProperties needs to be set:
setFlywayProperties(Map.of("flyway.baselineVersion", "2"))

That doesn't seem right, setting properties with flywayProperties.put should work too, there's a test for that :thinking:


Backport the fix to prop precedence from .NET to Framework

@gewarren This was taken from the new article.
Fixes #1154

Noted the snippets error. I restored the original code, some other old articles are using it. But I migrated the code for this specific article to the new snippets folder and it compiles and passes.


Remove placeholder normalization

We can not safely normalize the placeholder without introducing a specific color —which would be very opinionated—, or without modifying the opacity —which would prevent the placeholder from being shown in Edge under certain conditions due to a bug.
Context: this was originally discussed on #550 and then added on #571. The decision to remove it was made on #580.
Notes: (a) I didn't modify the test.html file since I couldn't find a test for this. (b) I didn't add a note to the README as @jonathantneal suggested since as we no longer include this, it would be weird to add it to a section with the "additional detail and explanation of the esoteric parts of normalize.css." tagline —please, feel free to add it if you deem it necessary.

This closes #580.

Looks good. Can we get a proper release after the merge?

@slavanga, I think that it would be the best thing to do —at least a minor release—, to prevent people from being caught with a weir Egde bug.

You did a very good resume of the situation, but majority of browsers use the same grey color for placeholders, so specifying a placeholder color is not so arbitrary…
Safari & Chrome use #A9A9A9
Edge & IE use #6D6D6D
Firefox use #767676 (black with .54 opacity)

Somehow similar discussion: https://github.com/h5bp/html5-boilerplate/pull/1403.

@visicode, I’d like to avoid setting those explicit values here because of how it alters the expectation for people leveraging opacity. To provide the best normalized experience across all browsers, some kind of PostCSS plugin would be needed. I would also recommend something like https://github.com/visicode/formalize.css and I realize now this is your own project. This would be a great addition to your opinionated project. If focused strictly on forms, I think it could be a great companion to both normalize.css and sanitize.css.

@alrra, great data! Thanks for linking the issue, would be great for future references.

Thanks!

@jonathantneal, great! The note in the README is a nice addition, thanks!
Off-topic: we have so much knowledge accumulated on issues and PRs that creating another document (even another project) listing all that it's starting to sound like a good idea.


J plus a b

Description
The main change is the implementation of the Jackknife+-after-Bootstrap method, thank to a class JackknifeAB in utils.py,
that permits bootstrapping and aggregation of the prediction. The jackknifeAB class can be a value of cv argument
The regression file is modified correspondingly, and test_regression.py too
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] test_regression.py

Checklist:

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[ ] Documentation builds successfully : make doc

Je vois qu'il y a des conflits avec la version actuelle de dev, car nous avons fait des modifications sur dev depuis la création de ta branche locale. Pourrais-tu prendre en compte ces mises à jour en local lors du prochain commit s'il te plait ?

Codecov Report

Merging #95 (416bc50) into dev (3db34f5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          828       891   +63
  Branches        56        69   +13
=========================================
+ Hits           828       891   +63

Impacted Files
Coverage Δ

mapie/regression.py
100.00% <100.00%> (ø)

mapie/tests/test_regression.py
100.00% <100.00%> (ø)

mapie/utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db34f5...416bc50. Read the comment docs.


Add create_token method to get a token usable with lxc remote add

Codecov Report

Merging #511 (81ca43d) into master (a44deea) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   97.05%   97.06%   +0.01%
==========================================
  Files          56       56
  Lines        4105     4120      +15
==========================================
+ Hits         3984     3999      +15
  Misses        121      121

Impacted Files
Coverage Δ

pylxd/models/certificate.py
100.00% <100.00%> (ø)

pylxd/models/tests/test_certificate.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44deea...81ca43d. Read the comment docs.


chayang: init at unstable-20230209

Description of changes
A simple program for Wayland compositors written in C that gradually dims the screen.
Very useful for screen locking scripts to give user some time to abort entering locked state, same
as on mobile phones.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 226625 run on x86_64-linux 1:
1 package built:
chayang
commits and diffs look good to me

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2496

Hi !
Thanks for your contribution.
I've left some comments, left me know if this is clear enough.

Clear enough, thanks, fixed everything.

Thanks for implementing the changes, all good for me.
For the rest of the comments (not by me), is everything fixed?

Yes, I have addressed all threads.


Event handling via generics instead of conditional compilation

I think that there is a better approach to optionally handle events than conditional compilation. .NET does some smart optimizations based on generics and struct generic argument, for example:
public interface IEventsHandler
{
    // ...
}

// a struct for compiler optimization
public struct NullEventsHandler: IEventsHandler
{
    // empty implementations with aggressively inlined methods
}

// World with generic TEventsHandler, which would have nicely optimized calls for NullEventsHandler
public class World<TEventsHandler> where TA: IEventsHandler
{
    // ...
}

public static class World
{
    public World<NullEventsHandler> Create() { /* ... */}
    public World<TEventsHandler> Create(TEventsHandler handler) where TEventsHandler: IEventsHandler  { /* ... */}
}

The only issue is that a generic World is returned. If that's a problem, an interface of IWorld could be created and returned instead. If an only one class exists for such interface, that would be optimized too (devirtualization).
The approach with generics has been successfully utilized in pebuphysics2:
https://github.com/bepu/bepuphysics2/blob/a763813/Demos/Demos/SimpleSelfContainedDemo.cs
Specifically it's described here:
https://github.com/bepu/bepuphysics2/blob/a763813/Demos/Demos/SimpleSelfContainedDemo.cs#L20

I've just realized that World can just inherit from World<NullEventsHandler>, and the Arch API would stay compatible, e.g.:
public class World: World<NullEventsHandler>
{
    // shadows World<NullEventsHandler>.Create
    public static World Create(/*...*/)
    {
        // ...
    }
}

So, if anyone wants to use events, they may simply use World<MyEventsHandler>.Create instead of World.Create.

This is definitely worth considering. This could simplify some things and it has the advantage that the performance remains stable. Unfortunately I'm currently working on some other features, but that would also be worth considering ^^

How would you then listen for individual component changes? That doesn't really make sense to me right now.
E.g.
world.OnAdded<Velocity>(() => {});
So how would this generic world variant implement this?


⭐ 33 - Real-Time Language Learning Assistant (Hacktoberfest Demo)

🤩 Thank you for participating in the CopilotKit Hacktoberfest event.
Follow This Link to Get Started!🎉
NOTE: CopilotKit will allow multi-assign issues
💡 Please show your support and give a ⭐ to the CopilotKit repository.
Documentation to:

CopilotKit
CopilotKit CoAgents (Advanced)

Demo:
Real-Time Language Learning Assistant
Description of app functionality:
Develop an interactive language learning platform where users practice conversations with the AI agent, teaching a new language through simple steps and the user writing back, receiving immediate feedback on grammar and vocabulary.
Technology Requirements
Using CopilotKit

Required: Your project must utilize CopilotKit as a core component.
Installation: Include CopilotKit by following the installation guide at CopilotKit Quickstart.
Documentation: Familiarize yourself with CopilotKit's features through the Official Documentation.

Styling with Shadcn-UI

Required: All UI components in your project should be styled using Shadcn-UI.
Installation: Install Shadcn-UI documentation

I would like to give it a try

I would love to work on this issue : )
@quest-bot embark

@quest-bot embark

@Nathan Tarbert please assign this issue to me

@NathanTarbert is hacktoberfest quest ended i have made a wonderful language learner i will submit it


Black screen on new Battle.net

Hey, with the recent Battle.net update, the black screen that this guide talks about fixing for Hearthstone now happens for Battle.net itself. How do you do that a step earlier in the process so the force d3d9 happens on battle.net rather than just Hearthstone? (assuming that that is indeed the fix)

Figured it out. You need to disable browser acceleration or whatever for the launcher to work at all. Will reinstall battle.net and make a pull request with the exact information


Add support for Gradle Configuration cache

https://docs.gradle.org/current/userguide/configuration_cache.html
build.gradle
org.gradle.unsafe.configuration-cache=true
fails on:
32 problems were found storing the configuration cache, 1 of which seems unique.
- Task `:app:easylauncherDebug` of type `com.project.starter.easylauncher.plugin.EasyLauncherTask`: invocation of 'Task.project' at execution time is unsupported.
  See https://docs.gradle.org/7.0.2/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution

Thanks for reporting the issue!
The configuration cache has been fixed in freshly released 4.0.0. Please let me know if you enounter any issues with it 🙏


A Cloudevent class per spec version

Today we have just one cloudevent.js that makes the interface with Spec classes. This is ok with vanilla js, because of flexibility which exists in js programming we inject new methods we needed.
Now it's time to stabilize the things. We are reaching the v1.0 and some attribute names are getting stable, in special the required ones: id, source, specversion and type.
We need:

a base class with required attributes
a class that extends the base one and makes specializations with it's own attributes
every implementation MUST follow the immutable object philosophy

@grant What do you think about this definition? May be would be better in ts?
/*!
 * cloudevents.io
 * Apache-2.0 Licensed
 */

"use strict";

/**
 * CloudEvent prototype
 *
 * @example
 * let event = new CloudEvent("A234-1234-1234", "https://github.com/cloudevents/spec/pull", "com.github.pull.create", {
 *     "comexampleextension1" : "value",
 *     "comexampleextension2" : {
 *         "othervalue" : 5
 *     }
 * });
 *
 * @constructor
 * @class
 * @param {String} id - Identifies the event
 * @param {String} source - Identifies the context in which an event happened
 * @param {String} type - The originating occurrence
 * @param {Object} extensions - Custom additional context attributes

 * @param {Object} data - Data attribute
 * @public
 */
function CloudEvent(id, source, type, extensions, data) {

}

CloudEvent.prototype.data = (data) => {

};

/**
 * Returns the internal representation of context attributes, extension
 * attribute and data attribute.
 *
 * @example
 * let event = new CloudEvent("A234-1234-1234", "https://github.com/cloudevents/spec/pull", "com.github.pull.create");
 * event
 *   .then((payload) => {
 *     // use the event payload, which is valid
 *     payload.id;
 *     payload.source;
 *     payload.specversion;
 *   })
 *   .catch((err) => {
 *     // threat the err reporting an invalid payload
 *   });
 *
 * @return {Promise} To resolve the event as object notation
 * @public
 */
CloudEvent.prototype.asObject = () => {

};

/**
 * Validates the payload against the definitions, but if something
 * is wrong throws and exception.
 *
 */
CloudEvent.prototype.validate = () => {

};

module.exports = CloudEvent;

Looks ok.
Would be much better with modern javascript (class) or TypeScript.

@grant Would like to help us with these definitions?

@fabiojose Sent email to you to discuss more first.

Given how the repo has evolved since this issue has been opened, I suggest closing this. @grant @fabiojose WDYT?

It's ok for me.

@fabiojose OK closing for now - as things progress we may revisit this, or not. :)


[cartservice] update .NET to .NET 8.0.3

Changes
[cartservice] update .NET to .NET 8.0.3 together with other packages.
It is security release from MS.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[x] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the docs N/A
[ ] Appropriate Helm chart updates in the helm-charts N/A

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Merging this one as the tracetest issue is not related to the PR.
I'll send a follow-up PR updating the TraceTest failure


Feature: Ability to lookup a value from an outside file or current yaml document and use it within a format marker

This is a decent use case where I'd like to look something up with a query within the same file or an external file, and plug it's value into somewhere within a yaml file (terrible statement).  This may be something better suited for pure templating, but I think this could reduce some of the needs for templating in general.  This needs to be thought out more, but I wanted to capture the idea.
Example:
File 1 - To look up a value I'd like to use in my overlays
---
some:
  stuff:
     here: cool
other:
  stuff:
    here:
      a: apple
      b: banana

Instructions file feature usage
---
# "path" key optional and would lookup a reference in the original yaml document?
references:
  - name: ref1
    path: ./file1.yaml
    query: some.stuff.here
  - name: ref2
    path: ./file2.yaml
    query: other.stuff.here[b]

yamlFiles:
  - path: /file/to/modify.yaml
    overlays:
      - name: Use ref1
        query: metadata.labels[app.kubernetes.io/name]
        value: "%r{ref1}"
        action: replace
      - name: Use ref2
        query: kind
        value: "%r{ref2}"

Expected Behavior:

overlay 1 replaces the value of metadata.labels['app.kubernetes.io/name'] with the value of cool
overlay 2 replaces the value of kind with the value banana

I'd like to use this to lookup and reference maps and arrays as well.
A use for this would be I deploy a bunch of stuff with Terraform and then spit it out in an orderly way with a template.
Then I want to populate a yaml based variables file with some of the info that I spit out from the terraform steps by looking up those references from the output to create a new yaml file that is properly configured for my new environment before further automation runs.

We do have the %v{r somefile.yaml}, but I want to look up (query) that file for the dynamic value's contents.


Update lb-ipam.rst

Minor update to the documentation. Several users are confused after configuring LB-IPAM and expect L2 announcements to work straight-away.
Clarified the wording so that folks understand they either need to use BGP or L2 Announcement to advertise the IP addresses set by LB-IPAM accordingly.

/test

Adding ready-to-merge: all approvals are in and docs change only (/tests didn't skipped ci-ipsec-e2e & ipv6 properly)


enclave-tls/dist: add dh_strip --exclude rules in the deb and dbgsym packages

According to https://man7.org/linux/man-pages/man1/dh_strip.1.html, we can use
dh_strip --exclude to exclude the files from being stripped. If the sgx_stub_enclave.signed.so
file is stripped, it will be an error, so we should use dh_strip --exclude rules to avoid
stripping them.
Fixes: #1006
Signed-off-by: Yilin Li<EMAIL_ADDRESS>

test result: the md5sum of dkpg -l and build from source codes are equal.

This is the build stage:


[CELEBORN-1534] Order the API v1 response sequences filed

What changes were proposed in this pull request?
Make the results returned by the API v1 in order.
Why are the changes needed?
For customer interface friendly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not needed.

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

it might be costly for sorting shuffle_id and application_id listing API
If that, I can remove the order for them

maybe we can sort the response in client side.
Waiting for the celeborn-CLI.

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

Perhaps we could add an option to choose between sorted and unsorted results?


How to sort all by desc in a resource?

After creation, object is display at the end.
I can't use indexQuery()
"NB! This overrides the indexQuery() method."
Maybe, i can use some default method to sort?
How to sort all by desc in a resource, and after creation object will be first?

Heya! The restriction comes from spatie/laravel-sortable which doesn't allow specifying the direction of the sort. However - there's one quick-fix which I've used and recommend to others as well:

Create an Observer for your model
Call $model->moveToStart() in the created() callback

Example of this:
public function __construct()
{
  static::created(function($model) {
    $model->moveToStart();
  });
}

Hi,
I also would like to have the sort of my resources to have the newests on top. I tried to override the indexQuery changing the direction of my order_column but then this package does not work properly.
It would be great to have a configuration in the package to indicate if the order_column should be desc or asc. I see in the trait, by default it always order by asc.
You mentioned that spatie/laravel-sortable does not support the direction, but I think in the Controller when persisting the data in the database, it could just invert the order when persisting if it is configured to be desc.
What do you think?
If everyone thinks that this is good, I can try to propose a PR.

@lisotton Hey! Thanks for your feedback.
I don't think it's that easy to tap into Nova's own CreateController - the easiest way is to observe the observable model and when a new one is created, move it to the first position. The models creation isn't handled by a controller inside this package.
What kind of a solution were you thinking of?

Hi @Tarpsvo
I get your point for creation, but my main point is to have the resources in the table ordered by desc (newest first). The change of the order for existing resources (when dragging and dropping) in the index is handled by the controller inside of this package, so I think could be an option to invert the order of the array received in the post or something more elaborated, so the order of the resources in the index table could be either ways.
What do you think?


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_931f2a9e-585e-45ca-a5eb-ea5a75d3862c/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_931f2a9e-585e-45ca-a5eb-ea5a75d3862c.git

Docs Build status updates of commit 425c75f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/VSC-Service-Account/docs-archive-test-source' (branch: Release_Archive_master_2020-06-02-05-53-27) is not authorized.. It looks like this might be the first time you’ve submitted a pull request to this repo. Before you can run builds in a pull request, you have to enable your GitHub account in Docs by visiting https://opportal-sandbox.azurewebsites.net. After you enable your account, close and then reopen this pull request to start another build.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Incorrect Learning Path validation

Multiple badges on the same Learning path cannot have overlapping skills. is displayed incorrectly, to replicate:

create project with 1 subject and 4 skills: Skill A, Skill B, Skill C, Skill D
create 2 badges:

Badge 1: Skill C, Skill D
Badge 2: Skill A, Skill D

create learning path of item of Skill C -> Skill D
now attempt to create Skill A -> Skill B and the following error is displayed:

PR: https://github.com/NationalSecurityAgency/skills-service/pull/2465

:+1:


I'm getting some optimization warnings regarding numberFormatSymbols, getMaterialTranslation and getCupertinoTranslation

I just updated my entire code and plugins and now I'm getting the following warnings:

Warning: getCupertinoTranslation from package:flutter_localizations/src/l10n/generated_cupertino_localizations.dart is too large. Some optimizations have been disabled, and the compiler might run out of memory. Consider refactoring this code into smaller components.

Warning: getMaterialTranslation from package:flutter_localizations/src/l10n/generated_material_localizations.dart is too large. Some optimizations have been disabled, and the compiler might run out of memory. Consider refactoring this code into smaller components.

Warning: numberFormatSymbols from package:intl/number_symbols_data.dart is too large. Some optimizations have been disabled, and the compiler might run out of memory. Consider refactoring this code into smaller components.

And I've no idea what it means or the impact it might have.

Where does the warning come from, Dart or the IDE?

Where does the warning come from, Dart or the IDE?

No idea my man. It appears when I compile.

cc @thkim1011 for the Flutter part


Reflect changes to URL.searchParams back to URL

Changes to URL.searchParams reflect back to original url.
Depends on: https://github.com/HtmlUnit/htmlunit/pull/375, or else test fails with cannot find function error

As always many thanks fr  the contribution. Will have a look at the others during the next days.
Btw: it will be really great if we can use your real name for the author tag

Hi,
i have done a different implementation for this because i do not want to get more HttpClient dependencies. But hopefully your cases are also solved now.
There is still a problem with all the encoding - have to work on this during the next days.
It will be great if you can have a look at my changes and maybe make a new pr with more test cases for this area (and maybe fixes also).
And again thanks a lot for your contributions.


[Documentation] Changed the occurrences of babel-core to @babel/core in react quick start guide

Issue:
babel-core is moved to @babel/core
What I did
Changed the occurrences of babel-core to @babel/core in the quick start guide of React

I have created a branch from master. When I try to create a PR it's shown that create a PR to next. So I did that then came some commits which are not mine.


Add IronLend Single Assets

IronLend is a fork of Compound and contracts are under 12 hour timelock.
Contracts
Strategies are forked from Aave strats.
ETH
Vault: 0xbC6DaEf70990fEcc6875947669752675Ce5435ea
Strategy: 0x6Fd51c01965ad64E00CFf1ADCb8cb7eb3b614D25
Want: 0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619
USDC
Vault: 0xb3D3D0FD83Af2afD0279A8861bBbB58CC398454d
Strategy: 0x6a8605749fAd4ED0184c17694eC98dD4fA5402c3
Want: 0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174
USDT
Vault: 0x0E9bc8CABC2417B6207FC348186dfeA9a467cd4B
Strategy: 0x3C7b16556a28B7e1B245f33210472a3DABeC7F0A
Want: 0xc2132D05D31c914a87C6611C10748AEb04B58e8F
WBTC
Vault: 0xF50f947b01D989a84a495c600296cfE5675618B5
Strategy: 0x53e0Dfcbc5b0F019f967b71AF6A9cb3542106536
Want: 0x1BFD67037B42Cf73acF2047067bd4F2C47D9BfD6

The cTokens timelock is 1 hour. Also I would cover off with Roman or I before diving into new platforms.

sorry i closed to deploy current prod, and this PR got vercel stuck, especially after 2nd commit
will reopen after


Fuzzy Search Roles

Summary
Implemented fuzzy searching for role names in the RolesConverter for a better user experiencing, especially with majority of servers using role names with "aesthetic" unicode characters.

Summary by Sourcery
Implement fuzzy search functionality in the RoleConverter to enhance role name lookups by allowing approximate matches, improving user experience in servers with complex role names.
New Features:

Introduce fuzzy searching for role names in the RoleConverter, allowing for more flexible and user-friendly role lookups by incorporating Levenshtein distance and word match scoring.

Enhancements:

Add logging capability to the converter module by initializing a logger instance.

.


Added support for multiline labels using explicit newline character.

I've added support for multiline text in Labels using explicit newline characters, per this issue:
https://github.com/AnalyticalGraphicsInc/cesium/issues/2402
I revived and (very slightly) improved the code written by @andre-nunes in this pull request:
https://github.com/AnalyticalGraphicsInc/cesium/pull/2575
I've tested and ensured that single-line labels have the same positioning (i.e. this maintains backwards compatibility)

Thanks @dwhipps!  It looks like you have a jsHint error
We'll take a look at this soon

Hannah,
I can't see the error on my end when running 'npm release' or 'npm tests-non-webgl'
Can you point me to the file/line? The "details" link in providing the Travis CI build log isn't very helpful.

I managed to fix the error. Not sure what the "bug bash" tag means. Do I have anything else to do?

Thanks @dwhipps,  we're a little busy around here this week so I'm not sure if we'll have a chance to review this right away.  I looked through and the code looks fine to me, but one of the graphics guys with a better understanding of the changes here will do a more thorough review to get this merged.

I know this code pretty well and this is a long overdue, mostly straightforward, change.  I'll try and get it merged by the end of the week.
As for the bug bash label, we are having a 3-day code sprint in October to help address a lot of issues that have been reported in Cesium while most of us have been heads down on 3D Tiles related work.  So the label just means that we definitely want to look at this for the sprint if it's not already merged by then.

I've discovered problems with this and have not yet been able to resolve them. It would recommend NOT pulling this until I've figured out what's going on.

Thanks for the heads up @dwhipps I had a few edge cases I wanted to be sure to check myself as well, so glad you're on the ball!  Getting good font measurements in the browser is way harder than it should be (especially getting the same results cross-browser)

Red Herring. The new multiline labels code was not causing the issues I'm seeing (I'll report those separately.) As far as I can tell, it works pretty well.

@mramato I'm a little late to the party here, but I'm curious why measuring text has to be so hard.  Can't we just ask the browser to do it?  Here's how I did it recently in a similar situation:
https://github.com/TerriaJS/terriajs/blob/master/lib/Map/Legend.js#L188
In short: Create a span, set its styles and textContent, add it to the DOM (display: fixed so it doesn't affect layout, and opacity: 0 so it's not visible) and then call getBoundingClientRect.
One thing to keep in mind is that the measurement will be affected by the inherited CSS wherever you add the element, but you can deal with that pretty easily just by adding a class to your measure element that resets everything to a known state.

@dwhipps is this ready to be reviewed or were there still some things you wanted to change?

Yeah, this is ready to go.

In short: Create a span, set its styles and textContent, add it to the DOM (position: fixed so it doesn't affect layout, and opacity: 0 so it's not visible) and then call getBoundingClientRect.

It's been a while and I would need to look into it, but we also need to account for letter placement, i.e. letters that go below the baseline, like lowercase y.  It's not just simple width/height we need to worry about.

we also need to account for letter placement, i.e. letters that go below the baseline, like lowercase y.

I don't think this should be an issue.  The size of the span will account for any possible drop below the baseline.  You can easily prove this to yourself with jsfiddle:
https://jsfiddle.net/srmvjdnn/1/
Change that o to a y or an R and notice that the height of the span doesn't change.
If you need to know the exact baseline position within that span for some reason, I don't know how to do that offhand, though I bet it can be done.  But I can't really think of why you'd need to know that.

If you need to know the exact baseline position within that span for some reason, I don't know how to do that offhand, though I bet it can be done. But I can't really think of why you'd need to know that.

I think the main issue with your approach is the wasted space above the y.  I'm less concerned about the memory/texture usage and more concerned with how that affects origin/offset positioning (though I admit it may not matter).  @shunter was actually the original author for most of the current label code, so hopefully he can chime in with some thoughts.   I'm fine with trying to approach you are suggesting, especially if it simplifies the code.

@dwhipps Check out the below code snippet and screenshot, I would expect the point to be dead center.  It is in master (but without the new lines obviously).  We need to make sure all of the various origin combinations work as expected.
var viewer = new Cesium.Viewer('cesiumContainer');
viewer.entities.add({
    position : Cesium.Cartesian3.fromDegrees(-75.1641667, 39.9522222),
    point:{
        color: Cesium.Color.BLUE,
        pixelSize:15,
        verticalOrigin : Cesium.VerticalOrigin.CENTER,
        horizontalOrigin : Cesium.HorizontalOrigin.CENTER,
    },
    label : {
        text : 'aa aa\naa aa\naa aa\naa aa',
        verticalOrigin : Cesium.VerticalOrigin.CENTER,
        horizontalOrigin : Cesium.HorizontalOrigin.CENTER,
    }
});

Hmm. Well, now I've merge in master (just to keep things up to date) and the "Point" has disappeared. Can you confirm?

Looks like the "Point" is not drawing on the latest Chrome or Safari on Sierra, but it is working on FireFox...

I just checked out your branch @dwhipps and the point it still drawing for me in Chrome

That looks a bit better. Still need to check the other combinations of vertical and horizontal centring.

Just tested a few other combinations and everything seems to look the same as it does on 'master' branch (with a single-line string) and looks "correct" with multiline strings.

It looks like you need some leading between lines and the text looks odd if you mix in upper and lower case letters (lines are different heights).

more concerned with how that affects origin/offset positioning

I would argue that the effect on origin/offset positioning is that it makes it correct.  Currently it is incorrect, as seen in @GatorScott's screen shot.

@GatorScott I'm pretty sure the lines are all the same height (I give them all the height of the "highest" row.) That said, they could use some leading between them. I'll see what I can do.

@GatorScott I added some leading, have a look and let me know.

@dwhipps this looks great, but I'm getting a failing test on my machine:
Scene/LabelCollection Label should increase label height and decrease width when adding newlines
Expected 16.6845703125 to be less than 16.6845703125.
Error: Expected 16.6845703125 to be less than 16.6845703125.
    at stack (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1475:17)
    at buildExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1445:14)
    at Spec.expectationResultFactory (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:584:18)
    at Spec.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:332:34)
    at Expectation.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:528:21)
    at Expectation.toBeLessThan (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1399:12)
    at http://localhost:8080/Specs/Scene/LabelCollectionSpec.js:1631:38
    at Object.<anonymous> (http://localhost:8080/Specs/spec-main.js:139:30)
    at attemptAsync (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1793:24)
    at QueueRunner.run (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1746:26)
Expected 16 to be greater than 16.
Error: Expected 16 to be greater than 16.
    at stack (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1475:17)
    at buildExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1445:14)
    at Spec.expectationResultFactory (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:584:18)
    at Spec.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:332:34)
    at Expectation.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:528:21)
    at Expectation.toBeGreaterThan (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1399:12)
    at http://localhost:8080/Specs/Scene/LabelCollectionSpec.js:1632:39
    at Object.<anonymous> (http://localhost:8080/Specs/spec-main.js:139:30)
    at attemptAsync (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1793:24)
    at QueueRunner.run (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1746:26)

If this is an easy fix, I can merge this and it will go out with 1.27 on Tuesday.  Thanks again.

This is actually just a poorly written test. I'll fix it now.

@mramato For whatever reason, I can't get the tests running properly on my machine (still can't run on Chrome or Safari, because of GPU blacklisting on my MacBook), but this change should work. Maybe have a quick look at it and tell me what you think.

Unfortunately the test is still failing.  I'll see if I can take a look this weekend if you don't beat me to it.
Sorry to hear about the blacklisting, it's been making waves on the WebGL mailing list as well. You can try forcing WebGL support in chrome://flags by enabling  Override software rendering list, or trying Firefox.

@mramato I'm really sorry but I can't test this on my end until I fix the issue with my blacklisted graphics card. The test is pretty self-explanatory. Could you have a quick look at it (or perhaps remove it for now?).

@mramato Now that 1.27 is out, can we have another look at this? (I'm working on getting a new machine in the next week or two, but until then, I can't run these tests here.)

Yep, I haven't forgot about this.  I wanted to get it into 1.27 but I'm juggling a ton of stuff at the moment and didn't have a chance.  I'll hopefully carve out some time this week to look at some long-running Cesium PRs.

@hpinkos @mramato Think you can vet this one for me? I put a lot of work into it, think it's pretty solid, and have to keep remembering to merge this branch into my own before I build and release...

@dwhipps yes, @mramato said he's going to try to carve out some time to look at this soon.
Meanwhile, could you merge in master?  There are some conflicts with some recent label improvements we made in #4675

@dwhipps it looks like some RectangleGeometry changes are mixed into your label-newline-support branch here, is that intentional?  If labels don't depend on that, those changes should be kept to a separate PR.

@emackey Ugh... too many branches. I'll have to revert some stuff. Sorry.

Actually I don't think you need to revert anything, just merge the upstream master in here and these diffs should disappear.  It looks like these RectangleGeometry diffs are the same ones that got merged to master today.

I'm going to have to update my label-backgrounds branch to deal with multiline labels.  #4715

@emackey Done.

@dwhipps you have a jsHint error:
Source/Scene/LabelCollection.js
line 270  col 51  'HeightReference' is not defined.
⚠  1 warning

Scene/LabelCollection Label should increase label height and decrease width when adding newlines is still failing in all browsers for me.  Looking at the code, I think the problem is that Label.getScreenSpaceBoundingBox needs to be updated to actually support newline characters.  Does this test pass for you @dwhipps?

@mramato @dwhipps The Label.getScreenSpaceBoundingBox function has a number of issues that are fixed on the label-backgrounds branch currently under review.  I changed the logic for that function and more generally I revamped the logic for placing glyphs, so there will be major merge conflicts if someone attempts a simple merge of the two branches.
I want to take a shot at creating a multiline-label-backgrounds branch, hopefully today or tomorrow, that uses my new glyph placement logic augmented with the newline processing found here, and including backgrounds for multiline labels.

@emackey Good Luck! Let me know if you need anything. I'm around most of the day tomorrow.

Thanks @emackey, sounds like you have it under control!

Nice, GitHub allowed me to push to your branch since this PR is open.  @dwhipps take a look at what changed here, and also try setting showBackground on a label with newline chars.
One intentional change I made is that HorizontalOrigin now controls text justification as well as the position relative to the anchor point.  I didn't think it made sense to have left-justified text on a label when the anchor was CENTER or RIGHT.

@mramato I think this is ready.  Code I added should be reviewed.  Thanks.

Updated doc & a demo.  This is ready.

Sorry this took so long to get merged, but looks like the next Cesium release is going to have lots of nice label improvements.  Thanks @dwhipps! and Thank @emackey for handling the merge and bounding box fixes.

Tests and Sandcastle look good.  Is coverage for the new code solid?  Just those trivial questions.
I'd like to get this into master soon for some use before the 1.29 release.  Does anyone else want to look at this?

Ah, I see this was already merged; I had the window open from earlier today. :+1:

does it able to have richtext?
like redblue !so i can display multi color text in one line !

Hi @arafat5549,
No, you can only have one text color for each label.  In the future, please ask questions like this on our forum: https://groups.google.com/forum/?hl=en#!forum/cesium-dev
The forum has higher traffic so it is more likely someone will see your question and be able to help.  We may miss your question if you comment on a closed pull request like this.  Thanks!


Multicast discovery

It is listed in known issues, but is it planned?

Hi Adirio,
I haven't spend much time looking at this project recently, but I've been looking for a reason to come back to it.
If it's something that you would find useful, I would be happy to implement it for you.

That feature and IPv6 support, as I found while lookig at the code that only IPv4 support is provided, are two things that would be quite nice.

Sounds good!
Would you mind creating a separate issue for IPv6 support?
Thanks!

On Nov 30, 2017, at 4:25 AM, Adirio<EMAIL_ADDRESS>wrote:
That feature and IPv6 support, as I found while lookig at the code that only IPv4 support is provided, are two things that would be quite nice.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Taking a look at multicast support now.

I'm wondering if multicast discovery should be left up to the application using smudge.
For example you could have 2 applications on a network that both use smudge to broadcast messages but should not connect to each others nodes as they do not share the same message model.

That could work. That name should be replace foobar in the mdns example in this repo: https://github.com/hashicorp/mdns.
I also think that multicast discovery should be optional.

I agree, discovery options should be configurable: the user has the option to introduce some seeds him/herself or use multicast discovery by providing a namespace.

Absolutely agree on all points.
I've almost got a working prototype together if you're interested (the issue6-multicast branch). Keep in mind that it's a feature-incomplete WIP though.

membership.go lines 211-234:
func getMulticastAddress() string {
	if ipLen == net.IPv4len {
		if multicastAddress == "" {
			if ipLen == net.IPv6len {
				multicastAddress = defaultIPv6MulticastAddress
			} else if ipLen == net.IPv4len {
				multicastAddress = defaultIPv4MulticastAddress
			} else {
				logFatal("Failed to determine IPv4/IPv6")
			}
		}
	}

	return multicastAddress
}

You probably want to remove the outter if ipLen == net.IPv4len as it will not work properly for IPv6. You have the IP version check inside.

Wait, what's that doing there? 😆
Good catch. I have no idea what I was thinking.

I created PR https://github.com/clockworksoul/smudge/pull/13 if you'd like to take a look at what I have.
If anybody wants to be a full-fledged collaborator, I'm certainly open to that :)

Merged https://github.com/clockworksoul/smudge/pull/13.


ARU Org Join Request

Your Name
David Sephton-Poultney
Membership Type
Member
Role
Postgraduate
Supervisor
Robyn Verrinder
Teams
No response
Collaborator Repositories
No response
Special Requests
No response
Code of Conduct

[X] I agree.

Email Address Confirmation

[X] I confirm that I have read and understood the above.

Invite sent


[Suggestion] Add NPC shops

For starters, thanks for developing this awesome plugin. I personally really enjoy it.
Citizens has a very basic and barebones version of attaching GUI shops to NPC's. https://wiki.citizensnpcs.co/Shops
Maybe incorporating something like this into FancyNpcs would be a nice addition. You could argue that this isn't really the plugin for it, but that's something up for you to decide.
Either way, thanks for considering my suggestion

You can use something like EconomyShopGUI and use the /shop <category> command when a player clicks.
I gotta agree with you this isn't the sort of plugin to support it really.

There are already ways to do it. It could be part of the FancyNpcs plugin, but I think a separate plugin/addon would fit better.


Cannot find module Cannot find module '@react-native-community/cli-platform-android/build/link/patches/applyPatch

Error: Cannot find module '@react-native-community/cli-platform-android/build/link/patches/applyPatch'


Transition to css

Related Issue

Mention issue for which this pull request is a part of (please mention issue number # ) #204

Proposed Changes
Transition to css
Additional Info

Any additional information or context

Checklist

[ ] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[ ] 🎀 I have updated the documentation accordingly.
[ ] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Title goes here
Title goes here

Image goes here
Image goes here

Please mention on which issue you were assigned

Please mention on which issue you were assigned

Transition to CSS #204