feat(Internal): :sparkles: added missing query param implementation

also updated documentation site
Closes: #34
Type of changes?

[ ] Bug fixes: Non-breaking change which fixes an issue
[x] New feature: Non-breaking change which adds a new feature
[ ] Performance improvement: Non-breaking change which improves performance
[x] Documentation: Non-breaking change which improves documentation
[ ] Other: Non-breaking change which does not fit into the above categories
[ ] Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

[ ] Change not related to Java project

Following checklists are optional if above checkbox is selected:

[x] Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
[x] Proper JavaDoc updated in main and test classes for all public classes and methods?
[x] Tests added for changes?
[x] Tests are passing locally?
[x] Check style checks are passing locally?
[x] Test coverage is at least 80% for newly added changes?
[x] There are no SonarCloud issues?
[x] README updated? (if applicable)
[x] Documentation website updated for the PR raised?

Checklist for Website

[ ] Change not related to Website project

Following is optional if above checkbox is selected:

[x] Lint check passes locally?
[x] Prettier check passes locally?
[x] Build command working fine locally?

Reviewers
@WasiqBhamla/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

Issue in this branch, will create new one.


Inverse of has_members missing as a feature?

Taking the active_record_spec example setup with only the relevant parts:
class User < ActiveRecord::Base
  groupify :group_member
end

class Manager < User
end

class Group < ActiveRecord::Base
  groupify :group
end

class Organization < Group
  has_members :managers
end

With this, Organization class has a has_many :managers association.
How do I get an inverse_of association of that as has_many :organizations relation in the Manager class?
I would expect there to be a has_groups method available for group members.

I wrote some specs to clarify my intention.
has_groups :organizations association
First off we define a counterpart to the has_many :managers association generated into Organization class:
class Manager < User
  has_many :organizations,
    -> { uniq },
    through: :group_memberships_as_member,
    source: :group,
    source_type: 'Group'
end

then I would expect the following spec to pass(which it does):
      it "adds a manager to an organization" do
        organization = Organization.create!
        manager = Manager.create!

        organization.add manager

        expect(organization.managers).to include(manager)
        expect(manager.organizations).to include(organization)
      end

So my wish here would be to have a helper to define the association like with has_members.
has_members :managers scoping issue
But then I noticed that organization.managers does not list only managers, but all users:
      it "adds only managers to an organizations managers" do
        organization = Organization.create!
        user = User.create!
        manager = Manager.create!

        organization.add manager
        organization.add user

        expect(organization.managers).to include(manager)
        expect(organization.managers).to_not include(user) #TODO failing
      end

Is this expected behaviour or is this a bug?
(Note that my custom organizations association above has the same scoping issue)

So the desired behavior is to have a way to define a custom association which returns a subset of possible groups (filtered by type)? That seems reasonable.
The behavior with managers seems like a bug. I would expect the organization.managers association to filter by users.type = 'Manager'.

I have sketched out a suggestion at the commit referenced above.
How should the has_groups method be named to avoid confusion about its usage? aka. it's not meant to restrict membership but to act as a counterpart to has_members. Also it is only relevant with STI so that could be included somehow.
The commit still needs to be merged with your open PR above to ensure compatibility when a model is both a group and a member and also uses both has_groups and has_members.

@juhazi I started doing similar work last week to support allowing a member to belong to multiple groups (of any class, not just of one base class). Here is as far as I got: https://github.com/dwbutler/groupify/compare/feature/multiple-group-associations
It's very similar to the work you did. I ended up calling the method belongs_to_groups instead of has_groups, otherwise our work is nearly identical.
I abandoned this approach when I realized how much work it will be. It will essentially require a rewrite of the entire gem. Everywhere there is encoded the assumption that there is a single groups association that contains all the groups. This would no longer be possible if there are multiple, independent, group associations that have to query different tables. All of the membership predicate methods, (such as shares_any_group?) would have to be rewritten to query the group_memberships table directly.
Furthermore, it's not clear to me that this approach will be compatible with how the Mongoid adapter is currently implemented, which might necessitate storing custom data structures instead of using the built in Mongoid relations.
In any case, we can implement a similar interface here, with the documented restriction that the membership classes must be subclasses of Group in order for the gem to work correctly. And then in the future, perhaps the same interface can be reused with that restriction lifted.

So feature-wise my commit would check all the boxes. I'll change the name to yours or should it be belongs_to_group_subclasses or something to reflect the restriction?
This feature should probably be merged after #48 because it has the same Mongoid issue and filtering should work correctly both ways.

I would stick to naming it belongs_to_groups and document its usage and limitations. Reason being that I don't want the public interface to change too much (if at all) when the internal implementation changes.

@juhazi this is in #61


Add macos unit testing with GitHub actions

Free!
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

macOS 11 will fail until https://github.com/actions/virtual-environments/issues/2506 is resolved


pkg/rules/proxy: fix hotlooping when receiving client errors

Currently, if we receive an error from the underlying client stream,
we continue with trying to receive additional data.
This causes a hotloop as we will receive the same error again.
This fixes it by returning in the error case and adds a unit test for the proxy logic.
Fixes #3717
Signed-off-by: Sergiusz Urbaniak<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification
Added unit tests, without the fix the unit test will hotloop.

cc @bwplotka @kakkoyun @squat

@squat Does it makes sense to get this fix released with 18.0?

@squat Does it makes sense to get this fix released with 18.0?

yes, it very much could make sense. In this case, @s-urbaniak, I would ask that you make the pr against the release-0.18 branch instead. We would later merge this into main.

yes, it very much could make sense. In this case, @s-urbaniak, I would ask that you make the pr against the release-0.18 branch instead. We would later merge this into main.

@bwplotka thank you for the review! :green_heart: PTAL for final review :)

@bwplotka thank you for the review! :green_heart: PTAL for final review :)

Submitted https://github.com/thanos-io/thanos/pull/3734 for the 0.18 backport.

Submitted https://github.com/thanos-io/thanos/pull/3734 for the 0.18 backport.

Mmm rather than doing this in both branches, we should do what we always do which is merge in the release branch and then merge the release branch into the master branch no? If we all agree then I'll close this PR

Mmm rather than doing this in both branches, we should do what we always do which is merge in the release branch and then merge the release branch into the master branch no? If we all agree then I'll close this PR

leaving up to the maintainers, i have both PRs open :-)

leaving up to the maintainers, i have both PRs open :-)

Mmm rather than doing this in both branches, we should do what we always do which is merge in the release branch and then merge the release branch into the master branch no? If we all agree then I'll close this PR

@squat Yeah let's close this and merge the PR in release branch. I don't think we will get a conflict but let's avoid polluting the git history with duplicate changes.

Mmm rather than doing this in both branches, we should do what we always do which is merge in the release branch and then merge the release branch into the master branch no? If we all agree then I'll close this PR

@squat Yeah let's close this and merge the PR in release branch. I don't think we will get a conflict but let's avoid polluting the git history with duplicate changes.


environment types updated, addresses issue #8

The environment types for the CloudKit class are set to
'DEVELOPMENT_ENVIRONMENT' | 'PRODUCTION_ENVIRONMENT'
when it should be
'development' | 'production'
https://cdn.apple-cloudkit.com/cloudkit-catalog/#readme/CloudKit-on-the-web shows the environment variable being used for development
I added the two new types without removing the old ones since I don't know how they are being used.

Good Job! Would like to see this getting merged ;)

Good Job! Would like to see this getting merged ;)


Allow all pages if access to robots.txt is forbidden

According to this link from Google, if robots.txt is forbidden then "crawlers will generally assume that they can crawl all URLs of the website".

I note that the specification recommends but does not require that a forbidden status means complete restriction. Thus implementing this change would not contradict the specification and might make it more accurate for the real world.

Actually, I think this is not a good idea. We've generally followed the specification and the recommendation is to deny all. Google didn't make the robots.txt specification, and Google gets away with not following it because webmasters are willing to allow Google traffic. Arbitrary crawlers get scrutinized more heavily and are more likely to get banned for even three appearance off misbehavior. Therefore polite crawlers do respect the specification including recommendations.
Look at it this way: the default return code for missing pages is 404. 404 for robots.txt already means allow all. Thus if someone has gone to the trouble of changing the response code to 403, they probably no longer mean to allow all.
If you're seeing sites with a 403 robots.txt, I'd recommend that you notify them and tell them that this is an ambiguous signal, which may mean they get omitted from crawls. If that's not what they want then they should change their website.
I'd personally prefer to err on the side of caution when it comes to robots.txt.

Is there scope to add an option for a flag for this? I imagine for a lot of people the use case of this library is similar to ours, which is for fault detection rather than crawling, and in which case you probably have a heavy regard for how Google are handling the situation.
Our system picked up a couple of sites that intermittently returned 403s which triggered a urgent alarm as it showed up as the whole site being blocked, but that is not how Google perceived the situation (as per their docs and what we could observe of their crawling behaviour).
I agree with the point that other crawlers probably get more scrutiny and observing the specification recommendations is probably the best course of action - it is just a shame if the library cannot accommodate what I imagine is the other major use case.

I think a configuration option would be feasible, but the default should definitely be off. Also, be careful of assuming just because Google didn't stop crawling your site that it didn't mean that Bing or other foreign country search engines didn't stop crawling your site. Again, if you were going to treat this as a fault detection, I'd recommend you treat a 403 robots.txt as a strong warning if not a urgent alarm.

Yeah - I agree that the option should be off by default.
Agree about treating it as a strong warning - that is our intention. Thanks a lot for the quick replies. :)

Hi @b4hand, I'm just revisiting this after other work took priority. I've tried to add the flag in the most lightweight way possible given there was no previous precedent for passing information from RobotsCache to Rules. Let me know if there is an alternative way that you feel is more aligned with the project or if there are any other amendments you'd like to see before merging in. Cheers!

I noticed that you set the executable bit on several of the module files. Those files aren't intended to be executed directly, so I don't think it makes sense to set the executable bit on them.

Otherwise, your approach looks fine to me. I'd like @dlecocq to approve as well, but if you fix those last few things, I think we can probably get this merged.

Thanks @b4hand and @dlecocq. Let me know when you are happy and I'll tidy the commits :+1:

LGTM

I'll merge as soon as you collapse the executable bit change back into the original introduction of those bits.

I've collapsed all the commits into one. Thanks a lot for your help @b4hand!


fixed a bug concerning IS NULL / IS NOT NULL not adding AND

fixed a bug concerning IS NULL / IS NOT NULL not adding AND between an IS NULL clause and other predicate clauses.
Added Testcase to prohibit that from happening again
Sorry can't merge files! You will need to do that again.

I was not able to correctly merging. But I moved code.
Please take the last changes from my master


Eliminate the need for nanoid module

I made it so you don't need to install an entire module for a single string.
Edit: I don't think you need to use nanoid since the IDs don't need to be cryptographically secure.

Alternately, we could use crypto.randomUUID(), available in browers and node since v16.7.0.

there are some pretty lightweight hashing functions, that could also be considered to make the ids content specific
eg:
https://github.com/bryc/code/blob/master/jshash/experimental/cyrb53.js


fix: change collapsible toggle arrow directions from up/down to down/right

Description
Pretty simple, we are changing the toggle arrow directions of the collapsible widget from up/down to down/right to match other collapsible on the entity explorer such as widgets/pages/datasources etc.
Fixes #587
Depends on # (pr)

every PR in the design-system repository should have a corresponding PR in the appsmith repository to ensure that changes
here don't break existing flows. Link the corresponding PR here to trigger dpulls and prevent accidental merging.
If relevant, link the enterprise PR here as well.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual on storybook
Manual on main repo
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/generate-alpha

Verified. Changes look good to me!


Build(deps-dev): Bump mochawesome from 7.1.0 to 7.1.1 (#3020)

Pull request opened by the merge tool on behalf of #3020

Merged in 1acf201b47bf6e975ee214bf8af19b0e180a676e


DITA L&T upgrade to DITA 2.0

Removes obsolete learning2 domain. learning domain is now backward compatible with 1.x learning and learning2 domains.
Test documents are in test/ directory. To validate, include learning/doctypes/catalog.xml at the front of the catalog path, along with the base 2.0 grammars.

Looks good to me, but I don't have rights to merge in this repo


Bneukom/library fix

#52 should be reviewed and merged first.
There was an issue with Datasmith imports when Vitruvio is enabled. The underlying issue is that the Datasmith encoder (from PRT) also loads FreeImage (as does Unreal) which led to issues because depending on which library was loaded first the Unreal Datasmith import would fail to load textures (the PRT Datasmith encoder FreeImage version is older).
We don't actually ever need the Datasmith encoder from PRT for Vitruvio so we can just filter it out when downloading PRT which fixes the issue.
Also added missing categories for BP editable fields which are necessary for Plugin packaging.

Thanks for review! Removed the debug output and merged.


clear error message when trying to use a block that does not exist

should include line number in the original yaml, name of the step that was trying to use

Currently we get this:
CRITICAL - Error while running a job:
No module named 'datayoga.blocks.mapz'
Traceback (most recent call last):
  File "/home/yossi/projects/datayoga-py/venv/lib/python3.8/site-packages/datayoga_cli/__main__.py", line 84, in run
    job = Job(job_settings, context)
  File "/home/yossi/projects/datayoga-py/venv/lib/python3.8/site-packages/datayoga/job.py", line 39, in __init__
    module = importlib.import_module(module_name)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'datayoga.blocks.mapz'

should be
cannot find block mapz
in line 45 of the yaml
On Sun, Oct 9, 2022, 12:13 Yossi Shirizli @.***> wrote:

Currently we get this:
CRITICAL - Error while running a job:
No module named 'datayoga.blocks.mapz'
Traceback (most recent call last):
File "/home/yossi/projects/datayoga-py/venv/lib/python3.8/site-packages/datayoga_cli/main.py", line 84, in run
job = Job(job_settings, context)
File "/home/yossi/projects/datayoga-py/venv/lib/python3.8/site-packages/datayoga/job.py", line 39, in init
module = importlib.import_module(module_name)
File "/usr/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 961, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'datayoga.blocks.mapz'
—
Reply to this email directly, view it on GitHub
https://github.com/datayoga-io/datayoga-py/issues/117#issuecomment-1272495989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANAS5VTMESCTJQCJHLMDT3WCKECZANCNFSM6AAAAAARAGZUNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add an option for whether or not cards in the card lens should be scrollable

Need to resolve what the "default" should be.

Having them be non-scrollable would probably match most users' default expectations.
Having them be scrollable might be odd for some, but it would make the option more discoverable ("Can I turn this off?"). The users that like it would not have to discover the option.

I like the idea of a more responsive title size in this context. It probably could be smaller in general as well.
I wonder if I can do something where the cards are only scrollable if you, say, hold alt.


Support for Inline and Display Math

I'm working to support MathJax.
Output tag format:
http://docs.mathjax.org/en/latest/model.html#how-mathematics-is-stored-in-the-page
The idea for now:

$ ... $ => inline math
$$ ... $$ => display math

The code I wrote is mostly monkey-patching. Could anyone help get it settled?

Why introduce a new syntax when you can just piggyback on code blocks and use a custom renderer?
```latex
f(x) = \int_{-\infty}^\infty
    \hat f(\xi)\,e^{2 \pi i \xi x}
    \,d\xi
```

https://github.com/chjj/marked#overriding-renderer-methods

Because inline math.

Scholdoc found a reasonable way to use backticks for inline math - require
exactly 2 backticks:
http://scholarlymarkdown.com/Scholarly-Markdown-Guide.html#inline-math
It's almost compatible with existing docs (using more than one backtick is
rare), and still allows anything to be escaped in new docs as you can
always use 3 or more backticks instead of 2.
I'm not saying that's a great syntax, just mentioning it.
If you want to compare to syntaxes others implemented, I'm cataloguing them
at https://github.com/cben/mathdown/wiki/math-in-markdown (feel free to
edit, it's a wiki).
The fragmentation is somewhat sad.
My personal opinion is that most scientists writing in markdown will
flock to pandoc so it's best to stick to one of the syntaxes that pandoc
supports.
2015-03-10 0:44 GMT+02:00 summivox<EMAIL_ADDRESS>
Because inline math.
—
Reply to this email directly or view it on GitHub
https://github.com/chjj/marked/pull/180#issuecomment-77960641.

@cben : I was aware of these work. This fragmentation is unfortunate yet inevitable -- considering we actually have CommonMark now.
Very ironic -- this patch was here over 2 years ago.

Clsoing due to staleness, possibly going beyond the specifications we are focusing on, and merge conflicts. See #956


Necessary UCI commands

UCI commands necessary for interaction with GUIs:

[x] uci

[ ] debug

[ ] isready

[ ] setoption

[ ] ucinewgame

[ ] position fen

[ ] position startpos

[ ] position moves

[ ] go

[ ] stop

[ ] ponderhit

[ ] quit

register is not needed, since this engine can be used without registering.

uci done with #6
quit done with #3

isready done with #10


change users / logout

El Weso sez:
Feature request. Change users without having to exit the program. The usecase was presented by Splinter, in which we want to change logged in user, but don't want to lose window placement.

Added a Log Out menu item in d1fb4cfc6798d5229a5712eb8fbe23dd608020c3


Add support to trim whitespace for FixedLengthRecordMapper

Can we have the same capability like DelimitedRecordMapper to trimWhitespaces? Thanks.

Hi,
Thank you for requesting this feature.
I've added support to trim whitespaces in the FixedLengthRecordMapper (example here).
You can give it a try with the current snapshot version (see instructions on how to use it) and keep me informed in case of any issue.
Kind regards
Mahmoud

Hi @sothavirak
Have you been able to try this new feature?
Please let me know if everything is ok for you.
Kind regards
Mahmoud

Hi @benas
Working good :+1:  Thanks :)
Regards,
Khy


Implement a separate labelDrawTime option

Implementation notes:
Since not all annotation types implement labels, the drawLabel method is optional.
If the labelDrawTime option isn't specified, then it checks the individual annotation's drawTime option, then the chart-wide annotation plugin's labelDrawTime option, then the chart-wide annotation plugin's drawTime option. This means that you can't override an individual annotation's drawTime without also affecting its labelDrawTime, but I think it's the more intuitive and backward-compatible behavior.
Since the option should default to drawTime if not set, I did not add it to the defaults object. Please let me know if I've misunderstood how plugins' default options should be implemented.

This should fix #243 and #94. It supersedes #161.

Thanks for the suggestion, @stockiNail. I hadn't considered using a drawTime property at the label node. I do like that better, although I have a question about how it should be designed: Should setting a chart-wide default drawTime for labels be permitted? That would mean that the chart's options.plugins.annotation has a label sub-object with only one usable property. (The line annotation plugin's labels implementation doesn't otherwise pull any label defaults from the chart's options.plugins.annotation - maybe that's worth raising separately, if it's an issue for anyone. Or maybe there's a way to better merge in defaults automatically; I'm still learning my way around the Chart.js APIs.)
I noticed that text annotations were listed under "To-do Items" (and it's probably something that our project will eventually need). I'm guessing that a hypothetical text annotations feature would use the same label sub-object as lines (to keep a consistent interface) and so whatever we decide here would work for that, too.

Should setting a chart-wide default drawTime for labels be permitted? That would mean that the chart's options.plugins.annotation has a label sub-object with only one usable property. (The line annotation plugin's labels implementation doesn't otherwise pull any label defaults from the chart's options.plugins.annotation - maybe that's worth raising separately, if it's an issue for anyone. Or maybe there's a way to better merge in defaults automatically; I'm still learning my way around the Chart.js APIs.)

@joshkel you would like to set the label drawTime default into annotation plugin options in order that all labels of all annotation can inherit from that. In this case the labelDrawTime should be set, agree with you. Do you think this is the good use case?
In this case, forgive because it makes sense to me as well, I didn't think about that case even if usually this decoupled drawing should be an exception, I guess, and then could be configurable for a single annotation.

I noticed that text annotations were listed under "To-do Items" (and it's probably something that our project will eventually need). I'm guessing that a hypothetical text annotations feature would use the same label sub-object as lines (to keep a consistent interface) and so whatever we decide here would work for that, too.

I  was thinking about that (also to have label on the box and all other annotation types) and maybe an abstract label class is needed and every annotation could extend and implement special labeling.
This is valid (in my opinion) also for TextAnnotation (not implemented yet).
But I didn't do yet because I'm working on other stuff, sorry.

@joshkel apologize, I forgot an important thing on my previous answer.
@kurkle taught me that the annotations are now Chart.js elements and therefore you can configure the annotation (by its type) also in Chart.defaults.elements and/or chart.options.elements, like point, bar, arc or line (default elements of Chart.js).
Therefore if you want to configure all line annotations (but this is valid for all annotation types) with a specific drawTime (and then let's assume to use drawTime for label as well), you can do something like that:
options: {
   elements: {
       lineAnnotation: {
         drawTime: 'beforeDatasetsDraw',
         label:  {
            drawTime: 'afterDraw'
         },
   }
   ....
}

You can do the same into Chart.defaults as well.
In this way you can configure the drawTime default option for all labels of all line annotations.
Unfortunately a piece of code is currently missing into plugin but I think it makes sense to add:
https://github.com/pepstock-org/chartjs-plugin-annotation/blob/a46915f3e409928281f1e0c9d550bc524c1bddc3/src/annotation.js#L136
el.options = merge(Object.create(null), [elType.defaults, chart.options.elements[elType.id], annotation]);

This line is of my branch where the options are calculated differently for your code (when merged and after conflicts resolving, it should work changing that).
In this way you can get the drawTime also into your label as default for all line annotation and then the drawing can use drawTime (instead of labelDrawTime) for the label as well.
If you agree on that (to use drawLine for label and use the elements for default configuration), I can add the update to my another branch and submit another PR.

I think I like the label.drawTime more. Lets go with that.
I'm planning to provide some utilities for this in the core, no need to write the resolution path in every plugin (and extension):

el.options = merge(Object.create(null), [elType.defaults, chart.options.elements[elType.id], annotation]);

I'm planning to provide some utilities for this in the core, no need to write the resolution path in every plugin (and extension):

Sounds good!

Apologies for the delayed reply.
I changed to label.drawTime, as suggested, since that definitely seems like a cleaner design.
Do you want me to do anything with merging options now, or wait until other PRs and/or core work?


[KBM] Can't mix shortcut and key remapping to swap (e.g. ctrl-a to B and B to ctrl-a)

ℹ Computer information

PowerToys version: 0.25
PowerToy Utility: Keyboard Manager
Running PowerToys as Admin: No
Windows build number: 2004

📝 Provide detailed reproduction steps (if any)

On a German keyboard remap the shortcut AltGr + ß to ´ (i.e. backspace to accute accent)
Now remap ´ to \ (i.e. accute accent to backspace)

✔ Expected result
I have switched accent and backspace
❌ Actual result
Both ´ and AltGr + ß now produce ´
This basically prevents all remapping of keys with modifiers (including shift) unless you completely remove a character from your keyboard as something will always be at the end of the chain and therefore no longer work.
Thanks,
Stefan

I think this is by design

/cc @crutkas

@stefanfritsch
I have used an onscreen keyboard and remapping a key to AltGr+ß does not work for me either.

I did not found ``` on the German keyboard so I used A.

free tip: in a comment, placing <kbd> before and </kbd> after the keyboard character makes it look like this 🙂

@crutkas is it known or expected?

A more general case would be swapping a shortcut and a key is not possible.

I think this is something we should quickly sync with @arjunbalgovind about.  I know AltGr can cause some quirks

I also wanted to remap Fn + something to Play/Pause Media but it turned out only Fn key which it says "Undefined" is now Play/Pause Media key which is extremely annoying whenever I change the volume or brightness while watching someting on YouTube.
Can I format my keyboard how it was, because I format my laptop but nothing changed. This is so annoying.

betting https://github.com/microsoft/PowerToys/issues/5585 is part of it

@crutkas
It is a more general issue. I would say it is by design. It is not part of #5585. After fixing it we still will have #5585.
For example, if we add the following remappings:

A -> Ctrl+C
Ctrl+C -> A

After pressing A we will still get A. KBM performs the following steps under the hood:

Remaps single key A to shortcut Ctrl+C
Remaps shortcut Ctrl+C to key A

By design, we apply key remappings first and then shortcut remappings. It makes sense for the following scenario.

A -> Ctrl+C
Shift+Ctrl+C -> Ctrl+V

When a user presses Shift+A they will get Ctrl+V as a result.
The issue looks like a corner case so possible solutions are:

check if a shortcut remap does not revert the last key remap
check if the current shortcut if produced only by a single key remap

@crutkas @mykhailopylyp as mentioned above this isn't an Alt-Gr issue. It's that you can't swap keys with shortcuts since the remappings for each of them appear in the two different windows, and the key to shortcut remapping will have priority in execution. We need to apply key remappings first and then shortcut remappings because otherwise there would be a lot of KBM functionality which wouldn't be possible (there are many edge cases which will fail as you think about all the scenarios).

By design, we apply key remappings first and then shortcut remappings. It makes sense for the following scenario.
A -> Ctrl+C
Shift+Ctrl+C -> Ctrl+V
When a user presses Shift+A they will get Ctrl+V as a result.

As @mykhailopylyp mentioned this is by design, so that a user can make complex shortcuts shorter as well.
Similar to what was mentioned above, we would need to check for scenarios exactly like this where a key and shortcut are exactly swapped, and if so, when the key A in the above example is pressed, after sending Ctrl+C we can check if this Ctrl+C was generated by us and accordingly choose not to apply the shortcut remap on it. There could be some edge cases here so we have to make sure it is well-tested and only occurs for the swap scenario.

This is by design and it wouldn't make sense to change it.
The idea of checking these scenarios to handle them as "special cases" is a rabbit hole.

This is by design and it wouldn't make sense to change it.
The idea of checking these scenarios to handle them as "special cases" is a rabbit hole.


LIS-JULES does not update LIS_snow_struc

The AGRMET Ops runmode uses LIS_snow_struc to pull (ensemble-averaged) tile values of snow depth and SWE for a couple of calculations.  But the values in this structure (defined in lis/core/LIS_snowMod.F90) are not filled when JULES is run.
An example of proper updates of this structure is LIS-Noah 3.9.  Please see:
lis/surfacemodels/land/noah.3.9/noah39_dynsetup.F90
lis/surfacemodels/land/noah.3.9/da_snodep/noah39_setsnodepvars.F90
lis/surfacemodels/land/noah.3.9/da_usafsi/noah39_setusafsivars.F90
A patch needs to be implemented for LIS 7.3.

@emkemp, looks like this one was resolved in #633.

This was probably fixed, but in any case 557 WW is no longer using JULES.  So this issue is moot.


fix: 🐛 Fixed a multi select value render

A value render was built under assumption label and value were same,
which was a bad assumption.
✅ Closes: SSC-82

@lucas-homer / @SeanGroff sorry for no loom - was having a terrible time trying to record it with the gf and her family shouting thanksgiving recipes at each other as background noise. 😄


Throws an error if UID attribute is not present in Active Directory

If UID attribute is not present in active directory, below line throws an error as it doesn't find username.
https://github.com/Nordes/IdentityServer4.LdapExtension/blob/7447e522ab34b37feb518635587b153a42dba59a/IdentityServer.LdapExtension/UserModel/ActiveDirectoryAppUser.cs#L131

There's no magic ;). Usually I would say that you are supposed to know which attributes you have in your AD. That being said, the "username" is a normal attribute in a normal AD. If you are using OpenLdap, it may differ (based on schema).


Is there a equivalent to 'SDImageCache' from SDWebImage  in this library? How to remove image from cache?

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
I would like to remove a specific image from the cache when user delete a photo. I do this with this code in SDWebImage:
SDImageCache.shared.removeImage(forKey:
Tell us about the issue
I want use KingFisher now instead... but I can't now understand how delete a image from cache.
Question
How can I do this with KingFisher library?

Please read the wiki and well-prepared cheat sheet: https://github.com/onevcat/Kingfisher/wiki/Cheat-Sheet#remove-images-from-cache-manually

I discovered how to achieve this:
KingfisherManager.shared.cache.removeImage & KingfisherManager.shared.cache.store
Thanks to you @onevcat - you helped me provide for my family by finishing client project this weekend. Thank you sir. Helping makes world a better place.


Rename emptyDir e2e test cases

Renaming these because they currently match to the ginkgo focus 'tmpfs' but are really not about tmpfs.
@vmarmol cc @jayunit100

Makes sense to me. Tmpfs is an accidental detail

@zmerlynn @quinton-hoole

LGTM


feature:enabled search filter

Issue <> 🎯🎯
Enabled Search by Query filter addressed by issue #73
Description
Now the search input field will filter the courses by input text and will display a list of filtered courses just below the search bar and when user will click on that course from the list that course details page will get opened and if user will just clicks on the search button adjacent to the input field then now the filtered course cards will be visible to the user only.
Screenshots 📷

If search button got clicked

Give me 5-10 minutes. Looking into changes

Ok sure

A react PR is on it's way to getting merged. (pending from 1 week)
You will get notifications regarding this PR by tomorrow 8 am.
We hope you understand.

Ok ok no problem By the way Is it fine? Or i need to improve something in this?

I will check it by tomorrow morning.
Another person also made the PR on same topic
It took him 112 lines if your code works. Good for you then.

Okay

Can you add hacktoberfest ,hacktoberfest-accepted
label to it


remove configsource from pilot helm values.

Please provide a description for what this PR is for.
The configSource was not used for a long time, now the configSource can be configured in the meshConfig, we should delete it from the pilot helm values.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

/retest

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


ActionContext.GetContext<string>("property") returns json token of {{ ValueKind: 3}} instead of actual value.

Hi,
I'm using 3.2.0.
I have a custom action in a action trigger:
 public class PropertySetterAction : ActionBase
    {
        private readonly RuleExpressionParser _expressionParser;

        public PropertySetterAction(RuleExpressionParser expressionParser, object input)
        {
            _expressionParser = expressionParser;
        }
        public override ValueTask<object> Run(ActionContext context, RuleParameter[] ruleParameters)
        {

            var propertyName = context.GetContext<string>("propertyName");
            var value = context.GetContext<string>("newValue");

            return new ValueTask<object>(this._expressionParser.Evaluate<object>(value, ruleParameters));
        }
    }

Debugger view:
My Rules look like this:
[
  {
    "WorkflowName": "Employee Validations",
    "Rules": [
      {
        "RuleName": "If Employee Last name is unset, use first name as last name",
        "Expression": "!string.IsNullOrWhiteSpace(input1.LastName)",
        "Actions": {
          "OnFailure": {
            "Name": "PropertySetterAction",
            "Context": {
              "propertyName": "LastName",
              "newValue": "input1.FirstName"
             }
          }
        }
      }
    ]
  }
]

My expectation is that propertyName in context would be the literal LastName and the value of newValue would be evaluated to an expression.
Am I missing something or is there a defect?

Hi @ElanHasson ,
I am unable to reproduce this error.
Can you please provide more details on the following so that we can help you further:

Which dotnet version are you using?
How are you parsing the json rule?

Thanks for your response.
I forgot to press save on my update to the issue last night.
I found when debugging the RulesEngine library it's a System.Text.Json thing as that's how I'm deserializing my rules json which is getting serialized in  at https://github.com/microsoft/RulesEngine/blob/main/src/RulesEngine/Actions/ActionContext.cs#L22
I suspect when deserializing, I should specify the WorkflowRules type versus allowing dynamic to be returned.
It may make sense for me to send a PR to add support for choosing a serializer to use.
Please let me know your thoughts.

@ElanHasson thanks for the reply. Currently the support for System.Text.Json is only partial.
Probably we can take it as a separate issue on improving System.Text.Json support.
As for your issue, i believe using newtonsoft.json for json parsing should fix your issue.

Thanks will update here.

@abbasc52, what is the work necessary to support? I can send a PR.
Any interest in supporting whatever serializer via configurable extensibility points in ReSettings?

@ElanHasson I would need give some thought on this.
Currently we internally use newtonsoft only in 2 places:

When user passes workflows as array of strings
https://github.com/microsoft/RulesEngine/blob/bafbff281d16172bd7b4cf4c7785e684cfa2be2c/src/RulesEngine/RulesEngine.cs#L42-L46
When we try to parse context for actions
https://github.com/microsoft/RulesEngine/blob/65d2abbd8b28d631a7a886b2ad3760641423eb80/src/RulesEngine/Actions/ActionContext.cs#L22
https://github.com/microsoft/RulesEngine/blob/65d2abbd8b28d631a7a886b2ad3760641423eb80/src/RulesEngine/Actions/ActionContext.cs#L40

These are internal implementation, which should not impact users, so I need to think further whether we want to provide an ability to configure serializer or simply migrate to System.Text.Json
However, the issue with users trying to parse workflow json with System.Text.Json is that default serialization settings do not work well.
Mostly due to stringEnumConvertor.
https://github.com/microsoft/RulesEngine/blob/65d2abbd8b28d631a7a886b2ad3760641423eb80/src/RulesEngine/Models/Rule.cs#L42-L43
We have mentioned these attributes for newtonsoft, but not for System.Text.Json.
Also for actions, we have key as enum for onSuccess and onFailure which is not supported by System.Text.Json last time I checked.
https://github.com/microsoft/RulesEngine/blob/65d2abbd8b28d631a7a886b2ad3760641423eb80/src/RulesEngine/Models/Rule.cs#L48
From the looks of it enums are the main problem.
Now we can approach it two ways:

We can either change all enums to string and add proper validation on allowed values
Or add attributes for System.Text.Json as well on the model

I would like to know your opinion on this

Thanks for the thorough response.
Judging from the overall direction of Json in .Net, there is a large investment on System.Text.Json in terms of perf.
I have not been adding NewtonSoft.Json to any of my projects as direct dependencies for a while now.
I do not think serializer extensibility should be an objective here, it's a minor implementation detail.
With that said, it may make sense to push workflow rule inputs  as strings to be a library consumer concern versus a function of the library and internally only work on the strongly- typed object model .
It would be nice to eliminate the json dependency as a whole.
The easiest solution is to add the attributes for now :)

@abbasc52  I'm doing a PR to validate the change for the attributes for now. This will unblock me for now and we can figure out next steps.

@ElanHasson I digged deeper into the issue and realized that System.Text.Json does not play well with Object type and generates valuekind like object.
https://josef.codes/custom-dictionary-string-object-jsonconverter-for-system-text-json/
It looks like something beyond the scope of this library, and we would recommend using Newtonsoft (or pass the json as string) till we are able to fully migrate to System.Text.Json
I will be closing this issue for now and will include this as a part of documentation

No worries that's so much for what you've done.


Add AWS S3 Sample Module

:loudspeaker: Type of change

[ ] Bugfix
[ x] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description
Added AWS S3 sample module to get files from bucket, put files into bucket and also list files that are available in the bucket path.
:bulb: Motivation and Context
Created module part of issue Add samples #675
:green_heart: Junit 5 test methods
:pencil: Checklist

[ ] I reviewed submitted code
[ x] I added tests to verify changes
[ ] I updated reference documentation to reflect the change
[ ] All tests passing
[ ] No breaking changes

:crystal_ball:
Create integration test for module
Update README file with test instructions

Thanks @yshameer for the PR. The code shows how to use S3 client, but does not show really any of the Spring Cloud AWS features, right?

Thanks @yshameer for the PR. The code shows how to use S3 client, but does not show really any of the Spring Cloud AWS features, right?

@maciejwalkowiak yes, correct

I am sorry because I know you put an effort into that, but we need Spring Cloud AWS specific samples.


Cases where int is assumed to be 32 bits and two's complement

I've come across a few cases where you've written code that assumes int is 32 bits and/or two's complement, I think it would be reasonable to use int32_t in most of these cases as it's already used in other parts of the library. Here's a few examples I've come across but this obviously doesn't cover everything:
https://github.com/trinamic/TMC-API/blob/fd6a5378b2157bf115b8126c9183364b899fa27f/tmc/ic/TMC2160/TMC2160.c#L20
https://github.com/trinamic/TMC-API/blob/fd6a5378b2157bf115b8126c9183364b899fa27f/tmc/helpers/Macros.h#L33 (Here the shifts can overflow if the values are not cast to uint32_t first, additionally int32_t is passed to these macros where uint32_t should be used as >> and << are undefined behaviour on negative values and on some platforms perform sign extension of negative values which leads to the wrong result being returned)
https://github.com/trinamic/TMC-API/blob/fd6a5378b2157bf115b8126c9183364b899fa27f/tmc/ramp/LinearRamp.c (Here int is being used to store int32_t values, I haven't looked at this enough to know if it's an issue or not, additionally abs is being used on int32_t values)

I agree that this should be fixed. I had the same problem with the TMC6100. The code assumes that int is int32 but in my case it was int16.

I'm trying to work an MSP430 and a TMC5160. The MSP430 has a 16-bit int, and I've found a couple other cases which I think need to be fixed:
https://github.com/trinamic/TMC-API/blob/4ced0291c5cdae49f54e7f082c3c651d03ca19e7/tmc/ic/TMC5160/TMC5160.h#L30
I replaced this int's with int32_t.
and the abs function takes an int as an argument and returns an int.
https://github.com/trinamic/TMC-API/blob/4ced0291c5cdae49f54e7f082c3c651d03ca19e7/tmc/ic/TMC5160/TMC5160.c#L235
I added a macro definition:
#define ABS(N) ((N<0)?(-N):(N))

and replaced abs with ABS.


chore(trunk): release eslint-config 1.4.7

:robot: I have created a release beep boop
1.4.7 (2024-04-29)
Miscellaneous Chores

release 1.4.7 (25d18ed)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Nos-Futurs/eslint-prettier-config/releases/tag/eslint-config-v1.4.7 :sunflower:


Dynamic C# coloring

Enable dynamic coloring of C# spans. VSCode uses text mate grammars to accomplish coloring which will make this especially difficult. However, there is a portion of the language server protocol being developed that adds dynamic colorization.
Some examples for when this will be important include:

@model TModel

This issue does not include the TagHelper attribute dynamic coloring. That's covered by https://github.com/aspnet/Razor.VSCode/issues/94

Not doing extensible directives


importing tls_client fails with "dependency missing error", even though it is present

Hey, I am facing next error, when trying to import tls_client:
>>> import tls_client
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/tls_client/__init__.py", line 15, in <module>
    from .sessions import Session
  File "/usr/local/lib/python3.9/site-packages/tls_client/sessions.py", line 1, in <module>
    from .cffi import request
  File "/usr/local/lib/python3.9/site-packages/tls_client/cffi.py", line 15, in <module>
    library = ctypes.cdll.LoadLibrary(f'{root_dir}/dependencies/tls-client{file_ext}')
  File "/usr/local/lib/python3.9/ctypes/__init__.py", line 452, in LoadLibrary
    return self._dlltype(name)
  File "/usr/local/lib/python3.9/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /usr/local/lib/python3.9/site-packages/tls_client/dependencies/tls-client-amd64.so: cannot open shared object file: No such file or directory

I checked, and I definitely have this file downloaded(I can even open it with normal with open(...) statement.
Also, ran ctypes library separately:
>>> import ctypes
>>> library = ctypes.cdll.LoadLibrary('/usr/local/lib/python3.9/site-packages/tls_client/dependencies/tls-client-amd64.so')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/ctypes/__init__.py", line 452, in LoadLibrary
    return self._dlltype(name)
  File "/usr/local/lib/python3.9/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: /usr/local/lib/python3.9/site-packages/tls_client/dependencies/tls-client-amd64.so: cannot open shared object file: No such file or directory

same issue. Any ideas on how to fix this? I am running this code on docker python:3.9 image on m1 macbook.
when I run it not in docker, everything works perfectly.

seems like the same issue as in https://github.com/FlorianREGAZ/Python-Tls-Client/issues/13
in docker:
>>> from platform import machine
>>> machine()
'aarch64'


iOS - thumbImage crashes the app only on release: component, components, or pathExtension cannot be nil

Environment
info Fetching system and libraries information...
System:
    OS: macOS 10.15.4
    CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
    Memory: 317.93 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 13.6.0 - ~/.nvm/versions/node/v13.6.0/bin/node
    Yarn: 1.22.0 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v13.6.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.8.4 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 23, 28, 29
      Build Tools: 28.0.3, 29.0.2
      System Images: android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
    Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_242 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.1 => 0.62.1
  npmGlobalPackages:
    *react-native*: Not Found

Description
Setting thumbImage causes the app to crash on iOS release mode. I didn't test on android yet. In development the thumb image shows correctly and has no problem.
This is the exception I'm seeing on XCode:
[error][tid:main][RCTUIManager.m:1183] Exception thrown while executing UI block: *** -[NSURL URLByAppendingPathComponent:]: component, components, or pathExtension cannot be nil.

Reproducible Demo
this is a reusable slider component I'm using in my project:
import React from 'react';
import Slider from '@react-native-community/slider';
import {useThrottle} from 'use-throttle';
import useTheme from '../../hooks/useTheme';
import Box from './Box';

const thumbImage = require('shared/img/slider-thumb.png');

console.log('thumbImage', thumbImage);

const SliderInput = ({
  min,
  max,
  initialValue = min,
  onChange,
  label,
  step,
  ...props
}) => {
  const theme = useTheme();
  const initialValueRef = React.useRef(initialValue);
  const [innerValue, setInnerValue] = React.useState(initialValue);
  const throttledInnerValue = useThrottle(innerValue, 1000);

  React.useEffect(() => {
    onChange?.(throttledInnerValue);
  }, [onChange, throttledInnerValue]);

  return (
    <Box {...props}>
      <Slider
        minimumValue={min}
        maximumValue={max}
        step={step}
        value={initialValueRef.current}
        onValueChange={setInnerValue}
        onSlidingComplete={setInnerValue}
        minimumTrackTintColor={theme['color-primary-default']}
        maximumTrackTintColor={theme['color-off-white']}
        thumbImage={thumbImage}
      />
    </Box>
  );
};

export default SliderInput;

Nevermind, found out the issue was metro not including external assets in watchFolders, which causes the image to not load - which is what caused this exception probably.
For more info see facebook/metro#290

@papigers I got similar problem only in production App too. I got custom metro config, but I never had problems with sources in the same folder with thumbImage (so assume metro configured properly).


EcCodes Error

I got an interesting error using the latest beta4 version.
ECCODES ERROR   :  default_malloc: error allocating 1555200 bytes
ecCodes assertion failed: `0' in ......\src\grib_context.c:231
Anyone have any thoughts?
Even with Try Catch this still results in an uncatchable error. Doesn't seem to be easily reproducible either.

Can you share your code?

This issue was moved to GribApiDotNet/GribApi.NET#2


Add flag to ignore test suites that fail to run

🚀 Feature Proposal
Add a flag that lets you ignore test suites (files) that failed to run instead of reporting them as failed.
It should not ignore tests that ran and failed.
Motivation
Make it easier to run one test suite and see the results when there are compile issues in the other test files that I want to ignore. I'm using TypeScript but suspect JS projects have the same behaviour.
When making a change that affects lots of files, I usually get the functionality working and then start fixing (and running) my unit tests one at a time. I run them one-by-one using the --testNamePattern= flag. The issue is that when you move/remove/rename a class, it breaks import statements in many tests and jest marks those tests as failed even if you're not targeting them. Same behaviour when you use --runTestsByPath.
This makes it difficult to see the results of the one test that you're interested in when there are 20 other failures.
Example
jest --ignoreFailedToRun -t="The test that I want to run"

Pitch
This would make jest easier to work with and the desired behaviour can't be achieved without changing jest (AFAIK).

I'm not a fan, too easy to leave it in the npm script and you end up with evergreen tests.

@thymikee, true, but the same could be said for the --testNamePattern=  option, right? One could leave that in and ignore all/most tests. Perhaps it could give a nice, big warning if failures were encountered and ignored.

I agree with @thymikee I think this can allow false positives.
IMO this sounds like a UX problem, and Jest offers many options to target specific files already. The way I generally work with a large scale refactor that propagates to many files is I run the tests in watch mode and filter them with a file pattern using p and then a to run them all and find the next failing tests.

say I have 100 test cases, adding this flag can tell me 15 out of 100 is failing which is very useful, why can't jest do that? seems like a typical feature for other unit test harness, statistics matter when you have a large code base.

Say, I have 600 tests and I know 3 of them will fail. But because I cannot tag those 3 tests as failing, I need to use a CI level flag such as continue-on-error: true to continue on error. This is dangerous since any error from those 600 can propagate while I only needed to ignore those 3.

This feature would be very helpful. Any updates here? I too have a use case where I want to ignore failed tests.

Is there any progress on this issue?

If not, you can assign this to me, and I'd like to try adding this feature

I have four test files out of >100 that cannot run in CICD pipeline (due to node module issues), but can run on localhost.  I cannot use describe.skip() because the test fails to load at all.  I'd like to ignore/exclude these files if possible.


add new ORDO terms - ORDO migration

here is the spreadsheet of new terms I added.
I still need to add terms to the exclusion list (in tab exclude)

@nicolevasilevsky
did you decide on the parentage for these new terms? or did you agree with the one given by ORDO?
I am asking to see if we should have both your orcid and the ORDO id for the parent source?


Question: Dynamic SelectField's

I have a SelectField whose value should dynamically update another SelectField. I'm using the new v6 syntax, however, I'm unable to get access to the onChange event. Would love a suggestion of how to cleanly implement this. Thank you!

You can read the current selected values while rendering using the FormValueSelector and attaching the current values to the props. Something like this:
import { formValueSelector } from 'redux-form'; // or redux-form/immutable

const formSelector = formValueSelector('formname');

const FormWrap= {
  Form: connect((state) => ({ vals: formSelector(state, 'color', 'size') }))(Form)
};

Then, while rendering, you can use this.props.vals.fieldname to filter your SelectField values.
No need for onChange here.

@adamtal3 that's super helpful, and good to know. thanks and closing this now.


Objective-C symbols cannot be demangled

such as "_ZNSt3__110__function6__funcIZ38+[WCTStatistics SetGlobalErrorReport:]E3$0NS_9allocatorIS2_EEFvRKN4WCDB5ErrorEEEclES8",any solution?

Neither binutils's c++filt nor llvm-cxxfilt demangle this as far as I can see. What does demangle objective-c symbols?


[BUG] Build fails on armv7 targets

Describe the bug
Trying to compile this on a Raspberry Pi Model 3B running Raspbian causes a compile error in the expansion of the WindowExt derive macro. The same error occurs when cross-compiling from my AMD64 desktop running Debian Buster using the armv7-unknown-linux-gnueabihf target. On both platforms, the stable branch of Rust was used.
Compiler output
This error appears in every location where WindowExt is derived:
error[E0308]: mismatched types
  --> src/window.rs:34:31
   |
34 | #[derive(WidgetExt, GroupExt, WindowExt, Debug)]
   |                               ^^^^^^^^^
   |                               |
   |                               expected `u64`, found `u32`
   |                               expected `u64` because of return type
   |                               help: you can convert an `u32` to `u64`: `WindowExt.into()`
   |
   = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

It seems like this bug was caused by a different data model on that architecture concerning the long type. By simply adding an explicit cast to the raw_handle() implementation, I could get the library to compile and run. I've made a pull request.

Indeed. I haven't taken that into account. I've merged the pull request, and will be publishing a patch tonight.
Thank you.

Glad I could help. Thank you for maintaining this library, so far it works great for me :)


Replaced tail recursion with while loop

#91
I'm not terribly familiar (as in not at all familiar) with async Python development, but I think this will work here with the existing await statement.
I'm also not sure how to write a test for this, let me know if you have any ideas.

@bradshjg thanks for contributing to Bottery! I believe this while True will block the polling task and no task from other platforms will be able to run in the future. Probably, a better solution is to change the recursive call to asyncio.ensure_future(self.polling(session, last_update). Can you try this approach? :)

Thanks for contributing to Bottery! :)

@bradshjg I made the fix for this issue https://github.com/rougeth/bottery/blob/master/bottery/platform/telegram.py#L114. Thank you very much!


Broken links due to removed double quotes in headings

Description
When you use double quotes in a heading, Gitea removes them from the reference link.
Example:
If you use a header with double quotes like:
## Header with "double quotes"

Gitea generated link to that header is <URL>#header-with-double-quotes instead of <URL>#header-with-"double-quotes".
This behaviour leads to inconsistency between renderers, even between those which follow CommonMark specs. For example VSCode's Markdown preview (which follows CommonMark specs) keeps the double quotes in the links.
I reproduced the issue here
Gitea Version
1.16.8
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
Irrelevant
Operating System
Ubuntu 20.04
How are you running Gitea?
The instance runs on a virtual machine without containerization. I don't know which DB is used since I didn't installed it myself. By the way I don't think it's relevant here.
Database
No response

Can you push that file to GitHub as well to see how they do it?

Here's the repo. The behaviour seems to be the same.
I guess it's a matter of parser then. VSCode uses markdown-it, while Gitea uses goldmark. Also, I didn't find any reference to this behaviour among CommonMark's specs.

I would say it's more like a feature but not a bug, because Markdown is not a strict system, and there seems no standard.
There are various characters would be removed&replaced during URL generation. For example, the single quote ' in your demo file, too.
https://github.com/federico-ntr/gitea-double-quotes-test#placeholder-to-force-scrolling-on-links-click
https://try.gitea.io/federico-ntr/double-quotes-test#placeholder-to-force-scrolling-on-link-s-click

Since there is no standard, so there is no right or wrong, as long as it works.

I tried to search on CommonMark and I didn't find anything related to this matter. I think it's a free different choice made by goldmark and markdown-it.
I'll format my links according to what goldmark does, since it's more important for me that they are working on Gitea rather than on VSCode md preview.

Thank you for your confirmation. Since there is no standard, I think we can close this issue at the moment, until there are some standards in the future (I believe that on that day, there will be new issues for it)


Console Warning with Feature-Policy header

Describe the bug
There is a console warning (error) once the user opens any page
"
Error with Feature-Policy header: Unrecognized feature: 'none'.
"
Screenshots

can't reproduce

still can't reproduce, closing
if you still have the warning, please open new issue with steps to reproduce


Layout property not pushed through on rx.plotly

Bug fix
Now both data and layout prop are supported in Plotly figures.

Fix itself looks like, but the tests need to be patched up


Support for the enabling/disabling, required option, visibility change of a control, when some other attributes get changed in the model

The current implementation does not allow to re-render the control, when some other attribute has been changed in the model, and also does not change attributes (i.e. required, disabled, visibility) of the control.
I've modified the Field:

Introduced new attributes.

visible (boolean):
Show/Hide the control
deps (array of name of attributes of the model):
Re-render the control on change of the attributes in the model

Allow to use function/boolean value for required, disabled, visible
These attributes will be evaluated to boolean value from the function before rendering the control.

Also, modified the Control:

Evaluate the required, visible, and disabled attributes during rendering the control.

I've also modified the documentations.

I've fixed all the above code-review comments.
Please have a look at it.

Hi Ashesh,
Great improvements with the disabled and visible options. Also nice to have comments. However I don't think dependant attributes should be there. Can you add that functionality to your own extended controls?

Thanks.
Reason for adding dependency list in Field allowed me, not to bother about any specific control during form creation.
I do use Backform to create forms/views dynamically based on the fields available.
Any way - if you think - it is not very helpful/required feature for any reason, I will use separate branch for my project, and make changes in this branch as per your suggestion.

You don't need another branch. You simply have to hijack the initialize function via the prototype. Add this code to your projects:
var orgInit = Backform.Control.prototype.initialize;
Backform.Control.prototype.initialize = function(options) {
  origInit.apply(this, arguments);
  // Listen to the dependent fields in the model for any change
  var deps = this.field.get('deps');
  var that = this;
  if (deps && _.isArray(deps))
    _.each(deps, function(d) {
      attrArr = d.split('.');
      name = attrArr.shift();
      that.listenTo(that.model, "change:" + name, that.render);
  });
};

The point is we are many using Backform in Amilia. And this functionality we do add when needed by extending the control. Or after creating the control. But we don't need it all the time.
Let me know what you think.

Thanks for the tip.
Though - I may not be agree about changing the control everytime, I will use the suggested approach. :-)
Please take a look at the changes now.


(arch) pluggable runtimes

End-user friendly description of the problem this fixes or functionality that this introduces

[X] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Make runtimes pluggable dynamically without changing code.
Added unit test test_dyn_runtime.py

Dynamic Runtime Registration
This pull request introduces a dynamic runtime registration mechanism, allowing users to add new runtimes without modifying the core openhands codebase.  This enhances extensibility and makes it easier to integrate custom runtimes.
Key Changes:

Default, core runtimes: The _registered_runtimes dictionary serves as the single source of truth for runtime information. It is initialized directly with the core runtime definitions.
Added register_runtime Function:  A register_runtime function has been added to allow dynamic registration of new runtimes.  Users can now register a runtime by providing its name, module, and class name.
Modified get_runtime_cls: The get_runtime_cls function now checks _registered_runtimes.  If the requested runtime is not found there, it raises a ValueError.
Added Unit Tests:  Unit tests have been added to verify the functionality of the dynamic registration and retrieval mechanism, including tests for error handling and mocking the import process.

Benefits:

Extensibility:  Makes it easier to add and integrate new runtimes without modifying core code.
Maintainability: Simplifies the runtime registration logic and reduces code duplication.
Testability:  Improves testability by allowing mocking of the import process.

This change provides a more flexible and maintainable way to manage runtimes in openhands.

@xingyaoww - I still don't understand, what the issue with this PR is. It is aimed to avoid additional hardcoding of names and allows for others to add a runtime without changing core code.

I am hesitant to merge this because we are essentially adding more code (+104 lines and only -11 lines) & performing complex dynamic import to simplify an "if-else" function. I'm still debating whether it is worth it -- @neubig, any idea?

Hi!
Just to clarify, what is the use case that caused this PR in the first place? Do we have a desire to add additional runtimes in some way? If it's not solving an existing problem I would tend towards keeping the code simple, but if there is something else that is blocked by this not existing then I think it is likely justified.

So 40 lines alone are for the unit test. ;)
The idea came to me with #4133 where a ModalRuntime would be introduced. It'd be for a commerical, 3rd party product (with all its own pros and cons).
I'd see it as an advantage if that kind of PR would not need to change "core" code here.

Closing this.


Transform hack/patch.sh into a proper make target

What this PR does / why we need it:
Followup of #5789
Add frictionless support for the patch script with the build container.
One should run now make patch-deployment instead of the patch script
directly.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @qinqon

/lgtm

/retest

/lgtm

/approve
/retest

/retest

@qinqon did another change. The name of the target is now make cluste-patch which should be more in line with the other cluster- commands.

/lgtm

/retest


Superfluous newline when setting report' to warnings'

Logtalk will output a superfluous newline with following config in settings.lgt:
:- initialization(set_logtalk_flag(report, warnings)).

Run following command:
% swilgt.sh -q -t 'write(hi), nl'

hi
%

I'm using Logtalk 3.9.3-rc1 and SWI Prolog 7.2.3.

Fixed in c45a3c6. Thanks for the bug report.


MetricsMiddleware can cause the SwiftPrometheus/PrometheusCollectorRegistry to generate a fatal error

The MetricsMiddleware appears to pass different metric dimensions/ label names for a route if the request succeeds, e.g. 200 response, versus if the request fails, e.g. 400 response. The difference in metric dimensions appears to cause SwiftPrometheus/PrometheusCollectorRegistry to crash with the following message:
SwiftPrometheus/PrometheusCollectorRegistry.swift
// check if all labels match the already existing ones.
if labelNames != labels.allLabelNames {
    fatalError(
        """
        Could not make Counter with name: \(name) and labels: \(labels), since the
        label names don't match the label names of previously registered Counters with
        the same name.
        """
    )
}

The MetricsMiddleware uses the following dimensions/ labels:

Success:

"http.route"
"http.request.method"
"http.response.status_code"

Failure:

"http.route"
"http.request.method"
"error.type"

The error.type value appears to be set to the response HTTP status code.
Possible fix: The crash goes away when error.type is replaced with http.response.status_code.
Here's a simple set up:
func run() async throws {
    MetricsSystem.bootstrap(PrometheusMetricsFactory(registry: PrometheusCollectorRegistry()))

    let router = Router()
    router.addMiddleware {
        LogRequestsMiddleware(.debug)
        MetricsMiddleware()
    }

    struct Hello: Decodable {
        let name: String
    }

    router.get("debug/hello") { request, context in
        let message = try await request.decode(as: Hello.self, context: context)
        return "Hello, \(message.name)"
    }

    let application = Application(
        router: router,
        configuration: ApplicationConfiguration(
            address: .hostname(hostname, port: port),
            serverName: serverName
        ),
        logger: Logger(label: serverName)
    )

    try await application.runService()

Here are a few commands that call the "debug/hello" route. Executing each request in a running application should cause the crash.
200 response
curl --location --request GET 'localhost:8080/debug/hello' \
--header 'Content-Type: application/json' \
--data '{
    "name": "Bill"
}'
Hello, Bill

400 response
curl --location --request GET 'localhost:8080/debug/hello' \
--header 'Content-Type: application/json' \
--data '{
    "foo": "Bill"
}'
{"error":{"message":"Coding key `name` not found."}}

The responses are expected. The mentioned crash is not expected.
Version details:

Hummingbird 2.1 (explicit dependency)
SwiftPrometheus: 2.0 (explicit dependency)
Swift Metrics 2.5 (explicit dependency)

Thanks in advance.

@adam-fowler @Joannis Thank you for quick turnaround.


Add useful context to WebDriver errors

With the "Promise-based" API from "wd", you can't actually handle
rejections.  You can intercept them with .then(), but they still
register as "unhandled rejections" in Karma, and the error messages
are devoid of useful context.
This change uses the older callback-based model of "wd" instead, so
that we can make sure the error log contains enough context to pin
down issues to the specific Selenium node that failed.
Closes #38

Overall I would encourage you to get rid of ‘wd’. Selenium has a native node client (4.0.0a) or the webdriver.io package.

Understood.  I'll file a new issue and consider that for the future.  Thanks!


Show correct information about AdoNet scripts

It looks like this part of documentation was not changed after scripts were removed from nuget packages. I spent quite a while today looking everywhere for OrleansAdoNetContent folder, while the scripts were listed on next docs page.

Docs Build status updates of commit be6a45b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

src/docs/host/configuration_guide/configuring_ADO.NET_providers.md
:warning:Warning
View
Details

src/docs/host/configuration_guide/configuring_ADO.NET_providers.md

Line 54, Column 260: [Warning: file-not-found - See documentation] Invalid file link: '~/docs/host/configuration_guide/adonet_configuration.md'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Automatically infer scale and offset from units attribute

When reading a netCDF CF-compliant input file, parse the units and infer scale and offset parameters.
Todo:

[ ] Add change to history
[ ] Remove explicit scale and offset configuration from tests

@huard You may want to pin pint in this PR. See: https://github.com/hgrecco/pint/issues/1631
Changes will be available in the newest xclim once https://github.com/Ouranosinc/xclim/issues/1211 is resolved.


Lit dev playground doesn't seem to work for @lit-labs/motion examples

I've seen these working before, but they don't appear to be loading for me today:

Navigate to https://lit.dev/playground/
Open the Sliding Circle example within the Motion section

Expected: Loading bar disappears eventually and preview loads in right-hand panel.
Actual: Loading bar persists and preview does not appear.

This seems like an issue with the unpkg CDN not being able to serve some dependencies. Hopefully it's a temporary issue but if it persist we may need to look into changing the CDN or serving core deps ourselves.

Consider switching to https://www.jsdelivr.com/
Its production focused with lots of high availability systems and features like API and stats

Playground appears to be working fine now.

I'll close the issue for now. If the unpkg becomes less reliable, we'll need to revisit this. We'd need https://github.com/google/playground-elements/issues/187 to be implemented to swap CDNs.


[Bug] Multi-selecting packaged apps adds only a single rule

Hi,
Multi-select for packaged app only adds one app to the rule. Regression? https://github.com/MicrosoftDocs/WDAC-Toolkit/pull/49

Hi @hj-collab, you can multi-select in the packaged app rules config panel -

Are you indicating you are not seeing all of your PFN rules in the policy?

@hj-collab I see what you are seeing. This is a bug. Thanks for reporting this!


Translation for engines.

Hello !
I'm trying to figure out how to get the translation working for my engines that I generated.
I saw that in database for some natif engine there is a engine_name_translation table in database, I build my own for my engine generated with rails generate refinery_engine. It great, it works, but it's not translatable as pages.
Please can some own explain me, how to activate it ?

I tried this (it works, some one can suggest something ?) Maybe there is something already build in refinery to automate it ?
_locale_picker.html.erb > new file

<% if (locales ||= ::Refinery::I18n.frontend_locales).present? and locales.many? %>

    <% locales.each do |locale| %>
      >
        <%= link_to refinery_icon_tag("flags/#{locale}.png", :size => '48x33'),
                    url_for(:switch_locale "engine_name"=> locale) %>

    <% end %>

<% end %>
==
_form.html.erb > add render
<%= render :partial => "locale_picker",
:locals => {
:current_locale => Thread.current[:globalize_locale]
} if defined?(::Refinery::I18n) %>
_"engine_name".html.erb > add lines
<% if defined?(::Refinery::I18n) and ::Refinery::I18n.frontend_locales.many? and
(locales = "engine_name".translations.collect{|t| t.locale}).present? %>

<% locales.each do |locale| %>
<%= refinery_icon_tag "flags/#{locale}.png", :size => '16x11' %>
<% end %>

<% end %>
"engine_name".rb model > add
translates :name, :quote
rejects any page that has not been translated to the current locale.
scope :translated, lambda {
  pages = Arel::Table.new("engine_name".table_name)
  translations = Arel::Table.new("engine_name".translations_table_name)

  includes(:translations).where(
    translations[:locale].eq(Globalize.locale)).where(pages[:id].eq(translations[:"engine_name"_id]))
}

=========
DATABASE
add table
"engine_name"_translations
id integer
"engine_name"_id integer
locale varchar(255)
"your fields" varchar(255)
"your fields" varchar(255)
created_at datetime
updated_at datetime

There is nothing to automate that yet but thanks for the gist!
@ZMaxim does that solution work well for your purpose according to this issue?

Ir works great for me :)
I will try to add it to the doc, I think it might help others !
Le 16 janv. 2012 à 21:17, Philip<EMAIL_ADDRESS>a écrit :

There is nothing to automate that yet but thanks for the gist!
@ZMaxim does that solution work well for your purpose according to this issue?

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms/issues/1216#issuecomment-3517386

Cool if you get time please open a pull request :)

You announced that there will be a 2.0 refinery, my technique will be still working?
If there will be a major update, should I wait to see how Refinery 2.0 Works ?
Le 27 janv. 2012 à 23:17, Philip Arndt a écrit :

Cool if you get time please open a pull request :)

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms/issues/1216#issuecomment-3695178

That should largely still work but with some updates to the syntax and the classes used.
You can see the code that will be 2.0 in the master branch currently :)

OK thanks !
Le 2 févr. 2012 à 10:49, Philip Arndt a écrit :

That should largely still work but with some updates to the syntax and the classes used.
You can see the code that will be 2.0 in the master branch currently :)

Reply to this email directly or view it on GitHub:
https://github.com/resolve/refinerycms/issues/1216#issuecomment-3775186


Getter/setter “is used reflectively but not in MirrorsUsed” warning after dart2js compilation

In my class, I have getters and setters which are working thanks to NoSuchMethod - that is, they're not explicitly defined. After I compile and run the js, I get the following error in the browser console:
Warning: 'closes_in=' is used reflectively but not in MirrorsUsed. This will break minified code.

In this case, closes_in= is an example of such a setter and there are some other warnings related to other getters/setters too. I do have a @MirrorsUsed with the name of the library/class included and the resulting compiled js is actually smaller than it was without using @MirrorsUsed statements.
However, if a -m flag is passed to dart2js, then when the js program runs it fails - as predicted by the warning message.
Thus, I have two questions:

How do I write my @MirrorsUsed statement so that the warning goes away?
If it's not possible, how do I suppress the warning message? (because if it's not possible to solve the problem, then my only option would be to NOT minify the file then).

I can't find relevant documentaion for this, thus I'm posting it into the issues. Hope this is something that just needs a better explanation, rather than a fix.

I'm taking a stab in the dark (missing too much context), but probably you just have to add
@MirrorsUsed(symbols: const ["foo", "bar", ...]) on an import of dart:mirrors, where "foo", "bar", ... are the names of the fields you want to support. The example in the MirrorsUsed class covers this case:
https://api.dartlang.org/stable/1.18.1/dart-mirrors/MirrorsUsed-class.html
Alternatively, you should just use symbols instead of getting the string-representation of the symbol.
If you don't know the names of the members that are invoked on your class, and you need their string-representations, then you don't really have a choice but to run in unminified mode. Afaik, dart2js doesn't have a mode where it minifies everything but the members (which is what would be needed).
Ccing @sigmundch in case I missed something.
I don't think there is anything actionable, so I'm closing this bug for now.


refactor(types): rename EventOptions to ListenerOptions

With the migration to using Listener instead of events, the type for EventOptions was missed, and this PR fixes those types.
In addition to this, I scanned the repository for additional mentions of the EventOptions and Event in general, and did not find anything.

There's also /src/lib/types/Events.ts (with an enum named listeners inside it.)

I believe that Enum is intended

I meant the one at line 9 and yeah, my bad I thought it was an enum, there's also the file name


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-06-30)
Features

add mhGetBodyHTML function to get html (62c8293)
add npm instead of yarn and remove duplicate docker file (beda66f)
add typescript (7b1dc5b)
ci: adds release-please.yml to automate release process (b584474)
refactor to typescript (bac8e0f)
rewrite in typescript with new assertions (3c2eb2c)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


Excluding older guava versions in the root pom.xml.

Explicitely relying on guava 13 for the integration tests.

FYI, both the hbase minicluster and bigtable integration tests pass.

First, I agree on the java5 exclude. Second, questions:

Would it be better to have a direct dependency on guava ${guava.version} to override the hadoop/hbase dependency? (and keep the guava 13 in integration tests)
If not, it seems that having excludes might be prone to things sneaking in again in the future. Consider using: http://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html to ban guava versions less than 18 [,18.0]

I'm not sure where you mean.  We already have a dependency on guava 18.0 in bigtable-hbase.  We shade in that dependency in bigtable-hbase-1.0.  We need guava 13 in integration tests.  I'm not sure how ${guava.version} helps us in this case.  What problem does ${guava.version} solve?

good idea.  I'll add it to bigtable-hbase-1.0 and -1.1.

Oh, I see.  It makes sense to add a ${guava.version} so it's consistent between the inclusion and the bannedDependenies plugin

For 1) - if the hbase-1.0 and hbase-1.1 jars depend directly on guava, then the version they reference will win for the purposes of dependency resolution. At that point, excludes are probably not required.
LGTM, anyways. Feel free to modify or not.

Ugh.  I forgot to rebase -i master first.  Sorry.


Test failing

One of the tests seem to fail. See log below. Any help in solving this would be appreciated.
$ bundle install
Resolving dependencies...
Using rake 10.4.2
Using i18n 0.7.0
Using json 1.8.3
Using minitest 5.8.0
Using thread_safe 0.3.5
Using builder 3.2.2
Using erubis 2.7.0
Using mini_portile 0.6.2
Using rack 1.6.4
Using mime-types 2.6.1
Using arel 6.0.3
Using addressable 2.3.8
Using ast 2.0.0
Using bcrypt 3.1.10
Using bundler 1.11.2
Using eventmachine <IP_ADDRESS>
Using hiredis 0.6.1
Using http_parser.rb 0.6.0
Using multipart-post 2.0.0
Using multi_xml 0.5.5
Using terminal-table 1.5.2
Using powerpack 0.1.1
Using rugged 0.22.2
Using thor 0.19.1
Using rainbow 2.0.0
Using ruby-progressbar 1.7.5
Using sqlite3 1.3.10
Using tzinfo 1.2.2
Using nokogiri <IP_ADDRESS>
Using rack-test 0.6.3
Using sprockets 3.3.2
Using mail 2.6.3
Using parser <IP_ADDRESS>
Using em-hiredis 0.3.1
Using faraday 0.9.1
Using httparty 0.13.5
Using activesupport 4.2.3
Using loofah 2.0.3
Using astrolabe 1.3.0
Using sawyer 0.6.0
Using gitlab 3.4.0
Using rails-deprecated_sanitizer 1.0.3
Using globalid 0.3.6
Using activemodel 4.2.3
Using rails-html-sanitizer 1.0.2
Using rubocop 0.32.0
Using octokit 3.8.0
Using rails-dom-testing 1.0.7
Using activejob 4.2.3
Using activerecord 4.2.3
Using pronto 0.4.2 from https://github.com/Zauberstuhl/pronto.git (at master@292d8ac)
Using actionview 4.2.3
Using diaspora-vines 0.2.0.develop.4 from source at `.`
Using pronto-rubocop 0.4.4
Using actionpack 4.2.3
Using actionmailer 4.2.3
Using railties 4.2.3
Using sprockets-rails 2.3.2
Using rails 4.2.3
Bundle complete! 7 Gemfile dependencies, 59 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

$ bundle exec rake
Was not able to load config/application.rb! This not a standalone version. You should use it only in a diaspora environment.
Was not able to load config/load_config.rb! This not a standalone version. You should use it only in a diaspora environment.
Was not able to load config/initializers/devise.rb! This not a standalone version. You should use it only in a diaspora environment.
Run options: --seed 55337

# Running:

..............................S..................................................................................................................................S..S............S............................................................................................................................................................................................................................................E..............

   1) handles invalid input
      NoMethodError: undefined method `ascii_only?' for nil:NilClass
          /usr/lib/ruby/2.2.0/openssl/ssl.rb:172:in `verify_hostname'
          /usr/lib/ruby/2.2.0/openssl/ssl.rb:161:in `block in verify_certificate_identity'
          /usr/lib/ruby/2.2.0/openssl/ssl.rb:159:in `each'
          /usr/lib/ruby/2.2.0/openssl/ssl.rb:159:in `verify_certificate_identity'
          /home/balasankarc/packaging/trying/diaspora-vines/original/vines/lib/vines/store.rb:126:in `block (2 levels) in files_for_domain'
          /home/balasankarc/packaging/trying/diaspora-vines/original/vines/lib/vines/store.rb:125:in `each'
          /home/balasankarc/packaging/trying/diaspora-vines/original/vines/lib/vines/store.rb:125:in `block in files_for_domain'
          /home/balasankarc/packaging/trying/diaspora-vines/original/vines/lib/vines/store.rb:124:in `each'
          /home/balasankarc/packaging/trying/diaspora-vines/original/vines/lib/vines/store.rb:124:in `files_for_domain'
      # /usr/lib/ruby/2.2.0/openssl/ssl.rb:172
      # /usr/lib/ruby/2.2.0/openssl/ssl.rb:161
      # /usr/lib/ruby/2.2.0/openssl/ssl.rb:159
      # /usr/lib/ruby/2.2.0/openssl/ssl.rb:159
      # lib/vines/store.rb:126
      # lib/vines/store.rb:125
      # lib/vines/store.rb:125
      # lib/vines/store.rb:124
      # lib/vines/store.rb:124
      # test/store_test.rb:41

   2) raises a service-unavailable stanza error [SKIPPED]
      test/stanza/message_test.rb

   3) save fragment [SKIPPED]
      test/storage/sql_test.rb

   4) find fragment [SKIPPED]
      test/storage/sql_test.rb

   5) writes the stanza to the connected user streams [SKIPPED]
      test/cluster/subscriber_test.rb

Finished in 6.845142s, 62.6722 runs/s, 136.3010 assertions/s.
429 runs, 933 assertions, no failures, 1 error, 4 skips

Failed Tests:

rake TEST=/home/balasankarc/packaging/trying/diaspora-vines/original/vines/test/store_test.rb TESTOPTS="--name=test_0001_handles invalid input"

After_run hook deleted test.db
rake aborted!
Command failed with status (1): [ruby -I"lib:test:test/storage" -I"/usr/lib/ruby/vendor_ruby" "/usr/lib/ruby/vendor_ruby/rake/rake_test_loader.rb" "test/**/*_test.rb" ]

Tasks: TOP => default => test
(See full trace by running task with --trace)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30437858-test-failing?utm_campaign=plugin&utm_content=tracker%2F4635430&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F4635430&utm_medium=issues&utm_source=github).

@balasankarc you probably haven't  configured your certs here conf/certs/ ?!

Ah. I didn't know it was required even for running tests. Lemme check.


Help/info needed: Cookie expiry via wizard/configurator install seemingly random

I've used the wizard/configurator route to install a simple notification (and styled it a bit with css). It's working pretty well but the acknowledgment seems to expire randomly and site visitors are seeing the consent popup frequently. Some value is definitely being set, because it's possible to dismiss the popup for at least some interval of days.
My first question is: what is the actual default term of acknowledgment that's being applied?
My second question is: if I have to modify this via the available javascript api, can someone help with a specific example of how you'd dismiss the popup for 90 days? I don't see any adaptable examples of working with this in the docs (https://cookieconsent.osano.com/documentation/javascript-api/)
Code:
<link rel="stylesheet" type="text/css"<EMAIL_ADDRESS>/>
<script<EMAIL_ADDRESS><script>
	window.addEventListener("load", function () {
		window.cookieconsent.initialise({
			"palette": {
				"popup": {
					"background": "#53565A"
				},
				"button": {
					"background": "#FFC72C"
				}
			},
			"content": {
				"message": "We use cookies to provide you with the best possible user experience. By continuing to visit this site, you agree to our use of cookies.",
				"dismiss": "Ok",
				"link": "More info",
				"href": "https://www.mills.edu/policies/cookie-policy.php"
			}
		})
	});
	window.cookieconsent.utils.isMobile = function () {
      return false;
    };
</script>

I feel like https://github.com/osano/cookieconsent/issues/622?_pjax=%23js-repo-pjax-container addresses this question in part so I'm closing out my own inquiry. Thanks @hvbe


Run more than 34 processes on Win32 if we have 32+ cores.

For a compatiblity reason, dwNumberOfProcessors in Win32 is capped at 32.
So even if your machine has more than 32 cores, Ninja spawns at most 34
subprocesses if compiled as 32 bit application. This patch fixes the issue by
using GetNativeSystemInfo, which returns the system info from Wow64 point
of view, instead of GetSystemInfo.
GetNativeSystemInfo is supported since Windows XP or Windows Server 2003.

Clearly I need to get a new computer to test this properly. :)

I recently got a beefy machine with 20 physical cores (40 logical cores). I confirmed that Ninja reports it had 32 processors. With this patch it correctly recognized 40 cores.

Thanks! (Might've deserved a comment, but fine as is too.)


Worlds with lots of water at spawn can crash the game at generation.

Certain seeds which try to generate large amounts of water can crash at generation, making those seeds unplayable. Will update this issue once I find specific seeds that cause this for testing as I do not currently have a list.

Seed<PHONE_NUMBER>375465181 causes this crash


Run TypeScript typechecking and eslint on Lint CI

Pull Request Description

Runs npm run typecheck on Lint CI
Runs npx eslint . on Lint CI

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

idk tbh. the lint seems to fail with linker errors around half the time. might only be an issue on certain runners?
it might have something to do with this PR adding a dependency...???

force-pushed because the other commits have been merged into develop

linker error is still happening: https://github.com/enso-org/enso/actions/runs/4922094467/jobs/8792728885?pr=6603
@mwu-tow would you happen to know what might cause this?

@mwu-tow would you happen to know what might cause this?

These are random runner corruptions that happen sometimes on incremental compilation. I'll clean the runners and rerun the job.

@mwu-tow would you happen to know what might cause this?

These are random runner corruptions that happen sometimes on incremental compilation. I'll clean the runners and rerun the job.

@mwu-tow would you happen to know what might cause this?

These are random runner corruptions that happen sometimes on incremental compilation. I'll clean the runners and rerun the job.

@mwu-tow would you happen to know what might cause this?

These are random runner corruptions that happen sometimes on incremental compilation. I'll clean the runners and rerun the job.

reviews: addressed
fixes: pushed
./run git-clean; ./run lint still works locally: yes

QA 🟢 I just see 1 warning in console though
TRACE ide_ci::program::command: npx⚠ <START>
 INFO ide_ci::program::command: npxℹ
 INFO ide_ci::program::command: npxℹ /Users/pawelbuchowski/projects/enso/app/ide-desktop/lib/dashboard/src/authentication/src/fileInfo.ts
 INFO ide_ci::program::command: npxℹ   11:26  warning  '_extension' is defined but never used  @typescript-eslint/no-unused-vars
 INFO ide_ci::program::command: npxℹ
 INFO ide_ci::program::command: npxℹ ✖ 1 problem (0 errors, 1 warning)
 INFO ide_ci::program::command: npxℹ
TRACE ide_ci::program::command: npxℹ <ENDUT>
TRACE ide_ci::program::command: npx⚠ <ENDUT>

@somebody1234 what is the status? do we want to merge it now? Are we sure it will not destabilize CI?

merging with develop to minimize the chance of issues


[kube-state] improve testing

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?

improve testing on kubernetes_state check (new test + more metrics tested).
replace protobuf.bin with more recent version (0.3 --> 0.4.1)

Motivation
We had a bad metric collection that should have been caught by tests.
Testing Guidelines
Just run the tests
Additional Notes
Linked to https://github.com/DataDog/dd-agent/pull/3297
Also rename a single-letter variable because it's not pdb friendly.

CI fails because it needs https://github.com/DataDog/dd-agent/pull/3297 to be merged... and https://github.com/DataDog/dd-agent/pull/3297 needs this one for its CI to pass. But tests pass locally.


Config options to disable all vscode providers except code completion

I have another vscode extension which provides things like goto definition, type hover, etc, except code completion. Is it possible / would a PR be accepted / to add config options that disable these providers?

@jacobdufault which extension btw?

It's a WIP project that integrates rtags. I plan on publishing it when I have it in a more polished state.

@jacobdufault if you ever happen to release it please notify me :)

It would be better that have switch for each provider caused I only want to turn off definition.


Vulkan version?

I would like to know the vulkan version used? I used <IP_ADDRESS> compile error.

Hi, wyj302.
At leaset need vulkan 1.3, I‘m using <IP_ADDRESS> ver.

Hi, wyj302. At leaset need vulkan 1.3, I‘m using <IP_ADDRESS> ver.

thank you for yao answer, i used 1.3 compile success, but run error at RHICheck(vkCreateDevice(m_gpu, &createInfo, nullptr, &m_device)),  on gtx1060(6G)，Is the GPU too low？

Hi, wyj302.
Maybe need to update graphics driver because I'm using the most recent vulkan features.

Hi, wyj302. Maybe need to update graphics driver because I'm using the most recent vulkan features.

Hi, quitang98, I want to know what kind of graphics card you're using? thanks.


can't remove marker using addTo and removeFrom

Hi, impossible to remove layer using addTo and removeFrom

None of the online examples is currently using this, but it is working correctly for me when using marker.removeFrom(earth).
Make sure you are linking the latest script version from http://www.webglearth.com/v2/api.js and that both marker and earth are defined when executing the code above (or similar).

how to remove polygon。thank you！