Can support xls?

@CodyGuo Thanks for your issue. The legacy XLS use Object Linking and Embedding (OLE) format, it's completely different with OOXML and can't be supported by the same code. To support this feature maybe needs to evaluate.

@Luxurioust Thank you, waiting for your good news.

see https://github.com/extrame/xls

@xuri The xls spec if pretty heavy duty and entirely different from reading xlsx. I think it would be reasonable to say we won't support the legacy xls format and close this and the related issues.

a conclusions yet？

@xuri Any update yet?

Any update on this topic? I really need to read xls file instead, due to business format usage.

see https://github.com/extrame/xls

Thank you!!!

So we have to use a totally different library for xls?

So we have to use a totally different library for xls? Hmm.. 🤔

It seems that you have to use a different library. The other one is easy to use. If you are going to use it, consider that it has a bug with the master branch tagging and you will have to go get github.com/extrame/xls/xls@4a6cf263071b975a90abf74ca3e804b48243be28

The github.com/extrame/xls lib is too old now and has a lot of bugs. The biggest bug is https://github.com/extrame/xls/issues/56 that, I don't think will get fixed soon.
If this lib is not support all functionalities for XLS, maybe make a conversion function to convert it to XLSX so we can use this lib in peace? :)

xlsx was introduced with Microsoft office 2007 and can be read with zip + xml parsers. It supports far more rows and allows for compression.
xls is a binary format, is limited to ~65k rows, and parsing it requires an entirely separate set of tools: https://interoperability.blob.core.windows.net/files/MS-XLS/[MS-XLS].pdf
I'd really like to know, why are you using xls instead of xlsx in 2023? Is it macro support?

I'd really like to know, why are you using xls instead of xlsx in 2023? Is it macro support?

Same on this issue's comment here: https://github.com/qax-os/excelize/issues/341#issue-403488280
That's because my company is still using the XLS format as a default instead, sadly! :(

I really don't see this getting added to the library due to the complexity involved. Like I said, it's not a similar implementation at all.
Java has Apache POI: https://poi.apache.org/ which is probably your most complete, free option.
There's a go wrapper for libxls: https://github.com/godzie44/go-xls
Over on the C# side if you have Windows there are some free libraries that support interop to office and can do conversion. If you're not on Windows (and that's unlikely for your server, and probably a risk to install there anyway) there are some paid libraries.
There's also a Python library: https://pypi.org/project/xlrd/


V2 - There is no option to clear search criteria

Prerequisite

Create a CLA group with CCLA enabled
Add github repository for the CLA group
Generate template
Company should have signed CLA for the CLA Group

Steps to Follow

Login to Github as individual contributor
Navigate to the repository used in prerequisite
Create PR
CLA check fails
Click on CLA NOT SIGNED
Contributor is redirected to Contributor Console
Click on Proceed as a Corporate Contributor
Observed that there is no option to clear search criteria

@pranab-bajpai
From usability perspective user should be able to clear search criteria. Could you please confirm if we need an option to clear search criteria

I think this behavior is fine.


RF433 Bridge lost ID's of device on last (2.4.4) update

Just updated from 2.4.3 to 2.4.4 and got some bug.
All the sensors connected to my bridge became: unnamed device, unnamed device2 etc
I have not changing any of config options
config.yaml
sonoff:
  username: yyy
  password: xxx
  mode: cloud
  force_update: [temperature, humidity, power]
  scan_interval: '00:05:00'  # (optional) default 5 minutes
  sensors: [temperature, humidity, power, current, voltage]
  rfbridge:
    Smoke1:
      name: Smoke Gost
      device_class: smoke
      timeout: 15
    Smoke2t:
      name: Smoke Tech
      device_class: smoke
      timeout: 15
    Smoke3s:
      name: Smoke Spaln
      device_class: smoke
      timeout: 15
    Smoke4d:
      name: Smoke Det
      device_class: smoke
      timeout: 15
    Leak1:
      name: Leak TechRoom
      device_class: moisture
      timeout: 30
    PIR1:
      name: PIR-1
      device_class: motion
      timeout: 30

GREATE!!!!!!
Thanks a lot!
Спасибо большое за оперативонсть! супер!
PS Fixed in v2.4.5


beginnings of register templates

start of register templates

I already pushed this files as part of the work of creating the html representation of the register


Opam package erroring due to wrong file location

I have just been trying to use the opam package, but when trying to build a simple example, I get the following error:
Fatal error: exception Sys_error("/home/meven/.opam/autosubst-ocaml/share/autosubst/fintype.v: No such file or directory")
Raised by primitive operation at Stdlib.open_in_gen in file "stdlib.ml", line 398, characters 28-54
Called from Stdlib.open_in_bin in file "stdlib.ml" (inlined), line 406, characters 2-47
Called from Autosubst_lib__Program.read_file in file "lib/program.ml", line 74, characters 14-32
Called from Autosubst_lib__Program.copy_file in file "lib/program.ml" (inlined), line 102, characters 33-48
Called from Autosubst_lib__Program.gen_static_files.copy_static_file in file "lib/program.ml", line 130, characters 4-74
Called from Autosubst_lib__Program.gen_static_files in file "lib/program.ml", line 134, characters 20-48
Called from Autosubst_lib__Program.main in file "lib/program.ml", line 177, characters 9-75
Called from Stdlib__result.map in file "result.ml", line 25, characters 32-37
Called from Monadic__Result.MakeT.ResultMonad.bind in file "monadic/library/result.ml", line 31, characters 24-33
Called from Stdlib__result.map in file "result.ml", line 25, characters 32-37
Called from Monadic__Result.MakeT.ResultMonad.bind in file "monadic/library/result.ml", line 31, characters 24-33
Called from Dune__exe__Main.main in file "bin/main.ml", line 6, characters 12-35
Called from Dune__exe__Main in file "bin/main.ml", line 10, characters 9-16

It seems like the culprit is this line, which hardcodes that the files are to be found in the share/subst folder, while the opam installation puts them in share/coq-autosubst-ocaml.

Does it work if you change the path and compile manually? Maybe this is due to a change in opam? It seems to me like the comment above explains what is going on. If changing the path works, we can change the code and the layout in the repo to match the (maybe new) opam file layout

I could not find the files opam downloads to change & rebuild them manually, but using the other approach of renaming share/coq-autosubst-ocaml to share/autosubst in my opam installation, things seem to work fine.

My office mate suggests that this might be a dune change. The relevant information seems to be here regarding section vs section_root. So changing the dune recipe in share might be enough.

Hi. It seems to me the issue is not solved?
When I run autosubst I get
Fatal error: exception Sys_error("~/.opam/autosubst-ocaml/share/autosubst/unscoped.v: No such file or directory")

The real path is ~/.opam/autosubst-ocaml/share/coq-autosubst-ocaml/unscoped.v (notice how the second autosubst also has to be renamed to autosubst-ocaml).

I installed from opam using the instructions of the README (which installed Coq 8.13 in a fresh switch).

Sorry, that's the problem. It seems I didn't release a new opam package.
If you clone, checkout coq-8.13 as branch, and do dune build, dune install you should be good to go

I see sorry.


esp32s3 usb host example cdc_acm_bg96 receive some message repeatly (IDFGH-7027)

Hi all:
I used the esp32s3 board to develop one usb host fuction.
I used the master branch code.
the device was the cdc-like device which connect to esp32s3's usb[GPIO 19 20] via one usb to uart chip(ft231xq).
I can find this device by the example of usb host lib,which show below info:
//-----------------------------------------------------------------------
*** Device descriptor ***
bLength 18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 0x0
bDeviceSubClass 0x0
bDeviceProtocol 0x0
bMaxPacketSize0 8
idVendor 0x403
idProduct 0x6015
bcdDevice 0.00
iManufacturer 1
iProduct 2
iSerialNumber 3
bNumConfigurations 1
I (5417) CLASS: Getting config descriptor
*** Configuration descriptor ***
bLength 9
bDescriptorType 2
wTotalLength 32
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes 0xa0
bMaxPower 90mA
*** Interface descriptor ***
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 0xff
iInterface 2
*** Endpoint descriptor ***
bLength 7
bDescriptorType 5
bEndpointAddress 0x81   EP 1 IN
bmAttributes 0x2        BULK
wMaxPacketSize 64
bInterval 0
*** Endpoint descriptor ***
bLength 7
bDescriptorType 5
bEndpointAddress 0x2    EP 2 OUT
bmAttributes 0x2        BULK
wMaxPacketSize 64
bInterval 0
I (5477) CLASS: Getting Manufacturer string descriptor
FTDI
I (5487) CLASS: Getting Product string descriptor
FT231X USB UART
I (5487) CLASS: Getting Serial Number string descriptor
DQ008964
//-----------------------------------------------------------------------
but when I try the example of cdc_acm_bg96,
of course I change the code of vid,pid to my device.
comment some code of bg96 special,like send AT cmd etc.
so the code is simple:
1.open the device with rx handle function.
2.print data of rx handle function.
the device seems open ok from log:
//--------------
D (2430) USBH: Processing actions 0x100
D (2430) USBH: New device 1
D (2440) cdc_acm: New device connected
D (2440) cdc_acm: Checking list of connected USB devices
D (2450) CDC_ACM: Submitting poll for BULK IN transfer
D (2450) CDC_ACM: in xfer cb
//-------------
but I received repeated messages which has len 2,
first was 0x11,two was 0x60.
it received again and again.
the device is ok,I connect it to pc's usb port.
it works,it not send the 0x11 0x60 message.
it just return message after I send some cmd to it.
I check the ascii,the 0x11 ofter used for XON flag,I don't know what should I do.
from the cdc_acm_bg96's readme,the device should be support:
//--------------------------------------
Supported Devices
The CDC-ACM Host driver supports the following types of CDC devices:

CDC-ACM devices
CDC-like vendor specific devices (usually found on USB to UART bridge devices)

CDC-Like Vendor Specific Devices
The CDC-ACM Class driver supports CDC-like devices that meet the following requirements:

The device class code must be set to the vendor specific class code 0xFF
The device needs to provide and interface containing the following endpoints:

(Mandatory) Two Bulk endpoints (IN and OUT) for data
(Optional) An interrupt endpoint (IN) for the notification element

For CDC-like devices, users are responsible for ensuring that they only call APIs (e.g., cdc_acm_host_send_break()) that are supported by the target device.
//-----------------------------------------------
any advice is welcome!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Hello @zhuyeaini9 , thank you for reaching out to us.
I can confirm that I reproduced the problem with FTDI 232RQ (PID: 0x6001), that is almost the same as your chip (comparison here)
It is something FTDI specific, but I'll prepare an example how to handle this

thanks@tore-espressif,really helpful.
for the line coding setting.
I remember I also try the method:cdc_acm_host_line_coding_set
after open the device,but the log show error of it:
//---------------------------------
E (9640) cdc_acm: cdc_acm_host_set_control_line_state(1113):
//---------------------------------

That's correct, FTDI chips don't use commands as defined in USB CDC specification but their own vendor specific commands.
The FTDI implementation is currently under internal review. I'll update this issue when it gets public, thanks!

That's correct, FTDI chips don't use commands as defined in USB CDC specification but their own vendor specific commands.
The FTDI implementation is currently under internal review. I'll update this issue when it gets public, thanks!

got it.

any update?

@zhuyeaini9 sorry for the delay.
If you are willing to test my work-in-progress code, you can try this example: https://github.com/tore-espressif/esp-idf/tree/feature/usb_host/cdc_custom_commands/examples/peripherals/usb/host/cdc/cdc_acm_vcp
The API can change in the official release, though.
There are couple of points we need to internally agree upon:

Currently the examples are in C++ only, as we need to override certain functions (FTDI specific) which is easily done in C++
Creating and destroying the driver object is not clean

Your feedback would be greatly appreciated, thanks!

Hello,
Thank you for your work @tore-espressif
Does this example works also with the FT2232D ?

Hello,
Thank you for your work @tore-espressif
Does this example works also with the FT2232D ?

Hello, I have not tested with FT2232D.
You can easily try it out by updating the PID of the device in the driver and invoke this constructor https://github.com/espressif/esp-usb/blob/master/host/class/cdc/usb_host_ftdi_vcp/include/usb/vcp_ftdi.hpp#L38

Thank you so much for your quick reponse, the codes are compatible also with the SIP ESP32-S3-PICO as it has the USB 1.1 OTG support right ?

yep, all modules based on S3 have USB 1.1 host support.

You are the best guys, thank you !

Beaware of hardware of your development board. Not all boards have USB (pin 19 and 20) wired out to USB-A connector

Excuse me, please. Can this library be independent of ESP32? I believe it can be used on other boards as well, since it's written entirely in C++ code. Am I right? Also, does this library support bidirectional communication?


UnicodeDecodeError when receiving flag_info info error

Hi all,
First of all thanks to spookylukey (and also dcramer) for this super library. I have recently discovered that sometimes Paypal is returning some unreadable characters in the 'flag_info' field and an UnicodeDecodeException exception is raised in the following line:
self.flag_info += info
of file: django_paypal-0.1.3-py2.7.egg/paypal/standard/models.py
I guess that a try/catch surrounding the line and managing the unicode variable properly should be enough to fix it.
Best regards from Barcelona,
Álvaro Vélez.

Closing as not enough info was provided, and this is old now.

Hi,
I'm having this error in my application using version 0.2. This is the request params that's causing this:
{
  "protection_eligibility": "Ineligible",
  "last_name": "Bar",
  "txn_id": "25F78140PL237475G",
  "receiver_email"<EMAIL_ADDRESS>  "payment_status": "Completed",
  "tax": "0.00",
  "residence_country": "BR",
  "invoice": "0c85c58f-df5b-baz-bar-foo",
  "payer_status": "unverified",
  "txn_type": "web_accept",
  "handling_amount": "0.00",
  "payment_date": "17:00:38 Apr 19, 2015 PDT",
  "first_name": "Foo",
  "item_name": "Foobar",
  "charset": "windows-1252",
  "notify_version": "3.8",
  "receiver_id": "27L7EUKFFCSPS",
  "business"<EMAIL_ADDRESS>  "payer_id": "W832M3A7B44MU",
  "verify_sign": "AaXhtpwght6PEuy-z7LFdf...",
  "mc_fee": "3.10",
  "mc_currency": "BRL",
  "shipping": "0.00",
  "payer_email"<EMAIL_ADDRESS>  "payment_type": "instant",
  "mc_gross": "39.00",
  "ipn_track_id": "f17a",
  "quantity": "1"
}

I'm seeing this as well. It looks like a Unicode object (self.flag_info) is concatenated with a byte object info which contains non-ascii characters.
All assignments of flag here are byte objects and the last two may contain non-ascii characters. Not sure if this is the root cause though.

@spookylukey Can you open this issue again? I'll try to look into it and fix.

I'm having the same issue.
I looked it up and in fact it is two problems :pensive:
1st: UnicodeDecodeError
The problem and solution proposed by @stefanw is ok. When a form error have no-ascii characters we get the error. It was happening because my django is in pt-BR and my form errors have accents.
The real error in fact was that PayPal retry_at field was not in the PayPal date format.
I saw that many fields was already patched. I did a quick test adding retry_at in that list and it worked fine. But I didn't run any unit tests yet.
What do you guys think? I can send a PR later.

The UnicodeDecodeError should have been addressed in https://github.com/spookylukey/django-paypal/commit/686382b58b2a047e2e61906fdc5f2211cef468f1

Both issues should now be addressed in 0.2.5


Programmatically trigger a drag start?

Is it possible to make a draggable component start following the mouse on, say, a button click? I'm imagining that a click, which would obviously contain a mouseup event, would be how the item got placed in this case.

This isn't possible, even in v1.0.0 with <DraggableCore> because the event will cancel on mouseUp. You may want to fork to do this - I don't consider this within the scope of Draggable. A simple component that basically tracks mouse movement and sets an absolute position would do the trick.

What's the status on this now?

Was there something unclear about the resolution?

It is such a simple thing to do:
http://jsfiddle.net/maCmB/1/


Nanosleep

To close #55

Thanks Roman for these helpful comments! I still have a few questions, unfortunately.

Which previously implemented syscall is closest to nanosleep, to use as an example?
What is the difference between Alloc trait and PassthroughAlloc trait? Why use Alloc for nanosleep?
Does the use of Alloc mean this syscall is proxied out to host, i.e. is the data from timespec params copied to untrusted memory block, with the syscall called on the host side?
Is there a way to tell generally which syscalls should be proxied vs. handled internally?
What kinds of checks should be done on data returned from untrusted memory? For nanosleep, provided that it does need to be proxied to the host, I would imagine that a basic check would be to ensure that *rem is less than *req, since the latter is a remainder of the former. However, since some of the implemented syscalls call out to untrusted C, is bounds checking necessary here? For example, here, I see that you're calling out to libc::SYS_clock_gettime. However, I'm not sure whether all or part of that syscall is executed in untrusted memory; does clock_gettime return to C code inside the Keep? I also see that you're using unsafe here, so presumably I may want to employ bounds checking on the syscall return values even if untrusted C code is returning to Rust code running in the Keep?

Sorry I have so many questions!

Sorry I have so many questions!

No problem, the documentation for this crate is severely lacking and it's great to see that you managed to go ahead and start with this!

* Which previously implemented syscall is closest to nanosleep, to use as an example?

Perhaps https://github.com/enarx/sallyport/blob/ad77fa18478a7322a3eb3ed845ee4817735d7786/src/v0.3/src/guest/call/syscall/clock_gettime.rs#L10-L40

* What is the difference between the `Alloc` trait and the `PassthroughAlloc` trait? Why use `Alloc` for nanosleep?

Alloc is the most generic trait, which is used for syscalls, which take pointer arguments - the data pointed to by these arguments should be copied into the block and an offset referring to the start of that copied region into the block should be passed to the host from the guest (because we cannot expose the guest memory to the host).
The host then computes a pointer from that offset, that's what deref* utilities are for
PassthroughAlloc is a specialized trait for syscalls that do not require this copying process and just pass arguments through directly

* Does the use of `Alloc` mean this syscall is proxied out to host, i.e. is the data from `timespec` params copied to untrusted memory block, with the syscall called on the host side?

Everything implementing *Alloc traits is allocated into the block and passed to the host

* Is there a way to tell generally which syscalls should be proxied vs. handled internally?

Most of syscalls should be proxied, unless the guest can handle it directly or if we provide a stub. Most of the syscalls that are not proxied are stubs. Memory-related syscalls are an example of syscalls handled directly within the guest (because we cannot expose the guest memory to the host anyway)

* What kinds of checks should be done on data returned from untrusted memory? For nanosleep, provided that it does need to be proxied to the host, I would imagine that a basic check would be to ensure that `*rem` is less than `*req`, since the former is a remainder of the latter. However, since some of the implemented syscalls call out to untrusted C, is bounds checking necessary here? For example, [here](https://github.com/enarx/sallyport/blob/ad77fa18478a7322a3eb3ed845ee4817735d7786/src/v0.3/src/guest/call/syscall/clock_gettime.rs#L16), I see that you're calling out to `libc::SYS_clock_gettime`. However, I'm not sure whether all or part of that syscall is executed in untrusted memory; does `clock_gettime` return to C code inside the Keep? I also see that you're using `unsafe` here, so presumably I may want to employ bounds checking on the syscall return values even if untrusted C code is returning to Rust code running in the Keep?

Since the data is static-size I don't think we really need to validate anything apart from the fact that rem is less than original req (great catch, by the way)
We generally cannot use libc functionality in this crate, since we essentially are providing a custom libc here. The reference you see is actually an imported constant, we do want to use those.

@greyspectrum It looks like this needs to be rebased.

@rvolosatovs Why are there two timespecs [here], inside Output<>, since there is only one timespec in the clock_gettime buffer? (https://github.com/enarx/sallyport/blob/6f0925ae3af419aa4cecfb17fdb8bb3a12a3f591/src/guest/call/syscall/clock_gettime.rs#L21)? Is one the value of the timespec and the other a pointer to the timespec?

@rvolosatovs Why are there two timespecs here, inside Output<>, since there is only one timespec in the clock_gettime buffer?

One is the the type of the reference/the type allocated in the block and the other is the type of the associated value, to which the data is going to be copied from the block

This still needs a test. Any chance I can break that out into a separate PR?

@greyspectrum how about we do something like this:
Added some missing parts and a simple test, fixed the syscall number and rem argument typing:
diff --git a/src/guest/call/syscall/nanosleep.rs b/src/guest/call/syscall/nanosleep.rs
index 3f40b93e..2af574b8 100644
--- a/src/guest/call/syscall/nanosleep.rs
+++ b/src/guest/call/syscall/nanosleep.rs
@@ -3,22 +3,22 @@
 use super::super::types::Argv;
 use super::Alloc;
 use crate::guest::alloc::{Allocator, Collect, Collector, Commit, Committer, InOut, Input, Output};
-use crate::Result;
+use crate::{Result, NULL};

 use libc::{c_long, timespec};

 pub struct Nanosleep<'a> {
     pub req: &'a timespec,
-    pub rem: &'a mut timespec,
+    pub rem: Option<&'a mut timespec>,
 }

 pub struct StagedNanosleep<'a> {
     req: Input<'a, timespec, &'a timespec>,
-    rem: InOut<'a, timespec, &'a mut timespec>,
+    rem: Option<InOut<'a, timespec, &'a mut timespec>>,
 }

 impl<'a> Commit for StagedNanosleep<'a> {
-    type Item = Output<'a, timespec, &'a mut timespec>;
+    type Item = Option<Output<'a, timespec, &'a mut timespec>>;

     fn commit(self, com: &impl Committer) -> Self::Item {
         self.req.commit(com);
@@ -27,23 +27,25 @@ impl<'a> Commit for StagedNanosleep<'a> {
 }

 unsafe impl<'a> Alloc<'a> for Nanosleep<'a> {
-    const NUM: c_long = libc::SYS_clock_nanosleep;
+    const NUM: c_long = libc::SYS_nanosleep;

     type Argv = Argv<2>;
     type Ret = ();

     type Staged = StagedNanosleep<'a>;
-    type Committed = Output<'a, timespec, &'a mut timespec>;
+    type Committed = Option<Output<'a, timespec, &'a mut timespec>>;
     type Collected = Result<()>;

     fn stage(self, alloc: &mut impl Allocator) -> Result<(Self::Argv, Self::Staged)> {
         let req = Input::stage(alloc, self.req)?;
-        let rem = InOut::stage(alloc, self.rem)?;
-
-        Ok((
-            Argv([req.offset(), rem.offset()]),
-            Self::Staged { req, rem },
-        ))
+        let (rem, rem_offset) = if let Some(rem) = self.rem {
+            let rem = InOut::stage(alloc, rem)?;
+            let rem_offset = rem.offset();
+            (Some(rem), rem_offset)
+        } else {
+            (None, NULL)
+        };
+        Ok((Argv([req.offset(), rem_offset]), Self::Staged { req, rem }))
     }

     fn collect(
diff --git a/src/guest/handler.rs b/src/guest/handler.rs
index aa204203..565e1303 100644
--- a/src/guest/handler.rs
+++ b/src/guest/handler.rs
@@ -318,7 +318,7 @@ pub trait Handler: Platform {
     fn munmap(&mut self, addr: NonNull<c_void>, length: size_t) -> Result<()>;

     /// Executes [`nanosleep`](https://man7.org/linux/man-pages/man2/nanosleep.2.html) syscall akin to [`libc::nanosleep`].
-    fn nanosleep(&mut self, req: &timespec, rem: &mut timespec) -> Result<()> {
+    fn nanosleep(&mut self, req: &timespec, rem: Option<&mut timespec>) -> Result<()> {
         self.execute(syscall::Nanosleep { req, rem })?
     }

@@ -661,6 +661,15 @@ pub trait Handler: Platform {
                 let addr = NonNull::new(addr as _).ok_or(EFAULT)?;
                 self.munmap(addr, length).map(|_| [0, 0])
             }
+            (libc::SYS_nanosleep, [req, rem, ..]) => {
+                let req = self.validate(req)?;
+                let rem = if rem == 0 {
+                    None
+                } else {
+                    self.validate_mut(rem).map(Some)?
+                };
+                self.nanosleep(req, rem).map(|_| [0, 0])
+            }
             (libc::SYS_poll, [fds, nfds, timeout, ..]) => {
                 let fds = self.validate_slice_mut(fds, nfds)?;
                 self.poll(fds, timeout as _).map(|ret| [ret as _, 0])
diff --git a/src/host/syscall.rs b/src/host/syscall.rs
index a145b2a1..a4acc5dd 100644
--- a/src/host/syscall.rs
+++ b/src/host/syscall.rs
@@ -426,11 +426,15 @@ pub(super) unsafe fn execute(call: &mut item::Syscall, data: &mut [u8]) -> Resul

         item::Syscall {
             num,
-            argv: [req, rem_offset, ..],
+            argv: [req_offset, rem_offset, ..],
             ret: [ret, ..],
         } if *num == libc::SYS_nanosleep as _ => {
-            let rem = deref_aligned::<timespec>(data, *rem_offset, 1)?;
-            let req = deref_aligned::<timespec>(data, *req, 1)?;
+            let req = deref_aligned::<timespec>(data, *req_offset, 1)?;
+            let rem = if *rem_offset == NULL {
+                null_mut()
+            } else {
+                deref_aligned::<timespec>(data, *rem_offset, 1)?
+            };
             Syscall {
                 num: libc::SYS_nanosleep,
                 argv: [req as _, rem as _],
diff --git a/tests/integration_tests/syscall.rs b/tests/integration_tests/syscall.rs
index 691a9644..07a879de 100644
--- a/tests/integration_tests/syscall.rs
+++ b/tests/integration_tests/syscall.rs
@@ -3,11 +3,12 @@
 use super::{run_test, write_tcp};

 use libc::{
-    c_int, iovec, sockaddr, SYS_accept, SYS_accept4, SYS_bind, SYS_close, SYS_fcntl, SYS_fstat,
-    SYS_getrandom, SYS_getsockname, SYS_listen, SYS_read, SYS_readv, SYS_recvfrom, SYS_setsockopt,
-    SYS_socket, SYS_write, SYS_writev, AF_INET, EBADF, EBADFD, ENOSYS, F_GETFD, F_GETFL, F_SETFD,
-    F_SETFL, GRND_RANDOM, O_CREAT, O_RDONLY, O_RDWR, SOCK_CLOEXEC, SOCK_STREAM, SOL_SOCKET,
-    SO_REUSEADDR, STDERR_FILENO, STDIN_FILENO, STDOUT_FILENO,
+    c_int, iovec, sockaddr, timespec, SYS_accept, SYS_accept4, SYS_bind, SYS_close, SYS_fcntl,
+    SYS_fstat, SYS_getrandom, SYS_getsockname, SYS_listen, SYS_nanosleep, SYS_read, SYS_readv,
+    SYS_recvfrom, SYS_setsockopt, SYS_socket, SYS_write, SYS_writev, AF_INET, EBADF, EBADFD,
+    ENOSYS, F_GETFD, F_GETFL, F_SETFD, F_SETFL, GRND_RANDOM, O_CREAT, O_RDONLY, O_RDWR,
+    SOCK_CLOEXEC, SOCK_STREAM, SOL_SOCKET, SO_REUSEADDR, STDERR_FILENO, STDIN_FILENO,
+    STDOUT_FILENO,
 };
 use std::env::temp_dir;
 use std::ffi::CString;
@@ -16,6 +17,7 @@ use std::io::{Read, Seek, Write};
 use std::mem::size_of;
 use std::net::{TcpListener, UdpSocket};
 use std::os::unix::prelude::AsRawFd;
+use std::ptr::null_mut;
 use std::slice;
 use std::{mem, thread};

@@ -225,6 +227,79 @@ fn getrandom() {
     });
 }

+#[test]
+#[serial]
+fn nanosleep() {
+    run_test(2, [0xff; 32], move |i, handler| {
+        let req = timespec {
+            tv_sec: 0,
+            tv_nsec: 1,
+        };
+        if i % 2 == 0 {
+            assert_eq!(
+                handler.nanosleep(&req, None),
+                if cfg!(not(miri)) { Ok(()) } else { Err(ENOSYS) }
+            );
+        } else {
+            assert_eq!(
+                unsafe {
+                    handler.syscall([
+                        SYS_nanosleep as _,
+                        &req as *const _ as _,
+                        null_mut() as *mut timespec as _,
+                        0,
+                        0,
+                        0,
+                        0,
+                    ])
+                },
+                if cfg!(not(miri)) {
+                    Ok([0, 0])
+                } else {
+                    Err(ENOSYS)
+                }
+            );
+        }
+
+        let mut rem = timespec {
+            tv_sec: 0,
+            tv_nsec: 0,
+        };
+        if i % 2 == 0 {
+            assert_eq!(
+                handler.nanosleep(&req, Some(&mut rem)),
+                if cfg!(not(miri)) { Ok(()) } else { Err(ENOSYS) }
+            );
+        } else {
+            assert_eq!(
+                unsafe {
+                    handler.syscall([
+                        SYS_nanosleep as _,
+                        &req as *const _ as _,
+                        &mut rem as *mut _ as _,
+                        0,
+                        0,
+                        0,
+                        0,
+                    ])
+                },
+                if cfg!(not(miri)) {
+                    Ok([0, 0])
+                } else {
+                    Err(ENOSYS)
+                }
+            );
+        }
+        assert_eq!(
+            rem,
+            timespec {
+                tv_sec: 0,
+                tv_nsec: 0,
+            }
+        )
+    });
+}
+
 #[test]
 #[serial]
 #[cfg_attr(miri, ignore)]

@rvolosatovs Thanks for your help on this PR. I applied applied your patch, mind taking one last look at this?

We should also document the syscall struct at least (especially due to "unusual" rem argument handling) or leave that for #32

We should also document the syscall struct (especially due to "unusual" rem argument handling) or leave that for #32

Could you give me a more specific idea of what kind of documentation you would like? Would you like an explanation of what the arguments do (as in from the man page) or something else?

We should also document the syscall struct (especially due to "unusual" rem argument handling) or leave that for #32

Could you give me a more specific idea of what kind of documentation you would like? Would you like an explanation of what the arguments do (as in from the man page) or something else?

I was thinking we should document that unlike most other syscall arguments, rem argument is written only on a specific error case, rather than a success. Can be left for #32


Running only xray installation, fails to access to the server

Which installer:
Ansible, posgres and xray role ONLY
playbook:
collections:
- jfrog.platform
roles:
- postgres
- xray
Which product and version (eg: ansible & collection version - 1.1.2):
Ansible 2.9.6
XRAY latest (following base galaxy collection)
Which operating system and version(eg: ubuntu & version - 20.4):
Ubuntu 20.4
What happened:
In the docs: The xray role will install Xray software onto the host. An Artifactory server and Postgress database is required.
But i have already a server dedicated to artifactory.
so i defined the variable
jfrog_url: https://myartifactory
I run a playbook to install only posgress and xray. Ansible installation works, but i cant access to xray portal, by example.
http://myservername -> nothing
http://myservername:8000 -> nothing
netstat -tunlp
(nothing running on port 8000, 80,)
server running:
● xray.service - JFrog Xray service
Loaded: loaded (/lib/systemd/system/xray.service; enabled; vendor preset: enabled)
Active: active (running) since Wed 2021-05-12 21:13:37 GMT; 44s ago
Process: 416158 ExecStart=/opt/jfrog/xray/app/bin/xrayManage.sh start (code=exited, status=0/SUCCESS)
Main PID: 418184 (jf-server)
Tasks: 0 (limit: 7031)
Memory: 1.0M
CGroup: /system.slice/xray.service
‣ 418184 /opt/jfrog/xray/app/server/bin/jf-server
May 12 21:13:12 TisXRYx21 systemd[1]: Starting JFrog Xray service...
May 12 21:13:12 TisXRYx21 xrayManage.sh[416158]: Resolved .shared.user (xray) from /opt/jfrog/xray/var/etc/system.yaml
May 12 21:13:12 TisXRYx21 xrayManage.sh[416158]: Resolved .shared.group (xray) from /opt/jfrog/xray/var/etc/system.yaml
May 12 21:13:12 TisXRYx21 su[416308]: (to xray) root on none
May 12 21:13:12 TisXRYx21 su[416308]: pam_unix(su:session): session opened for user xray by (uid=0)
May 12 21:13:37 TisXRYx21 systemd[1]: Started JFrog Xray service.
install.log -> no errors
console.log ->
2021-05-12T21:13:39.119Z [jfrou] [FATAL] [15f760333f212368] [bootstrap.go:105              ] [main                ] - Could not join access, err: cluster join: Failed joining the cluster; Error: Error response from service registry, status code: 404; message: HTTP 404 Not Found
...
2021-05-12T21:15:36.246Z [jfxr ] [INFO ] [                ] [access_client_bootstrap:167   ] [main                ] (--wrapper--)Cluster join: Retry 120: Service registry ping failed, will retry. Error: Error while trying to connect to local router at address 'http://localhost:8046/access': Get "http://localhost:8046/access/api/v1/system/ping": dial tcp <IP_ADDRESS>:8046: connect: connection refused
root@TisXRYx21:/opt/jfrog/xray/var/log#
systendiagnostics.log -> all good here, only DEBUG lines
What you expected to happen:
To be able to access to xray server
Anything else we need to know:

Probably my question should be, if this collection is only for JFrog Platform, not standolone products?

@andrescolodrero  it should work , Can you check what joinKey did you pass to connect in Xray role?

HI,
i double check master.key and join.key, and still cant make it work, not even XRAY ui.
could be this installation not compatible with Artifactorty 6.12 ?
2021-05-14T14:09:53.628Z [jfxr ] [ERROR] [82eb82c67bce979d] [ha_service:116                ] [main                ] Failed to register node: Failed to register node, master keys do not match
2021-05-14T14:09:53.628Z [jfxr ] [ERROR] [82eb82c67bce979d] [general_utils:23              ] [main                ] Critical error: exiting from Xray Program, reason: Failed to register node: Failed to register node, master keys do not match
i double checkd that master.key is the same on artifactory server and xray.
systemdiagnostics.log
shared.database.password: already encrypted
shared.newrelic.licenseKey: does not exist in the config file
shared.rabbitMq.password: already encrypted
shared.security.joinKey: already encrypted
shared.security.joinKeyFile: file '/opt/jfrog/xray/var/etc/security/join.key' - open /opt/jfrog/xray/var/etc/security/join.key: no such file or directory
2021-05-14T14:

@andrescolodrero

HI,
i double check master.key and join.key, and still cant make it work, not even XRAY ui.
could be this installation not compatible with Artifactorty 6.12 ?
2021-05-14T14:09:53.628Z [jfxr ] [ERROR] [82eb82c67bce979d] [ha_service:116 ] [main ] Failed to register node: Failed to register node, master keys do not match
2021-05-14T14:09:53.628Z [jfxr ] [ERROR] [82eb82c67bce979d] [general_utils:23 ] [main ] Critical error: exiting from Xray Program, reason: Failed to register node: Failed to register node, master keys do not match
i double checkd that master.key is the same on artifactory server and xray.
systemdiagnostics.log
shared.database.password: already encrypted
shared.newrelic.licenseKey: does not exist in the config file
shared.rabbitMq.password: already encrypted
shared.security.joinKey: already encrypted
shared.security.joinKeyFile: file '/opt/jfrog/xray/var/etc/security/join.key' - open /opt/jfrog/xray/var/etc/security/join.key: no such file or directory
2021-05-14T14:

could be this installation not compatible with Artifactorty 6.12 ?

Yes, Min requirement is Artifactory 7.17.4 and above


Improve tests code

[x] There is a lot of code repetition mainly involving this block:reader_driver.load_random()
assert controller.sidebar.loaded
if controller.sidebar.hidden:
    controller.sidebar.toggle()
assert controller.sidebar.hidden is False

It could be turned into a decorator to make it better looking.
[ ] The load_random function needs to be improved (as discussed here).

first part handled a while ago.
Second point is still to be checked.


Resource management layers

Currently, per-stub (or spy) and per-module layers of resource management coexist, which may be confusing or inconvenient.

Solved by #9 effectively


Security policy

I think we should make a security policy for the main repositories (most importantly server). Right now GitHub just returns the whole security.py file as the security policy, which I honeslty find kinda funny.

lol.

what you could do is move security.py, and stuff like that into  a new dir called src\
then create file called security with ur policy in it

what you could do is move security.py, and stuff like that into a new dir called src\
then create file called security with ur policy in it

Oh we can set which file can be our security policy, we just need to make a security policy.

I can write one if you want

I can write one if you want

Sure, that would be appreciated

Fixed with https://github.com/meower-media-co/Meower-Server/commit/b2cbcc48322fcb5538e6f6503a0f8674c016dfea, closing.

hehe oops i forgor


loadlibrary now is () => dynamic instead of () => Future<dynamic>

import 'package:intl/intl.dart';
import 'package:intl/message_lookup_by_library.dart';

import 'en_short_messages.dart' deferred as en_short;
import 'es_messages.dart' deferred as es;
import 'es_short_messages.dart' deferred as es_short;
import 'fr_messages.dart' deferred as fr;
import 'ja_messages.dart' deferred as ja;
import 'zh_CN_messages.dart' deferred as zh_cn;
import 'zh_messages.dart' deferred as zh;

//typedef Future<dynamic> LoadLibrary();
typedef dynamic LoadLibrary();

Map<String, LoadLibrary> _deferredLibraries = {
  'en_short': en_short.loadLibrary,
  'es': es.loadLibrary,
  'es_short': es_short.loadLibrary,
  'fr': fr.loadLibrary,
  'ja': ja.loadLibrary,
  'zh_CN': zh_cn.loadLibrary,
  'zh': zh.loadLibrary
};

[        ] compiler message: file:///Users/zoechi/dart/customers/lookatyou/lookatmybaby/timeago.dart/lib/src/i18/messages_all.dart:21:12: Error: The top level function has type '() → dynamic' that isn't of expected type '() → dart.async::Future<dynamic>'.
[        ] compiler message: Change the type of the function or the context in which it is used.
[        ] compiler message:   'es': es.loadLibrary,

Flutter 0.2.2-pre.4 • channel dev • https://github.com/flutter/flutter.git
Framework • revision ce75b44760 (4 hours ago) • 2018-03-20 07:48:43 +0100
Engine • revision e61bb9ac3a
Tools • Dart 2.0.0-dev.35.flutter-290c576264

Is this intentional or a bug?

It's unlikely to be intentional at the language level.
The Dart 1 spec says:

loadLibrary. This method returns a future f.

It does not say what the static type of loadLibrary is or what the static type of the invocation is.
However, since it does say that the method returns a Future, it is reasonable to assume that it is typed as such. I'd say that this is a bug, and the static and dynamic type of the loadLibrary method should be Future<void> Function() (or Future<dynamic> if the void is too breaking).

I'm not sure when exactly that behavior changed.
I switched to --preview-dart-2 a week ago or so, and it didn't cause an issue until today, but it was not flutter upgrade that caused it, but flutter clean.
So it might be that I had got this error a week ago already if I had run flutter clean back then.
(I run flutter clean today because some code changes didn't reflect in the running app)

I'm not seeing an issue with that in bleeding edge running the Intl code standalone. It's possible that it's already been fixed, or that there's something different happening with Flutter.

Flutter dev channel is on Dart 2.0.0-dev.35, the most current Dart dev version is 2.0.0-dev.40.
I'll check again with master channel and update with my findings.

@alan-knight thanks. Todays Flutter dev update ships with Dart 2.0.0-dev.39.0.flutter-06949dc985 and doesn't reproduce anymore.

It's still the same with
Flutter 0.2.2-pre.5 • channel dev • https://github.com/flutter/flutter.git
Framework • revision 0608a7a2cc (2 hours ago) • 2018-03-23 11:10:37 +0100
Engine • revision 6280adbfb1
Tools • Dart 2.0.0-dev.39.0.flutter-06949dc985

It's still the same with
Flutter 0.2.2-pre.6 • channel dev • https://github.com/flutter/flutter.git
Framework • revision 972ff23c4c (19 hours ago) • 2018-03-30 18:15:04 +0200
Engine • revision 9af82c5a1a
Tools • Dart 2.0.0-dev.43.0.flutter-e305117519

but I get these errors only once after flutter clean

OK, we dug a little deeper and think we know the issue.

Just send a possible fix to the FE team here: https://dart-review.googlesource.com/c/sdk/+/49042

This error is now gone with
Flutter 0.2.12-pre.34 • channel master • https://github.com/flutter/flutter.git
Framework • revision 6c049ec286 (12 hours ago) • 2018-04-15 19:24:49 -0700
Engine • revision 76cb311d9c
Tools • Dart 2.0.0-dev.47.0.flutter-f76dad0adc

Thanks!


adding pthread barrier to android

r? @m-ou-se
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 5436f98e408e22aec080ec2c3acef3332475c281 has been approved by JohnTitor

:hourglass: Testing commit 5436f98e408e22aec080ec2c3acef3332475c281 with merge 3c2d4c6b974f6725139aef4d453421addfd8ee76...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 3c2d4c6b974f6725139aef4d453421addfd8ee76 to master...


Foundation should only use nested import

The catchall index of foundation comes up too often when automatically resolving imports. Also, it prevents future modularization (easily publishing to different packages, tree shaking optimizations in bundlers, etc). We should clean up the code to always import e.g.
import { EthAddress } from "@aztec/foundation/eth_address";

Done by Orloaft in #449


MoneyParser::parse $forceCurrency parameter

If I'm parsing money using interface without knowing its actual implementation, there's a risk that this implementation would be, for example, DecimalMoneyParser, which require second parameter to be defined (or otherwise it just throws an exception).
On the other hand, if I pass that second parameter to other implementations, which actually get currency from parsed string, it overrides that currency. I'm finding this highly illogical.
Is there a sense to change that second parameter to $fallbackCurrency? Then it will not override parsed currency (if it is actually parsed).

@sagikazarmark I think this is a fair remark. When $forceCurrency is passed, it should be forced. Would you agree on this?


Top-level map no longer being rendered in vector mode

Nils suspects it's related to some filtering code. Will investigate.

Fix has been merged into dev-branch


Upgrade to latest Mesos

Update Scale to use the latest stable version of Mesos.
This should remove our need to do an explicit Docker pull in the pre-task. Test this!
Update the node.slave_id column to agent_id to reflect the new name in Mesos.
Check for updated Python bindings/stubs and see if we can remove the protobuf dependency.

Protobuf binding has been removed and newest version of Mesos is now supported using v1 Scheduler API. This was completed in #1383.


Bump Dependencies #10728345533

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/10728345533

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


pls

@MihaiValentinGeorgescu Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

DOn't use a public repository for your practice, use your own repository and fork(s) for that! Please remove this PR.

I am sorry, I am still learning, i wil remove this pr now


New User: AddThis

Name: AddThis
Homepage url: www.addthis.com
Brand Guidelines/Licensing: nope
Logo: http://www.addthis.com/style/images/wrapper/addthis-logo.svg

Thanks!


Why do you want to make sure ido-mode is disabled?

Hello:
I noticed some code in the init-ivy.el:
......

  (add-hook 'after-init-hook
            (lambda ()
              (when (bound-and-true-p ido-ubiquitous-mode)
                (ido-ubiquitous-mode -1))
              (when (bound-and-true-p ido-mode)
                (ido-mode -1))
              (ivy-mode 1)))

......

You seem to be sure that ido-mode is disabled.
Why do you want to do that?
I removed these code, and then used for some time, I never saw ido-mode started ...

Yes, that was temporary, when I was switching from ido. I can now remove it from my config.

Thanks


Add static analysis tools - Detekt & ktlint

Danger has errored
[!] Invalid Dangerfile file: undefined local variable or method commit_lint for #<Danger::Dangerfile:0x0000556c8815c260>
 #  from Dangerfile:8
 #  -------------------------------------------
 #
 >  commit_lint.check warn: :all, disable: [:subject_length]
 #
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger

Danger has errored
[!] Invalid Dangerfile file: undefined local variable or method is_pr_wip for #<Danger::Dangerfile:0x0000559e2273f850>
 #  from Dangerfile:5
 #  -------------------------------------------
 #  warn("Branch name should have `release/`, `hotfix/`, `fix/`, `housekeep/` or `feature/` prefix.") if !has_correct_prefix
 >  warn("Pull request is classed as Work in Progress") if is_pr_wip
 #  warn("This pull request is too big.") if is_pr_big
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger


Make shuffle and repeat buttons indicate state

The shuffle and repeat buttons should visually indicate their current state.

Addressed by #45


Change the dialog size

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[] iOS
[X] Android
[] UWP
[] PCL

Version of OS(s) listed above with issue
Version of ACR UserDialogs Library
6.3.3
Expected Behaviour
The dialog with a fixed size.
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
I need to download some grouped items. My dialog is showing like this:
==================
SPINNER
Getting Items...
3 of 1388
========================
SPINNER
Getting Inventory Group Items...
100 of 970
I have a lot of different groups and the dialog keeps dancing on the screen. My client complained to me about this.
My question is: it is possible to fix the dialog size? I tried to insert blank space at the beginning and at the end of title but seems the dialog trims the string.
Thank you very much.
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

This isn't something I would plan to do.  The progress dialog simply wasn't meant to be a huge control and it truncates intentionally to prevent this.  You are welcome to submit a PR if you would like to see this implemented in some fashion.


Search song lyrics on cli

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the contributors guide.
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered and confirmed that this submission will be valuable to others.
[x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[x] I give this submission freely and claim no ownership to its content.

My familiarity with the project is as follows (check one):

[ ] I have never used the project.
[x] I have used the project briefly.
[ ] I have used the project extensively, but have not contributed previously.
[ ] I am an active contributor to the project.

{pull request content here}
One can search the song on CLI by giving arguments like this - swaglyrics -c --song "Perfect" --artist "Ed Sheeran"

Hello @GermaVinsmoke! Thanks for opening this PR.

In the file swaglyrics/__main__.py:

Line 13:9: E117 over-indented (comment)
Line 14:9: E117 over-indented (comment)
Line 15:9: E117 over-indented (comment)
Line 16:9: E117 over-indented (comment)
Line 17:9: E117 over-indented (comment)
Line 18:9: E117 over-indented (comment)
Line 19:9: E117 over-indented (comment)
Line 20:9: E117 over-indented (comment)
Line 21:9: E117 over-indented
Line 78:9: E117 over-indented

Do see the Hitchhiker's guide to code style


Handle workflows without inbox elements in JobArchiver

I noticed there was a workflow in testbed not moving from aborted to aborted-completed and the reason is taht JobArchiver was failing to check the WMBS injection status (there was no inbox element for that request(?)).
In case the inbox element is gone, then we set this workflow as injected in the agent and get it out of the system.
@ticoann please review

@ticoann please review and merge before cutting the 1.0.21 tag


IP Address parse error on client requests

Hi !
After an update via nuget, every time a client post data calling my Web Api the error described below occurs:
in Systin.Net.IPAddress.InternalParse(String ipString, Boolean tryParse)
in WebApiThrottle.IPAddressRange..ctor(String ipRangeString)
in WebApiThrottle.Net.IpAddressUtil.ContainsIp(List`1 ipRules, String clientIp)
in WebApiThrottle.ThrottlingCore.IsWhitelisted(RequestIdentity requestIdentity)
in WebApiThrottle.ThrottlingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
in Systin.Net.Http.DelegatingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
in TravelHub.Base.Loggers.Monitoramento.InspetorRest.d__33.MoveNext()---
Fim do rastreamento de pilha do local anterior onde a exceção foi gerada ---
in Systin.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
in Systin.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
in TravelHub.Base.Servicos.Web.Api.Handlers.EncodingDelegateHandler.d__6.MoveNext()--
Fim do rastreamento de pilha do local anterior onde a exceção foi gerada ---
in Systin.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
in Systin.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
in Systin.Web.Http.Owin.PassiveAuthenticationMessageHandler.d__0.MoveNext()---
Fim do rastreamento de pilha do local anterior onde a exceção foi gerada ---
in Systin.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
in Systin.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
in Systin.Web.Http.HttpServer.d__0.MoveNext()
@stefanprodan: Can you help us, please ?  Are there another issue like this ?
Tks,
Juliano Cardarelli

Can you please remove the whitelisted IPs and test if it's working?

Hi Prodan !
Removing the whitelist we have no problem and there is no error when a client post any data to the web api. But, we need to use the whitelist to a specific IP client.
In a local environment (not in Azure), there is no error while we are using the whitelist. But, the error occurs when the api is deployed to the azure.
Always is the same stack trace.
Best regards,
Juliano Cardarelli

De: Stefan Prodan<EMAIL_ADDRESS>Enviado: quarta-feira, 16 de novembro de 2016 14:06
Para: stefanprodan/WebApiThrottle
Cc: Juliano Cardarelli; Author
Assunto: Re: [stefanprodan/WebApiThrottle] IP Address parse error on client requests (#78)
Can you please remove the whitelisted IPs and test if it's working?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/stefanprodan/WebApiThrottle/issues/78#issuecomment-260987006, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWaX-TKayaUarLLoD9S-nnoDT-XJb9Gdks5q-yoigaJpZM4Kz06Z.


Support for bucket-types and datatypes

Currently rekon only shows buckets from the default bucket-type, it would be great to have support for Riak 2.0. However I'm not sure if there's a way to list active bucket types.

@LnL7 - That's the problem, unfortunately. There's currently no public API to list active bucket types.
We're working on a prototype tool to replace Rekon, that will address this issue.

I was thinking that the install script could use riak-admin to generate a list of active bucket types.

it can be "manual" for now by url
buckets/rekon/keys/go#/types/animals - lists all buckets inside animals type
buckets/rekon/keys/go#/types/animals/buckets/cats list key in cats bucket in animals type


all: reduce init-time CPU & memory usage

Tracking bug to reduce init-time CPU & memory usage.

See also my last comment in #2559 about using go generate for some of this.

 That'll happen soon enough.

 GODEBUG=inittrace=1 is a better way to see. See the CL above, which shows those numbers.


Leave out object fields that have a null value

When converting from an object to JSON, if a field is an Option type, then I want to leave that field out of the JSON. The reason is to save space and thereby reduce IO because I'm saving JSON to the DB.
I can understand that you typically want to include the field with a null value, so a setting to optionally leave out null fields would be great.

You can do this with a custom dump hook.
Take a look at: https://github.com/treeform/jsony/blob/master/tests/test_quirkydump.nim#L29-L57
The https://github.com/treeform/jsony/blob/master/tests/test_quirkydump.nim#L29-L57 checks if there is an option then leaves out they key and the value.
You can also use this to compress default values like 0 or "". But again custom dump hook is required.
Does this answer your question?

I need the same, and am doing it like that, but one has to override all dumpHooks that deal with any kind of container (object, ref object, array, seq, table, ...).
I do think it should be a default option of jsony, as it is a lot of work/code, for a feature that I think will commonly be requested. It makes senes ot save space like in @jfilby's case, or like in mine, where I want to dump a config file, which should only contain the values that are actually set, to not clutter the file.


Slo absence workaround

Using djangosaml2 with a Saml 2 Saml proxy like SATOSA I found an exception about the absence of SLO in the proxy features.
With this patch I can manage the exception raised by a faulty or absent SLO response.
I needed this to handle different IDP, some with SLO and some Not.
I made a single branch as usual, to make this feature very easy to be read as possible.

Thank you @sheilatron, would you like ti do a PR on my branch? I Will test It and on merge It Will be available also here

Thank you for your revisions.
This patch solves problems coming from faulty idp's SLO implementations.
I need to use this with SATOSA wich do not have yet a SLO implementation.
Hope to see this merged soon @knaperek, with this commit my pplnx-dev branch and your master branch will be the same and I would use this latter in my project dependencies.

@knaperek @OskarPersson could it be usefull for the next release?

Still missing feedback from a long time, would there be the possibility to handle this?


Invalid DOM

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When trying to use paragraph, as in the below.
const blockRenderMap = Immutable.Map({
  'paragraph': {
    element: 'p',
  },
  'unstyled': {
    element: 'p',
  }
})

An invalid DOM is generated:

            asdf

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.
Check the output below what you are typing and notice the div nested inside the p tag.
https://jsfiddle.net/fedan2nv/25/
What is the expected behavior?
The P tag should only contain phrasing content. A div element is invalid.
http://w3c.github.io/html/single-page.html#phrasing-content
http://w3c.github.io/html/single-page.html#the-p-element
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
Draft.js 0.10.5
I can't tell you if it worked in previous versions as I just started looking into Draft.JS
Windows 10, MacOS 10.13.3 All Browsers
See the render method at:
https://github.com/facebook/draft-js/blob/e9540910e0e0168e5fdb3ce5b9e42168b301bd91/src/component/contents/DraftEditorBlock.react.js#L228
Also see #395

This still seems to be an issue, are there any plans to work on this?

I have the same bug in 0.11.5.

still an issue. Can those divs be changed to spans by default?

@sahilpurav Most likely, there will be no more releases.
https://github.com/facebook/draft-js#status


Merge Dev ke UAT 7 Feb 2017

Coverage decreased (-2.1%) to 61.74% when pulling b723d73a0c7ebf4998513fc2d3d214af7e14b4d4 on dev into d30c9b89b80a42dfb3ecf151e58020f2350f59dd on uat.


Documentation: Small spelling mistake in Domain Models

Small spelling mistake in the documentation of https://cap.cloud.sap/docs/guides/domain-models#about-domain-models in the section Domain Driven Design

Domain modelling as a service — Domain models ar only a means to an end: ...

Admittedly not world changing, but caught my eye..

Thanks for reporting this. We will fix this today :).

Issues was fixed weeks ago, see https://cap.cloud.sap/docs/guides/domain-models#keep-them-simple. Issue can be closed @gregorwolf.


Promises.join followed by reject() doesn't reject all subsequent promises

Observed on macOS 10.12/Sierra using Pony release 0.22.6: if I use Promises.join() to join a collection of P promises and then reject one of the promises in P, then the rejection doesn't propagate to all of the remaining promises.
A reproducing unit test case can be found at https://gist.github.com/slfritchie/a7833aca6ab95b35e09b5b045bfff749

Oops, sorry, the test in that gist is bad.  I'm creating a hopefully-correct one now.....

OK, sorry, I've updated the gist in the initial comment and deleted the gist with the incorrect test case.
I've left a comment that includes a 2 step .next() cascade that's similar to an earlier unit test.  In either instance, the 0-arity lambda for the cancellation action isn't being executed.

Good catch!
I think the issue is that in Promises.join ( https://stdlib.ponylang.org/src/promises/promise/#L280 ) the reject case is not handled at all. It should be propagated through to the _Join actor.

Ja, after drawing a diagram & stepping through everything, I came to the same conclusion.  I've got a 1-liner + new test case to create for a PR, coming soon.

Fixed by #2770.


rework ifd handling and deprecate directly accessing ifds

fixes #44
img.ifds is replaced with ifds(img).

Codecov Report
Patch coverage: 85.71% and project coverage change: -0.06% :warning:

Comparison is base (76b89f9) 90.27% compared to head (c1801d4) 90.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   90.27%   90.22%   -0.06%
==========================================
  Files          13       13
  Lines         761      767       +6
==========================================
+ Hits          687      692       +5
- Misses         74       75       +1

Files Changed
Coverage Δ

src/TiffImages.jl
100.00% <ø> (ø)

src/types/lazy.jl
89.85% <80.00%> (ø)

src/types/common.jl
86.95% <83.33%> (-1.28%)
:arrow_down:

src/types/dense.jl
94.44% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support grpc.reflection.v1alpha.ServerReflection

Hi.
I see you've explicitly removed v1alpha support in #58.
However, many third party tools (e.g. postman, k6) are still using v1alpha reflection. Essentially now anyone who depend on that tools cannot upgrade to SpiceDB v1.26.0.
I suggest to follow https://github.com/grpc/grpc-go approach when you support both server versions for some reasonable amount of time.

Thanks for reporting! I've opened https://github.com/authzed/grpcutil/pull/58 and https://github.com/authzed/spicedb/pull/1718


nit: Fix typos & grammatical errors

Description
This PR aims to fix a few typos, and grammatical errors in:

README.md in the root directory.
README.md for docs dir.

Type of change

[x] Documentation update

Checklist:

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
[x] I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
[x] If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
[x] I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
[x] I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
[x] I have tested with Helgrind in case my code works with threading.
[x] I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

I'm not sure why the Tests are failing, even though I didn't touch any code.
There might be an issue with the Tests. Please let me know, how this can be solved from my side(If possible)


Events being retriggered if more than one plugin uses it.

Hi,
I found this problem while sitting on my IRC channel and I noticed that all the join/leave messages were being sent twice. I looked into it further and noticed the same on my other server, so here's what I have:
http://images.akamai.steamusercontent.com/ugc/538524292207557183/5983A5DA7D285825C3050FCBDEB136F6F5E27A3C/
This image shows that I'm using 3 plugins with the same Event running for different reasons.
When the following code runs:
Declaring the Event:
Rocket.Unturned.Events.RocketPlayerEvents.OnPlayerDeath += RocketPlayerEvents_OnPlayerDeath;
Running the event:
private void RocketPlayerEvents_OnPlayerDeath(Rocket.Unturned.Player.RocketPlayer player, EDeathCause cause, ELimb limb, Steamworks.CSteamID murderer)
{
if (cause.ToString() != "SUICIDE")
//Skipping a lot of useless code
RocketChat.Say(Rocket.Unturned.Player.RocketPlayer.FromCSteamID(murderer), this.Configuration.NormalKillENG + " " + player.CharacterName + ". +" + this.Configuration.NormalKill_LP_Gain + " LP", Color.yellow);
}
So when I kill someone, this is the output:
http://images.akamai.steamusercontent.com/ugc/538524292207552572/15532BC85108D4192BE978B16CDF966A7503CA14/
PS: I'm sorry about the messy report, new to Github, not sure about BBCodes or whatever.

With my IRC plugin, the server sends the join message twice because I have another plugin dealing with telling the server what rank of the person is when they join.

Yep, indeed a bug, fixed in beta408


pass flatpak param to delegated koji task

OSBS-8723

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section:

[ ] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[ ] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request includes link to an osbs-docs PR for user documentation updates
[x] New feature can be disabled from a configuration file

Looks good! Thanks :+1:

rn updated: pass flatpak param to delegated koji task


Functional seek bar? (enhancement)

A functional seek bar for fullscreen.

Yeah, working fullscreen volume bar would be very cool.

Added in v2.0.0. @SupLiCatinG . Finally 😂


Dataset used for checkpoint in the huggingface

Hello! I am now using the CLAP model for my research, and the checkpoints from the huggingface transformers ('laion/clap-htsat-unfused") works best for me.
However, I cannot find exactly which datasets are used for the checkpoint unlike the models linked in this repository.
Can I get exact information about the datasets used for the huggingface pretrained models?

Hi,
I think the unfused and fused models of huggingface transformers come from these two checkpoints of our own:

For general audio less than 10-sec: 630k-audioset-best.pt
For general audio with variable-length: 630k-audioset-fusion-best.pt

They are models we presented in the paper, while other models (such as music, music+speech+...) come from our continuing training after the paper publication.
Best,
Ke


Several driver-based tests failing on engine roll

The engine roll https://github.com/flutter/flutter/pull/108862 contains only a dart roll https://github.com/flutter/engine/pull/35118 with commits https://dart.googlesource.com/sdk.git/+log/a8d90480d8ff..ba75fe6598e3.
Some example failures:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios complex_layout_scroll_perf_ios__timeline_summary/5986/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android complex_layout_scroll_perf__devtools_memory/4124/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10 new_gallery_impeller__transition_perf/273/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10 complex_layout_scroll_perf__timeline_summary/2215/overview

This started with https://github.com/dart-lang/sdk/commit/460bd7a03a2ef87663ad14a28db52d7ad93be8b5
@rmacnak-google

I do not see an original failure in these logs, only the harness timing out. Presumably there is an exception or crash in the target engine process.

The target Flutter app process is not crashing.  But midway through the test script the app process fails to correctly execute a request issued by the harness.  The harness keeps polling the app waiting for the expected response, and eventually it times out.
The Dart SDK commit has been reverted:
https://github.com/dart-lang/sdk/commit/d94a1cd419d8d644516336f9bbeae2e751ecdbf1

The Dart commit has been reverted, please consider lowering the priority to P2, we would still like to figure out the failure.

Yeah, since the roller is moving again, this is no longer a P0.

I think this can be closed.


Project Submission, Borys Babiak and Arsh Bawa

Semi-supervised domain adaptation using diffusion models.

updated md file


Incompatible zstd/zstandard versions

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
/opt/anaconda/envs/mamba/lib/python3.11/site-packages/conda_package_streaming/package_streaming.py:19: UserWarning: zstandard could not be imported. Running without .conda support.
  warnings.warn("zstandard could not be imported. Running without .conda support.")

and
>>> import zstandard
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/anaconda/envs/mamba/lib/python3.11/site-packages/zstandard/__init__.py", line 39, in <module>
    from .backend_c import *  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: zstd C API versions mismatch; Python bindings were not compiled/linked against expected zstd version (10505 returned by the lib, 10502 hardcoded in zstd headers, 10502 hardcoded in the cext)

Installed packages
zstandard                 0.19.0          py311hbe0fcd7_1    conda-forge
zstd                      1.5.5                hfc55251_0    conda-forge

Environment info
active environment : None
            shell level : 0
       user config file : /export/home/orion-admin/.condarc
 populated config files : /etc/conda/condarc.d/nwra.yml
          conda version : 23.7.4
    conda-build version : not installed
         python version : 3.11.6.final.0
       virtual packages : __archspec=1=x86_64
                          __glibc=2.28=0
                          __linux=4.18.0=0
                          __unix=0=0
       base environment : /opt/anaconda/envs/mamba  (read only)
      conda av data dir : /opt/anaconda/envs/mamba/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.cora.nwra.com/main/linux-64
                          https://conda.cora.nwra.com/main/noarch
          package cache : /var/cache/conda/pkgs
                          /export/home/orion-admin/.conda/pkgs
       envs directories : /opt/anaconda/envs
                          /export/home/orion-admin/conda/envs
                          /export/home/orion-admin/.conda/envs
                          /opt/anaconda/envs/mamba/envs
               platform : linux-64
             user-agent : conda/23.7.4 requests/2.31.0 CPython/3.11.6 Linux/4.18.0-477.21.1.el8_8.x86_64 almalinux/8.8 glibc/2.28
                UID:GID : 30657:30657
             netrc file : None
           offline mode : False

This was patched, but for some reason you seem to have gotten two incomaptible versions together. I had the same issue. To fix this,

install micromamba ("${SHELL}" <(curl -L micro.mamba.pm/install.sh))
~/.local/bin/micromamba install zstd=1.5.5 zstandard=0.21.0 -p /opt/anaconda/envs/mamba

Yeah, resetting the versions gets it working again.  So going forward there are restrictions in place to keep them in sync?  Thanks.

I just had this problem after running mamba update mamba with a fresh Mambaforge (23.1.0-1) installation.  The underlying problem seems to be that mamba (somehow, I haven't tracked the dependency path) depends on zstd but not on zstandard.  So that command updates zstd to 1.5.5 but leaves zstandard on the shipped version, 0.19.0; the installation then can't recover itself because installing compatible versions would require a working zstandard.
A newer Miniforge (23.3.1-1) ships with compatible versions of zstd 1.5.5 and zstandard 0.19.0, but still doesn't depend on zstandard so the problem will recur if any future version of zstd is incompatible with whichever version of zstandard ships with Miniforge, and will affect anyone who foolishly trusts the winget version of Mambaforge (which stopped updating after the Mambaforge/Miniforge merger).
I think the solution is to fix conda's dependencies so that zstandard doesn't get left behind; I don't think that's in scope for zstandard-feedstock.

What can we do with the recipe here to avoid recurring issues?
With the current setup, every time a new zstd version is being made available on conda-forge, zstandard would need to be quickly updated.
Otherwise any recipe that depends (directly or transitively) on zstandard but also on builds of other packages that have only been built for the newer zstd version would be broken (e.g., on Bioconda we currently have package builds for python=3.12 built against zstd=1.5.6 (and thus zstd>=1.5.6,<1.6.0a0 dependencies) that are not installable alongside zstandard since its latest version is pinned to zstd=1.5.5).
One "solution" would be to hold up conda-forge's pinning on zstd (i.e., switch from current 1.5 to 1.5.5) until zstandard is updated -- but that is, of course, conceptually not favorable and will also cause other issues (e.g., we'd essentially need to have 1.5.5 builds maintained).
(This would only be a last resort that I don't want us to take; I'm noting it here only in case someone else brings it up.)

I haven't looked into zstandard's upstream and recipe sources at all, so can't make suggestions but only defer questions:

Do we have sufficient tests in place that would allow us to move the zstd version dependency prior to upstream?
Does zstandard have shared libraries that import/export any symbols in case it is built against statically linked zstd?
If not, is it feasible to built against conda-forge::zstd-static and thus avoid the zstd dependency here.

Yeah, we can link statically and include the license file.


IMU buffer issue

I tried to run the repo in ROS2 foxy and ROS2 humble. At start it looks good, but after few seconds it starts to get slow and laggy.
When looking at the code and printing out the time it takes for some of the functions to execute, I found out that this part of the code (from the ErrorStateKF.cpp file) with each iteration it takes longer and longer to execute:
auto timeStart = omp_get_wtime();
// process remaining imuMeasurements
for (auto & imu : ImuMeasurements_) {
process(imu);
}
auto timeEnd = omp_get_wtime();
std::cout << "elapsed time = " << std::fixed << (timeEnd - timeStart) * 1000 << " ms\n";
Terminal output:
elapsed time = 0.148940 ms
elapsed time = 0.447329 ms
elapsed time = 2.189356 ms
elapsed time = 3.753960 ms
elapsed time = 4.660913 ms
elapsed time = 4.964182 ms
elapsed time = 6.703187 ms
elapsed time = 8.545713 ms
elapsed time = 8.818235 ms
elapsed time = 12.004614 ms
elapsed time = 12.267924 ms
elapsed time = 19.088806 ms
elapsed time = 17.534778 ms
elapsed time = 20.860500 ms
elapsed time = 20.584724 ms
elapsed time = 23.417522 ms
....
....
elapsed time = 915.021006 ms
elapsed time = 972.446391 ms
elapsed time = 1013.187167 ms
elapsed time = 1051.016102 ms
elapsed time = 1098.766206 ms
elapsed time = 1156.308788 ms
elapsed time = 1213.135090 ms
elapsed time = 1258.808280 ms
elapsed time = 1323.948975 ms
elapsed time = 1388.996876 ms
I suspect that the past IMU measurements (from previous state predict and update steps) are still kept in the buffer and that's why the computational time increases.

I did not encounter such an issue on my PC. Could you let me know which rosbag you used?

I tested with the same rosbag, but the elapsed time did not exceed 0.02ms.
Sorry, but it might be helpful to check the following items:

rosbag overload
Try lowering the rate or adding the --read-ahead-queue-size option.

Open3D visualizer rendering overload
The "max_num_points_per_voxel" in the config file is used only for rendering purposes.
Try reducing this value.
hilti_config.yaml
local_map:
voxel_size: 0.3
max_num_points_per_voxel: 1000

Release build
Ensure that Open3D and this package were built in Release mode.
To build in Release mode, add the -DCMAKE_BUILD_TYPE=Release option.

Building the package with this option "colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release" solved the issue. I did not test the option 1 and 2 that you provided.


unnessary parenthesis

@a14n feel free to land your patch, we'll take care of the other thing separately. Thanks for catching it.

@Hixie ok. I'll wait CIs
btw what would you think about removing unnecessary parenthesis like:
(a && b) || (c && d)

(I'm creating a lint to catch unnessecary parenthesis and I wonder if I should limit its action)

Is || lower priority than &&? So the above is equivalent to a && b || c && d?
That seems unobvious. I'd probably keep the parens in that case.

https://www.dartlang.org/guides/language/language-tour#operators gives the ordered list of precedence. My lint is based on it.
One advantage about the extended version of the lint is that it learn the user what is the priority list. But I agree that it could be hard to read.

The problem is that different languages have different priority orders and it's not obvious what the order is in any particular language. Based on a quick look at that table I'd probably allow parens around any expression that contains an operator that is then in another expression with another operator of lower (not equal) precedence, except if that operator is ==/!=, ?:, or any of the assignment operators. (Obviously if the operator is of higher precedence, then the parens are required anyway.)

Looking at flutter code base there are both styles. You can find (a && b) || (c && d) and a && b || c && d.

Yeah, probably depends how familiar the author was with the order of operations at the time. :-)
Are the cases without parens cases where the || is on a line break? I bet that makes the code clearer too...


feat: deprecate Compilation API

Summary

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6505  👈
#6448
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on  Graphite

!eco-ci

!eco-ci


how to use the dist_test.sh ?

when i want to test the model,it  prompt need checkpoint file.
would you please tell me how to use dist_test.sh ? I don't know what parameters to provide.
CHECKPOINT=$2  ????

when i want to test the model,it prompt need checkpoint file.
would you please tell me how to use dist_test.sh ? I don't know what parameters to provide.
CHECKPOINT=$2 ????


Allow min() and max() functions

See https://github.com/JackDunnNZ/AmplNLWriter.jl/issues/15.

Would you mind adding some test cases?

@JackDunnNZ

Thanks!


Re-initialising tablesaw 3.1.2 in swipe mode

I have essentially the same issue like #163 with a tabbed interface and some tables residing inside containers with display: none;
I'm using the current master branch of tablesaw (3.1.2.) Issue #163 presents the following solution for tablesaw 2.0.4: $("#myTable").data('table').refresh();
I trigger the code in an event handler when the corresponding tab is clicked that sets display: flex; on the container. However it doesn't resolve the problem. Instead I get a javascript error: jQuery(...).data(...) is undefined.
Each table's html has the following form <table id="myTable" class="tablesaw tablesaw-stack" data-tablesaw-mode="swipe" data-tablesaw-sortable>

Worked for me: $("#myTable").tablesaw().data('tablesaw').refresh();
Though, It slows down noticeable after dozens refreshes. It might be the memory leak issue.


Any way to add a tickmark/marker showing a prior value (i.e. status over time)?

Something like this:

That would be a super addition!


Serial prints

Hi I noticed the code has Serial.prints dotted about the place. I've moved them into ifdef DEBUG ENABLE blocks to stop spillover into the Serial when not required.

Thanks @milGus
I've done as for other debug messages usind the defined macro log_debug


fix buffer initialization in base64 encoding in node

If a number was passed to encode(), the buffer would be created with
uninitialised memory. This patch casts anything that's passed in to
a string first and then uses the safe Buffer.from API. Buffer.from
was added in Node v4 but the buffer-from module ponyfills it for older
Node versions.
See nodejs/node#4660

Ouch, it hurts seeing such errors arise in JavaScript. Thank you a lot for solving this. Could you please address the one linting issue? https://travis-ci.org/tus/tus-js-client/jobs/237541799#L428

Done :)

Thank you, I added a test and merged in 66694b4a93c8f9a7cda5ee4ea52e3692df926ef4


Promote integration-service from staging to production

Included PRs:

https://github.com/redhat-appstudio/integration-service/pull/421
https://github.com/redhat-appstudio/integration-service/pull/443
https://github.com/redhat-appstudio/integration-service/pull/438
https://github.com/redhat-appstudio/integration-service/pull/460
https://github.com/redhat-appstudio/integration-service/pull/457
https://github.com/redhat-appstudio/integration-service/pull/456

I think we should hold off on approving/merging this until Monday rather than risk breaking prod right before the weekend.

I think we should hold off on approving/merging this until Monday rather than risk breaking prod right before the weekend.

Agreed, lets not spoil the weekend with potentional prod complications.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/23 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 2897f5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Terminal - New Terminal -> The terminal process command '/bin/login_script.sh -l' failed to launch (exit code: 1)

Issue Type: Bug
Terminal - New Terminal -> The terminal process command '/bin/login_script.sh -l' failed to launch (exit code: 1)
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:29:22.216Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
8.00GB (0.23GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

python
ms-
2019.5.18875

This means that /bin/login_script.sh exited with a code of 1, you should investigate that yourself as I don't know what your login script does.


Fixes Issue #42 (build script fails)

https://github.com/anmonteiro/aws-lambda-ocaml-runtime/issues/42

Thanks for this -- would you mind adding it to every Dockerfile in the examples folder?

Sure. I'll test all examples. And send patch for each.

I really appreciate that -- you may have to bump the esy versions in the Dockerfile to 0.5.8 or @latest

Can I set every example dependency to use @latest (docker images, packages, ocaml, etc)? I prefer that behavior because softwares gets outdated quickly. And if it breaks we can always fix it.

Yeah I think that's fine

I tried to use git commit but I did not have permission. Then I tried to paste the patch here but GitHub did not accept. So I zipped it. I hope you'll be able to apply it. Sorry for the inconvenience.
patch-coreutils.zip

https://github.com/superherointj/aws-lambda-ocaml-runtime/commit/1d1cfc69a66fb6029084c2af8d982492186b6aa2

can you open a new PR from that commit?

Done.


Twig syntax support

Please add twig syntax support.

What file extensions are typically associated with twig? I would guess twig? any abbreviations or others? I'll add it when I get a chance unless you or someone else would like to do a pr...?

@jonschlinkert yes, twig: filename.html.twig, filename.json.twig, etc... Thanks.

noted, thanks for the info


Trait collision with ConditionalContainer

Great work!
When using together with ConditionalContainer I get following trait collision
Trait method 'availableFields' will not be applied because it collides with 'HasConditionalContainer'
Is there a way to solve this?

There is no real bullet-proof solution for this yet, laravel nova should do something similar to how eloquent boot traits to be able to stop overriding these methods... but this is an issue that has come up multiple times in other repositories as well.. I think you can follow this workaround it should work:
https://github.com/dcasia/nova-json-wrapper/issues/4#issuecomment-559796743
https://github.com/dcasia/nova-json-wrapper/issues/10#issuecomment-665444790

wonder if insteadof could be used - but which availableFields is the one which would support both correctly?
https://www.php.net/manual/en/language.oop5.traits.php
    use A, B {
        B::smallTalk insteadof A;
        A::bigTalk insteadof B;
    }

You need both .. they all call parent::availableFields() thats why extending the class works...

No longer an issue on the latest version


Error when revoking READ on future stages

Describe the bug
Hi,
I am getting many of these errors:
2023-01-16 12:34:15.176 - WARNING - Resolved ROLE [DEV__MYSCHEMA__WRITE__S_ROLE]: ERROR
(
message   =>  SQL compilation error: Privilege order violation for the future grants on stage. WRITE should be revoked before/simultaneously with READ.
errno     =>  3512
sqlstate  =>  23001
sfqid     =>  01a9b012-0102-2fef-0001-01e200d5ce6a
sql       =>  REVOKE READ ON FUTURE STAGES IN SCHEMA "DEV_TEST"."MYSCHEMA" FROM ROLE "DEV__MYSCHEMA__WRITE__S_ROLE"
)
This is after cloning DEV -> DEV_TEST and so SnowDDL is revoking grants to DEV__ roles.
Expected behavior
Revoke WRITE before/simultaneously with READ, as Snowflake error advises.

@marksabincarnivaluk , this issue should be fixed in 0.13.0:
https://github.com/littleK0i/SnowDDL/blob/master/snowddl/resolver/abc_role_resolver.py#L70-L77
I've introduced an additional sorting step while retrieving existing grants. WRITE grant for stages should now be properly revoked before READ grant. It applies both to normal grants and future grants.
Also, now I can easily add more sorting rules if we find more similar use cases.
Thank you for pointing this out.


⚠ PrivateHD has degraded performance

In 64c23ba, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3176 ms

Resolved: PrivateHD performance has improved in 19c0f47.


Merge Sort using Divide and Conquer

Hi @nits01.
Merge sort algorithm is already present and was added as a part of https://github.com/amanmehara/programming/commit/d7657ceef0d4544af7d601b37107817cc861d13f


Couldn't find the cantools command ?

When i run cantools generate_c_source RSDS_PCAN_V18.dbc,the terminal display not find the cantools command

Are you on Windows?

Thanks ! after i reset the system,i find the cantools command.
My systme is ubuntu 18.04


combined_chart support scroll

Please review the commit and merge the commit when no problem.Thank you.

thanks for your pull and i move scroll to other charts


Error on niche usecase for exports with global jQuery

I'm using node/commonJS (under browserify) with jQuery loaded as global.
I'm getting an error inside the factory as it enters the 'exports exists' and it's trying to 'require(jQuery)'.
I've solved it by removing the condition and just going with the global (inside the factory function).
You could use
function module_exists( name ) {
  try { return require.resolve( name ) }
  catch( e ) { return false }
}

(resolve - doesn't loads the module just checks if it exists)
... and have something like this
(function (factory) {
  if (typeof define === 'function' && define.amd) {
    // AMD. Register as anonymous module.
    define(['jquery'], factory);
  } else if (typeof exports === 'object' && module_exists(jQuery)) {
    // Node / CommonJS
    factory(require('jquery'));
  } else {
    // Browser globals.
    factory(jQuery);
  }
})(function ($) {

PS: thanks for the awesome plugin

I think you're going to have more problems than just cropper if you try using browserify but don't make jQuery available through require.
Instead of modifying Cropper. I recommend using either browserify-shim or exposify to expose the global jQuery variable as require('jquery') to browserify.

@dantman Thank you for answering this issue for me.


Look Assigner: Move Look Assigner tool since it's Maya only

Changelog Description
Fix #4357: Move Look Assigner tool to maya since it's Maya only
Additional info
This is just a draft, untested - and quick attempt on moving it around. In train currently and can't test easily.
Testing notes:

Start Maya
Look assigner should work as intended

@BigRoy will keep an eye on this for when it's out of draft mode cause now you are just stealing my tasks🙂

will keep an eye on this for when it's out of draft mode cause now you are just stealing my tasks🙂

Did a quick test-run. Worked for me.


[Sessions] Add SessionStartEvent wrapper for building the nanopb proto

Adds functions for interacting with nanopb. Some parts of this were difficult to do in Swift, so I had to do them in ObjC.
Adds SessionStartEvent as an abstraction over the proto
Adds FireLog dependency, and logs events to FireLog

#no-changelog

Apart from the comments: 3 major suggestions:

We need a clear/module class interaction defined and name the classes according to them. Some generic terms used for classes would grow in time to become hard to maintain.
Lets add comments to every class/function/variable to ensure that it becomes easier to understand that the class/function is supposed to do. Right now, I find it hard to understand the purpose of them
Logging levels for log messages - We need to have a good defined rule about the logging level for messages. Typically, error level is set for only something that the user has set something wrong as. For eg: bad app Id name. Anything else, should have a log level of warning or below. It might be good to even define them in the execution doc.

The way I think about naming classes is to look at what they do. I often find class names that are vague using overloaded terms like -Manager -Controller, etc. and I tend to move away from suffixes like those because they have no meaning (or overloaded meanings that we aren't conforming to). If a class name can be described by 1 word I go for 1 word because the extra words are meaningless.

I think commenting every class is good, I don't think commenting every variable or method is worth the time though - it actually takes a lot of time to do, and doesn't provide value in the long run. I subscribe to the idea that if the method does more than one thing it's worth a comment, but most variables or methods should be self-documenting.

In terms of logging levels, I generally subscribe to the following: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels

Warning is recoverable, Error is not. I'm interested if the core folks have advice they try to get everyone to follow.

Gonna submit this to unblock Leo. I'm gonna follow up with a refactor to the Identifiers class


Binding file for wsdl files source generation

Hello. Running "generate-sources" goal I get the following error
[ERROR] Error while parsing schema(s).Location[
file:/home/*/src/main/resources/soap/binding.xjb{8,30} ].
com.sun.istack.SAXParseException2; systemId: file:/home/*/src/main/resources/soap/binding.xjb; lineNumber: 8; columnNumber: 30;
Multiple <schemaBindings> are defined for the target namespace "http://schemas.***"

There are several wsdl files and for each of them I need different target package, so I tried using binding file, but for only 1 wsdl for now.
Here is my plugin configuraiton
            <configuration>
                <schemaLanguage>WSDL</schemaLanguage>
                <schemaDirectory>${basedir}/src/main/resources/soap</schemaDirectory>
                <schemaIncludes>
                    <include>manager/*.wsdl</include>
                </schemaIncludes>
                <bindingDirectory>${basedir}/src/main/resources/soap</bindingDirectory>
            </configuration>

Here is binding.xjb file
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<jaxb:bindings
        version="2.1"
        xmlns:jaxb="http://java.sun.com/xml/ns/jaxb"
        xmlns:xs="http://www.w3.org/2001/XMLSchema">

    <jaxb:bindings schemaLocation="manager/service.wsdl" multiple="true" node="//xs:schema">
        <jaxb:schemaBindings>
            <jaxb:package name="com.test.manager"/>
        </jaxb:schemaBindings>
    </jaxb:bindings>
</jaxb:bindings>

Beginning of service.wsdl file
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<wsdl:definitions xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/"
                  xmlns:sch0="http://schemas.***"
                  xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/"
                  xmlns:tns="http://schemas.***"
                  targetNamespace="http://schemas.***">
    <wsdl:types>
        <xs:schema xmlns="http://schemas.***"
                            xmlns:xs="http://www.w3.org/2001/XMLSchema"
                            attributeFormDefault="unqualified" elementFormDefault="qualified"
                            targetNamespace="http://schemas.***">
            <xs:simpleType name="NumericReference">
                ***
            </xs:simpleType>
            <xs:simpleType name="EntityNumber">
                ***
            </xs:simpleType>
        </xs:schema>
        <xs:schema xmlns="http://schemas.***"
                            xmlns:xs="http://www.w3.org/2001/XMLSchema"
                            attributeFormDefault="unqualified" elementFormDefault="qualified"
                            targetNamespace="http://schemas.***">
            <xs:complexType name="DisplayGroup">

Could you please help with resolving this issue?
Looks like the problem is connected with multiple xs:schema elements with same targetNamespace, but I can't find the solution without modifying wsdl.

The point is, JAXB needs 1:1 corrspondence between target namespace and package. So you should define different packages for different namespaces and same package for the same namespace.
I can't see target namespaces of your xs:schemas so it's a bit hard to say what's happening.
Basically you define the same package for multiple xs:shemas.
If there are different target namespaces there, you have a problem. You need to define different packages for these different target namespaces.
If all you xs:schemas are the same then I guess XJC does not tolerate multiple schemaBindings (even if they define the same target package). In this case it should be actually enough to customize just one xs:schema like //xs:schema[0] or something similar.

Closing as the question seems to be answered.


[WIP] Optimize expressions with Zygote-based autodiff

cc @kazewong
This is an attempt to use evalGradTreeArray in the constant optimization. This function computes the explicit Zygote.jl-based derivatives of an expression with respect to its constants, so in theory it should be faster than letting Optim.jl figure the gradient out using finite differences.
However, right now this attempt is about a quarter of the speed of when using Options(..., enable_autodiff=false). I'm not sure why this is. @kazewong, you mentioned you had seen a speedup right? Do you know why this attempt is slowing things down?
Cheers,
Miles

I also messed around with using Optim.only_fg! so I wouldn't have to re-compute the expression output. I couldn't get this warning as it seemed to want the Hessians too... Attempt is on branch optimize_with_autodiff_shared_compute.

Alternatively... maybe it only appears to be slower since the optimization is limited by number of steps? i.e., it only appears slower since I am now computing, say, 10 evaluations of f + 10 evaluations of df, vs before where it might have been 20 evaluations of f. The former should give you better optimization, even though it's slower. So perhaps a better comparison would be with a reduced number of optimization steps? (a bit harder to measure - will need to explicitly measure the constant optimization routine with/without autodiff)

So many changes since this was submitted we probably want to re-write this from scratch.


[preemption] Use strict patching when issuing evictions.

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:
[preemption] Use strict patching when issuing evictions to avoid duplicate workload preemption.
Which issue(s) this PR fixes:

Fixes #2244
Special notes for your reviewer:
Does this PR introduce a user-facing change?

None

I'm actually surprised that we never did this before.
Thanks!

/approve
/lgtm


Please add the user_timezone property to the embed examples

It is claimed that user_timezone can be specified here: https://discourse.looker.com/t/user-specific-time-zones-3-22/875/8 and https://discourse.looker.com/t/looker-3-34-release-notes/1682
vincentFeb 1
Hi @Jay_Stricks,

To set an embed users timezone, in the same query params that you put the permissions, models, etc, you add another one like so user_timezone: json_user_timezone. Let me know if you have any questions on this.

Cheers,
Vincent

and
Powered By Looker
PDF Downloading for Embedded Dashboards. Permissions are configured in the same way as for regular Looker Users and Roles.
All Download Types for Embedded Elements. Permissions are configured in the same way as for regular Looker Users and Roles.
User Timezones for SSO Embedding. Set the parameter as part of the SSO embed setup process.

But there is no complete example of this and the feature is not documented in the PDF embedding instructions provided by Looker (update: i do see the parameter listed in the PDF document). This makes the API really, really difficult to use. Does the user_timezone parameter need to be included in the request signing? Is it just a dashboard filter parameter?
Furthermore, the python example here: https://github.com/looker/looker_embed_sso_examples/blob/master/python_example.py does not use the user_timezone parameter.

I agree. Looks like it got added only to the ruby example:
https://github.com/looker/looker_embed_sso_examples/blob/master/ruby_example.rb#L76


custom the namespace when registry a child cluster

What would you like to be added:
Why is this needed:

I have the same requirement for this feature.  Mark