Refresh Token Revoked

I'm having issues with receiving the verification code. It says refresh_token_revoked after I enter my account and password

I am too. You may want to close this and add your issue to the ones that are already open?

I read the other issues, which seem related to re-logging in after adding. I can't add Kwikset integration because of this error tho.

Mine won't even allow me to refresh the token. It just says Failed to Setup.

#68 and this issue seems to be related

Probably

@explosivo22 hi there.
Any updates?

I'm getting this error as well. I see the following after entering username and password

Sorry for the delayed response.  This one has been unusually difficult to track down as I am unable to replicate this on my end no matter what I do, but also as there is not built in way to actually handle this error.  I am working on it though.

I have released an alpha to test something, but I am going to continue to try and trace this down.

Sorry for the delayed response. This one has been unusually difficult to track down as I am unable to replicate this on my end no matter what I do, but also as there is not built in way to actually handle this error. I am working on it though.
Just for clarification, you all can get through the setup the initial time, but when it says you must reauthenticate is when it is failing?

Thank you for working on this! I am setting it up for the first time today and I get the message "refresh_token_revoked" when it asks for the verification code.

Sorry for the delayed response. This one has been unusually difficult to track down as I am unable to replicate this on my end no matter what I do, but also as there is not built in way to actually handle this error. I am working on it though.
Just for clarification, you all can get through the setup the initial time, but when it says you must reauthenticate is when it is failing?

Thank you for working on this! I am setting it up for the first time today and I get the message "refresh_token_revoked" when it asks for the verification code.

Are you using the the prerelease build, 0.2.4-alpha1, or the last official 0.2.3?

Sorry for the delayed response. This one has been unusually difficult to track down as I am unable to replicate this on my end no matter what I do, but also as there is not built in way to actually handle this error. I am working on it though.

Just for clarification, you all can get through the setup the initial time, but when it says you must reauthenticate is when it is failing?

Thank you for working on this! I am setting it up for the first time today and I get the message "refresh_token_revoked" when it asks for the verification code.

Are you using the the prerelease build, 0.2.4-alpha1, or the last official 0.2.3?

I'm also trying to do the initial setup. The 0.2.4 alpha 1 shows unknown error occurred instead

Sorry for the delayed response. This one has been unusually difficult to track down as I am unable to replicate this on my end no matter what I do, but also as there is not built in way to actually handle this error. I am working on it though.
Just for clarification, you all can get through the setup the initial time, but when it says you must reauthenticate is when it is failing?

Thank you for working on this! I am setting it up for the first time today and I get the message "refresh_token_revoked" when it asks for the verification code.

Are you using the the prerelease build, 0.2.4-alpha1, or the last official 0.2.3?

Using last official 0.2.3

I have same problem and would be more than happy to try your 0.2.4 alpha release, but I don't know how to get it installed.

I have same problem and would be more than happy to try your 0.2.4 alpha release, but I don't know how to get it installed.

I think I got the 0.2.4 alpha release installed. What information do you want? As expected, I still get the refresh token rejected error.

Please don't close this as this is still active and a issue

Initial setup using official 0.2.3 resulted in “ refresh_token_revoked” - I attempted many times, but no change. Then I reset and downloaded alpha 0.2.4 which results in “unknown error occurred”

I am trying this add-on for the very first time, using 0.2.4-alpha1.  I am having similar problems, I can extract more debug logs if you are interested. This is what happens: When I go to configure the integration (clicking "+ Add Integration", search for Kwikset locks), it pops up the email/password dialog, then I get the "How would you like to receive your verification code?". I have tried it both ways, I never seem to receive the verification code.  I see there are LOGGER.debug() calls in the code when it start to talk to the kwikset API, so I may try to enable that and see what I get.

Here is where I am at with this... I found the python package aiokwikset which I believe to be maintained by the same author?  In any case, const.py shows a hostname ynk95r1v52.execute-api.us-east-1.amazonaws.com which I believe it would be communicating with, this hostname resolves to 4 IP addresses, <IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS> and <IP_ADDRESS>. When running through the setup process for kwikset-ha and running a tcpdump on my router, I didn't see any packets to/from this IP address.  I did get the following backtrace from what appears to be the http request, I am not sure what to make of it:
===
2024-04-29 22:04:03.573 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 88, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 32, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 71, in with_admin
return await func(self, request, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 222, in post
return await super().post(request, flow_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 73, in wrapper
result = await method(view, request, data, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 122, in post
result = await self._flow_mgr.async_configure(flow_id, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 356, in async_configure
result = await self._async_configure(flow_id, user_input)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 402, in _async_configure
result = await self._async_handle_step(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 506, in _async_handle_step
result: _FlowResultT = await getattr(flow, method)(user_input)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/kwikset/config_flow.py", line 189, in async_step_code
await self.api.verify_user(self.pre_auth, user_input[CONF_CODE])
File "/usr/local/lib/python3.12/site-packages/aiokwikset/api.py", line 278, in verify_user
Session=pre_verification['Session'],
~~~~~~~~~~~~~~~~^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

Just installed this add-on myself and getting the same refresh_token_revoked with 2.3


A11y_Azure Data Studio extension 'Azure SQL Migration'_View/Select_Link Purpose: "More info" link present in issues table of databases is not descriptive. Screen reader is not announcing link name.

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
Github Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #Benchmark; #SH-AzureSQLMigration-Win32-Jun2022; #DesktopApp; #Win32; #SQL Migration Control Plane; #WCAG2.4.4; #Link Purpose;
Environment and OS details:
Azure Data Studio Version 1.37.0(User Setup)
Windows Version 21H2 (OS Build 22000.675)
Note:
This issue is observed for all "More info" links present in all issues table
Repro Steps:

Turn on Narrator/NVDA
Install Azure data studio app and install Azure SQL migration extension
Connect to SQL server, tab till respective server, right click and select manage
Tab till Azure SQL Migration in sitemap and press enter key
Tab till migrate to azure sql and press enter
Navigate to databases grid in "Databases for assessment", select few databases and click next.
In Assessment results and recommendations step, select a azure sql target and navigate to "View/select" button and press enter
After selecting a database in "Assessment results" dialog, issues will be displayed.
In issues table, verify whether screen reader is announcing "More info" link descriptively or not

Actual Result:
"More info" link present in issues table of databases is not descriptive. Screen reader is only announcing as "link More info" but screen reader is not announcing link name i.e Supported compatibility levels in Azure SQL Managed instance.
Expected Result:
"More info" link present in issues table of databases should be descriptive. Screen reader should announce link name i.e Supported compatibility levels in Azure SQL Managed instance and then it should announce role.
Attachment:

@brian-harris, can you please add aria-label to these links?

#Closed;
Verified the issue in below Environment:
Issue is Fixed
Version: 1.41.1 (user setup)


ProtocolError 500 Internal Server Error after update to 	23.1.4_1

I am experiencing this error:
"Unexpected error fetching PF-Router OPNsense state data: <ProtocolError for<EMAIL_ADDRESS>500 Internal Server Error>"
It seemed to start after a recent OPNSense update (at least, it seemed to occur after I told the hass-opnsense to update to the latest firmware). I tried a full re-install of both the plugin on OPNSense and the integration on HASS, but it didn't fix it.

Duplicate of #68 and #70


fix: replace any ttl-num-blocks value

Overview
On one of our node I found the default ttl-num-blocks value as 10 instead of 5, so the default approach will not work in this case and it should be fixed with this commit.

I also found ttl-num-blocks = 0 and ttl-num-blocks = 15 on our RPC nodes (these have been around since the mocha-2 genesis I guess so that's probably the reason)

thanks @kinrokinro !!


Add updated Google Analytics code

Pending on #61

From @Roenok:
From our current production site, the UA-code is UA-19096645-1
<script type="text/javascript" async="" src="http://www.google-analytics.com/ga.js"></script>

<script>
  var _gaq = _gaq || [];
  _gaq.push(['_setAccount', 'UA-19096645-1']);
  _gaq.push(['_trackPageview']);

  (function() {
    var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
    var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
  })();
</script>

From @DBNess:
Yay analytics!! Can we set this up using an environment variable, so that
only the production site's visits are recorded to this tracking code? That
way people developing the site locally won't falsely affect our Google
Analytics numbers.
Here's a code example of how to set this up:
Frontend code references GOOGLE_ANALYTICS_TRACKING_CODE variable:
https://github.com/CodeMontageHQ/codemontage/blob/master/app/views/layouts/_google_analytics.html.erb
GOOGLE_ANALYTICS_TRACKING_CODE variable is defined per environment:
https://github.com/CodeMontageHQ/codemontage/blob/master/config/environments/production.rb
https://github.com/CodeMontageHQ/codemontage/blob/master/config/environments/development.rb

@DBNess sure! @juliaelman & @Roenok do we have access to the analytics to get/create these two codes? I'd be happy to put this together if so...

@kstack7 done!

Thanks for the input @DBNess ... This is set at PR #189


Support Systemjs and Browserify

Please add support for systemjs and browserify.

I would request more information since no examples are provided. And I think Browserify works with pdfjs-dist currently (with some modules exceptions).

Here's the most common example to use systemjs:
npm install jspm
jspm init # use defaults
jspm install pdfjs-dist

index.html
<!DOCTYPE html>
<html lang="en-us">

<head>
<meta charset="utf-8">
<title>Form Digitizing</title>
</head>

<body>
    <script src="jspm_packages/system.js"></script>
    <script src="config.js"></script>
    <script>
      System.import('src/app.js');
    </script>
</body>
</html>

app.js
# ES6 syntax
import pdfjs from 'pdfjs-dist';

# expected pdfjs to be a window.PDFJS object

Thank you for example

In previous versions we could use jspm shim to use pdfjs.
https://github.com/jspm/registry/wiki/Configuring-Packages-for-jspm
But after inclusion of node-ensure, we can't (node-ensure doesn't seem to be compatible with system.js).

Actually, this is a request for jspm packager, not specifically Systemjs loader.
I.e. it would be fine if it would require jspm shim, but don't add incompatible changes.

@Vanuan
Having the following in the config.js workaround the issue:
<EMAIL_ADDRESS>{
      "process"<EMAIL_ADDRESS>      "node-ensure": "empty",
      "entry?name=[hash]-worker.js": "empty"
    },

Similar hack is need for Browserify

Now issue: pdf.worker.js is loaded twice, that's an issue was solved by request.ensure() in webpack. The './pdf.worker.js' has to be forbidden from loading until it's really needed.

I thought "PDFJS.disableWorker = true;" solves that? Isn't it?

If you use System.import('./pdf.worker'), it will issue only one http request.

"PDFJS.disableWorker = true;" is not an option,since we want to move PDF processing on the different thread. We don't want suggest lousy solution for library users, do we?

Well, I'd be prefer lousy solution than no solution at all. For my use case, even 1 second page freeze is fine.
I'd be glad if you find a better solution.

What about other notes above?

Is there a specific reason why node-ensure was used?

If you look carefully at what examples/webpack/ produces:
pdf.js yury$ ls -la build/webpack/
total 2384
drwxr-xr-x   5 yury  staff     170 Dec 22 15:20 .
drwxr-xr-x  34 yury  staff    1156 Dec 22 10:08 ..
-rw-r--r--   1 yury  staff  546125 Dec 21 16:35 1.bundle.js
-rw-r--r--   1 yury  staff  546463 Dec 21 16:35 9d074593b165291f150e-worker.js
-rw-r--r--   1 yury  staff  122796 Dec 21 16:35 bundle.js

"bundle.js" is main file that loads (that means it will bring and initialize UI after 122796 bytes -- faster page start up). "9d074593b165291f150e-worker.js" is a worker which will run the logic and don't lock UI on slow devices. "1.bundle.js" portion is loaded only if disapleWorker triggered and for legacy browsers such as IE9.

I'd be glad if you find a better solution.

I'm expecting the systemjs might have some kinda guard to not parse all requires (replacing "./pdf.worker.js" with "empty" did not work for me).
@Vanuan Can you file an issue with systemjs to see if they have something better in mind? Thanks.

Sounds like the very last issue at systemjs https://github.com/systemjs/systemjs/issues/983 ?

Well, I'd be prefer lousy solution than no solution at all. For my use case, even 1 second page freeze is fine.

@Vanuan, nothing changed in usage of the pdf.combined.js file (I hope) -- looks like we need to keep it for such cases. You need to use it as you described as an issue in #6729. From your description it was not clear you are planing to use systemjs to load PDFJS.

nothing changed in usage of the pdf.combined.js file

Ah, great!

Anyway, something has definitely changed with regard to using it with worker.
Previously, we could use full path to worker, but get Uncaught ReferenceError: require is not defined inside it:
PDFJS.workerSrc =<EMAIL_ADDRESS>
Now, it seems like it's stuck on loading files. As if module loaded callback never completes.
The last module requested is process.

Anyway, something has definitely changed with regard to using it with worker.
Previously, we could use full path to worker,

pdf.combined.js fully included/includes pdf.worker.js and does not need workerSrc to be specified.

Changes to pdf.combined.js https://github.com/mozilla/pdfjs-dist/commit/a7cd5f77b00bac19c0f6ee4c2cfd5bbf0fe45d8f#diff-eccf5b94e31b0939738de07167e02af6

Yeap, I'm just evaluating options of using it along with jspm.

Now issue: pdf.worker.js is loaded twice, that's an issue was solved by request.ensure() in webpack

So, now it is being loaded in the main thread and doesn't use importScripts()?

My src/app.js is:
import pdfjs from 'pdfjs-dist';

console.log(PDFJS);

So it's not even using getDocument yet, but in network monitor it shows two entries for pdf.worker.js

It's strange. I only see one entry.

It's strange. I only see one entry.

It shall be none AFAIK :)

The same on Firefox and Chrome:

Ah. So looks like Systemjs dumbly parses all requires and tries to load them...

Conditional require is not a very common use case.

That's why it tries to load node-ensure too.

@yurydelendik
How such requires help webpack? Webpack still loads worker using importScripts, right?

Conditional require is not a very common use case.

I would disagree, https://github.com/systemjs/systemjs/issues/983 and https://github.com/webpack/docs/wiki/code-splitting are common use cases.

Webpack still loads worker using importScripts, right?

It does. But it also has an option to load pdf.worker.js as module if workers are disabled.

The issue will be solved by #6775 -- the systemjs has auto-detect for type of the module. Now it's commonjs, with UMD it will he AMD so it will not try to parse require().

Wow, great, I'll try as soon as merged and released.

Closing as fixed by #6825. If there are remaining problems, please open a new issue.

I also recommend to override module format when using jspm: jspm install npm:pdfjs-dist -o "{format: 'amd'}"


New version ETA

Hey there, thank you for this great library.
I'm using it successfully with the latest Home Assistant docker version. I've got multiple HmIP-STH and would benefit greatly from the changes in develop, that will probably see the light of day in version 0.1.73.
Is there an ETA for 0.1.73? If not I'd try to get the development branch working with my HA instance. Are there any breaking changes/dependency changes in there?
Thanks in advance

I'll publish a new version once https://github.com/danielperna84/pyhomematic/pull/403 has been merged. 👍

Awesome. To change week profiles I currently use homematic.set_device_value with:
interface: ip
address: XXXXXXXXXXX
channel: 1
param: ACTIVE_PROFILE
value: 2
value_type: int

That works quite well - the documentation's example uses put_paramset which is more complicated.


[Bug][client]spotless-check failed

Describe the bug
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.4.2:check (spotless-check) on project flinkx-clients: The following files had format violations:
[ERROR]     src/main/java/com/dtstack/flinkx/client/Launcher.java

To Reproduce
Steps to reproduce the behavior:

mvn clean compile -U -DskipTests on master branch

Expected behavior
Compile success
Screenshots
If applicable, add screenshots to help explain your problem.

Execute the 'mvn spotless:apply' command locally


iOS scroll weird behaviour

Description:
I have a SafeAreaView with an ScrollView inside it and the rare problem I've experienced it's that I can only scroll with 2 or more fingers. Scrolling with one finger does nothing, but if I use 3 fingers i get the scroll performed very well.
I tried different components and styles and this behaviour does not change.
I'm testing on an iPhone 11.
I cant solve this so any help will be refreshing for me :)
React Native version:
System:
OS: macOS Mojave 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 345.08 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 13.3.0 - /usr/local/bin/node
npm: 6.13.2 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 23, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
Steps To Reproduce
SafeAreaView with an ScrollView inside. I also tried different component mixes, as well as only a single ScrollView with long text to scroll, and this behaviour keeps equal, I can only scroll with two or more fingers. Doing it with one does absolutely nothing.
Expected Results
Scroll with only ONE finger.

Problem was with the component GestureRecognizer imported from react-native-swipe-gestures.
It was the thing which was causing the issue :(


Add capability to parse readme files and auto-generate a plugin's discovery.yml text.

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/8
Originally created by @aaronsteers on 2020-07-29 18:11:25

In theory, at least, we should be able to parse the contents of markdown tables and capture the relevant settings config info for externally-managed plugins.
This would greatly streamline the onboarding of new plugins, and could likely reduce support costs for existing plugins.
Depends on: meltano#2206

View 9 previous comments from the original issue on GitLab


Remove index.html from redirect URL

This removes index.html from the path when redirecting from a url like https://dartpad.dev/854a0c97716bb6328d7004abf2e7e3c1
Thanks @Deleplace for the suggestion.

Awesome!


MainWindow crash w. 2 cameras

When 2 cameras are connected to the app, the main window craches.
This is not the case with 1 and with 3 cameras.
What's going on?

It finally appears that it works sometimes with 2 cameras and  no more with 3.
Must redesign some classes.

Might deal with one or both of these:

bad release of resources at end of application (might be)
electric overload of USB plugs when playing with 2 USB cameras, mouse and external keyboard.

This is NOT a S/W issue, but a H/W one.
Might be difficult to alleviate according to embedding platforms H/W and used cameras.
Can't solve this here. This issue is closed now.

It finally appears that capturing frames from 3 cameras and displaying them in independant windows works.
So, the issue must be about the displaying of frames in a same window.

This bug was due to bad inheritance implemented in class Camera.
Successfully replaced now by composition rather then inheritance, with class cv2.VideoCapture.


ILEX-49 Search results - retrieve filter options from rest API

Issue #ILEX-49
Problem: Search results - retrieve filter options from rest API
Solution: Connect filters by getting terms from method getMatchTerms, this method also requires stored search term

it is duplicated, we have similar logic in ilex-50 task pr


Move away from shared project

This is an alternative approach to share code between the two clients. This is a tad more inline with the dotnet CLI as we no longer depend on legacy projects.
The impetus for this change was to improve cold compilation times.
My local jetBrains Rider kept locking up trying to do the initial compile.

Moves us over to <ArtifactsPath> (set to $root\.artifacts like other .NET projects)
Removes a leftover <OutputPath> for certain projects (this was tripping up deps.json resolving HARD).
No longer use nuget package locking

nuget resolves to lowest anyway and we never float dependencies
no other .NET repository at Elastic does this.

This looks great ❤ Thanks a lot for creating this PR.
I will need some time to review in detail, but already have one comment regarding the locked restore:
Would keeping the package lock have any other noticable drawback? I usually like that approach as it e.g. allows for easy package caching in CI (based on a hash of all package.lock.json files). This speeds up build times on the slow GitHub workers quite a bit.
To mitigate some of the "developer experience issues" like having to use --force-evaluate, my usual approach is to guard the condition like this:
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<RestoreLockedMode Condition="'$(ContinuousIntegrationBuild)' == 'true'" />

The CI passes that argument whenever the project must be built or packaged:
https://github.com/elastic/elasticsearch-net/blob/5cde9691b5a4613068ae1c97e8c6268575f77d57/.github/workflows/release.yml#L86
What do you think?

We simply cache by [cf]proj files. Slightly higher cache busting rate but in practice not a big issue :)
https://github.com/elastic/apm-agent-dotnet/blob/3ffe9b4f24f2e3cfdc5e82c1a42e346d64d36fb9/.github/workflows/bootstrap/action.yml#L39

No super strong opinion here, but given that the package.lock.json approach has no real drawbacks (AFAIK), I think it's the more robust approach. These files always represent the final package graph.
Hashing just [cf]proj won't capture changes in includes for these files as well as Directory.Packages.props, Directory.Build.props, Directory.Build.targets, etc.
Directory.Build.props for example is currently used to include the DotNet.ReproducibleBuilds package.


Output template now supports '0*d' zero padding

Might be an option for issue #5185.

I'm open for a better name for the fmt function. :p

Complete python 2 string formatting operations specification should be supported.
Current code has lots of issues. FYI, I've an implementation started several months ago that covers 1 but postponed due some subtleties I don't actually remember now. Here are the test set (integer only) I've used to test own implementation against (everything passes). Yours should pass as well:

    def test_prepare_filename(self):
        info = {
            'id': '1234',
            'ext': 'mp4',
            'width': None,
            'height': 1080,
        }

        def fname(templ):
            ydl = YoutubeDL({'outtmpl': templ})
            return ydl.prepare_filename(info)
        self.assertEqual(fname('%(id)s.%(ext)s'), '1234.mp4')
        self.assertEqual(fname('%(id)s-%(width)s.%(ext)s'), '1234-NA.mp4')
        # Replace missing fields with 'NA'
        self.assertEqual(fname('%(uploader_date)s-%(id)s.%(ext)s'), 'NA-1234.mp4')
        self.assertEqual(fname('%(abr)d.%(ext)s'), 'NA.mp4')
        self.assertEqual(fname('%(height)d.%(ext)s'), '1080.mp4')
        self.assertEqual(fname('%(height)d.%(ext)s'), '1080.mp4')
        self.assertEqual(fname('%(height)6d.%(ext)s'), '  1080.mp4')
        self.assertEqual(fname('%(height)-6d.%(ext)s'), '1080  .mp4')
        self.assertEqual(fname('%(height)06d.%(ext)s'), '001080.mp4')
        self.assertEqual(fname('%(height) 06d.%(ext)s'), ' 01080.mp4')
        self.assertEqual(fname('%(height)   06d.%(ext)s'), ' 01080.mp4')
        self.assertEqual(fname('%(height)0 6d.%(ext)s'), ' 01080.mp4')
        self.assertEqual(fname('%(height)0   6d.%(ext)s'), ' 01080.mp4')
        self.assertEqual(fname('%(height)   0   6d.%(ext)s'), ' 01080.mp4')
        self.assertEqual(fname('%%(height)06d.%(ext)s'), '%(height)06d.mp4')
        self.assertEqual(fname('%(width)06d.%(ext)s'), 'NA.mp4')
        self.assertEqual(fname('%(width)06d.%%(ext)s'), 'NA.%(ext)s')
        self.assertEqual(fname('%%(width)06d.%(ext)s'), '%(width)06d.mp4')

I think it can be achieved in a simpler way, see this example:
class StringInt(str):
    def __int__(self):
        return int(str(self))

kw = {
    'id': 'foo',
    'number': '001234',
}

for k, v in kw.items():
    if isinstance(v, str) and v.isdigit():
        kw[k] = StringInt(v)

formats = [
    '%(id)s-%(number)s',
    '%(id)s-%(number)d',
    '%(id)s-%(number)06d',
    '%(id)s-%(number)-6d.ext',
]

for f in formats:
    print('==> f=', f)
    print(f % kw)

@jaimeMF this approach fails on missing keys at least. And seems there is no way to stuff NA into non-string format specifier without rewriting it to %(field)s.

The solution by @jaimeMF is much cleaner than mine, as no string manipulation is necessary (and I'm really not happy about parsing an informal spec (that changed between Python versions) with regexes).
I'll adapt it to my PR, and also add the tests, but IMO supporting missing fields should be handled in a different PR, as it definitely involves string parsing as @dstftw notes, and is a different feature, that is useful with or without full formatting string support.

This should be a single PR since not handling missing fields breaks current behavior.

@dstftw Note that playlist_index is a string, so it's not affected with your patch. I'm fine with making it a number, but keep in mind that it won't be automatically padded with he number of entries in the playlist.

If we introduce string formatting operations padding as well as any other formatting is the responsibility of the user imo.

If we introduce string formatting operations padding as well as any other formatting is the responsibility of the user imo.

I think as you, but I don't personally use them so real users may disagree.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping github.com/google/go-cmp d103655...f144a35:
  > f144a35 Additional cleanup with Go 1.13 as minimal version (# 295)
  > 63c2960 remove xerrors (# 292)
  > 71220fc Use string formatting for slice of bytes (# 294)
  > 4664e24 Fix printing of types in reporter output (# 293)
  > 79433ac Run tests on Go 1.18 (# 290)
  > 039e37c Add //go:build lines (# 285)
  > 3242228 Drop hacks to work around Go reflection bugs in Go1.9 (# 282)
  > f59cd61 Update minimum supported version to go1.11 (# 281)
  > 6faefd0 Reduce minimum length for specialize string diffing (# 275)
  > f1773ad Use any alias instead of interface{} (# 276)
  > 9094ef9 Change build status badge (# 269)
  > 3ee52c8 Fix spelling mistakes (# 271)
  > 395a0ac Use sha256 in test (# 268)
  > 402949e Merge pull request # 266 from dsnet/fix-format
  > 290a6a2 Avoid shadowing variable (# 263)
  > d5fcb38 Fix textual printing of byte slices
  > 248ccff Fix staticcheck findings (# 262)
bumping k8s.io/api 44d27eb...4b838ea:
  > 4b838ea Update dependencies to v0.25.2 tag
  > fce3016 Merge pull request # 112161 from pohly/automated-cherry-pick-of-# 112129-origin-release-1.25
  > 29513a2 dependencies: update to ginkgo v2.1.6 and gomega v1.20.1
  > 5c4a1b1 Merge remote-tracking branch 'origin/master' into release-1.25
  > 714e431 Merge pull request # 111657 from aojea/hc_nodeport
  > 8608211 Merge pull request # 109090 from sarveshr7/multicidr-rangeallocator
  > 7840548 doc services healthcheckNodePort is inmutable
  > b88698c Merge pull request # 111258 from dobsonj/kep-596-ga-feature-flag
  > a7621fb Auto generate code for ClusterCIDR API
  > 2f9e588 Merge pull request # 111113 from mimowo/retriable-pod-failures-job-controller
  > b964bc7 Move CSIInlineVolume feature to GA
  > 14e048f Introduce networking/v1alpha1 api, ClusterCIDR type
  > 3be517c Merge pull request # 111696 from liggitt/go119mod
  > fe83bea Support handling of pod failures with respect to the specified rules
  > 991b481 Merge pull request # 108692 from jsafrane/selinux
  > e281bde Update go.mod to go1.19
  > f42f86a Regenerate files
  > a39f97c Add CSIDriverSpec.SELinuxMount
  > c8f0601 Merge pull request # 111677 from dims/stop-panic-in-govet-levee
  > ea1451a run lint-dependencies and follow directions
  > a2b9bcc Stop panic in govet-levee CI job
  > ad89a10 Merge pull request # 110495 from alexzielenski/atomic-objectreference
  > e590d1f Merge pull request # 111090 from kinvolk/rata/userns-support-2022
  > d978b18 mark persistentvolume's claimRef as granular
  > 7488a8c Merge pull request # 111435 from soltysh/cronjob_timezone_beta
  > 2a31718 Update autogenerated files
  > d351ecd Merge pull request # 111557 from alexzielenski/update-smd-422
  > f990455 Update generated
  > 9448de2 pkg/apis, staging: add HostUsers to pod spec
  > ae37896 update smd to 4.2.3
  > 010c740 Promote CronJobTimeZone to beta
  > 1b82208 Merge pull request # 110959 from mimowo/retriable-pod-failures-pod-conditions
  > 08dedd8 Introduction of a pod condition type indicating disruption. Its `reason` field indicates the reason:
  > f5e1938 Merge pull request # 111587 from ialidzhikov/k8s-utils@ee6ede2d64ed
  > b3c30ab Update `k8s.io/utils` to `ee6ede2d64ed`
  > be740eb Merge pull request # 111441 from denkensk/respect-topology
  > a76179a Merge pull request # 111402 from verb/111030-ec-ga
  > acf399c code generated by script for MatchLabelKeys in TopologySpreadConstraint
  > 537ea12 Merge pull request # 111442 from ialidzhikov/k8s-utils@56c0de1e6f5e
  > d8280df Remove EphemeralContainers beta disclaimer
  > d96a10b api defination for MatchLabelKeys in TopologySpreadConstraint
  > 8f210eb Update `k8s.io/utils` to `9bab9ef40391`
  > 04aced3 Merge pull request # 111254 from dims/update-to-golang-1.19-rc2
  > dda4dee Generate and format files
  > f6f0d0e Merge pull request # 111194 from ravisantoshgudimetla/promote-maxSurge-ga
  > f77fa25 Merge pull request # 111229 from ravisantoshgudimetla/promote-podOS-GA
  > 7b89ea1 Generated: maxSurge for DS
  > 9a18f7a Merge pull request # 110178 from kevindelgado/validation-beta-1-25
  > 844753e Generated: PodOS field to GA
  > d895ab7 api: Promote DS maxSurge to GA
  > 096c9df Merge pull request # 110388 from sanposhiho/graduate-mindomain-beta
  > 1d3dcfc update kjson
  > bdc8eb0 api: Promote PodOS field to GA
  > fa32a3a Merge pull request # 110896 from ravisantoshgudimetla/promote-minReadySec-sts-update-ga
  > eeea400 Update doc comment
  > 08c75a7 Merge pull request # 111008 from cici37/bumpCEL
  > 40e8eea Generated: minReadySeconds for STS
  > 0110f55 Update v1 package to graduate minDomains to beta
  > 0c6d49d Bump cel-go to v0.12.0
  > df27ddf api: Promote statefulset MinReadySeconds to GA
  > b9bd732 Merge pull request # 110564 from j4m3s-s/add-ports-doc-fix
  > 51e4c4a Merge pull request # 111010 from thockin/remove-refs-to-EndpointSliceNodeName
  > b7c39ad Fix description of Ports in PodSpec
  > 248dcdb Merge pull request # 111001 from pohly/klog-update
  > 4756865 Remove obsolete refs to gate EndpointSliceNodeName
  > b5b8fba build: update to klog v2.70.1
  > 8488949 Merge pull request # 110990 from thockin/svc-typenames-IPFamilyPolicyType
  > ed77e2e Rename IPFamilyPolicyType => IPFamilyPolicy
  > 33ab20e Merge pull request # 110868 from rikatz/endport-to-ga
  > f18d381 Merge pull request # 110831 from chendave/openapi
  > 270b22d Generated files for endPort promotion
  > 724b071 Bump `kube-openapi` to the latest
  > e803bc1 Promote endPort to GA
  > b98f264 Merge pull request # 110724 from pohly/klog-update
  > 61fcc0f build: update to klog v2.70.0
  > edebc67 Merge pull request # 110561 from Shubham82/extend_Description
  > 60387f6 Merge pull request # 110378 from lucacome/bump-grpc
  > 1cba8e4 RBAC: Modify the Description for the apiGroup.
  > 89ed2a8 Bump grpc to v1.47.0
  > 6b0201d Merge pull request # 110520 from dims/update-gopkg.in/yaml.v3-to-v3.0.1
  > 2c10714 Update gopkg.in/yaml.v3 to v3.0.1
  > d50b1bc Merge pull request # 109293 from iamNoah1/improve-ingressclassname-api-doc
  > 832b1f4 Merge pull request # 109938 from dims/move-from-k8s.gcr.io-to-registry.k8s.io
  > bba462c generate ressources after change request
  > ed22bb3 Move from k8s.gcr.io to registry.k8s.io
  > d1f2717 add change requests
  > be84346 Merge pull request # 109968 from kerthcet/feature/optimize-apifield-comment
  > e85f85a generate ressources after change request
  > 209903b amend comment of NodeInclusionPolicy
  > bac3ee2 add change requests
  > ae35a85 Merge pull request # 108492 from kerthcet/feature/add-NodeInclustionPolicies
  > a3f4ca9 generate ressources after change request
  > 202371b feat: add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
  > 4e39c88 add change requests
  > 9b88471 Merge pull request # 109891 from pohly/log-dependency-update
  > af2d87a add generated assets
  > 548c53c Merge pull request # 109602 from lavalamp/remove-clustername
  > 0f669be dependencies: logr and zapr v1.2.3
  > 4b894ff first shot improving api doc for ingressclassname
  > 5e2f5ad Merge pull request # 109308 from danwinship/traffic-policy-docs
  > eb567e7 compat
  > a2ee8c7 Merge pull request # 109803 from liggitt/api-fixture-data
  > 85c4c9d Clarify ExternalTrafficPolicy/InternalTrafficPolicy definitions
  > fcb6509 Merge pull request # 109440 from liggitt/gomod-1.18
  > 1afa1ae Remove v1.22.0 API fixture data
  > 3f52c1d Regenerate vendor
  > a2ae4d4 Add v1.24.0 fixture data
  > d672b36 Merge pull request # 109506 from wangrzneu/fix-comment
  > f2f8c15 Merge pull request # 109421 from vpnachev/fix/typo-in-token-request-doc-string
  > 35e4518 fix IngressClassParametersReferenceScopeCluster comment in staging/src/k8s.io/api/networking
  > af4f75e Merge pull request # 105963 from zhucan/bugfix-95367
  > aed3ebb Fix typo in TokenRequest doc string
  > 7a89730 Merge pull request # 109436 from JamesLaverack/revert-108290
  > 56fb9f0 generated code and doc
  > 1f82dd7 Revert "Introduce APIs to support multiple ClusterCIDRs (# 108290)"
  > 6f81c7b csi: add nodeExpandSecret support for CSI client
bumping knative.dev/eventing d1827fc...56e9ee1:
  > 56e9ee1 update exact/prefix/suffix filters to accept multiple entries (# 6551)
bumping knative.dev/pkg fb2e4fb...8178c38:
  > 8178c38 update k8s to 1.25.2 (# 2599)
bumping k8s.io/apimachinery 97e5df2...478dd6e:
  > 478dd6e Merge pull request # 112527 from liggitt/automated-cherry-pick-of-# 112526-upstream-release-1.25
  > 14bc1be Limit redirect proxy handling to redirected responses
  > 8252641 Merge pull request # 112330 from enj/automated-cherry-pick-of-# 112193-upstream-release-1.25
  > 10b456c Merge pull request # 112161 from pohly/automated-cherry-pick-of-# 112129-origin-release-1.25
  > 4759a80 Add an option for aggregator
  > 3296217 dependencies: update to ginkgo v2.1.6 and gomega v1.20.1
  > 117bd9b Merge pull request # 111113 from mimowo/retriable-pod-failures-job-controller
  > 74deb3d Merge pull request # 111696 from liggitt/go119mod
  > dbffa07 Support handling of pod failures with respect to the specified rules
  > fef5499 Update go.mod to go1.19
  > 41606c6 Merge pull request # 111677 from dims/stop-panic-in-govet-levee
  > 6627090 run lint-dependencies and follow directions
  > addc01f Stop panic in govet-levee CI job
  > f15b816 Merge pull request # 110495 from alexzielenski/atomic-objectreference
  > e68cae5 update kube-openapi
  > b541046 Merge pull request # 111557 from alexzielenski/update-smd-422
  > ace683f update smd to 4.2.3
  > 899984f Merge pull request # 111587 from ialidzhikov/k8s-utils@ee6ede2d64ed
  > c77a8ed Update `k8s.io/utils` to `ee6ede2d64ed`
  > 954536d Merge pull request # 111450 from HecarimV/fix-22072710
  > d58901c Merge pull request # 111454 from HecarimV/fix-log-capitalized
  > a9b0d05 cleanup: omit redundant arguments in make call
  > 8b07078 Merge pull request # 111496 from HecarimV/unnecessary-fmt
  > 1be2ea2 cleanup: fix some error log capitalization
  > 3bab4b1 Remove unnecessary use of fmt.Sprintf
  > 47ba8cb Merge pull request # 111442 from ialidzhikov/k8s-utils@56c0de1e6f5e
  > 0a1c3aa Update `k8s.io/utils` to `9bab9ef40391`
  > 7fb0342 Merge pull request # 111254 from dims/update-to-golang-1.19-rc2
  > 9652184 Merge pull request # 106388 from alexzielenski/ssa-ignore-nonsemantic-changes
  > fdf7942 Generate and format files
  > 915d89a Merge pull request # 111173 from BinacsLee/binacs/regenerate-sets
  > 65bf58a optimize nil and empty also for slices
  > 0661104 Merge pull request # 110178 from kevindelgado/validation-beta-1-25
  > fb683c6 Re-Generate k8s.io/apimachinery/pkg/util/sets
  > 6586a12 optimize nil and empty case for parity with other branch
  > 5d375c1 update kjson
  > 019f1e1 revert timestamp updates to object if non-managed fields do not change
  > cff14a5 Merge pull request # 111081 from HecarimV/fix-22071210
  > afc5e00 Merge pull request # 111008 from cici37/bumpCEL
  > 6f7b214 Fix: some typo in apimachinery/pkg
  > 51e28bc Merge pull request # 111097 from saltbo/fix-thethe-typo
  > cd7836f Bump cel-go to v0.12.0
  > 5074e27 fix: update the typo code comment
  > 0897ed8 Merge pull request # 108532 from cbandy/status-cause
  > 9cb1f71 Merge pull request # 110916 from zhoumingcheng/master-code-v1
  > 9291eff api/errors: Improve performance of Is* functions
  > 4afd3f4 Merge pull request # 109111 from chendave/ginkgo_upstream
  > 8c521e1 Fix a typo
  > 1eec2ee Use errors.As to detect wrapping in StatusCause
  > c87322d update ginkgo from v1 to v2 and gomega to 1.19.0
  > 2496976 Merge pull request # 111001 from pohly/klog-update
  > d40a017 build: update to klog v2.70.1
  > a869692 Merge pull request # 110831 from chendave/openapi
  > e4283bb Bump `kube-openapi` to the latest
  > 66bbc50 Merge pull request # 110788 from 21kyu/change_reflect_ptr
  > 55378ba Change reflect.Ptr to reflect.Pointer
  > e74e8a9 Merge pull request # 110724 from pohly/klog-update
  > 21dbaf7 build: update to klog v2.70.0
  > eda93e0 Merge pull request # 110448 from twilight0620/test0608
  > c5be385 Merge pull request # 110378 from lucacome/bump-grpc
  > 6243438 add some uts of group_version.go
  > bae69c6 Bump grpc to v1.47.0
  > b90ea24 Merge pull request # 110520 from dims/update-gopkg.in/yaml.v3-to-v3.0.1
  > 1831736 Update gopkg.in/yaml.v3 to v3.0.1
  > d407afb Merge pull request # 110351 from dims/switch-to-v3-of-github.com/emicklei/go-restful
  > 5e1e879 Switch to v3 of github.com/emicklei/go-restful
  > be3a79b Merge pull request # 109892 from jlsong01/add_annotation_comments
  > 5abf6e2 Merge pull request # 110207 from wojtek-t/clean_shutdown_managers
  > 21bf400 clarify a comment on annotation key validation
  > be75d4d Make contextForChannel public
  > e3c6631 Merge pull request # 110079 from ash2k/dial-with-context
  > e929c35 Always dial using a context
  > e572490 Merge pull request # 109752 from MadhavJivrajani/remove-apimachinery-clocks
  > e11374f Merge pull request # 110040 from astoycos/fix-panic
  > 5526e82 apimachinery/clock: Delete the clock package
  > ca5c89b Merge pull request # 110029 from ash2k/ash2k/no-double-tls-validation
  > 7c09d67 Fix additional panic
  > 4f2ae94 tls.Dial() validates hostname, no need to do that manually
  > ec91382 Write Unit test to imitate Panic
  > 28c7554 Merge pull request # 109651 from ash2k/ash2k/spdy-cleanup
  > f3b1305 Merge pull request # 108080 from astoycos/issue-132
  > 284911f Pass context for TLS dial
  > 1c398d5 Merge pull request # 107213 from mk46/portname_validation
  > 912a38b Fix Panic Condition
  > f1ceaed Don't clone headers twice
  > 4778951 Merge pull request # 109891 from pohly/log-dependency-update
  > b243f86 Fixed portName validation error message.
  > b85d889 Merge pull request # 109602 from lavalamp/remove-clustername
  > 1c1f82a dependencies: logr and zapr v1.2.3
  > 0ac710b generated files
  > 430b920 Remove ClusterName
  > 5f6d692 Merge pull request # 109804 from cici37/celUpdate
  > a5de00b Merge pull request # 109750 from aojea/spdy_tls
  > b6901b9 Update go-control-plane, cncf/xds/go, cncf/udpa/go and remove unused versions
  > b042ede Merge pull request # 109440 from liggitt/gomod-1.18
  > e57894b spdyroundtripper: d tlson't verify hostname twice
  > 535f064 Update GRPC
  > 92ee148 Regenerate vendor
  > 1564fe5 spdyroundrippter: close the connection if tls handshake fails
  > 5ac2923 Update genproto and antlr.
  > f71cc27 Merge pull request # 109259 from roycaihw/tweak-quantity-docs
  > 54c2bc0 Bump cel-go to v0.11.2
  > 080c0c7 Merge pull request # 109212 from alexzielenski/copylock-fix
  > af9793b Generated files
  > cf0bfa9 Tweak Quantity docstring for ease of reference generation
bumping k8s.io/client-go 3e73df6...593f096:
  > 593f096 Update dependencies to v0.25.2 tag
  > 1904631 Merge pull request # 112161 from pohly/automated-cherry-pick-of-# 112129-origin-release-1.25
  > 8f4eb75 Merge pull request # 112336 from enj/automated-cherry-pick-of-# 112017-upstream-release-1.25
  > e278668 dependencies: update to ginkgo v2.1.6 and gomega v1.20.1
  > 1874bc6 exec auth: support TLS config caching
  > db7e2d8 Merge pull request # 112055 from aanm/automated-cherry-pick-of-# 111752-origin-gh-aanm-release-1.25
  > c9008f3 client-go/rest: check if url is nil to prevent nil pointer dereference
  > 1a46dfd Revert "client-go: remove no longer used finalURLTemplate"
  > b3e4a40 Merge remote-tracking branch 'origin/master' into release-1.25
  > c2f61ae Update removal warnings to 1.26
  > 54e42ab update-gofmt
  > ef26118 Revert "Remove gcp and azure auth plugins"
  > a890e7b Merge pull request # 109090 from sarveshr7/multicidr-rangeallocator
  > f10f16e Merge pull request # 111113 from mimowo/retriable-pod-failures-job-controller
  > 76884cd Auto generate code for ClusterCIDR API
  > 3300752 Merge pull request # 111696 from liggitt/go119mod
  > c439b25 Support handling of pod failures with respect to the specified rules
  > ce9ac37 Merge pull request # 108692 from jsafrane/selinux
  > 4100519 Update go.mod to go1.19
  > a00e9ab Regenerate files
  > 55b6f70 Merge pull request # 111677 from dims/stop-panic-in-govet-levee
  > 606e4a8 run lint-dependencies and follow directions
  > fe9020e Stop panic in govet-levee CI job
  > e803ec6 Merge pull request # 110495 from alexzielenski/atomic-objectreference
  > 07171f8 Merge pull request # 111090 from kinvolk/rata/userns-support-2022
  > b5feb25 mark persistentvolume's claimRef as granular
  > bebf219 Update kubectl kustomize to kyaml/v0.13.9, cmd/config/v0.10.9, api/v0.12.1, kustomize/v4.5.7 (# 111606)
  > 912b04a Update autogenerated files
  > c5a511a update kube-openapi
  > 68639ba Merge pull request # 111557 from alexzielenski/update-smd-422
  > 828c3cb pkg/apis, staging: add HostUsers to pod spec
  > b0d4101 Merge pull request # 111475 from alculquicondor/clear_pod_disruption
  > 1631be4 update smd to 4.2.3
  > 3dfaef5 Add clock interface to disruption controller
  > 3e9c4b4 Merge pull request # 111587 from ialidzhikov/k8s-utils@ee6ede2d64ed
  > 2037cc6 Update `k8s.io/utils` to `ee6ede2d64ed`
  > 07735ea Merge pull request # 111441 from denkensk/respect-topology
  > 95367f2 Merge pull request # 110851 from negz/more-like-mac-slow-s
  > 2190b2f code generated by script for MatchLabelKeys in TopologySpreadConstraint
  > ec0f337 Merge pull request # 111387 from marseel/feature/retry_internal_errors
  > 761f55c Use SHA256 sums to verify discovery cache integrity
  > c2d2c47 Merge pull request # 111228 from Abirdcfly/220716
  > ff6bf67 Add option to retry internal api error in reflector.
  > 735524f Use sha256 to sanitize discovery HTTP cache keys
  > fe12e65 Merge pull request # 111442 from ialidzhikov/k8s-utils@56c0de1e6f5e
  > 65b1e7d clean Unreachable code
  > 1ea239f Use checksums instead of fsyncs to manage discovery cache corruption
  > 7a55c3b Update `k8s.io/utils` to `9bab9ef40391`
  > 76fccca Add a benchmark for the discovery cache RoundTripper
  > cc879cd Merge pull request # 111254 from dims/update-to-golang-1.19-rc2
  > b5c7588 Merge pull request # 109141 from ulucinar/bump-discovery-burst
  > 2a6c116 Generate and format files
  > b2097e6 Merge pull request # 110666 from ldsdsy/modify
  > 4aac6a7 Bump discovery burst of default ConfigFlags to 300
  > 4db4856 Merge pull request # 111242 from wojtek-t/fix_leaking_goroutines_11
  > 123d4e7 Fix a typo
  > ed7d154 Bump default burst limit for discovery client to 300
  > 95a40e2 Merge pull request # 110178 from kevindelgado/validation-beta-1-25
  > 9dde02d Clean shutdown of client integration tests
  > 267b657 Merge pull request # 111235 from Abirdcfly/220719
  > b4c3510 update kjson
  > 0cfc963 Merge pull request # 110649 from harshanarayana/fix/GIT-110335-fix-fake-event-expansion
  > ca60e0e fix a possible panic because of taking the address of nil
  > c6bd30b Merge pull request # 111176 from p0lyn0mial/upstream-cacher-refactor-for-streaming
  > e2ef408 GIT-110335: address namespace defaulting for events
  > 441e2c8 reflector: simplify reading the resourceVersion
  > 04f67d5 reflector: move LIST to its own method
  > 4e28921 reflector: refactor watchHandler
  > 163ee0b Merge pull request # 111080 from zhoumingcheng/master-v3
  > 743e29d Merge pull request # 111008 from cici37/bumpCEL
  > 84e1219 Correct some wrong syntax
  > 79a582f Merge pull request # 111097 from saltbo/fix-thethe-typo
  > 7f7dbbc Bump cel-go to v0.12.0
  > eabd428 Merge pull request # 111002 from HecarimV/fix-220707
  > 7c3fa18 fix: update the typo code comment
  > 59fda2e Merge pull request # 111087 from HecarimV/fix-22071205
  > f295032 fix static-check for staging/src/k8s.io/client-go/
  > 2f582c2 Fix:import the same package multiple times
  > 3b969f9 Merge pull request # 111001 from pohly/klog-update
  > 26b5064 build: update to klog v2.70.1
  > 506ef89 Merge pull request # 110990 from thockin/svc-typenames-IPFamilyPolicyType
  > 61a7d9d Rename IPFamilyPolicyType => IPFamilyPolicy
  > a16e76e Merge pull request # 110831 from chendave/openapi
  > 6a58c3a Bump `kube-openapi` to the latest
  > f5b6af4 Merge pull request # 110788 from 21kyu/change_reflect_ptr
  > 1b23c15 Change reflect.Ptr to reflect.Pointer
  > 8dfe88a Merge pull request # 110724 from pohly/klog-update
  > 899bcd7 Merge pull request # 110425 from LY-today/fake-evict-list-err
  > cb4a10d build: update to klog v2.70.0
  > 0647d43 Merge pull request # 109632 from weilaaa/recorrect_byindex_input_param
  > 9ac8bfe fix: list pod err after an pod evicted
  > acab036 Merge pull request # 110436 from nicks/nicks/issue-1108
  > 64585cf correct input params and add godoc
  > 830d4c4 Merge pull request # 110378 from lucacome/bump-grpc
  > 5ce7078 client-go: fix panic in ConfirmUsable validation
  > e0fa504 Bump grpc to v1.47.0
  > 2a9f955 Merge pull request # 110518 from dims/switch-to-released-version-of-v3.8.0-github.com/emicklei/go-restful/v3
  > d4fc9af Merge pull request # 110520 from dims/update-gopkg.in/yaml.v3-to-v3.0.1
  > 7e1edab Switch to released version of v3.8.0 - github.com/emicklei/go-restful/v3
  > 08b4bbc Update gopkg.in/yaml.v3 to v3.0.1
  > 87a5b7b Merge pull request # 110351 from dims/switch-to-v3-of-github.com/emicklei/go-restful
  > cf0ba13 Switch to v3 of github.com/emicklei/go-restful
  > f88de91 Merge pull request # 96771 from soltysh/shortcut_expander
  > e2598a4 restmapper: re-try shortcut expander after not-found error
  > cf13620 Merge pull request # 84145 from bells17/fix-typo
  > 33115b4 Merge pull request # 110100 from tkashem/client-go-backoff-fix
  > 21f4308 Fix typo: type -> eventtype
  > 0bc005e Merge pull request # 110076 from karlkfi/patch-1
  > 71b8c17 client-go: fix backoff delay
  > 8764064 fix: reflector to return wrapped list errors
  > ef63e49 Merge pull request # 110013 from enj/enj/i/remove_azure_gcp_auth_plugins
  > 1f7dc88 Remove gcp and azure auth plugins
  > 77f6364 Merge pull request # 108080 from astoycos/issue-132
  > b4b8e5e Merge pull request # 108492 from kerthcet/feature/add-NodeInclustionPolicies
  > f19a514 Fix Panic Condition
  > 5bb1a76 feat: add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec
  > 2420926 Merge pull request # 109891 from pohly/log-dependency-update
  > 7c5b742 Merge pull request # 109602 from lavalamp/remove-clustername
  > c301d44 dependencies: logr and zapr v1.2.3
  > 5a9c3ac generated files
  > c0ab12a Merge pull request # 109804 from cici37/celUpdate
  > bb66d80 Merge pull request # 109607 from liggitt/drop-unused-third-party
  > 631da0c Update go-control-plane, cncf/xds/go, cncf/udpa/go and remove unused versions
  > f4c553f Merge pull request # 109440 from liggitt/gomod-1.18
  > 7481505 Remove package variables
  > 28feddd Update GRPC
  > ccff963 Regenerate vendor
  > 28c4a4d Drop unused golang/template funcs
  > a8fbc49 Update genproto and antlr.
  > 671a40c Merge pull request # 109520 from cncal/lcn_cleanup_duplicate_code_snippet
  > ac3e4ba Bump cel-go to v0.11.2
  > 211d8a7 Merge pull request # 109443 from kevindelgado/dynamic-apply
  > 152e68f Remove the duplicate code snippet in client-go delaying_queue tests
  > 2cf1a8f Merge pull request # 105963 from zhucan/bugfix-95367
  > 4eab6be Add Apply and ApplyStatus methods to dynamic ResourceInterface
  > 28ccde7 Merge pull request # 109436 from JamesLaverack/revert-108290
  > 1f8debf generated code and doc
  > f9fdccd Revert "Introduce APIs to support multiple ClusterCIDRs (# 108290)"

/retest

@ricardozanini are you looking at fixing the build? You need to manually update the dependencies as there are breaking changes. Please look at this one as a example as what has been done: https://github.com/knative-sandbox/eventing-kafka/pull/1252

@ricardozanini are you looking at fixing the build? You need to manually update the dependencies as there are breaking changes. Please look at this one as a example as what has been done: knative-sandbox/eventing-kafka#1252

yes, it's on my plate. I'll do it on Monday.

/close


Update drop-trigger.md

Replace:

drop policy by drop trigger

From postgres doc

Nice catch! Thank you!


PLT-456: Propagate SrcSpans to UPLC

plc can now compile into CompiledCodeDebug. Also added compileDebug.
One bit of concern is that, as seen in the plc.golden files, -g gives us some SrcSpans, but many are still missing. Also for some reason the same Term gets overlapping SrcSpans (which I guess we can simply merge).

@michaelpj As you suggested, I removed CompiledCodeDebug, and use SrcSpans for annotation directly in CompiledCode.
Also:

Removed the Flat (CompiledCodeIn uni fun ann a) instance. It is not actually used anywhere, except in BasicValidators.hs under doc.
serialiseCompiledCode discards the annotations.
One thing slightly awkward is applyCode. It's not totally clear how to handle the annotations.

We will also most likely need to implement some heuristics to post-process the SrcSpans, because as it stands, some CoreExprs have no SrcSpan while some others have multiple. GHC's backend itself uses some heuristics (ref1, ref2). Another option is to implement another plugin to capture the SrcSpans from the parser. Either way, that's an orthogonal problem and will be tackled separately.

... with what goal? I'm not sure what you're trying to achieve.

Ideally we want each CoreExpr to have a single SrcSpan (or multiple non-overlapping ones with CSE), so that we can show source locations while stepping through Plutus Core. But that's not the case. So the heuristics could be something like

If a Lam does not have SrcSpan but its body does, use the body's.
If a CoreExpr have multiple SrcSpans, discard the ones that contain other SrcSpans.

Okay, that makes sense. Can be a Note.
Probably should discuss this elsewhere, but just dumping some thoughts. We have two problems:

Nodes missing srcspans
Nodes with multiple srcspans (not sure how often this happens?)

For 1 I would have thought we could just use the nearest enclosing srcspan in most cases? Unclear whether we want to support missing srcspans in the evaluator or whether we want to insist that we're given a program that has them everywhere.
For 2 I think your idea of discarding subsumed srcspans makes sense (although maybe the more precise one is better? unclear). I wonder how often this happens in practice, or whether we can get multiple locations where neither subsumes the other. Again, maybe we want to support multiple scrspans in the evaluator for generality, and then we can try and tidy them up beforehand. Or we could insist on exactly one.


Some tests don't run on Windows

This is more of a problem for contributors than users, but some tests don't run on Windows. For example, test/functional/index.js assumes it will be able to use lsof, which has no Windows equivalent:
exec('lsof -p ' + Number(server.pid), function(err, result) {

I'm not sure how to make it more multiplatform. I use both OS X and Windows platforms, so it's a partial problem for me.

I haven't found a replacement for lsof in windows, maybe a person with more experience on Windows can help here.

I don't think you will find a replacement. It would require operating system level support which Windows just does not make available. I think this is insurmountable.
Are any tests still failing because of this? If so, those tests need changing so that they are skipped on Windows. It's not ideal, but then neither is writing tests that use functionality beyond what is universally available.

The list of unit test affected are around 120 of 191. It's a big amount. I could skip them somehow, but still the windows platform will remain untested. Let's see if someone comes up with a solution/suggestion about this.

related https://github.com/fbsamples/f8app/issues/147#issuecomment-281972807 a hint to fix it on Windows

Future contributors with Windows machines won't be able to run the test, but, the whole testing architecture was created thinking on UNIX and the CI runs on UNIX machines anyway and is not optimal. I'll close this one due to inactivity and pretty likely there is no a solution unless rewriting the whole thing.

The future big release will fix this issue, no lsof needs it to run the test.


Expose Control::_get_drag_data() as non-const function

The documentation states that we could call Control::set_drag_preview() from inside Control::_get_drag_data().
https://docs.godotengine.org/en/latest/classes/class_control.html#class-control-method-get-drag-data
The function Control::_get_drag_data() is actually a non-const function
https://github.com/godotengine/godot/blob/f581f21dd61a8fb581b80d07755cdf60c95d146d/scene/gui/control.h#L511
..whereas it's been (wrongly) exposed as a const function here:
https://github.com/godotengine/godot/blob/f581f21dd61a8fb581b80d07755cdf60c95d146d/scene/gui/control.h#L352
GDVIRTUAL1RC should be changed to GDVIRTUAL1R to match the signature.
This fix would allow GDExtension to set drag preview.

You also need to run doctool.

@KoBeWi Thanks for the follow-up, I ran the doctool.
I discarded irrelevant documantation diffs which came from Multiplayer stuff.


Test against other implementations

Description of feature
E.g. Finch.jl

@BenBrock, IIRC you had set up a test suite for your implementations based on the SuiteSparse collection, right?
Could you point me towards where you run these tests? And are you hosting converted copies of this data somewhere?

Sorry for the late reply---this slipped through my inbox.
The testing infrastructure is still very much a work-in-progress.  The best thing I have at the moment is this GoogleTest infrastructure for the C++ bindings that reads in Matrix Market files, writes them as binsparse, reads them in again, and then checks for binary equivalence.


Use config.json in llama

Similar to #157, #158

Sorry, I just merged #145 which moves some stuff around so you'll need to rebase. Shouldn't be any conflict.


[Trufflehog Update] Add Trufflehog secret scanning workflow

Description
The GitGuardian secret scanning tool licence is now expired, therefore in order to maintain the Security of the Tractus-X Repositories there will be inforced the TRG-8.03 for all Tractus-X repos.
Incident Ticket
https://github.com/eclipse-tractusx/sig-security/issues/86
Your repository was found in one of our security scans, and it was listed along with other repositories for not contain any of this files:
".github/workflows/trufflehog.yaml"
".github/workflows/trufflehog.yml"
".github/workflows/secrets-scan.yml"

Please read the TRG-8.03 and create the workflow file as soon as posible!
What needs to be done?

[ ] Add the Trufflehog workflow like described in TRG-8.03 to the /.github/workflows folder
[ ] Remove all references to GitGuardian from documentation
[ ] Create a PR and Merge it to main
[ ] As committer: revise if any secrets were found in the scan (in the security tab)
[ ] Close this ticket

Thank you very much for doing the update! 🚀
If there is any question, please let us know,
Your Tractus-X Project Leads 💯

Hi @matbmoser , this repository is a template to be used by someone outside to build EDC extensions. Nothing is built out of this. Does it make sense to run TruffleHog in this repo? If not, how can it be excluded? Thanks!

Fair point, it can be also excluded :)


Enable Pulsar CI

Don't Merge this PR
This PR is intended as a way to test how symbols-view handles testing with Pulsar.
The CI on the Pulsar repo, which installs Atoms symbols-view repo, has 2 failing tests.
But local CI, and attempting to bundle this repo produces over 20. So lets see what it does here

This repo has been merged into Pulsar, and is now being archived.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Added a check for user must start with a letter
note: github has timeout issues ...
Fixes #1

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

Well, comething seems to not work despite following the directions.


Instructions for installing CLIP

If you don't want to install clip from the repository another option is:
pip install clip-anytorch
I just tried and can confirm it's working.


[BUG] Unable to connect to txAdmin. If you closed it, please start again and retry.

Unable to connect to txAdmin.
If you closed it, please start again and retry.
i from China i try use VPN But it doesn’t seem to work

For support please go to discord.gg/txAdmin

Hello 我遇到了相同的问题 请问你是否解决了它


Fix for #854

The bug was introduced in e2234497b79603388b58ba226abb157aa4aaf065

Pretty basic. Merging.

Just tested it after a go get -u github.com/mholt/caddy and it now works as expected!
Thank you!
Now it would be good if the Docker images updated with the fix. ;)

@mholt any release in sights ?
It'll make it to the docker image after the next release.

Seeing the fix, I think I might have caused this when I fixed a different bug in proxy related to headers.
So, thanks for finding this and making it right. :smile:
The next release is slated for Caddy 0.9, I'm working vigorously to get the beta versions out as soon as possible!

I was wondering if a test could be made for this?
Or is it too complex to run  another server to catch Host: in a test?

A test can definitely be written for this. It's on my list but I'd be happy to accept PRs on that!

I don't quite understand how testing works in Caddy.
On Tue, May 31, 2016, 7:19 PM Kai Hendry<EMAIL_ADDRESS>wrote:

I don't quite understand how testing works in Caddy. You recurse through
directories running go test?
http://s.natalian.org/2016-06-01/1464743896_2548x1380.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mholt/caddy/pull/855#issuecomment-222867423, or mute
the thread
https://github.com/notifications/unsubscribe/ABE5kdxOdZBe7XlE3mwkpBnTnG5TsDyeks5qHN4WgaJpZM4IpOtH
.

Cool. Didn't know about that syntax.
http://s.natalian.org/2016-06-01/1464745956_2548x1380.png


MultiStreamRecorder video/audio durations different/inconsistent

$ ffprobe -i ./some.webm  -show_entries format=duration -v quiet -of csv="p=0"
3.003000
$ ffprobe -i ./some.wav  -show_entries format=duration -v quiet -of csv="p=0"
2.986667
Slightly out of sync.
Any thoughts on how to align with ffmpeg?
May relate to #26
Cheers

I found the same problem. I'm recording 20s chunk and on the ondataavailable event I'm uploading the chunks on a node server to merge and encode a final webm video via ffmpeg. I'm passing a bufferSize of 16384 to MultiStreamRecorder. I've noticed that audio and video have different durations (in the order of 300-500ms) and seem to be out of sync more and more with the increasing of the overall recording.
Is it only related to the large bufferSize or is there something wrong in the code of the recorder?
Thanks a lot for your work and for your reply

Was this resolved? I seem to have this issue as well.

How are you merging files with ffmpeg? I can't even use ffmpeg as timing info is not added to webm files (using Chrome). I ended up using mkvmerge which concatenates the files but I'm also seeing sync issues between audio and video tracks.


Use pypechain's new deploy method

Use this instead of deploy_contract, which is now no longer used.  We can delete it or leave it since its still a utility that ethpy could provide.
I've also totally removed the dependency of abi_dir in eth_config throughout the repo... I think.  I'm not taking the final step of removing that either in this PR in case there is some use case I don't know about.

I'm fine with removing abi_dir completely. I agree that deploy_contract could have some use as an ethpy util, but only if we have good tests around it so it doesn't rot.

some more instances of ABI:

ABI_DIR is an env variable in eth.env.sample


Make sure VMs run on lang=en_US.UTF-8

I used a german debian12 to run on my mac UTM/qemu and ran the install script on. Some scripts have problems with the german lang - it should make sure (tested or set) that it is english during install script.
cat /etc/default/locale 2>/dev/null | grep -c "LANG=en_US.UTF-8"

On RaspberryPi its has:
admin@<IP_ADDRESS>:~ ₿ cat /etc/default/locale
#  File generated by update-locale
LANG=en_GB.UTF-8

Final testing with PR #4770


Allow user to set logging level?

https://github.com/gammasim/gammasim-tools/blob/e5105c0b31b8365647252c44642a7783ac203cb5/applications/derive_mirror_rnda.py#L25
I have a small piece of code that allows users to set the logging level (see below, ignore the color logger calls). If you approve of it, I will add something similar to the general utils.
def getLogLevelFromUser(self, logLevel):

        possibleLevels = {'info': logging.INFO,
                          'debug': logging.DEBUG,
                          'warn': logging.WARNING,
                          'warning': logging.WARNING,
                          'error': logging.ERROR,
                          'critical': logging.CRITICAL}
        logLevelLower = logLevel.lower()
        if logLevelLower not in possibleLevels:
            self.logStdout.error([['wb', 'Requested log level,'],
                                  ['r', logLevel],
                                  ['wb', ', is not known. Using INFO level instead.']])
        else:
            return possibleLevels[logLevelLower]

Not sure if we will add the colour logger itself to the code. I really like it and I think it helps the clarity of the output a lot, but it requires a little bit of learning how to use it, defining colour standards and adds an additional level of complexity. In my opinion it is worth it, but I won't force it in any way.

Sounds good, but I can't understand how it works. You could implement it in util.general and I can have a look at an example.
I don't think the coloured logger is necessary. The std logging works so well and it's so simple.

OK, I will assign myself and implement it when I get a chance. It's very simple anyway.

@RaulRPrado Can you please check out 5097b36 and tell me if this resolves this issue and I can do a PR?

Looks good! I left few comments there.

OK, I made the pull request, but I will leave this issue open until we fix all other loggers in the code (I can do it, no problem).

Ok, great.
It's better to create a new issue for the logger in other classes and close this one.

Are issues attached to classes? I didn't know that. I simply use it as a reminder to do it =)

No no. I didn't mean that.
I meant to create another issue for fixing the other classes instead of using this one.

Oh, OK, sure. I will close this and open a new one.


changes required for DS integration

What does this PR do?

Changes to be made for integrating accelerate in Transformers

@pacman100, we're seeing DS integration tests failing after this commit :(
https://github.com/microsoft/DeepSpeed/actions/runs/4941257007/jobs/8833704256?pr=3505

Hello @jeffra, Thank you for the quick notification. PR #1411 should resolve this.


[Don't merge] Debug pytest update bugs

Logs are not sufficient for the failing job Run XVR_JavaUsingPython_Dataflow PostCommit when pytest is updated.

Serialize and deserialize the object and see which one is causing the error and why.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


how to query mongoose with multiple query params ?

Here is my mongo object :
[ {},{}
{
"_id" : ObjectId("588aa3ab9045439fdf1bb280"),
"Bi_Weekly_P" : false,
"Continue_P" : false,
"CounterOffer" : "default",
"Counter_P" : false,
"DOM" : "default",
"Grey_P" : false,
"Later_P" : false,
"Later_Today_P" : false,
"Left_VM_P" : true,
"dateAdded" : "default",
"next_call_Date" : ISODate("2017-01-27T02:14:48.393Z"),
"__v" : 1
}
]
I want to query for objects that has "Left_VM_P" : true,  as true.
from angular this is how i call it.
var Priority = 'Left_VM_P';    (  this priority can be chnaged as per user selection )
url = currentUrl+"/api/prioritySearch/"+Priority;
exports.prioritySearch = function(req, res, next, id) {
// below query works
// Property.find({ Left_VM_P : 'true' }).exec(function(err, properties) {
// but i want below query to work coz i want to change the id parameter so I can modify each time what key is searched for
Property.find({id : 'true' }).exec(function(err, properties) {
Here's the log on terminal on server side.
value of  id =  Left_VM_P
req.params  =  { Left_VM_P: 'Left_VM_P' }
Your help will be greatly appreciated.

@jpca999 this is really not meanjs specific. You are crossing the line -- and you know it.

I agree that this isn't MEANJS specific. Closing.
@jpca999 If you have a more focused issue, and it's relevant to this project, then feel free to re-organize your question & re-open.
Look into dynamically generating your query object that is passed into your mongoose Model's find() method. This can be done with a simple switch statement.


DNS TXT record

The readme suggests conversion of the PEM to remove the comments and new line characters however the javascript sample app doesn't recognize this format and the current text record for keys.pathcheck.org doesn't either:
"-----BEGIN PUBLIC KEY-----\nMFYwEAYHKoZIzj0CAQYFK4EEAAoDQgAE6DeIun4EgMBLUmbtjQw7DilMJ82YIvOR\n2jz/IK0R/F7/zXY1z+gqvFXfDcJqR5clbAYlO9lHmvb4lsPLZHjugQ==\n-----END PUBLIC KEY-----\n"

Hi Denis,
Yes, we made the change on the protocol and the demo app did not follow. We are currently finishing this adjustment on the demo codebase.

I also quickly updated the Javascript, Ruby, Python, Java and Sell Script demos. You can test with pcf.vitorpamplona.com while keys.pathcheck.org doesn't update.

keys.pathcheck.org has been updated as well.

Thanks, though it looks like you're still not including the specified \n in keys.pathcheck.com and pcf.vitorpamplona.com

Hum.. which one are you referring to? The only \n that should be converted is the one in the middle of the public key. It should be turned into a \\n. You can see it down below.
MFYwEAYHKoZIzj0CAQYFK4EEAAoDQgAE6DeIun4EgMBLUmbtjQw7DilMJ82YIvOR\\n2jz/IK0R/F7/zXY1z+gqvFXfDcJqR5clbAYlO9lHmvb4lsPLZHjugQ==

Hi Vitor,
Sorry, I should have written \n.  For keys.pathcheck.org I'm seeing
MFYwEAYHKoZIzj0CAQYFK4EEAAoDQgAE6DeIun4EgMBLUmbtjQw7DilMJ82YIvOR\n2jz/IK0R/F7/zXY1z+gqvFXfDcJqR5clbAYlO9lHmvb4lsPLZHjugQ==
when using nslookup and when using https://mxtoolbox.com/SuperTool.aspx?action=txt%3Akeys.pathcheck.org&run=toolpage but when using the google https://dns.google/resolve?name=KEYS.PATHCHECK.ORG&type=TXT
MFYwEAYHKoZIzj0CAQYFK4EEAAoDQgAE6DeIun4EgMBLUmbtjQw7DilMJ82YIvOR\\n2jz/IK0R/F7/zXY1z+gqvFXfDcJqR5clbAYlO9lHmvb4lsPLZHjugQ==
So I'm unclear as to whether I specifically need to replace "\n" with "\n" as specified in my txt record or not

Some DNS Lookup tools already convert the \n to \n for you. It depends on the lib you use. If they do, then you should not need to convert yourself.


Try to guide noobs to a complete example of loading with skrifa

Make https://docs.rs/skrifa/0.0.1/skrifa/ and https://crates.io/crates/skrifa guide a new user to an example sufficient to Do Something. It would be nice if we had an example pen we could reference, it's quite noisy to put one directly in the example  but without one it doesn't do anything.

An end to end example is a great idea, but I think it'd be more useful to have one (or more) in an examples directory under the skrifa crate. We'd have more space for useful comments and the code would actually be runnable so that users can play with it.
Per IM, we should link directly to the examples dir from the docs.


"Root port reset failed" on slow starting USB device (IDFGH-11253)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.1.1
Espressif SoC revision.
ESP32-S3 (revision v0.2)
Operating System used.
macOS
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-S3-devkitc
Power Supply used.
USB
What is the expected behavior?
I'm trying to connect to an ATMEGA32U4 based USB device (to which I don't have the firmware sources) via the S3's USB host mode. The USB device itself has two modes, let's call them bootloader and application. If I force the device to enter the bootloader mode, it enumerates on the S3 just fine. If I let it boot it's application mode (the one I'm interested in talking to), all I get on the S3 is HUB: Root port reset failed.
What is the actual behavior?
I looked at the D+/D- lines with an oscilloscope and noticed a timing difference between the two modes when I hook it up to a PC. In bootloader mode, the device starts talking to the host immediately, i.e. after a couple of milliseconds. In application mode, it takes the device approximately 3 seconds to start talking. If I hook the device up to the S3, I see similar behaviour when in bootloader mode, but no bus activity at all when trying to start the application mode.
I tried increasing the configurable timeouts, i.e. CONFIG_USB_HOST_DEBOUNCE_DELAY_MS, CONFIG_USB_HOST_RESET_HOLD_MS and CONFIG_USB_HOST_RESET_RECOVERY_MS, but that does not seem to make any difference.
Steps to reproduce.
I've ordered an ATMEGA32U4 based board to hopefully produce a minimal test case that has the same behaviour as the closed source device to help debugging this issue.

Hello @Crazor

I tried increasing the configurable timeouts, i.e. CONFIG_USB_HOST_DEBOUNCE_DELAY_MS, CONFIG_USB_HOST_RESET_HOLD_MS and CONFIG_USB_HOST_RESET_RECOVERY_MS, but that does not seem to make any difference.

How much did you increase those timeouts? Did you try setting CONFIG_USB_HOST_DEBOUNCE_DELAY_MS > 3500 ?
This should give your device enough time to boot

Hi @tore-espressif
I did try to increase CONFIG_USB_HOST_DEBOUNCE_DELAY_MS to 5000, but it didn't work. I will try this again. Could you provide some pointers on what to watch out for with either the debugger or with a scope on the USB lines to make sure this is the correct "knob" to turn?

Hi everyone,
The main device logic part started after first device reset. So literally, if there is a chance to fix this with increasing the configurable timeouts, it will be either CONFIG_USB_HOST_RESET_RECOVERY_MS or CONFIG_USB_HOST_SET_ADDR_RECOVERY_MS.
But, if there is a chance to distinguish the specific moment, after which logic the delay is happened on the device it will help a lot.
Mainly, to answer the question "does that delay happened before USB setting the device address or after"?.

I don't think the bootloader is even using the USB port in any way, except when I set the boot jumper. With that kind of delay before the actual firmware connects, I would assume that I should see it appearing for a second or two under Windows, or hear the USB chimes showing connection-disconnection-connection sequence on normal boot. I think I need to test this under Linux and look at the syslog.
So far I don't have a good way to capture USB traffic in hardware. Wireshark should be no problem to set up. Is there a recommended setup for hardware capture on the line that does not break the bank? I suppose a Saleae is not fast enough, but I got to look into that.

@Crazor,
I see.
I though that the problem is when device changes the work mode from bootloader to application and both share USB.
Thus, the decreasing delays won’t help, obviously.
Yes, to start, Wireshark trace could help.
For both bootloader and application attach process.

@Crazor
But before, probably to increase the CONFIG_USB_HOST_RESET_RECOVERY_MS value is worth trying.
I am still not able to reproduce the problem quickly, but here is a timings diagram that can help to understand the delays and how they could affect the enumeration process. Increasing the CONFIG_USB_HOST_RESET_RECOVERY_MS doesn't affect the enumeration completion success, just increase the time of it. At least I have tried it with the value 5000.

And feel free to share the Wireshark tracelog, it may help us to move forward.

Hi @Crazor,
Is there any updates on the problem?

Haven't made an inch of progress so far, still working on it. Hopefully I can provide more detailed info on what's going on during next weekend.

Closing the issue as there not enough information to reproduce.
Please, feel free to reopen in case there will anything else.

I've had the same issue. After days looking for a solution.
I solved it link the pad USB- OTG.


Why - (BOOL)transactionWithBlock:(void(^)(void))block error:(NSError **)error do not work as I except?

Define my RLMObject:
@interface YYYProductInfo : RLMObject

@property NSString *name;
@property NSInteger price;
@property NSData *productDescription;
@property NSDate *date;

@property RLMArray<YYYHighEnergyProduct*><YYYHighEnergyProduct> *hignEnergyProducts;

@end
#import "YYYProductInfo.h"

@implementation YYYProductInfo

// Specify default values for properties

+ (NSString *)primaryKey {
    return @"name";
}
@end

AddObject like this:
YYYProductInfo *newProduct = [[YYYProductInfo alloc] init];
newProduct.name = @"test"; //[self randomString];
newProduct.price = arc4random_uniform(20) * 1.0;
newProduct.productDescription = [self getDataByString:@"添加单个商品信息, 价格在20块以下"];
RLMRealm *realm = [RLMRealm defaultRealm];
NSError *error;
[realm transactionWithBlock:^{
    [realm addObject:newProduct];
} error:&error];

if (error != nil) {
    NSLog(@"%@", error.localizedDescription);
}

this code crashed after doing twice "crash log":

Can't set primary key property 'name' to existing value 'test'

why it does not throw the "error" infomation instead of crashing in the second operation?

Creating an object with an existing primary key is treated as a program error, because write transactions are exclusive, so that you've a guarantee when checking before the attempt to create it that the operation will succeed. Realm operations fail in general with returning an error, if you've no way to foresee, that this could fail. If you want to add or update the object, please use -addOrUpdateObject: instead. Does this help?

@mrackwitz thanks a lot. That means I should modify my Model or code to fix this. What kind of error will i met if i use this method normally?

You need to modify your code for object creation. e.g.
[realm transactionWithBlock:^{
    [realm addOrUpdateObject:newProduct];
} error:&error];

This would fail, if the Realm can't be written, e.g. because Realm's auxiliary files can't be created.


d3.group, d3.groupsum, etc.

Formerly known as multimap, as proposed here:
https://beta.observablehq.com/@mbostock/group

I think the path forward here is to deprecate d3-collection entirely and adopt ES collections (Map, Set).
The proposed d3.group works well for single-level grouping, but it would be nice to have something analogous to d3.nest for multi-level grouping. Here’s an example two-level group:
new Map(Array.from(
  group(data, d => d.name),
  ([name, values]) => [name, group(values, d => d.date)]
))

Perhaps there’s a d3.nest(data, ...keys) function?

Some notes here: https://beta.observablehq.com/@mbostock/nested-groups

These seem to work well:
function nest(values, ...keys) {
  return (function regroup(values, j) {
    if (j >= keys.length) return values;
    const map = group(values, keys[j]);
    if (j === keys.length) return map;
    return new Map(Array.from(map, ([k, v]) => [k, regroup(v, j + 1)]));
  })(values, 0);
}

function rollup(values, reduce, ...keys) {
  return (function regroup(values, j) {
    if (j >= keys.length) return reduce(values);
    const map = group(values, keys[j]);
    return new Map(Array.from(map, ([k, v]) => [k, regroup(v, j + 1)]));
  })(values, 0);
}


App is not installed on emulator in detox 12.11.0

Describe the bug
Some test suits are failing because of the app isn't installed on the simulator
To Reproduce
just run 12.11.0

[x ] I have tested this issue on the latest Detox release and it still reproduces

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
https://imgur.com/BFFKt3p
https://imgur.com/engzM4g
Environment (please complete the following information):

Detox:12.11.0
React Native:0.59.0
Node:8.12.0
Device:Iphone
Xcode:10
iOS:12
macOS: 10.14

Device and Verbose Detox Logs
in screenshots
iOS Framework Build Logs
in screenshots

Thanks Ward!
Looking at the log, there was no xcrun simctl install call at all, which explains why the system complains. Going back to a previous version worked.

@noomorph

@noomorph This was solved, right? Please close if no longer relevant. Thanks

Resolved via #1467


attestation-service: implement *_policy() methods for EAR token broker

without the changes, kbs-client "set-attestation-policy" gets "not supported" errors.
the changes are taken from 'simple' token broker. Both token brokers have a policy_engine instance created.

OPA policy engine seems to writes these to the disk and at least the docker-compose backed mount stores it persistently (on the AS side, not KBS).

it might make sense to do implement for consistency's sake. but IMO we should really re/consider how we want to handle state in KBS/AS and not expose stateful methods unless we know how we want to address with it.

yeah makes sense. right now this is just to be able to experiment with EAR policies uploaded using kbs-client config set-attestation-policy the same way as with simple broker.

maybe we should make an issue for tracking the statefulness stuff


Gradle issue

Hello, why i can't import TornadoVM with gradle?
I imported it's jar files with intellij, here's the error i get

I would like to have a way to set TornadoVM  in gradle

Hi @offeex .
TornadoVM is built using maven. If you want to use another build system you need to also build the dependencies.
We get the API from a copy of all JAR files we have in GitHub.
The Maven dependency is as follows:
<repositories>
    <repository>
        <id>universityOfManchester-graal</id>
        <url>https://raw.githubusercontent.com/beehive-lab/tornado/maven-tornadovm</url>
    </repository>
</repositories>

<dependencies>
<dependency>
    <groupId>tornado</groupId>
    <artifactId>tornado-api</artifactId>
    <version>0.15</version>
</dependency>
<dependency>
    <groupId>tornado</groupId>
    <artifactId>tornado-matrices</artifactId>
    <version>0.15</version>
</dependency>
</dependencies>

And all JAR files are stored here: https://github.com/beehive-lab/TornadoVM/tree/maven-tornadovm

I close this issue since this build process is not the one TornadoVM has.


invalid metadata of pipelinetask, cause the pipelinerun has been waiting.

Expected Behavior
I recently encountered a webhook verification failure again, which made it impossible to create a taskrun, and the pr has been waiting.
have a similar question: #5723.
An invalid metadata is defined in the pipelinetask, the pipelinerun should directly report failure and stop running immediately.
Actual Behavior
the pr has been running, and did not directly report an error.
Steps to Reproduce the Problem
...
  tasks:
  - name: test
    taskSpec:
      metadata:
        labels:
          example.io/: test
...

Kubernetes version:
kubernetes: 1.23.1
Tekton Pipeline version:
0.41.x

I observed similar behavior with a TaskRun that fails validation for a different reason:
$ k get pr
NAME                  SUCCEEDED   REASON                STARTTIME   COMPLETIONTIME
demo-pipeline-run-1   Unknown     PipelineRunStopping   10s

$ k get tr -l tekton.dev/pipelineRun=demo-pipeline-run-1
NAME                      SUCCEEDED   REASON                    STARTTIME   COMPLETIONTIME
demo-pipeline-run-1-bar   True        Succeeded                 2m3s        104s
demo-pipeline-run-1-baz   False       TaskRunValidationFailed   2m3s        2m3s
demo-pipeline-run-1-foo   True        Succeeded                 2m3s        103s

$ tkn tr describe demo-pipeline-run-1-baz
...

🌡  Status

STARTED         DURATION    STATUS
3 minutes ago   0s          Failed(TaskRunValidationFailed)

Message

more than one PersistentVolumeClaim is bound

The PipelineRun should be marked as failed, but it's stuck in PipelineRunStopping. @cugykw is this the error you're experiencing as well, even if the reason for taskrun validation failure is different?

I observed similar behavior with a TaskRun that fails validation for a different reason:
$ k get pr
NAME                  SUCCEEDED   REASON                STARTTIME   COMPLETIONTIME
demo-pipeline-run-1   Unknown     PipelineRunStopping   10s

$ k get tr -l tekton.dev/pipelineRun=demo-pipeline-run-1
NAME                      SUCCEEDED   REASON                    STARTTIME   COMPLETIONTIME
demo-pipeline-run-1-bar   True        Succeeded                 2m3s        104s
demo-pipeline-run-1-baz   False       TaskRunValidationFailed   2m3s        2m3s
demo-pipeline-run-1-foo   True        Succeeded                 2m3s        103s

$ tkn tr describe demo-pipeline-run-1-baz
...

🌡  Status

STARTED         DURATION    STATUS
3 minutes ago   0s          Failed(TaskRunValidationFailed)

Message

more than one PersistentVolumeClaim is bound

The PipelineRun should be marked as failed, but it's stuck in PipelineRunStopping. @cugykw is this the error you're experiencing as well, even if the reason for taskrun validation failure is different?

@lbernick  The problem I'm having may be different. The problem I'm having is that the taskrun is not being created. Issue #5723 is when taskrun is being created but it has not passed the tekton webhook verification. The similar issue is #5569.
In fact, the invalid metadata problem encountered this time did not pass the verification of native k8s.
I'm not sure if there will be a problem if the pipeline controller fails to create a taskrun and directly returns an error and ends the run. Therefore, I want to handle creating taskrun the same way taskrun handles creating pod failures.