fiducials: 0.12.0-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository fiducials to 0.12.0-1:

upstream repository: https://github.com/UbiquityRobotics/fiducials
release repository: https://github.com/UbiquityRobotics-release/fiducials-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

aruco_detect
* Deps python2 -> python3
* Updated marker generation script to work with Python3  (#254 <https://github.com/UbiquityRobotics/fiducials/issues/254>)
  * Updated create marker script for python3
  * Updated to use Python 3 cairosvg module
  * Added argument to change fiducial length and scaling the marker based on it
  * Change to Python 3
  * Fixed string format
  * Changed argument name for passing in fiducial length
  * Updated marker generation script to work with Python3
  * Added a comment about why marker_gen is a separate module
  * gitignore bagfiles, we don't want them to be checked in generally
  Co-authored-by: Ajith Thomas<EMAIL_ADDRESS>* Use newer constant for imread in aruco tests
* Add missing dependencies on transport plugins
* Merge pull request #236 <https://github.com/UbiquityRobotics/fiducials/issues/236> from UbiquityRobotics/bugfix-aruco-detect-relative-topics
  fixed aruco detect remaps to relative topic names to suport namespaces
* Dynamic Reconfigure rosparam integration completed
* Splitted aruco vertices detection and pose estimation.
* Splitted detection and pose estimation.
* Make fiducial_tf_publish a param
* Moved fiducial tf publishing to aruco_detect node
* Add mutex to image callback
* Public node handle instead of leading / for namespace support
  This allows someone to start the node in a namespace and have all the
  topics remapped into the namespace automatically. Parameters are still
  kept in a private node handle so they come up in aruco_detect/*
  Fixes: https://github.com/UbiquityRobotics/fiducials/issues/183
* Fix fiducial_len_override bug (#180 <https://github.com/UbiquityRobotics/fiducials/issues/180>)
* Make ignored fiducials dynamically reconfigurable (#170 <https://github.com/UbiquityRobotics/fiducials/issues/170>)
  * Make ignored fiducials dynamically reconfigurable
* Contributors: Caio Amaral, Canberk S. Gurel, Janez Cimerman, Jim Vaughan, MoffKalast, Rohan Agrawal, Teodor, Vid Rijavec, canberkgurel

fiducial_msgs

No changes

fiducial_slam
* Merge pull request #259 <https://github.com/UbiquityRobotics/fiducials/issues/259> from ivan140/feature/pose_publish_rate
  Added pose_publish_rate which controls the rate of /fiducial_pose
* added feature pose_publish_rate which controls the rate of topic /fiducial_pose
* Merge pull request #258 <https://github.com/UbiquityRobotics/fiducials/issues/258> from UbiquityRobotics/opencv-deprecated-constant
  Replace deprecated OpenCV constant in fiducial_slam test
* Replace deprecated OpenCV constant in fiducial_slam test
* Merge pull request #244 <https://github.com/UbiquityRobotics/fiducials/issues/244> from agutenkunst/fix/remove_unused_subs
  I think this is sensible to merge, since it does not affect the workings of the package and it removes some confusion, so merging
* Remove non-functional doPoseEstimation from fiducial_slam
* Remove unused subscriber
* Merge pull request #221 <https://github.com/UbiquityRobotics/fiducials/issues/221> from UbiquityRobotics/bugfix-#220 <https://github.com/UbiquityRobotics/bugfix-/issues/220>
  Allow covariance to be overridden by launch file
* Allow covariance to be overriden by launch file
  Uses YAML interpretation for the parameter so that it becomes an array
  instead of a string. Fix a comparison issue in the code to make the
  override actually warn on 0 values.
* Return early from auto init when no fiducials
* Merge pull request #214 <https://github.com/UbiquityRobotics/fiducials/issues/214> from UbiquityRobotics/publish_fids
  Moved fiducial tf publishing to aruco_detect node
* Moved fiducial tf publishing to aruco_detect node
* Address #204 <https://github.com/UbiquityRobotics/fiducials/issues/204> (#205 <https://github.com/UbiquityRobotics/fiducials/issues/205>)
* Revert "Address #204 <https://github.com/UbiquityRobotics/fiducials/issues/204>"
  This reverts commit ba13b567ca71a33202547dd6df03d61b94a90d45.
* Address #204 <https://github.com/UbiquityRobotics/fiducials/issues/204>
* Use FrameId in rviz markers (#195 <https://github.com/UbiquityRobotics/fiducials/issues/195>)
  * FrameId used in the rviz markers
  * FrameId used in rviz markers
* Removed multi-fiducial code (#184 <https://github.com/UbiquityRobotics/fiducials/issues/184>)
* Add service call to add a fiducial to the map (#176 <https://github.com/UbiquityRobotics/fiducials/issues/176>)
  * Add service call to add a fiducial to the map
  * Abort auto-init when add fiducial service is called.
* Merge pull request #175 <https://github.com/UbiquityRobotics/fiducials/issues/175> from UbiquityRobotics/fix-#173 <https://github.com/UbiquityRobotics/fix-/issues/173>
  Cleanup for fiducial_slam
* add and run clang-format
* Get rid of observation.positon, it was only being used in 1 place
* Links to other fiducials uses set instead map<int,int>
  We only care if the element exists or not, so a set is a
  clearer data structure to use.
* Unused sum_in_qudrature removed, holdover from Alexy stuff
* Use clearer ranged for where possible
  Ranged for provides an easier way to interate over every
  element in a containter.
  NOTE: This commit changes what I consider to be buggy behavior
  in the autoInit and findClosestObs code, which was not properly
  iterating over every elemnent, using obs[0] every time.
* Remove using namespace declarations
  These are generally considered dangerous, due to the potential
  for namespace collisions and unclarity when using types.
* Contributors: Alexander Gutenkunst, David Alejo Teissière, Ivan Shalnov, Janez Cimerman, Jim Vaughan, Rohan Agrawal

fiducials

No changes

Sorry for the delay here.
I added the LICENSE file to this repo.
Since this package is already released on previous ROS versions (kinetic, melodic) I am not sure it makes sense to change the meta-package name for Noetic, which is going to be the last ROS1 version. I would agree that a better name would make sense for the ROS2 version.
Does that sound reasonable to you?

Since this package is already released on previous ROS versions (kinetic, melodic) I am not sure it makes sense to change the meta-package name for Noetic, which is going to be the last ROS1 version. I would agree that a better name would make sense for the ROS2 version.
Does that sound reasonable to you?

Ah yeah.  I didn't realize that this was already in previous ROS distributions under the fiducials name.  In that case, this is fine.  Thanks for the follow-up, I'll go ahead and merge this.


Add doctor script, update README about preconditions

@ludovic35 is missing, agrred with him to automerge for such chores


Fix datepicker title not centered when displaying calendar weeks

This pull requests fixes bug #1625. The fix is trivial and makes use of an existing feature; the potential for a regression is minimal.
Cheers, Oliver

LGTM

Thanks @mologie!


Possible deadlock downstream from WorkflowNodeExecutorActor

Logging this in case it helps someone else. Cause not yet known...
We were running "K-Means" through "Fit + Transform" (in local mode), and when the "fit" stage finished, the Spark job would hang, and the workflow would never progress. Clicking "Abort" wouldn't kill the job either, but "Stop editing" did.
Through the Spark UI we were able to do a thread dump and get the backtrace (below) of the thread that was blocked.
Unfortunately, haven't figured out the direct cause, but when we added the following to the "Custom settings" it the job was able to complete.
--conf spark.ui.showConsoleProgress=false

I do wonder if this is a red herring (an accidental fix that just delays the real cause), and could imagine this being related to #43 if the OutputInterceptorFactory isn't doing its job and keeping output buffers cleared/processed.
Blocked Thread
131    default-node-executor-dispatcher-16    BLOCKED
Blocked by Thread Some(35) Lock(org.apache.spark.ui.ConsoleProgressBar@302054359})
org.apache.spark.ui.ConsoleProgressBar.finishAll(ConsoleProgressBar.scala:122)
org.apache.spark.SparkContext$$anonfun$runJob$3.apply(SparkContext.scala:1926)
org.apache.spark.SparkContext$$anonfun$runJob$3.apply(SparkContext.scala:1926)
scala.Option.foreach(Option.scala:257)
org.apache.spark.SparkContext.runJob(SparkContext.scala:1926)
org.apache.spark.SparkContext.runJob(SparkContext.scala:1938)
org.apache.spark.SparkContext.runJob(SparkContext.scala:1951)
org.apache.spark.SparkContext.runJob(SparkContext.scala:1965)
org.apache.spark.rdd.RDD$$anonfun$collect$1.apply(RDD.scala:936)
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:112)
org.apache.spark.rdd.RDD.withScope(RDD.scala:362)
org.apache.spark.rdd.RDD.collect(RDD.scala:935)
org.apache.spark.mllib.clustering.KMeans.initKMeansParallel(KMeans.scala:381)
org.apache.spark.mllib.clustering.KMeans.runAlgorithm(KMeans.scala:256)
org.apache.spark.mllib.clustering.KMeans.run(KMeans.scala:227)
org.apache.spark.ml.clustering.KMeans.fit(KMeans.scala:319)
org.apache.spark.ml.clustering.KMeans.fit(KMeans.scala:253)
ai.deepsense.deeplang.doperables.serialization.SerializableSparkEstimator.fitDF(SerializableSparkEstimator.scala:35)
ai.deepsense.deeplang.doperables.serialization.SerializableSparkEstimator.fitDF(SerializableSparkEstimator.scala:28)
ai.deepsense.sparkutils.ML$Estimator.fit(SparkUtils.scala:89)
org.apache.spark.ml.Estimator.fit(Estimator.scala:61)
ai.deepsense.deeplang.doperables.SparkEstimatorWrapper._fit(SparkEstimatorWrapper.scala:57)
ai.deepsense.deeplang.doperables.SparkEstimatorWrapper._fit(SparkEstimatorWrapper.scala:39)
ai.deepsense.deeplang.doperables.Estimator$$anon$1.apply(Estimator.scala:56)
ai.deepsense.deeplang.doperables.Estimator$$anon$1.apply(Estimator.scala:54)
ai.deepsense.deeplang.doperations.FitPlusTransform.execute(FitPlusTransform.scala:65)
ai.deepsense.deeplang.doperations.FitPlusTransform.execute(FitPlusTransform.scala:35)
ai.deepsense.deeplang.DOperation2To2.executeUntyped(DOperations.scala:483)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor.executeOperation(WorkflowNodeExecutorActor.scala:126)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor$$anonfun$receive$1$$anonfun$applyOrElse$1.apply$mcV$sp(WorkflowNodeExecutorActor.scala:55)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor$$anonfun$receive$1$$anonfun$applyOrElse$1.apply(WorkflowNodeExecutorActor.scala:54)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor$$anonfun$receive$1$$anonfun$applyOrElse$1.apply(WorkflowNodeExecutorActor.scala:54)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor.ai$deepsense$workflowexecutor$WorkflowNodeExecutorActor$$asSparkJobGroup(WorkflowNodeExecutorActor.scala:145)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor$$anonfun$receive$1.applyOrElse(WorkflowNodeExecutorActor.scala:54)
akka.actor.Actor$class.aroundReceive(Actor.scala:484)
ai.deepsense.workflowexecutor.WorkflowNodeExecutorActor.aroundReceive(WorkflowNodeExecutorActor.scala:36)
akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
akka.actor.ActorCell.invoke(ActorCell.scala:495)
akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
akka.dispatch.Mailbox.run(Mailbox.scala:224)
akka.dispatch.Mailbox.exec(Mailbox.scala:234)
scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

@jaroslaw-osmanski Do you have any assessment of this? We keep having problems with the system becoming unstable when "Abort" is used, and I'm wondering if this ticket could be the problem. Here's somewhat of a test script from one of our data scientists (we can't submit the full thing here).

I was running df.count() in Python notebook and df.show() and Seahorse seems to just hang. If I look at Spark Resource Manager, job is showing as complete. This also happens when I try to run a k-means node twice in a row. The first time will run fine. Second time will hang.
Here's an example workflow of when this happens with k-means and steps to repeat.

Create k-means workflow with default settings, with a +1,000,000 row input DataFrame, and direct the results to a Python Notebook
Start editing workflow on yarn cluster.
Select Python Notebook node and click run. This should take about 2-3 minutes.
Select K-Means node and change k to 10.
Select Python Notebook node and click run. This should take FOREVER.
Wait 5 minutes and check Spark Resource Manager. This should say all tasks are complete, but Seahorse is showing the workflow is still running.

cc: @courtney-whalen


Planner documentation inconsistency. Closes #3338

Closes #3338

Awesome.
Thanks for your work. Will review it shortly 👍
You rock 🤩

Please revert your revert @Jwaegebaert 😆 I've already closed mine. This one is better, plus it's less review time.

Would that still be necessary? Because #3354 will now resolve this typo as well.

You're correct, I'm having them all muddled together in my head. 😵 continue as planned!

Merged manually, thanks @Jwaegebaert 🏁


List of issues with biometrics enabled in app and on device on android

Issues:

[x] app asks for biometrics authentication before entering into the biometrics screen in onboarding. App should only prompt once.
[x] When opening the app, the app does not prompt biometrics until after entering PIN. If PIN is incorrect but biometrics is correct, app does not successfully unlock. App should prompt biometrics automatically and without the need of a PIN.
[x] app prompts biometrics twice, once after entering the PIN and again while the app is loading. App should only prompt once.
[x] OS level message says "authenticate to retrieve secret". It should say "Open BC Wallet with your biometrics"
[ ] app does not unlock with face ID/face unlock even with it enabled on device

What I did:
I went through onboarding and right after creating a PIN, the app asks for biometrics authentication, after I authenticate, it goes into the biometrics screen, then after continuing with biometrics toggled on, it asks for biometrics again.
Right after enabling biometrics, the app is loading for a very long time. I had to close the app and open it again. Now, I have to enter my PIN and authenticate with biometrics twice to enter the app
OS level message to use biometrics says "authenticate to retrieve secret". This message is not plain language. It doesn't make sense to the average user.
My device has face data. After I opened the app and tried to unlock using face ID. It didn't work. I have to use fingerprint.
Build: 284
Device: OnePlus 6, Android 11

Done. The face authentication for Android will be moved to its own ticket.


Simplify the parsing logic of makejdk_any_platform_args

Close #3955

Grinder :https://ci.adoptium.net/view/Test_grinder/job/Grinder/10987/console
13:04:21  make[5]: Entering directory '/cygdrive/c/comp-jdk-build/temurin-build/workspace/build/src'
13:04:21  Error: Cannot locate spec.gmk, given by SPEC=win_x86-64.
13:04:21  /cygdrive/c/comp-jdk-build/temurin-build/workspace/build/src/make/Init.gmk:124: *** Cannot continue.  Stop.
13:04:21  make[5]: Leaving directory '/cygdrive/c/comp-jdk-build/temurin-build/workspace/build/src'
13:04:21  OpenJDK make failed, archiving make failed logs
13:04:22  Archiving and compressing with gzip
13

@andrew-m-leonard the build and error message I got

grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/11002/ - unset SPEC temporarily.
@andrew-m-leonard see the grinder unset SPEC temporarily is the test results good?

grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/11002/ - unset SPEC temporarily.
@andrew-m-leonard see the grinder unset SPEC temporarily is the test results good?

@sophia-guo good to see unsetting SPEC resolved the autoconf failure
The 3 differing files are caused by a failure in patching the SystemModule classes:
17:05:57  find: '': No such file or directory
17:05:57  find: '': No such file or directory
17:05:57  find: '': No such file or directory
17:05:57  Successfully removed all SystemModules jdk.jpackage hash differences from

It was clearly not "Successful" !!
I think it is this find line that is failing: https://github.com/adoptium/temurin-build/blob/79bb2763471fbe65ecb101d94e470514024bf7f9/tooling/reproducible/repro_common.sh#L96
I am not sure why ${JDK_DIR} is not being resolved, but I wonder if these two functions should be changed to have it passed as a param, like all the others are:
function removeSystemModulesHashBuilderParams() {
function processModuleInfo() {

https://ci.adoptium.net/view/Test_grinder/job/Grinder/11051/


[OSCI] Clean/breadcrumb updates - Refactoring use of 'let' for 'const' keyword and CSS modifier '--last' for one class only

Description
This PR addresses the new requests asked for the OuiBreadcrumb component as detailed below:

https://github.com/opensearch-project/oui/pull/131/files#r1043950226
https://github.com/opensearch-project/oui/pull/131/files#r1043973824

The specific updates done were:

Refactoring code in breadcrumbs.tsx file using const keywords instead of let.
Refactoring code in _breadcrumbs.scss file removing the CSS--last modifier from .ouiBreadcrumb class and keeping it only in .ouiBreadcrumbWrapperclass.

Issues Resolved
Issue #377
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks good, except this example breaks:

@BSFishy issue resolved. It was a minor mistake in the definition for calculating the variable calculatedMax. Thanks for the head-ups.

@BSFishy,
Any updates on this side? The corrections you requested are ready for review.
Regards,
Samuel

Visually looks good. Want to see this change, though, for cleanliness reasons

Only visual change is that the collapsed breadcrumb ellipses are a slightly brighter color, which I think was the original intention. Looks good!

Hi @BSFishy, do you want me to review the color you mentioned for the breadcrumb ellipsis?

Hi @BSFishy, do you want me to review the color you mentioned for the breadcrumb ellipsis?

Nope, the color looks better imo. I think I was trying to make this change when I redid this implementation but was running into issues and didn't want to hold it for longer than I already was, so this change is good in my book!

Hi @BSFishy, do you want me to review the color you mentioned for the breadcrumb ellipsis?

Nope, the color looks better imo. I think I was trying to make this change when I redid this implementation but was running into issues and didn't want to hold it for longer than I already was, so this change is good in my book!

Great! Btw just solved a merge conflict in the CHANGELOG.md that popped up here in the GitHub Interface. All good now.

@BSFishy,
PR updated with the main branch. Are we good to go for the merge?

PR updated with the main branch. Are we good to go to merge?

Just need another reviewer


Run on container based infrastructure

Will result in faster test execution time as the containers startup faster. See http://docs.travis-ci.com/user/workers/container-based-infrastructure/ for details.

Thank you. Merging.


Added FSS subnet along with security rules between Worker subnet.

Created network and security list for hosting OCI FSS. Updated worker subnet with an additional security list for FSS mount target network.
Signed-off-by: Ramesh Ramakrishnan<EMAIL_ADDRESS>

I'll close this PR since you submitted another one.


Organoid project doesn't display correct organ

The 10x demo dataset (project) - human cerebral organoids - displays the Organ as "skin of body". This is not accurate in the context of what the data represent.
In this project, skin samples were taken from donors, the skin cells in the sample transformed to become pluripotent (induced pluripotent stem (iPS) cells, or cells capable of becoming another cell type), differentiated into organoids that represent the brain (i.e. cerebral organoids), and then cells taken from the cerebral organoids were then sequenced.
donor -> skin sample (specimen) > iPS cells (cell line) > brain organoid (organoid) > neural cells (cell suspension) > sequencing files
So, the dataset actually represents the Organ brain (represented in the metadata in the organoid.model_for_organ.text field).
Having the Organ for this project be "skin of body" - the sample taken directly from the donor before being converted to iPS cells and then cerebral organoids - is misleading.

┆Issue Number: HCAB-265

@malloryfreeberg can you help us specify an algorithm—that works for all bundles across all projects— for extracting the correct organ and organ part information from the graph of metadata entities? The algorithm should define  direction and order of graph traversal as well as which field to consider from every entity. Something like:

Start from a specimen_from_ and go upwards in the graph.
When you encounter an organoid, extract field x and y if present and exit, otherwise continue
If you encounter an specimen_from_organism, extract fields a and b and exit, …

@hannes-ucsc sure thing! I'll work on this and review with the other wranglers.

Is organoid invariably downstream from specimen_from_organism? And is cell_suspension invariably downstream from organoid? I think it's yes on both, just want to make sure.

@hannes-ucsc yes, organoid is downstream of 'specimen_from organism' and 'cell_suspension' is downstream of 'organoid' (if there is one), if not it is always downstream from "specimen_from_organism".

@malloryfreeberg @zperova , I think this might break for "Single-cell RNA-seq analysis throughout a 125-day differentiation protocol that converted H1 human embryonic stem cells to a variety of ventrally-derived cell types.". I'm pretty sure those get marked as "blastocyst" from this algorithm, but they are not blastocysts.

Great point @mckinsel . We were all just discussing this the other day (@zperova @hewgreen ) and decided that we were missing the modelling of the actual differentiated cell line. I believe Matt is adding this in prior to re-ingestion, and is indicating the cell_type as "interneurons" and the model_organ and "brain". The model would then go:
... -> H1 stem cell line -> differentiated interneuron cell line (organ: brain) -> cell suspension -> sequence file
Cell lines would be treated like organoids. If you encounter them first travelling up from the sequence file, extract the organ information from the cell line rather than any upstream specimens.

@mckinsel you are right. The algorithm needs to be updated to incorporate the new field cell_line.model_organ.ontology_label in case of cell lines.

@malloryfreeberg
This issue is about the project "HPSI human cerebral organoids" which now shows "brain" instead of "skin". I am under the impression that this is the desired behavior and will be closing this ticket. If that is not correct, please reopen.
The above comments indicate that there is another project where the Data Browser still displays the wrong organ. @mckinsel alludes that this project currently displays "blastocysts" which it doesn't. It displays organ "embryo". What organ should be displayed? If would help if this information (which project, current behavior, expected behavior) were captured in a new issue, unless there already is one. #338 sounds similar. I think I understand what the fix is (including cell_line.model_organ and preferring a downstream cell_line over upstream, "sample-like" biomaterials like organoid or specimen in the graph.


close opened file descriptors properly

Calling fclose() will ensure the file descriptor is properly disposed of and output buffers flushed so the data written to the file will be present in the file on disk.
Found by https://github.com/bryongloden/cppcheck

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please


Replace autotools madness with CMake

Main question you may ask is "why", there is some good articles about this in google, I picked some for you:
http://voices.canonical.com/jussi.pakkanen/2011/09/13/autotools/
https://lwn.net/Articles/188693/
TL;DR: CMake is best. :-)
Hint: Squash-merge to hide funny HexwellC's commit message. :-)

Looks good, and I am convinced!  Thank you @foxcpp  and @HexwellC
P.S.  I don't see why the conversion from autotools to cmake would not fix my life, so I leave the comment in for posterity.


html: parsing: log warning if two input node classes share same type

Codecov Report

Merging #93 (d730726) into master (a61b653) will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   36.62%   36.64%   +0.02%
==========================================
  Files          67       67
  Lines        4314     4317       +3
==========================================
+ Hits         1580     1582       +2
- Misses       2734     2735       +1

Impacted Files
Coverage Δ

lona/html/parsing.py
89.41% <80.00%> (-0.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61b653...d730726. Read the comment docs.

@maratori Great! Thanks! :)


Couchbase support

Hi,
I am new to this tool we would like to implement this in our environment.
Is that wherehows can intergrate with couchbase? if yes can you provide the steps
Regards
Girirajan S.

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


Inject analytics

Injected snippets can now provide a snippetid, which will be sent to GA.
closes #1352

@RedBrogdon @jayoung-lee I think this is ready for another look. Right now, codelabs are using the id query parameter to distinguish between samples in a codelab:
https://dartpad.dev/embed-flutter.html?id=009a77697460e7ec6a3c142f0dfb1b5e&theme=dark&split=60

With this change, instead of id, the inject script sets the ga_id to whatever is specified in the markdown. for example:

        foo

Which ends up on the  turns into an iframe like this:

So i think we can use the same approach we are currently using without the need for virtual page views or custom dimensions

Yes! If the id (ga_id) shows up on the iframe URL, I can use that information :)

How about DartPad samples on the flutter.dev and dart.dev landing pages? Those DartPad samples are changed via a dropdown button.

@galeyang that's a good point, we will have to use virtual page views for that.

@johnpryan Are you planning to revise this PR to do pageviews, or would you like to land it and then go from there? Just asking if you still want a review, basically.

@RedBrogdon Let's get this landed and follow up with the virtual page views

Virtual pageviews issue: https://github.com/dart-lang/dart-pad/issues/1449


Allow size on select

📑 Description
Allow select size to be a number reflecting the original select props.
✅ Checks

[X] My pull request adheres to the code style of this project
[] My code requires changes to the documentation
[] I have updated the documentation as required
[ ] All the tests have passed

I understand tailwind variant a bit more now and this is not the solution. If you want to support the list style variant of select, either the variant name should be renamed or introduce a new attribute like selectSize or selectProps


🔔 Adding registration success banner and redirect to homepage

This PR addresses Issue #41
After going through the flow a few times, I realized there was a bit of a UX issue. On successful registration you stay on the registration page even though you can start navigating to other sections of the app, such as the homepage.
For this I decided to add a redirect to the homepage after a successful registration. Only at this time will a banner appear that says the registration was successful. Going to the homepage after this will not show that banner.
I know this was a bit off from what the ask was, but I think it makes a lot more sense! I attached a screenshot below of the new banner on the homepage:

@adilanchian Thank you very much for your support! I'll merge your pull request now :)
We have more issues and features to implement, If you'd like to help us feel free to ask us questions any time.

@staveyal you got it! Will see if there is something else I can help out with 👍


Errors monitoring for collectors

Montoring the state of your collectors is very important if you don't
want to fill up your logs with errors undetected. It is also very useful
to see where , when and why your collectors fail. We have found cases
where a collection fails only on a subset of hosts, since they had a bad
seyup, while it works well on the other 90%. Having this sort of
monitoring adds a layer of resilience to your collections and gives you
a more hollistic view of your systems.

What happened here T?

I am adding support for go collectors as well, so until that is done I closed this PR

I <3 this idea by the way.

:shipit:

Whammy! Nicely done.


AudioKit OS X is not working

Info:
I've tried running the HelloWorld example project, and when I toggle the button no sound emits. I've also tried following the installation video for 3.1, and still no sound. I'm also not getting any sort of errors. 😢
Specs:

Version: 3.1
OS: El Capitan 10.11.4
Processor: 2.8GHz Intel Core i7
Graphics: Intel Iris Pro 1536 MB

This sounds a lot like this issue that was reported the other day: https://github.com/audiokit/AudioKit/issues/336
@modulusMathews, try switching to the develop branch and seeing if that helps at all


Config.toml env variable replacement fails

Bug report
Describe the bug
When trying to run supabase start/stop using CLI versions 0.21.0 or above, an error is shown if an env variable is used in the config.toml.
This used to work with 0.18.2.
❯ source .env && supabase stop
Error: Error evaluating "env(GITHUB_CLIENT_ID)": environment variable GITHUB_CLIENT_ID is unset.
❯ echo $GITHUB_CLIENT_ID
some-client-id

Config
# other sections omitted
[auth.external.github]
enabled = true
client_id = "env(GITHUB_CLIENT_ID)"
secret = "env(GITHUB_SECRET)"

Let me know if more details are necessary.
Thanks!
To Reproduce

Add the above config snippet to a Supabase project
Create a .env file with GITHUB_CLIENT_ID=foo as contents
run source .env && supabase start
See error

Expected behavior
The env variables should be interpolated into the config.toml.
Ideally:

misconfigurations in the TOML file shouldn't prevent stopping the local Docker containers
env variable substitution should work throughout the config, and not just for auth providers

System information

OS: macOS 12.3
Version of supabase-cli: v0.22.4
Version of Node.js: v16.13.0

Thanks for the report! Will try to reproduce this.

Does it work if you do it like GITHUB_CLIENT_ID=a GITHUB_SECRET=b supabase stop?

I think you might need to use export GITHUB_CLIENT_ID=a etc. in your .env - source runs the script in a subshell so the envars are not passed to the supabase command.

As for your 2 points above:

misconfigurations in the TOML file shouldn't prevent stopping the local Docker containers

Agree, I should fix this.

env variable substitution should work throughout the config, and not just for auth providers

I'd like to keep it as is for now - the env() interpolation was really for things that shouldn't be committed to source control. I do think it's awkward that we only do it for external provider client IDs and secrets - might think up a better alternative at some point.

I think you might need to use export GITHUB_CLIENT_ID=a etc. in your .env - source runs the script in a subshell so the envars are not passed to the supabase command.
I'm not sure how/why it used to work though.

Before I didn't even need to run source. I would just alias my root /.env file to /supabase/.env. That seemed to work as intended.
And just to confirm, the env variables aren't loaded in automatically if I omit the source command either.
Issue with having to put export ... is that this then breaks the dotenv format and breaks usage with other tools.
I liked the aliasing workflow as it meant that we didn't have to juggle two sets of configs, and less chances of errors/accidental VCS commits.
I'll see if I can find a workaround, or have to adapt our workflow.
Thanks for investigating 🙏

As a workaround: https://unix.stackexchange.com/a/79077. Still not clean, but it works

@soedirgo, I did a bit more testing and identified 0.21.0 as the speicfic version where this behaviour changed.
I have zero Go knowledge and no knowledge about the reason for the change, but am assuming it's the removal of the godotenv from the main.go file that stopped reading in the .env file values.
package main

import (
-  "github.com/joho/godotenv"
  "github.com/supabase/cli/cmd"
)

func main() {
- _ = godotenv.Load("supabase/.env")
-
  cmd.Execute()
}

ah, that explains why my method of aliasing .env -> ./supabase/.env used to work then. I was just coopting the file.
I do think providing a more streamlined way for integrating with existing config conventions such as .env files would be desirable.
Please feel free to close this issue if you feel the above is out of scope, or want to track it another issue—new or reopening #177.
Either way, thanks for your time!

Yeah, I might revisit the secrets situation again. Thanks for your inputs!

@pocin I was able to reproduce this. Thanks for the catch!

does the fix apply if I run supabase start through npx?

FYI for others who stumble on this:

think you might need to use export GITHUB_CLIENT_ID=abcd

export GOTRUE_EXTERNAL_GITHUB_CLIENT_ID=id_abcd
export GOTRUE_EXTERNAL_GITHUB_SECRET=key_abcd

Without the export, it'll fail even if echo $GOTRUE_EXTERNAL_GITHUB_CLIENT_ID succeeds
(Probably would be good to put this in the docs or readme under https://github.com/supabase/gotrue#external-authentication-providers)

Thanks @iwasrobbed, saved me! 🌟

Hello guys.
I was facing this issue in my next.js + supabase project. I had made some changes in my config.toml file to use custom smtp provider and auth, so when I was following this tutorial: https://supabase.com/docs/guides/deployment/managing-environments?queryGroups=environment&environment=staging the github action was failing due to those missing envs.
Using dummy envs has solved the problem:
name: Deploy Migrations to Staging

on:
  push:
    branches:
      - main
  workflow_dispatch:

jobs:
  deploy:
    runs-on: ubuntu-latest

    env:
      SUPABASE_ACCESS_TOKEN: ${{ secrets.SUPABASE_ACCESS_TOKEN }}
      SUPABASE_DB_PASSWORD: ${{ secrets.STAGING_SUPABASE_DB_PASSWORD }}
      SUPABASE_PROJECT_ID: ${{ secrets.STAGING_SUPABASE_PROJECT_ID }}
      SUPABASE_RESEND_SECRET: 'dummy-secret'
      SUPABASE_AUTH_GITHUB_CLIENT_ID: 'dummy-id'
      SUPABASE_AUTH_GITHUB_SECRET: 'dummy-secret'
      SUPABASE_AUTH_GOOGLE_CLIENT_ID: 'dummy-id'
      SUPABASE_AUTH_GOOGLE_SECRET: 'dummy-secret'

    steps:
      - uses: actions/checkout@v4

      - name: Set up Supabase CLI
        uses: supabase/setup-cli@v1
        with:
          version: latest

      - run: SUPABASE_DB_PASSWORD=$SUPABASE_DB_PASSWORD supabase link --project-ref $SUPABASE_PROJECT_ID
      - run: supabase db push


Move test_tone and test_ppm out of test_hrt.cpp file into their own respective files.

Hi there,
This PR places test_tone and test_ppm into their own files to follow the convention in all of the other src/systemcmds/tests/* files.
Let me know if you have any questions on this PR!
-Mark

@davids5 , I've created the functionality we discussed. It's nice to get a tone when a test passes or fails.  Let me know if you'd prefer a different tone for pass/fail.  Thanks for the direction!

@dagar , ping.

Thanks @dagar and @davids5!


Add flag to indicate mid-circuit measurement support to target_info()

What is happening?
When running Supermarq, there are some benchmarks that require mid-circuit measurements. It would be helpful to know if a backend supports mid-circuit measurements through service.target_info() so we don't try to submit invalid circuits.
What are the current alternatives?
Use a try-except block to catch when a circuit is invalid for a certain device.
Any additional context?
No response

Note: with https://github.com/Infleqtion/server-superstaq/pull/2481, css.Service().target_info() now shows if an IBM backend supports mid-circuit measurements and conditional operations. Though, following https://github.com/Infleqtion/server-superstaq/issues/2481#issuecomment-1636507165, we're keeping this issue still open for its possible relevance for other targets.


Would be useful to have a simple interface for getting a single-time snapshot at a target population size

Use case: I have a control circuit. I've already verified (or don't care about) how it behaves dynamically. I want to see what kind of stationary distribution it leads to, ideally with low overhead, so I only care about state once the lineage has reached some large number of cells.
What I have to do currently:

Guess how long it will take to get to the right number of cells.
Simulate out to that time.
If it doesn't finish in some reasonable amount of time, or if it eats up all of my free RAM, manually kill Python and turn down the target time until it finishes.
Check through every schnitz to see if it runs to the end of the simulation. If there are "enough" of those schnitzes, continue with analysis. If not, ramp up the target time until I get enough cells. This has to be done slowly, since population will grow (stochastically!) exponentially with time.
Once I have enough cells, pull out all of the final states from each schnitz that's still alive at the end of the simulation into a new data structure and analyze from there.

*What I would like to be able to do:

Set a target population size.
Simulate out a lineage until the population reaches the target size, then return a dataframe or numpy array containing only final cell states.

Alternatively, could set an approximate amount of real time to simulate for, something like "run this for fifteen minutes and give me what you have".
Would this be practical? Could it run significantly faster/with less memory than a standard SimulateCellLineage?

This is similar to simulating with a population controlled chemostat (something I very much want to implement) - not particularly hard, but would require a whole new lineage simulation loop.

Yes! Chemostat would be nice. I've been "simulating" this by running a
bunch of independent single-cell lineages, which feels like I'm throwing
away half of my work and can't simulate evolution.
On Sat, Apr 3, 2021 at 1:53 PM William Poole @.***>
wrote:

This is similar to simulating with a population controlled chemostat
(something I very much want to implement) - not particularly hard, but
would require a whole new lineage simulation loop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/biocircuits/bioscrape/issues/94#issuecomment-812923798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM7DU4HNNIBMBOXJBWUS5TTG554DANCNFSM4ZNVK2VA
.

I can walk you through how to implement this if you want to get inside a simulation loop - or I could just do it. It is pretty easy.


Feature/signed distance field

Made a Class that computes Signed Distance Field(SDF) from grid map efficiently (O(n^2)).
To compute SDF use computeSignedDistanceField function. After that, the SDF is stored.
To access the SDF, use getDistanceAt function. This returns the signed distance at the position.
Also, getDistanceGradientAt provides the distance gradient at the position.

Closing this in favor if #122.


Markdown render wrong color on Dark Mode

In Dark Mode, the Markdown render component is black text on dark background:

Could you link to the JSON for this credential please? In the meantime will try to find another credential to test this with.

Displays as expected in iOS and Android LCW v2.0.11-Build 66–unordered list bullets are visible as expected in both dark mode and light mode using BCSI test credential.
Also works as intended in both iOS and Android LCW v2.0.11-Build 66-ordered lists, italics, bold are visible as expected in both dark mode and light mode using this test credential.


Dynamically added item to ng-repeat hold duplicate model

I 'm creating a web page where I 'm providing option to the user to dynamically add line items. I have used angularjs framework (v 1.4.7). I was able to achieve the effect of dynamically adding item to the ng-repeat but the modal seems to be not unique amongst the dynamically added items.
Here is demo code showing the problem:

<form novalidate class="form-vertical" ng-show="!loading" name="detailsForm" ng-controller="DetailsCtrl">

      <ng-form name="urlForm">
            <input type="email" name="socialUrl" ng-model="social.email">
            Email error
      </ng-form>

   Add
</form>

var myApp = angular.module('myApp', []);

myApp.controller('DetailsCtrl', ['$scope', function($scope) {
    $scope.loading = false;
    var social = {"email":""};

    $scope.socials = [
            { email<EMAIL_ADDRESS>        { email: 'invalid email'}];

  $scope.addSocial = function(){
    $scope.socials.push(social);
  };

    }]
    );

I have created the fiddle showing the problem. In the fiddle, please add a new item<EMAIL_ADDRESS>Add another item<EMAIL_ADDRESS>You will notice that the item added at first is also changed when typing in the second one.

Your code doing the 'add' push always the same object to the array, then of course changing "this" object displays the change in all views sharing the same object.
addSocial must do: $scope.socials.push({email:""}), creating a new email at each call
You should close this issue, nothing to do with angular.

@arashkbanan #miami #kashan #tehran

I agree with @frfancha


Prep work to migrate to PHPUnit 9.x

This is a fully backward-compatible change.
The general idea is to make the package testable under PHP 5.6 - 7.x - 8.0. This requires using both PHPUnit 5.x and 9.x, because only the last works correctly under PHP 8 (as is - collects coverage report).
But PHPUnit 9 has quite a lot of legacy methods removed, and PHPUnit 8 has these methods but with void return type. Therefore implementing these methods straight away is a no-go. This can be with a version-dependent trait, but for a small handful of functions used here it easier to do this by overloading them from __call and __callStatic. This is where DeprecatedTestMethods trait comes into play.
And there are also setUp(): void etc. which are not taken care in this PR.

There's also above-mentioned PolyfillAssertTrait from symfony/phpunit-bridge, but it is tagged @internal so it's a risky game to use it.
And there's also phpunitgoodpractices/polyfill, but it should be trivial to switch to any of those down the line.

Extracted from #5262 (it handles  setUp(): void among other things)

@keradus should it be more appropriate to use phpunitgoodpractices/polyfill here instead of a purpose-build short polyfill?

utilizing phpunitgoodpractices/polyfill would be great as more people found benefit from your work : )
(also we would have less maintenance in this project so I'm biased ;) )

Good point. Give me a minute to sort this out.

Should I add phpunitgoodpractices/polyfill as a direct dependency?

:+1:
feel free to raise PRs to that polyfill repo too, don't hesitate to reach out to me over https://gitter.im/keradus

@keradus DM'ing you there!

First PR for phpunitgoodpractices/polyfill is go https://github.com/PHPUnitGoodPractices/polyfill/pull/16
Once there's a CI, I'll add other methods.
Meanwhile this is ready for merge. Migrating to  phpunitgoodpractices/polyfill will be as simple as removing one file and changing one line.

What is the reason for the re-target?

Oh, I see. The last 2.15.x release has just happened?

So, what is the status with phpunitgoodpractices/polyfill? I think this is the only outstanding thing blocking merge now. The rest looks great, from what I can see.

@GrahamCampbell what we're doing there is fairly tricky, and, considering that @keradus is, understandably, looking for an uncompromising quality, at these circumstances I'd like to see it getting as thorough review as possible. Therefore, we have to wait for it to happen.

Do I need to squash-rebase it? It's not a big deal, but squash merging will be easier.

squash doesn't matter.
i only await for CI to confirm it works on all supported combinations of phpunit

This can be (squash) merged now, I think?

easy @GrahamCampbell , it will be merged when it will be merged. no need for pinging, especially when you see movement around related changes

I wasn't rushing. I was just re-approving after the changes you just made. :)

Thank you @sanmai.


[FEATURE] add getMatchingCountry

Exported the function to get the country code by number.

Hey @guiliuri13, Thanks for your PR!
I revised your PR and...there are interesting commits!
1. [FEATURE] add getMatchingCountry (HASH 1c4ac026c3e71cfcd5415444177c4405d9c8d57b):

This is a good commit! :)
But you need to improve the typescript to the function getMatchingCountry in declare file. The correct would be:

 export declare function getMatchingCountry(phoneNumber: string): ICountry | undefined;

The rest is okay!

2. [CONFIG] auth infos (HASH 057abac324b1d077ef51efd5690306aaced28614):

Bad Commit :C

3. [FIX] name pattern (HASH 88e2dea985ceaa24e893f55fdbddd8d8d3dae8c0):

Bad Commit :C

4. [FIX] fix exports (HASH a8fb6eab5fa829cd446d415648e2b4b96c3e7822):

This is a good commit! :)
In file lib/index.js you must not export getMatchingCountry and phoneMask like this (in your commit):

export { getMatchingCountry } from "./utils/getMatchingCountry"
export { phoneMask } from "./utils/inputMask"
 ```
 As you did is redundant, because both have already been imported from the appropriate path at the beginning of the file. So, export only as follows:
 ```
 export { getMatchingCountry, phoneMask}
 ```

And you need to improve the typescript to the function getMatchingCountry in declare file, too. The correct would be:

 export declare function phoneMask(value: string, countryCode?: string): string;

The rest is okay!

So, could you re-PR this, without the bad commit and with the required adjustments?
🚀AstrOOnauta 🚀

Hey @guiliuri13, Thanks for your PR!
I revised your PR and...there are interesting commits!
1. [FEATURE] add getMatchingCountry (HASH 1c4ac026c3e71cfcd5415444177c4405d9c8d57b):

This is a good commit! :)
But you need to improve the typescript to the function getMatchingCountry in declare file. The correct would be:

 export declare function getMatchingCountry(phoneNumber: string): ICountry | undefined;

The rest is okay!

2. [CONFIG] auth infos (HASH 057abac324b1d077ef51efd5690306aaced28614):

Bad Commit :C

3. [FIX] name pattern (HASH 88e2dea985ceaa24e893f55fdbddd8d8d3dae8c0):

Bad Commit :C

4. [FIX] fix exports (HASH a8fb6eab5fa829cd446d415648e2b4b96c3e7822):

This is a good commit! :)
In file lib/index.js you must not export getMatchingCountry and phoneMask like this (in your commit):

export { getMatchingCountry } from "./utils/getMatchingCountry"
export { phoneMask } from "./utils/inputMask"
 ```
 As you did is redundant, because both have already been imported from the appropriate path at the beginning of the file. So, export only as follows:
 ```
 export { getMatchingCountry, phoneMask}
 ```

And you need to improve the typescript to the function getMatchingCountry in declare file, too. The correct would be:

export declare function phoneMask(value: string, countryCode?: string): string;
 ```

The rest is okay!

So, could you re-PR this, without the bad commit and with the required adjustments?
🚀AstrOOnauta 🚀

Hey @guiliuri13, Thanks for your PR!
I revised your PR and...there are interesting commits!
1. [FEATURE] add getMatchingCountry (HASH 1c4ac026c3e71cfcd5415444177c4405d9c8d57b):

This is a good commit! :)
But you need to improve the typescript to the function getMatchingCountry in declare file. The correct would be:

 export declare function getMatchingCountry(phoneNumber: string): ICountry | undefined;

The rest is okay!

2. [CONFIG] auth infos (HASH 057abac324b1d077ef51efd5690306aaced28614):

Bad Commit :C

3. [FIX] name pattern (HASH 88e2dea985ceaa24e893f55fdbddd8d8d3dae8c0):

Bad Commit :C

4. [FIX] fix exports (HASH a8fb6eab5fa829cd446d415648e2b4b96c3e7822):

This is a good commit! :)
In file lib/index.js you must not export getMatchingCountry and phoneMask like this (in your commit):

 export { getMatchingCountry } from "./utils/getMatchingCountry"
 export { phoneMask } from "./utils/inputMask"

As you did is redundant, because both have already been imported from the appropriate path at the beginning of the file. So, export only as follows:
  export { getMatchingCountry, phoneMask}

And you need to improve the typescript to the function getMatchingCountry in declare file, too. The correct would be:

 export declare function phoneMask(value: string, countryCode?: string): string;

The rest is okay!

So, could you re-PR this, without the bad commit and with the required adjustments?
🚀AstrOOnauta 🚀

Of course, I'll tidy up your notes and make another pull request as soon as possible. I still hope to modify a good part of the architecture, hence the fork. I will always keep you with the credits! Thanks


Use Unicode emoji not :warning: to show warnings

Sorry, GFM is expanded on the document view in the PR, so it looked OK during review.  :cry:
Now it looks like this (and also cool in the ToC), at least on make docs-serve:

Thanks!


can you provide the instructions to prepare the datasets?

What do you mean? The Datasets take care of loading and pre-processing the data.

if you can provide some instructions to download the dataset. Or your code will automatically download the datasets?

https://github.com/brendenlake/omniglot
dataset link


ES Module support

@Hookyns check this out. Tried to run under type: "module" and got require is not defined.

You can create a PR with small change here:
https://github.com/Hookyns/tst-reflect/blob/53b56ac309e3f36c74c87d524268aa4084f87720/transformer/src/config.ts#L220-L229
Add the new module kind to line 228.

Published in<EMAIL_ADDRESS>TY for the PR.

Hmm, looks like it's still happening, https://stackblitz.com/edit/tst-reflect-issue-49-kdukpz

Any ideas why?

There's a require statement inserted in meta-writer/type-lib/TypeLibMetadataNodeGenerator.ts and
meta-writer/inline/InlineMetadataNodeGenerator.ts
factory.createIdentifier("require"),

I think that's why.

There are some other places where are the requires generated, without using the isESMModule function.
But now I don't know if we modified the isESMModule correctly. It's not just the "module" option but combination with "moduleResolution" or package.json setting. I need to look into it a little bit.

yeah, you might be right. I was asking about top-level await in the typescript repo and they pointed me to this.
https://www.typescriptlang.org/tsconfig#moduleResolution
It has to be set to nodenext apparently.

Should be fixed in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Also there was some trouble with typelib mode in nodenext module, cuz of code related to ts-node. Hope it'll be okay.

import { ExpressionKind, } from 'tst-expression';
         ^^^^^^^^^^^^^^
SyntaxError: Named export 'ExpressionKind' not found. The requested module 'tst-expression' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'tst-expression';
const { ExpressionKind, } = pkg;
``
Can you add a esm export to the packages?

Oh look's like there is one issue. In es mode, imports have to use .js extension for relative imports. getCtor() will have to change. Currently, it's like import("./index")

@avin-kavish Do you test it with ttsc or ts-node?
I found some note - from another contributor solving issues for ts-node - saying that ts-node has some issues with extensions .js/.ts so we removed the extensions cuz of it. But it was before nodenext option. They have to fixed it cuz of nodenext IMHO.

With ts-node. Not aware of any issues, i know it won't accept .ts extension though. Even .ts files have to be imported when .js.

Try<EMAIL_ADDRESS><EMAIL_ADDRESS>

woot! works now.

I'm working on it. 👍


Are there any plans to add thread affinity support for the java media driver?

I saw this feature from 1.38.2, but is only for c media driver

No. This would have a native dependency and the Java driver does not have native dependencies.


fix: Remove member confirmation is same for approver as well as member

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/46337
PROPOSAL: https://github.com/Expensify/App/issues/46337#issuecomment-2253759432
Tests

Go to workspace members page
Click on members profile
Click remove from workspace
Go back and click on approver profile
Click remove from workspace
Verify that: We should have different prompt for the approver warning the user that the current member is also approver

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to workspace members page
Click on members profile
Click remove from workspace
Go back and click on approver profile
Click remove from workspace
Verify that: We should have different prompt for the approver warning the user that the current member is also approver

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/a1c2d8ce-dfc7-49db-871b-07a96e5b0dfb

Android: mWeb Chrome

https://github.com/user-attachments/assets/114fdf6f-0f17-43c0-9eee-20748edd981e

iOS: Native

https://github.com/user-attachments/assets/514a52ec-65cd-46a8-8b23-bf2e43932176

iOS: mWeb Safari

https://github.com/user-attachments/assets/eeef78e8-f852-45f0-8e3c-d110c979a25f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/fd201344-117e-4c2e-82f1-425c6c84ad96

MacOS: Desktop

https://github.com/user-attachments/assets/ca5742bc-e7a4-4b9c-9c7e-bc6f833f128f

@allgandalf This is the result when we try to delete approver, Should we hide the remove button when deleting the approver?
https://github.com/user-attachments/assets/5f779060-c17d-4ddf-8165-d18d59053ff5

I don't think we want to allow that option - in the case where there's only one other person it works fine if you route all approvals to the other admin, but in the case that there are many approvers and admins, you need to manually update the approver flows

@allgandalf So we will not allow user to remove the approver, right?

The error message for why an approver cannot be removed is valuable IMO, I think we should keep it as is and just show the error message. So the current functionality seems fine

@allgandalf If it only shows error message like that, do we need to change the approver in optimistic data?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


ValueError: all the input array dimensions except for the concatenation axis must match exactly,

Sessions are crashing: https://codeocean.allenneuraldynamics.org/data-assets/b059b50d-0a77-43ce-bc74-1534d3bf875d/behavior_757209_2024-12-02_15-22-46_processed_2024-12-03_06-59-19/output?fullScreen=true&hideDetails=true

This has been fixed with above PR #59 and the pipeline capsules have been synced as well. Yay!


Added BorderFilter to detect if session is tagged i.e. authenticated or not

Detect if Session (i.e. user) is authenticated or not from the SessionId
(i.e. added a new byte inside Sessionid)
If SessionId is authenticated, then any HTTP requests to LoginManager paths
(i.e. unauthenticated paths) should be redirected to the protected
Service endpoint (i.e. path of the ServiceIdentifier)
If SessionId is not authenticated (i.e. not tagged), then any HTTP requests
to protected endpoint paths, should be redirected to LoginManager path

Fixes #85

@PeterFCaswell Please review this change

Current coverage is 96.25%

Merging #86 into master will increase coverage by +1.27% as of a0f2d23

@@            master     #86   diff @@
======================================
  Files           26      27     +1
  Stmts          359     374    +15
  Branches        13      21     +8
  Methods          0       0
======================================
+ Hit            341     360    +19
  Partial          0       0
+ Missed          18      14     -4

Review entire Coverage Diff as of a0f2d23

Powered by Codecov. Updated on successful CI builds.

Mostly just comment requests. Feel free to merge after you've added what makes sense.

@trane I have updated the code, let me know if it looks ok. If yes, I will merge it


allow multiple usage_report entries

xml2js parsing behaviour related
when only 1 usage_report child in the usage_reports xml, it is parsed as an object
when multiple usage_report children, it is parsed as an array

You are right. Thanks for spotting this and submitting the fix!


Enable scrolling on mobile even when there are event listeners present.

When we have any button or any event scrolling stops working on mobile you can actually check any community file in rive website you cant scroll the rive player when there are buttons.

Just ran into this issue... It absolutely breaks the site.

This is completely insane... This shouldn't be default behaviour. We have interactive rive on our website and you are just stuck there, unless you try to scroll somewhere in the corners

Just ran into this, you can see it on Dumbify.com, when you try to scroll on mobile by dragging in the "Say Hello to Dumbi" section, you are unable to.

I was able to get past this by enabling "isTouchScrollEnabled"
const { RiveComponent } = useRive({
    isTouchScrollEnabled: true,
// Rest of Configuration
  });

Getting the same behaviour on a Flutter mobile app; scrolling doesn't work when the swipe gesture starts on a rive target area. I've scoured the docs, but haven't found mention of the isTouchScrollEnabled parameter for Flutter anywhere, which makes me think that perhaps it doesn't exist. Anyone with the same issue?


Position Control Robot -> RobotViews

This PR solves #781. It also solved an UB with copying the robotView vector from WorldDataView on return

For some reason it added the commits from the previous branch. There should only be the last 4 commits


free skey on an error path in tls_construct_stoc_key_share()

skey is created by ssl_generate_pkey(), while it does not properly be freed if ssl_derive() fails, which may lead to memory leak.

Have you actually seen a memory leak here? Since it is stored in the SSL object I would expect it to be freed when the SSL object is subsequently freed.

Have you actually seen a memory leak here? Since it is stored in the SSL object I would expect it to be freed when the SSL object is subsequently freed.

No. In fact, I knew it will be freed eventually, but I think it is better to free it explicitly in this current function according to its context.

No. In fact, I knew it will be freed eventually, but I think it is better to free it explicitly in this current function according to its context.

This pattern is used extensively and I don't see a strong need to change it.

This pattern is used extensively and I don't see a strong need to change it.

Ok, thank you for your guidance. Then I just close it.


Day3 Dummy variable trap processing

Dummy variable trap processing part
encoding processing and dummy variable trap processing have some problem.

If I  one_hot_encoder = OneHotEncoder(categorical_features=[3]),
I got like [0.0000000e+00 0.0000000e+00 1.0000000e+00 1.6534920e+05 1.3689780e+05 4.7178410e+05]
then X = X[: , 1:].
I got like ``[0.0000000e+00 1.0000000e+00 1.6534920e+05 1.3689780e+05
4.7178410e+05]`, delete a first col
but I think writer want delete the fourth col.

why we need delete the fourth col？


Reduce string allocations on hotpath when not in debug logging mode

The event rendering can be moved inside the logging statement to reduce allocations if debug logging is not enabled.

@marc-casperlabs guess this is 1.4.0?

Yes, it's merged and not controversial.


Recurring functional test failures

We're seeing a couple of recurring test failures, which means there's likely a timing error with these tests.
The main one is:
PASS Users screen is correct (9 tests)
#    type: assertEval
#    file: /home/travis/build/TryGhost/Ghost/core/test/functional/client/team_test.js:68
#    code: }, 'The "Author" role is selected by default when adding a new user');
#    subject: false
#    fn: undefined
#    params: undefined

Here's an example broken build, plus the log link.

A second error that we see repeatedly is:
PASS Publish menu - new post status is correct after failed save (2 tests)
#    type: assert
#    file: /home/travis/build/TryGhost/Ghost/core/test/functional/client/editor_test.js:574
#    code: test.assert(false, 'Are you sure you want to leave modal did not appear.');
#    subject: false

With the exception of the classname, the test code hasn't changed here & doesn't look like it has an obvious potential timing issues. Both of these errors are to do with modals. This leads me to believe it may be the result of an issue with the upgrade to ember 1.13? cc @jaswilli

@ErisDS After spending several hours trying to figure this out, I haven't fully figured out a solution; however, I did figure out where exactly the problems are occurring.
As far as I can tell, neither error actually has to do with the modals themselves.
The 'author role is selected by default' error has to do with and incorrect selection occurring on the gh-select component somewhere around  here. I tried a couple of things with this. First I tried changing the $().prop('selected',true) to $().attr('selected',true), which seemed to fix it at first, but in the end didn't. I tried changing a couple of things in the team_test file to get that to fix it, but those didn't work either.
The 'modal not appearing' error is caused by something more interesting. The actual cause is because the editor controller is not returning 'isDirty' when it has actually been modified. (see here). I've tried several things, all of which don't consistently work.
If I have some other time later, I'll keep going at this, but for the moment, this is what I've found out.

These errors are new and seemingly related to dependency upgrades rather than code changes, as far as I can tell?
It sounds like the isDirty issue might come from an ember-data upgrade? There have been more releases of ember-data so perhaps we need to upgrade further? It seems isDirty has now been deprecated entirely https://github.com/emberjs/data/blob/master/CHANGELOG.md.
The gh-select component hasn't been updated recently, perhaps there is an underlying change in ember we aren't accounting for?
cc @jaswilli & @rwjblue any ideas on what might have changed to cause these issues ?

I'm tempted to comment out those two tests while we work on a fix - they're failing so often - I'm restarting builds 3/4 times before they pass.

I would agree with temporarily commenting them out – the fact that they pass eventually means that the functionality works at least.

I would second commenting them out. Perhaps put the issue in the current backlog to ensure its temporary-ness. As it stands it's really taking the continuous out of CI.

The editor test that is failing all the time was almost certainly broken by #5399.  The test for the role select dropdown is susceptible to a timing failure based on when it runs and when the option is actually set to selected.
The failing editor test can probably be fixed-up pretty easily.  The role dropdowns can be moved to something that in theory should be a little more stable and might take care of that failure.

I'm pretty sure the editor failure was occurring for me before inline-errors was merged. Inline-errors only got merged on Monday, and that failure has been occurring, on multiple branches, for the past couple of weeks. It's blocked me from being able to do grunt validate for a while.

Nevermind though, you seem to have fixed it. ;)

Think there might be one more in the editor tests?
PASS Publish menu - new page (10 tests)
#    type: fail
#    file: /home/travis/build/TryGhost/Ghost/core/test/functional/client/editor_test.js
#    subject: false

@ErisDS I haven't seen that one in a while, so I think it might be just a slightly more common random Casper error. At any rate, removing the blocker label might be a good idea for those looking for github issues to work on.

:+1:  done.

Going to close this in favour of just removing the casper.js tests in their entirety. @kevinansfield is working on a plan for how to do this and what we should replace it with.


enhancement on templating

Hi, there's two things that might be helpful to have on this awesome tool:

adding a lookup to the template to the entity the template is made for. this would help filtering on email when selecting a template. think about a standard user: he/she'll pull over any template thus complaining "if not working properly"
object fields lookup: when creating a template a non dev user might have difficulty to figure out what field name to insert. using the entity lookup (prev point) it might be simpler to only expose fields of that entity

Hi @luca0071,
Thanks for getting in touch.
I do understand your second point and have thought about it a couple of times as well.
It would certainly be possible, but is quite some work, since we have to check for nested values as well, when jumping across lookups.
Unfortunately I don't understand your first point, can you explain me the use case? Using the select target button, we already have something like the lookup you requested, right?
Kind Regards,
Florian

@luca0071 Do you mean you need a lookup on the template entity, which points to the entity which you target with your emails?
If yes then you could implement it per project using views, I don't think this should be part of the default solution.
Adding a control for selecting the correct fields is a task that I am planning as well.

Point one: defining a template for an entity might help filtering when selecting from the email; this way a standard user having filled out the regarding field would only find correct templates. This might be valid for language, so I know you added that feature to the template fields, but template text vary according to languages (same holds for standard CRM templates). That would increase adoption

Point two: adding the entity value to a template might help you create a entity fields list, this way adding fields to template will become easy ( only for those fields from main entity).

Good. I’ll keep posting ideas. If I like them...
one other thing would be introduce the language on the template as well. It
might help on complex orgs.
Il giorno mar 27 nov 2018 alle 08:22 Florian Krönert <
<EMAIL_ADDRESS>ha scritto:

Hi @luca0071 https://github.com/luca0071,
Now I see, thanks for the link. That's a great thing, I'll implement it.
Kind Regards,
Florian
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DigitalFlow/Xrm-Html-Templating/issues/2#issuecomment-441954366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQwSzAM0kSgBuRpTgX-88FWsM3Gz_opMks5uzOhMgaJpZM4YYYsP
.

--
Inviato da Gmail Mobile


toolkit: Increase usage of go code over makefile

This feature request is partly inspired by:

https://github.com/microsoft/CBL-Mariner/issues/2982
https://github.com/microsoft/CBL-Mariner/issues/6788

Is your feature request related to a problem? Please describe.
Our build logic exists both in Makefiles and Go, making it somewhat hard to maintain/develop. Makefile is currently used to store default configs, prepare/compile source files, etc. The Go tools on the other hand are only used as separate utilities for each build (sub)step. We could use the Go tools a bit more since it makes organizing and error-handling easier. Moreover, I personally find Go code easier to understand than some Makefile magic.
Describe the solution you'd like
I have been looking at alternatives for the CLI parser kingpin and found kong, which is developed by the same author. This library allows us to structure subcommands, flags using Go types and annotations. Config files of multiple formats are also supported so we can have dedicated files to store defaults config and ideally skip having to specify the command line flags whenever we run any build command. We can even have multiple default config files to use for each different build environment, e.g on a local dev machine vs on official build servers.
I have a demo PR where I refactor 2 of the Go tools, bldtracker and depsearch into 2 packages, and invoke them through a single CLI, as opposed to having 2 standalone programs:

https://github.com/microsoft/CBL-Mariner/pull/7237.

A sample config file is also included. This structure allows for both common and individual configs. With more refactor work like #6981, I can see how this library and structure will become useful.

Something to consider: we will need to handle tracking changes to files. This is a problem I'm bumped into from a few directions (specifically https://github.com/microsoft/CBL-Mariner/pull/6981). In that PR, I'd like to be able to cache toolchain artifacts, and invalidate those cached files if an input file has changed.
This feature will require a more general implementation, but if we get that then the toolchain cache will work fine. Ideally we can use real caching from online sources as well, but we will need a very robust mechanism to track changes.


Fix test method camel case

'ForpackageAutoload' is invalid camel-case.
By the way, do you think "checkWhetherPackageProvidesNamespace' is more clearly?

@xuanquynh I always name my tests after itShould... but I think we could name it itShouldProvideUsedNamespace smt like this.
And thanks for taking part 😉

@icanhazstring Sorry, I lost a change before pushing. I think using PHPUnit annotations at the top of method docblock is easier to read.


storage migration check error when deploying

When deploying with:
  --set-env-vars="GOOGLE_PROJECT=${PROJECT_ID},GOOGLE_STORAGE_BUCKET=${GCS_BUCKET_NAME}" \
deployment never completes for me and error is logged:
 "textPayload": "2020-12-18T01:45:05.526Z [WARN]  storage migration check error: error=\"failed to read value for \"core/migration\": googleapi: got HTTP response code 400 with body: <?xml version='1.0' encoding='UTF-8'?><Error>InvalidBucketName<Message>The specified bucket is not valid.</Message>Invalid bucket name: 'gs:'</Error>\"",
Deploying with the gs:// removed from the GOOGLE_STORAGE_BUCKET variable allows the deployment to succeed:
gcloud beta run deploy vault-server \
    --no-allow-unauthenticated \
    --concurrency 50 \
    --cpu 2 \
    --image gcr.io/hightowerlabs/vault:run \
    --memory '2G' \
    --min-instances 1 \
    --max-instances 1 \
    --platform managed \
    --port 8200 \
    --service-account ${SERVICE_ACCOUNT_EMAIL} \
    --set-env-vars="GOOGLE_PROJECT=${PROJECT_ID},GOOGLE_STORAGE_BUCKET=${GCS_BUCKET_NAME#'gs://'}" \
    --timeout 300 \
    --region us-west1

Same issue here

After looking at the bin/deploy script, I managed to fix the issue by removing the gs:// prefix from the GCS_BUCKET_NAME variable (and adding it manually when required).
So try deploying the new revision with:
gcloud beta run deploy vault-server \
  --no-allow-unauthenticated \
  --concurrency 50 \
  --cpu 2 \
  --image gcr.io/hightowerlabs/vault:run \
  --memory '2G' \
  --min-instances 1 \
  --max-instances 1 \
  --platform managed \
  --port 8200 \
  --service-account ${SERVICE_ACCOUNT_EMAIL} \
  --set-env-vars="GOOGLE_PROJECT=${PROJECT_ID},GOOGLE_STORAGE_BUCKET=${PROJECT_ID}-data" \
  --timeout 300 \
  --region us-west1

Note that the name of the buckets are not consistent between README.md and bin/deploy(...-data and ...-vault-data respectively).

@lvaylet thank you, that fixed the issue for me :)

Thanks @kevin-shelaga but @savageb1ts' solution requires less editing. I should have read his post entirely before offering a less optimal solution. I stopped reading after noticing I had the same issue... I submitted a PR anyway, just in case others run into the same issue.


window function postgres filter

Hi great author:)
Dialect

[ ] postgres
how make filter for this window function?, for example
SUM(adi.amount) FILTER (WHERE ad.document_status = 'pending') as unpaid_document_sum

Thanks Ales

You could put the whole thing in a literal
db.From("x").Select(goqu.L(SUM(adi.amount) FILTER (WHERE ad.document_status='pending'))).As("unpaid_document_sum")
SELECT SUM(adi.amount) FILTER (WHERE ad.document_status='pending')
FROM "x"


Support in-memory keypair.

Thanks for the writing this crate!
I happened to need this functionallity. This is tested only on Linux.
I took the idea for #[cfg(unix)] from the opened issue: https://github.com/alexcrichton/ssh2-rs/issues/77
Cheers,
Eldad

Thanks! Mind adding to the documentation that this is a unix only method?

Sure! I amended the commit with that right now.

Thanks!


click toggle element twice should set visibility to Off

Thanks for this nice library.
Environment

Select [0.1.12]

Current behavior
Currently, setToggleProps only have onFocus and onBlur.  Should add onClick handler, and perhaps onMouseDown/Up as well

@rnons Thanks for opening an issue!
You're right, it does seem more natural that clicking a toggle twice should close it. We have the ToggleVisibility query available for that, so we could have mouseDown events call that query.
Something like this ought to work:
setToggleProps = flip (<>)
  [ HE.onFocus $ HE.input CaptureFocus
  , HE.onKeyDown  $ HE.input Key
  , HE.onMouseDown $ HE.input_ ToggleVisibility
  , HE.onBlur $ HE.input_ $ SetVisibility Off
  , HP.tabIndex 0
  ]

@whoadave @crcornwell @foresttoney Unless you have other objections, I can implement this along with a toggle-driven example later today or tomorrow.

By the way -- if you need this behavior right now, you can always add it to the properties you're augmenting:
...
Setters.setToggleProps
  [ HP.class_ (HH.ClassName "my-class")
  , HE.onMouseDown $ HE.input_ Select.ToggleVisibility ]
...

@rnons Should be fixed in #21


Community Meeting February 14, 2024

Overview
At 10am Eastern, 7am Pacific, 2pm UTC; find your time
Video call link: https://meet.google.com/ved-ivnv-aen
dial-in: (US) +1<PHONE_NUMBER>
PIN: 873 550 579#
More phone numbers: tel.meet/ved-ivnv-aen?pin=7872592963542&hs=1
Add topics you'd like to discuss below!

Deprecating Tasks
Ref: https://issues.redhat.com/browse/EC-353
Metadata (annotations, labels) from TaskRuns in SLSA v1 provenance with https://tekton.dev/chains/v2/slsa-tekton build type. Annotations/labels are there for the PipelineRun, but not for TaskRuns, which is a shame as they are in SLSA v0.2.
So EC-353 is easy for SLSA v0.2, but it will fail for SLSA v1.0 with the current build type.
Alternatives include:

setting expires_on in the acceptable bundles, with the downside of that affecting all Tasks in the bundle.
extending acceptable bundles to include the Task deprecation data

Meeting recording: https://drive.google.com/file/d/1fmNqmEo5t2WwN-r2fFdHKIXDW_B0eQTg/view?usp=drive_link


To add a calculator for calculating vector joining two points

Is your feature request related to a problem? Please describe.
To add a calculator for calculating vector joining two points

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018

Go ahead
Deadline 24 May,2021


[master] Bump Mesos to nightly master fc0069b

High-level description
This is a routine bump to the latest Mesos and mesos-modules.
Related JIRA Issues
Checklist for all PRs

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Changelog:
https://github.com/apache/mesos/compare/270a3dce490d5b334f9a0011ea416ffc42e187e4...fc0069ba639cb82c6bebb9893dc67caef7d81b50
https://github.com/dcos/dcos-mesos-modules/compare/e9edd2d93d9fce88c8e3f5536c7f9abc326093d9...6c5189096804d37ee6640c446c0de1a3d80713a5

[ ] Test Results: [link to CI job test results for component]

[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

broken due to https://jira.mesosphere.com/browse/DCOS_OSS-5645


Create "About" dialog modal

This is another good first issue for newcomers 🔥🔥🔥

Motivation
Because this is an open source project, it would be great to give credit to whoever contribute to this project.
Description
Please make a dialog modal to show the About section of this project. If you don't know what dialog modal is, please check these examples.
The dialog modal would be something like this:

About

Winterly Tab is an open source chrome extension to beautifully change your new tab page with winter-themed background

Maintainer

Diky Hadna @dkhd

Contributors

Your name @username

Your name @username

Your name @username

continue the list ...

Github

[Close button]

Rules

Don't: do not use table (the table above just for layout guidance)
Don't: do not create new page, the dialog modal should be in the same page with the new tab page, it's dialog modal anyway
Do: only use TailwindCSS for styling
Do: replace the Winterly Tab by Diky Hadna at the right bottom screen (at the new tab page) with About without changing the current styling (the clickable text should be bolder than non-clickable text)
Do: If the About text clicked, it should open the dialog modal
Do: If [Close button] at the dialog modal is clicked, the dialog modal should be closed

If you have any question or want to work on this issue, drop your comment below so I can assign this to you 🎉🎉
Happy hacking!

@dddqwerty how about this? Do you want to work on this one?

I would like to work on this, can you please assign me this?

Hi @mani-rsg
I assign this issue to you 🔥🔥🔥
Happy hacking!

Hi @dkhd I would like to work on this repository, could you please open some more good first issue.

Hi @dhruvjain896 sure I will 🔥🔥
Also, if you have an idea, you can also post an issue and we can discuss together.

Hello, can i also work on this issue?

Hi @dkhd , I already created a PR with regards to this, you can assign this to me later :)

Closing as fixed in #13

@dkhd Can I still be working on this one?

You are correct :D
Salamat @dkhd


Bug in setting branch protection

PUT https://api.github.com/repos/dart-lang/dart-services/branches/master/protection: 422 Invalid request.

No subschema in "anyOf" matched.
More than one subschema in "oneOf" matched.
Not all subschemas of "allOf" matched.
For 'anyOf/1', {"strict"=>true, "contexts"=>["cla/google", "analyze (stable)"], "checks"=>[{"context"=>"cla/google"}, {"context"=>"analyze (stable)"}]} is not a null. []

Looks like it is not copying over the existing required checks? Not sure if related to #147 or not. Digging in.

Reproduced on my test repo:
PUT https://api.github.com/repos/jeffmendoza/test-settings/branches/main/protection: 422 Invalid request.

No subschema in "anyOf" matched.
More than one subschema in "oneOf" matched.
Not all subschemas of "allOf" matched.
For 'anyOf/1', {"strict"=>true, "contexts"=>["Inclusive Language"], "checks"=>[{"context"=>"Inclusive Language", "app_id"=>75645}]} is not a null. []


Handle null Constants.expoConfig and Constants.expoGoConfig

Goal
This PR builds on #143 which fixes a crash in configuration attempting to read a null Constants.expoGoConfig ( reported in #142)
The reported crash occurs because ExpoGoConfig is null in some circumstances, however the Expo docs state that both ExpoConfig and ExpoGoConfig could potentially be null, so this PR ensures guards are in place whenever either of those are accessed.

don't forget the changelog :D


[Honda Civic Hatchback 2019 FW] Add missing value for combinationMeter and programmedFuelInjection

Comma 2 often fails to recognize my Honda Civic Hatchback 2019 on the first car start (reverts to Dashcam mode). After 2-4 restarts of the car, C2 does recognize the car, and drives it well. Therefore, the "Unrecognized mode" does seem like a "fingerprinting" issue, since once C2 recognizes the car it works well.
Here is one attempt at fixing the issue: add the missing value for combinationMeter (78109-TGG-A220\x00\x00), as suggested in Discord.
However, I'm not sure this will work, because:

I notice that this value for Combination Meter appears for both carFingerprint = 'mock' (output) and carFingerprint = 'HONDA CIVIC HATCHBACK 2017 SEDAN/COUPE 2019' (output)  - so I suspect there are some other issues.
I cannot confirm that a unit test that fails to recognize my car, now passes with this change (see attempt: https://github.com/pviolette3/openpilot/commit/2a1367fa6137ba9fbc637c209f85212e18159fa2)

One other value that stands out to me is, my gateway value (38897-TBA-A020\x00\x00) shows up in both Ecu.unknown and Ecu.gateway. Is it possible this issue comes from OP incorrectly recognizing the "gateway" as Unknown in the unrecognized case?

An appendix (notes for me)
Part 1: Set up openpilot
(My setup is, Linux Mint)

Fork openpilot, clone fork into $HOME/openpilot (do not put subdir).
Run tools/ubuntu_setup.sh - fix various failure points
-> Need to install pyenv, and ensure it's on $PATH (something went wrong here the first time).
-> Pygames fails to install, I had to add these libraries: https://stackoverflow.com/questions/7652385/where-can-i-find-and-install-the-dependencies-for-pygame
-> Ensure that pip install -r tools/requirements.txt has worked correctly.

Part 2: Demonstrate failing test (this step is not achieved!)

Run python selfdrive/test/test_car_models.py - Ensure it passes with no changes. (A lot of Cython compiling happens on the first run)
Here was the output of a passing test:

(True, [])
.. 25 more lines
(True, [])
TEST SUCCESSFUL

Download the route file, on a run where the car was unrecognize. I downloaded: 5d02a73998def520_2020-05-03--16-09-07--0--rlog.bz2 from my.comma.ai (--0.rlog.bz2).
Hack the test to insert testdata (a/ Copy the routelog to /tmp/, b/ add to test_car_models.py , c/ run the test). Show that it fails. <- This step PASSES for me, so I'm unsure change will do anything. Please see my attempt here: https://github.com/pviolette3/openpilot/commit/2a1367fa6137ba9fbc637c209f85212e18159fa2

Part 3: Compare carParams for both working & not-working case.

Set up ssh.comma.ai (a/ upload github ssh keys, b/ add my user name in the Comma 2 UI as the user for SSH)
Find dongle ID (can find with my.comma.ai , or api.commadotai.com) (mine is: 5d02a73998def520)
a/ ensure comma2 is on (e.g. by turning on the car) b/ Run command suggested in ssh.comma.ai: ssh -i ~/.ssh/id_rsa -o ProxyCommand="ssh -i ~/.ssh/id_rsa -W %h:%p -p %p<EMAIL_ADDRESS>5d02a73998def520
Once ssh is working, dump the car params. PYTHONPATH=/data/openpilot python /data/openpilot/selfdrive/debug/dump.py carParams (it takes 1 min).
-> For my case, save the output when it's recognized (https://pastebin.com/V8mZwGcv) and unrecognized (https://pastebin.com/ZYQQzf8L)
-> Inspect the diff, to try to find the correct value.

What I did NOT need to do: Did not need to follow "Comma EON: Getting Connected With SSH", (No need to connect via Wifi, find the device IP address (such as with an IP scanner, or www.routerlogin.net))

Some more links:

Dongle ID: 5d02a73998def520
Route ID: 5d02a73998def520|2020-04-28--21-26-18--0
my.comma.ai link: https://my.comma.ai/5d02a73998def520/1588134378279/1588135263997
Canban link

Here is another example from last night (1st restart failed to recognize the car, 2nd restart successfully recognized the car). Note first segment did fail, and all subsequent segments did pass

Dongle ID: 5d02a73998def520
Route ID: 5d02a73998def520|2020-05-03--22-31-12--0
my.comma.ai link: https://my.comma.ai/5d02a73998def520/1588570271494/1588571087887#
Canban link

In the course of debugging, please feel free to find any of my drives' segments that are at the beginning of the drive, and have duration less than the expected 1m chunk. All of these will be examples of the "turn it off and turn it back on again" workaround.
Thanks for bearing with me; I'm being extra verbose because I have no idea what this code is doing :) I really appreciate the work from the Comma team!

Looking at the data I see two mismatches. Can you also add: b'37805-5AN-LF20\x00\x00' to Ecu.programmedFuelInjection. It shouldn't match for fingerprinting, but let's add if for completeness.

Good eye. Thank you. I have added the missing value for Ecu.programmedFuelInjection; ready for another look.

Good morning, Willem - I have confirmed this commit fixes my issue anecdotally, by cherry-picking this change onto 0.7.4 (see: https://github.com/pviolette3/openpilot/tree/release2), following instructions here.
After installing the CP'ed release, Open Pilot now recognizes my 2019 Honda Civic Hatchback on the first start (e.g. 5d02a73998def520|2020-05-06--09-35-51--0, CANBAN). Thanks for all the help! I will continue to let this bake on my vehicle, and report any issues (if any) here.
What is the process for upstreaming the change?


removing case_sensitive_units argument

Oops, I accidentally pushed direct to master. This pull request is to ensure some audit trail and trigger the pipeline.

Codecov Report

Merging #129 (c1cb9f8) into master (2743505) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   39.49%   39.49%
=======================================
  Files          50       50
  Lines       21410    21410
=======================================
  Hits         8456     8456
  Misses      12954    12954

Impacted Files
Coverage Δ

resqpy/well.py
33.25% <ø> (ø)

resqpy/model.py
62.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2743505...c1cb9f8. Read the comment docs.


class names are lost

in http://visionscarto.net/observable-jekyll/explore/2018/05/24/breakout.html the template has

but the runtime replaces .classtest by .observablehq
Expected behavior would be to add .observablehq (if that's feasible).

Good point, @Fil!
I've just released a notebook-inspector 1.1.1 that doesn't clobber existing classnames on the nodes that the inspector gets attached to.
Let me know if its still giving you any trouble.
https://github.com/observablehq/notebook-inspector/compare/v1.1.0...v1.1.1

Cool :) Tested it, but it doesn't look that the patch made it to
https://unpkg.com/@observablehq/notebook-runtime@1.1.2/dist/notebook-runtime.js?module
?
it still reads
if (!e) throw new Error("invalid node");this._node = e, e.className =
"observablehq";
and the github repo is not up-to-date either (still shows 1.1.0).

Correct. The runtime is still running inspector 1.1.0.

got it! yes it works when I do
  import {Runtime} from "https://unpkg.com/@observablehq/notebook-runtime@1.1.1?module";
  import {Inspector} from "https://unpkg.com/@observablehq/notebook-inspector@1.1.1?module";

thanks!


Pre-trained Weights

Hi Bin Li,
Thank you very much for such a thorough explanation of how everything works in the README! Also, thank you for making so many things public (representations, weights, and even some of the data).
Could you please explain which of the weights in the TCGA folder corresponds to which magnification? As I understand, one should be for the 5x and the other for the 20x magnification embedder network, but I do not understand which one is which.
Many thanks,
George

Those are all for high-mag. I uploaded low-mag weights to the same folder.


Spa per folder

Is it possible to have different spa's in different folders?
Eg
/test1/ is one self contained SPA
/test2/ is another self contained SPA

They are not linked in any way what so ever.

It's not currently possible with the built-in lws-spa module but you could fork that project and modify it to your taste.. there's a description of how to use and create middleware here,
Or, you could launch two separate ws servers - one for each SPA.. This may require you to reorganise your project slightly but it would be worth it, with better separation/re-use between the two projects.
The complexity in what you are requesting comes from the SPA redirect rules. E.g. if a user requests the path /user/1 then should ws redirect that request to /test1/spa.html or /test2/spa.html?

I would expect /user/1 to 404
But /test1/user/1 to go to /test1/index.html
And /test2/user/1 to go to /test2/index.html
The multi/server was something I had considered but didn't know how well that would work with https certs.
(New Territories for me)
And even the best way to proxy
/test1/user/1 goes to localhost:4331/user/1
And /test2/user/1 goes to localhost:4332/user/1
I will look into forking spa and quickly jump to redirect.
If I fail at redirect i will try harder at tweaking spa.

The multi/server was something I had considered but didn't know how well that would work with https certs.

ws --https will run on multiple ports..

/test1/user/1 goes to localhost:4331/user/1
And /test2/user/1 goes to localhost:4332/user/1

Maybe use lws-redirect for creating 302 Redirect responses if you need to direct the user to different servers..

I don't plan on making the other servers public if I go down the multiserver way. I want it to look like 1 server from the outside. So will prob proxy those folders to the internal servers.

@WORMSS did you find solution to this without writing tons of other files?


Review of rights model

Before implementation, review rights model to take into account 1) changes in community since it was originally drafted and 2) basic approach to access controls and rights in the chosen hydra head we are developing from.
Dependencies:

Samples of existing access controls in hydra head we will be building on.

@arwenhutt ijs this still relevant? If so, we should probably close and open a new ticket in horton.

@mcritchlow I think this has been taken care of as part of other tickets/work.  If we run into any other issues we can open new tickets to address them.


Added Tamal's portfolio

This is Tamal's Portfolio website made with very Basic HTML, CSS and Javascript language. This is made so that even beginners can learn and make Portfolio websites for themselves.

Sir, i have made the changes.