T022 - Ligand-based screening: Neural networks

Talktorial ID: 022

Title: Affinity prediction for EGFR
Original authors: Ahmed Atta
Reviewer(s): Sakshi Misra, Talia B. Kimber, Prof. Dr. Andrea Volkamer
Date of review: 12/2020-present

Content review

Potential labels or categories (e.g. machine learning, small molecules, online APIs): artificial neural network, scatter plot, keras model.
One line summary: Perform artificial neural network and predict the pIC50 values for unknown drug molecules.
[x] The table of contents reflects the talktorial story-line; order of #, ##, ### headers is correct
[x] URLs are linked with meaningful words, instead of pasting the URL directly or linking words like here.
[x] I have spell-checked the notebook
[x] Images have enough resolution to be rendered with quality, without being too heavy.
[x] All figures have a description
[x] Markdown cell content is still in-line with code cell output (whenever results are discussed)
[x] I have checked that cell outputs are not incredibly long (this applies also to DataFrames)
[x] Formatting looks correctly on the Sphinx render (bold, italics, figure placing)

Code review

Time it took to execute (approx.):
[x] Variable and function names follow snake case rules (e.g. a_variable_name vs aVariableName)
[x] Spacing follows PEP8 (run Black on the code cells if needed)
[x] Code line are under 99 characters each (run black -l 99)
[x] Comments are useful and well placed
[x] There are no unpythonic idioms like for i in range(len(list)) (see slides)
[x] All 3rd party dependencies are listed at the top of the notebook
[x] I have marked all code cell with output referenced in markdown cells with the label # TODO: CI
[x] I have identified potential candidates for a code refactor / useful functions
[x] All import ... lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*)
[x] I have update the relative paths to absolute paths.
List here unfamiliar libraries you find in the imports and their intended use:

@sakshimisra  - your talktorial's final index will be T022. Could you please at some point update this PR according to that (let me know if you need help)?

Hi @sakshimisra !
The notebook is looking good. Here are a few comments to be addressed before asking for Andrea for final review:

Please keep the structure of the template directory: https://github.com/volkamerlab/teachopencadd/tree/sm-021-review/teachopencadd/talktorials/000_template

README was deleted (it will be completed automatically, so no need to populate it).
all the generated or used data should live in the data folder
README in the data should be completed (by hand).

The sections "What is a neural network?", "Basic structure of a neural network", "What does a neuron do ?" are a bit redundant (and the figures as well: having one figure would suffice). Maybe you could have one section only which gives the general idea of the NN (mimics a human brain etc.) and then directly go into details with notations.

Double check your explanation for SGD and Mini-Batch Gradient Descent, it seems there might be confusion.

"Fault tolerance: They have potential for high fault tolerance. When these networks are scaled across multiple machines and multiple servers, they can debug and diagnose the problem by its own." I'm not too sure about this statement. Do you have a reference?

Naming should be more explicit (e.g. "my_model" ?)

There are some # NBVAL_CHECK_OUTPUT missing when printing outputs.

The notebook is running fine up until model = load_model("my_model") but there are errors with this folder.

Hi @sakshimisra !
The notebook is looking good. Here are a few comments to be addressed before asking for Andrea for final review:

Please keep the structure of the template directory: https://github.com/volkamerlab/teachopencadd/tree/sm-021-review/teachopencadd/talktorials/000_template

README was deleted (it will be completed automatically, so no need to populate it).
all the generated or used data should live in the data folder
README in the data should be completed (by hand).

The sections "What is a neural network?", "Basic structure of a neural network", "What does a neuron do ?" are a bit redundant (and the figures as well: having one figure would suffice). Maybe you could have one section only which gives the general idea of the NN (mimics a human brain etc.) and then directly go into details with notations.

Double check your explanation for SGD and Mini-Batch Gradient Descent, it seems there might be confusion.

"Fault tolerance: They have potential for high fault tolerance. When these networks are scaled across multiple machines and multiple servers, they can debug and diagnose the problem by its own." I'm not too sure about this statement. Do you have a reference?

Naming should be more explicit (e.g. "my_model" ?)

There are some # NBVAL_CHECK_OUTPUT missing when printing outputs.

The notebook is running fine up until model = load_model("my_model") but there are errors with this folder.

Hi @AndreaVolkamer, thank you for your feedback :)

Hi @AndreaVolkamer, thank you for your feedback :)

Thanks for the excellent work here @sakshimisra!


model.model_dump() 'include' option should take precedence over 'exclude_defaults' option

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
model_dump method should always include fields if they listed in 'include' option as it is more specific then exclude_defaults, exclude_unset and exclude_none.
(to decide about include vs explicit is also important, but this is topic for another issue)
Example Code
from pydantic import BaseModel

class Test(BaseModel):
    a: int = 0
    b: str = "b"

test = Test()
print(test.model_dump(exclude_defaults=True, include={"a"}))

# Output: {}
# Expected: {'a': 0}

Python, Pydantic & OS Version
❯ python -c "import pydantic.version; print(pydantic.version.version_info())"                                                                                ─╯
             pydantic version: 2.6.3
        pydantic-core version: 2.16.3
          pydantic-core build: profile=release pgo=true
                 install path: /home/tmax/development/badatz-monorepo/venv311/lib/python3.11/site-packages/pydantic
               python version: 3.11.8 (main, Feb 25 2024, 16:41:26) [GCC 9.4.0]
                     platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31
             related packages: typing_extensions-4.10.0
                       commit: unknown

@tmax22,
Thanks for the feature request. In general, I agree with your logic here. We can't change this in a minor version, due to the breaking nature of the change, but I've tagged this with the V3 label so that we can revisit this down the line :).

actually, I did not understand properly the include property properly. I thought that include is there in case property was excluded though to exclude_defaults, exclude_unset and exclude_none.
Clearly this is not the case, if you specify include, it includes ONLY the items that were specified. this is unintuitive and not clear from the docs. it should be named include_only.

@tmax22,
I understand the confusion. I think there's still some debate about how the various include vs exclude properties should interact with eachother that we should resolve with docs clarification + potentially some changes in V3.


Don't import Dask when Panel serving an app

Dask is imported when running the following:
import sys
import panel as pn
pn.panel("dask" in sys.modules).servable()

The import is happening here:
https://github.com/holoviz/lumen/blob/af86b044345b5b087689c63fe735f3504ebb6d6b/lumen/sources/base.py#L38
Where Lumen is called in Panel here:
https://github.com/holoviz/panel/blob/86a05a3c080d5cd39af7280793db8e6cd42a3783/panel/io/rest.py#L182

Running python -X importtime -c "import panel.io.rest" 2> log.txt && tuna log.txt I can see that lumen uses around half of the import time.


a question

protected bool _remove(RedBlackTreeNode nodeToDelete)
{
if (nodeToDelete == null)
return false;
        // Temporary nodes
        RedBlackTreeNode<TKey> node1, node2;

        // If nodeToDelete has either one child or no children at all
        if (!nodeToDelete.HasLeftChild || !nodeToDelete.HasRightChild)
        {
            node1 = nodeToDelete;
        }
        else
        {
            // nodeToDelete has two children
            node1 = (RedBlackTreeNode<TKey>)base._findNextLarger(nodeToDelete);//why is _findNextLarger
        }

        // Left child case
        if (node1.HasLeftChild)
        {
            node2 = node1.LeftChild;
        }
        else
        {
            node2 = node1.RightChild;
        }

        // If node2 is not null, copy parent references
        if (node2 != null)
            node2.Parent = node1.Parent;

        if (node1.Parent != null)
        {
            if (node1.IsLeftChild)
            {
                node1.Parent.LeftChild = node2;
            }
            else
            {
                node1.Parent.RightChild = node2;
            }
        }
        else
        {
            Root = node2;
            Root.Parent = null;
        }

        // Swap values
        if (!node1.IsEqualTo(nodeToDelete))
        {
            nodeToDelete.Value = node1.Value;
        }

        // Adjust the Red-Black Tree rules
        if (node1.Color == RedBlackTreeColors.Black && node2 != null)
        {
            _adjustTreeAfterRemoval(node2);
            Root.Color = RedBlackTreeColors.Black;
        }

        // Decrement the count
        base._count--;

        return true;
    }

node1 = (RedBlackTreeNode)base._findNextLarger(nodeToDelete);  in this code why is find larger but not find smaller.
https://www.cs.usfca.edu/~galles/visualization/RedBlack.html      this  link  shows the process of delete a note,and it process is find a smaller note but not larger note
which is right?

Hello @hwgeone,
Sorry for the late reply. When deleting a tree node that has children it we need to rebalance that branch after deletion, as that node could be linking to a big sub-tree and not just leaf nodes. Regardless of the size of the subtree that the delete operation will mutate, we need to find the next larger element in that subtree in order to find the new root for that subtree, this doesn't mean that we will end up with the largest number in the entire subtree but the next bigger one after the one we're deleting. When we find it we will mark it as the new root of the subtree and then try to re-balance the tree around it.
I hope this makes it clearer for you.
Cheers,
Ahmad

Hello @hwgeone,
I will close the issue for now, if you think this is really a bug, please reopen it with, preferably, a failing unit test to prove that there is a bug.
Cheers,
Ahmad


[Bug]:  Auto commit and push stops working nearly everyday

Describe the bug
I often notice that there has been no update from the plugin for a while and I see that its last Git update was hours ago. So I have to disable and enable the plugin for to resume normal operation. This wasn't the case when I initially installed the plugin but it's been happening for a few months now.
I have included the error I found from the logs.
The screenshot below shows the error go away after toggling the disable plugin button and the app proceeds to commit and push changes I made over 24 hours ago. I hope this is descriptive enough.
Thanks.

Relevant errors (if available)
git obsidian error: Connection reset by <IP_ADDRESS> port 22
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

VM148 plugin:obsidian-git:23985 Uncaught (in promise) Error: Connection reset by <IP_ADDRESS> port 22
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

    at Object.action (plugin:obsidian-git:23985:25)
    at PluginStore.exec (plugin:obsidian-git:24010:25)
    at eval (plugin:obsidian-git:21571:43)
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (plugin:obsidian-git:21569:16)
    at GitExecutorChain.eval (plugin:obsidian-git:21553:44)
    at Generator.next (<anonymous>)
    at fulfilled (plugin:obsidian-git:20402:24)

Steps to reproduce
It just happens.
Expected Behavior
I expect it to work consistently to back up changes.
Addition context
No response
Operating system
macOS
Installation Method
None
Plugin version
2.17.4

Have the same issue on multiple macs. Started happening with the latest version. It is constantly committing 0 files.  The issue is only with the auto-commit/push. Manual still works fine.

@Wit4r7 So your issue is not authentication when pushing, but committing of zero files? Then this is probably a different issue. Is just the notification wrong or do you really have empty commits, which I really doubt, because git doesn't allow that by default.

@Vinzent03 Yeah it is committing zero files. I downgraded and updated again. Currently, I'm unable to reproduce the error, but I'm also not on my main pc. If the error occurs again, I will create a new ticket and provide additional information.

Have the same issue on multiple macs. Started happening with the latest version. It is constantly committing 0 files.  The issue is only with the auto-commit/push. Manual still works fine.

Interesting. I noticed it also happens after the laptop has been put to sleep for a while.
The file changes counter remains at zero and it says the last Git update was a while ago (it just happened some mins ago and last Git update was 19 hours ago). It's like it stopped checking for changes and didn't resume even after the laptop was woken.

I've also encountered this issue, it stops syncing after the laptop has returned from sleep.


Missing entries in "msdb.dbo.backupset" for user databases in an AG

Hey Ola,
hope you are doing fine :)
So my problem is that our monitoring system "Checkmk" is not able to determine the date & time of user databases that are in an AG because there are no corresponding entries in the "msdb.dbo.backupset" table after the Full- and Log backup jobs ran.
Backup preference for the AG is set to "Prefer Secondary".
When I run the selects that are being executed via the monitoring system I get the following results:
PRIMARY NODE:
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-13 12:07:57	D	COBSVSQLAAG01	True	1
2022-04-24 07:45:01	L	COBSVSQLAAG01	True	1
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-27 04:45:00	D	COBSVSQLAAG01	0	NULL
2022-04-27 04:45:01	D	COBSVSQLAAG01	0	NULL
2022-04-27 04:45:02	D	COBSVSQLAAG01	0	NULL
2022-04-13 12:07:57	D	COBSVSQLAAG01	1	1	7BA734C9-BA78-4318-8B62-7FA215725BB6
2022-04-24 07:45:01	L	COBSVSQLAAG01	1	1	7BA734C9-BA78-4318-8B62-7FA215725BB6
SECONDARY NODE:
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-27 05:00:01	D	COBSVSQLAAG02	True	1
2022-04-27 11:00:01	L	COBSVSQLAAG02	True	1
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-27 04:45:01	D	COBSVSQLAAG02	0	NULL
2022-04-27 04:45:02	D	COBSVSQLAAG02	0	NULL
2022-04-27 04:45:02	D	COBSVSQLAAG02	0	NULL
The entries for the time 04:45 a.m. are for the full backups of the system databases.
FULL backups of the user database are created every day at 05:00 a.m.
LOG backups of the user database are created every 15 minutes.
The first two entries for the first select from the PRIMARY NODE are probably from a manual failover where it became the secondary node, thus creating the backups from this one because of the "Prefer Secondary" value.
Same goes for the last two entries in the secondary select for the PRIMARY NODE.
The first two entries for the first select from the SECONDARY NODE show Full and Log backups correctly, but they are completely missing from the secondary select and that is what I am assuming my main problem.
As for comparison, this is what it looks like on a SQL instance with no AG:
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-27 09:00:13	I	COBSVBDESQL01	True	1
2022-04-27 11:15:00	L	COBSVBDESQL01	True	1
2022-04-27 04:45:02	D	COBSVBDESQL01	True	1
last_backup_date	type	machine_name	is_primary_replica	is_local	replica_id
2022-04-27 03:21:44	D	COBSVBDESQL01	0	NULL
2022-04-27 04:45:00	D	COBSVBDESQL01	0	NULL
2022-04-27 04:45:01	D	COBSVBDESQL01	0	NULL
2022-04-27 04:45:02	D	COBSVBDESQL01	0	NULL
2022-04-27 09:00:13	I	COBSVBDESQL01	0	NULL
2022-04-27 11:15:00	L	COBSVBDESQL01	0	NULL
The select statements are as follows:
--HADRStatus IS NULL OR HADRStatus <> 1
SELECT CONVERT(VARCHAR, DATEADD(s, DATEDIFF(s, '19700101', MAX(backup_finish_date)), '19700101'), 120) AS last_backup_date,
type, machine_name, 'True' as is_primary_replica, '1' as is_local, '' as replica_id FROM msdb.dbo.backupset
WHERE machine_name = SERVERPROPERTY('Machinename')
GROUP BY type, machine_name
--HADRStatus = 1
SELECT CONVERT(VARCHAR, DATEADD(s, DATEDIFF(s, '19700101', MAX(b.backup_finish_date)), '19700101'), 120) AS last_backup_date,
b.type, b.machine_name, isnull(rep.is_primary_replica,0) as is_primary_replica, rep.is_local, isnull(convert(varchar(40), rep.replica_id), '') AS replica_id
FROM msdb.dbo.backupset b
LEFT OUTER JOIN sys.databases db ON b.database_name = db.name
LEFT OUTER JOIN sys.dm_hadr_database_replica_states rep ON db.database_id = rep.database_id
WHERE (rep.is_local is null or rep.is_local = 1)
AND (rep.is_primary_replica is null or rep.is_primary_replica = 'True') and machine_name = SERVERPROPERTY('Machinename')
GROUP BY type, rep.replica_id, rep.is_primary_replica, rep.is_local, b.database_name, b.machine_name, rep.synchronization_state, rep.synchronization_health
SQL Server version and edition
Microsoft SQL Server 2019 (RTM-CU15) (KB5008996) - 15.0.4198.2 (X64) - Enterprise Edition: Core-based Licensing (64-bit) on Windows Server 2022 Standard 10.0  (Build 20348: ) (Hypervisor) => same issue on Windows Server 2019 Standard with SQL Server 2019 Enterprise Edition
Version of the script
2022-01-02 13:58:13
What command are you executing?
EXECUTE [dbo].[DatabaseBackup]
@Databases = 'USER_DATABASES',
@Directory = NULL,
@BackupType = 'FULL',
@Verify = 'Y',
@CleanupTime = 47,
@CheckSum = 'Y',
@LogToTable = 'Y',
@CopyOnly='Y'
...and...
EXECUTE [dbo].[DatabaseBackup]
@Databases = 'USER_DATABASES',
@Directory = NULL,
@BackupType = 'LOG',
@Verify = 'Y',
@CleanupTime = 47,
@CheckSum = 'Y',
@LogToTable = 'Y',
@ChangeBackupType = 'Y'
What output are you getting?
See statements above.
Side note: Full- and Log-Backups are created all created successfully on the file system, but as I described before, I am missing the entries in the "msdb.dbo.backupset" table. Log entries for backup jobs where the databases are NOT running in an AAG are all working perfectly fine.
Unfortunately, altering the selects of the script executed from the monitoring system won't be that easy because it is implemented in their standard rollout.
Thanks in advance for your help :)
Greetings from Germany
Dennis

Hi Ola,
still having the issue. Any help or advice would help tremendously.
Thanks again in advance
Dennis

I would suggest you capture the backup_restore_progress_trace Extended Event (see https://techcommunity.microsoft.com/t5/sql-server-blog/new-extended-event-to-track-backup-and-restore-progress/ba-p/384447 for more details) as it captures the part where the back history is attempted to be written and potential reasons why that step failed.

pbarryuk

Hi pbarryuk,
Thanks for your reply.
Unfortunately, as I wrote in my original post, altering the selects of the script executed from the monitoring system won't be that easy because it is implemented in their standard rollout and we are using this one for hundreds of systems.
Regards
Dennis

Sorry if it wasn’t clear , I wasn’t suggesting changing the selects of the monitoring system. I was suggesting that you capture the xEvent for backups as there are entries of that xEvent that are fired when the backup tries to write the backup history to msdb and if it was successful or not or, if it was not successful, then it can give you an idea of why (e.g. could not obtain an update lock). As you mentioned there were no records in msdb this is to get to the root cause of the issue - it is outside of the Ola H scripts as backup history is a SQL Server activity.
Otherwise, if you have a support contract with Microsoft then open a case with them for them to help in the investigation.

Hi pbarryuk,
maybe I was writing your first reply not clearly enough. Yesterday was my first day back from the holidays and there was so much work on the table :D
I'll try your suggestions now.
Thanks again.
Regards
Dennis

The writes to msdb.dbo.backupset are happening inside the native BACKUP DATABASE and BACKUP LOG commands.
If the entries in msdb.dbo.backupset are missing, that is indicating that the backups did not take place on that replica.
It could also happen that the entries in msdb.dbo.backupset have been cleaned up.


VSCode performance issue (seems like something is leaking)

VSCode Version: 1.43.2
OS Version: Windows 10 (fully patched)

Steps to Reproduce:

Work for a while. The project I am working on has a couple hundred files (in C++), which seems large to me, but my guess is that is nothing compared to other projects at Microsoft. I am working in C++. As I work for a couple of hours, a lag begins to develop with each key pressed. At some times this lag can be as high as 1 second.
The "on fire" icon is not showing when this performance issue occurs, so as far as VSCode is concerned, its not working hard.
If I close out of VSCode and reopen it (basically restart the app... not refresh it), the problem goes away for a couple of hours. But once again, as I work it tends to develop over the course of a couple of hours so I have to restart the app a couple of times a day.

WRT to my hardware, I an running on an AMD 3990x with 256GB of RAM, so I don't think its a resource issue with my hardware.

Does this issue occur when all extensions are disabled?: Have not tried, but I am not running a lot of extensions. I need some extensions to work just to get work done like C++, Auto Comment Blocks, Settings Sync and Spell Checker. I have disabled everything else including themes to verify.

/needsMoreInfo
Please use this guide to provide more information: https://github.com/Microsoft/vscode/wiki/Performance-Issues. Thanks.

I worked with this for several days with most of the extensions disabled and the problem is gone, so it must be an extension issue.


Can Bluetooth low energy use MTU?

Hello!
Using Windows development Bluetooth tools to interact with Bluetooth low energy devices for data interaction, can I interact with MTU to complete the interaction of large data packets?

This appears to be a question about the feature itself, not a question about the sample. You can follow the instructions on Windows developer support for support options. (Click "Microsot Q&A".)


docs: Documentation on setting up Cypress out-of-sync/incorrent

It seems the Cypress section of the fCC docs are outdated/incorrect. I was trying set it up but all of the commands described in the docs have problems and throws errors.
The pnpm run cypress:dev:run command fails a few tests.
The pnpm run cypress:prd:run command mentioned in the doc doesn't even exist.
The command to run a specific test described in the doc pnpm run cypress -- run --spec=cypress/e2e/default/landing.ts does not work.

This is what I see:
<--- Last few GCs --->

[5598:0x6b32000]   471706 ms: Mark-sweep 4970.2 (5046.9) -> 4965.6 (5047.4) MB, 272.2 / 0.0 ms  (average mu = 0.343, current mu = 0.028) allocation failure; scavenge might not succeed
[5598:0x6b32000]   471979 ms: Mark-sweep 4970.1 (5049.4) -> 4967.6 (5048.9) MB, 269.3 / 0.0 ms  (average mu = 0.210, current mu = 0.014) allocation failure; scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb7b3f0 node::Abort() [/home/shauh/.nvm/versions/node/v18.14.2/bin/node]

But, I cannot then explain why CI is passing, unless this is device specific.

The command to run a specific test described in the doc pnpm run cypress -- run --spec=cypress/e2e/default/landing.ts does not work.

Looks like this is pnpm specific, and needs to be pnpm run cypress run --spec=...

This is what I see:
<--- Last few GCs --->

[5598:0x6b32000]   471706 ms: Mark-sweep 4970.2 (5046.9) -> 4965.6 (5047.4) MB, 272.2 / 0.0 ms  (average mu = 0.343, current mu = 0.028) allocation failure; scavenge might not succeed
[5598:0x6b32000]   471979 ms: Mark-sweep 4970.1 (5049.4) -> 4967.6 (5048.9) MB, 269.3 / 0.0 ms  (average mu = 0.210, current mu = 0.014) allocation failure; scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0xb7b3f0 node::Abort() [/home/shauh/.nvm/versions/node/v18.14.2/bin/node]

But, I cannot then explain why CI is passing, unless this is device specific.

Yeah... I got that too. Btw... I'm on -

Ubuntu 23.04
Node v18.13.0
pnpm 8.6.7

The command to run a specific test described in the doc pnpm run cypress -- run --spec=cypress/e2e/default/landing.ts does not work.

Looks like this is pnpm specific, and needs to be pnpm run cypress run --spec=...

I looked up the Cypress docs before and they said to use exactly what you did but with npx instead of pnpm. Is there any reason behind using pnpm?

Is there any reason behind using pnpm?

I keep forgetting why we changed, but, if I correctly recall, npm handled our mono-repo in a bad way for different versions of React (node_modules were not set up nicely).
@ojeytonwilliams Could you please confirm/elaborate? I might actually write the reason down, this time.

There were two main motivations for switching to pnpm.
Firstly, it provides better isolation of the workspaces because it does not hoist all of the dependencies into the root. That means each workspace has to declare the dependencies it needs, rather than relying another workspace's dependencies.
Secondly, and less importantly, it's way faster.
Anyways, for the question at hand, it should not make any difference if you use pnpm cypress, pnpm run cypress or npx cypress. They all end up calling the cypress script in node_modules/.bin/cypress.
Honestly I'm not sure why Cypress eats so much memory, but it does. Or, at the very least, running it and pnpm run develop at the same time needs a lot of memory (I've not dug into which is the culprit, though I suspect it's our client or Gatsby). I have 16GB of ram and still run into issues occasionally, so the fact you're running into problems with 5 (6?) isn't surprising.
Unfortunately, until we know what the underlying issue is or (if it's the client) migrate to a different framework, there's not a lot you can do. Sorry about that!

so the fact you're running into problems with 5 (6?) isn't surprising.

I have 24

The client is dying - Cypress is killing it.

Honestly I'm not sure why Cypress eats so much memory, but it does. Or, at the very least, running it and pnpm run develop at the same time needs a lot of memory (I've not dug into which is the culprit, though I suspect it's our client or Gatsby).

@ojeytonwilliams I've observed this previously when I was writing tests with Cypress. There is some sort of memory leak somewhere because I used to use Cypress to watch for changes and reload. I used to have only 8 GB of memory back then and every single time it reloaded, I could clearly see an increase in memory consumption and this memory would not get freed and kept on accumulating. After a few refreshes, I had to cntr + c and terminate the command and restart it. However, I do have to admit, I am not entirely sure where this memory leak is happening. But this memory leak was there from the very beginning, that's absolutely clear.

I have 16GB of ram and still run into issues occasionally, so the fact you're running into problems with 5 (6?) isn't surprising.

@ojeytonwilliams Just to clarify, I have 16GB  of RAM and still ran into the same issue. I'll see if I can reproduce it.

Thanks, @Twaha-Rahman. It's good to know this has been a problem for a while. So, you saw the leaks whenever Cypress reloaded?
Anyways, it's possible to up the amount of memory a node process uses (Cypress or the client) and I think that will have to be the solution for now.

It's really bad, @Twaha-Rahman. I tried upping the memory too and encountered the same problems you did.
The only thing that I could do to get a full run to complete was to build and serve the client first:
pnpm run build
pnpm run serve:client

You can get away with pnpm cypress:dev:watch for a bit if the client is in development mode, but not long :(
I'm not sure what the best advice is, though. If you're just running a few tests probably increase the memory and hope for the best? I'm not sure.

@ojeytonwilliams  I just tried your commands and all but 9 tests pass. It isn't clear from your reply so I'll need ask this to clarify: Did all the tests pass on your side?
For anybody who's following this issue, here's what I ran (In order) ->
Terminal no. 1:
pnpm run build
pnpm run serve:client

Terminal no. 2:
cd api-server && pnpm run start

Terminal no. 3:
npx cypress run --browser chrome

Did all the tests pass on your side?

No, there's more that needs to be done before all the tests can pass. We use https://github.com/freeCodeCamp/client-config/blob/master/serve.json to handle some redirects and without that config those tests will fail. That file needs to be in client/public/serve.json and then you can run pnpm run start-ci instead of start.
If you're curious the full set of working steps can be found in the workflow https://github.com/freeCodeCamp/freeCodeCamp/blob/main/.github/workflows/e2e-web.yml and we know that works because it runs all the time.

@ojeytonwilliams You are right. After following your steps, only these two tests fail.

For anybody who's following this issue, here's what I ran (In order) ->
First, I copied serve.json and pasted it in client/public.
(Get the serve.json file from here)
Terminal no. 1:
pnpm run build
pnpm run start-ci

Terminal no. 2:
npx cypress run --browser chrome

Ah, sorry @Twaha-Rahman, I forgot about email.  The workflow sets up mailhog to catch the requests:
https://github.com/freeCodeCamp/freeCodeCamp/blob/10eb1d9630ec2170e9a2ba5a698581a8845cb498/.github/workflows/e2e-web.yml#L90-L93
We have some docs on that, too: https://contribute.freecodecamp.org/#/how-to-catch-outgoing-emails-locally?id=installing-mailhog
I'm pretty sure that's it, but the tests are flaky and even if everything is set up correctly they can randomly fail.

We will be moving away from Cypress soon


Instantaneous execution of getters

Blocked by https://github.com/integritee-network/worker/issues/459
According to the Idea of @brenzi, respective my understanding of it:
Two solution possibility:

Caching of state. The getters can read the state directly from the cache.
Keep one state that will not be written on. While block production, the state is copied and the calls are executed on this copy-state. Once the state diff is created, that copy can be released. For block import, the state can be copied again (if that makes sense), diff applied, and once successful, the original state can be overwritten with memcopy.

@mullefel What do you think about these approaches?

Just for clarification: Sidechain block proposal does not acquire a write-lock, only a read lock. It is on block import that we need a write lock to write the proposed changes. That is the only time when getters are blocked, and it should be quite brief. However, if for our use case that is already too long, then we should keep a second copy of the state, to never block getters.

I think that sounds reasonable 👍
Two remarks:

The TOP pool does not play any part in the getter execution anymore

All dependencies and functions related to the RPC responder can be removed

Top pool still needs to be able to send status reports for calls. So I don't think it's "all".

Change RPC interface, getters must now use the state_get RPC function

Why state_get ? I believe we should stay close to substrate naming conventions (see https://polkadot.js.org/docs/substrate/rpc/)
Substrate does not have the concept of Getter (no signature necessary), but since it's something like an extrinsic, should it not be something close to author_submitGetter or state_submitGetter?

The TOP pool does not play any part in the getter execution anymore

All dependencies and functions related to the RPC responder can be removed

Top pool still needs to be able to send status reports for calls. So I don't think it's "all".

Yes, maybe it won't be all, but as far as I can tell, there are a couple of functions and dependencies related to sending state updates, that are only used for getters.

Change RPC interface, getters must now use the state_get RPC function

Why state_get ? I believe we should stay close to substrate naming conventions (see https://polkadot.js.org/docs/substrate/rpc/) Substrate does not have the concept of Getter (no signature necessary), but since it's something like an extrinsic, should it not be something close to author_submitGetter or state_submitGetter?

Someone at some point chose state_get. I don't really have a strong opinion here, so we can discuss the name.


App settings were updated.

Gradle & Dependencies settings were updated.
Code reformat was made.

Thanks for the contribution @halilozel1903 🙏

You're welcome 😊 @mertceyhan


Toggle between custom layouts

Description of the new feature / enhancement
The new feature (which I don't believe exists yet) would switch between 2 custom layouts that are on a single screen.  If, for instance, you had a 4x4 grid of zones that fit comfortably on your screen with applications designated for each one, but you had some number of additional zones (let's say a 2x2) each with an app/view designated to it, that you wanted to display/access, you could use a single toggle to efficiently switch from the 4x4 to the 2x2, or vice versa.
Scenario when this would be used?
Currently I have to toggle between 6 zones (4 visible and 2 open in the background in a split screen... on a single screen).  This is a lot of toggling to go from seeing my primary 4x4 to see only the 2x2 and then go back to the 4x4.  If you could toggle at a layer level, or a screen visibility level, it would only be one toggle to see the hidden layer and one toggle to get back to the primary layer.
Supporting information
I hope I explained it okay.  I don't have additional evidence, but it seem in line with the philosophy of FancyZones -- to access information faster.

It sounds like you want to use Virtual Desktops. Why should this feature to swap between a 4x4 layout of apps or a 2x2 layout be a FancyZones feature? /needinfo

Had never used the v desktop. That combo works pretty well.  Thanks for noting.


chore: upgrade charts

updated chart jxgh/vault-instance from 1.0.20 to 1.0.21

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajdavies
You can assign the PR to them by writing /assign @rajdavies in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
2f1c54c8666d34d5a4484e54f9994f3e506f4065
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Fix #2342, and updates for Poetry 1.2

Closes: #2342
What's Changed

Poetry 1.2.0 is released now

It has an underdocumented behavior change that poetry install --extras ... followed by poetry install (without any --extras) will result in Poetry removing the previously installed extras.

Change our install of Nautobot itself in the dev image to account for this change
poetry install --no-dev is deprecated in favor of poetry install --only main, so I've made that change.
Add poetry cache clear --all PyPI to the final-dev image build, fixing #2342 (with a workaround for a couple of Poetry bugs)

Weird, hadolint passes locally. Wonder if I have an old version or something. Will fix when I get time.

Actually it's the other way around - CI is using hadolint 2.7 but a locally built dev image has hadolint 2.10. Fails regardless when I run it locally against the actual branch in question 🤦

Poetry 1.2.0 is released now

It has an underdocumented behavior change that poetry install --extras ... followed by poetry install (without any --extras) will result in Poetry removing the previously installed extras.

Change our install of Nautobot itself in the dev image to account for this change

This seems to be a necessary fix as when we ship a new image we'll probably bring in Poetry 1.2 and plugin's development/testing images won't include the necessary dev dependencies at runtime: https://github.com/nautobot/nautobot-plugin-golden-config/blob/develop/development/Dockerfile#L42

Does the poetry installer at https://install.python-poetry.org/ support constraining the version with >=1.2.0 and if so should we add that constraint as part of this change? I know the installer says it will install the latest version so this may not be an issue?

It does always install the latest version by default. We could (and probably should) constrain it with the --version argument so that it will use a specific version until we intentionally move to a newer one though.

It does always install the latest version by default. We could (and probably should) constrain it with the --version argument so that it will use a specific version until we intentionally move to a newer one though.

This is how most plugins are installing Poetry: https://github.com/networktocode/gh-action-setup-poetry-environment/blob/main/action.yml

This is how most plugins are installing Poetry: https://github.com/networktocode/gh-action-setup-poetry-environment/blob/main/action.yml

Sure, though that's a virtualenv workflow, not a Docker workflow.
I've added an explicit --version 1.2.0 to the install-poetry command so that we can migrate to newer versions on our own schedule rather than immediately upon release.


update stories include angular material

Versions.
angular 4.0
Wiki documentation
include angular material should be update,  css-loader failing finding relative url, in the story are using
@import<EMAIL_ADDRESS>and should be replace by this
@import<EMAIL_ADDRESS>here the issue an the solution  #5026

PR with fix #5963 just waiting to be merged in.

Fixed via https://github.com/angular/angular-cli/pull/5963


Update extract.py

One line 301. cipher key is no longer existed in formats.  Its turned to signatureCipher. So a minute edit

Thank you, you are a life saver, hope this gets updated soon.

Worked for me!! Very Quick fix, Thank you!

Welcome😍😄❤
On Thu, Jun 4, 2020, 6:44 AM xXSlothaiXx<EMAIL_ADDRESS>wrote:

Worked for me!! Very Quick fix, Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nficano/pytube/pull/644#issuecomment-638541678, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBQLJSE6GV6FRLY5ZCTGCTRU3YNRANCNFSM4NOXA2ZA
.

This still doesn't work for me. I changed the file. Still the same error.

Works for me too, thanks for the patch! 😄

Would it be appropriate to replace
parse_qs(formats[i]["signatureCipher"]) for i, data in enumerate(formats)
with
parse_qs(data["signatureCipher"]) for data in formats
? I'm thinking there might be a consistency-based reason for the former?

Would it be appropriate to replace
parse_qs(formats[i]["signatureCipher"]) for i, data in enumerate(formats)
with
parse_qs(data["signatureCipher"]) for data in formats
? I'm thinking there might be a consistency-based reason for the former?

Yep, look cleaner and a bit more pythonic to me 😉

well, that's the downside of open software not backed by any companies/organizations :/ @to7m did you volunteer?

I didn't. I guess I will if no-one else does, but as I've never handled a pull request in my life, I'm hoping someone else has...
This patch shows that it should be community-maintainable to some extent without active development at least!

it worked for me thank you so much!!

Issue seems to be fixed already -- please re-open if this isn't the case :)


Error on Android: MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner)

On Android 14 I get an error when trying to open the SimpleBarcodeScannerPage. I only see a loader indicator and don't see the scanner.
Getting the error: MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner)

Hi, please share your device, flutter, package version that you are using.
Note: I have tested till Android 15 (API 35) and android 14 should work just fine, hope you are using the latest version https://pub.dev/packages/simple_barcode_scanner.

closing issue since there is no update.

I am testing on a Samsung A15 on Android 14. Have installed version 0.2.5 of the package but had the issue prior to it.

Okay, please feel free to reopen the issue with detailed steps to reproduce if you face an  issue using the latest version

Having the same issue using device
Device: Android Galaxy A53
Flutter 3.24.5
Dart 3.5.4


gpu_blas_lt_gemm_runner

we also have this TF_USE_CUBLASLT for enable hipblaslt
https://github.com/ROCm/tensorflow-upstream/blob/r2.13-rocm-enhanced-hipblaslt/tensorflow/core/kernels/gpu_utils.cc#L98-L107
I'm thinking maybe we should unify these flags as one

we also have this TF_USE_CUBLASLT for enable hipblaslt https://github.com/ROCm/tensorflow-upstream/blob/r2.13-rocm-enhanced-hipblaslt/tensorflow/core/kernels/gpu_utils.cc#L98-L107
and it seems for CUDA-only https://github.com/ROCm/tensorflow-upstream/blob/r2.13-rocm-enhanced-hipblaslt_gpu_blas_lt_runner/tensorflow/core/kernels/matmul_op_impl.h#L411-L413
I'm thinking maybe we should unify these flags as one for non-xla @ScXfjiang @pemeliya

I prefer flags in debug_options_flags.cc to env vars in general. The latter is hard to manage. How do you think about it? @pemeliya

debug_options_flags.cc is for XLA specific stuff.
If this is TF and non-xla, these flags are more messy.


pip install modpoll - dosn't work

Hello everyone,
I'm trying to install the program in the docker image, but that doesn't work.
pip install modpoll
shows the problem:
 Could not find a version that satisfies the requirement modpoll (from versions: ) No matching distribution found for modpoll
Docker image:
FROM debian:stretch-slim
Do you now why the issue exists?
regards
Martin

Hi, please check your python version, the latest modpoll (v0.5.4) requires python3.8+.

Close it due to no activity for long time


Failed to run ApolloAuto dreamview on Ubuntu 20.04.4 LTS on Windows 10 x86_64 using WSL2

System information

OS Platform and Distribution:  Ubuntu 20.04.4 LTS on Windows 10 x86_64 using WSL2
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 6.0
Output of apollo.sh config if on master branch:
[INFO] Apollo Environment Settings:
[INFO]     APOLLO_ROOT_DIR: /home/pbarac/apollo
[INFO]     APOLLO_CACHE_DIR: /home/pbarac/apollo/.cache
[INFO]     APOLLO_IN_DOCKER: false
[INFO]     APOLLO_VERSION: master-2022-06-21-9e1edfcc2b
[INFO]     APOLLO_ENV:  STAGE=dev USE_ESD_CAN=false
[INFO]     USE_GPU: USE_GPU_HOST= USE_GPU_TARGET=1
[INFO] Usage: /home/pbarac/apollo/scripts/apollo_config.sh [Options]
[INFO] Options:
[INFO]     -i|--interactive      Run in interactive mode
[INFO]     -n|--noninteractive   Run in non-interactive mode
[INFO]     -h|--help             Show this message and exit

Steps to reproduce the issue:

Installed all pre-requisites following https://github.com/ApolloAuto/apollo/blob/master/docs/specs/prerequisite_software_installation_guide.md
Installed software following https://github.com/ApolloAuto/apollo/blob/master/docs/quickstart/apollo_software_installation_guide.md
Done two changes to the bash scripts following this comment https://github.com/ApolloAuto/apollo/issues/14329#issuecomment-1073571799
Restarted PC for changes to take effect, Run ...cd apollo
bash docker/scripts/dev_start.sh
bash docker/scripts/dev_into.sh
run ./apollo.sh build, ./apollo.sh build_opt
Then get following message:
[ OK ] Done building apollo. Enjoy!
But when I open page where ApolloAuto dreamview should be run I get: This page isn’t working <IP_ADDRESS> didn’t send any data.
ERR_EMPTY_RESPONSE

Can somebody help me solve this or have some alternative solution for running this project on win10?
Installing Ubuntu isn't solution for me, because of drivers incompatibility.
Supporting materials (screenshots, command lines, code/script snippets):

As @orangetcy said in https://github.com/ApolloAuto/apollo/issues/14329

normally, it should be the same with wsl2.
Maybe you can try this command in apollo dev docker to test if dreamview is working:
curl http://localhost:8888
If get html code as output, maybe dreamview is working then try to solve docker/wsl2 network configuration problem. Otherwise, make sure your dreamview is working.

You can try the above method first.

Thank you for the tip. It lead me to fixing problem!


Devise

Remove current_user method in ApplicationController, devise will provide us with one. ✔
Install and setup devise. ✔
Can register a new user. ✔
User logs in with a combination of email and password. ✔
Hashed password should be stored in the database. ✔
Ask for confirmation of email. ✔
Confirmation email:

When clicking the link that is shown in the vscode terminal, this is what happens:

Can reset password. ✔
The mail you should receive when resetting the password:

Changing password:

Password changed:

Modify the views in devise for registration and login to match the wireframes from the Sneak Peek and your styling. ✔

Hi @nicupop729
Thx for the extra review ;)
I can still see the changes required in the dashboard. Is that normal?

Hi @EmiLoKiJu,
If I am not wrong (please correct me if I am), you still have a review attempt, no?
Please use it to ask for another review from your dashboard and the next reviewer will mark the project as approved right away (as it was mentioned in my previous review).


Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:apache:mina:*:*:*:*:*:*:*:*
CVE
CVE-2021-41973
ODC Integration
{"label"=>"Maven Plugin"}
ODC Version
7.1.0
Description
The CVE description says "Please update MINA to 2.1.5 or greater.", but the mitigation was also backported to 2.0.22

Brought this to the attention of the NVD as this is an error in their 'known vulnerable configurations' set. Expect it to be corrected in the source after a few business days. (and as GHSA has the same version range also filed a correction with them).
Thanks for bringing this up

NVD data has been updated, should take effect in there datastreams within 24hrs

NVD-update has resolved the issue


Enhancements and Testing Summary

Enhancements and Testing Summary
Overview
In the Space Travelers' Hub project, our collaborative team consisting of @mryeminthu  and @lily4178993 has successfully developed a web application that empowers users to book rockets and participate in space missions.
Components and Features
Our project revolves around three main sections: Rockets, Missions, and My Profile.
Rockets
The Rockets section presents users with a curated list of available SpaceX rockets, offering the capability to reserve or cancel reservations. The user interface showcases essential rocket details, such as names, descriptions, and captivating images.

Missions
The Missions section provides users with a glimpse into the exciting world of space exploration. Users can explore current space missions, read engaging descriptions, and seamlessly join or leave missions, enhancing their immersive experience.

My Profile
The My Profile section tailors the user experience by offering a personalized overview of reserved rockets and joined missions. This intuitive interface empowers users to effortlessly track their participation history and journey into the cosmos.

Implementation Highlights
Our team has demonstrated a dedicated focus on implementing key functionalities that ensure a seamless and captivating user experience:

Real-time data retrieval from the SpaceX API for Rockets, Missions.
Strategic utilization of Redux and Redux Toolkit to effectively manage and store fetched data, ensuring streamlined state management.
Clever deployment of conditional rendering, dynamically displaying reserved and joined statuses for rockets, and missions.
Seamless navigation facilitated by the integration of React Router, offering users an engaging and dynamic journey.

Testing Efforts
Our commitment to delivering a reliable and stable application led us to invest substantial effort into testing. We conducted thorough unit and integration tests for critical sections, including navigation(Header), MyProfile, Missions and Rockets. This rigorous testing process encompassed simulating user interactions, validating data integrity, and ensuring smooth component rendering.
Notes for Reviewers
Reviewers are encouraged to explore the application firsthand using the deployed link or by setting up a local environment with the following commands:
git clone https://github.com/lily4178993/space-travellers.git
cd space-travellers
npm install
npx eslint "**/*.{js,jsx}" --fix
npm start

Thank you @DammyShittu for your thorough inspection and valuable suggestions. Your keen eye for detail and commitment to quality have greatly contributed to the improvement of this project. We appreciate your dedication to excellence!

We want to express our sincere gratitude to the reviewers for their careful evaluation and approval of this project. Your feedback and guidance have been invaluable in ensuring the success of this endeavor. Thank you for your time, insights, and support throughout this journey!


Guide for users switching from LaTeX

This PR adds a guide for people switching from LaTeX to Typst to the docs.
Remaining tasks

[ ] Determine if this is the right place for the Guide or if there should be a new "Guides" section, with the URL being /docs/guide/latex-users
[ ] Review prose
[ ] Is any frequently asked question missing?

I think it'd be worthwhile to pass some paragraphs through some popular AI-thingy and ask if it can improve something. It'll not necessarily improve improve things, but I think it can come up with some sentences that are easier to comprehend.
Here's what a popular AI-thingy did with the section on Arguments (note that it changed arguments to parameters, I just changed it back to arguments again) (I can also let other stuff pass through if you think it's a good idea)
Arguments
A function can accept multiple arguments. Some arguments are positional, meaning you simply supply the value. For instance, the function [#lower("SCREAM")] converts its input to lowercase. Many functions employ named arguments rather than positional ones for enhanced readability or when some arguments are less frequently used. For instance, to define the dimensions and stroke of a rectangle, you would use named arguments:
#rect(width: 2cm, height: 1cm, stroke: red)

To indicate a named argument, first write its name (such as width, height, and stroke), followed by a colon, and then the value (2cm, 1cm, red). The available named arguments for each function can be found on the reference page or in the autocomplete panel while typing. Named arguments resemble the configuration style of certain LaTeX environments; for example, to initiate a list with labels a), b), and so on, you would enter \begin{enumerate}[label={\alph*)}].
Frequently, you may need to supply some content to a function. For example, the LaTeX command \underline{Alternative A} would be written as [#underline([Alternative A])] in Typst. Square brackets signify that a value is content, and within them, you can use standard markup. However, this syntax can be cumbersome for a straightforward call, so you can also exclude the parentheses and use square brackets to pass a content value as the last positional argument.

I'm gonna merge for now and see about improving with AI later.


Fix minor copyediting issue in opening paragraph

LGTM, thanks!  Will merge this in once we get our new TOC in place.


New load icon, removed unused open icon

In my opinion current load icon is not good enough, sometimes at first glance I mistake it with save, as it is solid and has right top corner cut off (especially when save icon is grayed out).
Also I've removed open icon as it was only copy of load icon and was unused.

CC @djrm.

seems good, but i don't know how it will look in the editor

@djrm Hi and low DPI versions:

looks good


Proper way for nested mutation resolvers

Hello,
I'm trying to get my head around nested mutations.
I have successfully created nested input types holding the data. However, I can't implement a proper way to insert them.
What I hope for
What I ultimately want is to process the nested input data in a graph, before I actually end up inserting the whole graph in database in one go (currently using EF Core)
What I can live with
What I can live with is inserting one by one the objects in database (respecting the hierarchy).
Is there something I'm missing? I've spent a good few days looking for a decent solution :(
Thank you in advance

Hi @vtrihos
GraphQL does by spec not support nested mutations
so this would be invalid:
mutation  {
   user{
       add(input: {userName:"Foo"}) {
           userName
       }
   }
}

where as this would be valid
mutation  {
   addUser(input: {userName:"Foo"}) {
           userName
       }
}

Only the top level is executed serially, everything below is a 'query'

can you show use some graphql/code to provide some more context?

Hey @PascalSenn ,
Thank you for your quick reply. That made things way clearer.
I was looking at the whole matter from the wrong perspective.
I was expecting there to be mutation resolvers which I would chain (like I do with the query resolvers).
The right approach was to have nested ObjectInputTypes instead, and handle the mutation chaining myself, in one go, in the resolver of the root mutation. Now, I'm chaining the creation of the objects and linking them together, as the nested input instruct.
I think I'm on the right track now.
Thanks again,
Bill


[Feature Request]: Hierarchical user read & write permission.

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
No response
Describe the feature you'd like
能否初始化时设置管理员账号，其它注册人员是使用者权限，不能修改模型配置
Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

还有就是def init_superuser():user_info中注册的账号并不能使用

Perhaps a general permission module can be imported for hierarchical permission control.


Refactor main option

The current labels API is kinda weird with the object map. Instead, I envision a rules API that let's users specify custom behavior more easily:
schedule(labels({
  rules: [{
    // Each rule consists of two keys: match and label
    // which allow you to specify the exact condition when to apply a label
    match: (text) => text === 'WIP',
    label: 'Work In Progress'
  }]
}))

This is much clearer and more explicit than what we have currently.

That should probably still support the shorthand:
schedule(labels({
  // A string defaults to { match: /${string}/i, label: ${string} }
  rules: ["Work In Progress"]
}))


docs: fix docstring for some themes

I updated the descriptions of Doom-Henna, Doom-Homage-Black Doom, Doom-Homage-White, and Doom Wilmersdorf. I didn't think this was worthy of creating an issue for so I decided to just complete the fix my self.
Fixes #0000
References #0000
Replaces #0000

[/] I searched the issue tracker and this hasn't been PRed before.
[/] My changes are not on the do-not-PR list for this project.
[/] My commits conform to the git conventions.
[/] My changes are visual; I've included before and after screenshots.
[ ] I am blindly checking these off.
[/] Any relevant issues or PRs have been linked to.
[ ] This a draft PR; I need more time to finish it.

Here is a before and after shot of a change that I made.

Good catches. Thanks for your help!


[DOC] strange authors credit on pypi

The author credit on pypi appears strangely:

Markus should be credited as author, since he contributed to the old base classes on sktime, but this looks like he is the main and only author and we just maintain.
This should be changed.

I saw that. But I don't know how to change it. Any ideas where that is populated from?

I think from pyproject.toml, and "author" ends up being only those authors in "authors" who have no email next to their names.


Add AVL tree cpp

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the
below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the commit guidelines for this project.
[ ] My code follows the standard code structure.
[ ] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[ ] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[ ] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

@parammittal16 you need to rebase your local repo manually. Also include the issue link in your commit. https://github.com/NITSkmOS/Algorithms/blob/master/GIT_BASICS.md#follow-up


Missing licence notice file?

Hi,
The binary distribution/jar of loki-logback-appender absorbs code from Grafana Loki and Google Protobuf. One of the sources (https://github.com/loki4j/loki-logback-appender/blob/main/common/src/main/java/com/dslplatform/json/RawJsonWriter.java) has a copyright from " Nova Generacija Softvera d.o.o".
Shouldn't this be explicitly listed in a NOTICE file with their licences and copyright holder?
Cheers, Ivo Kolev

Hi!
Thanks for reporting this! It's a valid question. I don't have much expertise in how to arrange this legal stuff properly. Probably, we should stick with some common practice (how it's done in well-established java projects).
Not sure I will have a time to investigate this in the nearest future. But for sure I will be glad to accept a PR fixing this.

Hi Anton,
Thanks for the prompt reply. Unfortunately I can't contribute directly, but the notice file would be like below. Looking in the binary distro and the source there is one source and Google Protobuf that are absorbed; I figured out that the com.grafana.loki is produced upon the protobuf definition and its not actual Loki code. The file is usually labelled NOTICE and resides next to the LICENCE file. Its good both to be included in the binary distro, so that the clients of Loki Logback Appender have certainty what's inside. You may consider adding copyright header "Copyright (c) 2020, loki4j" in the lib own source too.
Cheers, Ivo Kolev
NOTICE suggested content:
Loki Logback Appender, Copyright 2020, Loki4j
This software includes the following third-party software modules:

Source RawJsonWriter.java
Copyright (c) 2015, Nova Generacija Softvera d.o.o.
Licensed under BSD-3-Clause, https://opensource.org/licenses/BSD-3-Clause

Protocol Buffers - Google's data interchange format
Copyright 2008 Google Inc.  All rights reserved.
https://developers.google.com/protocol-buffers/
Licensed under BSD-3-Clause, https://opensource.org/licenses/BSD-3-Clause

Sorry, I just realized that the google package is also a protobuf generated and not the actual library. So the notice should only credit "Nova Generacija Softvera d.o.o.".
Cheers, Ivo Kolev


add supports for more basic operations and layers

In order to enrich the supported operations of tq, we need your help on adding more functionalities.
Please firstly identity the gates that have not been supported by torchquantum, you can find them by having a look at other frameworks such as Qiskit, Cirq etc. You can identity the gates that not supported by looking at qiskit.circuit.library.
Such as the SdG gate:
SdgGate
For the simplest non-parameterized gates, you need firstly add their unitary matrix to tq.functional file: https://github.com/mit-han-lab/torchquantum/blob/8d06a998a6d35374907c5e75a347d187e837b8cc/torchquantum/functional.py#L1104 and also add their functions. Then you can add a class to the tq.operators files and finally add test function to test/test_op.py. You may create new test files.
You may also implement other template layers according to qiskit.circuit.library. https://qiskit.org/documentation/apidoc/circuit_library.html
Please let us know if you have any questions or need any instructions!

Hi,
I have added the code for SDG gate in functional.py, added a class to the operators file and added the test_case as well. Should I do a PR/Merge request? I can also provide you the forked repo in case you want to check before merging.

Hi, @Hanrui-Wang
Apart from some Quantum Gates that I have added in my PR #138 , should I also add some ansatz layers/N-local circuits like RealAmplitudes, EfficientSU2, Two-Local, etc. that are used quite often in Qiskit Machine Learning

Hi, @Hanrui-Wang Apart from some Quantum Gates that I have added in my PR #138 , should I also add some ansatz layers/N-local circuits like RealAmplitudes, EfficientSU2, Two-Local, etc. that are used quite often in Qiskit Machine Learning

Hi bopardikarsoham,
Yes, ansatz layers/N-local layers are also very important so they are highly encouraged! When you implement RealAmplitudes, EfficientSU2, Two-Local, it would be better to also have similar hierarchy of classes as qiskit.

I add a PR for QFT in #142

Made changes and Added basic gates for issue #134

Congrats @pandey-tushar,  @bopardikarsoham, @YuNariai and @dhanvi-bharadwaj for successfully merged the pull requests and thank you for your contributions! Since UnitaryHack comes to an end, I will close this issue but we will very appreciate if you can continue to contribute to new functionalities in torchquantum!


Translate: Apha-level API generated by the microgenerator and checked in

OKR tracking issue

Closing this because the OKR was changed to the IAM service instead. Will create a separate issue for those.

Closing this because the OKR was changed to the IAM service instead. Will create a separate issue for those.


paymentsservice: code polishes

What
Polished code from the paymentsgateway module in order to make it ready for the next features.
Changes:

Rename AccountType to AccountLevel for improved clarity.
Fix async test testGetAccount_isNotMainAccount that was failing intermittently.
Update sendPayment signature so it can represent payments from one network to another, e.g. Circle->Stellar.
Add or update comments to improve clarity.

LGTM since there is no Circle specific implementations. I think Jake can do a better review on the payment gateway interface.


waf-reputation-lists should support IPv6

It'd be great now that WAF and CF support IPv6 to add support for Spamhaus DROPv6.

Running into the same issue. The function 'waf_update_ip_set' fails for IPv6 IPs.


⚠ Ixtanet SAT has degraded performance

In 86c725d, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20521 ms

Resolved: Ixtanet SAT performance has improved in 5a0b9f1 after 290 days, 12 hours, 33 minutes.


Load Single JS File in Page Directly

Hi :)
I want to using vue-multiselect in traditional way (load .js file in page directly).
Is there any guide about this?
I had lots of search and also read official doc, but I couldn't found anything useful.

After adding the vue-multiselect.min.js file inside the

    Simple select / dropdown

        Single select
        <multiselect v-model="value"
                     :options="options"
                     :searchable="false"
                     :close-on-select="false"
                     :show-labels="false"
                     placeholder="Pick a value">

        </multiselect>

{{ value  }}

{{ value  }}

Seems you’re using Vue 2.x. It might be that the version of Multiselect that is available on bower is for Vue 1.x.
You will have to either download and add the file yourself or use a fork https://github.com/monster-media/vue-multiselect that is available on bower as vue-multiselect3 and it seems to support Vue 2.0.

It works w npm version :)
Tnx

v2.0 link from CDN: https://cdn.jsdelivr.net/vue.multiselect/2.0.0/vue-multiselect.min.js
Having a easy-to-find download link on README would be useful. People not always use NPM.


S390x compatibility fixes

With the new support  (LLVM-18) for libomp and lld in s390x there are now tests that are unexpectedly passing (marked as failure), others that are not being run. The summary of changes in this PR is as follows:

LIBOMP presence is detected at cmake configuration step similarly to how all the binaries are detected, using cmake's find_library.
libomp feature added in lit.site.cfg. This is enabled depending on LIBOMP provided from cmake configuration.
libomp related tests are now have REQUIRES: libomp lit directive. These tests will now be marked UNSUPPORTED in s390x/LLVM < 18, and will run normally on LLVM >= 18
whole-toolchain testcases now run on s390x due to lld being supported. These tests are expected to fail, as building with  -rtlib=compiler-rt  will fail due to unsupported builtins library in the arch. Added XFAIL: s390x on them.

Additionally, fedora workflow in GH actions has been updated with latest supported versions.

Running this branch on a s390x system running latest Fedora Rawhide and LLVM 18.1.0~rc4 shows no failures:
# lit --show-xfail --show-unsupported -v tests
-- Testing: 51 tests, 2 workers --
PASS: LLVM regression suite :: plugins_newpm.txt (1 of 51)
[...]
PASS: LLVM regression suite :: scanbuild_py.cpp (51 of 51)
********************
Unsupported Tests (1):
  LLVM regression suite :: test_hwasan.c

********************
Expectedly Failed Tests (5):
  LLVM regression suite :: lto_and_cfi.c
  LLVM regression suite :: lto_and_cross_dso_cfi.c
  LLVM regression suite :: unwind.cpp
  LLVM regression suite :: whole-toolchain.c
  LLVM regression suite :: whole-toolchain.cpp

Testing Time: 12.03s

Total Discovered Tests: 51
  Unsupported      :  1 (1.96%)
  Passed           : 45 (88.24%)
  Expectedly Failed:  5 (9.80%)

@sylvestre Could you take a look at the cmake logic and double check if it's a good way to approach the libomp detection?
Also, it seems that the ubuntu runs that failed are unrelated to the changes in this PR. They've been there for a while.

@nikic pointed out internally that detecting libomp using clang -fopenmp could mask real failures in a scenario where clang search path is broken, for example. I updated the PR using a different approach based on finding the library instead.

@sylvestre ping, pretty please? :)

sorry, i missed your notif?!


Support ON CONFLICT ON CONSTRAINT

Postgres supports ON CONFLICT ON CONSTRAINT <constraint_name> to explicitly name the constraint that fails. Support this.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 33 (96.97%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.372%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
5
6
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
12707

Relevant Lines:
14712

💛  - Coveralls


ERROR:  CDB(_CDB_Has_Usable_Geom:42701:column "the_geom" of relation "completter" already exists)

When importing a file that contains an attribute called "wkt" which contains the geometry written in WKT for every feature, this error is raised.
2015-09-08 14:35:22 UTC: Before persisting metadata 'completter' data_import_id: f5b1026b-3d72-491e-b1d0-569fc70815fe
2015-09-08 14:35:26 UTC: Exception: PG::Error: ERROR:  CDB(_CDB_Has_Usable_Geom:42701:column "the_geom" of relation "completter" already exists): ALTER TABLE completter RENAME COLUMN wkb_geometry TO the_geom
CONTEXT:  SQL statement "SELECT _CDB_SQL(sql,'_CDB_Has_Usable_Geom')"
PL/
2015-09-08 14:35:26 UTC: ["/home/ubuntu/www/production.cartodb.com/shared/bundle/ruby/1.9.1/gems/sequel-3.42.0/lib/sequel/adapters/postgres.rb:145:in `async_exec'", "/home/ubuntu/www/production.cartodb.com/shared/bundle/ruby/1.9.1/gems/sequel-3.42.0/lib/sequel/adapters/postgres.rb:145:in `block in execute_query'", "/home/ubuntu/www/production.cartodb.com/shared/bundle/ruby/1.9.1/gems/sequel-3.42.0/lib/sequel/database/logging.rb:33:in `log_yield'",

Renaming the "wkt" column to other thing, like "myk", makes the upload work and the system generates the_geom column appropriately.
To reproduce:

Failing file: https://gist.githubusercontent.com/iriberri/74153be4d9628915003e/raw/46c7d1845b4926a296f3d3422a64c0342ddcbd8f/completter_fail.kml
Working file: https://gist.githubusercontent.com/iriberri/84c101b2c0beb1377168/raw/070416056da1eb43ef32cfa2973486801b95d03d/completter_work.kml

Another one, pasting here the error to be able to recognise the failing file later:
CDB(_CDB_Has_Usable_Geom:42701:column "the_geom" of relation "maporgs9_9_15" already exists): ALTER TABLE maporgs9_9_15 RENAME COLUMN wkb_geometry TO the_geom\nCONTEXT:

At least in one of the cases the input table has both the_geom and wkb_geometry. Probably one of them to be thrown away.

I just reproduced this error inside account by exporting and importing again the table "test2_copy" that lives in our current testing account.
It contains some empty rows I added manually, so some the_geom are null, and the table also has lat/long columns (null too for these rows).
So yes, it seems there's a colision.

Getting inconsistent results when trying to figure out the srid:
select _CDB_Geometry_SRID('many_geometry_columns'::regclass::oid, 'the_geom');
 _cdb_geometry_srid
--------------------
                  0

SELECT ST_SRID(the_geom) AS srid FROM many_geometry_columns LIMIT 1;
 srid
------
 4326

...weird...

The problem with the comment above is: the state of FOUND is not modified by EXECUTE INTO. Here's the documentation:
http://www.postgresql.org/docs/9.4/static/plpgsql-statements.html#PLPGSQL-STATEMENTS-DIAGNOSTICS
and here some quick tests:
CREATE FUNCTION found_test()
RETURNS void
as $$
DECLARE
  rec RECORD;
BEGIN

  EXECUTE 'SELECT 1';

  IF FOUND THEN
    RAISE NOTICE 'EXECUTE modified FOUND';
  ELSE
    RAISE WARNING 'EXECUTE DID NOT modify FOUND!!!!';
  END IF;

  EXECUTE 'SELECT 1' INTO rec;

  IF FOUND THEN
    RAISE NOTICE 'EXECUTE INTO modified FOUND';
  ELSE
    RAISE WARNING 'EXECUTE INTO DID NOT modify FOUND!!!!';
  END IF;

END;
$$ LANGUAGE plpgsql;

SELECT found_test();
drop function found_test();

and here the result:
# psql -U postgres contrib_regression -f ~/found_test.sql
CREATE FUNCTION
psql:/root/found_test.sql:28: WARNING:  EXECUTE DID NOT modify FOUND!!!!
psql:/root/found_test.sql:28: WARNING:  EXECUTE INTO DID NOT modify FOUND!!!!

Just FYI @pramsey: I'll review all usages of EXECUTE plus FOUND because they are widely used in cartodbfy code.

Ug! Thanks @rafatower

@pramsey I extracted the query on top of _CDB_Has_Usable_Geom to a function _cdb_geom_candidate_columns and run a small experiment:
DROP TABLE IF EXISTS many_geometry_columns;
CREATE TABLE many_geometry_columns (
       the_geom geometry,
       wkb_geometry geometry(MultiPoint,4326)
);
INSERT INTO many_geometry_columns (the_geom, wkb_geometry) VALUES
       ('0104000020E61000000100000001010000007108B023698052C03CEEA53A2E5D4440', '0104000020E61000000100000001010000007108B023698052C03CEEA53A2E5D4440'),
       ('0104000020E6100000010000000101000000864C9E57618052C0994F0C7F3C5B4440', '0104000020E6100000010000000101000000864C9E57618052C0994F0C7F3C5B4440');
SELECT * FROM _cdb_geom_candidate_columns('many_geometry_columns');

and this is what I got:
   attname    | srid | typname  |   desired_attname    | desired_srid
--------------+------+----------+----------------------+--------------
 the_geom     |    0 | geometry | the_geom             |         4326
 the_geom     |    0 | geometry | the_geom_webmercator |         3857
 wkb_geometry | 4326 | geometry | the_geom             |         4326
 wkb_geometry | 4326 | geometry | the_geom_webmercator |         3857

(this is the Cartesian product meta-info(att_name, srid) x desired(att_name, srid))
My question is how this can get along with this line:
    -- Name collision: right name (the_geom, the_geomwebmercator?)  but wrong type...
    IF r1.typname != 'geometry' AND r1.attname = r1.desired_attname THEN

I just want to make sure I'm not missing something important in the design of that function.

Maybe, I'm not sure what your concern is... finding non-geometry types that have our preferred column names to either avoid clobbering them or converting them into geometries...

My concern is understanding the algorithm, since it is setting flags and vars on a loop on the cartesian product of (attname,srid) x (desired_attname, desired_srid), and it also has side effects (renaming columns at the end) what are the guarantees it will deliver the intended results?

ref S/B 6623933 (Private datasets are in ticket)
Expected: PostgreSQL INSERT INTO will put column info from user's _new dataset into original (blank) dataset that has same column names
Happening:

@ztephm that's a different issue

Fixed and released


Hope that --require option support requiring local module

When I'm trying to require some modules with mocha.opts like below
--require should
--require ../Utils/Logger
--recursive

I get the error in the stderr:
Error: Cannot find module '../Utils/Logger'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at E:\WebstormProjects\activity-system\node_modules\mocha\bin\_mocha:345:3

Why not try to support the user to require a local module not only a module from node_modules?

Mocha does support this. Where is Utils/Logger relative to the project root? (I assume you are running Mocha from the project root, also; is this correct?)

Humour me for a minute and try changing ../Utils/Logger to ./Utils/Logger.

From my results, it seems like mocha requires the full file path name including the file extension if you are requireing a local module. So ../Utils/Logger.js. If the local module was in the local directory, Utils/Logger works for me.


backgroundColor is displayed inaccurately.

Thank you for your contribution to the open-source community. 😋
The background color of this widget appears lighter than the sample color on the right, even though it's actually using the same color value.

Code sample
import 'package:animated_toggle_switch/animated_toggle_switch.dart';
import 'package:flutter/material.dart';

class AnimatedTogglePage extends StatefulWidget {
  const AnimatedTogglePage({super.key});

  @override
  State<AnimatedTogglePage> createState() => _AnimatedTogglePageState();
}

class _AnimatedTogglePageState extends State<AnimatedTogglePage> {
  bool _selected = false;

  final _bgColor = Colors.yellow.withOpacity(0.6);

  final _height = 48.0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Animated Toggle')),
      body: Center(
        child: Row(
          mainAxisAlignment: MainAxisAlignment.spaceAround,
          children: [
            _buildToggleWidget(),
            Container(
              width: _height * 2,
              height: _height,
              color: _bgColor,
            )
          ],
        ),
      ),
    );
  }

  Widget _buildToggleWidget() {
    return AnimatedToggleSwitch<bool>.dual(
      current: _selected,
      first: false,
      second: true,
      height: _height,
      borderWidth: 0,
      onChanged: (value) {
        setState(() {
          _selected = value;
        });
      },
      styleAnimationType: AnimationType.onHover,
      styleBuilder: (value) => ToggleStyle(
        indicatorColor: Colors.red,
        borderColor: Colors.transparent,
        backgroundColor: _bgColor,
      ),
    );
  }
}

Thank you for reporting. I'll take a closer look at it.

This seems to be a bug in the Flutter framework. I'll just work around it.

Can you please test if the problem is solved with my fix? To test it, you can add the following to your pubspec.yaml.
animated_toggle_switch:
  git:
    url: https://github.com/splashbyte/animated_toggle_switch.git
    ref: 58-backgroundColor-is-displayed-inaccurately

@GF-Allen Can you please test if the problem is solved with my fix? To test it, you can add the following to your pubspec.yaml.
animated_toggle_switch:
  git:
    url: https://github.com/splashbyte/animated_toggle_switch.git
    ref: 58-backgroundColor-is-displayed-inaccurately

Thank you, the issue has been fixed.


PNG codec: support most pixel formats

GDI+ converts a lot of pixel formats to PixelFormat32bppARGB.
It turns out libpng supports transformations which allow you to convert from one image format to another (including to 32bppARGB).
Use these functions instead and support a bunch of new formats. Re-enable unit tests which were disabled on libgdiplus.
Fixes #533
Fixes #378
Fixes #184
Fixes #176
Fixes #175
Fixes #174
Fixes #173
Fixes #172

OK - I think this is ready for review. The Travis failure is because Homebrew updated pango, and it now triggers a deprecated function warning.
So, the idea is that images are always converted to 32bpp RGBA

Getting RGBA output can be achieved by calling png_set_bgr  and png_set_add_alpha.
< 32bpp image formats can be converted to 32bpp by calling png_set_expand
Grayscale images can be converted to color by calling png_set_gray_to_rgb

The exception is 4-bit and 8-bit paletted images.
It would be good to get a couple of reviews though, so pinging @hughbe and @filipnavara

/azp run


[fix] add better error handling for empty tags when --allow-latest is false

I originally went to address issue #273, when I fell down a small rabbit hole.
tl;dr 1) is my hacky way to parse the user's specified tag OK? 2) how should we be smart about looking for images on disk vs. a registry
We have this --allow-latest flag which defaults to false, that I'm assuming is for CI purposes. We'd like to be able to inspect claims for actors and providers on disk, in a registry or from a cache. We'd like to be "smart" about it and infer what the user wants with decent fallbacks. We'd like to give the user helpful error messages when they try wonky stuff.
Firstly, if --allow-latest is false, we shouldn't default the tag to "latest" when it's not specified and then give the user an error message that what we did behind the scenes isn't allowed. We should tell the user that they need to specify a tag. If the user specifies the "latest" tag explicitly, then we should show the error about not allowing it. This is what my initial commit addresses. Unfortunately, the logic that parses OCI reference strings and the logic that defaults the tag value are both behind the same API, and in order to parse out the input tag in the most consistent way possible, I had to steal some code from the oci_distribution dep. So it's a little hacky, and maybe peeps won't dig it. I suppose we could work with the maintainers of the crate but I'll let future us worry about that.
Secondly, being "smart" about checking local or remote is a tad tricky because, to my knowledge, there is no hard-and-fast disambiguation b/w valid OCI registry URLs and valid file paths (at least in UNIX). A path that looks like a registry reference would be "weird" but valid, and a registry reference could easily look path-ish. I'm being real neurotic here, but I can make a local relative file "localhost:5001/my_actor:tag_s.wasm" and have an image in a registry with the same reference. In this funky case, the user can't inspect the claims in the registry, since the system defaults to looking on disk and finds the .wasm file.
There are a few possible solutions that come to mind:

be a little smart and if the user happens to make a local wasm/par file that exactly matches a registry URL and they want to check the registry, then out of luck they be
be a little smart but give an escape hatch flag (like --no-local or --reg-only) if the user wants to host an image at a reference like "myreg:5000/myimage:tag_s.wasm"
don't be smart and have an opt-in flag (like --local or --on-disk) for checking local files
create a convention that wasmCloud OCI reference URLs MUST NOT end with ".wasm" or ".par" or ".par.gz" and enforce this in wash and wasmCloud, then we can be real smrt

In all cases, a more informative output specifying exactly where we found the bits would be helpful.
Happy nitpicking! :D
P.S. Maybe we could be smarter on Windows since paths are more strict?
P.P.S Also relates to #305

In order to get the tests to pass I changed the regex dependency to required. It was optional under the "cli" feature. I'm wondering if this is the right way to go.

Hey, sorry for the delays.
I could make an issue on the other repo. I'd like to clarify what we intend to make the issue about, though. The real problem I ran into in this fix is that there's no way to pull the user-supplied tag from the parsing process. If the user supplies no tag, the from_str (on the TryFrom impl) method defaults to "latest" and returns that (see this line).  Even though the tag member of the Reference struct is an Option, there's no way the parse can return a None if you go through from_str. If I had it my way, the result from parse would have an Option::None result for tag when the user-supplied tag is empty. I think the logic for replacing empty tags with the default belongs in the whole() method which converts a reference to a string. This is a breaking change though so...
In this context the minimum request would be to add some additional method to extract the just tag from a request. This solution is sub-optimal in my view, since the structure for handling this more naturally already exists in the types (namely the Reference.tag being an Option).
Now, that I've written it, this could be the blurb for the new issue? :D

@ceejimus I think something like what you just said would make a good issue for oci-distribution


Textures occasionally not displaying problem

⚠ Issues not using this template will be systematically closed.
Describe the bug
I used textures to implement a model with a grid, but every time I entered the page, the textures were sometimes invisible. I used sample-gltf-viewer for testing.
To Reproduce
If you enter the application repeatedly, there is a chance of recurrence.
Expected behavior
Every time you enter, the grid should show
Smartphone (please complete the following information):

Device: oneplus 9r 5g
OS: Android 13

Additional context
video
model

It looks like there is sorting problem with the "grid" object.
My guess is that both objects are "transparents" and this problem would definitely be fixed if the "box" was opaque.
I will argue that the asset is incorrect because it contains a transparent object intersecting another transparent object and currently we can't handle that very well -- there will always be some camera angles that don't work -- like when looking at it from the side.

It looks like there is sorting problem with the "grid" object. My guess is that both objects are "transparents" and this problem would definitely be fixed if the "box" was opaque.
I will argue that the asset is incorrect because it contains a transparent object intersecting another transparent object and currently we can't handle that very well -- there will always be some camera angles that don't work -- like when looking at it from the side.

Yes, there is a problem with BLEND support. My solution is to customize the material and replace the problematic material.


Http Error in Poller function of Azure Document intelligence

I am trying to custom extract fields like Title, Subtitle, Header, Footer from a policy document (pdf).
I am using the below code as suggested on your documentation.
from azure.core.credentials import AzureKeyCredential
from azure.ai.documentintelligence import DocumentIntelligenceClient
from azure.ai.documentintelligence.models import AnalyzeResult
endpoint = "https:<.........>cognitiveservices.azure.com/"
key = "**************************"
docUrl=r"https://<Storage_Name>.blob.core.windows.net/sample-99-container/xhygauscubc.pdf"
document_analysis_client = DocumentIntelligenceClient(endpoint=endpoint,
credential=AzureKeyCredential(key))
poller = document_analysis_client.begin_analyze_document(
"prebuilt-document", docUrl)
result: AnalyzeResult = poller.result()

I am getting the below error in the poller.
Message: Invalid argument.
Inner error: {
"code": "ParameterMissing",
"message": "The parameter urlSource or base64Source is required."
}"
}

Hi @AdityaR-B , thanks for your contact! The error is because the url is expected to pass through a "Request", can you try the code below?
from azure.ai.documentintelligence.models import AnalyzeDocumentRequest

poller = document_analysis_client.begin_analyze_document(
    "prebuilt-document", AnalyzeDocumentRequest(url_source=docUrl
)
result: AnalyzeResult = poller.result()

We also have a sample file you can follow: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/documentintelligence/azure-ai-documentintelligence/samples/sample_analyze_receipts_from_url.py
Thanks

/unresolve
Issue still persists with the newest version of the SDK.

please explicitly explain what is required - are raw bytes unsupported? do you have to provide a URL?
please update the typing of the library to reflect this, currently it does not require a request object.
using a request object fails with broken pipeline.


Rename struct to class?

Advantages:

Feels like it makes more sense now that struct can have methods in it
Consistent with Python
Would syntax highlight better when abusing Python syntax highlighting for Jou programs

Disadvantages:

Somehow "a class" doesn't feel like it emphasizes how it's just a way to arrange bytes in memory
Could seem disgusting to C programmers who associate classes with other garbage that OOP people do

Sounds like ... a good idea?

If struct has init (#249) I will rename struct to class


Typo "(Integration Services)"→"(Integration Services)"

https://docs.microsoft.com/en-us/sql/integration-services/security/security-overview-integration-services?view=sql-server-ver15
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; merging. Thanks @hyoshioka0128.


Update the provision step hardware specification

Use hardware as the key instead of environment which could be
confusing as it is already used for environment variables. Use a
group for the disk space specification to allow possible future
extensions such as disk layout.

A minor update of the hardware environment specification draft as discussed last week with @thrix and @happz. Please, have a look.

LGTM, +1.


do not call instance handlers for service entry

Currently instance handlers for service entry are ineffective because we call service handler in all cases and it triggers a full push.

@rshriram @howardjohn PTAL - as discussed pushed this PR

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
d2e1584a24ac4d2b00b3082ce60311a2027b95e3
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-cni_istio
d2e1584a24ac4d2b00b3082ce60311a2027b95e3
link
/test e2e-simpleTests-cni_istio

lint_istio
d2e1584a24ac4d2b00b3082ce60311a2027b95e3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


i9 create navigation bar

Change Summary
add navbar components
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

any documents where I can put documentation?
test is only recording of the navbar the recording is in this gdrive https://drive.google.com/file/d/1VYh1PsGkbngIZsPGCjn287MrGk1LgT3Y/view?usp=sharing

Other Information
[Is there anything in particular in the review that I should be aware of?]

needs to comment the import './assets/main.css' in main.ts since main.css from vue makes it render incorrectly

noted, will fix all of it. thanks for the review Chantelle


Ability to rename columns as part of a migration

There should be a way to rename columns as part of the natural evolution of a table.
Proposal it to add a new migration section to table json definition to do this.

Design proposal as:
 ,"migrations": {
      "dropColumns":["icd9s", "prc9s", "icd10s", "prc10s", "hcpcss", "cpts"]
     ,"renameColumns":[
          { "src":["drg","DRG"], "dest":"drgs" }
       ]
   }

related to #58 .


Improving the README.md

I would like to be assigned for GSSOC'23 for this issue
Suggestions:

Restructuring the header for a more visually appealing look
formatting text in a better manner
SEO friendly changes to link and text
adding badges for a cool effect
other minor changes

Great. I already passed ur pr. Best of luck .


Update equatable dependency and update sdk restraints

Status
READY
Breaking Changes
NO
Description
Update equatable to  ^2.0.0
Related PRs
List related PRs against other branches:

branch
PR

PR
https://github.com/ivoleitao/stash/pull/3

Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
± |develop U:1 ?:1 ✗| → dart example.dart
Task 1: "Run stash_memory example" is completed

Impact to Remaining Code Base
This PR will affect:
From equatable:
BREAKING: opt into null safety
feat!: upgrade Dart SDK constraints to >=2.12.0-0 <3.0.0
BREAKING: stringify prints "null" for null properties instead of ""

@ivoleitao Hey, other packages I have are using equatable ^2 which wont let me use stash or any of its modules. I ran the example.dart file and it appeared to work correctly. I updated the sdk restraints you don't use stringify in the project so it returning "null" as opposed to "" shouldn't matter to you.
https://github.com/ivoleitao/stash/blob/ef4ecb8abbffd34422c0dff0fb2698337ddd8d6e/lib/src/api/codec/msgpack/writer.dart#L52
  String toString() => 'Cyclic error in JSON stringify';

is the only place i see stringify so it really shouldn't matter.

Hi ! You can use the null safety version that I published: https://pub.dev/packages/stash/versions/2.0.0-nullsafety.3. This version already uses equatable 2.0.0
https://github.com/ivoleitao/stash/blob/prerelease/pubspec.yaml

I intend to move the package out of prerelease state as soon as I'm able to migrate the stash_moor package as it is still dependent on build_runner migration (which should happen this week, I hope)


fix(redash): use dashboard id if slug does not work

I tested calling the Redash endpoint with dashboard_id instead of slug and it responded with dashboard info. This should not be happening as per the API docs https://redash.io/help/user-guide/integrations-and-api/api but the actual behavior is different. Using the ID as fallback because the original change must have been tested with some version of Redash.
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Looking at the source code https://github.com/getredash/redash/blob/master/redash/handlers/dashboards.py#L155 it looks the API docs at https://redash.io/help/user-guide/integrations-and-api/api for /api/dashboards/<dashboard_slug> is wrong. It should have been /api/dashboards/<dashboard_id>


Notifications should expand automatically when clicking on them

When I clicked on this notification, it just "selected" it. I had to click the small little expand icon to see the full text. I think it would be better if it expanded automatically if you clicked on/selected it.

@DanTup doubleclick will expand. I am closing this as wontfix because it is perfectly fine to select a notification just to get focus and then maybe you want to keep the view state stable.

@bpasero Thanks; didn't realise I could double-click - I'm fine with that :)


CORS error with https://relay.nostr.info

I don't know how to fix or reproduce that. In my config there is only one header added with the capitalized writing.

this should be fixed. Switching from one relay implementation to another had added the header in two different places.


Shell integration cannot be activated when PROMPT_COMMAND is set to printf

Issue Type: Bug
when i enable shell integration, i get an error:
Shell integration cannot be activated due to complex PROMPT_COMMAND: printf "" "${USER}" "${HOSTNAME%%.*}" "${PWD/#$HOME/~}"

my .bashrc contains:
PS1=${PS_OVERRIDE:-"\[\e]0;\u@\h: \w\a\]\[\033[01;32m\]\u@\h\[\033[00m\]:\[\033[01;34m\]\w\[\033[00m\]\$ "}

VS Code version: Code - Insiders 1.66.0-insider (45999664ef626d6d665cb585104efdcab383a3cd, 2022-03-28T07:49:37.594Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
47.66GB (31.11GB free)

Process Argv
--crash-reporter-id e6e8bf0f-8ff2-4e01-a3ad-6aaeed8c91cc

Screen Reader
no

VM
33%

Item
Value

Remote
WSL: CentOS7

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz (6 x 2904)

Memory (System)
37.34GB (33.47GB free)

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

better-cpp-syntax
jef
1.15.13

remote-containers
ms-
0.230.0

remote-ssh
ms-
0.77.2022032415

remote-ssh-edit
ms-
0.77.2022032415

remote-wsl
ms-
0.66.0

doxdocgen
csc
1.4.0

better-cpp-syntax
jef
1.15.13

cmake-tools
ms-
1.10.5

cpptools
ms-
1.9.7

cpptools-extension-pack
ms-
1.1.0

cmake
twx
0.0.17

(2 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vsclayoutctrc:30405799
pythonvspyt640:30438691
vscscmwlcmc:30428972
vscgsvid2:30433758
pynewfile477:30451556

@Spongman looks like you set $PROMPT_COMMAND somewhere which re-writes your $PS1. Right now if we detect possible problems with unsupported $PROMPT_COMMAND formats we bail out and disable shell integration by design.
To workaround this you could point your $PROMPT_COMMAND at a function and run printf inside the function instead, for example https://github.com/Tyriar/dotfiles/blob/master/data/bash/.bash_prompt#L3

Assigning to April to see if we can improve our handling here.

no. i'm not setting PROMPT_COMMAND.

It might be set in your .bash_profile or .profile?

no, this also happens when connecting (via ssh) to a fresh CentOS7 install.

@Tyriar

Same here, with Arch and default /etc/bash.bashrc:
https://github.com/archlinux/svntogit-packages/blob/packages/bash/trunk/system.bashrc
As workaround I blanked the $PROMPT_COMMAND on my ~/.bashrc

Thanks for finding the file setting it, should make it easy to test against 👍

the shell integration feature also breaks long line-wrapping in bash on CentOS7. the terminal wraps the line before reaching the right edge of the terminal window, and it wraps to the same line overwriting the existing ontents of that line. scrolling through line commands in the bash command history is completely broken.

Tentatively assigning to July as this gets hit with Arch's default


[web-bluetooth] Add device connect pattern

As devices/characteristics will be invalidated on device disconnection, this PR introduces a pattern to reconnect to device and rediscover characteristic.
Background: https://github.com/WebBluetoothCG/web-bluetooth/pull/273#issuecomment-239571741 discussion
R:@jyasskin @jeffposnick

@g-ortuno can you have a look?

👍 from me.

👍 from me too.

@jyasskin If that new patch looks good to you, I'll merge.

LGTM


See value on it

https://github.com/sinekhayantuli

thanks for filling this issue.
however it doesn't describe the issue nor are three details provided.
closing this now