Correct syclcc clang includes

As mentioned in #93
Issue:
syclcc-clang adds an incorrect include path for clang's internal includes (it's leftover looking from when we used hcc)
Fix:
Instead try to look for the directory relative to whatever clang gets passed in (either through the json or through --hipsycl-clang=...)
Additionally:
I've added a couple of missing find_package statements for hipsycl_rewrite_includes. Without them, linkage fails. I assume the reason for this is because llvm's clang does not normally adds itself to system paths, as it'd interfere with system packages and, without these explicit looks, linker will go through the regular system paths instead (in my case, I build with rocm's clang 9.0 but system has clang 8 from Arch Linux' regular packages)

Thank you! I found that when several versions of clang are available, this does not necessarily pick the same version of clang and llvm (where it uses the newest), which can cause trouble. Is there a way to make it pick the same clang and llvm versions? It also seems that there is an issue with the clang 9 package from apt.llvm.org. cmake looks for /usr/lib/llvm-9/lib/libclang_shared.so.9 which is not provided by this clang distribution. Since we need very new clang versions to support the newest CUDA releases, we should expect our users to use the nightly apt.llvm.org packages.
If the clang cmake module causes trouble, I would also be fine with just disabling compilation of the source transformation tools by default to advance the deprecation process. No need to spend time on compiling something that users are discouraged to use :)

Any news?

Hey, man. Sorry I've been away, was planning on going over this tomorrow and hadn't had a proper look at your question yet.
Hmm... the way to do this, I guess, would then to get the full path of the clang executable used on the build, up one directory and add that to CMAKE_PREFIX_PATH. Such that, if you're building from the system, it would add /usr to it (essentially a non-op) but if, say, your clang was /opt/rocm/llvm/bin/clang, it would add /opt/rocm/llvm/ to it.
I was under the impression it was picking the correct one when I tested but can double check, for sure. I'm currently rebuilding all of my rocm stuff as I'm almost finished with polishing up my upgrade to rocm 2.6 (famous last words right here). Once that is done and pushed I can get back to this issue and make sure it's working as expected

What's the current state? We don't need the cmake stuff right away (compilation of the source transformation tools that were affected are now disabled anyway), but I'd like to merge the fix regarding the includes very soon as it's a blocker for my plans of extended testing on ROCm.
By the way, I will likely move to using aomp as new rocm compiler, since I suspect this is the one clang fork that is actually getting AMD's love. There are binary packages, so it's also very easy to install.
With aomp, things work fine if you just remove the problematic include in syclcc-clang entirely - so that would also be a good option moving forward.

It shouldn't be hard to implement either a tweak to CMAKE_PREFIX_PATH or try and ask for a specific version.  Alternatively I can just remove the "offending" commit. I was waiting on you to decide which way you'd prefer this sorted

I'm sorry, I wasn't aware you've been waiting for my feedback. I would suggest waiting with the fix for clang cmake integration until the aomp integration is done. The reason is that cmake seems to be unable to correctly deduce the clang version used by aomp (since aomp adds a suffix to the version string) which will already require a rework of how we are currently looking for llvm. When we have the aomp integration I believe it is easier to discuss possible solutions and check how well they work on our supported platforms once we have the basics in place.
Regarding the toolchain: My main issue with it is that you're not really pointed to which distribution you should pick. aomp is not really a new compiler, it's effectively just a branch of AMD's clang/llvm fork ("hip-clang") bundled with matching ROCm device and runtime libraries. So, it is effectively just a distribution of hip-clang, with the benefit that it comes with binary packages (good for our CI) and is easier to install since it already comes with everything it needs. Additionally, its OpenMP support opens the door for us to add a targeted OpenMP backend in the future.
HC C++ would have gone anyway (with all variants of hip-clang) - in my mind it has always been clear that it's not going to be kept around in the future. If I recall correctly, the hcc readme advises people to move their HC code to HIP or OpenCL.

Yeah, HC C++ and HCC have been marked for deprecation for quite a while. It's just that they haven't phased it out entirely yet. To my understanding the version in ROCm 2.6 should be the final release for HCC, from their deprecation notice a while back. So waiting on the dust settling on what's coming to replace it for real is probably the way to go for the future.

Yeah.. I'm moving in the direction now of using mainline clang for ROCm. Was the option that worked best for me. See PR #113.
Also, I've implemented an alternative solution in PR #113 for the include path. I'm using a cmake variable and let cmake do the guessing of the path instead of syclcc-clang trying to be clever. I think this may better since include paths can be quite different for diffierent clang distributions. What do you think?
Sorry for not building on your work for now, time has been pressing ;)

Eh, it's all good. I'll give that PR a go once I have the time, see how I fare with that. No hard feelings if it turns out there's a better solution =P

Excellent, looking for forward to that :)

So.. I've just built it. Had to massage it a little bit due partially to the way i've set up my environment, but might have run into a new detail that needs to be tweaked in CMake.
So, I've got both the classic HIP through HCC as well as the new HIP-CLANG installed (and the default).
Now, the place I ran into a rough edge was that it looks like rather than just having the one new libhipSYCL, we have both a libhipSYCL_clang and a libhipSYCL_rocm, with the latter building on the older hcc toolchain. This one wasn't building because it didn't automagically pick up libhip_hcc (this is more or less expected on my end)
If that's correct (we want both libs):

I'd need to think how to generalise the type of fix I've done here, maybe do search and enable thing if the person for whatever reason ONLY has hip-clang?
The CMake package files reference only three variants of libhipsycl, which means that we'd need to add clang to the possible list of hipsycl platforms and add the target to the config files (this is easy)

If that's incorrect (should be either or):

Then the libhipsycl_rocm target needs to be switched on/off depending on probed/passed HIP_PLATFORM.
BUT then we'd need to do similar changes on the CMake config files to expose hipSYCL::hipSYCL_rocm instead (also: should we consider aliasing these to hipSYCL::rocm
and the like?)

I can apply changes for either of these paths and open a new PR/issue

How did you manage to get libhipSYCL_rocm compile with hcc? For quite some time now, cmake exclusively uses the new syclcc-clang to build hipSYCL, and syclcc-clang doesn't know anything about hcc. syclcc-clang should also automatically link against libhip_hcc (which has a confusing name - it's also needed for HIP-clang, without hcc involved at all).
libhipSYCL_rocm and libhipSYCL_clang are both required as they do two entirely different things (which is also why cmake doesn't treat libhipSYCL_clang as a libhipSYCL variant):

libhipSYCL_rocm is the hipSYCL runtime library containing SYCL scheduling, memory management and so on. syclcc-clang will link SYCL applications against this library on ROCm. This library is needed at runtime.
libhipSYCL_clang is the clang plugin containing clang AST and IR passes (so, compiler stuff). It's loaded by syclcc-clang into clang's plugin system during compilation, but is not needed at runtime.

What exactly is your setup and what was your fix?

OIC...
So this is adding to my confusion from the AMD side... If you build hip-clang libhip_hcc doesn't get built at all. The spat out CMake config files also strip it from the targets. I was under the impression that when I was doing the hello-world tests for hip-clang, libhip_hcc wasn't being linked at all and when I was trying to convert a larger project, it got linked in and I was getting some weird segfaults.
So if this is all as expected then I need to look at the ROCm side and figure out what's happening there... ¬¬
I was tackling this yesterday and got a bunch of missing symbols so just realised I was wrong somewhere and decided to have another look today. So.. yeah... disregard, this is all me, although I still need to understand what's happening to the hip libs in that case


[Enhancement]: Add a clear discoverable signifier to add an action when an event handler has no actions

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I view an event handler with no actions, I should see a clear discoverable signifier to add a new action so that, I have a clear entry point to configure the event handler via the action selector
Steps To Reproduce
Open the property pane for a button widget and try spotting the CTA for adding a new action for any event handler
Solution
Design Specs

Fixed in 96d7903


Can't log in using SessionID

Tried deleting the SSID cookie and then reloading, but nothing

[07-03-2017 20:23] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:25] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:26] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:27] POEApi.Infrastructure.LogonFailedException: Incorrect session id
at POEApi.Transport.HttpTransport.Authenticate(String email, SecureString password, Boolean useSessionID)
at POEApi.Model.POEModel.Authenticate(String email, SecureString password, Boolean offline, Boolean useSessionID)
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()
[07-03-2017 20:33] Error downloading account name, exception details: System.ApplicationException: Unable to deserialize object
at POEApi.Model.POEModel.GetProperObjectFromTransport[T](Stream networkData)
at POEApi.Model.POEModel.GetAccountName()
[07-03-2017 20:33] System.Exception: Error downloading account name, details logged to DebugInfo.log. Please open a ticket at https://github.com/Stickymaddness/Procurement/issues and include your DebugInfo.log
at POEApi.Model.POEModel.GetAccountName()
at Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass23_0.b__0()
at System.Threading.Tasks.Task.Execute()

I had the same issue and after 2 days of messing around doing this seemed to do the trick for me copy the session id then paste it to a sticky note first then recopy it off the sticky note then paste it into procurement.

It actually worked! thank you!

I tried it, same problem:
] Error reading character data for veryuniquename, if you are in offline mode you will need to login and update. If you received this error while logging in, the authenticated session may have expired or bad data has been returned by GGG or a network issue may have occurred - Please try again.
The same for every character.

Logout of the path of exile forums.
Login again and grab the cookie.
Make sure there is no trailing or leading white space.

the problem is not with the sessionid itself, it actually logs in and starts scanning my stash tabs. After it is done, the characters are next, where I have that issue. I tried logging out again and back in, same issue.

Procurement 1.11.0 Initialized.

Authenticating badumts                                                                    [OK]
Fetching account name...                                                                  [OK]
Loading characters...                                                                     [OK]
Loading Standard Stash Tab 1...                                                           [OK]
Loading Standard Stash Tab 2...                                                           [OK]
Loading Standard Stash Tab 3...                                                           [OK]
Loading Standard Stash Tab 4...                                                           [OK]
Loading Standard Stash Tab 5...                                                           [OK]
Loading Standard Stash Tab 6...                                                           [OK]
Loading Standard Stash Tab 7...                                                           [OK]
Loading Standard Stash Tab 8...                                                           [OK]
Loading Standard Stash Tab 9...                                                           [OK]
Loading veryuniquename's inventory...
[Error] Error reading character data for veryuniquename, if you are in offline mode you will need to login and update. If you received this error while logging in, the authenticated session may have expired or bad data has been returned by GGG or a network issue may have occurred - Please try again.

I had the same issues since day 1 of patch 2.6.  I used it even in the day of the patch but i couldn't use it after the patch.  The user session id was good but when it got the the new Legacy character it gave the error. I tried for days and it didn't work. Just as I was writing this message I tried again and it worked...the only thing I did different before this attempt is that I logged in the standard league for the first time this patch and then reloged in Legacy. I don't know what was the issue, but there was a bug/issue for sure!

That actually worked! Thank you so much!


breaking-change-idea - jslint.js exports an object {cli, jslint} instead of a function jslint()

Please check these things before submitting your issue:

[x ] I searched for duplicate or closed feature request here

Is your feature request related to a problem? Please describe.

jslint has an internal cli-api i'll like to expose to users, which would

simplify mundane, operational/scripting tasks.
make it easier to write regression-tests covering only the cli-api (the current way of testing it is a bit hacky).

Describe the solution you'd like

jslint will export a frozen object: {cli, jslint} instead of a frozen function: jslint.
to use either jslint or the cli:
import jslint from "./jslint.mjs"

// jslint some code as normal
jslint.jslint(`console.log("hello world");`);

// jslint all .js/.mjs files in current-directory via cli
jslint.cli({
    file: "."
}).then(function (exit_code) {
    process.exit(exit_code);
});

Describe alternatives you've considered

the internal-api is currently accessible via a special-option passed thru jslint():
import jslint from "./jslint.mjs"
jslint("", {
    // special-flag to call cli() from jslint()
    cli_mode: true
});

Additional context

this would unfortunately break existing code using jslint, which would need to be modified as follows:
 import jslint from "./jslint.mjs";
 let code = ...
-jslint(code);
+jslint.jslint(code);

nvrmind, i'll keep current exported-function, and treat it as an "object" with attached properties so things won't break.
+jslint.cli = Object.freeze(cli);
+jslint.jslint = Object.freeze(jslint.bind(undefined));
+export default Object.freeze(jslint);

in v2021.6.3, jslint now exports an "object/function".  you can still use it like a function, but it also includes sub-properties jslint.cli() and jslint.jslint().


Implement buildpack

Implement #1
Per this comment on the issue, this PR does not include the staticfile order grouping.
This PR includes:

NGINX order group
HTTPD order group
Basic integration tests
README documentation
Workflows

@paketo-community/web-servers-maintainers bump on this! I think it can be merged without Staticfile support for now.

LGTM


Added method to delete a person on churchtools

As a follow up to #84 I'd like to add a method to call the API endpoint to delete a person record.
It is quite simple to use:
use CTApi\Requests\PersonRequest;

$personA = PersonRequest::find(21);
PersonRequest::delete($personA);

I haven't added documentation or unit tests, because your way of writing those is a bit hard to follow for me :-)
It would be nice if you could do that.

Argh... the last commit message should have been "Updated CHANGELOG"... sorry

Fixed by force push ^^

@naitsirch No Problem!  I admit it's a little hard to understand. I've added the documentation.
I split it up into several commit to improve the readability:

create example-code in "Tests\Unit\DocsPersonRequestTest" 01a6c7572ff429a7f1e298c7813d56e45afec419
add Unit-Test-Method to documentation in Folder docs/src/ressources/PersonAPI.md 33e5e8e3ddf6fca3ade4e95770c8a637de20c3b5
generate the docs with the composer run-script docs-generator command => this will create the documentation with the code example in Folder docs/out/PersonAPI.md 7e70a52b78b049e01494693a070d62e7ccb26da6

I hope this helps!


STYLE: Make xoutbase abstract and add xoutmain type for xout singleton

Made xoutbase<char> an abstract base class (as was already documented), by declaring its destructor pure (= 0) virtual, and its default-constructor protected.
Derived an xoutmain class as the new type of the xout singleton.
Aims to clarify the design of the xout library, by distinguishing clearly between base and leaf classes. See also Scott Meyers's book "More Effective C++", Item 33: "Make non-leaf classes abstract".

For the record, those VS2017 compile errors when declaring xoutbase as an abstract base class can be reproduced by https://rextester.com/WMSL75834 as follows:
#include <valarray>
#include <ostream>
#include <iomanip>

template <class T, class = std::basic_ostream<T>>
struct xoutbase
{
  virtual ~xoutbase() = 0;
  void operator<<(std::ostream & (*)(std::ostream&));
};

void fun(xoutbase<char>& x)
{
  x << std::endl;
}

Error(s):

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): error C2259: 'xoutbase<char,std::basic_ostream<char,std::char_traits>>': cannot instantiate abstract class
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): note: due to following members:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): note: 'xoutbase<char,std::basic_ostream<char,std::char_traits>>::~xoutbase(void)': is abstract
source_file.cpp(18): note: see declaration of 'xoutbase<char,std::basic_ostream<char,std::char_traits>>::~xoutbase'
source_file.cpp(24): note: see reference to class template instantiation 'std::valarray<xoutbase<char,std::basic_ostream<char,std::char_traits>>>' being compiled

For the record, those VS2017 compile errors when declaring xoutbase as an abstract base class can be reproduced by https://rextester.com/WMSL75834 as follows:
#include <valarray>
#include <ostream>
#include <iomanip>

template <class T, class = std::basic_ostream<T>>
struct xoutbase
{
  virtual ~xoutbase() = 0;
  void operator<<(std::ostream & (*)(std::ostream&));
};

void fun(xoutbase<char>& x)
{
  x << std::endl;
}

Error(s):

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): error C2259: 'xoutbase<char,std::basic_ostream<char,std::char_traits>>': cannot instantiate abstract class
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): note: due to following members:
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\valarray(174): note: 'xoutbase<char,std::basic_ostream<char,std::char_traits>>::~xoutbase(void)': is abstract
source_file.cpp(18): note: see declaration of 'xoutbase<char,std::basic_ostream<char,std::char_traits>>::~xoutbase'
source_file.cpp(24): note: see reference to class template instantiation 'std::valarray<xoutbase<char,std::basic_ostream<char,std::char_traits>>>' being compiled


Better logging if  config path not found?

First thing I tried (without thinking) on ubuntu was: ./csd. This failed with error below because /etc/csd/main.conf is not present unless you put it there.

I'm wondering if we can make this a tiny bit better for developers:

Check for existence of the config file in CSD (default or otherwise) and fail with better message - e.g.:

Specified conf file not found (whatever file it is). Use --conf flag to specify configuration file.

Even if we don't do this, would be good to get rid of the other warnings about missing location etc, (as these are spurious/just because of the missing file.
Perhaps have a second default file ./samples/files/ubuntu.conf. Not sure about this, since someone might choose to run on Arch Linux or whatever.

Also, the camera started even though it was missing "required" information. Shouldn't it fail in this case?

@lbegani FYI

More than logging, it is about handling of no or invalid conf file. Currently, if there is no conf file or dir with conf files, that gets parsed successfully, the ConfFile object would be empty.  This empty object is getting passed around. Also, there is no public method to check if the ConfFile obj is invalid. I am thinking of adding changes where ConfFile with no entries will not be passed. This will require making the usage of the ConfFile obj optional in CameraServer, MavlinkServer and RTSPServer. Keeping the issue open till done.


Make lukehoban credit more obvious for the Learn ES6 page

@sebmck @thejameskyle Please check this PR related to #113


Unlist at_demo_data on Pub.dev

Unlist the following packages on Pub.dev ~ @nickelskevin to provide further details

[ ] at_demo_data

Also ensure we leave the readme.md on Github and look for updates (like logo and readme.md standard archetype)

[ ] Review for current logo
[ ] Does it map to current standard archetype

Unlisted it @ksanty @nickelskevin, closing this issue.


Add schema for Generation data

Detailed Description
It would be great to add a schema for the generation data
Context

good to know what the data should look like

Possible Implementation

descriptions
screen shot of xarray dataset
pydantic model? for metadata?

Going to put some thoughts here on this, first of that the bits for using generation data (pv or wind) are not in this repo yet, there is GSP data loading but I think that is different enough that it can be outside the scope of this (can always revisit that), so this schema can start to be used when we add the PV Site Dataset in, and the info for it can be added in then as well:
Reason for having site/generation data schemas:

Easier and clearer for someone to understand what format the data needs to be in for ocf-data-sampler to “just work” with it
Less custom code needed in ocf-data-sampler to support slightly different formats (e.g different power units) (instead input files are put into the schema format before being used with these libraries)
With it it would be easier to have one load function for either pv or wind (feels like a lot of duplicated code between the two currently)

Proposed Schemas:

Metadata (currently csv format) columns, each row corresponds to a single site:

system_id: int
capacity_mw: float
latitude : float
longitude : float
asset_type: e.g solar or wind
ml_id: optional int. This is currently added in if it doesn’t exist and set to -1.

Generation power data (currently netcdf file):

system_id: int, should correspond to the id in metadata
timestamp (utc) datetime64[ns] format, should having granularity which is divisible by 5 mins
power_mw :float

Assumed MW would be the best power unit for this since that is usually the size of the sites we deal with, also removed tilt and orientation for now because I don't think these are actually used anywhere currently.
In terms of enforcing this schema, I think it could be done with the lighter touch side of documentation in a README and comments pointing to that in config rather than automated schema validation (which could be achieved if we used something like this, but I think a lighter touch approach would be adequate for now and make it clearer what is supported and lead to less ad hoc code. Keen to hear people's thoughts on this though. @peterdudfield @dfulu @AUdaltsova, thanks

re: ml_id, I am still a bit hazy on how this is different from site id (when we're talking pvnet-site). and I think all the data i used recently didn't have it. What am I missing?

timestamp (utc) datetime64[ns] format, should having granularity which is divisible by 5 mins
I think we don't require this anymore, but could be wrong

I really like the netcdf organisation! And thanks a lot for doing this :)

I also agree that being super-strict on this is not good right now, we will probably want stuff like tilt and orientation stored in the same files anyway and there might be unforeseen differences we cant reconcile depending on whose data we're using

re: ml_id, I am still a bit hazy on how this is different from site id (when we're talking pvnet-site). and I think all the data i used recently didn't have it. What am I missing?

ml_id is not in general related to site-id at all. Previously we wanted to switch to using ml_id because the IDs had become a real mess in ocf_datapipes. Back then we wanted to use site-level PV history from a few hundred sites as an input to PVNet UK. We had a whole lot of IDs floating round at the time and couldn't match between a given PV site in the production database and in the training data - i.e. we couldn't tell which PV site was which. ml_id was used to allow us to do that, but it is a misnomer as it has nothing to do with ML really.
I think that currently ml_id would still be needed to map between the training and production PV sites in the UK but I haven't looked at this in a year. We also aren't using PV site data as an input to PVNet UK. So we may want to revisit whether we need ml_id or if we can use a single id for systems. I think having a schema could help with the transition to a single ID

So i think its good for ml_id to start very small, so our embedding dim can be small.
Sometimes its useful to have a site id which maps to the system_id that the client has given us, so we know which site is which.
I think that was the motiviation
I'd be tempted to

get ride of ml_id
use system id for what we embed on
add client_site_name:str which we can use as a mapping from client name/id to ml_id

Thanks for the comments all, that is really helpful!
I agree with those points and suggestions and have updated the proposed schemas above, the next step will be to add this info in/use these schemas for renewable generation data files when we add in those datasets for PV and Wind here, hopefully it will be useful in the long term!

Just ran into this, so a heads-up: https://github.com/openclimatefix/PVNet/blob/aa76d4a748fc94f429daa2c5cf0608c82c447038/pvnet/utils.py#L94 expects system_id to be called pv_system_id (though I think the only place this function is used is the site backtest script...)

I would lean towards one netcdf for all sites, I think it's easiest/get the input datasets together that way
Also on the units perhaps MW should be kW as I think this is the most used power units across our code base. Finally, I think we should stick to "site" or "system", I have gone with "site" since I think that is what we use most now, updated the schema outline above to reflect this

yea i like

1 nc file
site
kW probably is easier at the moment, and the units should be in the variable name!


ders2_ - what about another mnemonic identifier?

It's said "2D"...

comparison between rng vertically consecutive pixels, forming ders2: 2D tuple of derivatives per pixel

What about ders2d_ ? Or dersy, dersY, ders2Y, dersV (vertical)
If the first are "1D" - ders1d (or no change), dersl (lateral, but small L is a bad letter in most fonts), ders1D, dersL
Or dersx, dersy , or dersX, dersY  or whatever more suggestive.
…
Unless there will be a sequence with numbering: ders3, ders4 etc.... Then it may be consistent with numbers as well.
https://github.com/boris-kz/CogAlg/blob/de001789fff4600b91b0ccf336844a4d47ebdb00/frame_dblobs.py#L64

I want to keep it brief, for the meaning you can just check content or
comments
On Thu, Sep 27, 2018 at 9:06 PM Todor Arnaudov<EMAIL_ADDRESS>wrote:

It's said "2D"...
comparison between rng vertically consecutive pixels, forming ders2: 2D
tuple of derivatives per pixel
What about ders2d_ ? Or dersy, dersY, ders2Y, dersV (vertical)
If the first are "1D" - ders1d (or no change), dersl (lateral, but small L
is a bad letter in most fonts), ders1D, dersL
Or dersx, dersy , or dersX, dersY or whatever more suggestive.
https://github.com/boris-kz/CogAlg/blob/de001789fff4600b91b0ccf336844a4d47ebdb00/frame_dblobs.py#L64
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boris-kz/CogAlg/issues/13, or mute the thread
https://github.com/notifications/unsubscribe-auth/AUAXGY4eMUNRf4KVZKkmV3NQocXUJ7CZks5ufXYQgaJpZM4W9r-f
.

OK


cmd/update-report: output to stderr when not a TTY.

Otherwise things like $(brew bundle list --formula) become a bit useless as they can auto-update and then will always fail.

Review period will end on 2021-02-04 at 13:33:39 UTC.

Review period ended.


nzValidateStatus & nzHasFeedback overlap with nzSuffix

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-zahkan
Steps to reproduce
<form nz-form>
	<nz-form-item>
		<nz-form-label [nzSpan]="5">Password</nz-form-label>
		<nz-form-control [nzSpan]="12" nzValidateStatus="success" nzHasFeedback>
			<nz-input-group [nzSuffix]="suffixTemplate">
				<input
        [type]="passwordVisible ? 'text' : 'password'"
        nz-input
        placeholder="input password"
        [(ngModel)]="password"
      />
    </nz-input-group>
        </nz-form-control>
      </nz-form-item>
</form>

<ng-template #suffixTemplate>
      <i nz-icon [nzType]="passwordVisible ? 'eye-invisible' : 'eye'" (click)="passwordVisible = !passwordVisible"></i>
</ng-template>

What is expected?
Icons are displayed next to each other
What is actually happening?
Icons overlap

Environment
Info

ng-zorro-antd
7.5.1

Browser
77.0.3824.6

P.S. Issue Helper can't handle "&" sign:

Issue title

Issue title after pressing "Create"

Hi @Svetomechc
you can add the style below as temp solution, we will release the fix version in 8.0.0
form .has-feedback .ant-input-suffix i {
    margin-right: 18px;
}

Thank you. I will wait for 8.0.0 (I already worked around this issue for now).

Tried release candidate. I am really sorry to say that your fix is quite subpar because it adds a constant margin, no matter if there are two icons or one.
See demonstration:

This is OK

This is NOT

Previously icons would always stick to the right. But now second image looks like a regression from ng-zorro-antd 7.x.x.
Please reopen.

@vthinkxie, please reopen.

Still the same.

@Svetomechc
the fix version has not released yet

@vthinkxie oh sorry, my bad.

@vthinkxie By the way, thank you for all your hard work and patience. Much appreciated (:

try this
form .has-feedback.has-success .ant-input-suffix i,
form .has-feedback.has-error .ant-input-suffix i,
form .has-feedback.is-validating .ant-input-suffix i{
    margin-right: 18px;
}

@vthinkxie this still makes [nzSuffix] position a bit off.

With fix above

Should be

https://stackblitz.com/edit/ng-zorro-antd-start-dgfg2j?file=src%2Fstyles.css
@Svetomechc

Hmm, looks OK to me. Have to investigate why it doesn't work in my case. I will
As a side note, I think [nzSuffix] should be displayed to the right of [nzHasFeedback] icon, not to the left.


(1.12) Fix 500 responses from v0 metrics API

High-level description
This is a 1.12 backport of #3436.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4088 metrics v0 API 500 error: "Failed to encode value to JSON"

Related tickets (optional)
Other tickets related to this change:
N/A
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: This fixes a bug that has yet to be released.
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): https://github.com/dcos/telegraf/compare/ccb5eb8c53842b690ace1af2c40ff6101e0dc93e...071b143b1c93f03e5469378d082ec14dacf41674
[x] Test Results: link to CI job test results for component
[x] Code Coverage (if available): link to code coverage report

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review

teamcity/dcos/test/aws/onprem/static  needs an override with https://jira.mesosphere.com/browse/DCOS_OSS-2115.

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static DCOS_OSS-2115

@mesosphere-mergebot bump-ee


fix(list-box): match experimental spec

Closes #2167
Related: https://github.com/IBM/carbon-components-react/issues/2022
This PR modifies the base listbox to match the experimental spec and lay the foundation for MultiSelect, ComboBox, and DropdownV2 changes in React
Changelog
New

invalid state support
docs examples

Changed

listbox hover color
spacing for inline and block level listbox elements
listbox menu list max-height

Removed

redundant styles

yeah @asudoh from my testing on IE11 the inconsistencies seemed to be on par with most of our other flex or grid components when viewed in IE11. I used grid here because I initially wanted to reduce markup changes as much as possible especially since multiple components are based on listbox. That being said, I am willing to refactor using the wrapper div approach like I used for some other form components if we would ultimately prefer that
the v9 markup is completely preserved after this line. I just removed the if/else blocks for the new icon SVGs and left the legacy icons

thanks for the feedback! this is ready for another review @laurenmrice

Hey I'm jumping in only because we are near code freeze, @laurenmrice @emyarod. I still see one error:
Light variant:

[ ] The opened drawer options should have White background too, should be $field-02 token, same as the dropdown's closed state background.

Other than that, it's all good!


added turven

Description
I have added turven.
Fixes #47
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Please make all PRs to hakincodes branch.

@mharshita ??

@garimasingh128 @ShauryaBhandari  Sorry but i dont know how to shift to another branch.

There's an edit option near the title of your PR on the top of this screen. Do that from there. Or google it simply.

@garimasingh128  Done!

Conflicting files
public/index.html
Please do a pull and resolve these.

@garimasingh128  I have done it. Please review. and also sorry for the delay.


Table Content overflow in responsive

Description
In the below URL, the table content is not showing properly in the responsive(320px) design.
Page URL: https://wordpress.org/openverse/sources/
For better understanding, I provided the Video attachment
Video URL: https://share.cleanshot.com/N09QQ0MzRdKvJ4fZkV8t
Thanks.

Thank you for reporting this error, @kajalmultidots. The video is very helpful.


Alarm.com Hundreds of "Successful Web Login" Notifications

Hello, I just recently installed the AlarmDotCom integration on my Home Assistant OS.
For clarity I am referring to the integration as AlarmDotCom and the alarm system as Alarm.com
I have tried this on v0.1.12 and v0.2.0-beta.7
It was great to see all the Alarm.com sensors on my same dashboard and be able to arm and disarm my Alarm.com panels all from one app (Home Assistant).
But the AlarmDotCom integration seems to be repeatedly logging in every minute or so (generating hundreds of notifications) on Alarm.com and totally burring any relevant sensor state changes in the Alarm.com app.
I've temporarily disabled the login notifications and texts from Alarm.com, so my phone has stopped blowing up.
I found that when I disable "polling for updates" on the AlarmDotCom Integration, the frequent logins stop but so does my stream of sensor state changes from Alarm.com.
I'm sure I've just configured something incorrectly.
How should I configure the AlarmDotCom integration to stay logged into Alarm.com, as to not spam me with login notifications?
While also viewing the Alarm.com sensor states in Home Assistant?
I don't need to be able to arm and disarm the alarm from HA, but would like to be able to see the sensor states and current panel status.
Thanks,
Danno

Are you seeing this behavior in both v0.1 and v0.2?

I am, I stopped the v0.2 after 10 minutes after getting 7 notifications.

Got it. The add-in doesn't keep an open session with the web server -- it logs back in every time it wants to refresh data. It would add decent amount of complexity to (and opportunities to introduce bugs) to keep the connection alive. It would be great it someone could take a stab at implementing a keep-alive model here, but I think the best near-term solution is to turn on 2FA (to beef up security) and to turn off login notifications.

Thanks! 2FA did the trick. My provider dint prompt for it so I didn't realize it was available.


Add CLI

Ref https://github.com/datetime/current-day-number/issues/2.

Coverage remained the same at 100.0% when pulling ad14046fc024588587d006f16b17e22b64ccf945 on arthurvr:cli into 8d5e4cfdb501e0c3039c6ebe8324ab8f5f1919b3 on datetime:master.

Coverage remained the same at 100.0% when pulling ad14046fc024588587d006f16b17e22b64ccf945 on arthurvr:cli into 8d5e4cfdb501e0c3039c6ebe8324ab8f5f1919b3 on datetime:master.

Coverage remained the same at 100.0% when pulling 4808baa49b405a79b7f3263346b1034809d4f1b6 on arthurvr:cli into 8d5e4cfdb501e0c3039c6ebe8324ab8f5f1919b3 on datetime:master.

@tunnckoCore ping?

Ping-pong.
Cool, thanks!
I'll merge and publish ASAP. :)

I'll merge and publish ASAP. :)

@tunnckoCore friendly ping once again?

@arthurvr ooh thanks, mate. I totally forgot. :+1:
Wait a bit :)

It's okey, but I think it should also handle and other cases.

It's okey, but I think it should also handle and other cases.

Sure. I will update my PR.

Hm. But its interesting how to handle 'August 07, 2016 in cli ;d

Okey, great. :)

http://gyazo.com/f8e629c80cb2ea5641f251f3c017fecb, LGTY?

Hm. But its interesting how to handle August 07, 2016 in cli ;d

What do you mean?

Coverage remained the same at 100.0% when pulling 9397d9cca657dc8af44d236aca2cb979a70f81e6 on arthurvr:cli into 8d5e4cfdb501e0c3039c6ebe8324ab8f5f1919b3 on datetime:master.

Haha, cool. Looks great.

@arthurvr released and published as v1.0.6


Update stable version in repo from 1.7.6 to 1.7.7

Think about update stable version to 1.7.7
Version: stable=1.7.6 (65 days old) => latest=1.7.7 (25 days old)
Installs: stable=272 (52.61%), latest=26 (5.03%), total=517
Click to edit

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.7.7 but the current stable version is already 1.7.7.
So this issue should be closed.


Feature: Adjustable timer multiplier instead of idle timer checkbox.

Let game hosts set a timer multiplier (defaulting to 1x, which is equivalent to having the old idle timer checkbox "checked") for speeding up or slowing down the idle timeout.
Tested and working on my private PYX server.

Eh, doesn't match my preferred style, but I don't see anything particularly wrong with it. If anything, my fault for not having a checkstyle thing set up.


Schemix CLI

Would it be easier if there was a schemix CLI that was responsible for outputting the schema.prisma file?
In this situation, the schemix configuration would be formalized into a file (think schemix.config.ts or schemix.config.js and would export a default object which would contain a configuration.
After this, you could run a "schemix CLI" that would generate your output file.
schemix mix

Would look in the root directory for a config file, otherwise you would be able to provide it options directly and override options in the config if desired.
schemix mix --config ./some-other-file.ts --output ./otherly-named-file.prisma

would love to take this up
will try to contribute to this project
Amazing work with Schemix though <3

Closed in favour of #75, which will track the next major version of schemix which will include these improvements!


Map with Control Measures Symbols Issues and Updated MilitaryOverlay gdb Readme

A list of the point, line and area control measures, documenting any
symbol and label issues. Pro 1.1 project package.

Pro package looks good, the only minor issue that should be fixed is that the basemap is pointing to the internal portal version (which can't be seem when opened from public)

Also - the Readme changes are included in this PR so I'll just review these changes here. While we are updating this table, we should probably fix all of the inconsistencies: (1) sort table by the Field ID (2) remove the "2525C" column (3) make the ones like "T1" "Unique Designation 2" consistent (4) fix anything that looks weird or makes the table hard to use

The field "Are Layers Correct" should be called "Are Labels Correct"

This old/temp field should be removed:

@csmoore repackaged project with edits and fixed issues in Military Overlay gdb Readme. Verify all issues have been fixed?

Test dataset/project package and updated datamodel readme look really good. Thanks for the fixes/improvements & going through the multiple passes needed to get the datamodel table updated and reviewed.

:+1:


docs(contributing): Add Windows requirements

Resolves #1428

I'll make sure it's reviewed before the end of the week

Thank you @JoseLion for your contribution!


[Feature Request] OpenSearch Mascot

Is your feature request related to a problem? Please describe
Mascots are cute, fun, and add brand recognition.
Who doesn't love the Linux Penguin or the Gradle Elephant?
OpenSearch deserves its own mascot.
I asked ChatGPT for some reasons to have a mascot and I tend to agree with the all knowing guru:
"Selecting a mascot for OpenSearch, is not merely about choosing a cute or quirky character; it's about embodying the spirit, values, and aspirations of the platform. A compelling mascot can serve as a symbol of unity, innovation, and community collaboration, reinforcing OpenSearch's commitment to openness, transparency, and inclusivity.
Here's why choosing a mascot for OpenSearch is crucial:

Brand Identity: A mascot can significantly enhance brand recognition and recall. OpenSearch, being a crucial tool in the tech ecosystem, needs a visual representation that can quickly resonate with users, developers, and contributors alike. A well-designed mascot can become synonymous with the platform, fostering a sense of familiarity and trust.

Community Engagement: A mascot can serve as a rallying point for the OpenSearch community. By involving the community in the selection process, whether through submissions or voting, you foster a sense of ownership and belonging. This engagement can lead to increased participation, contributions, and overall enthusiasm for the project.

Communicating Values: The right mascot can effectively communicate the values and principles that OpenSearch stands for. Whether it's openness, collaboration, or innovation, the mascot becomes a visual embodiment of these ideals, making them more relatable and tangible to users and contributors.

Marketing and Outreach: A memorable mascot can be a powerful marketing tool. It can be used across various promotional materials, social media campaigns, and merchandise, helping to generate buzz, attract new users, and foster a sense of community around the platform.

Differentiation: In a crowded marketplace, a distinctive mascot can help OpenSearch stand out from competitors. By choosing a mascot that is unique, memorable, and reflective of the platform's values, you create a distinct identity that sets OpenSearch apart in the minds of users and stakeholders.

Emotional Connection: Finally, a well-designed mascot has the potential to evoke emotions and create a personal connection with users. Whether it's through humor, charm, or relatability, the mascot can elicit positive feelings towards the platform, fostering loyalty and advocacy among its user base."

So let us address the most pressing need our project and select a mascot.
Here are some possible options:

An octopus: OpenSearch starts with "O", octopi can already be blue colored, OpenSearch can do many things at once like an octopus

A spider: Spiders have 8 eyes and OpenSearch lets you see lots of data

A dragon: Dragons are very cool

Describe the solution you'd like
We pick a mascot.
Related component
Other
Describe alternatives you've considered
Not having a mascot, which is very heartbreaking.
Additional context
No response

I vote for an Octopus.

they are very intelligent
Aiven.io already use an Octopus for OpenSearch service which will make it very easy for them

@scrawfor99 Love this idea, thanks for pushing for this.  What do you think about creating a visual representation of these mascots?
@krisfreedain Can we amplify this topic for broader community engagement?

@scrawfor99 - haha, this is entertaining for sure. Why not, right? I would love to see what all the community comes up with. We would of course need to see how and what it would take for the project to have a mascot. (legal, etc) But it couldn't hurt to get the community's creative ideas going.

cc @opensearch-project/opensearch-ux

I'm definitely biased, but perhaps some variation on our 'Sweaterbot' that doesn't directly reference my skull sweaters?

How about an owl?
Archetypically wise
Starts with O

How about a beaver, 😄
OpenSearch is a central Logging server.

How about Dolphin?
Noted for their grace, intelligence and friendliness

changed title to [RFC] to get more eyes on this.

Pretty much has nothing to do with OpenSearch, but I'm partial to dogs and using this as an excuse to introduce my dog. Meet Sequoia everyone :)

Adorable 🥰
On Tue, Jun 11, 2024 at 9:01 AM Eli Fisher @.***> wrote:

Pretty much has nothing to do with OpenSearch, but I'm partial to dogs and
using this as an excuse to introduce my dog. Meet Sequoia everyone :)
image.png (view on web)
https://github.com/opensearch-project/community/assets/10850824/e6e7e0c9-1878-43c6-b9b2-22b9ab09cabe
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/community/issues/24#issuecomment-2161119738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5VIBRO3TJDJULQ7SLPW3K3ZG4NPBAVCNFSM6AAAAABICKRWZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGEYTSNZTHA
.
You are receiving this because you commented.Message ID:
@.***>

Dolphin

Octopus

Beaver

Dragon

Robot

Owl

I'm heavily biased towards dolphins. 🐬 😀
Data interpreted and simplified is superior to raw data in some sense. And related to that dolphin as a mascot confirms what Douglas Adams might have meant:
“For instance, on the planet Earth, man had always assumed that he was more intelligent than dolphins because he had achieved so much—the wheel, New York, wars and so on—whilst all the dolphins had ever done was muck about in the water having a good time. But conversely, the dolphins had always believed that they were far more intelligent than man—for precisely the same reasons.”
― Douglas Adams, The Hitchhiker’s Guide to the Galaxy
And also the shapes of the logo remind me of dolphins as well.

Beaver

It looks like Octopus has the most votes so far - do we have any artists that want to draw up a few proposals for the community to vote on?

I challenged ChatGPT to come up with another mascot suggestion based on your text, and it suggested a curious and adventurous Fox named "Scout". Here is the complete prompt response: https://gist.github.com/janhoy/7018b78c986a0c9a8da6096d49110a39. And here is the generated sample image:

Hi @janhoy thanks for sharing! That is really cute too. I am happy if people want to revote based on the additional option. I am not the best cartoonist so have been hoping someone would volunteer to mock some options to decide from. If that does not happen, I will go ahead and do my best to make some choices for us to select from.


DCS-98 content changes for check your answers

Fix incident type ‘was use of force planned’
involved staff per line
Witnesses per line
Was the prisoner compliant? Needs to be a question yes/no
Remove ‘-‘ where we use ‘and’ in questions
Employee number move to actual numbers
Staff taken to hospital - none when nothing
Staff needed medical attention - none

Not sure what the Remove ‘-‘ where we use ‘and’ in questions means?

Oh, that's not very clear! - Andy told us to remove the dash where previously used the patternYes - and was used


add adobeDataLayer checkbox

update to support auto listener on adobeDataLayer.push of events

I am setting page context data in a preceding adobeDataLayer.push. To capture both the AdobeDataLayer state from that, combined with the current event's data I am doing this:
var tealiumData = {}; Object.assign(tealiumData,event.message.eventInfo,adobeDataLayer.getState());
Then I'm passing that object in as the event payload. FYI


Android And Web

I want Android and web real-time video, but no matter which side has not received the other party's video.server.key in assets,Does the server.key need to be configured in the project?where configured?

I not found assets folder and  server.key in you project.I create a assets folder in main folder


Q: any plan on releasing a new version with updated dependencies..

I would like to get rid of this
<dependency>
            <groupId>edu.uci.ics</groupId>
            <artifactId>crawler4j</artifactId>
            <version>4.4.0</version>
            <exclusions>
                <exclusion>
                    <groupId>com.sleepycat</groupId>
                    <artifactId>je</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <!-- https://mvnrepository.com/artifact/com.sleepycat/je -->
        <dependency>
            <groupId>com.sleepycat</groupId>
            <artifactId>je</artifactId>
            <version>18.3.12</version>
        </dependency>

To avoid the illegal reflective access warnings..

There are some forks available with updated dependencies. Might be worth switching as this libary seems dead...

@rzo1 any suggestion of a fork ? :-)

@rzo1 any suggestion of a fork ? :-)

We are using a custom, slightly refactored version for some of our research projects.

Actually, you can simply dependency-manage the version of com.sleepycat:je, then you do not need the exclusion. But anyway, this issue is more pressing now because com.sleepycat:je:5.0.84 is no longer available on Maven Central.


Modify VarReader::read() to read dynamically sized variable

It is possible to read dynamically sized variables, so I'd like it to be exposed directly in VarReader (because its easier to work with, and APIs are all about making things easier, right ?)
Example on Windows: https://github.com/netaneld122/firmware-variables/blob/a3f7d5993f043816fc4f9a5cdf4aa2553d2c7fc4/src/firmware_variables/variables.py#L44
I think that would also deprecate VarReaderEx

I don't have perms to do so but let's say I'm assigned to this issue

It is possible to read dynamically sized variables, so I'd like it to be exposed directly in VarReader (because its easier to work with, and APIs are all about making things easier, right ?)
Example on Windows: https://github.com/netaneld122/firmware-variables/blob/a3f7d5993f043816fc4f9a5cdf4aa2553d2c7fc4/src/firmware_variables/variables.py#L44
I think that would also deprecate VarReaderEx

That seems like a good idea, the current API isn't the best to be honest (I was just starting Rust back then) so it makes sense to change it.


Errors when running practical_identifiability.jl

I tried running the practical_identifiability.jl file. I get this error:
┌ Warning: Assignment to `F` in soft scope is ambiguous because a global variable by the same name exists: `F` will be treated as a new local. Disambiguate by using `local F` to suppress this warning or `global F` to assign to the existing global variable.
└ @ ~/work/practical_identifiability.jl:89
ERROR: LoadError: UndefVarError: F not defined
Stacktrace:
 [1] top-level scope
   @ ~/work/practical_identifiability.jl:89
in expression starting at /home/jovyan/work/practical_identifiability.jl:84

I tried adding global in front of F on line 89, as suggested. I then get this error:
# julia practical_identifiability.jl
ERROR: LoadError: KeyError: key :tickfont_pointsize not found
Stacktrace:
  [1] getindex(h::Dict{Symbol, Any}, key::Symbol)
    @ Base ./dict.jl:481
  [2] default(k::Symbol)
    @ Plots ~/.julia/packages/Plots/tXtrW/src/args.jl:1083
  [3] warn_on_unsupported_args(pkg::Plots.GRBackend, plotattributes::RecipesPipeline.DefaultsDict)
    @ Plots ~/.julia/packages/Plots/tXtrW/src/args.jl:1616
  [4] _add_the_series(plt::Plots.Plot{Plots.GRBackend}, sp::Plots.Subplot{Plots.GRBackend}, plotattributes::RecipesPipeline.DefaultsDict)
    @ Plots ~/.julia/packages/Plots/tXtrW/src/pipeline.jl:413
  [5] add_series!(plt::Plots.Plot{Plots.GRBackend}, plotattributes::RecipesPipeline.DefaultsDict)
    @ Plots ~/.julia/packages/Plots/tXtrW/src/pipeline.jl:343
  [6] _process_seriesrecipe(plt::Any, plotattributes::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/F2mWY/src/series_recipe.jl:46
  [7] _process_seriesrecipes!(plt::Any, kw_list::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/F2mWY/src/series_recipe.jl:27
  [8] recipe_pipeline!(plt::Any, plotattributes::Any, args::Any)
    @ RecipesPipeline ~/.julia/packages/RecipesPipeline/F2mWY/src/RecipesPipeline.jl:97
  [9] _plot!(plt::Plots.Plot, plotattributes::Any, args::Any)
    @ Plots ~/.julia/packages/Plots/tXtrW/src/plot.jl:208
 [10] #plot#135
    @ ~/.julia/packages/Plots/tXtrW/src/plot.jl:91 [inlined]
 [11] heatmap(args::Any; kw::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}})
    @ Plots ~/.julia/packages/RecipesBase/qpxEX/src/RecipesBase.jl:410
 [12] top-level scope
    @ ~/work/practical_identifiability.jl:95
in expression starting at /home/jovyan/work/practical_identifiability.jl:95

I've tried Googling around a bit, but I couldn't find anything with a similar issue.
I'm running the file through docker version 4.5.1, with julia v1.7.0. Running it on Windows 10 with julia v1.7.2 produced the same errors.
Any help would be appreciated.

That solved the first error, but I still get the second error when I try to plot the heatmap on line 92.

Ah, that worked. Thanks a lot!


Remoterendering test pipeline missing environment variable

Description
The test pipeline for the remoterendering sdk is missing an environment variable, thus all tests run fail in the setup process.
This PR adds this environment variable and should fix the tests or at least will run them, so we can see if something is really broken and not only the environment.

/azp run


Add Gaest.com to list of sites

We're huge fans of tachyons at Gaest.com!
It's a platform for booking (and renting out) meeting rooms (in 8 countries and 6 languages and counting) with a frontend written in React and originally custom CSS via CSS Modules. There's still some custom styling here and there, but over the past year we've moved most of the site over to tachyons and are continually impressed with how much is possible with just the classes that tachyons provides 🙌

Thanks @bewildergeist! There were merge conflicts with this pr so I added it manually.


[x-generate-default-message-map] allow writing to a file directly

this prevents PowerShell from adding CRLFs when doing a >
cc @BillyONeal

Can you fix the validation bit to use this so that the command it runs actually does the right thing?

Can you fix the validation bit to use this so that the command it runs actually does the right thing?

I see you did, thanks so much <3!


add beforeNow & afterNow rules

add date relative rules: afterNow beforeNow
Often (at least in my case), date rules are relative to now.

var indic = new(require('indicative'));
var moment = require('moment');

var rules = {
    exp_date: 'afterNow:12,months'
};

var data = {
   exp_date: moment().add(14, 'months').toISOString()
};

indic.validate(rules, data)
.then(function() { // valid data });

function arguments are

offset : positive or negative number
key: key values of moment().add add

If it suits you, could you please accept this PR.
Thanks

I believe method names have to little different , if i read them in english like after now 12 months makes less sense to me.
It should be something like after offset of 12 months , and before offset of 12 months
after_offset_of:12,months
before_offset_of:12,months
What you think ?

clearer, you're right.
I'm thinking about message handling too.
I've written some code that allow to show and format the pivot date.
var defaultMessages = {
  after_offset_of:  "Date must be after  {fmt:DD/MM/YYYY}",
  before_offset_of:  "Date must be before {fmt:DD/MM/YYYY}",
};

And implementation is

function parseMsg(message, pivot) {
 var matched = /.*\{(fmt:?([\w\s\\\/-]*))\}/.exec(message),
     dateFormat = 'YYYY-MM-DD';
 if (matched && matched.length && matched.length >= 3) {
   dateFormat = matched[2];
 }
  return message.replace(/(\{.*\})/, pivot.format(dateFormat));
}

function afterOffsetOf(data, field, message, args) {
  return new Promise(function(resolve, reject) {
    var pArgs = parseArgs(args),
        pivot, fieldValue;

    if (!R.has(field, data)) {
      return resolve("empty field");
    }
    fieldValue = moment(data[field]);
    pivot = moment().add(pArgs.offset, pArgs.key);
    if (fieldValue.isAfter(pivot)) {
      return resolve("is after offset");
    } else {
      return reject(parseMsg(message, pivot));
    }
  });
}

Do you think it is ok to add this stuff?

No this is very specific to this method only  and will confuse people as api has to be unified. I understand it takes the flexibility off but very customize things should be taken care at application level not at module level.

ok.
what do you suggest for displaying the pivot date the user?

You can make use of custom messages. Check them out here http://indicative.adonisjs.com/docs/node-validation-messages

Not clear for me.
I know the custom messages.
I don't understand how I can access the pivot date and show it in the message.
Can you make an exemple?

Haven't tried but this should work , and yes you have to require moment to the file where you are defining messages
Date should be after " + moment().add({{arg.0}},{{arg.1}}).format("DD/MM/YYYY")

Okay , i do not think there is any way to format message by passing it to moment.format , may be you have to do it manually.
var offset = '12'
var key = 'months'

var rules = {
  after_offset_of: offset + ',' + key
}

var messages = {
  after_offset_of: "Date should be after " + moment().add(offset,key).format("DD/MM/YYYY"))
}

yes, it looks better ;)
would you allow to have a message as a function that return a string?
var messages = {
  after_offset_of: function(rule, field, arrArgs, value) {
   return "Date should be after " + moment().add(arrArgs[0], arrArgs[1]).format("DD/MM/YYYY"))
 }
};

I know, I never stop :)

hahah , yes i was thinking about same. For now i think you have to go with custom solution, i have planned ton of changes on indicative, will do them soon.
And i am happy to accept the PR if you can change the function names

nice.
If you can share your plan it'll make me happy :)
I send you a new PR

sure i will soon , completing tasks list for http://adonisjs.com/ v2 right now

Published v1.3.0

This may help you https://trello.com/b/wrAVl3FJ/indicative-2-0

remove coffee - youpi :)
I love trello
thanks and good night


update cosmos-sdk and ibc-go (breaking change)

Update cosmos-sdk and ibc-go dependencies

Codecov Report

Merging #398 (584bc44) into main (838c0d2) will increase coverage by 0.31%.
 Consider uploading reports for the commit f80af72 to get more accurate results

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   28.26%   28.58%   +0.31%
==========================================
  Files          47       47
  Lines        6400     6574     +174
==========================================
+ Hits         1809     1879      +70
- Misses       4446     4548     +102
- Partials      145      147       +2

Impacted Files
Coverage Δ

module/app/app.go
0.60% <0.00%> (-0.03%)
:arrow_down:

module/x/gravity/handler.go
43.24% <0.00%> (-3.82%)
:arrow_down:

module/x/gravity/keeper/keeper.go
86.27% <0.00%> (-3.60%)
:arrow_down:

module/x/gravity/types/msgs.go
12.00% <0.00%> (-1.73%)
:arrow_down:

module/x/gravity/keeper/ethereum_event_vote.go
50.73% <0.00%> (-0.51%)
:arrow_down:

module/x/gravity/keeper/grpc_query.go
17.17% <0.00%> (-0.44%)
:arrow_down:

module/x/gravity/types/codec.go
5.71% <0.00%> (-0.06%)
:arrow_down:

module/x/gravity/types/key.go
0.00% <0.00%> (ø)

module/cmd/gravity/cmd/gentx.go
0.00% <0.00%> (ø)

module/x/gravity/client/cli/query.go
0.00% <0.00%> (ø)

... and 3 more


no-route is limited

as far as I know no-route is limited on 200 lines
is there any alternative way to restrict/split the client to connect national internet(Iran's network)?
Great Firewall is sensitive to foreign IPs

You can put your AnyConnect client into docker and expose a SOCKS5 proxy. Then you can use any rules you like.
For users in Iran, my suggestion is that AnyConnect's protocol is easy to detect but unable to decrypt. If you just want to break through the Firewall of Iran, you may try WireGuard, trojan, etc. AnyConnect isn't best solution.

I mostly use Trojan and Xray protocols to browse in internet but I also play some games that are not that popular
I think the great firewall detected it's host server as a bad service and blocked it, I can connect to it and play but after a few minutes the connection goes down and I have to relog into the game. Thats what I need the VPN for
I need stable and low latency to play games that's why I'm using open connect
wiregaurd must be good for gaming if I'm not wrong but i have no idea how to set it up

You can try tun2sock or SS-TAP for games. I don't know Iran's firewall technology.

people say that it is the same as china's

You can try out these VPNs one by one. If you are temp block, do not connect back immediately, it will cause a permanently block.

thank you so much for your response.
much <3

You can try out these VPNs one by one. If you are temp block, do not connect back immediately, it will cause a permanently block.

how would I realise if im temp blocked or not?

temp block means you can't connect to your VPN, but ok on SSH port or HTTP 80 port. If you are temp blocked, do not make VPN connect for several days.


chore(build): ship es modules

this will produce a package.json something like this:

@chasestarr Unfortunately there is not any exhaustive or canonical documentation regarding the "module" field. However, by convention and de-facto implementations in webpack and Rollup, the "module" field behaves exactly the same as the "browser" field, which can be a map, per the spec: https://github.com/defunctzombie/package-browser-field-spec
In webpack, all these resolution rules are handled by: https://github.com/webpack/enhanced-resolve. In webpack itself, the browser target merely has an additional "browser" value in the resolve.mainFields list: https://github.com/webpack/webpack/blob/88a5050fa837506ff456bcff3d8d443ec9998caa/lib/WebpackOptionsDefaulter.js#L337-L345


Nlog DatabaseTarget stops logging after reseed

Hi! Thanks for reporting this feature/bug/question!
we have using Nlog version 4.5.10 for logging the details from web application and windows services. Logging worked fine (logs in to sql db and file) but suddenly stopped logging into the sql db.log table and not seen any errors in eventlogs. (at the same time i see logs in logfile)
If was happening quite few times 2 times before,
Resolution : deleted the log table and created it again it started logging into the sqlserver log table.
we are running job everyday to remove old data logs n days less and reset the seeding.
DBCC CHECKIDENT (log, RESEED, 0);
is this causing issue to stop.
but it does not happened very often only 3 times in 9 months.
Also please let me know steps to find reason why it got halted or stopped
Note: It looks similar to this issue https://github.com/NLog/NLog/issues/1997
Thanks

Please check the internal log. Enable it for Warning at least, and the next time, please post it here :)

Resolution : deleted the log table and created it again it started logging into the sqlserver log table.

Sounds like a timeout?

Hi Team,
As specified, I have enabled  internal log and got below errors.  with logs I figured out the issue is primary key error and it is occured due to sql job which run everyday for deleting old records and reset the seed as show below
**Root Cause :- **
we are running job everyday to remove old data logs n days less and reset the seeding.
DBCC CHECKIDENT (log, RESEED, 0);
Resolution:-
Setting back reseed with current seed value in the column value it started inserting records.
Internal Errors:-
2020-04-25 00:12:39.3469 Error Error parsing layout aspnet-request will be ignored. Exception: System.ArgumentException: LayoutRenderer cannot be found: 'aspnet-request'. Is NLog.Web not included?
at NLog.Config.Factory2.CreateInstance(String name)    at NLog.Layouts.LayoutParser.GetLayoutRenderer(ConfigurationItemFactory configurationItemFactory, String name) 2020-04-25 00:12:39.4230 Error DatabaseTarget(Name=sqldatabaselog): Error when writing to database. Exception: System.Data.SqlClient.SqlException (0x80131904): **Violation of PRIMARY KEY constraint 'PK_dbo.Log'. Cannot insert duplicate key in object 'dbo.Log'. The duplicate key value is (417531).** The statement has been terminated.    at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)
at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)    at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)    at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)    at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted)    at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)    at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)
at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at NLog.Targets.DatabaseTarget.WriteEventToDatabase(LogEventInfo logEvent)
at NLog.Targets.DatabaseTarget.Write(LogEventInfo logEvent)
ClientConnectionId:ee275dc7-0156-423b-a5c8-b2e12cd01e34

but I want to reseed inorder to avoid max number (in case int / big int) if you have any other way please do let me know.

Use a guid/uniqueidentifier?

yes we have multiple services each logs lots of data and it is real time tracking we are using nlog to trace out if for issues validations.
Problem is that if we dont delete log table size increases drastically

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info -
thanks!


Add test scenario for account to multiSig rekey transaction

Closes #x
Proposed Changes

added unit test to check if the spend address was changed to multiSig address
added unit test to check if it is possible to spend from the account using one of the multiSig addresses

TODO

[x] Add unit tests
[ ] Add more test scenarios:

[ ] rekey multiSig to account

[ ] Verify if the tests are correct
[ ] Fix the potential problems

Should we change this to a draft PR until all subtasks are solved?


BlackHoleGlowCard has two warnings when first loading project

Two shader warnings when first loading GE into Unity:
Shader warning in 'BlackHole/BlackHoleGlowCard': Output value 'vert' is not completely initialized at line 40 (on d3d11) Compiling Vertex program
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_NO_CUBEMAP_ARRAY UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF3 UNITY_HARDWARE_TIER1 UNITY_COLORSPACE_GAMMA UNITY_LIGHTMAP_RGBM_ENCODING

Shader warning in 'BlackHole/BlackHoleGlowCard': 'vert': Top-level return value is not completely initialized; Output value 'vert' is not completely initialized at line 40 (on d3d11_9x)Compiling Vertex program
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_NO_CUBEMAP_ARRAY UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF3 SHADER_API_MOBILE UNITY_HARDWARE_TIER1 UNITY_COLORSPACE_GAMMA UNITY_LIGHTMAP_RGBM_ENCODING```

fixed in #118


Celo All-Core Devs Call 1

Celo All-Core Devs Call 1

When: Thursday, October 29th, 2020, 4 PM UTC/12 PM EST/9 AM PST, 90 minutes max
Where: Celo Zoom Event (Instructions on joining found in the calendar event below)
Calendar Event: Add to your calendar here
Focus: Activating CIP Process and Initial Talks about Celo's First Hardfork. Contracts discussions and adding Meta CIPs for activated Ethereum-based forks.

Agenda

Client Team Checkin
Activating CIP-0000: Celo Improvement Proposal Process
Electing New CIP Editors
Overview of New CIP template
Adding Meta CIPs for activated Ethereum-based forks.
Initial Discussions Of the Celo Hardfork and scheduling future Celo ACD calls.
CIP10 Discussion
CIP 20 PR
Governable Lookback Window (CIP-0021)

Governance

CGP-11 Post Mortem Report
CGP-14 cUSD Rewards

Please post all relevant proposals below that should be discussed and evaluated

I'd like to discuss CIP10 (https://github.com/celo-org/celo-proposals/pull/17) cc @kphed

In relation to the CGP11 issue, I think it would probably be a good idea to review the incident document https://docs.google.com/document/d/11oKD073WIp4nd87_I_lt-RIlWa0gscpM5_MhqNoi-Ng/edit?ts=5f89dc29#

Discuss https://github.com/celo-org/celo-proposals/pull/48 cc @andres-dg

would be good to get feedback on CIP20 #44

would also like to add to agenda a first draft of CGP-14 "cUSD Rewards" for early Celo Dollar adopters cc: @ewilz

Meeting Notes (thanks to @devme25 for taking notes!)
Yaz: Client Checkin for celo-blockchain
Mariano: representing celo-blockchain
Yaz: Going to go over items in the agenda and the CIP process documents
Explains the CIP Process Document
Viktor: How is the CIP process different from the CGP?
Yaz: CGP is more for changing parameters like Gas limits, etc
James: CIP will be the source of truth:
ex: upper and lower boundaries for gas limits
Sanity checks
Development of the protocol itself. E.g.: maybe we have a different language
Viktor: Why do we want to structure the governance this way - CIP vs CGP
Is there more clear dilenation between CIP and CGP
Currently we don’t have a document
Rough consensus - how to move decisions to change parameters using rough consensus
Victor: Also parameters are adjustable without hard forks
CIP might require hard fork  - change to the Celo client
This will allow more flexibility
Or: Merging code from upstream Geth - how do we merge code from a process point of view
Yaz: We should have a meta-CIP that specifies with EIP is implemented and which is not implemented
James: We want to have a public source of truth for what is and what isn’t implemented
Yaz: Do we have consensus on this CIP-0000:
Victor: Can we have more time to review it?
Yaz: Give 1-2 weeks?
James: The goal is not to slow things down but something that is documented and public - move things that already within cLabs process and making it public
Yaz: We will give folks a week to review the docs
James: We will use the CIP channel on Discord to spread the word and communicate
Victor: Discord is really hard to find details, search, etc and not user friendlyCan we use another mode - forum or a Github request?
Yaz :I will create a forum post and we can use that to track comments and feedback. I will also a add Meta CIP - things that were already implemented based on Ethereum
I will bring this to the next call to activate the process
Yaz: Celo hard fork Will be called Donut due to community feedback.
Yaz: Let’s go over CIP 10
Nam: CIP 10 to Generalize signer authorization; also allow smart contracts to be able to sign
This is a significant change to the network
Falls into Ring 1
There are a few details that need to be looked at. And come up with a deployment plan
What other things will this affect? Some details need to be filled in
Yaz: This is WIP and not yet draft. Once it goes to Draft that it will be eligible for Last Call
James: Moving Draft to Last Call is the only thing that requires rough consensus
Once it moves to Last Call, it is more likely to move to Accepted from there
Last call: When CIP moves from Default rejected to default accepted
Yaz: Rough Consensus: Using the definition as per IETF. The gist is it’ll fall between 51%-99%
We determine something is rough conensus only after we make sure it’s technically sound first
James: All Core Dev calls
For things not controversial 1 week tor review  and get to rough consensus the following week
For controversial changes, more time is needed
Changes will go much smoother if everybody comes prepared
Yaz: Let’s go over CIP 20
James: CIP-20 Relatively simple precompile
Goal: provide a bunch of different hash function under a single umbrella
The functions are all secure hash function from a technical perspective
Gas costs?
Not yet defined
James P - wants to come up with a process to quantify how much cost based on certain hardware in use
Part of the process should be to define a benchmark
Requesting feedback
Victor: Avoid resource heavy (memory hard) hash functions that are common in crypto - maybe explicitly ban them. Other ex: non standard functions, things not available in Go, etc
Kevin: If one precompile contains all the hash functions, will all function cost the same:
James: No
Yaz: Let’s all review the WIP draft of CIP 20 and discuss it more on the next ACD call. Let’s go to CIP 21
Andres: It is a hard fork change - Ring 0
Mariano: Can we make two things separately:
Change to layer 1
Change to smart contract
James: Like to see a safe min and max value for it - needs to be added to the proposal
Yaz: Use Governance proposal to update the parameter
James: Seems reletaviely non-controversialFor posterity, it’ll be good to add things what not to do
Victor: Edgecases: think about examples and address them
Yaz: Let’s go to CGP 14
Emily: cUSD yields to Valora holders from the Community Fund smart contract to encourage engagement on the platform.
James: Let’s have a separate governance process for the whys of a governance proposal with the technical details of the proposal to be standardized as a process within the ACD call.
Yaz: I will schedule a Governance Call with the community to go over the whys of CGP-14 and any process that is needed for it will come back to the CIP process as a Ring-4 best-practices or CRC.
Yaz: Nam to go over the CGP-11 Post Mortem
Nam: CGP-11 issue was a typo in the gasLimit cost set. We need to start specifying tests we can do within celocli and for the process to minimize errors moving forward.
Yaz: Nam please share the document of your analysis into this.
Yaz: Thank you all for a great first All-Core Dev Call. I’ll be scheduling the next ACD call and add it to the Celo Signal mailing list to update you all.

Action Items

Move CIP-0000 to Last Call which expires November 5th (1 week from today)
Make a Forum Post to Discuss CIP-0000
Schedule Governance Call to Discuss the Why of CGP-14
Review Proposals CIP-10, CIP-20, CIP-21 more.

After CIP-0000 Goes from Last Call to Active

Add Meta CIP Drafts for Implemented EIPs that are Final in Celo Blockchain
Add Meta CIP Draft for Donut Hardfork

New ACD Call Ticket: https://github.com/celo-org/celo-proposals/issues/63

Video of the call: https://www.youtube.com/watch?v=onYNHYHpDQI&feature=youtu.be


fix all clippy lints and remove them from allow list in cranky

As a new version has been published, its better to clean up clippy lints before any other major pull requests.

It seems the majority of the lints were already fixed in https://github.com/emilk/egui/commit/5093b67e9b095072033e54557825f3bfc9d39c49
I will leave type complexity lint alone. It requires naming a bunch of closures types in plot module which i have no idea about.


Improve detection of current Markdown heading

VSCode Version: Version 1.27.0 (1.27.0)
OS Version: Mac 10.13.5 (17F77)

Steps to Reproduce:
In this code:
# a

- b

---

- c

In VSC right now, - c is considered to be part of the # a heading, in the outline and breadcrumbs. But it probably shouldn't be? In my own Markdown files, I consider - c to not be part of # a, because the --- is meant to separate the two. So, in VSC, that should also be the case.

Does this issue occur when all extensions are disabled?: Yes

Due to the lack of further feedback on this issue, I'm closing it as out of scope


inviable septated mononucleate vegetative cell descendent

should I see
FYPO:NEW - septation following abolished chromosome separation, with mononuclear and anucleate compartments
i

I see
inviable septated mononucleate vegetative cell
as a descendant of
septation following abolished chromosome separation, with mononuclear and anucleate compartments

Right now there is a link (FYPO:0002000 is_a FYPO:0005070), but I think I ought to remove it, because FYPO:0002000 isn't defined as specific for forming anucleate and mononucleate compartments, as opposed to cut. Will that work for you?

yes, but I think we also need
septated mononucleate vegetative cel|
and
FYPO:NEW - septation following abolished chromosome separation, with mononuclear and anucleate
would be a descendant of it?
When I drill down its still hard to find the new term (mainly because I was in the wrong place), but I think this would help
I might need to move some of
inviable septated mononucleate vegetative cell  to this new term I used to think this was an inviable phenotype, but some can go on to form viable diploids.
Make sense?

new term
septated mononucleate vegetative cell FYPO:0005276
deleted link FYPO:0002000 is_a FYPO:0005070
adjusted some other links in relevant branch

edit file: 6ed67908e769470d4cd5e32b2e31751cba8581c2
release: 177067ba0b96083275fece46904f9eb490e908ca


Fix and enhance .gitignore

Enhanced .gitignore

Added log files entries
Added PID files entries
Added npm cache directory entry

Closes #39

Great Job!


No new release to PyPI

I came here to request that --keep-going be added to the options passed thru to sphinx-build, only to see it was already added in #109 (opened two years ago, merged ~6 months ago). That's great! But there's been no new release to PyPI for over two years. Would you please consider cutting a new release for the --keep-going fix and other small fixes since the last release? Thanks for this very handy tooling!

👍🏻 Really interested as well.

@tsibley have you tried using the --keep-going option with the project latest commit ?
It is not working for me, see https://github.com/executablebooks/sphinx-autobuild/pull/109#issuecomment-1643891064

Ha, no, I hadn't tried. Oy vey.

https://pypi.org/project/sphinx-autobuild/2024.2.4/


Isssue with -IncludeDetailedLabelActions parameter in Get-Label command

The result of the command with or without the -IncludeDetailedLabelActions parameter, today is the same. Previously with the parameter and the switch to $true the result showed more information, before "Settings", as you can see in the following images:
File -> WI_LabelBackup.json has been executed today with the parameter -IncludeDetailedLabelActions
File -> 2022-06-08_LabelBackup.json is an old file obtained in June 2022. Some attributes do not match, such as the "tooltip" or "color", as it is a previous version... It was executed with the parameter and switch -IncludeDetailedLabelActions $true

Has the behavior of the parameter changed, is it possible to get this data in another way?
Thanks in advance for your help.

@OVar3la, you should open a support ticket and ask. Report back here with any findings that can help improve the documentation.
Unclear whether this new behavior is intentional or unintentional.

@OVar3la Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. You can contact Microsoft support via the need help section on the admin center. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks


Implement RFC 7405.

Hi, this PR is to implement case sensitive string introduced by RFC 7405.

Hey @timothee-haudebourg, this looks all very good. Thanks! I will try to review this PR in the following few days. Don't mind the failing license check in CI for now.

@duesee sorry for the delay. Did you have time to see the changes?

No worries. Thanks again for the PR and for taking care of the requested changes! This sohuld be good to go (when CI is happy) :+1:

I'll update the version and make a new release to crates.io :-)

Here we go https://crates.io/crates/abnf 🎉


Fix typos and gdb command line in DEVELOPING.md

Travis job has got its time limit.
Merging.

Thanks for the fix, Luis!

@lisitsyn Thanks for merging it! :)


Enhanced "New" menu

Quick question - are these buttons a stop-gap until we get a top-level menu, or do we plan to continue having these buttons even after we have a top-level menu?

These were part of Cameron's design.

:+1:


Add your name in CONTRIBUTORS.md file.

Add your name in the CONTRIBUTORS.md  file after going through the code. And mention this issue in your Pull Request.

Hey @rockingrohit9639
I would like to do that. Please assign it to me.

Hey @rockingrohit9639
I would like to do that. Please assign it to me.

Sure.
Have you joined our Discord channel? If not then please join every query and doubt will be cleared there. You can find link on README.md.
Thanks

Thanks @rockingrohit9639
I will check out your Discord channel.

Can I work on this for cwoc?


fix: fix redirect post datasource save

Description
PR fixes the issue of redirect once the datasource save is clicked. Removed excess set view mode function calls.
PR fixes following issue(s)
Fixes #23706
Media
https://theappsmith.slack.com/files/U025TQ6P4MA/F0579E38FBM/screen_recording_2023-05-11_at_4.39.56_pm.mov
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing
How Has This Been Tested?

[ ] Manual
[ ] Jest
[ ] Cypress

Issues raised during DP testing
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true recreate=true

/build-deploy-preview skip-tests=true recreate=true

/ok-to-test


Peakdata adv search

Summary Change Description
I added a surrounding form element to support multiple output formats/hierarchies.
Affected Issue Numbers

Resolves #128
Resolves #129

Code Review Notes
This supplants PR #127.  I implemented some of the fixes from that review in this PR.

Known minor issue 1: If you submit a search of 1 output format and on the results page, switch output formats, the form shows a red error.  It is harmless.  I tried many things to prevent that error, but have not as yet, figured it out.
Known minor issue 2: The management form is arbitrarily generated from 1 of the 2 form classes.  It is fully functional, but feels like a kludge.

Everything else seems to otherwise work correctly.  However, (related to "known issue 2") the 1 overall design aspect I don't like is the fact that multiple different form types are wrapped in the same HTML form tag.  This is the only way I could figure out how to submit all form data in a single submission (in order to retain the user's entries before they changed the selected output format).  There are what feel like hacky kludges to validate only the forms of the selected output format form type.  I am open to suggested cleaner designs, though keep in mind, I already tried numerous more "proper" ways to do it.  It may just be a square peg / round hole issue.  Django is not designed to accept form submissions of multiplke different formsets in a single form.  I managed to get it to work in the most elegant way I could, but I posted on stack to ask if there's a better way to accomplish the same goal...
Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
[x] Tests implemented (or no code changes)
[x] All tests pass

a PeakGroup represents all of the labeling combinations for a given compound (i.e. C:0, C:1, C:2, C:3, C:4, C:5, and C:6).

Yeah.  I confess I was confused about that.  It seemed there wasn't much different between the 2 output formats.  That original PeakGroups output format is the same as the [basic search PR]9https://github.com/Princeton-LSI-ResearchComputing/tracebase/pull/1060 and was based on Caroline's tissue data - which was linked in the requirements for issue #77 as:

Search results page with data mimicking the sample spreadsheet

This makes much more sense.  I will change the peakgroups rows for both the basic search output format and the advanced search output format.  I'll leave off the label values since that's what separates those rows.

a PeakGroup represents all of the labeling combinations for a given compound (i.e. C:0, C:1, C:2, C:3, C:4, C:5, and C:6).

Yeah. I confess I was confused about that. It seemed there wasn't much different between the 2 output formats. That original PeakGroups output format is the same as the basic search PR and was based on Caroline's tissue data - which was linked in the requirements for issue #77 as:

Search results page with data mimicking the sample spreadsheet

This makes much more sense. I will change the peakgroups rows for both the basic search output format and the advanced search output format. I'll leave off the label values since that's what separates those rows.

OK @lparsons.  Looking at the adjustment of the PeakGroup format, we need to change 2 more fields: fraction and labeled_element, both of which were from the PeakData table, as we had discussed over zoom some time back when I first implemented the basic search for the PeakGroups output format.  I think that Caroline's spreadsheet linked in issue #77 probably was intended for the PeakData output format.  Cross-referencing it with Michael's format spreadsheet, I note that instead of fraction, it has "enrichment fraction".  And I will get the labeled_element from the Animal table.
This actually may make the PeakGroup output page a bit faster.

better names for "input compound" and "Presumed Output Compound"?  I would prefer "tracer"(or infusate)  and "detected compound" (or PeakGroup compound). I guess you will get feedback from the lab later.

There is an issue for this: #133.  That's specifically for the column names, but that applies to the select lists as well.  I will make a note of that in the issue.

Not sure if we want to share all the search features with the lab at this stage. It would be nice to have dropdown lists for a few key fields (study, animal, tissue, PeakGroupSet, compound)

top search features I would like to have with dropdown lists:
search based on study
search based on animal
search based on PeakGroupSet (AccuCor filename)

These search features in this PR were requested by the lab (albeit in a different form/interface - I think this represents an improvement over what was in the mockup), so I think it's OK to push this out to the users.  Refer to the user-created docs in issue #47, under the feature inspiration section at the top - specifically the mockup.

p.s.
with a button for "download file "

Download functionality was listed as a limitation of this specific effort.  See the limitations section of issue #128.  That is next on my list however and I hope to implement it by the end of the week.

Wow, so comparing dicts, as in self.assertEqual(response.context["qry"], qry) stringifies the dicts for comparison, so me creating a base class for the forms ended up changing the order of the keys in the resulting Dict, causing the tests to fail.  Anyway, it works now.  Push inbound.

OK, re-requesting review.  All (discrete) issues resolved/addressed.

Thanks.

@fkang-pu brings up a good point about the complexity of this search and the desire for some other simple searches. Let's leave this as "Advanced Search" for now and define some things we want to do for the "Basic Search" next.

I did think about the complexity issue a bit.  It's a valid concern and it could be addressed by applying a hierarchy depth limit - which trusted users could override.  I also think that this can be effectively mitigated by saving the search parameters with the downloaded data.  I am in the middle of writing up an issue for adding a download button ATM.


Exclusive function to Request Location Service

💬 Questions and Help
Thanks for the new updates.
I have a question though, currently when we call "getCurrentPosition", only then pop-up is displayed to turn on the GPS(if GPS is off). Is there a way to call the request location service manually rather than directly calling the current position?
Also, the timeout should be for only retrieving user location, not for the complete request process.
Current Timeout - Request Location + Request Permssion + Retrieve Location
Expected Timeout - Retrieve Location
Please clarify this.
Appreciate your response.

Hi @mvanbeusekom, your response is appreciated. I am waiting for it.
Thanks.

Hi @bajajsahil, I have been thinking about this feature but not sure if I want to fit it into the plugin. The problem is that this feature would only work when using the Android FusedLocationProviderClient, which means it will not work for Android LocationManager nor on iOS.
In general we could maybe find some way to return an error or simply ignore the calls when run on Android LocationManager or on iOS but both are not really user friendly solutions.

Thanks, @mvanbeusekom for your response.
So, in the current implementation, if we call the getCurrentPosition on Android LocationManager or on iOS CLLocationManager, then GPS popup will not come?

That is correct, on iOS and Android (when using LocationManager) will throw an LocationServiceDisabledException when GPS services are disabled when requesting a position.

@mvanbeusekom  So, It would be better to have this exclusive method I think. We should not execute our business logic until we have location services "ON" and getCurrentPosition is part of business functionality.
As you said, LocationServiceDisabledException will be thrown in the case of LocationManager and this will be perfectly fine in case of an exclusive method. A developer can handle this gracefully and can ask user to turn on the GPS manually.
That's my suggestion.

I am not against it, but it needs to be well documented and should be clear to users that this only works for Android devices which support Google Play Services (the FusedLocationProviderClient is part of the Google Play Services).
How would you suggest we handle this case on other platforms (i.e. iOS and Android LocationManager)? My suggestion would think we throw a not supported exception or something similar indicating this method doesn't work for these platforms (of course the exception message should clearly mention this) and return a boolean when running on Android with Google Play Services indicating if the activation of the location services was successful or not.

Yes, not supported exception is a good idea to differentiate between disabled and not supported error. And, boolean will be useful in case of successful execution. I completely agree with all your points.
Thanks.

@mvanbeusekom I needed the same functionality in my app, i.e. manually requesting user to enable location services. The entire workflow of the app depends on it. Couldn't find anything in geolocator. So I switched to location package which provides this functionality.