Grow our font size and set the content width to have ~80 characters

In the sphinx book theme I was doing a bit of research on good practices for design around web content for readability and accessibility. One thing that I consistently ran into was that you should shoot for 45-75 characters per line, with a max of 80 characters. (though note that Wikipedia seemed to think that a longer width was OK for material that needs to be information dense and "scannable"). They also consistently recommended 16px as the font base size.
Currently, our base font size is 15px, and the max width allows for about 108 characters per line on my screen.
What do people think about these two changes to this theme:

Set the font base size to 16px to be a bit larger. Here's one ref that recommends this.
Set the main content max-width such that, at a 16px font size, we have ~90 characters per line. (this is more than the recommended line width, but IMO this is OK since documentation content may have the same "scannability" needs that wikipedia does...I am happy to hear countering opinions on this one!).

What do folks think about this? (cc also @bollwyvl whose perspective on accessibility I have appreciated!)
Some refs:

Best practices for line width and accessibility and this criterion page from W3C as well
Visual design guide from accessibility.digital.gov
wikipedia page discussing their intent to cap the line width
the Tufte CSS page

a max-width of 1400px for all content, and then sets 55% for the main text and 45% for the sidebar text.
Main content: 55% of full width. Roughly 85 characters per line. Font size 1.4rem
Margin content: 50% of width of the main content. Roughly 60 characters per line. Font size 1.1rem

webtypography recommends about 66 characters per line

tagging @hoechenberger who may be interested in this discussion too

Thanks for the research! I am +1 in general. Do you have any idea what max-width this would approximately result in? (the ~90 chars at 16px)

Here's one attempt at doing this w/ minimal changes to the CSS: https://github.com/pydata/pydata-sphinx-theme/pull/428
What do folks think? (feel free to comment there if you like)

Set the font base size to 16px to be a bit larger.

ACTUALLY, we really shouldn't be setting a base font size at all.
From https://css-tricks.com/accessible-font-sizing-explained/#avoid-setting-a-base-font-size (the entire page is a really good read, if you're interested):

My recommendation is to avoid setting font-size on the :root,  or  elements in favor of letting the browser’s default size serve as a baseline from where we can cascade our own styles. Since this default is accessible, the content will also be accessible. The WACAG 2.2 working draft states that:

When using text without specifying the font size, the smallest font size used on major browsers for unspecified text would be a reasonable size to assume for the font.

Of course, there is an exception to the rule. When using an intricate, thin, or super short x-height font, for example, you might consider bumping up the font size base to get the correct contrast. Remember that the spec defines contrast, not size:

Fonts with extraordinarily thin strokes or unusual features and characteristics that reduce the familiarity of their letter forms are harder to read, especially at lower contrast levels.

In the same manner, a user might change the base font size to fit their needs. A person with low vision would want to choose a larger size, while someone with an excellent vision can go smaller to gain real estate on their screens.

If you skipped the quote above, this is basically for the behaviour when the user changes their default font size in the browser -- accessible pages are supposed to properly accomodate for this user preference (which is also why a bunch of folks recommend using rem as a layout unit).
Beyond that, I am nodding in agreement. :)

@pradyunsg interesting point! That sounds like a good argument to me as well. One thought thought: do we know if the Sphinx "basic" theme sets a base font size? If so then we might need to accommodate for that.
And to be clear, if we set the width based off of em, then this will roughly scale with the font size so the number of characters per line is the same. Is that right?

One thought thought: do we know if the Sphinx "basic" theme sets a base font size? If so then we might need to accommodate for that.

Nope: https://github.com/sphinx-doc/sphinx/search?l=CSS&q=font-size
Some of the other themes do, but, honestly, I think those are firmly a lost cause at this point.

One thing to consider is that code examples may also want 79 characters or so. But code blocks have extra margin so that in the case of your example the text is 80 chars but the code block clips at 75 chars.

@timhoffm that's a great point. I think we could widen the content window so that we have ~85 characters, and thus code blocks are at ~80 characters.

:+1: And that's assuming people don't use line numbers. But most don't so 80 without line numbers should be good enough.

Made a few tweaks in https://github.com/pydata/pydata-sphinx-theme/pull/428 - would love some feedback there.

It seems to me that this limitation is pretty much set here: https://github.com/pydata/pydata-sphinx-theme/blob/d2c51a65e79642babd1a845cf4fadcfbbcc589ca/src/pydata_sphinx_theme/assets/styles/sections/_article.scss#L18
should we adapt this value or keep it as it is and close this issue ?

I'm happy with either approach - I think our width is fine right now. Do others have opinions?

it seems everyone is happy with the current width (v0.11) I'll close this one for now


Show name for open generic arguments

Change open generics display from List<> to List<T>.
Add unit test for open generics.
Add a short name for void type and test for it.
Fix variable name typo.

@smitpatel could you please check if it's in line with what you offered here #278.

@AndreyTretyak,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Eilon - Your call on what should open generic print.

A small point against option with the name. If you will have a class with name T (surely not the best naming) there is no way to say if List<T> open or close generic.

c.IsGenericParameter is true for generic parameter false for non-generic.

I meant, there is no way to distinguish in string representation that we get from TypeNameHelper

My preference would be to avoid the <TKey, TValue> and instead do <,>. I think it's clear enough what the type is.

:shipit:

@smitpatel is this good to go? This change is blocking another PR I'm looking at and I'd like to get this in to unblock it.

@pranavkm - Go ahead.

Thanks for the PR!

@Eilon so an unfortunate side effect of our choice to omit the generic parameter name is that our stack traces look bad. We get
Microsoft.Extensions.Internal.StackTraceHelperTest+GenericClass<>.GenericMethod<>(ref  value)
instead of
Microsoft.Extensions.Internal.StackTraceHelperTest+GenericClass<T>.GenericMethod<V>(ref V value)",
Ignoring the extra white space produced in the first stack trace, the second one just conveys the type info a lot better. Should we reconsider the choice to not print generic parameter name?

Maybe it could be done as an option? An output of generic parameters names could be very useful for method display in #270 or you already have a way for method display and those PR no longer relevant?

@AndreyTretyak I'd prefer not having a flag for it. Given that this is a Sources package, it's just going to push the decision further up the stack rather than choising useful defaults

I understand. Could we hide open generics for type display but show them in methods where it's really needed, or it will be too inconsistent?
If we add a method into TypeNameHelper for methods display,  we could hide all logic about selecting correct variant inside it.
Then we could use those method in StackTraceHelper.GetMethodDisplayString in DI exception with a list of constructors and other places.

I'm trying to determine what @Eilon's rationale was in skipping it originally.

@pranavkm - typeof(List<>)  prints out List<> . The output is as you would write in source code.

Yeah what @smitpatel said... not sure the best way to address this.

I'm fine adding a new optional parameter (with the default being the "old" behavior).


Phrase and hotkey input fields should send auto save on blur or enter

Prevent need to manually click the "Save" button.

Blur was too "noisy", but automatic save on tab or enter is implemented.


Run pod install after upgrade

Describe the Feature
upgrade command could detect Podfile similar to how link does it, and run pod install after installing JS deps.
cc @orta @fson what do you think?

I think that's reasonable, yep 👍

I'd like to work on this issue, if nobody works on it yet

Sure, take it 👍 However, I'd only run it after the upgrade was successful. Otherwise just log to the console something like 'hey, don't forget to run "pod install" once your done upgrading manually'.


One-button to expand categorical summary within a panel

When there are multiple summaries in a panel, and a couple of them have long lists, one use-case is to expand one of the facets fully, and close the others.
Currently, to do this, all other facets need to be manually closed, and one of them need to be expanded. This can be tedious, animated positions of summaries are further complicating the use.
So, add a single button to a summaries: probably only for categorical, when it has more items to be shown, and there is potential screen-space saving by collapsing other summaries.

:thumbsup: for thinking of ways  to optimize screen real-state

Done:)


support postponed annotations and ForwardRef in python 3.7

Change Summary
support postponed annotations in python 3.7
Related issue number
fix #234 partial solution use of ForwardRef for the model itself isn't yet supported. Since almost all of the field setup logic assumes the model already exists this will be much more complicated
ForwardRef should now be fully supported. If the ForwardRef can't evaluate when creating the Model you'll need to call Model.update_forward_refs() after it's been created.
Also note that the Model will need to be defined in the root of the module so it's included in globals, this is a limitation of get_type_hints it could be fixed in future by implementing our own version of get_type_hints but that's beyond the scope of this PR I think.
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] HISTORY.rst has been updated

if this is the first change since a release, please add a new section
include the issue number or this pull request number #<number>
include your github username @<whomever>

Works for me as well, although with a slight catch compared to @StephenBrown2
(Python 3.7.3rc1, Pydantic 0.23)
I have this model :
class Entity(BaseModel):
    name: str
    relatives: List[Entity] = []

If I only add from __future__ import annotations, pydantic yells with the (very informative) message : pydantic.errors.ConfigError: field "relatives" not yet prepared so type is still a ForwardRef, you might need to call Entity.update_forward_refs().
Obviously adding that piece of code just works :+1:
I've had some little issues with the documentation regarding this feature though, for which I'm making an issue and a PR.

great to hear it works, PR for docs very welcome.


Utility method for reading a string from a ByteBuf.

Motivation:
Easier way to read a string efficiently from a ByteBuf.
Modifications:
Add utility method and unit test for reading a String from a ByteBuf.
Result:
Less boilerplate code in order to read a string from a ByteBuf.

@normanmaurer ptal


APEXMALHAR-2206: Fixed application tests

@yogidevendra Please review and merge

@yogidevendra the Travis build still did not complete, why was this merged in a rush?

@tweise
I observed following problems on local build which were fixed after this fix.

target directory size increasing indefinitely leading to disk full on local machine.
local build not finishing for long time.

Regarding travis build; I thought travis build is getting blocked because of the two other builds which were not yet finished. (I assumed there could be some upper cap on no. of buillds running for a project).
Local build was finished in less than 8 mins.


Alternatives missing in result type

What is the current behavior?
there should be alternatives in the result type
Steps to reproduce
enable alternatives and try to consume them.
Expected behavior
The result should have typed alternatives
Please tell us about your environment

Operating System/Version: *
Language: TypeScript
Browser: *

Other information
Alternatives are referenced in the API https://developers.deepgram.com/api-reference/ but not in the more detailed documentation

Hi @wodka, alternatives should exist currently on the individual channel returned in the transcript. Their location on a result would look like:
const response = await deepgram.transcription.preRecorded(fileSource, {
  punctuate: true,
});
const channel0Alternatives= response.results.channels[0].alternatives

Am I misunderstanding?

no you are completely right - I missed this. Thank you!


Style Y091 - Manually Identify Dependencies

Discuss

-1
Just want to keep code clear. Mangling during minification does't provide any big benefits + ng-annotate is cool as well if we will use it.
Suggest to inject dependencies in a simple way without arrays and etc:
angular
    .module('whatever')
    .controller('MYCtrl', function($scope, $timeout, KittensService) { ... });

-1 Hopefully ng-annotate can do this for us...

-1. I prefer the setup we have now. It's much cleaner and less repetitive.

Removed.


fix-link-tempalte-adr

Description
The invalid link in the template made a test fail on the doc builds
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in b1f5b65c34a6829639b398c2371412f72f17472b

Processing #5026.

Processing #5025.


update metabase docker image version

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @pmint93

I think we can close this. I submitted a separate PR which also does the upgrade which got merged in: https://github.com/helm/charts/pull/21582


adjust artifacts in release

the glob that is used to construct the zipfile is an input to the release action. It does have a default (because it made sense to the implementer); feel free to pass in whatever path seems more suitable
https://github.com/camunda-community-hub/community-action-maven-release/blob/main/action.yml#L4-L7

Cannot remember what this was about, tbh.


[Bug] Worker nodes are lost after head was killed due to OOM

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
Head of Ray cluster was killed due to OOM. After it came back, the rest of worker nodes are lost. Checked those worker pods are live:
k get pods -l ray.io/cluster=rc5a9d9f-f445-461f-aaf8-d579c2b706f6
NAME                                                      READY   STATUS    RESTARTS     AGE
rc5a9d9f-f445-461f-aaf8-d579c2b706f6-head-p5k25           1/1     Running   2 (8h ago)   4d23h
rc5a9d9f-f445-461f-aaf8-d579c2b706f6-worker-small-47xp2   1/1     Running   0            4d23h
rc5a9d9f-f445-461f-aaf8-d579c2b706f6-worker-small-rn89r   1/1     Running   0            4d23h

but didn't reconnect to the head node, so the cluster remains the status of only one head node.

Checked the logs showing GCS client couldn't reconnect to the GCS server(The last attempted GCS server address was :0).
[2021-11-19 02:34:55,929 I 17 35] object_store.cc:35: Object store current usage 8e-09 / 0.14151 GB.
[2021-11-19 02:34:56,986 I 17 17] worker_pool.cc:556: [Eagerly] Start install runtime environment for job 09000000. The runtime environment was {}.
[2021-11-19 02:34:56,988 I 17 17] worker_pool.cc:562: [Eagerly] Create runtime env successful for job 09000000. The result context was {"command_prefix": [], "env_vars": {}, "py_executable": "/home/ray/anaconda3/bin/python", "resources_dir": null}.
[2021-11-19 02:34:57,418 I 17 17] node_manager.cc:1181: NodeManager::DisconnectClient, disconnect_type=0, has creation task exception = 0
[2021-11-19 02:35:02,271 I 17 17] worker_pool.cc:556: [Eagerly] Start install runtime environment for job 0a000000. The runtime environment was {}.
[2021-11-19 02:35:02,272 I 17 17] worker_pool.cc:562: [Eagerly] Create runtime env successful for job 0a000000. The result context was {"command_prefix": [], "env_vars": {}, "py_executable": "/home/ray/anaconda3/bin/python", "resources_dir": null}.
[2021-11-19 02:45:04,317 C 17 17] service_based_gcs_client.cc:251: Couldn't reconnect to GCS server. The last attempted GCS server address was :0
*** StackTrace Information ***
    ray::SpdLogMessage::Flush()
    ray::RayLog::~RayLog()
    ray::gcs::ServiceBasedGcsClient::ReconnectGcsServer()
    std::function<>::operator()()
    std::_Function_handler<>::_M_invoke()
    ray::rpc::ClientCallImpl<>::OnReplyReceived()
    std::_Function_handler<>::_M_invoke()
    boost::asio::detail::completion_handler<>::do_complete()
    boost::asio::detail::scheduler::do_run_one()
    boost::asio::detail::scheduler::run()
    boost::asio::io_context::run()
    main
    __libc_start_main

Reproduction script
Create a ray cluster with smaller RAM, e.g. 0.5G, then submit a large job or submit a small job multiple times quickly, then the head node is expected to run into error, get killed and relaunched due to OOM. Then from the Dashboard you will see the ray cluster was left with the head node only, with all rest worker nodes lost but still live running.
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

@chenk008 mentioned this is related to #62, since we use sleep infinity here. Even the connection is broken, ray worker didn't exit. We expect worker pod can get restarted and reconnect to the new head.

I can confirm that worker can join back to the new head after 10 mins. This is still slow and we need to improve it.

I confirm that all the workers rejoined the new head sharply after 10min delay as well (Refer to the pic).

When the head Pod was deleted and recreated, the Raylet will try get GCS address from Redis in ReconnectGcsServer, but the redis_client always use the previous head IP, so it will always failed to get GCS address. The Raylet will exit until ping_gcs_rpc_server_max_retries(10min). So immediately after 10min wait for retry, the client exits and gets restarted while connecting to the new head IP.

Here's the ray core issue @chenk008 filed https://github.com/ray-project/ray/issues/20842 last Dec

Please try ray nightly build wheels, I think it has been reduced to 60s.

Please try ray nightly build wheels, I think it has been reduced to 60s.

Thanks. I tried the nightly version and confirmed that  the workers come back to the new head cluster in about 1 min. Among the 4 lost workers, 2 restarted at 60s, and the rest 2 workers restarted at 80s.

For version <= 1.9.1, you can set this param["system-config"] = '{"ping_gcs_rpc_server_max_retries": 20}' to overcome the problem. @nostalgicimp If you have time, can you help create a doc and document the best practice?

For version <= 1.9.1, you can set this head param --system-config='{"ping_gcs_rpc_server_max_retries": 20}' to overcome the problem. @nostalgicimp If you have time, can you help create a doc and document the best practice? You can put it under docs/

Sure, will do.

Please check https://github.com/ray-project/kuberay/blob/master/docs/best-practice/worker-head-reconnection.md for more details. We can close the issue


Added nominee: Community Health Toolkit

Added nominee: Community Health Toolkit

This is a duplicate of Medic Mobile, which already exists on our dataset, kindly update or replace the existing entry.

Resolved in commit 4e89da2


Fix failed CI

Hi!
Since Rubocop recently drops Ruby 2.2 support ( 7026 ), some specs fail in CI.
https://travis-ci.org/liufengyun/hashdiff/jobs/542366374
To fix the failed CI, this PR drops Ruby 2.2 and below in Travis.

RuboCop 0.69 has dropped support for Ruby 2.2. However I think that Ruby versions supported by RuboCop and Hashdiff are different issues.

As we merged #73 , this can be closed. Still thank you very much @tatsuyafw 👍

@koic @liufengyun
Thank you for your kindness!


Add router into vue app generated

Fix #1018

bounty claimed : https://opencollective.com/generator-jhipster/expenses/68143

@seraphinandrieux : approved, thanks a lot for your work here


verify expiry of cached claims

This PR verifies the expiry of claims retrieved from the cache.
Before adding tests I need to bump the mockito cmd and the way we generate mocks. Things have changed a lot there.

fixes https://github.com/owncloud/ocis/issues/8297


Add cf customtest command

Could be improved: The language could be automatically deduced from the file extension and the configuration.

Great works!
But I have changed a lot in the local repo. Maybe there would be a lot of conflicts.

I've rebased it, but the commit time doesn't change.

(nevermind, I didn't notice  "local".)

Pushed. You can try to solve the conflicts

I think language id is not user-friendly. Any thoughts?

Maybe you can ask what user want, just like template configuration.

Comment:

Docopt doesn't show any error messages when the format of the usage string is wrong. It just silently exits.
When the user provide an invalid language ID, the program will hang forever.
It's possible to check whether the ID is valid before submitting, but it will require the language list to be up-to-date (otherwise custom test of newly added language is not possible).

I think the custom test should be independent of templates. I mean you can pop out an available language list if the template detection failed instead of showing the error message.

BTW the command customtest could be ctest XD


I purchased platinum plan for 12 month for auto forward bot from app but still I didn't get my plan😭

I purchased auto forward bot platinum plan for 12 month from the app that you gave.but still my plan is free.help me to give me my platinum account or recover my money.i can't contact you in telegram for sending proof because of the privacy setting that says you can only send message to mutual contacts.my user id<PHONE_NUMBER>.my telegram username @ishaanvenghat

Please contact to my telegram @redf0x1 and send me your order id for check

Anyone can message me unless you are suspected of being scammed by telegram and you are not allowed to message anyone. Or you can use any telegram account to send me an invoice

I can't because of your privacy settings
On Sun, Nov 12, 2023, 5:46 PM redf0x1 @.***> wrote:

Anyone can message me unless you are suspected of being scammed by
telegram and you are not allowed to message anyone. Or you can use any
telegram account to send me an invoice
—
Reply to this email directly, view it on GitHub
https://github.com/redf0x1/Auto-Forward-Messages/issues/4#issuecomment-1807109414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQHI24H756QMB4FVGGBMF3YEC4YHAVCNFSM6AAAAAA7H2WEZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGEYDSNBRGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Why u not send your order id here???


Consolidate (simplify) UI for computed fields

Overview
Today, there are computed fields and custom fields.  Computed types are basically a type of a custom field.  That can be seen if you look at the inputs required to create a custom field. The distinct inputs for computed fields are "template", "fallback value", and "slug" (need to consider #824?)  Taking this into consideration, it should be possible to simplify the UI and consolidate/collapse the computed field UI into the custom field view.  If this updates the API for custom fields, that is okay, but not required.  The existing API for computed fields should not break.
User Story
As Austin the Network Automation Engineer, I find it quite confusing to navigate custom and computed fields in the UI.
I want to be able to more simply view all computed+custom fields in a single view,
So I can easily filter/see all computed+custom fields based on content type.

To clarify the requirements, is this talking about:

The object detail view UI presentation of custom fields and computed fields applicable to the given object (currently two separate sections, possibly merging them together into a single section)?
The list UIs for displaying a summary of all currently defined custom or computed fields (currently two separate UIs, consolidating them into a single combined UI)?
The detail view UIs for inspecting the definition of a single custom or computed field (currently two separate UIs, consolidating them into a single combined UI)?
The form UIs for creating/updating custom fields and computed fields (consolidating them into a single combined UI)?
All of the above?

Thanks. :-)

All of the above, but it's always open for discussion.
Maybe the "Template" goes into a tab in the object detailed view.  Would need some thought in the UI to finalize what the implementation would look like, but short answer is "yes" and "all of the above."

While I can understand the desire for a simplified UI and feature set, this is non-trivial from both a design and implementation standpoint. Some thoughts as to the challenges involved:

Fundamentally, computed field values are dynamic in value and are not present in the database, while custom field values are stored statically in the database. This poses any number of distinctions, such as querying/sorting/filtering (database operation for custom fields, not available for computed fields), performance implications (low for custom fields, potentially high for computed fields), editability (a computed field can be renamed after creation; a custom field may not), etc.
Non-overlapping model fields - custom fields have (required, default, validation constraints, etc.) and computed fields have (template, fallback_value). If we really want to go this route it might be that the best option could be to combine the two data models into a single consolidated model, but this would definitely require a fair amount of additional validation/cleaning logic, not to mention the UI aspects of this.

Given the multiple code paths in the existing implementation for custom fields, computed fields, and relationships, this is very non-trivial. Perhaps we defer this to a breaking change and look at a refactor of these three features at that time.

As far as I understand, 2/ 3/ & 4/ represent a large among of work and might not provide a lot of value
but 1/ should be fairly easy to implement without breaking anything and significantly improve the user experience.
Would it be possible to focus on 1/ first : merging Custom and computed field in the object detail view UI ? without touching the API or the models ?

Closing as we can revisit under larger UI refresh umbrella later.


Listener Errors

The error handler is invoked in the context of ConsumerRecords (batch) processing instead of each individual ConsumerRecord - this means messages within the batch after an error are skipped/ignored.
Also we need to consider whether we need autoCommitOnError - see https://github.com/spring-cloud/spring-cloud-stream/issues/542

Invalid - there is a try/catch within invokeListener.


[Select] ref to collection is undefined

Bug report
I've tried to replicate behaviour in our app as much as possible. We've select built using @radix-ui/react-select which allows to select an option that makes an input control visible which allows user to enter custom value. When user leaves the input, we run function which adjust entered text value. It works perfectly fine until ScrollUp/DownButton is starting to be visible because of smaller viewport or list being rendered near the top or bottom of the viewport.
Current Behavior
If you focus the input and right after you try to open the select and the ScrollUp/DownButton can be rendered it's going to throw because the ref to collection's container is undefined.
Expected behavior
I expect the component to not throw.
Reproducible example
https://codesandbox.io/s/crazy-dream-mlrwc2

Select option between 40-50 to make sure the scroll up button will be rendered.
Focus the input
Click on the select's trigger.

Suggested solution
I didn't dig into your source code so can't tell right now.
Additional context
[N/A]
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
2.0.0

React
n/a
18.3.0-canary-9377e1010-20230712 (Next.js app)

Browser
Brave
v1.60.118

Assistive tech

Node
n/a
v16.20.0

npm/yarn
pnpm
8.8.0

Operating System
MacOS
Sonoma  (14.1.1 (23B81))

I believe this is the same underlying issue as #1795

@benj-dobs Yes, that definitely is the same problem. I will close my issue in favour of that one.


[CHANGE ME] Re-generated to pick up changes from self.

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/29e430d2-e312-4f28-880c-dee68e7aba7d/targets

[ ] To automatically regenerate this PR, check this box.

This somehow deletes one of our source files.


fifth parameter

$5 = embedding e.g. simteg, sbert, roberta
There is a problem with the description of the fifth parameter for the two training scripts; this is actually the description for the sixth parameter. The fifth parameter does not appear to be used in the training scripts.

Sorry for the late reply, because I'm quite busy in the past few weeks.
Thanks for pointing it out, I have fixed it!


setup.py -> add groundwork for github actions builds

This is a streamlined version of a similar script from CadQuery/ocp_build_system. This is untested so far, but looking for commentary here.

A few comments:

I am not sure why you move all the relocate logic into setup.py. We anyhow have to run "python -m build -n" in a shell, so adding the relocate stuff in the shell would be easy and split the two concerns (build wheel and relocate wheel) clearly
setup.py already contains serialize.cpp, but the PR doesn't
You do some sys calls to get the conda prefix. Doesn't os.environ["CONDA_PREFIX"] do the same?
Would line 111 fail when suddenly we have more than one wheel in the folder?
a subtlety, but I am not sure I would call it bad_wheel. I think I'd prefer wheel and relocated_wheel. But namings are subjective ...

Closing this PR as this will need significant rework


Is pydantic pedantic enough? / json false is saved as "False"

I was mucking about with fastapi and tried sending the json value false to a str field.
Imagine my surprise when "False" was saved in my database instead of getting a 4xx response.
Now, I might have done something wrong, though I've just copied/pasted the docs - which just use the default settings.
The data passed into pydantic really is a False
> request._json
{'text': False, 'completed': True}

See https://github.com/samuelcolvin/pydantic/issues/1130 as well.
I'm wondering if the default settings are pedantic is enough or if fastapi should ship with a StrictModel instead?

There is a StrictStr type in pydantic if you want to disable this behavior.
(See the linked pydantic issue discussion for a more lengthy response about the tradeoffs involved with changing this behavior.)

I'm talking about expected behavior from a consumer/user's standpoint.
As a consumer it makes no sense that a False it converted into "False" and saved in the DB.
That is why I brought this up to see if fastapi should take an opinionated stance on how strict it's endpoints should be. Maybe it should use a StrictModel implementation by default.
I'm also not going to pursue using fastapi any further, so please do whatever makes sense.
Have a good one, see you on the flipside!

Yeah, that's how Python itself works. bool is a subclass of int and so on. Pydantic is quite Pythonic and it doesn't enforce what Python wouldn't. Also, there are several cases where you would depend on automatic string conversion. E.g. path, query, cookie, and header parameters. The specs deal only with strings, there are no other types. And still, there are the strict versions when you need to enforce them.
Anyway, hope you find a framework or language that suits your needs.
As I understand you already decided about your original question, I'll close this issue now.


Animation blocks

As a creator I want to be able to animate arbitrary values globally or nested inside sequences/table by defining a timeline with keyframes of the values to be animated and playing them back.

Spec draft: https://github.com/fragcolor-xyz/FIPs/blob/FIP-2/FIPs/FIP-2.md

Hey team! Please add your planning poker estimate with ZenHub @Kryptos-FR @satendrapalsingh @sinkingsugar


Run tests against python 3.6 instead of 3.4

Failed: https://travis-ci.org/d11wtq/dockerpty/jobs/220862358#L616

I could not get the tests to pass under Py35 or Py36.


V0.19.3 merge

Steps:

Create new local branch v0.19.3-merge from downstream/master
git fetch upstream && git merge v0.19.3
a. Solve conflicts. In this case it was just some go.mod lines.
Run go mod vendor
This PR

@fabianvf do we run update-collections.sh on z-stream releases, or (my guess) would that just be for X any Y stream?

@asmacdo I think we can probably skip updating the collections, tbh I don't know if we've done a z-stream release since collections were a thing

/lgtm


Feature request: use LINQ-provider from linq2db

Сurrently LINQ-provider in EF Core is far from perfect.
But there is a production-ready alternative: linq2db
EF Core model can be tranlated to linq2db mapping scheme.
This will allow very cheap access to the following functionality:

"Group by"
Nested queries
Extensions for easy implementation of any unsupported "out-of-box" DB-specific function or operation (like IP address comparison for PostgreSql)
Bulk operations
Many more different features

Also, EF Core team will be able to allocate more resources for the improvement of migrations, change tracker and other unique EF Core features
Now I use my own wrapper to transparently combine two ORM sharing one model

@Kirill-Maurin We are supportive of creating extensions that can be used with EF Core to enhance or replace some existing built-in part of the stack. To that end, we would be happy to work with the community on adding appropriate extension points to EF Core that can be used for such things. That being said, it would have to be a community driven effort, and the majority of the code should live externally to the EF Core repo.
With regard to the list of functionality that is "missing" could you be more specific on which parts are not working for you? It seems like the first three are implemented in 2.1, and #4 requires more than just changing the LINQ provider.

It seems like the first three are implemented in 2.1

Nested queries:
EF Core 2.1preview1
07:15:46.7670|[8]|Compiling query model:
'from X p in DbSet<X>
select new <>f__AnonymousType3<X, string>(
    [p],

        (from IP2Country c in DbSet<IP2Country>
        where int [c].From.CompareTo([p].IP) <= 0
        order by [c].From desc
        select [c].Country)
        .Take(1)
        .FirstOrDefault()
)'
07:15:46.8217|[8]|Optimized query model:
'from X p in DbSet<X>
select new <>f__AnonymousType3<X, string>(
    [p],

        (from IP2Country c in DbSet<IP2Country>
        where int [c].From.CompareTo([p].IP) <= 0
        order by [c].From desc
        select [c].Country)
        .Take(1)
        .FirstOrDefault()
)'
07:15:46.9892|[8]|(QueryContext queryContext) => IEnumerable<<>f__AnonymousType3<X, string>> _InterceptExceptions(
    source: IEnumerable<<>f__AnonymousType3<X, string>> _ShapedQuery(
        queryContext: queryContext,
        shaperCommandContext: SelectExpression:
            SELECT "p"."Updated", "p"."XId", "p"."IP", "p"."Port"
            FROM "Xs" AS "p",
        shaper: TypedProjectionShaper<BufferedOffsetEntityShaper<X>, X, <>f__AnonymousType3<X, string>>),
    contextType: P2P.PostgreSql.PostgreSqlP2PContext,
    logger: DiagnosticsLogger<Query>,
    queryContext: queryContext)
07:15:47.0146|[8]|Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT "p"."Updated", "p"."XId", "p"."IP", "p"."Port"
FROM "Xs" AS "p"
07:15:47.0764|[8]|Executed DbCommand (63ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT "p"."Updated", "p"."XId", "p"."IP", "p"."Port"
FROM "Xs" AS "p"
07:15:47.3125|[8]|A data reader was disposed.
07:15:47.3125|[8]|Executing DbCommand [Parameters=[@_outer_IP='?'], CommandType='Text', CommandTimeout='30']
SELECT "t0".*
FROM (
    SELECT "c0"."Country"
    FROM "IP2Country" AS "c0"
    WHERE "c0"."From" <= @_outer_IP
    ORDER BY "c0"."From" DESC
    LIMIT 1
) AS "t0"
ORDER BY "t0"."From" DESC
LIMIT 1
07:15:47.3890|[8]|Failed executing DbCommand (68ms) [Parameters=[@_outer_IP='?'], CommandType='Text', CommandTimeout='30']
SELECT "t0".*
FROM (
    SELECT "c0"."Country"
    FROM "IP2Country" AS "c0"
    WHERE "c0"."From" <= @_outer_IP
    ORDER BY "c0"."From" DESC
    LIMIT 1
) AS "t0"
ORDER BY "t0"."From" DESC
LIMIT 1
07:15:47.4321|[8]|An exception occurred in the database while iterating the results of a query for context type 'P2P.PostgreSql.PostgreSqlP2PContext'.
Npgsql.PostgresException (0x80004005): 42703: column t0.From does not exist
   at Npgsql.NpgsqlConnector.<DoReadMessage>d__155.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Runtime.CompilerServices.ValueTaskAwaiter`1.GetResult()
   at Npgsql.NpgsqlConnector.<ReadMessage>d__154.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Npgsql.NpgsqlConnector.<ReadMessage>d__154.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Runtime.CompilerServices.ValueTaskAwaiter`1.GetResult()
   at Npgsql.NpgsqlConnector.<ReadExpecting>d__161`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Runtime.CompilerServices.ValueTaskAwaiter`1.GetResult()
   at Npgsql.NpgsqlDataReader.<NextResult>d__32.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Npgsql.NpgsqlDataReader.NextResult()
   at Npgsql.NpgsqlCommand.<Execute>d__71.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Runtime.CompilerServices.ValueTaskAwaiter`1.GetResult()
   at Npgsql.NpgsqlCommand.<ExecuteDbDataReader>d__92.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Runtime.CompilerServices.ValueTaskAwaiter`1.GetResult()
   at Npgsql.NpgsqlCommand.ExecuteDbDataReader(CommandBehavior behavior)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.BufferlessMoveNext(DbContext _, Boolean buffer)
   at Microsoft.EntityFrameworkCore.Storage.Internal.NpgsqlExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.QueryMethodProvider.<_InjectParameters>d__27`1.MoveNext()
   at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext()
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Boolean& found)
   at lambda_method(Closure , QueryContext , X )
   at Microsoft.EntityFrameworkCore.Query.ExpressionVisitors.Internal.ProjectionShaper.TypedProjectionShaper`3.Shape(QueryContext queryContext, ValueBuffer valueBuffer)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.BufferlessMoveNext(DbContext _, Boolean buffer)
   at Microsoft.EntityFrameworkCore.Storage.Internal.NpgsqlExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
   at Microsoft.EntityFrameworkCore.Query.Internal.QueryingEnumerable`1.Enumerator.MoveNext()
   at Microsoft.EntityFrameworkCore.Query.Internal.LinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.MoveNext()

It seems like the first three are implemented in 2.1

"group by"
No logged errors, no logged queries, no data in my application
14:30:47.3502|[1]|Entity Framework Core 2.1.0-preview1-28290 initialized 'PostgreSqlP2PContext' using provider 'Npgsql.EntityFrameworkCore.PostgreSQL' with options: None
14:30:47.6162|[1]|Opening connection to database 'P2P' on server 'tcp://test:1234'.
14:30:48.0547|[13]|Opened connection to database 'P2P' on server 'tcp://test:1234'.
14:30:48.0678|[13]|Beginning transaction with isolation level 'Snapshot'.
14:30:48.2708|[5]|Compiling query model:
'from IGrouping<<>f__AnonymousType3<string, int>, YDetails> g in
    (from Z2Ks t2K in DbSet<Z2Ks>
    join Z2P t2P in DbSet<Z2P>
    on new <>f__AnonymousType7<DateTime, int>(
        [t2K].Updated,
        [t2K].ZId
    ) equals new <>f__AnonymousType7<DateTime, int>(
        [t2P].ZUpdated,
        [t2P].ZId
    )
    join P p in DbSet

    on new <>f__AnonymousType0<DateTime, string>(
        [t2P].PUpdated,
        [t2P].PId
    ) equals new <>f__AnonymousType0<DateTime, string>(
        [p].Updated,
        [p].Id
    )
    join P2X p2T in DbSet<P2X>
    on new <>f__AnonymousType2<DateTime, string>(
        [t2P].PUpdated,
        [t2P].PId
    ) equals new <>f__AnonymousType2<DateTime, string>(
        [p2T].PUpdated,
        [p2T].PId
    )
    join X t in DbSet<X>
    on [p2T].XId equals [t].Id
    where [t2K].Outdated == __MaxValue_Date_0 && [p].Outdated == __MaxValue_Date_1 && [p2T].Outdated == __MaxValue_Date_2
    join Y t2P in
        (from Y <generated>_1 in DbSet<Y>
        select [<generated>_1]).FromSql('select t2p.*, (select i2c."Country" from "IP2Country" i2c where i2c."From" < t2p."IP" order by i2c."From" desc limit 1) from "X2Ys" t2p')
    on [t].Id equals [t2P].XId
    select new YDetails{
        ZId = [t2K].ZId,
        XId = [t].Id,
        Size = [t].Size ?? 0,
        IP = [t2P].IP,
        Port = [t2P].Port,
        Country = [t2P].Country,
        Updated = [t2P].Updated
    }
    ).GroupBy(new <>f__AnonymousType3`2(Country = [t2P].Country, ZId = [t2K].ZId), new YDetails() {ZId = [t2K].ZId, XId = [t].Id, Size = ([t].Size ?? 0), IP = [t2P].IP, Port = [t2P].Port, Country = [t2P].Country, Updated = [t2P].Updated})
from YDetails gg in [g]
select new <>f__AnonymousType4<int, string>(
    [gg].ZId,
    [gg].Country
)'
14:30:48.3391|[5]|Optimized query model:
'from IGrouping<<>f__AnonymousType3<string, int>, YDetails> g in
    (from Z2Ks t2K in DbSet<Z2Ks>
    join Z2P t2P in DbSet<Z2P>
    on new <>f__AnonymousType7<DateTime, int>(
        [t2K].Updated,
        [t2K].ZId
    ) equals new <>f__AnonymousType7<DateTime, int>(
        [t2P].ZUpdated,
        [t2P].ZId
    )
    join P p in DbSet

    on new <>f__AnonymousType0<DateTime, string>(
        [t2P].PUpdated,
        [t2P].PId
    ) equals new <>f__AnonymousType0<DateTime, string>(
        [p].Updated,
        [p].Id
    )
    join P2X p2T in DbSet<P2X>
    on new <>f__AnonymousType2<DateTime, string>(
        [t2P].PUpdated,
        [t2P].PId
    ) equals new <>f__AnonymousType2<DateTime, string>(
        [p2T].PUpdated,
        [p2T].PId
    )
    join X t in DbSet<X>
    on [p2T].XId equals [t].Id
    where [t2K].Outdated == __MaxValue_Date_0 && [p].Outdated == __MaxValue_Date_1 && [p2T].Outdated == __MaxValue_Date_2
    join Y t2P in DbSet<Y>
    on [t].Id equals [t2P].XId
    select new YDetails{
        ZId = [t2K].ZId,
        XId = [t].Id,
        Size = [t].Size ?? 0,
        IP = [t2P].IP,
        Port = [t2P].Port,
        Country = [t2P].Country,
        Updated = [t2P].Updated
    }
    ).GroupBy(new <>f__AnonymousType3`2(Country = [t2P].Country, ZId = [t2K].ZId), new YDetails() {ZId = [t2K].ZId, XId = [t].Id, Size = ([t].Size ?? 0), IP = [t2P].IP, Port = [t2P].Port, Country = [t2P].Country, Updated = [t2P].Updated})
from YDetails gg in [g]
select new <>f__AnonymousType4<int, string>(
    [gg].ZId,
    [gg].Country
)'
14:30:48.5713|[4]|Disposing transaction.
14:30:48.5713|[4]|Closing connection to database 'P2P' on server 'tcp://test:1234'.
14:30:48.5812|[4]|Closed connection to database 'P2P' on server 'tcp://test:1234'.

It seems like the first three are implemented in 2.1

Extension for missed "out-the-box" features
This query cannot be generated by EF Core: type of field "From" is IPAddress.
select i2c."Country" from "IP2Country" i2c where i2c."From" < t2p."IP" order by i2c."From" desc limit 1

A solution with linq2Db
		[Sql.Expression( "{0} <= {1}", PreferServerSide = true, IsPredicate = true )]
		public static bool LessOrEqual( IPAddress left, IPAddress right ) => left.CompareTo( right ) <= 0;

#4 requires more than just changing the LINQ provider.

LINQ is not limited to SELECT queries
linq2db can do bulk operations for many DBMS, if you have a mapping scheme
Mapping scheme can be generated from EF Core data model

@Kirill-Maurin  have you tried preview-2 ?

@roji
Yes, Npgsql provider works well
@ErikEJ
preview-2 are better than preview-1
I can convert IPAddress to comparable type by HasConversion()
10:52:10.4781|[1]|Entity Framework Core 2.1.0-preview2-30571 initialized 'PostgreSqlXYZContext' using provider 'Npgsql.EntityFrameworkCore.PostgreSQL' with options: None
10:52:10.5978|[1]|Opening connection to database 'XYZ' on server 'tcp://test:1234'.
10:52:11.5554|[12]|Opened connection to database 'XYZ' on server 'tcp://test:1234'.
10:52:11.5554|[12]|Beginning transaction with isolation level 'ReadCommitted'.
10:52:11.7766|[9]|Compiling query model:
'from X2Y p in DbSet<X2Y>
select new <>f__AnonymousType3<BigInteger, string>(
    [p].IP,

        (from IP2Country c in DbSet<IP2Country>
        where [c].From <= [p].IP
        order by [c].From asc
        select [c]).FirstOrDefault().Country
)'
10:52:11.8408|[9]|Optimized query model:
'from X2Y p in DbSet<X2Y>
select new <>f__AnonymousType3<BigInteger, string>(
    [p].IP,

        (from IP2Country c in DbSet<IP2Country>
        where [c].From <= [p].IP
        order by [c].From asc
        select [c].Country).FirstOrDefault()
)'
10:52:12.0420|[9]|(QueryContext queryContext) => IEnumerable<<>f__AnonymousType3<BigInteger, string>> _InterceptExceptions(
    source: IEnumerable<<>f__AnonymousType3<BigInteger, string>> _ShapedQuery(
        queryContext: queryContext,
        shaperCommandContext: SelectExpression:
            SELECT p."IP", (
                SELECT c."Country"
                FROM "IP2Country" AS c
                WHERE c."From" <= p."IP"
                ORDER BY c."From"
                LIMIT 1
            ) AS "Country"
            FROM "X2Ys" AS p,
        shaper: TypedProjectionShaper<ValueBufferShaper, ValueBuffer, <>f__AnonymousType3<BigInteger, string>>),
    contextType: XYZ.PostgreSql.PostgreSqlXYZContext,
    logger: DiagnosticsLogger<Query>,
    queryContext: queryContext)
10:52:12.0750|[9]|Executing DbCommand [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT p."IP", (
    SELECT c."Country"
    FROM "IP2Country" AS c
    WHERE c."From" <= p."IP"
    ORDER BY c."From"
    LIMIT 1
) AS "Country"
FROM "X2Ys" AS p
10:52:12.1803|[9]|Executed DbCommand (106ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT p."IP", (
    SELECT c."Country"
    FROM "IP2Country" AS c
    WHERE c."From" <= p."IP"
    ORDER BY c."From"
    LIMIT 1
) AS "Country"
FROM "X2Ys" AS p

Nested query bug posted above. Duplicate of https://github.com/aspnet/EntityFrameworkCore/issues/11326 Fixed in 2.1.0-preview2

GroupBy issue seems like you are generating query and enumerator but you are not iterating it. If you are not consuming group, we don't do the work to retrieve data. Given that there are customers out there using GroupBy successfully, it seems like something is amiss in user code which is causing no sql to be seen in the logs.

@smitpatel

Nested query bug posted above. Duplicate of #11326 Fixed in 2.1.0-preview2

Thanks

GroupBy issue seems like you are generating query and enumerator but you are not iterating it.

I use the same code to reproduce. I change only query and LINQ-provider.
linq2db works fine
12:26:09.5150|[1]|Entity Framework Core 2.1.0-preview2-30571 initialized 'PostgreSqlXYZContext' using provider 'Npgsql.EntityFrameworkCore.PostgreSQL' with options: None
12:26:09.6222|[1]|Opening connection to database 'XYZ' on server 'tcp://test:1234'.
12:26:10.4541|[12]|Opened connection to database 'XYZ' on server 'tcp://test:1234'.
12:26:10.4541|[12]|Beginning transaction with isolation level 'Snapshot'.
12:26:10.6298|[6]|Expression test code generated: 'E:\Temp\linq2db\ExpressionTest.0.cs'.  Rows Count: 545.
 DataConnection

I use the same code to reproduce. I change only query and/or LINQ-provider.
linq2db works fine

Does EF Core gives you incorrect results? Or shows you empty results when there are results? Did you verify results by EF Core? If you see that there are no results generated when you verify them, please file a new issue with detailed repro steps. (ideally a repro solution)
EF Core using streaming for results. It will create the query and do all groundwork but reading actual data for server or running SQL queries (especially in the case where there are more than 1 SQL to be run), will depend on consumption of results from client code. If you are not consuming the results of the query, EF Core will not generate client objects for result. This is pattern allows you to iterate over a large result set without running out of memory because you can keep only data in memory which is needed for current iteration. Not all ORM or linq to sql translator work this way and they may be computing results even without getting enumerated. Difference in such behaviour is not indication that EF core is not working.

Verified that if you call GetEnumerator on query but do not enumerate the results, EF Core will not execute any SQL on server.

You asked for it...
https://github.com/linq2db/linq2db.EntityFrameworkCore

@ajcvickers
Talking about extension points support :). We currently miss two things and use reflection for it:

getting context options from context: https://github.com/linq2db/linq2db.EntityFrameworkCore/blob/master/Source/LinqToDB.EntityFrameworkCore/LinqToDBForEFToolsImplDefault.cs#L293
getting context from EntityQueryProvider: https://github.com/linq2db/linq2db.EntityFrameworkCore/blob/master/Source/LinqToDB.EntityFrameworkCore/LinqToDBForEFToolsImplDefault.cs#L350

@MaceWindu This is awesome.  Please please continue to develop and maintain this project.  With entityframework core and linq2db effectively combined there is a full feature set.  This would be a very powerful ORM setup.
Is there a roadmap for this project?

@nathan-parkinson not sure what we can include into roadmap. It is pretty much feature-complete project. I think next week we can release it on nuget taking into account EF.Core 2.1 release.

@MaceWindu Sorry, I think I'm asking the wrong question.  I suppose what i'm trying to ask is whether it is a safe option to add this into my projects. Will this be maintained and released - currently the readme states it is in early preview - or is this an experimental repo that could be discontinued at any time.

@nathan-parkinson it is in preview, because we didn't get any feedback yet from real users. We don't plan to drop this project and if it will get enought attention from users, we will consider to include it into linq2db directly later.

@MaceWindu Thanks for the information.  If I have any useful feedback I will let you know

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Revert "Ndbc Postgres module"

Reverts getquill/quill#1556 due to errors in transaction i.e. #1638.

Again, I'm sorry about this guys. There is an error in transaction with postgres-ndbc that needs to be fixed. I'll upload a postgres-ndbc branch to upstream so we can work on it together.


Fix incorrect weapon names (image ids) in filter view

It happens when there is a new weapon in the refreshed histories (can be resolved by restart the app).
Reproduce:

Export a long history
Clear the database
Restart the app
Refresh
Import the package with a long history (just to make sure some new weapons are added)

Thank you for your support. Generally you can perform a database upgrade to alter existing results, so that there is no need to export, clear and import.

Thank you for your support. Generally you can perform a database upgrade to alter existing results, so that there is no need to export, clear and import.

Oh, the steps are solely for reproducing the issue. The cache is stored in memory, so no database operations are needed for resolving the issue

Thank you for your support. Generally you can perform a database upgrade to alter existing results, so that there is no need to export, clear and import.

Oh, the steps are solely for reproducing the issue. The cache is stored in memory, so no database operations are needed for resolving the issue

I got it. LGTM.


Replace axios with @actions/http-client

Axios has issues with proxies. Rather than trying to workaround these problems this swaps our http client to @actions/http-client which is designed to work in actions environments.
The swap was pretty straightforward except the built in retry behavior was not as robust. We needed it to handle additional 5xx codes so I've implemented retries manually.

[Aside] will we need to remove axios totally?


Shader model above 5.0 not supported in HLSL

Error: unsupported Shader Model detected: ps_5_1. RGA supports Shader Model 5.0 and below.

Hi onatto,
As the error mentions, RGA does not support Shader Model 5.1 and above currently.
Support for these shader models is in our future feature list.

Hi, do you have ETA for this? Thanks!

Hi michal-z,
We currently do not have a target date for this feature.

I would like to subscribe to this as well. Would love to have higher Shader Model than 5.0 since I am targeting those.

Hi onatto, michal-z, giordi91,
RGA 2.3, which was released today, adds support for shader model 5.1 and above in the command line tool's DX12 mode (-s dx12). Please check this article for details.

This is great! Thank you! Been looking forward to this!


Improve end-to-end tests

There is some basic tests developed using testcafe but this is not sufficient, we should be able to test most features being connected to a full instance (ie including weather + measures data).

Closing in favor of https://github.com/kalisio/kdk/issues/38


help please. Inserts taking 20 seconds on a map with 20K rows. Use SQL experience?

I'm using a TreeMap and my Map keys are all Integer with linear increments.   If it were SQL and slow inserts, I might use a temp table to insert into (empty) then bulk insert.
Does such a strategy make sense with MapDB?
Any and all suggestions on tuning welcome.  I'm on Android ART runtime (5.0, 5.1, etc).

You could use data pump to make TreeMap faster (checkout examples). Also use correct BTreeKeySerializer class.


Error during install in PHP 8.0.x requires cuyz/valinor dev-master

I got error while install in PHP 8.0
./composer.json has been created
Running composer update opiy-org/asterisk-ari-php
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires opiy-org/asterisk-ari-php 2 -> satisfiable by opiy-org/asterisk-ari-php[2.0].
    - opiy-org/asterisk-ari-php 2.0 requires cuyz/valinor dev-master -> found cuyz/valinor[dev-master] but it does not match your minimum-stability.

Installation failed, deleting ./composer.json.

so I had to install separately cuyz/valinor
Interesting: if I install composer require cuyz/valinor error still appears
So I installed dev version composer require cuyz/valinor:dev-master
# composer require cuyz/valinor:dev-master
./composer.json has been updated
Running composer update cuyz/valinor
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading cuyz/valinor (1.2.0 => dev-master 3f31272)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading cuyz/valinor (dev-master 3f31272)
  - Upgrading cuyz/valinor (1.2.0 => dev-master 3f31272): Extracting archive
Generating autoload files
1 package you are using is looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found

it can be probably caused by your composer.json "minimum-stability": "stable" param,
try to set it to "dev"


Strip empty lines from comp alignment csv

Cut will turn empty lines into . lines in its output, which the NCBI accession download tool will interpret as accession numbers and try to download, then fail. The workflow runs despite this failure because the already downloaded datasets themselves are not in an error state - just the Collection is.

I guess this exposes two kind of strange behaviors of tools/Galaxy, which one might want to address separately:

should the Cut tool have an option to ignore trailing empty lines?
shouldn't a Collection that's in an error state fail a workflow that uses it?

I guess your comments should be moved to an issue on the Galaxy repo so we do not loose them.

@bgruening do you think the option in the Cut tool to ignore trailing empty lines is worth having?

see https://github.com/galaxyproject/galaxy/issues/9394 for the collections issue


[Question]: Using azure pipelines agent with rootless docker

Describe your question
It looks like where are running into the same issue as reported in  -> https://github.com/microsoft/azure-pipelines-agent/issues/3312
When using rootless docker we run into the error when running the pipeline
"##[error]Unhandled: EACCES: permission denied, open '/__w/_temp/.taskkey'"
It does seem to be an permission with the workspace that is being created by Azure-devops .
Do we have any alternatives suggestions -> installing the agent  with ./svc install <root_user>  doesnt work  . We get the following error
"/usr/bin/docker version --format '{{.Server.APIVersion}}'
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running? "
The understanding is that the docker demo runs with different unix file descriptor. where 100 would be id of the user
" unix:///run/user/100/docker.sock "
Versions
3.218.0/Linux
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
Red HAT 8.7
Version controll system
azure devops
Azure DevOps Server Version (if applicable)
No response

@ivanduplenskikh -> Can you let us know if this rootless docker is supported by the pipline-agent ? if not we would like to know if there will be any support for this in the future road map

Thanks for posting this @ktdharan, I am seeing the same issue on RHEL 8, agent version 3.220.2, although using podman rootless (with docker compatibility packages).
In our configuration we are running multiple agents for concurrency, and believe it may be due to locking or allocation of UID for the additional (concurrent) container. Will update if we find a solution.
@ktdharan can you confirm if you have SELinux on and enforcing in your configuration?

An additional note, there seems to be a permission issue with the initial creation of the temp directory when the agent first executes, so it is worth validating the permissions on the directories it creates.
The /__w/_temp directory in the container this error is referring to is mounted in from <agent_install_directory>/_work/_temp from the host when the container is launched. Validate the permissions on the host directory <agent_install_directory>/_work/_temp to confirm the the container process has read access.

Yes we do have similar issues and our containers are running with podman rootless. Interestingly it happens intermittent and it changes the permission of the _temp directory under agent to "S" like shared. Either we have to give permissions manually or recycle the agent to overcome the issue. We have about 100s of agents runnings and doing it manually is not a easy task for us. Even we automated this work around its impacting our user experience as the builds will get cancelled during restarts. Please advise any possible solution for this.

@phaneendrakotha -> when you say " Either we have to give permissions manually" it means the path <agent_install_directory>/ right ? so what permissions did you give to solve the problem.

Have been working through multiple issues when using podman, and had some success solving this specific issue by changing permissions on the following directory:
/<agent_install_location>/_work/_temp
It appears this needs to be accessible to:

The user the ADO agent is running as for writing the taskkey
The user on the host that the root user in the container is mapped to in /etc/setuid

Note: In our experience a consistent working configuration is to make these the same user. (ie. the user that root in the container is mapped to on the host is the same user configured to run the ADO agent).
If the user and group is correct, 770 should resolve the issue on the _temp directory. You will need to do this for all instances of the temp directory if you are running multiple instances of the container agent to achieve parallel execution.
This solution may also be dependant on the user mapping method you are using in containers.conf, I have had different issues using nomap, keep-id and auto.

Working through all the permutations of issues running rootless docker or podman, I think the majority of them can be solved if a configuration knob was added to disable the user creation steps during the container initialisation step, leaving the user management as an exercise for the developer.
https://github.com/microsoft/azure-pipelines-agent/blob/d7e0704fb4cb4bc6361710df8e6963847774b27c/src/Agent.Worker/ContainerOperationProvider.cs#L546
These steps don't really provide much benefit in rootless container configurations. Perhaps the assumptions here about running as 'root', (especially in rootless environments that map to unprivileged users) need to be revisited?

Hello,
We use on premise version of Azure Devops 2022.
Agent version: 2.217.2 running on Redhat 8 with rootless podman.
I changed the permissions on _temp directory
Now our problem is that dotnet pack command gives us :
Access to the path '/__w/38/s/src/...../obj' is denied
The mounted folder __w is owned by root in the container. I assume it is because the default value of --userns="" -  as pointed in https://www.redhat.com/sysadmin/rootless-podman-user-namespace-modes.
And the user inside the container (..._azpcontainer) does not have permissions to write there.
I cannot use options keep-id because when the agent initialize the container it does not have permissions to complete the tasks mentioned in this #4332
If i execute the following command from user bldagent (uid=1000)
podman run -i -u=0 -v "/home/bldagent/_work/38":"/__w/38" registry/build-image ls -lan /__w/38/
the result is this:
drwxr-xr-x 9     0     0 4096 Oct 25 13:18 .
drwxr-xr-x 3     0     0 4096 Oct 25 16:36 ..
drwxr-xr-x 2     0     0 4096 Oct 25 07:08 TestResults
drwxr-xr-x 2     0     0 4096 Oct 25 07:08 a
drwxr-xr-x 2     0     0 4096 Oct 25 07:08 b
drwxr-xr-x 5     0     0 4096 Oct 25 07:08 s
drwxrwxr-x 2     0     0 4096 Oct 25 12:40 test
drwxrwxrwx 3     0     0 4096 Oct 25 12:45 test2

if i execute the same command from root, the result is:
drwxr-xr-x 9 1000 1000 4096 Oct 25 13:18 .
drwxr-xr-x 3    0    0 4096 Oct 25 16:35 ..
drwxr-xr-x 2 1000 1000 4096 Oct 25 07:08 TestResults
drwxr-xr-x 2 1000 1000 4096 Oct 25 07:08 a
drwxr-xr-x 2 1000 1000 4096 Oct 25 07:08 b
drwxr-xr-x 5 1000 1000 4096 Oct 25 07:08 s
drwxrwxr-x 2 1000 1000 4096 Oct 25 12:40 test
drwxrwxrwx 3 1000 1000 4096 Oct 25 12:45 test2

which is the uid of the bldagent from the host.
Are we missing something with the configuration ?
@pixdrift do you have any success on this or we have to use root for the agent ?

I cannot use options keep-id because when the agent initialize the container it does not have permissions to complete the tasks mentioned in this #4332

Hi @agerchev I do have it working.. but I am the first to admin it's pretty hacky due to all the different scripts/assumptions that are made with the ADO agent.
To get this to work I had to use keep-id in the containers.conf file, and you are correct that this breaks the ADO container initialisation scripts. The only way I have found to work around this is the following 'options' in the pipeline yaml file container resource block:
resources:
  containers:
  - container: my-container
    image: your.image.host/image-name:tag
    options: --user 0:0

In the container image itself, I specify the user I actually want the container to run as (has matching UID to the ADO agent installation user).
Another approach to work around the initialisation script was to basically replace the commands used by ADO to configure the initial user etc. with dummy commands that return 0 so they don't fail on execution with a non-root user, but I never worked all the way through this approach to validate it.
I hope that helps, and apologies if it's not clear.. it's taken a lot of iterating through solutions to get a working combination of configuration, both on the host and in the container.

@pixdrift, thank you, It worked.
Are there any plans for more clean solution?

I have another workaround that works really well & doesn't require any modifications to the pipelines, and I think I now understand the underlying issue:

The host user has UID 1001 in my case.
It also has an entry in /etc/subuid, stating that sub-UIDs shall start at 165536.
By default, the agent starts the container (more or less, it's a bit more complicated than that) with --user=$(id -u) (i.e. --user=1001). That normally ensures that the container is running with the same permissions as the agent, and the agent can e.g. delete files created from the container afterwards (otherwise they'd be owned by root).
A container started with --user=0 (the default) is basically "root" within the sub-UID range (i.e. has the host UID 165536), and more or less directly maps to UID 1001 on the host.
As the container is now started with --user=1001, this doesn't happen - instead, we're now user 166537 (sub-UID range start + 1001). That user doesn't have (especially write) access to most files, and for example can't modify the working directory in a pipeline as well.

This means, that the issue can be solved by setting an ACL for the user for which the agent thinks the UID is correct:
setfacl -m default:user:166537:rwx -m default:group:166537:rwx -m user:166537:rwx -m group:166537:rwx --recursive work

With the "default" ACLs, this now also means that new files will have the ACLs set, which means that this should be a permanent solution. I am not using SELinux, so I have no idea if something additional is required there, but for me this works really well now.

I am not clear on how this solves the specific problems with the startup/initialisation script and the user creation / sudo steps @moqmar, but keen to better understand it. I had the same or similar issues when implementing various iterations of subuid configuration, so interested in this specific combination.
Are you using 'keep-id' in the containers.conf file?
What host OS (distro) are you using? and are you using docker or podman?

I'm using Docker on Debian 12, and didn't touch a containers.conf file. The startup script then has access to all the files it wants to access, as the files are accessible by the user within the container (which has a sub-uid). It is possible that --user=0 is still required on some systems like when using Podman, but that wasn't the case for me.

I'm facing a similar issue using rootless podman with selinux enabled in enforcing mode. /etc/subuid and /etc/subgid are correctly configured.
In my opinion a valid solution will be to enable to mount the volumes using z/Z SELinux:
without:
$ podman run --rm -it -v "/home/azure_agent/myagent/_work:/__w" my-container-job-image:latest ls /__w

ls: cannot open directory '/__w': Permission denied

with Z
$ podman run --rm -it -v "/home/azure_agent/myagent/_work:/__w" my-container-job-image:latest ls -l /__w

drwxr-xr-x.  6 root root   52 Nov  7 05:09 10
drwxr-xr-x.  6 root root   52 Nov 17 10:42 11
drwxr-xr-x.  6 root root   52 Oct 31 14:25 6
drwxr-xr-x.  6 root root   52 Oct 31 13:38 7
drwxr-xr-x.  8 root root  102 Oct 27 13:03 8
drwxr-xr-x.  6 root root   52 Oct 28 08:33 9
drwxr-xr-x.  4 root root   81 May 21 05:01 SourceRootMapping
drwxr-xr-x. 13 root root 4096 Nov 16 17:30 _tasks
drwxr-xr-x.  2 root root    6 Nov 17 10:43 _temp
drwxr-xr-x.  2 root root    6 Apr 13  2023 _tool
drwxr-xr-x.  3 root root   20 Oct 26 08:57 context
drwxr-xr-x.  3 root root   26 Apr 13  2023 node_modules

that it is correctly mapped to the root user.
Maybe adding a new option here to support SELinux should be enough


Add No Resources Found label under azure browse

This PR fixes #22373

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 41.685%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/azureResource/tree/flatAccountTreeNode.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/dialog/configurePython/configurePathPage.ts
1
57.02%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
30347

Relevant Lines:
67403

💛  - Coveralls


Markdown-it plugin bad behavior with subfolder since 0.49.11

Hi,
Describe the bug
Markdown-it plugin seems to not work when the slides.md file is in a subfolder
Minimal reproduction
Steps to reproduce the behavior:
I did a minimal reproductible test repository https://gitlab.com/pinage404/slidev_bad_subfolder_behavior/-/commits/main/?ref_type=HEADS

having the slides.md file in a subfolder
slidev build ./subfolder/slides.md

with this content in the slides.md
Normal ^sup^ normal

add markdown-it plugin

With<EMAIL_ADDRESS>plugin works
With<EMAIL_ADDRESS>the build works but the plugin seems ignored
With<EMAIL_ADDRESS>(current latest), same behavior as 0.49.11
Alternative solution
Moving the slides.md  in the root folder fix it
Additional context
I noticed the backward incompatibility on this slide (the corresponding code)
Environment

Slidev version: 0.49.11 and newer
Browser: not relevant, it fails event when building Firefox 128.0.2 (64-bit)
OS: NixOS 24.05.20240725.a1cc729 (Uakari) x86_64

If you are using Slidev globally (i.e. npx slidev or npm i -g slidev), please try to reproduce the issue in a local project (i.e. npm create slidev@latest).
It was really long and hard to isolate the problem, good luck with this one

Sorry, I can't see the content of your vite.config.ts. GitLab says 404 NotFound

Weird, it works for me
Here is the content
import MarkdownItSup from 'markdown-it-sup'
import { defineConfig } from 'vite'

export default defineConfig({
    slidev: {
        markdown: {
            markdownItSetup(md) {
                md.use(MarkdownItSup)
            },
        },
    },
})

It seems that the vite.config.ts hasn't been run. Move the vite.config.ts to the subfolder (next to slides.md) can fix this. Let's keep this issue open so that we can improve the behavior of the detection of "user root".

It used to work in 0.49.10 and below
I imagine that 0.49.11 introduces a behavior change
Thanks, i did a symlink in the subfolders this fix the issue

Hey folks, what's the current status of moving slides to a nested folders? I run a single slidev setup with multiple slides and noticed this issue. Layouts are not found too, so I moved back to leaving slides in the root folder, which I guess is not so bad, but I am wondering what's the expected behaviour.


fix flappy test

fix flappy test by making it impossible for the real node to determine that the target node is down
@uber/ringpop
In ringpop, a node E is declared suspect trough the indirect ping mechanism: When a node A fails to ping E; A randomly picks three members to send a ping-req to, say B, C and D. Upon receiving the ping-reqs the three nodes will ping E and send back the status (ping ok / ping not ok) to A. If all three results are "ping not ok", A will declare E suspect.
In this test we check ringpop's behaviour from the perspective of B (or C or D). We check if B responds with "ping not ok" since E is not responsive. It is important that B doesn't decide that E is a suspect when the ping from B to E fails, which could be a likely programmer mistake. Therefore we check that the all members are alive and there are no suspects in B's membership at the end of the test.
However, sometimes B found out that E is suspect trough it's own ping mechanism, which caused the test to fail. By disabling all pings and ping-reqs, B will never be able to decide if E is unreachable and therefor no longer declares E suspect.

LGTM, but please put the PR description to the commit message.


vcpkg installation don't work

C:\libs\vcpkg> .\vcpkg.exe install cppmicroservices:x64-windows
Computing installation plan...
The following packages will be built and installed:
cppmicroservices[core]:x64-windows
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\vcpkg\archives\fb\fbd15c3bb47446ea623a508467c3a9e26eaaab27.zip
Starting package 1/1: cppmicroservices:x64-windows
Building package cppmicroservices[core]:x64-windows...
-- Using cached C:/libs/vcpkg/downloads/CppMicroServices-CppMicroservices-b4d3d404df01d67dfd7fc36111bc5de50e1b89d6.tar.gz
-- Cleaning sources at C:/libs/vcpkg/buildtrees/cppmicroservices/src/e50e1b89d6-8d41542668.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/libs/vcpkg/downloads/CppMicroServices-CppMicroservices-b4d3d404df01d67dfd7fc36111bc5de50e1b89d6.tar.gz
-- Applying patch werror.patch
-- Applying patch fix-dependency-gtest.patch
-- Using source at C:/libs/vcpkg/buildtrees/cppmicroservices/src/e50e1b89d6-8d41542668.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:142 (message):
Command failed: C:/libs/vcpkg/downloads/tools/cmake-3.18.4-windows/cmake-3.18.4-win32-x86/bin/cmake.exe --build . --config Debug --target install -- -v -j9
Working Directory: C:/libs/vcpkg/buildtrees/cppmicroservices/x64-windows-dbg
See logs for more information:
C:\libs\vcpkg\buildtrees\cppmicroservices\install-x64-windows-dbg-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_cmake.cmake:93 (vcpkg_execute_build_process)
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/cppmicroservices/portfile.cmake:21 (vcpkg_install_cmake)
scripts/ports.cmake:136 (include)
Package: cppmicroservices:x64-windows
Vcpkg version: 2020.11.12-nohash

For me it seems to work for the installation : #677

Please my comment in https://github.com/CppMicroServices/CppMicroServices/issues/677#issuecomment-1159581761
Apologies for any inconveniences.


Issues with docker compose

Could you please address these issues?
a.	The documentation doesn’t specify what the name of the created compose project is.
b.	If docker-compose throws an error, the error details are not propagated to either Ibiza or the CLI.
c.	There’s no way to specify the COMPOSE_HTTP_TIMEOUT, so any moderately complicated compose projects (like ours) will always fail.
Thank you
--Azure IoT Team

Close to open three different issues instead of one issue for three problems.


Use Git branches/tags for versioning

Description
MA-2314
The version name (and version code) will now be determined automatically by using, in this order:

the version number in the BRANCH environment variable (for Travis CI)
the version number in the git branch name
the version number reported by git describe

For a branch / tag to be considered, it must start with rc/ or release/ prefix. E.g. rc/2.5.0 or release/2.6.
The version code will be based on the semantic version, allowing 3 digits between each decimal. For example, the version 2.3.67 will result in a version code of 2003067.
To quickly see what version would be used if you were to build right now, you can use the new gradle version task, for example: BRANCH=rc/2.3.0 ./gradlew --quiet version which will print 2.3.0 (2003000)
Travis CI
Travis does not expose the branch or fetch tags by default, so I updated the script to expose a BRANCH as an environment variable, as well as fetch the tags, so that both branch / tag based versioning will work on Travis as well.
Reviewers
If you've been tagged for review, please check your corresponding box once you've given the :+1:.

[ ] Code review: @BenjiLee
[ ] Code review: @mdinino

@@             master       #774   diff @@
==========================================
  Files           485        485
  Lines         20599      20599
  Methods           0          0
  Messages          0          0
  Branches       2912       2912
==========================================
  Hits           3650       3650
  Misses        16542      16542
  Partials        407        407

Review [#774][cc-pull] on Codecov

Powered by Codecov. Last updated by [00a1787...98b3b13][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-android/compare/00a178714798807708b44440f388dab1f9aeea49...98b3b1311b2ae656118ac64f3e9003a1a78e0a36?src=pr
[cc-pull]: https://codecov.io/gh/edx/edx-app-android/pull/774?src=pr

Test failure :(

Can we bump down the versionCode and versionName in master for this PR?

I'm curios about @BenjiLee 's question too. But other than that 👍

Ah, nvm. I see the change now.

Tried to created a build with a branch called rc/3.4.666, no version displayed

Additionally, Fabric is reporting the build as 0.0 (0)

@BenjiLee Fixed your issue; strange that it still built fine.
Also fixed Travis

@brianguertin @BenjiLee
I am wondering how this solution is going to work with what we talked about yesterday. If we have nightly builds. Are they all going to be on an RC branch? Should it be a part of the build automation process to create a new RC branch every time we run the script?
I am wondering if another option of implementing this JIRA ticket is to  derive the int number from the timestamp.

We can always create a different trigger for nightly builds. For example, if there is a branch called nightly/2.5.1 it can kick off the build.

We could derive the int from the timestamp. Is there a specific reason to use timestamps?

No, the only reason I suggested timestamps is that it's unique and always increasing.
My thought was that we modify the Gradle script to convert the time stamp to a int number automatically. Gradle could also take a version int parameter that would override this.
@bguertin What are your thoughts? I don't mind implementing, BTW.

The version int is only important for Google Play distribution, our testing builds have no reason to depend on it's value or to increment it. I think it is in our best interest to forget it exists, and rely only on the semantic version.
Like Chris said, we could easily customize the nightly build (or any build) to use a particular version if we need to. If building off master right now, it will use the last annotated tag in master (i.e. the output of git describe)

OK. That works.
On Tue, Jul 19, 2016 at 11:06 AM, Brian @ edX<EMAIL_ADDRESS>wrote:

The version int is only important for Google Play distribution, our
testing builds have no reason to depend on it's value or to increment it. I
think it is in our best interest to forget it exists, and rely only on the
semantic version.
Like Chris said, we could easily customize the nightly build (or any
build) to use a particular version if we need to. If building off master
right now, it will use the last annotated tag in master (i.e. the output of git
describe)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/edx/edx-app-android/pull/774#issuecomment-233662536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR10Twv0tEBhDKGXg_AxIWSfUoCB5N0Yks5qXOfigaJpZM4JNpnJ
.

--
Regards,
Marc DiNino
Android Engineer
EDX

Note, this strategy also implies that every submission to Google Play should (in fact, MUST) be accompanied by an increase in the semantic versionName string.
I think that's a good thing, but please speak up if you foresee any issue with that. I've used this strategy for other apps in the past without issue.

It think it should be OK.
On Tue, Jul 19, 2016 at 11:10 AM, Brian @ edX<EMAIL_ADDRESS>wrote:

Note, this strategy also implies that every submission to Google Play
should (in fact, MUST) be accompanied by an increase in the semantic
versionName string.
I think that's a good thing, but please speak up if you foresee any issue
with that. I've used this strategy for other apps in the past without issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/edx/edx-app-android/pull/774#issuecomment-233663959,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR10TzaovvQ1RNfJ4pYdTqulrEyo2M3yks5qXOjpgaJpZM4JNpnJ
.

--
Regards,
Marc DiNino
Android Engineer
EDX

👍


CKKS bootstrapping randomly returns ciphertext with incorrect data

Hi!
I am using this library to do some computation on the CKKS ciphertext that requires a lot of bootstrapping and I have notice that sometimes after bootstrapping, the data inside the output ciphertext was incorrect; however, this problem only occurs some of the time, meaning that if I run the same code twice one might return the correct result, and the other might fail. After looking through this paper, I have notice that it mentioned bootstrapping failure probability; therefore, I would like to know if this issue is related to the bootstrapping failure mentioned in the paper or not, and, if it is, is there any way to prevent it from happening, or to check if it had happened (without decrypting the ciphertext).
For the parameter, I am using the ckks.DefaultBootstrapSchemeParams[0] as a ciphertext params and ckks.DefaultBootstrapParams[0] for bootstrapping params. I am using v2.1.1 of this library.
Thanks.

Hi FongChanatip,
The bootstrapping parameters in v2.1.1. were set before a throughout failure probability analysis, and aren't the ones showcased in our paper. You can use the ones present in the latest code of the master as they are the ones of our paper. This should solve your problem. Note that there will always be a non zero probability of failure but it should this time be negligible.

Thank you! I'll try that out.


IGNITE-21678 Fix CDC ignite to ignite streamer in case BinaryConfiguration is specified in config

Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist

[X] There is a single JIRA ticket related to the pull request.
[X] The web-link to the pull request is attached to the JIRA ticket.
[X] The JIRA ticket has the Patch Available state.
[X] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[X] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[X] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[ ] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

replaced with https://github.com/apache/ignite/pull/11275


How can I work with custom WorkItemTypes?

I was trying to use the following configuartion
{ name: "System.WorkItemType" value: "Review" }
Review is a custom work item type created in an inherited process.
If I run this configurations, I'm getting the error message that says the Review is not allowed for System.WorkItemType.
I have check the details of a custom type and there the System.WorkItemType has the Review value.
Could you guide me please?
Thanks

Did you check your custom work item name with the API?
Rest API WorkItem types


Merge Hotfix 2.6.2 onto master

Codecov Report

Merging #1891 (7035e14) into master (846f43d) will decrease coverage by 0.06%.
The diff coverage is 46.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   83.43%   83.37%   -0.06%
==========================================
  Files         470      470
  Lines       16624    16646      +22
  Branches     2498     2499       +1
==========================================
+ Hits        13870    13878       +8
- Misses       2066     2081      +15
+ Partials      688      687       -1

Files
Coverage Δ

...ernal/vitals/JankStatsActivityLifecycleListener.kt
68.70% <46.15%> (-2.58%)
:arrow_down:

... and 28 files with indirect coverage changes


Inform that HME has been used for that website already

Hi again :)
I wanted to suggest a feature for the forgetful users of us.
When I am opening the extension, it is offering to create an HME for that website. But it is not recognizing, that I already did that in the past. I would need to manually switch to the "Manage Emails" tab, search for that website if it exists or not.
It would be helpful, if there is a little banner telling me, that I already created an HME for that specific domain. It should still offer me to create a new one though.
The banner should also recognize, when I created an HME for https://domain. com_, but now accessing https://sub.domain.com
Kind Regards

Hi @smoochy! I've thought about this feature (which Safari also provides) but I've omitted it in purpose because I didn't want the scope of the extension to overlap with the scope of a password manager. Password managers remind users of their existing emails, upon focusing on an email input element. That's one of the core features of every password manager. On the other hand, the primary concern of the HME extension is the generation of new addresses. I think it's better to keep these two concerns separate, and advise users to rely on password managers for the purposes of remembering existing addresses, but I'm happy to be challenged on that opinion.

That said, I think it would be useful to add a small hint in the extension icon, whenever the user visits a website for which an HME already exists. Something like a blue dot next to the apple.

Well, I think it is important to inform the forgetful user, that an alias had been created already for that domain.
If you think, a little banner on the "Create an address for" page would be too intrusive, an icon, as proposed by you, would be a good and decent trade-off.

I agree with @smoochy. I think for most user's the use-case is ONE email per service.
I would also love an option to omit the html injection for all sites i have already used hme for.
For me it happens alot, that I accidentally click on it and create another alias because sometimes hme is faster than 1password.

I would also love an option to omit the html injection for all sites i have already used hme for

@felix-exon this is great feedback, thank you! I'll look into adding this whenever I get the time to work on this issue.
If you find this to be too annoying you can navigate to the options of the extension to disable the autofill button and rely solely on the context menu.


Text Option: rotate: does not work within table cells.

Passing an array of objects with text/options values as the text value to table cells does not support the rotate option. The rotate option only worked with the .addText method.
When trying to rotate the text within a table cell using
rows.push ([
{ text: "text", options: { color: "ffffff", fill: "708371", rotate: 270 } }
]);
The text within the table cell would not rotate. When following the other syntax, and moving the rotate option outside of the text options properties, the text within the table cell would not rotate.

Same problem here. Any follow-up on this issue would be great.

The author has added this feature in a commit of version 3.13.0-beta.0 (not available in a cdn at the moment)
Syntax looks like this :
rows.push({ text: "Hello world", options: { textDirection: "vert270" } }) //Or textDirection: "vert"


token [3293] not found in text

OS: Win11, CUDA, jupyternotebook
This issue happened to run test.py(original but almost same as "Basic Usage").

Token (type: read) is set to .env
.env is set to same folder as test.py
CUDA &cuDNN is installed correctly
diffusers simple script can run

I don't know why this script can't get token from ".env" file.
Or, are there the other issue?
#test.py

import math
import os
import dotenv
from PIL import Image
from paint_with_words import paint_with_words

settings = {
    "color_context": {
        (7, 9, 175): "sky,1.0",
        (145, 177, 102): "moon,1.0",
        (98, 190, 214): "mountain,0.2",
        (90, 161, 58): "ground,0.2",
        (90, 102, 246): "lake,0.2"
    },
    "color_map_img_path": "input.png",
    "input_prompt": "realistic photo of a dog, cat, tree, with beautiful sky, on sandy ground",
    "output_img_path": "/output.png",
}

if __name__ == "__main__":

    try:

        dotenv.load_dotenv()

        color_map_image = Image.open(settings["color_map_img_path"]).convert("RGB")
        color_context = settings["color_context"]
        input_prompt = settings["input_prompt"]

        img = paint_with_words(
            color_context=color_context,
            color_map_image=color_map_image,
            input_prompt=input_prompt,
            num_inference_steps=30,
            guidance_scale=7.5,
            device="cuda:0",
            weight_function=lambda w, sigma, qk: 0.4 * w * math.log(1 + sigma) * qk.max(),
        )

        img.save(settings["output_img_path"])

    except Exception as e:
        print(e)

#output
CompVis/stable-diffusion-v1-4
CompVis/stable-diffusion-v1-4
Some weights of the model c....
......
.....
...
..
.
token [3293] not found in text
token [3293] not found in text

#diffusers simple script

from diffusers import StableDiffusionPipeline
import os

TOKEN = os.getenv("HF_TOKEN")

pipe = StableDiffusionPipeline.from_pretrained(
    "CompVis/stable-diffusion-v1-4",
    use_auth_token=TOKEN
).to("cuda:0")

from torch import autocast

prompt = "cute cat with colorful eye, jumping on the grass."
with autocast("cuda"):
    images = pipe(prompt, guidance_scale=7.5).images
images[0].save("output.png")

That error is because input_prompt doesn't contain "moon", "mountain", or "lake".

Thank you for quickly and accuratery advising.
The script worked fine when I included all the "color-context" words in the input-prompt.
I had mistaken “token" for haggingface’s.
Thank you so much😊