Point at caspark/ansible-factorio / delete this empty repo?

Heya, I notice this repo is named the same as my repo over at https://github.com/caspark/ansible-factorio, but it seems like you lost interest/motivation/whatever before pushing anything substantial up.
So in the name of helping out people looking for an easy way to set up factorio: do you think it makes sense to delete this repo or perhaps otherwise point it at caspark/ansible-factorio?

Sure - I had a look at your repo and it looks like you didn't use a galaxy role. I do prefer that all roles are built that way so users can just pick and choose what roles to include via requirements.txt. Are you taking PR's ? :)


Use namespaced jQuery in get_forwards

The function get_forwards was defined without the usual IIFE aliasing yl.jQuery to $. Since it wasn’t used anywhere else, this also moves it inside the Select2 script to avoid defining the function globally.
Should fix #792 (#806).

(Linting is failing because of https://gitlab.com/pycqa/flake8-docstrings/merge_requests/7.)

I got a good feeling about this, let's merge it and we can still revert / work it out if @gagarski (original author of this script) finds any objection.

It is not used outside select2.js but actually this code could be used for other autocomplete widgets. For now, I think we can move it back and/or refactor it when there will be any.

Thanks, everyone!


Crash when formatting case and macro for

case
{% for index in 0..0 %}
{% end %}
end

$ crystal tool format --show-backtrace

expecting {%, not `NEWLINE, `, at :1:5 (Exception)
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???

couldn't format './cr.cr', please report a bug including the contents of it: https://github.com/crystal-lang/crystal/issues

It is not a valid macro, you can't do that. As documented here: Macros

This means, for example, a macro cannot generate a one or more when expressions of a case statement unless case was a part of the generated code.

You can do this:
{% begin %}
case
{% for index in 0..0 %}
{% end %}
end
{% end %}

Technically, the code is valid because the expanded macro is empty. But of course, it doesn't make sense because you can't do anything useful with it.
Still, since it's valid syntax, the formatter should be able to handle it.
We could also consider making an outer macro expansion directly following a case or when expression a syntax error.


[Port dspace-7_x] Fix "No SLF4J providers were found." issue on all branches

Description
Manual port of #10036 to dspace-7_x
This includes an extra commit which removes unused slf4j dependencies from the main POM.  This is necessary because it's bad practice to include log4j-slf4j2-impl and log4j-over-slf4j... as these two bridges are opposite.  The first forwards slf4j to log4j, and the second forwards log4j to slf4j.

It appears this needs a different fix on 7.x.  I'll look into it tomorrow.

Closing as this error does NOT occur on dspace-7_x.  I've verified it's not impacted, and the dspace-7_x codebase still uses SLF4J itself in some areas.


[feature] DBus notification

Version and OS
0.45.25 on linux/docker
Is your feature request related to a problem? Please describe.
DBus notification is supported by apprise: https://github.com/caronc/apprise/wiki/Notify_dbus
However, if I input dbus:// in notification, it is not recognized.
Describe the solution you'd like
Support dbus:// notification
Describe the use-case and give concrete real-world examples
(This is used when the notification is local)
Additional context

its not an issue, its more about configuration, you need to connect dbus to your container


GooglePayButton appearance rejected by Google for being too rounded

We've had our Google Pay API integration submission rejected on the basis that "our brand guidelines have been reverted to reflect the rectangular asset and no longer the rounded Google Pay button". I attach the implementation of GooglePayButton and a screenshot showing how it appears within the app - thanks.
GooglePayButton(
   paymentConfiguration: PaymentConfiguration.fromJsonString(googlePayConfig),
   paymentItems: [paymentItem],
   type: GooglePayButtonType.pay,
   onPaymentResult: onGooglePayResult,
   loadingIndicator: const Center(
      child: CircularProgressIndicator(),
   ),
),

I have the same issue my app is also rejected by the Google for not matching there's brand guidelines

Please fix this issue

I have the same problem. Is anyone managing to use this lib like this?

Hi @fergushowe and @alekingo, apologies for the setback.
We've taken a look and adjuster the process.
Can you confirm that this is not a publish blocker anymore?

The roundness of the button is included in the design review as valid styling.
Can you confirm the issue is resolved?


bus_server: 0.1.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository bus_server to 0.1.0-0:

upstream repository: https://github.com/UbiquityRobotics/bus_server.git
release repository: https://github.com/UbiquityRobotics-release/bus_server-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: null

bus_server
* Added sonar statistics install rule
* Updated package.xml
* Added install rules
  to make sure python scripts are runnable in non-devel environments (such as installing from debs)
* Changed minimum sensor range to .15
* Fixed typo for /dev/ttyAMA0
* Merged
* Fixed /dev/ttyACM0=>/dev/ttyAMA0
* Use default ports if no port parameter is specified.
* Got dynamic sonar scheduling to work.
* Continuing to work on Sonars.
* Changed the strategy for managing clock skew between the robot and ROS.
* Added class/left_id/right_id fields to each Sonar.  These can be specified in the .yaml file and get reflected by bus_server.py to through to the robot firmware.  These fields are needed for dynamic sonar scheduling.
* Updated the descriptive text at the beginning of bus_server.py .
* Added Twist (cmd_vel) and transfer PID parameters to robot.
* Merge branch 'master' of https://github.com/UbiquityRobotics/bus_server
* Got odometry work in bus_server.py.
* Got odometry working.
* Refactored dead reckoning code into Dead_Reckon class.
* Merge branch 'master' of https://github.com/UbiquityRobotics/bus_server
* Backing down PID loop debug to minimal
* Merge branch 'master' of https://github.com/UbiquityRobotics/bus_server
* Got sonar sensers to publish range topics all the way to RViz.
* Increase PID rate and fix problem with initial going backwards at slow speeds. Also have debug serial to the bus_uart in PID loop which is on for now but can be disabled.
* Fixed typo with a duplicate left encoder set.
* Started adding sonar support to bus_server.py.
* Added in accidentally deleted code that sets encoders in PID code chunk.  Me bad.
* Rearranged bus_server.py to have all of the imports in one place.  Added main() and made the last line of code in the file run main().
* Created bus_server.py by concatenating all of the ROS Aduino bridge python files into one.  This code will not work.
* Added sonars to queue command.
* Added q command to bus server.  Some minor clean up on encoder interface.
* Making the Do PID param be Ko as other places like that term more.  No actual functional change with this cleanup
* Change PID loop rate to 10 hz and put command u for pin params in order of  Kp Kd Ki Do Ci to better match how it was before Ci appeared.  also if we use 'u 1' with less than 5 params we print params and don't set them.
* Removed concept of unit number for sonars.
* Refactored the code so that Sonar.{h,cpp} no longer needs RAB_Sonar{h,cpp}.
* Removed pin definitions from bus_loki and Sonar.
* Removed unused and unneed encoder registers from bus_sonar10.
* Got bus_sonar10 to return ficticious sonar data over the bus.
* Refactored bus_server, bus_loki, and bus_freya to add the RAB_Sonar class.  This is prepatory work for bus_sonar10.
* Change pid update to 25hz from 5hz. Add cap for speeds in z command. Change the debug PID override mode so you must set debug flag  to enable PID override when Kp is 0 so we can better tune pid without it interfering.  IMPORTANT:  Adding integral cap term so the u command has 5 terms now as Kp Kd Ki Ci Do   where new term is Ci as integral cap to avoid runaway integral term issues
* Adding description of serial commands we support
* Adding description of serial commands we support
* Added a debug to support periodic print of sonar meas error counters for minimally evasive debug
* Return distances in Cm now per correct way ROS expects the values
* Switch the p command to read from cached in-ram prior measurements.  Added back in the o which does inline measurement.  Returned values for Sonar are still in mm.
* Changed 'o' command to 'p' command.
* Adding system_debug_flags for dynamic changing of what is printed to serial port.  Should act like before by default is the intention.  Flags in bus_server.h
* Fixes to non-PID motor control when Kp is set to 0 and support for reading all sonars or just one using o command
* Renamed x command to z command.  z command sets the motor speeds without using PID loop.
* Removed some debugging code.  Removed a minus sign on the right motor speed.
* Got Loki encoders working.
* Upgrade to new Bus_Motor_Encoder API that has encoder get/set and pwm set methods.
* Wrapped up Bridge object conversion.
* More conversion over to Bridge object.
* Started transition over to Bridge object.
* More Freya/Loki refactoring.
* Finished refactoring Freya code.
* Started refactoring Freya and Loki code.
* Remove serial input echo so ROS Arduino Bridge functions properly.  Added option to invert encoder sense but have left it to be functionally as it was before so it is a debug compile time option.
* Lot's of code refactoring.
* Got bus_server to talk to bus_bridge_encoders_sonar on the bus.
* Converted code into Bus_Server class.  Added in some serial port code from the Configurator project.
* Got bus_server_server to respond to messages from bus_bridge_encoders_sonar .
* Added missing Frame_Buffer.cpp/h
* Refactored sharable code from bus_raspberry_pi.
* Added BusInt{8,16,32}{Get,Set}.srv RCP messages.
* Initial commit.
* Contributors: Mark, Rohan Agrawal, Wayne C. Gramlich, Wayne Gramlich

Holding until new buildfarm rollout is complete early next week.


Write and add linter to M3DB for detecting locks that are locked and then never unlocked

I.E the linter should be able to detect simple errors like this
func (s *someStruct) someMethod() error {
    s.Lock()
    err := s.doSomeWork()
    if err != nil {
        return err
    }
    s.Unlock()
    return nil
}

This will allow us to avoid defer's in hot-paths, but still be confident our code isn't buggy.

Did a little research on this a while back, more details here: https://github.com/m3db/build-tools/issues/14


Arena fix for Gen

[ ] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

closes #2702
Arenas for Gen-created sets were incorrectly always using fixed pointers, meaning that in the reconstruction (and subsequent output) these sets were shown to contain elements, which the underlying SMT constraints did not imply. The fix is to use a pointer with an unconstrained SMT value instead, and let the solver determine memberships, if any.

Codecov Report

Merging #2704 (f97ad34) into main (c6e014c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
- Coverage   78.50%   78.48%   -0.03%
==========================================
  Files         460      460
  Lines       15879    15876       -3
  Branches     2594     2595       +1
==========================================
- Hits        12466    12460       -6
- Misses       3413     3416       +3

Files Changed
Coverage Δ

.../apalache/tla/bmcmt/rules/aux/ValueGenerator.scala
98.38% <100.00%> (-0.04%)
:arrow_down:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix a claim that disconnecting an iframe causes it to load a document.

Also link to the definition of "disconnected".
The original text comes from #144. @rakina / @domenic, is this fix correct?

Preview | Diff

Oh, thanks! LGTM (although I don't think I have the power to approve the PR)


optimization: better is possible ?

Thanks for having created PCSE, this is just great.
My goal is to optimize crop management.
So
(a) I start from your notebook about optimization
(b) I check the optimization method (the code proposes NLOPT)
(c) I tried with other optimization methods to see if I can do better.
As detailed below, I think the methods I am using do much better (see results, all tested methods did better).
Now, I'd like to optimize more things. Like: an irrigation planning, or all human-controlled parameters we could think of. What do you think, is PCSE the right tool for this ? I can do the optimization with Nevergrad (which should be able to optimize hundreds or thousands of parameters), what I need is the simulator (I'm not an expert in crops...).
Any comment will be very appreciated!
Below my experiments in optimization.
In the notebook, nlopt obtains 0.14.
I have tried several methods in Nevergrad and results were all better:
NGOpt  obtains  3.345145142658821e-08
MetaModel  obtains  0.016835617653238974
Powell  obtains  0.01730523487596341
Cobyla  obtains  3.345145142658821e-08
CMA  obtains  0.03546233072931834
OnePlusOne  obtains  0.0005519658583644366
GeneticDE  obtains  0.010866832311696285
(NGOpt is the default in Nevergrad, and others are classical baselines)
Maybe NLOPT is not correctly parametrized ?
The code is quite small and simple (you might need pip install nevergrad):
import nevergrad as ng
Creating the objective function.
objfunc_calculator = ObjectiveFunctionCalculator(params, wdp, agro, df_pseudo_obs)
Creating Nevergrad's optimization method.
for opt in ["NGOpt", "MetaModel", "Powell", "Cobyla", "CMA", "OnePlusOne", "GeneticDE"]:
param = ng.p.Array(shape=(2,),
lower=(TDWI_range[0], SPAN_range[0]),
upper=(TDWI_range[1], SPAN_range[1]))
ng_optimizer = ng.optimizers.registry[opt](param, budget=num_calls)
x = ng_optimizer.minimize(objfunc_calculator).value
# Display results.
print("\noptimum at TDWI: %s, SPAN: %s" % (x[0], x[1]))
print(opt, " obtains ",  objfunc_calculator(x))
print("With %i function calls" % num_calls)

======================

(the indent has been lost in the copy-paste, sorry...)

Hi Teytaud,
Thanks for your remarks on my optimization code. What I am wondering is: what are you comparing? I guess this is the final error obtained of the solution. I would be easy to have NLOPT obtain a better solution, but at the expense of more function evaluations. So if you post the error you obtain with different algorithms, you also have to put the number of function evaluations. My experience with NLOPT is that it works quite well, but I never tried nevergrad, I will have a look.
Allard

We created various things based on your notebooks. You are the experts so your opinion is more than welcome:

https://github.com/facebookresearch/nevergrad/pull/1341/files (optimizing irrigation times)
https://github.com/facebookresearch/nevergrad/pull/1339 (optimizing hyperparameters of PCSE)
less directly related to your notebooks, adding NLOPT in Nevergrad (https://github.com/facebookresearch/nevergrad/pull/1340 )

Hello! I agree that we should use the same number of function evaluations, this is exactly what we have done.
We now try to include more agromanagement problems. We included this problem Adding Python Crop Simulation facebookresearch/nevergrad#1339 (optimizing hyperparameters of PCSE)
, but also an irrigation problem also based on your work: https://github.com/facebookresearch/nevergrad/pull/1341
We also added the FAO simulator: https://github.com/facebookresearch/nevergrad/pull/1343
This is work in progress, not yet merged in our main branch. Your feedback on what we are doing is welcome, as well as suggestions of useful problems.
Have a great day and thanks for PCSE and for these notebooks.


Add support for Italian

I chose "scheda" as the translation for card. "Carta" is also a valid option, although "scheda" has a nuance of information, while "carta" is more like a card for gaming, hence why I chose the former

Thank you, didn't catch that :)


Package installation fails with URP 14.0.3 and unity 2022.2.0b10

Tried to add ECS to my project, upgraded URP and unity
Sadly whenever the package manager tries to install BitRenderFeature, it fails with this error
[Package Manager Window] Error adding package: com.cyanilux.urp-blitrenderfeature@https://github.com/Cyanilux/URP_BlitRenderFeature.git.
ENOTEMPTY: directory not empty, rmdir 'pojectdir\Library\PackageCache\.tmp-13968-EFB7LJGCNbRz'
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

Copying the files directly in the folder works normally

This error seems related to the Package Manager itself or a bug introduced in that beta version of Unity, not something I can fix.
Could try deleting that directory and let Unity repopulate it. Probably a good idea to back-up before that just in case.
But if copying files manually works, that's good too.

Deleting this file or even the whole library does nothing. Will try to reproduce the big with another package


Updated the copyright year

Issue Number
fixes #166
Describe the changes you've made
I have updated the copyright year on the Login/Register page by using the getFullYear() function which returns the full 4-digit number (year) according to the present date.
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
NA
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Issue Number
fixes #166
Describe the changes you've made
I have updated the copyright year on the Login/Register page by using the getFullYear() function which returns the full 4-digit number (year) according to the present date.
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't) NA
Checklist

[x]  My code follows the code style of this project.
[ ]  My change requires a change to the documentation.
[ ]  I have updated the documentation accordingly.
[x]  All new and existing tests passed.
[x]  The title of my pull request is a short description of the requested changes.

@cyntss I have updated my PR. Kindly review it. Thank you


Replace isatty(1) with process.stdout.isTTY

Replaced tty.isatty(1) with process.stdout.isTTY
This change slightly decreases the module loading time, as measured in the nanocolors repo: 0.515 ms -> 0.502ms (best of the 100 measurements)

process.stdout.isTTY means exactly the same as tty.isatty(1) and is supported since Node v0.5.8

Seems like on Node.js 12 process.stdout.isTTY is wrong https://github.com/pinojs/pino-pretty/issues/220#issuecomment-912959528

Oh, I see


Fix/install button escapes paths on windows

Fixes #496

:tada: This PR is included in version 0.49.0 :tada:
The release is available on:

v0.49.0
GitHub release

Your semantic-release bot :package::rocket:


namespace is broken

With this PR namespace is broken and documentation on readme is using old namespace.

https://github.com/williamespindola/rabbitmq-service-provider/pull/12#issuecomment-334646878


Create GitHub release when tagged and binary packages of Poppy

Adding GitHub releases when tagged
Adding binary packages for easy installation of Poppy

The magic with Rust cargo is that users can install binaries provided by some crates, and even the version they want.
For instance one can install latest poppy binary with cargo install poppy-filters or a specific version with cargo install --version A.B.C poppy-filters. This will download and compile the good poppy binary and put it in $HOME/.cargo/bin.
Moreover cargo install can also be used to install the binary at a custom location.
So to say that when publishing crates on crates.io, I think managing GH releases cycles might sound a bit like double work.


Publish the package to PyPI and make datopian owner

Publish the package so it is available as pip and make sure dataopian is the owner.

Done in c1dd254541bc621259cd821c0f2eb22e975110d0 and datopian added as owner at PyPI.


Reorder Services

Ordering is important here.
@keybase/react-hackers

Maybe better to just have an array you reduce to make this

I thought it had to be an object so that we could have a type on the keys? export type ServiceIdWithContact = $Keys<typeof _services> Let me check if we can do something similar with an array

Oh yeah. But maybe it's not derived. Just a regular type. Then the const can be typed as array of that type

Lol, I'm pretty sure that's what it was at some point...
ah here it is: https://github.com/keybase/client/pull/13486/files/58c7b62932af774b69d115579bd4e1e2cf7908fc#r221350024

I guess I'm a little worried about it getting broken again

yep, that's reasonable. I'll switch it to an ordered array

https://flow.org/en/docs/types/generics/#toc-adding-types-to-generics

yeah, but nothing effectively changed about the code. This is likely the correct behavior, and there was some bug edge case when using $Keys<...>


Open Street Map extractor

What would you like to see added to or changed in Embedded Assets, and why?
Extractor for embedding iframes from Open Street Map.

Added in https://github.com/spicywebau/craft-embedded-assets/commit/0cf7da72780bd820a4bbf1b6cd2fb9afe5e12a96


label all Cilium resources with "app.kubernetes.io/part-of: cilium"

Signed-off-by: cyclinder<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Thanks for contributing!

Fixes: #20088
label all Cilium resources with "app.kubernetes.io/part-of: cilium"

I'm not sure if I need to label resources of the type configMap,RBAC..

Is the idea here to eventually deprecate the k8s-app=cilium label?

Is the idea here to eventually deprecate the k8s-app=cilium label?

I don't think so. k8s-app uses different values for each component (e.g. k8s-app: cilium vs k8s-app: hubble-relay), which we also use for service selectors, while part-of is the same for all components of the cilium Helm chart and more purely informational.

Yes but if we begin following the "recommended" labels, k8s-app would equate to app.kubernetes.io/name or app.kubernetes.io/component. See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

@gandro and @cyclinder Given that this moves us to one of the recommended k8s labels, I'd also be pretty happy if we moved k8s-app to the recommended ones suggested above as well. I do not think we should remove the k8s-app label just yet, but migrate away from it and towards the set of recommended lables. How do you both feel about this?

I'm not sure if I need to label resources of the type configMap,RBAC..

Is there a reason those might be excluded?

We use k8s-app for all the deployment/ds matchLabels selectors. We would probably want to deprecate that to make that change.

@gandro and @cyclinder Given that this moves us to one of the recommended k8s labels, I'd also be pretty happy if we moved k8s-app to the recommended ones suggested above as well. I do not think we should remove the k8s-app label just yet, but migrate away from it and towards the set of recommended lables. How do you both feel about this?

Thanks for the review! I totally agree.
We shouldn't remove k8s-app right now (maybe we should still keep it), but at least we should tag all cilium resources with app.kubernetes.io/name   or  app.kubernetes.io/component according to recommended" labels, just like k8s-app.

Is there a reason those might be excluded?

Since I see no labels for these resources at the moment

On whether or not to deprecate the k8s-app labels: While I'm not against removing them, I believe cilium sysdump is currently relying on them.
So if we decide to remove them, then we need to figure out a migration strategy for cilium sysdump that works with both old and new versions of Cilium.

@gandro and @cyclinder I do agree. We do not want to deprecate k8s-app until we can safely do so, especially with its usage in cilium sysdump. That being said, we can add the recommended labels like mentioned above. There is a bit of value add here. Right now I have a kind cluster and I see that the 'agent' pods use k8s-app=cilium while the operators do not.
Ideally, we can do something like:
app.kubernetes.io/part-of: cilium
app.kubernetes.io/name: cilium-agent

app.kubernetes.io/part-of: cilium
app.kubernetes.io/name: cilium-operator

Tho, I'm not sure if s/name/component or not?

Update:

Label all Cilium resources with app.kubernetes.io/part-of: cilium (But not including configMap,RBAC.etc, Since these resources do not have any label), The meaning of app.kubernetes.io/part-of is just to label which resources belong to cilium, and not be used for selector and matchLabels.
The label of  app.kubernetes.io/name can be equal to k8s-app, which is used to label different components in cilium, and which also used for selector and matchLabels, Just like k8s-app do.  In addition to, I used app.kubernetes.io/name instead of name .

@ldelossa @gandro

@gandro and @cyclinder I do agree. We do not want to deprecate k8s-app until we can safely do so, especially with its usage in cilium sysdump. That being said, we can add the recommended labels like mentioned above. There is a bit of value add here. Right now I have a kind cluster and I see that the 'agent' pods use k8s-app=cilium while the operators do not.
Ideally, we can do something like:
app.kubernetes.io/part-of: cilium
app.kubernetes.io/name: cilium-agent

app.kubernetes.io/part-of: cilium
app.kubernetes.io/name: cilium-operator

Tho, I'm not sure if s/name/component or not?

I like this proposal. I'm happy with name.
@cyclinder Would you be willing to change this PR to reflect that?

Changes lgtm, I am still a bit concerned over changing the immutable matchLabels. For example, if I try to do a helm upgrade with this branch I get:
Error: UPGRADE FAILED: cannot patch "cilium" with kind DaemonSet: DaemonSet.apps "cilium" is invalid: [spec.template.metadata.labels: Invalid value: map[string]string{"app.kubernetes.io/name":"cilium", "app.kubernetes.io/part-of":"cilium-agent", "k8s-app":"cilium"}: `selector` does not match template `labels`, spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/name":"cilium-agent", "k8s-app":"cilium"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable] && cannot patch "cilium-operator" with kind Deployment: Deployment.apps "cilium-operator" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/name":"cilium-operator", "io.cilium/app":"operator"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

I'm sorry to not responding for a long time since I was busy with work these days.

@cyclinder Would you be willing to change this PR to reflect that?

Hi @gandro , If my understanding is right,  the current PR already reflects these changes, Right?

Changes lgtm, I am still a bit concerned over changing the immutable matchLabels. For example, if I try to do a helm upgrade with this branch I get:
Error: UPGRADE FAILED: cannot patch "cilium" with kind DaemonSet: DaemonSet.apps "cilium" is invalid: [spec.template.metadata.labels: Invalid value: map[string]string{"app.kubernetes.io/name":"cilium", "app.kubernetes.io/part-of":"cilium-agent", "k8s-app":"cilium"}: selectordoes not match templatelabels, spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/name":"cilium-agent", "k8s-app":"cilium"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable] && cannot patch "cilium-operator" with kind Deployment: Deployment.apps "cilium-operator" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/name":"cilium-operator", "io.cilium/app":"operator"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
Not sure what the best solution for this is, perhaps to have way to specify custom matchLabel selectors in values.yaml.

Thanks! Good catch!
I'll test it on my local machine, and find a best solution for this.

Update:
As before, I added two labels to each cilium resource, app.kubernetes.io/name and app.kubernetes.io/part-of, and only when UseNewMatchLabel= true, then app.kubernetes.io/name  is one of the matchLabel.
We set the default value of UseNewMatchLabel to true in values.yaml , and we expect that when cilium is installed,  app.kubernetes.io/namewill be one of the matchLabel.  We may failed when updating chart because matchLabel is immutable, so we need to update it by --set UseNewMatchLabel=false.

Hi @gandro , If my understanding is right, the current PR already reflects these changes, Right?

Yes, I think I missed that. The labels used in the current version look good the me.

/kind feature
/area helm

So I confirmed: Adding labels to the following components will break the well-known identities feature: https://docs.cilium.io/en/v1.11/concepts/terminology/#well-known-identities
If we add these new labels to cilium-operator, etcd-operator, cilium-etcd, we also have to update the label set used to determine those identities. In other words, we will have to add a third label selector with the new labels to each of the affected identities here (similar to how it was done in https://github.com/cilium/cilium/pull/16585):
https://github.com/cilium/cilium/blob/19bda871b0fdaca7014be2988c45f4e2972bea02/pkg/identity/numericidentity.go#L183

Thanks for your patient reply！I checked this part of the source code, and as you said, there are four places should to update the identities : cilium-operator, etcd-operator, cilium-etcd, and cilium-etcd-operator.
But only cilium-operator and cilium-etcd-operator correspond to the above in PR, it seems that etcd-operator, and cilium-etcd, we do not need to update?

So I confirmed: Adding any new label to the following components will break the well-known identities feature: https://docs.cilium.io/en/v1.9/concepts/terminology/#well-known-identities
If we add these new labels to cilium-operator, etcd-operator, cilium-etcd, and cilium-etcd-operator, we will also have to update the label set used to determine those identities. In other words, we will have to add a third label selector with the new labels to each of the affected identities here (similar to how it was done in #16585):
https://github.com/cilium/cilium/blob/19bda871b0fdaca7014be2988c45f4e2972bea02/pkg/identity/numericidentity.go#L183

Thanks for your patience! I checked this part of the source code, and as you said, there are cilium-operator, etcd-operator, cilium-etcd, and cilium-etcd-operator where we need to update the identities.
But only cilium-operator and cilium-etcd-operator correspond to the above in PR, it seems that etcd-operator and cilium-etcd, we do not need to update?

But only cilium-operator and cilium-etcd-operator correspond to the above in PR, it seems that etcd-operator and cilium-etcd, we do not need to update?

Yes, I think you are correct. The other ones are deprecated (their deployment manifest is here) and therefore not changed by this PR.

/test

@cyclinder It seems like your signed-off-by line in the commit is not properly formatted. From the checkpatch CI (here):
  Error: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'cyclinder<EMAIL_ADDRESS>  #7:
  Signed-off-by: cyclinder<EMAIL_ADDRESS>
  Error: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'cyclinder<EMAIL_ADDRESS>
It's missing the < and > around your email address. You can add this via git CLI by using git commit --amend -s

@gandro Thank you very much for your help!

I have no idea about this CI failed(gke-stable). Can this CI job be retested?

/test-gke

Thanks, Does this PR require a review?  This is my first contribution to cilium :) , Can you tell me about the requirements for PR merged?

I prefer to have another code review from the policy CODEOWNERs (e.g. Chris), to ensure the well-known identity change is valid.


Trying to access Postgres service from docker image

I'm trying to connect to Postgres db from within my Docker image to run tests:
  test_backend:
    runs-on:
      group: ubuntu-large
    needs: build_backend

    # Service containers to run with `container-job`
    services:
      # Label used to access the service container
      postgres:
        # Docker Hub image
        image: postgres
        # Provide the password for postgres
        env:
          POSTGRES_PASSWORD: postgres
        # Set health checks to wait until postgres has started
        options: >-
          --health-cmd pg_isready
          --health-interval 10s
          --health-timeout 5s
          --health-retries 5
        ports:
          # Maps tcp port 5432 on service container to the host
          - 5432:5432

    steps:
    - name: Run tests in container
      uses: addnab/docker-run-action@v3
      with:
        image: backend-py:${{github.sha}}
        run: ./manage.py test --noinput
        options: --env-file .github/workflows/env.test

There is a script, that tries to connect to Postgres running as a service. However I can't figure out, how to set the correct network/host value. I've tried to set in env.test:
DATABASE_URL=postgres://${POSTGRES_USER}:${POSTGRES_PASSWORD}@${INPUT_DOCKER_NETWORK}:5432/${POSTGRES_DB}

Which gives me error:
django.db.utils.OperationalError: could not translate host name "${input_docker_network}" to address: Name or service not known

How should I specify the host name to successfully connect to Postgres GitHub service?

If you haven't figured it out, or for others who come across this, the hostname here would just be postgres, no other fancy docker networking necessary.


Question: Can I run 'ionic serve' as linux service?'

Hello!
Is it possible to start ionic serve as deamon? I would like to deploy on server and want the service to stay up even when I disconnect fssh session.
Cheers

Greetings @dejancencelj!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Update build.gradle script in README

Multiple changes to README.md:

remove arcgis java plugin for Gradle
replace apply plugin lines with the plugins {} block
remove buildscript block
replace arcgis.version = 100.2.1 with an ext property named arcgisVersion
add comment about ability to replace 100.2.1 with latest Runtime version
add compileJava.options.encoding = 'UTF-8'
in dependencies block replace compile with implementation
in dependencies block add the arcgis-java dependency to the `implementation' configuration
fix link to Install the SDK page in Java guide on developers.arcgis.com
update Requirements table for SDK Version from 100.2.1 to 100.2.1 and later

Related issue

https://github.com/ArcGIS/afd-native-apis-doc/issues/575

@mbcoder Please review this. Or find a Gradle expert to review it.
I believe I made the correct edits, but we need to check with those who know for sure.

@mbcoder What about the changes I made to the build script itself? Are those ok?
https://github.com/Esri/arcgis-runtime-toolkit-java/pull/40/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R17

@mbcoder I added support for jnilibs and resources to compensate for our removal of the Esri java plugin for Gradle.
I have some unanswered questions:

I left our the line group = 'com.esri.samples' . I don't that applies. If we need a group for this README, please indicate what the value should be.

I included the reference to the olympus artifactory, but not clear whether that url is accessible to our customers. It's used in the build scripts in the samples repo, so it's probably ok. But thought I should verify with you.

I omitted the definition of Gradle tasks, starting at createGradlePropertiesAndWriteApiKey  . That includes run and jar. Let me know if you want those in, and if so, which ones.

I omitted the gradle wrapper stuff. Is that ok?

@markjdugger answers to your questions:

I omitted the line group = 'com.esri.samples' . I don't think that applies. If we need a group for this README, please indicate what the value should be. MB: Yes that's fine.

I included the reference to the olympus artifactory, but I'm not clear whether that url is accessible to our customers. It's used in the build scripts in the samples repo, so it's probably ok. But thought I should verify with you.  MB: Can. you remove it.  I've commented in the pull request about why

I omitted the definition of Gradle tasks, starting at createGradlePropertiesAndWriteApiKey . That includes run and jar. Let me know if you want those in, and if so, which ones.  MB: Yes that's fine

I omitted the gradle wrapper {} block. Is that ok?  MB: Yes that's fine

I removed the reference to the Maven artifactory repo on Olympus.
Please review and approve

@mbcoder Please review and approve, if you approve.


canon defense added

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #1085

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @S-ishita ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@S-ishita Resolve conflicts

Hey @S-ishita,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @S-ishita , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Docker container for artifactory-pro has two copies of artifactory

I realize you are probably building the docker image from an artifactory "source" directory, but currently your docker images are inefficient due to the:
# Copy the artifactory zip and entrypoint files
COPY standalone.zip /opt/jfrog/

... line. That file is later unzip'd and removed, but because it was copied in, the file is still part of the image. You could probably optimize that by "downloading" the zip file, then unzipping and removing it all in one "layer" (in one RUN command).
Another option might be "squashing" ? http://jasonwilder.com/blog/2014/08/19/squashing-docker-images/
I realize that the image is excessively bloated in other areas, right now, but I really notice this one as each new version of artifactory comes out I have to download it twice.
Tommy

A tool that we have been using lately on our docker images is "dive"
https://github.com/wagoodman/dive
$ CI=true dive docker.bintray.io/jfrog/artifactory-pro:6.9.0
Fetching image... (this can take a while with large images)
Parsing image...
Analyzing image...
  efficiency: 79.0840 %
  wastedBytes: 254108946 bytes (254 MB)
  userWastedPercent: 23.4734 %
Run CI Validations...
  Using default CI config
  FAIL: highestUserWastedPercent: too many bytes wasted, relative to the user bytes added (%-user-wasted-bytes=0.23473385927040877 > threshold=0.1)
  SKIP: highestWastedBytes: rule disabled
  FAIL: lowestEfficiency: image efficiency is too low (efficiency=0.7908404361184976 < threshold=0.9)
Result:FAIL [Total:3] [Passed:0] [Failed:2] [Warn:0] [Skipped:1]

@TJM - we are aware of this and have plans to improve this in the future.
BTW - I also love the dive tool. Very useful!

So, if you build the Docker image outside of the application build, you can just download it directly from the release repo. This was the "solution" I used when I was working around #129 .
As I mentioned in that issue, the best solution (in my opinion) is probably to create a .tar.gz instead of or in addition to the .zip during the build. That way you can use "ADD" instead of "COPY" and just skip the unzip step all together, and not end up with two copies of the application in the Docker image. You could choose whether or not to distribute the .tar.gz publicly, but its probably not useful for much more than building the docker image. (shrug)
~tommy

7.x does not have this issue I guess. With that I am closing this, as this repo is under deprecation.

  Using default CI config
Image Source: docker://docker.jfrog.io/jfrog/artifactory-pro:7.x.feature.INST.151-10
Fetching image... (this can take a while for large images)
Analyzing image...
  efficiency: 99.9975 %
  wastedBytes: 44859 bytes (45 kB)
  userWastedPercent: 0.0051 %
Inefficient Files:
Count  Wasted Space  File Path
    2         31 kB  /var/opt/jfrog/artifactory/etc/system.full-template.yaml
    2        8.8 kB  /entrypoint-artifactory.sh
    2        4.3 kB  /var/opt/jfrog/artifactory/etc/system.basic-template.yaml
    2         121 B  /etc/passwd
    2         116 B  /var/opt/jfrog/artifactory/etc/access/keys/trusted/README.md
    2          68 B  /var/opt/jfrog/artifactory/etc/access/keys/README.md
    2          66 B  /var/opt/jfrog/artifactory/etc/security/README.md
    2          60 B  /var/opt/jfrog/artifactory/bootstrap/README.md
    2          44 B  /var/opt/jfrog/artifactory/bootstrap/artifactory/tomcat/lib/README.md
    2          40 B  /etc/group
    2          40 B  /var/opt/jfrog/artifactory/etc/README.md
    2          38 B  /var/opt/jfrog/artifactory/etc/artifactory/plugins/README.md
    2           0 B  /usr/share/info
    2           0 B  /root
Results:
  PASS: highestUserWastedPercent
  SKIP: highestWastedBytes: rule disabled
  PASS: lowestEfficiency
Result:PASS [Total:3] [Passed:2] [Failed:0] [Warn:0] [Skipped:1]```

Thanks for fixing that :)


Github extension activation spam on first run

Run code-insiders with a clean user-data-dir and extensions-dir
Be greeted with notification spam about the Github extension

Duplicates https://github.com/microsoft/vscode/issues/125395


Implement new html minify transform based on @swc/html

This adds a new unified transformer to minify HTML, based on @swc/html, which is implemented in Rust. The configuration produces output that is very similar to what html-minifier (which is currently used) produces. Potentially breaking minifications (like removing all whitespace instead of smart or omitting tags) are disabled.
Using this on DCC brings down build times by around 45%. Tested on an M1 Pro, we are coming from 330.24s (80.1ms/page) down to 180.36s (43.7ms/page).

Added a minifyHtml filter for John to use in https://github.com/GoogleChrome/developer.chrome.com/pull/4196. Additionally added a force config option to both transformers to overwrite the isTransformable util that would otherwise prevent transforming the output generated by the CMS render pipeline.


fix typo

Thanks for spotting the typo, but the "reporter.html" file is automatically generated by scripts/build-site.py, so the problem must be elsewhere...

I fixed it, it was in the description of notofonts/znamenny. Will be updated next time the script runs. (nightly)

Sorry, I did not realize it is built dynamically.
There is another PR in notofonts/znamenny that addresses the same typo in other files but maybe this will also be fixed with your changes.


Fix modifying workspace distance rate with an old data doesn't show an error

Details

If we update the distance rate with an old lastModifiedData, the update shouldn't be success and an error should be shown.
Fixed Issues

$ https://github.com/Expensify/App/issues/29853
PROPOSAL: https://github.com/Expensify/App/issues/29853#issuecomment-1840057141
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: have a workspace

Login with the same account on 2 devices
Go to Settings > Workspaces > Select any workspace > Reimbursement > Open the distance rate
On the first device, turn off the internet connection and change the distance rate to any number
On the second device, change the distance rate to any number
On the first device, turn on the internet connection
Verify the distance rate value shows the new value we enter in step 4
Verify there is a red dot error and message in the distance rate page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/08345971-2f7e-42f8-93e9-159b633d32fe

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/cdfdc499-514a-49e9-a481-a4c7d8e06432

iOS: Native

https://github.com/Expensify/App/assets/50919443/7728f774-8946-40aa-a77e-920c9dd68bea

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/dc7fb6a1-b08d-4a12-88de-291ec1f558a2

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/c166d3b3-87d4-4c5a-813f-6556ab280dca

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/5e34c2eb-1ca8-4570-8223-25add1e63e0d

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat: library target UMD supports names per target

What kind of change does this PR introduce?

feature
Did you add tests for your changes?

Yes, I updated the tests for LibraryTemplatePlugin. There didn't seem to be any for UmdMainTemplatePlugin yet - not sure if that's intentional, but if not, I could look into adding.
If relevant, link to documentation update:

I'll take the time to add documentation after getting approval for this feature.
Summary

Currently, the output.libraryTarget of 'umd' only supports a single name (output.library), whereas the user may instead wish to specify a different name for each target type (CommonJS, AMD, and global), e.g., to use kebab-case for AMD but camelCase for global and CommonJS.
Does this PR introduce a breaking change?

No.
Other information
Feel free to ask.

Could you sign the CLA, so we can merge it?

@sokra CLA has been signed.

@sokra Thanks for merging.


Move blocky to kube-system namespace

Feel it's more suited here than over the default ns

Default is actually fine, closing


Release 6.3.0

Changes since 6.2.6
🚀 Features

Improve UX for shell env sync failure (#6644) https://github.com/Nokel81
Add buttons to quicky filter the current view by a specific namespace (#6677) https://github.com/Nokel81
Include bundled extensions in package.json (#6715) https://github.com/jakolehm
Refactor kube detail components and add KubeEvents automatically to all custom resources (#6468) https://github.com/Nokel81

🐛 Bug Fixes

Handle globalAgent having a single non-array CA (#6628) https://github.com/Nokel81
Fix back navigation in entity settings (#6670) https://github.com/Nokel81
Fix not displaying any pie charts when missing only some data (#6671) https://github.com/Nokel81
Fix typing of ExtensionStore.createInstance static (#6764) https://github.com/Nokel81
Fix queries for operator provider metrics (#6679) https://github.com/Nokel81
Fix resize anchor z-index (#6784) https://github.com/aleksfront
Prevent shell sync commands from polluting history (#6668) https://github.com/Nokel81
Fix allowed resources checks on GKE  (#6657) https://github.com/Nokel81
Split out use of httpsProxy preference (#6771) https://github.com/Nokel81

🧰 Maintenance

Remove spdy support  (#6580) https://github.com/Nokel81
Bump @swc/core from 1.3.14 to 1.3.18 (#6609) https://github.com/dependabot
Bump mini-css-extract-plugin from 2.6.1 to 2.7.0 (#6607) https://github.com/dependabot
Bump css-loader from 6.7.1 to 6.7.2 (#6608) https://github.com/dependabot
Bump typescript from 4.8.4 to 4.9.3 (#6606) https://github.com/dependabot
Bump concurrently from 7.5.0 to 7.6.0 (#6618) https://github.com/dependabot
Bump marked from 4.2.2 to 4.2.3 (#6617) https://github.com/dependabot
Bump eslint from 8.27.0 to 8.28.0 (#6616) https://github.com/dependabot
Bump @swc/core from 1.3.18 to 1.3.19 (#6615) https://github.com/dependabot
Make ClusterFrameManager fully injectable (#6590) https://github.com/Nokel81
Bump eslint-plugin-react from 7.31.10 to 7.31.11 (#6624) https://github.com/dependabot
Bump esbuild from 0.15.14 to 0.15.15 (#6621) https://github.com/dependabot
Bump @typescript-eslint/eslint-plugin from 5.43.0 to 5.44.0 (#6623) https://github.com/dependabot
Bump @typescript-eslint/parser from 5.43.0 to 5.44.0 (#6622) https://github.com/dependabot
Make systems CAs platform-independent using injectables (#6321) https://github.com/Nokel81
Add eslint support for package.json exports (#6639) https://github.com/jansav
Make ResourceStack fully injectable  (#6591) https://github.com/Nokel81
Bump playwright from 1.28.0 to 1.28.1 (#6636) https://github.com/dependabot
Bump @types/lodash from 4.14.189 to 4.14.190 (#6638) https://github.com/dependabot
Bump @pmmmwh/react-refresh-webpack-plugin from 0.5.9 to 0.5.10 (#6646) https://github.com/dependabot
Make PrometheusProviderRegistry fully injectable (#6592) https://github.com/Nokel81
Bump @swc/core from 1.3.19 to 1.3.20 (#6656) https://github.com/dependabot
Bump esbuild from 0.15.15 to 0.15.16 (#6655) https://github.com/dependabot
Make EntitySettingRegistry fully injectable (#6604) https://github.com/Nokel81
Remove uses of legacy global logger from injectables (#6660) https://github.com/Nokel81
Bump @types/randomcolor from 0.5.6 to 0.5.7 (#6661) https://github.com/dependabot
Bump @typescript-eslint/parser from 5.44.0 to 5.45.0 (#6662) https://github.com/dependabot
Bump @typescript-eslint/eslint-plugin from 5.44.0 to 5.45.0 (#6663) https://github.com/dependabot
Bump mini-css-extract-plugin from 2.7.0 to 2.7.1 (#6673) https://github.com/dependabot
Bump @types/node from 16.18.3 to 16.18.4 (#6683) https://github.com/dependabot
Add milestone automatically to release PRs (#6681) https://github.com/Nokel81
Bump ts-loader from 9.4.1 to 9.4.2 (#6684) https://github.com/dependabot
Bump @types/lodash from 4.14.190 to 4.14.191 (#6685) https://github.com/dependabot
Bump query-string from 7.1.1 to 7.1.2 (#6694) https://github.com/dependabot
Bump @swc/core from 1.3.20 to 1.3.21 (#6695) https://github.com/dependabot
Bump react-select from 5.6.1 to 5.7.0 (#6696) https://github.com/dependabot
Replace CatalogEntityDetailRegistry with an injectable solution (#6605) https://github.com/Nokel81
Bump query-string from 7.1.2 to 7.1.3 (#6701) https://github.com/dependabot
Bump eslint from 8.28.0 to 8.29.0 (#6700) https://github.com/dependabot
Bump esbuild from 0.15.16 to 0.15.17 (#6699) https://github.com/dependabot
Bump @types/node from 16.18.4 to 16.18.6 (#6704) https://github.com/dependabot
Bump esbuild from 0.15.17 to 0.15.18 (#6702) https://github.com/dependabot
Bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser from 5.45.0 to 5.45.1 (#6705) https://github.com/dependabot
Bump typescript from 4.9.3 to 4.9.4 (#6714) https://github.com/dependabot
Bump tar from 6.1.12 to 6.1.13 (#6712) https://github.com/dependabot
Bump mini-css-extract-plugin from 2.7.1 to 2.7.2 (#6709) https://github.com/dependabot
Bump esbuild from 0.15.18 to 0.16.3 (#6718) https://github.com/dependabot
Remove named exports from CSS module typings (#6723) https://github.com/Nokel81
Unify build fs layout (#6717) https://github.com/jakolehm
Bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser from 5.45.1 to 5.46.0 (#6731) https://github.com/dependabot
Bump @swc/jest from 0.2.23 to 0.2.24 (#6729) https://github.com/dependabot
Simplify Error.cause logging (#6669) https://github.com/Nokel81
Bump @swc/core from 1.3.21 to 1.3.22 (#6735) https://github.com/dependabot
Bump typedoc from 0.23.21 to 0.23.22 (#6736) https://github.com/dependabot
Bump @types/react-beautiful-dnd from 13.1.2 to 13.1.3 (#6737) https://github.com/dependabot
Using custom properties for z-index values (#6733) https://github.com/aleksfront
Bump esbuild from 0.16.3 to 0.16.5 (#6747) https://github.com/dependabot
Bump @types/node from 16.18.6 to 16.18.9 (#6746) https://github.com/dependabot
Bump @typescript-eslint/parser from 5.46.0 to 5.46.1 (#6745) https://github.com/dependabot
Bump @typescript-eslint/eslint-plugin from 5.46.0 to 5.46.1 (#6744) https://github.com/dependabot
Bump marked and @types/marked (#6753) https://github.com/dependabot
Bump esbuild from 0.16.5 to 0.16.7 (#6755) https://github.com/dependabot
Bump @swc/core from 1.3.22 to 1.3.23 (#6754) https://github.com/dependabot
Bump css-loader from 6.7.2 to 6.7.3 (#6752) https://github.com/dependabot
Make base store non Singleton (#6690) https://github.com/Nokel81
Bump rfc6902 from 4.0.2 to 5.0.0 (#6765) https://github.com/dependabot
Bump moment-timezone from 0.5.39 to 0.5.40 (#6767) https://github.com/dependabot
Bump got from 11.8.5 to 11.8.6 (#6768) https://github.com/dependabot
Bump rfc6902 from 5.0.0 to 5.0.1 (#6766) https://github.com/dependabot
Bump @kubernetes/client-node from 0.17.1 to 0.18.0 (#6769) https://github.com/dependabot
Make apiBase not an InjectionToken and make openNodeShellSession not special (#6774) https://github.com/Nokel81
Bump eslint from 8.29.0 to 8.30.0 (#6776) https://github.com/dependabot
Bump sass from 1.56.1 to 1.57.0 (#6777) https://github.com/dependabot
Bump esbuild from 0.16.7 to 0.16.9 (#6778) https://github.com/dependabot
Bump playwright from 1.28.1 to 1.29.0 (#6779) https://github.com/dependabot
Bump @types/node from 16.18.9 to 16.18.10 (#6791) https://github.com/dependabot
Remove in-tree extensions to help facilitate a more secure and faster booting lens (#6775) https://github.com/Nokel81
Bump esbuild from 0.16.9 to 0.16.10 (#6790) https://github.com/dependabot
Bump sass from 1.57.0 to 1.57.1 (#6793) https://github.com/dependabot
Bump typedoc from 0.23.22 to 0.23.23 (#6792) https://github.com/dependabot
Navigation logging injectable (#6797) https://github.com/samitiilikainen
Fix broken import after PR merge (#6803) https://github.com/Nokel81

https://github.com/lensapp/lens/pull/6775 should not be considered maintenance, but deprecation. Features are being removed.


Add html view of the result

We now create a markdown variable at our code.
We have to also create an html one.

We need to have this yesterday, so that we can start marketing the product.


[WIP] Add a (b)ack option to 'Is this a valid secret?' Closes Issue #63

[Work In Progress]
Add going backwards option to 'Is this a valid secret?', closing Issue #63
This would be my first contribution to open source ever - thank you for the "good first issue" flag!
I have not yet figured out how to run the tests properly, else I would try to be test-driven.
The two directions I could see this go in are currently (preferences welcome):

(the "obvious" one) Make _secret_generator in core/audit.py a list instead of a generator and handle indices in audit_baseline
Cast _secret_generator to a "bidirectional iterator" object (still goes through list). That adds some overhead, but keeps the for ... in _secret_generator of audit_baseline and might make audit.py more readable.

This would be my first contribution to open source ever

That's really awesome :D   🎈 🍰 🎉
I'll get back to you on Tuesday or Wednesday with possible implementation preferences.

Bidirectional iterator looks good! Looking forward to tests!

Is there an assumption that secrets in the results of the baseline are in a fixed order? (I mean the lists baseline['results'][filename]')  If not I would re-write merge_resultsinbaseline.pyto remove this assumption so that it works with updates to the baseline that are out-of-order. That would simplify some choices inaudit_baselineofaudit.py` a lot :)

@cleborys: currently, no there isn't. It's a Python dictionary for O(1) access by filename (and because the JSON dump is human readable), but that means key iteration cannot be depended on for order.
It's a good point though -- and would simplify testing and other logic. Maybe you would like to work on it as a next PR? =D If we sort the keys before iterating through it, that should fix stuff.

@domanchi Sorry, I am a bit confused :sweat_smile:
I meant the list that is stored under the filename key and contains the secrets in that file. The merge_results function assumes that updates to that list are in order so that it is easier to update, but that now means I have some problems when stepping back on choices in the audit:
Currently the audit iterates over all secrets and automatically skips these that already had the is_secret flag set. But that means that when I skip back one secret after I previously chose y or n, it will be automatically skipped again, hence the back option currently only works correctly when the last option chosen was skip.
Instead I would like to change the loop to only iterate over secrets without the is_secret flag set and then append all previously known secrets that had there flag set already. But that would shuffle the list of secrets (the lists that are stored by filename) and I'm not sure if it is ok to shuffle this (after removing the "order" assumption of merge_results.
I am not completely confident that that would work as stated, because simply removing the "has is_secret-flag already set, then skip"-condition seems to produce lots of identical secrets to be shown, so there seems to be an extra effect that I don#t understand yet :wink:

@KevinHock  Thanks :) But it is not yet functional! Only the framework with the new iterator works yet, so don't merge :wink:
(I don't really know the etiquette yet - I made a pull request already so that you can see whats happening, but I wouldn't remove the [WIP] tag in the title until it is functional and I think I'm done. So I hope your approval doesn't mean that you intend to merge)

@cleborys, ah, I understand you better now.
Yes, the secrets in the list are ordered. One benefit of this is comparing side by side diffs of baselines - and it's very easy to see the changes between iterations. You can quite easily see whether a secret has been removed, added, or appropriately labelled. By reordering the contents, it becomes that much harder to see differences, if applicable.
For example, if you start the audit process with pre-existing audited secrets, but not perform any additional labelling, you would expect no changes to the baseline.
If the goal is to allow the back option to iterate over previously labelled secrets, perhaps you can just append that to the if statement?
e.g. something like
if 'is_secret' not in secret or decision == 'b':
    blah

@domanchi Cool, I will not mess around with the order then :sweat_smile:
Yes, I will try something like this. it is not completely straightforward, because you don't want to have the user step back into secrets that were previously autoskipped and that he is not aware of.
I think I will split the list into secrets shown to the user and secrets not shown before the loop and then interlace them in the correct order after the loop, again :)

It seems I had forgotten how Python works ("everything is a pointer") and in the end the necessary changes were much easier.
The user decision loop now only loops over secrets which don't have the is_secret flag set and decisions modify them in-place. So the order is kept and there is no need to backtrack changes when they are overridden. The results dict by filename is constructed after the user is done and then merged.
I expect that everything works as it should now, but I'll add some tests to make sure :smile:

Tests written and passing, some manual sanity checks also successful! :tada: :balloon:
Thanks, guys! Ready for final review.


Add ability to rollover content blocks

fixes #41

@lumoe I've updated the PR to the latest master version. It only contains the solution to #41 without any other changes.

closed in favor of https://github.com/lumoe/obsidian-rollover-daily-todos/pull/79


Animation run only one time when applied in TabViewController's child viewcontrollers via Storyboard?

I set the views with Spring animation via Storyboard which the ViewController is in the TabViewContoller, but I switch between different viewControllers, the animation commit only once when first time switch to it. Anyone no why? Pleas help me out!

do it in code, check closed issues and you'll find couple of answers similar to yours.

Ok, thanks too much pal. I'll check it.


Add a Gitter chat badge to README.md

NSLS-II/metadatastore now has a Chat Room on Gitter
@ericdill has just created a chat room. You can visit it here: https://gitter.im/NSLS-II/metadatastore.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

putting this in #150


Update deps

the ol' update

Major changes

Updated Python dependencies
Updated Node dependencies (keeping React at 18, Next at 14 and not focussing on CSS-related libraries because of pending tailwindification)
Replaced eslint and stylelint with Biome (with rules disabled that were triggering errors, pending later PR)
Removed next-pwa

Minor changes

Replace isNAN with Number.isNAN
Renamed useTranslation to getTranslation
Fixed percentToString to not return NaN
Increased navigation selector weight to fix css ordering bug


Can't update RealmSwift with CocoaPods

Cocoapods fails trying to install RealmSwift  10.5.2 when using pod update. It appears to be looking for RLMAccessor.h in the wrong directory.
Goals
Update to the latest RealmSwift and be able to build again in Xcode
Expected Results
Update to the RealmSwift 10.5.2  and be able to build again in Xcode
Actual Results
Here is the output from Terminal
Stack
   CocoaPods : 1.10.1
        Ruby : ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin20]
    RubyGems : 3.0.3
        Host : macOS 11.2.1 (20D74)
       Xcode : 12.4 (12D4e)
         Git : git version 2.24.3 (Apple Git-128)
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib
Repositories : trunk - CDN - https://cdn.cocoapods.org/

Plugins
cocoapods-deintegrate : 1.0.4
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.1.0
cocoapods-trunk       : 1.4.1
cocoapods-try         : 1.1.0

Podfile
# Uncomment the next line to define a global platform for your project
platform :ios, '12.4'

target 'Takedown' do
  # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for Takedown
    pod 'Firebase'
    pod 'Firebase/Core'
    pod 'Firebase/Messaging'
    pod 'Firebase/Auth'
    pod 'Firebase/Functions'
    pod 'Firebase/Analytics'
    pod 'Firebase/Database'
    pod 'Firebase/Storage'
    pod 'Firebase/RemoteConfig'
    pod 'Firebase/Crashlytics'
    pod 'Firebase/InAppMessaging'
    pod 'Harpy'
    pod 'SDWebImage/Core'
    pod 'FirebaseUI/Storage'
    pod 'UIImageColors'
    pod 'MBProgressHUD'
    pod 'TTOpenInAppActivity'
    pod 'YoutubePlayer-in-WKWebView'
    pod 'GoogleAPIClientForREST/YouTube'
    pod 'GoogleSignIn'
    pod 'CorePlot'
    pod 'Realm', '=10.5.2'
    pod 'RealmSwift', '=10.5.2'
    pod 'TwitterKit5'
    pod 'Purchases', '3.10.3'

    post_install do |installer|
      installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
          config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
        end
      end
    end
end

Error
Errno::ENOENT - No such file or directory @ realpath_rec - /Users/9a/Documents/CodingProjects/Takedown3.x/Pods/Realm/Realm/RLMAccessor.h
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `realpath'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `realpath'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:326:in `reference_for_path'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/project.rb:269:in `add_file_reference'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:224:in `block (2 levels) in add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:223:in `each'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:223:in `block in add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:213:in `each'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:213:in `add_file_accessors_paths_to_pods_group'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:96:in `block in add_source_files_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:145:in `message'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:95:in `add_source_files_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator/file_references_installer.rb:46:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator.rb:102:in `block in install_file_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:145:in `message'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/pods_project_generator.rb:100:in `install_file_references'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer/xcode/single_pods_project_generator.rb:17:in `generate!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:312:in `block in create_and_save_projects'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:307:in `create_and_save_projects'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:299:in `generate_pods_project'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:178:in `integrate'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/installer.rb:166:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command/update.rb:63:in `run'
/Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.10.1/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Steps for others to Reproduce
Don't know if it can be reproduced
Code Sample
N.A.
Version of Realm and Tooling
ProductName:	macOS
ProductVersion:	11.2.1
BuildVersion:	20D74

/Applications/Xcode.app/Contents/Developer
Xcode 12.4
Build version 12D4e

/usr/local/bin/pod
1.10.1
Realm (10.5.1)
RealmSwift (10.5.1)
Realm (= 10.5.1)
RealmSwift (= 10.5.1)

/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)

carthage not found
(not in use here)

/usr/bin/git
git version 2.24.3 (Apple Git-128)

@levelchanger can you test doing a clean pod install, instead of using pod update. First run pod deintegrate and then instead of using the update command, run pod install --verbose. If you still get an error, can you paste the logs here? so we can continue to help you.

I built a project yesterday with 10.5.2 and it worked correctly. I also updated an existing project as well. I was using macOS 10.14.6 and then on a completely different Mac, used 10.15.
Your podfile has 'Realm' - remove that and try just RealmSwift
pod 'Realm', '=10.5.2'
pod 'RealmSwift', '=10.5.2'

Our pod just uses
pod 'RealmSwift', '>= 10.0.0'

@visdyn I have a mixed ObjC/Swift project so I need both SDKs.
@dianaafanador3 I followed your instructionss and here is the output
podoutput.txt

Is this the same issue as this https://github.com/realm/realm-cocoa/issues/6943

As mentioned by @visdyn, referring to issue #6943, can you please clean your pod cache?

@visdyn, @dianaafanador3  Yes, it is the same problem and removing the pod cache and Xcode derived data fixed everything. Thank you!


Unify & simplify model adapter integration

Note: Depends on #257

Background
Currently, we have a lot of redundant code in the model mixins of each model class integration (src/transformers/adapters/models).
Solution
This PR does a range of refactoring with the goal to unify and simplify adapter the adapter integrations into the currently supported models:

AdapterLayerBaseMixin has been converted to a torch module, AdapterLayer, with a proper forward() method. This makes the integration into most models cleaner (except for (Ro)BERT(a)/ T5) as they don't require specific module mixins anymore
The transformer now is expected to be passed to AdapterLayer instead of being a class attribute. This removes the need for a couple of model integration workarounds.
A lot of management code (train_adapter(), train_adapter_fusion(), add_adapter(), get_adapter() etc.) has been pulled up to ModelAdaptersMixin. All of these methods now are model-agnostic and have been removed from each model-specific mixin.
To enable the last point, a new abstract iter_layers() method has been introduced in ModelAdaptersMixin. In the best case (e.g. DistilBERT), this is the only method that has to be implemented by each model mixin.
A new mechanism to call methods on each AdapterLayer has been added (ModelAdaptersMixin.apply_to_adapter_layers()). This means a base model mixin can directly call AdapterLayer methods. All intermediate add_adapter(), enable_adapters() etc. methods in each model layer are not necessary anymore.
As a consequence of the last points, all module mixins between the module holding AdapterLayer and the base model mixin have been removed (e.g. BertEncoderAdaptersMixin).
All tensor adjustments for parallel adapter composition now use adjust_tensors_for_parallel() in composition.py.

Breaking changes

The return of get_adapter() has changed.

This PR/issue depends on:

Adapter-Hub/adapter-transformers#257

Automatically provided by Dependent Issues (🤖).


How to save media messages to physical files we can play?

Hi friends! I need to save media messages to physical files I can play outside the projects. Example: Image, Audio, Video...
When I do: data, err := message.Download() I can't see a file with the final file...
PD: I know others languages but I'm novice in Go :(
Thanks!

if it's on linux, the download will be in / tmp

Pretty thanks it worked perfect! :)


Code documentation

Provide code level documentation. Use pydoc or similar to generate documentation site. We are looking for 80% or greater code documentation level. The code to generate the documentation site should integrate into the continuous integration pipeline.

It looks like ontospy can generate HTML documentation of ontologies!
http://lambdamusic.github.io/Ontospy/#generating-ontology-documentation


Restructure FFI

Hi,
In this pull request, I've restructured the FFI crate and moved common bindings to the crates/ffi-types crate.
We plan to export SSPI and WinSCard functions from the one dll. So, I moved all SSPI-related bindings to the sspi module and placed the winscard functions definitions into the winscard module.
Also, I placed all winscard-related typings into a ffi-types crate. It'll help keep our code cleaner and reuse them when needed. Ideally, I think we should do the same with sspi: move sspi-related typing to this crate too.
Most of the changes are just typings. So, don't be afraid of this big number 😅
Docs & references:

winscard.h

Finally, the CI is green

Thank you! This time I’ll squash because there are intermediate commits which don’t pass the CI, so it’s not convenient for bisecting.


fix(accordionitem): restore original defaults, opt-in deferred content rendering

Closes #1104
Summary

Restores the original functionality to the AccordionItem that was inadvertently removed in #940, while preserving the option to defer rendering of AccordionItem content to on expand of the section.
Adds additional logic to preserve the content when a section is opened, and then closed again. (previously closing would remove the content, a perf issue)

Change List (commits, features, bugs, etc)

Restore original AccordionItem export from Carbon
Add AccordionItemDefer, can be composed as a normal AccordionItem within Accordion
regen welcome story (exports table in the accordion was empty! This is what triggered the bug report)

Acceptance Test (how to verify the PR)

see the new AccordionItemDefer story - you can see the content not rendered to the DOM initially, but then rendered when you expand the section.

Yeah, this is a tricky spot - the original PR overwrote default functionality. It wasn't "opt-in" as we've discussed we're aiming for all new features to be. So it feels to me that the original change #940 introduced a bug. The default behavior from Carbon isn't available at all since the AccordionItem was overwritten. So my changes here fix the bug, restoring the original behavior. Additionally, it provides a new way to achieve the deferred rendering of content.
In practice this will mean that if your app requires the use of deferred content rendering in Accordions, you will need to update those usages/imports of AccordionItem to AccordionItemDefer.
I know this isn't ideal, but it seems appropriate in principle. The alternative would've had us exposing default carbon functionality through a different/new component. That feels backwards and potentially confusing for contributors and consumers.
On the dashboard sizing issue - I don't think the original PR, #940, did anything to fix the dashboard sizing issue #939? I haven't made any changes to styling for any component.

No, this fixed it... for Health because the accordion item by default
renders all content and just "hides" it.  That in itself seems wrong.  But
they do the same thing for tabs,etc, so they are consistently bad at it.
When a dashboard is renderinged in the accordion item and hidden then it
does not get rendered correctly.  In fact, we've seen several issues
related to content in the accordion item.
At least I'm aware they are broken.  When they ask, why, I'll know what to
say ;)
Sean.
On Tue, Apr 21, 2020 at 6:10 PM Taylor Jones<EMAIL_ADDRESS>wrote:

Yeah, this is a tricky spot - the original PR overwrote default
functionality. It wasn't "opt-in" as we've discussed we're aiming for all
new features to be. So it feels to me that the original change #940
https://github.com/IBM/carbon-addons-iot-react/pull/940 introduced a
bug. The default behavior from Carbon isn't available at all since the
AccordionItem was overwritten. So my changes here fix the bug, restoring
the original behavior. Additionally, it provides a new way to achieve the
deferred rendering of content.
In practice this will mean that if your app requires the use of deferred
content rendering in Accordions, you will need to update those
usages/imports of AccordionItem to AccordionItemDefer.
I know this isn't ideal, but it seems appropriate in principle. The
alternative would've had us exposing default carbon functionality through a
different/new component. That feels backwards and potentially confusing for
contributors and consumers.
On the dashboard sizing issue - I don't think the original PR, #940
https://github.com/IBM/carbon-addons-iot-react/pull/940, did anything
to fix the dashboard sizing issue #939
https://github.com/IBM/carbon-addons-iot-react/issues/939? I haven't
made any changes to styling for any component.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/IBM/carbon-addons-iot-react/pull/1105#issuecomment-617440022,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIB6KMYUDCO2RZHICPGVMDRNYKWBANCNFSM4MMZ2DCQ
.

btw, since we wrap every component before exposing it, this isn't a big
deal for us, and it's the reason why we don't expose carbon or iot
components downstream.  I just have to remember that this is broken the
next time I do a migration to the latest iot components.
On Tue, Apr 21, 2020 at 7:30 PM Sean Stuckless<EMAIL_ADDRESS>wrote:

No, this fixed it... for Health because the accordion item by default
renders all content and just "hides" it.  That in itself seems wrong.  But
they do the same thing for tabs,etc, so they are consistently bad at it.
When a dashboard is renderinged in the accordion item and hidden then it
does not get rendered correctly.  In fact, we've seen several issues
related to content in the accordion item.
At least I'm aware they are broken.  When they ask, why, I'll know what to
say ;)
Sean.
On Tue, Apr 21, 2020 at 6:10 PM Taylor Jones<EMAIL_ADDRESS>wrote:

Yeah, this is a tricky spot - the original PR overwrote default
functionality. It wasn't "opt-in" as we've discussed we're aiming for all
new features to be. So it feels to me that the original change #940
https://github.com/IBM/carbon-addons-iot-react/pull/940 introduced a
bug. The default behavior from Carbon isn't available at all since the
AccordionItem was overwritten. So my changes here fix the bug, restoring
the original behavior. Additionally, it provides a new way to achieve the
deferred rendering of content.
In practice this will mean that if your app requires the use of deferred
content rendering in Accordions, you will need to update those
usages/imports of AccordionItem to AccordionItemDefer.
I know this isn't ideal, but it seems appropriate in principle. The
alternative would've had us exposing default carbon functionality through a
different/new component. That feels backwards and potentially confusing for
contributors and consumers.
On the dashboard sizing issue - I don't think the original PR, #940
https://github.com/IBM/carbon-addons-iot-react/pull/940, did anything
to fix the dashboard sizing issue #939
https://github.com/IBM/carbon-addons-iot-react/issues/939? I haven't
made any changes to styling for any component.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/IBM/carbon-addons-iot-react/pull/1105#issuecomment-617440022,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIB6KMYUDCO2RZHICPGVMDRNYKWBANCNFSM4MMZ2DCQ
.

@sstone2423 if we encapsulate the stateful logic behind a prop inside AccordionItem we will be overriding Carbon's AccordionItem directly. This would cause us to copy/paste component source code, stories, proptypes, etc and then have to ensure it's all kept up to date as things potentially change through updating to new minor versions of Carbon.
Good idea on the info section - I'll add some docs there

:tada: This PR is included in version 2.71.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Knative service names truncated in metrics

Describe the bug
Emissary is truncating Envoy Proxy cluster names to 32 characters, which interferes with my ability to measure a service's requests per second, which is my goal.
Here are the metrics for two differently-named knative services whose names are longer than 32 characters. (I trimmed the unimportant labels.) How can I tell which one is which?
envoy_cluster_upstream_rq_xx{envoy_cluster_name="cluster_svc45678901234567890123456789012-0", envoy_response_code_class="2"} 6
envoy_cluster_upstream_rq_xx{envoy_cluster_name="cluster_svc45678901234567890123456789012-1", envoy_response_code_class="2"} 7

To Reproduce

Install Knative and ambassador
Create two knative services with similar names. The names should be begin with the same 32 characters, such as svc45678901234567890123456789012 and should be different after that.
Issue requests to both services.
Scrape the Emissary Ingress pod /metrics endpoint or view the envoy_cluster_upstream_rq_xx metric in Prometheus

Expected behavior
I would expect the envoy_cluster_name to be the exact knative service name, longer than 32 characters since that is allowed by knative, and not truncated or prepended with anything extraneous.
Versions (please complete the following information):

Ambassador - 1.13.7
Kubernetes environment - bare metal
Version - 1.19

Additional context
Knative is passing the service names on to Ambassador without truncating them:
$ kubectl -n my-namespace get ingresses.networking.internal.knative.dev
NAME                                 READY   REASON
svc456789012345678901234567890123    True
svc4567890123456789012345678901234   True

@khussey @kflynn can you please kindly look into this bug, thank you

+1
We are facing a similar issue.  The envoy_cluster_name metric value is getting truncated randomly.
The -<namespace- are well within 100 characters, and we are using ambassador:1.13.10 version.
Sample metrics : here the ending characters of the namespace is getting truncated!
envoy_cluster_upstream_rq_time_bucket{envoy_cluster_name="cluster_ums_authorization_1_umsp_in_qa_a-0",le="0.5"} 10
envoy_cluster_upstream_rq_time_bucket{envoy_cluster_name="cluster_subscription_service_read_1_hspa-0",le="100"} 3781
envoy_cluster_upstream_cx_length_ms_bucket{envoy_cluster_name="cluster_ratelimit_default_ambassador_in_-0",le="0.5"} 0`


Utils.feedback(:boolean_diagram3, answer) returns false when the diagram looks for true

Stack trace:
 1) test boolean_diagram3 (:boolean_diagram3)
     utils/lib/feedback.ex:237
     Assertion with == failed
     code:  assert answer == false
     left:  true
     right: false
     stacktrace:
       utils/lib/feedback.ex:239: (test)

I don't believe there's a way to get the diagram to false either way. When I interpret the top-left portion as true or true that evaluates to true. It's like true or evaluates to true no matter what, only an and would get us into falsey territory.
This screenshot should illustrate this a little better:

The first true should be false. This has been adjusted. Thank you for catching this!


When creating new virtual machines, AZ should not compute a default os disk name

Currently, we will generate a hashed name based on the vm name. If we don't specify a value, the platform will pick one for us.
But... if we do change this behavior, we need to understand how breaking it is (the default name will change, which means that a create on an already existing vm may have issues... not sure how important that is, though...

Why should we not compute a disk name?

In general, whenever the platform has a default behavior, we should have a good reason to override it in az.    The platform can do a better job of ensuring uniqueness (as one example). We are also considering how to link related resources in general, and while naming convention is unlikely to be the only mechanism, it won't help to have different clients needlessly using different naming schemes for related resources.

Does the platform have a default behavior in this case?  And if we relied on that default behavior, would the create command be idempotent?  If I issued the same VM create would I get two identical VMs or a successful PUT of the same VM (current behavior)?

At least for managed disks, yes and yes.


image_types_ostree: Add a unique ref to fix simultaneous bitbaking.

To enable simultaneous bitbaking of two images with the same branch name, create
a new ref in the OSTree repo using the basename of the image.
As @OYTIS has pointed out, this probably won't solve every problem that might
come up with simultaneous bitbaking, such as if the two images use different
bootloaders. However, it does solve the immediate problem that comes up with our
primary-image + secondary-image example.

Passes oe-selftest.


⚠ Bofrost.be has degraded performance

In 7f125ee, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1401 ms

Resolved: Bofrost.be performance has improved in 8bf828b after 30 minutes.


Read only not effective

Is there an existing issue for this?

[X] I have searched the existing issues

The question

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.1 23B74 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.1.1)
[✓] VS Code (version 1.89.1)
[✓] Connected device (5 available)
[✓] Network resources
flutter_quill: ^9.4.0
flutter_quill_extensions: ^9.4.0

readOnly is moved to controller properties try to set it in init state like
@override
void initState() {
super.initState();
controller.readOnly  = true;
}

@herowws this can be closed?


🫥s/${TEAM_NAME}/<TEAM_NAME>/g where appropriate😋

Based on my last run, I felt like people were confused sometimes they see their team names on the instructions, sometimes they see ${TEAM_NAME} so I updated the docs where I believe having hardcoded names shouldn't create a problem, like CLIs etc ☺ I also made some little updates on the docs as I went along.

this will break all the tests .... !!! PLEASE DO NOT MERGE THIS

Ahhh okay, didn't think about tests haha as I wrote in the description, it was sort of confusing for some people that some parts have the substitution but some not. But yeah I understand 🫡 I'll move some other improvement bits to another PR ♥ thanks @eformat ✨


Add Sentinel-1 timeseries and timelapse functions

Add functions for creating S1 timeseries and and timelapse. Also make it available through the streamlit web app https://streamlit.gishub.org
References:
https://geemap.org/timelapse/#geemap.timelapse.create_timeseries
https://geemap.org/timelapse/#geemap.timelapse.create_timelapse

Simple monochrome suffices like https://imgur.com/a/pmFOB8w?

Looks great. PR is welcome.


PartyParrot Additions

Added in missing party parrots from the cultofthepartyparrot.com website, the main source for party parrots

I beat you to it; https://github.com/lambtron/emojipacks/pull/146 :)

@snoek09 Ahhh rip haha


Complex variant casts

Complex variant casts do not work as expected. CoreCLR tests:
Loader\classloader\generics\Variance\IL\IsInst004\IsInst004.*
Loader\classloader\generics\Variance\IL\Unbox004\Unbox004.*

The test uses Activator.CreateInstance to instantiate the generic types to be tested. Normally, this would only succeed if the type is reflectable (and has a "constructed") EEType, but the code has a short circuit logic for value types to just RhNewObject them.
 Then we fail the casts because "necessary" EETypes don't bother to fill out interface lists.
Maybe we should flag "necessary" EETypes somehow.
Cc @davidwrighton