HDFS-16978. RBF: Admin command to support bulk add of mount points

JIRA: HDFS-16978
All state store implementations support adding multiple state store records using single putAll() implementation. We should provide new router admin API to support bulk addition of mount table entries that can utilize this build add implementation at state store level.
For more than one mount point to be added, the goal of bulk addition should be

To reduce frequent router calls
To avoid frequent state store cache refreshers with each single mount point addition

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 12s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 38s

the patch passed

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

-1 :x:
spotbugs
1m 24s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html
hadoop-hdfs-project/hadoop-hdfs-rbf generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
20m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 22s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

121m 42s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-rbf

org.apache.hadoop.hdfs.tools.federation.AddMountAttributes.getNss() may expose internal representation by returning AddMountAttributes.nss  At AddMountAttributes.java:by returning AddMountAttributes.nss  At AddMountAttributes.java:[line 45]

org.apache.hadoop.hdfs.tools.federation.AddMountAttributes.setNss(String[]) may expose internal representation by storing an externally mutable object into AddMountAttributes.nss  At AddMountAttributes.java:by storing an externally mutable object into AddMountAttributes.nss  At AddMountAttributes.java:[line 49]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux c842cebd39f3 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9e95b0aca39fd8896cd39d529e1d0d5ef2cf75e1

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/1/testReport/

Max. process+thread count
2447 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  6s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
20m 48s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  6s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 36s

the patch passed

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 37 new + 1 unchanged - 0 fixed = 38 total (was 1)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
20m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 52s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

116m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 8906f9be91d8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3b4d0063dfa836f6a500068705e7f8bc08bc8ade

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/2/testReport/

Max. process+thread count
2902 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 34s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
20m 33s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 52s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 36s

the patch passed

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 33s

the patch passed

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 37 new + 1 unchanged - 0 fixed = 38 total (was 1)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
20m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 36s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

117m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 0957a1b61cb1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0291b4e68de16e8a35ba55a9db75bfbb41f9ccfb

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/3/testReport/

Max. process+thread count
2147 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  3s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 45s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  4s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 36s

the patch passed

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 25s

the patch passed

+1 :green_heart:
shadedclient
20m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
22m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

118m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux aa66b56001c9 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a772eb4536637b2c3c863fb9997b0198920c6a7a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/4/testReport/

Max. process+thread count
2184 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 15s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 51s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 10s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 37s

the patch passed

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 18s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 3 new + 1 unchanged - 0 fixed = 4 total (was 1)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
20m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 47s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

116m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux ee8fa1853314 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7b31c482832de1b6a8ac00d45d6bec11f4e46250

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/5/testReport/

Max. process+thread count
2905 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 49s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 33s

trunk passed

+1 :green_heart:
shadedclient
24m 11s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 28s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 37s

the patch passed

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 31s

the patch passed

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

-1 :x:
javadoc
0m 32s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 23s

the patch passed

+1 :green_heart:
shadedclient
23m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
21m 25s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

125m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux c0f459291025 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7b31c482832de1b6a8ac00d45d6bec11f4e46250

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/6/testReport/

Max. process+thread count
2347 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 15s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 33s

trunk passed

+1 :green_heart:
shadedclient
20m 42s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  0s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 37s

the patch passed

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 31s

the patch passed

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 34s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 20s

the patch passed

+1 :green_heart:
shadedclient
23m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 30s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

118m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux a4c43eab2f72 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df002e2e56ae1c39b9caace6c11626c3abdbb16b

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/7/testReport/

Max. process+thread count
2904 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 57s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
20m 50s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  9s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 37s

the patch passed

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

-1 :x:
javadoc
0m 35s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
20m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
22m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

135m 37s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 0950b660f719 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 46dd8eb6690223a993f08f728d3230aacbdf005a

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/8/testReport/

Max. process+thread count
2195 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the reviews

Thanks @simbadzina, addressed the comments.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 22s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
20m 37s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 57s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 36s

the patch passed

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
20m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
20m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

119m 22s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux bc3e288579b1 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8235d5c4bd564984f95e00c14d6b06f8ca915073

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/9/testReport/

Max. process+thread count
2910 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Is it good to merge this PR?

Let's get a clean build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 23s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 33s

trunk passed

+1 :green_heart:
shadedclient
20m 55s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 14s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 36s

the patch passed

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 33s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 20 new + 79 unchanged - 20 fixed = 99 total (was 99)

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
20m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 48s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

116m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 2b329c8c5a62 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8235d5c4bd564984f95e00c14d6b06f8ca915073

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/10/testReport/

Max. process+thread count
2898 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

javadoc warnings are not for patch code, they are only for generated proto code

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 18s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 35s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  9s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 38s

the patch passed

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

-1 :x:
javadoc
0m 28s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 70 new + 0 unchanged - 99 fixed = 70 total (was 99)

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 38s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

117m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 7edecad926bb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8dacd81b3c9edf1ec05bf87b55deece6a6143e46

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/11/testReport/

Max. process+thread count
2903 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri i excluded "generated proto package" from having to go through javadoc warnings in the latest commit and hence, now the javadoc shows real source code warnings but they are not related to this patch.

generated 70 new + 0 unchanged - 99 fixed = 70 total (was 99)

can i create follow-up Jira to fix those 70 warnings for the whole module so that they are fixed in a separate patch?

Or shall i fix them all with this PR?

Let's tackle the warnings in a separate PR.

@ayushtkn can you take a final look?

@ayushtkn could you please take a look?

@goiri could you please help merge the PR?

@ayushtkn another ping.

Nothing further to add from my side. @goiri feel free to push once you are convinced. Thanx again for holding :-)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 13s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 31s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m  9s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 28s

the patch passed

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

-1 :x:
javadoc
0m 29s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 73 new + 0 unchanged - 99 fixed = 73 total (was 99)

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 19s

the patch passed

+1 :green_heart:
shadedclient
20m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 40s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

115m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux 9cc7c26c8b02 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 954616268bd71a3ad1dfc27aa82a1a32dc4cc569

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/12/testReport/

Max. process+thread count
2901 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 16s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 29s

trunk passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
20m 54s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 29s

the patch passed

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

-1 :x:
javadoc
0m 28s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 73 new + 0 unchanged - 99 fixed = 73 total (was 99)

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 17s

the patch passed

+1 :green_heart:
shadedclient
20m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 45s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

109m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux b530b0859747 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9f1e8bd23c2b914f00c2319c1ef13d09df45b629

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/13/testReport/

Max. process+thread count
2899 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 46s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 29s

trunk passed

+1 :green_heart:
shadedclient
24m 17s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 34s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
cc
0m 31s

the patch passed

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
cc
0m 28s

the patch passed

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 30s

the patch passed

-1 :x:
javadoc
0m 27s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 generated 73 new + 0 unchanged - 99 fixed = 73 total (was 99)

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
24m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 13s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

119m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5554

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle cc buflint bufcompat

uname
Linux aa464cf32e10 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9f1e8bd23c2b914f00c2319c1ef13d09df45b629

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/testReport/

Max. process+thread count
2099 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn @goiri @simbadzina latest review comments are addressed

Thanks again for the review @goiri, is this good for merge?
i will create follow-up jiras to address:

rbf modules javadoc warnings for JDK 11 (these are real warnings that came into picture after we excluded proto package from maven-javadoc-plugin)
state store putAll implementations to also return entries that failed to get added/updated

LGTM.
@ayushtkn can you give the final blessing?

Done. thx everyone


Yaml parsing of import.meta.glob is not working.

Describe the bug
When trying to read yaml with the following content with import.meta.glob('*.yml', { as: 'yaml' });, it cannot be parsed correctly.
Any of the following lines will result in an error. (Outputs Uncaught SyntaxError: Unexpected token ':')
quoted: 'quoted text'
hyphend-key: kebab case string
array:
  - simple array value1
  - simple array value1
delete: Delete (is reserved key?)

I have verified that eslint-plugin-yaml and yamllint are correct yaml.
Also, once it was read with as='raw' and later read with js-yaml, it was able to parse normally.
Reproduction
https://stackblitz.com/edit/vitejs-vite-kjksyn?file=src/test.yml
System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700KF
    Memory: 15.40 GB / 31.86 GB
  Binaries:
    Node: 18.10.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.2.3 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.525.0), Chromium (105.0.1343.53)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @vitejs/plugin-vue2: ^2.0.0 => 2.0.0
    vite: ^3.1.4 => 3.1.4

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vite does not support yaml out-of-the-box.
You'll need to use @rollup/plugin-yaml or other plugins that adds yaml support.


100 numpy exercises

Link: https://github.com/rougier/numpy-100
Author: @rougier
Video: none
Description: A set of 100 numpy exerises from easy to advanced.

Cool, I'm going to try these myself - thanks again @rougier!


[Refactor] Requests to use MediaType instead of XContentType

Refactors various REST requests to use MediaType instead of XContentType to abstract media format from the REST interfaces.
relates #5910

Codecov Report

Merging #6218 (ded5906) into main (2b77985) will decrease coverage by 0.06%.
The diff coverage is 43.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6218      +/-   ##
============================================
- Coverage     70.91%   70.86%   -0.06%
- Complexity    58898    58915      +17
============================================
  Files          4780     4780
  Lines        281380   281453      +73
  Branches      40635    40639       +4
============================================
- Hits         199536   199444      -92
- Misses        65426    65633     +207
+ Partials      16418    16376      -42

Impacted Files
Coverage Δ

.../java/org/opensearch/common/xcontent/XContent.java
100.00% <ø> (ø)

...rg/opensearch/common/xcontent/XContentFactory.java
64.15% <ø> (+0.94%)
:arrow_up:

.../opensearch/common/xcontent/XContentGenerator.java
73.33% <ø> (ø)

...a/org/opensearch/common/xcontent/XContentType.java
100.00% <ø> (ø)

.../opensearch/common/xcontent/cbor/CborXContent.java
80.00% <ø> (ø)

.../opensearch/common/xcontent/json/JsonXContent.java
100.00% <ø> (ø)

...pensearch/common/xcontent/smile/SmileXContent.java
87.50% <ø> (ø)

.../opensearch/common/xcontent/yaml/YamlXContent.java
84.61% <ø> (ø)

...ction/admin/indices/create/CreateIndexRequest.java
66.22% <0.00%> (-9.32%)
:arrow_down:

...g/opensearch/action/ingest/PutPipelineRequest.java
67.74% <0.00%> (-19.76%)
:arrow_down:

... and 514 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize Is this going to be backported? It builds on some changes from #6009 which has not been backported. I spent a couple minutes looking at it and it wasn't immediately obvious to me how to reconcile the changes.

Yes. I'll take care of both.


Add reranking support

According to the https://github.com/ggerganov/llama.cpp/pull/9510, lllama-cpp supported for reranking model https://huggingface.co/BAAI/bge-reranker-v2-m3.
Please provide support for this version.

@abetlen Sorry but do you have any plans to implement this?

Hi @donguyen32
I am thinking the same thing and have just submitted a PR to add the rank method to High-Level API.
I don't know if it will be merged or not, but it would be helpful to know how to do the ranking using llama-cpp-python.

@yutyan0119 Arcoding from the original repo, I see that the format of the rerank task is [BOS]query[EOS][SEP]doc[EOS]
https://github.com/ggerganov/llama.cpp/blob/9f409893519b4a6def46ef80cd6f5d05ac0fb157/examples/server/utils.hpp#L185-L196
your inputs are [f"{query}{doc}" for doc in documents]
Please check it

@donguyen32
Thanks for your comment! Actually, I was looking at examples/embedding/embedding.cpp, so I think there are some differences from the server implementation.
I have verified that the output is the same as the original implementation with the following command
./llama-embedding \
    -m models/bge-reranker-v2-m3/ggml-model-f16.gguf \
    -p "what is panda?</s><s>hi\nwhat is panda?</s><s>it's a bear\nwhat is panda?</s><s>The giant panda (Ailuropoda melanoleuca), sometimes called a panda bear or simply panda, is a bear species endemic to China." \
    --pooling rank --embd-normalize -1 --verbose-prompt

The same command also seems to be used for testing on CI.
https://github.com/ggerganov/llama.cpp/blob/a9e8a9a0306a8093eef93b0022d9f45510490072/ci/run.sh#L755
In fact, I do not know how these symbols affect the accuracy of Rerank. If you know, please let me know.
And if we want a return value in the form of the server, I think it would be better to have a separate method in the form of a create_embedding method for embed, like create_rank.

I am wondering is this feature in plan?

Any progress on this?


[master] Upgrade to latest dependencies

Justification, Retriggering after https://github.com/knative-sandbox/knobots/pull/34 -slinkydeveloper
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced via:
./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:
bumping knative.dev/hack 4ed1ecb...d946d25:
  > d946d25 Revert "Add hermetic go mod aware handling to run_go_tool (# 38)" (# 39)
  > ea9c9a0 Add hermetic go mod aware handling to run_go_tool (# 38)
bumping knative.dev/pkg 51c72e2...acbf2af:
  > acbf2af Harden logstream against non-object events (# 1984)
  > 93874f0 Drainer supports customized kubelet probe check (# 1977)
bumping knative.dev/networking ecb89ce...4c4c237:
  > 4c4c237 Add config to disable auto-creation of domain claims (# 330)
  > 3a89509 As per discussion with @mattmoor keep drainer in pkg (# 329)
  > c30dc94 Use symlink for testdata version of config-network.yaml (# 328)

/lgtm
/approve

/lgtm
/approve


update go versionm 1.16.1 -> 1.16.6

Signed-off-by: Ashley Schuett<EMAIL_ADDRESS>
What this PR does / why we need it:
Update go version
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Go version updated to version 1.16.6

Do we want to update the builder image too?

@xpivarc thanks for the reminder. I think I did it correctly now?

/lgtm

Thanks @ashleyschuett !
I'm a bit concerned that go rules don't fully support Go 1.16.6.
The latest go rules version (v0.24.14) that said something about supporting new Go versions says: Go 1.16.2, 1.16.1, 1.15.10, and 1.15.9 are now supported. In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").
On the other hand - I see that CI lanes ended up generally fine.. I would appreciate another opinion on this :)

/test pull-kubevirt-e2e-k8s-1.19-sig-storage

In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").

I can downgrad this to instead use 1.16.5 if that's better? Maybe @dhiller has an opinion?

In their latest version's release notes (v0.28.0) they use go_register_toolchains(version = "1.16.5").

I can downgrad this to instead use 1.16.5 if that's better? Maybe @dhiller has an opinion?

Sorry, missed the notification on this.
IMHO if everything works, we should leave it like this.

IMHO if everything works, we should leave it like this.

@dhiller are you okay with giving it an approve then? :)

/approve


Implement ESLint rules

Followed is a list of ESLint rules that we should implement.

[ ] enforce return statements in getters (getter-return)
[X] disallow using an async function as a Promise executor (no-async-promise-executor) #101
[X] disallow comparing against -0 (no-compare-neg-zero) #106
[ ] disallow assignment operators in conditional expressions (no-cond-assign)
[X] disallow the use of debugger (no-debugger) #103
[X] disallow duplicate arguments in function definitions (no-dupe-args) #99
[ ] disallow duplicate keys in object literals (no-dupe-keys) @mattjones
[X] disallow a duplicate case label (no-duplicate-case) #98
[ ] disallow empty character classes in regular expressions (no-empty-character-class)
[ ] disallow reassigning exceptions in catch clauses (no-ex-assign)
[ ] disallow unnecessary boolean casts (no-extra-boolean-cast)
[ ] disallow reassigning function declarations (no-func-assign)
[ ] disallow assigning to imported bindings (no-import-assign)
[ ] disallow variable or function declarations in nested blocks (no-inner-declarations)
[ ] disallow invalid regular expression strings in RegExp constructors (no-invalid-regexp)
[ ] disallow multiple spaces in regular expression literals (no-regex-spaces)
[ ] disallow returning values from setters (no-setter-return)
[x] disallow sparse arrays (no-sparse-arrays) #91
[ ] disallow unreachable code after return, throw, continue, and break statements (no-unreachable) @JayaKrishnaNamburu
[ ] disallow control flow statements in finally blocks (no-unsafe-finally)
[x] disallow negating the left operand of relational operators (no-unsafe-negation) #89
[ ] disallow template literal placeholder syntax in regular strings (no-template-curly-in-string)
[ ] disallow deleting variables (no-delete-var) @weblancaster
[X] disallow labels that are variable names (no-label-var) #102
[ ] disallow shadowing of restricted names (no-shadow-restricted-names)
[ ] suggest template literals instead of string concatenation (prefer-template)
[X] (disallow-var) #107

Please comment if you want to work on one of these and I'll mark you to avoid duplicating work. Mentions next to rules indicate that someone else is working on it. If a PR isn't opened within a few days then it will be up for grabs.
A checkmark indicates an open PR.

I'd like to try working on no-debugger

I started working on no-delete-var

I would like to try working on no-unreachable :

I'd like to try on no-async-promise-executor

I'd like to try taking on no-dupe-args

Taking a look at no-dupe-keys

I'm taking on no-duplicate-case

Would take no-label-var

I've added links to the ESLint rule documentation, src implementation and test implementation as it might be useful for people working on them.

[ ] enforce return statements in getters (getter-return)

docs | src | test | @tanhauhau

[ ] disallow using an async function as a Promise executor (no-async-promise-executor)

docs | src | test

[ ] disallow comparing against -0 (no-compare-neg-zero)

docs | src | test

[ ] disallow assignment operators in conditional expressions (no-cond-assign)

docs | src | test

[ ] disallow the use of debugger (no-debugger)

docs | src | test | @yangshun

[ ] disallow duplicate arguments in function definitions (no-dupe-args)

docs | src | test |  @zinyando

[ ] disallow duplicate keys in object literals (no-dupe-keys)

docs | src | test |  @mattjones

[ ] disallow a duplicate case label (no-duplicate-case)

docs | src | test | @zinyando

[ ] disallow empty character classes in regular expressions (no-empty-character-class)

docs | src | test

[ ] disallow reassigning exceptions in catch clauses (no-ex-assign)

docs | src | test

[ ] disallow unnecessary boolean casts (no-extra-boolean-cast)

docs | src | test

[ ] disallow reassigning function declarations (no-func-assign)

docs | src | test

[ ] disallow assigning to imported bindings (no-import-assign)

docs | src | test

[ ] disallow variable or function declarations in nested blocks (no-inner-declarations)

docs | src | test

[ ] disallow invalid regular expression strings in RegExp constructors (no-invalid-regexp)

docs | src | test

[ ] disallow multiple spaces in regular expression literals (no-regex-spaces)

docs | src | test

[ ] disallow returning values from setters (no-setter-return)

docs | src | test

[x] disallow sparse arrays (no-sparse-arrays)

docs | src | test | #91

[ ] disallow unreachable code after return, throw, continue, and break statements (no-unreachable)

docs | src | test | @JayaKrishnaNamburu

[ ] disallow control flow statements in finally blocks (no-unsafe-finally)

docs | src | test

[x] disallow negating the left operand of relational operators (no-unsafe-negation)

docs | src | test | #89

[ ] disallow template literal placeholder syntax in regular strings (no-template-curly-in-string)

docs | src | test

[ ] disallow deleting variables (no-delete-var)

docs | src | test

[ ] disallow labels that are variable names (no-label-var)

docs | src | test

[ ] disallow shadowing of restricted names (no-shadow-restricted-names)

docs | src | test

[ ] suggest template literals instead of string concatenation (prefer-template)

docs | src | test

Some general observations/thoughts while working on the noDebugger rule:

Not clear how to test for both valid and invalid cases. Would be good to have a format similar to ESLint's where contributors just specify the valid and invalid patterns along with desired errors
Might want to sort the exports in<EMAIL_ADDRESS>alphabetically to reduce the chance of merge conflicts. From looking at the PRs, there will be quite a few merge conflicts as most people add it to the bottom
Might want to sort the cases within<EMAIL_ADDRESS>or start a convention of one test file per rule. Lowers the chance of merge conflicts and smaller files are easier to read
The unusedVariables rule is firing on the other lint rules tests. Would be nice to have a way to silence it for other tests

Hey is anyone interested in discussing some pointers on implementation of no-unreachable implementation. I tried some way, but one way or the other few edge cases are failing when tested over eslint test rules 😓 😅

Taking no-compare-neg-zero

@JayaKrishnaNamburu Sounds like one of the more fun ones.  I'd be interested in thinking about it.  Got a branch up yet?

Sure @JayaKrishnaNamburu i will update it tomorrow and let's discuss there 😄

@JayaKrishnaNamburu

Hey is anyone interested in discussing some pointers on implementation of no-unreachable implementation. I tried some way, but one way or the other few edge cases are failing when tested over eslint test rules sweat sweat_smile

I don't think it would be as straightforward as ESLint since we don't have the same concept of code paths. It's fine if it's not as smart. Rome has a more sophisticated analysis system in js-analysis that we can utilize in the far future for something even better.

I've updated the main issue body with the latest PRs.

My user is @mattsjones not @MattJones btw 😅

Oops, sorry @MattJones :stuck_out_tongue:

I will work on no-template-curly-in-string

I'll take no-func-assign

no-cond-assign please

Yeah we would want the always/only option. Parens seems like an odd escape hatch. Just suppress it if it's what you actually want to mean.

@JayaKrishnaNamburu

Hey is anyone interested in discussing some pointers on implementation of no-unreachable implementation. I tried some way, but one way or the other few edge cases are failing when tested over eslint test rules sweat sweat_smile

I don't think it would be as straightforward as ESLint since we don't have the same concept of code paths. It's fine if it's not as smart. Rome has a more sophisticated analysis system in js-analysis that we can utilize in the far future for something even better.

Sure,  Thank you. I will continue my work then 👍  😄

Happy to pickup no-shadow-restricted-names. ESLint currently only handles "undefined", "NaN", "Infinity", "arguments", "eval".
I was thinking we should block everything matching scope.getRootScope().isGlobal(name)?

Sounds good to me!

Picking up no-ex-assign

I'll pick up no-import-assign

I'm taking on no-unsafe-finally

I will try no-regex-spaces

I'm taking prefer-template

I can do getter-return

Updated the issue body. Thanks everyone! Super happy and appreciative of all the PRs so far!

I can do no-empty-character-class

I would like to try no-inner-declarations (hopefully it's not too complex 😄)

I'm going to try to work on no-extra-boolean-cast

picking up prefer-template

I'll take on no-invalid-regexp

Is anybody here stuck/feel like they could use a second pair of eyes on whatever problem they're on?

There's been some changes to structure since this issue was created and many of the PRs submitted. I just created a PR that adds a simple rule #196 and included some instructions that will hopefully be helpful to others.

@sebmck can you please update the list? I see some rules in the list that are unchecked but are already implemented. Oh and I implemented no-inner-declarations rule (#305) since @tatchi never made a PR. So please update accordingly.

@thecodrr actually I did open a PR #142 but we decided to close it. Sorry, I should have added a comment here.

@tatchi and I should have confirmed (and researched) before jumping to implementation. :laughing: Duplicate efforts. haha

It actually looks like all these rules have been implemented or deferred. If anyone has any other ideas for lint rules, whether ones that already exist, or new ones that are made easier/justified with an easy autofix, please open an issue to discuss!


Error: Cannot find module './build/Release/node_sleep.node'

yarn add ./build/Release/node_sleep.node
yarn add v1.22.18
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
warning<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning request ><EMAIL_ADDRESS>this library is no longer supported
warning request ><EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
error Package "./build/Release/node_sleep.node" refers to a non-existing file '"/data/data/com.termux/files/home/bad-bot/build/Release/node_sleep.node"'.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

yarn add ./build/Release/node_sleep.node

This command doesn't make sense. Like the last line says, visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.


‘flushCall’ is not a member of ‘Verilated’

I am trying to use pyverilog with the register files generated with peakRDL-verilog (https://github.com/hughjackson/PeakRDL-verilog) and I am getting the following error.
g++  -I.  -MMD -I/usr/local/share/verilator/include -I/usr/local/share/verilator/include/vltstd -DVM_COVERAGE=0 -DVM_SC=0 -DVM_TRACE=1 -faligned-new -Wno-bool-operation -Wno-sign-compare -Wno-uninitialized -Wno-unused-but-set-variable -Wno-unused-parameter -Wno-unused-variable -Wno-shadow     -fPIC -shared --std=c++11 -DVL_USER_FINISH  -std=gnu++14 -Os -c -o pyverilator_wrapper.o ../obj_dir/pyverilator_wrapper.cpp
../obj_dir/pyverilator_wrapper.cpp: In function ‘void vl_finish(const char*, int, const char*)’:
../obj_dir/pyverilator_wrapper.cpp:56:24: error: ‘flushCall’ is not a member of ‘Verilated’
56 |             Verilated::flushCall();
|                        ^~~~~~~~~
make: *** [Vbasic_rf.mk:60: pyverilator_wrapper.o] Errore 1

flushCall() has been removed, then  restored for backwards compatibility starting from verilator version 4.102.
https://github.com/chipsalliance/chisel3/issues/1565
Discussed on this issue too
https://github.com/csail-csg/pyverilator/issues/16

I made a fork that deals with this issue ( https://github.com/bat52/pyverilator ) and is available over pypi as pyverilator-mm


Commit 4b2dafc26ab82df790bef6a4ae1c2ad5c5ca06c3 breaks font on gvim in Ubuntu 16.04

The font of gvim on my Ubuntu 16.04 machine is extremely wide. Reverting 4b2dafc26ab82df790bef6a4ae1c2ad5c5ca06c3 seems to fix the problem.

Please do a PR, I don't have access to an Ubuntu machine 👍


Piezo motion controller.

I will need to implement shortly a driver for an Attocube ANC300 Piezo positioning electronic system. And to avoid doing it twice it would prefer to do it directly with lantz. Does anybody else use that kind of system ?
It should be noted that this electronic can be connected to different sort of motion controller which cannot be remotely identified hence it behaves like a mixed AC DC voltage generator and features will all be expressed in volts. I will do what I need to get it working and see if we can come up with any sort of standard.
Another interesting point is that it uses telnet for communication and hence will require a new backend for lantz_core, I will open the corresponding issue.

i had a class for a newport mulit-axis motion controller, https://github.com/scikit-rf/scikit-rf/blob/master/skrf/vi/stages.py#L21
i dont use this very often (or have access to it) but i just thought i would mention is in case there was a desire to have a linear axis controller mother class.
also, fyi i will be  using the new lantz framework shortly, and am looking forward to it!

@arsenovic we have the same controller and a working Lantz Driver. I think is definitely a good idea. Let's try to come up with an API.

Glad to see you back in the loop @arsenovic . I will try to give a look at your driver and the one found in lantz.

@hgrecco I can't find the driver under the newport package (there is only a powermeter, could you please point me to it).

It is not there because it is not curated. We use it internally in our lab. I will put in a gist.

Great !

I have four ThorLabs APT closed-loop piezo controllers that I have been mulling over writing a driver for.  It might make sense to add an APT backend as well.
One thing that we should think about, though:  it is possible to open multiple concurrent connections to a device via ethernet, but it is not possible to do this via USB, serial, etc. directly.  It would be very cool to be able to have a manual adjustment application that can be paired with separate scripts to control the positioning stages (e.g. optimize position for highest power) so you can quickly switch between manual adjustments and automated adjustments.  However, the ThorLabs APT units connect via USB to serial chips, so it's not possible to connect two different applications at the same time without adding an arbitration layer of some sort in between.  It is also nice to be able to have an ipython session running with an active connection so the instrument state can be queried and various commands tested manually while not interfering with running automation scripts that use the same instrument (don't have to exit ipython to run a script).  Works great with LXI devices or GPIB devices through a GPIB to LAN bridge, but it doesn't work for USB and serial devices.  I'm not sure what sort of implementation might make the most sense here, or if this is a feature that anyone would require.  It may be necessary to have some sort of a daemon running in the background in order for this to be possible.  Thoughts?

The way we do that kind of things is having a control app on the background. The lantz app can be split into processes which communicate using pizco. Each process can control one or more (or all devices). A very common desire is to have the core application running in a process and the GUI in a different one. If the latter crashes, the core continues. This is really nice for long unsupervised experiments. For interactive experiments, multithreaded works better.
BTW: Pizco works fine but was just a work in progress, because it is more than a query-response. It can also notify clients.
So your proposal is also useful for this type of goals like having a detached/detachable GUI. It might be look again at the Jupyter project to see how they do it. I looked at the pre 1.0 IPython and the client/server part was too intertwined with the notebook code. Maybe now that Jupyter aims for different backends is better separated.
But, my suggestion is not to add this in Lantz-core, nor in Lantz-drivers. But we need to be sure that can be implemented easily. If you provide good introspection capabilities (as the current lantz has and we are planning for the next) it is easy to create a script that wraps a driver generating a client and a server. An example of such introspection capabilities is how the current test panel GUI that can be generated on the fly for any driver (This will be in a separate python package in the next lantz). Similar to this We could provide a way to generate other way of accessing this, such REST API that can be mounted easily in a web server.

Having the possibilty to have a kind of server is definitively something I would like in the long run but I agree with @hgrecco that it will be by wrapping the existing driver.

Looking on github for apt thorlabs yields many repos. It would make sense to try to get in touch with their maintainers.

The card I need to interface is a open-loop positioning module, the rack can accept two other types of cards :

one is an open-loop scanning module
the other an open loop scanning and positioning module.
I am not sure what are the main differences between open and closed loop and whether they need different bas classes or not. I will try to dig a bit more.

Looking quickly at some of the driver for Thorlabs APT it seems that two approaches are possible either stick with what thorlabs gives us and have a windows only driver relying on a dll (easy using PyCLibrary), or go the hard way and use libftdi (another kind of usb driver) and manage the communications ourselves (this is what is done by pyAPT project and it seems doable as Thorlabs provide a document describing low level communications). One issue will be documenting the installation of libftdi for our users.

I think the libftdi method is the way to go for the APT controllers as it's not limited to windows.

I looked a bit more at how my system works and compared it to the Newport one mentioned by @arsenovic and also what can be done in thorlabs apt. The Newport is a closed loop system (or so it seems to me) and hence quite far from my own need, the apt capabilities are large (doing it will a tremendous work) and even if an open-loop stepper motor might look like my system I am not sure it will be the same.
As I need to interface my system to at least do some testing, I will post my work and see whether or not we can build a standard from there. And this way you will see why it does not fit well with other motion controllers.

I'm wondering if it might be feasible to implement the interprocess arbitration layer seamlessly in lantz.  I'm thinking that what we could do is provide a daemon script that can be run separately (perhaps even as a system service) when this functionality is required.  Whenever a script tries to connect to an instrument, it will attempt to connect to the daemon first and then it will fall back on opening the connection to the instrument directly if the daemon is not running.  This would allow seamless sharing between control/monitoring UIs and other automation scripts without having to write wrapper scripts.  It could be extended to allow scripts to connect to a daemon running on a different computer, so instruments that do not support a network based protocol could be shared.  Thoughts?

I just opened a new issue concerning the use of a central server to avoid crowding this issue with unrelated discussions https://github.com/LabPy/labpy-discussion/issues/15.

For the APT controllers, building on top of pylibftdi may be the way to go.  Looks like that is a decent cross-platform libftdi wrapper library.

We shoukd also look at pyAPT https://github.com/freespace/pyAPT and see if we can build on top of it.

I actually took a look at that one a while ago when I was thinking about automating these stages, but it seems to be missing most of the APIs for the piezo controllers - it only seems to have APIs for the stepper motor controllers.  Either way we will have to implement the piezo controller API.

Currently, I have a Lantz driver for the newport ESP300/301 units. It is working with Lantz0.3
Furthermore, I am using thorlabs PRM1 rotation stages via pyAPT. pyAPT now also runs under python3. I did not create a lantz wrapper for pyAPT, mainly because the current status of lantz and the repositories is rather vague.


Rename readme.md to README.md

Q
A

Bug fix?
yes

New feature?
no

New sample?
no

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
Guidance
You can delete this section when you are submitting the pull request.

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to Dev branch.
For consistency and  http://dev.office.com/patterns-and-practices-detail/9399 is redirecting to github

Hi @DevArvindsa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

thx Arvind.


What is the difference between statefulIf and StatelessIf and when is a ConcreteFunction stateful?

@rnett Could you please explain tf.statefulIf vs tf.statelessIf and when a ConcreteFunction is stateful vs stateless?

I'm not sure tbh, it's an internal tensorflow distinction.  I have been meaning to play with it to get an answer but haven't yet, you might have better luck making an issue in the main tensorflow repo.  All I'm doing is propagating statefulness, i.e. if a stateful op is used in a ConcreteFunction, make the function stateful; if one of the if's functions is stateful, make the if stateful, etc.  Generally you should just use ifOp and rely on that, it does it automatically.


no-static-element-interactions issue

The eslint waring no-static-element-interactions still show up with the proper attributes for div tag.
I have add onClick, onKeyPress and role attributes to div tag as recommended in https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md, but still get warning
React version: 15.4.0
Eslint version: v3.19.0
Warning:

My Code:
<div
    className="hb-card hb-card--goal"`}
    onClick={this.handleClick}
    onKeyPress={this.handleKeyPress}
    tabIndex="0"
    role="button"
>

This is coming from the eslint-plugin-jsx-a11y library and not react-a11y.  You will need to go to that repo and log the issue there.


require('arachne').rename() dont work

E5108: Error executing lua ...site/pack/packer/start/arachne.nvim/lua/arachne/init.lua:42: attempt to concatenate local 'title' (a nil value)
stack traceback:
        ...site/pack/packer/start/arachne.nvim/lua/arachne/init.lua:42: in function 'rename'
        [string ":lua"]:1: in main chunk

$ nvim -v                                                                                3.8m
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
Übersetzt von<EMAIL_ADDRESS>
Features: +acl +iconv +tui
See ":help feature-compile"

          System-vimrc-Datei: "$VIM/sysinit.vim"
     Voreinstellung für $VIM: "/opt/homebrew/Cellar/neovim/0.8.0/share/nvim"

Run :checkhealth for more info

Heya - thanks for reporting the issue: It should now be fixed with the newest version. I will close the issue but feel free to comment on tis or open a new issue if you still encounter problems
The cause for this was that the original file to be renamed did not follow the naming scheme of the arachne notes, one can now rename any file to a note conforming to the naming scheme.

@oem Thx for the fast fix, works as you expect it.


Status Details Pass Through for LocalResponsePolicy

Title: Status Details Pass Through for LocalResponsePolicy
Description:
When using a local response policy (https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/http/custom_response/local_response_policy/v3/local_response_policy.proto) to alter responses before returning them to the client, the RESPONSE_STATUS_DETAILS field in the access logs is empty.
In some cases, it's useful to preserve RESPONSE_STATUS_DETAILS as this can aid debugging failed requests.
Proposing to modify https://github.com/envoyproxy/envoy/blob/main/source/extensions/http/custom_response/local_response_policy/local_response_policy.cc#L81 to something like:
const absl::optional<std::string>& details = encoder_callbacks->streamInfo().responseCodeDetails();
encoder_callbacks->sendLocalReply(code, body, mutate_headers, absl::nullopt, details.has_value() ? *details : "");

If the current behavior needs to be preserved as the default, we could introduce a boolean option that controls whether the status details are passed through, or dropped.
I would like to work on this feature, but would first like to confirm if we should make this behavior configurable?

@pradeepcrao Please could you take a look at this issue and let me know what you think? Thanks!

Hi Daniel,
Sorry for the late response. The original response code details might not be the right thing to return in this case as the local response policy is overriding the original response.
It might make sense to make this configurable (https://github.com/envoyproxy/envoy/blob/main/api/envoy/extensions/http/custom_response/local_response_policy/v3/local_response_policy.proto#L27) to either send back the original response code details, or have a new value defined for the LocalResponsePolicy.

Thanks Pradeep, that sounds good to me. I'll let you know when I have a PR for this change