3.0: Improve documentation

Description of changes
Small improvements to the code documentation.
I noticed that you are using :return: to document what a function returns, but many functions were missing the second ":" - feel free to let me know whether that's intended, in that case I can remove those changes from the pull request.
Tests
No test functionalities were modified
References
No related PRs
Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[x] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rdimaio can you please fix the check
../tests/integration-tests/s3_common_utils.py:40:121: E501 line too long (122 > 120 characters)
Thanks

Thanks, fixed the linter error and rebased the new commit into the previous one to keep the commit history clean. I fixed another :return: comment in cli/src/pcluster/utils.py, commented it for reference.


Creating tickets should be consistent

I think when I'm creating/editing a ticket should always be displayed with seperated fields.
(depending of the user role of course)
A dropdown for the status-tag (allow only one status at a time - this is also necesssary for kanban)
A second field which might allow to combine statuses, but I also think that there should be only one type tag per ticket. The same goes for the resolution field. The easier the better.
The storage goes probably into the same database field. But I think that's not a bad thing at all.

Instead of a status tag dropdown, I think now that a simpele tag cloud line would be better. Thats only one click. Like this:
open      construction        review         released        closed
Seeing it this way it would somehow correlate to the kanban view - except it always shows all the possible states.
Resolution by dropdown is good. As is issue type.

Resolution by dropdown is good. As is issue type.

Do you mean you want a second field to select the resolution tag?

yes. I think it would be easier this way. If you have a tag line like now - with predefined values - then you have to know what you could type and you never see all possible values.
A simple dropdown is easier to handle - you don't have to think - but if necessary you can always write a last comment before closing the ticket and explain some resolution in depth.

Ok, if you take a look at the attached pics... this is basically what I suggest:
For CREATING TICKETS:

and for EDITING TICKETS: (If you're more than just a user)

Ah ok. I like this idea.

Hey this looks very good now. Nicely done!
Thanks and closed.


Missing OpenCore.efi

Thanks for sharing your configuration. However, I tried to use your EFI folder and it is not booting because it is missing OpenCore.efi file. Could you provide the correct version of OpenCore used?

I don't know why I missing this file :((.
I don't use hackintosh anymore, but you can use the OpenCore.efi from opencore 0.6.2.
Thanks.


Fix file notifications using tlf properly

I fixed KBFS to send the full canonical path for FSNotifications:
https://github.com/keybase/kbfs/pull/495
This updates our notify handler, to calculate a TLF which is simply the first 3 directories of the canonical path.

@keybase/react-hackers


RFM - procexp

https://chocolatey.org/packages/procexp

I can take this one (and pocmon as well).

Done

New package just pushed!

package approved


feature request add support for http://you.rtl2.de/

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.08.07. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.08.07

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: http://you.rtl2.de/youplayer/index.html?vid=7980
Single video: http://you.rtl2.de/video/115/7982/dragon-ball/65-der-sechste-dragonball
Playlist: http://you.rtl2.de/video/115/7981/dragon-ball
Playlist: http://you.rtl2.de/videos/115/dragon-ball

Description of your issue, suggested solution and other information
Hi, hope ive done this new questionnaire correct... i wasnt sure if i should include it or just check it for my own.
I have found out how i can download videos from http://you.rtl2.de/ on which are manny full episodes. First of all i have to look for the iframe leading to a page like: http://you.rtl2.de/youplayer/index.html?vid=7980 , then i have to open that page in opera or crome and open the development tool with the network view, switch to persistant mode, disable cache (maybe works also with) and click to all given parts (Teil 1 and Teil 2 in german) for all parts in the network view under category xhr a file beginning with master.m3u8 will appere. This file can be saved (to its on directory because of youtube-dl wount download files with the same name again and they are all the same), all lines but the lines with the best quality listed can be deletet and then the content can be retrived using:
youtube-dl -a master3.m3u8
it would be grate if you could add this page to automatisate theese steps.
thanks in advacne

i found a problem here, the site used CryptoJS To decrypt the url, but trying to do the same thing using aes_cbc_decrypt does not work.
this is the code for decryption(after deobfuscation):
window.youStreamDecrypt = function(b) {
    var a = new window.ysd;
    if (a.inArray(a.tld, ["rtl2.de", "rtl2apps.de", "umwerk.me"])) {
        a = CryptoJS.enc.Base64.parse("6VfkLjwquBrStpLzQ9PvTBsDKrtiSMAD/2/C8iiqqiE=");
        b = CryptoJS.enc.Utf8.stringify(CryptoJS.enc.Base64.parse(b));
        streamUrlSplit = b.split(":");
        b = streamUrlSplit[0];
        var c = CryptoJS.enc.Base64.parse(streamUrlSplit[1]),
            a = CryptoJS.AES.decrypt(b, a, {
                iv: c
            });
        return b = CryptoJS.enc.Utf8.stringify(a)
    }
    console.log(a.msg)
};


[Bug]: The bindings on the properties of fields related to theming in JSONForm are wrong

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we drop JSON form, the binding on properties of fields related to theming are like: {{appsmith.theme.colors.primaryColor}} or {{appsmith.theme.borderRadius.appBorderRadius}}. But in order for JSONForm to work properly, these values should be of form {{((sourceData, formData, fieldState) => (appsmith.theme.borderRadius.appBorderRadius))(JSONForm1.sourceData, JSONForm1.formData, JSONForm1.fieldState)}}"
Steps To Reproduce

Drop JSONForm
Inspect the values of fields ( accentColor and borderRadius )
Notice they are not wrapped around a particular format JSONForm requires

Public Sample App
No response
Version
1.7

Closing as fixed!

Fixed the issue in https://github.com/appsmithorg/appsmith/pull/14768


No port

Can someone submit a FreeBSD port?

I'll handle it

Thanks, I'm not a ports committer.

we can mentor you

Committed to ports: https://svnweb.freebsd.org/changeset/ports/443063

The port doesn't package the header. Adding it would aid in the writing of wrappers.

The port doesn't package the header. Adding it would aid in the writing of wrappers
Fixed!


Docs/add yaml examples

Hey @yetudada, sorry for the mishap. This PR was supposed to within my repo. I have a another draft PR for the same already.

Hey @yetudada, sorry for the mishap. This PR was supposed to within my repo. I have a another draft PR for the same already.

Should I close this one and assume that #938 is the PR you want us to review when you're ready?

Yes that's the draft PR I was talking about. I'll close this PR.


Flattened the BUO like on Android.

Result of Integration 1
Duration: 13 minutes and 4 seconds
Result: All 224 tests passed, but please fix 2 warnings.
Test Coverage: 63%


iOS TensorFlowLiteC using old C API

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): iOS 13
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: iPhone 6
TensorFlow installed from (source or binary): binary (TensorFlowLiteC)
TensorFlow version: 1.14.0

Describe the problem
https://github.com/tensorflow/tensorflow/blob/v1.15.0-rc0/tensorflow/lite/experimental/ios/TensorFlowLiteC.podspec does not have the pre-compiled binary yet, considering we have a significant backward compatible API change introduce by https://github.com/tensorflow/tensorflow/commit/4cc4425aee000b6358fbf219fa3dd64710b7aed4
Currently, it's a problem for us at https://github.com/dart-lang/tflite_native/pull/22

Is this still an issue for you? We have recently published both v2.0.0 and v1.15.0 of the TensorFlowLiteC framework via CocoaPods. Let me know if there's anything I can help with.

@yyoon looking at https://github.com/tensorflow/tensorflow/blob/v1.15.0/tensorflow/lite/experimental/ios/TensorFlowLiteC.podspec, it's still pointing to 1.14.0. So does https://github.com/tensorflow/tensorflow/blob/v2.0.0/tensorflow/lite/experimental/ios/TensorFlowLiteC.podspec

I see how that could confuse you, but the actual process we take for releasing TensorFlowLiteC is:

Build the TensorFlowLiteC binary by checking out the release branch
Publish the binary to a publicly downloadable place
Update the podspec to bump up the version and point to the new binary, and publish the new podspec to CocoaPods after the fact.

So, it's somewhat irrelevant to what the podspec file is pointing to, in the specific release branch. Instead, I think you should be looking at the actual history of the C API directory in both branches.
https://github.com/tensorflow/tensorflow/commits/v2.0.0/tensorflow/lite/experimental/c
https://github.com/tensorflow/tensorflow/commits/v1.15.0/tensorflow/lite/experimental/c
You can see that the API style change commit is included in v1.15.0.
If you want to download v1.15.0 without going through CocoaPods, you can use this link directly:
https://dl.google.com/dl/cpdc/559f7884827d4af4/TensorFlowLiteC-1.15.0.tar.gz

ah thanks, I can see v2.0.0 on https://cocoapods.org/pods/TensorFlowLiteObjC now


Implement Point doubling gadget for Bulletproofs using zerocaf

Using the Sonny Curve which is embedded into the Scalar Field of Curve25519, implement a Point doubling gadget and tests for it.
This is one of the 4 gadgets required to implement what is mentioned in dusk-network/dusk-zerocaf#96

Closed via #4


Will DeOSS support continued uploading and downloading of files after they are paused in the future?

@jiuquxzy Consider supporting.


Error message appears when Juman++ and/or KNP are not installed

What
When attempting to start KWJA, an error message is displayed if Juman++ and/or KNP are not installed. The error message is as follows:
failed to start Juman++: [Errno 2] No such file or directory: 'jumanpp'
failed to start KNP: [Errno 2] No such file or directory: 'knp'

Proposed fix
This issue can be fixed by deferring the instantiation of Juman++ and KNP until they are actually needed. Please refer to the following line of code to fix the issue:
https://github.com/ku-nlp/kwja/blob/main/src/kwja/datamodule/datasets/seq2seq_inference.py#L18

PR #169 solves this issue.


No mention of LBRule as prereq for deploying to Azure SF

In https://github.com/Azure-Samples/service-fabric-dotnet-getting-started#voicemailbox

The application includes a web UI accessible at http://:8081/voicemailbox/ and a set of web APIs that can be used to interact with the actor methods.

It isn't immediately obvious that i have to go and manually create a load balancing rule first (for port 8081/TCP) if i want this deployed in Azure Service Fabric - see this other related Issue here https://github.com/Azure/azure-content/issues/5763
Please add a paragraph stating this is a prerequisite for all sample applications that require a LBRule.

Will do, we have a lot more documentation on the way around this that we'll link to from here.


NameError: name '_tensorboard_writers' is not defined

When I try to run the transformer example
Code
torch.hub.list('pytorch/fairseq')
en2de = torch.hub.load('pytorch/fairseq', 'transformer.wmt16.en-de', tokenizer='moses', bpe='subword_nmt')
en2de.eval()  # disable dropout
assert isinstance(en2de.models[0], TransformerModel)
en2de.translate('Hello world!')
en2de.translate(['Hello world!', 'The cat sat on the mat.'])
something wrong occured:
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/home/cat/PycharmProjects/test_pro/text_dispose/fairseq/fairseq/logging/progress_bar.py", line 299, in _close_writers
for w in _tensorboard_writers.values():
NameError: name '_tensorboard_writers' is not defined
My environment

fairseq Version (master)
PyTorch Version (1.4.0)
OS ( Linux)
Installed fairseq by source
Python version: 3.7

Could someone help me ?

Hello! I'm having the same issue


Possible copyright issues.

Hi, I am the owner and developer of the Discord bot ran in Davebot.me.
I would like to discuss the possibility of this bot (if being
commercialized) infringing our copyright and possibly spreading false information about our product.
The name Davebot has been owned since November 2018.

I'm going to close this issue, as this repo is no longer active.

Hey! Sorry for not responding sooner, busy day.
First, I don't plan on commercialising this bot, as it's currently not under further development, and even it it was, I can't think of a sane way to do so.
Second, while you may have claimed the name Davebot since November 18, the first commit to this repository (under the name DaveBot) was well before that, and there was a github release using the name Davebot on the 8th of June 2017. So, technically, I could ask what you're doing using our name!
Have a good one!

First of all, I'm glad to hear that we are able to reach an agreenment on
how we will continue.
Secondly, I hold the copyright of the name D.A.V.E Bot. Which is an
acronym, I think I forgot to mention that.
This situation would only be an issue if both of these bots would be
comersalazed as the names are so similar, which will never occur. From what
I understood.
Please confirm you recieved this message.
ti 30. huhtikuuta 2019 klo 22.42 Fisher<EMAIL_ADDRESS>kirjoitti:

Hey! Sorry for not responding sooner, busy day.
First, I don't plan on commercialising this bot, as it's currently not
under further development, and even it it was, I can't think of a sane way
to do so.
Second, while you may have claimed the name Davebot since November 18, the
first commit to this repository (under the name DaveBot) was well before
that, and there was a github release using the name Davebot on the 8th of
June 2017. So, technically, I could ask what you're doing using our name!
Have a good one!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488088512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIFAMSNGZKYZ237EFXCCPU3PTCOLXANCNFSM4HJIRR5A
.

Heya, yep, message received. I think since your bot's name is sufficiently
different that this shouldn't be an issue. Have a good one.
On Tue, 30 Apr 2019, 21:51 Esinko<EMAIL_ADDRESS>wrote:

First of all, I'm glad to hear that we are able to reach an agreenment on
how we will continue.
Secondly, I hold the copyright of the name D.A.V.E Bot. Which is an
acronym, I think I forgot to mention that.
This situation would only be an issue if both of these bots would be
comersalazed as the names are so similar, which will never occur. From what
I understood.
Please confirm you recieved this message.
ti 30. huhtikuuta 2019 klo 22.42 Fisher<EMAIL_ADDRESS>kirjoitti:

Hey! Sorry for not responding sooner, busy day.
First, I don't plan on commercialising this bot, as it's currently not
under further development, and even it it was, I can't think of a sane
way
to do so.
Second, while you may have claimed the name Davebot since November 18,
the
first commit to this repository (under the name DaveBot) was well before
that, and there was a github release using the name Davebot on the 8th of
June 2017. So, technically, I could ask what you're doing using our name!
Have a good one!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488088512,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AIFAMSNGZKYZ237EFXCCPU3PTCOLXANCNFSM4HJIRR5A
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488110935,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF7RP6752M7GX67ZZWV272DPTCWLTANCNFSM4HJIRR5A
.

Great, have a good day.
ti 30. huhtikuuta 2019 klo 23.57 Fisher<EMAIL_ADDRESS>kirjoitti:

Heya, yep, message received. I think since your bot's name is sufficiently
different that this shouldn't be an issue. Have a good one.
On Tue, 30 Apr 2019, 21:51 Esinko<EMAIL_ADDRESS>wrote:

First of all, I'm glad to hear that we are able to reach an agreenment on
how we will continue.
Secondly, I hold the copyright of the name D.A.V.E Bot. Which is an
acronym, I think I forgot to mention that.
This situation would only be an issue if both of these bots would be
comersalazed as the names are so similar, which will never occur. From
what
I understood.
Please confirm you recieved this message.
ti 30. huhtikuuta 2019 klo 22.42 Fisher<EMAIL_ADDRESS>kirjoitti:

Hey! Sorry for not responding sooner, busy day.
First, I don't plan on commercialising this bot, as it's currently not
under further development, and even it it was, I can't think of a sane
way
to do so.
Second, while you may have claimed the name Davebot since November 18,
the
first commit to this repository (under the name DaveBot) was well
before
that, and there was a github release using the name Davebot on the 8th
of
June 2017. So, technically, I could ask what you're doing using our
name!
Have a good one!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488088512
,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AIFAMSNGZKYZ237EFXCCPU3PTCOLXANCNFSM4HJIRR5A

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488110935,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AF7RP6752M7GX67ZZWV272DPTCWLTANCNFSM4HJIRR5A
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/DaveInc/Dave-BOT/issues/31#issuecomment-488112974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIFAMSPBIPMMOBITZLWTFLTPTCXDPANCNFSM4HJIRR5A
.


Configure delete empty allocations as periodic task in 3.1

I want to merge this change because copy changes from #7873 to master.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4221 Configure celery beat to clear empty allocations


Set SSL Protocol tls

Bug fix issue #54

@jeffersonmello  how is your luck with this api?

@jeffersonmello how is your luck with this api?

for now I'm using it well, there are some things I still don't know how to use

Thanks...!!!
@jeffersonmello
During the tests, I only needed to invert the lines because WS was not created yet ... It's people like you that make the OpenSource world better ... !!!
WebSocketClient = new WebSocket("wss://iqoption.com/echo/websocket");
WebSocketClient.SslConfiguration.EnabledSslProtocols = System.Security.Authentication.SslProtocols.Tls12;
I'll just adjust the DLL to release the package and update the version.


WCAG 4.1.2: Ensures ARIA attributes are allowed for an element's role (button[title="Show toolbar"])

Issue
Ensures ARIA attributes are allowed for an element's role (aria-allowed-attr)
Target application
Galeryst Data
Element path
#sanddance;button[title="Show toolbar"]
Snippet
<button type="button" role="button" aria-selected="false" class="ms-Button ms-Button--icon vbutton root-139" title="Show toolbar" data-is-focusable="true">
How to fix
Fix any of the following:
  ARIA attribute is not allowed: aria-selected="false"

Environment
Microsoft Edge version 109.0.1518.61
This accessibility issue was found using Accessibility Insights for Web 2.36.1 (axe-core 4.4.1), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

fixed in #737


What is this?

Could we get some more context on this lib? Is this built on top of react-map-gl or is the API completely different?
This is really cool but looking through the "show code" code I can't see anything about how to add source, layer etc.
I've been searching for the best web map stack for a couple years now. React-map-gl looks promising but mapbox killed compatibility with CRA with 2.0, and I haven't been able to hack it to roll back mapbox gl or to use maplibre.
Searching for a working example to fork with react-map-gl and maplibre brought me here, but I'm a bit skeptical. The get started sandbox hits a transpilation error, same as react-map-gl with mapbox 2.0.
If this is the FOSS webmap framework we've all been waiting for, please let us know

Ok, this codesandbox got me up and running. Great work, this seems like a good start so far.
I took a look at the WhereGroup site and it seems the company invests heavily in open source projects. Before investing my time in this lib, can you please clarify if this library will always be free and open source?
After watching mapbox close GL down after gaining some traction and getting forks removed from Github for "copyright infringment" (MapTiler), I don't want to get baited into having a troublesome dependency again. In my opinion, they would have been better off building their paid product on top of their open source lib like everyone else, rather than trying to reign back the project they already put out there.

We have updated the Readme to give a better overview and increase accessibility.
This response is more aimed to anyone else who stumbles upon this resource since you seem to have figured it out by yourself.
Basically this project is aiming to provide good react bindings for MapLibre-gl.
The CodeSandBox is the easiest way to try it, other options are documented in the readme file.


Compress websocket data

Compress the websocket data, before it's send over the socket.

Moved issue to https://github.com/jillix/flow-ws/issues/4.


[API] Calculate label URL

fix #8028

Could the caches contain more then one element?

Codecov Report

Merging #16186 (3c61190) into main (29695cd) will increase coverage by 0.04%.
The diff coverage is 86.56%.

@@            Coverage Diff             @@
##             main   #16186      +/-   ##
==========================================
+ Coverage   44.57%   44.61%   +0.04%
==========================================
  Files         701      701
  Lines       83237    83288      +51
==========================================
+ Hits        37100    37159      +59
+ Misses      40123    40112      -11
- Partials     6014     6017       +3

Impacted Files
Coverage Δ

routers/api/v1/repo/issue_label.go
18.55% <66.66%> (+3.17%)
:arrow_up:

modules/convert/issue.go
86.07% <82.35%> (-1.53%)
:arrow_down:

routers/api/v1/org/label.go
62.33% <100.00%> (+4.36%)
:arrow_up:

routers/api/v1/repo/label.go
62.33% <100.00%> (+4.36%)
:arrow_up:

models/repo_list.go
77.82% <0.00%> (+0.77%)
:arrow_up:

modules/log/event.go
61.79% <0.00%> (+1.88%)
:arrow_up:

modules/queue/workerpool.go
56.87% <0.00%> (+3.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29695cd...3c61190. Read the comment docs.

Could the caches contain more then one element?

Hmm... I don't think they can here.
The labels either belong to the repo or the org. It doesn't appear to make much sense to me that we would provide a cross repo label API.
@6543 is there actually a way that this could happen?

Yes the endpoint to get labels of issues can return org & repo labels

Could the caches contain more then one element?

yes this are edge cases but they exist

hmm, let's check these:

convert/issue.go:21:func ToAPIIssue(issue *models.Issue) *api.Issue {

L44: Labels:   ToLabelList(issue.Labels, repoCache, nil),
All of these labels must be within the same repository and same organization

convert/issue.go:177: ToLabel(label *models.Label, repoCache map[int64]*models.Repository, orgCache map[int64]*models.User)

Called by routers/api/v1/org/label.go 3 times but all must be in the same org.
Called by routers/api/v1/repo/label.go 3 times but all must be in the same repo.
Called by ToLabelList - see below.

convert/issue.go:224:ToLabelList

Called by ToAPIIssue above. Same Repo/Org
Called by routers/api/v1/org/label.go ListLabels - all must be in same org.
Called by routers/api/v1/repo/label.go ListLabels - all must be in the same repo.
Called by routers/api/v1/repo/issue_label.go 3 times but all must be in the same repo or org.

@6543 where were you thinking this was called where it could be cross-repo or cross-org?


Simple example arrow script fails on ubuntu:latest docker container

This docker file using ubuntu:latest, which at this time equates to ubuntu:jammy:

from ubuntu:latest
run apt update -y
run apt upgrade -y
run apt install -y vim libssl-dev libpq-dev python3 python3-venv build-essential
run cd /opt && mkdir python_environments && cd python_environments && python3 -m venv venv && . venv/bin/activate && python -m pip install --upgrade pip && pip install pyarrow pandas
run cd /opt/python_environments && . venv/bin/activate && python -c "import pandas as pd; import pyarrow as pa; from pyarrow import orc; orc.write_table(pa.table({'col1': [1,2,3]}), 'test.orc'); pdtbl = orc.read_table('test.orc')"

Fails on the orc.read_table command with this error:

#9 0.939 terminate called after throwing an instance of 'orc::TimezoneError'
#9 0.939   what():  Can't open /etc/localtime
#9 0.944 Aborted

The error report is accurate, there is no /etc/localtime file in the ubuntu:latest docker image

Environment: Active environment is described by Docker file, but I'm running docker on windows 10.
Reporter: Larry Dawson
Note: This issue was originally created as ARROW-16386. Please see the migration documentation for further details.

Larry Dawson: This works fine on debian:latest, but breaks on Ubuntu. It turns out that ubuntu is missing the timezone setup and adding the following line to the docker file fixes the problem:
run DEBIAN_FRONTEND=noninteractive TZ=Etc/UTC apt-get -y install tzdata

Fixed in the docker code, but I'm not sure given this whether this is a bug in pyarrow or not  - the code I'm running is pretty simple and doesn't have a functional dependency on the local timezone, so I don't think it should fail if the timezone hasn't been set up, but I have to admit, it's pretty basic functionality.

I also encountered the same problem i don't know which dockerfile modify?


manual peak picking with optimize=true should also return width

i think a more natural behavior of optimize=true would be to also fit a shape to make it consistent with the automatic peak picking. This is also important for many techniques such as XPS or XRD where we actually also want to know the width of the peak. I.e., i would call https://github.com/mljs/global-spectral-deconvolution/blob/985d9aa4d539c2ccf5afd84c51b49d58037da5ac/src/post/optimizePeaks.js#L23 and not simply look for the closest min/max
what do you think @lpatiny

The width in the manual peak picking result ? I fully agree.

yes, i'd like to have the width in the manual peak picking to have an output that is interoperable with the one from automatic picking


Documentation improvements

I want to make a 'super issue' to track the progress.
I guess we should cover several topics:

The anatomy of the otel4s library (See #117)
How a library author can instrument a library. We can provide some guidelines (See #118)
How an end user can manually instrument a service (actually, it intersects with point 2)
How to collect OpenTelemetry metrics and traces by third parties: Honeycomb, Grafana, Jaeger, etc
How to customize OpenTelemetry: histogram customization, JVM metrics exporters, etc

Currently, I am thinking of the following structure:

Design notes:

[ ] Modules structure and dependencies (describe why have 10+ modules)

Instrumentation

[ ] Tracing
[ ] Metrics
[ ] Cross-service propagation

Customization

[x] Histogram custom buckets
[ ] JVM metrics exporter

Visualization (or exporting?)

[x] Jaeger - collecting traces
[x] Honeycomb - metrics and traces
[ ] Grafana Cloud - metrics and traces
[ ] Grafana + Prometheus - metrics and traces

What do you think @rossabaker @zmccoy @armanbilge?

Just came across this issue,  I had some spare time and made an example project using Grafana for metrics and traces here. Not sure if that's what you were expecting though as it still uses jaeger to store the traces, I could adapt the example by replacing jaeger by tempo, or even just storing traces in prometheus if that's better.
Let me know what you think !

It would be nice to cover OpenTelemetry + Prometheus too. Because a lot of systems are using Prometheus to collect metrics of Kubernetes cluster, for example.
For the simplest case, I was using https://grafana.com/docs/grafana-cloud/data-configuration/otlp/send-data-otlp/.

Just took a look at the link you sent me, this seem pretty specific to Grafana Cloud.
They got a free plan though, I'll try to find some time to update my code and adapt it to this use case :+1:

@keuhdall As you mentioned, the approach I sent above is suitable only for Grafana Cloud.
I believe we shouldn't change your code. A lot of people are using on-premise Grafana and Prometheus and your example fully covers this scenario.
I added Grafana + Prometheus - metrics and traces item to the list. So we can keep your example and add further documentation there.

I can probably still get rid of jaeger in order to push traces directly to prometheus though.
Should I make a PR to update the microsite with the example ?

It would be nice!
By the way, in the current example, the counter is recreated on every request https://github.com/keuhdall/otel4s-grafana-example/blob/79223a24c5b121ff2ef39726f2ef69e2fac5e644/src/main/scala/ExampleService.scala#L43-L45.
I assume it should be:
def apply[F[_]: Async: Tracer: Meter: Random](
  minLatency: Int,
  maxLatency: Int,
  bananaPercentage: Int
): F[ExampleService[F]] =
metricsProvider
  .counter("RemoteApi.fruit.count")
  .withDescription("Number of fruits returned by the API.")
  .create
  .map { counter =>
     new ExampleService[F] {
        ...
     }
  }

Oh nice catch! I'll update my code.
Also, I tried finding a way to export traces to prometheus, but it doesn't seem to be possible.
At best, spanmetrics can be pushed into prometheus, but not traces themselves.
I can either keep jaeger or try to replace it by tempo since it's also developed by grafana labs, let me know what you think is best.

I just added a tempo example on this branch. I'm not sure it's particularly useful to document this example in detail as it is pretty much the same as using jaeger when it comes to displaying traces in grafana (it's just a matter of choosing tempo as datasource instead of jeager).
I'll try making a PR during the coming week to update the documentation with the initial grafana / prometheus / jaeger example if that sounds good to you

For the JVM metrics, would we consider just linking to https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/runtime-telemetry ? That works perfectly, and does not require any agent on the side.

For the JVM metrics, would we consider just linking to https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/runtime-telemetry ? That works perfectly by just registering new instruments using the library, and does not require any agent on the side.
For Java 17: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/runtime-telemetry/runtime-telemetry-java17/library

Sounds good


Can't find the UI objects

Hi,
I can't manage to find the UI objects that come with TGPControls (i.e. TGPCamelLabel, TGPDiscreteSlider). I've been looking inside the object library, but none of them are there. Am I doing something wrong?

Same issue. It would be great if the readme explains this!

did you ever get an answer?

I was wondering the same thing as it's not stated in the Readme and I have not used custom UI components before.
Just drag a UIView in Interface Builder onto whatever it is you are building.  Then select that view and go to the Identity Inspector menu (the one that looks like a postcard).  Under Custom Class -> Class, select one of the TGP classes (TGPDiscreteSlider for example).  Now the UIView will show the preview and if you go to the Attributes Inspector menu (the one that looks like a shield) you can change it's properties.
Note, for all of this to work you of course need to installed the Pod and opened the .xcworkspace.


[Feature Request] registerDelayedCallback for tests

Is your feature request related to a problem? Please describe.
To write more efficient tests would be nice to support method like in other SDKs - registerDelayedCallback
Describe the solution you'd like
https://github.com/temporalio/samples-go/blob/main/updatabletimer/workflow_test.go#L24

That would be great, missing that also!


do not mark entrypoint as visited

as colly will mark entrypoint URL as visited, so it will not visit it again after restart the program, so I suggest do not mark the entrypoint URL as visited

You can turn on/off url revisit checking manually.


[Bug]: Allow autocompleting by FIRST and LAST name (skip MIDDLE)

Overview
If possible, allow both "John Quincy Adams" and "John Adams" to give you the autocomplete for "John Quincy Adams"

Duplicated with https://github.com/UTDNebula/utd-trends/issues/260 mb

Duplicated https://github.com/UTDNebula/utd-trends/issues/260 mb


data disk not mounted correctly.

maybe because the source code clone is before the mount?

fixed in https://github.com/Microsoft/kunlun/pull/34


Update annotations

We have already updated the new data dictionaries in https://github.com/neurobagel/openneuro-annotations
once. Every time we do, we should also update https://github.com/OpenNeuroDatasets-JSONLD/ now
to keep it in sync.

Closed by https://github.com/neurobagel/planning/issues/50


Pickup delivery

@JackDownsNZ please test this out

@JackDownsNZ there is a build failure in the front-end code - can you take a look please

Cool - tested and all works for me.

Since Joyce wants to hold these changes till the weekend, should we hold this PR until then? Or do you want me to hide my front end changes so we can push the api changes?

Let's just hold the PR. I may change my mind depending on what other changes get merged though

I'm abandoning this PR since it's been replaced with the new behaviour


a workable version on python3.7, fixed some bug

This patch seems to lose the ability to use pymodbus as a backend?


BREAKING: run zig fmt to catch deprecated @xToY builtins

This fix re-enables compiling with zig >= 0.11.0-dev.3771+128fd7dd0.

Thank you for this! Looks like I need to fix my tests for other changes in Zig, but I verified your changes locally.


Got about zero acc When validating resnet50_no_fusion

Training log is like below,  train_acc is around 1, but test_acc is 0, only used h36m dataset.
I also train the fusion model, but i got same train_acc and test acc
What happened? Is the model overfitting?
256_nofusion_2019-12-10-09-57_train.log

Can you help check if the saved debug images in the output'' directory are correct? In particular, the images with names validation_''.

I tried to run the noFusion experiment. The log of the first epoch is as follows:
Test: [0/1250]  Time 26.000 (26.000)    Loss 0.0133 (0.0133)    Accuracy 1.000 (1.000)
Test: [100/1250]        Time 0.212 (0.411)      Loss 0.0334 (0.0276)    Accuracy 0.971 (0.981)
Test: [200/1250]        Time 0.102 (0.274)      Loss 0.0252 (0.0288)    Accuracy 0.996 (0.981)
Test: [300/1250]        Time 0.107 (0.225)      Loss 0.0325 (0.0298)    Accuracy 0.978 (0.978)
Test: [400/1250]        Time 0.151 (0.201)      Loss 0.0421 (0.0301)    Accuracy 0.945 (0.976)
Test: [500/1250]        Time 0.158 (0.187)      Loss 0.0127 (0.0310)    Accuracy 1.000 (0.973)
Test: [600/1250]        Time 0.155 (0.178)      Loss 0.0169 (0.0298)    Accuracy 1.000 (0.975)
Test: [700/1250]        Time 0.112 (0.170)      Loss 0.0309 (0.0293)    Accuracy 0.985 (0.976)
Test: [800/1250]        Time 0.158 (0.165)      Loss 0.0288 (0.0291)    Accuracy 0.985 (0.976)
Test: [900/1250]        Time 0.092 (0.162)      Loss 0.0306 (0.0291)    Accuracy 0.989 (0.976)
Test: [1000/1250]       Time 0.143 (0.159)      Loss 0.0290 (0.0294)    Accuracy 0.978 (0.976)
Test: [1100/1250]       Time 0.156 (0.156)      Loss 0.0329 (0.0292)    Accuracy 0.985 (0.976)
Test: [1200/1250]       Time 0.119 (0.154)      Loss 0.0250 (0.0304)    Accuracy 1.000 (0.972)

Arch
root
rhip
rkne
rank
lhip
lkne
lank
belly
neck
nose
head
lsho
lelb
lwri
rsho
relb
rwri

256x256_multiview_pose_resnet_50_d256d256d256
1.000
0.983
0.966
0.910
0.987
0.947
0.686
0.990
1.000
1.000
1.000
0.917
0.816
0.776
0.928
0.797
0.725

I think there must be some mistakes in validate code, I trained and tested the nofusion model using the same data, I changed the multiview_h36m.py  line 98 [::5] to [::64], so that train and test data must be identical, but train_acc is high test_acc is low too.
my pytorvh version is 0.4.1, ubuntu is 4.15.0-69-generic.
Is there some difference between your local  respository and remote one?

I reclone the respository， it works properly now.
Thanks for your reply


Lab 3.4 - pwd explanation

Lab 3.4:
When speaking about the pwd command the example has the following location:
/home/pi/dockercon-blinkt/labs/3.4
It would be more helpful to have it pointed to /home/pi/blinkt/examples, as this is the location needed for mounting the directory.

Thanks


Roku and Mini Media player card showing 'No card type configured'

I have tried several times to install and set up these cards, including trying to restart hass and rebooting the whole system.
-->
Version of HACS 013.1 on Hassio 0.97.2

If you have issues with configuration of a card you need to ask the developer of that card.


Add raster layer gallery

cc. @gjmooney
Add a raster layer gallery using xyzservices.
Common sense would want to create a server endpoint for accessing the gallery items, I'm not taking this approach otherwise it would not work in the case of jupyterlite.
Remaining for this PR:

[x] Should we really commit the images or include them at build time?
[x] Missing attribution entry and some other raster layer parameters
[x] Make the layer gallery registry a plugin

A raster layer gallery sounds nice, but should it be implemented as a registry and populated by plugins?

A raster layer gallery sounds nice, but should it be implemented as a registry and populated by plugins?

Yeah definitely 👍🏽

I just have a tiny suggestion, then I believe this is looking good and we can merge!

Let's merge and iterate! Thanks Greg :)


To improve bottom in Login in page

Hey @QAZIMAAZARSHAD
As you can see the bottom class in Sign In page is not up to the mark .
I wish to work on this issue under LGM SOC '21

Do it for both login and sign up page.


HBase revisiting

Adding timestamp to the HBaseQueue and using current time to select items from the past.

Current coverage is 56.75% (diff: 100%)

Merging #186 into master will decrease coverage by 10.47%

@@             master       #186   diff @@
==========================================
  Files            70         70
  Lines          4404       4410     +6
  Methods           0          0
  Messages          0          0
  Branches        521        522     +1
==========================================
- Hits           2961       2503   -458
- Misses         1307       1796   +489
+ Partials        136        111    -25

Powered by Codecov. Last update 01886b4...83de57e

The reason for the current failure seems to be that the start-hbase.sh(in the hbase-docker repo) runs non-PY3 compliant code. As can be seen here the print statements lack parenthesis. I can either submit a PR there or we can use a forked version.

@Preetwinder the project looks abandoned, let's fork it under scrapinghub, and then fix this fork. I'll arrange the public fork.

@Preetwinder please submit a PR here https://github.com/scrapinghub/hbase-docker and let's setup everything to make docker images pulling from using this repo.


add reference for modeling stakeholder needs

add reference for modeling stakeholders & concerns, as per page 40-42 of "Architecting Spacecraft with SysML: A Model-Based Systems Engineering Approach".

closing, as https://github.com/Mach30/m30ml#stakeholder-need is already derived from a reference for stakeholder modeling


Use 'delegate' methods to update GUI

The methods executed from Acws events call GUI updating methods.
Since 5ebdc2f, those four methods checks if Invoke are required and wrap the methods it is supposed to call inside 'Invoke' in a pretty awful way.
The idea would be to correctly use delegate methods to clean the repeated lines of code.

Fixed in b40bc2a
Just used a method that is called by the four callback methods. This method is wrapped in an Invoke if necessary. This allows to focus on a single method if changes are needed.


DevTools: Two new imported DevTips

This also fixes a small issue with the Admin Importer, making the match of what tips where already posted a little more fuzzy (slash vs. no slash at end of original source url) so they don't reappear in the importer.
@petele since this isn't original content, I'm unsure whether the instruction of getting a lgtm from a writer applies here as well. Thoughts?

@pbakaus - yes, you still need an LGTM, even if it's not original content. We also should make sure that we have a CLA on file for Umar.

Again, will merge today, but this'll be the last time ;)

OK thanks for the clarification. Will get a writer on to it next time!


[Bugfix] Update Dict Types | Documentation | Protocol Implementation

This PR:

makes some minor adjustments to the dictionary type casting
updates documentation to Xcode 8 standards
shifts the protocol implementations of Adobe.swift and mParticle.swift into the main class

Addresses issues: Issue #25 Issue #26

In response to the discussion in Issue #26, changes to extension implementations have been reverted (out of the main class), as well as reverting open back to public for classes and functions


Generalized array generation (including capacitors) in align.primitive

Caps are a somewhat weird beast as of now since there is custom code to generate capacitor array primitives as part of PlaceRouteHierFlow. In the long run, we may want to additionally support the creation of inductor arrays & arrays of arbitrary pcells as well.

Same as in #290 and #204.


#2421 - Add terminology clear-cache operations

The terminology subsystem caches terminology resources by URL and/or URL + version. If the user tries to update a CodeSystem or ValueSet resource keeping the same URL + version, the cache does not get cleared and some operations (e.g. validate-code) do not return the expected results after update. This change adds an operation ($clear-cache) that can be called on either terminology resource and will clear the appropriate caches.
Signed-off-by: Corey Sanders<EMAIL_ADDRESS>

@csandersdev Per our discussion and given the general feedback that I received from the team, this is a low-level function that addresses a very specific requirement and should not be packaged with the FHIR server by default. Since it is currently part of the fhir-operation-term module it will need to be broken out into a separate project so that it can be built and packaged as an "add-on".

@JohnTimm How about /add-ons/fhir-operation-term-cache? Do you have an opinion on what we should do with the integration tests in fhir-server-test after the move? There isn't a ton of code that I'm using there, but I would hate to duplicate.

@JohnTimm How about /add-ons/fhir-operation-term-cache? Do you have an opinion on what we should do with the integration tests in fhir-server-test after the move? There isn't a ton of code that I'm using there, but I would hate to duplicate.

I assume that the /add-ons folder would live under the existing operation folder. As for the integration tests I think we can include it in the build automation so they get executed but exclude it from the default FHIR server packaging. @prb112 any thoughts on this?

@JohnTimm How about /add-ons/fhir-operation-term-cache? Do you have an opinion on what we should do with the integration tests in fhir-server-test after the move? There isn't a ton of code that I'm using there, but I would hate to duplicate.

I assume that the /add-ons folder would live under the existing operation folder. As for the integration tests I think we can include it in the build automation so they get executed but exclude it from the default FHIR server packaging. @prb112 any thoughts on this?

Let's leave in /operations
Let's update /README.md to indicate that this is an addon and the description.
Let's update https://github.com/IBM/FHIR/blob/main/build/docker/copy-test-operations.sh to copy the test operation
Let's update automation to copy the operation

https://github.com/IBM/FHIR/blob/main/build/persistence/postgres/pre-integration-test.sh#L66
https://github.com/IBM/FHIR/blob/main/build/notifications/kafka/pre-integration-test.sh#L40
https://github.com/IBM/FHIR/blob/main/build/audit/kafka/pre-integration-test.sh#L41
https://github.com/IBM/FHIR/blob/main/build/pre-integration-test.sh#L76
Let's update

@prb112 Is your expectation that the operation classes for the new module all live under src/test/java? If that is the case, is there any reason why we wouldn't just keep them in fhir-operation-term and move them from main to test and then make the rest of the script changes you recommend above for the fhir-operation-term module?

@prb112 Is your expectation that the operation classes for the new module all live under src/test/java? If that is the case, is there any reason why we wouldn't just keep them in fhir-operation-term and move them from main to test and then make the rest of the script changes you recommend above for the fhir-operation-term module?

Is the purpose test/dev only? If so, we'll mark it as test/dev only, and still treat this separately.
We'll also add fhir-operation-test-term-clear-cache as the name.

Is the purpose test/dev only? If so, we'll mark it as test/dev only, and still treat this separately.
We'll also add fhir-operation-test-term-clear-cache as the name.

No. Given current constraints, I expect IHE to use these operations in a production setting. I was just trying to reconcile your suggestion of copying the test artifacts. I don't have anything under src/test/java right now. I'm not clear on why I would need those steps of copying the -tests.jar unless my stuff lived under the test tree.

Is the purpose test/dev only? If so, we'll mark it as test/dev only, and still treat this separately.
We'll also add fhir-operation-test-term-clear-cache as the name.

No. Given current constraints, I expect IHE to use these operations in a production setting. I was just trying to reconcile your suggestion of copying the test artifacts. I don't have anything under src/test/java right now. I'm not clear on why I would need those steps of copying the -tests.jar unless my stuff lived under the test tree.

I believe that he is suggesting test jars so that they get deployed with the server such that you can still run integration tests. This is exactly what we do with fhir-operation test.

I've started a direct message to clarify.

I resolved the DCO manually.

@csandersdev The latest build failure is due to the fact that we upgraded to v2.0.1 of the JSONP reference implementation and they changed their package name prefix from javax.json to jakarta.json.


a fix for TextColmun

creating TextColmun returns undefined variable $getLineClamp, this pull request fixes that

Thank you for PR

Thanks for contribution!


It's time to build for Noble too

Hi,
Noble (24.04) is now available for some time, 23.10 users are now being offered the option to upgrade to Noble and likely in August Jammy users will also, so probably this is the time to have a build for having a build for Noble, to have the help of users of 23.10 to test and smooth wrinkles for LTS users.

Hello I am wondering what needs to be done to make this work on 24.04?


Vertical Point Stack Issue in Potree Converter but not in QTReader

So I have a .las file just under 200 MB. This is what happens when I try converting it:

However, if I take the same file and put it into QTReader, I get something actually meaningful:

Has anyone had this issue before, or know why Potree Converter isn't able to properly understand where the points should be going? Thank you for your help.

The coordinates are likely stored in latitude and longitude.
PotreeConverter only supports euclideon coordinates.

Is there any way to convert them into euclideon coordinates? Another program?

I think you could give Proj4 a try (http://proj4.org/). I never used it but it reads it allows you to do just what you want to do. Of course you should know anything about reference systems and projections. Otherwise, you could project your data using a Geographic Information System (GIS).

Well the goal is to put it online. I am not the most well versed in this sort of thing. What do you mean by 'project' my data using GIS?
Also I installed it just fine, but I'm not sure what settings I would use to convert it. I'm fairly certain I need it to stay as a .las file for PotreeConverter to work, but I'm not sure what option would convert between lat/long and euclideon coordinates.

Well, this could be quite simple or super tuff depending on your knowledge of spatial data and reference systems. One example of conversion from lat/long coordinates to euclidean (not euclideon) ones is inside the potree repository itself (https://github.com/potree/potree/blob/master/examples/openLayers3.html). You can set a spatial reference for .las which are fine to be used in potree (but you can use other formats as well).
With "project" I mean exactly converting from one spatial system to another (e.g. from a geographic coordinate (lat/long) system as WGS84 to a projected one (e.g. in metric units) such as UTM. This means going from a 3d (geodetic) system to a 2d (planimetric or EUCLIDEAN) system. To do this you could use a software (like a GIS) which could read your point cloud (in .las format or others), read its spatial system and converting to the new planimetric one. Finally, in the example I provided, they're using Proj4 to do this without using a GIS, but as I said I cannot tell you exactly how it works.

It does seem that there is a way to use Potree to convert, after looking over the information in the openLayers3 file. The only thing is, I'm not sure how to call it. This is the command that I use normally:
PotreeConverter.exe C:/Aqueduct.las -o C:/xampp/htdocs/potree --generate-page pageName2 --overwrite
Do you know what command I need to add to work with openLayers3? I've tried messing with the projection, the type of input, the type of output, but nothing changes. What I find odd about the projection parameter is that I can seemingly put anything in there and it doesn't throw an error.

Unfortunately, you can't convert a point cloud with lat/longcoordinates at all.
You'll first have to convert your las with lat/long coordinates to a las with euclidean coordinates.
I'm not sure how to do that, though. Maybe with lastools las2las.exe?
You could also try CloudCompare but I think it will also show the point cloud as a vertical line.
The reason this happens is because x and y are stored as lat/long, which are very very small numbers, but height is stored in meters which is a lot larger. Since the height in meters is so much larger than lat/long, you'll get to see a vertical line.

Well, I tried every conversion combination I could think of with las2las. All it really did was move the line away from the center, but nothing substantial other than that. It's highly likely I'm using the program incorrectly, though it does not appear to be the most user friendly (certain selections go off screen and you can't scroll to it for some reason?). Thank you for your help so far, I definitely understand this more than I did before. Unfortunately I'm not sure if I can figure this out.
List of things I've tried: transformation (translate, scale), projection(several combinations to and from lat/long). Maybe it's just me, but it's not terribly clear if the projection on the left is what the program is expecting, and that the projection on the right is what you're trying to change it into, or something else.

Did you generate your point cloud with photoscan? As far as I remember you can choose whether to export it in lat/long or euclidean coordinates .

first, you can find the precision of you lon/lat data, than ,you can multiply a factor to you latitude to make sure the three value have a same precision, for example,  the lon/lat data range is 0.002 degree  and the lat data range is 500 meter , so you can multiply 0.000004 to all lat data. just a idea!


Add path to certs and routes

spec:
host: fom-test.nrs.gov.bc.ca
path: /api
More details https://github.com/bcgov/nr-fom/issues/608

Resolved by #44


[SDL2] Fixed detection of FLAC files with ID3 tag at begin

Recently I found that some FLAC files won't play at all. I had checked, and I found it begins with an ID3 tag. Also, I checked around the stuff, and it's not a paranomrmal mess of Audacity: it's one of legacy forms of FLAC files that used ID3 tags at begin.
There is a comment where I explained about this a first time: https://github.com/WohlSoft/SDL-Mixer-X/commit/94e87503c80cc0311dfedb370e21d25573492e33
Example file (I exported it in 2019'th year by the old version of Audacity): Fox fantasy.mid-battle-chess-gmized.flac.zip

Wait for https://github.com/libsdl-org/SDL_mixer/pull/527 to be reviewed / merged, first.

I'll completely remake THIS after SDL3 version will get it's final variant and gets merged.


Build with Bazel

I've created BUILD files for building closure-compiler with Bazel, and was wondering whether you'd be open to adding them in this repository?
/cc @robfig @sgammon

Created internal issue - http://b/140446397

Can you put together a PR, we do build with Bazel internally to Google, but I expect the external rules could be much simplier than specialized rules we have built up over the years.

Externs will require https://github.com/bazelbuild/rules_pkg/pull/65


Add ps prefix to run script here for compute cause we don't want it i…

…n the head node case

Looks good


ceph_volume: add container support for batch

https://tracker.ceph.com/issues/36363 has been resolved and the patch
has been backported to luminous and mimic so let's enable the container
support.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1541415
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

How does CEPH_CONTAINER_IMAGE get set? Is this something an operator will need to set manually if they want to use containers and ceph-volume?
Do we have any CI tests that exercise batch in containers?

@andrewschoen here https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-osd/tasks/scenarios/lvm-batch.yml#L16, we do, but triggering them will fail for the reasons mentioned recently.

@andrewschoen here https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-osd/tasks/scenarios/lvm-batch.yml#L16, we do, but triggering them will fail for the reasons mentioned recently.

@leseb I added the lvm_batch_container scenario here: https://github.com/ceph/ceph-build/pull/1177/files#diff-9f359904db703ec24f8844ccf1380133R100
If that's merged could we trigger them manually with dev packages from shaman? We have a container being built from ceph@master now right?

jenkins test dev-lvm_batch

jenkins test dev-lvm_batch_container

The ceph version inside the container is ceph version 13.2.2 (02899bfda814146b021136e9d8e80eba494e1126) mimic (stable), which is why the container tests failed. We'll need to update some config for these test to pull the container built from master right?

I was able to run a test with the latest-master tag, but it looks like the mon container is failing to come up. https://2.jenkins.ceph.com/job/ceph-ansible-scenario/386/console

@andrewschoen yeah we need https://github.com/ceph/ceph-ansible/pull/3262 so we can fetch the right container image.

Yes, I need to merge this https://github.com/ceph/ceph-container/pull/1215/commits/2595f71779911c83611310305ef3af45dc737704, but first I need to cut the PR a bit.

jenkins test dev-lvm_batch

jenkins test dev-lvm_batch_container

jenkins test dev-lvm_batch_container

jenkins test dev-lvm_batch

jenkins test dev-lvm_batch

jenkins test dev-lvm_batch

jenkins test dev-lvm_batch_container

jenkins test luminous-docker_cluster

jenkins test luminous-ooo_collocation

jenkins test luminous-docker_cluster_collocation

jenkins test luminous-centos7_cluster

jenkins test luminous-docker_cluster

jenkins test luminous-docker_cluster

jenkins test luminous-centos7_cluster

jenkins test luminous-docker_cluster_collocation

jenkins test luminous-ooo_collocation


Too many airdrops error

The issue I have here is the following error:
Process error: Client error: You have requested too many airdrops. Wait 24 hours for a refill.
Even if you just enter the playground in the browser and do "connect", and right after "solana airdrop 2". This is the error I get, I have tried this with 2 different computers in 2 different locations there seems to be some type of an issue when it comes to requesting airdrop as it will happen even if it is your first time entering the site, so far i have not been able to get any type of airdrop. I am sure it would be better to just play around with Solana playground on my local machine, however I believe that misses the point of having an accessible browser based Solana IDE. If there is another issue related to this feel free to close it and direct me there. Thank you.

Even if you just enter the playground in the browser and do "connect", and right after "solana airdrop 2". This is the error I get, I have tried this with 2 different computers in 2 different locations there seems to be some type of an issue when it comes to requesting airdrop as it will happen even if it is your first time entering the site, so far i have not been able to get any type of airdrop

You might get this error even if you haven't manually requested airdrop yourself because the playground automatically requests airdrop if you don't have enough funds. Airdrops are also heavily rate-limited unfortunately.

I am sure it would be better to just play around with Solana playground on my local machine, however I believe that misses the point of having an accessible browser based Solana IDE.

If you can just run solana-test-validator, you can connect to your local validator from playground which doesn't have these limitations.

If there is another issue related to this feel free to close it and direct me there.

We've just been talking about airdrops in https://github.com/solana-playground/solana-playground/issues/261

yeah but even if it autorequests it, it does not show up. Where is the code related?

Nevermind I just see in the issue you listed that it is being worked on, I will move it there.


meta-dts-distro/recipes-dts/dts/dts/dts-functions.sh: Fix MSI Z790-P …

…DDR4 board matching

@miczyg1 IIUC this was not tested and we do not have needed platforms to test it?

@TomaszAIR right. But someone on Matrix confirmed it worked just now.

Merged to develop, will release in v1.2.19


Gradle Support for 1.3.10 and above

I'm getting this error while building the app.
FAILURE: Build failed with an exception.

What went wrong:
The Android Gradle plugin supports only Kotlin Gradle plugin version 1.3.10 and higher.
The following dependencies do not satisfy the required version:
project ':flutter_p2p' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.71

I got the same error too, I tried downgrading ext.kotlin_version to 1.2.71 as per the p2p package, it still does not build successfully.

Any update on this?
Looks like development is discontinued

@SupremNandalDev , I was able to get it to compile and install successfully after downgrading kotlin to 1.2.71. Just make sure to close and re-open Android studio for it to take effect. I am able to establish a successful p2p connection between my two devices to send data using this package.


Provide actual buttons on keypad module. Closes #4

Coverage increased (+0.1%) to 33.784% when pulling 7a1d369d796ee2f913a629ee93d0283f3f650e08 on feature/keypad_buttons into 3c948ca3cadfae30f7c3ae918a590adb11ca41aa on develop.

Coverage increased (+0.1%) to 33.784% when pulling 7a1d369d796ee2f913a629ee93d0283f3f650e08 on feature/keypad_buttons into 3c948ca3cadfae30f7c3ae918a590adb11ca41aa on develop.


Optimize large/slow database tables

Some of the etl-queries tables are pretty big now, particularly challenge_receipts_parsed
Easy things might be tuning indexes. That one has both address and name for witness and transmitter, could just be address and always use subselects for names
Would more recent postgres versions or alternate database storage solutions help with others?
Related here is the pg_stat results on old DeWi ETL:
https://etl.dewi.org/question/117-slow-queries-pg-stat-statements + xlsx dump
query_result_2021-08-07T10 45 38.985426-04 00.xlsx
Here are all table sizes
select table_name, pg_relation_size(quote_ident(table_name))
from information_schema.tables
where table_schema = 'public'
order by 2 desc;

          table_name           | pg_relation_size
-------------------------------+------------------
 gateways                      |<PHONE_NUMBER>64
 transactions                  |<PHONE_NUMBER>6
 transaction_actors            |<PHONE_NUMBER>0
 challenge_receipts_parsed     |<PHONE_NUMBER>6
 rewards                       |<PHONE_NUMBER>0
 challenge_receipts_parsed_old |<PHONE_NUMBER>8
 accounts                      |<PHONE_NUMBER>
 gateway_inventory             |<PHONE_NUMBER>
 packets                       |<PHONE_NUMBER>
 block_signatures              |<PHONE_NUMBER>
 gateway_status                |<PHONE_NUMBER>
 dc_burns                      |<PHONE_NUMBER>
 validators                    |<PHONE_NUMBER>
 account_inventory             |        282730496
 blocks                        |        182550528
 validator_inventory           |        176136192
 validator_status              |         99999744
 locations                     |         42696704
 spatial_ref_sys               |          4694016
 stats_inventory               |          1777664
 oracle_prices                 |           786432
 ouis                          |           360448
 vars_inventory                |           204800
 oui_inventory                 |            57344
 oracle_inventory              |             8192
 oracle_price_predictions      |             8192
 cheatnets                     |             8192
 __migrations                  |             8192

I would suggest 2 things, before going into index tunning: timescaledb extension and table partitioning. I found these 2 to be more helpful with big tables, than indexes which are also growing in size as time passes.


Add a message saying what the winning hand was

Currently when someone wins, the only message is "player/opponent wins". Make that screen say something along the lines of "Opponent/Player won: Flush beats Ace high."
Est~50-100 pts

F16 OK (200 pts)


Player changed today?

I just noticed the whole player has changed to a different format. Here's a screenshot showing that new format. The one thing I noticed is that 40px are lost from the video height due to the expanded player controls, meaning that setting the player to 1280x720 will actually created 1280x680 player, clearly out of proportion.
It's an interesting player. I did manage to get rid of it by deleting the VISITOR info cookie, which reverted it to the previous styling. The reason I don't like this new one is the fact everything is super large, as though everyone is blind to notice things.
Main question: will YT Center be able to compensate the 40px height loss in the new player?

It does seem like YouTube has started rolling out a new player to some people... But if I leave youtube center (build 507) active I get this:

Both of you are getting the transparent player which is still incomplete and is most likely having conflicts with YTC. If you want to opt-out you can do it via this link: https://www.youtube.com/testtube
And click on the "Restore original player" button.

Errmm, I can't see/found the "restore original player" button.

Try deleting all cookies set by YouTube. In the past YouTube has used cookies to track whether a user has an experimental player or layout.
In Chrome, you can do this by going to Settings -> Privacy -> Content settings... -> Cookies -> All cookies and site data... and searching for "youtube.com".

@Zarggg You can't get rid of it via the cookies either? Can't believe they are forcing a feature that is still under testing.

No, removing cookies did restore the regular player for me. I just thought it was amusing/ironic that I got the new one shortly after posting on this issue.

I believe the cookie that YT uses to track people is the VISITOR_INFO1_LIVE cookie. Simply deleting that one will remove any tracking data and give you a plain cookie.
 It's like they think I'm blind and that I won't notice whether a video is paused or not >_>


Improve number parsing

https://github.com/sindresorhus/query-string/pull/241

@sindresorhus  I went through this #241 pr and did a few tests and there was no issue regarding number parsing actually, I tried everything and could not re-create anything related to that issue stated by on that pr.
What I did found is that he was probably running some test cases and the key of the expected value was not in quotes meaning he was probably testing it as a number so when running the tests the compiler treated it as a number just like it should.
If you run the following test, it will recreate that issue and generate an error saying the expected value is<PHONE_NUMBER>0000 since the expected object key is a number which is true.
test('handle number pusring correctly with math operands', t => {
	t.deepEqual(queryString.parse('192e11=bar'), {192e11: 'bar'});
});

But when you add the quotes to the expected object key and turn it into a string then the tests work fine. So basically there is no such issue regarding number parsing.

I was not able to re-create this issue!
Both of the following works just fine as it should be.
queryString.parse('192e11=bar')
//=> {'192e11' : bar}

queryString.parse('bar=192e11')
//=> {bar : '192e11'}

Did misunderstood the issue ?
// @sindresorhus

How about stringify?

But that's good. Then this issue is just about submitting some tests to confirm the existing behavior.

@sindresorhus stringify is working too. I think his pr was kind of misleading cause here is an assumption on what he probably did.
He probably created a test such as
	t.deepEqual(queryString.parse('192e11=bar'), {192e11: 'bar'});

and left the expected key as a number, not as a string and therefore when he ran the test it threw an error saying that it is expecting<PHONE_NUMBER>000000000000000 as it should since it is expecting a number.
But yeah not issue on the module. I can write some tests on that later if needed!

I can write some tests on that later if needed!

That would be amazing 👍🏻


Create and open

No longer seems to work with a new vault I created. Note is created, it is just not opened.

+1

+1

Should be fixed in dev, with new option to open in tab as well.


nfsserve: init at 25d9f98

Description of changes
Packages up https://github.com/xetdata/nfsserve, which is an (admittedly early) implementation of an NFSv3 server in Rust.
Considering adding a module for this, but there is no configuration for the application at this point. This will just get things started.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closing as upon further investigation the demo server provided doesn't interact with the actual filesystem but rather a dummy one, rendering this package more or less useless?
Happy to reopen if this changes or another project/fork extends it.


SQL RP compatibility with 1902 update

[Enter feedback here]
Hello.
The current latest SQL RP requires:
Use-AzureRmProfile -Profile 2018-03-01-hybrid
Install-Module  -Name AzureStack -RequiredVersion 1.5.0
The core Azure Stack 1902 release requires:
Install-Module AzureRM -RequiredVersion 2.4.0
Install-Module -Name AzureStack -RequiredVersion 1.7.0
Please advise when a new SQL RP will be made available for the 1902 build.
Here is the error:
Azure Powershell Module with 2.4.0 version found. Need Azure powershell compatible with stack. Use ArmProfile 2018-03-01-hybrid. Please uninstall the current version and rerun the RP setup

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31804a1d-4c4f-70e6-556c-66c533e9b3e3
Version Independent ID: cbdb8c6f-ad4d-9e3d-a490-f1348b5ccdfa
Content: Using SQL databases on Azure Stack
Content Source: articles/azure-stack/azure-stack-sql-resource-provider-deploy.md
Service: azure-stack
GitHub Login: @jeffgilb
Microsoft Alias: jeffgilb

@rfsonders I'm following up on some issues. I wanted to find out if this was still an issue? Thanks, Matt #in-progress

Thanks for feedback! @rfsonders
The online document is correct. SQL/MySQL RPs do version check at the beginning of installation. The later released version of PowerShell profile/module may include some breaking changes which could cause the deployment failure of database RPs.
In future release of SQL/MySQL RP, it would support the latest version of PowerShell profile then. But for the current released versions of RPs, user need to install the required versions of profile and module.
https://docs.microsoft.com/en-us/azure-stack/operator/azure-stack-sql-resource-provider-deploy#deploy-the-sql-resource-provider-using-a-custom-script

@rfsonders Thanks again. Can you let me know if you have any additional questions. #please-close

Hey guys, this appears to still be an issue. whats the ETA here?


Using a linter

Not an issue, just a question. I'm trying to learn from your code. It seems clever and very clean.
What linter (settings) are you using to pass your store.js export const dispatchToken = register(({action, data}) => {
With JSHint esnext=true I get an "Unexpected token =>". Plain arrow functions are ok. It's the arrow in combination with the destructuring that doesn't pass apparently.
Also I noticed that files like dispatcher.js you are missing () for a constructor and are using != instead of !==. Is this your choice for some reason or did they just slip by because you're using more relaxed linter settings? I'm just curious, because you seem to code by your own standards, omitting semicolons ;) But I like that if there's a good argument for doing it. In the case of semicolons I agree with you.

I don't like JSHint. Douglas Crockford is... opinionted. I'm waiting for Eslint,  http://eslint.org/blog/2015/03/eslint-0.17.0-released/ was already released, but I will give it two weeks to polish isuess, and then I will add it into project.
As for "Unexpected token =>", that's probably some yet another Crockford weirdness.
As for !=, that's ok too. === everywhere is soo jQuerish.
Yes, writting ;;;;;;;; everywhere is mannerism :-)
Eslint will be added soon.

You seem pretty opinionated yourself :-) I don't get what === has in to do with jQuery. I believe Crockfords rules are jslint, but jshint is more relaxed and community driven. It has served me well, but eslint looks promising.
Thanks for sharing your code.

As for === jQuery, as I remember, it was mantatory for everything.
As for jshint/jslint, sorry I was tired :-) Feel free to suggest everything what can improve Este, I'm open to almost anything.

I actually think Este & linting is a bit of a unique situation. Usually I don't care what code style my dependencies use because they live by themselves in node_modules. Their code is completely independent of my own.
But the nature of Este being a project base means that Este code lives side by side with own code. This makes things awkward when Este style clashes with my own style.
Originally I edited Este code to conform to my existing lint settings. But that makes trying to merge in useful changes from upstream Este a huge pain. So now I'm trying to leave Este files relatively untouched, so I can benefit from new stuff in Este. Of course this makes linting not consistent.
For this reason I'd prefer if Este were less opinionated about code style. I'd prefer if it linted cleanly with eslint default settings, instead of trying to push its own style opinions on my project.
Note that I'm not claiming eslint default settings are "better" than este style in any way. I'm just claiming that default settings are likely to be shared by many people. The further away from this default settings that este gets, the more trouble people have to go through to keep synced.
I like that este has opinions about app architecture, but I think it'd be more effective at spreading these architecture opinions if it didn't also try to push its relatively unique code style opinions :smile:
So, my friendly suggestion is to consider trying to keep este style as close as possible to eslint default settings.

+1, what he said :smile:

It's all and nice and I agree with you, except one thing. I really don't want write ; for sake of mannerism. There is no reason to write ; after almost (which one exactly?) line.

I'm not going to try to defend semi-colons; I'm only interested in making it as easy as possible to integrate with este. I'm happy you agree with my overall point, even if your distaste for semi-colons is perhaps a stronger feeling :wink:
Thanks for considering this @steida! :smile:

@steida Thanks for making your code a bit more standardized. I love the current structure. And you convinced me to move back to plain Flux :smile:


Security_Log_Profile - unexpected provisioned module requested

Environment

Application Services Version: 3.16
BIG-IP Version: 15.0.101000
Lic: Best Bundle
Provisionned modules: ltm, asm, avr

Summary
Use Case: define a shared Application Logging Profiles for Application Services
First deployment: OK
A further deployment without any change in the declaration: error caused by "One of the following features must be licensed/provisioned for the URI security/log/profile/network : afm em"
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
    "class": "AS3",
    "persist": true,
    "declaration": {
        "class": "ADC",
        "schemaVersion": "3.11.0",
        "Common": {
            "class": "Tenant",
            "Shared": {
                "class": "Application",
                "template": "shared",
                "asm_log_bigiq": {
                    "class": "Security_Log_Profile",
                    "application": {
                        "storageFilter": {
                            "requestType": "illegal-including-staged-signatures"
                        },
                        "localStorage": false,
                        "maxEntryLength": "10k",
                        "responseLogging": "illegal",
                        "protocol": "tcp",
                        "remoteStorage": "bigiq",
                        "reportAnomaliesEnabled": true,
                        "servers": [
                            {
                                "address": "<IP_ADDRESS>",
                                "port": "8514"
                            }
                        ]
                    }
                }
            }
        }
    }
}

Observe the following error response:

{
    "results": [
        {
            "message": "failure querying config for tenant Common (GET http://admin:XXXXXX@localhost:8100/mgmt/tm/security/log/profile/~Common~Shared~asm_log_bigiq/network?$filter=partition%20eq%20Common getting BIG-IP config response=400 body={\"code\":400,\"message\":\"One of the following features must be licensed/provisioned for the URI security/log/profile/network : afm em\",\"errorStack\":[],\"apiError\":1})",
            "host": "localhost",
            "tenant": "Common",
            "code": "ERR_REQUEST_FAILED"
        },
        {
            "code": 200,
            "message": "no change",
            "host": "localhost",
            "tenant": "Common",
            "runTime": 809
        }
    ],
    "declaration": {
        "Common": {
            "Shared": {
                "class": "Application",
                "asm_log_bigiq": {
                    "application": {
                        "protocol": "tcp",
                        "maxEntryLength": "10k",
                        "storageFilter": {
                            "requestType": "illegal-including-staged-signatures",
                            "logicalOperation": "or"
                        },
                        "servers": [
                            {
                                "port": "8514",
                                "address": "<IP_ADDRESS>"
                            }
                        ],
                        "localStorage": false,
                        "reportAnomaliesEnabled": true,
                        "remoteStorage": "bigiq",
                        "responseLogging": "illegal",
                        "facility": "local0",
                        "guaranteeLoggingEnabled": false,
                        "guaranteeResponseLoggingEnabled": false
                    },
                    "class": "Security_Log_Profile"
                },
                "template": "shared",
                "enable": true
            },
            "class": "Tenant"
        },
        "class": "ADC",
        "schemaVersion": "3.11.0",
        "id": "autogen_eabe89af-1f45-4432-8a0f-52732deb4a37",
        "updateMode": "selective",
        "controls": {
            "archiveTimestamp": "2019-12-28T20:34:06.653Z",
            "class": "Controls",
            "logLevel": "error",
            "trace": false
        }
    },
    "code": 207
}

Expected Behavior
"code": 200, 202
Actual Behavior
"code": 400

I am unable to reproduce this issue with the steps provided.
BIG-IP version:
Sys::Version
Main Package
  Product     BIG-IP
  Version     <IP_ADDRESS>
  Build       0.0.3
  Edition     Point Release 1
  Date        Mon Nov 18 11:30:00 PST 2019

Module provisioning:
sys provision afm { }
sys provision am { }
sys provision apm { }
sys provision asm {
    level nominal
}
sys provision avr {
    level nominal
}
sys provision cgnat { }
sys provision dos { }
sys provision fps { }
sys provision gtm { }
sys provision ilx { }
sys provision lc { }
sys provision ltm {
    level nominal
}
sys provision pem { }
sys provision sslo { }
sys provision swg { }
sys provision urldb { }

AS3 version:
{
    "version": "3.16.0",
    "release": "6",
    "schemaCurrent": "3.16.0",
    "schemaMinimum": "3.0.0"
}

Is there any additional information you can provide to help me reproduce this issue?

Closing for inactivity. If you are still encountering issue, please reopen this ticket for a file a new one.


Extractor loading -- directory with extractor objects or upper level directories

I'm cleaning a few outstanding issues that have been fixed, @Borchardt can you advise whether this is currently fixed?


Context mutations in it blocks leak into sibling describe blocks

When a describe block has inner describe blocks, as well as immediate it blocks, the this context of the immediate it blocks leak to the tests in the inner describe blocks.

"tests should not leak to sibling describe blocks" - Fail (expected: Pass) :x:

describe("asdf", function () {
  describe("inner 1", function () {
    it("works", function () {
      if (this.foo) {
        throw new Error('foo should not exist');
      }
    });
  });
  it("setting foo", function () {
    this.foo = true;
  });
});

In addition, when a describe block has inner describe blocks, as well as immediate it blocks, all in the context of some parent describe block with a beforeEach, the this context of the immediate it blocks leak to the tests in the inner describe blocks, overriding the top level beforeEach!

"tests should not leak to sibling describe blocks when a higher beforeEach exists" - Fail (expected: Pass) :x:

describe("asdf", function () {
  beforeEach(function () {
    this.foo = false;
  });
  describe("inner", function () {
    describe("superinner 1", function () {
      it("works", function () {
        if (this.foo) {
          throw new Error('foo should not exist');
        }
      });
    });
    it("setting foo", function () {
      this.foo = true;
    });
  });
});

Interestingly, when beforeEach is sibling to the it block and the inner describe block, mocha works as expected: the context mutation doesn't override the beforeEach.

"tests should not leak to sibling describe blocks when a sibling beforeEach exists" - Pass (expected: Pass) :white_check_mark:

describe("asdf", function () {
  beforeEach(function () {
    this.foo = false;
  });
  describe("inner 1", function () {
    it("works", function () {
      if (this.foo) {
        throw new Error('foo should not exist');
      }
    });
  });
  it("setting foo", function () {
    this.foo = true;
  });
});

(TL;DR at/after the "what would be particularly helpful" line)
If I recall correct from the last time I looked into this (pun intended), Mocha goes out of its way to make this in tests and hooks behave like local variables in the suite callbacks with something equivalent to suite-level shadowing on assignment. That is, these examples should be equivalent to:
describe("asdf", function () {
  describe("inner 1", function () {
    it("works", function () {
      if (foo) {
        throw new Error('foo should not exist');
      }
    });
  });
  var foo
  it("setting foo", function () {
    foo = true;
  });
});

-
describe("asdf", function () {
  var foo
  beforeEach(function () {
    foo = false;
  });
  describe("inner", function () {
    describe("superinner 1", function () {
      it("works", function () {
        if (foo) {
          throw new Error('foo should not exist');
        }
      });
    });
    var foo
    it("setting foo", function () {
      foo = true;
    });
  });
});

-
describe("asdf", function () {
  var foo
  beforeEach(function () {
    foo = false;
  });
  describe("inner 1", function () {
    it("works", function () {
      if (foo) {
        throw new Error('foo should not exist');
      }
    });
  });
  it("setting foo", function () {
    foo = true;
  });
});

I'm not saying this is a good design -- if nothing else it seems (almost) entirely redundant given you can achieve the same behavior without this at all (except in the exports interface I guess? do people want that exact behavior in the exports interface?)... But I am saying these examples aren't necessarily bugs, unless I missed a design document specifying different behavior.

What would be particularly helpful to us is:

A proposed specification for a different design (beyond the level of just a few examples)
Discussion of what testing patterns or methodologies the proposed design enables and how difficult they are to achieve without it (e.g. can it be achieved with suite-local variables without significant downsides, can it be achieved by calling some parameterized helper functions without significant downsides, etc.)
Comparison to the behavior/design of this in test runners with interfaces similar to Mocha for mutual compatibility purposes (whether we'd be getting closer to or farther from similar test runners may have some influence on whether a new design is seen as worth the inevitable breakage in addition to the intrinsic merits of a given design)

(I've actually looked at a proposal earlier this year about either changing the behavior of this or adding something to achieve a slightly different behavior that has some advantageous uses, but I haven't got back around to the comparing with other test runners yet, which I wanted to do before revisiting the proposal.)

Hi @ScottFreeCode. Here's an idea of my proposed spec, of which we limit for the sake of explanation to just the semantics of beforeEach, describe, and it:
Invariants:

no context mutation in an it block can ever leak into another test
context mutations can only be done in beforeEach blocks
context is reset to {} on every test run.

Hypothetical implementation notes:
When a test suite is executed, each test should run its constituent code blocks in the following order:

(Reset the this context to {} if necessary)
Run the outermost beforeEach's, down to the innermost beforeEach
Run test
Run the innermost afterEach, out to the outermost afterEach

Here are some advantages from those core principles:

Test isolation: the status of a test should generally not depend on code in other it blocks. With the aforementioned invariants, the this context for any given it block will never be affected by other it blocks

Independence from the test suite: the status of a test should generally not depend on whether it is run in isolation, or as part of a test suite.  With the aforementioned invariants, one will never encounter a situation where a test passes when run alone with it.only but fails when run as part of the entire test suite (assuming no use of global state or closure state).

I took a look at rspec (of which I believe mocha took much inspiration from) and transliterated the test cases I mentioned earlier. It passes all three examples, whereas mocha only passes the last example. Here is the rspec code for reference:
# 1. tests should not leak to sibling describe blocks
describe "asdf" do
  describe "inner 1" do
    it "works" do
      expect(defined? @foo).to eql nil
    end
  end
  it "(mutation)" do
    @foo = true
  end
end

# 2. tests should not leak to sibling describe blocks when a higher beforeEach exists
describe "asdf" do
  before(:each) do
    @foo = true
  end
  describe "inner 1" do
    describe "superinner 1" do
      it "works" do
        expect(@foo).to be true
      end
    end
    it "setting foo" do
      @foo = false
    end
  end
end

# 3. tests should not leak to sibling describe blocks when a sibling beforeEach exists
describe "asdf" do
  before(:each) do
    @foo = true
  end
  describe "inner 1" do
    it "works" do
      expect(@foo).to be true
    end
  end
  it "setting foo" do
    @foo = false
  end
end

In other words, rspec guarantees test isolation if one sticks to setting up test in beforeEach's, whereas mocha does not.

Here's another example of the test isolation I'm looking for, this time in hspec, a test runner for Haskell also very inspired by rspec.
test should be isolated from other tests - Pass (expected: Pass) :white_check_mark:
#!/usr/bin/env stack
-- stack --resolver lts-8.0 --install-ghc runghc --package hspec -- -Wall -Werror
import Test.Hspec
import Data.IORef

main :: IO ()
main = hspec $ do
  describe "asdf" $ beforeWith (\() -> newIORef False) $ do
    describe "inner" $ beforeWith (\ctx -> writeIORef ctx True >> return ctx) $ do
      it "ctx should be true" $ \ctx -> do
        readIORef ctx >>= shouldBe True
    it "(setting ctx to False)" $ \ctx -> do
      writeIORef ctx False

In the equivalent mocha code, this test suite would fail, since somehow the context mutation in the bottom it block would leak into the inner describe block. Much like rspec, hspec does not have this issue; the beforeWith's (beforeEach's) run exactly before each test, from the outermost to innermost describe block.

Because test runners like rspec and hspec, both the most popular test runners for their respective languages, guarantee proper test isolation with respect to context setup, mocha should also guarantee proper test isolation with respect to context setup.

Good to know RSpec's behavior here; thanks!
This might not be relevant in the case of Haskell with its automatic memoization and lack of mutation (and I apologize if it was mentioned already and I missed it), but does RSpec have a before(All) and after(All)? Again, I don't think it's really a good design since it's used for state that persists between tests, but it's pretty clearly a deliberate part of Mocha's design (and more widely relied upon than the exact behavior of this as far as I happen to know, although that might be anecdotal). In considering adoption of new (for Mocha; older, in general) this behavior, we'd need to decide whether this can be used in before(All) and after(All), and if so with what behavior, or alternatively whether to get rid of before(All) and after(All). (Although I suspect getting rid of them would be the most intrusive option; even if we nuked this from before(All)/after(All), as long as we kept them at all one could, for better or for worse, continue using variables that are set up just once for the suite by making them local variables of the suite callback.)
I'd also be interested in figuring out the behavior of this in the couple of JavaScript test runners that are allegedly supposed to be compatible with Mocha with few or no test code changes; RSpec, being widely imitated (on top of better designed), sets the tone for much test-driven development, but those JS test runners are where there might be direct compatibility. It's been a while since I looked into choosing JS test runners; I want to say off the top of my head that Intern and... I think maybe Jasmine?... advertised having the same interface as Mocha as at least one of their options, but I can't recall for sure. I need to block out some time to glance through them all and figure out which I should focus on (and then block out some time to dig into the ones I should focus on).

One other proposal I believe we considered not too long ago was (off the top of my head; I don't recall the exact details but I think this was the gist of it) to make this in nested suites' before(All) visible to outer suites' beforeEach, e.g. so this would work:
var assert = require("assert")
var configurableType = require("./configurable-type")

describe("parameterized behavior", function() {
  before(function() {
    this.configuration = 42
  })

  beforeEach(function() {
    this.configurableObject = configurableType(this.configuration)
  })

  it("should be configured for 42", function() {
    assert.equals(this.configurableObject.configuration, 42) // imagine testing more complex behavior that depends on the object's parameter
  })

  describe("with different parameter", function() {
    before(function() {
      this.configuration = 7
    })

    it("should be configured for 7", function() {
      assert.equals(this.configurableObject.configuration, 7) // imagine testing more complex behavior that depends on the object's parameter
    })
  })
})

Or at any rate, it was some kind of proposal to allow a resource defined in an outer suite to have some kind of dependency defined alongside it in the outer suite and then overridden in an inner suite. I think it was also RSpec-inspired, although, and this is purely my fault, I spent a lot of the discussion accidentally figuring out that Mocha's current this behavior wasn't even what I had thought it was at the time, so I don't remember exactly how RSpec supposedly did it. I need to revisit that one too.

Experiencing a similar problem, having beforeEach leak across its
describe("A broken mocha", function() {
  beforeEach(function() {
    this.variable = "foo"
  })

  describe("A nested context", function() {
    beforeEach(function() {
      expect(this.variable).to.deep.equal("foo")
      this.variable = "bar"
    })

    it("should", function() {
      expect(this.variable).to.deep.equal("bar")
    })

    it("should", function() {
      expect(this.variable).to.deep.equal("bar")
    })
  })
})

Removing the nested describe causes things to work correctly.

this seems similar to some other bug I commented on the other day.
use closures instead of context object

@boneskull That is the decision Jest goes with.
We switched over to Jest from mocha, and initially missed mocha's context object. We then switched over to using closures, which was slightly syntactically uglier, since you'd have to first declare your variables uninitialized, and then mutate them in beforeEach's.
In any case, we found that both solutions were both lacking in terms of flow type inference, so we ended up settling on a third solution:  functions.
i.e.
function setupTest (params: { url: string }): { foo: string, bar: string } {
  ...
}

it("blah", () => {
  const { foo, bar }  = setupTest({ url: "https://github.com" });
  ...
});

It's an extra line of code for each test, but you get type inference on both your inputs and outputs.
In addition, these are just functions, so you can import them, export them, compose them, etc. Closures and this are bound to their describe/it block and do not enjoy these privileges.

Can anyone weigh in on whether this issue is distinct from #2014 (see also my summary at https://github.com/mochajs/mocha/issues/2014#issuecomment-343021094)? I've been trying to close some duplicates lately. (We may also want to see if we can make that one more likely to show up in searches related to any variation on, or interpretation of, this issue.)

@ScottFreeCode this seems to be a duplicate of #2014.  closing


Problem with image in Actor sheet.

Hi! :D
When adding a photo to the sheet of a player and non-player character. It is not saved. Once the picture is chosen, when you press F5 or refresh Foundry, the outsider's mark is set by default. 🤔
I have tried creating a new world without modules and the problem persists.
Browser: Client Foundry VTT
Modules Installed: 0
Steps for Reproduction: Create Actor, add image, and when you hit F5, it is removed.
Expected Behaviour: The selected image is kept.
Actual Behaviour: The chosen image is replaced by the outsider's mark.
Screenshot (if possible):

@Damaskian actually this is partially related to a bug Foundry has at the moment (#79). Having said that, this is likely caused by the fix being too over egregious. I'll try and get this fixed in the next release, but that might take a while yet... Thanks for letting me know!

@Damaskian actually this is partially related to a bug Foundry has at the moment (#79). Having said that, this is likely caused by the fix being too over egregious. I'll try and get this fixed in the next release, but that might take a while yet... Thanks for letting me know!

Great! No rush. My players will fall into the void with or without an image. 😈

Great! No rush. My players will fall into the void with or without an image. 😈