ServiceEntry captures traffic that doesn't match host?

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
If I define the following service entry, and then watch traffic from my pod literally anything over 443 is captured and matches the entry.
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: test
spec:
  exportTo:
  - .
  hosts:
  - sts.us-east-2.amazonaws.com
  - '*.s3.dualstack.us-east-2.amazonaws.com'
  location: MESH_EXTERNAL
  ports:
  - name: https
    number: 443
    protocol: TLS
  resolution: NONE

Hit a different endpoint:
$ curl https://www.google.com

Observe the traffic logs in the istio-proxy container:
[2024-02-22T07:00:21.655Z] "- - -" 0 - - - "-" 883 24794 136 - "-" "-" "-" "-" "[2607:f8b0:4009:81b::2004]:443" outbound|443||*.s3.dualstack.us-east-2.amazonaws.com [2600:1f16:40:5306:1f57::10]:43380 [2607:f8b0:4009:81b::2004]:443 [2600:1f16:40:5306:1f57::10]:43364 www.google.com -
Why is the *.s3.dualstack.us-east-2.amazonaws.com host showing up here? Why is the ServiceEntry matching for any reason? It appears to do this for any traffic over port 443.
Version
EKS 1.29
Istio 1.20.3

ENABLE_NATIVE_SIDECARS: true
ISTIO_ENABLE_IPV4_OUTBOUND_LISTENER_FOR_IPV6_CLUSTERS: true

It’s worth noting this issue is even worse if I set resolution: DNS as traffic is actually redirected to the wrong location.

This very much is not expected:
$ istioctl pc l shell-6d8bcd654d-w2ldz | rg aws
<IP_ADDRESS>      443   SNI: sts.us-east-2.amazonaws.com                                                                Cluster: outbound|443||sts.us-east-2.amazonaws.com
<IP_ADDRESS>      443   SNI: *.s3.dualstack.us-east-2.amazonaws.com                                                     Cluster: outbound|443||*.s3.dualstack.us-east-2.amazonaws.com

is what I get and expect -- only match that SNI

I'm running into something like https://github.com/istio/istio/issues/34358#issuecomment-923413096 but on containerd 1.7.11 when trying to run istioctl pc commands:
❯ istioctl pc route myapp-mq-main-5b969cf98-h6xww
2024-02-22T16:19:24.309982Z     error   klog    an error occurred forwarding 57063 -> 15000: error forwarding port 15000 to pod 512224d5c842a05d98413a21861ad61fd630406eaca2356180ea0a782affeac6, uid : failed to execute portforward in network namespace "/var/run/netns/cni-118b1c16-2c5c-1383-68ac-17b4fd273ef5": failed to connect to localhost:15000 inside namespace "512224d5c842a05d98413a21861ad61fd630406eaca2356180ea0a782affeac6", IPv4: dial tcp4 <IP_ADDRESS>:15000: connect: connection refused IPv6 dial tcp6: address localhost: no suitable
address found
2024-02-22T16:19:24.311783Z     error   port forward failed: lost connection to pod
Error: failed to execute command on myapp-mq-main-5b969cf98-h6xww.myapp sidecar: failure running port forward process: Get "http://localhost:57063/config_dump": EOF

❯ istioctl pc l myapp-mq-main-5b969cf98-h6xww | rg aws
Error: failed to execute command on myapp-mq-main-5b969cf98-h6xww.brainbaseline sidecar: failure running port forward process: Get "http://localhost:57160/config_dump": EOF

istioctl ps does work:
❯ istioctl ps
NAME                                                                   CLUSTER        CDS        LDS        EDS        RDS        ECDS         ISTIOD                      VERSION
myapp-mq-main-5b969cf98-h6xww.myapp                                    Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5b6b86894b-rzw64     1.20.3
myapp-mq-scheduled-reports-745d79fcf8-6brdk.myapp                      Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5b6b86894b-ththj     1.20.3
myapp-web-5c58db94bc-5klnn.myapp                                       Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5b6b86894b-ththj     1.20.3
istio-ingressgateway-67fb75d8c9-qkml5.istio-ingressgateway-private     Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5b6b86894b-ththj     1.20.3
istio-ingressgateway-67fb75d8c9-z4757.istio-ingressgateway-private     Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     NOT SENT     istiod-5b6b86894b-ththj     1.20.3

you can also just curl http://localhost:15000/config_dump in the contianer, then pass it to istioctl with -f

The EKS IPv4 vs IPv6 setup is probably making this check: https://github.com/istio/istio/blob/65d15b6b616ac969f2a354a990599fd908ba3b28/pilot/pkg/networking/core/v1alpha3/tls.go#L206 fail.
actualWildcard is probably <IP_ADDRESS> but svcListenAddress=="::" or something

This issue is a regression but I’m not clear right now why. I am using the exact same entry definitions (with resolution: DNS) on another cluster that is ipv4-only, without native sidecars, using older istio 1.17.5 and am not seeing this behavior.

I've tried to help narrow this down:

I turned off native sidecars and still observe this behavior.
I downgraded to 1.20.1 and still observe the behavior.
I downgraded to 1.19.1 and see the example above do what you expect, emitting PassthroughCluster instead of matching the ServiceEntry.

Ok I can reproduce it on just a simple IPv6 only kind cluster

So the problem is svcListenAddress  is always set to <IP_ADDRESS> while the actualWildcard is ::.
Not sure why it worked in 1.19, though

Wow good catch; the funny thing is that the / was causing Envoy dualstack bugs at the time. I can put up a PR to fix the conditional

Now that @codeverifier helped me fix istioctl pc l I was able to get that output for y'all.
❯ istioctl pc l myapp-web-5576c48d65-dj5lj | rg amazonaws
::                   443   SNI: sts.us-east-2.amazonaws.com; Addr: ::/0                                                    Cluster: outbound|443||sts.us-east-2.amazonaws.com
::                   443   SNI: *.s3.dualstack.us-east-2.amazonaws.com; Addr: ::/0                                         Cluster: outbound|443||*.s3.dualstack.us-east-2.amazonaws.com


#10111 - Puppet should do OCSP instead of CRL

Hi,
Please find my attempt at bringing OCSP to Puppet. This time based on current master.
OCSP is a way for a node in an X509 PKI to check the validity of a peer certificate. For this, the node sends to a 3rd party an OCSP request, the 3rd party (usually the CA) checks the certificate and returns an OCSP response.
In the Puppet ecosystem, the Puppet CA acts as the OCSP responder. It receives OCSP requests sent through REST at the ocsp indirection, checks the certificate status in the CA CRL and returns an OCSP response (in a YAML format because that's the only way it could work). OCSP has no interest in terms of security if the master is also the CA.
The OCSP verification can be enabled on both the client and the server. On the client side, all the server certificate chain is verified against the OSCP responder. On the server, only the current client certificate is checked. On non-webrick servers, the SSL endpoint should be configured to forward (usually as an http header) the client certificate if OCSP verification is enabled server side (check the commit message for instructions).
OCSP is enabled with the configuration settings --ocsp_verification.
The OCSP verifier contains a cache to not abuse the OCSP responder on every requests (the cache entries expires after --ocsp_ttl (usually 3600).
Note: I was unable to test with a passenger setup. Although I believe the passenger-only code is correct, it's possible that it might be buggy.
Note2: There is no caching in the CRL check. And the CRL check is sequential. This might be a performance issue for large CRL.
Note3: I'm closing the previous #233 pull request in favor of this one.
Thanks,

Hello,
I don't see it in the possibilities for the v4.2 : https://docs.puppetlabs.com/puppet/latest/reference/config_ssl_external_ca.html#revocation
Is it still planned to integrate it ?
best regards,
Adrien

@jeffmccune, @alemairebe. It's been years and, as far as I can tell, still no support for OCSP.
The ticket is still open. How about reopening this pull request or creating a new one and getting this in as soon as possible?

@avylove @alemairebe We do have plans to support OCSP, but we're eliminating some ssl technical debt to make adding OSCP support (and do so without using the indirector). Please add yourself as a watcher to the ticket if you haven't already.


Delegated mgmt

This branch and PR will add History tracking as well as delegated management through user and admin roles. This PR is dependent on PR #1 and cannot be merged until that PR is resolved and merged.

 Track change/history as services are saved

 Diff color syntax


Bug: Few editor shortcuts don't work (e.g. cntl+enter for execute query, cntl+z for undo) in certain cases

Hi Serge,
Found the above issue on 5.1.5 (and early) and even on EA (5.1.6). Didn't know how to re-produce hence waited this long. The above happens if I do the following steps.

Connect to a database (my case, mysql or oracle)
Open an saved editor.
Close that and open another saved editor.
Now try any of the editor shutcuts. In my case they dont work. cntl+enter breaks the current line instead of executing it. cntl+z does nothing. I have to right click and select undo from context menu.

Hope you can reproduce this and fix it. Many thanks in advance.
If it helps, my System Windows 10 pro 64 bit (Insiders release 17738.1000 rs5 branch). Happened on 1803 current stable.

How do you open saved editor?
From project explorer view, by shortcut?

File -> Recent editors
I just have database navigator. Closed project explorer view and dont use anymore.
Connect to a database from database navigator by expanding it. Then open editor as said above

Unfortunately I still can't reproduce that.
Does switching active editor or switching to some view and then back to the editor resolves the problem?
Usually if Ctrl+enter inserts new line instead of executing a query this means that this SQL editor isn't associated with any connection. And thus it works like a regular text editor.
Make sure you have some connection assigned (in the main toolbar).

I'm trying to reproduce but not luck so far.
Could you say:

Does switching active editor or switching to some view and then back to the editor resolves the problem?
Does clicking on "Execute statement" icon works in that case?

I'm trying to understand is execute command is unavailable or just shortcut was broken by some reason.

Hi Serge,
Thanks a lot for your time.

Switching active editor meaning going to a browser or notepad and coming back? The work around I use at the moment is Active broken editor view, disconnect from db, reconnect and open the saved editor. This works.
Yes, all mouse clicks work as expected. Just the keyboard shortcuts do not work. Even 'delete' key doesnot work when I try to rejoin the broken line

I see some checkin, tried the latest EA released 17th, still the issue.

Ok.
Could you try to reset workspace (https://github.com/dbeaver/dbeaver/wiki/Reset-workspace).
Just delete workbench.xmi file and restart DBeaver.

I think I've finally reproduced that. Looks like some bug in Eclipse.
The stack:
2018-08-19 10:24:21.151 - Event loop exception
org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:65)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:318)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:252)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:161)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:204)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.executeCommand(KeyBindingDispatcher.java:305)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.press(KeyBindingDispatcher.java:579)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.processKeyEvent(KeyBindingDispatcher.java:648)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.filterKeySequenceBindings(KeyBindingDispatcher.java:438)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.access$2(KeyBindingDispatcher.java:381)
	at org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher$KeyDownFilter.handleEvent(KeyBindingDispatcher.java:93)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1190)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1051)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1076)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Control.traverse(Control.java:4274)
	at org.eclipse.swt.widgets.Control.translateTraversal(Control.java:4256)
	at org.eclipse.swt.widgets.Composite.translateTraversal(Composite.java:1297)
	at org.eclipse.swt.widgets.Display.translateTraversal(Display.java:4674)
	at org.eclipse.swt.widgets.Display.filterMessage(Display.java:1208)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3530)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1170)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1059)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:667)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:597)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.jkiss.dbeaver.core.application.DBeaverApplication.start(DBeaverApplication.java:162)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:656)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:592)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1498)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1471)

Hi Sergey,
Thanks for the update. Such a relief! I really appreciate your hard work for such non-trivial thing.
I checked error logs but didn't find anything related (Tried at 19th Aug 8pm local time). Please see the screenshot of un related events only related to yesterday and before.

Additional fix committed. I've reverted one of my previous fixes which (I believe) caused this issue.
Please test in 5.1.6 and reopen if this problem still exists.

Hi Serge, Tested the latest release <IP_ADDRESS>808262133 and the problem persists.

Ok. could you post debug log (https://github.com/dbeaver/dbeaver/wiki/Log-files). Perhaps it will contain some clues.

Hi Serge,
I have enabled debug log from Window -> Preferences -> Error handling -> Error logs (${workspace}.metadata\dbeaver-debug.log) but nothing is written to it when the scenario happens. Do I have to do anything?

I've been able to reproduce this once or twice.  Eventually I think I've fixed this (although I can't be 100% sure as it is not so easy to reproduce - but I never saw this problem after the fix).
Please check this in 5.2.

Hi Serge,
This is still not fixed as I have been testing 5.2 EA released on 27th August and later on 3rd September. But again this is not a show stopper nor important that it deserves your time. Lets safely ignore this until someone else complains.
Thanks again for your time. Have a great day!

I am also encountering this bug.  I'm not sure if it's a bug in windows or in dbeaver.  It wasn't happening frequently before but with 6.2.2 it is happening all the time.

As for @drawnfallow , I have the same issue using <IP_ADDRESS>906091949.
This indeed seems to occur somewhere after loading a saved .SQL from File > Recent Editors.
I had it twice in a row, resetting UI in-between, and unable to reproduce it now.
Worth noting, I'm using a shared server (Windows 2016) having layouts for French and US keyboards.
I'm not sure but sometimes I also encounter a switch of layout (system shortcut, not admin of server, can't debug on this, I usually disable such shortcut).
Could that be a side effect of triggering an improper global shortcut?

This still occurs in 7.0.0


Ctrl+space does not work

Windows Terminal version
1.14.2281.0
Windows build number
10.0.19043.1889
Other Software
OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2
Steps to reproduce
Disable the default Paste binding as ctrl+v.
SSH into any linux host. Press ctrl+v (to send the next input as verbatim) then ctrl+space.
Expected Behavior
You should get a ^@ character on screen, as seen on the bottom part of the picture (mintty).

Actual Behavior
Nothing happens, no character is sent at all.

/dup https://github.com/PowerShell/Win32-OpenSSH/issues/1842


feat(core): make facet search use generic interface

COM-1296
So.... after discussing and brainstorming and screensharing a lot, we decided to implement a generic interface that could be implemented by both SearchAPIClient and ProductListingClient.
This required a couple of changes, such as changing the searchApiClient property to simply apiClient.
Then, the thunk arguments for the actions require a specific implementation (such as facet search requiring FacetSearchAPIClient instead of a SearchAPIClient. This make it so the SearchEngine can expose in its extra arguments apiClient: SearchAPIClient, and ProductListingEngine can expose it as apiClient: ProductListingClient. Since both implement FacetSearchAPIClient, everything runs fine! :confetti_ball:
Since we are deprecating searchApiClient, I changed a couple of actions to use the new property. Sami assured me that it is improbable that someone was using its own "engine" that would provide its own extra argument, so even though it's technically breaking, it is also fairly safe.

All FTs are failing because it's missing analytics calls. My plan is to create another PR that branches off this one and implements the proper Analytics things.
The changes were already big, so I'd rather split the PRs

Cool!
However, a few executeSearch are commented out, is this meant to be fixed in a different PR?


Allow to get a custom location to save and read snapshots

Saving snapshots in a custom location is helpful for many reasons. We should have this.

Fixed with #40


[BUG]: TIMESTAMPS showing up incorrectly on drizzle studio.

What version of drizzle-orm are you using?
0.30.7
What version of drizzle-kit are you using?
0.21.1
Describe the Bug
Drizzle studio shows an incorrect timestamp that is 13 hours behind the expected timestamp.
This is how the table is defined:
export const gameSessions = pgTable("gameSession", {
  id: serial("id").primaryKey(),
  gameSessionScheduleId: integer("gameSessionScheduleId").references(
    () => gameSessionSchedules.id,
    { onDelete: "set null" },
  ),
  bookingOpen: timestamp("bookingOpen", { mode: "date" }).notNull(),
  bookingClose: timestamp("bookingClose", { mode: "date" }).notNull(),
  date: date("date").unique().notNull(),
  startTime: time("startTime").notNull(),
  endTime: time("endTime").notNull(),
  locationName: text("locationName").notNull(),
  locationAddress: text("locationAddress").notNull(),
  capacity: integer("capacity").notNull(),
  casualCapacity: integer("casualCapacity").notNull(),
});

Expected behavior
Data returned from query (expected):
{
    "id": 135,
    "gameSessionScheduleId": null,
    "bookingOpen": "2024-10-30T20:00:00.000Z",
    "bookingClose": "2024-11-04T06:30:00.000Z",
    ...
}

Data shown on drizzle studio:

Environment & setup
No response

I also had a similiar issue here, and I think it has to do with storing the time in UTC, and then drizzle-kit seams to assume that it is stored in your local time zone, and then converts it again to UTC, creating an offset.
I can compare these values using another database viewer like Dbeaver.
DBeaver:

DrizzleKit:

Actual Response from Drizzle ORM in Production (correct):

This means Drizzle Kit is providing a different response than Drizzle ORM.
I am using a postgres database in this case, with the date mode on.

Here is some more evidence to the bug.  I'm using a planetscale database.
I ran this query through the drizzle studio and on the planetscale web console and got different results.  The 6 hour time difference being that I'm in US Pacific time.
From drizzle studio in local dev:

From planetscale web console:

I'm not seeing this bug in drizzle ORM production code.  Only on the studio side.

should be fixed by upgrading to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Added echo function to OpenAI API server.

The feature implements the echo function for OpenAI API server. It supersedes previous PR #959 on top of #1328. Also, it supports the issue #201.
For OpenAI API server, the PR makes following modifications:

Removed error message for requesting echo.
Modified create_logprobs function to reflect engine output changes.
Changed the behavior of streaming as in OpenAI's implementation, the number of streamed payloads basically equals to the number of tokens generated times number of choices; whereas in our previous implementation, it would yield another end of streaming empty token.
Edge case: added the support for the case of echo=True and max_tokens=0, which is a valid case in OpenAI APIs. In this case, the SamplingParams.max_tokens would be set to 1 and enable an echo_self flag. The flag is then used in the following post processing to ensure the additionally generated token being removed from the final output.

@zhuohan123 request to review.

@zhuohan123 Except for the unresolved conversation, I've addressed comments.

@zhuohan123 besides the design decision for the top logprob behavior, is there anything you would like to address?

any updates?

any updates?

I suppose that we’re still waiting for the team to get another round of review done. @zhuohan123 do we have any concern with merging the PR?

@zhuohan123 would it be possible to get this PR re-reviewed/merged... we're heavily using this branch but would be much better if the code was in main.
Haven't reviewed the code but all seems to work well (aside from the open question on whether the logprobs of the chosen tokens should be returned in top_logprobs).

@zhuohan123 I've addressed the comments. Please let me know if you found anything else to address.

Hi thanks for fixing the issues! I tried running the following script to test:
import openai

# Modify OpenAI's API key and API base to use vLLM's API server.
openai.api_key = "EMPTY"
openai.api_base = "http://localhost:8000/v1"

# List models API
models = openai.Model.list()
print("Models:", models)

model = models["data"][0]["id"]

# Completion API
stream = False
completion = openai.Completion.create(
    model=model,
    prompt="A robot may not injure a human being",
    echo=True,
    n=2,
    stream=stream,
    logprobs=3)

print("Completion results:")
if stream:
    for c in completion:
        print(c)
else:
    print(completion)

And got the following error on the server side:
Traceback (most recent call last):
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/applications.py", line 289, in __call__
    await super().__call__(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/cors.py", line 83, in __call__
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/routing.py", line 273, in app
    raw_response = await run_endpoint_function(
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/routing.py", line 190, in run_endpoint_function
    return await dependant.call(**values)
  File "/home/zhuohan/vllm/vllm/vllm/entrypoints/openai/api_server.py", line 594, in create_completion
    logprobs = create_logprobs(
  File "/home/zhuohan/vllm/vllm/vllm/entrypoints/openai/api_server.py", line 193, in create_logprobs
    for i, p in step_top_logprobs.items()
AttributeError: 'NoneType' object has no attribute 'items'

Hi thanks for fixing the issues! I tried running the following script to test:
import openai

# Modify OpenAI's API key and API base to use vLLM's API server.
openai.api_key = "EMPTY"
openai.api_base = "http://localhost:8000/v1"

# List models API
models = openai.Model.list()
print("Models:", models)

model = models["data"][0]["id"]

# Completion API
stream = False
completion = openai.Completion.create(
    model=model,
    prompt="A robot may not injure a human being",
    echo=True,
    n=2,
    stream=stream,
    logprobs=3)

print("Completion results:")
if stream:
    for c in completion:
        print(c)
else:
    print(completion)

And got the following error on the server side:
Traceback (most recent call last):
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/applications.py", line 289, in __call__
    await super().__call__(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/cors.py", line 83, in __call__
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/routing.py", line 273, in app
    raw_response = await run_endpoint_function(
  File "/home/zhuohan/anaconda3/envs/vllm/lib/python3.10/site-packages/fastapi/routing.py", line 190, in run_endpoint_function
    return await dependant.call(**values)
  File "/home/zhuohan/vllm/vllm/vllm/entrypoints/openai/api_server.py", line 594, in create_completion
    logprobs = create_logprobs(
  File "/home/zhuohan/vllm/vllm/vllm/entrypoints/openai/api_server.py", line 193, in create_logprobs
    for i, p in step_top_logprobs.items()
AttributeError: 'NoneType' object has no attribute 'items'

@wanmok Can you double check on your side? I believe the bug is caused by that the first token of the prompt does not have log probability, and thus its step_top_logprobs will be None.

I have it fixed and tested. Please let me know if you found any other issues.

does this work? I'm getting "echo is not currently supported" @zhuohan123 @wanmok

Are you using the latest main branch? This PR hasn't been included in the latest release yet.

When will this be released? I work in a cuda 11.8 environment, and I haven't figured out a way to compile the repo.

I'm having the same problem as @lifengjin. How do you get a pull request to compile? I'm running into an abi compiler incompatibility error @zhuohan123 .


.gitattribute: remove old entries and force lf mode for python files

In gitattributes there are entries that set attributes for (probably) old files: .bat, .h and .cpp.
Is it ok to remove them?
Should I add an entry *.py text eol=lf for python files?

Is it ok to remove them?

I think so.

Should I add an entry *.py text eol=lf for python files?

Why you wrote these in Python and not Zig or Bash?


[BUG] Building process breaks when path has space

Describe the bug
When running yarn build for oui, the build fails if the path to the folder has an empty space.
To Reproduce
Steps to reproduce the behavior:

Clone the repo using the following command: git clone git clone https://github.com/opensearch-project/oui.git bug_oui\ space
Run yarn install
Run yarn build
See error

Expected behavior
The build process should not cause this error. It should manage path with blank spaces.
Screenshots
Error screenshot

Host/Environment (please complete the following information):

OUI Version: [e.g. 1.0]
OS: macOS Ventura 13.5.2

Additional context
N/A

I've noticed most people have issues when the space is further up in their path. For example one might create a My Projects directory, into which they clone OUI. Even in that case, where the path is ~/My Projects/oui, this issue persists.

I would like to pick up this one:)


adding bots=1 to piwik tracking url

resolves #648

what's the purpose of this change? should we also update the tracking url in header/footer?

@kosarko the purpose of this change is to request piwik to filter bots when the request is coming from our Java code. The javascript code in header/footer is already good.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/80685

TagBot fix

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


Check item 288

Also, there seems to be a problem with this item:
288
NAME NP (размером/величиной) с NP-Acc - Собака была размером с лошадь.
It generates two menu items in Morphology, one is: NP (размером, and the other is: величиной) с NP.
Maybe the / messed it up?
And there are many items with the label “NA”, I don't understand how those work.

Also this type of problems will go away once we move away from the spreadsheet and only edit YAML files. This problem arose because I need to convert spreadsheet -> csv -> yaml.

I have fixed this in the database, this was my mistake. All NA items are now replaced with tags, 288 item is fixed, the words appeared in that slot by mistake and mixed with tags. This problem arose because I was asked to provide the database as I have it concerning the syntactic and morphological annotation, and some tags are there not updated, this leads to duplicate tags with and without capital letters, etc. I can fix these inconsistencies in the database in the beginning of January if I can only focus on them.

I understand that this is now fixed. Closing. Please reopen the issue if something remains to be done for this.

I understand that this is now fixed. Closing. Please reopen the issue if something remains to be done for this.


Multithreading doesn't work properly on high thread count CPUs

https://forum.nim-lang.org/t/4732#29528

I don't have evidence yet to confirm this is actually true.

I think it's more of an issue with lock contention.


How to expose ipp printer via http?

Hello.
First this is not an issue.
We are having on-premise printers which support ipp. We have successfuly printed using different implementations of ipp (java and node.js) running on localhost.
The problem is how can we convert this calls to regular HTTP calls as made from postman, so that we can expose/call the printers outside the network using plain http.
Is that even possible?
Best regareds,
Bruno.

Hello Smith,
Thank you for your quick reply.
I will post also the question to the PWG's reflector page.
Thank you,
Bruno.


Reverse proxying to lego requires modifying reverse proxy transport

Hi. I'm not sure if this is a bug or not, but if not it might be worth documenting somewhere if it isn't.
My setup is that I wanted to run lego on a non-standard port (using the --http flag) and have http-01 acme challenges forwarded to lego from my two web servers.
My first attempt at doing so was to add 302 http redirects but for some reason the Let's Encrypt validation servers just wouldn't play ball (even though everyone on the net says http redirects works fine). This was nothing to do with lego, but I just thought I'd mention it.
Having failed at that I decided to use httputil.ReverseProxy from the Go standard library to send on the challenges. This worked great with my first web server which has a single domain name on the certificate. However my second web server, which has a SAN Multi-Domain certificate, failed. The first domain on the certificate validated fine with Let's Encrypt's servers, but the second did not whith lego returning an acme "404" error.
After a bit of head scratching I turned off re-use of TCP connections between different HTTP requests in the transport of the reverse proxy by setting DisableKeepAlives in the transport to true. Then everything worked perfectly! :)
Anyway, I just thought I'd let you guys know in case it was of interest.

To reply to myself, I've just made a patch to lego that (I believe) solves the problem. I will submit a PR in in minute or two (never done one before!)

I think 302 redirects only work for redirecting from a domain to another (www.example.com to example.com) and not to a different port for that matter.
About the KeepAlive problem, you are completely right :)

Great. It's my first PR so glad not to have made a fool of myself :)


Rename window still doesn't work

Is there an existing issue outlining your problem?

[X] I have searched the existing issues and they do not solve my problem.

Describe your problem.
Renaming a window does not reflect on the bar.
Paste your configuration.
set -g mouse on

set -g base-index 1
setw -g pane-base-index 1

set-option -g renumber-windows on

set -ga terminal-overrides ",xterm-256color*:Tc"

set -g pane-border-style bold

set -g status-position top

unbind-key C-b
set-option -g prefix C-Space
bind-key C-Space send-prefix

bind h select-pane -L
bind j select-pane -D
bind k select-pane -U
bind l select-pane -R

set -g @plugin "catppuccin/tmux"
set -g @plugin "tmux-plugins/tmux-battery"
set -g @plugin "tmux-plugins/tmux-sensible"
set -g @plugin "tmux-plugins/tpm"

set -g @catppuccin_window_left_separator "█"
set -g @catppuccin_window_middle_separator " | "
set -g @catppuccin_window_right_separator "█ "
set -g @catppuccin_window_number_position "left"

set -g @catppuccin_window_default_fill "none"

set -g @catppuccin_window_current_fill "all"

set -g @catppuccin_status_modules_right "user host battery date_time"
set -g @catppuccin_status_left_separator "█"
set -g @catppuccin_status_right_separator "█"

set -g @catppuccin_date_time_text "%A, %Y-%m-%d"

run '~/.tmux/plugins/tpm/tpm'

Attach screenshots.
https://github.com/catppuccin/tmux/assets/166430582/a490e822-3c9f-41a4-b416-d7a6e504ad10
What tmux version are you seeing the issue on?
tmux 3.4
Any additional comments?
No response

# Window
set -g @catppuccin_window_current_text "#{window_name}"
set -g @catppuccin_window_default_text "#{window_name}"
``` Add these lines to your config

# Window
set -g @catppuccin_window_current_text "#{window_name}"
set -g @catppuccin_window_default_text "#{window_name}"

Add these lines to your config

Damn, that was fast! Thank you!

# Window
set -g @catppuccin_window_current_text "#{window_name}"
set -g @catppuccin_window_default_text "#{window_name}"

Add these lines to your config

That only works for the active window, not inactive windows.

# Window
set -g @catppuccin_window_current_text "#{window_name}"
set -g @catppuccin_window_default_text "#{window_name}"

Add these lines to your config

Is there a way to do it also for inactive windows?

set -g @catppuccin_window_current_text "#{window_name}"
set -g @catppuccin_window_text "#{window_name}"


Problem with polymer-apollo babel output ?

Hello, i'm trying tu use your project on a polymer/graphql application i'm working on, and i've a problem
I've "webpacked" my js code andload it into the browser with a script tag, but when it's loaded, i get a :
_polymerApollo2.default is not a constructor

Maybe this part of the webpack output can help you to help me :) :
	var _apolloClient = __webpack_require__(2);

	var _apolloClient2 = _interopRequireDefault(_apolloClient);

	var _polymerApollo = __webpack_require__(65);

	var _polymerApollo2 = _interopRequireDefault(_polymerApollo);

	function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

	// Create the apollo client
	var apolloClient = new _apolloClient2.default({
	  networkInterface: (0, _apolloClient.createNetworkInterface)({
	    uri: 'http://localhost:8080/graphql',
	    transportBatching: true
	  }),
	  queryTransformer: _apolloClient.addTypename
	});

	//create a new polymer behavior from PolymerApollo class.
	PolymerApolloBehavior = new _polymerApollo2.default({ apolloClient: apolloClient });

I've used the chromium debbuger, and it seems _polymerApollo2 has no property "default". A problem with the "babelisation" done at npm install ? (apollo-client class own a default property and constructs well)
thks, and don't hesitate to ask me more informations :)

PolymerApolloBehavior = new _polymerApollo2.default({ apolloClient: apolloClient });
Check what happens if you change this line to
PolymerApolloBehavior = new _polymerApollo2({ apolloClient: apolloClient });
By the way Its already converted to es5 before publishing to npm.

Same error :
_polymerApollo2 is not a constructor

console.log(_polymerApollo2); ?

this is working :
new _polymerApollo2.PolymerApollo({ apolloClient: apolloClient });

ok, i've found :
import PolymerApollo from 'polymer-apollo';

as to be
import { PolymerApollo } from 'polymer-apollo';

so it's just a small mistake in your README :)

@atoy40 Oh. Okay. Sorry for that. I've changed the readme. Thanks for reporting. closing the issue. :)


PLT-8284 - Log indexer errors

Here, we're using the new logging machinery to catch errors raised by indexers wrapped in a WithTrace.
This will target main after PLT-7811 is merged. It's just pointing at PLT-7811 currently for the reviewer's convenience.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense and have useful messages
[ ] Important changes are reflected in changelog.d of the affected packages
[x] Relevant tickets are mentioned in commit messages

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Targeting main unless this is a cherry-pick backport
[x] Self-reviewed the diff
[x] Useful pull request description
[ ] If relevant, reference the ADR in the PR and reference the PR in the ADR
[x] Reviewer requested

Don't we want to exclude StopIndexer from all these logging?

We do, but that's already being done in logIndexerError


Fix broken test in Ledger.d

This problem showed up once I started using a tx pool in the Ledger. It started erroring about duplicate transactions. Turns out the test was wrong here.

Added assertion in getChainedTransactions and removed double semicolon.

Green.


Handle null and undefined values of result and result.return in invocationRequest

This PR addresses this issue in the Durable JS SDK.
Previously a "falsy" return value would fail to serialize due to logic in invocationRequest that led the worker to assume that there was no return value.
This PR simply refines some if-statements to ensure we only avoid serialization when result and result.return are either null or undefined. :)
ToDos:
I was hoping to add at least one unit test to this, but I couldn't figure out a way to set result variable here by looking at the WorkerChannel tests. Any ideas, pointers, or examples I could follow? Thanks!

Thanks David! I would try adding a test just like this one: https://github.com/Azure/azure-functions-nodejs-worker/blob/v2.x/test/WorkerChannelTests.ts#L445-L456
Although this is definitely a bugfix, since the current behavior has been in place for so long I wonder if it counts as a breaking change and something we should be careful about? I'm trying to think about the impacts a change here may have on a customer's system, and I think it may depend on the type of binding (ex: if it's an HTTP output, honoring a "false" value might return something different or if it's a blob output maybe "0" means that no blob is output, or something like that). @fabiocav - any thoughts on this bugfix and potential breaking impact?

Thanks David! I would try adding a test just like this one: https://github.com/Azure/azure-functions-nodejs-worker/blob/v2.x/test/WorkerChannelTests.ts#L445-L456
Although this is definitely a bugfix, since the current behavior has been in place for so long I wonder if it counts as a breaking change and something we should be careful about? I'm trying to think about the impacts a change here may have on a customer's system, and I think it may depend on the type of binding (ex: if it's an HTTP output, honoring a "false" value might return something different or if it's a blob output maybe "0" means that no blob is output, or something like that). @fabiocav - any thoughts on this bugfix and potential breaking impact?

@fabiocav, could we get your thoughts Marie's question above?

This is indeed a breaking change and has the potential to negatively impact production workloads with a behavior change.
I agree that it is a good change, but likely behavior that would need to be put behind a flag until we have a new major version out.


:bug: [Fix] Delete pre-push hook

Summary

Delete pre-push hook

Describe your changes

리베이스 강제 로직 삭제

Issue number and link

감사합니다아~~


the pulgin is something wrong with the new version Discourse

FAILED
Pups::ExecError: cd /var/www/discourse/plugins && git clone https://github.com/Toxuru/discourse-sidebar-categories.git failed with return #<Process::Status: pid 916 exit 128>
Location of failure: /pups/lib/pups/exec_command.rb:112:in `spawn'
.....
https://github.com/Toxuru/discourse-sidebar-categories.git"]}
cd67e1807300a5643fc837d0dcbdf0f86bbe61f0241ae9a41f3c9a56cc20c3c0
FAILED TO BOOTSTRAP  please scroll up and look for earlier error messages, there may be more than one.
./discourse-doctor may help diagnose the problem.
==================== END REBUILD LOG ====================
build failed, the plugin is incompatible
Could you help me solve this problem？ Thank you very much

I think the issue is resolved.
https://meta.discourse.org/t/sidebar-with-categories/104165/35


Functionality to "walk" YAML schemas

Including resolving references

Functionality to:

"walk" YAML schemas
output to JSON Schema (and eventually XSD?)
output to XLSX templates and files (or at least facilitate it)
Manage ID/Reference scopes and provide a list of file paths to search for them


Foundations

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@8e988eb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         5
  Lines           ?       130
  Branches        ?         6
========================================
  Hits            ?       130
  Misses          ?         0
  Partials        ?         0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add ownProperty check to iterator

One of the indices returned when iterating utterances was the string
'iterator'. Add a check for hasOwnProperty to avoid an error being
thrown.
Using node 6.9.1, calling code was written in Typescript 2.1.4.
My stack trace was:
TypeError: utterances[idx].replace is not a function
  at generateUtterances (/home/josh/src/veronica/node_modules/alexa-utterances/index.js:162:39)
  at /home/josh/src/veronica/node_modules/alexa-app/index.js:460:22
  at Array.forEach (native)
  at utterances (/home/josh/src/veronica/node_modules/alexa-app/index.js:459:34)
  <snip>

You should, please, write a test for this and edit CHANGELOG.

No longer seems to be an issue. I'll add tests and a a line in the changelog next time!


refactor: Remove unused authZ provider logic

Issue #, if available:
Description of changes:

Remove unused authZ provider logic
Deployed and tested login, add user logic were not affected

Checklist:

[x] Have you successfully deployed to an AWS account with your changes?
[x] Have you linted your code locally prior to submission?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @SanketD92, thanks for the comments earlier. I did another review of the front end functionality and realized the auth provider update method is actually in use by the front end, and it does update the DDB for the auth provider information. However, the update will only stay temporarily till the next deployment is done. I've added the codes related to update auth provider back, and only removed the endpoint for create auth provider, which was not used by any front end assets. Meanwhile, I'll create another ticket to refactor the update method since we need to understand how/if customers are using this method before we do anything.

Hi @SanketD92, thanks for the comments earlier. I did another review of the front end functionality and realized the auth provider update method is actually in use by the front end, and it does update the DDB for the auth provider information. However, the update will only stay temporarily till the next deployment is done. I've added the codes related to update auth provider back, and only removed the endpoint for create auth provider, which was not used by any front end assets. Meanwhile, I'll create another ticket to refactor the update method since we need to understand how/if customers are using this method before we do anything.


Add Pull Request and Issue templates

Issue and pull request templates help in maintaining standard format for reporting issues as well as creating PRs. Also it enables automatic addition of labels as well as automatic closing of issues.
failing-test label currently doesn't exist... It needs to be added.

cc @quinton-hoole @VenuReddy2103 @AmitRoushan


Questionnaire support for expression based population and advanced behavior  (Walter Wellauer, Cistec AG)

ch.fhir.ig.ch-etoc#0.1.0 /questionnaire.html
To be able to use choice selection and answer context for the interactive population use cases (http://build.fhir.org/ig/HL7/sdc/populate.html#mode) and advanced behavior as depicted in https://github.com/hl7ch/ch-etoc/issues/18 (http://build.fhir.org/ig/HL7/sdc/StructureDefinition-sdc-questionnaire-behave.html) dependency on SDC base questionnaire http://build.fhir.org/ig/HL7/sdc/StructureDefinition-sdc-questionnaire.html and therefore SDC 2.8.0 is suggested (or alternatively applying the existing the corresponding extensions in  SDC 2.7.0).
Without the ability to add information present in the clinical system be user interaction CH eToc or any CH ORF depending IG won't have a real chance to be used as end users in clinical information systems - especailly in hospitals - are used to that and have no time to enter such information again in any form.
Therefore at minimum expression based population http://build.fhir.org/ig/HL7/sdc/populate.html#expression-based-population has to be supported respect to the most relevant resources in this respect like medication statements, conditions or observations, with special attention to sdc-questionnaire-candidateExpression, answerExpressions and probably others like sdc-questionnaire-contextExpression or any one to support the desired behavior.
Walter Wellauer, Cistec AG

Tel. Mit Walter Wellauer 27.10.2021: #17-19: Feature Request: Technik für Population ist zu diskutieren; am ehesten Expression based.


Implemeted ArgminRandom for nalgebra backend and added nalgebra particle swarm example

fixes #273

Codecov Report
Base: 91.55% // Head: 91.56% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (4b05288) compared to base (c874876).
Patch coverage: 87.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   91.55%   91.56%   +0.01%
==========================================
  Files         117      118       +1
  Lines       17624    17678      +54
==========================================
+ Hits        16135    16187      +52
- Misses       1489     1491       +2

Impacted Files
Coverage Δ

argmin/src/core/checkpointing/mod.rs
66.19% <0.00%> (ø)

argmin/src/core/result.rs
66.36% <0.00%> (ø)

argmin/src/core/kv.rs
90.86% <57.14%> (ø)

argmin-math/src/nalgebra_m/random.rs
96.29% <96.29%> (ø)

argmin/src/solver/neldermead/mod.rs
94.31% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Enhance snippet generator to include using directives

We can improve customers' Track 2 SDK getting started experience by displaying the required using directives in each of our README code samples. See this related issue. To get there, the snippet generator tool should include the necessary C# using directives. This should be the default behavior.
There may be some cases in which using directives aren't as useful to display. To support those cases, a new command-line option should also be provided to opt out of including the using directives.
With the proposed enhancement, the following code sample:
var client = new LogsQueryClient(new DefaultAzureCredential());

Would look like this:
using Azure.Identity;
using Azure.Monitor.Query;

// code omitted for brevity

var client = new LogsQueryClient(new DefaultAzureCredential());

The standard System.* namespaces should be filtered out.

That would not be compilable in the requested form, and would defeat the mandate for snippets that they be copy/paste to compile.   The work-around for this would be to create a separate snippet for using statements and a section in the README / Sample explicitly for usings.  I like the clarify that you're going for and would recommend bringing this up for discussion with the architects to be codified in the guidelines for docs.
As this is not a suggestion that we'll move forward with, and this repository doesn't define guidelines for samples, I'm going to close this out.


Use standard build/ directory for outputting Gradle reports

When the Gradle dependency.check plugin generates reports, it should place them in the standard build/... directory, so that users aren't forced to add a custom gitignore pattern.

The default directory has already been moved to build/reports. This change will be included in the next release.
--Jeremy


make grobid skip pdf files

Hi everyone,
I have got a huge bunch of pdf-files which I would like to process. Some of them are not working (I guess because of some weird pdf-format). Is there a way I can make grobid skip a file? For example if it takes to long?
Unfortunally there is no way to identify the problematic files in advance.

Hi @MariusKempf,
AFAIK if one file is failing, grobid should tell you what went wrong and move one the next file. How are you processing them?
If you need to process them in parallel, you can you spawn grobid as a server and use the grobid-python-client via the API, it should also automatically skip problematic files.
Regarding long-processing files, Grobid already has a system to avoid processing too-big files (e.g there is a timeout on the conversion from pdf to XML and some limit on the maximum numbers of blocks and tokens a PDF can have).

As a complement to Luca answer, there are already 3 mechanisms to skip PDF, in the sense "stop working on this PDF when it turns bad":

a timeout to the call to pdfalto, pdfalto is doing the low level pdf parsing (the default value is 60s, we're generous, it can be changed in grobid/grobid-home/config/grobid.properties)

a memory limit to the process running pdfalto, so we are sure to avoid having swap, JVM disaster, etc. (the default value is 6096MB, we're generous, it can be changed in grobid/grobid-home/config/grobid.properties)

a maximum block number and a maximum token number (they can be changed in grobid/grobid-home/config/grobid.properties)

Nothing else because we really have to at least parse the PDF to see if it is weird. We can have gentle PDF of 200MB because they have big embedded images, and nasty well-looking lightweight PDF.

Hi @kermitt2 and @lfoppiano
Thank you guys a lot - this helped me to fix quite some things on how I integrate your tool into my project.
I still have problems parsing some PDF files, i.e.:
problem_7b6fe606-5570-4024-aca6-7481fafa39b7.pdf
problem_d052c049-bf4d-49b0-9d40-065208284090.pdf
Those might some examples which can´t even be parsed to find out if they are 'weird' like you said.
Unfortunately, Grobid is not stopping or skipping them and my crawler can´t separate them during crawling.

Hi @MariusKempf,
mmmm .... that's weird because I've just tried and I've got immediately an answer.
Archive.zip
I wonder what's happening with your crawler? How did you implement it? Do you call grobid via API or in a different way? What's happening? it is just hanging?

Hi @lfoppiano
Thanks for your efforts! yes, it´s very weird.
I just cloned the grobid-service and the python-client again from your repository to make sure everything is up-to-date. Furthermore, I changed Java back to JDK8.
I am using the local server on default port etc. and the python client. All my other example files are working just those two keep grobid hanging/busy
The problem seems to be connected with Win(10) since on my Linux server it´s working without any problems and amazingly fast as well. On Win it always gets stuck or hanging when it gets to those two files.

OK, basically, as you can see also in the number of unresolved issues related to windows, we recommend using grobid on Linux (mac is also possible). I suggest using a virtual machine or a docker instance on Linux.

Thank you guys - it´s definitely Windows. I am running everything on a linux machine now and it workds perfectly 👍


Create generic tab component

Release Type: Non-Breaking Feature
Fixes https://x-team-internal.atlassian.net/browse/XP-2807
Description

The component should hold minimal design to be effectively generic, mostly the behaviour and minimal CSS for positioning and display
Only one element can be active at a time
We should be able to inject some actions on the change for tab
Add component into Storybook and provide stories for common and edge cases

Checklist
Before submitting a pull request, please make sure the following is done:

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if you've fixed a bug or added code that should be tested, add unit tests
[x] manually tested the component by running it in the browser and checked nothing is broken and operates as expected!

Steps to Test or Reproduce
Go to Storybook: http://localhost:9001/?selectedKind=UI Components%2FTab&selectedStory=basic usage&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel&background=%23fff
Screenshots

@bernardodiasc and @migueliriano  - all your comments has been addressed.
Latest update: scenario for missing props for Container, Head and Pane has been added and default wrapper has been change to use Fragment instead of div


Make octant embeddable in other projects (cobra-based CLIs)

Describe the problem/challenge you have
Love octant :) .
I'd like to embed it in other tooling and with its usage of Cobra, this would be very easy to do. But first I'd like to know if philosophically the project would be OK with this?
Describe the solution you'd like
Today, we cannot produce the root octant command because it is inside an internal package. However, if from a non-internal package we returned this *cobra.Command, it could easily be added as a subcommand a different CLI / tool.
To make this even more concrete: I have an existing CLI (using cobra) where I'd like octant to be a sub-command.
Anything else you would like to add:
I currently have this wired up in a POC and it works great:
$ mycli dashboard launch --help
octant is a dashboard for high bandwidth cluster analysis operations

Usage:
  mycli dashboard launch [flags]

Flags:
      --context string                 initial context
      --disable-cluster-overview       disable cluster overview
      --enable-feature-applications    enable applications feature
      --kubeconfig string              absolute path to kubeConfig file
  -n, --namespace string               initial namespace
      --namespace-list strings         a list of namespaces to use on start
      --plugin-path string             plugin path
  -v, --verbose                        turn on debug logging
      --client-max-recv-msg-size int   client max receiver message size (default 16777216)
      --accepted-hosts string          accepted hosts list [DEV]
      --client-qps float32             maximum QPS for client [DEV] (default 200)
      --client-burst int               maximum burst for client throttle [DEV] (default 400)
      --disable-open-browser           disable automatic launching of the browser [DEV]
  -c, --enable-opencensus              enable open census [DEV]
      --klog-verbosity int             klog verbosity level [DEV]
      --listener-addr string           listener address for the octant frontend [DEV]
      --local-content string           local content path [DEV]
      --proxy-frontend string          url to send frontend request to [DEV]
      --ui-url string                  dashboard url [DEV]
      --browser-path string            the browser path to open the browser on
      --memstats string                log memory usage to this file
      --meminterval string             interval to poll memory usage (requires --memstats), valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h". (default "100ms")
  -h, --help                           help for launch

From the lens of what Octant is aiming to be fully electron by v1, this wouldn't be something officially supported in the near future.
I okay with moving this to a public package - however is the intention to open a UI? The front end bundles in web/dist/ are not included in version control so embedding then compiling might open to a blank page even though the websocket server will send data.

Hi @joshrosso , I like the idea, as Sam pointed out, it isn't on our timeline, but very open to PR especially since it would have no functional changes to Octant and it purely adding lifting the cobra command to a public package so it can be consumed.

Thanks all! We'll look to get a PR open then.
Based on @GuessWhoSamFoo's comments, my understanding is the UI stuff is embedded in to the eventual go binary. So we might need some special build instructions for creating this octant "plugin", but it still seems possible 🤔.
Let me know if you see any blockers with this.


Add static overlay components

[x] .OverlayModeless
[x] .OverlayModal

So the var --stacking-system-message is going to be applied to all OverlayModeless components?

Yep. Unless we modify/update the stacking order. There's a case for changing the var name from --stacking-system-message to --stacking-overlay-modeless, I guess.

Is the --stacking-system-message var being used elsewhere?

Not currently, and no plans to with what we can see.

@ohskylab scope creep to do as part of this?

No, reasonable to change here. The var() def happens  in style guide and I have a couple of other changes for that, so will queue up some mini-PRs when I add the amend for this.


Flake: TestRefreshingCertificate panics

panic: Log in goroutine after TestRefreshingCertificate has completed

goroutine 8 [running]:
testing.(*common).logDepth(0xc0002c39e0, 0xc0000b2000, 0x17e, 0x3)
	/usr/local/go/src/testing/testing.go:730 +0x581
testing.(*common).log(...)
	/usr/local/go/src/testing/testing.go:712
testing.(*common).Fatalf(0xc0002c39e0, 0x150c996, 0x2e, 0xc0000ac140, 0x5, 0x5)
	/usr/local/go/src/testing/testing.go:780 +0x82
github.com/golang/mock/gomock.(*Controller).Call.func1(0xc0003214d0, 0x140c2a0, 0xc0000522a0, 0x14ec810, 0x14, 0xc00000e460, 0x2, 0x2, 0x0, 0x0, ...)
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/vendor/github.com/golang/mock/gomock/controller.go:231 +0x485
github.com/golang/mock/gomock.(*Controller).Call(0xc0003214d0, 0x140c2a0, 0xc0000522a0, 0x14ec810, 0x14, 0xc00000e460, 0x2, 0x2, 0x0, 0x1, ...)
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/vendor/github.com/golang/mock/gomock/controller.go:247 +0xb4
github.com/Azure/ARO-RP/pkg/util/mocks/keyvault.(*MockManager).GetCertificateSecret(0xc0000522a0, 0x16fafa0, 0xc000120010, 0x14e74e7, 0xf, 0xc00004a420, 0xc000071f78, 0xc000390240, 0xc0002d1e88, 0xc0002d1f38, ...)
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/pkg/util/mocks/keyvault/keyvault.go:88 +0x131
github.com/Azure/ARO-RP/pkg/env.(*refreshingCertificate).fetchCertificateOnce(0xc0000a8150, 0x16fafa0, 0xc000120010, 0x0, 0x0)
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/pkg/env/certificateRefresher.go:69 +0x9a
github.com/Azure/ARO-RP/pkg/env.(*refreshingCertificate).fetchCertificate.func1(0xc0000ac0a0, 0xc0000a8150, 0x16fafa0, 0xc000120010)
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/pkg/env/certificateRefresher.go:93 +0x144
created by github.com/Azure/ARO-RP/pkg/env.(*refreshingCertificate).fetchCertificate
	/home/cloud-user/agent/_work/1/go/src/github.com/Azure/ARO-RP/pkg/env/certificateRefresher.go:86 +0x79
FAIL	github.com/Azure/ARO-RP/pkg/env	0.257s

For visibiltiy: had a chat with @petrkotas. This looks like a different sympthom of the issue which is being fixed in #1636.

@petrkotas I think there's still a flake here.  On unit test run of #1645 it failed the first time which had your changes from #1636.  I reran and it worked successfully.  Tried to reproduce locally but I couldn't.
Look at build run 1 (number 2 passed successfully) here.  You might have to click "Show Previous Attempts".

We are currently using time to do these tests.  Maybe we could use clockwork or something that mocks time to get from what seems to be a race.


Webpack support

Firstly, great library.
Had a little issue using it with Webpack.

Installed using Bower
import SVGMorpheus from 'svg-morpheus';

However empty object was being returned. Ended up changing the default src file to the unminified version and exposing by - module.exports = SVGMorpheus
Is there a better way to import this file for use with Webpack?
Cheers

@ahamo That should work ok now. Please get the version 0.3.1 and try again.

Thanks Alex, you're a champ @alexk111

would you please upgrade npm module?


Add stretched grid to remap_restarts

This PR is to try and add the stretched grid changes from @wmputman in regrid.pl to remap_restarts.
I'll keep it draft until I can get nodes on discover to test and all with C270.
cc: @weiyuan-jiang as I might be asking for his help 😄

Closing


Export all records as a workbook

Create a workbook (XLSX format) to download with all records in the database for purpose of quality assessment and data curation.
One line per record with trait name, and trait value (norm_value field), weight and references.
Example of the source code for generation of the report is available in https://github.com/jrfep/fire-veg-aust, folder python/Report-output.

Berin and Renee suggest having:

[ ] norm value column: will show selected category for categorical data and summary of best (lower--upper) for numerical data
[ ] Additionally, for numerical data have the triplet value as separate columns (best, lower, upper)
[ ] raw value column (currently this can be consulted following the link to the record in the database)
[ ] method of estimation column


Badge origin error

Steps to reproduce
No steps needed just use badge component prop badge origin with one origin only horizontal or verticalare
Current behavior
if we use one origin at a time its gives us error the
Expected behavior
should allow one origin not both at the same time,
Context
No response
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: badge origin

It's required to provide both horizontal and vertical to anchorOrigin. Please see the demo https://mui.com/material-ui/react-badge/#badge-alignment

I think the docs should mention this. PR welcome to add a callout that both keys are required.

But @siriwatknp why we really need to give both I think it should be Partial to add one or both


How to run examples like on https://magicleaphelio.com/devsamples/

I keep getting the error:
Uncaught ReferenceError: mlWorld is not defined
    at HTMLElement.render (prismatic.min.js:1)
    at HTMLElement.attributeChangedCallback (prismatic.min.js:1)

When trying to run the intermediate sample from here: https://developer.magicleap.com/learn/guides/prismatic-positioning-quads-and-scrollable-content
Or any of the samples from this repo.

hey @netgfx are you trying to run this in Helio on a Magic Leap device or through another browser?

On Chrome (from what I gather, this isn't possible right?). If there is another way to test without the headset on (developer hub maybe?) please do tell.

Right, at the moment, it's only possible to render and view 3D content with Prismatic through Helio.
You can, however, use the alt-image attribute to fallback to a specified flat image when viewing on another browser.  There's an example of this here: https://glitch.com/edit/#!/hello-prismatic?path=index.html:20:6
alt-image documentation here

Thanks really helpful! Which is the right channel to ask questions about Prismatic/Helio browser etc, stackoverflow / github via issues / or somewhere else?

Np! For anything Prismatic related, I would file an issue here.  If it's related to the Helio Browser specifically, I would post on magic leap's developer forum

Thanks appreciate the help!


Question: how do I specify Paths (i.e. /healthecheck) in config.endpoint.v3.Endpoint.HealthCheckConfig

Title: Question: how do I specify Paths (i.e. /healthecheck) in config.endpoint.v3.Endpoint.HealthCheckConfig
Description:
I would like to add a path like /healthcheck to the config.endpoint.v3.Endpoint.HealthCheckConfig on my Endpoints but looks like I can only specify address and port
[optional Relevant Links:]
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/endpoint/v3/endpoint_components.proto#envoy-v3-api-msg-config-endpoint-v3-endpoint-healthcheckconfig

You can only speicify the path in the configuration of cluster health checker. See https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/health_check.proto#config-core-v3-healthcheck-httphealthcheck
The config.endpoint.v3.Endpoint.HealthCheckConfig is just used to override the health check address.

Right, #28375 is relevant, looks like we can extend this to override the global one for different endpoints in the same cluster.

Thank you guys, we can use the health check config at cluster level and only override the address at endpoint level for now just fine :) for me this can be closed, but if you want to keep it open feel free to do so

Feel free to close this. Thanks!


Update Oboe.js definition

Added a missing function definition for the node event.
Refactored the definition so the definitions can be referenced without having to import the module which allows for referencing in other ambient module definitions.

@heymagurany Thanks mate!


Bluetooth: Mesh: Only settings load post mesh init

Prevent mesh stored settings from triggering unless bt_mesh_init has been called.
Signed-off-by: Anders Storrø<EMAIL_ADDRESS>

From what I can see your suggestion works @PavelVPV. You think it is worth our time to do further exploration on how to do this more neat/efficient, or are we content with this solution?

Should we check BT_MESH_INIT flags in bt_mesh_provision? E.g. in case when BT_SETTINGS disabled and an application self-provisions the device?

Should we check BT_MESH_INIT flags in bt_mesh_provision? E.g. in case when BT_SETTINGS disabled and an application self-provisions the device?

I guess it is not necessary since it is already checked implicitly here: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/mesh/settings.c#L64
If initialization happened then BT_MESH_VALID is set that is checked in the provisioning procedure.

Should we check BT_MESH_INIT flags in bt_mesh_provision? E.g. in case when BT_SETTINGS disabled and an application self-provisions the device?

I guess it is not necessary since it is already checked implicitly here: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/mesh/settings.c#L64
If initialization happened then BT_MESH_VALID is set that is checked in the provisioning procedure.

In case BT_SETTINGS is disabled, settings.c is not compiled.
See this: https://github.com/zephyrproject-rtos/zephyr/blob/0620cb1fe1807a4a0e1ea83b300138d27b7fc175/subsys/bluetooth/mesh/CMakeLists.txt#L27

@Andrewpini, seems these changes broke oob provisioning bsim tests.


Long running crash and crash with Teams sharing.

Environment
Platform ServicePack Version      VersionString

Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Using Windows Terminal Preview
Steps to reproduce
1st type of crash:  Leaving the terminal with a bunch of windows open causes it to crash in a day or two of use.  This happens consistantly.  Perhaps a leak of some sort?
2nd type of crash:  Share terminal with Microsoft Teams, screen sharing of the terminal window.  ALT-Tab to another window and click terminal on the Taskbar.  You get a brand new terminal as the old one has crashed.
Expected behavior
Not a crash
Actual behavior
Crash

/feedback


Subclass automatically calls parent's _ready()

Operating system or device - Godot version:
Windows 10, Godot 2.1
Issue description (what happened, and what was expected):
It's easier to just read the screenshot, pay attention to the Output tab...
The parent's _ready() are called automatically, even when the subclass' didn't call it. Not sure if bug or working as intended.

Duplicate of #6500
It's not a bug.


Problem with font-weight

If I set this on CSS
font-weight: 600

or this
font-weight: "600"

I get errors running the App. The first one maps to 600 while the second one maps to "\"600\"".
Need a way to have it mapping to "600".
The only solution so far to bypass this problem is:
font-weight: "JS('600')"

The problem has been resolved, please update to the latest version.


[BUG] LREM does not pass the number of removed items to the callback.

Node Version: v8.1.2
Node Redis Version: 2.8.0
Redis version: 4.0.8
Steps to replicate
In redis console
<IP_ADDRESS>:6379>  lpush test 'hello'
(integer) 1
<IP_ADDRESS>:6379> lrange test 0 1
1) "hello"

Script (redis.js)
const redis = require("redis")
const redisClient = redis.createClient("redis://<IP_ADDRESS>:6379")
redisClient.lrem('test', 0, 'hello', function(number){
  console.log(number)
})

run with node redis.js
Expected output of the script the to print the no of removed items
Actual Output is null
Test in redis console to confirm removal of the item from list
<IP_ADDRESS>:6379> lrange test 0 1
(empty list or set)

The first argument in the callback is the error object, which is null on success.  This should work:
redisClient.lrem('test', 0, 'hello', function(error, number){
  console.log(number)
})

@dirkbonhomme thanks. This is working


Add roadmap image and ecosystem document.

This is based on feedback from Brian Colby, who was using Juttle for a
while and then mentioned that he missed the browser-based
visualizations, not knowing that juttle-engine existed.
Add a roadmap image that shows where juttle lies in the overall
ecosystem. The roadmap image links to a new ecosystem page that lists
all the main projects and a larger ecosystem image with everything
labeled.
The idea is that we would add the smaller roadmap image to all the
github READMEs.
@mnibecker @go-oleg I took Mike's blog post that named the components, but renamed his juttle-viewer to juttle-client-library and called juttle-viewer a packaging of juttle-viz and juttle-client library. I think this is accurate, can you comment?
Also @dmehra @demmer @VladVega

@davidvgalbraith

Updated, please look again?

+1
The same effort was started on the wiki, but not updated after the change outrigger->juttle-engine. Please duplicate to there as well. https://github.com/juttle/juttle/wiki/Project-Organization

At a high level I think the diagram and descriptions look great, but I really don't like the "You are here" image at the top of the repository. It's confusing and distracting from the main message.
I think it would make more sense to have a dedicated section below the fold (like after Installation) in each of the repos that has a larger version of the image with the you are here business and a bit of text that explains what this image is and why it's here.

New layout and addressed @demmer's feedback, how about this layout?


Simplify meta.yaml file

The meta.yaml file seems to have quite complicated dependencies, meaning that building the conda package takes a lot of time.

And most importantly, this needs to be changed in the bioconda recipe.

Updated the bioconda recipe in this PR. From the testing of the build process locally, removing dependencies boundaries does not improve memory consumption or build time. But it is still useful to simplify it, and we will see how it behaves in practice.

If we don't have at least a hope this helps I am not sure it is worth to change. When installing locally we could compare the consumption when using conda vs mamba (https://github.com/mamba-org/mamba)

It seems that installing the package locally does not require extensive memory (we observed something up to 500 MB). Let's try to remove the dependency boundaries; hopefully, it will help UMSA with the installation process.
Anyway, I opened another PR because the previous one was automatically closed with merging v0.2.3 update PR.


Feature Request. Find in Files/Replace in Files

Godot version:
Any
OS/device including version:
Any/Engine Level
Issue description:
there is a find/replace in file but this should be expanded to files throughout the project to include more search capabilities. Also can we have button Icons not be fixed sizes, I seen no reason for this. there is no way to adjust the rect of a button fitted with a texture in the Icon property.
Steps to reproduce:
This would be a tremendous feature since a lot of people use external code editors solely for mass refactoring, plus just a nice feature in general.
Minimal reproduction project:

Related to #2592.

Wow from 2 years ago talk about being buried.

It's not much about being buried, it's more about no one caring enough to actually make it happen.

You might as well comment on it if you're interested in it... or if you know how to it would be awesome if you could go ahead and implement it :)

I have a modification of TODO plugin that do that (only search, not replace) but godot 2 do not expose to gdscript enought methods to scroll to any line in the script, so you only see where are the search result and the line, and you need to scroll to that manually. TODO plugin it's not ported to godot 3... I suscribe this feature request with all my hearth. Perfect example of this feature is the way that is implemented in notepad++(find in open files, replace in open files, with a contextual window with the search results that allow to jump to file and line).... But i'm realist about that, this is not trivial, i'm happy with code folding and function list, this is "the third" of the trinity of the text-editor features in my opinion...

Duplicate of #2592 ?
I started such a tool this evening :p

I was going to post the same suggestion! I'd really like being able to mass-search and mass-replace across all project scripts.
Another example of a program that does this well is Bluefish, which is the one I've been using. But it would be much better to be able to do all script-related stuff directly inside of Godot.
Here's an idea to polish it further: being able to choose between searching in all files in the project, searching in open files or just in files in a particular folder.  But just a basic option that includes all files would be really nice already.
Btw, thanks for your work, guys! :) This engine is awesome. I hope I can contribute some day.


Refs #27624 -- Optimized Query.clone() a bit.

Turn explain info into one attribute instead of three
Remove unnecessary if ... is None paths, which are already shallow-copied in the __dict__.copy() call.

ticket-27624

I've got a separate branch with much the same changes (only setting if not None), having noted basically the same. However I never bench'd the difference in isolation (it's part of a bigger changeset) - can we do so?
As you mentioned on the ticket:

But it may not be worth the effort to change and profile.

Honestly I think any and every effort to speed up (or obviate) cloning costs is worthwhile, as it is a large source of slowdown in things like prefetch_related. I've got a change which could land subsequent to this which may help, and a couple of other ideas off the back of that.

I've got a separate branch with much the same changes (only setting if not None), having noted basically the same.

Link? Did you make a PR?

However I never bench'd the difference in isolation (it's part of a bigger changeset) - can we do so?

Basic benchmark on Python 3.9.7.
Before:
In [1]: from django.db.models.sql.query import Query

In [2]: %timeit Query('somemodel').clone()
7.09 µs ± 53.9 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

After:
In [1]: from django.db.models.sql.query import Query

In [2]: %timeit Query('somemodel').clone()
6.87 µs ± 106 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Honestly I think any and every effort to speed up (or obviate) cloning costs is worthwhile, as it is a large source of slowdown in things like prefetch_related. I've got a change which could land subsequent to this which may help, and a couple of other ideas off the back of that.

Okay, if we're happy to carry on stacking micro-optimizations then I'm happy to see them coming!

Link? Did you make a PR?

Apologies if it came off like you were treading on my toes (if anything, I'm treading on yours), there's no public branch or PR; it was part of a larger changeset which I was considering proposing (which is also something you were looking at in the same ticket) as a ticket once I've found time to sit down and step through the various commits noting any differences/regressions.
There are a couple of "related" PRs (insofar as my target is "prefetch_related is slow, lemme try and fix that") floating around on here, but none that directly touch this bit.

@adamchainz Thanks :+1:


Refer back to original source from segment

Variation(s)

need to not lose rights statement on source for the segment

Proposed Solutions
Video API @id, can reference info.json for rights.  In Presentation API, can have link to service.
Additional Background
Source: BL workshop notes
Interest: 60%

Also embedded metadata as server implementation consideration, ala coping rights metadata from image source to tiles.

Between info.json and Presentation seems like we'd have rights covered. Is the embedded metadata via the server implementation something we'd want to encourage?

Only time this is actually an issue is if there's a bitstream api that allows separate download of the segment.


Azure spelling fixes

Adding acr, ACR, azurecr, and tsv to spellcheck allow list.

@xescab Please merge this in and then your other PR will also get updated.


Form Herds from Multiple scf.forall nests.

In order to support code generated from loop-peeling, we'd like to look at forming herds from multiple scf.forall statements ( rather than targeting just one), so that L1 allocations can stay local within a herd definition.

Here's a proposal https://github.com/nod-ai/iree-amd-aie/issues/210

I have an example showing IR before peeling, after peeling and after mapping to a herd with core ids https://gist.github.com/yzhang93/7ab35c4da0f958d4ffaca31977b91c7f. We can have a discussion based on this.


Removes border around node.js logo in IE10

While I was testing #96 I noticed a border around the logo in IE10.
This removes that border.

Thanks!


output allocations.csv from galileo

A suggestion made was to make a galileo command that specifically outputs an allocations.csv format, so you don't have to do the shell glue yourself outside galileo.
Originally posted by @plaidfinch in https://github.com/penumbra-zone/penumbra/issues/700#issuecomment-1108893535
See related suggestions in #700

For each address/row, we allocate:
* "1_000__000_000","upenumbra"
* "100","gm"
* "1","cube"


Fix sync status lost on reconciler pod replacement

Fix reconciler ignoring/erasing status from previous reconciler
instances by priming the in-memory cache from the RSyncs status.
Example: status.sync.commit
Exception: errors are not parsable and may still be lost.
Cache the last known source, rendering, and sync spec seperately
from the current reconciler config, and use when testing equality.
This allows updating the status when only the spec has changed.
Previously only the commit, message, and errors were checked.
That was fine until initialization from RSync status was added.

Dependencies:

https://github.com/GoogleContainerTools/kpt-config-sync/pull/1283
https://github.com/GoogleContainerTools/kpt-config-sync/pull/1280
https://github.com/GoogleContainerTools/kpt-config-sync/pull/1282

Looks like the initializing the cache from RSync status has broken status.rendering.oci.dir somehow, probably because it's not part of the renderingStatus struct in-memory. That broke TestPublicOCI, TestPolicyDirUnset, and TestUpdateRootSyncGitDirectory.
And it looks like there's another potentially related issue with the status.rendering.commit not being as expected. That broke TestHydrateKustomizeComponents and TestHydrateHelmOverlay.

Alright, it took a fair amount of refactoring, but I was able to add the git/oci/helm source spec into the reconcilerStatus in a way that allows it to be considered when testing for quality. Without this change, the status update is skipped if the RSync spec changed without affecting the status (ex: sync dir changed but not commit).

/retest
Huh. Got a CrashLoopBackoff, but I don't see any error in the logs. Maybe just a kind/docker flake issue on CI.
          Warning  FailedMount       8m8s                kubelet            MountVolume.SetUp failed for volume "configs" : failed to sync configmap cache: timed out waiting for the condition
          Warning  FailedMount       8m8s                kubelet            MountVolume.SetUp failed for volume "otel-agent-config-vol" : failed to sync configmap cache: timed out waiting for the condition

/hold
Blocked on https://github.com/GoogleContainerTools/kpt-config-sync/pull/1286 and needing to redo https://github.com/GoogleContainerTools/kpt-config-sync/pull/1283

/unhold


coord hiding doesnt work again

again :0
When SpawnOnJoin is enabled if you try to /login nothing happens
Minecraft 20w27a
simpleauth 1.4.6
fabric-api-0.14.2+build.373-1.16.jar

Huh, that's strange ... any errors in console?

I'm closing this since it's no longer relevant (snapshot phase is over) and coordinate hiding works in latest 1.16.2.


invalid go version

Hello how can i fix that?

in the go.mod file, change the version to 1.23,
it worked for me.

Hello, please run the installation command again because I have provided a new update. If you still have the same problem, update GO and try again. Please let me know if the problem persists. Thank you.
Fallparams
go install github.com/ImAyrix/fallparams@latest

Go

https://go.dev/doc/install

@hosainxade @phoelion

Thank you that worked!

Thank you that worked!


Swap must be disabled before initializing control-plane

Otherwise we get this error:
error execution phase preflight: [preflight] Some fatal errors occurred:
	[ERROR Swap]: running with swap on is not supported. Please disable swap

/sig cluster-lifecycle

this is already mentioned in the install docs:

Swap disabled. You MUST disable swap in order for the kubelet to work properly

https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/
/close


Vue flags not working correctly

Vue version
3.5.13
Link to minimal reproduction
https://github.com/rstoenescu/vue-flags-bug
Steps to reproduce
Please see the reproduction repo (a barebones Vitejs project folder): /vite.config.js for flags configuration and /src/App.vue for an Options API component.
define: {
  // No effect, it's still included
  __VUE_OPTIONS_API__: 'false',

  // Has the opposite effect: devtools will be enabled for prod builds!
  // Commenting this out will disable devtools in prod builds.
  __VUE_PROD_DEVTOOLS__: 'false',

  // Has the opposite effect: mismatch details will be included in prod builds!
  __VUE_PROD_HYDRATION_MISMATCH_DETAILS__: 'false'
},

Run yarn build then serve the /dist folder. App.vue, which is an Options API component runs fine and executes its Options API definition.
Run yarn build with vite.config.js > __VUE_PROD_DEVTOOLS__: 'false',. Serve the /dist folder and notice that Vue Devtools is available and running. Then again with the vite.config.js __VUE_PROD_DEVTOOLS__ line commented out. Notice that Vue Devtools is not available.

What is expected?

Options API to not be included when define > __VUE_OPTIONS_API__ is set to false.
Vue Devtools not to be available for production builds when define > __VUE_PROD_DEVTOOLS__ is set to false.
Hydration mismatches will still be available in production builds when define > __VUE_PROD_HYDRATION_MISMATCH_DETAILS__ is set to false.

What is actually happening?
Following the configuration from my reproduction repo:

Options API is still running fine. No build errors also.
Vue Devtools are available in production builds.
Hydration mismatches are still be available in production builds.

System Info
No response
Any additional comments?
No response

https://github.com/vitejs/vite-plugin-vue/blob/bebb87b4b477e57d4801ad965659b28dc95e05bc/packages/plugin-vue/src/index.ts#L245-L248

It's a vite-plugin-vue bug, see https://github.com/vitejs/vite-plugin-vue/issues/480


fix: ensure full refresh when color scheme changes

This commit fixes a bug in the highlight setup in highlights.lua. The bug was causing highlights not to refresh when the color scheme is changed. The fix involves introducing an optional force_refresh parameter to the setup and setup_builtin_hl_groups functions. When force_refresh is true, the highlights are refreshed even if they are already set.
Alternative Solution:
An alternative solution to this bug could involve extracting the three vim.api.nvim_set_hl calls into a new function (e.g., force_refresh). This function would be called in the callback of autocmds.setup function, ensuring that the highlights are always refreshed when this callback is executed. This approach could potentially make the code more modular and easier to understand, but it would also introduce more changes to the current codebase.

The bug was causing highlights not to refresh when the color scheme is changed.

The color scheme needs to reset the highlight groups. If it doesn't, it's a bug in the color scheme, not indent-blankline.

I can confirm that this bug was not present in v2.20.8. However, I am not certain whether we should attribute the issue to the color scheme.


CircularProgress icon is same color on raised Button

Hello,

What RMWC Version are you using [major]:

Describe the bug with as much detail as possible:

I've encountered a visual bug when placing a CircularProgress component inside a raised Button. The CircularProgress color appears to be the same as the button's background, making it difficult to distinguish.
can be reproduced in https://rmwc.io/buttons

@Julien-coeurvolan-enedis  Nice catch! Thanks for the issue! We are working on the v14 release, but we will take a deep look at this right after!


Unofficial grimoire fix

There was an issue with overcast not working due to data not being pasted from dialog to test and also calculation of user entries:
        for(let key in this.userEntry)
        {
            if (["string", "boolean"].includes(typeof this.userEntry[key]))
            {
                this.fields[key] = this.userEntry[key]
            }
            else if (Number.isNumeric(this.userEntry[key]))
            {
                this.fields[key] += this.userEntry[key];
            }
        }
        this.tooltips.finish(this, "User Entry")

since overcast value in cast dialog is a numeric field, instead of passing it to test, it was either incremented on every input change, or treated as NaN, due to null + number calculation.
Also, minor typo and translation in base dialog.

@moo-man - this PR has been updated to latest changes.

@moo-man - went through comments and updated PR.


reproduce issue with timestamp as key

Oliver has switched the odata-v2 proxy to use the new db layer in his tests.
This reveals a problem with datetime elements as key.
On first glance, the ISO function formats datetime values as timestamps which cannot be found anymore as we don't apply the same function on where clauses. Alternatively, we must not use the function for datetime elements.
caused by #131

The failing one is exactly one of the cases documented to fail:
For example, all these work:
SELECT.from(Foo).where `someTimestamp = anotherTimestamp`
SELECT.from(Foo).where `someTimestamp = someDateTime`
SELECT.from(Foo).where `someTimestamp = ${new Date}`
SELECT.from(Foo).where `someTimestamp = ${req.timestamp}`
SELECT.from(Foo).where `someTimestamp = ${'2022-11-11T11:11:11.123Z'}`

While these would fail, because the input values don't comply to the rules:
SELECT.from(Foo).where `createdAt = ${'2022-11-11T11:11:11+02:00'}` // non-zulu time zone
SELECT.from(Foo).where `createdAt = ${'2022-11-11T11:11:11Z'}` // missing 3-digit fractions

This is because we never can reliable infer the types of input to where clause expressions → it's strongly recommended to use always use Date objects there, e.g.:
SELECT.from(Foo).where { createdAt: new Date('2022-11-11T11:11:11Z') }`

The failing one is exactly one of the cases documented to fail:

I've seen this and therefore mentioned that we either need to support it on sqlite level or change the runtime to generate a compliant query. As of now, the runtime always sends ISO strings without ms precision.

just tested and also works with current runtime implementation :)


How can I update an entry in resolver and trigger an update in watchQuery?

For example I have an entity Book and I need to mock a mutation changeBookName. I am writing something like this:
Mutation: {
        changeBookName(obj, args, context) {
          let book = context.mirageSchema.findBy('Book', {uuid: args.uuid});
          book.update({ name: 'aaaaa' });
          return book;
        },

And I see the response is correct in console but apollo client ignores this change.
I use Ember 3.28.12, "ember-apollo-client": "^4.1.1", and watchQuery under the hood
Thanks.

Ok, I've managed to resolve that problem, finally! Apollo is not updating entities immediately so it could show outdated data in observables sometimes. In most cases it is not so important but sometimes can cause troubles. I've managed to separate the updates with code splitting via setTimeout, so the problem was on my side 😄


Make Option<Interests> the same size as Interests

Issue #934
The problem in test case is still waiting. https://github.com/tokio-rs/mio/issues/934#issuecomment-492096665

@Thomasdezeeuw Could you please review this?
Though, I thought the code newly needed for sub Interests would add to the coder's thinking burden.

I'm good w/ this whenever @Thomasdezeeuw

@FXTi thanks!


README.md for azure-test-watcher

Missing readme for azure-test-watcher was causing the verify readme step to fail.

/azp run java - appconfiguration - ci

/azp run java - appconfiguration


Allow source tools to work with tuples

I can use source/values (without any source tools) to set an LED to match a button:
led = LED(2)
button = Button(3)

led.source = button.values

And I can used the negated to set an LED to always be the opposite of a button:
led.source = negated(button.values)

I can use the first technique to pair an LEDBoard and a ButtonBoard of the same size:
leds = LEDBoard(2, 3, 4, 5)
buttons = ButtonBoard(6, 7, 8, 9)

leds.source = buttons.values

But I can't use negated in the same way:
leds = LEDBoard(2, 3, 4, 5)
buttons = ButtonBoard(6, 7, 8, 9)

leds.source = negated(buttons.values)

Instead, I have to iterate over the zip of the two collections and apply negated to each one in turn:
for led, button in zip(leds, buttons):
    led.source = negated(button.values)

(or if I were @waveform80, set the source to some crazy tuple comprehension)
I suggest we either extend functions like negated to work with tuples as well as single values, or provide additional functions which do the same for collections, e.g. negated_multi (eugh terrible name). I'd much prefer the former :)

Haha, (almost exact) duplicate of #365 ;-P

Ah!


Parallel deploy

... parked off the side of #295 as scale of change was getting to big to resolve

Closing this out as the complexity is much higher than originally thought (as worked through in the Operator)