Launching ubuntu creates blank screen

Please paste the output of the following command here: sudo startunity

Please describe your issue:
I installed Ubuntu by doing      sudo sh -e ~/Downloads/crouton -t unity
and when i launched it it only showed a blank desktop
If known, describe the steps to reproduce the issue:

@nmkrupp,
Please paste the output of the following command below: sudo edit-chroot -all

I am getting this problem as well, here is my startunity and edit-chroot -all:
chronos@localhost ~ $ sudo enter-chroot
Entering /mnt/stateful_partition/crouton/chroots/xenial...
Unknown username "geoclue" in message bus configuration file
(xenial)dl@localhost:~$ startunity

_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root

X.Org X Server 1.18.4
Release Date: 2016-07-19
X Protocol Version 11, Revision 0
Build Operating System: Linux 4.4.0-128-generic x86_64 Ubuntu
Current Operating System: Linux localhost 3.18.0-18543-gac154810530e #1 SMP PREEMPT Wed Sep 26 00:36:13 PDT 2018 x86_64
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 3584000 verity payload=PARTUUID=f2e60aad-4c24-cf43-b6cf-b4e68926e40f/PARTNROFF=1 hashtree=PARTUUID=f2e60aad-4c24-cf43-b6cf-b4e68926e40f/PARTNROFF=1 hashstart=3584000 alg=sha1 root_hexdigest=05ee24d781d171ef0f1fca1cf0be8dcdb7ca4988 salt=b31baadcd4fd5980bd7aa2dd4744d4a3c1ff462c6efc1787aa041b13b8753847" noinitrd vt.global_cursor_default=0 kern_guid=f2e60aad-4c24-cf43-b6cf-b4e68926e40f add_efi_memmap boot=local noresume noswap i915.modeset=1 tpm_tis.force=1 tpm_tis.interrupts=0 nmi_watchdog=panic,lapic intel_idle.max_cstate=7
Build Date: 10 August 2018  09:33:05AM
xorg-server 2:1.18.4-0ubuntu0.8 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.33.6
        Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Sun Sep 30 17:57:36 2018
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Error org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.LibCrosService was not provided by any .service files
xf86EnableIOPorts: failed to set IOPL for I/O (Operation not permitted)
Error executing command as another user: Not authorized

This incident has been reported.
crouton: version 1-20180718130616~master:5d4c3014
release: xenial
architecture: amd64
xmethod: xorg
targets: touch,unity-desktop
host: version 11021.28.0 (Official Build) beta-channel cave
kernel: Linux localhost 3.18.0-18543-gac154810530e #1 SMP PREEMPT Wed Sep 26 00:36:13 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
xrandr: Output eDP1 is not disconnected but has no modes
xrandr: Output DP1 is not disconnected but has no modes
xrandr: Output DP2 is not disconnected but has no modes
xrandr: Output HDMI1 is not disconnected but has no modes
xrandr: Output HDMI2 is not disconnected but has no modes
Kicking xrandr again
xrandr: Output eDP1 is not disconnected but has no modes
xrandr: Output DP1 is not disconnected but has no modes
xrandr: Output DP2 is not disconnected but has no modes
xrandr: Output HDMI1 is not disconnected but has no modes
xrandr: Output HDMI2 is not disconnected but has no modes
Kicking xrandr again
(II) AIGLX: Suspending AIGLX clients for VT switch
Error org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.LibCrosService was not provided by any .service files
^C/usr/bin/xinit: connection to X server lost

waiting for X server to shut down Hangup
Hangup
Running exit commands...
(II) Server terminated successfully (0). Closing log file.

/usr/bin/xinit: unexpected signal 2
(xenial)dl@localhost:~$ logout
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
chronos@localhost ~ $ sudo edit-chroot -all
name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20180718130616~master:5d4c3014
release: xenial
architecture: amd64
xmethod: xorg
targets: touch,unity-desktop
host: version 11021.28.0 (Official Build) beta-channel cave
kernel: Linux localhost 3.18.0-18543-gac154810530e #1 SMP PREEMPT Wed Sep 26 00:36:13 PDT 2018 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

Any help would be appreciated.

@nmkrupp,
Do you get a blank screen when launched from outside the chroot in a shell session with:

sudo startunity

You could try adding a different desktop/target like lxde-desktop instead of unity.
You could also try adding the 'xiwi' xmethod/target and see if unity works with it.
Hope this helps,
-DennisLfromGA

@DennisLfromGA
I had the exact same issue - ie I was getting a blank desktop.
Note: I had been using beta channel on my chromebook from last June or so and crouton had been running perfectly, it was only when I reverted to stable channel from the beta, that I got this error.
Your tip above of adding xiwi method worked beatifully and resolved my issue!
For the benefit of others and @dmlyons @nmkrupp, here is the command (assuming you are using xenial i.e. Ubuntu 16.04)
sudo sh ~/Downloads/crouton -t xiwi -u -n xenial
PS: I am using an ASUS C302c Chromebook


Java extractor: ensure output directory exists before writing kindex [phab:D551]

Created by schroederc at 2015-10-12 22:44:51:

shahms accepted this revision at 2015-10-12 22:46:42

zarko accepted this revision at 2015-10-12 22:47:48


Allow a Form to mimic a model with an attribute with the same name

Currently, having a Form with an attribute with the same name of the mimicked model does not work well. In some cases, the value of the attribute is overwritten with the mimicked model data, resulting in invalid data.
With these changes, data from the mimicked model will override the params_hash hash values and the behavior will be the right one.
The only unsupported scenario is when the attribute contains a hash value, as it would be very difficult for the code to determine if the hash is the mimicked model information or the value for the attribute.
I modified tests to check this situation.

@andypike We have rebased this branch as well, so it's easier for you to review it and potentially merge this. Thanks!


[SECURITY] Tampering with Bluetooth metadata

In a recent report to the Swiss CSIRT, EPFL professor @vaudenay and Martin Vuagnoux point out that the Bluetooth metadata containing the transmission power is merely encrypted with AES-CRT, and not authenticated (cf Section 3.5 here). This makes tampering with parts of the metadata possible, and highly increases the chances of success of some forms of replay attacks, particularly in conjunction with the validity of RPI for 2 hours (see Section 3.6).

This makes the entire system vulnerable to false positive attacks, with the attack surface growing much faster than the utility of the system.
I have been told by some in the periphery of the German community working on Corona Warn that this is a flaw well known here, but have not been able to gain confirmation. Has it been documented anywhere?

Thanks for the report. Our security experts will have a look at that.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

Good morning @pdehaye,
thanks for reaching out.
As described in our mobile architecture documents and especially the architecture diagrams (Android/iOS) we do not manage the Bluetooth transmission and/or reception and therefore do have less influence on both scenarios you mentioned above. The Bluetooth management and related activities are handled by the mobile operating systems and their corresponding Exposure Notification Framework.
Furthermore, an attack precondition to create false positives is to be able to tamper upload authorizations to spread a false notification status at the end.
Nonetheless we highly appreciate your remarks and will further discuss them with the mobile operating system providers.
Happy Friday
@haxxbard

Furthermore, an attack precondition to create false positives is to be able to tamper upload authorizations to spread a false notification status at the end.

This is wrong. An attack precondition is to collect Rolling Proximity Identifiers whose Temporary Exposure Keys will later be (correctly) revealed. One scenario is thus harvesting of Bluetooth beacons near a hospital at 7.30am, tampering with them, and then replaying them in the middle of the financial district. Since it is deployable on consumer phones, smartphones (even of non-participants) or IoT devices are part of the attack surface through hacking.

therefore do have less influence on both scenarios you mentioned above
Have you considered reaching out to other European projects and discussing how the API could be changed?

Please re-open the issue, or at least point me to where this vulnerability could be reported while CoronaWarn undergoes a security review later.

Regarding 3.5 "Unauthenticated Metadata" - rather than flipping bits in unknown values (which has a decent chance that you are actually increasing a value that you wanted to decrease), the attacker would be better off simply replaying the message with a much higher output power. I don't think this aspect is a real weakness in the protocol.

@mh- I am aware of this, but it really depends on which type of attacker you are considering. A hacker leveraging someone else's device might not have that opportunity for instance. An attacker leveraging someone else's SDK might not have that opportunity either. This affects scale, likelihood, cost, motive, etc of the attacker, which in turn affcet legal questions around the legal status of this data (as personal data or not), depending on the country.
Additionally you would detect this differently in the two attack modes: one on signal strength abnormally high, one on multiple payloads that are very similar.
Finally, depending on undocumented parts of the protocol, I suspect in dynamic environments you would be able to detect which payload was emitted at higher strength, due to timing and physical characteristics of the signal.

Reviewing the whole thread, please make sure to include this tampering attack also in your documentation, as it has downstream security and legal effects, especially if you care about interoperability. The trade-offs will not be the same everywhere you are hoping to interoperate with.

@pdehaye Again, the observation that one can flip bits in the plaintext with CTR mode is correct, but it helps only if you know the original value, or you can make reasonable assumptions about it. This significantly reduces the relevance of this attack vector.
Also, your statements are very broad, e.g. "downstream security and legal effects" - if you wish to engage in a discussion, it might help to be more specific.

As already stated by @haxxbard, we do not manage the Bluetooth transmission and/or reception. Please address these concerns directly to Apple and Google, they have dedicated processes especially with respect to security.
In case you find out a security vulnerability in one of the CWA components, please see the respective SECURITY.md file in the respective repositories, e.g. https://github.com/corona-warn-app/cwa-app-ios/blob/development/SECURITY.md for the iOS client.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

@mh- The downstream security and legal effects refer to consequences for the legality analysis of the system deployed. The app developers can chose to ignore problems "lower down the stack", at the protocol or Bluetooth layer, but at some point someone in Germany will have to deploy it and evaluate the legality of the app (who?), which will have to include considerations of the integrity of the data, usefulness of the signals, classification as a medical device, consideration as personal data, etc. This is highly dependent on the country, so I can't be more specific for Germany, but in Switzerland these considerations are biting back into the app developers as well, in terms of UI for instance: "Exchange Bluetooth beacons anonymously" will probably not fly anymore. I can offer more specifics if you are interested, but some will be dependent on the fact that despite having similar data protection laws, we don't have the same jurisprudence built on top. Some are also still question of political debate, for instance around the epidemiological interventions following a SwissCovid notification of risk: if the Swiss confederation wants to deploy an app that it knows is at risk of false positives, and it wants such a notification to give a right to a free COVID-test, then maybe the cantons shouldn't be paying for these tests.
@SebastianWolf-SAP The core problem as I see it is precisely to think in terms of a layered stack: it is not so. Everyone wishes we could build on top of a nicely defined protocol, but of course the interactions are very open since there can be all kinds of eavesdroppers etc. If you forget one such angle of attack (here direct tampering with beacon signals), you might need to revisit more than you think. If you know of one such angle of attack and don't document it, you might be assuming more liability than you anticipate (especially if you see it as a problem with the components you are using, but decide it is not your problem to get those components fixed).
My main point here is that while the signal strength vs message tampering question is irrelevant to mitigation measures at the software layer (*), it will have consequences further when the app is analyzed. Basing this analysis on partial documentation of the threats might have consequences later in validating the app.
(*): unless we go into a surveillance countermeasures route, or maybe the protocol takes advantage of the three bytes that remain available in the metadata to include some sanity checks

@mh- I have been privately told of techniques that increase the chances of an attacker at flipping values for the AEM. They convinced me, but I will not disclose them at the moment because this is still the topic of ongoing research.

@SebastianWolf-SAP to illustrate the fact that this metadata tampering is not documented well enough, see the responses to this thread:
https://github.com/corona-warn-app/cwa-documentation/issues/306#issuecomment-646373297

In joint work with Joel Reardon (University of Calgary) (see also #), we found a new attack that we consider linked to this one, since an attacker would leverage the dematerialization the AEM tampering brings to bring them scale (an attacker would no longer need hardware, and could just attack through software).
This new attack is now #308.

Please re-open this issue, until this attack is documented.

@pdehaye mentioned the "the core problem" being "to think in terms of a layered stack".
I had similar thoughts when I read about how a question regarding the impact of a fundamental Bluetooth vulnerability was dealt with a while ago, issues #99 #100 #101 and #160.

@pdehaye because you insist:
I tend to think that your "catastrophic failure" is academic only:
a) Flipping bits in (unknown) plain text
You repeatedly mentioned that AEM is not authenticated, and therefore I could - within a re-play attack - flip bits of the "TX Power" byte, which is encoded as a signed 8 bit integer. I would want to decrease the plaintext value, because I don't have a fleet of high-powered transmitters, and if I succeed, the receiver would later think that the attenuation was lower than in reality --> the estimated distance was shorter than in reality.
Now I have these options:
flip bit 10000000 - this would change the sign of the value; since the original value is likely negative, now I have a much larger value - not desired.
flip bit 01000000 - this would either decrease the value by 64, or increase the value by 64, but I don't know what it will do, since I don't know the original value
flip bit 00100000 - this would either decrease the value by 32, or increase the value by 32, but I don't know what it will do, since I don't know the original value
flip bit 00010000 - this would either decrease the value by 16, or increase the value by 16, but I don't know what it will do, since I don't know the original value
flip bit 00001000 - this would either decrease the value by 8, or increase the value by 8, but I don't know what it will do, since I don't know the original value
flip bit 00000100 - this would either decrease the value by 4, or increase the value by 4, but I don't know what it will do, since I don't know the original value
flip bit 00000010 - this would either decrease the value by 2, or increase the value by 2, but I don't know what it will do, since I don't know the original value
flip bit 00000001 - this would either decrease the value by 1, or increase the value by 1, but I don't know what it will do, since I don't know the original value
So which bits should I flip? I'm somewhat afraid that if I decrease the "TX power" value below the received RSSI, the receiver might actually detect my manipulation and simply discard my modified packet.

Of course I will insist!
You presented 8 options. Of course that's not all the options an attacker would have. They actually have 256, since one can combine the 8 primary ones.
It's not just that I don't know the value. I also don't know:

if the attenuation value is a constant. If you see that documented somewhere, please tell me. If it is variable there are clear ways to figure out relative information about the values involved (which is higher than the other).
if Apple/Google discard nonsensical reads (negative attenuations); if you see it documented somewhere that Apple and Google would engage in detection of manipulation, please tell me.
what is the likely distribution of values within their range of -127 to 127. It seems likely they would be unevenly distributed, if it is tied to calibration of devices actually circulating in a certain geographic region. The values could be rounded off as well, for privacy reasons. if you see these values documented somewhere, please tell me.
how the values will be averaged over the duration of an epidemiologically relevant contact. The iOS doc talks about AttentuationValues, but last time I checked it was fairly confusing. I also have no guarantee this is the same for Apple and Google. If you see this documented, please tell me.

You also seem to forget an attacker doesn't exactly need the initial value, they just need the result of a calculation tied to distance and attenuation to end up in the right "box" for the GAEN risk calculation (this is dependent on how exactly the API is leveraged by the app).
In the attack scenarios described, the attacker also doesn't need specific people to be "caught", just a larger number than when the system works nominally, or even just a different set. This value being tampered can be thought of R such that all the individuals between R and R+2m are "painted". When the system works nominally, we have R=0. An attacker would just observe that an annulus of radii R and R+2m is very likely to have more people in it than the disc of radius 2m. Of course too large an R would not do, due to the actual physical attenuation of the signal. But still, more options than you might think.
So, all in all:

I am confident there are many ways to drastically improve the odds one might expect the attacker to have at first - it will never be deterministic but certainly better than a 1/256 chance;
I am aware describing a precise strategy requires information I don't have at the moment;
I am aware the CoronaWarn project committed to full open source and documentation of how the system works, so I am looking forward to eventually dig into the code and get answers to my questions, so I can in turn more precisely answer yours.

So what could and attacker achieve in the worst case at the application level and how much would they have to spend?

You are probably also aware that iOS and the Google Play Services is closed source and the CoronaWarn project will not be able to answer your questions. Why don't you direct them to Apple / Google directly? (And please let us know about the response, I'm very interested in this.)

I have directed some questions to Google and Apple already, with no response. I am glad to hear you are interested in this, but can't guarantee I would get back to you on this one. Therefore I would advise you to ask Google and Apple directly as well if you are interested. Personally I care about the response coming from CoronaWarn because I believe those who deploy such apps should be clear also on what parts are obscure to them, and certainly not pretend everything is open source when there are clear software issues that are hidden away.
for figuring out relative values, you actually have the triple Bluetooth channels to take into account as well as temporal evolution and background Bluetooth traffic (i.e. of third parties), which the target phone is reacting to. Lots of side-channels!
yes, I meant the TX power, not the attenuation value. It might vary, and indeed it would make sense that it does from a utility perspective. It would be a drain on battery too. Regardless, my question was whether it does vary.
? the attacker doesn't have to change all the values the same way for all devices (but even if the attacker does, a quick calculation shows that the surface of an annulus and an empty disc is likely to be higher than the sum of areas of two disks of radius 2m)
am I understanding correctly that the table you are referring to is already published here? This is actually the result of the work of GSMA and collaboration with other European teams.

@sventuerpe leveraging the AEM tampering, I came up with Joel Reardon (UCalgary) with a SDK-based attack. See #308. I don't know if this answers your question. The spend to an attacker in the right position would be very small. At application level, the consequences might be:

faster collection of identifiers than anticipated, more notifications etc;
UI to contextualize this risk to users, before enabling the system and when a notification arrives

Certainly for the project building this application, it means: better documentation.

am I understanding correctly that the table you are referring to is already published here? This is actually the result of the work of GSMA and collaboration with other European teams.

I don't know if Google / Apple are using this table to determine the encrypted TX Value.
tx_RSS_correction_factor seems like a candidate that is related, but since I do not find my device in the table, and it sends "0xf2" == -14dBm, but I also don't find -14 in the table e.g. as the default value, I would say:
No, that is not a table an attacker could use to devise useful attacks on flipping TX Power bits.

Then I think the data referred in this tweet by a member of the Swiss team will be it.

@pdehaye I am afraid I do not follow. #308 points back here without adding much detail.

@sventuerpe Apologies. In #308 there is a link to a paper explaining how the AEM tampering can be leveraged to conduct population-scale re-identification and/or false positive attacks. We called it the SDK attack, and I started a new issue given that this one had been flagged as out of scope and closed.

@pdehaye

@sventuerpe how the AEM tampering can be leveraged to conduct population-scale re-identification and/or false positive attacks.

Sorry, I must have missed that. How do you envision using AEM tampering to conduct population-scale re-identification attacks?

@mh- You are correct, I was imprecise. I should have said to @sventuerpe :

The GAEN framework suffers from well-known and documented re-identification and false positive attacks. However these attacks are wrongly thought to either require physical presence of the attacker next to the victim or to be expensive because they require hardware. In #308 we show those assumptions are incorrect. We show that by leveraging either SDKs or particluarly well-permissionned apps, an attacker could conduct population-level re-identification and/or false positive attacks. The case of a false positive attack would require to implement a variation on classic replay attacks, called AEM tampering. We additionally show some evidence indicating such a SDK-based attack would be very easy to some actors. Neither the AEM tampering nor the scaling-through-SDKs are documented in official German documentation.

@pdehaye I think

The case of a false positive attack would require to implement a variation on classic replay attacks, called AEM tampering.

is also imprecise, it is not required.
You can implement a relay attack if you can build your bot net, using the maximum available TX power of each device while advertising the relayed beacons, without tampering with AEM; you just hope to further increase the effectiveness by trying to modify the AEM.

You are right, we didn't formally show it was required. I highly suspect it would make it easier and is in fact required, but can't demonstrate that without:

more transparency in the Bluetooth layer;
more data on calibration (beyond averages of the kind published here)

Also, a SDK might not have/offer the option of modifying the maximum TX power.

For the record, because this might be relevant to #322: while the tampering with AEM values has to be done blindly, one can use all the binary triples (say) abc to XOR the actual AEM with abc11111, and thereby generate a predictable set of values: the initial value x plus all its shifts by 32, modulo 256 so that it remains in [-127,127].
Example:
If the real metadata value is 10, which I don't know because it is encrypted, I can nevertheless generate the encrypted values of 10 and 42, 74, 106, -22, -54, -86, -118.

Then I think the data referred in this tweet by a member of the Swiss team will be it.

Google has released the relevant data now: https://developers.google.com/android/exposure-notifications/files/en-calibration-2020-06-13.csv


feature: ignore filetype register

Ignores the registry of buffered windows of a specific type.

Hi, thanks for the feature. Unfortunately, I think your implementation would prevent all the windows to be registered if the first window is one of the ignored filetypes, meaning the proportional resizing cannot be done if one of the buffers is the ignored filetype.
I do plan to implement this feature in the future, but I am quite busy these days.


Added Learning guide for Cluster-API and MetalCubed

Please fix the merge requests in teh commit history

Ok . I have couple of things to fix. I will delete this pull  request and create a new one.


feat: support shouldPersistHeaders option in GraphiQL plugin

This PR added support for the shouldPersistHeaders option to the graphiql plugin.

Hi! Thank you for your contribution! Can you add a changeset ?
Just run pnpm run changeset and follow instructions :-)

@EmrysMyrddin Thank you for your comments! I added a changeset!


Roll engine f3482700474a..68ae872e22d3 (21 commits)

https://github.com/flutter/engine/compare/f3482700474a...68ae872e22d3
git log f3482700474a791dabe9c4783568ed0fe512b04d..68ae872e22d3c827d6bfda28ada2934e30a43e47 --no-merges --oneline
68ae872e2 Made the persistent cache's directory a const pointer. (flutter/engine#9815)
8720043dc Roll src/third_party/skia a2e7d5e2b63c..83cfe4fa24d9 (3 commits) (flutter/engine#9916)
b28ccd8e1 Roll fuchsia/sdk/core/mac-amd64 from 9XAYIkrdh9JQjy22gyni7VbK2yYurszww1k9zRQ_jU8C to GcUOj20BDDGW4Sz4cnsI4_Lf9qte_6OCgQBmDQLnGNcC (flutter/engine#9915)
89a9a95af Roll fuchsia/sdk/core/mac-amd64 from lXCuLh2YGWM641A5Io3ASt3Uy70e_YGRKFLf46new08C to 9XAYIkrdh9JQjy22gyni7VbK2yYurszww1k9zRQ_jU8C (flutter/engine#9911)
c8f35b948 Roll src/third_party/skia ea6da6909624..a2e7d5e2b63c (3 commits) (flutter/engine#9910)
8704d61ec Roll src/third_party/dart 6bf1f8e280..63120303a7 (4 commits)
866d0570f Roll src/third_party/dart 0506882b37..6bf1f8e280 (9 commits)
72893549a Roll src/third_party/dart 8cb7e4c237..0506882b37 (3 commits)
d84b9385a Roll src/third_party/dart 41d3971e83..8cb7e4c237 (2 commits)
52b226cd4 Roll src/third_party/dart 2b3336b51e..41d3971e83 (3 commits)
cf4129bbb Roll fuchsia/sdk/core/mac-amd64 from 0NcHg3_AYcxrkseoO6xmXrQ-GZ82gy8CE5NU-SDJq_QC to lXCuLh2YGWM641A5Io3ASt3Uy70e_YGRKFLf46new08C (flutter/engine#9908)
c2133b41a Roll src/third_party/skia d7639aff1001..ea6da6909624 (7 commits) (flutter/engine#9907)
ca91c66d7 Roll fuchsia/sdk/core/mac-amd64 from JDPk4JFZX16IXpzzjQH5KFf0vRALbOtJYiMHCqFLFOQC to 0NcHg3_AYcxrkseoO6xmXrQ-GZ82gy8CE5NU-SDJq_QC (flutter/engine#9904)
fd2cb8150 Respect EXIF information while decompressing images. (flutter/engine#9905)
dd06cda54 Fix justify for RTL paragraphs. (flutter/engine#9859)
be3e2ed4c Fix fuchsia license detection (flutter/engine#9857)
b7b791b3f In a single frame codec, release the compressed image buffer after giving it to the decoder (flutter/engine#9825)
1af19ae67 Roll fuchsia/sdk/core/mac-amd64 from PHtpiJGexJFgd7sgPTUbFphKES09fzotmtrO2kTHI08C to JDPk4JFZX16IXpzzjQH5KFf0vRALbOtJYiMHCqFLFOQC (flutter/engine#9892)
5d9f7b18e Log dlopen errors only in debug mode (flutter/engine#9890)
8f060b995 Add clang version to Info.plist (flutter/engine#9873)
0fcf3b3ef Roll src/third_party/skia e574f1e409aa..d7639aff1001 (16 commits) (flutter/engine#9889)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (aaclarke@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4959917801209856 , https://cirrus-ci.com/task/6648767661473792 , https://cirrus-ci.com/task/6367292684763136 , https://cirrus-ci.com/task/5522867754631168 , https://cirrus-ci.com/task/6085817708052480

Commit queue failed; closing this roll.

Commit queue failed; closing this roll.


Remove v.format.enable config  and honor the builtin vscode format config

Just tested this PR, and it's finally fixes an issue I encountered:

If I set v.format.enable option to true, the extension tries to format current file on every save, even if VS Code editor.formatOnSave option is set to false.

If I set v.format.enable option to false, the extension does not format on save, but it doesn't register V formatter (so, there're no an item in the context menu of current document).

After this PR is applied, users can disable format on save via built-in method in settings.json:
{
    "[v]": {
        "editor.formatOnSave": true,
    }
}

but they will be able to use formatter via a context menu or a hotkey.
As I understood, VS Code uses internal check to detect if format on save is allowed, as is said here:

Recently, we added the "Format on Save" feature. An extension properly implementing the formatting API supports this feature without any new code.
so, a custom check is at least useless.


Store Infra Client client.pem contents in the Windows Certificate Store

As an operator, I want to store the client.pem contents in a secure location
so that it cannot be discovered by others.
As a security team I want the ensure that no certificates are stored on disk,
so that systems are compliant with audits
Acceptance Criteria

A new config option 'migrate_key_to_keystore' to migrate keys to system certificate stores if they are found on disk
The option would default to false today and be set to true some time in the future
The option could be set via CLI flag as well in chef-client
Knife bootstrap with a --store-key-in-keystore set the migrate_key_to_keystore flag in the client.rb so that the first run moves the key

Other Notes
This implements the Windows side of the Aha Idea https://chef.aha.io/ideas/ideas/CHEF-I-30

Waiting on a code review

Here are the work items I see that we need to perform

Update the chef-config gem to reflect the new option to migrate from disk
Update the registration code to intercept calls to Registration (first time run) and substitute a call into the cert store to retrieve the key if it's there.
Add an additional option to the registration code to import the key into the certstore if the flag is set. This might need a review, I don't know that trapping the call to Registration and using that to install a cert is the correct spot for that.
Update the HTTP/Authenticator code to retrieve the cert from the store under normal circumstances. This work has been done already, but need to verify impact of the new code being added via step 3 and ensure consistency of calling conventions and naming objects.


Add Remark Command

Codecov Report

Merging #6 (a9c3052) into master (78f5c23) will decrease coverage by 0.58%.
The diff coverage is 63.15%.

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
- Coverage     72.15%   71.57%   -0.59%
- Complexity      399      408       +9
============================================
  Files            70       73       +3
  Lines          1232     1284      +52
  Branches        125      130       +5
============================================
+ Hits            889      919      +30
- Misses          311      332      +21
- Partials         32       33       +1

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...eedu/address/logic/parser/RemarkCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Remark.java
62.50% <62.50%> (ø)

...va/seedu/address/logic/commands/RemarkCommand.java
70.83% <70.83%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
97.05% <100.00%> (+0.04%)
:arrow_up:

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
85.71% <100.00%> (+2.38%)
:arrow_up:

...c/main/java/seedu/address/model/person/Person.java
97.82% <100.00%> (+0.20%)
:arrow_up:

.../java/seedu/address/model/util/SampleDataUtil.java
25.00% <100.00%> (+5.00%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f5c23...a9c3052. Read the comment docs.


Finding the available moves

[x] static List FindKingLine => Find king with queen moves => returns whole diagonal/row/column, or whole board if not found (opposing* acts as partial* as well)
[x] static List QueenEndpoints => Queen moves that don't go over friendlies
[x] static List HorseMoves => Horse moves that don't capture friendlies ()
[x] static List GetAttackers => Find enemy endpoints with queen moves that can attack current position
[x] static Point GetAttacker => Finds the first enemy with queen moves that can attack current position
[x] static List GetAttackersCount => Shorthand for MatrixCount(GetAttackers)
[x] static List HasAttacker => Shorthand for MatrixAny(GetAttackers)
[ ] static List AvailablePieces => Returns matrix of available pieces
[x] static Point FindKing => returns king position
[ ] Shorthand for the above: Function(chessPiece)
[x] abstract List GetMovesAll() => Moves of piece that are defined
[x] virtual List GetMovesAvailable() => Moves of piece that don't go over friendlies (made abstract instead of virtual due to algorithmic problems)
[x] virtual List GetMovesPinned()
[x] Run MatrixAnd for each piece in GetAttackers on Attacker.GetMovesAll and FindKingLine.
[x] If there is an instance where the result is equal to original FindKingLine, run MatrixAnd(Attacker.GetMovesAvailable, Piece.GetMovesAvailable)
[ ] virtual List GetMovesFinal() => if (HasAttacker(FindKing()) == false) then same as GetMovesPinned else if (MatrixCount(GetAttackers(FindKing())) > 1) then no moves else GetAttackers(FindKing())

Shorthand: will not implement


MongoError: connection 0 to localhost:27017 timed out —> Topology was destroyed

Many errors of this kind appear after node makedash.js runs for a while, and the script fails to generate many pages/assets.
err { MongoError: Topology was destroyed
    at nextFunction (/home/gordonl/Measure/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:547:27)
    at Cursor.next [as _next] (/home/gordonl/Measure/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:701:3)
    at fetchDocs (/home/gordonl/Measure/node_modules/mongodb/lib/cursor.js:857:10)
    at toArray (/home/gordonl/Measure/node_modules/mongodb/lib/cursor.js:884:3)
    at /home/gordonl/Measure/node_modules/mongodb/lib/cursor.js:841:5
    at Cursor.toArray (/home/gordonl/Measure/node_modules/mongodb/lib/cursor.js:840:10)
    at Object.module.exports.dateDiffsByTimePeriods (/home/gordonl/Measure/widgets/widgetUtils.js:84:28)
    at Object.module.exports [as module] (/home/gordonl/Measure/widgets/repo/34_prTimeStatsChart.js:5:17)
    at async.mapSeries.results.filter.h (/home/gordonl/Measure/lib/dashboards.js:96:28)
    at /home/gordonl/Measure/node_modules/async/dist/async.js:1121:9 name: 'MongoError', message: 'Topology was destroyed' }
  One of the dashboard widgets ("prTimeStatsChart", running against
  the "sanjayy" contributor had a problem, so I've skipped over it.
  This is really an internal error, and should be reported.
  (The error is described like this, which will help in the report:
  Topology was destroyed,
  node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:547)

@gordongli Out of curiosity, how much memory does the instance you're running mongo on have?

GHCrawler with Docker is running on a Linux box with 24GB memory. docker ps -s shows that the docker_mongo_1's size is 0B (virtual 366MB). Connecting to mongo from remote, show dbs shows ghcrawler  0.845GB.
CONTAINER ID        IMAGE                      COMMAND                  CREATED             STATUS              PORTS                                                                                NAMES                SIZE
0a9356050aa6        docker_dashboard           "npm start"              3 days ago          Up 3 days           <IP_ADDRESS>:4000->4000/tcp, 5858/tcp                                                             docker_dashboard_1   0B (virtual 840MB)
078fe325891b        docker_crawler             "npm start"              3 days ago          Up 3 days           <IP_ADDRESS>:3000->3000/tcp, 5858/tcp                                                             docker_crawler_1     0B (virtual 812MB)
35cfed5c7969        metabase/metabase:latest   "/app/run_metabase.sh"   3 days ago          Up 3 days           <IP_ADDRESS>:5000->3000/tcp                                                                       docker_metabase_1    554kB (virtual 245MB)
5ade5270fc42        rabbitmq:management        "docker-entrypoint.s…"   3 days ago          Up 3 days           4369/tcp, 5671/tcp, <IP_ADDRESS>:5672->5672/tcp, 15671/tcp, 25672/tcp, <IP_ADDRESS>:15672->15672/tcp   docker_rabbitmq_1    144B (virtual 151MB)
5279e526c7d8        mongo:latest               "docker-entrypoint.s…"   3 days ago          Up 3 days           <IP_ADDRESS>:27017->27017/tcp, <IP_ADDRESS>:28017->28017/tcp                                           docker_mongo_1       0B (virtual 366MB)
21b4d6dfe9c0        redis:latest               "docker-entrypoint.s…"   3 days ago          Up 3 days           <IP_ADDRESS>:6379->6379/tcp                                                                       docker_redis_1       0B (virtual 107MB)

While we were seeing this with very small instances during early build, I've not been able to reproduce it recently. We're looking into it further now.

@gordongli I've made some changes to the error reporting. "Topology was destroyed" is a cascade error; it happens when something else goes wrong, and then our control flow has a problem and causes all the widgets to throw an error. If you're still experiencing the problem, then before all the "topology" errors there should be another error reported which is the thing that's the actual problem; if you could follow up with that error, we can fix it.

I tried it again, and it was mongo timing out:
connection 0 to localhost:27017 timed out
MongoError: connection 0 to localhost:27017 timed out
    at Function.MongoError.create (/home/gordonl/Measure/node_modules/mongodb/node_modules/mongodb-core/lib/error.js:29:11)
    at Socket.<anonymous> (/home/gordonl/Measure/node_modules/mongodb/node_modules/mongodb-core/lib/connection/connection.js:200:20)
    at Socket.g (events.js:291:16)
    at emitNone (events.js:86:13)
    at Socket.emit (events.js:185:7)
    at Socket._onTimeout (net.js:339:8)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)

I see you've made a fix in the most recent commit to execute the calls in batches, which seems to prevent that. I've run into another issue, however, which is the node running out of heap memory (I believe this has occurred before as well), and it still relates to mongo. I've made a new issue here: https://github.com/MeasureOSS/Measure/issues/76
<--- Last few GCs --->

 5382881 ms: Mark-sweep 1303.3 (1404.6) -> 1303.2 (1406.6) MB, 1540.7 / 0.0 ms [allocation failure] [GC in old space requested].
 5384277 ms: Mark-sweep 1303.2 (1406.6) -> 1303.2 (1406.6) MB, 1395.6 / 0.0 ms [allocation failure] [GC in old space requested].
 5385622 ms: Mark-sweep 1303.2 (1406.6) -> 1305.1 (1404.6) MB, 1345.0 / 0.0 ms [last resort gc].
 5386890 ms: Mark-sweep 1305.1 (1404.6) -> 1307.1 (1404.6) MB, 1267.4 / 0.0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x3ff7c8cfb51 <JS Object>
    2: _next [/home/gordonl/Measure/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:~700] [pc=0x51e82082034] (this=0xe9c5a8d3859 <a Cursor with map 0x3a49d2873cd1>,callback=0x3b7e7ca24ec9 <JS Function (SharedFunctionInfo 0x265f061c5641)>)
    3: fetchDocs(aka fetchDocs) [/home/gordonl/Measure/node_modules/mongodb/lib/cursor.js:857] [pc=0x51e822cbcc3] (this=0x3ff7c804381 <undefined>)...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x101167c [node]
 3: v8::Utils::ReportApiFailure(char const*, char const*) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::TypeFeedbackVector::New(v8::internal::Isolate*, v8::internal::Handle<v8::internal::TypeFeedbackMetadata>) [node]
 7: 0xafa2e0 [node]
 8: 0xafa493 [node]
 9: 0xafac08 [node]
10: 0xafb86e [node]
11: 0xb03dbb [node]
12: v8::internal::Compiler::Compile(v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Compiler::ClearExceptionFlag) [node]
13: v8::internal::Runtime_CompileLazy(int, v8::internal::Object**, v8::internal::Isolate*) [node]
14: 0x51e80e092a7
Aborted

Hi,
I'm also getting the same connection timeout error in my server when i deployed my application in my local machine everything is worming as expected:
{ result:    { result:       { MongoNetworkError: connection 4 to localhost:27017 timed out           at Socket.<anonymous> (/var/www/node-application/hotel-caching/node_modules/mongodb-core/lib/connection/connection.js:259:7)           at Object.onceWrapper (events.js:277:13)           at Socket.emit (events.js:189:13)           at Socket._onTimeout (net.js:443:8)           at ontimeout (timers.js:436:11)           at tryOnTimeout (timers.js:300:5)           at listOnTimeout (timers.js:263:5)           at Timer.processTimers (timers.js:223:10)         name: 'MongoNetworkError',         errorLabels: [Array],         [Symbol(mongoErrorContextSymbol)]: {} } } }
Please guide me how to fix this issue. thanks in advance.

@jogendra-yadav just to confirm: are you using Measure when you get this error?  And it will increase more.

@jogendra-yadav I'm sorry, but this is the repository for the Measure software, not a general MongoDB help account; we won't be able to help you here. The software you're using may have its own help forum -- the documentation for it may tell you that -- or you may have more luck posting this question on Stack Overflow (https://stackoverflow.com) which is designed as a help forum for more general programming questions. Good luck finding an answer!


Unexpected Keyword "retry_on_empty" while init AsyncModbusTcpClient

Describe the bug
After installing and removing a other HACS integration for reading solaredge inverters a error appears while starting your solaredge-modbus-multi integration on HA startup:

I think the problem is, that with this other integration an newer Version of pymodbus-lib came in my system :-(((
So I have searched with google for a possible cause an find a documentation for the latest pymodbus API. There is described that the parameter retry_on_empty was removed (I hope thats the correct finding ;-))

This are my HA-Versions:

But your really super extension worked with this HA-Version until I installed an other HACS-solaredge-integration :-(((
What is your opinion on the subject? Have you a tipp for my how I can determine the installed version of pymodus-lib in my system?
Thanks a lot!
Expected behavior
No Error while startup process of integration!
Screenshots
No response
Diagnostic File
No File available
Debug logs
Logger: custom_components.solaredge_modbus_multi
Quelle: helpers/update_coordinator.py:312
Integration: SolarEdge Modbus Multi (Dokumentation, Probleme)
Erstmals aufgetreten: 08:04:25 (17 Vorkommnisse)
Zuletzt protokolliert: 08:21:53

Unexpected error fetching SolarEdge Coordinator data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 312, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/solaredge_modbus_multi/__init__.py", line 190, in _async_update_data
    return await self._refresh_modbus_data_with_retry(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/solaredge_modbus_multi/__init__.py", line 234, in _refresh_modbus_data_with_retry
    raise ex
  File "/config/custom_components/solaredge_modbus_multi/__init__.py", line 231, in _refresh_modbus_data_with_retry
    return await self._hub.async_refresh_modbus_data()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/solaredge_modbus_multi/hub.py", line 364, in async_refresh_modbus_data
    await self.connect()
  File "/config/custom_components/solaredge_modbus_multi/hub.py", line 470, in connect
    self._client = AsyncModbusTcpClient(
                   ^^^^^^^^^^^^^^^^^^^^^
TypeError: AsyncModbusTcpClient.__init__() got an unexpected keyword argument 'retry_on_empty'

Home Assistant Version
2024.7.4
solaredge-modbus-multi Version
2.4.18
Installation Type
HAOS
Read the Instructions

[X] My configuration follows https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Configuration
[X] I have read the Known Issues https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Known-Issues
[X] This issue is not about a template error (do not report template errors, read https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Template-Design-Notes)

Additional Context
No response

I'm having the same issue with pymodbus 3.7.0 and HA 2024.7.4. The integration worked for a while (although changing power settings I have issues understanding how it works, sometimes I could get it to work and sometimes it just did not respond).
Anyway, right now the integration is not starting / loading at all with the same error as listed here.

By-the-way: my dirty-hack to resolve the error in my system landscape is like this:
Commet out the line 475 in hub.py:

After restart HA integration works fine again - but this can only be a temporarily solution and I don't know what other effects the missing option has. But at first glance, everything seems to be running normally for me!

Yes, installing something external that forces the pymodbus version to 3.7.0 will cause it to break since that parameter was removed. Home Assistant core uses pymodbus==3.6.9. I will remove it from the modbus client.


Feature/maths vectors

This PR will add Vector2, Vector3, Vector4
There may be changes between this and #190 as discussed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Scalar is mostly ready for review.
There will be some additions (like Acos right now) but overall it's consistent now.
cc @Perksey

Awesome, Vec2 has my sign-off then :D

Happy to drop the previous commit if considered out of scope

Happy I could help :) I'm fine as is


Add useAvroLogicalTypes source format option for Avro

See REST schema here https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#jobconfigurationload
Minor feature addition, LMK if I should add anything else but seems pretty straightforward.

Oops, meant to do this in main apache github. will leave this up to you and make the same PR over there

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Displaying image along with tile count

For manual merge:
Has to setup DisplayInspectorText.Sprites, essentially a dictionary of tiletype to sprite.
Also set DisplayInspectorText.TileCountPrefab to Prefabs/UI/Inspector/TileCount

I'm holding off on merging this cause I think we're going to make changes the design of the inspector for terrain tiles


Zero-width spaces in updates/obsoletes

Describe the issue
RFC 8996 contains a LOT of RFC numbers in its updates attribute.  Along with some of those, it includes a Unicode zero-width space character (U+200b).
While it is not clear that whitespace is allowed in this attribute, xml2rfc has been tolerant of whitespace thus far.  The wrinkle here is that python's strip() does not, by default, recognize "\u200b" as whitespace.  So what has happened is that the character has made its way into the links in HTML that xml2rfc generates.  The resulting links are bad.  (The HTML is also bad, but that is of less immediate consequence.)
Options here appear to be:

Be more tolerant of garbage.  While there is no reason to use U+200b in this attribute, that happened.  xml2rfc can strip it out.  The problem with this is that a point fix here only creates inconsistency in the interface.  Why is U+200b allowed here but not elsewhere?
Don't change xml2rfc, but instead fix the problem at the source.  This is probably a one-off.  Though it messes with the RFC immutability thing, that's not sacrosanct.

My opinion is that the second course is better, but that requires broader discussion, probably in RSWG.  Either way, I wanted to open this to track the issue.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Personal opinion:
I think it is clear enough in RFC 7991 that the updates attribute can only contain number, commas and draft names, not whitespace or anything else.
My preferred way forward would be to have ave xml2rfc strip everything that is not an RFC number, comma or I-D name.  This would leave the formatting of that in the rendered RFCs to xml2rfc, which is more appropriate given that a) this is header/metadata not content and so the formatting is for the series editors to manager not the authors; and b) the tool can do a better job of formatting across all the different renderings.
It is unfortunate that we now have an RFC with "\u200b" in that attribute as it is likely to break or at least confuse any code that parses it.  If we are going to republish the XML then "unexpected stuff in the XML that is contrary to our documentation and likely to break parsers" is probably high up the list of reasons to do so.


docs(api): update broken and redirecting support links

Overview

A couple links to support articles on the Welcome page were broken, and a couple more were redirecting. Updated all to directly to go the right URL.
Changelog

Updated 5 link URLs.

Review requests

Click all the links under the Support header.
Risk assessment

None, docs only.

@SyntaxColoring strange, they seem to be working for me in the sandbox

@SyntaxColoring @ecormany
On my end, all links work without a salesforce login.

Yep, sorry for the false alarm.
I think what happened is if you go to sandbox.docs.opentrons.com/docs-fix-support-links (without /v2 at the end), that redirects you to docs.opentrons.com/v2 (without the sandbox at the beginning). So I was looking at the wrong version.

Oh yeah, I made that "fix" to the infinite redirect loop #9918 which is OK in production but totally introduced a pitfall in the sandbox. (April! I was so naive then! 😅) Maybe we can improve that on a rainy day…


Figure out Invenio's access grants

In the schema there's a section parent.access.grants that seems to provide individuals with varied levels of permissions. How can this be used, and how do the values here function in Invenio?


[FSPE-7708] Prepare release for Chi 4.0.0

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-38/1/. :white_check_mark:

You can check this PRs instance in https://cb7cd236ce0fc9bf9281ab2889c8a3b2fbf2aece-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-38/2/. :white_check_mark:

You can check this PRs instance in https://1b6df015d1150ee7dcb14e001fadd58e2e1b19fb-chi-pr.enterprise.ctl.io


Request: Olympics?

So I see in the supported sites information that youtube-dl can handle downloading from NBC.  Any chance this can work with http://stream.nbcolympics.com?
I tried just a straight download, but no luck:
C:\Users\Heubner\Downloads>youtube-dl http://stream.nbcolympics.com/nbcsn-coverage/winter/15452?nid=15451_208 -v
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['http://stream.nbcolympics.com/nbcsn-coverage/winter/15452?nid=15451_208', '-v']
[debug] Encodings: locale 'cp1252', fs 'mbcs', out 'cp437', pref: 'cp1252'
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.5 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[generic] 15452?nid=15451_208: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 15452?nid=15451_208: Downloading webpage
[generic] 15452?nid=15451_208: Extracting information
ERROR: Unsupported URL: http://stream.nbcolympics.com/nbcsn-coverage/winter/15452?nid=15451_208; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "youtube_dl\YoutubeDL.pyo", line 493, in extract_info
File "youtube_dl\extractor\common.pyo", line 158, in extract
File "youtube_dl\extractor\generic.pyo", line 380, in _real_extract
ExtractorError: Unsupported URL: http://stream.nbcolympics.com/nbcsn-coverage/winter/15452?nid=15451_208; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output
. Make sure you are using the latest version; type  youtube-dl -U  to update.

This video is gone. Anyway there's a new request at #10295. Please move there for further discussions.


feat(editor): improve documentation editor using Remirror

Highlights

Improved UX for documentation editing with

Modals to Add Links / Images
Inline menus for quicker access to style text
Inline link previews

@mentions: users can now tag entities by typing @. More details about the entity shown upon hovering over the mention
Resizable images: users can now resize images

By default, uploading images will be saved as markdown (i.e. ![alt text](my-image.png)). Upon resizing, the image will be stored as HTML Markup (i.e. <img height="46" width="54" src="my-image.png" alt="alt text" />)

Table editing

Controls to add/remove table rows/columns easily
Tables are converted to markdown where possible. Otherwise, it will be stored as in HTML Markup. (Markdown tables cannot contain lists, headings, code blocks, or another table)

Summary of Changes

Install additional packages - @remirror/* for editor, prosemirror-autocomplete for powering inline suggestions, turndown-plugin-gfm to add gfm support for tables
Add custom buttons/controls to fit with AntD stylings
Add new Remirror DataHubMentionsExtension to contain rendering logic and to import prosemirror-autocomplete plugin
Remove sanitising of documentations located outside the editor (already handled by Remirror)
Update Jest configuration to explicitly transpile lib0 and y-protocols, keeping '^.+\\.module\\.(css|sass|scss)$' from default configurations

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

everything is passing in CI now woo! except for these failing Monitoring tests but those are failing for all open PRs

Awesome, thanks for the help @chriscollins3456 !


reinstate run-s to fix wasm issue. Fixes #1350

Do we want to go back to && so that the errors aren't swallowed?


feat(portal): New version of the  WS control protocol

TODOs:

[x] Switch to sending messages instead of replies
[ ] Do not hide pre-filtered resources and render them with an error instead (in case we will want to expose that on a client later)
[x] Figure out how to generate PSK so that it stays across WS connections

Nice work! I don't have the headspace to get into the nitty-gritty details in this PR, but just so I'm aware, what's the user-facing change (if any) here?

Primarily fewer round-trips for making new connetions, i.e. decreased latency / TTFB. It will also enable packet buffering because the new protocol is designed to be idempotent in regards to creating / reusing connections which greatly reduces the complexity for that in the client.

Will the new API be backwards-compatible or should I plan to make any announcements?

No, it will only work for clients & gateways >= 1.4. Gateways will be backwards-compatible with old clients. We need to hold back the client releases until customers have upgraded their gateways to 1.4+.

@thomaseizinger I have updated the structs and switched to sending messages. WDYT about the proposed naming? flow_created and flow_creation_failed? I feel they are more human-readable in the codebase.
I must say using messages instead of replies feels weird, especially because in other places we still do have replies (like create_log_sink). And tests for it feel a bit unconventional for Elixir codebase too.

@thomaseizinger I have updated the structs and switched to sending messages. WDYT about the proposed naming? flow_created and flow_creation_failed? I feel they are more human-readable in the codebase.

You probably encounter them more often than I do, so feel free to use those names. My suggestions were based on a convention that ties the messages together based on the initial "method" without having to resort to English grammer, i.e. past tense of create. Ultimately don't feel strongly about it so go with whatever makes most sense to you!

I must say using messages instead of replies feels weird, especially because in other places we still do have replies (like create_log_sink) and it's not an idiomatic use of Phoenix channels. Tests for it feel a bit unconventional too.

You can delete the create_log_sink stuff, we no longer use that :)
Does it feel weird to the point where it actively bothers you? It works much better for us. The p2p control protocol we are building follows the same idea: We only have named events and those are by nature unidirectional, no responses.
connlib is very heavily concurrent, each packet is basically an event. Being able to process anything regarding to the control protocol also as independent events without having to keep around state that matches previously sent ones based on some ID is simpler to reason about :)
Maybe we should change the name of create_flow to be less RPC-ish and more event-based too? Maybe access_intent? The "reply" to that could be a flow_created event?

@thomaseizinger I'm just complaining about non-idiomatic integration path 🤣. Let's keep this PR as is, with names and messages instead of replies.

@thomaseizinger I'm just complaining about non-idiomatic integration path 🤣. Let's keep this PR as is, with names and messages instead of replies.

@AndrewDryga Haha okay :D
This PR is fully backwards-compatible right? So for the old messages, we do still get replies?

This PR is fully backwards-compatible right? So for the old messages, we do still get replies?

Yes, old ones will work as they do now

Can we merge this? I'd like to make progress on the Rust side here.


Disappearing bars if responsive: true

Hello.
Found an issue with the way Chart.js calculates the height if resposive: is true.
In the full-screen preview before (2nd link), try zooming/resizing the browser view.
JSBin:
https://output.jsbin.com/huviquwuse/1
upd: to reproduce the POC we need to save the code locally in a .html file to let the browser view it as if it was a website

I didn't notice anything even after zooming up to 500% in Chrome

JSBin won't view it as a raw html document anymore, not sure what their policy is, but they say it's expired. I won't comment on that.
But I've updated the instructions in the message above to show how to reproduce the issue.

Disappearing easily work with Chrome under Windows.
Open https://output.jsbin.com/huviquwuse/1 in a tab. Create new tab and such save any picture in this Tab. Go back to the tab with Site. Close the Chrome Download bar at the Bottom. Bars disappear.
Don't work in Firefox (Windows), also not working in Chrome under Mac OSX.

Thank you for your input, @Endzeitlive
However I'm able to reproduce the bug in both FF and Chrome under macOS.

I tried the exact reproduce from @Endzeitlive and this did not reproduce

you did this in chrome under windows? I'll record a Video. I'll edit my post in few minutes.

Following your video I was able to reproduce it. I don't know if its a Chart.js issue. The chart render code runs, but nothing shows up on the canvas. Its almost like the browser couldn't render anything anymore

Could be related to https://bugs.chromium.org/p/chromium/issues/detail?id=591374

Thank you for the video, @Endzeitlive
However I've originally intended to reproduce a different bug.
Try going here http://fiddle.jshell.net/03bos983/show/light/ an resizing the browser's window horizontally from the smallest to the largest. Notice the last two bars disappear as you enlarge the window and appear again as you shrink it.
src: https://jsfiddle.net/03bos983/

@sturmer-eha the problem is that the y axis minimum value is changing. Adding beginAtZero: true fixes the problem.
See http://fiddle.jshell.net/03bos983/1/

Closing as resolved per my last comment


Getting a lua ssl certificate verify error

This is a new issue for me. I have lua-resty-auto-ssl running on 4 web servers and was attempting to add two more today. Lua-resty-auto-ssl works flawlessly on all my other servers. It uses a shared redis backend to store the certificates. I checked to make sure that all of the versions of openresty and lua-resty-auto-ssl were the same. They are
lua-resty-auto-ssl
   0.12.0-1 (installed) - /usr/local/lib/luarocks/rocks

lua-resty-http
   0.12-0 (installed) - /usr/local/lib/luarocks/rocks

nginx version: openresty/<IP_ADDRESS>

On both of the web servers that I recently added - I get this error whenever a client attempts to connect to the server:
[error] 3823#3823: *28163 lua ssl certificate verify error: (20: unable to get local issuer certificate), context: ssl_certificate_by_lua*, client: <IP_ADDRESS>, server: <IP_ADDRESS>:443

The default certificate file should be the same. I checked for permission issues as well. Does anyone have any thoughts as to what might be happening here?

This might still be an issue but I am going to close out because I was able to resolve it.
Basically my allow_domain function made a request to an endpoint that either returns 200 (allowed), or 404 (not allowed). When that uri is an https url, then it throws the error above. When it is an http url it works fine. So nothing to do with serving inbound https connections.


Add logout command to CLI

Description:
We can log in to the Yorkie server, to use admin APIs which can manage documents and projects with CLI.
$ yorkie login -u username -p password
$ yorkie project ls

 NAME     PUBLIC KEY            SECRET KEY            AUTH WEBHOOK URL  AUTH WEBHOOK METHODS  CREATED AT
 default  cg044avhiqss73d20n2g  cg044avhiqss73d20n30                    []                    6 days

But we don't have logout command to log out from the Yorkie server yet.
Refer to:

docker login: https://docs.docker.com/engine/reference/commandline/login/
docker logout: https://docs.docker.com/engine/reference/commandline/logout/
https://github.com/yorkie-team/yorkie/issues/377

Why:

The user can use the logout command to delete authentication information locally.

I'm interested in this issue. can I work on it?

Thank you for your research.
Instead of token invalidation, I think deleting the token from the context file(~/.yorkie/config.json) would be a more appropriate way to handle the logout command for now.
It might be beneficial to consider aspects such as token invalidation for future reference as well.


Fix test for #30674

Feature Description
https://github.com/go-gitea/gitea/pull/30676#pullrequestreview-2020092429
Screenshots
No response

Fixed in #30699


Merge conflicts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: nico2021fau:x: fe27hityYou have signed the CLA already but the status is still pending? Let us recheck it.


Output the error message when there is a problem.

This happens more often than we like, at least give a hint...

LGTM


feat(api): Add an OpenAPI spec for the HTTP API

overview
This adds an OpenAPI 3.0 spec for our HTTP API. It is mostly correct and schemad and exampled; it passes the swaggerdocs generator.
I have never made one of these before! So I am extremely interested in all comments and suggestions. I'd specifically like eyes around

openapi doesn't support patternProperties, which is kind of required for things like GET /settings/pipette to be forward compatible. I used "x-patternProperties" (as recommended by some random blog posts) which I'm not sure was the right move. I just really don't want to have to list all the properties explicitly
how do you list the endpoint that returns the spec?
is there more we should do with metadata? list the port somehow? does that make sense?
is there other stuff I should change to make this useful?
is this apache-2 licensed like the code itself?

Closes #4635

Points for discussion

Since this is for the current HTTP API that is not congruent with how the new HTTP API should look, can we maybe have the version as "0" instead of "1"?
OR
Should we even have a full OpenAPI spec for our current HTTP API at all? Is this something we want to even encourage people to develop off of?
how do you list the endpoint that returns the spec?

Maybe we can simply add the path in our health endpoint in lieu/in addition to having max supported HTTP version?
Or, we can automatically return it when the root path is accessed?

Still noodling on the other stuff you listed.

Since this is for the current HTTP API that is not congruent with how the new HTTP API should > look, can we maybe have the version as "0" instead of "1"?
OR
Should we even have a full OpenAPI spec for our current HTTP API at all? Is this something we > want to even encourage people to develop off of?

Yeah I think we should have the spec just because that's what reflects reality. I don't think we should just ignore it, unfortunately. Versioning wise, I get a little nervous about a version 0 but I guess I could see it

* Maybe we can simply add the path in our `health` endpoint in lieu/in addition to having max supported HTTP version?

Yeah that's a good idea I'll do that. Unfortunately we can't do the root path thing because that's the websocket path.

Have you considered using something like the aiohttp-swagger module? This autogenerates an openapi spec from meta comments placed above each endpoint. In my experience, this minimises the chance of an api change not being reflected in the docs. [I must admit to not having used aiohttp-swagger, but have used one the flask equivalents (flassger)...so can't vouch for its completeness]

@henrynash we investigated aiohttp-swagger, but chose not to use it (or any other API-spec-from-code tool) for a variety of reasons.
Why not aiohttp-swagger?

None of us like YAML, and writing YAML in docstrings seems especially painful
We're not super confident that this library will remain maintained

Why not API spec from code?

Philosophically, we want to separate the API specification from the implementation itself

If at some point the spec doesn't match actual API behavior, we want to have a layer of separation so that devs will be careful when considering whether the API is wrong or the spec is wrong
We'll be using the spec for more than just documentation; it will be running integration tests and API mocks for client development

Scattering the API spec across a variety of Python files makes it harder for devs (especially non-Python devs) to interact with, update, and/or sandbox changes to the spec

@mcus I think those are fair comments (particularly the one regarding confidence in library maintenance). You can, of course, still take advantage of spec-generators for the extended uses (such as testing and client generation). Given that you are providing the openAPI spec on a url (rather than only as an external doc), then you secure many of the openAPI eco-system advantages. This is great stuff.

@mcous Fixed the lint complaints except the ones that misunderstand "example" and "nullable"


The 3D files of doors and windows

Thank you very much for your outstanding work. I would like to ask whether there are corresponding 3D files for doors and windows, and if so, how can I download them?

Those assets are embedded in [Ai2-THOR]((https://github.com/allenai/ai2thor), and you can find the prefab files here


Stunprod rework

About the PR

StunDamage 20 => 35
EnergyPerUse 70 => 120
ActivatedDamage 0 => 5 shock
Why / Balance

At the moment stunprod is useless and no one uses it, the recipe has been changed to be more consistent with the sprite
Technical details

n/a
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/140359015/8603a3e3-44ca-421e-a135-439935bf74c6
Breaking changes

Changelog

:cl:

tweak: Now for crafting stunprod you need: igniter, cable cuffs, small power cell, metal rod.
tweak: Stunprod deals 35 stamina damage per hit and 5 shock damage. The battery charge is enough for 3 hits.

make the cell removable

Stunprod is supposed to suck because it's overpowered in ss13 and it stops people trying to port it. As long as the cell isn't interchangeable its probably fine.

Well if you don't remove the celle, make it rechargeable by something else then a weapon recharger

Syunprod should be a weakened version of a regular baton, if you make the stamina damage less than that of a baton, then no one uses it. Nobody forbids doing 2-3 stunprods at once in order to definitely introduce someone to staminacrit.

 As long as the cell isn't interchangeable its probably fine.


sci.vision error opening pull request

When trying to upload a model to the model catalogue using the frontend form I get the error message below and can't open a pull request:
> The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined

#653 seems to have solved this problem


Debugger Canvas

Ideas from here http://visualstudiogallery.msdn.microsoft.com/4a979842-b9aa-4adf-bfef-83bd428a0acb

Moved to https://prodbg.phoreplay.com/T30


Error while running Docker image polusai/nyxus:0.2.1

The following error appears while running polusai/nyxus:0.2.1 with Docker and Singularity:
/opt/executables/nyxus: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /opt/executables/nyxus)

Following our discussion, it appears that the error is not due to Singularity compatibility after all, I can reproduce it with Docker and I see that the entrypoint in the Dockerfile contains an absolute path.

Error appears to be fixed in versions 0.2.2 and 0.2.3.


Dead link: https://github.com/WavePlayz/Bedrock-Scripting-API/tree/master/utility/Timer

(in Useful Links)

fixed https://github.com/SirLich/bedrock-wiki/pull/247


fix(#726): Icon component should have ability to remove title tab inside svg

Closes IBM/carbon-components-react#726
Icon component should have ability to remove title tab inside svg
Changelog
Changed
Icon

add iconTitle prop , and the Icon's title will still use description prop if  iconTitle is undefined

Tooltiop

add iconTitle prop , and the default value is ""

Since aria-label is there, I'm fine with this change as this should not affect a11y

Bump @xiaolixu for status 👍

@joshblack  The root cause of the linked issue is that the parameters "description" "alt" and "title" in the component "Icon" use the same variable, so iconTitle is added for parameter "title".

@xiaolixu Thank you for jumping in and my apologies for being late. The code change looks good from my perspective. Wrt Storybook, do you want to change Icon-story.js? One way to do this is something like this (though I haven't tested it):
--- a/src/components/Icon/Icon-story.js
+++ b/src/components/Icon/Icon-story.js
@@ -42,9 +42,10 @@ const props = () => {
     width: text('The SVG `width` attribute (width)', ''),
     height: text('The SVG `height` attribute (height)', ''),
     description: text(
-      'The content in <title> in SVG (description)',
+      'The a11y text (description)',
       'This is a description of the icon and what it does in context'
     ),
+    iconTitle: text('The content in <title> in SVG (iconTitle)', ''),
     className: 'extra-class',
   };
 };

@xiaolixu did you want to make the storbook updates Akira suggested so we can get this merged in?

Going to close this due to inactivity. Feel free to re-open the PR if you're still willing to take this on! Just a couple of notes left around Storybook and comments updates 👍

@asudoh @alisonjoseph   Sorry for no response much time.  I took one long holiday and missed your info after i am back.  now  open one new pr to update the storybook , thanks!


DEX-293 pt. 1

Adds featured_asset_guid to the individual. If the individual's encounters don't have any annotations and therefor assets it will return None, although this would be a weird case.
If no featured_asset_guid has be set by a user, it will return the guid of the first asset it finds associated with the individual.
As is tradition, the EDM individual JSON will be augmented with the featured_asset_guid.

/rebase

/rebase


[FEAT] Import / Export milling pattern protocol

Add functionality to import / export milling pattern / protocol / stages to a file (yaml)

@patrickcleeve2 migrate


Getting a KeyError: u'module' error when i run python manage.py migrate

Can you let me know how to fix this error.
bash % python manage.py migrate
/Library/Python/2.7/site-packages/treebeard/mp_tree.py:102: RemovedInDjango18Warning: MP_NodeManager.get_query_set method should be renamed get_queryset.
class MP_NodeManager(models.Manager):
Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/Library/Python/2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/Library/Python/2.7/site-packages/django/core/management/init.py", line 354, in execute
django.setup()
File "/Library/Python/2.7/site-packages/django/init.py", line 21, in setup
apps.populate(settings.INSTALLED_APPS)
File "/Library/Python/2.7/site-packages/django/apps/registry.py", line 108, in populate
app_config.import_models(all_models)
File "/Library/Python/2.7/site-packages/django/apps/config.py", line 202, in import_models
self.models_module = import_module(models_module_name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/Library/Python/2.7/site-packages/wagtail/wagtailcore/models.py", line 268, in
class Page(six.with_metaclass(PageBase, MP_Node, ClusterableModel, index.Indexed)):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/six.py", line 566, in with_metaclass
return meta("NewBase", bases, {})
File "/Library/Python/2.7/site-packages/django/db/models/base.py", line 71, in new
module = attrs.pop('module')
KeyError: u'module'

Hi @asvarmaa,
Please use the mailing list for support queries.

Traceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/Library/Python/2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/Library/Python/2.7/site-packages/django/core/management/init.py", line 354, in execute
django.setup()
File "/Library/Python/2.7/site-packages/django/init.py", line 21, in setup
apps.populate(settings.INSTALLED_APPS)
File "/Library/Python/2.7/site-packages/django/apps/registry.py", line 108, in populate
app_config.import_models(all_models)
File "/Library/Python/2.7/site-packages/django/apps/config.py", line 202, in import_models
self.models_module = import_module(models_module_name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/Library/Python/2.7/site-packages/wagtail/wagtailcore/models.py", line 268, in
class Page(six.with_metaclass(PageBase, MP_Node, ClusterableModel, index.Indexed)):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/six.py", line 566, in with_metaclass
return meta("NewBase", bases, {})
File "/Library/Python/2.7/site-packages/django/db/models/base.py", line 71, in new
module = attrs.pop('module')
KeyError: u'module'

Thanks for the update, i have created a new topic in the mailing list


Added copy button on UserAccount component

This PR contains improvements on adding click to copy account Id on User Account UI
closes #2620

Clicking other area within the User Account UI will work as normal:

Short accountId:

Long accountId:

I'm closing this PR as the issue has been resolved by this PR.


Reload speaker recycler view due to the transition bug

Issue

refs #568

Overview (Required)

This is very ugly patch, so you should not merge this basically.
It seems that the sessionsRecycler is not reloaded during transition, so this patch notifies it on end of the transition
I know #611 is already there.

Links

none

Screenshot

none

:eyes:

I think about cherry-pick into release :eyes:

LGTM 👍


Replace Canny with Nolt (closes #775)

👢 🗑
I've observed an issue here where moment timezone doesn't seem to get imported properly and it breaks the _getCurrentUser method in the application route. Not sure if it's something weird on my end so would appreciate if whoever reviews this could check if that works for them. Dunno if the discussion here is related: https://github.com/hummingbird-me/kitsu-web/pull/775

Thank you for doing this!

SSO (with nolt('identify', { jwt: token })) doesn't seem to happen when logged in on Kitsu

Ah yep my bad forgot to note it uses this branch. https://github.com/hummingbird-me/kitsu-server/tree/nuck/nolt-sso
Will get that updated to relocate the token in the graphql schema

lmk when you've got that branch updated and I can give it 👀  pretty quick

LGTM! Don't merge until the server side has been deployed to production yet though - I deploy the-future to production regularly with translation updates

https://github.com/hummingbird-me/kitsu-server/pull/869

Do we want to set up the "remote Login URL" thing? nolt.io/help/single-sign-on

We probably want to do this. The canny integration has started getting spammed by non-Kitsu accounts over the past year which I've had to delete.


Adding BTU (BTU Protocol) token

Submitting the data of BTU (BTU Protocol) token
Public links about the token :

company website : https://www.btu-protocol.com/
Etherscan link : https://etherscan.io/token/0xb683d83a532e2cb7dfa5275eed3698436371cc9f
coinmarketcap url : https://coinmarketcap.com/currencies/btu-protocol/
Our hotel booking dapp : http://btu-hotel.com/

Hi @appyhour770 just merged this https://github.com/MetaMask/eth-contract-metadata/pull/211 closing this PR. Thanks.


metadata passed through onSuccess callback

Fixes issue with metadata not being passed back through onSuccess callback (as compared to plaid's standard module)

Any movement on this?

I'm trying to get control of the npm so I will be able to put it in.
On Aug 26, 2016 3:56 AM, "Dan Hackner"<EMAIL_ADDRESS>wrote:

Any movement on this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/csbarnes/angular-plaid-link/pull/2#issuecomment-242671768,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG6LrRPA2VxMxgUPQ4e22d7wwxv44VJbks5qjqo0gaJpZM4IKNjM
.

👍


[DS-4407] Support JDPA debug option (for Eclipse & other IDEs) with DSpace Docker

I have had some recent luck debugging Java Tomcat Apps running in Docker with Eclipse.
The following PR would provide support to for DSpace 7.
https://jira.lyrasis.org/browse/DS-4407
Launch DSpace Docker with the following command:
docker-compose -f docker-compose.yml -f dspace/src/main/docker-compose/jdpa-debug.yml up -d
Create a remote debug configuration in Eclipse:

Set a breakpoint in the code and invoke that code via the HAL browser:

Eclipse Project Setup
Note: In my Eclipse configuration, I imported the DSpace code into Eclipse "as a Maven Project".  I do not know if this necessary to enable the debugger to locate the necessary source modules.

Per Slack conversation with @kshepherd  and @J4bbi, I wonder if this solution would be applicable to any IDE that supports jdpa debugging.  If so, I recommend renaming eclipse-debug.yml to jdpa-debug.yml.  I would need confirmation from users of other IDE's.

Closing as outdated


Indy: K8S Auth job Helm release

Create the Helm release for the K8S Auth job Helm chart.

Closed by #156