Make the Keyboard Manager keyboard specific

Description of the new feature / enhancement
There could be different sets of settings in the keyboard manager, which would be active only for the specific keyboards that they've been assigned to.
Scenario when this would be used?
As a laptop user I sometimes use the the built in keyboard, other times I attach my own separate keyboard and use that. They have a different layout, so if I optimize the settings to the first one it makes using the other one worse.
Supporting information
No response

with the current way we are doing the detection, we cannot do per-keyboard.  We have 2 investigation tasks but as of now, we cannot do this via public APIs.


Set EnumsAsInts as True for jsonpb

Fix the error like"
unknown value "HEALTHY" for enum v1alpha2.InstallStatus_Status which cause the reconcile does not work.

@irisdingbj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
49285c1e06599713d344f4c14d7dc91b3ab5d8df
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
49285c1e06599713d344f4c14d7dc91b3ab5d8df
link
/test gencheck_operator

lint_operator
49285c1e06599713d344f4c14d7dc91b3ab5d8df
link
/test lint_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
49285c1e06599713d344f4c14d7dc91b3ab5d8df
link
/test lint_operator

gencheck_operator
7641af1c365d3cd85de6ef008768887e86238e57
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Agent][Plugins]Return plugin info

增加AIMessage的plugin infor字段，传入PluginStep。
增加AIMessage对Plugin Infor的str表示，从而logging过程能打印plugin-info。
agent层面逻辑修改，对其他文件进行适配，其中functionAgentwithRetrieval逻辑复杂，尚未适配

Codecov Report
Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (c99142c) 61.57% compared to head (0728170) 60.44%.
Report is 1 commits behind head on develop.

Files
Patch %
Lines

erniebot-agent/src/erniebot_agent/agents/base.py
33.33%
22 Missing :warning:

...t-agent/src/erniebot_agent/chat_models/erniebot.py
0.00%
3 Missing :warning:

...gent/src/erniebot_agent/agents/functional_agent.py
92.00%
2 Missing :warning:

...ot_agent/agents/functional_agent_with_retrieval.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    61.57%   60.44%   -1.14%
===========================================
  Files           56       56
  Lines         2751     2811      +60
===========================================
+ Hits          1694     1699       +5
- Misses        1057     1112      +55

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

这个PR合入以后，我同步到retrieval agent里面


Fix #137.

This should fix #137.

You've apparently tested it; I reviewed gmaxwell's original commit and all looks well to my inexperienced eyes.
If you feel comfortable with it, you have the permissions to merge it:
Merge it.


config of prompt processor seems to be wrong

Hi, I tried to run code but failed. I noticed that the config of prompt processor seems to be wrong. Following the theme-station-render.yaml, the coding will run with run to
            self.ref_prompt_processor = threestudio.find(                 self.cfg.prompt_processor_type             )(self.cfg.ref_prompt_processor)
but the cfg.ref_prompt_processor is empty.

@hey0chen Hi, we wrongly set  use_reference_model_dreambooth=True in config/theme-station-render.yaml (L28). Please set this option to False and try again.

@hey0chen Hi, we wrongly set use_reference_model_dreambooth=True in config/theme-station-render.yaml (L28). Please set this option to False and try again.

@zhenwwang Thanks for reply, the code was already to run at this stage, but got a new problem. Can you check the parameters of theme-station-optimization.yaml? I got the similar error when I run sh scripts/run_optimization.sh

@hey0chen Hi, could you please provide the error message for reference? I cannot reproduce this error on my site.

@hey0chen Hi, could you please provide the error message for reference? I cannot reproduce this error on my site.

Sorry, I found the reason of this erro, it was caused by failing to download online model of huggingface. Thank you for your reply!


YARN-11530. Server$Listener stating too many open files when setting ipc.server.read.threadpool.size big enough

Description of PR
https://issues.apache.org/jira/browse/YARN-11530
This PR adds a catch for the too many open files to avoid crashing the system and also shuts down the readers already opened to allow for customized failovers and later actions.
How was this patch tested?
(1) set ipc.server.read.threadpool.size to 50000
(2) run org.apache.hadoop.yarn.TestRPCFactories#test
An extra IOException hinting where the problem is can be observed in the output of the test.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 22s

trunk passed

+1 :green_heart:
compile
17m 14s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 23s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 27s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

+1 :green_heart:
javadoc
1m 21s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 36s

trunk passed

+1 :green_heart:
shadedclient
36m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
16m 24s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 24s

the patch passed

+1 :green_heart:
compile
16m 11s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 21s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 160 unchanged - 0 fixed = 162 total (was 160)

+1 :green_heart:
mvnsite
1m 46s

the patch passed

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 46s

the patch passed

+1 :green_heart:
shadedclient
36m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 14s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 13s

The patch does not generate ASF License warnings.

225m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6037/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6037

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 600535f8e75c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 27c5fb08bf74ce0ab4c1842472cf65c67bc055e0

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6037/2/testReport/

Max. process+thread count
1302 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6037/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


async_support.timeseries

When using the code in the readme (see below). I get the following error on the TimeSeries import
"Cannot find reference 'TimeSeries' in 'timeseries.py' "
import asyncio
from alpha_vantage.async_support.timeseries import TimeSeries
symbols = ['AAPL', 'GOOG', 'TSLA', 'MSFT']
async def get_data(symbol):
ts = TimeSeries(key='YOUR_KEY_HERE')
data, _ = await ts.get_quote_endpoint(symbol)
await ts.close()
return data
loop = asyncio.get_event_loop()
tasks = [get_data(symbol) for symbol in symbols]
group1 = asyncio.gather(*tasks)
results = loop.run_until_complete(group1)
loop.close()
print(results)

Closing this for now as our team was unable to reproduce the issue. Will re-open if other users report similar issues.

I copied and pasted that code directly from the readme into my IDE, after installing the alpha_vantage python package, are there any steps that I am missing ?


list: Decode key/prefix and marker/continuation in Core layer

Some modules depending on minio-go, such as Minio Gateway S3, depends
on minio-go Core to perform listing. However a regression is found
because decoding keys and common prefixes, along with marker for list v1
and next continuation for list v2 is not happening in Core module
but in higher level.
This PR moves decoding to Core level.

You need to do this for listMultipartUploads as well

Done


Add more testing locations to locations/

Locations should follow the .json format described in locations/template.txt
These locations are not intended to be final, and as the setting changes, we probably delete some and update others. We mostly just need to rigorously test the Location navigation and parsing system.

hey, Will, I added some locations on [whatever-branch]


Individualized address in requests: Hello, (name)

As an editor
I would like to be able to address all my contributors by their name when sending out requests. Therefore I need to be able to use a button to individualize requests, displaying e.g. "Hallo ((VORNAME))"

Our value proposition is personalized communication and sending out messages with broken placeholders would ruin that (and would probably have a negative impact on contributor engagement). Therefore, we should consider how to prevent that. A few different approaches I could imagine:
Identifying syntax errors: If we use some custom syntax for placeholders (e.g. {{VORNAME}} and an editor makes a mistake (e.g. they might use a placeholder that we do not support or they use single braces instead of double braces), we should try to warn them about this before sending out any messages („Looks like you meant to use a placeholder, did you mean {{VORNAME}}?”).
Showing a preview/confirmation: We could preview the message as it would be rendered for a random contributor. This might help editors to spot mistakes.
Highlighting placeholder: This helps identifying placeholders as well as non-supported placeholders/invalid syntax.


Fix the calculation of the angular velocity

Fix #63004
before this patch:
https://user-images.githubusercontent.com/6397893/179704430-35b93c09-a0e6-4d6c-b56a-7232d86fd5c0.mp4
after this patch:
https://user-images.githubusercontent.com/6397893/179704475-b12bf53f-90fd-474f-8e67-07559bc4b8d5.mp4
Description
The angular speed calculation was wrong when the rotation speed was not enough.
In Basis::get_axis_angle, the first condition tested an epsilon of 0.01.
For example, by rotating on Y by 0.005 radians per frame (which is not that slow as you can see in the video) which correspond to an angular velocity of (0, 0.600408, 0), you end up with a difference for Math::abs(rows[2][0] + rows[0][2] of<PHONE_NUMBER>5861 (and sometime<PHONE_NUMBER>965 which explain with in this speed, the cube is moving a bit), so when the value is lower than the epsilon, the function don't return an angular velocity.
test project:  bug-rotation.zip

looks ok to me, @aaronfranke what do you think?

Thanks!

Cherry-picked for 3.5.

@and-rad Yes, currently only rotation velocity (displacement) is taken into account. I proposed to add the rotation (angle) as well in the near future.


RUM-4516 flag critical events in custom persistence

What does this PR do?
Adds an additional flag when writing event to let storage handle those differently.
Motivation
Because some users with custom PersistenceStrategy use mainly a memory based storage, they need to know when the app is about to crash in order to persist the data in a way that can be retrieved after an app reboot.
Additional Notes
An additional type was created for telemetry, just to be able to distinguish it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (f4f8507) to head (6fadd84).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2044      +/-   ##
===========================================
- Coverage    83.03%   82.97%   -0.06%
===========================================
  Files          493      494       +1
  Lines        17701    17709       +8
  Branches      2685     2682       -3
===========================================
- Hits         14697    14693       -4
- Misses        2271     2274       +3
- Partials       733      742       +9

Files
Coverage Δ

...otlin/com/datadog/android/api/storage/EventType.kt
100.00% <100.00%> (ø)

...droid/core/internal/persistence/AbstractStorage.kt
100.00% <100.00%> (ø)

.../core/internal/persistence/FileEventBatchWriter.kt
97.50% <ø> (ø)

.../core/internal/persistence/NoOpEventBatchWriter.kt
100.00% <ø> (ø)

...og/android/core/persistence/PersistenceStrategy.kt
100.00% <ø> (ø)

...in/com/datadog/android/log/internal/LogsFeature.kt
84.06% <100.00%> (-2.17%)
:arrow_down:

...g/android/log/internal/logger/DatadogLogHandler.kt
77.12% <100.00%> (ø)

...dog/android/log/internal/storage/LogsDataWriter.kt
100.00% <100.00%> (ø)

...g/android/rum/internal/DatadogLateCrashReporter.kt
84.75% <100.00%> (-2.26%)
:arrow_down:

...tadog/android/rum/internal/domain/RumDataWriter.kt
100.00% <100.00%> (+11.11%)
:arrow_up:

... and 10 more

... and 28 files with indirect coverage changes

@0xnm regarding your idea to provide a flush method, it does make a sense, but IMO makes an assumption on what the implementation looks like (in this case that the custom implementation will always be an in memory).
If a customer wanted to use a local DB instead of batch files, the notion of flushing data would make no sense. Flagging the events themselves as Crash means they can add their own logic on top of it, e.g.  send them first when we request data to be sent in the next intake request.


DotMerge is confusing name for a class because it does not do a dot product

The name on the DotMerge class is confusing and it also does not seem to be used anywhere.
Maybe it should be deleted ?

Yup, that is a legacy class. I deleted it.


[ERROR] Invalid packaging for parent POM com.google.guava:listenablefuture:1.0, must be "pom" but is "jar" @

We have several projects receiving the bellow log error:
Could not get package information for dependency 'com.google.guava:listenablefuture:1.0': ProjectBuildingException: 3 problems were encountered while building the effective model for com.google.guava:listenablefuture:1.0 [ERROR] Invalid packaging for parent POM com.google.guava:listenablefuture:1.0, must be "pom" but is "jar" @ [ERROR] Invalid packaging for parent POM com.google.guava:listenablefuture:1.0, must be "pom" but is "jar" @ [FATAL] The parents form a cycle: com.google.guava:listenablefuture:1.0 -> com.google.guava:listenablefuture:1.0 @ for project com.google.guava:listenablefuture:1.0 at /builds/oss/oss-review-toolkit/ort-gitlab-ci/cache/.gradle/caches/modules-2/files-2.1/com.google.guava/listenablefuture/1.0/48183accf902b8d60bc6c853aa5c57febd124a48/listenablefuture-1.0.pom Caused by: ModelBuildingException: 3 problems were encountered while building the effective model for com.google.guava:listenablefuture:1.0 [ERROR] Invalid packaging for parent POM com.google.guava:listenablefuture:1.0, must be "pom" but is "jar" @ [ERROR] Invalid packaging for parent POM com.google.guava:listenablefuture:1.0, must be "pom" but is "jar" @ [FATAL] The parents form a cycle: com.google.guava:listenablefuture:1.0 -> com.google.guava:listenablefuture:1.0 @
After some search I found this related issue https://github.com/oss-review-toolkit/ort/issues/2115 which was fixed a while ago. Did something change since then?

I've extended the existing curation for version 9999.0-empty-to-avoid-conflict-with-guava of that artifact to also cover version 1.0: https://github.com/oss-review-toolkit/ort-config/pull/148

The curation has been merged in ort-config. Taking it into use should resolve the issue.

This issue resurfaced using GradleInspector, while legacy Gradle works fine.

That doesn't make sense, as the issue was fixed via a curation, which is independent of the package manager being used.
If you still believe that the issue persists, please provide a repository to analyze to reproduce the issue.


Merge Intervals

Please assign me this problem in c++ for hacktoberfest

https://github.com/piyushsharma220699/Hacktoberfest-2021/issues/53
This issue was already assigned to @Shreyas12345678 ! Please create issue for some other leetcode problem 👍🏻 Then I'll assign you 🔢


prune之后再训练完毕的模型，继续加载训练无法载入权重

生成sensi文件，继续进行训练，将训练之后的模型保存，之后再加载该模型训练，提示没有权重被加载
部分信息如下
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-2_weights doesn't match.(Pretrained: (361, 552, 1, 1), Actual: (960, 960, 1, 1))
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-2_bn_scale doesn't match.(Pretrained: (361,), Actual: (960,))
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-2_bn_offset doesn't match.(Pretrained: (361,), Actual: (960,))
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-2_bn_mean doesn't match.(Pretrained: (361,), Actual: (960,))
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-2_bn_variance doesn't match.(Pretrained: (361,), Actual: (960,))
2021-04-12 16:52:01 [WARNING]	[SKIP] Shape of pretrained weight conv-1_weights doesn't match.(Pretrained: (10, 361, 1, 1), Actual: (10, 960, 1, 1))
2021-04-12 16:52:01 [WARNING]	There is no pretrain weights loaded, maybe you should check you pretrain model!
2021-04-12 16:52:01 [INFO]	Start to prune program with eval_metric_loss = 0.1
model = pdx.seg.HRNet(
num_classes=N_CLASSES,
width=WIDTH,
class_weight=weights,
input_channel=4
)
import warnings
with warnings.catch_warnings():
warnings.filterwarnings("ignore", category=DeprecationWarning)
model.train(
num_epochs=swa_EPOCHS,
train_dataset=train_dataset,
train_batch_size=BATCH_SIZE,
eval_dataset=None,
optimizer=optimizer,
log_interval_steps=20,
save_interval_epochs=SAVE_INTERVAL,
save_dir=SAVE_DIR,
pretrain_weights=pretrain_weights_path,
sensitivities_file='hrnet.sensi.data',
eval_metric_loss=0.1,
use_vdl=True)
其中pretrain_weights_path是已经裁剪后又训练多轮的模型路径

裁剪后的模型不能被作为预训练模型


test: add e2e test for DataTable

affects: test-puppeteer

@ilya-trifonov Please resolve conflicts and merge


Unable To Work With Two Nodes

Hi, we are unable to complete the following using hooks or validation;
func (Payment) Fields() []ent.Field {
    return []ent.Field{
        field.Float("amount").
        Validate(func(amount float64, order *ent.Order) {
            if amount != order.Total {
                fmt.Errorf("Your payment amount %v does not match order total %v, with order ID: %v. Please try again", amount, order.Total, order.ID)
            }
        }),

also, here's a hookthat want compile
client.Use(func(next ent.Mutator) ent.Mutator {
            return hook.InvoiceFunc(func(ctx context.Context, invoice *ent.InvoiceMutation) (ent.Value, error) {
        if *ent.Payment.Amount() == *ent.Order.Total() {
                invoice.Is_paid(): true,
                {else
                    {
                        invoice.Is_paid():false,
                    },
                }
                        }
                        return next.Mutate(ctx, invoice)
                    })
                },
      }
}

Hey @wr125 👋

also, here's a hook that want compile
client.Use(func(next ent.Mutator) ent.Mutator {
            return hook.InvoiceFunc(func(ctx context.Context, invoice *ent.InvoiceMutation) (ent.Value, error) {
        if *ent.Payment.Amount() == *ent.Order.Total() {
                invoice.Is_paid(): true,
                {else
                    {
                        invoice.Is_paid():false,
                    },
                }
                        }
                        return next.Mutate(ctx, invoice)
                    })
                },
      }
}

Something is broken with this Go code as it contains a few syntax errors.

Can you please paste here your ent/schema (payment and order) and the logic you try to implement using hooks?

The above example is what we want to be able to do in ent but this is the closes we got. Here is also want we want to do with payment and order in ent
c.Use(func(next ent.Mutator) ent.Mutator {
			return hook.PaymentFunc(func(ctx context.Context, p *ent.PaymentMutation, o *ent.OrderMutation) (ent.Value, error) {
		if p.Amount() != o.Total() {
				fmt.Errorf("Your payment amount %v does not match order total %v, with order ID: %v. Please try again", amount, order.Total, order.ID)
						}
						return next.Mutate(ctx, p,o)
					})
				},

				// Limit the hook only for these operations.
				ent.OpCreate|ent.OpUpdate|ent.OpUpdateOne,

			),
        }
}

Hey @wr125,
Regarding your hook example - hooks are attached to specific mutations or a list of mutations, but your function signature is incorrect. Please see the docs and the example in our website, and let me know if something is missing there (we can add more info and example to it).
For this specific example, Order and Payment are not connected with any edge in the above schema. But in general, if you want to load a relation/association in a hook, you can use the Client/Tx method on the mutation to execute regular queries. For example:
hook.PaymentFunc(func(ctx context.Context, m *ent.PaymentMutation) (ent.Value, error) {
	id, ok := m.ID()
	if !ok {
		// fail.
	}
	// Load associations.
	inv := m.Client().Invoice().Where(invoice.HasPaymentID(id)).OnlyX(ctx)
	// Run your validation here.
	if <condition> {
		 // fail.
	}
	// Call the next hook in the chain.
	return next.Mutate(ctx, m)
})

i have updated the edge of invoice. Would this help?
// Fields of the Invoice.
func (Invoice) Fields() []ent.Field {
	return []ent.Field{
		field.Bool("isPaid"), //update this column with payment amount column. Use a hook
		field.UUID("reference", uuid.UUID{}).
			Default(uuid.New),
	}
}
// Edges of the Invoice.
func (Invoice) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("orders", Order.Type),
		edge.To("messages", Message.Type),
		edge.From("payments", Payment.Type).
			Ref("invoices"),
	}
}


v6.0.1: Fix Aurelia detection

What does this PR do?
Aurelia requires that the entry file exports a configure function, which was making the TargetsFinder service think it was a library.
I added a protected property with a list (with just Aurelia for now) of frameworks that use export on the entry file, that way the service will check the list and if the framework is there, it won't set library to true.
How should it be tested manually?
npm test
# or
yarn test

Pull Request Test Coverage Report for Build 253

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 250:
0.0%

Covered Lines:
2143

Relevant Lines:
2143

💛  - Coveralls


chore: Fix watcher plugin for Windows users

Description
This PR addresses an issue where our watcher plugin that rebuilds the TW plugin previously didn't work for contributors that were using Windows.
Changsets
Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.
Checklist
Please read and apply all contribution requirements.

[ ] This PR targets the dev branch (NEVER master)
[ ] Documentation reflects all relevant changes
[ ] Branch is prefixed with: docs/, feat/, chore/, bugfix/
[ ] Ensure Svelte and Typescript linting is current - run pnpm ci:check
[ ] Ensure Prettier linting is current - run pnpm format
[ ] All test cases are passing - run pnpm test
[ ] Includes a changeset (if relevant; see above)

I've confirmed this is working fine on Mac. @HugeLetters and Alexander confirmed this was functional on Windows via Discord.


Attempting anonymous user link is returning "No supported providers." error.

So I've literally tried anything and everything I could think of to fix this.
I have my anon user that I'm trying to link/upgrade with an existing account, now this works if I try to link/upgrade it to an account that say, has an email & a phone number attached.
But the problem is, let's say I have said account above AND a Facebook account with the same email, those will not merge, it just returns the error. Now I'm not sure if this is intended behavior and if it is there's probably a better way to handle it than pass it as a "DEVELOPER_ERROR".
Accounts laid out:
"Facebook Provider"<EMAIL_ADDRESS>"Google & Phone Provider (Linked)"<EMAIL_ADDRESS>& +12345678900"
Works ONLY using Phone: Anon upgrade to -> "Google & Phone Provider (Linked)"
Doesn't work: Anon upgrade to -> "Facebook Provider"

@austinhodak thanks for the report!  I am a little bit confused by the situation.  Could you lay out the reproduction steps in order so that I can get this bug to happen?

@samtstern Ya sorry! It's kinda hard to explain but I'll try my best!
First time users are logged in Anonymously. Then I have the login builder with the enable auto upgrade.
Anonymous User trying to login:
-- Upgrading to NEW account (Works)
-- Upgrading to existing account (Google/Phone) works ONLY when using the Phone number.
-- Upgrading to existing account (Facebook w/ same email as above Google) doesn't work.
See photo below for the accounts, the only way I can upgrade an anon user to any of the 2 is by using the phone number.

@austinhodak thanks!  So I assume from that screenshot that you have the "multiple accounts per email" setting enabled on your project.

@samtstern I assume the temporary solution would be to just disable the "multiple accounts per email" setting?

Sorry I dropped the ball on this issue!  I've been traveling for work and
haven't had much quality time to sit down and code.
Yeah I suspect that would help, since that's the setting I use for all of
my testing.  Of course that would be a big change for your app, so I
understand why you might not want to try that.
On Thu, Oct 25, 2018, 1:09 AM Austin Hodak<EMAIL_ADDRESS>wrote:

@samtstern https://github.com/samtstern I assume the temporary solution
would be to just disable the "multiple accounts per email" setting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/1489#issuecomment-432869104,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEw6rb-i9PbQ7jGomiU9zOhgNfwva4zks5uoQEfgaJpZM4XsW3v
.

@samtstern It's ok! I just went ahead and disabled it for now, shouldn't affect my sign in flow, and having the ability to actually upgrade anon users was more important to me than allowing multiple emails.

*accidentally closed this, my bad, reopening.

This is complex and I don't want to put 4.3.0 at risk so punting it to 4.3.1

We're seeing the same issue.
It looks like a customer originally signed up via Facebook, then logged in via email/password, and now is trying to log in with Facebook again, but receives: "No supported providers." via FirebaseUI Android.
Looking in the authentication list, the only provider icon listed is the email/password icon.
It's as if the Facebook provider was removed from the user account.

@ahaverty thanks for that extra info, it simplifies things a bit in my mind.
@lsirac is it the intended behavior for password to "override" Facebook?  If not can you take a look at this?

@ahaverty I'm guessing you have multiple accounts per email enabled, right? Otherwise there's no way for you to sign in with Facebook, and then log in via email and password.
Unfortunately, the linking and anonymous upgrade flows depend on using the fetchSignInMethodsForEmail API. When multiple accounts per email is enabled, this API doesn't work in the same way, breaking our flows.

@lsirac Yes we have multiple accounts, anonymous exploration and anonymous merging. Some of our users sign in via our end-user application and later sign up to our business product which allows them to do more like managing other user's spend.
We only allow passwordless email signup for this.
This sounds like fetchSignInMethodsForEmail isn't working as designed?

Sorry for my lack of response here, I talked with @lsirac and a few others about this and basically there is no way we can get FirebaseUI linking to work completely correct for the "multiple accounts per email" case without making backend changes to fetchSignInMethodsForEmail.  We agree that it doesn't work how we want, but also changing it would be non-trivial and would be possibly breaking change in behavior for anyone relying on the current behavior.
For the forseeable future there won't be anything we can do within FirebaseUI to make this better, so I am going to close this issue.  I'll make sure to document this whole discussion in an internal bug report so that if we ever do change how it works on the backend we can re-open this and get it right.


Add support for service account token authentication to remote clusters

In #82 I reported authentication issues with GKE. The OAuth token expires every hour and Google Cloud Tools is needed to renew it. We will face similar problems with other cloud providers. An alternative solution that is cloud provider-agnostic is to use service account tokens from the remote clusters. An approach was described in this article.
I propose that we create a script that does the following:

Get the service account token from the k8ssandra-operator service account in the remote cluster
Get the CA cert from the k8ssandra-operator service account in the remote cluster
Create a kubeconfig for the remote cluster
Create a kubeconfig secret in the control plane cluster
Create a ClientConfig in the control plane cluster. It should reference the secret.

┆Issue is synchronized with this Jira Task by Unito
┆Issue Number: K8SSAND-799
┆Priority: Medium

Note that in future Kubernetes versions static service account secrets  will probably be phased out in place of ephemeral ones  that are auto-renewed:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/1205-bound-service-account-tokens/README.md
https://github.com/kubernetes/enhancements/issues/542
I think the plan is to enable this behaviour by default in 1.22.  Something in my be

Thanks for the references @arianvp. I need to read through those docs to better understand what is involved.

This would mean you'd still run into expiring credential problems.

As long as I can handle the expiration and renewal via k8s APIs then it should be fine. The expiration problem I ran into required either have gcloud installed in the operator image or making calls to GCP APIs. We would likely have to do something similar for each cloud provider.

The KEP mentions this about expiration:

A volume plugin implemented in the kubelet will project a service account token sourced from the TokenRequest API into volumes created from ProjectedVolumeSources. As the token approaches expiration, the kubelet volume plugin will proactively rotate the service account token. The kubelet will start trying to rotate the token if the token is older than 80 percent of its time to live or if the token is older than 24 hours.

It looks like there is a mechanism to handle expiration, but this wouldn't apply to our use case of using the token out of cluster. We will need to sync the tokens, but I don't know that using the k8s api is the best way to do that. If for some reason the token does expire before it can be synced then we might be stuck in a bad state.


I use your bodyPix to create realtime background removal

Mimic Zoom virtual background feature. Thanks for awesome tfjs
https://github.com/james4388/webcam-background-removal

Nice! Would be great if you had a browser demo too ;-) Probably would get more people sharing it then too. Just a suggestion. Keep up the great work and thanks for letting me know! If you are on social media feel free to post a video / GIF using #madeWithTFJS so our team can find it!


Cannot close the connection dialog when connecting to a Azure db with wrong password

Login to Azure with a valid account. (and some existing SQL dbs)
from the viewlet, clinet on a SQL DB to connect to (it's possible I had old password for that db stored in my machine)
the connection dialog opens with "login failed' error and to get the correct  password
entering the wrong password shows the same error. I didn't have the correct password so I canot say it will connect correcly
try to close the dialog by clicking on the "Cancel" button

Expected: the dialog should close
Actual: I keep getting the connection error dialog and I cannot close the connection dialog

@aaomidi Maybe https://github.com/microsoft/azuredatastudio/commit/5da0e16e440a3991cc2caac6cd68697ac8985d52 broke this? Not sure what the behavior was before, could you check to see if it's related?

I have verified that this was fixed. The same issue was tracked here - https://github.com/microsoft/azuredatastudio/issues/7051 and it was fixed by https://github.com/microsoft/azuredatastudio/pull/7711


clang compilation warning suggests bug

sparsebundlefs.cpp:298:27: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]     if (fd_limit.rlim_cur < 0)
There are some other clang warnings, but this one suggests a bug

Nice catch! I'll have a look

Fixed in f3ccd20


New #each format

Great work, thanks a bunch.
It would be really nice to have the new {{#each}} syntax available:
{{#each items as |item|}}

{{/each}}

Working fine, never mind.

:)


Consolidate microstructure and macrostructure into structure

The Adapter API provides macrostrucutre() and microstructure() as two separate methods that contribute information to the structure key in the HTTP API. The original motivation was to avoid doing extra work in cases where only need one more the other.

It turns out these cases are very rare.
Delaying evaluation does not safe much work anyway.
The distinction between which does where does not hold up in all cases.
The has made the code that constructs HTTP responses unnecessarily complex.

Discussed on a call with @tacaswell, who agreed with the plan to consolidate these methods into one. If we want to select less information, we can always add an optional parameter to structure to make it return less.


Cannot set dynamic values to ClassApplier properties

I tried to assign a variable and a function returning a string to the elementProperties and it doesn't work. When setting attempting to use a function it sets the function definition in string format o_O and setting a variable does nothing when its clearly got a value
highlighter.addClassApplier(
      rangy.createClassApplier('note', {
        ignoreWhiteSpace: true,
        elementTagName: 'a',
        elementProperties: {
          href: '#',
          title: noteText,
        },
      })
    );

https://github.com/timdown/rangy/blob/1e55169d2e4d1d9458c2a87119addf47a8265276/src/modules/rangy-classapplier.js#L557
issue with this line. forces whatever is passed to turn into a string. Wouldn't it be better to just check if the value or whatever is passed is a string instead of doing this


Avoid closure in s.starts_with();

Post-merge nit for a follow-up PR: s.starts_with(char::is_uppercase);
Originally posted by @dr-orlovsky in https://github.com/rust-bitcoin/rust-bitcoin/pull/768#discussion_r784684641
Note: there's a clippy lint for this.

Closed by #784


Uninstall possible for logged users only.

Addressing https://github.com/IntelAI/inference-model-manager/issues/78
As we want only authenticated users to be able to uninstall the platform, whole removal process should be stopped if user does not have a valid token. Uninstall shall be fully completed or not begin in the first place.

+1


Patroneos to return server error response code if nodeos is down

Describe the bug
Currently patroneos returns HTTP 200 response and empty content even if nodeos is down and not responding. Appropriate solution will be to return some internal server error if cannot connect to nodeos. This will make it easier for detecting if a particular node is down.

This has been resolved with PR #32. I will be creating a v1.0.2.rc.2 release as soon as the fixes are merged.

Great. Works well!


AutoScalingGroup CreationPolicy doesnt error

CloudFormation Lint Version
v1.10.1
What operating system are you using?
windows
Describe the bug
in the example template, i have a reference to ResourceSignalCount. There isnt a parameter for this but does not throw an error
Expected behavior
an error is thrown
Reproduction template
AWSTemplateFormatVersion: 2010-09-09

Resources:
  AutoScalingGroup:
    Type: AWS::AutoScaling::AutoScalingGroup
    CreationPolicy:
      ResourceSignal:
        Count: !Ref ResourceSignalCount
        Timeout: PT15M
    Properties:
      MaxSize: 1
      MinSize: 1

Some notes for adding support:

Creation policies are ignored for resources that don't support them (this could be a Warning)

Other fixes:

One of LaunchTemplate, LaunchConfigurationName, InstanceId or MixedInstancesPolicy is required for AWS::AutoScaling::AutoScalingGroup
At least one Availability Zone or VPC Subnet is required for AWS::AutoScaling::AutoScalingGroup


Roll engine

@tvolkert

LGTM

This resolved the memory regressions in https://github.com/flutter/flutter/issues/8429.


InvalidOperationException while accessing ActionDescriptor's Properties

Hi,
It seems that in some point ApiVersionActionSelector tries to get ActionDescriptor's Properties while those properties are written.
System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
at Microsoft.AspNetCore.Mvc.Abstractions.ActionDescriptorExtensions.GetProperty[T](ActionDescriptor actionDescriptor)
at Microsoft.AspNetCore.Mvc.Versioning.ApiVersionActionSelector.<>c.<MatchVersionNeutralActions>b__19_0(ActionDescriptor action)
at System.Linq.Enumerable.SelectArrayIterator`2.MoveNext()
at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
at Microsoft.AspNetCore.Mvc.Versioning.ApiVersionActionSelector.SelectBestActions(ActionSelectionContext context)
at Microsoft.AspNetCore.Mvc.Versioning.ApiVersionActionSelector.SelectBestCandidate(RouteContext context, IReadOnlyList`1 candidates)
at Microsoft.AspNetCore.Mvc.Internal.MvcAttributeRouteHandler.RouteAsync(RouteContext context)
at Microsoft.AspNetCore.Routing.Tree.TreeRouter.RouteAsync(RouteContext context)
at Microsoft.AspNetCore.Routing.RouteCollection.RouteAsync(RouteContext context)
at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)

Version tested:  2.3.0
How to reproduce:
This is tricky, it doesn't failed often but sometimes when you perform many request when the app is actually starting - you can see this exception.

Hmm... this shouldn't be happening. The read operation is supposed to be safe. I've since something like this months ago where the dictionary was being mutated at runtime, but things have since been refactored to ensure that doesn't happen. My understanding is that reading from a dictionary should always be safe and not cause this.
Thanks for the stack trace. This pins things down to exactly where it happened. I'll investigate and follow back up.

I've cleaned up everything and rebuild again against newest version of the lib. I cannot reproduce this issue so far. I suspect the library update was not successful and I've had built against v2.0.0 then.
I'll be checking it further for a while...

I looked into this more - just to be sure. You definitely could have hit this in earlier releases. Based on the history from mainly #311, but also #306 and #248, I believe you have hit an issue that has been solved. It only happened non-deterministically and primarily only while hosting on Kestrel. There was an internal discussion and review on this issue, which has not since come up again.
At the end of the day, API versioning should not be performing any write operations on shared data such as an ActionDescription. Everything is now pre-computed so that never happens. All Read operations are supposed to be safe. Based on the stack trace, this looks very, very similar to #311. It's unfortunate that it took so long to find this issue as it only occasionally happens and manifests differently at runtime.
If you feel comfortable that you've cleaned up and updated your references, I think we can close this one out. I'm happy to reopen the issue or investigate further if you see something else pop up.
Thanks


Localized names and composite icons

Added localized name generation. It pulls the localization from the original source, so the effort on your end is minimal. I did add a suffix in the name to mark them, which is the only thing that needs to be localized on the mods end.
Instead of replacing the icons it now paints the ghost sprite in the upper right corner.

Both changes should improve the look and feel of the mod. I did not add a changelog entry or bumb the version. If you have any questions you contact me either here or via discord under Soggs#4093. I am on the Factorio discord. So you can just ping me in the mod-making channel.

My first PR nice. Thanks for the PR
I'll have do some testing to see if everything works but otherwise I'll merge it and release it as an update. The only thing left to do regarding locales is to also move the descriptions for settings into locale files, but that can happen later.


Display waveform for pre-recorded audio file.

Consider an use-case where the audio file already exist and the user wants to load it to the plugin and display the waveform without actually recording the audio.
Does the plugin already has this feature? If not, it would be great to implement this feature because there might be scenarios where user do not want to record the audio in real-time but display the waveform for pre-recorded audio.
If above said feature is implemented then it makes sense to also implement the onLoad audio event.

Hello. This has been implemented in the new release. You can find its details here: https://github.com/AbreezaSaleem/react-voice-recorder-player/releases/tag/v1.2.0


Fix merging of interface types with concrete values

@admtnnr Thanks for the PR. Can you describe a bit more why is this needed (which use cases, …) ?

@vdemeester sure, here's the case I ran into:
Say we have an interface:
type Doer interface {
  Do() error
}

And we have two implementations of that interface:
type NoopDoer string
func (d NoopDoer) Do() error { return nil }

type RealDoer struct { ... }
func (d RealDoer) Do() error {
  ...
  return nil
}

And we have our config struct like so:
type config struct {
   Doer Doer
}

And we set up a "default" config that we will merge in that uses the NoopDoer we defined above:
var defaultConfig = config{
  Doer: NoopDoer("this does nothing"),
}

What I've encountered is that the call to mergo.Merge fails if you have a setup where you pass in a config that also has a Doer defined that should take precedence, but is a different concrete type.
So something like this will return an error and panic where it shouldn't since the config should accept any implementation of a Doer:
var myConfig = config{
  Doer: RealDoer{},
}
if err := mergo.Merge(&myConfig, defaultConfig); err != nil {
   panic("THIS WILL GET RUN")
}

So what actually seems to happen is that mergo doesn't check that the types are actually assignable to the field in the struct, but rather just checks that the source and destination types are the same.
It skips through this case since the underlying types aren't the same: https://github.com/imdario/mergo/pull/106/files#diff-a103b5fee5fb31abebf12ee067c01da8R190 and instead hits this line: https://github.com/imdario/mergo/pull/106/files#diff-a103b5fee5fb31abebf12ee067c01da8R195
The test I added will fail if the check for AssignableTo is removed even though both types implement http.Handler.
Hopefully that helps explain it a little better. It's a weird case, I'll give you that. :)

So what actually seems to happen is that mergo doesn't check that the types are actually assignable to the field in the struct, but rather just checks that the source and destination types are the same.

@admtnnr indeed :sweat_smile:

@admtnnr btw can you rebase against master to fix the CI ? :angel:

@vdemeester Rebased.

@vdemeester let me know if there's anything else you need from me to get this merged. :)


Request to add regex pattern matching VLAN network interfaces

Hello,
In cmd/scollector/collectors/ifstat_linux.go, the regular expression ifstatRE matches physical interfaces and bonded virtual interfaces. However, it does not match tagged VLAN interfaces which have a suffix formed by a dot followed by the numeric VLAN ID, such as "eth0.1234" or even "bond0.1234". I suggest adding "(\.\d{1,4})?" before the ":".
You may also want to add a vlan_string = ".vlan" similar to bond_string but I don't know what was the discussion that lead to the creation of bond_string and if the logic also applies to VLAN interfaces (and what about VLANs tagged on a bond interface?).
Unfortunately I don't code in Go yet.
Thank you!

Ooh! I just found out the regex can be overridden with the IfaceExpr configuration parameter.

IfaceExpr (string): Replaces the default regular expression for interface name matching on Linux.
source: https://godoc.org/bosun.org/cmd/scollector

# /opt/scollector/scollector.toml
…
IfaceExpr = '\s*(?:eth\d+|em\d+_\d+/\d+|em\d+_\d+|em\d+|bond\d+|team\d+|p\d+p\d+_\d+/\d+|p\d+p\d+_\d+|p\d+p\d+)(?:\.\d{1,4})?'
…

It's important to use non-capturing match groups (?:…) because match group indexes matter later in the code.


Divide some pages in sections?

Maybe dividing the pages tutorials, courses or videos would make the sections clearer? E.g. in general/web3 intro resources and development-related pages.
It looks like they are getting long and (at least for me) it takes time to load the resources.

It's definitely getting a lot, and probably starting to become less useful this way.
Too long of a list and not sure where to get started.
It hasn't been a priority for me yet, but I'd love to do an overhaul of useWeb3 and making sure its more useful.
Any ideas or suggestions on how to structure it better?

It looks like the pages "tutorials", "courses" and "videos" are the longest ones. Maye split them via topic in sections or two pages each?
Courses could be split in coding or web3 in general. Videos and tutorials maybe accoding to the topic or level (beginner / intermediate).
I'm happy to categorize if needed. Not a super important issue though (-:


ngRedux.subscribe will throw error if store is not configured yet

Subscribing to the store with the ngRedux.subscribe method will fail if the store is not configured yet (since the _store is not set yet).
Since there is a behaviorsubject keeping track of the store (_store$), we could subscribe to it and bind the listener once the store is configured. The only problem is unsubscribing from the store is broken.
subscribe = (listener: () => void) => {
    if (!this._store) {
        const subscription = this._store$.subscribe(store => {
            if (store) {
                store.subscribe(listener);

                subscription.unsubscribe();
            }
        });

        // need to return the store subscription here somehow
    }

    return this._store.subscribe(listener);
};

Do you see any solutions or is it an option to expose the _store$ so I can subscribe manually?
Some context:
I'm writing a localstorage module that syncs the state to the browser storage. I wrapped this in an enhancer that takes some selectors (much like the selectors in this module) and subscribes to store change events to update the storage. Since the enhancer is triggered before the configureStore is executed, it crashes when trying to subscribe to the _store.
Right now, I'm checking wether _store is defined and subscribe to _store$ to delay my subscription so it won't throw an error. But I'd rather not be accessing any private properties.
Maybe there is a better solution?

Sorry for the delay on this.
A couple of notes:

you can get access to _store$ using select with no params (e.g. ngRedux.select()). This will give you an Observable of the entire root state.
ngRedux.subscribe and ngRedux.select().subscribe are subtly different.

ngRedux.subscribe calls straight through to Redux's store.subscribe, which manipulates Redux's internal set of listener functions.
ngRedux.select().subscribe actually calls Observable.subscribe() on the Observable returned by select.

Not 100% sure what your enhancer does, but I think what you want to do is
ngRedux.select().subscribe(
  successHandler,
  errorHandler,
  completionHandler)

It's also worth noting that there are a few existing redux enhancers/middlewares that sync to localstorage already.  redux-localstorage is a decent example.

The enhancer syncs the localstorage and the state, and allows specifying specific paths to sync using the same syntax this package uses. I would show some code but it's not open source (might rebuild it as a proper plugin and opensource it someday).
I was able to do it by subscribing to ngRedux.select() with a filter and first to assure the store is there, thanks for the tip!

Cool, glad it helped.


Class for database access

Hello.
I want to create class, which would handle database connection and have a public atribute ResultSet.
Something like this:
#include "ocilib.hpp"
#include <string>
#include <iostream>

using namespace ocilib;

class Dao
{
private:

	Connection* con;
	Statement* st;

public:
	Resultset* rs;
	Dao(std::string sqlQuery);
	~Dao();

};

and realisation of class:
#include "Dao.h"

Dao::Dao(std::string sql_query)
{
	try
	{
		Environment::Initialize();
		con = new Connection("rfinfot1", "broker", "broker");
		st = new Statement(*con);
		st->Execute(sql_query.c_str());
		*rs = st->GetResultset();
	}
	catch (std::exception& ex)
	{
		std::cout << ex.what() << std::endl;
	}
}

Dao::~Dao()
{
	Environment::Cleanup();
}

But I got exception when I do '*rs = st->GetResultset();'.
I think that there is a problem in my architecture solution. Can you help me with right architecture for my goal?

Hi,

Environment::initialize() and Environment::Finalize() should be called only once per application life-time
Resulsets are owned by Statements and deallocated every time their origin statement are re-prepared
You cannot "store" a "smart reference" on a resultset (which what a ocilib::Resultset object is) but you can store a "smart reference" on a statement if you do keep trace of its connection (as statements are children objects of connections)

ocilib C++ objects are "smart reference" on handles from its C API.  You don't need to allocate them using new. Instead you can just assign them.
What you can do is:
#include "ocilib.hpp"
#include <string>
#include <iostream>

using namespace ocilib;

class Dao
{
private:

	Connection con;
	Statement st;

public:
	Dao(std::string sqlQuery);
        Resultset Result();
	~Dao();
};

and realisation of class:
#include "Dao.h"

static std::atomic<bool> ocilibInitialized;

Dao::Dao(std::string sql_query)
{
	try
	{
		if (!ocilibInitialized)
                {
                     // quick and dirty code as there is possible race condition on the guard
                     ocilibInitialized = true;
                     Environment::Initialize();
                }

		con = connection("rfinfot1", "broker", "broker");
		st = Statement(con);
		s.Execute(sql_query);
	}
	catch (std::exception& ex)
	{
		std::cout << ex.what() << std::endl;
	}
}

Resultset Dao::Result()
{
    return st.GetResultset();
}

Dao::~Dao()
{
	if (ocilibInitialized)
        {
             Environment::Cleanup();
        }
}
`

Regards,

Vincent

Thank you!


allow setting default language which doesn't require url component

Hi,
For a recent project I was working on using the LangInPathMiddleware the client required that pages in the default language not have the language code added. This simple patch enables that so thought I'd offer it upstream incase you might be interested

This looks good. I just had a couple nitpicks.
I also wanted to mention that Django 1.4 adds support for this lang-prefixing functionality, so you might want to check it out and see how hard it would be to get this behaviour working there.

After using this a bit more I've discovered that this change introduces an annoying problem when the user's preferred language as indicated via browser settings doesn't match settings.TRANSURLVANIA_DEFAULT_LANG.
LangInPathMiddleware.process_request sets the request language if the url prefix matches one of the available language codes but if we allow special cases where there is no language code then the language_code will be set on the normal django heuristics. If django determines the current language to be, say, en-us whereas TRANSURLVANIA_DEFAULT_LANG is en-gb all urls will 404 as the urlresolver will have been primed with en-gb as the prefix.
For our project a simple enough workaround was to modify the middleware as well so that if it can't guess the language based on the url then it just forces it to be TRANSURLVANIA_DEFAULT_URL but all in all I am not too happy with this solution and so think you should just disregard this pull request


Version up to v1.6.3

Description
Please include a summary of the change and which is fixed.

release preparation
"TODO" was skipped beceuse the grand refactoring was postponed

How has this been tested?
Please describe the tests that you ran to verify your changes.

[x] UnitTest
[x] Benchmark

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.48%. Comparing base (04ff22a) to head (4478f31).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   90.45%   90.48%   +0.03%
==========================================
  Files         128      129       +1
  Lines        4430     4447      +17
  Branches      714      716       +2
==========================================
+ Hits         4007     4024      +17
  Misses        278      278
  Partials      145      145

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

temporally close to try fix CI issue
Version 3.9 was not found in the local cache


chore(deps): bump https://github.com/salaboy/fmtok8s-api-gateway from 0.0.99 to 0.0.100

Update salaboy/fmtok8s-api-gateway from 0.0.99 to 0.0.100
Command run was jx step create pr chart --name fmtok8s-api-gateway --version 0.0.100 --repo https://github.com/salaboy/fmtok8s-springone-app.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign salaboy
You can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow suppression of console output

Hi. Sorry for late response.
It seems that both output and output_schema has been modified but only output is tested. Personally I would mock out the log_json and check that it's called correctly with correct values. https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_with
Also I would check that if it's written to console or not. e.g. https://stackoverflow.com/a/61533524/1271400

Thank you for your feedback and for pointing me in the right direction regarding mocks.

@kivipe Starts to look good! One more comment from my side and then LGTM.
@Atihinen Any comments from you?

@asimell  not from my side. Yeah to fix that not needed variable and we should be good to go with merge unless GHA finds something. 🙂

Thank you for your review. Variable self.output_schema_console was not used because somehow my output_schema tests were missing. I added output_schema tests into a new class so the purpose would be clearer. I rewrote init to avoid code duplication.


Run CI for every PR

I get the same error on my machine:

Thank you @OskarStark

Any clue why the tests are failing ?

Symfony is facing the same issue:


Add the MeshSync page in spanish

Signed-off-by: Christian Alexis Castro Guerrero<EMAIL_ADDRESS>Description
This PR fixes #4352
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 7bb5fdc8bac97f017e77d83534633202cb3b8db3 at: https://6161fdeb367fbb909a585cc5--meshery-docs-preview.netlify.app

The es/concepts/architecture/meshsync looks very good! well Done!
but, you edited the ENGLISH INDEX docs/page/index.md, instead of editing the docs/page/es/index.md page.
The spanish pages must be shown only in the docs/page/es/index.md page.
Just correct this and expect the approval 👍🏼

🚀 Preview for commit 668bf406a2a93b77e8640806dc649ed4d0aef925 at: https://616229f23311c3fc7d34030e--meshery-docs-preview.netlify.app

🚀 Preview for commit ff8eab9179858e08ff0681cc82f0fc9a1a305f99 at: https://61622e67a3152019752a46f0--meshery-docs-preview.netlify.app


syntax error in dbcreate.sql

I have downloaded the dbcreate.sql from here
when i tried to run \i dbcreate.sql i am getting syntax errors
(rasa_ui) [postgres@Hydidc-VoiceBOT-Srv1 ~]$ psql
psql (9.2.24)
Type "help" for help.
postgres=# \c rasaui
You are now connected to database "rasaui" as user "postgres".
rasaui=# \i dbcreate.sql
psql:dbcreate.sql:1: ERROR:  syntax error at or near "NOT"
LINE 1: CREATE SCHEMA IF NOT EXISTS "rasa_ui";
^
psql:dbcreate.sql:3: ERROR:  schema "rasa_ui" does not exist
psql:dbcreate.sql:5: ERROR:  syntax error at or near ":"
LINE 1: GRANT ALL ON SCHEMA "rasa_ui" TO :postgres_user;
^
psql:dbcreate.sql:6: ERROR:  schema "rasa_ui" does not exist
DO
SET
psql:dbcreate.sql:23: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:30: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:37: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:44: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:51: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:58: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:65: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:72: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:79: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:86: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:93: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:100: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:107: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:114: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:121: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:128: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:135: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:142: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:149: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:156: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:163: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:187: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:201: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:218: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:233: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:248: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:258: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:272: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:283: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:296: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:315: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:328: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:346: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:367: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:386: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:403: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:418: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:436: ERROR:  no schema has been selected to create in
psql:dbcreate.sql:443: ERROR:  relation "intents" does not exist
LINE 3: ...ts.agent_name, grouped_intents.grp_intent_count from intents
^
psql:dbcreate.sql:450: ERROR:  relation "nlu_parse_log" does not exist
LINE 3: ...g."timestamp", 'MM/DD'::text)) as month_date from nlu_parse_...
^
psql:dbcreate.sql:457: ERROR:  relation "nlu_parse_log" does not exist
LINE 3: ...g."timestamp", 'MM/DD'::text)) as month_date from nlu_parse_...
^
psql:dbcreate.sql:462: ERROR:  relation "nlu_parse_log" does not exist
LINE 3: ..."timestamp", 'MM/YYYY'::text)) as month_year from nlu_parse_...
^
psql:dbcreate.sql:469: ERROR:  relation "nlu_parse_log" does not exist
LINE 3: ...g."timestamp", 'MM/DD'::text)) as month_date from nlu_parse_...
^
psql:dbcreate.sql:483: ERROR:  relation "parameters" does not exist
LINE 11: FROM parameters
^
psql:dbcreate.sql:488: ERROR:  relation "nlu_log" does not exist
LINE 3: FROM nlu_log
^
psql:dbcreate.sql:492: ERROR:  relation "nlu_log" does not exist
LINE 3: FROM nlu_log;
^
psql:dbcreate.sql:500: ERROR:  relation "entities" does not exist
LINE 4: FROM entities
^
psql:dbcreate.sql:508: ERROR:  relation "nlu_log" does not exist
LINE 4: FROM nlu_log
^
psql:dbcreate.sql:519: ERROR:  relation "messages" does not exist
LINE 6: FROM messages AS msg
^
psql:dbcreate.sql:535: ERROR:  relation "messages" does not exist
LINE 8: FROM messages AS msg
^
psql:dbcreate.sql:537: ERROR:  syntax error at or near ":"
LINE 1: ...ALL PRIVILEGES ON ALL TABLES IN SCHEMA rasa_ui TO :postgres_...
^
psql:dbcreate.sql:538: ERROR:  syntax error at or near ":"
LINE 1: ... PRIVILEGES ON ALL SEQUENCES IN SCHEMA rasa_ui TO :postgres_...
^
psql:dbcreate.sql:541: ERROR:  relation "response_type" does not exist
LINE 2: INSERT INTO response_type (response_type_text) VALUES ('DEFA...
^
psql:dbcreate.sql:542: ERROR:  relation "settings" does not exist
LINE 1: INSERT INTO settings (setting_name,setting_value) VALUES ('r...
^
rasaui=#

Hi @Stolaine,
I replaced all occurances of :postgres_user in the sql Script with the username of the database.
I followed the install guide. However, I am using Mac OS.
Hope it helps.

You need to update PostgreSQL. Early versions do not support CREATE SCHEMA IF NOT EXISTS command


Multiple databases

Consider there is a model like this:
class DifferentStorage::Base < ActiveRecord::Base
  establish_connection(YAML.load(File.read('config/database.yml')))["different_storage_#{Rails.env}"])

  self.abstract_class = true
end

Expected Behavior
I expect that read queries for that model will be executed against different database (not master or slave). As well as for all child models.
Actual Behavior
Read queries for that model are executed on slave database, which does not contain these models.
Update/delete queries are executed against right database, which constains these models.

Do you have a plan to support models which are stored in different database?

Currently this gem does everything we need from need it in production. Supporting other databases would be a great idea. I will gladly accept a pull request if you add this capability.

:ok_hand:  I will make a PR

FYI Rails 6 will support database replicas out of the box https://github.com/rails/rails/pull/34052

I'm not going to make a PR. Sorry.
If you use mysql/mariadb you can look at temporary workaround in https://github.com/mainameiz/active_record_slave/pull/1 (until upgrade to Rails 6).


chore(gcp): remove unused code

Signed-off-by: Jorge Turrado<EMAIL_ADDRESS>This code is not used anywhere, doesn't make sense to keep it for nothing
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

/run-e2e gcp*

/run-e2e gcp*


Add support to select named inserts for output message object

This pull request enhances the getMessage function to allow a dataNamedInsertsPattern value (which is a regular expression) to be supplied in the incoming message object which is used to select namedInserts keys to be built into the output message object under data.
For example, if you have message.namedInserts with
{
  "user.key": "userValue",
  "otherKey": "otherValue"
}

and supply a dataNamedInsertsPattern value of ^(user\\.) then you would get
{
  "user.key": "userValue"
}

in message.data.
This allows a user to selectively include some of the namedInserts values in the output, separate from including the whole namedInserts block depending on whether verbose is set to true or false

Coverage remained the same at 100.0% when pulling 3fe0429b0f2fc86d2cdb9d1d6f8e2c0f00526574 on mattbaileyuk:named-inserts-pattern into 2a866bbd57c6fa6b410d242ff862022ce2397c53 on IBM:master.

LGTM - quick work @mattbaileyuk :)

Merging. More changes to follow before we publish a  new version


Refactor API object fuzzer

API object fuzzer is used to randomly populate API object for testing. Similar
code of the fuzzer was duplicated in multiple files. This change refactors the
tests and moves the fuzzer to a separate file.
This closes #3691.

LGTM - I did not realize these were literally identical.  Sigh.
Travis failed, but I am not sure why - does this pass 'make test' and integration test?

Waiting for green

I ran make test before and after the new patch; both times passed. By integration test, did you mean hack/test-integration.sh? I tried running with a clean repo but it kept failing. I have yet to figure out why it isn't working :-(

integration is failing?  That's not good.  We'll see what Travis says..

hmm, no link to Travis and Shippable failed.  @brendandburns did we finally put travis out of our misery?

How can I view the shippable results?

Closed it by accident. Reopening it.

Shippable says:
docs/kubectl.md is out of date. Please run /home/shippable/workspace/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/bin/linux/amd64/gendocs > docs/kubectl.md

Travis says the same

Travis wants to add all the --test.xx options in the doc. @jlowdermilk pointed out that it could be caused by importing testing in fuzzer.go, which is in a main package (api).
I moved fuzzer to a separate package (api/testing) to bypass this issue.

LGTM - Travis is green.  I'm on a plane early tomorrow so on-call can commit this.  That looks like @satnam6502

I'll merge this tomorrow early morning unless it needs to go in urgently (which I sense it does not).

Not urgent.
On Thu, Jan 29, 2015 at 9:37 PM, Satnam Singh<EMAIL_ADDRESS>wrote:

I'll merge this tomorrow early morning unless it needs to go in urgently
(which I sense it does not).
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/3917#issuecomment-72156648
.


Memory snapshots

Hello,
This pull request adds new option ENABLE_MEMORY_SNAPSHOTS to collect memory allocation statistics. It's aimed for developers that want to profile OpenCV memory usage and spot enormous memory usage and too often re-allocations.
This pull request was inspired by a small hack that I did recently to eliminate memory-crash on iOS platform which happened due to big memory usage in OpenCV. With this feature it was very easy to detect and fix a problem.
A more information on this feature can be found on my blog: Hacking OpenCV for fun and profit.

looks like this is abandoned PR. Let's close it. @BloodAxe, please, feel free to reopen it when you are ready.

@vpisarev, perhaps you are right. Currently this PR uses C++11 features which no available for GCC (or it require to edit compiler flags). I will keep it locally for my needs and if someday OpenCV will switch to C++11 on all platforms I reopen it.


chore: handle non-iterable arrays in test environment

Summary
Fixes #3879. I absolutely hate this solution. Maybe we should figure out a plan which allows us to run the test environment outside of the user sandbox? Would allow us to ditch the babel plugin, which is turning into a monster

Test plan
The test that was never run will now run, and hopefully pass

Doesn't even work :(
Seems I gave up last time: #4630. And the test is purposefully ignored

Maybe we should figure out a plan which allows us to run the test environment outside of the user sandbox?

Totally. We've had other issues related to this and running the runner code in a different environment and then just share its globals with the test environment would probably solve them all.

@aaronabramov tried that in #3880, not sure why he aborted the attempt? Some side channel talk with @cpojer perhaps? I think @mjesun attempted it at some point as well.
I'll write it down for the summit in a few weeks, maybe we can figure out a way forward then

The information I had was that jest-circus will fix all of these, by properly running each thing in the right place.

jest-circus runs inside of the sandbox: https://github.com/facebook/jest/blob/5d2d46f1597e2880aeca4126947d7390cc6ff827/packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts#L27


Release a new version of CESSDA Documentation Theme (Gem v0.1.10)

After the feedback mechanism, we need to release the stable version to the Gem Repository.
https://rubygems.org/gems/jekyll-cessda-docs

[ ] Update Checklist


Remove list of OpenSource repos

This PR removes the list of repositories that are configured to use the OpenSource user feedback experience. We shouldn't publish a list like this for the following reasons:

The current list is out of date and it's too hard to maintain the list.
The configuration is at the docset level not the repo level. A repo can have multiple docsets.
Within a docset, you can limit the OpenSource to specific folders. For example, the dotnet/docs repo uses Standard feedback for some folders and OpenSource for others.
The customer doesn't know or care about which repos are configured. They only know what they see on the web page.
If the OpenSource feedback control exists on the bottom of the page, then the user can use it. If its not there, then they can't. Knowing the repo name is not helpful.

#sign-off


theme-classic(v2): fonts do not render the same way across browsers

🐛 Bug Report
I'm not sure if I should put this as a bug, feel free to update.
The fonts do not render the same way in Firefox and Chrome (the only browsers I've tried).
It is particularly obvious in the sidebar and when overriding the title font, like in my case:

Everything is a little heavier on FF. I personally prefer the lighter font-weight we see in Chrome, I'm not sure which version is the orignal intent.
Have you read the Contributing Guidelines on issues?
Yes
Expected behavior
The fonts should be closer in weight across browsers.
Your Environment
Chrome: 88.0
FF: 86.0

Indeed, now we have such inconsistency in fonts. But that's because we don't specify the same font anywhere but we are relying on system font stack (see https://systemfontstack.com/ or https://www.digitalocean.com/community/tutorials/css-system-font-stack for more details).
As I understand it, many CSS frameworks follow this pattern, so we done same. If you don't like it, you can override CSS variable ifm-font-family-base.


Check for LF trademark footer for all CNCF project website

This should be in the Legal category
All project sites should have this footer
e.g., https://prometheus.io/
" @ 2022 The Linux Foundation. All rights reserved. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our Trademark Usage page."
For now I think the check can be simple and simply just look for this URL: https://www.linuxfoundation.org/trademark-usage

Does this check cover the TRADEMARKS check requested in #33 or this is independent of the trademark transfer to the foundation?

The TRADEMARKS file should be independent, we don't really use that much at
all right now but will probably change that
The footer on the website is widely used and needs to be checked for on the
website
On Mon, Feb 28, 2022 at 8:21 AM Sergio C. Arteaga @.***>
wrote:

Does this check cover the TRADEMARKS check requested in #33
https://github.com/cncf/clomonitor/issues/33 or this is independent of
the trademark transfer to the foundation?
—
Reply to this email directly, view it on GitHub
https://github.com/cncf/clomonitor/issues/73#issuecomment-1054305620,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSIJ64RVPBEGDZKLMNTTU5OAFFANCNFSM5OSNK2ZQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Cheers,
Chris Aniszczyk
https://aniszczyk.org

We've added temporarily this check to the best practices section as we are doing some design changes to accommodate the new Legal category. We'll move it to the new one as soon as it's ready.
(project card possible new look with 5 rows instead of 2 rows and 2 columns)


updated fsociety.py code to python3

The code was somewhat in between python2 and python3 making it unuseable for both the language versions...updated the code to python3 to make it somewhat useable

This version of FSOCIETY is for python2!!!!!!!!!!!! We have already done the py3 conversion wayyyyyyy better and more stable. PR will be denied - go download the new version here

Hi, this version only supports Python 2. For Python 3 please see fsociety-team/fsociety


Update macOS.gitignore

Clarified purpose of ._* files. See https://lists.apple.com/archives/applescript-users/2006/Jun/msg00180.html
Reasons for making this change:
Clarified purpose of ._* files
Links to documentation supporting these rule changes:
https://lists.apple.com/archives/applescript-users/2006/Jun/msg00180.html

@DKroot I can't take this in due to the line ending changes - I managed to accidentally break this a while ago and someone else noticed it. Apologies!


bgpv1: component test framework

Introducing bgp control plane component tests. This change introduces test harness and basic BGP tests related to podCIDR advertisements, lb service advertisements and neighbor events.
Motivation of this change
Increase test coverage around boundaries of subcomponents

For eg, we do not test complete flow of change from getting Kubernetes event and then validating that it is reflected in the peering router.
Unit tests today exists for
-- Controller : This is limited to that policy change calls correct reconciler methods.
-- Reconcilers : Tests validate the diffs are generated correctly and we are inspecting gobgp directly for validation. Direct inspection of gobgp might not be suitable here in long term, if another underlying routing agent is used.

Validate and make BGP Peering part of CI testing.

This is mainly for neighbour configuration : like timers, graceful restart, authentication etc. And later on for more advanced BGP as well ( Routing policies and filters )
During new feature development, we have to validate the expected behaviour and add tests for it. It is currently not possible with unit tests, as we only configure local gobgp and we have to validate the behaviour separately via container labs to test actual peering behaviour. Which is again not coded anywhere and we do not repeat those manual tests as we continue to modify the code ( I would say this is the biggest reason ).
Also having this tests as part of CI, will ensure that there are no regressions introduced to feature behavior as we make changes.

Types of test cases to add
This component level test is mainly cover high level BGP features
So, what I see following tests need to be added

Pod CIDR advertisements
LB Service advertisements
Neighbor behavior
-- Authentication
-- Timers
-- Graceful restart
Some special test cases
-- Restarts
-- Any customer reported bugs and issues with order of operations.

/test

/test


Latest update introduced intermitent bug

Describe the bug
Latest release has introduced a bug with camera sometimes not showing, and the person, car and pet detection, its there but on odd occation they are unavailable.
I have rolled back to previous release and issue dissapears.
To Reproduce

Both cameras show up with this amount of the sensors being unavailible, its regular and evenly spaced out
Expected behavior
not for sensors to go unavailible ever 20 to 30 mins
Screenshots

latest update

after rollback to previous release.
Environment:
Please provide useful information about your environment, like:

Home Assistant version:  2022.8.7 Hass OS, supervisor and OS kept upto date as well
Reolink camera model : it happens to both so I dont think its specific
Camera firmware number
RLC-822A - v<IP_ADDRESS>6_22041507
RLC-811A - v<IP_ADDRESS>6_22042008

Additional context
Rollback fixes the issue and it only appeared in recent update.

I see the same kind of behaviour with my RLC-810A. Firmware numbers for both V1 and V2 are v3.1+.

I'm experiencing the same issue.
RLC-812A
IPC_523B188MP
v<IP_ADDRESS>0_22040613
HA Core: 2022.11.4
HA OS: 9.3


specify map size

Please provide a description of this PR:
specify map size for better performance.

Hi @wulianglongrd. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test


Trying to get a CentOS Brave container to run on Kubuntu 20.10, but its throwing an issue?

Hello,
So I was introduced to Brave by the reddit user /u/bering_team in this thread: https://www.reddit.com/r/LXD/comments/l7lpvi/i_was_suggested_to_check_out_lxd_since_i_used_a/gmk84cs/
So far he has helped me in installing and creating a Bravefile, however when I try to deploy I get an error
So if I run brave deploy I get:
si@linux:~/Documents/Brave-LXD/CentOS-7$ brave deploy
2021/02/10 00:59:58 Unit centos already exists on host

If I run brave units I get this:
si@linux:~/Documents/Brave-LXD/CentOS-7$ brave units
NAME    STATUS  IPV4    VOLUMES PORTS
centos  Stopped

So I run brave start centos and I get this:
si@linux:~/Documents/Brave-LXD/CentOS-7$ brave start centos
Starting unit: centos2021/02/10 01:04:42 Failed to start unit: Failed to run: /snap/lxd/current/bin/lxd forkstart centos /var/snap/lxd/common/lxd/containers /var/snap/lxd/common/lxd/logs/centos/lxc.conf:

And finally I get this if I run lxc info --show-log centos:
si@linux:~/Documents/Brave-LXD/CentOS-7$ lxc info --show-log centos
Name: centos
Location: none
Remote: unix://
Architecture: x86_64
Created: 2021/02/09 03:41 UTC
Status: Stopped
Type: container
Profiles: brave

Log:

lxc centos<PHONE_NUMBER>0441.580 WARN     cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1129 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.monitor.centos"
lxc centos<PHONE_NUMBER>0441.723 WARN     cgfsng - cgroups/cgfsng.c:mkdir_eexist_on_last:1129 - File exists - Failed to create directory "/sys/fs/cgroup/cpuset//lxc.payload.centos"
lxc centos<PHONE_NUMBER>0441.138 WARN     cgfsng - cgroups/cgfsng.c:fchowmodat:1550 - No such file or directory - Failed to fchownat(17, memory.oom.group,<PHONE_NUMBER>, 0, AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW )
lxc centos<PHONE_NUMBER>0441.745 ERROR    conf - conf.c:run_buffer:314 - Script exited with status 1
lxc centos<PHONE_NUMBER>0441.745 ERROR    conf - conf.c:lxc_setup:3388 - Failed to run mount hooks
lxc centos<PHONE_NUMBER>0441.745 ERROR    start - start.c:do_start:1218 - Failed to setup container "centos"
lxc centos<PHONE_NUMBER>0441.746 ERROR    sync - sync.c:__sync_wait:36 - An error occurred in another process (expected sequence number 5)
lxc centos<PHONE_NUMBER>0441.758 WARN     network - network.c:lxc_delete_network_priv:3185 - Failed to rename interface with index 0 from "eth0" to its initial name "vethf0aa3a51"
lxc centos<PHONE_NUMBER>0441.759 ERROR    lxccontainer - lxccontainer.c:wait_on_daemonized_start:860 - Received container state "ABORTING" instead of "RUNNING"
lxc centos<PHONE_NUMBER>0441.759 ERROR    start - start.c:__lxc_start:1999 - Failed to spawn container "centos"
lxc centos<PHONE_NUMBER>0441.759 WARN     start - start.c:lxc_abort:1013 - No such process - Failed to send SIGKILL via pidfd 30 for process 3982
lxc centos<PHONE_NUMBER>0442.400 WARN     cgfsng - cgroups/cgfsng.c:cgfsng_monitor_destroy:1086 - Success - Failed to initialize cpuset /sys/fs/cgroup/cpuset//lxc.pivot/lxc.pivot
lxc<PHONE_NUMBER>0442.408 WARN     commands - commands.c:lxc_cmd_rsp_recv:126 - Connection reset by peer - Failed to receive response for command "get_state"

It shows that its failing to load the container? Anyone have any ideas?
A bit more info about my system,
OS: Kubuntu 20.10
LXD version: 4.11
Brave version: 1.55 (the precompiled version found on the github)
Hopefully this is sufficient info to help me.

Hi - this seems to be related to: https://discuss.linuxcontainers.org/t/fail-to-start-container/5878/5
Can you debug by:

removing the container - brave remove centos
change Bravefile resources to gpu: "no"
brave build
brave deploy
brave units check if the container without a GPU is now running.

Are you running LXD inside a VM? There may be something going on with your nvidia drivers and LXD is not detecting them. What's the output of nvdia-smi on your Kubuntu setup?

Hi - this seems to be related to: https://discuss.linuxcontainers.org/t/fail-to-start-container/5878/5
Can you debug by:

removing the container - brave remove centos
change Bravefile resources to gpu: "no"
brave build
brave deploy
brave units check if the container without a GPU is now running.

Are you running LXD inside a VM? There may be something going on with your nvidia drivers and LXD is not detecting them. What's the output of nvdia-smi on your Kubuntu setup?

Yes I am first testing this in a VM, so my gpu is a vmware virtual gpu.

Could you check if you're able to build and deploy an image without gpu support?

Could you check if you're able to build and deploy an image without gpu support?

build and deploy without gpu support works but I have additional issues. Systemd inside container doesn't work and I can't launch any gui apps. What other additional steps do I need?

LXD shouldn't have any issues running systemd, so this is again looks like a start up problem inside your container.
To troubleshoot, see the first scenario on: https://linuxcontainers.org/lxd/docs/master/faq
Re GUI: https://blog.simos.info/how-to-easily-run-graphics-accelerated-gui-apps-in-lxd-containers-on-your-ubuntu-desktop/
This appears to be more related  to LXD settings and configuration rather than bravetools. LXD community is fantastic if this continues to be an issue: https://discuss.linuxcontainers.org/


3D scatter plot: visualMap doesn't take colors from series:itemStyle

Version
4.9.0
Reproduction link
https://jsfiddle.net/ramgorur/gxf6La29/
Steps to reproduce
Just go to the JSFiddle and run the code. No setup necessary.
What is expected?
Was expecting the visualMap to get the color: assigned in the itemStyle.
What is actually happening?
It takes the color but the order of the points get shuffled in a strange way.
For example, without visualMap I have this plot:

I want the same plot with a color-slider from the visualMap . So first I tried like this:
visualMap: {
        type: "continuous",
        seriesIndex: 0,
        min: 0,
        max: 1.0,
        color: (params) => {return colors[params.dataIndex];},
        calculable: true,
      },

and I'm getting this plot:

In the next attempt, I tried like this:
visualMap: {
        type: "continuous",
        seriesIndex: 0,
        min: 0,
        max: 1.0,
        color: colors,
        calculable: true,
      },

and I'm getting this plot:

What I want is keep the same coloring and a color slider provided by the visualMap.

Not sure if it's a bug or I'm not doing it in a correct way.

bump?

I believe this is still an issue in current versions. When trying to assign a color to each point of the 3d scatterplot the values get shuffled somehow.


Drag-and-drop of table fields don't work in safari

These drag and drop buttons don't work in safari. Nothing happens, it seems. In chrome it works fine.

(PS: Thanks for creating this inspiring tool)

I don't have Safari to test it but the issue is also reproducible in Gnome Web (which is based on older WebKit version that Safari uses).
It seems that WebKit is a little more strict and doesn't allow dummy/blank elements as drag placeholder, aka. the following is causing Safari/Gnome Web to fail silently:
e.dataTransfer.setDragImage(document.createElement("div"), 0, 0);

I've pushed a fix in master and will be available with the next minor v0.16.3 release (I'll not rush a release since it is fairly minor and it is not a blocker).


Refactored inventory interaction event blocking system

I ran into an issue while using SpiGUI as a dependency for my project where I couldn't use SHIFT + CLICK at all.
It turned out to be a hardcoded block, this update is to resolve this issue!
I've moved these blocks to the SGMenu, so the user can set the blockers / permitters themselves for every individual menu.
Although the user doesn't have to enter any settings, SGMenu and SpiGUI.create still has the old constructor that will automatically use the traditional blockers & permitters.
I've tried to copy you guy's code style as much as possible, please let me know if there is anything that needs changing before merging. I'm open for feedback! :)

Cheers! That looks good.
One thing… it might be nicer to have getters and setters for the permitted/blocked actions instead of passing them in the constructor - that makes their purpose more clearly labelled and would allow more flexibility then as you could change them dynamically.

Cheers! That looks good. :)
One thing… it might be nicer to have getters and setters for the permitted/blocked actions instead of passing them in the constructor - that makes their purpose more clearly labelled and would allow more flexibility then as you could change them dynamically.

Very good point, I've implemented your feedback and I agree, this is way better!
The public arraylists have been swapped with private arrays that can be set with variable arguments, I think it turned out very nice :)
Please let me know if you have any other feedback points!

Awesome, thanks! The variadic arguments are a nice touch! :)
It just occurred to me that it might be useful to also have methods to add/remove permitted/blocked too? (Although this is optional because if needed you could implement add/remove with the getters and setters).
Also using HashSet instead of Array for storing the permitted actions could be an optimization because it’s O(1) instead of O(n) - it’s something I hadn’t considered with the original implementation.
(That said, I doubt it makes much of a performance difference for so few elements (say around 6). It just has the advantage of ensuring there are no duplicates.)
In any case I don’t think those are really necessary so I’m happy to merge this and take a look at those myself afterward (unless you would like to?).

No half measures!
But for real, good feedback, HashSets also made it easier to add those add / remove methods and it is slightly more efficient.
And I never really used or even heard of them to be super honest, so I'm a slightly better programmer now!

Could you update the maven / gradle dependency so I can use it in my project? :)

Yep! I’ll publish a new release this weekend

Could you update the maven / gradle dependency so I can use it in my project? :)

Uhmm 👉👈 :)

Could you update the maven / gradle dependency so I can use it in my project? :)

Uhmm 👉👈 :)

Sorry - I haven't forgotten! :)
(I had wanted to try and bundle some other changes up too, but there's probably more to it so I'll just get yours rolled out tomorrow!)

Just deployed to Maven Central and pushed a release to GitHub.
Changes should roll out to both Central and JitPack shortly! :)


Refactor logging and errors

I'll use logrus, because k6 uses it, so there are no extra dependencies.
Update:
While working on issue #58 in PR #60, I found that the logging should be refactored first. Also, the current way errors are reported (using fmt.Printf) makes it really hard to test the output of the functions. So, this issue takes precedence over issue #58.

I'll write tests for this feature in #60, but it is available on main branch for testing.


Correctly obtain ALSA version for SBOM

Fixes https://github.com/adoptium/temurin-build/issues/3807 issue(2.)
Correctly obtain the ALSA version from the built spec.gmk

How does this behave with alsa download enabled?

How does this behave with alsa download enabled?

It retreives the built libsoundj path to the alsa used, which for download will be the path in --with-alsa=...


Will this be updated to work with Zustand V4 and above?

Hey, I'm on a legacy project using an old version of typescript and so I looked into this library, it seems to be working on Zustand 3.7.2 but not Zustand 4.1.1. This library works with legacy versions of typescript as there's no  TS 2509 Type union error that comes with the main persist middleware packed in with zustand.  Refer the issue here and as mentioned #22 , the example code is broken in typescript as Zustand 4 changed types.
Was wondering if this library will be updated in the future to support the new update?

You can use import { persist } from "zustand/middleware"; from the zustand library itself.


ebpf_hash_table_update copies large buffer twice

ebpf_hash_table_update copies the data twice, once before calling RtlInsertElementGenericTableAvl and then again after.   The second one makes sense if an existing entry was found.
It seems the first copy could be removed as it's redundant.

Note:
This is obsoleted by https://github.com/microsoft/ebpf-for-windows/issues/387, which is being addressed in https://github.com/microsoft/ebpf-for-windows/pull/389
Per the commit message from the Linux side, the behavior of update is to atomically replace the old value with the new value.
Note that non-per-cpu hash map always allocates new element
and then deletes old after rcu grace period to maintain atomicity
of update. Per-cpu hash map updates element values in-place.

The new BPF_MAP_TYPE_HASH now atomically replaces the old hash-map entry with the new one.

Closing this as the code is gone.


namecoin: nc0.13.0rc1 -> nc0.15.99-name-tab-beta2

Motivation for this change
getting namecoin to compile again.
sadly I will have to use a beta release for this (but was it ever stable anyway ;))
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg altcoins.namecoin

@GrahamcOfBorg build altcoins.namecoin

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘namecoin-nc0.15.99-name-tab-beta2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/altcoins/namecoin.nix:39 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/bin/test_namecoin
shrinking /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/bin/bench_namecoin
shrinking /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/bin/namecoin-qt
shrinking /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/bin/test_namecoin-qt
gzipping man pages under /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/lib  /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2/bin
patching script interpreter paths in /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2
checking for references to /build in /nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2...
/nix/store/illya2gm8y9bcnw58wx8va7fm56nv4hw-namecoin-nc0.15.99-name-tab-beta2

Failure on aarch64-linux (full log)
Partial log (click to expand)
  CXX      test/test_test_namecoin-base58_tests.o
  CXX      test/test_test_namecoin-base64_tests.o
  CXX      test/test_test_namecoin-bech32_tests.o
  CXX      test/test_test_namecoin-bip32_tests.o
  CXX      test/test_test_namecoin-blockchain_tests.o
  CXX      test/test_test_namecoin-blockencodings_tests.o
  CXX      test/test_test_namecoin-bloom_tests.o
  CXX      test/test_test_namecoin-bswap_tests.o
building of '/nix/store/7arkzs31bgjqi821s6842r46rrrx4x9p-namecoin-nc0.15.99-name-tab-beta2.drv' timed out after 3600 seconds
error: build of '/nix/store/7arkzs31bgjqi821s6842r46rrrx4x9p-namecoin-nc0.15.99-name-tab-beta2.drv' failed

e50c1ad98a58d649eb19155c2353c63ccbe42b37


Replace _padding with proper repr(align(x)) on newer Rust

This reduces the Bucket struct size from 112 bytes to 64 bytes when compiled on Rust >= 1.25 that supports #[repr(align(x))]

To be clear. After applying this patch, the Bucket struct has size 112 and alignment 8 on Rust <1.25. And on newer Rust it has size 64 and alignment 64.

Thanks!


Remove legacy manage.py

Proposed Changes
Simply remove manage.py from the project root.

Justification
This was left there initially in v1.0.0 as a fallback, however it is absolutely no longer needed.

Implemented by #3317 for 2.0.