Unbounce is not vulnerable for subdomain takeover.

The attacker here used an un-ethical way to exploit Unbounce which is resolved now as far as I believe.
https://github.com/EdOverflow/can-i-take-over-xyz#unbounce

Going through the hackerone report it seems that this instance of subdomain takeover was indeed an exploitation of a vulnerability on the Unbounce services. In the same report, both parties (researcher and Unbounce security team) confirm that the Unbounce vulnerability has been fixed.
Unless there is another instance of subdomain takeover for Unbounce I'll agree with @smiegles that Unbounce's entry is a false-positive.

Are you sure the takeover is still possible?
I am getting this error message when I try to "Add a New Custom Domain":
Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>

Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>Any idea how we can now

I don't think we can if someone has an unbounce account I can give you a link to test

@rosonsec @d55pak, Last I checked it was still possible. There might be some edge cases though for example, when I tested, I simply pointed my domain to Unbounces CNAME and see if it was vulnerable. In your case it seems like the domain was being used activity before and then removed from Unbounce. Unbounce might be blocking takeover on those types of domains but I am not sure yet. I will look into this further and update the ticket.
Cheers!

@rojan-rijal if you DM me on Twitter I can give you a previously used domain that is still pointing to a unbounce CNAME

I have tried to takeover 10 subdomains which has following Fingerprint
The requested URL was not found on this server.

Results of 10 subdomains are either:

Domain is already in use.
( or )
Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>
Looks like unbounce preventing us from takeovers which they have used their service previously.

👍

Sorry, I have been extremely busy lately and have not had a chance to update the project. We determined that there is only one rare case where one can hijack a subdomain pointing to Unbounce and that is if the team never had a project in the first place. The likelihood of this being the case is so minute that I personally do not think we should claim that it is possible to hijack subdomains pointing towards Unbounce. Thank you to everyone who participated in this discussions here; it is an absolute pleasure seeing everyone working together like this. :)

Hey there, I was reading this thread and seems pretty interesting. Which is a subdomain takeover?
A subdomain takeover is posible when the attacker can claim an unclaimed domain name through an alias or canonical name (cname)  pointing to unbouncepages.com.
Some 3rd party services put filters to avoid this, like adding a random TXT record or hash or others methods to force and secure the DNS entries as unique per customer, which is NOT the case of unbouncepages.
An attacker can claim a domain not claimed over unbouncepages.com. So, We have 3 scenarios when we want takeover a subdomain over unbounce:

'Domain is already in use' (which means that the domain is claimed)
'Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>(Which means that the domain is NOT actually claimed or used but unbounce detect that the domain was used in the pass) [they put this filter as intent to avoid takeovers.]
Claim the domain (no errors: the domain is added to domains section correctly)

*The 3rd options is still available and works: so YES, unbouncepages is Vulnerable to Subdomain Takeover.
regards,
@ak1t4

@EdOverflow @codingo Takeover via Unbounce is still exist who said not vulnerable last week I do a takeover last week and my friend do 1 takeover from unbounce month ago

@EdOverflow @codingo  Takeover via Unbounce is still Vulnerable as @ak1t4 said there is 3 cases ..   I do a takeover last week and my friend do 1 takeover from unbounce less than month ago

;)

@ak1t4 They mentioned here this is Edge Case and in the main status Not vulnerable  ..
This Poc belong to the duplicate report which  got duplicate after traiged and fixed :-(

That awkward moment when you realise that you have left the target's hostname in the tab bar. :P

hahahaahah!!!

Hi,
where I can find vulnerable domain sites because I  tried for many one but not get it to perform subdomain takeover. Even search in google dork.

When you add the domain name to the account, you will have to validate it again before it'll become active. This requires you to control the DNS of the domain, which you don't. So therefore subdomain takeover is not possible :(

When you add the domain name to the account, you will have to validate it again before it'll become active. This requires you to control the DNS of the domain, which you don't. So therefore subdomain takeover is not possible :(

Hi @m7mdharoun Here is your challenge takeover info.hacker.one which is pointing to unbounce services

Hi @vishnugadupudi as @ak1t4 said :

We have 3 scenarios when we want takeover a subdomain over unbounce:

'Domain is already in use' (which means that the domain is claimed)
'Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>(Which means that the domain is NOT actually claimed or used but unbounce detect that the domain was used in the pass) [they put this filter as intent to avoid takeovers.]
Claim the domain (no errors: the domain is added to domains section correctly)

info.hacker.one is already in use and already has pages example :
https://info.hacker.one/the-data-protection-officer/
https://info.hacker.one/2018-hacker-report/

This mean case (1)  '
Domain is already in use' (which means that the domain is claimed)

So not possible to takeover it .
Kind Regards,
Mohamed Haron.

@m7mdharoun :)

hello.guys.
takeover is still possible???

hello.guys.
takeover is still possible???

I just tried today and it fails ....

yup.me too.seems it needs a bit of luck.

You can found Steps here and This is still vulnerable
https://www.youtube.com/watch?v=-znOxODC2QM

I have tried to takeover 10 subdomains which has following Fingerprint
The requested URL was not found on this server.

Results of 10 subdomains are either:

Domain is already in use.
( or )
Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>
Looks like unbounce preventing us from takeovers which they have used their service previously.

👍

exactly same errors

I have tried to takeover 10 subdomains which has following Fingerprint
The requested URL was not found on this server.

Results of 10 subdomains are either:

Domain is already in use.
( or )
Looks like this domain has been deleted, to be able to use it again we need to verify its ownership for security purposes. Please contact our team at<EMAIL_ADDRESS>
Looks like unbounce preventing us from takeovers which they have used their service previously.

👍

exactly same errors

You Just need Good Luck to find it but it still work ;)

Status: 413 I’m a ☕ Teapot
El El sáb, 21 dic. 2019 a la(s) 17:21, m7mdharoun<EMAIL_ADDRESS>escribió:

I have tried to takeover 10 subdomains which has following
Fingerprint
The requested URL was not found on this server.

Results of 10 subdomains are either:
Domain is already in use.
( or )
Looks like this domain has been deleted, to be able to use it again we
need to verify its ownership for security purposes. Please contact our team
at<EMAIL_ADDRESS>
Looks like unbounce preventing us from takeovers which they have
used their service previously.

👍
exactly same errors
You Just need Good Luck to find it but it still work ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EdOverflow/can-i-take-over-xyz/issues/11?email_source=notifications&email_token=ACTRPJ7BBMB4235W2F7K5BTQZZ3EFA5CNFSM4EX2LSXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPC3DY#issuecomment-568208783,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACTRPJ3KTHJQ32SMLRBDL63QZZ3EFANCNFSM4EX2LSXA
.

thanks for the confirmation

@X-shadowt how you added dns record :P

@X-shadowt  how you manage whats the trick of social engineering you used for verification. please list down

I noticed that social engineering was mentioned here. Social engineering is not acceptable when participating in bug bounty programs (unless stated), nor is it acceptable in any case. I'd suggest NOT social engineering the friendly team at Unbounce to bypass their verification steps. You may end up in legal trouble and for what? A bounty? Not worth it. If you feel that unbounces methods for proving you own a domain are not adequate and you can 'bypass' them, i'd send them a message to politely let them know. Work with them, not against them :)
Stay safe everyone. <3

Thank you very much @zseano for pointing this out for the community!
At Unbounce safekeeping our customers and their information within our ecosystem is of utmost importance.
We believe in the mantra that no environment is 100% secure, and that upholding information security is an iterative effort and a process of continuous improvement.
Aside from our own internal resources we also partner with third party security researchers and firms to perform approved and prescheduled external vulnerability scans and penetration tests against our environment.
We would like to stress that our Acceptable Use Policy (which is part of our Terms of Service), as well as those of our infrastructure hosting provider's, prohibit users, customers, and third parties from performing unapproved vulnerability tests/scans against our platform.
Currently, we do not have a formal bug bounty program in the traditional sense with monetary rewards; but it is something we are considering as we appreciate the work of security researchers like yourself.
As such, and in the absence of a bug bounty program, we deem all unapproved tests/scans as unauthorized activities.
With that said, we completely support, and see the value in, sharing findings/PoCs online to educate others. However, in the event that you had unknowingly performed a test/scan against our platform, we ask that you remain committed to an ethical methodology in your approach.
To this end, we ask that you report your findings to<EMAIL_ADDRESS>first, and that you kindly refrain from sharing your results externally until our engineers have had the time to assess what you have reported.
Thank you all very much.
Please stay healthy and safe!

Thank you for addressing this, @zseano & @UBAMas. I will add a note about this in the README for future contributors. 👍

Hello
I found subdomain which is saying - The requested URL was not found on this server.
I check the cname for that subdomain, but i didn't found any cname .
Than i try to add this subdomain on unbounce . Its takes all the thing but when processing its still on configuration saying "Hang in there—we’re processing your domain!"
what should i do now

@foysal1197  I got the same response - The requested URL was not found on this server.
May I report it?

@foysal1197 I got the same response - The requested URL was not found on this server.
May I report it?

Sure No don't report until , you must be sure that you takeover this subdomain.
let's Take a small example :
Hackerone has subdomain called info.hacker.one  This subdomain show you error The requested URL was not found on this server.
visit https://info.hacker.one/
But it works well in paths example :
visit https://info.hacker.one/2018-hacker-report/
Kind Regrads,
Mohamed Haron.

I searched the whole internet with dork and every tool but there is sub
file like test.domain.com/test.php .
It only have single domain that is test.domain.com which is showing error
that requested url not found on this server.
What should I do?
On Wed, 1 Jul 2020, 10:26 pm m7mdharoun<EMAIL_ADDRESS>wrote:

@foysal1197 https://github.com/foysal1197 I got the same response - The
requested URL was not found on this server.
May I report it?
Sure No don't report until , you must be sure that you takeover this
subdomain.
let's Take a small example :
Hackerone has subdomain called info.hacker.one This subdomain show you
error The requested URL was not found on this server.
visit https://info.hacker.one/
But it works well in paths example :
visit https://info.hacker.one/2018-hacker-report/
Kind Regrads,
Mohamed Haron.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EdOverflow/can-i-take-over-xyz/issues/11#issuecomment-652535542,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQDTYIBYO4EYOARIK466KS3RZNTFNANCNFSM4EX2LSXA
.

@Bplotka @foysal1197  Did you ever manage to perform subdomain takeover for Unbounce? I don't think it will be possible now until you interact with the unbounce team, as per the link here: https://documentation.unbounce.com/hc/en-us/articles/360000851786

@UBAMas explained that you shouldn't be trying this. Closing the issue.

Hi @m7mdharoun  I still have the same error The requested URL was not found on this server.
how can i exploit it?

not vulnerable

Is it still possible in 2020 to takeover subdomain in unbounce.com with this "The requested URL was not found on this server." error?
Anyone ??

@ayushmayank no it's not bro

@X-shadowt yah I was thinking that too... thanks

Hello ,
I just test 3 subdomains with 404 Error Via Unbounce .
i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty :100:

Hello ,
I just test 3 subdomains with 404 Error Via Unbounce .
i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

Are you sure ?
Found a case just like you said and this is what I got

do you think this subdomain take over is possible i dont want to register my credit card in unbounce

by any  chance it is possible to take over this subdomain

No i think it 's not possible to claim it .

Everytime you find an long string identifier, chances you can take the
domain are very low.
On Fri, 14 May 2021, 06:01 0xElmalky, @.***> wrote:

No i think it 's not possible to claim it .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EdOverflow/can-i-take-over-xyz/issues/11#issuecomment-841145104,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2OS75WBWO3XAHHWDAIEI3TNTYIJANCNFSM4EX2LSXA
.

is this takeover possible

any one is takeover possible here

is takeover possible here

can you bypass Unbounce's control by doing an NSLOOKUP and using the alias associated with the domain that Unbounce has blocked?

so Unbounce not a vuln ?

no bro

is it still working ?

Does this still work, anyone ?

Does this still work, anyone ?

no

Here is end to this topic for now its not possible to takeover
Regards :)
https://user-images.githubusercontent.com/44978381/195972592-9163e08b-b6e3-4e93-b251-e5e7a24f095f.mp4

@rojan-rijal ur totally right .. last night i reported a subdomain takover and it was using unbounce. The sec team triaged it asap ..! 😅
how you exploited i mean how takeover

I confirm that Unbounce is still vulnerable to subdomain takeovers since I successfully took over a subdomain 17 days ago (23 December 2022).

Hello , I just test 3 subdomains with 404 Error Via Unbounce . i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

Hello, can you tell me the tool name I also have the same problem with this .Please

Thank you
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Sayan Chakraborty @.>
Sent: Friday, January 20, 2023 9:14:44 AM
To: EdOverflow/can-i-take-over-xyz @.>
Cc: fsocietyxzy @.>; Comment @.>
Subject: Re: [EdOverflow/can-i-take-over-xyz] Unbounce is not vulnerable for subdomain takeover. (#11)
Hello , I just test 3 subdomains with 404 Error Via Unbounce . i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com  canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com      canonical name = unbouncepages.com.
Name:   unbouncepages.com
Address: <IP_ADDRESS>
Name:   unbouncepages.com
Address: <IP_ADDRESS>
Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com  canonical name = unbouncepages.com.
Name:   unbouncepages.com
Address: <IP_ADDRESS>
Name:   unbouncepages.com
Address: 54.93.101.
it is 100% Vulnerable For Takeover And Congrats about the bounty 100
Hello, can you tell me the tool name I also have the same problem with this .Please
—
Reply to this email directly, view it on GitHubhttps://github.com/EdOverflow/can-i-take-over-xyz/issues/11#issuecomment-1397965468, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A47PWBTRDZNJYB5GMI7JGCLWTIUNJANCNFSM4EX2LSXA.
You are receiving this because you commented.Message ID: @.***>

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

which command i can use to check this ?

dig subdomain.test.com

I confirm that Unbounce is still vulnerable to subdomain takeovers since I successfully took over a subdomain 17 days ago (23 December 2022).

how you bypass the domain error?

Hello ,
I just test 3 subdomains with 404 Error Via Unbounce .
i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

Are you sure ?
Found a case just like you said and this is what I got

this is the same error I am facing, anybody knows if it is still possible to bypass it and take over?

I confirm that Unbounce is still vulnerable to subdomain takeovers since I successfully took over a subdomain 17 days ago (23 December 2022).

how you bypass the domain error?

There was no error, for me at least. I guess it was pure luck, I guess?

I confirm that Unbounce is still vulnerable to subdomain takeovers since I successfully took over a subdomain 17 days ago (23 December 2022).

how you bypass the domain error?

There was no error, for me at least. I guess it was pure luck, I guess?

maybe, good for you.
What about the txt record entry thing mentioned above, aren't we need to have access to the target's root domain for this?
btw I just contacted the support team and they also provide me with an entry to add as Txt record, can I add this in any domain I owned?

Hai, ada yang punya akun unbounce?

That awkward moment when you realise that you have left the target's hostname in the tab bar. :P

Yes if url is insecure takeover is possible

Hello , I just test 3 subdomains with 404 Error Via Unbounce . i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

Hello, can you tell me the tool name I also have the same problem with this .Please

Yes you are right

Hello , I just test 3 subdomains with 404 Error Via Unbounce . i noticed that the Subdomain With CName Record Like this
Non-authoritative answer:
Sub.Domain.com	canonical name = 1b450602efa347e0ac14sadwa8be95d.unbouncepages.com.
1b450602efa347e0ac14c4fb0a8be95d.unbouncepages.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: <IP_ADDRESS>

Is 100% Not Vulnerable And You Can't Claim it .
But if the Cname Record Was Like this :
Non-authoritative answer:
Sub.Domain.com	canonical name = unbouncepages.com.
Name:	unbouncepages.com
Address: <IP_ADDRESS>
Name:	unbouncepages.com
Address: 54.93.101.

it is 100% Vulnerable For Takeover And Congrats about the bounty 100

Hello, can you tell me the tool name I also have the same problem with this .Please

Yes you are right

Hi, is there any special indication other than cname, for example from the protocol whether SSL is available, error or not?

still vulnerable ?

<a href="httref="https://github.com">click meps://github.com">click me

still vulnerable ?

Unfortunately not possible.

It's still vulnerable but only as a rare edge case, I exploited a valid one a few days ago - see https://github.com/Stratus-Security/Subdominator/issues/1#issuecomment-1868153929

Hello @coj337 I recently saw on Unbounce account giving an 404 Status code. Could you please help me confirm if its vulnerable for subdomain takeover with your account? I don't have funds to purchase one. Thank you very much sir.

If it is, then well share the outcome.
Am a bug bounty hunter by the way :)

Hello, even after when you add your domain, It is not vulnerable.
Just shift your attention to something else.

Not true.

Not true.

Yeah i think so, it's possible, The domain was pointing at a random ip address while using dig command and when i can subzy it was vulnerable to unbounce subdomain takeover and also when i claimed the subdomain it got claimed but after that it was asking for a cname to go live i guess. So, if anyone knows how to do that please help

Ok. No challenge.
I'll be glad to learn how you will do that.
Thanks and regards


Hide "show" action in backend for unauthorized users

We are currently unable to show a post if the logged user is not the author (i.e. in backend).
This PR move the "show" action towards authoring protection (Like "edit" action).
Result:

Just asking, shouldn't we filter the posts list by the authenticated user though?

I think you can show posts even if you're not the author of it.

Make sense show a post which we cannot act?

It's a controversial question since all posts are public on frontend and anyone can read it... so why we should deny reading them on backend?

@bocharsky-bw I agree with you, so there are two options:

Allow show a post and hide "edit", "delete" actions inside?
Show only the posts of the authenticated user (author) in this list?

I go for the second.

I think that showing post only for it's author is very strange behavior :) I would allow all authenticated users to view any post.

@voronkovich

I would allow all authenticated users to view any post.

IMHO this is the goal of the frontend.
If I enter to backend I'll want to see my posts only, to review/edit it or create a new one.

@yceruto, thanks for the explanation. It makes sense.  So, I would choose the second option: Show only the posts of the authenticated user (author) in this list.

This might be trickier than I thought. For example, if I browse the backend of a WordPress blog managed by several users, I can see (and most of the times, edit) the articles written by all authors, not only me.
If you agree, we could do this instead:

In the "author" column, display "You" is you are the author of the article. Otherwise, keep displaying the author's email.
Keep the Show button for all articles
Keep the Edit button for all articles ... but disable it for articles that you are not the author. Bonus: display a hover message in those buttons saying: "You can't edit this article because you are not the author".

Does it make sense?

@javiereguiluz I think it's fine, but what do we do with the "show" button? we allow show the post and we hide the edit/delete actions inside it? or we disable it too?

@yceruto if we do this, then yes, we should display but disable the edit and delete buttons.
But there's something I don't like about this proposal and I don't know what is. It doesn't feel right to me :(

@javiereguiluz to be honest, me neither. IMO this is a multi-user app that has two scenarios, frontend (public) and backend (private), so for me, just to filter the posts list by the logged user would simplify the things. What do you think about this alternative?

Yes ... maybe it's better to only display your posts and see if we like the result 👍

Updated!

Rebased with master!

@yceruto much simpler and better now! Thanks.


Added TOC Category for easier searching/navigation

When the TOC grows in number, it will be very difficult to navigate or search relevant issues, hence I have added a category to make it more structured and organized.
Thanks @litong01 for suggestion the TOC and @ryjones  for implementing the TOC.

Will redo pull request


web socket client

reference implementations

https://github.com/atmoner/cosmos-websocket

reference implementations

https://github.com/atmoner/cosmos-websocket

You can refer to this file for a minimum code, it simply retrieves the new blocks live from websocket of tendermint :+1:
import WebSocket from 'ws';
const ws = new WebSocket('ws://osmosis.strange.love:26657/websocket');

ws.on('open', function open() {
  console.log('Connected on Osmosis blockchain from WebSocket');
  ws.send(JSON.stringify({
    "method":"subscribe",
    "params": ["tm.event='NewBlock'"],
    "id":"1",
    "jsonrpc":"2.0"
  }));
});

ws.on('close', function close() {
  console.log('disconnected');
});

ws.on('message', function incoming(data) {
  var finalData = JSON.parse(data.toString('utf-8'));
  if (finalData.result.data)
    console.log(finalData.result);
});

https://github.com/atmoner/cosmos-websocket/blob/main/osmosis-websocket.js

The doc is here: https://docs.tendermint.com/master/rpc/

thanks @atmoner ! this is much appreciated :)

Also; keplr-wallet TendermentTxTracer
https://github.com/chainapsis/keplr-wallet/blob/97a65130583778b09e59016e0e7c95a296641c94/packages/cosmos/src/tx-tracer/index.ts#L9-L308

@Zetazzz hey, do you want to discuss on how we will implement this ? I can't reach to you through discord so tagging you here.

@hoangdv2429 Hey, sorry for late response. yes, I think we can discuss more on discord.


Purple-Black Textures on map icons

in my gmod, lot of maps without icon. And in game i see translucent, but in StormFox i see Purple-Black icons!!!

I'm just loading the map-icons from your client. StormFox does not add or remove map-icons.

StormFox not remove map icons from game menu! and lot of my maps use default translucent map icon(in gamemenu). but stormFox in (where can see what map scanned,has env_....) for maps without icon use purple-black texture

StormFox support temperature changing only for 1 player? if yes, can be realized warm temperature in vehicle!


About the key modification pain points and suggestions, I hope the software is getting better and better, thanks for reading my suggestions in a busy schedule.

Description of the new feature / enhancement

Single-key key modifications can also be set for specific software. (Currently only shortcut key modifications are supported for specific software)

key modifications can have more than two presets and can be quickly switched with custom shortcut keys.

Scenario when this would be used?
People who have the need to change keys for specific software, and people who need completely different keys for different scenarios such as work or life, may need these functions very much
Supporting information
As a user of the actual use of pain points, I hope the software is getting better and better, please refer to, thanks for reading my suggestions in a busy schedule

/dup #6756 and #18350

This is a completely different issue.

what is already available for different applications are the shortcut keys below, the single key above is not set to target different applications.

there are multiple presets for the overall solution and can be toggled with custom shortcuts (currently there is only one preset), and the overall switch between completely different key settings, for example I use completely different keyboard presets at work and for entertainment.

This is a completely different issue.

what is already available for different applications are the shortcut keys below, and the single key above does not target different applications.

there are multiple presets for the overall solution and can be switched with custom shortcuts (currently there is only one preset), and the overall switch function for completely different key settings, for example, I use completely different keyboard presets for work and entertainment.

------------------ 原始邮件 ------------------
发件人:                                                                                "microsoft/PowerToys"                                                                                @.>;
发送时间: 2022年8月27日(星期六) 下午2:30
@.>;
<EMAIL_ADDRESS>主题: Re: [microsoft/PowerToys] About the key modification pain points and suggestions, I hope the software is getting better and better, thanks for reading my suggestions in a busy schedule. (Issue #19925)
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

/dup #6756和#18350

This is a completely different issue.

what is already available for different applications are the shortcut keys below, and the single key above does not target different applications.

there are multiple presets for the overall solution and can be switched with custom shortcuts (currently there is only one preset), and the overall switch function for completely different key settings, for example, I use completely different keyboard presets for work and entertainment.


keybind changing

Describe your problem here.
i can only change the left keybind and i cant go further down to change the other keybinds im pressing s and it doesnt work. is there another way to scroll? pls help
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Have you tried pressing the down arrow?

S key doesn't work in options.
Have you tried pressing the down arrow?

S key doesn't work in options. Have you tried pressing the down arrow?

thanks that helped me

S key doesn't work in options. Have you tried pressing the down arrow?

thanks that helped me

Cool.
IF your problem has been solved, please, close this issue.


request regarding issues with bug-fixing ARC9 calcview

some bug-fixes weren't necessary and instead made it worse for any FOV changes.
also apparently, the "bug-fix" at a line containing fixfovmult = view.fov / fov just made the ARC9 FOV smaller rather than fixing it entirely, changing it to fixfovmult = fov / view.fov on other hand made it increase the ARC9 FOV.
also the unnecessary changes to the Beatrun_FOV callback made it to each time you changed your FOV (through Q-menu or console), it made the FOV change back to the original FOV.

Also fixed the issue, where you had to press Left Shift instead of Left Control in order to do a Safety Roll, after jumping off a swing rope or zipline.

Looks good to me!


inlay hints

Inlay hints from LSP can show the parameter type as virtual text in the code line to help the user better understand the code. Currently, nvim's support for this is incomplete, i.e., ext mark can only show the virtual text after the line.

inlay hints in nvim: https://github.com/neovim/neovim/issues/18086
Neovim PR for this (not ready): https://github.com/neovim/neovim/pull/9496
vim supports inlay hints via text prop (vim's version of virtual text): https://github.com/vim/vim/issues/7553
coc.nvim supports inlay hints: https://github.com/neoclide/coc.nvim/commit/d9967a047394e2365cb9e82b8dae494f9809241c
vim-lsp supports inlay hints in this PR: https://github.com/prabirshrestha/vim-lsp/pull/1347

Implemented https://github.com/neovim/neovim/pull/23736


GPTQQuantizer hard coded the device to 0

System Info
optimum version: 405199457d9f6b8e060c043216eb717bc7a4c4c1
Platform Linux:
Python version: 3.11

Who can help?
@SunMarc @younesbelkada @fxmarty
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)
When trying to use device_map to load the model to a specific device. The quantizer raises the error

RuntimeError: Expected all tensors to be on the same device, but found at least two devices

from transformers import AutoModelForCausalLM, AutoTokenizer, GPTQConfig
import torch
torch.cuda.set_device(2)
quantization_config = GPTQConfig(
        bits=4, group_size=128, dataset="wikitext2", desc_act=False, use_cuda_fp16=True
    )
quant_model = AutoModelForCausalLM.from_pretrained(
    "facebook/opt-125m", quantization_config=quantization_config, device_map={'':torch.cuda.current_device()}
)

The root cause is the at https://github.com/huggingface/optimum/blob/405199457d9f6b8e060c043216eb717bc7a4c4c1/optimum/gptq/quantizer.py#L429C21-L429C38
if self.cache_block_outputs:
     handle = blocks[0].register_forward_pre_hook(store_input_hook, with_kwargs=True)
      for data in dataset:
          for k, v in data.items():
              # put the data on gpu, we won't put them back to cpu
              data[k] = v.to(0)
          try:
              model(**data)
           except ValueError:
              pass
      handle.remove()

Expected behavior
The input should be transferred to the same device as the model.

cc @SunMarc

same problem here


Add Nudge logo in the header bar

At http://kibana.nudgeapm.io -> replace the kibana logo by the nudge one

Previously done, one month ago


About Visualization

Hi~
It's a exciting work!
I wanna ask that what tool you use to visualize point clouds in your paper?
Thanks a lot!

I use the meshlab to visualize the point cloud in our paper. You can download it from https://www.meshlab.net/


Add pre-commit hook

Thanks! I'm OK with these checks as pre-commit checks. I really liked @jklmnn 's suggestion of having the heavier checks (mypy, pylint) as pre-push checks in addition to this.

@kanigsson I have added a pre-push hook which executes all checks.


Feat/linters - test picking up shebang shell scripts without extension and annotating in PR

Testing that files without a .sh extension and with a present shebang are picked up. This currently relies that such files are executable (perm /111) and don't have an extension (! -f .) - that is directly taken from the shellcheck action used previously that has shell script detection. We can loosen that up if needed.

Files are picked up and annotations are present, closing this and opening another PR in the operator-workflows.


Adding Vertical order Traversal of binary tree

Related Issue

#84

Proposed Changes

Added vertical order traversal of a binary tree using level order traversal along with time complexity
Updated README.md accordingly

Additional Info

Vertical order traversal is the method of traversing a tree from top to bottom and left to right.
In the output, the node that is at leftmost horizontal distance of the root node is printed first.
Then the other nodes that are at same horizontal distance are printed from top to bottom and left to right, ending with the rightmost node.
There are various methods for the same, but here it is being implemented using level order traversal.

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the documentation.
[x] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Input/Output Screenshots

@Lakhankumawat Can you please clarify the above doubt, so that I can work accordingly on it again?

Edit Your PR descriptive and describe your PR in a bit of details .

You need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

once you re done these changes and one of mentors reviews your PR , your PR will be merged , thanks .

Thanks for reviewing. I'll make the changes and update  soon.

@Lakhankumawat I have updated the code and README accordingly. Are there any more changes to be done?

@siddhi-244 The table of contents should include the contents of Vertical order traversal or all the various traversals?

For the one which you have done !

closed

@all-contributors please add @Chahat-M code ,


Forum video link

https://www.parkinsons.org.uk/content/online-community

YouTube link: https://www.youtube.com/embed/zSsh0_Z7Ipk

This can be done via an iframe.


Do we need a new category for OSPO Landscape Tools?

@caniszczyk - I was talking to @nishakm and @rnjudge, and we decided to put Tern in the Licensing category (PR #52) for lack of a better category, but we were wondering if maybe there should be an SBOM category that Tern and possibly SPDX or other projects might better fit into an SBOM category?

I think an SBOM category or something like "SCA" that can include licensing
and security related tools
On Tue, May 18, 2021 at 10:09 AM Dawn Foster @.***>
wrote:

@caniszczyk https://github.com/caniszczyk - I was talking to @nishakm
https://github.com/nishakm and @rnjudge https://github.com/rnjudge,
and we decided to put Tern in the Licensing category (PR #52
https://github.com/todogroup/ospolandscape/pull/52) for lack of a
better category, but we were wondering if maybe there should be an SBOM
category that Tern and possibly SPDX or other projects might better fit
into an SBOM category?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/todogroup/ospolandscape/issues/53, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSIJHTTTXYMOANSTYXYLTOJ7KLANCNFSM45CXEVMQ
.

--
Cheers,
Chris Aniszczyk
https://aniszczyk.org

Closing this issue. SCA box is already implemented at OSPO Landscape 👍 https://landscape.todogroup.org/card-mode?category=sca&grouping=category


Devops pipeline is running successfully for databricks notebook deployment, but notebook are not getting deployed to databricks workspace.

We are using Databricks Deployment Notebook task to deploy databricks notebooks to the India subscription, but deployed folders are not reflecting in databricks workspace. This task is not failing in the pipeline but it is deploying the code to workspace. It is giving a xml error.
please find the below details
Workspace Name: gcpl-da-dev-databricks-001
Workspace Location: centralindia
Folder Name: gcpl_mfg_iot
I am using service principal method to connect to databricks.

please help us to resolve this issue.

Hi Team any update on the issue

I am facing the same issue.


Fix forceSsl exceptions

This ensures Patrol starts with a baseUrl containing the schema (and includes a port if used) before trimming/replacing http: and avoids it throwing a FILTER_VALIDATE_URL exception. I also added the available override setting to the readme.

@chrisrowe Thank you!
I've been lagging behind on Patrol maintenance, your help is much appreciated.
Primary domain is used in routing but for a slightly different purpose than SSL alone.
It let's you redirect to a specific domain if your site/app can be accessed via different domains.

@selvinortiz Thanks, any idea when you'll be pushing a new release for this?

@chrisrowe Sorry about the delay, Chris. I'll do my best to cut a new release before the weekend.


Support custom directives

Is your feature request related to a problem? Please describe.
I would like to render information about custom directives declared on a schema type or in the locations (like: field). The information includes a custom description of how/why is the custom directive is declared.
For example: we have one query called searchRole, and we want to limit access to ADMIN user role only. We can accomplish this by adding a directive called auth with an argument requires to the query. In the generated document MDX for the query, there will be a section for type directives to list the directive auth with a custom description This requires the current user to be in ADMIN role..
Thought this use case might be rare and requires customizations. Curious to know your thoughts/suggestions on implementing this.
Describe the solution you'd like
Add a new plugin setting to allow selection of custom directives and a descriptor function for each selection. The descriptor function accepts arguments of defined directive type and declared directive node, the function allows the user to customize the display information.
Similar to how it handles group info for categorization, we parses the schema and root types to collect the defined directive types based on the setting. When traversing the schema types and its nested properties (like: fields and arguments), it will check if there is any custom directive declared in the location and conditionally render the information for the directive.
Describe alternatives you've considered
Alternatively, we could include the information in schema description.

 Thank you for bringing this feature forward, and pushing the PR :muscle:
I can see in the PR that you choose the custom helper function to inject the directive resolution - and, I like that solution, pretty sleek.  I'll dive more into the PR today and provide a full review.
As part of improving directives support, I was thinking that the feature would have to provide support for the following requirements:

Add a  new Directives section to be populated if any directive is applied to an entity: param, type, enum, ...
This would be very basic:
### Directives
   * `auth`
      Description ...
   * `complexity(3)`
      Description ...

Obviously, this fully fit your current proposal and PR :clap:

Then there is the the case of directives applicable to a param type, eg
  directive @auth(level: AuthLevel) on OBJECT | FIELD_DEFINITION

  enum AuthLevel {
      NONE # no authentication required (public)
      USER  # user authentication required (private)
      SELF  # user authentication required, limited to authenticated user (private strict)
      ADMIN  # admin authentication (admin)
  }

  type query {
      User(id: ID!) : User
  }

  type User {
       id: ID!
       name: String!
       email: String! @auth(level: SELF)
  }

In type User, we should then render the directive. This can be done either by using the badge system, and/or adding a subsection that would resolve like the normal section.

Also note in the example 2, when using an enum the directive should then inherit (or not) the enum description if present.

This open a question about rendering any directives in the GQL snippet? I'd say no as it can quickly make it crowded, but this can be a plugin parameter.

Ofc, the whole implementation will need to fully support the skipDirective feature. IE, if a directive has skipDirective then it won't be rendered as part of directive list, nor in the section directive - if this is the only directive, then the section is not rendered.

Hi @edno
Thank you for the thoughtful details about feature requirements and the full reviews on the PR already! 👍
I agree with the proposed requirements. Think some of them are implemented in the POC PR. Here are some of my thoughts regarding the requirements:

Add a new Directives section 👍 Considerations of printing information in this section about the directive name, link to the defined directive type, how the directive is declared, and description.
The PR covers most part of the information, except for how the directive is declared. Regarding where to print the information, one option is to include it in the section as shown in your example for complexity(3), one other option could be including it in the Code section similar to how it shows the deprecated directive, another option could be omitting it to defer to the description.

Cover the case of directives applicable to a param type 👍 The PR uses the badge system and a subsection for description to render the directives, similar to the approach for deprecated directive.

Inherit enum description: I think this is a good use case to cover. Though it's not covered in the examples in the PR, but given the setup of new plugin parameter, this is possible to do.
The PR uses a new plugin parameter to map custom directive name to descriptor function. There are 2 arguments useful for the descriptor function: one is directiveType of type GraphQLDirective (which is the defined schema directive type), and the other one is constDirectiveType of type ConstDirectiveNode (which is the declared directive node). For an argument of enum type, to get the enum value's description, one can find the information from directiveType, like: find the matching argument by name through <directiveType>.args; given the match of type GraphQLArgument, then find the underlying type's description.

Thank you again for the thorough reviews of the PR, I will address the feedbacks and update the PR! 🙇

Hi @ljiang-ti

the section is the best option. Yet, shall we also show them on the GQL snippet? Maybe, we can add an optional handler in addition to descriptor, eg snippet?

I am not 100% convinced by the badges... I need to think about it, but that can be reviewed in a later release, and we can still go with the current implementation for the coming release

I covered this one in PR comment: https://github.com/graphql-markdown/graphql-markdown/pull/844#issuecomment-1528745898

:bulb: I also think we can extend, or rather improve, how to enable the section directive.
Instead of only supporting custom directives mapped under customDirective, we can add a more generic option typeDirectives for displaying the directive section:

undefined || false: legacy behavior, no section displayed
true: display the section with all directives associated to a type with their description
customDirective: {}: behavior as per your PR, ie custom description and filtering

What do you think?

Hi @edno
Agree with the proposed changes! Honestly, this is one original idea around custom directives, thanks for taking it further to extend the possibilities. 👍

I think my proposal can be improved and simplified by keeping it closer to your design for customDirective.
I'd keep just customDirective moved/renamed to printTypeOptions.directives (more consistent with the general option printTypeOptions) with following behavior:

undefined: legacy behavior, no section displayed
{ [name: string]: function } same as your design with a twist by supporting a generic handler *

Example:
{
/// other options
  printTypeOptions:
  {
    directives:
    {
      '*': // catch non specific directive handling
      'auth': // specific directive handling
    }
  }
}

Excepted the renaming of the config option, I won't introduce the generic handler * in the current PR as it is not critical.

In that case, the case true from my previous proposal would become '*': genericHandler, where genericHandler can be the out-of-the-box function exported by the package likehttps://github.com/graphql-markdown/graphql-markdown/pull/844#issuecomment-1528745898.

Implemented in PR #860

Closing this feature request with the release 1.18.2 :rocket:

Closing this feature request with the release 1.18.2 :rocket:


Powertoy suggestion: Idle user tracker

Today there is no good and simple way to configure logout of user after a certain amount of idle time, in for example a virtualized zero/thin client environment like vmware horizon. you have the GPO for idle rdp sessions, thats all. it would be helpful with a idle time tracker that could easily be configured to log out someone after a certain amount of time.

You can, thanks to GPO, send a logoff command instead of a screensaver.
You can enforce an idletime before the screensaver is started.

Log off or lock?  I don't know if we'd do a log off as doesn't seem 'power user' and lock already has this ability.  /needinfo


build: Update to header 1.3.264

Update known-good
Generate source

CI Vulkan-Tools build queued with queue ID 40230.

CI Vulkan-Tools build # 1123 running.

CI Vulkan-Tools build # 1123 passed.


Embedding subtitles --embed-subs converts .ass subtitle to srt?

Hi,
When I try to download a video with .ass subtitle yt-dl does convert it to .srt ?
How can I keep .ass subtitle format?
This is the command I did use and
Here is the output verbose.
youtube-dl "URL" --cookies "cookies.txt" -f best --all-subs --write-sub --embed-subs

use --keep-video option.

use --keep-video option.

İt doesn't work the embed subtitles are .srt again it still converts .ass files to .srt but the only difference is that .ass subtitles aren't deleted this time?

mp4 format does not support embeding ssa/ass subtitles, so the subtitle needs to be converted before embedding in the mp4 file.

mp4 format does not support embedding ssa/ass subtitles, so the subtitle needs to be converted before embedding in the mp4 file.

So what command do I need to remux fast to mkv?
--merge-output-format mkv doesn't work?

So what command do I need to remux fast to mkv?

not currently supported, this problem has been already reported.

So what command do I need to remux fast to mkv?

not currently supported, this problem has been already reported.

Ok I understand thank you for your help could you post the links of the topic this issue has been reported so that I can follow the problem?

#17968

I found solution yt-dlp does have --remux mkv🙂👍
https://github.com/yt-dlp/yt-dlp

I found solution yt-dlp does have --remux mkv🙂👍

yt-dlp --remux-video mkv --sub-lang enUS --write-sub --embed-subs this will work


Stories not open In IOS

Dear Team,
I hope this message finds you well.
We have successfully integrated your package into our project. It is functioning seamlessly on Android; however, we are encountering an issue on iOS. Specifically, when we attempt to click on a user image, the stories do not open.
Could you kindly provide guidance on how to address this matter? Any assistance you can offer would be greatly appreciated.

Hello! thanks for using our library :) are you using stories inside of modal? Because on iOS there is allowed only one modal opened ( stories is using modal ). if so, please create your custom view with absolute position and width, height 100%.
If this is not a problem, please try to debug touchableOpacity onPress inside avatar component.
let us know if problem is solved, thanks!


Selecting node while moving mouse causes undoable position change

Godot version:
3.1 alpha2
Issue description:
When you try to select node and accidentally move mouse while doing so, the node will move for split second and stop (it's like it instantly applies cursor velocity vector to the position just after being selected). It's annoying on it's own, because you risk breaking things when trying to simply select something.
But what's worse, this movement can't be undone. Not sure how it was before alpha2, but now when you accidentally move something while selecting, it's not recorded as undo action. If you do it on freshly opened scene, the undo doesn't work at all. But when you have some undo history, trying to undo looks like undoing 2 operations (because the selection one wasn't recorded).
Steps to reproduce:

Open a scene with any node (actually I tested it only on Control nodes)
Try to select a node, but do so while moving mouse
If done correctly, the node will move slightly just after being selected
Happy reverting, unless you want to manually move it back

Here's a gif showing it:

What I did was moving the panel, then deselecting it, then selecting again with quick-moving mouse. After I did undo (CTRL + Z), it returned to the first position, instead the second one.

Might be fixed in one of the beta versions. I was able to repeat what you described using 3.1 alpha 2, but in 3.1 beta5 and master the drag behavior has been changed. It is now possible to do proper drag and drop without having to click mouse twice and undo is working.

Yeah, seems to be fixed already.


Add application/json header for errors

https://github.com/rancher/rancher/issues/7961

LGTM.
I'll merge, but a better solution would be to check if the request's Accept header was application/json and only set this header if it was that.


WIP: Copy the contents of requirements_all_ds.txt into requirements.txt

As per discussion to try and get our build to include all data sources:
https://github.com/RedashCommunity/redash/issues/59#issuecomment-1599951891
Note that I have no idea if this will actually pass our CI as is, so this is more experimental than anything for now.
Also update httplib2 to version 0.15.0, as 0.14.0 is apparently too old (according to my local pip install).
When trying this out from the command line on my local Ubuntu 20.04 system, pip installs most of them but throws these errors:
ERROR: boto3 1.14.63 has requirement botocore<1.18.0,>=1.17.63, but you'll have botocore 1.13.50 which is incompatible.
ERROR: dql 0.6.2 has requirement botocore>=1.17.55, but you'll have botocore 1.13.50 which is incompatible.
ERROR: dql 0.6.2 has requirement pyparsing==2.1.4, but you'll have pyparsing 2.3.0 which is incompatible.
ERROR: snowflake-connector-python 3.0.2 has requirement charset-normalizer<3,>=2, but you'll have charset-normalizer 3.1.0 which is incompatible.
ERROR: snowflake-connector-python 3.0.2 has requirement cryptography<41.0.0,>=3.1.0, but you'll have cryptography 2.8 which is incompatible.
ERROR: firebolt-sdk 0.16.2 has requirement cryptography>=3.4.0, but you'll have cryptography 2.8 which is incompatible.
ERROR: firebolt-sdk 0.16.2 has requirement python-dateutil>=2.8.2, but you'll have python-dateutil 2.8.0 which is incompatible.
ERROR: firebolt-sdk 0.16.2 has requirement sqlparse>=0.4.2, but you'll have sqlparse 0.3.0 which is incompatible.
ERROR: pinotdb 0.5.0 has requirement httpx<0.24.0,>=0.23.0, but you'll have httpx 0.24.0 which is incompatible.
We may need to drop those data sources in the short term to get things to a fully working state, then come back to them at some later point.

Heh Heh Heh.  It threw the error on the dql libray.  I'll update this PR with the downgraded dql library version, so we can see what happens. :smile:

@Avey777 It looks like downgrading dql isn't a complete fix for the full build (with all data sources), as there's one test that seems to be persistently failing anyway.
We might need to do some "bisecting" type of thing, and try with (for example) half of the libraries excluded (repeated a few times) to try and narrow down which library or libraries are causing the problem.
I'll take a better look at this later on.

The user requested cryptography==2.8
    pyopenssl 19.0.0 depends on cryptography>=2.3
    pysaml2 6.5.2 depends on cryptography>=1.4
    authlib 0.15.5 depends on cryptography
    snowflake-connector-python 3.0.2 depends on cryptography<41.0.0 and >=3.1.0

Maybe we can disable snowflake-connector-python 3.0.2 and then give it aty.

I has been try it
cryptography from 2.8 to 3.1.0,<41.0.0
This won't work.

Maybe we can disable snowflake-connector-python 3.0.2 and then give it aty.

Cool.  That one was removed in the last commit that I pushed.  I still haven't managed to get any sleep since yesterday, so I'm not really awake enough at the moment to do any serious thinking.  So, I'll probably pick this up again tomorrow. :smile:
Feel free to push changes to this branch to experiment with things if you want.


How to dismiss the pop window?

Thanks

There should be a dismiss method to do this.

Sorry I probably did something wrong, but I get:


Accessible generates methods return types as IO[E, A] instead of ZIO[R, E, A]

zio-macros version 0.4.0
@accessible generates capability accessors as IO[E, A] even if the service methods have ZIO[R, E, A].
E.g. in the test case zio.macros.access.ValidateAccessible the method
def get(id: Int): URIO[Example, String]                       = Example.>.get(id)

keeps compiling even with this signature
def get(id: Int): URIO[Any, String]                       = Example.>.get(id)

See tentative PR https://github.com/zio/zio-macros/pull/27. Proposed solution fails with scala 2.12 and 2.11, but seems to work for 2.13

Actually the https://github.com/zio/zio-macros/pull/27 doesn't work on  2.13 either (on CI, but I was able to compile locally). Feel free to close it if it is not useful at all.


Two slightly different background colors in editor (Same as Issue #12634)

Prerequisites

[x] Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[ ] Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
[ ] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[x] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[x] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Issue #12634 seems to be back on Atom 1.30.0, Mac OS 10.13.6 High Sierra.  Image is below.

Steps to Reproduce

Open Atom 1.30.0, Mac OS 10.13.6 High Sierra
Use a dark layout

Expected behavior:
Text displays with a single background color
Actual behavior:
2 slightly different background colours in one editor (dark and light grey)
Reproduces how often:
100%
Versions
Atom : 1.30.1
Electron: 2.0.5
Chrome : 61.0.3163.100
Node : v8.9.3
OS: Mac OS 10.13.6 High Sierra
MacBook Pro (Retina, 15-inch, Late 2013) (I know, it's old)
2.6 GHz Intel Core i7
16 GB 1600 MHz DDR3
NVIDIA GeForce GT 750M 2048 MB
Intel Iris Pro 1536 MB
Additional Information
FWIW, this happens on both my external display (apple 27") as well as my built-in retina display.

Thanks for the report!  If you update Settings > Color Profile to Use sRGB color profile, does that make any difference?

@rsese that does seem to have resolved the issue!  Thank you!

Great, glad this helped you both :+1:

Is this documented somewhere so others can find it? If not, could you use this ticket to update the doc?

The setting was introduced in 1.28 and we blogged about it:
http://blog.atom.io/2018/06/21/atom-1-28.html#support-for-custom-color-profiles
But I can see it being added to our debugging guide maybe:
https://flight-manual.atom.io/hacking-atom/sections/debugging/
Since the Flight Manual has its own repository, I'll close this and open an issue in https://github.com/atom/flight-manual.atom.io/ with the suggestion.  Pull requests welcome!

https://github.com/atom/flight-manual.atom.io/issues/486

Perfect, thanks so much!!


Update Web-Expensify references from master to main

We are migrating the default branch of Web-Expensify to main and we nee dto update those references
Details

Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/183738
Tests
No tests, it's only comments.
QA Steps
No QA.
Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Yes, there are a lot of PRs for Web-Expensify haha We have mentions in almost every repo

It's been approved so auto-merging

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @pecanoro in version: 1.1.14-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[v1.4.1 Added RecordFind, command usage message updates

Added new RecordFind command
Resolves #162
...more to come

Coverage decreased (-1.2%) to 71.925% when pulling f54f0098dc346c214447584c118053904e59a991 on kthSim:codeMods into 2e4775ee5b2205515c68b6b5105c067d46d6a6e4 on CS2103-AY1819S2-W17-2:master.


enhancement request: show app logs during standard cf push during app start

Command
e.g. cf push myapp

from a user (i think @tomwhoiscontrary) with experience working with cloud foundry and the cli:
Hi,

This is a bit of an idle thought.

'cf push' prints out the logs relating to the staging of the app. Would it be possible for it to continue to print logs after staging, as the app starts, until it finishes starting up? Not by default, but when given a --logs flag or something. I have no idea how cf push gets the staging logs, so i don't know if this is low hanging fruit, or would require a complete re-architecting. This would allow someone pushing an app to get faster feedback on how the start-up is going.

My motivation here is that we have a moderately complicated deployment process which sometimes fails, and rolls itself back when it does. When it rolls back, it deletes the apps it's just pushed, and in doing so wipes out the recent logs that CF stores. That makes it tricky to diagnose failed deployments. Being able to cf push --logs would let us collect all the crucial logging in the output of our deployment script.

Regards,
tom

we should consider whether we can think of a downside for showing the app logs by default as "cf push" without any additional arguments? one downside is that we currently show the app status as a cadenced log message. if we show the app logs, then we'd have to consider how to adjust the cli UX for that.

This sounds similar to #910, although you are suggesting to print them depending on setting a flag instead of on app start failure.
A concern I had with #910 that I haven't been able to validate yet is the risk of unintentionally & unexpectedly printing credentials or other sensitive information on cf push from those logs when users don't expect it - a flag could address that.
That said, with the upcoming run-task command we considered printing the task's logs to stdout but the feedback I got was that users prefer to run cf logs (or use existing tools like papertrail) to analyse the logs - we'll first release run-task without printing logs and reconsider when we get more user feedback.
What is the purpose of showing the logs at push in your view? How long would we show these logs for? Would cf push "hang" and tail the logs "for ever", or only for the time we're polling the app state until one of its instances has started?
Cheers,
Dies Koper
CF CLI PM

For the person you received that feedback from, why don't they just run cf push their app || cf logs theirapp --recent so they have the logs before they delete it?

i've asked tom to reply here

Original idle thinker here ...

What is the purpose of showing the logs at push in your view?

To make it simple to collect logging of application startup in our deployment script, so that we can diagnose failed pushes more easily.

How long would we show these logs for? Would cf push "hang" and tail the logs "for ever", or only for the time we're polling the app state until one of its instances has started?

I'd like it to show logs from each instance until it has started successfully.

why don't they just run cf push their app || cf logs theirapp --recent so they have the logs before they delete it?

That would be better than what we have now, that's for sure! However, we're using Spring Boot, which produces enormous amounts of logging, so logs --recent at the end of startup doesn't cover everything. We could do something like cf push & cf logs theirapp, but getting that right is mildly tricky - we have to retry cf logs until the app is created, then detect app startup and kill it, and even then we risk missing a bit of logging at the start. We could do it, but the CF CLI could do a better job of it.

Hi @tomwhoiscontrary
Thanks for joining!
It seems everyone has a use case that requires a new flag on cf push because the CLI could do it better, so we'd like to take our time validating it benefits enough people.
For the issue that your runtime produces too much logging and cf logs --recent could miss out, you could push with --no-start first to ensure the app exists, then run cf logs yourapp & before you cf start yourapp ; kill <cf logs's process>: no need to retry, no need to detect app startup, no missing a bit of logging, only need to look up how to reliably find the right pid on your platform (ps, lsof on the log file if you direct it to disk, etc.).
Please let us know how that goes - if it turns out that the behaviour doesn't satisfy completely, a --logs option wouldn't either..


Don't 500 error on unknown license values

http://openledger-dev.creativecommons.org/?search=puppy&licenses=cc0 returns a 500 error, because it's expecting the license string to be 'CC0' (all-caps). It shouldn't error on an unknown license, just drop it and warn in the logs.
(It should also try to capitalize the value since the lowercase value is used as a URL param elsewhere, like on the detail page.)

Fixed and deployed


Invalid Usage of NCCL Library

Trying to train tiny llamaon 4 P5.48xlarge instances and I see this error:
 0: [rank3]: torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/NCCLUtils.hpp:328, invalid usage (run with NCCL_DEBUG=WARN for details), NCCL version 2.23.4
 0: [rank3]: ncclInvalidUsage: This usually reflects invalid usage of NCCL library.

Library versions used:
FROM nvidia/cuda:12.2.2-devel-ubuntu22.04

ARG GDRCOPY_VERSION=v2.4.1
ARG EFA_INSTALLER_VERSION=1.37.0
ARG AWS_OFI_NCCL_VERSION=v1.13.2-aws
ARG NCCL_VERSION=v2.23.4-1
ARG NCCL_TESTS_VERSION=v2.13.10

Parallelism parameters used:
parallelism:
  dp: 4
  expert_parallel_size: 1
  pp: 2
  pp_engine: 1f1b
  tp: 4

Slurm submission script:
#!/bin/bash

# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: MIT-0

#SBATCH -N 4 # number of nodes to use, 24 p4d(e) = 192 A100 GPUs
#SBATCH --ntasks-per-node 8 # Number of GPU per node
#SBATCH --gpus-per-node=8 # number of GPU we reserve. Uncomment for AWS ParallelCluster
#SBATCH --job-name=huggingface # name of your job
#SBATCH --exclusive
#SBATCH --nodelist=p5-dy-gpu-[9-12]

###########################
###### User Variables #####
###########################

# default variables for Enroot
: "${DATA_PATH:=/fsxl/awsankur}"
: "${FSX_MOUNT:=$DATA_PATH:$DATA_PATH}"
: "${IMAGE:=/fsxl/awsankur/huggingface.sqsh}"

## Plenty of EFA level variables
export FI_PROVIDER=efa
export FI_EFA_FORK_SAFE=1
export FI_LOG_LEVEL=1
export FI_EFA_USE_HUGE_PAGE=0    # Set to 0 when you see os.fork() causes OSError: Cannot allocate memory.  Disabling huge page causes minor performance hit.
##export FI_EFA_ENABLE_SHM_TRANSFER=1
export NCCL_DEBUG=INFO

export CUDA_DEVICE_MAX_CONNECTIONS=1
# Trying to avoid hangs
export TORCH_NCCL_ASYNC_ERROR_HANDLING=1

declare -a ARGS=(
    --container-image $IMAGE
    --container-mount-home
    --container-mounts $FSX_MOUNT
    --no-container-remap-root
)

# Calculate total number of processes
export NNODES=$SLURM_NNODES
export GPUS_PER_NODE=8
export WORLD_SIZE=$(($NNODES * $GPUS_PER_NODE))

declare -a TORCHRUN_ARGS=(
    --nproc_per_node=$GPUS_PER_NODE
    --nnodes=$SLURM_NNODES
    --rdzv_id=$SLURM_JOB_ID
    --rdzv_backend=c10d
    --rdzv_endpoint=$(hostname)
)

### Nanotron specific
export NANOTRON_BENCHMARK=1
### Disable wandb
export WANDB_MODE=disabled

srun "${ARGS[@]}" -l torchrun "${TORCHRUN_ARGS[@]}" run_train.py --config-file examples/config_tiny_llama.yaml

issue.zip
Attaching Dockerfile, Slurm submission script and full output log in issue.zip

Get the same error for an older version of NCCL:
5: [rank12]: torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/NCCLUtils.hpp:328, invalid usage (run with NCCL_DEBUG=WARN for details), NCCL version 2.20.3
 5: [rank12]: ncclInvalidUsage: This usually reflects invalid usage of NCCL library.

Hi @awsankur !
From you logs you have
 1: p5-dy-gpu-9:1970263:1970590 [1] init.cc:783 NCCL WARN Duplicate GPU detected : rank 9 and rank 1 both on CUDA device 64000

which hints to the fact that multiple processes are trying to use the same GPUs.
It is likely caused by the way you launch you script via Slurm:
#SBATCH --ntasks-per-node 8 # Number of GPU per node

torchrun is responsible for launching one process per GPU on each node. Here the --ntasks-per-node 8 instructs Slurm to run the srun torchrun 8 times per nodes.
Can you retry setting:
#SBATCH --ntasks-per-node 1 # Only launch 1 torchrun process per node

?

I get Cuda OOM error when I try setting #SBATCH --ntasks-per-node 1 .
 Traceback (most recent call last):
0:   File "/workspace/huggingface/nanotron/run_train.py", line 233, in <module>
0:     trainer = DistributedTrainer(config_file)
0:   File "/workspace/huggingface/nanotron/src/nanotron/trainer.py", line 147, in __init__
0:     self.parallel_context = ParallelContext(
0:   File "/workspace/huggingface/nanotron/src/nanotron/parallel/context.py", line 55, in __init__
0:     self.set_device()
0:   File "/workspace/huggingface/nanotron/src/nanotron/parallel/context.py", line 133, in set_device
0:     torch.cuda.set_device(torch.cuda.device(device_id))
0:   File "/usr/local/lib/python3.10/dist-packages/torch/cuda/__init__.py", line 478, in set_device
0:     torch._C._cuda_setDevice(device)
0: RuntimeError: CUDA error: out of memory
0: CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
0: For debugging consider passing CUDA_LAUNCH_BLOCKING=1
0: Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.


Add a wiki: SCP Foundation

An anonymous user has submitted a new wiki via our submission form.
Link to origin wiki: https://the-scp.foundation/
Link to destination (independent) wiki: https://scp-wiki.wikidot.com/

Noting that the destination wiki is on Wikidot, which we haven't evaluated yet as a host.

Looks like a request to redirect what is basically an independent alternative frontend to the actual wiki it's pulling content from. Not really in the scope of this extension.


Category property export

Extend the Akeneo category export to contain the custom properties of this bundle.
Test Cases:
All tests should be run with both CSV and XLSX export.

Run the category export without defining any properties. The export result equals the result without this bundle.
Run the category export with some properties. The export now contains the custom properties

The custom properties are appended as columns to the exported files
The custom properies which are localized follow the same schema as the default label property of Akeneo (name-xy_XY)
Exported properties are written into the proper column

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d831f75). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
  Complexity      ?        35
========================================
  Files           ?         8
  Lines           ?        99
  Branches        ?         0
========================================
  Hits            ?        99
  Misses          ?         0
  Partials        ?         0

Flag
Coverage Δ

backend
100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d831f75...5dd0ca1. Read the comment docs.


Add support for file uploads

It would be cool to add a /post/upload endpoint, which returns the file size of the uploaded object.

Hi there. Any progress here?

Since this already exists, I'm inclined to close this unless there is some further clarification on why this needs to differ from /post.

This is indeed what /post was intended for.

It would be nice to have an <input type="file"> on http://httpbin.org/forms/post, so that we can easily test the file upload from a form.

no test upload?

This assumes that the upload content type is a standard multipart/form-data or application/x-www-form-urlencoded. What if you are trying to upload all sorts of stuff like application/x-tar... etc?


Can't find models.zip file in the provided google drive

Hi !
I can't seem to find the models.zip file, and the link in the download_model script seems to be broken, is there anyway you could reupload it ?
Thank you very much in advance!

Hi,
sorry for the inconvenience and thanks for pointing this out.
I reuploaded the models folder.

Thank you very much !


[BACKLOG-17069] Fixes clearing recent searches at startup AND avoids …

…displaying recent searches empty dropdown

@ddiroma Please Sir!...

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands
mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files
  plugins/file-open-save/core/src/main/javascript/app/app.component.js
  plugins/file-open-save/core/src/main/javascript/app/app.css
  plugins/file-open-save/core/src/main/javascript/app/app.html
  ui/src/main/java/org/pentaho/di/ui/core/PropsUI.java

Still Broken Tests:
org.pentaho.di.trans.steps.addxml.AddXMLMetaInjectionTest.test:
:red_circle: java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.addxml.AddXMLMetaInjectionTest.setup(AddXMLMetaInjectionTest.java:34)

:red_circle: java.lang.NullPointerException
java.lang.NullPointerException

org.pentaho.di.trans.steps.xmljoin.XMLJoinMetaInjectionTest.test:
:red_circle: java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.xmljoin.XMLJoinMetaInjectionTest.setup(XMLJoinMetaInjectionTest.java:36)

:red_circle: java.lang.NullPointerException
java.lang.NullPointerException

org.pentaho.di.trans.steps.xmloutput.XMLOutputMetaInjectionTest.test:
:red_circle: java.lang.NullPointerException
java.lang.NullPointerException
	at org.pentaho.di.trans.steps.xmloutput.XMLOutputMetaInjectionTest.setup(XMLOutputMetaInjectionTest.java:31)

:red_circle: java.lang.NullPointerException
java.lang.NullPointerException

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -2.02%:small_red_triangle_down:
Complexity Change: -2.13%:small_red_triangle_down:
Instruction Change: -.34%:small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change:  + .53%
Complexity Change:  + .56%
Instruction Change:  + .07%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .15%
Complexity Change:  + .18%
Instruction Change:  + .05%
Line Change:  + .08%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.28%:small_red_triangle_down:
Complexity Change: -.78%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 3.12%
Complexity Change:  + 3.16%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.ivwloader.IngresVectorwiseLoader

Branch Change: -.71%:small_red_triangle_down:
Complexity Change: -1.14%:small_red_triangle_down:
Instruction Change: -.55%:small_red_triangle_down:
Line Change: -.88%:small_red_triangle_down:

org.pentaho.di.trans.steps.ivwloader.IngresVectorwiseLoader.FifoOpener

Branch Change: -16.67%:small_red_triangle_down:
Complexity Change: -12.50%:small_red_triangle_down:
Instruction Change: -7.14%:small_red_triangle_down:
Line Change: -10.53%:small_red_triangle_down:
Method Change: -20.00%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 3.53%
Complexity Change:  + 4.05%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.rssinput.RssInputField

Branch Change:  + 2.27%
Complexity Change:  + 1.54%
Instruction Change:  + .29%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2.04%:small_red_triangle_down:
Complexity Change: -2.04%:small_red_triangle_down:
Instruction Change: -.32%:small_red_triangle_down:
Line Change: -.81%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change:  + 1.79%
Complexity Change:  + 1.19%
Instruction Change:  + .07%

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change:  + .17%

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change:  + .14%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/ui/src/main/java/org/pentaho/di/ui/core/PropsUI.java

:heavy_exclamation_mark: 'if' is not followed by whitespace. at Line: 1,224 Column: 7

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f pom.xml clean install && mvn -B -f pom.xml site

Cleanup Commands
mvn -B -f pom.xml build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/core/PropsUI.java

Newly Broken Tests:
org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization:
:red_circle: java.lang.RuntimeException
java.lang.RuntimeException: Error validating dateFormatLocale
	at org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization(TextFileInputMetaLoadSaveTest.java:167)
Caused by: org.pentaho.di.core.exception.KettleException:

Attribute dateFormatLocale started with value fi_FI ended with value en_US

	at org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.testSerialization(TextFileInputMetaLoadSaveTest.java:167)

Still Broken Tests:
org.pentaho.di.trans.steps.syslog.SyslogMessageConcurrentTest.concurrentSyslogMessageTest:
:red_circle: java.lang.Exception
java.lang.Exception: test timed out after 10000 milliseconds
	at org.pentaho.di.trans.steps.syslog.SyslogMessageConcurrentTest.createSyslogMessageTask(SyslogMessageConcurrentTest.java:119)
	at org.pentaho.di.trans.steps.syslog.SyslogMessageConcurrentTest.concurrentSyslogMessageTest(SyslogMessageConcurrentTest.java:67)

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.lifecycle.KettleLifecycleSupport

Branch Change:  + 8.33%
Complexity Change:  + 9.09%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change:  + 1.00%
Complexity Change:  + 1.41%
Instruction Change:  + .30%

org.pentaho.di.trans.step.StepMeta

Branch Change:  + .68%
Complexity Change:  + .58%
Instruction Change:  + .19%
Line Change:  + .26%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change:  + .31%
Instruction Change:  + .06%
Line Change: -.23%:small_red_triangle_down:
Method Change: -1.02%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -.91%:small_red_triangle_down:
Complexity Change: -.82%:small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%
Complexity Change:  + .40%
Instruction Change:  + .04%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.Trans

Branch Change:  + .10%
Complexity Change:  + .13%
Instruction Change:  + .09%
Line Change:  + .11%

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Instruction Change:  + .13%

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change:  + .14%


Allow chaining with Illuminate\Database\Eloquent\Builder->setQuery()

If setQuery() looked like this:
	/**
	 * Set the underlying query builder instance.
	 *
	 * @param  \Illuminate\Database\Query\Builder  $query
	 * @return  \Illuminate\Database\Eloquent\Builder
	 */
	public function setQuery($query)
	{
		$this->query = $query;

		return $this;
	}

it would allow me to turn this:
        $postsEloquentQuery = \Post::with([]);
        $postsEloquentQuery->setQuery($query);
        $posts = $postsEloquentQuery->get();

Into this:
        $posts = \Post::setQuery($query)->get();

Much better!

Close this and open a PR, could be accepted I think.


Unable to find dependencies for libconsole-bridge-dev

Hi,
I'm trying to use tf with my current project. I added  to the manifest.xml, then I run roshask dep. I receive the following message:
Looking for ["libconsole-bridge-dev"], dependencies of /home/bruce/catkin_ws/src/lab1
roshask: Couldn't find path to package (2) libconsole-bridge-dev

It seems that roshask cannot find the package "libconsole-bridge-dev", but this package clearly is installed.
I wonder if I'm doing something wrong or is there any workaround to this?

It seems that "libconsole-bridge-dev" is not a ROS Package. Thus it would not be on the ROS_PACKAGE_PATH, so roshask would not be able to find it. Try adding "libconsole-bridge-dev" to the list of ignoredPackages in roshask/src/Ros/Internal/DepFinder.hs:
ignoredPackages = ["genmsg_cpp", "rospack", "rosconsole", "rosbagmigration",
                   "roscpp", "rospy", "roslisp", "roslib", "boost", "libconsole-bridge-dev"]

Hrmph, is it worth trying to find a good way of differentiating these kinds of dependencies? This mechanism works, but doesn't scale very well. On the other hand, it doesn't seem to cause too much trouble, so maybe a hand-maintained list like this is most expedient. We could add some kind of whitelist that could be pulled out of a file (eg, roshask.ignore) so folks don't have to edit the code.