unhandled page event *page.EventDownloadWillBegin

What versions are you running?
The latest master branch

$ go list -m github.com/chromedp/chromedp
The latest master
$ google-chrome --version
78.0.3904.108
$ go version
go 1.9.7

What did you do? Include clear steps.
i wanted to download a file by clicking a button, but it throws an err.
i tryed to solve the issue writing "page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath("."),"but it didn't work
What did you expect to see?
download successful
What did you see instead?
err: unhandled page event *page.EventDownloadWillBegin
below is my code
func main() {
	dir, err := ioutil.TempDir("", "chromedp-example")
	if err != nil {
		panic(err)
	}
	defer os.RemoveAll(dir)

	headers := map[string]interface{}{
		"cookie": "session=d640ccf80c5859119524101d9905db15; csrf_token=7896178060",
	}

	opts := append(chromedp.DefaultExecAllocatorOptions[:],
		chromedp.DisableGPU,
		chromedp.NoDefaultBrowserCheck,
		chromedp.Flag("headless", false),
		chromedp.Flag("ignore-certificate-errors", true),
		chromedp.Flag("start-maximized", true),
		chromedp.UserDataDir(dir),
		chromedp.UserAgent("Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36"),
	)

	allocCtx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
	defer cancel()

	// also set up a custom logger
	taskCtx, cancel := chromedp.NewContext(allocCtx, chromedp.WithLogf(log.Printf))
	defer cancel()

	// create a timeout
	taskCtx, cancel = context.WithTimeout(taskCtx, 20*time.Second)
	defer cancel()

	err = chromedp.Run(taskCtx,
		network.Enable(),
		network.SetExtraHTTPHeaders(network.Headers(headers)),
		chromedp.Navigate(`https://<IP_ADDRESS>/alarmReport.html?anchor=head&_id=3&type=active#history`),
		chromedp.WaitVisible(`body > footer`),
		page.SetDownloadBehavior(page.SetDownloadBehaviorBehaviorAllow).WithDownloadPath("."),
		chromedp.ActionFunc(func(context.Context) error {
			fmt.Printf("body finish\n")
			return nil
		}),
		chromedp.Click(`//span[@class="export-pdf"][1]`, chromedp.BySearch),
		chromedp.Sleep(5*time.Second),
	)
	if err != nil{
		log.Fatal(err)
	}
}

Thanks, I was able to reproduce this with a simple program. I can fix the error; though I don't imagine it's causig any real bugs.

Thanks for your reply. This bug has been driving me crazy these days.
Waiting for your message!

I forgot to link the commit to the issue, my bad. This was fixed in bbc198126faffcdca2ed78ecddccda3f14c668d0.


Voxceleb dataset copy?

Anyone can kindly provide the voxceleb1 & voxceleb2 datasets?
It takes a huge amount of time to download & crop the video in this repo:
https://github.com/AliaksandrSiarohin/video-preprocessing
, and most of the link are broken.
Can anyone help?

任何人都可以提供 voxceleb1 和 voxceleb2 数据集吗？
下载和裁剪此存储库中的视频需要花费大量时间：
https://github.com/AliaksandrSiarohin/video-preprocessing
，并且大部分链接都已损坏。
有人可以帮忙吗？

Hello, have you solved this problem?Can you provide me with the data set?


Generate documentation

We want to work towards a release, so a simple documentation is needed. I guess only for users, not developers. Perhaps a few typical tasks are expected:

[ ] changing the solver
[ ] setting what is saved as output (how many dts are saved, we ourselves struggled with it a bit]
[ ] saving U at the bottom

Plotting doesn't need to be addresses because we have a separate repo for this, Cross-comparison. This will need to be tidied up a bit separately. This issue is related to #37

saving U at the bottom

Will be left out, see remark from PR #44 .

Let's make it pragmatic. What documentation system (for python) are you (most) familiar with, @HannoSpreeuw ?

No recent experience in writing user documentation, only developer documentation, in my case that just meant writings docstrings, sorry.
So I asked the colleague sitting next to me: Which documentation system would you use when writing a tutorial from scratch?
readthedocs, he replied and he especially liked a recent project where a Jupyter notebook was integrated in this documentation system.
Pls let me know how you feel about this.

But there are quite a few options available with e.g. GitBook and Doxygen being viable alternatives.

That is a nice example, but using a responsive format such as a notebook is applicable if there is an API, in our case user sets all the parameters in one script and then runs one command. For running one command, you don't need a notebook.
This is scientific, not utility software, so the users will engage with the code. So that's ok to only write developer documentation, but the current one is not sufficient. Docstrings can be the biggest part of it, but maybe you could move them a bit closer to PEP 257? As for the rest, I think I could try to list the tasks users (including future us) would typically try to do, but I need a week or so.
I think it is also ok if you don't want to write documentation.

After consulting @jhidding I will go for pdoc.

Looks as good as anything else; I imagined @jhidding would recommend entangled, but I guess there was a reason not to.

Entangled doesn't include a document generator (i.e. in CarboKitten this is Documenter.jl). The most used document generator for documenting Python projects is Sphinx, which has many options and extensions but is not so nice to work with. I've seen some projects that used MkDocs, but its API documentation generation is less than stellar. For smaller projects I have worked with pdoc which has a more minimalistic approach. It requires no configuration. Rather, it will read the doc-strings in your module and generate a documentation page from that. Combine that with sourcing an extensive README into that documentation and that's perfect for small projects (that are not written in Entangled 😀).

@jhidding The only thing that worries me now is the rendering.
Suppose I have this docstring snippet:
    Parameters:
    -----------
    solver_parms: dict
        Parameters about solver settings.
    tracker_parms: dict
        Parameters about the progress bar and time interval for storage
    pde_parms: dict
        Model parameters, which govern e.g. the physical processes, but
        also the discretization, such as the number of grid cells.

Then it gets rendered like this in the corresponding .html:
Parameters:

solver_parms: dict Parameters about solver settings. tracker_parms: dict Parameters about the progress bar and time interval for storage pde_parms: dict Model parameters, which govern e.g. the physical processes, but also the discretization, such as the number of grid cells.

i.e. it seems to be turned into one line of text.


5/31/2022 Publish

Docs Build status updates of commit 462c1b4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8277d6f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 00fb962:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-dns-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-monitor-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-redis-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-search-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-storage-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/security-keyvault-jca-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-starter-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/preview/resourcemanager-appcontainers-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-communication-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-confidentialledger-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-deviceupdate-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-dynatrace-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-education-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-imagebuilder-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-machinelearning-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-three-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-two-readme.md
:warning:Warning
View (azure-java-preview)
Details

This comment lists only the first 25 files in the pull request.

docs-ref-services/latest/cosmos-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-dns-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-monitor-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-redis-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'redis-cache'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-search-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-storage-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/security-keyvault-jca-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'keyvault'.
Line 159, Column 35: [Warning: file-not-found - See documentation] Invalid file link: 'resources/SignToPrincipal.png'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 70, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

docs-ref-services/latest/spring-cloud-appconfiguration-config-readme.md

Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'appconfiguration'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/spring-cloud-appconfiguration-config-web-readme.md

Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'appconfiguration'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3f2833c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-dns-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-monitor-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-redis-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-search-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-storage-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/security-keyvault-jca-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-starter-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/preview/resourcemanager-appcontainers-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-communication-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-confidentialledger-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-deviceupdate-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-dynatrace-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-education-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-imagebuilder-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-machinelearning-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-three-readme.md
:warning:Warning
View (azure-java-preview)
Details

This comment lists only the first 25 files in the pull request.

docs-ref-services/latest/cosmos-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 11, Column 1: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(11,1), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(11,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-dns-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-monitor-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-redis-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'redis-cache'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-search-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-storage-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/security-keyvault-jca-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'keyvault'.
Line 159, Column 35: [Warning: file-not-found - See documentation] Invalid file link: 'resources/SignToPrincipal.png'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 70, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d959ec2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-dns-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-monitor-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-redis-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-search-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-storage-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/security-keyvault-jca-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-starter-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/preview/resourcemanager-appcontainers-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-communication-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-confidentialledger-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-deviceupdate-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-dynatrace-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-education-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-imagebuilder-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-machinelearning-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/sdk-template-readme.md
:warning:Warning
View (azure-java-preview)
Details

This comment lists only the first 25 files in the pull request.

docs-ref-services/latest/cosmos-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 11, Column 1: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(11,1), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(11,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 11, Column 1: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(11,1), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(11,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-dns-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-monitor-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-redis-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'redis-cache'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-search-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-storage-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 18488a3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-encryption-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-dns-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-monitor-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-redis-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-search-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-storage-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-trafficmanager-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/security-keyvault-jca-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-appconfiguration-config-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-feature-management-web-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/spring-cloud-starter-appconfiguration-config-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/preview/resourcemanager-appcontainers-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-communication-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-confidentialledger-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-deviceupdate-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-dynatrace-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-education-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-imagebuilder-readme.md
:warning:Warning
View (azure-java-preview)
Details

docs-ref-services/preview/resourcemanager-machinelearning-readme.md
:warning:Warning
View (azure-java-preview)
Details

This comment lists only the first 25 files in the pull request.

docs-ref-services/latest/cosmos-encryption-readme.md

Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 11, Column 1: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(11,1), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(11,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'cosmos'.
Line 11, Column 1: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(11,1), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(11,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-dns-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-monitor-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-redis-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'redis-cache'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/resourcemanager-search-readme.md

Line 9, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'resourcemanager'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Change ref names to allow multiple open/close triggers

Suggestion

Update the refs name for components with open|close behaviors to allow adding multiple open|close triggers easily. This is currently working but with a warning The "close" ref has been found multiple times. Did you forgot to add the [] suffix to its name?

Solution
Switch the declaration from refs: ['open', 'close'] to refs: ['open[]', 'close[]'] for components like Modal, Panel
Questions

Will this cause breaking change ?
Should this be the go to way when implementing click behaviors with refs on components ?

Yes sure, i'll send a PR.
Do not have an opinion on refs vs component, you know the inner machine better, so i'll follow what you think is best

Fixed in #49 and released in 0.2.9.


Enabled rectilinear interpolation.

Implemented functionality that enables linear_interpolation_coeffs to return the coefficients for a rectilinear interpolation.
This involves a function _prepare_rectilinear_interpolation that converts a path of the form
[(t1, x1), (t2, NaN), (t3, x3), ...]

onto
[(t1, x1), (t2, x1), (t2, x1), (t3, x1), (t3, x3) ...]

such that linear interpolation on the modified path corresponds to rectilinear interpolation on the original path.
This is invoked by supplying the index of the channel dimension where your time values belong (usually time_idx=0) as follows
    rectilinear_coeffs = linear_interpolation_coeffs(x, rectilinear=0)

And that's that! Congrats on your first pull request :)


About 2D-skeleton

 Hello, I want to ask that does st-gcn work on 2D-skeleton?

Yes. See the Kinetics experiments using the OpenPose pose estimation as input.
https://github.com/yysijie/st-gcn#kinetics-skeleton


Add git hash to nuget package / assembly info

Do you want to request a feature or report a bug?
FEATURE
What is the current behavior?
Not easy to cross reference the CI build number ie alpha-102 to the specific git hash
What is the expected behavior?
The assembly informational version should have the git hash embedded as described here
https://stackoverflow.com/questions/15141338/embed-git-commit-hash-in-a-net-dll
What is the motivation / use case for changing the behavior?
easy to check if upgrading is a good idea by reviewing the git log

I agree. Let's do this.

@ghuntley Looked at this last night, AssemblyInformationalVersionAttribute is now part of the csproj format.  Cake.Incubator has the new csproj parser, and GitVersion will return the sha of the latest commit.  Going to attempt to get this working this week.  I'd assume that the same git hash should be used for each package?

I agree - every ReactiveUI assembly should be stamped with the sha from gitversion.  You'll need two approaches though as ReactiveUI uses the .NET CPS SDK project system AND the legacy project system (for WPF projects - reactiveui-wpf and reactiveui-events-wpf)
CPS
Check out the SDK over at
https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.GenerateAssemblyInfo.targets#L69-L70
In theory you should be able to do this:
            .WithProperty("InformationalVersion", $theShaFromGitVersion)

At https://github.com/reactiveui/ReactiveUI/blob/develop/build.cake#L203
Legacy (WPF)
Use https://www.cakebuild.net/api/Cake.Common.Solution.Project.Properties/AssemblyInfoAliases/A528A2DA with the $theShaFromGitVersion


Add Pratik Parmar to Contributors list

Hi  @prateek18597, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

It was helpful to understand how thing works.


gesture controlled snake game using opencv added

Related Issues or bug
gesture controlled snake game using opencv
Fixes: #326
Proposed Changes
gesture controlled snake game using opencv added
Additional Info
This program can be used to play a Snake Game (or like it) by detecting hand gestures to control movement of the snake on the screen. It has been implemented in Python using OpenCV library. Although, the demo shown here refers to playing a Snake Game, it can be used to play any game or control any application using hand gestures only. This program shall be used to play a Snake Game by detecting hand gestures to control movement of the snake on the screen. It has been implemented in Python using OpenCV library. Although, the demo shown here refers to playing a Snake Game, it can be used to play any game or control any application using hand gestures only.
Screenshots

@17arindam are you done with making PRs😂


[TextField] Replace underline content text with nbsp

Due to a few comments that were made about the pseudo element text being visible from this pull request https://github.com/mui-org/material-ui/pull/11181, I am going to change the text to a non-breaking space.  This will prevent color styles from showing the text, reduce the content size, and enable the removal of having to set the color to transparent.

Thanks


query_msg_for__empty.json: Weird file name and value in title

This problem doesn't exist in v0.17.0 anymore, since there is now only one schema file for cw721-base. Though it is worth checking why cargo schema creates this file, with title QueryMsg_for_Empty in line 3: query_msg_for__empty:
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "title": "QueryMsg_for_Empty",
  "oneOf": [
    {
      "description": "Return the owner of the given token, error if token does not exist Return type: OwnerOfResponse",
...

This causes ts-codegen not being able to create ReadOnlyClientInterface (since it doesn't find QueryMsg). Check issue here: https://github.com/CosmWasm/ts-codegen/issues/120

The reason it creates this file is that QueryMsg implements generics, i.e. QueryMsg<QueryExtension>, in cw721-base there is no query extension so the value is QueryMsg<Empty> which leads to query_msg_for__empty.json. Make sense?


E2E Transfer Eureka Test Happy Path

Create a happy path of transfer using the eureka protocool. send -> receive -> acknowledgement. Ensure that denomination is created as expected with the client-id.

@bznein is any of this covered in the work you have been doing?

@bznein is any of this covered in the work you have been doing?

Yeah I think this is covered by our tests cc @chatton

Covered in https://github.com/cosmos/ibc-go/pull/7524


chore(tests): add scripts for running browser tests against global builds

Description:
Add scripts for building specs including global builds (Rx.js
and Rx.min.js) instead of cjs builds, so that these packages can
be regression tested in browsers.
Related issue (if exists):
Closes #2229
Caveats:
Running against global builds crashes few tests, because there are conflicts between global and cjs codebases. For example some tests check if returned values are instanceof some internal Observable (say, GroupedObservable) which is not exported in global build. Since cjs and global are two different codebases, such checks fail.

few notes:

travis config running saucelabs should point new browser testing, need check if it passes correctly
existing browser testing may need to be removed
test_browser script need to be updated

Coverage remained the same at 97.644% when pulling 5bb599282e4ca086dab9d4bf28547b1fadb34564 on Podlas29:global-test-build into e38711379f357f55290ead7fabcf8c70c5b31961 on ReactiveX:master.

Coverage remained the same at 97.644% when pulling 6c3b2e738d9e57fe0e83d0334b1d1146813a942c on Podlas29:global-test-build into e38711379f357f55290ead7fabcf8c70c5b31961 on ReactiveX:master.

I'm marking it for reviewing now, though change itself won't impact semver. May need to run couple of saucelabs test, etcs etcs.

Coverage remained the same at 97.644% when pulling 338241fc67f775b46ac2cb63d81363f52a65c5e8 on Podlas29:global-test-build into e38711379f357f55290ead7fabcf8c70c5b31961 on ReactiveX:master.

I think this is now really outdated, since testing strategies have changed since having to add rxjs-compat and others. We can probably just close it. But we do need to re-explore browser testing in the near future.


Changed the system requirements link to the latest one provided by Yajie

sorry to close, but this PR has too much accumulated changes that are actually already merged.


Not getting Playlist song list

@CodeDotJS  Right now, I have faced an issue with getting the video list from playlist id (also use same in the description)
{ data: { name: '', playlist: [] } }

@lefuturiste can you please show me the code?

@CodeDotJS I'm using simply your description code with browserify module. It worked yesterday. but right now not.
ytlist(url, ['id', 'name', 'url']).then(res => {   console.log(res.data);   /* Array   [ { id: 'bgU7FeiWKzc',     name: 'Singleton Design Pattern - Beau teaches JavaScript',     url: 'https://youtube.com/watch?v=bgU7FeiWKzc',     isPrivate: false },   { id: '3PUVr8jFMGg',     name: 'Observer Design Pattern - Beau teaches JavaScript',     url: 'https://youtube.com/watch?v=3PUVr8jFMGg',     isPrivate: false },   { id: '3pXVHRT-amw',     name: 'Module Design Pattern - Beau teaches JavaScript',     url: 'https://youtube.com/watch?v=3pXVHRT-amw',     isPrivate: false },   { id: 'KOVc5o5kURE',     name: 'Mediator Design Pattern - Beau teaches JavaScript',     url: 'https://youtube.com/watch?v=KOVc5o5kURE',     isPrivate: false } ]    */ });

Hi I have the same problem in my Code and on RunKit too

I can also confirm this, my theory is that the disable_polymer parameter is no longer working. I tried to tweak the selectors but in the HTML markup, the elements are no longer there. They are however in window.ytInitialData.
To fix it for my use case I created my own scraper here, the response is similar to this library, but the API is not: https://github.com/Aidurber/youtube-playlist-scraper
Most of the magic is here: https://github.com/Aidurber/youtube-playlist-scraper/blob/master/src/parseInitialData.ts#L19-L26
Since there are a number of users depending on this library, I think it would be easy enough to port/add a fallback to ytInitialData scraping.


⚠ Bofrost.at has degraded performance

In 977352a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1538 ms

Resolved: Bofrost.at performance has improved in 328cb5f after 13 minutes.


Use is not syntax and remove unnecessary parentheses

PR Summary
Instead of the huge changes in #13286, a more modest change using is not syntax to remove parentheses.
PR Context
#13286
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@daxian-dbw Can you restart CI?

It appears Codacy (SonarCSharp) does not understand C# 9 pattern matching.

/azp help

/azp list

It looks like the same test is failing across all platforms, implying a regression. In that case, I think it's safer for us not to take this change

/azp run

I have fully reviewed this PR and it is now ready to merge as far as I am concerned.

@PoshChan Please remind me in 1 hour

@daxian-dbw, this is the reminder you requested 1 hour ago

this "is not "syntax make my build failed using visualstudio2019

@baosj0 You need to use Visual Studio 16.7 Preview, I will open a PR to update documentation.

@baosj0 You need to use Visual Studio 2019 16.7 Preview (link), I have opened a PR to update build documentation (#13336).

yes , no problem now


Include schema with file://

Hey,
I am trying to include a different schema, that should be reused in multiple schemas. Something like
{
    "$schema": "http://json-schema.org/draft-04/schema#",
    "type": "object",
    "additionalProperties": true,
    "allOf": [
        {
            "$ref": "file://request.json"
        }
    ]
}

The problem is the FileGetContents.php file is not able to find the schema (tried with file://./request.json as well) unless I specify the full path e.g. /var/www/html/foo/bar/request.json.
Is it possible to reference a schema in the same directory?

Take a look at the code sample in README.md file.

SchemaStorage wont help here, the error comes from JsonSchema/Uri/Retrievers/FileGetContents.php  which SchemaStorage uses as well.
What I would need is for FileGetContents retriever to look for the schema in the same directory as the checked schema.
I tried to set my own retriever in validator but it still keeps using the original one

So, I managed to set my own retriever directly in schema storage and it works. Thanks


Merge MongoDB Support from qliam's fork

Sorry, had a brain fart when trying to merge your commits into my own fork.


Couple of changes in WGSL layer

Pull Request Template
Checklist

[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
The changes are issues identified during #1173
Changes
Fixes a couple of edge cases with sum/reduction WGSL layer.
Testing
"run-checks all"
TBD

[ ] squash the commits not related to this PR
[ ] macro for approx_eq

I assume this PR is blocked?


BackButton

Goes on Titlebars, I think. @lesliearkorful

Yeah it's in the UI kit

Our Scaffold should imply a BackButton like the Material Scaffold does

I guess this is a duplicate of #85, since the backbutton is just an icon button with a function that returns to the previous screen

Nah, BackButton is a dedicated widget because it has a default action and also has a different spec


Color scheme up to CCSU Standards / ARIA Compliant.

Will need to try to find what the CCSU Color standards are.
There is some websites out there where you can copy + paste your code such as HTML Validator, CSS Validator, ARIA Validator, etc to make sure that it is compliant for people with disabilities. I will link these sites when we get closer to time for this story.

As of 11/14 @vinny2001 has started implementing CCSU/ LALCC logos, accessibility standards, and UI/ color schemes as per the following document:

ARIA Compliance will be added/ tailored in future updates

As of today, I added ARIA compliance changes to all HTML files, improving their accessibility standards.


Clustering: Allow configuration of ClusterManager Algorithm

In our project we are using clustering with Maps Compose using MapEffect. We would like to use the new Clustering() composable instead, but since we cannot find how to override the Algorithm for the ClusterManager (NonHierarchicalDistanceBasedAlgorithm#maxDistanceBetweenClusteredItems) we cannot migrate yet.
Is there currently a way to do this?
A solution could be to provide a parameter renderer to the Clustering composable.

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.
@philip-segerfast Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

Allowing us to pass in the clusterOptions object such as:
const clusterOptions = {
  gridSize: 30,
  zoomOnClick: false,
  maxZoom: 10,
};

could help with this (from this doc: https://cloud.google.com/blog/products/maps-platform/how-cluster-map-markers)

A temporary solution could be to provide a ClusteringEffect composable similar to MapEffect where the underlying ClusterManager is exposed.
This would allow us to use the full capabilities of the ClusterManager.

This would also help resolve crashes due to #309

There's still no way of configuring the ClusterManager algorithm though?
How am I supposed to specify a clusterRenderer without having access to the ClusterManager, since DefaultClusterRenderer requires the related ClusterManager as a constructor argument.
Am I missing something? Can someone show a code sample for how to override the ClusterManager Algorithm?
Also, if you specify a clusterRenderer, clusterContent and clusterItemContent aren't used.
I'm suggesting a simple algorithm field to the Clustering composable.


Version number not correctly reported

Describe the bug
Running cargo-make --version just prints out cargo and not the actual version. I have so far only tried this with v0.27.0 on Mac, and am not sure if it has been fixed in master or for other platforms.
To Reproduce
Run cargo-make --version.

i think you meant to do cargo make --version no?

you can also checkout:
https://github.com/sagiegurari/cargo-make#cli-options

i think you meant to do cargo make --version no?

Ah, ok, I see now. So running cargo-make make --version prints out cargo-make 0.27.0 as I was expecting. I found this confusing because running cargo-make --help claims that there is a --version switch which would print out the version, and it only prints out cargo.
I guess this option should be removed, then?
Please forgive my ignorance with these tools; I'm not terribly familiar with cargo or cargo-make, and am installing this tool on behalf of some other developers who need it in our CI infrastructure.

so i'm using clap which generates that help docs. i'm not that fond of it but it does most of the job right.
you do have another binary which is makers that you do not need to call cargo first.
so you can do makers --version
makers and cargo-make do the same job just makers doesn't require that cargo prefix....

closing this one, but feel free to open new issue if you have any trouble.

No problem, thanks for the clarification @sagiegurari!


Fix bug for webhook and feishu caused by API changed.

Just found the type on webhook table has some spaces so that webhook cannot be fired correctly.
This also fix feishu webhook since the API changed. fix #13858, #13907

Codecov Report

Merging #13937 (589279b) into master (c11cf4b) will decrease coverage by 0.00%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##           master   #13937      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%
==========================================
  Files         710      710
  Lines       77232    77207      -25
==========================================
- Hits        32604    32589      -15
+ Misses      39264    39243      -21
- Partials     5364     5375      +11

Impacted Files
Coverage Δ

services/webhook/feishu.go
0.00% <0.00%> (ø)

models/webhook.go
69.06% <100.00%> (+0.09%)
:arrow_up:

services/webhook/webhook.go
53.46% <100.00%> (ø)

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

modules/notification/ui/ui.go
93.05% <0.00%> (-2.78%)
:arrow_down:

models/notification.go
66.25% <0.00%> (-0.99%)
:arrow_down:

models/error.go
38.49% <0.00%> (-0.82%)
:arrow_down:

services/pull/pull.go
40.68% <0.00%> (-0.50%)
:arrow_down:

modules/notification/mail/mail.go
39.08% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11cf4b...589279b. Read the comment docs.

make lgtm work

According https://github.com/go-gitea/gitea/issues/13907#issuecomment-743270005, it seems it still not resolve the problem. Wait until I confirm that.

According #13907 (comment), it seems it still not resolve the problem. Wait until I confirm that.

@lunny sorry had red it to late


[WIP] Restructuring pycobra

Overhauled pycobra's structure to now make it scikit-learn compatible.

Merging PR - changes include setting up travis and restructuring pycobra.
Will release a version 0.2.0 to accommodate the restructuring.


Webview_flutter File Download not working

File download not working in Webview_flutter (from Flutter Team). In fact, also not working in webview plugin (from the flutter community).
What should we do to implement this funcionality?

Hi @premy
this is the webview_flutter first party plugin,
could you please provide your updated  flutter doctor -v
and a minimal code sample to reproduce the problem?
Thank you

@iapicca webview_flutter has the same issue. As described here: https://github.com/flutter/flutter/issues/39321
I believe this issue is a duplicate, but in general this is a needed capability and is currently not present.

Hi @premy
as @walsha2 pointed out (thank you)
there's an open issue addressing the case you described.
Please follow up on that issue,
I'm closing the current one as duplicate.
If you disagree please write in the comments
and I will reopen it.
Thank you


[FEAT] Add unit test coverage tracking

Describe the feature
We have a few unit tests with bun but need a better idea of our test coverage.
We currently use bun-test for our unit test. Seems like Bun has some good options for test coverage tracking. Could you add some automatic test coverage options (even just a command in our package.json) or configuration? Up to your research on what is the best, most sustainable approach.
The end goal is to have an easy way to see our test coverage so that we can improve.
https://bun.sh/docs/test/coverage

@Kitenite I would like to work on this issue!! would u mind giving some more info regarding the issue

Hey @vr-varad ,
Great! I will assign this to you. We currently use bun-test for our unit test. Seems like Bun has some good options for test coverage tracking. Could you add some automatic test coverage options (even just a command in our package.json) or configuration? Up to your research on what is the best, most sustainable approach.
The end goal is to have an easy way to see our test coverage so that we can improve.
https://bun.sh/docs/test/coverage

@vr-varad how's it going? Do you need any support on this?

Almost Done, being in college was stuck with exams will make a pr by tomorrow @Kitenite hope u understand


[Feature request] make lnurl payable with a fiat amount

https://t.me/decentraleyes: when i pay<EMAIL_ADDRESS>via pASTE REQUEST/READ  it asks for sats however i want to be able to enter a FIAT amt. can someone point me to the area of code that i could chane to make that happen? or could i Pay someone to make that change? If someone needs 1000 pesos its too darn hard to figure out how many sats taht is
there is a bounty. :)

This mockup was shared by dni on Telegram.
I think it is fine, I just suggest we also add amount in satoshi (circled in red) when paying not in satoshi but with fiat amount.
We need to compute this value anyway, because we need to check whether it fits within the requested range, so we could as well show it (and we should).

hm, i dont know, i agree it would be better to preview that sats, but i am not sure if we have rates on the frontend?
rn, i am doing it on the fly before request the lnurl invoice.

but i am not sure if we have rates on the frontend?

If that turns out to be complicated, we might merge PR https://github.com/lnbits/lnbits/pull/2136 first and improve upon that in some future PR.


OpcTwin module doesn't stop trying to connect to an invalid OpcUa server when asked to browse.

Is your feature request related to a problem? Please describe.
When sending a "Browse_V2" direct method request to an OpcTwin edge module containing an invalid Opc Ua server address, it will retry connecting after a 5 second timeout until the edge module is restarted. This is not a big problem but if the logs from OpcTwin are collected, this will cause a lot of redundant data.
Tested versions:

2.7.206
<IP_ADDRESS>

Sample request:
{"endpoint":{"url":"opc.tcp://opcplcfake:50000","securityMode":2,"securityPolicy":http://opcfoundation.org/UA/SecurityPolicy#Basic256Sha256},"request":{"nodeId":http://microsoft.com/Opc/OpcPlc/#s=Telemetry,"direction":0,"maxReferencesToReturn":0}}

Logs:
[14:47:16 INF Root] Starting module OpcTwin version <IP_ADDRESS>.
[14:47:16 INF Root] Initiating prometheus at port 9701/metrics
[14:47:16 INF Root] Prometheus metric server started.
[14:47:16 WRN Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] Bypassing certificate validation for client.
[14:47:16 INF Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] Running in iotedge context.
[14:47:17 INF Microsoft.Azure.IIoT.Module.Framework.Client.IoTSdkFactory] 0: Module saschac-dev_opctwin reconnected due to Connection_Ok.
[14:47:17 INF Microsoft.Azure.IIoT.Module.Framework.Hosting.ModuleHost] Initialize device twin for saschac-dev - opctwin

[14:47:17 INF Microsoft.Azure.IIoT.Module.Framework.Hosting.ModuleHost] Applying initial desired state.
[14:47:17 INF Microsoft.Azure.IIoT.Module.Framework.Hosting.ModuleHost] Reporting currently initial state.
[14:47:17 INF Microsoft.Azure.IIoT.Module.Framework.Hosting.ModuleHost] Module Host started.
[14:48:29 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Session created.
[14:48:29 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Creating session via opc.tcp://opcplcfake:50000.
[14:48:29 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:29 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Connecting to opc.tcp://opcplcfake:50000 changed from Connecting to NotReachable
[14:48:29 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 1329 ms...
[14:48:31 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:31 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 3853 ms...
[14:48:35 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:35 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 5000 ms...
[14:48:40 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:40 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 5000 ms...
[14:48:45 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:45 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 5000 ms...
[14:48:50 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:50 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 5000 ms...
[14:48:55 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Error establishing a connection: BadNotConnected creating session via opc.tcp://opcplcfake:50000 - retry.
[14:48:55 INF { name: "bdd88531-08c7-41de-b6d5-11213b5af726", sessionId: 2, url: "opc.tcp://opcplcfake:50000" }] Try to connect via opc.tcp://opcplcfake:50000 in 5000 ms...
<<< will go on forever >>>

Describe the solution you'd like
It would be great if a number of maximum retries could be set in an env var when starting the OpcTwin module. Also, probably a default maximum number should be set if no value is provided.
Describe alternatives you've considered
No alternatives considered.
Additional context
No additional context.

Thanks @TechPreacher, you are correct, the retry is expected, and the retries should stop after some time, but that time is not configurable. Also we had feedback about the logging strategy before, including allowing configuration of trace level for area, etc. and we believe that makes sense.  I am tagging it as feature request and happy to take contributions here.


Add general rate limiting rule

Add a general rate-limiting rule to complement our post-request rate-limiting rule.
Investigation is required to determine an appropriate cutoff value.

@wmoussa-gc This ticket could probably be closed once you have merged https://github.com/cds-snc/forms-terraform/pull/646


Multiple plugin windows support

Is your feature request related to a problem? Please describe.
Currently plugin supports only one window, we need to support for multiple plugin windows to show and compare different diagrams.

Duplicates #200


“T[][] is not assignable to Iterable<[T, T]>” while it is (at compile time)

TypeScript Version:
1.8.9
Code
new Map<number, number>([1, 2].map(x => [x, x]));

// Error:
// Argument of type 'number[][]' is not assignable to parameter of type 'Iterable<[number, number]>'…

Expected behavior: types are inferred correctly, no error shown.
Actual behavior: type error.

I think this issue is related to #6574

Thanks, yes, same problem, a dupe. Should I close this one?

It would be nice if contextual types allowed to infer an array as a tuple, to support such an idiom.
@FranklinWhale I don't think #6574 is related. If #6574 was fixed, the inferred type would be Iterable<number[]> which would still be a problem. This issue is about inferring [x, x] as a [number, number] instead of number[].

I don't mean that this issue is a duplicate of #6574, but they are both related to array to tuple inference. I am sorry if any confusion has been caused.
To be clear:
In #6474, T[] may be a tuple of T.
In this issue, T[][] may be an array of tuples of T.

#6574 is about inferring Tuple<T>.map<U>()'s result as a Tuple<U> instead of Array<U>. It says nothing about inferring array literals as tuples (notice that it starts with explicit annotation for the tuple), whereas this issue is about inferring array literals as tuples. I.e., if [x, x] was inferred as a [number, number] instead of number[]
Hence my point that they're not related.

That's not really the case. In @elbarzil's code sample in #6574, [1,2] in [1,2].map(x=>x+1) is actually a number[], and the map function also returns a number[]. It is actually the same as assigning an array created from an array literal to a varible declared as a tuple. Therefore, #6574 will be fixed when any array may be inferred as tuple when there is an matching tuple declaration.

See also #3369


Add Scamper to "Tools"

As a user I want to open Scamper from the tools tab in the menu bar.
predicted: 3

Acceptance Criteria:

[ ] In the toolbar should be a working scamper button


changed_attributes is deprecated in Rails 5.1

changed_attributes is deprecated in favor of saved_attributes.
When I updated my project to Rails 5.1 I started seeing this:
DEPRECATION WARNING: The behavior of `changed_attributes` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_changes.transform_values(&:first)` instead. (called from update_funding_caches at...

The stack-trace included a reference to this:
https://github.com/elastic/elasticsearch-rails/blob/2.x/elasticsearch-model/lib/elasticsearch/model/proxy.rb#L65
I'm not sure how to cleanly resolve this without modifying elasticsearch-model.

Ya, you can see the approach I took here:
https://github.com/jkeam/elasticsearch-rails/commit/e3a764b28a48c197d0167cd17bf2e4588434bddf

From my point of view @jkeam's code looks fine. @jkeam, could you open a pr so this can be discussed with the maintainers of this gem?

Good call.  Opening a PR now.

Hi all, and especially @davedash, please accept my apologies for not solving this problem sooner.
I've spent some time with @jkeam's and @Geesu's patches, and I think we have a solution in 7815039 which solves the problem with Rails 5.1 and keeps the compatibility with older Rails versions.
I'll close this issue for now, if it's OK, can you please re-open or open a new one if the problem persists?

@karmi Thanks for fixing this.  We ended up running into a lot of little issues in general (not just ES related) when trying to upgrade to 5.1 for our project, that we just settled for 5.0.x.  But I'm glad that this won't be a blocker.

Agreed, thanks so much @karmi and everyone else that helped with this issue.

Thanks for the info, @davedash, and good luck with the upgrade!


Incorrect x87 fstp lifting/evaluation

Binary Ninja Version: 2.0.2154-dev, 458b33a9
Platform: Windows 10 Version 1903
fstp seems to get evaluated as
TEMP ← ST(0);
PopRegisterStack;
DEST ← TEMP;

instead of
DEST ← ST(0);
PopRegisterStack;

Which causes the following code
fld dword [ecx]
fld dword [edx]
fadd st1
fstp st1
ret

To become
*arg2
return fconvert.t(*arg1)

instead of
return fconvert.t(*arg1) + fconvert.t(*arg2)

The LLIL lifting for fstp is done correctly. The error occurs in the MLIL lifting. Need more investigation on this.

After a bit more investigation this seems to be a LLIL SSA conversion bug, which only exhibits itself on linux. On Mac and Windows the SSA is properly generated.

I double checked, and I seem to be getting the same LLIL SSA on windows and linux (and so the same problem), if that's what you mean?
5 @ 00000006  x87#4[2 + top#2] = x87#3[0 + top#2] @ x87#3 ; I guess this should be `x87#4[1 + top#2] = ...` ?
6 @ 00000006  __free_slot(x87#5[0 + top#2]) @ x87#4
7 @ 00000006  top#3 = top#2 + 1

Actually I miss spoke macOS is the only one that actually has the correct result.


Shall we set up a /force2018 repo now?

That could help us keep track of issues that need to be tackled for next year.

I just went ahead and created it: https://github.com/force11/force2018 .


git+ssh: the git URL based on ssh starts with git@

ssh access to git repository is not using URL based on ssh:// but with git@github.com:name/repo or git@gitlab.com:name/repo
This is true for github and gitlab.
This is needed to support git private repositories.

ssh access to git repository is not using URL based on ssh:// but with git@github.com:name/repo or git@gitlab.com:name/repo

The issue is your formatting; git just uses the format that the underlying ssh does. The correct invocation you're looking for is -m git -U<EMAIL_ADDRESS>-- mainly, note the : -> / swap. Hardcoding the git@ user at something to identify is likely not what we want to be doing here, but documenting the difference in how people use git vs. what poudriere wants (valid URI).

Hi Kyle, thanks for the answer.
I know that poudriere would accept a different formatting.
The git@ is not MY formatting, it's what Github and Gitlab provides and git supports it, while poudriere is the only tool I know where I need to change it.
Yes, you can improve the documentation, but from a user prospective, I miss the point to not just accept this very popular and vastly adopted formatting

The main thing that I take exception with here is the hardcoded user. This should instead match a generic : type pattern and assume it's ssh in the face of no other spec, because there's many times where the server side user will not be git and times when it will be omitted entirely. The minimum you need is a host name and a path, and you can't assume the format of either.

You should probably match *://* before it so you can complain about an unknown protocol.

The user is hardcoded and this is the way ssh works for Github and Gitlab.
This patch has the only purpose to recognize the format provided by Github and Gitlab for ssh, not to replace the current ssh:// URL format, that I agree is preferable, but not provided by those 2 popular providers.
For the poudriere repo, Github provides this: git@github.com:freebsd/poudriere.git
If you want to restrict the purpose, I can refine the match to git@*:* , but there is no:// to match.
We can even go to git@git*:* to be more specific on the intention to support Github and Gitlab and not other generic cases

The user is hardcoded and this is the way ssh works for Github and Gitlab.
This patch has the only purpose to recognize the format provided by Github and Gitlab for ssh, not to replace the current ssh:// URL format, that I agree is preferable, but not provided by those 2 popular providers.
For the poudriere repo, Github provides this: git@github.com:freebsd/poudriere.git
If you want to restrict the purpose, I can refine the match to git@*:* , but there is no:// to match.
We can even go to git@git*:* to be more specific on the intention to support Github and Gitlab and not other generic cases

I think you're misunderstanding what I'm saying. This is specifically what I'm recommending in lieu of this patch and what I would advocate for; tack these two cases on to the end, between file:// and the catch-all:
*://*) err 1 "Invalid git protocol" ;;
*:*) METHOD="git+ssh" ;;

So we can catch absolutely bogus things (protocol) while still passing the ssh-looking specification through to ssh to let it reject it instead if it wants to. This solves the problem not just for you, but also for me and everyone else with different circumstances.

Yes, I misunderstood what you were saying (the 'before' part).
I'll rework the patch as soon as possible.
Thanks


ci(repo): Update CI flow; Integrate Turbo caching [SDK-854]

Description

Fixes various CI caching issues.
Applies Turborepo caching to CI.

Enables substantial speed increases.

NOTES:
This PR removes the original checks workflow while leaving the rest intact. Follow-up PRs will address the remaining workflows and ensure they're utilizing the same steps/composite actions.
Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[x] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[x] build/tooling/chore

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


usage of rom0:FONTM makes nhddl incompatible with DESR models

I know DESR models are a small userbase, but this might be another incentive to switch to a TTF Font?
https://github.com/pcm720/nhddl/blob/64d5d68aa91cc15c8ab053e0cd3937725c257f6a/src/gui.c#L72

Apart from it not incompatible with DESR models, I also don't like how FONTM looks.
I agree that the whole font rendering needs a rework.
It's something I'd like to do, just not sure when I'll have the time to do it.


[QHC-619] Update Runcard to QUA config flow to support opx1000

@fedonman @jordivallsq @jjmartinezQT for solving the documentation issues that this PR is having,
I created this other PR: https://github.com/qilimanjaro-tech/qililab/pull/758, take a look and if we merge it to main, the ones here should disappear 👍


fix: make streaming test react code more idiomatic

Moves token/fetching logic into react component
Use React helpers like useCallback and useMemo for state/lifecycle management
Render DOM element containers with IDs for selenium to wait for instead of sleeping
Report fetch/DOM errors using aforementioned DOM elements to report through to mocha
Core formatting

So I noticed the pipeline wasn't running successfully, and tried cloning your branch to debug locally
It might have to do with this

Despite the CSP error, you can still send a message and receive an echo, but in the pipeline it does also check for console errors
Do you know where else styling could be popping up? I tried editing the add-nonce script, to add nonce to index.html like so
<link nonce="a1b2c3d" href="/static/css/main.2ae47eeb.chunk.css" rel="stylesheet">
However even with that there, it still is throwing that CSP error

@Zerryth I was close but stopped debugging at the end of day. Planning to pick it back tomorrow. Thanks for the advice!

@joshgummersall I think we were on this version of Web Chat because there were some DOM/V-DOM changes being discussed in Web Chat. @Zerryth do you remember the specifics of why we were pinned to this version?

Not sure why I can't respond to this directly as a thread, but yes, we pinned to a specific WC version, per William's suggestion, b/c of potential DOM changes that could occur in the future. Currently the test grabs specific WC elements to pull out the text from the chat bubbles, but if the DOM changes, we might have to traverse differently to grab the text to assert echo

That could actually explain the test failures at the moment - I'll revert to the pinned version.

Awesome! Things work :)
@joshgummersall could you make sure to edit the directory you're working in when running rm -rf botframework-streaming to  $(ReactProjectDir)/node_modules/botframework-directlinejs/node_modules, so that we actually delete botframework-streaming folder? Because it seems like it's still resolving to bf-streaming 4.10.3, if it's not deleted
npm list

Done for my comments. Will let @stevengum and @Zerryth drive.


[master] Bump Mesos to nightly master 5f4c7d6

High-level description
This is a routine bump to the latest Mesos and mesos-modules.
Related JIRA Issues
Checklist for all PRs

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Changelog:
https://github.com/apache/mesos/compare/e65ab60bff4b1b7d4dc9fd892dd632f0d5d57083...5f4c7d696c7fb812f4926b1ae217957ba4b354eb

[ ] Test Results: [link to CI job test results for component]

[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot bump-ee

Closed in lieu of https://github.com/dcos/dcos/pull/3904


CSS MVP: Identify Requirements and Prep for CSS in AWS Open Data Registry

💡 Description

[ ] reach out to SMD CSDO to understand what needs to be done here (@jordanpadams)
[ ] TBD

Reached out to CSDO and they have an agreement with AWS to allow some data sets into the registry, but per their recommendation, we should just pursue the submission on our own. Process is defined here: https://github.com/awslabs/open-data-registry/

📆 October status: In work. On schedule.

New internal wiki page has been created for that.

📆 November status: Working ongoing. On schedule

📆 December status: Increased scope to complete full onboarding process for AWS Open Data Registry vs. initial scope to prep the data for the Registry. The process is a bit more involved, and requires support from SBN to document how to use the data. This will be an ongoing effort that will require numerous players, so it can be done in parallel with other efforts. Not impact on delivery expected.

MCP cannot do the AWS account for us, so working with Open Data Registry's in AWS. Deadline = 2 weeks!

📆 01/2024 status: In work. Completion date delayed 1 sprint. No impact on delivery.


Use GET method instead of POST method when sending query

Sorry for duplicate if this issue has already been brought up.  Can we add support to enable GraphiQL to send request via GET method?  Most GraphQL server implementations support both GET and POST.   Our GraphiQL is using POST by default.  Would be great to use GET.

@jonathanawesome indeed, I was going to suggest the same thing. I was thinking that createGraphiQLFetcher() can accept a enableQueryGET boolean, ala enableMultipartFetcher option

@jonathanawesome @acao hi i was just struggling to get this working. i'm trying to make a GET request with the query, however it just returns the graphiql UI. is there a way i can make that request without using a fetcher? i have a restriction meaning i can only specify a URL unfortunately :/ any help would be greatly appreciated! thanks :D

@JankOops if you don't control the GraphiQL implementation (i.e. if you use GraphiQL provided by a third-party API), it's not possible to configure sending GET requests through the UI. I also think that is the correct way. If the API does not support GET requests for whatever reason, it makes little sense that GraphiQL would allow sending that request.
Looking at the draft for the GraphQL over HTTP spec, it also only required support for POST and marks support for GET as optional.


Please add Dart to https://github.com/google/protobuf README

Link: https://github.com/google/protobuf

Why?

Because it tells all protobuf-Users that there is a language out there named Dart! ;-)
Links as the one above tells the world that Dart is so important that as in this case a protobuf-version exists

Okay, I understand now. You want to add Dart to their README file:
https://github.com/google/protobuf/blob/master/README.md
(I thought you meant moving all the source code to their repository.)

Yes + sorry for the confusion! + Thanks!

https://github.com/google/protobuf/pull/3008


[INLONG-6639][Sort] Fix DynamicPulsarDeserializationSchema deserialize NPE problem when sourceMetricData is not initialized

Prepare a Pull Request

Title: [INLONG-6639][Sort] Fix DynamicPulsarDeserializationSchema deserialize NPE problem when sourceMetricData is not initialized.

Fixes #6639

Motivation
Fix DynamicPulsarDeserializationSchema deserialize NPE problem when sourceMetricData is not initialized.
Modifications
Do not report metrics when sourceMetricData is not initialized.

Because add spotless checkstyle, maybe it need git rebase master


GEODE-3952: Improve Spotless

Expand whitespace handling to trip end of lines and end of files
Remove commented-out import statements.
Enforce import ordering
Enforce modifier ordering

NOTE: Build will fail at this commit without applying spotless.

--
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

For ease of integration, the changes to spotless and the application of spotless have been separated.  The second commit will likely need to be redone before merging to account for any changes between rebases.


Where can I find the command run by kulala?

Hi there, I having troubles with Kulala, indeed it can do GET calls, but for some reasons the POST is not working. I set debug to true but I see no errors.
Is there a way to see the plain cal in logs or something like that?
Thank you in advance!

Have you tried to copy the request as curl command to your clipboard?
https://kulala.mwco.app/docs/usage/public-methods#copy

oh didnt know it. Thanks!


Add Dockerfile and Refactor Weather Alert Application: User Input for Dynamic Weather Alerts

Developer Checklist

[x] Adhered to the guidelines outlined in the README & Contributing file.
[x] Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
[x] Please ensure to include a README file for enhanced project clarity.
[x] Starred ⭐ the repository (optional).

Summary
This pull request introduces a Dockerfile for the weather alert application, streamlining the deployment process and ensuring consistent environments across different systems. Additionally, it refactors the application to include a user input form for city names, enabling dynamic weather alert checks based on user-defined locations. The application retrieves weather data in real-time, enhancing user engagement and usability.
However, the application is currently hosted on localhost, limiting its accessibility. Future work should focus on deploying the application to a cloud platform to allow users from various locations to access the service. Additionally, implementing AJAX could allow for real-time updates without requiring a page refresh, making the application more dynamic.
Suggestion: Consider developing this application using Django for better structure and scalability. I would be happy to assist in making improvements and implementing best practices in that framework.
Screenshot

@coderabbitai full review

@coderabbitai full review

Yes i have done with changes which you have said , now review it
On Fri, Oct 25, 2024 at 10:58 PM Aman Kumar @.***>
wrote:

@.**** requested changes on this pull request.
Hi @Amitabh-DevOps https://github.com/Amitabh-DevOps,
Thank you for your valuable contribution. We already have the project
available in this repository. If you would like to contribute to the same
project, please create a directory within the existing Weather Alert
directory. I recommend using the following structure: Weather
Alert/your-usrName/project-files (excluding the project name, as that
directory is already defined).
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/king04aman/All-In-One-Python-Projects/pull/85#pullrequestreview-2395953371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKAIEHVFCZZZHQ4EZP7VBPLZ5J5SDAVCNFSM6AAAAABQS765RCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJVHE2TGMZXGE
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

If there is any changes you want to suggest it please go ahead
and review it if it is ok then proceed it
i have did not modified the existing code , i just created a dir with my username as you have told
some how i have to copy the existing code of Weather Alert to get back the existing with seprately because i have changed the origanl README.md and all so make sure to check that also

I think it is so long time done , please check my PR


Permissive hold

Implemented the changes discussed here.
Keyboard code changes tracking #71
Tap Hold works perfect now.
No longer need to slow typing.

removed commit that change default feature.
restored 10k/s scan
added full sized keymap to reproduce stack protection fault

Reverted the part of change in Matrix trait, so split code can build.

This PR contains lots of modifications, I suggest to split this to separate PRs, where each one focus on only one thing.
btw force-push makes it harder to track what's changed between commits. If you want to make the commit history clean, splitting them to different PRs and squash merging is a better way imo.

hey @davidqge, I'm thinking about decoupling matrix and keyboard these days as you said, as well as the compatibility of other types of input devices.
The following is my current thoughts:

The scanning, key processing and communication should be three tasks, the event flow is: scanning -> processing -> communication
Scanning task and key processing task emit one report per action, while communication task merges reports which are within one communication interval
The scanning task and key processing task then could be fully async, no more busy loops when idle
All other input devices are also independent tasks, sending events to key processing task
Then we can regard keyboard matrix as an input devices, which makes it possible to run a batch of input device tasks together

There are some potential drawbacks:

The increasing inter-task communication may have negative compact on latency
The increasing number of tasks makes the latency less unpredictable
The size of communication channels is hard to determine: we don't want one slow processing blocks all other reports
Tap/hold still needs special processing

I've written a POC implementation in feat/input_device branch. Because part of this PR does similar thing, so I'd like to get some feedbacks of this refactoring. If you have any ideas/suggestions/questions, feel free to comment :D

I think only 2 is needed. You need channel between them because delay caused by usb/ble send.
Scanning and Tap Hold processing should be in one task. And Macro playback, Magic processing, and report on the communication task.
Store action in channel rather than report, that gave you more flexibility. Put Macro playback after channel will reduce the need for large channel.

Yeah i agree with u about it. but I still decoupled the matrix and key processing tasks, which takes matrix itself as an input device and makes it possible to add more input devices with little effort. all other devices can be configured from vial too.
Another benefit is that I finally makes all tasks fully async, including mouse and taphold processing, which simplifies the split code a lot and theoretically has lower power consumption.
The bad side is just like what you said, it may require large channels, and it may perform worse on latency and even worse when the channel is blocking. anyway, there is quite a lot room for improvement.


Crash on startup with Redirector

https://gist.github.com/border999/ad255c7f74b7f7f96f8efa65c63a2a6f

Basically the same as #33

Which I already have a fix for

I'll keep this open until I release the fix

Just want to comment and say that I am having the same problem, isolated my mod updates and saw that it was this mod

now fixed


Set up dependabot to update dependencies

Done in https://github.com/GothenburgBitFactory/taskchampion-sync-server/commit/2dba0813815a219a51311c9a9b59c1e034d9ca47


ROCm 1.9.1 OpenCL subtly broken on kernels 4.18.10+

Ubuntu, ROCm 1.9.1 OpenCL-only, two Vega64 GPUs.
hsa-ext-rocr-dev/Ubuntu 16.04,now 1.1.9-9-ge4ab040 amd64 [installed,automatic]
hsa-rocr-dev/Ubuntu 16.04,now 1.1.9-9-ge4ab040 amd64 [installed,automatic]
hsakmt-roct/Ubuntu 16.04,now 1.0.9-8-g238782c amd64 [installed,automatic]
hsakmt-roct-dev/Ubuntu 16.04,now 1.0.9-8-g238782c amd64 [installed,automatic]
rocm-opencl/Ubuntu 16.04,now 1.2.0-2018090737 amd64 [installed]
Testing with GpuOwl, everything works fine on kernel 4.18.8,
but wrong results are produced (easily, systematically) on kernels 4.18.10, 4.18.12, 4.19-rc7 (i.e. any kernel above 4.18.8 that I've tried).
What is interesting is that no error is reported, neither by the OpenCL API, nor by amdgpu in dmesg.

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c?id=v4.18.8&id2=v4.18.10
This is the only difference that may(not quite sure) cause this.

I tested kernel 4.19-rc7 with amdgpu-pro 18.30 and it works correctly.

Thanks @preda fr confirming after verifying with the latest kernel.
Hope this issue is no more observed.
Please file a new ticket if you observe the same with the latest kernels.

Thanks @preda fr confirming after verifying with the latest kernel.
Hope this issue is no more observed.
Please file a new ticket if you observe the same with the latest kernels.