The provided init.lua is probably outdated

Following the installation steps and trying to run yazi raises:
thread 'main' panicked at /home/ojarrisonn_/.cargo/registry/src/index.crates.io-6f17d22bba15001f/yazi-plugin-0.2.3/src/plugin.rs:45:32:
called `Result::unwrap()` on an `Err` value: RuntimeError("[string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:32: attempt to perform arithmetic on a nil value (field 'SYNC_CALLS')\nstack traceback:\n\t[C]: in metamethod 'add'\n\t[string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:32: in field 'sync'\n\t.../ojarrisonn_/.config/yazi/plugins/starship.yazi/init.lua:1: in main chunk\n\t[C]: in function 'require'\n\t[string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:1: in main chunk")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

In clear, the error message:
[string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:32: attempt to perform arithmetic on a nil value (field 'SYNC_CALLS')
stack traceback:
    [C]: in metamethod 'add'
    [string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:32: in field 'sync'
    .../ojarrisonn_/.config/yazi/plugins/starship.yazi/init.lua:1: in main chunk
    [C]: in function 'require'
    [string \"/home/ojarrisonn_/.cargo/registry/src/index.c...\"]:1: in main chunk

Lot of doc is outdated both for Yazi and it's plugins

Thanks for opening this, I'll have a look when I get a chance later

What is your yazi version and how did you install actually, as I haven't come across this error

I was using latest git changes, but I went and tried the latest stable version of v0.2.4, (it is also up to date on crates.io), and it still works for me. Could you make sure you are on the latest stable version?

Sorry for the waiting.
I'm using yazi 0.2.3 and i've iinstalled it usng cargo install. I didn't managed to update yazi to 0.2.4, it simply doesn't compiles yazi-adaptor

I don't think so

I don't think so

Could you try installing it with that command and see if the problem persists?

Just updated to 0.2.4 and now it works perfctly, thanks

That's good to hear. I might add a note to the readme about the minimum version just in case.


[Refac] Improve/refactor the behavior of set_trainable function

By @madagra
Description
Currently, the set_trainable function is confusing and not very easy to use for more complex tasks such as QEL. This issue aims to improve the current interface by making more explicit what is fixed in the parameters and what is not. See below the proposed interface.
Proposed interface
We have three types of parameters in Qadence: variational, feature, and fixed. Let's make this explicit in the high-level QuantumModel interface and not only at the block level.
High-level interface for the QuantumModel
# model with all types of parameters
optmodel = QuantumModel(...)

# select the variational parameters and return a list of IDs (names)
# and not the current values
vparams = optmodel.vparams(only_ids=True)

# make the parameters fixed with the current values: this modifies the
underlying QuantumCircuit in place and freeze the variational parameters
set_as_fixed(vparams, optmodel)

# select the feature parameters and return a list of IDs (names)
fparams = optmodel.fparams()

# set the feature parameters as variational
set_as_variational(fparams, optmodel)

Alternatively and likely better (following the principle of OOP interface and functional core), we can also use class methods:
optmodel = QuantumModel(...)
optmodel.set_as_fixed(optmodel.vparams())
optmodel.set_as_variational(optmodel.fparams())

Low-level interface for blocks
The low-level interface for blocks can remain similar to what we have today, except that we can replace the set_trainable function with suitable and more explicit functions. For example:
circuit = ...

fm_b = circuit.get_blocks_by_tag("feature_map")
ansatz_b = circuit.get_blocks_by_tag("ansatz")

# set all the parameters in the block variational/fixed
set_as_variational(fm_b, inplace=True)
set_as_fixed(ansatz_b, inplace=True)

# set one parameter only as a feature
set_as_feature(ansatz_b, params=["th1"], inplace=True)

# recreate the circuit with the new, updated, blocks
circuit = QuantumCircuit(2, fm_b, ansatz_b)

Discuss with @inafergra - if this is still relevant?

For context @inafergra, we are pinging you because we were thinking you had an issue with QEL at some point that would have been fixed by having a better developed set_trainable function.

Thanks for raising this. I think being able to set specific parameters as trainable/non-trainable at the QuantumModel level would be very useful indeed. Both for QEL and for more complicated algorithms where you might need a finer control of the parameters. There was no issue per se with the current set_trainable() function but it only operates at the block level which means you normally have to write some bolier-plate code to rebuild the QuantumModel if you change the trainability of its params.
No preference over the OOP or functional form, the functional maybe seems more neat to me but just a personal preference.


Implement --keep-mgmt-net for destroy subcmd

Implementing #271.
This is based upon changes introduced in #460.
At the same time it adds an implementation of the DeleteNet() for containerd.
Here we are listing all the Host interfaces to see if the bridge is still the master to any existing device, if not, and not --keep-mgmt-net is set, the deletion of the cni based mgmt bridge is executed.

Alright then, I'd consider this done now.

Resolved merge conflicts.
We're ready to merge here, aren't we?

We're ready to merge here, aren't we?

I think it is time to add a test for this case

@hellt are you fine with the tests

@steiler can you please also add a doc flag to destroy command?

@steiler also I think you wanted to add the schema entry for bridge under mgmt?

@hellt That is not related to this flag, so it should go into a new PR.

Since we've gone downa different path now, with karims work on refactoring the runtime interface, should the withKeepMgmtNet() func now be replaced by jsut the field in the withConfig piece?
https://github.com/srl-labs/containerlab/pull/462/files#diff-bb8ad382f59edfae9297e446895a161036f39115189e67da9d9f377a684a8f82R28

@

Since we've gone downa different path now, with karims work on refactoring the runtime interface, should the withKeepMgmtNet() func now be replaced by jsut the field in the withConfig piece?

can you create a commit with that approach? Looks more clean to me

As discussed, we go with this approach for now and tackle a potential change in a different PR.


Adding the Railway Track Fault Detection Model

Pull Request for DL-Simplified 💡
Issue Title: Railway Track Fault Detection

Info about the related issue (Aim of the project): To predict whether the given Rail Track is Defective or Not.
Name: Ankit Pandey
GitHub ID: pandey-ankit-22
Email ID<EMAIL_ADDRESS>Idenitfy yourself: Contributor (SSOC)

Closes: #issue number that will be closed through this PR
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@abhisheks008 I have created the PR. Please check !!

@abhisheks008 I have made the requested changes in the PR. Please check it.


"Unicode property not found" breaking build

Cleared my Cargo.lock and tried to build but I ended up being met with this error:
error: failed to run custom build command for `pio-parser v0.2.0`

Caused by:
  process didn't exit successfully: `/home/thompsonc/Projects/msbaker-firmware/target/release/build/pio-parser-67e78b185c5e4962/build-script-build` (exit status: 1)
  --- stdout
  processing file `/home/thompsonc/.cargo/registry/src/github.com-1ecc6299db9ec823/pio-parser-0.2.0/src/pio.lalrpop`
  /home/thompsonc/.cargo/registry/src/github.com-1ecc6299db9ec823/pio-parser-0.2.0/src/pio.lalrpop:273:10: 273:44 error: invalid regular expression: regex parse error:
      (\p{ID_Start}|_)\p{ID_Continue}*
       ^^^^^^^^^^^^
  error: Unicode property not found

  --- stderr
    Symbol = r"(\p{ID_Start}|_)\p{ID_Continue}*";
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I don't know why this is just now an issue but I can no longer compile which kinda sucks. Perhaps a breaking issue way upstream was pushed but not sure.
Any help is greatly appreciated.

This is caused by https://github.com/lalrpop/lalrpop/issues/750
Adding the dependency regex-syntax = { version = "0.6", default_features = false, features = ["unicode"] } to your Cargo.toml should work around the issue.
@ithinuel is currently working on building that workaround into pio-rs, but you can also add it to your msbaker-firmware.

Fixed in 0.2.2, many thanks!


Fix integration breakage

Did not wait for all tests - only waited for compile since I know that this bug was just a change of arguments causing a compilation error.


[dokuwiki chart] Using tls in ingress should set serviceport to 443

Hello!
This is concerning the dokuwiki chart, but possibly impact others as this is a general ingress problem (not specific to dokuwiki app)
Is this a request for help?: No

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT
Version of Helm and Kubernetes: helm 2.9.1 with k8s 1.11
Which chart: dokuwiki
What happened:
When enabling the ingress tls for the chart, it automatically allow ingress.kubernetes.io/secure-backends: "true"
However, the ingress is still created on the port 80 and not on the port 443.
This break http check from ingress, and so the ingress-controller consider the service unreachable, as it tries to reach https on port 80.
What you expected to happen:
When enabling tls for the ingress, serviceport should be set to 443
How to reproduce it (as minimally and precisely as possible):

Install a release while enabling tls: true in the ingress part
get the ingress on k8s cluster
ingress.kubernetes.io/secure-backends is correclty set to "true" in annotations
However, the spec-rules part still describe the backend using the port 80, which cannot work

Anything else we need to know:
This problem possibly impact others charts, as this seems a general bug when generating the ingress with SSL. Possibly, it has already been solved for others charts, but I found no corresponding issues in the github.
Sorry in advance if I have missed one, but still the bug is present for dokuwiki :-)
Anyway, thank you for your work on these charts! Really great job.
Regards,

Hello there :)
Is there any chance this issue is solved?
Thanks!

@LecygneNoir Sorry for the late response. Where exactly are you seeing the error? I deployed dokuwiki enabling ingress and tls but I don't see any HTTP healtcheck failing.

Hello @tompizmor
It's some month ago, but it seems the bug is still here.
When enabling the tls option in the chart, it triggers the option ingress.kubernetes.io/secure-backends: "true"
This option is added in the ingress when deploying, and it implies that the ingress controller do its healthcheck on a secure port (eg: 443)
But at the same time, the ingress is hardcoded to use port 80, where there is no SSL:
    http:
      paths:
      - backend:
          serviceName: dokuwiki-release-dokuwiki
          servicePort: 80
        path: /

Thus the healthcheck reach the service, tries to establish SSL session, failed, and it brokes the ingress process.
You could see here : https://github.com/helm/charts/blob/master/stable/dokuwiki/templates/ingress.yaml
The annotation secure-backend is added:
  annotations:
    {{- if .tls }}
    ingress.kubernetes.io/secure-backends: "true"
{{- end }}
[...]
spec:
  rules:
  - host: {{ .name }}
    http:
      paths:
        - path: {{ default "/" .path }}
          backend:
            serviceName: {{ template "dokuwiki.fullname" $ }}
            servicePort: 80

While the backend servicePort is 80. If your ingress support the secure-backend option (which it should :-) ) then it'll try SSL on the port 80, and the healthcheck will fail.
Using the secure-backend option is a really good practice for me, I guess it should add something like
  - host: {{ .name }}
    http:
      paths:
        - path: {{ default "/" .path }}
          backend:
            serviceName: {{ template "dokuwiki.fullname" $ }}
{{- if .tls }}
            servicePort: 443
{{-else }}
            servicePort: 80
{{-end }}

But I am really not familiar with the helm and yaml syntax and failed to made it works in my env (I finished by editing the ingress manually after deployment).
Hope it's more clear, and thank you again for all these charts :)
Regards


<picture /> elements generated by @sveltejs/enhanced-img cannot be styled

Describe the problem
Classes/styles applied to <enhanced:img /> elements are applied to the contained  element, not the outer container. This makes grid/flex layouts hard to manage without a wrapper element.
<enhanced:img class="grid-item" />

becomes
<picture>

</picture>

Describe the proposed solution
The <picture /> element could be marked as display: contents, or maybe classes/styles could be applied to the <picture />.
The example above could become either
<picture style="display:contents">

</picture>

or
<picture class="grid-item">

</picture>

Alternatives considered
As a workaround, you can wrap a
 around each <enhanced:img /> with your grid/flex logic applied to it, but this feels wrong when <picture /> is already wrapping your images.
Importance
would make my life easier
Additional Information
No response

I may be wrong, but it seems incorrect to put classes on the  in general.
I'm using tailwindcss on my project and have the following classes row-start-3 col-start-2 my-auto max-h-[2rem] md:max-h-[2.25rem] which work fine with a normal image, but the enhanced image doesn't behave correctly for exactly this reason. Wrapping the enhanced image works, but it is clunky.

Another idea: Split <enhanced:img /> into two parts, the wrapper (<picture />) and the image ().
This would lose the simplicity of just adding one element to your markup, but would make it clear where your props are applied.

I may be wrong, but it seems incorrect to put classes on the  in general.

I think we still want to retain being able to add classes to the  element so we can add styles such as object-fit

I was working a grid layout and wrapping the enhanced:img inside a div does work.

			<enhanced:img class="rounded object-cover" src={hero} />


Failed to load in Unity 2017.3.1f1

https://github.com/ray-cast/UnityVOXFileImport/blob/63d851a9bf45b4e2d0f0e7152864d4be0ca88bad/VOXFileLoader/Scripts/VOXFileImport.cs#L373
Solve:
Color32 color;
to
Color32 color = new Color32();

thanks, fixed


add: comment feature

I wanted to work with schemix and prisma-nestjs-graphql, saw the corresponding issue#55 and decided to implement this functionality.
If you have any suggestions, feel free to review the code. I am happy to help and adjust the pull request if needed.
Thanks for the great project and Happy Easter!

Using this I noticed two things:

adding a comment to a mixin-model should inherit the comments
All FieldOptions except BooleanFieldOptions form a union type with DefaultFieldOptions. Is this intentional or a bug?

I really like your approach to this. Will check it later and merge it in if all looks well!

All FieldOptions except BooleanFieldOptions form a union type with DefaultFieldOptions. Is this intentional or a bug?

This is a bug, let's get this fixed!


Pub/Sub subscriber flow control stops ack requests

Pub/Sub client library stops sending Ack or modifyAckDeadline requests entirely when flow control settings are defined.  See code below: when ran as it is against a subscription with a large backlog, it shows that the client thinks it's processing ~700 messages/second, while there is no outgoing traffic from the machine and the monitoring metrics show no ack | modAckDeadline traffic.
If we comment out the flow control argument, the overall processing rate is the same, acks and modifyAckDeadlines are regularly and successfully received by the server.
Expected behavior: flow control settings do not prevent the client library from acknowledging the message.

OS type and version
Mac Os Sierra
Python version and virtual environment information python --version
2.7
google-cloud-python version pip show google-cloud, pip show google-<service> or pip freeze
pip show google-cloud-pubsub
Name: google-cloud-pubsub
Version: 0.28.4
Stacktrace if available
Steps to reproduce

Run without flow control setting against a subscription with a large (10K messages) backlog
Run without flow control setting against a subscription with a large (10K messages) backlog

Code example

import time
import datetime
import sys
from google.cloud import pubsub_v1 as pubsub
import threading

subscription_name = "projects/%s/subscriptions/%s"%(sys.argv[1], sys.argv[2])
sleep_time_ms = 0
try:
    sleep_time_ms = int(sys.argv[3])
except Exception:
    print "Could not parse custom sleep time."

print "Using sleep time %g ms"%sleep_time_ms
start_time = -1
messages_processed = 0.0
thread_lock = threading.Lock()

def callback(message):
    global start_time, thread_lock,messages_processed

    if start_time < 0 :
        with thread_lock: start_time = time.time()

    time.sleep(float(sleep_time_ms)/1000)
    message.ack()
    with thread_lock:
        messages_processed += 1

subscription = pubsub.SubscriberClient().subscribe(subscription_name, flow_control = pubsub.types.FlowControl(max_messages=100)).open(callback=callback)

while(True):

    time.sleep(5)
    print "Acking messages at rate %.5f / second"%( messages_processed / (time.time() - start_time))

Using GitHub flavored markdown can help make your request clearer.
See: https://guides.github.com/features/mastering-markdown/

Also affected by this bug in the latest release google-cloud-pubsub==0.29.1
@lukesneeringer is thee any other way to limit number of messages pulled by subscriber?
I have 2000 events per second with 300KB of average message size and this just kills my workers with OOM, thanks

reproducible for me with google-cloud-pubsub==0.29.2

@explicitcall I am luckily close to "progress" for fixing how the flow control pauses and resumes the consumer thread.

@kir-titievsky I'm fairly certain 0.29.4 has resolved this, would you mind helping verify?

OK, see https://github.com/dhermes/google-cloud-pubsub-performance/tree/master/issue-4238, I am 100% sure this issue is fixed.
@kir-titievsky I'd still love to chat about other ways I can "kick the tires" to make sure this implementation is hardened.


fix: concurrency number worker

:tada: This PR is included in version 0.11.0-beta.31 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


The Dragon; a short story

I'm writing a depressing short story. I want it to be done by the end of October.

:+1:

4,000 words done so far. Getting there.

10,000 words your goal?

No. Just 1000 words a day.

That is awesome, until the end of October? (or whenever you deem it done?)

Until I deem it done. It might be a long while. Right now I have 2 of at least 5 different chapters done. They'll probably need to be rewritten.

I didn't finish. :( But I worked on it! :)

Thanks for joining us! Closing until next year's run. :)


pcolormesh class added

Method works, but I am not entirely happy that it contains the variable on line 193 called self.qcs (quad contour set) when it actually uses a quad mesh.
This will have to be changed at some point for clarity and accuracy, but as far as functionality is concerned, this is a trivial issue and makes no difference to the outcome of the call.

Coverage decreased (-1.5%) to 71.681% when pulling 0a462d171f4da3b5d6e870a52afd4fb9a63bb38a on corinnebosley:pcolormesh_skeleton into 0d60d6413ab6203e5ad3fa7457ed4bbedf2a7ab2 on SciTools:master.

closes #14

That doesn't seem right, I'm sure that was meant to link some things up...

That doesn't seem right, I'm sure that was meant to link some things up...

it will when we close it, it's fine

suggestion:
take line
https://github.com/corinnebosley/cube_browser/blob/0a462d171f4da3b5d6e870a52afd4fb9a63bb38a/lib/cube_browser/__init__.py#L38
'remove' this line; it is what mandates the shared behaviour
now only contour and contourf have this behaviour, and only on __call__
then you can change
https://github.com/corinnebosley/cube_browser/blob/0a462d171f4da3b5d6e870a52afd4fb9a63bb38a/lib/cube_browser/__init__.py#L193
to something like
# add QuadMesh to self
self.qm = ...

mebbe add comment to this behaviour in contour/contourf
# add ContourSetQuadContourSet to self

Coverage decreased (-1.7%) to 71.429% when pulling 76c64244f6c2fe293c4333b9948794741ebcb823 on corinnebosley:pcolormesh_skeleton into 0d60d6413ab6203e5ad3fa7457ed4bbedf2a7ab2 on SciTools:master.

see #45 for a suggested pattern for testing.  if you like it, i suggest you merge it, then rebase this branch onto the new master
(there should be no conflicts)
you can then add a new test module for pcolormesh following the pattern

OK, just worked out how to rebase properly (sorry, still getting my head around doing that without breaking stuff), so how much do I have to change in the test module?

Never mind, I am going home soon, I will have a look at this on Monday when I get in.  I'm sure I can work it out, but I seem to have a bit of a stupour on today.  Not achieved nearly as much as I wanted to.
Everything is fine.
I will be capable and productive again on Monday and get stuff done.

i suggest adding a new file, called test_Pcolormesh.py in
tests/unit/
i think it should be able to be very similar to
https://github.com/SciTools/cube_browser/blob/master/lib/cube_browser/tests/unit/test_Contour.py
search and replace, then fix
https://github.com/SciTools/cube_browser/blob/master/lib/cube_browser/tests/unit/test_Contour.py#L26
(... i think)

Coolio.  Thanks

:)

i don't understand why travis is failing this test, it looks good to me
@corinnebosley does the teat pass locally?
python test_Pcolormesh

@bjlittle can you see why the test runner is failing to find this test despite knowing to look for it?

Coverage increased (+1.4%) to 90.0% when pulling 2af28f1a06426d85a29d2416c21d7835d286f965 on corinnebosley:pcolormesh_skeleton into 0187da059e9c2dcde00c5166c6568fc5d524c598 on SciTools:master.

@marqh I think this was a small error in an import.  I had assumed that if QuadContourSet came from matplotlib.contour, then QuadMesh would come from matplotlib.pcolormesh, but it comes from matplotlib.collections (and mpl.pcolormesh doesn't exist).
I've got my fingers crossed.


Ensure REPL arguments are processed by the ArgsResolver

Introduce a new Job.ArgTemplate case which represents "squashed" arguments, so we can represent the structure of LLDB's --repl= argument and resolve the args which will be used to configure the frontend before concatenating them. The old behavior wasn't causing too many problems in practice, but this should make it easier to eventually launch the REPL as the last step in a multi-job build plan.
Also, this PR shell escapes arguments when printing jobs with -###, matching the behavior of the old driver

@swift-ci please test

@swift-ci please test

@swift-ci please test


Change how open framework banner is displayed on dashboard

Trello ticket: https://trello.com/c/e1Gk2eTF/12-fix-styling-for-framework-banners-on-account
Everything done as per the screenshot I think except the headers are h3, not h2,  as changing them would add a layer of complexity (The header element lives in the macro and is used for many different temporary messages across digital marketplace).
Screenshots:
Two started applications:

Started and not started application:

Mobile view:

One framework open:

This looks good to me.

Looks good @CrystalPea, although I think it would be worth putting some extra work into this page to get the headings at the right level in the hierarchy. At the moment it's a bit confusing. The main heading is h1, then have three h3's down the left-hand side that visually look very different from each other, and then on the right we have a single h2 that looks the same as the bottom h3. This doesn't feel very accessible and I suspect it would give a very confusing experience to people using e.g. a screenreader.
I think the best thing to do is have all of the current h3's become h2's. I'd argue that the blue box headers should be the same font size as the other subheadings on the page, although that's more one for @laurenceberry.
Here's what it would look like with equal font sizing:

If we're going to change the heading size then perhaps this needs a new macro altogether in the toolkit for this, to avoid messing with how these look elsewhere.  There are already a number of variations on these "temporary messages" and making all the things infinitely configurable takes us away from the idea of fixed building block patterns.
I do quite like the look of Sam's mock-up though.
And 100% agree about somehow getting the heading levels right.

You have a good point @samuelhwilliams that the headings should be h2, and I also agree with @TheDoubleK that that calls for a new pattern then, since we change so much in the old one. I guess with @Wynndow we avoided this route since it was meant to be a small story, but happy to go for it :).

Would it make any sense to have the headings in the temporary messages be h2's and then the headings for the live framework and the side bar ("Your company") be h3's? The temporary nature of temporary messages could make them more important than the existing stuff?

That would leave us with no h2s when there are no temporary messages. I think they're all of equal importance regardless of whether they're ephemeral or not.

Sorry for the late response.
The live frameworks are H3s but beneath a visually hidden H2, this makes sense.
The heading in the sidebar should should also remain as a H2.
Yeah, the headings for the banners should be H2s.
I don't think the font size needs increasing for the banners but yeah they should be H2s.

@laurenceberry @samuelhwilliams @TheDoubleK it is h2 now, behold:

HI @CrystalPea @TheDoubleK
Is this intended?
With Temp message:

Without Temp message:

I would suggest doing the following:

  {% include 'suppliers/_frameworks_coming.html' %}
  {% include 'suppliers/_frameworks_open.html' %}
  {% include 'suppliers/_frameworks_pending.html' %}
  {% include 'suppliers/_frameworks_standstill.html' %}

Your services

    {% include 'suppliers/_frameworks_live.html' %}

Yeah those links should always be on the right.

Not sure what changed to make it move.


Add --signal-index option to event align

Add additional columns in the eventalign output file corresponding to events start and end indexes on the  raw signal. It works but can probably be optimized.

Merged, thanks for the PR


[AIRFLOW-1670] Make Airflow Viewable By Color-blind Users

Fix Airflow task instance colors so that color blind users can see them. If people don't like this change or don't think they can get used to it we can implement an accessibility mode instead but that's a lot more work and I think these colors are fine. This change isn't perfect since there are other task instance states but this will solve the issue for 95%+ of the cases.
Here is what the new colors look like (in the order of failed/running/success), the dark blue circles don't have the strange outlines on the actual webserver:

Shut down has been changed to maroon from blue.
JIRA: https://issues.apache.org/jira/browse/AIRFLOW-1670
@saguziel

This is interesting because I had a person here at pandora mention they were color blind and the UI gave them trouble

I'm going to close this for now, got some anonymous feedback that the new colors are non-intuitive for existing users. We should go the accessibility mode route and have color blind users use browser extensions that modify css for now as a workaround.

Maybe make it user configurable (set cookie?)


Extension Code Runner fails on VSCode Insiders

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Insiders 1.64.0
OS Version: Windows 10

Steps to Reproduce:

Install code runner extension by Jun Han.
Install Python extension
Create a python file and add some code of your own
Run it using code runner.
See error below.

It automatically adds cmd.exec in place of C:
I am not getting this issue in vscode as of now.

/causedByExtension


Scrolling behaviour when using AppBar layout or scrolling tabs

Please update sample which work with design support library behaviour, when use fastscroll with recycleview its stop behaviour of autoscroll AppBar and Tabs

Sorry for that, but the sample was created before the design library was even introduced.
I will keep this issue open till this will be fixed.
If there is an issue, and you've found how to fix it, please let me know.

I've separated the sample and the library, and added some code to show how to use along with the design library.
Some of the code is based on this repo:
https://github.com/sitepoint-editors/Design-Demo


jQuery dialog button event issue on .select2-results click using formatNoMatches

Gents,
I run under an issue with asp.net button postback inside a user control outside of updatepanel called using _doPostback function which works on second click only.
Before posting this question I tried different ways but without success, the last one is to define the dialog by using:
$('.select2-results').click(function () {
           var dlg = $('#NewUserPanel').dialog({
                modal: true,
                width: 320,
                autoOpen: true,
                minHeight: 10,
                minWidth: 10,
                buttons: {
                    ok: function () {
                        $('#btnAddNew').click();
                    }
                },
                open: function (type, data) { $(this).parent().appendTo($('form'));}
           });
                      return false;
        })

The issue is related to 3.x version, but the version 3.x is not maintained anymore. But if this bug occurs in 4.x version, please reopen the issue and send us a JSFiddle example code or a PR.


Move stats no-op classes into a new class, NoopStats.

This design is more consistent with the 'tags' package.

Coverage decreased (-0.02%) to 78.609% when pulling 8fea9ae5759076067dd177e24e84c2c75b15e0ae on sebright:refactor-no-op-stats-classes into b7b4be7d5e71a488178f410fab3485ea52f33299 on census-instrumentation:master.

Codecov Report

Merging #671 into master will decrease coverage by 0.02%.
The diff coverage is 92.3%.

@@             Coverage Diff              @@
##             master     #671      +/-   ##
============================================
- Coverage     76.81%   76.78%   -0.03%
+ Complexity      732      730       -2
============================================
  Files           132      133       +1
  Lines          3463     3464       +1
  Branches        329      329
============================================
  Hits           2660     2660
- Misses          740      741       +1
  Partials         63       63

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/io/opencensus/stats/StatsComponent.java
100% <ø> (ø)
1 <0> (-2)
:arrow_down:

...c/main/java/io/opencensus/stats/StatsRecorder.java
100% <ø> (ø)
2 <0> (-2)
:arrow_down:

core/src/main/java/io/opencensus/stats/Stats.java
93.33% <100%> (ø)
4 <0> (ø)
:arrow_down:

...e/src/main/java/io/opencensus/stats/NoopStats.java
91.66% <91.66%> (ø)
2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b4be7...8fea9ae. Read the comment docs.

Thanks!


Issue with k8s.io/docs/reference/kubectl/overview/

Where is the custom-columns list? Here https://kubernetes.io/docs/reference/kubectl/overview/#custom-columns I can see nothing but an example. Where should I get an information to build custom-columns path expressions?

This looks like a request to add a custom columns expression reference into the Kubernetes documentation.
/sig cli
/kind feature
/priority backlog
/triage accepted

/reopen
We should try to add this.


add hash

Coverage decreased (-0.2%) to 97.619% when pulling ccf94b4dbc8b7b4f71df80aa0974bc53c099620c on develop into cad585c7e5e57b59ae465144373c83549b39fc61 on master.

Coverage decreased (-0.2%) to 97.619% when pulling ccf94b4dbc8b7b4f71df80aa0974bc53c099620c on develop into cad585c7e5e57b59ae465144373c83549b39fc61 on master.


Correct suggested version for React Native

This pull request changes the suggested version for React Native users to be aligned with the current major version of react-redux.
Not really an "issue", so I didn't make one :kissing_heart:

Thanks!


Extend Podman interfaces to allow mounting an image instead of a container in unshare-based checks.

Is your feature request related to a problem? Please describe.
Yes, when running checks for operator bundles, which are non-runnable container, I must fake-create the container in order to extract the bundle and perform my check.
Example: #124
Describe the solution you'd like.
Instead, it would be ideal if we could mount the container image without running the container at all.
#126 implemented similar functionality for containers. A PR resolving this issue would have to expand on that, allowing for "running in a filesystem" to work for either containers or images.
This would likely mean expanding the podmanEngine interface to allow for mounting an image.
Describe alternatives you've considered.
The alternative is implemented in #124 as an example, and described above in the related problem description. We must create the container to extract resources from that filesystem, and then we must clean up after ourselves.
Additional context.

/assign

I've already commented on the PR, but thought I should also put it here for easier discussion.
Is there a reason to keep the container mounting around? What use case is the container mount necessary rather than just the image mount. TBH, I would have just implemented it with the image mount had I realized it could be done with podman instaed of requiring buildah.


Auto Approve Matches Option

Add an option to let the tool approve face matches without asking the user for confirmation based on some criteria like the number of matches or tolerance (how close in distance a match is). The tool currently asks the user to approve the name for every face encountered.

Pushed commit #8630ace with basic auto approve/confirm matches functionality.


[TOPI] Add generic batch norm

Adds a TOPI implementation of batch norm so it can be constant folded.
Adds associated tests

@mbrookhart PTAL

@AndrewZhaoLuo @jwfromm PTAL


mise ls --json --current returns an array with a single object

mise ls --json --current returns an array for each tool (even though there can only be one), e.g.:
{
  "node": [
    {
      "version": "18.19.0",
      "requested_version": "18.19.0",
      "install_path": "/home/peelz/.local/share/mise/installs/node/18.19.0",
      "source": {
        "type": "legacy-version-file",
        "path": "/home/peelz/path/to/project/.nvmrc"
      },
      "installed": false,
      "active": false
    }
  ],
  "rust": [
    {
      "version": "stable",
      "requested_version": "stable",
      "install_path": "/home/peelz/.local/share/mise/installs/rust/stable",
      "source": {
        "type": ".mise.toml",
        "path": "/home/peelz/.config/mise/config.toml"
      },
      "installed": true,
      "active": true
    }
  ]
}

Wouldn't it make more sense to have a "tool": {} mapping instead?

Oh my bad. I forgot about that :sweat_smile:

there can be multiple active versions

How does it decide which version to run? Sorry I haven't looked too in depth into the docs.

I'm updating my zsh config to display the versions of the tools in my prompt. Basically, I just want to list the tools and (their versions) that are overridden in the current environment.


Smoke test for Connector Application

Add a smoke unit test that starts the smart_card_connector_app's
Application object, and checks it successfully completes the
background initialization.

PTAL. I believe the test should fail on "coverage" bots currently, because we need to backmerge the memory leak fix I submitted to the upstream recently (https://github.com/LudovicRousseau/PCSC/commit/615160ff2f1e6f0f0ee324f7442b0068552d0068). I'll upload the PR for that later today.

PTAL. I believe the test should fail on "coverage" bots currently, because we need to backmerge the memory leak fix I submitted to the upstream recently (LudovicRousseau/PCSC@615160f). I'll upload the PR for that later today.

Strike that 🤣  No, actually I'm surprised it passed - let me double-check.


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@chunyu3 -  my chnage is only related to editing the document, it possibly cannot cause this breaking chnage, I showed it few of my team members as well.

Hi @mitagarg you added two new properties in existing version stable/2019-11-01 which is an breaking change. Eithor you onboard a new API version to add those properties nor you need to acquire breaking change approval if you want to apply those changes in existing API version.

/azp run

i have all the approvals here, but merging is still blocked ...how does this merging happens?


server: fix multiplexing on plain text port

https://github.com/istio/istio/pull/26481 multiplexes gRPC on plain text port if gRPC port is off. But the place it was added is incorrect. When http server is being initialized,  s.GRPCListener will always be nil as it is initialized later. This PR fixes that order.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X ] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
1286deb8c305346b763eda960a189adefaedc903
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f0004aa78c09feae0127b68c46cbe01b7c4be217
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Bump CloudFoundry Ruby buildpack

Add rubygems 3.3.4, remove rubygems 3.2.33
Add bundler 2.3.4, remove bundler 2.2.33

See release notes

Codecov Report

Merging #1722 (bd5804f) into master (b33cb68) will decrease coverage by 83.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #1722       +/-   ##
==========================================
- Coverage   86.88%   3.67%   -83.22%
==========================================
  Files         399     399
  Lines        8647   13117     +4470
  Branches     1247     231     -1016
==========================================
- Hits         7513     482     -7031
- Misses        938   12634    +11696
+ Partials      196       1      -195

Impacted Files
Coverage Δ

app/models/role.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/team.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/alert.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/contact.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/country.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/product.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/accident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/incident.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/models/location.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

app/forms/alert_form.rb
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 351 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33cb68...bd5804f. Read the comment docs.


nixosTests.syncthing-many-devices: init

Description of changes
Attempting to fix #260262 in the 2nd commit, and test that https://github.com/NixOS/nixpkgs/issues/259256 is fixed along with #260262 ..
Currently this doesn't reproduces #260262, so this is still a draft..
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I'm sorry @3JlOy-PYCCKUi but it didn't reproduce to me. For reference, I applied the following revert+your patch on top of this PR:
patch
diff --git i/nixos/modules/services/networking/syncthing.nix w/nixos/modules/services/networking/syncthing.nix
index c821fbd4eb8e..d3f6853424c8 100644
--- i/nixos/modules/services/networking/syncthing.nix
+++ w/nixos/modules/services/networking/syncthing.nix
@@ -36,16 +36,17 @@ let
     # be careful not to leak secrets in the filesystem or in process listings
     umask 0077

+    # get the api key by parsing the config.xml
+    while
+        ! ${pkgs.libxml2}/bin/xmllint \
+            --xpath 'string(configuration/gui/apikey)' \
+            ${cfg.configDir}/config.xml \
+            >"$RUNTIME_DIRECTORY/api_key"
+    do sleep 1; done
+
+    (printf "X-API-Key: "; cat "$RUNTIME_DIRECTORY/api_key") >"$RUNTIME_DIRECTORY/headers"
+
     curl() {
-        # get the api key by parsing the config.xml
-        while
-            ! ${pkgs.libxml2}/bin/xmllint \
-                --xpath 'string(configuration/gui/apikey)' \
-                ${cfg.configDir}/config.xml \
-                >"$RUNTIME_DIRECTORY/api_key"
-        do sleep 1; done
-
-        (printf "X-API-Key: "; cat "$RUNTIME_DIRECTORY/api_key") >"$RUNTIME_DIRECTORY/headers"
         ${pkgs.curl}/bin/curl -sSLk -H "@$RUNTIME_DIRECTORY/headers" \
             --retry 1000 --retry-delay 1 --retry-all-errors \
             "$@"
diff --git i/nixos/tests/syncthing-many-devices.nix w/nixos/tests/syncthing-many-devices.nix
index 7cc627298cf4..51db9d416e55 100644
--- i/nixos/tests/syncthing-many-devices.nix
+++ w/nixos/tests/syncthing-many-devices.nix
@@ -86,6 +86,11 @@ in {
           devices
           folders
         ;
+        options = {
+          autoUpgradeIntervalH = 0;
+          urAccepted = -1;
+        };
+        gui.theme = "dark";
       };
     };
   };

I also read the documentation for the options you mentioned, and I can't imagine how that would have anything to do with the API's performance, and whether the API key changes during run...
BTW for easier communication, you can use  and code blocks to attach patches. The website you use forces me to download the patches.

Oh I see, you also check whether the gui and options settings are set... Thanks for explaining! I made the configuration, and the testScript code even more robust, and I managed to prove your issue! I marked the PR as ready for review, and your approval is welcome.

@ofborg test syncthing-many-devices


How can the SSG generated by generating nuxt3 be statically deployed on the Github page

Environment

Operating System: Darwin
Node Version:     v18.0.0
Nuxt Version:     3.5.3
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, ssr
Runtime Modules:  -
Build Modules:    -

Reproduction
https://github.com/web-abin/abinWeb
Describe the bug
The dist directory generated by nuxt3 executing nuxt generate locally is the local absolute path, pointing to. output/public. I want to deploy the generated SSG to the Github page, but it seems that I cannot modify the folder name generated by nuxt generate (which needs to be changed to docs). Moreover, since this folder is the local absolute path, I may report an error when deploying: the file does not exist
Additional context
No response
Logs
No response

Have you tried using the github-pages deployment preset?
export default defineNuxtConfig({
  nitro: {
    preset: 'github-pages'
  }
})


Unit Testing in PhantomJS Timeout

Bug, feature request, or proposal:
When unit testing, in PhantomJS 2.1.1 (not sure about other versions), if I import MaterialModule.forRoot(), the tests time out. If I pull in the modules for only the Material2 components that are used in my component, the test succeeds.
Note, this does not happen when testing through Chrome.
What is the expected behavior?
That the tests do not fail because of an async timeout
What is the current behavior?
PhantomJS (or Jasmine) spits out the following message:
Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

What are the steps to reproduce?
Plnkr: http://plnkr.co/edit/qw1OLZ
Basically just create a component with an Angular material component in it and import MaterialModule.forRoot() into your test for that component.
What is the use-case or motivation for changing an existing behavior?
I want to effectively test my components which use Material2
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.3.1
Material2 2.0.0-beta.1
PhantomJS 2.1.1
Windows 10
Node  4.5.0
Is there anything else we should know?
No

Hey @gonzofish - I tried to reproduce this locally, but didn't saw the issue.

Please try to update your PhantomJS / launcher and also try to use Angular Material beta.2

I have the same issue when i run tests with phantom js. I get this error only for components that uses material component.
I am using beta.8 with most updated PhantomJS

Any fix or work around for this? Getting the same error on a component test


Lots of 1.14.4 mappings

Lots of minor field/method mappings
Backports #1458 to 1.14.4
Fixed the editorconfig

Friendly bump to move this along 😄

Well I requested other people, they just don't come and review. Can't help.

I can port more things in a different PR, sure.


Show line number on search

Hi, I would like to request the feature of showing the archive line number next to the code found when I search some piece of code. I think it could be added as a setting such as "search.lineNumbers: "on"||"off" just like "editor.lineNumbers" setting. Do you guys think that is possible?
Just an example below:

Reasonable request, but since the viewlet is so narrow, it would have to take up horizontal space or get cut off.

What if it's enabled automatically when expanding the viewlet? Just like the extension icons and other info? Just like below.

+1 for this - moving over from another IDE I use this to quickly ascertain if results are in same method so I don't have to worry.

+1 as well. It's the one thing I miss from Atom

+1

I probably spend 30% of my vscode time navigating through search results like a maniac, so having line numbers would be a terrific productivity improvement, especially now that we have "search.location": "panel". Thanks!

+1 After Atom looks like an obvious functionality

+1 for this. JetBrains does this and it's incredibly helpful.

how to get this to work?
I got the version from 3 days ago and cannot find the option

@onqtam The setting is search.showLineNumbers. This is available in the current insiders version, 1.29. You can download the insiders version or wait until our monthly release next week


Actionable notifications actions don't work

Hi, currently having an issue with Notifications part of the integration.
I have started using actionable notifications. They work fine on my Android phone.
However, when I send them to the HASS.Agent, I get the proper notification with the action buttons, but clicking the buttons does not trigger any action.
I've tried multipl times and it just doesn't work. The same notification can be actioned without issues from a Android device.

The event for actionable notifications is different than what the Home Assistant mobile app uses.
See documentation here: Actionable Notifications at the section "Action Automations".

Hi fillefilip8,
Thanks for the feedback.
When I read the documentation earlier (well, skimmed over it) I only really read this bit, so i just plugged my existing notification scripts on the hass agent notify.
HASS.Agent's actionable notifications work the same way as the companion apps do. Read HA's docs for more info,
As it worked for the standard notifications and getting the actions, I assumed it was a bug rather than looking into the specific examples in the documentations.
Sure, if it followed the exact same format as the Home Assistant mobile app it would be ideal as it would save me time but in this case this is just user error.
Closing the issue.


feat: Add button to force reinstall Northstar

Useful for reinstalling Northstar after installing a developer version.
Closes #153

Note that it doesn't update the version number displayed on the main / PlayView and I kinda don't know how to get it to update ^^"

Could you add UI feedback to acknowledge FlightCore is currently reinstalling Northstar?
Currently, when you click the button, nothing happens on the interface.

Any idea how I can implement that in a quick way in a few lines of code? ^^
Frontend is definitely not my forté and I rather not have the PR be blocked by me trying to figure out frontend stuff for a week :P
At the very least I could show a notification when it's done if that's enough.
(I usually just look at the console output cause I'm running from a local build :P)

At the very least I could show a notification when it's done if that's enough.

Given that's a developer feature, a notification when starting downloading and a notification when it's done should do the trick :)

At the very least I could show a notification when it's done if that's enough.

Given that's a developer feature, a notification when starting downloading and a notification when it's done should do the trick :)

Done as suggested in af881ad45698cac236d10749d0fbd7e7ca9e2090 ^^


Refactor tests

Use test.each instead of forEach
Use screen instead of destructuring the render result
Use cleanup instead of writing our own

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   94.78%   94.78%
=======================================
  Files          12       12
  Lines         115      115
  Branches       18       18
=======================================
  Hits          109      109
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d4c24...f22f411. Read the comment docs.


append ".exe" to windows executable

As the title says. Thanks for the fantastic project! 😃

Thanks! 🍺
/merged


cloud hosted version 4.1.15 issue with "login Handler"

Hi there Lavoaster
Am currently testing out your plugin on a temporary trial version of the Ipboard in a cloud host environment. version 4.1.15. i uploaded the steam xml file as you instructed, made sure it is enabled from the "plugins" menu, but when i navigate to the "login handler" section it does not show the "Steam" option at all as your instructions say. its not present with the rest of the options. What could i be doing wrong?
PS: am a noob at this.
all the best
V.

The plugin also needs files to be uploaded. The "Test/Demo/Trial" version
is very restricted anyway.
But it is possible to install onto a CiC (Cloud) installation. IIRC we have
a few clients on CiC.


Llama.web app published into iis windows 64bit server, after deployment model values not loaded from appsettings

Localhost is working fine. When we publish the code in iis it's not working. We created the sub app and folder permission provided. Still unable to load the models

@saddam213 Hi, would you like to take a look into this issue? And a possibly similar issue #598

You may have to check the ASPNETCORE_ENVIRONMENT environment variable is set correctly on the server or it will try use the appsettings.Development.json
https://learn.microsoft.com/en-us/aspnet/core/fundamentals/environments?view=aspnetcore-8.0
And double check your launchSettings.json make sure its correct
This is a IIS configuration issue and not related to LLamaSharp.

We tried with all the environment files like appsettings.json  , appsettings.Production.json, appsettings.Development.json
Once modify the appsettings file we restart tha app in iis, Still models not loaded

@pxramesh Did you resolve the issue? I am also facing the same issue. Tried everything, still it is not working.


Added setCornerRadius function to avoid Ambiguous use of 'cornerRadius' issue

@ricardopereira Please check again.

I'll accept this for now but maybe it should have a more dedicated method for tag customization. Something like appearance for TagView's.

@mobilestar1 Actually, there's already a method for the same purpose 😅
https://github.com/whitesmith/WSTagsField/blob/6553752451d13642c42f470486e89776ddccbf83/Source/WSTagsField.swift#L90-L94

@mobilestar1 Actually, there's already a method for the same purpose 😅
https://github.com/whitesmith/WSTagsField/blob/6553752451d13642c42f470486e89776ddccbf83/Source/WSTagsField.swift#L90-L94
Sorry, I should've checked this earlier.

Of course, I knew that. As You can see from PR title I added setCornerRadius function to avoid Ambiguous use of 'cornerRadius' issue.
Several libraries declared cornerRadius variable publicly so it conflicts each other.

@mobilestar1 Ok, could you please share an example project for further investigation? This situation can happen with any property. For example with the text property: if someone adds an extension with UIView.text then it should not clash with wsTextField.text, right? We don't need to create a setText just to avoid that particular clash. That would be impractical.

For example, in my project I added this UIView extension to set corner radius easily.(I checked many other libraries and they also provide this solution)
extension UIView {

    @IBInspectable
    var cornerRadius: CGFloat {
        get {
            return layer.cornerRadius
        }
        set {
            layer.cornerRadius = newValue
        }
    }
}

Now if I want to set tag field corner radius by tagField.cornerRadius=x, then I got Ambigious use of cornerRadius issue.

any updates?

I think it would make more sense to rename the cornerRadius property to tagsCornerRadius. It would solve the issue but doing that the borderWidth, borderColor, etc. need to be renamed too (tagsBorderWidth, tagsBorderColor...), to keeps things consistent. But the best would be some sort of tags configuration mechanism.
Even so, I'll merge this but keep in mind that it will break in the future. Thanks

I think it would make more sense to rename the cornerRadius property to tagsCornerRadius. It would solve the issue but doing that the borderWidth, borderColor, etc. need to be renamed too (tagsBorderWidth, tagsBorderColor...), to keeps things consistent. But the best would be some sort of tags configuration mechanism.
Even so, I'll merge this but keep in mind that it will break in the future. Thanks

Yes Please do change the borderColor property name likewise, I'm facing the ambiguous issue in borderColor.


Cross Browser Compatibility: Safari fixes

This PR only targets the high priority issues reported by @patthiel affecting IE11 only. Issues affecting IE10 are low priority before release.

Coverage increased (+0.008%) to 27.434% when pulling 4f30f27c1f07d659b10c45f54652b311e9440b08 on alioso:safari-compatibility into<PHONE_NUMBER>f8809635ecc02c2161c4345b21357e on linode:develop.

I'm confused, are these safari fixes or IE fixes?

Selection cards now display checks ✅
Select boxes now display carrots ✅
IconTextLink Icons now have expected spacing ✅

There anything else to test for here @alioso ?


Cert signed by CA with constraint 'CA:FALSE' are considered valid

LDAPServer-generate-cert.txt
LDAPServer-setup-ca.txt
openssl_ca.conf.txt
openssl_srv.conf.txt
CA cert
ca_false.crt.txt
ca_true.crt.txt
Server Cert + Key
server_ca_false.crt.txt
server_ca_false.key.txt
server_ca_true.crt.txt
server_ca_true.key.txt
I am unsure if this is a bug or a known implementation difference between SSL libraries.
It certainly created some confusion so here it is:
I Created a CA and signed certificates with it

The CA had the basic constrain "CA:FALSE" set to false
I attached the openssl config + procedure on how I generate CA and server cert (it case it matters)

Certificate considered trusted by OpenSSL and moznss

Certificate worked fine with OpenLDAP 2.44 client/server compiled with OpenSSL (CentOS 7)
Same for default OpenLDAP client on CentOS 7 which uses moznss

Certificate considered not trusted by GnuTLS

I discovered this because ldapsearch on Debian/Ubuntu is compiled with GnuTLS

How to test:

Generate first set of CA + cert with "CA:FALSE"
Generate second set of CA + cert with ""CA:TRUE"
Start openssl s_server
Test with both openssl s_client and gnutls-cli providing the CA as option

Result: gnu-tls could not verify the cert create by a CA with "CA:FALSE", works with "CA:TRUE:. Both work with openssl.
 Is OpenSSL behavior correct ?

The OpenSSL utilities will sign a certificate without really looking at the signer's certificate.
When verifying a certificate  chain, OpenSSL library will see that an invalid CA signed the cert. Just like gnuTLS, etc.  Are you sure that openssl did not do this?  What version are you using?

@arekkusu I think it would be helpful if you could attach the ca cert and server key+cert for which you see this behaviour.

Yes I am quite sure. I have used the CA cert with 'CA:false' with OpenLDAP/openssl on CentOS 7 for month. Only recently noticed that OpenLDAP/gnutls in Ubuntu14/Ubuntu16 fails.
Note the extension I used in my openssl config:
[ ca_ext ]
keyUsage                = critical,keyCertSign,cRLSign
basicConstraints        = critical,CA:false
subjectKeyIdentifier    = hash

Let me generate cert + log I can share.

What version of openssl is your ldap build using?
You don't need to share that information.  Your config, saying CA:false, is incorrect.  I don't know when gnutls checked it. I don't know off the top of my head when OpenSSL started checking it.

Sorry I was unclear.  "You don't need to share that information"  I meant about generating and posting certs or a cert chain.  Knowing the version used in your ldap config would be interesting. But this fundamentally comes down to an erroneous config file using a non-CA cert as a CA.  Really old versions of openssl did not check this, current ones should.  I will leave this open until we find out the openssl version used in the ldap server.

Ok added the cert to my first post anyway...
I confirm the behavior with following:
OpenSSL 1.0.2k-fips  26 Jan 2017

[vagrant@default ~]$ cat /etc/redhat-release
CentOS Linux release 7.4.1708 (Core)

[vagrant@default ~]$ gnutls-cli -v
gnutls-cli 3.3.26

openssl s_client does return:
Verify return code: 0 (ok)

While it should be following if the check failed
Verify return code: 7 (certificate signature failure)

GnuTLS returns:
- Status: The certificate is NOT trusted. The certificate issuer is not a CA.
*** PKI verification of server certificate failed...
*** Fatal error: Error in the certificate.
*** Handshake has failed
GnuTLS error: Error in the certificate.

1.0.2k is a bit outdated, but ... I'm stumped.   Anyone else @openssl ?

Just compiled latest openssl and I still see the same behavior.
[vagrant@default openssl-1.0.2n]$ ./apps/openssl version
WARNING: can't open config file: /usr/local/ssl/openssl.cnf
OpenSSL 1.0.2n  7 Dec 2017

How to reproduce:
(I added all the needed cert/key in my first post)
# Run test server
openssl s_server -key server_false.key -cert server_false.crt -accept 6666
# Run test client (OpenSSL 1.0.2n  7 Dec 2017)
./apps/openssl s_client -CAfile ~/CA_FALSE/ca_false.crt -connect vagrant-srv.example.org:6666
(...)
    Verify return code: 0 (ok)

So I am either doing something wrong or it's really an issue in OpenSSL.

latest openssl [...] 1.0.2n

The newest release is 1.1.0g, which includes a near-complete rewrite of certificate verification.

Yeah, but the "check CA flag" code seems to be in 1.0.2, for a very long time.  Hence my confusion.

IIRC we do not apply purpose checking to trusted certificates prior to 1.1.0

I can confirm the issue with openssl 1.0.1t and 1.0.2k, but not with 1.1.0g.

Aha.  That was the point I missed, thanks Ben.
So this is a bug in 1.0.2 (or at least a mis-feature) and it's fixed in 1.1.0  We're not going to change the behavior in 1.0.2
I am going to close this.

Sorry I did not realize I compiled the latest LTS and not the latest.
Thanks a lot for your help !

For info this change in behaviour was introduced by this commit: 0daccd4dc. It applies to 1.1.0 and master only. So prior to that we don't check chain extensions for trusted certificates.

Technically the certificate is not compliant with RFC 5280, if this is the config used:
[ ca_ext ]
keyUsage                = critical,keyCertSign,cRLSign
basicConstraints        = critical,CA:false

From section <IP_ADDRESS> Basic Constraints:

The cA boolean indicates whether the certified public key may be used to verify certificate signatures.  If the cA boolean is not asserted then the keyCertSign bit in the key usage extension MUST NOT be asserted.

That said, yes, OpenSSL should fail safe in this scenario.

This issue has CVE-2021-3601 assigned.

CVE was not issued by the OpenSSL CNA.  CVE should be rejected.  OpenSSL does not class this issue as a security vulnerability.  The trusted CA store should not contain anything that the user does not trust to issue other certificates.

The CVE was assigned to 1.0.2 specifically, at a time when it was already not supported by the OpenSSL Project.

The project still analyses reports of vulnerabilities against 1.0.2 and continues to issue CVEs for it (the most recent one being CVE-2022-2068 which was published last month)

The CVE was assigned to 1.0.2 specifically, at a time when it was already not supported by the OpenSSL Project.

CNA's are not allowed to assign a CVE name for any issue in a product covered by another CNA, even if it was unsupported.  The CNA should first be approached and asked to assign a name, and any lack of response or dispute is then escalated to their root CNA.

I was not my decision, I'm just a messanger, please talk with Red Hat Product Security directly<EMAIL_ADDRESS>

We had the CVE reassigned to our CNA and published the rejection https://www.cve.org/CVERecord?id=CVE-2021-3601


await for doesn't run if I just add stream output to buffer

I am using flutter_bluetooth_serial library, and trying to gather all data into a buffer:
await for (String msg in _bluetooth.onRead()) {
      //print(msg);
      _buffer.add(msg);
    }

Some times its doesn't work at all, or works weirdly, until I uncomment the print line.
[√] Flutter (Channel dev, v0.11.3, on Microsoft Windows [Version 10.0.17134.376], locale en-US)
    • Flutter version 0.11.3 at C:\Flutter
    • Framework revision 72bf075e8d (2 days ago), 2018-11-09 20:36:17 -0800
    • Engine revision 5646e86a6f
    • Dart version 2.1.0 (build 2.1.0-dev.9.3 9c07fb64c4)

Based on how flutter_bluetooth_serial is implemented, I can't see any clear reason why the code above will work. Unfortunately, I don't know what _buffer is, so we're going to need a more full code sample to help you debug this.


Add support for onDragStart

Similar to onOpenStart or onCloseStart this PR introduces onDragStart which is called when user initiates either dragging drawer open or closed.

Thank you for this great library! This feature would be helpful for us as well. It looks like it has already been requested in a couple other places. Are there any updates on this?

This PR is ready for merge.  I've been maintaining a fork with this specific change for my project.


Add .codecov.yml file

Codecov Report

Merging #543 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #543   +/-   ##
========================================
  Coverage    93.53%   93.53%
========================================
  Files           38       38
  Lines         2368     2368
  Branches       483      483
========================================
  Hits          2215     2215
  Misses          92       92
  Partials        61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fd6e2...f006d89. Read the comment docs.


Update milvus-sdk-java to 2.4.8

About this PR
📦 Updates io.milvus:milvus-sdk-java from 2.4.1 to 2.4.8
📜 GitHub Release Notes - Changelog - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.milvus", artifactId = "milvus-sdk-java" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.milvus", artifactId = "milvus-sdk-java" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #387.


Palette wcag review

Thank you in advance for helping us to improve Terminal for MkDocs
Please read through the template below and answer all relevant questions. Your additional work here is greatly appreciated and will help us respond as quickly as possible. To avoid duplicates, please search existing Issues before submitting one here.
By submitting a PR to this repository, you agree to the terms within the Terminal for MkDocs Code of Conduct.  Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.
Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.
If the UI is being changed, please provide before/after screenshots.

This PR adds a palette review script to tests/utils that outputs a markdown report in tests/.
This PR also includes some new high contrast palettes to compare via the review script.
I also removed the comment lines from the gruvbox dark palette because it was breaking the process and it is the only palette like this.
Some minor changes were made to the test scripts. html.py has conflicts with the requests package, so it was renamed to html_utils.py. Also deleted the version line of the docker compose file because it was raising a warning.
References

Include any links supporting this change such as a:

GitHub Issue/PR number addressed or fixed
Related pull requests/issues from other repos

If there are no references, simply delete this section.

This PR addresses #120 and #119 in an attempt to expand on the palette options and to expedite the palette review process.
Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If there are existing unit and/or integration test suites, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).

[ ] This change adds test coverage for new/changed/fixed functionality
No tests added because the review script is almost a test itself, but some default (commonly used) palettes could be added to test the accuracy of the review.

Checklist

[x] I have added documentation for new/changed functionality in this PR or in mkdocs-terminal/documentation
[ ] All active GitHub checks for tests, formatting, and security are passing

closing PR to refresh the diff file, will reopen

didn't work, will try again but update the base while PR is closed

can't change the base branch while the PR is closed; reopening

hi @cowellbunga
do you mind reverting the file name refactor?  ie updating tests/utils/html_utils.py back to tests/utils/html.py?
ty!
in meantime i will take a look at the test script

i like this so far i think it makes sense
i also think if i clean up the existing .css palettes it will work a lot better
for example if i remove the unused colors from gruvbox_dark.css and replace the use of var() we get this output which is much more readable:
gruvbox_dark.css

backgrounds
tertiary-color (a89984)
secondary-color (bdae93)
font-color (ebdbb2)
primary-color (fabd2f)
error-color (fb4934)

background-color (282828)
:ballot_box_with_check:
:ballot_box_with_check:
:white_check_mark:
:white_check_mark:
:ballot_box_with_check:

progress-bar-background (504945)
:ballot_box_with_check:
:ballot_box_with_check:
:ballot_box_with_check:
:ballot_box_with_check:<
      :x:

code-bg-color (504945)
:ballot_box_with_check:
:ballot_box_with_check:
:ballot_box_with_check:
:ballot_box_with_check:<
      :x:

hi @cowellbunga do you mind reverting the file name refactor? ie updating tests/utils/html_utils.py back to tests/utils/html.py? ty!
in meantime i will take a look at the test script

I realized that having the palette review inside of utils caused the utils.html file to clash with an html package (used by palette review) of the same name. Moving the review script outside of the tests.utils package fixes the issue, removing the need for a name change. Name change reverted.


organizations duplicate definitions ROBOT report error

Duplicate definitions were identified in the ROBOT report for organizations. See the list of terms here:
https://docs.google.com/spreadsheets/d/16EMx4nZruzSshe08_rPBD-xdVqyuIrHaQWtNy37WQos/edit?usp=sharing
One solution is to just remove definitions for these terms or maybe change the definitions to rdfs:comment in theorganizations.tsv.

Discussed on OBI call 2022-05-09. We decided to remove the duplicated definitions of the organization instances.


Limit multiple platform manifests to one for size check

client.Pull will only pull one matching platform by default.
When checking the size of image we match that behavior so that
we don't look for multiple platforms that might not exist on disk.
Fixes #3387 and #2991

@ibuildthecloud thanks for the fix. But we still need sign-it-off with your real name :P

Can you please rebase and sign, I think this change is fine for now. I think a better solution would be more involved, but this change represents client expectations for getting the size from a pulled image.

LGTM, ignore Travis' red 'x' for now, it is from canceling ppc64le job


Check if DS is already defined

When using in the global composer, it possible some other package already defined DS as DIRECTORY_SEPARATOR.
PHP is giving a vage notice about this.

@TakeMeNL Thank you for the submission!


LXC with clone did not set other parameters for a first time, only on second try

memory and some other tags did not set on first terraform apply
For example I have one template with preconfigured memory = 1024
When I'm trying to clone that template by proxmox_lxc:
 resource "proxmox_lxc" "worker1" {
   target_node = "node1"
   hostname = "worker1"
   clone = 100
   full = true
   memory = 1024
   start = true
   onboot = true
 }

After first terrform apply CT  will be created with 512mb (config from clone)
After secondterrform apply CT will be updated to 1024mb
Little bit confused.

I'm seeing similar behaviour, except that the second terraform apply fails completely with a 500 error from proxmox because the ct already exists on the node.


Support for chainsync FindIntersect at origin

We currently fail to find a chain intersect when the client sends the empty origin point. This should mostly be adding a special case for slot 0 and empty hash in the ledger state when finding the chain intersect.

Hey there!
Your query will be dealt with by the support team.
Please see the link below to our dedicated support line:
HELP CENTER
Ticket id: DR52Z
Note: Click on the live chat icon at the bottom corner of the page to start a conversation


re-enable content length enforcement

Motivation and Context
This PR re-enables content-length runtime plugin that was previously disabled due to some erroneous tests. Those tests appear to be fixed.
Original PR: https://github.com/smithy-lang/smithy-rs/pull/3491
Tracking issue: https://github.com/smithy-lang/smithy-rs/issues/3523
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Blocked by https://github.com/smithy-lang/smithy-rs/pull/3620 landing and a new version of the SDK released with that test ignored so that semver hazards check can pass.


Changing dashboard by adding links to join multiplayer, create multiplayer, start single player

Changing dashboard by adding links to join multiplayer, create multiplayer, start single player

done: https://github.com/sopra-fs23-group-32/SoPra23_Server/commit/520d03f588b4ca08a7f71e363884d0993c28e72c


Add Multipass

A tool from Ubuntu to install several of their distribution in VirtualBox
multipass.svg.zip
https://multipass.run/

Added in 028450df5370ab04535e3d1b0f5e343232d94d2d
Thanks


Command-buffer supported queue properties

Header update generated from OpenCL-Docs PR XML change https://github.com/KhronosGroup/OpenCL-Docs/pull/850

FYI, I think this will require CTS updates, due to the removal of CL_COMMAND_BUFFER_CAPABILITY_OUT_OF_ORDER_KHR.

FYI, I think this will require CTS updates, due to the removal of CL_COMMAND_BUFFER_CAPABILITY_OUT_OF_ORDER_KHR.

I agree, drafted those updates here https://github.com/KhronosGroup/OpenCL-CTS/pull/2101 but still need to update an implementation to verify the CTS changes are correct.


Fix jazzy

This PR fixes the change in API for calculateMinAndMaxDistances due to the following PR: https://github.com/ros-planning/navigation2/pull/3875
This PR buils on top of the changes from: https://github.com/rst-tu-dortmund/teb_local_planner/pull/414

Can somebody look at this PR?

ping?

pinging @corot as it seems you are the last one who merged something in this repository :slightly_smiling_face:

pinging @corot as it seems you are the last one who merged something in this repository 🙂

I guess I'm the closest to a maintainer for this repo....  but I'm still stuck with ROS 1, so cannot test this.
I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create a branch humble-devel from the current main. And then merge this PR into main. The current main can then be released for iron and higher.

I can merge with a leap of faith, but this will break backward compatibility with previous ROS 2 versions, right?

You should create the following branches: humble-devel: contains the current ros2-master code iron-devel: contains this PR: #414 ros2-master should contain #414 + this PR

I have created the humble branch and I will try the PR this week, and sync with @corot
Thank you for the PR

I have created the humble branch and I will try the PR this week, and sync with @corot Thank you for the PR

thanks!   what about the build farm to create the debians?  I guess we need to change to use one branch or the other
also, I would not call it -devel...  I expect pretty little additional development here

@Rayman
It looks like ros-jazzy-g2o is not compatible with teb in this version.
g2o::sign was removed (I have checked that it exists on latest release but not in g2o master branch)
Did you manually change to use release to build it?
@corot
We will have to update the build farm.
regarding the -devel, I have followed the repo convention.

Ok, I finally installed jazzy, so I can take over this
Iron is EOL this month, so I will skip

I'll rename master as Humble
Merge this and @renan028's PR on master (== jazzy)
hopefully rolling and jazzy are compatible by now


[feat] add stack trace option in error page

Hey, I just made a Pull Request!
Add option to include stack trace in the ErrorPage for debugging purposes

Closes #22156
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@Rugvip @awanlin just realized that for some reason one of the e2e test jobs had failed earlier. Triggered the pipeline again after rebasing my changes and it worked and was able to get the preview environment up.

@jithenms looks like there's a little conflict in here, can you fix up and rebase? :pray:

Awesome work @jithenms, thanks for the contribution! 🚀

Also, thanks for the reviews @benjdlambert and the merge @Rugvip! :)


NOTICKET: Replace cutoff-dates with auto-validations on new topics

To fix default loophole and timestamp-mills validations on new topics we had introduced cutoff-date. This PR gets rid of those in favour of new validations only on new topics.
This PR is branched out from PR 861. Diff of the contents for this PR can be seen here.

Closed this as it was on top of other feature branch. Open new PR 871 on top of master.


Made include and exclude for write_spss optional, such that if neithe…

…r are provided all items in the targeted set will be included by default.

This PR resolves #339.


Update readme install instructions

Helix now includes the default variant. Update readme to reflect that.

That's great! I had no idea. Thanks for the PR.

Just a quick follow-up: how will eventual upstream updates be handled, should this repo change?

I plan to keep both in sync. This repo should be the primary repo for changes/discussions.


TextField that embedded in the GestureDetector can't be selected

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

create a textfield and wrap it into the gesture detector.

Expected results
the textfield can be selected and updated.
Actual results
can't select the text
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            GestureDetector(
              onTap: () {
                print('single tap');
              },
              onDoubleTap: () {
                print('double tap');
              },
              // this textfield can't be selected
              child: TextField(
                controller: TextEditingController()..text = 'Initial Text',
              ),
            ),
            // this textfield can be selected
            TextField(
              controller: TextEditingController()..text = 'Initial Text',
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel unknown, 3.10.1, on macOS 13.0 22A5358e darwin-arm64, locale en-CN)
    ! Flutter version 3.10.1 on channel unknown at /Users/lucas.xu/Desktop/flutter
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
    ! Unknown upstream repository.
      Reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.79.2)
[✓] Connected device (3 available)
[✓] Network resources

Thanks for filing this issue. Checking this across Flutter versions, it appears on the latest stable and master channels but works as expected on Flutter 3.7.12.
Per your Flutter version and the latest working version, this may be introduced in 3.10.0 or 3.10.1.

Demo

stable/master ❌
3.7.12 ✅

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.10.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (29 hours ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.79.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (5 available)
    • Pixel 3a (mobile)      • 964AY0WL20                               • android-arm64  • Android 12 (API 32)
    • iPhone (mobile)        • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • iPhone 14 Pro (mobile) • 98082851-A0C4-4E39-A310-21C48B10A364     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)        • macos                                    • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)           • chrome                                   • web-javascript • Google Chrome 114.0.5735.133

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.12.0-4.0.pre.121, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.12.0-4.0.pre.121 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not
      inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding
      /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside
      your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding
      /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5182697c0d (2 hours ago), 2023-06-19 21:37:33 -0400
    • Engine revision a91bb3f566
    • Dart version 3.1.0 (build 3.1.0-230.0.dev)
    • DevTools version 2.24.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 114.0.5735.133

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

This might be a change in behavior. I'll take a closer look tomorrow.

There is a first time for everything - this was the first time that I've been negatively affected by a new Flutter release. Once every year and a half, I will take those odds :) But yes, apparently wrapping TextFields in a gesture detector will make the form fields innaccessible (unless you long press a field/force touch on a mac trackpad).
Either way, I'm going to have to push out a hotfix for this - I wish I found out about this sooner. Please comment to let us know when this is addressed.

cc @Renzo-Olivares

I bisected this to https://github.com/flutter/flutter/pull/117502 which was a great improvement.

@bleroux Thanks for looking into that! I think I know what is happening. We use currentDown from the _TapStatusTrackerMixin when we fire the tap down event in the recognizer. The _TapStatusTrackerMixin consecutive tap timer is timing out while the GestureArena is delaying victory because we have TapGestureRecognizer, DoubleTapGestureRecognizer, and TapAndDragGestureRecognizer and all of them wait for all recognizers to declare a loss. Even though at the end of this interaction TapAndDragGestureRecognizer is declared victorious, _currentDown has become null and no tap down event is fired as a result, so the TextField cannot be selected. I'll put a PR out to correct this. The solution may be not to depend on _currentDown when firing a tap down event.

@Renzo-Olivares I'm assuming this will be released in the next weekly hotfix?


Basic conversion failing

I wanted to convert a simple tflite into onnx model. I am hit with the issue [1] below. Below is the procedure to reproduce with a public model:
a) Download mobilenet from [2]
b) Setup a virtualenv (python3.6) with tensorflow(1.15.2 & 2.3 show same issue)
c) pip install tflite2onnx
d) tflite2onnx mobilenet_v1_1.0_224_quant.tflite .
[1] onnx.onnx_cpp2py_export.checker.ValidationError: Unrecognized data_type (tensor name: TFLITE2ONNX_Scalar_uint8_151): 2
[2] https://storage.googleapis.com/download.tensorflow.org/models/tflite/mobilenet_v1_1.0_224_quant_and_labels.zip
Can anyone pls help in letting me know if I am doing something wrong in using the tool?

Hi @subashp thanks for reporting this issue, could you please report with the bug report template and attach verbose log?

Hi @subashp thanks for reporting this issue, could you please report with the bug report template and attach verbose log?

I moved on by not using this tool. So I don't have steps to provide to recreate. I will be closing this issue.


Debugging metrics.

I am looking at 2 of my validation submissions and I am struggling to debug why the mAP scores on one of them are higher than the other despite having really high ADE and really high FDE. Images attached below; Any explanation would be useful. I have read through the description of all the metrics but I am still unsure why this is the case and would appreciate it if anyone could shed any light;

A similar concern with miss rate. How can the miss rate be lower when the Min ADE and Min FDE are so much higher?

I agree those numbers are unexpected.  I don't have an immediate answer for what is going on there.  I will try to get some time to look at your submission file to see what is causing this.  The only thing I can think of is if your model does well on stationary and nearly stationary objects only, this could result in something like this.

Hi Arbaaz.  I took a quick look at your submissions.  In the first submission your model predicted stationary objects very well for cyclists at 3 seconds, but for all other trajectories it was not very accurate resulting in a high FDE score.  Because the mAP metric averages across trajectory type bins, stationary trajectories count for 1/8th of the mAP score.  This why your first model had a high mAP score for cyclists at 3 seconds.  Your second model did better in general resulting in a lower FDE score, but it did worse on the stationary trajectories, and did was not accurate enough on other trajectories to avoid misses on almost all trajectories.  This is why even though the FDE score is lower, the mAP score is worse.  I agree this is a bit counter intuitive.  Plotting the P/R curves for the trajectory bins helps a lot to understand this. We will consider adding these plots to the results in the future.


jest-haste-map: add test to demonstrate broken behavior for platform-specific files

When you have two files A.js and A.ios.js, removing the second one will not properly update jest-haste-map cache. This causes jest or dependents to crash, as they try to access a now non-existent path. This changeset adds a test that reproduce the issue, along with complementary tests to verify other variations on the theme are not broken. These tests try to ensure that the follow-up fix will not break the platform-specific files handling in other ways.

Codecov Report

Merging #5508 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5508   +/-   ##
=======================================
  Coverage   61.69%   61.69%
=======================================
  Files         213      213
  Lines        7077     7077
  Branches        3        4    +1
=======================================
  Hits         4366     4366
  Misses       2710     2710
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc14ac8...b57160c. Read the comment docs.

Nice!