gitsigns/git.lua:222: attempt to concatenate upvalue 'line' (a nil value)

Describe the bug
When using with neovim official lsp client, and the client seems caused neovim CPU high.
The plugin report:
Error executing vim.schedule lua callback: ...al/share/nvim/plugged/gitsigns.nvim/lua/gitsigns/git.lua:222: attempt to concatenate upvalue 'line' (a nil value)
Press ENTER or type command to continue

To Reproduce
init.vim:
" Specify a directory for plugins
" - For Neovim: ~/.local/share/nvim/plugged
" - Avoid using standard Vim directory names like 'plugin'
call plug#begin('~/.local/share/nvim/plugged')

Plug 'neovim/nvim-lspconfig'
autocmd Filetype go setlocal omnifunc=v:lua.vim.lsp.omnifunc

" https://github.com/nvim-lua/completion-nvim/wiki/chain-complete-support
Plug 'nvim-lua/completion-nvim'
" Configure the completion chains
let g:completion_chain_complete_list = {
    \ 'default': [
    \    {'complete_items': ['lsp']},
    \    {'mode': '<c-p>'},
    \    {'mode': '<c-n>'}
    \]
\}

let g:completion_enable_auto_popup = 1
let g:completion_enable_auto_hover = 1
let g:completion_enable_auto_signature = 1
let g:completion_matching_smart_case = 1
let g:completion_trigger_keyword_length = 1 " default = 1
let g:completion_timer_cycle = 80 "default value is 80
" auto change sources whenever this completion source has no complete item
let g:completion_auto_change_source = 1
let g:completion_enable_auto_paren = 1

" Set completeopt to have a better completion experience
set completeopt=menuone,noinsert,noselect
" Avoid showing message extra message when using completion
set shortmess+=c

n
" The delay is governed by vim's updatetime option,
" default updatetime 4000ms is not good for async update
set updatetime=100

" set signcolumn to 2 to avoid git gutter sign conflict with linter sign
set signcolumn=yes:2

" signify show git diff sigs
" Plug 'mhinz/vim-signify'
" https://github.com/lewis6991/gitsigns.nvim
Plug 'nvim-lua/plenary.nvim'
Plug 'lewis6991/gitsigns.nvim'

lua << EOF
require('gitsigns').setup {
  signs = {
    add          = {hl = 'DiffAdd'   , text = '│', numhl='GitSignsAddNr'},
    change       = {hl = 'DiffChange', text = '│', numhl='GitSignsChangeNr'},
    delete       = {hl = 'DiffDelete', text = '_', numhl='GitSignsDeleteNr'},
    topdelete    = {hl = 'DiffDelete', text = '‾', numhl='GitSignsDeleteNr'},
    changedelete = {hl = 'DiffChange', text = '~', numhl='GitSignsChangeNr'},
  },
  numhl = false,
  sign_priority = 6,
  status_formatter = nil, -- Use default
}

local lsp = require'lspconfig'
local cmp = require'completion'

--@param client: (required, vim.lsp.client)
local mix_attach = function(client)
  -- lsp_status.on_attach(client)
  cmp.on_attach(client)
end

-- lsp.gopls.setup{}
-- https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/gopls.lua
-- https://github.com/golang/tools/blob/master/gopls/doc/vim.md#neovim
-- https://github.com/neovim/nvim-lspconfig/blob/master/CONFIG.md#gopls
lsp.gopls.setup({
  on_attach = mix_attach,
  settings = {
    gopls = {
      usePlaceholders = true,
      completeUnimported = true,
    },
  },
  capabilities = lsp_status.capabilities,
})

EOF

Steps to reproduce the behavior:

open a go file under a regular go project, the file must be big, about 3000 lines code
insert some go comment (and then neovim lsp client will continue to send the whole file to lsp server)
neovim cpu will 100%

See error

Error executing vim.schedule lua callback: ...al/share/nvim/plugged/gitsigns.nvim/lua/gitsigns/git.lua:222: attempt to concatenate upvalue 'line' (a nil value)
Press ENTER or type command to continue

Observed output
Error messages, logs, etc
Screenshots

Additional context
System: Linux Ubuntu 20.10 x86_64
Neovim version:
NVIM v0.5.0-dev+1115-gc1fbc2ddf
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/ttys3/.config/nvim/neovim/build/config -I/home/ttys3/.config/nvim/neovim/src -I/home/ttys3/.config/nvim/neovim/.deps/usr/include -I/usr/include -I/home/ttys3/.config/nvim/neovim/build/src/nvim/auto -I/home/ttys3/.config/nvim/neovim/build/include
Compiled by ttys3@ttys3-ht

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/share/nvim"

Run :checkhealth for more info

also reported to nvim lsp https://github.com/neovim/neovim/issues/14037

There could be a couple issues going on here. I've fixed the nil handling here https://github.com/lewis6991/gitsigns.nvim/commit/cdf8e98ca16521138e1376279772dfcf60008ec8 so that should let you see what the actual error is.

Thank u, I'll try it later

@lewis6991  thanks, I tried many times, and the error did not come. Seems that it's OK now (although neovim lsp is not OK, still CPU 100% :laughing: )


Main menu tweaks (wording and remove scrollbar from settings menu)

Removed unnecessary scrollbar from Settings menu.
Reworded menu tooltips: "Addressbook" -> "Contacts" and "Marketstatistics" -> "Market"

+5
did the merge manually


feat: import with .js and .jsx file extensions

fixes #55

Thanks! I would say it's a good feature instead of a bug fix.

Thanks! I would say it's a good feature instead of a bug fix.

Sure. I've renamed the PR to reflect that. Let me know if I should squash all commits and amend the commit message on my branch.


Hide when product out of stock

I believe that the pay in x should be hidden when a product is not in stock - see image for a better description.

Hello @mrabsinthe,
Thank you for your message !
You're right, the pay in x button should be hidden when a product is not in stock. We share the issue with Paypal to found the best way to fix it. We will integrate the fix as soon as possible in a future release.
I will let you know when the issue is resolved.
Best regards,
Team 202

Fixed in 5.6.0


Rtl epub position

Hi
Do you have any idea about this bug?
https://github.com/readium/r2-testapp-swift/issues/399
Regards,

No update for this issue, but I transferred it to this repo so we don't forget about it: https://github.com/readium/swift-toolkit/issues/70


[thread-cert] use the same mesh local prefix as Thread harness

Travis fails.
You may need explicitly set the mesh local address when bring up nodes. Otherwise, mesh local prefix would be derived from extpanid, i.e. the practical mesh local prefix is still the old one fdde:ad00:beef::/64
https://github.com/openthread/openthread/blob/master/src/core/thread/mle.cpp#L163

ping~


I have PWA in wappalyzer but in lighthouse I have some issue , how can I fix them ?

issue 1 : Web app manifest or service worker do not meet the installability requirements .
No matching service worker detected. You may need to reload the page, or check that the scope of the service worker for the current page encloses the scope and start URL from the manifest .
issue 2 : Downloaded icon was empty or corrupted.
how can i fix them im new in vue and nuxt and still learning

when i add
pwa: {         workbox: {             enabled: true         }     }
i have only one issue

but css is not loading so i have to clear cookie

@SepehrMoafi Could it be related to #32 ? This module does not work well since<EMAIL_ADDRESS>unfortunately.

Duplicate of #32


Update display_manager.py for PY3 compatibility.

The Pythocalypse is nigh!
Please add a meaningful description for your change here
Output of the graph renderer is a byte string, which cannot be directly displayed in Python 3.
R: @pabloem

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Could you please file a JIRA ticket for this issue, describe the failure mode, and include it into the PR title? I wonder what problem you are hitting given that  display.HTML() seems to accept unicode, str and bytes as per https://ipython.readthedocs.io/en/stable/api/generated/IPython.display.html.
cc: @davidyan74 @KevinGG: Please make sure to test interactive runner in Python 3 interpreters, and add automated Python 3 test suites if they are missing.

cc: @davidyan74 @KevinGG: Please make sure to test interactive runner in Python 3 interpreters, and add automated Python 3 test suites if they are missing.
Hi Valentyn, we are actually moving InteractiveRunner away from display_manager and interactive_pipeline_graph completely and have all new interactive related tests and features only compatible/executed with Py3.6 and +.
[interactive] has its own setup.py dependency configuration and is mostly isolated from other packages. Details of detecting current environment can be found in interactive_environment module.

The PR removing the display manager usage is in review: https://github.com/apache/beam/pull/10132


[dv/ibex] Enhance riscv_debug_single_step test

As pointed out by @tomroberts-lowrisc in #983, the current
implementation of riscv_debug_single_step_test cannot handle
single-stepping over instructions that change the PC.
This PR aims to introduce this functionality, utilizing the
new instr_monitor_if.
Now, if the core single-steps onto a branch/jump instruction, the
testbench will log the new target PC and compare it against the actual
target address stored in dpc.
"Normal" instructions are checked as usual by incrementing the
instruction's PC by either 2 or 4 (depending whether it is compressed)
and comparing that against dpc.
This test passes successfully when combined with the RTL patch in #1034.

Funny that you mention actually, because the Imperas team that developed OVPsim is working to integrate their ISS into the UVM environment for lockstep comparison during simulation time (like you mentioned), which would eliminate the need for all of the handshaking and overly complex checks.
Thanks for the review!

this force push re-adds the enum casting to opcode and step_instr[6:0], as per my comment in the PR.


Improve selecting and deselecting event call

I noticed that the selecting-item and the deselecting-item events were not fired when selecting by taping directly on the item associated checkbox.
I also suggest to add a selecting-all event and a deselecting-all event.

This change is

Thanks!
This is a welcomed feature!
I'll do some finishing touches on it, add tests and rename selecting-all to selecting-all-items and deselecting-all to deselecting-all-items and merge it.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Disable API Check in projects with untracked breaking changes

@dougbu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Will go in before fix for aspnet/KoreBuild#143

See aspnet/BuildTools#205 for more context

Travis failure appears to be due to curl failure I've seen mentioned elsewhere.

Followup bug?

As I mentioned in aspnet/BuildTools#205 here, I'll file issues to revert each temporary change once they are in.


swap/add error boundary for orders

add error new component for server error in orders: https://emurgo.atlassian.net/browse/YOMO-940
add missing cursor style

just a quick heads up, this error boundary will be capturing whatever error is thrown and displaying as service unavailable for now.


[Feature Request] Table column with very long label

Existing Component
Yes
Component Name
el-table-column
Description
I need to handle cases where the table column label is very long, so the label is not wrapped.
https://jsfiddle.net/L1gb9ddg/
While I can truncate the label, in that case I'd like to show a tooltip of the full label text -- this could just be a title attribute, or a popover. But really I'm not sure what is the best solution.

In this case the best solution may be render-header. And for the tooltip part, you can check out our show-overflow-tooltip implementation for reference.


Add rpm spec file linter (rpmlint)

This is a rough attempt at adding a linter for RPM spec files using rpmlint.  It appears to work well enough, but note the following:

I basically don't know what I'm doing.  I have many years of programming experience but outside of setting variables in my .vimrc, vim isn't something I've done before.
Some rpmlint errors do not have line numbers.  I just made them show up at line 1 but perhaps there's a better way to handle that.
The vim modeline reads 'spec' but everyone's going to call them "RPM spec files".  I'm not sure where that should actually go in the documentation.
Editing vim help files is... weird.  I tried to get things to line up the right way but I'm not sure if it's done the right way.
I added an entry for the test suite but I didn't try actually running it.  I guess the CI setup will yell at me if it doesn't run properly.

So, anyway, it's a first try.  Please let me know what I can do to make it better.

Well crap, I check back and now the checks failed.  The log doesn't make it obvious but I would guess I screwed up the test I added.  I guess I'll try to figure out how to run it myself.

I played around with it a bit but no luck.  I am not seeing where the syntax error in my test is, and while I can get the test suite to start, it just hangs after the first incidence of:
docker run -a stderr --rm -v /home/tibbs/work/ale:/testplugin -v /home/tibbs/work/ale/test:/home w0rp/ale vim-v8.0.0000 +Vader! test/*.vader test/*/*.va   der test/*/*/*.vader test/*/*/*/*.vader
Vim: Warning: Output is not to a terminal
Vim: Warning: Input is not from a terminal

If you have any hints, that would be great.

Cheers! :beers:

Thanks!


Cannot create a datasource with this plugin via Grafana Provisioning

Hello.
We are using the Grafana Provisioning mechanism to provisioning of our Grafana instance. Syntax is pretty close to your example in README but for some reasons we have issues with putting token into database.
Example of configuration:
  - name: "cdn-stats-test2"
    orgId: 1
    editable: true
    access: "proxy"
    type: "gcorelabs-cdn-stats-datasource"
    version: 1
    jsonData:
      apiUrl: "api.gcore.com"
    secureJsonData: 'APIKey 0123$abcdefghij'

Of course, we created a token correctly. Tried with APIKey word and without it, with quotes and without - no result. Behaviour in the end is: when we try to query on this datasource we see "Invalid API token" (with APIKey word) or "Authentication credentials were not provided" (without it) errors.
Interesting that if we edit the datasource manually and just put the token (without any prefixes and words) it works! What is the right way to configure the datasource in the provisioning process?
Thanks.
If it is important:
grafana-server --version
Version 10.0.9 (commit: 439bbb4722, branch: HEAD)

Hello! We have analyzed this issue. This happens because the data source configuration file can be interpolated. This behavior can be found in the Grafana documentation.

Hello!
Yes, it works! Personally after first look thought about something in YAML but the issue was in the different place.
Thank you for help!


#583: First prototype of integration tests in bash.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.267%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
6398

Relevant Lines:
9169

💛  - Coveralls


Module not found: Can't resolve 'tslib' in '...@aspnet\signalr\dist\esm'

Hello,
i get the following error using "@aspnet/signalr": "1.0.0", and creat-react-app
Failed to compile.

<EMAIL_ADDRESS>Module not found: Can't resolve 'tslib' in 'D:\VSTS\LSNG\node_modules\@aspnet\signalr\dist\esm'

Just run npm install --save tslib

It looks like we may have an issue here. importHelpers was set but we don't properly depend upon tslib. We'll track this for an upcoming release.

Is this issue solved?
I just updated to v1.0.2 today but am still facing it.

It's still open, so no :). You can manually install tslib to work around it right now.

I'm confused. The package, while written in typescript, is published as javascript via npm.
I assume the solution is not to simply add tslib as a dependency but fix the build/publish process so that the resulting javascript artifacts don't require tslib anymore?

Yeah, which is why the issue is still open and marked as a bug.

I assume the solution is not to simply add tslib as a dependency but fix the build/publish process so that the resulting javascript artifacts don't require tslib anymore?

Yes and no, and we'd actually appreciate some feedback here :). tslib is a library containing the helpers that TypeScript would normally generate for things like await and class hierarchies. We have two major options here:

Change from importHelpers to emitHelpers in the TypeScript compilation options. This would mean the helpers would be injected into each of the ~40 JS files we have in the dist/esm and dist/cjs files. That would have an impact on the size of the library, but would avoid the additional dependency
Add a proper dependency on tslib to our package.json. This would fix the actual "bug" since it was the original intent when we enabled importHelpers. That would avoid introducing additional code into our compiled JS, but would add the additional dependency. It wouldn't really affect users either way since they use this code (the tslib helpers) either way, but it would be a new "dependency" in theory.

I think 2 is our preferred option for a few reasons:

Adding the NPM dependency means that users don't see an issue, they just update to our fixed version and the new dependency is installed
If a user is using SignalR as well as some other library (such as Angular), they can share the tslib dependency, reducing the overall code (note that @angular/core also does this, it depends on tslib)

So, I think we're going to add the dependency for 2.2.0 and look at back-porting that change to an upcoming 2.1.x patch.

I'm a little unsure here, but seems like it might be worth checking out how angular adds their tslib dependence. I'm in an Angular project, and I've not added any references to tslib. So for whatever reasons, Angular doesn't make any demands one or the other in regards to tslib. Seems it would be best for Signalr code to do the same?

Yes, this is our issue, as I mentioned above. We're actually removing the tslib dependency entirely.

@anurse Will this fix be included in a future 1.0.3 package version?

Yes, we are considering this fix for a patch release.


Consider support for no param BuildWebHost() detection in design tools

Say, I don't want to use WebHost.CreateDefaultBuilder(args), but I have my own builder method where I don't use the args parameters, because its not necessary.
Example:
public class Program
{
    public static void Main() =>
        BuildWebHost().Run();

    public static IWebHost BuildWebHost() => // Note that there is no `string[] args` parameter on this method.
        new WebHostBuilder()
                .UseKestrel()
                .UseContentRoot(Directory.GetCurrentDirectory())
                .UseIISIntegration()
                .UseStartup<Startup>()
                .Build();
}

Currently (in 2.0) the EFCore design tools will throw the the following error when trying to build the service provider: An error occurred while calling method 'BuildWebHost' on class 'Program'. Continuing without the application service provider. Error: Parameter count mismatch.. This is because it tries to run BuildWebHost(args) instead of BuildWebHost().
It would be nice to have support for a no args BuildWebHost method.

The ASP.NET team defines the pattern--we just consume it. In 2.1, it's changing to the following:
public static IWebHostBuilder CreateWebHostBuilder(string[] args)
{
    // ...
}

To discuss supporting additional patterns, you'll need to create an issue on aspnet/Hosting.

Will do. Thanks!


Feature request: startup penalty

I am using emhass to control my pool pump based on Amber electricity prices. Often, the solution EMHASS comes up with switches the pump on and off repeatedly, which is probably a bit more switching than I'd like. The pump also runs faster (2x energy consumption) for the first few minutes, which probably negates the benefit from running at 22c/kWh rather than 23c/kWh.
I think I'd like to alter the algorithm to allow specifying a penalty (in minutes or cents) for each startup. That way, the optimiser can split the usage in two if it really helps, but won't stop and start every 30 minutes when the power price fluctuates slightly over the day.

Turning on the option to make it a continuous load with just one startup is not an option for you?

It’s an option, but not the preferred one. Starting up twice is fine, but
it needs to be a big enough win to justify it.
— Andrew Garrett
On Wed, 1 May 2024 at 22:11, David @.***> wrote:

Turning on the option to make it a continuous load with just one startup
is not an option for you?
—
Reply to this email directly, view it on GitHub
https://github.com/davidusb-geek/emhass/issues/261#issuecomment-2088380008,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCFXSMHZOQNKASJXTAQTLZADLXTAVCNFSM6AAAAABGT3VWX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGM4DAMBQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have this somewhat working in a branch. Want to clean it up before sending a PR.

Hi, ok nice feature!
The annoying part will be to add a new user-define input variable to control this.
I think that by default no penalty should be applied on the number of startups. Then if the user desires as it was your case, this option can be activated.
This has been a constant struggle, add parameters so that this optimization can be highly configurable, but at the same each new parameter adds more complexity and the people complain about how all this is hard to setup.
But go ahead these are nice features. Try to add some lines to test_optimization.py to quickly test the desired/expected behavior of the feature.

This is included in the just released new version.
Closing this for now but reopen if eneded.


Use of the term "Author" for the Profile Spec

“This specification describes how to author an xAPI Profile.” This is the first sentence of the doc. Perhaps we should change this from “author” to “represent” or “publish” or something else? We will develop tools for people to publish profiles, but we don’t want them to manually “author” anything in RDF/JSON-LD on their own. The way the word author is used here seems to imply they will be expected to manually create these files themselves, which isn’t the case. That would result in a lot of errors, typos, human errors, etc. “Author” is used in second sentence as well. Pretty much anywhere we say “author” we should come up with a more representative term. I know this is somewhat explained later when talking about a “profile” server’s capabilities. But I’m not fond of the term, “author” in this context. We can discuss this further if you guys feel there is a good reason to stick with this term. The only exception is that it seems to make sense to use the term “author” when referring to the provenance metadata of the profile (the creator or author).

I don't think the term author implies writing JSON directly rather than using a tool to do so. Especially since L&D has "rapid authoring tools" that enable us to author e-learning without writing code.


Support loading non-cubicchunks worlds and dimensions

I guess Implemented in #624???

Yes

Well... partially
Still needs to detect which dimensions are CC and which are not.


Fix Admin component crash while rendering if first resource isn't loaded yet

Hi there,
Just a little fix that prevents the Admin component from crashing at render time when the first Resource wasn't (yet) loaded.
Also as the children node isn't marked as required, it should be fair to allow no children at all.
In such case, the resources variable was undefined, as the React.children.map doc suggests.

Hi, I don't understand in which conditions the crash can occur. Can you provide a reproductible scenario?

I'll try to provide you with something, but in the meantime:
Suppose I'm using the Admin component with a dynamic resource array.
<Admin {...props}>
  {this.props.resources.map(resource =>
    <Resource />
  )}
</Admin>

This array might be empty on first render, and this would crash:
...
const firstResource = resources[0].name;
...

https://github.com/marmelab/admin-on-rest/blob/master/src/Admin.js#L61

OK, that's because you load the resources dynamically?

Yes exactly, I'm experimenting with the current state of https://github.com/api-platform/admin
Thanks :+1:


winget upgrade for nvm is broken

Issue:
Hi, thank you for the nice tool.
I am installing NVM for windows with winget, which is becoming the de facto tool for managing packages in Windows.
❯ winget install --id CoreyButler.NVMforWindows

My issue is that to this date I cannot seamlessly use the upgrade function of winget due to NVM for windows not been upgraded by the tool:
❯ winget upgrade --id CoreyButler.NVMforWindows
This package's version number cannot be determined. To upgrade it anyway, add the argument --include-unknown to your previous command.

Adding the --include-unknown parameter is not a good solution because I am never not in a state where the system is 'up to date'
You can see the main reason is that winget is unable to detect the current version of NVM for windows:
❯ winget upgrade --include-unknown
Name                                 Id                        Version Available Source
---------------------------------------------------------------------------------------
NVM for Windows                      CoreyButler.NVMforWindows Unknown 1.1.9     winget

Expected Behavior:
The actual version of the currently installed version should appear as so:
❯ winget upgrade --include-unknown
Name                                 Id                        Version Available Source
---------------------------------------------------------------------------------------
NVM for Windows                      CoreyButler.NVMforWindows 1.1.9   1.1.9     winget

Additional context:
As explained here: https://github.com/microsoft/winget-cli/issues/1356
The version used by winget is simply the information provided from Control Panel
Apparently, all that is needed is to add a DisplayVersion key in the registry when installing.
See how the Control panel does not see the version:

Here is an example of a program with a version:

I think if you use the update utility it doesn't work so you probably need to use the installer to fix this.

I think if you use the update utility it doesn't work so you probably need to use the installer to fix this.

I can confirm that if you use the installer to update the version it fixes the issue.

This bug has been fixed in 1.1.10
When available from Winget, winget upgrade --include-unknown will also work


[Enhancement] EasyMaskEquip

EasyMaskEquip is a feature that allows players to quickly equip masks without needing to assign them to C-buttons or D-pad slots. It simplifies the process by letting players equip masks directly from the pause menu. The enhancement also provides visual feedback by highlighting the currently equipped mask and graying out masks that can't be equipped in certain situations (e.g., underwater or mid-transformation).
This PR introduces the EasyMaskEquip enhancement, allowing players to equip masks directly from the pause menu by pressing the A button.
A new OnKaleidoClose hook was added to handle mask equipping when the pause menu is closed. This allows players to change their mask selection if they accidentally select the wrong one, ensuring the mask is only equipped once the pause menu is closed.
This enhancement also utilizes Proxy's BeforeKaleidoDrawPage hook from PR #537 to allocate and update vertex data for the mask equip border.

Build Artifacts

2ship-linux.zip
2ship-mac.zip
2ship-windows.zip

I think this is already in a pretty good working state so I'm just gonna go ahead and change this to ready for review. I don't foresee this having to many issues, but please do report any bugs you may find.

I realize ShouldEquipMask may not account for all scenarios, but its a good start. I would need help identifying what else we may need to add.

63 commits later and I think I've gotten this to a state I'm happy with. I don't plan to make any more changes unless the devs request otherwise. Hope yall like it!


Migrate to SPA architecture using Svelte

@toboshii thanks for the awesome app! I've been trying to build it from this branch in a fork, but it looks like the only thing that is currently working with the Dockerfile (I've had to slightly modify it to make it compile) is the backend.
With this rework, do you plan to have 2 containers (1 to serve the frontend and the other for the backend)?

@toboshii thanks for the awesome app! I've been trying to build it from this branch in a fork, but it looks like the only thing that is currently working with the Dockerfile (I've had to slightly modify it to make it compile) is the backend. With this rework, do you plan to have 2 containers (1 to serve the frontend and the other for the backend)?

Thanks for the kind words, and trying Hajimari out! Yes I haven't quite updated the build process yet as I just run the frontend and backend separately for dev. The plan is to continue embedding the frontend as was done previously. In the latest code I've pushed this is completed.
I'm hoping to have the time this weekend to wrap most of this up and get a beta build out this week.

Awesome work, thanks! I finally managed to build and test the latest changes, looks promising! I'll make sure to provide any relevant feedback as I'm using it ;)

FYI - some permissions need to be added to the service account:
hajimari-5c4bf99964-qr5z8 hajimari time="2022-10-02T00:51:09Z" level=error msg="Error Getting EndpointSlices: endpointslices.discovery.k8s.io is forbidden: User \"system:serviceaccount:default:hajimari\" cannot list resource \"endpointslices\" in API group \"discovery.k8s.io\" in the namespace \"rook-ceph\"" _source="util/replicastatusgetter.go:55"

FYI - some permissions need to be added to the service account:

Thanks for pointing that out, I'll make sure that gets in the next chart release :+1:


Test internal builds

Closes hollowverse/hollowverse#167

We need to decide what to do when a requested test environment is not found. Should we soft fail to master or should we show an error page?

@msafih I've greatly simplified the code handling both routing paths. It's no longer using separate middlewares, but it keeps the logic for fetching the environment details separate for maintainability.

@msafih I've also changed the code so that now we only have to set the query string one time and all subsequent pages will be served from the test branch. This is done via another cookie called branch that takes precedence over the env cookie, but only if the test branch actually exists, so when the branch environment is deleted, the code soft-fails to a random production environment.

@msafih I've also changed the code so that now we only have to set the query string one time and all subsequent pages will be served from the test branch. This is done via another cookie called branch that takes precedence over the env cookie, but only if the test branch actually exists, so when the branch environment is deleted, the code soft-fails to a random production environment.
But this also means that as long as the test environment is still up, we will be served that environment until the cookie expires. We might forget that we are actually using a test environment. We will need to remove the cookie manually to return to a production version. I've reduced the branch cookie maxAge to 2 hours.

Cool.
When we hit a page from the browser, how are we going to know which environment it's being served from? Will this information be in the header or somewhere else?

When we hit a page from the browser, how are we going to know which environment it's being served from? Will this information be in an HTTP header or some where else?

Both cookies branch and env can be viewed in Chrome DevTools in the Application tab.

@forabi Okay, but this is not very convenient and it's something that we set. Not something that the server responds with. The question is: how do we know what the server responded with?

@msafih How about we set a custom header with the endpoint as the value
just before we call proxy.web?
On Sat, Sep 23, 2017, 7:27 PM msafih<EMAIL_ADDRESS>wrote:

@forabi https://github.com/forabi Okay, but this is not very convenient
and it's something that we set. Not something that the server responds
with. The question is: how do we know what the server responded with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hollowverse/release-manager/pull/5#issuecomment-331648059,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA90GcYfK1RR4ITBWaxMJxJKc6QQfSEcks5slTFjgaJpZM4PfFkb
.

@forabi That should be fine if the endpoint is a user-friendly string from which it is easy tell the branch name. Otherwise, it would be better to have the branch name in the in the header.

@msafih I've added a new header, X-Hollowverse-Release-Manager which includes the final branch name as resolved by Release Manager. https://github.com/hollowverse/hollowverse/pull/197 also adds a similar header to version server to serve as the source of truth in case something goes wrong in the routing code.

@msafih I added another header, X-Hollowverse-Requested-Environment, which is set when requesting a branch with the query string param.
So if we request https://hollowverse.com/?branch=test:

X-Hollowverse-Requested-Environment will be test.
X-Hollowverse-Resolved-Environment will be test if the environment test actually exists. Otherwise it will be a randomly assigned environment like master or beta
X-Hollowverse-Actual-Environment (https://github.com/hollowverse/hollowverse/pull/197): should match the previous header if release manager logic is good.

Without ?branch=test, X-Hollowverse-Requested-Environment will not be set.

👍

@msafih I think this PR is ready


feeds are broken

as reported in https://github.com/jekyll/minima/issues/89:

the generated feed is broken. https://validator.w3.org/feed reports a missing author element and other problems.
also, it seems that feed.xml gets served as application/xhtml+xml but it should be application/atom+xml

We don't control the content type of the feed; that's an issue with your server configuration.
Can you be more specific about what you mean when you say the “feed is broken?” As discussed in #144, the generated feed does validate.

On 2016-11-29 16:25, Pat Hawks wrote:

We don't control the content type of the feed; that's an issue with your
server configuration.

that's too bad. is there any way jekyll can define the content type of a
resource? if not, i guess this one is hard to fix.

Can you be more specific about what you mean when you say the “feed is
broken?” As discussed in #144
https://github.com/jekyll/jekyll-feed/issues/144, the generated feed
does validate.

https://validator.w3.org/feed/check.cgi?url=http%3A%2F%2F2017.ws-rest.org%2Ffeed.xml
is the example i am looking at. it is this odd constraint of atom that
there must always be an author element.

If a site author is specified, we will include it.
If not, should we output an empty <author> element?

On 2016-11-29 21:21, Pat Hawks wrote:

If a site author is specified, we will include it.
If not, should we output an empty || element?

technically speaking, atom requires each entry to have an author,
directly or inherited. so for each entry either the entry must have an
author, or the feed (if both then entry overrides author). if neither
one does, then in order to at least satisfy the syntax requirements, an
empty author element probably is the best idea.


is text-decoration: underline; text-decoration: underline dotted; still necessary?

the source of _reboot.scss has this:
// Abbreviations
//
// 1. Duplicate behavior to the data-* attribute for our tooltip plugin
// 2. Add the correct text decoration in Chrome, Edge, IE, Opera, and Safari.
// 3. Add explicit cursor to indicate changed behavior.
// 4. Remove the bottom border in Firefox 39-.
// 5. Prevent the text-decoration to be skipped.

abbr[title],
abbr[data-original-title] { // 1
  text-decoration: underline; // 2
  text-decoration: underline dotted; // 2
  cursor: help; // 3
  border-bottom: 0; // 4
  text-decoration-skip-ink: none; // 5
}

is it still necessary to have both text-decoration: underline; and text-decoration: underline dotted;. it's been quite some time since this "hack" was introduced and maybe it's no longer necessary. here's the relevant discussion from 2016: https://github.com/necolas/normalize.css/pull/468#issuecomment-174107494
thanks!

I've not tested those needs, but the latest (8.0.1) normalize.css has both.
https://github.com/necolas/normalize.css/blob/8.0.1/normalize.css#L87-L88

@mdo

Duplicate property 'text-decoration' found.
https://github.com/twbs/bootstrap/blob/8fa0d3010112dca5dd6dd501173415856001ba8b/dist/css/bootstrap-reboot.css#L57

abbr[data-original-title] {
  text-decoration: underline;
  -webkit-text-decoration: underline dotted;
  text-decoration: underline dotted;
  cursor: help;
  border-bottom: 0;
  -webkit-text-decoration-skip-ink: none;
  text-decoration-skip-ink: none;
}

Duplicate property 'outline' found.
https://github.com/twbs/bootstrap/blob/8fa0d3010112dca5dd6dd501173415856001ba8b/dist/css/bootstrap-reboot.css#L203

button:focus {
  outline: 1px dotted;
  outline: 5px auto -webkit-focus-ring-color;
}


Add travis

Add a basic travis config to patch the esp32 & stm32 crates to guard against breaking changes.
Should hopefully stop changes like #13 from breaking crates.

This should good to go. I had a little trouble with language: "python" (for some reasons pip wasn't installed in venv?) so I switched to rust and installed python after.

Nice, it spotted said issue :) Will rollback and see if this picks up on it.

@MabezDev can you rebase on master to see if it all works?

It now works for stm32, obviously this breaks esp32 but hopefully I'll be able to find a way around that.

I'd like to merge this, can you comment out the esp32 call for now?

@nickray Sorry I didn't get a chance to look at this earlier. Instead of commenting it out, I've separated the jobs and set esp32 as allowed to fail for now.

Perfect, thanks a lot!


[Media] Media Tasks, Fx 76 tasks

Trello
https://trello.com/c/dcuwxwSu/232-media-session-api-fx-76
https://trello.com/c/hMdZ1Wjv/261-audio-worklets
Acceptance criteria

[x] Implement the seek{back,for}ward in the MediaSession interface

[x] Implement setPositionState

[x] Implement playbackState

[x] Enable Media Session API on Nightly

[ ] enable "dom.audioworklet.enabled" on beta and release

Audio worklets rel note added here:

@a2sheppy can you provide info on what you've done to document the above changes, and set DDCs where appropriate? Ta.


Fix Bitbucket pull request selection broken due to a different response

This pull request ensures correct PR selection based on Bitbucket's API, which in turn fixes submitting comments on Bitbucket PRs.
When run with the bitbucket_pr formatter: pronto run -f bitbucket_pr -r rubocop, pronto 0.7.1 fails with
/Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:68:in `block in pull': undefined method `[]' for nil:NilClass (NoMethodError)
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:68:in `each'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:68:in `find'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:68:in `pull'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:57:in `pull_id'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/bitbucket.rb:11:in `pull_comments'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/formatter/pull_request_formatter.rb:5:in `existing_comments'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/formatter/git_formatter.rb:7:in `format'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto.rb:59:in `block in run'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto.rb:58:in `each'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto.rb:58:in `run'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/cli.rb:54:in `block in run'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/cli.rb:53:in `chdir'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/lib/pronto/cli.rb:53:in `run'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /Users/konradstrack/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/pronto-0.7.1/bin/pronto:6:in `<top (required)>'
	from /Users/konradstrack/.rbenv/versions/2.2.4/bin/pronto:23:in `load'
	from /Users/konradstrack/.rbenv/versions/2.2.4/bin/pronto:23:in `<main>'

The actual response from Bitbucket's API is different than the current implementation expects:
table:
  :description: ''
  :links:
    ...
  :destination:
    ...
  ...
  :source:
    commit:
      hash: 7b2e2948bf645
      links:
        self:
          href: https://api.bitbucket.org/2.0/repositories/AAA/BBB/commit/CCC
    repository:
      links:
        self:
          href: https://api.bitbucket.org/2.0/repositories/AAA/BBB
        html:
          href: https://bitbucket.org/AAA/BBB
        avatar:
          href: https://bitbucket.org/AAA/BBB/avatar/333/
      type: repository
      name: Bbb
      full_name: AAA/BBB
      uuid: "{aa2485b9-53e1-4978-882b-bf645094f734}"
    branch:
      name: feature/my-branch
  ...

even though it's not properly documented (https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/{username}/{repo_slug}/pullrequests/{pull_request_id}).
This change selects the correct source branch for comparison with @repo.branch.

@konradstrack thanks 🙇!


Merge 'hotfix-3.1' into develop

Codecov Report

Merging #29 into develop will decrease coverage by 0.67%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop      #29      +/-   ##
=============================================
- Coverage      79.08%   78.40%   -0.68%
  Complexity        85       85
=============================================
  Files             29       30       +1
  Lines            349      352       +3
=============================================
  Hits             276      276
- Misses            73       76       +3

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/com/senorpez/loot/api/WebConfig.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c81fe...ec20d01. Read the comment docs.

🧜♀


Max request size per endpoint?

There is a max request size parameter on Javalin start, however, is there a way you can implement it for specific endpoints? Ideally the endpoint would error out as soon as the bytes exceed the specified amount. Any references would be appreciated.

@twoxfh there is nothing built in for this, but it should be as easy as doing throwing a 413 if you see that the body is too large?
throw HttpResponseException(413, "Payload too large")

@twoxfh there is nothing built in for this, but it should be as easy as doing throwing a 413 if you see that the body is too large?
throw HttpResponseException(413, "Payload too large")


Should Cassandra 3.11.1 be merged due to CASSANDRA-13752 and CASSANDRA-13756 SSTable corruption bugs?

This looks pretty worrisome, should C* 3.11.1 get merged?
https://issues.apache.org/jira/browse/CASSANDRA-13752
This seems related too:
https://issues.apache.org/jira/browse/CASSANDRA-13756

Greg

Yes, as soon as the C* 3.11.1 will be fully released (there is not yet cassandra-3.11.1 tag).

Le 8 sept. 2017 à 21:46, Greg Saylor<EMAIL_ADDRESS>a écrit :
This looks pretty worrisome, should C* 3.11.1 get merged?
https://issues.apache.org/jira/browse/CASSANDRA-13752 https://issues.apache.org/jira/browse/CASSANDRA-13752
Greg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/119, or mute the thread https://github.com/notifications/unsubscribe-auth/AJzHmTm1vbR5yS4HQ5V_duCw_-NNsqpfks5sgZl4gaJpZM4PRnPV.

Elassandra <IP_ADDRESS> is now based on Cassandra 3.11.1.


translate WDL's sub() as replaceAll() equivalent not replace()

From WDL spec:

this function replaces all non-overlapping occurrences of pattern in input by replace

But I think what we have in the get_expr_apply is a call to .replace() which only replaces one occurrence (different than the Python function with same name!)
Instead I think we must use JS' replaceAll().

Good catch! We should add a test case with data that would demonstrate this

I think this workflow is using it to replace spaces by underscores (for filename): https://github.com/broadinstitute/viral-pipelines/blob/f009d869ddb75770ae0aa69d9dd8bcaf1390502e/pipes/WDL/tasks/tasks_reports.wdl#L367
That workflow has a lot more than what we need, so we can just extract the test case for a string with spaces, then replace space by _, and that's that :+1:

We are already not passing the pattern correctly to replace as the openWDL 1.1 spec says

pattern is a regular expression that will be evaluated as a POSIX Extended Regular Expression (ERE).

so we should be wrapping the replace string in /…/ to mark them as JS RegExp objects.
https://github.com/common-workflow-lab/wdl-cwl-translator/blob/63d60b51421a68b819411e36ed47a1df547db411/wdl2cwl/main.py#L852

Alas replaceAll is not in ECMAScript 5.1., but the specification for replace() reminds us that

If searchValue.global is true, then search string for all matches of the regular expression searchValue.

We can set the global flag by formatting the pattern string like /{arg_string_expr}/g with the g suffix.

Alas replaceAll is not in ECMAScript 5.1

:open_mouth: thought it was available in that spec. Sounds like the global flag is the way to go then :+1:


GET /v2/service_instances/:guid/permissions

The sso dashboard documentation states that /v2/service_instances/:guid/permissions should be used to control authorization: https://docs.cloudfoundry.org/services/dashboard-sso.html#checking-user-permissions
The documentation for the space auditor role (https://docs.cloudfoundry.org/concepts/roles.html) states that:

Assign this role to people who need to view but not edit the space.
A Space Auditor can:
View the status, number of instances, service bindings, and resource use of each application in the space

The endpoint /v2/service_instances/:guid/permissions, though, returns true for all space roles:

Developer
Space Manager
Auditor

I would expect this endpoint to only return true for SpaceDeveloper. By returning true for all roles, third party services will allow any space role dashboard access (which likely has write operations).
For example, the Pivotal MySQL service specifically calls out that only users with the SpaceDeveloper role will have a manage link for the dashboard: http://docs.pivotal.io/p-mysql/#dashboard - I would expect /v2/service_instances/:guid/permissions to control visibility of manage.

Hey @cholick
We totally agree.  Pushed a change to clean this up.
Thanks,
@zrob & @wendorf


optimizing overlaps with labels

overlaps with labels vectorized

Codecov Report
Base: 82.81% // Head: 82.81% // No change to project coverage :thumbsup:

Coverage data is based on head (e6d0c6d) compared to base (4ba2032).
 Consider uploading reports for the commit 7dbd320 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   82.81%   82.81%
=======================================
  Files           7        7
  Lines        1117     1117
=======================================
  Hits          925      925
  Misses        192      192

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


A bug in the JWT plugin regarding expiration time verification

The following code is a function for JWT expiration time validation.
My understanding is that if the function returns false, then the JWT has expired.
false is returned only if exp is empty or exp - time() > maximum_expiration.
Let's assume that exp is always there, this function will return false only if exp - time() > maximum_expiration is true.
If the JWT has expired, then exp - time() must be a negative number. However, maximum_expiration must be a value greater than 0.
Thus, exp - time() > maximum_expiration can never be true.
That is, if the JWT is out of date, the function will never tell.
https://github.com/Kong/kong/blob/50b8405d02a3bcdf070033632ef0521db1219371/kong/plugins/jwt/jwt_parser.lua#L364-L380
What do you think?

@yuchunyu97, sounds like you are correct, shouldn't it be time() - exp instead.

@yuchunyu97, sounds like you are correct, shouldn't it be time() - exp instead.

@yuchunyu97, but I think this check does not check whether token has expired or not. It checks that token does not have too big expiration. It is correct.

@yuchunyu97, but I think this check does not check whether token has expired or not. It checks that token does not have too big expiration. It is correct.

@yuchunyu97 this is the actual expiry check:
https://github.com/Kong/kong/blob/50b8405d02a3bcdf070033632ef0521db1219371/kong/plugins/jwt/jwt_parser.lua#L323-L325
So I will close this.

@yuchunyu97 this is the actual expiry check:
https://github.com/Kong/kong/blob/50b8405d02a3bcdf070033632ef0521db1219371/kong/plugins/jwt/jwt_parser.lua#L323-L325
So I will close this.


Map editor not showing this map

@allyoucanmap can you please take a look at this specific map on Nexus server? It appear inside the embed map of the preview panel but not inside the editor.
Please investigate if it's something with the editor or with the data received from the API. In the latter case ask @mattiagiupponi to investigate. I remind you that this data were upgraded from a preivous master version, but I don't think this is an issue caused by migrations.
@allyoucanmap you can get the credentials here

It seems something related to migration, now data is returned as string instead of object cc: @mattiagiupponi

Technically this migration was made in order to fix this issue:
https://github.com/GeoNode/geonode/blob/master/geonode/geoapps/migrations/0006_geoapp_blob_migration.py
@allyoucanmap did you notice that is happening only for this map?

@mattiagiupponi I think that map is not a geoapp but I'm not sure.

did you notice that is happening only for this map?
I only verified this one

@giohappy @allyoucanmap Looks like the maps are already in place in the Nexus DB, the payload was saved/read as str, while now with the new version of the client is saved/read as JSON.
I'm going to open a PR in geonode with a migration (like what we did for the geostories) in order to fix this.
NOTE: the new maps are correctly saved/read

ISSUE: https://github.com/GeoNode/geonode/issues/7911

PR opened here: https://github.com/GeoNode/geonode/pull/7912


✨ Expose QPS and Burst flags on agent command line

Summary
This PR adds command line flags to the OCM Status Add-On Agent for client-side self-restraint, in terms of QPS and Burst, for accessing the local cluster (WEC) and for accessing the hub (ITS).
Related issue(s)

After this change:
mspreitz@mjs13 ocm-status-addon % go run ./cmd/ocm-status-addon agent -h
Start the addon agent

Usage:
  addon agent [flags]

Flags:
      --addon-name string                 name of the addon. (default "status")
      --addon-namespace string            Installation namespace of addon.
      --cluster-name string               Name of spoke cluster.
      --component-namespace string        Namespace of the component.
      --enable-leader-election            Enables the leader election for the controller
  -h, --help                              help for agent
      --hub-burst int                     Allowed burst in requests/sec for accessing the hub (default 10)
      --hub-kubeconfig string             Location of kubeconfig file to connect to hub cluster.
      --hub-qps float                     Max average requests/sec for accessing the hub (default 5)
      --kubeconfig string                 Location of the master configuration file to run from.
      --local-burst int                   Allowed burst in requests/sec for accessing the local cluster (default 10)
      --local-qps float                   Max average requests/sec for accessing the local cluster (default 5)
      --zap-devel                         Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error) (default true)
      --zap-encoder encoder               Zap log encoding (one of 'json' or 'console')
      --zap-log-level level               Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
      --zap-stacktrace-level level        Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
      --zap-time-encoding time-encoding   Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.

Global Flags:
      --log-flush-frequency duration   Maximum number of seconds between log flushes (default 5s)
      --logging-format string          Sets the log format. Permitted formats: "text". (default "text")
  -v, --v Level                        number for the log level verbosity
      --vmodule pattern=N,...          comma-separated list of pattern=N settings for file-filtered logging (only works for text log format)

@MikeSpreitzer: please note that if we want to expose agent flags  the status add-on chart, these values need to be provided to the add-on controller and from there set in the ManifestConfig - see https://github.com/kubestellar/ocm-status-addon/blob/a1f669bafe01d5a337136837138bc85880634a80/pkg/controller/manager.go#L38-L63. The controller builds the manifestwork for the add-on by applying those values to the templates defined in https://github.com/kubestellar/ocm-status-addon/tree/main/pkg/controller/manifests/templates.
Therefore, arguments to propagate to the agent should be templated in https://github.com/kubestellar/ocm-status-addon/blob/a1f669bafe01d5a337136837138bc85880634a80/pkg/controller/manifests/templates/deployment.yaml#L60-L64.

Yes, there is more to do. Can we do it in a follow-on PR?

ok with me

@pdettori: thanks for the pointers about the templating and variables. I am mystified about some. I see https://github.com/kubestellar/ocm-status-addon/blob/v0.2.0-rc8/cmd/ocm-status-addon/main.go#L100-L107 , and it looks like https://github.com/kubestellar/ocm-status-addon/blob/v0.2.0-rc8/cmd/ocm-status-addon/main.go#L102-L106 is moot because there is no AddOnDeploymentConfig , and do not see the source of many variables I see referenced in https://github.com/kubestellar/ocm-status-addon/blob/v0.2.0-rc8/pkg/controller/manifests/templates/deployment.yaml, such as HTTPSProxy and Tolerations.

The mysterious references may be outdated junk; see https://github.com/open-cluster-management-io/addon-framework/issues/270 .
The template might work because of subtleties of Go template functionality<EMAIL_ADDRESS>says that the default behavior when a template references a key that is not in the map is to "Do nothing and continue execution". It is not obvious to me what this means, but it might mean that an enclosing "if" pipeline expands to the empty string.


fix buffer support

There's still lots of unknowns in here, so I made #293 to pull out the smallest change


System blocks are executed multiple times during input_output_response

I'm using the library to build and simulate feedback control systems, which are made up of TransferFunction, StateSpace and NonlinearIOSystem blocks linked together.
During some simulations, I noticed a problem: for each single time sample of the simulation, each system block gets executed more than once. For example, assuming that my feedback control system (with sampling time T=1s) only has two blocks (the plant P and the controller C), at time t=0s I would expect that the code inside P and C gets executed just once, but in reality they get executed multiple times before the simulation goes on to the time sample t=1s. I also noticed that, during the "extra" blocks executions, the inputs of the blocks are all set to zero, no matter the inputs/outputs of the other blocks.
Is anyone experiencing the same problem? Am I possibly using the library in a wrong way? Does anyone have an example of feedback control system where it's verified that this problem doesn't occur?
Thank you

Hi @francesco-paoli-leonardi , here is an example that uses interconnect to connect DT and nonlinear systems (and I just now realized that for some reason it doesn’t appear in the official list of examples) https://github.com/python-control/python-control/blob/main/examples/simulating_discrete_nonlinear.ipynb
when creating nonlinear systems that will be used with the simulator, one to be aware of is that your P and C in general have two functions that get called: the update (dynamics) function and the output function. I have noticed that the output function may get called repeatedly but your update function should get called once per time increment. In other words, make sure your output function has no side-effects.

Are you systems discrete time systems or continuous time systems (with a fix set of times passed as the time steps at which the input is defined)?
For continuous time systems, the integration algorithms (which come from SciPy) will often call a single block multiple times as the algorithm tries to sort out the right step size to use.  So you can definitely get multiple calls to the right hand side of the differential equation (which then traces down to calls for the update function for each block).  The function that controls all of this is scipy.integrate.solve_ivp.
For discrete time systems, the code that executes the simulation is pretty simple (from nlsys.input_output_response):
        for t in t_eval:
            # Store the current input, state, and output
            soln.y.append(x)
            u.append(ufun(t))
            y.append(sys._out(t, x, u[-1]))

            # Update the state for the next iteration
            x = sys._rhs(t, x, u[-1])

The call to sys._rhs goes through each block and calls the update function for those blocks.
As @sawyerbfuller notes above, the output functions can get called multiple times.  In particular, to allow feedthrough terms to propagate correctly, there is a call to a function sys._compute_static_io that calls the output functions of all blocks multiple times to make sure that any direct feedthrough terms (e.g., the D matrix in a linear system) are properly accounted for.
In terms of the specific behavior that you note above, where there are calls with the inputs set to zero: is that for the update functions or for the output functions?  If for the output functions, it may be coming from sys._compute_static_io.
Finally, is there an issue with simulation where you don't think it is carrying out the right calculation?

Thank you both for your clarifications.
Replying to @sawyerbfuller : my problem is exactly what you pointed out, i.e., the output function of my P and C system blocks generally have side-effects when they are executed more than once per simulation time step and/or when they receive "unexpected" values in input. To avoid side-effects, I'm building all my feedback-control system blocks such that all "meaningful" dynamics is embedded in the update function, while the output function behaves just like an identity matrix (or something similar that has no strange behaviors). Still, I'm looking for a way (if is there any) to make the output function of each system block execute just once per simulation time step.
Replying to @murrayrm : as you pointed out, I forgot to mention that all blocks of my feedback-control system are discrete-time (all with same sampling time) and, in my case, the _rhs function executes a scipy.integrate.solve_ivp function that I personally set up in my code, used to update the system blocks at each discrete time step. Also, my system blocks receive all-zeros inputs only during the "extra" executions of the output function, and these all-zeros inputs usually create side-effects in my blocks' output function. Generally, a part from the "extra" executions, the simulation does its job are correctly computes the system evolution over time, but, if the blocks' output function is computationally heavy, their multiple executions per time step makes the simulation slower with respect to what it could potentially be.

@francesco-paoli-leonardi Interesting idea to wrap a solve_ivp inside your discrete-time dynamics to get accurate simulation. In the example I linked to above, I used a similar (less accurate but much faster) approach of discretizing the nonlinear plant using a fixed-step integrator. Someday python-control will get a way to use variable-step integrators with a fixed-step controller model, perhaps using a different integrator (e.g. LSODA method in solve_ivp?) but that is a future project. That example is meant to be an intermediary solution; perhaps if you get something working you might consider adding an example notebook.
Regarding how to get the output to be called only once. My current understanding is that the output function should in general never have any side effects  (such as callling a numerical integrator), but I am curious to see what application you have in mind that might need that.
In the meantime, the other option is to perform the numerical integration yourself, it is only a few lines for a discrete-time system.  You can use the dynamics and output methods (which are there for that exact purpose).

@sawyerbfuller To answer your curiosity: the side-effects I have when executing the output function of a system block multiple times are maily:

when computing a discrete-time integral, the integration gets performed many more times than needed.
when implementing (for example) low-pass filters that make use of sliding-window buffers, the buffer window slides more than once per simulation iteration.

As I said in my previous message, I found a simple workaround for it:

I'm building all my feedback-control system blocks such that all "meaningful" dynamics is embedded in the update function, while the output function behaves just like an identity matrix (or something similar that has no strange behaviors)

I think this issue is resolved, in the sense that we understand what is happening and the issue is due to a fairly uncommon situation, for which there is a workaround.
Issue #1009 is related to this.


Could you add a licence to this repository please?

Thank you.

Forgot to close this.
I added an MIT licence.


Deployment Error with activ Trigger

Hello,
when we deploy the  to the test Synapse Enviroment and some Trigger are activ we getting this Error:
WorkspaceType:] Job was submitted with resources=[24] when the compute has a capacity of=[12]
We need to aktivate some off the definied Triggers from the Develop Enviroment.
For Deployment we are using the mater Branch.

We are working on toggle trigger action. We will be supporting it both in azure devops extension and Github action.

Thanks.
Hope we get the changes in the next few Month.

Closing the issue for now.


Workflow “is waiting for github-pages deployment approval”

Might be that someone with access to repository settings can solve this?

I’ve no idea what state the build is in, Github’s GHA history is currently very weird for this repository.

@strogonoff you should have access now, try again?

It says this now... Maybe there is some issue with the workflow dependencies.

I see what you saw too:

Perhaps cancel and restart?

I didn’t see anything in settings, so perhaps just stuck workflow. Cancelled & it seems to have succeeded.


[BACKLOG-11041] Upgrade to SWT version 4.6

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  build.xml
  ivy.xml


Added Pinwheel Framework

Added Pinwheel to the Activity Indicator section.
Project URL
https://github.com/Astranno/Pinwheel
Category
Activity Indicators
Description
Added Pinwheel to the Activity Indicator section.
Why it should be included to awesome-ios (mandatory)
It is a an iOS UI framework that I have been asked to make. If 1 person finds it useful, other might as well.
Checklist

[ ] Has 50 Github stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[ ] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

1508
301
https://www.moltin.com/swift-ecommerce-sdk/ redirects tohttps://www.moltin.com/developer/swift-ecommerce-sdk/

  Generated by :no_entry_sign: Danger

@Camji55   We cannot merge your PR yet until you fill all of contribution guideline requirements. Feel free to open PR once it is ready.
Please check our CONTRIBUTION GUIDELINES


Spannable to content strings ( and  in text)

Include the following:

Material Dialogs version: <IP_ADDRESS>'
Device OS version: any
Device Manufacturer: any
Device Name: any

It would be nice, when this could be possible.
Reproduction Steps
<string name="crazy_string">My %1$s bold text could be view as %2$s italic.</string>

new MaterialDialog.Builder(this)
                    .content(R.string.crazy_string, "happy", "angry")
                    .show();

Want to create dialog with Text like:

My happy bold text could be view as angry italic.

Expected Result
Dialog with formated text: My happy bold text could be view as angry italic.
Actual Result
My happy bold text could be view as angry italic.

It's actually odd that it's not working, since getText(int) is being used to retrieve the string resource, rather than getString(int).


Separate VM from Hint Execution: Phase 4 (Move DictManager to the ExecutionScopes)

This PR aims to remove DictManager from the VM structure, and instead create it and store it inside the current execution scope when needed.

[x] Remove DictManager from VM and VMProxy
[x] Add helpers to ExecScopeProxy to get references to stored dict_manager
[x] Fix affected hint functions and tests
[x] Remove some clones that will no longer be needed

Depends on #361

Codecov Report

Merging #365 (01715f1) into exec-scopes-any (9c1a0be) will decrease coverage by 0.02%.
The diff coverage is 97.51%.

@@                 Coverage Diff                 @@
##           exec-scopes-any     #365      +/-   ##
===================================================
- Coverage            97.71%   97.69%   -0.03%
===================================================
  Files                   44       44
  Lines                12140    12198      +58
===================================================
+ Hits                 11863    11917      +54
- Misses                 277      281       +4

Impacted Files
Coverage Δ

src/utils.rs
98.75% <ø> (ø)

src/vm/vm_core.rs
97.27% <ø> (-0.01%)
:arrow_down:

src/vm/hints/dict_manager.rs
95.73% <66.66%> (-1.71%)
:arrow_down:

src/vm/hints/dict_hint_utils.rs
99.85% <99.27%> (-0.15%)
:arrow_down:

src/types/exec_scope.rs
81.13% <100.00%> (+0.54%)
:arrow_up:

src/vm/hints/execute_hint.rs
100.00% <100.00%> (ø)

src/vm/hints/squash_dict_utils.rs
99.88% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


remove_isolated_nodes shouldn't mutate passed-in graph

Coverage increased (+0.003%) to 92.23% when pulling 3efedfbcfe27a3d5486f308d1821a4f9f9eef53b on fix into babf3fc0718bb0497c8d046096c621b349e5369c on master.


changelog produces vUnreleased instead of Unreleased heading

In v0.3.12 changelog produced the unreleased headline Unreleased, now in v0.3.13 it produces a vUnreleased headline.
Is this an intentional change?
Unreleased is not a version. Prefixing it with v is surprising and confusing, and IMO wrong.

Thanks for notifying.
This is indeed not intentional. I will fix this soon


Add desktop tools, web tools, social media handlers, blogs and article

Thanks @thoyo!


allow prefix for dictrestore

When using a pretrained model like VGG under a different variable_scope, currently only SaverRestore supports a prefix. This commit adds this functions for DictRestore as well.

For DictRestore this is not needed. Users can just use
dict = {prefix + name: value for name, value in six.iteritems(dict)} to do the same thing.

Users dont care about the internal format of npy files. They want to restore weights from npy files like restoring from checkpoint. It is a matter of consistency.

Users should care about the format if they use DictRestore. That's why it takes a dict but not a file name.

In fact using the dict and npy format is specifically for users to load and modify the model manually. Being easy to load and modify is the only benefit it has compared to tf format.

I see your point. Just wondering, if class *Restore shouldn't share the same interface.

it may be better discuss the function first,  then start coding.

I just code them, when I need them without asking anybody.
Honestly, I don't care if @ppwwyyxx wants them to be included a public version of tensorpack or not. If not, I close the pull-request, like I did in the past. That's the nice thing about GIT and forks.
I understand the point, that this library wants to be light-weight. But I this case I am still convinced, it might be good to keep the interfaces at least consistent. So I use it in my local version.
I respect @ppwwyyxx decision. So there should be no discussion.

About forks, you can also just write a collection of functions for your convenience, e.g. a wrapper around DictRestore or logger.set_logger.dir. This might be easier than maintaining a personal fork.
About light-weight. Yes I hope it's lightweight -- though there is a lot of complexity already. So in general I don't like one-line features.
About consistency: if there are 5 *Restore and one is different from others, I'll call it a consistency issue. These two in my mind were just two things with different functionalities and therefore different APIs. I don't even know if there will be a third *Restore, because I can't imagine what else one can need.


Tiered rolls (same highest roll) don't offer a proper way to deal with it when End Automatically is enabled.

Describe the bug
Last raid i came to this situation when highest rolls were the same. However i didn't have any option to "solve the tie" or was there any further announce from the addon that there was a tie. It simply came to a halt.
To Reproduce
Steps to reproduce the behavior:

Have 2 players roll the same highest roll. (which is what i tried to do with the adding a custom roll "stage" so we get there sooner by having to only roll between 5 numbers, not 100, but it seems there is no option for that in the addon).
Have End Automatically.
There is no "Solve tie" option.

Expected behavior
Should have the "Solve tie" option when you have End Automatically checked.
Screenshots
Sadly, don't have video or screenshots.
Version:

WoW cata
Addon 2024-06-04

Additional context
Add any other context about the problem here.

Good point, I'll change it so that tie rolls are never ended automatically.


Metamorphic transformation leads to WebGL blue-screen

[Shaders, screenshots, error log, reproduction steps, etc.] [ZIP]
Device: AMD R9 Fury
Windows 10 driver version: 16.9.2
Comparison of observed effects available here.

AMD Report Form ("n/a" means not filled):
Graphics Card Model:
Radeon R9 Fury X
Graphics Card Part Number:
n/a
AMD Radeon Software Driver Version:
AMD Radeon Software Crimson Edition 16.9.2
Driver History:
Do Not Know
Operating System:
Windows 10 64-bit
Type of Issue:
Other
Crossfire Configuration:
No
Using Mantle:
No
Other Games/Applications:
Google Chrome
Describe the Issue and Steps to replicate:
We use a custom written WebGL launcher and Chrome (self-contained HTML available for download at [1]; paste the shader code in the top box and hit "Execute"). When rendering the shader via WebGL, the device driver crashes. A number of things might happen:
* The browser continues fine, with the "Rats! WebGL hit a snag!" message
* The browser hangs, with the ability to force-close it
* The machine blue-screens, with the "THREAD_STUCK_IN_DEVICE_DRIVER" error
The effects are more deterministic with an ANGLE-based binary (source available for download at [2]). On our machine, we can reproduce the blue-screen consistently upon the first attempt at rendering the shader.

The shaders we used are available to see at [3]. Additionally, the problematic shader is available for download at [4].

[1] http://htmlpreview.github.io/?https://github.com/mc-imperial/shader-compiler-bugs/blob/master/utils/webgl/webgl_viewer.html
[2] https://github.com/paulthomson/GetImageAngle
[3] https://github.com/mc-imperial/shader-compiler-bugs/issues/28
[4] <LINK_REMOVED>

CPU Details:
Intel(R) Xeon(R) CPU E5-1630 v3 @ 3.70GHz, 3701 Mhz, 4 Core(s), 8 Logical Processor(s)
Display Devices and Connections used:
Dell S2009W on HDMI
Motherboard or System Make & Model:
n/a
Motherboard BIOS version:
n/a
System Memory Type & Amount:
32GB
Power Supply Wattage:
n/a

AMD fixed this in driver version 17.1.1.


net/http: ServeMux redirect loses query info

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.1 windows/amd64
What operating system and processor architecture are you using (go env)?
go version go1.7.1 windows/amd64
What did you do?
this error cannot be seen on play as it requires http.
package main

import (
	"fmt"
	"net/http"
)

func main() {

	http.HandleFunc("/testOne", testOneHandler)  // no slash at end or you lose the query string
	http.HandleFunc("/testTwo/", testTwoHandler) // no slash at end or you lose the query string

	http.ListenAndServe(":8008", nil)

}

func testOneHandler(w http.ResponseWriter, r *http.Request) {

	textOut := r.URL.Query()
	fmt.Fprintln(w, textOut)

	return
}

func testTwoHandler(w http.ResponseWriter, r *http.Request) {

	textOut := r.URL.Query()
	fmt.Fprintln(w, textOut)
	return
}

What did you expect to see?
This version works:
input URL:  http://localhost:8008/testOne?this=that
result:  URL stays the same, and the output is:  map[this:[that]]
This doesn't:
input URL:  http://localhost:8008/testTwo?this=that
result:  URL is redirected to http://localhost:8008/testTwo/
there is no output.
conclusion:
query strings are lost when the input URL and the http router have a "/" at the end of the selector.
this error was initially reported in #5382,
I hope that this is sufficient information.

In summary:
bradfitz@gdev:~$ curl 'http://localhost:8080/testOne?foo=bar'
/testOne?foo=bar
bradfitz@gdev:~$ curl 'http://localhost:8080/testOne/?foo=bar'
404 page not found
bradfitz@gdev:~$ curl 'http://localhost:8080/testTwo?foo=bar'
Moved Permanently.

bradfitz@gdev:~$ curl 'http://localhost:8080/testTwo/?foo=bar'
/testTwo/?foo=bar

I assume your question is about my third case? (http://localhost:8080/testTwo?foo=bar)
But you said http://localhost:8080/testTwo/?foo=bar in your bug report, which I assume is a mistake.
What is your actual bug report?

correct, I edited the issue to reflect the typo.  The error is in case #3 where a re-direct occurs and doesn't forward the query string.  Thanks for looking at this.

And here is a playground runnable repro https://play.golang.org/p/t0sLqU5tIS for anyone who wants to test or fix the bug.

I've mailed https://go-review.googlesource.com/43779.

I was just whetting my appetite for Kubernetes code and testing it out, then noticed that this bug fix breaks their two of their tests(which seemed to rely on the old buggy behavior)

with the test failing when they encounter:
server_test.go:1327: 7: response location: expected http://localhost:12345/exec, got http://localhost:12345/exec?ignore=1&command=ls&command=-a&output=1

Just a note as am also going to file a bug on their project for them too, to keep vigilant when they update to Go1.9.

@odeke-em, nice find! Yeah, if you could send them a PR to make their test work with either Go 1.8 or Go 1.9, that'd save everybody a lot of hassle later. Thanks!

Aye aye, done sent in https://github.com/kubernetes/kubernetes/pull/46306.

From offline discussions, the closing CL broke the builds at tip and didn't account for the case where Redirect was invoked directly with a full URL that itself had its own query string. Reopening this issue.

From offline discussions with @bradfitz, the closing CL broke the builds at tip and didn't account for the case where Redirect was invoked directly with a full URL that itself had its own query string. Reopening this issue.

We should only change ServeMux, not func Redirect.

@odeke-em Could you take a look at the CL?

Thank you for the ping @namusyaka, and thank you for the CL, I am going to take a look at it in a few.

@sdwarwick The issue has been fixed by this commit. Please let me know if you still have the issue.


issue #156 - Added the function setBidTTL(bidId) to replace repeated …

Description
I changed redis.expire(bids:${bidId}, config('bids_ttl')); to setBidTTL(bidId) and I create the function to solve the repeated code.
Related Issue
#156

Hey @ArnaudButel I accidentally approved the review, but you are yet to make the changes! 🙂

Sorry, I made the change and remove the async.


feat(admin): Project Quarantine

This set of changes introduces a concept of Project Lifecycle Status, and specifically adding and removing projects from a quarantine status.
There are no end-user facing changes yet, and those will only be introduced after this PR is merged/deployed (so there's no race condition with ORM changes and columns not existing in time...)
The intent is to have a status that can convey that we are not certain if a project is good or bad yet - but it's concerning enough that we want to make in unavailable to installers or mirrors. Those changes will follow later.
This is mostly to get a feel for how it will work on the Project's model and how things enter and exit quarantine.

Admin Interface for Quarantine 👩💻 - Watch Video


[ACR] Creating managed registries doesn't appear to work

Description
When I attempt to run the az acr create command,  and specify any of the Managed_* SKU options via the --sku flag, it spins for a few moments and then spits out the following error:
Deployment failed. {
  "error": {
    "code": "NoRegisteredProviderFound",
    "message": "No registered resource provider found for location 'westus' and API version '2017-06-01-preview' for type 'registries'. The supported api-versions are '2016-06-27-preview, 2017-03-01, 2017-06-01-preview'. The supported locations are 'westus, eastus, southcentralus, westeurope, northeurope, uksouth, ukwest, australiaeast, australiasoutheast, centralindia, eastasia, japaneast, japanwest, southeastasia, southindia, brazilsouth, canadaeast, canadacentral, centralus, eastus2, northcentralus, westcentralus, westus2'."
  }
}

If I set specify --sku Basic, then everything works great, but I'd really like to use a managed registry :) Am I doing something wrong? Any help would be greatly appreciated!

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: bash interactive script
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:
azure-cli (2.0.10)
acr (2.0.8)
acs (2.0.10)
appservice (0.1.10)
batch (3.0.3)
billing (0.1.3)
cdn (0.0.6)
cloud (2.0.6)
cognitiveservices (0.1.6)
command-modules-nspkg (2.0.1)
component (2.0.6)
configure (2.0.10)
consumption (0.1.3)
core (2.0.11)
cosmosdb (0.1.10)
dla (0.0.10)
dls (0.0.10)
feedback (2.0.6)
find (0.2.6)
interactive (0.3.6)
iot (0.1.9)
keyvault (2.0.8)
lab (0.0.8)
monitor (0.0.8)
network (2.0.10)
nspkg (3.0.1)
profile (2.0.8)
rdbms (0.0.5)
redis (0.2.7)
resource (2.0.10)
role (2.0.8)
sf (1.0.5)
sql (2.0.7)
storage (2.0.10)
vm (2.0.10)
Python (Darwin) 2.7.10 (default, Feb  7 2017, 00:08:15)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
Python location '/Users/joncart/lib/azure-cli/bin/python'
OS Version: What OS and version are you using?
Answer here: macOS
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: bash

@lostintangent Thank you for trying out managed registries.
Basic SKU is globally available but managed registries is a preview feature that is available in three regions West Central US, East US, and West Eurpoe.
ARM however returns a bad error message too in this case. @tjprescott What is a good way for this scenario besides hard code the three regions? /cc @SajayAntony

@djyou Ah OK, using westcentralus fixed it! Thanks for that clarification :)

@tjprescott Can you please close this issue as the service has been available in all regions? Thanks.


Fixed CONTRIBUTING.md file name

Changed the name of the contribution file from CONTRIB.md to CONTRIBUTING.md. Also added a link to the file in README.md.
Relates to #212

I set the link in README.md to go to ../CONTRIBUTING.md rather than the current ../CONTRIB.md. I'm not sure if the link will change if the file name changes, but if not, can somebody update it for consistency?
Also, if this pull request goes through, can you please close #184 , #185 , and #213 ?

Thank you for your contribution!


refine use cache for mpt model

What does this PR do?

Modified the kv_cache initialization method and optimized performance.
Co-author:  @atakaha
Test command:
python run_generation.py --model_name_or_path mosaicml/mpt-7b --use_hpu_graphs --use_kv_cache --limit_hpu_graph --batch_size 128  --max_input_tokens 128 --max_new_tokens 128 --trim_logits --attn_softmax_bf16 --warmup 3 --n_iterations 1 --bf16

Result:

Version
batchsize
max input tokens
max new tokens
Throughput (including tokenization)(tokens/s)
Memory allocated(GB)
Max memory allocated(GB)

before
128
128
128
2900
37.28
64.39

after
128
128
128
4803
29.28
48.39

before
16
128
1024
624
26.55
41.79

after
16
128
1024
1215
23.04
33.77

before
2
1024
1024
197
16.27
19.66

after
2
1024
1024
255
15.27
17.66

before
16
1024
1024
384
40.78
67.86

after
16
1024
1024
846
32.78
51.86

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@Jing1Ling can you check the other PR https://github.com/huggingface/optimum-habana/pull/1126, the code base has changed there

@Jing1Ling can you check the other PR #1126, the code base has changed there

@yafshar Thank you for the reminder. I believe this patch is a more concise approach. It only changes a few lines of code, achieves lower memory usage and similar throughput.

Why this change causes such a large decrease in memory usage:
The conclusion is that 'query_states', 'key_states', and 'value_states' are all views of 'mixed_qkv'. When I create a new tensor tuple and copy 'key_states' and 'value_states' into it, 'mixed_qkv' will be released after the attention function returns.
Before the modification, 'key_states' and 'value_states' were saved in 'past_key_value' as views of 'mixed_qkv', so 'mixed_qkv' could not be freed. In other words, with the change in this PR, each transformer layer (block) can save the space of one 'query_states' during the decode first token process(create k, v but release mixed_qkv, thus saving the space of one q).
I used torch.hpu.synchronize() and torch.hpu.memory_summary() to do memory statistics at each stage of decoding the first token.
# exit after decoding the first token
python run_generation.py --model_name_or_path mosaicml/mpt-7b --use_hpu_graphs --use_kv_cache --limit_hpu_graph --batch_size 8 --max_input_tokens 128 --max_new_tokens 5 --trim_logits --attn_softmax_bf16 --warmup 3 --n_iterations 1 --bf16

Here is some evidence:

@Jing1Ling thanks.
@atakaha is this PR cover everything you added in https://github.com/huggingface/optimum-habana/pull/1126

@Jing1Ling thanks. @atakaha is this PR covers everything you added in #1126

In the point of performance, YES. In the point of "--reuse_cache" implementation like other modes, no.

@Jing1Ling thanks. @atakaha is this PR covers everything you added in #1126

In the point of performance, YES. In the point of "--reuse_cache" implementation like other modes, no.

@atakaha can you tell me what is missing for --reuse_cache implementation? With the current implementation the memory usage seems the same and I think that is the main point of reuse_cache. So if you add that extra code what is the benefit? Am I missing anything?

Do you think any other model might benefit from this? As far as I can tell, mixed qkv is a feature of mpt/dbrx, and of the 2 we only have MPT here right?

Here is only MPT. I think the same can be useful for any similar model

@Jing1Ling thanks. @atakaha is this PR covers everything you added in #1126

In the point of performance, YES. In the point of "--reuse_cache" implementation like other modes, no.

@atakaha can you tell me what is missing for --reuse_cache implementation? With the current implementation the memory usage seems the same and I think that is the main point of reuse_cache. So if you add that extra code what is the benefit? Am I missing anything?

The --reuse_cache implementation is followed other models, such llama, mistral approach. This PR introduce same performance of  improvement of --reuse_cache implementation.

@Jing1Ling thanks. @atakaha is this PR covers everything you added in #1126

In the point of performance, YES. In the point of "--reuse_cache" implementation like other modes, no.

@atakaha can you tell me what is missing for --reuse_cache implementation? With the current implementation the memory usage seems the same and I think that is the main point of reuse_cache. So if you add that extra code what is the benefit? Am I missing anything?

The --reuse_cache implementation is followed other models, such llama, mistral approach. This PR introduce same performance of improvement of --reuse_cache implementation.

@atakaha thanks. Then please close https://github.com/huggingface/optimum-habana/pull/1126, let us merge this PR first and if there is any missing functionality we can start a new PR on top of this. Thanks for your contribution

@Jing1Ling thanks. @atakaha is this PR covers everything you added in #1126

In the point of performance, YES. In the point of "--reuse_cache" implementation like other modes, no.

@atakaha can you tell me what is missing for --reuse_cache implementation? With the current implementation the memory usage seems the same and I think that is the main point of reuse_cache. So if you add that extra code what is the benefit? Am I missing anything?

The --reuse_cache implementation is followed other models, such llama, mistral approach. This PR introduce same performance of improvement of --reuse_cache implementation.

@atakaha thanks. Then please close #1126, let us merge this PR first and if there is any missing functionality we can start a new PR on top of this. Thanks for your contribution

@yafshar, https://github.com/huggingface/optimum-habana/pull/1126 is closed.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


confluent_kafka_topic support

What problem are you facing?

I would like to deploy confluent_kafka_topic resources via crossplane.
How could Crossplane help solve your problem?

Add confluent_kafka_topic support to confluent-provider

Would be nice to merge this.


feat(Select): add disabled option

FX-2160
Description
Added a disabled option
How to test

FIXME: Add the steps describing how to verify your changes

Screenshots

Before.
After.

Insert screenshots or screen recordings
Insert screenshots or screen recordings

Review

[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

@vshyrokov Great catch! Fixed ✅

The color of the disabled item is still incorrect because we have an opacity of 0.5 there.


Key with space in query params not working properly

Environment
Name: Ufo
Version: 1.1.2
Reproduction
Add any query params in which key is having space in it.
Describe the bug
Add any query params in which key is having space in it and check space is converted to '+' sign while encoding but while decoding '+' sign is not getting converted back to space.
Additional context
No response
Logs
No response

Raised PR: https://github.com/unjs/ufo/pull/150


[Finish #121366693] Update README

What this PR does
Updates the application's README.

Coverage remained the same at 82.73% when pulling 3e4f2d4bf65c6fc1c7590a339e5b7a93a19033f6 on chore/update-readme into f8dc96ab12fb6107cbafda6d09ae1fbd57c5dcdc on develop.

Coverage remained the same at 82.73% when pulling bc2f3f26f6c71485db770a380eac4f04ffd16c5d on chore/update-readme into f8dc96ab12fb6107cbafda6d09ae1fbd57c5dcdc on develop.


Feature/issue add matern 3/2 prim

Submission Checklist

[x] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
Add a Matern 3/2 Kernel (Covariance Function) to Prim library, with ARD prior support.
How to Verify:
Summary:
Add a Matern 3/2 Kernel (Covariance Function) to Prim library, with ARD prior support.
How to Verify:
Tests include, but are not limited to:
vec double
vec double double
vec double ARD
vec eigen
vec eigen eigen
vec eigen ARD
vec double double ARD
rvec eigen
rvec eigen ARD
vec eigne rvec eigen
vec eigen rvec eigen ARD
rvec eigen rvec eigen
rvec eigen rvec eigen ARD
eigen mixed
eigen mixed ARD
double domain err training
nan error training
differing x lengths
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Copyright <2018>
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I get this error: Remote call on gelman-group-mac failed. The channel is closing down or has closed down, something about sending an email to null, and creating the zip file, which has nothing to do with this PR. All other tests were passed fine.
I'm checking out this post: http://discourse.mc-stan.org/t/new-jenkins-jobs-tutorial/2383/8
and I can't load the job pipeline because I don't have "Job configure permission". Can some one please reset these tests when they get a chance?

I probably have permission, but I can't find the screens in the interface.  If someone can send me a URL to something I can push to restart, I'm happy to push the button.

updating calculations and docs so they are the consistent with exp_quad covariance function


Pass an absolute path to build.ImportDir(). It is assumed to always be t...

...he case.
Explanation at https://code.google.com/p/go/issues/detail?id=9057
This fixes using "errcheck ./..."
Also, add the ImportPath instead of whatever name provided; normally "." or things like "./lib".
This doesn't fix "errcheck ." locally.

This CL is stale but the problem subsist. I'll close this pull request and redo a proper one based on the recent code base. To clarify, the problem exists if GOPATH is a symlink, I filed a proper bug as https://github.com/kisielk/errcheck/issues/65.


[pipeline] Result is wrong for RIGHT SEMI JOIN

Steps to reproduce the behavior (Required)
SELECT *
FROM
(
    VALUES (1,2)
) t1
RIGHT SEMI JOIN
(
    VALUES
        (1,2),
        (1,3)
) t2
ON t1.column_0 = t2.column_0 AND t1.column_1 != t2.column_1;

Expected behavior (Required)
+----------+----------+
| column_0 | column_1 |
+----------+----------+
|        1 |        3 |
+----------+----------+
2 rows in set (0.01 sec)

Real behavior (Required)
+----------+----------+
| column_0 | column_1 |
+----------+----------+
|        1 |        2 |
|        1 |        3 |
+----------+----------+
2 rows in set (0.01 sec)

Let me fix this issue.


Fix missing ghost.fullname in template call.

What this PR does / why we need it: Given I am a user of this chart,
When I try to deploy this using serviceType NodePort,
Then helm will explode and tell me that
Error: render error in "ghost/templates/NOTES.txt": template: ghost/templates/NOTES.txt:39:130: executing "ghost/templates/NOTES.txt" at <{{template "fullname...>: template "fullname" not defined

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test
/lgtm
You'll need to rebase and bump the version in Chart.yaml again, though.

/lgtm

This PR seems to be blocking on @tompizmor and @prydonius. Would it be possible to get it merged within the next 24 hours? I don't really want to keep merging haha. 😆

In general, you can wait with merging until the PR is approved. I'm pretty active and once the PR has been approved, you've done the merge, I can simply lgtm it again to merge it to master.
The maintainers are pretty busy people, I'm afraid :(

/lgtm

Thank you @timstoop and @prydonius! I know you guys must be really busy, so thank you for taking the time! =] <3

Thank you @ejamesc for the fix, and sorry for the delay! Just FYI, the repo maintainers are also able to push to your branch and we often merge/rebase to resolve conflicts before LGTM'ing when we can to avoid the feedback loop :), so no worries about that. Of course, if we can get them merged before a conflict happens, that's always better!

Oh! Alright then, thanks for telling me, I’ve learnt something new. :)

Gah, I just realised that due to a bad merge to master, I changed the Ghost app version to 1.22.2 (the latest release is 1.22.1. Should I update?


Simplify or remove assert_*_equal wrappers around pandas.testing functions

We have our own wrappers in conftest.py for the three pandas assert_X_equal functions.  We originally added those because the default tolerances of those functions changed in pandas 1.1.0 (see #1018).  Our wrappers check the version of pandas and do some simple kwarg manipulation based on whether the installed pandas is greater or lower than 1.1.0.
Now that our minimum pandas is greater than 1.1.0, the version checking is no longer needed and we can simplify those functions.
It is also worth looking into whether we can/should get rid of those wrappers entirely and just use the pandas functions directly, but that change might require a lot of work (https://github.com/pvlib/pvlib-python/issues/1018#issuecomment-668631386).

I think we should just get rid of our own wrappers, and use pandas.