tornado: Add None check for SHARED_SECRET.

Comparing secret with None is an unintended behavior. When SHARED_SECRET is
None, we avoid the comparison and deny the request.
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Technically, constant_time_compare accepts None and does the comparison anyway by forcing it into a str, but this is probably not what we intended for in this case.

I was thinking it might be better to just refuse to startup, by creating a get_mandatory_secret that returns str and throws an exception if the value is unset, and use it for these.
# Make this unique, and don't share it with anybody.
SECRET_KEY = get_mandatory_secret("secret_key")

# A shared secret, used to authenticate different parts of the app to each other.
SHARED_SECRET = get_secret("shared_secret")

But yeah, I like the alternative get_mandatory_secret approach, it might be better to throw the error at startup

OK, I got that implemented. Do we have a setup to test the settings?

This breaks generate_secrets.

I'm not sure how we want to fix this. Whenever zproject.settings get imported, we run into this error, even if we are going to set up the secrets. We can't really handle the error in a try-except block, because the imported settings will be out of scope.
We can't really check if app_is_ready in get_mandatory_secret, because this function won't get called again once the server is up.
    try:
        apps.check_apps_ready()
    except AppRegistryNotReady:
        logging.exception(
            f'Mandatory secret "{key}" is not set; falling back to an empty string.'
        )
        return ""
    else:
        raise ZulipSettingsError(f'Mandatory secret "{key}" is not set')

Another possibility will be writing the mandatory secrets to the secrets file first before importing zproject.settings, but we won't be able to drop the changes if any error occurs during the setup. We can probably get around this by creating a temporary file first.
Another solution will be mocking get_mandatory_secret, which feels hacky.

We should go back to your previous approach (a3f6f59133e5b36b9edaf3b2a3ecf8e859c77648). The Django settings module is designed for assigning values to Django’s settings, not for running custom validation checks.
There is a system check framework we could use, but it would not save us from the typing issue that forces us to check for None at runtime anyway.

As I expected, this system check feels overengineered. It provides no typing benefit (because we need to do the runtime check anyway), no security benefit (because we need to do the runtime check anyway), and negligible practical benefit (the installer automatically sets up SHARED_SECRET, and nobody’s ever complained to us about it becoming misconfigured). I think the runtime check is plenty.

As I expected, this system check feels overengineered. It provides no typing benefit (because we need to do the runtime check anyway), no security benefit (because we need to do the runtime check anyway), and negligible practical benefit (the installer automatically sets up SHARED_SECRET, and nobody’s ever complained to us about it becoming misconfigured). I think the runtime check is plenty.

Yes. I feel the same. It also requires us to ensure that the check is invoked when appropriate. Unless we have more use cases for system checks. For context, the implementation is in cb5da0592fa18f1403cec180b9aaeb59c01c5730.

Yeah, we don't want to use Django's system check framework for this. The extra manage.py check calls are a startup performance issue.
I think the credible options are:

Go back to the get_mandatory_secret API, and fix the generate_secrets issue by having it set a DISABLE_MANDATORY_SECRET_CHECK environment variable or something (one of the few pays to pass information to the settings codebase; we use it for SENTRY_DSN, for example) to skip mandatory secret checks. This would provide the typing advantages we want without much added complexity.
Giving up on a version with a typing benefit, and just doing runtime assertions.

This env var solution is way cleaner than the other approaches. We do compromise "mandatoriness" by stubbing an empty string for the secret when the flag is enabled, but I guess that's fine.

Merged, thanks for cleaning this up @PIG208!
Can you do a quick check on whether there's any documentation updates we should make to docs/subsystems/settings.md, either related to this or inspired by your having spent time in the subsystem?

Opened #22789


Suggestion: Show both poe.ninja and pathofexile.com/trade values side by side

I saw a previous open feature request was tied back to being a duplicate of Issue #3.  You replied in January that you were working on a pre-release version that looks at pathofexile.com/trade but that issue was automatically closed due to lack of response.
I think it is extremely important to show both poe.ninja and pathofexile.com/trade side by side because just now I was searching on the unique item The Gryphon.  Your tool suggested I should list it for 13c, but if you go to pathofexile.com/trade there is not a single one listed in our current league for less than 45c, and when I search for ones that have stats matching the one I have there's not a single wan listed for less than 100c!  That's a huge difference!

Here is another example: https://imgur.com/LfePgsT ... on the right is my item (with its stats shown), in the middle is what Poe Overlay suggested (20.81c, however when I told it to do a search it came back with 1 item for 150c), and on the left is pathofexile.com/trade showing a manual search I did for the same items with stats as good as or better than mine.  The cheapest is 100c.
I know it would probably be slower (due to rate limiting), but IMO It would be much more useful if PoE Overlay did a search for every item and showed both results without needing me to manually intervene each time I want more detail.  (Because frankly, with discrepancies like this it makes me want to do manual searches every time, so I'm intervening every time.)
I hope I don't sound too harsh - I do appreciate the work you've put into this tool (it has helped me speed up my sorting!) - I'm just trying to be helpful.  But I wanted to actually show you the reason behind my suggestion because I know sometimes it's easy to read a suggestion and disregard it!


Improved issue template configuration

I've used a config file to remove the How-To issue template and replace it with a link to the Discord server :)

Thanks you, this is better.


Capture atom view in index

This PR introduces atom html in our index. Also unrelated flaky bug fixes for some test failures that appeared in the card-catalog modal.

Looks good, would it make sense to include it in #1383?

Yeah, it should be a search result format that you can ask for.

Looks good, would it make sense to include it in #1383?

Yeah, it should be a search result format that you can ask for.

that said, i think you only need to return this format if the client asks for it--so it should be part of the parameters of the search function. (which maybe means it's not something that fits in your Pr, but perhaps a subsequent PR)


sdk - android - max Retry option

In the DefaultDispatcher, we are doing a re-try when the track call goes unsuccess and the events cache has elements. Possible to have MAX_RETRY option? by this way, we can control the app running in thread without re-trying always till app is closed or kill.
For example i expect when piwik (matomo) server was down, I expect app can re-try only 5 times.
https://github.com/matomo-org/matomo-sdk-android/blob/master/tracker/src/main/java/org/matomo/sdk/dispatcher/DefaultDispatcher.java

What would happen after exceeding the MAX_RETRY value?
How would you differentiate server down from connectivity issues, where the user is, e.g. in a subway?

My intention is to stop the thread keep on running when there is server down or connectivity issue, probably can we write the events cache in disk and try when we app re-open?

Did you notice this having a negative impact? The current code would have it retry every 5 minutes, a thread consumes virtually no resources while sleeping. If the app is in the background during that time the system will kill it anyways.

agreed when we have retry every 5 minutes our impact is low and when the app is in background this will be killed. What happens when we have dispatchInterval 0 ?
        mPiwikTracker = Piwik.getInstance(getReactApplicationContext()).newTracker(TrackerConfig.createDefault(url, id));             mPiwikTracker.setDispatchInterval(0);
and we will have sleepTime as 0.
` while (mRunning) {
try {
long sleepTime = mDispatchInterval;
if (mRetryCounter > 1) sleepTime += Math.min(mRetryCounter * mDispatchInterval, 5 * mDispatchInterval);
                // Either we wait the interval or forceDispatch() granted us one free pass
                mSleepToken.tryAcquire(sleepTime, TimeUnit.MILLISECONDS);
            } catch (InterruptedException e) {Timber.tag(LOGGER_TAG).e(e); }`

Note: I am trying to avoid queuing in the client app, and I am trying to dispatch the track immediately to the piwik server, so dispatchInterval is 0.


Issue with options

Getting into the service, options are cool
Thing is, I'm testing the implantation through rails
But 'multiple' & 'drag_text' options does not work   implemented this way :
<%= f.filepicker_field :file_url, dragdrop: true, services: %w( COMPUTER ), multiple: true, drag_text: "Ajouter...", container: "modal" %>
Should it be done another way ? Is it restricted to another subscriptions level ?

Closing, since no feedback was provided here.


Code issues

datas = read_pkl(hp.pkl_path_08).
May I ask what data is loaded in this code ?It caused the following error.
IndexError: too many indices for array : array is 1-dimensional, but 2 were indexed.

We are very sorry for not being able to reply to you in time.
I failed to find this error when running our data set locally. The possible reason may be a conflict between numpy and pickle versions.
The read data is in the form of a list: List[train,val,test]


Add persistent velocity as a step towards player physics

This PR does the following

Adds persistent velocity and acceleration, which is off by default and can be toggled with "V".
Puts player movement logic into character_controller.rs to separate it from the netcode and prediction logic.
Various changes/refactors to make this separation of logic possible, some of which will likely need revision.

While I believe this PR is technically in a mergeable state, I do not have that much confidence in the current state of this PR and am definitely open to suggestions on how to improve the readability/maintainability of this code. I have the following specific concerns:

[ ] I have the server pass a SimConfig object to the client, which reduces some code repetition, but it also likely adds unwanted coupling between config file organization and the actual simulation configuration.
[ ] The prediction logic and server communication doesn't seem to mesh well with the entity-component abstraction, and it seems like fields are being passed around ad-hoc.
[ ] A lambda is passed into PredictedMotion, and a type parameter is used, both in order to allow mocking for the wraparound() test. However, the lambda setup seems quite ad-hoc and fragile, and it's not obvious that the type T refers to a tick of input.
[ ] The handle_net function has a large amount of code repetition. The update_position function should probably be inlined into handle_net to make the code look more consistent. This is mostly a symptom of the ad-hoc non-entity-component setup of message passing.
[ ] The purpose of CharacterControllerPass is to stuff contextual information into the self parameter and rely on regular arguments in helper functions for information relevant to the function. However, I'm not that familiar with this design pattern and am not sure if it's an antipattern. I have a more complete example at collision-demo.
[ ] The no_clip toggle option's current state is used as part of the input struct rather than toggling no_clip being a kind of input. I believe this likely results in cleaner logic, but it's a bit unintuitive.

I have the server pass a SimConfig object to the client, which reduces some code repetition, but it also likely adds unwanted coupling between config file organization and the actual simulation configuration.

This is fine, and matches my design in other projects. There's already SimConfigRaw specifically to decouple the details of the config file from the in-memory form, and we can add other intermediate forms in the future if needed.

The prediction logic and server communication doesn't seem to mesh well with the entity-component abstraction, and it seems like fields are being passed around ad-hoc.

Not sure what you're getting at here; they seem to relate to the ECS in the same way any logic would?

A lambda is passed into PredictedMotion, and a type parameter is used, both in order to allow mocking for the wraparound() test. However, the lambda setup seems quite ad-hoc and fragile, and it's not obvious that the type T refers to a tick of input.

This decision puzzled me as well. I'd leave PredictedMotion and its methods monomorphic for simplicity, and maybe see if you can bundle up the state that it cares about into a single long-lived structure inside Sim that can be passed as one mutable reference.

The handle_net function has a large amount of code repetition

This will be mitigated if you refactor the message as my review recommends.

The purpose of CharacterControllerPass is to stuff contextual information into the self parameter and rely on regular arguments in helper functions for information relevant to the function

See discussion of PredictedMotion above. In general this pattern isn't terrible, but it's a clue that there may be a better way to organize your code.

The no_clip toggle option's current state is used as part of the input struct rather than toggling no_clip being a kind of input.

This is correct. How input is physically expressed by the user should be kept decoupled from what the input represents. See also why we have a motion vector instead of w: bool, a: bool, s: bool, d: bool or whatever.

General note: I can give much better code review if you make changes in the form of small, independent, self-contained commits. Reviewing a commit that changes a bunch of unrelated things for reasons that will only become clear in the context of code in another commit, or code that hasn't even been pushed yet, is difficult.

General note: I can give much better code review if you make changes in the form of small, independent, self-contained commits. Reviewing a commit that changes a bunch of unrelated things for reasons that will only become clear in the context of code in another commit, or code that hasn't even been pushed yet, is difficult. This does usually mean having to rearrange your changes after you first draft them, especially when you're still developing the habit, but the result is much more likely to work as intended.

Good to know. Believe it or not, this is actually the revised version. My first draft lives in collision-wip, which has smaller commits, but their far less organized. The first commit felt like none of its changes made sense without the context of the other changes in that commit, and it wasn't clear how I could split it further, or whether it made sense to try. I'll keep trying to build up the skill of crafting a sensible commit history.
Nevertheless, your review was exactly what I was looking for, as I should be able to find my footing again. Thanks for the detailed review!

The prediction logic and server communication doesn't seem to mesh well with the entity-component abstraction, and it seems like fields are being passed around ad-hoc.

Not sure what you're getting at here; they seem to relate to the ECS in the same way any logic would?

One possibility I was picturing was that predicted information could live in a component rather than being pure internal system data. This could potentially be useful if multiple entities are involved in a single prediction. Also, in engines like Unity, entities have a "transform" component which directly affects draw calls, but in this PR, the draw calls depend on PredictedMotion with additional extrapolation on top of that.
Your response suggests that this is nothing to worry about, and I have no disagreements.
Everything else you said in https://github.com/Ralith/hypermine/pull/247#issuecomment-1356476698 makes sense to me.

predicted information could live in a component rather than being pure internal system data

This isn't an unreasonable thought, but when there's always exactly one predicted character, shoving the data into the ECS just adds unnecessary ceremony. If we add other forms of prediction which are less narrow (e.g. player-fired projectiles) then that state should definitely live in components.

entities have a "transform" component which directly affects draw calls, but in this PR, the draw calls depend on PredictedMotion with additional extrapolation on top of that.

We should move towards a normalized transform component eventually, both for prediction of the local character and for interpolation of server-governed states. That way downstream logic has a homogeneous data model to work with. However, since there isn't really any downstream logic other than the renderer, the simpler existing pattern isn't doing any harm; one step at a time.

I have applied all your suggestions, so this should be ready for another review. The diff of my latest changes are in https://github.com/Ralith/hypermine/commit/6902a955788111bfceae1edf2658e5e2e503a007. This lives in my collision-wip branch, which I've used to (temporarily) keep track of the true history of changes I've made over time. While the branch as a whole is confusing and not really useful for reviewing, this single commit representing the minor changes I most recently made may be useful.

@Ralith: My plan for future PR revisions is to push the changes to GitHub, leave a summary comment of the changes, and re-request the review (without making a comment "mentioning" you like this one). I believe this strikes a good balance in ensuring you see my changes without being discourteous.
However, I'm not 100% sure that GitHub notifications are reliable enough for this to work. To avoid accidentally being in a situation where both of us are waiting for each other, please can you confirm that leaving a comment and re-requesting the review (the things I did three hours ago) are sufficient?

Yep, that's a fine workflow and should reliably notify me in ways I'll typically notice within a day or two. Also feel free to bump a PR or reach out via side-channels if I haven't responded to something within a week.


KAFKA-8729, pt 3: Add broker-side logic to handle the case when there are record_errors and error_message

All the changes are in ReplicaManager.appendToLocalLog and ReplicaManager.appendRecords. Also, replaced LogAppendInfo. unknownLogAppendInfoWithLogStartOffset with LogAppendInfo. unknownLogAppendInfoWithAdditionalInfo to include those 2 new fields
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Depending on #7150 to be merged

Ready for another round of reviews @guozhangwang . The failed tests passed on my machine so likely they're flaky

retest this please.

Ready for another round of reviews @guozhangwang @hachikuji

retest this please

All tests have run and succeeded. Please let me know what you think about the latest changes @guozhangwang @hachikuji

Just minor comment, otherwise LGTM! Thanks @tuvtran

Merged to trunk, also pushed to 2.4

Thanks @hachikuji @guozhangwang for the reviews!


Update images to use the new files directory after livebook 0.11.0

Describe the issue
With livebook 0.11.0+, the images folder no longer loads images. There is a provided script they had on the release notes for 0.11.0 which links to this gist https://gist.githubusercontent.com/jonatanklosko/20e28aa772a888a25a829337a4b805e1/raw/a0da10fe5b45b09197529a76a08c92b9d80d8047/convert_notebook_images.exs
Reproduction Steps (If Applicable)
Steps to reproduce the behavior:

Go to any livemd file that links to an image in images/*.png/jpg
Livebook warning will show about this issue, and images from directory will not load

Expected behavior
The images should be in the files directory and load when you open the livemd file

I was able to run this locally on the release file in the reading folder and it seems to work but may need more testing for an official update

a PR would be very welcome! My plate has been very full on other projects a curriculum maintenance is on the backburner right now so I likely won't have time to make a PR myself for awhile but would happily test and approve a fixed version.

Are these changes (#1059) reflected in the v2.0.0 release?
I downloaded the Source Code from the releases page (.tar.gz), and the codemod script did not seem to be applied.
When I opened the "Computer Hardware" LiveBook, I received an error from LiveBook indicating that images in the images/ directory are deprecated. I confirmed that images are in the reading/images/ directory and the exercises/images/ directory.
I was able to manually apply the codemod script, and the images appeared in the files/ directory and appear in the LiveBook .

no the 2.0 is the version i was using when i noticed the image issue, you could apply the same fix to the release, or build your own with the updated changes on main


chore: fix function name in comment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update zio-kafka to 2.2

About this PR
📦 Updates dev.zio:zio-kafka from 0.17.8 to 2.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-kafka" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-kafka" }
}]

labels: library-update, commit-count:1

Superseded by #1170.


add domain support

Whats the use case where you'd want to set the domain of the cookie?

I'm creating a cookie at a subdomain. Without setting domain=.exmple.com, it can be accessed only from sub.example.com, not from example.com and www.example.com.

can you add tests for this?

It works, I know, cause I uploaded it to a subdomain and accessed the cookie from the naked domain, but I'm not sure how to make it an automated test.


The form does not shrink/grow with the browser window

The form size seems to be fixed, when I increase the size of the browser windows the form or report stays the same size.
Long project names take-up multiple lines.

Interesting. Is it possible to add a screenshot?
The dashboard is designed to grow/shrink to a size that "looks right" but not to 100% to avoid everything looking too spaced out.
However, if you've got long project names maybe this doesn't quite work as intended, and the text wraps too early rather than increasing the grid width. One thing I did want to avoid is having project names that make the width so wide it meant you ended up with a horizontal scrollbar.
Since there are no width limits set on the columns, I'm not sure what's going on here. I guess I'll have to see if I can avoid wrapping the project name up to the screen width, but then allow wrapping... Sounds like a bit of a challenge! Bit of investigation needed I think.

Thanks, that's helpful.
I found the problem. I have a fix for the next release (v1.7), however I'm now struggling to get the table to stretch a bit when there is little content as it used to without having to fill the whole width (need to brush up on my CSS skills clearly!).
I'll see if I can resolve this before cutting the new version.

Okay I solved the other problem I was having - a bit of CSS grid rather than HTML tables was all I needed. Have a try of the new version and see if it fixes your problem.

looks good, thanks


Send to dead letter exchange after requeue logic reaches the number of attempts

Hi Antony, first of all thanks for creating this great library.
I have a scenario to cover and I wanted to confirm whether this should be handled outside the failed message handling pipeline or if it could become a feature request.
Problem
Messages are lost after handler throws an exception and the retries logic completes executing (either exhausts retries or requeue not configured in exchange).
Expectation
There should be a way to do something else with the message (like sending to a DLX) after retries so the problem can be diagnosed.
Details
I need the message handling pipeline to send failed messages back to the configured dead letter exchange when the message handler throws an exception and the re-queueing logic finishes with no successful handling. They currently get discarded.
In other words, when executing MessageHandlingService.HandleFailedMessageProcessing , I need the system to send the message to the DLX when either:

The exchange is configured not to requeue failed messages (options.RequeueFailedMessages = false), or
The exchange is configured to requeue them (options.RequeueFailedMessages = true) and reaches its retries limit (current attempt number == options.RequeueAttempts)

I want to add exception details to the message (perhaps via Headers) before sending the messages to the DLX, so people investigating the issue can read it.
I see two ways of implementing this:

Add a new option for the exchange to configure this behavior and update MessageHandlingService.HandleFailedMessageProcessing to send the message to the DLX when the message failed and either the exchange is not configured to retry or all retries were done.
Create a base non-cyclic message handler that will catch exceptions and then check for the headers similarly to how it's done in MessageHandlingService.HandleFailedMessageProcessing and finally send the message to a DLX if configured.

Both cases have drawbacks as either I'm messing with the execution pipeline code or I'm duplicating headers checking code outside the pipeline.
Questions

Does the library already supports something like this and I'm not seeing it?
If not, do you think that the scenario is common enough to try to come with an update to MessageHandlingService.HandleFailedMessageProcessing and a possible feature for the library?

Thanks in advance and please let me know if any clarification is required.

@sblasetti Please, check out the linked PR. I hope this is what you are looking for.
If everything is okay, I will try to release a newer beta version of the library (another 5.0.0 pre-release).
Best regards,
Antony

Awesome! I'll take a look.

Sebastian, I published a newer version of the library (5.0.0-beta-02). You can try it out now.
Be aware that those pre-release versions of 5.0.0 contain a lot of changes and current docs are out of date. I am trying to find free time to finish documentation, but I do not have an estimate time when it will be done.
So if you have questions about 5.0.0 you can contact me via email for some details. I hope I will manage to update docs soon.
Best regards,
Antony


[3.2] Fix race condition between foxx install and selfHeal

port of #5273

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/472/


FINERACT-821 Added and Enforced ModifierOrder Checkstyle

Refer: https://issues.apache.org/jira/browse/FINERACT-821
I used the custom spotless code from<EMAIL_ADDRESS>@vorburger I think you would love the idea to have the modifier order fixed by spotless as implemented in this, if not we can remove that feature :)

Please merge  #1080 before this, it would be easier to deal with merge conflicts(if any).


Add CryanCodes File

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request


[Question] When Sriov will be supported?

At present, due to the needs of the project, the network performance of the virtual machine needs to be improved.
I would like to know when the community will release a version that supports the sriov function. tks

solved


Uncaught TypeError: Cannot read property 'toLowerCase' of undefined

Hi, I am getting this error when I try to mount the plugin by calling Vue.use(VueAwesomeSwiper)
Any ideas about how to resolve this? Thanks!

I need your more detailed error message.

I am getting the same error....
I updated the Vue from 2.0.2 to 2.3.3. and then resolved it.


Users should be advised of the importance of keeping their seed safe and secure during the onboarding process

Some feedback from Slack:

When creating the seed it is explained that it is used for recovery. I think for the next five years or so we have to also show a big warning, that anyone who gets the seed will be able to steal your money. New users might not know this.
-- @michaelWuensch

Working on this

Fixed via #1029


helm template fails for redpanda chart

What happened?
In the charts/redpanda directory:
helm template .

produces
Error: template: redpanda/templates/tests/test-console.yaml:45:144: executing "redpanda/templates/tests/test-console.yaml" at <include "console.ContainerPort" (dict "a" (list (dict "Values" (dict "AsMap" .Values.console))))>: error calling include: template: no template "console.ContainerPort" associated with template "gotpl"

Use --debug flag to render out invalid YAML

What did you expect to happen?
I expected the defaults to produce a working set of kubernetes resources.
How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

git clone https://github.com/redpanda-data/helm-charts
cd helm-charts/charts/redpanda
helm template .
Error: template: redpanda/templates/tests/test-console.yaml:45:144: executing "redpanda/templates/tests/test-console.yaml" at <include "console.ContainerPort" (dict "a" (list (dict "Values" (dict "AsMap" .Values.console))))>: error calling include: template: no template "console.ContainerPort" associated with template "gotpl"

Use --debug flag to render out invalid YAML

Anything else we need to know?
No response
Which are the affected charts?


Code style idea: seperate usages of callBy* that send value > 0 and those with value == 0

As only ~3 or so instances of the CallBy methods use non zero value, there is a potential source of confusion around sending $ to the call.
Create two versions of each of the callBy* Methods that accept value and that expect value = 0. Most instances will use the value = 0 and the code should be more readable.

:link: zboto Link

@snissn I know what you mean here, but so far we have callByID, callByAddress and callNonSingletonByID. If we add another option with = 0 and != 0, it is going to be kind of messy. I think we can sacrifice this in order to avoid more and more functions that are slightly different. I could add a constant called VALUE_ZERO and send that as value for methods that don't send anything. That could be an option.

@snissn is what you're proposing to have some callWithValueByID method? I'm not sure it's gonna be more readable. This is internal API anyway, right? We don't expect developers to be using these methods directly.

yes - this helps with long term code maintainability to prevent future development from problems, but is not needed for this release

We will end up with a long combination of functions that do almost the same though.

i'm happy to close this one


Added more clarification on how to use z-index

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #34928

Thanks @thecodingaviator, LGTM!

@thecodingaviator z-index works other positioned elements (position: absolute|relative|fixed) and not just position: absolute.  Maybe instead of your proposed changes, the first sentence could be written something like:

When elements are positioned (i.e. position: absolute | relative| fixed) to overlap, the element coming later in the HTML markup will, by default, appear on the top of the other elements.

Or maybe put an asterisk on the word positioned and have a note say something like:

* Positioned means elements which have the value of absolute, relative, or fixed for the posiition property.

@RandellDawson How does this look?

@thecodingaviator I believe that looks fine, however I forgot about one (position: sticky).

@RandellDawson Changes made

Thank you @thecodingaviator for your contribution. Looking forward to more contributions from you! 🎉


Normalize case: Github -> GitHub

As a brand reference, G/H should both be capitalized.

Everything pretty straight forward and correct.
/lgtm

/assign @Bradamant3
as PR wrangler

@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content.
Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of).
Personally i would split this PR.

I found a hit for Github in content/es//community/_index.html, can you take a look?
grep -r "Github" content/es/                                                                                14:56:40
content/es//community/_index.html:                <a href="https://github.com/kubernetes/kubernetes"> Proyecto en Github </a>

/lgtm cancel

@electrocucaracha can you verify the checkout you were looking at? I believe that line was already changed here, and I don't see other references in that file.

@electrocucaracha can you verify the checkout you were looking at? I believe that line was already changed here, and I don't see other references in that file.

It's weird, I'm sure that I cloned and verified that on your branch... But it's true the line has the proper case(https://github.com/dpb587-pivotal/website/blob/patch-2/content/es/community/_index.html#L49)
/lgtm

@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content.
Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of).
Personally i would split this PR.

Hi @DanyC97 in general, I completely agree with you, e.g. having the case were multiple languages are changed. In this case only a single word is changed Github => GitHub. This is quite easy to check and therefore someone from the root-owners should be enough.

i understand @rlenferink and happy with letting this PR in however we all need to be careful and not abuse / ask for a waiver just because is a simple/ minor/ typo change. The rational is that new contributors will find this PRs and they will follow on the basis that if their PR was merged, mine should be accepted too.

@DanyC97 That's definitely true as well! However, the PR already exists now, so maybe next time indeed ;)
/lgtm

Thanks for the assist, @rlenferink.


replace // by torch.div

Hi Omar,
I had an error in heatmaps, related to // being deprecated. I found that it should be replaced with torch.div, with rounding_method='floor' to keep previous behavior.
Victor

Thank you Victor


Enable issues per organization etc

Change the email delivery to use templates
Simplify the url generation
Handle various errors around auth
Provide config option to enable issues only for particular organizations

Ok should be good to merge now @joetsoi

@joetsoi we could really do with you merging these improvements


Type error when using (None) as the default value in function signature

Bug Description
This part in pyo3 macros:
https://github.com/PyO3/pyo3/blob/8f4a26a66ecee4cfa473ada8cb27a57c4533d04f/pyo3-macros-backend/src/params.rs#L192-L201
This line looks like it also should be fixed:
https://github.com/PyO3/pyo3/blob/8f4a26a66ecee4cfa473ada8cb27a57c4533d04f/pyo3-macros-backend/src/pyfunction/signature.rs#L483
special-cases the ident None when it’s used as the default value for a parameter. Unfortunately, it doesn’t work for any other expression evaluating to None, e.g. (None).
Steps to Reproduce
Try to compile this code:
#[allow(unused_parens)] // sic: unused parens are the point
#[pyfunction]
#[pyo3(signature = (x = (None)))]
fn takes_x(x: Option<u8>) {
    println!("{x:?}");
 Did you use a virtualenv?
System repositories
Additional Info
Using arbitrary expressions evaluating None may seem to be a strange thing to want, but I’m autogenerating Python bindings and my defaults are something like None.convert_to_type_that_impls_IntoPy(). I’d rather not special-case None here.

Unfortunately, I’m not sure how to fix this without removing the special treatment of Option<_> completely. IMO Some-wrapping is kinda counterintuitive, especially considering this problem, but I get why it could be desired.

I have mixed feelings about the Some-wrapping. Given that this is the API boundary which is supposed to look like Python, I think it does make the user experience a little cuter.
I agree that this edge case is a bit horrible though, and in general I don't like implementations which rely on recognising tokens at text. For example, if you put Option under a different name the Some-wrapping doesn't work, because we can't detect type equivalency.
I suggest two ways forward:

You could rely on the fact we detect known name Option and use an alias in your generated code to circumvent the feature.
We could explore a way to reimplement this functionality using traits, which might be able to support some-wrapping automatically. (Or try blocks on nightly?)

I’m currently just forwarding this if to my generating code, like
if default_value_s == "None" {
    quote!(#name = None);
} else {
    quote!(#name = #default_value.convert())
}

Aliasing Option<_> is another possible workaround. I’m not too happy about either of them though.
Some trait-based solution would be interesting. Maybe some approach using deref specialization to use wrapping trait if available or fall back to identity function? I’ll try to write an example later today.

@davidhewitt This looks like a proper solution:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=8d3d90a25757bf9def5c2875e32102fe
I won’t have time in near future to actually implement this though.

Note that it could trivially be abstracted over the wrapper type:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f28eff9301f625b888d353e7faff271e

Thanks! Having been successfully nerd-sniped I managed to reduce the trait to a relatively simple form to solve the exact problem we needed. #3461

Thanks for the fix! It looks like it would solve the problem.
As a sidenote though, deref-based version doesn't rely on textually detecting Option<_>, doing a proper type comparison. As far as I can see, version in the PR still detects Option<_> textually. It's a much lesser concern than detecting None textually though.

Agreed, unfortunately we also detect text Option<_> for #2935 - which one day maybe we might kill, but until then there wasn't really any benefit in trying to remove that detection here.
The deref-based version you shared ran into other complexities - e.g. we needed to specify the type annotation in the macro, but we need to strip all lifetimes from the type annotation first because we're moving it from a function signature into the caller. Possibly a future refinement.


python311Packages.peaqevcore: 19.5.6 -> 19.5.10

Changelog: https://github.com/elden1337/peaqev-core/releases/tag/19.5.10
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 263523 run on x86_64-linux 1

4 packages built:

python310Packages.peaqevcore
python310Packages.peaqevcore.dist
python311Packages.peaqevcore
python311Packages.peaqevcore.dist


RouteResolver argument counts not equals

$router->get('/admin_crm/{w:controller}/{a:action}/{?:id}', function ($controller, $action, $id = null) {
Warning: array_combine(): Both parameters should have an equal number of elements in /var/www/..../web/vendor/szenis/routing/src/RouteResolver.php on line 44
so array_combine return false. You do not control ?:{...} optional arguments ?
this worked in 1.x previous version.
try
$count = min(count($route->getArguments()), count($arguments));
                $arguments = array_combine(array_slice($route->getArguments(), 0, $count), array_slice($arguments, 0, $count));

or compare optional arguments before please.

I will take a look into it

This issue is fixed in version 2.0.1


dz2 paperkey styling

@keybase/react-hackers
Will need another pass when we get icons / dz2 input / buttons / etc

:+1: % Type declaration (and optional sheepish comments)

fixing up the stuff now. we can ditch the :sheep: i think in the future, its all good stuff we should fix up


[SPARK-7979] Enforce structural type checker.

Merged build triggered.

Merged build started.

Test build #33844 has started for   PR 6536 at commit 633f9a1.

Test build #33844 has finished for   PR 6536 at commit 633f9a1.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #33845 has started for   PR 6536 at commit f833151.

Test build #33845 has finished for   PR 6536 at commit f833151.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


feat: NestedScrolling behavior on complicated layouts works

Added nested scrolling behavior to the PullToRefreshView which works on complicated layouts and copies behavior of a standard SwipeRefreshLayout (on scroll down when reaches top of the screen it starts opening layout animation).
Animation logic moved to a separate method to avoid repetitive code and improve readability.

Thanks! This fork really helped a lot!
I have the Phoenix refresh layout as the parent to a RecyclerView which was nested inside a CoordinatorLayout with an AppBarLayout that has scroll flags set on it. The normal Phoenix refresh layout will not allow the AppBarLayout to scroll back down, but the version you created in this fork successfully did.


install dependencies is constantly failing

Describe the bug

I'm constantly getting an issue with install dependencies and can't continue with building an app.
I've had this error occur in three separate builds I've attempted for an app.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-d81jzr3w
Validations

[X] Please make your project public or accessible by URL. This will allow anyone trying to help you to easily reproduce the issue and provide assistance.

Steps to reproduce
Scroll to first error. I've had this occur on this and three other attempts to build this app.
Expected behavior
I expected to at least be able to get to the point of seeing a preview of my project. This hasn't happened. Haven't got that far in this project or the other two attempts at this project.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 189058974,
  "usedJSHeapSize": 113456154,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = JCMawds
Chat ID = 4381ba61744b

Additional context
I've opened the project in StackBlitz and get this error:
npm ERR! 404  '<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! A complete log of this run can be found in: /home/.npm/_logs/2024-12-18T11_21_51_297Z-debug-0.log

I experience exactly the same issue

Hey @JCMawds, thanks for the report.
The @nativescript/sqlite package does not exist in public NPM registry: https://www.npmjs.com/package/@nativescript/sqlite
Did Bolt generate that package.json completely or is it imported from some existing project?


add hack to make HTTP PATCH work in ruby

Ruby 1.8.7 does not have Net::HTTP:PATCH,
so we need to define our own.
This should be compatible with newer versions of ruby
that DO define the class, because it is namespaced.

Awesome - thanks! I've merged this into the apidoc-generator project: https://github.com/gilt/apidoc-generator/commit/20d3fde4e6e131105e682c988d490e6d49321afb

I take it that is where patches should be submitted going forward?

Yes - but it's not clear until I get everything release (which I'm actively
working on this week)
On Thu, Feb 26, 2015 at 9:47 AM, Michael Reed<EMAIL_ADDRESS>wrote:

I take it that is where patches should be submitted going forward?
—
Reply to this email directly or view it on GitHub
https://github.com/gilt/apidoc/pull/284#issuecomment-76189897.


No debugging breakpoints have been set anywhere.

OS/Web Information

Web Browser: chrome
Local OS: window10
Remote OS: Ubuntu 16.04.1 LTS
Remote Architecture:
code-server --version:  2.1665-vsc1.39.2 ,3d5db8313a91f80dfc402450fd117b4e63f7711e ,x64

Steps to Reproduce
Expected

No debugging breakpoints have been set anywhere.

Notes

This issue can be reproduced in VS Code: Yes/No

Can you verify if this is reproducible in the latest version of code-server?


lookups doesn't accept null

when defining a query filter like:
query {
  users(filter: {username: {contains: null}}){
  }
}

the query fails with with: "Cannot use None as a query value" except for some filters like exact. And for exact this is a spec violation:
filters shall accept Unset or None to not filter
This bug causes errors when testing with schemathesis.
PR follows
System Information

Strawberry version (if applicable): 0.29

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Fixed by https://github.com/strawberry-graphql/strawberry-django/pull/478

good idea, thank you


As a user I would like to reorder data grid columns dynamically in the UI

A user should have the ability to reorder columns in the UI and save that column order preference (in user preference).

Blocked by #463

Re-ordering the grid is done, but not the save in user preferences.

Closing this issue - OBE


WIP: force one of flag

Hey, I am working with an API that I cannot add discriminators to, but downstream generators can't consume AnyOf properly in some cases.
Here are some similar threads:
https://github.com/asteasolutions/zod-to-openapi/issues/162
https://github.com/asteasolutions/zod-to-openapi/pull/163
This PR is a proposal for an interface to let a user opt into a potentially unsafe representation of their schema.
If the direction is approved, I can add testing / ensure correctness of my implementation -- I have not manually checked it yet for correctness, but want feedback on the interface & approach.

@fmmoret Thank you for opening a PR and sorry for taking long on this. I think I do agree that we can add such an option (as opposed to the previous implementation in #163).
A couple of pointers:

I think it makes sense to be consistent across the document => I would rather move the configuration at constructor level instead of through the .openapi method. I simply cannot envision why one would want to have two ZodUnion schemas with different signature within a single document.
We tend to add tests for all features/bugs that we handle. Please add some for this.

I'd also cc: @georgyangelov to share his opinion on the matter.

@fmmoret thank you for the contribution.
@AGalabov I'm a bit on the fence for constructor parameter vs .openapi. On one hand the .openapi approach gives more control - you can use oneOf for some of the types (I also can't think of a reason to want that but that doesn't mean there isn't any). On the other hand - that way would mean going through all of your types and adding that to every single one where a union may be declared. The latter is I believe more of an issue so I support the global switch in the geenrator object approach - that would mean users won't forget to add the flag when the schemas change.

@fmmoret are you still pursuing this? I found myself also looking for this solution. I agree with your approach and I'm happy to jump in on this if needed.


Clarify how to run client-side code in framework components

What kind of changes does this PR include?

New or updated content

Description

Clarifies how to run client-side code within framework components - they require a lifecycle method AND a client: directive (this has taken me days to figure out! lol glad to document it here)

Thanks for contributing to the docs! It's this line that you added that I think is super helpful for our readers:

Tell the framework component to hydrate client-side by using a client: directive.

That said, we like the way our existing section is structured. We don't use nested bullet points in Astro docs, and "entirely cient-side rendered" vs "partially client-side rendered" isn't quite how it works - in both cases, the component is completely client-side rendered; in the case of client: attributes other than client:only, it's also server-side rendered.
Would you be willing to add the note about using a client: directive to our existing paragraph setup?

Hey @caseywatts, are you still interested in this one? Happy to take it over.

Hey @Jutanium -- I think it's ok if you jump in with this one now! Let's get @caseywatts' contribution into the docs!  :partying_face:


IOU - User is able to select a date in the future when creating IOU request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com.
Go to 1:1 DM > + > Request money.
Enter amount > Next.
Click Show more > Date.
Select a date in the future and create the request.

Expected Result:
User should not be allowed to select a date in the future when creating IOU request.
Actual Result:
User is able to select a date in the future when creating IOU request.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/09219795-bc74-44ec-b71d-bb2c268503b2
View all open jobs on GitHub

@tgolen Offending line
maxDate={dateAdd(new Date(), {years: 1})}
Is this intentional?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Possible to select future date for IOU requests.
What is the root cause of that problem?
We set the max date to 1 year from now:
https://github.com/Expensify/App/blob/b884e29ea7163017035a4acacf51d3b05f032c5c/src/pages/iou/request/step/IOURequestStepDate.js#L74
What changes do you think we should make in order to solve the problem?
Should use maxDate={new Date()} instead if no future requests are allowed.
What alternative solutions did you explore? (Optional)

Might we need to update a testrails case here? or was this raised independently of a test case?

Agree that we should update testrail


fix(plugins): responsiveness improvements [KHCP-12616]

Summary

Resources

Creating a package docs

I didn't look at the code changes closely, but could you mark this as a breaking change since we are removing an existing prop pluginsPerRow?

I didn't look at the code changes closely, but could you mark this as a breaking change since we are removing an existing prop pluginsPerRow?

Yeah, it's still in draft mode, I gotta fix couple of things before it's gonna be ready for review but that's what I was gonna do tomorrow 🙂

Since this is still a draft, maybe you already know this (but I'll post it here anyway): we only invoke setToggleVisibility in the onMounted hook, so when we resize the screen, the visibility of the View less and View more buttons won't be updated:
https://github.com/user-attachments/assets/9589b488-716b-4fe8-b168-b05162715454

Since this is still a draft, maybe you already know this (but I'll post it here anyway): we only invoke setToggleVisibility in the onMounted hook, so when we resize the screen, the visibility of the View less and View more buttons won't be updated:
Kapture.2024-07-17.at.13.33.54.mp4

Fixed now, thanks for pointing out!


Fixed the id of the maven repository

This matches the id's created in the archetype for the custom policy.

Fixed in the following PR:
https://github.com/mulesoft/docs-api-manager/pull/181


Customizing table headers

It appears the combination of a customized header and the 'TextFilter' results in a failed prop type warning.  There doesn't seem to be any missing functionality, but just wanted to bring this to light.
bundle.js:9327 Warning: Failed prop type: Invalid prop `columnName` of type `object` supplied to `TextFilter`, expected `string`.
    in TextFilter (created by TableHeaderColumn)
    in TableHeaderColumn (created by Releases)
    in tr (created by TableHeader)
    in thead (created by TableHeader)

<TableHeaderColumn
    ref='theader_release_name'
    key='release_name'
    dataSort={true}
    dataField='release_name'
    width="250px"
    filter={{ type: 'TextFilter', placeholder: 'Release Name' }}
    dataFormat={this.reportLinkCellFormat}>
    <Tooltip label='reltooltip' placement="top" trigger={['hover']} overlay={releaseTooltip}>

Releases

    </Tooltip>
</TableHeaderColumn>

ok, I know the problem probably, because in TableHeaderColumn, I use the this.props.children as a column title and use it anywhere(Include pass children to TextFilter as a columnName prop).
I'll think about how to deal with this issue. Thanks your contribution :) 👍

Just ran into the same issue, not knowing what caused it. This helped us pinpoint it.
We were using a span to wrap around the column title for a tooltip. For now we removed that, but ti would be nice to have some flexibility around the header.

@batjko, ok, I understand.  I'll try to improve it. But there's always some restriction, so I can't promise that I can improve this issue. thanks

I have the same problem. I have a filtered column which has a div as header.
Thanks

Running into the same issue, anyone found a workaround?

I'll improve it after v4.0.0, thanks~

I think it was work from v3.1.7, please upgrade to v3.5.1 and you can custom the child of TableHeaderColumn and please remember to assign the headerText on TableHeaderColumn to assign the title for TableHeaderColumn.

Sorry, I'll fix on v4.0.0 and v4.0.0 will be release in this weekend officially.

Looks like https://github.com/AllenFang/react-bootstrap-table/pull/1534 has been merged, but a fix for this ticket wasn't included. Is it being moved into a post-v4 release?

@batjko thanks your remind :)
Actually, it was fixed before, if you have custom header(TableHeaderColumn), now it will work as expected, but please remember to add headerText on TableHeaderColumn !!!
Let me know if there's still any bug when you have customization header, thanks 👍

Hey, i came across this problem today. I have icons in the columns headers and if i set up the filter, it shows this message.  If i delete the filter, it doesn't show anymore.
Here's the code:
<TableHeaderColumn dataField='selected_option' dataSort dataAlign="center"
columnClassName={ this.columnClassNameFormat }
filter={{ type: 'TextFilter', delay: 500, placeholder:"Procure"}}
width='16%'> Ação

@Rclass93 As said by @AllenFang don't forget to add headerText on TableHeaderColumn.


[red-knot] rename {Class,Module,Function} => {Class,Module,Function}Literal

Summary

Rename Type::Class => Type::ClassLiteral
Rename Type::Function => Type::FunctionLiteral
Do not rename Type::Module
Remove *Literal suffixes in display::LiteralTypeKind variants, as per clippy suggestion

closes #13863
Test Plan
—

(Could possibly wait for @carljm's review as well on this before landing)


Exposing all hls.js events as api events leads to memory leak

Triggering player events whenever a hls.js event is fired increases private memory consumption steadily.
See: https://flowplayer.org/forum/#!/setup:buffering-preloader-always

With the propagation of hls.js to be triggered as flowplayer events private memory in chrome://memory-redirect/ can exceed 1GB.
At least temporarily I will remove these triggers.
It needs investigation though: With the dashjs plugin we do something quite similar without problems: https://github.com/flowplayer/flowplayer-mpegdash/blob/master/flowplayer.dashjs.js#L255 or https://github.com/flowplayer/flowplayer-mpegdash/blob/master/flowplayer.dashjs.js#L207-L257
@nnarhinen, @mangui - thoughts?

We still must expose hlsError because the earliest opportunity to set up a hls.js listener is ready, and by that time we are too late for a scenario like 'Simulate dummy stream' at http://demos.flowplayer.org/api/live-check.html

To document this:

For comparison with dashjs plugin:

hls.js demo player:

581,840k private memory

MP4 highest resolution of same movie: 277,144k in Flowplayer.

In our project we use flowplayer-hlsjs when streaming video. Recently we found memory leak bug, which is happened when stream is playing some amount of time. These leaks are happened only when Hls.Events.FRAG_PARSING_DATA event is exposed in listeners array of hlsjs configuration.
One of the workarounds, that eliminates these memory leaks, is to reset event data, before we triggering this event on flowplayer, but in this case we lost all data of FRAG_PARSING_DATA event.
Maybe you can suggest better sollution or pinpoint right direction for solving this problem?
P.S. It takes place in all web-browsers, except EDGE.

@criozen can you try listening to the event directly and see whether that alleviates the problem, e.g.:
flowplayer(containter, {
  // player configuration goes here
  // do not register the hls.js event
}).on("ready", function (e, api) {
  if (api.engine.hlsjs) {
    api.engine.hlsjs.on(Hls.Events.FRAG_PARSING_DATA, function (e, data) {
      console.info(data);
    });
  }
});

@blacktrash Listening directly from hls.js eliminate this issue in Chrome and Internet Explorer, but not in Firefox.

@criozen - without an actual sample page I can't know what you're actually doing in the event handler.
Things to try:

does it happen as well with minimal functionality as above?
does it happen in a pure hls.js setup as well?
what are the actual symptoms of the memory leak bug?

Yes, it happen with minimal functionality as above as well.  Main symptom is increasing of memory heap e.g.  on this screenshot i compare memory snapshot that was made in the beginning of stream (heap size 35 mb) and that was made after 15 minutes of stream (heap size 235 mb)

After 60-70 minutes of streaming heap size reaches 1 GB and page with the stream will crash.

And this does not happen in a pure hls.js setup w/o Flowplayer?

Turns out that problem was not only with FRAG_PARSING_DATA event, but also with FRAG_LOADED event. After i start to listen both of this events directly from hls.js, memory leaks in all browsers are gone.

@criozen - I have lost track now: when you listen to both events, the issue is gone, but if you listen to FRAG_PARSING_DATA alone it's still there?
Aside: I did run an almost 2 hour stream with hlsFragParsingData registered and got less than half of what's in your table, and certainly no crash.
It would really be helpful if you came up with a sample.

Sorry about this, but I think they've removed the memory tab from chrome.  Can you comment as to whether or not this issue may be responsible for memory behavior like this?
https://ibb.co/eqFiKk
Basically i see an acceptable Javascript heap but overall memory consumption balloons out of control.  Specifically, i've got two players rendering the same live video on a page.

@josh-sachs - chrome://system/
There is obviously a somewhat higher memory usage when running hls.js via the plugin, the core player also eats some CPU.
You can/should compare with running 2 hls.js plain video tag instances.
In the end both hls.js and dash.js are quite memory intensive, plus hls.js also has to remux constantly.
This issue is about incrementing local memory though.
Also take a look at https://github.com/video-dev/hls.js/issues/1262 - note as well that having debugging tabs open increases memory consumption.


[Typo] A small typo in tools/train.py

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


API generation regression in properties

See https://github.com/Qiskit/documentation/pull/222#discussion_r1367492777.

Possibly related problem in /api/qiskit/tools#monitoring (see "line_discipline").

@frankharkins I think the issue with line_discipline is not related to this regression. It seems like the HTML files from the CI artifact have the same problem :thinking:


remove execsync and add sync-exec to work with node 0.12

hey @gunta.  I like using this package and I've upgraded to node 0.12.  It seems you can use sync-exec instead of execSync to be compatible with +0.12 as well as with earlier versions of node.  This change passed the working tests in the example repo.
Let me know if there is something else you have a question on.  Otherwise I would love to get this up on npm so that I can use it straight from there.
Thanks

Thank you!

  Will you be publishing to npm shortly?  Just want to know when I should download.
Thanks!


Additional support for windows

Purpose
Address several places that were not platform independent.
What the code is doing

Finished splitting up commands between local/ssh and removed the execute_command in the local case, as it relied on /bin/bash
Add the DataAccess.join attribute according to the subclass, removing hard coded posixpath.join in calling code
Added get_base_dir and match_scenario_files to encapsulate the logic of creating paths, along with tests for these
Fix potential issue in InputData and OutputData which were relying on the values from server_setup.py, which had posixpath implicitly hard coded (e.g. INPUT_DIR = data/input). We delay the path join by using a tuple instead

Testing

Ran a scenario in docker (using LocalDataAccess)
Created and prepared a scenario on the server and deleted it (using SSHDataAccess)
Added a few unit tests

Time estimate
20 mins

Rebased and fixed the test that was still calling data_access._execute_command("whoami")


Clarify benefits of using Moya over vanilla Alamofire

It's not super clear why one would want to use Moya instead of using Alamofire itself. We should update the README.

Rolling into #123.


Update profile_name in ibm_catalog.json

Description
IBM Cloud for Financial Services has been renamed to IBM Cloud Framework for Financial Services so need to update profile name in the ibm_catalog.json
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

/run pipeline

:tada: This PR is included in version 4.11.1 :tada:
The release is available on:

GitHub release
v4.11.1

Your semantic-release bot :package::rocket:


please explain LED behavior and firmware usage

Hello Reverieline,
first of all thank you for the enhanced firmware. Can you please explain the LED behavior?
For the v3 coordinator  i have to use the file MODKAMRU_V3_USB.hex, right?
Many thanks
BoBeRzE

Answer found
Thank you


refactor(core): organize API structure

Created folders for api, classes, interfaces and types to unclutter the files. This was needed to keep the project clean while expanding and adding more stuff.

Task linked: CU-86788531c Organize API structure


FIP-11 Enhance bundled transaction usability

Tracks comments, development and deployment of FIP-11: https://github.com/fioprotocol/fips/blob/master/fip-0011.md

Discussion moved to: https://fioprotocol.atlassian.net/browse/WP-113


Score for each location?

Could it be possible to have a score for each location found?
Indeed sometimes it could be good to know why some locations are in the results for example :
`

import geograpy
places = geograpy.get_geoPlace_context(text="This sentence mention UK as country and London as city.")
places.countries
['United Kingdom', 'United States', 'Canada']
places.cities
['London']
places = geograpy.get_geoPlace_context(text="Jin Yin-tan Hospital, Wuhan, China.")
places.countries
['China', 'Mexico', 'United States']
places.cities
['China']
`

Something like the following score could be interesting :
[('United Kingdom',0.99), ('United States',0.56), ('Canada',0.45)]
A score of confidence could help to avoid those results.

How would you like to calculate the score? Currently there are a few possible strategies:

use the population as an indicator e.g. Vienna Austria has a higher population as Vienna Illinois
use the combination of fields as an indicator Wuhan China should limit the location as a grid search just in that area

Please note that the disambiguation is currently only possible with the Locator API.

I think a combination of fields should be the best approach.

see also http://wiki.bitplan.com/index.php/Geograpy#Difference_in_Name.2FLabel

#52 now addresses this - the default is to order by population. For our own use case we'll use a more sophisticated version and see what the likelyhood of a location is in our context given how often it is already in our corpus.


{Compute} Bump up azure-mgmt-compute SDK to 33.0.0

Related command

Description

Bump up azure-mgmt-compute SDK to 33.0.0
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute


Set Route 53 to S3 bucket

In AWS the s3 bucket hosting the site needs to be set to the domain zone in Route 53.

add zone record to aww. http://www.githubusersbylocation.com.s3-website-us-east-1.amazonaws.com/

http://www.githubusersbylocation.com/


Generalize LeaseArbiterDecorator for Execution & Scheduling

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
I create the following new classes:

InstrumentedLeaseArbiterDecorator - a decorator around MultiActiveLeaseArbiter with metrics for lease attempts (ReminderSettingDagProcLeaseArbiter & ReminderSettingFlowTriggerLeaseArbiter will extend the common functionality)
ReminderSettingDagProcArbiter  - child class of InstrumentedLeaseArbiterDecorator used for multi-active execution to set a reminder for a dagTask an instance failed to obtain a lease on.
(existing class renamed) ReminderSettingFlowTriggerLeaseArbiter will contain similar logic for Multi-active scheduling.
DagActionReminderScheduler - provides methods for adding reminders to another QuartzScheduler.
[needs to be done] TODO's around initializing the two classes (and creating factory methods) as well as updating the schemas of MySqlMultiActiveLeaseArbiter & MySqlDagActionStore
I debated the following implementation details
Re-using the same QuartzScheduler and SchedulerService from GobblinServiceJobScheduler?
Because I want to avoid the confusion of having multiple job types in a single scheduler & in-memory QuartzSchedulers are pretty lightweight, I opted to create a separate scheduler to handle reminder events for multi-active execution lease arbitration.
Use a different lease arbitration table and instance btwn the scheduler and execution arbitration phases.
I create a separate lease arbiter instance and table for execution versus scheduler so we can more easily isolate & monitor issues between scheduler and execution lease arbitration in case the cases need to be handled differently. It also allows us to use the existing code with no changes to vary the epsilon/linger values for scheduling and execution (the latter should be much greater).
Note that we have to do the lease arbitration logic twice because we had separated the rollout of multi-active scheduler from executor. A future optimization would be to do de-duplication and consolidation before adding actions to the dagActionStore then arbitrate once to establish ownership of execution, but this will require significant investment to optimize working functionality so we leave this for the future.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

checks on my fork: https://github.com/umustafi/gobblin/pull/22

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.33%. Comparing base (2bdf7eb) to head (db55dd8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3890      +/-   ##
============================================
- Coverage     46.67%   41.33%   -5.35%
+ Complexity    11196     2193    -9003
============================================
  Files          2232      475    -1757
  Lines         88056    20147   -67909
  Branches       9657     2333    -7324
============================================
- Hits          41102     8328   -32774
+ Misses        43250    10935   -32315
+ Partials       3704      884    -2820

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unused component imported

Hey @alan2207 ! Thanks for creating this repository. It's a great starting point for me to build my React App.
I'm currently facing a problem where my unused code is executed in the test. So I'll give an example.
features/order/index.ts
export { useCreateOrderMutation } from './api/useCreateOrderMutation';
export { useGetOrderQuery } from './api/useGetOrderQuery';

pages/MyPage.tsx
import { useGetOrderQuery } from '@/features/order';

...

pages/MyPage.test.tsx
I'm testing MyPage component and mock useGetOrderQuery using jest.spyOn()

But somehow, the code inside useCreateOrderMutation is executed even though I'm not importing it in MyPage.
Is there any missing setup from my side? I didn't clone this repo but I built my repo from scratch, so maybe I might missed something from the webpack or the other setup.
Thanks!

Hey @kevindavee ,
Can you provide the repo with the issue?

Hey @alan2207 , I just invited you to the repo because it's a private repo. I gave you read access so you can read the code. Here's the repo https://github.com/kevindavee/icx-app

@kevindavee  Can you send me the link to the test file?

Try to comment on this line https://github.com/kevindavee/icx-app/blob/bf843adfa016248221163831f1380c2ee961e610/src/tests/jestSetup.ts#L60-L64
And run yarn test src/hooks/useHydration.test.tsx
You'll see a warning like this.

Looks like the tooling won't tree-shake unused imports from the feature, so you will have to specify the exact file. If this happens, avoid using index files from features as the main entry point and just import from files individually.
Updating the imports to this made the test succeed without issues:

I'm having this issue as well when importing a component from a feature's index.ts file and it importing everything in that index.ts file (even unused one). I guess the only solution right now would be to import directly?

Hey @prodbygoss @kevindavee I've just published the package https://github.com/pafry7/babel-plugin-bulletproof-features-import. It seems to solve the issue in our two projects. You can give it a try.

Hey @prodbygoss @kevindavee I've just published the package https://github.com/pafry7/babel-plugin-bulletproof-features-import. It seems to solve the issue in our two projects. You can give it a try.

Ooh, this look interesting. So would this work intelligently with different sub directories too? In your example it shows it changing the imports to /views sub directory.
If I have a bunch of items in sub directories of the features folder (like /types, /screens, /components, /hooks, etc) that get exported from the barrel file, would it be able to import directly to those paths

Hey @prodbygoss @kevindavee I've just published the package https://github.com/pafry7/babel-plugin-bulletproof-features-import. It seems to solve the issue in our two projects. You can give it a try.

Ooh, this look interesting. So would this work intelligently with different sub directories too? In your example it shows it changing the imports to /views sub directory.
If I have a bunch of items in sub directories of the features folder (like /types, /screens, /components, /hooks, etc) that get exported from the barrel file, would it be able to import directly to those paths

It should work with subfolders as long as you use relative imports in your index file.


Large refactor / HISAT2 compatibility / working index building

Option to align using HISAT2 with the --align hisat2 command line parameter.
Lots of stuff moved from the pipeline file into the config file
Moved scripts out into their own files in bin
Switched BED conversion from BEDOpts to gtf2bed script, which actually works with RSeQC
Some of @Galithil's Docker stuff in with this PR

Better R package installations
Fixed broken Fasta / GTF download links for GRCh37

So what't the test situation with this @ewels?

I've run single-end and paired-end tests with HISAT2 on subsampled data, and it's worked fine (with the exception of preseq falling over as it was subsampled). I ran tests with star a little while ago and that was fine also, though I haven't repeated that recently.
Basically, I think it should be fine. But it'd be good to test it on a proper project please :) HISAT2 and STAR now. Can also run -with-timeline to get profiles at the same time.

Running a test on some actual data, will come back with feedback after that.

Test finished fine, merging!


How to pass arguments to the browser executable?

How to pass arguments to the browser executable?
Use case:

https://github.com/microsoft/playwright/issues/1062
https://github.com/arjun27/playwright-github-actions/blob/2770e149bdd75408203aa2b6590e11dafec6fdc3/test-project/index.js#L19

For GitHub Actions to work with Playwright, we need to pass --no-sandbox to chromium
I think the arguments should be passed somewhere here: https://github.com/mmarkelov/jest-playwright/blob/v0.0.10/src/PlaywrightEnvironment.js#L48

@tkrotoff you can pass it with jest-playwright.config.js:
module.exports = {
	launchBrowserApp: {
		args: ['--no-sandbox']
	}
}

Note that WebKit will crash when launched with no-sandbox, which is a valid arg for Chromium only.
For now, I recommend using process.env.BROWSER === ‘chromium’ ? ['--no-sandbox'] : []
Follow this as we look for a better fix: https://github.com/microsoft/playwright/issues/1063


Use Anchors for Code

This pull request switches the code include statements to using anchors instead of line numbers. There are a couple of other minor tweaks to the tutorial to try and clarify some bits I thought were confusing. Once merged, this pull implements the anchor part of #46, no attempt has been made to use diffs yet.

I've edited most of the tutorials to use the anchors. I'm going to leave out 3.4 because I think it needs some rewrites to take into account the info I brought up in #74.

hey @desttinghim, this is awesome, thanks so much! do you mind splitting this into a couple of separate PRs please? maybe we can start with the first two chapters, otherwise this is a bit too big to review properly and there's a good chance some code will go missing from the book, had that before and it's a pain.

That is okay by me. Give me a bit to get the PR's up

no rush at all 😄

@desttinghim I just merged a PR which moves some of the files around to support translations, it might be a pain to merge directly so might be worth just starting a new branch and copying your version of the files to the new place. sorry for the hassle!

That was my plan in the first place, so no worries :)

I'll close this PR since we're going to phase out it's changes over multiple.


clippy: Fix semicolon_if_nothing_returned lints.

This doesn't enable the lint as I have a subsequent follow-up PR coming for that.

This doesn't enable the lint as I have a subsequent follow-up PR coming for that.

Why not within this PR?

Why not within this PR?

Because it is a new approach and deserves discussion on its own!


Review landing page descriptions

In the " Learn about the source" box, it says, "We also included any known data quality issues and advice on how to access the data."
I think we are not providing advice on how to access the data.
In " Get direct access to the source data": "You can also customize the data fields you need for a more manageable dataset."
That is not true at the moment.

Closing in favor of #269


cant import ludwig

Describe the bug
I have installed ludwig via pip but when I try to import it in python it gives error and kills python
(base) C:\>python
Python 3.7.1 (default, Dec 10 2018, 22:54:23) [MSC v.1915 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from ludwig import LudwigModel
ModuleNotFoundError: No module named 'numpy.core._multiarray_umath'
ImportError: numpy.core.multiarray failed to import

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 980, in _find_and_load
SystemError: <class '_frozen_importlib._ModuleLockManager'> returned a result with an error set
ImportError: numpy.core._multiarray_umath failed to import
ImportError: numpy.core.umath failed to import
2019-04-01 10:28:04.393999: F tensorflow/python/lib/core/bfloat16.cc:675] Check failed: PyBfloat16_Type.tp_base != nullptr

Screenshots
I have added a screen shot as well.
Environment (please complete the following information):

OS: [windows10]

'3.7.1 (default, Dec 10 2018, 22:54:23) [MSC v.1915 64 bit (AMD64)]'

Ludwig version

Additional context
I did pip install ludwig
and got this issue and later even did
pip to master zip file
![2019-04-01 10 28 21]
(https://user-images.githubusercontent.com/18720437/55296740-8ae3e080-5469-11e9-876d-84f050319afb.png)

Please use the latest code from master, it has updated dependencies that solve the issue.

hi , "Please use the latest code from master" can you provide more details please thanks .

When this qquestion was asked the latest version of the code on master had moved to a newer version of numpy that did not have the problem, so i was suggesting to use that instead of the package on Pypi, but thie issue with numpy versions has vbeen solved long ago.


Popup dialogs are created with wrong width

When a dialog (e.g., the built-in PIN dialog in example_cpp_smart_card_client_app) is opened, it gets a wrong width instead of the one specified in the code.

I think it regressed in #518: this line shouldn't have been deleted:
Object.assign(createWindowOptions, opt_createWindowOptionsOverrides);

And there's another issue introduced in #404, when the format of the "width"/"height" parameters has changed, but the example PIN dialog callsites weren't updated accordingly.


[io] make wheel.py runnable

This PR is not intented for merge, but to rather show the changes I had to make in order to make wheel.py run on my setup. I use python3, this may be the most noticible thing.
The list issue could be fixed when #104 is taken care of.
For the body_class, i think the best is to change the number of arguments rather than define a dummy one. I don't see how to fix that one properly since in C++ we have a default argument and that swig wrap both constructors.

I'll compile for Python3 and test the examples shortly.

With 077e2ef349 these problems are now fixed at the bindings level.  Any Siconos function accepting float or int should now properly convert numpy values, and functions accepting pointers to vectors or matrices should be able to accept None values which convert to null pointers.
My argument for the latter is that some functions may want to support optional values by means of accepting null, and previously this was rejected by the swig bindings.  Also, even if this could lead to segfaults, otherwise it would lead to cryptic "wrong arguments" error messages from the swig bindings.  I find it's actually easier to debug null-pointer segfaults in real Siconos code using gdb than understanding why swig is refusing to even call the function.
Functions with reference arguments (SiconosVector&) will give an error message, e.g. 'expected vector'.


this call overwrite err

https://github.com/StabbyCutyou/buffstreams/blob/20679e9ca31ad9ff33e5a1c3c4b90ec65e9a0b03/tcplistener.go#L79

Good catch, I wrote this before I was in the practice of heavily linting my go code


merge from konsum-frontend-svelte,template-arlac77-github,template-svelte-app

package.json

chore(deps): add ^3.0.5 remove ^3.0.4 (devDependencies.vite)

.github/workflows/browser_ci.yml

chore: add ubuntu-latest (jobs.test.runs-on)
chore(deps): remove 18.7.0 (jobs.test.strategy.matrix.node)

README.md

docs(README): update from template

:tada: This PR is included in version 1.32.2 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.32.2
GitHub release

Your semantic-release bot :package::rocket:


Remove custom prompts from Google, Claude 3, OpenAI and Mistral models

Multiple users have ran into issues with running various scenarios (verifiability, unitxt) due to the custom prompts. We should revert this for the v0.5.0 release until we figure out a better way to do custom prompts without breaking lots of scenarios.
The Claude 1 and 2 prompts can stay because they include the special Anthropic strings that are required for passing API validation.

@teetone are you using the custom Gemini prompt for VLM stuff?

We do need the custom prompts for Claude 3, but I want to redo this in a more principled manner. I'm doing this temporarily to unblock multiple external users first.


Pass MediaStream or canvas instead of video element, Holistic-JS

The example code for MediaPipe Holistic (JavaScript) fails when trying to pass a MediaStream (or canvas HTML element) instead of a video element.
Do you have any fix or plans to support this in the immediate future?
Thanks!

Hi @pwhite77, Could you please share the  above error and update code changes.

Thanks, @sgowroji ! The error I'm getting:
Uncaught (in promise) TypeError: Failed to execute 'texImage2D' on 'WebGL2RenderingContext': Overload resolution failed.
    at la.h (pose.js:43)
    at S (pose.js:13)
    at pa.next (pose.js:14)
    at k (pose.js:23)

If you need, here's the code I'm using:
const pose = new Pose({locateFile: (file) => {
        return `https://cdn.jsdelivr.net/npm/@mediapipe/pose/${file}`;
    }});
pose.onResults(onResults);

function startPoseEstimation(video) {
    async function poseDetectionFrame() {
        await pose.send({image: video});
        requestAnimationFrame(poseDetectionFrame);
    }
    poseDetectionFrame();
}

To start pose detection, I use:
startPoseEstimation(document.getElementById("myVideo"));

And this works, but changing this to:
startPoseEstimation(myMediaStream);

causes the error.

@pwhite77 You can, in fact, send an HTML Image element.  We support HTMLVideoElement, HTMLImageElement, HTMLCanvasElement, and ImageBitmap.
We are considering some sort of MediaStream in the future, but I don't have a date.  On Chrome, you can do this today by instantiating ImageCapture on top of your MediaStream track, and then using ImageCapture.grabFrame() which will return an ImageBitmap.


Smurf S04 Slot 2 high noise on Bands 0-3, 'Unlocked' Jesd status

Hi all, this is from troubleshooting that Yuhan W did on the Srv So4 slot 2 Bay 0 AMC card that previously had power issues at the beginning of SATP3's Run 13.
AMC 0 only has bad band 0 and 1, maybe also band 2
after hammering S.check_jesd(0) either returns:
[ 2024-08-27 03:19:46 ]  JESD Tx Okay
[ 2024-08-27 03:19:46 ]  JESD Rx Okay
[ 2024-08-27 03:19:47 ]  JESD health check finished after 1 seconds. The final status was Unlocked.
(True, True, 'Unlocked')

or
[ 2024-08-27 02:03:45 ]  JESD Tx DOWN
[ 2024-08-27 02:03:45 ]  JESD Rx Okay
[ 2024-08-27 02:03:46 ]  JESD health check finished after 1 seconds. The final status was Unlocked.
(False, True, 'Unlocked')

power cycle the crate doesn’t fix this
when trying S.setup(force_configure=True)
it errored out with:

ChannelAccessGetFailure: Get failed; status code: 192

CA.Client.Exception...............................................
    Warning: "Virtual circuit disconnect"
    Context: "localhost:5064"
    Source File: ../cac.cpp line 1223
    Current Time: Tue Aug 27 2024 03:24:28.384456697
..................................................................
4. when hammering, saw this
[ 2024-08-27 03:01:50 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:00 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:10 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:20 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:30 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:40 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:02:50 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:00 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:10 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:20 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:30 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:40 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:03:50 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:04:00 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:04:10 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:04:20 ]  caget smurf_server_s2:AMCc:SmurfApplication:ConfiguringInProgress
[ 2024-08-27 03:04:26 ]  False
[ 2024-08-27 03:04:26 ]  caget smurf_server_s2:AMCc:SmurfApplication:SystemConfigured
[ 2024-08-27 03:04:26 ]  True
[ 2024-08-27 03:04:26 ]  System configuration finished after 196 seconds. The final state was True.
[ 2024-08-27 03:04:26 ]  caget smurf_server_s2:AMCc:SmurfApplication:SmurfVersion
[ 2024-08-27 03:04:26 ]  7.4.0+0.g3ed5cb3c.dirty

See plot attached for full band response.

Hi Sam, thanks for the info. If this problem is still occurring do you think you can run S.save_state to dump the rogue state so we could get maybe @swh76 to quickly check it out?
The JESD being unlocked is concerning to me, I'm not sure if I've seen that before, though its not something I regularly check often
I don't believe that the CAClient exception during S.setup means anything, it is just timing out because the server is busy loading the configuration. I believe the fact that the logs end with: System configuration finished after 196 seconds. The final state was True. means it was successful.
We've previously seen issues on SATp1 where individual bands (not entire AMCs) were saturated  while others looked normal. We never really figured out what was wrong, but learned that it was sometimes fixed by hammering. Just to confirm, you did hammer but this didn't resolve the issue? This is a good one to track.

Chatted w/ @samdayweiss on slack ; I think this AMC needs to come back to SLAC for a look.  The issue has been confirmed to follow the AMC (ie, another AMC installed in its place works as expected).  I'm not sure what the issue could be, but I think odds point to it being a hardware issue of some kind.  I believe hammering also did not resolve this issue.
@jlashner re: individual bands being saturated that resolves on hammer, is there an open discussion for that problem?  If don't have already, it would be good to get a state dump for a system in that state.
Re: JESD reporting unlocked, depending on the details this may not be that worrisome; the Unlocked status is probably a bad status descriptor usually not what it sounds like ; ie that status will get reported if a system instantaneously loses lock and successfully recovers (which as far as I know, does not result in any negative impact).  It is most useful when run right after setup(), otherwise interpretation depends on the exact state of the many things (some innocuous) that the rogue CheckJesd routine looks at.


typo on tab Fortran (was Cython)

A typo in the documentation.
The tab was Cython | Cython, but the latter should have been fortran.

Thanks for the help on the docs! They are quite new and not fully polished yet, this has been helpful!


docs: Update to use kubectl kustomize in instructions

Since Kubernetes v1.14, kustomize became a subcommand in kubectl so we can just use kubectl instead.

/cc @Jeffwan @zw0610


Need support for android project under subdirectory

dryrun assumes that the android project is at the root of the git repository. If the android project is under subdirectory, we get following error:
 [~] $ dryrun https://github.com/hnrainll/learn-android/tree/master/RadioButtoDemo
Cloning into '/tmp/dryrun/master/RadioButtoDemo'...
fatal: repository 'https://github.com/hnrainll/learn-android/tree/master/RadioButtoDemo.git/' not found
https://github.com/hnrainll/learn-android/tree/master/RadioButtoDemo is not a valid android project

Quoting from the README.md:
From a custom repository folder:
dryrun REPOSITORY_URL -p CUSTOM/PATH/TO/GRADLE_APPLICATION

just tried it, works:
dryrun https://github.com/hnrainll/learn-android -p RadioButtoDemo

That's good to know. I am still getting this error:
 [~] $ dryrun https://github.com/hnrainll/learn-android -p RadioButtoDemo
Cloning into '/tmp/dryrun/hnrainll/learn-android'...
remote: Counting objects: 1546, done.
remote: Total 1546 (delta 0), reused 0 (delta 0), pack-reused 1546
Receiving objects: 100% (1546/1546), 5.88 MiB | 1.27 MiB/s, done.
Resolving deltas: 100% (569/569), done.
Checking connectivity... done.
Using custom app folder: RadioButtoDemo
gradlew: 158: gradlew: Syntax error: "(" unexpected
Failed
Installing com.leochin.radiobuttodemo...
executing: adb shell am start -n "com.leochin.radiobuttodemo/com.leochin.radiobuttodemo.MainActivity" -a android.intent.action.MAIN -c android.intent.category.LAUNCHER

Starting: Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] cmp=com.leochin.radiobuttodemo/.MainActivity }
Error type 3
Error: Activity class {com.leochin.radiobuttodemo/com.leochin.radiobuttodemo.MainActivity} does not exist.

> If you want to remove the app you just installed, execute:
adb uninstall com.leochin.radiobuttodemo

Please ignore. I see this would be issue #3 already being tracked. Thanks.

Which version are running BTW?


Speed up build_image.php

For building a sprite sheet, a single call to montage is far faster than repeated calls to composite. This gives the same result with a ~50x speedup on my machine.

This is a great approach. I meant to do this back when I started, but since you can't pass them on the commandline and have to use popen() i got lazy.
However, the ordering of output here is not the same as the original, so I can't merge it yet:

(build time per sheet is now ~30s on my build box, instead of multiple minutes)

That's very strange, I get the correct order on mine. What version of imagemagick are you using? Mine is ImageMagick 6.8.9-9 Q16 x86_64 2016-06-01.

It's older:
# montage -version
Version: ImageMagick 6.5.4-7 2014-02-10 Q16 OpenMP http://www.imagemagick.org
Copyright: Copyright (C) 1999-2009 ImageMagick Studio LLC

After a yum upgrade I got:
# montage -version
Version: ImageMagick 6.7.2-7 2016-06-16 Q16 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2011 ImageMagick Studio LLC
Features: OpenMP

That built the sheets correctly. I'll add a note to make sure the ImageMagick version is recent 👍

note added in 1c5928f


ubuntu base image outdated

the base image
ubuntu 22.04 base image needed
gcr.io/buildpacks/builder:v1  is outdated

Thanks for the feedback. Our team is currently working on introducing Ubuntu 22.04 as the new base image for gcr.io/buildpacks/builder
When the work is complete, we expect the new tag to be gcr.io/buildpacks/builder:latest

@unnimona  we jsut released our first version of the Ubuntu-22 builder, you can give it a try using the google-22 tag on the builder. For example, if you're using pack you can do this:
pack build --builder=gcr.io/buildpacks/builder:google-22 <image name>

Made a small announcement outlining how to use the new Ubuntu-22 base image. PTAL @unnimona and provide feedback if you have any comments