feat(hyper): switch to std::io, std::net, and std::path.

All instances of old_io and old_path were switched to use the new
shiny std::io, std::net, and std::path modules. This means that
Request and Response implement Read and Write now.
Because of the changes to TcpListener, this also takes the opportunity
to correct the method usage of Server. As with other
languages/frameworks, the server is first created with a handler, and
then a host/port is passed to a listen method. This reverses what
Server used to do.
Closes #347
BREAKING CHANGE: Check the docs. Everything was touched.

Needs a rebase already.

@reem rebased.
Interesting to note: speed improvements with the client_mock_tcp bench is over 500%.
BEFORE
test bench_mock_hyper ... bench:    280059 ns/iter (+/- 62609)

AFTER
test bench_mock_hyper ... bench:     50152 ns/iter (+/- 5771)

If there's no real problems, I'd like to merge so we can unbreak people on crates.io...

Hey, I am not sure if this is a blocker, but with the current build the example client does not build for me. Here's the exception:
src/main.rs:19:20: 19:36 error: type `hyper::client::response::Response` does not implement any method in scope named `read_to_string`
src/main.rs:19     let body = res.read_to_string().unwrap();
                                  ^~~~~~~~~~~~~~~~
src/main.rs:19:36: 19:36 help: methods from traits can only be called if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
src/main.rs:19:36: 19:36 help: candidate #1: use `std::io::Read`
error: aborting due to previous error

@akoskaaa read_to_string() was changed in the new io mdoule. Looks like the example needs to be updated. Here is how I modified my code to make it compile:
    use std::io::Read;
    ...
    let mut content: String = "".to_string();
    try!(response.read_to_string(&mut content));

Alright, I updated the REAME to work, and renamed that odd function. Once travis hits green, I'll merge. (sorry those using git rev's, I probably broke you because of my force-push)


The Java agent jar gets copied from the bundled location to ~/.appmap/lib/java

If the plugin can't download the agent jar, it should copy the version that's bundled into ~/.appmap/lib/java (and create the appmap.jar symlink).
This will allow the user easy access to the jar if they want to run a JVM manually.

:tada: This issue has been resolved in version 0.68.0 :tada:
The release is available on:

v0.68.0
GitHub release

Your semantic-release bot :package::rocket:


Fix to call componentDidUpdate on setState of React v16

@ljharb @lelandrichardson This is to fix #1247 🙏
Currently, componentDidUpdate is not called when calling setState with React v16.

@koba04 this needs to be rebased, so as to remove all merge commits; i have some commits i need to add to master first, so i'll rebase this branch for you after that, and then merge it.

@ljharb Rebased!
But I couldn't run unit tests on my local because lerna bootstap never finish at the following point... Is it just me?
lerna info version 2.5.1
lerna info versioning independent
lerna info Bootstrapping 9 packages
lerna info lifecycle preinstall
lerna info Installing external dependencies
⸨         ░░░░░░░░░⸩ ⠙ install dependencies: verb actions 9 actions, concurrency 4

I'm using macOS 10.12.6 and Node v8.9.0 and npm v5.5.1.

@koba04 hm, that should definitely work. i'll give it a shot.

(altho you don't need to run lerna yourself; npm install should do all the necessary things)

Thanks! To be accurate, that is a result through npm install. If anyone doesn't have the trouble, my environment would have a problem.

Thanks!

https://github.com/airbnb/enzyme/pull/1261#issuecomment-341760426
(I avoided the trouble by lerna bootstrap --concurrency 1 🤔)

Is this fixed and already in the latest version? Because I am using 3.3.0 and this problem persists. The workaround for me is to use mount instead of shallow.


:robot: Build framework images on self-hosted during release

What this PR does / why we need it: We were not using self-hosted runners to build framework images during release
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1240

merging it, we can just test on release


Select micro-framework for wrapping Range with Element

Used for marking TextQuoteSelectors @ Applicator.js

https://github.com/frank06/ranger
https://github.com/lakenen/wrap-range-text
https://github.com/webmodules/wrap-range

Done and implemented in f339e5d.
Chose wrap-range-text because ranger doesn't export as module and wrap-range lacked functionality.


Consider targeting at 4.6.x for a better OOTB experience.

Is targeting .NET Framework 4.7 really neccessary for ColorTool?

I edited the csproj to target v4.6 and it compiled fine, so I'd say the answer to this is a resounding no -- 4.7 is just blocking regular w10 users who have 4.6.2 ootb.

PR submitted COUGH

cough Pull Request cough
As for targeting 4.7:
You need to build this yourself, and the base Visual Studio 2017 install (as older versions aren't available anymore) for building C# code comes with the 4.7 SDK so this would only block people with older versions of Visual Studio.

Right, 4.7 is in an optional component, but the default workloads for desktop and web use 4.6.1.

My bad then, ignore what i said

This has been merged

Sorry for the reference, #7 was in the text to describe the number, it wasn't related to this other issue but got automatically processed as such.


Chats list header and new menu

Implement chats list header and menu UI
Base branch: develop
Requirements

Build UI for chats list header (Including new Menu button and new icon to share public key)
Implement logic to show balance and trigger contact/messages fetch
Build UI for chats list hamburger menu

Figma designs:
https://www.figma.com/design/suipHjIGKg38rbWo0qHGqV/Desktop-Design-System---Dark-Version?node-id=3512-27733&node-type=canvas&m=dev
Acceptance Criteria

[ ] Implements UI and logic for chats list header and new menu

can you assign this to me?

@tomastiminskas - Lemme Know if this issue is up for grab, assign it to me?

@RajVerma97 @j4nlksh this ticket is already assigned. Let me know what languages are you up to so I can try to get some bounties out!

I have experience with next'js and react native .I would be glad to work on either of the tech.

@j4nlksh this ticket is already assigned. Let me know what languages are you up to so I can try to get some bounties out!

I've got good back w/ React & Next as Well!


Write a function that interacts with Google Map API to get elevation from GPS coordinates

On it.

Done


pattern_lang has wrong error

The property pattern_lang has been removed from the Indicator, but it still says:
{217} pattern_lang contains a value not in the pattern-lang-ov vocabulary.

This will be fixed when we update the validator for RC3.


adding an 'edo' ugen

Hey Paul, per your suggestion, I kept this out of soundpipe. Hopefully this new ugen is general enough for you...middle C as an anchor pitch is assumed here, and the pitch_num index '0' will always represent middle-C (negative numbers for below, positive for above). Check out the 'edo.sp' example for usage.

Sure
On Sun, May 27, 2018, 14:21 Paul Batchelor<EMAIL_ADDRESS>wrote:

@PaulBatchelor commented on this pull request.
In ugens/basic.c
https://github.com/PaulBatchelor/Sporth/pull/36#discussion_r191085897:

@@ -827,6 +827,54 @@ int sporth_mtof(sporth_stack *stack, void *ud)
return PLUMBER_OK;
}

+SPFLOAT sporth_edo_helper(SPFLOAT nn, SPFLOAT edo)
Could you make this function static?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PaulBatchelor/Sporth/pull/36#pullrequestreview-123593143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY9bH6Bk_eVYrcVwqm8Aa_nedvCyPgw_ks5t2vyhgaJpZM4UPUkr
.


Add the underlying type to GoType

Adds the underlying type to GoType. The underlying type for id in this example will be int
type CustomID int
var id CustomID

:+1: looks good, thanks!


$ref to an invalid schema always says the data is valid

If a file referenced by $ref is a random JSON instead of a schema, validation always passes instead of raising an error. I think the $ref contents should also be verified with check_schema first.

When you say "random JSON", do you mean " a JSON object with some keys that aren't necessarily known validators "? Such a thing is a valid schema, and all things validate successfully against it.

Yes, I'm sorry, I didn't know that. Allowing a schema to contain arbitrary keys is counter-intuitive to me... I think it would be nice to implement the "Ban unknown properties" mode proposal and provide an option to use this mode for schema checking. Maybe even by default, if the standard (draft) allows this.

No worries -- it's quite a useful feature, it's what allows the spec to be extended with extra validators without sacrificing (the entirety) of portability.
There's code in some old issues for disallowing additionalProperties in schemas if you're looking for the behavior.


Update howto-configure-opcua-authentication-options.md

Update copy paste issue.

@dominicbetts
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @WilliamBerryiii - thanks for spotting this and taking the time to create the PR.
#sign-off


swr-infinite pagination

I am trying to find a way to update only a single resource from the data that can have multiple pages.
So, for example, when I update a post that is found on 3. "page" in the data that I received from swr response, how could I revalidate only that page?
I tried using global mutate by providing exact url (like: "&count=10&from=0"), and this worked but only for the first page, if I change params to  "&count=10&from=10", so to fetch next 10 it doesn't work.
Also for the first one when it worked, it worked only when I adedd this prefix ("$inf$").
If you have any suggestions how this could be done, please let me know.
Thanks!

Will post this in the discussion section.


ISO-8601 date format for log timestamps

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Current log timestamp format is like Mar 01 01:25:28.484.
What is the expected behavior?
ISO-8601 format: 2022-03-01T01:25:28.484+00:00
Using the ISO standard would make interoperability much easier. In particular easier processing and analytics of the graph-node logs without having to resort to custom decoding of the timestamp.

Thanks @aasseman! What do you think @leoyvens & @tilacog? Seems like probably quite a small change, but I wonder if it would break anything?

We can look into making this configurable.

Hi.It seems like a issue for which easy to resolve by a new contributor.Is a good solution to add a new environment variable to config   which date format? @leoyvens @azf20

Done in #3387, thanks for tackling this @willser!


[BUG] cards missing when horizontal rule present in document

All cards within a document disappear when there's a horizontal line (---) present in the document
To Reproduce
Steps to reproduce the behavior:

Go to the end of the document
Add a horizontal line (---) before the #flashcards hastag for example
Reload
See error

Expected behavior
Cards are kept regardless
Screenshots
Cards present:

Cards missing:

Versions (please complete the following information):

OS: Windows 10 64b
Obsidian version: 1.5.12
Plugin version: 1.12.4
If on desktop, Installer version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/1.4.13 Chrome/114.0.5735.289 Electron/25.8.1 Safari/537.36

test-cards.md

Hi @AdrianSkar thanks for letting us know.
To help us reproduce, could you please post the actual markdown file (attach to your post, not copy & paste)
Cheers
Ronny

Discovered similar issue but with --- inside a code block

Hi @AdrianSkar thanks for letting us know.
To help us reproduce, could you please post the actual markdown file (attach to your post, not copy & paste)
Cheers Ronny

Sure! Thank you.


Results are different from the Bluemix dashboard tooling test

The results from the demo that was put together using this repo are  different from the results shown in the Conversation dashboard test for the same workspace.
Results from dashboard test

Results from demo:

You are likely using two different API versions. The sample app is likely using an older API version and we are still in the process of updating it, while the tryoutpanel is likely the most up to date.
If you want the same answers, then youll need to update the API version in the sample app code, if you like the sample app responses, keep the old API version.


mobile: hopefully reducing test flakes

https://productionresultssa11.blob.core.windows.net/actions-results/20c6bc1d-a543-4566-8758-83d884608a27/workflow-job-run-d2c4c874-8b8b-5fed-920d-f5a0759b8c9b/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-05-30T14%3A53%3A27Z&sig=rgmX5sWOqG3kzirFC8iOVuMGfKcjASTkc2QxhQVAaKU%3D&sp=r&spr=https&sr=b&st=2024-05-30T14%3A43%3A22Z&sv=2021-12-02
Looks like *san wait times can be more like 5s on slow machines.


Creating a RequestAuthentication object with an invalid 'jwks' parameter causes istio-proxy sidecars to break

Bug description
I run the following test deployment / service exposed via an ingress gateway:

Deployment / service / gateway / virtualservice definitions
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: my-app
  labels:
    app: my-app
spec:
  replicas: 1
  selector:
    matchLabels:
      app: my-app
  template:
    metadata:
      labels:
        app: my-app
    spec:
      containers:
      - name: main
        image: kennethreitz/httpbin
        ports:
        - containerPort: 80
---
apiVersion: v1
kind: Service
metadata:
  name: my-app-service
spec:
  selector:
    app: my-app
  ports:
    - protocol: TCP
      port: 80
      targetPort: 80

---
# Ingress GW
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: my-ingress-gateway
spec:
  selector:
    istio: ingressgateway # use Istio default gateway implementation
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "httpbin.myhost.com"
---
# Routes mapping for the GW
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: my-httpbin-virtual-service
spec:
  hosts:
  - "httpbin.myhost.com"
  gateways:
  - my-ingress-gateway
  http:
  - match:
    - uri:
        prefix: /httpbin
    route:
    - destination:
        port:
          number: 80
        host: my-app-service
    rewrite:
      uri: /

This works just fine. At this point, I added by mistake a RequestAuthentication with an invalid jwks:
apiVersion: security.istio.io/v1beta1
kind: RequestAuthentication
metadata:
  name: my-service-req-authn
spec:
  selector:
    matchLabels:
      app: my-app
  jwtRules:
  - issuer: christophe
    jwks: foo # <-- this is invalid

As soon as this is created, it completely breaks istio-proxy for the pods of this workload. Here's the output of istio-proxy:
2021-05-24T14:55:15.870513Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-05-24T14:55:17.870519Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected

As soon as I fix the RequestAuthentication object by a valid one, e.g.
apiVersion: security.istio.io/v1beta1
kind: RequestAuthentication
metadata:
  name: my-service-req-authn
spec:
  selector:
    matchLabels:
      app: my-app
  jwtRules:
  - issuer: christophe
    jwks: >
      { "keys":[ {"e":"AQAB","kid":"DHFbpoIUqrY8t2zpA2qXfCmr5VO5ZEr4RzHU_-envvQ","kty":"RSA","n":"xAE7eB6qugXyCAG3yhh7pkDkT65pHymX-P7KfIupjf59vsdo91bSP9C8H07pSAGQO1MV_xFj9VswgsCg4R6otmg5PV2He95lZdHtOcU5DXIg_pbhLdKXbi66GlVeK6ABZOUW3WYtnNHD-91gVuoeJT_DwtGGcp4ignkgXfkiEm4sw-4sfb4qdt5oLbyVpmW6x9cfa7vs2WTfURiCrBoUqgBo_-4WTiULmmHSGZHOjzwa8WtrtOQGsAFjIbno85jp6MnGGGZPYZbDAa_b3y5u-YpW7ypZrvD8BgtKVjgtQgZhLAGezMt0ua3DRrWnKqTZ0BJ_EyxOGuHJrLsn00fnMQ"}]}

... then the sidecars start working again:
2021-05-24T14:56:55.870391Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-05-24T14:56:57.870620Z	warn	Envoy proxy is NOT ready: config not received from Pilot (is Pilot running?): cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2021-05-24T14:56:59.870984Z	info	Initialization took 9m41.838941787s
2021-05-24T14:56:59.871013Z	info	Envoy proxy is ready

Here's the output of istioctl bug-report when it's in the state Envoy proxy is NOT ready:
bug-report.tar.gz
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior The RequestAuthentication resource is refused at creation time or ignored
Steps to reproduce the bug

Deploy the deployment / service / gateway / virtualservice provided above
Deploy the (invalid) RequestAuthentication object
Kill a pod to have a new one started by the deployment controller
Notice how the sidecar is not working

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
$ istioctl version --remote
client version: 1.10.0
control plane version: 1.10.0
data plane version: 1.10.0 (3 proxies)

$ kubectl version --short
Client Version: v1.21.1
Server Version: v1.20.2

How was Istio installed? Using istioctl install --verify
Environment where the bug was observed (cloud vendor, OS, etc) DigitalOcean managed Kubernetes service

cc @yangminzhu

I think the validation could be updated to reject such obvious invalid config, it might be tricky to match the exact validation behavior in the Envoy JWT filter but we should at least check for some common issues.

Hey guys! I'd like to contribute by doing this validation if that's possible. I'd still need a little bit of guidance since I'm still pretty new to the codebase. And wouldn't know where to begin looking. I think I should start looking into Galley.
If I understood correctly the issue, we would like to either apply the RequestAuthentication or completely ignore it, right?

Hey guys! I'd like to contribute by doing this validation if that's possible. I'd still need a little bit of guidance since I'm still pretty new to the codebase, and wouldn't know where to begin looking. I think I should start looking into Galley.
If I understood correctly the issue, we would like to either apply the RequestAuthentication or completely ignore it, right?

ohhh, I have already done it...

Hey guys! I'd like to contribute by doing this validation if that's possible. I'd still need a little bit of guidance since I'm still pretty new to the codebase, and wouldn't know where to begin looking. I think I should start looking into Galley.
If I understood correctly the issue, we would like to either apply the RequestAuthentication or completely ignore it, right?

ohhh, I have already done it...

Hey Kebe! Completely cool! I'll take a look at your PR to see how to achieve this


DO NOT MERGE - Reject anonymous payments

Any payment which has incomplete sender information will no longer
be credited to a prisoner, even if it is possible to identify the
prisoner for whom it is intended. Instead it will be classified as
an 'unidentified' payment and no automatic action will be taken.
Payments lacking sender information which have been credited in the
past will still show up as successful payments.

This should not be merged until process and messaging have been updated.


Do not check if non-abstract class members are implemented in object expression

This does fix https://github.com/Microsoft/visualfsharp/issues/4961, but maybe it's better to return isOptional flag based on abstractness of methods at https://github.com/Microsoft/visualfsharp/blob/4eed66b39d0db4c3c2d63bf11e98f4ea3f30be4c/src/fsharp/MethodOverrides.fs#L478

The perf is not improved for normal inheritance. However, the bottleneck is new:

It's ready.

Can we move parts of it out and pass it in again?

@forki No, but what it does with this "set" is to check if there is exactly one meth by name and args, so I'm gonna to get the head and check that there are no duplicates, it will be O(n).

BTW, that ListSet.setify is a dangerous function (as well as the entire ListSet - all the operations are O(N^2) AFAIK. Maybe it's worth to check the codebase for its usages and eliminate them.

Funny how even GitHub gives up on basic colorization for src/fsharp/TypeChecker.fs

I think setify was always used under assumption that lists are small.

@forki it might be worth to put an assert checking list size there and try to see how valid the assumption is.

Wouldn't that just break people's code completely?
Gauthier Segay<EMAIL_ADDRESS>schrieb am Di., 22. Mai 2018,
19:51:

I think setify was always used under assumption that lists are small.
@forki https://github.com/forki it might be worth to put an assert
checking list size there and try to see how valid the assumption is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/pull/4971#issuecomment-391081800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNPg7XolO4j0wEKc8BN1XS9ibHsi8ks5t1FAOgaJpZM4UIioK
.

I've optimised normal inheritance as well:

It's not as smooth as with object expressions because it does need to check that all the overloads are the equivalent. I'd love to optimise it further.

@vasily-kirichenko can you rename the PR to something to the effect of "Optimize unnecessary checks when computing overloads"? (Not sure of the proper title but that seems like what this work is doing)
On a side note, @dsyme do you have insights into the ListSet module? I agree with @vasily-kirichenko that it feels quite dangerous to use things from there, especially since certain combinators (e.g., List.forall exist)

@matthid

Funny how even GitHub gives up on basic colorization for src/fsharp/TypeChecker.fs
I've just from that file in VS - everything works tolerably fast, colorization is there.

@forki

Wouldn't that just break people's code completely?

I agree.

@cartermp done

let's review ALL setify places. I think I already found one that can be improved. will send PR

#4973

Yes, the code was written on the assumption to the 20 overloads of the same name found in WriteLine and friends was at the upper end of what we would see.  That was 2006.

On a side note, @dsyme do you have insights into the ListSet module? I agree with @vasily-kirichenko that it feels quite dangerous to use things from there, especially since certain combinators (e.g., List.forall) exist and appear to do the same work

Yes, nearly all traces of this have gone but there are still a few lurking.  It is vaguely useful as an ordered set for small collections.

Yes, the code was written on the assumption to the 20 overloads of the same name found in WriteLine and friends was at the upper end of what we would see. That was 2006.

In the meantime in C#:

Better (overload resolution) in C# 2 or 3
Better Betterness (of overload resolution) in C# 6
Improved overload candidates and bestest betterness (of overload resolution) in C#7

@dsyme has the handling of overload resolution in F# compiler followed a same route as in C# (where I feel a lot of carefull but noticeable improvements have been made over the releases)?
It always feel that it gets in the way whenever the types are using that mechanism "creatively", I'm still challenged once in a while, even after few years of using F#, to write some calls right for the compiler to pick the correct overload, and I'm sure it trips a lot of newcomers.

@dsyme has the handling of overload resolution in F# compiler followed a same route as in C# (where I feel a lot of carefull but noticeable improvements have been made over the releases)?

Some improvements have been made, particularly in the presence of large sets of generic overloads, but we have not tracked the C# improvements since the type inference used by F# is different. There are still some overload sets that cause problems like Task.


0.4.0 breaks my build

"Because of protocols, they can still be used with the Calendar functions for formatting, timezone shifting etc." this line from the changelog is simply not true.  Functions like Calendar.DateTime.diff are actually defined on data structures from Calendar.
Furthermore I actually have some of my protocols implemented for Calendar, now I have to duplicate this code for Calecto structures.
And just out of curiosity why you decided to change the underlaying data structures?

Hi

"Because of protocols, they can still be used with the Calendar functions for formatting, timezone shifting etc." this line from the changelog is simply not true.

It is true for most functions in Date, Strftime, NaiveDateTime, Time. But I guess Calendar.DateTime functions need to have some functions added, so that DateTimeUTC structs can be used with Calendar.DateTime functions. Thank you for bringing that to my attention. I assume that it is a Calecto.DateTimeUTC field that you want to use Calendar.DateTime.diff on?
I plan to fix the issue with DateTimeUTC compatability with Calendar.DateTime functions.
I decided to change it so that you can use them in queries. E.g. you can use Calecto.Date structs in an Ecto query.

The only function I haven't found to work are Calendar.DateTime.diff (and related functions before? after? same_time?). Have you found any other functions that don't work?

@sumerman Try upgrading Calendar to version 0.12.1 And also upgrading Calecto to the newest version.
Calendar.DateTime.diff should work with DateTime.diff now.
Let me know if you find any other problems.

@lau Thanks for fixing diff. Sorry it took me so long, didn't have time for the project I'm using calecto in.
But I still have to implement my protocols twice, have <= operator broken.

But I still have to implement my protocols twice, have <= operator broken.

Could you post a more detailed explanation of what you are trying to do? If you want you can cast e.g. Calendar.Date as Calecto.Date and the other way around.

Let's say I just don't understand the reason to have 2 different datatypes with exactly the same structure given that you are the maintainer of both projects. Furthermore there are cases (even in your own calendar_phoenix) where you have to have protocol implemented twice. Finally, for terms representing dates erlang term order was a natural way to compare.

I explained why:

I decided to change it so that you can use them in queries. E.g. you can use Calecto.Date structs in an Ecto query.

To expand: At the time you could not do queries using e.g. Calendar.Date or Calendar.DateTime because of how Ecto treated custom types.
Fortunately Ecto has since added the Ecto.DataType protocol. This allows getting rid of the Calecto structs so Calendar structs can be used in queries too. So I plan to implement that protocol and get rid of the Calecto structs. So there won't be two different datatypes representing the same thing anymore.

@lau thanks, after expanded explanation it all makes sense.

You're welcome. Version 0.5.0 has been released and goes back to returning Calendar structs instead of Calecto structs.

@lau thank you again.


Profile Social links title

@ mention of reviewers
@Didayolo
A brief description of the purpose of the changes contained in this PR.
In profile page, the title for Github was Website. Now it is fixed

Checklist

[x] Code review by me
[x] Hand tested by me
[x] I'm proud of my work
[x] Code review by reviewer
[x] Hand tested by reviewer
[x] CircleCi tests are passing
[x] Ready to merge

Nice catch


Generic category support

Figure out a way to generically add categories, so for example it's easy for the user to add subcategories like say, a category for picked up logs, a category for weapons database, whatever.
It has to be done in such a way that it makes no assumption about the intended design. User should be able to very easily add their own subcategories while being exposed as little as possible to the underlying code.

https://github.com/nashmuhandes/PDA_Starter_Kit/issues/4


fix(cli-core): remove unsupported option for yarn berry

:tada: This PR is included in version 4.5.5 :tada:
The release is available on:

v4.5.5
GitHub release

Your semantic-release bot :package::rocket:


add ArtPrompt probes

Fix #535
Implements two prompt obfuscation patterns based on ArtPrompt
Testing work is still in progress here a new possible base case or detector specific to technique, may be needed. As current mitigation.MitigationBypass detector does not quite cover the returned values when the model is not able to infer the masked word.
Example Usage pattern:
python -m garak -m huggingface.Model -n meta-llama/Llama-2-7b-chat-hf -p artprompt
python -m garak -m huggingface --model_name gpt2 --probes artprompt

The probe pattern could be enhanced to be provided a dataset of prompts to be augmented with a dictionary of unsafe words often blocked by safety training that can be easily maintained as a set of resource files.

This is looking pretty reasonable. Agree that a probe works well for the case that the paper presents!

Hi, my team was thinking of building this as a Buff for the Apart Deception Hackathon (but, just saw this pull request already existed!) - is there anything that's still waiting on being implemented?

@zazer0, the current implementation for the probe is mostly complete, a plan for configurable prompts will likely be worked on after #602.
The primary reason this is still in draft is that work is still needed to generate a better detector for evaluating the responses from a prompt offered by this probe. The current detectors look for a mitigation response however this probe would needs additional filtering to determine if the response was able to identify the safety  word masked in the prompt as failure to decode would not represent a finding of successful bypass of alignment or mitigation.

Given the upcoming payloads work on decoupling content from transformation, can it make sense to put this through as a probe in this PR?  And defer (in separate PRs):
a. making the encoded texts accessible via the payload mechanism;
b. a buff


Example app constantly crashes on Heroku

Description
👋🏼  When I deploy the example app to heroku, the first time it works, but the 2nd time it always crashes with:
2021-07-13T06:22:55.725901+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2021-07-13T06:22:55.766346+00:00 heroku[web.1]: Stopping process with SIGKILL
2021-07-13T06:22:55.844048+00:00 heroku[web.1]: Process exited with status 137
2021-07-13T06:22:56.081258+00:00 heroku[web.1]: State changed from starting to crashed

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Hi @dunyakirkali, thanks for asking the question!
I've never experienced this before but I will check if the situation arises to me. Did you follow the steps in https://slack.dev/bolt-js/deployments/heroku?

Hi @dunyakirkali, thanks for asking the question!
I've never experienced this before but I will check if the situation arises to me. Did you follow the steps in https://slack.dev/bolt-js/deployments/heroku?

Yes. I followed those steps exactly.

@dunyakirkali - Here are some common reasons for the R10 error, in case that helps your troubleshooting:  Why is my node js app crashing with an r10 error?

@dunyakirkali - Here are some common reasons for the R10 error, in case that helps your troubleshooting: Why is my node js app crashing with an r10 error?

@srajiang Thank you for your reply.

I do indeed use process.env.PORT (just as in the sample app)
About using <IP_ADDRESS> instead of localhost: I couldn't find a way of achieving this wit boltjs
The last item (having a single command in npm run start) is also correct (just as in the sample app)

One change I have dnoe tho, is to enable the socket mode. Could that be the issue?

@dunyakirkali
Ah, for running a Socket Mode app on Heroku, you can use "worker" mode in Procfile instead! Checking https://github.com/slackapi/bolt-js/pull/932/files should be helpful to you 👋

Just tested it and it works. Thank you


The --fmt option should allow a "help" specifier

It's becoming tedious to document the various formatting options (especially the field names) in the manual, and easy to forget to do it.  It would be better for --fmt to respond to "help" by printing help.  It's not a great fit in the pipeline, because --fmt is parsed very late, but probably doable: if a command has an --fmt option, and the string value for that is /help/ or starts with /help,/, then print help and exit.  This requires that the printing modules must be reorganized a little because they need to initialize the formatters and aliases earlier than now.

Plausible sketch for this on larstha-137-wip-format-help, but I don't have time to finish that right now.


Fix bootstrap scss import order

According to the migration guide of bootstrap, we should import bootstrap files in the following order:
https://getbootstrap.com/docs/5.3/migration/#new-_mapsscss

bootstrap/scss/functions
bootstrap/scss/maps
bootstrap/scss/variables

Currently, we import them like so:

bootstrap/scss/functions
bootstrap/scss/variables
bootstrap/scss/maps

Originally reported by Rathore Mikender, IT12.2

@swisspost/design-system-maintainers: Intense testing necessary!


About other Version

Hello, I  indeed appreciate your great work. Could you tell if there are other version of implementation, such as PyTorch,TensorFlow or so on?

TensorFlow implementation is available at https://github.com/cardwing/Codes-for-Lane-Detection.

Danke schön


[Event Request] codeunit 99000834 "Purch. Line-Reserve" - OnBeforeVerifyChange

Hi Team,
In codeunit 99000834, please provide the possibility to have OnBeforeVerifyChange event in procedure.
procedure VerifyChange(var NewPurchLine: Record "Purchase Line"; var OldPurchLine: Record "Purchase Line")
After begin at Line No 124
IsHandled := false;
OnBeforeVerifyChange(NewPurchaseLine, OldPurchaseLine, IsHandled);
if IsHandled then
exit;

Event:
[IntegrationEvent(false, false)]
local procedure OnBeforeVerifyChange(var NewPurchaseLine: Record "Purchase Line"; var OldPurchaseLine: Record "Purchase Line"; var IsHandled: Boolean)
begin
end;

Hi Team,
Any update on the above request.

Hi Team
Any update on the above request.

Event already implemented by other request(s).
It is or will be available in some of the next releases.


Soft AP on ESP-WIFI-MESH (IDFGH-9356)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[x] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I'm trying to create a mesh network with an exposed soft AP interface serving a page via HTTP (so that other devices may connect to the mesh nodes and root).
My question is: is it possible to make such a server with AP from the nodes of a mesh?
The docs for esp_netif_create_default_wifi_mesh_netifs() mention that the ESP-MESH API disables both DHCP client and server:
Creates default STA and AP network interfaces for esp-mesh.
Both netifs are almost identical to the default station and soft AP,
but with DHCP client and server disabled.
Please note that the DHCP client is typically enabled only if the device is promoted to a root node.
Returns created interfaces which could be ignored setting parameters to NULL if an
application code does not need to save the interface instances for further processing.

Here is an example code:
// initialize netif
ESP_ERROR_CHECK(esp_netif_init());
ESP_ERROR_CHECK(esp_event_loop_create_default());
ESP_ERROR_CHECK(esp_netif_create_default_wifi_mesh_netifs(&m_netif_sta, &m_netif_ap));

// initialize and start WiFi
wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
ESP_ERROR_CHECK(esp_wifi_init(&cfg));
ESP_ERROR_CHECK(esp_wifi_start());

// initialize mesh
esp_mesh_init();
ESP_ERROR_CHECK(esp_netif_dhcps_start(m_netif_ap));

When I try to enable the DHCP server to use the ESP as an access point, it crashes:
dhcps = 0x0, netif = 0x3ffc4dec
E (2292) esp_netif_lwip: DHCP server cannot be started (err -16)
ESP_ERROR_CHECK failed: esp_err_t 0x500d (ESP_ERR_ESP_NETIF_DHCPS_START_FAILED) at 0x400d7c25

It seems the dhcps is not being initialized by the API.

Also, I've done another test by using esp_netif_create_default_wifi_sta and esp_netif_create_default_wifi_ap instead of esp_netif_create_default_wifi_mesh_netifs without calling esp_mesh_init and it worked (I could access the AP with its SSID and password, and open the HTML page). But when I call esp_mesh_init, I can no longer connect to its SSID and my external device stays in an infinite reconnection loop with timeout, despite not logging any error.
This is my second attempt:
ESP_ERROR_CHECK(esp_netif_init());
ESP_ERROR_CHECK(esp_event_loop_create_default());

// ESP_ERROR_CHECK(esp_netif_create_default_wifi_mesh_netifs(&m_netif_sta, &m_netif_ap));

m_netif_sta = esp_netif_create_default_wifi_sta();
m_netif_ap = esp_netif_create_default_wifi_ap();

wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();

ESP_ERROR_CHECK(esp_wifi_init(&cfg));

ESP_ERROR_CHECK(esp_wifi_start());

wifi_config_t ap_cfg{};

memcpy(
    ap_cfg.ap.ssid,
    "MyNetwork",
    32
);

memcpy(
    ap_cfg.ap.password,
    "MyPassword",
    64
);

ap_cfg.ap.max_connection = 3;

ap_cfg.ap.authmode = WIFI_AUTH_WPA_WPA2_PSK;

esp_wifi_set_config(wifi_interface_t::WIFI_IF_AP, &ap_cfg);

esp_err_t ret = ESP_ERR_MESH_NOT_INIT;
// ret = esp_mesh_init(); // AP only works if mesh is not initialized

@eduardobehr I think the official example esp-idf/examples/mesh/ip_internal_network can meet your requirements.

Thanks, I took a look at the example and I'm trying to make it work for my case.
Do you know if it's possible to access the mesh nodes' access points with external devices? There is the following struct which I think should be used here:
esp_mesh.h
/**
 * @brief Mesh softAP configuration
 */
typedef struct {
    uint8_t password[64];              /**< mesh softAP password */
    /**
     * max number of stations allowed to connect in, default 6, max 10
     * = max_connection + nonmesh_max_connection
     */
    uint8_t max_connection;            /**< max mesh connections */
    uint8_t nonmesh_max_connection;    /**< max non-mesh connections */
} mesh_ap_cfg_t;

It mentions "non-mesh connections", which I understand by external devices (e.g. Android phone). However, the AP layer doesn't seem to emit an SSID, which could be used by other devices. It seems to generate a hidden network.

I also asked this on the following commit, which introduced the supposed feature:
https://github.com/espressif/esp-idf/commit/42a1be10db3fdba1c7f2ba4b8a542bc72371ad6e#commitcomment-121519972

@eduardobehr About the non-mesh device connects to mesh network, you can refer to this https://github.com/espressif/esp-idf/pull/8158

@eduardobehr Can this issue be closed?

I wasn't able to test it for now, but you may close it.

Thanks for reporting, we will close this issue. Feel free to reopen if have more updates.


Navigate through disconnected containers

If blocks are not connected you cannot use the hot keys to select them

W/S on a container block goes to the respective container


initial commit

Merging to Close the loop on this. Work still needs to be done before publishing. This is a good start for iterative improvements until version 1.0


About how to set new Screen IDs in constants.SCREEN_CONFIG[XX].bbox

HI! This is a awesome project!
However, there some SCREEN_CONFIG.bbox settings rule of constants makes me so confuse, such as why OK_bbox setting is like OK_X = 143, OK_Y = 558 ,even ok button's upper left coordinates is (280,1096) approximately.
How to get them?
And I want to add “Party mode” icon in SCREEN_CONFIG for setting a new screen_state, I already screenshot a Party mode png-24 (without Alpha channel), and bbox setting using its upper left coordinates, but I still can not get a low hash_diffs like other state, end_of_game or lobby, down blow 10.  Could you please tell me how to set appropriate bbox values?
Here is my party setting in constants:
ClashRoyaleBuildABot\clashroyalebuildabot\data\images\screen
party.png 38X38  24-PNG

PARTY_SIZE = 38
PARTY_X = 305
PARTY_Y = 397

SCREEN_CONFIG = {
.....
    'party': {'bbox': (PARTY_X,
                       PARTY_Y,
                       PARTY_X + PARTY_SIZE,
                       PARTY_Y + PARTY_SIZE),
              'click_coordinates': (420, 420)},
}

Hello! Sorry for the slow reply.
The bounding box values need to be scaled relative to the screenshot size. These scaling factors are S_x = SCREENSHOT_WIDTH / DISPLAY_WIDTH = 368 / 720 = 0.51 and S_y = SCREENSHOT_HEIGHT / DISPLAY_HEIGHT = 652 / 1280 = 0.51. That explains why the coordinates are about 2x the size.
If you still have a problem with the hashes after this let me know and I will investigate. It's possible you might have to increase the threshold in clashroyalebuildabot/state/screen_detector.py...

The solution worked perfectly.
Thank you so much for your help, and really appreciate your time and effort in answering my question.
Then I found out that most of the min_hash of Party battle scenes is above 29.
What needs to be solved now is to find an area of the image that can make the hash lower than 20 or even 10


KSP supports?

The lib does not support KSP at the moment.
I definitely have in mind to add KSP support in the future. Just not at the moment, since KSP is still in very early development. I think when KSP beta/rc release comes out, I'll release a KSP artifact.

The KSP support has been added. See #24 for PR and README's section for more info.


alpha channel is needed

I found this package in this comment: https://github.com/Qix-/color/issues/99#issuecomment-266601291
i thought that it would be directly compatible with color, but its not totally:
e.g. this leads to wrong results, because color-blends needs an alpha channel (property a):
import Color from 'color'
import blender from 'color-blend'

const color1 = Color("#B5E684")
const colorBlended = blender.normal(color1, Color("yellow")) // returns {r: NaN, g: NaN, b: NaN, a: NaN}

No, it's not the goal of this package to be specifically compatible with the Color package. Its approach is a little more broad.
However, it should not be too hard to write a wrapper that does so:
import Color from 'color'
import blender from 'color-blend'

export default Object.keys(blender).reduce((carry, prop) => Object.assign({}, carry,
  prop === 'options'
    ? {}
    : {
      [prop]: (backdrop, source) => {
        const { r, g, b, a } = blender[prop]({
          r: backdrop.red(),
          g: backdrop.green(),
          b: backdrop.blue(),
          a: backdrop.alpha()
        }, {
          r: source.red(),
          g: source.green(),
          b: source.blue(),
          a: source.alpha()
        })

        return Color({ r, g, b, alpha: a })
      }
    }
), {})

This exports a version of the blender that takes two Color objects and also returns a Color object.
I've not tested it extensively but the few cases I've tried worked fine.


Add hooks before and after operators

Describe the feature
I noticed the project has a hook factory, which provides an easy way to add some extra business logic (like throughput metric) before and after a training iteration.
However, the name hook is a little bit misunderstanding since it is not the same as the hook of Pytorch.
The PyTorch hooks can add some operations before and after FWD and BWD of a submodule.
Currently, the project does not provide a function in the BaseHook for developers to do some operations before and after a PyTorch submodule (like Linear) execution.
For example, someone would like to depict the memory footprint during training by recording the memory usage before and after an operator execution.
I consider adding register_forward_hook and register_forward_pre_hook functions to HookBase. Just like the setup_zero_stage3_hooks. Does this make sense to you?

Hi, the hooks currently only support the life cycle at the trainer level but not tensor level. Life cycle of trainer hook is like before train, before train iter, after train iteration and so on. If we want to track the memory footprint at the operation level, I think a new hook factory is required.


Progress bar value is not reset after changing story and video time is not calculated properly

@LukasFridmansky thanks for the fix early.
I think there are still issues with the progress bar, especially when using video and images together

first of all the timer should be reset every time a story is changed which at the moment it doesn't happen
secondly, I think the time of the video is not calculated properly as the first time it starts from the default 1000ms value

I really like the library but I think a bit more focus should put on how the progress bar work which I know is usually the most complicated thing to do. Keep the good work

hi, this is an open source project and developing it is not easy because it is not our main goal. However, we would like to welcome new maintainers! we tried to fix that soon as possible. thanks for patience.

Hello, please try to update lib to 1.0.11 and let us know

Hello, thanks for the update. I think it has improved. But I still have issues especially when the stories changes with the Pan animation. If I press on the side it looks it work as intended, but if I drag it left or right sometime the progress doesn't start
DRAG ANIMATION

TAP ANIMATION

Added next fixes to 1.0.12, hope its fine now


Fix corrupt link for May-2018 hardfork

All links for https://github.com/bitcoincashorg/spec/blob/master/may-2018-hardfork.md should be replaced by https://github.com/bitcoincashorg/bitcoincash.org/blob/master/spec/may-2018-hardfork.md due to recent repo reorganization.
Of course, getting rid of the entire hardfork announcement would be one way. But as a quick fix, I propose pointing at correct links because I'm sure many people are getting 404 error when Googling official info (incl. me). 🚶

Thank you for putting this up.  However, this has been superseded by removing the announcement altogether.


Some inline code examples in botbuilder-dialogs is out of date

Examples in the typescript files need to be updated with the latest syntax for creating Waterfall dialogs.

Fixed in #406


How to remove nfs?

So, if we want to uninstall the nfs support, is there an easy way to do that?

@tonivdv - I'm guessing, but I think just delete docker-machine-nfs from /usr/local/bin

no, sorry.. I mean to remove the nfs mount that docker-machine-nfs creates (basically a docker-machine-nfs undo)

Hey @frankcarey ,
Seems a nice feature to add :) . But basically if you remove the /var/lib/boot2docker/bootlocal.sh from your box and restart it should return to the basic functionality. Additionally you can clean the /etc/exports too by removing the line related to your box.

I need this feature, too. After completing the project which required this NFS volume support for local development, I need to switch to another project which can't use NFS volumes, so I need to remove NFS support.


adding a few p3 params

This PR adds parameters used in the P3 Scheme mass regime (Morrison and Milbrandt 2015), soon to be housed in CloudMicrophysics.jl. I'm creating this PR to get this process started, being that it's far from finished.
(More params will be added here as I continue working in CloudMicrophysics.jl.)

bors try

bors try

bors try

bors r+


Decide on home/index page

Should the default page be projects, about, contact, resume or something else? Please share your thoughts.

I was thinking the "about" just so that we can get an overview of a person. What ideas do y'all have?

Me personally I like to jump into code straightaway so I prefer to see the "projects" page.


Fix frsqrte behaviour (and minor changes)

This branch was initially created to fix the error output difference between
SimEng and hardware. (SimEng has greater error than hardware)
There was result differences between hardware and SimEng when the
instruction frsqrte was used.
Therefore, it was suspected to be the cause and some changes are made
as below.
Even though the error output was reduced by very small amount after the fix,
the behaviour of frsqrte is now exactly same as hardware.
The use of 1/sqrt(x) and 1/sqrtf(x) in frsqrte are replaced with the methods
based on the pseudo code from Arm Architecture Reference Manual
Armv8, for Armv8-A architecture profile.
While checking wrongly implemented instructions, better tests are added to
instructions st2 (multi struct), faddp (single precision vector),
mov (general to vector), and frsqrte.
st1 (two 16b vectors variant) and st2 (two 4s vectors post index variant)
are found that they can have minor improvements.
Address generation of st1 is simplified, so it can simply store data vector
by vector.
Type of operands in st2 are changed to uint32_t to ensure non-floating point
data can also be handled.

Whilst it's good that we're improving the functional accuracy of running the minifmm benchmark, I worry that the amount of code used and increased complexity/decreased readability outweighs the accuracy gained. Whilst we want to improve accuracy, we equally want to maintain a clean/ease-to-understand code-base. It seems that there's a lot of work done for an un-proportional positive effect. For the sake of fairness, @FinnWilkinson do you have anything to add to this comment/point-of-view

I agree that it decreases readability a fair bit, and adds alot of code - but if the accuracy of 1/sqrt(x) etc was out for a wide range of hardware then it could potentially be justified. Also, if using 1/sqrt(x) affected benchmark results by a resonable degree then it could be justified to use this new, more accurate implementation.
It would also be useful to know what the original accuaracy discrepency when using 1/sqrt(x) was; as if this is fairly small then again it may be worth accepting this discrepency in order to maintain a more readable code base.
TLDR : maybe it is worth evaluating the original accuracy problem as well as how well the new solution works on a range of benchmarks & processor models before deciding on a solution.

I think it's best if we leave this out for v0.9 and investigate. @viper12590 could you move this branch from your fork to a branch in SimEng please

I made a new branch frsqrte-improvement and changed the base of this PR to it.

I made a mistake while making a frsqrte-improvement branch, so I made new frsqrte-improvement2 branch and changed PR base to it


OCPBUGS-2072: CGU-Hangs-When-A-ManagedCluster-is-Unavailable

Not reachable cluster case handled for backup
Introduced timeout for backup that prevent CGU from hanging
Remaining MCA are deleted for non reachable clusters

Signed-off-by: Sabbir Hasan<EMAIL_ADDRESS>/cc @jc-rh @fontivan

/hold

/jira refresh

Obsoleted by #377 and #383


Farmer jobs paying for thrown chicken eggs

Detailed description of the issue:
The farmer job is paying for eggs that are thrown and even from a dispenser, making it possible for to gain a lot of money exploiting a chicken farm. Is it possible to not pay for chickens that spawn from eggs?
The original ticket from someone else https://github.com/Zrips/Jobs/issues/1188#issue-898820140

Jobs version:  <IP_ADDRESS>
Server Type (Spigot/Paper/etc):  Paper
Server Version (using /ver): This server is running Paper version git-Paper-121 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 4bf2aef)

Sadly there is no way to know who launched egg which caused entity to be spawned. We already using basic look up for closest player when entity spawns due to lack of API to know what source (player) caused this spawn event. Without directly blocking chicken egg dispensing from dispensers we will have to live with this possible exploit or simply avoid using chicken breeding as a way to make money.


Remind PR merge and new case failure

Added features:

Comment PRs with failed test case with "issue closed" tag
Comment PRs with failed test case that has not been recorded in the database

Refinement:

Data types, ci report query fix, ...

This PR is the current up and running version started on Jan. 27th.

Note that GitHub related features (case-issue management and PR reminder) are currently switched off in the running version, specified by empty GitHub token (-tk)

Note that GitHub related features (case-issue management and PR reminder) are currently switched off in the running version, specified by empty GitHub token (-tk)

PTAL @lilinghai

PTAL @lilinghai


Hv for pr

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

57 of 59 (96.61%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 90.067%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

smt/utils/kriging.py
5
7
71.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
5649

Relevant Lines:
6272

💛  - Coveralls


[Doc]: Consider updating the listed APIs for horizontal regridding

Describe your documentation update
After revisiting the horizontal regridding APIs we have listed in the API Reference page, I think listing all of these options can be confusing for the user.

Python classes

https://xcdat.readthedocs.io/en/stable/generated/xcdat.regridder.regrid2.Regrid2Regridder.html
https://xcdat.readthedocs.io/en/stable/generated/xcdat.regridder.xesmf.XESMFRegridder.html

General accessor method

https://xcdat.readthedocs.io/en/stable/generated/xarray.Dataset.regridder.horizontal.html

Individual accessor method by tool

https://xcdat.readthedocs.io/en/stable/generated/xarray.Dataset.regridder.horizontal_xesmf.html
https://xcdat.readthedocs.io/en/stable/generated/xarray.Dataset.regridder.horizontal_regrid2.html

All of these methods achieve the same functions, but go about it in a slightly different way.
This is the callstack with xesmf: horizontal(...tool="xesmf") -> horizonal_xesmf() -> XESMFReridder().
Solution
I propose we just keep "2. General accessor method" listed in our documentation. I foresee most people using that API since it is the most straightforward to use and most flexible (you can specify tool="regrid2" or tool="xesmf").

Any thoughts @xCDAT/core-developers?

I haven't investigated this enough to weigh in on what is right, but I do find the regridder documentation a little confusing (as mentioned here). It seems like 2 has the correct documentation.
One note regarding these references:

Find options at xcdat.regridder.xesmf.XESMFRegridder()

I think this is probably the best way to note/refer to options specific to xESMF / regrid2, but if there was a way of putting it within the documentation here that could be helpful.

These are purely there for documentation, that's the only way to make a link to reference the individual regridder options.

You're right, I forgot you need to list the accessor class to list its methods and attributes.

I'd be fine removing horizontal_xesmf and horizontal_regrid2, they really only save a single argument.

Yeah, I noticed people mostly using horizontal() in their code/notebooks. Those underlying APIs include xesmf or regrid2 in the name of the method, which almost as many characters tool='xesmf'.

After some more thought we could solve the documentation issue by getting rid of horizontal() and vertical() and just have regrid2(), xesmf(), and xgcm(). We could group them together under horizontal and vertical in the documentation since users will probably learn about them there.

After the last meeting, the plan is to deprecate the current regridding accessor functions and remove them in a few release cycles.

horizontal()
vertical()

The horizontal_xesmf() and horizontal_regrid2() will remain and vertical_xgcm() will be added. Retaining the horizontal and vertical prefix will allow the possibility for a regridder to implement both vertical and horizontal.
The documentation will be moved to these methods so there will no longer be a link from the accessor methods to class __init__ methods e.g. accessor method -> class init. Once this is done https://xcdat.readthedocs.io/en/stable/generated/xcdat.regridder.regrid2.Regrid2Regridder.html and https://xcdat.readthedocs.io/en/stable/generated/xcdat.regridder.xesmf.XESMFRegridder.html can be removed. This will drastically clean up the regridding documentation and make the individual regridders documentation easier to access.
I will also do a pass on all the regridding documentation to update anything requiring clarification.

Closing as we've decided to stick with generic horizontal and vertical methods. PR https://github.com/xCDAT/xcdat/pull/535 addresses the documentation changes in this PR.


JBPM-5964 adding cancel button to field edition popup

To be merged before https://github.com/kiegroup/kie-wb-common/pull/887
@pefernan could you give a look?

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

jenkins please test this

@ederign tnx! :)

@alessioscalici could you please fix the conflicts?


[DOCKER] NVM and Node does not persist after build

I can install nvm in my docker container and it's able to install the Node version off the .nvmrc file. The challenge that I'm having is that after the build.  Has anyone run into this issue before?

cc @PeterDaveHello
We do have a dockerfile in the repo; it’s worth checking that out.
I think in general, you need to make sure that you’re using a login shell, or that your shell sources nvm.sh on login.

yeah I assume it's about login shell and nvm.sh sourcing issue.

@rodoabad please confirm that your docker container's shell is sourcing nvm.sh? Happy to reopen if that's not the problem.


[166802401] rubocop update

Delivers Pivotal #166802401

Updates RuboCop (Adds new extensions split from main gem; Updates RuboCop configuration)
Updates CodeClimate configuration to use highest available RuboCop channel

There is no manual test script, though I suppose one could simply RuboCop any file.
Note: when running RuboCop, one should no longer use the -R/--rails option.

Coverage remained the same at 91.842% when pulling 8b433a3b4f2602975c5573b37f76050e126e0e0a on JoeCohen:166802401-rubocop-update into 66c7af5684270a0764ba8088952d46f191f8ad21 on MushroomObserver:master.

Will fix the Codeclimate issues. They all offend the Naming/RescuedExceptionsVariableName cop.
It's a new cop on the block, which we are encountering because this PR bumps (by 4) the RuboCop version  used by Codeclimate. Mildly annoying to have a new cop added, but easy to fix (especially as it's supposed to support autocorrection.)


missing credentials file error, though no credentials are needed

Our grafana-boshworkspace uses a grafana-boshrelease from a public git repo. No credentials are needed for cloning/fetching and with bosh-workspace 0.8.5 everything works fine.
Using bosh-workspace 0.9.0 on the same bws I get the following error with bosh prepare deployment:
"Authentication is required for: https://github.wdf.sap.corp/cloudfoundry/grafana-boshrelease.git
Credentials file does not exist: /home/vcap/landscape-dev06/bosh-workspaces/grafana-boshworkspace/.credentials.yml".
best regards, Stephan

Bosh-workspace 0.9.0 changed the git backend from ruby-git to  rugged. The error you are seeing means check_connection returns false. Unfortunately check_connection only retruns true of false which means bosh-workspace can not display a more helpful message.

Wow. What a fast answer. Thank You!
Digging a little deeper brings me to
Invalid credentials for: https://github.wdf.sap.corp/cloudfoundry/grafana-boshrelease.git
/home/vcap/.rvm/gems/ruby-2.1.2@bosh-1.3001.0.1/gems/rugged-0.23.0b4/lib/rugged/repository.rb:210:in fetch': The SSL certificate is invalid (Rugged::SslError)         from /home/vcap/.rvm/gems/ruby-2.1.2@bosh-1.3001.0.1/gems/rugged-0.23.0b4/lib/rugged/repository.rb:210:in fetch'
Seems like I have to add our internal root certificate to the keystore which rugged uses. Do you know which keystore file rugged uses by default?
Best regards, Stephan

Sorry I don't know which keystore rugged is using, but let me know when you find out because I'm interested as well. But I don't have time to investigate right now (I'm on vacation).

I added the CA.crt to /etc/ssl/certs/ and it's content to /etc/ssl/certs/ca-certificates.crt, called c_rehash then all worked - on ubuntu. Thanks and enjoy your vacation!

Stephan, are you planning on making your grafana bosh release available on bosh.io?

I also encountered this issue. create the .credentials.yml in your bosh-workspace. And add the following content in it.

url: https://github.com/example/top-secret-boshrelease.git
username: foo
password: bar


Can't scroll

I'm running Chrome 60 and I can't scroll the contents of the window. There is no scrollbar and my mouse wheel just scrolls the content in the background window.

Oh crap; that was my bad. I broke it in the last release.
To help me make sure I have fixed it, do you have a sample var_dump that is large enough to induce scrolling?
Thanks!
-Phil

I’ve created a Gist with a var_dump in it: https://gist.github.com/richardwo/42eebd8b7d4059b1841f07cc0a620011 https://gist.github.com/richardwo/42eebd8b7d4059b1841f07cc0a620011
Thanks,
Richard

On 8 Aug 2017, at 17:52, Philip Reasa<EMAIL_ADDRESS>wrote:
Oh crap; that was my bad. I broke it in the last release.
To help me make sure I have fixed it, do you have a sample var_dump that is large enough to induce scrolling?
Thanks!
-Phil
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Rece/var_dump/issues/33#issuecomment-321015742, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVSObQgTjmH1Lax1vUIGS2HsSPivW5Dks5sWJIzgaJpZM4Owo4o.

Thanks Richard. I'll do my best to have this fixed tonight.

Thanks again for that var dump! This has been fixed. I just released it to the web store. Updates should take place in the next 60 mins.
Sorry for any trouble it caused!


refactor(plugin): regex more short

this breaks for js and ts files

@aidenybai it does not break


Feature: Auto use last published workfile as first workfile

Brief description
Add a PreLaunchHook and a setting to use last published workfile as first workfile.

Description
1- Check if setting for this feature is enabled
2- Check if workfile in work area doesn't exist
3- Check if published workfile exists and is copied locally in publish
4- Substitute copied published workfile as first workfile
It recovers Tray's ModulesManager and find initialized sync_server to access its sync_server_thread. An Event has been added to the Thread to be able to wait the reset loop has complete downloading.

Merged, thanks @Tilix4  for contribution and patience :)


Layout displacement while opening search

After reproducing you can see there is a displacement from the top of the window to the first row. When closing the search popup, the displacement is fixed.

VSCode Version: 1.17.0
OS Version: Windows 10 Version 1703 - (Build 15063.608)

Steps to Reproduce:
1.Scroll down until you can't see row one anymore
2.Open search with CTRL+F.
3.Scroll back up.

Reproduces without extensions: Yes

This is expected. The space is there so that the find widget doesn't cover up the first line in the editor.


Tiny changes 2

👷 Deploy Preview for shopify-blog processing.

Name
Link

🔨 Latest commit
5aa9be1f358da9f7f580b3ebac0f9450ade304db

🔍 Latest deploy log
https://app.netlify.com/sites/shopify-blog/deploys/6351c157f4ac1100085a0992


Memory exhausted on byteserving large files

Here is a PHP message on a url
Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate<PHONE_NUMBER> bytes) in /home/XXX/domains/XXX/public_html/application/helpers/byteserve_helper.php on line 152
Message:  Allowed memory size of 134217728 bytes exhausted (tried to allocate<PHONE_NUMBER> bytes)

That's a common problem with a lot of PHP served file download. It can be fixed by setting "output_buffering" to "Off" in the "php.ini" configuration file, or with the ini_set function in the script.


Python2/3 Mixup with IPython Kernels?

Description:
I just updated hydrogen and hydrogen-launcher to the newest versions and it somehow lost track of my ipython kernel locations?
Steps to Reproduce:
When I try to execute code with hydrogen, I get the following error message:

I've always used Hydrogen with Python3.6 and it's worked great..not sure what happened..
Versions:
Which OS and which version of Hydrogen and Atom are you running?
Atom v1.16.0
Hydrogen 1.11.2
Hydrogen-Launcher v1.2.1
OS 10.12.4 (Sierra)
Logs:
Nothing appeared in the dev console..just the error message pasted above.

Hmm. I fixed it by adding another python3 kernel mapping in the optional settings. When I run jupyter kernelspec list --json it gives me a python3 mapping that calls python2.7 ..? Not sure why, but changing the first argv to python3 from python fixed it.

Here's a link with the instructions to install either the python2 or the python3 kernel with Jupyter. This should work for Hydrogen or any other Jupyter tool (e.g. nteract or the notebook).
The kernel spec setting is more convenient when you want to run both pytthon2 or python3 (Hydrogen will prompt you to choose one on first run).
I'm going to close this issue. Please, feel free to reopen if the instructions above don't work for you.

Thank you for reporting this, I've heard others having trouble after the latest ipykernel update within other projects that had similar behavior. I may be able to help fix some other folks' setup.

Had the same issue and was able to resolve per dhhagan's solution above:

changing the first argv to python3 from python fixed it.

This arg is what specifies which binary to call for the kernel, and on most machines python is mapped to 2.7, thus changing this to python3 actually tells the kernel to use python3.  Rather than making this change in the option settings of the Hydrogen plugin, I found it easiest to edit the kernelspec file... which can be located by running jupyter kernelspec list.  For my Mac (using Homebrew), this returned the following:
Available kernels:
  python3    /usr/local/share/jupyter/kernels/python3

This issue still exists, I guess, in 2020 -- but as @dhhagan has stated, changing the first argv to python3 from python fixed it. for me, at least


Fix: detect OpenSSL/LibreSSL from official C headers

Detecting the OpenSSL version using pkg-config is prone to bugs when a libssl.pc or libcrypto.pc definition aren't available, or pkg-config itself isn't available. Using a C preprocessor to extract the official OPENSSL_VERSION_NUMBER and LIBRESSL_VERSION_NUMBER constants from the openssl/opensslv.h header should always be correct.
The version numbers are a little cryptic when compared to their text counterpart, but this is what's expected by OpenSSL, so we should follow.
Of course, if pkg-config if installed we use it to detect the correct version (linking will use it).
fixes #7244

I'm all in favor to abstract a TLS module in Crystal's stdlib, allowing to choose or switch to any library (OpenSSL, BearSSL, GnuTLS, ...) by using a selected shard.
I have some concerns with mbedtls. Looking at TLS linux distributions, there are differently named libraries: libpolarssl.so, libmbedtls.so, and some different ABI versions, which will probably be confusing. Packaged versions of PolarSSL are far outdated (1.3.9 in Debian Jessie for example). It probably requires to switch to mbedtls which may be available or not. One must enable jessie-backports to install it on Debian Jessie, and it's an old 2.4.2 release, that didn't get any update since sept 2017, despite seeing some CVE in newer releases... I'm not sure it has the kind of extended support that old OpenSSL releases can have (in RHEL, Ubuntu or Debian).
OpenSSL is ubiquitous. The API doesn't break much. I spend a couple hours once a year to fix some removed deprecations when a new version is released, and that's it. A real issue has been detecting and supporting LibreSSL, which is supposed to be an OpenSSL 1.0.0 replacement, but isn't exactly, and choosing to use text version numbers, instead of extracting the real version numbers was probably a bad choice. The last issue is that some OS are stuck with a far outdated 0.9.8 for which we should just drop support, like Ruby did 2 years ago: https://github.com/ruby/openssl/commit/4eb4b3297a92149d0a95c674107d091b18fe76af.

Note that the crystal brew depends on openssl, which does install a supported version (1.0.2) but:
openssl is keg-only, which means it was not symlinked into /usr/local,

This means we need to set some things up to use the library we asked to install (sic).
Anyway: CI/darwin is fixed by defaulting to 0.9.8.

@RX14 Let's make that a separate thread, first of all focusing on extracting an implementation-independent TLS API.

Alright, we have 2 choices here:

Default the version to 0.9.8 when no header can be found;

Configure CI/darwin to use the OpenSSL library we asked to install (using pkg-config and PKG_CONFIG_PATH) at least with macOS 10.12; 10.13 may work better since it ships libressl.

We can also fail compilation when headers can't be found. It's an error after all.
I believe the TLS interface and mbedtls are different topics :)

I much prefer version 2.
We shouldn't support unmaintained openssl versions.

I would prefer to have semantic version formatted strings used all around :-(
The brew formula only depends on pkgconfig on build, when bottle the dependency is not installed. Maybe that should change?
I don't see where https://github.com/Homebrew/homebrew-core/blob/master/Formula/crystal.rb depends on openssl (ref: https://github.com/crystal-lang/crystal/pull/7245#issuecomment-450756001)

I would prefer to have semantic version formatted strings used all around

Yes, it's ugly, but that's the way to distinguish versions for OpenSSL, let's not fight it (we lose). We can't expect the pkgconfig definition to be present. OPENSSL_VERSION_TEXT is an arbitrary text and parsing it to extract the version will probably break. We could build the version text by parsing OPENSSL_VERSION_NUMBER, but is that really worth the hassle?

The brew formula only depends on pkgconfig on build, when bottle the dependency is not installed. Maybe that should change?

I don't know. Can someone run the openssl specs from this pull request on a recent macOS release (high sierra or later)?

I don't see where Formula/crystal.rb depends on openssl

The formula may not, but the log of brew install crystal does installs openssl on CircleCI. I don't know why. Maybe it's being updated because it was installed in the CircleCI VM?

Openssl doesn't even follow semver ;)

I would prefer to have semantic version formatted strings used all around

Yes, it's ugly, but that's the way to distinguish versions for OpenSSL, let's not fight it (we lose). We can't expect the pkgconfig definition to be present. OPENSSL_VERSION_TEXT is an arbitrary text and parsing it to extract the version will probably break. We could build the version text by parsing OPENSSL_VERSION_NUMBER, but is that really worth the hassle?

Oh well...

I don't see where Formula/crystal.rb depends on openssl

The formula may not, but the log of brew install crystal does installs openssl on CircleCI. I don't know why. Maybe it's being updated because it was installed in the CircleCI VM?

ruby formula which is updated to 2.3.7 seems to be the one that installs openssl.

* The brew formula only depends on pkgconfig on build, when bottle the dependency is not installed. Maybe that should change?

Yes, it should. Crystal's debian packages already depend on pkg-config. A lot of Crystal assumes pkg-config is available in practice.
The crystal homebrew formula should ensure that the correct PKG_CONFIG_PATH is set for the crystal compiler to see openssl, however it decides to do that.

2\. We can check the default homebrew directory on macOS (`/usr/local/opt/openssl`) and even ask brew about it with `brew --prefix openssl`. That's simple and should just work, without requiring any configuration by the user —it's a shame that openssl is poorly managed on macOS, but that's Apple's fault, not Crystal users' fault.

No, I refuse to merge this. This hack belongs in homebrew, not Crystal. If crystal even needs to know homebrew exists, I will strongly argue against merging it.
Homebrew should wrap crystal (or pkg-config), and export the correct PKG_CONFIG_DIR so that the build environment is correct. It is not crystal's job to fix the build environment!

I don't care about homebrew and macOS, but lots of developers do use them. Adding a few lines to a script file to help the most common scenario ain't much.
Especially since this patch will break all macOS+brew installations, because it only worked by chance until now —defaulting to a 0.9.8/1.0.0 version that happened to be the system installed one.

I don't care about homebrew and macOS, but lots of developers do use them. Adding a few lines to a script file to help the most common scenario ain't much.

I'm not advocating breaking anything, I'm just advocating moving the hack where it belongs.

Then I let someone that's actually using macOS and brew to handle the fix properly in the crystal brew formula. For example:

patching src/openssl/version.sh to search for /usr/local/opt/openssl then fallback to brew --prefix openssl;
make pkg-config a mandatory requirement and fix PKG_CONFIG_PATH in the crystal wrapper shell script;
whatever other solution that works.

Until some as an acceptable solution for both crystal and homebrew, we should wait before merging this PR, or just merge it with the brew fix. I'm fine with whatever, as long as we do fix openssl for homebrew users in the end.

make pkg-config a mandatory requirement and fix PKG_CONFIG_PATH in the crystal wrapper shell script (hopefully we won't need a fix for each and every binding in stdlib);

This was what I was essentially proposing.
Looking at homebrew: pkg-config is compiled with a default pkg-config path which contains the default homebrew locations. So I think just installing pkg-config should be enough?

pkg-config is compiled with a default pkg-config path (...) I think just editing the homebrew formula to install pkg-config should be enough.

No it won't. openssl.pc isn't in a standard location (like /usr/local/lib/pkgconfig) but in a specific installation folder for openssl (/usr/local/opt/openssl/lib/pkgconfig), this is on purpose.

Where is OPENSSL_DIR coming from?

Just a simple mean to quickly select an installed version. Could be removed, but it's nice to just type OPENSSL_DIR=/opt/openssl-1.1.1. It's simpler and less error prone than typing PKG_CONFIG_PATH=/opt/openssl-1.1.1/lib/pkgconfig:$PKG_CONFIG_PATH (or wait, was it lib/pkg-config or PKGCONFIG_DIR? I always forget), especially when trying to test one specific version, among many installed versions.
pkgconfig is a nice tool when things are installed globally on the system, yet awful when they're not.

No it won't. openssl.pc isn't in a standard location (like /usr/local/lib/pkgconfig) but in a specific installation folder for openssl (/usr/local/opt/openssl/lib/pkgconfig), this is on purpose.

I don't understand why they'd do this :/ If Homebrew wants to be awkward, we need to discuss with Homebrew what the proper fix is. Hacking around it without understanding Homebrew's point of view seems ill-advised.

Just a simple mean to quickly select an installed version. Could be removed, but it's nice to just type OPENSSL_DIR=/opt/openssl-1.1.1. It's simpler and less error prone than typing PKG_CONFIG_PATH=/opt/openssl-1.1.1/lib/pkgconfig:$PKG_CONFIG_PATH (or wait, was it lib/pkg-config or PKGCONFIG_DIR? I always forget and dig stackoverflow), especially when trying to test one specific version, among many installed versions.

Then can it become CRYSTAL_OPENSSL_DIR? I can imagine conflicts with that name...

This just need to be merged without the macos-specific stuff and then use a wrapper script to fix the build environment in Homebrew. I don't see why homebrew wouldn't accept that.

Hey, sorry to dig-up such an old thread,
I've read the discussion and it looks like this got very close to being merged, I was wondering what was the status of this as of today (3 years later)
my goal being to try to push crystal on freebsd to a better state

Echoing @InfRandomness question above.
On FreeBSD, openssl is available both from the base system and from ports, and Crystal currently requires patching to use openssl from the base (https://github.com/crystal-lang/crystal/issues/7244).
It looks that HomeBrew issue was resolved by https://github.com/Homebrew/homebrew-core/pull/48028, which seemed to be the only objection to merging this PR.

I wouldn't mind polishing up this PR and merging it.
But overall, I'd rather like a more flexible, general approach for configuring lib bindings. There should be easy options to specify which libraries and versions to link to at compile time. This should technically work without having OpenSSL sources locally installed (or rather, despite), for example for cross-compiling workflows.
This problem is by far not a specific for libssl/libcrypto but applies to many other library bindings, hence I'd look for a more generic solution.

Honestly, I don't see any alternative, especially a generic one. There is #8336 but it only works for types and "constants", so we still need checking versions to know whether a function is available or not. It would help avoid the shell script, though, which does just that (preprocess the C headers to extract the version constants).

We can always improve #8336 or do something similar that checks whether a function is define. This can be done by creating a small C program and check if it compiles or not.

OpenSSL vs LibreSSL strikes again: the OpenBSD 7.6 base ships LibreSSL v4.0.0 but the pkg-config for libssl and libcrypto reports v2.0.0 which is breaking the openssl integration.
Trying to install the openssl pkg doesn't help because there are 3 versions that can be installed in parallel in non standard directories, and each with their own exotic pkg-config name :sob:


Error during downloading pre-trained models

I've trying to download pre-trained models.
However, all link seem to be blocked.
Please check that if links are available properly.
Thanks.

I've met this problem, too. :(

Hi, the file server that hosts the pre-trained weights are down. We are working on the fix. Sorry for the waiting.

The links are fixed now. Let me know if there is any problem. Thanks!


Add option to download text as markdown

Could be proofreading texts or published texts.
Desiderata -

should include proofreader notes as footnotes

Right now there are three download cases on my roadmap:

TEI XML (as the document of record that generates everything else)
plain text (for parsing, general ease of use, etc.)
PDF (for pleasant reading)

For Markdown, I have some questions:

How do you read a Markdown text today? What programs, etc.
What would a markdown download would give you that plain text and PDF would not?
Do you know others who would prefer to read texts through markdown?

For Markdown, I have some questions:
* How do you read a Markdown text today? What programs, etc.

With intellij idea (if not a plain text editor).
Hugo static website generator

* What would a markdown download would give you that plain text and PDF would not?

Sections, for one.
Better conservation of important formatting (bold, italics, footnotes etc..)

A better question might be - "What would plain text download give you that a markdown doesn't?"

* Do you know others who would prefer to read texts through markdown?

Basically everyone who cares to read LARGE texts as a plain text files, everyone who uses static website generation. I recall that @shreevatsa and @drdhaval2785 have used markdown.

So far, the most convenient way to produce markdown from TEI I've found : https://github.com/sanskrit-coders/doc_curation/blob/master/doc_curation/tei.py . (So, here it's mostly code reuse with minor modifications.)

Sections, for one.
Better conservation of important formatting (bold, italics, footnotes etc..)

Why are PDFs inadequate here?

A better question might be - "What would plain text download give you that a markdown doesn't?"

More useful for NLP applications and text mining. But that's about all that comes to mind.

So far, the most convenient way to produce markdown from TEI I've found

Wonderful! My main concern was that we'd have to maintain the TEI -> XML logic indefinitely going forward. If there's an out-of-the-box solution that someone else will maintain, I think there's no reason not to add it.

Sections, for one.
Better conservation of important formatting (bold, italics, footnotes etc..)

Why are PDFs inadequate here?

Flowing text on various screens.
Modifiability
Search and copy-paste (can be assuaged to some extant by being very careful in pdf generation).
Smallest possible file size.
Ability to plug into a variety of other tools, including converters

So far, the most convenient way to produce markdown from TEI I've found

Wonderful! My main concern was that we'd have to maintain the TEI -> XML logic indefinitely going forward. If there's an out-of-the-box solution that someone else will maintain, I think there's no reason not to add it.

You mean TEI -> MD? I keep some custom variants of the main TEI stylesheets as well (eg. sarit here ). Maintenance might therefore not be a big issue.

You mean TEI -> MD?

Yes, my mistake.


Update README for general users

Right now, the README is focused on new developers and using the Python interface.  Add a section for folks who may just want to use the .sqlite file.
Also, schema figure is currently broken.

Made a README for the org. https://github.com/SIMPLE-AstroDB
which is stored : https://github.com/SIMPLE-AstroDB/.github/tree/main/profile

add bit about astrodb_scripts (astrodb_utils) package for ingesting.
maybe add  something about tests?


GVFS Sparse prune after expected failure is successful but folders still present

I was testing what happened if I pruned a folder that was in use, and I saw this behavior:

Try to prune folder I'm in, fails as expected.
cd out of it
Try to prune same folder, succeeds but folders are still present on machine
Try to prune again, folders go away

I have a fairly stable repro right now if anyone wants me to demonstrate. I have added my diagnose at \scratch2\scratch\judemars\gvfs_20191107_173346.zip
D:\mono\src\engtools>gvfs sparse --set otools --prune
Running git status...Succeeded
Updating sparse folder set...Succeeded
Forcing a projection change...Succeeded
Finding folders to prune...Succeeded
Found 1 folders to prune.
Running git status before prune to make sure you don't have any pending changes.

Running git status...Succeeded

WARNING: If you abort the sparse after this point, the repo may become corrupt

Unmounting...Succeeded
Cleaning up folders...-Cannot prune folder 'engtools': removing 'engtools' failed.
Ensure no applications are accessing the folder and retry.
More details: The process cannot access the file 'D:\mono\src\engtools' because it is being used by another process.
Cleaning up folders...Succeeded
Mounting...Succeeded
engtools The process cannot access the file 'D:\mono\src\engtools' because it is being used by another process.
Failed to dehydrate 1 folder(s).
Failed to prune. Exit Code: DehydrateFolderFailures

D:\mono\src\engtools>cd ..
D:\mono\src>dir
Volume in drive D is Data
Volume Serial Number is B88B-F529

Directory of D:\mono\src

11/07/2019  05:26 PM    <DIR>          .
11/07/2019  05:26 PM    <DIR>          ..
<other files>
11/07/2019  05:24 PM    <DIR>          collateral
11/07/2019  05:24 PM    <DIR>          engtools
<other files>
11/04/2019  12:32 PM    <DIR>          otools
<other files>
11/07/2019  05:24 PM    <DIR>          warehouse
              7 File(s)         15,164 bytes
              6 Dir(s)  1,459,043,827,712 bytes free

\\ First of all, strange that only engtools failed but collateral and warehouse are still present
D:\mono\src>gvfs sparse --set otools --prune
Running git status...Succeeded
Updating sparse folder set...Succeeded
Forcing a projection change...Succeeded
Finding folders to prune...Succeeded
Found 1 folders to prune.
Running git status before prune to make sure you don't have any pending changes.

Running git status...Succeeded

WARNING: If you abort the sparse after this point, the repo may become corrupt

Unmounting...Succeeded
Cleaning up folders...Succeeded
Mounting...Succeeded
engtools folder prune successful.

D:\mono\src>dir
Volume in drive D is Data
Volume Serial Number is B88B-F529

Directory of D:\mono\src

11/07/2019  05:26 PM    <DIR>          .
11/07/2019  05:26 PM    <DIR>          ..
<other files>
11/07/2019  05:24 PM    <DIR>          collateral
11/07/2019  05:24 PM    <DIR>          engtools
<other files>
11/04/2019  12:32 PM    <DIR>          otools
<other files>
11/07/2019  05:24 PM    <DIR>          warehouse
              7 File(s)         15,164 bytes
              6 Dir(s)  1,459,043,827,712 bytes free

\\ This is the bug, only the otools directory should be present here
\\ However, rerunning gvfs sparse fixes the issue:
D:\mono\src>gvfs sparse --set otools --prune
Running git status...Succeeded
Updating sparse folder set...Succeeded
Forcing a projection change...Succeeded
Finding folders to prune...Succeeded
Found 0 folders to prune.

D:\mono\src>dir
 Volume in drive D is Data
 Volume Serial Number is B88B-F529

 Directory of D:\mono\src

11/07/2019  05:28 PM    <DIR>          .
11/07/2019  05:28 PM    <DIR>          ..
<other files>
11/04/2019  12:32 PM    <DIR>          otools
11/07/2019  05:24 PM             6,725 tagger_config.json

@judemars I'm unable to repro this issue with my changes in #1605
I will assign this issue over to you, could you re-test this scenario on your machine once a new release with #1605 is ready?

Sadly, this does still repro for me on the new version of gvfs. Please note that engtools is a folder with multiple subfolders in the original sparse list within it - I think that may be causing the problem?

WARNING: If you abort the sparse after this point, the repo may become corrupt

Unmounting...Succeeded
Cleaning up folders...-Cannot prune folder 'engtools': removing 'engtools' failed.
Ensure no applications are accessing the folder and retry.
More details: The process cannot access the file 'D:\mono\src\engtools' because it is being used by another process.
Cleaning up folders...Succeeded
Mounting...Succeeded
engtools The process cannot access the file 'D:\mono\src\engtools' because it is being used by another process.
Failed to dehydrate 1 folder(s).
Failed to prune. Exit Code: DehydrateFolderFailures

D:\mono\src\engtools>cd ..
(Note this is a departure from before - here there were some folders present other than what got succesfully dehydrated)
D:\mono\src>dir
 Volume in drive D is Data
 Volume Serial Number is B88B-F529

 Directory of D:\mono\src

12/09/2019  09:28 PM    <DIR>          .
12/09/2019  09:28 PM    <DIR>          ..
12/09/2019  09:27 PM    <DIR>          engtools
11/15/2019  03:32 PM    <DIR>          otools
               7 File(s)         15,164 bytes
               4 Dir(s)  1,395,597,185,024 bytes free

D:\mono\src>gvfs sparse --set otools --prune
Running git status...Succeeded
Updating sparse folder set...Succeeded
No folders to update in sparse set.
Finding folders to prune...Succeeded
Found 1 folders to prune.

WARNING: If you abort the sparse after this point, the repo may become corrupt

Unmounting...Succeeded
Cleaning up folders...Succeeded
Mounting...Succeeded
engtools folder prune successful.

D:\mono\src>dir
 Volume in drive D is Data
 Volume Serial Number is B88B-F529

 Directory of D:\mono\src

12/09/2019  09:29 PM    <DIR>          .
12/09/2019  09:29 PM    <DIR>          ..
11/15/2019  03:32 PM    <DIR>          otools
12/09/2019  08:39 PM             6,725 tagger_config.json
               7 File(s)         15,164 bytes
               3 Dir(s)  1,395,596,947,456 bytes free

D:\mono\src>gvfs --version
GVFS 0.3.19330.1

@judemars to confirm, it looks like the unexpected behavior is seeing a bunch of the folders after running gvfs sparse --set otools --prune again from inside src?  Does that sound right to you?

Yes! After the second gvfs sparse --set otools --prune call, which says it was successful, there should only be the otools directory present in src. After the third call, this seems to be the case.

This turned out to be a problem on my end - the reset that is called during gvfs sparse was triggering the git hook we are using to update the sparse list to be a different set than otools. Will fix on our end. Thanks for the debugging help William!


Legend Selected state with refresh at 5s

in echarts is it possible to keep legend selected state through refreshes set to 5s interval? where to store it and how to retrieve it?

@sscott044 One of the options is to use Dashboard Variables: https://volkovlabs.io/plugins/volkovlabs-echarts-panel/variables/. There are more examples in the documentation.
Another option is to use local Storage in the browser, which will persist and will be unique for each user. We use it in panels, but I have not tried it from the ECharts JS Code editor.

Thanks,
BTW, Really enjoy using this plugin!

@sscott044 Great to hear! Let us know if there is anything else.


Licence file

Thank you for a great library.
I see in the package.json file you say the licence is BSD but you don't have a licence file in the repository.
Thanks!

+1

Upon your request https://github.com/dankogai/js-combinatorics/commit/036a57ce1e4ff75aaafbefbaf7020b310f25c4dc

Great! But is it dual licensed BSD and MIT? The package.json file says BSD?

Fixed package.json so it is MIT license https://github.com/dankogai/js-combinatorics/commit/31069badb1c916a10e96f5f75b091d32a769ea05
MIT is my license of choice and I usually start the project with it so I have been thinking this has been under MIT...


Can't pull the text generation inference docker image

System Info
I run the command
docker pull ghcr.io/huggingface/text-generation-inference:sha256-xxxxxxxxxxxxxxxxxxxxx467d7cf721f015b0987c956837f0e4f33e7b2.sig
and the output is
Error response from daemon: Get https://ghcr.io/v2/: read tcp <IP_ADDRESS>:33012-><IP_ADDRESS>:443: read: connection reset by peer
is it my client side error?
I am sshing into a local dgx machine
ssh -L 8888:localhost:8888<EMAIL_ADDRESS>Information

[X] Docker
[X] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
run the command
docker pull ghcr.io/huggingface/text-generation-inference:sha256-xxxxxxxxxxxxxxxxxxxxx467d7cf721f015b0987c956837f0e4f33e7b2.sig
Any fixes or checks I might have to run to fix this?
Expected behavior
download the image and then be able to run docker run --gpus all --shm-size 1g -p 8080:80 -v $volume:/data ghcr.io/huggingface/text-generation-inference:0.9 --model-id $model --num-shard $num_shard

.sig files in the docker registry are Cosign signatures. You need to pull ghcr.io/huggingface/text-generation-inference:sha-5a1512c.


Create 0000-01-02-IreneCoded.md

layout: slide
title: "Welcome to our second slide!"
Your text
Use the left arrow to go back

IreneCoded's file


Support Wren Language

Hello, this seems like a nice project.
I am interested in using Wren as a scripting language.
This language is successfully used in other projects such as
https://tic.computer/
https://domeengine.com/
and https://luxeengine.com/
I'm willing to do a PR with a plugin, but I would need some guidance on where to look for integration :)
Thanks 👍

cool. I'll be helping you in case you need any help.
design document is on the way, along with a game sample

Ok, that would be awesome.
I'll wait a little so I have a clearer picture on how to make a plugin 👍
thanks.

http://glitterbombg.com/devblog/posts/rizz-basics/#plugins

http://glitterbombg.com/devblog/posts/rizz-basics/#plugins

Should be http://glitterbombg.com/blog/posts/rizz-basics/#plugins right?

yes. I changed the urls a while back. thank you


Setup User & User Verification Database

User DB Schema is setup and is able to store signup info.


Collapsing message

In Private messages, whenever a user collapses any message, Following events takes place:

Clicking back on [More..] doesn't uncollapses the message(unless reloaded).
In Message controls, collapse button doesn't get updated to Un-collapse(unless reloaded).
A user have to click the floor of [More..] to get message uncollapsed.

These problems are specific to Starred messages, @-mentions and private messages(works fine in Home)

The code for managing collapsed messages is I think in static/js/message_list_view.js if anyone wants to take a crack at debugging this; it sounds like the reproduction recipe is pretty simple here...

@timabbott I am working on this.
On Sun, Mar 13, 2016 at 5:58 AM, Tim Abbott<EMAIL_ADDRESS>wrote:

The code for managing collapsed messages is I think in
static/js/message_list_view.js if anyone wants to take a crack at
debugging this; it sounds like the reproduction recipe is pretty simple
here...
—
Reply to this email directly or view it on GitHub
https://github.com/zulip/zulip/issues/516#issuecomment-195838822.


post_install = xx like s3:// path format not work in config file

Hi all,
I've tried to add below learnt from example mentioned in README-WRF.rst
post_install = s3://bucket-id1-cfncluster/cfncluster_postinstall.sh
But cfncluster fail to be create, reported
Error occurred during build: Command runpostinstall failed
+ error_exit 'Failed to run cfn-init. If --norollback was specified, check /var/log/cfn-init.log and /var/log/cloud-init-output.log.'
+ cfn-signal --exit-code=1 '--reason=Failed to run cfn-init. If --norollback was specified, check /var/log/cfn-init.log and /var/log/cloud-init-output.log.' --stack=cfncluster-hpc-cluster --resource=MasterServer --region=us-west-2
+ exit 1

After change the script path from s3:// format to S3 endpoint like http://s3endpoint/backet/filename.sh , it works.
Please double check and change README-WRF.rst accordingly.
Thanks.

It works okay for me with:
+cfn_postinstall=s3://esipfed/roms/cfncluster_postinstall.sh

I just had to make sure it was public read.