'React/RCTBridgeDelegate.h' file not found

Description
So i've been trying to run my iOS react native application but it keeps on showing this error.
Steps i've tried

pod install in ios folder but it shows following message

Analyzing dependencies
Downloading dependencies
Generating Pods project
Integrating client project
Pod installation complete! There are 0 dependencies from the Podfile and 0 total pods installed.
[!] The Podfile does not contain any dependencies.

Also ' react ' is missing in schemes

Version
0.70.6
Output of npx react-native info
System:
OS: macOS 12.6
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 24.21 GB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.7.0 - /usr/local/bin/node
Yarn: Not Found
npm: 8.15.0 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
Languages:
Java: 15.0.9 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: ^0.70.6 => 0.70.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Trying to run iOS react native project.
Snack, code example, screenshot, or link to a repository
can't share the code

Hi @Jyotiraditya008, to help you, we need more information. First of all, you should try to create a repro with minimal code to highlight the issue. I understand you can't share your code, but you can try to create a new app and add similar code pieces to reveal the problem.
Thank you so much.

Hi @Jyotiraditya008, to help you, we need more information. First of all, you should try to create a repro with minimal code to highlight the issue. I understand you can't share your code, but you can try to create a new app and add similar code pieces to reveal the problem.
Thank you so much.

i tried creating a new app and then install pods in that... But then also the same issue occured that said
"   Pod installation complete! There are 0 dependencies from the Podfile and 0 total pods installed.
[!] The Podfile does not contain any dependencies.    "
I'm stuck since last 2 weeks

Can you share your podfile, please?

Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'CampusDEMO' do
Comment the next line if you don't want to use dynamic frameworks
use_frameworks!
pod 'React', :path => '../node_modules/react-native', :subspecs => [
#'Core',
'CxxBridge',
'DevSupport',
'RCTText',
'RCTNetwork',
'RCTWebSocket',
'RCTAnimation',
'RCTActionSheet',
'RCTGeolocation',
'RCTImage',
'RCTLinkingIOS',
'RCTSettings',
'RCTText',
'RCTVibration',
'RCTBlob',
'RCTCameraRoll',
'RCTFileSystem',
'RCTNetwork',
'RCTWebSocket',
'RCTAsyncStorage',
]

Pods for CampusDEMO
target 'CampusDEMOTests' do
inherit! :search_paths
# Pods for testing
end
end
Here

Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'CampusDEMO' do
Comment the next line if you don't want to use dynamic frameworks
use_frameworks!
pod 'React', :path => '../node_modules/react-native', :subspecs => [
#'Core',
'CxxBridge',
'DevSupport',
'RCTText',
'RCTNetwork',
'RCTWebSocket',
'RCTAnimation',
'RCTActionSheet',
'RCTGeolocation',
'RCTImage',
'RCTLinkingIOS',
'RCTSettings',
'RCTText',
'RCTVibration',
'RCTBlob',
'RCTCameraRoll',
'RCTFileSystem',
'RCTNetwork',
'RCTWebSocket',
'RCTAsyncStorage',
]

Pods for CampusDEMO
target 'CampusDEMOTests' do
inherit! :search_paths
# Pods for testing
end
end

Can you share your podfile, please?

The Podfile should look more like this.
I strongly suggest you to use the use_react_native! function (as shown here) that takes care of installing the dependency properly.

@cipolleschi those links now 404. Anywhere else I can find what your were linking to?

The link got broken after the Monorepo refactoring landed. I just updated them!

Same problem here
react native 0.72
config podfile
Resolve react_native_pods.rb with node to allow for hoisting
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
require Pod::Executable.execute_command('node', ['-p',
'require.resolve(
"react-native/scripts/react_native_pods.rb",
{paths: [process.argv[1]]},
)', dir]).strip
platform :ios, '14.2' ##min_ios_version_supported
prepare_react_native_project!
use_frameworks! :linkage => :static
linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
use_frameworks! :linkage => linkage.to_sym
end
target 'mobile' do
config = use_native_modules!
pod 'React-Codegen', :path => 'build/generated/ios'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
pod 'React-RCTAppDelegate', :path => '../node_modules/react-native/Libraries/AppDelegate'
pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
pod 'React-Core', :path => '../node_modules/react-native/'
#APP DETAILS
pod 'OneSignalXCFramework', '3.12.9'
pod 'GoogleUtilities', :modular_headers => true
pod 'FirebaseCore', :modular_headers => true
pod 'Firebase'
$RNFirebaseAnalyticsWithoutAdIdSupport = true
pod 'RNIap', :path => '../node_modules/react-native-iap'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'RNImageCropPicker', :path => '../node_modules/react-native-image-crop-picker'
pod 'RNCMaskedView', :path => '../node_modules/@react-native-community/masked-view'
pod 'FBSDKLoginKit', '~> 9.3'
pod 'lottie-react-native', :path => '../node_modules/lottie-react-native'
pod 'FirebaseAnalytics'
pod 'RNReanimated', :path => '../node_modules/react-native-reanimated'
Flags change depending on the env values.
flags = get_default_flags()
use_react_native!(
:path => config[:reactNativePath],
# Hermes is now enabled by default. Disable by setting this flag to false.
:hermes_enabled => flags[:hermes_enabled],
:fabric_enabled => flags[:fabric_enabled],
# Enables Flipper.
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable the next line.
#:flipper_configuration => flipper_config,
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
target 'mobileTests' do
inherit! :complete
# Pods for testing
end
post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
installer.pods_project.build_configurations.each do |config|
config.build_settings["EXCLUDED_ARCHS[sdk=iphonesimulator*]"] = "arm64"
end
react_native_post_install(
installer,
config[:reactNativePath],
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end
target 'OneSignalNotificationService' do
pod 'OneSignal', '>= 3.0.0'
end

@Feeeliperesende
Do you have the same issue with 0.74?
On top of that, the Podfile is a bit messy.

Remove all the React- pods. React native install them for you
For lottie, reanimated, firebase and all the react-native specific libraries, you should add them to the project using yarn add <name-of-the-library>, otherwise you risk to miss some automation
move all the pod statements after the use_react_native( function. We run some code in that function and if you add some libraries BEFORE calling that function, some variables are not visible to them.

Let me know if the situation improves. Otherwise, please setup a reproducer using this template and I'll have a look at it!


requests.exceptions.ReadTimeout is not raised when response is chunked

https://gist.github.com/nickjoyce-wf/c536f2573ef124115f86
When a request has a timeout param supplied and the response is chunked but does not return enough data in time, requests.exceptions.ReadTimeout should be raised.
$ mkvirtualenv test
(test)$ pip install requests werkzeug
(test)$ python server.py

In another terminal:
$ workon test
(test)$ python client.py

Expected results:
requests.exceptions.ReadTimeout is raised due to response not being sent within the timeout specified by requests.get.
Actual results:
Traceback (most recent call last):
  File "client.py", line 3, in <module>
    requests.get('http://<IP_ADDRESS>:8000/', timeout=0.5)
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/api.py", line 65, in get
    return request('get', url, **kwargs)
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/api.py", line 49, in request
    response = session.request(method=method, url=url, **kwargs)
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/sessions.py", line 461, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/sessions.py", line 610, in send
    r.content
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/models.py", line 730, in content
    self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
  File "/Users/nick/.virtualenvs/test/lib/python2.7/site-packages/requests/models.py", line 662, in generate
    raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8000): Read timed out.

Recorded http request/response via Wireshark:
GET / HTTP/1.1
Host: <IP_ADDRESS>:8000
Connection: keep-alive
Accept-Encoding: gzip, deflate
Accept: */*
User-Agent: python-requests/2.5.1 CPython/2.7.9 Darwin/13.4.0

HTTP/1.0 200 OK
Content-type: text/plain
Transfer-Encoding: chunked
Connection: close
Server: Werkzeug/0.9.6 Python/2.7.9
Date: Fri, 26 Dec 2014 17:51:21 GMT

Tested with requests==2.5.1

Log:
Traceback (most recent call last):
File "/home/provakil/repo/backend/case_status_consumer.py", line 69, in
channel.start_consuming()
File "/usr/local/lib/python2.7/dist-packages/pika/adapters/blocking_connection.py", line 955, in start_consuming
self.connection.process_data_events()
File "/usr/local/lib/python2.7/dist-packages/pika/adapters/blocking_connection.py", line 240, in process_data_events
if self._handle_read():
File "/usr/local/lib/python2.7/dist-packages/pika/adapters/blocking_connection.py", line 348, in _handle_read
super(BlockingConnection, self)._handle_read()
File "/usr/local/lib/python2.7/dist-packages/pika/adapters/base_connection.py", line 351, in _handle_read
self._on_data_available(data)
File "/usr/local/lib/python2.7/dist-packages/pika/connection.py", line 1285, in _on_data_available
self._process_frame(frame_value)
File "/usr/local/lib/python2.7/dist-packages/pika/connection.py", line 1365, in _process_frame
self._deliver_frame_to_channel(frame_value)
File "/usr/local/lib/python2.7/dist-packages/pika/connection.py", line 976, in _deliver_frame_to_channel
return self._channels[value.channel_number]._handle_content_frame(value)
File "/usr/local/lib/python2.7/dist-packages/pika/channel.py", line 792, in _handle_content_frame
self._on_deliver(*response)
File "/usr/local/lib/python2.7/dist-packages/pika/channel.py", line 886, in _on_deliver
body)
File "/home/provakil/repo/backend/case_status_consumer.py", line 15, in consume_case_status
case_num['case_id'], case_num['case_year'], s)
File "/home/provakil/repo/backend/src/fetcher/case_status.py", line 147, in get
case_page = fetch_case_page(case_type, case_id, year, session)
File "/home/provakil/repo/backend/src/fetcher/case_status.py", line 32, in fetch_case_page
content = r.text
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 777, in text
if not self.content:
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 750, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 680, in generate
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='courtnic.nic.in', port=80): Read timed out.

Yes, if you set stream=True. Otherwise, no.
In future, it's better if you can ask these questions on Stack Overflow: this issue tracker is really meant for bugs only. =)


Identity based auth for Doc Intelligence and Azure OpenAI Services

I noticed that this implementation uses key based authentication for Doc Intelligence and Azure OpenAI Services.
Can we get examples with identity based auth?

Hey Sam, I've been away a lot recently and have this on my list of upcoming features in the new year. Identity-based auth + private networking options are at the top of the list - I am hopeful to have these options some time in January. Thanks for letting me know that this is important to you - it helps in the prioritization of new features.


Prefix tag names with v

To play nice with go modules you need to prefix the version tags with v, e.g. v0.2.0, otherwise you have to pin to commits.
If interested, see https://github.com/golang/go/issues/32945 for all the historical discussion.

added v-tags


FluidKrToBuf: base on size of kr stream?

I'd like to write a SynthDef collecting features of an audio stream in a buffer:
SynthDef(\rtAnalysis, {|out = 0, buf = 0, featureBuf = 1|
	var sig, mfccs, isPlaying;

	sig = PlayBuf.ar(1, buf, doneAction: 2);

	mfccs = FluidMFCC.kr(
		sig, q.numFccCoefs,
		startCoeff: 1,
		maxNumCoeffs: q.numFccCoefs
	);

	FluidKrToBuf.kr(mfccs, featureBuf);

	sig!2

}).add;

my (naive) approach was to provide a buffer number here but soon i found out that a Buffer object is required:
https://github.com/flucoma/flucoma-sc/blob/e5c75cf3bb636a41a4b69fef03d34ba88833b6b2/release-packaging/Classes/FluidBufToKr.sc#L6
this implementation leads to
^^ ERROR: Message 'numFrames' not understood.
RECEIVER: an OutputProxy

I'd propose to base the iteration in FluidKrToBuf on the dimensionality of the kr signal instead:
FluidKrToBuf {
	*kr {
		arg krStream, buffer;
		^krStream.collect{
			arg sig, i;
			BufWr.kr(sig, buffer, i);
		}
	}
}

A definition for FluidBufToKr is a little more involved but I could imagine that providing (optional) numFrame and startFrame arguments  would increase usability:
FluidBufToKr {
	*kr {
		arg buffer, numFrames, startFrame=0;

		if(buffer.isKindOf(Buffer), {
			numFrames = numFrames ?? {buffer.numFrames - startFrame};
		}, {
			numFrames = numFrames ? 1;
		});

		if(numFrames > 1,{
			^numFrames.collect{
				arg i;
				BufRd.kr(1,buffer,i,0,0);
			}
		},{
			^BufRd.kr(1,buffer,0,0,0);
		});
	}
}

After implementing this, I realised you already fixed this in the dev branch:
https://github.com/flucoma/flucoma-sc/blob/4e91cc363ef1f91a1a91aeb881000068aeafee4f/release-packaging/Classes/FluidBufToKr.sc#L19-L29
However, I could imagine that my startFrame argument might be a good addition ;)
Also, I'd recommend initialising numFrames with nil instead of -1.
Good work, anyhow!

I added a PR, feel free to include it :)

Thanks @LFSaw ! Yes, this is coming. I like your startFrame suggestion. I'll take a look at adding it to the dev branch code that exists!
Many of the FluCoMa objects use a numFrames default of -1 to indicate to use the rest of the buffer so here we're using -1 to be consistent across the toolkit.
Thank you!
Ted


[RFC] Process separation of backend plugins

Heads up that this RFC is a bit out there and is definitely a bad idea if not executed well. I mainly just wanted a space where we can discuss this kind of architecture :grin:
Need
There's a lot of discussion going around where to go with backend plugins, both in the community and among the maintainers. This is a bit of a mini RFC that outlines a high-level idea for what backend plugins could look like in the future.
The proposal covers a couple of different needs, so I'll summarize them briefly. First is the need for isolated deployment of backend plugins. Currently this is done by creating multiple backend packages with separate sets of plugins, but it's a bit clunky and could likely be done in better ways since backend plugins are well isolated anyway.
The second need is isolation between plugins. Backend plugins are already not supposed to communicate with each other though code, but this doesn't mean they can't affect each other in other ways. I think any additional isolation we can add between backend plugins is good.
The third is support for worker threads, which can provide a way to scale processing in a way that is independent of the number of nodes a plugin backend is deployed across.
Lastly I think we can improve the local development setup of backend plugins. The current webpack method end up being pretty far off how they execute in production, and the hot loading is a bit flaky and doesn't always behave as expected.
Proposal
Each backend plugin is a standalone Node.js module entrypoint and process. It would likely be possible to run a plugin by itself using e.g. node ./dist/plugins/catalog.js, but in practice this is likely executed as part of the backend framework. When running the backend you might be able to select which plugins you want to include, for example node ./dist --plugins=catalog,scaffolder, although this might also be handled by separate entrypoint modules for the backend itself.
Since the processes would be heterogenous we couldn't really use the cluster module to implement this, but we'd probably still use a primary process that would be responsible for routing requests to the different plugins that are installed.
For local development each of the plugin modules would have their own lifecycle, and you may even have a CLI similar to jest where you're able to restart and start/stop individual plugins.
Alternatives
I think this would be one of the only sane ways to support worker threads for backend plugins, but to be honest we don't really need them either.
For splitting of backends we can use separate entrypoints, but of the backend itself rather than the plugins.
Risks
This is a minefield and I mainly wanted to document this idea for further discussion and keep a record of why we wouldn't do this. It adds a ton of complexity and magic, it may require custom built tooling support and complete refactoring of existing backends. The idea of process separation comes with the need for handling a lot of additional multiplexing of requests, metrics, logging, etc.
A big downside of only separating by process when it comes to splitting the backend is that all backend instances will have all dependencies installed since it's all the same package. They won't be loaded at runtime, but they'll still be there on the filesystem and have postinstall scripts run, etc.

As part of #11611 we evaluated this and decided against this approach. The chosen alternative is to instead make backends very lightweight, and for it to be possible to have shared environment definitions, discussed further in #13088


Rename registryDisk to containerDisk

Today we have a volume source called registryDisk.

The term itself implies that there is a disk registry, which is technically right, but might be misleading.
The API could lead to the impression that the whole container is used as the disk source for the VM. but in reality it is a file within the container which is used as a disk image.

These two points are worth to resolve, in order to not block us to actually eveolve other stories around registries and containers in the future (i.e. meaning of a real container in the vm spec, or other registries).
An alternative API could be along the lines of:
kind: VM
spec:
  …
  volumes:
  - name: wooooah
    containerDisk:
      image: quay.io/bob/ubuntu:latest
      path: /disk.img

I could actuall yimagine that path defaults to a certain path, or that a glob is used by default. (i.e. first file in / or so).

To me this kind of API cleanup would be something for 1.0

/cc @davidvossel

For me it is equally clear/unclear if the container is the disk or if we have a disk inside the container, no matter if we call it registryDisk or containerDisk. Also imageDisk would be an option to align it with the image term on pods.
But whatever is clearer for the majority works for me.

I like containerDisk but I wonder if diskPath would be better than just path.

imageDisk is rather intuitive to me, but I wouldn't complain about containerDisk either.  I have to poke around a bit WRT the suggestion from @aglitke on using diskPath, seems like we naturally used that for some local variables so maybe that was the natural choice to begin with?

I'm good with something that looks like this.
kind: VM
spec:
  …
  volumes:
  - name: wooooah
    containerDisk:
      image: quay.io/bob/ubuntu:latest
      path: /disk.img

Calling it "containerDisk" implies it's a disk that lives in a container. The "image" variable in the containerDisk spec indicates the container image to use which has the disk. All of that seems to mesh well with me.
So, just from that spec I can derive two things without prior knowledge of what a containerDisk is.. 1. This volume has something to do with containers, and 2. I can specify what container image to use. That's the general idea

xref https://github.com/kubevirt/kubevirt/issues/1576

The pull requests are now https://github.com/kubevirt/kubevirt/pull/1730 and https://github.com/kubevirt/user-guide/pull/155


update pd (pure-data) to version 0.48-0

After making all changes to the cask:

[x] brew cask audit --download pd is error-free.
[x] brew cask style --fix pd reports no offenses.
[x] The commit message includes the cask’s name and version.

The -64bit suffix was removed in version 48 (see list of software: http://msp.ucsd.edu/Software/)

Thank you for your contribution!


Improve performance of creating a LeJsonV4Writer

Bindings are computed every time a LeJsonV4Writer is created.

Rough time to create a writer:
Smalltalk garbageCollect.
[ 1000 timesRepeat: [
	LeJsonV4 uniqueInstance newWriter ] ] timeToRun.
"0:00:00:13.735"

Modify LeJsonV4Writer to properly reset when copied and then just copy an existing instance:
Smalltalk garbageCollect.
[ 1000000 timesRepeat: [
	LeJsonV4 uniqueInstance newWriter ] ] timeToRun.
"0:00:00:00.03"

(Note that the number of loops has increased by 1000x)


Admin - Setting up CSS

Adding Materialize to the repo + settings for it.
_variables.scss is copied from Materialize and placed under version control since it'll be changed later unlike the rest of Materialize.

All ok =D


[ERA-9327] Swahili i18n

What does this PR do?

Adds Swahili language support to the Earthranger web client

How does it look

N/A

Relevant link(s)

https://allenai.atlassian.net/browse/ERA-9327
Env building

Any thoughts on why the first part of this doesn't get translated? :( (About 1 ...)

@AlanCalvillo yes, our "human readable date string" utility function's dependencies don't appear to support i18n in the way we'd expect. It's an issue with the current codebase as well, i'd recommend filing it as a bug ticket but not blocking i18n work


ResultStream produces max_requests+1 requests

search_args = load_credentials()
rule = gen_rule_payload("rule", results_per_call=100)
rs = ResultStream(rule_payload=rule,
                  max_requests=1,
                  **search_args)
tweets = list(rs.stream())

This ResultStream produces 2 requests (and len(tweets) will be 200).

https://github.com/twitterdev/search-tweets-python/blob/c1453961e0f9ad3942098b9d4952f9019e3ecc3e/searchtweets/result_stream.py#L217
Maybe, this line's self.n_requests <= self.max_requests should be self.n_requests < self.max_requests

Thanks for reporting, @kxbmap.

--max-pages number is now honored.


Optional feed for cut (closes #213)

Contributor checklist

[x] I have read the CONTRIBUTING.rst
[ ] I have tested my contribution on these devices:

e.g. Epson TM-T88II

[x] My contribution is ready to be merged as is

Description
Optional feed. Fixes #213.

Before I merge this, I would be interested, why the code here differs from the code that I proposed in the corresponding issue. If you know it you can explain it to me, otherwise I will just read the spec on cutting and feed as soon as I get around to it.

I did this patch expecting that not calling print_and_feedshould be enough but it was not the case. I have added a test so I can now guarantee that we have the correct output that you mentioned in your issue.
Since I do not have a printer that support cut I cannot test this, but the binary output is now tested so it should be ok.

Thank you! :-)


Webhooks are called one after the other

Currently, webhooks are called synchronously. This is because we process webhook messages from RabbitMQ one by one through a single channel (a RabbitMQ channel is synchronous by nature).
Potential solutions are:

consume multiple messages at the same time and acknowledge them when associated webhook is successfully called (this might imply switching to the "promise" paradigme);
communicate with RabbitMQ through multiple channels in parallel ;
start multiple instances of the webhook worker (pm2 might be helpful here).

Not a big issue for now, right?
You should check this out: https://nodejs.org/api/cluster.html

No, it's not a big deal for now. But it might become a problem if multiple votes are ran at the same time and one of those vote's remote server is unreachable. Each failed attempt to call an unreachable server will delay all subsequent messages from all votes by 30 seconds (or whatever value the TCP TTL is set to).
This makes me think that an other potential solution could be to shard webhook messages by vote: dedicate a queue and a worker for each active vote. I am not a big fan of this approach though as creating queues and spawning workers dynamically seems like a recipe for problems.

One queue per vote means we have to sync votes and their respective queue. Maybe we should... add a queue for that? Not a good idea indeed.
I'd rather have a cluster with a dozen forks.


Lambdatest integration

Description
This PR adds capability to run karma tests on LambdaTest platform

Motivation & Context

Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[ ] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues

@XhmikosR
Steps to run tests on LambdaTest

in the root folder do npm install and export below variables

export LT_USERNAME=username
export LT_ACCESS_KEY=accessKey
export LT_TUNNEL_NAME=tunnelName (Optional)

Run tests using command npm run js-test-ltcloud

I still can't edit your files :/ You should see a checkbox on the right here in the PR, please enable it:

hi @XhmikosR - i have added you as maintainer

Thanks but it shouldn't be needed... Out of curiosity, don't you see the checkbox here in the PR?

Nope. I don't see option in the PR.

@mukesh-lt could you please add @GeoSot to your repo too?

Done

@vipulkv thank you! We merged it in a branch in our repo so that we can test it and we'll let you know how it goes.

OK, it seems it fails with:
Error checkPath -----> Error: ENOENT: no such file or directory, access '/home/runner/work/bootstrap/bootstrap/.lambdatest/v3'

Then we got:
Downloading latest binary
Extracting binary
Starting tunnel
Tunnel successfully initiated. You can start testing now

But we see nothing on LambdaTest.

Then we got:
Downloading latest binary
Extracting binary
Starting tunnel
Tunnel successfully initiated. You can start testing now

But we see nothing on LambdaTest.

@XhmikosR there are two commands being running, this shows that first command worked and you should 1 active tunnel in LambdaTest account, within few seconds we should see the tests start running

@mukesh-lt thanks! It seems some tests are now failing due to timeout https://github.com/twbs/bootstrap/actions/runs/4543010434/jobs/8007150779

@mukesh-lt thanks! It seems some tests are now failing due to timeout https://github.com/twbs/bootstrap/actions/runs/4543010434/jobs/8007150779

@XhmikosR it seems all the mobile tests are failing, could you plz confirm you have the Mobile browser on Real Device in your subscription plan, if you do not wish to run tests on real device then you can comment them in browsers.js file

Thanks I sent an email and I'm waiting to hear back!

@XhmikosR We have enabled Web Automation on Real Devices for your subscription. Can you try running the test on Real Device now and let us know if you face any issues.

Hey @XhmikosR,
Can you please rerun the tests? It will help diagnose the issue.

The fourth time I restarted the job, tests passed. I'm going to restart CI again to see if it happens again.

Hey @XhmikosR,
We are looking into this.


Add support for multiple trackers

Current implementation miss support for multiple trackers.
Changes:

Changed concept of GoogleAnalyticsTracker; now contains track ID within instance
Moved static settings to separate class
Change how code is organized because of all this changes
Add support for tracker sampling rate
Add backwards compatibility class to keep all previous versions running
Create customDimensionsFieldsIndexMap to easy up customDimension implementation

I haven't changed methods signatures.
I've tested it locally but I would appreciate if others could also confirm that both, old and new implementations works. Tested on both Android and iOS.
I suggest that this default singleton export gets deprecated. It is more idiomatic that users create their own tracker instances.
Couldn't run example.
Let me know if I can do something more.

Hi @MrBr!
Wow, this is fantastic work. I've been thinking about supporting multiple trackers for some time now. I'm happy to see this PR!
I'm busy all day tomorrow, but I'll take some time this evening and this weekend to review and test this. Again, great work, thanks!

It is no problem, I have updated PR.

Great, thanks a lot! I will see about releasing this in a major version tomorrow or friday.


indexer-agent: Unable to sign the query response due to unavailable AllocationSigners

Figment and Protofire have both been reporting issues serving queries from the gateway, with indexer-service presenting an error similar to the following:
[2021-10-13 23:05:42.064 +0000] ERROR (IndexerService/1 on indexer-service-56b8447df8-wqg76): Failed to handle paid query
    indexer: "0xb06071394531B63b0bac78f27e12dc2BEaA913E4"
    operator: "0x7A361DB89c9419699DEf3349b5F6F1cBA294267D"
    component: "Server"
    err: {
      "type": "IndexerError",
      "message": "Failed to process paid query",
      "stack":
          IndexerError: Failed to process paid query
              at Object.indexerError (/opt/indexer/packages/indexer-common/dist/errors.js:139:12)
              at /opt/indexer/packages/indexer-service/dist/server/index.js:213:50
              at Generator.throw (<anonymous>)
              at rejected (/opt/indexer/packages/indexer-service/dist/server/index.js:6:65)
      "code": "IE032",
      "explanation": "https://github.com/graphprotocol/indexer/blob/master/docs/errors.md#ie032",
      "cause": {
        "type": "Error",
        "message": "Unable to sign the query response attestation",
        "stack":
            Error: Unable to sign the query response attestation
                at QueryProcessor.<anonymous> (/opt/indexer/packages/indexer-service/dist/queries.js:60:31)
                at Generator.next (<anonymous>)
                at fulfilled (/opt/indexer/packages/indexer-service/dist/queries.js:5:58)
        "status": 500
      }
    }

Kuba from Figment tracked this down, finding that queries are being received from the gateways that don't have a corresponding signer in the AllocationSigner map. Furthermore, these queries are for allocations that have already been closed.
The AllocationSigner map is maintained by periodically querying the network subgraph for active allocations, and instantiating NativeAllocationSigners for these allocations. The polling query is defined here: https://github.com/graphprotocol/indexer/blob/main/packages/indexer-service/src/allocations.ts#L25
Currently the query only filters allocations that are Active, so on a fresh start of indexer-service, it will not instantiate signers for allocations that have been recently closed, but that the gateway may still be sending requests to the indexer for. In normal operation (i.e. without an indexer-service restart), the AllocationSignerMap does not flush out signers that were instantiated for now-closed allocations, so even as the polling query runs and those allocations drop out of the result set, the signers are still available for queries that come in.
If this is indeed the issue, the fix may just be to widen the filter on the polling query, perhaps to include allocations If that's the case, then a potential fix might just be to widen the query scope to include recently closed allocations (maybe where closedAtEpoch >= currentEpoch - 1, assuming the gateway respects those bounds).
More complete information on the issue can be found in these diagnoses threads:
https://discord.com/channels/438038660412342282/898136504549904386/898137387656429579
https://discord.com/channels/438038660412342282/897959055488868373/897980447915663411

@jakubbujny I just amended my post, what I was describing happens in indexer-service, not indexer-agent. Apologies. Did you restart indexer-service at the same time?


Perform the whole worker lifecycle in the worker thread

There are two changes here, in two commits:

Move dependency injection into the container, rather than delegated to the dependency provider.

Remove the use of the spawning set during worker_setup, worker_result and worker_teardown, so these all happen in the same (worker) thread.

The motivation for this change is https://github.com/mattbennett/nameko-sentry/pull/7 (specifically the last commit). Running the worker lifecycle methods in the same thread means that thread-locals are shared, which Raven relies upon.
The downside is that the lifecycle of an individual worker may potentially be slower -- for example, if there is more than one dependency with an onerous and I/O bound setup or teardown, they will no longer be run in parallel.
On the other hand this change avoids spawning lots of probably useless threads, since most dependencies don't implement the worker lifecycle methods.
In practice I think the performance change will be negligible.

this seems fine. at some point we might want to use a sorted data structure to make the order more predictable, but let's leave that for another day

Awesome, thanks. +1 for making the order more predictable too.


Update openadr requirements.txt -- newer version of the Django library

This pull request is now managed with CodeReviewHub. Refresh.


HIVE-27093: Fix NPE in initialize() of Partition class

What changes were proposed in this pull request?
Check if the SD of a Partition exists to avoid NPE.
Why are the changes needed?
The Partition SD may lost in backend metadata database for some reasons. For these partitions with corrupted metadata, we can  not even drop them if the NPE exists.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No new tests.

@ayushtkn @veghlaci05 @zabetak Could you help review this PR? The failed tests seems not related to this PR, and I pass the tests in local with following commands:
mvn test -Dtest=org.apache.hadoop.hive.ql.schq.TestScheduledQueryService -pl :hive-exec
mvn test -Dtest=org.apache.hadoop.hive.cli.TestMiniTezCliDriver -Dqfile=tez_union_with_udf.q


Update cross-platform-targeting.md

I think it would better if we target the netstandard2.0 and net461 in this sample, this way it follows the point made earlier about consider adding a target for net461 when you're offering a netstandard2.0 target.

I looked at the change, and it's fine to me.  @JamesNK what do you think?


Upgrade to support Graphp API new version

Many changes are done to Facebook Graph API from the time of your last release 2017 Jul. 22.
I wonder when you intend to release a new version? If this will take a long time you can at least release new version for covering the breaking changes (https://developers.facebook.com/docs/graph-api/changelog/breaking-changes).

The current version of oauth2-facebook is designed for Facebook Graph API v2.10, which is end-of-life on Nov 5, 2019. Has anyone tried a newer version of Graph? What is the latest version that will work with oauth2-facebook?

i am starting to wonder if any of thePhpLeague-oauth2 code is even maintained anymore.  i was really hoping to use https://auth0.com instead, but i have yet to see a working PHP example.

after a bit of work (ok more than a bit) it appears that https://Auth0.com might be doing what thePHPLeague does, except its actively maintained with customer service support.


HHH-12012 UnsupportedOperationException thrown for Stateless session query

https://hibernate.atlassian.net/browse/HHH-12012

close this PR unless there is some feedback from the bug reporter.

A few days ago, I ran into the same issue while migrating our system from hibernate-core 5.1 to 5.4. However, correct me if I'm wrong, but this does not provide a resolution to the issue and upon execution of QueryImpl.scroll() (or QueryImpl.list() for that matter), an UnsupportedOperationException is thrown. There does not seem to be a way of explicitly setting neither cacheStoreMode nor cacheRetrieveMode to null, as setCacheMode calls in turn the respective CacheHelper methods.


Update supported versions

Exclude impossible combination of Ruby and Rails/Rack versions based on the travis doc.
https://docs.travis-ci.com/user/customizing-the-build#Build-Matrix

Coverage increased (+7.8%) to 98.649% when pulling 51ae7f7330d86ff584f1212611cf83cf3367ece0 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage increased (+7.8%) to 98.649% when pulling 51ae7f7330d86ff584f1212611cf83cf3367ece0 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 406d4ebb089cafe457eec3cf226e0ef10d1f4c38 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 406d4ebb089cafe457eec3cf226e0ef10d1f4c38 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 406d4ebb089cafe457eec3cf226e0ef10d1f4c38 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 406d4ebb089cafe457eec3cf226e0ef10d1f4c38 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling c56668c5edf6a9e4891c5f7a518e57d720811373 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 0bf35033e7ffdafd90249e2a07b9ffc02094d579 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.

Coverage remained the same at 90.868% when pulling 0bf35033e7ffdafd90249e2a07b9ffc02094d579 on update-supported-versions into 67e82dd2512dfeed3abf8ba45045b7b658357a67 on master.


Compile Issue with high_dim_filter.so On Nvidia TX1: modified_permutohedral.cc error: 'feature' was not declared in this scope

Hi. I ran into a modified_permutohedral.cc compile issue with Nvidia TX1 (Ubuntu 16). I am running Tensorflow 1.5 and Keras 2.2.2. I am compiling the gpu_version (USE_GPU := 1) with CUDA 8.

modified_permutohedral.cc:359:22: error: 'feature' was not declared in this scope
const float * f = (feature + k * num_dimensions);
^
modified_permutohedral.cc: In member function 'void ModifiedPermutohedral::sseCompute(tensorflow::Tensor&, const tensorflow::Tensor&, int, bool, bool) const':
modified_permutohedral.cc:622:51: error: 'seqCompute_cpu' was not declared in this scope
seqCompute_cpu( out, in, value_size, reverse, add);

(cv40py35) nvidia@tegra-ubuntu:~/cviz/crfasrnn_keras/src/cpp$ make
nvcc -std=c++11 -c -o cudacode.o high_dim_filter.cu -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/external/nsync/public -D_GLIBCXX_USE_CXX11_ABI=1  -x cu -Xcompiler -fPIC --expt-relaxed-constexpr -D FILTER_GPU=1
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(56): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(80): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(100): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(192): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(216): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(236): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(52): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(147): warning: integer conversion resulted in a change of sign
nvcc -std=c++11 -c -o modified_permutohedral.o modified_permutohedral.cu -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/external/nsync/public -D_GLIBCXX_USE_CXX11_ABI=1  -x cu -Xcompiler -fPIC --expt-relaxed-constexpr -D FILTER_GPU=1
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(56): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(80): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(100): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(192): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(216): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(236): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(52): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(147): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(56): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(80): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(100): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(192): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(216): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(236): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(52): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(147): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/generated_message_reflection.h(689): warning: variable "unused" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(56): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(80): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(100): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(192): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(216): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/stubs/atomicops_internals_arm64_gcc.h(236): warning: variable "temp" was set but never used
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(52): warning: integer conversion resulted in a change of sign
/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/google/protobuf/arena_impl.h(147): warning: integer conversion resulted in a change of sign
g++ -std=c++11 -D_GLIBCXX_USE_CXX11_ABI=0 -shared -fPIC -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include -O2  -I/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow/include/external/nsync/public -o high_dim_filter.so high_dim_filter.cc modified_permutohedral.cc cudacode.o modified_permutohedral.o -L/home/nvidia/.virtualenvs/cv40py35/lib/python3.5/site-packages/tensorflow -ltensorflow_framework -L/usr/local/cuda/lib64 -lcuda -lcudart -D FILTER_GPU=1
modified_permutohedral.cc: In member function 'void ModifiedPermutohedral::init_cpu(const float*, int, int)':
modified_permutohedral.cc:359:22: error: 'feature' was not declared in this scope
const float * f = (feature + k * num_dimensions);
^
modified_permutohedral.cc: In member function 'void ModifiedPermutohedral::sseCompute(tensorflow::Tensor&, const tensorflow::Tensor&, int, bool, bool) const':
modified_permutohedral.cc:622:51: error: 'seqCompute_cpu' was not declared in this scope
seqCompute_cpu( out, in, value_size, reverse, add);
^
Makefile:50: recipe for target 'high_dim_filter.so' failed
make: *** [high_dim_filter.so] Error 1

I was able to check out Master and compile successfully on AWS P2 instance (Ubuntu 16, tensorflow-gpu==1.8.0, Keras==2.0.8). I think there might be some typo issues with the GPU Branch of the project. When can we expect a full GPU version of the project? Thanks.


ENH: Run a placeholder forward only when lazy

Codecov Report

Merging #116 (0e90fc9) into develop (11c86c2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           33        35    +2
  Lines          905       949   +44
=========================================
+ Hits           905       949   +44

Impacted Files
Coverage Δ

pfhedge/_utils/lazy.py
100.00% <100.00%> (ø)

pfhedge/nn/modules/hedger.py
100.00% <100.00%> (ø)

pfhedge/features/_getter.py
100.00% <0.00%> (ø)

pfhedge/features/__init__.py
100.00% <0.00%> (ø)

pfhedge/features/features.py
100.00% <0.00%> (ø)

pfhedge/instruments/underlier.py
100.00% <0.00%> (ø)

pfhedge/features/functional.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c86c2...0e90fc9. Read the comment docs.


feat: useTemplateEl

Description

Linked Issues
Additional context

Can you open this again, it's closed :(


xclicker: init at 1.5.0

Description of changes
Closes https://github.com/NixOS/nixpkgs/issues/269012
This PR adds 1 new package xclicker
While packaging I found an malloc related issue, opened a PR for it in upstream (https://github.com/robiot/xclicker/pull/91)
Once it gets accepted, I'll use fetchpatch

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269031 run on x86_64-linux 1

1 package built:

xclicker

I do get the following crash when clicking the settings button:
...
Yeah, I didn't check the settings button.
It turns out I missed wrapGAppsHook, that made it work...
or it should have, but I found even more malloc size mistakes, so I updated the PR and the patch...

The patch has been merged, changed to fetchpatch

Came across this PR when having the same buffer overflow problem in my own package.
Tested this and it works perfectly.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1485


LoadError: cannot load such file -- github/markup

Hello,
I installed Redmine via the Debian packages: https://wiki.debian.org/Redmine

Environment:
Redmine version                4.0.7.stable
Ruby version                   2.5.5-p157 (2019-03-15) [x86_64-linux-gnu]
Rails version                  <IP_ADDRESS>
Environment                    production
Database adapter               Mysql2
Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery                smtp
SCM:
Git                            2.20.1

But I can't install the redmine-git-hosting plugin
Dependance ok :
# apt-get install build-essential libssh2-1 libssh2-1-dev cmake libgpg-error-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
uild-essential is already the newest version (12.6).
cmake is already the newest version (3.13.4-1).
libgpg-error-dev is already the newest version (1.35-1).
libssh2-1 is already the newest version (1.8.0-2.1).
libssh2-1-dev is already the newest version (1.8.0-2.1).
0 upgraded, 0 newly installed, 0 to remove and 61 not upgraded.

And if I follow the documentation:
root@mailgw:/usr/share/redmine/lib/plugins# git clone https://github.com/jbox-web/redmine_bootstrap_kit.git
Cloning into 'redmine_bootstrap_kit'...
remote: Enumerating objects: 751, done.
remote: Total 751 (delta 0), reused 0 (delta 0), pack-reused 751
Receiving objects: 100% (751/751), 2.29 MiB | 3.96 MiB/s, done.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 791cdc9 Merge branch 'devel' into v0.2.x
root@mailgw:/usr/share/redmine/lib/plugins/redmine_bootstrap_kit# cd ..
root@mailgw:/usr/share/redmine/lib/plugins#  git clone https://github.com/jbox-web/redmine_git_hosting.git
Cloning into 'redmine_git_hosting'...
remote: Enumerating objects: 114, done.
remote: Counting objects: 100% (114/114), done.
remote: Compressing objects: 100% (88/88), done.
remote: Total 27053 (delta 38), reused 58 (delta 22), pack-reused 26939
Receiving objects: 100% (27053/27053), 7.54 MiB | 7.88 MiB/s, done.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at e5d9a68d 4.0.0
root@mailgw:/usr/share/redmine/lib/plugins/redmine_git_hosting# cd ..
root@mailgw:/usr/share/redmine/lib/plugins# cd ..
root@mailgw:/usr/share/redmine/lib#
root@mailgw:/usr/share/redmine/lib# cd ..
root@mailgw:/usr/share/redmine# bundle install --without development test
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set without 'development test'`, and stop using this flag
Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break
this application for all non-root users on this machine.
The dependency tzinfo-data (>= 0) will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x64-mingw32, x86-mswin32. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x64-mingw32 x86-mswin32`.
Using rake 13.0.1
Using concurrent-ruby 1.1.6
Using i18n 1.6.0
Using minitest 5.14.1
Using thread_safe 0.3.6
Using tzinfo 1.2.7
Using activesupport <IP_ADDRESS>
Using builder 3.2.4
Using erubi 1.9.0
Using nokogiri 1.10.0
Using rails-dom-testing 2.0.3
Using crass 1.0.2
Using loofah 2.2.3
Using rails-html-sanitizer 1.0.4
Using actionview <IP_ADDRESS>
Using rack 2.0.6
Using rack-test 0.7.0
Using actionpack <IP_ADDRESS>
Using nio4r 2.3.1
Using websocket-extensions 0.1.2
Using websocket-driver 0.6.3
Using actioncable <IP_ADDRESS>
Using globalid 0.3.6
Using activejob <IP_ADDRESS>
Using mini_mime 1.0.1
Using mail 2.7.1
Using actionmailer <IP_ADDRESS>
Using method_source 0.9.2
Using thor 0.19.4
Using railties <IP_ADDRESS>
Using actionpack-xml_parser 2.0.1
Using activemodel <IP_ADDRESS>
Using arel 9.0.0
Using activerecord <IP_ADDRESS>
Using mimemagic 0.3.2
Using marcel 0.3.2
Using activestorage <IP_ADDRESS>
Using public_suffix 3.0.3
Using addressable 2.5.2
Using bundler 2.1.4
Using css_parser 1.6.0
Using csv 3.0.2
Using htmlentities 4.3.3
Using mysql2 0.5.2
Using net-ldap 0.16.1
Using sprockets 3.7.2
Using sprockets-rails 3.2.1
Using rails <IP_ADDRESS>
Using rbpdf-font 1.19.1
Using rbpdf 1.19.5
Using redcarpet 3.4.0
Using request_store 1.3.0
Using rmagick 2.16.0
Using roadie 3.2.2
Using roadie-rails 1.3.0
Using rouge 3.19.0
Bundle complete! 19 Gemfile dependencies, 56 gems now installed.
Gems in the groups development and test were not installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
root@mailgw:/usr/share/redmine# bundle exec rake redmine:plugins:migrate RAILS_ENV=production NAME=redmine_git_hosting

rake aborted!
LoadError: cannot load such file -- github/markup
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/redmine/lib/plugins/redmine_git_hosting/lib/redmine_git_hosting/hooks.rb:1:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/redmine/lib/plugins/redmine_git_hosting/lib/redmine_git_hosting.rb:8:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `block in require'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:291:in `require'
/usr/share/redmine/lib/plugins/redmine_git_hosting/init.rb:2:in `block in <top (required)>'
/usr/share/redmine/config/initializers/00-core_plugins.rb:12:in `eval'
/usr/share/redmine/config/initializers/00-core_plugins.rb:12:in `block in <top (required)>'
/usr/share/redmine/config/initializers/00-core_plugins.rb:2:in `each'
/usr/share/redmine/config/initializers/00-core_plugins.rb:2:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:285:in `load'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:285:in `block in load'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:257:in `load_dependency'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:285:in `load'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:657:in `block in load_config_initializer'
/usr/share/rubygems-integration/all/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:170:in `instrument'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:656:in `load_config_initializer'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:614:in `block (2 levels) in <class:Engine>'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:613:in `each'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:613:in `block in <class:Engine>'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `instance_exec'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `run'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:61:in `block in run_initializers'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:50:in `each'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:50:in `tsort_each_child'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:60:in `run_initializers'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:361:in `initialize!'
/usr/share/redmine/config/environment.rb:14:in `<top (required)>'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:337:in `require'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:337:in `require_environment!'
/usr/share/rubygems-integration/all/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:520:in `block in run_tasks_blocks'
/var/lib/gems/2.5.0/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => redmine:plugins:migrate => environment
(See full trace by running task with --trace)

Thank's for your help

This should be fixed in release 5.0.0. If your problem exists with this version, feel free and reopen this issue.

This should be fixed in release 5.0.0. If your problem exists with this version, feel free and reopen this issue.


[bug] virtual text doesnt appear

nvim --version: 0.6
Operating system/version: manjaro 21 xfce ornara (arch linux)

Describe the bug
i dont get any virtual text on the searches even with pasted config from your readme
quick demo for you to see:
https://user-images.githubusercontent.com/54772464/134736740-65522963-375b-4b99-b8da-3c776347eb04.mp4
i followed your instructions and for me virtual text doesnt appear just near the results.

update:
after looking on use other issue on this repo:
my packer config look like this now:
	use {
		'kevinhwang91/nvim-hlslens',
		setup = [[vim.g.loaded_nvim_hlslens = 1]],
	}

and still, it doesnt work...

check out your statusline

yeah, i saw that, thats why i've raised this issue, because its broken.
normally, the virtual text should be position to the right of the item that is found within the search.

just like undefined global issue, but just for the items that im searching for.

i want to have it like this
https://user-images.githubusercontent.com/17562139/115062493-fd26a100-9f1c-11eb-9305-20ef83d08e40.png
from your readme, but i respected the snippet that you gave us for virtual text, but it doesnt work.

minimal configuration, please

configuration copy pasted from your readme
require('hlslens').setup({
    calm_down = true,
    nearest_only = true,
    nearest_float_when = 'always',
    override_lens = function(render, plist, nearest, idx, r_idx)
        local sfw = vim.v.searchforward == 1
        local indicator, text, chunks
        local abs_r_idx = math.abs(r_idx)
        if abs_r_idx > 1 then
            indicator = ('%d%s'):format(abs_r_idx, sfw ~= (r_idx > 1) and '▲' or '▼')
        elseif abs_r_idx == 1 then
            indicator = sfw ~= (r_idx == 1) and '▲' or '▼'
        else
            indicator = ''
        end

        local lnum, col = unpack(plist[idx])
        if nearest then
            local cnt = #plist
            if indicator ~= '' then
                text = ('[%s %d/%d]'):format(indicator, idx, cnt)
            else
                text = ('[%d/%d]'):format(idx, cnt)
            end
            chunks = {{' ', 'Ignore'}, {text, 'HlSearchLensNear'}}
        else
            text = ('[%s %d]'):format(indicator, idx)
            chunks = {{' ', 'Ignore'}, {text, 'HlSearchLens'}}
        end
        render.set_virt(0, lnum - 1, col - 1, chunks, nearest)
	end
})

it doesnt work as presented in this image

-   nearest_only = true,
-   nearest_float_when = 'always',

now its working

thank you so much!


Translate concepts/cluster-administration/kubelet-garbage-collection/ into Japanese

This is a Feature Request
What would you like to be added
Translate concepts/cluster-administration/kubelet-garbage-collection/ into Japanese.
Why is this needed
This page has not been translated.
Comments
/language ja
/assign

/triage accepted


Image markup puts alt text into wrong attribute

Describe the bug.
The docs state that the optional title value in the image markup will "be used as the alt text of the image." However, if you put [img[Title|Image]], the HTML output is:
This output is incorrect; alternative text should go in the alt attribute for accessibility.
To Reproduce:
Steps to reproduce the behavior:

Insert an image in a passage using the image markup.
Publish the file.
Use developer tools (or open resulting HTML file) to check the  created.

Expected behavior.
The HTML output should be:
Project details.

SugarCube Version: 2.37.3
Included Add-ons: none
Included Libraries: none
Compiler & Version: Twine <IP_ADDRESS>

Desktop details.

OS & Version: Windows 10

Additional context.
Some assistive tech can access/announce text in the title, but some simply can't. Others will announce both if they are present - which means that the same text should not be duplicated in an alt attribute as a fix.
More info: img: The title attribute (mdn web docs)

When that code was written (ca. the 2000s or even the 1990s) the title tag was the way to specify alternate text on an image.  So, not a bug per se.
That said, things have moved on, as they are want to do, and today you are correct.  The alt tag is a better fit.


pico-sdk: Make full SDK available

Description of changes
Fixes #175297
The instructions for the use of this SDK (pages 6 and 7) specify that submodules are required for its full/normal use:

$ git clone https://github.com/raspberrypi/pico-sdk.git --branch master
$ cd pico-sdk
$ git submodule update --init
...

 WARNING
Failure to run the git submodule update --init command above will mean that the tinyusb module will not be included,
and as a result USB functionality will not be compiled into the SDK. This means that USB serial, other USB functions,
and example code will not work

The Pico W guide (pages 5 and 31) has a similar message:

$ git clone https://github.com/raspberrypi/pico-sdk.git --branch master
$ cd pico-sdk
$ git submodule update --init
...

 WARNING
If you have not initialised the tinyusb submodule in your pico-sdk checkout, then USB CDC serial, and other USB
functions and example code, will not work as the SDK will contain no USB functionality. Similarly, if you have not
initialised the cyw43-driver and lwip submodules in your checkout, then network-related functionality will not be
enabled.

With this change, I was able to build a network-using executable & run it on a Pico W.
Without this change, attempting to build an executable that uses the board's WiFi fails with this error message:
...
[ 20%] Building C object CMakeFiles/tattlekey.dir/blink.c.obj
/tmp/source/blink.c:18:10: fatal error: pico/cyw43_arch.h: No such file or directory
 #include "pico/cyw43_arch.h"
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

The previous pico-sdk is now called pico-sdk-minimal.
I've excluded the full pico-sdk from hydra due to size concerns expressed in https://github.com/NixOS/nixpkgs/issues/175297#issuecomment-1140498424 and https://github.com/NixOS/nixpkgs/issues/175297#issuecomment-1179141091 .
I'm not including a note in the release notes about this change because this doesn't remove any existing functionality -- it only adds functionality.
FYI:

@muscaln, pico-sdk maintainer
Folks from https://github.com/NixOS/nixpkgs/issues/175297

@icodeforyou-dot-net, creator
@brodul and @danwdart, fellow travelers

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is great, thank you!

any updates on this/work on addressing the reviews? Also need this to package the debug probe for easier building

I just created https://github.com/NixOS/nixpkgs/pull/321786 but then realized that this PR exists.
What is the hang-up to move this forward ?

Adding @emilytrau as she might have some good guidance w.r.t. to embedded libraries and as she is also maintainer of pioasm which somewhat overlaps with this package.
It looks like we have multiple needs w.r.t. the pico-sdk and also addressing #175297

Need for binaries provided by the sdk such as pioasm and elf2uf2
Development: The minimal pico-sdk without any submodules (but also not super-useful without these).
(FYI: The submodules of pico-sdk can be found here in https://github.com/raspberrypi/pico-sdk/tree/master/lib )
Some common submodules are typically needed such as tinyusb and lwip.
other submodules such as btstack or cyw43-driver have an license that looks mostly MIT-like, but have a clause with a commercial clause ... unless used with the RP2040 when it seems entirely free to use. Not sure what to make of it, but folks with license experience can probably clear this up. In any case, some of these modules have different licenses, so that needs to be captured in license metadata.
Maybe sub-packages pico-sdk.tools (with pioasm and elf2uf2), pico-sdk, pico-sdk.tinyusb would be an answer ? (Though sounds somewhat complicated).

I don't have much experience with good practices in nix packaging, so leaving it to the experts.
I think there is value in merging this very PR now and iterate (this one is already stalling 8 months) so that it is actually possible to implement things for the Raspberry Pi Pico on NixOS (I just tried that and right now the sdk is not very useful as one would like to have usb).
Then implement the improvements to be discussed here or in the referenced bug on top.

What is the verdict on this PR ?
I think either this PR or the slightly simpler #321786 should be merged to make rp2040 development on NixOS possible.

Anyone knows a nixpkgs contributor with interest in microcontroller development to add to this review so that there is someone who could drive the review and merge this or PR #321786 ?


ci: update github workflows

chore: update golangci-lint configuration
ci: updated workflows

Codecov Report
Base: 94.23% // Head: 94.23% // No change to project coverage :thumbsup:

Coverage data is based on head (78c20a2) compared to base (322e482).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   94.23%   94.23%
=======================================
  Files           1        1
  Lines          52       52
=======================================
  Hits           49       49
  Misses          2        2
  Partials        1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Falsehoods about Aircraft Seat Maps

👋
Preliminary checks

[x] I have read the Code of Conduct
[x] I applied all rules from the Contributing guide
[x] I have checked there is not other Issues or Pull Requests covering the same topic to open

Aha! That one is great and nicely illustrated. Let's merge! :)


interop: add OptimismSuperchainERC20Factory to predeploys

Description
Updates the predeploys.md file to include the SuperchainERC20Factory specs, as a follow up to the Design Doc
Some comments and open questions:

I'm using past tense for the event, following the current implementation, but I know there's been discussions around it. Should we stick to the past or begin the transition? what would be a better name?
Should the Beacon Contract be a predeploy? if so, should I include it in the predeploys.md file?
The current function and event names (createOptimismSuperchainERC20 and OptimismMintableERC20Created) are following the structure from the OptimismMintableERC20Factory. We can change it to something simpler, like deploy, wdyt?
In the design doc, the OptimismMintableERC20Created included the token metadata and did not have the deployer address. I removed the metadata to be in sync with the OptimismMintableERC20Created event. Metadata can later be fetched from the superToken address. Any take on this?
Should I update the L2StandardBridge in the same file to cover the changes? we already have a liquidity-migration.md file that explains it, but it makes sense to have it repeated here I think.

Should the Beacon Contract be a predeploy?

Yes it should be, we will want to include it in predeploys.md. You can do it as part of this PR or as a follow up. We will need compute the address that the impl is deployed to and then return that from implementation()(address). We do the pre computation as part of consensus already, see ecotone specs derivation for gas price oracle deployment for how we do it. For now we can leave that out tho.

I'm using past tense for the event

Personally i would vote on moving away from past tense but we should not bikeshed on this for too long and just pick something, there exist events that are not past tense that cannot be modified

Should I update the L2StandardBridge in the same file to cover the changes?

I think moving the changes to predeploys.md and then linking to them from the liquidity migration doc makes the most sense. This keeps context around the predeploy changes in a single place

I'm using past tense for the event

Personally i would vote on moving away from past tense but we should not bikeshed on this for too long and just pick something, there exist events that are not past tense that cannot be modified

what would you prefer instead? Something like OptimismSuperchainERC20Creation?

Should the Beacon Contract be a predeploy?

Yes it should be, we will want to include it in predeploys.md. You can do it as part of this PR or as a follow up. We will need compute the address that the impl is deployed to and then return that from implementation()(address). We do the pre computation as part of consensus already, see ecotone specs derivation for gas price oracle deployment for how we do it. For now we can leave that out tho.

Will do in this PR.
For address derivation, following the Ecotone and Fjord specs for GasPrice Oralce, I should do
cast compute-address --nonce=0 fromAddress
Do you know what the fromAddress could be in this case?

@tynes I just pushed a new update addressing your comments.

Added the Beacon Contract description. I didn't add functions and events details as its just using the ERC-1967 interface.
Added the changes for the L2StandardBridge. I think it makes sense to remove the whole liquidity-migration.md file now, as I've included the updates for both the OptimismMintableERC20Factory and L2StandardBridge in the predeploys.md file. Wdyt?

Also pushed an update to the upgrade.md file to include modifications to the OptimismMintableERC20Factory and L2StandardBridge, and deployment of BeaconContract and OptimismSuperchainERC20Factory.


Bug in printing mappingN names

There is a bug in the way the mapping names are used. Given the following contract;
pragma solidity ^0.4.24;

contract Storage {
  mapping (address => uint) public myFirstArray123;
  mapping (address => uint) public mySecondArray;
}

Note that both functions refer to the same mapping.
This compiles to<PHONE_NUMBER>6004361060485763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166357092fea8114604d57806390f1f82d14608a575b600080fd5b348015605857600080fd5b50607873ffffffffffffffffffffffffffffffffffffffff6004351660b5565b60408051918252519081900360200190f35b348015609557600080fd5b50607873ffffffffffffffffffffffffffffffffffffffff6004351660c7565b60016020526000908152604090205481565b600060208190529081526040902054815600a165627a7a723058208d63c3e798dc9103a25dc8a216e21a6f924b5c584f8eb37ad4d0a8f5cd59bfd20029.
This will decompile as
mapping (unknown => unknown) mapping1;
mapping (unknown => unknown) mapping2;

function 57092fea() public view {
    return(mapping1[_arg0]);
}

function 90f1f82d() public view {
    return(mapping1[_arg0]);
}

The public getter functions refer now to the same mapping, although there are two mappings.
This happens becase the SLOAD instruction will create a MappingLoad using count = Object.keys(state.mappings).indexOf(mappingLocation.toString()).
When 57092fea is decompiled, it will point to mySecondArray, which is the only hence first mapping, so it has count=1 and will print (incorrectly) as mapping1.
When 90f1f82d is decompiled, it will point to myFirstArray123, which has a lower storage index, so it's the first mapping with count=1 and will print as mapping1.
I fixed it locally by not using a count variable but storing the mappingLocation, and using that in the MappingLoad.toString() function to construct a proper name. This seems to solve the issue. Are you open to a pull request?

I'm definitely open to pull requests. Thank you!

Do you plan to merge the 0.3 branch to master soon? Or should I make the pull request based on 0.3?

Unfortunately I don't have much time to work on the 0.3.0 branch, but I'm planning on taking a look at what needs to be done to finish it after next week. I think it would be best if you could add any work that you do to the 0.3.0 branch.

Okay, I'll do that. It would be nice if you could merge 0.3.0. If you have any concrete other work that needs to be done on the 0.3.0 branch, I could perhaps help out with that as well.


Use default configuration if no setup

Hello,
If no configuration was passed in setup, the default setups where not used.
This is now fixed with this PR, as you can test

Results in

I'm not sure I understand the problem here, can you explain what kind of setup call results no cfg being used?.
The plugin works fine on my end(and uses the default cfg) when no cfg is passed to setup()

If you do require("stabilize").setup() you'll have the parameter as nil, and the default configuration will not be used: if setup_cfg then.

Oh yes my bad, didn't see that the cfg variable was globally!
I'm closing this PR now


[INFO] about "doManifest"

**This is just an info to @Petschko **
I read here: https://github.com/Petschko/dhl-php-sdk/blob/a78ea297246a18c280902ec5c78cc60a4858025f/examples/getting-started.md#domanifest

I personally don't know for what is this for, but it works!

I just run about this documentation:
deleteShipmentOrder
Mit dieser Operation werden zuvor angelegte Sendungen storniert.

Die Stornierung bereits erstellter Sendung ist nur vor dem Tagesabschluss möglich.

Die Anfrage- bzw. Antwortparameter werden bei den IO-Referenzen erläutert und in Form eines Beispiels dargestellt.

So as far i understand this:
you can create shipments|labels and delete them again.
If you delete the label before the daily completion (In german "Tagesabschluss")
then you wont have to pay for it.
The daily completion will be done every day at 18 pm. actually it should be 17:10 pm
So to complete(?) all current labels manually you could request doManifest.

BTW: UPS handles this better imo.
Cancel Shipment API can:
 allow a user to cancel a forward shipment up to 28 days after the initial processing of the shipment.
 allow a user to cancel a return shipment until 2 a.m. Eastern Time the following night.

You can define the time of the automatic daily manifest in the Geschäftskundenportal.
Optionally you can do the manifest via API - for example right after your last label for this day was printed.
DHL will check the manifest against the actually scanned labels for their billing process.

I'm currently implementing all the 3.x stuff, so I will also add this =) Thank you


Docs: Render the filters in a collapsible panel

To render the filters above the table content in a collapsible panel, you may use: layout: Layout::AboveContentCollapsible

Thanks for the PR, @VasasA!
Could you update the example to be similar to the ones above it?

😃  You are welcome, @zepfietje
Example is updated.

Perfect, thanks!


Objects inside a Subviewport that use a shader with render_mode wireframe will cause memory to increase continuously!!

Godot version
4.0.2
System information
Windows 10
Issue description
I have a meshinstance3d with a shader attached, and this is inside a subviewport. ( I instanced a bunch to make the memory rise faster, for testing purposes ).
The shader uses render_mode wireframe.
Whenever the object is onscreen, the memory will increase continuously! If the object goes offscreen, it will stop.
If I remove render_mode wireframe from the shader, the memory won't increase.
If I set debug_mode to wireframe on the subviewport, the memory won't increase.
Steps to reproduce
Open the attached project, and run the test.tscn
Watch as your memory continues to go up.
It stops if you either remove render_mode wireframe from the shader, or if you set the subviewport debug_mode to wireframe.
It also stops if the object isn't onscreen.
Minimal reproduction project
subViewportWireframeBug.zip

I can confirm this on 4.0.2 (Linux, GeForce RTX 4090 with NVIDIA 530.41.03).
The higher the FPS, the more RAM leaks. With --disable-vsync, I can reach 380 FPS which leaks about 500 MB of memory per second.

Just discovered that this bug doesn't require being in a subviewport. It happens even if you don't use a subviewport! I'll edit the title.

This is caused by a pipeline caching bug. In line 81 of PipelineCacheRD::get_render_pipeline(), it attempts to load a pre-existing pipeline from the cache based on supplied parameters like p_wireframe:
https://github.com/godotengine/godot/blob/1d14c054a12dacdc193b589e4afb0ef319ee2aae/servers/rendering/renderer_rd/pipeline_cache_rd.h#L72-L90
If a pre-existing pipeline is not found, it calls PipelineCacheRD::_generate_version() to generate a new one:
https://github.com/godotengine/godot/blob/1d14c054a12dacdc193b589e4afb0ef319ee2aae/servers/rendering/renderer_rd/pipeline_cache_rd.cpp#L35-L71
However, p_wireframe is overridden in line 39 of this function, so the newly cached pipeline will never match the original p_wireframe given to get_render_pipeline(), and a new one ends up being generated every time it is called (every frame?).

However, p_wireframe is overridden in line 39 of this function, so the newly cached pipeline will never match the original p_wireframe given to get_render_pipeline(), and a new one ends up being generated every time it is called (every frame?).

Maybe even multiple times per frame if the same pipeline is used.
The rasterization_state.wireframe is set by the shader, while p_wireframe comes from get_debug_draw_mode() == RS::VIEWPORT_DEBUG_DRAW_WIREFRAME and is passed to the pipeline when grabbing the pipeline state.
I guess the solution is to check rasterization_state.wireframe as well as p_wireframe to see if the version exists. As if wireframe is set in the shader wireframe is always enabled (even if p_wireframe) is false
https://github.com/godotengine/godot/blob/578ca94ef6351cb6c31b1addf8b3c36577376bd4/servers/rendering/renderer_rd/pipeline_cache_rd.h#L81

I wonder if this issue is what causes wireframe drawing to be very slow in Direct3D 12, as I indicated in one of my comments in https://github.com/godotengine/godot/pull/70315.

I guess the solution is to check rasterization_state.wireframe as well as p_wireframe to see if the version exists.

See the below pseudocode for an alternative suggestion.
diff --git a/servers/rendering/renderer_rd/pipeline_cache_rd.cpp b/servers/rendering/renderer_rd/pipeline_cache_rd.cpp
index 17051d1954..229d0d242a 100644
--- a/servers/rendering/renderer_rd/pipeline_cache_rd.cpp
+++ b/servers/rendering/renderer_rd/pipeline_cache_rd.cpp
@@ -32,16 +32,14 @@

 #include "core/os/memory.h"

 RID PipelineCacheRD::_generate_version(RD::VertexFormatID p_vertex_format_id, RD::FramebufferFormatID p_framebuffer_format_id, bool p_wireframe, uint32_t p_render_pass, uint32_t p_bool_specializations) {
 	RD::PipelineMultisampleState multisample_state_version = multisample_state;
 	multisample_state_version.sample_count = RD::get_singleton()->framebuffer_format_get_texture_samples(p_framebuffer_format_id, p_render_pass);

-	bool wireframe = p_wireframe || rasterization_state.wireframe;
-
 	RD::PipelineRasterizationState raster_state_version = rasterization_state;
 	raster_state_version.wireframe = wireframe;

 	Vector<RD::PipelineSpecializationConstant> specialization_constants = base_specialization_constants;

 	uint32_t bool_index = 0;
 	uint32_t bool_specializations = p_bool_specializations;
diff --git a/servers/rendering/renderer_rd/pipeline_cache_rd.h b/servers/rendering/renderer_rd/pipeline_cache_rd.h
index 0b12dab416..58c1278312 100644
--- a/servers/rendering/renderer_rd/pipeline_cache_rd.h
+++ b/servers/rendering/renderer_rd/pipeline_cache_rd.h
@@ -72,14 +72,16 @@ public:
 	_FORCE_INLINE_ RID get_render_pipeline(RD::VertexFormatID p_vertex_format_id, RD::FramebufferFormatID p_framebuffer_format_id, bool p_wireframe = false, uint32_t p_render_pass = 0, uint32_t p_bool_specializations = 0) {
 #ifdef DEBUG_ENABLED
 		ERR_FAIL_COND_V_MSG(shader.is_null(), RID(),
 				"Attempted to use an unused shader variant (shader is null),");
 #endif

 		spin_lock.lock();
+		p_wireframe |= rasterization_state.wireframe;
+
 		RID result;
 		for (uint32_t i = 0; i < version_count; i++) {
 			if (versions[i].vertex_id == p_vertex_format_id && versions[i].framebuffer_id == p_framebuffer_format_id && versions[i].wireframe == p_wireframe && versions[i].render_pass == p_render_pass && versions[i].bool_specializations == p_bool_specializations) {
 				result = versions[i].pipeline;
 				spin_lock.unlock();
 				return result;
 			}

That solution also looks good!

Is that all that is needed changed, or is there more to it?
I might want to test this out, since there hasn't been any updates.

@prominentdetail The solution proposed by myaaaaaaaa is all you need.

Okay.. hopefully I did everything correctly. I tested it on my end, and it seems to work. Memory has stopped increasing.


Bug: upgrade command doesn't upgrade but wants to set a default version

Bug report

I have Amazon Corretto <IP_ADDRESS>.1 installed using the 23-amzn ID, and since version <IP_ADDRESS>.1 just came out, I wanted to upgrade, but the upgrade subcommand behaves really strangely. Instead of upgrading a version, it instead prompts you to set a default version, which I don't want. So when entering n it just exits without doing anything. Entering Y it installs the suggested version instead of upgrading the already installed version:
~ ❯ sdk upgrade java

Available defaults:
java (local: 23-amzn; default: 21.0.4-tem)

Use prescribed default version(s)? (Y/n): n
~ ❯

To reproduce

Run the sdk upgrade java command
System info

macOS 15.0.1
zsh 5.9

~ ❯ sdk version

SDKMAN!
script: 5.18.2
native: 0.4.6

Hi @audio-engineer, this isn't a bug. We currently track Temurin as our sensible default for upgrades (Temurin is the defacto OpenJDK used by most folks).
We have had several requests that people want to track a specific vendor's JDK releases (like Amazon in your case) but we haven't implemented it yet because it's complicated. We are working towards this, though.
In future, please chat to us on Discord as per our contributing guidelines before opening a bug report here. Thanks!


mesh aabb doesn't respect animation

Bevy version
main - c2b332f98a0bcab7390e4b184099202cfb4fbbe1
What you did
added a cam controller to the animated_fox demo, switched to animation 0 (fox looking left and right) and put the camera so that the head should be in view only when looking fully to one side.
What went wrong
the mesh is frustum-culled since the aabb uses vertex positions in the initial pose.

related to #4971

right, closing as duplicate, thanks


support metis contracts

What was wrong?
Would you consider upstreaming this change. It would save the Metis team from having to maintain a fork of this repo.
Closes #
How was it fixed?
@gnosis/safe-services

https://github.com/gnosis/gnosis-py/pull/162
https://github.com/gnosis/safe-deployments/pull/53

recheck

I have read the CLA Document and I hereby sign the CLA

I'm only merging the changes to safe_transaction_service/history/management/commands/setup_service.py, please revert all the other changes and rebase master branch

Hey sorry about that. Looks like I forgot about this PR and pushed some extra changes to it.

Formatting tests are not passing, please make sure you run the pre-commit hooks: https://github.com/gnosis/safe-transaction-service#setup-for-development

Hi, just a reminder as I see this PR has not been active for 19 days 😉

couldn't get time to update this until now, thank you for waiting.
rebased against master and passed the pre-commit hooks.

Coverage decreased (-1.7%) to 86.84% when pulling 3b5f98cab679a3264dff8d70c2c4e526a7163e60 on titandac:feature/metis_chains into e5761bae84a33aeb42a5218cb396acb88cf60b96 on gnosis:master.


Automatically name the output image after the input file

I think it might be a good idea to by default name the output image after the input file's basename. For example meteor_09-08-01_06-05-2021.s would give meteor_09-08-01_06-05-2021.bmp automatically, unless specified otherwise with a -o parameter. What do you think @dbdexter-dev?

I knew I was missing something from the previous codebase. Yes, I can add that for sure.

Implemented in 622db7ee.


fix(search): fixed critical defect where apps were not opening after search (JIRA 482 & 450)

added check so contact validation does not break on undefined list an…d made it so global listing store updates from backend if full app entry is not cached
JIRA 482 & 450
@blynch11p @mleeBoeing @skhtet
Fixes bugs with following descriptions:

STR-
Go to Search bar
Search on Chatter Box 3
Click on the Chatter Box 3 displaying in search results drop down list
RESULTS - Nothing
Dev tools - main.js:53779 Uncaught TypeError: Cannot read property 'forEach' of undefined(…)
EXPECTED RESULTS - Should launch Quick View Modal of app listing
Choose enter
Click on the Chatter Box 3 app listing icon in the search results display.
RESULTS-Nothing
EXPECTED RESULTS- Should launch Quick View Modal of app listing

STR-
Search on an app
Once the app returns in the search reults screen
Click on it to open thge Quick View Modal
RESULTS - Nothing happens. Error -  instance.contacts is undefined
EXPECTED RESULTS - Should open Quick View modal.

:+1:

:+1:

:+1:


Add hold to button spec

why do up/down appear at 0x1/0x2, but click, long click, and hold come at 0x8N?

down/up map to reserved event code active/inactive

Got it... so presumably the hold button code needs to be a different value?

Looks good


libft - ft_memcmp giving wrong errors on correct code.

ft_memcmp is giving errors on code that use to pass 42filechecker.
Here are the 4 errors I get, even though my code (And the code of several other cadets I had test this problem) has passed Moulinette.
ft_memcmp:     [OK] [OK] [OK] [FAILED] [FAILED] [FAILED] [FAILED] [OK] [OK] [OK]
[fail]: your memcmp does not work with basic input
[fail]: your memcmp does not cast the memory in unsigned char
[fail]: your memcmp stop at
[fail]: your memcmp does not work with basic input

same here, any idea what it's trying to run for those tests? I'm still searching.


Fix progress output for identifier name

Codecov Report

Merging #36 (1b73320) into master (59ac425) will increase coverage by 0.06%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   83.00%   83.06%   +0.06%
==========================================
  Files          15       15
  Lines         800      803       +3
==========================================
+ Hits          664      667       +3
  Misses        136      136

Flag
Coverage Δ

unittests
83.06% <52.63%> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cloudscale_cli/commands/__init__.py
61.57% <47.05%> (+0.15%)
:arrow_up:

cloudscale_cli/commands/floating_ip.py
100.00% <100.00%> (ø)

cloudscale_cli/commands/objects_user.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ac425...1b73320. Read the comment docs.


[glyf] Support ROUND_XY_TO_GRID

https://docs.microsoft.com/en-us/typography/opentype/spec/glyf#composite-glyph-description

Looks like freetype applies this only when hinting is enabled. And since ttf-parser doesn't support hinting we can probably skip it all together.


Multiline string in C# block causes Template render error

Category
Bug with templating
What is the current behavior?
When using this code-block:
```cs
var html = @"
<head>
    <style>
        body {{
            margin: 20px;
        }}
    </style>
</head>";
Application.Current.Use(new PartialToStandaloneHtmlProvider(html))

I get the following error:
Template render error: (C:\Users\Mackiovello\Documents\Documentation\test-gitbook\sub-page-two.md) [Line 6, Column 19]
  expected variable end

What is the desired behavior?
There should be no error because the code is within a code block.
Additional information
CLI version: 2.3.0
GitBook version: 3.2.2

You have to escape the {{ }} parts as this is similar to the templating syntax.
Enclose the problematic parts in {% raw %} {% endraw %}.
So it would look like this:
{% raw %}
var html = @"
<head>
    <style>
        body {{
            margin: 20px;
        }}
    </style>
</head>";
Application.Current.Use(new PartialToStandaloneHtmlProvider(html))
{% endraw %}

Ah, just saw on Slack that you've also figured it out... :smile:

From what @SamyPesse said:

Basically code blocks should be escaped from GitBook templating syntax (which conflicts with Polymer bindings.

I thought that this might be a bug that probably should be fixed. It's not a big deal, though it was annoying when I first hit it.

The root of this issue is the same than https://github.com/GitbookIO/feedback/issues/316
The templating syntax for variables {{ ... }} should not be parsed within code blocks.
I'll close this issue in favor of the other.


Inverse affine transformation

If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.
TensorFlow version (you are using): 2.8
Are you willing to contribute it (Yes/No) : Yes
Describe the feature and the current behavior/state.
Currently affine transformaton like RandomFlip, RandomHeight, RandomRotation, RandomWidth, RandomCrop and RandomZoom can only be used for image classification task since the ground truth for other visual tasks have to be changed for such augmentations.
Describe the feature clearly here. Be sure to convey here why the requested feature is needed. Any brief description about the use-case would help.
Want a layer(s) to reverse the affine transormation(s) so that the input can be augmentated for other visual taks.
Will this change the current api? How?
Yes. Addition of new layer(s).
Who will benefit from this feature?
Anyone using keras for visual tasks like segmentation, object detection etc
cc: @LukeWood

/cc @qlzh727

Thanks for reporting the issue.
We added a new base layer for https://github.com/keras-team/keras/blob/a179ed22f002e2f4a43ae4770348a9b8e1d5a051/keras/layers/preprocessing/image_preprocessing.py#L225. This will allow user to override augment_label and augment_bounding_box.
We are gradually applying the base layer to all the existing KPLs, and will make this base layer available publicly.

Assigning to @qlzh727 as he is already holding the work to make this use case possible.

@old-school-kid,
Could you please take a look at these two PR's which were already merged, 1. Add support for segmentation mask in BaseImageAugmentationLayer 2. Add all of the no-op segmentation mask augmentations.
https://github.com/keras-team/keras-cv/pull/748
https://github.com/keras-team/keras-cv/pull/751
Thank you!