Three new staff explode scripts

Submitting three new staff_explode scripts based on a template provided by Nick Mazuk.
I'm not sure if I'm doing the right thing here so please let me know if I need to handle GitHub Desktop and Visual Studio Code differently. I think I've created my own local fork of the repository, and these submissions from that fork should remain benign until approved for use in the master repository.

Very glad to hear that it worked Nick! I hadn’t read through configuration.lua, but it’s purpose seemed perfectly obvious, I just didn’t think to update the config pointer for each file. Will make the changes and submit new request.
I can now bring some of my other scripts into the repository. Are there any you think are particularly useful?
http://carlvine.com/lua/
Carl

On 16 May 2022, at 12:03 pm, Nick Mazuk @.***> wrote:
@Nick-Mazuk commented on this pull request.
Hey Carl, thanks for taking the time to try and tackle Git and GitHub!
Overall, looks great. You've definitely created a local version of the repository, and submitted a pull request correctly. And you've definitely not messed anything up (and even if you did, I can fix it).
I made two tiny comments that should be quick an easy to fix. To fix them, all you need to do is the following:
In your local version of the repo on your computer, edit the files like normal.
Create a new commit with the changes.
Push the changes to GitHub (the same way you did before).
The PR will automatically update with the new changes and I'll automatically get notified. I'll then approve this PR and merge it into the master branch!
Let me know if you have any questions. Feel free to ask here on GitHub or on Facebook.
In src/staff_explode_pairs.lua https://github.com/finale-lua/lua-scripts/pull/172#discussion_r873272229:

   This script allows for the following configuration:

   ```

   fix_note_spacing = true -- to respace music automatically when the script finishes

   ```

]]
return "Staff Explode Pairs", "Staff Explode Pairs", "Staff Explode as pairs of notes onto consecutive single staves"
+end

+local configuration = require("library.configuration")
+local clef = require("library.clef")
+
+local config = {fix_note_spacing = true}
+
+configuration.get_parameters("staff_explode.config.txt", config)
Could we update this line to the following?
configuration.get_parameters("staff_explode_pairs.config.txt", config)
The convention we use in this repository (though admittedly I don't think we've documented it) is to use the file name for the script as the filename for the config file. So hello_world.lua would have the config file hello_world.config.txt.
Also, let me know if you're confused with what the configuration.get_parameters function is or how it works. The relevant docs are in the following link, but I'm curious if those docs are clear or not.
https://www.finalelua.com/docs/library/configuration https://www.finalelua.com/docs/library/configuration
In src/staff_explode_split_pairs.lua https://github.com/finale-lua/lua-scripts/pull/172#discussion_r873273640:

   This script allows for the following configuration:

   ```

   fix_note_spacing = true -- to respace music automatically when the script finishes

   ```

]]
return "Staff Explode Split Pairs", "Staff Explode Split Pairs", "Staff Explode as pairs of notes onto consecutive single staves"
+end

+local configuration = require("library.configuration")
+local clef = require("library.clef")
+
+local config = {fix_note_spacing = true}
+
+configuration.get_parameters("staff_explode.config.txt", config)
Likewise, this should be:
configuration.get_parameters("staff_explode_split_pairs.config.txt", config)
—
Reply to this email directly, view it on GitHub https://github.com/finale-lua/lua-scripts/pull/172#pullrequestreview-973330403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFP4NYUIG7RF5OCIVHCMXLVKGUGLANCNFSM5V7ZQ3UQ.
You are receiving this because you authored the thread.

Many thanks Nick. The process wasn’t as gruelling as I had expected. Will add more in due course. Some of my larger scripts need major surgery to begin to approach FinaleLua style clarity.
Carl

On 17 May 2022, at 1:17 am, Nick Mazuk @.***> wrote:
They're now live on the site! https://www.finalelua.com/scripts?search=explode https://www.finalelua.com/scripts?search=explode
Feel free to add any of your scripts that aren't duplicates of scripts we already have. The "Create Cue Notes" and "Tempo from Beginning" scripts seem particularly useful.
—
Reply to this email directly, view it on GitHub https://github.com/finale-lua/lua-scripts/pull/172#issuecomment-1127804142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZFP4N4DY5CTXXBJJRXOTUTVKJRH5ANCNFSM5V7ZQ3UQ.
You are receiving this because you authored the thread.

Glad it wasn't as difficult as you expected!
If you'd like any help with Git in the future, feel free to ask.
Same with your larger scripts. You can create a "draft" pull request to get feedback early before it's ready to be merged. Then, when you're satisfied with it, you can set the pull request as "not draft" so we know it's good to merge.


Modify list command

Codecov Report

Merging #41 (a5bef89) into develop (09b7cc8) will increase coverage by 0.39%.
The diff coverage is 51.72%.

@@              Coverage Diff              @@
##             develop      #41      +/-   ##
=============================================
+ Coverage      40.26%   40.65%   +0.39%
- Complexity       211      219       +8
=============================================
  Files             72       72
  Lines           1145     1183      +38
  Branches         114      129      +15
=============================================
+ Hits             461      481      +20
- Misses           637      649      +12
- Partials          47       53       +6

Impacted Files
Coverage Δ

...in/java/seedu/ibook/logic/commands/AddCommand.java
90.00% <ø> (ø)

...n/java/seedu/ibook/logic/commands/ListCommand.java
0.00% <0.00%> (ø)

...java/seedu/ibook/logic/commands/UpdateCommand.java
0.00% <0.00%> (ø)

...ain/java/seedu/ibook/logic/parser/IBookParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/ibook/model/Model.java
0.00% <0.00%> (ø)

src/main/java/seedu/ibook/model/ModelManager.java
0.00% <0.00%> (ø)

...in/java/seedu/ibook/model/util/SampleDataUtil.java
0.00% <0.00%> (ø)

...model/product/ProductFulfillsFiltersPredicate.java
34.78% <34.78%> (ø)

...n/java/seedu/ibook/logic/commands/FindCommand.java
40.00% <50.00%> (-10.00%)
:arrow_down:

...va/seedu/ibook/logic/parser/FindCommandParser.java
95.45% <95.23%> (-4.55%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b7cc8...a5bef89. Read the comment docs.


WIP: Improve win32 font docstrings, formatting, and annotations

Changes

Adds annotations to win32 font modules
Adds docstrings
Improves whitespace

How to test
Run unit tests to make sure it still works
Follow-up work
I'll be working my way through the other font code as time allows.

Let's just merge it now to keep momentum up. :+1:


Simple.OData.Client is unable to invoke Action that accepts entity collection

I get error "The parameter 'wheels' is of Edm type kind 'Collection'. You cannot call CreateCollectionWriter on a parameter that is not of Edm type kind 'Collection'."
Below are details of my setup:
Web API 2.2 OData v4 service : I have defined Action in WheelsController class in my service like this:
public async Task< IHttpActionResult > UpdateWheels(ODataActionParameters parameters)
{
object value;
parameters.TryGetValue("carId", out value);
int carId= (int)value;
parameters.TryGetValue("wheels", out value)
IEnumerable< Wheel > wheels = (IEnumerable< Wheel >)value;
// logic goes here....
return OK();
}
In WebApiConfig.cs files, the Action configuration is defined as below:
ODataConventionModelBuilder builder = new ODataConventionModelBuilder();
builder.EntitySet< Car >("Cars");
builder.EntitySet< Wheel >("Wheels");
var action = builder.EntityType < Wheel > ().Collection.Action("UpdateWheels");
action.Parameter< int >("carId");
action.CollectionParameter< Wheel >("wheels");
I get success in invoking the above action from RESTClient extenstion in FireFox browser as POST request to URL "http://localhost/Service/Wheels/UpdateWheels"  with Request Body as
{"carId":2,
"wheels":[{"Id":1,"Name":"Wheel Front 1","Description":"Front wheel left",           "PositionEnum":"FrontLeft"},{"Id":2,"Name":"Wheel Front 2","Description":"Front wheel right", "PositionEnum":"FrontRight"}]
}
However, it gives error when I try to invoke the above service action using Simple.OData.Client in client application such as
public async void TestUpdateWheels(List< Wheel > wheelList)
{
// client is derived from ODataClient from assembly Simple.OData.Client.Core.dll, v<IP_ADDRESS>
await client.For< Wheel >()
.Action("UpdateWheels")
.Set(new { carId = 2, wheels =  wheelList})
.ExecuteAsync();
}
It gives error message: The parameter 'wheels' is of Edm type kind 'Collection'. You cannot call CreateCollectionWriter on a parameter that is not of Edm type kind 'Collection'.
How can I call successfully the above Action from ODataClient?  Please help.

Thanks for reporting the issue.

Can you try most recent of Simple.OData.Client? There's been some changes since the version 4.3, so I'd recommend trying 4.7.
If the error still occurs, can you share the service metadata document?

I have now used Simple.OData.Client v 4.7.1 but getting the same error.  The service metadata is as follows: http://localhost:55225/Service/$metadata
(And I have the sample solution but do not know how to post it here (452 KB zip file) )

<edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx">
edmx:DataServices

</edmx:DataServices>
</edmx:Edmx>

I will appreciate sample solution, it will be easier to reproduce the problem. Can you send it to me at<EMAIL_ADDRESS>

I managed to reproduce the issue. Expect the fix soon :-)

The new version 4.7.2 has fixed the issue for me. Thanks for prompt support!


Validate cockle_wasm_env if it already exists

If cockle_wasm_env already exists, do not assume it contains the correct packages and instead validate it.

Fixed by #72.


Update README.md

Readme.md file updation
if(issue['pull_request']){   if(issue['pull_request']['merged_at']){     // Pull request was merged     user_name = 'neeru24';       user_avatar = 'https://avatars.githubusercontent.com/u/161798182?s=400&u=b56d57123a3be947048a2c750c3f505428e1f1c9&v=4';       users.push({user_name, user_avatar})   } }

You made a well-structured and informative README.

Glad to know that 😊 Thank you.


Update README.md

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #870   👈

This stack of pull requests is managed by Graphite.


[Feature] Lineage of sources from models in multi-project docs

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
When having multiple projects and one documentation repository, many of those projects may use tables from others as sources. Right now, it is not possible to track down this in the dbt docs Lineage Graph.
We'd like to see the full lineage of a table across multiple projects.
Describe alternatives you've considered
The alternative is going to the "Database" tab, look for the source, find the repeated name, and click on the right one to find the model.
Who will this benefit?
This will benefit anyone who uses dbt docs generate with multiple projects in the packages.yml
Are you interested in contributing this feature?
Yes, check the code below.
Anything else?
The following python script creates a new version of the manifest.json that solves this issue in dbt 1.7.8
This is working for me as an extra step, but I think that it sould be integrated as a --option of the dbt docs generate command.
import json

with open("target/manifest.json", "r") as manifest_file:
    manifest = json.load(manifest_file)
    model_relations = {}
    for k, v in manifest['nodes'].items():
        if v['resource_type'] == "model":
            model_relations[f"{v['database']}.{v['schema']}.{v['name']}"] = k
    for k, v in manifest['sources'].items():
        relation_name = f"{v['database']}.{v['schema']}.{v['name']}"
        if relation_name in model_relations:
            manifest['parent_map'][k].append(model_relations[relation_name])
            manifest['child_map'][model_relations[relation_name]].append(k)

with open('manifest.json', 'w', encoding='utf-8') as f:
    json.dump(manifest, f, ensure_ascii=False, indent=2)

Thanks for proposing this idea @akerone ! 🧠
We don't view this as the preview of dbt docs generate. Instead, you can do any extra post-processing steps like in your example.

@akerone Thx for the code, I used it to create dbt docs with multiple projects with amazing success ;)

Hi @Nic3Guy ! I'm glad you could find it. I hope the title is descriptive enough to find for all of us that use "Option 4: Separate Team Repositories + One Documentation Repository".
Since it seems it won't be integrated into dbt, we'll have to keep close tabs on the release notes of each dbt release. Any changes to the structure of manifest.json may break this script.


changed colors and fixed cmd line print

This PR changes the color scheme of the app to fit the first one that Chloe suggested. It makes a few other small style changes for things like the modals too.
@MontanaRoberts @hmc-cs-celliott @hmc-cs-jcrewe


Tag the source

Could you please tag the source? This allows distributions to get the complete source from GitHub.
Thanks

I'm getting this error:
.../gehome-master/examples/websocket_example.py:74: DeprecationWarning: The object should be created within an async function
session = aiohttp.ClientSession()
which may have lead to another error:
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)


Wip: Style guide view

A really work in progress about adding style guide view.

[x] Add an example template file when generating component (by default or with an option)
[x] Make a mountable engine with Komponent::StyleguideController handling responses
[x] Add a way to list all components in a project as an helper ?
[ ] Add an index view listing all components
[ ] Add a component view for each component
[ ] Add tests

Closes #94.

Some questions:

Do we add extra pages as mountain_view does? (https://github.com/devnacho/mountain_view#adding-extra-pages-to-the-styleguide)
What do we use to render the assets (css and js) of the stylguide pages?

For now, let's not add extra pages.
For the assets, can we have a dedicated pack?
We could also have components styleguide/header and styleguide/footer in the engine, that you can override in your project if you want to customize them.

For the assets, can we have a dedicated pack?

Not sure this part is easy to do. For now I just put style inside a style tag.
Otherwise I created 3 components komponent/styleguide/(header|container|footer).
I also:

Add a helper to have the components list with komponent_components
Start to update the README and CHANGELOG
Create Komponent::Styleguide controller and index, show views
Start working on styleguide stylesheet and html structure
Start updating the generator to add a _example.html.(engine) file on component generation
Create a Komponent::Component class to easily list or find a component (may be it could improve by using the path resolver)
Rename Railtie as a Engine (not sure what is the better to do here)

I will continue this later, may be in the next week.

I was thinking a bit about assets this last days and I notice two problems:

Not sure if we can easily create a pack, I have to read more about webpacker.
Not sure how could we process to load the css of the component. MountainView did it from asset pipeline, but we can't really do the same since Komponent use webpacker.

I worked on the default UI today. Here is what it looks like:

We discussed the next steps with @nicolas-brousse.
The idea to allow customization of the styleguide, and easy setup, is to:

[ ] add a generator rails g komponent:styleguide that will:

copy frontend/components/komponent to the main app folder (probably using Thor directory action)
add a pack frontend/packs/komponent.js that will contain:

import 'components';
import 'components/komponent';

mount the engine in routes.rb

This way, the user can customize the UI of the styleguide, by modifying components and reusing CSS variables from the main app. It's also possible to add JavaScript in those components, if needed. The assets are compiled using webpacker, with the same process as the main app existing pack.

[ ] when rendering the _example.html.slim file in the styleguide, we could override the component helper, to output the component, followed by the source code to copy-paste (and maybe the resulting HTML code as well)

Pull Request Test Coverage Report for Build 399

13 of 14 (92.86%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 99.231%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/komponent/komponent_helper.rb
1
2
50.0%

Totals

Change from base Build 379:
-0.8%

Covered Lines:
129

Relevant Lines:
130

💛  - Coveralls

I made some changes:

Move the frontendfolder into generators templates.
Locally, I update the fixtures rails application to do some test. I'll push this a bit later.
Create komponent:styleguide generator and regroup common generators methods in a Utils module.

What needs to be done:

Optimize Komponent::Component by using Komponent::ComponentPathResolver
Add more tests (not sure what to test)
Decide to use Engine or Railtie or both

What I noticed:

Design seems to be broken in Firefox, not sure if I broke something with my lasts commits.

@nicolas-brousse I added more tests, we're now back over 98% coverage. What's left to test is:

resolved_component_path
path

About Railtie vs. Engine:.

Any Rails::Engine is also a Rails::Railtie

Source: https://api.rubyonrails.org/classes/Rails/Engine.html
So I don't see any issue in using an Engine :)

About Railtie vs. Engine:
Okay. It was just to be sure with you and have your advice if needed.

Here are a few more tasks:

[ ] support for nested components in nav
[ ] support for adding static pages: add routes in the engine, so you just have to create the views in app/views/komponent/static/

I created #114 to do "support for adding static pages: add routes in the engine, so you just have to create the views in app/views/komponent/static/" in a separate PR


Extension provider types are not available across modules

Bicep version
Bicep CLI version 0.2.328 (a13b032755)
Describe the bug
With the work made in #870, most of the type errors has been resolved for extension providers, when utilized inside of the same bicep file.
When trying to splitting this out into two modules however, the resource scope is, to my understanding, no longer possible, as the scope on a resource requires a resource as input.
To Reproduce
Working example of implementing this in a singular file:
resource adf 'Microsoft.DataFactory/factories@2018-06-01' = {
  name: dataFactoryName
  location: resourceGroup().location
}

resource log_analytics 'Microsoft.OperationalInsights/workspaces@2020-08-01' = {
  name: logAnalyticsName
  location: resourceGroup().location
}

resource adf_diagnostics 'Microsoft.Insights/diagnosticSettings@2017-05-01-preview' = {
  name: diagnosticSettingsName
  scope: adf
  properties: {
    workspaceId: log_analytics.id
    logAnalyticsDestinationType: 'Dedicated'
    metrics: [
      {
        category: 'AllMetrics'
        enabled: true
      }
    ]
  }
}

In this case, all type errors are gone, and intellisense completion is also possible.
This is the desired outcome.
However, if I attempt to split it up into two different modules, as such:
mod1
resource adf 'Microsoft.DataFactory/factories@2018-06-01' = {
  name: datafactoryName
  location: location
}
output adfName string = adf.name

resource log_analytics 'Microsoft.OperationalInsights/workspaces@2020-08-01' = {
  name: logAnalyticsName
  location: location
}
output logAnalyticsResourceId string = log_analytics.id

and mod2
resource adf_diagnostics 'Microsoft.Insights/diagnosticSettings@2017-05-01-preview' = {
  name: diagnosticSettingsName
  scope: 'Microsoft.DataFactory/factories/${datafactoryName}'
  properties: {
    workspaceId: logAnalyticsResourceId
    logAnalyticsDestinationType: 'Dedicated'
    metrics: [
      {
        category: 'AllMetrics'
        enabled: true
      }
    ]
  }
}

Additional context
It is worth noting that I am able to get the result desired by specifying mod2 as a extension provider directly on the resource, with "/providers/diagnosticSettings@2017-05-01-preview", but that obviously brings back the type issue.
At this point I don't know if I'm missing the usage of some function, or if it's simply not possible.
The syntax for the scope in mod2 was mostly me playing around, and trying to mimic the implementation of resource scoping in ARM, but I don't know if it's simply not possible due to it being separate deployments.

I think this will be possible once existing is done (#1339). @DanniJuhl - you need a reference to your data factory resource inside of mod2, so mod2 would look something like this:
param dataFactoryName string
param diagnosticSettingsName string
param logAnalyticsResourceId string

resource adf 'Microsoft.DataFactory/factories@2018-06-01' existing = {
  name: dataFactoryName
}

resource adf_diagnostics 'Microsoft.Insights/diagnosticSettings@2017-05-01-preview' = {
  name: diagnosticSettingsName
  scope: adf
  properties: {
    workspaceId: logAnalyticsResourceId
    logAnalyticsDestinationType: 'Dedicated'
    metrics: [
      {
        category: 'AllMetrics'
        enabled: true
      }
    ]
  }
}

FYI - we're still playing around with the syntax for existing so feel free to share feedback on that :)
This feels a little hacky as I have to duplicate the adf resource in two places. There is some discussion of exposing resources as a property of the module so that you could reference it outside of the module. You can imagine a main.bicep like the following:
module mod1 './mod1.bicep' = {
  name: 'mod1'
}

module mod2 './mod2.bicep' = {
  name: 'mod2'
  params: {
    adfResource: mod1.resources.adf
  }
}

The above implies that we have a param of type resource which doesn't exist today, but it could make this scenario cleaner.

I think this will be possible once existing is done (#1339). @DanniJuhl - you need a reference to your data factory resource inside of mod2, so mod2 would look something like this:
param dataFactoryName string
param diagnosticSettingsName string
param logAnalyticsResourceId string

resource adf 'Microsoft.DataFactory/factories@2018-06-01' existing = {
  name: dataFactoryName
}

resource adf_diagnostics 'Microsoft.Insights/diagnosticSettings@2017-05-01-preview' = {
  name: diagnosticSettingsName
  scope: adf
  properties: {
    workspaceId: logAnalyticsResourceId
    logAnalyticsDestinationType: 'Dedicated'
    metrics: [
      {
        category: 'AllMetrics'
        enabled: true
      }
    ]
  }
}

FYI - we're still playing around with the syntax for existing so feel free to share feedback on that :)
This feels a little hacky as I have to duplicate the adf resource in two places. There is some discussion of exposing resources as a property of the module so that you could reference it outside of the module. You can imagine a main.bicep like the following:
module mod1 './mod1.bicep' = {
  name: 'mod1'
}

module mod2 './mod2.bicep' = {
  name: 'mod2'
  params: {
    adfResource: mod1.resources.adf
  }
}

The above implies that we have a param of type resource which doesn't exist today, but it could make this scenario cleaner.

+1 on having a param of type resource.
I'm exclusively using modules for all resources, to simplify the authoring experience and main.bicep to give an overview of the combination of resources in the "solution".
In this use-case, I want to have diganosticsSettings for various resource types in separate modules, so I can easily re-use these modules. I can create a module, which would turn on all logs and metrics for a website resource, which I then provide as a param. This enables me to reference the module in any main.bicep file.
This is a really powerful use-case for re-using modules.

I agree with @MikkelHegn on the +1.
Considered the existing implementation as well, but as Alex mentions, it definitely feels hacky. In the use case described by Mikkel, it would pretty much involve interacting with every single resource already deployed in a separate module.

That being said, at this point in time, it is most likely the solution that I'll end up implementing, simply because I value modules higher, and "dealing" with what seems like duplicate code.

I also use modules a bit, and definitely more aggressively more compared what has been made in ARM, simply due to the simplicity that comes with bicep. This means that even IAM access between resources has been split off into a separate module, to allow for scenarios where this is not possible due to security restrictions.
As a result of this, I end up passing ResourceId's across modules as outputs quite extensively, which perhaps the resource property could assist?
To extend on the example above, it could be a reference to adfResource.Id in mod2?
@alex-frankel is there anywhere where feedback on resource outputs is ongoing, I would happily describe a use case if so.

Totally agree your comments @DanniJuhl & @MikkelHegn!
The existing syntax at present is useful to refer to resources which are totally outside the scope of your deployment, but it leaves something to be desired in the scenario that you're trying to reference resources that are in the scope of your deployment, but are in a different .bicep file.
For that purpose, I'd personally love to see some means of passing a strongly-typed reference to a particular resource via param & output as I think Alex is hinting at. I would not want to compromise on type safety however.

#1339 provides a solution to this problem.
#2246 tracks the more elegant solution.
Closing this one as a duplicate.


set animations to data attributes

Hi @danifornells ,
Thanks for you talk the other day in Madrid.
As we discuss ,I think there will be a good practice to have all the animations set in a data attribute instead on a class (same with JS interaction ) . Something like this:
[data-animation="a-reveal-opacity"] {}
you also said that you could have other animation elements in other layers and I see that your animation layer is almost at the bottom of the stack.
This makes me think in two issues.
The first one is that we can't asure the override of the animation rule because we don't have !important
The other one is more about "single source of truth principle".
If a developer has to fix something on a module  that has a mixin like:

The developer will have to look into both files and do some testing to see which one is the one that is affecting the behavior (we are not fulfilling the single source of truth) .
this is one of the reasons that I don't like very much the use of mixin , except if the mixings are utilities (in this case we can asure that the utility is overriding the other elements on the mixin).
So mi proposal will be to refactor animation to be set with data attributes and maybe (and here I have my doubts) do not let have animation stuff inside our components, object, etc or in the wirst case tread animations as utilities with !important.
What do you think ?

Hi @area73 , thanks for contributing, you're welcome ;)
The animations layer is not at bottom, because is a design abstraction that can be inherited by components, as you can see on the haiticss triangle. No matter what order has the three abstraction layers (objects, animations and color-shemes), but those three should be after elements and before components.
If I understood your concerns, those are:

Serving abstractions as a mixins, and applying them on components, can break the single source of truth, while you can achieve same results adding the abstraction class on HTML. You need to check both component and animation css files to have the whole picture of properties.

The animation inherited properties, could be overridden by other animation properties if any are set on component layer.

I can understand and share parts of the same concerns, but I have doubts about your proposal as a solution for them.

About serving abstractions as a mixins and class names as well. There's a reason why we did it. If we consider the objects layer, and real world cases, we found components who mutates the object abstraction under certain conditions, like a matched breakpoint. On those cases we thought on many solutions, and concluded the best to define that complex or mutable layout in the component level. Mixins can help on that. But the usage of those mixins as a replacement for the inheritance of abstractions, let's say that's not a best practice, because you'll get more css output, and you loose the stronger point of the architecture. After playing with ITCSS the best practice that achieved better results on our cases, is to use the abstractions as class names on HTML, and write on component css file, just the properties that cannot be inherited, reserving to use utilities class names, to keep room for exceptions. It worked like a charm for us, and we believe that's the best way to go.

About overriding abstractions properties on component levels. Sometimes is needed, for instance different vertical and horizontal paddings on objects. If happens, is better to override them on component css rather than using utilities class names.

Besides the concerns, your proposal was to use data-attributes, or let's say just attributes, to set animations. For me does not make a lot of sense, because all other abstractions are working based on class names, and you'll get a difference on a layer, but having same specificity on selectors. Besides that, I like the idea of attributes for determining the states of an animation or a component (not modifiers).
Maybe involving more people on that conversation we'll find the light.
Knock, knock @d-asensio @judabelli @arnau-pujol @nucliweb

Hi!
I get the @area73 points, but my opinion is similar to @danifornells, I prefer to use the classes and mantain the mixins, but I have to say that I like the idea of use data-attributes to set the animations states as well!

OK, then I think we can close this issue


add tokio-console

just realised there is a potential memory leak in the tracer so need to test this https://github.com/tokio-rs/console/issues/184


ROOT_NIBBLE_HEIGHT is wrong

ROOT_NIBBLE_LENGTH was formerly HashValue::LENGTH * 2; this was updated to 256 * 2 instead of 32 * 2 as part of the byte-oriented refactoring.  We should identify exactly where this happened and whether there were any other errors made a the same time as this one.

This change happened in #15 , here:
https://github.com/penumbra-zone/jmt/pull/15/files#diff-a24d89da14b71cd283dbe8cf1d4412177027cbe2beea657dc6e5f50cb0e517ac
There are a couple remaining references to diem_crypto::hash::HashValue in access_path.rs and block_info.rs, but code from those files doesn't seem to be referenced anywhere else.

https://github.com/penumbra-zone/jmt/pull/28 fixes ROOT_NIBBLE_HEIGHT itself so far, but I want to make a survey of changes in #15 and look for places where HashValue::LENGTH might have been replaced incorrectly.


Fix a failure to create new statefulset at sync time.

Also do a fmt run.

Coverage increased (+0.005%) to 7.699% when pulling 9935f3646d9965352ca061ea137c009d86f5bd4e on bugfix/fail_to_create_kubernetes_objects_on_sync into 6813bf59216a65ddae4eb7d95ccead74caa4d63a on master.

:+1:

👍


Revert custom CIDR change

Reverts #473.
Sending for review/approval. Still seeing if I can avoid backing this out.

This change is

@colemickens,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@acs-bot test this please

Could anyone point why #473 was backed out please?

It broke our CNI plugin. (pod to pod communication). We have work planned to get them working together. It doesn't make sense to any of us why they are incompatible. Any one who wants to help investigate why they don't work together we would definitely appreciate.


Use config.returning value in PG Queries

The config option set up in https://github.com/tgriesser/knex/blob/master/src/dialects/postgres/index.js#L18 wasn't being used. This PR adds a check for the defaultReturning option set on the PG Client and uses it if it's there.

Hmm, I forget when this had gotten added in here but I can't find it referenced in any other tickets and it doesn't look like it's documented as an option anywhere.
I'm kind of hesitant to add it back in though, I'd rather get a good way to hook into the query construction process. Let me think on this one for a bit and get back to you.

Closing for now, since this is missing tests, documentation and resolving conflict. Can be opened for reconsideration if PR is finished.


Show all orgs on user profile, except the private one's

Re-PR of #2523 because of wrong branch.

Previously, the profile page of an user showed all organisations the user owned (regardless if public or not), which makes no sense. After merging this, the profile page will show all organisations the user has joined (not just the one's he owns), except the private (=not public) one's. Just like on GitHub :-)

Thanks again!

Updated on https://try.gogs.io/


TypeError: Cannot read property 'match' of undefined

I am getting this error, while using the scripts.
Please if anyone can give their insight.

The error means it cannot find the server,please make sure you have the correct name and that the script is allowed to access the server and that is not behind a firewall or proxy.

The host name is correct, but I think its in a private network, that is the issue.
If I try to open the ports, and as Azure is on open network (source ip - internet) will it solve my problem ?

It should work
We did setup a build server on our private network that runs this script (and others) that is called from azure, so we didn’t have to expose SAP.

13 maj 2020 kl. 17:31 skrev Himanshu Sharma<EMAIL_ADDRESS>
The host name is correct, but I think its in a private network, that is the issue.
If I try to open the ports, and as Azure is on open network (source ip - internet) will it solve my problem ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Okay, Thank you @matt1as .
For triggering repository, as mentioned, the command is-
- script: |
npm start -- --host= --protocol=http --username= --password=Password --package=
Here I am hard-coding the server credentials. Is there any other way to provide the Details for a secure hit to the server or we have to use only this command.

You can also use env variables to pass the settings , to avoid having them in your script.

20 maj 2020 kl. 09:48 skrev Himanshu Sharma<EMAIL_ADDRESS>
Okay, Thank you @matt1as .
For triggering repository, as mentioned, the command is-

script: |
npm start -- --host= --protocol=http --username= --password=Password --package=
Here I am hard-coding the server credentials. Is there any other way to provide the Details for a secure hit to the server or we have to use only this command.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I am new to JS, plz ignore my silly questions 😜✌. Dotenv file might help here, I think.

No worries.How you set env variables really depends on how you are running the script.
I’ll close this now, but please open a question if you have questions.


No access to ee repository

Hi,
currently the travis build fails because I've an example which uses the ee version of the cockpit.
(No worries, there is no checked in license file)
It looks like that the project is not correctly configured to have access to the ee repository.
How can we fix this?
Cheers,
Patrick

Or maybe @menski has some idea how to fix this?

The problem is we do not offer EE repo access to community extensions. Maybe excluding the example from the maven build and just linking it in the docs might make more sense?

Ok, would also be ok, I just did it, thanks!


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
cba1bc5 -> 1d43759

go (source)
toolchain
patch
1.22.4 -> 1.22.5

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

GitHub release
v2.0.0

Your semantic-release bot :package::rocket:


Fix two missed relative links

Fix two missed relative links by replacing them with intradoc links.

@zeylahellyer I think there is one more in the gateway

@zeylahellyer I think there is one more in the gateway

It looks like it wasn't used anyway, so I've gone ahead and deleted it. Thanks


Image not changin when modding files

Describe your bug here.
I'm trying to change the icons of the charaters. But when i modify the icon it doesn't change in-game. Even modifying assets and even creating mods
Crash Log or logcat logs (if existing)
No response
Are you modding a build from source or with Lua?
I am not modding
What is your build target?
Android
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I only edited the icons images on assets game folder

fixed ig, will include on next devbuild.


Error when doing DE AttributeError: 'NoneType' object has no attribute 'var_names' from loaded model

Hello, I ran into the error below when trying to do DE from a model that was loaded using these 3 lines:
adata=anndata.read('./'+ model_name+'.model/adata.h5ad')
model = scvi.model.SCVI.load(adata, model_name+'.model', use_cuda=True)
de = model.differential_expression( groupby="leiden")

After some poking around, I copied these lines from the intro example, and then the DE ran with no problem:
adata.layers["counts"] = adata.X.copy() # preserve counts
adata.raw = adata # freeze the state in `.raw`

However, I find it odd that I had to run these lines again, because the anndata that I saved was the one that used to train the model. I had not realized that having the adata itself stored in adata.raw was necessary, but given the error, this seems to be the case?

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-125-eb1e0fcfe1d1> in <module>
      1 de = model.differential_expression(
----> 2     groupby="leiden",
      3 )
      4 de.head()

~/anaconda3/lib/python3.7/site-packages/scvi/core/models/rnamixin.py in differential_expression(self, adata, groupby, group1, group2, idx1, idx2, mode, delta, batch_size, all_stats, batch_correction, batchid1, batchid2, **kwargs)
    179         adata = self._validate_anndata(adata)
    180
--> 181         col_names = _get_var_names_from_setup_anndata(adata)
    182         model_fn = partial(
    183             self.get_normalized_expression,

~/anaconda3/lib/python3.7/site-packages/scvi/model/_utils.py in _get_var_names_from_setup_anndata(adata)
    119         adata.var_names
    120         if adata.uns["_scvi"]["use_raw"] is False
--> 121         else adata.raw.var_names
    122     )
    123

AttributeError: 'NoneType' object has no attribute 'var_names'

Could you print
print(adata.uns["_scvi"]["use_raw"])

Right after you load your object?

The adata setup was done (in another notebook) with these lines:
adata.layers["counts"] = adata.X.copy() # preserve counts
scvi.data.setup_anndata(adata, layer="counts", batch_key='experiment')

So I did not do adata.raw = adata which seems to be the problem
Doing print(adata.uns["_scvi"]["use_raw"]) returns False
print(adata.uns["_scvi"]["use_raw"])

Hi @Munfred,
I'm trouble replicating this bug. Below is my code. Do you mind trying it out or posting the exact workflow that led to the error?
import scvi
adata = scvi.data.synthetic_iid()
adata.layers['counts'] = adata.X.copy()

scvi.data.setup_anndata(adata, layer="counts", batch_key='batch')

model = scvi.model.SCVI(adata)
model.train(1)
model.save('tmp', overwrite=True)
model = scvi.model.SCVI.load(a, 'tmp')
model.differential_expression(groupby = 'batch')

Thanks!

@Munfred
Nevermind, I just found the bug.  It's caused by saving the anndata. It turns the boolean into type numpy.bool_, and thus if adata.uns["_scvi"]["use_raw"] is False will always evaluate to False. I will submit a PR to fix this. Thanks for letting us know!
To Reproduce:


Infer individual posteriors using TensorFlow and compare to the found posteriors

[ ] Check that posteriors agree with the found posteriors to build confidence that the interface with TensorFlow works.
[ ] Run inference on hierarchical control growth model.

References:

https://www.tensorflow.org/probability/api_docs/python/tfp/mcmc/HamiltonianMonteCarlo
https://juanitorduz.github.io/tfp_hcm/

Obviously doesn't work because the log-posterior function needs to be composed from tensor operations.


fix: validate only one isbsvc implementation type is defined. Fixes #269

Signed-off-by: David Seapy<EMAIL_ADDRESS>Fixes #269
Validates only one isbsvc implementation type is defined

I think the intention is for only one to be defined, but if that's not the case & both should be able to be defined together then I can work on a different PR to address the issue.

We will have a validatingwebhook provided to prevent this from happening - to switch isbsvc.

We will have a validatingwebhook provided to prevent this from happening - to switch isbsvc.

ok, so you are saying that's a future effort to implement a validating webhook that handles that?  If so sounds like I should create a separate ticket to track that and this PR should be ok as-is?

We will have a validatingwebhook provided to prevent this from happening - to switch isbsvc.

ok, so you are saying that's a future effort to implement a validating webhook that handles that?  If so sounds like I should create a separate ticket to track that and this PR should be ok as-is?

I think so, thanks!


Add toc level class

Add a toc level class attribute to each list item to allow for individual level styling, e.g. class="toc1", class="toc2", etc.

My initial reaction was to push back on this. But in the end I don't really have a good reason to not allow this, especially if someone is willing to do the work. However, before this can be merged, all of the failing tests need to be updated to include the new class in the expected output. Also, a comment needs to be added to the change log.

@waylan Please let me know if this is acceptable or if any further work is required. Thanks

Note that some TOC related tests have been moved to the new framework and now reside in tests/test_syntax/extensions/test_toc.py. However, some older TOC tests have not yet been updated and still reside in tests/test_extensions.py. If any of the old tests need to be modified, then they should be moved to the new location and updated to make use of the assertMarkdownRenders (and dedent if needed) methods.
The same applies to the txt and html files in tests/extensions/. Any tests which need to be modified should be moved to [tests/test_syntax/extensions/test_toc.py and refactored to use the newer framework.
To summarize, we should not be modifying any tests which are not under tests/test_syntax. Instead, those tests should be deleted and new tests should be created under tests/test_syntax to replace them.

In addition to the requested changes above, this should be off by default and have a config option to turn it on.
That said, I don't see this as necessary and am not interested in spending any time working on it myself. If the requested changes are not made soon, I am inclined to simply close this.

In addition to the requested changes above, this should be off by default and have a config option to turn it on.
That said, I don't see this as necessary and am not interested in spending any time working on it myself. If the requested changes are not made soon, I am inclined to simply close this.

I am closing this due to inaction. It can be reopened if/when the requested changes are made.


UI for configmap management

What type of PR is this?
/kind feature

What this PR does / why we need it:

add store management, we use zustand now
ui for configmap management
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

- implement management for configmap under the config
- introduct zustand as store management

/hold

This PR should be reviewed after

https://github.com/karmada-io/dashboard/pull/83
https://github.com/karmada-io/dashboard/pull/85

This PR should be reviewed after

configmap manage #83
feat: update err-check cond, add method for create unstructured resou… #85

The two PRs get merged, but you have to rebase and resolve the conflicts.

This PR should be reviewed after

configmap manage #83
feat: update err-check cond, add method for create unstructured resou… #85

The two PRs get merged, but you have to rebase and resolve the conflicts.

I'll solve conflicts asap~.

This PR should be reviewed after

configmap manage #83
feat: update err-check cond, add method for create unstructured resou… #85

The two PRs get merged, but you have to rebase and resolve the conflicts.

After rebase main, this PR seems much smaller than before 😄 .
@RainbowMango  Let's move forward~

/hold cancel


JavaScript/TypeScript: false positive Semicolon Insertion in template string

Copied over from https://github.com/lgtmhq/lgtm-queries/issues/50
I don't see where a semicolon would be missing.
if (arg.startsWith('-'))
    throw new ConfigurationError(`Unknown option '${arg}'.`);

@asger-semmle, could you take a look at this?

Thanks again for your report. We are working on a fix, but in the meantime we have disabled the semicolon insertion rule for TypeScript, so you should not be seeing this alert any more.

This has now been fixed and the rule has been re-enabled.


chore: remove repetitive words globally

use https://github.com/Abirdcfly/dupword to check duplicate words
output:
celestia-node/share/eds/retriever_quadrant.go:71:4: Duplicate words (into) found
celestia-node/share/availability/full/reconstruction_test.go:179:2: Duplicate words (L) found
celestia-node/share/getters/getter_test.go:338:2: Duplicate words (D) found
celestia-node/share/p2p/peers/manager_test.go:86:3: Duplicate words (be) found

hi @goofylfg thank you! I thought i had caught all these 😄
Generally, we tend NOT to accept simple grammar/spelling fixes. That said, this project uses golangci-lint and has a CI integration to run it. It also appears dupword can be enabled https://golangci-lint.run/usage/linters/#dupword.
It appears it would be fairly trivial to enable dupword in our config, and modify this PR so the contribution is enabling dupword in our linter, then have the fixes accompany that as a change. This is something we'd appreciate and accept.
Would you be interested in giving it a go?

hi @goofylfg thank you! I thought i had caught all these 😄
Generally, we tend NOT to accept simple grammar/spelling fixes. That said, this project uses golangci-lint and has a CI integration to run it. It also appears dupword can be enabled https://golangci-lint.run/usage/linters/#dupword.
It appears it would be fairly trivial to enable dupword in our config, and modify this PR so the contribution is enabling dupword in our linter, then have the fixes accompany that as a change. This is something we'd appreciate and accept.
Would you be interested in giving it a go?

sure, I will add dupword CI integration.

celestia-node/share/eds/retriever_quadrant.go:71:4: Duplicate words (into) found
celestia-node/share/availability/full/reconstruction_test.go:179:2: Duplicate words (L) found
celestia-node/share/getters/getter_test.go:338:2: Duplicate words (D) found
celestia-node/share/p2p/peers/manager_test.go:86:3: Duplicate words (be) found

"L","D" is false positve, so I added it to ignore list. @ramin  plz check it ~

@goofylfg oh awesome nice job! My only request would be to do //nolint:dupword for those _test.go files (either whole file, or the area with the false positive) vs adding to config for single letters like that, then IMO it's gtg

@goofylfg oh awesome nice job! My only request would be to do //nolint:dupword for those _test.go files (either whole file, or the area with the false positive) vs adding to config for single letters like that, then IMO it's gtg

fixed, thks for the feedback @ramin


GD-XXX: Running a single test case runs all of them

The used Test Adapter version
1.1.1
The used Godot version
v4.2.2.stable.mono.official [15073afe3]
Operating System
Windows 11
Describe the bug
Running a single TestCase for a test method from the Visual Studio Test explorer window runs all the test cases, at least in Debug mode.
Steps to Reproduce

Creata a test like described below
Set a breakpoint inside the test method on the assertion
Use the Visual Studio Test Explorer window and right click on a single test case, select Debug from the dropdown

The test will be run for each TestCase attribute and the breakpoint hit, with value going through 0, 1, 2
namespace Examples;

using GdUnit4;

[TestSuite]
public class TestClass1 {
	[TestCase(0)]
	[TestCase(1)]
	[TestCase(2)]
	public void Test1(int value) {
		Assertions.AssertInt(value).IsEqual(7);
	}
}

Minimal reproduction project
No response

this is related to #27


Hide company name, rating and comment if it has not more than 5 users having set their salaries

some test will be broke with this feature 😅


fix: add hardcoded utc prefix to crontab

Fixes #943
Description
Karpenter releases are built with UTC, but this adds a "TZ=UTC" prefix to valid schedules for budgets to ensure that the underlying cron library always parses the schedule in UTC time.
How was this change tested?
make apply with kwok and test different schedules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 80.985%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
95.51%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
8160

Relevant Lines:
10076

💛  - Coveralls

/lgtm


ResourceFlavor nodeLabels not added to .nodeSelector field on Pods

What happened:

Based on the documentation: https://kueue.sigs.k8s.io/docs/concepts/resource_flavor/, the expected behavior is that nodeLabels defined in each ResourceFlavor will be propagated to the .spec.template.spec.nodeSelector field for any Pod when is executed in the same queue.
After configuring a ResourceFlavor with a nodeLabel defined and linked to the ClusterQueue, and running jobs in this queue, the nodeLabels seem that are not propagated to the .spec.template.spec.nodeSelector of each Pod.

What you expected to happen:

nodeLabels defined on the ResourceFlavor should appear on the nodeSelector field of the Pods.

How to reproduce it (as minimally and precisely as possible):

Create a manifest (gpu-clusterqueue.yaml) defining all the Kueue components: ClusterQueue, LocalQueue, ResourceFlavor

apiVersion: kueue.x-k8s.io/v1beta1
kind: ResourceFlavor
metadata:
  name: "gpu-flavor"
spec:
  nodeLabels:
    karpenter.k8s.aws/instance-gpu-count: "1"
    karpenter.k8s.aws/instance-gpu-name: t4
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "gpu-clusterqueue"
spec:
  namespaceSelector: {} # match all.
  resourceGroups:
  - coveredResources: ["cpu", "memory"]
    flavors:
    - name: "gpu-flavor"
      resources:
      - name: "cpu"
        nominalQuota: 16
      - name: "memory"
        nominalQuota: 32Gi
---
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  namespace: "kueue-system"
  name: "gpu-queue"
spec:
  clusterQueue: "gpu-clusterqueue"

Create a manifest (sample-job-gpu.yaml) for a Job definition, adding the appropriate annotation (kueue.x-k8s.io/queue-name: gpu-queue) to run the Job in the previous queue configuration.

apiVersion: batch/v1
kind: Job
metadata:
  namespace: kueue-system
  name: sample-job-gpu
  annotations:
    kueue.x-k8s.io/queue-name: gpu-queue
spec:
  parallelism: 3
  completions: 3
  template:
    spec:
      containers:
      - name: dummy-job
        image: gcr.io/k8s-staging-perf-tests/sleep:latest
        args: ["3600s"]
        resources:
          requests:
            cpu: "500m"
            memory: "512Mi"
          limits:
            cpu: "500m"
            memory: "512Mi"
      restartPolicy: Never

Execute the previous Job definition:

$ kubectl create -f sample-job-gpu.yaml
job.batch/sample-job-gpu created

Verify that Pods are running

$ kubectl get pods
NAME                                        READY   STATUS    RESTARTS   AGE
kueue-controller-manager-84b7595fbd-bflgt   2/2     Running   0          81m
sample-job-gpu-98hlr                        1/1     Running   0          15s
sample-job-gpu-dwwln                        1/1     Running   0          15s
sample-job-gpu-kqpsj                        1/1     Running   0          15s

Describe one Pod running from the previous execution and verify that the nodeSelector field remains as <none>

kubectl describe pod sample-job-gpu-98hlr
Name:             sample-job-gpu-98hlr
Namespace:        kueue-system
Priority:         0
Service Account:  default
Node:             (censored)
Start Time:       Thu, 29 Jun 2023 14:56:06 +0000
Labels:           controller-uid=401eaa8d-3985-43a6-9f53-61d731efcca8
                  job-name=sample-job-gpu
Annotations:      kubernetes.io/psp: eks.privileged
Status:           Running
IP:               (censored)
IPs:
  IP:            (censored)
Controlled By:  Job/sample-job-gpu
Containers:
  dummy-job:
    Container ID:  containerd://ac5e7421bad6916e168edbdcbc45ae2444500943602e4a582499d192ef7b44c1
    Image:         gcr.io/k8s-staging-perf-tests/sleep:latest
    Image ID:      gcr.io/k8s-staging-perf-tests/sleep@sha256:00ae8e01dd4439edfb7eb9f1960ac28eba16e952956320cce7f2ac08e3446e6b
    Port:          <none>
    Host Port:     <none>
    Args:
      3600s
    State:          Running
      Started:      Thu, 29 Jun 2023 14:56:07 +0000
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     500m
      memory:  512Mi
    Requests:
      cpu:        100m
      memory:     512Mi
    Environment:  <none>
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-92jlf (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  kube-api-access-():
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  42s   default-scheduler  Successfully assigned kueue-system/sample-job-gpu-98hlr to  (censored)
  Normal  Pulling    41s   kubelet            Pulling image "gcr.io/k8s-staging-perf-tests/sleep:latest"
  Normal  Pulled     41s   kubelet            Successfully pulled image "gcr.io/k8s-staging-perf-tests/sleep:latest" in 417.789009ms
  Normal  Created    41s   kubelet            Created container dummy-job
  Normal  Started    41s   kubelet            Started container dummy-job

Anything else we need to know?:

Reproduced this on releases v0.3.1 and v0.3.2
The install was patched to allow MPIJob framework from Kubeflow, and to avoid interferences with other namespaces using Karpenter. (Described at the bottom)

Environment:

Kubernetes version (use kubectl version):

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:36:36Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"24+", GitVersion:"v1.24.14-eks-c12679a", GitCommit:"05d192f0de17608d98e17761ad3cffa9a6407f2f", GitTreeState:"clean", BuildDate:"2023-05-22T23:41:27Z", GoVersion:"go1.19.9", Compiler:"gc", Platform:"linux/amd64"}

Kueue version (use git describe --tags --dirty --always):
Tested both on: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.3.2 and https://github.com/kubernetes-sigs/kueue/releases/tag/v0.3.1

Cloud provider or hardware configuration:
AWS EKS

OS (e.g: cat /etc/os-release):

System Info:
  Kernel Version:              5.4.226-129.415.amzn2.x86_64
  OS Image:                    Amazon Linux 2
  Operating System:            linux
  Architecture:                amd64
  Container Runtime Version:   containerd://1.6.6
  Kubelet Version:             v1.24.7-eks-fb459a0
  Kube-Proxy Version:          v1.24.7-eks-fb459a0

Kernel (e.g. uname -a):
Kernel Version: 5.4.226-129.415.amzn2.x86_64
Install tools:
Kueue deployed via ARGOCD (kustomization.yaml) following the instructions here: https://kueue.sigs.k8s.io/docs/installation/#install-a-custom-configured-released-version

namespace: kueue-system
resources:
- https://github.com/kubernetes-sigs/kueue/releases/download/v0.3.2/manifests.yaml
- ondemand-clusterqueue-setup.yaml
- spot-clusterqueue-setup.yaml
- gpu-clusterqueue-setup.yaml
configMapGenerator:
- namespace: kueue-system
  name: kueue-manager-config
  behavior: replace
  files:
  - controller_manager_config.yaml
patches:
  - path: kueue-karpenter-patch.yaml
    target:
      group: admissionregistration.k8s.io
      name: kueue-mutating-webhook-configuration
      kind: MutatingWebhookConfiguration
      version: v1

Controller configuration modified to allow the MPIJob framework (controller_manager_config.yaml):
apiVersion: config.kueue.x-k8s.io/v1beta1
kind: Configuration
health:
  healthProbeBindAddress: :8081
metrics:
  bindAddress: :8080
webhook:
  port: 9443
leaderElection:
  leaderElect: true
  resourceName: c1f6bfd2.kueue.x-k8s.io
controller:
  groupKindConcurrency:
    Job.batch: 5
    LocalQueue.kueue.x-k8s.io: 1
    ClusterQueue.kueue.x-k8s.io: 1
    ResourceFlavor.kueue.x-k8s.io: 1
    Workload.kueue.x-k8s.io: 1
clientConnection:
  qps: 50
  burst: 100
#waitForPodsReady:
#  enable: true
#manageJobsWithoutQueueName: true
#namespace: ""
#internalCertManagement:
#  enable: false
#  webhookServiceName: ""
#  webhookSecretName: ""
integrations:
  frameworks:
  - "kubeflow.org/mpijob"

Karpenter patch to avoid interfering with other namespaces when the cluster downscales (kueue-karpenter-patch.yaml):
- op: replace
  path: /webhooks/0/namespaceSelector
  value:
    matchExpressions:
    - key: kubernetes.io/metadata.name
      operator: NotIn
      values:
      - karpenter

Others:

/close
user error :)


Whois server name return

Description

When using the library, one cannot tell which server has returned the result. It could be an advantage to have a possibility to query the name of the server that has served the last request, to see if something goes wrong.
Example

$ts = microtime(true);
$domain = 'somedomain.tld';
$result = $this->whois->isDomainAvailable($domain) ? 'free' : 'busy';
$elapsed = microtime(true) - $ts;
$serverName = $this->whois->getLastServer(); // New method that returns the server name responsible for the last result
$this->log(sprintf(
  "Whois data for %d was served by %s, resullt:%s, obtained in %f seconds",
  $domain,
  $serverName,
  $result,
  $elapsed
));

Added in https://github.com/io-developer/php-whois/commit/8f620163da45cac2f0671f54d161b868af40ce6d
Also used parser type added to DomainInfo - https://github.com/io-developer/php-whois/commit/fddcff3abe65dc64333353c02083cd1bc847bc88


[Bug]: RAG inference context null

Contact Details(optional)
No response
What happened?
When making request to inference API for RAG completion the context is always null.
Version
v0.2.1
Relevant log output
[nodemon] starting `node --disable-warning=ExperimentalWarning index.js`
VOYAGER is running on port 8000, happy sailing!
file:///app/actions/inference.js:227
        { role: "system", content: `This background information is useful for your next answer: "${rag_result.context}"` }
                                                                                ^

TypeError: Cannot read properties of null (reading 'context')
    at ragChatCompletion (file:///app/actions/inference.js:227:111)

Node.js v20.15.1

@cbh778899 @Aisuko

In the latest version, you should load the dataset first using POST /v1/embeddings/dataset and call the rag engine with the loaded dataset name. Still, I'll add validation on null values later.

@cbh778899 Do we have some demo for how to load dataset? like video, or test case? If not, may you create an issue for it?

just run the try it out in swagger docs can load the dataset, the variables are written there

Here is the new video https://github.com/SkywardAI/voyager?tab=readme-ov-file#setup-and-api-usage-demo-video and it includes how to load the data from Swagger cc @Murkeee


Find unused datasets

Describe the solution you'd like
The function should return all datasets who are not used in any pipeline. The function should be in [adf] class.
The result could be pass to cmdlet in order to delete them.
Additional context
Martin Zurita created this script to do this: https://gist.github.com/Gorgoras/9faca9a726e874489c2b1d76078764e4
import os

# set repo location and ADF name
repo_path = "D:/Work/Python/Azure"
dataFactory_name = "Highwayman-ADFv2"
full_path = "/".join([repo_path, dataFactory_name])

# get list of dataset and pipeline files
datasets = os.listdir("{}/dataset".format(full_path))
pipelines = os.listdir("{}/pipeline".format(full_path))

# just the name of the dataset, without .json
list_datasets = [x.split(".")[0] for x in datasets]

# iterate over pipelines looking for dataset names
for i in range(0, len(pipelines)):
    f = open("{}/pipeline/{}".format(full_path, pipelines[i]), "r")
    stringPipe = f.read()

    for o in range(0, len(list_datasets)):

        # if the dataset is being used, replace it with ''
        if list_datasets[o] in stringPipe:
            list_datasets[o] = ""

    # remove used datasets from the list
    list_datasets = [s for s in list_datasets if s != ""]

# datasets not removed are the ones not being used
print("These are your datasets that are not being used.")
print(list_datasets)

I'm thinking about implementing the option to do a "soft delete" that just removes the dataset from the object $Adf, but does not delete the actual json file. By doing this, it will not be deployed but it will still exist.
What are your thoughts on this approach? Should I include a parameter -SoftDelete to check for this?


Merge branches into main

Hi @C-H-Simpson  @acocac , any objection to merging the branches with your work on into the "main" branch?
I think it's nice if people can see the examples when they first land on the repo...  If you don't have any objections, I can do this later this week?

Nick, np. Once merged I can improve documentation if necessary.

No objections here


Stop ChartContainer from rendering twice on chartStatus change

Before:

ChartContainer renders twice for each query, one rendering happened when ChartStatus changed from previous status to loading, another at ChartStatus switching from loading to success

spinner position is relative, shifting chart downwards while loading

After:

renderVis is only called when ChartStatus is changed to loading (meaning ChartUpdate started), or if there's a height change (at browser window resize)
chart is dimmed while loading and spinner is put on top as overlay
timeout is added to resize handler to prevent over-triggering

needs-review @ascott @mistercrunch

Nice, check out https://github.com/airbnb/superset/issues/1826 for related items

LGTM as is, the only thing missing from that issue is to run resize when window is resized. I had a good hanlder in v1 that would not over-trigger. It's nice to know the drag event is 100% done before running potentially expensive resize (lots of viz just point their resize to re-render).

LGTM.

In the end it turned out render() and resize() has to be called after mounting, otherwise the slice will refer the old ref instead of newly mounted ones.


bug: RPM repo PGP check fails

What happened:
When trying to upgrade package using official Yum repo this occurs:
Running transaction
Transaction failed: Signature verification failed.
PGP check for package "kubectl-1.31.3-150500.1.1.x86_64" (/var/cache/libdnf5/kubernetes-3d554b2ea1b53740/packages/kubectl-1.31.3-150500.1.1.x86_64.rpm) from repo "kubernetes" has failed: Problem occurred when opening the package.

What you expected to happen:
Update succeeds and package installed.
How to reproduce it (as minimally and precisely as possible):

Add repo following https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-using-native-package-management and try to update RPM package.
Anything else we need to know?: It worked until now.
Environment:

Kubernetes client and server versions (use kubectl version): kubectl-1.31.3-150500.1.1.x86_64
Cloud provider or hardware configuration: n/a/
OS (e.g: cat /etc/os-release): Fedora Linux 41

It is better to transfer it to main repo for visibility
/transfer kubernetes


Issue: Backup download from admin site shows the auth type as guest

Is this the intended behavior? Or could this also be a security vulnerability. Thank you for all the work you do on this. I am also on version 0.22.17, so not sure if this was fixed in a later update. I do not see any release notes that indicate so.
See the screenshot below

It is just an implementation detail, it is not a security issue.
The auth field in the logs indicates whether the request was sent with valid Authorization:TOKEN header, but backups download and protected files doesn't use the Authorization header and instead rely on a short-lived token send with the file GET request.
We also have automated tests that verify that backups are accessible only by admins - https://github.com/pocketbase/pocketbase/blob/5547c0deded8f9cc329cd6f0670aef19e2a3001a/apis/backup_test.go#L338.
In any case, if you think that something is a security issue the safest way will be furst to report it either via the GitHub security advisory or at support [at] pocketbase.io as  mentioned in the Security policy


feat: Integrate external secrets

Adds kubernetes-external-secrets so AWS Secrets Manager can be used in favour of k8s secrets.

Can you add an Issue to track adding of an api to add namespace restrictions and ExternSecret


TraceUpload.zip includes an old version of Microsoft.AspNetCore.Http.Features.dll, which has security vulnerabilities

Not sure if this is the right way to report this as it is a potential security issue but the MSRC rejected my report (VULN-107830) saying that I should update .NET to solve the problem, which obviously doesn't work.
When I build my app that includes Microsoft.ApplicationInsights.Kubernetes and Microsoft.ApplicationInsights.Profiler.AspNetCore, it outputs a file called TraceUpload.zip.
This zip contains v2.1.1 of Microsoft.AspNetCore.Http.Features.dll, which is old and Veracode says it has a DoS vulnerability (CVE-2022-21986).

Duplicate of #2779.
Hi @scott-moxham, thanks for reporting the issue.
There is a transitive dependency where our SDK pulls in v2.1.1 of Microsoft.AspNetCore.Http.Features.
I took a look at this a few months ago and determined that this is not a problem for our SDK.
Please take a look at the previous issue where I have a detailed description, screenshots, and some related links.
In summary, the resolution is to update your .NET runtime and the runtime will pull in a higher version of this dependency.
This can be seen by debugging your application and inspecting the loaded Modules.

Thanks for your reply @TimothyMothra
When I run my app, it does show the version of Microsoft.AspNetCore.Http.Features loaded as being 7.00.523.17410, but this does beg the question, why is the old version of the dll being included in the zip file if it just loads the latest version from the runtime anyway?


HP Packages seem to fail to extract

Using version 6.5.2 of DriverAutomationTool HP Driver packages are not created correctly (a ~200 KB self extracting file is being generated). When I've looked in the Dowloads folder the "extracted" folder ("Windows10-20H2-x64-12.00 A 1") is empty. I've reported similar issue to creator of OSDDrivers - apparently HP's silent extraction switches have changed.

Give the latest beta build a try, I was getting errors with HP drivers but this beta seems to work for me:
https://github.com/maurice-daly/DriverAutomationTool/tree/master/Beta Builds/6.5.4


Databricks: Query has been timed out due to inactivity

Describe the bug
A clear and concise description of what the bug is. What command did you run? What happened?
Pat from dbt Labs here!
This is not in relation to our company accounts.
We have seen a couple customers reach out to us about long running jobs in dbt and upon investigation seems like one of the models / threads will timeout and fail on Databricks side but we don’t receive notice on our end, so we keep running the job until it hits the job timeout (or 24 hours if they do not have a timeout set up).
This is particularly confusing to us because we don't receive word that it timed out and therefore do not Error out the job.

Steps To Reproduce
In as much detail as possible, please provide steps to reproduce the issue. Sample data that triggers the issue, example model code, etc is all very helpful here.
This seems to be sporadic, only happening sometimes, and seems to happen to create, update, and hook type statements.
The timeouts are oddly usually less than 60 seconds.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots and log output
If applicable, add screenshots or log output to help explain your problem.
System information
The output of dbt --version:
1.4.6 and 1.5.0

Additional context
Add any other context about the problem here.
Collected affected IDs.
01edf77d-7a7b-1fab-a04a-3e572068f2a3
01edff96-b864-12e3-ac83-fd01c999ccbb
01ee00f1-9a9f-118c-bd98-64d8f7aedb56
01edfede-7028-1c28-8eb7-e3446ab134c6
01edffb6-2103-1745-ba32-3fe67df11f7a
01ee00b7-dcdd-10f7-a139-e0a93791ef9a
We also opened up a support ticket:
Ticket Detail:
Ticket Number: #00331582
Subject: dbt <> Databricks Timeout Issue
Ticket URL: https://help.databricks.com/s/case/5008Y00002A5sWS
Unique TicketId: [ ref:_00D61JGc4._5008Y2A5sWS:ref ]

Thanks. This is an issue in Databricks (not dbt-databricks) that we are actively working on. Latest version of the adapter has a workaround to prevent connection waiting forever. Updating to version 1.5.4 will mitigate the issue.

Will close this issue as it is not a dbt-databricks issue. The fix is currently being rolled out in production on Databricks side.

Got it, thank you!


EventSource's response has a MIME type ("text/html") that is not "text/event-stream".

Environment
Nuxi 3.1.2
                                                                                18:07:36
RootDir: /Users/ps//Development/webapp
Nuxt project info: (copied to clipboard)

------------------------------
- Operating System: `Darwin`
- Node Version:     `v18.2.0`
- Nuxt Version:     `2.17.0-27947541.7f76ace`
- Nitro Version:    `1.0.0`
- Package Manager<EMAIL_ADDRESS>- Builder:          `webpack`
- User Config:      `ssr`, `target`, `server`, `env`, `head`, `plugins`, `buildModules`, `router`, `serverMiddleware`, `css`, `components`, `modules`, `sentry`, `axios`, `build`, `serverHandlers`, `devServerHandlers`, `devServer`, `typescript`, `bridge`
- Runtime Modules:  `<EMAIL_ADDRESS>`<EMAIL_ADDRESS>- Build Modules:    `()`, `<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>------------------------------

Reproduction
My nuxtjs version was
nuxt - 2.15.8
I have followed this:-
https://nuxt.com/docs/bridge/overview#feature-flags
Describe the bug
Everything works ok now, but i get this error
EventSource's response has a MIME type ("text/html") that is not "text/event-stream". Aborting the connection.

Looks like some web socket request is fired. This error only comes when you do refresh the pageI
Additional context
No response
Logs
No response

To understand the core of the issue
https://www.daniweb.com/programming/web-development/threads/468769/server-sent-events-sse

text/event-stream is the official media type for Server Sent Events (SSE); it will prefix data bits with a data: prefix and you can also choose your prefix to change the meaning of that piece of data for the client. This media type is for browsers, as they support that using the EventSource JavaScript API.

I am also experiencing this (and webpackHotUpdate is not defined) after updating to Nuxt bridge today.

It is solved for me
  hooks: {
    ready(nuxt) {
      // Write this hook in nuxt.config.js
      nuxt.hook('server:devMiddleware', async (devMiddleware) => {
        await nuxt.callHook('server:devHandler', fromNodeMiddleware(devMiddleware));
      }); */
    },
  },

@psahni what does that solve for you? I am still getting the webpackHotUpdate error, as well as the MIME type error. Hot module reloading is still not working for me.

@galaxyblur
Have u deleted node_modules and installed again
Seems webPackHotUpdate plugin is not installed
Nuxt bridge installs webpacker and hotReloading module
https://github.com/nuxt/bridge/blob/c80e571b42d715d362f0b40161641043cedbe2ee/packages/bridge-schema/build.config.ts

Thanks, I tried deleting node_modules and reinstalling, but the error persists. I noticed it only happens when I make a code change after the initial build.

@galaxyblur
Try this:-
rm yarn.lock
rm package-lock.json
yarn cache clean
yarn install

I was using nuxt 2.15 and I upgraded it to nuxt bridge
But I am facing, template compilation issues and I have rollback everything.
I will wait for offcial guide migrating to Nuxt3
Cheers

Thanks @psahni -- I was missing the correct import statement for fromNodeMiddleware:

@galaxyblur
Oh I also faced this issue
Glad it is now resolved for u.
👍


Typescript Playground > tsconfig exactOptionalPropertyTypes option is ignored if set via URL parameter

Bug Report

🔎 Search Terms
exactOptionalPropertyTypes
typescript playground
🕗 Version & Regression Information
Since TS4.4 beta including nightly.

I was unable to test this on prior versions because this is a new option

⏯ Playground Link
The following playground link was generated by the share button.
https://www.typescriptlang.org/play?ts=4.4.0-beta&exactOptionalPropertyTypes=true#code/JYOwLgpgTgZghgYwgAgArQM4HsTIN4BQyxyIcAthAFzIZhSgDmANESXIxAPw0gCu5AEbQA3AQC+BAghx1kAB0w4a6KNlwBefG2JlKNAEQAROCGAQANgdYlkHasgBMAdgliCAE0sRICpSAA6exFiAHpQ5AAVAAsULEUoUw9kLBg7ZAByLwsfCAyUhLgwLChkcj45YQKwYBw4CwCpAiA
It includes the following parameter which was added automatically:
exactOptionalPropertyTypes=true

However when visiting the link the option reverts back to being unset, which can be evidenced by the lack of an error in the line of code delete person.age.
Not sure if this was because the property was recently renamed or if it had never worked under its original name.

Please assign to @orta as per @sandersn - https://github.com/microsoft/TypeScript/pull/43947#issuecomment-881055949

Fixed by https://github.com/microsoft/TypeScript-Website/pull/1940 - will close this issue now, expect the fix to get deployed sometime this week, likely today


Add IsEnabled Property To Control

I have got a task today to make some inputs not focusable and not editable. As I skimmed through the properties I couldn't find any way to do it what really surprised me so I did it myself, I think it might be usefull for others. Blocking input isn't uncommon.

Hello,
Could we call the property isEnabled to be consistent with the BabylonJS Node class ?

Sure. I will make changes asap

@barteq100 I am wondering if this should also be added to other controls for consistency ?
Also, it would be really cool if you could drop a line in the dist/preview release/whatsnew.md file for the nice addition.

@sebavan sure I can do it for csistency but I need this change asap and changing all controls will take a moment.

@barteq100  Sure, no problem I can integrate this one first and then you ll have more time for the other controls.
Could you just add the line in the whats new file so that I can merge ?

@sebavan
Done

I ll test and merge in the afternoon, thanks again for the contribution.