Add support for Consistent Hashing with Bounded Loads

What version of Traefik are you using (traefik version)?
v1.1.2
What is your environment & configuration (arguments, toml...)?
ECS backend
What did you do?
Decided to suggest adding support for consistent hashing with bounded loads, as detailed in this paper by Mirrokni, Thorup, and Zadimoghaddam. This allows some nice things:

Good load-balancing on scaled services of same type
Good load-balancing for different requests (by id)
Stickyness for same request (by id) via consistent hashing, also for "second best" in case of overloading
More information can be found in this lovely writeup by Andrew Rodland from Vimeo.

What did you expect to see?
Community enthusiasm.
What did you see instead?
You tell me.

Would this example implementation help?
http://www.tom-e-white.com/2007/11/consistent-hashing.html

Is this on the roadmap for Traefik v2?

Is this on the roadmap for Traefik v2?

As an example of why this is important: This and #1207 are the things keeping us at famedly.com from scaling up matrix.org deployments further efficiently. Users pass their access tokens in headers or query parameters, and a lot of the caches are more efficient per user (and even more so per session). Just using regular round robin means we'll need a lot more RAM and will still get less cache hits.
If we worked on an implementation for this, would this be likely to be merged? Is there a place to discuss this? I saw that #2613 was closed with a note that it should've been discussed on slack first, is this still applicable? Couldn't see a mention of it on the contributing guidelines.

In general, I think it'd be useful to look at how haproxy does this, because it gives all the flexibility one would ever need. The downsides are a memory unsafe language and a very peculiar config style, so if we could get this done with traefik instead, I'd be a lot happier, even if that means throwing some resources at it ourselves to get it working.

@jcgruenhage I'm trying to scale up synapse on docker swarm and it causes a lot of issues with the cookie based stickiness, which traefik provides. I wonder if cookies are even supported/used by matrix clients?  I see messages getting mixed up in their order of sending, messages popping up as unseen again and again, bots stop working etc.
So I wonder how do you even scale up synapse with traefik?

@jcgruenhage I'm trying to scale up synapse on docker swarm and it causes a lot of issues with the cookie based stickiness, which traefik provides. I wonder if cookies are even supported/used by matrix clients?  I see messages getting mixed up in their order of sending, messages popping up as unseen again and again, bots stop working etc.
So I wonder how do you even scale up synapse with traefik?

Are you just runnung a second instance of synapse? You really, really don't want to do that. https://github.com/matrix-org/synapse/blob/develop/docs/workers.md contains the docs how to properly scale. The issues you're describing aren't related to this traefik issue.
This traefik issue being fixed will increase performance, but even without it, it should still work correcrly (although with higher resource usage and worse performance)

Are you just runnung a second instance of synapse? You really, really don't want to do that. https://github.com/matrix-org/synapse/blob/develop/docs/workers.md contains the docs how to properly scale. The issues you're describing aren't related to this traefik issue.
This traefik issue being fixed will increase performance, but even without it, it should still work correcrly (although with higher resource usage and worse performance)

@jcgruenhage wow thank you so much for pointing this out!
I was just scaling out my main synapse service. This created two main instances, which accessed the same files via glusterfs and the same postgres. This is why everything went haywire!
I've now added a separate service of workers to my stack. I used this image and wrote a little script, which copies a predefined worker.yaml and sets the worker name to the docker container ID. Works amazingly well!

@jcgruenhage wow thank you so much for pointing this out!
I was just scaling out my main synapse service. This created two main instances, which accessed the same files via glusterfs and the same postgres. This is why everything went haywire!
I've now added a separate service of workers to my stack. I used this image and wrote a little script, which copies a predefined worker.yaml and sets the worker name to the docker container ID. Works amazingly well!

@ggogel, small follow up: This here starts being helpful once you have more of one worker of a certain type

@ggogel, small follow up: This here starts being helpful once you have more of one worker of a certain type

Hey there, I'm facing the same issue while trying to scale out Collabora CODE on Kubernetes.
As per documentation and research, one can use simple annotations with nginx ( nginx.ingress.kubernetes.io/upstream-hash-by: "$arg_WOPISrc")  and haproxy (haproxy.org/backend-config-snippet: |\n      balance url_param WOPISrc check_post\n      hash-type consistent) as ingress controllers to achieve loadbalancing based on a URL parameter.
In this case it is used to send users, editing the same document to the same document server backend.

This is actually super vital for things like collabora, imho it should be more than a "nice to have" on the roadmap.
As it actually makes traefik ingress unusable for specific usecases.


XDMA Advanced topics

Hello! I'm glad to see more interesting experiments!
I saw you posted a link to Xilinx DMA PCIe Tutorial by Roy Messinger. in XDMA Communitcation. I read it. He implements XDMA with descriptor bypass, which is interesting but not became clear what exactly happens. He uses polling mode which is wasteful of CPU threads (energy).
Do you plan to test the descriptor bypass feature ? It seems supported by the driver w/o modification.
AFAIK it is convinent when the memory is not contiguous.
Also, I try to imagine how they do c2h double buffering in stream mode - there should be a buffer on the host and the user/driver should get notification/IRQ when a buffer is filled so to replace it with another while the DMA is writing into its current buffer.

Yes, my understanding of the use case for descriptor bypass is to sequence non-contiguous memory accesses (scatter-gather). I do not see how it would improve large contiguous transfers or AXI-Stream when using XDMA.
The Xilinx DMA PCIe Tutorial may be a bit too out of date now. With the current state of the XDMA driver there is no need to organize DMA transfers.

c2h double buffering in stream mode

Don't know. I would focus on FIFOs and the _tready signal(1). Best performance comes from having large enough FIFOs to allow data to flow from/into your application as soon as it is ready.

What I was thinking is that (still haven't read the xdma driver source) the XDMA driver setups each transfer (maps buffers?) before submit it to the BM DMA of the IP Core in the FPGA, which leads to DMA engine idling. So they provided 4 channels to somehow allow an user app to counter that by submitting overlapped requests to the 4 channels. How I imagine descriptor bypass should work:

somebody (user app, driver) allocates nc buffers and creates SG descriptor tables for them also in nc memory.
driver setups the address of the first SG descriptor. The last descriptor closes the ring, pointing to the first descriptor as next_descriptor. The descriptors have flags, which the IP core checks to know whether to stop, it also (optionally) marks which descriptor has been used (written to the memory block).
when the start is issued, the IP core reads the first descriptor, initiates DMA over PCIe to it, and initiates prefetch of N next descriptors in cache BRAM so the next TLP to have readily available PHY memory address.
somehow the driver should get notification to process an available block of data - either by MSI, generated by some criteria (threshold of written memory blocks). It can intervene and switch the next_descriptor of the last descriptor for example to point to a new group of descriptors, so to enable the currently available block of data to be processed without worry of being overwritten in the meantime and to allow memory copy to be avoided.
I'll dig into the driver once i manage to start the test pattern generator and video write buffer to work (shame on me).

Yes, for XDMA MM (Memory-Mapped) the 4 channels are interchangeable and each corresponds to a thread so you can overlap read/write requests and let the driver sort things out.
For XDMA Stream, each C2H/H2C channel corresponds to its own circuit, S_AXIS_C2H_?/M_AXIS_H2C_?. If you are working on Video I recommend you look into the AXI4-Stream Video Tutorials, pg231, and ug934.
XDMA Descriptor Bypass mentions there is an 8-deep queue for descriptors.
I stumbled across the Descriptor Bypass Controller for Xilinx XDMA project that I will look through.

Since we are at discussion of advanced topics, what the DMA bypass (not to be confused with descriptor bypass) is good for?

My best guess is to be able to implement your own DMA engine. If your project has defined and specific access sequences you should be able to optimize for it.

My best guess is to be able to implement your own DMA engine. If your project has defined and specific access sequences you should be able to optimize for it.
That is what descriptor bypass is for.
DMA bypass seems to acts like integrated  AXI-bridge, similar to standalone option for US+. Probably for small size low latency access.


Shen 22.0 Upgrade

[x] New version of kernel, load init.kl, call shen.initialise.
[x] Include feature-expand and provide feature symbols.
[x] Use launcher extension in npm run repl.

@tizoc Example feature list is [shen-script js node windows]. Is that reasonable or what is the standard? Should it be shen/script instead of shen-script?

@rkoeninger sounds good to me. For Shen/Scheme I only added shen/scheme for now, will give it more thought in the future (I missed the symbol for the operating system, but will do that in the next release).
shen-script is fine btw, I use shen/scheme because thats the name of the port, not because the slash has any special meaning.

I'm having trouble with the launch extension. In node, process.argv is returning:
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\Users\\koeningerr\\Workspace\\Me\\ShenScript\\scripts\\repl.js' ]

which I convert to a cons list of course. Trying to run with no additional arguments prints:
ERROR: Invalid argument: C:\Users\koeningerr\Workspace\Me\ShenScript\scripts\repl.js
Try `C:\Program Files\nodejs\node.exe --help' for more information.

shen.exe can't run without any arguments now?

@rkoeninger the node.exe part has to be excluded, the first element in the list has to be the program that launches Shen itself.


fix: remove invalid examples in native.js for @stdlib/math/base/special/fibonacci

Description
This PR removes invalid examples in native.js for @stdlib/math/base/special/fibonacci, which were the non-integer and NaN input examples, as suggested here.

What is the purpose of this pull request?

This pull request:

removes invalid examples in native.js for @stdlib/math/base/special/fibonacci.

Related Issues

Does this pull request have any related issues?

n/a
Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

☑ Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

LGTM. I restored the negative integer example, as it is handled by the C implementation, as n can be an int32_t.

Great, thanks for that.


distrho: unstable-2016-06-26 -> unstable-2017-08-04

Motivation for this change
the previous version didn't work anymore in NixOS, see:
https://github.com/DISTRHO/DISTRHO-Ports/issues/17
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@FRidh @cillianderoiste
Since you two have a history of merging my audio pkgs, could you have a look?
The previous version doesn't actually work on NixOS, so it'd be great if this could be in 17.09.


Release/1.44.0

What
In this release:

FEATURE - Preview collection
 BUG - post 1.43.0 release - Florence not able to ‘preview’ collection once the collection is in the queue.
BUG - post 1.43.0 release - Florence redirect to collections after preview exit
BUG - post 1.43.0 release - redirect to home page after editing url in the browser bar
FEATURE - Updated Toast UI design

How to review
Check if tickets were signed off by PM
Who can review
anyone

@dandwal thanks I though they were all moved but it was signed off with Paul last week. he is unfortunately away today and we have scheduled the release tomorrow morning :-(

@dandwal thanks I though they were all moved but it was signed off with Paul last week. he is unfortunately away today and we have scheduled the release tomorrow morning :-(

On the basis of that will approve now


Pipeline in WGS mode appears to require target_bed

Description of the bug
When I run the pipeline in WGS mode target_bed must be supplied, or it feeds a null value to TABIX_PBT, causing the pipeline to crash.
The documentation suggests that target_bed is optional.
Command used and terminal output
No response
Relevant files
No response
System information
nf-core/raredisease 1.0 (current git master)

Hi @lfearnley! Could you share your nextflow.log from a failed run?

Hi @ramprasadn - will do once it's available; I've had another run failure on a different issue.
Speaking of which - I'm running raredisease on GRCh38 WGS using the install instructions and encountering a reasonably large number of issues; how did you want me to handle these? Github issues with 1 per problem/query, or email?

Sounds good!
That's concerning..
I think it'd be better if you open a Github issue for each problem/query, as it will allow other users and devs to pitch in with their experiences. 😄

Sure thing! Not too concerning - I think most of what I'm hitting is related to documentation/defaults that aren't getting set for some reason. I'll start with two I can think of off the top of my head.
On this issue though, a related question - running the pipeline in WGS mode seems to still result in PICARD_COLLECTHSMETRICS running. I'm not sure that makes sense?

I also had this issue with intervals file and ended up adding a bed file for the whole genome. I agree that the best would be to disable CollectHSMetrics when using WGS, as it's not applicable. @lfearnley I have many of the same issues and you can see some notes (quite terse, sorry) in my repo README https://github.com/fa2k/raredisease-configs/tree/main , a bit down under Reference Data. I've also had great benefit from Clinical Genomics's repo https://github.com/Clinical-Genomics/reference-files/ and the test datasets. I think it's great that you're making issues in github instead of just working around it like I did, though.

@fa2k Thanks so much for that!
The only thing I'd check/flag in your notes (which are immensely helpful - there's one or two steps I've yet to debug that they clear up for me) is that the gnomAD SV 2.1 listed is possibly aligned against hg19 and the other files are aligned against GRCh38. I've been using the gnomAD 2.1.1 GRCh38 liftover from dbVar which is linked at gnomAD's download page if that helps for an update.

Thanks @lfearnley for the correction on gnomAD SV, this will save me a lot of headaches:) (I'll also try to adapt to the new changes in the dev branch, there are some new arguments.)

Could you check if the latest release fixes this issue with target_bed @lfearnley?

Fixed in #395


IMAP sent mail folder doesn't appear to be syncing correctly

I have an account setup for IMAP which regularly is running into a problem with syncing. It seems that the index of messages gets confused and loops back around to the beginning.
I rename my sent mail folder at the beginning of each month via a cron job. My other IMAP clients don't have any issues with this, but K9 regularly gets the index all wrong. It is keeping older messages on my phone, even tho I can see it's syncing the sent mail folder. The messages show up in the list, but if I try and open one, it's grabbing an old message from the retained messages which should no longer show up. I'm seeing messages from December 2018 in this list clear up to April. If I open the next message in the list, it's looping around and grabbing the message from the start of the list. I can't seem to figure out how to get the index to reflect the current sent mail folder. It's appending messages to the sent mail folder correctly, and those messages are showing up on other clients, so it seems to be something about how it's reacting when the sent mail folder is renamed and a new one created each month. I think. I can't explain how else it's still showing messages from December in the locally cached view/copy of the IMAP messages.
Environment
K-9 Mail version: 5.6
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Please take some time to retrieve logs and attach them here: sorry, I don't have any way of running adb to fetch the logs

Here are some more details / screenshots from my phone which hopefully might help.
This my current view in K9 of my send mail messages:

If I try to open the second message (microblasting) it instead is opening a message from April 23rd:

If I scroll down through my Sent mail I should only be seeing messages from May, but I'm seeing messages dating all the way back to December of 2018:

So I scrolled up through my message list to the beginning of the month, and there is are messages there from April 23rd and then it jumps to May 1st:

I can open the last message from April 23:

but if I open the next message for May 1st, it's looping all the way around to the first message in the index, which is in December:

If I hit "Clear local messages" it seems to resolve itself, but I can't see why this step would be required to get the local copy to sync correctly, especially when it's able to successfully append to the messages file on the server when I send a mail on my phone.

See #1074


Over-reporting of invalid_use_of_covariant

The diagnostic invalid_use_of_covariant is reported in several places where the parser has already reported extraneous_modifier. While I believe that the analyzer diagnostic message is better, having both messages isn't helpful to users. The following is an example of all the places I could think of where covariant could be placed, with the names of the reported diagnostics (if any) as a comment.
void f(covariant int x) {} // extraneous_modifier, invalid_use_of_covariant
Function g = (covariant int x) => x; // invalid_use_of_covariant
typedef F = void Function(covariant int); // invalid_use_of_covariant
class C {
  covariant int f1 = 0;
  void m1(covariant int x) {}
  static covariant int f2 = 0; // covariant_and_static
  static void m2(covariant int x) {} // extraneous_modifier, invalid_use_of_covariant
}
mixin M {
  void m3(covariant int x) {}
  static void m4(covariant int x) {} // extraneous_modifier, invalid_use_of_covariant
}
extension on C {
  void m5(covariant int x) {} // invalid_use_of_covariant_in_extension
  static void m6(covariant int x) {} // invalid_use_of_covariant_in_extension
}

Also, there are no tests for this diagnostic.

@srawlins in case this interests you


popovers: Fix alignment in Move topic menu

Issue #19875

I moved the second option on new line using <br/> in static/templates/move_topic_to_stream.hbs.
Please check if this requires any change.

Merged, after a slight tweak to the commit message to auto-close the issue and explain the problem statement more clearly.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
If you'd like, a nice follow-up would be looking at the CSS for that widget and adjusting the vertical spacing to make it look nicer.


document Operator node selectors, labels, annotations

Add docs for:

nodeSelector
additionalLabels
additionalAnnotations

Fixes https://github.com/cockroachdb/cockroach-operator/issues/643

This change is


SSH adaptor does not support environment variables

The SSH adaptor currently does not support environment variables, see SshJobs.java:171. The sim-city-client task manager passes information into the job through an environment variable, and so cannot be used with the Xenon ssh:// adaptor.
As far as I can tell, SSH does not support this directly, although you can send environment variables from the local session to the remote session if the server supports this and the variable has been whitelisted. But that would require setting the variable locally as well, and special configuration on the server side.
Alternatively, an environment-set command could be sent before the actual command, but this may be tricky as well, as the syntax for setting environment variables is shell specific. Perhaps just supporting Bourne-style syntax would be enough.
sim-city-client has its own non-Xenon ssh routines now, but it would be nice if this could be done through Xenon instead, so we don't get duplicate functionality.

Should add test for this

Seems to work in tutorial by the way.

I checked, and both the Local and SSH adaptors support setting environment variables that are provided in the JobDescription. It is up to the application that uses Xenon to fill these appropriately.
Is this still an issue for you ? If so, please reopen.

Well, I guess this got fixed implicitly when the SSH adapter was updated for Xenon 2. nl.esciencecenter.xenon.adaptors.ssh.SshJobs doesn't even exist anymore. I'm no longer working on sim-city-client, but I assume that the issue has been fixed and that it'll work if/when sim-city-client is upgraded to Xenon 2.

I'm now running into this with Cerise, so I can confirm that it's not fixed in Xenon 1. I'm planning to upgrade to Xenon 2, and I can work around it for now, but if Xenon 1 will remain supported, then maybe it should be fixed.
[2017-10-04 12:44:05.944] [CRITICAL] Traceback (most recent call last):   File "cerise/run_back_end.py", line 48, in <module>     manager = ExecutionManager(config, api_config, apidir, _xenon)   File "cerise/../cerise/back_end/execution_manager.py", line 67, in __init__     api_files_path, api_install_script_path)   File "cerise/../cerise/back_end/xenon_job_runner.py", line 46, in __init__     self._api_files_path, api_install_script_path)   File "cerise/../cerise/back_end/xenon_job_runner.py", line 133, in _run_api_install_script     xenon_job = self._x.jobs().submitJob(sched, xenon_jobdesc) jpype._jexception.nl.esciencecenter.xenon.jobs.UnsupportedJobDescriptionExceptionPyRaisable: nl.esciencecenter.xenon.jobs.UnsupportedJobDescriptionException: ssh adaptor: Environment variables not supported!


Updated version to v1.8.1.

@pelson - Can I ask you to take a look at #1690 before a release is actually tagged, also #1692 I think.

Too late I guess then @pelson? #1690 is even in the milestone...

Too late I guess then @pelson? #1690 is even in the milestone...

Ah - I've completely messed up there. I looked in the GH interface at the v1.8.1 milestone and it was empty - my mistake as I was looking at issues and apparently that doesn't include PRs.
I'll make sure that the docs we build have #1690 in them, even if the actual source for v1.8.1 doesn't have the change (but v1.8.x does).

Ah OK no worries. I always go for the milestones tab and then select the one I want which shows both. The interface will probably have changed by the next time this is done anyway!

The interface will probably have changed by the next time this is done anyway!

I hope not!  :)
I've got high hopes for drastically shortening our release cycles - I'm just lacking the time to implement them! :watch:

I've got high hopes for drastically shortening our release cycles

I'm all for that!


Drag n drop of file into explorer not working

Linux, vscode - latest insiders
Drop a file into explorer
File does not get copied over

If I drag the file over to the editor it is nicely opened. Dragging a folder also works.
I also verified and this all works on OS X, I just can not seem to get it to work on linux.

I can reproduce sometimes and it smells awfully like https://github.com/Microsoft/vscode/issues/7948


Output cache now uses CodeIgniter caching library.

Updated the output library caching mechanism.  Now uses the Cache
library and associated drivers to do full page caching.  Given that
$_GET is no longer a leper in CI have added that to the cache key
generation.  Any headers set are also cached and resent on subsequent
requests for the cached page.
Have tested with APC, Memcached and file system caches.

+1

+1


The kubernets secrets is not updated

I'm trying to install and set up the plugin but seems something is missing
logs
"msg":"loading kube specs"}
"msg":"successfully loaded kube specs"}
"msg":"updating CRD"}
"msg":"Upserting custom resource externalsecrets.kubernetes-client.io"}
"msg":"starting app"}
msg":"successfully started app"}
"msg":"MetricsServer listening on port 3001"}

But when I change the secret on AWS secret manager my Kubernetes secret doesn't update
describe of deployments
Environment:
      AWS_DEFAULT_REGION:
      AWS_REGION:
      LOG_LEVEL:
      LOG_MESSAGE_KEY:
      METRICS_PORT:
      POLLER_INTERVAL_MILLISECONDS:
      VAULT_ADDR:
    Mounts:                          <none>
  Volumes:                           <none>

I was wondering if the Mounts and Volumes labels should have something

Did you create any ExternalSecret resource? Please provide more details, if the issue has been resolved please close this.


Cannot catch the rainlab.user.beforeAuthenticate event

I installed October v3.7.5 and Rainlab Users v3.1.3.
I try to modify the functionality with listening to this event, but I just cannot catch it.
Event::listen('rainlab.user.login', function ($user) {
    trace_log("This works");
});
Event::listen('rainlab.user.beforeAuthenticate', function ($component, $credentials) {
    trace_log("This does not work");
});

Looking at the ActionLogin.php from Rainlab Users, there's a note about version 3.7 already:
https://github.com/rainlab/user-plugin/blob/46d0e619dd17c78c215134ff1adfcd255ba1b7e2/components/authentication/ActionLogin.php#L43C1-L55C10
So I replaced it with the suggested line but still I cannot fetch this event.
Did I missunderstood it and the event is not thrown on every login? I debugged through the Authentification component and it should be thrown. Checking the EventEmitter.php from the system traits, I see that code does not run in local or global event, it uses the last return value there.
So, what needs fixing here:

Please Fix the Event so it can actually be fetched again.
Looking at this documentation: https://github.com/rainlab/user-plugin/blob/46d0e619dd17c78c215134ff1adfcd255ba1b7e2/docs/events.md
I guess "Before the user is attempting to authenticate using the Account component." should ne about the Authentication component, not the Account component aynmore, right?

Fixed in de3f81f775728e1b0b413d51581b68bead03e560


Failed to call smart contract function

Here is our abi:

and this is my code:
`let url = URL(string: nodeAddress)
let web3 = try Web3.new(url!)
web3.provider.network = Networks.Custom(networkID: BigUInt("666666"))
web3.addKeystoreManager(self.keystoreManager!)
let walletAddress = EthereumAddress(fromAddress)! // Your wallet address
let contractMethod = "ownerDeposit" // Contract method you want to call
let filePath = Bundle.main.path(forResource: "gung", ofType: "abi")!
let contractABI = try String(contentsOfFile: filePath) // Contract ABI
let parameters = [BigUInt(months)] as [AnyObject]
let contractAddress = EthereumAddress(gungnirContract)!
let abiVersion = 2 // Contract ABI version
let extraData: Data = Data()
let contract = web3.contract(contractABI, at: contractAddress, abiVersion: abiVersion)!
var options = TransactionOptions.defaultOptions
options.from = walletAddress
options.gasPrice = .automatic
options.gasLimit = .automatic
let tx = contract.write(
contractMethod,
parameters: parameters,
extraData: extraData,
transactionOptions: options)!
let result = try tx.send(password: pass, transactionOptions: options)
`
Here is the problem:
This func needs an amount value, but i don't know where to put this value
when I put it in parameters, it appears to be wrong in inner logic; when set it to option.value, I can't get gas.
so, where should I put this value

    var options = TransactionOptions.defaultOptions
    options.value = amount

    var options = TransactionOptions.defaultOptions
    options.value = amount

Thanks for replying, but I tried to set amount to options.value, still got the error "Failed to fetch gas estimate"

    var options = TransactionOptions.defaultOptions
    options.value = amount

I also tried to set amount after the transaction is created, like this:

The month value can't be set another value but 12, I set it wrong, so problem fixed


Example in dev-guide, "Create a MIL-STD-2525 multipoint", does not show all symbols in Cesium .

There are 2 examples, "Create a MIL-STD-2525 multipoint" and "set the visibility of an overlay", which 3 symbols are added to the map.   In both cases, one of the symbols does not show.   In both cases all 3 features are added to the map at the same time, then the map zooms to the overlay prior to the features being shown (as the map is returned success of the feature add PRIOR to the feature being added by the engine.)  The zoom works and is in right area, however it looks as though the renderer is clipping the images out of the picture because if you zoom slighltly out the renderer displays the missing graphics.  Fix this.

Test case:
Use branch #126.
Run 2 examples in dev guide:, "Create a MIL-STD-2525 multipoint" and "set the visibility of an overlay"
The test is a success if all 3 features show on the map.

Reintegrate

Merged into the dev branch. Closing this issue.


Cassava images and visualizations scrambled

Most of the paragraphs in the cassava essay are appearing out of order, and the visualizations are showing up in different paragraphs too.

Texts and visualizations also scrambled in pelargonium essay


DKRZ-Ocean/gr15/gr15_uvw_vis.nc corrupt grid

Import DKRZ-Ocean/gr15/gr15_uvw_vis.nc
Add a wireframe renderer

You will get the image below:

I'm closing this issue. The displayed rendering is correct. This is a complicated curvilinear grid that wraps around itself when projected into Cartesian coordinates. Attached is an image from a 2d version of the data now available in data/Source/DKRZ-Ocean/gr15.

Also attached is an image generated by Matplotlib that exhibits the same overlapping grid

FYI - The full file path to the dataset is below.  I believe the data format is NetCDF-CF.  @stasj please specify if this is wrong.  I currently get an error on importing the data as described above.
/glade/p/cisl/vast/vapor/data/Source/DKRZ-Ocean/gr15/*


Wrap content in variables and watch views

During debugging, my variable names are long and its content is long too. So Variables/Watch/CallStack/Breakpoints windows cannot show all contents.
Please support customized font setting for debugger windows. If possible, I want to use smaller font in these windows.
Another request: if the variable is a list and its content is long, current window just show "...". So can the windows "wrap" the text and show all the contents?

For the debug font, dup of https://github.com/microsoft/vscode/issues/519 as we will not allow to customize the font of the debug views and everything else in the workbench to be untouched
As for wrapping the text in the variables view, that is a fair feature request. Thus renaming this issue and leaving it open as a feature request which we might consider in the future.
Thanks

Thanks. The situation is different from VS IDE. In the IDE, the watch window is in the bottom. So you can always drag it bigger to see all contents. But in VS code, you cannot move the watch window to the bottom, so "wrap" feature is much more important.

I disagree with this being closed. As it stands now, if a watch expression is too long it is impossible to see the result of it. You can make the debug pane larger but there is a limit. Hovering over the expression doesn't tell you the value either. I make heavy use of watch expressions, so this is the biggest thing turning me away from debugging in VS code.

Hi @joe-gre . I totally agree with you. I suggest you create another ticket for them  😊

@weinand in the follow-up ticket you suggest moving the pane to the bottom. While this helps for a strings of a certain length, for anything longer than that, I'm still force to copy their value and paste that … anywhere.
Any chance of re-opening? I assume @joe-gre  and @kgfly at least (besides) might appreciate that ✌
Thanks a lot for your consideration 🙏

😮 Oh wow, I just discovered that hovering the value actually works (by now?).
Nevermind my last comment … sorry and happy coding y'all 😊

please add your votes to https://github.com/microsoft/vscode/issues/177733 - if you would like this feature to be implemented


Updated licensing changes for Windows Servers

Removed outdated licensing information for Windows servers and added proper licensing server information for MDATP based upon PM information and Product Terms as of April 2020.  Confirm with proper channels and review Product Terms to see matching information.

Added an additional licensing comment from Product Terms to make it more visible discussing the maximum number of devices MDATP can be used on per user as this has been a common ask by customers and is buried in the product terms.


Edit geometry fails in maploom 1.2.8

turns out to be related to edit geometry improvements. made changes so that edit matches expected changes made for new geometry. fixed in 1.2.9


suppprt pandas categorical

#192
also support categorical str

Hi @wxchan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

should I change default to 'auto'?

I think you can.
BTW, how to ensure the training data and validation data use same code of categorical ?

strange thing: add this test will lead other tests fail.
@guolinke I am not sure why test fails, do boosters in same script share the same handle?

@wxchan  can you pass this test offline ?

@guolinke No, same error.

@wxchan
I try some tests, it seems the params in test_template is changed after call test_pandas_categorical, and this params caused error.
Did you know why ?

@wxchan if I change test_regression as following:
    def test_regreesion(self):
        evals_result, ret = test_template({'objective': 'regression', 'metric': 'l2'})
        ret **= 0.5
        self.assertLess(ret, 4)
        self.assertAlmostEqual(min(evals_result['eval']['l2']), ret, places=5)

it can pass...

@wxchan what is the reason?

The params is used as a global variable, I put it into a class.
There is still a warning, I test it occurs with set_categories, but I am not sure how to fix it.

fixed. in order not to change origin data, make a copy of origin data and change category to int, but it will add memory cost.
another issue here: pandas feature name can be integer, so cannot use them directly sometime.


Configurable leader key for keymaps

Most of the default mappings are starting with <localleader>. People might have their custom bindings with <localleader>. In that case they will have to remap all the keymaps for the plugin like I did:
      local leaderKey = "<localleader>r"
      local opts = {
        keymaps = {
          replace = { n = leaderKey .. "r" },
          qflist = { n = leaderKey .. "q" },
          syncLocations = { n = leaderKey .. "s" },
          syncLine = { n = leaderKey .. "l" },
          close = { n = leaderKey .. "c" },
          historyOpen = { n = leaderKey .. "t" },
          historyAdd = { n = leaderKey .. "a" },
          refresh = { n = leaderKey .. "f" },
          abort = { n = leaderKey .. "b" },
          gotoLocation = { n = "<enter>" },
          pickHistoryEntry = { n = "<enter>" },
        },
      }

Here I am suggesting to have a configurable leaderKey which will allow users to reuse predefined sensible keymaps by just changing the leaderKey.
Updated default config would look like this after suggested change:
{
   ...
   - Key prefix for default keymaps
   leaderKey = ",",

  -- shortcuts for the actions you see at the top of the buffer
  -- set to '' or false to unset. Mappings with no normal mode value will be removed from the help header
  -- you can specify either a string which is then used as the mapping for both normmal and insert mode
  -- or you can specify a table of the form { [mode] = <lhs> } (ex: { i = '<C-enter>', n = '<localleader>gr'})
  -- it is recommended to use <localleader> though as that is more vim-ish
  -- see https://learnvimscriptthehardway.stevelosh.com/chapters/11.html#local-leader
  keymaps = {
    replace = { n = leaderKey .. "r" },
    qflist = { n = leaderKey .. "q" },
     ...
    gotoLocation = { n = "<enter>" },
    pickHistoryEntry = { n = "<enter>" },
  },
  ...
}

hi @guruor , thank you for the suggestion 😄 . Just trying to understand the use case more as at first glance it seems to be an edge case, or maybe something specific to your setup.
As far as I understand, the purpose of localleader is to have buffer type specific bindings. Are you by chance using localleader when you should be using leader for your bindings instead?

Hi @MagicDuck , this might be specific user case but I have key mapping with <localleader>r to execute a operation on certain filetype.
Following are the use cases with their filetype:

Make a http request with rest.nvim for http fieltype
Execute visually selected query in sql filetype.
Run preview of markdown file currently open

Here just to override this one mapping I had to override all the defaults of grug-far.nvim.

@guruor so if you have it configured per-filetype why would it conflict? grug-far has it's own separate filetype.
I am assuming you could either use ftplugin or do something like the following to create filetype specific bindings...
vim.api.nvim_create_autocmd('FileType', {
  group = vim.api.nvim_create_augroup('my_http_binds' .. name, { clear = true })),
  pattern = { 'http' },
  callback = function()
    vim.keymap.set('n', '<localleader>r', function()
      -- do http request
    end, { buffer = true })
  end,
})
vim.api.nvim_create_autocmd('FileType', {
  group = vim.api.nvim_create_augroup('my_http_binds' .. name, { clear = true })),
  pattern = { 'sql' },
  callback = function()
    vim.keymap.set('n', '<localleader>r', function()
      -- run sql query
    end, { buffer = true })
  end,
})
...

@MagicDuck Ah, my bad. Didn't notice these bindings are local buffer bindings only and are limited to grug-far filetype. By quick look at default config I assumed that it might conflict with my bindings but thats not the case. Got to know about actual use of <localleader> mappings from your referenced article.
Now that I understood the gap, this request makes no sense. You can close the issue.

@guruor no worries 😄


⚠ Bofrost.at has degraded performance

In 395f888, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2018 ms

Resolved: Bofrost.at performance has improved in 3ba8b14 after 308 days, 10 hours, 6 minutes.


added ability to access app.name

wow, such cool, so amazement

We should start adding tests someday.


Fix errors when processing user input before app loads.

discussion: https://chat.zulip.org/#narrow/stream/6-frontend/topic/hotkey.20bug

@timabbott I have not reviewed this PR.

Test-deploying this on chat.zulip.org.

Merged, thanks @amanagr! It appears the CI issue was just a ReadTheDocs infrastructure flake.


add feature importance in python

Changes:

add feature importance with 2 options: split and gain
simplify functions (list comprehension is recommended in python)
format comments

Discussions:

if user calls train() with train_data is Dataset object and categorical_feature is not None, categorical_feature won't be used for Dataset;
best_iteration is not right with init_model. For example, init_model has 100 trees, train 10 more iterations and meet early stopping criterion, then if use num_iteration=gbm.best_iteration in predict, it only uses 10 trees (should use 110 trees).

Hi @wxchan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Should we expose Dataset to the user? Or we can use another class that warp Dataset and other filed, and expose this "high level" data-set to user?
use Booster.predictor to fix this.

Before we have better solutions, we can use examples or wiki to recommend user to use tuple. People can still use Dataset if he knows what he is doing.
I tried to solve 2, but it's not working. The logic seems not easy.

@wxchan

Actually, current interfaces in engine.py and sklearn.py cannot save memory after convert to Dataset. Since the reference of raw data is not freed.
My suggestions:

use high level Dataset that can set X, y , categorical_features, init_predictor, other_fields.
engine.py only can accept this Dataset as input.
Construct real Dataset before construct Booster(in training or cv). After construct real Dataset, free raw data
If user want to predict Dataset without raw data, raise an exception

you can update the code, I can help to take a look.

@wxchan OK, i will merge this first, then create another PR to refine Dataset.


Fix SHELL_BACKEND_MQTT label text

A minor fix. The SHELL_BACKEND_MQTT label text said "TELNET"
instead of MQTT.

Thanks @pearson


Kotlin objects with JsonJacksonCodec

Hi!!
I'm using Redis as a cache provider with the help of Redisson in a kotlin service.
At first I tried to set in redis non Serializable objects and I had to change to a JsonJacksonCodec in order to encode non Serializable objects. However some code at initTypeInclusion from JsonJacksonCode.java is avoiding our jackson to write @class property for kotlin classes (they are closed by default).
I have created a custom Codec in kotlin extending JsonJacksonCodec:
package com.bumble.utils.redis.redisson

import com.fasterxml.jackson.databind.ObjectMapper
import com.fasterxml.jackson.databind.jsontype.BasicPolymorphicTypeValidator
import org.redisson.codec.JsonJacksonCodec

class JsonJacksonKotlinCodec(objectMapper: ObjectMapper) : JsonJacksonCodec(objectMapper) {

    override fun initTypeInclusion(mapObjectMapper: ObjectMapper) {
        mapObjectMapper.activateDefaultTyping(BasicPolymorphicTypeValidator.builder()
            .allowIfBaseType(Any::class.java)
            .build(), ObjectMapper.DefaultTyping.EVERYTHING)
    }
}

And I start redisson with:
                val codec = JsonJacksonKotlinCodec(ObjectMapper())
                codec.objectMapper.registerKotlinModule()
                config.codec = codec
                config.useSingleServer().address = redisConfig.host

And everything works! Now I can serialize and deserialize kotlin classes into Json and keep them in redis.
However I'm wondering, as we are passing class type to getBucket:
redisProvider.getClient()?.getBucket<V>(cacheKeyToString(namespace, key))?.get()?.awaitSingleOrNull()
Can't we just use that information to indicate Jackson which class should be used to deserialize???
Also, did you find OK my JsonJacksonKotlinCodec?

Also, did you find OK my JsonJacksonKotlinCodec?

Yes.

Can't we just use that information to indicate Jackson which class should be used to deserialize???

Unfortunately no, you can look at similar implementation of TypedJsonJacksonCodec. Which allows to specify types in constructor.


Integrate vaadin.com header-as-a-service

Still using preview.vaadin.com URL, as HaaS is not yet production-ready.
Removed the custom Google Analytics tracker, as HaaS should include that already. Not sure if the <meta name="google-site-verification" ...> is still needed.
TODO We should use haas.tracker.gtm. triggerGAEvent  instead of the global ga method for sending tracking events.
TODO: also, why are we using JS to create the <link> elements? Why not just put them in the HTML directly?

Oh, damn. A lot of unnecessary white space changes. I did the changes in VS Code – should I change some formatting settings?

And apparently I messed up the rebase as well, as this PR contains changes that are already merged to master.

Maybe @Artur- wants to do these changes instead? 😅

Can you fix the TODOs @jouni ?

Yeah, I think I can, but can’t say exactly when. Might not happen today.


Hangman Extension Feature

Is your feature request related to a problem? Please describe.
The current platform lacks interactive word games, leaving users with limited engagement options.
Describe the solution you'd like
Introduce a Hangman extension to the platform, offering users a fun and educational word-guessing game. Players can select difficulty levels and categories, enhancing user experience and knowledge retention.
Describe alternatives you've considered
We could explore other word-based games, but Hangman is a classic choice that appeals to a broad audience and aligns with our platform's educational goals.
Additional context
Hangman is a popular word game that challenges players to guess a word by suggesting letters within a certain number of guesses. It's a simple yet effective way to engage users and promote vocabulary expansion.
What problem is this feature trying to solve?
This feature aims to enhance user engagement by offering a fun and interactive word game within the platform, addressing the current lack of such activities.
How do we know when the feature is complete?
The feature will be considered complete when users can seamlessly access and enjoy the Hangman extension, with options for different difficulty levels and categories, providing an engaging experience that encourages repeat usage and positive feedback.

@Sulagna-Dutta-Roy There was an issue raised for this two weeks ago, but it hasn't been completed yet. I'd like to take it on

In that case you can directly comment on this Issue. Because I don't know if they're working on this. So need to know the update #244
Kindly avoid the duplicates. Otherwise I will receive same PRs in the same time. Thank you @thevijayshankersharma


Making an equipped LIGHT object invisible doesn't hide the light.

I'm attempting to use IED to add light sources to some lanterns I'm working on, and when I hide the equipped lantern in SHIELD slot, the mesh disappears, but the light remains. I'm not sure if this is a bug, but I can find no other way to hide the light if I wanted to use IED's light feature instead to allow for more versatility.
Secondary note, I'm not sure if it's a bug either, but I could not make my equipped torch/light invisible hiding the Shield Hand node until I installed a XP32 compat skeleton in my debug profile to test with.
Thanks!

Hiding nodes doesn't affect lights. Since the light isn't attached to the skeleton (it just tracks the parent node), changing any node parameters other than position has no effect on it.
Use the hide light option in custom object settings, model section.

Secondary note, I'm not sure if it's a bug either, but I could not make my equipped torch/light invisible hiding the Shield Hand node until I installed a XP32 compat skeleton in my debug profile to test with.

Non-xp skeletons don't have that node.

Ah, I've been messing with torches/lanterns, and the 'remove light' option in custom views doesn't seem to do anything, while add light duplicates the light.
Ah okay, I was thinking that something that may be the case.
Thank you very much for the info, I think I've found an alternate method to achieve what I'm working on.
Cheers :D


Add logging format

This PR modifies mc2-utils to use a better spdlog log format which tells the user whether they are in a HOST or ENCLAVE environment

LGTM!


KAFKA-9962: Make the auth operations fields ignorable

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@omkreddy When we merge this we need to cherry pick this to the versions enumerated in the Jira.

Thanks for the PR. I think we should update the admin client compatibility test to include this.

Thanks for the PR. I think we should update the admin client compatibility test to include this.

@ijuma, I am not sure I follow. Do you mean these kind of tests in .../admin/KafkaAdminClientTest.java?
public void testDescribeClientQuotas() throws Exception {
  try (AdminClientUnitTestEnv env = mockClientEnv()) {
    env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
...

The system test client_compatibility_features_test.py.

It seems like if includeAuthorizedOperations = true and we can't include the authorized operations, we should get an UnsupportedVersionException, right?  So these fields should not be ignorable.
Or are you arguing that we should silently ignore the failure and return Optional.empty or null? (can't remember which we did in this case).
That sounds kind of like it should require a KIP, since it's a behavior change to the API.  Several APIs... if we did a KIP like that, we might also consider setting `includeAuthorizedOperations to true by default.  I'm not sure if such a KIP would be a good idea or not (would have to think).

My understanding is that this is meant to fix the behavior to match the original KIP. So, not sure we need a new KIP. I haven't reviewed the actual change though.

My understanding of this sentence in KIP-430 is that we should ignore the field:

Newer clients connecting to older brokers will use the older protocol version and hence will not request authorized operations.

I am okay creating a KIP to make the intent clear. cc @rajinisivaram

I should mention that based on the information expose by the current implementation of the Admin client, the user doesn't have enough information to determine if those fields should be true or false.

@jsancio Thanks for the PR. The original KIP at the time it was voted through said:
Newer clients connecting to older brokers will use the older protocol version and hence will not request authorized operations. AdminClient will throw an exception if the option is requested but not supported by brokers.

@cmccabe found a compatibility issue with the KIP and made some changes. I think the change was to allow ConsumerGroupDescription#authorizedOperations to return null instead of throwing an exception since there wasn't an easy way to throw an exception for this case.
In the case described in this JIRA, KSQL is requesting authorized operations from a broker that doesn't support it. What is it going to do if we don't throw an exception and quietly ignore the request to provide authorized operations?

One issue is, we were not throwing exception in 2.3 and 2.4 releases. This was enforced in https://github.com/apache/kafka/pull/7710 (2.5 release)

One observation is, we were not throwing exception in 2.3 and 2.4 releases. This was enforced in #7710 (2.5 release)

Thanks @omkreddy and sorry for the delay response.
It looks like ignoring the field was the old behavior. This PR makes it explicit in the message schema.
Adding the system tests @ijuma suggested.

The system test client_compatibility_features_test.py (also see ClientCompatibilityTest.java).

Done.

In the case described in this JIRA, KSQL is requesting authorized operations from a broker that doesn't support it. What is it going to do if we don't throw an exception and quietly ignore the request to provide authorized operations?

I don't know @rajinisivaram. Based on what the Admin client exposes there is no way for the client/KSQL to determine if the server version supports this feature, no?
My understanding is that KSQL is setting this to true if some broker config is set. That broker config can be set even if the broker doesn't support this feature.

@rajinisivaram wrote:

@cmccabe found a compatibility issue with the KIP and made some changes. I think the change was to allow ConsumerGroupDescription#authorizedOperations to return null instead of throwing an exception since there wasn't an easy way to throw an exception for this case.

Hmm.  I think the JIRA you're thinking of is KAFKA-8158.  The bug was that new client + old server was silently returning an empty set of auth operations, rather than throwing an exception OR returning null.  My change was intended to fix that, not to change the behavior from exception to null (or vice versa).
@jsancio wrote:

I don't know @rajinisivaram. Based on what the Admin client exposes there is no way for the client/KSQL to determine if the server version supports this feature, no?

Well, the client can handle the `UnsupportedVersionException and stop requesting the authorized operations.
Anyway, if you folks feel strongly that it should silently return null rather than throwing a UVE, I'm OK with this change.  To be clear, the null (rather than empty) set does let the client know for sure that the authorized operations request was not supported.
I suppose the fact that we did return null for this in 2.3 and 2.4 rather than a UVE is a strong argument for doing it that way in 2.6 and beyond.  Let's just update the KIP and also bump the KIP thread as well.  I agree with @ijuma that we should also change the compatibility tests for this in ducktape.

Well, the client can handle the `UnsupportedVersionException and stop requesting the authorized operations.

This is not fine grain enough for all cases. There are already a few reasons why the call may throw an UnsupportedVersionException. This is one example:
https://github.com/jsancio/kafka/blob/kafka-9962-ignorable-auth-ops/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1681-L1687
I have added compatibility tests that verify that the client return null when describe topics against a cluster version that doesn't support this feature.

**The KIP clearly specifies that describeCluster will throw a UVE in this case:
bq. When the AdminClient is talking to a broker which does not support KIP-430, it will fill in either null or UnsupportedVersionException for the returned ACL operations fields in objects.  For example, ConsumerGroupDescription#authorizedOperations will be null if the broker did not supply this information.  DescribeClusterResult#authorizedOperations will throw an UnsupportedVersionException if the broker did not supply this information.
The discussion above was about describeConsumerGroups, but the PR seems to be changing both.
bq. [UVEs are] not fine grain enough for all cases. There are already a few reasons why the call may throw an UnsupportedVersionException.
In the future, KIP-584 will make new features (that can't be faked by old brokers) more discoverable to clients.

The bug report in KAFKA-9962 is for describeCluster.


Issue on mod download failure

(Initially posted by @wolf109909 in Discord)
I think I've found some issues that might occur when mad failed to finish any of the install states in current main branches. Heres the walkthrough:
I've done a few temporary fixes to these problems while debugging myself, here is the first part:

user double click on the server with a downloadable mod
mod auto download kicks in, but failed when downloading due to poor internet
user did 1 again, instead of retrying the download, user got sent into the server and disconnected with out of sync with server.

Debugging
In moddownloader.cpp at void ModDownloader::DownloadMod(std::string modName, std::string modVersion), the ScopeGuard cleanup will get called even when you early return in any of the failing conditions which sets the modState.state. this will cause modState.state to always be set to DONE, which makes  the UI think the mod is downloaded (detailed info on the second part). I just removed the scope guard and moved to the old code reusing style for temoporary fix.
After that, I tried again. I get these instead:

user double click on the server with a downloadable mod
mod auto download kicks in, but failed when downloading due to poor internet
user gets a download failed warning, and got sent back to the server browser.
user did 1 again, but this time got to 3 immediately.
user retried again, this time he got to 2 but the download progress bar glitches.
things broke

From my debugging, I found 3 is caused by line 39 and line 41 in menu_ns_moddownload.nut where the NSGetModInstallState() call is right next to NSDownloadMod( mod.name, mod.version ), when in CPP the void ModDownloader::DownloadMod(std::string modName, std::string modVersion) creates a requestThread and making the NSDownloadMod in squirrel operation not blocking, giving NSGetModInstallState() with the old g_pModDownloader->modState.state. Immediately the UI will freak out and send user a Download Failed warning BUT in the mean time ModDownloader::DownloadMod is still running and didn't get canceled.  Once the user triggers 1 again, the NSGetModInstallState() will give the correct state but its set from the previous NSDownloadMod call. there we got some kind of race condition between two downloader threads that does filesystem opertaions and computer not very happy(its not that bad tbh just glitchy).
Another tempfix
I added simple thread block like the ones used in masterserver.cpp to limit only one  concurrent threads at the same time. then I added a new state on top of modState.state, naming it IDLE. I set the state to IDLE before spawning requestThread, making the script able to wait for the first modState.state and not just returning. At this stage, I think the whole process is more stable and user-friendly.
ps: I do this in discord instead of a github issue cause I'm not entirely sure if I'm doing this correctly. there are environmental differences between my testing branch and main branch. I will push the fixed code to my branch, but they are not very clean and are just temp fixes.

Relevant code can be found here:
https://github.com/R2NorthstarCN/NorthstarLauncher/commit/e01944fdcdc13c3aa06ce878da3d7cd1edb770d9
https://github.com/R2NorthstarCN/NorthstarMods/commit/dd23739de94e4c4022ab1e6b0b4b0953969db9d0
note: we are using a custom masterserver which doesn't have connectionless auth from atlas. this means we are still running very ancient server browser nut files and I decided to just change MAD related code instead of implementing the same server browser changes in masterserver.cpp


[INTERNAL] Make World.name property refer to level.dat

The property name in the World class should be lazy-delegated to a function scanning the level.dat  NBT file and selecting the LevelName tag.

closed with aa4f378acf150a58696da1326d5f02203e9b154d


[UI] Add commas to one thousandth place

Description
This PR fixes #2717
Notes for Reviewers
MDN link
Signed commits

[x] Yes, I signed my commits.

Thank you, @Kn99HN 👍


Implement config changes to UA

Task/Issue URL: https://app.asana.com/0/0/1205442309571983/f
CC: @jonathanKingston
Description:
It allows to modify UA through config by either using the old logic, safari UA or safari UA with DDG component.
Steps to test this PR: TBD
1.
2.

Overall it looks fine. One small comment and the tests are failing due to user agent changes.


Typos and phrasing in jax_and_jaxtyping.md

Ref: https://github.com/openjournals/joss-reviews/issues/6915


Einsum

Several pieces of the code are written out as raw loops. Consider using the NumPy einsum function for much greater speed.

@sgulania I see you use loops in DIIS right?

I was thinking more of here.

OK. Oh I see. @sgulania is working on SOSCF and that will be updated soon.
By the way, @dgasmith , I could not find @sgulania in Assignees. Do you happen to know why?

@sgulania Did not accept their invite to be a collaborator.

Ok, I see.

@dgasmith @Kee-Wang  I am cleaning up the codes, and will use einsum, wherever required.

DIIS cleaned


DBZ-7143 Error when fail converting value with internal schema

https://issues.redhat.com/browse/DBZ-7143

@nicholas-fwang I am now a bit lost. Is there any information you are asking me for or is the PR more or less done (it seems to me so)? Thanks a lot

@nicholas-fwang I am now a bit lost. Is there any information you are asking me for or is the PR more or less done (it seems to me so)? Thanks a lot

@jpechane yes, I'm done, please review PR focusing following points :)
there are 2 points updated different with initial.

event.converting.failure.handling.mode is applied when convert the default value.
parsingErrorHandler in MysqlValueConverters is replaced by value of event.converting.failure.handling.mode.

@nicholas-fwang Could you please take a look at test failures? They seems to be related.

@jpechane I have fixed mysql TC for gtid (replica) case.
Should I fix also TC for Db2 and SQL server? I'm not sure that it's also related.

@jpechane could you confirm this?

@nicholas-fwang Restarted Db2 job - IMHO the failures are unrelated and are known flaky tests. I'll merge the PR when the run is finished.

The PR was rebased to the latest (2.6) main

@nicholas-fwang Applied, thanks! Could you please prepare an addtional PR with MySQL docs updated - the new config option?
Thanks!

@nicholas-fwang I am sorry, yes you are right. Nothing more is needed.


Updating the go-bindata go get links in the project.

What this PR does / why we need it: Updating scripts and documentation for consistency :).
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

/assign @cecilerobertmichon

Looks like a rebase is needed. I'll close this and open a new PR.


editor.action.smartSelect.shrink not working properly with PHP files

VSCode Version / OS Version:
Version: 1.43.2 (system setup)
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

HTML code in HTML file (this is OK)
First selects current element, then all elements between the tags, and then together with the tag

HTML code in PHP file (this is WRONG):
First selects the current element and then immediately select everything together with the tag.
With current behavior, this option is completely useless because you can't select everything between the tags

Does this issue occur when all extensions are disabled?:
Yes
Additional information:
editor.emmet.action.balanceOut it's not a solution because this not working with PHP files too (#93413)

VS Code only provides the framework for smart select and a simple default implementation. Extensions have API to provide AST-based data - so this is either an issue with the extension that you are using or the lack of an extension

Caused-by-extension ??
I tested it on a fresh installation without any additional extensions....

so this is either an issue with the extension that you are using or the lack of an extension


NorthwindDbContextInitializer - make random less random

By using a consistent data seeder, we avoid issues where Bogus generates names and other fields which are too long for the database.
Experienced this a few times today when running the tests on this project.

Great change @wicksipedia.  Thanks for this improvement.


How to configure Android Studio to use .teamcity code files in project?

I am trying to setup a TeamCity project configuration using Kotlin DSL. I've created a sample project in TeamCity pointing to just an empty Android Studio project with empty Activity which I 've published in the github. I've enabled Kotlin DSL configuration on the TeamCity for that project.
After that TeamCity has commited a .teamcity folder to my Android Studio project. However,  when I am inspecting the code in settings.kts the IDE is not giving me any hints and I cannot use the autocompletion for the Kotlin DSL configuration code.
For example I cannot navigate to implementation of function triggers, cannot use autocompletion etc.
I was trying to follow https://blog.jetbrains.com/teamcity/2019/03/configuration-as-code-part-1-getting-started-with-kotlin-dsl/#commento-login-box-container but unfortunately I cannot right-click on the pom.xml file and don't see any option to Add as Maven.
In addition I cannot see any External Libraries added to my project related to TeamCity DSL
I am using Android Studio 4.0
Is it possible to use such configuration in my case?
If so, can you please help me how I should properly setup it in Android Studio to have such benefits in Android Studio?
Android Studio project uses Gradle by default

I am not familiar with what you are doing specifically but I manage a non-trivial amount of TeamCity Kotlin config.
The lack of doc is frustrating and make using the DSL much harder than it needs to be. Here a couple hints that might help.

The intelliJ IDE, after you load the pom.xml, provides hinting and have very good lint checking to help catch errors before committing. Also, buried in the Maven menus is a option to "Generate" a configuration which essentially does the same thing that server does and catches most errors the server would throw.
I have a test teamcity project with no restrictions. In this project I can use the GUI to make changes and then examine the results. There are two ways I use this. The first is simply to make and save the change and the export the whole project as Kotlin (look for this under the actions menu of the project, it is not shown in the buildTypes action menu). The other way is to look for the "DSL" button in the GUI. There are many settings that, before they are saved, can show you the resulting Kotlin. This allows me to get a quick peek on what the setting should look like and even allows me to make a copy so I can paste in the code in the .teamcity directory.

Hope that helps.

@timdaman I also agree with your opinion of struggling with simple task as this is not relevant to other CI clients (such as Github CI, Jenkins or Gitlab CI).

Can you please elaborate more on that? If it is not possible to use such setup for my project in Android Studio then maybe it is possible in IntelliJ Idea. Unfortunately I was trying without luck in IntealliJ Idea Community edition. After right-clicking on the .teamcity folder and choosing "add as Maven" I encounter another error, IDE cannot resolve the jetbrains import packages and the Libraries are also not present. You can find the project here: https://github.com/jisasava/KotlinTeamcityDSL. Is it possible to configure this project to be working as expected in IntelliJ?

This approach is something which does actually makes the main purpose of configuration as code not useful. This "configuration as code" should be the main trait of switching from TeamCity control panel in web (GUI) to the code. As you describe I would still need to work with TeamCity UI mainly, and just copy pasting the configuration as a plain text (code). Thank you for your engagement to my question I really appreciate it.

I am short on time so I am not going to write a detailed answer right now.
You issue with adding the Maven project is probably related to the teamcity-server config in the pom.xml.
To initially create a project it is best to download a empty one from the TeamCity server in question. There are a couple reasons.

There are several versions of the DSL/API. When you download the the settings as generated on the server it will automatically set this to a version supported by the server.

The TeamCity server runs a secret Maven server. In the pom.xml the server generates it sets paths to download the libraries from itself. I noticed when looking at your linked pom.xml it is referencing http://localhost:8111/app/dsl-plugins-repository. If you did use the server to generate this pom.xml ensure that the server is running and reachable at the address configured in the pom.xml when you are importing/adding it.

@timdaman Hello,
thanks again for your answer. I've tried to firstly run the server as you suggested (I am using docker image and configuration exact as described here: https://nad.dev/posts/2020/01/06/teamcity-server-agent-docker.html
I've just tried to open an alone .teamcity folder in the IntelliJ Idea Community Edition. Unfortunately still I cannot setup it properly, I am getting unresolved errors:

Maybe you can describe me the exact steps how can I run the code in IntelliJ?

@timdaman I've also created some video which shows (perhaps in more details) the problem that I am encountering: https://www.youtube.com/watch?v=t4AboFhtb60&t=3s


Update version verification instruct's for Deb8/9

Updated instructions for identifying the current Debian waagent version to search for waagent rather than walinuxagent.  Based on feedback in Issue #5599.

@jpconnock : Thanks for your contribution! The author, @SuperScottz, has been notified to review your proposed change.

Thanks, this looks good to merge.
#sign-off

@iainfoulds: I'm sorry - only the author of this article, @SuperScottz, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


PlanRob

PlanRob page updated for 2024

Hi Gloria,
I just tried to update the PlanRob Workshop page but without much luck. I had updated the dates to the following:

Paper submission: Monday, 25 March 2024
Notification of acceptance: Friday, 26 April 2024
Camera-ready version due: Friday 24 May 2024
Workshop Date: June 2-3, 2024

to sync better with the rest of the workshops… but somehow, I’m getting the status that the working group is clean after I committed  but on github in the browser, I’m not seeing my change and so can’t lodge a pull request.
Please advise (and so sorry for the extra work).
Many thanks,
Iman

On 2 Feb 2024, at 13:21, GloriaB @.***> wrote:
Merged #16 https://github.com/icaps2024/icaps2024.github.io/pull/16 into master.
—
Reply to this email directly, view it on GitHub https://github.com/icaps2024/icaps2024.github.io/pull/16#event-11683444263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH42TVZ54EOCBAIYOSWNVLYRTK55AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY4DGNBUGQZDMMY.
You are receiving this because you authored the thread.

Hi Iman,
Did you make a new fork?
BR,
Zlatan
On Wed, Feb 7, 2024, 19:12 iawaad @.***> wrote:

Hi Gloria,
I just tried to update the PlanRob Workshop page but without much luck. I
had updated the dates to the following:

Paper submission: Monday, 25 March 2024
Notification of acceptance: Friday, 26 April 2024
Camera-ready version due: Friday 24 May 2024
Workshop Date: June 2-3, 2024

to sync better with the rest of the workshops… but somehow, I’m getting
the status that the working group is clean after I committed but on github
in the browser, I’m not seeing my change and so can’t lodge a pull request.
Please advise (and so sorry for the extra work).
Many thanks,
Iman

On 2 Feb 2024, at 13:21, GloriaB @.***> wrote:
Merged #16 https://github.com/icaps2024/icaps2024.github.io/pull/16
into master.
—
Reply to this email directly, view it on GitHub <
https://github.com/icaps2024/icaps2024.github.io/pull/16#event-11683444263>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAH42TVZ54EOCBAIYOSWNVLYRTK55AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY4DGNBUGQZDMMY>.

You are receiving this because you authored the thread.

—
Reply to this email directly, view it on GitHub
https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1932610274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGEMXB6LWO6HYBKZ4FQ3LTTYSO7Z5AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYYTAMRXGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Zlatan,Thanks for the quick reply. Nope - just the one I made a few days ago to set up the 2024 page. Should I make a new one again just for updating the page with new dates?Many thanks,ImanOn 7 Feb 2024, at 23:23, Zlatan Ajanovic @.***> wrote:
Hi Iman,
Did you make a new fork?
BR,
Zlatan
On Wed, Feb 7, 2024, 19:12 iawaad @.***> wrote:

Hi Gloria,

I just tried to update the PlanRob Workshop page but without much luck. I

had updated the dates to the following:

Paper submission: Monday, 25 March 2024

Notification of acceptance: Friday, 26 April 2024

Camera-ready version due: Friday 24 May 2024

Workshop Date: June 2-3, 2024

to sync better with the rest of the workshops… but somehow, I’m getting

the status that the working group is clean after I committed but on github

in the browser, I’m not seeing my change and so can’t lodge a pull request.

Please advise (and so sorry for the extra work).

Many thanks,

Iman

On 2 Feb 2024, at 13:21, GloriaB @.***> wrote:

Merged #16 https://github.com/icaps2024/icaps2024.github.io/pull/16

into master.

—

Reply to this email directly, view it on GitHub <

https://github.com/icaps2024/icaps2024.github.io/pull/16#event-11683444263>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAH42TVZ54EOCBAIYOSWNVLYRTK55AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY4DGNBUGQZDMMY>.

You are receiving this because you authored the thread.

—

Reply to this email directly, view it on GitHub

https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1932610274,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AGEMXB6LWO6HYBKZ4FQ3LTTYSO7Z5AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYYTAMRXGQ

.

You are receiving this because you are subscribed to this thread.Message

ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Yes, we would need a new fork for each change, as previous one is merged.
On Wed, Feb 7, 2024, 23:30 iawaad @.***> wrote:

Hi Zlatan,Thanks for the quick reply. Nope - just the one I made a few
days ago to set up the 2024 page. Should I make a new one again just for
updating the page with new dates?Many thanks,ImanOn 7 Feb 2024, at 23:23,
Zlatan Ajanovic @.***> wrote:
Hi Iman,
Did you make a new fork?
BR,
Zlatan
On Wed, Feb 7, 2024, 19:12 iawaad @.***> wrote:

Hi Gloria,

I just tried to update the PlanRob Workshop page but without much luck.
I

had updated the dates to the following:

Paper submission: Monday, 25 March 2024

Notification of acceptance: Friday, 26 April 2024

Camera-ready version due: Friday 24 May 2024

Workshop Date: June 2-3, 2024

to sync better with the rest of the workshops… but somehow, I’m getting

the status that the working group is clean after I committed but on
github

in the browser, I’m not seeing my change and so can’t lodge a pull
request.

Please advise (and so sorry for the extra work).

Many thanks,

Iman

On 2 Feb 2024, at 13:21, GloriaB @.***> wrote:

Merged #16 https://github.com/icaps2024/icaps2024.github.io/pull/16

into master.

—

Reply to this email directly, view it on GitHub <

https://github.com/icaps2024/icaps2024.github.io/pull/16#event-11683444263>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAH42TVZ54EOCBAIYOSWNVLYRTK55AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY4DGNBUGQZDMMY>.

You are receiving this because you authored the thread.

—

Reply to this email directly, view it on GitHub

<
https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1932610274>,

or unsubscribe

<
https://github.com/notifications/unsubscribe-auth/AGEMXB6LWO6HYBKZ4FQ3LTTYSO7Z5AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYYTAMRXGQ>

.

You are receiving this because you are subscribed to this thread.Message

ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHub
https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1933043378,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGEMXB5N76LVUQ5WLBSIO6TYSP57BAVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGA2DGMZXHA
.
You are receiving this because you commented.Message ID:
@.***>

Thank you so much and sorry for that — done :)
Have a lovely day!

On 8 Feb 2024, at 06:05, Zlatan Ajanovic @.***> wrote:
Yes, we would need a new fork for each change, as previous one is merged.
On Wed, Feb 7, 2024, 23:30 iawaad @.***> wrote:

Hi Zlatan,Thanks for the quick reply. Nope - just the one I made a few
days ago to set up the 2024 page. Should I make a new one again just for
updating the page with new dates?Many thanks,ImanOn 7 Feb 2024, at 23:23,
Zlatan Ajanovic @.***> wrote:
Hi Iman,
Did you make a new fork?
BR,
Zlatan
On Wed, Feb 7, 2024, 19:12 iawaad @.***> wrote:

Hi Gloria,

I just tried to update the PlanRob Workshop page but without much luck.
I

had updated the dates to the following:

Paper submission: Monday, 25 March 2024

Notification of acceptance: Friday, 26 April 2024

Camera-ready version due: Friday 24 May 2024

Workshop Date: June 2-3, 2024

to sync better with the rest of the workshops… but somehow, I’m getting

the status that the working group is clean after I committed but on
github

in the browser, I’m not seeing my change and so can’t lodge a pull
request.

Please advise (and so sorry for the extra work).

Many thanks,

Iman

On 2 Feb 2024, at 13:21, GloriaB @.***> wrote:

Merged #16 https://github.com/icaps2024/icaps2024.github.io/pull/16

into master.

—

Reply to this email directly, view it on GitHub <

https://github.com/icaps2024/icaps2024.github.io/pull/16#event-11683444263>,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAH42TVZ54EOCBAIYOSWNVLYRTK55AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY4DGNBUGQZDMMY>.

You are receiving this because you authored the thread.

—

Reply to this email directly, view it on GitHub

<
https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1932610274>,

or unsubscribe

<
https://github.com/notifications/unsubscribe-auth/AGEMXB6LWO6HYBKZ4FQ3LTTYSO7Z5AVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYYTAMRXGQ>

.

You are receiving this because you are subscribed to this thread.Message

ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID: @.***>
—
Reply to this email directly, view it on GitHub
https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1933043378,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGEMXB5N76LVUQ5WLBSIO6TYSP57BAVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGA2DGMZXHA
.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub https://github.com/icaps2024/icaps2024.github.io/pull/16#issuecomment-1933369625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH42TQALMMWN4ZAAJCTIH3YSRMILAVCNFSM6AAAAABCRURIVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGM3DSNRSGU.
You are receiving this because you authored the thread.


Front-end tryout - Edit project

I had created a project via the new front-end build. However, I have some questions regarding the "edit" project function. Thanks!

There are three boxes I can edit (general & science case). How about subjects & workflow? How can I edit them?
For the workflow, I changed "type": "single" to "type": "multiple" = the selection changed from radio button to check-box. How about "drawing"? can I draw boxes? when I changed to "drawing" it gave me radio button again. What other "type" are available?
How can I put content in the interface under "Status" and "Team"?

Checkout the zooniverse/Panoptes-Front-End for questions about the front end. I'll ping @brian-c for help on this too.

We're still getting documentation together, but he's some more info about Workflow task options https://github.com/zooniverse/Panoptes/issues/401#issuecomment-66874291

Thanks, I am playing with the "type": "drawing". Thanks for the documentation.

Editing subjects and workflows is not implemented yet. This is coming soon.

See Ed's link. There'll be a proper workflow-editor interface for this in the future.

"Status" and "team" content will be generated automatically.

Seems to be a Panoptes Front End issue to me.


nuScenes sampling not working correctly.

Hello,
I am trying to use your model, namely the sample.py but it is not working as intended. Some params I have changed is low_vram is True, and I reduced the image size to save on space to (128,256). However when I run the model the output is very strange, perhaps I have a misunderstanding as to how the model works.
But when i provide the 25 images, the prediction and GT are as so:
Ground Truth:

Predicted:

I thought it takes temporal context and so will continue after a certain point. But it seems like it does not do this.
Additionally, I then changed cond_frames to 10 as I thought this would solve it. But for the predicted frames, the first 10 frames are the GT, which i expected as they are given as context. But the predicted 15 frames continue from the first frame where the front of the truck is barely in sight, similar to the predicted seen in the images provided.

The model has never been trained on that aspect ratio (128/256), thus it's hard to generalize on that resolution. We suggest using resolutions of 320×576 or 576×1024, which the model has been trained on.

Ok understood. Are there any sample runs to show what it should look like on the full image size? I cannot find a demo for nuScenes on the repo

https://huggingface.co/spaces/rerun/Vista
It seems the link is broken to try the example on HuggingFace, I will try locally hopefully sometime soon. Thanks


Small dot in front of the task state. tooltips are not required for mouse movement.

任务状态前的小圆点，鼠标移入不需要tooltips。


🚢 Ship 1.0.4

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           14        17    +3
  Branches         0         1    +1
=========================================
+ Hits            14        17    +3

Impacted Files
Coverage Δ

src/vue-markdown-it.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624796...1571b97. Read the comment docs.


updating device images

is updating the device images something you would accept a pull request on?

Still would be great, @justincavery ! Can I help with preparing the new mockup images? But I guess it’s a little more complicated than just updating the device images.

Device images and the new ratio calculations for the size of the device would be all that is needed.


Fix ONNX Gather codegen for Shape input

Pull Request Template
Checklist

[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
This finishes some work still left after #2128 for ONNX Gather nodes to accept Shape inputs.
Without it, the actual codegen fails (Note that the error message is misleading, the Arg here is not a scalar but a Shape(2), but the message predates Shapes being used in ONNX imports):
  ERROR burn_import::logger: PANIC => panicked at burn\crates\burn-import\src\onnx\to_burn.rs:1245:18:
  Can't transform scalar to tensor.

  --- stderr
  thread 'main' panicked at burn\crates\burn-import\src\onnx\to_burn.rs:1245:18:
  Can't transform scalar to tensor.
  stack backtrace:
     0: std::panicking::begin_panic_handler
               at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library\std\src\panicking.rs:652
     1: core::panicking::panic_fmt
               at /rustc/051478957371ee0084a7c0913941d2a8c4757bb9/library\core\src\panicking.rs:72
     2: burn_import::onnx::to_burn::<impl core::convert::From<&onnx_ir::ir::Argument> for burn_import::burn::ty::TensorType>::from
     3: burn_import::onnx::to_burn::ParsedOnnxGraph::gather_conversion
     4: burn_import::onnx::to_burn::ParsedOnnxGraph::into_burn
     5: burn_import::onnx::to_burn::ModelGen::run_from_script
     6: burn_import::onnx::to_burn::ModelGen::run_from_script
     7: burn_import::onnx::to_burn::ModelGen::run_from_script
     8: build_script_build::burn::import_models
     9: build_script_build::burn::import_models
    10: build_script_build::burn::import_models
    11: core::ops::function::FnOnce::call_once
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

It will probably also be needed for the model in issue #2115 to import successfully.
Changes
Check if the input value is a Shape instead of a Tensor, and if so, convert the Shape to a tensor before doing the select operation.
Testing
Added an ONNX-Test for this case, as well as a codegen unittest.

Just a minor comment for now.
For the new shape type introduced this LGTM.
I'd like to get @antimora's feedback though. I know you wanted to avoid simple shape operations to be done on GPU and retrieved to CPU, but with this typical sequence of tensor -> shape -> gather ops we have the shape results on CPU and the indices for gather as a tensor. Hence we have to either convert the shape back to a tensor (as per this PR) or get the indices as a vec... didn't we just come back full circle to your initial concern?

We spoke offline. It's true we want to use Shape as much as possible (only when dealing with shapes) but in this instance is unavoidable since select needs a multidimensional tensor and shape information comes from CPU (struct).

It's true we want to use Shape as much as possible

I haven't implemented this here, but at least for the case where a Scalar index is selected from a Shape, a special path could be added to output another Shape with just the selected size (it would always be dim 1) completely on the CPU.
At least from the (admittedly few) ONNX I've seen where Shape and Gather are combined, the index was usually a Scalar anyways.
Of course, adding this will probably expose even more Ops that cannot handle Shape inputs correctly yet, so implementing something like that would likely introduce regressions in terms of model compatibility at first.


Hangs while checking for new versions

I just downloaded and installed npm-check, but all it does is hanging at the step where it supposedly is checking for newer versions of the used packages and that's it. I've let it run for about 12 hours now, but it never finished. There are also no error messages or anything, it just seems to idle there.
Checking npm registries for updated packages.

My assumption is, that there is a connection issue (behind company network here) that is not properly handled, but there is no indication that this is actually the case. node.js can connect to the internet without any issues (obviously since I installed npm-check).

+1

+1

+1

same

same issue. Hangs here:
⠼ Checking npm registries for updated packages.%

My network can access npm registry correctly. So, why hangs here? Any timeout error message will be better than hanging.

Same here in 2020, behind a corporate proxy with environment variables http_proxy and https_proxy set. I found that this package https://www.npmjs.com/package/npm-check-updates works well, but unfortunately lacks the interactive features of npm-check.


ADD fraud status and payment type, come on midtrans!

Fraud Status is required to check wether any credit card transaction was rejected or has any fraud detected.
Payment Type needed to re-map midtrans transaction with local transaction.

Come on midtrans!

wakakkaka

3D Secure disabled by default on snap, there is no option to add credit_card options. Fixed on bcfb90c.
With the credit card option avaiable, we can add CreditCard: &midtrans.CreditCardDetail{Secure: true}, on snapReq.

Hi @ariestiyansyah & @ngurajeka
Thanks for contributing!
Sorry took sometime to response.  The original maintainer for this repo has leave for quite sometime.


[WIP]bugfix for sealer run

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

What kind of bug you fixed? Could you provide more details about the bug? Nothing could be reviewed, I think. Actually I feel quite uncertain for the refactoring. I wish to get more thinking result from you guys. @kakaZhou719 @VinceCui

What kind of bug you fixed? Could you provide more details about the bug? Nothing could be reviewed, I think. Actually I feel quite uncertain for the refactoring. I wish to get more thinking result from you guys. @kakaZhou719 @VinceCui

Sorry I merged the code，its some little bugfix in the refactoring process which is intermediate, I should have added the details about it.


Separate lexer and parser from cfront

This pull request separates the lexer and parser into independent modules from original cfront module. This is the predecessor task for later tokenizer optimization (e.g. less side effect).

I defer to @vacantron for reviewing.

Thank @ChAoSUnItY for contributing!


Add DEP Notify Clean Up

Is your feature request related to a problem? Please describe.
Some folks have requested clean up of DEP Notify app and some files that live in /var/tmp. Creating this enhancement request to track community interest.

Added error warning for end users into the develop branch.


Deprecation since 2024.5.0b0

2024-04-25 08:20:40.546 WARNING (ImportExecutor_0) [homeassistant.helpers.typing] HomeAssistantType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'webrtc' custom integration
2024-04-25 08:20:40.549 WARNING (ImportExecutor_0) [homeassistant.helpers.typing] ServiceCallType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.ServiceCall instead, please report it to the author of the 'webrtc' custom integration

Thanks. I think this is fixed in latest master version

Hello!
I still get the warnings on HA 2024.5.1, webrtc v3.5.2
Logger: homeassistant.helpers.typing
Source: helpers/deprecation.py:206
First occurred: 20:18:00 (2 occurrences)
Last logged: 20:18:00

HomeAssistantType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'webrtc' custom integration
ServiceCallType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.ServiceCall instead, please report it to the author of the 'webrtc' custom integration

Yeah, it is fixed in master already by this commit: https://github.com/AlexxIT/WebRTC/commit/d132c8c351071947eee6b8efb7eb78229d114b9f
So it should be solved when the next version ships. Thanks Alexx!

Same here!
Core 2024.5.3
Supervisor 2024.05.1
Operating System 12.3

Still getting this message in HA 2024.9.2

If you want them to vanish so badly, then use the master version. You easily can check when it will be fixed otherwise.
New version?
No? Not fixed.
Yes? Fixed.

Just adding that im seeing the below
HomeAssistantType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'webrtc' custom integration
ServiceCallType was used from webrtc, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.ServiceCall instead, please report it to the author of the 'webrtc' custom integration

https://github.com/AlexxIT/WebRTC/releases/tag/v3.6.0


Improve onTranslationNotFound callback

Hi Martin,
I want to use onTranslationNotFound event listener for missing translations tracking. But unfortunately it doesn't provide missing key's scope so it is hard to locate a problem when there are a lot of scoped translations with the same key.
What do you think about adding scope to callback arguments?
translate.onTranslationNotFound(function(locale, key, fallback, scope) {
  ...
});

Thanks, Ivan! I've just merged it and released v0.17.8. Enjoy!

Cool. Thanks!


Multus CNI does not work for v4.0.0.

Hello, I just tried installing your Multus CNI helm chart and noticed that I got the following error when trying to use image v4.0.0:
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "cp": executable file not found in $PATH: unknown
Back-off restarting failed container

The Multus DaemonSet started up fine when using v3.9.3.

Thank you for using this chart.
I update the chart to support Multus CNI v4.0.2 with Thick Plugin.
Have a good day.


Feature reorder projects

Based on branch from @beyersito (see PR #310).
I'm comandeering this to get this ready.
I think this is ready for review - I just need to find the offset issue that occurs if icon is dragged with a scrolled sidebar (see third screenrecording)
Related Issue:
#195
Summary:

Rebased to master (Reorder projects was using React-Motion - so this rebase changed a lot of the branch & hopefully I've fixed everything.)
Added review comments & fixed scroll behaviour

Screenshots/GIFs:
Drag & drop with fullscreen window

Drag & drop reduced window size (not scrolled)

Drag & drop reduced window size (scrolled) - y-offset issue

Todo

[x] Review code because rebase was pretty heavy
[x] Fix failing tests
[x] Placeholder is not keeping the previous location open during dragging so the AddProject button will move
[x] Check flow type of tasks
[x] Improve coverage
[x] Fix drag & drop issue - mouse position is getting an y-offset if sidebar is scrolled (see screenrecording)

I just did some research and looks like people were having the same offset issues, and it was due to a parent node that had the transform property. Sure enough when I removed the offset and all the animated stuff on Wrapper the issue went away. See https://github.com/atlassian/react-beautiful-dnd/issues/499#issuecomment-389724270
I pushed up the fix but I'm not sure why we were using animation on the wrapper, can you take a look? Not sure if it was actually necessary (feel free to bump off the commit if it's not a good fix :)

@melanieseltzer 👍 wow, great. For me that's OK. I'm not sure why there was an animation on the y-offset. Maybe it was a slide-in animation but I haven't seen that.
I think it's OK to remove. If there was an anmiation we could add it later.

@AWolf81 Turns out animation is needed for the sidebar slide in, so instead I've just implemented a portal which is the recommended fix in the original issue I posted above. I removed the previous commit since I needed to undo it - can you make sure this portal fix is working for you? Looks good my end.

I think I'll have to do some debugging later today because there are two things I'd like to check:

Added divs at end of body (two more divs after each drag&drop) & scrollbars (see screenshot below)
Dragging sometimes not working as the cursor not changing to a finger (could be related to 1. or I reduced the screen height too much)

Good catch, I think it was due to being in the render so I moved the portal creation outside, does that fix things? (not sure about the scrollbars because I don't see them but maybe it was all related).

Good idea, just added the id 👍 In terms of extracting the portal to its own location, I think we could wait until we need to reuse it somewhere else since it's a pretty specific fix for a niche issue.

@AWolf81 i'll extract that issue with Infobar into a separate issue for cleanup. I think that's a Windows specific thing because I don't have the problem.


[docs] Fix MUI Treasury links

[x] I have followed (at least) the PR section of the contributing guide.

Closes https://github.com/mui/material-ui/issues/40554

What should we do with this 404 https://mui.com/material-ui/discover-more/related-projects/#layout? Around @mui-treasury/layout.

What should we do with this 404 https://mui.com/material-ui/discover-more/related-projects/#layout?
(around @mui-treasury/layout).

Opps, missed this one. will open a PR.