Batch link to vcenter

Add command az connectedvmware create-from-machines.
Delete HCRP Machine resource by default during delete vm. To retain, use --retain-machine flag.
Use GA API Version for VCENTER_KIND_GET_API_VERSION.
Set extension to non-preview and update version to 1.0.0

Related command

az connectedvmware
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please fix CI issues.

Please fix CI issues.

The CI failure looks to be unrelated to the code changes. It failed because it was unable to authenticate to the nuget endpoint. Link
Attempting to gather dependency information for package 'Microsoft.Security.CredScan.2.1.17' with respect to project 'D:\a\_work\_sdt', targeting 'Any,Version=v0.0'
MSBuild auto-detection: using msbuild version '<IP_ADDRESS>704' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin'.
Using credentials from config. UserName: VssSessionToken
WARNING: The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
Unable to load the service index for source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json.
  Response status code does not indicate success: 401 (Unauthorized).
##[command]"NuGet.exe" install Microsoft.Security.CredScan -Source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json -Version 2.1.17 -ConfigFile D:\a\_work\_sdt\dt.nuget.config -NonInteractive

Please fix CI issues.

The CI failure looks to be unrelated to the code changes. It failed because it was unable to authenticate to the nuget endpoint while downloading the CredScan tool. Link
Pipeline failures started 2 days back - I can see other PRs failing with same error.
Attempting to gather dependency information for package 'Microsoft.Security.CredScan.2.1.17' with respect to project 'D:\a\_work\_sdt', targeting 'Any,Version=v0.0'
MSBuild auto-detection: using msbuild version '<IP_ADDRESS>704' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin'.
Using credentials from config. UserName: VssSessionToken
WARNING: The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
Unable to load the service index for source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json.
  Response status code does not indicate success: 401 (Unauthorized).
##[command]"NuGet.exe" install Microsoft.Security.CredScan -Source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json -Version 2.1.17 -ConfigFile D:\a\_work\_sdt\dt.nuget.config -NonInteractive

We have sent an email to Microsoft Security Code Analysis Support for help, thank you for your reminder.

/azp run

Add @yanzhudd and @ReaNAiveD to help review this PR.

/azp run

Please fix the CI issues.

Please fix the CI issues.

All the failures are happening due to appservice-kube extension, which were not happening before. The failures might be happening because this PR got merged without the CI build tests running?

/azp run

The CI has passed after re-running.


Fix #20284

Fix zephyr-env.sh side effects. For example, when using zsh p9k theme will cause some problems that affect the experience.

@bandheight thanks for the PR. Can you  please format the commit message according to the project rules?
https://docs.zephyrproject.org/latest/contribute/index.html#contribution-workflow

Thanks for your contribution @bandheight .
Note that the bot is going to complain about this commit not meeting this https://docs.zephyrproject.org/latest/contribute/index.html#commit-guidelines
(you will need to fix it)
With regards to the PR, please set a title that is descriptive of the change itself

I have changed my github name to Hosun Zhu.
Why can't pass CI checks?

@bandheight it's not the GitHub  name, but the name that git sees in your ~/.gitconfig


Thread safety improvements

This is another part of the thread on this branch.  There are some changes here that should make the fixes to the filters work a little nicer, which is why I am submitting a PR now.
The goal is to isolate the core thread to minimize the number of syncrhonization locks between the API facing calls and the processing loop.  Previously there was locks taken on pretty much every federate interaction.  This PR partitions the internal federate object maps between the API callable functions and the internal loop.  A number of other things were fixed along the way to getting there.
The future iteration of the branch will do the same thing to the interface object representations.  which should reduce the number of locks taken quite a bit further.
I have said this before but it may have fixed some of the long standing issues that occasionaly come up on travis and appveyor.

@nightlark  can you resolve the conflict once you merge #226,  I am not totally clear on what the resolution is right now.

A number of the file changes are library updates to cereal and libguarded which are merges from the upstream source.
Another change is more work on the integration of named_points and bool into the helics well supported types.  Additional tests are required to verify operation and then add the functionality to the C interface

Yea, I'll resolve the conflict. I want the last mac build to finish to make sure the cache gets updated. Huge backlog on Travis for OS X builds right now.

@kdheepak can you take a look at this, see if you notice any issues?


Support to Ubuntu 16.06

This cookbook then support to ubuntu 16.04?
In my test falied when I include in my cookbook.

In our cookbook version that worked it was to 7.0.0 due to other dependancy. Thank you very much.


onDrop missing?

Having some issues getting onDrop to work. I am passing a function down, if I do with any other callbacks e.g. onDragStop it works but not for onDrop.
I can see that onDrop is refered to in the docs and it is used in /lib/ReactGridLayout.js on GitHub.
However when I install the package it is not used in node_modules//build/ReactGridLayout.js

Seeing the exact same issue. The build of ReactGridLayout does not contain onDrop at all:

Ran the build myself locally, and onDrop can be found in ReactGridLayout.js. So I checked out the commit from the most recent release (0.16.6) and ran the build. Lo and behold, onDrop is missing from all the build files. @STRML We need a release with the newest features!

@tomc278 Looks like this feature was only recently added to the project. See https://github.com/STRML/react-grid-layout/pull/997

I'm closing this issue because it will be fixed in the next release as noted by @Jacob-Grafenstein


Register JuliaBinaryWrappers/Geant4Builder_jll.jl v0.1.0+0

Autogenerated registration for JuliaBinaryWrappers/Geant4Builder_jll.jl v0.1.0+0

Ehhh, wait a minute, it's got Builder at the end of its name.  Orz.


Flake8 rule 'E231' reported an invalid point

Flake8 reported an invalid point for the rule E231, with the messge missing whitespace after ','.

Debug information:
Atom version: 1.15.0
Flake8 version: 3.2.1 (pyflakes: 1.3.0, mccabe: 0.5.2, pycodestyle: 2.2.0) CPython 2.7.12 on Darwin

Are you able to share code to reproduce this?
There is currently a known bug with unicode characters that might be causing this, but without code it's impossible to say.

It can be reproduced with the following code.
import jaconv

class Foo():

    @staticmethod
    def _create_option_object(position, entry_name, value, is_size=False):
        return {
            'position': position,
            'entry_name': entry_name,
            'value': jaconv.h2z(value) if value else None,
            'is_size': is_size,
            }

    @staticmethod
    def _concat_names(sep, names):
        str = None
        for name in names:
            if not str and name is not None and name.strip() is not '':
                str = name
            elif name is not None and name.strip() is not '':
                str += '%s%s' % (sep, name.strip())
        return str

    def bar(self):
        # do something
        return {
            'options': [
                self._create_option_object(1, 'テスト', self._concat_names('',[
                    None,
                    'test',
                    ]), True),
            ],
        }

If 'テスト' is changed to one character by Unicode character like 'テ' or when it is changed to ASCII character, it does not occur,
It may concern you bugs.

Ah ha! Thanks for providing the code.
This is another case of pycqa/flake8#306 which is fixed on their master branch and should be in the next flake8 release. Unfortunately there isn't anything that can be done here till then 😞.

I understand. Thank you.


fix(pkg/downloader): Remove comparing hashed digests on build cmd

Signed-off-by: Hang Park<EMAIL_ADDRESS>This PR includes the removal of checking sync status of Chart.yaml and Chart.lock dependencies before executing the main functionality of helm dependency build.
This resolves #6416. Moreover, similar to #6416, this resolves abnormal failures on build when Chart.yaml contains some subchart versions in the form of SemVer range, too.
Fixes #6416
What this PR does / why we need it:

#6416 reports that helm dependency build command (abbr. build) fails if Chart.yaml contains subchart's alias.
I found that a same failure happens if Chart.yaml contains SemVer range on some of its subcharts.

These two bugs are originated from a mismatch of hashed digests of deps in Chart.yaml and Chart.lock.

Before #5874 merged, hashed digest in Chart.lock is calculated from Chart.yaml deps.
This makes Chart.lock not be updated properly when all of below happened:

subchart's version is written in SemVer range
that subchart is updated to a new version (still within the range)
helm dep up is executed and so the new version is installed

because it is true that the contents of Chart.yaml are not changed!
So, #5874 made digest calculation to use Chart.lock contents, not of Chart.yaml.

But notice that (1) lock file does not contain alias information and (2) lock file has specific resolved versions while yaml file may have version ranges.
Checking sync on yaml & lock (actually comparing hashed digests of deps in each file) in build command worked well before #5874.
However, after that PR merged, this comparing process is not valid with ranged versions (and #6416 was a bug even before #5874.)
More technically, build command (1) loads a chart and stores it in var c *chart.Chart, (2) calculates the hash value of c.Meta.Dependencies, and then (3) compares it with c.Lock.Digest value, which was already written in the Chart.lock file.
That c.Lock.Digest is originated from previous dep update command, which (1) loads a chart, (2) resolves deps, (3) calculates the hash value of resolved deps, and then (4) stores resolved deps along with its hash value as a digest into Chart.lock file.
Note that c.Meta.Dependencies[i].Alias may exist but c.Lock.Dependencies[i].Alias is always empty, and that c.Meta.Dependencies[i].Version may be SemVer range but c.Lock.Dependencies[i].Version is just a single resolved version. (see internal/resolver/resolver.go)

Thus, I removed comparing hashed digests of two files in build command.
Special notes for your reviewer
My PR is the simplest way to fix bugs I think, but there are many other approaches without removal of comparing two files.  For example:

record digests of both original deps declaration and resolved lock file contents, so use one of it in each desired situation properly (we can concatenate two digests into one digest, maybe)
instead of comparing digests, determine out-of-sync manually like: dep_yaml.name == dep_lock.name && dep_yaml.repo == dep_lock.repo && dep_yaml.version CONTAINS dep_lock.version && each pairs of (name, repo) in Chart.yaml APPEARS in Chart.lock also (and vice-versa.)

If you guys think these approaches are better than this PR, I'd like to work further on this issue.
If applicable:

[x] this PR contains unit tests

Thanks a lot for this PR @hangpark . Looks like you fixed a bug, could you write a failing test that reproduces the bug / root cause of the bug? So that your code can pass the failing test 😄 I'll try to understand the code in the meantime

Hi, @karuppiah7890. I just pushed a commit for failing tests. These tests are all passed in mine but failed in upstream dev-v3. Following is a result of reproduced failures:
=== RUN   TestBuild_WithoutOptionalFields
--- PASS: TestBuild_WithoutOptionalFields (0.01s)
=== RUN   TestBuild_WithSemVerRange
--- FAIL: TestBuild_WithSemVerRange (0.01s)
    manager_test.go:250: Chart.lock is out of sync with Chart.yaml
=== RUN   TestBuild_WithAlias
--- FAIL: TestBuild_WithAlias (0.01s)
    manager_test.go:250: Chart.lock is out of sync with Chart.yaml
=== RUN   TestBuild_WithCondition
--- FAIL: TestBuild_WithCondition (0.01s)
    manager_test.go:250: Chart.lock is out of sync with Chart.yaml
=== RUN   TestBuild_WithTags
--- FAIL: TestBuild_WithTags (0.01s)
    manager_test.go:250: Chart.lock is out of sync with Chart.yaml
FAIL

You can check that optional fields make a failure.

@hangpark Thanks for digging into this! It seems like the logic is pretty sound, but I'm going to get @mattfarina and @bacongobbler to take a look at this as well because the dependency locking code is not something I've messed with too much

@mattfarina Thanks for your review. Instead of comparing digests, I tried to implement comparing the contents of the chart and the lock file manually. Is this good enough to inform unsynchronized status to the end-users?

@hangpark The idea of the digest is to make sure the lock file was generated from the content of the requirements. If the requirements changed then the hash would change and you would know the lock file was not generated from those requirements. This is a simple check. Why does this not work?

@mattfarina I agree that digest comparison is a simple idea to compare dependencies and the lock file. But by #5814, the digest in a lock file is generated from lock contents. These lock contents don't have any information about aliases, conditions, tags, and version ranges. The digest comparison in dep build command compares that digest from lock contents, to a newly calculated digest from Chart.yaml dependencies. It fails if Chart.yaml has any of aliases, conditions, tags, or version ranges. Unless digest calculation is changed to use both Chart.yaml and Chart.lock, we cannot know whether the lock file is out-of-sync or not from the digest.
Since I'm new to here, I couldn't determine which solution is the best one, as I introduced several approaches in the Special notes for your reviewer section above. I picked the second one, and I know that one doesn't use the digest anymore.
To reflect your point in this PR, I think we should change the digest calculation function (HashReq()) to accept two arguments, Chart.yaml dependencies and Chart.lock dependencies. It can make the digest be aware of both Chart.yaml and Chart.lock changes. How do you think about this approach? It would work with both dep build and dep up.
In this approach, I worry about an edge case:

Chart.yaml has >= 1.0.0 dep
Lock file created, 1.0.1 targetted.
Change Chart.yaml from >= 1.0.0 to >= 1.0.1
Lock file still valid in range, but dep build will fail with out of sync.

Apologies for the automatic closure. We just switched the dev-v3 branch to master, and the old master branch is now dev-v2. Feel free to re-open a new PR with this change. Thanks again and sorry for the hassle!

Re-open in #6736


test(e2e): add gateway upgrade in upgrade test

Description
Closes: https://github.com/zeta-chain/node/issues/2921

Closing for https://github.com/zeta-chain/node/pull/2932 (rebasing issue)


Implement mapped type

Suggestion

🔍 Search Terms

implement mapped type
class implements mapped type
interface extends mapped type
autocomplete for mapped type in class
intellisense for mapped type in class

✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

I would like to implement a mapped type from a class and let Typescript/VS Code implement the methods I just created using template literal types.
export const methods = [
  "GET",
  "POST",
  "PUT",
  "PATCH",
  "DELETE",
  "OPTIONS",
  "HEAD",
] as const;

export type Method = typeof methods[number];

type MethodMapper = {
  [P in Method as ${Lowercase<string & P>}]: () => void;
};

class Router implements MethodMapper {
}

Currently the Typescript Playground and Visual Studio Code doesn't implement my new type:

📃 Motivating Example

Implement a mapped type into a class using template literal types.
💻 Use Cases

Currently I'm working in a new routing library and want to type check new methods added in methods array. For now the workaround is implement the methods by hand in my class.
Thank you in advance.

@RyanCavanaugh I traced the problem (i.e., why Implement inteface code fix does not show up) and this is the result.
Problem
When there's no explicit keyof T in the mapped type definition, there'll be no declarations available for the corresponding symbols (i.e., symbol.getDeclarations() returns undefined), hence, no "Implement interface" code fix appears.
Take this simplified case as an example:
type Base = { ax: number; ay: string };
type BaseKeys = keyof Base;
type MappedDirect = { [K in keyof Base]: boolean }; // Has explicit keyof T
type MappedIndirect = { [K in BaseKeys]: boolean }; // Implicit keyof T via BaseKeys
class MappedImpl implements MappedDirect, MappedIndirect { }

Here in MappedDirect definition there's a keyof Base whereas in the MappedIndirect the keys are read indirectly from the BaseKeys intermediate type. If you open this code segment in VS Code, then you'll see the "Implement interface" code fix is just available for the MappedDirect:

From the parser/type-checker point of view, the difference lies at checker.ts:11717 where modifiersType is set to undefined for the MappedIndirect type:
//checker.ts:11714
const modifiersType = getApparentType(getModifiersTypeFromMappedType(type)); // The 'T' in 'keyof T'

This results in modifiersProp set to undefined:
//checker.ts:11745
const modifiersProp = isTypeUsableAsPropertyName(keyType) ? getPropertyOfType(modifiersType, getPropertyNameFromType(keyType)) : undefined;

And with modifiersProp being undefined, the declarations property is not assigned:
//checker.ts:11757
if (modifiersProp) {
    prop.syntheticOrigin = modifiersProp;
    // If the mapped type has an `as XXX` clause, the property name likely won't match the declaration name and
    // multiple properties may map to the same name. Thus, we attach no declarations to the symbol.
    prop.declarations = nameType ? undefined : modifiersProp.declarations;
}

Solutions
I can think of two solutions:

Update the type checker and see if the ConstraintType (i.e., X in K in X) is itself defined as keyof T then assign modifiersType with T. However, this might work for only one level of indirection and will probably fail (i.e., keep the existing behavior) in cases like this (although I didn't really check that):
type Base = { ax: number; ay: string };
type BaseKeys = keyof Base;
type BaseKeysIndirect = BaseKeys;
type MappedIndirect = { [K in BaseKeysIndirect]: boolean };
class MappedImpl implements MappedIndirect { }

Do not modify the checker, and fix this case at the language services level. That is, when there's no declaration available for a symbol, just assume it as a simple property. This needs modification of addNewNodeForMemberSymbol function defined in src/services/codefixes/helpers.ts. I've already pushed an implementation of this solution to be used if maintainers deemed fit.

@RyanCavanaugh What's your opinion?

You generally don't want to touch the checker to fix a LS issue unless it's returning something manifestly wrong, which in this case it's not. I think the fix in the PR is likely the appropriate path.


Fix/multiple interfaces with same name in source generator

Fixes #252.
Add support to the source generator for multiple interfaces with the same name but in different assemblies, or with different number of generics type parameters.

Tested with:
using System.Threading.Tasks;
using RestEase;

namespace SourceGeneratorSandbox
{
    public record HttpBinResponse
    {
        public string? Origin { get; set; }

        public string? Url { get; set; }
    }

    public class Program
    {
        public static async Task Main()
        {
            var impl = RestClient.For<ISomeApi>("https://httpbin.org");
            var response = await impl.GetAsync();

            var impl2 = RestClient.For<AnotherNamespace.ISomeApi<HttpBinResponse>>("https://httpbin.org");
            var response2 = await impl2.PostAsync();
        }

        public interface ISomeApi
        {
            [Get("/get")]
            Task<HttpBinResponse> GetAsync();
        }
    }

    namespace AnotherNamespace
    {
        public interface ISomeApi<T>
        {
            [Post("/post")]
            Task<T> PostAsync();
        }

        public interface ISomeApi<T1, T2>
        {
            [Post("/get")]
            Task<T1> GetAsync();

            [Post("/post")]
            Task<T2> PostAsync();
        }
    }
}

@canton7, provided that you agree with this fix, do you have any plans for a release any time soon, so I can start using it?

Addressed in 4694c856585db62a2e38e458a17d76b4d83ba930


Update NodeJS and various flags

Updates NodeJS to v10
Adds --build-release-test flag, which will point terraform at the latest release test build (which triggers on commits to the release-* branches).
Adds --build-dev flag, which points terraform to the dev build (HEAD)
Exposes docker images as variables in terraform
Adds --use-gcloud-auth which will bypass creation of the SA key
Moves Turbinia virtualenv calls to bottom to minimize what gets executed out of the virtualenv
Changes GCS bucket access to "uniform access"

@berggren Can you please review this?  I don't have access to request a reviewer :).


file path is wrong within workspace with multiple folders

I have the following workspace with two folders:

You can add a new folder to the current workspace like this

The errors are shown in the "Problems" tab but not in the file editor (no squiggle underlines).

Note that the file path is /null/..., which is wrong.

I've had a look, I didn't reproduce the /null/ path bug, but I think I know what the problem is. The extension is just a translation layer between the Idris IDE process and VS, and currently it only ever launches a single Idris process. That IDE process needs to be launched in the app directory for the IDE commands to work, so to work with a multi-root workspace it would need to launch multiple processes, one per workspace-folder.
That the logic to get the directory path is assuming a single workspace-folder is definitely a mistake, at the very least it should display an error to the user that it can't currently handle multi-root workspaces. Your change would make it work, but only for the first folder.
For now, I'll document that it doesn't support multi-root workspaces, because the current behaviour is confusing and annoying. Longer term, I think launching multiple client processes could work, but I'm not sure how complicated it would be, so it might take a while.


Rewrite and unify damage parsing

Support non-dice damage [3 cut].   Can support all other modifiers.   This is a legal (if stupid) roll formula:  '5-2x3(2) cut', and it displays:
5-2 = 3.
Total = 3 x 3 = 9
If there are no dice rolled, and there are no other modifying factors to the damage "roll", the drag-able section does not contain a collapsible section (since there is nothing to display).
Don't tell anyone... we now support any sided dice for non-targeted (e.g attribute, skill), non-derived damage (e.g. SW+1) rolls.    Examples: [3d4], [2d10 cut], [2d100-30x3(0.5) imp]
We only show the dice sides if they are part of the damage formula (e.g. '3d6').   If they are not included, we assume 6 sided dice, and we display the roll in 'GURPS' format (e.g '3d')

Also changed Knockback chat message to use [DX | S:Acrobatics | S:Judo] OtF form so the player doesn't have to figure out which is best


Full Assets with no URLs

I am building an Ember app and would like to use Semantic UI. However, I cannot have external access to URLs. It will be on a closed off system that will need to have everything it needs locally in order to work, so the links to things like 'fonts.gstatic.com', for instance, won't work.
Is there a way to download a complete package of Semantic UI somewhere? If not, is there a way to quickly update it so that I can use it without needing those external URLs?
Thanks!

Closing this out since it looks like you received an answer in the Semantic-UI issues thread. Hopefully you were able to work it out.


duplicate resource type

Hello!

Vote on this issue by adding a 👍 reaction
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details
It seems that resource Switch and Subnet refer the same thing, alicloud_vswitch in Terraform.
And documentation for Subnet resource is incomplete.
If Pulumi intentionally use Subnet as an "alias" for Switch, the documentation should be fixed, and improved by saying that both resource type do the same thing, except different urn.
Personally, I would prefer removing Subnet resource from alicloud provider, to stay in consistent with alicloud terms.

Hi @zhangyoufu - thank you for reporting this!
It does appear that the Subnet resource is either deprecated or never existed. This should get fixed with the next release of this provider in #262.
Thank you and apologies for any confusion.

Hi @guineveresaenger
#262 (closed) was superseded by #278 (merged), but this issue still exists. Please take a look. Thanks.

Hi @zhangyoufu - I added a deprecation message to the Subnet resource. Because removing this is a breaking schema change, we will remove it on the next major release of this provider.


Auto Pointing option for only line-start and line-end timestamps

I don't think this is currently possible with auto-pointing. I would like to be able to use auto-pointing to create time markers only at the start and end of all lines.

I didn't expect such a use.
Since it is almost line synchronization, it can be considered as the range of Lyrics TTE.
An easy implementation is to add options to RhythmiKaRu,
It is a matter of consideration to add options that are not expected very much.
Well, there's no reason why you shouldn't use RhythmiKaRu to create line syncs.
Apart from Auto Pointing for karaoke, it may be possible to create Auto Pointing for line synchronization.
そういう用途を想定していなかった。
それってほぼ行同期なので、LyricsTTEの範囲とも考えられる。
簡単に実装するのはRhythmiKaRuにオプションを追加する方法だが、
あまり想定していないオプションを追加するのは検討の対象。
ただまあ、RhythmiKaRuを使って行同期作成をやったらダメな理由もないから、
カラオケ用Auto Pointingとは別にして、行同期用Auto Pointingを作ってもいいかも。

The [start_time]lyric[end_time] lyrics are considered "2 star Karaoke" according to AutoLyric. It uses the end_time to start the fade-out animation of the line. Currently I am using a regular expression substitution I made to add time markers at the start and end of each line (https://regex101.com/r/m4ftIt/2), but I thought it would be nice if this feature was built in to RhythmiKaRuTTE.
I have only been doing 2-star timing like this since a few days. Before I used to make these in LyricsTTE like you said, but it involves more steps. I would add empty lines after each line to be able to time them, and after I'm done, use a regex to move all of these fade-out timestamps behind the line that came before it.
So, from
[00:00.00]Some lyric
[00:02.00]

to
[00:00.00]Some lyric[00:02.00]

As you can see, this is more tedious than using RhythmiKaRuTTE, which supports this syntax already.

Thank you, this is great!


Required fragments

Hi!
Is there any way to mark some fragments as "required" so if they return error code we should return some general error page instead of broken one? This can be useful in case we want to show "Server error page" if server that server our header & footer is unavailable.
P.S.: It this behaviour makes sense for you guys I can help with a PR.

@StyleT Yeah its totally possible and you can mark the fragment that you want to control the status code of the page as primary
<fragment primary src="url.com"></fragment>

and if you want to control the fragment fallback then you can also give the fallback-src if its down.

@vigneshshanmugam problem here that header & footer fragments are not actually primary fragments. primary one in this theoretical setup with header, body & footer fragments is actually a body.
And I can't use few primary fragments on the page.
Talking about fallback-src. Great feature, but what if fallback is also broken?

This Should clarify the overall idea..

There can be only one primary fargment on the page..  (If you have multiple the first one wins)
Primary decides the status code.. if primary fragment is down and doesn't have a fallback-src then 500 status code is returned and none of the fragments are rendered.
If primary fragment is down and it does have a fallback-src then page will be rendered with 500 status code and fallback is fetched
If fallback is also down then status code will be still 500.. but the response is ignored.. all the other fragments are rendered as well.

@vigneshshanmugam yep, got it.
But what if I want to mark some fragments in such way so if some of them (and their fallbacks too) are down we should return some general error page instead of broken one?

@StyleT Hmm we haven't had/thought about this case.. Because we always serve the fallback-src from a CDN ( static error html)..
Doing the proposal that you are aiming for would require lots of bookkeeping and will need some tweaks in the way we compose streams!..

Having the fallback of the fallback doesn't make sense to me..

I agree with @w0rm on this and in the end you would need to fall back to a page when your primary/required fragment is not available which is already solved in tailor.
Having required is not in scope for now, Hence closing the issue


Cannot change battery

When i open the change battery window - i can't choose a battery in a list.
The game just don't switch to a new battery, despite any Valve Index key press or grab or anything.
This makes game unplayable because I can't charge them and can't create new ones all the time, just don't have such resources.
I installed this mod only on fresh stable subnautica today + BepInEx

I changed controller shortcuts trough native steam overlay and problem was solved.


Create a JSON-B stream writer

Add support for a Publisher<Pojo> when writing a WebServer response using
Response.send(publisher, Pojo.class) (also usable in client when sending request).

Have a look at https://github.com/oracle/helidon/pull/1796 - JsonpBodyWriter.java

Here's one approach https://github.com/michael-simons/neo4j-examples-and-tips/blob/master/examples/neo4j-and-helidon-se-reactive/src/main/java/io/helidon/examples/quickstart/se/api/MovieBodyStreamWriter.java
Should be generified but I guess you get the idea.
For reference http://ndjson.org
That would also be more appropriate for the Jsonp writer… With it, one can actually stream the content.

A different approach leading to the same Sse Events that Quarkus and Spring produce:
public final class SseJsonObjectBodyStreamWriter implements MessageBodyStreamWriter<Object> {

	private static final MediaType APPLICATION_X_NDJSON = MediaType
		.parse("text/event-stream;element-type=\"application/json\"");
	private static final Jsonb JSON_FACTORY = JsonbBuilder.create();
	private static final byte[] DATA = "data: ".getBytes(StandardCharsets.UTF_8);
	private static final byte[] NL = "\n\n".getBytes(StandardCharsets.UTF_8);

	@Override
	public PredicateResult accept(GenericType<?> type, MessageBodyWriterContext context) {
		return PredicateResult.supports(Object.class, type);
	}

	@Override
	public Flow.Publisher<DataChunk> write(Flow.Publisher<? extends Object> publisher,
		GenericType<? extends Object> type, MessageBodyWriterContext context) {

		context.contentType(APPLICATION_X_NDJSON);
		return Multi.defer(() -> publisher)
			.flatMap(m -> Multi.just(
				DataChunk.create(DATA),
				DataChunk.create(JSON_FACTORY.toJson(m).getBytes(StandardCharsets.UTF_8)),
				DataChunk.create(NL))
			);
	}
}


Add package and workflow generation files (client)

Context for PennyLane-Orquestra
This is the first in a line of additions making up the PennyLane-Orquestra plugin.
The main idea for the PennyLane-Orquestra plugin is that it allows integrating PennyLane with Orquestra to execute remote jobs sent from PennyLane. By using a device added defined in the PennyLane-Orquestra plugin, users can send jobs for execution to Orquestra via executing QNodes from PennyLane. As part of the first alpha version of the plugin, given a quantum function, PennyLane-Orquestra allows computing expectation values of operators using the familiar UI provided by PennyLane.
The plugin aims to reserve the modularity provided by Orquestra and allows interfacing with several backends.
Additions & changes
This particular PR has mainly two types of additions:

Boiler plate for the PennyLane-Orquestra package:

setup.py for the plugin
src/setup.py for the PennyLane component used by Orquestra (needed to be able to run a step which is tba)
README.md (to be changed in upcoming docs change), version.py, etc.
CI for GitHub actions

Code that allows generating of Orquestra workflow files.

In specific, we'd like to generate workflows that are compatible with the run_circuit_and_get_expval function in the steps/expval.py file (https://github.com/PennyLaneAI/pennylane-orquestra/pull/2).
Note on the folder structure of the repo
This repo will contain code executed at two different places: code that's executed on the client-side (user machine when running code using PennyLane) and code that's executed by Orquestra (server-side executing the jobs defined in Orquestra workflows).
Server-side

The steps folder contains the functions used in generated workflows as steps.
The src folder contains further server-side auxiliary code (if any).

Client-side

The pennylane_orquestra folder contains client-side code created as part of the
PennyLane-Orquestra plugin. It includes a base device class, further specific devices (e.g., Qiskit, Qulacs, etc.) and auxiliary functions for interacting with Orquestra.

Thanks for the review @co9olguy and the comments @Thenerdstation @josh146! Were very useful. :slightly_smiling_face:

Thank you for the review @josh146! Addressed your comments. Will merge this one, but can adjust details further in the subsequent PR.


rm -rf /var/lib/apt/lists/* everywhere

Your Dockerfiles have that gem in them. i think what you want to do is sudo apt clean to flush downloaded packages.

Thanks for pointing this out @StyXman.
I think originally I found that recommendation here - https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#apt-get
I'll try to replace it with apt-get clean and will see what the results will be.

According to https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run

Official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required.


[Suggestion] Allow complications to be visible to GM only.

Great mod.
Some complications need to be GM only since they are setups for role-play opportunities that the PC should not see.
In other cases, though, it makes a fun bonus for PCs to see the results of a complication.
Maybe it could be a switch per downtime activity? Kind of how you have private rolls.

So, just to be sure. If a private complication is desired, then the complication should only be messaged to the GM? Do you see any reason why this couldn't be implemented into the current private rolls button?

If a private complication is desired, then the complication should only be messaged to the GM?
Yes, my preference would be to have the results be visible to everyone (no private) but if a complication arises, have that whispered to GM only.

Do you see any reason why this couldn't be implemented into the current private rolls button?
I think the main thing I am suggesting is a separation of the results from the complications so that the complications could be whispered to the GM.

Okay, I understand that now. I think this is a good addition, so it'll be in the next release. It'll have a similar checkbox to "private Results".


Introduce directed graphs

[x] Introduce graph.Directed[N].Build().
[x] Introduce graph.Directed[N].AllowsSelfLoops().Build().
[x] If reusing graph.edgeSet to implement Graph.Edges, replace calls to Graph.AdjacentNodes with Graph.Successors.

Done and done.


Two-way binding

Hi,
I'm currently using this in a small project since its quite simple the way it works along with the plugins used in http://erikringsmuth.github.io/nex-js/#/examples e.g. requirejs etc... and I quite liked it  :).
However there's a missing feature (or I'm missing it) which I'd like to have which is Two-way binding, any suggestions how i can have two waybinding with this? or any suggestion which plugin goes well with it?
Basically what I need is this:
model -> bound to a input text -> which updates the model back -> render it again in a different form
Small example such as http://emberjs.com/ - AUTO-UPDATING HANDLEBARS TEMPLATES. However my scenario is much more complex e.g. not simply 1 textbox, the UI is quite dynamic and there quite a lot of textboxes etc...
Thanks!

In short, no it doesn't have two-way binding. This was a concept I was working on back when I was using Backbone.js as my main JS framework. I wasn't a fan of Angular's modules or DI and I wanted to do it better with RequireJS. In the end I started using Ractive and Polymer. Now Angular 2.0 and React are looking like good choices too. I probably won't be doing any further development of Nex.js since there are so many good libraries and frameworks showing up. You could always dig through the source and try adding your own form of two-way binding with object observers or something similar.

Great, thanks for you honest answer. Myself was also looking into the RactiveJS which is quite similar to your nex.js with two-way bindings.
I agree, Angular 2.0 along with emerging libs such as Aurelia are really great, however in this case I'm setting a skeleton project which is as simple/easy as possible for someone who doesn't have any knowledge on SPA and not familiar with frameworks such as Angular. Thanks again!


Update .NET Core telemetry article - license section

Update to license section only of the .NET Core telemetry article. Recommend against quoting license. The data section is subject to change -- and did change recently. :>)
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

#sign-off
Change to License section only.

@mairaw Ready for review


Security issue: Data representation leaks because validation takes places before authentication

Reported this on the mailing list and was asked to create an issue. I'm attaching some basic code to illustrate the problem.
My application
public class TestApplication extends Application<Configuration> {

    public static void main(String[] args) throws Exception {
        new TestApplication().run(args);
    }
    @Override
    public void initialize(Bootstrap<Configuration> configurationBootstrap) {

    }

    @Override
    public void run(Configuration configuration, Environment environment) throws Exception {
        environment.jersey().register(new BasicAuthProvider(new SecuredResourcesAuthenticator(),"SecuredEndpoints"));
        environment.getObjectMapper().disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);
        ValidatedResource resource = new ValidatedResource();
        environment.jersey().register(resource);
    }
}

My resource
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
@Path("/greet")
public class ValidatedResource {

    @POST
    @Timed
    @ExceptionMetered
    public Object createSolution(@Valid TransportObject validatedObject,@Auth Object userPlaceholder) throws JsonProcessingException {
        String response = "Hello";
        return response;
    }
}

The object with "secret" internal representation I only want authenticated people to know about
public class TransportObject {

    @NotNull
    @Size(min = 1)
    @Pattern(regexp="some_regexp_here")
    private String given_name;

    public String getGiven_name() {
        return given_name;
    }

    public void setGiven_name(String given_name) {
        this.given_name = given_name;
    }
}

The class that "handles" authentication by denying everybody
public class SecuredResourcesAuthenticator implements Authenticator<BasicCredentials,Object> {

    @Override
    public Optional<Object> authenticate(BasicCredentials credentials) throws AuthenticationException {
        //Deny everybody access
        return Optional.absent();
    }
}

I'm using dropwizard 0.7. A POST to http://localhost:8080/greet after the service has been started with an empty JSON body gives the following response:
{
errors: [1]
0:  "given_name may not be null (was null)"
-
}

After  getting that info I POST
{
    "given_name": ""
}

And get basically the full internal representation of this rather simple resource
{
errors: [2]
0:  "given_name must match "some_regexp_here" (was )"
1:  "given_name size must be between 1 and<PHONE_NUMBER> (was )"
-
}

Now that I figured out how it works, I can POST
{
    "given_name": "some_regexp_here"
}

And only then am I asked for credentials, which I don't have (valid one's that is) in the first place.

I've created pull request #891 which has a couple of tests which verify that this data leakage no longer occurs in Dropwizard 8.x (current master). Presumably this issue was also discovered by the Jersey folks and they addressed it, and we've been the beneficiaries of that. I'd just like a couple of pairs of eyes to go over the tests to make sure I haven't missed anything or if there are any other tests I should add, which I'm happy to do.

I'll take a stab at recapping what was found in https://github.com/dropwizard/dropwizard/pull/891
Jersey provides the parameters to a resource method in the order they are defined in the resource.
So if the @Auth param is first, the rest of the parameters will short circuit when the AuthFactory throws an exception because the user is invalid.
However, if the first parameter is @Valid SomeBean, that will go thru validation and return any validation errors before being authenticated because the @Auth param is defined after SomeBean
I can think of few options:
[1] Say this is a limitation and document very well. "If you do auth, it must be the first param"
[2] Do the security in a filter, which I think would happen before calling the resource method. I think this would mean some annotation on the resource method. Since the resource method may need the principal, we can have the filter call ContainerRequestContext#setProperty with the principal. We can then create a provider for a principal parameter which knows to look there. This means you would need the method annotation and the principal parameter annotation. TBH, I think this would work but would need to do a POC to be sure
https://jersey.java.net/documentation/latest/security.html

I personally like option 2 as I've been trying to use the @RolesAllowed annotations to handle authorization in my application which required me to implement my own SecurityContext and request filter to set request.setSecurityContext().  Then in the resources, you have to fetch the principal from the @Context SecurityContext sc.

@jplock I put some work into this. Let me know if it's the right the direction.
https://github.com/dropwizard/dropwizard/compare/master...carlo-rtr:auth_rewrite?expand=1

I want to think a little bit more about the class names and abstractions
I want to see if I can create a Provider to encapsulate reading the attribute and casting to a type. To make it easier to access a typed principal other than one that's a String.

d5410fbb22df73e7e086cde3538b014a0b2c6e5f

Nice to see that the issue is being fixed, although I won't be upgrading to a version of dropwizard that incorporates the fix anytime soon so I'll have to make due with the workaround. I couldn't help but notice the following line though: "Fixed security issue where info is leaked during validation of unauthenticated resources(#768)", surely that should say "authenticated resources"?

Depends on your point of view, I suppose. The principle attempting to
obtain the resource resource has not been authenticated when the data is
being leaked. The resource has been marked as requiring authentication, but
the leak occurs before the authentication stage occurs in the original
issue.
Perhaps a better wording would be "Fixed security issue where info is
leaked during validation of resource requiring authentication"?
On Tue, Apr 7, 2015 at 11:14 AM Martin Peters<EMAIL_ADDRESS>wrote:

Nice to see that the issue is being fixed, although I won't be upgrading
to a version of dropwizard that incorporates the fix anytime soon so I'll
have to make due with the workaround. I couldn't help but notice the
following line though: "Fixed security issue where info is leaked during
validation of unauthenticated resources(#768
https://github.com/dropwizard/dropwizard/issues/768)", surely that
should say "authenticated resources"?
—
Reply to this email directly or view it on GitHub
https://github.com/dropwizard/dropwizard/issues/768#issuecomment-90604086
.

It looks like this comes with some pretty significant user-facing API changes. Can someone sum the changes up (I keep losing a mental list as I scroll through commit d5410fb)? The API changes appear to be more feature development (role-based auth) than bug fixing. Maybe I missed the discussion around the API changes, but this seems like something the committers may want to have a quick discussion and vote on.
There's a little bit of context lost between Feb. 22nd and March 10th in this thread where the issue was reopened. But it looks like if we reordered the parameters internally (we could generate a proxy object) then Jersey could be made to do the right thing, which would fix this bug without introducing the API change.
The original authentication API was intentionally pretty simple. From quickly looking at the diffs in the commit, the changes to user applications appear to be significant.

The high level description is that auth now happens at the filter level, not at parameter injection. This means that information isn't leaked when parameters that fail to validate are listed before the auth parameter. Doing auth at the filter level, meant we could use provided authentication & authorization filters. So we did that, that's why it feels like a slight feature upgrade. The bulk of the implementation conversation happened starting May 10th in this issue, and in this PR https://github.com/dropwizard/dropwizard/pull/945

We have had some discussions on the mailing thread: https://groups.google.com/forum/#!topic/dropwizard-user/1xNzJe7GpV8
Given we have merged the provider, the changes to the API don't seem that dramatic. If other community members want a simpler approach to Auth, I think they can put something together and share it. I don't think we should keep the old auth under a separate module, and leave that security risk. I know we do that at the risk of upsetting some people, but I think that's going to be inevitable.


xDnsServerForwarder: Ignore UseRootHint in test function

Pull Request (PR) description
If the UseRootHint was not specified in the resource, the default will be $false. If we now have the DNS Server default configuration actually set to $true, the resource will never be in the desired state.
Proposed solution: Only test the root hints if they were specified.
Task list

[X] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[X] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #104 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #104      +/-   ##
==========================================
+ Coverage   81.35%   81.37%   +0.02%
==========================================
  Files          15       15
  Lines         874      875       +1
==========================================
+ Hits          711      712       +1
  Misses        163      163

Impacted Files
Coverage Δ

..._xDnsServerForwarder/MSFT_xDnsServerForwarder.psm1
93.54% <100%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436b727...8b20a79. Read the comment docs.

Thank you @claudiospizzi.

Thank you @indented-automation for the fast review and merge


Update http4s-client, http4s-dsl, ... to 0.21.15

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-server

from 0.21.6 to 0.21.15.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #83.

Superseded by #83.


Emit TestStepStarted event on @BeforeAll and @AfterAll hooks

Is your feature request related to a problem? Please describe.
It look like @BeforeAll and @AfterAll hooks do not fire any events, at least I don't see it in the code explicitly.
This makes impossible to report them in third-party report systems. At least in a straightforward way, without hacking that with AspectJ.
Describe the solution you'd like
Fire TestStepStarted event as you do for all other hooks.

@aslakhellesoy I don't think Cucumber currently has a message type suitable for before all/after all hooks.
Using TestStep{Started,Finished} would be inappropriate because there is no testCaseStartedId.

From the perspective of cucumber-ruby, as documented here: https://github.com/cucumber/cucumber-ruby/tree/main/features/docs/writing_support_code/hooks#beforeall-and-afterall, BeforeAll and AfterAll hooks are not part of the execution of the tests. There are suppose to setup and clean-up things that are not related to cucumber.
As @mpkorstanje said, I am not sure there would be an appropriate event for those.
We could maybe add new ones dedicated to such hooks?

I think we would need new message types in https://github.com/cucumber/common/tree/main/messages/jsonschema - maybe BeforeAllHookStarted and BeforeAllHookFinished.

That would mean adding four messages {Before,After{AllHook{Started,Finished}. For regular hooks we don't even make that distinction. There is a lack of consistency there that bothers me.

What kind of reporting do you want to be able to do @HardNorth?

@mattwynne I'm not really sure what you asking. I am a developer of Report Portal. It collects all test information (structure, hooks, logs, etc.) And analyse it with a taste of AI. I implemented numerous of test framework integrations for our project. Without these hooks reporting we won't be able to reflect them properly in our application, hence if such hook failed it won't be counted which cause statistics issues. And these hooks are also invisible for our analyser as for now

That would mean adding four messages {Before,After}AllHook{Started,Finished}. For regular hooks we don't even make that distinction. There is a lack of consistency there that bothers me.

Good point. Perhaps it would be better to simply have HookStarted and HookFinished. We could have a property indicating what kind of hook it is, e.g type = “BeforeAll” | “BeforeFeature” | “BeforeScenario” | “BeforeStep” | ….. If we go down this route we should also consider replacing the use of TestStepStarted and TestStepFinished for regular (scenario) hooks.

In my mind, the original {Before,After}{Scenario,Step} hooks are just special cases of TestSteps since if they fail they can fail a test case. However a BeforeAll hook isn't part of any specific test case, so it feels like a different beast.
I'm curious how you were thinking about reporting on it @HardNorth. Would a failure of a BeforeAll hook be counted as a failure of all the tests in the run? Or do you count these sorts of hooks as separate to the tests themselves?

The equivalent of a special test step for before hooks would be a special test case for before all hooks.
And a failure of a hook would be equivalent to failing the test run (same as with failure of a test case, worst result wins).

@mattwynne We don't report all tests as failed usually, just a single Item which failed. But for those who want to be extremely accurate I leave a public empty method, which can be overridden.
But without any event we won't even report a failed test run. That will be confusing for our users.

Good point. Perhaps it would be better to simply have HookStarted and HookFinished. We could have a property indicating what kind of hook it is, e.g type = “BeforeAll” | “BeforeFeature” | “BeforeScenario” | “BeforeStep” | …..

+1

If we go down this route we should also consider replacing the use of TestStepStarted and TestStepFinished for regular (scenario) hooks.

+1 keeping in mind to add a proper deprecation notice before totally replacing those

@aurelien-reeves I am not suggesting we deprecate TestStepStarted and TestStepFinished.
I am suggesting we use those messages only for Gherkin steps, and not for hooks.

@aurelien-reeves I am not suggesting we deprecate TestStepStarted and TestStepFinished.
I am suggesting we use those messages only for Gherkin steps, and not for hooks.

Yes, I understood 👌
Still, not using TestStep{Started|Finished} anymore with hooks remains a breaking change.

Yes it would be a breaking change, but there isn't anything to deprecate.


configmaps "extension-apiserver-authentication" is forbidden

kube-scheduler constantly logs the following:
E1019 11:57:21.407120       1 reflector.go:127] k8s.io/apiserver/pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:kube-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1019 11:57:57.428130       1 reflector.go:127] k8s.io/apiserver/pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:kube-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1019 11:58:31.721129       1 reflector.go:127] k8s.io/apiserver/pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:kube-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"
E1019 11:59:20.845730       1 reflector.go:127] k8s.io/apiserver/pkg/server/dynamiccertificates/configmap_cafile_content.go:206: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps "extension-apiserver-authentication" is forbidden: User "system:serviceaccount:kube-system:kube-scheduler" cannot list resource "configmaps" in API group "" in the namespace "kube-system"

I'm not sure if this is an indication for a real problem, but anyway we probably want to either fix the problem or eliminate the unnecessary logging.
Observed with lokoctl v0.4.1-207-gd814fcc0 on Packet.

Perhaps extension-apiserver-authentication-reader role should be assigned.

I wanted to report the same issue, it's producing quite some logs, and I wonder if this means something is broken?

@niels-s I'm not aware on any breakage caused by this. I think it might occur if you would combine it with scenario of multiple tiers of API servers, which is used in GCP IIRC, which obviously we don't use in Lokomotive.

I don't think this should happen now, we have added this via ccm in https://github.com/kinvolk/lokomotive/blob/2e7f69625331d5c23ca3c20d16f56fe3fb892fcb/assets/charts/control-plane/packet-ccm/templates/deployment.yaml#L159-L170

@knrt10 this binding is for the CCM, we need a separate binding for kube-scheduler (and possibly other workloads which use it).

Did we check if other components do not suffer for the same issue?

Let me confirm


action go_to problem

hi, i try another way to complete my project
try to make drone with the gps position with go_to
the goto stuck at this problem
usr/bin/python3.10 /home/naor/fhsbs/drone-camera-/mavSDK main.py
Waiting for drone to have a global position estimate...
-- Global position estimate OK
At GPS position: Latitude=47.397750699999996, Longitude=8.5456074, Altitude=488.25701904296875 meters
At cartzian position: x_i=0.0, y_i=0.0, z_i=0.0 meters
Enter the target altitude in meters: 2
-- Arming
At cartzian position: x_i=0.04447797058612646, y_i=-0.01111949242549315, z_i=2.037994384765625 meters
At cartzian position: x_i=0.04447797058612646, y_i=-0.01111949242549315, z_i=2.037994384765625 meters
Traceback (most recent call last):
  File "/home/naor/fhsbs/drone-camera-/mavSDK main.py", line 209, in <module>
    asyncio.run(main())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/naor/fhsbs/drone-camera-/mavSDK main.py", line 198, in main
    await x_axes(15,drone)
  File "/home/naor/fhsbs/drone-camera-/mavSDK main.py", line 158, in x_axes
    await drone.action.goto_location(lat_dist, long_dist, alt_dist, yaw)
  File "/home/naor/.local/lib/python3.10/site-packages/mavsdk/action.py", line 548, in goto_location
    raise ActionError(result, "goto_location()", latitude_deg, longitude_deg, absolute_altitude_m, yaw_deg)
mavsdk.action.ActionError: UNSUPPORTED: 'Unsupported'; origin: goto_location(); params: (47.39775089999999, 8.545742698240886,<PHONE_NUMBER>125, 90.57073974609375)

its simple go to..
the simulate drone get the command of the go to but the code is collaps
thanks for the help

What autopilot is that? PX4? Ardupilot? Which version of MAVSDK?


new \POGOProtos\Data\PlayerData did not read the full length

new \POGOProtos\Data\PlayerData did not read the full length
i think you will hate me. when finally it's fixed i update and get always new errors ahah

Update the dependencies :)


fix: try publishing again

:tada: This PR is included in version @kuka-js/serverless-v1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @kuka-js/core-v1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


split commands

Hai are you allright with split and join functions,
i would call them join-vertical and join-horizontal, and split- ...
i asked my Prof, there seems to be no standart on it but i think they will be usefull especially if you join a vektor to a matrix and then ask for determinant and more. You basically can quickly ask this way about properties of the solution of equation sytem. get row and column vectors via split misht also be interesting.
peace
herbert

allright i pospone these plan to when the access API stands

cat-horizontally

allright done, currently dont see use for split so put priority low

changed titel due join commands are implemented and tested and working


Max altitude parameter does weird things

I think the parameter LNDMC_ALT_MAX is implemented very poorly and can lead to very unexpected behavior from the users perspective:

mission altitudes are just cropped based on the max altitude reported by the land detector -> no user feedback at all. I would suggest to include it into the mission feasibility checker so that you cannot plan a mission with an invalid altitude.
https://github.com/PX4/Firmware/blob/master/src/modules/navigator/mission_block.cpp#L718

to make matters even worse the max altitude reported by the land detector is a function of the battery level of the vehicle -> the max altitude can change during a flight and can lead to very unexpected mission behavior, potentially just running into a tree.
https://github.com/PX4/Firmware/blob/master/src/modules/land_detector/MulticopterLandDetector.cpp#L242
I don't  quite understand why we need this logic. We have battery failsafe in place which, if activated, triggers a RTL or makes the vehicle land. Limiting the altitude based on the battery states is just weird. You could fly a 2 hour mission at low altitude, you are still going to run out of battery.

why does the land detector publish the maximum altitude in the first place?

Suggestions:

remove dependency on battery level and include check for max altitude in mission feasibility, but DON'T just crop altitude
remove from land detector. Should flighttask and navigator handle this entirely?

I don't want to comment on the current design, but I can provide the rationale behind it: If you fly up 200 meters and have a descend rate of 4 m/s (which is quite fast for a quad), then you need 50 seconds to descend. At a lower descend speed it is even worse and gets into the minutes, which for some systems is 5-10% of the total flight time.
If you go out of range horizontally the system goes into an emergency descend and nobody gets hurt, if you get it wrong on the altitude, then you turn the drone into a falling brick.
So this is all needed, but it probably could be done more elegantly and more transparently for the full system. I also think that it needs to factor in if its a VTOL that can (and is configured) to loiter down as fixed wing.


Update links to examples on the README

I noticed the example links pointed to example.ts and example.js, wich apperently do not work anymore.
I've updated them to be examples/main-typescript.ts and examples/main-javascript.js, respectively

Good catch! Thanks :)


doc: Add Azure CNI to CNI chaining section

This change is

test-docs-please

Coverage increased (+0.01%) to 44.082% when pulling dc69bdfb7b68adfc3d938d15e519b0e4b484367c on pr/tgraf/list-aks-chaining into 40a922e11ce2c0fc7382e1a8cd8ea82c84a83ca4 on master.

test-me-please


dev - allow to configure devtools location (#168454)

for #168454

Obsolete with https://github.com/electron/electron/pull/39734


feat: format json generated doc

Features:

Change the output string of the generated markdown (docs/REAMDE.md) using the default styles of vuepress
Fix lost nested object values at the parsing process

before

Current master request localhost:8080 snapshot. All nested object data are lost

after

In this pr localhost:8080 snapshot using the same hoppscotch-collection.json

@yubathom thanks for the PR, I just made a couple of tweaks. What're your thoughts?


Open partitioned parquet files

I'm trying out metabase with duckdb for processing viewing a large parquet file. I'm running Metabase from a Docker container following the instructions found on this repo readme.
I was able to query several single parquet files using
select * from 'path/to/parquet_single_data/*.parquet'

However, I can't seam to find out how to do the same for a parquet file that was created with partitions. My parquet file is partitioned into years like so:

parquet_data/ano=2013/part-0.parquet
parquet_data/ano=2014/part-0.parquet
parquet_data/ano=2015/part-0.parquet

This is what I tried:
select * from read_parquet('path/to/parquet_data/*.parquet')

and
select * from read_parquet('path/to/parquet_data/*/*.parquet')

None worked
Is it possible to open partitioned parquet files in duckdb?
Edit: Looking at the duckdb documentation, one should use parquet_scan for this. But I'm getting Cannot invoke "Object.getClass()" because "target" is null
https://duckdb.org/docs/archive/0.8.1/data/partitioning/hive_partitioning

As a complement, I check using the duckdb cli and the following query works.
select * from read_parquet('/app/dados/dados_parquet/sicor_operacao_basica.parquet/*/*')

Im using duckdb views to do this and also setting the datatype of each field instead of using star notation.
CREATE OR REPLACE VIEW {table_name} AS (
SELECT {fields} FROM read_parquet(['path/to/parquet_data/*/*.parquet'], HIVE_PARTITIONING=true)
)

With this you can add or remove data from the path and it will automatically update to metabase. Not sure how well the caching works when you do change the data.

I was having this issue when using a Duckdb database "in memory". But following what you did, I'm now creating a duckdb database on disk, inserting a bunch of views that use read_parquet and loading that file on Metabase. It's working just fine and I can use partitioned parquet files.

I misread you comment. After some testing I realized that if trying to open a partitioned parquet inside metabase, one must declare all fields contained in the files.
For instance, this works:
select REF_BACEN, NU_ORDEM from read_parquet('/dados/dados_parquet/sicor_operacao_basica.parquet/*/*')

but this does not
select * from read_parquet('/dados/dados_parquet/sicor_operacao_basica.parquet/*/*')

I'm reopening the issue because I think that select * from... should work regardless if we have a single parquet or a partitioned dataset.
In case it helps, I'm attaching the metabase log that I get when I execute the query.
metabase_partitioned_parquet_errorerr.log
Not sure it's related but I'm also seeing this warning when I re-scan the duckdb fields in metabase:
proagrodb_docker-metabase-1  | 2023-09-29 12:13:03,190 WARN query-processor.deprecated :: Atenção: driver :duckdb está usando Honey SQL 1. Este método foi descontinuado em 0.46.0 e será excluído em uma versão futura.

Sorry for the message in portuguese. But it's basically saying that the driver is using Honey SQL1, which was discontinued in version 0.46.0 and will be excluded in the future.

but this does not
select * from read_parquet('/dados/dados_parquet/sicor_operacao_basica.parquet/*/*')

Hi! Did you try this thing direct in duckdb? Is it working?

but this does not
select * from read_parquet('/dados/dados_parquet/sicor_operacao_basica.parquet/*/*')

Hi! Did you try this thing direct in duckdb? Is it working?

Yes, it works using duckdb CLI. I pasted the output a couple of comments above
https://github.com/AlexR2D2/metabase_duckdb_driver/issues/16#issuecomment-1730194178

Sorry for the long delay in answering. I'm installing metabase and duckdb driver using the following dockerfile. Will that give me the latest version of the metabase plugin?
FROM openjdk:19-buster

ENV MB_PLUGINS_DIR=/home/plugins/

ADD https://downloads.metabase.com/v0.47.5/metabase.jar /home
ADD https://github.com/AlexR2D2/metabase_duckdb_driver/releases/download/0.2.3/duckdb.metabase-driver.jar /home/plugins/

RUN chmod 744 /home/plugins/duckdb.metabase-driver.jar

CMD ["java", "-jar", "/home/metabase.jar"]

I just tested using a metabase installed as shown above and a partitioned parquet dataset. All worked fine!
The following syntaxes worked:
select * from read_parquet('/data/iris_part/**/*.parquet')
select * from read_parquet('/data/iris_part/**/*')

select * from read_parquet('/data/iris_part/*/*.parquet')
select * from read_parquet('/data/iris_part/*/*')

select * from read_parquet('/data/iris_part/**')


publish docs

Read the docs allows for free building and hosting of documentation sites and offers close knit support for sphinx. Github pages could also be a nice alternative.

A good point, @SauravMaheshkar .  We already have our docs on Read the Docs:
https://robota-core.readthedocs.io/en/latest/index.html
But I don't think we link to it from the GitHub repository effectively, and we don't yet publish directly from GitHub.  It would be fantastic if you were willing to put together a PR that automatically built and published updated docs to Read the Docs for each release we make here.

Sounds good. Will make a PR soon. Till then perhaps a easy way to link to the documentation from the repository is to add it as a website in the repository settings.

How it looks
How to configure

Good suggestion, thanks.  I've done that now.


Update Needed for Python3.11

It seems that tkfontawesome fails to install in PyCharm when using Python3.11. tkfontawesome requires lxml4.7 which is only available for Python3.10 and earlier. Do you plan on updating tkfontawesome for Python3.11 using lxml4.9?

+1

It seems that tkfontawesome fails to install in PyCharm when using Python3.11. tkfontawesome requires lxml4.7 which is only available for Python3.10 and earlier. Do you plan on updating tkfontawesome for Python3.11 using lxml4.9?

Meanwhile i used https://pypi.org/project/fontawesome/


block height reported by wallet transactions CLI command incorrect

A user reported that the block height for certain transactions as returned by the <> wallet transactions std CLI command are incorrect, and in fact about twice the size of the current height of the reported chain height.

Is there any more info available? There is mention of "certain" transactions - is there an example of such a transactions perhaps?

Currently unable to reproduce

It seems the only place the height is set on the transactions is in the ProcessConsensusChange function in the wallet. This function uses a variable in the wallet to keep track of the current height, which would suggest it is possible for this variable to get out of sync


Add headerWarning to dydx

Resolves L2B-7563

@radinat Do we want to show the header warning in the table? The warning can be markdown and the tooltips are not hoverable.

038-a84f-3a3ba066eac3)


[Scenario] ALittleNightMusic - Spanish Translation added

Hi,
I've updated my MoM scenario ALittleNightMusic to add a Spanish translation by Vidi M.
The updated files have been committed here:
https://github.com/jlederer2/Valkyrie/tree/master/ALittleNightMusic
However, for some reason, I'm not seeing the "download" icon in MoM to download the new version of the scenario.
Does the Valkyrie manifest.ini file need to be manually updated at your end?
Thanks,
Jim

Hmm, the manifest.ini is now showing Spanish info...so something must be working again :-)


update: architecture.md

Review the architecture.md document

@ashucoder9 can you pull main and rebase?

Merged main into the fork. Should be working fine now.


Arrays over 999,999 samples in length throwing errors

_main.pd in "subpatch/_main.pd" @ (x:0, y:22): invalid literal for int() with base 10: '1e+06'

@ylevtov This issue has now been fixed and pushed to the dev channel.
In the future, I strongly recommend that you avoid using Pd arrays in favor of tables unless you specifically want to store data in the patch. In other words, when we find array we have to store all of your values in the patch. With table we only have to store the number of values. The latter is a lot easier on us.
Thanks for your help!

Great - thanks! Yes, my use of arrays was left over from when I was storing sample data in the patch. Now that we’re no longer doing that I can go back to using tables.

On 20 Jul 2016, at 10:03, Martin Roth<EMAIL_ADDRESS>wrote:
Closed #107 https://github.com/enzienaudio/heavy/issues/107.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/enzienaudio/heavy/issues/107#event-728693629, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR_dGg9nXQO8sJZEnceSytsc5NFJYGjks5qXeRzgaJpZM4JQGQw.

I did also update the table parser, so you're more than welcome to create tables with sizes larger than 1e6 now as well ;)
...@ylevtov, always pushing those boundaries...


Can Colorizer act on the Terminal window?

Can Colorizer act on the Terminal window?
(My build task sends its output to Terminal and the output is presently uncolored despite having Colorizer installed).

Currently it only works on the Output panel.  Will have to do more research to see if its possible to apply colorization rules to the terminal.

Any updates on this? I am also interested!


AdoptOpenJDK has gone EOS

As per https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/, OpenJDK is no more or will be shortly.  A different way of saying this is that AdoptOpenJDK has gone End of Service.
https://adoptium.net/ is the new location to get these binaries.
The source code location of this is https://github.com/hyperledger/fabric-chaincode-java/blob/main/fabric-chaincode-docker/Dockerfile#L57.
It's worth putting into this issue that the Fabric Java SDK will need to compile/run in the updated environment, which will potentially have an impact on the amount of time it takes to finish this task.  That is, Fabric SDK code may need to be updated before or with this change and I'm not sure how much code change is needed.

JVM updated for the 2.5 release
https://github.com/hyperledger/fabric-chaincode-java/commit/37bebee7fced815336960504cb880083a7d40a52

Is this going to be backported to v2.2 given that it's still your Long Term Service (LTS) release?


can not send Messages

Somehow this code does not send a Message. Do I need a "Channel" at the beginning of the channelID like the BotToken needs "Bot " at the beginning?
package main

import (
	"github.com/bwmarrin/discordgo"
)

func main() {
	discord, _ := discordgo.New("Bot MyBotToken")
	_, err := discord.ChannelMessageSend("MyChannelID","message")
	if err!=nil {
		panic(err)
	}
}

I get the error:
panic: HTTP 400 Bad Request, {"message": "Unauthorized", "code": 40001}

goroutine 1 [running]:
main.main()
        /media/nas/dev/go/discord test/main.go:11 +0xe8

Process finished with exit code 2

You forgot to open a connection right before sending the message. Adding client.Open() before ChannelMessageSend should fix the issue.


Setting active account doesn't seem to work

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework

[x] Angular
[ ] React
[ ] Other

Description
From the Angular B2C example
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/df55fda194a733a861c5ad08f12e5b2a3ff2108f/samples/msal-angular-v2-samples/angular11-b2c-sample/src/app/home/home.component.ts#L24-L26
I am using the redirect way of authentication (instead of pop up), the above line should set the account after authentication. But instead, this doesn't happen.
I confirmed it with - console.log(this.authService.instance.getActiveAccount()); - this shows null. But console.log(this.authService.instance.getAllAccounts()); - does print all the accounts.
Error Message
No error messages
MSAL Configuration
export const b2cPolicies = {
  names: {
    signUpSignIn: 'B2C_1_SignUpSignInFlow',
    forgotPassword: 'B2C_1_PasswordReset',
    editProfile: 'B2C_1_ProfileEditing'
  },
  authorities: {
    signUpSignIn: {
      authority: 'https://gollahalliauth.b2clogin.com/gollahalliauth.onmicrosoft.com/B2C_1_SignUpSignInFlow',
    },
    forgotPassword: {
      authority: 'https://gollahalliauth.b2clogin.com/gollahalliauth.onmicrosoft.com/B2C_1_PasswordReset',
    },
    editProfile: {
      authority: 'https://gollahalliauth.b2clogin.com/gollahalliauth.onmicrosoft.com/B2C_1_ProfileEditing'
    }
  },
  authorityDomain: 'gollahalliauth.b2clogin.com'
};

Reproduction steps
// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

Expected behavior
Identity Provider

[ ] Azure AD
[x] Azure B2C Basic Policy
[ ] Azure B2C Custom Policy
[ ] ADFS
[ ] Other

Browsers/Environment

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Regression

[ ] Did this behavior work before?
Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[ ] Customer request

@akshaybabloo Unfortunately, the current implementation of active account means that it does not persist, but must be set per page load. This is an enhancement we are looking to make. Today, please set the active account on each page load, after checking that interaction is complete. Please see our FAQ and sample for more details.


Use theme resolved colors where possible

This shouldn't have any noticable effect as every direct
color resolve is just replaced with theme provided ones.
As a part of #958, dynamic colors part.

In all places, the colorSecondary should remain unchanged - this value is not meant to change with the theme and should always be a dark gray. colorPrimary and colorAccent can change for the most part

I noticed there are several areas where I don't want to change the color based on the theme right now, can this PR be refocused to just changing the color in the following cases?

Buttons
Charts

I can evaluate the other elements using colorPrimary/colorAccent to see if they are candidates or switch them to another color in the theme that doesn't shadow the attr name.
With no change to colorSecondary

I noticed there are several areas where I don't want to change the color based on the theme right now, can this PR be refocused to just changing the color in the following cases?

I'm not that familiar with the app to understand the terminology, sorry :/

With no change to colorSecondary

Done

I noticed there are several areas where I don't want to change the color based on the theme right now, can this PR be refocused to just changing the color in the following cases?

I'm not that familiar with the app to understand the terminology, sorry :/

No worries, so basically only keep the changes to the following files (listed in the order they show on the Files Changed tab): AltitudeBottomSheet, CustomUiUtils, TileButton, PathElevationChart, BatteryChart, FragmentToolMetalDetector, FragmentToolSolarPanel, ToolsFragment, HumidityChart, PressureChart, TemperatureChart, activity_onboarding.xml, and styles.xml
That should include all buttons / charts, but none of the labels/drawables. I will evaluate those individually to see if they can use a dynamic color.

With no change to colorSecondary

Done
Thanks!

That should include all buttons / charts, but none of the labels/drawables. I will evaluate those individually to see if they can use a dynamic color.

Done

Thanks, I'll do some testing and then merge this in


chore: add gitignore and ignore .DS_Store

** DO NOT OPEN NEW PULL REQUESTS AGAINST THIS REPOSITORY **
This repository has not been marked archived/read-only, as we do periodically update the list of packages and/or their constraints. However, this repository is a metapackage, and is only used to release the product.
Only open a pull request that will update existing package constraints; all other requests will be closed.

Thanks. 👍


introduce CertificateAuthority and CertificateStore

This PR introduces two interfaces and a single respective implementation.

CertificateAuthority
CertificateStore

Certificates will for now be created for all of the referenced nodes for a topology. This is meant to change once the KindProperties (#1207) are available. Then it will be again restricted to SRL nodes.
As a next step also the introduction of a seperate config knob is planned to enable cert creation for individual nodes.

Introducign the config knob will solve this issue #1211

This PR will allow an easy implementation of #746 since we have proper interfaces, which the new implementation simply needs to satisfy.

We should maybe consider pushing the certificate mangement and creation down to the node instead of trying to manage this centrally. This would provide the nodes with the ability to e.g. delay cert creation, to then request the cert also with the mgmt IP as a SAN value #150

looking good


Type issues for SideSheetProps.position in tsx files.

Describe the bug
Greetings.
When using the SideSheet component in a NextJS project, the TS (.tsx) compiler throws an error stating Type 'string' is not assignable to type 'Pick<PositionTypes, "bottom" | "left" | "right" | "top">'. Although the SideSheet is being rendered as expected during on the development server, the error causes the build process to fail.
Just wanted to clarify if this a bug or am I getting something wrong?
To Reproduce
<SideSheet
  position={Position.LEFT} // ← Error is thrown at this line
  isShown={isMenuOpen}
  onCloseComplete={() => toggleMenuOpenState(false)}
  preventBodyScrolling
>
...
</SideSheet>

CodeSandBox Example: https://codesandbox.io/s/4nurm?file=/src/SideSheet.tsx
Expected behavior
The SideSheet is being rendered as expected but this error causes the build process to fail.
Evergreen Version
v5.1.1
Screenshots

Environment:

OS: Windows 10 / 1909 / 64-Bit
Browser: Mozilla Firefox
Version: 81.0

Dupe of https://github.com/segmentio/evergreen/pull/1048 -- going to merge that into master and cut a release. Thanks for reporting!


Dev: Web - Composer is focused when reloading after workspace is opened from RHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the website
Settings > Workspaces
Reload the website
Observe the composer

Expected Result:
Composer shouldn't be focused
Actual Result:
Composer is focused
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: Dev <IP_ADDRESS>
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/0c86e9ac-eb2c-42f5-b08e-3b8a90e5893e
Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693280983559619
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Composer is focused when reloading after workspace is opened from RHN
What is the root cause of that problem?
Te root cause is that in this line modal object sometimes is empty and makes shouldAutoFocus = true for short time
What changes do you think we should make in order to solve the problem?
we should add modal.hasOwnProperty('isVisible')to the shouldAutoFocus condition in order to verify thart the object is comming correctly.
Solution Working
https://github.com/Expensify/App/assets/16781411/4b504e23-9a8d-410b-9472-bdc83984fac2
What alternative solutions did you explore? (Optional)
N/A

@MonilBhavsar - are you able to reproduce this for me given it's on DEV? 🙏

@sophiepintoraetz - i was able to reproduce when i send the proposal but now i'm not able to reproduce it in DEV.

I'm not able to reproduce too. Looks like it is fixed now and we can close this
https://github.com/Expensify/App/assets/32012005/0de1e7a6-284e-405d-8cf4-4b89b2600d00


Make Routesv2 the default

Description:

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Closing this PR as there's another one #2605


Move from bors to GitHub Merge Queue

This PR removes bors, as it is being deprecated, and applies a small fix in preparation of using the GitHub Merge Queue.
Closes #1667.

Thank you!


Use ISO 8061 basic format

The current directory name set by prepare_output_dir contains a datetime string of ISO 8061 extended format e.g. 2017-04-24T02:14:52.180466.
It is easy to read, but its colons : are cumbersome, so this PR will get rid of them by switching to the ISO 8061 basic format e.g. 20170424T021452.180466

Coverage increased (+0.003%) to 57.81% when pulling a4b7c821b5bd7ffa9176903f18de141035e9012d on muupan:iso-8061-basic into 38002b3d23817be70709c1f66dcb0a320c29bc3f on pfnet:master.


ci,lib up

Codecov Report

Merging #92 (3d3e482) into master (d56d362) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           62        62
=========================================
  Hits            62        62

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Nuxt Build Error: "useId" is not exported by vue.runtime.esm-bundler.js in Nuxt 3.14.1592 and Nitro

Environment

Nuxt Version: 3.14.1592
Nitro Version: 2.10.4
Node.js Version: v20.11.0
Vite: v5.4.11
Build Command Used: nuxt build

Reproduction
The error occures only on build (yarn build) and not on yarn dev.
It occured since updating to the latest Nuxt Version.
Describe the bug
When running yarn build I get the following Error output.
See the Logs below.
Additional context
For me it seems to be similar to the issue people had with rollup on bun, bit im not 100% sure.
E.g. https://github.com/nuxt/nuxt/issues/29920
Logs
storefront on  main [$✘!?] via  desktop-linux via  v20.11.0
❯ yarn build
Nuxt 3.14.1592 with Nitro 2.10.4                                                                                10:23:31 AM
ℹ Using 2024-04-03 as fallback compatibility date.                                                                                10:23:33 AM
ℹ Using default Tailwind CSS file                                                                                nuxt:tailwindcss 10:23:33 AM
ℹ Building client...                                                                                10:23:37 AM
ℹ vite v5.4.11 building for production...                                                                                10:23:37 AM
ℹ ✓ 1912 modules transformed.                                                                                10:23:49 AM

 ERROR  x Build failed in 11.42s                                                                                10:23:49 AM

 ERROR  Nuxt Build Error: node_modules/nuxt/dist/app/composables/id.js (1:9): "useId" is not exported by "node_modules/vue/dist/vue.runtime.esm-bundler.js", imported by "node_modules/nuxt/dist/app/composables/id.js".                                                                                10:23:49 AM
file: /Users/*************/code/storefront/node_modules/nuxt/dist/app/composables/id.js:1:9

1: import { useId as _useId } from "vue";
            ^
2: export const useId = _useId;

  file: node_modules/nuxt/dist/app/composables/id.js:1:9

  1: import { useId as _useId } from "vue";
  ^
  2: export const useId = _useId;

  at getRollupError (node_modules/nuxt/node_modules/rollup/dist/es/shared/parseAst.js:396:41)
  at error (node_modules/nuxt/node_modules/rollup/dist/es/shared/parseAst.js:392:42)
  at Module.error (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:15593:16)
  at Module.traceVariable (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:16042:29)
  at ModuleScope.findVariable (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:13825:39)
  at Identifier.bind (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:5071:40)
  at VariableDeclarator.bind (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:2658:23)
  at VariableDeclaration.bind (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:2654:28)
  at ExportNamedDeclaration.bind (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:11739:27)
  at Program.bind (node_modules/nuxt/node_modules/rollup/dist/es/shared/node-entry.js:2654:28)

It sounds like you have vue 3.4 installed rather than vue 3.5, which is the version Nuxt now relies on.
Would you investigate in your lockfile, and if necessary add an explicit dependency on the latest version of vue?


Bugfix: Enable only integer values for range slider

Hello everyone,
First, congratulations on your project! I really like the idea of combining Matplotlib (or image plots in general) with a Dash Dashboard.
While reviewing your code, I noticed that it allows for the selection of non-integer values for the year. This doesn't make much sense since the WHO air quality dataset has a temporal resolution of one year. Therefore, I propose adding the step parameter to the dcc.RangeSlider to restrict the selection to integer values only:
  dcc.RangeSlider(
      id="from-to",
      min=2013,
      max=2022,
      step=1,
      value=[2015, 2020],
      marks={i: str(i) for i in range(2013, 2023, 1)},
  ),

Additionally, during the setup of the environment, I encountered an error indicating that the regex module is not installed. I suggest adding regex to the install_requirements.txt file. This was unexpected for me as well, since I assumed regex to be a base module. However, it was not included in my Python 3.11 installation from the Mamba Forge channel.
Best regards,
Alex Landolt

Hey, Thank you for your feedback and also directly providing a fix for your issue! I agree about your point with the time resolution of the data. We also added regex to the install_requirments.


Examples?

Can you provide an example app? Its no really clear how to use your tool. Suppose TodoApp would be nice.

right now I'm about to release devtools extension for monitoring and debug.
As case of TodoApp, I can't see any application for Slots to show how user can benefit from its use for such a simple ("logicless") app. We can do it, but just for fun or for comparison of count of code lines.
I believe that we'll see more during this week. Btw documentation is already out of date ((. Work in progress ).

Mb I understood something wrong? Slots is an equal for Relay? If so you can provide an example of TodoApp with server as data provider to explain how to work with your tool in simple example. As for now I do not understand your documentation at all, sorry :)

In general it could be considered as a "app-state-management" framework. It's independent on any data source and update method. It's independent on environment (it works equally on the client and on the server). The concept is really dead simple. You need just understand  how "set" is working. All other things (the support of promises, contexts, transactions, commits) are just "additions". Tests are also could be useful to understand how it works.


PR: test spyder_kernels PR 180

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Reopening this to see if our tests pass here before merging that PR in spyder-kernels.


Terminal: suspend when not visible

Consider a long running job that is executing in the terminal with lots of output produced periodically. When the integrated terminal is not visible in VS Code I would assume that it becomes a no-op for the renderer at least.
It looks like the integrated terminal is not suspending work when hidden and the upstream issue is: https://github.com/xtermjs/xterm.js/issues/880

Put a PR out to do this using [IntersectionObserver][(https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API) https://github.com/xtermjs/xterm.js/pull/1144

Cool!


Specific safety concerns and related information

Create a new page that discusses specific safety concerns around metalwork. The issues covered should include things of which newbies may not be aware, such as metal fume fever, the dangers associated with burning zinc (and brass) and galvanized steel objects.

This page should include a link to the Jim "Paw-Paw" Wilson case


SPIKE: TODO Use "/v2/" route in Template class once available

User Story - Business Goal
The code is littered with TODO comments that are not linked to tickets and not well understood. This TODO concerns using the /v2/templates route in the Template class of notification-api/app/models.py "when available". The /v2/templates route has been available for some time.
The goal of this ticket is to determine if we should deprecate the existing templates route, {{notification-api-url}}/service/{{service-id}}/template for the new template route {{notification-api-url}}/v2/templates

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a    VANotify
I want   to clean up TODO comments
So that    the code is more readily maintained
As a    VANotify
I want   to determine the utility of the v2 template route
So that  we can provide a better service to our clients
Additional Info and Resources

TODO: Use "/v2/" route in Template class once available.
  def get_link(self):
      # TODO: use "/v2/" route once available
      return url_for(
          "template.get_template_by_id_and_service_id",
          service_id=self.service_id,
          template_id=self.id,
          _external=True
      )

Acceptance Criteria & Checklist

[ ] Technical Documentation has been created and linked in the glossary
[ ] Learnings have been shared with the team, and decisions have been documented
[ ] Tickets for next steps have been identified and created

[ ] Any new tickets created should handle the TODO comment, either by adding in a ticket number to that comment or by removing the TODO comment (depends on the work)

Completed research addresses the problems and/or answers the questions below:

It is unclear why a v2 route even exists for templates: what was it trying to solve?
Should we sunset the existing template route (noting that Strike directly accesses the DB for template crud, without using our endpoints) and perform the work asked in the TODO?
Should we sunset the v2 route and just remove the TODO in the code?

Hey team! Please add your planning poker estimate with Zenhub @EvanParish @k-macmillan @kalbfled @trevor2718 @jakehova @cris-oddball @ianperera

Please add your planning poker estimate with Zenhub @justaskdavidb2

@cris-oddball I left this guy in backlog because it had more content in it than usual. Not sure if that will make it easier to get to a review ready state.

Hey team! Please add your planning poker estimate with Zenhub @cris-oddball @EvanParish @kalbfled @ldraney @nikolai-efimov

Closing.