Bluetooth: Controller: Wrong channel index in connectionless AoA

Describe the bug
I am working on direction_finding_connectionless_rx/tx samples using Nordic nrf52833 and nrf5340. I noticed that with PER_ADV_EVENT_CTE_COUNT set to 5 on the tx side, CTE reports from the rx side are like
PER_ADV_SYNC[0]: [DEVICE]: EF:BB:1A:FA:87:19 (random) synced, Interval 0x03c0 (1200 ms), PHY LE 2M
success. Periodic sync established.
Enable receiving of CTE...
success. CTE receive enabled.
Scan disable...Success.
Waiting for periodic sync lost...
CTE[0]: samples count 45, channel ID 24, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -690
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -760
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -760
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -760
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC not OK, CTE Info OK, RSSI -760
CTE[0]: samples count 45, channel ID 36, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -410
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -380
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -380
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -380
CTE[0]: samples count 45, channel ID 0, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -380
PER_ADV_SYNC[0]: [DEVICE]: EF:BB:1A:FA:87:19 (random) sync terminated
Periodic sync lost.

They are basically a random selected channel N followed by four 0 for each CTE train. As far as I know, channel number within a single train should be the same in Zephyr. Please correct me if not.
I also tested it with a ST processor as the TX (not running on Zephyr), with RX remained unchanged, and PER_ADV_EVENT_CTE_COUNT was set to 4. As you can see from the log message below, channel index were 4 different numbers for the ST part (ST has a different channel selecting strategy). That means the direction_finding_connectionless_rx sample was working as expected and it was direction_finding_connectionless_tx that might have some issue.
Waiting for periodic sync lost...
CTE[0]: samples count 45, channel ID 31, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -480
CTE[0]: samples count 45, channel ID 7, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -470
CTE[0]: samples count 45, channel ID 32, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -480
CTE[0]: samples count 45, channel ID 18, cte type AOA, slot durations: 2 [us], packet status CRC OK, RSSI -480
PER_ADV_SYNC[0]: [DEVICE]: A0:AC:7E:00:00:00 (public) sync terminated

To Reproduce
Zephyr version: 3.7.99
SDK: zephyr-sdk-0.16.8
TX board: nrf52833 devkit
RX board: nrf5340 devkit
For TX side: build direction_finding_connectionless_tx and flash
west build -p always -b nrf52833dk/nrf52833 samples/bluetooth/direction_finding_connectionless_tx -DEXTRA_CONF_FILE=overlay-aoa.conf
west flash

For RX side:

add channel ID print to cte_recv_cb in direction_finding_connectionless_rx

static void cte_recv_cb(struct bt_le_per_adv_sync *sync,
			struct bt_df_per_adv_sync_iq_samples_report const *report)
{
	printk("CTE[%u]: samples count %d, channel ID %u, cte type %s, slot durations: %u [us], "
	       "packet status %s, RSSI %i\n",
	       bt_le_per_adv_sync_get_index(sync), report->sample_count, report->chan_idx,
	       cte_type2str(report->cte_type), report->slot_durations,
	       packet_status2str(report->packet_status), report->rssi);
}

build and flash

Impact
AoA calculation uses channel index for wavelength calculation. There would be bias if incorrect.
Additional context
The bug was first found on nRF Connect SDK, then I switched to Zephyr Project and was able to reproduce the problem. There are some details I posted in Nordic Forum https://devzone.nordicsemi.com/f/nordic-q-a/114492/direction-finding-chan_idx-of-cte-sent-in-single-periodic-advertising-train, which I didn't get an answer from Nordic but could be some useful FYI.

Looks like there is a 3-years-old FIXME here https://github.com/zephyrproject-rtos/zephyr/pull/38989/commits/28cadd13356e2228ce8f61e1078dd501584d26dc

@cvinayak Is this a Controller bug?

Looks like there is a 3-years-old FIXME here 28cadd1

Thanks for digging out, seems like we overlooked here.

Thanks, I appreciate you putting this task onto the schedule!

Thanks, I appreciate you putting this task onto the schedule!

Please use this fix PR branch and perform your tests, your new results with the plot as in devzone will be valuable validation of the fix. Thank you in advance.
Fix: https://github.com/zephyrproject-rtos/zephyr/pull/79818

Please use this fix PR branch and perform your tests, your new results with the plot as in devzone will be valuable validation of the fix.

@cvinayak Thanks for the quick fix! Channel indexes within a periodic train are different numbers now. And I test similar physical setup as in devzone, here are some plots after applying the commit:

The separation issue for big channel index numbers I mentioned in post has gone, which is good, but still larger offset can be observed when channel idx goes up.

Thank you for testing and confirming that now periodic train have different channel indices in the reports. I am not familar with your plots as to the X and Y axis. I will need to let folks at the devzone provide their comments.


Git: Ignore .js/.js.map Files in public folder

Is it really necessary that we have the js files in public folder under version control? It increases the diff of PR and I think we don't need them since we create them with npm? Or did I understand anything wrong?

If we don't have those file the the project won't work with git clone unless we do npm install and after compile.
I understand the struggle, but it's pretty easy to overcome this. Before pulling the new version of the project just do a git checkout public/

Can this be closed?

for the moment yes, maybe we find a better solution in future

I'm afraid that this is a caveat that we must live with.
This is the source repo for laravel-enso.com. The demo would never work if the files would not be compiled.
Sorry.

I unterstand you - is there a „best practice“ how other projects do this? I can’t believe that the combiled js files are in repo there? But I can’t be wrong...

Laravel Enso is packed as a boilerplate ready to go.
The optimal flow (what we use in our business projects, and the way we built it) would be:
1 Repo cloning, follow setup steps
2 Play
3 If you find Enso suited for building a project with it, delete the .git folder an run git init, and have a dedicated repo for the custom project.
4. Develop.
5. Whenever you need updates, just run composer update / npm update compile.

Need another new project ? Step 1.

We structured everything in packages, so there's almost never any need to update something in the root of the project, or in the cases when there is, it's trivial.
First thing that you will replace, for sure, is the dashboard. This mean that you already break the base. The dashboard structure is only an example, is there for you to modify it.
If you look with attention, basically what we update in the laravel-enso/enso repo on every version is composer.json, package.json, republish resources on every update (this would happen to you private repo too after composer update), compile / change the public folder and so on.
Only recently we added the new examples structure, but soon we will have a command like php artisan enso:clear-examples to leave everything clean for any new project.
Hope that helps.

ok, thanks for the explanation - everything is clear.
My point war that the combiled js files have a lot of changes after each js change therefore you get a lot of lines in PR.
But thats a minor problem.


HW10: Task 01: Phrasing of Function Unclear (Moderate)

In Homework 10, Task 01, we are instructed to write a function that will compute "Imm Thai's percentage of votes after simulating one bootstrap sample of tbl." Is it saying that tbl is already a resample of the votes table? Or is it saying that we need to resample the votes table and then do the percentage calculation? I only bring this up because in Task 04, given how the skeleton of the function is setup, it suggests that tbl in Task 01 is resample of votes, but I just want to be sure.

Good question/point. tbl is the sample data. This means you need to create a bootstrap resample from the sample data in tbl. I suppose, in theory, tbl is a possible resample. It is unlikely that a resample will be exactly the same as the original sample though.
In Task 04, the phrase "from one bootstrap sample of tbl" is suggesting that tbl is the original sample and you need to work with a resample from that data.
I'll add a clarifying note to Task 01.

I only just got around to reading the clarification. I only just got around to reading your clarification and I think I did Task 01 incorrectly. Just to be clear (and I apologize if I am being pedantic, but by "[t]his means you need to create a bootstrap resample from the sample data in tbl," do you mean that when we write the function one_resampled_percentage, inside that function we have to do a resample of tbl and then return the percentage that results from that?
If so, then in Task 04, the presence of the bootstrap variable throws me off because if bootstrap is already a resample of the original sample in tbl, then passing that resample into the earlier function from Task 01, one_resample_percentage, based on how I am now understanding that function to work, we would be resampling from an already resample table, which while it still accomplishes the goal (and is random), seems odd.
My Task 01, one_resample_percentage function does not resample tbl but just computes the percentage. It expects the input table to be resampled already.

A bootstrap variable would be in both functions.

Then that still raises the question of why a bootstrap would need to be in both functions as it really only needs to be in the percentages function since the differences function would call the percentages function which already does a resampling of the original table inside of it. I think that is what was still puzzling me.

Good point. Looking at their template/instructions:

Task 01: This function creates a bootstrap resample, calculates the percentage, and returns the percentage. This gives a simulated test statistic value based on a resample.
Task 04: This function creates a bootstrap resample, calculates the percentage, and returns the difference.

After looking at this setup further based on your raised issue. I agree that it is unnecessary to get the resample in the Task 04 function. Simply calling the function from Task 01 in the function for Task 04 would get the resample and calculate the percentage. From there you can just use the provided formula. For example:
def one_resampled_difference(tbl):
    imm_percentage = one_resampled_percentage(tbl)
    return  imm_percentage - (100 - imm_percentage)

I'll make a note that we should consider updating the template/phrasing of this for future semesters if this assignment will continue to be used.


sbt-mocha fails with "no test suite" when there are nested describes in sbt 1.x

In many of my tests, I have nested describe blocks to help organize things, like this:
describe("outer", function() {
    describe("inner", function() {
        it("should do a thing", function() {
            expect(1).to.equal(1);
        });
    });
});

When running sbt-mocha 1.1.2 in an sbt 0.13.17 project, this works perfectly fine. However, when I upgraded the project to sbt 1.2.6, it started failing. Specifically, it would run the tests until it hit a file with a nested describe, then it would run the tests in that file, then it would fail with the following exception:
[error] java.lang.RuntimeException: no test suite
[error] 	at scala.sys.package$.error(package.scala:26)
[error] 	at sbt.JUnitXmlTestsListener.$anonfun$withTestSuite$1(JUnitXmlTestsListener.scala:153)
[error] 	at scala.Option.getOrElse(Option.scala:121)
[error] 	at sbt.JUnitXmlTestsListener.withTestSuite(JUnitXmlTestsListener.scala:153)
[error] 	at sbt.JUnitXmlTestsListener.writeSuite(JUnitXmlTestsListener.scala:230)
[error] 	at sbt.JUnitXmlTestsListener.endGroup(JUnitXmlTestsListener.scala:215)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.$anonfun$handleSuite$25(MochaTestReporting.scala:222)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.$anonfun$handleSuite$25$adapted(MochaTestReporting.scala:221)
[error] 	at scala.collection.immutable.List.foreach(List.scala:388)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.$anonfun$handleSuite$24(MochaTestReporting.scala:221)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.$anonfun$handleSuite$24$adapted(MochaTestReporting.scala:220)
[error] 	at scala.Option.foreach(Option.scala:257)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.handleSuite(MochaTestReporting.scala:220)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.$anonfun$logTestResults$3(MochaTestReporting.scala:81)
[error] 	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:233)
[error] 	at scala.collection.immutable.List.foreach(List.scala:388)
[error] 	at scala.collection.TraversableLike.map(TraversableLike.scala:233)
[error] 	at scala.collection.TraversableLike.map$(TraversableLike.scala:226)
[error] 	at scala.collection.immutable.List.map(List.scala:294)
[error] 	at com.typesafe.sbt.mocha.MochaTestReporting.logTestResults(MochaTestReporting.scala:78)
[error] 	at com.typesafe.sbt.mocha.SbtMocha$.$anonfun$mochaTestTask$7(SbtMocha.scala:180)
[error] 	at scala.Option.map(Option.scala:146)
[error] 	at com.typesafe.sbt.mocha.SbtMocha$.$anonfun$mochaTestTask$5(SbtMocha.scala:179)
[error] 	at com.typesafe.sbt.mocha.SbtMocha$.$anonfun$projectSettings$15(SbtMocha.scala:128)
[error] 	at com.typesafe.sbt.mocha.SbtMocha$.$anonfun$projectSettings$15$adapted(SbtMocha.scala:112)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40)
[error] 	at sbt.std.Transform$$anon$4.work(System.scala:67)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:269)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error] 	at sbt.Execute.work(Execute.scala:278)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:269)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (foo / mochaOnly) no test suite

If I comment out the inner describe calls so that all the it tests are now on the same level, then the tests run normally again.
I also forked sbt-mocha and modified one of the test files in the scripted tests to do this, and I was able to replicate the issue there as well. Unfortunately, I'm not that familiar with the inner workings of this plugin, so I haven't been able to figure out the root cause yet.

I encounter the same issue, when using sbt-mocha in version 1.1.2 and sbt 1.3.10. It worked well with sbt  0.13.15.

This still fails, I added you example here to let it run through tests:

#33

I do think MochaTestReporting.scala needs to be adjusted to support nested describes.
If someone comes up with a pull requet to fix that I am happy to review.


Update the crates.io version

Hi, I'm using softbuffer in my toy terminal emulator project on Wayland, and I had to pull softbuffer as a git dependency in order for it to do proper Wayland damage tracking on redraws. Could you please publish the latest master onto crates.io?

I have been meaning to for a little bit already, but there are a few things
that I wanted to finish first (namely making the Wayland implementation
better). I'll push a new version soon, probably without the completely
improved Wayland implementation.
On Fri, Oct 7, 2022, 4:32 PM Marceline Cramer @.***>
wrote:

Hi, I'm using softbuffer in my toy terminal emulator project on Wayland,
and I had to pull softbuffer as a git dependency in order for it to do
proper Wayland damage tracking on redraws. Could you please publish the
latest master onto crates.io?
—
Reply to this email directly, view it on GitHub
https://github.com/john01dav/softbuffer/issues/28, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6MJIKS5SCV454ZFJRDTX3WCCJGNANCNFSM6AAAAAAQ753C3I
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I have been meaning to for a little bit already, but there are a few things that I wanted to finish first (namely making the Wayland implementation better). I'll push a new version soon, probably without the completely improved Wayland implementation.

I had been meaning to fork softbuffer and make my own improvements on Wayland. Do you need help with anything?

Any PRs that you'd like to offer with any Wayland improvements would be
greatly appreciated. It's pretty obvious what the issues are just from
running the examples, but I can collect a list of specific issues if you
prefer. Do you have any experience with Wayland? That API is sufficiently
complicated that it feels like I need to read a book on it to make
everything work fully properly. I'd like to do that amount of reading on it
at some point, but I don't have the time right now.
On Fri, Oct 7, 2022, 6:25 PM Marceline Cramer @.***>
wrote:

I have been meaning to for a little bit already, but there are a few
things that I wanted to finish first (namely making the Wayland
implementation better). I'll push a new version soon, probably without the
completely improved Wayland implementation.
I had been meaning to fork softbuffer and make my own improvements on
Wayland. Do you need help with anything?
—
Reply to this email directly, view it on GitHub
https://github.com/john01dav/softbuffer/issues/28#issuecomment-1272157003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6MJIPISPXIOFMWORCZQKTWCCWPPANCNFSM6AAAAAAQ753C3I
.
You are receiving this because you commented.Message ID:
@.***>

I don't have much hands-on experience with Wayland, no, but I figure that something like double-buffering (to get rid of the screen-tearing during normal operation and shearing on resize, would fix #11) would be pretty straight-forward to implement. I was planning on referencing tried-and-true Wayland shm implementations like minifb and foot, but if that doesn't work, I can take the time myself to learn the nitty-gritty specifics of Wayland. I need shared memory-based CPU graphics in lots of the projects I do, so I'm happy to put a lot of time into softbuffer's Wayland backend if it means that my projects can run on non-Wayland for other people too.
There are two major issues that I've personally noticed while using softbuffer that I plan to fix:

My compositor (Sway) greatly slows down with more than a few full-screen softbuffer windows updating. I want to add damage rects (#9) to the API to reduce the strain on the compositor.
Transparency is unsupported (#17). I can add this for Wayland and X11 (again, by referencing working impls) but not for other platforms. This would also require an API change.

0.2.0 is now released, see the changelog for changes.


MINOR: Escape '<' and '>' symbols in quickstart streams code snippet

This was missing from an earlier PR that escaped these symbols in another section of the doc.

LGTM, thanks for the cleanup!


Deprecate shard_size in push_to_hub in favor of max_shard_size

This PR adds a max_shard_size param to push_to_hub and deprecates shard_size in favor of this new param to have a more descriptive name (a shard has at most the shard_size bytes in push_to_hub) for the param and to align the API with Transformers.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


examples/c: Add support for riscv64

Add riscv64 vmlinux.h header. Update Makefile to identify riscv64 architecture.
After the test, make minimal can succeed and the program can run with correct results.
In addition, it has also been tested on the x86 architecture and has no impact.
The system information and test results are as follows:
ubuntu@ubuntu:~/work/libbpf-bootstrap/examples/c$ uname -a
Linux ubuntu 5.19.0-1012-generic #13~22.04.1-Ubuntu SMP Thu Jan 12 15:34:31 UTC 2023 riscv64 riscv64 riscv64 GNU/Linux
ubuntu@ubuntu:~/work/libbpf-bootstrap/examples/c$ make minimal
...
...
  LINK     /home/ubuntu/work/libbpf-bootstrap/examples/c/.output/bpftool/bootstrap/bpftool
  GEN-SKEL .output/minimal.skel.h
  CC       .output/minimal.o
  BINARY   minimal
ubuntu@ubuntu:~/work/libbpf-bootstrap/examples/c$ sudo ./minimal
libbpf: loading object 'minimal_bpf' from buffer
libbpf: elf: section(3) tp/syscalls/sys_enter_write, size 104, link 0, flags 6, type=1
libbpf: sec 'tp/syscalls/sys_enter_write': found program 'handle_tp' at insn offset 0 (0 bytes), code size 13 insns (104 bytes)
libbpf: elf: section(4) .reltp/syscalls/sys_enter_write, size 32, link 13, flags 40, type=9
libbpf: elf: section(5) license, size 13, link 0, flags 3, type=1
libbpf: license of minimal_bpf is Dual BSD/GPL
libbpf: elf: section(6) .bss, size 4, link 0, flags 3, type=8
libbpf: elf: section(7) .rodata, size 28, link 0, flags 2, type=1
libbpf: elf: section(8) .BTF, size 599, link 0, flags 0, type=1
libbpf: elf: section(10) .BTF.ext, size 160, link 0, flags 0, type=1
libbpf: elf: section(13) .symtab, size 192, link 1, flags 0, type=2
libbpf: looking for externs among 8 symbols...
libbpf: collected 0 externs total
libbpf: map 'minimal_.bss' (global data): at sec_idx 6, offset 0, flags 400.
libbpf: map 0 is "minimal_.bss"
libbpf: map 'minimal_.rodata' (global data): at sec_idx 7, offset 0, flags 80.
libbpf: map 1 is "minimal_.rodata"
libbpf: sec '.reltp/syscalls/sys_enter_write': collecting relocation for section(3) 'tp/syscalls/sys_enter_write'
libbpf: sec '.reltp/syscalls/sys_enter_write': relo #0: insn #2 against 'my_pid'
libbpf: prog 'handle_tp': found data map 0 (minimal_.bss, sec 6, off 0) for insn 2
libbpf: sec '.reltp/syscalls/sys_enter_write': relo #1: insn #6 against '.rodata'
libbpf: prog 'handle_tp': found data map 1 (minimal_.rodata, sec 7, off 0) for insn 6
libbpf: map 'minimal_.bss': created successfully, fd=4
libbpf: map 'minimal_.rodata': created successfully, fd=5
Successfully started! Please run `sudo cat /sys/kernel/debug/tracing/trace_pipe` to see output of the BPF programs.
.....^C

ubuntu@ubuntu:~/work/libbpf-bootstrap/examples/c$ sudo cat /sys/kernel/debug/tracing/trace_pipe
         minimal-3989    [003] d...1 15514.859049: bpf_trace_printk: BPF triggered from PID 3989.

         minimal-3989    [003] d...1 15515.863017: bpf_trace_printk: BPF triggered from PID 3989.
...

Fixed issue #150

needs at least a rebase now

Done ~
Thanks for review.


ui-grid: tabbing into and out of the grid?

Hi guys,
I have a ui-grid on the page which displays search results. I need to be able to tab into it after hitting Search button and navigate the rows. Once a row is selected, I need to be able to tab out to an 'Open' button (which is outside the grid). Is this possible?
Thanks!

I have a number of fields (textboxes, checkboxes, selectfields etc) along with a number of grids (implemented using ui-grid) in a single page. Tabbing works fine in the page through various fields until i encounter the grid. The tabbing skips the grid and goes straight to next field ! I hope this fix will help me too ! Thanks to Paul and Swalters on this !


drivers: usb_dc_stm32: do not restrict out stage transfers to one MPS

Do not restrict control out stage transfers to one MPS.
Related to #19038

@jfischer-phytec-iot , should it be back ported on 1.14? (cf #19038)

@erwango yes


Container deployment template or descriptor

A feature that I think would really help is to have a way to provide a deployment description when creating a container.  When creating a container the UI pops up a dialog with a number of fields.  For my cases using docker I am creating new containers with the same parameters each time.  From the command line this is easy, I can reuse the same command with all the arguments and just change the image name.  It would be great in DockerUI if we could upload a file or create a template that we could apply from the create container dialog.  This would then apply all of the settings to the container when it runs.

I agree with you and I am working on it . But this repo seems that author no longer manger it .Many pull request are not merged and issues have nobody to answer. Why?

Maintainer here, I've been traveling without internet for the last 6 weeks and just got back yesterday. It'll take me a while to catch up with everything.

Related to #128. I like the idea

So...something like docker-compose support? Being able to specify a docker-compose.yml file (and perhaps a registry/list of them) to generate containers from? Would be awesome.....

It seems to be something different from docker compose, I think it's just add a label to a container like kubernets add labels to containers so we can select them easily

Portainer has support for App templates, which are pre-defined container configurations that can be run in a few clicks. We also allow the users to specify their templates.
See https://github.com/portainer/portainer


[HUDI-2376] Add pipeline for Append mode

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run travis

+1, very promising PR, thanks for the contribution ~

Thank you for your advice！

@hudi-bot run azure


Bug Report. When creating a strategy V1 spot_perpetual_arbitrage in a bot created via a dashboard.

Describe the bug
My error
10:17:52 hummingbot_application MQTT Bridg
e connected with success.
10:18:39 async_utils Unhandled error in background task:The
module spot_perpetual_arbitrage does not contain any subclass of
ScriptstrategyBase (See log file for stack trace dump)
appears in the bot created through the dashboard. When I create a strategy in an isolated bot, everything works. Perhaps the same error occurs in other strategies V1 in such bots.
Steps to reproduce

Version 1.24 and 1.25
Bot created through the dashboard
strategy V1 spot_perpetual_arbitrage
02:15:19 async_utils Unhandled error in background task:
The module spot_perpetual_arbitrage does not contain any subclass of Sc
riptstrategyBase (See log file for stack trace dump)
There is no such error in a bot created from scratch without a dashboard.

Release version
1.24 and 1.25
Type of installation
Source
Attach required files
No response

I previously sent the strategy to the scripts folder and that's why there was an error.


Type 'undefined' is not assignable to type 'string'.  TS2345

Hello,  I came across this project doing some research into DIY recycled plastic extrusion machines.
I've been developing web applications for long time so I was pretty excited to see you are using React / Node. Hopefully I can help out.
I cloned the repo to get up and running and ran into a typescript compile error in Action.tsx file in the pages/home folder:
Type error: Argument of type '{ resetPassword: true; actionCode: string | string[] | undefined; }' is not assignable to parameter of type 'IState | ((prevState: Readonly<IState>, props: Readonly<any>) => IState | Pick<IState, "resetPassword" | "actionCode"> | null) | Pick<IState, "resetPassword" | "actionCode"> | null'.
  Type '{ resetPassword: true; actionCode: string | string[] | undefined; }' is not assignable to type 'Pick<IState, "resetPassword" | "actionCode">'.
    Types of property 'actionCode' are incompatible.
      Type 'string | string[] | undefined' is not assignable to type 'string'.
        Type 'undefined' is not assignable to type 'string'.  TS2345

    58 |     } else if (values.mode === 'resetPassword') {
    59 |       this.handleResetPassword(auth, actionCode)
  > 60 |       this.setState({ resetPassword: true, actionCode })
       |                     ^
    61 |     } else {
    62 |       this.props.history.push('/')
    63 |     }

I'm comfortable with React but haven't worked much with typescript so it's not readily apparent what value actionCode should have.  Looks like it is referencing a query string parameter.
I was able to get it to compile by assigning a default prop to the argument passed to this.handleResetPassword:
this.handleResetPassword(auth, actionCode = '')
this.setState({ resetPassword: true, actionCode })

If this fix seems reasonable for this let me know and I'll push a PR for it.
thanks,
Sean

sorry my bad.. #398


Switch quic-go to pions fork

quic-go currently doesn't support Go modules, switch to a fork
until upstream adds modules support.
https://github.com/lucas-clemente/quic-go/issues/1781

Pull Request Test Coverage Report for Build 1982

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 79.32%

Files with Coverage Reduction
New Missed Lines
%

rtcdtlstransport.go
1
77.4%

Totals

Change from base Build 1980:
0.02%

Covered Lines:
3897

Relevant Lines:
4913

💛  - Coveralls


Add support for PowerShell Remoting sessions

I have added support for PowerShell Remoting (also called WinRM) sessions to the PowerShellSessionLexer. These follow the format below.
[Hostname]: PS C:\> Get-ChildItem

I have added this by adding an optional non-capturing group to the regex in front of the traditional regex. I hope this follows all the rules and that I did not miss an edge case.

Could you please add a test case for this? You can generate one using the unittest formatter, but I'd feel better about it with at least some basic test added.

Sure, I will add it soon

On 22 Feb 2020, at 20:53, Matthäus G. Chajdas<EMAIL_ADDRESS>wrote:

Could you please add a test case for this? You can generate one using the unittest formatter, but I'd feel better about it with at least some basic test added.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have added the test case you requested. Please check to see if it makes sense to test it this way (I'm fairly new to unit testing).

Merged, thanks!


Using shipit-npm with Grunt fails

Hi,
Maybe I'm doing something wrong, but I cannot find out why.
I've just installed shipit-npm in my project and loaded it in Gruntfile.js by grunt.loadNpmTasks('shipit-npm'). After running grunt shipit:[stage] deploy` I got error in console:
Task 'npm:init' is not in your shipitfile

Do I have to do something more than loading the module in Gruntfile? I've event tried to set options of shipit-npm under shipit.options in Gruntfile but that didn't help. I've also created a shipitfile.js with exact config as in README.md but it wasn't it too.
Thanks for help!

All right, just after posting this question I've found a way to do what I need :)
For others, here's my Gruntfile.js config:
module.exports = function(grunt) {
    grunt.loadNpmTasks('grunt-shipit');
    grunt.loadNpmTasks('shipit-deploy');
    grunt.loadNpmTasks('shipit-npm');
    require('shipit-npm')(grunt.shipit);

    grunt.initConfig({
        shipit: {
            options: {
                workspace: '/tmp/local-deploy-dir',
                deployTo: '/tmp/deploy-dir',
                repositoryUrl: 'https://github.com/author/repo,
                ignores: ['.git'],
                keepReleases: 3,
                npm: {
                    remote: false,
                    installFlags: ['--production']
                }
            },
            staging: {
                servers<EMAIL_ADDRESS>            }
        }
    });
};

@callerc1 If you don't mind, I'll provide a pull request with README update soon.


Version bump to 0.6.0

Please, bump version in order not to create a new bower component.

thanks)


Widget doesn't show up after package installation

Cumulocity Tenant Version
UI 1016.0.303
Backend 1018.540.0
Widget Relaese 0.0.3
I uploaded the package and installed it to a copy of the standard Cockpit but it doesn't show up in the Widget Library.

Works after Frontend/Ui Update to 1018.0.214.


Contentformat senml

application/senml+json and application/senml+cbor, implementation has dependency with cf-2.0.0-M13.

Thx for the contribution.
First step for a contribution to an eclipse project, the legal stuff  ...
Here more details about it : https://github.com/eclipse/leshan/wiki/How-to-contribute#legal-stuff-
Is it OK for you ?

Thx for the contribution.
First step for a contribution to an eclipse project, the legal stuff ...
Here more details about it : https://github.com/eclipse/leshan/wiki/How-to-contribute#legal-stuff-
Is it OK for you ?

I had signed ECA few month ago, and I sign-off just now.

I looked at this PR quickly and It will be hard to review it and integrate it like this (too big, commit cherry picked from master, ...)
I propose to cut this contribution in several smaller PR :

contributing SenML-JSON encoder in leshan-core inspired by LwM2mJson  + unit tests (at least spec examples)
contributing SenML-JSON decoder in leshan-core inspired by LwM2mJson  + unit tests (at least spec examples)
contributing LwM2mNodeSenMLEncoder for SenML-JSON + unit tests
contributing LwM2mNodeSenMLDecoder for SenML-JSON + unit tests
add SenML-JSON content format + encoder to DefaultLwM2mNodeEncoder.
contributing SenML-CBOR encoder in leshan-core   + unit tests (at least spec examples)
contributing SenML-CBOR decoder in leshan-core   + unit tests (at least spec examples)
contributing LwM2mNodeSenMLEncoder for SenML-CBOR + unit tests
contributing LwM2mNodeSenMLDecoder for SenML-CBOR + unit tests
add SenML-CBOR content format + encoder to DefaultLwM2mNodeEncoder.
add SenML-JSON + SenML-CBOR to leshan demo.

Does it make sense to you ?
(If you are ok, do not forget to sign all your future commit)

I looked at this PR quickly and It will be hard to review it and integrate it like this (too big, commit cherry picked from master, ...)
I propose to cut this contribution in several smaller PR :
1. contributing **SenML-JSON** encoder in `leshan-core` inspired by `LwM2mJson`  + unit tests (at least spec examples)

2. contributing **SenML-JSON** decoder in `leshan-core` inspired by `LwM2mJson`  + unit tests (at least spec examples)

3. contributing `LwM2mNodeSenMLEncoder` for **SenML-JSON** + unit tests

4. contributing `LwM2mNodeSenMLDecoder` for **SenML-JSON** + unit tests

5. add **SenML-JSON** content format + encoder to `DefaultLwM2mNodeEncoder`.

6. contributing **SenML-CBOR** encoder in `leshan-core`   + unit tests (at least spec examples)

7. contributing **SenML-CBOR** decoder in `leshan-core`   + unit tests (at least spec examples)

8. contributing `LwM2mNodeSenMLEncoder` for **SenML-CBOR** + unit tests

9. contributing `LwM2mNodeSenMLDecoder` for **SenML-CBOR** + unit tests

10. add **SenML-CBOR** content format + encoder to `DefaultLwM2mNodeEncoder`.

11. add **SenML-JSON** + **SenML-CBOR** to leshan demo.

Does it make sense to you ?
(If you are ok, do not forget to sign all your future commit)

Make sense, I have created first PR #659 already. However, I have to update DefaultLwM2mNodeEncoder in first commit, in order to reuse existing encoder unit test

Close this one, and will split into more smaller size PRs.


Intermittent failure "No request context available"

https://github.com/medplum/medplum/actions/runs/6229558289/job/16908256945?pr=2869
  Summary of all failing tests
  FAIL src/fhir/repo.test.ts (5.107 s)
    ● FHIR Repo › Rebuild compartments success

      No request context available

        55 |   const ctx = requestContextStore.getStore();
        56 |   if (!ctx) {
      > 57 |     throw new Error('No request context available');
           |           ^
        58 |   }
        59 |   return ctx;
        60 | }

        at getRequestContext (src/context.ts:57:11)
        at src/fhir/repo.ts:726:26
        at SelectQuery.executeCursor (src/fhir/sql.ts:416:13)
        at Repository.rebuildCompartmentsForResourceType (src/fhir/repo.ts:720:5)
        at Object.<anonymous> (src/fhir/repo.test.ts:532:5)

@mattwiller - what is expected behavior for getRequestContext in long running async jobs?

My expectation is that the context should follow the async call chain independent of duration, since there's nothing removing the context from the AsyncLocalStorage instance.  I'll take a look to see if it's not being propagated correctly somewhere

This should hopefully be resolved with the AsyncLocalStorage fixes, but if the issue re-emerges feel free to reopen


perfect FunctionScanner class

[x] Add FunctionScanner for the new feature.
[x] Add tests for the new feature.
[x] Add a CHANGELOG.md entry for the new feature.

Originally posted by @pifeifei at https://github.com/zendframework/zend-code/pull/181

Hey, all the scanners are generally to be avoided: consider using (and contributing to) roave/better-reflection instead

Originally posted by @Ocramius at https://github.com/zendframework/zend-code/pull/181#issuecomment-569421249

Performance, which can be ignored temporarily
purpose
The code prompt file is generated automatically according to the ide-helper-generator I wrote. It's useful here to scanner
conceive

For PHP Extensions, such as swoole updates

Existing ide helper (v2.2.0)
<?php

/**
 * docblock and other
 */
class Server{
    /**
     * docblock and other
     * @param string $ip
     * @param int $port
     */
    public function __constuct($ip, $port);
}

/**
 * function docblock and other
 * @param string $ip
 * @param int $port
 */
function swoole_server($ip, $port);

Need to update to 4.x.x

function and class updating.

<?php
Swoole\Server::__construct(string $host, int $port = 0, int $mode = SWOOLE_PROCESS,$sock_type = SWOOLE_SOCK_TCP);
function swoole_server($ip, $port, $mode, $sock_type);

Desired result

Version updates inevitably have functions / class added, deprecated, deprecated, and existing comments combined to generate the latest version of ide-helper

<?php

/**
 * docblock and other
 */
class Server{
    /**
     * docblock and other
     * @param string $ip
     * @param int $port
     * Some parameters are not, and need to be processed manually.
     */
    public function __constuct(
        string $host,
        int $port = 0,
        int $mode = SWOOLE_PROCESS,
        $sock_type = SWOOLE_SOCK_TCP
    );
}

/**
 * function docblock and other
 * @param string $ip
 * @param int $port
 */
function swoole_server($ip, $port, $mode, $sock_type);

Here you need to use  classScanner and  FunctionScanner.
The actual situation
One day I need to use ftp to update the html files of different servers, because the server has an intranet IP, using the passive mode, the upload fails all the time, and various searches on the Internet have not found a suitable one. I didn't find it, and finally found php bug # 55651. I need a parameter FTP_USEPASVADDRESS to solve the problem instantly. Then I went through the documentation and finally found this parameter in the English page.
Chinese Version：no FTP_USEPASVADDRESS
English original：Have FTP_USEPASVADDRESS
If you have the latest code prompt, type FTP_ and you will be prompted accordingly. There is no need to work hard to find a solution.
Of course, this is official and there is help documentation, so using your own development php extension, or niche php extension, ide-helper automatic generation will be very convenient. You don't need to check the git log to improve the document, although I will not develop PHP at this time. Expansion.

Conclusion: I have a limited level of English, and I am learning English in order to see the original English documents. These are also translated with Google. Please forgive me if there are errors.

Originally posted by @pifeifei at https://github.com/zendframework/zend-code/pull/181#issuecomment-569468145

The FunctionGenerator class is also added to see if it is needed.
at master branch: https://github.com/pifeifei/zend-code.git

Originally posted by @pifeifei at https://github.com/zendframework/zend-code/pull/181#issuecomment-569918548

No longer needed as per #58


Bug: publishing  does not work

Current publishing scripts use ancient Node 10 and old cluster scripts, which no longer work:

https://app.circleci.com/pipelines/github/ipfs/awesome-ipfs/1071/workflows/46e19899-e038-406a-8ad1-ce0c92b7e41e/jobs/1762?invite=true#step-102-12

This means website updates are not published correctly.
We should fix publishing by switching to Fleek.
TODO

[x] see if there is an easy (one-line) fix, if not, we need to migrate to Fleek
[x] remove old publishing scripts (based on olizilla/ipfs-dns-deploy)
[x] add awesome.ipfs.io to Fleek

name it awesome-ipfs, this will give us DNSLink /ipns/awesome-ipfs.on.fleek.co

[x] update DNS to point at Fleek

remove from collab cluster configs in https://github.com/protocol/bifrost-infra
add to managed domains in https://github.com/protocol/infra/ and set awesome.ipfs.io to point at Fleek CDN and DNSLink

@SgtPooki this is a good opportunity for you to learn how hosting websites on Fleek works

I hosted pl-compass on fleek. It's crazy easy. I could handle this

I had to migrate to https://awesome.ipfs.tech (part of https://github.com/protocol/bifrost-infra/issues/178):

the new domain is live, Fleek previews are enabled on PRs
the old domain will be updated after https://github.com/protocol/infra/issues/908 is resolved


Potential Data Inconsistency Due to Lack of Locking for Shared Variables in add_frames

I noticed that in the add_frames function here, there are self.lock.acquire() and self.lock.release() lines, which I believe are intended to protect the variables self.frames_np, self.frames_offset, and self.timestamp_offset for thread safety. However, I noticed that these variables are also modified in other threads, and those other threads do not use the lock.
My question is: Could these variables be modified simultaneously by two threads, leading to potential data inconsistency issues?

Thanks for pointing out. We're looking into but yeah its possible that there is a data leakage if we make changes in another thread without a lock.


add generic push/pull functionality to upload/download files to/from production

There are times when it is necessary to upload a large file into a production component. For instance, if it is needed to seed a database with a very large database dump, the local tunnel will timeout. In this case, uploading the large file into that component, then console'ing in and importing would do the trick.
Could potentially look like this:
nanobox push data.db /path/to/local/file /path/to/remote
And pull would be the same, just in reverse.
This implementation might span multiple components so we will need to figure out how or where to do this.

This issue was moved to nanobox-io/nanobox#302


[otbn] Document the idle_o signal

As Sri pointed out, I've just added some DV code that checks the
idle_o signal does what I think it should do, but this isn't actually
specced anywhere. Fix that!

See https://github.com/lowRISC/opentitan/pull/5703#discussion_r600917699 for the comment about the missing spec.


Support with repos with multiple devcontainer configurations

I have a repo that has a couple services in it each with their own devcontainer config it looks kinda like this
.devcontainer
  service1
    devcontainer.json
  service2
    devcontainer.json
src
  service1
    ...
  service2
    ...

When I run the app to launch my editor it doesn't detect any of the configurations

version 0.1.7
https://containers.dev/implementors/spec/#devcontainerjson
https://github.com/microsoft/vscode-docs/blob/main/remote-release-notes/v1_75.md#folders-with-multiple-devcontainerjson-files

Very interesting, I didn't know about this feature yet - but I definitely want to use it in future.
So I have the following idea in mind about how this could work:
We add an arg --select container_name, which will then open the specified devcontainer.
If you open a multi-container project without this arg, we will detect that and reply with a list of available devcontainers. Later we could also use a TUI (similar to the recent-ui feature) for that.
Let me know what you think.

I suspect this solution will work, I started to work on on something to handle that scenario. Still new with rust so still wrapping my head around the code so no promises.

So that the app crashed (panicked) was actually a bug, which is now (in the next version) fixed: https://github.com/michidk/vscli/commit/90b3f11502d58502f2a2aecc39a8332697f17411
So when opening a multi-devcontainer environment now, this error will show:
I: Devcontainer not found, opening the classic way...

I created this: https://github.com/michidk/vscli/pull/36
Basically craws all devcontainers, assigns them an index and adds a command that can be used to select them.
However, I am not quite sure if this is actually possible.
The way to open a devcontainer boils down to call vscode-remote://dev-container+{hex encoded path to workspace}{folder inside the container}
I am not quite sure how one would tell vscode which devcontainer to actually use.

Okay, I found a way by basically disassembling the vscode devcontainer extension. And its a bit more involved than I thought, but it is indeed possible!

So the implementation is done and works. It can be tested on the multi-devcontainers branch: https://github.com/michidk/vscli/tree/multi-devcontainers
In this branch, I also changed a bunch of other stuff. Basically the code is a lot better now and the behavior clearer to understand.

This was implemented with the release of version 0.2.0.
Since this was a really interesting journey, I made a write-up of how I figured that one out. You can read it over here: https://blog.lohr.dev/launching-dev-containers-from-code-is-impossible

Works great, thanks.
Interesting read on the blog.


Setup windows debug libraries in Connext_LIBRARIES (cmake module)

The Visual Studio build of RTI Connext generates release and debug libraries (same using a "d" postfix). The issues is not critical as far as you don't need to debug the RTI Connext libraries. And the workaround would be to modify the _excpected_library_base_names in FindConnext.cmake package adding a d at the end.
I would say that the proper way of getting this defined in the Find cmake module would be to use:
set(Connext_LIBRARIES optimized nddsc debug nddscd
                      optimized ...   debug ...)

Something similar is implemented in the FindwxWindows.cmake module
When I tried a quick test for this layout ament is generating the error:
ament_export_libraries() package 'rmw_connext_cpp' passes the build configuration keyword 'debug' as the last exported library

Could be that some parsing/code in the ament package does not support this way of defining the libraries? I need to investigate about it.

ament supports build configuration keywords. If you can point me to the modified version and what exactly you called I could take a look.

If you can point me to the modified version and what exactly you called I could take a look.

I run a quick test just adding this line at the end of the FindConnext.cmake module (just a stub for triggering the error).
@@ -249,6 +228,8 @@ if(Connext_FOUND AND NOT WIN32)
   list(APPEND Connext_LIBRARIES "pthread" "dl")
 endif()

+set(Connext_LIBRARIES optimized nddsc debug nddscd)
+
 include(FindPackageHandleStandardArgs)
 # Connext_HOME, Connext_LIBRARY_DIRS, and Connext_LIBRARY_DIR are not always se
 find_package_handle_standard_args(Connext

Install the connext_cmake_module and run ament build --only rmw_connext_cpp
 - Found rosidl_typesupport_connext_cpp: 0.0.0 (C:/Users/jrivero/code/ros2_build
/install/share/rosidl_typesupport_connext_cpp/cmake)
CMake Error at C:/Users/jrivero/code/ros2_build/install/share/ament_cmake_export
_libraries/cmake/ament_export_libraries.cmake:48 (message):
  ament_export_libraries() package 'rmw_connext_cpp' passes the build
  configuration keyword 'optimized' as the last exported library
Call Stack (most recent call first):
  CMakeLists.txt:44 (ament_export_libraries)

-- Configuring incomplete, errors occurred!
See also "C:/Users/jrivero/code/ros2_build/build/rmw_connext_cpp/CMakeFiles/CMak
eOutput.log".

That is a quoting problem in the rmw_connext_cpp CMake code. The following PR fixes this: ros2/rmw_connext#90


Why do characters have no color when loaded into Blender

Why do characters have no color when loaded into Blender

When you export it as a video or image, it will have color.


Any plan on getting this to work on a later leaflet?

Sorry .. I think it works, its just the demo that's not updated


Publish 09/21/2022 3:30 PM PT

Docs Build status updates of commit 3355a24:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/New-CsTeamsAudioConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsAudioConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update README.md

Codecov Report

Merging #4 (8cd6072) into master (28d8305) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   94.02%   94.02%
=======================================
  Files           2        2
  Lines         251      251
=======================================
  Hits          236      236
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d8305...8cd6072. Read the comment docs.


Replaced codeblocks with pre tag wrap

Wouldn't it be better to change
```
// code
```

with
```javascript
// code
```

?


DO NOT MERGE Add graceful restart support.

This needs the FVs to be run over it as well as some manual testing.

Track the chains that are really in the dataplane.
Don't flush or stub out chains that already exist until
end of GR window.

Fixes #339.

What's the plan for doing the testing on this?  @fasaxc is this with you, or are you expecting some help from the Ocelot team?

See my comment in the issue - I think this is a workaround for the way the cleanup currently works, and it would be potentially cheaper and simpler to tweak the cleanup code so the issue goes away.

AFAIK this isn't needed for 0.18, so deferring as we already have too much else to get in today.

I think we can punt this to 0.19.  It's not as important as the other things that are going on.

Oops, one of my new UTs depended on the print order of a dict.  Fixing up...

Should be fixed now.

I hate to go back on my view that we should just accept this, but I've been a bit shaken by just how many lines of code it is for something so marginal (though much of it is tests). That doesn't mean we shouldn't take it, but it does mean that I need to spend more time reviewing it than I had expected, and have not had time yet.

That'll teach me to add UT and extra comments :-P

Assigning this to @Lukasa as this has been languishing for a long time now and has already been deferred from two releases.  As @plwhite is OOO today, it makes sense for someone else to have a look so that we can hopefully get the code in and running through some tests before the 0.20 release.

This is a complex review job and it's hard to do effectively, but there's nothing obviously wrong with this. I'm going to merge for now, but further feedback on this change is welcomed.

Also merged to feature/neutron-ha


ufinder suggested enhancements

hcam-finder version: 1.1.4

Would it be possible to add a faint grey dashed line marking the ULTRACAM dividing line between left & right on ufinder? Idea is to remind people not to put the target too close to it and it serves to indicate the readout direction which is relevant to bleeding of charge from bright stars.
Second possible enhancement: add an indication of the bottom of the chip which is of relevance when setting fields for drift mode when one expects to use the drift mask.
Apologies if this is a mis-use of "issues"

Cheers tom.
Excellent suggestions. We already have the dividers for HiPERCAM, should definitely add them for ULTRACAM as well.
Good idea about indicating the bottom of the chip. Perhaps a thicker line along the bottom?

Cheers tom.
Excellent suggestions. We already have the dividers for HiPERCAM, should definitely add them for ULTRACAM as well.
Good idea about indicating the bottom of the chip. Perhaps a thicker line along the bottom?

yes, a thicker line would do fine

yes, a thicker line would do fine

fixed in https://github.com/HiPERCAM/hcam_finder/commit/acc5c82e04ee6be1a0d1cc5335ab9c1bb45e6371
install V1.1.5 for fixes

fixed in https://github.com/HiPERCAM/hcam_finder/commit/acc5c82e04ee6be1a0d1cc5335ab9c1bb45e6371
install V1.1.5 for fixes


dom-repeat stomps incorrect data when user slices the array used for rendering

It seems that dom-repeat template is handling array slices incorrectly in certain cases.
Live Demo
Example 1:
http://jsbin.com/wevevuqunu/edit?html,console,output
Example 2:
http://jsbin.com/lumunemipa/edit?html,output
Steps to Reproduce

Click reorder button

Expected Results
Numbers in bold should change in both examples
Actual Results
Numbers in bold stay unchanged in example 1, example 2 with this.async() works as expected.

This doesn't look like an error to me, it's just an optimization. I can explain why it works like this.
In your first example, you only reorder the original objects in your array. Polymer sees [1,2,3] -> [2,1,3] so it only reorders the position of the rendered elements, and doesn't construct new ones.
In your second example, you add this.async() after removing two elements from the array, and in the asyc function, you add them again. This causes Polymer to see [1,2,3] -> [3] -> [2,1,3] so after first step it destroys the two elements, and after the second step, it constructs new ones.
Multiple array operations are batched (with a debounce-like guard), and the async() causes it to see the intermediate state because there is a pause in execution between the two steps.
async() doesn't do anything special here, if you change the async() to wrap all the mutations you will see that it doesn't change anything:
this.async(function(){
        var left = this.splice('rows', 0, 1)[0];
        var right = this.splice('rows', 0, 1)[0];
        this.splice('rows', 0, 0, right);
        this.splice('rows', 1, 0, left);
        console.log(this.rows);
})

If all array mutations happen without preemption, polymer will only see the array change from the original state to the new state, detect that it's only a reordering, and will only re-order the original stamped elements instead of constructing new ones.
This feature is actually great; without it every array manipulation would immediately trigger DOM manipulation and everything would be prohibitively expensive. Now operations like changing the order of your array are really cheap because it effectively only causes elements to be re-positioned in the DOM instead of having to be rebuilt completely.
If you want to explicitly rebuild elements, you have to separate removing your items and inserting them into different steps, like you did with async(). Something like setTimeout will also work. This will make Polymer first destroy the old elements before creating new ones to insert.
Hope that helps :)

I don't think you are right, because if it would be reordering them, the values should also switch positions.
Notice that element in bold is inside test-elem shadow dom, so if reordering would work - the numbers would ALSO switch position - thats my real concern here.

maybe related to #4188

You are right, it looks like the DOM nodes are not redistributed, and only the properties are changed. My points above still stand, but it does look like an unexpected behavior.
#1713 Has good discussion on this subject

I've tried another stab at the problem using sort:
http://jsbin.com/rimogiwola/edit?html,js,output
Maybe I implemented this incorrectly - but it doesn't seem to improve anything.


Add tests for the kubernetes controller

We need tests for the kubernetes controller, you can see how AWS is doing it here and use it as an example.
We need to test for basic functionality such as successful creation, and deletion as well as if we encounter errors. We don't currently allow for updating of resources so this will be good plumbing to put in before that.

Hello, @ADustyOldMuffin  I want to contribute to this project. Please assign.

Hello @FaithKovi! Sure thing, we have several examples already of tests for things like the Container Registry.
Let me know if you have any questions!

sure, thanks @ADustyOldMuffin  I will let you know if I have any questions.

@ADustyOldMuffin I won't be able to complete this. You can assign to someone else


bug: pnpm remove doesn't work

Provide environment information
System:
OS: Linux 6.2 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
CPU: (16) x64 AMD Ryzen 7 4800H with Radeon Graphics
Memory: 51.45 GB / 62.22 GB
Container: Yes
Shell: 5.1.16 - /bin/bash
Binaries:
Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
Yarn: 1.22.19 - /usr/bin/yarn
npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm
Watchman: 20230129.130010.0 - /usr/local/bin/watchman
Describe the bug
Initialized turbo, and can't remove packages inside apps/expo directory. Made already some commits to the repository, but now decided to get rid of @shopify/flash-list package, and can't do it.
pnpm remove @shopify/flash-list
../..                                    |  WARN  `node_modules` is present. Lockfile only installation will make it out-of-date
 ERR_PNPM_FETCH_404  GET https://registry.npmjs.org/@acme%2Feslint-config: Not Found - 404

This error happened while installing a direct dependency of /home/aleshaoleg/Documents/Projects/wealth-way/apps/expo

@acme/eslint-config is not in the npm registry, or you have no permission to fetch it.

No authorization header was set for the request.

With installation, there was no problem at all and all of the @acme packages were installed.
Link to reproduction
https://github.com/solofeed/wealth-way
To reproduce
cd apps/expo && pnpm remove @shopify/flash-list
Additional information
No response

I'm also experiencing this, I got used to deleting it from package.json and then running  pnpm i 🙈

Run with --filter or -F from root and it should work:

Hi I also ran into this issue. Is there a way we could enable running the "remove" from a workspace? Any idea why this is not working?


Edge versions

I just discovered that my Edge version is 20.1xxx...
In browser section of the web i see Edge at 12 as current version. Is it ok?
I just wanted to report this as it might be overooked.

Duplicate of #1928.


default role naming add 2 __

Recomendation: no _, just the number.

there was no double _ but removed the single _

oh, found the double _ - the reason it was double was to avoid the conflict with the single generated in _allocRole; now that there is no underscore in _allocRole, I replaced the double with single


WIP removing binary files

This does three things:

Removes the following files:
delete mode 100644 dat/filter_curves
delete mode 100644 dat/nm_all_results.jld
delete mode 100644 dat/nm_results2.jld
delete mode 100644 dat/parallel_results_1444286953.JLD
delete mode 100644 dat/parallel_results_1444288483.JLD

It moves the prior files to a directory cfg (for configuration; I'm open to renames)

Moves remaining test data (stamps) to test/data.

Still to do: I'd like to remove the stamp files from the repo as well as part of this PR. Options:

put them on a webserver and download them (do we have a NERSC project allocation under mantissa?)
get the script originally used to create them and create them on the fly (I assume dustin created them?)

After this PR is merged, I'll run a cleaner on the repo, after which everyone will have to get a fresh clone.

After issue #123 we'll have the ability to process just one source at a
time. How about waiting until then, and then doing away with stamps
entirely? That way we'd avoid having to  support 2 data formats, one of
which that only gets used in tests, and the tests will cover more of the
code base and use data more like the actual data.
On Mon, Feb 29, 2016, 2:54 PM Kyle Barbary<EMAIL_ADDRESS>wrote:

This does three things:

Removes the following files:
delete mode 100644 dat/filter_curves
delete mode 100644 dat/nm_all_results.jld
delete mode 100644 dat/nm_results2.jld
delete mode 100644 dat/parallel_results_1444286953.JLD
delete mode 100644 dat/parallel_results_1444288483.JLD

It moves the prior files to a directory cfg (for configuration; I'm
open to renames)

Moves remaining test data (stamps) to test/data.

Still to do: I'd like to remove the stamp files from the repo as well
as part of this PR. Options:

put them on a webserver and download them (do we have a NERSC
project allocation under mantissa?)
get the script originally used to create them and create them on the
fly (I assume dustin created them?)

After this PR is merged, I'll run a cleaner on the repo, after which
everyone will have to get a fresh clone.

I agree it would be best to remove the stamp stuff entirely. Let's go ahead and merge this and remember to clean the repo of large files after stamps are eventually removed (we want to clean it only once).

Looks good! All the Python and R, deps.jl, and the file named PYTHON can go too, at least once we've got a new analysis pipeline running.


not work in IE11

Hello! This fast blur not work on internet explorer 11 in windows 8.1...

A polyfill for requestAnimationFrame should fix it: https://gist.github.com/paulirish/1579671


cmake/DetermineGflagsNamespace.cmake was ignored when repush

cmake/DetermineGflagsNamespace.cmake was ignored by .gitignore.
When downloading a release and making it part of a project, that file won't be pushed to git by default.

Why do you use Glog's .gitignore in the first place?


skip store of position if tab is already hidden

position recall was working, but only if you were going to tab and back.
This is because setInvisible is being called on all already invisible tabs (during tab selection). I've taught setInvisible to early return if a tab is invisible already

merged into 3.0.3


Inform the user if a Safe-App initiate a malformed TX

#852

Travis automatic deployment:
https://pr895--safereact.review.gnosisdev.com/app

Nico showed me how the message looks, since the only way to see the message is mess up an application on purpose from the code itself
If any developer tries to implement a new app he will see that, for application that submit tx, they need specific values to be there.
I've check the app workflow just in case, to make sure nothing broke in the process of doing this ticket.
Looks good to me

Travis automatic deployment:
https://pr895--safereact.review.gnosisdev.com/app

any idea what can be wrong?

Travis automatic deployment:
https://pr895--safereact.review.gnosisdev.com/app


我想把我现有的key更换为一个新的key，似乎没有这个功能

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

是的没有这个功能, key不支持更换


Issues for windows users due to dependency on wcwidth

One of our Windows users is reporting problems due to the dependency on wcwidth. I have reported the problem upstream: https://github.com/solidsnack/wcwidth/issues/7
I am currently investigating a solution to the problem

Thanks for the issue!
From the issue you opened in https://github.com/solidsnack/wcwidth/issues/7, this is a problem that we already faced in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1234077695.
The version of wcwidth which is on Hackage (0.0.2) unfortunately does not bundle the pure Haskell implementation (see https://github.com/solidsnack/wcwidth/pull/3 which came after the release of the version 0.0.2). Unfortunately, there is nothing I can do to fix this, other than just copy the source of the package inside this one (which I'd rather not, ideally).
The pure Haskell implementation has been rewritten in https://github.com/solidsnack/wcwidth/pull/6 but we also found a bug in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1236313862 where a single space character does not have the correct width (0 instead of 1). This was meant to be fixed but I don't think it was yet.

Thanks for the quick reply (and the great library). I didn't think about looking into the other issue. But apparently the solution is for upstream wcwidth to release a new version to Hackage, and to then adjust the lower bounds in diagnose accordingly. Right?

As long as the width of the space character is patched, then yes this should be the thing to do to make it work.
The bounds on wcwidth should already be relaxed enough to account for any update which does not go beyond 1.0.0, but we'll see if it needs an update.

Does it mean that diagnose does not work on windows currently?

See this comment: https://github.com/Mesabloo/diagnose/pull/13#issuecomment-1277784256


Please support windows server 2016

Please can you make this available on windows server 2016?

Sorry, no. Terminal requires some platform features that don't exist in a three-year-old version of Windows, even if it is Windows Server.