cargo-tauri: Add SystemConfiguration

Description of changes
cargo-tauri refuses to build on my mac without SystemConfiguration
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

thedavidmeister@davids-iMac rainix % nix develop
warning: Git tree '/Users/thedavidmeister/Code/rainix' is dirty
warning: updating lock file '/Users/thedavidmeister/Code/rainix/flake.lock':
• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/2da337b5578e8173f59aaf8bd185f3b91a6d9de7' (2024-01-09)
  → 'github:nixos/nixpkgs/8c8d2ccce5cce05d03887b27b47a3bfb87eacef6' (2024-01-09)
warning: Git tree '/Users/thedavidmeister/Code/rainix' is dirty
error: builder for '/nix/store/5cja47cfni3rfbzakxzcrclclr373xix-tauri-1.5.4.drv' failed with exit code 101;
       last 10 log lines:
       >
       > warning: `tauri-cli` (lib) generated 2 warnings
       > error: linking with `/nix/store/vwh2qqal1q101wv4jy40giavp73q0msd-clang-wrapper-16.0.6/bin/cc` failed: exit status: 1
       >   |
       >   = note: env -u IPHONEOS_DEPLOYMENT_TARGET -u TVOS_DEPLOYMENT_TARGET LC_ALL="C" PATH="/nix/store/y24qqyfbnnxza5841hd9hnda5icmzymq-rustc-1.74.0/lib/rustlib/aarch64-apple-darwin/bin:/nix/store/30m4ghksg1dlnwfy3qybfixjwnrhgrh9-cargo-1.74.0/bin:/nix/store/6a8n27y9r10pnr653344yybxr4qpd7g9-cargo-auditable-0.6.1/bin:/nix/store/xanxf5bwj0ddd7q34jlafask4475vvpr-pkg-config-wrapper-0.29.2/bin:/nix/store/rp517rlw5kbxcwm382ap5lg0jvn4nakr-auditable-cargo-1.74.0/bin:/nix/store/30m4ghksg1dlnwfy3qybfixjwnrhgrh9-cargo-1.74.0/bin:/nix/store/i2q9ff0fpgr20zza6kr6nlpki6mn43if-rustc-wrapper-1.74.0/bin:/nix/store/vwh2qqal1q101wv4jy40giavp73q0msd-clang-wrapper-16.0.6/bin:/nix/store/3vzbr8yb4c233lhi1qz78b8kaaxrjqcj-clang-16.0.6/bin:/nix/store/pzajj7gw0nazs3vzp6jld53q8ird5izr-coreutils-9.4/bin:/nix/store/0i7w6qsij8akg6h39qn67w9ig5hirv1a-cctools-binutils-darwin-wrapper-16.0.6-973.0.1/bin:/nix/store/i4sfjfz08vmnrj84asl2j5imakga12za-cctools-binutils-darwin-16.0.6-973.0.1/bin:/nix/store/pzajj7gw0nazs3vzp6jld53q8ird5izr-coreutils-9.4/bin:/nix/store/6x5inimwy8rlvf678yy080zccbw71alb-findutils-4.9.0/bin:/nix/store/01bzxsyn8dqz9fsdhp9r6ya796g5ydmf-diffutils-3.10/bin:/nix/store/9z9k8dwhhiryr7z2pz70zca0vwa15yqc-gnused-4.9/bin:/nix/store/zsm4xd527427rnjfnvfhvsld2n57b822-gnugrep-3.11/bin:/nix/store/hhc2x65zvp89lh15grqk21r6dcvifggy-gawk-5.2.2/bin:/nix/store/gclclfhq9blxp32lv8kxm9iv5060rx5f-gnutar-1.35/bin:/nix/store/crpi4clk07gy760ydbb710f74dy8q6c9-gzip-1.13/bin:/nix/store/qay0pa86lb712162d6m5lyw62iczb71d-bzip2-1.0.8-bin/bin:/nix/store/zc9qsb0rzlw0ckhy7097frcwb4pkfx3d-gnumake-4.4.1/bin:/nix/store/6nxav88iiz0g8m598xy643f8hhdz5kkx-bash-5.2-p21/bin:/nix/store/kizmwlnj40d11ixbap74c0syaqxn05wc-patch-2.7.6/bin:/nix/store/xcy0fr1dangwh9r9isay6fqbg91g5b3h-xz-5.4.5-bin/bin:/nix/store/x1bzwj6pz7f3ajg5y36x07b1328jzx7r-file-5.45/bin" VSLANG="1033" ZERO_AR_DATE="1" "/nix/store/vwh2qqal1q101wv4jy40giavp73q0msd-clang-wrapper-16.0.6/bin/cc" "-arch" "arm64" "/private/tmp/nix-build-tauri-1.5.4.drv-0/rustcU4LRYv/symbols.o" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/deps/cargo_tauri-b399a7a0dee433a9.cargo_tauri.8bc1508fc21c95bc-cgu.3.rcgu.o" "-L" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/deps" "-L" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/release/deps" "-L" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/build/ring-a144e74d53e3b6fd/out" "-L" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/build/bzip2-sys-2556bfc5dd9d767f/out/lib" "-L" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/build/zstd-sys-92376e123844ce69/out" "-L" "/nix/store/y24qqyfbnnxza5841hd9hnda5icmzymq-rustc-1.74.0/lib/rustlib/aarch64-apple-darwin/lib" "/private/tmp/nix-build-tauri-1.5.4.drv-0/rustcU4LRYv/libring-4681a2bdd0b770c3.rlib" "/private/tmp/nix-build-tauri-1.5.4.drv-0/rustcU4LRYv/libzstd_sys-cdad3e15de5e96b8.rlib" "/private/tmp/nix-build-tauri-1.5.4.drv-0/rustcU4LRYv/libbzip2_sys-ea051bfcff18846e.rlib" "/nix/store/y24qqyfbnnxza5841hd9hnda5icmzymq-rustc-1.74.0/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_builtins-738eb43ff73087cd.rlib" "-framework" "SystemConfiguration" "-framework" "CoreFoundation" "-framework" "CoreFoundation" "-framework" "CoreServices" "-liconv" "-lSystem" "-lc" "-lm" "-L" "/nix/store/y24qqyfbnnxza5841hd9hnda5icmzymq-rustc-1.74.0/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/deps/cargo_tauri-b399a7a0dee433a9" "-Wl,-dead_strip" "-nodefaultlibs" "/private/tmp/nix-build-tauri-1.5.4.drv-0/source/tooling/cli/target/aarch64-apple-darwin/release/deps/cargo_tauri_audit_data.o" "-Wl,-u,_AUDITABLE_VERSION_INFO"
       >   = note: ld: framework not found SystemConfiguration
       >           clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `tauri-cli` (bin "cargo-tauri") due to previous error
       For full logs, run 'nix log /nix/store/5cja47cfni3rfbzakxzcrclclr373xix-tauri-1.5.4.drv'.
error: 1 dependencies of derivation '/nix/store/44gvrldx2j73l6rymgpnp5gawax62h9l-nix-shell-env.drv' failed to build

Hmm still getting this even with the commit above 🤔

oh lol, i changed the wrong package 😅

Looks like it works now
Ubuntu build: https://github.com/rainlanguage/rainix/actions/runs/7459203317/job/20294699171?pr=4#step:8:1
Mac build: https://github.com/rainlanguage/rainix/actions/runs/7459203317/job/20294699491?pr=4#step:8:1

@thedavidmeister greetings !
can you please update commit message to match contribution

@kirillrdy hmm, doesn't github have a "squash merge" option where you can just set the commit message when you merge it?

@kirillrdy hmm, doesn't github have a "squash merge" option where you can just set the commit message when you merge it?

formatting of commit messages is what triggers CI to run the correct build jobs, we want to know that CI passed before merging.
All requirements are outlined in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

@kirillrdy ok, how's this?

squashing the commits from the github interface is usually frowned upon because it changes the commit's signature, and the contributing guide wants the signatures to be preserved.
that said, if you're short on time or this is a bit of a pain, I'm happy to squash the commits for you from the github interface.
(git rebase -i HEAD~3 , should help you squash the three commits into one).

Result of nixpkgs-review pr 279771 run on x86_64-darwin 1

1 package marked as broken and skipped:

kiwitalk

1 package built:

cargo-tauri

@happysalada all good now?

Lgtm, just waiting a bit for other people to have a chance to have a look at it too.


Add OpenAPI spec, generated client and sanitation

Purpose
Integrating the new OpenAI Finetune connector generated by the OpenAI OpenAPI contract.

Added the updated OpenAPI documentation of OpenAI
Generated the client, types, and utilities from the documentation
Added the sanitations.md for the changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


String to Complex Number conversion program added

Description
Write here what you have changed
Issue No.- #40

Type issue number after hash(#)

Checklist

[ ] Yes, this task assigned to me.
[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

Invalid PR
PR01 - Issue not Assigned.


adds support for azure single tenant

What kind of change does this PR introduce?
The goal is to add Azure single tenant support to supabase.  I wanted to get this started as it's a big blocker for utilizing supabase for internal tools through Azure.
What is the current behavior?
Currently this feature is completely unsupported : #179
What is the new behavior?
Adds tenant_id parameter to Azure oauth provider that defaults to "common". Should support the possibility for single tenancy with Azure
Additional context
This pull request is not complete as I am very inexperienced in golang and have not had time to fully flesh this out.  I was hoping this would at least help get it started!

I believe the TenantID in oauth2.Config is not needed. It's just used to build the urls:
diff --git a/api/provider/azure.go b/api/provider/azure.go
index 954bd9c..eceac6d 100644
--- a/api/provider/azure.go
+++ b/api/provider/azure.go
@@ -49,7 +49,6 @@ func NewAzureProvider(ext conf.AzureProviderConfiguration, scopes string) (OAuth
        return &azureProvider{
                Config: &oauth2.Config{
                        ClientID:     ext.ClientID,
-                       TenantID:     ext.TenantID,
                        ClientSecret: ext.Secret,
                        Endpoint: oauth2.Endpoint{
                                AuthURL:  authHost + "/" + ext.TenantID + "/oauth2/v2.0/authorize",

closing this in view of this PR getting merged


Develop

PR Details
If multiple mails were sent via one connection
only the last one was returned when calling Server.Messages()
Description
Added Handler for RSET
Related Issue
https://github.com/mocktools/go-smtp-mock/issues/101
How Has This Been Tested
See server_test.go:319
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have read the CONTRIBUTING document
[x] I have added tests to cover my changes
[x] I have run golangci-lint run from the root directory to see all new and existing tests pass
[x] I have run go tool cover to avoid test coverage degradation

Hello, @Pointer666! Thanks for attending, but this feature should be implemented more clear.


[fix][loadbalance] Fix wrong unit of NIC speed on linux

Fixes #15229
Motivation
conversion of NIC bandwidth  and tx_bytes rx_bytes is wrong on linux platform.
Modifications

For NIC bandwidth:
1,000 bit/s = 1 kbit/s (one thousand bits per second)

For tx_bytes and rx_bytes, the unit should same with NICLimit , so it should be bytes*8/1000=kbit rather than 8/1024.

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] no-need-doc
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

@mattisonchao  PTAL

Not in the scope of this PR, but related, see #15322

Hi, @gaozhangmin
This PR looks could not cherry-pick to branch-2.9, could you mind pushing the new PR to branch-2.9?

@gaozhangmin
Hi, @gaozhangmin
This PR looks could not cherry-pick to branch-2.10, could you mind pushing the new PR to branch-2.10?

@gaozhangmin Could you migrate this PR to branch-2.8?

I will cherry-pick https://github.com/apache/pulsar/pull/15770 instead.


Add support for VK_EXT_sample_locations extension

I've actually wanted to do this for a long time. It's something we need for vkd3d in order to support programmable sample positions in D3D12 apps. I've had this on the back burner, though, because of an apparent lack of demand.

Starting work on this now.

Implemented in #1566.


How can i export all records using yajra datatables?

Summary of problem or feature request
I need to export all records on click in csv button but now yajra only export record of current page. Someone can help me? @yajra
Code snippet of problem
return $this->builder()
                    ->setTableId('drcsendmoneytransac-table')
                    ->columns($this->getColumns())
                    ->minifiedAjax()
                    ->stateSave(true)
                    // ->responsive()
                    ->autoWidth(false)
                    ->parameters(['scrollX' => true])
                    ->addTableClass('align-middle table-row-dashed fs-6 gy-5')
                    ->parameters([
                        'dom'          => 'Bfrtip',
                        'buttons'      => ['excel', 'csv', 'pdf'],
                    ])
                    ->orderBy(0)
                    ->selectStyleSingle();

System details

Windows
PHP 8
Laravel 9
Laravel-Datatables 9

You need to use the server-side export buttons https://yajrabox.com/docs/laravel-datatables/10.0/buttons-starter.
You need to load the custom scripts <script src="/vendor/datatables/buttons.server-side.js"></script>

Thank you so much! 👋 👋


Get tests working after tools 2.0.1 template sync

Thanks! They were automatically added in again via the template sync here and I only realised after the markdown lint failed for having multiple headers with the same value.


[C++][Parquet] Provide API to return metadata string from FileMetadata.

we need to add a function like
FileMetaData::ToString()
this is useful when people want a string format of metadata.
If loads of file sharing the same fileMetaData, ToString will provide a binary string that stay in memory to reduce redundant metadata reding time.
Reporter: Zherui Cao / @czxrrr
Assignee: Zherui Cao](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=czxrrr) / @czxrrr
PRs and other links:

GitHub Pull Request #5481

Note: This issue was originally created as PARQUET-1664. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 5481
https://github.com/apache/arrow/pull/5481


Improve translation for russian locale

[-] I have read freeCodeCamp's contribution guidelines.
[-] My pull request has a descriptive title (not a vague title like Update index.md)
[-] My pull request targets the master branch of freeCodeCamp.
[-] None of my changes are plagiarized from another source without proper attribution.
[-] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM


BRIDGE-3150 Backfill Participant Versions

See https://github.com/Sage-Bionetworks/BridgeServer2/pull/608

Update index version.


Fix failing techdock workflow

I merged in PR #64 per this request from the Backstage foundations team and it resulted in the following failure https://github.com/liatrio/openo11y.dev/actions/runs/10616857888/job/29428294345#step:17:17
Not sure what caused the failure. But @tjvkroll said he could assist

https://github.com/liatrio/openo11y.dev/pull/74


SW-4625 Create Q4 report on December 1

Organizations need to be able to file their annual reports starting on December 1,
not starting on January 1 of the following year. Update the scheduling logic to
create the annual reports in December.

Current dependencies on/for this PR:

main

PR #1583   👈

This stack of pull requests is managed by Graphite.

Going to do a very rare (for us) non-squash merge for this one so we can deploy it as a patch release.


Config server - APPROLE authn initial token renewal.

Describe the bug
I have configured the Config Server to use Vault as backed and tried to use the authentication mechanism of APPROLE pull method. I need to renew the initial login token that has a TTL of 30 days. The token I'm using to get the role and secrete id.
I'm using spring boot 3.0.3, Java 17.
Pom.xml
              <dependency>
		<groupId>org.springframework.vault</groupId>
		<artifactId>spring-vault-core</artifactId>
	</dependency>

	<dependency>
		<groupId>org.springframework.cloud</groupId>
		<artifactId>spring-cloud-config-server</artifactId>
	</dependency>

Java config
@Override
public ClientAuthentication clientAuthentication() {
   VaultToken  initialToken = VaultToken.of(getToken());
    AppRoleAuthenticationOptions options = AppRoleAuthenticationOptions.builder()
            .appRole(vaultConfig.getAppRole())
            .roleId(AppRoleAuthenticationOptions.RoleId.pull(initialToken))
            .secretId(AppRoleAuthenticationOptions.SecretId.pull(initialToken))
            .build();
    appRoleAuthentication = new AppRoleAuthentication(options, restOperations());
      return appRoleAuthentication;
}

I want to renew this initial token. Is there a way to do that? I couldn't find any documents related to that. The vault Initial token I'm generating (getToken()) and passing to pull methods.
Note: client token return by this API  auth/approle/login renews automatically every 5 mins.

We do not have a way to rotate the initialToken. Currently, a restart is the only way to achieve rotation.


Change to Play - portraits

Clint:

we won't have pictures of most of our artists so we can't really do the portrait of them in the Play section's What's the Connection.
The name alone is a bit boring maybe so am wondering if we can keep the circle and have it expand in size based on the size of the name.
For example, it is always 1.5 ems larger than the length of the name so short names are in smaller circles and large names in bigger ones. Is that possible Rob?

It's probably possible with some custom JavaScript, but it will have to go to the back of the queue.

Closing this issue for now. Tagged with enhancement. Perhaps we can revisit.


date format issue

create a datepicker object on a page
set format to MM/DD/YYYY HH24:MI
set a default value, 12/12/2017 15:24
run page

the default date is not quite populated on the page. Strangely, if you inspect the page, and show elements, the date is set as value, but if you do $("P4_START_DATE").val(), it is empty.
Thanks, btw, this theme is great!

Bug is still here. This happens only if date format set with time. I found that after setting any datepicker widget option (like https://github.com/vincentmorneau/material-apex/blob/4dd1e938b290bd004ee46de65ae4b5d6092b6c48/src/js/materialize-init.js#L230) value of datepicker input disappear. Same in standart apex theme.
My temp workaround:
in the begin of that function https://github.com/vincentmorneau/material-apex/blob/4dd1e938b290bd004ee46de65ae4b5d6092b6c48/src/js/materialize-init.js#L181
i save datepicker values, and in the end i set them back.

@minia68 you are totally right. Can you try to implement my latest commit and see if this fixes your problem? I tried a cleaner workaround, to avoid saving and resetting the value.


feat: weather alert aggregation

:tada: This PR is included in version 1.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix decode in ws_client

fix https://github.com/kubernetes-client/python-base/issues/192

@pigletfly Can you please rebase against master to resolve the conflicts? :slightly_smiling_face:

/assign

@palnabarun rebased

/assign


Resource Bug

Hi, thanks for the new version it work well and caption futures too, just there is one error that I post it in another issue,
ok lets say current issue about this topic
https://github.com/r0oth3x49/udemy-dl/issues/17
about this problem, it is again same but now it is a little changed, there is no .txt file like before. but the same problem about lectures is still bug
lets say we have 3 chapter and 4lecture in chapter 1
chapter 1:
        lecture a:
             download file 1;
             download file 2;
             download file 3;
       lecture b:
       lecture c:
       lecture d:
chapter 2:
     .....................
chapter 3:
     ......................

with starting the program it will download only and just download file 3, and download 2 and download 1 are skipped.

@selanium which course are you downloading.

it is same, for all courses, just find a course with with more than 1x ( I mean 2, 3 , 4 ,5, ...) in one lecture only.

in this case it works perfect, and it downloads in this way, lecture a.mp4 + download file 1 + b.mp4 + download file 2 + c.mp4 + download file 3 + d.mp4 ( this one dosent have resource :D ), then jump chapter 2 and do the same, then jump chapter 3 and do the same.

chapter 1:
        lecture a:
             download file 1;
       lecture b:
             download file 2;
       lecture c:
             download file 3;
       lecture d:
chapter 2:
     .....................
chapter 3:
     ......................

but in this case not work, how it works in this case?
start chapter 1, download a.mp4 + download file 3.mp4 ( here we lost download 1 + download 2 ) + b.mp4 + download file 5 ( here we lost download file 4 )  + c.mp4 ( here we don't have any resource to download :D ) + d.mp4 + download file 6

chapter 1:
        lecture a:
             download file 1;
             download file 2;
             download file 3;
       lecture b:
             download file 4;
             download file 5;
       lecture c:
       lecture d:
             download file 6;
chapter 2:
     .....................
chapter 3:
     ......................

so every lecture with more than 1x ( 2,3,4,...) we have only the last one, so if we have 3 downloable file we can download only download file 3
if we have 4, only I can download ,download file 4
only case that it works is 1 downloadble file, so it downloads the 1 file and works well:D
I try my best to explain it well wish you understand. about the course you can test it on any course you want it is same in alls
my personal idea about this as developer ( beginner:D)
I guess we read download file1, then jump to download file 2, then download file 3 and if we have 3. we save only last one . it look like before the 3 ( 2 and 1 , are overwritten without saving )

@selanium which course are you downloading?


Odd behavior with anonymous functions

Here is an edge case I think is worth looking into
julia> using Chain

julia> x = 1
1

julia> @chain x begin
       (t -> t + 1)
       end
ERROR: LoadError: Can't prepend first arg to expression t->begin
        #= REPL[76]:2 =#
        t + 1
    end that isn't a call.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] insert_first_arg(::Expr, ::Symbol) at /home/peterwd/.julia/packages/Chain/HuSPl/src/Chain.jl:38
 [3] rewrite(::Expr, ::Symbol) at /home/peterwd/.julia/packages/Chain/HuSPl/src/Chain.jl:53
 [4] rewrite_chain_block(::Symbol, ::Expr) at /home/peterwd/.julia/packages/Chain/HuSPl/src/Chain.jl:80
 [5] @chain(::LineNumberNode, ::Module, ::Any, ::Expr) at /home/peterwd/.julia/packages/Chain/HuSPl/src/Chain.jl:113
in expression starting at REPL[76]:1

julia> @chain x begin
       (t -> t + 1)(_)
       end
2

Well the readme says there's only implicit function calling for symbols. Here you have a whole expression which, granted, is evaluated to a function. First-argument splicing only works for function calls and macros, not for arbitrary expressions. Also, why are you doing this if _ + 1 works?
And what should work I guess is making the function call explicit: (t -> t + 1)()

That sounds good!
This is fine, i will close.

Part of this is that the weirder the expressions that I allow in the macro, the harder it becomes to read, potentially. I think a single symbol is very easy to parse as a supposed function call, but your example would already be too close optically to an expression in which an underscore could hide somewhere, making it a different thing.


Update workflows

Context

Changes

Investigation details

Decisions

I wouldn't add this "validation" script either

removed.

This is also a _check_* wf

Updated.


Allow Task Name as Only Param when env vars are compatible

If

FOLIO_MIGRATION_TOOLS_TASK_NAME env var is unset
FOLIO_MIGRATION_TOOLS_CONFIGURATION PATH is set

Currently, the tool assigns the first positional arg to the config path, and chokes on no task name.
I propose in this that instead, we should just allow it to parse the arg as a task name.
This does mean that
python -m folio_migration_tools arg

Will assign arg to config_path in other circumstances, and to task_name only in this situation - a bit ambiguous - but I still feel this is the closest to desired behavior

Ready for Review.
It does revert the prompting of the positional args to the behavior before the argparse PR - in that it won't prompt for positionals - but that was simpler than the other things I tried, and shouldn't be too breaking.


The total value is concatenated but not adds

When you set
Chart.defaults.StackedBar.showTotal = true;

You can view the total when you hover the chart, something like this

The problem is the total is a concat of the numbers but not an adds, as I don't know how do a pull request I put the solution here
In the line 280 you need parse the element.value to int
total.value +=  element.value;

to
total.value +=  parseInt(element.value);

Seems like your configuration is not correct. Can you setup a jsbin/jsfiddle/codepen?

Well, maybe is my configuracion because the data array isn't In numbers, Is a string  like this
['20','40','45',etc...]

However this should be allowed


[BEAM-2316] Restore non-recursive globs in GcsUtil

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @meunierd this is what I have in mind as a quick fix, basically. I stopped short of actually parsing the glob and translating it...

Totally reasonable. This can be improved by passing delimeter=/ when there is no recursive wildcard present. Even though this code filters correctly, the API returns way more data than necessary.

Coverage decreased (-0.02%) to 70.734% when pulling 9b5167483c89423a0789658a33e51b3f5b6e8e16 on kennknowles:GcsUtil into 5e3c5c6574bc70320683d6c16fc3b11791a77418 on apache:master.

Coverage increased (+0.007%) to 70.759% when pulling 9b5167483c89423a0789658a33e51b3f5b6e8e16 on kennknowles:GcsUtil into 5e3c5c6574bc70320683d6c16fc3b11791a77418 on apache:master.

Agreed - we should do more to leverage the capabilities of filtering remotely.


Fixed Error

Fixed the footer which PR #87 messed up.
Before :

After :

@smaranjitghose Please review it.


Add Genero/DBL language

Hi,
Could you please add Genero/BDL language to your project ?
For more details about our company, please see http://4js.com/
Here the patches for languages.yml and HelloWorld sample.
BDL-sample.zip
Thanks in advance.
Best regards,
Sisa.

First of all, welcome to Linguist.
Now for the whoopsie. It looks like you may have wanted to open an issue rather than a pull request as all of the changes in this pull request have already been merged and included in Linguist and the only thing new appears to be the file you've attached to the initial note.
If you'd like to add support for the Genero/DBL language, please see the details at https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language and if you're confident enough to do this and your language has high enough usage on GitHub already (we need to see at least several hundreds of different users and repositories), please feel free to open a pull request with your changes applied to the necessary files.
As this appears to be opened in error, I'm going to close this PR.


Save Default Settings

I'd love to see the program save default settings, or have the option to save different presets of settings.
Some of my videos are recorded using a teleprompter, and others are more naturally speaking.  Both environments would have dramatically different settings to achieve the desired result, but it would be challenging to remember what those settings were.
For the command line, there could be a --savesettings PATHFILENAME and --settings PATHFILENAME and for the Windows app, those could maybe appear in a dropdown gadget or menu?
Maybe it could just be a defaults.cfg file or something that sits in the program folder, and a user could edit it or swap them with a batch file or something, even if you didn't want to implement it as an option at the command line.
Either way, the cfg file could have comments in it to clarify what the settings mean, too.

The nice thing about clis is that they don't need all need to build this feature. You can create this yourself using aliases. In MacOS, you can just edit your ~/.zshrc file and add something like export ae='auto-editor --margin 3,3
I don't remember what's the zshrc file equivalent for Windows off the top of my head but you can easily find it if you look it up.


Implement pinned register usage

@cfallin I had a question about this: what do you think is the best way to pass settings (settings::Flags) around? In this case, we'd probably want to pass them to all the transitive callers of create_reg_universe, so this can be pretty invasive...
I had another use for them in codegen too, as another example: Spidermonkey expects unpatched immediates to be all ones, and not all zeroes, for verification purposes.

Merged via rebase as 0b307fce07734bf60b6c3a972cade67af94d4d54.


Multiple Blank Pages

Hi,
I am in no way a coder, just trying to set this up.
I navigated my way through installation and came across a few issues, most of which I was able to figure out for myself.  For example the directory the xampp/MAMP needs to be set to is the dsjas-master > public not dsjas-master.
However I just came across an issue I can not seem to figure out.  I got through the installation completely, database is set up, etc.   However many pages are completely blank.
I have not made an exhaustive list but here are the few that seem to work.  If you would like me to test all pages I can do so.  Issues occur with both direct navigation (putting the file path directly into the browser) as well as navigating with links.
(*=localhost:8888/admin/)
*install - all pages load correctly
*dashboard.php - blank no error
*index.php -blank no error
*stats.php - works
*status-update.php - blank no error
*bank/ - all pages and subdirectories blank no error
*settings/mod.php - works
*settings/ext.php - shows coming soon page
*settings/advanced.php - works
*settings/editUser - blank no errors
This is probably just user error.  Let me know if there is anything I can do.  According to map I am currently running PHP 7.4.1.  I tried downgrading to 7.3.7 and the error persisted.  I have checked that I am running the proper visual studio version.  I have checked that read/write permissions are correct.
Edit: It is running on an ec2 AWS server.  Windows 2019, tc2.small.
Thanks

When you copy the repository, make sure you are not just clicking on download zip, instead grab the zip from releases section, or if you use git commands make sure to add git recursive submodules, otherwise you might have missing stuff in the hooks folder, which will cause some pages to be blank.

That worked!
Thank you for your fast response and for making such an in depth tool.

No problem. Please see #5 for a technical explanation of this problem.
By the way, status-update.php is an API endpoint and should not be directly visited in the browser - so don't panic when it still doesn't show anything useful once the site is fixed.
For any future problems, there is likely some help in the documentation. The FAQ and install guides are a good place to start.
Good luck and happy scambaiting.


Update to follow the latest WebGPU spec

This is the screenshot of the console

We should update the editor to follow the latest WebGPU spec.

Closing by #24


Web Interface Sending/Receiving siacoin, host configuration bindings, general UI fixes

This should add enough functionality to the web interface to send and receive SC. The big addition is the "Transfer Funds" view which allows a user to transfer SC from their account to an address.
Changes to how views interact with incoming data, layout tweaks etc. The host configuration view now has a warning and accurate field names.
fixes #191
helps progress on #193

you grabbed .miner.swp again


Support CMake.

Now, it can be compiled with CMake.

I've sent an alternative PR that uses a more modern CMake approach (target-based). #27


Fix darglint errors in tests

Where?
We still have some darglint errors in tests files which needs to be fixed.
Also make make darglint check in  GitHub Actions mandatory (currently we ignore errors).
How to check
Make sure you have darglint installed, do
$ darglint tests
You will see following errors

Additional Context
Make sure you complete both of the tasks 😄

[ ] Fix darglint errors.
[ ] Make darglint mandatory in GitHub Actions.

@aanurraj , regarding darglint, what I have seen is that it actually checked in GA (without ignoring errors) in modified files (ignoring test folder as well)
Later, at the end of the GA, it is again checked in src and test folder (ignoring errors in this case)

I want to try this.

@aanurraj , regarding darglint, what I have seen is that it actually checked in GA (without ignoring errors) in modified files (ignoring test folder as well)
Later, at the end of the GA, it is again checked in src and test folder (ignoring errors in this case)

Yes, @jmaunon  I had a conversation with @gmuraru  it would be better if we skip tests. Also I figured out since we have darglint in pre-commit hook, will it be necessary to have a separate action for it ? @gmuraru your views ?

@aanurraj Yep. It seems is almost duplicated. As you say I would remove the last darglint check because is already included in pre-commit

@aanurraj Yep. It seems is almost duplicated. As you say I would remove the last darglint check because is already included in pre-commit

Thanks that would work 😬

I want to try this.

Hi @dnabanita7 appreciate your help, but there is not much to do in here (initially I thought there was)  may be you can grab some other issue ?

ya.. i see..

So, should we convert this ticket to only skipping the tests from the test folder?
Also, we have darling (to block the PR) in the pre-commit, right? or should we add it there? ( @jmaunon)

Hi. Yes, I would say that the only this is needed is to remove
https://github.com/OpenMined/SyMPC/blob/7561dec407b230767b9dc517553ea77481d891e9/.github/workflows/tests.yml#L76
because is already checked (without ignoring errors) here:
https://github.com/OpenMined/SyMPC/blob/7561dec407b230767b9dc517553ea77481d891e9/.github/workflows/tests.yml#L64


Problem with raw text completion training - possible issue with flash-attn

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Same qLoRA.yaml script. Training for raw text completion for same model should still start without any issue just like 2 days ago.
Current behaviour
But after doing a git pull (c1382e7)- the training for raw text completion now trigger the following traceback just after training begins:
  0%|                                                                                | 0/18914 [00:00<?, ?it/s]Traceback (most recent call last):
  File "/home/jaredquek/Python/axolotl/scripts/finetune.py", line 54, in <module>
    fire.Fire(do_cli)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/jaredquek/Python/axolotl/scripts/finetune.py", line 50, in do_cli
    train(cfg=parsed_cfg, cli_args=parsed_cli_args, dataset_meta=dataset_meta)
  File "/home/jaredquek/Python/axolotl/src/axolotl/train.py", line 118, in train
    trainer.train(resume_from_checkpoint=resume_from_checkpoint)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 1591, in train
    return inner_training_loop(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 1892, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 2776, in training_step
    loss = self.compute_loss(model, inputs)
  File "/home/jaredquek/Python/axolotl/src/axolotl/utils/trainer.py", line 310, in compute_loss
    return super().compute_loss(model, inputs, return_outputs=return_outputs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 2801, in compute_loss
    outputs = model(**inputs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/utils/operations.py", line 636, in forward
    return model_forward(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/utils/operations.py", line 624, in __call__
    return convert_to_fp32(self.model_forward(*args, **kwargs))
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 14, in decorate_autocast
    return func(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/peft/peft_model.py", line 946, in forward
    return self.base_model(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 103, in forward
    return self.model.forward(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1034, in forward
    outputs = self.model(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 917, in forward
    layer_outputs = torch.utils.checkpoint.checkpoint(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 249, in checkpoint
    return CheckpointFunction.apply(function, preserve, *args)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/autograd/function.py", line 506, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 107, in forward
    outputs = run_function(*args)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 913, in custom_forward
    return module(*inputs, past_key_value, output_attentions, padding_mask=padding_mask)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 631, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 489, in forward
    attn_output = self._flash_attention_forward(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 526, in _flash_attention_forward
    query_states, key_states, value_states, indices_q, cu_seq_lens, max_seq_lens = self._upad_input(
  File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 562, in _upad_input
    query_layer.reshape(batch_size * kv_seq_len, num_heads, head_dim), indices_k
RuntimeError: shape '[2048, 8, 128]' is invalid for input of size 16777216

Think the problem, which never occurred before concerns the last few lines. Unfortunately even when I reverted to earlier pulls (3fbde76 HEAD@{3}: pull: Fast-forward
58cf7e7 HEAD@{4}: pull: Fast-forward) - it triggers another kind of error. This kind explicitly involving padding mask and flash-attn:
  File "/home/jaredquek/miniconda3/envs/AI/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
TypeError: flashattn_forward() got an unexpected keyword argument 'padding_mask'

Any help appreciated. Has there been some breaking change in flash-attn library?
My qlora.yml (for text completion):
base_model: /home/jaredquek/text-generation-webui/models/Olier
base_model_config: /home/jaredquek/text-generation-webui/models/Olier

model_type: LlamaForCausalLM
tokenizer_type: LlamaTokenizer
is_llama_derived_model: true

load_in_8bit: false
load_in_4bit: true
strict: false

datasets:
  - path: /home/jaredquek/Python/Olier/DataProcessing/JSONS/combinedtext.jsonl
    type: completion
dataset_prepared_path:
val_set_size: 0
output_dir: ./qlora-out

adapter: qlora
lora_model_dir:

sequence_len: 500
sample_packing: false
pad_to_sequence_len: true

lora_r: 64
lora_alpha: 32
lora_dropout: 0.05
lora_target_modules:
  - q_proj
  - v_proj
  - k_proj
  - o_proj
  - gate_proj
  - down_proj
  - up_proj
lora_target_linear: true
lora_fan_in_fan_out:

wandb_project: huggingface
wandb_entity: singaporespprtsschool
wandb_watch:
wandb_run_id: QLoraAxolotlSep30Text
wandb_log_model:

gradient_accumulation_steps: 1
micro_batch_size: 4
num_epochs: 2
optimizer: paged_adamw_32bit
lr_scheduler: cosine
learning_rate: 0.00001
train_on_inputs: false
group_by_length: false
bf16: false
fp16: true
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_steps: 500
eval_steps:
eval_table_size:
save_steps: 2000
debug:
deepspeed:
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
  bos_token: "<s>"
  eos_token: "</s>"
  unk_token: "<unk>"

Steps to reproduce
Use the above config to train a text-completion model.
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main/4d6490b
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Ok UPDATE (1 October): I tried the latest axolotl training with ShareGPT format - also got the same issue:
"  0%|                                                 | 0/48205 [00:00<?, ?it/s]Traceback (most recent call last):
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/home/jaredquek/Python/axolotl/src/axolotl/cli/train.py", line 38, in
fire.Fire(do_cli)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/home/jaredquek/Python/axolotl/src/axolotl/cli/train.py", line 34, in do_cli
train(cfg=parsed_cfg, cli_args=parsed_cli_args, dataset_meta=dataset_meta)
File "/home/jaredquek/Python/axolotl/src/axolotl/train.py", line 118, in train
trainer.train(resume_from_checkpoint=resume_from_checkpoint)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 1591, in train
return inner_training_loop(
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 1892, in _inner_training_loop
tr_loss_step = self.training_step(model, inputs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 2776, in training_step
loss = self.compute_loss(model, inputs)
File "/home/jaredquek/Python/axolotl/src/axolotl/utils/trainer.py", line 310, in compute_loss
return super().compute_loss(model, inputs, return_outputs=return_outputs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/trainer.py", line 2801, in compute_loss
outputs = model(**inputs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/utils/operations.py", line 636, in forward
return model_forward(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/utils/operations.py", line 624, in call
return convert_to_fp32(self.model_forward(*args, **kwargs))
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 14, in decorate_autocast
return func(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/peft/peft_model.py", line 946, in forward
return self.base_model(
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 103, in forward
return self.model.forward(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
output = module._old_forward(*args, **kwargs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1034, in forward
outputs = self.model(
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
output = module._old_forward(*args, **kwargs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 917, in forward
layer_outputs = torch.utils.checkpoint.checkpoint(
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 249, in checkpoint
return CheckpointFunction.apply(function, preserve, *args)
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/autograd/function.py", line 506, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 107, in forward
outputs = run_function(*args)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 913, in custom_forward
return module(*inputs, past_key_value, output_attentions, padding_mask=padding_mask)
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
output = module._old_forward(*args, **kwargs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 631, in forward
hidden_states, self_attn_weights, present_key_value = self.self_attn(
File "/home/jaredquek/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/jaredquek/miniconda3/envs/axo/lib/python3.10/site-packages/accelerate/hooks.py", line 164, in new_forward
output = module._old_forward(*args, **kwargs)
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 489, in forward
attn_output = self._flash_attention_forward(
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 526, in _flash_attention_forward
query_states, key_states, value_states, indices_q, cu_seq_lens, max_seq_lens = self._upad_input(
File "/home/jaredquek/.local/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 562, in _upad_input
query_layer.reshape(batch_size * kv_seq_len, num_heads, head_dim), indices_k
RuntimeError: shape '[2816, 8, 128]' is invalid for input of size 23068672"""

there's an off by one issue somewhere. I've seen this before. let me see if I can track down the previous issue

try deleting the tokenized dataset (simply remove the last_run_prepared folder should suffice)

Hmmm I tried deleting the last_run_prep folder and also left empty the dataset_prepared_path as u can see in the yml file on top. But to no avail. What might be causing this particular error?

May I ask if you have updated your transformer version to the latest axolotl branch?
Could you please help verify a few things?

Does enabling sample_packing fix this? Found this person having exact issue about a week ago https://discord.com/channels/1104757954588196865/1111279858136383509/1155936866005172375
Do the examples in the repo work for you as-is? It seems like the issue persist across completion and sharegpt?

I managed to fix this issue by using the Docker containers...both sharegpt and text-completion work now. So it's probably an environmental issue. Thanks for ur attention.
Just to verify - does 'sample packing' means the dataset will be shuffled?

Nice to hear it is solved.
Sample packing: uses a multipacker algorithm that efficiently packs sequences together.
Is there another issue as I noticed you reopened the Issue?

No further issue. I just wanted to ask about the sample packing. So it does not shuffle - but just pack the dataset - speeding training?

Yes, that's what it does from a general overview. For a deeper explanation, unfortunately, I do not understand the inner components myself. It would be better to join the discord for clarification :)

I have this issue, even with latest transformers (4.34.0.dev0). Enabling sample packing does make it go away, but that introduces a different issue that causes my loss to spike eventually.

Could you please provide stack trace and reproduce steps?

Huh. It works now after I (again) upgraded transformers from 0.43.0.dev0 to 0.43.0.dev0, so nevermind I guess.

Oh nice. Sometimes I would completely uninstall transformers before installing from commit. pip is sometimes finicky. Closing this since it's now solved.


Update embed code

Update the Youtube embed code to the new iframe version rather than the existing object code.

Done.


Add web UI for viewing aggregated trace data

There we go - I've cleaned up the code a bit.
Tell me if there are any issues that have to be addressed! (code style etc)
Commit message

After running the zipkin/aggregate hadoop job, dependency
links are stored in the database. This allows us to draw a
graph of the entire system.
Hovering over nodes will highlight which dependency links it has.
Clicking a node will show a list of its dependency links, and
from there you can click on a dependency to view data about the
dependency link itself. (number of calls, mean time etc)
The width of an arrow corresponds to the amount of traffic
between nodes (the number of calls made).

Sweet!
Style issue: we use two spaces for indentation.
Is there a way to populate some example data so someone could see an example of this in action?

good!

If you want to populate test data:

Configure a local Zipkin instance running on Cassandra
Run zipkin-tracegen
Run the hadoop job
Look at the web UI - traces should now be generated.

Alternatively: I'll see if I can make a modified JSON dump of our production data and host it somewhere as a static page.

OK, I (think) I fixed the indentation now.

Ok, I guess it's cumbersome to set up hadoop and everything just for some sample data, so here's an alternative.

Start Zipkin with a local MySQL instance
Dump this into the database: https://gist.github.com/eirslett/302b070cf6bff9598420
You're ready to go!

Great. Anyway to get this into the zipkin-example project? It's already possible to boot it up with the right flags set to populate it with example data. This could piggyback on that.

Yes, it would definitely be nice to dump that test data into the example project.
But I'm not quite sure how to solve the dependency links between modules: zipkin-anormdb probably shouldn't know about test data, since that's only relevant for zipkin-example. But AnormSpanStore doesn't expose a public API with "importSql" functionality, and I don't think it should? So how should we dump the data into Anorm? (Or, eventually, should we break any of the dependency barriers I mentioned?)

Hrm. Eventually we'll need some sort of API for this. For now, maybe just put the data in zipkin-tracegen along with some documentation on what to do with it.

com.twitter.zipkin.storage.Aggregates. has a storeDependencies method. I could hardcode the test data in a AggregateTestData Scala object and put that either in zipkin-example or zipkin-tracegen? Then the test data should also work independent of which database backend you're using.

I commited the SQL test dump into zipkin-tracegen for now, let me know if you want me to convert it to a Scala dump!

Okay. Pulled internally.

@sprsquish Is there any intention to pull this into the open source repo?  Seems like a really cool feature that many users could benefit from!

any update?

mental note check to see if it is indeed pulled internally

good news and bad news... good news is that OSS is synced to our internal stuff! bad news is that the build is broke, most likely due to us not using sbt to build. carrot to the one who fixes first!


cargo-about: upgrade cargo fetcher and cargoSha256

Infra upgrade as part of #79975; no functional change expected.

@grahamcofborg build cargo-about


Session expiration

Created by: @bayegan Aug 17 2021 at 18:47 CET
Last updated: Aug 17 2021 at 18:49 CET
ClickUp ID: IK-1376
To ensure that sessions have a timeout, implement expiration handling on sessions (e.g., timeout on cyphers).
Acceptance criteria:
WHEN a session is created
GIVEN a timeout period
THEN then the session will expire

Commented by: @bayegan Aug 17 2021 at 18:48 CET
@yetizer : please fill in with additional details/context, if you have.


Add files via upload

This code is necessary to process the MPRAGE data, to visualize the B1+ map for subject A (or any other), and the MPRAGE for subject B, thus   create figures 2 and 4

On it

Closing as this branch has been super-seeded by #46


Not able to run

Hi,
I'm facing a quite annoying issue, when I try to run the process I'm always getting the error:
$ grunt deploy
Running "deploy:init" task

Running "deploy:fetch" task
Warning: Cannot read property 'workspace' of undefined Use --force to continue.

Aborted due to warnings.

I'm using grunt 0.4.5 and grunt-shipit 0.4.3
My config looks like this (the one of the example):
shipit: {
  options: {
    workspace: '/tmp/github-monitor',
    deployTo: '/tmp/deploy_to',
    repositoryUrl: 'https://github.com/user/repo.git',
    ignores: ['.git', 'node_modules'],
    keepReleases: 2
  },
  staging: {
    servers<EMAIL_ADDRESS>  }
}

Any idea ? Seems that grunt.shipit.config is undefined, don't get why...
Btw, thanks for this grunt plugin that seems great :)

what was the fix??I am facing similar issue

Just had to type this command:
$ grunt shipit:TARGET deploy
// in my case
$ grunt shipit:staging deploy


PHPUnit 6

Upgrades to PHPUnit 6 for PHP 7.
PHPUnit 5.7 is retained for legacy PHP 5 support.

Coverage remained the same at 96.866% when pulling c5863c029528dec1006b65326893f8509ddbb164 on Sam-Burns:phpunit6 into a51018c1044496c6d08a817539402ea08938a3a4 on slimphp:4.x.

Coverage remained the same at 96.866% when pulling 9ea9d91fdd050a09d323756c60f6fbddfb5ba546 on Sam-Burns:phpunit6 into a51018c1044496c6d08a817539402ea08938a3a4 on slimphp:4.x.


[stable/redis-ha] Add antiAffinity rules

What this PR does / why we need it:
Adding antiAffinity rules for both redis-server and redis-sentinel pods

@nickgryg want to merge with master to fix conflicts?

/assign

@nickgryg PTAL?

@davidkarlsen I've fixed merge conflicts. Please take a look to the updated PR.

/ok-to-test

/retest

/retest

/lgtm

/retest

/retest

/test pull-charts-e2e


feat: support string parameter and force set content type header to application/json

This change is

can you please use pnpm

My mistake, package-lock.json modification removed

0.1.1 released


Re-enable clippy

Description of changes
When discussing #498 we forgot that clippy was responsible for denying unwrap() expressions. Re-enable clippy in CI so that it will continue to detect these.
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

[x] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yes. Clippy lints will be warnings, printed into the CI log and ignored by us for the most part.
Anything listed in https://github.com/cedar-policy/cedar/blob/main/.cargo/config.toml will be an error, causing the build to fail unless we add an #[allow()].


/assets/i18n/en.json NOT FOUND

I realize this is a common issue and have been scouring this repo's support tickets and Stackoverflow looking for why I can't get this working. None of the many suggestions I've tried have worked. I'm confused because my setup is simple and in no way (that I can see) different from the example code setup shared in this repo.
I'm using Angular 5.1.0 along with Angular CLI 1.7. Webpack and ngx-translate versions are as follows:
    "@ngx-translate/core": "^9.1.1",
    "@ngx-translate/http-loader": "^2.0.1",
    "webpack": "~3.8.1"

http://localhost:4200/src/assets/i18n/en.json resolves to the file correctly in the browser, so the file is in the correct location for the default configuration outlined in the ngx-translate README.
Here are the relevant files:
app.component.ts
import { ActivatedRoute } from '@angular/router';
import { Component, ElementRef, HostListener, OnInit, ViewChild, AfterViewInit, ErrorHandler } from '@angular/core';
import {TranslateService} from '@ngx-translate/core';

/*
 * Main app component that houses all views.
 */
@Component({
  selector: 'app-comp',
  templateUrl: './app.component.html'
})

export class AppComponent {

  store: any;

  constructor(private route: ActivatedRoute, private translate: TranslateService) {
    // translate.addLangs(['en', 'fr']);
    translate.setDefaultLang('en');
  }
}

app.module.ts
import { MaterialModule } from './material.module';
import { BrowserModule, Title } from '@angular/platform-browser';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateModule, TranslateLoader } from '@ngx-translate/core';
import { TranslateHttpLoader } from '@ngx-translate/http-loader';
import { HttpClient, HttpClientModule, HTTP_INTERCEPTORS } from '@angular/common/http';
import { HttpModule } from '@angular/http';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';

import { RootComponent } from './root.component';
import { AppComponent } from './app.component';
import { AppRoutingModule } from './app.routing';

import { InMemoryWebApiModule } from 'angular-in-memory-web-api';
import { InMemoryDataService } from '../db/in-memory-data.service';

import { AppInterceptor } from './_core/app.interceptor';
import { FooterComponent } from './_core/footer/footer.component';
import { HeaderComponent } from './_core/header/header.component';
import { DataService } from './_core/data.service';
import { DataResolver } from './_core/data.resolver';

import { environment } from '../environments/environment';
import { AppGuard } from './app.guard';

import { MessageService } from './message.service';
import { GatewayService } from './shared/gateway.service';
import { WindowRefService } from './window-ref.service';

/*
* Main module for the app that boostraps everything.
*/
@NgModule({
    imports: [
        BrowserModule,
        HttpClientModule,
        TranslateModule.forRoot({
          loader: {
            provide: TranslateLoader,
            useFactory: HttpLoaderFactory,
            deps: [HttpClient]
          }
        }),
        HttpModule,
        FormsModule,
        AppRoutingModule,
        BrowserAnimationsModule,
        InMemoryWebApiModule.forRoot(InMemoryDataService, { dataEncapsulation: false }) // Remove to use real HTTP calls
    ],
    declarations: [
        RootComponent,
        HeaderComponent,
        AppComponent,
        FooterComponent
    ],
    providers: [
        AppGuard,
        DataService,
        DataResolver,
        MessageService,
        GatewayService,

        WindowRefService,
        {
            provide: HTTP_INTERCEPTORS,
            useClass: AppInterceptor,
            multi: true,
        }
    ],
    bootstrap: [RootComponent]
})

export class AppModule { }

// required for AOT compilation
export function HttpLoaderFactory(http: HttpClient) {
    return new TranslateHttpLoader(http);
}

I've tried all the common solutions, including using the CopyWebpackPlugin to try to resolve the webpack bundling, adding the i18n directory to the assets list in angular-cli.json, and explicitly passing my path to TranslateHttpLoader like so:
return new TranslateHttpLoader(http, "./assets/i18n/", ".json");
None of these approaches have worked.
Is there something very basic I'm missing in my setup? I feel like I've just been looking at it too long at this point. :/

Check your angular cli configuration, I'm pretty sure the mistake comes from here.
You can look in apps > prefix and add its value before ./assets/i18n/.

if you are using the cli, you may need to include it in the paths folder in angular-cli.json

@ellenchristine  in your angular-cli the prefix and assets should refer to the paths as shown below.
"assets": [
        "assets",
        "favicon.png"
      ],
 "prefix": "app"

Then refer it like this in your root module
export function createTranslateLoader(http: HttpClient) {
  return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}

I had the same problem the InMemoryDataService intercepts your requests to the real server.
You can set passThruUnknownUrl: true like this:
InMemoryDataService, {dataEncapsulation: false, passThruUnknownUrl: true}

I also had this issue using webpack 4. It turned out that json files had to be copied to the dist folder along with the rest of the compilation, so I used copy-webpack-plugin for that. In my webpack config:
const CopyWebpackPlugin = require('copy-webpack-plugin');
...
  plugins: [
    new CopyWebpackPlugin([
      { from: helpers.root('src'), to: helpers.root('dist') }
    ]),
  ],

It solved the problem and json files are loaded correctly now. At least when using dev server...

I have the same Problem. With Angular Version 6.
But there isn't a angular-cli.json File. So I add the path in the angualr.json
  "projects": {     "navigatorWebClient": {       "root": "",       "sourceRoot": "src",       "projectType": "application",       "prefix": "gue",       "schematics": {         "@schematics/angular:component": {           "styleext": "scss"         }       },       "architect": {         "build": {           "builder": "@angular-devkit/build-angular:browser",           "options": {             "outputPath": "dist/navigatorWebClient",             "index": "src/index.html",             "main": "src/main.ts",             "polyfills": "src/polyfills.ts",             "tsConfig": "src/tsconfig.app.json",             "assets": [               "src/favicon.ico",               "src/assets",               "src/assets/i18n"             ],             "styles": [               "src/styles.scss"             ],             "scripts": []           },
But the Error isn't disappear
My ngx-translate-Version is
"@ngx-translate/core": "^10.0.2",
"@ngx-translate/http-loader": "^3.0.1",

best regards
McGurk

I had the same problem, the InMemoryDataService intercepts your requests to the real server.
To fix this you can set passThruUnknownUrl: true like this:
InMemoryDataService, {dataEncapsulation: false, passThruUnknownUrl: true}

Worked for me, if I disabled InMemoryDataService would work but not when enabled so the passThruUnknownUrl config property did the trick.

I had the same problem, the InMemoryDataService intercepts your requests to the real server.
To fix this you can set passThruUnknownUrl: true like this:
InMemoryDataService, {dataEncapsulation: false, passThruUnknownUrl: true}
It works

try this 2 option..
export const environment = {
production: true,
appRootPrefix: '/<>'
};
export function createTranslateLoader(http: HttpClient) {
return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}

Worked for me too.
return new TranslateHttpLoader(http, "/BASEHREF/assests/i18n", ".json");

@pookdeveloper thanks, worked for me

I had the same problem, Is there any way to solve it now

Worked for me too.
return new TranslateHttpLoader(http, "/BASEHREF/assests/i18n", ".json");

@Aprajita-96 How did you solve it

At the moment, the only thing that worked for me is to change the .json extension of the files to .txt. Then put this in the
module:
export function httpTranslateLoader(http: HttpClient) {
  return new TranslateHttpLoader(http, "./assets/i18n/", ".txt");
}

If I tried to enter the url of the json file in the browser, it didn't work, now if i try this with the txt file in the same folder it works. So the .json file are intercepted. I have a MSAL http interceptor which I cannot just remove.
Its not the best solution, but it works, if I can find a better way, I would love to. Now after each deploy to production, I need to copy these translation files to txt.

I spent few hours to figure this issue out, but it finally works. Want to share it, hope this will fix your issue as well.
step 1: added below code in the src folder -> web.config file:          [src/web.config]

Example of src/Web.config file:

    <!-- for mutil-language to get static json files from assets i18n folder -->
     ****<staticContent>
        <mimeMap fileExtension=".json" mimeType="application/json" />
    </staticContent>****

</system.webServer>

step 2: In the app.module.ts, added the below code
// The TranslateHttpLoader uses HttpClient to load translations, which means that you have to import the HttpClientModule from @angular/common/http before the TranslateModule:
// import TranslateModule and execute the translateHttpLoaderFactory function
export function HttpLoaderFactory(http: HttpClient) {
return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}
step 3: add "src/web.config" and "src/assets/i18n" under in the angular.json file
the path is "projects" => "Project Name" => "architect" => "build" => "options" => "assets" => "src/assets/i18n" and "src/web.config"

I had this problem after building using ng build --prod --base-href=/itai-ui/
I ended using a similar solution to @mderaeve , saving the i18n folder path in my environment.ts and enviornment.ts.prod files. This is my loader at app.module.ts
export function HttpLoaderFactory(http: HttpClient) {
  return new TranslateHttpLoader(http, environment.I18N_FOLDER, ".json");
}

I hope this helps

I have same error  but didn't get any solution , I am using angular 10 and my ngx-translate version is
"@ngx-translate/core": "^11.0.1",
"@ngx-translate/http-loader": "^4.0.0",
And I have already made export function of httpLoaderFactory(),  after then having error . Because of that I am not  able to have object value. If anyone has any idea, plz suggest here

Worked for me. readFileSync(dist/test-seo-project/browser/assets/i18n/${lang}.json, 'utf8')));

I have same problem in angular 10 (SSR). I use MultiTranslateHttpLoader and when project running in ssr "Could not find translation file: assets/i18n/en.json

After hours of searching and useless tries I decided to write custom loader that loads JSON files by dynamic import:
export default class LanguageLoader implements TranslateLoader {
  public getTranslation(language: string): Observable<{ [key: string]: string }> {
    return from(import('./i18n/' + language + '.json'));
  }
}

Then in AppModule:
TranslateModule.forRoot({
      defaultLanguage: 'en',
      loader: {
        provide: TranslateLoader,
        useClass: LanguageLoader,
      },
    }),

That's all, i18n files loads as modules, not by HTTP, @ngx-translate/http-loader can be removed from dependencies.
Don't forget to add "resolveJsonModule": true in tsconfig.json, or if you want to use ts\js file instead of json, move object with translations into it and export this object by default, than use: return from(import('./i18n/' + language)).pipe(pluck('default')); or some other logic that depends of your situation.

After hours of searching and useless tries I decided to write custom loader that loads JSON files by dynamic import:
export default class LanguageLoader implements TranslateLoader {
  public getTranslation(language: string): Observable<{ [key: string]: string }> {
    return from(import('./i18n/' + language + '.json'));
  }
}

Then in AppModule:
TranslateModule.forRoot({
      defaultLanguage: 'en',
      loader: {
        provide: TranslateLoader,
        useClass: LanguageLoader,
      },
    }),

That's all, i18n files loads as modules, not by HTTP, @ngx-translate/http-loader can be removed from dependencies.
Don't forget to add "resolveJsonModule": true in tsconfig.json, or if you want to use ts\js file instead of json, move object with translations into it and export this object by default, than use: return from(import('./i18n/' + language)).pipe(pluck('default')); or some other logic that depends of your situation.

Hi, i tried your method but iam getting this error "./src/app/app.module.ts:20:16-54 - Error: Module not found: Error: Can't resolve './i18n'" am i missing some step? I didn't understand what you mean by "return from(import('./i18n/' + language)).pipe(pluck('default'));", thanks!

I had the same problem, the InMemoryDataService intercepts your requests to the real server. To fix this you can set passThruUnknownUrl: true like this: InMemoryDataService, {dataEncapsulation: false, passThruUnknownUrl: true}

worked for me thanks!!


[core] Support redirecting TraceLog to custom logging system

As a user, I'd like to have full control of the logging system. e.g. I may want to log in both console and file. Or use my own format with timestamp, thread id, etc.
At the moment, TraceLog simply logs the msgType (aka INFO, ERROR, etc) + the text. While I could implement my own logging system for my stuff, raylib would still output everything just to the console. I'd like to sink everything raylib has to say into my own logging mechanism.
To do such thing, the easiest way I can think is using a callback (if previously set) that TraceLog calls instead of using its own implementation.
I have created a possible solution in ~15LOC in utils.c. The usage from the user point of view would be as follows:
void logCustom(int msgType, const char *text, ...)
{
    va_list args;
    va_start(args, text);
    vprintf(text, args);
    printf("\n");
    va_end(args);
}

 int main()
 {
    SetTraceLogCallback(logCustom);
...

Just for reference, I've checked current Android log data redirection... it just uses Android log system, but this system does not offer any redirection mechanism like the proposed one...
My main concern was callback usage... but I imagine it's ok... any opinions in the room?

To do such thing, the easiest way I can think is using a callback (if previously set) that TraceLog calls instead of using its own implementation.

Sounds good to me.

Closed with #597.

thanks, I still want ti review some formating details on the PR...

Ah, sorry for the premature merge...

hahaha... no worries! :D


Question about paper

Quick question -- is the code in python_examples/example_full_softmax.py the code that you used to produce Fig 5 in the paper?

Yes!


Refactor/manual rubocop fixes part1

Description
Attempt to start fixing some more complex things. Likely to break things
Type of change
Please delete options that are not relevant.

Refactoring (improvements to code design or tooling that don't change behaviour)
Breaking change (will cause existing functionality to not
work as expected) Maybeeeeeee

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request. - TODO
Note to other contributors
If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

[ ] Tests have been added for any changes to behaviour of the code
[ ] New and existing tests are passing locally and on CI
[ ] bundle exec rubocop reports no offenses
[ ] RDoc comments have been updated
[ ] CHANGELOG.md has been updated

Hi @mattwynne
I've edited a few lib/ files here and It got quite confusing, so for a lot of it I opted to do as little as possible given I don't know an awful lot about the areas. If you could review each of those it would be greatly appreciated.

There's a lot here to review @luke-hill! I'd say if the tests are passing you're probably good.
Was there anything specific you want me to look at in detail?


Adding network error check

Proposed changes
Currently, SSO extension returns a network error but we prompt for interaction required. When MSAL doesn't have RT, it returns that interaction required instead of network unavailable in this case. ADO item
In addition if there is a network error, we do not want to continue to fallback controllers of broker or local controller. Therefore this change adds a check before returning to fallback controller if there is a no network error.
Type of change

[ ] Feature work
[X] Bug fix
[ ] Documentation
[ ] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[X] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Adding a flakiness UTs fix

@fidelianawar @hieunguyenmsft, merge from dev to fix the pipeline [MSAL] Common core submodule update check error (Vision Framework Failed)

@fidelianawar Change looks good, can you please also create a manual test case for this release? Thanks!


Sort hover results in tests

I can add back the space after dyn, but the positioning of that brace makes no sense to me.

bors r+


Containers output files as the local user

Testing this commit:
Running 'make' should be sufficient. This will run the deps_to_ninja
and get_fundamental_packages containers, although the second one
doesn't do anything yet.
After running make, the 'output' directory should be created; that
directory, and all its descendants, should be owned by your user and
groupowned by your primary group. It is an error for this directory to
be owned by root.
Commit details:
This commit prepares for the inclusion of the get_fundamental_packages
scripts. Containers need to interact with each other and with the
local environment, so the files that they generate cannot be owned by
root. This commit ensures that containers run their runtime commands
as an unprivileged user with the same user and group name and IDs as
you.
Dockerfiles are now generated from Dockerfile.mk in each directory,
since they need to have user and group information sed-ed in on your
local machine.

This PR needs to be rebased on top of master.

lgtm


Pacific Collegiate School

@Norok-The-Diablo First stage of verification passed, official domain is pacificcollegiate.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.pacificcollegiate.com/apps/pages/lunch

Thanks, excited for a reply!

@Norok-The-Diablo Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Automation component to not use platform logic

Description:
This is a WIP.
Migrate automation integration away from abusing the PLATFORM_SCHEMA, as it doesn't actually use platforms. This has a downside that I did not initially consider: for platforms, if a single platform is invalid, we still set up the component with the other platform logic present. To mimic this in the automation component, we have two choices:

Add the automation validation logic in CONFIG_SCHEMA. This means that check_config will pick it up and config validation will report the invalid config correctly. However, it means that no automations will load when a single automation contains invalid config.
Do the validation logic in _async_process_config (as is this PR). Downside is that check_config no longer works.

I think that we should consider adding a new type of schema, to indicate that an integration is platform like, but that we should not load platforms. But then, maybe we just end up at what we have now? 🤷♂
Related issue (if applicable): fixes #23080
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly (example).
[ ] New dependencies have been added to requirements in the manifest (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

This is not it, we will end up with the original setup, so let's keep it like this.


Can this package upgrade OTA to device directly

Sry,I'm not good at bluetooth.I'd like to ask ‘Can this package upgrade OTA to device directly’.Does it mean that write something to device.Example write instructions to device and make device ready and write ota config file to device. Thank you very much for your answer!

The library doesn't have anything specifically related to OTA; but with that said the functionality you've described:

write instructions to device (supported)
write OTA config file to device (may required a custom DeviceConnection to write binary data, but supported)

It would be interesting to see how you make out with this, but I believe the library contains the building blocks you'd need to get started.
I'm always open to PR that might add functionality to make this work.

The library doesn't have anything specifically related to OTA; but with that said the functionality you've described:

write instructions to device (supported)
write OTA config file to device (may required a custom DeviceConnection to write binary data, but supported)

It would be interesting to see how you make out with this, but I believe the library contains the building blocks you'd need to get started.
I'm always open to PR that might add functionality to make this work.

Thanks!
You mean it provides all the basic functions of Bluetooth, and I need to compose it to realize OTA

Thanks!
You mean it provides all the basic functions of Bluetooth, and I need to compose it to realize OTA

It should, I don't see why not.
The standard functionality provides text based writing (configurable encoding):

This should let you write instructions to the device

There are issues/docs on how to create a DeviceConnection for transfering binary data:

This should let you save a file once you've used the correct command

You'll need to review your device functionality, and see what is required in the form of data format, but the base functionality should all be there.
Feel free to open any issues/PRs along the way so that we can get it happening.
Just remember, I don't want to pull in any other Connectors, Acceptors or Connections.   I'd like to keep the base library as small as possible for the most generic purposes (ie. mine).   But we can definitely add as much documentation/samples as possible to describe how to replicate.

It should, I don't see why not.
The standard functionality provides text based writing (configurable encoding):

This should let you write instructions to the device

There are issues/docs on how to create a DeviceConnection for transfering binary data:

This should let you save a file once you've used the correct command

You'll need to review your device functionality, and see what is required in the form of data format, but the base functionality should all be there.
Feel free to open any issues/PRs along the way so that we can get it happening.
Just remember, I don't want to pull in any other Connectors, Acceptors or Connections.   I'd like to keep the base library as small as possible for the most generic purposes (ie. mine).   But we can definitely add as much documentation/samples as possible to describe how to replicate.

Well, thanks a lot for your timely reply.
I try it.

Well, thanks a lot for your timely reply.
I try it.

Closing - as this isn't so much to do with the library, but more the custom device/application logic.  If a specific example can be provided and replicated we can look at adding functionality.

Closing - as this isn't so much to do with the library, but more the custom device/application logic.  If a specific example can be provided and replicated we can look at adding functionality.


flutter create -a kotlin  still generate java code

Steps to Reproduce
flutter version
Flutter 0.10.0 • channel dev • https://github.com/flutter/flutter.git
Framework • revision d954ae6850 (8 days ago) • 2018-10-09 16:21:06 -0400
Engine • revision bf377896ff
Tools • Dart 2.1.0-dev.6.0.flutter-a50dfd6698

issue command
flutter create -i swift -a kotlin projectA

the projectA contains Java version of Android code and ObjC version of iOS code.
Logs

flutter doctor -v
[√] Flutter (Channel dev, v0.10.0, on Microsoft Windows [Version 10.0.17134.345], locale en-US)
    • Flutter version 0.10.0 at C:\Users\leagm\Applications\flutter
    • Framework revision d954ae6850 (8 days ago), 2018-10-09 16:21:06 -0400
    • Engine revision bf377896ff
    • Dart version 2.1.0-dev.6.0.flutter-a50dfd6698

[!] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at C:\Users\leagm\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    X Android license status unknown.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 29.1.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] VS Code (version 1.28.1)
    • VS Code at C:\Users\leagm\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 2.19.0

[√] VS Code, 64-bit edition (version 1.28.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 2.19.0

[√] Connected device (1 available)
    • MIX 2 • <IP_ADDRESS>:5555 • android-arm64 • Android 8.0.0 (API 26)

! Doctor found issues in 1 category.

I think this has been fixed and can be closed, using current stable Flutter v1.2.1 running flutter create -a kotlin projk produces:
 projk/android/app/src/main/kotlin/com/example/projk/MainActivity.kt (created)
as expected.

The GeneratedPluginRegistrant files are still in java and Objective-C but that's by design.
Are you still seeing this in a recent Flutter build?


TN-1163 cleanup and py3 compatibility for test_scheduled_job.py

Hello @John0Randolph! Thanks for submitting the PR.

In the file tests/test_scheduled_job.py, following are the PEP8 issues :

Line 64:40: E222 multiple spaces after operator


GH-34303: [CI][Packaging][deb] Use system Meson on Debian GNU/Linux bookworm

Rationale for this change
"pip3 install meson" isn't accepted on Debian GNU/Linux bookworm.
What changes are included in this PR?
System Meson is recent engouh.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #34303

@github-actions crossbow submit debian-bookworm-*

+1


Approximate DBSCAN perf fix

Turns out I didn't compare benchmarks in my previous PR (#178) and introduced a massive perf regression. The issue was with a faulty range query distance parameter for calculating neighbour cells. The distance was set incorrectly in previous implementations and interacted badly with linfa-nn, leading to sky-high runtimes despite correct results. The issue has been fixed and now Approximate DBSCAN runs faster than before the linfa-nn integration, although it's still slower than normal DBSCAN.
Pre-linfa-nn benchmarks:
appx_dbscan/appx_dbscan/10
                        time:   [589.38 us 590.73 us 592.31 us]
                        change: [-3.6668% -2.9207% -2.1162%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  1 (1.00%) low severe
  5 (5.00%) high mild
  9 (9.00%) high severe
appx_dbscan/appx_dbscan/100
                        time:   [6.5295 ms 6.5613 ms 6.6008 ms]
                        change: [-1.9789% -1.2880% -0.5680%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) high mild
  1 (1.00%) high severe
Benchmarking appx_dbscan/appx_dbscan/1000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.1s, or reduce sample count to 50.
appx_dbscan/appx_dbscan/1000
                        time:   [90.272 ms 90.557 ms 90.885 ms]
                        change: [+78.299% +79.153% +79.922%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

Benchmarks for this branch:
appx_dbscan/appx_dbscan/10
                        time:   [44.176 us 44.398 us 44.629 us]
                        change: [-92.588% -92.524% -92.464%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) high mild
  2 (2.00%) high severe
Benchmarking appx_dbscan/appx_dbscan/100: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.3s, enable flat sampling, or reduce sample count to 60.
appx_dbscan/appx_dbscan/100
                        time:   [1.0550 ms 1.0857 ms 1.1291 ms]
                        change: [-83.856% -83.575% -83.231%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) high mild
  4 (4.00%) high severe
Benchmarking appx_dbscan/appx_dbscan/1000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.3s, or reduce sample count to 90.
appx_dbscan/appx_dbscan/1000
                        time:   [52.594 ms 52.781 ms 52.976 ms]
                        change: [-42.001% -41.715% -41.441%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Benchmarks in current master are complete garbage (my bad), so I won't show them.

Codecov Report

Merging #184 (0ca812b) into master (375209c) will decrease coverage by 0.08%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   58.42%   58.33%   -0.09%
==========================================
  Files          91       91
  Lines        8038     8033       -5
==========================================
- Hits         4696     4686      -10
- Misses       3342     3347       +5

Impacted Files
Coverage Δ

...ms/linfa-clustering/src/appx_dbscan/hyperparams.rs
7.89% <0.00%> (ø)

...gorithms/linfa-clustering/src/appx_dbscan/tests.rs
80.64% <88.88%> (-5.36%)
:arrow_down:

...linfa-clustering/src/appx_dbscan/cells_grid/mod.rs
47.36% <100.00%> (-1.76%)
:arrow_down:

...nfa-clustering/src/appx_dbscan/cells_grid/tests.rs
100.00% <100.00%> (ø)

algorithms/linfa-clustering/src/utils.rs
100.00% <100.00%> (ø)

algorithms/linfa-clustering/src/k_means/init.rs
86.17% <0.00%> (-6.23%)
:arrow_down:

...infa-clustering/src/appx_dbscan/cells_grid/cell.rs
50.00% <0.00%> (-1.62%)
:arrow_down:

...lgorithms/linfa-clustering/src/optics/algorithm.rs
51.17% <0.00%> (+1.77%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375209c...0ca812b. Read the comment docs.

Everything looks good! Happy to have someone else take a look as well, though, if you'd prefer

Since it's a regression fix I want to merge it sooner than later. As long as I didn't mess something up again it should be fine (and if it's not then people can just use normal DBSCAN). I will wait till end of this weekend to merge.


Battle ship

Port of battleship transaction family from 0.7 to 0.8.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Ryan Banks:x: RyanLassigBanksRyan Banks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Need to clean up git commits and add tests


Possible to make this a ReactiveVar extension?

I have not tried the package yet, but it looks great and I wonder if it could be made a ReactiveVar extension:
var foobar = new ReactiveVar(function () {
  var sum = 0;
  collection.find({}, {fields: {value: 1}}).forEach(function (doc) {
    sum += doc.value;
  });
  return sum;
});

// Get the value
console.log(foobar.get());

// Set the value until next reactive computation
// (probably not so useful, but coherent with ReactiveVar semantic)
console.log(foobar.set(33));

Couldn't this even be made part of the ReactiveVar package?

In fact this is part of my recent pair of packages where I gave up on ReactiveVar and created ReactiveField. :-)

And while doing this package, @retronator already asked why I do not just make ReactiveField behave like this package, if you pass a function in. I like clear separation of things. I do not see any benefit in overloading. That something behaves so much  differently if you pass a function or if you pass a value in.
Also, ReactiveField has both a getter and setter, while this one has only a getter.
And I would like a theoretical use of being able to store functions into a ReactiveField.


Loc compact T2 with countable network are 2nd countable

New theorem: Countable network + weakly locally compact + T2 ==> second countable.

I have read (theorem 2 in this post) that if a space X is locally compact, then n w ( X ) = w ( X ) . Maybe we could add it too.
Locally compact+Has a countable network+~Second countable
Weakly locally compact+Has a countable network+~Second countable

Engelking assume Hausdorff.  Dan Ma often assumes Hausdorff as well.  Are you saying that Theorem 2 in Dan Ma's blog is proved with locally compact without Hausdorff?  (That would indeed be a strengthening of the result.)

I have read (theorem 2 in this post) that if a space X is locally compact, then n w ( X ) = w ( X ) . Maybe we could add it too.
Locally compact+Has a countable network+~Second countable
Weakly locally compact+Has a countable network+~Second countable

Engelking assume Hausdorff. Dan Ma often assumes Hausdorff as well. Are you saying that Theorem 2 in Dan Ma's blog is proved with locally compact without Hausdorff? (That would indeed be a strengthening of the result.)

Hmm... Now, I am unsure.

The proofs in the two references make essential use of the Hausdorff condition.  So we should check in detail what the proof from Dan Ma's blog assumes.

The proofs in the two references make essential use of the Hausdorff condition. So we should check in detail what the proof from Dan Ma's blog assumes.

The proof of claim 3 cites a result from the previous post, where he mentions that the spaces are $T_2$. Also, reading how he was using locally compactness, it seems that he was using it as weakly locally compactness instead (anyways weakly locally compact + $T_2$ implies locally compact), which would be this PR already.

Coincidently, in that previous post, he also mentions a result (Compact + $T_2$ + Has a countable network $\Rightarrow$ metrizable) that wasn't in $\pi$-Base before, but it is deduced with the theorem T534 now.

The proofs in the two references make essential use of the Hausdorff condition. So we should check in detail what the proof from Dan Ma's blog assumes.

I think that he assumes the Hausdorff condition. The proof of claim 3 cites a result from the previous post, where **he mentions that the spaces are T 2 ** (he actually mentions T 3 , but T 2 compact spaces are T 3 ). Also, reading how he was using locally compactness, it seems that he was using it as weakly locally compactness instead (anyways weakly locally compact + T 2 implies locally compact), which would be this PR already.

Actually he uses the Hausdorff condition in an essential way in the proof of Lemma 1 of the previous post, to show item 5 (compact Hausdorff spaces have the same network weight and weight).  That's basically the same proof as in the refs from this PR.

Yeah. By the way, I apologize for my previous misinformation.

Please, no need to apologize for anything.  We are all learning here and these discussions are very useful to explore variations and improvements, and to clear misunderstandings and reinforce concepts, for all of us!

Thank you so much. Wise words, Patrick.

Noting examples at https://topology.pi-base.org/spaces?q=weakly+Locally+compact%2BHas+a+countable+network%2B~Second+countable and (currently) empty search at https://topology.pi-base.org/spaces?q=T_2%2Bweakly+Locally+compact%2BHas+a+countable+network%2B~Second+countable