B-20291: Customer "Review your request" Page Errors

Agility ticket
Summary
Milmove would crash if a customer tried to Review their request after their move has been approved. This was happening because in src/components/Customer/Review/Summary/Summary.jsx at line 410, currentDutyLocation.name is being referenced. This is an issue because in the same file at line 306 "currentDutyLocation" is being set based on orders?.origin_duty_location?.transportation_office the "origin duty location" having a transportation office. If there is a transportation office then currentDutyLocation is not null but if there isnt then currentDutyLocation is null which makes currentDutyLocation.name fail.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the MilMove as customer and create a move using a duty location that does not have a Transportation Office OR use a move that already has this circumstance
Login to OFFICE as a TOO and approve the move
Go back to the MilMove customer and select Review your Request

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against c48fa91482f744b34d7afcf1bb74e194a9edfef0

Bumping this, heads up it's still in draft mode @TevinAdams


Move findAncestorRenderObjectWrapper to RenderObjectWrapper

That way it's closer to where it's used, and it's more obvious that
anyone can write such functions.

LGTM


Updated August release-notes.md

@v-haripkmsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @v-haripkmsft - Would you make this content update in the private repo? We'll close this PR. Thanks.


BigQuery return timestamp field as exponential

This is the result from the time field in the BigQuery dataset instead of some thing like this

Is there something I'm missing ?

@debopamsengupta did you mean to close?

Well, found a workaround as the exponential can be converted into a Unix timestamp.
But it would be good to just receive the string from BigQuery

I agree! Which API call is the time field returned in?

https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.25.1/bigquery?method=query returns the time field

I can't find that property being returned in the raw API response (https://cloud.google.com/bigquery/docs/reference/v2/jobs/query)
Is this your own data? It looks like we could convert to a Date object if we see the matching schema type for a returned property is "TIMESTAMP".

Well this is the schema for the table, and the schema type for the field time`` is TIMESTAMP```

Got it, thanks. Sorry for all the questions, just wanted to make sure I understood. I think we can sniff out when we are returning these types and convert them to the format that makes sense. Thanks for calling this out!

Thanks, no problem !

Hey guys, any chance we can continue the old behavior by passing a special parameter? That is, what if I really just want the raw data? Can I ask for raw (un-schema-parsed) results? /cc @callmehiphop

The raw data will still come through in the apiResponse parameter:
table.query('SELECT * FROM ...', function(err, rows, nextQuery, apiResponse) {
  // apiResponse:
  {
    "schema": {
      "fields": [
        {
          "name": "url",
          "type": "STRING",
          "mode": "NULLABLE"
        }
      ]
    },
    "rows": [
      {
        "f": [
          {
            "v": "https://github.com/jfeaver/hireme"
          }
        ]
      }
    ]
  }
});

OK cool :)
Where do we document the full apiResponse object? Do we link back to the
BigQuery page that defines the schema of that object?

It's a bit of a click-hunt, but if you get to the bigQuery#query docs, the last link on the page ("Jobs: query API Documentation" under the "More information" section) takes you to https://cloud.google.com/bigquery/docs/reference/v2/jobs/query which shows the response body.
I'll open a new issue for making the apiResponse callback parameter linkable directly to the response body. For now, I made a small note in the release notes about the raw response.

Oh that's a great idea. Maybe all our apiResponse parameters could point to
the API page on cloud.google.com?

Yeah, I think that'd be awesome! Issue opened: #1007


Debug Restart option requires a manual focus shift

Issue Type: Bug

Set up the vscode-mock-debug sample and run it.
Begin stepping through readme.md example "code" using Step Over button on debug toolbar.
After a step or two, click the Restart button on that toolbar.
The debug toolbar disappears. It is necessary to change focus (e.g. click onto body of the open readme.md file, or onto a different application) in order to make debugging start and the debug toolbar reappear.

VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.15063
Also happens on latest 1.29 Insider.

Try setting EMBED_DEBUG_ADAPTER = true and then launching the Extension debug config of vscode-mock-debug per the instructions at https://code.visualstudio.com/docs/extensions/example-debuggers#_alternative-approach-to-develop-a-debug-extension
When I flip EMBED_DEBUG_ADAPTER to false I no longer get the problem.

I do not plan to fix this. Closing


more timestamps in stageout code

Hi,
You can see here:
http://cms-project-relval.web.cern.ch/cms-project-relval/forELOG25Sep2014/
an example of a job that seems to have taken 15 hours to stage out its log file and its root file. However,
there are not enough timestamps printed out in the stage out code to have any idea what the problem.
Can the developers please add more timestamps e.g. at least one here immediately before and after each stage out.
Thanks.
Andrew

The stage out code has much more timestamp now (since 2015). So I'm closing this issue


Protocompiler does not build

Grab latest master (up until this commit)
Using vs2017 RC 1, make sure you have .NET Desktop with F# checked, C++ Desktop, and VS Extensibility Workloads installed
open VS Developer command prompt in admin mode
run build.cmd vs

Build FAILED.

"C:\Users\Phillip Carter\repos\visualfsharp\src\fsharp-proto-build.proj" (default target) (1) ->
"C:\Users\Phillip Carter\repos\visualfsharp\src\fsharp\FSharp.Compiler-proto\FSharp.Compiler-proto.fsproj" (Build targe
t) (3) ->
(CallFsLex target) ->
  C:\Users\Phillip Carter\repos\visualfsharp\packages\FsLexYacc.7.0.1\build\FsLexYacc.targets(34,3): error MSB3073: The
 command "C:\Users\Phillip Carter\repos\visualfsharp\src\fsharp\FSharp.Compiler-proto\..\..\..\packages\FsLexYacc.7.0.1
\build\fslex.exe  -o "pplex.fs" --unicode --lexlib Internal.Utilities.Text.Lexing ..\pplex.fsl" exited with code 9009.
[C:\Users\Phillip Carter\repos\visualfsharp\src\fsharp\FSharp.Compiler-proto\FSharp.Compiler-proto.fsproj]

Code 9009 is file not found, and I noticed that pplex.fsl does not exist on my machine.

From: http://stackoverflow.com/questions/1351830/what-does-exited-with-code-9009-mean-during-this-build
It may be because your path has a space in it. Perhaps try in a different location.

Thanks @JoshVarty, that seemed to work.  I'll create a PR to add a note to the DEVGUIDE that the path cannot have a space in it.

How about fixing that thing that checks the path to accept spaces?
Am 29.11.2016 2:03 vorm. schrieb "Phillip Carter"<EMAIL_ADDRESS>
:

Closed #1880 https://github.com/Microsoft/visualfsharp/issues/1880.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/1880#event-874541348,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgNBLXrIHB5QkAiF4JzueYf4y83ot_ks5rC3nugaJpZM4K-aMH
.

@forki Not familiar with the build scripts, but it seems to just be invoking msbuild on the project: https://github.com/Microsoft/visualfsharp/blob/master/build.cmd#L488
Quick google search suggests using \\ to specify paths, otherwise msbuild won't accept the path.  Not sure what a good solution here is for the build script, but I'm inclined to think that it would involve a string replace up top and percolating the replaced path string throughout the script.

Didn't @dsyme just fix it? Or was this another thing?
Am 29.11.2016 6:45 nachm. schrieb "Phillip Carter"<EMAIL_ADDRESS>
:

@forki https://github.com/forki Not familiar with the build scripts,
but it seems to just be invoking msbuild on the project:
https://github.com/Microsoft/visualfsharp/blob/master/build.cmd#L488
Quick google search suggests using \ to specify paths, otherwise msbuild
won't accept the path. Not sure what a good solution here is for the build
script, but I'm inclined to think that it would involve a string replace up
top and percolating the replaced path string throughout the script.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/1880#issuecomment-263643611,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNGtVDf_JbEcjMoFpeYsO0Kn6RWJoks5rDGTIgaJpZM4K-aMH
.

yup looks like it


Fall back to footprint when COG isn't georeferenced

Originates from https://github.com/radiantearth/stac-browser/issues/101 and was written originally by @AsgerPetersen:

The Items in this demo catalog https://skraafotodistribution-stacfastapi.k8s-test-121.septima.dk/ have footprints, but their COGs are not georeferenced as they are not rectified.
It would be nice if the browser would fall back to the footprint in that case.

I dug a little deeper and the issue is that I'm missing a try-catch in georaster which causes the promise to parse the GeoRaster to never complete when this error occurs.  Here's a link to the line where I need to add a try/catch: https://github.com/GeoTIFF/georaster/blob/master/src/parseData.js#L83.    When I manually throw the error, stac-layer works fine.
I'll fix georaster and this should fix the downstream issues.

Small update.  I tried to fix this in georaster with https://github.com/GeoTIFF/georaster/commit/93d6491394e623c6fe1189c4f2c85cba98288b3a#diff-5369190f55138dab912f4f97bca88335d0f783f50e14cda286672c7e5821963aR83, but it didn't work.  The issue is that georaster uses old school promises and not async/await, so I have to update the code not just there, but everywhere else along the promise chain to make sure the error is sent all the way up (not to mention that the promise rejection is inside a web worker, so the error has to be sent as a message to the main thread).
I'm working on a massive upgrade to georaster at the moment (including using async/await), but that probably won't be complete for still a couple months.  I've already sank 2 hours into doing a hotfix to georaster, so I'm not optimistic about this path.
That said, I think there is an easier solution.  I can just fetch the first 1k bytes and then check if the projection information is in there using geotiff.js or is-cog.  If it's not, don't run parseGeoraster.  I'll keep you updated.

This is the production version of the STAC api: https://api.dataforsyningen.dk/skraafoto_api/v1.0/?token=6f27c9754e42e3ded6042f804203579b
The API and its data are free and open but requires a user token. I have created a token specifically for this issue, but I cannot guarantee for how long the token will survive. Ping me again if it stops working.

@AsgerPetersen Thanks a lot! Would you be okay with us downloading one of the GeoTiffs and (maybe after cropping), putting it with attribution (due to CC-BY 4.0) on https://github.com/GeoTIFF/test-data so that we avoid the token issue?

@DanielJDufour If you think this is a good idea, could you take care of this? I don't think I can push to the test-data repo...


Fixed dead link on trampolining

There may be a better Julia specific link, but I couldn't find one.

Thanks 👍

The archived version of the original link might be still usable.

Thanks @mindbound 👍


Remove equals from heading which breaks our links.

LGTM.
Open an issue for the TOC munger?

LGTM

cc @JanetKuo


class file for ca.uhn.fhir.model.primitive.BoundCodeableConceptDt not found in ca.uhn.fhir.jpa.provider.ResourceProviderMultiVersionTest

James,
I'm getting this error:
/Users/paulpog/Documents/workspace/hapi-fhir/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/ResourceProviderMultiVersionTest.java:47: error: cannot access BoundCodeableConceptDt
p.getGender().setValueAsEnum(AdministrativeGenderCodesEnum.M);
^
class file for ca.uhn.fhir.model.primitive.BoundCodeableConceptDt not found
but that class does not exist in the base source code. It's in either the structure.dstu or structure.dstu2 source
PP

Is this on a clean Git pull of HAPI, or on your fork? If the latter, can
you please push the changes you've made?
On Wed, Jun 17, 2015 at 4:10 PM, Paul Pogonoski<EMAIL_ADDRESS>wrote:

James,
I'm getting this error:
/Users/paulpog/Documents/workspace/hapi-fhir/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/ResourceProviderMultiVersionTest.java:47:
error: cannot access BoundCodeableConceptDt
p.getGender().setValueAsEnum(AdministrativeGenderCodesEnum.M);
^
class file for ca.uhn.fhir.model.primitive.BoundCodeableConceptDt not found
but that class does not exist in the base source code. It's in either the
structure.dstu or structure.dstu2 source
PP
—
Reply to this email directly or view it on GitHub
https://github.com/jamesagnew/hapi-fhir/issues/187.

It’s a pull of HAPI for any source changes. these source changes were updated into my fork.
I’ve just pushed the changes to the fork

On 17 Jun 2015, at 9:23 pm, James Agnew<EMAIL_ADDRESS>wrote:
Is this on a clean Git pull of HAPI, or on your fork? If the latter, can
you please push the changes you've made?
On Wed, Jun 17, 2015 at 4:10 PM, Paul Pogonoski<EMAIL_ADDRESS>wrote:

James,
I'm getting this error:
/Users/paulpog/Documents/workspace/hapi-fhir/hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/provider/ResourceProviderMultiVersionTest.java:47:
error: cannot access BoundCodeableConceptDt
p.getGender().setValueAsEnum(AdministrativeGenderCodesEnum.M);
^
class file for ca.uhn.fhir.model.primitive.BoundCodeableConceptDt not found
but that class does not exist in the base source code. It's in either the
structure.dstu or structure.dstu2 source
PP
—
Reply to this email directly or view it on GitHub
https://github.com/jamesagnew/hapi-fhir/issues/187.

—
Reply to this email directly or view it on GitHub https://github.com/jamesagnew/hapi-fhir/issues/187#issuecomment-112938918.

Hmm, ok if I try to build this fork locally I get a bunch of compile issues related to slf4j. I take it this doesn't happen for you?
[ERROR] /Users/t3903uhn/git/paulhapi/hapi-fhir/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/method/DynamicSearchMethodBinding.java:[113,38] incompatible types: java.lang.String cannot be converted to org.slf4j.Marker

No. However, I know we have a different implementation of SLF4J in our container, than that specified by HAPI

On 17 Jun 2015, at 9:32 pm, James Agnew<EMAIL_ADDRESS>wrote:
Hmm, ok if I try to build this fork locally I get a bunch of compile issues related to slf4j. I take it this doesn't happen for you?
[ERROR] /Users/t3903uhn/git/paulhapi/hapi-fhir/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/method/DynamicSearchMethodBinding.java:[113,38] incompatible types: java.lang.String cannot be converted to org.slf4j.Marker
—
Reply to this email directly or view it on GitHub https://github.com/jamesagnew/hapi-fhir/issues/187#issuecomment-112940828.

Hmm, ok I see it too.
Unfortunately I am stumped as to why. It doesn't happen on the non fork build, so it's definitely something to do with the changes you have made, but I don't know enough about the OSGi stuff to be able to begin to guess.
This really just reinforces my view though that it would make sense to add a new submodule with dependencies on everything you want to include and make sure that no changes happen to the rest of the build. I think as long as there are all of these dependency changes to the core library we wouldn't be able to merge this back into the core anyhow so it's not something we'll ever be able to keep current with....

Here is how this is done for the other HAPI library: http://sourceforge.net/p/hl7api/code/HEAD/tree/trunk/hapi-mvn/hapi-osgi-base/
That way there are no OSGi dependencies in the core or structures libraries and the unit tests don't break. This design is known to work.

OK.
Let me have a look at this and re-evaluate.
I take your point re supporting these changes. Although, All I have done is:

created my own servlet that will work in our container (created a WAB out of something like the hapi-fhir-jpaserver-example just didn’t work)
change the POM’s of the base, structure and jpa-server jars, to create bundles
add additional non-container jars into a separate library and add that library to the base bundle classpath.

PP

On 17 Jun 2015, at 9:49 pm, James Agnew<EMAIL_ADDRESS>wrote:
Here is how this is done for the other HAPI library: http://sourceforge.net/p/hl7api/code/HEAD/tree/trunk/hapi-mvn/hapi-osgi-base/ http://sourceforge.net/p/hl7api/code/HEAD/tree/trunk/hapi-mvn/hapi-osgi-base/
That way there are no OSGi dependencies in the core or structures libraries and the unit tests don't break. This design is known to work.
—
Reply to this email directly or view it on GitHub https://github.com/jamesagnew/hapi-fhir/issues/187#issuecomment-112946096.

Closing old bugs that appear solved, please re-open if issue persist.


DSDL should be compiled from .cyphal

Currently only the compiled DSDL is taken from .pycyphal and used


Issue with "Phone Number" Category

Hello team,
I came across a bug while using the Entity Recognition cognitive skill in Azure Cognitive Search, specifically "Phone Number" category.
The bug was that the indexer fails to run, and produces this error message:

"Failed to initialize indexer: List of categories contains one or more invalid categories. Valid categories are 'Product, PhoneNumber, Person, Quantity, Organization, IPAddress, URL, Email, Event, Skill, Location, PersonType, Address, DateTime'"

After going through the documentation of Text Analytics Cognitive Services, I found that "PhoneNumber" entity should be a one word and not separated by a space.
Supported entity categories in the Text Analytics API v3
This finding was also mentioned in the error message, where "PhoneNumber" entity should be one word not separated by a space. Although the documentation in Entity Recognition cognitive skill (V3) states otherwise, since it has it as "Phone Number" instead of "PhoneNumber".
Kindly review this documentation page, and thank you for your effort.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b3693b4-98ee-a221-ae90-6b5ec97eacee
Version Independent ID: c79b186c-a01f-47c3-51d8-40c60ccfa2cd
Content: Entity Recognition (V3) cognitive skill - Azure Cognitive Search
Content Source: articles/search/cognitive-search-skill-entity-recognition-v3.md
Service: cognitive-search
GitHub Login: @Ayokande
Microsoft Alias: aakande

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

@AhmedAlmu Thanks for the feedback again, will update the document soon.

@YutongTie-MSFT Thank you for the update and your effort on this.

We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


Update Ingame Info and Suggestions

Unsure if you are interested in getting info from other people, but I noticed some things about the map.
For starters I know Mayhem claim all of Paleto and actively patrol it on their bikes.
As far as I know wastelands claim grapeseed, but they are not really around much.
I also know that NBC has some turf in vinewood, but can come back with more exact info, but it is all tagged up ingame.
I would say MG also control the oil fields, considering its also El burro (their meth corner)
The ballas lease maze bank stadium to people for a meth corner, so i would count that for them, and afaik they "won" the banning corner from the vagos in their last war.
I also feel like the lost reach a bit further outside of sandy towards harmony, perhaps even the entire desert region.
There are still russians that operate out of the south east docks, they just stay lowkey. this has been known as "russian docks" for a long time.
Unsure what "oxy shop" is in the southsside
Paleto Pets is a business up north in paleto
I also thought it might be cool for you to add the "neighborhood" district overlay, as this often times coincides with territory, and is 100% how turf is defined ingame when it comes to drug sales.

https://i.redd.it/5cw11krz9kcz.jpg
This is the neighborhood map

@Daunt92, I can do that.  I wont be able to start it for a couple days.  Thanks for the resource

@Daunt92, Should be ready this weekend

#31 adds the neighborhoods


webFetch() fails in mock accessing http://localhost:8000/config.txt

Using SAFE Browser mock 0.14.0 to access the same resource in two ways:

WORKS: type http://localhost:8000/config.txt into browser address bar
FAILS: using safeApp.webFetch('http://localhost:8000/config.txt', {method:'GET'})

OS: Ubuntu 18.10

Ah, right now webFetch is only setup for accessing safe:// urls. It doesn't do any handling of http.
It should work if you use a standard browser fetch though.

I think it would be best if this was fixed so that using mock will work as well as live, when for example doing webFetch('/config.txt')

yeh that'd make sense.
So this issue is probably more like 'wrap safeApp nodejs webfetch to be able to handle any acceptable browser URL (eg: localhost)


Boxplot whisker ends shown for aggregated groups even if values are exceeding the maximum set by “data mapping”

To Reproduce

Open https://lineup.js.org/develop/aids.html
Group for Human Development Index
Collapse all groups
Open data mapping for column Yearly change in %
Set max value of input domain to 2.5

Expected behavior
The Boxplot whisker ends (right border) should not be visible if data mapping is applied.
Screenshots
Before adjusting the data mapping

After adjusting the data mapping

The whiskers are "off-screen" (or column) but here they are still visible which leads to wrong interpretations of the data.
Context

Version: 4.3.0
Browser: Chrome 94

Thanks for explanation. What would happen if we disable the clamping for data mapping? Which other side effects does this have in LineUp?

So, that the basic assumption that a normalized value is in the 0..1 range won't hold anymore...

all renderer that are using normalized values would need to manually handle that case ensuring that they are not rendering outside of their box
not sure about normalized histograms and making sure that the alignment to the data mapping is still the same
combined columns will have the same problem, e.g. a stacked bar where one component is bigger that 1 or in theory also smaller than 0
numerical color scales that use the value would also need to be adapted.

We discussed this internally and we suggest to show a warning to the user in the data mapping dialog when modifying the input domain.

Warning: All items with values outside of the input domain will be set to the min/max value of the input domain.

@sgratzl Is it possible to show such a warning?


Delete feature_cat and feature_home

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3162e14) to head (db32737).

Files
Patch %
Lines

.../jamiecruwys/showcase/presentation/MainActivity.kt
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #120   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          6       6
  Lines         63      55    -8
  Branches      13      13
=====================================
+ Misses        63      55    -8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Try to actually acquire a frame on Intel/Linux upon adapter inspection

Another take at the problem previously addressed by #94/#95/#97

@kvark I'm planning to pull this into Zed so we can get feedback from people.

Looks like this path faced some issues for end users

Hey, could this be rebased on master to fix #168? Thanks!

@apricotbucket28 done

Some information that may be relevant to this, especially if kvark finds it inconvenient to test Wayland locally:

I still experience the issue described in https://github.com/zed-industries/zed/issues/17005 even if I switch Zed to use this branch.
On that issue, I just added a backtrace of a segfault I captured with gdb, of encountering this issue. This may be useful as I didn't see a segfault already posted on related issue threads.

This path is no longer viable, since as of #203 we don't have a specific surface any more when creating a GPU context.
We'll need to find a better path.


Improve the style of documentation

Description
This commit improves the documentation (rst files) only in the
following three ways:

Aligned section headers with their underline/overline punctuation characters

Deleted all trailling whitespaces in rst files

Deleted a few trailling newlines at the end of the rst files

Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[ ] Add new feature
[x] Update documentation

Please merge the main branch to run the new version of CI. Thanks

It looks great!
Thanks!


PHOENIX-7465 Update to spark 3.4.4

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+0 :ok:
mvndep
1m 30s
Maven dependency ordering for patch

-1 :x:
mvninstall
0m  6s
root in the patch failed.

-1 :x:
compile
0m  6s
root in the patch failed.

-1 :x:
javac
0m  6s
root in the patch failed.

-1 :x:
scalac
0m  6s
root in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 10s
phoenix5-spark3 in the patch failed.

-1 :x:
javadoc
0m  6s
root in the patch failed.

-1 :x:
scaladoc
0m  9s
phoenix5-spark3 in the patch failed.

-1 :x:
scaladoc
0m  7s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
0m  6s
root in the patch failed.

-1 :x:
asflicense
0m 25s
The patch generated 4 ASF License warnings.

24m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/148

Optional Tests
dupname asflicense scalac scaladoc unit compile javac javadoc xml

uname
Linux acb5053ef1ed 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 6a5f621

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-compile-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/branch-scaladoc-root.txt

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-compile-root.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-compile-root.txt

scalac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-compile-root.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-scaladoc-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
52 (vs. ulimit of 30000)

modules
C: phoenix5-spark3 . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-148/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


docs: add a note arguing you should generate tokens

Add a note at the top of the token generation howto, explaining why you should, what you should do if you don't, and that administrators can disable it.
I'd like to add a link to the proper helm chart value in that last item, but I don't really know what to link to (the value is server.allowImplicitLogin.
Companion PR to https://github.com/Substra/substra-backend/pull/698
Similar to https://github.com/Substra/substra-documentation/pull/335 and https://github.com/Substra/substra/pull/378

Waiting for https://github.com/Substra/substra-backend/pull/698 to be merge


[skip-ci] RPM: switch default firewall to nftables on EL10+

set NETAVARK_DEFAULT_FW to nftables on EL10+.

LGTM

ELN failures can be ignored for now. They are fixing ELN to default to dnf5 as we speak.

[root@7629c3fd2a93 /]# rpm -q netavark
netavark-1.10.1-1.20240514125744608979.pr987.119.ge7ea9b7.el10.x86_64
[root@7629c3fd2a93 /]# /usr/libexec/podman/netavark version
{
  "version": "1.11.0-dev",
  "commit": "14044b1e19f238939aa53f10d9acf02e0da11c49",
  "build_time": "2024-05-14T00:00:00+00:00",
  "target": "x86_64-unknown-linux-gnu",
  "default_fw_driver": "nftables"
}

Tested on centos stream 10 container image.
@Luap99 @mheon @jnovy PTAL

Re-pushing with a comment.


handle time for metal EPs

 Data quality: Time for Metal Improvement

 Data quality: Time for Metal Improvement

What I just remebered: what about clearing the album title of the (EP)?

What about
albumTitle = albumTitle.replaceAll(EP_SUFFIX, "")

It's already there...


Replace pronto with danger

What happened
Replaced pronto with danger system
Why?

Pronto is currently being used to provides inline linting comments. It was selected because it supports for Bitbucket. But even that support broke back in August last year (2019). Since we migrated to Github, there is no need to continue using Pronto.

Reference
Insight

Removed pronto and it's related setup from the repository
Added Danger system and dependent gems
Added and formulated the basic Dangerfile
Edited semaphore.yml to support the changes

Proof Of Work
Implemented in Braive: :heavy_check_mark:

LGTM @noor-ahmed @rafayetn @junan @byhbt 👏👏👏


Can you change GPL to a more permissive license?

This library looks great, but I'm hesitant to publish my code with GPL, which I must if I use this library. Would you please release the library with a more permissive license like MIT?

Good idea. I'll do it as soon as possible.

It's licensed with MIT License now


[HUDI-2252] Replace read full data with read latest commit data in fl…

…ink stream read
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
New, flink streaming read process will read full data instead of reading the incremental data, which will greatly affect the performance of reading. So in this PR, the default read strategy is changed to read the incremental data set of latest commit instead of all the snapshot data PLUS incremental data set.
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Change commit title to "[HUDI-2252] Default consumes from the latest instant for flink streaming reader"


Sample project update.

Hi. I updated the sample for the KMM project with shared UI.
Changes:

updated dependencies
modularized it by feature, each of them is a small ballast component
added Web target
added screenshots

Thanks for making these updates! I continue to get more and more excited about where Compose is going, and this is a great example of how Ballast fits into that workflow. I'll review it a bit closer today before merging this PR

Thanks for merging this. I'll expand the sample later to showcase different features of Ballast and common Kotlin Multiplatform use cases.


Optimize and audit static images

Images in static/ are only used up to certain widths. They can be bulk resized so the source matches this width. See https://www.gatsbyjs.com/docs/preoptimizing-images/
Some images are no longer used. They are copied directly from the static/ dir so we need to make sure they are not expected at those paths from anywhere outside this repo.

Hey @lukekarrys I see #748 covered the resizing.
Did you still need someone to audit the images that are no longer used?


Google Login: Library v1.12.1 and later are broken on Android API 21

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/googleapis/google-auth-library-java/issues
Check for answers on StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform

If you are still having issues, please include as much information as possible:
Environment details

Specify the API at the beginning of the title. For example, "BigQuery: ...").
General, Core, and Other are also allowed as types
OS type and version: Android API 21
Java version: Java 7
version(s): v1.12 is good. v1.12 and later (including v1.17) are broken

Stack trace
java.lang.NoSuchMethodError: No virtual method getAndSetObject(Ljava/lang/Object;JLjava/lang/Object;)Ljava/lang/Object; in class Lsun/misc/Unsafe; or its super classes (declaration of 'sun.misc.Unsafe' appears in /system/framework/core-libart.jar)
   E      at com.google.common.util.concurrent.AbstractFuture$UnsafeAtomicHelper.gasWaiters(AbstractFuture.java:1394)
   E      at com.google.common.util.concurrent.AbstractFuture.releaseWaiters(AbstractFuture.java:1110)
   E      at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1000)
   E      at com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:783)
   E      at com.google.auth.oauth2.OAuth2Credentials$RefreshTask.access$400(OAuth2Credentials.java:600)
   E      at com.google.auth.oauth2.OAuth2Credentials$RefreshTask$1.onSuccess(OAuth2Credentials.java:617)
   E      at com.google.auth.oauth2.OAuth2Credentials$RefreshTask$1.onSuccess(OAuth2Credentials.java:614)
   E      at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1138)
   E      at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
   E      at com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:143)
   E      at com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:132)
   E      at com.google.common.util.concurrent.ListenableFutureTask.done(ListenableFutureTask.java:111)
   E      at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
   E      at java.util.concurrent.FutureTask.set(FutureTask.java:204)
   E      at java.util.concurrent.FutureTask.run(FutureTask.java:245)
   E      at com.google.auth.oauth2.OAuth2Credentials$RefreshTask.run(OAuth2Credentials.java:633)
   E      at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
   E      at com.google.auth.oauth2.OAuth2Credentials$AsyncRefreshResult.executeIfNew(OAuth2Credentials.java:581)
   E      at com.google.auth.oauth2.OAuth2Credentials.asyncFetch(OAuth2Credentials.java:232)
   E      at com.google.auth.oauth2.OAuth2Credentials.getRequestMetadata(OAuth2Credentials.java:182)
   E      at com.google.auth.oauth2.ServiceAccountCredentials.getRequestMetadata(ServiceAccountCredentials.java:931)
   E      at com.google.auth.http.HttpCredentialsAdapter.initialize(HttpCredentialsAdapter.java:96)
   E      at com.google.api.client.http.HttpRequestFactory.buildRequest(HttpRequestFactory.java:91)
   E      at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.buildHttpRequest(AbstractGoogleClientRequest.java:442)
   E      at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:552)
   E      at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:493)
   E      at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.execute(AbstractGoogleClientRequest.java:603)

Ref: https://gist.github.com/ashishb/108a095603446fa39eb901b006642af6
External references such as API reference guides

?

Any additional information below
Following these steps guarantees the quickest resolution possible.
Thanks!

@ashishb This library supports Java 8+ starting version 1.0.0.


how to add another org through sdk?

I got some requests on how to add another organization through sdk, I will check the issue and update the tutorial.

A reference: https://hyperledger-fabric.readthedocs.io/en/release-2.0/channel_update_tutorial.html

Does the python have this function? or need help to add this function?

@00Kai0 I think all the parts are ready but there is no wrap-up function

yeah, need a tutorial about it. Are you working on it?

Not currently, I'm still writing my thesis. If depending on me, it will be June or July. So if anyone is available, feel free to pick this task up.

Yeah, I want to do if I can. But I don't find any task list in jira.
Is it because the python sdk is too new? Is it still in preview?

we migrate from jira to github issues now.

But you can create an issue on jira as well if you want to. Link here

that's great, thank you

@dexhunter is this still open?


Configure for colima

Is it possible to configure this module to work with colima? Because of the licensing model, I can't use docker desktop and I am using colima as an alternative.
When I run my tests, I get the error:
com.playtika.test.common.spring.DockerNotPresentException: Docker must be present in order for testcontainers to work properly!
Is there a known fix?

this project uses testcontainers in order to use it with colima check the docs

Thank you for your answer. With the configuration from this post I could get the Testcontainers running, but now I have the issue that the connection to my postgres does not work I get the following error: connection to localhost:49212 refused. Check that the hostname and port are correct and that the postmaster is accepting TCP/IP connections.
I checked the configuration with Docker Desktop and it was working fine

I think I fixed the problem with the following steps:

Run colima delete
Run colima start
Run sudo ln -sf $HOME/.colima/default/docker.sock /var/run/docker.sock according to the colima FAQ
Add the environment variables from below (with export in .zshrc or with set -g -x in fish) according to the testcontainer documentation

TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=/var/run/docker.sock
DOCKER_HOST=unix://{$HOME}/.colima/default/docker.sock
TESTCONTAINERS_RYUK_DISABLED=true

Thanks to @eddumelendez who helped me fixing this issue


Wanted a middleware to manage OA account which is not start with 'gh_'

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Some OA account which our user can not know all of them, and when we get some message from them, some mistake response message will make our bot crazy! And also take a high risk to our WeChat account.
Describe the solution you'd like
A clear and concise description of what you want to happen.
A smart wechaty middleware which could skip all of them messages which we do not want, and we could also add a white list for it.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
We need a list like that:
exceptid = ['newsapp', \
"weixin", \
"qqmail", \
"filehelper", \
"fmessage", \
"tmessage", \
"qmessage", \
"lbsapp", \
"qqsync", \
"floatbottle", \
"shakeapp", \
"medianote", \
"newsapp", \
"weibo", \
"weixinguanhaozhushou", \
"feedsapp", \
"qqsafe", \
"mphelper", \
"cmb4008205555", \
"meituanwx"]

the list is copy from here
And we could keep it open source, and let more and more contributor to expand it.
Additional context
Add any other context or screenshots about the feature request here.
[enhancement]

maybe we can add a function like this:
function checkOfficial (id: string):boolean {
  const exceptidList = [
    'newsapp',
    'weixin',
    'qqmail',
    'filehelper',
    'fmessage',
    'tmessage',
    'qmessage',
    'lbsapp',
    'qqsync',
    'floatbottle',
    'shakeapp',
    'medianote',
    'newsapp',
    'weibo',
    'weixinguanhaozhushou',
    'feedsapp',
    'qqsafe',
    'mphelper',
    'cmb4008205555',
    'meituanwx']

  if (/^gh_/.test(id) || exceptidList.indexOf(id) > -1) {
    return true
  }

  return false
}

https://github.com/HalfdogStudio/wechat-user-bot/issues/10#issuecomment-172181796
https://github.com/EricCen/wechat-robot/blob/master/src/main/java/me/biezhi/wechat/Constant.java#L20

We can publish a npm package here: https://github.com/wechaty/wechaty-type

Awesome! It's a great package and I believe that all puppet should dependence it for identifying the ID types.
BTW the WeChat system now allows the official account to customize their ID to any strings. So I believe we should try to find more robust way to identical the OA account other than depending the string features and the hard coded list.


OCM-5758 | fix: allow to patch subnet of hcp mp

OCM-5758
Change type

[ ] New feature
[x] Bug fix
[ ] Build
[ ] CI
[ ] Documentation
[ ] Performance
[ ] Refactor
[ ] Style
[ ] Unit tests
[x] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

/lgtm
/approve


benchmarking

Signed-off-by: lovesh harchandani<EMAIL_ADDRESS>

I couldn't tell exactly what failed in the CI pass from the logs I saw. Mike?

Oh, a download of a docker image failed.

@lovesh once you address my nits and fix the conflict, we can land this patch.  Thanks!

https://gitlab.com/sovrin-foundation/ursa/-/jobs/170281118. Once that's fixed I can merge it.

@lovesh please fix the merge conflict.

@dhuseby Done


Complete rewrite

This shouldn't be too hard to do, and I think we can do better overall with a new codebase.

I'm working on this in the mchp2 branch, but I'll likely not continue it since the current panel works fairly well and I don't have the free time I had when first building this.


Implement ensemble defense for poisoning

Is your feature request related to a problem? Please describe.
Deep Partition Aggregation: Provable Defense against General Poisoning Attacks
https://arxiv.org/abs/2006.14768
Describe the solution you'd like

jupyter notebook
examples

Describe alternatives you've considered
NA
Additional context
NA

I can work on implementing this


Spell Voilà properly in README.md

There's two kind of people in this world. Those who spell French properly, and those who don't.

NB: this is more of a joke than an actual need. I think nobody cares about a single `

There are two kinds of people in the world: those that have French keyboards, and those that don't :P

I nailed that answer ^^

Apologies if I shouldn't be commenting on this (I'm relatively new to rust, just exploring around atm), but - this PR made me wheeze in the middle of class.
This entire community seems extremely wholesome, oh my goodness.


ffuf problom

why am i geting ffuf like this any fix ?

Hi @asterfinix,
Your terminal window width is smaller than the minimum required to show the entire line, so it breaks the line and keeps showing you that.
Happy hacking.


Enable linux build

To enable linux build I had:

Removed usage of paket (because it requires mono)
Added condition for build that on linux only .net core targets are built
Update build.fsx to reflect the above

Moreover, I have enabled linux build for AppVeyor. It does not make sense to have multiple linux builds. It is just for consideration how it looks.
Disadvantage of this change is losing paket functionality (synchronization of nuget reference versions). Advantage is simplification of usage as now it is not anything extra needed to build it (except .NET Core SDK on all platforms and .NET 4.5.2 target on Windows). Moreover, it gives option mentioned by @bartelink to have various dependencies for targets.
What do you think about this change?

It is good to have Linux build working.
I wouldn't stop supporting Mono, I think it is still very valuable platform and usable in scenarios where .NET Core isn't. The proposed change removes it.
I like Paket, I agree that it's value is lower with .NET Core. I like that you fix by this the Linux build. However, it doesn't mean I wouldn't like to reintroduce it once Mono is fixed or there is .NET Core version of Paket. But it is just personal opinion, I am fine with it. And Paket supports different versions of dependencies for various targets (see https://github.com/fsprojects/Paket/pull/3046/files).

First of all, this pull request is to open discussion.
To be honest, I think that if we will be able to rework the emits in a way that it will work similarly even under netstandard, then we can remove the net45 target completely. That means that mono will not be needed for anything.
Right now, it does not remove Mono support. It just removes the ability to compile net45 targets under Mono. The nuget still can be used under Mono.
The only question is whether we want to use paket or not. If so, then we need to have working paket under Mono again. Or we need to get paket running without Mono.

I think it is great that you opened the discussion.
You are right that Mono is still supported for client usage even with this change. However, I also value ability of being compiling and testing TickSpec itself using Mono. Even, if we had .NET Standard version of TickSpec only it is good to support using Mono for both .NET Standard compilation and .NET45 tests running.

You have more knowledge and context, but based on my knowledge, that makes sense so feel free to go ahead with that if you see fit.


Boringssl support for s390x

Creating this issue with reference : https://github.com/tensorflow/tensorflow/pull/11170
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): master
Bazel version (if compiling from source): 0.6.1
CUDA/cuDNN version: Not used
Exact command to reproduce: bazel build -c opt //tensorflow/tools/pip_package:build_pip_package

Hello @gunan Continuing discussion about disabling the oauth support /GCP on big endian from issue https://github.com/tensorflow/tensorflow/pull/11170#issuecomment-320071548
I could see that the PR changes made for s390x are now reverted in Tensorflow master.
So as suggested, disabling GCP support on a big-endian systems,  I followed following steps:
~/tensorflow# ./configure

You have bazel 0.6.1- (@non-git) installed.
Please specify the location of python. [Default is /usr/bin/python]:
Found possible Python library paths:
/usr/local/lib/python2.7/dist-packages
/usr/lib/python2.7/dist-packages
Please input the desired Python library path to use.  Default is [/usr/local/lib/python2.7/dist-packages]
Do you wish to build TensorFlow with jemalloc as malloc support? [Y/n]:
jemalloc as malloc support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Google Cloud Platform support? [Y/n]: n
No Google Cloud Platform support will be enabled for TensorFlow.

~/tensorflow# bazel build -c opt //tensorflow/tools/pip_package:build_pip_package
Even after disabling GCP support, build fails with an error:
ERROR: /root/.cache/bazel/_bazel_root/30b0ed2738c25ecefa4b108f71649fc1/external/boringssl/BUILD:115:1: C++ compilation of rule '@boringssl//:crypto' failed (Exit 1).
In file included from external/boringssl/src/include/openssl/bio.h:60:0,
                 from external/boringssl/src/crypto/bio/printf.c:57:
external/boringssl/src/include/openssl/base.h:114:2: error: #error "Unknown target CPU"
 #error "Unknown target CPU"
  ^

Need more changes here?
On test cases part, I have added tags = ["no_big_endian"]  in tensorflow/core/platform/cloud/BUILD file.
Yet to verify this changes.

Looks like S3 support also depends on curl, which depends on boringssl.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/platform/s3/BUILD#L47
Could you also try turning off s3 support?
On Fri, Oct 27, 2017 at 11:34 AM, Nayana Thorat<EMAIL_ADDRESS>wrote:

Hello @gunan https://github.com/gunan Continuing discussion about
disabling the oauth support /GCP on big endian from issue #11170 (comment)
https://github.com/tensorflow/tensorflow/pull/11170#issuecomment-320071548
I could see that the PR changes made for s390x are now reverted in
Tensorflow master.
So as suggested, disabling GCP support on a big-endian systems, I followed
following steps:
~/tensorflow# ./configure
You have bazel 0.6.1- (@non-git) installed.
Please specify the location of python. [Default is /usr/bin/python]:
Found possible Python library paths:
/usr/local/lib/python2.7/dist-packages
/usr/lib/python2.7/dist-packages
Please input the desired Python library path to use. Default is
[/usr/local/lib/python2.7/dist-packages]
Do you wish to build TensorFlow with jemalloc as malloc support? [Y/n]:
jemalloc as malloc support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Google Cloud Platform support? [Y/n]:
n
No Google Cloud Platform support will be enabled for TensorFlow.
~/tensorflow# bazel build -c opt //tensorflow/tools/pip_
package:build_pip_package
Even after disabling GCP support, build fails with an error:
ERROR: /root/.cache/bazel/_bazel_root/30b0ed2738c25ecefa4b108f71649fc1/external/boringssl/BUILD:115:1: C++ compilation of rule '@boringssl//:crypto' failed (Exit 1).
In file included from external/boringssl/src/include/openssl/bio.h:60:0,
from external/boringssl/src/crypto/bio/printf.c:57:
external/boringssl/src/include/openssl/base.h:114:2: error: #error "Unknown target CPU"
#error "Unknown target CPU"
^
Need more changes here?
On test cases part, I have added tags = ["no_big_endian"] in
tensorflow/core/platform/cloud/BUILDfile.
Yet to verify this changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/14039#issuecomment-340049932,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHlCOQ69vwqT3DmG_4bOXfdizxCtg2I4ks5swiIfgaJpZM4QJcJ0
.

@Nayana-ibm have you tried also turning off s3 support?

hi @gunan I have tried turning off s3 support through configure however still I'm facing an issue with boringssl code.
tensorflow# ./configure
You have bazel 0.6.1- (@non-git) installed.
Please specify the location of python. [Default is /usr/bin/python]:

Found possible Python library paths:
  /usr/lib/python3/dist-packages
  /usr/local/lib/python3.5/dist-packages
Please input the desired Python library path to use.  Default is [/usr/lib/python3/dist-packages]

Do you wish to build TensorFlow with jemalloc as malloc support? [Y/n]:
jemalloc as malloc support will be enabled for TensorFlow.

Do you wish to build TensorFlow with Google Cloud Platform support? [Y/n]: N
No Google Cloud Platform support will be enabled for TensorFlow.

Do you wish to build TensorFlow with Hadoop File System support? [Y/n]: N
No Hadoop File System support will be enabled for TensorFlow.

Do you wish to build TensorFlow with Amazon S3 File System support? [Y/n]: N
No Amazon S3 File System support will be enabled for TensorFlow.

Do you wish to build TensorFlow with XLA JIT support? [y/N]:
No XLA JIT support will be enabled for TensorFlow.

Do you wish to build TensorFlow with GDR support? [y/N]:
No GDR support will be enabled for TensorFlow.

Do you wish to build TensorFlow with VERBS support? [y/N]:
No VERBS support will be enabled for TensorFlow.

Do you wish to build TensorFlow with OpenCL support? [y/N]:
No OpenCL support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]:
No CUDA support will be enabled for TensorFlow.

Do you wish to build TensorFlow with MPI support? [y/N]:
No MPI support will be enabled for TensorFlow.

Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -march=native]:

Add "--config=mkl" to your bazel command to build with MKL support.
Please note that MKL on MacOS or windows is still not supported.
If you would like to use a local MKL instead of downloading, please set the environment variable "TF_MKL_ROOT" every time before build.
Configuration finished

bazel build -c opt //tensorflow/tools/pip_package:build_pip_package

ERROR: /root/.cache/bazel/_bazel_root/79d3d3c667100526634e40f5a15c8098/external/boringssl/BUILD:115:1: C++ compilation of rule '@boringssl//:crypto' failed (Exit 1).
In file included from external/boringssl/src/include/openssl/asn1.h:61:0,
                 from external/boringssl/src/crypto/asn1/f_int.c:57:
external/boringssl/src/include/openssl/base.h:114:2: error: #error "Unknown target CPU"
 #error "Unknown target CPU"
  ^

I'm looking  into BUILD files if there is any code change requires for s390x.

@case540 Do we need to disable s3 and gcp support through config options?

@case540 Could you please let me if disabling support by config options is sufficient? Do I need to investigate further on this?

You can disable s3 and gcp support by not having --config=s3 or --config=gcp in your Bazel build command (answering No to s3 and gcp support question when running configure.py will do this (they default to the Yes choice)).
Looks like you already did this though.

Looks like now we need boringssl for grpc.
@martinwicke WDYT?

Also cc @vjpai
We would like to build TF for s390x. But boring SSL strictly has no ppc64 support. Looks like GRPC now depends on boringssl. Below is my bazel query output:
@grpc//:grpc++_unsecure
@grpc//:grpc++_base_unsecure
@grpc//:grpc_unsecure
@grpc//:grpc_common
@grpc//:census
//external:libssl
@boringssl//:ssl
@boringssl//:crypto

How would you recommend for us to proceed?

This looks like a bug in the grpc_unsecure rule. It seems like it shouldn't depend on any ssl code. @mrry do you know who to best tell about this?

I think @vjpai would probably have it covered - he recently switched us over to using gRPC's own BUILD file (instead of our old fork).

Thanks for the heads-up; I'll look this over. It is indeed a problem in the rule for grpc_unsecure if it actually depends on boringssl.

Ok, I see the issue. This dependence is being pulled up through census. Not sure why census wants boringssl but I'll investigate.

I think I have this under control with grpc/grpc#13525 .

Awesome, thanks! We need to update our dependency again once this is merged.

@gunan   As grpc dependency version is updated through #14981,  I have tried building tensorflow master for s390x again.  I have disabled Google Cloud Platform and  Amazon S3 File System support through ./configure options.  (answering No to s3 and gcp support question when running configure.py )
Now, build is successful (No error related to boringssl) however test execution failed with
ERROR: external/boringssl/BUILD:115:1: Couldn't build file external/boringssl/_objs/crypto/external/boringssl/src/crypto/bn_extra/bn_asn1.pic.o: C++ compilation of rule '@boringssl//:crypto' failed (Exit 1).
In file included from external/boringssl/src/include/openssl/bn.h:126:0,
                 from external/boringssl/src/crypto/bn_extra/bn_asn1.c:15:
external/boringssl/src/include/openssl/base.h:114:2: error: #error "Unknown target CPU"
 #error "Unknown target CPU"
  ^
In file included from external/boringssl/src/crypto/bn_extra/bn_asn1.c:15:0:
external/boringssl/src/include/openssl/bn.h:163:2: error: #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
 #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
  ^

I guess, I need to add no_big_endian tag in the BUILD files to disable the tests as you mentioned in https://github.com/tensorflow/tensorflow/pull/11170#issuecomment-329252942
I have identified below files which may require change:
tensorflow/core/platform/cloud/BUILD
tensorflow/contrib/tpu/profiler/BUILD
tensorflow/core/platform/default/build_config.bzl
tensorflow/core/platform/s3/BUILD
third_party/aws.BUILD
tensorflow/BUILD
tensorflow/core/platform/cloud/BUILD
tensorflow/contrib/cloud/kernels/BUILD
third_party/curl.BUILD

Please correct me if I'm missing anything here.

What was the exact command you tried and got this result?

5H2L
Get Outlook for Androidhttps://aka.ms/ghei36

From: Gunhan Gulsoy<EMAIL_ADDRESS>Sent: Wednesday, December 13, 2017 2:49:58 PM
To: tensorflow/tensorflow
Cc: Subscribed
Subject: Re: [tensorflow/tensorflow] Boringssl support for s390x (#14039)
What was the exact command you tried and got this result?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/issues/14039#issuecomment-351516681, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcpcMArDmneFh7Xvpq6fPotso9a4E18eks5tADh2gaJpZM4QJcJ0.

Configure using:
export TF_NEED_GCP=0
export TF_NEED_HDFS=0
export TF_NEED_CUDA=0
export TF_NEED_MKL=0
export TF_NEED_OPENCL=0
export TF_NEED_VERBS=0
export TF_NEED_S3=0
yes "" | ./configure

Build
bazel build -c opt //tensorflow/tools/pip_package:build_pip_package
==> Build successful.
Run bazel test command.
bazel --host_jvm_args="-Xms512m" --host_jvm_args="-Xmx1024m" test \
    --test_tag_filters=-gpu,-benchmark-test -k \
    --test_timeout 300,450,1200,3600 --build_tests_only \
    --test_output=errors -- \
    //tensorflow/... -//tensorflow/compiler/...

==> Facing an issue related to boringssl : #error "Unknown target CPU"

The command somehow seems to be trying to build cloud and mobile targets.
using no_big_endian tags will not help with the command you are running, because you are not filtering with the "no_big_endian" tag in your command.
One immediate solution can be to exclude some more modules in your command. Could you try adding these at the end of your command:
-//tensorflow/core/platform/aws/... -//tensorflow/core-platform/cloud/... -//tensorflow/contrib/lite/... -//tensorflow/contrib/cloud/...

@gunan Executed below command to execute tests:
bazel --host_jvm_args="-Xms512m" --host_jvm_args="-Xmx1024m" test \
    --test_tag_filters=-gpu,-benchmark-test -k \
    --test_timeout 300,450,1200,3600 --build_tests_only \
    --test_output=errors -- \
    //tensorflow/... -//tensorflow/compiler/... -//tensorflow/core/platform/aws/... -//tensorflow/core-platform/cloud/... -//tensorflow/contrib/lite/... -//tensorflow/contrib/cloud/...

Still facing an error:

external/boringssl/src/ssl/../crypto/internal.h:338:19: warning: 'constant_time_select_int' defined but not used [-Wunused-variable]
 static inline int constant_time_select_int(crypto_word_t mask, int a, int b) {
                   ^
____[9,702 / 9,711] Compiling external/boringssl/src/ssl/s3_pkt.cc
ERROR: /data/TF_tmp/_bazel_root/be3f47674f2731fd84874c35a2feb28b/external/boringssl/BUILD:128:1: Couldn't build file external/boringssl/_objs/ssl/external/boringssl/src/ssl/s3_pkt.pic.o: C++ compilation of rule '@boringssl//:ssl' failed (Exit 1).
In file included from external/boringssl/src/include/openssl/ssl.h:145:0,
                 from external/boringssl/src/ssl/s3_pkt.cc:109:
external/boringssl/src/include/openssl/base.h:114:2: error: #error "Unknown target CPU"
 #error "Unknown target CPU"
  ^
In file included from external/boringssl/src/include/openssl/asn1.h:68:0,
                 from external/boringssl/src/include/openssl/x509.h:70,
                 from external/boringssl/src/include/openssl/pem.h:66,
                 from external/boringssl/src/include/openssl/ssl.h:149,
                 from external/boringssl/src/ssl/s3_pkt.cc:109:
external/boringssl/src/include/openssl/bn.h:163:2: error: #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
 #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
  ^
In file included from external/boringssl/src/ssl/s3_pkt.cc:121:0:
external/boringssl/src/ssl/../crypto/internal.h:202:2: error: #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"
 #error "Must define either OPENSSL_32_BIT or OPENSSL_64_BIT"


Add WebRTC clusters definitions

2 interlinked WebRTC clusters defined. The spec is in the cameras branch of the specs repo.
There is a StreamType enum added to one of the clusters (used in both) that is defined in the spec in a different cluster (AVStreamManagement). I have defined in here to unblock for now, and added an issue to remove as soon as AVStreamManagement cluster definition is merged.

I think we may be trampling each others' work 😅
I originally had this PR as one big one, as they are all somewhat interlinked: https://github.com/project-chip/connectedhomeip/pull/35773
But @bzbarsky-apple requested that I split it up to one-cluster-per-PR, and so I've done that & have a pending PR for one of the webrtc clustes: https://github.com/project-chip/connectedhomeip/pull/35773
(was going to get that in first before doing the 2nd)

ok, killing this one and will create a new pr just with requestor


/sonarr_actions.py", line 194, in get_series_to_exclude KeyError: 'title'

Describe the bug
Bug when running in docker against large pool of sonarr shows.
To Reproduce
See below
Versions

OS Version: ubutu
Excludarr version: current from dockerhub

Debug logging
Running
docker run -it --rm --env-file excludarr.env haijeploeg/excludarr:latest --debug sonarr exclude -a not-monitored

gives me the following. Note it does process several shows (which I have omitted) before failing.
[2021-12-27 16:12:41] - Starting Excludarr v1.0.2
[2021-12-27 16:12:41] - Got sonarr as subcommand
[2021-12-27 16:12:41] - Reading configuration file
[2021-12-27 16:12:41] - Determining which configfile to use
[2021-12-27 16:12:41] - Configfile to use: /etc/excludarr/excludarr.yml
[2021-12-27 16:12:41] - Reading configfile: /etc/excludarr/excludarr.yml
[2021-12-27 16:12:41] - Read the following configuration: {'general': {'fast_search': True, 'locale': 'en_
US', 'providers': ['netflix', 'amazon prime video', 'Disney Plus', 'Hulu']}, 'radarr': {'url': 'http://192.168.1.
197:7878', 'api_key': '<REDACTED>', 'verify_ssl': False, 'exclude': ['']}, 'sonarr': {'url': 'http://<IP_ADDRESS>
7:8989', 'api_key': '<REDACTED>', 'verify_ssl': False, 'exclude': ['']}}
[2021-12-27 16:12:41] - Got exclude as subcommand
[2021-12-27 16:12:41] - Got CLI values for -p, --provider option:
[2021-12-27 16:12:41] - Got CLI values for -l, --locale option: None
[2021-12-27 16:12:41] - Got CLI values for -a, --action option: not-monitored
[2021-12-27 16:12:41] - Got CLI values for -d, --delete option: False
[2021-12-27 16:12:41] - Got CLI values for -e, --exclusion option: False
[2021-12-27 16:12:41] - Got CLI values for -y, --yes option: False
[2021-12-27 16:12:41] - Got CLI values for --progress option: False
[2021-12-27 16:12:41] - Initializing PySonarr
[2021-12-27 16:12:41] - Initializing JustWatch API with locale: en_US
[2021-12-27 16:12:41] - Getting all the series from Sonarr
[2021-12-27 16:12:42] - Got the following providers: Netflix, Amazon Prime Video, Disney Plus, Hulu

Traceback (most recent call last):
  File "/usr/local/bin/excludarr", line 33, in <module>
    sys.exit(load_entry_point('excludarr==1.0.2', 'console_scripts', 'excludarr')())
  File "/usr/local/lib/python3.10/site-packages/excludarr-1.0.2-py3.10.egg/excludarr/main.py", line 68, in cli
  File "/usr/local/lib/python3.10/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/typer/main.py", line 500, in wrapper
    return callback(**use_params)  # type: ignore
  File "/usr/local/lib/python3.10/site-packages/excludarr-1.0.2-py3.10.egg/excludarr/commands/sonarr.py", line 69, in exclude
  File "/usr/local/lib/python3.10/site-packages/excludarr-1.0.2-py3.10.egg/excludarr/core/sonarr_actions.py", line 194, in get_series_to_exclude
KeyError: 'title'

Duplicate of #30 has been fixed in #35 . Going to release v1.0.3 in a couple of minutes with the fix included.

Version v1.0.3 is out!


Docker image creation with yum install mssql-tools reads from tty

[Enter feedback here]
Doing the "yum install -y mssql-tools" on a RHEL Docker container fails because the RPM queries for license acceptance from the tty:  it requires you to type "YES" or "NO".   The standard yum "-y" option has no effect on this.  Is there a way to provide license acceptance in a Dockerfile?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39bb4ba1-ae62-07a3-f79a-138f14cf2f10
Version Independent ID: beaa4e7d-e771-cc96-0e59-34d9b1d5e8cc
Content: Install SQL Server command-line tools on Linux - SQL Server
Content Source: docs/linux/sql-server-linux-setup-tools.md
Product: sql
Technology: linux
GitHub Login: @VanMSFT
Microsoft Alias: vanto

Hi @johnpyrce - Thanks for the question. The command-line tools should be included as part of the docker SQL Server images. https://docs.microsoft.com/sql/linux/sql-server-linux-docker-container-deployment?view=sql-server-ver15&pivots=cs1-bash#tools-inside-the-container

@johnpyrce -- please also consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@VanMSFT -- thank you for clarifying.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

Perhaps you don't understand my comment?  I don't think the fact that the
command line tools are in the Docker Sql Server image solves my issue.  I
am creating a Docker Image and loading software into it.  I can't do this
via a script for the SQL Server tools because they insist on having a tty
to prompt about the EULA but there isn't one for a script.  I do not want
to install SQL Server in this Container, so having the tools already
installed in an existing SQL Server container does not help me.
"Yum install" allows a "-y" option to be used to state EULA agreement
without prompting.  That is what the SQL Server tools RPM should support as
well.
Unless you are suggesting that I include the SQL Server Docker image in my
container to get the command line tool?  But the SQL Server container is
100s of MBs which I don't want in order to get what is (probably) a few MBs
of code that I do want.
On Thu, Dec 3, 2020 at 10:29 AM Van To<EMAIL_ADDRESS>wrote:

Hi @johnpyrce https://github.com/johnpyrce - Thanks for the question.
The command-line tools should be included as part of the docker SQL Server
images.
https://docs.microsoft.com/sql/linux/sql-server-linux-docker-container-deployment?view=sql-server-ver15&pivots=cs1-bash#tools-inside-the-container
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/issues/5773#issuecomment-738119980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIWZ2NRAIRQUNHW3G6VFX33SS64HHANCNFSM4UMCOBXQ
.

Hi @johnpyrce - I'm not proficient with RHEL, but in installing mssql-tools into an Ubuntu container I am able to accept the EULA by adding ACCEPT_EULA=Y to the front of my apt-get command. I wonder if this will have the same impact on yum install.
(https://github.com/dzsquared/sql-development-tools/blob/main/.devcontainer/mssql/installSQLtools.sh)


codespell: config, workflow (to check, no autofix) + typo fixes

This was merged into a separate PR that was more up-to-date. Thank you so much!


Issues/#2562

Fixes #2562

@antw Fixed your remarks 👍

The ability to toggle demand on the dynamic demand chart seems to have been broken by these changes. Maybe the @totalDemand variable is now referencing the wrong series?

This is still broken for me; is it working for you? Everything else looks good.

This is still broken for me; is it working for you? Everything else looks good.

Interesting. I think I broke it again, it did work. One moment.

Thanks @grdw; works perfectly now. Merged it! :+1:


Added Black jack

Zero To Mastery - Webblocks 2022 📦📦
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:

Implemented a card game named black jack.

Breaking changes

None

Screenshots

@MattCSmith Fixed the issue mentioned above and created a new file named meta.json.


accessibility bug of 200% zoom

observation:-
table at 100% zoom

table at 200% zoom columns are hidding

requiement:-
at 200% zoom columns should not hide

Removed XS Specific styles for now. You should see scrollbars.


No error message when internet is not working

Please include:

Operating System: Ubuntu 16.04

Clear steps to reproduce the issue:
When we get disconnected to the internet and click on login button it opens up a blank page without showing any error and when we are again connected to the internet, we have to click on reload for the app to show something again.

Relevant error messages and/or screenshots

Even when the app starts it shows a blank screen. A good user experience would be to add a message that tells the user that the messages are being fetched from the server.

It's a known issue. Probably we should first check the internet connection through window.navigator.onLine or something and then proceed further.

Claiming

@jajodiaraghav do you want to work on this?

Yes. Will submit a PR soon!

Awesome. Let me know if you need any help.

This might be helpful.
@akashnimare, @jajodiaraghav
https://www.npmjs.com/package/is-online

@jajodiaraghav you can use @zulipbot  claim to claim an issue.


RELATED_IMAGE_AUTHORINO env var

What
Authorino image can be read from RELATED_IMAGE_AUTHORINO env var. Defaults to quay.io/kuadrant/authorino:latest
Required to specify the authorino image from the CSV manifest
The authorino image being used in the deployment is read from different sources with some order of precedence:

Authorino CR's spec.image
RELATED_IMAGE_AUTHORINO env var
Value set at  the operator  compilation time passed as ldflags -X github.com/kuadrant/authorino-operator/controllers.DefaultAuthorinoImage=VALUE
quay.io/kuadrant/limitador:latest

Verification steps
run cluster
kind create cluster --name authorino-operator-system

install CRDs
make install

run operator locally with specific RELATED_IMAGE_AUTHORINO env var.
RELATED_IMAGE_AUTHORINO=quay.io/kuadrant/authorino:v0.18.0 make run

Create authorino object without spec.image to deploy version from env var.
k apply -f - <<EOF
apiVersion: operator.authorino.kuadrant.io/v1beta1
kind: Authorino
metadata:
  name: authorino
spec:
  listener:
    tls:
      enabled: false
  oidcServer:
    tls:
      enabled: false
EOF

Check authorino's version is quay.io/kuadrant/authorino:v0.18.0
$ kubectl get deployments authorino -o jsonpath='{.spec.template.spec.containers[0].image}'

The response should be
quay.io/kuadrant/authorino:v0.18.0

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.47%. Comparing base (66594a6) to head (9a9df11).

Files with missing lines
Patch %
Lines

controllers/authorino_controller.go
25.00%
4 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   61.78%   61.47%   -0.32%
==========================================
  Files           2        2
  Lines         785      789       +4
==========================================
  Hits          485      485
- Misses        249      252       +3
- Partials       51       52       +1

Flag
Coverage Δ

unit
61.47% <25.00%> (-0.32%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

supersedes https://github.com/Kuadrant/authorino-operator/pull/174

he requested changes, so I ~cannot~ shoud not merge even with one approval.


Improve pagination performance without using OFFSET.

(moved to here: https://github.com/laravel/ideas/issues/1347)
Currently the pagination logic generates OFFSET LIMIT ? in the SQL.
(see https://github.com/laravel/framework/blob/5.7/src/Illuminate/Database/Eloquent/Builder.php#L746)
which brings a huge performance impact when querying large database.
(See more detail at Faster Pagination in Mysql – Why Order By With Limit and Offset is Slow?)
Please consider to support a cursor based pagination.
We can introduce a new method for cursor based pagination.
The signature of the cursor based pagination would be
public function paginateAfter
(
$cursor, // the value of cursor. for example `212`
$cursorColumn, // the column name of cursor. for example `id`
$perPage = null,
$columns = ['*'],
$pageName = 'page',
$page = null
)

What do you think?
If this is OK to have I'll send a PR for this.

Please use https://github.com/laravel/ideas/issues for proposals.

@staudenmeir Thanks, I copied this one to there.

Please close the issue.