Cannot use mj-include inside mj-head

Starting with mjml 3.2.0, using mj-include inside mj-head does not work any more. We have a common  section for multiple emails, each email including it as in
<?xml version="1.0" encoding="utf-8"?>
<mjml>
    <mj-head>
         <mj-include path="common-mj-attributes.mjml" />
    </mj-head>
[...]

Build does not error out, but prints the somewhat cryptic
Warning: No handler found for: mj-raw, in mj-head, skipping it

message and does not include the attributes. This worked with mjml 3.1.1

Hi @vbraun
Because we change how that works in 3.2 ! It's weird that it mention mj-raw tho..
So now you can just put your mj-attributes inside a mj-head for you common-mj-attributes.mjml like that :
<mjml>
  <mj-head>
    // Every head attributes will be includes in main file
   </mj-head>
</mjml>

That didn't work for me either. I debugged this a bit and it seems to be because we use mjml2html() in code to render the mjml. Then, in includeExternal.js, the var filePath = _ref.filePath; is undefined. Then, a few lines further down, _path2.default.dirname(filePath || process.cwd() is the parent directory of where we launch from. So all path= arguments are not relative to the current directory, but the parent directory of the current directory (this is most likely not intentional).
The second bug is then that <mj-include path=... read errors are not errored out (imho exit with code > 0 would be the right thing to do) but replaced with a '<mj-raw><!-- mj-include: file not found ' + filePath + ' --></mj-raw>';. Hence the uninformative Warning: No handler found for: mj-raw, in mj-head, skipping it.
If I make the <mj-include path=... relative to the parent of the current directory then it works, but that can't be the right way of doing things.

Wait, how do you compile your file with the cli ? The cli should set filePath for you, that's an option that you can pass to mjml2html & mjmlrenderer too.
 I add this to add a comment inside mj-body so you do

Just to clarify, I do not use the cli. I'm using my own script that does import {mjml2html} from 'mjml' and then calls mjml2html in code.

I made #510 to clarify the parent directory issue

Oh... I didn't seen the cwd was parsed by default I'll merge your PR !

3.2.2 has been released with your fix ! So I can close this now

I'm somehow experiencing the same issue ...
But I'm on v3.3.5
Node - ./testing.js
const fs = require("fs");
const path = require('path');
const mjml = require("mjml");

const verifyEmail = fs.readFileSync(path.join(__dirname, "email_templates", "verifyEmail.mjml"), "utf8");
const html = mjml.mjml2html(verifyEmail);
// OUTPUT
// -- Warning: No handler found for: mj-raw, in mj-head, skipping it

./email_template/common-head.mjml
<mj-attributes>...</mj-attributes>
<mj-style>...</mj-style>

./email_template/verifyEmail.mjml
<mjml>
  <mj-head>
    <mj-preview>...</mj-preview>
    <mj-include path="./common-head" />
  </mj-head>
  <mj-body>
    <mj-container>...</mj-container>
  </mj-body>
</mjml>

What could be the problem here?
Using the CLI it mostly works, but sometimes the same error occurs also there.
With nodeJS I get the error everytime.

Running mjml like this, works perfectly fine: .\node_modules\.bin\mjml .\email_templates\verifyEmail.mjml -o  .\test.html

Ok, did some research and found the problem, going to open a new issue.

#986


Fix broken OWL

Fix broken OWL: all values of owl:onClass should actually be owl:allValuesFrom

As an aside, it seems terrible that no OWL tool I could find would clearly and simply tell us "hey! your restrictions have two onFoo properties and no value or cardinality restrictions."
Errors I saw with Robot and Protege were all extremely opaque.


GLES 3.0/3.1 confusion in our implementation

Filament requires OpenGL ES 3.0 only but in gl_headers.h we assert on the fact that OpenGL ES 3.1 headers are present. In addition, MSAA only works with OpenGL ES 3.1 as currently implemented. We should fallback on the extension when running on 3.0 hardware.

I'm looking at this.

Okay so actually requiring the ES31 headers is correct. We should always include the most recent headers so that we can use ES31 features (such as MSAA) natively. In the future we might even require ES32 headers. However, we must MAKE SURE that we're running on an ES30 implementation.


[Bug] [RD] Email alert bug

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I have configured an Email alert but the alert service throws an exception when dispatching an alert email.

What you expected to happen
I expect to send an email whatever the result.
How to reproduce
Just configure an email alert and run a workflow that sends the result when the task is done.
Anything else
I have modified the code and it can send an email when the task is done, so the email alert configuration is fine.

Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Refer to https://github.com/apache/dolphinscheduler/pull/9142


Expand Windows Loader Search Path to Include Paths in User-writable Registry Keys

When discussing how to properly register and activate an implicit layer, @Anteru and I realised there's a gap in support on windows.
On linux the search path goes roughly: /usr/local/, /etc, /usr, then ~/.local. This gives a nice ability to install things system-wide at different levels as well as user-local without root privileges.
But on windows, the search path is only HKEY_LOCAL_MACHINE\SOFTWARE\Khronos\Vulkan (and corresponding Wow6432Node). This is OK for system-wide installation of layers, but it means if a user wants to be able to register a layer without having administrator privileges they are out of luck.
The only options are setting environment variables each time which is awkward and a bit error prone, since I think implicit layers don't get located by VK_LAYER_PATH.
I'd suggest that the search path be expanded to HKEY_CURRENT_USER\SOFTWARE\Khronos\Vulkan with exactly the same ExplicitLayers/ImplicitLayers tree structure. This key can be written by users without escalation, and it can be second in the search order just the same as linux.

Enhancement made in commit 1b9da316f15b56b52cdaae0f5056cca0f9de1791


Fix compatibility with newer versions of SvelteKit and error when there is no prettier config file

Requirements for Contributing a Bug Fix

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

SvelteKit changed the API in regards to how prerendered assets are built.
getPrettierConfig() would attempt to access the config property on a potentially null value.

Description of the Change

Plugin was updated to use the newer version of the API.
getPrettierConfig() now checks if the value is null first.

Verification Process
Packaged it and ran on my own project.
Release Notes

Fix compatibility with newer versions of SvelteKit
Fix error when there is no config file for getPrettierConfig()

Oh wow, I was meant to catch up but didn't have time, so this PR is much appreciated! Due to the API change I'd also suggest bumping the SvelteKit version in the manifest. If you don't use pnpm, npx pnpm <action> <package>should do.

Running pnpm install gave me
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

.
└─┬ @sveltejs/eslint-config
  └── ✕ missing peer eslint-plugin-node@">= 11"
Peer dependencies that should be installed:
  eslint-plugin-node@">= 11"

I'm unfamiliar with pnpm but I'm guessing that this dependency is just missing so I added it. pnpm install eslint-plugin-node
That fixed the error but pnpm install doesn't update SvelteKit (I think this is because of how the version is pinned?). I changed the version to the latest in the package.json (1.0.0-next.391 as of writing), and ran pnpm install again, but this then resulted in another peer dependency missing, this time Vite 3.0.0. I added that and now pnpm install runs and it should be on the newest version of SvelteKit.
I also fixed the issue where the package json was installed instead of json5.

Thanks again for the PR. I will spend some more time looking at the dependency changes and add proper tests before I release a new version.


Out of memory example

Summary
Describe what modifications this PR brings to the project.

Gives more memory to LibTimidity to play MIDI files. Added more songs to the React example to test these limits.
Triggers an error event when library is out of memory or comes across a problem while attempting to load the MIDI file.
Moved the code that fetches instrument patches to their own method.

Checklist
All tasks below must be performed in addition to automated CI/CD checks.

[x] Changes are documented.
[ ] Tests were added, deleted, and/or updated.
[x] Version was bumped with npm run upgrade:patch, npm run upgrade:minor or npm run upgrade:major
[x] Example was updated (if applicable).

I am seeing This webpage is using significant memory. Closing it may improve the responsiveness of your Mac error in Safari starting with version 1.2.0 and my application crashing without loading in mobile Safari, something is not right with this change.
Version 1.1.23 occupies 60Mb in memory and the new one takes more than 1Gb in memory. Page source.

Hi @Ksinia, thank you for your feedback!
Can you open an issue?
I encourage you to use version 1.2.2, which uses less memory. If you're still experiencing issues, I will continue fine-tuning the library to reach a happy medium. There is a lot of room for optimization!
Please note that the library is still not compatible with Safari (issue #136 is still open). I'm planning on fixing this issue on Thursday.


Cherry pick

What changes were proposed in this pull request?
merge code from branch 2.1.0
How was this patch tested?
this code hasn't been test yet

LGTM


Using custom colors in commands like tellraw displays an error

1.16 has added the ability for custom colors to be used in commands like title and tellraw. However, trying to use a custom color will display an error that you're using an unsupported color. I did check in the settings to make sure I was using the MC version (which it was set to 1.16)
Extension Version: 2.1.14
VSC Version: 1.47.2

Didn't see the language server repository, and realized this issue has already been reported. My bad, guess it pays to look around a little more before reporting something.

No worries 😄


Fiddle

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: Tomas Miliauskas:x: tqmukas:x: viliuslTomas Miliauskas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


🐛 [firebase_storage]  [firebase_storage/unknown] An unknown error occurred, please check the server response.

I am Japanese. I'm a beginner, so there are some things I'm unfamiliar with.
sorry
Bug report
Describe the bug
I want to upload an image to firebase cloud storage, but I couldn't because of an unknown error.
I've been struggling with this for a week.
Help me.
Steps to reproduce
Steps to reproduce the behavior:
import 'package:flutter/material.dart';
import 'package:firebase_core/firebase_core.dart';

import 'dart:io';
import 'dart:convert';
import 'package:firebase_storage/firebase_storage.dart';
import 'package:image_picker/image_picker.dart';
import 'package:path_provider/path_provider.dart';

class MainPage extends StatefulWidget {
  @override
  State<MainPage> createState() => _MainPageState();
}

class _MainPageState extends State<MainPage> {
  Image? _img;
  Text? _text;

  // ダウンロード処理
  Future<void> _download() async {
    // ファイルのダウンロード
    FirebaseStorage storage = FirebaseStorage.instance;
    Reference imageRef = storage.ref().child("DL").child("flutter.png");
    String imageUrl = await imageRef.getDownloadURL();
    Reference textRef = storage.ref("DL/hello.txt");
    var data = await textRef.getData();

    // 画面に反映
    setState(() {
      _img = Image.network(imageUrl);
      _text = Text(ascii.decode(data!));
    });

    // ローカルにもファイルを書き込み
    Directory appDocDir = await getApplicationDocumentsDirectory();
    File downloadToFile = File("${appDocDir.path}/download-logo.png");
    try {
      await imageRef.writeToFile(downloadToFile);
    } catch (e) {
      print(e);
    }
  }

  // アップロード処理
  void _upload() async {
    // imagePickerで画像を選択する
    final pickerFile =
        await ImagePicker().pickImage(source: ImageSource.gallery);
    if (pickerFile == null) {
      return;
    }
    File file = File(pickerFile.path);
    FirebaseStorage storage = FirebaseStorage.instance;
    try {
      await storage.ref("UL/upload-pic2.png").putFile(file);
      setState(() {
        _text = const Text("UploadDone");
      });
    } catch (e) {
      print(e);
    }
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text('images'),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              if (_img != null) _img!,
              if (_text != null) _text!,
            ],
          ),
        ),
        floatingActionButton:
            Row(mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: [
          FloatingActionButton(
            onPressed: _download,
            child: const Icon(Icons.download_outlined),
          ),
          FloatingActionButton(
            onPressed: _upload,
            child: const Icon(Icons.upload_outlined),
          ),
        ]));
  }
}

The settings are below

pubspec.yaml

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.2
  firebase_core: ^1.21.1
  cloud_firestore: ^3.4.6
  firebase_auth: ^3.7.0
  firebase_storage: ^10.3.7
  image_picker: ^0.8.5+3
  path_provider: ^2.0.11

ios/podfile

# Uncomment this line to define a global platform for your project
platform :ios, '11.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
  'Debug' => :debug,
  'Profile' => :release,
  'Release' => :release,
}

def flutter_root
  generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'Generated.xcconfig'), __FILE__)
  unless File.exist?(generated_xcode_build_settings_path)
    raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure flutter pub get is executed first"
  end

  File.foreach(generated_xcode_build_settings_path) do |line|
    matches = line.match(/FLUTTER_ROOT\=(.*)/)
    return matches[1].strip if matches
  end
  raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Generated.xcconfig, then run flutter pub get"
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_ios_podfile_setup

target 'Runner' do
  pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => '9.4.0'
  use_frameworks!
  use_modular_headers!

  flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
  end
end

The rule settings for firebase cloud storage are as follows
rules_version = '2';
service firebase.storage {
  match /b/{bucket}/o {
    match /{allPaths=**} {
      allow read, write: if
          request.time < timestamp.date(2022, 10, 6);
    }
  }
}

I also tried this and got an error
rules_version = '2';
service firebase.storage {
  match /b/{bucket}/o {
    match /{allPaths=**} {
      allow read, write: if true;
    }
  }
}

Expected behavior
if i try on android
I can upload images but the following is in the debug console
E/SurfaceSyncer( 5902): Failed to find sync for id=1
E/SurfaceSyncer( 5902): Failed to find sync for id=2
E/SurfaceSyncer( 5902): Failed to find sync for id=3
E/StorageUtil( 5902): error getting token java.util.concurrent.ExecutionException: com.google.firebase.internal.api.FirebaseNoSignedInUserException: Please sign in before trying to get a token.
W/StorageUtil( 5902): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
W/NetworkRequest( 5902): no auth token for request

In the case of ios simulator it is not possible due to an error
 [firebase_storage/unknown] An unknown error occurred, please check the server response.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.0, on macOS 12.5 21G72 darwin-x64, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.2)
[✓] Connected device (4 available)
[✓] HTTP Host Availability

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.18.0
Flutter SDK 3.3.0
flutter_application_3 1.0.0+1

dependencies:
- cloud_firestore 3.4.6 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cupertino_icons 1.0.5
- firebase_app_check 0.0.7 [firebase_app_check_platform_interface firebase_app_check_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 3.7.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.21.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_storage 10.3.7 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- image_picker 0.8.5+3 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- path_provider 2.0.11 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]

dev dependencies:
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- async 2.9.0 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.1
- clock 1.1.1
- cloud_firestore_platform_interface 5.7.3 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.8.6 [cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.16.0
- cross_file 0.3.3+1 [js meta]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.1
- file 6.1.4 [meta path]
- firebase_app_check_platform_interface 0.0.4+15 [firebase_core flutter meta plugin_platform_interface]
- firebase_app_check_web 0.0.6+4 [firebase_app_check_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 6.6.0 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 4.3.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.5.1 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 1.7.2 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_storage_platform_interface 4.1.15 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.3.5 [async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_plugin_android_lifecycle 2.0.7 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- http 0.13.5 [async http_parser meta path]
- http_parser 4.0.1 [collection source_span string_scanner typed_data]
- image_picker_android 0.8.5+2 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.8 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.6 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.1 [cross_file flutter http plugin_platform_interface]
- intl 0.17.0 [clock path]
- js 0.6.4
- lints 2.0.0
- matcher 0.12.12 [stack_trace]
- material_color_utilities 0.1.5
- meta 1.8.0
- path 1.8.2
- path_provider_android 2.0.20 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.11 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.7 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.6 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.4 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.3 [ffi flutter path path_provider_platform_interface win32]
- platform 3.1.0
- plugin_platform_interface 2.1.2 [meta]
- process 4.2.4 [file path platform]
- sky_engine 0.0.99
- source_span 1.9.0 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.1 [source_span]
- term_glyph 1.2.1
- test_api 0.4.12 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.1 [collection]
- vector_math 2.1.2
- win32 3.0.0 [ffi]
- xdg_directories 0.2.0+2 [meta path process]

Thanks for the report @sudama-221
From the error log, it seems atleast on Android side, the error is meaningful and is throwing:
E/StorageUtil( 5902): error getting token java.util.concurrent.ExecutionException: com.google.firebase.internal.api.FirebaseNoSignedInUserException: Please sign in before trying to get a token.
W/StorageUtil( 5902): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
W/NetworkRequest( 5902): no auth token for request

But on iOS:
It throws a general unknown error: [firebase_storage/unknown] An unknown error occurred, please check the server response.
But it does indicate that it might be related to server's response while trying to fetch the data through dart, but somehow the server isn't able to provide the data.
Do you have fast internet connection / service provider ? Can you also perhaps try on a different fast network or with a different service provider and see if you still get same error or not ?

Thank you for your answer
When I logged in with firebase auth on Android, I got the following error
W/StorageUtil(12776): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
D/TrafficStats(12776): tagSocket(119) with statsTag=0xffffffff, statsUid=-1
W/StorageUtil(12776): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.

On iOS I get the same error even if I log in
Do you need AppCheck?
The connection environment is using Wi-Fi
I tried it with a new program, but it didn't work.
I'm trying the iOS simulator on iphone 13 pro, is it related?

I got this error when I tried the example of the library called firebase_storage.
https://pub.dev/packages/firebase_storage
WARNING: Unable to set the Firebase Storage emulator settings. These must be set before any usages of Firebase Storage. If you see this log after a hot reload/restart you can safely ignore it.
flutter: [firebase_storage/unknown] An unknown error occurred, please check the server response.

There are other people also struggling with the same error.
https://www.reddit.com/r/flutterhelp/comments/wty1z2/firebase_storage_emulator_doesnt_work_with_ios/
https://stackoverflow.com/questions/73434335/storage-emulator-issue-unhandled-exception-firebase-storage-unknown-an-unkno
Please give me a solution!

W/StorageUtil(12776): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.

For this, try this solution and see if it helps.

WARNING: Unable to set the Firebase Storage emulator settings. These must be set before any usages of Firebase Storage. If you see this log after a hot reload/restart you can safely ignore it.
flutter: [firebase_storage/unknown] An unknown error occurred, please check the server response.

This could be related to firebase tools and not with client (flutterfire). Can you confirm what version of firebase tools are you using. Make sure they are on latest versions.

I got this error when I tried the example of the library called firebase_storage.

We aren't doing anything with storage emulators and the warning / error seems to be coming from firebase tools as I mentioned earlier and you should reach out to them for further resolution. https://github.com/firebase/firebase-tools/issues

Thank you for your answer.
After trying various things by myself, I succeeded with [putData]
I'll post the code for anyone else wondering.
final ImagePicker picker = ImagePicker();
    final XFile? image = await picker.pickImage(source: ImageSource.gallery);
    imgFile = File(image!.path);
final metadata = SettableMetadata(
        contentType: 'image/jpeg',
        // contentType: 'image/png',
        customMetadata: {'picked-file-path': imgFile.path},
      );
      UploadTask uploadTask;
      Reference ref =
          FirebaseStorage.instance.ref().child('books').child('/hogehoge.jpg');

      try {
        uploadTask = ref.putData(await imgFile.readAsBytes(), metadata);
        imgUrl = await (await uploadTask).ref.getDownloadURL();
      } catch (e) {
        print(e.toString());
      }

I didn't need AppCheck.
Thank you very much for taking the consultation.
Answer helped me.

Good to know the issue is resolved. Closing.


Sending commands

Is there any option to send command such as Charger Enabled (On/Off) ? I understand that additional pin on ESP would have to be connected to RX on MPPT charger.

Is there any option to send command such as Charger Enabled (On/Off) ? I understand that additional pin on ESP would have to be connected to RX on MPPT charger.

Hi unfortunately not . The protocol used is read only it can't send any commands


DNA_binding_site [sf#131]

Reported by lkajan on 2008-11-18 22:22 UTC
New term request: DNA_binding_site
Similar to SO:0000410 - protein_binding_site.
This new term is to denote residues/regions involved in DNA binding as predicted - for example - by the DISIS method (`Prediction of DNA-binding residues from sequence.', PMID:17646316).
This term is necessary to have the proper feature type definition in a planned DAS server.
Thank you for considering this new term for addition.
Best regards,
Laszlo Kajan

Commented by eilbeck on 2008-12-18 21:06 UTC
There is a term DNA_contact which is_a binding site.
If I add DNA_binding_site as a synonym, would that work for you?
--K

Commented by eilbeck on 2009-01-22 21:06 UTC
Hi laszlo,
I have added DNA_binding_site as a child of binding_site
--KAren

Updated by eilbeck on 2009-01-22 21:06 UTC

status: open --> closed-accepted


Updated README

*Fixed formatting for Utilities and Journal Section headers.
*Added section headers for Format and Examples.
*increased clarity of warning.
*added code block syntax for format.
--
This edit is done as part of an assignment for CMPT 376W

Fantastic changes @KAujla . Keep it up and you could be a top-rate unpaid intern one day.


Samsung phone is booted out when trying to join game

Samsung phone is booted when it tries to join. The other devices that were able to join were the ipod touch and the samsung tablet

refreshed page on samsung tablet and tried to join the game and it said that the game "was full"....did not refresh other devices before trying to rejoin however


python311Packages.reolink-aio: 0.8.5 -> 0.8.6

Diff: https://github.com/starkillerOG/reolink_aio/compare/refs/tags/0.8.5...0.8.6
Changelog: https://github.com/starkillerOG/reolink_aio/releases/tag/0.8.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279710 run on aarch64-darwin 1

4 packages built:

python310Packages.reolink-aio
python310Packages.reolink-aio.dist
python311Packages.reolink-aio
python311Packages.reolink-aio.dist

Result of nixpkgs-review pr 279710 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.reolink
python310Packages.reolink-aio
python310Packages.reolink-aio.dist
python311Packages.reolink-aio
python311Packages.reolink-aio.dist

Result of nixpkgs-review pr 279710 run on aarch64-linux 1

5 packages built:

home-assistant-component-tests.reolink
python310Packages.reolink-aio
python310Packages.reolink-aio.dist
python311Packages.reolink-aio
python311Packages.reolink-aio.dist


Export PDF border on the right side and bottom is wrong

First of all let me tell how much I love this tool. It is awesome to create PDFs online and with such flexibility.
The issue I have is when using File -> Export -> Advanced you can set a Border or padding. If I set this value the border will be correctly applied to the left and upper side but unfortunately the right and lower site are getting cut off.
Obviously the border is not correctly calculated. Should be easy to fix.
Thank you.

I cannot reproduce. Can you please attach a sample
I tried the following file and the results looks good (20 pixels border)
borders.pdf
borders.txt

I've run into the same problem, but only in the desktop version.

I tried to create a sample, but could not reproduce it with a new diagram and the problem seems to go away after restarting the desktop app.  But I have definitely had issues with the bottom and right borders being smaller or missing when exporting PNGs in the desktop version.
I did find a couple of exports that suffered from the bug.  One has no border and the other has a smaller border on the bottom and right.  I generally set the border to 10px.

with PNG exports in the desktop version.


Config gui

Here are the things I noticed when looking over your code:

[ ] 1. On the “Save a config” page, the “name” input box confused me at first; I thought it referred to the name of the agent we are creating a configuration for, not the file name. Clarifying that can help reduce confusion among users.

[ ] 2. The "edit" and "remove" buttons on lines 138-139 do not work. It seems like adding an @click method to lines 138-139 will fix the issue. I have handled editing and removing things from tables as well; Feel free to look at the tables in tables.py to see how I approached it.

[ ] 3. Use Buttons instead of links for page navigation (for consistency).

[ ] 4. Ensure that the files that are being save are of the right type (save_csv_config function; saves as “platform_driver” not “platform_driver.csv”).

[ ] 5. If the file you are creating is going to be nested within a directory, those directories must exist before creation of the file. In line 24 and line 34, the program is trying to open the file within the “configs” directory, which does not exist nor is it created. This produces a “FileNotFoundError.”

[ ] 6. After fixing these things, I think you are good to start implementation into the current code. Do another pull request of this. Things to note:

Classes are nested within classes.py.
Tables as well as any relating functions are nested within tables.py.

The table under "render_config_list" can replace the table on lines 45-68 in tables.py (remove only lines 45-68).
The table under "render_config_form" should be added to tables.py and not replace anything.
The table that I am referring to in tables.py on lines 45-68 is defined in pages.py on line 411.
The save_instance function on line 21 of pages.py takes table rows as data. Handling this data after implementing your code could different to how data was handled before.

Please let me know if you have any more questions or things that need to be clarified. I am always happy to set up a meeting as well to discuss this.


New Measure 39664000 - Graphics Measure for PresentAT Netflix App

New Measure 39664000 - Graphics Measure for PresentAT Netflix App

@anaharris-ms Can you also please merge this file as I don't have access for that?


Include chain break points in returned embedding context

Example of "chain break points":
a chain with +++: no break points.
a chain with +--: break point at (0,1)
a chain with +-+: break points at (0,1) and (1,2)

Codecov Report

Merging #447 (8135c08) into master (13bda5c) will decrease coverage by 2.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   90.52%   87.57%   -2.96%
==========================================
  Files          22       22
  Lines        1520     1521       +1
==========================================
- Hits         1376     1332      -44
- Misses        144      189      +45

Impacted Files
Coverage Δ

dwave/system/composites/embedding.py
96.02% <100.00%> (-1.13%)
:arrow_down:

dwave/system/samplers/leap_hybrid_sampler.py
61.42% <0.00%> (-14.29%)
:arrow_down:

dwave/system/samplers/clique.py
77.35% <0.00%> (-5.04%)
:arrow_down:

dwave/system/samplers/dwave_sampler.py
84.14% <0.00%> (-3.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bda5c...8135c08. Read the comment docs.


adds header for crc-32 element, standardizes global elemement header

CRC-32's header was missing, and I simplified the global header above it to match the EBML Header Elements H2 level heading above.

Oh! This was already done, I must have been working on a stale version! Closing!


[MobileStepper] Add ability to maintain the 3 dots exactly at center of the whole stepper width, whatever is the width of "Back" and "Next"

In you demo page https://material-ui.com/components/steppers/#dots you use words "Back" and "Next", plus an icon for each, so the width of these buttons are exactly the same, so we see 3 dots exactly at middle of the Stepper container.
But if you change the labels by let's say "Previous" and "Next" (or change locale of these labels), then the buttons width is not the same, and the 3 dots move a bit to the right and so they are not centered anymore with the whole Stepper container.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

You could add an option to let developer decide if dots should:

current behaviour: maintain exactly the same space between:
** Back to 3 dots (on the left side of stepper)
** 3 dots to Next (on the right side of stepper)
OR
new behaviour: remain always at middle of stepper

Examples 🌈

import MobileStepper from '@material-ui/core/MobileStepper';

export default function DotsCenteredMobileStepper() {

   ...

  return (
    <MobileStepper
      ...
      variant="dots"
      dotPosition="centered"
      nextButton={
        <Button ... >
          Next
        </Button>
      }
      backButton={
        <Button ... >
          Back
        </Button>
      }
    />
  );
}

Motivation 🔦

This option would help to:

set dot position exactly at the middle of Stepper, so in some cases it could help container design, for example to do some alignment
maintain position of dots if Back/Next buttons label are changing during navigation through steps

Here is one possible approach using CSS grid:
diff --git a/packages/material-ui/src/MobileStepper/MobileStepper.js b/packages/material-ui/src/MobileStepper/MobileStepper.js
index b9a8f7a5b..d359788c5 100644
--- a/packages/material-ui/src/MobileStepper/MobileStepper.js
+++ b/packages/material-ui/src/MobileStepper/MobileStepper.js
@@ -9,9 +9,8 @@ import LinearProgress from '../LinearProgress';
 export const styles = (theme) => ({
   /* Styles applied to the root element. */
   root: {
-    display: 'flex',
-    flexDirection: 'row',
-    justifyContent: 'space-between',
+    display: 'grid',
+    gridTemplateColumns: '1fr auto 1fr',
     alignItems: 'center',
     background: theme.palette.background.default,
     padding: 8,
@@ -79,7 +78,9 @@ const MobileStepper = React.forwardRef(function MobileStepper(props, ref) {
       ref={ref}
       {...other}
     >
-      {backButton}
+

+        {backButton}
+

       {variant === 'text' && (
         <React.Fragment>
           {activeStep + 1} / {steps}
@@ -107,8 +108,9 @@ const MobileStepper = React.forwardRef(function MobileStepper(props, ref) {
           {...LinearProgressProps}
         />
       )}
-
-      {nextButton}
+

+        {nextButton}
+

     </Paper>
   );
 });

However, it doesn't work with IE 11, and not sure about the support of older mobile browsers, which seems to be more important. In your case, you might have to set a wrapping div with a fixed height, until our browser support target allows the above.


Total current year energy not available constantly

Hi,
the annual energy total fails intermittently. It only happens with this sensor:

Now it shows up, now it shows up as unavailable:

Do you have any explanation?
I'am using a northbound account.

Can you enable debug mode?
With that you will see the data that Fusion Solar is returning. If the value is empty ('') or not present the sensor will be unavailable.

Enabled.
This information appears in the home assistant registry section?

I think they should be available under Settings → System → Logs

This is the only trace I see at the moment...
Unexpected error fetching FusionSolarOpenAPIStationYearKpi data: Access frequency to high. failCode: 407, message: ACCESS_FREQUENCY_IS_TOO_HIGH

Ok, wait until the unavailable sensor is available again and then check the logs when it is unavailable again.

Hi again,
this is the only thing I see in the logs, the error is repeated constantly.
Logger: custom_components.fusion_solar.sensor
Source: custom_components/fusion_solar/fusion_solar/openapi/openapi_api.py:194
Integration: FusionSolar ([documentation](https://github.com/tijsverkoyen/HomeAssistant-FusionSolar), [issues](https://github.com/tijsverkoyen/HomeAssistant-FusionSolar/issues))
First occurred: 15:25:19 (17 occurrences)
Last logged: 18:35:19
Unexpected error fetching FusionSolarOpenAPIStationYearKpi data: Access frequency to high. failCode: 407, message: ACCESS_FREQUENCY_IS_TOO_HIGH

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 217, in _async_update_data
    return await self.update_method()
  File "/config/custom_components/fusion_solar/sensor.py", line 655, in async_update_station_year_kpi_data
    response = await hass.async_add_executor_job(api.get_kpi_station_year, station_codes)
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/fusion_solar/fusion_solar/openapi/openapi_api.py", line 125, in get_kpi_station_year
    response = self._do_call(url, json)
  File "/config/custom_components/fusion_solar/fusion_solar/openapi/openapi_api.py", line 194, in _do_call
    raise FusionSolarOpenApiAccessFrequencyTooHighError(
custom_components.fusion_solar.fusion_solar.openapi.openapi_api.FusionSolarOpenApiAccessFrequencyTooHighError: Access frequency to high. failCode: 407, message: ACCESS_FREQUENCY_IS_TOO_HIGH

@jvcsw thanks. This seems to be the same issue as reported in https://github.com/tijsverkoyen/HomeAssistant-FusionSolar/issues/89. I will close this issue, but you can follow in #89
I have a Pull Request ready that I will try to release later today.


The OGMS PURL is broken

The PURL http://purl.obolibrary.org/obo/ogms.owl redirects to a GitHub 404
https://raw.githubusercontent.com/OGMS/ogms/master/src/ontology/ogms.owl
The file is instead currently at:
https://raw.githubusercontent.com/OGMS/ogms/master/ogms.owl

Should be able to fix it here: https://github.com/OBOFoundry/purl.obolibrary.org/blob/master/config/ogms.yml

Hey Dr Hogan!
Was the PURL link above (in the first line) that redirects to 404? At current it goes to a version of OGMS (not sure which one though).
The second URL does lead to a 404.
Just want to make sure I dont break things while trying to fix them.
Thanks,
b.

Brian,
I believe Nico and James took care of this issue.
Bill
On Tue, Aug 17, 2021 at 12:37 PM Brian Aevermann @.***>
wrote:

Hey Dr Hogan!
Was the PURL link above (in the first line) that redirects to 404? At
current it goes to a version of OGMS (not sure which one though).
The second URL does lead to a 404.
Just want to make sure I dont break things while trying to fix them.
Thanks,
b.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OGMS/ogms/issues/166#issuecomment-900453008, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55VUA37HGFQ6XPQI6UTT5KF5RANCNFSM5BY3UN7A
.

Oh Great! Thanks!


How to make redirect from network layer?

Here is my network layer:
function fetchQuery(operation,
                    variables,
                    cacheConfig,
                    uploadables) {
	// return fetch('https://api.graph.cool/relay/v1/cj07pfjjj1nbq0148rutjhxd5', {
	return fetch('http://localhost:3010/graphql', {
		method: 'POST',
		headers: {
			'Accept': 'application/json',
			'Content-Type': 'application/json',
		},
		body: JSON.stringify({query: operation.text})
	}).then(response => {

		if(response.status == 401){
			throw new Error('Network response was not ok.');
// HOW TO MAKE REDIRECT TO LOGIN PAGE HERE?

		}

		return response.json();
	});
}

Help me please!

You wouldn't do the redirect from the network layer. Instead add a route that e.g. throws a RedirectException in render, per https://github.com/4Catalyzer/found-relay/blob/2071b36c445475c367d6ecaf18cce1dfefafab46/test/modern/render.test.js#L144-L147.

@taion I've tried this way, but resolving is undefined always.
props are filled if there is no error
errors are undefined all the time
If error:

if data exist:

May be something wrong with my network layer?

import fetch from 'isomorphic-fetch';
import {
  Environment,
  Network,
  RecordSource,
  Store
} from 'relay-runtime';

function fetchQuery(
  operation,
  variables,
  cacheConfig,
  uploadables
) {
  return fetch('https://api.graph.cool/relay/v1/cj07pfjjj1nbq0148rutjhxd5', {
    method: 'POST',
    headers: {
      'Accept': 'application/json',
      'Content-Type': 'application/json',
    },
    body: JSON.stringify({query: operation.text})
  }).then(response => {
    return response.json();
  }).then(data=>{
    debugger;
    return data;
  });
}

// Create a network layer from the fetch function
const network = Network.create(fetchQuery);
const source = new RecordSource();
const store = new Store(source);

export default new Environment({
  network,
  store
})

You can try it:
https://github.com/CostaRico/graphql-relay
yarn install
yarn relay
yarn dev

Your lockfile has alpha 6. Upgrade to the latest alpha.

@taion if I switch to latest then I get error like here https://github.com/4Catalyzer/found-relay/issues/76
"Cannot read property 'Container' of undefined"
So if I get it right way, I need to switch to "react-relay": ">=0.6.0 <1.0.0", also.
Is it mean I cant use relay modern in this case?
Thx u for your time!

Not latest. Use next.

@taion: My question is really similar to the original one...   I would like to handle the error case when the graphql server is down.. I can catch the error in the network layer but I want to handle it somewhere in the rendering logic. But as I see non of the render method's arguments reflect the http error state..
I've tried to check for props ===  null but sometimes props has null value even when the graphql endpoint is up..  and as I see there is no other relevant/reliable argument to check...
GraphQL down:
{ error: null,   props: null,   retry: null,   resolving: true }
GraphQL up:
{ error: null,   props: object or null, <-- ???   retry: [func],   resolving: true }
@CostaRico: have you solved this at the end?

@peet86 I solved what I've asked originally thx to @taion
But next I've tried to render error messages and it's too difficult.
Finally i've chosen to use redux for a while.
When relay modern will be more mature I try again. :)

@peet86 See https://github.com/facebook/relay/issues/1913. I'm just matching the semantics of <QueryRenderer> here. You'll want to explicitly throw in the network layer.

@taion it would be nice to have some examples
and thx u for all u do!

It would be better for such examples to live upstream for facebook/relay. They're not specific to Found Relay.


Add usage in response like openai?

https://platform.openai.com/docs/api-reference/completions/object#completions/object-usage
What about add usage in trt ensemble models to return the token usage like openai? At lease the prompt and output token length. It would be eaiser to provide an OpenAI compatible API.

https://platform.openai.com/docs/api-reference/completions/object#completions/object-usage What about add usage in trt ensemble models to return the token usage like openai? At lease the prompt and output token length. It would be eaiser to provide an OpenAI compatible API.

Have you solved the problem?

not yet

Do you know how to do it? Any ideas?

I think u could customize the logic in postprocess and preprocess to do the calculation.

I think u could customize the logic in postprocess and preprocess to do the calculation.

Thank you. I tried. It didn't work

I managed to get the output_token_len to the output, but can't add the input_token_len since this information is not directly passed down from the pipeline to the postprocessing model.
Here's how to do it:
We need to create a new output field in the postprocessing model, and make small changes to the code to handle the information retrieval and output.
The first step is to modify the postprocessing\config.pbtxt, add the following content:

output [
  {
    name: "OUTPUT_TOKEN_LEN"
    data_type: TYPE_INT32
    dims: [ -1 ]
  },

  ...

]

Then we need to chagne postprocessing\1\model.py to add logic to output the tensor corresponding to the above output field.

class TritonPythonModel:

    def initialize(self, args):

        ...

        # Parse model output configs
        output_names = ["OUTPUT", "OUTPUT_TOKEN_LEN"]
        for output_name in output_names:
            setattr(
                self,
                output_name.lower() + "_dtype",
                pb_utils.triton_string_to_numpy(
                    pb_utils.get_output_config_by_name(
                        model_config, output_name)['data_type']))

    def execute(self, requests):

        ...

        # Number of tokens
        output_token_len_tensor = pb_utils.Tensor(
            'OUTPUT_TOKEN_LEN',
            np.array(sequence_lengths).astype(self.output_token_len_dtype))
        outputs.append(output_token_len_tensor)

Then, we can modify the ensemble\config.pbtxt, add the new output field to both output fields and the ensemble pipeline, as shown in the following content:
output[
  {
    name: "output_token_len"
    data_type: TYPE_INT32
    dims: [ -1 ]
  },

  ...

]

ensemble_scheduling {
  step [
      {
      model_name: "postprocessing"
      model_version: -1

      ...

      output_map {
        key: "OUTPUT_TOKEN_LEN"
        value: "output_token_len"
      }
  ]
}

you can use https://github.com/npuichigo/openai_trtllm , it is a wrapper to create openai compatible api for tensorRT-LLM

any progress on this issue?


Joining on a column, not index, gives erroneous result

Code Sample, a copy-pastable example if possible
import pandas as pd
d1 = pd.DataFrame({'a': [1, 2], 'b': [11, 22]})
d2 = pd.DataFrame({'a': [1, 2], 'c': ['aa', 'bb']})
d1.join(d2, on=['a'], how='outer', lsuffix='.d1', rsuffix='.d2')

Actual output
     a  a.d1     b  a.d2    c
0  1.0   1.0  11.0   2.0   bb
1  2.0   2.0  22.0   NaN  NaN
1  0.0   NaN   NaN   1.0   aa

Expected Output
   a   b   c
0  1  11  aa
1  2  22  bb

output of pd.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.4.3.final.0
python-bits: 64
OS: Linux
OS-release: 3.19.0-65-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
pandas: 0.18.1
nose: None
pip: 1.5.4
setuptools: 3.3
Cython: None
numpy: 1.10.1
scipy: 0.17.1
statsmodels: 0.6.1
xarray: None
IPython: 4.0.0
sphinx: None
patsy: 0.4.1
dateutil: 2.5.2
pytz: 2016.3
blosc: None
bottleneck: None
tables: 3.2.2
numexpr: 2.4.6
matplotlib: None
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: 0.999
httplib2: 0.9.2
apiclient: None
sqlalchemy: None
pymysql: None
psycopg2: 2.6.1 (dt dec pq3 ext lo64)
jinja2: 2.8
boto: None
pandas_datareader: None

yeah looks strange. merge should work though...
pd.merge(d1, d2, on='a', how='outer')
#    a   b   c
# 0  1  11  aa
# 1  2  22  bb

There is also a problem with the overlapping columns detection:
In [11]: d1.join(d2, on=['a'])
...
ValueError: columns overlap but no suffix specified: Index([u'a'], dtype='object')

as this should of course not be raised if this is the column you want to merge on.

how="inner" also gives unexpected results:
d1.join(d1, on=['a'], how='inner', lsuffix='.d1', rsuffix='.d2')
#    a  a.d1  b.d1  a.d2  b.d2
# 0  1     1    11     2    22

d2.join(d1, on=['a'], how='inner', lsuffix='.d1', rsuffix='.d2')
#    a  a.d1   c  a.d2   b
# 0  1     1  aa     2  22

you just need a simple concat or merge here.
In [4]: pd.concat([d1,d2],axis=1)
Out[4]:
   a   b  a   c
0  1  11  1  aa
1  2  22  2  bb

In [5]: pd.merge(d1,d2, on=['a'], how='outer')
   ...:
Out[5]:
   a   b   c
0  1  11  aa
1  2  22  bb

Here is what on does.
on : column name, tuple/list of column names, or array-like
    Column(s) in the caller to join on the index in other,
    otherwise joins index-on-index. If multiples
    columns given, the passed DataFrame must have a MultiIndex. Can
    pass an array as the join key if not already contained in the
    calling DataFrame. Like an Excel VLOOKUP operation

So this has to do with the overlapping detection. I think this should just raise as its fundamentally a user error here. This is not a join/merge rather a concat; here the difference matters.


moved users folder to be consistent

moved users folder to user to be more consistent
@alex-glv

closing no longer relevant.


Add support for MicrosoftEdge

Add MicrosoftEdge to browser list to use path '/'
Follow rules for this images : https://aerokube.com/images/latest/#_microsoft_edge
'edge.desktop': {
      browserName: 'MicrosoftEdge',
      dockerImage: edgeDockerImage,
      viewport: { height: 768, width: 1366 },
    },

Thank you for your contribution ❤


Feature/ab#205 correct error saverelation

Prevent updating the whole entity when only position changed. An optimistic lock exception was thrown otherwise because of relation updates.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Bug: https://dev.azure.com/starwit/lj-projectbuilder/_backlogs/backlog/lj-projectbuilder Team/Features/?workitem=224

Bug: https://dev.azure.com/starwit/lj-projectbuilder/_backlogs/backlog/lj-projectbuilder Team/Features/?workitem=226


Support Python 3.9 build/tests

For context, RAPIDS is dropping Python 3.8 support in favor of 3.9.
This PR updates the cucim GHAs workflows to build from https://github.com/rapidsai/shared-action-workflows/tree/py-39, which contains updated build/test matrices for Python 3.9.
This branch change will be reverted in a subsequent PR once all of RAPIDS is building and publishing 3.9 packages.

/merge


Add new popup menu that like City Guides by National Geographic

Thanks for your custom map library!
I have custom it with new popup menu to make it looks more beautiful, and now I want to share it with you.
Thanks again!

This is pretty cool, however to get it merged it will need tests and documentation. Maybe you just want to add this to a demo project instead of extending the library proper? Either way you need to fix the build.

Thanks!
I will close this request and create a new one.


ClickOnce deployment --> missing dlls

Describe the bug
When deploying a C# application using the Microsoft.CognitiveServices.Speech NuGet, only the Microsoft.CognitiveServices.Speech.csharp.dll is sent to the output
To Reproduce
Steps to reproduce the behavior:

Create a new C# console (.NET Framework) project
Add Microsoft.CognitiveServices.Speech NuGet to the project
Build
Check the output directory --> All references are present
Publish
Check the publish directory --> Only the ***.Speech.csharp.dll is present

Expected behavior
This list of dlls should be present in the publish directory:

Microsoft.CognitiveServices.Speech.core.dll
Microsoft.CognitiveServices.Speech.csharp.dll
Microsoft.CognitiveServices.Speech.extension.audio.sys.dll
Microsoft.CognitiveServices.Speech.extension.codec.dll
Microsoft.CognitiveServices.Speech.extension.kws.dll
Microsoft.CognitiveServices.Speech.extension.lu.dll
Microsoft.CognitiveServices.Speech.extension.mas.dll

Version of the Cognitive Services Speech SDK
1.20.0 (same issue ith 1.19.0)
Platform, Operating System, and Programming Language

OS: Windows 11 Pro
Programming language: C#, VS2022, .NET Framework 4.7.2

Additional context

When trying to use the cognitive services from a client using ClickOnce deployment and checking the output using the Remote Tools for VS, you can see that the application can't find the ***.Speech.core.dll and so you can't start a speech recognition

Thanks for trying the Microsoft Cognitive Services Speech SDK. Including native dependencies from Nuget packages when using ClickOnce to publish an application seems to be a general pain point.
The workaround is to explicitly add the native dependencies to your project as "Content", at which point the publish step will pick up those file. Specifically, open up your project file (.csrpoj) in your text editor of choice and can add the following just before the closing </Project> at the end:
  <ItemGroup>
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.core.dll" />
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.extension.audio.sys.dll" />
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.extension.lu.dll" />
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.extension.kws.dll" />
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.extension.codec.dll" />
    <Content Visible="false" Include="$(SpeechNativeDllDir)\Microsoft.CognitiveServices.Speech.extension.mas.dll" />
  </ItemGroup>

After this, you the needed native DLLs will start showing up in the list of files to publish:

Thanks a lot @ralph-msft . Your suggestion resolved this issue. 👍


[BUG] Limited Display of Profiles in Search Results

Description
Edit:
When searching for profiles using tags such as "open source" or "javascript," the Search results page only displays 20 profiles on a single page. This results in an unappealing layout with one empty space for a profile card. This issue is consistent across the all project pages. Increasing the profile card limit from 20 to 21 would resolve this problem. Please refer to the attached screenshot for visual clarity.
Screenshots
Top

Bottom

Do you want to work on this issue?
Yes
Additional information
Edit:
Currently this is also reflect on the Discover page, but this page is to be removed as shown here: https://github.com/EddieHubCommunity/BioDrop/issues/9341
By increasing the results (changing from an even number to an odd number), this will fix it for three columns but break it for two columns. However as the two column size is less used, this can be ignored for now (and will be fixed as part of the upcoming redesign).

@Shiva-Sai-ssb thank you for raising.  Please see my edits and comments in the Issue description.
Could you please explain your proposed solution.

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description.
Could you please explain your proposed solution.

I'm new to this project. When I looked at the BioDrop website, I noticed an empty spot where a profile could go. So, I made a request to add a profile there. Yes, if we split it into two columns, there will be even more empty space because the profiles are small. The only way I can think of fixing this is by adding one profile.

@Shiva-Sai-ssb thank you for raising. Please see my edits and comments in the Issue description.
Could you please explain your proposed solution.

I'm new to this project. When I looked at the BioDrop website, I noticed an empty spot where a profile could go. So, I made a request to add a profile there. Yes, if we split it into two columns, there will be even more empty space because the profiles are small. The only way I can think of fixing this is by adding one profile.

Thank you @Shiva-Sai-ssb  - but by "explain your proposed solution" I meant, what section of code would you change.
Here is the section of the code that needs changing:
https://github.com/EddieHubCommunity/BioDrop/blob/553bed87c1023c8be8f76b8e11de7d934bc96854/pages/search.js#L198
I will assign this issue to you.

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

I want to work on this issue please assign me this issue .I hope i could start my first contribution to the community by solving this issue.

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

I want to work on this issue please assign me this issue .I hope i could start my first contribution to the community by solving this issue.

Hi, I've opened this issue and said that I'm ready to work on it. It's my first time contributing to this project, and I'll submit a pull request for it soon. Can you please check out a other issues?

Don't worry @Shiva-Sai-ssb, the issue is assigned to you and I am going to review your PR now


allow the option to use an external pool in MessageDispatcher

Hi, as the title suggests, it would be helpful if the MessageDispatcher could take an external pool as a parameter, instead of always using the static pool. This is especially useful in parallel messaging situations, as I mentioned in #120.

I don't prefer the uppercase POOL either. I left it unchanged because I didn't want to alter the git annotation for such a small change. But since you don't like it, I'll update it to lowercase.

@damcaoson Thanks
@Tom-Ski or any other maintainer. I cannot remember where the build server is. So please, send me this info or merge this PR yourself if the remote build succeeds. Thanks 😄

@davebaol think we will migrate this to GHA, because we are doing that everywhere else.

@Tom-Ski Great, thanks.

Any release plan for this MR ?


Has anyone use tensorboardX to visualize network structure? Some problem about the  process of visualizing.

I want to visualize the M2Det network, using the following code.
from configs.CC import Config
from layers.functions import Detect, PriorBox
from m2det import build_net
from tensorboardX import SummaryWriter
from torch.autograd import Variable
from utils.core import *

cfg = Config.fromfile('configs/m2det512_vgg.py')
net = build_net('test',
                size = cfg.model.input_size,
                config = cfg.model.m2det_config)
dummy_input = torch.rand(13, 3, 512, 512)
with SummaryWriter(comment='M2Det') as w:
   w.add_graph(net, (dummy_input, ))

It would raise the error TypeError: conv2d(): argument 'input' (position 1) must be Tensor, not tuple
but when I change the last line to
w.add_graph(net, dummy_input)
it would raise ValueError: Auto nesting doesn't know how to process an input object of type str. Accepted types: Tensors, or lists/tuples of them
Anyone have the experience to visualize the network structure? Please help me , Thx

hi, You can modify some codes in m2det.py to solve this problem.
From:
self.leach = nn.ModuleList([BasicConv(
deep_out+shallow_out,
self.planes//2,
kernel_size=(1, 1), stride=(1, 1))]*self.num_levels)
To:
self.leach = nn.ModuleList([BasicConv(
deep_out+shallow_out,
self.planes//2,
kernel_size=(1, 1), stride=(1, 1)) for _ in range(self.num_levels)])


Use dark text on lighter images

I noticed some of the text was very hard to read when on languages with lighter colours. So now the script will take into account how bright the colour is before generating the via.placeholder.com URL.
Triggers to black text if the colour's brightness is over 65% percent. Function is_dark is defined as:
def is_dark(color):
    # l = (0.2126 * R + 0.7152 * G + 0.0722 * B)
    c = {
        'r': int(color[0:2], 16),
        'g': int(color[2:4], 16),
        'b': int(color[4:6], 16)
    }
    l = (0.2126 * c['r'] + 0.7152 * c['g'] + 0.0722 * c['b'])
    return False if l / 255 > 0.65 else True

print(is_dark('444444')) # true
print(is_dark('eeeeee')) # false

This is simplified in the actual code. Colour multipliers are from here.
This PR/Commit also includes the regenerated colors.json and README.md.

Neat :)


[pick 2421 r1.29] Move guardian hash annotation to podTemplate

The hash is added so that pods will be updated if any secrets or configmaps are updated, like the CA bundle, if it is on the deployment the annotation is updated with no pod update but with it on the podTemplate then the pod will be redeployed so it will pick up the changes.
Picking #2421
Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

The CI ran out of time because it was waiting so long for CI capacity. I'm going to merge this anyway.


Make this project source installable via Pip

Is your feature request related to a problem? Please describe.
Originally requested by @TMiguelT in #119. The goal is to be able to pip install -U git+https://github.com/triaxtec/openapi-python-client.git.
Describe the solution you'd like
Auto-generate a setup.py from pyproject.toml using GitHub Actions so it's kept up to date.
Additional context
This will probably also make this installable via pipx from source.

As I said elsewhere, I think with pip 19.0 onwards, this should just work automatically, as long as you define the [build-system] section correctly: https://pip.pypa.io/en/stable/reference/pip/#pep-517-and-518-support. Because then pip understands that it needs poetry in order to build the package.

Oh interesting, I knew it could read some data from pyproject.toml but didn't realize you could tell it to require packages. I'll give this a shot for sure.

Awesome, it works! Thanks @TMiguelT, I'll probably do something similar for #120 in the short term too.


Deadlocking with rwlock

Hello,
I have run into some strange behaviour where rayon seems to deadlock when interacting with a rwlock. I have seen other issues such as this https://github.com/rayon-rs/rayon/issues/592, but it doesn't quite seem to fit the below example.
In the below example we

Let a task acquire a read lock.
Let another task block on acquiring the write lock.
Let several tasks block on acquiring a read lock.

However, the task which successfully acquired the read lock seems to deadlock on its rayon processing, even though there should be available rayon threads to process it. We are only creating CORES / 2 read lock tasks so there should be plenty of rayon threads which are not blocking on acquiring the read lock.
use parking_lot::RwLock;
use rayon::iter::ParallelIterator;
use rayon::prelude::IntoParallelRefIterator;
use rayon::ThreadPoolBuilder;
use std::sync::Arc;
use std::thread::sleep;

pub const CORES: usize = 16;

#[derive(Debug)]
struct Engine {
    data: u64,
}

fn main() {
    ThreadPoolBuilder::new()
        .thread_name(|i| format!("rayon-thread-{}", i))
        .build_global()
        .unwrap();

    let engine = Arc::new(RwLock::new(Engine { data: 0 }));

    rayon::spawn({
        let engine = engine.clone();
        move || loop {
            {
                // Attempt to acquire the lock after the first read task below has acquired the read lock.
                sleep(std::time::Duration::from_millis(50));
                println!("Acquiring write lock");
                let mut lock = engine.write();
                println!("Writing data");
                lock.data += 1;
            }
            println!("Data written");
            sleep(std::time::Duration::from_secs(3));
        }
    });

    let tasks: Vec<_> = (0..CORES / 2).collect();
    for task_number in &tasks {
        // The first task wont sleep and will acquire the read lock before the above write task attempts to acquire the write lock.
        sleep(std::time::Duration::from_millis(*task_number as u64 * 100));
        my_task(*task_number, engine.clone());
    }

    sleep(std::time::Duration::from_secs(1_000));
}

fn my_task(task_number: usize, lock: Arc<RwLock<Engine>>) {
    rayon::spawn(move || {
        let thread = std::thread::current();
        println!("Attempting to acquire lock task={} on thread={}", task_number, thread.name().unwrap());

        let data = lock.read();
        println!("Successfully acquired lock task={}", task_number);
        sleep(std::time::Duration::from_millis(1_000));
        let mut list = Vec::new();
        list.extend(0..CORES);
        let _: Vec<_> = list
            .par_iter()
            .map(|idx| {
                let binding = std::thread::current();
                sleep(std::time::Duration::from_secs(1));
                println!("Task={} thread={} processing it={}", task_number, binding.name().unwrap(), idx);
                idx
            })
            .collect();
        let thread = std::thread::current();
        // This never prints.
        println!("Processing completed task={} thread={} data={:?}", task_number, thread.name().unwrap(), *data);
    });
}

I think it is the same fundamental issue as #592. Your task that's holding the read lock is splitting into many recursive joins via par_iter. When the first part of a join finishes, it will wait for its other half to finish as well, so it enters work-stealing. If that steals another read-lock job, it will block due to the waiting writer, and that's a deadlock since it prevents the current reader from finishing.
If you attach a debugger, it should be possible to see this in the thread backtraces.
Since you're using parking_lot, you could work around it in this particular example by calling read_recursive instead, since that ignores waiting writers -- "starving" them.


[Question]: how to start this project without using Docker?

Describe your problem
Would you like to know how to start this project without using Docker? Additionally, I'd like to ask how to check the running commands when Docker is used to start the project.

Please checkout docker/entrypoint.sh.
Commands in it are all about start the system.

Here's the doc: https://github.com/infiniflow/ragflow/blob/main/docs/guides/develop/launch_ragflow_from_source.md

hello, did you make it


Main HTML page

as a developer, when I load the main HTML page
Then  I am presented with a header including a title, a quote generator button, and a Happy image button
When I click on the quote generator button, a random quote is generated
When I press the Happy image button,
Then a happy image is displayed
When the user inputs daily feelings into the user input card
then they can save all to local storage
When The display previous motivational logs button is clicked
then we are navigated to the history HTML page for stored data to be displayed


[EPIC] Tx list and modals redesign

What it solves
Resolves https://github.com/gnosis/safe-react/issues/2995

[x] #2990
[x] #2989
[x] #3067
[x] #3061
[x] #3082
[x] #3375

How this PR fixes it
This PR includes the final version of [EPIC] Improving tx info/data to be tested before merging into dev
How to test it
Tx list and modals shall include more tx advanced data and display the new design as per the Figma files:
Tx List

https://www.figma.com/file/47wkjxMZkyEeCRbCrLJBJa/safe%232995-Tx-details?node-id=2%3A27

Modals

https://www.figma.com/file/47wkjxMZkyEeCRbCrLJBJa/safe%232995-Tx-details?node-id=135%3A3120

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

30 of 76 (39.47%)  changed or added relevant lines in 19 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.1%) to 33.502%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logic/safe/transactions/txHistory.ts
1
2
50.0%

src/routes/safe/components/Transactions/TxList/InfoDetails.tsx
1
2
50.0%

src/routes/safe/components/Transactions/TxList/MethodValue.tsx
0
1
0.0%

src/routes/safe/components/Transactions/TxList/TxInfo.tsx
1
2
50.0%

src/routes/safe/components/Transactions/TxList/TxInfoMultiSend.tsx
0
1
0.0%

src/utils/camelCaseToSpaces.ts
1
2
50.0%

src/routes/safe/components/Transactions/TxList/TxInfoCreation.tsx
1
3
33.33%

src/routes/safe/components/Transactions/TxList/MethodDetails.tsx
0
4
0.0%

src/routes/safe/components/Transactions/TxList/styled.tsx
4
8
50.0%

src/routes/safe/components/Transactions/TxList/TxInfoTransfer.tsx
2
8
25.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/safe/components/Transactions/TxList/hooks/useKnownAddress.ts
1
11.76%

src/routes/safe/components/Transactions/TxList/MethodDetails.tsx
1
15.38%

src/routes/safe/components/Transactions/TxList/TxDetails.tsx
1
3.53%

src/routes/safe/components/Transactions/TxList/TxInfoMultiSend.tsx
1
10.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
3189

Relevant Lines:
8495

💛  - Coveralls

We still have some inconsistencies in the design:

We still have some inconsistencies in the design:

@johannesmoormann Why is this not expected? Contract interaction vs Send funds display different  (https://github.com/gnosis/safe-react/issues/3254)

@DiogoSoaress it is the same type of message, therefore it should have consistency in the design even though the content of the message varies. and, at least for me, the difference looks just bad but maybe to originator herself can chime in here @TanyaEfremova

@johannesmoormann @DiogoSoaress From the design team point of view: even thought the labels are different, these texts serve as titles that draw attention to the context of the transaction, thus may be of the same style .
@liliiaorlenko will provide the mockups

For what I can see in the figma doc, is the "Interact with" that has the wrong format. It should be black text and not capitalized

I notice that other tx have the same problem, in the safe app the text is capitalized and is a light gray, in contrast with the figma design, where the text is black and not capitalize.
Is there a reason why the text are not following the designs in figma (maybe they were that way before and we are leaving it as they are

In figma, the names of the actions of a contract interaction don't have "()" and they are in bold.

Modify spending limit font is too small

Reject and confirm buttons are swapped. "Confirm" should be the button on the left. This is not like that in the figma designs.

@francovenica everything that you pointed was discussed with the designer and tweaked 👍  except the buttons order that ended up being modified in Figma but good catch

@johannesmoormann in this EPIC we've changed the order of "Reject" and "Execute" buttons to have the cancelling action on the left and the approving action on the right, following the same line of thought that we display in the Modal's buttons.
This however raised the question if will be accepted by the users as these 2 buttons are swapped. Can you share your opinion on this?

The issues pointed out regarding text sizes, text color and capitalization were fixed and look good
The only thing we are missing is the decision of if we should swap the buttons confirm/reject (on a personal note, I'd leave them as they are, since they have been like that for years now)

I think we decided to not change the order of the buttons and icons then.

This dropdown for rejections probably shouldn't be here. It shows no estimation fee and nothing to edit, this is because tx rejections don't have anything that can be edited in the advanced options (The nonce is already set in stone by the tx that will be rejected, so you can't edit that one)

This dropdown for rejections probably shouldn't be here.

Can you add an issue for it please @francovenica? We need to keep track of the bugs on the board.

Question before creating an actual issue:
There is no stepper at all when a tx is being created and executed right away (1/x safes).
Probably at least the block or space should be there until it actually loads the owner who created and executed the tx.

There is no stepper at all when a tx is being created and executed right away (1/x safes). Probably at least the block or space should be there until it actually loads the owner who created and executed the tx.

@liliiaorlenko, is this the intended design? I don't know if this is something that was discussed with @DiogoSoaress.

There is no stepper at all when a tx is being created and executed right away (1/x safes). Probably at least the block or space should be there until it actually loads the owner who created and executed the tx.

@liliiaorlenko, is this the intended design? I don't know if this is something that was discussed with @DiogoSoaress.

We didnt discuss it, but if needed lets have the space for it / empty state.

I don't think we should just not show the stepper. It's inconsistent. What are your thoughts? @gnosis/safe-web

The issue is only for those tx that are created in safes 1/x, where there is no list of owners loaded.

This should now be resolved.

The issue is only for those tx that are created in safes 1/x, where there is no list of owners loaded.

This should now be resolved.

Indeed. Now there is a stepper even in those tx that are created and executed right away in safes 1/x. Looks good

The issues reported were fixed:
The stepper during the tx processing for 1/x safes
The extra dropdown for rejection tx's for safes 2/x and 1/x
Being able to edit the adv options for tx in safes 1/x or for the the final signature of the rejection (all fields except the nonce)
The bug introduced that would fail to estimate the gas limit
New issue:
It was recently introduced that Reject tx are now labeled with the name of the safe.
Go to a safe 2/x
Create a tx
Create the rejection of that tx
See the gif:

This is the last issue I found in this EPIC. whenever this is fix I'll pass it to done.

New issue: It was recently introduced that Reject tx are now labeled with the name of the safe instead of an actual rejection.

Couldn't reproduce this issue. It seems that the gateway returned false for isCancellation so we used the destination address (name) as a fallback. Not sure if we can handle it in a better way on our side without additional information outside of isCancellation.

Can you provide the transaction @francovenica?

@usame-algan @DiogoSoaress please fix the lint. 🙏

@usame-algan @iamacook
Here: https://pr3373--safereact.review-safe.gnosisdev.com/app/rin:0x51c125bb0D2FB3394129e4AAa97BbF91e737d9b2/transactions/0x432b6d52ad094a090cb9ed6726c5b76aa085f474d57872ec7487a2d060c07019
There is another in the history tab even, tx 65
https://pr3373--safereact.review-safe.gnosisdev.com/app/rin:0x51c125bb0D2FB3394129e4AAa97BbF91e737d9b2/transactions/history

It looks fine to me:

It looks fine to me:

Probably you don't have the safe named. Also, the deep link should be a "rejection", not a contract interaction

Probably you don't have the safe named. Also, the deep link should be a "rejection", not a contract interaction

You're right:

@katspaugh can you share link to the linter error? I don't see it broken

https://github.com/gnosis/safe-react/pull/3373#issuecomment-1029193710 @DiogoSoaress


Compatibility with JDK 6+

I'm not exactly sure if this is due to apt plug-in anymore, but to be sure I started new project with just a couple of dependdencies. I managed to get the same error I'm now getting on my regular project with courier 1.0.2
Could you check it out?
Here is the repo of test project I mentioned: https://github.com/jkwiecien/CourierAptTest
The exact error I get when rebuilding the project is: Error:Execution failed for task ':app:compileDebugJava'.> java.lang.NoSuchMethodError: javax.lang.model.element.Element.getAnnotationsByType(Ljava/lang/Class;)[Ljava/lang/annotation/Annotation;
An error won't appear if you don't have any courier annotations in the project.

Your test project compiles and runs just fine for me!

I see the problem. The getAnnotationsByType method was only added in java 8. You must be running an older version of the JDK (6 or 7).
There's probably a way for Courier to work without this method, and since Android only requires java 6 I'll take this on board as a compatibility issue.

I'm confused, is java8 supported by android?

No, it's not. Android supports java 7 (since build-tools version 19. java 6 before that).
But the error you are receiving is from the annotation processor (compiler) not from Android. The annotation processor is pure java. In fact, javax.lang.model.element.Element doesn't exist at all in Android (Android doesn't include anything in javax.*).
The annotation processor can use java 8 since it is running on your computer not on your Android device. You can install java 8 without breaking anything. It can still compile against java 7 for your Android code.

How do you use java8 with Android Studio? My app won't run if I just set JDK path in module settings to java8. If it's set to java7 I get the mentioned error. Even if I set java8 as jdk for my machine:
➜  ~  java -version
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)

My app won't run
This is way too vague for me to be able to help you troubleshoot.

I've just made the fix for JDK 7+ support, so hopefully that fixes your issue. compile 'me.denley.courier:courier:1.0.3' should work with JDK 7.
I couldn't go as far as JDK 6, since Android Studio requires JDK 7, but I've set the source to compile for java 6 to maintain support for older Android versions.

JDK7 sounds fine, grat thanks, I'm struggling for days with this, since I'm so excited with this library of yours :)

No worries. I know how frustrating build errors can be. Gradle itself is a pretty steep learning curve. Thanks for helping me make courier more robust and compatible.
I'll close this issue now since I think it's fixed, but feel free to reopen it or keep commenting if something is still not working.


Allow to force usage of CNAME over ALIAS

This adds a flag that forces ExternalDNS to create CNAME records when it could also use ALIAS, which is the current behaviour.
Attempt to solve https://github.com/kubernetes-incubator/external-dns/issues/564#issuecomment-391296405

/lgmt
/approve

LGTM, I think it would be a good idea to add some docs when you want to use this feature.

Our motivation was for example: https://github.com/kubernetes-incubator/external-dns/issues/564#issuecomment-511719652 Did you mean something like that?

Our motivation was for example: #564 (comment) Did you mean something like that?

Yes, that would be great. It would be nice if you could create a new PR for that, then I'll merge this now.

/lgtm

/lgtm

@linki thank you! Where should I document this?

@dbluxo You can add it to the FAQ. There's already something about CNAME with TXT, maybe in that area.


Add closeEditorAtIndex command

Similar to the workbench.action.openEditorAtIndex command, it would be helpful if there was the corresponding
workbench.action.closeEditorAtIndex command.
I am working with dragging "tabs" represented in a tree of editor groups and a closeEditorAtIndex would avoid a lot of code.  Currently, the only close editor commands work on the active editor only - so using that command would require making the editor you want to close (perhaps because you are dragging its tree item to another group, see demo below) the active one, and then resetting the active editor to the previously active editor afterwards for the user.  Same with the various moveEditor commands - it appears they only work on the currently active editor.
My dragHandler code can easily access the indices of the tabs that are selected and dragged.
[The demo uses the TabGroups.move() method which is no longer available, but will hopefully be in the future.]

Even though this talks about adding a command, I feel this belongs more into the new tabs API.

With the tabs API are you not already able to do this?
const group = window.tabGroups[groupIndex];
group.close(group.tabs[tabIndex]);


Export ServiceFn type

Is your feature request related to a problem? Please describe.
The function hyper::service::service_fn uses a private return type, making it more difficult to compose.
Describe the solution you'd like
Make ServiceFn pub.

I second this

For now, I don't think this is likely. service_fn is a simple utility, and if you need to compose with more service things, you likely want the adapter in hyper-util and to use tower::ServiceFn.


Array struct

implement #164
depends on #165

why split up the changes into different prs?

First PR (#165) is not breaking. Just add some sugar.


Java/C++/C#: Add support for BarrierGuards.

This adds support for BarrierGuards similar to the JavaScript dataflow library.  Currently the C# and C++ classes are just stubs, so BarrierGuards won't work there just yet.
This doesn't add any new functionality to dataflow, but makes it easier to specify barriers/sanitizers that arise from guards. In particular it is unnecessary to know about things like SSA variables or the concept of a guard controlling a basicblock.
As an example, the TaintedPath query has been supplied with a !var.contains("..") sanitizer.

This PR also fixes https://github.com/Semmle/ql/issues/1416.

Perhaps add a release note for #1416, since this was a user-reported FP?

Added change note for the java/path-injection improvement.


Update clang-tools to 13.0.0

Checklist

[X] Checked the nixpkgs master branch

[x] Checked the nixpkgs pull requests

Project name
nix search name: nixpkgs.clang-tools

current version: 12.0.1
desired version: 13.0.0
Notify maintainers

maintainers: @aherrmann
Note for maintainers
Please tag this issue in your PR.

Closing because it has been updated.


Server help option

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category:

New Feature

Short description:
Added --help/-h option to server

Let's write .sh test. See /dbms/tests/queries/*.sh


Fixed latency issues with type checking

Hi there,
I thought I could create a pull request for this. I did not want to remove topology completely I just added a custom type checker for Baobab and let all of Baobab use that internally.
So there is no removed code here, only replaced checks. Now we are actually down to 2 ms, where it was at over 600ms.
I thought this could be a good first iteration?

Thanks @christianalfoni! I will give it a look tonight.

Cool :-)
I also run the new version on our framework which has become quite huge, not experienced any problems. That in addition to tests going green of course :-)
Do not feel bad if you think its too much to change or if it is changed not to your liking. I just had to check how much performance I could get out of it.

Merged. I might just change some little thing in type.js to comply with my OCDs.
typology will be removed in favor of a validate routine that can be provided by the user.
I will probably release a 0.3.2 version of the lib before introducing breaking changes.

haha, I know the feeling ;-) Great, thanks for the merge!