wine-wayland: added derivation for building the experimental Wayland driver for Wine

Motivation for this change
Added the necessary derivations and aliases to build the experimental Wayland driver for Wine (from Collabora: https://gitlab.collabora.com/alf/wine/-/tree/wayland). The derivation was based off of the existing derivation for the staging version, as well as the derivation present in this user's flake: https://github.com/cidkidnix/nixcfg/blob/master/flake.nix#L67
This builds the wayland-compatible version for all Wine builds, with a certain caveat still to be solved (hence the draft), with which I request some assistance (more information follows below).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The main issue encountered seems to be related to the wineWow builds. Namely, the build fails with the following errors:
error: builder for '/nix/store/ax5iacw1xxarpadf3zrhy5wmi38xd480-wine-wow-7.0-rc2-wayland.drv' failed with exit code 1;
       last 10 log lines:
       > creating Makefile rules... done
       > configure: creating ./config.status
       > config.status: creating include/config.h
       > config.status: linking /build/source/tools/winewrapper to wine
       > config.status: linking /build/source/tools/winewrapper to wine64
       > config.status: executing include/stamp-h commands
       > config.status: executing tools/makedep commands
       > config.status: executing Makefile commands
       > makedep: error: open /stable/viewporter/viewporter.xml : No such file or directory
       > config.status: error: could not create Makefile
       For full logs, run 'nix log /nix/store/ax5iacw1xxarpadf3zrhy5wmi38xd480-wine-wow-7.0-rc2-wayland.drv'.

From what I could gather, viewporter.xml is provided by the wayland-protocols package, which is included as a buildInput for all appropriate architectures. Note that this error does not occur on neither wine nor wine64 builds. My assumption thus far is that this is caused by the need to link both architectures for the wineWow build, but I have not been able to figure out how to solve this issue.

I believe I have managed to solve the aforementioned issue regarding wineWow builds. Please review this PR, as there may be some remaining issues with the way I went about making this derivation, it might not be the optimal way. Regardless, I will post the nixpkgs-review and test results as soon as they are finished (however, manually building and testing has been successful).

Nice work. I think however if you move the overrides from wayland.nix into base.nix your patch will be much cleaner and a lot more future proof.
I imagine wayland support will make it into other variants some day, so we probably just want a new entry in supportFlags for it.

I did try that beforehand, the reason I decided against it was that it caused massive rebuilds, for every wine variant and every package which has wine as a dependency, regardless of the variant. You can see this through the flags that ofborg added before today's force push (which amended this). I decided to separate it in this fashion to reduce that. If you believe that moving the changes to base.nix would be better for the reasons you specified, I can go back to that approach.

I ended up following @FlorianFranzen's suggestion anyways, as I needed a way to work around the following issue, where the 32-bit version of the vkd3d library wouldn't get linked appropriately, as it was being added internally through callPackage. Since this change would cause the aforementioned rebuilds anyways, I followed through with the rest of the suggestions as well.
checking for -lvkd3d... not found
checking for -lvkd3d-shader... not found
configure: error: vkd3d 32-bit development files not found (or too old), Direct3D 12 won't be supported.
This is an error since --with-vkd3d was requested.
error: builder for '/nix/store/iflxwk0ab0b5vf74yjwhhxkwqbhq4vjm-wine-wow-7.0-rc2-wayland.drv' failed with exit code 1

Result of nixpkgs-review pr 153932 run on x86_64-linux 1

3 packages marked as broken and skipped:

lutris
lutris-free
lutris-unwrapped

22 packages failed to build:

bottles
grapejuice
pipelight
playonlinux
q4wine
winbox
wine (winePackages.full ,winePackages.stableFull ,winePackages.unstableFull)
wine64Packages.base (wine64Packages.stable ,wine64Packages.unstable)
wine64Packages.minimal
wine64Packages.stagingFull
wine64Packages.wayland
wine64Packages.waylandFull
winePackages.minimal
winePackages.staging
wineWowPackages.base (wineWowPackages.stable ,wineWowPackages.unstable)
wineWowPackages.minimal
wineWowPackages.staging
wineWowPackages.stagingFull
wineWowPackages.wayland
wineWowPackages.waylandFull
yabridge
yabridgectl

7 packages built:

wine-staging (winePackages.stagingFull)
wine-wayland (winePackages.waylandFull)
wine64 (wine64Packages.full ,wine64Packages.stableFull ,wine64Packages.unstableFull)
wine64Packages.staging
winePackages.base (winePackages.stable ,winePackages.unstable)
winePackages.wayland
wineWowPackages.full (wineWowPackages.stableFull ,wineWowPackages.unstableFull)

Those build failures are rather strange; could you share the reason for them?

Those build failures are rather strange; could you share the reason for them?

If I had to guess my machine OOM'd :P

Result of nixpkgs-review pr 153932 run on x86_64-linux 1

3 packages marked as broken and skipped:

lutris
lutris-free
lutris-unwrapped

2 packages failed to build:

winePackages.wayland
wineWowPackages.waylandFull

27 packages built:

bottles
grapejuice
pipelight
playonlinux
q4wine
winbox
wine (winePackages.full ,winePackages.stableFull ,winePackages.unstableFull)
wine-staging (winePackages.stagingFull)
wine-wayland (winePackages.waylandFull)
wine64 (wine64Packages.full ,wine64Packages.stableFull ,wine64Packages.unstableFull)
wine64Packages.base (wine64Packages.stable ,wine64Packages.unstable)
wine64Packages.minimal
wine64Packages.staging
wine64Packages.stagingFull
wine64Packages.wayland
wine64Packages.waylandFull
winePackages.base (winePackages.stable ,winePackages.unstable)
winePackages.minimal
winePackages.staging
wineWowPackages.base (wineWowPackages.stable ,wineWowPackages.unstable)
wineWowPackages.full (wineWowPackages.stableFull ,wineWowPackages.unstableFull)
wineWowPackages.minimal
wineWowPackages.staging
wineWowPackages.stagingFull
wineWowPackages.wayland
yabridge
yabridgectl

@GrahamcOfBorg eval

Those build failures are rather strange; could you share the reason for them?

If I had to guess my machine OOM'd :P

Something similar happens to me with nixpkgs-review, where I run out of "disk space" (due to having a tmpfs root, most likely, which means it's actually OOMing). However, building the packages individually works and I can confirmed I have overridden Lutris to use wineWowPackages.waylandFull and it works as intended.
As for Lutris being listed as broken, all I could find was this: https://github.com/NixOS/nixpkgs/pull/155529#issuecomment-1019567947
which suggests it's an unrelated issue to Wine.

Result of nixpkgs-review pr 153932 run on x86_64-linux 1

1 package failed to build:

airwave

32 packages built:

bottles
grapejuice
lutris
lutris-free
lutris-unwrapped
pipelight
playonlinux
q4wine
winbox
wine (winePackages.stableFull ,winePackages.unstableFull)
wine-staging (winePackages.stagingFull)
wine-wayland (winePackages.waylandFull)
wine64 (wine64Packages.stableFull ,wine64Packages.unstableFull)
wine64Packages.base (wine64Packages.stable ,wine64Packages.unstable)
wine64Packages.minimal
wine64Packages.staging
wine64Packages.stagingFull
wine64Packages.wayland
wine64Packages.waylandFull
winePackages.base (winePackages.stable ,winePackages.unstable)
winePackages.minimal
winePackages.staging
winePackages.wayland
wineWowPackages.base (wineWowPackages.stable ,wineWowPackages.unstable)
wineWowPackages.full (wineWowPackages.stableFull ,wineWowPackages.unstableFull)
wineWowPackages.minimal
wineWowPackages.staging
wineWowPackages.stagingFull
wineWowPackages.wayland
wineWowPackages.waylandFull
yabridge
yabridgectl

Seems like this is ready to be merged?

@GrahamcOfBorg eval


Replace testnet with devnet

Description of change
Replaces all references to the testnet with devnet. This includes the network name, default node URL, explorer URL, method specification, examples, and documentation.
This is due to the discontinuation of the Chrysalis P2 testnet in favour of the Chrysalis P2 devnet.
Breaking changes:

Network::Testnet -> Network::Devnet
"test" is no longer a reserved network name
"dev" is now a reserved network name
iota:did:test -> iota:did:dev

Links to any relevant issues
Fixes issue #358
Type of change

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] Enhancement (a non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Fix

How the change has been tested
Created a valid DID using the Network::Devnet, viewable at: https://explorer.iota.org/devnet/identity-resolver/did:iota:dev:GimqiaYtv1aNnxQS3c6sfTst6gakiZg3UwWhxoazQv59
All tests and examples pass locally.
Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

The CI is failing due to the wasm compilation bug, pending fix in PR #404.

Coverage CI failing due to Coveralls outage:

https://coveralls.io/
https://github.com/coverallsapp/github-action/issues/93


Support for native transformation numeric-to-divide

At the moment, it's possible to apply the transformation numeric-to-multiply but not numeric-to-divide. It would be helpful.

Implemented and documented in 1.23.0-beta.68 or on nuget via -Update-Package NBi.Framework -version 1.23.0-beta0068.

Implemented and documented in 1.23.0-beta.68 or on nuget via -Update-Package NBi.Framework -version 1.23.0-beta0068.


[feathr] Add API to materialize features to offline store

Add API to materialize features to offline storage.
Syntax:
client = FeathrClient()
offlineSink =<EMAIL_ADDRESS># Materialize two features into a Offline store.
settings = MaterializationSettings("nycTaxiMaterializationJob",
                                   sinks=[offlineSink],
                                   feature_names=["f_location_avg_fare", "f_location_max_fare"])
client.materialize_features(settings)

This will generate features on latest date(assuming it's 2022/05/21) and output data to the following path<EMAIL_ADDRESS>You can also specify a BackfillTime so the features will be generated for those dates. For example:
backfill_time = BackfillTime(start=datetime(
    2020, 5, 20), end=datetime(2020, 5, 20), step=timedelta(days=1))
offline_sink =<EMAIL_ADDRESS>settings = MaterializationSettings("nycTaxiTable",
                                   sinks=[offline_sink],
                                   feature_names=[
                                       "f_location_avg_fare", "f_location_max_fare"],
                                   backfill_time=backfill_time)

Output sample:

Have one more comment - since we are using protobuf to write the results to online store, would end users need to use protobuf to read the results from the materialized features in offline stores? Or more specifically, how would they use the features that are materialized to offline store?


About rewards() on chance node

Hi, I have one question about the functionality of rewards().
So suppose we have transitions (s1, a1, R1, s2), if I understand correctly, R1 = s2.rewards():
https://github.com/deepmind/open_spiel/blob/77aca74c5459121322caa079dfb6e7eb1ba075c4/open_spiel/spiel.h#L106-L109
However if s2 is a chance node, according to the following comments, s2.rewards() will be forbidden.
https://github.com/deepmind/open_spiel/blob/77aca74c5459121322caa079dfb6e7eb1ba075c4/open_spiel/spiel.h#L325-L344
So in this case, how can we get R1?
One possibility to deal with this case is to store R1 on the next non-chance node: (s1, a1, R1, s2, a_c, s3), where s3 is a non-chance node and R1 = s3.rewards().
However, what if the environment will also render rewards for the players when the chance is taking an action? For example, if the transitions are (s1, a1, R1, s2, a2, R2, s3, a3, R3...) where s2, s3 are all chance nodes, then how can we correctly get the accumulated return?

Currently there is no way to get R1 separately. You have to wait until a non-chance node (say s') and get all the rewards between s1 and s'.  This what s'.rewards() would give.

However, what if the environment will also render rewards for the players when the chance is taking an action? For example, if the transitions are (s1, a1, R1, s2, a2, R2, s3, a3, R3...) where s2, s3 are all chance nodes, then how can we correctly get the accumulated return?

Do you have an example game where this is the case? We decided for simplicity to not allow this, specifically because we could not think of an example where the algorithms would take advantage of the decomposed rewards between chance nodes (in fact, most RL algorithms would not even "see" the chance nodes, the RL environment just hands them the rewards between s1 and s4.

We could revisit this choice if there is a use case being prevented by it, just let us know.


Accept lists of IDs

Modify the CLI to accept multiple IDs from the command line or to read them from a file (separated by either spaces or newlines)

One needs to be a bit careful since the API is rate-limited!

Fixed by https://github.com/mseri/doi2bib/pull/15, the rate limiting is not enabled since the new service seems to be fine with it


tortoise: update opinion within sliding window

closes: https://github.com/spacemeshos/go-spacemesh/issues/3573
closes: https://github.com/spacemeshos/go-spacemesh/issues/2920
depends on: https://github.com/spacemeshos/go-spacemesh/pull/3596

added OnAtx tortoise, similarly to OnBallot and OnBlock.
this handler is required to receive late atxs and expected to be called before ballots that are using referenced atx
are sent to OnBallot
ballots are counted for all layers within the window
all layers within the window are verified on calling TallyVotes (there are optimization options, but they can be made later if needed)
verifying tortoise is reworked so that total good weight doesn't have to be updated after verifying a layer
integrated OnAtx to atx handler

removed code:

separate windows for full and verifying tortoise are removed. as a simplification both modes will use same window
mark good cut routine is removed. approach described #3637 will allow to skip that
outdated tests are removed
background rerun is removed

bors try

bors try

bors try

bors try

bors try

bors try

bors merge


GasConduit = auto not working

EnderIO <IP_ADDRESS>1 and Mekanism <IP_ADDRESS>
S:isGasConduitEnabled=auto the Gas Conduit doesn't show up. Using true it works just fine.

EnderIO 2.2.8 is NOT compatible with Mekanism 8 (as they changed their API and it's not possible to support both versions).
Which means "auto" is working perfectly as it disabled the gas conduits.

Mekanism 7 is way too old. And with out going to the Legacy Downloads the oldest is <IP_ADDRESS> and that's too old as well, and it still doesn't work.
If nothing else it would have been nice to informed about this in the change log that having to set it to true in the configs when using the latest Mekanism.

You're right, I'll hop into my time machine, jump back to last year and put into the changelog: "When Mekanism will change their API to be no longer compatible with the Mekanism API Ender IO is programmed against, you have to do stuff."

Setting that config flag to true will not make EIO 2.2.8 compatible with Mek 8.x either.
You will need to update to the EnderIO 2.3 beta builds when you want to use gas conduits with Mek 8.

Actually setting the flag to true does allow EIO <IP_ADDRESS>1 and Mekanism 8.x to work perfectly fine.
I've tested it, I wouldn't made my last post if I had not tested it or of I had and it didn't work.
I can take screen shots to show you proof if you want.
In the mean time; my test set up was Mekanism Electric Pump over a water source, Rotary Condensentrator turns water into oxygen, then a gas tank. Connections: pump and R.Con. using EIO Ender Fluid and Energy Conduits. R.Con to Gas Tank using EIO Gas Conduit. I even use an EIO creative capacitor bank to power it.

Yes, that's not what we are talking about though. Setting it to true will
not enable gas conduits. This is so that Mek 8 will not crash with them.
On May 20, 2015 1:53 PM, "Wolf68k"<EMAIL_ADDRESS>wrote:

Actually setting the flag to true does allow EIO <IP_ADDRESS>1 and Mekanism
8.x to work perfectly fine.
I've tested it, I wouldn't made my last post if I had not tested it or of
I had and it didn't work.
I can take screen shots to show you proof if you want.
In the mean time; my test set up was Mekanism Electric Pump over a water
source, Rotary Condensentrator turns water into oxygen, then a gas tank.
Connections: pump and R.Con. using EIO Ender Fluid and Energy Conduits.
R.Con to Gas Tank using EIO Gas Conduit. I even use an EIO creative
capacitor bank to power it.
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderIO/issues/2488#issuecomment-103973813
.

Setting it to true DOES enable gas conduits. The recipe works and they work as they should.
The most list of the test instance I've been testing with: http://i.imgur.com/KkUcGFK.png
With the gas conduit in place filling the gas tank: http://i.imgur.com/pOcpGy1.png
With the gas conduit filled with oxygen because the tank is fill: http://i.imgur.com/I8EMibK.png
Now other than a few other mods truly only EIO and Mek are in this instance. However I've also tested with the full pack I'm working with and again it still works just fine.
I'm not trying to rub anyone the wrong way or get on anyone's bad side or whatever. I truly enjoy the mod and truly enjoy helping people find problems and sort them out. But I wouldn't have started this thread if I hadn't tried every possible thing I can think of to show that there is a problem with either the setting that should be working but isn't or that there should have been a note to pack makers to manually set it to true.
If after everything I've said, and now shown, you guys and you still don't believe me, try it for yourself.
And just in case it might matter; the test instance is running Forge 1403 and the pack I'm working with is running Forge 1388.
The only thing that's not working like it does with other conduits is the In/Out mode doesn't let you set anything for the Extract and Insert modes. Here I admit I never really messed with Mek and EIO enough in the past to see if that is normal or not.
Now if there some other reason that I'm missing that you guys say as to why the gas conduits in the above versions of the mods should not be working then please explain in detail what you mean.
The only crash I ever got was with EIO 379 and the same Mek listed above. That's when I got this http://i.imgur.com/E1cqzz4.png
Now to me that says it need Mek 7.0 or 8.0. At first I thought it something I or MultiMC had done to mess up enabling Mek. It was after narrowing down the cause to EIO that I went for the 381 update, which according to it's change log didn't seem like enough of an reason for me to get since my pack doesn't have EE3 but I tried it anyway. It was after that and loading my test world to see gas conduits was missing that started all of this: my testing and this thread.
Please forgive me if I'm seem like a nuisance, that is not my intent. Just trying to help.

As has been pointed out several times - EnderIO 2.2.8 builds ARE NOT compatible with Mekanism 8.
If you use the EnderIO 2.2.8 gas conduits with Mekanism 8 you risk a world corruption. This is the reason they are disabled when Mekanism 8 is detected.

That screenshot should be impossible. Gas conduits force themselves off if
there is no "7" at the beginning of the version number.
On May 20, 2015 4:18 PM, "MatthiasMann"<EMAIL_ADDRESS>wrote:

As has been pointed out several times - EnderIO 2.2.8 builds ARE NOT
compatible with Mekanism 8.
If you use the EnderIO 2.2.8 gas conduits with Mekanism 8 you risk a world
corruption. This is the reason they are disabled when Mekanism 8 is
detected.
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderIO/issues/2488#issuecomment-104022970
.

Ok, "risk a world corruption" an answer that makes sense to me. "Not compatible" in this case makes it sound like "does not work" or "can't be enabled" or anything along those lines. Like saying you cannot connect EIO energy conduits to IC2 machines, which is of course true.
In this case it does work but comes with a risk.
However I would like to say that as far as I know, no one has complained about any world issues and I'm sure there are loads of people using the pack that do the Mek 4x or even 5x ore processing. Granted as of now not using 381 but it is EIO 2.2.8 and Mek 8.1x
@tterrag1098
Not sure what to tell you. Sorry? You're welcome? I don't know.

"No one has complained"? We had 18 issues for this so far. See #2110

Ok fair enough. I meant no one at the forums where the pack I work on is at.


Rerequest permissions (iOS)

Is there any way to have the app rerequest the user for access to the contacts? If not I can document that behavior.

On iOS you can check and/or request the user's permission to access to his contacts: https://github.com/rt2zz/react-native-contacts#permissions-methods-ios-only-optional

@JeanLebrument I'm sorry Jean. That does not answer the issue. Can an app re-request permission after a denial?
I believe it can't. If so I can document it why (ios limitation, whatever).

iOS will not re-prompt the user. If AddressBook access is critical to the application, the best you can do is prompt the user with instructions for how to enable contacts. i.e. Go to your settings and enable...

My bad, I rade request instead of rerequest. I reopen the issue until you found an answer.

I'm running into an issue where even if uninstall the app on my device/simulator, I don't get the permissions dialog, and always getting permissionDenied back from Contacts.getAll.   Also, I don't see Contacts being denied when I look at Settings -> [app name] ... running iOS 9.3.1.   Any ideas on why?

I'm wondering if this is related to iOS 9.3.x, because this was working just fine in a commit in my code base on March 17th.

Nevermind on my 9.3.x theory, just installed the iOS 9.2 simulator and still getting the issue


Allow faster polling of templates when the server supports ETags.

When fetching a template send a If-None-Match header if we previously
received an ETag, then propogate that out so clients can wait less and
skip extracting image data.
This controlls access to writing the template using a work queue so we
don't do updates in the middle of fetching a template.
Haven't tested this yet as the test server is down.

Applied suggested changes except the first one. For that I fixed the type so that the return type of enqueue is the same as the passed in promise.


v2 datamodel KDD syncer isn't filtering host-networked pods

Host networked pods are being passed through to Felix, with a made-up caliABCD interface name, for example:
2017-10-27 02:46:23.388 [DEBUG][76] conversion.go 110: Pod is host networked. pod="kube-proxy-b5l2l"
...
2017-10-27 02:46:23.397 [DEBUG][76] validation_filter.go 50: Validating KV pair. key=WorkloadEndpoint(node=fd-crc-kubeadm-master, orchestrator=k8s, workload=kube-system/kube-proxy-b5l2l, name=eth0) value=&model.WorkloadEndpoint{State:"active", Name:"cali9b0375b0140", ActiveInstanceID:"", Mac:(*net.MAC)(nil), ProfileIDs:[]string{"kns.kube-system"}, IPv4Nets:[]net.IPNet{net.IPNet{IPNet:net.IPNet{IP:net.IP{0xa, 0x80, 0x0, 0x2}, Mask:net.IPMask{0xff, 0xff, 0xff, 0xff}}}}, IPv6Nets:[]net.IPNet(nil), IPv4NAT:[]model.IPNAT(nil), IPv6NAT:[]model.IPNAT(nil), Labels:map[string]string{"controller-revision-hash":"3888521348", "k8s-app":"kube-proxy", "pod-template-generation":"1", "projectcalico.org/namespace":"kube-system", "projectcalico.org/orchestrator":"k8s"}, IPv4Gateway:(*net.IP)(nil), IPv6Gateway:(*net.IP)(nil), Ports:[]model.EndpointPort{}}

Expected Behavior

Host networked pods shouldn't be passed through to Felix (or if there's a reason for passing them through, we need to adjust Felix).
Current Behavior

Felix programs dispatch and per-endpoint chains for the phantom interfaces.  I don't think that has any functional impact, but it does add extra fluff to the dataplane.
Possible Solution

Filter them out in the update processor?
Steps to Reproduce (for bugs)

Context

Your Environment

/ # /sbin/versions
confd v1.0.0-alpha1-rc3
BIRD version 1.6.3
libnetwork-plugin: v1.1.0-28-g20f511e
calico-bgp-daemon: v0.2.2

Felix:
2017-10-27 03:37:51.938 [INFO][656] logutils.go 83: Early screen log level set to debug
2017-10-27 03:37:51.938 [DEBUG][656] felix.go 125: No GOGC value set, defaulting to 20%.
Version:            3.0.0-alpha1-rc1-14-g5075dce9
Full git commit ID: 5075dce9678e46031c22fe7f0278bee7c5d0d9c5
Build date:         2017-10-26T15:25:59+0000

Libcalico-go revision: 3265689af5de15e20427ff12c5dd4a9d1d311e16

From a quick code read, looks like IsCalicoReadyPod() is only being called for Get and List operations but it is omitted form the Watch path.

Upgraded to a P1 because I think this could cause nasty dataplane churn (and confusing logs)


Convert server status endpoint to ninja

@BryonLewis with #243 being merged, this is now the last Ninja conversion. I'll make a follow up PR to this that removes the remaining bits of DRF (mostly DRF exceptions still being used).


HIVE-22239

@kgyrtkirk , I pushed a new commit containing only the range change and addressing your comments ; I will upload a follow-up for the timestamp column stats propagation in a new PR. Can you take another look?


ItemCard: deprecate and replace with composable pieces

The ItemCard was a helper component that wrapped basically a complete Material-UI Card, adding styling and a number of props that were passed down to its constituent parts. This component was not in widespread use, and lacked composability: as a monolith, it could not easily adapt to different circumstances without a prop explosion.
Rather than trying to update it to become even more flexible and to make use of it in place of the various lookalike copies of it, we chose to deprecate it. The suggested usage is now to instead follow the exact structure that the Material-UI docs suggest when making Cards, and to use the new composable little pieces in this PR where appropriate.
Example usage:
<ItemCardGrid>
  <Card>
    <CardMedia>
      <ItemCardHeader title="My Card" subtitle="neat!"

Tugboat has finished building the preview for this pull request!
Link:

https://pr4803-wdtnrn5gfsv4dzwxioopfo2wq69d62t4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6040bcdbfcb22d272767c412

Tugboat has finished building the preview for this pull request!
Link:

https://pr4803-wdtnrn5gfsv4dzwxioopfo2wq69d62t4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6040bcdbfcb22d272767c412

Tugboat has finished building the preview for this pull request!
Link:

https://pr4803-wdtnrn5gfsv4dzwxioopfo2wq69d62t4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6040bcdbfcb22d272767c412

Tugboat has finished building the preview for this pull request!
Link:

https://pr4803-wdtnrn5gfsv4dzwxioopfo2wq69d62t4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6040bcdbfcb22d272767c412

I like this, we have to look how this can be integrated in the tools tab of the explore plugin, but that's something for a later step.

Tugboat has finished building the preview for this pull request!
Link:

https://pr4803-wdtnrn5gfsv4dzwxioopfo2wq69d62t4.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/6040bcdbfcb22d272767c412

@timbonicus  :D

@Fox32 Ah yeah, should be easy.


Squashed commit of github.com/scothis/servicebinding-runtime

There's a lot in here, as the repo was a ground up implementation of the spec but reused the apis, projector and resolver (with light edits). This PR is primarily a place to host a conversation about the code and to consider its inclusion into the RI. I expect there will need to be changes before it would be appropriate to merge.
Signed-off-by: Scott Andrews<EMAIL_ADDRESS>

Codecov Report

Merging #119 (c500f8c) into main (37c5a00) will decrease coverage by 4.33%.
The diff coverage is 77.03%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   86.35%   82.02%   -4.34%
==========================================
  Files           8       14       +6
  Lines         740     1346     +606
==========================================
+ Hits          639     1104     +465
- Misses         76      206     +130
- Partials       25       36      +11

Impacted Files
Coverage Δ

...is/v1beta1/clusterworkloadresourcemapping_types.go
100.00% <ø> (ø)

apis/v1beta1/servicebinding_lifecycle.go
0.00% <0.00%> (ø)

apis/v1beta1/servicebinding_types.go
100.00% <ø> (ø)

dies/v1beta1/clusterworkloadresourcemapping.go
0.00% <0.00%> (ø)

dies/v1beta1/servicebinding.go
0.00% <0.00%> (ø)

projector/binding.go
92.95% <ø> (ø)

projector/mapping.go
100.00% <ø> (ø)

projector/metapodtemplate.go
62.50% <ø> (ø)

resolver/cluster.go
89.02% <81.25%> (-5.81%)
:arrow_down:

controllers/webhook_controller.go
86.41% <86.41%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c5a00...c500f8c. Read the comment docs.

As discussed during todays call:

Is there a place I can find a more comprehensive guide to using reconciler-runtime?  godoc is a good place to start, and the readme has a good amount of information, but I'd like to learn more.

The reconciler-runtime readme and godoc are the best general purpose sources. If you have questions I can answer them.

Why do we need a webhook controller?

The readme in this PR has a section on the architecture and implementation detail
https://github.com/servicebinding/service-binding-controller/pull/119/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R25-R84

Is that how webhook registration is done with reconciler-runtime (as opposed to calling the manager in controller-runtime?

The validation webhook for ServiceBinding resources is unchanged by this PR, the additional webhooks handlers are registered on the webhook server from the manager. For example https://github.com/servicebinding/service-binding-controller/pull/119/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R126


implement simple array buffer allocator

see https://github.com/NativeScript/android-runtime/issues/164

TODO: add unit tests

:+1: Looks good

done with https://github.com/NativeScript/android-runtime/commit/0e39b98701e37bc3131316647794033b145aa94e


llvmPackages_11: 11.0.0 -> 11.0.1

Motivation for this change
https://lists.llvm.org/pipermail/release-testers/2021-January/001436.html
http://lists.llvm.org/pipermail/release-testers/2020-December/001422.html
http://lists.llvm.org/pipermail/llvm-dev/2020-November/146911.html
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build llvmPackages_11

@lovek323 @7c6f434c @primeos I think this is good to go now.

@lovek323 @7c6f434c @primeos I think this is good to go now.

@GrahamcOfBorg build mesa

@GrahamcOfBorg build mesa


Various fixes

I've been using this in production for @Homebrew's MacStadium ESXi installs and thought I'd submit back the various fixes I've made along the way.
Let me know if you have any thoughts or concerns on any of these and thanks for the great tool!

This is awesome, I really appreciate you sharing back these changes. It looks like you handled a lot of little edge cases that I neglected the first time around (I was in a hurry to get some machines running when this tool was created). Including SATA as well as SCSI is a great change too.

Thanks again to you too @pddenhar! Let me know if there's anything else you'd want done to get this merged.

Thanks for the merge ❤


Motion Events - time directory name wrong

Hi, with the new update 0.18 (model y211ga ) the time directory names are wrong , the time set in configuration is right and in the status page is showing the right local time utc+3 (summer time) , but in Motion Events the directory names are created with current time + 3h , e.g. current time is Thu Jun 24 12:57:25 EEST 2021 in status page , but in Motion Events the directory created are:
Date: 2021-06-24 Time: 15:00 - 2021Y06M24D15H

Here is a similar problem.
Dir time is right.
The sytem creation time of dirs and videos has +1 hour.

I confirm the behaviour - I rolled back to not using a local time

Did you noticed this issue only with 0.1.8?

I can tell only for v 0.1.8 as I just receive 2 cameras y211ga and flash them with the latest firmware, will try to test with older 0.1.7 or so.

Please take a snapshot of the motion page and the output of ls command.

FWIW I had differences in time and fixed it by using the app to set UTC0 (GMT) and set the real time zone in Yi-Hack otherwise it's added twice.

FWIW I had differences in time and fixed it by using the app to set UTC0 (GMT) and set the real time zone in Yi-Hack otherwise it's added twice.

Thank you for this hint. I have been looking for the origin of GMT offsets for a long time.

Don't know if it's any help but time offset on my firmware appears to be at 0x0x7F012c, 0x12c in "conf" IIRC. Time zone offset from UTC in seconds.

FWIW I had differences in time and fixed it by using the app to set UTC0 (GMT) and set the real time zone in Yi-Hack otherwise it's added twice.

Hi ghost, I did the same (set "Coordinated universal time" on Yi App, and "EST5EDT,M3.2.0,M11.1.0" on Yi-Hack), but the built-in Yi timestamp (at left top corner) is still wrong.


Mod causes Minecraft to crash on M1 mac

I was able to verify that before installing this mod the game still does not crash.
I have attached the crash log
crash-2023-08-06_10.44.04-client.txt

Analyzing the crash log shows that you're using Simply No Shading 0.6.8 with Sodium 0.4.10. This version of Simply No Shading is made for Sodium 0.5.0, you should instead use 0.6.7. Tell me then if 0.6.7 still crashes

misclick

Thank you! That was indeed the issue, sorry for wasting your time.


Finish Python version

Finish python version with all the features.

Python version is now the only version, the initial goal is being re-worked.


wiring diagram issue PWR_EN

I am trying to determine where I can safely connect external 5V (or if i need to 3.3V ) to the t-display s3 non touch so i can still use a USB cable to connect and program. I noticed the PWR_EN connected to D1 on the right side pf the wiring diagram. The only other place I found this is on pin 20 of the ESP. Is this the only thing it connects to? I would find this unlikely since pin 20 is connected to VDD3V3.
Second question I have: Is 5V input thru a Schottky diode on the battery connector safe as is suggested in another issue?

Have you read this?
https://github.com/Xinyuan-LilyGO/T-Display-S3/issues/205
There may be problems if external 3.3V access and USB are connected at the same time, because USB will also reduce the voltage to 3.3V for T-Display-S3


Loopback

Hi,
The loopback rule was failed by our pen testers as being to generic, I have made this more specific now.
Regards
Mark

Thank you very much for contributing and securing the role! Will deploy 0.2.2.


<EMAIL_ADDRESS>is missing build/ -- only has package.json

Looks like an incorrect publish.
Discovered on Definitely Typed, which has types for rsocket-(tcp|websocket)-(client|server).
Here's the failure from the overnight run: https://dev.azure.com/definitelytyped/DefinitelyTyped/_build/results?buildId=18518
If this is intentional, I'll remove those type packages from Definitely Typed.

Hi @sandersn! Not sure the failure is intentional but type definitions has done my community and seem to be a little incorrect in terms of following the original API. I'm going to take a loot at that thing later this week if it is not that urgent

Well, in this case the types are fine -- 0.0.11 itself is a bad publish. There's no source code shipped with the package! So users who npm install rsocket-tcp-client, for example, will get a broken package.

@OlegDokuka Incorrect publish is for whole 0.0.11 version. At npm all packages have only package.json files:
https://registry.npmjs.org/rsocket-websocket-client/-/rsocket-websocket-client-0.0.11.tgz
https://registry.npmjs.org/rsocket-core/-/rsocket-core-0.0.11.tgz
https://registry.npmjs.org/rsocket-flowable/-/rsocket-flowable-0.0.11.tgz
https://registry.npmjs.org/rsocket-types/-/rsocket-types-0.0.11.tgz
....

@sandersn Sorry for the trouble, could you try again with 0.0.16?

Yep, looks like the latest checks for @types/rsocket-* all passed. Thanks a lot!


Navigation Bar flickering on return transition

I suspect that BottomBar is related to this issue since I've exempted the navigation and status bars from my sliding transition. On the return transition, the navigation bar flashes once and then returns to normal. See attached. Is it possible that there's a problem with the elevation?

This issue was related to transitions (transition overlap set to false). Not to BottomBar. Thanks anyway!


E887: Sorry, this command is disabled, the Python's site module could not be loaded.

Hello, I'm in windows 7 x64.
Before using spf13-vim, python works fine(python print 'test' gives test)
but after setting up spf13-vim, it won't work(E887).
I installed python in D:\Python27, and
python --version gives Python 2.7.11
:ver gives +python/dyn
:set all gives pythondll=python27.dll
:echo has('python') gives 1
:echo has('python3') gives 0
:python print 'test' gives E887 error
I have following lines in .gvimrc,
let $PYTHONHOME='D:\Python27'
let $PYTHONPATH='D:\Python27\Lib'
Anything in spf13-vim's config might cause this problem?
Or any suggestion as to find out the cause of it?
Thanks!

@with0out : try running vim without spf13-vim (via the -u NONE) argument to vim. and then set those python variables. If it still doesn't work then, then it isn't spf13-vim config.

@jrobeson thanks for the tip, -u NONE gave same error,so it's not spf13-vim's fault.


ChatGoogleGenerativeAI:TypeError: Parameter to MergeFrom() must be instance of same class: expected google.ai.generativelanguage.v1beta.FunctionDeclaration got FunctionDeclaration. When trying to bind @tools

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
I am trying to use ChatGoogleGenerativeAI for tool calling and Agentic Ai implimentation
from langchain_google_genai import ChatGoogleGenerativeAI
model_name = "gemini-1.5-flash-001" #"gemini-1.5-pro-latest"
llm = ChatGoogleGenerativeAI(model=model_name,
                              google_api_key=os.getenv('GOOGLE_API_KEY_2'),
                              max_output_tokens = 1024,
                              temperature = 0,
                              verbose=False,
                              )

llm_with_tools = llm.bind(functions = [search_web, split_documents ] )
responce = llm_with_tools.invoke("Search for LangChain on DuckDuckGo")

Below are the tool definations
@tool(parse_docstring=True)
def split_documents(
    chunk_size: int,
    knowledge_base: Annotated[Union[List[LangchainDocument], LangchainDocument], InjectedToolArg],
    chunk_overlap: Optional[int] = None,
    tokenizer_name: Annotated[Optional[str], InjectedToolArg] = config.EMBEDDING_MODEL_NAME
) -> List[LangchainDocument]:

    """
    This method is an implimentation of Text splitter that uses HuggingFace tokenizer to count length.
    This method is to be called for chuncking a Langchain Document/List of Langchain Documents.
    Returns a list of chuncked LangChain Document(s)

    Args:
      chunk_size: "Size of Chunks to be created, in number of tokens.Depends on the Context window length of the Embedding model"
      knowledge_base: "List of Langchain Document(s) to process. To be passed at run time
      chunk_overlap: "Size of overlap between Chunks, in number of tokens"
      tokenizer_name: "Name of the tokanizer model to be used for tokanization before chunking the Langchain Document(s) in knowledge_base"
    """
   # Tool Code

@tool(parse_docstring=True)
def search_web(
    query:str,
    engine:Optional[str]="Google",
    num_results:Optional[int]=5,
    truncate_threshold:Optional[int]=None,
) -> List[LangchainDocument]:

    """
    Performs web search for the passed query using the desired search engine's API.
    This function will then use web scraping to get page content and return them as a list of LangChain documents.

    Args:
      query:"Query to perform Web search for"
      engine: "The search engine to use for the web search"
      num_results: "The number of search results to return from web search"
      truncate_threshold: "Threshold in number of characters to truncate each web pages' content"
    """

   # Tool Code

Error Message and Stack Trace (if applicable)
WARNING:langchain_google_genai._function_utils:Key 'title' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'title' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'title' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'default' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'title' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'default' is not supported in schema, ignoring
WARNING:langchain_google_genai._function_utils:Key 'title' is not supported in schema, ignoring

TypeError                                 Traceback (most recent call last)
 in <cell line: 1>()
----> 1 responce = llm_with_tools.invoke("Search for LangChain on DuckDuckGo")
8 frames
/usr/local/lib/python3.10/dist-packages/langchain_core/runnables/base.py in invoke(self, input, config, **kwargs)
5090         **kwargs: Optional[Any],
5091     ) -> Output:
-> 5092         return self.bound.invoke(
5093             input,
5094             self._merge_configs(config),
/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py in invoke(self, input, config, stop, **kwargs)
275         return cast(
276             ChatGeneration,
--> 277             self.generate_prompt(
278                 [self._convert_input(input)],
279                 stop=stop,
/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py in generate_prompt(self, prompts, stop, callbacks, **kwargs)
775     ) -> LLMResult:
776         prompt_messages = [p.to_messages() for p in prompts]
--> 777         return self.generate(prompt_messages, stop=stop, callbacks=callbacks, **kwargs)
778
779     async def agenerate_prompt(
/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py in generate(self, messages, stop, callbacks, tags, metadata, run_name, run_id, **kwargs)
632                 if run_managers:
633                     run_managers[i].on_llm_error(e, response=LLMResult(generations=[]))
--> 634                 raise e
635         flattened_outputs = [
636             LLMResult(generations=[res.generations], llm_output=res.llm_output)  # type: ignore[list-item]
/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py in generate(self, messages, stop, callbacks, tags, metadata, run_name, run_id, **kwargs)
622             try:
623                 results.append(
--> 624                     self._generate_with_cache(
625                         m,
626                         stop=stop,
/usr/local/lib/python3.10/dist-packages/langchain_core/language_models/chat_models.py in _generate_with_cache(self, messages, stop, run_manager, **kwargs)
844         else:
845             if inspect.signature(self._generate).parameters.get("run_manager"):
--> 846                 result = self._generate(
847                     messages, stop=stop, run_manager=run_manager, **kwargs
848                 )
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/chat_models.py in _generate(self, messages, stop, run_manager, tools, functions, safety_settings, tool_config, generation_config, **kwargs)
964         **kwargs: Any,
965     ) -> ChatResult:
--> 966         request = self._prepare_request(
967             messages,
968             stop=stop,
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/chat_models.py in _prepare_request(self, messages, stop, tools, functions, safety_settings, tool_config, generation_config)
1128             formatted_tools = [convert_to_genai_function_declarations(tools)]
1129         elif functions:
-> 1130             formatted_tools = [convert_to_genai_function_declarations(functions)]
1131
1132         system_instruction, history = _parse_chat_history(
/usr/local/lib/python3.10/dist-packages/langchain_google_genai/_function_utils.py in convert_to_genai_function_declarations(tools)
177         else:
178             fd = _format_to_gapic_function_declaration(tool)
--> 179             gapic_tool.function_declarations.append(fd)
180     return gapic_tool
181
TypeError: Parameter to MergeFrom() must be instance of same class: expected google.ai.generativelanguage.v1beta.FunctionDeclaration got FunctionDeclaration.
Description
I am trying to use ChatGoogleGenerativeAI for tool calling and Agentic Ai implimentation.
With  responce = llm_with_tools.invoke("Search for LangChain on DuckDuckGo") I expect it to call search_web with appropriate arguments.
But instead it give me the following error.
System Info
System Information

OS:  Linux
OS Version:  #1 SMP PREEMPT_DYNAMIC Thu Jun 27 21:05:47 UTC 2024
Python Version:  3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0]

Package Information

langchain_core: 0.2.37
langchain: 0.2.15
langchain_community: 0.2.15
langsmith: 0.1.108
langchain_google_genai: 1.0.10
langchain_text_splitters: 0.2.2

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.10.5
async-timeout: 4.0.3
dataclasses-json: 0.6.7
google-generativeai: 0.7.2
httpx: 0.27.2
jsonpatch: 1.33
numpy: 1.26.4
orjson: 3.10.7
packaging: 24.1
pillow: 10.4.0
pydantic: 2.8.2
PyYAML: 6.0.2
requests: 2.32.3
SQLAlchemy: 2.0.32
tenacity: 8.5.0
typing-extensions: 4.12.2

I got the same issue? Our code did not change also core library :(

Hi @eyurtsev, Hope you are doing well. Can you help us out with this issue . We’d really appreciate your help! Thanks

Hi @AkashBais I have a idea, you should remove all environment and install again. My problem has solved for action. I am using conda environment. I have remove it and create env with same name. Luckily, it work for me. It take me many time

@thanhtan1105 I tried it but it dosent do the trick for me. Will need a more permanent soution. For you is it just re creating the env or you made some other changes too.

Hi @AkashBais you can follow my library version below with requirement.txt file. I did not make any change, destroy env and install again. You can try it
langchain==0.2.15
ollama==0.3.2
huggingface-hub==0.24.6
opensearch-py==2.7.1
langchain-community
unstructured==0.15.9
markdown==3.7
nltk==3.9.1
llama-index-vector-stores-opensearch==0.1.14
llama-index-embeddings-ollama==0.2.0
llama-index-embeddings-langchain==0.1.2
llama-index-llms-llama-cpp==0.1.4
llama-index-core==0.10.68
llama-index-llms-langchain==0.3.0
langchain-openai==0.1.23
langchainhub==0.1.21
google-generativeai==0.7.1
grpcio==1.66.1
grpcio-tools==1.62.3
langchain-google-genai==1.0.10
fastapi==0.112.2
uvicorn==0.30.6
langchain-core==0.2.38
google-cloud-aiplatform==1.64.0
python-dotenv==1.0.1
google-cloud-texttospeech==2.17.2

HI @thanhtan1105. I am using langchain == 0.2.15 and langchain_google_genai == 1.0.10. I guess if it's a compatablity issue it should be between these packages, but they are the same as in your discription.
Also a quick question if I may. How are you defining the Tools for routing and function call. Maybe that where the issue is with my code.

Hi @AkashBais  I just create dummy tools without any action. I can share little bit in the image to you. Very simple llm.bind_tools functions

I am consider move all code base to llamaindex framework. I think it more stable than langchain. I hope that.

@thanhtan1105 Thanks for the help, but I am still stuck. I tried ChatVertexAI and ChatGoogleGenerativeAI from langchain. Both have the same issue. Let's see if there is a resolution on this opened issue.

Closing this issue.Raising a new issue with more detailed description.

@AkashBais Did you find any solution?

@AkashBais Hi, I have the same problem, is there a solution?


Change products reference in admin controller

Was too lazy to submit PR.
In some places in AdminBeesBlogImagesController you still have products reference instead of posts.

fix completed by commits 2fc1e5e9c3c0e0de8f642b0d2b63638fb672cce4 and 854c6b1d442d01036777af75fcc6207868978a6d


Correct implementation to reflect OASIS standard

We need to check what needs to be done to get conformance with the latest version of the standard which is at: https://docs.oasis-open.org/csaf/csaf/v2.0/csaf-v2.0.html

Some Todos:

[ ] Use correct values for profiles for /document/category
[ ] Implement #84

Use correct values for profiles for /document/category

Nothing to do here - it is just taken from CVRF 'as is'.


compatibility for new firmware and new generation device

Since this project was launched, Polyend has added 4 additional midi tracks for a firmware update of the original and a new device called Tracker Plus.
Are there any plans to add compatibility/support for these too?

Sorry, I fully switched to dirtywave m8 and stopped maintaining this project. Feel free to fork :)


Change existing HTML Element creation function to match new HTML layout

Change already existing function elements to match newly created HTML layout to generate restaurant cards

card generation script changed


Support auto_merge field in PullRequest struct

The pulls API returns an auto_merge field which is currently not available in the PullRequest struct.
When auto-merge is enabled for a Pull-Request the returned auto_merge field looks like:
  "auto_merge": {
    "enabled_by": {
      "login": "fho",
      "id": 514535,
      "node_id": "MDQ6VXNlcjUxNDUzNQ==",
      "avatar_url": "https://avatars.githubusercontent.com/u/514535?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/fho",
      "html_url": "https://github.com/fho",
      "followers_url": "https://api.github.com/users/fho/followers",
      "following_url": "https://api.github.com/users/fho/following{/other_user}",
      "gists_url": "https://api.github.com/users/fho/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/fho/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/fho/subscriptions",
      "organizations_url": "https://api.github.com/users/fho/orgs",
      "repos_url": "https://api.github.com/users/fho/repos",
      "events_url": "https://api.github.com/users/fho/events{/privacy}",
      "received_events_url": "https://api.github.com/users/fho/received_events",
      "type": "User",
      "site_admin": false
    },
    "merge_method": "rebase",
    "commit_title": "",
    "commit_message": ""
  },

It would be great if go-github could parse this field and make it accessible.

Thank you, @fho !
This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!
Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)
Thank you!

Hey @gmlewis, I am new to opensource and Golang, I will like to contribute to this project can you guide me on what needs to be done.
I have read the CONTRIBUTING.md and I also signed the CLA.

Hi @slayer321 - welcome to Go and to open source and thank you for your interest in helping out this project!
Sure... when attacking any kind of problem, it is best to break it down into smaller, more easily understandable parts.
So for this specific task, I would basically do the following:

Fork and clone this repo if you haven't done so already
Make sure you can run tests locally before you attempt to make any changes

As an aside, I personally use the following test script so that I don't forget anything:
#!/bin/bash -ex
go generate ./...
go test ./...
go vet ./...

Create a new branch for your development... I like to put the issue in the name... something like:

$ git checkout -b i1881-support-auto-merge

OK, I can see this message is going to get huge... so I'll just start commenting and keep creating more comments as I break down the problem.  Stay tuned... :joy:

Next, since @fho  was so kind as to provide us a URL regarding the issue, I take a look at it.
I see that the endpoint in question is: GET /repos/{owner}/{repo}/pulls
I now try to find out where this is in our repo's code base by searching for repos/%v/%v/pulls and making sure it is a GET method

OK, I'm getting pulled into a meeting so I'm going to have to continue to address this later today.

I then match that endpoint with the code, in this case: https://github.com/google/go-github/blob/master/github/pulls.go#L135-L145 and check that the URL for the method is pointing to the same endpoint.
I see that PullRequest is the struct being returned, which is located here: https://github.com/google/go-github/blob/master/github/pulls.go#L21-L77
I then search for the "auto_merge" field which is what is currently missing... both in the docs and in the struct... and yes, I confirm that it is in the docs ("auto_merge": null) and not in the code.
I see that the author of the issue shows an example response for this field even though the GitHub v3 API documentation does not, so I base my implementation on the provided example.
It looks to me like the "auto_merge" field has 4 sub-fields and should go at the top-level of the PullRequest struct... and one of the fields looks very much like our existing User struct.  So I would write some code like this:

// PullRequestAutoMerge represents the "auto_merge" response for a PullRequest.
type PullRequestAutoMerge struct {
    EnabledBy *User `json:"enabled_by,omitempty"`
    MergeMethod *string `json:"merge_method,omitempty"`
    CommitTitle *string `json:"commit_title,omitempty"`
    CommitMessage *string `json:"commit_message,omitempty"`
}

Then I would add this new struct into the PullRequest struct, probably after RequestedReviewers:
...
	RequestedReviewers  []*User    `json:"requested_reviewers,omitempty"`
	AutoMerge *PullRequestAutoMerge `json:"auto_merge,omitempty"`
...

Afterward, I would ideally incorporate this new value in an existing or new unit test (following examples in the surrounding code)... although it is not always necessary to do this just when adding new fields.  It is a nice-to-have to make sure that the struct gets populated properly from JSON... and you could use the example given by the author of the issue in this case.
Finally, I would test out all my changes using that same script I shared above and make sure everything is working properly, then I would share my PR on GitHub and ask for a code review.
I think that about summarizes things... please let me know if you have any questions, and best wishes to you.

Wow, I did not expect such a fast response. :-)
@slayer321 thanks a lot for volunteering! Please let me know if you should change your plans to do the implementation, then I would pick it up instead
@gmlewis excellent step-by-step guide! :-)

Thank you very much @gmlewis  for explaining everything step by step. Most of the steps I understood and some I didn't but I am learning about it.
As you have assigned it to me I will start working on it and if I face any problems I will let you know 😃

@gmlewis Since there were no updates for around 11 days, I thought I will go ahead and give this a try. I have created a PR #1894 for the same. Please check and let me know.
Also, I feel it would be nice to have all the test files in a separate folder

Sorry, @bharathk005 , but let us give @slayer321 an opportunity to respond before taking over an issue that is already assigned.
Additionally, I looked at your PR and it has a number of problems, so I'm not going to officially review it until we hear back from @slayer321.
As for putting test files in a separate folder, that is not idiomatic Go and we will not accept that kind of change in this repo.

@gmlewis
Thanks for the quick response. Sure let's wait for @slayer321

Sorry, @gmlewis  for replying so late. I was not able to work on this issue as my college exam started and I was busy with that but now as the exams are over I can start working on it.

@gmlewis Before opening a PR I have some doubt that I think needs to be clear.
sorry if this seems naive as this is a first time I am working with golang and testing.
I added all the code that needs to be added but I am  bit confuse about the testing part.

Afterward, I would ideally incorporate this new value in an existing or new unit test (following examples in the surrounding code)... although it is not always necessary to do this just when adding new fields. It is a nice-to-have to make sure that the struct gets populated properly from JSON... and you could use the example given by the author of the issue in this case.

As you have mentioned above that after adding the fields we need to test the code so I found a file name fields.go in test/fields dir and then I set the GITHUB_TOKEN env var
and when I run the fields.go command  this is what I am getting
*github.User missing field for key: hireable (example value: <nil>)
*github.User missing field for key: twitter_username (example value: <nil>)
*github.User missing field for key: hireable (example value: <nil>)
*github.User missing field for key: company (example value: <nil>)
*github.User missing field for key: email (example value: <nil>)
*github.Organization missing field for key: company (example value: <nil>)
*github.Organization missing field for key: blog (example value: <nil>)
*github.Organization missing field for key: name (example value: <nil>)
*github.Organization missing field for key: email (example value: <nil>)
*github.Organization missing field for key: twitter_username (example value: <nil>)
*github.Organization missing field for key: location (example value: <nil>)
*github.Repository missing field for key: temp_clone_token (example value: )
*github.Repository missing field for key: forks (example value: 1533)
*github.Repository missing field for key: mirror_url (example value: <nil>)
*github.Repository missing field for key: watchers (example value: 7537)
*github.Repository missing field for key: open_issues (example value: 69)
*github.Issue missing field for key: milestone (example value: <nil>)
*github.Issue missing field for key: active_lock_reason (example value: <nil>)
*github.Issue missing field for key: performed_via_github_app (example value: <nil>)
error: GET https://api.github.com/gists/9257657: 502 Server Error []

seeing this error I think that I need to give the github username is that what's needed?
and if yes where should I add it .
apart from all this I run all the 3 test command and getting no errors
go generate ./...
go test ./...
go vet ./...

seeing this error I think that I need to give the github username is that what's needed?
and if yes where should I add it .

Sorry, @slayer321, but it is really difficult to diagnose and troubleshoot problems without seeing the code and seeing the exact command that you are using to run the code.
Can you please either create the PR or a GitHub gist that shows what you are trying to do and how you are calling it?
Make sure to NOT including any personal access tokens in your post, as you would have to immediately delete them if you do.
Thanks.

Hi @slayer321 - #1896 LGTM... nice job!
It would be great if you could test it out on an actual repo (like the test case given above) to make sure it works.
It sounds like you were having challenges with that testing... feel free to post a GitHub gist (without your personal access token) and I'll see if I can figure out what is going wrong with it.

As I commented on the gist, you can ignore the existing integration test.
Please attempt to write your own stand-alone test to make sure that the new code works.  You don't need to check it in to the repo, but just make sure that it does what you expect.
Thank you, @slayer321 !

Thanks a lot for the implementation @slayer321.
I started to make use of the change  and realized that the PullRequestEvent struct is also missing the AutoMerge field.
The Automerge structure is exactly the same in PullRequestEevent. I checked a github webhook event that I received.
I don't know how you want to handle it.
Should I create a separate new github issue for that?
Or could we include it in https://github.com/google/go-github/pull/1896 already instead?

I don't know how you want to handle it, @gmlewis.
Should I create a separate new github issue for that?
Or could we include it in #1896 already instead?

Since #1896 is not yet merged, I'm fine if @slayer321 would like to add it to that PR.

Hi @gmlewis, yeah I will like to add changes that need to be done.
Before adding anything just wanted to confirm that I interpreted things right whatever was said by @fho

I started to make use of the change and realized that the PullRequestEvent struct is also missing the AutoMerge field.
The Automerge structure is exactly the same in PullRequestEevent. I checked a Github webhook event that I received.

I found the PullRequestEvent struct in event_types.go file in github dir
so the changes that need to be done is to add the  AutoMerge field in PullRequestEvent struct something like this
...
Before      *string         `json:"before,omitempty"`
After        *string          `json:"after,omitempty"`
AutoMerge     *PullRequestAutoMerge   `json:"auto_merge,omitempty"`
...

is this correct?

is this correct?

That sounds right to me.  @fho - can you please confirm?

@slayer321
Yes, that is correct. That is all.

Sorry, for the confusion. Please forget what I said. :-)
The Automerge field must not be added to the PullRequest struct.
In the PullRequestEvent  the auto_merge field is nested in the PullRequest struct.

oh! thank you for letting us know.  :)
so I will not open another PR.

https://github.com/google/go-github/pull/1896 is now merged 😁🎉 Thank you @slayer321!
@gmlewis when can a release be expected? 😊👍

@gmlewis when can a release be expected?

Yes indeed, @simongottschlag , but I've got a lot more merges to perform first.  Hopefully by later tonight you will have a new release.

@gmlewis that's awesome! Sorry if it read like "I expect a release now!" - it was more a question like "How is the usual release cadence? I'm in no hurry, but really looking forward to it!".
Thank you for the hard work! 🥇

Fixed by #1896.

Sorry if it read like "I expect a release now!" - it was more a question like "How is the usual release cadence? I'm in no hurry, but really looking forward to it!".

No problem at all, @simongottschlag!  I was just trying to give an accurate estimate.  :smile:
This should now be available in Release v37.0.0: https://github.com/google/go-github/releases/tag/v37.0.0


TODO: BitcartCC Long-term roadmap

This issue contains a list of long-term issues and features to add. We decided to switch to long-term planning instead of per-month planning.
Core Daemons and Coins support

[ ] Omni layer support (electrum-omni probably)
[ ] Ethereum support (#105)
[x] Investigate weird issue failing CI at times (for example, this CI run)

Merchants API

[ ] Add ability to extend API endpoints and database schema with plugins
[x] Refactor codebase (#109)

Admin Panel

[x] Add more server management settings to admin (lightning management?)
[ ] Add ability to add new pages and extend navigation with plugins

Store

[ ] Add ability to extend store functionality or add new pages with plugins

Docker and deployment

[ ] Tor and using your own node support(bitcartcc/bitcart-docker#8)
[ ] Add ability to add runtime plugins to API, store and admin

Docs

[x] Finalize docs

BitCCL

[ ] Add more functions and events for ease of usage
[ ] Integrate into main Merchants API

SDK

[x] Release 1.0 (bitcartcc/bitcart-sdk#3)
[x]  Refactor to stop using sync_generator.py (bitcartcc/bitcart-sdk#9)

Other integrations and improvements

[x] Set up release versioning (#125)

Closing in favour of https://github.com/orgs/bitcartcc/projects/1

Closing in favour of https://github.com/orgs/bitcartcc/projects/1


Conflicts with file from package error on installation

Installed Fullstaq on a CentOS 7 server.
Installed packages:
fullstaq-rbenv.noarch 1.1.2-1 @fullstaq-ruby
fullstaq-ruby-2.6-jemalloc.x86_64 rev5-centos7 @fullstaq-ruby
fullstaq-ruby-common.noarch 1.0-0 @fullstaq-ruby
Everything works fine. Now I want to install the 2.7 version also so I run:
sudo yum install fullstaq-ruby-2.7-jemalloc.x86_64
Got error:
Transaction check error:   file /usr/lib/.build-id/bb/b8242dc9965a6238d9c0f9360487395b95f53b from install of fullstaq-ruby-2.7-jemalloc-rev1-centos7.x86_64 conflicts with file from package fullstaq-ruby-2.6-jemalloc-rev5-centos7.x86_64   file /usr/lib/.build-id/bb/b8242dc9965a6238d9c0f9360487395b95f53b.1 from install of fullstaq-ruby-2.7-jemalloc-rev1-centos7.x86_64 conflicts with file from package fullstaq-ruby-2.6-jemalloc-rev5-centos7.x86_64
Any ideas?
The installation of the 'normal' variant (fullstaq-ruby-2.7.x86_64) works fine.

This bug has been confirmed. /usr/lib/.build-id/bb/b8242dc9965a6238d9c0f9360487395b95f53b is a symlink to jemalloc. The jemalloc library is built once per distribution, so it's binary identical in all Ruby packages for that distribution, which results in it having the same build ID in those Ruby packages. Unfortunately that results in filename clashes.
The easiest fix is to not package the build IDs.

The issue has been fixed now. When the Continuous Deployment system finishes, you'll receive package updates.


[SPARK-17182][SQL] Mark Collect as non-deterministic

What changes were proposed in this pull request?
This PR marks the abstract class Collect as non-deterministic since the results of CollectList and CollectSet depend on the actual order of input rows.
How was this patch tested?
Existing test cases should be enough.

Test build #64195 has started for PR 14749 at commit 0045128.

Test build #64195 has finished for PR 14749 at commit 0045128.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64195/
Test PASSed.

Merged build finished. Test PASSed.

hmm, I think aggregate function don't need the concept of deterministic, as we never check this property for aggregate functions.

@cloud-fan I noticed this issue because I saw First and Last are marked as non-deterministic. Although we are not checking this property for now, it's still good to set the right values.

thanks, merging to master!

Hm why does this matter? Is it failing some tests?

@rxin It doesn't fail any tests. Found this issue while working on related code path.


Added boolean mooc to code schools table

Description of changes
Add boolean "mooc" to code schools table. See closed PR #236 for discussion.
Issue Resolved

Fixes #169

@hpjaj There is a conflict in db/schema.rb. I think this means there was a migration added and merged after add_mooc_to_code_schools. I can't rebase on the command line because I'm getting an error:
error: Failed to merge in the changes.
Patch failed at 0001 Added boolean mooc to code schools table
The copy of the patch that failed is found in: .git/rebase-apply/patch

@leenyburger - Your rebase issues should be resolved now.  You can pull down the fresh changes from GitHub.
You'll want to check (make test) and fix all the failing specs, based on the new mooc column being required now.
Ping me if you have any issues!

I don't see mooc in the API response for code_schools

@kylemh - our bad.  resolved in https://github.com/OperationCode/operationcode_backend/pull/269


Add Azure Deployment Option

Pretty sure Azure is still the second largest cloud host. We should add a "Deploy to Azure" button
Docs: https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/deploy-to-azure-button
Need to create the Azure service template and test it out.

These docs might be better. This might be fairly easy actually!
https://learn.microsoft.com/en-us/azure/container-instances/container-instances-quickstart-template


This.debug error

i updated my current project from  angular7 to 9  and iam using node 12.0.0
my project is running fine but when i running the command "ng run dev:ssr", iam getting a error .i.e
this.debug is not a function
npm ERR! code ELIFECYCLE
npm ERR! errno 1

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Keep {tag} if value null

It's possible to keep {tag} if the value is null, empty string, etc?  For single value I just replace do replacing like this:
                orderDate: currentClaim.orderDate ?                     moment(currentClaim.orderDate).format("DD.MM.YYYY") : "{orderDate}",
But how do it for arrays?
{#reviews}{position}			               {submitted} {acceptanceText} {fullName}{/reviews}

My guess is no.
If this is something you need, add a variable to your data with an array to check if the reviews array has elements.
const data = {
  reviews,
  noReviews: reviews.length ? [] : [{ display: `{#reviews}{position} {submitted} {acceptanceText} {fullName}{/reviews}`}]
}

then you can do:
{#reviews}{position} {submitted} {acceptanceText} {fullName}{/reviews}
{#noReviews}{display}{/noReviews}

I haven't tested this, but I don't see why it wouldn't work.

As @aylabbs said this is currently not supported and you can use some smart workarounds as suggested.
If you fancy a "real" solution it should be relatively easy to implement by modifying the TemplateCompiler.doTagReplacements method. I would probably control it by adding a flag to the TemplateCompiler constructor (and at the same opportunity will change its list of arguments into an options object as it is getting quite large).
I may implement this in the future but not for the very near one. If you prefer you are welcome to implement it yourself and PR.
Hopes that helps.


Update version to 0.5.6

Description of the change
Update version property to 0.5.6 in preparation of next release
Motivation
Released version 0.5.5 does not match current source version 0.5.4. As a result, SDK requests contain the incorrect version.
curl -H 'x-goog-api-key: AIz' -H 'Content-Type: application/json' -H 'x-goog-api-client: genai-swift/0.5.4'
Type of change
Bug fix
Checklist

[X] I have performed a self-review of my code.
[X] I have added detailed comments to my code where applicable.
[X] I have verified that my change does not break existing code.
[X] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
[X] I am familiar with the Google Style Guide for the language I have coded in.
[X] I have read through the Contributing Guide and signed the Contributor License Agreement.

No problem @andrewheard, I don't have write access to merge the PR so kindly merge at your convenience. Thank you!


Adding .idea for gitgnore

Purpose
Ignoring .idea files from PRs
Goals
Avoid adding .idea files with PRs

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixes step06 according to latest specs: sdpParams in RTCIceCandidate constructor and use promises

The lack of sdpParams in the RTCIceCandidate constructor was throwing a newly created TypeError as per the latest spec draft and .
Moreover, the usage of callbacks in createOffer was causing a race condition that sometimes led to sending a null offer that caused an error on the other peer.

@samdutton Here are the changes I mentioned yesterday, thanks for looking into it.
Should fix Issue #102 as well.

Thanks Maria! Merged.


Discuss: Phase 1 - Vanilla JS Starter Kit Inclusion of jQuery

As I was thinking about the use cases for a Vanilla Starter Kit and how the JS files are structured, I realized jQuery will likely be used.  I'd like to discuss if we should include it by default or provide a modern alternative.

Decided that jQuery would not be included because of wide support for querySelector.


🚀 - Allow dynamic changes to TUI_NUMBER_FORMAT

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
core
Description
Different locales have different decimal separators, so it would be good to be able to change it dynamically on language change. Maybe change it to InjectionToken<TuiNumberFormatSettings | Observable<TuiNumberFormatSettings>>, this way it will be backward compatible with the previous versions.

That's a good suggestion. Will you be willing to make a PR for it?

sure, will take a look

Hi! Any ideas for the implementation? It seems that TUI_NUMBER_FORMAT is used in many places, so it's not trivial.


Renamed ensembl to genome

Varcode could, theoretically, use any pyensembl.Genome object, not necessarily one based on Ensembl data. This makes the name ensembl confusing.

Fixed by https://github.com/openvax/varcode/pull/242


Fix calculating wrong start column for block node when formatting

Purpose
Previously we use parent position start column as the start column for the Block node but this causes few issues and it is not a calculated data. Hence this commit will add calculated start column location which will be passed to the block node from its parent and will format according to that data.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/19586
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[x] Checked Tooling Support
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[x] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19587 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19587   +/-   ##
================================================
  Coverage            15.73%   15.73%
================================================
  Files                   47       47
  Lines                 1265     1265
  Branches               197      197
================================================
  Hits                   199      199
  Misses                1053     1053
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ca4e3...4e00c73. Read the comment docs.


Change example dates to match accompanying image on troubleshooting-commits-on-your-timeline.md

Why:
The example dates on troubleshooting-commits-on-your-timeline.md had inconsistent dates; it talked about Jul 19 first, then used Jul 20 on the URLs, then the accompanying image showed Apr 10 (of another year).

What's being changed:
I changed the dates to match the .png:

I didn't modify any localization files, but given the change is language-agnostic I can add it if desired.

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@felipecalvo Thanks so much for opening a PR! I'll get this triaged for review ✨

@felipecalvo Thanks so much for opening a PR! I'll get this triaged for review ✨


Add submit progress indicator when new exercise being created.

A PR for #31:
Created a new component SubmitIndicator which receives 3 props (message, step, total steps) which replaces the 2 of the conditional returns in the TrackNewExercise component.
Submit indicator uses the previously included LoadingIndicator (at its default size).
No changes made to posting logic/conditions.

@ErikSchierboom, for your review :smile:

Thanks @neenjaw!

Thanks for the chance! Was a neat learning opportunity to work with typescript and react!!


migrate tools/make_dist_html.py to python3

Hi
Now that python2 is being phased out, it may be time to migrate tools/make_dist_html.py to python3.
With this patch, tools/make_dist_html.py runs with python3 and gives the same results as the old version with python2.
Hope this helps

@bnoordhuis I've applied the changes you suggested.
All the best

Landed in https://github.com/libuv/libuv/commit/4ce37613702352c4808c39f4226a12e4960dfc43. Thanks!


[core] Add expiration cleanup limit

Purpose

【common】add parameters for cleaning limits
【core】limit bulk deletions when snapshots expire
after the consumer group expires, a large number of snapshots will be deleted. In severe cases, it may cause continuous checkpoint timeout and affect the running of tasks. Therefore, we need to limit the number of deleted snapshots to make the whole process smoother.
Tests
No
API and Format
No
Documentation
No

Related PR: https://github.com/apache/incubator-paimon/pull/1823


Visual Scripting - no PackedScene var type

Operating system or device, Godot version, GPU Model and driver (if graphics related):
3.0master build 42e2821
I would like to add a PackedScene var for instancing as we do in GDScript:
export (PackedScene) var Mob

but PackedScene does not appear in "Edit Variable" -> "Type" list.

you can drag the scene from filesystem dock to the visual script and it
becomes a PackedScene
On Sat, Sep 30, 2017 at 9:55 PM, Chris Bradfield<EMAIL_ADDRESS>wrote:

Operating system or device, Godot version, GPU Model and driver (if
graphics related):
3.0master build 42e2821
https://github.com/godotengine/godot/commit/42e2821d04a5efd434fffa090e817905d30a0c73
I would like to add a PackedScene var for instancing as we do in GDScript:
export (PackedScene) var Mob
but PackedScene does not appear in "Edit Variable" -> "Type" list.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/11736, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z23_-13pnw3M2usJw3iL9_qZYhHgZks5snuMCgaJpZM4Ppvj2
.

Thanks! That was the one thing I was stuck on!


Outbound connection to <IP_ADDRESS>?

Any reason why konnected board would try utbound connection to <IP_ADDRESS>? Noticed this in the logs on the firewall running on my router.
Dec 11 21:01:30 kernel: [BLOCKED - OUTBOUND] IN=br0 OUT= MAC=18:31:bf:4a:20:e0:68:c6:3a:e1:9c:2a:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=76 TOS=0x00 PREC=0x00 TTL=255 ID=6 PROTO=UDP SPT=4096 DPT=123 LEN=56

By using google on the IP address. It shows that is a tor IP. Also shows
that it is an abusive IP.
On Sat, Dec 14, 2019, 12:09 AM qu3bec<EMAIL_ADDRESS>wrote:

Any reason why konnected board would try utbound connection to
<IP_ADDRESS>? Noticed this in the logs on the firewall running on my
router.
Dec 11 21:01:30 kernel: [BLOCKED - OUTBOUND] IN=br0 OUT=
MAC=18:31:bf:4a:20:e0:68:c6:3a:e1:9c:2a:08:00 SRC=<IP_ADDRESS>
DST=<IP_ADDRESS> LEN=76 TOS=0x00 PREC=0x00 TTL=255 ID=6 PROTO=UDP SPT=4096
DPT=123 LEN=56
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/konnected-io/konnected-security/issues/114?email_source=notifications&email_token=AJB2YJRXBPCSXU2DULCHH4TQYRTBPA5CNFSM4J2YWTTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG32RAY#issuecomment-565684355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJB2YJUTAX7PZK5ZODYJSBLQYRTBPANCNFSM4J2YWTTA
.

No idea why Konnected would be hitting this ip. Are you sure the source is a konnected device?

No idea why Konnected would be hitting this ip. Are you sure the source is a konnected device?

Yes I've set up the board with a static IP <IP_ADDRESS>

The alarm can't seem to connect to my wifi as of yesterday.  I have no idea
and can't see to correct the issue.
On Sun, Dec 15, 2019 at 4:07 PM qu3bec<EMAIL_ADDRESS>wrote:

No idea why Konnected would be hitting this ip. Are you sure the source is
a konnected device?
Yes I've set up the board with a static IP <IP_ADDRESS>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/konnected-io/konnected-security/issues/114?email_source=notifications&email_token=AMCWOAGXTCEKP2WYVDJET73QY2MBBA5CNFSM4J2YWTTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG5CG4Q#issuecomment-565846898,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMCWOAAVLFVEXU2BTOZX6LLQY2MBBANCNFSM4J2YWTTA
.

I really have no idea. This is not much info to go on. Maybe try capturing the traffic with wireshark to see if we can see what kind of content it is?

I really have no idea. This is not much info to go on. Maybe try capturing the traffic with wireshark to see if we can see what kind of content it is?
https://otx.alienvault.com/indicator/ip/<IP_ADDRESS>
Under Passive DNS some ntp servers listed. Does the board connect to ntp servers? I just found out that my TP-Link HS110 plug also tried to hit this ip!!

https://otx.alienvault.com/indicator/ip/<IP_ADDRESS>
Under Passive DNS some ntp servers listed. Does the board connect to ntp servers? I just found out that my TP-Link HS110 plug also tried to hit this ip!!

Yes, it does connect to NTP to sync the current time.

Looks like pool.ntp.org is one of the DNS entries, so that makes sense now.

Yeah it does. How often does the board sync current time? Mine reboots once every few days and sometimes twice a day so maybe it can't connect to ntp servers when it reboots?

It syncs after every reboot.
It will prefer to get the current time from your router/gateway. So, if you can configure your router to act as a NTP server, then you can avoid going out to the internet to sync time.


Animation Copy + Paste copies by reference (preserves ExtResource), unlike Duplicate

Godot version: 3.2.3

OS/device including version: Linux Ubuntu 18.04

Issue description:

When copying and pasting an animation in the Animation window (when working on an AnimationPlayer), the new animation is actually a clone by reference of the original animation. This can be verified by inspecting the scene containing the AnimationPlayer. If you copy and paste, then duplicate an animation you will see something like this in the .tscn:
[node name="AnimationPlayer" type="AnimationPlayer" parent="."]
anims/ANIM_NonPlayerCharacter_Idle_Left = ExtResource( 7 )
"anims/ANIM_NonPlayerCharacter_Idle_Left 2" = ExtResource( 7 )
"anims/ANIM_NonPlayerCharacter_Idle_Left 2 (copy)" = SubResource( 3 )

with the same ExtResource ID for Copy-Pasted animation, but a different one for Duplicated animation (note that the last one is SubResource simply because I didn't save it in an external asset file yet).
Steps to reproduce:

In a scene, create an animation player
In the Animation window, create a first animation ANIM_Original
(optional) Add a key point to modify some property of some accessible object. If you have a spritesheet you can select a sprite frame to make differences between animations visible at a glance.
Click on Animation > Copy then again Animation > Paste. Default name is ANIM_Original 2 but you can rename it ANIM_Copy for clarity.
Either from the original or this copy, click on Animation > Duplicate. Default name is suffixed (copy) but you can rename it ANIM_Duplicate for clarity.
Open the scene in a file editor and observe the properties of the animation player. It should contain SubResource with same ID for ANIM_Original and ANIM_Copy, but a different one for ANIM_Duplicate.
(optional) If you did 3, modify a key property value on ANIM_Original and see the change occur on ANIM_Copy, but not ANIM_Duplicate.
(optional) Now try to Save (not Save as) the animations one by one. Note that ANIM_Duplicate prompts for save location since it's the first time you saved it, while ANIM_Original and ANIM_Copy are the same, therefore only the first one will prompt for save location. This is actually how I discovered the bug, I only checked scene file content later.

Expected: both operations should copy animation by value (deep copy) and generate a different asset.
Of course, if you really want to keep copy by reference then it's possible, but I'd recommend having a different command "Paste by reference". Users probably expect Copy + Paste to be equivalent to Duplicate (excepted for name suffix I guess), and in most cases we want a deep copy, e.g. to make animations for a character turned up, left, right, down.
Minimal reproduction project:

Just reproduce it from scratch in a new project, no asset nor project config is needed to reproduce this bug, a dummy spritesheet can just help visualize things.

Duplicate of https://github.com/godotengine/godot/issues/30197.


Fixes release upload tag so it uploads to an existing release.

Current dependencies on/for this PR:

main

PR #152   👈

This comment was auto-generated by Graphite.


Why the same datasets otdd is not zero ?

I tried to measure the same dataset otdd, but the result told me that it's not zero.
loaders_src  = load_torchvision_data('MNIST', valid_size=0, resize = 28, maxsize=2000)[0]
loaders_tgt  = load_torchvision_data('MNIST',  valid_size=0, resize = 28, maxsize=2000)[0]

The result is 346.16

Two possible reasons:
(1) the maxsize flag yields a data loader that randomly subsamples the dataset, so these two loaders will return datasets of size 2000 that most likely do not have the same samples, hence the non-zero distance
(2) if you are not using the debiased verstion (debiased=True flag), then there is an entropy regularization term in the OT distance that biases the result away from zero.

Thank you David!


Migrate away from elementAt for Dart 3.3

elementAt has been deprecated as of Dart 3.3 and should be replaced by operator +.
Valid SDK bound for using operator +: "version:3.3.0-279.1.beta".
Context:

https://github.com/dart-lang/sdk/issues/54250

This was done in https://github.com/dnfield/vector_graphics/commit/83517058d2d99e38478861f4329956e9bd9f8199#diff-ab1e22ae020563734f9f8d6ebd6520504de6b0c038d1ffec2134adc613f840b0R122 and was published to pub.dev.

Argh. I think I failed to push this up to github correctly too.

I'm going to re-open this. I didn't publish with theright SDK constraint, and I don't want to publish this until people have had more time to update to a newer version of Flutter.

Oh, but it looks like the indexing operator is available earlier and does the same thing..


System for configuration is local system not the target system

I'm finding it weird that local system is used for nixpkgs here: https://github.com/ryan4yin/nixos-rk3588/blob/349f39dcaafeb41250544bcc066db8668a7762ce/demo/flake.nix#L13-L36
Can you explain how it works, because if you remove colmena from the configuration and make it regular nixos configuration and try to crosscompile it would look like this:
nixpkgs.lib.nixosSystem {
  system = "x86_64-linux";
  modules = [
    nixos-rk3588.nixosModules.orangepi5.core
    nixos-rk3588.nixosModules.orangepi5.sd-image
    ./configuration.nix
  ];

  specialArgs.rk3588 = {
    inherit nixpkgs;
    pkgsKernel = import nixpkgs {
      localSystem = "x86_64-linux";
      crossSystem = "aarch64-linux";
    };
  };
}

Which is a bit weird, cause system is still aarch64-linux.

Nevermind. It doesn't work as I described.
I've set nixosSystem as follows:
nixpkgs.lib.nixosSystem {
  system = "aarch64-linux";
  modules = [
    nixos-rk3588.nixosModules.orangepi5.core
    nixos-rk3588.nixosModules.orangepi5.sd-image
    ./configuration.nix
  ];

  specialArgs.rk3588 = {
    inherit nixpkgs;
    pkgsKernel = import nixpkgs {
      localSystem = "x86_64-linux";
      crossSystem = "aarch64-linux";
    };
  };
}

and used my orangepi 5 as remote builder (as described here) and everything worked flawlessly. Maybe example should be updated or I can add example featuring regular deployment.


List some carto layers in the sidebar

Adds a helpful legend

Closed because this is a dirty PR -- must have done a failed rebase


⚠ Bofrost.de has degraded performance

In 7cf0e0f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1531 ms

Resolved: Bofrost.de performance has improved in bc445a7.


Access to process.binding("http_parser") is deprecated

问题

期望
废弃了为啥还会调用，0改动，拉下来跑就出来了这个错误

底层库调用 忽略
发自我的iPhone
------------------ Original ------------------
From: 刘山山 @.>
Date: Tue,Jul 5,2022 6:09 PM
To: zhangyuang/ssr @.>
Cc: Subscribed @.***>
Subject: Re: [zhangyuang/ssr] Access to process.binding("http_parser") isdeprecated (Issue #217)
问题
期望
废弃了为啥还会调用，0改动，拉下来跑就出来了这个错误
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


issue importing matplotlib.pyplot with spyder

hello - I'm having the following error when importing matplotlib.pyplot from the IPython console or the Python console. It is my first time using Spyder and I'm just learning Python (I'm a 15+ yr experienced Matlab user), but could not find any help for this error on the various sites I visited. Below is a copy paste of the error I get with running this command in the console:
thanks for your help
Enrique
#--------------------------------------------------------
import matplotlib.pyplot
Traceback (most recent call last):
File "", line 1, in
import matplotlib.pyplot
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\pyplot.py", line 27, in
import matplotlib.colorbar
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\colorbar.py", line 34, in
import matplotlib.collections as collections
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\collections.py", line 27, in
import matplotlib.backend_bases as backend_bases
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\backend_bases.py", line 56, in
import matplotlib.textpath as textpath
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\textpath.py", line 19, in
import matplotlib.font_manager as font_manager
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\font_manager.py", line 1415, in
_rebuild()
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\font_manager.py", line 1400, in _rebuild
fontManager = FontManager()
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\font_manager.py", line 1040, in init
self.ttffiles = findSystemFonts(paths) + findSystemFonts()
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\font_manager.py", line 312, in findSystemFonts
for f in win32InstalledFonts(fontdir):
File "C:\Users\mami\Anaconda3\lib\site-packages\matplotlib\font_manager.py", line 231, in win32InstalledFonts
direc = os.path.abspath(direc).lower()
File "C:\Users\mami\Anaconda3\lib\ntpath.py", line 535, in abspath
path = _getfullpathname(path)
ValueError: _getfullpathname: embedded null character

@tacaswell, have you seen this error before? I don't know where it could be coming from...

my guess is that are some non-ascii characters in a font path (see http://stackoverflow.com/questions/33977519/valueerror-embedded-null-character-when-using-open ?) and the encoding is not what ever python is assuming it is.
@jeportillo Can you try the same thing in an IPython shell and use %debug to sort out what value of direc is causing the problem?

Thomas/Carlos -- thanks for your help!
I am printing the value of "direc" before being calling by
"abspath(direc)". Since it is being called inside a for loop, I also
printed the index. Attached is a screenshot of what I get: Basically, the
"BrushSci.tff" file has some characters associated to it during the 246th
iteration.
let me know if you need me to run anything else - thanks again
PS. I'm running on Windows 7
Enrique
On Mon, Nov 30, 2015 at 8:13 PM, Thomas A Caswell<EMAIL_ADDRESS>wrote:

my guess is that are some non-ascii characters in a font path (see
http://stackoverflow.com/questions/33977519/valueerror-embedded-null-character-when-using-open
?) and the encoding is not what ever python is assuming it is.
@jeportillo https://github.com/jeportillo Can you try the same thing in
an IPython shell and use %debug to sort out what value of direc is
causing the problem?
—
Reply to this email directly or view it on GitHub
https://github.com/spyder-ide/spyder/issues/2833#issuecomment-160814786.

I think this is the same issue reported at http://matplotlib.1069221.n5.nabble.com/Error-on-import-matplotlib-pyplot-on-Anaconda3-for-Windows-10-Home-64-bit-PC-td46477.html

cpython bug report: https://bugs.python.org/issue25778
SO question: http://stackoverflow.com/questions/34004063/error-on-import-matplotlib-pyplot-on-anaconda3-for-windows-10-home-64-bit-pc/34007642#34007642

many thanks Thomas -- I added the patch provided in the link you sent out
and was able to make my first ever plot in Python :-)
direc = direc.split('\0', 1)[0]
On Sat, Dec 5, 2015 at 11:31 AM, Thomas A Caswell<EMAIL_ADDRESS>wrote:

cpython bug report: https://bugs.python.org/issue25778
SO question:
http://stackoverflow.com/questions/34004063/error-on-import-matplotlib-pyplot-on-anaconda3-for-windows-10-home-64-bit-pc/34007642#34007642
—
Reply to this email directly or view it on GitHub
https://github.com/spyder-ide/spyder/issues/2833#issuecomment-162218478.


Create Ansible Skeleton Configuration

Full installation playbook using Ansible (minus HTTPS and automatic deployment)
Closes #3

super !


Ingest the policy tags exactly as they are in the BigQuery

Is your feature request related to a problem? Please describe.
Open Metadata does not ingest taxonomies along with policy tags. For example: instead of #BigQueryPolicyTags.name, bring #PII.name
Describe the solution you'd like
Basically I need the ingestion of policy tags to be the same way as BQ. Another point: not having to add the Category Name field to ingestion.

duplicate of #9830