conflict between Logout Tweaks and Speedy Paths

Hey,
Noticed there's a conflict between Logout Tweaks and Speedy Paths: if you logout while the Speedy Paths buff is active (e.g. while standing on wood or stone), on login the Speedy Paths buff appears twice, with one of the buffs doing nothing but staying permanently, even if you walk away from wood / stone.

I had a quick look at the code and I'm not sure why the buff is not ignored by Logout Tweaks though :/

I thought I had fixed the incompatibility in the 0.5.0 update. What version of the mods and game are you using?

Yeah, from looking at the code added in 0.5.0 it makes no sense to me either why the status effect is picked up... Haven't investigated further.
Versions:

Game: 0.217.46
Logout Tweaks: 0.5.0
SpeedyPaths: 1.0.8

Oh, I remember now. I couldn't fix that because the status effects from Speedy Paths aren't mimicking vanilla behavior and are added when Hud.instance.UpdateStatusEffects is called here Speedy Paths Repo. Which my mod calls here Logout Tweaks Repo. I might be able to remove that line if the status effects are updating properly without it. Otherwise I have my own version of that mod called Need For Speed you can use in its place until it can be fixed.

Good catch! Yeah it looks like UpdateStatusEffects is called in the main Update loop so I suspect it should be fine even without a manual call at load time.
Did see Need for Speed but I liked the Speedy Paths approach with a visible status effect better, makes it obvious to the user when a buff or debuff is applied 😅

This is fixed in version 0.5.1

Thanks!


Switch to quickbit-universal

Still need to add indexing for maximum performance 🚀

@mafintosh I'll leave further optimisations for a separate PR so this should be ready for review.

@kasperisager good to go?

@mafintosh Yep, got indexing implemented for lastIndexOf() as well.

woot

Merged!


keybase pgp drop doesn't warn to generate revocation certificate

$ keybase version
Client:  1.0.16-20160713110422+a1c00b3
Service: 1.0.16-20160713110422+a1c00b3

$ keybase pgp drop "0101cbea3f0835743a39b13908ea7e7bfac05e32e685417637d099d714fc441eca530a"
- INFO Revoking KIDs:
- INFO   0101cbea3f0835743a39b13908ea7e7bfac05e32e685417637d099d714fc441eca530a

$ keybase pgp help drop
NAME:
   keybase pgp drop - Drop Keybase's use of a PGP key

USAGE:
   keybase pgp drop <key-id>

DESCRIPTION:
   "keybase pgp drop" signs a statement saying the given PGP
   key should no longer be associated with this account. It will **not** sign a PGP-style
   revocation cert for this key; you'll have to do that on your own.

Where is the revoking certificate the cli tool is telling me? Or is the pgp drop command output misleading?

The "revoking kid" output is confusing. We should fix that. But there is
not pgp revocation cert generated for this key.
On Friday, July 15, 2016, Cássio Oseki<EMAIL_ADDRESS>wrote:

$ keybase version
Client:  1.0.16-20160713110422+a1c00b3
Service: 1.0.16-20160713110422+a1c00b3
$ keybase pgp drop "0101cbea3f0835743a39b13908ea7e7bfac05e32e685417637d099d714fc441eca530a"

INFO Revoking KIDs:
INFO   0101cbea3f0835743a39b13908ea7e7bfac05e32e685417637d099d714fc441eca530a

$ keybase pgp help drop
NAME:
keybase pgp drop - Drop Keybase's use of a PGP key
USAGE:
keybase pgp drop
DESCRIPTION:
"keybase pgp drop" signs a statement saying the given PGP
key should no longer be associated with this account. It will not sign a PGP-style
revocation cert for this key; you'll have to do that on your own.
Where is the revoking certificate the cli tool is telling me? Or is the pgp
drop command output misleading?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/3484, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_5DJroch1L1ua40A2QYZFROavjZpks5qV2hzgaJpZM4JNSqG
.


Windows issue reading ipptool files

A strange and intermittent issue has come up running ipptool under windows. It only came to bite me after numerous successful runs.
It seems that ftell gets confused when various getc / ungetc operations are performed on a file that is opened in mode "r" (ascii). It is necessary to open the file in mode "rb" (binary). My file on windows had simple unix style line endings which is perhaps where the inaccuracy comes about - I'm not sure. I have confirmed the fix works.
Rather than submitting a patch I'd like to offer the code location for the change as its very simple to find. I do not feel other fopen and similar calls need to be changed from "r" to "rb" at this time but I'll be on look out now!
ipptool.c
~ line 829:	if ((fp = fopen(testfile, "rb")) == NULL)

The symptoms of the problem were weird parse errors showing "incorrect tokens" from earlier in the file. And in particular due to a collection attribute. Maybe the pattern of getc / ungetc did the trick in this. Attached is a zipped file that should hopefully not work for you and then will work after the patch.
J
testfile.zip

This is strange.
I think the best long-term solution is to update the code to use the CUPS file API which doesn't have this issue. We've had issues in the past when reading text files in binary mode on Windows thanks to unsafe assumptions that Microsoft makes... :/

[master 947cefe] Migrate ipptool to use the CUPS file API to avoid some Windows line ending problems (Issue #28)


himlib error

I meet a problem
gcc failed with exit status 1

@xtyi1997 Could you be more specific? From what you said I think it might be a linker error because you use gcc, you might want to use the flag -lstdc++ for gcc.


Sub-applications within IIS don't work anymore

I used to be able to publish an aspnet 5 beta 7 web application as a sub-application.  Since I'm upgrading to rc1-final I am no longer able to do it.
Here is the error I get when I attempt to call the sub-application within IIS.

Cannot add duplicate collection entry of type 'add' with unique key attribute 'name' set to 'httpplatformhandler'

I can of course publish to a separate root IIS application and it will work, but of course that breaks the whole architecture of the application.
It's the result of the web.config changes that occurred.
<configuration>
  <system.webServer>
    <handlers>
      <add name="httpplatformhandler" path="*" verb="*" modules="httpPlatformHandler" resourceType="Unspecified" />
    </handlers>
    <httpPlatform processPath="..\approot\web.cmd" arguments="" stdoutLogEnabled="true" stdoutLogFile="..\logs\stdout.log"></httpPlatform>
  </system.webServer>
</configuration>

So how do I publish in the new world?

This issue was moved to aspnet/IISIntegration#44

We tried removing the handler from the sub-application. The sub-application will only throw 404s from that point on.
This is a bug or a change that requires information to implement.


field don't show dict_id, dict_is_ordered in format/debug

Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
field don't show dict_id, dict_is_ordered in format/debug
Make field format clear
Are there any user-facing changes?
Yes, it will change output.

After careful consideration, I believe that this PR would result in many changes, but the benefits are not as substantial. Therefore, I have decided to close it.


JS stops running when put chromium in background (hide or minimize)

Puppeteer version: 1.7.0
Platform / OS version: Mac OS 10.13.6 (17G65)
URLs (if applicable):
Node.js version: v8.9.4

What steps will reproduce the problem?

start a puppeteer program whatever control the elements
hide the chromium (CMD+H), or minimize the chromium, or move to another desktop

What is the expected result?
The program continues running
What happens instead?
The program just paused. It will continue when you reactivate the chromium (put it in foreground)

Seems to be a dupe of #3156.

[Solution]:
Add the following values to the array you assign to the args property in the options object. Now, you should be able to run Puppeteer while your window is in the foreground, background, or minimized.
const chromeArgs = [
  '--disable-background-timer-throttling',
  '--disable-backgrounding-occluded-windows',
  '--disable-renderer-backgrounding'
];

Solution and explanation available in an article written by Rohit Kumar, @rkr090 at Big Binary:
Debugging failing tests in puppeteer because of background tab


Link to lang files is broken

Screenshots/Error Log:

Additional Context:

Link isn't working anymore on the github repo.

Ha, thank you for letting me know! I fixed it up 😄


.next not supported for source/data packages

Describe the bug
Orchestrator commands like build and individual create package commands for source package don't respect .NEXT as the buildnumber , it just creates the package with .next as the buildnumber, creating issues in stages like promote where most artifact repositories expect a proper semantic version and fails when it sees .NEXT
Though build commands support passing of the build number, its not clear what it means as unlocked packages accept next while source doesn't. Also source packages build number have to be placed with always zero.
To Reproduce
Steps to reproduce the behavior:

Introduce a source package with .NEXT as the build number
Notice how build number doesnt override the .next part
Try publish and see how it fails with Azure Artifacts

Expected behavior
A clear and concise description of what you expected to happen.
Two Options
.NEXT should be supported or
There should be a build failure ensuring build number is a mandatory requirement and  warning .next is getting replaced by build number

decided to fail if .next is encountered


Forwarding uniqueid from Asterisk for outgoing calls

Hello,
I have following issue:
For incoming calls, when call is finished, PBXIS sends agentComplete message which includes "recording" attribute with the name of the file containing recording of the call.
For outgoing calls, system never sends agentComplete message and uniqueid attribute from bridgeStatus message is not forwarded when creating phoneNumber message.
However, from PBXIS logs it is visible that Asterisk sends uniqueid attribute (which is essencially same as recording attribute for agentComplete - in this example "Primary_Ast4CRM-1555588602.7610") in bridgeState message when call is established (other party picks up). PBXIS uses that bridgeState message and creates phoneNumber message from it in this case.
2019-04-18 13:56:57 Asterisk-Java ManagerConnection-0-Reader-2 INFO  o.a.m.i.b.b.BridgeState - Members size 2 org.asteriskjava.manager.event.BridgeEnterEvent[dateReceived='Thu Apr 18 13:56:57 CEST 2019',privilege='call,all',linkedid='Prim
ary_Ast4CRM-1555588602.7610',server=null,calleridname='CN HD',bridgeuniqueid='80e54f04-1637-4757-b1ec-b892210db89b',channel='SIP/665-0000132c',language='en',exten='s',calleridnum='XXXXXXXXXXX',context='macro-dial-trunk-pstn',bridgetechnol
ogy='simple_bridge',connectedlinenum=null,uniqueid='Primary_Ast4CRM-1555588602.7610',timestamp=null,channelstatedesc='Up',systemname='Primary_Ast4CRM',bridgetype='basic',bridgenumchannels='2',connectedlinename=null,bridgecreator=null,sequ
encenumber=null,priority='4',channelstate='6',bridgename=null,accountcode='SIP-665',systemHashcode=1776153776]
2019-04-18 13:56:57 Asterisk-Java ManagerConnection-0-Reader-2 INFO  o.a.m.i.b.b.BridgeState - Bridge SIP/665-0000132c SIP/CCM1-0000132d
2019-04-18 13:56:57 Asterisk-Java ManagerConnection-0-Reader-2 DEBUG com.ingemark.pbxis - PBXIS event {:type "phoneNumber",
:agent "665",
:number "XXXXXXXXXXX",
:queue nil,
:name nil,
:unique-id "SIP/665-0000132c"}
2019-04-18 13:56:57 Asterisk-Java ManagerConnection-0-Reader-2 DEBUG com.ingemark.pbxis-ws - Send WebSocket {"type":"phoneNumber","agent":"665","number":"XXXXXXXXXXX","queue":null,"name":null,"unique-id":"SIP/665-0000132c"}
2019-04-18 13:56:58 Timer-0 DEBUG com.ingemark.pbxis - PBXIS event ...
What is needed is that PBXIS forwards this information so call can be paired with the call recording.
is it possible to get that information in phoneNumber message or in agentComplete (if it can be created when call finishes)?

Which version of Asterisk are you running?


diff-add-exclude-elements-options

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ac02167) 83.66% compared to head (0015cb5) 83.66%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   83.66%   83.66%
=======================================
  Files         216      216
  Lines       12502    12502
=======================================
  Hits        10460    10460
  Misses       1668     1668
  Partials      374      374

Flag
Coverage Δ

unittests
83.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


What's up with FloatingPoint?

Likely related to recent C++20 math constants changes: https://godbolt.org/z/mzkD-v
Investigate...

Doesn't look like anything to me


Update tapir-akka-http-server, ... to 0.17.10

Updates

com.softwaremill.sttp.tapir:tapir-akka-http-server
com.softwaremill.sttp.tapir:tapir-enumeratum
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-circe-yaml
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-swagger-ui-akka-http

from 0.17.0-M8 to 0.17.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

labels: library-update, semver-pre-release

Superseded by #82.


Update Blazor common sample example

Fixes #18865
The user triggers ActivateTab, and SetActiveTab is used to set the tab.
Thanks @serpent5! 🐢 ..... Do u want to 👀 this to make sure that I didn't create a PR :poop:? :smile:

Sure, looks good.
Purely just out of curiosity, I did also wonder whether the SetActiveTab functionality could be put into a setter for the ActiveTab property. Is that supported in Blazor WASM? I'm new to that side of things, and there's a whole 'nother argument whether it's appropriate, but yeah, I was curious.

Possibly ... I didn't consider it. It doesn't seem like that change would have any bearing on what the example is here to show, namely cascading parameters. Actually, I kind'a feel that this whole example has too much going on to be a great introductory example for the concept. Anyway ... this example came from engineering this way, and I just dropped it into the docs. It was reviewed by Ryan on a big :eye: review before going to release, so I guess he felt it was right when he looked at it again.

Yeah, I understand. It's totally irrelevant to the sample. I was just asking if it was supported; certainly not challenging any decisions. I guess I should've just tried it myself, really. Thanks.

Given my workload right now ... and for the foreseeable future ⛏⛰😅 ...  I don't have time to refactor/test that approach. If you come up with something that looks better, then put it up in an issue. We can certainly take a look at it and see what's what.

It was never about suggesting something better. I was perhaps just thinking out loud, which was my mistake. I'm not trying to add to your workload and I'm not trying to cause issues for you. I understand that you're busy and I really am sorry for being a distraction.

No distraction. I'm not that busy :smile:.
I must not be that busy ....... I'm working on Sunday again. Hold on while I :trollface: myself: STOP working on Sunday you GoObErReX! lol


updated lingon-x (4.0.1)

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Merged as 10ab3ba063c0dac1266480a659fe55916bd7abe4.


[Bug] [Chat_Data] use stream model return json without data

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information
3.10
DB-GPT version
latest release
Related scenes

[X] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[ ] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
x86_64
NVIDIA GeForce GTX 1080
Models information
LLM: iFlytekSpark-13B
Embedding model:text2vec-large-chinese
What happened
When I call the streaming answer mode with the API, the answer result is only JSON characters, without data.

What you expected to happen
Return streaming output results, just like non streaming output.

How to reproduce
curl -X POST "http://localhost:5670/api/v2/chat/completions"
-H "Authorization: Bearer dbgpt"
-H "accept: application/json"
-H "Content-Type: application/json"
-d "{"messages":"Hello","model":"chatgpt_proxyllm", "stream": true}"
Additional context
nothing
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

thank u for answer. What I mean is that it returned an incorrect response, which is that the streaming output did not output the complete table at the end. I use Source Code Deployment, where shall I modify to fix it

it looks like web chat data app not correct , can you show the whole complete chat data screen shot? did you specify your db name?


Add VCS recording for atlantis-trunk svn checkout

Implementation will likely be almost entirely in SalishSeaCast/NEMO-Cmd, but capturing notes from issue #1 here for reference.

I did a little more research on the VCS recording with svn issue and found that, without having to authenticate to the server, svn info provides a bunch of useful stuff including:

repo URL
last changed rev
last changed authored
last changed date
What's missing compared to what we can get from git are the list of files that were touched in the most recent commit, and the commit message. I'm fuzzy on whether svn has the git concept of commit and push to server, or if svn commit communicates directly with the server. So, I'm not sure if there is a case where svn info would show something different for changes that have been committed but not pushed (if that's even a thing).

svn diff also works without authentication, so we can capture uncommitted changes.


Game crashes using SDL on MacOS with an external display attached

I'm working on an osu-framework project using the SDL graphical backend, but I am unable to start it when I have an external display connected via thunderbolt 3, even if the window is supposed to be on the primary display. I am using a 16-inch Macbook Pro with MacOS Catalina 10.15.7 and a Mobile Pixels Duex Pro external display.
When I run the project without an external display, everything works as expected; after a bit of time, the window appears and displays the content to the screen. This also happens when I have the display connected while useOsuTK: true. However, using SDL with the display attached, I get an exception in the host.run() that I don't really understand:
Exception: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'index')
   at System.Char.IsDigit(String s, Int32 index)
   at osu.Framework.Platform.PassthroughGraphicsBackend.<>c.<getVersionNumberSubstring>b__25_0(String s)
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
   at osu.Framework.Platform.PassthroughGraphicsBackend.getVersionNumberSubstring(String version)
   at osu.Framework.Platform.PassthroughGraphicsBackend.Initialise(IWindow window)
   at osu.Framework.Platform.SDL2.SDL2GraphicsBackend.Initialise(IWindow window)
   at osu.Framework.Platform.SDL2DesktopWindow.Create()
   at osu.Framework.Platform.MacOS.MacOSWindow.Create()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at Piously.Desktop.Program.Main(String[] args) in /Users/ben/Desktop/Git_Stuff/piously_Git/Piously.Desktop/Program.cs:line 14

The program.cs file where the crash occurs:
public static class Program
{
    [STAThread]
    public static int Main(string[] args)
    {
        using (GameHost host = Host.GetSuitableHost(@"Piously", useOsuTK: false)) // No issues when useOsuTK is true or no external display
            host.Run(new PiouslyGameDesktop()); // Exception here

        return 0;
    }
}

I'm not sure what the external display has to do with it, but clearly going off of this code:
https://github.com/ppy/osu-framework/blob/388be39457fd5bf90a02fb65af4825dfb45cbeee/osu.Framework/Platform/PassthroughGraphicsBackend.cs#L124-L130
you must be getting an empty OpenGL version string, which I'm not even necessarily sure how to debug why would that be the case (possibly calling GL_GetError()?). Certainly sounds like there's a probability this isn't the framework's problem.

After some testing, I learned that while running SampleGame in osu-framework does not appear to crash, running osu.Framework.Tests results in the crash, and both are with SDL. I am still not sure why this is the case.

The only thing I can think of here is that the one which is failing has a different display stored to the config, which is somehow inhibiting the ability to get a gl context. Could you check the framework.ini files for each of the projects you're running and see if that correlates to the error?

Ok, I have more info regarding specifically when the crash happens.
This is the layout of my displays in which the program crashes on initializing:

The primary display is the horizontal screen on the left, while the external display is the vertical one on the right. This screen layout causes the game to crash when the window is at the maximum allowed space (display size minus dock at the bottom) from the previous time played. However, if I change my layout to that of the next images, there is no crash when the window was previously at the maximum window size and I try to relaunch it.
Does not crash with these layouts:

I do not know what this has to do with OpenGL, but these are my findings. For now, I'll be having my external display be attached to the left side of my primary display since this doesn't cause the crash.

An interesting detail for sure, but I'm not sure I can glean much from the fact that it only seems to not work on this one side... As a next step I would probably poke the size/position code in SDL2DesktopWindow and see if there aren't any obviously wrong values.

@ben9583 this is my screen layout, and i cannot reproduce a crash:

Are you able to try going back to your old layout and repositioning to be more centered? Also can you confirm whether your game window is starting on your main or secondary screen in the fail case?

So weird thing happened: When I updated my MacBook, my kernel extensions got messed up, so I had to reinstall the drivers for my display. The display was in landscape mode and the option to rotate it was removed. I haven't been able to figure out how to make it portrait mode like it was previously and so it has just been in landscape mode. No crashes occur in this case, even when the display was to the right of my primary.
My guess is that this was an issue with the display, not osu-framework. Disappointed I can't work with it in portrait mode, but that's another problem, so I think it's best this issue be closed. By the way, back when the program was crashing, the framework.ini showed that the window was starting on my primary display.

Since there are no other reports of this for now, tentatively closing as resolved. Will reopen if anyone else pops up to report a similar thing.


33 refactor testing and db connecting

Codecov Report
Base: 90.55% // Head: 89.86% // Decreases project coverage by -0.69% :warning:

Coverage data is based on head (41f57aa) compared to base (565f6a0).
Patch coverage: 75.60% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   90.55%   89.86%   -0.70%
==========================================
  Files          38       39       +1
  Lines         593      592       -1
  Branches       79       70       -9
==========================================
- Hits          537      532       -5
- Misses         56       60       +4

Impacted Files
Coverage Δ

src/server.ts
0.00% <0.00%> (ø)

src/db/connectToDatabase.ts
76.00% <76.00%> (ø)

src/app.ts
88.88% <100.00%> (-3.80%)
:arrow_down:

src/db/sessionStore.ts
100.00% <100.00%> (ø)

src/middlewares/error.ts
100.00% <100.00%> (ø)

src/exceptions/IdNotValid.ts
60.00% <0.00%> (-6.67%)
:arrow_down:

src/exceptions/UserNotFound.ts
60.00% <0.00%> (-6.67%)
:arrow_down:

src/authentication/logout.ts
88.88% <0.00%> (-0.59%)
:arrow_down:

src/exceptions/Http.ts
100.00% <0.00%> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


SingleDatePicker: No way to distinguish between invalid date and empty input

SingleDatePicker's onDateChange handler is fired with null when user's input doesn't validate to a date. This can happen when the date is, in fact, invalid 13/13/2018 or when user input is empty.
Is there a way to tell these scenarios apart?

+1

This is also tripping me up a little. My scenario is that I want to send a request to the server if the user "clears" the input, but I have no way of knowing if the null date arg was because of an actual clearing of the input or a temporary edit that put the input into an invalid state.
Perhaps additional arguments could be passed to the change handler, in addition to the date value? Something that refers to the validity of the current state of the input?

+1

+1 this is driving me insane:)
Its probably a bug though, as onDateChanged should not be triggered at all.
See README:

The SingleDatePicker also manages internal state for partial dates entered by typing (although onDateChange will not trigger until a date has been entered completely in that case).

+1

+1  Same problem here

Looks like my +1 comment was marked as spam for some reason, but I am also experiencing the same problem.

All +1 comments are spam; github etiquette is to use an emoji reaction on the OP.

We probably should make onDateChange fired with either a Date object or a string (contains whatever user's original input) to fix this issue

Hi all, huge issue for us. As we don't know if the date is being edited but invalid or just empy. Maybe use null / undefined.

RE: https://github.com/airbnb/react-dates/pull/2015

Any updates on this? Hoping to find a solution on this as well...

really late i guess but i need this too

Hi I checked the actual value of the input. I am not quite sure if I used document.getElementById or a ref to get the input


Fix infinite loop

We discovered a bug where equations like 4 - ((3)/(2))x = 1 would not solve correctly, getting caught in an infinite loop of shifting the ((3)/(2))x term back and forth between the two sides of the equation.
It turned out this was happening essentially due to ((3)/(2))x being incorrectly identified as a non-symbol term (i.e. term without a variable), and this fix simplifies the logic of that identification.

@GabrielMahan At your suggestion I also tried to get a sense of any performance impacts. I picked 10 equations from the test cases and solved each of them 100 times.

var examples = [
  '2 - x = -4 + x',
  '2x/3 = 2',
  '2x - 3 = x',
  '8 - 2a = a + 3 - 1',
  '2 - x = 4',
  '2 - 4x = x',
  '9x + 4 - 3 = 2x',
  '9x + 4 - 3 = -2x',
  '5x + (1/2)x = 27 ',
  '2x/3 = 2x - 4'
];
t = Date.now();
for (let i = 0; i < 100; i++) {
  for (let e of examples) {
    ms.solveEquation(e);
  }
}
console.log((Date.now() - t) / 1000);

The result is that performance appears very similar with this change, if not slightly better (~11.7s vs ~11.9s).

@GabrielMahan At your suggestion I also tried to get a sense of any performance impacts. I picked 10 equations from the test cases and solved each of them 100 times.

var examples = [
  '2 - x = -4 + x',
  '2x/3 = 2',
  '2x - 3 = x',
  '8 - 2a = a + 3 - 1',
  '2 - x = 4',
  '2 - 4x = x',
  '9x + 4 - 3 = 2x',
  '9x + 4 - 3 = -2x',
  '5x + (1/2)x = 27 ',
  '2x/3 = 2x - 4'
];
t = Date.now();
for (let i = 0; i < 100; i++) {
  for (let e of examples) {
    ms.solveEquation(e);
  }
}
console.log((Date.now() - t) / 1000);

The result is that performance appears very similar with this change, if not slightly better (~11.7s vs ~11.9s).

I also confirmed that all of our mocha tests in Dent pass with this mathsteps revision.

I also confirmed that all of our mocha tests in Dent pass with this mathsteps revision.


Move custom_limiter_detect_os_oom_failure to its own test

This test uses rlimit which can't be executed in parallel with other
tests. Previously this used libc::fork but the call afterwards to
libc::wait was racing all other child subprocesses since it would wait
for any child instead of the specific child we were interested in. There
was also difficulty getting the output of the child on failure coming
to the parent, so this commit simplifies the situation by moving the
test to its own executable where it's the only test.

cc @akirilov-arm was this the failure you were mentioning in yesterday's wasmtime meeting?

was this the failure you were mentioning in yesterday's wasmtime meeting?

Yes, in fact I managed to reproduce it on a Xeon machine with a large number of processors (80) as well.


Report devices that return an error during enumeration

Partially fixes https://github.com/achow101/HWI/issues/36 and should allow easier debugging in the future.

This reduces the error message I'm getting from a long crash stack to just an error field with the problem description, so it seems an improvement.

Pushed another fix so having an error opening a device while finding the prescribed fingerprint doesn't result in an erroneous error.
e.g., I want my Ledger to sign, but the Trezor is first in the list, so it throws an error rather than skipping over it.

ACK 92cc16a407d9930ef27db0596efe2f95b7ccbc45


[SPARK-28369][SQL] Honor spark.sql.decimalOperations.nullOnOverflow in ScalaUDF result

What changes were proposed in this pull request?
When a ScalaUDF returns a value which overflows, currently it returns null regardless of the value of the config spark.sql.decimalOperations.nullOnOverflow.
The PR makes it respect the above-mentioned config and behave accordingly.
How was this patch tested?
added UT

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12760/
Test PASSed.

Test build #107630 has started for PR 25144 at commit cc95f00.

Test build #107630 has finished for PR 25144 at commit cc95f00.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107630/
Test PASSed.

cc @JoshRosen @cloud-fan

thanks, merging to master!

thanks @cloud-fan @dongjoon-hyun @viirya!


[Lang] Layout in TVM node system

Per RFC we introduce Layout into TVM node system, and remove that from Relay.
Reviewers Please help to review @kevinthesun @merrymercy @tqchen

Only some minors, generally looks good to me

LGTM as long as we add topi layout_transform.

@kevinthesun @merrymercy @tqchen Thanks for feedback. Comments addressed, please review again.

Have one comment on changing layout.h->data_layout.h otherwise lgtm, will leave it to @merrymercy for moderation

@tqchen @merrymercy @kevinthesun Comment addressed. Please check again.

@tqchen @yzhliu @kevinthesun  Thanks. It is merged


How to achieve local refresh after login?

After logging in to my spa app, the whole page has been refreshed once. I don't want to use redirect_ Uri redirection, is there any other way?

No, sorry. That's how it works.


Windows Defender Exploit Guard (Not Device Exploit Guard)

Fixed typo and added link.

Thanks @npherson! One quick ask: please remove "en-us" from the URL. Leave the link language neutral, then the browser handles redirection to the proper localized repo.

Looks good, merging now.


Python version changes

The CLI docs imply that the python version can be changed using the "functionapp config set" options, but it doesn't appear to do anything.
az functionapp config set --python-version 3.7 --name shetldev --resource-group XYZ --subscription XYZ
If the python version can only be set on creation of the functionapp, this page should probably say so, and the CLI docs should not make it seem as if the python version can be changed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d955d169-8fb8-c511-8911-3e49f95c5ce6
Version Independent ID: 8a3d927c-51ce-d7d4-e5d1-acd928826db2
Content: Python developer reference for Azure Functions
Content Source: articles/azure-functions/functions-reference-python.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@dxkaufman Thank you for your feedback! We will review and update as appropriate.
cc: @ggailey777 @kulkarnisonia16

@ankitkumarr

Hi @Hazhzeng - Could you share your insights on this question?

@mike-urnun-msft
Yes, currently, we allow users to change Python version only on app creation az functionapp create --runtime python --runtime-version 3.7.

Thanks @Hazhzeng!
@dxkaufman I'll create a PR that clarifies this point on this doc.


Mock getRequestURI for AuthenticationFilter unit tests in common-auth

https://github.com/hortonworks/registry/pull/143


disabled NAMD integration workflow

See #4
Changes made in this Pull Request:

temporarily disabled the NAMD integration workflow
renamed file so that it does not end in yml/yaml

PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG updated?
[ ] Issue raised/referenced?

Note that the change does what it's supposed to be doing: the NAMD integration workflow is not running anymore.

Will do the same in the docker branch, closing this


No DOM related material in course

I can't see any DOM-related material in the entire course. I think this is too important topic to skip. What do you think about expanding the program or it's the thing that you should learn by yourself?
http://javascript.info has good chapter related to DOM.

@w96k thanks for the issue. I agree that learning about the DOM is important. However, freeCodeCamp's challenges are focused on interactive challenges and I'm not sure how to make learning about the DOM very interactive (I could be wrong). IMO, it might be better to have these as YouTube videos or wiki articles.
cc/ @freeCodeCamp/moderators

@w96k I agree with @erictleung, so I'm closing this. If you can come up with a good way to teach these interactively within our platform, please reopen this.

Thank you for the answer, will think about that.

If you cannot conceive of a way to teach the DOM within the interactive platform, then it needs to be made abundantly clear somewhere in the course that the DOM is a thing -- a critical thing -- that you must learn elsewhere, because one can't be a web developer without understanding it.
I would suggest a section in the curriculum, containing links to free resources elsewhere, e.g.:
https://mena.udacity.com/course/javascript-and-the-dom--ud117


Text wrap positively does not work

Issue Type: Bug
Hi, I'm really wanting to dive into VScode, but this text wrap thing is too much of an obstacle.
Brand new Big Sur OS install. Fresh VS install (after MANY uninstalls). Still, cannot toggle the text wrap feature. Way too much horizontal scrolling to do!
Hope you can suggest a fix? Thanks so much!
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z)
OS version: Darwin x64 20.1.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 x 3800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 1, 1

Memory (System)
32.00GB (19.46GB free)

Process Argv
--crash-reporter-id c4e6ddc7-f6f7-4517-be91-fe176164139d

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

prettier-vscode
esb
5.8.0

ftp-simple
hum
0.7.5

vim
vsc
1.17.1

Please provide detailed steps for how we can reproduce the behaviour that annoys you and describe the behaviour that you expect. I assume you have found the command to toggle the text wrap: View>Toggle Wordwrap.


docs in Snowflake: "Certificate attached to OCSP response is invalid"

Issue
Issue description
Not sure if this belongs here or in dbt-docs. When trying to run dbt docs generate on Snowflake, I'm getting the following error:
Running with dbt=0.13.0
Found 47 models, 0 tests, 0 archives, 0 analyses, 194 macros, 1 operations, 1 seed files, 1 sources

11:05:31 | Concurrency: 8 threads (target='dev')
11:05:31 |
11:06:47 | Done.
11:06:48 | Building catalog
Encountered an error:
254010: None: Certificate attached to OCSP response is invalid. OCSP response current time - 2019-04-17 15:07:08.666506+00:00 certificate not before time - 2018-04-17 12:15:42+00:00 certificate not after time - 2019-04-17 12:15:42+00:00 for sfc-ds1-customer-stage.s3.amazonaws.com

I wonder if it is related to a relatively recent change to Snowflake's python connector.
System information
The output of dbt --version:
installed version: 0.13.0
   latest version: 0.13.0

Up to date!

Well, since it is currently April 17th at 15:15 UTC, it looks to me like snowflake is responding with an invalid certificate (expired 3h ago), and recently added a check to make sure their certificates were valid. Those are mutually incompatible choices!
Does downgrading to snowflake-connector-python to 1.6.12 fix it?

Turned out they have an open issue with certificate issues with Python 2 version of connector.
https://github.com/snowflakedb/snowflake-connector-python/issues/59
I had same issue today.
I think I may have installed dbt on python2 on my Macbook.  Once I did pip3 install dbt...everything worked fine


Fixed html syntax in file

Fix #15
Catched these HTML syntax errors and fixed them

Hi @Biki-das the Issue attached to this needs more info and to move to ready for work before submitting a PR for it. I appreciate your enthusiasm, but please review the Contribution Guidelines and reopen a PR once the above criteria has been men.
Closing this for now.


Proposal: Generate Map method for all keyed lists.

See comment I sent offline for more details. This would mean that for all lists in compressed generation, that this method would be generated. For atomic lists the path simply ends here.
The benefits are (for compressed generation only),

Allows querying just the whole list without using batch.
Allows replacing on the whole list rather than one element at a time.

Should the suffix be "Map" instead of "All"? That "Any" means "return a slice" and "All" means "return a map" seems a little cryptic to me. What do you think?

Should the suffix be "Map" instead of "All"? That "Any" means "return a slice" and "All" means "return a map" seems a little cryptic to me. What do you think?

I like it. I'll use Map.

agreed on Map to prevent confusing Any with All

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.946%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1736

Relevant Lines:
2068

💛  - Coveralls


onTransitionEnd not called

It seems like this doesn't get called for me. I had to add a resolve at the bottom of the Promise callback, otherwise my modal windows didn't get destroyed.
https://github.com/RWOverdijk/dialog-sample/tree/4b33155c8e84f110f4e8f0bfdf85ce92371fe1e6 here's the app where it's broken (tested in chrome and firefox).

I found out that the reason for this, is that I didn't RTFM and forgot to add .plugin('aurelia-dialog') to main.js. PEBKAC.


Make an example gallery like Sunpy

Provide a general description of the issue or problem.
Sunpy has an awesome example gallery and I think new and experienced users use it all the time to see how to do basic and complicated things.
We should move the .ipynb examples to something that gets auto-built into examples by Sphinx.

Closed by #150


apiv2(ticdc): pause changefeed

What problem does this PR solve?

Issue Number: ref #8019
What is changed and how it works?
implement the open api v2 for pause a changefeed
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/merge

/merge

/merge

/run-egine-integration-test

/run-egine-integration-tests

/run-engine-integration-tests

/merge

/merge

/merge

/merge

/run-integration-tests


Add readonly storage buffer example on render pipeline

Currently no WGSL samples covers this GLSL use case in vertex shader:
layout(std430, set = 0, binding = 0) readonly buffer myBuffer {
    float numbers[];
} myBuffer;

Details of how readonly is specified is still in progress for WGSL. See https://github.com/gpuweb/gpuweb/issues/1159. Once that's finalized, I'll be happy to add an example that uses readonly storage buffers in the vertex shader :)

Hi, any updates on this?

What would be useful to demonstrate here that isn't already demonstrated by the read-only storage buffer in the compute stage of computeBoids?


Argument which print the actual version of vulnerabilities bases

Is your feature request related to a problem? Please describe.
For our Security team will be cool if we can provide the version of vulnerabilities bases which checks dependencies in project.
Describe the solution you'd like
Add a new argument which will print the actual version of vulnerabilities bases
Describe alternatives you've considered
We can just print by curl https://nvd.nist.gov/feeds/json/cve/1.0/nvdcve-1.0-modified.meta and https://raw.githubusercontent.com/Retirejs/retire.js/master/repository/jsrepository.json

We don't keep track of the lastModifiedDate of all of the NVD files.  We only keep track of the modified. This is already written into the reports; below is from one of the HTML reports.
NVD CVE Modified: 2019-11-11T15:02:18

One of the reasons we don't keep track of them all - if we have updated within the last seven days we only update based on the modified JSON file.

Ok, thanks for answer


add explicit make_dvcyaml arg

Fixes #381. This is a breaking change, so it will require a 2.0 release.

Merging to 2.0 branch to be safe.


:sparkles: support other destId type

I found a case type === XYZ && has top left, but destId is startWith bib.
{
    "start": 0,
    "end": 2,
    "rect": [
        507.742,
        723.345,
        515.962,
        733.323
    ],
    "str": "25",
    "page": 12,
    "rectDest": {
        "left": 303,
        "top": 489.986,
        "boundingRect": [
            [
                303,
                489.986
            ],
            [
                303,
                489.986
            ]
        ]
    },
    "type": "XYZ",
    "dest": "bib25",
    "color": {
        "0": 0,
        "1": 0,
        "2": 0
    }
}

pdf:
doc (4).pdf

Hi, thank you for your contribution, and I'm very sorry for the late response.

I think we have to apply this change to a few more lines. grep "cite." src/ -r will show you all the relevant locations.
I'm thinking about adding an option that lets the user to specify any regular expressions instead of hard-coding them in the source code. How do you like this?

copy that! 👍
This is a great project for me, and I've been working on PDFs lately, so I hope we can work together to make this project more usable.


Bug: Some images cannot be uploaded due to livewire?

A really bad quick fix might include something along the lines of:
// Stupidest solution out there:
$clientName = $input['photo']->getClientOriginalName();
$encodedClientName = utf8_encode($input['photo']->getClientOriginalName());
$hasEncodingIssues = $clientName != $encodedClientName;

If there is enough time, redoing the component itself might be beneficial. @TimKardol what do you think?


Only seeing a big O

Hey,
When I use the mobile route advisor I just get to see this.

This is my crahs dump:

I get it while using ets2mp.
Can you help me?
Borek

The "big O" is a message box that will show certain messages depending on the state of the game (such as "Connected, waiting for the drive...").  Anyways, I'm guessing there's some sort of JavaScript error that is occurring on the skin.  Are there any errors in the JavaScript console? (press Ctrl+Shift+J to open the console in Firefox)

Thanks for the really fast answer. This is what I get:

Btw I have the problem to on my Ipad.

In another browser the same problem?
Maybe can browser extensions affect this behavior

I have this problem with every browser on my pc and with every browser on my Ipad. I did see it said : "Connected, waiting for the drive..." before I started the game.

I'm going to go ahead and close this since it has been inactive for about 3 months. If you continue to have an issue, feel free to open a new issue.


add icann option

fix issue #4  #6

Coverage remained the same at 100.0% when pulling 1c4dda9c768d4cb57e1af4b4d878fae0e617fed9 on alsotang:master into 525be70ecf5ac828a6ba19e7683a1b5ed7ac1ed2 on peerigon:master.

Coverage remained the same at 100.0% when pulling 1c4dda9c768d4cb57e1af4b4d878fae0e617fed9 on alsotang:master into 525be70ecf5ac828a6ba19e7683a1b5ed7ac1ed2 on peerigon:master.

ping @jhnns

Coverage remained the same at 100.0% when pulling e58f2ba12510c017feea2ae318085c77dcf65fb0 on alsotang:master into 525be70ecf5ac828a6ba19e7683a1b5ed7ac1ed2 on peerigon:master.

Awesome, thx! 👍 I was just about to write that for myself :)
I've merged this PR locally because it had a conflict. I'll publish a 1.0.0 tomorrow.
FYI: I've renamed options.icann to options.includePrivateTlds which is false by default. I think, most users would not expect blogspot.com to be a TLD.

Yeah, I also think most user dont want to non-icann tlds. That socall effective-private-tld always make misunderstand.

can we just name the option private?

We can name it privateTlds, but private is too generic

ok, I agree with we should use a non-generic name.
And should we make privateTlds : false a default option?
I think the feature of private tld is unpredictable and obscure. I really doubt that how many people would rely on this feature.
If we still make privateTlds: true default, does the harm of the confusion of new users greater than its compatibility?

Yes, it should be privateTlds: false by default. I tripped over it too.


Copy PWD to clipboard

# Copy the PWD to the Clipboard
alias cpwd="pwd | tr -d '\n' | pbcopy && echo 'pwd copied to clipboard'"

https://kyleshevlin.com/bash-shortcut-copy-your-present-working-directory-to-your-clipboard

Added in house cleaning.


Better document component className buildup methods

Reference https://github.com/TechnologyAdvice/stardust/blob/master/src/utils/propUtils.js#L76
Explain the 4 types of props to className permutations:

[x] show all 4 html examples
[x] show all 4 API examples
[x] show cx propUtil methods for each
[x] show common tests for each

/cc @jamiehill this is regard to https://github.com/TechnologyAdvice/stardust/pull/278#discussion_r68427862
Which ever of us starts working on this first, just leave a comment.  This way we don't duplicate efforts.

Fixed in #317


Fibonacci_numbers.java and alternating_characters.java

Added Fibonacci_numbers.java and alternating_characters.java and updated the README.md

I'm sorry but I think that their is a conflict because of Readme.md file having the same name in both the repo(the one I forked and the master) you can go through the readme.md of my repo here and you can see that there is no issue with it and it is safe to be merged. :)


Added additional options for additional security

To prevent sensitive user input being saved to shell history I provided additional options

-sp or --securepassphrase

This option activates the passphrase option, but the passphrase is not entered directly in the initial command but in a prompt during program execution. For this the Python library getpass is used for added security.
To create a new mnemonic with passphrase enter
$ python -m iota_mnemonic -sp

and then enter the passphrase when prompted.

-m or --mnemonic

This option allows entering the mnemonic and outputs the corresponding IOTA seed.
To recover the IOTA seed from a mnemonic enter
$ python -m iota_menmonic -p TREZOR -m mnemonic "often various act decide tongue sausage summer wall priority knock finish until taxi robot panic toward giraffe acid avocado anchor travel kiwi actress cream"

-sm or --securemnemonic

The same as option --mnemonic but again using the getpass library for added security.
To recover a seed from mnemonic enter
$ python -m iota_mnemonic -sm

and then enter the mnemonic when prompted.
The options can be freely combined. To recover a seed from a mnemonic and a passphrase enter
$ python -m iota_mnemonic -sm -sp

So, I completely replaced the old options with the new ones and updated the readme accordingly. Should be ready for the pull request now.


Add quantitativeType

Added quantitative types to properties which should have units using the DTDLv3 annotations and overrides functionality. The additional annotation and override property was added only for the properties which could have variation in the unit. If there is a global standard (i.e. electrical current=ampere) and no anticipated variation, no additional property was added.
This PR adds quantitative types for all DTDL models except the Capabilities which can be addressed in a future PR.

Would love to review, but first: can v3 models with these features be public right now, given that v3 is not released publicly (NDA issues etc)?


Purple Worm Error

I am not sure where these worms come from, most likely Graham's Things or Apotheosis but they cause this error text which no other mob does.

fixed for not release


Adding imgBB

C'mon! Just add it!

This repository is no longer maintained per the README, and development of the forums might only be in a private repository.
This repository (s2forums) should be archived as it has been deprecated.


Use correct unit in charge history durations

It seems that Zoe50 reports durations in seconds not minutes.
Ref #562
cc @jumpjack

It looks like charge-history returns duration in minutes while charges returns in seconds...
/charge-history:
        {
            "day": "20220317",
            "totalChargesNumber": 1,
            "totalChargesEnergyRecovered": 5.4,
            "totalChargesDuration": 241
        },

/charges:
        {
            "chargeStartDate": "2022-03-17T01:01:10Z",
            "chargeEndDate": "2022-03-17T05:02:01Z",
            "chargeDuration": 14451,
            "chargeEndBatteryLevel": 74,
            "chargeEndStatus": "error"
        },

/charge-history is not working (above error), /charge sessions works fine:
Charge start         Charge end           Duration    Power (kW)    Started at    Finished at    Charge gained    Power level    Status
-------------------  -------------------  ----------  ------------  ------------  -------------  ---------------  -------------  --------
2022-03-16 03:02:16  2022-03-16 05:01:58  1:59:42                   62 %          62 %                                           error
2022-03-16 21:18:42  2022-03-16 22:50:08  1:31:26                                 60 %                                           error
2022-03-17 02:01:10  2022-03-17 06:02:01  4:00:51                                 74 %                                           error
2022-03-18 02:01:13  2022-03-18 06:02:04  4:00:51                                 64 %                                           error
2022-03-18 18:34:28  2022-03-18 18:37:57  0:03:29                                 55 %                                           error
2022-03-18 18:40:37  2022-03-18 19:17:22  0:36:45                                 89 %                                           error
2022-03-19 16:18:18  2022-03-19 17:36:04  1:17:46                                 99 %                                           error
2022-03-20 22:21:31  2022-03-21 07:32:50  9:11:19                                 71 %                                           error

But /charge-sessions endpoint gives a "404 - not found" error on my script, I can use only /charge-history and /charges

I didn't update anything, but this morning both "charge history" and "charge sesssions" are working.
But this morning we also have amazing data from renault...
        {
            "chargeStartDate": "2022-03-21T23:35:12Z", <<============= wrong day
            "chargeEndDate": "2022-03-21T06:32:50Z",
            "chargeDuration": -61342,                 <<============== negative duration
            "chargeEndBatteryLevel": 71,
            "chargeEndStatus": "error"
        }

We have a negative time, because charge ended before starting....
Renault did a mess with date/time localization: they use YYYY-MM-DDTHH:MM:SSZ format, but the time is not UTC, is local... I also noticed it for charge schedule and hvac schedule.
Unfortunately, this night the charge started at 23:35 local, but if you store it as 23:35Z, it means 00:35 of next day, so you should also change the day from 21 to 22...
Result from your script:
2022-03-22 00:35:12  2022-03-21 07:32:50  -1 day, 6:57:38
A further mess is that the two commands show different data....
My formatted output for /charge-history:
day	totalChargesDuration	totalChargesNumber	totalChargesEnergyRecovered
20220310	0
20220311	206	1	5.1
20220312	121	1	28.85
20220313	213	1	5.05
20220314	310	1	5.95
20220315	0
20220316	212	2	4.95
20220317	241	1	5.4
20220318	282	3	23.5
20220319	78	1	20.65
20220320	84	1	28.15	<<<<<<<<==========
20220321	552	1	12.5
20220322	388	1	8.65

My raw output for /charges:
   "charges": [
        {
            "chargeStartDate": "2022-03-16T02:02:16Z",
            "chargeEndDate": "2022-03-16T04:01:58Z",
            "chargeDuration": 7182,
            "chargeStartBatteryLevel": 62,
            "chargeEndBatteryLevel": 62,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-16T20:18:42Z",
            "chargeEndDate": "2022-03-16T21:50:08Z",
            "chargeDuration": 5486,
            "chargeEndBatteryLevel": 60,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-17T01:01:10Z",
            "chargeEndDate": "2022-03-17T05:02:01Z",
            "chargeDuration": 14451,
            "chargeEndBatteryLevel": 74,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-18T01:01:13Z",
            "chargeEndDate": "2022-03-18T05:02:04Z",
            "chargeDuration": 14451,
            "chargeEndBatteryLevel": 64,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-18T17:34:28Z",
            "chargeEndDate": "2022-03-18T17:37:57Z",
            "chargeDuration": 209,
            "chargeEndBatteryLevel": 55,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-18T17:40:37Z",
            "chargeEndDate": "2022-03-18T18:17:22Z",
            "chargeDuration": 2205,
            "chargeEndBatteryLevel": 89,
            "chargeEndStatus": "error"
        },
        {
            "chargeStartDate": "2022-03-19T15:18:18Z",
            "chargeEndDate": "2022-03-19T16:36:04Z",
            "chargeDuration": 4666,
            "chargeEndBatteryLevel": 99,
            "chargeEndStatus": "error"
        },
        {                                         <<<<<<<<<<<<=============== Where is 2022-03-20 ???
            "chargeStartDate": "2022-03-21T23:35:12Z",
            "chargeEndDate": "2022-03-21T06:32:50Z",
            "chargeDuration": -61342,
            "chargeEndBatteryLevel": 71,
            "chargeEndStatus": "error"
        }
    ]

Renault API is a mess - always.
I can always help with the processing of the result, but I cannot help with the content that we receive from Renault!

Nobody knows what's inside the brain of Renault developers.


[Website] Display non harmonized symbol on molecular data tables when hgnc symbol is not available

explanation is yet to be implemented


Use experimental streams for interop with NodeJS Writables and Readables

This PR is a work-in-progress conversion of the @effect-ts/node/Stream interop module that provides an interface for converting between the NodeJS stream module and the Effect-TS experimental stream module.

I could probably use a second set of eyes on the types I'm returning for the experimental Stream API 🙏 .

@r-cyr - do you think you're implementation of transform is "ready" enough to be pulled into this PR? If so, let me know and I can grab it from the gist.


Non-function paramtypes rewritten to Object

I'm using a little hacky solution in my NestJS projekt where I overwrite a string-const export with a type.
export type Configuration<T extends {} = {}> = T & InferConvict<typeof DEFAULT_SCHEMA>;
export const Configuration = 'CONFIGURATION' as unknown as Type<Configuration>;

So I can use this construct to inject a dependency with the proper typing
class Example {
    constructor(protected readonly config: Configuration) {}
}

This works well in ts-node, as with tsc and node but not with ts-node-dev. The reason is the following generated code:
let Example = class Example {
    constructor(config) {
        this.config = config;
    }
}
Example = __decorate([
    __metadata("design:paramtypes", [typeof (_a = typeof configuration_1.Configuration !== "undefined" && configuration_1.Configuration) === "function" ? _a : Object]
]);

Is there an option to disable this "feature"?

Not sure I get. Could you add a reproduce code snippet to test it?

Will close, reopen if needed.


[Feature Request] Please provide a way to add custom buttons to the toolbar and a way modify behaviour of existing ones

In my use case I need to add a button to upload files and another one to browse them.

You already can add custom buttons by changing the toolbar config option, you can also set custom functions!

@clubdesign I'm new to this editor. Can you give me a few pointers for adding a custom button and setting a custom function. I want to replace the image button with a button which will allow me to use the google file picker to choose the image url. This will return the url for adding to the simplemde editor.( I already wrote the code to get the image url from the picker)

You'll need to use the toolbar option:
// Customize all information and/or add your own icons
var simplemde = new SimpleMDE({
    toolbar: [{
            name: "bold",
            action: SimpleMDE.toggleBold,
            className: "fa fa-bold",
            title: "Bold (Ctrl+B)",
        },
        "|", // Separator
        ...
    ],
});

Just change the action to a function of your own.

Thanks Wes
I already went that route.
I ended up setting the values in the options.insertTexts.image array with
the image url returned from the google picker and then called drawImage
A bit dirty but it got the job done fast.
¸ ...      ___________
·´º o`·, /__/ _/_ ____/\
 °´ ¸,.-·~·~·-.,¸ `°·-. :º° ·~·~·-..,¸
Property South Costa Blanca
http://www.MaxGoldHouse.com

On 25 November 2015 at 19:58, Wes Cossick -<EMAIL_ADDRESS><
<EMAIL_ADDRESS>wrote:

> You'll need to use the toolbar option:
>
> // Customize all information and/or add your own iconsvar simplemde = new SimpleMDE({
>     toolbar: [{
>             name: "bold",
>             action: SimpleMDE.toggleBold,
>             className: "fa fa-bold",
>             title: "Bold (Ctrl+B)",
>         },
>         "|", // Separator
>         ...
>     ],
> });
>
> Just change the action to a function of your own.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NextStepWebs/simplemde-markdown-editor/issues/183#issuecomment-159716155>
> .
>

@dindinet @WesCossick So that means you have to customize the whole toolbar, you cannot modify the existing one, right?
I'd say this use case is not very clear in the documentation, but I'd say is a pretty common scenario.
Thanks for the heads up!

Actually I just added one new button. which triggered my code t fetch the
url from google then pushed the result into the options.insertTexts.image
array and called the drawImage.
I suspect this would be messy with more than one editor on the page.
somehting like
function drawCustom(editor, customStuff) {
var cm = editor.codemirror;
var stat = getState(cm);
_replaceSelection(cm, stat.image, customStuff);
would be handy
¸ ...      ___________
·´º o`·, /__/ _/_ ____/\
 °´ ¸,.-·~·~·-.,¸ `°·-. :º° ·~·~·-..,¸
Property South Costa Blanca
http://www.MaxGoldHouse.com

On 25 November 2015 at 22:51, Angel Ruiz -<EMAIL_ADDRESS><
<EMAIL_ADDRESS>wrote:

> @dindinet <https://github.com/dindinet> @WesCossick
> <https://github.com/WesCossick> So that means you have to customize the
> whole toolbar, you cannot modify the existing one, right?
> I'd say this use case is not very clear in the documentation, but I'd say
> is a pretty common scenario.
> Thanks for the heads up!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NextStepWebs/simplemde-markdown-editor/issues/183#issuecomment-159749381>
> .
>

@dindinet
So you did something like:
toolbar.push({
  myButtonsSettings: ...
});

Nevermind I think I got it now...

@aruizca, @dindinet I'm not seeing any way to add an additional custom toolbar button without re-specifying the entire set of default buttons in the toolbar option (implied by the 3 dots in the snippet from @WesCossick above). But it sounds like you were able to do that. If so, what am I missing?

@dae721 I can't either find it. I think they are adapting the original library code. At least _replaceSelection(cm, stat.image, customStuff); function is private and is not available outside the library.
@WesCossick this is sad that you don't pass your helper functions like _replaceSelection  to the action function. That means we should implement just the same function or to make a library fork, shouldn't we?

@smnbbrv I finally noticed something a couple days ago that helps: the array passed in for the toolbar option can be a mix of strings and icon objects. If it's a string, SimpleMDE looks it up and replaces it with the corresponding icon object. I originally thought the entire array had to be icon objects so I was redefining each one using code from SimpleMDE's builtInButtons. Instead, you can do something like this (I'm using typescript, where SimpleMDEEx is a subclass of SimpleMDE):
myButtons: Array<string|SimpleMDE.ToolbarIcon> = [
  "bold", "italic", "strikethrough", "heading", "|", "code", "quote", "unordered-list", "ordered-list",
  {
    name: "outdent",
    action: (mde: SimpleMDEEx) => mde.outdent(),
    className: "fa fa-outdent",
    title: "Decrease Indent (Shift-tab)"
  },
  {
    name: "indent",
    action: (mde: SimpleMDEEx) => mde.indent(),
    className: "fa fa-indent",
    title: "Increase Indent (tab)"
  },
... the rest ...
];

@dae721 nice catch!

@smnbbrv No, and I agree that would be nice. Instead I've put that type of functionality in my subclass (SimpleMDEEx above). I haven't needed _replaceSelection yet, but I've defined similar functions such as appendToCurrent and insertAfterLine (as well as indent and outdent shown above). These use codemirror directly and don't have any dependencies on SimpleMDE internals. Probably the same could be done for _replaceSelection, but it would be duplicating code of course.

myButtons: Array<string|SimpleMDE.ToolbarIcon> = [
  "bold", "italic", "strikethrough", "heading", "|", "code", "quote", "unordered-list", "ordered-list",
  {
    name: "outdent",
    action: (mde: SimpleMDEEx) => mde.outdent(),
    className: "fa fa-outdent",
    title: "Decrease Indent (Shift-tab)"
  },
  {
    name: "indent",
    action: (mde: SimpleMDEEx) => mde.indent(),
    className: "fa fa-indent",
    title: "Increase Indent (tab)"
  },
... the rest ...
];

@ialex90
You can do like this
    action: function customFunction(editor){
        editor.codemirror.replaceSelection("your words")
    }

This feature is alreay implemented in sparksuite/simplemde-markdown-editor/pull/613, Please accept it.


overlayRef is always undefined for cdkconnectedoverlay

Bug, feature request, or proposal:
This seems to be a bug , when I am trying to update the width of overlay using overlayref it always comes undefined
What is the expected behavior?
Ideally I should be able to update overlay using overlayref
What is the current behavior?
currently overlay reference is undefined
What are the steps to reproduce?
this can be reproduced on stackblitz , console should give the overlay reference
https://stackblitz.com/edit/cdk-connected-overlay-mtwlwv
What is the use-case or motivation for changing an existing behavior?
I am unable to update the overlay properties
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/core": "~5.1.3",
"@angular/cdk": "~5.0.3",
Is there anything else we should know?

The OverlayRef gets created when the overlay is opened. It looks like you're accessing it too early.

I tried with timeout with 2000 ms , still get the undefined, am i missing something here


Problem with colors in version 2.0.2

When I use Calligraphy 2.0.2 the colors of my Application are ok, but since I have updated to Calligraphy 2.1.0, the following happens :

In API 19 the following elements become white -> TextViews, EditTexts, simple_list_items, AlertDialog titles.
In API 21 the previously mentioned elements, become black.

I use AppCompat.Light theme in my App.

Can you provide a full example?

In my application i use MaterialNavigationDrawer library: https://github.com/neokree/MaterialNavigationDrawer/wiki/Moving-to-MaterialNavigationDrawer
which uses Theme.AppCompat.Light theme.
With Calligraphy 2.0.2 my application looks like this in both 19 and 21 APIs:

With Calligraphy 2.1.0 my app looks like this in API 19:

With Calligraphy 2.1.0 my app looks like this in API 21:

Mmm. You'll need to paste more code. Worth noting I don't support that
library. And that appcompat has a few bugs in it with theming pre 21.
On Mon, 3 Aug 2015 09:01 Fivos Stamopoulos<EMAIL_ADDRESS>wrote:

In my application i use MaterialNavigationDrawer library:
https://github.com/neokree/MaterialNavigationDrawer/wiki/Moving-to-MaterialNavigationDrawer
which uses Theme.AppCompat.Light theme.
With Calligraphy 2.0.2 my application looks like this in both 19 and 21
APIs:
[image: screenshot_2015-08-03-10-35-37]
https://cloud.githubusercontent.com/assets/7528533/9032959/10c1d80e-39cc-11e5-8b2e-80b42781ea25.png
[image: screenshot_2015-08-03-10-35-31]
https://cloud.githubusercontent.com/assets/7528533/9032963/1597d37e-39cc-11e5-804a-9a9209ac4bab.png
[image: screenshot_2015-08-03-10-35-17]
https://cloud.githubusercontent.com/assets/7528533/9032964/189811ba-39cc-11e5-9c01-5faceaed91f2.png
With Calligraphy 2.1.0 my app looks like this in API 19:
[image: screenshot alert dialog]
https://cloud.githubusercontent.com/assets/7528533/9033235/fdac7722-39cd-11e5-9c76-5382398d5bd6.png
[image: screenshot dialog]
https://cloud.githubusercontent.com/assets/7528533/9033236/01623636-39ce-11e5-845a-b8d771065b53.png
[image: screenshot_2015-08-03-10-35-31]
https://cloud.githubusercontent.com/assets/7528533/9033239/063fd21c-39ce-11e5-8442-072c1d5ac0b7.png
With Calligraphy 2.1.0 my app looks like this in API 21:
[image: screenshot_2015-08-03-10-56-00]
https://cloud.githubusercontent.com/assets/7528533/9033350/ecc86730-39ce-11e5-97e4-edd4f9961d9e.png
[image: screenshot_2015-08-03-10-56-07]
https://cloud.githubusercontent.com/assets/7528533/9033351/f03023b8-39ce-11e5-8a99-adfbbde64d45.png
[image: screenshot_2015-08-03-10-57-30]
https://cloud.githubusercontent.com/assets/7528533/9033356/f37a7564-39ce-11e5-93a9-c0c7d751c462.png
—
Reply to this email directly or view it on GitHub
https://github.com/chrisjenx/Calligraphy/issues/197#issuecomment-127154819
.


Version 2.0 candidate

The algorithms branch has been in development for quite some time and is a series of fundamental differences between a few assumptions previously built into geometry.hpp library.
Breaking Changes

Addition of empty in variant
mapbox::geometry::feature now is mapbox::feature::feature and is in different location header.
Feature id is now a variant

Dev Changes

HPP Skel layout
Catch HPP for testing
Added google benchmark for testing perf
Added clang format and clang tidy

mapbox::geometry::feature now is mapbox::feature::feature and is in different location header.

What's the rationale for this change?

@brunoabinader the rationale for the change is to not require the use of feature.hpp by default when including geometry.hpp. Ideally these are different concepts and you should be getting geometry.hpp when including feature.hpp not the other way around.


Fix interval parsing logic and precedence

I originally opened an issue for this on the DataFusion side: https://github.com/apache/arrow-datafusion/issues/3944, but found the error to lie in how the queries were being parsed.
These changes allow something like "SELECT col FROM test WHERE d3_date > d1_date + INTERVAL '5 days' AND d2_date > d1_date + INTERVAL '3 days'" to be parsed correctly. Previously, the '5 days' was getting separated from the INTERVAL keyword and lumped into the AND operator.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

13 of 14 (92.86%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 86.181%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
13
14
92.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
11581

Relevant Lines:
13438

💛  - Coveralls

I'm having trouble creating a test for this. Right now I have something like:
#[test]
fn parse_interval_and_or_xor() {
    let sql = "SELECT col FROM test \
        WHERE d3_date > d1_date + INTERVAL '5 days' \
        AND d2_date > d1_date + INTERVAL '3 days'";

    let ast = Parser::parse_sql(&GenericDialect {}, sql).unwrap();

    let expected_ast = vec![Query(Query {
        with: None,
        body: Select(Select {
            distinct: false,
            top: None,
            projection: vec![UnnamedExpr(Identifier(Ident { value: "col".to_string(), quote_style: None }))],
            into: None,
            from: vec![TableWithJoins {
                relation: Table {
                    name: ObjectName(vec![Ident { value: "test".to_string(), quote_style: None }]),
                    alias: None,
                    args: None,
                    with_hints: vec![] },
                joins: vec![] }],
            lateral_views: vec![],
            selection: Some(BinaryOp {
                left: BinaryOp {
                    left: Identifier(Ident { value: "d3_date".to_string(), quote_style: None }),
                    op: Gt,
                    right: BinaryOp {
                        left: Identifier(Ident { value: "d1_date".to_string(), quote_style: None }),
                        op: Plus,
                        right: Interval {
                            value: Value(SingleQuotedString("5 days")),
                            leading_field: None,
                            leading_precision: None,
                            last_field: None,
                            fractional_seconds_precision: None } } },
                op: And,
                right: BinaryOp {
                    left: Identifier(Ident { value: "d2_date".to_string(), quote_style: None }),
                    op: Gt,
                    right: BinaryOp {
                        left: Identifier(Ident { value: "d1_date".to_string(), quote_style: None }),
                        op: Plus,
                        right: Interval {
                            value: Value(SingleQuotedString("3 days")),
                            leading_field: None,
                            leading_precision: None,
                            last_field: None,
                            fractional_seconds_precision: None } } } }),
            group_by: vec![],
            cluster_by: vec![],
            distribute_by: vec![],
            sort_by: vec![],
            having: None,
            qualify: None }),
        order_by: vec![],
        limit: None,
        offset: None,
        fetch: None,
        lock: None })];

    assert_eq!(actual_ast, expected_ast);
}

But this is pretty clunky, plus the main thing we want to check is that the selection value (with all the nested BinaryOps) is correct. I was wondering what the best way to do this would be?

Thank you for the contribution @sarahyurick

Thanks @alamb @AugustoFKL ! Let me know what you think. Should I update anything with the precedence logic, or just keep as is for now?

Thanks again @sarahyurick  and @AugustoFKL


RPC protocol update + multi-view plumbing [ready]

~edit: After a bit of playing around there may be a few performance regressions I want to look at, but this is good for review.~ (all good)
This is approximately where I would like it to be in terms of the API modifications discussed in #191. It also includes a variety of naming changes, which are intended to more clearly document the use of particular APIs & methods. I'm touchy about renaming other people's code: please consider all naming changes to be suggestions, and I'm happy to revert them. 😄
RPC Changes:
Because this already involved breaking changes to the RPC protocol, I took the liberty of normalizing certain other RPC signatures.

In all RPC methods, the word tab as an identifier of 'client viewports' has been replaced with view_id.
in all RPC methods, the word filename has been replaced with the word file_path. (We were using both in different places, I just grepped the src directory and picked the most common).
TabCommand is now CoreCommand. (not a protocol change)
NewTab and DeleteTab (new_tab, delete_tab) have been removed from CoreCommand.
NewView { file_path }, CloseView { view_id } and Save { view_id, file_path } have been added to CoreCommand.
Open and Save have been removed from EditCommand.

In error messages and other names, the word tab has been replaced with core, where appropriate.
Other changes:
The other main change here is that Editor now behaves as it if has multiple views, although the actual multi-view support isn't implemented. To reduce the diff size, Editor still does everything through a self.view instance. There is code in place to dynamically swap this variable out when an event arrives associated with a new view, but these codepaths are not currently available.
Anyway: the real consequence of this is that events and responses are associated with a specific view_id, rather than a buffer+view (e.g. a 'tab'). This plus the clarified view and editor lifecycle stuff enabled by the RPC changes set me up to hopefully start implementing provisional plugin support. Maybe? 🤞
To think about:

What is the role of TabCtx, now? with message routing now based on view_id, which isn't owned by a particular TabCtx, this should be rethought.
How will actual multi-view support happen, and what refactoring is required to make that possible? It still feels like there's a lot of state split between the editor and the view. I haven't looked into this very much.
Are  there any other protocol changes to make now, while we're already breaking things?

@raphlinus 🚀

I was testing out RLS vim integration. self. produces lots of useful completion suggestions! 😞

Thanks!


Block Break Stage disappears on server restart

3.6.6, 3.6.7, 3.6.8dev
If a player is on a quest stage that requires them to break a certain amount of blocks (100 dirt blocks) then on a server reset if they are in teh process of completing it (50/100 dirt blocks) then the quest completely loses its stages and the player has to quit the quest and restart it
Screenshot of how the quest shows up in the Quest Journal after a restart.

Possibly related to #772

@Nericu Please check if http://ci.ac3-servers.eu/job/Quests/742/ resolves the issue.

Seems to still be happening, on a side note (prob should be another issue) it seems teh quests.yml file cannot be read if using spigot 1.14.1 btw...had to revert to 1.14 just to get our quests back and it even erased all the player data so I had to give everyone their quests back and stuff.

@Nericu I'll keep looking into this then. Thanks!
Definitely create another ticket for the 1.14.1 issue, if you can.

Ok only prob is I dont have a ton of information on it but I will do what I can

Since the Jenkins server is down, try this build and let me know the results:
https://www.dropbox.com/s/vlu1dd2v0hxibrh/Quests-3.7.1.jar?dl=0

Since the Jenkins server is down, try this build and let me know the results:
https://www.dropbox.com/s/vlu1dd2v0hxibrh/Quests-3.7.1.jar?dl=0

I will try it when I get done work today and get back to you on it. Thanks

Ok that build didn't resolve the issue, in fact this build removed all quests from everyone each startup. The quests were there to get but if the server restarted everyone lost all quests and progress on them...

Alright, sorry for the inconvenience. I hope to find a proper solution soon.

@Nericu I’m having trouble replicating this on Quests 3.7.7. Is this still happening for you?

Hey @Nericu, I can't seem to replicate the issue either. We're thinking it may have been fixed accidentally already.

Sounds good, I will update if I am still having trouble but wont be able to really test until tomorrow.

Yeah looks like I am still having this issue. I honestly have no idea what it could be other then McMMO Overhaul because that is the only thing that effects woodcutting on our server but I cant see that resetting the entire quest....

@Nericu could you send your config and maybe a video of it happening?

https://clips.twitch.tv/CaringSilkyGiraffeTTours thats a clip of it happening. It seems all you have to do now is just leave/join the server for it to reset as well, before it was just upon restarts that it messed it up.
Quests.yml - https://pastebin.com/Q96wDw9G
Config.yml - https://pastebin.com/dEPnKwK3

I was able to replicate this using your quest. The problem only arises when the block break objective is the Stage 2 of the quest. Using the objective for Stage 1 works as expected.
For anyone else testing this, here's the same quest which I've stripped of unnecessary fields:
https://pastebin.com/cemhSCmk
Code-wise, I'm seeing the blocksBroken list doesn't appear to be populated after re-logging, which in turn causes a loop in showObjectives to go untriggered.
Unfortunately, that's all the time I have for now. Will investigate further soon.

Yep, I was able to reproduce it too. The root issue is that when loading the data, it's attempting to set the blocks broken into a list at certain indices instead of appending them, requiring a pre-allocated list made by addEmptiesFor. The stage number for this was hardcoded to be the first stage only, so any stages past that will lose their data. I'm pushing a simple fix for this.

Awesome glad this has been figured out. Would either one of you be able to also check the smelting quest. I submitted an issue with it just not tracking at all awhile back and think it might also be because its a stage 2 quest as well.

@Nericu the only quests that should have been affected by this bug are blocks broken, placed, damaged, used, and cut. Your smelting quest worked fine for me, both with and without the fix - if there's an issue with it then it's a different bug.

Ok no worries just figured I would check thanks


Tests

check inheritance and ensure properties return expected values

Was planning to use mock library but didn't and forgot to edit the docstring. Have modified the docstrings


Highlighting disappears when switching tabs

The syntax highlighting seems to work fine on initial page load, but when switching to the Commits or Activity tabs the highlighting disappears.

This might be somehow related to the Highlight modal code and collapsed code ticket but I'm not sure exactly.
I took a quick peek at the code and if I can free up some time over the course of the next few weeks I might be able to try and help out.

Yep. I'm pretty sure they're related. The thing is that for each of these events (tab change, show more code etc.) we need to call prism.highlightAll().
Thank you very much!

@hk0i , the problem is already solved. You can check by downloading the new version.


Does anyone tried to implement this in Raspberry Pi?

Hello, I would like to ask does anyone tried to implement this in Raspberry Pi 4? Can you please help how to do it? Thank you.

Looking for the same

I managed to make this work in Raspberry Pi, although running Manjaro 64 bit OS.
https://github.com/werman/noise-suppression-for-voice/issues/40

https://forums.raspberrypi.com/viewtopic.php?t=358993


Deploy resource only if there are no error in yaml

This PR disable auto deploy, if resource has yaml syntax errors.

Note: it doesn't take in account schema validation, we need to look on how we can get validation result from YAML LS

Codecov Report

Merging #326 into master will decrease coverage by 0.79%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   74.25%   73.46%   -0.80%
==========================================
  Files          45       45
  Lines        3383     3399      +16
  Branches      630      632       +2
==========================================
- Hits         2512     2497      -15
- Misses        871      902      +31

Impacted Files
Coverage Δ

src/tekton/deploy.ts
44.23% <75.00%> (-53.81%)
:arrow_down:

src/yaml-support/tkn-yaml.ts
90.22% <87.50%> (-0.08%)
:arrow_down:

src/yaml-support/yaml-locator.ts
89.06% <100.00%> (+1.34%)
:arrow_up:

src/tkn.ts
65.31% <0.00%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb63ce6...ff93b1a. Read the comment docs.


Makefile: do not hardcode prefix on macOS

Installing anything in /usr should rather be avoided on macOS, and in any case there is no need to hardcode that.

Looks like it actually still tries to use /etc/xdg, i.e. overriding does not work correctly:
Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_sysutils_albafetch/albafetch/work/albafetch-6d34bb67a7e1eae7b750b8e807271bf3a728cb48" && /usr/bin/make -w install DESTDIR=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_sysutils_albafetch/albafetch/work/destroot
make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_sysutils_albafetch/albafetch/work/albafetch-6d34bb67a7e1eae7b750b8e807271bf3a728cb48'
mkdir -p /usr/local/bin /etc/xdg
mkdir: /etc/xdg: Permission denied
make: *** [install] Error 1

Ah, that is because this does not work:
OS := $(shell uname -o 2> /dev/null)

Correct flag is -s:
36-25% uname -o
uname: illegal option -- o
usage: uname [-amnprsv]
36-25% uname -s
Darwin

@alba4k Ok, now this seems to work finally. Overrides were failing due to an invalid flag with uname.
P. S. Ubuntu CI fails on PATH_MAX, unrelated to this.

yeah, I noticed. plan on fixing that once I get home

wait though, uname -o worked on mac last time I tried and the output was Darwin. I need it to be -o because -s gives Linux on both Android and (GNU)/Linux

Ok, let me drop the uname commit and just leave the prefix one. (Please fix uname then later.)


Hardcode default services/topics/actions for each node in a converted policy

These defaults consist of (but are not limited to):

Services:

describe_parameters
get_parameters

Topics:

rosout
parameter_events

TODO

[x] Find entire set of defaults for rclcpp/rclpy client libraries.

Ensure these default sets are the same for both client libraries. If not, have to figure something out. (set unique?)

[x] "Hard code" the defaults into each node in each converted policy.

See if there is a "smarter" way of doing this, namely through the xinclude/xpointer mechanism.

The set of "defaults" can be found here. This brings up the distinction between a regular node and a lifecycle node, which is not sufficiently expressed in the NoDL description of a system.
These common XMLs could either be added to this repository, or somehow imported through the resource index. After that point, it's a matter of xinclude/xpointer mechanism for each node added.

The set of common/default permission tags have been generated, by (for now) pulling in the policies/common directory into this repository and going from there. Two issues persist:

Are lifecycle nodes a talking point at all?
What about the "default" topics/services that an action requires? It seems like said topics/services are also NOT in NoDL's scope, but that might not be a problem.


[WIP] chore(deps): bump k8s deps

Fixes #N/A
Description
Includes dep bumps from dependabot #886 as well as the necessary code changes.
How was this change tested?
make test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 79.952%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
7661

Relevant Lines:
9582

💛  - Coveralls


Fix final variable definition that is used in a for loop being moved outside the for loop

Fixes a compile error in RealmsSelectWorldTemplateScreen where a variable is used in a lambda but the definition is being moved outside a for loop causing the variable to no longer be effectively final.

Codecov Report
Patch coverage: 91.30% and project coverage change: +0.01% :tada:

Comparison is base (99b9298) 76.87% compared to head (f0811b8) 76.89%.
Report is 4 commits behind head on develop/1.10.0.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                 Coverage Diff                  @@
##             develop/1.10.0     #311      +/-   ##
====================================================
+ Coverage             76.87%   76.89%   +0.01%
- Complexity             8367     8380      +13
====================================================
  Files                   251      251
  Lines                 26986    27013      +27
  Branches               6804     6812       +8
====================================================
+ Hits                  20746    20771      +25
- Misses                 4164     4165       +1
- Partials               2076     2077       +1

Files Changed
Coverage Δ

...ava/decompiler/modules/decompiler/MergeHelper.java
79.04% <91.30%> (+0.46%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


'No space left on device' for some alpine-linux and x86-64_linux static docker nodes

test-docker-alpine317-x64-2 (which has a label hw.dockerhost.dockerhost-equinix-ubuntu2204-x64-1) and test-docker-ubuntu2204-x64-2 (which has a label hw.dockerhost.dockerhost-equinix-ubuntu2204-x64-1) have many test jobs that are failing with 'No space left on device'
To make it easy for the infrastructure team to repeat and diagnose, please
answer the following questions:

test suite/name (e.g, BUILD_LIST, TARGET, CUSTOM_TARGET)?
a link into recent Test_ job on https://ci.adoptium.net which showed the failure

https://ci.adoptium.net/job/Test_openjdk17_hs_sanity.functional_x86-64_linux/263/
https://ci.adoptium.net/job/Test_openjdk17_hs_extended.openjdk_x86-64_alpine-linux_testList_2/61/
https://ci.adoptium.net/job/Test_openjdk20_hs_sanity.system_x86-64_linux/83/

Hyperlink to re-run in Grinder:
Is there an existing issue elsewhere covering this?
Which machine(s) does it work on?
Which machine(s) does it fail on? test-docker-alpine317-x64-2 and test-docker-ubuntu2204-x64-2

ON the second one is was the docker build cache that was chewing just under 700Gb so I've just issued docker builder prune on their to reclaim the space.

infrastructure bot has been fixed by @steelhead31 so is now producing alerts again. Closing


Verify and improve RTL configuration

I have installed RTL but, in my opinion, some configurations are wrong or can be improved.
For example, I haven't tested my components with dynamic imports. Create a component and verify if my configuration is working.

I tested locally and tests have passed.


Replace Redux Saga with Redux observable

This is a proof of concept to facilitate discussion around replacing Redux Saga with Redux Observable. The author of this fully accepts this pull request to be closed without merging because I didn't create an issue first. It had been discussed in issue #1139. However it was a wet weekend where I live and I had an code itch that needed scratching so I spent a day doing this. Also, I intend on using Redux Observable in my own projects, and I'd like to share this.
Reactive programming seems like a generally useful approach to development just as Promises have become a standard part of development. So much so that there is a drive to propose Observables for ECMAScript.
I personally find the code in Redux-Observable easier to reason about compared to Redux-Saga. I find the approach of imagining epics as streams of dispatched actions over time a useful one and then applying transformations such a map and filter just fit with functional composition.
This proof of concept also uses Marble tests. I found that this notation works very well for writing clear, understandable tests.
I attempted to add asynchronous loading but I have been unable to fully get this working. Redux-Observable also offers hot module replacement but at this stage it has not been implemented.

Hi  @mxstbr  @davidwilde
any idea when this can be tested and available to use

@muthukumarse Have you had a chance to pull this locally? It would be great to hear your feedback on it and could help push this through. I had some problems with the travis build process around tempting. At some point I will look at this again.

Hello everybodies! Has there been any development on this? I'm interested in react-boilerplate, but i'd like to use it with rxjs. Have you guys ran into any major issues when switching things up?

Hey @bradabelgit I have successfully replaced redux-saga for redux-observable on our rather larger scale project and it is working great.

Sagas: replace, modify, keep, etc., has a lot of discussion and many alternatives. Barring someone really digging in and summarizing the various options, I don't see the community moving on this issue.
Perhaps a better approach would be to document the process of replacing redux-sagas with the async/observable package of choice.

@davidwilde thank you so much for this truly awesome work... unfortunately, rx is just not on RBP roadmap at this point. if you are interested in maintaining a fork, please feel free to open a PR against documentation with a link and tag me in it :)
as @gihrig said, we would LOVE a PR to documentation with info on migrating 🙏 @petyrek


parse_requirements: Add include_invalid argument

Rather than fail on the first invalid requirement,
allow caller to require parser continues and
includes invalid requirements in the results.

Hiya @di, could you give your opinion on this.  We have a new GSoC about to start, and still no traction on the bugs in pytest-reqs. My patches keep getting broken when you urgently fix incompatibilities created by new pip, and then you do a release, and then nothing else happens.  If this keeps happening, I'll create my own plugin so I can get stability for the coala development team's test rig.
If you would prefer a different approach for this patch, I am happy to re-arrange this.   e.g. it could still raise an exception, but the exception could include the partial parse information as attributes.
If you dont believe this is useful at all in pip-api, I could add vcs URL parsing to pip-api, which would be enough to finish https://github.com/di/pytest-reqs/pull/26 , but still leaves it unable to report multiple parse failures.


404 at /registry/spec/api/

I found a broken link : https://docs.docker.com/registry/spec/api/
I arrived on this page through: https://www.google.com/

Closing since I figured out there are a bunch of similar issues.


init

Description

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

What is the purpose of this PR? Why do we need it?


fix dumpEcdsFilterConfigs when not have any ecds configs

Commit Message: Fixes https://github.com/envoyproxy/envoy/issues/32796
Additional Description:   fix dumpEcdsFilterConfigs when never received  any resources
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@yanjunxiang-google IIRC you worked on this previously. Can you please take a first look.
/assign @yanjunxiang-google

/retest

/lgtm

Can you please also address the comment from above:

may have missed it, but will it be possible to add another test that validates what happens when no ECDS config is received (I only saw this change impacting tests where the config is removed).
Please also add a release note.

@adisuissa   I think that the existing TTL integration tests have already included tests for when it is unconfigured or not have any configs

/retest

@adisuissa @zuercher @yanjunxiang-google
Just resolved a merge conflict，PTAL again, thanks!

Already approved by a senior-maintainer, merging.


No dependencies in package.json

The generator installs a lot of node dependencies when setting up a new project but none of them are added to package.json. This leaves the developer needing to manually set these up.

I just ran into this myself. If you clone a project created with the generator, and then try to run grunt (even after an npm install) I get the following:
>> Local Npm module "grunt-contrib-clean" not found. Is it installed?
>> Local Npm module "grunt-contrib-watch" not found. Is it installed?
>> Local Npm module "grunt-contrib-jshint" not found. Is it installed?
>> Local Npm module "grunt-jscs" not found. Is it installed?
>> Local Npm module "grunt-mocha-istanbul" not found. Is it installed?
>> Cannot rename missing "mocha_istanbul" task.
Warning: Task "clean" not found. Use --force to continue.