Check that computed chunks have right size and dtype

This was inspired by a question in #7234. At present assert_eq checks
that the computed array has the right size and dtype, but it's still
possible that the individual chunks have the wrong size (as long as they
add up to the right total size) and maybe the wrong dtype (as long as
they coerce to produce the right dtype - although I haven't actually
checked that this would slip through).
Now persist is used to access the individual computed chunks and
checked for shape and dtype.
This is a draft because there are a couple of failures. One is in
test_zarr_return_stored[False] (which I'll need to investigate
further, but possibly persist just doesn't make sense for this case)
and the other is in test_blockwise_concatenate which looks like it
might just be a test bug.

[ ] Tests added / passed
[x] Passes black dask / flake8 dask

It might also be worth making _check_chunks a public function (named assert_something to make it clear that it's for testing) so that it can be used independently of assert_eq.

Oops, had meant it to be a draft PR. Changed now.

I've mostly fixed up the tests, but the mindeps testing is showing up a real bug: tril and triu use zeros_like_safe, and on older versions of numpy those functions don't match the dtype, so one ends up with chunks of the wrong dtype.
I'm happy to fix those functions, but I don't know their history so I'm not sure what the semantics are supposed to be.

I've mostly fixed up the tests, but the mindeps testing is showing up a real bug: tril and triu use zeros_like_safe, and on older versions of numpy those functions don't match the dtype, so one ends up with chunks of the wrong dtype.
I'm happy to fix the _like_safe functions, but I don't know their history so I'm not sure what the semantics are supposed to be.

There is a PR that refactors tril and triu to follow the numpy implementation more closely: https://github.com/dask/dask/pull/6997
I haven't checked if it actually solves your issue though, but it doesn't use zeros_like_safe at least.

There is a PR that refactors tril and triu to follow the numpy implementation more closely: #6997

Interesting, but assuming it fixes the test failure it's just hiding the actual bug (in zeros_like_safe) which may well affect other code.

I think I've finally gotten the tests passing again (just waiting for MacOS CI), so ready for review. The history has being a bit of a mess so let me know if you'd like a rebase (I think it should be 3 commits: one to fix a test, one to fix #7287 and one for the headline change).

Thanks for doing this. I think the history is fine, we'll squash-merge anyways.

Ok, as long as the commit message gets cleaned up. The default of just concatenating all the individual commits into a message for the squashed commit would look awful.

Is this good to merge then?

Is this good to merge then?

The code is ready from my point of view. If you like I can rebase to get a cleaner commit message when you squash-merge.


[BUG] <Integration pmazz/ps_hassio_entities> Repository structure for v1.1.0 is not compliant

Cannot add this repository to HACS.  Error message in title.
Latest HACS and HASS.

I can confirm it is not working (anymore)

Hmm, this seems to be working for me with HACS 2.0 and Home Assistant 2024.9.   The version on this repo is still 1.1.0, so not sure what changed.


Resource access control - undo probably not working

The following observation was made during pre-deployment testing for 1.9.6:
User A (resource owner) granted view permission to user B and edit permission to user C. Then C granted edit permission to B. Now when C tries to change permission for B back to view, system does not allow that and says 'Non-owners can't decrease privilege of others'. If C tries to delete existing edit permission (click on X) of B, system says 'You don't have permission to remove this sharing setting'. I was expecting it to go back to original view permission granted by user A.

@pkdash Undo is a different function than unshare. Undo is invariant of user privilege. One can invoke it even if one loses the privilege first.

@alvacouch Is that means unshare should call undo internally from the UI perspective?

@pkdash There is actually no reasonable way to do that.

undo_share reinstates the previous privilege you might not have granted. E.g., if you gave CHANGE, and someone else gave VIEW, undoing restores VIEW.

unshare permanently unshares, in the sense that it does not reinstate any previous privilege granted by another. In the same situation, unshare would remove all privilege including VIEW.

So, one has to call undo_share separately if that is what one wants to do.
Or, one can write a function undo_or_unshare to do that.

@ pkdash The problem with combining the functions concerns only owners.

Non-owners cannot unshare.
Owners can unshare, which means removing all privilege.
Non-owners can undo.

So, my simple question is: should an owner be able to undo?

If so, undo and unshare are different UI buttons.
If not, undo and unshare can be the same UI button.

@alvacouch Would it work then if we use the same button (x) but do different actions depending upon if the user is owner (remove all privileges) or non-owner (undo)?

@pkdash It will work but that is exceptionally poor UI design.  An owner should still have the option of a simple undo. It really needs two buttons that appear when can_unshare_* and can_undo_share_* are true.

@pkdash If you must use one button, I recommend a button that makes "undo" the priority operation, so that:

if undo_share_* is true, then it is labelled undo share and undoes the share when pressed (without necessarily wholly unsharing the resource if privileges were assigned by others).
else if unshare_* is true (only for owners), then it is labelled unshare and unshares the resource when pressed.

Thus, an owner who assigned a new privilege can unshare by pressing the button at most twice.
IMHO this is a decent UI design.

(remember that undo is limited to a single action, and that further undos are prohibited after the first one by the backend, even though the information is there.)

@mauriel133 Can you work on the above UI changes (as suggested by Alva) in access control panel? Any backend changes you need, I can do.

Yes, I'll work oj it.

@mauriel133 @pkdash The functions UserAccess.can_unshare_*_with_* and UserAccess.can_undo_share_*_with_* tell whether a user can unshare and/or undo.
So, to emulate the behavior above, you would write
if user.uaccess.can_undo_share_resource_with_user(resource, u2):
    user.uaccess.undo_share_resource_with_user(resource, u2)
elif user.uaccess.can_unshare_resource_with_user(resource,u2):
    user.uaccess.unshare_resource_with_user(resource, u2)

This undoes a share if possible, and otherwise unshares it if possible.

@pkdash please tell @Lizabrazil what has changed on the UI for this issue.  She needs to change help documentation and screen shots to reflect changes in functionality.  I cannot actually see any front end changes, but perhaps they are subtle, which is why we need your help to point out what is different.

OK


Database migration does not correctly add offhand item slot to character table

The offhand item slot is not correctly added to the character table when applying the 0.1.1 migration. A new migration should be added that correctly applies this change.

Closed in v0.1.2

Still not working in 0.1.2


Create our own default stringency instead of relying on GATK's

The default stringency in ReadConstants from GATK is SILENT and it is ok for our purposes, but they can change it in any moment and I prefer to change it before we go further into the released GATK4. It is also different from the default in the SamReaderFactory, so we should change it there too (either on startup or on construction of our wrapper factory).

I still need to think if this is the proper way to go. Now that we have a ReadWalker, we should keep it in the same way as GATK. This will be much better once we move to version 2.0.0 - kept open until then to evaluate if it is really necessary.


Added streetlighting.

Absolutely support it, its an awesome idea ;).

Absolutely support it, its an awesome idea ;).

I really like the idea of ultra-local decision making for this kind of thing. It also sounds like a great way of making the most of an investment which has already been made in the infrastructure.
@afdy Please could you read the Contributor License Agreement and leave a comment if you agree to it. Thanks!

I really like the idea of ultra-local decision making for this kind of thing. It also sounds like a great way of making the most of an investment which has already been made in the infrastructure.
@afdy Please could you read the Contributor License Agreement and leave a comment if you agree to it. Thanks!

This is a really tricky one. As you say modern streetlights don't cost a lot to run, and subsequently don't generate a lot of pollution aside from, perhaps, some light pollution. We have one in our front window which doesn't bother us and does provide a fantastic water show when raining at night. So perhaps turn them off, but... it's not just a "local" thing, it's also a "people who use your street" thing and has a safety aspect. I suspect a lot of women would prefer that streets were lit after dark. So, on balance, I think no, I'd prefer them left on for that reason alone.
Vote: ❎

This is a really tricky one. As you say modern streetlights don't cost a lot to run, and subsequently don't generate a lot of pollution aside from, perhaps, some light pollution. We have one in our front window which doesn't bother us and does provide a fantastic water show when raining at night. So perhaps turn them off, but... it's not just a "local" thing, it's also a "people who use your street" thing and has a safety aspect. I suspect a lot of women would prefer that streets were lit after dark. So, on balance, I think no, I'd prefer them left on for that reason alone.
Vote: ❎

So, on balance, I think no, I'd prefer them left on for that reason alone.

Vote: ❎

This underscores exactly the problem though.  You have decided to vote to leave them "on for everybody" due to your own personal preferences, and voted against this option to allow local control.  This perpetuates the never ending discussion of "should they be on or off".
If you were to allow local control, individuals could make the best decision for their area as a community as you don't know how other people feel.
Consider a piece of road with no housing that doesn't need lighting - that could be off by default.
Consider some star gazers that don't like lighting - they should have that option.
Consider a well populated area with high crime, they may like lighting - they should have that option.
If, like you have done - one person tries to make the decision for the whole area without considering other individual perspectives and opinions, 50% of people will be upset with whatever the outcome.  If you let the community around the lamp post decide, you end up with lighting tuned to be perfect for whoever lives there!
I still strongly believe its the ideal option.  Can you suggest an alternative approach other than "all on" or "all off", or could you perhaps reconsider?
By changing to vote positively for this change - you could still choose to keep your lamp on, but you would avoid forcing your decisions onto people who want their lamp off...

So, on balance, I think no, I'd prefer them left on for that reason alone.

Vote: ❎

This underscores exactly the problem though.  You have decided to vote to leave them "on for everybody" due to your own personal preferences, and voted against this option to allow local control.  This perpetuates the never ending discussion of "should they be on or off".
If you were to allow local control, individuals could make the best decision for their area as a community as you don't know how other people feel.
Consider a piece of road with no housing that doesn't need lighting - that could be off by default.
Consider some star gazers that don't like lighting - they should have that option.
Consider a well populated area with high crime, they may like lighting - they should have that option.
If, like you have done - one person tries to make the decision for the whole area without considering other individual perspectives and opinions, 50% of people will be upset with whatever the outcome.  If you let the community around the lamp post decide, you end up with lighting tuned to be perfect for whoever lives there!
I still strongly believe its the ideal option.  Can you suggest an alternative approach other than "all on" or "all off", or could you perhaps reconsider?
By changing to vote positively for this change - you could still choose to keep your lamp on, but you would avoid forcing your decisions onto people who want their lamp off...

@pavsmith that's a really good point, although the starting point for this idea is that the streets aren't lit for the whole night in Hampshire.
Perhaps the process for deciding whether lights should be turned on could take account of everyone who uses a street, not just the residents? A FixMyStreet for lights? The other thing I've been wondering about is the idea of residents paying. I could easily imagine that affluent areas end up with all their street lights on, while other areas stay in the dark.
I still really like the idea of local neighbourhoods having the power to decide on which streets are lit after dark though. What do you think about updating the proposal a bit @afdy?

@pavsmith that's a really good point, although the starting point for this idea is that the streets aren't lit for the whole night in Hampshire.
Perhaps the process for deciding whether lights should be turned on could take account of everyone who uses a street, not just the residents? A FixMyStreet for lights? The other thing I've been wondering about is the idea of residents paying. I could easily imagine that affluent areas end up with all their street lights on, while other areas stay in the dark.
I still really like the idea of local neighbourhoods having the power to decide on which streets are lit after dark though. What do you think about updating the proposal a bit @afdy?

For me it simply comes back to personal safety. Plus it can't only be about the locals making the decision, especially where the street is used as a thoroughfare by people on foot. Indeed I flip exactly the opposite way on streetlights in areas with no housing, as they're the least safe areas after dark, and I think therefore it is an area that needs to be lit. A final thought for the moment is the condition of footpaths in many places which are bad enough trip hazards in the daytime, let alone if you were trying to walk on them in the dark!

For me it simply comes back to personal safety. Plus it can't only be about the locals making the decision, especially where the street is used as a thoroughfare by people on foot. Indeed I flip exactly the opposite way on streetlights in areas with no housing, as they're the least safe areas after dark, and I think therefore it is an area that needs to be lit. A final thought for the moment is the condition of footpaths in many places which are bad enough trip hazards in the daytime, let alone if you were trying to walk on them in the dark!

Just discovered that there's an interactive map of street lights which shows which ones are currently on a "Part Night Lighting" schedule.

Just discovered that there's an interactive map of street lights which shows which ones are currently on a "Part Night Lighting" schedule.

Interestingly I was once again enjoying last evening's rain falling through the streetlight outside our window and then, i think about 2230, it turned itself off!

Interestingly I was once again enjoying last evening's rain falling through the streetlight outside our window and then, i think about 2230, it turned itself off!

Ok made amendments to address funding and security concerns by @pavsmith

I have read the CLA Document and I hereby sign the CLA

I like the idea of more local control and I think it's worth getting this policy in, on the basis that it is over and above the street lighting provided by the county, which already includes a mixture of lighting schedules.
Vote: ✅


[Question] Is this extension working ?

Hello,
I was wandering if you are still working on this extension and if you could create a documentation on the installation process.
Thanks

Interface "Box\InjectionAwareInterface" not found (9998)

not working i think


Error: Resource is no longer available.

I get the above error when using this library.
Did they change the API endpoint? Any way to update the endpoint?

These guys change the API on a regular basis..... this has to be at least the 5th iteration I am changing.
As far as I can tell, they did not change the base URI which is still https://data.nasdaq.com/api/v3
Notice that this gem does not have any endpoint hardcoded, except the base URI. The entire API class is 44 lines long.
They did however seem to have replaced the "/datasets" URI I am using in all the examples and tests.
This means that there is no change needed in the code, but just in the way you call them.
This, for example, works for me:
$ nasdaq pretty datatables/MER/F1

(took the first example from their documentation)
I will dig deeper into it, and update the examples accordingly.

Wow - these Nasdaq / Quandl guys must really hate developers.... their documentation is one of the worst I have ever seen, and the documentation that does exist link to non working endpoints.
On top of that - there is almost no useful free data over there, and most premium data sources do not have sample data.
Excluding the outdated WIKI prices publisher (nasdaq pretty /datatables/WIKI/PRICES ticker:NVDA), I was unable to get anything else (e.g. /databtables/EOD/MSFT which is supposed to work according to the docs).
I am seriously considering shutting down this gem.

Ok well that's good news that it sort of works. I am glad I am not the only one that got confused by their documentation. I kept clicking links and just going round in circles without finding anything useful. I couldn't even figure out where the endpoint was.
I'm actually just looking for LBMA/GOLD and LBMA/SILVER EOD prices, which I was using prior to these changes, but doing datatables/LBMA/GOLD gets nothing. Perhaps it's switched to premium or some other source.

clicking links and just going round in circles

Same here. I have spent a couple of hours trying to find a decent endpoint reference - there is none as far as I could find.
Furthermore, its not only that they changed "datasets" to "datatable" - they also changed how the internal databases work.
"datasets/WIKI/AAPL" is now "datatables/WIKI/PRICES?ticker=AAPL"
I have a developer license to the EOD data, which is supposed to be "datatables/EOD/AAPL" - as their own documentation state, but its not working.
If you are not attached to Quandl / Nasdaq Data Link - then I would consider an alternative.
I have developed a couple of  similar gem, using the Intrinio data service and another data service::

https://github.com/DannyBen/intrinio
https://github.com/DannyBen/eod

Perhaps one of them still has less of a "consumer-level developers are not wanted here" vibe?

Thanks for those. EODHD seems to have a free plan and I found the data I was looking for in less than 10 minutes. What an amazing difference. Only thing they didn't have was Platinum prices, but I will email them, perhaps they could add it. Looks really straight forward otherwise.

Excellent. If you are going to use any of these other gems and encounter issues, feel free to report and I will do my best to assist.


Watch Mode?

Should the CLI include a -watch option? It could be useful during development. It could be similar to watch in TypeScript.

It could do, yeah. watch modes can get surprisingly complicated — the built-in fs.watch is unreliable on some platforms so you sometimes have to use something like chokidar, which can also be a bit of a pain, and you have to handle all kinds of weird cases like files being renamed, files being created in a watched directory, etc.
So we haven't bothered with that yet because for the most part it's best left to things like webpack and Rollup (with rollup-watch) — they've already solved these problems, and have extra features (like CSS extraction) that are maybe a little harder to do via a CLI.
But it would be a good addition in the longer term. PRs always welcome! 😀

Yeh I'm using rollup-watch (with rollup-plugin-svelte of course). Single responsibility principle?


0.7.0 README references (forthcoming!) 0.8.0 functionality.

Hi! I hope this format is ok for a new issue, I didn't see any explicit guidelines in the README.
Currently, the README for 0.7.0 references ..._v2 functionality concerning artifact loads, but does not contain the code (which is in the 0.8.0 prerelease branches.)
This is somewhat confusing for people currently integrating the package into their projects and should probably not already be present in the current 0.7.0 release documentation.
Thank you for all the hard work on this, very neatly solves observability issues with dbt/dbt-Cloud!!!

Hey @devin-hc - thanks for raising this. We should have created a 0.8.0 branch to keep these docs off of the front page, sorry for the confusion. 0.8.0 is now released though, so I think we're back in sync.


Design - Grid component

Summary: Design of the Grid component.
Design on component branch and push to main Figma file when approved.
Acceptance Criteria:

[ ] Component Kickoff
[ ] Sync with Dev and Design
[ ] Research and consulting other design libraries
[ ] WCAG Goal can be completed using a screen reader.
[ ] WCAG Visual elements observe color contrast requirements.
[ ] WCAG Manual accessibility testing meets WCAG 2.1 AA requirements.
[ ] Provides equal service in French and English.
[ ] Sync with Dev and Design
[ ] Comparison with official policy, documented reasons for deviation if any
[ ] Design review
[ ] Policy review
[ ] Design - Different screen sizes
[ ] Design - Short content / long content (text overflow etc.)
[ ] Design - Error state (if applicable)
[ ] Design - Empty state (if applicable)
[ ] Component anatomy
[ ] Write draft of design guidance
[ ] Handoff from draft dev guidance to documentation author/lead
[ ] Update Figma version

Ensure grids are more detailed that what's on the website to show specific pixel amounts like DECD DS does - Add grids to Figma and specify screen widths to be used for desktop and mobile

@RavinaSamaroo is this done already or is still needed?
See the comment above, it seems this was created because we wanted to show specific pixel numbers and specify screen widths.


Allow changing the location of the lima cache

Description
Currently you can easily change the location of the lima files, using $LIMA_HOME...
It would be nice if it is was just as simple to change the cache location, $LIMA_CACHE.
Both default to using $HOME directories by default, which might not always be suitable.
Should also document the default location on Linux, which is under $XDG_CACHE_HOME.

I might prefer to say $LIMA_HOME/_cache should replace the default OS cache location (only if it already exists), and then the user can create a symlink to a directory anywhere else if they want to.
This would have the advantage that you only need to specify LIMA_HOME and not multiple environment variables. Because if you ever run in a shell that doesn't set LIMA_CACHE you would accidentally use the default location again.
I have no strong preferences, but just wanted to mention this for consideration.

That would require a custom wrapper or setup script to create it, and not just setting environment variables.

How so? All it requires is to run this once:
ln -s /Volumes/ThunderBlade/Lima ~/.lima/_cache

Before starting to use Lima, that was.

Before starting to use Lima, that was.

You could do it any time afterwards too:
mv ~/Library/Caches/lima /Volumes/ThunderBlade/Lima
ln -s /Volumes/ThunderBlade/Lima ~/.lima/_cache

As I wrote before, I don't have strong preferences either way, but I generally prefer to not have lots of environment settings for one application. At some point it becomes preferable to have a config file. I just don't think we are quite there yet.

But it does open up for sharing the Lima cache (between users), even if that is a separate topic...

I'm not sure this is a good idea, especially for "fallback" images, which could be unexpectedly quite outdated.
Adding files to the cache may have race conditions, and pruning becomes unpredictable because it cannot know which images are still being used by other users.
But if you are willing to ignore this, then creating a symlink to the shared cache will work just as well to.
The difference really boils down to:

environment variable: has to be set every time you invoke limactl start
symlink: is set up once and is linked to LIMA_HOME[^1], so switching the home switches the cache as well

[^1]: you can of course link multiple LIMA_HOME locations to the same cache, with the same caveats as sharing a cache between users.

I might prefer to say $LIMA_HOME/_cache should replace the default OS cache location (only if it already exists), and then the user can create a symlink to a directory anywhere else if they want to.
This would have the advantage that you only need to specify LIMA_HOME and not multiple environment variables. Because if you ever run in a shell that doesn't set LIMA_CACHE you would accidentally use the default location again.
I have no strong preferences, but just wanted to mention this for consideration.

SGTM

Adding files to the cache may have race conditions, and pruning becomes unpredictable because it cannot know which images are still being used by other users.

Usually this is solved by making the cache read-only for the users, as far as I know the images are copied before taken in use so the cache images can always be removed ?

I think moving the cache directory into the home directory is a different change, and not the one I wanted to do...
It would be possible to symlink also the current location, even if it requires access to the regular cache location first.

environment variable: has to be set every time you invoke limactl start

actually it is only set up for each environment, normally sourced by shell

actually it is only set up once for each environment, normally sourced by shell configuration

I guess we must be thinking of different user-cases; you seem to expect only a single installation of Lima per environment, and you want to globally adjust the location of the cache.
My starting point (and why I originally introduced LIMA_HOME) comes from the desire to have multiple installations of Lima in the same environment, and they should be completely separate from each other.
Originally this was for Rancher Desktop, but now also for finch, and potentially in the future also for colima, when it starts bundling a specific version of Lima (I don't know if the plan is to use a separate LIMA_HOME as well).
So with this setup you can install potentially incompatible versions of Rancher Desktop and Lima in any order, update, and uninstall them, and they will be completely ignorant of each other.
Now Rancher Desktop does not make use of the Lima cache (it bundles the ISO, and nerdctl), so I haven't thought about the shared cache situation.
But I can see now that if a "Lima-embedding application" uses the cache, it may not want to be affected when the user has a separate Lima installation and runs limactl purge. Which means having a separate cache location could be useful.
So with this use-case in mind, LIMA_HOME and the cache location are linked; you wouldn't change one without the other, so having the change happen automatically would be simpler and prevent user errors. Which is why I suggested $LIMA_HOME/_cache as an option, to allow an app to isolate.
If you are only concerned about a single LIMA_HOME per environment, then I think a symlink in the default cache location already provides the flexibility you need. Just like you don't really need to set LIMA_HOME, you could just create a symlink from ~/.lima.

You are right, I wasn't thinking of the forks. And the symlink workaround could take care of the hardcoded cache dir.


Better HTTP Response

Currently response are not all json. For example if we register using same information twice following is the raw data instead of helpful json message like Wrong username or password.
BadRequest: Key<EMAIL_ADDRESS>already exists.

Correct, I will work on it ...
Bad week-end, I have flu :(

Resolved in #19

great


Windows Universal Project

Project for Windows Universal apps

hi, Just have a few quesions
Have you tested that the Win 8 project still works on Windows 8? I've not come across the DLLs you are referencing before e.g. api-ms-win-core-handle-l1-1-0.dll
Are these safe to use in Win 8/8.1? Is this the recommended way to access these APIs now, or is this some undocumented way to get at them?

Both my PCs are Windows 10. I have a Windows 8.1 one but did not manage to test on it. Will try it this weekend.
However, according to the official documentation for Windows 8, these DLLs are the ones to be used. Check the Windows 8 API Sets in MSDN: https://msdn.microsoft.com/en-us/library/windows/desktop/dn505783(v=vs.85).aspx


selection_sort.cpp: Add cpp implementation for selection sort.

This commit adds the Cpp implementation of selection sort for NITSkmOS/Algorithms.
closes https://github.com/NITSkmOS/Algorithms/issues/482

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #482
By submitting this pull request I confirm I've read and complied with the
below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the commit guidelines for this project.
[x] My code follows the standard code structure.
[x] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[x] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

Hey @yashasingh,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: d94ab390-dbc2-11e8-8e0f-4de0fcdedaae

Hey @yashasingh,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 14344410-dbc5-11e8-8e0f-4de0fcdedaae

Hey @yashasingh,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: cdff9700-dbc5-11e8-8e0f-4de0fcdedaae

Hey @yashasingh,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 53429480-dbc6-11e8-8e0f-4de0fcdedaae

@sangamcse Please review my PR!

@sangamcse Please review!

@sangamcse I have updated the commit message but regarding the redundant issue in README.md, the line was already poor indented. Updating the same reflects it as a bigger change.
you may refer README.md line 28 to notice the indentation.

@sangamcse Required changes have been made. Please review :slightly_smiling_face:

Also, rebase your branch

@sangamcse Branch rebased. Please review. :slightly_smiling_face:

ack a5277bd952a1ab1d76540f9d75cea7d08ca2f00e

@sangamcse ff

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

Automated fastforward with GitMate.io was successful! :tada:


ci: generate_gapic_bom.sh to include Cloud and existing entries

Fixes https://github.com/googleapis/google-cloud-java/issues/9837
The gapic bom mainly includes cloud libraries and ones that have been included already.
Let's avoid adding com.google.maps and com.google.shopping for now. We may decide to
add them later. It's more difficult to remove them later without impacting users.

"generation diff / gapic-bom" succeeded https://github.com/googleapis/google-cloud-java/actions/runs/6236607445/job/16928325841?pr=9849

Re-running the failed checks.

Trying to create a pull request without a fork.


Special characters in the password (still)

Character # in password still does not work

Fixed with 1.0.1


Mounted Fallen Knights are frequently bucked off their horses.

Some time after spawning on a zombie horse the knights are dismounted, leaving the pair to wander away from each other.
ERZ 1.3.6

I have a fix for this and also https://github.com/PrinceOfAmber/ERZ/issues/18 , but i had to disable the feature where they could use bows. ill have to revisit it later (maybe) if i can find a way to add it without breaking everything else

https://minecraft.curseforge.com/projects/emberroot-zoo/files/2546169


Waiting for loading animation to complete.

Im implementing a page load state which consists of a overlay that slides over the content and then slides out to reveal the new content. Hoverver swup is not waiting for this animation to complete, so it's effectively not showing at all (Im working on a local environment so load times are almost instantaneous).
Even though the new page might be loaded before the loading animation shows or is complete, I still what the entire loading animation to play through.
This is my  current loader css:
.c-load-screen {
    width: 100vw;
    height: 100vh;
    position: absolute;
    top: 0;
    left: 0;
    z-index: 2;
    background-color: $orange;
    transform: translateX(-100%);
    transition: all 0.5s ease;
}

.is-changing .c-load-screen{
    transform: translateX(0);
}

Is there any way I can acheive this?

FYI - use is-animating for the animating state instead, otherwise the content wouldn't animate back in (or in your case overlay wouldn't slide out of viewport) in case swup did wait for the animation finish.
html.is-animating .c-load-screen{
    transform: translateX(0);
}

But back to your problem. If swup doesn't wait for the animation to finish, it means it selects wrong/no elements that it should wait for.
Can you show your HTML for the overlay and swup settings?

Thanks @gmrchk The loader element was outside of the  element. It improved when I added the '.load-screen' selector to swup's elements to watch, however it's only playing the out animation, the sliding in to viewport animation is not.
my css is now:
.c-load-screen {
    width: 100vw;
    height: 100vh;
    position: absolute;
    top: 0;
    left: 0;
    z-index: 2;
    background-color: $orange;
    transform: translateX(-100%);
    transition: all 0.5s ease;
}

html.is-animating .c-load-screen {
    transform: translateX(0);
}

and my HTML:

Features

and JS:
const swup = new Swup({
    cache: false,
    debugMode: true,
    elements: ['#swup', '.c-load-screen']
})

swup has options elements and animationSelector. elements serves for defining the blocks of HTML that need to be replaced.  animationSelector serves to define what elements should swup wait for to finish animating. This is separated because replaced elements are not always the ones that are animating - your example is a perfect use case of this.
This should make it work for you.
const swup = new Swup({
    cache: false,
    debugMode: true,
    elements: ['#swup'],
    animationSelector: '.c-load-screen',
})

Thanks @gmrchk  for the clarification and the quick responses. That did the trick


Support "unknown" model type

For unsupported model types we can add a "mock" model_type.
This way we'll enable users to use different mlem commands that dont need to load actual model like clone.
RN, the process is python model obj -> getting model type with analyzer (methods, requirements, io)-> producing artifacts from ModelIO -> saving metadata
For unknown models, users can do analyzers work manually like this
python model object -> user saves model manually -> generates empty metadata from files like ModelMeta.from_files(...) -> optionally fills metadata manually (adding requirements and stuff) -> saves metadata

@mike0sv, is this still an issue? This related to that discord question we had recently.

It's more of a feature proposal than an issue. Don't think it's relevant to that question either, it's basically about an API to manually create MlemModel objects more easily. Rn you can also do this of course, but in very unfriendly way

I'd say it's p2 or even p3 btw


autocompletion not working

should suggest "current_member" defined in Access::RestrictedForTool

fixed by https://github.com/luizpvas/holistic-ruby/commit/aef1672d27486e6edf7674b3e2766e4993362e76


Check Fish version, exit if too low

Just now I updated my Fisherman (finally!) but started getting some strange errors. I realized it was because I was still on an old version of Fish, the 2.1 branch. After updating to 2.2.0, everything was fine.
Since Fisherman pretty much crashed and burned on the old version, maybe it's worth having a brief check? Something like this:
function __fisher_check_fish_version
    set -l fish_version (fish --version 2>&1 | grep -oE "[0-9]+.[0-9]+.[0-9]+")
    # test: set -l fish_version 2.1.3
    set -l fish_major (echo $fish_version | cut -f1 -d.)
    set -l fish_minor (echo $fish_version | cut -f2 -d.)
    if [ $fish_major -lt 2 -o $fish_minor -lt 2 ]
        echo "Current Fish version is $fish_version."
        echo "A minimum version of 2.2.0 is required to run Fisherman."
        exit 1
    end
end

__fisher_check_fish_version

This is the first time I've actually written a Fish script, so it's probably a mess. So I didn't send it in as PR, but I'll do that if you think this is a valid addition 😄

I think we could perform this check outside the fisher function itself in the file. This way the code would run only "once", when the fisher.fish file is sourced by fish, that is, the first time the function is called, but only the first time.

https://github.com/fisherman/fisherman/commit/846758a8528c4c2d1dfdf26bfbd6568865281b26


digestAuth k8s usersFile documentation mismatch

Do you want to request a feature or report a bug?
Documentation improvement
In digestAuth documentation, Kubernetes section does not contain any useful example explaining how to put credentials into a file. The given example is same as users(using base64 encoding)

will this be added anytime soon?

👍 Thanks for the report, this would be a nice improvement!
Unfortunately we lack the resources to deal with this so anyone willing to contribute by adding more complete examples is more than welcomed, including for generating the base64 passwords from CLI or other tools maybe?
In case anyone is interested but unsure how to proceed we have a contributing guide


Korean IME does not work as expected

Environment
Windows build number: Windows 10 2004 19041.21
Windows Terminal version (if applicable): 0.8.10091.0

Any other software?

Steps to reproduce

Run Windows PowerShell tab
Typing text $x = '한글'

Expected behavior

The resulted text should be $x = '한글'

Actual behavior

But the resulted text was $x = '한그ㄱ글'

https://github.com/microsoft/vscode/issues/89853 Possibly similar issue happening in VS Code

@zadjii-msft Is there any progress on this issue? It seems like quite a lot of people encountered this problem.

@rkttu Nope, when there is progress, someone will make sure to chime in on this thread. It's been triaged as a P1 bug for 1.0, so we won't be shipping 1.0 without a fix for this, so stay tuned. If anyone is particularly passionate about this bug, we'd be happy to review a PR. Until someone's been assigned to this bug, you can be sure you won't be stepping on our toes ☺

Possible workaround (not tested): try removing Droid Sans Fallback from the fonts list of the app if it's there.
https://github.com/microsoft/vscode/issues/89853#issuecomment-581495374

Note that this problem did not occur in version 0.7.3451.0.

Possible workaround (not tested): try removing Droid Sans Fallback from the fonts list of the app if it's there.
microsoft/vscode#89853 (comment)

@hatsunearu Unfortunately https://github.com/microsoft/vscode/issues/89853 is caused by wrong glyph rendering and that workaround dosn't work here.

@guswns0528 discovered that this bug is first caused by https://github.com/microsoft/terminal/commit/dfa7b4a1. https://github.com/microsoft/terminal/commit/dfa7b4a1 itself is right commit so we can't simply revert it.
Looks like this issue is caused by strange behavior of Core text APIs. Originally, the Composition complete event should only be fired when the letter composition is completed. Like this:

If you are typing ㅎ ㅏ ㄴ ㄱ ㅡ ㄹ, composition event should be fired twice.
한, and 글

But in here it's fired before that. Like this:

If you are typing ㅎ ㅏ ㄴ ㄱ ㅡ ㄹ, composition event should be fired twice.
한, 그, and 글`

It might be a bug of Core text APIs but core text API is just a wrapper of Text Services Framework, which is super stable framework inheritted from Windows XP era. So I need to investigate further.
I'm currently debugging this issue and I'll comment on here if I find something. Please feel free to share any information if you find something. Thanks

@simnalamburt thanks! Note that @leonMSFT is currently working in this area and has a couple pull requests out for this; perhaps you two can coordinate?

Cool! Currently I am suspecting wrong parameter of NotifyTextChanged function as the cause of the bug. But in fact, since I first saw the Core text API today, I still don't know what's wrong. Any help or information is always welcomed!

@simnalamburt thanks a lot for the investigation! I tried to see if I can repro the two vs three composition completed events issue, but I only see two composition completed events. Maybe you could provide a screenshot of the debugging logs you used to find this? Here's a screen of my debug logs:

I was also taking a look at this bug earlier, and perhaps my findings could explain why you're seeing the bug you're seeing. Here's the behavior I'm observing and why I think we're messing up Korean IME input:
So, going through your example keysequence, pressing ㅎㅏㄴ, would result in three TextUpdated events being received, with the _inputBuffer and the _textBlock having the character 한.
Now the user presses ㄱ, and what will happen is the following:

TextUpdated is received with the character 한.
CompositionCompleted is received, signaling that 한 is the finished composition.
As part of our CompositionCompletedHandler, we send the contents of _inputBuffer (which is 한) to the terminal and reset the _inputBuffer and _textBlock. Then we also notify the text server that they should also make their "buffer" empty as well. (This is the NotifyTextChanged call that you mentioned).

What should happen now is that we should receive a TextUpdated event with the text as 한ㄱ.
However, we're actually not getting any TextUpdated events after our CompositionCompletedHandler is finished because we're telling the text server to reset their text buffer. Since their buffer is empty, it won't tell us that we should update our text to be anything.
This is why you'll run into the weird issue where you'll be pressing ㅎㅏㄴ, which works fine, and you'll see 한 on the screen, but once you make another input, like ㄱ, nothing happens. The ㄱ keypress triggers the CompositionCompleted event for the previous character 한, which tells the text server to clear their buffer. So, you will need to press ㄱ again to make ㄱ show up on the screen.
So, the core of the problem is that we need to send the IME input to the terminal when we believe composition is finished, and we naturally also need to clear our buffer whenever we send some input to the terminal. We also need to keep the text server's buffer and our _inputBuffer in sync, so whenever we clear our buffer, we tell the text server to clear theirs as well.
As a small test, I've tried commenting out the code where we're telling the text server to reset their text buffer, and lo and behold, text comes out as you would expect, without having to double-press any characters. The only problem here is that if we don't reset our text buffer, every CompositionCompleted event will cause us to send the whole _inputBuffer (which included literally everything you've ever typed while in IME mode) to the terminal, resulting in lots of duplicate input.
I'm currently trying to think of a way around this, but I'm giving you a summary of my findings so maybe you can also repro and investigate further to see if I've missed something! 😄

@leonMSFT Wow thanks for your detailed explanation! Now I understand what was going on in my development environment.
Currently I’m trying to leave some unfinished characters in text buffer instead of totally clearing it in ConpositionCompletedHandler.
Please share any information or updates and let me help anything I can! Actually there are lots of people waiting for this issue to be resolved since there are not much options that Korean developer can choose in Windows. Any share will be helpful and the whole Korean developer community will be grateful to you! 😄

@simnalamburt Yup, not clearing the whole text buffer, but leaving unfinished characters in is key! Luckily, I think I'm close to getting the fix for this out! 🎉I'm specifically testing out trying to type out this sequence: 안녕하세요, which was provided earlier in this thread.

It seems to work as expected, but before I have a PR out for this fix, I'll need to make sure I haven't messed up any other IME input modes, so hang tight! 😃
One thing I would like your help on is letting me know of other sample character sequences that might possibly break the way I'm handling Korean IME! I don't know Korean at all, so having the sequence laid out in english characters like it was above with "dkssudgktpdy" (which comes out as 안녕하세요) really helped!

Wow it was very fast! I lost my chance to become hero lol
Actually there are not many corner cases in Korean IME. And your sample
video (안녕하세요) showed that it perfectly handles one of very famous corner
cases in Korean IME called “도깨비불 현상”.
If 안녕하세요 works perfectly I expect the other cases to work fine, but I’ll
share you few more samples just in case.
gksrnrdj whgdk (한국어 좋아)
To test whether aborting composition with space works fine
gksrnrdjEnterwhgdk (한국어\n좋아)
To test whether aborting composition with enter works fine
Actually there are bunch of things to test further like

Test if alternative Korean IME like 세벌식 works fine
Test if swiching IME in the middle of composition works fine (it’s very
common for Korean people)
etc

But these cases might be complicated to ask you to test so just share your
patch or make the draft PR. I have bunch of Korean and Japanese friend
developers interested in this issue and they will battle test it for you!
2020년 2월 29일 (토) 09:27, Leon Liang<EMAIL_ADDRESS>작성:

@simnalamburt https://github.com/simnalamburt Yup, not clearing the
whole text buffer, but leaving unfinished characters in is key! Luckily, I
think I'm close to getting the fix for this out! 🎉I'm specifically
testing out trying to type out this sequence: 안녕하세요, which was provided
earlier in this thread.
[image: koreanoutput]
https://user-images.githubusercontent.com/57155886/75596418-67dcfa80-5a45-11ea-9530-064e1cb53ba0.gif
It seems to work as expected, but before I have a PR out for this fix,
I'll need to make sure I haven't messed up any other IME input modes, so
hang tight! 😃
One thing I would like your help on is letting me know of other sample
character sequences that might possibly break the way I'm handling Korean
IME! I don't know Korean at all, so having the sequence laid out in english
characters like it was above with "dkssudgktpdy" (which comes out as 안녕하세요)
really helped!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/4226?email_source=notifications&email_token=ABB235NX3G3S45MIL6SLM73RFGTXFA5CNFSM4KG4TDJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKUHNQ#issuecomment-592790454,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABB235PXTI7IBLLIC474K33RFGTXFANCNFSM4KG4TDJA
.

I tried to reproduce the scenario that you described, but I'm having trouble. I typed ㅎㅏㄴㄱ and I got 2 textUpdate event instead of 0 after typing "한".
# Typed ㅎ
_compositionStartedHandler() called.
_textUpdatingHandler() called.
Text:  ㅎ
Range: [0, 0]

# Typed ㅏ
_textUpdatingHandler() called.
Text:  하
Range: [0, 1]

# Typed ㄴ
_textUpdatingHandler() called.
Text:  한
Range: [0, 1]

# Typed ㄱ
_compositionCompletedHandler() called.
_SendAndClearText() called.
inputBuffer was L"한" and cleared.
_compositionStartedHandler() called.
_textUpdatingHandler() called.
Text:  ㄱ
Range: [0, 0]
_textUpdatingHandler() called.
Text:  ㄱ
Range: [0, 0]
_compositionCompletedHandler() called.
_SendAndClearText() called.
inputBuffer was L"ㄱㄱ" and cleared.

Is there anything that I misunderstood, or did something changed with https://github.com/microsoft/terminal/commit/31c9d19a72ef5fce19ab480c0a5e407064e15941#diff-7708ccd4133d008adca4935827f7ddb7?
https://github.com/simnalamburt/terminal/commit/acf74bc8ad947 this is a patch that I used for tracing.

That's really weird! I pulled your branch from your fork (and the branch called patch-4226) and tried to do the same thing you were doing and this is what I'm getting:

After pressing ㄱ, as you can see, _textUpdatingHandler,  _compositionCompletedHandler and _SendAndClearText are called in sequence, and another _compositionCompletedHandler is called afterwards. I'm not seeing the two extra _textUpdatingHandler calls that you're seeing though. 😢

That's strange. My issue (2 text update event) is being reproduced consistently on two computers, mine and PC of @guswns0528. I wonder what the difference is.
My Windows specifications:

Windows Terminal version: https://github.com/simnalamburt/terminal/commit/acf74bc8ad947
Windows Edition: Windows 10 Pro
Windows Version: 1909
Windows OS build: 18363.657
Processor type: 64-bit operating system, x64-based processor
Windows display language: English (United States)
Default app language, Default input language: 한국어

From the details you've provided, I don't really see a difference 😢. However! I finally have a PR out, so feel free to take a look and play around with it!

Me and @guswns0528 tried https://github.com/microsoft/terminal/pull/4796 and it worked perfectly! Still don't know why the 2 TextUpdate events were fired but looks like your patch fixed it anyway. 👍


filed building wheel for lxml

I run this command sudo pip install --upgrade droneapi always appear lxml faild and wait long time install.
shoud I use pip install lxml?
The directory '/home/farsight/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Requirement already up-to-date: droneapi in /usr/local/lib/python2.7/dist-packages
Requirement already up-to-date: pymavlink>=1.1.50 in /usr/local/lib/python2.7/dist-packages (from droneapi)
Requirement already up-to-date: MAVProxy>=1.4.13 in /usr/local/lib/python2.7/dist-packages (from droneapi)
Requirement already up-to-date: protobuf>=2.5.0 in /usr/local/lib/python2.7/dist-packages (from droneapi)
Requirement already up-to-date: requests==2.5.1 in /usr/local/lib/python2.7/dist-packages (from droneapi)
Requirement already up-to-date: future in /usr/local/lib/python2.7/dist-packages (from pymavlink>=1.1.50->droneapi)
Collecting lxml (from pymavlink>=1.1.50->droneapi)
Using cached lxml-4.1.1.tar.gz
Collecting pyserial>=3.0 (from MAVProxy>=1.4.13->droneapi)
Using cached pyserial-3.4-py2.py3-none-any.whl
Requirement already up-to-date: six>=1.9 in /usr/local/lib/python2.7/dist-packages (from protobuf>=2.5.0->droneapi)
Requirement already up-to-date: setuptools in /usr/local/lib/python2.7/dist-packages (from protobuf>=2.5.0->droneapi)
Installing collected packages: lxml, pyserial
Running setup.py install for lxml ... \
error
Complete output from command /usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-1jQTmj/lxml/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-Z535dk-record/install-record.txt --single-version-externally-managed --compile:
Building lxml version 4.1.1.
Building without Cython.
Using build configuration of libxslt 1.1.28
running install
running build
running build_py
creating build
creating build/lib.linux-armv7l-2.7
creating build/lib.linux-armv7l-2.7/lxml
copying src/lxml/sax.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/pyclasslookup.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/_elementpath.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/ElementInclude.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/doctestcompare.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/init.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/usedoctest.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/cssselect.py -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/builder.py -> build/lib.linux-armv7l-2.7/lxml
creating build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/init.py -> build/lib.linux-armv7l-2.7/lxml/includes
creating build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/formfill.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/html5parser.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/clean.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/diff.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/ElementSoup.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/_diffcommand.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/_html5builder.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/soupparser.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/init.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/usedoctest.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/_setmixin.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/builder.py -> build/lib.linux-armv7l-2.7/lxml/html
copying src/lxml/html/defs.py -> build/lib.linux-armv7l-2.7/lxml/html
creating build/lib.linux-armv7l-2.7/lxml/isoschematron
copying src/lxml/isoschematron/init.py -> build/lib.linux-armv7l-2.7/lxml/isoschematron
copying src/lxml/etree.h -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/etree_api.h -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/lxml.etree.h -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/lxml.etree_api.h -> build/lib.linux-armv7l-2.7/lxml
copying src/lxml/includes/schematron.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xpath.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/uri.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xslt.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/init.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/c14n.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/relaxng.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xinclude.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/dtdvalid.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xmlerror.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/config.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/tree.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xmlschema.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/etreepublic.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/xmlparser.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/htmlparser.pxd -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/lxml-version.h -> build/lib.linux-armv7l-2.7/lxml/includes
copying src/lxml/includes/etree_defs.h -> build/lib.linux-armv7l-2.7/lxml/includes
creating build/lib.linux-armv7l-2.7/lxml/isoschematron/resources
creating build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/rng
copying src/lxml/isoschematron/resources/rng/iso-schematron.rng -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/rng
creating build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl
copying src/lxml/isoschematron/resources/xsl/XSD2Schtrn.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl
copying src/lxml/isoschematron/resources/xsl/RNG2Schtrn.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl
creating build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_dsdl_include.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_svrl_for_xslt1.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_skeleton_for_xslt1.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_schematron_message.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/iso_abstract_expand.xsl -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
copying src/lxml/isoschematron/resources/xsl/iso-schematron-xslt1/readme.txt -> build/lib.linux-armv7l-2.7/lxml/isoschematron/resources/xsl/iso-schematron-xslt1
running build_ext
building 'lxml.etree' extension
creating build/temp.linux-armv7l-2.7
creating build/temp.linux-armv7l-2.7/src
creating build/temp.linux-armv7l-2.7/src/lxml
arm-linux-gnueabihf-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DCYTHON_CLINE_IN_TRACEBACK=1 -I/usr/include/libxml2 -Isrc -Isrc/lxml/includes -I/usr/include/python2.7 -c src/lxml/etree.c -o build/temp.linux-armv7l-2.7/src/lxml/etree.o -w
arm-linux-gnueabihf-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-armv7l-2.7/src/lxml/etree.o -lxslt -lexslt -lxml2 -lrt -lz -lm -o build/lib.linux-armv7l-2.7/lxml/etree.so
/usr/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
error: command 'arm-linux-gnueabihf-gcc' failed with exit status 1
----------------------------------------

Command "/usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-1jQTmj/lxml/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-Z535dk-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-1jQTmj/lxml/

Which hardware platform and operating system are you using?
lxml is a big package and takes a lot of time to build from sources. Try to install it from the binary repositories of your distribution, not from pip.
On Debian, it's as simple as: sudo apt-get install python-lxml.
Since you're building on ARM, you may find the piwheels project useful, since it has ARM builds of lxml and other packages. That would allow you to install lxml with pip.
If you want or need to build lxml from sources, this StackOverflow answer should help you solve the linking problem.

Also, the correct command to install DroneKit is:
pip install dronekit

(not droneapi).


How about publishing it to npmjs.com

Dev,
Can you please publish this plugin to npmjs.com and cordova.apache.org/plugins so that we can use it in phonegap build.
Thank you for your effort.

I'm on it.

https://www.npmjs.com/package/call-number
npm install call-number


What about SockerCluster on UE4 4.23?

Hello,
First, thanks for this awesome project.
Do you plan to support the new version of UnrealEngine 4.23?
What about Linux support?

Hi,
You are welcome, we are glad you find the project useful.
Yes, 4.23 version will be released today.

Update.
Support for 4.23 is released, and currently under review for marketplace release.


docs: Add missing required delete_repo permission

Merged! Thank you for your contribution. Much appreciated! 👍


Show only the icon

Hi, i want to only show the icon, so i use this:
animation: true
language: es
name: Clima
type: 'custom:ha-card-weather-conditions'
weather:
  current:
    current_conditions: sensor.cc_weather_condition

But then it shows like this:

Can this be fixed?
Thank you!
Pd: amazing card bro!

Thanks, bro. The newly released version implements your request.
Renato

Amazing! Thank you!


Corrections to CSE administration articles

This pull request contains minor corrections to articles found in the CSE administration section:
https://help.sumologic.com/docs/cse/administration/

Thanks for the review, @kimsauce!


Update c++ for(i=0;i<=n-2;i++)

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

I didn’t find anything new in this PR as both are the same.
**INVALID PR*g

Hi @derbess,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


Using LSP (nvim-cmp) and tagalong.vim is breaking code

Hello together, I just catched a bug, which is driving me crazy sometimes.
When using the autocomplete of nvim-cmp, I am having a hard time to use the tagalong.vim package.
Is there any way to circumvent this one?
Edit: On the screen I am using "ESC" to exit the insert mode, which then replaces the Link with a div. Sometimes the full code is being unreadable

Looking at the gif, the big thing that I see is that you start on line 15 and then move to line 16. I think that nvim-cmp is also adding a missing import, which shifts the code around and tagalong ends up looking at the wrong tag, because the lines shift under it.
I'll see if I can figure out how to debug, but it might take a while -- I don't use neovim and I don't use LSP. My experience has generally been that they tend to be very aggressive in making changes to the buffer, which is both part of why I don't use this kind of thing, and why it might be hard to figure out the order of events and callbacks.

What works is, that I dismiss the cmp dialog, and then just use a code action to import the missing import. But then, nvm. Thanks for the effort though.

Well, I'd like to take a look and see if there's a way to at least avoid messing the buffer up. I'll see if I can find the time for it.

I've pushed a branch called use-marks-for-positioning, which should make sure that the tag changes are applied even if other lines are added. It's actually simpler in some ways, though it would mess up people's marks and I have to think about restoring.
For now, I'd like to understand how this affects the auto-import thing. I had a hard time replicating this, the best I could do was to stay in insert mode and go to the top of the buffer. Though there's one problem with that, I'd like to ignore it for now for testing purposes.
If you have the time and energy to help me out with testing, could you check this branch out and let me know if and how it works with nvim-cmp?

Just switched to nvim-ts-autotag, (only) until this is solved, since I really like the work you are doing.
Will try and report asap.

I'm seeing the same problem using https://github.com/neoclide/coc.nvim
I tried your branch https://github.com/AndrewRadev/tagalong.vim/tree/use-marks-for-positioning
It fixes the positioning problem, but for some reason it undoes the automatically-inserted import :/

It fixes the positioning problem, but for some reason it undoes the automatically-inserted import :/

Yup, that's the problem I mentioned :)

Though there's one problem with that, I'd like to ignore it for now for testing purposes.

I suppose that confirms that marks work, at least. The undoing is because there's a literal undo in the code, once you make the change, the plugin triggers an undo and applies both changes in both places. I remember I implemented it due to an issue, I don't remember what it was. I'll see if I can find the time this weekend to find it and shape up a more complete fix.

Turns out, marks won't help me avoid the issue, because marks seem to be maintained when lines are shifted, but the shifting columns when editing the opening tags are not kept.
I've created a new branch, update-closing-position which offsets the closing position of the end tag based on the difference of the original and current start tag position when exiting insert mode. It passes the tests and I think it should fix the issue fully, but I still need to reorganize the code a bit and think of other potential edge cases.
@fnune @iduuck Could you try that branch out and let me know if it seems to fix the problem?

Things worked fine with that branch for me!

I finally found some time to clean the code up a bit and I've merged this change to the main branch. With that, I'll close the issue, but let me know if this kind of thing happens again, or if the change causes some different problem.


VZ-6156: Changes for embedding customized dashboard

Forward port of https://github.com/verrazzano/rancher/pull/36.
Add CATTLE_DASHBOARD_TAR_URL variable to specify url of tar file containing dashboard assets

oracle/release/2.6.7 branch has been created recently and build from source changes done as part of https://github.com/verrazzano/rancher/pull/49. Please change the target branch to oracle/release/2.6.7 branch and make  changes as necessary.

oracle/release/2.6.7 branch has been created recently and build from source changes will be done as part of #49. Please change the target branch to oracle/release/2.6.7 branch and make changes as necessary.

Created separate PR https://github.com/verrazzano/rancher/pull/50 for 2.6.7 branch


Implement CORS middleware

In Sources/KituraCORS/CORS.swift:

Line 79: Shouldn't that include alowed = true
Line 89: Shouldn't that be != 0

This function shouldn't be called with .all, so this case is unreachable.
I think we need exactly one match here, we are trying to match a URL with a regex.


HBASE-25339 Method parameter and member variable are duplicated in ch…

…eckSplittable() of SplitTableRegionProcedure
We input a this.bestSplitRow as splitRow of checkSplittable()
private void checkSplittable(final MasterProcedureEnv env,
    final RegionInfo regionToSplit, final byte[] splitRow)

But this private method could use 'bestSplitRow' directly

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m  6s
branch-2.3 passed

+1 :green_heart:
spotbugs
1m 58s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 10s
the patch passed

+1 :green_heart:
checkstyle
1m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  4s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

38m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2724

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 834fbeecc0bc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / dc99fc5a09

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 35s
branch-2.3 passed

+1 :green_heart:
compile
1m 13s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
148m 35s
hbase-server in the patch passed.

177m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2724

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ce79812d60f0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / dc99fc5a09

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/testReport/

Max. process+thread count
3597 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 15s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 44s
branch-2.3 passed

+1 :green_heart:
compile
1m 11s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 29s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
6m 26s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
192m 41s
hbase-server in the patch passed.

221m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2724

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 80f30057cd56 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / dc99fc5a09

Default Java
AdoptOpenJDK-11.0.6+10

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/testReport/

Max. process+thread count
2879 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2724/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Apply operation, columnToIndex and fastCSV

apply: Applies a function to a row/column of DataFrame
columnToIndex: Converts a column of data to a level of row indexes
fastCSV: The old parser was subpar to put it lightly. I saw a post which I couldn't find taking a scenario of a csv 2,000,000 X 5. I wrote a script to generate a mock CSV with the same specification and from_csv couldn't do it. Then I reduced 2,000,000 to 200,000 and from_csv still couldn't parse it fast enough. It took almost 6 minutes to parse 100,000 rows. The time just increases exponentially with from_csv. Hence I researched a bit and got fastCSV working. The benchmarks can be found here

I will replace from_csv with fastCSV after I extend it's functionality to match that of from_csv. Should be finished by the end of the week.
cc/ @thewilsonator - Ready for review :space_invader:
If you find anything out of place, or anything that can be improved, please leave a review and I'll make the necessary changes at the earliest of my convenience :octocat:

It seems you could do with a utility function to compare predicates on the lines of two files, see the unit tests for fastCSV

Thanks for the review :octocat:
Will make the necessary changes soon


feat!: upgrade to CDK v2

Closes #37
This is actually blocked by #48, so we should address that separately first.
Of note:

CDK v2 doesn't bundle experimental APIs in, so they're separate @aws-cdk modules. This makes the peer dependencies quite awkward.
dimensions is no longer accessible in the Metric props, forcing us to use dimensionsMap, which is typed to only allow string values. I'm not entirely sure if forcibly putting non-string values works properly.
The @aws-cdk/aws-secretsmanager:parseOwnedSecretName feature flag is removed in CDK v2.
It's otherwise mostly just import changes

Relevant docs:

https://docs.aws.amazon.com/cdk/v2/guide/migrating-v2.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

there might still be some changes that are not covered, I think it might be the case of WAF.

You mean in terms of pre-existing code coverage?

I mean that these would need a migration to CDK v2, since they include import changes, right?

This has been rebased on top of the current HEAD, so I'll go ahead and allow this to be merged.


Parameter reference (%1) could not be found

Running Docker on Windows 10, I pulled the latest mssql-server-windows-developer image. Executed:
docker run -d -p 1433:1433 --env sa_password=Password1 --env ACCEPT_EULA=Y --isolation=hyperv microsoft/mssql-server-windows-developer
Resulted in the error:
"docker: Error response from daemon: container 05a9878069205b35f53e10f04e641733aeacfedb9ab05288b1b7621e4112fa8b encountered an error during CreateContainer: failure in a Windows system call: The description string for parameter reference (%1) could not be found."

the same here, but with all containers

@andrewNestorenko You're right, it's all containers on Windows. I've been in Linux mode for a while so didn't notice until I switched over. Found this, but still looks to be an open issue.

@ryankmcintyre , which version of docker and build of W10 is it on?

I'm on Windows 17025. Docker version is more interesting in that when I look at "About Docker" from the Windows app it shows 17.09.0-ce-win33, but when I run "docker --version" it shows 17.04.0-ce.

Thanks Ryan! My current is 17.11.0-ce-win40 (14328), but it makes no difference whatsoever on WIP.


Malicious q p crashing

I didn't think much of it until someone said in a CC, wanna see me get banned?
and typed a q p [impossible] and ended up freezing my client and computer has I kept getting notifications from RL about a q p.

I've had this issue mentioned before but I've been unable to replicate it (issue #2). I would appreciate if you could give as much information as possible about the bug.
Things like:

What are your setting for this plugin?
What are your RuneLite settings related to notifications?
Did this happen in an actual clan chat or a friends chat (the old CC)?
Has this happened before? If so is it regular?

The qp plugin settings are spaces and the only thing turned on are use overlay and inline hints

It happens in joining a cc, not sure which is which honestly.
And as for how regular, it varies. Because it's obviously very malicious the way they do it.

Thanks to your help I found the issue!
It's "Game message notifications" causing the problem as the notification message is A  q p opportunity! which itself contains a "q p".
I will fix the issue by changing the notification message to A qp opportunity!.


Unnamed objects support

Hi!
Your example
class JSONExample
{
public:
    std::string text;
...
}

Serializes into {"JSONExample":{"text":"Hello JSON World"}}. Is it possible to serialize them into just
{"text":"Hello JSON World"} ? Suppose I need to serialize a vector of JSONExample instances, so after serialization I'd like to have:
[{"text":"Hello JSON World 1"}, {"text":"Hello JSON World 2"}]

Hello vlkv.
The example below produces this:
	{ 		"vector_example": { 			"text": ["ve0", "ve1", "ve2"] 		} 	}
Which parts are you trying to eliminate?
This snippet is also valid JSON but has had the markup generated by the std::vector<> member removed.
{ "vector_example": ["ve0", "ve1", "ve2"] }
What is going to consume the JSON?
//-----------------------------------------------------------------------------
// test elementary vector example
class vector_example
{
public:
// content gets streamed to JSON
std::vectorstd::string text;
public:
void serialize(JSON::Adapter& adapter)
{
// this pattern is required
JSON::Class root(adapter, "vector_example");
// this is the last member variable we serialize so use the _T variant
JSON_T(adapter, text);
}
};
void test_vector()
{
vector_example source;
source.text.push_back("ve0");
source.text.push_back("ve1");
source.text.push_back("ve2");
std::string json = JSON::producer<vector_example>::convert(source);
vector_example sink = JSON::consumer<vector_example>::convert(json);
//
JSON::throw_if(0, source.text != sink.text, "test_template failed");

}

Hello!
In your example, I'd like to be able to have
{ "text": ["ve0", "ve1", "ve2"] } instead of
{ "vector_example": { "text": ["ve0", "ve1", "ve2"] } }
Look, It's not the same behaviour that we have in JavaScript (it's from Chrome console):
var vector_example = {text: ["ve0", "ve1", "ve2"]};
undefined
JSON.stringify(vector_example);
"{"text":["ve0","ve1","ve2"]}"

I really want to have a functionality in c++ that provides golang https://blog.golang.org/json-and-go

Hello @vlkv ,
Did you get any solutions of your problem as I am also getting the same issue, Please let me know if you have any solutions.
Thanks in advance.

@pmehul55 what is going to consume your JSON?

@g40
Thanks for your reply. I am getting this string after performing below step
std::string json = JSON::producer<Request_Model>::convert(request);
std::cout << json;
{
"": {
"UserName": "abc",
"Password": "abc",
"MobileInfo": {
"AppVersion": "2.0",
MobileOSVersion: "iOS"
},
"ID": 1
}
}
How can I get below string instead of extra  { "" this brackets
{
"UserName": "abc",
"Password": "abc",
"MobileInfo": {
"AppVersion": "2.0",
MobileOSVersion: "iOS"
},
"ID": 1
}
Thanks


Add/update DCO, CoC, contributing ... files

Description
Update non code files to be uniformish amongst all repos.
Why is this needed
Ensures our repos are all licensed correctly and contain similar/minimum
contribution info files.

@gianarb @thebsdbox any clue whats up with CI? Is it that my PR is from a fork?


Resume possible?

I have run a test with the gardenvase dataset, did train, evaluate and then rendered the 480 frames, to then end abruptly, as it expected ffmpeg to be installed, which was not in the requirements. RuntimeError: Program 'ffmpeg' is not found
Rather not go through the +-90 minutes to render the frames again, I wondered if I can resume in some way from that point. Any advice? I now have a render-folder with 1920 files (4.3 GB) of generated data, for acc_, color_, distance_mean_ and distance_median_.

Well, that is happen to me too. Rendering for +-60 minutes and forget to install ffmpeg

Thanks for flagging this, I've added ffmpeg as a requirement.
As for your first question, I don't see an easy solution besides just hacking the render script to skip a few indices.


Enhancement: Schedule calculate - don't DML update record if rollup value unchanged

I have a client who uses DLRS for an AccountTeamMember rollup to Account. It must run in Scheduled mode because a trigger is unavailable. They do have a number of baked-in processes including an external sync that get triggered by DML updates, even if the data is otherwise unchanged.
Every time the rollup runs, the "Last Modified" date on all 50,000+ Accounts is bumped, regardless of whether the rollup substantially changed anything. Apparently this causes a lot of difficulty for their automated sync. Would it be possible to add a setting which leaves the record alone without a DML update, if the calculated rollup is exactly the same as the current field value?

Yes that would be possible.

Thanks - this would be much appreciated! If it makes it into a release I'll be sure to let my client know of the good news.

I guess this might be a dupe of #370 now that I see it? Save for, I suppose, the idea of making it an option. Under some scenarios it does make sense to trigger workflows and such en masse, but in others not so much.

I just logged a request for this same thing before seeing this thread.  We would LOVE to see this change!

Fixed in v2.10

Awesome. Is this automatic in all modes or does it need to be enabled?

Thats really good news! Thanks for the feedback.

Is it still possible for the rollup summary to cause an update even if the value is unchanged? Use case: my non-profit customer is performing MAX aggregate to return the most recent Opportunity Close Date. Then Process Builder runs on edit to evaluate if the most recent Close Date is = This Month to check/uncheck a "Monthly Donor" checkbox. If the most recent Close Date = 10/1/2019 come 11/1/2019 when the Scheduled Calc runs, it's not updating the Parent record to fire the Process Builder to uncheck the "Monthly Donor" checkbox.

@ClarkBranson perhaps your use case can now be satisfied with the new Winter '20 Scheduled Flows feature. You can have it search nightly for records matching certain criteria and then run a Flow on them.


Upgrade Spatie/medialibrary to v8

The table name has changed. Student pictures have been disabled, see commit 727ba951649d1817fcced8c4472dd4f873ce0d13

This issue should be solved with composer update doctrine/inflector
https://github.com/vanilophp/framework/issues/72

Thanks @damienBAUDET, I didn't notice a new release of doctrine/inflector had been released already. I merged your PR #164

@all-contributors please add @damienBAUDET for maintenance


GUI: show syntax, click to expand or explore

show syntax, click to expand or explore

F1 help implemented in playground and vscode, closing


IMPORTANT: Add API Testing

At the moment, the API is not tested. This should be fixed by adding extensive unit tests. This is essential, and very important, to ensure the code works long term with no errors. So far, it has only been slightly tested manually, and so there is the potential for significant issues in the code. The pipeline should run unit tests which are in the the testing folder, if they are named following a pattern which pytest can detect

I would love to help with this issue and this project.
I have some questions about this issue:

All endpoints must have testing?
How many different tests each endpoint must have?

Great, thanks!
Yes, all the endpoints need to be tested, except /api/firebase-config in backend/routes/api/authentication.py - this API route is no longer used and will be removed in the future. In the main branch, goals.py isn't a web route - it just contains functions. In the dashboard-page branch, the functions in goals.py are turned into API routes, but that'll only be ready when the branch is merged into main. So all the API routes in the following files need to be tested:

backend/routes/api/authentication.py
backend/routes/api/card_management.py
statistics.py
These are the only files containing API routes.

In terms of the endpoint tests, one part would be checking that the API accepts or rejects the right sort of data. But the priority would be that the API does what is expected when you pass it valid or extreme data. For example, when you go to the api/create-account  route, is an account created? Can you pass it any data which makes it behave differently than expected? Also, a priority would be to see what happens in different situations - for example, what happens when you try to get information from a user who doesn't exist?
A guide to how the code works, and for testing the code, is at CONTRIBUTING.md. You'll need to cloning the repo, and testing the local installation. Then you can set it to save to local .json files rather than Firebase, which are easier to check if they have the right data. Then, the unit tests may be able to read these files. Also, you are free to change any classes to make it easier to test, so long as the code won't dramatically change - in particular, the database classes are relevant.
Feel free to ask me any questions about this, including about the CONTRIBUTING.md guide - hopefully its easy to follow
Also, make sure that you write the code so that if you clone the repository, and run pytest testing/, assuming requirements are installed, the tests will run. For example, if your tests rely on the code being setup so that it writes to a local file, the test should do this configuration first (in other words, changing the file that is used to determine whether the database is firebase or local). This is to replicate the process that the automatic pipeline that runs tests will make.

Thanks for assigning me to this issue!
As soon as i get home, i plan to start to work on it.

Can i use any testing framework like unittest, or should i use just assert for this?

You can use any testing framework you like, so long as you add the packet to requirements.txt
(The pipeline, which automatically runs the tests, installs the packages in requirements.txt before running pytest)

Hey, @jacob-macleod.
I'm wondering, how do you want these tests to be?
One method for each endpoint, with many assertions, like this:
    def test_create_account(self) -> None:
        """
        Tests the account creation endpoint.
        3 tests total.
        """
        valid_dummy = {
            "userID": "1",
            "displayName": "Dummy"
        }

        response = self.post_api(Routes.ROUTE_CREATE_ACCOUNT['url'], valid_dummy)
        response_json = response[0]
        self.assertTrue(expr=response_json['success'],
                        msg=f'Invalid return for "create_account" method. '
                            f'Should be True but was {response_json['success']}')

        error_dummy = {
            "userID": "",
            "displayName": ""
        }

        response = self.post_api(Routes.ROUTE_CREATE_ACCOUNT['url'], error_dummy)
        response_json = response[0]
        self.assertFalse(expr=response_json['success'],
                         msg='Invalid return for "create_account" method, should not create a nameless user.')

Or should I split each assertion on different methods?
    def test_create_valid_account(self) -> None:
        valid_dummy = {
            "userID": "1",
            "displayName": "Dummy"
        }

        response = self.post_api(Routes.ROUTE_CREATE_ACCOUNT['url'], valid_dummy)
        response_json = response[0]
        self.assertTrue(expr=response_json['success'],
                        msg=f'Invalid return for "create_account" method. '
                            f'Should be True but was {response_json['success']}')

    def test_create_invalid_account(self) -> None:
        error_dummy = {
            "userID": "",
            "displayName": ""
        }

        response = self.post_api(Routes.ROUTE_CREATE_ACCOUNT['url'], error_dummy)
        response_json = response[0]
        self.assertFalse(expr=response_json['success'],
                         msg='Invalid return for "create_account" method, should not create a nameless user.')

The second way is verbose and specific, the first one will stop on the first AssertionError on the method.

Yeah, the second one would probably make the most sense

Perfect, the backend-testing branch has already some unitary tests.
Here is the branch i'm currently working on, the file test_api.py has the most changes, and the unittests come just after test_check_request_json method.
test_api.py
If you want any specific test, just let me know. 👍

Looks good, thanks!
Just one point, the serve_credentials function doesn't need to be tested, because its not being used anymore and will be removed in the future. I see by the function for that, you have some comments relating to setting up a test firebase instance. Because the tests are run automatically in a pipeline, the instance would have to be integrated into the pipeline. There are two possible ways - either having a pipeline stage where test instance credentials are saved from github secrets, like the real credentials in the current pipeline, or by deploying some sort of testing deployment of the code connected to firebase, and testing that. Of course, that's outside the main scope of this issue, so you don't have to explore that - it would be a secondary thing, possibly needing a separate issue.

The comment you saw about a firebase instance was exactly about the serve_credentials function, i forgot that you said that it does not need to be tested.
Besides this function, do you think i'm gonna need a Firebase instace on my local development environment?
I commented that because there was no other function that had no local database connection.
I'm wondering if it's possible to test all the endpoints using just the local database config.

@jaymeklein is this issue completed now - am I free to close it?

Yes, i think you're free to close this issue.
Please let me know if there's something missing on the tests. 👍


Migration to controller-runtime 0.16

What does this PR do?
{SUBH}
Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?

periodical dependencies maintenance
also fixes https://issues.redhat.com/browse/SVPI-649

How to test this PR?

generic testing

Do you want to include them in this pr?

No, I'll make a separate one.


Add 'not dead' browser compatibility. fixes #14

Did anyone has chance to take a look at this issue?

Thanks for this, I hope it will be merged into the main repo soon because the package is currently unusable with IE11.

My PR could be related to this #23
apparently, v4.0.0 of normalize-url is needed, not v4.5.0
https://github.com/sindresorhus/normalize-url#install

Sorry for the late response. I need to turn on notifications for this repo again 😄
This fix is now available with version 2.0.1.

No problem :) Thanks for merging


Exclude external dependencies

I may be doing this completely wrong to start with. So how should I map a "library" that is relative to the host and exclude it when bundling? This is my config:
In config.js
  paths: {
    "alias*": "/some-path/*"
  },
  map: {
    "lib": "alias/some-lib"
  }

In bundle config
"excludes": ["lib"]
But I get the following error:
Error: Error on fetch for alias/some-lib.js at file:///some-path//some-lib.js
	ENOENT: no such file or directory, open 'd:\github\aurelia\skeleton-navigation\skeleton-es2016\some-path\some-lib.js'
    at Error (native)

Is this file 'd:\github\aurelia\skeleton-navigation\skeleton-es2016\some-path\some-lib.js' really exists in the file system?

No it doesn't. By external I wanted to say that the file does not exist in the project/file system.
Finally managed to do it. If someone stumbles upon this use case:
In config.js
paths: {
  lib: "/some-path/some-lib.js"
},
meta: {
  "/some-path/some-lib.js": {
    build: false
  }
}

@ahmedshuhel As I get it this config option is systemjs builder specific. I hope when/if the bundler stops using systemjs builder this scenario will be supported in some way.

@StrahilKazlachev Perhaps you would be interested in making a PR to our bundler docs with a note on this? They are in the framework repo, doc folder.
@ahmedshuhel Please make a note about this. Any future solutions definitely need to account for this use case.

@EisenbergEffect Will do, I'll try by the end of the week.

Some additional info. It tuns out that since systemjs builder 0.15.0 there is an option that automatically takes care of my use case. But for that to work one should not add the module in question to the excludes of the bundle config, as I was doing, because this causes the error from my first comment.


MySQL composite unique key index max size is exeeded by "unique_title" key of label table

Describe the bug
MySQL composite unique key index max size is exeeded by "unique_title" key of label table
To Reproduce

Use MySQL with InnoDB as data store
Run migrate

Expected behavior
Migration should run without alteration
Environment (please complete the following information):

Label Studio Version 1.7.0

Additional context
MySQL InnoDB's unique key max size is 3,072 bytes
If char set is utfmb4, 4 bytes/varchar * 767 chats + 4 bytes/int * 1 foreign key = 3,072 bytes
So max_lenght of title column of label table should be 767 if MySQL is supported.
../labels_manager/models.py
line 14: title = models.CharField(_('Title'), max_length=767, help_text=f'Label title')

Hello, LS doesn't support MySQL.

Oh, okay. I thought it did because it has docker-compose for MySQL. Thank you for checking out the issue.

Previously LS worked with mysql, but we never tested it. Maybe another mysql version work.


Introduce achievements/badges

StackOverflow.com has badges, video-games often have achievements, and I believe Code-Wars would benefit from adding badges & achievements as well. It should be tangent-to/separate-from the honor system (i.e., it is not based on honor-points).
Here are some ideas:

[Nice Solution] : A badge you can get by having a solution that earns 3+ Best-Practices votes
[Clever Devil] : (Similar to the above) but for Clever solutions
[Revisionist] : You get by editing/correcting other katas
[Burgeoning Author] : (one-time) You get for authoring your first kata
[Prolific Author] : (one-time) You get by authoring lots of kata
[Silver Solution] : Getting 10 Best-Practice votes
[Gold Solution] : Getting 20+ Best-Practice votes
[Poly-Glot] :  Getting above a 5-kyu in 3+ languages
etc... The Medal modifier (i.e., "Gold/Silver" could be extended to create ranks of badges, "Bronze/Silver/Gold/Platinum Whatever Badge".

It would be nice for a badge to be a link in the user's profile to the thing that earned the badge (i.e., the solution, comment, translation, etc.).
┆Issue is synchronized with this Clickup  by Unito

I would like to see these achievements listed above be added to Honor points to the Achievements section in the Stats section in the user profile. Clicking Achievements bar should see the list of achievements the user earned from requirements.