switch to true|false for protectionsState param

Task/Issue URL:  https://app.asana.com/0/0/1205915950517978/f
Description
Switching to true|false instead of 1|0 for cross-platform consistency. See the parent task https://app.asana.com/0/1201141132935289/1205644489547731
Steps to test this PR

[ ] Submit the breakage form with protections on
[ ] Verify that the breakage form pixel param protectionsState is the string true
[ ] Submit the breakage form with protections off
[ ] Verify that the breakage form pixel param protectionsState is the string false

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

CI is failing


Add some documentation to the resolver

I spent a few hours yesterday re-teaching myself the resolver and wanted to add some comments along the way!

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

cc @Eh2406 I'm sure you'll be interested in this! This'll surely conflict with https://github.com/rust-lang/cargo/pull/5187 so I'd like to hold off on merging this until that goes through

I have been reading the comments and they look great to me so far! I got up to This is used during backtracking to ensure we can skip over as much work as possible., but notest that I was no longer actually focusing well. I will take a break and come back to this. The part I read looks really good!

:umbrella: The latest upstream changes (presumably #5187) made this pull request unmergeable. Please resolve the merge conflicts.

To be clear I am +1 when you feel this is ready and it is mergeable. :-)
Then I think working together, we are in a good place to solve https://github.com/rust-lang/cargo/issues/4810#issuecomment-357553286; the last reproducible and in the wild exponentially slow resolution (that I have found).

Ok I've rebased and updated with the recent merge conflict, @Eh2406 mind giving it a once over to make sure it still makes sense?

@bors: r=Eh2406
Ok cool, thanks for double checking me!

:pushpin: Commit 5695119 has been approved by Eh2406

:hourglass: Testing commit 5695119e22a62a21062fa0ee4c5a8d24187dbf7f with merge 6ececacf83586369c86be162153c9e45d75f6920...

@bors: retry

:broken_heart: Test failed - status-travis

@bors: retry

@bors: retry

:hourglass: Testing commit 5695119e22a62a21062fa0ee4c5a8d24187dbf7f with merge a9b1369d861b297535e6b997bfaf887f1e6875be...

:sunny: Test successful - status-appveyor, status-travis
Approved by: Eh2406
Pushing a9b1369d861b297535e6b997bfaf887f1e6875be to master...


Parallels Desktop 19

Parallels Desktop 19 installs WinterspringLauncher fine, but the game fails to launch

See https://github.com/Arctium/WoW-Launcher/issues/24#issuecomment-1362885111

All the time in C:/

Hmm, interesting.
Can you start the game without the launcher?
Just by opening WowClassic.exe?

I can start the game without the launcher just by opening WowClassic.exe

Can you also start WowClassic_ForCustomServers.exe?
Because this would allow you to join the server while the launcher is in the state you screenshotted before.

I can't start WowClassic_ForCustomServers.exe, What should I do to get started?

I have the same problem within Parallels. Did you fix it meanwhile?


Postgres: execute_batch still significantly slower than copy command

As discovered as part of #44, the execute_batch facility in psycopg2 used for Postgres still leaves a lot of room for improvement. The native Postgres COPY command is about 55x faster to load the same amount of data locally as compared to batch inserts using execute_batch.
Using execute_batch – 1m51s:
$ wc -l 201701-citibike-tripdata.csv
<PHONE_NUMBER>01-citibike-tripdata.csv

$ ls -lh 201701-citibike-tripdata.csv
   117M Jun 13 12:35 201701-citibike-tripdata.csv

$ time csv2db load -f 201701-citibike-tripdata.csv -o postgres -u test -d test -t test

Loading file 201701-citibike-tripdata.csv
File loaded.

real	1m51.615s
user	0m17.277s
sys	0m1.015s

Using COPY – 2.7s:
test=> \timing
Timing is on.
test=> \copy test from '/tests/201701-citibike-tripdata.csv' DELIMITER ',' CSV HEADER;
COPY 726676
Time: 2755.240 ms (00:02.755)

Issue https://github.com/psycopg/psycopg2/issues/491#issuecomment-276551038 acknowledges that:

Adding functions into the extras module to implement the ideas discussed here and in the ML thread without changing the executemany() implementation.
@altaurog has reported the following speedups over transatlantic connection:

cur.executemany():<PHONE_NUMBER>19 sec
execute_batch(): 14.6529989243 sec
execute_values(): 12.4037430286 sec
pgcopy: 2.85529208183 sec

It seems like there is no easy wrapper function in psycopg to leverage the same performance mechanism that COPY provides for simple batch INSERT statements.
However, the driver does support cursor.copy_from() and cursor.copy_expert() functions that allows the client to tap into the COPY command instead. This concept could be used to load the data via memory-based StringIO or BytesIO classes to speed up the data load to numbers as shown above.
A question to be answered is how to deal with extra encoding/decoding of the values already read from the file.

After some more research, it looks like that psycopg2 will never offer an executemany() DBAPI method that will get anywhere close to the performance of the COPY command. There might be a chance that this will happen with psycopg3 but that's still in development and far from being clear whether it would even implement the DBAPI, see https://www.varrazzo.com/blog/2020/03/06/thinking-psycopg3/


updated message to text area

Updated the message input to text area to allow multiple line entry

Do not merge.
Change was incorporated into feature/rest-api


Please add brew(not cask) formula

I would like to install pwsh on our team's centos server where I have no root privilege. But pwsh only comes with brew/cask, which made it impossible for me to install with linux brew.

@TravisEz13 Is it possible?
@CavalloneChen You can download zip distributive and unpack it in your folder.

@CavalloneChen I'm happy for the community to build a formula.  It would not be a Microsoft supported thing as a formula builds the product and we would not have tested those binaries.

@CavalloneChen You can download zip distributive and unpack it in your folder.

Yeah, definitely. But my server's system isn't officilay supported and installing dependencies can be a pain.

I guess OpenSSL is single dependency you need and only for remoting.

We could build a formula if it was in our own repo.  Would that work?
I have a prototype in my personal repo: https://github.com/TravisEz13/Homebrew-PowerShell


Add networking related istiod metrics

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x ] Networking
[ ] Performance and Scalability
[ x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

I don't think this is the right approach. We should have a single metric with a label for type. I would also strongly prefer if we can make this generic in crdclient rather than special casing every different CRD

Ok, I see your idea: We should have a single metric with a label for type.


Is possible to make a login with user and pass, via code?

Is possible to make a login with user and pass, via code?
I need a example that allow to make login with a ticket or page that I own in a nodejs.

@augcampos I believe your question is not relative to this project but to CAS itself. In any case see https://jasig.github.io/cas/4.2.x/protocol/REST-Protocol.html.

Enable REST support (the link I gave).
Create your page with form asking username & password.
Use the REST API to authenticate.
In Node handle login.

I'm going to look into adding the REST protocol to this library once I fix the other problems with it.


Enhance log message in FirstFitPlanner

Description
When cluster reached capacity threshold log message is:
"capacity threshold defined at each cluster/ at global value for capacity Type : 0"
Admins hardly remember the Capacity Type and it can take a while to look at which is the resource for the respective ID.
This PR adds a log message pointing to the capacity name (e.g. Memory / CPU) as well as global settings parameter name and value to be looked at.
Additionally, this PR also proposes to change the log message from DEBUG to Warning, as it gives relevant information in case of exceptions, and might enforce production environments to have log level at debugging instead of info.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

@DaanHoogland I think so.
Unless ClusterCPUCapacityDisableThreshold.value() could be null. I might need to add a validation in such a case to not get a log message resulting in NPE.

hm, none of the travfis runs succeeded :(

@DaanHoogland I think so. Unless ClusterCPUCapacityDisableThreshold.value() could be null. I might need to add a validation in such a case to not get a log message resulting in NPE.

@GabrielBrascher as far as I know, we cannot update configurations with value type =Integer/Long/Float to null.

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1900

Hi @GabrielBrascher Is this PR good to go in 4.16.1?

@sureshanaparti I have just changed the base branch from main to 4.16.

@sureshanaparti I have just changed the base branch from main to 4.16.

thanks @GabrielBrascher

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1970

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1976

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1980

@blueorangutan test

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


[ColorPicker - Editor] Add "Select color" tool tip

📝 Provide a description of the new feature
At the moment we have a tooltip on hovering the centered color which says "edit color".
I think for a consistent ux it does make sense to have a tooltip on the color suggestions too. This can help new users to understand the feature.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@niels9001 / @martinchrzan thoughts?

Yeah we can add this.

@niels9001
Is this a larger item?

@niels9001
Is this a larger item?

The words "Select this alternative color" would without a doubt be absolutely clear.

This has been resolved in the 0.35 release. https://github.com/microsoft/PowerToys/releases/latest


Organized Code

This Commit is made to organize code,
I'll be adding storybook and testing code in upcoming commits,

Looking forward for this PR to get merged. Inorder to add story book and more features


Disable vim delete/copy buffer into Mac's clipboard

Vim bootstrap version(number in first line): latest
Operating system: macOS latest
Vim/Nvim version: Nvim
Languages: Any programming languages

Description
Every I delete (dd) or yank (yy) things in vim, it will overwrite my OS clipboard,

Sometimes, I just copy something out of vim,
And I wanna paste my things into vim,
But, first I will delete (dd / dw) things in vim,
Then! vim overwrite my clipboard with the things I just delete!

I really hate this.
How could I disable this behavior?
I found config:
"" Copy/Paste/Cut
if has('unnamedplus')
  set clipboard=unnamed,unnamedplus     # I comment out this and it works.
endif

noremap YY "+y<CR>                     # I wanna keep this
noremap <leader>p "+gP<CR>     # I wanna keep this
noremap XX "+x<CR>                    # I wanna keep this

if has('macunix')
  " pbcopy for OSX copy/paste
  vmap <C-x> :!pbcopy<CR>
  vmap <C-c> :w !pbcopy<CR><CR>
endif

Any other better solution?

refs #71

Just disable clipboard flags that your found
Both commented down this line:
" set clipboard=unnamed,unnamedplus # I comment out this and it works.

or set to none as your customization like:
set clipboard=

would works for you.
Is there any reason caused you don't do this way?
Reference
These docs copied from built-in manual:
						*clipboard-unnamed*
	unnamed		When included, Vim will use the clipboard register '*'
			for all yank, delete, change and put operations which
			would normally go to the unnamed register.  When a
			register is explicitly specified, it will always be
			used regardless of whether "unnamed" is in 'clipboard'
			or not.  The clipboard register can always be
			explicitly accessed using the "* notation.  Also see
			|clipboard|.

						*clipboard-unnamedplus*
	unnamedplus	A variant of the "unnamed" flag which uses the
			clipboard register '+' (|quoteplus|) instead of
			register '*' for all yank, delete, change and put
			operations which would normally go to the unnamed
			register.  When "unnamed" is also included to the
			option, yank and delete operations (but not put)
			will additionally copy the text into register
			'*'. See |clipboard|.

Btw, you can use
:set clipboard<CR>

or
:set clipboard?<CR>

to preview current flags of clipboard, and tell us what it shows.

@shirohana I don't wanna rewrite the vim-bootstrap's default config.
But I think I found the property way:
I overwrite clipboard in the vimrc.local which my custom config.


Strange behavior of curly braces in JavaScript Code Style

Opening curly brace for switch is shifted and curly brace after "do" in do...while is not on next line.

It's wrong settings page (it's for do {}  while). Anyway - brace option not handled, wip

pushed


Wait for app to be ready on all ports

Expected Behavior

by default, wait until there is a listener on port 8080
config for additional ports ( PORT_NAME=NUMBER, ex. PORT_grpc=8081), wait for app to listen on port.

After app listens on all ports, we can listen on the h2 tunnel port.
Actual Behavior
503 errors on startup, CloudRun believes we are ready when tunnel port starts listening.

Fixed.


Fire event if file already exist

I think we should add an event and fire it if a file already exist. The event should contain the tried file name or file path. The event listener could add a new file name to the event. In this case the uploader will try to use this new file name again.
With this feature we are able to use own code logic to decide what should be happen if a file already exist. This is also important to add support for custom namers which do not return 100% unique file names (because a lot of functions are random but not guaranteed unique).
An example: You could trigger your own file namer again.

Idea for default behaviour. Example: The file test.zip already exist.

Try test_1.zip or test1.zip or test.1.zip.
Try test_TIMESTAMP.zip. TIMESTAMP will be replaced by the current timestamp.


v0.0.6 manifest.json had unexpected number of entries: 2

Attempted to build this Paketo sample rack app with the command:
pack build rails-rack-app --buildpack gcr.io/paketo-buildpacks/nodejs --buildpack gcr.io/paketo-community/ruby

And got the output:
ERROR: failed to build: opening buildpack blob: extracting buildpack<EMAIL_ADDRESS>layer (diffID sha256:0c670b1d33c9f41a33ce38fabc8cd69def4379a04c64a09b12b31b0736f263c4): manifest.json had unexpected number of entries: 2

This seems related to this Ruby issue.

I'm unable to reproduce the issue. Used nodejs 0.0.6 and ruby 0.0.16 (latest).
pack build rackapp --buildpack gcr.io/paketo-buildpacks/nodejs:0.0.6 --buildpack gcr.io/paketo-community/ruby:0.0.16
The app built successfully and ran fine.
What versions did you use?

As far as pack can tell, it's using the latest tag of the buildpack:
pack build rails-rack-app --buildpack gcr.io/paketo-buildpacks/nodejs --buildpack gcr.io/paketo-community/ruby
base: Pulling from paketobuildpacks/builder
Digest: sha256:83c60fcd6def0a3b6f9a1cbf049345a54dd43b6603041d19d61c08c46edd7185
Status: Image is up to date for paketobuildpacks/builder:base
base-cnb: Pulling from paketobuildpacks/run
Digest: sha256:30cd86c9a265a39629421fea0172be15cd4aefb9f7f432e98a330583196f172e
Status: Image is up to date for paketobuildpacks/run:base-cnb
latest: Pulling from paketo-buildpacks/nodejs
Digest: sha256:314cd0a2ddd6e87d3c1a064627a64e0b63299761595efee06d707c98dab07101
Status: Image is up to date for gcr.io/paketo-buildpacks/nodejs:latest
latest: Pulling from paketo-community/ruby
Digest: sha256:8442aecf21e6f19fe35efd603a66ded6561bf96cb80a8add2007082915d79665
Status: Image is up to date for gcr.io/paketo-community/ruby:latest

However, when I pack build with the version tags specified, I get the following output:
pack build rails-rack-app --buildpack gcr.io/paketo-buildpacks/nodejs:0.0.6 --buildpack gcr.io/paketo-community/ruby:0.0.16
base: Pulling from paketobuildpacks/builder
Digest: sha256:83c60fcd6def0a3b6f9a1cbf049345a54dd43b6603041d19d61c08c46edd7185
Status: Image is up to date for paketobuildpacks/builder:base
base-cnb: Pulling from paketobuildpacks/run
Digest: sha256:30cd86c9a265a39629421fea0172be15cd4aefb9f7f432e98a330583196f172e
Status: Image is up to date for paketobuildpacks/run:base-cnb
0.0.6: Pulling from paketo-buildpacks/nodejs
Digest: sha256:314cd0a2ddd6e87d3c1a064627a64e0b63299761595efee06d707c98dab07101
Status: Downloaded newer image for gcr.io/paketo-buildpacks/nodejs:0.0.6
0.0.16: Pulling from paketo-community/ruby
Digest: sha256:8442aecf21e6f19fe35efd603a66ded6561bf96cb80a8add2007082915d79665
Status: Downloaded newer image for gcr.io/paketo-community/ruby:0.0.16
0.9.1: Pulling from buildpacksio/lifecycle
Digest: sha256:53bf0e18a734e0c4071aa39b950ed8841f82936e53fb2a0df56c6aa07f9c5023
Status: Image is up to date for buildpacksio/lifecycle:0.9.1

It seems that the latest tag for the nodejs buildpack isn't pointing at the same image as the 0.0.6 tag.

As of date, the latest tags are same as nodejs 0.0.6 and ruby 0.0.16. What version of pack are you using?
If you're using 0.13, can you try with 0.11 or 0.12?

I run into this occasionally with all Paketo Buildpacks (you can find several threads in slack around this). As the prior message suggests, I always reference buildpackages explicitly with their tag to avoid this issue. This might be something worth engaging with the CNB community on.
Slack thread: https://paketobuildpacks.slack.com/archives/C011S6EL49L/p1594148632196100

I believe this is being looked into at the lifecycle level: https://github.com/buildpacks/imgutil/issues/63. Maybe we can close this issue?


Support --deployment option

According to the docs (pod install --help):

Disallow any changes to the Podfile or the Podfile.lock during installation

This might be handy on CI to ensure all changes to Podfile.lock are committed. Currently, one has to use a separate script step to perform this check manually.

That's right, this option is very useful, without it, the code on the repository vs the build app can be different. This option ensures consistency halting the build if the file is out-of-sync.

Hi @nikolaykasyanov @goetzc,
Thank you for reaching out.
I have escalated this to the next level of support for consideration.

Still relevant.

Hello,
It's Mefi here from the Bitrise CoreSteps Team. Thanks for reaching out helping us and the mobile community to have a better experience with Bitrise steps. 💜
We started to have a broader review of all the open issues and PRs and we are continuously prioritizing these in our sprints.
We reviewed this issue and we found it to be a valid feature request. We are collecting new feature requests on our Discuss forum where you can upvote and discuss further details. As this one is on our current roadmap, I close the issue and we'll share an update once we released the new version of the step. Until then, feel free to create a feature request and share your thoughts on Discuss.
Happy building! 🚀


Add a "new tab" button to the right of tabs

Hello
I'd like to know if it's currently possible to add the button to add a new tab on the right of the tabs as on Chrome?
See more generally adding the possibility of adding one or more buttons with icons.
Thank you for this superb library

Now custom components are supported on the right side of the tab. https://codesandbox.io/embed/eager-galois-hq8uxb?fontsize=14&hidenavigation=1&theme=dark

Thank you very much for this update.
I'd also like to suggest that you add the possibility of making a tab non-deletable by the user, and hide the remove button of course.

The tab supports using the isCloseIconVisible property to control whether the close icon is displayed.


Support date parameter for measurement

Consider gaps between measurements for big range of dates so the list doesn't get too long

Also support without the gaps (through param, without_gaps=true or something) for data download

Date should be a filter, but we need a different parameter for aggregates: #17


Tests failed in test_user_schemas.py

5 tests failed under test_user_schemas.py

the user_base_data was missing nickname and first name it cause key error, fixed it by adding those fields in the fixture


Windrose Icon not clear when in small layout

It's not clear that one has to click the windrose icon after selecting an area on the map.

Maybe some kind of highlighting after the map area has been clicked?

not doing, ugly


[1.0.2] Global leak found in _marshalArgs

Hi,
I was doing mocha test with global leaking check, it raise an error in Polymer library, and I found the _marshalArgs have a leak:
https://github.com/Polymer/polymer/blob/6dd6aa9755e2911018a199990875974e4e61f410/src/lib/bind/effects.html#L113

Thanks.  Fixed in https://github.com/Polymer/polymer/commit/cd4acffab214fb407aec5c10092c8b3b62015bdb.


Support for Lambda Payload version 2.0

Is your feature request related to a problem? Please describe.
AWS recently announced GA for "HTTP API" for API Gateway, which supports a newer JSON format for Lambda Payload. It'll be nice if we can use aws-lambda-go with HTTP API/Lamda payload format 2.0.
Describe the solution you'd like
An optional flag to use version 2 vs version 1 formats.
Describe alternatives you've considered
N/A
Additional context
Relevant blog post: https://aws.amazon.com/blogs/compute/building-better-apis-http-apis-now-generally-available/

+1
I was also looking for the new payload support like requestContext.routeKey and other key pairs.

Implemented by #274


Test: Should allow adjusting font weight

Test for #381 (came in via PR #10515)

[x] Any OS dbaeumer

Complexity 1
Adds two new settings editor.fontWeight and terminal.integrated.fontWeight. If terminal.integrated.fontWeight is missing, editor.fontWeight will be picked up by the terminal.
Please check that you can change the editor's and the terminal's font weight.

@alexandrudima please let me know when adding to terminal.integrated, first I heard of it was a bug that was filed https://github.com/Microsoft/vscode/issues/11198

I'm actually not particularly for this in the terminal. This would override the ANSI bold values which communicate/highlight information.

@Tyriar It came in via PR #10515 (I wrote above in the description). I was surprised that it adds the terminal option as well, but then I noticed the terminal has all the other font-related settings from the editor and thought it was a good change. We can definitely remove the terminal.integrated.fontWeight and its influence in the integrated terminal.


chores: adding new projects, removed archived

Description
Fixes #67
Type of Change:
Quality Assurance Documentation
Added Projects
Bridge-In-Tech
STEM Diverse TV
Anitab Forms Web
Deleted Archived Projects
Mentorship Flutter
Volunteer Management System
Portal

Can this pull request be reviewed and approved for merging if it meets the necessary requirements?


Optimize the manifest workflow to reduce the run-time

Is your feature request related to a problem? Please describe
Current manifest workflow which is being called by the GH action versions.yml takes lot of time to run and randomly fails with Error: The operation was canceled. The cause of the issue is executing the methods gradle_cmd which calls ./gradlew properties and then outputs the version, based on this version the flow executes to raise a PR as follows https://github.com/opensearch-project/opensearch-build/pull/3008
With ./gradlew properties running on the OpenSearch repo taking lot of time the GH runner breaks with Error: The operation was canceled where as this works on local without any error.
Describe the solution you'd like
To get the version instead of running ./gradlew properties which starts Gradle Daemon runs the task Task :properties , its easy to query the file buildSrc/version.properties from the OpenSearch repo to get the version, something like OPENSEARCH_VERSION=$(cat buildSrc/version.properties | grep opensearch | cut -d= -f2 | grep -oE '[0-9.]+') which is already being used in version increment workflow, this should significantly reduce the time in the manifest workflow execution.
Describe alternatives you've considered
No response
Additional context
No response

Adding @dblock and @opensearch-project/engineering-effectiveness.

Using version.properties directly might cause issue later if there is more than one opensearch key value pairs.

Should there be only only one OpenSearch version in version.properties @peterzhuamazon

Maybe we can turn the workflow into a matrix where each runs in parallel?

One more data point, adding PR manually https://github.com/opensearch-project/opensearch-build/pull/3164

This issue seems to be recurring for every release and I would like to close it out as soon as possible. @prudhvigodithi @zelinh Can we move ahead with @dblock suggestion?

Another dp here https://github.com/opensearch-project/opensearch-build/pull/3192.
I would like we prioritize this issue so we could get unblocked.

As per my understanding we are running ./gradlew properties -Dbuild.snapshot=false and writing the property output. We are then reading the properties to get the value of version key to get the version here.
I do not see any other usage of values returned by the gradle command and believe it is safe to be replaced by @prudhvigodithi proposed solution, unless, I may have missed any other usage of the properties value retrieved. Please correct me if my understanding is wrong @peterzhuamazon @dblock.
Also, @peterzhuamazon since opensearch is supposed to be a key, it cannot be duplicated, right?
@dblock Can you also please add some more details regarding the solution you proposed with respect to running in parallel?

Hey @rishabh6788 @dblock just to add running in parallel with the solution proposed (a matrix strategy for GitHub runners) might not be a right solution here, it would work for instances when a loop of isolated process has to be called. For manifest workflow its all single process  ./manifests.sh update and does not take any inputs example like ./ci.sh ${{ matrix.manifest }} --snapshot where ./ci.sh can be split into multiple process each process having an input of manifests under the manifests folder.
Here  ./manifests.sh update is a single process that add manifests based on OpenSearch Core branches,  if we have to run in a matrix may be we have modify the code manifest workflow like  ./manifests.sh update ${{ matrix.core_branch }}, having this we can run in a loop for each core branch, rather than this querying version.properties would be easy and less complex approach go with.
Thank you

Until the optimization takes place, we moved the workflow to jenkins here: https://build.ci.opensearch.org/job/manifest-update/
It was able to create a PR with 2.8.0 https://github.com/opensearch-project/opensearch-build/pull/3433

Closing this issue as we have moved the workflow to run on higher specs machine that can handle gradle properties check which seems more appropriate than  parsing the version.properties file.
Please re-open if you think proposed solution above is more appropriate.
Thanks!


dataset problem - Revert ocularAnteriorSegmentAtlas from complete to valid

Dataset/group this task is for:

project uuid - 16e99159-78bc-44aa-b479-55a5e903bf50
link to browser HCA data portal
link to ingest UI

Relevant People

Wrangler - Rachel, William, Jason

Description of the problem with the dataset
New files and metadata need to be added to this submission so the status needs to be reverted from complete.

Submission state changed to Metadata Valid.


PISA Performance Scores Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : PISA Performance Scores Analysis
:red_circle: Aim : The aim of this project is to analyze the dataset using machine learning models.
:red_circle: Dataset : https://www.kaggle.com/datasets/thedevastator/pisa-performance-scores-by-country
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID (If not, then put NA) :
Approach for this Project :
What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hi @abhisheks008 , I would like to take up this issue!!
Full name : Aniket Ray
GitHub Profile Link : https://github.com/raysofani
Participant ID (If not, then put NA) : NA
Approach for this Project :
EDA Processing
Feature engineering
Use 3-4 algorithm to Analyse and do the required Prediction. Will use Regression algorithm like linear regression, Decision Tree, Random Forest and XGboost for improved accuracy. finally based on the complexity of dataset best suited algoithm will be used.
What is your participant role? IWOC 2.0

Complete your previous issue first @raysofani

Hi @abhisheks008
I would like to take this issue.
Full name : Mariam
GitHub Profile Link : github.com/mariam7084
Participant ID : NA
Approach for this Project : perform EDA and visualize the results
What is your participant role? JWoC 2024

Assigned @mariam7084


node v5.9.1

Unsuccessful install.
npm install --production gives error when using node v5.9.1
npm-debug.log:
71938 error Linux 3.13.0-79-generic
71939 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--production"
71940 error node v5.9.1
71941 error npm  v3.7.3
71942 error code ELIFECYCLE
71943 error<EMAIL_ADDRESS>preinstall: `npm install semver && node -e "require('./core/server/utils/startup-check.js').nodeVersion()"`
71943 error Exit status 231
71944 error Failed at the<EMAIL_ADDRESS>preinstall script 'npm install semver && node -e "require('./core/server/utils/startup-check.js').nodeVersion()"'.
71944 error Make sure you have the latest version of node.js and npm installed.
71944 error If you do, this is most likely a problem with the ghost package,
71944 error not with npm itself.
71944 error Tell the author that this fails on your system:
71944 error     npm install semver && node -e "require('./core/server/utils/startup-check.js').nodeVersion()"
71944 error You can get information on how to open an issue for this project with:
71944 error     npm bugs ghost
71944 error Or if that isn't available, you can get their info via:
71944 error     npm owner ls ghost
71944 error There is likely additional logging output above.
71945 verbose exit [ 1, true ]

This is expected behaviour. See the docs for an explanation: http://support.ghost.org/supported-node-versions/

Thanks @ErisDS!
Fyi there's also a ghost slack: #6389


Make boto3 session creation threadsafe.

Fixes #560
This makes session_cache.get_session threadsafe, so that only 1 boto3 session can be initialized at a time, since boto3 client creation itself is not threadsafe.

Actually, thinking about this a bit more, this probably isn't the correct fix for this race, since the race is happening between these lines in multiple threads:
https://github.com/remind101/stacker/blob/e123052c6f549559bea1426983786803011f72eb/stacker/session_cache.py#L66-L67
CredentialCache itself needs to be threadsafe.


Add/update notebooks

This PR adds and updates Jupyter notebook examples and is ready for review. If errors arise on the testing server I will plan to open a new PR addressing them.
Additional tasks:

[x] Add notice about using jupyterlab instead of jupyter notebooks for notebooks using pyrosetta.distributed.viewer
[x] Add notice about installing third-party external packages in 01.00-How-to-Get-Started.ipynb: matplotlib biopython blosc dask distributed jupyter numpy pandas py3Dmol scipy traitlets graphviz seaborn dask-jobqueue

Hi @lyskov, this PR is ready for review. Upon merging this into the PyRosetta.notebooks submodule I will update the submodule HEAD from #4279 and queue testing of the notebooks (which now include ipython magic commands and third-party package imports) from #4279. If any errors arise on the testing server from this PR, I can open a new PR addressing them.

GNU-Parellel
This is also a great notebook.  Some comments that need to be addressed.

You have the user cat expected_outputs/run_file_parallel_interactive.txt  instead of the one specific for their work environment in output that you had created in the block before. I would also use the command parallel instead of the full path as the path can be different (and certainly is on my mac).  If it's not found - instruct the user how to install it on linux/mac. Or just point to the GNU-parellel website for more info.

Users may not know what SLURM is.   I would include a description of what slurm is. Explain that this is for a cluster-environment, and that SLURM is just one of several job-submission applications and that their cluster may not have SLURM.  Also note that the notebook is setup from via hosting in a cluster environment.  Provide links for how to set this up.

dask-delayed

I would change the name of this to Dask-Delayed via SLURM or something like that.

I could not run this locally. I would put a disclaimer on the top of this notebook that it must be run on a SLURM-capable machine, most likely a cluster.

dask-delayed-PyRosetta

I would combine this with dask-delayed.  I would have it in a second major section.

Again, I could not run this locally.

Make sure users have graphviz installed to see the visualization you have here.

ligand-docking-Dask

Same for above.  Combine the completed and main notebooks to one notebook.  If there is a way to have the client not be slurm, please add these.

Thanks for writing these Jason!  I think these are really cool and a great addition.  Cheers!

@jadolfbr many thanks for your review! I have now updated the notebooks addressing your comments. The only point that I could not directly address in the notebooks is that the interactive slider widget did not work for you, which requires the ipywidgets module so you might try pip install jupyter to fix that. I have also added third-party dependency installation instructions to 01.00 and 01.01. I think this PR is ready to merge pending your review. Thank you again!


fix: problem in issues #810

The problem shown in #810 is caused by UniRef30_2021_03. It should be changed to the latest version UniRef30_2023_02 for some practices.

Is there anything that's still blocking this PR?

I guess downloading from wwwuser.gwdg.de is much slower than from Google Cloud Storage. It would be preferable if the updated UniRef 30 were mirrored in GCS as well.

I guess downloading from wwwuser.gwdg.de is much slower than from Google Cloud Storage. It would be preferable if the updated UniRef 30 were mirrored in GCS as well.

I really agree with you. This issue should be fixed since many students who know nothing about coding are using AlphaFold2 through Supercomputing platform which use this repository as a easy program. They feel confused with the problem caused by the issues.


[Bug][Integration][Airflow] In Airflow 2.3 unknownSourceAttribute facet is always set

I ran a BigQueryExecuteQueryOperator on Airflow 2.3 from which input and output datasets were successfully extracted.
When I query the resulting job I see the inputs/outputs/context successfully set but I also see:
"unknownSourceAttribute": {
        "_producer": "https://github.com/OpenLineage/OpenLineage/tree/0.8.1/integration/airflow",
        "_schemaURL": "https://raw.githubusercontent.com/OpenLineage/OpenLineage/main/spec/OpenLineage.json#/definitions/BaseFacet",
        "unknownItems": [
          {
            "name": "BigQueryExecuteQueryOperator",
            "type": "operator",
            "properties": { <REDACTED> }
          }
        ]
      }

I assume that what is happening is that when the task starts and extract_metadata() is called for the first time it calls the extract() method on BigQueryOperator which returns None
A potential fix could be to only return the TaskMetadata with the unknownSourceAttribute facet in the else case where no extractor was found.

This was closed by: #762


Wrong key

Press Shift+F5 to compile and run the program without debugging.nter feedback here]
should be Ctrl+F5

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8df4bc4b-88e1-a629-fcbd-6808b4f7308c
Version Independent ID: 87d3afdd-d7d5-35d7-0718-63dadc4eab1d
Content: Create a .NET Standard class library using Visual Studio - .NET Core
Content Source: docs/core/tutorials/library-with-visual-studio.md
Product: dotnet-core
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Thanks for reporting that!


feat(parquet): introduce inverted index applier to reader

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add the index applier in the Parquet reader to filter row groups:

Add the inverted_index_available property to SstInfo and FileMeta
Introduce the row_groups_to_read method for ParquetReaderBuilder, which returns row groups that still need to be read after being filtered through the inverted index and min-max index
Add metrics to observe the selectivity of the index

Moreover, once inverted_index_available becomes a property of FileMeta, it not only represents a single SST File but also includes the associated index files. Therefore, when handling deletions, they should be deleted together.
Checklist

[x]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

Refer to a related PR or issue link (optional)
#2705

@waynexia @evenyag PTAL

@evenyag @waynexia PTAL


How to sort complete dataset when paging is enabled?

The sort functionality works great but when paging is enabled, only the items of the selected page are sorted when you sort a column but sometimes a user might want to sort all items of that column. Is this possible right now?
Thanks.

I guess It is known the issue that hasn't been fixed yet.  #40
@jeremy-ingenuity

Hi there @evrencoskun , I already have a working solution for this but I haven't pushed it yet/created a pr for now, I've been busy these past weeks and haven't worked on this. Aside from fixing the issue, I also have other features to suggest and contribute.
Hi @ankurt-optimus , for now, a workaround can be saving the column index/indices that the user wants to sort and their corresponding SortStates and sorting those columns whenever the the TableView page is turned (using the Pagination.OnTableViewPageTurnedListener), although, this would cause an increase in processing steps, but the original dataset and order is not altered.
...
    mPagination = new Pagination(mTableView);
    mPagination.setOnTableViewPageTurnedListener(onTableViewPageTurnedListener);
...

private Pagination.OnTableViewPageTurnedListener onTableViewPageTurnedListener =
        new Pagination.OnTableViewPageTurnedListener() {

            @Override
            public void onPageTurned(int numItems, int itemsStart, int itemsEnd) {
              // assuming that you have a list of ColumnSortState objects
              // name tableColumnSortStates
                for (ColumnSortState columnSortState : tableColumnSortStates) {
                    mTableView.sortColumn(columnSortState.getColumn(), columnSortState.getSortState());
                }
            }
        };
...

// sample class ColumnSortState to store the SortStates of columns
class ColumnSortState {
    private int column;
    private SortState sortState;

    public ColumnSortState(int column, SortState sortState) {
      this.column = column;
      this.sortState = sortState;
    }

    public int getColumn() {
      return this.column;
    }

    public SortState getSortState() {
      return this.sortState;
    }

    public void setSortState(SortState sortState) {
      this.sortState = sortState;
    }
}

Thanks, will update soon.

Hi  @jeremy-ingenuity, nice to hear that! 👍

@jeremy-ingenuity @evrencoskun
Thanks jeremy, i thought about this workaround as well, but this doesn't fit my needs well. What this does is that it maintains the sorting state when the page index has changed but my issue is that sorting is applying only on the items that are on a page but what you might want is that the whole dataset should sort.
Suppose there are 1-1000 number entries below a column and page size is 10, on sorting the first page in descending order i get entries like (10,9,8......up to 1) according to current implementation but what should happen is i should entries like (1000, 999, 998, 997, 996....990) on the first page index.
Now the current behavior might be useful in some cases as well, so it can be sort of a configurable feature.
Thanks.

Hi @ankurt-optimus

Suppose there are 1-1000 number entries below a column and page size is 10, on sorting the first page in descending order i get entries like (10,9,8......up to 1) according to current implementation but what should happen is i should entries like (1000, 999, 998, 997, 996....990) on the first page index.

Oh yeah, I completely missed that this should be the exact behaviour and not just the "per page sorting", I shall review the code and implementation again and provide a good implementation so that pagination and sorting would work seamlessly. Thanks 😄


Add option --no-bundle

Adds support for the option --no-bundle, equivalent to using esbuild without --bundle.
Closes #66.

This needs more work because it doesn't handle imports recursively. So imports called from other imports are not transpiled or included in the final build. I'll try to work on it when I have time.


Add an EGL driver and port X11 OpenGL handling to it

This uncouples Godot from GLX, effectively allowing other DisplayServers like Wayland to use OpenGL.
This is done by replacing the libGL dependency with libglvnd's own libEGL (which shouldn't be a problem since it has been around for quite a while now), adding a new EGL_ENABLED define (defined in drivers/egl/SCsub) and a new EGLManager driver, which wraps the EGL API in a platform-agnostic way.
All OpenGL methods get loaded by GLAD through a code path selected by the EGL_ENABLED define in RasterizerGLES3.
This new driver is based almost completely on the original GLManager_X11 (the creators of which I thank a lot), cleaning it up and making it follow more closely the coding conventions I learned while working on the rest of the engine. Most notably it removes all window size handling logic (as it's not needed and already did nothing) and, for the sake of being platform-agnostic, moves all X11 VisualInfo handling to its DisplayServer. Other platforms using it will have to implement their own specific quirks on their own, like Wayland having to manipulate its own wayland_egl handles.
To use it, all platforms must implement a platform-specific child class which extends its two _get_platform_extension_* methods and make all calls through it.
This PR is still a draft as it needs a little bit more testing.
Note that, although AFAIK EGL is supported on Android, I haven't ported anything other than X11 stuff.
I got also told that currently VR handling depends on GLX, but as I got no VR equipment I'm unable to work on this this myself. I'd be glad to assist any VR developer that wishes to help me with this problem.

Thanks for splitting out this PR!

Note that, although AFAIK EGL is supported on Android, I haven't ported anything other than X11 stuff.

AFAIK, Android is already using EGL.

I got also told that currently VR handling depends on GLX, but as I got no VR equipment I'm unable to work on this this myself. I'd be glad to assist any VR developer that wishes to help me with this problem.

I'll paraphrase what I wrote over on #57025:
I'm working on a OpenXR with OpenGL PR (#67775), and the only way in the core standard to initialize OpenXR on X11 is using the XrGraphicsBindingOpenGLXlibKHR, which needs to take some pointers from GLX. I did discover that there is a vendor extension from Monado (XR_MNDX_egl_enable) that appears to allow initializing via EGL. If we can make the assumption that anyone on Linux is using Monado, we could perhaps rely on this extension? I haven't dug into it any deeper than looking at the docs, though, so this would need to be tested.
However, if we can't rely on that extension, then for OpenXR we'll need to stick with GLX for X11. There's perhaps a way to use GLX, but load libGL.so dynamically to prevent the dependency for folks who only have Wayland (without xwayland)?
@BastiaanOlij What are your thoughts?
@clayjohn Are there any other considerations with switching from GLX to EGL on X11?

@dsnopek I guess for OpenXR we can simply detect that extension and fail initialization if that extension is not available and EGL is used. Hopeful OpenXR runtimes on Linux will implement the extension.

@BastiaanOlij so, your inclination is to go for the switch to EGL on X11, and not worry that we'd be incompatible with SteamVR? As I said on RocketChat, my inclination would be to stick with GLX for now (but dynamically load libGL.so somehow) to retain compatibility. But I'm fine to go with whatever the consensus is!


Redis integration (Async coordinator poc)

First try to build an async version of the coordinator. The async version uses redis to maintain its state. In addition, the aggregation part was removed to simplify the implementation. I took some ideas from the mini-redis project.
I will add some more comments later.

closed in favor of #413


feat: initial redesign

@ctizen @zardak it seems like the layout should be scaled down to ~80%. Currently the main page looks quite ugly.

@ctizen @zardak it seems like the layout should be scaled down to ~80%. Currently the main page looks quite ugly.

Probably we should ask design team about it. E.g. I'd scale header to 80%, but cards to 60%.


Omit built-in context prop if user component props include context

This PR:

Reworks the type inference for connect so that if the user's component expects props.context already, we use that type instead of the possible alternate context: ReactReduxContext type
Uses a Mapped type to simplify the hover display types for connected components.

Connected components allow users to pass in a ReactReduxContext instance as a prop named context. We also do internal checks to see if that really is a context instance, in case the user passed a real value as props.context.
However, the TS types did not reflect this - props.context was always a ReactReduxContext type, and if users did have a component that accepted a prop named context, this would cause a type clash.
In this case, the types didn't reflect the reality of runtime behavior.
By extracting "the props of the component" and omitting the built-in context field type if appropriate, this now works.
Fixes #1957 .
Additionally: due to the ridiculous types-level shenanigans inside of connect, the hover display of connected components is incredibly obtuse and hard to read.
Over the last year I've experimented with several different util types that "expand/flatten" a TS typedef to make the actual fields more readable (and by "experimented" I mean "I stole them from other repos and pasted them in to see what would happen").  One of the simpler ones is a Mapped type:
type Identity<T> = T
export type Mapped<T> = Identity<{ [k in keyof T]: T[k] }>

(I don't pretend to understand all the magic there, but it works!)
By inserting that at the right spot in the connected inference sequence, we get a much better hover display for connected components.
Some examples from our type tests:
// Before:
const ConnectedButton: ConnectedComponent<(props: IButtonProps) => JSX.Element, Omit<IButtonOwnProps & {
    name: string;
} & DispatchProp<AnyAction>, "dispatch" | "name"> & {
    ...;
}>

// After
const ConnectedButton: ConnectedComponent<(props: IButtonProps) => JSX.Element, {
    label: string;
    context: 'LIST' | 'CARD';
    store?: Store<any, AnyAction> | undefined;
}>

// Before:
const Test: ConnectedComponent<typeof TestComponent, Omit<React.ClassAttributes<TestComponent> & OwnProps & StateProps & DispatchProps, "bar" | "onClick"> & {
    ...;
}>

// After
const Test: ConnectedComponent<typeof TestComponent, {
    foo: string;
    ref?: React.LegacyRef<TestComponent> | undefined;
    key?: React.Key | null | undefined;
    context?: React.Context<ReactReduxContextValue<any, AnyAction>> | undefined;
    store?: Store<...> | undefined;
}>

Most users aren't going to care about the ref/key/context/store part... but it is much easier to read and more accurate.  So we're throwing that in here as a bonus.

HALP the TypeScript just blew up on the floor:
Version 4.2.4
Error: src/components/connect.tsx(789,5): error TS2322: Type 'FunctionComponent<WrappedComponentProps> & NonReactStatics<ComponentType<TProps>, {}> & { ...; }' is not assignable to type 'ComponentType<TActualOwnProps>'.
  Type 'FunctionComponent<WrappedComponentProps> & NonReactStatics<ComponentType<TProps>, {}> & { ...; }' is not assignable to type 'FunctionComponent<TActualOwnProps>'.
    Types of property 'propTypes' are incompatible.
      Type 'WeakValidationMap<WrappedComponentProps> | undefined' is not assignable to type 'WeakValidationMap<TActualOwnProps> | undefined'.
        Type 'WeakValidationMap<WrappedComponentProps>' is not assignable to type 'WeakValidationMap<TActualOwnProps>'.
          Type '(null extends WrappedComponentProps[K] ? Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined> : undefined extends WrappedComponentProps[K] ? Validator<...> : Validator<...>) | undefined' is not assignable to type '(null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>) | undefined'.
            Type 'null extends WrappedComponentProps[K] ? Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined> : undefined extends WrappedComponentProps[K] ? Validator<...> : Validator<...>' is not assignable to type '(null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>) | undefined'.
              Type 'Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined> | (undefined extends WrappedComponentProps[K] ? Validator<...> : Validator<...>)' is not assignable to type '(null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>) | undefined'.
                Type 'Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined>' is not assignable to type 'null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>'.
                  Type 'null extends WrappedComponentProps[K] ? Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined> : undefined extends WrappedComponentProps[K] ? Validator<...> : Validator<...>' is not assignable to type 'null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>'.
                    Type 'Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined> | (undefined extends WrappedComponentProps[K] ? Validator<...> : Validator<...>)' is not assignable to type 'null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>'.
                      Type 'Validator<WrappedComponentProps[K] | (WrappedComponentProps[K] & null) | undefined>' is not assignable to type 'null extends TActualOwnProps[K] ? Validator<TActualOwnProps[K] | (TActualOwnProps[K] & null) | undefined> : undefined extends TActualOwnProps[K] ? Validator<...> : Validator<...>'.

oops

Board is green, let's get this in.

sigh
I was supposed to merge this an hour ago, before publishing 8.0.3

@markerikson First of all thank you for doing all of this, I am honestly blown away how responsive you guys have been given the size of this library.
I have updated my sandbox to use this version of the PR: https://codesandbox.io/s/tender-mestorf-x272kj?file=/src/client/Button.tsx
The error is gone! As long as the component has it's own context: required prop, there will be no error.
If the prop is optional IE: context?: CARD | LIST, we have the same TS error as before. Is that intentional you think or simply a limitation of TS in this case, since like you said some of these typing are pretty intense! In any case, thank you again, I can make this work!
Also
type Identity<T> = T export type Mapped<T> = Identity<{ [k in keyof T]: T[k] }>
This is pure magical! I plan on using this in our app, this is a complete game changer for hover display!

@strongui Nice, glad that works!
I'd say that the change is semi-intentional / semi-limited.  If you look at the implementation, it boils down to a check of TOwnProps extends { context : any } ?.  In other words, "does the type of your component's props include a field named context in it?".
I'm honestly not sure if you can detect optional fields that way. It's possible you can, this was just the first solution I could think of.
Note that this is now out publicly in 8.0.4:
https://github.com/reduxjs/react-redux/releases/tag/v8.0.4

TOwnProps extends { context?: any } ? should do the trick if I'm not mistaken :)

Hmm. Yeah, that does actually appear to work.


Error syncing load balancer

Hi, I'm pretty new to Terraform and k8s so forgive me if I'm missing something obvious, but when trying to install Helm charts I keep running into the same error:
Error syncing load balancer: failed to ensure load balancer: hcloud/loadBalancers.EnsureLoadBalancer: hcops/LoadBalancerOps.Create: neither load-balancer.hetzner.cloud/location nor load-balancer.hetzner.cloud/network-zone set

Nevermind, I figured it out. I had to add load balancer annotations to the Helm chart I was installing:
helm install wp bitnami/wordpress --set service.annotations."load-balancer\.hetzner\.cloud/location"="hel1"


Allow coordgen and maeparser to be built as static libraries

Reference Issue

The code in the coordgen and maeparser now incorporates explicit dllimport/dllexport decorators, however it does not seem to support building static libraries on Windows anymore, as dllimport/dllexport decorators are always added.
What does this implement/fix? Explain your changes.
As the RDKit needs to build static libraries too, I added a patchCoordGenMaeExportHeaders() function to RDKitUtils.cmake which adds a few pre-processor directives to coordgen and maeparser headers to allow that. Additionally, I removed the CMAKE WINDOWS EXPORT_ALL_SYMBOLS bit from the coordgen CMakeLists.txt as it is not needed anymore, since now explict decorators are present in the headers. I also added the -DIN_COORDGEN and -DIN_MAEPARSER definitions to the coordgen CMakeLists.txt as required by the new coordgen/maeparser headers.
Any other comments?

Paolo -  I thought the future was dynamic linking, even on Windows? (I'm excited about your PR https://github.com/rdkit/rdkit/pull/1861). I assume that this is because dynamic linking is not yet the default on Windows?

I can answer at least part of this: there are definitely some cases where I would like to be able to continue to statically link. The one that jumps right out at me is the Java wrappers. Having to switch those over to use DLLs would complicate stuff "a bit".

@d-b-w Hi Dan, the reason why dynamic linking on Windows (which has been introduced with PR #1861) is not the default is to avoid breaking existing build scripts which assume static libraries to be generated. You may build the DLLs adding -DRDK_INSTALL_DLLS_MSVC=ON to your cmake flags. As Greg says, there are definitely use cases for static linking on all  platforms, so the build system will keep supporting both static and dynamic libraries.

That totally makes sense. Thanks guys. (I wasn't objecting, just hoping for context when I think about build in maeparser and coordgen in the future).


Guides revision

Hi Andrew,
here is what we have done with the Guides Revision. Another user can make revision of someone`s else guide, which is sent to the admin for Approve or Reject. After admin has approved the revision, the body_markdown of the Guide will be replaced with the new content. When you are logged as admin, you can view two tables - pending revisions and another below with approved/rejected. At the same time, the user will receive info if the revision is approved or rejected.
We know that there are many more things to be done, so we can continue work further on it, just send us your comments about it.

This is really great work! :+1: I'm going to try it out locally before merging it, but I don't have many comments. I think it has been implemented well and I can tell that you've put a lot of time into it. Thanks!


#166 Refactored predict cubes

The predict_cubes function has been refactored to reduce its complexity.
Description
The predict_cubes is now splitted on the support functions:
-prepare_data, by a given patient ID it returns three np.ndarray.
-annotate, by a given model and a volumetric data, it returns a DataFrame.
-stats_from_batch, for each nodule in a batch it returns a list of DataFrame
Reference to official issue
This addresses #166
CLA

[x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

LGTM otherwise!

I'm not completely sure that I've done it correctly in the code base.

What do you mean?

Merged, thanks!


When monitorable property of Area2D is true, the area does not detect when monitorable property of second overlapping Area2D is toggled

Tested versions
v4.3.stable.official [77dcf97d8]
System information
Godot v4.3.stable - macOS 15.1.1 - GLES3 (Compatibility) - Intel(R) UHD Graphics 630 - Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 Threads)
Issue description
I have an Area2D - lets call it "Hurtbox" - set to detect other Area2Ds on a given layer - lets call this other Area2D "Hitbox".
When the monitorable property of "Hurtbox" is false, it is able to detect collisions with "Hitbox" even when the monitorable property of "Hitbox" is toggled while the two Area2Ds are overlapping.
However when the monitorable property of "Hurtbox" is true, it is only able to detect collisions with "Hitbox" if the monitorable property of "Hitbox" is set to true before the two Area2Ds collide. I would expect this to work the same as when the monitorable property of "Hurtbox" is false.
https://github.com/user-attachments/assets/caa3873c-300b-406a-b934-6ffa3be5149e
Additionally when the monitorable property of both "Hurtbox" and "Hitbox" are true and the two are overlapping, if the monitorable property of "Hitbox" is set to false this is not detected by "Hurtbox" until it is moved to no longer overlap.
This may be related to #100346, #71489, and #17238.
Steps to reproduce

Create an Area2D. Set its monitoring to true, monitorable to true, and Bit 0 of collision_mask to 1. Connect methods to its area_entered and area_exited signals to detect collisions. This is the "Hurtbox".
Create a second Area2D. Set its monitoring to false, monitorable to false, and Bit 0 of collision_layer to 1. Do not connect anything to its area_entered nor area_exited signals. This is the "Hitbox".
Have the two Area2Ds overlap.
While the game is running, set monitoring of "Hitbox" to true.

Expected: "Hurtbox" detects the collision.
Actual: "Hurtbox" does not detect the collision.
Minimal reproduction project (MRP)
collisiontest.zip

Thank you for reporting! We prefer to have one report tracking each issue so I am closing this and consolidating in:

https://github.com/godotengine/godot/issues/71489

Please see there for more details


[Quantum] Add job usage events

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
[george] 10/20/21
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
[george] October
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Hi, @george-moussa. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.


slabtext-linesize-[N] and slabtext-linelength-[N] not added

Any advice greatly appreciated. I just updated from 2.3.1 to 2.4 to get the classnames slabtext-linesize-[N] and slabtext-linelength-[N].
I don't see the classes added. The right script is loading, slabtext is working, but no slabtext-linesize-[N] or slabtext-linelength-[N] classes.
I checked the demo and the new classes do not appear to need 'switching on'. Feeling dim, any help appreciated.
 The demo certainly has them but this doesn't mean the code bundle has the correct minified code... apologies...

No worries and thanks for letting us know.


Replace underscores for dashs in multi word names

Seems that according to jsonapi spec and ember data jsonapi,
some_thing , should become some-thing.
In the jsonapi.org page, it has the example:
....
attributes": {
      "first-name": "Dan",
      "last-name": "Gebhardt",
      "twitter": "dgeb"
    },

....
If i manage to learn how to do this, i can do it on the weekend and write some tests.

@alexjp nice. A hint is we could process the attributes here https://github.com/jeregrine/jsonapi/blob/master/lib/jsonapi.ex#L86 maybe piping it into a new function.

Important to note that JSONAPI recommends using dashes, but does not require them. An easy way to opt-in to dasherized attributes would be great though!

@alexjp @adamesque in the spec doesn't say anything about any recommendation in term of naming. Correct me if I am wrong http://jsonapi.org/format/#document-member-names

To enable an easy mapping of member names to URLs, it is RECOMMENDED that member names use only non-reserved, URL safe characters specified in RFC 3986.

Either way, API consumers most of the time will prefer to have underscore instead of dashes, the dot notation is broken when you use dashes. .attributes.first_name vs (Hopefully) .attributes['first-name']
@alexjp in the Ember examples they use underscore as well http://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_using-json-api-error-object-format
This could be a extra configuration to add but I wouldn't recommend to put it by default

The latest version of the spec recommends hyphen minus as a separator between multiple words.

@emwalker yep, R.I.P Javascript dot notation with it or anyone that can read it with dot notation or R.I.P languages that don't support dashes in the hash keys.

@jeregrine do we want to support this change by default or add a configuration option to swap _ for -?  I can take a stab at getting a PR up for this.

I have no strong convictions on this one @doomspork configuration may be best. Or maybe a function?


Return 404 Not Found when http method name is unknown

Before:

Path is under /api (handled by RESTeasy's HttpServlet30Dispatcher)

If a method for the path is NOT available: 404 Not Found

If a method for the path is available:

if @GET, etc. annotation is same with the requested method: 200 OK

otherwise: 405 Method Not Allowed

Path is not under /api

Resource is always unavailable (no servlets are mapped to this path)

If method is either of GET, HEAD, POST, PUT, DELETE, OPTIONS, or
TRACE: 404 Not Found
(handled by Undertow's DefaultServlet which extends
javax.servlet.http.HttpServlet)

otherwise: 501 Not Implemented

This change maps a new servlet to /api that returns 404 Not Found for
any requesting methods so that behavior becomes consistent with paths
under /api.
javax.servlet.http.HttpServlet was returning 501 Not Implemented: http://www.docjar.com/html/api/javax/servlet/http/HttpServlet.java.html

👍


relaxngDatatype - split package problem on JPMS

Jaxb-ri depends on relaxngDatatype:relaxngDatatype:20020414 [1] which contains classes extracted from here:
https://github.com/relaxng/jing-trang/tree/master/mod/datatype/src/main/org/relaxng/datatype
This will cause split package problem if loaded as a module together with official Jing [2].
[1] http://repo1.maven.org/maven2/relaxngDatatype/relaxngDatatype/20020414/
[2] http://repo1.maven.org/maven2/com/thaiopensource/jing/20091111/

Fixed in 2.3.1


MM-14498 Generate random channel URL name from display names that don't clean into a usable name

Summary
Generate random channel URL name from display names that don't clean into a usable name. This will fix cases where non-latin characters are used in the display name but are not convertible to a usable channel name.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14498
Checklist

[x] Added or updated unit tests (required for all new features)

Can somebody help cherry pick this to v5.11?

Thanks @migbot


Add to Paradox Mods

Hi, thank you for this awesome mod. Any chance you can add it to the official Paradox Mods?

Yes, I miss this mod very much and I have not found anything like it in paradox mods. I hope to add it


Using skunami with mesh models

I'm trying to find out how to use your library with meshed models.
Any pointers as to what I would need to do to setup skunami with an openCTM
model rendered with three.js ?
I'm trying to visualize the effect of rising flood waters with models generated from UAV aerial imagery.
Awesome library by the way!

Hi there eokeeffe,
Three.js supports OpenCTM models, so loading them into the scene shouldn't be a problem.
Official example: http://threejs.org/examples/webgl_loader_ctm.html (see the source code)
To get it to work with skunami, call addStaticObstacle(mesh) where mesh is a THREE.Mesh that you can get from loading your OpenCTM model. The skunami water sim should then reflect off this obstacle automatically.
The codes will go something like this:
//create gpu skunami water
var gpuWater = new SKUNAMI.GpuPipeModelWater(...);  //or whichever water model that you would like to use

//load openctm model as a THREE.Mesh
var mesh;
var loader = new THREE.CTMLoader();
loader.load("yourmodel.ctm",  function(geometry) {
    var material = new THREE.MeshPhongMaterial(...);
    mesh = new THREE.Mesh(geometry, material);
    scene.add(mesh);
}

//add the loaded mesh as a static obstacle
gpuWater.addStaticObstacle(mesh);

//update every frame (place these lines in your update loop)
renderer.clear();
gpuWater.update(dt);  //have to do this after clear but before render
renderer.render(scene, camera);

Just wanted say thanks again
I got it working http://eokeeffe.github.io/FloodSimulation/example.html
One thing I was wondering was how to make the mesh have the same type
of collisions as the created skulpt

Hi eokeeffe,
Did you mean how to turn your mesh into a height field so that skunami.js water can interact with it? You can render your mesh from the top view and use the depth as a height field texture.
I have to dig out an example. Will get back to you on this soon!


⚠ Samsung has degraded performance

In 4139c50, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2348 ms

Resolved: Samsung performance has improved in ac509d0.


Use flat folder for JATS output

@xuanxu I forgot, how are the artifacts copied to the target repository? Would it help if Inara took a target directory as another argument?

If I understand it correctly, we need:

All the images in the same directory as the jats file
The correct relative references in the JATS file to the images
A directory to know what to upload to the final repository

Would it be easier to have jats file and images in a separate jats_files (for example) directory?

Would it be easier to have jats file and images in a separate jats_files (for example) directory?

Yeah, I agree I think this would be the ideal solution here (a self-contained folder with everything in related to JATS, but also without any nested folders).

we now create a folder paper.jats that has all the relevant data, including the images, all at the same level. Example:

Just for absolute clarity – the paper (e.g., paper.jats.xml) will also be in that same directory?

I've prepared a branch in the GH actions to use this changes and keep the paper.jats folder when uploading to the papers repo. I'll merge the changes once this new version of inara is up.

Just for absolute clarity – the paper (e.g., paper.jats.xml) will also be in that same directory?

Yes, the paper.jats folder includes the xml and any media files

Sorry, I'm not entirely clear on these questions:

Is there more work needed on Inara?
Who will merge the PRs? (I assume @xuanxu?)

1. Is there more work needed on Inara?

I don't think so (every new commit is automatically re-publishing the Inara Docker image, right?). This is ready.

2. Who will merge the PRs? (I assume @xuanxu?)

I'll merge them all at the same time tomorrow morning so I can monitor the actions.

Thanks @tarleb!

Hang on, isn't this URL incorrect?
https://github.com/openjournals/joss-papers/blob/eff5cbbffd13961e4399e80bde0033daed1221de/joss.05618/paper.jats/10.21105.joss.05618.jats#L159
(i.e., I think it should be ./matbench-genmetrics.png)

@arfon ouch, you are right, the files are in the right place but the URLs for images in the paper all point to /paper.jats/ folder https://github.com/openjournals/joss-papers/blob/master/joss.06017/paper.jats/10.21105.joss.06017.jats#L253
Is this easy to fix @tarleb?

Argh, my bad. I'll open a new PR in a minute.

See #53. Do we want to keep the /paper.jats/ path or shorten that to just /jats/?

@arfon can you reaccept this one to regenerate the files? https://github.com/openjournals/joss-reviews/issues/06017

Done

Hey @tarleb, merging #53 seems to have modified the DTD declaration in the generated JATS file, see the first lines here:
https://github.com/openjournals/joss-papers/commit/554242d5c9f19c5018a074c1b8fd8d6b3142537a
Is that intentional (in which case I'll update the xml validator) or is a bug?

I've updated the XML validator gem so now we can validate both the Journal Publishing and the Journal Archiving and Interchange tag sets.
Still not sure which of them we should use in Inara to generate the paper.jats file.

This was not intended, sorry. I'll push the fix without PR.
Note to self: better not to rush out patches at 2am after the ESC.

Do we want to keep the /paper.jats/ path or shorten that to just /jats/?

hey @tarleb, I noticed that sometimes there's already a paper.jats file in the repository created by the authors of the submission and that has caused conflicts on a couple reviews already, so on a second thought it's better to use another name for the folder, /jats/ or /paper_jats/ for instance.

Hey both. Can I just check where we landed here? In the joss-papers repo I see a PR that's flattening folders (good), but doesn't seem to be putting the papers into a jats folder.
Also, this most recently-merged PR looks to still be using the old paper.jats repo format?

Right now, in the joss-papers repo all the jats files (.jats and images) are placed in a paper.jats folder, so the structure is something like this:
joss-paper-1234.pdf
\paper.jats
    joss-paper-1234.jats
    image1.png
    image2.png
```

The `paper.jats` folder name was problematic when generated in the GitHub action, where sometimes conflicted with other files present in the submitted sofwtare's repo, so now inara creates the jats output in a folder called `jats`, it is an internal change. When uploading the files to a branch in the joss-papers repo, there is no problems with the name of the folder so `paper.jats` is still used there.

Ah great. So there's nothing to do here?

Right, I think we're good.


Update kotlin to 1.3.50

Related Links

Release Notes

Description
Kotlin updated to version 1.3.50
Highlights

Designing a new Duration and Time Measurement API (available for preview).
Working on an improved Java-to-Kotlin converter.
Experimental generation of external declarations for npm dependencies in Gradle Kotlin/JS projects (using Dukat).
A separate plugin for debugging Kotlin/Native code in IntelliJ IDEA Ultimate.
Java compilation support in multiplatform projects.

Should we add ready tag here as well 🤔 ?

Yes good thinking!
This repository will be (soonish ™ ) moved to @beatlabs. Since I'm doing some maintenance work in order to prepare it I was thinking it'd be better to add there all the missing labels 👍 🤘
(The labels don't get transfered along with a repository sadly).


Precompose navigation got my current scene unactive

As simple as that, when i navigate from login(scene) to home screen(group), and get back once the user logout is having this behaviour
If you can check the code out here: https://github.com/enmanuel52/Pop-Corns/tree/feat_auth i will appreciate
I'm sending out the pictures of how it looks like for active and inactive case.

I tried another approach, here is the code that did not change, but I don´t see anything wrong:
const val LOGIN_GRAPH_ROUTE = "/login_graph_route"
private const val LOGIN_ROUTE = "login_route"

fun Navigator.navigateToLoginScreen(navOptions: NavOptions? = null) {
    navigate(LOGIN_GRAPH_ROUTE, navOptions)
}

fun RouteBuilder.loginRoute(onLoginSucceed: () -> Unit) {
    group(LOGIN_GRAPH_ROUTE, "/$LOGIN_ROUTE") {
        scene(
            "/$LOGIN_ROUTE", navTransition = NavTransition()
        ) {
            LoginRoute(onLoginSucceed)
        }
    }
}

@Tlaster

I owe you and appologize 😅, I had some drawer state open that kept out the  focus , your library still rocks!!


Add revision support for Git source

Right now, we only support set Github url from here:
https://github.com/redhat-developer/build/blob/master/pkg/apis/build/v1alpha1/gitsource.go#L12
And cannot set revision and only use the master branch as Ref:
https://github.com/redhat-developer/build/blob/master/pkg/apis/build/v1alpha1/gitsource.go#L15
But in our experience, some times, the user wants to use other branch or commit or revisions, so we also need to support it by adding it in generate_taskrun.go:
https://github.com/redhat-developer/build/blob/master/pkg/controller/buildrun/generate_taskrun.go#L174
Hi @sbose78 ,
BTW, Can I get the writer permission in this repo, so that I can modify the issue tag or status in future.
Thanks!

Agreed! how do you think we should model this? revision should take higher precedence over the `ref ?

BTW, Can I get the writer permission in this repo, so that I can modify the issue tag or status in future.

Done :-)

Thanks!

Agreed! how do you think we should model this? revision should take higher precedence over the `ref ?

Are they different? At the beignning, I thought the ref and revision are same. Do you have any addtional configurations in ref?
If no, I suggest:

we also switch to use the name Revision in Build
Or just set the value of current ref to the Tekton git source revision ->
https://github.com/tektoncd/pipeline/blob/master/pkg/apis/resource/v1alpha1/git/git_resource.go#L44

So that it won't make the end-user confusing :)

I think I confused myself a bit there, yeah they are the same.  :)
We could switch to using Revision to keep things simple .

And cannot set revision and only use the master branch as Ref:

Sorry, why can't we ?

And cannot set revision and only use the master branch as Ref

Because right now, our logic doesn't support it.
So that is why I opened this issue to implement it.

Ah got it.
Sounds good! Yeah, the code assumes it is always master.

Hi @sbose78 ,
Implemented by using the PR https://github.com/redhat-developer/build/pull/85
Pls review.


Rounding errors in slideWidth accumulate, causing obscured slides

The width of slides is calculated using Math.ceil (see code here), so it can easily be off by almost 1px per slide. Over a large number of visible slides, this can accumulate enough to shift a slide off the right edge of the carousel, causing it to be partially hidden.
====================================================================
See this jsfiddle for an example. In the example, I deliberately set it up with a carousel width of 201px and 10 visible slides, so that each would have a computed width of Math.ceil(20.1) = 21.  The last slide has an accumulated error of ~10px, causing half of it to be obscured.  This version shows what happens when the width is changed to 200px, so that there is no rounding error - it works fine.
====================================================================
Steps to reproduce the problem

Set up a carousel with many visible small slides, little or no margin between slides, and fluid or manually-adjustable width.
Resize browser or otherwise adjust the width of the carousel. At some widths slides will be partially obscured.

====================================================================
What is the expected behaviour?
All slides should be entirely visible.
====================================================================
What is observed behaviour?
At some widths slides are partially obscured.
====================================================================
More Details
This is a mathematical issue with slick.js version 1.6.0; it will happen on all browsers and with all versions of jQuery. I am new to slick.js and do not know whether it ever worked in the past.
====================================================================
Workaround
As a workaround on a responsive page, one could add a zillion media queries that force the width of the carousel to resize in increments that are a whole multiple of the number of slides. Spacing the slides by > n pixels also prevents obscured slides, though they could end up looking off-center.
Suggested solution
I am not very familiar with the code, but I think a first step would be to change that Math.ceil to Math.floor.
The problem is that that would cause the next slide to become partially visible. So, I think that one of the divs (maybe .slick-list) should also have its width rounded down to crop the slides so that nothing else is shown.

Hey @pdg137, appreciate the issue. This bug is definitely a bit of a dagger. I can tell you it's on the radar and hopefully it gets resolved soon. Thanks!


Selection1D streams dont work on ndoverlay source?

While trying to find a simple example to raise an issue with DynamicMap and streams (another issue), i went back to simplest example closest to my problem and turned out that the example on curve selection doesnt work anymore? on tap selection always returns  None.

Sorry about the delay getting back to you and thanks for reporting this! It does seem like there is a bug here for us to fix...

This should work now but I'm going to repurpose this issue to fix it more generally.


Source.ToCore: Let can be simplified

The conversion from Source to Core can be simplified a bit.
Lets are currently converted to a tuple of the input value and the let-bound expression. This was necessary in the original Core language because the streaming operations (Map, Filter) explicitly specified their input streams.
With the new Core, there are no explicit streams, and the body of folds and filter expressions can just refer to previously bound names. That means the let can be simplified to just the let-bound expression, and each reference just needs to refer to its name, rather than "first of input stream of blah".
I don't think this is resulting in worse end-result code right now, but it might be making flatten and melt a bit slower.

This is a bit more effort than I thought because the tupled version is still used by (latest x ~> fold f) (perhaps other things?).
In latest x ~> fold f, we store the whole tuple of everything that is in scope in the buffer, and then fold over it at the end.
We will need to modify latest to only store a tuple of what's actually used.
This is totally doable but I suspect there are lower-hanging fruit.


[question] Race condition in shader object layer?

In UpdateDrawState CommandBufferData& data is guaranteed to be externally-synchronized and it owns the FullDrawStateData *state_data.
What worries me is that Shader *vertex_or_mesh_shader taken from state_data->GetShader(...) is not and Shader::pipelines does not use mutexes. I haven't found anything that makes accesses to different Shaders synchronized.
So is it a race condition or is access to VkShaderEXT (being bound to a command buffer) externally-synchronized or something else?
https://github.com/KhronosGroup/Vulkan-ExtensionLayer/blob/ace98ffe07ac03d671e7e99a6035221a20c990f1/layers/shader_object.cpp#L2436-L2442

You are correct, this is a bug. Thank you for reporting the issue

There's still a problem.
If a pipeline was created in another thread during locking of data for writing, that pipeline should be bound, but in current implementation VK_NULL_HANDLE is bound.
https://github.com/KhronosGroup/Vulkan-ExtensionLayer/blob/628236719fb3760036275580222a521cb819cb76/layers/shader_object.cpp#L2488-L2498

Reopening because @qbojj wrote the following:
There's still a problem.
If a pipeline was created in another thread during locking of data for writing, that pipeline should be bound, but in current implementation VK_NULL_HANDLE is bound.
https://github.com/KhronosGroup/Vulkan-ExtensionLayer/blob/628236719fb3760036275580222a521cb819cb76/layers/shader_object.cpp#L2488-L2498

nevermind, the new problem is now in #282


User profile

Fixes # .
Changes proposed in this pull request:

Same commits as in https://github.com/tenhobi/flashcards/pull/133


Add retry logic for image pulls from registry.svc.ci.openshift.org

Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>/cc @bparees

All CI jobs are breaking on a done keyword.  This seems like a likely culprit.  Who knows how to revert these changes and have them take effect?


Guide for translation workflow

I'd to copy that.
I began translating ftc into German yesterday, I'm stuck with the workflow here, tried to email to<EMAIL_ADDRESS>with no success and would at least like to provide you the litte 1% done so far.
Originally posted by @drlbln in https://github.com/flattenthecurve/guide/issues/12#issuecomment-599141350

First cut here: https://github.com/flattenthecurve/guide/wiki/Content-translation


[QUESTION] Is there a way to disable settings menu as a whole in dashboard?

Question
There are appConfig boolean values like disableConfiguration which disables user from changing config. Wondering if there is a way to disable settings menu as a whole in dashboard UI. Tried hideSettings in appConfig and that doesn't work either.
Basically this would avoid changing things in UI. I wanted to keep things strictly changeable via conf.yml file.
Thanks.
Category
Configuration
Please tick the boxes

[X] You are using a supported version of Dashy (check the first two digits of the version number)
[X] You've checked that this question hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Hey @scribblepad - the best way to properly achieve this would be to make the conf.yml read-only. In Docker, that can be done with the readonly option. This would prevent any changes being able to be written.
Use that alongside appConfig.disableConfiguration: true, and the user won't be able to access any settings, beyond local only options (language and theme)

We should reopen this, beacause it can not be disabled from code neither, unfortunately.

Should work if you set disableConfiguration: true under appConfig

Hi everyone! @Lissy93, I really like this project, looks very nice and inspiring! I agree with the author of Issue, it would be helpfull to be able to disable any configuration at all, including theme, color, layout, and view settings.
disableConfiguration: true allows to hide the bar and prevents from changing the sections and items, but not prevents from changing layout, view type, e.t.c.

Hi @Lissy93,
I agree with @maks2199 about the Settings panel. Even when I set appConfig.disableConfiguration: true and appConfig.hideComponents.hideSettings: true, other users can still go to the dashboard, toggle open the Settings Menu and edit Themes, Layout, Item Size. They can even view the content of config file in Config > Update Configuration > Click conf.yml in Using config from /conf.yml

We need an option to completely disable the toggling of Setting Menu, so that user opening the page can only click into the items

Hi,
As @maks2199 and @Trungtin1011 i truely love dashy !
It may/will be amazing if we had the option directly on the app to disable editing (or protect it with a password) !
Looking forward to have new on this feature 🚀


Make ConnectionConfig#autoCommit configurable via fake pragma

Problem
I am using Kotlin's SQL Framework https://github.com/JetBrains/Exposed with sqlite-jdbc.
import org.jetbrains.exposed.sql.Database
import org.jetbrains.exposed.sql.transactions.transaction
(snip)

val sqLiteConfig = SQLiteConfig()
val ds = SQLiteDataSource(sqLiteConfig)
val database = Database.connect(ds)

import org.jetbrains.exposed.sql.transactions.transaction
import org.sqlite.SQLiteErrorCode
import org.sqlite.SQLiteException
import java.time.temporal.Temporal

transaction(db) {
  connection.autoCommit = false
  // do something with DB
}

I want to disable auto-commit for better performance, but it appears that it is not configurable via SQLiteConfig nor SQLiteDataSource.
SQLiteConnectionConfig offers setAutoCommit, but SQLiteConfig#defaultConnectionConfig always use autoCommit = true.
https://github.com/xerial/sqlite-jdbc/blob/263c296f0057b1de9d758fbdef5ccfd2762add26/src/main/java/org/sqlite/SQLiteConnectionConfig.java#L21
One can specify connection.autoCommit = false in transaction { ... } DSL, but it is error-prone because one might forget.
Proposal
This PR adds "fake" pragma jdbc.auto_commit, so auto-commit can be configurable via SQLiteConfig.
val prop = new Properties()
prop.setProperty(SQLiteConfig.Pragma.JDBC_AUTO_COMMIT.pragmaName, "true")
val sqLiteConfig = SQLiteConfig(prop)
val ds = SQLiteDataSource(sqLiteConfig)
val database = Database.connect(ds)

It seems JDBC expects the default to always be true, according to https://stackoverflow.com/a/11022406
It would probably make sense for the exposed framework to allow for such option so that new connections are always set to false.

I agree autoCommit = true should be the default.
This PR allows users to configure autoCommit so they can use this driver for any framework in autoCommit = false mode.

Please take a look.


automatic nixpkgs update

Automated changes by create-pull-request GitHub action

broken still because of hash mismatch between mac and linux.


Revamp xcframework generation to avoid conflicts with other Rust libraries

Hopefully the move to a documented shell script makes all the whacky things we have to do for the iOS generation a bit clearer.

Codecov Report
Patch coverage has no change and project coverage change: -0.23 :warning:

Comparison is base (69e0e48) 90.17% compared to head (1486d5f) 89.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   90.17%   89.94%   -0.23%
==========================================
  Files         113       83      -30
  Lines       16120    14678    -1442
  Branches      565        0     -565
==========================================
- Hits        14536    13202    -1334
+ Misses       1563     1476      -87
+ Partials       21        0      -21

Flag
Coverage Δ

uitests
?

uitests-ios
?

unittests
89.94% <ø> (+0.87%)
:arrow_up:

unittests-ios
?

unittests-rust
89.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Set version at develop-SNAPSHOT.

Simplified versions such that versions are only SNAPSHOT or non-SNAPSHOT (no more beta).  Eliminated gateway.distribution.version by having the manifest set in gateway.server and picked up from gateway.service.update.check (This may eventually be better off in gateway.service.update.check all together).

One of 2 Travis builds failed.  The failed test intermittently fails and is already assigned to @krismcqueen


Fix comment

From looking at code, I believe this comment was incorrect (or outdated). It seems that Ts are stored in reverse order.

@bors r+

:pushpin: Commit 925e22085ded3d85d50e00e8a22e0eb78f4f1c25 has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 925e22085ded3d85d50e00e8a22e0eb78f4f1c25 with merge ac00a0bbef46f02f555e235f57ce263aefa361e0...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing ac00a0bbef46f02f555e235f57ce263aefa361e0 to master...


Replace Tce class

This is a proposal for a new TCE class. It adds small modifications to a standard python dictionary. It ensures that certain quantities (period, depth, duration etc.) are astropy Quantities, and refuses to accept efforts to set their values to non-Quantities (e.g floats).
It also adds a method get_model() which returns a model transit in the requested time system (e.g bkjd, bjd etc.).

I am going to turn this into a draft PR. When you think it is truly ready for review, you can remove the draft status and ping us again. 😄

Modulo pep8 details, this PR is ready for review. The Tce is a standalone data class, while model generation has been separated off into models.py


add knowledge of DeepFM

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: AqourAreA:x: ZhangHandi:x: chajchaj:x: Blang233You have signed the CLA already but the status is still pending? Let us recheck it.


Message hub service goes down everyday

Iam using message hub service for a project.Iam running in to an issue that message hub service goes down everyday and the app needs to be started everyday.How can I handle this.
Unable to consume topic: Error: Request returned status code 502 but it was not in the accepted list.
2016-10-20T10:32:13.768+0530[App/0]OUTgot error: { [Error: Request returned status code 502 but it was not in the accepted list. ] statusCode: 502 }
Can someone help if they are using messagehub for production and how they are handling this kind of thing.

Hi @harishvarma8055,
Yes the REST API is restarted everyday as stated in our documentation under "Known restrictions": https://console.ng.bluemix.net/docs/services/MessageHub/ts_overview.html#messagehub057
We don't recommend using the REST API for production usages but instead only as a way to get started quickly. If you want to use Message Hub with Nodejs, I'd suggest you to check: https://github.com/Blizzard/node-rdkafka
We are currently building a sample application with this client and it should be published within the next couple of weeks.


FontAwesome outdated

In the footer, the Google+ logo is outdated.

Err, we're using an old version of FontAwesome. Newest is https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css


Android-Kotlin : 09.24 Expandable ListView in Android (Kotlin) #1455

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # <issue_number_here>

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[x] Android Dev (Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[ ] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Please make a separate branch from our domain branch, make commit there, I cant review so many file changes if you make a new branch from main branch

@sirilalithaadapa please close this PR. As you send another PR.