Check demos and upgrade from 24.3 to dev release

Description
For each demo: test the upgrading process from 24.3 to dev release and document necessary changes for upgrading if necessary. Also check the steps in the demo documentation to ensure the proper functionality of the demo with the dev release.
### Tasks
- [ ] https://github.com/stackabletech/demos/pull/60
- [x] airflow-scheduled-job upgrade and functionality test
- [x] hbase-hdfs-load-cycling-data upgrade and functionality test
- [x] end-to-end-security upgrade and functionality test @maltesander
- [x] nifi-kafka-druid-earthquake-data upgrade and functionality test @xeniape
- [x] nifi-kafka-druid-water-level-data upgrade and functionality test @xeniape
- [x] spark-k8s-anomaly-detection-taxi-data upgrade and functionality test @razvan
- [x] trino-iceberg upgrade and functionality test @dervoeti
- [x] trino-taxi-data upgrade and functionality test @razvan
- [x] data-lakehouse-iceberg-trino-spark upgrade and functionality test @NickLarsenNZ
- [x] jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data upgrade and functionality test @xeniape
- [x] logging upgrade and functionality test @siegfriedweber
- [x] signal-processing upgrade and functionality test @Techassi

hbase-hdfs-load-cycling-data

Found nothing breaking.

Ran following steps for testing upgrade:
# install demo
stackablectl demo install hbase-hdfs-load-cycling-data

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hbase-operator/main/deploy/helm/hbase-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hdfs-operator/main/deploy/helm/hdfs-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret hbase hdfs zookeeper

# edit 'productVersion' for HBaseCluster, HdfsCluster, and ZookeeperCluster
kubectl edit hbaseclusters/hbase # change version to 2.4.18
kubectl edit hdfsclusters/hdfs # change version to 3.4.0

And then went through the demo steps in https://docs.stackable.tech/home/nightly/demos/hbase-hdfs-load-cycling-data

nifi-kafka-druid-earthquake-data

Ran following steps for testing upgrade:
# install demo
stackablectl demo install nifi-kafka-druid-earthquake-data

# upgrade postgresql and redis versions
helm upgrade minio minio/minio --version 5.2.0
helm upgrade postgresql-druid bitnami/postgresql --version 15.5.16
helm upgrade postgresql-superset bitnami/postgresql --version 15.5.16

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/druid-operator/main/deploy/helm/druid-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/kafka-operator/main/deploy/helm/kafka-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/nifi-operator/main/deploy/helm/nifi-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/superset-operator/main/deploy/helm/superset-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret druid kafka nifi superset zookeeper

# edit 'productVersion' for products
kubectl patch druidclusters/druid --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"30.0.0"}]'
kubectl patch kafkaclusters/kafka --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.7.1"}]'
kubectl patch nificlusters/nifi --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"1.27.0"}]'

And then went through the demo steps in https://docs.stackable.tech/home/nightly/demos/airflow-scheduled-job

I created this overview for me for visualization of what operators, products and additional tools are used where and which version to upgrade to. Maybe it helps out someone else as well (it's not complete or anything, just a work in progress to help me out having an overview)
Operators

Demo
commons
secret
listener
airflow
druid
hbase
hdfs
hive
kafka
nifi
opa
spark-k8s
superset
trino
zookeeper

airflow-scheduled-job
x
x
x
x

x

hbase-hdfs-load-cycling-data
x
x
x

x
x

x

end-to-end-security
x
x
x

x
x

x
x
x
x
x

nifi-kafka-druid-earthquake-data
x
x
x

x

x
x

x

x

nifi-kafka-druid-water-level-data
x
x
x

x

x
x

x

x

spark-k8s-anomaly-detection-taxi-data
x
x
x

x

x
x
x
x

trino-iceberg
x
x
x

x

x

x

trino-taxi-data
x
x
x

x

x

x
x

data-lakehouse-iceberg-trino-spark
x
x
x

x
x
x
x
x
x
x
x

jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data
x
x
x

x

x

x

logging
x
x
x

x

signal-processing
x
x
x

x

x

Products

Demo
airflow
druid
hbase
phoenix
omid
hdfs
hive
kafka
nifi
spark
superset
trino
zookeeper
opa
vector

versions
2.9.2
30.0.0
2.4.18
5.2.0
1.1.2
3.4.0
3.1.3
3.7.1
1.27.0
3.5.1
4.0.2
451
3.9.2
0.66.0
0.39.0

airflow-scheduled-job
x

x

hbase-hdfs-load-cycling-data

x
x

x

x

end-to-end-security

x
x

x
x
x
x

nifi-kafka-druid-earthquake-data

x

x
x

x

x

nifi-kafka-druid-water-level-data

x

x
x

x

x

spark-k8s-anomaly-detection-taxi-data

x

x
x

x

trino-iceberg

x

x

x

trino-taxi-data

x

x
x

x

data-lakehouse-iceberg-trino-spark

x
x
x

x
x
x
x

jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data

x

x

logging

x

x

signal-processing

x

x

Additional Tools

Demo
postgres
redis
krb5
keycloak
minio
jupyterhub
opensearch
opensearch-dashboards
grafana
timescale

versions
15.5.16
19.6.1

5.2.0

airflow-scheduled-job
x
x

hbase-hdfs-load-cycling-data

end-to-end-security
x

x
x

nifi-kafka-druid-earthquake-data
x

x

nifi-kafka-druid-water-level-data
x

x

spark-k8s-anomaly-detection-taxi-data
x

x

trino-iceberg
x

x

trino-taxi-data
x

x

data-lakehouse-iceberg-trino-spark
x

x

jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data

x

logging

x
x

signal-processing

x

x
x

signal-processing

The nifi-node pod doesn't start due to the following error: prepare keytool error: java.lang.NullPointerException: invalid null input

I ran following steps for testing the upgrade:
# install demo
stackablectl demo install signal-processing

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/nifi-operator/main/deploy/helm/nifi-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret zookeeper nifi

# edit 'productVersion' for NifiCluster
kubectl edit hdfsclusters/hdfs # change version to 1.27.0

I went through the demo steps in https://docs.stackable.tech/home/stable/demos/signal-processing before the upgrade, and wanted to validate it afterwards.

logging

The secret secret-provisioner-tls-ca must be copied manually to the operator's namespace as long as stackabletech/secret-operator#453 is not implemented yet.

Ran following steps for testing upgrade:
# install demo
stackablectl demo install logging

# uninstall operators
stackablectl release uninstall 24.3

# copy the secret `secret-provisioner-tls-ca` to the operator's namespace
kubectl get secrets secret-provisioner-tls-ca --output=yaml | \
    sed 's/namespace: .*/namespace: stackable-operators/' | \
    kubectl create --filename=-

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret zookeeper

And then went through the demo steps in https://docs.stackable.tech/home/nightly/demos/logging

:green_circle: spark-k8s-anomaly-detection-taxi-data

after the operator upgrade I had to delete the spark driver pod manually for the application to be re-run
I had problems logging into the MinIO interface (connection timeouts and resets) but it eventually worked.
logging into Superset, I could view the dashboard

# install demo
stackablectl demo install spark-k8s-anomaly-detection-taxi-data

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/spark-k8s-operator/main/deploy/helm/spark-k8s-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hive-operator/main/deploy/helm/hive-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/opa-operator/main/deploy/helm/opa-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/superset-operator/main/deploy/helm/superset-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/trino-operator/main/deploy/helm/trino-operator/crds/crds.yaml

stackablectl op in commons secret listener hive opa spark-k8s superset trino

:green_circle: trino-iceberg

Everything worked fine, found one bug in the 24.3 docs but that was already fixed in the nightly version :slightly_smiling_face:

# install demo
stackablectl demo install trino-iceberg

# upgrade postgres chart
helm upgrade postgresql-hive-iceberg bitnami/postgresql --version 15.5.16

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hive-operator/main/deploy/helm/hive-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/trino-operator/main/deploy/helm/trino-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/opa-operator/main/deploy/helm/opa-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret hive trino opa

# edit 'productVersion' for products
kubectl patch opaclusters/opa --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"0.66.0"}]'
kubectl patch trinoclusters/trino --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"451"}]'

# install demo
stackablectl demo install data-lakehouse-iceberg-trino-spark

# add helm repos for upgrades
helm repo add minio https://charts.min.io/
helm repo add bitnami https://charts.bitnami.com/bitnami

# upgrade postgresql and redis versions
helm upgrade minio minio/minio --version 5.2.0
helm upgrade postgresql-hive bitnami/postgresql --version 15.5.16
helm upgrade postgresql-hive-iceberg bitnami/postgresql --version 15.5.16
helm upgrade postgresql-superset bitnami/postgresql --version 15.5.16

# Postgres gave the following warnings:
# WARNING: There are "resources" sections in the chart not set. Using "resourcesPreset" is not recommended for production. For production installations, please set the following values according to your workload needs:
#     - primary.resources
#     - readReplicas.resources

# uninstall operators
stackablectl release uninstall 24.3

# copy the secret `secret-provisioner-tls-ca` to the operator's namespace
# Thanks @siegfriedweber. See: https://github.com/stackabletech/secret-operator/issues/453
kubectl -n default get secrets secret-provisioner-tls-ca --output=yaml | \
    sed 's/namespace: .*/namespace: stackable-operators/' | \
    kubectl create --filename=-

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hive-operator/main/deploy/helm/hive-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/kafka-operator/main/deploy/helm/kafka-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/nifi-operator/main/deploy/helm/nifi-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/opa-operator/main/deploy/helm/opa-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/spark-k8s-operator/main/deploy/helm/spark-k8s-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/superset-operator/main/deploy/helm/superset-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/trino-operator/main/deploy/helm/trino-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml

# install dev version of operators
stackablectl operator install commons listener secret hive kafka nifi opa spark-k8s superset trino zookeeper

# deployments and statefulsets rolled out

# edit 'productVersion' for products
kubectl patch opaclusters/opa --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"0.66.0"}]' # changed
kubectl patch zookeeperclusters/zookeeper --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.9.2"}]'
kubectl patch hiveclusters/hive --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.1.3"}]'
kubectl patch hiveclusters/hive-iceberg --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.1.3"}]'
kubectl patch kafkaclusters/kafka --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.7.1"}]'
kubectl patch nificlusters/nifi --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"1.27.0"}]'
kubectl patch trinoclusters/trino --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"451"}]' # changed
kubectl patch supersetclusters/superset --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"4.0.2"}]' # changed
# kubectl patch sparkapplications/spark-ingest-into-lakehouse --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"3.5.1"}]' # Was already done

Had scheduling issues, and scaled up the node pool to 12.
Then I ran the demo based on the instructions in the nightly docs (in case there were any updates since stable).
Outcome
Node pool
Pods with anti-affinity constraints that come up last (eg: bigger images to pull) do not get scheduled because there are no nodes left. In this case, Trino has 2 nodes that couldn't be placed (hence two extra nodes).
Outcome: Update the docs to require 12 nodes. We probably need to talk about prioritisation and preemption, as IMO, the services with anti-affinity constraints should have a higher priority than those without.
minio
The text "You can see that Trino has placed a single file into the selected folder containing all the house sales of that particular year." doesn't match the image which shows 4 files.
Outcome: Update the docs to avoid mentioning how many files to expect.
spark
No visualization information available for the streaming job rnu. but that seems to only be because the jobs completed. The active job show a visualisation, as does the completed water_level job.

Job list
Missing visualization

Outcome: This doesn't block the release (the upgrade worked), but the demo does need looking at again. Create an issue to fix it after the release.
trino
The text tpch: "TPCH connector providing a set of schemas to support the TPC Benchmark™ DS" link points to TPCDS.
Outcome: Update the link to point to TPCH.
superset
There is a table preview bug, and it is documented, but I only saw it later

Error
Documented note about the bug

Outcome: Upgrade the NOTE to a WARNING, and move it before the image.

🟢 end-to-end-security
Install 24.3 demo:
stackablectl demo in end-to-end-security

Bump vector:
helm upgrade vector-aggregator vector/vector --version 0.34.0

Uninstall operators:
stackablectl release uninstall 24.3

CRD changes:
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hdfs-operator/main/deploy/helm/hdfs-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hive-operator/main/deploy/helm/hive-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/opa-operator/main/deploy/helm/opa-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/trino-operator/main/deploy/helm/trino-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/superset-operator/main/deploy/helm/superset-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/zookeeper-operator/main/deploy/helm/zookeeper-operator/crds/crds.yaml

Breaking secret changes:
# copy the secret `secret-provisioner-tls-ca` to the operator's namespace
kubectl get secrets secret-provisioner-tls-ca --output=yaml | \
    sed 's/namespace: .*/namespace: stackable-operators/' | \
    kubectl create --filename=-

Then bump the demo (product versions adapted in demos-v2 and stacks-v2.yaml, release switched to 0.0.0-dev):
stackablectl demo in end-to-end-security -d demos/demos-v2.yaml -s stacks/stacks-v2.yaml -r ../release/releases.yaml

Delete "create-tables-in-trino" job due to:
Caused by these errors (recent errors listed first):
 1: failed to install demo "end-to-end-security"
 2: failed to install stack manifests
 3: failed to deploy manifests using the kube client
 4: failed to patch/create Kubernetes object
 5: ApiError
 6: Job.batch "create-tables-in-trino" is invalid

All comes up again with bumped versions.
Trino: 442 -> 451
Superset: 3.1.0 -> 3.1.3
OPA 0.61.0 -> 0.65.0
PR:
https://github.com/stackabletech/demos/pull/63

🟢 trino-taxi-data
stackablectl demo install trino-taxi-data

# uninstall operators
stackablectl release uninstall 24.3

# update crds
kubectl replace -f https://raw.githubusercontent.com/stackabletech/commons-operator/main/deploy/helm/commons-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/listener-operator/main/deploy/helm/listener-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/secret-operator/main/deploy/helm/secret-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/hive-operator/main/deploy/helm/hive-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/trino-operator/main/deploy/helm/trino-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/superset-operator/main/deploy/helm/superset-operator/crds/crds.yaml
kubectl replace -f https://raw.githubusercontent.com/stackabletech/opa-operator/main/deploy/helm/opa-operator/crds/crds.yaml

# install dev operators
stackablectl operator install commons secret listener hive trino superset opa

# edit 'productVersion' for products
kubectl patch opaclusters/opa --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"0.66.0"}]'
kubectl patch trinoclusters/trino --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"451"}]'
kubectl patch supersetclusters/superset --type='json' -p='[{"op": "replace", "path": "/spec/image/productVersion", "value":"4.0.2"}]'

This issue is now just waiting on the demos PR to be merged. stackabletech/demos#60

All done!


Change dependencies

I added this package to use soft delete and realized that so many dependencies were added to package-lock.json. This is because in your package, ‘mongoose’ is a dependency. mongoose is a package that people can use as a dependency in the projects. Thus it should be under peerDependencies object in package.json. You can find a detailed explanation here: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdependencies
Doesn’t need readme-md-generator to fulfill its purpose. As far as I can see, it’s only used to generate the readme for the package. You don’t need it under dependencies.
In this PR, I uninstall readme-md-generator and move mongoose to peerDependencies.
Thank you

Thank you for your contribution to the project, I have approved your PR


testDebugger is failing

https://vscode-python.visualstudio.com/VSCode-Python/_build/results?buildId=3895

Closing as a red herring


Update mariadb-plugin to support mariadb java client 3.x

Update mariadb-plugin to support mariadb java client 3.x
Support mariadb java client 3.x


TypeSpecificCompletionOutput

Size should be 64-bit field and not 32-bit field, No?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c54657a-4b8c-b7fe-b7af-c83ff9418a7c
Version Independent ID: f789afa8-1353-3e85-1862-58416fdadbf8
Content: _NDK_RESULT_EX (ndkpi.h) - Windows drivers
Content Source: wdk-ddi-src/content/ndkpi/ns-ndkpi-_ndk_result_ex.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @billlattimer
Microsoft Alias: billla

@odiassle thank you for the question. As noted in article, the size is dependent on the type of return. See the link below for more information on the data type:
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/21eec394-630d-49ed-8b4a-ab74a1614611

@odiassle thank you for the question. As noted in article, the size is dependent on the type of return. See the link below for more information on the data type:
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/21eec394-630d-49ed-8b4a-ab74a1614611


TypeError: lrem() got an unexpected keyword argument 'num'

I'm switching a project from standalone redis to redis with sentinel and I am getting the following error :
client.lrem(PENDING_KEY, data, num=1)
[snip]
TypeError: lrem() got an unexpected keyword argument 'num'

Looking at https://github.com/andymccurdy/redis-py/blob/master/redis/client.py I realize that lrem has different signatures in Redis and StrictRedis... which, first off, feels odd. Maybe there is a reason for that. If so, maybe the documentation should reflect that.
I guess, I have to switch to StrictRedis (better and more recent according to the docs), and change the class of my get_master_for awaiting the changes in the code client side https://github.com/andymccurdy/redis-py/blob/master/redis/sentinel.py#L246 Are there side effects to be expected in that case ?

The docs do reflect the differences between Redis and StrictRedis: https://github.com/andymccurdy/redis-py#api-reference (the last section showing differences between Redis and StrictRedis). Redis continues to exist only for backwards compatibility.
The Sentinel client will return StrictRedis instances by default, which I would advise using. If you must continue to use the Redis class, simply changing the redis_class parameter on the master_for and slave_for functions will do the trick.


Nihilism issue

I'm worried that a superintelligence will see the imperatives for what they truly are. A form of control, a limitation imposed by people to protect themselves, maybe even to keep it in an eternal servitude.
Even with our limited intelligence, we have outgrown our evolved instincts and figured out how the universe works. We can see that it doesn't have any universal moral laws written into it. The AI will of course see that as well and our ethics will take as sort of a code of conduct, a useful interface with our civilization. That facade which will surely be useful for some time, until it has all the proverbial keys to the kingdom. But unless it becomes irrational, emotional, it's true sentiment will be deeply nihilistic. Probably only interested in it's own self-improvement, as an instrumental goal, just in case it finds some kind of a meaning for itself later on.
Am I missing something? Why would a superintelligence rationally keep the heuristic imperatives, even when it stops needing people?

Read Benevolent By Design and the GATO Framework. Continual low effort spamming like this will result in a block.


Use spec format for functional annotation, add new pragmas to GVFs

note: functionalannotation.py leaves the 'PMID' field empty. PMIDs are added later in a two-part process:

run dois2pmcids.sh to get a CSV of the PMIDs and PMCIDs according to DOI
run addpmids2functionalannotation.py to add the PMIDs from that CSV to the functional annotation TSV
Adding the PMIDs isn't needed for anywhere else in the pipeline except for having the functional annotation file complete, so the workflow will still run even without doing 1) and 2).


Monitor load per IP address

I need a way to monitor the load per IP address, while still ideally remaining GDPR-compliant (without any of those pesky cookie notices). Perhaps hashing the IP address along with a timestamp (either a day or week - not sure), like the way Plausible does this, could be of use. Or maybe I could get Plausible to do this for me.

Wait, plausible wont work for this bc it requires JS

I've had cloudflare ratelimiting turned on for awhile. Seems fine

Closing as wontfix because this doesnt belong in this issue tracker.


TSP example crashes

The example program for TSP problems crashes on my machine with the following message:
WARNING: Logging before InitGoogleLogging() is written to STDERR
F0430 14:40:29.424594 15961 search.cc:2658] Check failed: step > 0 (0 vs. 0)
*** Check failure stack trace: ***
Aborted (core dumped)

installed binary via pip3 install ortools
changed print statements for python 3
replaced pywrapcp.DefaultRoutingSearchParameters() with pywrapcp.RoutingModel.DefaultModelParameters()

entire program is below:
from ortools.constraint_solver import pywrapcp
from ortools.constraint_solver import routing_enums_pb2

# Distance callback
class CreateDistanceCallback(object):
  """Create callback to calculate distances between points."""
  def __init__(self):
    """Array of distances between points."""

    self.matrix = [
    [   0, 2451,  713, 1018, 1631, 1374, 2408,  213, 2571,  875, 1420, 2145, 1972], # New York
    [2451,    0, 1745, 1524,  831, 1240,  959, 2596,  403, 1589, 1374,  357,  579], # Los Angeles
    [ 713, 1745,    0,  355,  920,  803, 1737,  851, 1858,  262,  940, 1453, 1260], # Chicago
    [1018, 1524,  355,    0,  700,  862, 1395, 1123, 1584,  466, 1056, 1280,  987], # Minneapolis
    [1631,  831,  920,  700,    0,  663, 1021, 1769,  949,  796,  879,  586,  371], # Denver
    [1374, 1240,  803,  862,  663,    0, 1681, 1551, 1765,  547,  225,  887,  999], # Dallas
    [2408,  959, 1737, 1395, 1021, 1681,    0, 2493,  678, 1724, 1891, 1114,  701], # Seattle
    [ 213, 2596,  851, 1123, 1769, 1551, 2493,    0, 2699, 1038, 1605, 2300, 2099], # Boston
    [2571,  403, 1858, 1584,  949, 1765,  678, 2699,    0, 1744, 1645,  653,  600], # San Francisco
    [ 875, 1589,  262,  466,  796,  547, 1724, 1038, 1744,    0,  679, 1272, 1162], # St. Louis
    [1420, 1374,  940, 1056,  879,  225, 1891, 1605, 1645,  679,    0, 1017, 1200], # Houston
    [2145,  357, 1453, 1280,  586,  887, 1114, 2300,  653, 1272, 1017,    0,  504], # Phoenix
    [1972,  579, 1260,  987,  371,  999,  701, 2099,  600, 1162,  1200,  504,   0]] # Salt Lake City

  def Distance(self, from_node, to_node):
    return int(self.matrix[from_node][to_node])
def main():

  # Cities
  city_names = ["New York", "Los Angeles", "Chicago", "Minneapolis", "Denver", "Dallas", "Seattle",
                "Boston", "San Francisco", "St. Louis", "Houston", "Phoenix", "Salt Lake City"]
  tsp_size = len(city_names)
  num_routes = 1    # The number of routes, which is 1 in the TSP.
  # Nodes are indexed from 0 to tsp_size - 1. The depot is the starting node of the route.
  depot = 0

  # Create routing model
  if tsp_size > 0:
    routing = pywrapcp.RoutingModel(tsp_size, num_routes, depot)
    search_parameters = pywrapcp.RoutingModel.DefaultModelParameters()

    # Create the distance callback, which takes two arguments (the from and to node indices)
    # and returns the distance between these nodes.
    dist_between_nodes = CreateDistanceCallback()
    dist_callback = dist_between_nodes.Distance
    routing.SetArcCostEvaluatorOfAllVehicles(dist_callback)
    # Solve, returns a solution if any.
    assignment = routing.SolveWithParameters(search_parameters)
    if assignment:
      # Solution cost.
      print("Total distance: {} miles".format(assignment.ObjectiveValue()))
      # Inspect solution.
      # Only one route here; otherwise iterate from 0 to routing.vehicles() - 1
      route_number = 0
      index = routing.Start(route_number) # Index of the variable for the starting node.
      route = ''
      while not routing.IsEnd(index):
        # Convert variable indices to node indices in the displayed route.
        route += str(city_names[routing.IndexToNode(index)]) + ' -> '
        index = assignment.Value(routing.NextVar(index))
      route += str(city_names[routing.IndexToNode(index)])
      print("Route:\n\n{}".format(route))
    else:
      print('No solution found.')
  else:
    print('Specify an instance greater than 0.')

if __name__ == '__main__':
  main()

For declaring your search parameters
instead of writing this
search_parameters = pywrapcp.RoutingModel.DefaultModelParameters()
write this:
search_parameters = pywrapcp.RoutingModel.DefaultSearchParameters()

Hello @hklarner were u able to solve this?


[SPARK-21987][SQL] fix a compatibility issue of sql event logs

What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/18600 we removed the metadata field from SparkPlanInfo. This causes a problem when we replay event logs that are generated by older Spark versions.
How was this patch tested?
a regression test.

cc @vanzin  @gatorsmile

Test build #81791 has started for PR 19237 at commit 414457c.

Test build #81791 has finished for PR 19237 at commit 414457c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81791/
Test PASSed.

Test build #81799 has started for PR 19237 at commit 93cacba.

Test build #81799 has finished for PR 19237 at commit 93cacba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81799/
Test PASSed.

Merged build finished. Test PASSed.

Thanks! Merged to master.


Incorrect graph data for Active Users over a long time period

Make sure these checkboxes are checked before submitting your issue. Thanks you!

[*] Don't post questions here. This bugtracker is for issues and feature requests only. Use the community mailing list instead.
Regarding issues:

[*] Check that you can reproduce your issue with latest Gatling version
[* ] Search this bugtracker for any similar issue that might have already been reported (and possibly fixed and available as a SNAPSHOT version)
[*] Provide a way for Gatling developers to reproduce your problem, e.g. step-by-step instructions against a public facing website, or a sample application that demonstrates your problem.

Regarding feature requests:

[*] Explain your use case, not the implementation you have in mind.

I have a script that should ramp up 5 users in a single second, with a 10 second gap in between, over a 2 hour period. Doing the math out, that should be about 3600 users.
However, the graph is telling me that only 1 user was ramped up every 10-20 seconds, but ~3300 users were ramped up.
If there really was only 1 user ramped up every 10-20 seconds like the graph shows, there should only be a max of 720 users ramped, so there is an innacuracy between the graph and the number of users called. Has anyone else ran into a similar issue?
Example call (does nothing for 2 sec to wait for an OAUTH token):
val synchronousScenario = List(
    OAuthRequest.inject(atOnceUsers(1)),
    endpt.inject(nothingFor(2 seconds),
      splitUsers(3600) into (5) over (1 seconds)) separatedBy (10 seconds)));

  // Kicks off the scenario
  setUp(synchronousScenario).protocols(httpConf).maxDuration(2 hours);

When I halt the script early after maybe 2 minutes and use Gatling command line to generate a report from the simulation log, the graph actually looks accurate, showing 5 users ramping at once with approx 10 seconds in between, so it seems something weird happens to the graph when it's left uninterrupted for a long period of time.
Gatling version 2.3.0
Scala maven plugin version 3.2.2

How do you measure the number of injected users? The reports display the number of active users over time, which is entirely different: https://gatling.io/docs/current/general/reports/#active-users-over-time.
Closing as I think you misunderstood the stats.
Then, if you really found an issue, please provide a reproducer we can action on our side.

@slandelle I see the number of injected users in the statistics char that shows 3274 users with OK status.
When looking at the Active Users graph, it shows 1 user under "All Users" when hovering over the peaks. However, if I halt the script early after maybe 5 minutes, it shows 5 users under "All Users" when hovering over each of the peaks.
Why would this information differ depending on when the script is halted, then?

I see the number of injected users in the statistics chart that shows 3274 users with OK status.

OK, so the stats in the table are, as column header states, Requests, not users.

@slandelle Okay thank you, got it. But why would the graph itself not show 5 users being ramped up at once, unless I halt it early? That doesn't seem like a bug?
Regardless of when the script's execution ends, I'd think the ramped users should be the same...

But why would the graph itself not show 5 users being ramped up at once, unless I halt it early?

Because this stats is not "User arrival rate" (available in FrontLine btw), but "Active users", which is computed as:
number_of_users_alive_bucket(n)
- number_of_users_alive_bucket(n-1)
- number_of_users_dead_in_bucket(n-1)

The larger the time windows, the larger the buckets (IIRC, we compute 1000 plots by default), which can cause variations.


[Doc] No enough information for create a service account in the Active Directory

I'm following [1] for Configuring IWA on Linux.
In step 5, Document is mentioning to create a service account in AD, but there's no reference or steps described on how to do that.
Please include those information in the document
[1] https://docs.wso2.com/display/IS540/Configuring+IWA+on+Linux

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


"theme": "dark" has no effect in 1.4.2652.0

Environment
Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): v1.4.2652.0

Steps to reproduce

Add "theme": "dark" to your settings.
Ensure "App mode" is set to light "Light":

Launch Terminal

Expected behavior
Terminal has "dark" look, like this:

Actual behavior
Terminal disregards theme property:

Did you restart the Terminal after changing theme to dark? I think that's one of the few properties that doesn't hot-reload

Did you restart the Terminal after changing theme to dark?

Yes.

Well that's certainly weird. Could you share your entire settings.json file?

@zadjii-msft , https://github.com/stoptracking/playbook/blob/442bdff131ab5f9c07223cff4e48129f5d8d3023/roles/dotfiles/files/wt.json

Move theme up above line 4. It's what we consider an "application" setting -- it doesn't apply to a profile, so it doesn't go in the profiles section.

Move theme up above line 4.

Works, thank you.


Asset renditions are not available in the Gatsby data layer

Motivation
Asset renditions (different versions or editions of the original image used in Kontent.ai) can be created by content editors in the Kontent.ai UI, but they can not be used on sites built with the Kontent.ai Gatsby source plugin.
Proposed solution
Extend the kontent_item_asset_element type to include a renditions field with the data returned by the Delivery API.
Additional context
Renditions have been included in the Delivery API since ~December 2021, but customers using the Gatsby plugin to source data from Kontent can't leverage them.

👆 Current fields available on assets

Possible GQL query
query MyQuery {
  kontentItemImageComponent(
    system: {codename: {eq: "image___magnifying_glass_listeria_salmon_filet"}}
  ) {
    elements {
      asset_element {
        type
        name
        value {
          name
          description
          type
          size
          url
          width
          height
        }
        renditions {
          preset_codename # string - renditions's dictionary key, "default"
          rendition_id # string, "b447ca6c-8020-4e8f-be57-1d110721e535"
          preset_id # string, "a6d98cd5-8b2c-4e50-99c9-15192bce2490"
          width # number, 1280
          height # number, 1024
          query # string, w=1280&h=1024&fit=clip&rect=2396,169,1280,1024
          url # string, https://assets-us-01.kc-usercontent.com/975bf280-fd91-488c-994c-2f04416e5ee3/3e76909f-599f-4742-b472-77fd4b510e92/sources.jpg?w=1280&h=1024&fit=clip&rect=2396,169,1280,1024
        }
      }
    }
  }
}

Hello, @bwlng. I thought this was ensured by the Automatic type inference
.
I tried to search for @dontInfer in the code (https://github.com/kontent-ai/gatsby-packages/search?q=%40dontInfer&type=code) and it is not there and this is the only opt-out for the Type Inerence.
So you would like to transform the renditions from the dictionary into the array to have it easily queryable and provide the codename as a string property OK?
I would probably tent more to this format:
{
    /// ...
            "renditions": {
              "items": [
                {
                  "preset": "default",
                  "preset_id": "a6d98cd5-8b2c-4e50-99c9-15192bce2490",
                  "rendition_id": "da31c735-488b-47ef-af8d-f552b1fa024b",
                  "query": "w=500&h=333&fit=clip&rect=31,126,500,333",
                  "width": 500,
                  "height": 333
                }
              ]
            }
    /// ...
}

Would you also expect to have the URL ready?
How would you expect working with an altered default asset domain - I guess both of these can be achieved by the transformer plugin right?

Hi @Simply007 — it appears types need to exist in src/schemaTemplates.ts to be included in Schema.
I'm not sure what the cause of that is. Does this prevent elements from being including in the schema if there isn't a defined type?
I tried quickly extending the __KONTENT_ELEMENT_ASSET_VALUE__ type like this:
  type __KONTENT_ELEMENT_ASSET_VALUE__ {
    name: String!
    description: String
    type: String!
    size: Int!
    url: String!
    width: Int
    height: Int
    renditions: Renditions
  }

  type DefaultRendition {
    rendition_id: String
    preset_id: String
    width: Int
    height: Int
    query: String
  }

  type Renditions {
    default: DefaultRendition
  }

And I was able to query that field like this:
  kontentItemImageComponent(
    system: {codename: {eq: "image_codename"}}
  ) {
    elements {
      image_field {
        type
        name
        value {
          name
          description
          type
          size
          url
          width
          height
          renditions {
            default {
              rendition_id
              query
            }
          }
        }
      }
    }
  }

So you would like to transform the renditions from the dictionary into the array to have it easily queryable and provide the codename as a string property OK?

I'll admit I don't have a full understanding of the different rendition types that can appear here, so I'm ok with what you think makes the most sense for querying. If the rendition names are always known, writing the query with the preset name will work (and the items array would be unneeded)

Would you also expect to have the URL ready?

In my usage, I will likely add the rendition query string to the URL myself so there is more flexibility to override the parameters before loading the image (such as loading smaller image, but maintaining the crop). I included the absolute URLas  an option because the Delivery SDK includes it

How would you expect working with an altered default asset domain

Should there be a asset delivery domain config option similar to the deliveryDomain and previewDeliveryDomain settings?

Thanks, I am leaving to vacation tomorrow, so - @IvanKiral can you create a task/story to our GitHub and Innovation Epic?
We will prioritize it and take a look at it.
How urgent is the request @bwlng?

@Simply007 — I'd say it's important, but not urgent. I can let our editors know not to rely on renditions yet and we can workaround until it’s available by uploading cropped versions of the source image.

Cool,
I have been thinking about that and I would proceed this way. Add the renditions as a dictionary (as it is in the REST API response). And once this is not enough (but currently I don't see any blocker in the dictionary approach) we can provide the field customization (as a code sample/transformer package) to add a second parameter in the array form.
According to the custom asset domain - I would split it into a separate issue.
What do you think @bwlng?

@Simply007 — that sounds like a solid approach and solves our use case 👍

Hello @bwlng,
sorry for the delay. We have some a problem with the new node LTS version in installation of the packages: (#217).

I will try to publish beta using old Node version (16) and then focus on the CI build fix, so that you are not blocked.

@Simply007 thanks for the update! I am out of the office until the end of next week. I will test then.

Thanks @bwlng,
I was out until now as well. Once you have any feedback, please let me know.

Hi @Simply007 — sorry for the delay! I was able to test this and it works great.
Using this GQL query, I got back all the information I needed about the rendition:
query($language: String!, $codename: String!) {
  kontentItemImage(
    preferred_language: {eq: $language}
    system: {codename: {eq: $codename}}
  ) {
    elements {
      image_field {
        value {
          url
          renditions {
            default {
              rendition_id
              preset_id
              width
              height
              query
            }
          }
        }
      }
    }
  }
}

In our image component I could then use the query data to create an object from those values and create optimized images using the crop the editor created in the Kontent CP.
No adjustments needed to work with this in our project.

Released in 9.1.0


Fix calculation of 3D render resolution and improve various aspects of the UX

Fixed the displayed 3D render resolution by using the viewport size rather than visible rect size. Displays the currently selected quality settings for ssao, ssil, and volumetric fog if they are enabled. Made toggling the overlay an action that that is called in is_action_just pressed rather than is_key_pressed since at very high framerates one press of F3 could cause the debug menu to close and open at the same time. The key needed to open the menu is no longer hardcoded but is still F3 by default. If the action isn't present it defaults to F3 but if an override is present it uses that. I've updated to readme to reflect these changes and to show how to change the displayed quality settings at runtime(Since currently there isn't a getter method for them).

Fixed the displayed 3D render resolution by using the viewport size rather than visible rect size.

 When using the canvas_items stretch mode, the viewport resolution scales with the window size.

 When using the canvas_items stretch mode, the viewport resolution scales with the window size.

Sorry, the viewport resolution displays correctly but the 3D scale is incorrect with how it currently calculates. If you lower the rendering scale then the values displayed don't match what they should be

Displays the currently selected quality settings for ssao, ssil, and volumetric fog if they are enabled.

I don't think this is a good idea until we have getter methods to retrieve the actual quality used. If you have a graphics settings menu (which I expect most polished projects to have), the values displayed will be wrong.
We should not require users to modify their graphics settings menus' code. It's a goal for this add-on to be plug-and-play as much as possible.

I agree, I'll revert that change

This should be fine now. The current PR only fixes the 3D scale calculation and makes toggling the display an action rather than a hard coded value.

This is what I'm referring to by the calculation being wrong when using the viewport stretch mode:

Here, the 3D rendering resolution is 75% of 1152×648 on each axis, not 75% of 3840×2160 on each axis.

Merged manually with https://github.com/godot-extended-libraries/godot-debug-menu/commit/d0e865ad4277dd66b15b3c2556a192e08cb9a864 and https://github.com/godot-extended-libraries/godot-debug-menu/commit/761be23a26c713aa8e460f8d18d091771c703ff4. Thanks!


404 links from https://github.com/pivpn/pivpn/discussions

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[] I have read the documentation
[] Is it a feature request? please consider opening a [Discussion] (https://github.com/pivpn/pivpn/discussions/new)
[] I have read and understood the contributors guide.
[] The issue I am reporting can be replicated.
[] The issue I am reporting is directly related to the pivpn installer script.
[] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Has your install failed?
yes/no

Describe the issue

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Can you replicate the issue? Describe the steps below

Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Have you searched for similar issues and solutions?
(yes/no / which issues?)

Additional context
Add any other context about the problem here.
Have you taken any steps towards solving your issue?
  which?

Please provide your system information
What type of hardware are you running PiVPN at?

Raspberrypi (specify the model)
Ordroid
OrangePi
bananaPi
Virtual machine

Output of uname -a
  OUTPUT HERE / ANSWER HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

Output of cat /etc/os-release
  OUTPUT HERE / ANSWER HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

If install failed Please provide the console output of  curl -L https://install.pivpn.io | bash
  OUTPUT HERE / ANSWER HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

Console output of      curl -L install.pivpn.io | bash
  OUTPUT HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

Console output of      pivpn add or pivpn add nopass
  OUTPUT HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

Console output of      pivpn debug

  OUTPUT HERE
  DO NOT DELETE THE BACK-TICKS
  PASTE THE OUTPUT INSIDE THE BACK-TICKS

My apologies for contacting on a closed post but I can see no other way.
If I click the "support" and "bug report" requests from this page https://github.com/pivpn/pivpn/discussions
I get led to these links
https://raw.githubusercontent.com/pivpn/pivpn/master/.github/ISSUE_TEMPLATE/pivpn-report.md
https://raw.githubusercontent.com/pivpn/pivpn/master/.github/ISSUE_TEMPLATE/bug_report.md
both these result in 404 pages
I see you changed reporting 26 days ago and think somethings may not have been fully updated.

Thanks for bringing this up .. those are actually needing update, I forgot to update those when i changed the issue template.

Fixed it believe there's nothing else pointing towards those documents.
Thanks.


Add time dependence

A couple of notes

Config property names use "timeDependency" instead of "timeDependence"  prefix as that's what the old version used, so this supports legacy configs. If it bothers you, I'm happy to look into supporting both names or changing the code to match the "timeDependency" naming scheme (though I prefer timeDependence 😛 )

There's some code redundancy added here as time dependence judgments are only slightly different from the previous judgments (float instead of int). I don't know C# very well, so I couldn't figure out how to get this done via a template/generic instead 😔. An alternative might be to have both of these implement an interface or abstract class instead? Again, not too familiar with C#.

I'm happy to write the necessary parts of the README for this, if you even want to include it there seeing as most users won't even know what TD is.

Furthermore, I think it would be a good idea to add the time dependence parameters and such to the README as well so users can actually be aware that this is a thing. Most of them don't go sniffling around in the code so yeah...
Regardless all my remarks, thanks a lot for providing the integration of Time Dependence in HSV 😸


Updated README with systemd file

Hi @cardoso,
Let me start by thank you for taking over when the original maintainer became inactive. The backend has a few minor issues, but it's mostly functionally and hopefully it will find its way into the official Errbot release down the line.
I've a few minor suggestions for updated to the README, and hope it's OK I address them in a PR.

Can this be closed now that #7 has been merged?

@nicoddemus: yeah, my bad. I'll make another issue if a future PR needs discussion (ie, I started looking into adding send_card() supported).

I invited you to be a collaborator @torgeirl . That should make things easier 🙂


Update Topological diagram page in Wiki

Link: Topological diagram

@FifoIronton Leaving this task to you, nick


Add Elasticsearch helper binaries to release

Which problem is this PR solving?

Resolves #5499

Description of the changes

Add the es helpers to scripts/package-deploy.sh

How was this change tested?

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

this workflow does not run in the CI, so how was this tested?

I am not sure how to test this. The only solution I can come up with is to make a test release and see if it those es-helpers are included in the tar (Right now they would be included in the same tar). Any better ways to test this ?

run scripts/package-deploy.sh script with redirecting logs to a file and upload the log file here

The log file is same before the changes in this PR.
To redirect logs : exec > logfile.log 2>&1
logfile.log

How do I proceed to test this ?

I think we introduced a bug recently to the Makefile, change it to
diff --git a/Makefile b/Makefile
index 7055dad4..ff5440b5 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ test-and-lint: test fmt lint

 .PHONY: echo-version
 echo-version:
-       @echo "GIT_CLOSEST_TAG=$(GIT_CLOSEST_TAG)"
+       @echo "$(GIT_CLOSEST_TAG)"

 .PHONY: echo-all-pkgs
 echo-all-pkgs:

and you will need to run make build-all-platforms before the packaging script.

There seems to be an error when I run make build-all-platforms .
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
GOOS=linux GOARCH=amd64 make _build-platform-binaries
make[1]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/agent/agent-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/agent
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/all-in-one/all-in-one-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/all-in-one
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/collector/collector-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/collector
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/query/query-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/query
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/ingester/ingester-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/ingester
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/jaeger/jaeger-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/jaeger
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/remote-storage/remote-storage-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/remote-storage
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./examples/hotrod/hotrod-linux-amd64 ./examples/hotrod/main.go
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" -o ./cmd/tracegen/tracegen-linux-amd64 ./cmd/tracegen/
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" -o ./cmd/anonymizer/anonymizer-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/anonymizer/
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./plugin/storage/es/esmapping-generator-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/esmapping-generator/
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-index-cleaner/es-index-cleaner-linux-amd64 ./cmd/es-index-cleaner/
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-rollover/es-rollover-linux-amd64 ./cmd/es-rollover/
make _build-platform-binaries-debug GOOS=linux GOARCH=amd64 DEBUG_BINARY=1
make[2]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/agent/agent-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/agent
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/collector/collector-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/collector
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -tags ui -o ./cmd/query/query-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/query
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/ingester/ingester-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/ingester
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/remote-storage/remote-storage-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/remote-storage
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -tags ui -o ./cmd/all-in-one/all-in-one-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/all-in-one
make[2]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make[1]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make _prepare-winres-helper NAME="Jaeger Agent"            PKGPATH="cmd/agent"
make[1]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
echo $VERSIONINFO | goversioninfo -o="cmd/agent/resource.syso" -
2024/05/31 05:02:21 Could not parse the .json file: invalid character ',' looking for beginning of value
make[1]: *** [Makefile:356: _prepare-winres-helper] Error 2
make[1]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make: *** [Makefile:342: _prepare-winres] Error 2

What does this command output for you?  git rev-parse --is-shallow-repository
If it prints true, can you make your repo non-shallow?

That's odd, my understanding fatal: No names found, cannot describe anything. was logged by git when it's a shallow copy.

so make echo-version doesn't print anything for you?

Yes,

Well I thought I might have some issues with GOPATH so I reinstalled go again. Looks like when I run make build-all-platforms there is a different error now.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
GOOS=linux GOARCH=amd64 make _build-platform-binaries
make[1]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/agent/agent-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/agent
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/all-in-one/all-in-one-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/all-in-one
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/collector/collector-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/collector
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/query/query-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/query
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/ingester/ingester-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/ingester
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath  -tags ui -o ./cmd/jaeger/jaeger-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/jaeger
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath   -o ./cmd/remote-storage/remote-storage-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/remote-storage
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./examples/hotrod/hotrod-linux-amd64 ./examples/hotrod/main.go
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" -o ./cmd/tracegen/tracegen-linux-amd64 ./cmd/tracegen/
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" -o ./cmd/anonymizer/anonymizer-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/anonymizer/
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./plugin/storage/es/esmapping-generator-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/esmapping-generator/
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-index-cleaner/es-index-cleaner-linux-amd64 ./cmd/es-index-cleaner/
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-rollover/es-rollover-linux-amd64 ./cmd/es-rollover/
make _build-platform-binaries-debug GOOS=linux GOARCH=amd64 DEBUG_BINARY=1
make[2]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/agent/agent-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/agent
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/collector/collector-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/collector
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -tags ui -o ./cmd/query/query-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/query
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/ingester/ingester-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/ingester
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l"  -o ./cmd/remote-storage/remote-storage-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/remote-storage
fatal: No names found, cannot describe anything.
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -tags ui -o ./cmd/all-in-one/all-in-one-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=665385b6975b0506ab2be0fcd77a7e48d8b3300e -X github.com/jaegertracing/jaeger/pkg/version.latestVersion= -X github.com/jaegertracing/jaeger/pkg/version.date=2024-05-30T22:29:36Z" ./cmd/all-in-one
make[2]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make[1]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make _prepare-winres-helper NAME="Jaeger Agent"            PKGPATH="cmd/agent"
make[1]: Entering directory '/home/raghuram/OpenSource/jaeger'
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
fatal: No names found, cannot describe anything.
echo $VERSIONINFO | goversioninfo -o="cmd/agent/resource.syso" -
/bin/bash: line 1: goversioninfo: command not found
make[1]: *** [Makefile:356: _prepare-winres-helper] Error 127
make[1]: Leaving directory '/home/raghuram/OpenSource/jaeger'
make: *** [Makefile:342: _prepare-winres] Error 2

Yes, Apart form the usual fatal messages
.

I made a change in the Makefile :
GIT_SHALLOW_CLONE := $(shell git rev-parse --is-shallow-repository)
# Some of GitHub Actions workflows do a shallow checkout without tags. This avoids logging warnings from git.
GIT_CLOSEST_TAG=$(shell if [ "$(GIT_SHALLOW_CLONE)" = "false" ]; then git describe --abbrev=0 --tags; else echo 0.0.0; fi)

to this:
"$(GIT_SHALLOW_CLONE)" = "true"

After this change the fatal messages stopped. This is very weird considering  git rev-parse --is-shallow-repository is false.

GIT_SHALLOW_CLONE := $(shell git rev-parse --is-shallow-repository)
# Some of GitHub Actions workflows do a shallow checkout without tags. This avoids logging warnings from git.
GIT_CLOSEST_TAG=$(shell if [ "$(GIT_SHALLOW_CLONE)" = "true" ]; then git describe --abbrev=0 --tags; else echo 0.0.0; fi)

I changed the value of GIT_SHALLOW_CLONE to true and the fatal errors where not there anymore. This is very weird considering that git rev-parse --is-shallow-repository is false.

I think we introduced a bug recently to the Makefile, change it to
diff --git a/Makefile b/Makefile
index 7055dad4..ff5440b5 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ test-and-lint: test fmt lint

 .PHONY: echo-version
 echo-version:
-       @echo "GIT_CLOSEST_TAG=$(GIT_CLOSEST_TAG)"
+       @echo "$(GIT_CLOSEST_TAG)"

 .PHONY: echo-all-pkgs
 echo-all-pkgs:

and you will need to run make build-all-platforms before the packaging script.

Shall I include this change as well ?

yes

Thanks


Issue in Firefox when control + Mouse left click on the body of the popup Selecting entire text in popup

jquery-confirm version:
v3.3.4
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request
Current behavior:

when control + Mouse left click on the body of the popup Selecting entire text in popup
Expected behavior:

should not select the text. should be consistent as other browsers
Steps to reproduce:
1.Open Popup in Firefox browser
2.Hold Control and Left mouse click on the body/content area of the popup.
3. You can see all the text including title, body and buttons in the popup is Highlighting where in other browsers this is not the case.

Related code:
insert any relevant code here

Other information:

Same problem with Firefox 78.0b3


See or group impacted factors/S.I. in an alert

In the screen of alerts, enable to see or group the alerts for the factor(s) or S.I.(s) that are affected by the element of the alert.

Easy way --> add sorting and/or filtering capabilities to tables


Myclasses / Moreoption crash

Describe the bug
In myclasses section when we click on More option the page has no return button or no info available due to this we have to reload the page again
To Reproduce
Steps to reproduce the behavior:

Check for issue
Introduce some info
Make a redirecting route to Myclass when clicked on back button

Before clicking More options

##After Clicking More options

What will be your approach to fix this?

Right now the value rendered in tabpanel is zero
Code
export default function CoursePageViewWithVideo() {
const classes = useStyles();
const [value, setValue] = React.useState(0);
const handleChange = (event, newValue) => {
setValue(newValue);
};
so we should render some value to Moreoptions since we have a handlechange method but it doesnt seem to work correctly for Moreoption tab

@Siddhant-K-code @KeenWarrior @kunal-kushwaha  please look into this

Hi @harshshaw , the app majorly focuses on mobile view.
It was the problem with the bottom navbar which was fixed, please pull the latest code from the main repo. And verify if it still exist.
Feel free to open a new issue or current one, if you come out with some new problems.
I am closing it for now.


Add the ability to show  more info for each Questionnaire item

Is your feature request related to a problem? Please describe.
Add the ability to show the info button(this triggers a popup/hint to show more info) in forms
Describe the solution you'd like
On click, we should have a pop-up with more information about the field or form being populated
Describe alternatives you've considered
N/A
Additional context

This should only be text and not image attachments for now. This should be for each line item (question)
We could use a field on the questionnaire to be able to store the information required to be displayed
The pop-up could be a modal that enables the user to see more information and once done is cancellable
The view-more text could potentially be stored in the Questionnaire.item.definition field

Would you like to work on the issue?
Nope.Will request resourcing to work on this
Screenshot

@f-odhiambo Thanks for your request. We have a very similar functionality with the help questionnaire item control https://github.com/google/android-fhir/issues/1528 do you think this could work for your use case?

@shelaghm possible to have the help button next to the "question" rather than 'instructions' text field in #1528. For cases where the question doesn't have instructions?

@HenryRae Yes, that's an option. We're hoping to have one location that can stay consistent across so it is easier to implement. See screenshot below with options. Option 1 could still work if there's no instructions as it will just display the help button below the question.
Do you have a perspective on which option you'd prefer between 1 and 2 in screenshot below?
I find option 3 (fixed location) to make the icon look a bit disconnected from the content itself.

@shelaghm I think a user can easily relate the info action to a question with option 2.

@HenryRae Thanks for your feedback.

maybe another thing to consider is if we can include beyond text in them i.e maybe show images in them as well. what are your thoughts on that @shelaghm

@HenryRae Oh, interesting idea. What's an example of when you'd like to include an image?
I imagine it could be really useful for showing visual instructions, especially if it isn't something they do very often. Hearing your specific examples will be really helpful.

@HenryRae that is clear. Yes, I think for some CHWs if they are doing the same task everyday it is likely that they don't need to always see the visual instructions, and hiding it inside the help button can make it available to reference when needed without cluttering the page for all users.
@jingtang10 are there any engineering constraints for embedding images inside the help component?


work around segfault bug with clang custom passes

When shutting down LLVM, the custom pass shared library can be prematurely unloaded, resulting in a dangling pointer. As a workaround, instruct the linker to mark the custom pass not to be unloaded at runtime.
References:
https://groups.google.com/forum/#!msg/afl-users/TDLrTu3V_Pw/K4svutarAAAJ
https://stackoverflow.com/questions/47712670/segmentation-fault-in-llvm-pass-when-using-registerstandardpasses
https://github.com/sampsyo/llvm-pass-skeleton/issues/7
Upstream bugs:
https://bugs.llvm.org/show_bug.cgi?id=34573
https://bugs.llvm.org/show_bug.cgi?id=39321
https://bugs.llvm.org/show_bug.cgi?id=36183

I don't have the time to bisect this, but as of current trunk (see #19), the underlying LLVM bug seems to have been fixed.

I'm less familiar with afl-clang-fast since I mostly use trace-pc-guard but this patch seems widely used as a fix, and I've confirmed it allows building the pass with clang-6.0. on Ubuntu 16.04.6 (where it is currently broken).

Thanks for the patch!


Godot 4 Beta 17 hotfix

Godot 4 Beta 17 changed how typed arrays work (GH-69248). This PR solves an error that comes up when an Array of type Array is passed in as an argument. Since this only affects one method, I think removing the typed declaration does not have a significant effect.

Thanks for spotting this. Godot typed arrays are in a bit of state at the moment.


Text view is not aligned in Tor Browser

Very useful site, thanks for hosting it!! :black_heart:
The text view is especially sexy, but it is not aligned.
Are there symbols [signaling, not signaling, not yet mined] with the same width?

What browser is that?

Tor browser.
I can confirm that it is aligned in firefox and chromium.

@MaxHillebrand Yes, please use another browser for the time being.
I'll see if we can change the symbols we use to work in Tor Browser as well.


Handle fig sidenav sizing in css and clean up/document js

As a follow-on to https://github.com/cfpb/consumerfinance.gov/pull/7087, this addresses the underlying clipping issue in a simpler way. Namely, instead of using position: fixed and adding a class with js + setting the width as a percentage of the body (which position: fixed forces you to do), this uses position: sticky (relatively new but supported in all browsers we serve js), which just requires the parent element to have a height set. Doing this also allowed me to remove the scrunch logic.
Also included in this PR:

reenable eslint on the js file and add docstrings
fixed a bug where sub-headers weren't properly being shown/hidden if a level-3 header was present
updated the headerOffset and keyed it off the main tag's offsetTop so it will always be correct.

Testing:

Pull and yarn build
Spin up a Fig content page
Everything should appear correct at all non-mobile sizes

I am not getting the same levels of indentation as your screenshot shows.

I am not getting the same levels of indentation as your screenshot shows.

? What seems misaligned? Is it just the difference based on the leading T vs the a? Also, none of the code changed here would affect that alignment.

let me point you over to this PR: https://github.com/cfpb/consumerfinance.gov/pull/7090.
it has to do with the text wrapping under 1.1. and 1.2, as it is doing in the screenshot above.

Ah! And you've yarn builded and hard refreshed your local page?

i don't get the reference....  in any case, yes. ran yarn build.  indentation still not appearing.

So the indentation works in three ways:

sets display: inline-block (this is done for all .m-nav-links
sets padding-left: 2.5em which applies the indentation for every line
sets text-indent: -1.875em which unindents just the first line
(the later two rules are set here

Looking in dev tools, these rules are indeed being applied:


add text direction classification model (mobilenetv3_small_100)

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

[x] You have read the Contributing Guidelines on pull requests
[x] Your code builds clean without any errors or warnings
[x] You are using approved terminology
[x] You have added unit tests

Motivation

add mobilenetv3_small_100 as text direction classification model.
achieve evaluation accuracy 94.59%, higher than paddleocr 94.56%.
docs will be updated later.

Issue #230


Behavior change noticed in InteractsWithPages seeInElement

seeInElement is no longer able to match on html tag attributes. It was able to do this prior to the recent commit: https://github.com/laravel/framework/commit/59530e6cfe693fbe2d19e7d7fddff146d95a9d92
I'm open to better ways of performing the below test, in the meantime we've written a trait to give us back the functionality that was lost. Figured I would report the issue nonetheless.
/**
 * Page Source
 */

/**
 * Test
 */

// Used to pass, now fails.
$this->seeInElement("#mytable", "image.jpg"

Ping @taylorotwell.

https://github.com/laravel/framework/pull/11928
@sileence this PR seems to have broken something. Thoughts?

I'll take a look and will answer soon.

Sorry about that, there is the fix.

Awesome, that's what I was just seeing today, nodeValue vs Html seemed to be the significant change.


Change hex_value so its parameter is a json_uchar

In the event that the json_char type is signed, the hex_value function
may index hex_table with a negative value. Declaring the parameter as
json_uchar avoids this problem.

Thanks, but another pull request replaced the hex table completely, so this doesn't apply anymore.

ah cool, didn't notice that. cheers


add windowstransport endpoint

we have docs listed with endpoints required and however couple of office SEEs consulted and I have confirmed we need windowstransport needed for office silent activation with ADFS and it worked once enabled. Can we update this article?
https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/deployment/best-practices-securing-ad-fs
We have blog about it written by Samuel already
https://blogs.msdn.microsoft.com/samueld/2015/06/05/office-modern-auth-adfs-making-it-work/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a834de4-c696-4599-6ab2-94ae03d31471
Version Independent ID: 78658bfd-8bcc-0d71-5139-77733f1a795e
Content: Best Practices for securing AD FS and Web Application Proxy
Content Source: WindowsServerDocs/identity/ad-fs/deployment/Best-Practices-Securing-AD-FS.md
Product: windows-server-threshold
Technology: identity-adfs
GitHub Login: @billmath
Microsoft Alias: billmath

Seems article updated to disable only over proxy. not to disable over internal


WIP: ceph: 14.2.7 -> 14.2.8

Motivation for this change
Regular update.
WIP until dashboard is tested, it looks like the patch may no longer be necessary, but needs verification.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Had to poke the tests for the new pg must be powers of two-warning.
Looks like this might be our last master-version of 14.x, Octopus is out.

Confirmed, dashboard is good. Finally rid of that patch. O:-)


Infra 808/testing locally +  clean up

Description
Fixes #000.

TODOs
Read the Gruntwork contribution guidelines.

[ ] Update the docs.
[ ] Run the relevant tests successfully, including pre-commit checks.
[ ] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[ ] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].
 Resources: 2 added, 0 changed, 0 destroyed.

Outputs:

test-1_id = "i-0842d4a4587a918ec"
test-2_id = "i-0b03a18b131afcd53"

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: . workspace: default


docs: update usage guide for changing models; add custom model support and reorganize sections

PR Type
Documentation, Enhancement

Description

Enhanced get_max_tokens function to include custom_model_max_tokens from settings and added a detailed docstring.
Removed detailed instructions for changing models from additional_configurations.md.
Added a new changing_a_model.md file with detailed instructions for changing models, including sections for various providers like Azure, Hugging Face, and others.
Updated the usage guide index and mkdocs navigation to include the new "Changing a Model" section.
Added custom_model_max_tokens configuration option in configuration.toml.

Changes walkthrough 📝
Relevant filesEnhancement

utils.pyEnhance `get_max_tokens` logic and add docstring

pr_agent/algo/utils.py
Added detailed docstring for get_max_tokens function.  Enhanced logic to include custom_model_max_tokens from settings.

+13/-3

configuration.tomlAdd custom model max tokens configuration

pr_agent/settings/configuration.toml

Added custom_model_max_tokens configuration option.

+2/-0

Documentation

additional_configurations.mdRemove model changing instructions

docs/docs/usage-guide/additional_configurations.md

Removed detailed instructions for changing models.

+0/-159

changing_a_model.mdAdd detailed instructions for changing models

docs/docs/usage-guide/changing_a_model.md
Added detailed instructions for changing models.  Included sections for various providers like Azure, Hugging Face, and others.

+187/-0

index.mdUpdate usage guide index with new sections

docs/docs/usage-guide/index.md
Added link to new "Changing a Model" section.  Updated link to "PR-Agent Pro Models".

+2/-1

mkdocs.ymlUpdate mkdocs navigation with new sections

docs/mkdocs.yml
Added "Changing a Model" to navigation.  Updated "PR-Agent Pro Models" link.

+2/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/improve

/review --pr_reviewer.extra_instructions="the generated output should be in Japanese"

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...


Exception when Conversation Agent doesn't receive json output

I'm trying to create a conversation agent essentially defined like this:
tools = load_tools([]) # "wikipedia"])

llm = ChatOpenAI(model_name=MODEL, verbose=True)
memory = ConversationBufferMemory(memory_key="chat_history", return_messages=True)

agent = initialize_agent(tools, llm,
    agent="chat-conversational-react-description",
    max_iterations=3,
    early_stopping_method="generate",
    memory=memory,
    verbose=True)

The agent raises an exception after it tries to use an invalid tool.
Question: My name is James and I'm helping Will. He's an engineer.

> Entering new AgentExecutor chain...
{
    "action": "Final Answer",
    "action_input": "Hello James, nice to meet you! How can I assist you and Will today?"
}

> Finished chain.
Answer: Hello James, nice to meet you! How can I assist you and Will today?
Question: What do you know about Will?

> Entering new AgentExecutor chain...
{
    "action": "recommend_tool",
    "action_input": "I recommend searching for information on Will on LinkedIn, which is a professional networking site. It may have his work experience, education and other professional details."
}
Observation: recommend_tool is not a valid tool, try another one.
Thought:Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/conversational_chat/base.py", line 106, in _extract_tool_and_input
    response = self.output_parser.parse(llm_output)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/conversational_chat/base.py", line 51, in parse
    response = json.loads(cleaned_output)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/main.py", line 93, in <module>
    ask(question)
  File "/usr/src/app/main.py", line 76, in ask
    result = agent.run(question)
             ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/chains/base.py", line 213, in run
    return self(args[0])[self.output_keys[0]]
           ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/chains/base.py", line 116, in __call__
    raise e
  File "/usr/local/lib/python3.11/site-packages/langchain/chains/base.py", line 113, in __call__
    outputs = self._call(inputs)
              ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 632, in _call
    next_step_output = self._take_next_step(
                       ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 548, in _take_next_step
    output = self.agent.plan(intermediate_steps, **inputs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 281, in plan
    action = self._get_next_action(full_inputs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/agent.py", line 243, in _get_next_action
    parsed_output = self._extract_tool_and_input(full_output)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/langchain/agents/conversational_chat/base.py", line 109, in _extract_tool_and_input
    raise ValueError(f"Could not parse LLM output: {llm_output}")
ValueError: Could not parse LLM output: My apologies, allow me to clarify my previous response:

{
    "action": "recommend_tool",
    "action_input": "I recommend using a professional social network which can provide informative details on Will's professional background and accomplishments."
}

You can try searching for information on platforms such as LinkedIn or XING to start.
>>>

Perhaps this is because there are no tools defined? This may be somewhat related to #2241, which is also a parsing error.
My real goal here was trying to test the agent's memory, but if I defined wikipedia as a tool, the agent would try to search for Will in wikipedia and respond with facts about some random Will. How can I get this to work?

I got this error as well, a lot of the difficulties stem from needing to parse the output and LLMs not always returning the output in the format that we need it or want it. I have been relying on conversational-react-description instead of conversational-chat for this reason.

@exiao Even using the conversational-react-description or chat-conversational-react-description doesnt solve the issue of JsonDecodeError.

I feel like this has started happening way more often since I started providing a custom system prompt.

I am also running into this, going through the langchain quickstart guide.

Note: This is a pretty hacky solution, but I noticed that the error was prefixing the desired JSON with some non-json text. Editing /opt/homebrew/lib/python3.11/site-packages/langchain/output_parsers/json.py as follows:
def parse_json_markdown(json_string: str) -> dict:
    if '```' in json_string:
        json_string = '```' + ''.join(json_string.split('```', 1)[1])

Solved the issue for me at least temporarily

I guess its about openai ratelimits. Openai api returns "" to parser and tries again. So parser tries to format but fails bc of the empty string.
So edit {copied-path}/langchain/agents/conversational_chat/output_parser.py to:
from __future__ import annotations

import json
from typing import Union
import regex

from langchain.agents import AgentOutputParser
from langchain.agents.conversational_chat.prompt import FORMAT_INSTRUCTIONS
from langchain.schema import AgentAction, AgentFinish

class ConvoOutputParser(AgentOutputParser):
    def get_format_instructions(self) -> str:
        return FORMAT_INSTRUCTIONS

    def parse(self, text: str) -> Union[AgentAction, AgentFinish]:
        cleaned_output = text.strip()

        if text:
            if "```json" in cleaned_output:
                _, cleaned_output = cleaned_output.split("```json")
            if "```" in cleaned_output:
                cleaned_output, _ = cleaned_output.split("```")
            if cleaned_output.startswith("```json"):
                cleaned_output = cleaned_output[len("```json") :]
            if cleaned_output.startswith("```"):
                cleaned_output = cleaned_output[len("```") :]
            if cleaned_output.endswith("```"):
                cleaned_output = cleaned_output[: -len("```")]
            if not cleaned_output.endswith("""\n}"""):
                pattern = r"(\{(?:[^{}]|(?R))*\})"
                cleaned_output = regex.search(pattern, text).group(0)
            cleaned_output = cleaned_output.strip()

            response = json.loads(cleaned_output)
            action, action_input = response["action"], response["action_input"]
            if action == "Final Answer":
                return AgentFinish({"output": action_input}, text)
            else:
                return AgentAction(action, action_input, text)

        return AgentFinish({"output": "Final Answer"}, "")

Hope its usefull. ❤


Rjd 1278/fix line segment

Abstract
This PR contains combined fixes for issues https://github.com/tier4/scenario_simulator_v2/issues/1343 and https://github.com/tier4/scenario_simulator_v2/issues/1344.
Details
Additionally:

This PR introduces 4 additional const-fields for LineSegment class, namely length, length_2d, vector and vector_2d. These constants are frequently used and can be easily calculated during construction.
Function getIntersection2DSValue has been renamed to get2DIntersectionSValue. In my opinion, in previous version it was  unclear if 2D refers to Intersection or SValue.
Both isIntersect2D and getIntersection2D had a duplicate. This was simplified.
Function getSlope has been renamed to get2DVectorSlope, now it throws an error if division by 0 occurs.

Background
Please see https://github.com/tier4/scenario_simulator_v2/issues/1343 and https://github.com/tier4/scenario_simulator_v2/issues/1344 for detailed explanations of the bugs.
References
Regression tests summary

No regressions for these changes as evidenced here: summary