HDFS-17324. RBF: Router should not return nameservices that not enable observer r…

…ead in RpcResponseHeaderProto

Description of PR
Router Observer Read is controled by RBFConfigKeys.DFS_ROUTER_OBSERVER_READ_DEFAULT_KEY and RBFConfigKeys.DFS_ROUTER_OBSERVER_READ_OVERRIDES.
If a nameservice is not enable for observer read in Router, RpcResponseHeaderProto  in Router should not return it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
60m  6s

trunk passed

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 52s

trunk passed

+1 :green_heart:
shadedclient
20m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

-1 :x:
spotbugs
0m 53s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html
hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 18s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

129m 44s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-rbf

Write to static field org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.observerReadEnabledDefault from instance method new org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient(Configuration, Router, ActiveNamenodeResolver, RouterRpcMonitor, RouterStateIdContext)  At RouterRpcClient.java:from instance method new org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient(Configuration, Router, ActiveNamenodeResolver, RouterRpcMonitor, RouterStateIdContext)  At RouterRpcClient.java:[line 224]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6412

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fe24f565867c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e8db25bbb70e7e9c1866d2d123df135b5c9a303d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/1/testReport/

Max. process+thread count
2623 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 15s

trunk passed

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 20s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 17s

trunk passed

+1 :green_heart:
mvnsite
0m 24s

trunk passed

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
20m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
20m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 57s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

107m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6412

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 490d2bade0dc 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6f8bbedb097e482173456bb73d90bed50c8c224

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/3/testReport/

Max. process+thread count
2597 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 17s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 20s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 17s

trunk passed

+1 :green_heart:
mvnsite
0m 24s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

trunk passed

+1 :green_heart:
shadedclient
20m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
compile
0m 16s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 10s

the patch passed

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 46s

the patch passed

+1 :green_heart:
shadedclient
21m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 11s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

103m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6412

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c466dd89188e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6f8bbedb097e482173456bb73d90bed50c8c224

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/4/testReport/

Max. process+thread count
2627 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri @simbadzina  Cloud you have time to review this, thanks!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 49s

trunk passed

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 20s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 18s

trunk passed

+1 :green_heart:
mvnsite
0m 27s

trunk passed

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 50s

trunk passed

+1 :green_heart:
shadedclient
19m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
mvnsite
0m 17s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
0m 48s

the patch passed

+1 :green_heart:
shadedclient
19m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 19s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

106m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6412

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 777cf14df018 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a60178b505beeffb8454aba60e01b4626b8096da

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/5/testReport/

Max. process+thread count
2623 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6412/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@simbadzina @slfan1989  Hello, sir.   Can you review this, Thanks.


Update Resources.ru-RU.resx

[*] Have you signed the Contributor License Agreement?
[*] Are you working against an Issue?

Microsoft Reviewers: Open in CodeFlow

Localized strings need to go through internal review. I will submit this suggestion and close this PR when the change has been committed. Thanks!

Changes have been merged, thanks!

Awesome!


[bug] After running cargo tauri android dev, the notification plugin is not working on Windows

Initially, the notification plugin was working fine on Windows. Then, I tested it on an Android device, and it also worked. However, after continuing development and testing on Windows, the notification plugin stopped working. There were no error messages during this process, so I'm not sure if the issue is with the plugin itself.
After running cargo tauri android dev, a config.toml file is generated with the following content:
[build]
target = "x86_64-pc-windows-msvc"

[target]

If I delete this file, the notification plugin starts working on Windows again.
cargo tauri info:
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 120.0.2210.144
    ✔ MSVC: Visual Studio 生成工具 2022
    ✔ rustc: 1.79.0 (129f3b996 2024-06-10)
    ✔ cargo: 1.79.0 (ffa9cf99a 2024-06-03)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
    - node: 20.11.1
    - npm: 9.8.1

[-] Packages
    - tauri [RUST]: 2.0.0-beta.24
    - tauri-build [RUST]: 2.0.0-beta.19
    - wry [RUST]: 0.41.0
    - tao [RUST]: 0.28.1
    - tauri-cli [RUST]: 2.0.0-beta.22
    - @tauri-apps/api [NPM]: 2.0.0-beta.15
    - @tauri-apps/cli [NPM]: 2.0.0-beta.22

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Thanks for the report! This is the same issue I tried to fix in https://github.com/tauri-apps/plugins-workspace/pull/1502.
Note that installed apps are not affected by the logic bug, so your end-users won't have this issue.

Thanks for the report! This is the same issue I tried to fix in #1502. Note that installed apps are not affected by the logic bug, so your end-users won't have this issue.

I did some research and found winrt_toast. We might be able to refer to this to register an AUMID.


[SPARK-7770] [ML] GBT validationTol change to compare with relative or absolute error

GBT compare ValidateError with tolerance switching between relative and absolute ones, where the former one is relative to the current loss on the training set.

Merged build triggered.

Merged build started.

Test build #41866 has started for   PR 8549 at commit 47bb5e6.

Test build #41866 has finished for   PR 8549 at commit 47bb5e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41866/
Test PASSed.

Btw, I commented on the JIRA.   Let me know what you think.

Merged build triggered.

Merged build started.

Test build #42655 has started for   PR 8549 at commit 9790bb0.

Merged build triggered.

Merged build started.

Test build #42656 has started for   PR 8549 at commit ffea283.

Test build #42655 has finished for   PR 8549 at commit 9790bb0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42655/
Test PASSed.

Merged build finished. Test PASSed.

Test build #42656 has finished for   PR 8549 at commit ffea283.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42656/
Test PASSed.

This looks good, but can you please document the semantics of validationTol in BoostingStrategy?

Merged build triggered.

Merged build started.

Test build #42879 has started for   PR 8549 at commit e6cf283.

Test build #42879 has finished for   PR 8549 at commit e6cf283.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42879/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #43058 has started for   PR 8549 at commit a9ef902.

Test build #43058 has finished for   PR 8549 at commit a9ef902.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43058/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #43393 has started for   PR 8549 at commit 589180f.

Test build #43393 has finished for   PR 8549 at commit 589180f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43393/
Test PASSed.

Merged build finished. Test PASSed.

LGTM, merging with master.  Thanks for the PR!


Robyn's issues list for 2023

Here is a list of issue for 2023

[ ] Application error/timeout when all academic years selected  #2230
[ ] Activity and/or subcategory – possible error in project entry form #2231
[ ] Project search not working in Projects > All Projects #2232
[ ] Project name not showing as entered #2233
[ ] Map filter button reacting oddly when pushed from display screens #2234
[ ] Programming Error at /projectspublicreport/ #2235
[ ] AttributeError at /register-Campus-Partner-User/ #2236
[ ] Fix issue for deleting user @MansiKamthan
[ ] Make necessary technical and user manual updates @MansiKamthan
[ ] Make inventory (excel) discussed in meeting @MansiKamthan
[ ] Django admin page no longer shows the main cepi black header and drop downs when admin logs in #2237
[ ] New community partners added to a project (through the edit project process) not displaying in table after submitted #2239
[ ]  Admin to edit project details inconsistent #2240

@SachinPawaskarUNO
@MansiKamthan
I believe these are the majority of issues but if anything else comes up I will add them here. Do you want me to notify you if I add anything new?

@robynlloos This is a great start.
YES, Please add any new items here. This will automatically notify people who are mentioned on the issue.
I have assigned this to @MansiKamthan, so she should be notified as well.

@MansiKamthan see new issues added above:
https://github.com/uno-isqa-8950/uno-cpi/issues/2278
https://github.com/uno-isqa-8950/uno-cpi/issues/2277
https://github.com/uno-isqa-8950/uno-cpi/issues/2241

High Priority Issues:
Activity and/or subcategory – possible error in project entry form https://github.com/uno-isqa-8950/uno-cpi/issues/2231
Project search not working in Projects > All Projects https://github.com/uno-isqa-8950/uno-cpi/issues/2232
Project name not showing as entered https://github.com/uno-isqa-8950/uno-cpi/issues/2233b
Campus user needs to be able to add community partner organization to tool https://github.com/uno-isqa-8950/uno-cpi/issues/2236

@MansiKamthan @SachinPawaskarUNO new map search issue added

See added issue documentation for
Project data entered not showing on public/logged in view but shows as it was entered on the admin side #2309
@MansiKamthan @SachinPawaskarUNO @anguyen63

See  New User Error #2311

@SachinPawaskarUNO @MansiKamthan I added in some new screenshots to the projects not coming up after being entered and then added a new issue that I tagged you both in.
Do you think we can sort through which of these the team would take on and which @MansiKamthan would take on? Just for sake of understanding where things are happening and for other issues that come up.

@SachinPawaskarUNO @MansiKamthan - see the new issue added for inconsistent data. The CP totals are not consistent on map vs reports of all community partners. Should be.  Inconsistent data - community partners #2359

@SachinPawaskarUNO @MansiKamthan
FYI:
I renamed this list to follow the naming for the summer list. It may help to have a unique list for each semester so it keeps everything together accordingly - especially for work with capstones as those happen. I figured you both would agree 👍


done + docs

Codecov Report

Merging #355 into develop will decrease coverage by 0.02%.
The diff coverage is 23.52%.

@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
- Coverage    28.98%   28.96%   -0.03%
===========================================
  Files           56       57       +1
  Lines         6179     6194      +15
  Branches      1423     1426       +3
===========================================
+ Hits          1791     1794       +3
- Misses        3132     3141       +9
- Partials      1256     1259       +3

Flag
Coverage Δ

#rnvunittests
28.96% <23.52%> (-0.03%)
:arrow_down:

Impacted Files
Coverage Δ

packages/rnv/src/deployTools/fastlane.js
35.71% <ø> (-4.29%)
:arrow_down:

packages/rnv/src/configTools/configParser.js
45.25% <ø> (-0.14%)
:arrow_down:

packages/rnv/src/cli/index.js
56.73% <0%> (+0.3%)
:arrow_up:

packages/rnv/src/projectTools/publish.js
25% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f75092...0e4584e. Read the comment docs.


i can't get the origin action type in reducer

code like that:

my action type like that:

it can't get the origin action type via switch & case
is there any wrong in my code?

Hi,
Please show how you create fetchDataSuccess function

export const fetchDataSuccess = createStandardAction(types.FETCH_DATA_SUCCESS)<
    PlainObject
>()

I think it's typescript's problem;  it can only show the property all the union type has;  some action has not payload . so it would show the error.  when i change my actions all create as PayloadAction and it work!

I understand, please could you also show contents of entire './actions'  module, I could tell you which action could be problematic

this is action & reducer file

@vegawong I think you shouldn't be using never, it should be void, can you try it? If you take a look at docs it is always using void.

nothing worked!    it also create as EmptyAction type that only as type property.  it can't work in union type.

hello!   I had found out what's wrong with that?   but.... emmmm...   I has no idea to deal with.
if i did not use constant type from another module,and then actionCreator would get the collect type and  it work! like that:

but, when is use the constant from another module, actionCreator can't get the collect type like that:

@piotrwitek oh my god！ It is my fault; my constant code like that:
const PAGENAME = 'dzcf/Prescriptions'

export const FETCH_DATA = `${PAGENAME}/fetchData`

export const FETCH_DATA_SUCCESS = `${PAGENAME}/fetchDataSuccess`

I type the code use String Template and typescript is not suport this way for String Literals, so that it can't get the right value as type for getType function. thanks


Add Ufa University of Science and Technology

@bymaxi7 Unfortunately, your request cannot be processed further because JetBrains doesn’t provide product or services to territories subject to applicable EU, UN or US sanctions or under comprehensive export control restrictions due to legal, compliance and other commercial related risks.


useParam always returns the same value (the first selected)

I've got  a blog/[slug].js structure
In react navigation I have
 <NavigationContainer
        linking={useMemo(
          () => ({
            prefixes: [Linking.createURL('/')],
            config: {
              initialRouteName: 'home',
              screens: {
                HomeScreen: '',
                BlogScreen: 'blog',
                BlogSlugScreen: 'blog/:slug',
                CourseSlugScreen: ':courseSlug/:categorySlug/:slug',
...

In the Blog screen I have:
import { createParam } from 'solito'
const { useParam } = createParam()

export function BlogSlugScreen({   route }) {
  const [slug] = useParam('slug')
   console.log('slug', slug)
   console.log('route', route)
   ...

So, first time a select a post, slug  keeps the right value and same thing for route.params.slug.
But next times, route.params.slug  stores the right value while slug keeps storing the first selected (it's not updated). Is it a bug ?

i believe this is a duplicate of #51

if you use setSlug it would work for now, as shown in the docs

but yeah i need to fix this

I mean use the setter from the useParam docs:
const [slug, setSlug] = useParam('slug')

// and then...

setSlug('123')

But this will be fixed when I have time.

ok , I understand. Thx!!

closing as duplicate of #51


Dashboard "back" button behavior

The back button doesn't behave as expected, particularly on mobile where the expectation is that, if you're in an app, that back should take you to the home screen, or perhaps to the most recent app used.

The intended behavior of the back button is as follows:

If you are in an app, the back button should provide normal "back" navigation within the app.
If you are at the "home" (first) page of an app, the back button should take you to the main apps menu
If you are at the main apps menu already - the back button should take you away from fabmo to whatever domain you were browsing before you started using fabmo.
If you have the DRO up, it should close the DRO.
If you have the left side menu up on mobile in its non-collapsed mode, the back button should close it.


Use hidden / secret variables in commands

Do secret / hidden variables defined at the build level get excluded from calls to commands, if they are a part of that command, in TFS?
for instance, in order to tag the repo with the version number, I'm trying to do the following:
git push https://${env:tagUser}:${env:tagPass}@${env:tagUrl} $versionString
in a powershell script. The three env: variables are defined as build variables. tagPass is the only one that is hidden. tagUser and tagUrl get substituted in the command; tagPass may or may not - the logged error message message excludes the text (as expected). The command fails only if tagPass is marked as hidden. If I save it as unhidden, the push works correctly.
My thought here is that since it is a call to a command (something that may interact with stdout), the variable value is stripped from the command, and authentication fails because of that. Is my assumption correct, and if so, any recommended work arounds?

Does
$(tagUser)@$(tagPass)... work?
note our vars are replaced with parens and no env:

@(var) should get replaced on all inputs including secrets

You need to use $(tagUser) not ${env:tagUser}

With:
 git push https://$(tagUser):$(tagPass)@$(tagRepoUrl) ...
´´´

I get a bunch of errors: such as

tagUser : The term 'tagUser' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
´´´
Same if I use the @(tagPass) syntax :

After I had posted the issued, I went out a different path, that seems to work (I did test your suggestions though).
What workd for me:
Set local variables with the arguments passed to the script:
[string]$tagUser = $args[0]
[string]$tagPass = $args[1]
[string]$tagRepoUrl = $args[2]

add use the local vars in the script:
git push https://${tagUser}:${tagPass}@${tagRepoUrl} $GitVersionJson.MajorMinorPatch --porcelain

this actually works and the log message has the password replaced with *'s

I see you are trying to use variables in your script, I missed that somehow.  The variable replacement we do is on the inputs on the tasks, we don't parse the scripts.  To use secret variables you will have to take those as inputs into your script we explicitly do not populate those into the environment.  Other variables you should be able to reference as normal environment variables if you want.

Thanks guys! I think this might be worth including in some future documentation, since it isn't clear (and to a powershell noob like myself, tough to discover).

+1 @MiguelAlho

@MiguelAlho
If using PowerShell, you can access secret variables using Get-TaskVariable function from Microsoft.TeamFoundation.DistributedTask.Task.Internal module.
Example:
Import-Module "Microsoft.TeamFoundation.DistributedTask.Task.Internal"

$username = Get-TaskVariable -Context $distributedTaskContext -Name "ApiUsername"
$password = Get-TaskVariable -Context $distributedTaskContext -Name "ApiPassword"

$cred = New-Object System.Management.Automation.PSCredential($username, (ConvertTo-SecureString -String $password -AsPlainText -Force))

The ApiPassword is marked as secret in the build definition and will be logged to the console as *******.

That will only work from a task it will not work from a arbitrary powershell script.

@chrisrpatterson can you expand on your last comment?
I'm actually creating a build task, and upon executing the associated Powershell script, I'm getting this
Cannot bind argument to parameter 'Context' because it is null.
Thanks

@carlosrfernandez ask on StackOverflow or get on the AspNetCore Slack (I created a #vsts-tfs channel in there.) I will be glad to help.

@tuespetre Thanks, I've joined the Slack team.
In the end I've solved the issue by reading up on the new SDK documentation.
I can get access to the secret variable using this:
$sourcesDirectory = Get-VstsTaskVariable -Name "Build.SourcesDirectory"


Fix: make UUID retrieval more portable

The CUuuid byte type is std::os::raw::c_char and it depends on the platform, whether it is i8 or u8 in Rust. With just passing in 0 without a type identifier, both cases are handled. This makes the code more portable.

A friendly ping if this PR could perhaps get a review (and ideally a release :) This would enable me to get off a fork and use the upstream version.


Add MAX78 family to build system

Include MAX file as a sub directory for MAX78 SoC family.

MAX32 family is going to be used for MAX78xxx too. No need this addition.
Can be closed.


Refactor directory structure

Some proposed changes to the directory structure:

Moves doc/examples to examples, both because most of the contents under examples aren't docs, and to more heavily promote the examples to first-time visitors to the repo.
Break up contributing to doc/contributing and etc/contributing - the former for documentation, the latter for the scripts/configs.

Hey guys, changes like this can't be merged unless you make these fixes in
the docs TOC (table of contents) tree, index file, etc. Now every link to
examples throughout our docs 404s because the dir structure is different.
http://docs.pachyderm.io/en/latest/examples/README.html
One reason these were under /doc is because we want them nicely organized
as parts of our developer docs. I'm sure it's possible to fix this, but I
don't have the time to look at it right now so it should be included as
part of this PR. Sorry that I didn't track this PR and comment on it sooner
https://github.com/pachyderm/pachyderm/blob/master/doc/index.rst
On Wed, Dec 12, 2018 at 2:10 PM Yusuf Simonson<EMAIL_ADDRESS>wrote:

Merged #3257 https://github.com/pachyderm/pachyderm/pull/3257 into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pachyderm/pachyderm/pull/3257#event-2022760747, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABtjwHsamoDScYJVaHvMbrC8fJ0hSTw5ks5u4X6-gaJpZM4ZHRx1
.


[BUG] Invalid version for gdk_toplevel_titlebar_gesture and gdk_titlebar_gesture_get_type

This was originally opened here.

Fixed the annotations upstream at https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/4154


persisting privacy mode toggle

Github Issue (if applicable): #606
Explanation of Bugfix/Feature/Enhancement:
Persist the toggle of privacy mode.
Recommended Release Notes:
Your privacy mode toggle will be saved for next time you come to the app.

Thank you!


Configuration for backup

Hi,
I am using Strapi cloud, and would like to use this plug-in to achieve daily backup.
Questions :

databaseDriver: env('DATABASE_CLIENT') : What should be the value for DATABASE_CLIENT? I believe we are using PostgreSQL.
pgDumpExecutable : How to get this path? The strapi is running in cloud, so I am not sure where to grab this path.

Any response will be appreciated!

Hello @Yujink0624 ,

The value of DATABASE_CLIENT must be postgres if you are using PostgreSQL.
You must contact your cloud provider to get the pgDumpExecutable path.

Thank you for your interest in this project
All the best


Add 1.15.4 and 1.14.11

https://golang.org/dl/#go1.15.4
https://groups.google.com/forum/#!msg/golang-announce/iKm1t36tF80/tYbQ3YGIBwAJ

pls add 1.15.4 and 1.15.5

Hoping this PR will be approved and merged soon


sigproc.synth.Counter sleeps too long

https://github.com/iscoe/ezmsg/blob/005590f74ec66b22cd36a94827ff5822ee4bbc92/extensions/ezmsg-sigproc/ezmsg/sigproc/synth.py#L111-L117
Both await asyncio.sleep(block_dur) and await asyncio.sleep(1.0 / dispatch_rate) fail to subtract the processing time. The sleep durations should probably be something like asyncio.sleep(t_next - time.time()) where t_next is calculated from a sum of the time of the last counter-reset (if self.STATE.samp >= self.STATE.cur_settings.mod: self.STATE.t_counter_reset = time.time() + {time of overflow samples}) + how long it should taken to reach the next self.STATE.samp.
I'm actually playing around with EEGSynth, which uses ext_clock, so the above issue isn't even the source of my problem. I just thought I'd submit the issue before moving on.

Aye... this was a case of "good enough for now" but I agree its not the highest precision impl.  Now that this is addressed in sigproc.synth.Clock I'll make a TODO to fix this here in the dev branch.

I'm pretty sure this was fixed in #62


Freq residency v2

This is v2 of #87.
It includes the requested changes. Also, some comments are added to ease understanding what the code does.

Other than the minor nits, I vote for merge :heart:

I like to optimizations in 30a46c2 but I'm wondering why not squashing these fixes into the previous two patches? Moreover, these "optimization" patch is too complex to be understood... better just have two initial patches with the optimization already done.
Am I missing another reason to keep it separated?

The IDLE_STATE constant renaming patch also IMHO should be squashed into the first two...

On 17/06/16 12:31, Patrick Bellasi wrote:

I like to optimizations in 30a46c2
https://github.com/ARM-software/lisa/commit/30a46c2a5e89cda04c1d9ca65f3c20f125802ecb
but I'm wondering why not squashing these fixes into the previous two
patches? Moreover, these "optimization" patch is too complex to be
understood... better just have two initial patches with the optimization
already done.
Am I missing another reason to keep it separated?

It's just to keep the history of how we started thinking about computing
the frequency residency and how we do it now. But if you prefer to have
it squashed I can do that...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ARM-software/lisa/pull/130#issuecomment-226746654,
or mute the thread
https://github.com/notifications/unsubscribe/AGFSei-0QI7McA7OEz7SXVkiEJH-bp1aks5qMoWbgaJpZM4I4Ov0.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

These modifications have been addressed in #132


rebased mystal:transparency with master

This is a rebase of mystal transparency work here:
https://github.com/jwilm/alacritty/pull/331
Mystal seems to be busy with other work so I decided to go ahead and rebase this with the current code accordingly.
This code has been tested accordingly on a fresh master on osx 10.12.6 and seems to be working as expected.

I appreciate you going to the trouble to rebase that PR, but you should probably make sure to set the author appropriately so @mystal still gets credit.

I tried changing the commit author to him by ammending and forcing an update. Not sure if I did this correctly though.

Original author followed up and we ended up landing #331. Thanks for getting the ball rolling, though!


Allow auto-detection of DNS providers / Fix acme renewal flow

Coverage decreased (-0.3%) to 61.563% when pulling 5829794d82d140eefd46cef55e52f6fb0e81d283 on castrapel:fix_le_renew into 771be58dc5cff7c0cebda5bebc3df55e51957294 on Netflix:master.


Pipes wrongly marked as impure

DifferencePipe and DateFormatPipe are actually pure pipes, but are marked as pure: false

Good catch! Can you please send a PR for that?
On Thu, Sep 22, 2016 at 2:18 PM, Tiago Roldão<EMAIL_ADDRESS>wrote:

DifferencePipe is actually a pure pipe, but is marked as pure: false
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urish/angular2-moment/issues/73, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2dngpzPHdAY9cQU1w4vE0PiLCa3rAKks5qsnIVgaJpZM4KD0y9
.

In progress :)


Landscape orientation on Android App.

I downloaded some Mediapipe examples and I love it. Unfortunately I notice that it only supports portrait mode currently. I want to implement the Multi-hand Tracking in an app, where it's required to be in landscape mode. I already tried to fix it on my own and failed. I also looked into the other issue, but it didn't help me much.
Can someone please help me find a fix in more detail? Thank you very much.
Landscape orientation on Android App. #568

我也遇到了一样的问题，不知道如何解决


Notify and redirect the user back to the login screen when their toke…

Fixes the issue where data would suddenly disappear and the user would be logged out but not taken out of the app.

Users are now redirecting to the login page as soon as they receive a 401 indicating that their token has expired.
A nice user message is displayed to the users telling them they must log back in.
The CorsFilter now correctly adds its headers when Spring Security rejects the request with a 401

#71 Will also need to update if this is merged first.


Error in GPy.models.GPMultioutRegression

Fitting a multi output GP to different data sets repeatedly returns the following error in line 127:
qU_var_r = tdot(self.qU_var_r_W) + np.diag(self.qU_var_r_diag)
ValueError: operands could not be broadcast together with shapes (4,4) (10,10)
The shape of tdot(self.qU_var_r_W) scales with the number of output dimensions in Y (in this case 4).
The shape of np.diag(self.qU_var_r_diag) remains constant at (10, 10).
Thus the only Y training data sets which proceed past line 127 are those with specifically 10 output dimensions. This appears to be an error.
Any advice would be greatly appreciated. I would be very happy to provide further details if someone may be able to look into this.

Was this ever resolved?


feature: add joke provider

This PR add a joke provider class that supports the following methods

new Faker().joke().pun();
new Faker().joke().knockKnock();

This can be extended in the future to support more joke categories.
Functionality has been validated and tested locally.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f8d403d) 92.34% compared to head (363fea0) 92.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1026      +/-   ##
============================================
- Coverage     92.34%   92.23%   -0.11%
- Complexity     2764     2766       +2
============================================
  Files           290      291       +1
  Lines          5536     5541       +5
  Branches        600      600
============================================
- Hits           5112     5111       -1
- Misses          272      276       +4
- Partials        152      154       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


error loading wasm after rust toolchain update compiler

 RUST_BACKTRACE=1 nix run github:andresilva/polkadot.nix#subwasm --  metadata result/lib/runtime.optimized.wasm  --format scale > out.txt

test.zip
🗣 If you think it should have worked, please open an issue at https://github.com/chevdor/subwasm/issues
and attach your runtime and mention using subwasmlib v0.20.0
The source was "result/lib/runtime.optimized.wasm"

Hash Error
Error:
   0: Generic error: Failed loading runtime

Location:
   cli/src/main.rs:101

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 3 frames hidden ⋮
   4: subwasm::main::he999dfba082e9974
      at <unknown source file>:<unknown line>
   5: std::sys_common::backtrace::__rust_begin_short_backtrace::hcdb697a2b8a0db9e
      at <unknown source file>:<unknown line>
   6: std::rt::lang_start::{{closure}}::h97a0e80dd1689db2
      at <unknown source file>:<unknown line>
   7: std::rt::lang_start_internal::h7910e71d80e7bec3
      at <unknown source file>:<unknown line>
   8: main<unknown>
      at <unknown source file>:<unknown line>
   9: __libc_start_call_main<unknown>
      at <unknown source file>:<unknown line>
  10: __libc_start_main_impl<unknown>
      at <unknown source file>:<unknown line>
  11: _start<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.

So is it possible to expand error to full? Whole trace/message of Hash?

Weird is that how HashError happens? Why hashing fails?

and attach your runtime

it is inside archieve. gh does not allow to upload wasm exfensions

test.zip

it is unoptimized wasm btw. so optimized fails same way.  fails on several new rust versions.

I also had this issue and it was happening because the start of the wasm was not the WASM Magic bytes.
https://blog.ttulka.com/learning-webassembly-2-wasm-binary-format/

Closing as it sounds like the wasm was not generated properly. Please reopen if you think this is wrong and include how you built the wasm.


Missing migrations

When installing into Django 1.11 on Python3.6 there are a number of AlterField migrations missing.
If I run makemigrations I get:
Migrations for 'djangocms_forms':
  ~/lib/python3.6/site-packages/djangocms_forms/migrations/0006_auto_20180104_0929.py
    - Alter field cmsplugin_ptr on formdefinition
    - Alter field form_template on formdefinition
    - Alter field field_type on formfield
    - Alter field ip on formsubmission

Ideally these migrations could be added and deployed to PyPI. If you like I can submit a pull request with them but it might be easier for you to do it yourself if you've got a dev environment set up already.

Looking into this.

Alter field cmsplugin_ptr on formdefinition

By default on_delete behaviour  used to be django.db.models.CASCADE
We can modify the initial migration to just add that.

Alter field form_template on formdefinition
Alter field field_type on formfield

Both of the fields are "settings" driven.
i.e if someone changes settings. DJANGOCMS_FORMS_TEMPLATES
or settings. DJANGOCMS_FORMS_FIELD_TYPES
This will make django complain about missing migrations!
What we should do is update original migration and change "choices" value to point to settings.
e.g https://github.com/mishbahr/djangocms-forms/blob/master/djangocms_forms/migrations/0001_initial.py#L63
... choices=settings.DJANGOCMS_FORMS_FIELD_TYPES
or https://github.com/mishbahr/djangocms-forms/blob/master/djangocms_forms/migrations/0001_initial.py#L49
should use settings. DJANGOCMS_FORMS_TEMPLATES
Finalllly...

Alter field ip on formsubmission

This is minor bug. Nothing has changed for the field.
Except the verbose name is not wrraped in ugettext_lazy function i.e _('...')
so I bet python 3 it thinks its string now and before it was in byte.
This can be fixed by changing this line...
https://github.com/mishbahr/djangocms-forms/blob/master/djangocms_forms/models.py#L230
ip = models.GenericIPAddressField(verbose_name=_('IP'), blank=True, null=True)

FYI @riclima if you update your merge request with above suggestions.. I'll be happy to merge it.
Sorry, it took me this long to look into it. I've been super busy recently and I actually haven't used this package or django-cms for years now.

Run into the same issues... Nothing done, yet, isn't it?


Add killstreak kit tags and put them into stats.

Possibly global stats (#16) for both unbox and mvm to see how many of each 49 pro ks combos were achieved.

Partially added in 0.9.6 for just mvm stats, potentially move MvM Tours to MvM Loot
Still need to add unbox info


[Question] Segmented source input?

Is it possible to implement lexer over a segement input (E.g. RopeSlice) ?
I found that there is a Source trait in logos, but I have no idea how to implement these methods over RopeSlice.
fn slice(&self, range: Range<usize>) -> Option<&Self::Slice>;
unsafe fn slice_unchecked(&self, range: Range<usize>) -> &Self::Slice;

Those 2 methods require returning a reference, not a reference-like-type.
For RopeSlice, I would expect using these approach:
impl<'a> Source<'a> for RopeSlice<'a> {
    type Slice = RopeSlice<'a>
    fn slice(&self, range: Range<usize>) -> Option<Self::Slice> {}
    unsafe fn slice_unchecked(&self, range: Range<usize>) -> Self::Slice {}
}

But this can not be done with current trait requirement.

Slices wouldn't be so bad and I could relax the types here, however for the Lexer to work on segmented input, it would need to be able to read Chunks of sequentially allocated memory, which might be tricky with segmented input (in case Lexer wants to quickly match the next 8 bytes, but there are only 4 left in current segment, f.e.).


WIP: Updates to generatorSetup docs

work in progress
Description
GeneratorSetup page did not match experience of trying to follow it. There are now two generator.jar files and these instructions referred to the old one which is now only used as part of the orchestrator one.
Changes
Reflect changes to jar files
Additional notes
Needs review for understanding of DH
Issue
None... yet

Extended by #1111


Support AM2301

It's possible to add support for AM2301 ?

I have this same issue...
If you look at Adafruit_DHT\common.py, you will see the following:
# Define sensor type constants.
DHT11  = 11
DHT22  = 22
AM2302 = 22
SENSORS = [DHT11, DHT22, AM2302]

As you can see, the AM2302 uses the same code (22) as the DHT22. The AM2301 should use the same code as the DHT11.
Try setting your Sensor type to DHT11, it should work.

According to the Data Sheets, the AM2301 and AM2302 use the same communication formula.
AM2301 Datasheet
AM2302 Datasheet
So you can specify AM2302 for a AM2301.


Cannot find name 'AggregateError'.ts(2304)

🔎 Search Terms
Cannot find name 'AggregateError'.ts(2304) AggregateError typescript
🕗 Version & Regression Information
<EMAIL_ADDRESS>⏯ Playground Link
No response
💻 Code
// Your code here

🙁 Actual behavior
With<EMAIL_ADDRESS>- in lib.es2022.error.d.ts get problems about this:
interface AggregateErrorConstructor {     new (         errors: Iterable<any>,         message?: string,         options?: ErrorOptions,     ): AggregateError;     (         errors: Iterable<any>,         message?: string,         options?: ErrorOptions,     ): AggregateError; }
I get found Cannot find name 'AggregateError'.ts(2304)

🙂 Expected behavior
Maybe missing include AggregateError interface?
Additional information about the issue
No response

What is your tsconfig looking like? Make sure your target is at least es2021.

What is your tsconfig looking like? Make sure your target is at least es2021.
my tsconfig here:
{
"compilerOptions": {
"module": "commonjs",
"declaration": true,
"removeComments": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"allowSyntheticDefaultImports": true,
"target": "es2022",
"sourceMap": true,
"outDir": "./dist",
"baseUrl": "./",
"incremental": true,
"allowJs": true
},
"exclude": ["node_modules", "dist"]
}

Btw, im using node version 22.3

Odd, if you are using "target": "es2022" without a "lib": [] override, then you shouldn't be getting an error, and I wasn't able to reproduce this with only the tsconfig you provided. If you set "target": "es2022" then we load es2022 by default, es2022 loads both es2022.error and es2021, and es2021 loads es2021.promise, which contains the definition for AggregateError.
Are you using tsc to build your project, or a third-party package that uses the TypeScript API to build, such as ngc, a webpack plugin, ts-node, etc. If so, I would recommend checking as to whether any of those packages have updates to be installed in the event the installed versions might have issues.
If a third-party build tool was not the issue, then can you try adding "lib": ["es2022.full"] to your "compilerOptions" in tsconfig.json? If that works, then something in your dependencies might be interfering with default lib detection. If that doesn't work, then try "lib": ["es2022.full", "es2021.promise"] as a workaround and report back.
You could also try running tsc with --listFilesOnly to print a list of all files in the compilation. If es2021.promise is in that list, then I'll need to follow up with additional steps to diagnose further. If es2021.promise is not in that list, then you would need to go through all of the files in that list that come from your dependencies to see if any dependency contains the text /// <reference no-default-lib="true"/>, as that would interfere with default lib detection.

Set "target": "es2022" works for me!

Sounds like this an external misconfiguration. Closing.


Formatting & integration test code cleanup

Applies gofmt -s to all Go files, autopep8/autoflake to all Python files, adds a .pylintrc file for integration tests, fixes lots of nits/warnings from pylint, turned comments in integration tests into docstrings.

Coverage remained the same at 89.711% when pulling 07f18bbb61d31ab07085980de82bb743a2456055 on cs/py-cleanups into 1742b3227642fa28f9d9719045fe33310ff65e12 on master.


Unable to define custom integrated terminal profile

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.61.2
OS Version: Windows 11, 21H2 (build 22000.348)

Steps to Reproduce:

settings.json
attempt to define custom workspace profile

{

	//"terminal.integrated.shell.windows": "C:\\Users\\zachd\\scoop\\shims\\ssh.exe",
	//"terminal.integrated.shellArgs.windows"<EMAIL_ADDRESS>
	"terminal.integrated.profiles.windows": {
		"pizero": {
			"path": "C:\\ProgramData\\scoop\\shims\\ssh.exe",
			"args"<EMAIL_ADDRESS>		}
	},
	"terminal.integrated.defaultProfile.windows": "pizero",
	"Lua.diagnostics.globals": [
		"parallel",
		"keys",
		"shell",
		"periphery"
	]
}

VSCode only allows the default shells and nothing else

ssh is infact located at that path

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

For me it the same, it does not work on both VSCode 1.63.0 and 1.64.0-insider versions.

I have a similar issue with version 1.63.1 on macos M1.
If I open vscode with source code from local folder, I expect the user settings to be processed first then the workspace in the .vscode subfolder
Neither if I set my profile in user or workspace the shell appears.

I also tried to create a custom workspace

reopened vscode from that workspace but still no terminals.

It is only when I open my source code in a remote containter (devcontainer or remote ssh host) that I get the workspace profiles processed correctly (with a caveat as I would expect the Remote settings to overwrite the workspace settings to be more specific to the remote environment(documentation does not mention the Remote in the inheritance process, will open another issue - https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence)

Can you enable trace logging and toggle the shared process and attach the logs when you launch/save the profile?

is that what you are looking for? This is what I get when I open the code-workspace. I tried to update the profile but the log (Shared) is not showing any activity

Open the command palette (ctrl or cmd shift p) toggle shared process. Then, command palette set log level trace.

open the command palette ctrl or cmd shift p
toggle shared process
command palette set log level - trace
do something or reload the window
share the logs


Replace common-types.ts with dependency on @silvermine/toolbox

npm run prepare and npm run test both run successfully after switching the dependency to @silvermine/toolbox

@lukelafountaine please fix the commit message so the build passes

Coverage decreased (-0.09%) to 99.192% when pulling c95224950d662e5debc1835093c85d1dab6518ef on lukelafountaine:remove-common-types into 149d5609331ae65ac0bac4cc83b678a78239f553 on silvermine:master.


move to preview4

PR Summary
Cherrypicked change to enable CI on this branch.
Update build to 3.0-Preview.4
Update versioning to 7.0.0
PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Change is not breaking
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

closing an opening the PR to trigger CI

cherry-picked the change which enables CI from master and pushed to this branch.

Seems like the big blocking issue is that Add-Type is broken

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/testing-guidelines/CodeCoverageAnalysis.md.https://codecov.io/gh/PowerShell/PowerShell should work
retry of URL failed with error:
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 113
113:                                 throw "retry of URL failed with error: $($_.Message)"

@PoshChan please retry static

@SteveL-MSFT, successfully started retry of PowerShell-CI-static-analysis

@SteveL-MSFT, your last commit had 9 failures in PowerShell-CI-macos
(These are 5 of the failures)
Validate Update-Help from the Web for one PowerShell Core module..Validate Update-Help for module 'Microsoft.PowerShell.Core' with scope as 'False'
Expected 1, but got 0.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 181
181:     $helpFilesInstalled.Count | Should -Be $expectedHelpFiles.Count

Send-MailMessage.Error occurred in Describe block
Cannot bind argument to parameter 'Path' because it is null.
At /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1:11 char:30

Validate 'Save-Help -DestinationPath for one PowerShell Core modules..Validate Save-Help for the 'Microsoft.PowerShell.Core' module
Expected 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.zip', because Save-Help for  should download 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.zip', but got $null.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 333
333:     $compressedFile | Should -Be $expectedCompressedFile -Because "Save-Help for $module should download '$expectedCompressedFile'"

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly '/tmp/4dd728f4-93b7-46e4-9299-f7c773ce4676/file.txt', but got /.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected '/tmp/4dd728f4-93b7-46e4-9299-f7c773ce4676/not-a-file', but got /.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

@SteveL-MSFT, your last commit had 7 failures in PowerShell-CI-linux
(These are 5 of the failures)
Send-MailMessage.Error occurred in Describe block
Cannot bind argument to parameter 'Path' because it is null.
At /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1:11 char:30

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly '/tmp/f4322734-1a63-45ca-b8f2-1b6f9b40eab3/file.txt', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected '/tmp/f4322734-1a63-45ca-b8f2-1b6f9b40eab3/not-a-file', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to a directory
Expected exactly '/tmp/f4322734-1a63-45ca-b8f2-1b6f9b40eab3/subdir', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 476
476:             $link.Target[0] | Should -BeExactly $real.ToString()

Measure-Object.Numeric tests.Should be able to return all the statitics for given values
Expected strings to be the same, but they were different.
Expected length: 16
Actual length:   18
Strings differ at index 16.
Expected: '3.02765035409749'
But was:  '3.0276503540974917'
---------------------------^
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Measure-Object.Tests.ps1: line 185
185:             ($result.StandardDeviation).ToString()  | Should -Be '3.02765035409749'

@SteveL-MSFT, your last commit had 324 failures in PowerShell-CI-windows
(These are 5 of the failures)
Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\63f2a62c-fd2a-4ea7-8e63-e734f5030708\file.txt', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected 'C:\Users\VSSADM~1\AppData\Local\Temp\63f2a62c-fd2a-4ea7-8e63-e734f5030708\not-a-file', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a directory symbolic link to a directory
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\63f2a62c-fd2a-4ea7-8e63-e734f5030708\subdir', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 486
486:             $link.Target[0] | Should -BeExactly $real.ToString()

Dot-source operator is not allowed in modules on locked down systems that export functions with wildcards.Verifies that a classes only module with dot-source and with using directive loads successfully
The term 'PublicUsingFn' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Security\ConstrainedLanguageModules.Tests.ps1: line 426
426:                 $result = PublicUsingFn

Import trusted manifest files in system lockdown mode.Verifies that trusted manifest with nested modules and no extension module exports explicit function
Cannot load the module 'C:\Users\VSSADM~1\AppData\Local\Temp\a232a9cf-e1dd-4967-93c0-c4b460e52cde\ImportTrustedManifestWithNestedModsAndNoExtNoFnExport_System32' because the module nesting limit has been exceeded. Modules can only be nested to 10 levels. Evaluate and change the order in which you are loading modules to prevent exceeding the nesting limit, and then try running your script again.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Security\ConstrainedLanguageModules.Tests.ps1: line 1214
1214:                 $module = Import-Module -Name $manifestFileName -Force -PassThru

@PoshChan please retry windows

@SteveL-MSFT, successfully started retry of PowerShell-CI-Windows

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-macos
Send-MailMessage.Error occurred in Describe block
Cannot bind argument to parameter 'Path' because it is null.
At /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1:11 char:30

@SteveL-MSFT, your last commit had 389 failures in PowerShell-CI-windows
(These are 5 of the failures)
Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\fa7b8f20-a1bb-43eb-8ba6-4be3919a51a8\file.txt', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected 'C:\Users\VSSADM~1\AppData\Local\Temp\fa7b8f20-a1bb-43eb-8ba6-4be3919a51a8\not-a-file', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a directory symbolic link to a directory
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\fa7b8f20-a1bb-43eb-8ba6-4be3919a51a8\subdir', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 486
486:             $link.Target[0] | Should -BeExactly $real.ToString()

Connection.Test connection to local host port 80
Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Test-Connection.Tests.ps1: line 271
271:         Test-Connection '<IP_ADDRESS>' -TCPPort $WebListener.HttpPort | Should -BeTrue

Web cmdlets tests using the cmdlet's aliases.Execute Invoke-WebRequest
No connection could be made because the target machine actively refused it.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Utility\WebCmdlets.Tests.ps1: line 3246
3246:         $result = Invoke-WebRequest $uri

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-linux
Send-MailMessage.Error occurred in Describe block
Cannot bind argument to parameter 'Path' because it is null.

At /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1:11 char:30

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly '/tmp/7d27d065-4c2c-445a-902f-779e46f06266/file.txt', but got /.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected '/tmp/7d27d065-4c2c-445a-902f-779e46f06266/not-a-file', but got /.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to a directory
Expected exactly '/tmp/7d27d065-4c2c-445a-902f-779e46f06266/subdir', but got /.
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 476
476:             $link.Target[0] | Should -BeExactly $real.ToString()

Measure-Object.Numeric tests.Should be able to return all the statitics for given values
Expected strings to be the same, but they were different.
Expected length: 16
Actual length:   18
Strings differ at index 16.
Expected: '3.02765035409749'
But was:  '3.0276503540974917'
---------------------------^
at <ScriptBlock>, /Users/vsts/agent/2.150.0/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Measure-Object.Tests.ps1: line 185
185:             ($result.StandardDeviation).ToString()  | Should -Be '3.02765035409749'

@SteveL-MSFT, your last commit had 389 failures in PowerShell-CI-windows
(These are 5 of the failures)
Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\3715e842-db9c-4d4c-95fe-059a78787a5d\file.txt', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected 'C:\Users\VSSADM~1\AppData\Local\Temp\3715e842-db9c-4d4c-95fe-059a78787a5d\not-a-file', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a directory symbolic link to a directory
Expected exactly 'C:\Users\VSSADM~1\AppData\Local\Temp\3715e842-db9c-4d4c-95fe-059a78787a5d\subdir', but got C.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1: line 486
486:             $link.Target[0] | Should -BeExactly $real.ToString()

Connection.Test connection to local host port 80
Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Test-Connection.Tests.ps1: line 271
271:         Test-Connection '<IP_ADDRESS>' -TCPPort $WebListener.HttpPort | Should -BeTrue

Web cmdlets tests using the cmdlet's aliases.Execute Invoke-WebRequest
No connection could be made because the target machine actively refused it.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Utility\WebCmdlets.Tests.ps1: line 3246
3246:         $result = Invoke-WebRequest $uri

@SteveL-MSFT, your last commit had 7 failures in PowerShell-CI-linux
(These are 5 of the failures)
Send-MailMessage.Error occurred in Describe block
Cannot bind argument to parameter 'Path' because it is null.
At /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1:11 char:30

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create symbolic link to file
Expected exactly '/tmp/b0a9da78-40a0-4834-b787-b81cc84e259e/file.txt', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 455
455:             $link.Target[0] | Should -BeExactly $real.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to nothing
Expected '/tmp/b0a9da78-40a0-4834-b787-b81cc84e259e/not-a-file', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 464
464:             $link.Target[0] | Should -Be $nonFile.ToString()

Hard link and symbolic link tests.New-Item and hard/symbolic links.New-Item can create a symbolic link to a directory
Expected exactly '/tmp/b0a9da78-40a0-4834-b787-b81cc84e259e/subdir', but got /.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1: line 476
476:             $link.Target[0] | Should -BeExactly $real.ToString()

Measure-Object.Numeric tests.Should be able to return all the statitics for given values
Expected strings to be the same, but they were different.
Expected length: 16
Actual length:   18
Strings differ at index 16.
Expected: '3.02765035409749'
But was:  '3.0276503540974917'
---------------------------^
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Utility/Measure-Object.Tests.ps1: line 185
185:             ($result.StandardDeviation).ToString()  | Should -Be '3.02765035409749'


refactor: remove catalog_to_schema.py and extractors.py in portex

Task linked: CU-2kj6uh0 移除 portex/extractors.py 与 portex/catalog_to_schema.py


docker: failed to register layer: Error processing tar file(exit status 1)

Command run on AWS EC2 instance to run docker on local instance
nextflow run /home/ubuntu/my-pipelines/nf-core/rnaseq-nfcore/rnaseq --reads '/data/dataset/SRR9667733/*_R{1,2}.fastq.gz.1' --genome GRCh37 -profile docker
It started with out issues
Jul-15 23:36:33.141 [main] INFO  nextflow.Nextflow - Run Name          : backstabbing_hopper
Reads             : /data/dataset/SRR9667733/*_R{1,2}.fastq.gz.1
Data Type         : Paired-End
Genome            : GRCh37
Strandedness      : None
Trimming          : 5'R1: 0 / 5'R2: 0 / 3'R1: 0 / 3'R2: 0
Aligner           : STAR
STAR Index        : s3://ngi-igenomes/igenomes//Homo_sapiens/Ensembl/GRCh37/Sequence/STARIndex/
GTF Annotation    : s3://ngi-igenomes/igenomes//Homo_sapiens/Ensembl/GRCh37/Annotation/Genes/genes.gtf
BED Annotation    : s3://ngi-igenomes/igenomes//Homo_sapiens/Ensembl/GRCh37/Annotation/Genes/genes.bed
Save prefs        : Ref Genome: No / Trimmed FastQ: No / Alignment intermediates: No
Max Resources     : 128 GB memory, 16 cpus, 10d time per job
Container         : docker - nfcore/rnaseq:1.3
Output dir        : ./results
Launch dir        : /home/ubuntu/my-pipelines/nf-core/rnaseq-nfcore/rnaseq
Working dir       : /home/ubuntu/my-pipelines/nf-core/rnaseq-nfcore/rnaseq/work
Script dir        : /home/ubuntu/my-pipelines/nf-core/rnaseq-nfcore/rnaseq
User              : ubuntu
Config Profile    : docker
However I get the following error. I am not sure if it runs out of space on the EC2 instance or there are other issue with docker.

See 'docker run --help'.

I just needed more memory on the root drive. It was resolved.

Hi @gtg269c , I am attempting the same, could you share your aws/container details in your nextflow.config file for me to see what they need to look like? Thx


⚠ Bofrost.at has degraded performance

In 051fb7c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1048 ms

Resolved: Bofrost.at performance has improved in 8f266c9 after 6 minutes.


User friendly UX for Unity Client

Currently the Unity client UX is pretty broken (and hidden for HoloLens).
Loading, connection properties, and user login will all need to be added shortly to keep it operational with the OAuth identity work.

I'm going to spend some time soon writing a brief description of what we want to see here.
Also something to keep in mind: when a user is authenticated, and authentication expires, the user should be able to handle this gracefully


daq gauge

Gauge value font-size does not scale with the object size therefore covers over the dial numbers when the size is reduced for display on mobile device.

Hi, this issue tracker is for issues with the codebase behind https://pypi.org itself, not the projects hosted on PyPI.
You should report this issue to the tracker for the project in question instead.


event-delegation.js:44 Uncaught TypeError: Cannot read property '__widget' of null

event-delegation.js:44 Uncaught TypeError: Cannot read property '__widget' of null
   (anonymous function) @ event-delegation.js:44
   batchUpdate @ update-manager.js:96
   (anonymous function) @ event-delegation.js:25

It looks this error happens when destroying a widget while in the process of handling an event.

I'm experimenting with some fixes for this issue.


support 8.0.3

support 8.0.3

The VMware community Fling currently only supports up to 8.02, and on 8.03 it appears to break.
See here:
https://community.broadcom.com/vmware-code/discussion/lastest-for-u3-usb-network-native-driver-for-esxi-not-work#bm3ba19dfe-5fef-4d8f-888a-67696903b9d0
As a workaround, if you need USB NIC support you can stay with 8.02, or if you dont need USB NIC support, comment out the following script lines and it will build fine.
$usbFling = "ESXi80U2-VMKUSB-NIC-FLING-67561870-component-22416446.zip"
and
Add-EsxSoftwarePackage -ImageProfile $newProfile -SoftwarePackage "vmkusb-nic-fling" -Force
I'll update the script as and when an updated driver Fling is released.

I just noticed there is an updated Fling for 8.0U3, so I've addeded this and its now working for 8.0U3. See script comments for Broadcom Fling download links to either upgrade in future or build lower versions .


Dev

Hello @sofianelounici! Thanks for opening this PR.

In the file examples/marklearn/malware_detection_dawn.py:

Line 49:39: E226 missing whitespace around arithmetic operator

In the file examples/marktorch/mnist_dawn.py:

Line 50:35: E226 missing whitespace around arithmetic operator

In the file examples/marktorch/mnist_selected.py:

Line 42:1: W293 blank line contains whitespace

In the file mlmodelwatermarking/marktorch.py:

Line 667:37: E226 missing whitespace around arithmetic operator

Do see the Hitchhiker's guide to code style


Consider converting all single-variant extractors/loaders to suppot multiple variants

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/86
Originally created by @tayloramurphy on 2021-06-03 19:53:24

Per https://meltano.com/docs/contributor-guide.html#making-a-custom-plugin-discoverable when there is only a single variant, the definition can be embedded in the plugin definition. I think while we still have a small number of out of the box connectors that it would be good to convert these to the variants array so that we have consistency across all extractors and loaders. This will save us trouble in validation with the JSON schema and enable us to easily add variants.
We should do this prior to https://gitlab.com/meltano/hub/-/issues/35

View 7 previous comments from the original issue on GitLab


Use Builder::setAttribute whenever possible

Closes #303
Whenever attributes are set on a span in connection to its creation, use the Builder::setAttribute method instead of Span::setAttribute.
I have made changes whenever attributes are set in the same region of code as the span creation. I have not tried to follow every code path to try to find cases where attribute setting could have been moved to initialization instead.

I will merge this as soon as the intensely sporadic failures (not related to this PR) are fixed by #354, and I can update this PR to get a clean build.


dwx_zeroMQ_server_v2.0.1_RC8 fail to compile

when i compile the file i face below errors:
'create' - function not defined	GlobalVariable.mqh	211	34
'::' - unexpected token	GlobalVariable.mqh	211	32

when i compile the file i face below errors:
'create' - function not defined GlobalVariable.mqh 211 34
'::' - unexpected token GlobalVariable.mqh 211 32

I have the exact same problem with dwx_zeroMQ_server_v2.0.1_RC8 and dwx_zeroMQ_server_v2.0.2_RC1
I tried to compile GlobalVariable.mqh separately and everything looks fine, but I can't compile the desired mq4 script.

I ran into the same issue.
I resolved this by updating the dependencies from the mql-zmq repo directly (https://github.com/dingmaotu/mql-zmq).
Good luck!

I ran into the same issue.
I resolved this by updating the dependencies from the mql-zmq repo directly (https://github.com/dingmaotu/mql-zmq).
Good luck!

It works fine now, thank you.
should we submit an issue for this so we can resolve this issue in this repo?

I ran into the same issue.
I resolved this by updating the dependencies from the mql-zmq repo directly (https://github.com/dingmaotu/mql-zmq).
Good luck!

It works fine now, thank you.
should we submit an issue for this so we can resolve this issue in this repo?

i updated the code and now that works fine. thanks for your help.

@farhadc7 maybe we should leave this issue open until the authors update the dependencies within the repo itself.


Deploying to artifactory using 'groupId' path

I've created a pom.xml like this:
<groupId>com.xxx.prj.helm</groupId>
<artifactId>ui</artifactId>
<packaging>helm</packaging>
..
<properties>
     <release.url>https://artifactory.xxx.com/artifactory/hlm-all/</release.url>
     <snapshot.url>....</snapshot.url>
 </properties>
...
<plugin>
 <groupId>com.kiwigrid</groupId>
 <artifactId>helm-maven-plugin</artifactId>
 <version>5.6</version>
 <extensions>true</extensions>       <!-- for custom packaging -->
 <configuration>
     <chartVersion>${project.version}</chartVersion>
     <chartDirectory>${project.build.directory}</chartDirectory>

     <useLocalHelmBinary>true</useLocalHelmBinary>
     <autoDetectLocalHelmBinary>true</autoDetectLocalHelmBinary>
     <addDefaultRepo>false</addDefaultRepo>
     <uploadRepoStable>
         <name>hlm-public</name>
         <url>${release.url}</url>
         <type>ARTIFACTORY</type>
     </uploadRepoStable>
     <uploadRepoSnapshot>
         <name>hlm-private</name>
         <url>${snapshot.url></url>
         <type>ARTIFACTORY</type>
     </uploadRepoSnapshot>

 </configuration>
</plugin>

Settings.xml is correctly configured.
Then doing mvn clean deploy  the plugin tries to deploy to:
https://artifactory.xxx.com/artifactory/hlm-all/ instead of using groupId path and deploying to:
https://artifactory.xxx.com/artifactory/hlm-all/com/xxx/prj/helm/ui/${project.version}/ as I think it should.

Is there a way to force it to deploy to the 'groupId' path other than specifying the whole path in the <release.url> parameter?
Is it possible to remove <url> attribute (from <uploadRepoStable> tag) so it can only use the <name>attribute to correctly identify the repository in the settings.xml in order to do a deploy?

Hi @icstreispe
PR raised: https://github.com/kiwigrid/helm-maven-plugin/pull/134

In order to deploy using groupId in repo path, add useGrouId inside repo configuration. e.g.:
     <uploadRepoStable>
         <name>hlm-public</name>
         <url>${release.url}</url>
         <type>ARTIFACTORY</type>
         <useGroupId>true</useGroupId>
     </uploadRepoStable>

I have just checked inside my organization - works like a charm. 😉

ok great
how about the second issue?

ok great
how about the second issue?

I'm not sure that such feature gives much conveniency, since you can always set property in settings.xml and reference it from pom.xml.
To my mind, it will only give pom.xml of smaller size.
But, if you insist, I'll take a look.

yes it will keep pom.xml smaller/cleaner
if its simple to do it ok, if its too complicated we can forget it....

yes it will keep pom.xml smaller/cleaner
if its simple to do it ok, if its too complicated we can forget it....

I consider to raise separate issue for this.

ok

Please close this issue.
I've filed follow-up: https://github.com/kiwigrid/helm-maven-plugin/issues/149


WSL 2 - Custom Kernel - Process exited with code<PHONE_NUMBER>

Please fill out the below information:

Your Windows build number:  (Type ver at a Windows Command Prompt)
Windows Insider 19013
Microsoft Windows [versão 10.0.19013.1000]

I trying to run a custom vmlinux with WSL2
After more less a minute the return : "process exited with code<PHONE_NUMBER>"
Is there any way to get kernel logs with earlycon or earlyprint on WSL2? I fear that without these logs I will not be able to solve a bug during the boot process of my Kernel
I try to get some info with the saved lxcore_kernel.etl but nothing on events logs
thanks in advance!

I fixed same problem by "netsh winsock reset"

had the same issue, had docker installed with wsl2 feature enabled

I fixed same problem by "netsh winsock reset"

uninstalling docker and running "netsh winsock reset" solved it for me

/dupe #4929 #4364

@microhobby
Run netsh winsock reset as Administrator, then reboot your computer.
The result like below:
❯ netsh winsock reset

Sucessfully reset the Winsock Catalog.
You must restart the computer in order to complete the reset.

This was fixed by Kernel Mainline, it is now possible to use a custom kernel with the source of Linus Torvalds: https://youtu.be/N6b7DZKbvEE

Great! Nonetheless, there are still some troubles to migrate to the new kernel version. I don't know if Microsoft has a new solution. . .

If you are having this problem caused by updating the system, you can try to restore the previous version of Windows 10 in the settings. This method works for me.

the solution is to update the kernel https://docs.microsoft.com/en-us/windows/wsl/wsl2-kernel

@godie007 Thx, It work 🙇

the solution is to update the kernel https://docs.microsoft.com/en-us/windows/wsl/wsl2-kernel

Even though I already had the newest version installed, it solved the problem

I had my  docker disabled on startup. Opening it up before starting the wsl2 solved the problem to me.

If someone comes 'till here and nothing worked like I did, know that I had the same error, and I then noticed that I had mistakenly deleted my custom kernel file (like an idiot), and WSL couldn't find it. So changing back the wslconfig file to not use a custom kernel might be the solution.

If someone comes 'till here and nothing worked like I did, know that I had the same error, and I then noticed that I had mistakenly deleted my custom kernel file (like an idiot), and WSL couldn't find it. So changing back the wslconfig file to not use a custom kernel might be the solution.

@spersico Can you explain that a little bit more? Where can I find the wslconfig file? Under C:\User{User}.wslconfig? And how can I determine not to use a custom kernel? Thanks in advanded.

@MethodJules in my case it's on C:\Users\<MY_USER>\.wslconfig
By default it uses the normal, non-custom kernel, I just removed the line which pointed to my kernel file, in my case, that was
kernel=C:\\Users\\SP\\bzImage


fix: If the user has delete permission on the workspace, allow the user to delete the workspace and also delete the default roles (without permission)

Fixes #18216
Today, the workspace delete assumes that the user is a member of the workspace (which is indeed true for community editition). But with Granular Access Control, a non member could also be given the permission to delete the workspace. In that case, the user would not have access to the default workspace roles (since she isn't a member). During delete, the operation includes both delete of the workspace and doing a cleanup of default roles to which the user doesn't have any permission. To evade this, we are just checking for the user having the permission to delete the workspace. If she has the required permission on the workspace, we are letting the cleanup of the default roles without permission.

/ok-to-test sha=0b8459d

/ok-to-test sha=cd24dd8


Spin lock with exponential backoff

RedissonLock uses pubsub mechanism to get notified about changes to lock. According to the cluster spec (https://redis.io/topics/cluster-spec), currently messages are simply broadcasted to all nodes in the cluster. It makes this lock inefficient in clusters with more than 5 nodes.
It would be great to have a spin lock with exponential backoff, because it works well with Redis's horizontal scaling.
If the idea seems fine to you, I can prepare a PR in a few days, just let me know. If not - sorry for taking your time, feel free to close the feature request.
Best regards,
Danila Varatyntsev

It makes this lock inefficient in clusters with more than 5 nodes.

Can you clarify here? I don't understand how it affects lock.

It makes this lock inefficient in clusters with more than 5 nodes.

Can you clarify here? I don't understand how it affects lock.

It doesn't affect lock itself, it affects cluster performance.
We reached a network throughput limit on AWS Redis cluster with 20 nodes, when we tried to aquire and release more than 1.000.000 locks per minute, because messages are distributed to all nodes. When network throughput reaches the limit, Redis engine CPU increases to 100% and service fails to process request. Increasing cluster size makes this problem to happen even earlier, because messages are sent to more nodes. And we couldn't use a cluster with fewer number of nodes, because we used the same cluster for other non-pubsub requests.

It doesn't affect lock itself, it affects cluster performance.
We reached a network throughput limit on AWS Redis cluster with 20 nodes, when we tried to aquire and release more than 1.000.000 locks per minute, because messages are distributed to all nodes. When network throughput reaches the limit, Redis engine CPU increases to 100% and service fails to process request. Increasing cluster size makes this problem to happen even earlier, because messages are sent to more nodes. And we couldn't use a cluster with fewer number of nodes, because we used the same cluster for other non-pubsub requests.

Here antirez wrote that following:
In the current naive implementation every message is sent to every node, which is quite an overhead, but by limiting the number of instances to 3/4, the overhead is acceptable

Here antirez wrote that following:
In the current naive implementation every message is sent to every node, which is quite an overhead, but by limiting the number of instances to 3/4, the overhead is acceptable

Yes, that lock could be interesting feature. Different backoff algorithms could be offered, similar to described in this article https://aws.amazon.com/ru/blogs/architecture/exponential-backoff-and-jitter/

Yes, that lock could be interesting feature. Different backoff algorithms could be offered, similar to described in this article https://aws.amazon.com/ru/blogs/architecture/exponential-backoff-and-jitter/

Best implementation is to make base RedissonLock and RedissonSpinLock extending from BaseLock class.

Best implementation is to make base RedissonLock and RedissonSpinLock extending from BaseLock class.

merged

merged


Improve SEO Investigation

Several SEO Tools should be run against the site.
Issues should be created in priority for all of the SEO improvements that can be made.

Investigation Complete.
Lots of improvements Identified.
Issues created for each one and prioritised.
They can be found under the SEO Overhaul Milestone.


Script pipeline processor is missing

Elastic.Clients.Elasticsearch version: 8.11.0
It looks like the script processor is not generated:
https://github.com/elastic/elasticsearch-net/tree/main/src/Elastic.Clients.Elasticsearch/_Generated/Types/Ingest
Docs: https://www.elastic.co/guide/en/elasticsearch/reference/current/script-processor.html

Hi @f1nzer, Thanks for reporting! There are currently a bunch of processors missing from the specification. The issue is tracked in the specification repository: https://github.com/elastic/elasticsearch-specification/issues/2231


Request for a more verbose README

While the project seems very exciting, the README seems to lack details as the main landing page for the project.

This would be really good for developers. ☺

Thank you :)


Ingress101.md is outdated

kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/mandatory.yaml

The URL is a 404.

Correct URL is https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.7.0/deploy/static/provider/cloud/deploy.yaml. Also, kubectl create ingress demo --class=nginx --rule="grundbuch-test.eu/*=demo:80" just results a 503 error. The entire Ingress documentation is outdated.

@gauravrattan Would you like to work on this?

Sure @ajeetraina


Add Minio

Add Minio to list of software exposing Prometheus metrics

Thank for sharing. I'm not sure this really classifies as directly instrumented, most of your metrics are coming from your own internal instrumentation system rather than Prometheus instrumentation. You can list this as something exposing Prometheus metrics, and you also need to satisfy the DCO.
minio_server_start_time_seconds is also redundant with the standard process_start_time_seconds.

Thanks for the info! I have updated the PR.
We'll take a look at the redundancy you pointed out.

Thanks!


Request to join the organisation

I would like to join the organisation for contribution

Hi @akshitagupta15june, apologies if we missed this - you are more than welcome to participate - there's no need to formally join FINOS. Check out our http://finos.org/get-involved page and / or pick a project to contribute to!


optimize:  add the change records folder

Ⅰ. Describe what this PR did
add a change log file for the merge and author information record of each pr
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3397 (ca59e74) into develop (2bd39c9) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3397      +/-   ##
=============================================
- Coverage      51.57%   51.44%   -0.14%
+ Complexity      3332     3329       -3
=============================================
  Files            616      616
  Lines          20198    20172      -26
  Branches        2531     2484      -47
=============================================
- Hits           10418    10377      -41
+ Misses          8737     8728       -9
- Partials        1043     1067      +24

Impacted Files
Coverage Δ
Complexity Δ

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 28 more


Yunhee/join quiz backend

I added some functions to start the session and check if they started or not to join. Please check and if it conflicts or wrong, tell me.

closed by request


hide/show column

I need to hide and show the column dynamically based on the header values. What is the best way to approach.

You can use $('.c1').hide(); for example, but you must be careful to hide the headers as well. jExcel is very close to a pure HTML table, so you can apply css. But, this depends on what you really want to do.


Fix debug build by adding compat.c to tests

Linking of tests that needed something from compat.c failed.

LGTM.
On which platform did you experience a build issue?

It also failed linking test_vecdeque and test_vector if I recall correctly, so added a more general and future-proof solution.
Found it on macOS Catalina.


Upgrade to Angular 5?

Are there any plans to bump the angular dependencies in package.json to include v5?

I'm on it actually.

Is there an ETA for this? Have you started work on it @dimpu ?

@NikoRoberts Ya I'm working on it. Maybe by week after next week.

Hi Guys. Now it supports ng 5 too.

great, thank you 👏


Specify maxItems for operations in GridCellOperatorResponse

On the tcl4 branch, the maxItems specification is missing for the operations field in GridCellOperatorResponse in the swaggerhub yaml. It was noted that it may have been missing due to an issue with adding a maxItems spec on an array of objects nested in an object, but it looks like we were able to specify maxItems for operators in GridCellMetadataResponse.
@hi-kevin mentioned that this number should be 1000.

There is no validation done on the platform to limit the number of operations. Swaggerhub won't support documenting it legitimately. I suggest the real limit of the number of operations for a USS in a GridCell becomes a requirement out of TCL4.