When I use localhost connect, if I use the IP it doesn't connect

I run the server and the client in the same computer, for testing. If in the client I use the address localhost it works, but if I use the IP of the computer "<IP_ADDRESS>" it fails. The error message is this:
D0725 20:25:53.870862 Grpc.Core.Internal.NativeExtension gRPC native library loaded successfully.
D0725 20:25:53.872652 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "grpclb"
D0725 20:25:53.872779 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "cds_experimental"
D0725 20:25:53.872871 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "eds_experimental"
D0725 20:25:53.872962 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "lrs_experimental"
D0725 20:25:53.873053 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "priority_experimental"
D0725 20:25:53.873118 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "weighted_target_experimental"
D0725 20:25:53.873181 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "xds_routing_experimental"
D0725 20:25:53.873249 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "pick_first"
D0725 20:25:53.873311 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\lb_policy_registry.cc:39: registering LB policy factory for "round_robin"
D0725 20:25:53.873377 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\resolver\dns\c_ares\dns_resolver_ares.cc:504: Using ares dns resolver
I0725 20:25:55.903532 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\subchannel.cc:1033: Connect failed: {"created":"@1595701555.902000000","description":"OS Error","file":"T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\lib\iomgr\tcp_client_windows.cc","file_line":105,"os_error":"Unable to retrieve error string","syscall":"ConnectEx","wsa_error":10061}
I0725 20:25:55.904211 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\subchannel.cc:970: Subchannel<PHONE_NUMBER>801D70: Retry immediately
I0725 20:25:55.904411 0 T:\src\github\grpc\workspace_csharp_ext_windows_x64\src\core\ext\filters\client_channel\subchannel.cc:997: Failed to connect to channel, retryin

It seems that the channel is created, because it is the subchannel<PHONE_NUMBER>801D70, but for some reason can't get the response from the server.
The code of the server is this:
const int miPort = 5001;

                var cacert = File.ReadAllText("Keys/ca.crt");
                var cert = File.ReadAllText("Keys/server.crt");
                var key = File.ReadAllText("Keys/server.key");

                var keypair = new KeyCertificatePair(cert, key);
                var sslCreds = new SslServerCredentials(new List<KeyCertificatePair>
                                    {
                                        keypair
                                    }, cacert, false);

                Server server = new Server()
                {
                    Services = { Gestor.BindService(new GestorAplicacionesService()) },
                    //Ports = { new ServerPort("<IP_ADDRESS>", miPort, sslCreds) },
                    Ports = { new ServerPort("localhost", miPort, sslCreds) },
                };
                server.Start();
                Console.WriteLine("Started server on port " + miPort);
                server.ShutdownTask.Wait();

The code of my client is this:

                var miCaCertificate = File.ReadAllText("Keys/ca.crt");
                var miClientCertificate = File.ReadAllText("Keys/client.crt");
                var miClientPrivateKey = File.ReadAllText("Keys/client.key");

            var keypair = new KeyCertificatePair(_clientCertificate, _clientPrivateKey);
            var sslCreds = new SslCredentials(_caCertificate, keypair);

            var channel = new Channel(_serviceAddress, _port, sslCreds);
            var client = new Gestor.GestorClient(channel);

            await client.MiSaludoAsync();

The certificates works, because with localhost it works, but this is the script that I use to create a self signed certificates with OpenSSL:
# Generate valid CA
openssl genrsa -passout pass:1234 -des3 -out ca.key 4096
openssl req -passin pass:1234 -new -x509 -days 365 -key ca.key -out ca.crt -subj  "/C=SP/ST=Spain/L=Valdepenias/O=Test/OU=Test/CN=Root CA"

# Generate valid Server Key/Cert
openssl genrsa -passout pass:1234 -des3 -out server.key 4096
openssl req -passin pass:1234 -new -key server.key -out server.csr -subj  "/C=SP/ST=Spain/L=Valdepenias/O=Test/OU=Server/CN=localhost"
openssl x509 -req -passin pass:1234 -days 365 -in server.csr -CA ca.crt -CAkey ca.key -set_serial 01 -out server.crt

# Remove passphrase from the Server Key
openssl rsa -passin pass:1234 -in server.key -out server.key

# Generate valid Client Key/Cert
openssl genrsa -passout pass:1234 -des3 -out client.key 4096
openssl req -passin pass:1234 -new -key client.key -out client.csr -subj  "/C=SP/ST=Spain/L=Valdepenias/O=Test/OU=Client/CN=localhost"
openssl x509 -passin pass:1234 -req -days 365 -in client.csr -CA ca.crt -CAkey ca.key -set_serial 01 -out client.crt

# Remove passphrase from Client Key
openssl rsa -passin pass:1234 -in client.key -out client.key

pause

When using secure connection, the name the client uses for the target need to match what's in the certificate.
Example:

I want to connect to a server and I use a certificate to verify that I'm connected to the right server (this is how TLS works) to avoid man in the middle attack. The only way to enforce that is that the URL of the server I'm using (e.g I'm connecting to URL server on URL "foo.bar") needs to match the name of the server in the certificate (e.g "foo.bar").
in your case you're calling a server with IP address (xx.yy.zz.uu) but you expect the IP address to match what's in the certificate (you specify canonical name of the server is /CN=localhost) - which is not the case. That's why the connection fails.


[oadp-1.3] fix: 4.15 CI error with restart policy

Why the changes were made
Fix CI for OCP 4.15+ as done in https://github.com/openshift/oadp-operator/pull/1365
How to test the changes made
Check CI logs, no restartPolicy errors should happen.

/retest

/retest

Majority of failures were due to "The API Server may have been down" (and I also saw our normal flake and error updating status for volume snapshot content snapcontent, which is planed to be fixed in the future). Should we override?

Think it's safe to override. Unlikely to introduce bugs in this PR.


nixos/deluge: add user/group/openFirewall opts and extraction packages to path

Motivation for this change
This PR adds configuration options to the Deluge module that allows
configuration of the user and group that the deluged and delugeweb
daemons run as. It also adds a openFirewall option for the deluge web
interface. Further, it adds extraction utilities used by Deluge's built-in
"Extractor" plugin to the PATH so that Deluge doesn't error and behave
strangely when the plugin is enabled and it can't find them.
I've confirmed this works by importing the module in my local configuration.
cc @Infinisil (reviewed the previous change to the Deluge module)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@Infinisil is there anything else I need to do to see this merge?


SQL error for logging url suggestions

I got this SQL error when logging url suggestions:
`Geta.NotFoundHandler.Data.SqlDataExecutor: Error: An error occurred in the ExecuteSQL method with the following sql: INSERT INTO [dbo].[NotFoundHandler.Suggestions]
(Requested, OldUrl, Referer)
VALUES
(@requested, @oldurl, @referer)
System.ArgumentException: The SqlParameter is already contained by another SqlParameterCollection.
at Microsoft.Data.SqlClient.SqlParameterCollection.Validate(Int32 index, Object value)
at Microsoft.Data.SqlClient.SqlParameterCollection.Add(Object value)
at Geta.NotFoundHandler.Data.SqlDataExecutor.CreateCommand(SqlConnection connection, String sqlCommand, IDbDataParameter[] parameters)
at Geta.NotFoundHandler.Data.SqlDataExecutor.ExecuteNonQuery(String sqlCommand, IDbDataParameter[] parameters)`

Ok I think 19 days was a long time to be open for such a breaker and simple fix, so I thought to my self why not make a first ever contribution to open source.
@valdisiljuconoks Do you think it would be possible to get the fix in asap and get it release to the nuget feed?

Awesome you took the courage! 😁🤘
Running internal review...


Add CTC loss option in zipformer recipe

This PR adds CTC loss option in the new zipformer recipe. Now train.py supports:

transducer loss (default), with --use-transducer=True --use-ctc=False
ctc loss, with --use-transducer=False --use-ctc=True
transducer loss & ctc loss, with --use-transducer=True --use-ctc=True

The change dose not cause conflicts with already trained model.

Training with both transducer loss and CTC loss, with option --use-transducer True --use-ctc True

transducer head, epoch-40-avg-16

greedy-search
modified-beam-search
fast-beam-search

2.24, 5.01
2.19, 5.03
2.2, 4.98

CTC head, epoch-40-avg-16

ctc-decoding
1best
nbest
nbest-rescoring
whole-lattice-rescoring

2.4, 5.66
2.46, 5.11
2.46, 5.11
2.37, 4.93
2.37, 4.88

@marcoyang1998 has trained the zipformer with CTC loss alone, getting 2.62, 6.14 at epoch-90-avg-38.

What is the graph and lm?
For 1best and nbest, we use HLG as decoding graph, where G is a word-level 3-gram. For nbest-rescoring and whole-lattice-rescoring, we use a word-level 4-gram for further rescoring.

Training with both transducer loss and CTC loss, with option --use-transducer True --use-ctc True

transducer head, epoch-40-avg-16

greedy-search	modified-beam-search	fast-beam-search
2.24, 5.01	2.19, 5.03	2.2, 4.98

CTC head, epoch-40-avg-16

ctc-decoding	1best	nbest	nbest-rescoring	whole-lattice-rescoring
2.4, 5.66	2.46, 5.11	2.46, 5.11	2.37, 4.93	2.37, 4.88
@marcoyang1998 has trained the zipformer with CTC loss alone, getting 2.62, 6.14 at epoch-90-avg-38.

Could you list the baseline results trained without CTC for better comparison?

Training with both transducer loss and CTC loss, with option --use-transducer True --use-ctc True

transducer head, epoch-40-avg-16

greedy-search	modified-beam-search	fast-beam-search
2.24, 5.01	2.19, 5.03	2.2, 4.98

CTC head, epoch-40-avg-16

ctc-decoding	1best	nbest	nbest-rescoring	whole-lattice-rescoring
2.4, 5.66	2.46, 5.11	2.46, 5.11	2.37, 4.93	2.37, 4.88
@marcoyang1998 has trained the zipformer with CTC loss alone, getting 2.62, 6.14 at epoch-90-avg-38.

Could you list the baseline results trained without CTC for better comparison?

Added


Correct documentation typo

Signed-off-by: Jayesh Patel<EMAIL_ADDRESS>

No problem.
I thought I already included the sign-off line:
[image: image.png]
However, I typed it in manually, not using "git commit -s".  Does that make
a difference?
On Tue, Feb 22, 2022 at 11:05 AM Rupert Swarbrick @.***>
wrote:

Thanks for this! Please could you add a sign-off line as described in
CONTRIBUTING.md
https://github.com/lowRISC/opentitan/blob/master/CONTRIBUTING.md?
(You'll need to use git commit --amend to update the commit message).
—
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/11011#issuecomment-1047951038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX4BPSLCQOZCNJIKHSKH7GLU4OX5JANCNFSM5PBF4ERQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Oh, good point! Sorry, I didn't read the CI logs properly. If you click on "details" above:

then you'll see the 3 messages that are coming out. The problem is actually with your name and email.
You can reproduce locally (and check you've fixed things without having to re-push) with the ci/scripts/lint-commits.sh script like this:
> ci/scripts/lint-commits.sh master
Checking commit messages since 3281bd3cf497853245a7d59678ae5ceeb4d411c7
Checking commit fd7e415533038e795c4ed65f2c8d9ca360c6cdfe
##vso[task.logissue type=error]Commit fd7e415533038e795c4ed65f2c8d9ca360c6cdfe: Commit author has no valid email address set: {commit.author.email!r}. Use "git config user.email<EMAIL_ADDRESS>to set a valid email address, then update the commit with "git rebase -i" and/or "git commit --amend --signoff --reset-author". Also check your GitHub settings at https://github.com/settings/emails: your email address must be verified, and the option "Keep my email address private" must be disabled.  See CONTRIBUTING.md for more details.
##vso[task.logissue type=error]Commit fd7e415533038e795c4ed65f2c8d9ca360c6cdfe: The commit author name 'jayeshaarish' contains no space. Use "git config user.name 'Johnny English'" to set your real name, and update the commit with "git rebase -i " and/or "git commit --amend --signoff --reset-author".  See CONTRIBUTING.md for more details.
##vso[task.logissue type=error]Commit has one or more Signed-off-by lines, but not the one we expect. We expected to find "Signed-off-by: jayeshaarish<EMAIL_ADDRESS>The commit message must contain a Signed-off-by line that matches the commit author name and email, indicating agreement to the Contributor License Agreement. See CONTRIBUTING.md for more details. You can use "git commit --signoff" to ask git to add this line for you.
##vso[task.logissue type=error]Commit lint failed.

Thanks for you patience in explaining everything @rswarbrick .  I think I've satisfied the CI requirements now but please let me know if I missed something.


Addition of skills/experiences/etc blocks to the page

Addition of skills/experiences/etc blocks to the page

great!


(BUG) The images are cut off on the camera permission pop-ups

Precondition:
The "Home" page is opened
Camera permission set "Ask default"
Steps to reproduce:

Click the "Send" button
Click the "Scan QR" button
Pay attention to the images on the pop-ups

Actual result: The images are cut off on the camera permission pop-ups
Expected result: The images are displayed fully on the camera permission pop-ups

Checked on  dev 1.3.1-2
Desktop: Windows 10 // Google Chrome   87.0.4280.66
iPhone 8 //13.3.1
Samsung S9 // Android 10

Issue is reproduced on goodnative too so doesn't seem to be a merge problem.
A quick inspection shows that the problem is with the height set to the View parent of svg, that height is smaller than svg's height, causing the cut. Possible solutions are: increase View height or reduce Svg height to match View's

@mauriguz previous images are displayed fully
but I found one more that is cut


Incompatiblity with MBOptionScreen xml

I wanted to report an incompatibility issue. This was discovered through "TML Tweak Mod" a smithing mod on the Nexus. I was told that this crash is due to MBOptionScreen. Even when running MBOptionScreen standalone with Community Patch triggers the crash.

Yeah, this is fixed on the dev but a new release hasn't occurred yet.


Investigate CRD controller timing out if no Cilium CRDs are present when it is created

The issue is that when the CRD controller is first created and begins watching for CRDs in the cluster,  and no Cilium CRDs are present at that point (meaning cilium-operator has not registered them yet), the crd-wait-timeout will be triggered, even after cilium-operator registers the Ciilum CRDs. The controller is unable to find them due to a K8s apiserver error indicating that v1beta1.CustomResourceDefiniton was found, when expecting v1.PartialObjectMetadata.
This error was observed while working on https://github.com/cilium/cilium/pull/13418. It seems to only occur on K8s versions below 1.15.
Reproduction steps:

Deploy
Delete all Cilium CRDs
Roll agent
Tail agent logs
Roll operator so that it can register Cilium CRDs
Observe controller errors in the agent logs

These errors eventually resolve themselves after the CRD wait timeout is hit (default is 5m). The timeout will fatal the agent, and upon it restarting, it is able to sync the CRDs and the agent goes on fine.

Likely cause of this is that watching a PartialObjectMetadata is not supported until K8s 1.15, which would explain the behavior of it working on 1.15 and not 1.14.


Get the same dataset from Attention is all you need

@xavierVG Future work item, still in Business Analysis stage.


This design is not compatible with Blazor architecture

The Blazor has an architecture (Blazor.Shared, Blazor.Server, Blazor.Client) where shared objects are used by both the client and the server.
Those shared objects are Command, Query and ViewModel objects.
In the current design Command and Query objects are in the Application layer.
If Application layer is referenced by the Blazor.Shared it would depend on MediatR, FluentValidation, Mapper, Logger and Persistence layer which seems not right.

Command, Query and ViewModel objects should be taken out of Application Layer and could be put inside Domain layer or some new layer like Blazor.Shared. If they are put on Domain layer Mapping functions can be moved there too else will be in Handlers in Application layer.
Validators can be moved to Shared too.
As a result the Shared layer will depend only on MediatR and FluentValidation.
Application Layer should only host the Handlers and maybe the Mappers.

Opinions?

I think this design is 100% compatible ..
Think this way: The Blazor is not more than a client to the API ... no logic Business logic should be present ..
I've used this project as blueprint for an Web API, And Razor Pages Backoffice and a Xamarin App that just calls the Web API.
By using swagger on the Web API I have the Client code auto generated for my Xamarin (using  NSwagStudio)
So if I'm correct you'll end up using this client lib on your Blazor Pages project....

Share server-side and client-side app logic all written with .NET
https://docs.microsoft.com/fr-fr/aspnet/core/blazor/?view=aspnetcore-3.0

The shared part of blazor's architecture is just sharing logic and is the role of the application Layer.
If i look samples and examples from Blazor Community the application layer clearly plays the same role.
So I don't quite understand where the problem is.
For me the Application Layer is egal to Blazor.Shared just move your logic inside application Layer .

I think @cmorgado and @ValerianHavaux have covered this well. Thanks for your input.


Support combine without a block

We need a test showing expected behavior :)

I'll do it then =)

yes please, in general no PR will be accepted without tests, even if a change is trivial in terms of implementation.

Added a spec for the behavior.

awesome @kwando :)


Re-enable qps_test TSAN runs

Likely needs the channel connectivity stuff enabled: not GA blocking.

Fixed for some time.


Remove @juggle/resize-observer?

I wonder if @juggle/resize-observer is necessary at all as most browsers anyway support it and in case someone wants to support older versions he could still load the polyfill optionally? Just noticed while checking the code because of minor performance issues...

Maybe after 1 or 2 years we can remove it? I notice that it seems some users user chrome of version 5x.

I remember in 2018, safari doesn't support ResizeObserver.

What are the performance issues?

I was facing some issues when using checked-row-keys prop of DataTable and saw in the profiler that the ResizeObserver took most of the time. Without the polyfill it felt faster though I did not ran any quantitive measurements.


Create an Access token to bypass SSO in datahub-frontend UAT

This work enables an Access token (with a value provided via $OAUTH2_DEV_TOKEN) to be created within the backend for CircleCi User Acceptance tests. The same access token value is then used in datahub-frontend to byPass SSO on CircleCi.
Of Note

@r4vi and @lgarvey have spoken about a SSO stub. When this has been built we can look at integration testing for data-hub-frontend
I have asked the SSO team if they can add a healthcheck endpoint so we can add this to the data-hub-frontend health check and in the future potentially a separately hosted data-hub-frontend status page.

This work is related to #877

Codecov Report

Merging #603 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #603   +/-   ##
=======================================
  Coverage     96.5%   96.5%
=======================================
  Files          125     125
  Lines         3775    3775
  Branches       325     325
=======================================
  Hits          3643    3643
  Misses          94      94
  Partials        38      38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24407fd...18209be. Read the comment docs.

@feedmypixel you can try make fakesso if in circle if you like https://github.com/r4vi/fakesso

@feedmypixel you can try make fakesso if in circle if you like https://github.com/r4vi/fakesso

@r4vi great thanks, I'm not gonna integrate this s this piece of work but will come back to it later in the week and give you a shout if there are any questions.

@feedmypixel I've tried it with export-wins and it seems to work

@feedmypixel I've tried it with export-wins and it seems to work

awesome :)


:traffic_light: Add codecov.io

Current coverage is 100.00%

Branch #5 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.
Review entire Coverage Diff as of 201cd29

Powered by Codecov. Updated on successful CI builds.


Improve tab switching performance

The main difference between Sublime and Atom for tab switching, is Atom use "onmouseup" event while Sublime use "onmouseup":
With Atom, you only switch tab after releasing your finger from your mouse. This is noticeable with the eye.

@benogle: could you provide some more feedback on this, please? I tried opening a ton of files under the same window, and switched tab through pane:show-next-item: everything seems quite responsive, though. What am I missing?
Thank you :bow:

This was a ticket to look into it -- profile it and see if there is low hanging fruit. Some people were having issues. The recent speedups in the editor may have made things better. And I suspect packages (e.g. https://github.com/atom-community/autocomplete-plus/issues/247) are contributing to some of the slowdown.

:+1: I see. To be honest, I cannot notice any slowdown when switching lots of tabs and, therefore, I assume this issue is mostly related to autocomplete-plus, rather than to Atom itself.
Shall we keep it anyways, or can we say this was fixed? Thanks :dancers:

How about switching to "mousedown" like @KeitIG mentioned?
All tabs I use daily (Chrome, Nautilus, Firefox, Gimp, Sublime etc.) work that way.
I think that would definitely help. Or is there already some preparation stuff done on mouse down I don't know about?

How about switching to "mousedown" like @KeitIG mentioned?
All tabs I use daily (Chrome, Nautilus, Firefox, Gimp, Sublime etc.) work that way.
I think that would definitely help. Or is there already some preparation stuff done on mouse down I don't know about?

The main difference between Sublime and Atom for tab switching is Atom use "onmouseup" event while Sublime use "onmouseup" when clicking a tab.
With Atom, you only switch tab after releasing your finger from your mouse. This is noticeable with the eye.

@marcelgwerder: as explained by @benogle earlier on, this issue is more about slowdowns experienced while switching tabs. Could you explain how your proposal could impact speed? Moreover, I'd say the behavior you're requesting belongs to https://github.com/atom/tabs, thus you may want to open an issue there.
Thanks for your feedback! :blush:

@as-cii It will not speed up the process itself. It will just feel faster for the user because the switch is already invoked on mousedown. Some quick tests show me a personal difference of ~60ms between mousedown and mouseup. That of course depends on the user but it's a "quick win" if you will.

. It will just feel faster

It's more than feeling faster.  Your eyes see the new tab sooner and can
start doing their thing.
On Sun, Mar 15, 2015 at 4:49 AM, Marcel Gwerder<EMAIL_ADDRESS>wrote:

@as-cii https://github.com/as-cii It will not speed up the process
itself. It will just feel faster for the user because the switch is already
invoked on mousedown. Some quick tests show me a personal difference of
~60ms between mousedown and mouseup. That of course depends on the user but
it's a "quick win" if you will.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/5174#issuecomment-80982739.

Resolved in atom/tabs#124 - tabs are quite snappy now.

@mnquintana
My PR didn't really improve "tab switching performance", but "tab switching performance feeling"

@marcelgwerder: as explained by @benogle earlier on, this issue is more about slowdowns experienced while switching tabs


Add npm commands to build and deploy to gh-pages

This PR contains:
Npm scripts to build & deploy to gh-pages with 1 command
npm run deploy:gh-pages

This will build & deploy to gh-pages based on the origin remote you have setup. If it's a fork, it will be published to your fork.
The live link will be https://{{fork-username}}.github.io/best-resume-ever
Update: This is intended for forks mostly and is related to #18 which was partially solved. The base repo has CI and automatic deploy to gh-pages.
Describe the problem you have without this PR
When you fork the repo and want to publish your resume to gh-pages, you have to do it manually by installing gh-pages package, building and running gh-pages commands.

Thanks @cristijora, I am quite busy at the moment but I will try to take a closer look this weekend.

Excellent, @cristijora! Thank you!

Thank you very much @cristijora for your help. In the current version docs can be now generated with npm run docs and previewed with npm run docs:serve. While your PR pushes to the gh-pages branch, the current version  generates a /docs folder. In this way tests can be run (npm run test:docs). So I am going to close this.


Remote audio feature

Remote audio can now be redirected away from the default audio device.
RemoteAudioSource on Unity now plays audio using the OnAudioFilterRead API.
This PR also adds some a new high-level API which manages buffering and provides a way to consume the audio as a stream, resampling and/or changing the number of channels on the fly.
TODO add proper interface to enable/disable tracks.

Did you consider using OnAudioFilterRead? It allows you to write the streaming audio data (after decoding it to WAVE_FORMAT_IEEE_FLOAT) directly to an AudioSource, bypassing the need for an AudioClip.

Did you consider using OnAudioFilterRead? It allows you to write the streaming audio data (after decoding it to WAVE_FORMAT_IEEE_FLOAT) directly to an AudioSource, bypassing the need for an AudioClip.

I saw that technique yesterday in that Gamasutra article and was wondering about the difference with the streaming AudioClip. @eanders-MS do you have any experience with this? How do the two compare? It sounds (pun intended) like OnAudioFilterRead might be better for performance and/or latency, no? And that avoids the issue with Unity object access when changing channel count and sample rate I assume, at the expense of re-sampling since you seem to be limited to the internal sampling rate of the Unity DSP (but anyway Unity will do that resampling on the AudioSource anyway I am pretty sure).
Ping @stephenatwork, what do you think? The docs explicitly mention the technique for procedural audio:

If this is the first filter in the chain and a clip isn't attached to the audio source, this filter will be played as the audio source. In this way you can use the filter as the audio clip, procedurally generating audio.

I was hoping to sign up for this work but @stephenatwork beat me to it :)

@eanders-MS do you have any experience with this? How do the two compare?

My prior experience is one-sided in that I've only used the OnAudioFilterRead approach. On a previous project I incorporated a streaming mp3 player into Unity. It would read output from ffmpeg and pipe it to an AudioSource via OnAudioFilterRead. There was some timing code to ensure the video stream stayed in sync to the audio. I think the same approach is applicable here, given the similarities.
That said, if the solution in this PR works and it's a good Unity integration, then fantastic.

Did you consider using OnAudioFilterRead? It allows you to write the streaming audio data (after decoding it to WAVE_FORMAT_IEEE_FLOAT) directly to an AudioSource, bypassing the need for an AudioClip.

Thanks for the tip. That looks like a much better choice than the one I found. I did a few local tests and it seems to have very little delay (which is an issue in the AudioClip version). It shouldn't be much work to port the implementation, except to add the resampling.

I've updated this PR to use the OnAudioFilterRead API.
Also, managing buffers and resampling in C# seems inefficient. So this PR adds some a new high-level API which manages buffering and provides a way to consume the audio as a stream, resampling and/or changing the number of channels on the fly.

All the scaffolding is in place, we just need to choose and wire up a resampler. Luckily webrtc seems to include at least 2 which I'll need to evaluate:
webrtc\xplatform\opus\silk
webrtc\xplatform\webrtc\common_audio\resampler\include

The current branch supports (only) spatial audio. Objects with a RemoteAudioSource component, can have an AudioSource attached. Remote audio tracks are not piped to the output device. When there is no remote audio data, either because of underrun or not yet connected, the RemoteAudioSource outputs a low buzz for debugging.
TODO: remove the dialtone, allow per track routing of output to speakers or AudioSource.

I would approve but ...

Hi @stephenatwork,
These look like some great changes!   Funny enough I'm looking at an audio problem where all audio volume is severely reduced when a webrtc session is initiated (all audio except for the webrtc audio).  What I've found is that the Google webrtc implementation selects the default audio communications device for audio output and when that device gets used then Windows ducks/reduces all other audio by 80% (for anyone else reading this, it's a Windows feature to ensure speech is heard above everything else).  Problem is if you're building something like a game then all the game audio is suppressed by 80% as well 😞
So this feature you've worked on looks to actually solve that for Unity, correct?  Could you help me understand some aspects of how it works, specifically:

With your changes will the incoming/remote webrtc audio get piped into Unity via your new RemoteAudioSource Component?
Does that mean all the webrtc audio will not go through Windows Core audio directly, but instead be piped to the Unity audio pipeline and get output to the Windows default audio device (i.e. not the Windows default communications device)?
With this change will we be able to independently change the webrtc audio volume via Unity's AudioSource.volume property, but through your RemoteAudioSource?
Is there an ETA when it will be merged to the master branch?  :)
My understanding was that since Google's libwebrtc Windows implementation sends audio directly to the default audio communications device that the only way to change that was by modifying the libwebrtc code, recompiling and re-integrating into MixedReality.  How were you able to "circumvent" that paradigm?

Thank you for all your hard work!
Cheers,
Andrej

Hi @drejx, I had noticed the same behavior but hadn't looked into it, thanks for investigating!
This change uses a custom AudioMixer but doesn't change the AudioDeviceModule, so I am afraid it won't solve the problem (I suppose that even if no audio is played on it, the default comm device will still be in use). I'll open a new issue for it.
I'll try to reply to your questions with what I know:

Yes
Yes (AFAIK), but this won't avoid the volume drop, as said above.
I am not sure what you're asking - I think you will be able to change the volume through AudioSource.volume but I haven't tried. @stephenatwork can you confirm?
Not sure - in order to work on UWP this relies on some other changes that are still in flux. Would it still be useful for you if it only worked on Desktop?
I am not sure what you mean by "the MixedReality-SDK from 2019-12-16". If you mean "is it possible to integrate these changes to a previous master/release", it's not really recommended, but I can't think to any obvious blocker so feel free to try.
We weren't, as said above.

Thanks the interest @drejx - @fibann has taken over this feature.

I am not sure what you're asking - I think you will be able to change the volume through AudioSource.volume but I haven't tried. @stephenatwork can you confirm?

My understanding is that the unity.audiosource is the correct (indeed, only!) place to change the volume.
Because the reduction appears to be a system setting (see below), I expect there may be no way to bypass the setting. I agree we'd want a custom ADM. So an option to use the default output device as well as an option for a custom device id sounds like a great idea.

Yes @stephenatwork but I think @drejx is right that at least in theory opening the audio endpoint as a non-communication device should prevent this behavior. Now I have no idea if/how easy it is to do that. @fibann had a look and from what I understand from above it requires some changes to the Google implementation, either by changing their code or by injecting a custom audio device module that replaces the built-in one. Either way this requires some work.

Thanks for the detailed responses everyone :)  In my case I am using it with Unity Desktop/Standalone and hence wouldn't need it to work for UWP.
Correct me if I'm wrong, but as I understand it even with the Remote Audio Feature the voice audio will still be piped through the Windows default communications device (due to Google's webrtc implementation) and also piped to your new RemoteAudioComponent to Unity.  So in effect it would kinda negate the Remote Audio feature. For example, changing the volume/muting in Unity won't affect the audio going through the communications device and all audio will still be ducked (including RemoteAudio).  I'm wondering if it will make the experience worse because you'll be hearing the voice audio coming from 2 sources.  In your tests have you noticed this beahviour?  I don't mean to be a drag, but want to highlight possible pitfalls before you get 300 issues/bugs titled "audio doesn't work!"  :P
It would be great for the Google webrtc logic to be able to select a device, but I understand that is tough to do in your situation as it would require a new fork of their code.  @fibann thanks for creating #263.  I'll post there what I've found in my digging of the code, but the short answer is in audio_device.h there is this enum for which device to select and kDefaultCommunicationDevice is what the AudioDeviceWindowsCore() is initialized with:
    enum WindowsDeviceType {
        kDefaultCommunicationDevice = -1,
        kDefaultDevice = -2
      };

Keep on truckin'!
Andrej

@drejx

even with the Remote Audio Feature the voice audio will still be piped through the Windows default communications device (due to Google's webrtc implementation) and also piped to your new RemoteAudioComponent to Unity.

Not really, with this change the audio data from remote tracks is "redirected away" from the WebRTC audio device (i.e. the Windows default comm device) so you won't hear the audio twice (for the sake of clarity, note that this behavior needs to be chosen explicitly by calling RenderRemoteAudioTrack(false)). On the other hand, even if all tracks are redirected away, the device will still be opened and empty frames (silence) will be sent to it, so volume from all the other apps will still be reduced when the session begins. I hope this clarifies the issue.
If you think this is a useful change even if it only works on Desktop I think we can push it as it is (only minor changes should be left) so hopefully it can go in in the next few days.

Hi @fibann,
Got it, thank you.  I think it's quite useful for Unity/Desktop, even though it will still duck other sounds.  A major plus is being able to change the volume so at least the user can adjust voice chat volume to match the other ducked game/app audio :)
I'm exploring changing the Google webrtc code to switch from kDefaultCommunicationDevice  -> kDefaultDevice.  In your opinion what would cause the least friction to get a custom built webrtc.lib into the MixedReality-WebRTC SDK?  I believe the MixedReality project uses the output of the webrtc-uwp-sdk project for it's webrtc library and I can build my own webrtc.lib by following the instructions here:
https://github.com/webrtc-uwp/webrtc-uwp-sdk#building-the-sdk
Once built I can replace the MixedReality webrtc.lib in here:
MixedReality-WebRTC\packages\Microsoft.MixedReality.WebRTC.Native.Core.Desktop.x64.Release.1.0.2\lib\native\lib\win10\x64\release\webrtc.lib
Would that be sufficient or would Org.WebRtc.WrapperGlue.lib also need to be copied?
Oops, didn't meant to hijack this issue thread!  I'd be happy to open a new one if you wish.
Cheers,
Andrej

@drejx if you build locally the "core dependencies" (the Google code) following this doc then it automatically takes precedence over the webrtc.lib from the NuGet packages when you use the Visual Studio solution, no need to copy anything or overwrite any file. There's already a build.ps1 script also to help compiling, you "only" need to make sure the environment and all tools/dependencies are setup on your dev machine, as explained in that doc.


Missing css file in mobile app

Executing the following commands:
qx create mtest --type mobile -I
cd mtest
qx compile
results in the following error:
2018-12-13 09:25:21.098 Error: ENOENT: no such file or directory, open '/srv/http/qx6/mtest/source/resource/mtest/css/custom.css'
The resulting app runs but it looks "ugly".  Am I missing something?  I am using the latest qx compiler on arch linux.

I can confirm this. It's odd. I first thought it was related to #243, but the resource folder is completely missing for some reason. I am looking into it.

I am not getting the error if I use the current master. Which version is displayed when you do qx without any arguments?

qooxdoo-compiler v0.2.25.  I just did an 'npm -g update' this morning.  If I do a 2nd 'qx compile' without an intervening 'qx clean' then I don't get the error but the displayed result still looks 'strange'

2 runs of compile are necessary for the first time - the generated css files are not reckognized in the first run.
What's ugly? Do you have a picture?

I was probably being harsh using the word ugly.  I guess I was expecting a "smoother" default theme.

Your are right. The custom.css file is not loaded.
Please try to insert an externalResource in your manifest.json
 "externalResources": {         "script": [          ],         "css": [           "your_app/css/custom.css"         ]    }
We should do this during create for mobile app

@hkollmann can you fix the mobile skeleton?

It‘s on the list
Von meinem iPad gesendet

Am 14.12.2018 um 10:43 schrieb Christian Boulanger<EMAIL_ADDRESS>@hkollmann can you fix the mobile skeleton?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Since I am actually trying to convert several mobile apps from 5.0.2 to the compiler, I copied over the files from old_app/source/resource/old_app/css to new_app/css and updated the Manifest.json.  But nothing happened so I'm guessing I placed the css directory in the wrong location.

css or scss files? I mobile app the css files are autogenerated into css dir. This is not changed.
You can try to generate a new mobile app with Compiler > 0.2.27, this generates an manifest.json with external resource.

I am currently running v0.2.27 and except for the Manifest.json containing an externalResources key I see no difference from my original comment.  The app still looks the same and the only .css file I can find is under
source-output/resource/qx/mobile/css/custom.css and it is a 0-length file.  The original ENOENT error refers to source/resource but there is no such directory -- there is a source/theme directory.

Compiler needs 2 runs.

compile source\theme\test\scss\custom.scss to source\resource\test\css\custom.css
copy source\resource\test\css\custom.css to source-output\resource\test\css\custom.css.

Could you try to create a new mobile project, run qx compile twice, run qx serve and look if it's working for you?

I created a new mobile project (mtest), changed to that directory and ran
qx compile source/theme/mtest/scss/custom/scss
I also tried it with a 2nd argument of source/resource/test/css/custom.css; and I tried just using sass.  In each case I got the following error message:
Error: Failed to load [object Object]: SyntaxError: Cannot tokenize symbol <@> at 1:1
@import "common/all";
^
at defaultConstructor.__loadJson (/home/ed/.nvm/versions/node/v8.14.0/lib/node_modules/qxcompiler/lib/qx/tool/cli/commands/MConfig.js:256:15)
at
I re-installed nvm/npm/qx today but maybe I've got something configured incorrectly?

Please run qx compile without any arguments!
Von meinem iPad gesendet

Am 17.12.2018 um 23:22 schrieb eda2z<EMAIL_ADDRESS>I created a new mobile project (mtest), changed to that directory and ran
qx compile source/theme/mtest/scss/custom/scss
I also tried it with a 2nd argument of source/resource/test/css/custom.css; and I tried just using sass. In each case I got the following error message:
Error: Failed to load [object Object]: SyntaxError: Cannot tokenize symbol <@> at 1:1
@import "common/all";
^
at defaultConstructor.__loadJson (/home/ed/.nvm/versions/node/v8.14.0/lib/node_modules/qxcompiler/lib/qx/tool/cli/commands/MConfig.js:256:15)
at
I re-installed nvm/npm/qx today but maybe I've got something configured incorrectly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I first did an 'npm -g update' and noticed that I now have v0.2.28.  I then repeated my steps of building a new mtest and compiling it twice.  Running 'qx serve' and also accessing the app thru apache showed no change.  The app runs but it looks like it is using some default css/theme.  Since I do have versions of my apps running under 5.0.2, I did the following:
created a new mtest app and compiled it twice; created the directory mtest under source-output/resource (since it did not exist); copied the 3 directories (css, icon, scss) from one of my old apps (source/resource/oldapp).  The app now looks like it is themed.

Wich Linux do you use? Is npm sass working?
@team: Could someone working with linux try to create and compile a mobile app?
Von meinem iPhone gesendet

Am 18.12.2018 um 16:08 schrieb eda2z<EMAIL_ADDRESS>I first did an 'npm -g update' and noticed that I now have v0.2.28. I then repeated my steps of building a new mtest and compiling it twice. Running 'qx serve' and also accessing the app thru apache showed no change. The app runs but it looks like it is using some default css/theme. Since I do have versions of my apps running under 5.0.2, I did the following:
created a new mtest app and compiled it twice; created the directory mtest under source-output/resource (since it did not exist); copied the 3 directories (css, icon, scss) from one of my old apps (source/resource/oldapp). The app now looks like it is themed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I am running on Arch linux and installing gnome-builder caused ruby-sass (version 3.6.0-1) to also be installed.  I uninstalled it and installed npm sass -- the compiler install instructions never mentioned the need for it.  Doing this had no affect, there is still no theme and npm sass complains about "@import "common/all" -- Can't find stylesheet to import.

do you have a docker container with archlinux and node?

No.  Arch is my base operating system.  I did not have any problems with the compiler for desktop, only mobile.

I just did an "npm -g update" which got me version v.0.2.23 and it looks like it solves my original issue.  Thanks for fixing this.  Should I be closing this issue?

muat be v0.2.33.
yes please close the issue

Fixed with v0.2.23.


Add V1 token migration transaction hooks

What does this PR do and why?
More prep for https://github.com/jbx-protocol/juice-interface/issues/1335 (https://github.com/jbx-protocol/juice-interface/issues/1056)
⚠ There are no user-facing changes in the PR
Adds transaction hooks:

PayV1TokenPaymentTerminal
V1SetOperator

In addition:

minor V2ContractLoader refactor to include new terminal contract
move and rename some files
update contract reader logging
clean up v2 manage tokens section pre-render

Screenshots or screen recordings
No user-facing changes.
Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.
[x] I have tested this PR in dark mode and light mode (if applicable).

@wraeth-eth hey there, could you please review this when you get a chance? 😃

@wraeth-eth scratch that - going to send @johnnyd-eth 's way as he needs this context for NFT rewards.

 Will take note for the NFT contract 🧠 LGTM


Add observation noise if provided

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 91.649%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
428

Relevant Lines:
467

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 91.684%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
430

Relevant Lines:
469

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 91.684%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
430

Relevant Lines:
469

💛  - Coveralls


bug: cannot delete consumer if secret used in KeyAuth secret ref has been deleted first

Issue description
TL;DR
When deleting Consumer manifests - and - if using an authentication scheme such as KeyAuth which references a Kubernetes secret - if the secret has already been deleted within the environment, the consumer cannot be removed [and retries infinitely]
More Context:
We use argocd and helm charts to deploy our services.
We manage ingress access in these charts by creating secrets and consumers.
The secrets created are the API tokens that consumers refer to for KeyAuth.
The secrets are managed by external-secrets and thus pre-exist in a secret manager.
Deploying consumers is no issue - however, when we delete everything in a particular release - not all consumers are deleted [non-deterministic] and those that cannot be deleted enter into an infinite loop of retries.
They are still contained with etcd and therefore available on the APISIX api.
From a quick glance at the code for 1.5 - I believe this is happening due to the fact that in the environment, argocd can delete secrets before the ingress-controller has processed the consumer deletion event [race condition]
The ingress-controller tries to translate the consumer to be removed and fails to parse / translate due to the secret being missing.
The only way to remove the consumer entry is to manually delete it or restore the secret.
Useful links to functions
https://github.com/apache/apisix-ingress-controller/blob/32be235aaf1f571a9f70f6375459429cd4ecc1af/pkg/kube/translation/apisix_consumer.go#L68
https://github.com/apache/apisix-ingress-controller/blob/32be235aaf1f571a9f70f6375459429cd4ecc1af/pkg/kube/translation/plugin.go#L125
Environment

your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 1.5.0
your Kubernetes cluster version (output of kubectl version): v1.23.13-eks
if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):

Minimal test code / Steps to reproduce

Create Kubernetes Secret with property key=token
Create Consumer with keyAuth reference to Kubernetes Secret
Ensure syncrhonised with APISIX [check admin API or etcd]
Delete Secret
Delete Consumer

Actual result
Consumer is not deleted
Error log
error ingress/apisix_consumer.go:166 failed to translate ApisixConsumer {"error": "invalid key auth config: secret "dev-api-key-gn78j-15" not found"... [Apisix Consumer Object JSON is printed to screen - removed for brevity]
ingress/status.go:220	failed to record status change for ApisixConsumer	{"error": "Operation cannot be fulfilled on apisixconsumers.apisix.apache.org "t-gn78j-15": StorageError: invalid object, Code: 4, Key: /registry/apisix.apache.org/apisixconsumers/t-gn78j/t-gn78j-15, ResourceVersion: 0, AdditionalErrorMsg: Precondition failed: UID in precondition: e8fb79f7-e8e2-4e7c-9746-b17c8670f683, UID in object meta: ", "name": "t-gn78j-15", "namespace": "t-gn78j"}
Expected result
Consumer is deleted

thanks for the report, add this to my queue.

Thanks, @tao12345666333 - very happy to help test fixes.


JBPM-4912 - Removing the deprecated 'jbpm.v5.id.strategy' property

Related to https://github.com/droolsjbpm/jbpm/pull/389

+1 beside this tiny duplication

Fixed!


Creation of "Countdown" Page/Window UI

As a logged-in user, I want to be able to start a Singleplayer mode#93

https://github.com/sopra-fs23-group-32/SoPra23_Client/commit/3a729f5cc253d85055ed1879d756d0299de9970d
Wrong commit name, code is roundCountdown page

https://github.com/sopra-fs23-group-32/SoPra23_Client/commit/ce1b23e1829f254e7a50cb00b520249396fd8839


Hot Reload Not Working

Version
3.2.1
Reproduction link
https://github.com/chenweibo/vueCliDemo
Environment info
  System:
    OS: macOS 10.14.2
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 10.14.2 - /usr/local/bin/node
    Yarn: 1.12.3 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 71.0.3578.98
    Firefox: 64.0
    Safari: 12.0.2
  npmPackages:
    @vue/babel-preset-app:  3.2.0
    @vue/cli-overlay:  3.2.0
    @vue/cli-plugin-babel: ^3.2.0 => 3.2.0
    @vue/cli-plugin-eslint: ^3.2.0 => 3.2.1
    @vue/cli-service: ^3.2.0 => 3.2.0
    @vue/cli-shared-utils:  3.2.0
    @vue/component-compiler-utils:  2.3.1
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    babel-helper-vue-jsx-merge-props:  2.0.3
    babel-plugin-transform-vue-jsx:  4.0.1
    eslint-plugin-vue: ^5.0.0-0 => 5.0.0
    vue: ^2.5.17 => 2.5.21
    vue-eslint-parser:  2.0.3
    vue-hot-reload-api:  2.3.1
    vue-loader:  15.4.2
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.17 => 2.5.21
    vue-template-es2015-compiler:  1.6.0
  npmGlobalPackages:
    @vue/cli: 3.2.1

Steps to reproduce
使用npm 安装的vue-cli  正常选择默认模板生成 然后 启动服务 热更新已经默认不生生效了 重现的模板在github  地址
What is expected?
希望正常能热更新  安装过很多版本的node.js 版本 都是不行 包括文档推荐的node.js 版本
What is actually happening?
不能热更新

WAIT  Compiling...6:11:27 PM
10% building 0/1 modules 1 active ...dex.js??ref--13-0!/web/demo/src/App.vue DONE  Compiled successfully in 408ms6:11:28PM
WARN
Couldn't parse bundle asset "/web/demo/dist/app.9f3062b5c30ee5b7e896.hot-update.js".
Analyzer will use module sizes from stats file.
App running at:

Local:   http://localhost:8081/
Network: http://<IP_ADDRESS>:8081/

控制台没报错。 但是VUE UI 这个报错。   直接提示这个热更新问题不行

vue-cli 是通过 npm 安装。 没安装cnpm模块

是的  我测试了下老的项目  webpack-dev-server 3.0.rc.12   发现热更新 生效的     这是我再开发新项目 重新生成模板的时候遇到的。

// vue.config.js
module.exports = {
devServer: {
disableHostCheck: true
}
}
这样设置是可以修复，但是vue ui启动控制台还是有警告，用npm启动没有警告

Should have been fixed with the latest release of webpack-dev-server v3.1.14
Please run rm -rf node_modules yarn.lock package-lock.json and reinstall the dependencies.

Still having to downgrade to 3.1.10 even after clean install of everything and wiped cache.

True, v3.1.14 is still no working at all.
I using npm-force-resolutions to solve this problem

<EMAIL_ADDRESS>热更新动作会发生，但没有实质效果，一个更改在后续更改触发的热更新里才能起效果。

True, v3.1.14 is still no working at all.
I using npm-force-resolutions to solve this problem

Hello, how do you solve the problem? I put
"resolutions": {
    "webpack-dev-server": "3.1.10"
  }

in package.json file and follow this doc run
rm -r node_modules
npx npm-force-resolutions
npm install

But i still get 3.1.14 version.
$ npm ls webpack-dev-server
<EMAIL_ADDRESS>/Users/jiangxingshang/Documents/workspace/WebStorm/final-shop
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>

True, v3.1.14 is still no working at all.
I using npm-force-resolutions to solve this problem

npm install<EMAIL_ADDRESS>

I just ran npm install -g @vue/cli - that installed version 3.4.1 (again)
Then ran npm install<EMAIL_ADDRESS>Everything is working as expected now.
I don't understand why this worked all of a sudden when a clean install previously installed the same versions. Perhaps a sub dependency has been updated in the last week... ?

I update @vue/cli to version 3.4.1 still not work.
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
 WARN
Couldn't parse bundle asset "/Users/jiangxingshang/Documents/workspace/WebStorm/final-shop/dist/app.bda800bdbb3808612f08.hot-update.js".
Analyzer will use module sizes from stats file.

hot reload not working in keep-alive

Caused by webpack-dev-server 3.1.11.
Workaround 1:
// vue.config.js
module.exports = {
  devServer: {
    disableHostCheck: true
  }
}

Workaround 2:
If you are using yarn, you can lock its version by adding the following resolutions field to package.json.
如果用 yarn 的话，暂时可以在 package.json 里增加 resolutions 字段锁版本
"resolutions": {
  "webpack-dev-server": "3.1.10"
}

Workaround 1 is working.
BUT when the  is wrapped in a   tag will make hot-reload no working too.

I am not using keep-alive tag and in vue.config.js also has
devServer: {
    disableHostCheck: true
}

still not work for me.
I try to use yarn to install with
"resolutions": {
  "webpack-dev-server": "3.1.10"
}

Also not work. Crazy...

I am not using keep-alive tag and in vue.config.js also has
devServer: {
    disableHostCheck: true
}

still not work for me.
I try to use yarn to install with
"resolutions": {
  "webpack-dev-server": "3.1.10"
}

Also not work. Crazy...

my success case:
1- remove <keep-alive>
2- add disableHostCheck to devServer (must to do)
3- use default versoin (3.1.14) of webpack-dev-server

devServer: {
// 热更新 打开
hotOnly: true,

devServer: {
// 热更新 打开
hotOnly: true,

现在好像不需要了，我的是关闭的也可以热更新

没用啊

Doesn't seem to be related directly to Vue?
I don't see gzip or parsed sizes, it only shows stat size


how name the fax

Description
I'm making in first time the map, and i'm wanna to name the fax, like: Sender: SE.
P.s. i dont see any issue about this, if they exist, pls say me.

in mapping think you have to vv it aince no power also this is not an issue


How Can i want to add label as vertical center of connection line and also add background and border radius on this

I want to make like this

@jerosoler Can you please help here?

Virw

#18

@jerosoler I already seen this but i want to add background-color and border-radius in label and i also want to show label vertical center As per i given in attached image.
Thanks.

@jerosoler is there any update here?

@jerosoler Can you please help here?

Try this method  described in #18 and change with svg circle or html with svg foreignObject

I already try this method and how can i replace svg with html?

@jerosoler ?


What happens to my data?

There should be a note on the webpage as to what is going to happen to my data that I upload.
Is it safe to upload sensitive data?

Nothing happens to your data, it stays on your computer and is not transmitted anywhere.
If you want to be sure of that you can :

Check the source code
Open the "network" tab of your developer console (on chrome for exemple) and check that no external requests are made when you upload a csv

Still there should be a note telling people about this. Don't you think?


BUG Infinite loops in TempDatabase (fixes #8902)

Ugly, but so is the original implementation that this works around (swallowing an exception to trigger functionality)

The change seems acceptable to me – it's no worse than the exception swallower itself.
The PGSQL failures due to a VACUUM ANALYZE - wtf the are we calling VACUUM in a test suite for!? I'd suggest attacking is issue from that angle.

wtf the are we calling VACUUM in a test suite for!?

To answer this question: the config setting DBSchemaManager.check_and_repair_on_build is the only thing that determines whether DBSchemaManager::checkAndRepairTable() is called when updating a table during a dev/build operation, including a temp database build.
I suggest that we address this by somehow disabling check_and_repair_on_build for TempDatabases.
The approach that I would probably go with is:

Have an $options map argument to DBSchemaManager::schemaUpdate() where you can pass [ 'check_and_repair_on_build' => false ]. Note that for the implementation of that setting you will probably
Have that argument set the global config flag before executing $callback() and reset it afterward. Note that it needs to modify the statically acessible DBSchemaManager so that singleton(DataObjectClass)->requireTable() is able to access it, otherwise I'd suggest a solution that doesn't involve static state manipulation.
When calling schemaUpdate in TempDatabase::rebuildTables(), pass [ 'check_and_repair_on_build' => false ]

Arrrghghghgh, so this was an exception that was conveniently swallowed before on Postgres, and now surfaces? Why do I always seem to pick the goddamn rabbit hole PRs :D
Thanks for digging into this Sam! Your solution isn't easy because SQLite has it's own schemaUpdate() implementation that would break. We could change the public API signature here, but it would require setting upper and lower constraints on framework compat with SQLite, coordinated release management, etc - not super keen on that. Instead I've just taken your approach and put it into TempDatabase directly.

This gets my 👍.


Fixes Japanese translation

[x] Tests exist or have been written that cover this particular change.

Change Details:

Use ja locale instead of en in ja_test.go
Comment out calling ut.AddCardinal with locales.PluralRuleOne.

because cardinal plural rule 'One' does not exist for locale 'ja'.

@go-playground/admins

Coverage remained the same at 100.0% when pulling 106b067c20eb275aa55e5c8588c3441f1418d939 on akm:fix_ja_translation into 0277b12d53df79c9dbf7311cb07fa9c81ed621bb on go-playground:v9.


Cleaned up the options management in hocs

Will fix issues when not specifying a fragmentName or fragment in withDelete, now user only need to pass a collection and collectionName (default fragment will be used in this case). Also factorized code a bit to get a consistent behavior across hocs.
I wrote test but could not run them, I have trouble with @babel/runtime. Also I did not found out how to mock package methods like getCollection during tests.

Good idea :) Is it ok to merge now?

:+1:


Policy refactoring with automation and testing

Overview/Summary
This PR makes a fundamental change to the how we manage and test custom policies implemented as part of Azure landing zones.
This PR fixes/adds/changes/removes

Adds a new resource library containing individual policy definition and policy set definition resources as individual files
Adds a Bicep template used to programmatically generate a new policies.json file for the eslzArm Portal deployment
The new policies.json template is now designed to universally work across AzureCloud, AzureChinaCloud and AzureUsGovernment clouds
Adds new GitHub Action to automatically regenerate policies.json when relevant changes are detected in a PR
Adds new GitHub Action to perform static code analysis (linting) of the new src folder (also scans eslzArm folder but for reporting only)
Adds a new GitHub Action to perform automated testing of the eslzArm deployment, including a complete deployment and tear-down
Adds an updated version of the original EnterpriseScaleLibraryTools PowerShell module from the Terraform implementation, now rebranded as Alz.Tools and extended to include new functionality needed for broader use (will be re-usable for Terraform and Bicep implementations)
Adds a new GitHub Action to keep the Alz.Tools module up to date with the latest API versions
Includes minor (primarily cosmetic) updates to the eslzArm deployment to improve maintainability and control whilst running programmatically

Breaking Changes
None identified
Testing Evidence
AzureCloud
See test pipelines in GitHub Actions.
policies.json for AzureChinaCloud
Testing evidence to follow
policies.json for AzureUsGovernment

Testing URLs
n/a
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[ ] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.
[ ] Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@krowlandson I'll have a go with testing this in Azure China, will reach out when I have questions

I have one concern that we are using a Bicep data structure to store the configuration for the public/mc/ff policies.
This should be in a common data format like JSON or YAML.
I understand there is a feature request in the Bicep team for a new function (loadJsonContent()) but they have not committed to producing this. As a workaround to this I would like us to store the data as JSON/YAML, then convert this to Bicep in the absence of a loadJsonContent() func. This way we can start on the journey to have a machine readable definition for ALZ.


Error on display

When I run and load the page all I see is a grey screen with the word Error in a small red rectangle in the upper right.
The console displays this every time I run and then refresh the http://localhost:8000/ page:
$ ~/.display/run.js &
[1] 38756
$ Listening on http://undefined:8000
RangeError: msecs must be a non-negative finite number
at Object.exports.enroll (timers.js:160:11)
at Socket.setTimeout (net.js:329:12)
at /Users/adamlevy/.display/server.js:14:16
at Layer.handle [as handle_request] (/Users/adamlevy/.display/node_modules/express/lib/router/layer.js:82:5)
at next (/Users/adamlevy/.display/node_modules/express/lib/router/route.js:110:13)
at Route.dispatch (/Users/adamlevy/.display/node_modules/express/lib/router/route.js:91:3)
at Layer.handle [as handle_request] (/Users/adamlevy/.display/node_modules/express/lib/router/layer.js:82:5)
at /Users/adamlevy/.display/node_modules/express/lib/router/index.js:267:22
at Function.proto.process_params (/Users/adamlevy/.display/node_modules/express/lib/router/index.js:321:12)
at next (/Users/adamlevy/.display/node_modules/express/lib/router/index.js:261:10)

Thanks for the report. This seems like a problem caused after this commit to node: https://github.com/joyent/node/commit/f34757398fcc393685b4dfbcbdc692fb38332d6c
77ab8d07a987a280be83481e5aaaf105070902d9 reduces the timeout from Infinity to just really-large.

Can I do anything about that?

This should be fixed already. Let me know if you are still having trouble after pulling.

Fixed. Thank you.


View position is not correct when show keyboard

In special circumstances need to display a full-screen pop view controller.When the view controller show keyboard the view position is not correct.

For more detail: https://github.com/bawn/STPopupDemo

I got this same problem


Unable to build operator

It seems there are some dependencies missing from the project as I can't seem to build it
❯ go version
go version go1.8.3 darwin/amd64

❯ make install_deps build
glide install
[WARN]    The name listed in the config file (github.com/treacher/namespace-rolebinding-operator) does not match the current location (github.com/gugahoi/namespace-rolebinding-operator)
[WARN]    Lock file may be out of date. Hash check of YAML failed. You may need to run 'update'
[INFO]    Downloading dependencies. Please wait...
[INFO]    --> Found desired version locally github.com/davecgh/go-spew 782f4967f2dc4564575ca782fe2d04090b5faca8!
[INFO]    --> Found desired version locally github.com/emicklei/go-restful ff4f55a206334ef123e4f79bbf348980da81ca46!
[INFO]    --> Found desired version locally github.com/emicklei/go-restful-swagger12 dcef7f55730566d41eae5db10e7d6981829720f6!
[INFO]    --> Found desired version locally github.com/ghodss/yaml 73d445a93680fa1a78ae23a5839bad48f32ba1ee!
[INFO]    --> Found desired version locally github.com/go-openapi/jsonpointer 46af16f9f7b149af66e5d1bd010e3574dc06de98!
[INFO]    --> Found desired version locally github.com/go-openapi/jsonreference 13c6e3589ad90f49bd3e3bbe2c2cb3d7a4142272!
[INFO]    --> Found desired version locally github.com/go-openapi/spec 6aced65f8501fe1217321abf0749d354824ba2ff!
[INFO]    --> Found desired version locally github.com/go-openapi/swag 1d0bd113de87027671077d3c71eb3ac5d7dbba72!
[INFO]    --> Found desired version locally github.com/gogo/protobuf c0656edd0d9eab7c66d1eb0c568f9039345796f7!
[INFO]    --> Found desired version locally github.com/golang/glog 44145f04b68cf362d9c4df2182967c2275eaefed!
[INFO]    --> Found desired version locally github.com/google/gofuzz 44d81051d367757e1c7c6a5a86423ece9afcf63c!
[INFO]    --> Found desired version locally github.com/hashicorp/golang-lru a0d98a5f288019575c6d1f4bb1573fef2d1fcdc4!
[INFO]    --> Found desired version locally github.com/howeyc/gopass bf9dde6d0d2c004a008c27aaee91170c786f6db8!
[INFO]    --> Found desired version locally github.com/imdario/mergo<PHONE_NUMBER>c1639d9d78127b7d47c622b5d7b6dc!
[INFO]    --> Found desired version locally github.com/juju/ratelimit 5b9ff866471762aa2ab2dced63c9fb6f53921342!
[INFO]    --> Found desired version locally github.com/mailru/easyjson d5b7844b561a7bc640052f1b935f7b800330d7e0!
[INFO]    --> Found desired version locally github.com/PuerkitoBio/purell 8a290539e2e8629dbc4e6bad948158f790ec31f4!
[INFO]    --> Found desired version locally github.com/PuerkitoBio/urlesc 5bd2802263f21d8788851d5305584c82a5c75d7e!
[INFO]    --> Found desired version locally github.com/spf13/pflag 9ff6c6923cfffbcd502984b8e0c80539a94968b7!
[INFO]    --> Found desired version locally github.com/ugorji/go ded73eae5db7e7a0ef6f55aace87a2873c5d2b74!
[INFO]    --> Found desired version locally golang.org/x/crypto d172538b2cfce0c13cee31e647d0367aa8cd2486!
[INFO]    --> Found desired version locally golang.org/x/net f2499483f923065a842d38eb4c7f1927e6fc6e6d!
[INFO]    --> Found desired version locally golang.org/x/sys 8f0908ab3b2457e2e15403d3697c9ef5cb4b57a9!
[INFO]    --> Found desired version locally golang.org/x/text 2910a502d2bf9e43193af9d68ca516529614eed3!
[INFO]    --> Found desired version locally gopkg.in/inf.v0 3887ee99ecf07df5b447e9b00d9c0b2adaa9f3e4!
[INFO]    --> Found desired version locally gopkg.in/yaml.v2 53feefa2559fb8dfa8d81baad31be332c97d6c77!
[INFO]    --> Found desired version locally k8s.io/api e012d1a19ed30848135c78dca93b6d6a0f82d9e0!
[INFO]    --> Found desired version locally k8s.io/apimachinery dc1f89aff9a7509782bde3b68824c8043a3e58cc!
[INFO]    --> Found desired version locally k8s.io/client-go 9675d048204baf818bb24f7c74d0e64f6254902e!
[INFO]    --> Fetching github.com/googleapis/gnostic.
[INFO]    --> Fetching github.com/golang/protobuf.
[INFO]    Setting references.
[INFO]    --> Setting version for github.com/go-openapi/jsonpointer to 46af16f9f7b149af66e5d1bd010e3574dc06de98.
[INFO]    --> Setting version for github.com/mailru/easyjson to d5b7844b561a7bc640052f1b935f7b800330d7e0.
[INFO]    --> Setting version for github.com/PuerkitoBio/purell to 8a290539e2e8629dbc4e6bad948158f790ec31f4.
[INFO]    --> Setting version for github.com/go-openapi/jsonreference to 13c6e3589ad90f49bd3e3bbe2c2cb3d7a4142272.
[INFO]    --> Setting version for github.com/golang/protobuf to 4bd1920723d7b7c925de087aa32e2187708897f7.
[INFO]    --> Setting version for github.com/PuerkitoBio/urlesc to 5bd2802263f21d8788851d5305584c82a5c75d7e.
[INFO]    --> Setting version for github.com/google/gofuzz to 44d81051d367757e1c7c6a5a86423ece9afcf63c.
[INFO]    --> Setting version for github.com/golang/glog to 44145f04b68cf362d9c4df2182967c2275eaefed.
[INFO]    --> Setting version for github.com/juju/ratelimit to 5b9ff866471762aa2ab2dced63c9fb6f53921342.
[INFO]    --> Setting version for github.com/gogo/protobuf to c0656edd0d9eab7c66d1eb0c568f9039345796f7.
[INFO]    --> Setting version for github.com/googleapis/gnostic to 68f4ded48ba9414dab2ae69b3f0d69971da73aa5.
[INFO]    --> Setting version for github.com/ghodss/yaml to 73d445a93680fa1a78ae23a5839bad48f32ba1ee.
[INFO]    --> Setting version for github.com/ugorji/go to ded73eae5db7e7a0ef6f55aace87a2873c5d2b74.
[INFO]    --> Setting version for github.com/imdario/mergo to<PHONE_NUMBER>c1639d9d78127b7d47c622b5d7b6dc.
[INFO]    --> Setting version for github.com/go-openapi/spec to 6aced65f8501fe1217321abf0749d354824ba2ff.
[INFO]    --> Setting version for github.com/emicklei/go-restful-swagger12 to dcef7f55730566d41eae5db10e7d6981829720f6.
[INFO]    --> Setting version for github.com/davecgh/go-spew to 782f4967f2dc4564575ca782fe2d04090b5faca8.
[INFO]    --> Setting version for github.com/howeyc/gopass to bf9dde6d0d2c004a008c27aaee91170c786f6db8.
[INFO]    --> Setting version for github.com/hashicorp/golang-lru to a0d98a5f288019575c6d1f4bb1573fef2d1fcdc4.
[INFO]    --> Setting version for github.com/spf13/pflag to 9ff6c6923cfffbcd502984b8e0c80539a94968b7.
[INFO]    --> Setting version for github.com/emicklei/go-restful to ff4f55a206334ef123e4f79bbf348980da81ca46.
[INFO]    --> Setting version for github.com/go-openapi/swag to 1d0bd113de87027671077d3c71eb3ac5d7dbba72.
[INFO]    --> Setting version for golang.org/x/net to f2499483f923065a842d38eb4c7f1927e6fc6e6d.
[INFO]    --> Setting version for golang.org/x/crypto to d172538b2cfce0c13cee31e647d0367aa8cd2486.
[INFO]    --> Setting version for golang.org/x/sys to 8f0908ab3b2457e2e15403d3697c9ef5cb4b57a9.
[INFO]    --> Setting version for golang.org/x/text to 2910a502d2bf9e43193af9d68ca516529614eed3.
[INFO]    --> Setting version for k8s.io/api to e012d1a19ed30848135c78dca93b6d6a0f82d9e0.
[INFO]    --> Setting version for gopkg.in/yaml.v2 to 53feefa2559fb8dfa8d81baad31be332c97d6c77.
[INFO]    --> Setting version for gopkg.in/inf.v0 to 3887ee99ecf07df5b447e9b00d9c0b2adaa9f3e4.
[INFO]    --> Setting version for k8s.io/client-go to 9675d048204baf818bb24f7c74d0e64f6254902e.
[INFO]    --> Setting version for k8s.io/apimachinery to dc1f89aff9a7509782bde3b68824c8043a3e58cc.
[INFO]    Exporting resolved dependencies...
[INFO]    --> Exporting github.com/davecgh/go-spew
[INFO]    --> Exporting github.com/emicklei/go-restful
[INFO]    --> Exporting github.com/ghodss/yaml
[INFO]    --> Exporting github.com/emicklei/go-restful-swagger12
[INFO]    --> Exporting github.com/go-openapi/jsonpointer
[INFO]    --> Exporting github.com/golang/glog
[INFO]    --> Exporting github.com/golang/protobuf
[INFO]    --> Exporting github.com/imdario/mergo
[INFO]    --> Exporting github.com/go-openapi/swag
[INFO]    --> Exporting github.com/google/gofuzz
[INFO]    --> Exporting github.com/PuerkitoBio/urlesc
[INFO]    --> Exporting github.com/go-openapi/jsonreference
[INFO]    --> Exporting github.com/hashicorp/golang-lru
[INFO]    --> Exporting github.com/spf13/pflag
[INFO]    --> Exporting github.com/PuerkitoBio/purell
[INFO]    --> Exporting github.com/ugorji/go
[INFO]    --> Exporting github.com/go-openapi/spec
[INFO]    --> Exporting github.com/juju/ratelimit
[INFO]    --> Exporting github.com/gogo/protobuf
[INFO]    --> Exporting github.com/mailru/easyjson
[INFO]    --> Exporting github.com/howeyc/gopass
[INFO]    --> Exporting github.com/googleapis/gnostic
[INFO]    --> Exporting golang.org/x/crypto
[INFO]    --> Exporting golang.org/x/net
[INFO]    --> Exporting golang.org/x/sys
[INFO]    --> Exporting k8s.io/api
[INFO]    --> Exporting golang.org/x/text
[INFO]    --> Exporting gopkg.in/yaml.v2
[INFO]    --> Exporting k8s.io/apimachinery
[INFO]    --> Exporting gopkg.in/inf.v0
[INFO]    --> Exporting k8s.io/client-go
[INFO]    Replacing existing vendor dependencies
rm -rf bin/%/namespace-rolebinding-operator
go build -v -i -o bin/namespace-rolebinding-operator ./cmd
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:9:2: cannot find package "k8s.io/api/core/v1" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/api/core/v1 (from $GOROOT)
        /Users/guga/.go/src/k8s.io/api/core/v1 (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:10:2: cannot find package "k8s.io/api/rbac/v1beta1" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/api/rbac/v1beta1 (from $GOROOT)
        /Users/guga/.go/src/k8s.io/api/rbac/v1beta1 (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:11:2: cannot find package "k8s.io/apimachinery/pkg/apis/meta/v1" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/apimachinery/pkg/apis/meta/v1 (from $GOROOT)
        /Users/guga/.go/src/k8s.io/apimachinery/pkg/apis/meta/v1 (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:12:2: cannot find package "k8s.io/apimachinery/pkg/runtime" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/apimachinery/pkg/runtime (from $GOROOT)
        /Users/guga/.go/src/k8s.io/apimachinery/pkg/runtime (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:13:2: cannot find package "k8s.io/apimachinery/pkg/watch" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/apimachinery/pkg/watch (from $GOROOT)
        /Users/guga/.go/src/k8s.io/apimachinery/pkg/watch (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:14:2: cannot find package "k8s.io/client-go/kubernetes" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/client-go/kubernetes (from $GOROOT)
        /Users/guga/.go/src/k8s.io/client-go/kubernetes (from $GOPATH)
../../treacher/namespace-rolebinding-operator/pkg/controller/controller.go:15:2: cannot find package "k8s.io/client-go/tools/cache" in any of:
        /usr/local/Cellar/go/1.9/libexec/src/k8s.io/client-go/tools/cache (from $GOROOT)
        /Users/guga/.go/src/k8s.io/client-go/tools/cache (from $GOPATH)
make: *** [build] Error 1

Interesting, I just deleted all my dependencies and cloned a fresh copy and it worked fine.

Built fine today :shrug:


Review benchmark

Ref https://github.com/fractal-analytics-platform/fractal-server/pull/1379#issuecomment-2049945196

Closing, as it never took place again.


Ensure the selector property is present in JSON

What
Ensure the selector property is emitted in the JSON body to create
query text indexes.
Reviewers
None yet.
Issues
Fixes #31

I'd like to see a test that previously would fail.

@mikerhodes test added

I suggest squashing all three commits under something like:
Fix incorrect selector and fields handing when creating indexes

* selector wasn't put into the POST body at all.
* fields wasn't nested in the index field.

+1 with the squashing.


Posts after payout

If posts after their payout (7 days), voted by anyone, we should show tipping options or suggest tipping.

@feruzm Kindly close this issue because it has been done.


[Windows] Closing quickly after opening will crash

invalid issue.
if do not want follow the issue template  but at least has to point out the specific plugin.


Vulnerability roundup 100: go-1.14.15: 1 advisory [7.5]

search, files

[ ] CVE-2021-27918 CVSSv3=7.5 (nixos-20.09)

Scanned versions: nixos-20.09: 12d9950bf47.
Cc @Frostman
Cc @c00w
Cc @cstrahan
Cc @kalbasit
Cc @mdlayher
Cc @mic92
Cc @orivej
Cc @rvolosatovs
Cc @zowoq

I'll probably take a swing at killing go1.14 since it's officially deprecated.

20.09 is EOL.


audiowaveform: 1.4.2 -> 1.5.1, fix gtest subproject

Will be needed to fix build with gtest v1.11.0 (currently in staging-next #131928).
See https://github.com/bbc/audiowaveform/commit/7243739cb138e3952884786ba42694dd9ddc2c09

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134093 run on x86_64-darwin 1

1 package built:

audiowaveform

Looks good, very good catch!


proposal: Go 2: iota for strings (useful for enums)

Problem
We can write code like this:
const (
	MONDAY int = iota
	TUESDAY
	WEDNESDAY
	THURSDAY
	FRIDAY
	SATURDAY
	SUNDAY
)

But not like this:
const (
	MONDAY string = iota
	TUESDAY
	WEDNESDAY
	THURSDAY
	FRIDAY
	SATURDAY
	SUNDAY
)

Proposal
Make iota return strings with the same value as the const name.
Example, this:
const (
	MONDAY string = iota
	TUESDAY
	WEDNESDAY
	THURSDAY
	FRIDAY
	SATURDAY
	SUNDAY
)

Is equal to this:
const (
	MONDAY    = "MONDAY"
	TUESDAY   = "TUESDAY"
	WEDNESDAY = "WEDNESDAY"
	THURSDAY  = "THURSDAY"
	FRIDAY    = "FRIDAY"
	SATURDAY  = "SATURDAY"
	SUNDAY    = "SUNDAY"
)

Why?
Simple, it makes writing code that use such enums easier, less boring and less error prone.
One good example is writing code that deals with errors:
const (
	ERR_PASSWORD_TOO_SHORT string = iota
	ERR_SUPER_USER_PASSWORD_IN_USE
	ERR_FAILED_TO_VERIFY_PASSWORD_HIBP
	ERR_FAILED_TO_HASH_PASSWORD
)

Compatibility
Current Golang, gives this error when trying to compile code like the one proposed:
cannot convert 1 (type untyped number) to type string
As such I don't think that any old code will become incompatible.

While I like the idea, what would const Test = iota be? iota should always be an untyped integer constant. Perhaps a different name would be more fitting.

If the type is not specified it becomes a number just like today.
I agree that a sperate name would be better, maybe siota (s meaning string) or str_iota or string iota (with a space)

Why declare enum values as strings? Generally, you just need the values to be unique and simple, so integers are fine. If you need to represent them as strings, you can use https://godoc.org/golang.org/x/tools/cmd/stringer.

Because printing strings is easier than ints. I don't need a conversion function or a mapping table to print my errors and understand them.

This is precisely what String() methods are for, which is what stringer produces. fmt.Println(someEnumValue) will work out of the box with stringer, just like any %s or %v formatting.

I would have sometimes liked a feature such like this, but more often than not, I wouldn't want the string to match my constant name exactly. Worse, if one changes a constant's name, for instance when changing whether a constant is exported or not, the string would change, too, which seems not a desirable feature.
It also seems a bit unfortunate to "reuse" iota for this purpose: iota right now has a very simple definition: it's the (untyped integer) index of the constant declaration (specification, to be exact) starting at the const keyword. Giving it an extra meaning here adds complexity to the language for a relatively minor convenience.
But most importantly, we do have the stringer command as pointed out by @mvdan, which specifically addresses this problem. For a typical use with plenty of constants that need string names, see for instance $GOROOT/src/cmd/compile/internal/syntax/tokens.go. Specifically, the -linecomment gives you extra flexibility in the choice of string representation.
I'm not in favor of this proposal.

it seems to me that the most natural way to do it would be to allow
const (
	MONDAY = string(iota)
	TUESDAY
	WEDNESDAY
	THURSDAY
	FRIDAY
	SATURDAY
	SUNDAY
)

which keeps iota unchanged and adds the cast.

Thanks, but we already have the stringer tool, and that seems like the right tool for this job.


Integration Test - Release - 2019/03/19 17:51:36

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#backlog'

#pri2

#backlog

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


Ensure generation is pinned when downloading

We shouldn't start downloading a different generation due to resuming a download.
This may already work - needs investigation.

It looks like at the moment we don't perform download resumption anyway. We make a single request, copying the received data to the output stream in chunks.
We allow the user to specify a generation to download in the options, but that's all.
Closing this as it doesn't make sense to leave open on its own, but will discuss whether resumable downloads are a requirement.


Trading priorities

translate.google.com
Bot.json:
"SteamUserPermissions": {
  "maser1": 3,
  "master2": 3
},
"SteamTradeToken": "token1"

If SteamTradeToken NOT null, then send him (token1).
At the moment, is ignored SteamTradeToken, if the master in the friends list.
Can also solve the "problem" SteamUserPermissions multiple masters.

We recommend to set exactly one user as Master, and any amount you wish as Operators and below. While it's technically possible to set multiple Masters and ASF will work correctly with them, for example by accepting all of their trades sent to the bot, ASF will use only one of them (with lowest steam ID) for every action that requires a single target, for example a !loot request, so also properties like SendOnFarmingFinished or SendTradePeriod. If you perfectly understand those limitations, especially the fact that !loot request will always send items to the Master with lowest steam ID, regardless of the Master that actually executed the command, then you can define multiple users with Master permission here, but we still recommend a single master scheme - multiple masters scheme is discouraged.


Premake v5.0.0-alpha14 gmake2 (Linux) not adding custom commands via addMOCCustomBuildRule

Hi. I have some wiered behavior when using premake-qt with premake v5.0.0-alpha14 when I'm trying to add custom command, created with addMOCCustomBuildRule.
This is open source project, so I'll point to it's code. Main problem is that addMOCCustomBuildRule working on Windows and I can see lines like:
<Command Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">"C:\Qt\5.14.0\msvc2017_64/bin/moc" "../code/delta_qt/ui/logframe.h" -o "../code/delta_qt/qtgen/moc_logframe.cpp"  -DFXNAME="PS4Delta" -DFXNAME_WIDE=L"PS4Delta" -DDELTA_DBG -DNOMINMAX -DWIN32_LEAN_AND_MEAN -D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING -D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -Drsc_company="Dev-Force/Alpin-Dev" -Drsc_copyright="(C) Force67 2019-2020. All rights reserved" -Drsc_fileversion="<IP_ADDRESS>" -Drsc_productversion="<IP_ADDRESS>" -Drsc_internalname="delta-qt" -Drsc_productname="PS4Delta" -Drsc_originalname="delta-qt.dll" -Drsc_description="PS4Delta core - with qt" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_WIDGETS_LIB -DQT_OPENGL_LIB -DQT_QML_LIB -I"../code/delta_qt" -I"../code/common" -I"../code/common/utl" -I"../code/core" -I"../code/core/orbis" -I"../code/video_core" -I"../code/vendor/fmtlib/include" -I"../code/vendor/capstone/include" -I"../code/vendor/zlib" -I"../code/vendor/xbyak/xbyak" -I"C:/Qt/5.14.0/msvc2017_64/include" -I"C:/Qt/5.14.0/msvc2017_64/include/QtCore" -I"C:/Qt/5.14.0/msvc2017_64/include/QtGui" -I"C:/Qt/5.14.0/msvc2017_64/include/QtWidgets" -I"C:/Qt/5.14.0/msvc2017_64/include/QtOpenGL" -I"C:/Qt/5.14.0/msvc2017_64/include/QtQml" -I"../code/delta_qt/qtgen"</Command>
in delta-qt.vcxproj file:
https://ci.appveyor.com/project/q4a/ps4delta/builds/30674575/job/bowaalmkws2eg4gj#L58
But not working on Linux. There is no using /usr/bin/moc in delta-qt.make file:
https://ci.appveyor.com/project/q4a/ps4delta/builds/30674575/job/o75820tvxxki5h64#L453
Is this bug of premake, premake-qt or mine? Can you help me to fix it?
I already build lastest premake from source but error still here.
Also I added 2 prints to addMOCCustomBuildRule  in premake-qt:
https://github.com/q4a/ps4delta/blob/f9c30bce929c767ffebc3d00246177f75bca099e/tools/premake/premake-qt/qt.lua#L621
And got good custom commands on Windows:
https://ci.appveyor.com/project/q4a/ps4delta/builds/30674575/job/bowaalmkws2eg4gj#L24
And Linux:
https://ci.appveyor.com/project/q4a/ps4delta/builds/30674575/job/o75820tvxxki5h64#L413

Hi,
From the links you sent me, the problem seems to come from the uic tool. The second link you provided has the calls to /usr/bin/moc, and has the command lines to generate the moc files. But the error (at the end of the log) is:
#include "qtgen/ui_mainwindow.h"```

And indeed, it seems like the addon failed to generate the custom command to process mainwindow.ui ... I will need to investigate. It's been a while since I didn't use this addon, but from what I remember and from a quick look at `qt.lua`, if `moc` works, `uic` should also work (it's based on the `.ui` extension, so if the `mainwindow.ui` file is correctly added to the project, I don't understand why it doesn't generate the `uic` command line...)

I checked a bit, and it seems there's a problem in premake-core: in module/gmake2/gmake2_cpp.lua, line 178 and line 181.
On line 181, it seems the buildoutputs for the current file are tested, and if the current file has some, then it's added as a generated file.
But with the .ui file, line 178 creates a copy of the file configuration context with 0 build outputs ... and this is why line 181 skips adding the command.
(if you add a print(#filecfg.buildoutputs .. " -> " .. #shadowContext.buildoutputs) on line 180, you'll see that it prints 1 -> 0)
I don't know why it does this, but maybe you should raise an issue on the premake-core repository, and mention this one here. I'm not sure if this is a bug on premake-core or on Qt addon...
The only difference between the custom commands using moc and the ones using uic is that moc generates a .cpp file (which is a compilable file for which gmake2 generates a compilation rule) and uic generates a header file, which gmake2 seems to ignore...

Hi again,
I did a quick test to see if the problem is indeed coming from the Qt addon or the gmake2 action, and it seems that it is indeed something I do in the addon that is causing the bug (I'll post a comment on the issue you opened on the premake-core repo to let them know)
I'll have to figure out what's wrong though and it might take a bit of time, apologies in advance, but anyway, just wanted to let you know that I didn't forget this issue :p

hi!
I'm having similar troubles generating Makefile using gmake2.
I don't use UI tools from Qt, but use moc application, I have latest premake5 build for today - alpha15, and head revision of your repo.
When I insert logs into premake.extensions.qt.addMOCCustomBuildRule - I am able to see correctly produced moc'ing commands, but they don't appear in project Makefile, they are added to GENERATED and OBJECTS lists, but they never created by moc app using custom build steps, because no custom build steps are produced.
I have been able to use vs2017 config on Windows all the time, and this is first time I'm compiling on Ubuntu.
I have tried switching to gmake instead of gmake2, and it's producing custom build steps as required, but also fails to create output cpp files, as it seems to be treating relative paths wrong, I have changed to abspath in your script, and then moc is creating them in right place, and everything goes ok. That may be a problem of gmake (I'm about relative paths), because it's deprecated as it's noted in the docs, but currently I'm stick to that hack as it works in my environment.
I'm willing to help investigating that bug, can give repro steps, because I really want to use up-to-date and stable gmake2 option here.
Thanks!

Hi,
Sorry I don't have much time to work on this. The problem seems to be quite tricky: as you noticed, the addon's functions that generate the custom commands for the moc files are correctly called, but gmake2 doesn't seem to care, while gmake works fine. At first I thought that it was gmake2 that wasn't able to handle custom build commands, but I checked, and it does support them... So basically the problem seems to be some sort of combination of how I generate custom commands + how gmake2 handles them. Unfortunately I couldn't find what exactly.
I'll try to get back to this issue if I can find some spare time, but in the meantime if you find the bug, do not hesitate to comment here.
Regards

In the PR https://github.com/dcourtois/premake-qt/pull/21
I add 2 scripts one with that premake module, and one without.
For uic, the alternative is fine: you can use premake rule
Something like
rule "uic"
  display "uic"
  fileextension ".ui"
  buildmessage 'uic -o ../../obj/%{file.basename} %{file.relpath}'
  --buildinputs { "%{file.relpath}" }
  buildoutputs { path.join("obj", "ui_%{file.basename}.h") }
  buildcommands { path.join(QtRoot, "bin", "uic") .. " -o " .. path.join("../../obj", "ui_%{file.basename}.h") .. " %{file.relpath}" }

and then, in the project:
    rules { "uic" }

I will try to fix other generators.

Fixed by 16b7041ce2efd1f7ca36e334a0a3af187ade7c8f


use console-scripts in setup.py to define starting point

Currently it's unclear which script is the starting point of the app. If you use this:
https://setuptools.readthedocs.io/en/latest/userguide/entry_point.html#console-scripts
then you will be able to do:
$ neurobooth-os start
$ neurobooth-os copy_to_nas

etc without opening python console

closed by #60


shane/autofill-5.2.0

Reviewer:
Description:
Bumping Autofill to remove some debug errors being thrown
Steps to test this PR:

ensure Autofill still works as before for the extension (email protection)

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

@shakyShane either rebase+rebuild or merge https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/1447


Way to target multiple proxmox nodes in "target_node"

If you have a proxmox cluster already defined how to you go about spreading the creation out across multiple nodes?
Is there a way to just have it round robin create a resource on each node in a list?

@ginjiruu I've been doing it like this:
resource "proxmox_vm_qemu" "vm" {

	count           = var.vm_count
	target_node = element(var.proxmox_hosts, count.index)

where proxmox_hosts is a list of the proxmox names

Yeah that seemed to have worked perfectly for me. Thanks a ton

Does this work if you want to do more than 1 resouce per proxmox host?
Say 6 resources across 3 nodes?

j'ai ecris à fanny et pdh
De: "ginjiruu"<EMAIL_ADDRESS>À: "Telmate/terraform-provider-proxmox"<EMAIL_ADDRESS>Cc: "Subscribed"<EMAIL_ADDRESS>Envoyé: Mercredi 3 Mars 2021 13:12:17
Objet: Re: [Telmate/terraform-provider-proxmox] Way to target multiple proxmox nodes in "target_node" (#309)
Does this work if you want to do more than 1 resouce per proxmox host?
Say 6 resources across 3 nodes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [ https://github.com/Telmate/terraform-provider-proxmox/issues/309#issuecomment-789371610 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ACJ2BS2JUG422BYOPUVYHY3TBWLIDANCNFSM4YJEO6VA | unsubscribe ] .

@ginjiruu yup, so when terraform is told to create more VMs than proxmox hosts, it will use the count index until the last host, then circle back to the first like this:
vm1  ---> proxmox1
vm2 ---> proxmox2
vm3 ---> proxmox3
vm4 ---> proxmox1
vm5 ---> proxmox2
vm6 ---> proxmox3
vm7 ---> proxmox1
...
...
...


Implement snap-to feature for //pose/@rotation_type conversion

Desired behavior
Per proposal http://sdformat.org/tutorials?tut=better_pose_proposal&cat=pose_semantics_docs&, should allow conversion among rotation types (e.g. from `rpy_degrees
Alternatives considered
See proposal
Implementation suggestion
See proposal
Additional context
See proposal

@EricCousineau-TRI Is it possible to comment on proposals somewhere? Based on the motivation, I was wondering if the following alternative has been considered:
<pose>
  <value degrees="True">0 0 0 90 45 0</value>
</pose>

Making it degrees=False by default would make the entire thing backward compatible with 1.8.

@FirefoxMetzger , those are hosted at sdf_tutorials, i.e. https://github.com/ignitionrobotics/sdf_tutorials/pull/37

@chapulina Thanks :) Would I create an issue there to comment on a proposal, or what is the preferred approach?

Good question, I'd say it's best to open an issue here at sdformat for greater visibility. If you have specific suggestions, you could open a PR against the proposal.

FWIW, the option we're currently working in #589 is <pose rotation_type="rpy_radians/rpy_degrees/q_wxyz">. By default @rotation_type=rpy_radians so it would be backward compatible.

Thanks for pointing that out @azeey . I skimmed the PR and it does look like the better choice than <value degrees="True/False">.

Closing given merge of #689