DCOS_OSS-4054: Implement endpoint for delayed reset functionality

Implement the endpoint used for resetting
delayed services using the marathon API.
Closes https://jira.mesosphere.com/browse/DCOS_OSS-4054
Testing
Since this is just the api, we have to make some changes to the code to test it.

In dcos-ui/plugins/services/src/js/components/modals/ServiceModals.js change line 69 from
let deleteItem = force => this.props.actions.deleteService(service, force);
to
let deleteItem = force => this.props.actions.resetDelayedService(service, force);
In dcos-ui/plugins/services/src/js/events/MarathonActions.js
add console.log("success") on line 270 and console.log("error ", xhr) on line 275.
Create a service that should be running.
Example JSON:

{
  "id": "/non-delayed",
  "instances": 1,
  "portDefinitions": [],
  "container": {
    "type": "MESOS",
    "volumes": []
  },
  "cpus": 0.1,
  "mem": 128,
  "requirePorts": false,
  "networks": [],
  "healthChecks": [],
  "fetch": [],
  "constraints": [],
  "cmd": "sleep 1000"
}

Create a service that will be delayed.
Example JSON from the jira:

{
"id": "/delayed",
"backoffFactor": 10,
"backoffSeconds": 1,
"cmd": "exit 1",
"container": {
"type": "MESOS",
"volumes": []
},
"cpus": 0.1,
"disk": 0,
"instances": 10,
"maxLaunchDelaySeconds": 3600,
"mem": 10,
"gpus": 0,
"networks": [
{
"mode": "host"
}
],
"portDefinitions": [],
"requirePorts": false,
"upgradeStrategy": {
"maximumOverCapacity": 1,
"minimumHealthCapacity": 1
},
"killSelection": "YOUNGEST_FIRST",
"unreachableStrategy": {
"inactiveAfterSeconds": 0,
"expungeAfterSeconds": 0
},
"healthChecks": [],
"fetch": [],
"constraints": []
}

Try to delete (actually reset, we are just highjacking the modal) both of them and observe the console. Trying to reset the delayed one should result in a success, trying to delete the other one should result in an error.
Verify the same for pods.
Example JSON:
non-delayed

{
  "id": "/non-delayed-pod",
  "containers": [
    {
      "name": "container-1",
      "resources": {
        "cpus": 0.1,
        "mem": 128
      },
      "exec": {
        "command": {
          "shell": "sleep 1000"
        }
      }
    }
  ],
  "scaling": {
    "instances": 1,
    "kind": "fixed"
  },
  "networks": [
    {
      "mode": "host"
    }
  ],
  "volumes": [],
  "fetch": [],
  "scheduling": {
    "placement": {
      "constraints": []
    }
  }
}

delayed
{
  "id": "/delayed-pod",
  "version": "2019-05-28T11:20:07.349Z",
  "containers": [
    {
      "name": "container-1",
      "resources": {
        "cpus": 0.1,
        "mem": 10,
        "disk": 0,
        "gpus": 0
      },
      "exec": {
        "command": {
          "shell": "exit 1"
        }
      }
    }
  ],
  "networks": [
    {
      "mode": "host"
    }
  ],
  "scaling": {
    "instances": 10,
    "kind": "fixed"
  },
  "scheduling": {
    "backoff": {
      "backoff": 1,
      "backoffFactor": 1.15,
      "maxLaunchDelay": 300
    },
    "upgrade": {
      "minimumHealthCapacity": 1,
      "maximumOverCapacity": 1
    },
    "killSelection": "YOUNGEST_FIRST",
    "unreachableStrategy": {
      "inactiveAfterSeconds": 0,
      "expungeAfterSeconds": 0
    },
    "placement": {
      "constraints": []
    }
  },
  "executorResources": {
    "cpus": 0.1,
    "mem": 32,
    "disk": 10
  },
  "volumes": [],
  "fetch": []
}

Verify that the added tests make sense.

Trade-offs
None.
Dependencies
None.
Screenshots

That same "filter by zone" test is failing. Retriggered.

Merging as phillip also approved earlier on 👍


remove duplicated tasks bar component #75

After the quick look I see that after checkout to PR branch. I guess this is not what We want. I check it for solution.

@miniMax18 fixed :) take a look now

This is legit right now 👍 well done @mniegrzybowska and @katarzynaFronc 🥇

can you approve so that we can merge @miniMax18 ?


New Feature Request : IIS Http  Security Headers

Issue:
The script is detecting TLS and more configuration about IIS,. There are no details for IIS Security Headers.
Reason:
Microsoft announced some of articles about EXchange and IIS as below,
https://techcommunity.microsoft.com/t5/iis-support-blog/remove-unwanted-http-response-headers/ba-p/369710
But in the script there is no reviewing metric for http header details
Fix:
could you please add reviewing http header settings for following setting as in best practices
X Frame Options
X XSS Protection
X Content Type Options
X Permitted Cross Domain Policies
Strict Transport Security
Content Security Policy
Referrer Policy
Feature Policy
Expect CT
Validation:
N/A

Closing PR as there are no changes.
@bill-long we need to figure out how this PR was able to be created as I don't think contributors should be able to create a PR from branches within our own repository.


Fine tuning NLLB

❓ Questions and Help
Before asking:

search the issues.
search the docs.

My question?
I am trying to fine-tune the NLLB model on the Moroccan Arabic and English languages. I prepared my data using the "Filtering and Preparing the Data" pipeline as described in the ReadMe. The result of the Prepare Data step is the following directory:

The second step now is to fine tune the model, I used this command:
DROP=0.1
python examples/nllb/modeling/train/train_script.py cfg=nllb200_dense3.3B_finetune_on_fbseed  cfg/dataset=bilingual cfg.dataset.lang_pairs="ary_Arab-eng_Latn"  cfg.fairseq_root=/home/docker/notebooks/khadija/Translation_with_NLLB-200/fairseq     cfg.output_dir=model_fine_tuned cfg.dropout=$DROP  cfg.warmup=10     cfg.finetune_from_model=/home/docker/notebooks/khadija/Translation_with_NLLB-200/checkpoint.pt
The bilingual.yaml file is as follows:

But I get this error when I run the command:

Can you help me please? Is there anything I've missed?
What's your environment?

fairseq Version : 1.0.0a0
PyTorch Version: 1.13.0
OS : Linux Ubuntu 20.04.4 LTS
How you installed fairseq: (pip, source):
Python version: 3.8
CUDA/cuDNN version: Cuda 11.1, cuDNN 8

Hi, could you share your insights on this issue? Were you able to fine-tune the model?


Hello, what is the CesiumDev directory under the build folder for?

Hello, what is the CesiumDev directory under the build folder for?

Hi, this is a temporary build directory generated by running npm start.  The start task will watch for changes to code and rebuild artifacts as needed upon request. We don't want to override the other build artifacts generated by the build and release tasks, so CesiumDev is used.
CesiumJS is a big project, so we use GitHub for feature requests and bug tracking exclusively. In the future, please take any questions to the Cesium Forum where there are members of the community and developers from the team who can help. Thanks!


Arangobench unreliable behavior

My Environment

ArangoDB Version:        3.11
Deployment Mode:       Single Server (local Docker)
Deployment Strategy:   docker compose up
Operating System:        Using arangodb:3.11.1 as Docker image, and MacOS Sonoma 14.0
Total RAM in your machine:       10 GB

Component, Query & Data
Affected feature: arangobench
AQL query (if applicable):
Note that there is a typo and that is intentional, more on this later.
LET foo_children = (FOR vertex IN 1..9999 OUTBOUND 'foos/878' GRAPH loadtest_graph
            LET next = (FOR v IN OUTBOUND vertex GRAPH loadtest_graph LIMIT 1 RETURN true)
            FILTER LENGTH(next) == 0
            RETURN vertex)

LET bar_children = (FOR vertex IN 1..9999 OUTBOUND 'burs/1' GRAPH loadtest_graph
            LET next = (FOR v IN OUTBOUND vertex GRAPH loadtest_graph LIMIT 1 RETURN true)
            FILTER LENGTH(next) == 0
            RETURN vertex)

RETURN INTERSECTION(foo_children, bar_children)

Steps to reproduce
My dataset is too big to dump here, but simply create 4 collections:

foos
bars
bazs
default(edge)

with the following graph:
foos/1 --> bazs/1 <-- bars/1

and run:
arangobench --server.endpoint tcp://arango:8529 \
	    --server.username root \
            --server.password test \
            --server.database loadtest_db \
            --collection foo \
            --collection bar \
            --collection baz \
            --collection default \
            --requests 10 \
            --test-case custom-query
            --custom-query-file ./query-file.txt  \
            --json-report-file ./report.json \
            --log debug

Problem:
The problem is that I get an actual output:
{"totalNumberOfOperations":10,"runs":1,"keepAlive":true,"async":false,"batchSize":0,"replicationFactor":1,"numberOfShards":1,"waitForSync":false,"concurrencyLevel":10,"testCase":"custom-query","complexity":1,"database":"loadtest_db","collection":"default","results":{"requestTime":0.04450821876525879,"requestResponseDurationPerThread":0.0044508218765258786,"timeNeededPerOperation":0.0014653444290161134,"timeNeededPerOperationPerThread":0.014653444290161133,"operationsPerSecondRate":682.4334130586876,"timeSinceStart":0.014653444290161133,"failures":0,"incompleteResults":0},"min":0.0037221908569335938,"avg":0.0044508218765258786,"max":0.007030963897705078}

This is a problem because:

It seems that I can only specify 1 collection while my query uses 4. The report has only the last one in there
I put a typo in my second LET AQL, note the starting node, bur/1 instead of bar/1. This is an error as there is no such collection. Since this does not error out, I cannot trust these results. I don't know if these numbers relate to my test succeeding or failing. Note that even if I fix this typo, there may be another error I don't know about during runtime.

here is my arangobench output as well:
/loadtest # arangobench --server.endpoint tcp://arango:8529 --server.username root --server.password test --server.database loadtest_db --collection foos --collection bars --collection bazs --collection default --requests 10 --test-case custom-query --custom-query-file ./query-file.txt --json-report-file ./report.json --log debug
2024-03-13T20:49:43Z [398] DEBUG {config} found config file '/etc/arangodb3/arangobench.conf'
2024-03-13T20:49:43Z [398] DEBUG {config} loading '/etc/arangodb3/arangobench.conf'
2024-03-13T20:49:43Z [398] WARNING [78b1e] {startup} option '--log' is deprecated since v3.5.0
2024-03-13T20:49:43Z [398] INFO [69091] {bench} Running test case 'custom-query': executes a custom AQL query, that can be specified either via the --custom-query option or be read from a file specified via the --custom-query-file option. The query will be executed as many times as the value of --requests. The --complexity parameter is not used.
2024-03-13T20:49:43Z [398] INFO [a6905] {bench} starting threads...
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] DEBUG [3906e] {general} connecting to ip endpoint 'http+tcp://arango:8529'
2024-03-13T20:49:43Z [398] INFO [a6905] {bench} executing tests...

Total number of operations: 10, runs: 1, keep alive: yes, async: no, batch size: 0, replication factor: 1, number of shards: 1, wait for sync: false, concurrency level (threads): 10
Test case: custom-query, complexity: 1, database: 'loadtest_db', collection: 'default'
Total request/response duration (sum of all threads): 0.044508 s
Request/response duration (per thread): 0.004451 s
Time needed per operation: 0.001465 s
Time needed per operation per thread: 0.014653 s
Operations per second rate: 682.433413
Elapsed time since start: 0.014653 s

Min request time: 3.7222ms
Avg request time: 4.4508ms
Max request time: 7.0310ms

Expected result:

Using all 4 collections (if the --collection flag is used for other purposes some clarification on this in the docs would help)
Error log or stopping execution, or options to that end, if there is an error in the test query.

I may be misusing this command too, please advise. Many thanks.

@maininformer : the --collection option is ignored when using --custom-query or --custom-query-file.
When using a custom query, all that matters to arangobench is the actual custom query. So not declaring all collections used in the query via the --collection option is not an error.
When using a non-existing collection in the custom query, the query will fail. The same is true for any other hard errors. arangobench will even print warnings about this, such as:
2024-03-14T08:26:23Z [6568] WARNING [fb835] {bench} single request for URL '/_api/cursor: got invalid response from server: HTTP 404: 'Not Found'
2024-03-14T08:26:23Z [6568] WARNING [6daf1] {bench} ...more warnings...
...
2024-03-14T08:26:23Z [6568] WARNING [a826b] {bench} 1000 arangobench request(s) failed!

In case of hard errors, the generated results JSON file will also contain these in the "failures" attribute.
Regarding the typo in your collection names inside the traversal (i.e. FOR vertex IN 1..9999 OUTBOUND 'foos/878' GRAPH loadtest_graph instead of FOR vertex IN 1..9999 OUTBOUND 'foo/878' GRAPH loadtest_graph):
This is not considered a hard error by ArangoDB, as during query parsing 'foos/878' is just a string literal.
You can even run this query in ArangoDB just fine (at least on single server), as there may be edges starting at foos/878 in any of the edge collections used in the graph.

Thank you this is helpful.


odo should allows user to customize project deletion timeout

User Story
As a user I want to be able to customize project deletion timeout so that I can wait for longer/shorter time for a project to be deleted. Current default of 3 minutes is not configurable.
As a user, I might want longer timeout for slower/latent connection or for a project that's got large number of resources (services, components, etc.) started within it. I might want a shorter timeout for quicker feedback since I'm working on an air-gapped environment.
Acceptance Criteria

[ ] odo preference command should have the feature to set/unset the project deletion timeout

Links

Related issue: #1884, #2397
Originally discussed in PR review at https://github.com/openshift/odo/pull/2397#discussion_r420573695.

/kind user-story
/kind discussion
/area project

We have alot of times, I cannot keep track of them. We need to generalise this to a timeout that already exists - by renaming an existing timeout if need be

Current default of 3 minutes is not configurable.

Thinking out loud - 3 minutes should be enough for most environments. Closing this since it hasn't come up as a concern from anyone yet. Re-open if it becomes relevant at some point.
/close


fix: Updated the artifact upload version

Updated the artifact upload version

:tada: This PR is included in version 1.4.0-next.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix fix bind using join for compatible with MySQL behavior

Proposed changes
fix bind slot in using join for compatible with MySQL behavior
for example
select *
from t1
left join t2 using(id)
left join t3 using(id)

we should generate the join condition:

t1.id = t2.id
t1.id = t3.id,  previously, it was t2.id = t3.id

run buildall

run buildall

run buildall


Measure downtime on image tag update

Does updates cause any downtime?

Short answer: works!
Recorded a short clip: https://youtu.be/WdFvWA1olPc


[WIP] Feat(pagination): Implements Pagination Component

fixes #32

Thanks @mattnolting
I in PTO until Monday.
I will merge work on your comments on Monday.

Hello @mattnolting,
my goal with this PR was to try to compose with existing components and see if we can have the pagination component without a lot of work.
This is why all variables are inlined. Obviously I will remove this in the future.
I would like to have your feeling on this one https://github.com/patternfly/patternfly-next/issues/878
You can probably reach the pf team more easily and have a quicker decision.

I would like to have your feeling on this one #878
You can probably reach the pf team more easily and have a quicker decision.

I'd do .pf-c-pagination .pf-c-button.pf-m-disabled { background: transparent; }. Then revisit after design review.

hey @guillaumevincent are you able to update this PR with the suggestions from @mattnolting? Let us know if you have any questions or concerns with this. Thanks!

@matthewcarleton I propose to close this PR and @mattnolting can copy this PR or start a new one.
@mattnolting can you take the lead on a new PR to push the pagination component?
I'm a little busy right now


English version

Hi! Very nice work, thanks!
What could be the best way to add english version as well?

yes,please!

please please please


[Feature Request] Support for tests

tl;dr: It would be great to provide a way to run tests without worrying the gem will prevent consecutive runs to be successful. This could be provided in the form of a specific method/implementation enhancement or at least with some guidance in the docs.
Problem
I've experienced in my project that some tests when run twice in a row they fail in the second run. This happens because RateLimit.throttle! is failing the second time.
To solve the problem, as we're using Redis, I've added Redis.new.flushall to the before statement in our rails_helper.
Solution
It would be great if there was a way to configure the gem itself to prevent this from happening, like setting it to test mode.
Otherwise, maybe at least adding some guidance to the docs on how to deal with such scenario would also be fine.

It would be great if there was a way to configure the gem itself to prevent this from happening, like setting it to test mode.

I don't know how this would work, especially since test scenarios can be very diverse.
IMO a good option would be to introduce
RateLimit.clear_all_counters

which for now would just wrap RateLimit.config.flushall but abstract away the internal mechanisms from the tests.

Thanks for the request. I'm going to add some new issues to support multiple cache adaptors and improvement for the overall caching layer. Then we can pick this issue during that milestone 👍


Moming

精简ParaSum的数据集， 仅保留CNNDM数据集作为说明

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: momingTang:x: TangMomingmomingTang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(curriculum): create performance quiz

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56226

I know this was approved already, but could we include a question on INP as well?
The article even has a few quizzes at the bottom if we need inspiration.
https://web.dev/articles/inp

BTW, I'm out of the loop on these quizzes. What is the knowledge base they are founded upon?
Is it answers to questions we have given at some point in the curriculum, or just stand-alone quizzes with no direct connection to the curriculum?

@lasjorg It's for the new curriculum, the lectures are WIP right now

@naomi-lgbt @ilenia-magoni Do you want me to add a question on Interaction to Next Paint (INP), or are these questions good enough?

@ilenia-magoni Then let me rephrase it, how does the camper know the answers?
Surely it isn't expected that challenges will be created that contain answers to all the questions asked? That would cause the quizzes to dictate the challenge content.

@lasjorg the lectures should contain the knowledge needed for the quizzes

@ilenia-magoni OK, just seems a little backwards to me. But I get the motivation.

@AryanBhirud
If you want to add one question on INP that is fine.
If you are already at 20 questions, then you will need to replace one of these questions with the INP one because each quiz should have a max of 20 questions.

@jdwilkin4 I have replaced a question with a new one on INP. Awaiting review.


ipc_service: nocopy tx buffer allocation works unexpectedly with RPMSG backend

Describe the bug
Target platform: nrf5340dk_nrf5340
Application: Internal tests that uses ipc_service with RPMSG backend.
int ipc_service_get_tx_buffer(struct ipc_ept *ept, void **data, uint32_t *size, k_timeout_t wait) can return after 15 seconds with NULL pointer when timeout is set to K_FOREVER when there is not possibility to allocates buffer due to shared memory being full. I would expect that this function should wait forever for free place for buffer if shared memory is full and function is called with K_FOREVER parameter.
The second issue is that the ipc_service_get_tx_buffer can only allocates buffer with fixed size of RPMSG_BUFFER_SIZE - sizeof(struct rpmsg_hdr) and currently there is not option other than adding build time definition to set RPMSG_BUFFER_SIZE to size different than 512 bytes. It would be good to have this parameter configurable at least from Kconfig during build time but the perfect solution would be to add possibility to allocate buffer which could contain a few continuous block of memory to fit data bigger than  RPMSG_BUFFER_SIZE because sometimes we need to allocate buffer just for few bytes but in other case it can be over 1Kb.
To Reproduce
Run any application that uses IPC with RPMSG backend and try to pass more data that can fit into a shared memory. For example buffers can be hold on the Rx remote side without being fired. When the shared memory will be full then allocation of the next Tx buffer will exit after 15 seconds setting the data pointer to the NULL.
Expected behavior

int ipc_service_get_tx_buffer(struct ipc_ept *ept, void **data, uint32_t *size, k_timeout_t wait) should wait forever for free place in shared memory when wait parameter is set to K_FOREVER.
Maximum  requested Tx buffer size should be configurable at least from the Kconfig. The perfect solutions would be buffer allocation where the place for data could be composed of several contiguous memory blocks if data doesn't fit into single block.

Impact
Implementation that use int ipc_service_get_tx_buffer(struct ipc_ept *ept, void **data, uint32_t *size, k_timeout_t wait) with wait time set to forever may failed unexpectedly if this function returns with NULL pointer due to shared memory being full.
It is not possible to sent more data than RPMSG_BUFFER_SIZE - sizeof(struct rpmsg_hdr) through IPC service with RPMSG when nocopy mechanism is used.

In case of returning with K_FOREVER. On the remote side the ipc_service_get_tx_buffer can even return without waiting any time here: https://github.com/zephyrproject-rtos/zephyr/blob/70dbf7e695d24067ded1e041f39bac9f577abbf0/subsys/ipc/ipc_service/backends/ipc_rpmsg_static_vrings.c#L538
if the shared memory is full the get_tx_buffer_size returns 0 as a buffer size. So I would consider it as a bug since I would expect to wait for available buffer forever but instead of this on remote side I return immediately with ENOMEM error and  theipc_service_get_tx_buffer return 0 as a max buffer size but on the master side it waits maximum 15 seconds for a free buffer.
I can agree that second issue can be considered as a feature.

In case of returning with K_FOREVER. On the remote side the ipc_service_get_tx_buffer can even return without waiting any time here:
https://github.com/zephyrproject-rtos/zephyr/blob/70dbf7e695d24067ded1e041f39bac9f577abbf0/subsys/ipc/ipc_service/backends/ipc_rpmsg_static_vrings.c#L538
if the shared memory is full the get_tx_buffer_size returns 0 as a buffer size. So I would consider it as a bug since I would expect to wait for available buffer forever but instead of this on remote side I return immediately with ENOMEM error and theipc_service_get_tx_buffer return 0 as a max buffer size but on the master side it waits maximum 15 seconds for a free buffer.
I can agree that second issue can be considered as a feature.

I see that there is an asymmetry between remote and host about this. I'll try to see if we can fix this without involving OpenAMP.


Support Llama-3-8B-Instruct Model 2 types of EOS tokens - Update utils.py

To fit with Llama-3-8B-Instruct Model, which have 2 types of EOS tokens ("<|end_of_text|>" and "<|eot_id|>"), I add an optional parameter (eos_token_ids) of generate function to receive an array of EOS tokens for Llama-3-8B-Instruct Model and changed the for-loop break check as "if token in eos_token_ids:". If the function does not receive any eos_token_ids as an input, it is by default using "[tokenizer.eos_token_id]" which keep the function can break for-loop, just like the previous version.

My understanding is that the instruct model uses <|eot_id|> not <|end_of_text|>. I don't think we need to support multiple end of sentence tokens. The instruct models just need to have the eos token configured properly as they do in the mlx-community: https://huggingface.co/mlx-community/Meta-Llama-3-8B-Instruct-4bit/blob/main/special_tokens_map.json#L10


WIP: appointemnet service

🍒
Service Layer Refactoring:
Introduced clearer separation of concerns in AppointmentService.
Extracted complex logic into smaller, more manageable methods.
Enhanced error handling and logging for better transparency and maintainability.
Kafka Integration:
Configured KafkaTemplate<String, Object> to handle diverse message types, allowing for flexible message publishing across different business needs.
Added Kafka messaging for both payment processing (payment-request-topic) and appointment cancellations (cancellation-topic).
New REST Controller Endpoints:
Developed a new endpoint in AppointmentController for booking appointments, supporting both physical and online payments.
Added a cancellation endpoint that processes cancellation requests and communicates changes via Kafka.
Added a callback for payment service
Tests :)
Introduced CancellationRequest DTO for handling appointment cancellations.
Refined model consistency and interactions, especially with new status updates and Kafka message formats.


[Event Request] page 6510 "Item Tracking Lines" OnCalculateSumsAfterCalcSums

Hello,
Is it possible to get the following event:
procedure CalculateSums()
var
    xTrackingSpec: Record "Tracking Specification";
begin
    xTrackingSpec.Copy(Rec);
    Rec.Reset();
    Rec.CalcSums("Quantity (Base)", "Qty. to Handle (Base)", "Qty. to Invoice (Base)");
    // DINNL <<
    DINOnCalculateSumsAfterCalcSums(Rec);
    // DINNL >>
    TotalItemTrackingLine := Rec;
    Rec.Copy(xTrackingSpec);

    UpdateUndefinedQtyArray();
end;

[IntegrationEvent(false, false)]
local procedure DINOnCalculateSumsAfterCalcSums(var TrackingSpecification: Record "Tracking Specification");
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Compiler allows unconstrained impl type parameters.

While implementing #1118, stumbled upon a bug: https://github.com/FuelLabs/sway/runs/5819569715?check_suite_focus=true
Note: the old codegen also errors, but with a different error.

Another instance of generic types leaking into IR.. all generic types should be resolved before IR generation. The error in the old codegen is likely just a symptom of the same problem.

This was the smallest repro I could come up with:
script;

struct S { }

impl<T> S {
  fn use_asm(self, value: T) {
    asm(size: size_of::<T>()) {
      aloc size;
    };
  }
}

fn main() {
    (S{}).use_asm(true);
}

It appears that the ASM block isn't copying the T type.  Note that the bug didn't arise when just using a generic function, it seemed to need to be in a generic impl.

Could be tackled alongside #1103 and/or maybe #1116?

I have a feeling this is where it needs to be fixed, as the problem is the trait method hasn't resolved T: https://github.com/FuelLabs/sway/blob/9fde15ff4232ad71a81bc5fa913576124a0d64a4/sway-core/src/semantic_analysis/ast_node/declaration.rs#L578
But I'm not sure.  @emilyaherbert @sezna do you have any ideas?  What does that comment mean?

That comment is pretty vague and I feel like I probably wrote it, sorry about that. I believe what I meant was that the methods in a trait declaration are stored as un-type-checked until the trait is implemented, since they could be relatively generic and not have all the necessary type info.

I'm still not sure what the solution is here.  I think the issue is that the struct itself doesn't have any type parameters, only the impl.  So the monomorphisation process currently starts with 'generic' type mappings which get resolved via copy_types() but these are all instantiated by typed function decls, typed struct decls or typed enum decls.
In the above we need the same but for typed impl decls, which isn't quite the same..?  The line I quoted above with the comment is in a TypedTraitDeclaration but as you say, a trait's methods aren't type checked until instantiated.  I think we instantiate them as TypedFunctionDeclarations but in the case of f() in my repro, T is not resolved.  But is this true for all trait methods or am I missing something?  Let me check...

Now I'm starting to think this will be fixed by #948.  It's impossible to explicitly create a trait with generics at the moment, but that's pretty much what we do in this repro, I think?

Could we force the generic type to be in the struct declaration? In the code I'm writing for Vec, I expect the RawVec to be generic.
struct S<T> { }

impl<T> S<T> {
  fn f(self, value: T) {
    size_of::<T>();
  }
}

Wait, I thought that required. Generic structs should need type parameters...
The code below with no type parameters on the struct declaration does not look sane to me:
struct S { }

impl<T> S {
  fn f(self, value: T) {
    size_of::<T>();
  }
}

Aha, well, I thought it might work... the compiler doesn't complain but maybe it should.  Rust:
error[E0207]: the type parameter `T` is not constrained by the impl trait, self type, or predicates
 --> src/main.rs:5:6
  |
5 | impl<T> S {
  |      ^ unconstrained type parameter

For more information about this error, try `rustc --explain E0207`.

@mohammadfawaz I don't think this is still critical?

If it's blocking Vec that's only because you're trying to use the malformed declarations.  I think even if you give RawVec a T but don't use it, we still have the same problem.  Rust again:
  |
3 | struct S<T> { }
  |          ^ unused parameter
  |
  = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`
  = help: if you intended `T` to be a const parameter, use `const T: usize` instead

I think the solution is not to use T for RawVec, but instead include the item size as a field, and then alloc with that.  You're only needing T for size_of in there.  Vec can still have T as is...

Hm, interesting workaround. I'll investigate and report back.

Tried that and there's a problem! If I remove the generic on RawVec, then Vec is
pub struct Vec<T> {
    buf: RawVec,
    len: u64,
}

which now also results in a compiler error! I don't think there's any way to make specific methods generic if the struct itself is not generic, right?

Hrmm, I guess the solution is to put a dummy T field into RawVec but not use it, just to get it to type check?
It seems we need pointers, so that buf could actually be a *T, etc.
This is kinda where impl<T> S { ... } makes sense to me, if the methods use T it shouldn't matter whether S does or not.

I considered that, but it's a very non-ideal workaround because it would fundamentally change the ABI representation of Vecs. It's also not obvious how to get an instance of a T without knowing anything about T.

I believe that the example we are discussing here is malformed. In Rust the closest approximation is this:
use core::mem::size_of;

struct S { }

impl S {
  fn f<T>(self, value: T) {
    size_of::<T>();
  }
}

fn main() {
    (S{}).f(true);
}

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f9858aca30c642a70975fb529d222609
I actually don't know if this will work in Sway or not. Is this what you had in mind for this issue @adlerjohn ?

Aha, well, I thought it might work... the compiler doesn't complain but maybe it should.

I think maybe this is the problem @otrho .

From my understanding, impls with generics should only be valid if the struct/enum/trait has a generic type, otherwise function, specific generics should go in the type parameters of the associated method in the impl.

Are you working on this @otrho ? If not, I'm happy to take it.

Is there a reason to forbid a struct from being generic even if non of its fields are generic? It doesn't seem to inherently hurt, and unlocks a way to do Vec without forcing the user to specify the generic type every single time they call a function.

How about instead we allow the user to use Vec without having to specify the generics? I think that they should be allowed to omit the generics if the compiler is able to infer the types. The reason why this doesn't work now in the compiler is either due to a bug or due to the specific relevant inference algorithms not being implemented. I would have to dive into more to figure out what is missing.
Personally I don't think it would be a good user experience to allow users to add generics to structs that are basically no-ops.

Is there a reason to forbid a struct from being generic even if non of its fields are generic? It doesn't seem to inherently hurt, and unlocks a way to do Vec without forcing the user to specify the generic type every single time they call a function.

it just feels kinda messy right? monomorphization would be a no-op though as Emily said. Although being messy doesn't inherently mean it should be disallowed.
In Rust, the <T> in vec ultimately resolves to this T:
https://docs.rs/rust-libcore/0.0.2/src/core/.cargo/registry/src/github.com-1ecc6299db9ec823/rust-libcore-0.0.2/rust/src/libcore/ptr.rs.html#685
That T is just a constant pointer, i.e. what we are currently calling a u64. That's the difference between us and Rust here. And that generic in Rust's case isn't even really doing any type system magic, it just boils down to a raw pointer, basically a u64 just like us...because of that, I'm kind of in favor of allowing the noop generic for this specific pattern, since we likely won't implement reference logic to the same degree of intensity that Rust has.

Ah! This is exactly why Rust has PhantomData. For types that represent a type in an unsafe way and can't use the type system to represent it.
PhantomData is zero-sized but takes a type argument, signifying that the struct contains something of that type even if it is a raw pointer/u64.
@adlerjohn you could take a stab at implementing PhantomData?

After much discussion, we have decided to allow unused generics and not implement PhantomData.

After much discussion

That, uh, one way of putting it :joy:

What is the current status of the situation with this issue?

I'm working on it, ETA early next week.

I've spent some time with this and I'm going to document my thoughts here, for my own sanity:
Right now, generic types are stored in a field's type. E.g., the following struct declaration: ```rust
struct Test { a: T }
gets stored as (pseudo)
```rust
struct {
  name: Test,
  fields: [{name: a, type: T}]
}

Note that the type parameters themselves are not stored in the type. Just the fields. This means that if you declare a struct like this:
struct Foo<T> {}

Then you get a type like this:
struct {
  name: Foo,
  fields: []
}

Unfortunately, this means that you need to use a type parameter in order for the type system to understand your type and not incorrectly consider the types the same.
My solution to this is going to be to change struct and enum types. They should contain the type parameters within their type info, and the fields should be references to those type parameters. This will require some reworking of monomorphization but should otherwise be a drop-in change.

After https://github.com/FuelLabs/sway/pull/1746 it seems that the Vec library from https://github.com/FuelLabs/sway/pull/1118 successfully builds https://github.com/FuelLabs/sway/pull/1750. Are we able to close this issue?

Closed by https://github.com/FuelLabs/sway/pull/1746

Ah I see @sezna, I had added this line which was allowing it to pass: https://github.com/FuelLabs/sway/blob/7bae662ac48326fcdf2d2164ff6aaba635849fb7/test/src/e2e_vm_tests/test_programs/should_pass/language/vec/src/main.sw#L14
I'll reopen and investigate!

@sezna  I forget where we left things after the sync call---am I writing the fix that disallows @otrho code? (i.e. disallows declaring a generic param on an impl, when the type implementing for does not take a generic param)


Draw mean line for unsorted data change

Fixes disappearing mean line on 'Plot Type' change before sorting.
Still having issues with selection in Safari. May be due to afqb.mouse from abatement PR.

checked on 3 data sets and it looks like the bug was fixed


Signature of Using complicates usage and involves unnecessary coupling

https://github.com/Reactive-Extensions/Rx.NET/blob/d50374813e99489eba181d1eeed2084c5da077a9/Rx.NET/Source/System.Reactive.Linq/Reactive/Linq/Observable/Using.cs
I contribute to RxJava where the signature for the Using operator was copied from ReactiveExtensions. I suggested an improvement to the signature for Using that was accepted and it struck me that I should contribute the improvement back to the source being ReactiveExtensions.
Discussion is at  https://github.com/ReactiveX/RxJava/issues/1466

I think you may have closed the wrong issue with this commit.
On 14 Apr 2015 04:11, "bartdesmet"<EMAIL_ADDRESS>wrote:

Closed #77 https://github.com/Reactive-Extensions/Rx.NET/issues/77 via
ee2e3dc
https://github.com/Reactive-Extensions/Rx.NET/commit/ee2e3dc3d362bbd56b39c20a3a754c737b00353f
.
—
Reply to this email directly or view it on GitHub
https://github.com/Reactive-Extensions/Rx.NET/issues/77#event-280025600.

The design in Rx.NET is based on the fact that subscriptions are represented using IDisposable which is also used by the using keyword in languages like C#, which is where the Using operator borrows its name from. As such, one doesn't have to do anything special to implement IDisposable for existing resources such as I/O streams etc.
This differs from RxJava where the resource has to implement the Subscription interface, hence the blind porting of .NET's Using operator makes it look strange and introduces coupling. The closest would have been to make subscriptions use Closeable in Java, and have an operator called TryWithResources in lieu of Using, further constraining the resource to deriving from AutoCloseable.


Release GitHub action workflow only works if there is no branch protection.

Look for a better way. Personal token scope is too wide to feel safe using that.

Should be resolved with https://github.com/neverendingqs/serverless-dotenv-plugin/pull/162


running the experiments described in the HAWQ-v3 paper

Hello,
I would like to reproduce the results described in the HAWQ-v3 paper for the QAT scenario, specifically those describing the results of running the ResNet50 model on the CIFAR10 dataset.
I have tried to use the command line in the README file (under the "Quantization-Aware Training" seciton), but it resulted in very inferior results compared to the ones documented in the paper.
I was hoping you could guide me as to how I can reproduce those results (for example for the uniform 8bit quantization).
Thank you!

Same here. I want to know how to run the results on the CIFAR10 dataset.

Same here. I want to know how to run the results on the CIFAR10 dataset.


finish changing the path for varlink

cleanup the last references to /run/io.projectatomic... and make sure
/run/podman/projectatomic... is used.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

bot, retest this please

merging manually ... CI flakes and dont want to wait to build new packages for release


Geyser Config passthrough

Currently, only a very few config options can be changed on the imbedded Geyser. Is it reasonably possible to implement a system where the imbedded Geyser loads defaults unless a config option is specified? What I mean is, for example, if you leave "enable-extended-worldheight" out of the config, it'll default to false, but, if you place it in the config with "true," it'll pass that through and override the default.
I personally would like the extended-worldheight and above-nether-building passed through for an experimental server.

No longer an issue as the rewrite moves it to a Geyser extension


Register implementation - without form validation

Wrong commit - the right commit is with #120 (by mistake)


Block hash calculation

Add block hash calculation:
BLOCK HASH
A block hash is a hash of the block’s header elements.
Specifically:
pedersen_hash(
parent_block_hash,block_number,
new_global_root,sequencer,
creation_time, transaction_commitment, transaction_count
event_commitment, event_count, protocol_version,
extra_data
)
In StarkNet Alpha, each component that is not yet implemented is replaced with 0.
The code for the block hash generation can be found here.

Done in https://github.com/NethermindEth/juno/pull/467


single vs double colon pseudo elements

I recently found out, that stylelint requires a single colon pseudo-elements (:before, :after, etc.), but it's recommended to use double colon (::before, ::after, etc.). Since we don't have to support IE8, we should use double colon pseudo-elements, to better distinguish from pseudo-clasess.

"It's recommened to use double colon" – could you link the recommendation?

I can't find an article where they really recommend it, but it was created to differentiate the pseudo classes from elements, and since we don't have to support IE8, which is the only browser not supporting ::pseudo-element syntax, we probably shouldn't force the older syntax by stylelint. And maybe leave it for the developer to decide.


translate.use not working

this.translate.use(this.languageInUse.language).subscribe(() => {
console.info(Successfully initialized language.', this.languageInUse.language);
}, err => {
console.error(Problem with  language initialization.');
});
i got console success message but pages are not translated. and there is no http calls hapening at network tab.
///////// app.module.ts
export function createTranslateLoader(http: HttpClient) {
return new TranslateHttpLoader(http, './assets/i18n/', '.json');
}
///////////
always taking default language set at app.component.ts
any help???

Sorry - I can't reproduce this.
The code looks good (except for the wrong quote marks) - but it's hard to tell without seeing more of your project.
Here's a simple working demo project: https://github.com/CodeAndWeb/ngx-translate-demo


Support Casset::get_filepath_*(array('jquery-1.7.1.js', 'jquery-1.7.1.min.js')

Currently Casset::get_filepath_js accepts only a string which represents the relative filepath to the current asset path. This makes all environments to include either minified or non-minified.
It would be a useful addition to be able to call:
Casset::get_filepath_js(array('jquery-1.7.1.js', 'jquery-1.7.1.min.js')

where Casset will decide depending on environment which script path to return.
This is also applies to all get_filepath_* methods.

An alternative to this would be to give a new argument to render_*, which would make it return the path to the relevant file, rather than the whole <script>/<link> tag.
This would offer the same power as your proposal, but would allow Casset to minify the relevant file if the user didn't have a pre-minified copy available.
What do you think?

Take a look at the feature/gen_tags_option branch, see if it does what you want.

I had a read throught the README.
Thank you!

Cool, it's been merged into develop.


Landing page: Fix typo

Subject of the issue
On the landing page, it states Gain exposure to a variety of asset.   This should be assets (plural).

Deliverables

Fix the typo on the landing page

Bounty
60 $OP

can i work on this one?


[Bug] Coverage Report is Empty

Describe the bug
Coverage report does not seem to be working in Storybook 7 with Vite. The test runner will go through and test the stories as expected, but no information is displayed in the coverage table or underlying coverage json file. I tried this on both a brand new Vite project as well as an existing Vite project I was upgrading to Storybook 7 and experienced the same issue.
To Reproduce
Steps to reproduce the behavior:

npm create vite@latest {PROJECT_NAME} -- --template react
cd {PROJECT_NAME} && npm install
npx storybook@latest init
npm install -D @storybook/test-runner @storybook/addon-coverage
Add "@storybook/addon-coverage" to the .storybook/main.js addons array
run the command npm run storybook
in a new terminal run npx test-storybook --coverage
the stories will be tested, but the output of the coverage will be an empty table.

Expected behavior
The coverage table would show the tested components from the stories as well as the number of covered lines. The coverage/storybook/coverage-storybook.json should also be populated with information.
Screenshots

System
Environment Info:
System:
OS: macOS 13.4
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Binaries:
Node: 16.19.1 - ~/.nvm/versions/node/v16.19.1/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.19.3 - ~/.nvm/versions/node/v16.19.1/bin/npm
Browsers:
Safari: 16.5
npmPackages:
@storybook/addon-coverage: ^0.0.8 => 0.0.8
@storybook/addon-essentials: ^7.0.20 => 7.0.20
@storybook/addon-interactions: ^7.0.20 => 7.0.20
@storybook/addon-links: ^7.0.20 => 7.0.20
@storybook/blocks: ^7.0.20 => 7.0.20
@storybook/react: ^7.0.20 => 7.0.20
@storybook/react-vite: ^7.0.20 => 7.0.20
@storybook/test-runner: ^0.10.0 => 0.10.0
@storybook/testing-library: ^0.0.14-next.2 => 0.0.14-next.2

First of all, I am very grateful to have Storybook as OOS and have been using it happily for a couple of years now.
@jeffcap1 I really wish I could help as I myself just spent more than a couple of hours to get to the bottom of this.
I used Storybook CLI to update to the latest (from v7.0.5 to v7.0.23).
I got the same problem with the test-storybook not honoring the --coverage option anymore.
In my case running pnpm dlx storybook@latest upgrade also bumped @storybook/test-runner from v0.10.0 to v0.11.0.  Going back to v0.10.0 fixed the problem for me.

I just tried the same approach as @cezudas by running npx storybook@latest upgrade on the brand new vite project to get to version 7.0.24. I then ran npx test-storybook --coverage with @storybook/test-runner at 0.11.0 and rolling then back to 0.10.0. Unfortunately, neither seemed to produce a working coverage report. What I did notice is on 0.10.0 I get an empty table output to the terminal, however, 0.11.0 I do not see a table. In both scenarios the coverage report json is empty.


Alignment off when using bootstrap input-group

With the following markup the alignment of the completer-dropdown is off. Doesn't seem to be able to take into account the height of the field:

            <ng2-completer [inputClass]="'form-control'"
                [(ngModel)]="customerCode"
                [datasource]="customerAutoCompleteDataService"
                [minSearchLength]="2"
                (selected)="onCustomerSelected($event)"
                (blur)="lookupCustomer(customerCode)"
                [ngModelOptions]="{standalone: true}">
            </ng2-completer>

                <button class="btn btn-default" type="button" (click)="showChildModal()">…</button>

This is using bootstrap 3.3.7

Add this class to your page (not in Angular component or template):
.completer-input { 	width: 100% !important; }


Adding missing docu for OAuth/OpenID Authentication in Keptn Bridge

Disclaimer: I am not an expert on OAuth, however, there might be some inconsistencies in the docs.
In one example the endpoint is defined as token while in the other example it is defined as token_decision:

Also, the payload does not match:

@jetzlstorfer thanks for the feedback. I have fixed the inconsistency.


jlrincontrol.start_vehicle question

Hey
Happy new year! Sorry, i know this is really for bugs, but i wasnt sure where else to ask. I am using the below to remote start my car
name: Start Engine
tap_action:
action: call-service
service: jlrincontrol.start_vehicle
data:
entity_id: sensor.my_new_car_info
pin:
target_value: 43
I wanted to know what that "Target Value" is based on? I think when the car starts its preconditioning to 21.5 degrees C. I want to increase this, but was not sure what value to enter in the target value (assuming that is the temp value?
Any help appreciated?
Thanks

target_value is the temperature to set (15.5 - 28.5C or 58 - 84F based on local HA units).
start_vehicle service is documented here: https://github.com/msp1974/homeassistant-jlrincontrol/blob/master/custom_components/jlrincontrol/services.yaml#L44 and the same documentation is visible in HA (see screenshot below).

Thanks but i am a little confused because mine is set to 43, but the temp comes on at 21.5c?

The api and old versions of the integration use a number range of 31-57 for the temp.  In C this is double the temp, in F this is temp - 27.
As this was confusing, later versions of the api allowed this value to be a temperature and we convert it.
As such, change yours to start using actual temp C.

Noted, just tested this set at 23 and it worked. Thank you.


ksync create should not create new specs if 'ksync watch' is not running.

$ ksync get
       NAME        LOCAL    REMOTE     STATUS                              POD                             CONTAINER
+----------------+-------+----------+----------+---------------------------------------------------------+-----------+
  leading-martin       .   /src/app   waiting
  wired-jaybird        .   /src/app
                                      watching   my-app-ksync-a20b41c7-683a-4336-a1e9-78a112ff2eb0-q9gzx

$ pkill -f ksync

$ ksync create -n ashahba --selector=job-name=my-app-ksync-a20b41c7-683a-4336-a1e9-78a112ff2eb0 $(pwd) /src/app1

$ ksync get
FATA[0000] Having problems querying status. Are you running watch?

and now my ksync.yaml has this spec near the end:
- name: holy-cub
  containername: ""
  pod: ""
  selector: job-name=my-app-ksync-a20b41c7-683a-4336-a1e9-78a112ff2eb0
  namespace: ashahba
  localpath: <SOME_PATH>
  remotepath: /src/app1
  reload: true
  localreadonly: false
  remotereadonly: false

And the only way for users to verify if the ksync create was successful or not is to run the ksync watch and then find out.

At first glance this might be intended behavior as it doesn't require an active cluster connection to add specs.


[google_sign_in][web] work perfect on debug mode, but get MissingPluginException(No implementation found for method init on channel plugins.flutter.io/google_sign_in) in release mode

What package does this bug report belong to?
google_sign_in
What target platforms are you seeing this bug on?

Yes
Dependency versions
pubspec.lock
https://pastebin.com/hhsz6ruh

Steps to reproduce
work perfect on debug mode
but build in release mode and publish to web get error:
MissingPluginException(No implementation found for method init on channel plugins.flutter.io/google_sign_in)
Expected results
build in release mode work perfect like debug mode
Actual results
get error:
MissingPluginException(No implementation found for method init on channel plugins.flutter.io/google_sig
Code sample
Code sample

Screenshots or Videos

Screenshots / Video demonstration

Logs
Logs
https://pastebin.com/ntymGC1X

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.22631.4169], locale zh-HK)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.6)
[√] Android Studio (version 2023.2)
[√] VS Code (version 1.94.0)
[√] Connected device (3 available)
[√] Network resources

Hi @Kinwailo, I checked this on my end but couldn't reproduce the issue as reported (tried both canvaskit and HTML renderers). I'm on the latest Flutter stable 3.24.3 and deployed web with Firebase hosting. Please try upgrading Flutter to see if the issue persists or not.
Can you share the deployed site here? And please provide the error trace in text format instead of screenshot for better readability and investigation.


Use publicPath for importScripts

importScripts will make a request to the file path passed in. In cases where a publicPath is being used, the filename alone is insufficient, so the request fails.
e.g., if you just do sw.[hash].js and you have a publicPath of /js/ then the file is served at /js/sw.[hash].js but the generated sw.js file will only have importScripts('sw.[hash].js')

Good catch @Aweary thanks!

@goldhand my pleasure! Any chance you could cut a release with this change soon? We've got some pending work over at https://github.com/electrode-io/electrode-archetype-react-app/pull/46 that depends on this 👍

Sure, I'll test and let you know when its published


bumblebee: add xf86inputmouse to x11 modules

Description of changes
Without this the X11 server would fail to start with the error:
(EE) Failed to load module "mouse" (module does not exist, 0)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi, thanks for your PR :)
Can you please change the commit message and PR title to something that matches the commit conventions?
I don't have an Nvidia GPU, so I can't review the technical part of the PR, I hope someone (@abbradar?) comes along.

@puzzlewolf  anything else I could do to help this move forward?

Pinging @abbradar, you're the maintainer of the bumblebee package, it would be great if you could review this PR :)
If they don't turn up, @abmantis, you can find some other people (not too many :D) who recently worked on this or other bumblebee related packages (made a PR or reviewed or so) and kindly ask them for a review here. Also, you can post in PRs ready for review _.

Hey @Mic92 , do you have a chance to try this?
I saw your change in the hardware repo and was hopping you could test this out.

Hey @Mic92 , do you have a chance to try this? I saw your change in the hardware repo and was hopping you could test this out.

The only thing, I can test here, is if it evaluates. I don't have a dual-gpu setup with Nvidia. Only some big enterprise Nvidia GPU.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3644

I have tested this, and it works. :+1:

@abbradar  any chance to try this?

I just tested this by rebasing your commit onto my current nixos-version --revision (42f4c8c5f480f520dce56d13fa2d19e10946dbff).
I am using bumblebee and intel-virtual-output to use external monitors on a Thinkpad P52 with a Quadro P1000 GPU.
For me, this already works fine without your fix. I have no complains. (As long as I don't do anything weird, like trying to sleep or hibernate...)
Although, I can see the same error message in the log, every time I do something with the nvidia card: intel-virtual-output, or optirun glxgears.
But that has never bothered me.
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (EE) Failed to load module "mouse" (module does not exist, 0)
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) NVIDIA: No DRM device: Direct render devices found but none could be
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) NVIDIA:     used.
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) NVIDIA(0): Option "NoLogo" is not used
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) Warning, couldn't open module mouse
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (EE) Failed to load module "mouse" (module does not exist, 0)
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) Warning, couldn't open module libinput
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (EE) Failed to load module "libinput" (module does not exist, 0)
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (WW) Warning, couldn't open module libinput
Jun 15 17:56:15 A014 bumblebeed[1212]: [XORG] (EE) Failed to load module "libinput" (module does not exist, 0)

Now, with your change, the mentioned EE) Failed to load module "mouse"  is indeed gone:
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (WW) Open ACPI failed (/var/run/acpid.socket) (No such file or directory)
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (WW) NVIDIA: No DRM device: Direct render devices found but none could be
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (WW) NVIDIA:     used.
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (WW) NVIDIA(0): Option "NoLogo" is not used
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (WW) Warning, couldn't open module libinput
Jun 15 18:03:22 A014 bumblebeed[1201]: [XORG] (EE) Failed to load module "libinput" (module does not exist, 0)

BUT now the mouse cursor on external monitors is lagging/jumping around. Only when moving. Hardly noticeable when moving slowly. But very noticeably when moving fast.
This sounds very much like multiple actors are calculating the mouse position differently.
And indeed, if I revert my non-standard mouse acceleration settings from flat to the default adaptive profile, the lag is gone:
#xinput set-prop 12 "libinput Accel Profile Enabled" 0 1 0 # flat
xinput set-prop 12 "libinput Accel Profile Enabled" 1 0 0 # adaptive

But I like the flat profile and don't yet know how to enable it in bumblebees xserver.
So, it appears, that in my case it was positive, that the mouse module did not load.
Now, I wonder if the mouse lag is also related to the other error in my logs:
(EE) Failed to load module "libinput" (module does not exist, 0)
Would the mouse lag be fixed if the libinput module would load?
Or, in my case, maybe I should try to stop x11 from even trying to load both the mouse and libinput modules? They do not appear to be necessary at all.

As NixOS 23.11 reaches end-of-life today, this PR is closed as part of the EOL cleanup.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/overriding-options-or-more/50606/9


Updates emitter.LaunchProcesses to use new Default process feild

Makes the output more like a formatted table

Resolves #243
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Didn't get a chance to comment on this PR, but do we think the log line we output now is unclear?
Like, is (default) part of the command? Or, what if the command is really long?
some-type: some-command
web:            some-other-command (default)

some-type: some-command
web:            some-other-command with lots of arguments that goes on for such a long thing that its hard to notice that this is the default command unless you are really looking for it (default)

Would it make it easier to read if the output looked something like this?
some-type:     some-command
web (default): some-other-command

@ryanmoran I am more than happy to make that change! I think that make a good amount of sense I just did not know how to add it. It will complicate the table formatting a bit but I think I can work that out


motion fails with motion version 4.0.1+git6a97d1a

VERSION/TAGS
0.35.2
0.35.1
0.35
OS
all version tested on (2) machine:
OpenMediaVault <IP_ADDRESS> / docker version 17.03.1-ce
Ubuntu 16.04 / docker version 17.04.0-ce
SYMPTOM
-motioneye cannot load network camera images
-motioneye reports error after restore backup (camera images never appear)
DETAILS
Looks like motion crashes with 6a97d1a or fails in error (4.0.1+git6a97d1a)
I was able to export working motioneye container that used motion 8a1b9a9 (4.0.1+git8a1b9a9), all was OK
This error seems to recently started in last 30days.  I previously moved to new machine without error.
Recreating image+container on same machine now result in errors.
not sure if it is related to https://github.com/Motion-Project/motion/pull/379
also, would it be possible to utilize specific motion build to prevent error

Good point. I shouldn't be building against master in case there are bugs in master. Can you verify it works against tag release-4.0.1

Motion 4.01 works but one of the commits has broken my end.
I last built working Motioneye 0.35.2 around 20170403 and can only verify motion 4.0.1+git8a1b9a9 working with all Motioneye 0.35.x
I'm only able to verify different motion builds by comparing working/nonworking container.

Hi, I got the same problem. I added "git checkout release-4.0.1" in installMotion.sh just after "cd motion" and rebuild the image. All works again after that.

Fixed via d0f4fe60f92c1ffc5afd12b3ade175d067a69065. Please try out the newest build published 6 days ago.


net: DialContext returns "dial tcp : context deadline exceeded" error

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.9.3 linux/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build672889649=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

What did you expect to see?

What did you see instead?
A reverse proxy logged a quick burst of "dial tcp <addr>: context deadline exceeded" errors. The errors originated from the DialContext method a *net.Dialer with a Timeout value set.

My guess is that the context.DeadlineExceeded message is in the error string because mapErr isn't being called here. But I haven't been able to reproduce the error message locally.

Closing as dup of #22724.


RND-397 - Unsynchronized modification of a Service field in a method.

This feature is on hold, since we'd like to check how broad problem is and how many cases it reveals. Moreover, it covers only one synchronization method.


Configs cannot be set on raw attributes

I trying ->
std := logrus.New() std.Out = &out std.Level = level  std.Formatter = formatter
none of the configs seems to be set on the logger, there is no error as well, provide methods to set them on logger as provided in exported one which uses locks.

FYI, I just experimented with this, still i am not able to set it properly.

My bad, I was importing global logger all along in other packages, which was already set to default configs, I should have opened this issue after proper debugging! sorry.


message length unrecognized when start with '0'

when candump out as below, (message length is '08')
can0  29A  [08]  2B 2A 8F 00 00 40 00 00
below command shows nothing.
candump can0 | cantools decode AA.dbc
after fixing dump message as below, and when I test using cat command, decoded signals shown well. (message length is modified as '8')
can0  29A  [8]  2B 2A 8F 00 00 40 00 00

maybe below modification would work,
-RE_CANDUMP = re.compile(r'^.*  ([0-9A-F]+)   [\d+]\s*([0-9A-F ])$')
+RE_CANDUMP = re.compile(r'^.\s+([0-9A-F]+)\s+[[0-9]+]\s*([0-9A-F ]*)$')

The problem is not the 0, right, but white spaces? Can you show the exact candump output for the failing case?

right, the fixed white space length seems problem.
this is a CAN-FD message dump.
can0  29A  [08]  F0 43 5D 00 00 40 00 00
can0  29A  [08]  23 04 5E 00 00 40 00 00
can0  29A  [08]  2B 2A 5F 00 00 40 00 00
can0  29A  [08]  85 8B 60 00 00 40 00 00
can0  29A  [08]  9B 14 61 00 00 40 00 00
can0  29A  [08]  48 53 62 00 00 40 00 00
can0  29A  [08]  3D 9B 63 00 00 40 00 00
can0  29A  [08]  EE DC 64 00 00 40 00 00
can0  29A  [08]  F6 1B 65 00 00 40 00 00
can0  29A  [08]  2B 2A 66 00 00 40 00 00
can0  29A  [08]  50 94 67 00 00 40 00 00
can0  29A  [08]  83 D3 68 00 00 40 00 00
can0  29A  [08]  41 0A 69 00 00 40 00 00
can0  29A  [08]  92 4D 6A 00 00 40 00 00
can0  29A  [08]  E7 85 6B 00 00 40 00 00

That dump does not have the correct number of white spaces. The output from candump does not have one white space everywhere, right?
Press the "Insert code" button when posting code, to preserve white spaces.
Something like this:   can0  29A  [08]  92 4D 6A 00 00 40 00 00

I tried to build using modified decode.py file. but not succeeded, (maybe) because test codes are not modified. How can I get a fixed version?

I can fix it later today, but first, please see my previous comment. I need the exact candump output to implement a test case.

the dump message are from candump.
can0  29A  [08]  1F 9D C5 00 00 40 00 00
can0  29A  [08]  CC DA C6 00 00 40 00 00
can0  29A  [08]  B9 12 C7 00 00 40 00 00

Ohh that's true, the inlice code does not show all whitespaces. I edited your comment to show them.

A fix is part of release 33.2.0, available on PyPI.

Thanks !!
but I'm still in trouble. How can I build new version?
just download the .zip & make is not working on my raspberry pi...

Try installing it with pip.


Change the name of navbar to header

Header represents its purpose better

Changed navbar.html, navbar.css, id=navbar and class=navbar-container to header


Modifying the list table for Page Crud

Hi Guys,
I have created a new crud page and everything works as expected so far. Thanks for your great CMS. But I have an small issue with list tables. There is a language column in this page listing page which I dont need as I dont use any translations. And I want to add published date column to this table. Can you guide me how do I modify the columns of this table. Thanks.

@pramithagayan You can adjust the columns in your module controller via the indexColumns array. See https://twill.io/docs/#controllers for an example.

@pramithagayan You can adjust the columns in your module controller via the indexColumns array. See https://twill.io/docs/#controllers for an example.

Yeah I found it after I posted this here. But still im not sure how to remove language column from the table. I can add new new columns though

Does your model happen to have the hasTranslation trait? The method which builds the indexColumns in the default ModuleController adds the languages column if the model has that trait.
        if ($this->moduleHas('translations')) {             array_push($tableColumns, [                 'name' => 'languages',                 'label' => 'Languages',                 'visible' => $visibleColumns ? in_array('languages', $visibleColumns) : true,                 'optional' => true,                 'sortable' => false,             ]);         }

Does your model happen to have the hasTranslation trait? The method which builds the indexColumns in the default ModuleController adds the languages column if the model has that trait.
        if ($this->moduleHas('translations')) {
            array_push($tableColumns, [
                'name' => 'languages',
                'label' => 'Languages',
                'visible' => $visibleColumns ? in_array('languages', $visibleColumns) : true,
                'optional' => true,
                'sortable' => false,
            ]);
        }

Yes it has a hasTranslation trait. But I actually dont need that. Problem is when I remove the hasTranslation trait and try to create a new post it shows validation fails error message. Do you know why? if I could able to create page module without translation trait my problem will be solved. :)

@pramithagayan It sounds like when you created your module, you accidentally added the translation flag. Remove the trait from your model and make sure the $translatedAttributes are commented out, and also remove the trait from the module repository. You may also want to remove the translations from your migration as well if you aren't using it. Hope this helps.

This should be resolved automatically thanks to #532. As a user, you can also hide columns so that they do not display on subsequent visits to the listing page.


JSCS Website

For a long time we carried the idea of generating JSCS documentation website using JSDoc from JSCS rules. The first attempt was made by @just-boris here: #327.
I tried to continue developing the idea:

To have documentation generated from rule files.
To have a website about JSCS.
To have all that generated automatically.

The generated example can be found here: http://jscs-dev.github.io/node-jscs/
Later I wish we move here: jscs.info.
@mikesherov, @markelog, @mrjoelkemp check it out, please.

Looks awesome! Small thing but the JSCS icon links to https://jscs-dev.github.io/ which is a 404 now.

Looks awesome! Small thing but the JSCS icon links to https://jscs-dev.github.io/ which is a 404 now.

@mdevils Great work!
Do you think about regrouping rules according to @markelog's work (https://gist.github.com/markelog/752e53faf9f27de4024d)?
It should helps a lot for those who want manually fix their code style presets.

@mdevils Great work!
Do you think about regrouping rules according to @markelog's work (https://gist.github.com/markelog/752e53faf9f27de4024d)?
It should helps a lot for those who want manually fix their code style presets.

Do you think about regrouping rules according to @markelog's work (https://gist.github.com/markelog/752e53faf9f27de4024d)?

I would leave this for later work.

Do you think about regrouping rules according to @markelog's work (https://gist.github.com/markelog/752e53faf9f27de4024d)?

I would leave this for later work.

Looks awesome! Small thing but the JSCS icon links to https://jscs-dev.github.io/ which is a 404 now.

Thanks, will check this out!

Looks awesome! Small thing but the JSCS icon links to https://jscs-dev.github.io/ which is a 404 now.

Thanks, will check this out!

This looks great. Great work!
We need to make sure we update Contributing.md with the following:

Replace all instances of Readme.md with the appropriate link to the website
In the section "Proposing additional presets," users should modify OVERVIEW.md now, not README.md.

For the list of companies/projects that use JSCS, we can add:

Adobe (http://www.adobe.com/)
Grunt (http://gruntjs.com/)

This looks great. Great work!
We need to make sure we update Contributing.md with the following:

Replace all instances of Readme.md with the appropriate link to the website
In the section "Proposing additional presets," users should modify OVERVIEW.md now, not README.md.

For the list of companies/projects that use JSCS, we can add:

Adobe (http://www.adobe.com/)
Grunt (http://gruntjs.com/)

Definetely probably don't need that many - but you can also add:

Ionic (http://ionicframework.com/)
Moment.js (http://momentjs.com/)
Ember (http://www.emberjs.com/)
TodoMVC (http://todomvc.com/)
Famous (http://famo.us/)
RxJS (http://reactive-extensions.github.com/RxJS/)

Definetely probably don't need that many - but you can also add:

Ionic (http://ionicframework.com/)
Moment.js (http://momentjs.com/)
Ember (http://www.emberjs.com/)
TodoMVC (http://todomvc.com/)
Famous (http://famo.us/)
RxJS (http://reactive-extensions.github.com/RxJS/)

Thank you, guys!!

@mrjoelkemp, @hzoo, added all the companies/products. Tell me if you have more.
@mrjoelkemp, fixed README.md references.

Thank you, guys!!

@mrjoelkemp, @hzoo, added all the companies/products. Tell me if you have more.
@mrjoelkemp, fixed README.md references.

Fixed style issues, tried and published website to http://jscs.info/

Coverage remained the same when pulling fa99836c3c9bd27c5fb7b3673be741acd10af229 on mdevils.website into 7125f4a20a4ae22edd6ce587b284a9d7d5a697b6 on master.

Looks great.

:+1: :clap:

Coverage remained the same when pulling ac9a1b79145e744661792047b30fa16c61f344b4 on mdevils.website into 7125f4a20a4ae22edd6ce587b284a9d7d5a697b6 on master.

I am ready to merge this. How do you think?

Hello, glad to see it!

Why are you are parse rules through Regexp instead of JSDoc? It may cause some issues in future when rules will become more complicated.
You still have a very long page with whole rules list. What about short rules index for faster navigation?

But I like general direction, and I guess it can be made later

@just-boris,

Why are you are parse rules through Regexp instead of JSDoc? It may cause some issues in future when rules will become more complicated.

I believe this can be fixed later if we get issues.

You still have a very long page with whole rules list. What about short rules index for faster navigation?

I would postpone this too. First I want this to be merged to avoid complicated rebases later.

Personally I don't like the idea to store website in the main repo. But code is lgtm. Great work!

@zxqfox it is the easiest way to keep docs and code in sync

@just-boris yeah. But it should be built and published just after releasing new version so anyway it's a script that can fetch main website repo, push there autogenerated content, and publish to gh-pages or something. But without website repo you'll see a mix of website and code fixes. It's a critical difference for me ;-)

@zxqfox I see you point, but it will be really difficult to keep them in sync otherwise.

First I want this to be merged to avoid complicated rebases later.

Yes. I don't see any blockers from merging. We can patch after.

Merged. Thank you a lot, guys!

Coverage remained the same when pulling 4c31d9ee8039d87aa6db346b5efe7d5679551d21 on mdevils.website into 7125f4a20a4ae22edd6ce587b284a9d7d5a697b6 on master.

More projects
Flight: https://flightjs.github.io/
RxJS: https://reactive-extensions.github.io/RxJS/
h5bp: http://html5boilerplate.com/
Ghost: https://ghost.org/

Also FineUploader: https://github.com/FineUploader/fine-uploader
and you can fix this quickly @mdevils https://github.com/jscs-dev/node-jscs/issues/872

Great work @mdevils and @justboris !
On Friday, January 2, 2015, Joel Kemp<EMAIL_ADDRESS>wrote:

Also FineUploader: https://github.com/FineUploader/fine-uploader
and you can fix this quickly @mdevils https://github.com/mdevils #872
https://github.com/jscs-dev/node-jscs/issues/872
--
Reply to this email directly or view it on GitHub
https://github.com/jscs-dev/node-jscs/pull/873#issuecomment-68569761.

--
Mike Sherov

Oh, man, this was merged pretty fast.

I'd say it's definitely should be in separate repo, with it's own issues and commits, otherwise it would clutter everything
Readme.md of the node-jscs should be clean now, and consist only with very basic info about the project
Twitter feed, if we need one, should also show "#jscs" tweets
All those "who uses" references should be verified, (although i don't feel the need to publish them in the main page or publish it at all :-), i think we need a links for each of them to be sure people are actually use it.
"who uses" reference should be more focused, now everything is in the pile without evident structure
Rules should be dived and clusterized with their own pages and description for them should be taken from JSDoc as it was in @just-boris pull
jscs.io also could be used, as redirect
"Extensions", "Friendly packages", "CLI options", "options", "presets" should be moved to their own pages

I would put N1 as a priority, so everything else could be moved to the issues.

btw, great job!

I agree on separate repo, but glad to see we finally have something!

Nice job, I really like the website. I have just two remarks:
What do you think about having a textarea like http://jshint.com or http://jslint.com to paste code and check it online? I would like it. (I not sure if jscs is currently working in the browser.)
And to nitpick a little bit: the logo and the favicon aren't looking too good on retina displays. The logo can easily be created with SVG and for favicons I really like the http://realfavicongenerator.net/ . I'll create a pull request for this later.

I think that would be cool! There is browserify setup already so that could work?

It works. We already use it in http://zz85.github.io/mrdoobapproves/.

@markelog moved repo to https://github.com/jscs-dev/jscs-dev.github.io

Twitter feed, if we need one, should also show "#jscs" tweets

I believe we need it, it indicates that the project is alive and in active development. About #jscs, try that hashtag, there is a lot of garbage, so it is useless.

"who uses" reference should be more focused, now everything is in the pile without evident structure

I would like to have logos of the key projects on the page. That is way more friendly.

Rules should be dived and clusterized with their own pages and description for them should be taken from JSDoc as it was in @just-boris pull

Should be because...?

Made an attempt on JSCS online demo: http://jscs.info/demo.html

@mdevils One more great thing we have now. Thanks! Did you think about using plugins on this page? ;-)

@zxqfox Which plugins? Fell free to send PRs)


⚠ Bofrost.at has degraded performance

In c4a46dc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1343 ms

Resolved: Bofrost.at performance has improved in 10bbf9b after 20 minutes.


Better test coverage

I would love to have better sharness test coverage across different commands here.
@chriscool do you think you could help out with that when you have time? It would be very much appreciated.

@whyrusleeping ok I will take a look at that soon.
Are there some specific commands you are thinking about?


.github: add MLH config for flake tracking

Signed-off-by: André Martins<EMAIL_ADDRESS>

I'm looking at https://github.com/cilium/github-actions/commit/b915560bf29700d894a3b58a5b6b0ca6c23db6ff before reviewing this -- anything of interest you recommend I checkout? I'm personally interested in the correlation thingy :D

I'm looking at cilium/github-actions@b915560 before reviewing this -- anything of interest you recommend I check out? I'm personally interested in the correlation thingy :D

in cilium/github-actions? Not particularly. In this PR, if you could double check if the job names are correct and if you think the correlation between PR jobs and stable jobs sounds good. The explanation of the configuration file is in https://github.com/cilium/github-actions#configuration


make sure we get an image before trying to create injector pod

zarf init --components=k3s --confirm goes so quick that it tries to inject the zarf registry before k3s is able to actually populate a cluster. This ensure we wait until a pod exists within the k3s cluster that way we can actually fetch an image to use as part of our injection pod.

Great catch--I was actually thinking if it's the k3s installed version though we should just use the old injection, this adds needless complexity for that model and we fully control it.  I don't mind dropping cli-based injection for others though.

thanks I fixed it a little differently in the main PR.


Not a Jenkins Pull Request - skipping danger run

Report
Trying to use Jenkins to get danger to write comments to our PR's but am getting an error. Just a note, we're not using the Jenkins Pull Request plugin to manage our PR's but instead have a script to do that for us. Would this be causing the issue?
If that is the issue, is there a way to have the bot write to the PR by running the danger command locally? Thank you!
What did you do?
bundle exec danger
What did you expect to happen?
Expected danger to run against the Dangerfile and write comments to the PR accordingly
What happened instead?
Got the following error:
Not a Jenkins Pull Request - skipping 'danger' run
Your Environment
Using Jenkins for CI, running the latest version of Jenkins
if github.pr_body.length < 5
  fail "Please provide a summary in the Pull Request description"
end

You'll need to set up the env vars manually, you can find them in the Jenkins code: https://github.com/danger/danger/blob/master/lib/danger/ci_source/jenkins.rb


fix: fixes cuda_setup issue

The is_cublasLt_compatible function in cuda_setup/main.py has an uninitialized variable.

Probably related: https://github.com/TimDettmers/bitsandbytes/pull/115

I merged #115 instead because it was the first PR. Thanks for your contribution!


Autocomplete link markdown format

Is it possible to to configure autocompletion to insert markdown link format [Foo Bar](foo-bar.md) instead of wiki format [[foo-bar]]?

Hi @avucic! Thanks for raising this. Could you give a more specific example for the behavior you want: document + input to autocomplete? The way things are now:

If you type [[ this will bring wiki-style autocomplete.
If you type []( or [Foo bar]( this will bring markdown-style autocomplete. You need to input the square brackets [] because markdown inline links have the structure [title](url).

I'm assuming you want to streamline p.2 but I'm not sure what exactly you have in mind?

Hi @artempyanykh. Right now I'm using zk-nvim which has implemented LSP sever (I beleive zk tool has that under the hood). I like feature that when you type [[ node anme]] AC will return link like this: [h1 header from the file](path to the file.md). Actually you can configure that in .zk/config.toml link-format = "[{{title}}](/{{rel-path}})". Currently I have to enter the link title manually. Not big deal, of course, but it would be nice if Marksman can do that for me ;) Btw. awesome work!!

Indeed, a configuration option such as the one @avucic mentioned would also solve my use case really nicely :+1:


Rename element directory, update element files

Rename element directory to camel case.
Update element files to match the structure and element directory name.

Fixes the #3


fix: package.json main field

https://github.com/verdaccio/verdaccio/pull/3689 introduced what seems to be typo and not intented change.
Result of it is that require('verdaccio') now imports<EMAIL_ADDRESS>instead of CJS file and it started to cause failures for us:
/usr/local/share/.config/yarn/global/node_modules/verdaccio/index.js:1
export { default as startVerdaccio } from './build/index';
^^^^^^

SyntaxError: Unexpected token 'export'
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1049:15)
    at Module._compile (node:internal/modules/cjs/loader:1084:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
    at Module.load (node:internal/modules/cjs/loader:998:32)
    at Module._load (node:internal/modules/cjs/loader:839:12)
    at Module.require (node:internal/modules/cjs/loader:1022:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/usr/local/share/.config/yarn/global/node_modules/gatsby-dev-cli/dist/local-npm-registry/index.js:3:24)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)

Node.js v18.6.0

cc @juanpicado

Thank you for quick turnaround on this. Can confirm that new patch release (5.23.1) fixed things for us.


sensor integration test helper refactor

Description
Refactor the helper functions used in the sensor-integration-test

Enables the helper functions to create resources based on structs.
Adds the testRun struct to hold all the information regarding a test run.
Adds a RetryCallback that will be called (if set) when the creation of a resource fails.

Note to the reviewers: Consider reviewing the PR commit by commit.
Checklist

[ ] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed

CI
make sensor-integration-test

/retest


Consistency between first_name, last_name and display_name

We need consistency between first_name, last_name and display_name because we are getting first_name and last_name from the endpoints, but we are using display_name for the filtering

@AitorAlgorta that's a good point. Which one would you prefer? display_name or the split version

@AitorAlgorta that's a good point. Which one would you prefer? display_name or the split version

for the current context, display_name is good enough

for the current context, display_name is good enough


estimate scale ratio at begin

check if test_decorate_model.py create infinite loop

tests/test_benchmark_plots.py .                                                                                [ 19%]
tests/test_cli.py

test_msel_oracle.py

tests/test_model_diva.py::test_model_diva PASSED                         [ 78%]
tests/test_msel_oracle.py::test_msel_oracle PASSED                       [ 79%]
tests/test_msel_oracle.py::test_msel_oracle1 PASSED                      [ 80%]
tests/test_msel_oracle.py::test_msel_oracle2 PASSED                      [ 81%]
tests/test_msel_oracle.py::test_msel_oracle3 PASSED

Codecov Report
Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.22%. Comparing base (1520907) to head (34975da).

Files
Patch %
Lines

domainlab/algos/trainers/a_trainer.py
96.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   95.17%   95.22%   +0.04%
==========================================
  Files         130      130
  Lines        5164     5189      +25
==========================================
+ Hits         4915     4941      +26
+ Misses        249      248       -1

Flag
Coverage Δ

unittests
95.22% <97.05%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Revert to allowing authorizationUrl & tokenUrl to not match networkDomain

Without this, our current Google packs would break, and probably quite a few 3rd party ones.

No issue with the revert, but this would just block new uploads, correct?
Why not just allow the existing builds but require the correct authentication structure for any new builds?

@alan-codaio I'm tempted... that's why I kept the code. But since it will be an annoying surprise to lots of pack makers, I just didn't want to take on that hassle right now. Just trying to move faster.


Reinstate properties on errors

When reinstating errors, additional properties on those errors were not correctly preserved. Now they are.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mitchell Harris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM :+1:


JSDM

Depends on my other two PRs

This works, but I still can't get it to run in parallel on Hipergator. Running serially now. Ready for code review/discussion/tips on what I might be doing wrong.

do you have any errors from the hipergator?

It just sits there indefinitely without producing output when I run the code as-is, but it does save my results to the mistnet_output folder when I run it with lapply instead of mclapply

On Mar 6, 2017, at 10:56 AM, Shawn<EMAIL_ADDRESS>wrote:
do you have any errors from the hipergator?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/weecology/bbs-forecasting/pull/94#issuecomment-284438394, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzdCVCP3EGejSNSn4Et9mvXaxGDMaA1ks5rjCyQgaJpZM4LuALy.

does mistnet parallize at all? I'm running fit_mistnet() right now without mcapply and it's cpu usage is 200%, which usually means it's maxing out 2 cores.

That's really weird.  None of the code I wrote for mistnet is in parallel, although I suppose it's always possible that I'm calling some other parallel code? Maybe the armadillo library?
Thanks for looking into this...

On Mar 6, 2017, at 12:22 PM, Shawn<EMAIL_ADDRESS>wrote:
does mistnet parallize at all? I'm running fit_mistnet() right now without mcapply and it's cpu usage is 200%, which usually means it's maxing out 2 cores.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/weecology/bbs-forecasting/pull/94#issuecomment-284467301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzdCXE6rnsTA3KwfO6e_Lgwirs3TuJ_ks5rjEDwgaJpZM4LuALy.

On my Mac, I'm only using 100%. When you run it, does it create two process each running around 100%, or does it just have one process going at 200%?

On Mar 6, 2017, at 1:03 PM, Dave Harris<EMAIL_ADDRESS>wrote:
That's really weird.  None of the code I wrote for mistnet is in parallel, although I suppose it's always possible that I'm calling some other parallel code? Maybe the armadillo library?
Thanks for looking into this...

On Mar 6, 2017, at 12:22 PM, Shawn<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
does mistnet parallize at all? I'm running fit_mistnet() right now without mcapply and it's cpu usage is 200%, which usually means it's maxing out 2 cores.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/weecology/bbs-forecasting/pull/94#issuecomment-284467301, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzdCXE6rnsTA3KwfO6e_Lgwirs3TuJ_ks5rjEDwgaJpZM4LuALy.

On serenity, which is ubuntu, it has one process going at 100%, but on hipergator when I use a dev session it will go to 200%

😡😡😡
Dave

On Mar 6, 2017, at 1:13 PM, Shawn<EMAIL_ADDRESS>wrote:
On serenity, which is ubuntu, it has one process going at 100%, but on hipergator when I use a dev session it will go to 200%
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

using a doParrallel::foreach() implementation  on hipergator seems to be working, I'll let you know if it actually finishes on a small subset.
library(doParallel)
cl=makeCluster(4)
registerDoParallel(cl)

output = foreach(i=1:8) %dopar% {
    source("mistnet.R")
    fit_mistnet(iter = i, use_obs_model = TRUE)
    }

Thanks Shawn!

On Mar 6, 2017, at 1:25 PM, Shawn<EMAIL_ADDRESS>wrote:
using a doParrallel::foreach() implementation on hipergator seems to be working, I'll let you know if it actually finishes on a small subset.
library(doParallel)
cl=makeCluster(4)
registerDoParallel(cl)
output = foreach(i=1:8) %dopar% {
source("mistnet.R")
fit_mistnet(iter = i, use_obs_model = TRUE)
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/weecology/bbs-forecasting/pull/94#issuecomment-284485366, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzdCdtDZmYQ7F1wQrHr86CIxlJ3-n-Gks5rjE-TgaJpZM4LuALy.

Confirmed, using foreach() as above works.

Looks like @sdtaylor's idea didn't solve the problem: instead of fitting 1 model per hour, I'm now fitting 16 models every 16 hours.
I'm going to cancel everything and just type sbatch mistnet.job into the terminal sixteen times 🛠

how long does each model normally take to run?

One hour on one thread. So I should be getting sixteen per hour, not sixteen every sixteen hours.
Dave

On Mar 16, 2017, at 9:55 AM, Shawn<EMAIL_ADDRESS>wrote:
how long does each model normally take to run?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

So is dopar working as expected with mistnet now? What did you change?

This should finally be ready for review.  Sorry for the giant mess of 50+ commits...

Great, no worries. With the GitHub Squash and Merge option that's easy to fix.
I don't have time for a detailed read through before I leave, but I did give it a quick once over and didn't see any obvious issues. @sdtaylor why don't you take a look and when you're happy go ahead and merge.

I don't know enough about the mistnet API to say this looks right, but I didn't see anything that looked problematic, so in it goes.


Add Animation Motions to Home Page

Title: Added Animation Motions to Home Page
Issue No.: #139
Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
[X] I have gone through the contributing.md file before contributing.

Additional context (Mandatory):
Are you contributing under any Open-source programme?

[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor

Hyy @Laxmi01345 please add some screenshot or clips so that it is easy to understand the issue #139


could not fetch image

What's the issue?
Hey-o i love this mod but whenever i go in and out of my world the images disappear and get replaced with text that says could not fetch image. the images are still on my pc and have not been moved or anything so idk what causes this
Screenshots

Mod and Minecraft version
Camerapture-1.3.0+mc1.20.1

also sometimes when using the camera i dont receive the image

This might be an issue I'm aware of! Are you using the Essential mod?

yeah i am!

In that case, if it's what I think it is, I released version 1.3.1 that should fix this!

thank you so much this worked!


Extend the XSHG calendar further into the future

The calendar for XSHG ends in 2025, which is not that far in the future any more. Is there some code somewhere to compute the holidays on the Shanghai stock exchange? As far as I can see they are all hard-coded in https://github.com/gerrymanoim/exchange_calendars/blob/master/exchange_calendars/exchange_calendar_xshg.py
I could of course try to find all the holidays for any later dates, but it probably would be a bit easier if someone has some more "local" knowledge.

Hi @hannes101, yup they are hard-coded.
I suspect the holiday rules are sufficiently complex that it was decided it would be simpler to just hard code them each year.
PR's welcome to extend the holidays (Workflow to modify an existing Exchange Calendar)
Thanks


Please use MIT or a commercially available open source license.

Please use MIT or a commercially available open source license.

negotiating

refer to all the headers: https://github.com/NVlabs/Sana/blob/82ebd2706879b9725d2af903601a64c0e38bfed5/app/app_sana.py#L8

The license of Sana's code base is changed to Apacha 2.0


New version: Google.AndroidStudio version 2<IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-01-25T03:05:20.8663489Z ##[error] Manifest Error: Invalid field value. [InstallerType]

(Automated response - build 655.)

Hi @jahvari,
This manifest removes Apps and Features entries that are present in previous PR versions. Should these entries also be added to this version?
(Automated response - build 655.)

@stephengillie I added it back