MvcSiteMapProvider not working at all

i have successfully installed MvcSiteMapProviderMVC4 from nuget, but when i add below two lines in my layout page breadcrumbs does not display. only menu display without links.
@Html.MvcSiteMap().Menu()
@Html.MvcSiteMap().SiteMapPath()
my project is mixing of web forms and mvc 4.0. Dot Net Framework is 4.0.
i am not understanding what i am doing worng. i have tried many times but same issue occurs. but interesting thing is that in new project this work fine.
In my project menu shows without links and breadcrumbs does not display.

MvcSiteMapProvider consumes MVC routing and also requires a node configuration to define how controller actions are to be nested. Most of the examples show this in XML, but you can define nodes many different ways.
I suggest you go through the article How to Make MvcSiteMapProvider Remember a User's Position to understand exactly how to get it matching.
Since it works in a new project but not in an existing project, most likely you either have misconfigured routes or you haven't accounted for all of the route values that are in your existing application. If you can post your entire routing configuration (including areas) and how your nodes are configured, and a sample of how you want the breadcrumb to look in certain cases I might be able to tell you where to start.

thanks for your reply, hope it would help me but one thing i want to tell you that new projects where this is working fine has same routes defined.

here is my nodes and output.
1. Mvc.sitemap file

2. Routes
routes.MapRoute(
name: "Admin",
url: "{section}/{controller}/{action}/{id}",
defaults: new { action = "index", id = UrlParameter.Optional },
constraints: new RouteValueDictionary { { "section", "admin" } }
);
3. Output screen

Now you can see that only menus are displaying without any link. breadcrumbs are not appearing at all. please tell me what should i do to display breadcrumbs.
thank you in anticipation.

The issue is that you haven't accounted for the {section} parameter in your SiteMap. If {section} has nothing to do with the selection of the page, you can force a match on any value using preservedRouteParameters.
<mvcSiteMapNode title="Product List" controller="Product" action="List" preservedRouteParameters="section">

As pointed out in the article How to Make MvcSiteMapProvider Remember a User's Position, you need to manually account for all route values in order to make it match.


Rendering errors when modifying fox.obj

Hi, I'm working on a modified version of this logo as part of this GitCoin issue. I'm having issues getting the fox to render correctly after changing some polygon colors in 3DS Max. 3DS Max and Windows' built-in 3D object viewer seem to both render the fox correctly, though.
Here's the result when using this library:

Steps to reproduce:

Open fox.max in 3DS Max.
Change the material of some of the polygons.
Export fox.max to fox.obj and fox.mtl using default settings.
Execute npm run convert and npm run start to view broken image on web.

I briefly took a look at the code and noticed that the polygons are correctly generated here, but are then being hidden either when the determinant is negative or because the z-index is zero. I'll mess with this a little more and see if I can figure out the exact cause of the issue.

@smartcontracts Did you figure out a fix for this issue in the end?

I did not :-/ are you running into the same issue?


Undocumented visitorId? (YouTube v3 api)

So this seems like the canonical place to ask:
What is a visitorId? I can't find any documention from the discovery service, api explorer, or reference.
Also, I don't see a visitorId when I make a youtube.channels.list request.

Sorry, this repo is just Go code automatically generated from discovery docs. So we don't know either.

Okay. This is under the Google organization. Who would?

At the bottom of https://developers.google.com/youtube, there are links for the issue tracker and StackOverflow. I'd try those.

Thanks. Right, even the discovery team  wouldn't know about all the apis...


bug: Failed loading lazyvim.config.keymaps

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.0-dev-152+g1887d8d7d
Operating system/version
Pop!_OS 22.04 LTS x86_64
Describe the bug
Whenever I start lazyvim I get an error that lazyvim.config.kepmap couldn't be loaded. It doesn't appear to be affecting my own config, but the notification is certainly 1. troublesome to a new user and 2. an annoyance. I am not well-versed in even getting the output but here's a screenshot of the error:

Steps To Reproduce

Install lazyvim v1.24.0
Start lazyvim

Expected Behavior
I would not expect there to be an error loading an included configuration
Repro
No response

If this is a new install you might want to delete .config.nvim, .local/share/nvim and .local/state/nvim and clone the starter repo again, as there is a chance there might have been an incomplete clone of the repo. That is assuming you didn't make any customizations to lazyvim.config.keymaps yourself.

The reason you're getting that error is because you're using an older nightly build.
Either install a recent nightly, or install a stable version of Neovim

Thank you!


chore: Switch to new react-router syntax

This is step #2 of upgrading to React Router v6. https://reactrouter.com/en/main/upgrading/v5#upgrade-to-react-router-v51
As reference, I looked at
https://reacttraining.com/blog/react-router-v5-1 and https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f

Current dependencies on/for this PR:

main

PR #638   👈

This comment was auto-generated by Graphite.

Note that I deviated from https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f#get-started-upgrading-today in the PrivateRoute refactor, because https://reactrouter.com/en/main/upgrading/v5#upgrade-to-react-router-v51 says to remove , which that suggested. I think that will work okay but I don't have a good way to test this -- how can you manually go to a route in Electron? If you have a way to test the redirect works okay, and the from passes through properly, that would be good to double-check. Low-risk, though, this should be rarely (if ever) hit.

All you need to do is just to drop in a Link component to a certain route and you can see it in action. Tested locally and it seemed to work!


feat: Change the admin theme to Claro and remove thunder

Change the admin theme to Claro and remove thunder
This PR does the following:

Removed support for the Thunder Admin theme
Installs the Claro admin theme

Notes:

Claro is a new core theme with a rigorously tested design system: https://www.drupal.org/docs/8/core/themes/claro-theme/design.
Accessibility is a driving focus of Claro.
The color palette is fairly neutral.
Support and bug fixes will be bundled with core updates.

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


LHN to Yagan K8s

Foreman Reservation & tests
VLAN interface with ip rule for Yagan & tests
add rke module for rp_filter to yagan

I think this PR should be marked as a draft until the changes are tested on ruka and a PR for those changes is merged.


[Bug]: Incorrect behavior of ignored properties in an embbeded object

What happened?
Ignored properties in Embbeded Objects seem not to reflect changes after they are updated.
Repro steps
For example:
@RealmModel()
class $Example {
  @MapTo('_id')
  @PrimaryKey()
  late ObjectId id;

  @Ignored()
  String test1 = "";

  late $ExampleEmbeddedProperty? exampleEmbeddedProperty;
 }

@RealmModel(ObjectType.embeddedObject)
class $ExampleEmbeddedProperty {

  @Ignored()
  String test2 = "";
}

example.test1 = "test1";
print(example.test1); // prints "test1"

example.exampleEmbeddedProperty!.test2 = "test2";
print(example.exampleEmbeddedProperty!.test2 ); // only prints "" => INCORRECT

Version
^0.8.0+rc
What Realm SDK flavor are you using?
MongoDB Atlas (i.e. Sync, auth, functions)
What type of application is this?
Flutter Application
Client OS and version
MacOS 12.6
Code snippets
No response
Stacktrace of the exception/crash you're getting
No response
Relevant log output
No response

@Taco55 I'm afraid this is expected. Whenever you access a managed realm object (embedded or not) via a link from another realm object, you get a new instance. You should not store state in ignored properties and expect to be able to read them back out like this.
Ignored properties are mostly for caching values that can be inferred from the persisted ones.

@nielsenko Thanks for your answer. I used ignored properties to store temporary data for filtering purposes. Since I use a lot of embedded properties it seemed a logical place to store the related data here as well. I have solved it now by using separate state management.
However, I don't see any use case for non-data-intensive computing since computed properties should work well. May be the documentation can be optimized to clarify proper use of ignored properties?
The issue can be closed.

@mongodben Maybe something we can improve in the docs?


Add locking when accessing metrics map from user space

Currently we are iterating the metrics map in user space using updatePrometheusMetrics
If the map is being dumped without the Dump and DumpWithCallback functions, we should RLock the map which is done in pkg/bpf/map/DumpWithCallback to ensure that it is not modified from userspace while accessing it. Currently since we are only reading from user space, this is not an issue, but that might change in future.
See https://github.com/cilium/cilium/pull/4225 for reference

Might as well just switch to using one of the regular Dump functions instead.


[Service] util to parse app-info

Use common function to parse app-info and update ml-information handle.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #371. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


fix(1289): change name to "test wallet"

Context

fixes #1289

Changes

😅  I played at developer Radu, can you please make the rest of the changes?


Translation agent updates and add Maps agent

Updates translation agent and added initial code for maps agent

@googlebot I fixed it.

@googlebot I fixed it.


Dropping dropdownSelector configuration option (Breaking change)

In an effort to make the code simpler and reduce dependencies & tight coupling, I'm considering dropping support for the dropdownSelector configuration option.
This option only works with jQuery and Bootstrap Javascript, and the developer can implement on their own method for closing a dropdown in the on-set-time callback.
$scope.onTimeSet = function (newDate, oldDate) {
    // do something with new/old date as needed

   // close the dropdown with jQuery
  $('#dropdown1').dropdown('toggle');
}

Please comment on this issue if there are any reasons why this won't work for you.

So are you changing the way the dropdown is opened?

No, there won't be any changes to the way opening works. That's why I am thinking of removing it, it is the only configuration option that is not directly related to selecting a date or time. It violates the single responsibility principle.

Hi , I tried the datetimepicker today and in the console I started getting this warning "Empty string passed to getElementById()."
although there is no sign of error in the functioning and everything is working fine. I was just curious if someone can look into this matter. I tried to fix on my own but no success.
Thanks

Hi, when I am concat the all JS into a single  app.js and try to run the app getting same issue even application functionality is running correct.
So is there any kind mistake by me or other things which i need to resolve

@deeppatidar, as far as I know there is no problem with minifiying this directive. It is likely a dependency injection with your code -
From https://docs.angularjs.org/guide/di

$inject Property Annotation
To allow the minifiers to rename the function parameters and still be able to inject the right services, the function needs to be annotated with the $inject property. The $inject property is an array of service names to inject.
var MyController = function($scope, greeter) {
// ...
}
MyController.$inject = ['$scope', 'greeter'];
someModule.controller('MyController', MyController);
In this scenario the ordering of the values in the $inject array must match the ordering of the parameters in MyController.
Just like with the array annotation, you'll need to take care to keep the $inject in sync with the parameters in the function declaration.

The dropdownSelector configuration option is being removed because it will not function properly.
How we can resolved this type of issue ?

It currently works fine, but only with jQuery and Bootstrap Javascript included on the page. This feature has been a pain in terms of support questions and people requesting support for other frameworks (i.e. angular-bootstrap) I don't see it adding much value.
So far, no one has objected to its removal.

I was about to ask for an example of how to inject it via the template options...

Hey guys, this might help some of you out there.
The example below uses ui.bootstrap to orchestrate the dropdown sequences, and works a little better with the bootstrap's active components (and with the angularJS injection pipeline)
http://plnkr.co/edit/kH9AEtvUzFhStdGJQaIM

you have to include bootstrap.js to remove this error

@dalelotts you could add this to the documentation. I think it's easier if your library does not handle the dropdown itselft.

I think most of people use the selector in the dropdown way.
What is your proposal to do that without the current dropdownSelector ?.

@martinib77 it can be handled in the on-set-time callback

This will not be removed from 1.x, however it will not be included in 2.x


Add this to https://github.com/vuejs/awesome-vue

I think I'm pretty satisfied with the way this library works at the moment and I think it would be best if it got exposure to more people.

I also recommend submitting this to hacker news

It is not finished yet actually. I'm working to do this layout reactive fully and I need a bit of time to make some promises inside to achieve async calls in one task without calling so many events. It will be easier then for make it compatible with Vuex and different tools.
Thanks for advices :)

Great work! I'll close this for now.


Add SINA to Karmada Adopters

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

Thanks @xudongyang95 for your support, that means a lot to the community!
Could you please help to sign the commit to make CI happy:), you can do that according to the guideline:
https://github.com/karmada-io/website/pull/398/checks?check_run_id=14553414524
or, just run following commands:
# git checkout main
# git rebase HEAD~1 --signoff
# git push --force-with-lease origin main

/lgtm
Thank you very much for choosing Karmada!

Thank you very much for choosing Karmada!


Mark existing content as NOT obsolete when made public

Why
Need a way to send patch request to update lessons in Degreed.
What
Added a PATCH req handler and update method in the Degreed client
Testing

[ ] Make a curl request with

curl -X POST "https://betatest.degreed.com/oauth/token"
  -H 'Content-Type: application/x-www-form-urlencoded'
  -d 'grant_type=client_credentials&client_id=<id>&client_secret=<secret>&scope=content:read,content:write'

The client_id and client_secret can be found in 1password under "Degreed Credentials"

[ ] copy the returned access_token

[ ] In the degreed project directory run bin/console

[ ] set the correct URL for the beta test endpoint before testing a request by running Degreed.configuration.base_url = "https://api.betatest.degreed.com/api/v2"

[ ] res = Degreed::Client.new(token: "copied access token goes here").courses.all # to our ALL courses enpoint
expect response 200 OK

[ ] res.body["data"].first["attributes"]["obsolete"] # to confirm the oboslete state
expect true or false

[ ] res = Degreed::Client.new(token: "copied access token goes here").courses.update(id: "rwrEWz9", obsolete: true) # There is only one lesson currently so the I have included the id. Then set the obsolete value to true or false depending on it's current state
expect response 200 OK

[ ] res.body["data"].first["attributes"]["obsolete"] # to confirm the oboslete state
expect true or false depending on value sent

Boom!💥
We should have a working update request!

@rreinhardt9 Thank you for all the help. The testing notes have been included. Please let me know if you think anything needs to be made clearer.


istioctl register/unregister cmd failed

Downloaded the daily build (04/25's).   The istioctl uses the default location for the .pem file but mine isn't in the default location.
$ ls $(dirname $KUBECONFIG)
ca-wdc06-linistio3.pem          kube-config-wdc06-linistio3.yml
~/go/src/github.com/linsun/examples/guestbook-go on  master! ⌚ 11:38:29
$ echo $KUBECONFIG
/Users/linsun/.bluemix/plugins/container-service/clusters/linistio3/kube-config-wdc06-linistio3.yml
$ kubectl get pods
NAME                 READY     STATUS    RESTARTS   AGE
redis-master-pxdm2   1/1       Running   0          43d
redis-slave-fntrc    1/1       Running   0          43d
redis-slave-kmb72    1/1       Running   0          43d
~/go/src/github.com/linsun/examples/guestbook-go on  master! ⌚ 11:24:47
$ istioctl kube-inject -f guestbook-deployment.yaml --debug
Error: invalid configuration: unable to read certificate-authority ca-wdc06-linistio3.pem for linistio3 due to open ca-wdc06-linistio3.pem: no such file or directory

cc @esnible @liamawhite

marking as blocking release as this is a common scenario where the pem and yml are in a dir but perhaps not in a default dir.  it only works if I modify the yml to use the absolute path of the pem file.

I have verified that this ONLY affects kube-inject.  The .pem file is handled correctly for istioctl get routerules.  I verified using strace.

This is still an issue because register and deregister still fail with the same error for the same reason.  To reproduce:
istioctl register foo <IP_ADDRESS> 80

The problem is that a call to clientcmd.LoadFromFile() is eating the pathname of the certificate file.  The get and other working commands use clientcmd.BuildConfigFromFlags() which does not have this problem.  I will take a look at https://github.com/istio/istio/pull/5300 and see if the same code will fix register and deregister.

good point, register still fails..

@ayj While working on this I noticed debugging output coming from these CLI commands.  As far as I can tell the CLI is the only thing that calls pilot/pkg/serviceregistry/kube/register.go  and deregister.go.  Would it be reasonable to change the output in those methods to fmt.Printf() and log.Debugf() from the current log.Infof()?  Would it be reasonable to do that on the PR for this fix?

cc @ldemailly for register.go and deregister.go specific changes.
Debug output should be off by default. Level info should be sufficient to use the command under normal circumstances.

logging from command line with more details isn’t unheard of, I would leave log.Info()

Not 0.8 release blocking per discussion with @louiscryan

Agreed, i should have removed it after the kube-inject cmd works now.

So we are dropping support for 0.2 mesh expension feature because ... ?

I'd like to say this is a blocker for 0.8, as many customer are now trying service mesh expansion now, any workaround solutions for this?
root@gyliu-icp-6:~/cases# istioctl -n bookinfo register details <IP_ADDRESS> http:9080
2018-05-11T10:33:53.150072Z	info	Registering for service 'details' ip '<IP_ADDRESS>', ports list [{9080 http}]
2018-05-11T10:33:53.150122Z	info	0 labels ([]) and 1 annotations ([alpha.istio.io/kubernetes-serviceaccounts=default])
Error: invalid configuration: unable to read certificate-authority mycluster1/ca.pem for mycluster1 due to open mycluster1/ca.pem: no such file or directory

/cc @linsun @ldemailly

I had a PR that fixed this problem.  It was about 4 lines of fixes and about 4 lines of changing log levels.  I deleted the PR because it was not clear if the commands should be removed or fixed.  I am happy to take over the Issue but I have never used these commands and I need wisdom/guidance to know if the goal is to make these commands work, to remove them, or to improve them.

@esnible @linsun I think that we need at least keep this works in 0.8 release and can improve for next release, so @esnible , can you please continue your PR to fix this for 0.8?

@esnible, i think your PR will make the cmd work, at least work like it used to with the old route rule.

@esnible as I commented in your then PR (and here indirectly) there is no reason for the command to cease working (and also no reason to change the logging from Info to another level, it is "informative" about what it is doing, if a user doesn't want the output they can raise the level to warning)


Feature Request: Add jaeger receiver value

So far, for traces, oltp and zipkin receivers are referenced in the helm values. Is it worth adding a value that creates a otelcol.receiver.jaeger component?

I tried enabling one today so definitely worth adding it I think! I see Pete's already begun which is great, I'll keep an eye on this and try it out once done.
There may be a way to do this differently, but I'm trying to configure GEM deployed to the same cluster to send its traces via the k8s-monitoring managed agent. It looks as if GEM/Mimir only support Jaeger at the moment so makes sense we have it as a receiver in this chart.


@expressify puts shinylive into a strange state

In the dev version of Shinylive, @expressify puts it in a strange state where it doesn't seem to recognize changes to the function body.
For example, with this app, if you change the body of the card function and restart the app, the card doesn't change.
Live example
from shiny.express import expressify, render, ui

@expressify
def card(i: int):
    with ui.card():
        with ui.span():
            "This is card "
            ui.span(str(i), style="color: red;")

card(1)
card(2)

https://github.com/posit-dev/py-shiny/assets/86978/98a3d1eb-9c72-41ea-aa8a-50cc2a10a80e
Although the problem is happening in Shinylive, I think that's probably just a symptom of a deeper issue that's in the implementation of expressify.

I also found that if you load the app, then change the function name to card1  (along with the function calls), then press the play button, it will do this:
>>> Traceback (most recent call last):
  File "<exec>", line 379, in _start_app
  File "<exec>", line 357, in __init__
  File "/lib/python3.10/site-packages/shiny/express/_run.py", line 42, in wrap_express_app
    app_ui = run_express(file).tagify()
  File "/lib/python3.10/site-packages/shiny/express/_run.py", line 93, in run_express
    exec(
  File "/home/pyodide/app_vjx2c2sazx2j5o8fraqf/app.py", line 5, in <module>
    def card1(i: int):
  File "/lib/python3.10/site-packages/shiny/express/expressify_decorator/_expressify.py", line 128, in expressify
    return decorator(fn)
  File "/lib/python3.10/site-packages/shiny/express/expressify_decorator/_expressify.py", line 103, in decorator
    fcode = _transform_body(cast(types.FunctionType, fn))
  File "/lib/python3.10/site-packages/shiny/express/expressify_decorator/_expressify.py", line 169, in _transform_body
    raise RuntimeError(
RuntimeError: Failed to find function 'card1' in AST. This should never happen, please file an issue!

Appears @render.express has the same issue

There's also a linecache.checkcache(filename=None); by default, it checks all of the files it's cached and flushes entries for files that have changed. Or you can have it check a specific file.

I think we can use linecache.checkcache() on any file just before doing special evaluation of it?

I think you’ll have the same problem without special evaluation, if the app.py loads another .py that uses those decorators? Maybe linecache.checkcache() (with no args) when the run button is pushed?

checkcache() and clearcache() seem to partially work. In the video here, it doesn't work if I change the body of a function, but seems to work if I change the name of a function. I'll have to poke at this some more.
https://github.com/posit-dev/py-shiny/assets/86978/e6a74af6-38da-4318-8b76-3550a86f0271

It doesn’t explain what you’re seeing, I don’t think, but we do also have our own cache here: https://github.com/posit-dev/py-shiny/blob/main/shiny/express/expressify_decorator/_expressify.py#L33

Yes, it looks like the code_cache is the source of the problem. This might be a bug with this specific version of Pyodide. (I'm not sure if linecache is also causing problems.)
This is where it checks if the bytecode object fn.__code__ is in the cache. What I'm seeing is that, after the first time the app has been run, the test if fn.__code__ in code_cache evaluates to True in some cases even when the code is different.
https://github.com/posit-dev/py-shiny/blob/64d80363f2e29dae1bf2fff28c2956dc050635b2/shiny/express/expressify_decorator/_expressify.py#L99-L100
Here's a minimal reprex.
import contextlib

def card():
    with contextlib.nullcontext():
        "This is text"

print(card)
print(card.__code__.__hash__())

def card():
    with contextlib.nullcontext():
        "This is other text"

print(card)
print(card.__code__.__hash__())

If I run this in my normal Python in a terminal, I get the following output:
<function card at 0x102799ee0>
5123763730382191169
<function card at 0x10279a020>
-5359592953186025408

This is what I would expect. However, if I run it in Pyodide (via Shinylive), this is what it looks like:
<function card at 0x17361d0>
1335897378
<function card at 0x17a5338>
1335897378

In Pyodide, both of the __code__ objects have the same hash, even though their contents are slightly different. (Other changes, like changing the name of the function, or removing the with statement, do result in a different hash.)
Shinylive using Pyodide 0.22.1. I also tested that code in their web console at https://pyodide.org/en/0.22.1/console.html and was able to reproduce the problem there as well.
However, when I tried a newer version, like https://pyodide.org/en/0.23.0/console.html, the hashes are different. So it might have been fixed in that version.


GetMessageSummariesAsync in v2.5.6 takes a long time

GetMessageSummariesAsync method is slow in v2.5.6.

https://github.com/danzuep/MailKitSimplified/issues/32#issuecomment-1723135408

Thanks @faisalbwn for spotting this one. I've deployed a new version so let me know how it goes.

I've removed the slow result filtering from Range().GetMessageSummariesAsync() which fixes the issue. This means that Query().GetMessageSummariesAsync() now returns results in ascending order to match MailKit, so anyone relying on that will now need to use the Linq.Reverse() method to get results in descending order again.

Thanks Daniel,
The fix is working fine for me.


CC0 license is likely inappropriate

Hi,
I've noticed the repository has a LICENSE file indicating the repo content is CC0. Aside from its conflict with PRC copyright law (attribution rights cannot be waived in PRC so CC0 is effectively CC-BY here), I don't consider it likely for Loongson to permissively license LATX either, so something must be clarified or fixed here IMO.
PS: IMO a better way to open-source developments while securing commercial profits is the Qt way: strongly copyleft the work but allow for separate commercial licenses. This way both the broader open source community and Loongson can benefit from open collaboration, and revenue can be collected from commercial usages.
方才发现此仓库的 LICENSE 文件表明此仓库的内容是 CC0 许可的。CC0 在中国大陆无效（在中国大陆，著作权不可放弃，CC0 实质等效于 CC-BY）；除此之外，本人也并不认为龙芯意图宽松许可 LATX。对此可能需要一些解释或订正。
PS: 私以为 Qt 所采用的方式有助于在开源开发的同时保证商业利益：使用强烈的 copyleft 许可证保护作品，但允许单独获取商业授权。这样广大社区用户与龙芯都将享受到开放合作模式的便利，而龙芯也得以从商业使用中获取收入。

Meanwhile, if open-sourcing is not yet prioritized: the interim license should likely be the Loongnix EULA.
如果目前开源事项不在优先级上：可能应以《Loongnix 最终用户许可协议》为这一时期临时采用的许可证。

Hi,
Thanks for your suggestion, I've noticed this issue.
This repo is created to strengthen the connection of dev & open testing, and the intended outcome is some documents to help end users to utilize latx easily.

Hi, Thanks for your suggestion, I've noticed this issue. This repo is created to strengthen the connection of dev & open testing, and the intended outcome is some documents to help end users to utilize latx easily.

Hi, thanks for the clarification! In this case I think it's better to put it down explicitly: the CC0 license is only meant to cover the docs and communication happening in this repo (and its forks), but not the LATX itself.


errorJSONvalue when sending "PRESS"

See attached image, I'm sending the command and receiving this error.

Issue was sending json "PRESS" when it should've just been raw PRESS

@ogerrard glad u figured it out and thanks for closing the issue
double quotes are used to signify a string value so the raw value is a simple string and not a full json string. Good u got it going though. cheers


ffmpeg failed to execute command

I am getting this error on ubuntu, ffmpeg already installed. please can you help me?
Fatal error: Uncaught Alchemy\BinaryDriver\Exception\ExecutionFailureException: ffmpeg failed to execute command '/usr/local/bin/ffmpeg' '-y' '-i' 'resources/Danni no Transfer 2.wav' '-acodec' 'flac' '-b:a' '256k' '-ac' '1' 'audiob6abdd0.flac' in /var/www/html/geolocation/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/ProcessRunner.php:100 Stack trace: #0 /var/www/html/geolocation/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/ProcessRunner.php(72): Alchemy\BinaryDriver\ProcessRunner->doExecutionFailure(''/usr/local/bin...') #1 /var/www/html/geolocation/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/AbstractBinary.php(209): Alchemy\BinaryDriver\ProcessRunner->run(Object(Symfony\Component\Process\Process), Object(SplObjectStorage), false) #2 /var/www/html/geolocation/vendor/alchemy/binary-driver/src/Alchemy/BinaryDriver/AbstractBinary.php(137): Alchemy\BinaryDriver\AbstractBinary->run(Object(Symfony\Component\Process\Process), false, Array) #3 /var/www/html/geolocation/vendor/php-ffmpeg/php-ffmpeg/src/ in /var/www/html/geolocation/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Media/Audio.php on line 74

just copy this:
'/usr/local/bin/ffmpeg' '-y' '-i' 'resources/Danni no Transfer 2.wav' '-acodec' 'flac' '-b:a' '256k' '-ac' '1' 'audiob6abdd0.flac'
and paste it in ternmenal to see if that command works or not.

@Abu3safeer ffmpeg version N-90176-g27cbbbb Copyright (c) 2000-2018 the FFmpeg developers
built with gcc 5.4.1 (Ubuntu 5.4.1-2ubuntu1~16.04) 20160904
configuration:
libavutil      56.  7.101 / 56.  7.101
libavcodec     58. 13.100 / 58. 13.100
libavformat    58. 10.100 / 58. 10.100
libavdevice    58.  2.100 / 58.  2.100
libavfilter     7. 12.100 /  7. 12.100
libswscale      5.  0.101 /  5.  0.101
libswresample   3.  0.101 /  3.  0.101
Input #0, wav, from 'resources/Danni no Transfer 2.wav':
Duration: 00:01:05.79, bitrate: 13 kb/s
Stream #0:0: Audio: gsm_ms (1[0][0][0] / 0x0031), 8000 Hz, mono, s16, 13 kb/s
Stream mapping:
Stream #0:0 -> #0:0 (gsm_ms (native) -> flac (native))
Press [q] to stop, [?] for help
Output #0, flac, to 'audiob602df5.flac':
Metadata:
encoder         : Lavf58.10.100
Stream #0:0: Audio: flac, 8000 Hz, mono, s16, 256 kb/s
Metadata:
encoder         : Lavc58.13.100 flac
[gsm_ms @ 0x2e3b800] Packet is too small
Error while decoding stream #0:0: Invalid data found when processing input
I can't find solution for this

But it created the file audiob6abdd0.flac

the output file, does it work?

beside what is the version of ffmpeg you are currently using?

Yeah it's work, ffmpeg version N-90176

the version number is not really a number, looks like this is a special build.
the latest official build is (FFmpeg 3.4.2 "Cantor")
where did you get this ffmpeg from?

oh sorry i am wrong @Abu3safeer  this is my ffmpeg version 3.4.2-1

i try on macbook is running well, but on server getting trouble like above

Is the version on the macbook same as the version on the server?

thanks you for your response @Abu3safeer . I fixed that to set permission folder for save file to 777.

777 is danger, especially if you website is live, try to use more secure permissions.

yup, i try to chante 755 or 765 still error

Any solution?


Introduce telemetry macro for ring buffer helper

What does this PR do?
This PR introduces bpf_ringbuf_output_with_telemetry macro.
Motivation
Describe how to test/QA your changes
Covered by functional tests in KMT
Possible Drawbacks / Trade-offs
64 byte increase in each helper telemetry map entry
Additional Notes

/merge

/merge -c

/merge


Create bindings for RegExp

This adds bindings for most of RegExp
#275

Oh, I found that RegExp constructor seems to be throwing if the second argument has invalid flags. I couldn't find it documented in MDN though.
Should a catch attribute? (I tried but I get an error saying: first argument of method must be a bare type. I'm guessing it has something to do with that it is an constructor)

@brisad oh hm I think catch may not be supported on constructors yet? That may need a dedicated bug to support that. In the meantime though it's ok to not return a Result

@alexcrichton I've updated the PR after your review comments

Awesome, thanks!


Fix iterator hint shortening heuristic

Turns out I made a mistake with the heuristic check which is always true, so all iterators exposed from core were shortened, including things like ranges. 😅

bors r+

Well, one more reason why Range shouldn't have been an iterator :D


Teach JS-YAML about slaw/array

Allows read/write of of slaw/array in the same way as slaw/vector.
Resolves issue #17

LGTM. Thanks! Do you need a release published?

Yes, please!

Published as 0.1.14. https://www.npmjs.com/package/plasma-js-bridge


wrong encoding

This is the output on an arduino due with the sample sketch:
wiki:pedia = d2lraTpwZWRpYQA=
This is however wrong. It should be "d2lraTpwZWRpYQ==".
Both string side by side:
d2lraTpwZWRpYQA=
d2lraTpwZWRpYQ==

Please see https://github.com/adamvr/arduino-base64/issues/12#issuecomment-386869533 and pull request #23


The users don't get added when using simulator and default password params.

I think it is a timeout issue. A quick fix is to do 50000 instead of 100000 rounds.

We changed the encryption rounds


No x64 package included in nuget package

Referencing package dupimagelib from nuget will only download the 32-bit files.
But when running the app (in 64-bit mode), it says
Unable to load DLL 'Magick.NET-Q8-x64.Native.dll': The specified module could not be found.

I've updated the Magick.NET dependency to the newest Magick.NET-Q8-AnyCPU version in release 1.1.1 that should fix this. Please report if this solves this issue.


Pydantic version

Hi,
can you please update to Pydantic 2.x? In this way AiZynthFinder can be more easily installed in the same environment as REINVENT (still many complaints about incompatible packages but none of those seem to matter).
route_distances/validation.py then needs to change as follows
type: str = Field(pattern=r"^mol$")  #pydantic.constr(regex=r"^mol$")
# ...
type: str = Field(pattern=r"^reaction$")

Also, pytorch 1.x is a bit old.  From our experience it is no problem to update to the most recent version 2.x.
Many thanks,
Hannes.

Now the pydantic update is included in the latest pypi release, so considering this done.


I just need to know if VCRedists are needed...

Hi and greetings!
I was wondering about dependencies. Do my target systems need to have the VisualC++ 2012 Redist installed in order for them to use SQLitePCLRaw.core? My target systems are Windows Server 2008R2 and up to Windows Server 2016.
The reason behind me asking is if I read from the readme.md and I got a bit confused.
"On my build machine, I have Visual Studio 2012 and Visual Studio 2013 (update 2) and Visual Studio 2015 and Xamarin Android + iOS and
the relevant Android SDK(s)."
and further on:
"(1) We need something that can call the C code. For the Xamarin implementations this is DllImport (aka P/Invoke). For Windows Phone 8, this is a C++ wrapper. For the others, it is both. In either case, this presents an extremely low-level API. C pointers become System.IntPtr. Strings are not actually .NET strings, but rather, are in utf-8 encoding, represented in C# as either an IntPtr or a byte[]."
To my understanding there is no dependency on any of the VCRedists under Windows Server OS, but I'd like to confirm this :)
Thank you in advance!
/cheers

(FWIW, and to help with the confusion, neither of the snippets you quoted are related to the question of whether VCRedists are needed or not.)
I assume you are talking about using SQLitePCL.raw with its e_sqlite3 library.
No, you should not need to install VCRedists if your target is Windows Server.  Whenever possible, e_sqlite3 is built with the C runtime library statically linked in.  In one or two cases, this is not supported by the toolchain, but those cases do not involve Windows Server.

Yes you assumed correctly, I meant the SQLitePCL.raw bits 😀
Thank you very much for the clarification!
/cheers


In 12 health check

health check implemented for both grpc and http deliveries.
Units : postgres , kafka , writable-tmp-dir.

Good job!


iOS 10 Navigation bar is not set to transparent

I am writing code for app with future support so basically i'm looking at all side previous versions, current version, as well as future version which will be iOS 10.
This category works perfect until iOS 9.3.3 but in iOS 10 its not working, i've tested on both iDevice and Simulator
I'm setting clear colour for navigation bar at viewDidLoad as below
 [self.navigationController.navigationBar setShadowImage:[UIImage new]];     [self.navigationController.navigationBar lt_setBackgroundColor:[UIColor clearColor]];
Please someone help me out with this.
I'm sorry for my english, i don't know what language you're using 😜
Thanks.

I have the same question.
I find that the "_NavigationBarBackground" is under the overlay view at iOS 10, but the "_UIBarBackground" is above the overlay view at iOS 9.3.3.
When push to new ViewController , the overlay view is at the front of the navigationbar.
I just set the backgroundColor.

fixed in v2.1.3

thanks for the new version 👍


Volume and Iridescence GLTF/GLB from glTF-Sample-Models do not display or import/export correctly

Describe the bug
The glTF Sample Models for IridescentDishWithOlives and IridescenceLamp do not display or import/export correctly in Blender 3.4.1 latest.
In the Blender viewport in Material Preview mode the materials do not render correctly at all.
When the models are exported, they are missing their iridescence map, however this is known as  KHR_materials_iridescence isn't added to Blender yet via https://developer.blender.org/T99447
The real issue is that the materials do not look correct in the Blender viewport at all when imported into Blender, for a wysiwyg style look dev workflow it makes Blender unusable for material edits to these types of models in Blender when they render like this:

To Reproduce
Steps to reproduce the behavior:

Open Blender 3.4.1
Import one of the sample models linked above

Expected behavior
Volume and iridescence should import and export correctly with the models via glTF
Screenshots
Fresh imports of the glb versions of the files above:

Left is original and right is exported from Blender as-is with default GLTF export options for GLB viewed with https://github.khronos.org/glTF-Sample-Viewer-Release/

Repro Files:
Repro.zip
Version

OS: Windows 11
Blender Version 3.4.1

I noticed the specular imports as infinite, reducing it fixes the bleached white colours of the bowl

Then as per here I enabled Screen Space Reflection and Refraction in Eevee but I also had to enable Screen Space Refraction on the materials themselves which I assume the GLTF importer should enable if those are per-material settings?

Confirmed.
There is a division by 0 because of specular. I will fix it.
Currently, there is no change of global Eevee option when importing.
I don't think an importer should change global settings of Blender or Render Engine.

Thickness using the Thickness map don't have an effect on anything in Eevee, is this expected?

Thickness in glTF has no equivalent value in any Eevee or Cycles node. They are not using same model for rendering.
There is no 100% feature compatibility between Blender and glTF

Thickness using the Thickness map don't have an effect on anything in Eevee, is this expected?

Thickness in glTF has no equivalent value in any Eevee or Cycles node. They are not using same model for rendering. There is no 100% feature compatibility between Blender and glTF

Understood, I am adopting Blender with a team and we are trying to establish workflows with GLTF so that is an issue for cross-software workflows.

Any glTF value/texture without any corresponding Blender data are plugged to the "glTF Material Output".
So at export, these data/texture can be exported, even if not displayed in Blender.


add support for GF180MCU

It would be nice to have support for gf180mcuC, so that we can get some ideas of how many projects are "portable" and if they require any other configuration update beside setting a different PDK environment variable.

Any design using rams (include dfframs) will need updating.

@vvbandeira
GF180 MPW shuttle submission got over. Can you please create CI pipeline and give me instruction to push GF180 shuttle design as part of MPW CI?


gltfio: robustness improvements for Draco meshes.

These changes are motivated by #3815.
See also:
https://github.com/KhronosGroup/glTF-Blender-IO/issues/1326
https://github.com/KhronosGroup/glTF-Blender-IO/issues/1345

Mainly I would like to avoid logging in release builds. logging is a response to an error, and that should be decided by the caller -- not us.

This makes sense.  So...I have an idea (for the future):
If gltfio needs to be robust against certain types of badly formed data, maybe it can recover but still tell clients about it by using an "info log" string, similar to how OpenGL handles shader errors.  e.g. Instead of emitting to the log, ResourceLoader could provide a getInfoLog() query.

Mainly I would like to avoid logging in release builds. logging is a response to an error, and that should be decided by the caller -- not us.

This makes sense.  So...I have an idea (for the future):
If gltfio needs to be robust against certain types of badly formed data, maybe it can recover but still tell clients about it by using an "info log" string, similar to how OpenGL handles shader errors.  e.g. Instead of emitting to the log, ResourceLoader could provide a getInfoLog() query.

Yes, I think it makes sense for gltfio to adopt a defensive stance. Which is different from the philosophy in filament.
But the question is, do we make all the checks in debug and release? If we are truly robust against ill formed files only in debug, then why not log only in debug too?
I'm starting to think that for gltfio the robustness checks should be a compile option. Because if you know for a fact that your files are good, you shouldn't have to pay the price of the checks (performance and size). On the other hand, if you can't guarantee it because you don't control the files, you might want to use the "robust" version. In debug builds, the checks and logs could be always enabled. In release builds, it would be a compile time option for both the checks and the logs.
I don't know if it's feasible, but maybe we need a separate validation library. People who need the robustness, could use to first validate the files? This way gltfio itself can stay lean and mean.

Mainly I would like to avoid logging in release builds. logging is a response to an error, and that should be decided by the caller -- not us.

This makes sense.  So...I have an idea (for the future):
If gltfio needs to be robust against certain types of badly formed data, maybe it can recover but still tell clients about it by using an "info log" string, similar to how OpenGL handles shader errors.  e.g. Instead of emitting to the log, ResourceLoader could provide a getInfoLog() query.

Yes, I think it makes sense for gltfio to adopt a defensive stance. Which is different from the philosophy in filament.
But the question is, do we make all the checks in debug and release? If we are truly robust against ill formed files only in debug, then why not log only in debug too?
I'm starting to think that for gltfio the robustness checks should be a compile option. Because if you know for a fact that your files are good, you shouldn't have to pay the price of the checks (performance and size). On the other hand, if you can't guarantee it because you don't control the files, you might want to use the "robust" version. In debug builds, the checks and logs could be always enabled. In release builds, it would be a compile time option for both the checks and the logs.
I don't know if it's feasible, but maybe we need a separate validation library. People who need the robustness, could use to first validate the files? This way gltfio itself can stay lean and mean.

Yes, I like the idea of a compile-time option.  We actually already ask cgltf (the 3P library) to perform an explicit validation step in debug builds, but it does not catch everything.
I'm a little unsure about creating a separate validation library since that implies some duplication of effort: the "robust" version of gltfio would need to detect & recover errors, and that same detection would exist in the validation library.
Again, I like the idea of a "fast" version of gltfio.  For example a generic viewer should probably be robust, but a game with fixed assets does not.

For example a generic viewer should probably be robust, but a game with fixed assets does not.

exactly.


Training the model from scratch, pronunciation is unintelligible

Checks

[X] This template is only for question, not feature requests or bug reports.
[X] I have thoroughly reviewed the project documentation and read the related paper(s).
[X] I have searched for existing issues, including closed ones, no similar questions.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Question details
Using my own phone sequence, I trained the model from scratch, with about 200 hours of Chinese data and a 155M model. The synthesized speech is completely incomprehensible.
How much data is generally needed to train a model from scratch?

I have thoroughly reviewed the project documentation and read the related paper(s).

all details are given in our paper, including used training corpus for small model, batchsize, evaluation results from 400~800k updates

will close this issue, feel free to open if further questions


Suggestion

Guys, I really appreciate the work and effort made to make react-stripe-elements available.
But making a separate set of form components is forcing us to break away from the react components we are already using on our setup, and then comes the work to make these components fit with the rest of the UI, making it harder to work with it.
I know some people would appreciate having all the logic baked inside these components to build a card & payment form quick, but it is like re-inventing the wheel when there are great react form libraries that stripe could integrate into, making it easier for us developers that want to keep their UI consistent - and not be forced to fit yet another type of component in the mix.
Suggestion one: react-redux-form and redux-form are good form libraries that stripe can integrate into, making it easier to work with stripe for most of us.
Suggestion two: There are plenty of use cases in which we may want to create our own form component and want to create a token without being forced to integrate a specific set of components. If I want to pass the payment info as parameters to the stripe API and get back the token - clean and simple, without having to setup a form with another set of components (don't understand why v3 is going in this direction - giving more integration option is better than reducing them)

Hi @pbreah,
Thanks very much for the feedback!
We built elements to make it as simple as possible keep your UI consistent while still making SAQ A compatibility easy. For better or worse, the latest PCI guidelines say that to be eligible for SAQ A, sensitive card information must be collected within an iframe. We know it's different than directly controlling inputs, but you get a lot of power for that tradeoff (masking, formatting, localization, responsiveness, dynamic zip, etc). If you're running into specific use cases that don't fit into your forms or are hard to customize, please do contact support! (support@stripe.com).
Regarding redux: we don't want force all users of react-stripe-elements to use redux. If there are specific improvements to react-stripe-elements that would make redux tools easier to use, we'd love to hear them!


Fix where the  docs reference wrong method

It seems that the documentation for the findOrCreateBy method on the schema was referencing findBy instead. This updates it so it's using the correct method.

Thanks Jason!


CVE-2018-19786 - HashiCorp Vault < 1.0.0

Description
--
HashiCorp Vault before 1.0.0 writes the master key to the server log in certain unusual or misconfigured scenarios in which incorrect data comes from the autoseal mechanism without an error being reported.
##Vector:
CVSS:3.0/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H
score: 8.1 HIGH
References
https://github.com/hashicorp/vault/blob/master/CHANGELOG.md#100-december-3rd-2018
File affeted, Path:
tessera/key-vault/hashicorp-key-vault/target/hashicorp-key-vault-0.10.6-SNAPSHOT-all.jar
hash in file: SHA1: 89c99461b787eacb27ac23990e09ddd565ecfc26

Hi - we don't set any restrictions on the version of Vault used, provided that it supports the kv v2 secret engine.  It is the user's responsibility to ensure the version of their Vault server does not have this vulnerability.

@chris-j-h
https://github.com/jpmorganchase/tessera/blob/master/pom.xml#L328
really?

KeyValueOperationsDelegateFactory is a Tessera class that uses an SDK to create an HTTP client to Vault.  It doesn't create/start Vault itself.  Tessera's only interaction with Vault is through this client.


corrupted upgrade from 21.1: /usr/local/libexec/opnsense-auth: not found

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Tried upgrading our gateway to 21.7 yesterday, from 20.7. Made it as far as 21.1, and then had an upgrade failure on the console which resulted in a broken system. Please see opnsense-21.7-upgrade-fail.log
The GUI is still accessible, but there is no way to get administrative access because of the message sh: /usr/local/libexec/opnsense-auth: not found.
Hardware is HP DL20 Gen10.

looks like using third party (FreeBSD) package mirrors, which aren't compatible.
	varnish6: 6.5.1 -> 6.6.1 [FreeBSD]

reinstall is likely the quickest fix...
https://docs.opnsense.org/manual/software_included.html#packages-pkg

thanks, that explains it at least.


Partials vs. Layouts

Right now, the builder has a number of src objects that defines where and how it builds parsed data. The default src options are:
  src: {
    data    : {
      basedir: 'src/data',
      glob: 'src/data/**/*'
    },
    layouts : {
      basedir: 'src/layouts',
      glob: 'src/layouts/**/*'
    },
    pages   : {
      basedir: 'src/pages',
      glob: 'src/pages/**/*'
    },
    partials: {
      basedir: 'src/partials',
      glob: 'src/partials/**/*'
    },
    patterns: {
      basedir: 'src/patterns',
      glob: 'src/patterns/**/*.html'
    }
  }

I wanted to examine partials and layouts to determine whether they are both truly needed. The rough current semantic explanation is that partials are, well, just partials, while layouts are partials but also more layout-like and intended for use with handlebars-layouts. It's also a holdover from fabricator, and I didn't really think deeply about it.
Currently: In the prepare phase, anything matched by the partials glob is registered as a partial on the handlebars instance. Additionally, anything matching the layouts glob is also registered as a partial. Thus, they are treated the same here.
In the parse phase, however, layouts are additionally added to a layouts property on the global drizzleData object—this becomes necessary for accessing them later in the render phase for handlebars-layouts reasons. I can expand on why that is necessary if y'all are curious but will leave it out here for brevity.
All that aside, I'm wondering if having separate partials really does anything for us. In a "combined" model, all of the things would get registered as partials and all of the things would be available on the global data object. I'm not sure what to call these things if we combine them, maybe templates?
Anyway, can you think of any reason that we should keep partials separate from layouts?
/cc @tylersticka @mrgerardorodriguez @saralohr

Anyway, can you think of any reason that we should keep partials separate from layouts?

No, not really. I'd be fine with this. :+1:

:+1:

:+1:

Fixed in #58


Add bouncycastle to vespa-node-admin RPM

#4978 broke host admin (node admin running on host). I wasn't quite sure whether it was needed since the code isn't exercised.
FYI @freva @smorgrav


Merge Abstract intents

Remove intents from index.js
Abstract intents into single responsibility files and export what is necessary

Automated and Manual Alexa tests pass. Will merge this pull request


DEV settings not developy-enough

The appsettings.Development.json is almost the same as the appsettings.json sibling, whereas

DEV is missing the "AllowedHosts": "*" (if anything you might expect Prod version to be more restrictive)
imho DEV flavour could be "Default": "Verbose" just to show some useful variation

Thank you for the feedback.
You don't have to explicity define AllowedHosts in DEV appSettings as the the framework will just pick up whatever settings you have from the default appSettings.json. If you want to override some settings from the default appSettings.json then you are free to do so in a different  appSettings files like DEV, TEST, STAGE or PROD.

sure, but if DEV and PROD are the same you don't need secondary env-specific config.
My point wasn't [really] adding the optional AllowedHosts clause to make them more similar [but if you like AllowedHosts you probably would], but to make them more different to satisfy the distinct foibles of each env

but if DEV and PROD are the same you don't need secondary env-specific config.

Having a separate env-specific config won't hurt you. In fact, the Dev config is part of the default file generated when you create a new project from Visual Studio template. I think the goal is to guide/let the devs know that you can setup whatever env-specific config there instead of just adding them all in appSettings.json. In reality, apps should have at least two configs, (DEV and PROD), and both should have different settings.

Understood that AllowedHosts is optional, and presumably MS include that clause in the PROD file as a reminder that maybe they should whitelist intended sites [whereas DEVs are unlikely to care about security niceties]. I agree that the different env files should be different [especially for logging], but the only difference was that AllowedHosts clause [that doesn't matter much in dev-land] which is why I raised the issue.
The MS templates (e.g. Empty) generates those 2 files [exactly as your code download], so really my complaint is with the MS templates and not anything that you authors have invented [my bad assumption!]
The PDF for the book (p259/603) describes pecking order well enough, but most templates will create the appsettings files automatically so users won't have to manually create as instructed on pp507-509 [that also well describe Logging knobs].
I think we agree so I'm closing this Issue #15 now. Thanks for your time Vince.


Type classes for common structures: strict total order

Description
This addresses issue https://github.com/input-output-hk/formal-ledger-specifications/issues/34 for the special case of inequalities.
The main goal of this PR is to allow us to use a single operation
symbol, _<_, to denote the less than relation on the types ℤ, ℕ,
and the Slot and Epoch types occurring in fields of the
EpochStructure record type.
In fact, I could only find one instance of a special, decorated
less than symbol---namely, the symbol <ˢ occurrs on line 97 of
the PPUp.lagda file.
The new HasStrictTotalOrder module, and the instance for
HasStrictTotalOrder Slot _≡_ in the HasStrictTotalOrder/Instance
module, allows us to write < on line 97 of PPUp.lagda (instead of <ˢ).
Some purely cosmetic/no-op improvements were removed from this PR, but
these should probably be included in a future PR.  In particular,

a couple of modules we touch here import the entire Algebras module
in cases where we only really need open import Algebras.Bundles using (Semiring).

Another minor cosmetic improvement would be to change the lines in
equational reasoning proofs near the bottom of Utxo.Properties that
begin with ℤ.+_; these can all begin with ℤ.+ instead.

Checklist

[X] Commit sequence broadly makes sense and commits have useful messages
[X] Code is formatted according to CONTRIBUTING.md
[X] Self-reviewed the diff

I have no idea why there are so many repeated commits in this PR. 😥

I've been looking at your inequalities PRs, and I think we should try as much as possible just to have one type class. Our orders are not necessarily total, so I think partial orders are a reasonable choice. We could choose between strict and non-strict, but it doesn't really matter since there are Relation.Binary.Construct.NonStrictToStrict and Relation.Binary.Construct.StrictToNonStrict which can convert them in either direction.
With that in mind, I think it's best to close this PR & derive a strict partial order from the partial order in your other PR instead.

I've been looking at your inequalities PRs, and I think we should try as much as possible just to have one type class. Our orders are not necessarily total, so I think partial orders are a reasonable choice. We could choose between strict and non-strict, but it doesn't really matter since there are Relation.Binary.Construct.NonStrictToStrict and Relation.Binary.Construct.StrictToNonStrict which can convert them in either direction.
With that in mind, I think it's best to close this PR & derive a strict partial order from the partial order in your other PR instead.

@WhatisRT Okay, I'll close this and open a new one.
However, I think it would be nicer to have alternative choices allowing us to specify exactly what type of order we mean to use implicitly.  That seems safer to me.  Also, I don't like the idea of "casting" from a strict relation to a non-strict relation and back, especially if this will be happening implicitly.  That seems dangerous.
What would you think about having a single HasOrder module that supports the various order type-classes, as follows:
{-# OPTIONS --safe #-}

module Interface.HasOrder where

open import Level using (_⊔_ ; suc)
open import Relation.Binary using (Rel)
open import Relation.Binary.Structures

record HasPreorder {a ℓ ℓ₂} (A : Set a) (_≈_ : Rel A ℓ) : Set (a ⊔ ℓ ⊔ suc ℓ₂) where
  infix 4 _≤_
  field
    _≤_ : Rel A ℓ₂
    isPreorder : IsPreorder {A = A} _≈_ _≤_

record HasPartialOrder {a ℓ ℓ₂} (A : Set a) (_≈_ : Rel A ℓ) : Set (a ⊔ ℓ ⊔ suc ℓ₂) where
  infix 4 _≤_
  field
    _≤_ : Rel A ℓ₂
    isPartialOrder  : IsPartialOrder {A = A} _≈_ _≤_

record HasStrictPartialOrder {a ℓ ℓ₂} (A : Set a) (_≈_ : Rel A ℓ)  : Set (a ⊔ ℓ ⊔ suc ℓ₂) where
  infix 4 _<_
  field
    _<_ : Rel A ℓ₂
    isStrictPartialOrder : IsStrictPartialOrder {A = A} _≈_ _<_

record HasTotalOrder {a ℓ ℓ₂} (A : Set a) (_≈_ : Rel A ℓ) : Set (a ⊔ ℓ ⊔ suc ℓ₂) where
  infix 4 _≤_
  field
    _≤_ : Rel A ℓ₂
    isTotalOrder : IsTotalOrder {A = A} _≈_ _≤_

record HasStrictTotalOrder {a ℓ ℓ₂} (A : Set a) (_≈_ : Rel A ℓ)  : Set (a ⊔ ℓ ⊔ suc ℓ₂) where
  infix 4 _<_
  field
    _<_ : Rel A ℓ₂
    isStrictTotalOrder : IsStrictTotalOrder {A = A} _≈_ _<_

record HasRawLeq {a ℓ} (A : Set a) : Set (a ⊔ suc ℓ) where
  infix 4 _≤_
  field _≤_ : Rel A ℓ

It's not less safe, since the conversions are done exactly like you'd expect. In fact, I think it's more safe: going this route it's guaranteed that a ≤ b iff a < b or a ≈ b, while if we allow other instances this might not always hold.
This many type classes approach won't work, since if you write a ≤ b it's again not clear what it should be. Does it refer to a preorder or partial order? This doesn't even work if there'd only be one possible instance, since Agda will complain even before it goes into instance search that there are multiple definitions for _≤_.

We've decided against having a type class for each type of inequality, so this PR is obsolete.  As a result, we cannot have a inequality type class for, e.g., the TokenAlgebra, since the inequality for that type is abstract so it's impossible to prove the order properties.  (Previously, we included a "raw partial order" which didn't require proof of the properties and so could be used for abstract types like the TokenAlgebra type.)


Guidelines: put a page with best practices on doxygen commenting.

Topics to cover:

@retval What to do when bool. az_results. -1, 0, and >=0. When not to use retval.
Starting with capital letter, ending with periods.
backticking (NULL, true, false, uint32_t and so on)
# references (+ ending functions with ())
short @briefs, when to use @remarks or @notes, or @details
@param[in], [out], [in,out], or just @param.
Use @file. Use @file with no name after it.
Few examples of non-ideal wording, and better ones (search https://github.com/Azure/azure-sdk-for-c/pull/1057 for examples)
Do not use "see below" in doxygen comments.
Documenting struct members, enum members. ///< vs '///'. Separating groups with regular comment (// === Section ===). Separate with empty line before, stick from the top with with no newline.
What not to include in doxygen, but put as a simple comment
Documenting internal and local functions, tests? Samples? in .c files?

Prefer illustrative do/don't format.

Moved to the SDK repo,
https://github.com/Azure/azure-sdk/issues/1721

FYI, you can use the GitHub "Transfer issue" feature to move issues between repos. That makes it quite easy.


feat!: implemented artifact manifest type

Implemented ArtifactManifest and related structs and functions. Unit tests included. Will rebase after #28 is merged into main.
Part 3 of #21
Signed-off-by: wangxiaoxuan273<EMAIL_ADDRESS>

Codecov Report

Merging #29 (4c4b5f2) into main (f71877f) will decrease coverage by 0.00%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   57.18%   57.17%   -0.01%
==========================================
  Files         105      106       +1
  Lines       10842    10905      +63
==========================================
+ Hits         6200     6235      +35
- Misses       3954     3977      +23
- Partials      688      693       +5

Impacted Files
Coverage Δ

manifest/ocischema/manifest.go
74.19% <ø> (ø)

manifest/ocischema/artifact_manifest.go
55.55% <55.55%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I think a builder struct will be needed for artifact manifest, so that we can enforce some rules on artifact manifest creation. I'll add it in future when necessary, for now I'll just create artifact manifest by hand.


Storage:ceph:rook. No nodes are available that match all of the following predicates:: MatchNodeSelector (1), PodToleratesNodeTaints (1).

After my 2 node cluster has been running for a day or so I notice a number of the pods in the rook namespace have the following status.
No nodes are available that match all of the following predicates:: MatchNodeSelector (1), PodToleratesNodeTaints (1).
Pods are in pending state.
What debugging information can I supply that is more pertinent to resolve issue?
What is the next move to get back to healthy state?

It means that there is not enough resources to schedule those pods. You can increase the size of your node, or create another node in order to schedule these pods.

ok. I did resize the worker node from 1G to 2G post the build.
Im trying to get the balance right between costs and kube functionality optimal.
Will feed back my actions and outcomes.

Perhaps a minimum config needs to be stated to prevent users having to expend the time to experiment with this capacity issue.
Or perhaps as part of testing that is planned a validation of minimum capacity should be done. (As the stack gets higher the capacity required per release may go up, or as tuning goes on it may come down)

going to try a reboot on the worker and just monitor that machine resources are stable before I move up the capacity config.

After worker node restart only 1 pod failed to recover.
rook-ceph-mgr0-2487684371-3hvs5
rook
<IP_ADDRESS>
Waiting: CrashLoopBackOff
47
7 hours
Error syncing pod
Back-off restarting failed container

You should remove the pod and the replication container will start a new one.

Please feel free to open this issue again if the pod still doesn't come back up.


Prepare for 3.12 / Drop 3.7

Description
To ensure cvxpy is usable with the newly released 3.12, we planned to ship cvxpy with a 3.12 wheel right away.
I tested it locally and it works. Currently, our solvers do not have prebuilds for 3.12, but I managed to install all of them locally, except for SCS. I think the build would not go through if this was the case on the CI as well.
This PR also drops Python 3.7 support, as it has reached EOL (https://devguide.python.org/versions/).
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[x] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[ ] Check that your code adheres to our coding style.
[ ] Write unittests.
[ ] Run the unittests and check that they’re passing.
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

My approval is conditional on resolving the typoes

Resolved the typos. Merging here based on the conditional approval and our discussions offline.


[stable/fluent-bit] update to fluent-bit v1.3.7

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @edsiper

/lgtm


Missing ContentKeyIdentifierClaimType

As stated on How to use DRM to playback MK.IO assets encrypted, MK.IO will honor the usage of the claim type "urn:microsoft:azure:mediaservices:contentkeyidentifier".
However, the identifier is missing (it was present on ASM package).

Thanks. I merged your pull request

In https://github.com/microsoft/MK.IO/releases/tag/v1.7.2


Impl arithmetic traits on fractions

@malik672 This PR introduced breaking changes. And the version was already bumped to 0.8.0. Can you release it first and make the next one 0.9.0?

Ok will  do that


chore(MONGODB-CR): document removal of MONGODB-CR

Fixes NODE-1300

@mbroadst I originally wrote in a warning, but @behackett's comment here says that we should not warn.


[TextField] Specs alignment

Updated helperText css to align with css from Label/Placeholder
Closes #17147

Thanks


Ackermann steering with steering angle.

🎉 New feature
Closes #1863
Summary
Option to use <steering_only> to enable a mode that does not drive the wheels. It instead only controls the central steering angle phi in radians on a /model/{name_of_model}/steer_angle gz::msgs::Double. This is usefull for simulating the control of a real vehicle without direct cmd_vel capabilities.
Test it

https://user-images.githubusercontent.com/10233412/212523915-1357228c-ad57-4005-8e56-fbf31b061b82.mp4
Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Added example and/or tutorial
[x] Updated documentation (as needed)
[x] Updated migration guide (as needed)
[x] Consider updating Python bindings (if the library has them)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Hmmm, somewhere along the way I got a regression of the default cmd_vel method.
Working to figure it out now.

Changes look good to me, but can you add some tests to cover this new functionality?

Mmmmm, found one last interesting use that needs addressed. 4 wheel steer and multiple vehicles, guess I get to add sub_topics to it as well.

@ahcorde thanks for the reviews, just finished adding them all.

@osrf-jenkins retest this please


Can't install the package with npm

Following the install guide from the README, I can not install the package. Here is the logs
❯ npm install @lukemorales/query-key-factory
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Required: {"node":"^14 || ^16","npm":"please-use-yarn","yarn":"^1"}
npm ERR! notsup Actual:   {"npm":"8.1.0","node":"v16.13.0"}

npm ERR!      /Users/myuser/.npm/_logs/2022-08-29T07_35_29_130Z-debug.log

I think its because of please-use-yarn package, but why is there such restriction?
If you plan to keep this restriction, I think readme has to be updated to use yarn as example and also maybe message about this restriction, or at least some more meaningful error message would be good for the end users. I see that original please-use-yarn package is very very simple and provides only message in Chinese, so maybe there is another way to enforce such restriction (fork that or just use something else)?

@Shaglock Thanks for bringing this to my attention. Sorry about the inconvenience, it was totally a misunderstanding that the yarn restriction would only affect development. I just published v0.2.1 without that engine restriction


Support optional auto unzip for zip files when submitting agents with secret sources

Note: not all the zip files need to be unzipped

Implemented in #7f22eac


3D dilation support

From mxnet api, 3d dilation is supported. However, When I check this, I find in fact, 3d dilation may not be included in mxnet.
Ubuntu 16.04
mxnet 1.0.0
python
Error Message:
Dilate is not supported in 3d convolution
`---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
 in ()
11 # conv3D_ex = conv3D.simple_bind(mx.gpu(), arg_dicts={'data':data})
12 # conv3D_exe = conv3D_bn.simple_bind(mx.gpu(), data=data.shape)
---> 13 conv3D_exe = conv3D_maxpl.simple_bind(mx.gpu(), data=data.shape)
14 args = conv3D_exe.arg_dict
15
xxx/mxnet/python/mxnet/symbol.pyc in simple_bind(self, ctx, grad_req, type_dict, group2ctx, shared_arg_names, shared_exec, shared_buffer, **kwargs)
1477                 error_msg += "%s: %s\n" % (k, v)
1478             error_msg += "%s" % e
-> 1479             raise RuntimeError(error_msg)
1480
1481         # update shared_buffer
RuntimeError: simple_bind error. Arguments:
data: (3L, 1L, 7L, 7L, 7L)
Error in operator convolution3: [20:54:34] src/operator/./convolution-inl.h:495: Check failed: param_.dilate.Size() == 1U (8 vs. 1) Dilate is not supported in 3d convolution
Stack trace returned 10 entries:
[bt] (0) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(_ZN4dmlc15LogMessageFatalD1Ev+0x3c) [0x7f9e0723ccfc]
[bt] (1) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(ZNK5mxnet2op15ConvolutionProp10InferShapeEPSt6vectorIN4nnvm6TShapeESaIS4_EES7_S7+0x2c9a) [0x7f9e0814e9fa]
[bt] (2) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(+0x131b46a) [0x7f9e07e9246a]
[bt] (3) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(+0x274bc23) [0x7f9e092c2c23]
[bt] (4) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(+0x274cfda) [0x7f9e092c3fda]
[bt] (5) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(+0x274dfc6) [0x7f9e092c4fc6]
[bt] (6) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(_ZN4nnvm11ApplyPassesENS_5GraphERKSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaIS7_EE+0x32c) [0x7f9e092ebb2c]
[bt] (7) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(_ZN4nnvm9ApplyPassENS_5GraphERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x3c9) [0x7f9e082859c9]
[bt] (8) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(_ZN4nnvm4pass10InferShapeENS_5GraphESt6vectorINS_6TShapeESaIS3_EENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x1f3) [0x7f9e08289373]
[bt] (9) xxx/mxnet/python/mxnet/../../lib/libmxnet.so(_ZN5mxnet4exec13GraphExecutor4InitEN4nnvm6SymbolERKNS_7ContextERKSt3mapINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES4_St4lessISD_ESaISt4pairIKSD_S4_EEERKSt6vectorIS4_SaIS4_EESR_SR_RKSt13unordered_mapISD_NS2_6TShapeESt4hashISD_ESt8equal_toISD_ESaISG_ISH_ST_EEERKSS_ISD_iSV_SX_SaISG_ISH_iEEERKSN_INS_9OpReqTypeESaIS18_EERKSt13unordered_setISD_SV_SX_SaISD_EEPSN_INS_7NDArrayESaIS1I_EES1L_S1L_PSS_ISD_S1I_SV_SX_SaISG_ISH_S1I_EEEPNS_8ExecutorERKSS_INS2_9NodeEntryES1I_NS2_13NodeEntryHashENS2_14NodeEntryEqualESaISG_IKS1S_S1I_EEE+0x612) [0x7f9e082df082]
Minimum reproducible example
import mxnet as mx
data = mx.nd.arange(1029).reshape((3,1,7,7,7))
x = mx.sym.Variable('data', shape=(3,1,7,7,7))
conv3D = mx.sym.Convolution(data=x, kernel=(3, 3, 3), pad=(2, 2, 2), dilate=(2, 2, 2), num_filter=2)
What have you tried to solve it?
I tried to check the source code of src/operator/convolution-inl.h. And I  found all these code related to dilation.

format:
line number code snapshot

DMLC_DECLARE_PARAMETER
69    DMLC_DECLARE_FIELD(dilate).set_default(TShape())
70    .describe("convolution dilate: (h, w) or (d, h, w)");
Forward function
133 if (param_.kernel.ndim() > 2) {
LOG(FATAL) << "Volume convolution is not implmented in mshadow";
}
177           param_.dilate[0],
178           param_.dilate[1]);
Backward function
212 if (param_.kernel.ndim() > 2) {
LOG(FATAL) << "Volume convolution is not implmented in mshadow";
}
266           param_.dilate[0],
267           param_.dilate[1]);
479     CHECK_EQ(param_.dilate.Size(), 1U)
<< "Dilate is not supported in 3d convolution";
InferShape function
448    } else if (param_.kernel.ndim() == 3) {
449      // 3d conv_v1
init function
385      CHECK_EQ(param_.kernel.ndim(), 3U) << param_.kernel.ndim() << "D convolution not supported";
386      param_.layout = param_.layout ? param_.layout.value(): mshadow::kNCDHW;
387      if (param_.stride.ndim() == 0) param_.stride = Shape3(1, 1, 1);
388      if (param_.dilate.ndim() == 0) param_.dilate = Shape3(1, 1, 1);
389      if (param_.pad.ndim() == 0) param_.pad = Shape3(0, 0, 0);
As you can see, this code is not consistent. Some parts say 3d dilation supported other parts not.

https://mxnet.incubator.apache.org/api/python/gluon.html#mxnet.gluon.nn.Conv3D

@dongzhuoyao  So did you run the code from gluon interface? I run the code from mxnet v1.0.0 (the most recent version).

given your four line code, I can run it with no error. @KnightOfTheMoonlight

Really?!
I just tried gluon interface.  Code like this:
net = gluon.nn.Sequential() net.add(gluon.nn.Conv3D(2, (3,3,3), strides=(2,2,2), padding=(2,2,2), dilation=(2,2,2))) net.add(gluon.nn.BatchNorm()) net.add(gluon.nn.MaxPool3D((3,3,3), stride=(1,1,1)))
I still got this 3d dilation not supported error. I checked my mxnet version. I install it by "pip install mxnet-cu80=1.0.0"
And I think that gluon interface is just a wrapper for mxnet. Then if the core mxnet code does not support 3d dilation, the gluon interface will be the same, right?

and the mxnet version is 0.12.0
this code is ok.
import mxnet as mx
print mx.__version__
data = mx.nd.arange(1029).reshape((3,1,7,7,7))
x = mx.sym.Variable('data', shape=(3,1,7,7,7))
conv3D = mx.sym.Convolution(data=x, kernel=(3, 3, 3), pad=(2, 2, 2), dilate=(2, 2, 2), num_filter=2)

this code is the same error as you.
import mxnet.gluon as gluon
net = gluon.nn.Sequential()
net.add(gluon.nn.Conv3D(2, (3,3,3), strides=(2,2,2), padding=(2,2,2), dilation=(2,2,2)))
net.add(gluon.nn.BatchNorm())
net.add(gluon.nn.MaxPool3D((3,3,3),stride=(1,1,1)))

I think there is something wrong between gluon and mxnet. maybe a bug.

@dongzhuoyao  Thanks for your suggestion.  I have tested the 0.12.0 version.
I found that even this code works,
conv3D = mx.sym.Convolution(data=x, kernel=(3, 3, 3), pad=(2, 2, 2), dilate=(2, 2, 2), num_filter=2)
when I add the following code to make it more real, I get the same error:
conv3D_exe = conv3D.simple_bind(mx.gpu(),data=data.shape)
I forgot to post this line in my issue, I just revised it again.
Btw, this no-3d-dilation 3d-conv code can run with no errors:
conv3D = mx.sym.Convolution(data=x, kernel=(3, 3, 3), pad=(2, 2, 2), num_filter=2)
conv3D_exe = conv3D.simple_bind(mx.gpu(),data=data.shape)
So I think in fact maybe 3d dilation is not supported. I will check the source code deeply, and wish the authors can check this issue.

Try cudnn_off=true

@chinakook Thanks for your suggestion. As I can remember mxnet has said 3d conv related things are based on cudnn calculation. But I still tried setting cudnn_off.
Here is the code:
import mxnet as mx
print(mx.__version__)

data = mx.nd.arange(1029).reshape((3,1,7,7,7)) # NCDHW
data_shape=(3,1,7,7,7)
x = mx.sym.Variable('data')
conv3D = mx.sym.Convolution(data=x, kernel=(3, 3, 3), pad=(2, 2, 2), dilate=(2, 2, 2), num_filter=2, cudnn_off=True)
conv3D_exe = conv3D.simple_bind(mx.gpu(),data=data.shape)

Here is the related error:
RuntimeError: simple_bind error. Arguments:
data: (3L, 1L, 7L, 7L, 7L)
Error in operator convolution0: [13:42:28] src/operator/./convolution-inl.h:495: Check failed: param_.dilate.Size() == 1U (8 vs. 1) Dilate is not supported in 3d convolution

proposed labels: "Bug", "Python", "Gluon", "CUDA"

cuDNN didn't support 3d dilation convolution yet, will use another method to achieve the same functionality. @sandeep-krishnamurthy please add feature request label. thanks


[Storage] [Blob] Fixed next pylint errors in blob storage

Description
Fixed all next pylint errors in blob storage except docstring-keyword-should-match-keyword-only. This is the fix for issue #32630 .
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob


Add initial transforms config blueprints.

This PR is adding initial versions of transforms config blueprints. These will likely take few iterations to settle on, so please let me know what are your thoughts.

Template to remove PII proposed by Alex.
# Policy to search for "sensitive PII" as defined by
# https://www.experian.com/blogs/ask-experian/what-is-personally-identifiable-information/
schema_version: 1.0
name: "Redact PII"
models:
  - transforms:
      data_source: "/Users/piotr/dev/gretel-cli/data/bike_orders/bike-customer-orders-15000.txt"
      policies:
        - name: remove_pii
          rules:
            - name: fake_or_redact_pii
              conditions:
                value_label:
                  - person_name
                  - credit_card
                  - us_phone
                  - us_ssn
                  - email
                  - custom/*
              transforms:
                - type: fake
                - type: redact_with_char
                  attrs:
                    char: X

label_predictors:
  namespace: custom
  regex:
    user_id:
      patterns:
        - score: high
          regex: "user_[\\d]{5}"


[SPDX][TV] SBOM value format is incorrect for ExtractedText

Summary
SPDX value format is  missing or incorrect for ExtractedText
ExtractedText: NONE
Background

Download syft version 0.73.0
Generate sbom with syft packages {image}:{version} -o {syft_format} --file {out_file} for centos tag centos8.4.2105
Observe the following error:

SPDX value format is  missing or incorrect for ExtractedText
Expected behavior
ExtractedText should be delimited by <text>..</text>
Screenshots
If applicable, add screenshots to help explain the problem.
Repository
Which repository causes this error?

centos:centos8.4.2105

Additional Context
Optional - add any other context about the problem here.
Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

Unit Tests added and running in CI
Functional Tests updated to cover feature, if applicable
Demonstrate the set of capabilities to the product team

References
Limited to SPDX.
Finder: sbomqs
SBOM: sbomlc-centos-centos

@surendrapathak this may be an issue, but the example SBOM I only see:
ExtractedText: NONE

This is not multi-line text, and therefore does not need to be surrounded by the <text> delimiters.
The spec says: "In tag:value format multiple lines are delimited by <text> .. </text>."

@kzantow - Oh god! You are right. A' NONE' should be permitted based on how the spec is.
It feels like an issue with our eager tool. We will take it for a deeper dive into licenses tomorrow, but please feel free to close this thread for now. Sorry about the false positive.

Invalid


Apply highlightClass to currentElement when tour.modal == false

I'm currently implementing a tutorial with this library (thank you!) where I do not want to dim the entire page, but would like to apply a specific highlight class to the target of attachTo when a given step is active.
I was surprised to find that the highlightClass option for a step is only applied within the popoutElement service method, which itself is only called here when tour.modal == true and currentStep.options.copyStyles == false.
I'm wondering if it's a principled decision to restrict the usage of highlightClass to this set of conditions. This PR adds a path that applies step.options.highlightClass to the target element when tour.modal == false; let me know what you think.

LGTM! Thanks!


Fix filename / path handling of .pickle / .parquet files

Fixes .pickle / .parquet file handling during import from Strava export

Thank you for these changes! I haven't tested the Strava checkout importer lately. I'll obtain an archive and set up some testing with it the next time I work on this project. The number of defects that I introduce start to become annoying.


[zh] Update hyperlinks to point to main branch in blog post

Fix issue spotted here https://github.com/kubernetes/website/pull/31748#issuecomment-1153261829.

/lgtm
/approve


WIP: first recipe for EN-FR baseline

@srush Have a look at this.
this is the kind of recipe that makes the system easy to use for newbies (and more).
it's very preliminary but in the same code style as what we do for Kaldi.
Cheers,
Vincent

Thanks for doing this, this will be quite helpful.
There are couple policy things to decide:

There has been uncertainty in the past about including any Perl code in the repo. I am quite sensitive to this argument. The assertion is that we don't need these scripts of Kaldi/Moses anymore since our interface is significantly more intuitive.
Obviously this doesn't apply when the input data comes in XML form.  Therefore, we should probably have an SGM-to-txt converter. This is something we can maybe do in Lua or Python for supportability.
There is a stronger argument for including multi-bleu, which is standard and just makes things more convenient.

Finally I also am not sure these recipes need to be in the main repo. Potentially we could have a OpenNMT/recipes which collects them and includes tutorials? This keeps the surface area of the code base smaller.
Let me know if you want to talk more in gitter.

oh all these links were supposed to be relative links to OpenNMT/ files or folders, just to be able to execute lua scripts from the recipe-name folders.
Anyway all what you outline above makes sense especially if you want to keep it a pure lua / core code repo.
my view is the following:
For a framework (like tensorflow) it make sense to make these things apart.
For a "toolkit" I think it's good to expose some pre-written scripts like EMS for moses.
it helps users to better adopt the product.
Last, unless I am mistaken, WM-like stuff rely more on sgml format for test sets.

This is sensible. And I agree short term, having evaluation and WMT SGML
support is crucial. I raised it with the other developers so we can decide
on a policy going forward.
On Mon, Jan 9, 2017 at 2:34 PM, vince62s<EMAIL_ADDRESS>wrote:

oh all these links were supposed to be relative links to OpenNMT/ files or
folders, just to be able to execute lua scripts from the recipe-name
folders.
Anyway all what you outline above makes sense especially if you want to
keep it a pure lua / core code repo.
my view is the following:
For a framework (like tensorflow) it make sense to make these things apart.
For a "toolkit" I think it's good to expose some pre-written scripts like
EMS for moses.
it helps users to better adopt the product.
Last, unless I am mistaken, WM-like stuff rely more on sgml format for
test sets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_OpenNMT_OpenNMT_pull_57-23issuecomment-2D271384702&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=wnHFZ7D4m-9MRwk-CWlvCGbWEiQX_AvUO2LuMy4Vj7c&m=-NIDk0dd4NGWWr4twEGH1-rI541EV3sJr26EEDw8ubc&s=JTpRVGNJK0ZdhWVu8yS1Q8-33vON8b09XTNaXlzUSkc&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AACMKoPV3WgfHusaEyGt3hhzMhrVpBw3ks5rQovegaJpZM4LeQR6&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=wnHFZ7D4m-9MRwk-CWlvCGbWEiQX_AvUO2LuMy4Vj7c&m=-NIDk0dd4NGWWr4twEGH1-rI541EV3sJr26EEDw8ubc&s=g4mK-t4jyJqIM-pELVKz8Fnjl8JJ4ZxMLJUc9SW8MLo&e=
.

@vince62s, this is great! fyi, we are preparing a benchmark platform that we will open very soon, and the outcome of this recipes will be the baseline system. thanks a lot. I like the idea of recipe and we should commit that in a recipe/ folder (isn't it more explicit than "egs"?). For the evaluation - what I propose (and we are working on that), is that we get all reference testsets we know of, and push them into a reference_testset_xxyy.tgz package on the s3 bucket together with all the tool needed to wrap/unwrap and compute the score. So your recipe will pull the package, and just iterate on all the bash script test_something.sh, to compute all the scores. what do you think?

new thoughts on that : I do not like starting introducing a lot of new stuff inside the OpenNMT directory - to keep it small/restricted to the minimum. Also being consistent on lua allows us to run complete process wherever we want (like embedded, with minimal dependencies). Why don't we create 2 new repositories: "recipes" (or egs) that  will contain end-to-end scripts, and "3rdParty" that will contain minimal number of tools maintained in other projects like  mteval/multi-bleu? and the tools for sgm conversion could be in OpenNMT/tools - in lua.

No pb to me. There is only one limitation: lua does not accept execution outside the current directory. So I had to create relative symlink to make things "easy for a newcomer" to understand the logic. If we copy this outside the main repo you will have to ask the user to 1) either make the symlink 2) respect the folders name of the 2 repos on his local computer.
Hope this is clear, but I do understand the will to keep the house tight.

What about a separate repository but include it as a submodule in OpenNMT?

after discussion with @guillaumekln - here is what we propose:

we create a new repository recipes that will be a sub-module of OpenNMT. Like Kaldi, I propose that actual recipes are stored in recipes/name/ directory
for conveniency, we also create another repo tools/3rdParty - where we can commit reference eval scripts and misc conversion scripts useful for the test
finally, I propose that the actual official test sets license-free that we can collect are stored in s3 bucket (since they won't be recipe-dependent)

@srush, @vince62s - is this ok for you?

Sounds good to me. We'll just have to document the fact that the "recipes" repo shall not be cloned on its own but only used as a submodule.

Sorry, I'm going to object to the use of submodules. It adds weight to the checkout and complicates things. My proposal is that we should have tools/thirdparty checked into the core opennmt repo when the license allows (as it is lightweight and I don't really understand the lua only thing) and recipes as a separate repo. We should come up with a technical solution to the lua issue by either making a symlink in the recipes, by setting LUAPATH, or by installing opennmt through luarocks.

Guys I am not a difficult person :) - just keep in mind that these "recipes" are supposed to be very light weight. Mainly ONE script, ONE results file and symlinks.
the "data" / "exp" folders are created on the fly on the user local repo and the "newstest" is going away since we will download files from S3 and put them in "data".
for "third party-tools" maybe could stay here as a temporary solution until someone re-writes them in lua.

I will also object a bit here :) - agree the submodule is not really necessary but starting introducing third party tools inside the code base is dangerous - the two ones we are mentioning are tiny, but there are others that are far bigger around and also multi-bleu and mteval are LGPL not MIT. Finally they are available on a github repository, so the best is that the recipes get them directly from where they are.
So I think - we agree on the recipes repo (I am creating the repo), recipes should get what they need from where they are (opennmt, but also im2text), and for simplifying life of users, we are gathering all known official test sets on s3 bucket (first draft will be done tomorrow). @vince62s, as discussed, we are also pushing 2M baseline corpus and I will come back to you soon on the benchmark platform.

Okay, so @jsenellart-systran and I are on the same page then. We host Recipes as a repo (actually made one alreads), third-part tools come from another repo. We make it very clear how to get recipes and eval on the website, but OpenNMT remains Lua-only and our support tools.

I think I understand everything except for third party tools.
Do we ask the user to install / download them directly ? do we script the downloads for them ?
if the latter, do we put them locally in a specific folder ?

I propose that it is part of your download at the beginning of the recipe:
wget https://raw.githubusercontent.com/moses-smt/mosesdecoder/master/scripts/generic/mteval-v13a.pl

as for Kaldi recipe, I propose that we do not plan any optimization by sharing cross-recipe knowledge, so each occurrence of the recipe will download them (we can just check that we don't have them yet in the current directory - which is more critical for the data)

I agree with one change. Can we make it so the recipes put all their temp
files in a time stamped directory? It should be easy to erase and start
again.
On Tue, Jan 10, 2017 at 9:49 AM, Jean Senellart<EMAIL_ADDRESS>wrote:

I propose that it is part of your download at the beginning of the recipe:
wget https://raw.githubusercontent.com/moses-smt/mosesdecoder/master/scripts/generic/mteval-v13a.pl
as for Kaldi recipe, I propose that we do not plan any optimization by
sharing cross-recipe knowledge, so each occurrence of the recipe will
download them (we can just check that we don't have them yet in the current
directory - which is more critical for the data)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_OpenNMT_OpenNMT_pull_57-23issuecomment-2D271594488&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=wnHFZ7D4m-9MRwk-CWlvCGbWEiQX_AvUO2LuMy4Vj7c&m=xl7ZoijASLdU-afYwO8b_3BIaFQYyic2xzkmd4yscUo&s=pP7lPC7ZuPBEcZiptKWffBBBtY5kG4dNfJTeotd9Q_g&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AACMKoPgL7Ivv0txq1UFquXM6mx1N2Guks5rQ5qEgaJpZM4LeQR6&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=wnHFZ7D4m-9MRwk-CWlvCGbWEiQX_AvUO2LuMy4Vj7c&m=xl7ZoijASLdU-afYwO8b_3BIaFQYyic2xzkmd4yscUo&s=2cnLoZUFPHFpecEssp5TLpNOkfKgvPAuJ3aoSHpBqRo&e=
.

@vince62s - see https://s3.amazonaws.com/opennmt-tests/onmt_enfr_tests.tgz - we are preparing this type of repository for all languages - this contains all official test sets (older and more recent) from WMT - and we will also include other competitions where testsets are public. this is just a first draft - we do need to add some information about each file in the repo, but the idea will be this one, where we also normalize all the file format for simple processing. it would be great if you can publish the first recipe using these test sets.

will do. I just to make sure I full understand the reported Bleu as per the tutorials.
Usually we do report bleu on detokenized text.

@vince62s You have write access on OpenNMT/Recipes, so feel free to just add these as you go. And we decided to the not import the metrics. Therefore I am going to close this PR as completed.


Migrate docs from GitBook

This PR migrates the CI plugin documentation https://mattermost.gitbook.io/circle-ci-plugin/ currently hosted via GitBook to the GitHub repository README file.
Once this PR is merged, the GitBook-hosted content can be archived/removed.

@hanzei - Are you able to merge this approved PR for me?

/update-branch

@cwarnermm I can't merge this PR due to a configuration issue, I've reached out via https://community.mattermost.com/private-core/pl/gyeutikrc3ntfbug8thunmsoyy.

Thanks so much, @hanzei!


after compiled: export keyword  “char”  has been replaced  like "_char",  but import still  use "char"

Describe the bug
"@swc/core": "1.3.49"
example
test.js
export function char() {   console.log("char====char");   return ""; }
util.js
import { char } from "./test"; char();
complied code：
`"use strict";
webpack_require.r(webpack_exports);
/* harmony export / webpack_require.d(webpack_exports, {
/ harmony export /   "_char": () => (/ binding / _char)
/ harmony export */ });
function _char() {
console.log("char====char");
return "";
}
"use strict";
webpack_require.r(webpack_exports);
/* harmony export / webpack_require.d(webpack_exports, {
/ harmony export / });
/ harmony import */ var test__WEBPACK_IMPORTED_MODULE_0_ = webpack_require("./src/test.js");
(0,test__WEBPACK_IMPORTED_MODULE_0_.char)();
`
export keyword  “char”  has been replaced  like "_char",  but import still  use "char"
Input code
No response
Config
No response
Playground link
No response
Expected behavior
export keyword  “char”  has been replaced to a new string
import follow the same rule
Actual behavior
No response
Version
1.3.49
Additional context
No response

Please provide a repro. At least a playground link

Please provide a minimal repro. It's way too large to analyze

this is a playground link
https://play.swc.rs/?version=1.3.49&code=H4sIAAAAAAAAA0utKMgvKlFIzs8rBpIZiUUKtgoamrZ2CtVcCkAAEs%2FPSdXLyU%2FXUAdJ24IBiKWuyVXLBQBc5g4TPwAAAA%3D%3D&config=H4sIAAAAAAAAA2VSu27DMAzc8xUC5wAZii7ZWnRJgXTKDxAKkyrQwyDpNEbgf69kxI4jexAk3olH3fm%2BMgYoXsFszT3vywchHQm2pa7cwXos28T0LRl4m0qnxJY%2BvD8wRsmHUGDllibGsYsYnN2FJrHWoCKfScudUbsv2LDARewEgI4CM24uezqj7b4oj4aauOpf5EdoT4pHVFxSmNDqS1tjNhvDbVQXKNuAraaA6iysC5DYWI8izs4uwIMOC%2F6cpL%2Bc%2FnanHwwkDVpaDJM5rdBn67y6WHv5eNCVfGpCzibDJ%2FQyw%2Fv1qtqAT0lqHWiQhfjVSumi4m2I3QYUy65RmNl0kdtS8OlvPWxfhTw0lnd45pv%2FstbTLOKuGeyzKYQULwIT08l%2B5BaJVf8PfP2zz7YCAAA%3D
export  "char"  was complied  to  Object.defineProperty(exports, "_char", {
enumerable: true,
get: function() {
return _char;
}
});
then, this will cause other module references to  "char " not to be found

Investigation: This is a bug of es3 compat pass (likely reserved_words)

It is a missing part of  #7165.
Please assign this issue to me.

Thank you!