MinTLSVersion is too low

https://github.com/elastic/go-elasticsearch/blob/master/elasticsearch_example_test.go
Recommends this code to configure the TLSClientConfig:
TLSClientConfig: &tls.Config{
MinVersion: tls.VersionTLS11,
},

But I ?think? (I am very unsure about this) Elasticsearch supports TLSv1.3 https://www.elastic.co/guide/en/elasticsearch/reference/current/jdk-tls-versions.html
The example repository should absolutely be updated to use tls.VersionTLS13 if it is supported by Elasticsearch.

To add to this: I came across this error because it showed up as a vulnerability via Gitlab's security vulnerability tool, which is a static analysis tool that I think uses gosec to find vulnerabilities.

Hi @Gregory-Ledray, thanks for raising this!
I agree this example should be bumped to a more recent version of TLS.
However while Elasticsearch does support TLS1.3 if it's JDK supports it, many providers are only supporting TLS1.2.
So I would suggest raising the MinVersion in the example to 1.2 for now, what do you think ?

Any improvement would be an improvement.


source ip when redirecting requests on the same host

Hello,
I'm new to the whole vpn topic and could not find another place to find help. Can you please help out?
I'm trying to use your container to limit access to certain parts of my website.
You can find my config here
I can connect to the vpn and I can also access all my docker containers through the route (<IP_ADDRESS>/16).
When I do curl v4.ifconfig.co from a connected client it shows me the ip from my server as expected.
When I send a request to my own webserver running in another container the logs show me a connection from my clients public ip.
What I would like to have is to also changes the source ip when I access my own website.
So that I can limit certain parts of the website to that ip and make content only available for connected clients.
Why is the source of traffic to my own server not changed?
How can I do this? Is that the right way to do this?
EDIT:
Shoudn't the OVPN_NAT=1 setting do what I want? I have the following iptables rule:
-A POSTROUTING -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE

I solved this by moving the openvpn server to another host/ip.
Still wondering why that isn't an issue for someone else.
https://serverfault.com/questions/858657/openvpn-and-website-on-the-same-server-ip

I have the same issue.
on the vpn host/container running on the host, i see my isp public ip everywhere. ssh, nginx logs etc..


Simulator refresh icon missing

Describe the bug

Chrome, stable branch

fixed

Still seeing this in stable.

fixed in latest stable


torch._C._LinAlgError

problem description
torch._C._LinAlgError encountered after a few terations
proposed solution
replacing torch.linalg.solve by torch.linalg.lstsq

I didn't encounter the problem before. I think it's fine but might be slower.
Or you can try to slightly increase the value of jitter

Hi, I found the solution to the problem after spending some time there. Let me know if I did a mistake.
torch.linalg.solve works for recent pytorch versions, you need to switch arguments.
Pytorch removed the old torch.solve(A,B) and torch.lstsq because its behaviour was different to numpys, see this stackoverflow post.
If you try to replicate the example from this stackoverflow link with torch.linalg, you will get the same result as in numpy.
So, I found that for newer python versions this is the correct way:
x = torch.linalg.solve(ATA + jitter, ATB) # NOT torch.linalg.solve(ATB, ATA + jitter)
x = x.reshape(n, self.gr, h, w)
I did come to the same conclusion as @cnexah that torch.linalg.lstsq is actually just slower.
  jitter = torch.eye(n=h * w, dtype=x.dtype, device=x.device).unsqueeze(0) * 1e-12  # Torch:(1, 1672, 1672)
  start_time_solve_linalg = time.time()
  x1 = torch.linalg.solve(ATA + jitter, ATB)
  x1 = x1.reshape(n, self.gr, h, w)  # Torch: (32, 1672, 1)
  end_time_solve_linalg = time.time()
  start_time_lstsq_linalg = time.time()
   x = torch.linalg.lstsq(ATA + jitter, ATB)
   x = x.solution.reshape(n, self.gr, h, w) # x.solution is 32,1,1672
   end_time_lstsq_linalg = time.time()
   difference = torch.norm(x1 - x)
   print(f"Time taken for linalg.solve: {end_time_solve_linalg - start_time_solve_linalg}, time taken"
                f" for linalg.lstsq: {end_time_lstsq_linalg - start_time_lstsq_linalg}"
                f"the difference between both tensors is {difference}")

An example output is: Time taken for linalg.solve: 0.40329957008361816, time taken for linalg.lstsq: 0.8831644058227539the difference between both tensors is 0.05662015080451965
Hope this helps future people :)


brackets as internet browser

Hi,
Got something unique happened to the software becoming a browser or this something like new feature. Don't know how it happen. Don't mind the web content :+

1:

This is not edited by the way.

As Brackets is based on CEF, it can also act as an general Web Browser. You can replicate the behavior for example dropping an URL to the working area.
However this behavior is not supported (at least currently) by any means in Brackets. To resume to the normal state, launch Brackets again.

@petetnt thanks.


support in non-Chromium browsers

Hi there, my team is interested in using this library to collect field data to flesh out the information from the Core Web Vitals report in the Google Search Console, in particular we hoped to be able to include data from browsers other than Chrome.
I've implemented reporters for CLS, LCP, and FID in my local development version of the site and I am seeing the reporting I would expect when I test in Chrome, but it seems that nothing is reported in Safari and only FID is coming through in Firefox. I don't understand why this should be, as PerformanceObserver is nominally supported in both those browsers. I've tried both the standard and base+polyfill version and I get the same outcome either way.
I double-checked by cloning the repo and running the test server and it does seem to confirm that only Chrome is logging these events - I tested in Chrome, Firefox, Safari, and the Safari simulator. Functioning in iOS Safari is especially important to us because it represents a significant share of our traffic.

I've implemented reporters for CLS, LCP, and FID in my local development version of the site and I am seeing the reporting I would expect when I test in Chrome, but it seems that nothing is reported in Safari and only FID is coming through in Firefox.

FID should be reported in both Safari and Firefox, but it's expected that you wouldn't see LCP and CLS in either of these browsers.
See the browser support section of the README for more details on exactly which browsers support which APIs.

I don't understand why this should be, as PerformanceObserver is nominally supported in both those browsers. I've tried both the standard and base+polyfill version and I get the same outcome either way.

Yes, PerformanceObserver is supported in multiple browsers but what you need to check is support for the relevant entry types.
E.g. you can run this in your browser to see:
console.log(PerformanceObserver.supportedEntryTypes);

The entry type you need for LCP is largest-contentful-paint, for FID it's first-input, and for CLS it's layout-shift.
The base+polyfill version of the library only polyfills the first-input entry, as that's the only one that can be reasonably polyfilled in a performant way.

ok thanks, sorry - not sure how I missed that section. I guess I just assumed that anything claiming to be a polyfill would cover more of the features.


[BUG] User Data and Network Data display incorrectly when provisioning RKE2 via terraform-provider-rancher2

Describe the bug
When provision RKE2 via terraform-provider-rancher2, UserData and NetworkData become garbled.

To Reproduce
Steps to reproduce the behavior:

Install Harvester with any nodes
Install Rancher
Login to Harvester dashboard, create an image for VM creation
Create a VM Network which able to access Rancher
Install terraform-provider-rancher2

Use https://github.com/rancher/terraform-provider-rancher2/pull/1051#issue-1520440132 or new version after this PR

Apply code snippet in Additional content

Update all UPPER_CASE info in the code snippet

View RKE2 cluster config after It provisioned (configuration will not able to view before RKE2 provisioned)

Expected behavior
UserData and NetworkData should display as human readable.
Environment:

Harvester ISO version: v1.1-a002d078-head
ui-source Option: Auto
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): qemu/KVM 3 nodes

Rancher Version:

v2.7-c24fb8b0869a0b445f55b3307c6ed4582e147747-head (Docker Image: 216bef921570)
v2.6-a55f968896341f311fc8302b3ed6247da3c13900-head (Docker Image: 122aa2f1b66b)

Additional context
ref to https://github.com/rancher/terraform-provider-rancher2/pull/1051#issuecomment-1452094194
Code snippet as below:
terraform {
  required_providers {
    rancher2 = {
      source = "rancher/rancher2"
      version = "0.0.0-master"
    }
  }
}

provider "rancher2" {
  api_url    = "RANCHER_URL"
  access_key = "RANCHER_ACCESS_TOKEN"
  secret_key = "RANCHER_SECRET_KEY_FOR_TOKEN"
  insecure = true
}

data "rancher2_cluster_v2" "foo-harvester" {
  name = "vm"
}

# Create a new Cloud Credential for an imported Harvester cluster
resource "rancher2_cloud_credential" "foo-harvester" {
  name = "foo-harvester"
  harvester_credential_config {
    cluster_id = data.rancher2_cluster_v2.foo-harvester.cluster_v1_id
    cluster_type = "imported"
    kubeconfig_content = data.rancher2_cluster_v2.foo-harvester.kube_config
  }
}

# Create a new rancher2 machine config v2 using harvester node_driver
resource "rancher2_machine_config_v2" "foo-harvester-v2" {
  generate_name = "harv"
  harvester_config {
    vm_namespace = "default"
    cpu_count = "2"
    memory_size = "4"
    disk_info = <<EOF
    {
        "disks": [{
            "imageName": "IMAGE_ID",
            "size": 40,
            "bootOrder": 1
        },{
            "storageClassName": "harvester-longhorn",
            "size": 5,
            "bootOrder": 2
        }]
    }
    EOF
    network_info = <<EOF
    {
        "interfaces": [{
            "networkName": "VM_NETWORK_ID",
            "macAddress": ""
        },{
            "networkName": "VM_NETWORK_ID",
            "macAddress": ""
        }]
    }
    EOF
    ssh_user = "ubuntu"
    user_data = <<EOF
#cloud-config
password: password
chpasswd: {expire: False}
sshpwauth: True
EOF
    network_data = <<EOF
version: 1
config:
  - type: physical
    name: enp1s0
    subnets:
      - type: dhcp
  - type: physical
    name: enp2s0
    subnets:
      - type: dhcp
EOF
  }
}

resource "rancher2_cluster_v2" "foo-harvester-v2" {
  name = "harv2"
  kubernetes_version = "v1.24.9+rke2r2"
  rke_config {
    machine_pools {
      name = "pool1"
      cloud_credential_secret_name = rancher2_cloud_credential.foo-harvester.id
      control_plane_role = true
      etcd_role = true
      worker_role = true
      quantity = 1
      machine_config {
        kind = rancher2_machine_config_v2.foo-harvester-v2.kind
        name = rancher2_machine_config_v2.foo-harvester-v2.name
      }
    }
    machine_selector_config {
      config = {
        cloud-provider-name = ""
      }
    }
    machine_global_config = <<EOF
cni: "calico"
disable-kube-proxy: false
etcd-expose-metrics: false
EOF
    upgrade_strategy {
      control_plane_concurrency = "10%"
      worker_concurrency = "10%"
    }
    etcd {
      snapshot_schedule_cron = "0 */5 * * *"
      snapshot_retention = 5
    }
    chart_values = ""
  }
}

This issue is not related to the multi disks and multi network issue，moved this issue to 1.2.0. cc @lanfon72

Hi,  @lanfon72 Can you help verify this problem first ？ It has been merged into rancher 2.7.2

@WuJun2016 this also break on v2.6-head, are we going to fix them on v2.6?

@WuJun2016 this also break on v2.6-head, are we going to fix them on v2.6?

It won't be fixed in 2.6.11 because it's already released,
Maybe it should be fixed in 2.6-head,  But there is no planned version  （rancher 2.6.12） right now

Tested with following cases:

UI fixed on Rancher v2.7-211409c9a689d8ee4d801ed1bce1d887b0fb4b00-head with Harvester v1.1.2-rc3, but RKE2 provision stuck.
UI not fixed on Rancher v2.7.2-rc5 with Harvester v1.1.2-rc3, but RKE2 provisioned successfully.

Verified this has been fixed.

Test Information

Environment: qemu/KVM single node
Harvester Version: v1.1.2-rc3
ui-source Option: Auto
Rancher Version: v2.7-cd1a71624a94de993d471ce8a643cf4d2dbb75a6-head

Verify Steps:

Follow Step to reproduce in https://github.com/harvester/harvester/issues/3598#issue-1611539260
Update userData in code snippet to include qemu-guest-agent[^1] as below:

#cloud-config
package_update: true
packages:
  - qemu-guest-agent
runcmd:
  - - systemctl
    - enable
    - '--now'
    - qemu-guest-agent.service

[^1]: we changed to not install qemu-guest-agent automatically when using terraform in https://github.com/harvester/harvester/issues/3392


Increase PHP upload size limit by default

I've worked with the WordPress importer on my vagrantpress box quite a bit, and something I've found myself doing repeatedly is changing the upload file size limit by hand. Would be cool if that could be done by default and be something fairly high (like maybe 200M).
Here's an SO suggestion on how to accomplish it.

I can fix that for you @fredrikekelund.
I'll take a look in the next few days.

Cool, thanks a bunch!


Webpack building devDependencies too

Hello man,
Thanks for the boilerplate.
Let's imagine a scenario where a function uses lodash, we would install lodash dependency in global layer so it can be reused without  bloat the function up (many functions use it)
The problem is that functions can't reference the installed module and keep linting "module not found" when coding the function body.
The first workaround was to install lodash as dev dependency in the function folder so  lint error stopped, however, when we build to deploy using webpack, the generated JS includes ALL de dev dependency in the function which makes it very heavy and the global layer unecessary.
How can we solve it?
Something about ignore devDependencies when compile?
I have spend many hours trying different solutions but with no luck. Your help would be appreciated.

I fixed it by using the webpack-node-externals plugin to webpack.
It removes all node_modules dependencies when building which makes the generated function JS very small containing only the function body.
I think it's a good ideia to make a PR to the boilerplate.


Fixing argument issue on minikube and minishift psi tests

Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>What type of PR is this?
Add quotes to arguments to ci-firewall request to ensure args are treaded as part of the script.
What does does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #4523
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:

/lgtm

Failures are not due to this change. Requires update in openshift/release


Make the setup.py more friendly to pip

Seems the tests failed due to an expired access token of the author.

Thanks for the PR and sorry for the late reply.
Er, but I don't really understand how this improves over the pip?

The source tarball could be created by python setup.py sdist.
Users won't have to install requests manually. pip will pull it in.

If you would like a dynamic-loaded description and version number, I suggest following the practice of you-get.

OK, I got the point and cherry-picked 6c4e356f987d81bdaba5a489da3ed07e27f81f4f Thanks.

Because bypy is a module with dependencies, and the dependencies might have not installed yet. In this case, the requests module.
The pip system (and install_requires field in setup.py) was introduced to solve the dependency problem, thus users don't need to fully read the installation manual and install dependencies one by one. Instead, one could just issue a "pip install " and wait for its completion, unless some C headers (xxx-devel in RH and xxx-dev in Debian) are required and building failed.
If you create a clean environment (a fresh python + setuptools + pip, nothing else), you could observe pip install bypy failed because it tried to import module bypy, and bypy imports requests, and BOOM!, an exception poped out.
As the practice of you-get, they created an individual module for the version information, and this module have no dependencies, so it can be safely referred in both the main module and the setup.py script.
I will create a patch following the approach of this kind, when I have some time.

Wow, this is very informative, thanks :+1:

OK, after some readings, I've finally understood the problem with my previous setup.py. It irks me that there seems no "elegant" way (statically) to do this single source version, every recommendation here (https://packaging.python.org/single_source_version/) appears to be a bit hacky one way or another.


refactor(lib): Switch from pin-project to pin-project-lite (again)

Second try, turned out to require a bunch more changes in src/client/conn.rs and src/server/conn.rs due to the ProtoClient and ProtoServer enums which previously had cfg-conditional variants (which aren't supported by pin-project-lite). Now the variants that previously were disabled by cfg(not(feature = "http1")) and cfg(not(feature = "http2")) are instead made to be uninhabited.
The code would be a decent amount simpler if the non-exhaustive variants could be omitted in matches (https://github.com/rust-lang/rust/issues/51085).

Note the practical affects of this PR:

Dependency count with --features full dropped from 65 to 55.
Time to compile after a clean dropped from 48s to 35s (on a pretty underpowered VM).

🎉

Will there be a patch release with this soon?

Yep, just released v0.14.9.


Support JSON response in Plan JSON API

https://www.infracost.io/docs/integrations/infracost_api could be extended to include a format attribute (similar to how the CLI supports it).

This has been merged to master and will go live with the next release.

We just couldn't wait for 9.13 🙂  this  is live now🚢


Register Placeholder model with admin

Documentation checklist

[ ] I have updated CHANGELOG.txt if appropriate
[ ] I have updated the release notes document if appropriate, with:

[ ] general notes
[ ] bug-fixes
[ ] improvements/new features
[ ] backwards-incompatible changes
[ ] required upgrade steps
[ ] names of contributors

[ ] I have updated other documentation
[ ] I have added my name to the AUTHORS file
[ ] This PR's documentation has been approved by Daniele Procida

Coverage remained the same at 78.189% when pulling 058c4864048810dc19f3eb64b28c9a6046fc24d7 on Aiky30:placeholder-admin into 1d789468403f50301e413856a925b15f020a71b1 on divio:release/4.0.x.


Set LiveTestCtestRegex to match CtestRegex in ci.yml across the repo, in a consistent format, following the template project.

Tables' ci.yml was the only one that was inconsistent. All other instances within the repo have the LiveTestCtestRegex value match CtestRegex, so we fixed it in https://github.com/Azure/azure-sdk-for-cpp/pull/6223, for consistency.
That said, some use wild-card (*), while others have it wrapped in quotes (""), while the rest leave it as plain-text:
https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-cpp LiveTestCtestRegex&type=code
We should consider picking a viable format, and apply it consistently, to avoid confusion.
A strawman proposal is to have it be unquoted, without the wild card, matching what we have in our template and core project:
azure-template
azure-core
azure-security-keyvault
azure-storage
Open question:
Would it make a difference to the set of tests that get matched/run if the regex value ended with a period . or not?
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/template/ci.yml#L29
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/keyvault/ci.yml#L30-L31
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/storage/ci.yml#L30-L33

cc @danieljurek in case you have any thoughts on the proposed format we could pick, for consistency

* is a special character in YAML so if used in a string the string should be wrapped in quotes
We use --tests-regex which only requires a match of the name to the regex (not a match of the entire name)

Two things to consider:

You can probably remove the .* from the regexes and not change the tests that run. Which means you can also remove the quotes.
If tests that depend on live services don't require special regexes and filtering you can probably consolidate everything into a single CtestRegex instead of having both CtestRegex and LiveTestCtestRegex .. This means that live tests should be able to run properly in the absence of live services (e.g. playback of recordings) or know when to skip


Fix http://nooooooooooooooo.com/

No sound
AS2 script is using Sound and its attachSound and start functions (see http://help.adobe.com/en_US/AS2LCR/Flash_10.0/help.html?content=00001514.html).

WFM in Shumway 0.10.299.


Rename master -> main

It's time to make the move master -> main.

Please update your forks, if necessary:
git branch -m master <BRANCH>
git fetch origin
git branch -u origin/<BRANCH> <BRANCH>
git remote set-head origin -a

[x] Done
I'll leave this open for another couple of days, just in case someone stumbles over it.

No issues with the switch so far...


No focus when entering a Jupyter Notebook tab

Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur

Open a tab with a .ipynb file with some cells (Python extension must be installed)
move a bit around: pressing j you select the next cell
now move the focus away from the tab and put it back in to the notebook tab, for instance press twice CMD+`  in macOS to show and hide the terminal.
now you would expect to be able to interact with the notebook with the keyboard, for instance pressing k you would expect to select the cell above, but nothing happens
to restore the focus you have to click with the mouse in one cell

Actual behavior
Once going away from a .ipynb tab and going back in the focus is lost and you have to use click with the mouse to restore the focus
Expected behavior
Focus should be on the notebook, as what it happens with any source code tab.

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local | Remote | N/A
Extension version: 2020.4.74986
VS Code version: March 2020 (version 1.44)
Setting python.jediEnabled: false
Python and/or Anaconda version: Python 3.7.6
OS: Mac 10.15.3
Virtual environment: conda

Developer Tools Console Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

If you use to Windows 10 you should try this ⊞ Win + Tab then you could use to → the key to Enter.

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see https://github.com/microsoft/vscode/issues/91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.


Global Settings -> Branding Bugs

If you upload certain image resources they will render outside the preview area. Granted, these assets are larger than 200px wide..

If you upload less common image formats like TIFFs they will not work. We should declare which image types are supported.

Example SVG I have that will render outside the preview area (GitHub forced me to zip it):
BITCOIN_FULL_LOGO_SVG.zip

Verified on v2.7-head Commit ID: c35f112
Large images like the attached bitcoin logo are properly rendered inside the expected preview areas. Smaller images are still working great and images of the accepted types are working as expected.
There is now text present stating: Accepted formats: JPEG, PNG, SVG.


Include 0 as max in elastic axis if all values are negative

See new PR https://github.com/dc-js/dc.js/pull/1156 against original repo.


Inspector not opening editor, spawn code ENOENT

Describe the bug
Whenever I use the inspector and click on something, it doesn't open the editor.
Reproduction URL
https://github.com/probablykasper/svelte-inspector-enoent-bug
Reproduction

Create a SvelteKit app with the default options: npm create svelte@latest my-app
Enable the inspector in svelte.config.js:vitePlugin: {
	experimental: {
		inspector: true,
	},
},

Use the Svelte inspector to click on an element to open it in the editor

Logs
Could not open +page.svelte in the editor.
The editor process exited with an error: spawn code ENOENT.

System Info
System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 235.95 MB / 32.00 GB
    Shell: 3.6.0 - /usr/local/bin/fish
  Binaries:
    Yarn: 3.3.0 - ~/Library/Application Support/Volta/tools/image/yarn/3.3.0/bin/yarn
    npm: 8.19.3 - ~/Library/Application Support/Volta/tools/image/node/18.13.0/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 110.0.5481.177
    Edge: 110.0.1587.63
    Firefox: 109.0.1
    Firefox Developer Edition: 111.0
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.0.0
    @sveltejs/kit: ^1.5.0 => 1.11.0
    svelte: ^3.54.0 => 3.55.1
    vite: ^4.0.0 => 4.1.4

reads like code isn't in your PATH. either add it or use LAUNCH_EDITOR=/path/to/vcsode/bin/code  in env

In vscode you can open the command palette and write install code to add code to path.


Do not list partially-created projects unless necessary

Motivation:
When we access a project, we usually assume that dogma and meta
repositories exist in that project. However, the creation of a project
is a multi-step process:

Create a project
Create the dogma repository
Create the meta repository

Therefore, if another party who attempts to access the project (or its
meta repository) at the same time, he or she may see a partial view of
the project.
Modifications:

Move the creation of dogma and meta repository to DefaultProject
so that a project creation is fully transactional and thus a failed
project creation will roll back the partial changes.

ProjectInitializingCommandExecutor is gone.

Modify StorageManager.create() so that the storage subsystems can
record the creation time and project author correctly.
Miscellaneous:

Replace INTERNAL_REPO and METADATA_REPO with Project.REPO_DOGMA
Prevent API callers from creating meta or dogma repository,
because they must be created by the system when a project is created.

Result:

Nobody can see a partially created project.
Fixes #245

Thanks, reviewers :smile:


[WIP] Add core tagging inventory collection and tests

Horrible, terrible, really bad hack just to start getting tests and collectors working.

@Ladas this is gross but I don't see a way of doing bulk assignment with acts-as-taggable-on so we might have to write our own.


Custom Log Level for Swift

Hi,
I am trying to setup a custom log level. I followed the steps mentioned at Custom Log Level. With those steps, I am able to access the custom log level from Objective C files but not from Swift file. It seems that the swift file take reference from CocoaLumberjack.swift. Can you please point me to some documentation in this regard?
Kind regards,
Kunal

Try searching here.

same question, in obj-c i can do
#undef LOG_LEVEL_DEF
#define LOG_LEVEL_DEF DDLogLevelError

but not sure about swift. would be great to have it added in readme

I added an Obj-C wrapper to access it from Swift files. Please refer DDLogWrapper

@kunalbshah DDLogLevel is an enum and we can't change the enum. Can you please tell me how did you add new DDLogLevel.?


Disable the default workingDir and HOME overrides

Changes
Prior to this commit Steps were given a default HOME env var of "/tekton/home" and a default workingDir of "/workspace". These defaults collide with any value set by the Step's image Dockerfile.
This commit removes the default home and workingDir overrides (except in those few cases where they're still expected, like PipelineResources).
See https://groups.google.com/g/tekton-dev/c/C-PL8VYN51E/m/el5Fca_PDAAJ for our tekton-dev announcement of this change.
See https://github.com/tektoncd/pipeline/issues/1836 for the original problem description and workingDir tracking issue.
See https://github.com/tektoncd/pipeline/issues/2013 for the HOME change tracking issue.
See https://github.com/tektoncd/pipeline/blob/main/docs/deprecations.md for our documented dates for these deprecations.
See https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md#alpha-beta-and-ga
for our beta deprecation policy.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
Steps no longer receive a default HOME env var of "/tekton/home", nor a default workingDir of "/workspace".

action required: if you rely on these defaults you now have a choice to make: either update your Task steps to include the workingDir and HOME env or set the "disable-home-env-overwrite" and "disable-working-directory-overwrite" feature flags to "false". We plan to continue supporting these flags for another 9 months following the release of 0.24 and then they too will be removed.

/kind feature

=== RUN   TestRealRunnerTimeout
    runner_test.go:37: step didn't timeout
--- FAIL: TestRealRunnerTimeout (0.04s)

This doesn't reproduce for me locally. Retrying.
/test tekton-pipeline-unit-tests

This PR should be up to date now with the latest enable-api-fields flag.

/test pull-tekton-pipeline-build-tests


NLog EcsLayout - Write directly to StringBuilder instead of string allocation

Also recycles the same Utf8JsonWriter when possible (It is intended to be reused see also Utf8JsonWriter.Reset)

:broken_heart: Build Failed

Expand to view the summary

Build stats

Build Cause: [Pull request #75 opened]

Start Time: 2020-05-08T20:32:33.261+0000

Duration: 4 min 17 sec (256957)

Commit: 21ea76cfc3a8606ec1d79592f62e70be3d1e5ed4

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Result: FAILURE

Duration: 0 min 0 sec

Start Time: 2020-05-08T20:36:47.776+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-05-08T20:36:42.210Z] Fetching upstream changes from git@github.com:elastic/ecs-dotnet.git
[2020-05-08T20:36:42.211Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-08T20:36:42.215Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-dotnet.git +refs/pull/75/head:refs/remotes/origin/PR-75 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-05-08T20:36:42.806Z]  > git config core.sparsecheckout # timeout=10
[2020-05-08T20:36:42.810Z]  > git checkout -f 21ea76cfc3a8606ec1d79592f62e70be3d1e5ed4 # timeout=15
[2020-05-08T20:36:42.860Z]  > git remote # timeout=10
[2020-05-08T20:36:42.864Z]  > git config --get remote.origin.url # timeout=10
[2020-05-08T20:36:42.867Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-05-08T20:36:42.870Z]  > git merge a5bf899ee42361553962d89f20378d6b8b9f679c # timeout=10
[2020-05-08T20:36:43.003Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-05-08T20:36:43.017Z]  > git config core.sparsecheckout # timeout=10
[2020-05-08T20:36:43.025Z]  > git checkout -f 7dbfc49fb268c457ec6dc14cffd74f43547f7ea5 # timeout=15
[2020-05-08T20:36:43.136Z]  > git rev-parse --verify HEAD # timeout=10
[2020-05-08T20:36:43.140Z] Resetting working tree
[2020-05-08T20:36:43.140Z]  > git reset --hard # timeout=10
[2020-05-08T20:36:43.147Z]  > git clean -fdx # timeout=10
[2020-05-08T20:36:43.926Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-05-08T20:36:44.593Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-05-08T20:36:45.173Z] From https://github.com/elastic/ecs-dotnet
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/1/head  -> origin/pr/1
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/10/head -> origin/pr/10
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/11/head -> origin/pr/11
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/12/head -> origin/pr/12
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/14/head -> origin/pr/14
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/15/head -> origin/pr/15
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/16/head -> origin/pr/16
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/19/head -> origin/pr/19
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/2/head  -> origin/pr/2
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/22/head -> origin/pr/22
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/23/head -> origin/pr/23
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/24/head -> origin/pr/24
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/25/head -> origin/pr/25
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/26/head -> origin/pr/26
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/27/head -> origin/pr/27
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/28/head -> origin/pr/28
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/33/head -> origin/pr/33
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/34/head -> origin/pr/34
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/35/head -> origin/pr/35
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/36/head -> origin/pr/36
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/37/head -> origin/pr/37
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/38/head -> origin/pr/38
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/39/head -> origin/pr/39
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/4/head  -> origin/pr/4
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/40/head -> origin/pr/40
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/43/head -> origin/pr/43
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/44/head -> origin/pr/44
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/45/head -> origin/pr/45
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/47/head -> origin/pr/47
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/48/head -> origin/pr/48
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/49/head -> origin/pr/49
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/5/head  -> origin/pr/5
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/50/head -> origin/pr/50
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/51/head -> origin/pr/51
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/52/head -> origin/pr/52
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/53/head -> origin/pr/53
[2020-05-08T20:36:45.173Z]  * [new ref]         refs/pull/57/head -> origin/pr/57
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/59/head -> origin/pr/59
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/6/head  -> origin/pr/6
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/60/head -> origin/pr/60
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/63/head -> origin/pr/63
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/65/head -> origin/pr/65
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/66/head -> origin/pr/66
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/67/head -> origin/pr/67
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/69/head -> origin/pr/69
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/7/head  -> origin/pr/7
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/70/head -> origin/pr/70
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/74/head -> origin/pr/74
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/75/head -> origin/pr/75
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/8/head  -> origin/pr/8
[2020-05-08T20:36:45.174Z]  * [new ref]         refs/pull/9/head  -> origin/pr/9
[2020-05-08T20:36:45.174Z]  * [new tag]         1.2.0-alpha1      -> 1.2.0-alpha1
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.0             -> 1.4.0
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.0-beta1       -> 1.4.0-beta1
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.1             -> 1.4.1
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.2             -> 1.4.2
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.3             -> 1.4.3
[2020-05-08T20:36:45.174Z]  * [new tag]         1.4.4             -> 1.4.4
[2020-05-08T20:36:45.174Z]  * [new tag]         1.5.0             -> 1.5.0
[2020-05-08T20:36:45.692Z] + git rev-parse HEAD
[2020-05-08T20:36:46.066Z] + git rev-parse HEAD
[2020-05-08T20:36:46.386Z] + git rev-parse origin/pr/75
[2020-05-08T20:36:46.434Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-05-08T20:36:46.632Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-08T20:36:47.455Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-dotnet/pulls/75/reviews return 0 elements
[2020-05-08T20:36:47.508Z] [INFO] githubPrCheckApproved: Title: NLog EcsLayout - Write directly to StringBuilder instead of string allocation - User: snakefoot - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-05-08T20:36:48.808Z] Stage "Sanity checks" skipped due to earlier failure(s)
[2020-05-08T20:36:48.886Z] Stage "Parallel" skipped due to earlier failure(s)
[2020-05-08T20:36:48.979Z] Stage "Linux" skipped due to earlier failure(s)
[2020-05-08T20:36:48.994Z] Stage "Windows" skipped due to earlier failure(s)
[2020-05-08T20:36:49.038Z] Failed in branch Linux
[2020-05-08T20:36:49.077Z] Stage "Windows" skipped due to earlier failure(s)
[2020-05-08T20:36:49.152Z] Stage "Windows" skipped due to earlier failure(s)
[2020-05-08T20:36:49.246Z] Failed in branch Windows
[2020-05-08T20:36:49.525Z] Running on Jenkins in /var/lib/jenkins/workspace/gent-dotnet_ecs-dotnet-mbp_PR-75
[2020-05-08T20:36:49.653Z] [INFO] getVaultSecret: Getting secrets
[2020-05-08T20:36:49.714Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-08T20:36:50.488Z] + chmod 755 generate-build-data.sh
[2020-05-08T20:36:50.489Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-75/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-75/runs/1 FAILURE 256957
[2020-05-08T20:36:50.739Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-75/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-08T20:36:51.290Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/ecs-dotnet-mbp/PR-75/runs/1/tests/?status=FAILED -o tests-errors.json

Jenkins run the tests please

Awesome work @snakefoot !
Not sure if Reuse's existence mandates its intended to be used.
Interesting discussion around adding it in the Serializer helpers in dotnet/corefx:
https://github.com/dotnet/corefx/pull/37533#discussion_r284940413
It was voted not to move ahead with this.
Mind reworking this in two PR's? The StringBuilder reuse is gold, I would feel more comfortable pulling this in as a two separate pull requests:

One newing all the time but writing to stringbuilder directly.
One building upon this adding the reuse of the json writer.

This would allow us benchmark each improvement and weigh the benefits vs code complexity.
Let me know if you are up for this or not, we've not been the most responsive the past two weeks 🙈

Not sure I understand the goal of splitting this in two PRs.

One newing all the time but writing to stringbuilder directly.

So skip reusing the Utf8JsonWriter, but only reuse the MemoryStream-object and char[]-buffer ?
Reason why I decided to also reuse the Utf8JsonWriter AND MemoryStream is because they welded together by Microsoft. So when reusing, then one is reusing both. Trying to break them apart is going generate more code.

Resolved merge conflicts.

These numbers 😍

Method
Mean
Error
StdDev
Completed Work Items
Lock Contentions
Gen 0
Gen 1
Gen 2
Allocated

Empty
1.116 μs
0.0096 μs
0.0090 μs
0.0000
-
0.1125
-
-
712 B

Minimal
1.805 μs
0.0164 μs
0.0137 μs
0.0000
-
0.1469
-
-
928 B

Complex
4.872 μs
0.0220 μs
0.0184 μs
0.0000
-
0.3357
-
-
2152 B

Full
480.486 μs
32.3246 μs
92.2240 μs
-
-
-
-
-
41472 B

Spoke to soon those benchmark tests don't run through the new bits yet

Closing this in favor of: #82
Again thanks a million for your work on this @snakefoot this will benefit the NLog integration tremendously!


Multiple Bindings?

Sorry to open an issue for this, but how does one specify multiple bindings using this extension?

Hi @issafram
Currently we do not support adding multiple bindings from the task. To add multiple bindings you try one of the following:

Since our task adds the binding that you specify in the task, you can add the bindings one-by-one-triggering a separate release for each binding.

You can also manually add the bindings in you IIS website from IIS Manager once. The IIS task will not delete the already existing bindings.

You can add the following command in the "Advanced->Additional AppCmd.exe Commands" option in the task:
set site /site.name:"<your_website_name>" -applicationDefaults.applicationPool:"<your_application_pool_name>" -[path='/'].[path='/'].physicalPath:"<physical_path_of_the_website>" /bindings:"http/:8085:","https/:443:","http/<IP_ADDRESS>:8081:"

Note: In solution 3, you specify your bindings as a comma separated list like this "/::","/::"
Warning: the last solution sets the bindings to what has been specified and removes any old bindings for the website.

Since our task adds the binding that you specify in the task, you can add the bindings one-by-one-triggering a separate release for each binding.

Can I just add multiple tasks to the same release?  Like can I have one task per binding?
Also, option 3 seems very attractive.  But it might need some complicated variables to work.  I don't want to input my website name in multiple locations.  The comma seperated list of bindings should be an option in the plugin (IMO), so that it generates the AppCmd.exe command dynamically.
What are your thoughts?

Yes, multiple tasks in single release should work as well.
You can define a variable in your release definition and use it everywhere in the task. For example you can add a variable "websiteName" with value "myWebsiteName". Then you can use that variable in the task-just use $(websiteName) instead of "myWebsiteName".
There are no current plans to add an option for multiple bindings in the task right now but we might consider adding it in the future.

Please reopen this issue if you have further queries regarding this.


Add option to specify path to V executable

Resolves #79.

Tested on both Windows and Linux.
If the V path is not specified, the extension behaves like before: it tries to execute "v" command. If it's in PATH, or in a workspace directory it will be executed.
Note that now ALL commands use a workspace directory as CWD. This fixes a bug, where a user was unable to get V version via the respective command, even if a workspace with V project is opened and it contains v executable.


Query Tracker UI shows "unsupported data type" for dynamic table system columns like $timestamp and $cumulative_data_weight

How to reproduce:
$ yt create table //home/max42/test_queue --attributes '{dynamic=%true; schema=[{name="$timestamp"; type=uint64}; {name="$cumulative_data_weight"; type=int64}; {name=a;type=string}]}'
$ echo '{a=blahblah}' | insert-rows //home/max42/test_queue --format yson

Then query (using YQL syntax):
select * from `//home/max42/test_queue`

And the result will look like

The issue is related to web_json format; it ignores all system columns by default, unless they are explicitly requested in "columns" attribute of the format. Looks like UI should explicitly list all requested columns, taking them from "get_query_result" API call beforehand.

I just understood that this issue belongs to the UI repository, closing this one.


Added support for setting the nofile ulimit in the upstart configurat…

…ion.

Testing evidence: https://gist.github.com/bjtieman/36cba9ac508048b5360e927c549dc75b
I wasn't able to get the ubuntu box to start up on my machine so the testing evidence only contains a test run for centos :(

+1

+1 after process limit is set in the upstart config as well

+1

Responded to comments and rebased.

+1

+1

Have enough +1s, merging


Alignment Issue on Design 2

In Design 2, with the same settings, the first and second line of LT1 is not at the same height as on the other LTs. For demonstration I put it both on left side. But it is the same on Left/Right or any other orientation.
LT2, LT3 and LT4 are perfectly aligned.
Design 1 and 3 are also fine.
Version 1.6 (latest)

{"alt-2-style-color-2":"rgba(59,59,59,0)","alt-1-inverse-ratio":"8","alt-3-border-thickness":"false","lower-thirds-switch2":"true","alt-4-inverse-ratio":"8","alt-4-autoload":"false","alt-1-style":"2","alt-1-logo-default":"../logos/logo_1.png","alt-4-style-color-1":"rgba(213,65,65,0)","alt-2-align-left":"true","alt-1-preview":"false","alt-4-margin-h":"22","alt-1-style-color-1":"#E76000","alt-1-logo-2":"","alt-1-margin-v":"1","alt-3-margin-v":"1","alt-1-info-weight":"false","alt-3-style-color-1":"rgba(213,65,65,0)","set-tooltips":"false","alt-2-logo-preview":"../logos/logo_2.png","alt-1-shadow-amount":"5","alt-1-border-color":"false","alt-4-name-color":"#F2F2F2","alt-3-logo":"false","alt-2-align-right":"false","global-animation-time":"","alt-1-info-transform":"false","alt-2-logo":"false","alt-1-margin-h":"22","alt-1-lock-active":"true","alt-1-name-1":"","alt-1-active-time":"","alt-3-lock-active":"true","alt-1-logo-1":"","alt-1-inactive-time":"","alt-4-logo-preview":"../logos/logo_4.png","alt-4-style":"2","set-preview":"false","alt-1-name":"John Doe","alt-2-autotrigger":"false","alt-3-margin-h":"22","alt-1-style-color-3":"#E76000","alt-3-info":"","alt-3-name":"","alt-2-line-spacing":"1","alt-1-align-right":"false","alt-1-font":"'Open Sans', sans-serif","global-active-time":"15","alt-1-name-weight":"true","alt-2-info-color":"#F2F2F2","alt-1-logo-preview":"../logos/logo_1.png","set-slot-numbers":"false","alt-3-border-color":"false","lower-thirds-masterswitch":"true","alt-4-line-spacing":"1","alt-2-style-color-3":"#E76000","alt-3-info-color":"#F2F2F2","alt-3-logo-preview":"../logos/logo_1.png","lower-thirds-switch1":"true","alt-2-inverse-ratio":"8","alt-1-corners":"0","alt-1-logo":"false","alt-2-name-color":"#14CC1F","alt-1-border-thickness":"false","alt-2-shadows":"false","alt-1-logo-size":"-2","global-lock-active":"false","alt-4-info":"","alt-1-info-2":"","alt-1-shadows":"false","alt-1-name-2":"","alt-4-logo-9":"","alt-2-style-color-1":"#6300E7","alt-2-logo-size":"-2","alt-3-name-color":"#F2F2F2","alt-1-info":"Professional Services Consultant","alt-1-line-spacing":"1","alt-3-line-spacing":"1","alt-4-lock-active":"true","alt-2-info":"Professional Services Consultant","alt-2-name":"John Doe","alt-1-style-color-2":"rgba(59,59,59,0)","alt-4-margin-v":"1","alt-4-name":"","alt-3-inverse-ratio":"8","alt-1-background":"true","alt-1-name-transform":"true","alt-1-info-1":"","alt-4-logo-default":"../logos/logo_4.png","lower-thirds-switch3":"false","alt-1-oneshot":"true","alt-2-lock-active":"true","alt-3-logo-default":"../logos/logo_3.png","alt-3-style":"2","alt-2-logo-default":"../logos/logo_2.png","lower-thirds-switch4":"false","theme":"dark","alt-4-info-9":"","alt-2-font":"'Open Sans', sans-serif","alt-1-align-center":"false","alt-1-animation-time":"","alt-2-background":"true","alt-4-logo":"false","alt-2-name-transform":"true","sorted":"alt[]=1&alt[]=2&alt[]=3&alt[]=4","alt-4-info-color":"#F2F2F2","set-switch-position":"false","alt-1-align-left":"true","alt-2-margin-h":"22","alt-4-style-color-3":"rgba(213,65,65,0)","alt-3-style-color-3":"rgba(213,65,65,0)","alt-2-align-center":"false","alt-2-corners":"0","alt-1-autotrigger":"false","alt-4-name-9":"","alt-2-style":"2","alt-1-size":"24","alt-1-info-color":"#F2F2F2","alt-2-margin-v":"1"}

Thanks for your detailed comment. We will check and give you an answer as soon as possible.

Thanks for your detailed comment. We will check and give you an answer as soon as possible.

Actually, the LT1 is the correct one. The change in height is due to an adjustment in the shadow mask. I will replicate it in the other LTs. Thanks for notifying us! ;)

Hahaha, I never thought that the minority of elements could be the right. Thank you! :)


Checkstyle report: unused imports for JavaDoc only imports

Checkstyle reports import unused, when it is only used in JavaDoc class ref.
We should enable javadoc proccess.
Also consider using: https://github.com/nikitasavinov/checkstyle-action#checkstyle-github-action

Fixed in #313

Fixed in #313


Preserve height of ChatInputItem if keyboard item was previously opened.

[Current coverage][cc-pull] is 64.31%

Merging [#170][cc-pull] into [dev][cc-base-branch] will decrease coverage by 0.43%

@@                dev       #170   diff @@
==========================================
  Files            63         63
  Lines          3362       3391    +29
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2177       2181     +4
- Misses         1185       1210    +25
  Partials          0          0

Powered by Codecov. Last updated by [61fe370...a4d823c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/badoo/Chatto/branch/dev?src=pr
[cc-compare]: https://codecov.io/gh/badoo/Chatto/compare/61fe370e8666f3f1274cb75615ddc5e128ce05e7...a4d823c4d7ea56f3b3e1b3e77accbc483da75e20
[cc-pull]: https://codecov.io/gh/badoo/Chatto/pull/170?src=pr


Swipe to delete functionality for videos

Description
LEARNER-1289
Swipe to delete video functionality
How to test this PR

Go in Video Section
Download all videos
Swipe the row from right to left, the delete button will appear.
On Sub-section level delete action will delete all video components in subsection
On Unit level delete action will delete just one video component in unit.
Swipe to delete option will be enable when all videos are downloaded or the downloaded icon is check sign.

Codecov Report

Merging #961 into master will decrease coverage by 0.44%.
The diff coverage is 15.93%.

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage    45.7%   45.25%   -0.45%
==========================================
  Files         402      410       +8
  Lines       26388    26896     +508
==========================================
+ Hits        12061    12173     +112
- Misses      14327    14723     +396

Impacted Files
Coverage Δ

...rce/LibSource/SwipeAccessibilityCustomAction.swift
0% <0%> (ø)

Source/CourseVideoTableViewCell.swift
42.85% <0%> (-14.84%)
:arrow_down:

Source/OEXMyVideosSubSectionViewController.m
0% <0%> (ø)
:arrow_up:

Source/LibSource/SwipeActionButton.swift
0% <0%> (ø)

Source/LibSource/SwipeAnimator.swift
0% <0%> (ø)

Source/OEXMyVideosViewController.m
0% <0%> (ø)
:arrow_up:

Source/LibSource/SwipeCellViewOptions.swift
0% <0%> (ø)

Source/LibSource/SwipeCellViewDelegate.swift
0% <0%> (ø)

Source/LibSource/SwipeCellActionView.swift
1.44% <1.44%> (ø)

Source/OEXInterface.m
26.59% <100%> (+0.57%)
:arrow_up:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440220f...a6e9319. Read the comment docs.

@saeedbashir Please take a loot at PR. Thanks

@salman2013 Swipe cell behaviour is not consistent. Sometimes after swipe, on clicking row hides delete action and sometimes row gets selected on both section and unit level.
I also encounter a scenario in which on refreshing course content is deleting downloaded videos.

@saeedbashir the PR is ready for second pass. Please take a look into it. Thanks

@saeedbashir I have fixed the comments so please take a look into it. Thanks

"There is 0.36% decrease in coverage. @salman2013 Can we somehow improve this?
Show outdated"

I wrote the all scenario test cases which can be in swipe to delete functionality.

@saeedbashir PR is ready for another pass. Thanks

@salman2013 Can you configure SwipeableCell in such a way that, if someone set's a specific state of cell then delete button appear automatically and stays there. It will help us in deleting videos from multiple rows.

@saeedbashir I have remove the hard coded string. PR is ready for another pass. Thanks

@salman2013 Few comments from last pass still needs to be addressed.


Update citra.json

Closes #XXXX

Relates to #XXXX

[ ] I have read the Contributing Guide.

There's already an open PR that also fixes citra-canary, but it needs a rebase: https://github.com/Calinou/scoop-games/pull/1024
I suggest applying the change to citra-canary so that this PR can be merged right away.

Closing, as Citra is no longer available from its original source. See https://github.com/Calinou/scoop-games/pull/1158.


Update cloudknox-howto-view-role-policy.md

Updates to make the doc consistent to the current UX.

@marcelodiiorio : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Annoit for Sanctuary doesn't work

Annoit works fine for say Diamond Skin, but my annoited amulet with Sanctuary doesn't register, the resistances are wrong.
See https://pastebin.com/6WAGxsDg

It's allocating the "Sanctuary" that is an Inquisitor ascendancy node instead of the normal one.


Add string type

This issue has been reflected in v0.6.
https://github.com/shapoco/calctus/releases/tag/v0.6.8857.6956-beta


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2932

Questions ?
Please refer to the Backport tool documentation


DRAFT: ChArUco coordinate definition

For review together with @Rampex1 , particularly around our conventions for y- and z-axes
Please do not merge until AFTER #89.

I went over the PR. Looking at the data/controller_calibration_config.json here is my understanding of the coordinate system for the "targets": the ChArUco board is in portrait mode (height > width) with marker 0 at the top-left corner. Positive x goes from left to right, positive y goes from bottom to the top and positive z goes out the board. Also, the origin seems to be in the middle of the board. This coordinate system is the same as how I defined it previously (except for the origin which I put at the bottom left), so I think there should be no issue. The rest of the PR looks good to me.

Closed via 0bd218fd4c72844fc7dc487c28668ebbe46e3310 and 03e9adf0311a71918619886694ff189f744568a2


How to pickle an Ptxt?

Hello, I got some error when pickling ptxt. This is the error:
Traceback (most recent call last):
  File "E:\NCKU\ICLab\code\Pyfhel-master\examples\Demo_4_SaveNRestore.py", line 172, in <module>
    pkls_ptxt = pickle.dumps(p)
  File "<stringsource>", line 2, in Pyfhel.PyPtxt.PyPtxt.__reduce_cython__
TypeError: no default __reduce__ due to non-trivial __cinit__

I'd like to encode the deep learning model's weights, then I can perform operations between the encrypted image and the encoded weights. However, when I attempt to encode the weights, a MemoryError might occur (I guess, because the code will stop without raising an error.) Therefore, I intend to pickle the encoded weights (Ptxt) to avoid overloading the RAM. Pickling ctxt doing well in #81, but pickling ptxt gets error.
Do you have any advice?

@Shakemilktea The encoding operation is light-weight compared to the homomorphic operations. That being said, you could:

Pickle the weights as numpy objects.

Forl Pyfhel, implement the necessary pickling mechanism for PyPtxt and merge it on the main repo. This seems quite easy:

Create a __reduce__ method in PyPtxt.pyx that does exactly what PyCtxt.__reduce__ does
Test it and add some example of its use in an examples file.

I'd be happy to provide further assistance if you decide to implement it.

Thanks for your advice! It looks good when multiplying Numpy and Ctxt!
Regarding the pickling of Ptxt, I haven't had experience with Cython before, so I need to study it first.

Solved then!


架构: concepts/authorization-arch.md

This article is waiting to be claimed. concepts/authorization-arch.md

目录调整，该章节合并，详情见 #251


Add support for DynamoDb.

Feature Description
Are you planning to add DynamoDb support, or it's already there ?
Describe the solution you'd like
https://github.com/guregu/dynamo
Describe alternatives you've considered

Additional context

Hi @manojown
DynamoDb support is not there yet,
Soon will be adding 👍
Feel free to contribute if you have some bandwidth 👍

If this has not already been picked, I would want to contribute.

Hi @manojown sure feel free to pick
Happy to help you if you need to know how to get started with new db provider

Thanks @lakhansamani , I'll go through the code and let you know in case of query.

You can duplicate this folder and rename new folder to dynamodb
server/db/providers/provider_template
Then you have to fill out all the methods that are part of it

Hey @lakhansamani , I was testing the code and it seems https://62cbc6738042b16aa7c22df2.mockapi.io/api/v1/webhook this api reached the max limit. 😄

@manojown I have reset the api,
Though you can always disable it by setting env to test
https://github.com/authorizerdev/authorizer/blob/587828b59b5fdcdc3558174fa82eb1adbcc6971f/server/utils/webhook.go#L57

Hi @lakhansamani , Hope you doing well,
I have a question about pagination. In the current graphql schema, it appears to be limited to offset and limit, however in certain databases, it works with a cursor.
As I'm new to ghraphql, I just needed to ensure that:
changing the schema.graphqls file for Pagination and paginationInput after that running gql genrator would work, or is there anything else I'm missing?

@manojown yes the procedure is correct. However it would be good to keep that abstraction of offset and limit at API level and run cursor till that limit on backend.
Also there is some error with latest go versions in gqlgen that I need to fix. So let me know if that doesnt work on your machine I can generate schema for you.

@lakhansamani thanks for quick reply.
Yes, kindly assist me in generating the schema. Despite my efforts, I consistently receive exit status 1 (gql generate) even when using the   --verbose mode.

Sure will share new schema with that change

@manojown I have added changes here:
https://github.com/authorizerdev/authorizer/tree/feat/dyanmo-db-cursor
Though I am not very happy with this approach it would be good if we can abstract this for APIs and manage cursor at provider level. Reason for this is that lot of apis in frontend can break in dashboard.

Yes, you are correct. I was thinking along the similar lines because we need to control the forward and backward cursor on the front end (not compatible) . What are your thoughts on the alternative method of looping through the data till the offset is not reached?
Note- However this is not good for huge data because every time we need to loop till the offset.

@manojown if we change api to support cursor, we will have to add support for same in all dbs
That could result in to the breaking change.
I know this will be performance issue while dealing with large data but as initial version of dynamo db support lets go with looping & skipping till the offset on server side.
Also these paginations are admin only features used on dashboard so we can optimize them later.
But lets make sure we create issue for that once we release support for dynamodb.
Also yes while adding search and other features we can optimize this with cursor and that will open doors for other dbs as well.
WDYT?


Add CUDA requirements file

This PR introduces a new file requirements-cuda.txt which contains all of the dependencies that cannot install unless CUDA is available.
Presently, the only package this contains is instructlab-training which has a dependency on flash-attn.
To make use of this, you can install the ilab CLI by doing pip install instructlab[cuda].
Signed-off-by: Oleg S<EMAIL_ADDRESS>

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[x] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

PTAL @tiran would appreciate your guidance on how we should be aligning dependencies between synchronized repos like instructlab and training. My assumption is that since we coordinate both repos directly including like in this PR is the best practice, but might be missing an important factor.

Optional dependencies are currently the best option to define different requirements for GPU platforms. There is an ongoing discussion in the packaging community about environment markers for GPUs. This will enable requirements like somepackage; sys_platform == 'linux' and sys_gpu == 'cuda'. The proposal is in an early discussion phase and not ready any time soon.
The change looks good to me. I only have one suggestion. Right now we target five flavors:

cpu
cuda
hpu (Intel Gaudi)
rocm (AMD ROCm, but --device=cuda)
mps (Apple Metal Performance Shader)

instructlab[hpu] already exists. From a UX perspective, it would be a good idea to make the installation instructions consistent by adding optional requirements for cpu, rocm, and mps. The requirements files for the other flavors can be empty.

I have created https://github.com/instructlab/instructlab/pull/1753 to implement my suggestions and to follow up on some other minor problems. For example I have updated e2e tests to use the optional dependencies.

Sounds good, I will remove Nathan as a requested review as he is on PTO today.

thank you @RobotSail and @tiran !

@RobotSail @n1hility I approved the PR under the assumption that my follow-up PR #1753 was going to be reviewed and approved the same day or the day after. It's now over 5 days. Could you please take a look?

Ah sorry, the PR was not merged because I asked Russel to review and he hasn't had time to review. I forgot that a pending review blocks auto-merge.


Assing the same flavor to codependent resources

What type of PR is this?
/kind bug
What this PR does / why we need it:
When adding a ClusterQueue to the cache, identify the resources that share the same list of flavors, which we call codependent.
When admitting, iterate through flavors, checking that all the codependent resources have enough quota for the flavor.
Which issue(s) this PR fixes:
Fixes #167
Special notes for your reviewer:
We need to add validation to the ClusterQueue to make sure that "two resources can either have completely different flavors or they must share all flavors, in the same order"

Oops, wrong link. It should have been #167, but it's still WIP.

@kerthcet this is ready for review :D

/lgtm
/hold
hold just in case you are expecting more discussion on the PR, feel free to remove it.

/hold cancel


Type mismatches in inferred React defaultProps do not produce an error

@calebmer's recent blog post about better React support included an example with defaultProps. Taking that example and introducing mismatched types should produce an error, but does not.
Observed behavior
import * as React from 'react';

type Props = {
  foo: number, // This is a number
};

class MyComponent extends React.Component<Props> {
  static defaultProps = {
    foo: '42', // This is not a number and should produce an error
  };
}

> flow
No errors!

Expected behavior
Cannot extend Component [1] with MyComponent because string [2] is incompatible with number [3] in static property defaultProps.foo.

You have to use the component without a prop, so it uses the default prop to get an error...

This probably can be closed.
/cc @vkurchatkin

From a developer perspective, it'd be nice for Flow to show the correct error without having to use the component, just as it does for state.

We now require annotation on this, and the issue is likely fixed a long ago


Add Helm 2 support

Helm v2 does not currently work. This issue tracks adding the backwards compatibility

At this point in time, there's probably never gonna be a need to support Helm 2.


Deposit report is not opening

Describe the bug
I am facing difficulty in running the deposit report. I created a deposit and run the deposit report, but it throws an error.
To Reproduce
Steps and to reproduce the behavior:

Search for the deposit report, it will throw an error.

AL Code to reproduce the issue
Expected behavior
The report should open perfectly.
Screenshots
If applicable, add screenshots to help explain your problem.

5. Versions:

AL Language: 5.0.191295

Business Central:<IP_ADDRESS>

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


feat: Add Number Insight v2

Implements NI v2 spec.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@80ab245). Click here to learn what that means.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage        ?   94.26%
  Complexity      ?     2892
=======================================
  Files           ?      426
  Lines           ?     6919
  Branches        ?      449
=======================================
  Hits            ?     6522
  Misses          ?      204
  Partials        ?      193

Files
Coverage Δ

src/main/java/com/vonage/client/VonageClient.java
98.91% <100.00%> (ø)

...onage/client/numberinsight2/FraudCheckRequest.java
100.00% <100.00%> (ø)

...nage/client/numberinsight2/FraudCheckResponse.java
100.00% <100.00%> (ø)

...a/com/vonage/client/numberinsight2/FraudScore.java
100.00% <100.00%> (ø)

...vonage/client/numberinsight2/FraudScoreStatus.java
100.00% <100.00%> (ø)

...java/com/vonage/client/numberinsight2/Insight.java
100.00% <100.00%> (ø)

...ge/client/numberinsight2/NumberInsight2Client.java
100.00% <100.00%> (ø)

...umberinsight2/NumberInsight2ResponseException.java
100.00% <100.00%> (ø)

...n/java/com/vonage/client/numberinsight2/Phone.java
100.00% <100.00%> (ø)

...va/com/vonage/client/numberinsight2/PhoneType.java
100.00% <100.00%> (ø)

... and 4 more


Is the Global Reach Add-on Required on both ExpressRoute circuits?

Do I pay once and it covers both circuits or do I have to pay for the add-on for each circuit?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c2e5cb1-6388-4944-b2bb-c98152c5fe65
Version Independent ID: 841a4807-a4b3-4d4d-31e8-a25c540f3bfc
Content: Azure ExpressRoute Global Reach
Content Source: articles/expressroute/expressroute-global-reach.md
Service: expressroute
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thanks for the question! We are currently investigating and will update you shortly.

@rcarrara99 The Global Reach Add-On enables the global reach feature on each ExpressRoute Circuit.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Sorry, to be persistent but you’re answer is still vague. Do you have to purchase the add-on for each circuit, meaning I have to pay for it twice to interconnect two locations or do I only have to pay for it on one circuit and then I can connect to any second location?
Thanks,
Richard
From: TravisCragg-MSFT<EMAIL_ADDRESS>Reply-To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Date: Wednesday, October 3, 2018 at 2:49 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Richard Carrara<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [MicrosoftDocs/azure-docs] Is the Global Reach Add-on Required on both ExpressRoute circuits? (#16051)
@rcarrara99https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rcarrara99&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=Mtk74D6-8z-yMIZb7k5Ma8AQ9rj885G3vg1Yb2OzZsA&s=_hKR8d4T4ZCsdNg5nknfaTzyaMBs2XVGHQBz0QJ1RJ8&e= The Global Reach Add-On enables the global reach featurehttps://urldefense.proofpoint.com/v2/url?u=https-3A__azure.microsoft.com_en-2Dus_pricing_details_expressroute_&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=Mtk74D6-8z-yMIZb7k5Ma8AQ9rj885G3vg1Yb2OzZsA&s=AMv0zoYr8nMfzX5CGHlmVmXV94Vk-HQnWytT93lini0&e= on each ExpressRoute Circuit.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_azure-2Ddocs_issues_16051-23issuecomment-2D426775638&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=Mtk74D6-8z-yMIZb7k5Ma8AQ9rj885G3vg1Yb2OzZsA&s=w2qNJGHavP5ZSXBygoU-dgG4F8hMW4ZwYPcC2cpr-9M&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ApvKcJd687drERJMckZyKKNLv09vdAsHks5uhRTggaJpZM4XE89g&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=Mtk74D6-8z-yMIZb7k5Ma8AQ9rj885G3vg1Yb2OzZsA&s=fLkAsnTxRs9-yoVM_wzpsZSq2-t1XF-T_1Hje5qushE&e=.

@rcarrara99 no need to apologize, I am happy to clarify! The Global Reach Add-On is placed between 2 ExpressRoutes, allowing communications between different on-prem environments. When you enable the Global Reach Add On for 2 ExpressRoutes, you pay once, but both ExpressRoutes gain the ability to communicate.
You will choose 2 existing ExpressRoutes, and pay once for each to use the Global Reach Add-On.

Perfect! Thank you!
Richard Carrara
Principal Solutions Architect - CCIE #7288 / CISSP
EQUINIX | 1950 N Stemmons Fwy
Dallas, TX 75207
E rcarrara<EMAIL_ADDRESS>| M +1<PHONE_NUMBER>
[/Users/rcarrara/Library/Containers/com.microsoft.Outlook/Data/Library/Caches/Signatures/signature_1676157889]http://www.equinix.com/
A New Global Baseline for the Digital Economy
See the Equinix Global Interconnection Index here: http://eqix.it/2w7N7fb
From: TravisCragg-MSFT<EMAIL_ADDRESS>Reply-To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Date: Wednesday, October 3, 2018 at 3:15 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Richard Carrara<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [MicrosoftDocs/azure-docs] Is the Global Reach Add-on Required on both ExpressRoute circuits? (#16051)
@rcarrara99https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rcarrara99&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=_5IB-St-L2wWIYfvmch62rg13hZz2icMsx7ecHWnKJU&s=PHlP3maDglDqZWTdI3rbmGalsWTx_KxwirRkRoQsNgg&e= no need to apologize, I am happy to clarify! The Global Reach Add-On is placed between 2 ExpressRoutes, allowing communications between different on-prem environments. When you enable the Global Reach Add On for 2 ExpressRoutes, you pay once, but both ExpressRoutes gain the ability to communicate.
You will choose 2 existing ExpressRoutes, and pay once for each to use the Global Reach Add-On.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_MicrosoftDocs_azure-2Ddocs_issues_16051-23issuecomment-2D426784937&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=_5IB-St-L2wWIYfvmch62rg13hZz2icMsx7ecHWnKJU&s=NDj7wIzw05s0PrrRIPSvwDM8IIdIkQ6tOITiqAs-ZDs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ApvKcN-2DHArmE0XW4Yf-5Fr91aVpQCSbdeDks5uhRrUgaJpZM4XE89g&d=DwMFaQ&c=gxW9PgscCAGwFImBgfkGkoANogu61GVPNv0sglxAtik&r=QkbwlBSezDfqbK2VEGPSNW882h0uDMZXFXUZ6cPvyjI&m=_5IB-St-L2wWIYfvmch62rg13hZz2icMsx7ecHWnKJU&s=NXakgYH1vpg_dhQr_7BuRnGYNLmJgOYJxmeVwOIn2jQ&e=.


Correct Opkherab's statblock to appropriate level/stats

It's stats are incorrect for the level/statblock
https://www.reddit.com/r/Pathfinder2e/comments/xha6an/a_warning_for_anyone_running_blood_lords_in

This was already fixed


Bump CBMC to 6.4

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@potsrevennil Can you do this?


how to add pages?

i've been trying to add pages to the example instance following the given structure:
/_i18n/de/about/about.md
seems like i got it wrong.. any hints?

having the same issue here. I've tried moving it around to different places and adding the info to the language.yml file under pages, but no go.

Ah. Figured it out. You must create a normal page at the root (in this case an about page) with the header and with this in the content:
---
layout: page
title: About
permalink: /about/
---

{% translate_file about/about.md %}

Then inside each of the language folders you just have markdown with the correct language. Make sure to erase the headers from those md files, or else your site will break.

Hi @elotroalex, can you please add your explanation to the README and create a PR, thanks!

Put it on the to do pile. I'll try to get to it soon.

:D

OK, I was looking for a way to translate pages and it is good.
But Is there a way to translate page title too?

@UnclePetros The best way is probably to use the default lang file :
in en.yml
global:
  title: My default website title!

pages:

  about:
    title: Get to know me

  contact
    title: Contact me

Then, in about.html
---
layout: default
permalink: /about/
title: pages.about.title
---

Well, hello there!

And in your _layouts/default.html
<head>
  <title>{% if page.title contains "pages." %}{% t page.title %}{% else %}{% t global.title %}</title>
  ...

HI Jason,
thank you for the answer.
This works fine for title.
But what about the permalink?
I've tried to do a short test with the following:
---
layout: page
title: pages.about
permalink: /{% translate pages.about %}/
---

{% translate_file about/about.md %}

But it fails.
Is there a chance to translate permalink?

@UnclePetros yes, that was part of my last pull request (I will need to add some documentation about that in the README ..)
Have a look at #53 for more infos, and let me know if you have problems using it!

Yes, sorry Jason, I was just reading your fix on permalinks.
Unfortunately I don't manage in installing plugin ver. 1.3.0.
I place files in my project _plugins directory but when I compile I receive the following error

undefined method `include?' for nil:NilClass

Any idea?

Might be one of your file that is missing the "permalink" in its header. My plugin isn't bullet proof, there's so much to double check, and Jekyll isn't throwing detailed error messages, even with --trace ... So, you will probably need to start with a copy of your project with almost nothing in it, then add pieces by pieces, pages by pages, until it crash. Then, you will know where the error is coming from. Please let me know when you fix it.

OK, thank you very much for you availability.
I've done some tests with both Octopress (my platform) and Jekyll.
I've tried with a fresh octopress installation (on top of jekyll 2.5.3) and it gives always the same error:

undefined method `include?' for nil:NilClass

So I've downloaded Jekyll latest version, installed the plugin, and try to build.
It returns this error:

Error: undefined method read_posts’ for class Jekyll::Site'

I've googled for the error and found this:
https://talk.jekyllrb.com/t/error-undefined-method-read-posts-for-class-jekyll-site/1392/2
But, this unfortunately not solve the issue.
Any ideas?

OK, Anthony new version of the plugin works like a charm.
I've installed it against Ruby 2.0.0 and my Octopress fork.
Thank you very much.
Let me know if you need further info.
Regards
UnclePetros

Version 1.4.0 has a section explaining this.

Hi guys,
I am able to add pages, adding folders to the root of the project.
But when I try to add pages in a "_pages" folder, like described here: http://damonbauer.me/organizing-jekyll-pages/ , it does not compile the pages anymore.
Probably I am missing a small step in the process, but I don't know what.
Could anyone help me? Thanks


Add a link to the Source of the Reddit clone to the homepage

While watching the rad intro video on ember-redux.com I wanted to follow along with the code, but couldn't quite find it. In #146  I'm adding a link to the examples page; I would also like that link on the homepage underneath the video.

Right on! I just merged the PR to add the reddit clone link up to our examples listing. About the link under the video ... assuming you don't mind tinkering in the website html/css :) see what you can come up with and I'll give it a look

@benshine thanks again for the great PRs this week! I love the website !!! If you are at EmberConf next month let me know so I can thank you in person!!


Ternary Operator Forced Into Multiple Lines

Input
Ternary operators are forced into multiple lines.
let test = (true) ? true : false;

Expected Output
let test = (true) ? true : false;

Actual Output
let test = (true)
    ? true
     : false;

Settings
{
    "indent_size": 2,
    "indent_char": " ",
    "indent_level": 0,
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 2,
    "jslint_happy": false,
    "space_after_anon_function": true,
    "brace_style": "collapse-preserve-inline",
    "keep_array_indentation": false,
    "keep_function_indentation": false,
    "space_before_conditional": true,
    "break_chained_methods": false,
    "eval_code": false,
    "unescape_strings": false,
    "wrap_line_length": 0
}

This doesn't repro on http://jsbeautifier.org/.  What tool are you using to run this?

Using the Atom plugin, with a .jsbeautifyrc. This is in an ES6 JSX file.

@gpresland -
Have your tried uninstalling and reinstalling the atom-beautify plugin?
If so, can you show more of the code around this problem?   It seems like there's some other part of the input that might be causing this.
Are the settings accurate?   What you show looks like indent_size of 4, not 2.

Input
import './Test.less';

import React from 'react';
import classNames from 'classnames';

const propTypes = {
  //
};

const defaultProps = {
  //
};

export class Test extends React.Component {

  constructor(props) {
    super(props);
  };
}

render() {

  let test = (true) ? true : false;

  return (

Test

  );
}
}

Test.propTypes = propTypes;
Test.defaultProps = defaultProps;

export default Test;

Output
import './Test.less';

import React from 'react';
import classNames from 'classnames';

const propTypes = {
  //
};

const defaultProps = {
  //
};

export class Test extends React.Component {

  constructor(props) {
    super(props);
  };
}

render() {

  let test = (true)
    ? true
    : false;

  return (

Test

  );
}
}

Test.propTypes = propTypes;
Test.defaultProps = defaultProps;

export default Test;

Settings
{
    "indent_size": 2,
    "indent_char": " ",
    "indent_level": 0,
    "indent_with_tabs": false,
    "preserve_newlines": true,
    "max_preserve_newlines": 2,
    "jslint_happy": false,
    "space_after_anon_function": true,
    "brace_style": "collapse-preserve-inline",
    "keep_array_indentation": false,
    "keep_function_indentation": false,
    "space_before_conditional": true,
    "break_chained_methods": false,
    "eval_code": false,
    "unescape_strings": false,
    "wrap_line_length": 0
}

Even with that added code, I still can't reproduce this on http://jsbeautifier.org/ .  Sorry.
I suspect operator_position is being set by atom-beautify, https://github.com/Glavin001/atom-beautify.  Please take a look at https://github.com/Glavin001/atom-beautify/blob/master/CONTRIBUTING.md#new-issues-bugs-questions-etc and generate debugging info and include that here.

I will move the issue to the atom-beautify repo since the issue appears to be coming from them.

For your information, I'd to dig into the repository of atom-beautify to find the fix.
Add option "preserve_ternary_lines":true in .jsbeautifyrc


How can I display a subview overlay when there are no messages?

I'd like to display a subview with images over the chat contents when there are no messages. I have tried to put a subview there but it must be hidden by the messages view controller because I never see it.
How can I position something on top of the messages view?

hey @ericgross - you shouldn't have any trouble doing this.
In viewDidLoad, something like:
[self.collectionView addSubview:myview];
[self.collectionView bringSubviewToFront:myview];


v0.8.0 testdeployment.sh fail while cyphernode is ok

Reproduce the problem
Delete all docker images and volumes.
Remove start.sh and testdeployment.sh script from the dist dir.
With an up to date repo on releases/v0.8.0 branch.
./build.sh
cd dist/
./setup.sh
./start.sh
Then the test fail but cyphernode work properly.
After further investigation I found out that the test container was mounting cyphernode_container_monitor docker volume while others containers were mounting dist_container_monitor docker volume.

Also, there is weird log while testing Notifier.

Testing Notifier... listening on [::]:1111 ...
connect to [::ffff:<IP_ADDRESS>]:1111 from dist_notifier_1.cyphernodenet:37550 ([::ffff:<IP_ADDRESS>]:37550)
Tue Mar 22 02:35:03 UTC 2022
GET /notifiertest HTTP/1.1
Host: 29a98d9b6674:1111
User-Agent: curl/7.79.1
Accept: /
Notifier rocks!

Hi @BHodl !
I can't reproduce what you are describing.  I created a brand new Debian VM, installed Docker from scratch, git cloned cyphernode, went to dist/ and ran ./setup.sh followed by ./start.sh and everything ran fine.  The images (master branch, v0.8.0 tag) were downloaded as expected.  Can you reproduce with master/v0.8.0?
kexkey@debian:~$ docker volume ls
DRIVER    VOLUME NAME
local     5c3d29806bfd3986edf2c4449e9f8f970c5e25fac07fc6fc1f28383807d18bbb
local     69da4eb7131045cebcb4ac6a9c34af0262380b2c9c2b8956195129d39b30ce85
local     b29bb568771c8098e20ad576179323be5846ac8ee8bebf942d9a6e3e6dc51a48
local     be8f3916afca20c6fb9e08c4abd2e9f95f9e47a3c759efad4469efc67be52231
local     cyphernode_container_monitor
local     f9fae717bd34194542eb425c38f5bdb494eadec09b09bcadd05ed3cdafd9b9b3
kexkey@debian:~$

I have no idea where your dist_container_monitor volume comes from.  It's nowhere in the cyphernode project.  I've never seen this volume in any of my multiple cyphernode environments.
Can you give me more information about your set?
Thanks!

The dist_ prefix on the volume name is the name of the stack.  You can find it in start.sh:
<% if (docker_mode == 'swarm') { %>
docker stack deploy -c $current_path/docker-compose.yaml cyphernode
<% } else if(docker_mode == 'compose') { %>
docker-compose -f $current_path/docker-compose.yaml up -d --remove-orphans
<% } %>

Are you using Swarm or docker-compose?

Ahh ok I just installed it using docker-compose and I can reproduce now.
kexkey@debian:~/.cyphernode/cyphernode/proxy_docker/app/tests$ docker volume ls
DRIVER    VOLUME NAME
local     3b63ad384244d0a8093b2cd8d4a503d1317c02a60afc651b09aac14dd830a463
local     3c0f508de2e9ea797de2f5401b3d5c27e233a8ca4abcd29b16ccb11a0704d19a
local     5e4012f20c9232c415c03f0dbc344aa816b51192cd2848f2c3cb96f40a9485b5
local     6f4e387b42c7774cf348b9c1a0e0c169a4e232bd95cf5d70d908ed20bde0b3b3
local     23e3ae3c29bbed5bd9721b47d7d1c26066058d1ce3c7ebe862136531c850fa72
local     cyphernode_container_monitor
local     deda92e33cb9a7d7cb7053028367460d409bb4286e3b6e711d4a916a59839ef6
local     dist_container_monitor
local     f4c98f76ac71a49a6aa44c634f78880b41acab483577508f83d1bd4c90224543
kexkey@debian:~/.cyphernode/cyphernode/proxy_docker/app/tests$

Ok let's go to your PR!  :-D

While testing with docker-compose (which I never use!) I noticed the welcome app doesn't even start properly because of the restart_policy condition that is not understood by docker-compose.  Only by Docker Swarm.
Ok, so, the simplest solution to fix all that:
Add this just before services: in the file cyphernodeconf_docker/templates/installer/docker/docker-compose.yaml:
name: cyphernode

Also, in the cypherapps repo, we need to remove for each docker-compose.yaml file:
        condition: "any"

I think that would fix a bunch of problems for docker-compose.

While testing with docker-compose (which I never use!) I noticed the welcome app doesn't even start properly because of the restart_policy condition that is not understood by docker-compose.  Only by Docker Swarm.
Ok, so, the simplest solution to fix all that:
Add this just before services: in the file cyphernodeconf_docker/templates/installer/docker/docker-compose.yaml:
name: cyphernode

Also, in the cypherapps repo, we need to remove for each docker-compose.yaml file:
        condition: "any"

I think that would fix a bunch of problems for docker-compose.


#61 - Implement localization

Resolves #61.

I used https://github.com/aissat/easy_localization as reference for JSON key lookup, caching and general structure of localization helpers. easy_localization is under MIT licence, is that going to be a problem for us? I can rewrite that part if we wish 🤷♂.

Resolves #61.

If I'm reading the PR correctly it doesn't fully resolved #61 in my opinion as it doesn't change the current strings in the app. Those are still hardcoded as far as I can tell at a glance?
This is still a really good start. We just need to move all of those strings to json to really support localization of the app.

This is still a really good start. We just need to move all of those strings to json to really fully support localization of the app.
Yes, of course, hence the draft status. :) I'm used to start PR as soon as I have something to show off and ready to be commented upon.

This is still a really good start. We just need to move all of those strings to json to really fully support localization of the app.

Yes, of course, hence the draft status. :) I'm used to start PR as soon as I have something to show off and ready to be commented upon.

Sorry didn't see the draft status when I commented :) It's not super clear on the github mobile app I'm using.

Following discussion on Discord I've decided not to translate Test and Widget library. They are meant for developers and will be never shown to end-users so there's no need to translate them. Additionally, localised text takes a bit longer to include than hardcoded text and I don't wish to burden the developers when they wish to quickly add a button to test new feature.

easy_localization is under MIT licence, is that going to be a problem for us?

I ended up not using their code because I decided to generate Dart classes from .json files.

@DreadBoy Can you update README.MD and explain how to add localization?


Error when compiling with HDF5 1.10

This version of the compiler is complaining about the different signature of the method 'readArrayNdOfValues' in src/common/HdfProxy.h and the correspondent cpp file.
Anyway, the issue can be fixed using the same typedef defined in H5Ipublic.h:
typedef int64_t hid_t;
Obviously the signature of all 'readArrayNdOfValues' needs to be changed accordingly:
from:
void readArrayNdOfValues(const std::string & datasetName, void* values, const int & datatype);
to:
void readArrayNdOfValues(const std::string & datasetName, void* values, const hid_t & datatype);
Do you want me to send a pull request for it? Or you don't plan to support this version of Visual Studio now?

Oï Henrique,
Obrigado for your feeedback
However, I think the proposed solution cannot be sufficient.
Indeed, H5Ipublic.h does not always declare typedef int64_t hid_t. For example, on my current HDF5 library (hdf5-1.8.18-win64-noszip-vs2013), H5Ipublic.h does declare typedef int hid_t which explains why I don't see your problem. The same declaration is in H5Ipublic.h of hdf5-1.8.19-Std-win7_32-vs2013 and of hdf5-1.8.21-Std-win7_64-vs14.
Your problem may not be caused by your compiler but caused by the HDF5 library version you use. Maybe you use HDF5 1.10 which is not officialy supported https://github.com/F2I-Consulting/fesapi (see readme) because RESQML does not officialy support it.
A nice fix would be to automatically modify the signature (at cmake time) of the readArrayNdOfValues according to the associated H5Ipublic.h which can be different among the different HDF5 library versions.
I keep this issue opened untill a PR is proposed. It does not look as a high priority but it may change.
Could you indicate please in this issue the HDF5 library version you use?
Thanks

Wow, right at the spot!
You are right, I am currently using 1.10.1 (this is the version my whole company is using).
I tend to always blame visual studio because, on each new release version, it happens to cause some problem in my code (warnings treated as error being one of the worst ones :( ).

OK then I close this issue but am happy to keep it archived when RESQML will officially support HDF5 1.10.
If you want to apply a workaround (if you don't want or cannot go back to HDF 1.8) then I advise you to modify the signature of the methods to use "long long" or "int64_t" instead of int. This will probably be what I am going to do when HDF5 1.10 will be officially supported by RESQML (and consequently by Fesapi too).
I prefer not using hid_t in .h cause of potentially harder support with SWIG.

Hi Philippe & Henrique,
For what it's worth (and for our future selves), it looks like the first HDF5 1.10 version that we can use is 1.10.2 which supports specifying the minimum supported read version to H5F_LIBVER_V18 with H5Pset_libver_bounds().  They accidentally left this support out of 1.10.1.
My company will upgrade to 1.10.3 (unless there is a .4 by then) near the end of the year.  I will see about updating fesapi to support 1.10.2+ at that point if no one else has done it.
By adding a H5Pset_libver_bounds() property to output file creation, it should finally be possible to write 1.8-compatible HDF5 files with newer versions of the library.
This is discussed in the release notes for 1.10.2
https://portal.hdfgroup.org/display/support/HDF5 1.10.2 if you search down for "H5F_libver_t"

Fixed in 380676b63609789c9983a5385a316ea99044c102


Currency input with first empty character

Is it possible to have a mask for the currency that will, when first clicked into, look like this (| represents the caret):
|.00

and when you continue typing it would apply the grouping and separations:
1.00
123.00
1,234.00

etc.

Adding _mask: () => '(,999){*|1}' seems to have worked :slightly_smiling_face:

Yes *


Feature request : support for Firefox Android

It would be nice if the extension could support Firefox for Android. I honestly don't know the amount of work needed to make it work, but I think it would be a nice feature.

This is planned at some point, but i think there is an app, would that be more helpful?, I don't know if the extension to mobile will be good for that

I saw the app beta on the discord, but I think fro simply adding links the FF add-on for Android woulb be way easier as it allow to add links without leaving the browser.

I've managed to load freshly downloaded extension via Firefox with debug mode :

Yap 7-8 times on the app icon in "About Firefox...", thas enable debug/dev mode
In Firefox settings you can install the extension file.
You'll have to configure your Linkwarden crendentials under Extension prefenrence page (seems "config "button broken)
Then you can add links with Firefox Android to

Compatibility is already there but, just lack of firefox addon store management.
Cheers,


How to render 3-code tone emojis correctly?

I'm asking myself how I can render emojis with tones "correctly". When I use basic emojis, like ok_hand, it works fine. But for things like "female detective with dark tone", I don't manage to render it correctly.
Here is what I tried:
twemoji.parse("🕵🏿♀")

twemoji.parse("🕵♀🏿")

Worked it out! It has to do with the placement of the Zero Width Joiner and Variation tokens.

Mind sharing how you solved this?  In the same boat here

@maniacally Phew, good question. I'll check later if I still have that project somewhere

You can read about canonical ZWJ sequences on Unicode's website: https://unicode.org/Public/emoji/11.0/emoji-zwj-sequences.txt
twemoji.parse("\uD83D\uDD75\uD83C\uDFFD\u200D\u2640\uFE0F")

<img class="emoji" draggable="false" alt="🕵🏽♀" src="https://twemoji.maxcdn.com/2/72x72/1f575-1f3fd-200d-2640-fe0f.png"/>


Move element between shared lists

I'm trying to move an element between lists.
I'm able to drag between shared lists but after dragging to one of the lists, I show a popup where the user needs to confirm if he wants to move it. If user cancels I want to move item back to previous list.
Any idea how i can accomplish this?
I don't see a way to move items programmatically.

Try this, it works for me:
https://github.com/SortableJS/Sortable/issues/266#issuecomment-1619729909


Let's make concrete/bin/concrete5.php executable

In my composer.json I have these scripts:
{
    "scripts": {
        "post-install-cmd": [
            "concrete5 c5:ide-symbols"
        ],
        "post-update-cmd": [
            "concrete5 c5:ide-symbols"
        ]
    }
}

They work fine in a Posix system, but in Windows they won't work since the only binary defined by concrete5 is concrete/bin/concrete5.
If we add concrete/bin/concrete5.php to the binaries, composer is intelligent enough to read the shebang and make the script work under Windows too.
That way, writing these scripts will work both under Posix and under Windows systems:
{
    "scripts": {
        "post-install-cmd": [
            "concrete5.php c5:ide-symbols"
        ],
        "post-update-cmd": [
            "concrete5.php  c5:ide-symbols"
        ]
    }
}

We could also rename the current bin/concrete5.php to bin/concrete5 (deleting the previous bin/concrete5 bash script): everything should work fine both for Posix and for Windows users, and we'd have only one binary for composer (bin/concrete5).

Let's rename it as well @mlocati

@aembler Done.


Drop-in replacement of jop-io/kontonummer.js

Hi,
Thank you for this project.
It would be nice to be able to get a single file drop in replacement for kontonummer.js
I am not very familiar with your tooling, but maybe it is not that hard to achieve?

Hi,
I'd assume it'd look something like this:
function kontonummer (number: string) {
  try {
    const k = new Kontonummer(number)
    return {
      bank_name: k.bankName,
      clearing_number: k.sortingCode,
      account_number: k.accountNumber
    }
  } catch {
    return false
  }
}

However I'm not sure if it's right to place it in this library, or if it's better to add that snippet to your own codebase to simplify migration

Thanks. In my project there is no npm/yarn. We are primarily a backend service with some very simple html forms.
If I could choose, I would want a simple js file I could include.

Fair, I'll havw to test this when I have a computer at hand, but I think you could do something like
<script type="module">
import Kontonummer from<EMAIL_ADDRESS>
function kontonummer (number) {
  try {
    const k = new Kontonummer(number)
    return {
      bank_name: k.bankName,
      clearing_number: k.sortingCode,
      account_number: k.accountNumber
    }
  } catch {
    return false
  }
}
</script>

Thank you so much for following up on this. The example is a great start, but I am afraid the dependencies
When it is importing the other files it cannot find them due to the missing extension in the url:

I tried building from source manually and add ".js" on all the imports and then it worked.

Yeah I was afraid that would happen. I'll see if I can add that to make sure it works when imported in browsers, and push out a new patch version

All right, 4.0.1 should do the trick, I've also added the above snippet as an example to the release notes

Thanks, it works!
To actually get kontonumber function available in my code I needed to add it to window: