Music in Formula One Grand Prix runs too fast - PAL/NTSC?

Hi,
Just booted up an old classic, Formula One Grand Prix by Geoff Crammond.
However, I noticed straight away that the intro music plays back too fast - the game is set to run in NTSC but if you force PAL, it runs at the right speed.
Not sure if this is deliberate or not, but I thought you'd want it pointing out in case it should be corrected.
If you do change it to PAL, perhaps the cropping setting for the game could be checked and verified also. It looks good in NTSC as naturally it fits at 5x with no cropping. However the HUD does run right to the bottom of the screen, so if it was changed to PAL you wouldn't want that info to be chopped off. However it is a bit of a border fest in default PAL mode.
Maybe this is why it was set to NTSC in the first place! :)
Anyways, thought i'd raise it for you.
Thanks a lot.

Gotcha! I'll fix it to run in 50Hz but with 5X scaling.

No worries! So long as if it's in 5x mode, the HUD doesn't get cut off at the bottom. I believe the HUD runs right to the base of the screen so if there is cropping involved, it might need positional tweaks or to be left at 4x?

Don't worry, the game runs in a 320x200px viewport 😘

Ah right, in that case it should be perfect then! :) I am not sure if the menus run in a larger viewport and could be cropped as a result, perhaps that might need to be verified.

Fixed in 50b6eb010a7db219f2c244e01d55530897f99704

Great, thank you very much as always! :thumbsup:


[bug] Occluded shadows aren't working in the DesktopGL port

For some time now, I've been trying to implement lighting to my game. I found this library, and I think it's a great resource, however, I have an issue regarding the "Occluded" ShadowType.
I want to develop a cross-platform game using OpenGL, but the Occluded shadows act just as "Illuminated" ones in DesktopGL. I tested every single version of the DesktopGL builds (1.3.0 - 1.4.0) - none of them worked for me.
When I added a hull and changed the ShadowType of the light to Occluded in the example/demo project "HelloPenumbra", it worked (since the example project is using DirectX). Then I made a new OpenGL project, copied the code from the original example, and added the DesktopGL reference - it didn't work.

Thanks for raising the issue @kobdak. I will look into it in the coming days.

A potential issue with MonoGame that might be related: https://github.com/MonoGame/MonoGame/issues/5441
Unfortunately, it's quite an old one with not much information.

 The problem was solved by adding just one line of code to the Game1 constructor; graphics = new GraphicsDeviceManager(this){ PreferredDepthStencilFormat = DepthFormat.Depth24Stencil8 };


allow sync iterators

There is no reason the transformer shouldn't be able to also transform a sync iterable to an async concurrently processed iterator.

This looks like a simple for-of-loop with extra steps and no actual benefits (except leading to a probably non-determined result).
I don't really see where/why this should be used, would someone mind giving a small example please?

alright, you are right I didn't do a very good job in explaining:

we don't have an infinite stream but one that "ends", that doesn't change anything but just for completeness.
We want to dynamically control how many expensive executions are running in parallel (think basically less parallelization if there's more load on the system OR a feature flag or the like). However the code currently to achive that for ANY amount of parallelization is a bit ugly since you can't use the asyncBufferedTransformer if you want serially executed promises.

E.g.:
//numberOfExecutions can be anything between 0 and 100, we don't "really" control it
const doTheThing = (inputStream: AsyncIterable<PromiseWrapper<unknown>, numberOfParallelExecutions: number) => {

if (numberOfParallelExecutions === 0 || numberOfParallelExecutions === 1) {
  for await (const execution of inputStream) {
      await execution.promise;
  }
} else {
  //drainStream isn't exposed currently, another thing I changed
  await collectAll(asyncBufferedTransformer(inputStream, {
      noOfParallelExecutions
  }))
}

which of course works, but imho there's no need for that complexity and it would read much nicer if asyncBufferedTransformer can be used in such dynamic circumstances

lgtm2, but I'll let Marc merge

@Germandrummer92 Please run npm lint --fix or similar


Recovery screen is not triggering anymore

We've had multiple issues of something panicing in the federation setup since we moved around the initialization code and now the setup is stalling without falling back to an error screen.
https://github.com/MutinyWallet/mutiny-web/issues/898

trying to repro let me know if you find a reliable way

Have you tried adding the federation in question?

yeah that actually causes a different problem.
it errors when I try to add it:

but it seems the federation stays in storage and now the wallet can't start up anymore:

this is good now yeah?


Function for parsing both sql and plpgsql?

I tried using pg_query::parse (rust) but the body of plpgsql functions comes up as a string "begin <SQL stuff> end". Moreover to use parse_plpgsql I have to use a full function definition, not just what is in between begin and end. Is there a way to parse both of these, a full fledged sql file that will have queries, triggers, and functions and fully parse the function bodies?
Thanks you

@rex-remind101 There isn't any convenience function for that today - technically it should be possible to add, but the challenge is with the resulting parse tree (the regular SQL AST is independent of the PL/pgSQL AST).
The easiest approach today, which is a bit of a hack, would be to parse the SQL first, then identify the relevant CreateFunctionStmts and then either (1) Use the location field of the top-level node to identify where the statement starts/end in the source string, (2) use the deparser (which is pretty complete) to turn the function definition back into SQL, and then pass that to the PL/pgSQL parser.
We should probably have a convenience function that takes a CreateFunctionStmt parse node and does the PL/pgSQL parsing based on that. PRs welcome :)

I will give the deparser method a shot for now, thank you.

ah this issue already exists here.
I created a duplicate in the bad repo: https://github.com/pganalyze/pg_query/issues/254


support safeAreaLayoutGuide of iOS11

em, the configure is old  'platform=iOS Simulator,name=iPhone 7,OS=10.0' can update to iOS 11 ?


Panda ideas

Supposed to replace this PR:
https://github.com/bluesky/ophyd-epics-devices/pull/20

tests are failing due to area detector, not panda. Need to follow this through with @coretl


set_value failed with ProxyException

When shutting down two covers at once (grouped by cover group via two HmIP-BROLL) I got the following exception/logs. One cover shut down immediately, the other with a delay of ~10 to 20 seconds.
Both HmIP-BROLL are installed in the near range of the CCU3 (~1 to 1,5 meters).
Custom Homeatic version: 0.28.7
Logger: hahomematic.client
Source: /usr/local/lib/python3.9/site-packages/hahomematic/client.py:269
First occurred: 21:37:38 (2 occurrences)
Last logged: 21:37:58

set_value failed with ProxyException ((<Fault -1: 'Generic error'>,)): 00111D8998D677:4, LEVEL, 0.0
set_value failed with ProxyException ((<Fault -1: 'Generic error'>,)): 00111D8998D035:4, LEVEL, 0.0

The single HmIP-BROLLs work without a Problem?
Have you used the old integration successfully with groups?

I am completely new to HomeMatic as well as to Home Assistant. The HmIP-BROLLS are installed since 2 weeks and are mostly used by the hardware switch itself.
But i remember that I had some delay issues (5 to 30 seconds), when I used the BROLLs via TinyMatic app. Probably this is more an CCU / hardware issue.

Good to know.
You should start solving this in the CCU. If this works you should go on in HA.
Maybe the homematic-forum can help you with the CCU related issues.
Please close this issue, if you agree.

I will. Does the log fit to the explained behaviour?

Not really.


AI decision coordinates: 'x=960, y=995'

Hello dear pywinassistant developpers,
First of all, thank you for your amazing work at pushing forward the limits of AI !
I would like to notify you about an issue I have had with this software.
I managed to make this AI assistant work by using "Razorbob"'s tutorial in both https://github.com/a-real-ai/pywinassistant/pull/9 and https://github.com/a-real-ai/pywinassistant/issues/5
It started great with the command "python ./assistant.py".
The Assistant icon showed up and there were no errors in the terminal.
The issue started when I asked him the following command by text (my first one): "Play "Never gonna give you up" in the application "Spotify""
The bot started, but went to the wrong coordinates:
Assistant listening thread started...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Clicked on the assistant: Whats the action?
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Processing input: play the song "Never gonna give you up" in the application "Spotify"
Performing action:  play the song "Never gonna give you up" in the application "Spotify"
Selected application: tk
Listening...
Listening...

Keywords: play, song, "Never gonna give you up", application, Spotify

AI decision coordinates: 'x=960, y=995'
Listening...
Listening...
Listening...
Executing command: <function stop_assistant at 0x00000229843300D0>```

I of course tried multiple times but the bot always went at these coordinates: 'x=960, y=995'

The spotify application was open and in full screen.

I am using the default model. I have a similar issue. I asked it to open firefox and tell me the weather for Florida. It fails to locate firefox. It says opening application VSCode and click on the search inside VSCode. 🤣

@Odysseum04 @iamgonnagiveyouup It seems that the "App Selector Agent" is selecting the application that has the actual instance of PyWinAssistant which is not being ignored by the agent. To fix this issue, ignore the application that is always selecting by adding strings "Tk.exe", "Tk", "Code", and "Code.exe" to the following lists:

To avoid hardcoding I'm implementing the ability to detect automatically the instance in which PyWinAssistant is running, but I'm checking on different ways to get securely into this approach.

Im getting this issue too i have nvidia geforce overlay

Hi @Odysseum04 @jasonc624 !
I have updated the following files to ignore the Nvidia overlay, Tk and Visual Studio Code (The assistant is intended to not be run by an IDE or a virtual environment).
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/last_app.py#L23
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/window_focus.py#L54
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/topmost_window.py#L18
If you have further issues please let me know.

Hi @Odysseum04 @jasonc624 !
I have updated the following files to ignore the Nvidia overlay, Tk and Visual Studio Code (The assistant is intended to not be run by an IDE or a virtual environment).
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/last_app.py#L23
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/window_focus.py#L54
https://github.com/a-real-ai/pywinassistant/blob/0bf9be45682036c3522d9f4748517bad4e26678b/core/topmost_window.py#L18
If you have further issues please let me know.

amd dvr overlay might be another one to add

@TheJustinCrow
Thank you for the suggestion, I'll add the following:
'amdow.exe' which is the 'amd dvr overlay'.
Greetings!

Okay, so thank you for your patch proposals. I have been testing these patch but the issue still occurs unfortunately.
Here are the updated last_app, topmost_window and window_focus files:
def should_exclude_process(name):
    excluded_processes = ['dwm.exe', 'Tk.exe', 'TK', 'Code', 'Code.exe', 'nvcontainer.exe', 'nvidia broadcast ui.exe', 'system', 'python.exe', 'steam.exe',
                          'TextInputHost.exe', 'tk', 'pycharm64.exe', 'nvidia broadcast.exe', 'widgets.exe',
                          'CTkToplevel', 'AI Drone Assistant', 'Ctk',
                          'nvidia broadcast.exe', 'widgets.exe', 'translucenttb.exe', 'securityhealthsystray.exe']
    return name in excluded_processes

def should_exclude_process(name):
    excluded_processes = ['dwm.exe', 'Tk.exe', 'TK', 'Code', 'Code.exe', 'nvcontainer.exe', 'nvidia broadcast ui.exe', 'system', 'python.exe', 'steam.exe',
                          'TextInputHost.exe', 'tk', 'pycharm64.exe', 'nvidia broadcast.exe', 'widgets.exe',
                          'CTkToplevel', 'Windows Input Experience',
                          'nvidia broadcast.exe', 'widgets.exe', 'translucenttb.exe', 'securityhealthsystray.exe']
    return name.lower() in excluded_processes

and
def get_open_windows():
    excluded_titles = ["AI Drone Assistant", "NVIDIA GeForce Overlay", "Windows Input Experience", "Program Manager"]
    excluded_executables = ["NVIDIA Share.exe", "Tk.exe", "TK", "tk", "Code", "Code.exe", "TextInputHost.exe", "Tk.exe", "conhost.exe", "explorer.exe",
                            'CTkToplevel', 'Windows Input Experience', "SecurityHealthSystray.exe", "Steam.exe",
                            "SearchApp.exe", "ApplicationFrameHost.exe", "ShellExperienceHost.exe", "MicrosoftEdge.exe",
                            "MicrosoftEdgeCP.exe", "MicrosoftEdgeSH.exe", "python.exe", "pycharm64.exe", "pycharm64.exe"]

    windows = gw.getAllWindows()

Here is the output of the code in the terminal:
PS C:\Users\cleme\Documents\pywinassistant\core> python assistant.py
Assistant listening thread started...
Listening...
Listening...
Listening...
Listening...
Listening...
Clicked on the assistant: Whats the action?
Listening...
Listening...
Listening...
Processing input: open google chrome
Performing action:  open google chrome
Debug: Window Title: 'tk', Process: 'python3.10.exe'
Selected application: tk
Listening...

Keywords: open, google, chrome

Listening...
AI decision coordinates: 'x=960, y=995'
Listening...
Listening...
Listening...

Both have been tried on Visual Studio Code and Pycharm

Okay so, first of all, thank you for your patch proposals !
I have been trying them out on my problematic installation.
After cloning the updated github repository, I tried once more and here are the results:
PS C:\Users\cleme\Documents\pywinassistant\core> python ./assistant.py
Assistant listening thread started...
Listening...
Listening...
Listening...
Clicked on the assistant: Whats the action?
Clicked on the assistant: Whats the action?
Listening...
Listening...
Listening...
Listening...
Processing input: open google chrome
Performing action:  open google chrome
Selected application: AI Drone Assistant
Listening...

Keywords: browser, chrome

Listening...
AI decision coordinates: 'x=1872, y=967'
Clicked on the assistant: Whats the action?
Listening...
Listening...
Listening...
Listening...
Listening...
Listening...
Clicked on the assistant: Whats the action?
Listening...
Processing input: Create a long AI essay about an AI Starting to control a Windows computer on Notepad
Performing action:  Create a long AI essay about an AI Starting to control a Windows computer on Notepad
Selected application: tk
Listening...
Listening...

Keywords: AI, essay, control, Windows, computer, Notepad

Listening...
AI decision coordinates: 'x=960, y=995'
Listening...
Listening...
Listening...
Listening...

As you can see, the code "worked" once even though it didn't open chrome, but the second time it went back on "Selected application: tk" and "AI decision coordinates: 'x=960, y=995'".

To be precise, all my test were done by writing the task, wich brings the "AI Assistant" icon (so basicaly tk) at the topmost of applications

Hi @Odysseum04 !
PyWinAssistant is having issues discarding it's own ui so it is focusing itself when chat is used.
Temporally instead of using the chat, please try activating the assistant using your own voice with the command "OK computer" as PyWinAssistant automatically fixes the given prompt.
If you want to try written prompts, execute directly driver.py using the examples at the bottom of the assistant function.
I'm working on fixing the chat issue that is focusing on itself. The method of selecting and recognizing apps is not properly ignoring the PyWinAssistant UI.


Rust repos code metrics

SLOC in Rust repos, to start.

From https://internals.rust-lang.org/t/the-rust-project-needs-much-better-visibility-into-important-metrics/:

Another possible metric is the total number of Rust lines in github repositories. Repos from rust-lang and servo should be excluded I think.

Ooh, yeah, scraping Rust repos has a lot of promise.

Boilerplate: I'm going to refocus this project on rfcbot, since that's the primary usage rusty-dash.com is seeing.


Lesson58 - Fatal Error

Hello
I have installed the lesson58 on a fresh WP installation. Received the following error on activate:
Fatal error: Uncaught Error: Class 'Inc\Base\Activate' not found in D:\xampp\htdocs\wordpress\wp-content\plugins\alecaddd-plugin\alecaddd-plugin.php:46 Stack trace: #0 D:\xampp\htdocs\wordpress\wp-includes\class-wp-hook.php(286): activate_alecaddd_plugin('') #1 D:\xampp\htdocs\wordpress\wp-includes\class-wp-hook.php(310): WP_Hook->apply_filters('', Array) #2 D:\xampp\htdocs\wordpress\wp-includes\plugin.php(465): WP_Hook->do_action(Array) #3 D:\xampp\htdocs\wordpress\wp-admin\plugins.php(177): do_action('activate_alecad...') #4 {main} thrown in D:\xampp\htdocs\wordpress\wp-content\plugins\alecaddd-plugin\alecaddd-plugin.php on line 46
Thanks

Resolved. Did not run composer install.

i too, thanks https://webaoe.com/

I am trying to install my plugin on live server but it giving me this error on activation, its working fine on localhost


V1.56 update broke editor menu bar icons of Shortcut Menu Bar extension

VS Code Version: 1.56
OS Version: Windows 10

Hey there, I'm the author of Shortcut Menu Bar. Latest VSCode release is causing problems in rendering editor menu bar icons.
Steps to Reproduce:

use VSCode 1.56
install Shortcut Menu Bar
observe editor menu bar icons

Expected behavior:

Current behavior:

Issue doesn't exist if I downgrade from v1.56.
Related bug: https://github.com/GorvGoyl/Shortcut-Menu-Bar-VSCode-Extension/issues/54
Let me know if you need further details.

Does this issue occur when all extensions are disabled?: Yes

Same problem here, It broke not only the extension jerrygoyal.shortcut-menu-bar, but others also, like nanlei.save-all and panzerstadt.light-dark-toggle


fix fix version check failure of window_funnel when upgrading

Proposed changes
Issue Number: close #xxx
Fix fix version check failure of window_funnel when upgrading to latest branch 2.1.
02:49:13   F20240930 02:47:48.546983  7581 block.cpp:89] Check failed: BeExecVersionManager::check_be_exec_version(be_exec_version)
02:49:13   *** Check failure stack trace: ***
02:49:13       @     0x564640041856  google::LogMessage::SendToLog()
02:49:13       @     0x56464003e2a0  google::LogMessage::Flush()
02:49:13       @     0x564640042099  google::LogMessageFatal::~LogMessageFatal()
02:49:13       @     0x56463922d106  doris::vectorized::Block::deserialize()
02:49:13       @     0x5646390a82bf  doris::vectorized::WindowFunnelState<>::read()
02:49:13       @     0x5646390a6889  doris::vectorized::IAggregateFunctionDataHelper<>::deserialize_and_merge()
02:49:13       @     0x5646390acdc3  doris::vectorized::IAggregateFunctionHelper<>::deserialize_and_merge_from_column_range()
02:49:13       @     0x56463fa77152  doris::pipeline::AggSinkLocalState::_merge_without_key()
02:49:13       @     0x56463fa9d114  doris::pipeline::AggSinkLocalState::Executor<>::execute()
02:49:13       @     0x56463fa78569  doris::pipeline::AggSinkOperatorX::sink()
02:49:13       @     0x564640013296  doris::pipeline::PipelineXTask::execute()
02:49:13       @     0x56464001d41c  doris::pipeline::TaskScheduler::_do_work()
02:49:13       @     0x56463663e078  doris::ThreadPool::dispatch_thread()
02:49:13       @     0x564636634901  doris::Thread::supervise_thread()
02:49:13       @     0x7fb64cf58ac3  (unknown)
02:49:13       @     0x7fb64cfea850  (unknown)
02:49:13       @              (nil)  (unknown)
02:49:13   *** Query id: b0cd194940184766-961c310e833e92b1 ***
02:49:13   *** is nereids: 1 ***
02:49:13   *** tablet id: 0 ***
02:49:13   *** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1727635668" if you are using GNU date ***
02:49:13   *** Current BE git commitID: 653e315ba5 ***
02:49:13   *** SIGABRT unknown detail explain (@0x1648) received by PID 5704 (TID 7581 OR 0x7fb354a9a640) from PID 5704; stack trace: ***
02:49:13    0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/common/signal_handler.h:421
02:49:13    1# 0x00007FB64CF06520 in /lib/x86_64-linux-gnu/libc.so.6
02:49:13    2# pthread_kill at ./nptl/pthread_kill.c:89
02:49:13    3# raise at ../sysdeps/posix/raise.c:27
02:49:13    4# abort at ./stdlib/abort.c:81
02:49:13    5# 0x000056464004C06D in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13    6# 0x000056464003E76A in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13    7# google::LogMessage::SendToLog() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13    8# google::LogMessage::Flush() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13    9# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13   10# doris::vectorized::Block::deserialize(doris::PBlock const&) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/vec/core/block.cpp:113
02:49:13   11# doris::vectorized::WindowFunnelState<(doris::vectorized::TypeIndex)14, long>::read(doris::vectorized::BufferReadable&) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/vec/aggregate_functions/aggregate_function_window_funnel.h:363
02:49:13   12# doris::vectorized::IAggregateFunctionDataHelper<doris::vectorized::WindowFunnelState<(doris::vectorized::TypeIndex)14, long>, doris::vectorized::AggregateFunctionWindowFunnel<(doris::vectorized::TypeIndex)14, long> >::deserialize_and_merge(char*, char*, doris::vectorized::BufferReadable&, doris::vectorized::Arena*) const at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/vec/aggregate_functions/aggregate_function.h:517
02:49:13   13# doris::vectorized::IAggregateFunctionHelper<doris::vectorized::AggregateFunctionNullVariadicInline<doris::vectorized::AggregateFunctionWindowFunnel<(doris::vectorized::TypeIndex)14, long>, false> >::deserialize_and_merge_from_column_range(char*, doris::vectorized::IColumn const&, unsigned long, unsigned long, doris::vectorized::Arena*) const at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/vec/aggregate_functions/aggregate_function.h:465
02:49:13   14# doris::pipeline::AggSinkLocalState::_merge_without_key(doris::vectorized::Block*) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/pipeline/exec/aggregation_sink_operator.cpp:389
02:49:13   15# doris::pipeline::AggSinkLocalState::Executor<true, true>::execute(doris::pipeline::AggSinkLocalState*, doris::vectorized::Block*) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/pipeline/exec/aggregation_sink_operator.h:73
02:49:13   16# doris::pipeline::AggSinkOperatorX::sink(doris::RuntimeState*, doris::vectorized::Block*, bool) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/pipeline/exec/aggregation_sink_operator.cpp:744
02:49:13   17# doris::pipeline::PipelineXTask::execute(bool*) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/pipeline/pipeline_x/pipeline_x_task.cpp:332
02:49:13   18# doris::pipeline::TaskScheduler::_do_work(unsigned long) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/pipeline/task_scheduler.cpp:347
02:49:13   19# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
02:49:13   20# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_branch-2.1/doris/be/src/util/thread.cpp:499
02:49:13   21# start_thread at ./nptl/pthread_create.c:442
02:49:13   22# 0x00007FB64CFEA850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83
02:49:13   [2024-09-30 02:49:13,147 __main__:796] [INFO]: <IP_ADDRESS> last coredump sql: 2024-09-30 02:48:18,328 [query] Query b0cd194940184766-961c310e833e92b1 1 times with new query id: 2e0e00de0e7548dd-95f9abc9d8d11c3a

run buildall


Screen with streaming video (hls) opens with delay

Hi, I want to see a streaming video that my backend sends to my app in .m3u8 format
I can see the video, but the screen where the video has been collocated spends a lot of time to open.
How I can avoid this delay?  is there a way to optimize it?
Thanks

solved with https://github.com/react-native-community/react-native-video/pull/426


Adding rimraf instead of rm -rf

The rm -rf  is a unix style command that windows users wont be able to use.
If we switch to the rimraf the clean command will work.

Thanks @fokion


Fix x509 error about vendor link

Hi @chalin , as you suggested in #2128, the https certificate was updated months ago.
Now change the url to Insight that is an observability product and integrates with many OTel features.

ok, well noted. I'm asking IT staff why. This PR can be closed because nothing need to be changed currently.
The certificate looks different in and out of China -_!

The certificate looks different in and out of China -_!

That is what I was beginning to suspect.

Finally, the SSL certificate works now. It is effective after 24:00 last night while it was updated 8 hours ago.

Verified it at: https://www.sslchecker.com/sslchecker

Thanks for the confirmation. I've removed the link-checker ignore rule for daocloud.io in #2362, see https://github.com/open-telemetry/opentelemetry.io/pull/2362/files#diff-9ad64044531d7d8c033064f11141586478b535147312374c24f8d2d997722889L19-L20.


added dark theme

Follow-up to https://github.com/TuringLang/turinglang.github.io/pull/92

Hello @penelopeysm, version check workflow is failing here, can you please have a look at it?

@shravanngoswamii I'm fairly sure it's because the PR is being made from a fork, it runs fine on #510.
Will edit the action to handle this case more gracefully!

Will edit the action to handle this case more gracefully, but it's safe to ignore it for now!

Thank You, @penelopeysm!

@jitendravjh I think the background colour of this breadcrumb should be same as main bg-color!

Thank you for the feedback! I'll update the breadcrumb background color.


Incompatible with Quart 0.19.4 (no AsyncNamespace in quart.signals)

Traceback:
/nix/store/7b0rz3bnx7msw2wawkv1hhn5lqf1b0wi-python3-3.11.6/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
src/autonomic/web/test_serve.py:14: in <module>
    import autonomic.web.serve as asrv
src/autonomic/web/serve.py:15: in <module>
    from quart_sqlalchemy import SQLAlchemyConfig as QuartSQLAlchemyConfig  # type: ignore
/nix/store/8s9ndlyap5pilfk1khr70c2f9aj9af42-python3-3.11.6-env/lib/python3.11/site-packages/quart_sqlalchemy/__init__.py:3: in <module>
    from .bind import AsyncBind
/nix/store/8s9ndlyap5pilfk1khr70c2f9aj9af42-python3-3.11.6-env/lib/python3.11/site-packages/quart_sqlalchemy/bind.py:15: in <module>
    from . import signals
/nix/store/8s9ndlyap5pilfk1khr70c2f9aj9af42-python3-3.11.6-env/lib/python3.11/site-packages/quart_sqlalchemy/signals.py:6: in <module>
    from quart.signals import AsyncNamespace
E   ImportError: cannot import name 'AsyncNamespace' from 'quart.signals' (/nix/store/8s9ndlyap5pilfk1khr70c2f9aj9af42-python3-3.11.6-env/lib/python3.11/site-packages/quart/signals.py)

Indeed, there is no AsyncNamespace in quart-0.19.4/src/quart/signals.py

I'm not finding any code that actually uses async_signals -- can we just remove it outright?

Looking at history, btw, this appears to have happened in the commit "Upgrade to blinker 1.6", which happened between 0.18.x and 0.19.x


Non-arrays get cleared too

@sazzad16 we shouldn't remove the test but adopt it to the right result.

@gkorland Thank you for handling that.


TypeError: unhashable type: 'list' in signal control examples

Several Python scripts within the demos_and_examples directory are failing due to a TypeError related to hashability. Specifically, the scripts attempt to use a list as a key in a dictionary, which is not permitted in Python as lists are mutable and thus unhashable.
Affected Files:

example_08_signal_reactive_control.py
example_08en_signal_reactive_control.py
example_11en_signal_4legged_intersection_reactive_control.py

Steps to Reproduce:

Execute the scripts individually or through a test runner like pytest.
Observe the TypeError that occurs when attempting to use a list as a dictionary key.

Expected Behavior:
The scripts should run without errors, managing signal control as designed.
Actual Behavior:
When running the scripts, they fail with the following error output:
TypeError: unhashable type: 'list'

The error is thrown in the following context for each script:

In example_08_signal_reactive_control.py and example_08en_signal_reactive_control.py at line 37:vehicles_per_links[l.signal_group] = l.num_vehicles

In example_11en_signal_4legged_intersection_reactive_control.py at line 45:vehicles_per_links = {l.signal_group: 0 for l in II.inlinks.values()}

Error Log:
For example_08_signal_reactive_control.py:
simulation setting:
...
simulating...
      time| # of vehicles| ave speed| computation time
       0 s|        0 vehs|   0.0 m/s|     0.00 s

Traceback (most recent call last):
  File "/path/to/example_08_signal_reactive_control.py", line 37, in <module>
    vehicles_per_links[l.signal_group] = l.num_vehicles
TypeError: unhashable type: 'list'

Similar errors are observed for the other affected files.
Suggested Fix:
A review and potential redesign of the data structure used to track vehicles per link is needed. If l.signal_group is indeed a list and meant to be used as a key, one could consider converting it to a tuple, which is hashable, provided the list's contents are also hashable. Otherwise, restructure the code to avoid using a list as a dictionary key.

Thanks! I have updated the examples.
This was caused by the recent update on traffic signal modeling.


ProtoInputHooks64.dll missing from 2.1

Doesn't startup due to missing .dll in nucleus co-op root folder. This is not an issue in 2.0

Did you make sure your antivirus or firewall doesn't delete the file?


Obstacle Management Support

Need to add new MQTT routes for delete obstacles by Id or all obstacles

Topic
Source
Destination
Data Type
Sample
Summary

{channal}/obstacles/delete
Server
GUI
JSON
{ “id”: “#” }
Delete the obstacle which has given id

{channal}/obstacles/delete/all
Server
GUI
Null
?
Delete all obstacles in the scene.

Done

Done


remove welcome banner

Pivotal
Before

After

Note the Process application panel is now butted up to the black bar. I'm going to have a little tidy up through some of the templates in a separate PR coming shortly. 👌

Great, please merge!


Fix disconnect

Always fire disconnect event when read loop finishes
On close, wait till the read loop is finished
Breaking change: Reset but don't close the serial port on closing ESP Web Flasher. It's passed in in the open state, so it's up to the caller to close the port.

Hmm this last remark about keeping the serial port open gives me an idea.
Would it be possible to schedule a number of calls to the node after some delay, or maybe even after reading back some specific string?
This would allow to enter some credentials to be sent via the serial port at the initial boot.

Yes, that is possible and that's what we're doing with ESP Web Tools v2. It supports sending credentials using the new Improv over Serial


[zh] Translate the the "en/docs/reference/kubernetes-api/service-resources/ingress-v1.md"

#34646

请先稍后再review，我按照昨天要求，统一修改一下

/close

/open

/reopen

@shixiuguo Still working on this? 2 weeks have passed.

@shixiuguo If you are no longer working on this, we can close this one or hand it over to someone else.

@shixiuguo Do you mind if someone else takes over this work if you are too busy to carry it on?

@shixiuguo Do you mind if someone else takes over this work if you are too busy to carry it on?

我可以接着来，前一段时间总去医院，现在可以了，我可以接着来

/retitle [zh] Translate ingress-v1 API reference

@shixiuguo If you are really too busy to push this forward, you can let someone else to take it over. It is fine for someone else to continue a stalled work. This is one of the oldest PRs we have in the queue.

CC @windsonsea,
Here is another PR maybe you would like to take a look.

ok, I will take this over and co-author it with @shixiuguo tonight.

/close
Superseded by #35634


Ignore __MACOSX metadata directory in zip files

Zip files created on Mac OS X might include a folder with metadata for files in
the archive:
./submission/ISIC_0000003_Segmentation.png
./__MACOSX/submission/._ISIC_0000003_Segmentation.png

With the current error checking, the similar filename in the metadata folder
causes the error:
Multiple matching submissions for: ISIC_0000003_Segmentation.png

To avoid the error, ignore the __MACOSX metadata directory when extracting zip
files.
Fixes #15

LGTM.


Dracula theme for Unigram

Dracula theme for Unigram (Telegram client)
https://github.com/weeebdev/unigram
Colors are ported from: https://github.com/dracula/telegram
P.S. There are may be issues with some colors, because I couldn't find documentation about each property, so the properties which I don't know left with #FF5555

Great! I just sent you an invite to join the organization.
Once you accept it, you'll be able to transfer the repo and I'll take care of adding it to the site.
Thanks for building this! 🎉

@zenorocha done!

I am sorry, but how do I turn off email notifications about repo transfers? I am afraid of changing the settings of your organisation, so I decided to ask you directly

It's live! 🎉 🎉 🎉
https://draculatheme.com/unigram
Thanks @weeebdev, you should stop receiving notifications now. :)


Add article table of contents sidebar

https://github.com/remarkjs/remark-toc
https://github.com/JS-DevTools/rehype-toc
https://github.com/remarkjs/remark-git-contributors
https://github.com/remarkjs/remark-contributors
https://github.com/vcarl/remark-headings


model.mock.estimate_ngals() doesn't work for composite HOD model

When I populate the halo catalog with this model, the estimate_ngals() method gives back an error:

while the following works.

The only difference should be the HOD model.

Thanks for pointing this out @KuanWang-Astro - should be an easy fix.


undefined reference to `OrtGetApiBase'

Cargo run got undefined reference to OrtGetApiBase error
  = note: /usr/bin/ld: /home/abao/Documents/work/collage/target/debug/deps/libcollage_ai-ec1cbd2bcc7bb2e3.rlib(collage_ai-ec1cbd2bcc7bb2e3.3tmk9tf6qwadfhi2.rcgu.o): in function `collage_ai::get_available_providers':
          /home/abao/Documents/work/collage/packages/ai/src/lib.rs:22:(.text._ZN10collage_ai23get_available_providers17h349598fc542233a8E+0x13): undefined reference to `OrtGetApiBase'
          collect2: error: ld returned 1 exit status

  = note: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)

error: could not compile `collage-app` (bin "collage-app") due to previous error

<root>/Cargo.toml
[workspace]
resolver = "2"
members = ["app/src-tauri", "packages/ai"]

[profile.dev]
rpath = true

[profile.release]
rpath = true

<root>/packages/ai/Cargo.toml
[dependencies]
ort = { version = "1.16.3", features = ["load-dynamic"] }

<root>/.cargo/config
[target.x86_64-unknown-linux-gnu]
rustflags = [ "-Clink-args=-Wl,-rpath,\\$ORIGIN" ]

I am not family with rust compile system,

For normal api, e.g. ort::Environment,  cargo run run success

With the load-dynamic feature, the dynamic library is loaded at runtime. The executable isn't being linked to the ONNX Runtime libraries, hence the undefined symbol.
If you need access to the OrtApi object, there is a function for that that works with load-dynamic: ort::ort


Metron 142 Simplify Parser configuration

This pull request includes several changes related to optimizing configuration for parser topologies.  Currently the process for adding parsers includes several unnecessary steps with configuration being duplicated in various places.  The high level changes are:

Sensor specific config files (parser and enrichment) were reorganized into their respective projects
Parser topology configuration is now dynamically driven by simple sensor specific json config files
Zookeeper configuration infrastructure was extended to support parser topologies
Ansible scripts were updated to load parser configurations to zookeeper and call parser topology startup scripts correctly.
Unit and integration tests were updated to accommodate parser topology changes and provide coverage for new classes.
Updated tools for reading and writing sensor parser configs to zookeeper
Removed generic configuration feature as it is not being used anywhere
Changed enrichment integration and unit tests to use a dedicated test config instead of reusing a sensor specific enrichment config
Moved zookeeper configuration functions to a new component in the integration testing framework.
Abstracted integration test validations to facilitate more readable code and reusable validations

The major benefits of this pull request are a simpler process for adding more parsers and additional test coverage for sensor specific parser configurations.  This has been integration tested and verified with a full-dev-platform build.

This looks good to me.  +1

+1 Looks good.  Validated 'Quick Dev' based on changes to how Monit is integrated.


example of build using dynamically generated config

this is a proposal for getting more dynamic build configuration
the example lets a build use a dynamically generated config.mk (well at the moment just a verbatim copy of the static configuration; but the point is you could change the copy incrementally to use updated info)
admittedly its a bit of a hack (needs testing)

this is wip on #577
it needs latest amusifier patches

this can be merged, but it is mainly instructive


hazmat suit config options

please add a config settings for hazmat suit armor amounts like there is for other armors.

Hey, there's already a setting for that.
"# List of armor item stacks and their default radiation shielding levels. Format: 'modid:armorName:meta_resistance'. Note: this is not the only way to add these values if you have CraftTweaker installed. Radiation resistance can also be given to armor by changing their recipe such that an NBT tag called "ncRadiationResistance" with the double value equal to the resistance level is attached to it."
For me, it's in line 1301 in the config

i see you didn't even read my comment before replying, i said want a config option to set the >>>ARMOR<<< for hazmat suits.

Added for the next version ;)


Ensure correct error texts and codes are used in rejection messages (for charge price list) sent to market participants

Synopsis:
As a market participant
I want to receive rejection messages that uses correct error texts and codes.
So that it is clear what went wrong
And the rejection messages are familiar to the ones I'm used to in DataHub2.
Tech note:

Creating the rejection message for a charge price list is already in main, it does however not apply correct error texts and codes, which is needed to be considered valid.
This is for the async validation of charges only
English error descriptions are to be used (JST 3/1-'21)
Error texts are now to support placeholders for dynamically filled variables, contrary to previous decision, where descriptions were dynamical and text static. (JTST &/1-'21)

Acceptance criteria:
Given the already implemented validation rules for charge price list requests
When violating any of them
Then the rejection text and code sent in the rejection message to the market partipant
complies with the error code and text provided by (PO and SME)
EDIT: the list of error codes and corresponding texts are availble in the internal file:
https://energinet.sharepoint.com/:x:/r/sites/DH3ART-team/Delte dokumenter/General/CIM/Kodelister og Attributter/Kodeliste DH3 - CIM inkl. att. tilknytning.xlsx?d=wc9be2dea8a7f4c20a12ee53bcd944dd9&csf=1&web=1&e=NVP8zq
(filter by TYPE ResponseReasonDescriptionCode)

EDIT 20220106: The list of validation texts is changed to ((https://app.zenhub.com/files/345465244/9fc033f5-4f35-45a1-a557-e8c133da4cde/download)) The file is due for changes, and current story will be updated once a versionized file is shared.

@PerTHenriksen or @IreneDataHub please provide the correct error codes and texts as per AC2.

@PerTHenriksen, the synopsis seems updated but it's no longer aligned with the title and AC, which should also be updated to make the story clear and unambigous.

@PerTHenriksen, the synopsis seems updated but it's no longer aligned with the title and AC, which should also be updated to make the story clear and unambigous.

Given the talk we had Monday during planning, I actually updated the story the same day (title + description). Besides having the source for codes and texts, what would you like to have changed? @BjarkeMeier

Added another tech note to, hopefully, remove ambiguity.
(the first listed tech note)

MeteringPointId indicated in the validation rule Excel sheet for VR.009 and VR.223 does not make sense. Document ID is used as parameter for errormessages.

(https://app.zenhub.com/files/345465244/9fc033f5-4f35-45a1-a557-e8c133da4cde/download)

Added new bug #1068

added another bug #1070

Additional two bugs #1071 and #1072

New story added #1073

Test documentation


Add README.md for ui test

add README.md for ui test

@pelikhan Have merged this pull request in the previous one


Accessibility : keyboard navigation loose focus after the choice of a file

Hello,
When i use the keyboard (without a mouse) to upload a file :

i use the browse button
i select a file
i use the open button
and then i loose the focus and i can't go further.

@Equipement were you able to fix this issue?


Fix lifetime issue in implementation of Decodable for Cow

Building the portability branch with a recent nightly compiler results in:
raoul@sacagawea:~/Documents/rustc-serialize/src$ cargo +nightly-2024-01-05 build
...
error[E0310]: the parameter type `T` may not live long enough
    --> src/serialize.rs:1155:5
     |
1155 |     fn decode<D: Decoder>(d: &mut D) -> Result<Cow<'static, T>, D::Error> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |     |
     |     the parameter type `T` must be valid for the static lifetime...
     |     ...so that the type `T` will meet its required lifetime bounds...
     |
note: ...that is required by this bound
    --> /rustc/f688dd684faca5b31b156fac2c6e0ae81fc9bc90/library/alloc/src/borrow.rs:180:30
help: consider adding an explicit lifetime bound
     |
1151 | impl<'a, T: ?Sized + 'static> Decodable for Cow<'a, T>
     |                    +++++++++

For more information about this error, try `rustc --explain E0310`.
...
warning: `rustc-serialize` (lib) generated 261 warnings (85 duplicates)
error: could not compile `rustc-serialize` (lib) due to 1 previous error; 261 warnings emitted

(Warnings related to trait objects without an explicit dyn being deprecated and others are not fixed)

We decided to move the code to the fortanix GitHub account. We new PR was filed.


Security Policy

Question:
Hi,
I see that there is no security policy listed currently for this project. Is there any such security policy that exists and is being used for this project development?
For example:
https://www.microsoft.com/en-us/securityengineering/sdl/practices
Thanks!

Confluent has a large security team whose mandate covers the client libraries. The development team interact with them regularly for a variety of purposes, including those listed in the linked to article.
I don't believe we have anything published publicly.


Backport HBASE-28804 to branch-2

[HBASE-28804: Implement asynchronous retrieval of bucket-cache data from persistence
During the retrieval of data from bucket cache persistence file, a transient structure that stores the blocks ordered by filename is constructed from the backing map entries. The  population of this transient structure is done during the server start-up. This process increases the region-server startup time, if the bucketcache has large number of blocks.
This population happens inline with the server restart and blocks the server for several minutes. This makes the server restart inconvenient for the external users. Restarts during upgrade can run into timeout issues due to this delay in the server startup.
Hence, the recommendation in this Jira is to make the cache-retrieval asynchronous to the server startup. During a server startup, a new thread is spawn that reads the persistence file and creates the required structures from persistence file. The server continues with the restart and does not wait for the bucket-cache initialisation to complete.
Note that the bucket cache is not available immediately for usage and will only be ready to use after the data is repopulated from persistence into memory.
The prefetch thread that may start before the bucket-cache is initialized is modified to wait until the bucket cache is initialized.
Change-Id: I2c136d7b1d884f74642d29923172a1ad4ada36e4
HBASE-28804: Apply splotless and spotbugs changes.
Change-Id: I239c357a135a058650a20c5707c7c7303a248c85
HBASE-28804: Addressing first round of review comments.
Change-Id: Ie160b249f6a2bff18fd8a577ae32a263b7de25ea
HBASE-28804: Added unit tests for validation of cache in initialization state.
Change-Id: Ib54f565152c391da727be7413dd775fb507daea7
HBASE-28804: Address further review comments.
Change-Id: I446475dc84d52403f67762b878af874b9cbe1937
HBASE-28804: Fix unit test.
Change-Id: I391e5e453e077b7e5733cd997130467b356a3e66
HBASE-28804: Fixed check-style warnings
Change-Id: Ieb6b5841cb7b23d919fbebbe420c0083167d6d0b
Change-Id: I690e840b866795484d2a1463ff47d885d43fc7dc

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
3m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 33s

branch-2 passed

+1 :green_heart:
compile
3m 33s

branch-2 passed

+1 :green_heart:
checkstyle
0m 42s

branch-2 passed

+1 :green_heart:
spotbugs
1m 45s

branch-2 passed

+1 :green_heart:
spotless
0m 53s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  2s

the patch passed

+1 :green_heart:
compile
3m 23s

the patch passed

+1 :green_heart:
javac
3m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 45s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 2 new + 63 unchanged - 1 fixed = 65 total (was 64)

+1 :green_heart:
spotbugs
1m 52s

the patch passed

+1 :green_heart:
hadoopcheck
23m 16s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

-1 :x:
spotless
1m  1s

patch has 54 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s

The patch does not generate ASF License warnings.

51m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 3022eccf387e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3acb488c4d6da414203412920be024eef9f7f0ed

Default Java
Eclipse Adoptium-11.0.23+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
3m 13s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 20s

branch-2 passed

+1 :green_heart:
compile
1m 13s

branch-2 passed

+1 :green_heart:
javadoc
0m 32s

branch-2 passed

+1 :green_heart:
shadedjars
6m 43s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 51s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed

+1 :green_heart:
javac
1m  6s

the patch passed

-0 :warning:
javadoc
0m 31s
/results-javadoc-javadoc-hbase-server.txt
hbase-server generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44)

+1 :green_heart:
shadedjars
6m 33s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
222m 29s

hbase-server in the patch passed.

255m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux d7d71f210d2b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3acb488c4d6da414203412920be024eef9f7f0ed

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/testReport/

Max. process+thread count
4470 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 33s

branch-2 passed

+1 :green_heart:
compile
0m 45s

branch-2 passed

+1 :green_heart:
javadoc
0m 27s

branch-2 passed

+1 :green_heart:
shadedjars
4m 53s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 26s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed

+1 :green_heart:
javac
0m 45s

the patch passed

-0 :warning:
javadoc
0m 26s
/results-javadoc-javadoc-hbase-server.txt
hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
shadedjars
4m 59s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
245m 19s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

267m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 5f77d83aa5d7 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3acb488c4d6da414203412920be024eef9f7f0ed

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/testReport/

Max. process+thread count
4718 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 23s

branch-2 passed

+1 :green_heart:
compile
0m 53s

branch-2 passed

+1 :green_heart:
javadoc
0m 27s

branch-2 passed

+1 :green_heart:
shadedjars
6m 17s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 12s

the patch passed

+1 :green_heart:
compile
0m 52s

the patch passed

+1 :green_heart:
javac
0m 52s

the patch passed

-0 :warning:
javadoc
0m 26s
/results-javadoc-javadoc-hbase-server.txt
hbase-server generated 1 new + 85 unchanged - 0 fixed = 86 total (was 85)

+1 :green_heart:
shadedjars
6m 56s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
264m  3s

hbase-server in the patch passed.

291m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux c2fba4658c6e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3acb488c4d6da414203412920be024eef9f7f0ed

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/testReport/

Max. process+thread count
4524 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 28s

branch-2 passed

+1 :green_heart:
compile
3m 30s

branch-2 passed

+1 :green_heart:
checkstyle
0m 44s

branch-2 passed

+1 :green_heart:
spotbugs
1m 46s

branch-2 passed

+1 :green_heart:
spotless
0m 52s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 57s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 45s

hbase-server: The patch generated 0 new + 62 unchanged - 1 fixed = 62 total (was 63)

+1 :green_heart:
spotbugs
1m 53s

the patch passed

+1 :green_heart:
hadoopcheck
23m 25s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
1m 11s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s

The patch does not generate ASF License warnings.

49m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 0476dc385ef7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 430c9eeb125e2ce43b5c9553d28ba9c25a322513

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 20s

branch-2 passed

+1 :green_heart:
compile
1m  9s

branch-2 passed

+1 :green_heart:
javadoc
0m 32s

branch-2 passed

+1 :green_heart:
shadedjars
6m 42s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 50s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed

+1 :green_heart:
shadedjars
6m 29s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
215m 22s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

245m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux d8f46596d79b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 430c9eeb125e2ce43b5c9553d28ba9c25a322513

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/testReport/

Max. process+thread count
4392 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 37s

branch-2 passed

+1 :green_heart:
compile
1m 19s

branch-2 passed

+1 :green_heart:
javadoc
0m 38s

branch-2 passed

+1 :green_heart:
shadedjars
7m 36s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 54s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed

+1 :green_heart:
shadedjars
7m 10s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
266m 46s

hbase-server in the patch passed.

299m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6219

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux d5dd15cdf55d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 430c9eeb125e2ce43b5c9553d28ba9c25a322513

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/testReport/

Max. process+thread count
4418 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6219/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Hi @wchevreuil,
The test failure seen for "org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS" seems to be random and not related to this change. The same test is also listed in the "Existing Failures".
The local execution of the test on my local branch, succeeded.
git Branch:
commit 34450be695ffb4dd63556fc8a376326b6bce4ce4 (HEAD -> branch-2-for-HBASE-28804)
Author: jhungund<EMAIL_ADDRESS>Date:   Mon Sep 9 18:44:15 2024 +0530
HBASE-28804:  Implement asynchronous retrieval of bucket-cache data from persistence (#6182)

Signed-off-by: Wellington Chevreuil<EMAIL_ADDRESS>Change-Id: I515d81fdc484cd49308d3164067a2287b8901520

Test Execution:
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/hbase-common-2.7.0-SNAPSHOT-tests.jar)
WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule$1 (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/hbase-common-2.7.0-SNAPSHOT-tests.jar)
WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule$1
WARNING: System::setSecurityManager will be removed in a future release
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.52 s - in org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Hence, this seems unrelated to the change.
Thanks,
Janardhan


.toBeGreaterThanOrEqual()

It would be nice to have >= and <= assertions.
Also, this alias may be good: .toCompare('>=', 5) (dont know how to name it!)

I think .toBeGreaterThanOrEqualTo is a good name. I'd be happy to accept a PR that does this.

I think ...OrEqual is better than ...OrEqualTo though, simply because it keeps parity with .toEqual, but that's just a minor nitpick on my part :)

Now that we have expect.extend we can leave this up to a 3rd party lib, no? You still want it in core?
Actually, I'm kind of thinking we could refactor our whole library to use extend internally... not sure it would be worth it though.

I like the idea of using extend() internally, but i'm with you that it's small enough that it doesn't warrant it.

Would be good to have this.
:+1:


remove this from the Learn page

i dont want the highlighted buttons so you can remove this

Hello @sanjay-kv Sir, i can fix this issue, can you please assign me the same?

Thanks for assigning me this issue, I'm working on it and adding my PR asap. @sanjay-kv

@sanjay-kv Sir, could you please tell me where is the code of the blog.html page

branch gh-pages


Possible to differentiate keypad from other keys?

I know I've seen it in other languages but so far nothing in any go packages strangely...
Is there some way to implement the ability to tell the difference between a key pressed on the keypad and a standard key?

I'm guessing there's a similar issue involved when trying to figure out if the user typed "Ctrl+PgDn" or "Shift+PgDn".  I'd love to be able to do that in a cross-platform way, but it just doesn't seem possible.

Yeah, the problem is that legacy terminals don’t always get these keys.
You can try to see what happens, but most often the window manager will
steal those key strokes and you’ll never see them at all.
On Thu, Apr 19, 2018 at 6:13 PM Brett Vickers<EMAIL_ADDRESS>wrote:

I'm guessing there's a similar issue involved when trying to figure out if
the user typed "Ctrl+PgDn" or "Shift+PgDn". I'd love to be able to do that
in a cross-platform way, but it just doesn't seem possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gdamore/tcell/issues/185#issuecomment-382931848, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPDfblzjhJXQRZYncCRHjQQvnDQPRydks5tqTYmgaJpZM4RVNwt
.

I have noticed that when using an xterm terminal, the modified versions of arrow keys and other keys (like PgDn, PgUp, etc.) often produce ANSI escape code sequences like ESC [ 1 ; 5 C.  Would it make sense to handle these somehow?

Yes, some of them are handled, but terminfo doesn’t know about all the
various ones.  Its made worse by the fact that there are a zillion terminal
emulators that pretend to be xterm, but have slightly different escapes for
some of this stuff.
On Fri, Apr 20, 2018 at 9:27 AM Brett Vickers<EMAIL_ADDRESS>wrote:

I have noticed that when using an xterm terminal, the modified versions of
arrow keys and other keys (like PgDn, PgUp, etc.) often produce ANSI escape
code sequences like ESC [ 1 ; 5 C. Would it make sense to handle these
somehow?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gdamore/tcell/issues/185#issuecomment-383150263, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPDfa4V3grBEIV_JmZQtaboKPIyK87oks5tqgxkgaJpZM4RVNwt
.

I'm concerned that changing this will break applications.  So I'm disinclined to make this change -- at least not unless there is a opt-in method available.


[fix]fix be core when migration tablet to other disk

The asynchronous task reference captures a local variable
Proposed changes
Issue Number: close #36809

run buildall

@bobhan1 @gavinchou @dataroaring Hi, Some regression cases failed and have nothing to do with modifications.


MetalDriver: Assert in debug mode due to recent SamplerGroups changes

Describe the bug
The following assert triggers after rebasing to latest changes to SamplerGroups.
https://github.com/google/filament/blob/main/filament/backend/src/metal/MetalDriver.mm#L876
After tracking it down, it happens with the texture mKernelTexture created by IBLPrefilterContext::SpecularFilter and involves the sampler group created by the default MaterialInstance of mIntegrationMaterial.
To Reproduce
Should be reproductible with anything that uses the IBLPrefilterContext

I'm having trouble reproducing with our samples that use IBLPrefilterContext. In particular, the usage in IBL.cpp does not seem to trigger it.
Does the assert fire 100% of the time for you? Is your app doing anything special?

Just as a sidenote: we rebased and hit the same issue again.
This time, we made the  IBLPrefilterContext::SpecularFilter live as long as the IBLPrefilterContext  until the engine is terminated,, and the problem  is gone.
The faulty texture is the kernel texture allocated in the SpecularFilter. For some reasons in our workload, if the SpecularFilter is destroyed to early (even after a flushAndWait()), the issue occurs.


Migrate to Github Actions

Replaces #75

Pull Request Test Coverage Report for Build 256

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.292%

Totals

Change from base Build 253:
0.0%

Covered Lines:
421

Relevant Lines:
424

💛  - Coveralls

Looks like it's failing on that docker stuff. Why is it in there, btw?

Looks like it's failing on that docker stuff. Why is it in there, btw?

Docker is used for cross compiling the core library for other platforms. It's tested in CI to ensure those build steps continue to work.


Malware Alert in Avast

fuse-3ds-1.0b8-win64.zip comes up in Avast as infected with Malware-gen.

does win32 show the same? both were built on the same virtual machine.

No issues with the 32-bit version. I'm on Win10, btw.

I will try re-building the win64 exe after completely removing Python 3.6.5 64-bit

try this newly built one: fuse-3ds-1.0b8-win64.zip

Clean as a whistle. I was a little worried and was holding off using this. Thanks!

MSE didn't detect anything fwiw.

release updated: https://github.com/ihaveamac/fuse-3ds/releases/tag/v1.0b8


[ZEPPELIN-474] Provide InterpreterContext as ThreadLocal value

This PR implements ZEPPELIN-474.
Let 3rd party library access InterpreterContext.

Looks good to me

I'm merging it into master


[feature suggestions] Pickaxes and shovels

Pickaxe: pickaxes pierce, so i think for pickaxes for each tier should have x damage guaranteed regardless of armor
Shovel: shovels have a wide face, so when you hit it should "stun" and stall the movement for a very short time
I also think you should try to implement the increased reach attack from combat tests. I know you dont want this to be a combat test clone but i think this seems to be the most compelling part of the combat update imo
Other notes:
The other two issues right now can be resolved with this client mod, but maybe not what you want to enforce on server: https://github.com/florensie/no-weak-attack
Bow and crossbow looting. i have seen many mods for every other tool except this. I think i can probably help with this because it is a simple mixin
Edit: had another idea: remove invincibility frames because when i shoot multishot it bounces off the target if more than 1 arrows hit

Hello, thanks for the ideas! I will need to split those in different issues I guess, and I'm not sure to do all of them but that's cool you share them =)

Shovel and pickaxe: this definitely needs me to think more about it. That could be a thing, I don't know, but this will need as usual to find the right balance if I add it. Give me time to think about it ;)
Reach: it should already be the same thing than combat snapshots, but I acknoledge I didn't test that much the combat snapshot. I will check again if it feels different but values are accurate
Weak attack: I don't think I want that if I understood what you wanted
Bow/Crossbow looting: why not. Bows are too OP so I don't know if it would be a nice thing but maybe with a different value than sword looting. Or only on crossbows to allow looting with range attack, just like looting is only available on sword and not (pick)axes.
Invicibility: that's a combat snapshot feature but if I'm right it applies only to projectile because otherwise you would get instantly killed by mob hords. I may add it in the future but I didn't think enough about it.

In a more general way, combat snapshots features are mostly good. I added the most important ones to me and the ones I was sure was a good idea (in my opinion). Others can be added if I think more about, but more importantly if I have time to add them, because modding is not my work so I do it in my free time.


Posterize

Hello, is there a Posterize filter? If not, would you be interested in a contribution?

Hello,
There's no such filter yet. Contributions are welcome!


custom_args support not working any more in Snapfile

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I use custom_args "GCC_PREPROCESSOR_DEFINITIONS='SCREENSHOTS'" in my Snapfile to build a version perfectly to generate screenshots.
This does not work any more now. I tried using custom_build_args however it does not work too.
Complete output when running fastlane, including the stack trace and command used
➜  xenim-ios-app git:(release/1.2) ✗ fastlane screenshots
[18:56:57]: -------------------------------------------------
[18:56:57]: --- Step: Verifying required fastlane version ---
[18:56:57]: -------------------------------------------------
[18:56:57]: fastlane version valid
[18:56:57]: ------------------------------
[18:56:57]: --- Step: default_platform ---
[18:56:57]: ------------------------------
[18:56:57]: Driving the lane 'ios screenshots' 🚀
[18:56:57]: -----------------------------
[18:56:57]: --- Step: update_fastlane ---
[18:56:57]: -----------------------------
[18:56:57]: Looking for updates for cert, credentials_manager, deliver, fastlane, fastlane_core, frameit, gym, match, pem, pilot, produce, scan, screengrab, sigh, snapshot, spaceship, supply...
[18:57:03]: Nothing to update ✅
[18:57:03]: ----------------------
[18:57:03]: --- Step: snapshot ---
[18:57:03]: ----------------------
[18:57:04]: Variable Dump:
[18:57:04]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios screenshots"}
[18:57:04]: Could not find option 'custom_build_args' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | update_fastlane                     | 6           |
| 4    | snapshot                            | 0           |
+------+-------------------------------------+-------------+

[18:57:04]: fastlane finished with errors

[!] Could not find option 'custom_build_args' in the list of available options: workspace, project, devices, languages, launch_arguments, output_directory, ios_version, skip_open_summary, clear_previous_screenshots, reinstall_app, erase_simulator, localize_simulator, app_identifier, add_photos, add_videos, buildlog_path, clean, configuration, xcpretty_args, sdk, scheme, number_of_retries, stop_after_first_error, derived_data_path

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
  desc "Generate screenshots for all supported devices"
  lane :screenshots do
    snapshot(configuration: "Debug")

    # currently frameit not required
    # frameit
  end

Environment
fastlane version (run fastlane -v): fastlane 1.89.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No.
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? rbenv

@funkenstrahlen Thanks for reaching out. Right now we don't support this. I'll mark this as a feature request since the launch_arguments parameter doesn't cover your use case. I'm going to mark this as help wanted in case anyone from the community wants to take a look 👍

So why did this feature get removed? Or did it not work before and it just did not throw an error?

Hi @funkenstrahlen Thanks for asking this was retired in favor of launch arguments and xcpretty arguments. I'll leave this ticket open because I'm curious to know if anyone else is trying to do this 👍

I am open to alternatives. I have only one usecase: There is a framework changing the look of the statusbar in the simulator, so I can generate nice screenshots via snapshot. This framework does access Apple private API though, so I can not ship it to iTunes Connect. I want the framework only to be linked if I run snapshot.

@funkenstrahlen Thanks for following up. What happens if you link the framework to it's own test target in Xcode and then setup snapshot on that test target?

@funkenstrahlen Have you found a solution for this problem? Because I'm also looking for a solution.

Hi @Sef1995! Thanks for followin gup on this. Can you provide your full input and output? I'd love to take a look.


Corrected ES5 for-in destructuring binding emit

Although it's not permitted in the checker to use an array or object binding pattern ("destructuring") as the iterating variable in a for..in loop, TypeScript can still output the syntax. This corrects the emitter to correctly destructure the variables in the body of the loop. Previously they were incorrectly being bound in the iteration statement.
I'm not particularly satisfied with how this code shaped up. There's some duplication in the convertForInStatementForLoop* functions, but just small enough of it that I didn't extract into a shared function... does anyone see a cleaner approach?
Fixes #2272

We discussed this in the design meeting today, and while we appreciate the effort that went into putting together this PR, unfortunately we will not be taking this change. There are several factors involved:

The downlevel emit for ES5 is not compliant with ES2015 semantics with respect to surrogate pairs.
Supporting true ES2015 string iteration via a helper would overcomplicate the existing helpers and add a fairly large amount of extra code at the top of any file using array destructuring downlevel.
We already report an error for this, and it is not the only case where we may emit invalid JavaScript in the presence of a reported error (which is one of the reasons --noEmitOnError exists as a compiler option).

However, since this is legal ES2015, we may consider removing the error for --target ES2015 and higher.

We discussed this in the design meeting today, and while we appreciate the effort that went into putting together this PR, unfortunately we will not be taking this change. There are several factors involved:

The downlevel emit for ES5 is not compliant with ES2015 semantics with respect to surrogate pairs.
Supporting true ES2015 string iteration via a helper would overcomplicate the existing helpers and add a fairly large amount of extra code at the top of any file using array destructuring downlevel.
We already report an error for this, and it is not the only case where we may emit invalid JavaScript in the presence of a reported error (which is one of the reasons --noEmitOnError exists as a compiler option).

However, since this is legal ES2015, we may consider removing the error for --target ES2015 and higher.


DPL-027 [BUG] Sample edit page adding consent withdrawn metadata

When editing a sample date_of_consent_withdrawn and user_id_of_consent_withdrawn is being saved in the sample_metadata.
Note: The consent_withdrawn flag is NOT being set.
This combined with
https://github.com/sanger/sequencescape/issues/2937
https://github.com/sanger/sequencescape/issues/3104
makes sample editing a conduit for bad data
example id: 4495321, name: “CV001_KM8853544”
When fixed the affected data will require fixing
select count(*) from sample_metadata where date_of_consent_withdrawn is not null and consent_withdrawn = 0
800 records

For data update:
samples = Sample.joins(:sample_metadata).where('sample_metadata.consent_withdrawn = 0 AND sample_metadata.date_of_consent_withdrawn IS NOT NULL')

samples.each do |s|
  s.sample_metadata.update!(date_of_consent_withdrawn: nil, user_id_of_consent_withdrawn: nil)
end

Spun out data fix into https://github.com/sanger/sequencescape/issues/3213


Can I skip the step that incorporate the coverage biases in HSats?

Hi,
I would like to run this pipeline in a plant genome. I would like to skip the step4 "incorporation coverage biases in HSats". How I could achieve this if I want to run "flagger_end_to_end_no_variant_calling_no_ref.wdl"?.
Many thanks.

Hi @ericgonzalezs
Yes you can use "flagger_end_to_end_no_variant_calling_no_ref.wdl" using the instructions mentioned here:
https://github.com/mobinasri/flagger#running-pipeline-with-wdl
It will ignores incorporation coverage biases in HSats.


[WIP] bootstrap: Ensure that BPFFS is mounted on the host

Before this change, some environments and SLE installations did not have
the BPFFS mount on the host, which resulted in the following warning in
Cilium:
level=warning msg="================================= WARNING ==========================================" subsys=bpf
level=warning msg="BPF filesystem is not mounted. This will lead to network disruption when Cilium pods" subsys=bpf
level=warning msg="are restarted. Ensure that the BPF filesystem is mounted in the host." subsys=bpf
level=warning msg="https://docs.cilium.io/en/stable/kubernetes/requirements/#mounted-bpf-filesystem" subsys=bpf
level=warning msg="====================================================================================" subsys=bpf

This warning means that restarts of Cilium pod can lead to the small
downtime, because all the BPFFS structure and BPF maps need to be
regenerated after the next BPFFS mount.
This change fixes that behavior and ensures that BPFFS is always
available before Cilium gets deployed.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

@mrostecki I've filed https://bugzilla.suse.com/show_bug.cgi?id=1146991 - please ensure you add the bsc#1146991 tag inside of the final commits

FYI - this PR is still not ready - for some reason the entry in /etc/fstab doesn't get added.

Now it fully works, please review.

@ereslibre I don't think so. Upgrades shouldn't remove the line from /etc/fstab or manipulate with fstab or partitions in any way, so inserting it just during deployment should be fine. Or am I wrong?
TBF that issue should be fixed in SUSE cloud images some day - I mean they should have the bpffs mount in fstab. But this is the temporary workaround before that happend.

@ereslibre I don't think so. Upgrades shouldn't remove the line from /etc/fstab or manipulate with fstab or partitions in any way, so inserting it just during deployment should be fine. Or am I wrong?

If a user deployed CaaSP 4.0 on a set of nodes without this change, they won't have this entry on fstab; as part of the upgrade to a newer version we should enforce the creation of these fstab entries. Or should this be documented to be done manually by the customer on an existing cluster?

If a user deployed CaaSP 4.0 on a set of nodes without this change, they won't have this entry on fstab; as part of the upgrade to a newer version we should enforce the creation of these fstab entries. Or should this be documented to be done manually by the customer on an existing cluster?

OK, yes, you are right. Please disregard my previous comment. I will add that as an upgrade step in a follow up PR.

OK, yes, you are right. Please disregard my previous comment. I will add that as an upgrade step in a follow up PR.

The only problem I see right now is that we don't have the concept of "upgrade" without bumping the Kubernetes version (so we don't have a way currently to push this kind of fixes by an upgrade that won't touch Kubernetes versions). Maybe while we put some thought on this we can document this so they add the entry by hand. WDYT?

@ereslibre Good idea.
TBH I would really like to see the proper fix in cloud images. I'm even thinking whether we should drop this PR in general and instead:

document the issue for people who already deployed clusters
put the bpffs mount in cloud-init
ping public cloud teams to prepare images with bpffs enabled in /etc/fstab, or make the needed changes ourselves in OBS and IBS

I agree it's quite surprising to not have this mounted by default on sles.
If people change their cloud init it would be easy to forget it.
I like the fact it's included in the bootstrap of skuba, and I think a release note for the upgrades would be good enough, myself. But I am a nobody here, merely a user :)

* ping public cloud teams to prepare images with bpffs enabled in /etc/fstab, or make the needed changes ourselves in OBS and IBS

ping @rjschwei how should we file this request?

@flavio any update on the follow up?

I didn't have a follow up from @rjschwei yet. We are going to have a follow up with the public cloud about a bunch of topics.
In the meantime, @mrostecki: let's not be focused on the AWS case. Is this something that is currently broken on regular SLE systems as well?
I'm thinking about what you wrote inside of https://github.com/SUSE/skuba/pull/598#issuecomment-531788553. Maybe the proper fix is to document it and get everything sorted out inside of the VMware/OpenStack/Public cloud images and on bare metal.

We agreed that this ticket can be closed in favor of the change to the unit file change originating at https://build.suse.de/request/show/203856, right?  I'm closing it; feel free to reopen if I misunderstood. :)


Is there a way to manually call the export function?

Is there a way to manually call the export function on the button, so you can do some stuff before the export starts? Something like this:
<button mat-button (click)="myExportFunction()">EXPORT</button>

myExportFunction() {
    doSomething();
    matTableExporterFunction();
}

Great extension!

Many thanks for the feedback.
Yes, actually the exportStarted event is emitted just before the real exporting happens. You can listen to that event.
component template
<mat-table .........  (exportStarted)="onExportStarted()">
component.ts

onExportStarted() {
alert('export started');
}

Oh excellent! I did not read the documentation thoroughly enough. Thank you!


This is a small commit to test caching

Changes
Add a summary of the changes in this pull request
Checklist

[ ] Attach this pull request to the appropriate card in Trello.
[ ] Update the CHANGELOG.md if needed.

Happy with this. closing.


Update javascript-destructuring-assignment.md

In Array destructuring example the skip value mentioned in the comment should be 9, not 12.

Thankyou 😊


Update sbt-scoverage to 1.8.1

Updates org.scoverage:sbt-scoverage from 1.8.0 to 1.8.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #360 (6be76ce) into master (864fff8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   99.51%   99.51%
=======================================
  Files           7        7
  Lines         410      410
  Branches       41       41
=======================================
  Hits          408      408
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 864fff8...6be76ce. Read the comment docs.


[BUG] VM can’t boot due to filesystem corruption

Describe the bug
When running VMs on harvester, rarely the VMs could not boot up due to filesystem corruption.
To Reproduce
Steps to reproduce the behavior:

Start VM
Run IO on VM
delete any one of the replicas and stop VM (parallel operations)
loop from step 1

If we meet the above issue, Start VM would be stuck.
Expected behavior
Works normally. Turn on/off VM would be OK.
Support bundle
Environment

Harvester ISO version: v1.0.3

Additional context
This happens when volume rebuilding is involved, for example, turning on/off VMs and powering cycle hosts.
It seems related to https://github.com/longhorn/longhorn/issues/4354

@guangbochen  - what type of filesystem do you run within your VM? Can you add details?
I believe if you use a filesystem with 4k I/O size instead of 512 bytes you might not be able to reproduce..

We running with OpenSUSE-Leap-15.3, the root filesystem is XFS with 512 sector size.
We could reproduce the corruption issue in the above environment with harvester v1.0.3.

For v1.0.3, the current workaround is to re-generate the cloud image to use a filesystem with 4k sector size for metadata/data/log.
We could see the related fix ([BUG] data corruption due to COW and block size not being aligned during rebuilding replicas) is involved in Longhorn v1.3.2. So we could verify this with LH v1.3.2

Update with test result on my local environment, QA would do a whole test including the regression.
environment rootfs:
vm001:~ # xfs_info /dev/vda3
meta-data=/dev/vda3              isize=512    agcount=4, agsize=653887 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=0, rmapbt=0
         =                       reflink=0
data     =                       bsize=4096   blocks=2615547, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=2560, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0

tested with the following steps:

start VM
run 4k random write IO / Delete random replica  (these two operations are parallel)
wait 20-60 seconds then stop VM
loop back to 1.

pass 626 rounds and do not meet any corruption issues.

Verified fixed on Harvester master-5ee476dd-head (10/12) with Longhorn v1.3.2-rc2 merged.
Test Result

Pass 586 round of the I/O write test, did not encounter data corruption issue and VM is alive

opensuse:~ # xfs_info /dev/vda3
meta-data=/dev/vda3              isize=512    agcount=13, agsize=653887 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=0, rmapbt=0
         =                       reflink=0
data     =                       bsize=4096   blocks=7858427, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=2560, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0

Test Information

Test Environment: 3 nodes harvester on local kvm machine
Harvester version: master-5ee476dd-head (10/12)

Verification steps
Execute the python script provide by team member to execute start and stop VM
which will execute fio command to run I/O test
And use another shell script to delete replica paralleled with I/O write test.

Start VM
run 4k random write IO / Delete random replica (these two operations are parallel)
wait 20-60 seconds then stop VM
loop back to 1.

Pass the following volume operation regression test:

Create volume (Harvester, Longhorn storage class)
Create volume from image
Unmount volume from VM
Delete volume in use and not in use
Export volume to image
Edit volume to increase size
Delete volume in use
Clone volume
Take volume snapshot
Restore volume snapshot

Verified fixed on Harvester master-5ee476dd-head (10/12) with Longhorn v1.3.2-rc2 on data corruption.
And also pass the volume related regression test as listed above. Close this issue.