Incompatible with sodium version 0.5.8 for minecraft version 1.20.1

Describe the Bug
Incompatible mods found!
A potential solution has been determined, this may resolve your problem:
- Replace mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 with any version that is compatible with:
- sodium 0.5.8+mc1.20.1
More details:
- Mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 is incompatible with version 0.5.0 or later of mod 'Sodium' (sodium), but a matching version is present: 0.5.8+mc1.20.1!
Reproduction Steps

install sodium 0.5.8 for minecraft version 1.20.1
install create
3.run the game
...

Expected Result
Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
- Replace mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 with any version that is compatible with:
- sodium 0.5.8+mc1.20.1
More details:
- Mod 'Create' (create) 0.5.1-d-build.1161+mc1.20.1 is incompatible with version 0.5.0 or later of mod 'Sodium' (sodium), but a matching version is present: 0.5.8+mc1.20.1!
at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51)
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:195)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:243)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:278)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
sodium version 0.5.8 on mincreaft 1.20.1
Additional Context
No response

currently create 0.5.1d sodium 0.4.10 fabric api 0.88.1 iris 1.6.4 and indium 1.0.21 are the precise versions you want.
a fix is in the works

Dupe of #1039

is there a planned release date, any communication is helpeful, sorry if im being pushy, i understand this is a large project

there is not


Points on the map don't appear immediately after adding a point

When adding a point, we are redirected to the /thanks page, which has a link to the /map page.  However, when following the link, the point that was just added does not appear. Reloading the page is enough to see the new point appear.
My guess is that the JSON file is generated after the request is served, and not before, so that the old version of the JSON is used for the first request.

Reproduced, not figured out yet, on /map right after adding a point the public.json downloaded is ok (containing the last point added)...

GeoJSON file is rebuild during the 'POST' route, right before redirecting to the /thanks page, see https://github.com/JocelynDelalande/wifi-with-me/blob/master/backend.py#L204
Maybe we could juste add a random query string to the GeoJSON file, to bypass browser cache.

Maybe we could juste add a random query string to the GeoJSON file, to
bypass browser cache.

It's worth a try :)

@opi You inspired me :)
I tried (as exercice for me, I have to admit) to do it a better way using file actual json modification time instead of curent clock as querystring. What do you think ?
@zorun can you confirm it now works for you ?


StripNick from one bridge is modifying nicks for all next bridges in queue

the original rmsg object is modified inside Gateway.modifyUsername()

I will create a PR soon


PHP 8 error: method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given

There is a type error when using the operator get for PHP8.
Problem:
src/hasDirect.php in method_exists at line 36
https://github.com/mpetrovich/dash/blob/bd6ec108638dcf6942439779cd7b1c5fcb03be83/src/hasDirect.php#L27-L37

Thanks for reporting! Dash isn't currently tested against PHP 8, but I'll make sure it is and will fix errors like this one.

Thanks for reporting! Dash isn't currently tested against PHP 8, but I'll make sure it is and will fix errors like this one.

I don't have bandwidth to address this issue right now, but I welcome all PRs if anyone would like to contribute.

Fixed in v4.0.0

Argh, for some reason my git wrangling clobbered your original commits, so you won't get the proper attribution :(


Silence sed warning

To silence the following error message from sed, apply the patch below:
sed: character class syntax is [[:space:]], not [:space:]
Patch:
diff --git a/updBlackList.sh b/updBlackList.sh
index d04caca..246b9d0 100755
--- a/updBlackList.sh
+++ b/updBlackList.sh
@@ -475,7 +475,7 @@ doProcess4()
     cat ${flBlockList} | \
         sed -e '/^[;#]/d' \
             -e '/ERROR/d' \
-            -e '/[:\::]/d' \
+            -e '/[\:\::]/d' \
             -e 's/ .*//g' \
             -e 's#//.*##g' \
             -e 's/[^0-9,.,/]*//g' \

I do not receive this error.  Are you running this on your edgerouter or elsewhere?  On  edgeos 'sed' is actually the busybox implementation.

Yes. I get this error running on ER4 under 2.0 beta-3

Ah - You probably mean 2.0.0-alpha.3.   FYI that is actually not a beta and is actually a still in-development alpha that is currently still undergoing significant changes.  I do not see the error on alpha-2, for instance.
Once that version moves into a beta (it has not yet) I will be testing there but until then it is still far too early to try to chase as the platform is still in too great of a state of change.
I'll keep this open to track until then.

You’re right, it’s alpha3. UBNT upgraded to Debian stretch on this version.

On Sep 14, 2018, at 2:09 PM, WaterByWind<EMAIL_ADDRESS>wrote:
Ah - You probably mean 2.0.0-alpha.3. FYI that is actually not a beta and is actually a still in-development alpha that is currently still undergoing significant changes. I do not see the error on alpha-2, for instance.
Once that version moves into a beta (it has not yet) I will be testing there but until then it is still far too early to try to chase as the platform is still in too great of a state of change.
I'll keep this open to track until then.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I've pushed this minor update (finally).  It has been working on both 1.x and 2.x releases for me and it just took me finding the 30 seconds to publish it. . .


Outdated screenshot and portal menu options

I am not seeing "Advanced Access Policy" blade for Key Vault resource anymore. I see the options under "Access Policies" blade. I assume UI changed however the screen shot was not updated

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26bcd765-e7de-c91e-2193-a6b7c166ed05
Version Independent ID: 6432a759-9995-e08a-ee31-6077fefca464
Content: Creating and configuring a key vault for Azure Disk Encryption on a Windows VM - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/disk-encryption-key-vault.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@TharinduK Thanks for the feedback. We are investigating the issue and will update you shortly.

Hello @msmbaldwin , could you please evaluate this document update request and update it as required.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Request to shorten adyen status codes in order grid

Hi, we show the adyen status codes in order grid
The problem is that the text is in ALL CAPS and is taking a lot of space in the grid
Would it be possible to make this a stoplight? Or other?
Red = False
Green = True
ORange = Waiting?
None = none
or the letters
F
T
delta symbol
Appreciate it

Hi Sean,
That is a good idea. The value in the database field needs to be the same because of supporting older versions of the module. I think it is possible to change the grid view to have a better look and feel this is something that needs to be investigated. At the moment not a high priority.
Regards,
Rik
Adyen


Getting a column should be 1-indexed

Silly mistake, but a column should be 1-indexed. For example:
const sourceFile = project.createSourceFile("test.ts", "");
sourceFile.getColumnAtPos(0); // should be 1 and not 0

This applies to getColumnAtPos, getStartColumn and getEndColumn.

Hmmm... I was looking in visual studio and noticed there's "col" and "ch"... looking it up: https://stackoverflow.com/questions/19226060/what-is-the-col-value-in-visual-studio-text-editor

The difference between column and character positions is evident for characters such as the tab character that can incorporate more than one column

So I have getColumn-like methods implemented completely wrong. I don't think it makes sense to have this function in ts-simple-ast because properly implemented it depends on how the character is displayed (ex. font, character design, tab size).
I'm going to deprecate these methods and replace them with sourceFile.getCharCountFromLineStartAtPos(pos); (can't think of a better name atm).


Update Controls/index.tsx: Updating ControlButton element from div to button.

Updating ControlButton element from div to button.

Hi, this is for accessibility. This change would enable focus to Controls via Keyboard Navigation

hey @itstushargarg
this is a good point. Why did you close the PR?


feat(image): optionally add image captions from alt tags

This PR introduces a new option named extractImageCaptions to enable image captions.
Input
![An elephant at sunset](/elephant.jpg)

Output
(newlines added for PR readability, not included in code)

An elephant at sunset

The inspiration for the output markup was taken from here:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption
Help Request: While the paragraph tags don't really hurt, they would ideally be removed. Any advice?

I will pay $10 via PayPal to get this merged.
/cc @tivie

I've been swamped in work lately, but will use the xmas vacations to look into this.

PR has been updated to include the dist files.

@tivie I'm interested in this feature. Is there an alternative way to get something equivalent now with 2.0? If not, can you get this merged?

@marcelogp - this feature has already been added & is ready to use.
Tho - I don't know why this pull request was never merged from @tlhunter to implement it with his work done already! :disappointed:
Hoping @tivie is willing to close this PR to avoiding causing any future confusion.

ps - @tivie let's clean up some of these issues etc - feel free to get in contact with me etc.


Add arm64 support

Current dependencies on/for this PR:

master

PR #1   👈

This comment was auto-generated by Graphite.


Longer videos and textual inversions and fp16 autocast

Added the ability to choose separately the length of a video and the size of the context of the temporal attention module. By using a sliding window of attention it is now possible to generate infinitely long GIFs.
Sliding window related parameters:
--L - the length of the generated animation.
--context_length - the length of the sliding window (limited by motion modules capacity), default to L.
--context_overlap - how much neighbouring contexts overlap. By default context_length / 2
--context_stride - (2^context_stride) is a max stride between 2 neighbour frames. By default 0

Added support for .pt textual inversions from civit.ai that should be put in models/embeddings directory. Though I'm not very sure if this implementation is fully correct, but works fine for me.

Now inference automatically uses torch.autocast to fp16 if --fp32 is not specified. It sped things up by 100% in my tests.

Thank you dajes for your contribution! I've tested the fp16 autocast on my 4090 and the speed increases are x4. From 55s per gif I went down to 15s/gif.

Any chance you would be interested in figuring out how to add embeddings or the context stride to this repo? https://github.com/neggles/animatediff-cli

Any chance you would be interested in figuring out how to add embeddings or the context stride to this repo? https://github.com/neggles/animatediff-cli

actually I was able to get it to work, nevermind!

Just a reminder, for users looking at this who have an old Maxwell card like the Tesla M40 , the fp16 mode actually causes a 3x slowdown instead of 3x speed boost, so use fp32 for Maxwell cards. Maxwell doesn't have dedicated fp16 hardware. Found this out the hard way haha.

Is this PR merged any where?

Is this PR merged any where?

AFAIK this technique is used in https://github.com/neggles/animatediff-cli https://github.com/magic-research/magic-animate


double line issue

Since today I have the following issue:
When pressing enter two new lines will be created within a comment.
Let's say you're creating a new comment. The the following will come up:
    /**
     *
     * [cursor]
     */

What I expect:
    /**
     * [cursor]
     */

Same for //.

It seems like Atom's "enter" key event isn't being cancelled after triggering Docblockr.

Cant seem to reproduce it..

This is what happens for me.

@clayfreeman  is that java?

I am in the same room as @clayfreeman and I am not having the same problem but I am on windows. Is it a mac issue?

@nikhilkalige No, C++

void asdf() {

};
/**
 *
 */
//
//
struct melvin_data_t {
  int value = 16;
}

:( . This doesn't make sense at all.. I think there may be some package collision

I disabled all my community extensions and re-enabled them and now it's working as expected. Weird!

As @nikhilkalige already pointed out this seams to happen due to a collision of two keybindings. You can debug this kind of problems using the Keybinding Resolver (ctrl-.). This way you can find out what keybinding causes the problem and change or remove the keybinding.
I guess if both keybindings have the same selector, atom determines which one to use by the order you installed the packege that added the keybinding. This could explain why disabling and again enabling solved the problem for @clayfreeman.

I have this same problem for Javascript on OS X. Pressing enter inside a block produces the equivalent of pressing enter 3 times. I don't think I have an conflicts here, rather the 3 new lines are the result of docblockr, then the base atom action, then the core OS X action.
/** <enter> results in:
/**
 *
 *
 *
 */

Here's my keybinding resolver from this action:

Seems like docblockr isn't eating the enter keypress here.

At least in @mattweir10's example the events seam fine. The docblockr:parse-enter command is the only used command. editor:newline has a matching selector, but is not applied  because docblockr:parse-enter comes first.
Dose this only happen with if you press /** enter or even if you press /** tab?

By looking at the image that's what I thought too. But I just cannot reproduce the same error

On my GNU/Linux computer I can't reproduce it too. I guess it really is a OSX only issue.

@MoritzKn Nope, I'm using Windows 7.

For some reason it was solved for me today, didn't updated something manually. Feel free to reopen if you still experience this issue.


Create PPT for demo day

User story

As a team
We need a demo day PPT
So that we can present our AMOS project for 20 minutes

Acceptance criteria

Created a PPT for the AMOS demo day

Definition of done (DoD)

Linter & Checker were performed and passed
Code Review has been completed
Code was merged in sprint release candidate
Updates are written in issue comments
Feature builds and tests successfully
Acceptance by product owner
User Story & Acceptance Criteria fulfilled

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Reuse from demo day video.


[Doc Improvement][Update on command palette steps][3264909]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/add-resource.md
95
2
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Set permissions

Use the Drive API to set permissions for documents created through GDataDB, so they can be shared with personal accounts and thus opened with the Drive web UI.

I make a method that add permission in the file
var request = _requestFactory.CreateRequest();
request.Headers.Set("Content-Type", "application/json");
var data = JsonConvert.SerializeObject(new {
        role = role,
        type = type,
        value = email
});
request.UploadString(string.Format("https://www.googleapis.com/drive/v2/files/{0}/permissions", this._id), data);


HTTP request error about identify public IP

Error
Error: HTTP request error. Response code: 403

  on modules/sec/net.tf line 1, in data "http" "ip":
   1: data "http" "ip" {

https://stackoverflow.com/questions/46763287/i-want-to-identify-the-public-ip-of-the-terraform-execution-environment-and-add

https://ipv4.icanhazip.com


Source collection and badge data on page

Figure out where we're going to pull these fields from.
Net Worth field will probably be disabled for the time being unless we stumble upon a dope way to source it.

Hmmm interesting, I imagined we could partner with someone like DefiLlama if we don't want to write our own.

For this, we will be using DefiLlamas API. Ideally, because they are such an incredible and productive member of the ecosystem, we will be able to spotlight that they are the data source for this material.
Right now, the current design does not handle that, but it will eventually. For now, we will utilize the API. If needed, I can write the aggregation logic for the front end. Potentially even this could be stuffed into the backend.


Title tag in many elements as possibile

Labels are often useless because of their numbers. In some viz it is possible to hide them (ie. circle packing), but not in all (ie. clustered force layout). Also without labels, it could be useful identify each element, for example using tooltip generated by title tags. So I suggest to add a title tag to every element (circle, bar, ...) when possibile and useful. Thanks! :)

We updated some of the visual models in this direction. We will keep this issue open until we will update all of them.


Deprecate renderIntoDocument()

The fundamental (and great) aspect of this library is:

The more your tests resemble the way your software is used, the more confidence they can give you.

I've watched all your talks and you keep saying that Simulate is a bad idea (even Dan Abramov told us that, if I'm not wrong) and I really agree with you!
We all want to make testing easier, and the only confusing thing that I see in this great library is having two render methods.
My suggestion is that we just deprecate renderIntoDocument() and move renderIntoDocument()'s behavior to render().
I don't see any reason to use render() over renderIntoDocument().

Thanks for bringing this up. As soon as this is done then I will be willing to do that. Until then, we have to have the cleanup method and I think that would be annoying/confusing as well. I'm happy to hear other's thoughts on the matter though.

We could encourage people to have a beforeEach that cleans things up, but that'd be annoying and reduce the simplicity.

I think having a beforeEach(cleanup) is a lot simpler than having both render(), renderIntoDocument(), Simulate, having to explain when to use element.click() over Simulate.click(), and having to explain why the consumer can't use element.click() or element.focus() if he is using render().
Other than that, we can't really trust Simulate, so the additional beforeEach(cleanup) effort would be fine as the trade-off would be increasing confidence.
For me, cleanup is part of the testing process. To make things more clear we could rename cleanup() to removeRenderedContainerFromDocument or something like that.

You make good points. And honestly, many people have a testSetup file where they they could do this repetitive work and reduce that friction.

Yeah, we could import something like react-testing-library/auto-cleanup in setupTests.js.

What if we did it automatically 🤔 Like put this at the top of our main file:
if (typeof beforeEach !== undefined) {
  beforeEach(cleanup)
}

Hmmmm..... Why would that be bad?

The only problem I see is that then important the library would cause a side effect, which is a bad thing.

We could change a bit the render() usage:
test('sync test', () => {
  render(<Login />, ({ getByLabelText }) => {
    getByLabelText('username')
    getByLabelText('username').value = 'chucknorris'
  })
})

test('async test', () => {
  render(<Login />, async ({ getByLabelText }) => {
    await wait(() => getByLabelText('username'))
    getByLabelText('username').value = 'chucknorris'
  })
})

The implementation:
const render = async (..., callback) => {
  const publicAPI = ...
  await callback(publicAPI)

  document.body.removeChild(container)
  ReactDOM.unmountComponentAtNode(container)
}

Thanks for the ideas! I'm not sure that makes things any simpler. I feel like it would be a step backward.

The only problem I see is that then importing the library would cause a side effect, which is a bad thing.

I can understand that perspective. The side-effect is basically unobservable though so I think it'd probably be ok, but I wont push it.
I think I'm in favor of just deprecating renderIntoDocument and putting its logic into render as you originally suggested. Then we'd just tell people to make sure to have a beforeEach(cleanup) configured. We could also expose a module as you suggested. So people could do:
import 'react-testing-library/cleanup'
import {render} from 'react-testing-library'

I don't think that's too much to ask.
We could also re-export everything from cleanup:
import {render} from 'react-testing-library/cleanup'

Thoughts?

For me the best approach would be suggesting the users to import react-testing-library/cleanup on their global test setup script or import it on every test if they don't have a global test setup script.
Also if they call render() and we didn't detect that cleanup() was called we could throw an error.
import {render} from 'react-testing-library/cleanup'
I like the simplicity of it and I dislike that it's not very semantic. But I'm not opposed to it, I don't see any other problems than the semantic issue.

I agree with what you said! Though

Also if they call render() and we didn't detect that cleanup() was called we could throw an error.

How do you propose we do that?

Hum...
let willCleanup = false

function render() {
  if (!willCleanup) throw new Error("You forgot to import `react-testing-library/cleanup`!")
  // ...
}

function cleanup() {
  // ...
  willCleanup = true
}

It would work?

Unfortunately not. It's totally valid to call render multiple times before a cleanup

Yes, but import 'react-testing-library/cleanup' is a side effect, so it would run before the test itself.

Ahh... My code is wrong, what I really want is that important react-testing-library/cleanup' sets willCleanup` to true.

What about:
// index.js

let willCleanup = false

function render() {
  if (!willCleanup) throw new Error(`You forgot to import "react-testing-library/cleanup"!`)
  // ...
}

function setupCleanup(beforeEach = beforeEach) {
  if (beforeEach !== undefined) {
    beforeEach(cleanup)
    willCleanup = true
  }
}

export { render, setupCleanup }

// cleanup.js

import { setupCleanup } from "./""

setupCleanup()

If beforeEach is not available, the user can import setupCleanup himself and pass the correct beforeEach fn.

Yes, but import 'react-testing-library/cleanup' is a side effect, so it would run before the test itself.

That's not a problem though. We just need to register an afterEach(cleanup) which shouldn't be a problem at all.

I'm thinking that what I want to do is start off without have a react-testing-library/cleanup file and just do as simple as possible. Remove Simulate, replace render with renderIntoDocument, and publish a breaking change. I think I'll work on this myself.

@kentcdodds sounds like a good plan.

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add thread name in the error message when thread creation fails.

This PR adds thread name in the error message when thread creation fails. It helps with debugging when thread creation fails.

@hawkinsp would you mind taking a look? Thanks.

@rohan100jain do you know about the windows bazel failure? Why is it happening only on windowns?

@allenlavoie thanks for the approval. Please let me know when it can be merged.

@burgerkingeater useful diff, thanks!


[5.7] Fix Argon2id hasher class name, check method and add tests

Follow-up to https://github.com/laravel/framework/pull/25085 and https://github.com/laravel/framework/commit/bbe08b01fea3b4f3f9d2979ea10e1150efbe7c20

Tests are failing.

@taylorotwell I thought it was weird that the tests were failing as they were passing locally for me, turns out you had a typo (the class name and the file name were different - Argon2IdHasher vs Argon2idHasher 😛 )


DOCS-602: Fixes syntax for a note

Fixes https://tigera.atlassian.net/browse/DOCS-602

@bmckercher123 Can you take a look? Thanks!


🐛 Stylelint: "customSyntax" config is not recognised as dependency usage

Prerequisites

[X] I'm using the latest version
[X] I've read the relevant documentation
[X] I've searched for existing issues
[X] I've checked the list of known issues
[X] I've read the issue reproduction guide

Reproduction url
https://codesandbox.io/p/sandbox/zealous-northcutt-g94nf7
Reproduction access

[X] I've made sure the reproduction is publicly accessible

Description of the issue
Including "customSyntax": "postcss-less"  in the stylelint config does not mark postcss-less as a used dependency. knip definitely detects the config file correctly, but there is nothing in the plugin code that checks this field. https://github.com/webpro-nl/knip/blob/main/packages/knip/src/plugins/stylelint/index.ts
Knip produces the following report:
Unused devDependencies (1)
postcss-less  package.json

Workaround
By switching to a JS config, you can do
"customSyntax": require.resolve("postcss-less")

which causes the dependency to be correctly marked as used.

I'll try to raise a PR for this at some point, for now it's just a nice-to-have so that knip works better out-of-the-box.

Sounds great, thanks in advance! Let me know if you need anything.


Replace JSON rendering with better looking component

Fixes #206.
This involves adding a piece of metadata to the schema, listingKey. This is to be specified at the same level as a required field, and specifies which of the properties of an object should be used to represent it at a top level. I'm open to suggestions about renaming this field to whatever best suits it, but I just chose a name to get moving on it. @satra It would be good for you to confirm that the listingKey I specified on each property is actually what it should be. Most of the time it's name, but does vary.
This also adds a component, DandisetLandingView/ListingComponent.vue, which is recursive and is only used in the DandisetLandingView page.

@AlmightyYakob - for now this is great. the listingKeys are fine and we can always change those in the short term.

The UI side looks good, much improved!, but does this make sense to add to the schema, or should we put it in the UI code somewhere, this listing key? This relates to the MVC separation that we had talked about before. Is listingKey something that describes the data or describes how the data should be visualized in this specific case? I want to be careful about polluting the schema.

@mgrauer - i would be ok in the short term of adding this into the schema, but with pending schema updates to refactor the component based on the new schema. we will want to do a few things regarding customized display where contributors would look more like zenodo lists, add an ordering index to contributors, etc.,., and we will need to generate a citation. so we will likely have to create a DLP component that is quite custom and we can move some of that information out of the schema.
all of that is to say that let's keep this to improve the display and then figure out the better path forward alongside the revised schema.

The UI side looks good, much improved!, but does this make sense to add to the schema, or should we put it in the UI code somewhere, this listing key? This relates to the MVC separation that we had talked about before.

IMO it would be messy to specify this in the code, as we'd basically have to duplicate the schema for the sole purpose of specifying this data.

Is listingKey something that describes the data or describes how the data should be visualized in this specific case? I want to be careful about polluting the schema.

I think it's fair to say that this describes the data, as it basically specifies the "Primary Key" of an object. I'd actually say primaryKey would be a better name than listingKey, as it better describes the semantics of it.

Given that @satra is ok with this, and he can represent for the schema side of things, I withdraw that objection. I would ask a related question: how are we versioning the schema or representing the stability of the schema API? It might be fine to change/break it for now, but get some idea of API promises on the horizon.
@AlmightyYakob I get your point, that is reasonable for now too. Maybe you should change the name to primaryKey? Is there a way to make it a required property/key, given that you want to call it a primary key?
My conceptual QA is done, and this generally passes, but we still need a code QA.

how are we versioning the schema or representing the stability of the schema API

none at the moment. hence the need to actually fix some of those things before we move forward. i am waiting on some convergence of things from the biccn side as well and then will release a versioned data model.

@AlmightyYakob I get your point, that is reasonable for now too. Maybe you should change the name to primaryKey? Is there a way to make it a required property/key, given that you want to call it a primary key?

Yeah I can change the name, although I'm not sure what can be done to enforce that this key exists on sub-schemas with an "object" type. Since this field isn't a property itself, but is just extra metadata, the JSON Schema validator ignores it because it's not part of the JSON Schema spec. I think this would be best left as an addtional task. Should I make an issue for it?

Make an additional task, let's not hold up this PR with it. I know we will want to do some DLP refactoring and specializing, so we can think about this issue as a part of that work.

I too am not fond of adding presentational data to the schema. listingKey is exclusively used in the ListingComponent, which makes it easy to define in a smaller, isolated scope rather than a global schema definition.
Rather than redefining the entire schema, I recommend including a new property field on ListingComponent so it knows when it's rendering an organism vs. a language vs. a sponsors, etc. Then you can just define a computed property like so:
  listingKey() {
    switch(this.field) {
      case 'access':
        return 'status';
      case 'publications':
        return 'url';
      case 'organism':
        return 'species';
      default:
        return 'name';
    }
  }

This doesn't seem that gross to me. It even solves the problem of listingKey not being defined on sub-schema metadata. If name is not sufficient for those cases, you can just add that case next to the top level fields (assuming no collisions). It also won't require a schema change if we want to change how the frontend is rendered in the future.
I don't feel good about modifying the schema for the benefit of the presentational layer as more than a temporary bandaid. If that's all it is I'm OK with it, but I think my solution is cleaner.

I like this idea, I'll try that. The only caveat is that if we update the schema we might have to update this computed prop as well, but I'm okay with that.

Also like you said @dchiquit, this would become a problem if there's field name collisions (e.g. two properties access that have different primary keys, and occur at different places in the schema). @satra Do you think this is likely to happen?

this would become a problem if there's field name collisions (e.g. two properties access that have different primary keys, and occur at different places in the schema). @satra Do you think this is likely to happen?

@AlmightyYakob - i very much doubt that this will ever happen.

Great, this looks a lot nicer than what was there before and the separation of concerns seems reasonable. Nice going @AlmightyYakob and @dchiquit .


Error record_linkage_example.py

KeyError: 'Field type Price not valid. Valid types include Source, ShortString, Set, String, Interaction, Categorical, Text, Exact, LatLong, Custom'

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact, LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

Thanks! that fixed it! also sent this to your other email..
*Hi Forest -- *
Do you know if dedupe is capable of relating records based on match
percentage? i.e. return more than one match per record.
When I run csvlink it usually matches records one to one. Meaning I'll get
the number of matches equal to the number of the smaller record set.
eg
csvlink examples/linking_temp.csv examples/csv_example_messy_input.csv
--field_names Address Zip --output_file output.csv --skip_training
*linking_temp.csv is 233 in line count *
csv_example_messy_input is ~3000 in line count
matches output: 233
I'd imagine there are several other matches that come close to records, is
there any way to include these. Maybe get it to return a sorted list or
something.
Thanks!
ᐧ
On Tue, Apr 28, 2015 at 1:52 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact, LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97203766
.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

The gazetteer class supports multiple matches.
On Tue, Apr 28, 2015 at 4:02 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

Thanks! that fixed it! also sent this to your other email..
*Hi Forest -- *
Do you know if dedupe is capable of relating records based on match
percentage? i.e. return more than one match per record.
When I run csvlink it usually matches records one to one. Meaning I'll get
the number of matches equal to the number of the smaller record set.
eg
csvlink examples/linking_temp.csv examples/csv_example_messy_input.csv
--field_names Address Zip --output_file output.csv --skip_training
*linking_temp.csv is 233 in line count *
csv_example_messy_input is ~3000 in line count
matches output: 233
I'd imagine there are several other matches that come close to records, is
there any way to include these. Maybe get it to return a sorted list or
something.
Thanks!
ᐧ
On Tue, Apr 28, 2015 at 1:52 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact,
LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

—
Reply to this email directly or view it on GitHub
<
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97203766
.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97205880
.

Will check it! if you have any good tutorials/examples in mind please let
me know...
ᐧ
On Tue, Apr 28, 2015 at 2:18 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

The gazetteer class supports multiple matches.
On Tue, Apr 28, 2015 at 4:02 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

Thanks! that fixed it! also sent this to your other email..
*Hi Forest -- *
Do you know if dedupe is capable of relating records based on match
percentage? i.e. return more than one match per record.
When I run csvlink it usually matches records one to one. Meaning I'll
get
the number of matches equal to the number of the smaller record set.
eg
csvlink examples/linking_temp.csv examples/csv_example_messy_input.csv
--field_names Address Zip --output_file output.csv --skip_training
*linking_temp.csv is 233 in line count *
csv_example_messy_input is ~3000 in line count
matches output: 233
I'd imagine there are several other matches that come close to records,
is
there any way to include these. Maybe get it to return a sorted list or
something.
Thanks!
ᐧ
On Tue, Apr 28, 2015 at 1:52 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact,
LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

—
Reply to this email directly or view it on GitHub
<

https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97203766

.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/
—
Reply to this email directly or view it on GitHub
<
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97205880

.

—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97209994
.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

I tried using the address matching example with:
clustered_dupes = linker.match(messy_addresses, threshold=0.4,
n_matches=4)
and I haven't seen anything that gives me multiple matches per single
canonical record.
Just so I'm not burning days/hours trying to figure this out would you have
any examples of multiple matches?
ᐧ
On Tue, Apr 28, 2015 at 2:27 PM, Ajay Sharma<EMAIL_ADDRESS>wrote:

Will check it! if you have any good tutorials/examples in mind please let
me know...
ᐧ
On Tue, Apr 28, 2015 at 2:18 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

The gazetteer class supports multiple matches.
On Tue, Apr 28, 2015 at 4:02 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

Thanks! that fixed it! also sent this to your other email..
*Hi Forest -- *
Do you know if dedupe is capable of relating records based on match
percentage? i.e. return more than one match per record.
When I run csvlink it usually matches records one to one. Meaning I'll
get
the number of matches equal to the number of the smaller record set.
eg
csvlink examples/linking_temp.csv examples/csv_example_messy_input.csv
--field_names Address Zip --output_file output.csv --skip_training
*linking_temp.csv is 233 in line count *
csv_example_messy_input is ~3000 in line count
matches output: 233
I'd imagine there are several other matches that come close to
records, is
there any way to include these. Maybe get it to return a sorted list or
something.
Thanks!
ᐧ
On Tue, Apr 28, 2015 at 1:52 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma<EMAIL_ADDRESS>

wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact,
LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

—
Reply to this email directly or view it on GitHub
<

https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97203766

.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/
—
Reply to this email directly or view it on GitHub
<
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97205880

.

—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97209994
.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

ᐧ
On Sat, May 2, 2015 at 10:30 AM, Ajay Sharma<EMAIL_ADDRESS>wrote:

I tried using the address matching example with:
clustered_dupes = linker.match(messy_addresses, threshold=0.4,
n_matches=4)
and I haven't seen anything that gives me multiple matches per single
canonical record.
Just so I'm not burning days/hours trying to figure this out would you
have any examples of multiple matches?
ᐧ
On Tue, Apr 28, 2015 at 2:27 PM, Ajay Sharma<EMAIL_ADDRESS>wrote:

Will check it! if you have any good tutorials/examples in mind please let
me know...
ᐧ
On Tue, Apr 28, 2015 at 2:18 PM, Forest Gregg<EMAIL_ADDRESS>wrote:

The gazetteer class supports multiple matches.
On Tue, Apr 28, 2015 at 4:02 PM Ajay Sharma<EMAIL_ADDRESS>wrote:

Thanks! that fixed it! also sent this to your other email..
*Hi Forest -- *
Do you know if dedupe is capable of relating records based on match
percentage? i.e. return more than one match per record.
When I run csvlink it usually matches records one to one. Meaning
I'll get
the number of matches equal to the number of the smaller record set.
eg
csvlink examples/linking_temp.csv examples/csv_example_messy_input.csv
--field_names Address Zip --output_file output.csv --skip_training
*linking_temp.csv is 233 in line count *
csv_example_messy_input is ~3000 in line count
matches output: 233
I'd imagine there are several other matches that come close to
records, is
there any way to include these. Maybe get it to return a sorted list or
something.
Thanks!
ᐧ
On Tue, Apr 28, 2015 at 1:52 PM, Forest Gregg <
<EMAIL_ADDRESS>wrote:

You need to updated dedupe.
On Tue, Apr 28, 2015 at 3:22 PM Ajay Sharma <
<EMAIL_ADDRESS>wrote:

KeyError: 'Field type Price not valid. Valid types include Source,
ShortString, Set, String, Interaction, Categorical, Text, Exact,
LatLong,
Custom'
—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24.

—
Reply to this email directly or view it on GitHub
<

https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97203766

.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/
—
Reply to this email directly or view it on GitHub
<
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97205880

.

—
Reply to this email directly or view it on GitHub
https://github.com/datamade/dedupe-examples/issues/24#issuecomment-97209994
.

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

--
Github https://github.com/asharma567/ | LinkedIn
http://www.linkedin.com/in/mrasharma/

@asharma567 I'm not exactly sure what you mean.
https://github.com/datamade/address-matching/blob/master/address_matching.py#L122-130 Is probably most relevant section of address-matching.py
Particularly, https://github.com/datamade/address-matching/blob/master/address_matching.py#L129
Notice, that unlike the other types of matching "cluster" consists of a set of possible matches. In this program we are just using the top scoring one (the first one).


GN-4442: general Functionality to move a node DOWN the document (+support for Template Comments)

general function to find the next valid position that a node can be inserted
update to moveDown of template comment to use this better algorithm

Overview
Adds a new file document-walker that adds algorithm functions that can walk down through the document. This is in order of what you see as a user (which is the same as what you see in the prosemirror structure debug window). This is what "down" means for users.
The functions accept a predicate and will test every space between nodes. This is often what we want, because inserting is always preferred to do between nodes, to avoid splitting up nodes and getting weird behaviour.
If leaf/atom-nodes would also need to be looked through, it might be able to be easily extended by just using a more fancy predicate. I did not really look into this though.
The algorithm works as follows:

look before the passed node if can insert there.
if not, go inside the node (to its children) and look to insert as much to the left as possible.
if not, go even deeper. If no children, go to a space to the right and check there.
if nothing in the children of the passed node is found, we need to go up the tree.
when going up, the same is done there.
Note that it can be easily understood when looking at the document structure with the debug tool. It really just loops from top to bottom. The hard part comes from getting the right information without just looping over positions. Prosemirror isn't made for looping over global positions and this way it should be quicker.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4442 (half of it. Moving up is not included)

Setup

only this repo needed -

How to test/reproduce

include a template comment in some structure in Regulatory Statements part.
add some structured data (title, article, paragraphs ...)
click on the template comment and move it up and down

it should move up and down from node to node

without splitting any nodes (creating anything weird)
keeping the selection inside the template comment intact

Challenges/uncertainties

There is probably still a bug if the template comment is at the end (=reason for draft)
I added some comments to make clear what happens. However, most of it isn't written super clearly. Feel free to suggest different wording.
The algorithm might be difficult to understand. I don't think it is important to fully understand it, but mostly to check if the comments are good enough.
the helper functionality should probably be in ember-rdfa-editor. But that increases difficulty of testing this and it is needed for template comments now.

Just a mention, have you looked at<EMAIL_ADDRESS>at all? It seems to at least be in the same ballpark, might not be exactly the same but still worth a look

I did look through the utils but misinterpreted what findNodes did so didn't realize it did similar to what I need (cause it would indeed have been a good starting point :upside_down_face: ). I'm also not sure if it will find them in the order that is needed for moving a node (but now looking through the code itself I think it does?). Hard to be certain at a first glance because the code is quite complex to fully interpret.
I'll test to see if it might be what I need with a good-build filter. :)

dont forget to bump editor in this pr when that pr is merged

Changelog was merged wrong. Fixed in commit to master: 16b4e288c496bfd2eca0db7861648af0789c98a6


Initiating a set time from a hidden seconds input

Any suggestions on the best way initiate an option to preset the time (in seconds) or set an input id/name with the seconds there (i.e like your hidden input in the demo)

Set duration in the options array
Set duration after the plugin has initialized

These two methods would be awesome to have. I tried using the defaultValue option that seems to be currently there but it doesn't work.

Any suggestions on the best way initiate an option to preset the time (in seconds) or set an input id/name with the seconds there (i.e like your hidden input in the demo)

I think the best way would be to use defaultValue option with one of possible value types:

Integer - an initial number of seconds (already done)
function - a function, which must return an Integer value (number of seconds)

Set duration after the plugin has initialized

I'll see what i can do.

I tried using the defaultValue option that seems to be currently there but it doesn't work.

How did you do that? This should work:
$('#duration').timeDurationPicker({ defaultValue: 123456789 });

[jsfiddle] (https://jsfiddle.net/kyybuaub/)

@digaev I'm using defaultValue but it doesn't seem to update the placeholder / value, not until I click the input to open the model with dropdowns and click 'Update' then it shows the updated placeholder x hours and x minutes.


cargo new --template ignores/replaces/overwrites .gitignore

While investigating another flaw in --template, I discovered the following undesired behaviour when generating a test project from my boilerplate for CLI utilities:
diff -u -ur ../rust-cli-boilerplate/.gitignore ./.gitignore
--- ../rust-cli-boilerplate/.gitignore  2017-03-09 13:33:13.345285768 -0500
+++ ./.gitignore        2017-03-23 11:41:35.619386304 -0400
@@ -1,2 +1,3 @@
-/callgrind.out.justfile
-/target
+target/
+**/*.rs.bk
+Cargo.lock

While I admit I forgot to exclude *.rs.bk, the rest is unhelpful.
What's worse is that I don't see how this actually helps anything, given that, for a project template, there isn't really much of a purpose to .gitignore outside of being passed on to the generated projects.  (It's not as if the template's Cargo.toml is valid TOML before the placeholder for the author list gets substituted.)
You'll also notice that it's adding Cargo.lock to the .gitignore when this is specifically intended as --bin project template, not a --lib one, so that's not helpful either.
I think a proper solution would be to only generate a .gitignore if none is present in the template
As-is, I'm forced to go back to what I used before... a wrapper script.

cc @ehiggs @gchp

If I understand correctly, your template has a .gitignore but it wasn't used by cargo new and some other .gitignore was generated. And the expected behaviour is that it should use the .gitignore from your template verbatim. Makes sense to me.

Yes, that's correct.
The template contains a .gitignore which ignores the target folder and the temporary file used by my justfile for passing profiles from callgrind to kcachegrind.
cargo new instead populates new projects with a .gitignore which ignores target, *.rs.bk, and Cargo.lock. (The latter being a problem because not all templates are going to be --lib templates.)

Yeah makes sense to me as well to use the .gitignore from templates over the built-in one, thanks for the report @ssokolow!

Templates have been removed pending an RFC. There is a pre-RFC thread here. I think this can be closed for now.

Thanks @ehiggs!


added refresh timer

Change is addressing: https://github.com/severin-lemaignan/vim-minimap/issues/23
Adds minimap_refresh_ms setting, default is 100ms, which controls minimap update interval.

I also think this would be quite useful. I care more about scrolling smoothly than about having an up-to-date preview while I'm actively scrolling.


Fixed a couple of screen reader issues

Fixes #2478
Fixes #2569

Just checkoing: the progress bars for disk free space are now ignored when in narrator mode, was this the intended behaviour?

Just checking: the progress bars for disk free space are now ignored when in narrator mode, was this the intended behavior?

That was intentional.

Ok it makes sense


Form field rendering for ManyToManyFields inconsistent (+ version without checkboxes not resizing correctly)

The search/filter form renders ManyToManyFields differently from the create and update forms:

The latter version seems preferable because it's less clunky, but the field doesn't resize to its contents (selected values) and can overlap other fields.

For reference: "Pillbox" is the word I was looking for in today's JF to describe the latter widget.

More notes:

fields.py contains custom overrides for various django-autocomplete-light widgets
in GenericModelForm, we override built-in field types:

https://github.com/acdh-oeaw/apis-core-rdf/blob/4c9495773b842bf626fb55ef52a01a0752981ec2/apis_core/generic/forms/__init__.py#L69-L75

don't confuse django-select2 with django-autocomplete-light as I'm wont to do (d'oh); we use the latter, which is imported with dal_select2

What we do use is the bootstrap-multiselect library, which gets imported in the apis_templatetag.html monster template:
https://github.com/acdh-oeaw/apis-core-rdf/blob/4c9495773b842bf626fb55ef52a01a0752981ec2/apis_core/apis_entities/templates/apis_entities/apis_templatetag.html#L1
and which replaces the default html multiselect widget with what you see on the first screenshot.

The latter version seems preferable because it's less clunky

actually, I'm not sure about that. I'd say it depends on the amount of possible options. If there are only a dozen things you can select, I'd opt for the first implementation, because you don't have to know how the option is spelled

actually, I'm not sure about that. I'd say it depends on the amount of possible options. If there are only a dozen things you can select, I'd opt for the first implementation, because you don't have to know how the option is spelled

The number of options is a good point, though I'd argue that a small number of possible choices – or a smaller number of expected selections from not-too-big a pool of choices – is a better argument for the pillbox solution.
I've now only experimented with instances of the widget where all allowed values are known/predefined, and from what I could see, they are shown in a dropdown-like list as soon as one starts typing, so spelling shouldn't be an issue. (?!)
But as soon as you're looking to select more than a handful of values, or when there's a longer list of options, it's faster to go through a list of checkboxes in a dropdown which remains open than selecting values by (half-)typing them out or picking them one-by-one from this ephemeral pseudo dropdown.

In Frischmuth, the single-select fields which need to be converted to multi-select ones only hold a handful of values (~3-6) each, and I don't expect them to be searched or filtered in very intricate or complex ways, which is probably why the pillbox version looks very appealing, heh.
But, I wouldn't want to switch e.g. the "additional columns" dropdown out for it.

GenericFilter should also overwrite the default widgets similar to the GenericModelForm

Did we end up deciding on one version over the other?
I remember we discussed the pros and cons as well as different use cases/needs of projects in a JF, and @sennierer showed an incredibly long list of "Columns" in one project (don't remember which, unfortunately).

GenericFilter should also overwrite the default widgets similar to the GenericModelForm

Ah, I didn't realise this may have been meant as instruction, read it as an additional note.


Test don't run due to --single-run option

I'm submitting a...

[X] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

Attempt to run tests but get:

PS C:\Users\wayne\Projects\VidLessons> npm test

><EMAIL_ADDRESS>test C:\Users\wayne\Projects\VidLessons
> ng test --single-run --code-coverage

Unknown option: '--singleRun'

Expected behavior

Tests would run, once
Minimal reproduction of the problem with instructions

Generate default app (named 'VidLessons' in my case)
cd into dir
npm test

Note: ng test runs; the problem is just the single-run  flag that's a problem, it's not among the options listed with ng test --help
What is the motivation / use case for changing the behavior?

Should be able to test under Angular 6
Environment

PS C:\Users\wayne\Projects\VidLessons> npm list -g --depth=0
C:\Users\wayne\AppData\Roaming\npm
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>
PS C:\Users\wayne\Projects\VidLessons> ng --version
...
Angular CLI: 6.0.0
Node: 9.6.1
OS: win32 x64
Angular: 6.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, http, language-service, material, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@ngtools/webpack                  6.0.0
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              6.1.0
typescript                        2.7.2
webpack                           4.6.0

Angular version: 6.0.0

Browser:

[ ] Chrome (desktop) version XX
[ ] Chrome (Android) version XX
[ ] Chrome (iOS) version XX
[ ] Firefox version XX
[ ] Safari (desktop) version XX
[ ] Safari (iOS) version XX
[ ] IE version XX
[ ] Edge version XX

For Tooling issues:

Node version: 9.6.1  <!-- run node --version -->
Platform:  Windows 10

Others:

@wstidolph Please verify with the latest build.


psl: replace SchemaAst with a lossless AST

Problems with the current implementation

We can't refer to AST nodes in a fine-grained way. We would for example like to be able to have a reference to a specific expression inside an array expression inside an attribute.
We lose information like comments.
We can't treat different AST nodes in a generic way (they're different types).
We lose a lot of information on how schema nodes are ordered.
We are allocating a lot of strings and vectors.

Options

rust-analyzer style AST with rowan

https://github.com/rust-lang/rust-analyzer/blob/master/docs/dev/syntax.md
https://ericlippert.com/2012/06/08/red-green-trees/

zig-style AST

https://media.handmade-seattle.com/practical-data-oriented-design/
https://github.com/ziglang/zig/blob/master/lib/std/zig/Ast.zig

... ?

Path to replacing the AST

Replace pest with the new parser

Challenge: we have to reimplement reformatting.

Slowly remove bits of SchemaAst, until we only have the lossless AST and parser-database.

Hi there,
As part of our effort to clean up our GitHub repo, we’re closing this issue to help focus on features and improvements that align with our focus areas and those of our community.
This issue was originally created for internal tracking purposes, but if you feel this is important to you, feel free to reopen the issue and get like-minded users to upvote as we will prioritize fixing issues based on community interest.
For more insight into our priorities and how we’re thinking about the future of Prisma, please see our blog post: https://www.prisma.io/blog/prisma-orm-manifesto.
Thank you for your understanding and support!


isLoop="true"

Hi Dear @fengminchao
I use your library and it's great :)
just I have a problem.when I use isLoop attribute, it doesn't work properly after a moment and have wrong behavior.
would you help me?
thanks in advance 👍

Hi Dear @fengminchao
I use your library and it's great :)
just I have a problem.when I use isLoop attribute, it doesn't work properly after a moment and have wrong behavior.
would you help me?
thanks in advance 👍

Thanks for your feedback. I've fixed this bug in version 1.1.1. Now you can just upgrade this library version and run. It will work fine!

thanks :)


Infinite recursion in jax2tf with bfloat16 input.

Short repro:
import jax.numpy as jnp
from jax.experimental import jax2tf

jax2tf.convert(lambda x: x)(jnp.bfloat16(1.0))

Traceback (most recent call last):
  File "tmp.py", line 7, in <module>
    f(jnp.bfloat16(1.0))
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 278, in converted_fun
    out_flat = converted_fun_flat_with_custom_gradient(*args_flat)
  File "/Users/vanderplas/.local/share/virtualenvs/jax-LBbfM5ix/lib/python3.8/site-packages/tensorflow/python/ops/custom_gradient.py", line 258, in __call__
    return self._d(self._f, a, k)
  File "/Users/vanderplas/.local/share/virtualenvs/jax-LBbfM5ix/lib/python3.8/site-packages/tensorflow/python/ops/custom_gradient.py", line 212, in decorated
    return _eager_mode_decorator(wrapped, args, kwargs)
  File "/Users/vanderplas/.local/share/virtualenvs/jax-LBbfM5ix/lib/python3.8/site-packages/tensorflow/python/ops/custom_gradient.py", line 409, in _eager_mode_decorator
    result, grad_fn = f(*args, **kwargs)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 273, in converted_fun_flat_with_custom_gradient
    out_with_avals = _interpret_fun(flat_fun, args_flat, args_avals_flat)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 304, in _interpret_fun
    out_vals: Sequence[Tuple[TfVal, core.AbstractValue]] = fun.call_wrapped(*in_vals)
  File "/Users/vanderplas/github/google/jax/jax/linear_util.py", line 155, in call_wrapped
    args, kwargs = next(gen)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 341, in _interpret_subtrace
    in_tracers = tuple(TensorFlowTracer(trace, val, aval)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 341, in <genexpr>
    in_tracers = tuple(TensorFlowTracer(trace, val, aval)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 657, in __init__
    self.val = _safe_convert_to_tensor(val, dtype=self._aval.dtype)  # type: ignore[attr-defined]
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 95, in _safe_convert_to_tensor
    val = tf.bitcast(tf.convert_to_tensor(val.view(jnp.uint16),
  File "/Users/vanderplas/github/google/jax/jax/_src/numpy/lax_numpy.py", line 4909, in _view
    return lax.bitcast_convert_type(arr, dtype)

<snip>

  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 703, in pure
    return TensorFlowTracer(self, val, core.ShapedArray(shape, dtype))
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 657, in __init__
    self.val = _safe_convert_to_tensor(val, dtype=self._aval.dtype)  # type: ignore[attr-defined]
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 95, in _safe_convert_to_tensor
    val = tf.bitcast(tf.convert_to_tensor(val.view(jnp.uint16),
  File "/Users/vanderplas/github/google/jax/jax/_src/numpy/lax_numpy.py", line 4909, in _view
    return lax.bitcast_convert_type(arr, dtype)
  File "/Users/vanderplas/github/google/jax/jax/_src/lax/lax.py", line 463, in bitcast_convert_type
    return bitcast_convert_type_p.bind(operand, new_dtype=new_dtype)
  File "/Users/vanderplas/github/google/jax/jax/core.py", line 270, in bind
    tracers = map(top_trace.full_raise, args)
  File "/Users/vanderplas/github/google/jax/jax/util.py", line 36, in safe_map
    return list(map(f, *args))
  File "/Users/vanderplas/github/google/jax/jax/core.py", line 377, in full_raise
    return self.pure(val)
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 703, in pure
    return TensorFlowTracer(self, val, core.ShapedArray(shape, dtype))
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 657, in __init__
    self.val = _safe_convert_to_tensor(val, dtype=self._aval.dtype)  # type: ignore[attr-defined]
  File "/Users/vanderplas/github/google/jax/jax/experimental/jax2tf/jax2tf.py", line 92, in _safe_convert_to_tensor
    if not isinstance(val, jnp.ndarray):
  File "/Users/vanderplas/github/google/jax/jax/_src/numpy/lax_numpy.py", line 112, in __instancecheck__
    return isinstance(instance.aval, _arraylike_types)
RecursionError: maximum recursion depth exceeded in __instancecheck__

I believe this is the issue blocking #5085

I think the issue is that for bfloat16, _safe_convert_to_tensor calls view(), which leads to another call to _safe_convert_to_tensor within the primitive binding. We'll need to somehow work around this.

Is there any update about timeframes for the TF/JAX bfloat16 unification work that would fix this? It's causing some significant issues for us.

Is there any update about timeframes for the TF/JAX bfloat16 unification work that would fix this? It's causing some significant issues for us.

Assigning to @gnecula, as this is jax2tf related, and my initial fix was rejected.

Assigning to @gnecula, as this is jax2tf related, and my initial fix was rejected.


array: generalize S.pluck

Fixes #381

I was about to merge this pull request when I noticed your update-pluck branch in the network graph, @gabejohnson. I like your approach as it avoids mentioning prop in error messages. I've updated this pull request. Would you mind giving it one more look?

@davidchambers my apologies. I wrote that while eating lunch last week and promptly forgot about it. It works for me. 😄


pls help me fix

zenbot4 error
return s.exchange.getTime()
                        ^

TypeError: s.exchange.getTime is not a function
    at now (/root/zenbot/lib/engine.js:639:25)

I have change code is
function now () {
    if (so.mode === 'live')
      return new Date().getTime()
    else
	  return new Date().getTime()
      //return s.exchange.getTime()
  }

can work but i want fix it
pls help me fix it

Can you please share you command line input?

zenbot trade --paper

Which exchange and currency pair are you on?

ETH/BTC

Next bug. With HitBTC program not work ?

To be honest, if you are not giving any input like startup parameters and config and no output, no one could even try to help you.
About the originsl issue try #1405

Did you resolve your issue?  If so please consider closing this.


feat: Add configuration for stable environment

Description
This PR will introduce environment specific configuration for the 24.08 release to run on the catena-x stable environment.
Issue
relates to https://github.com/eclipse-tractusx/portal/issues/408
Checklist
Please delete options that are not relevant.

[x] I have performed a self-review of my changes
[x] I have successfully tested my changes
[x] I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
[x] I have commented my changes, particularly in hard-to-understand areas

@ds-lcapellino as discussed, I'm closing this PR as it doesn't make sense to merge it main because there we're are already ahead of the v2.1.0, the branch can still be used for installing v2.1.0


Don't pop up auth view controller if an accessTokenDelegate is available.

Verified that @RicoYao has signed the CLA. Thanks for the pull request!


Unable to delete Service Bus Namespace

Hi,
I'm getting the following error when attempting to delete a Service Bus namespace with the arm package:
servicebus.NamespacesClient#Delete: Failure sending request: StatusCode=400 -- Original Error: Long running operation terminated with status 'Failed': Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'northeurope' and API version '2014-09' for type 'namespaces'. The supported api-versions are '2014-09-01, 2015-08-01'. The supported locations are 'australiaeast, australiasoutheast, centralus, eastus, eastus2, westus2, westus, northcentralus, southcentralus, westcentralus, eastasia, southeastasia, brazilsouth, japaneast, japanwest, northeurope, westeurope, centralindia, southindia, westindia, canadacentral, canadaeast'."

From what I can see the API Versions don't match as the day component is missing in the error message.

Thats odd because sdk is set to correct version(with day). Have you checked request url using fiddler if final request formed has wrong version? We will also investigate at our end and get back to you soon.

Can you also provide sdk and go-autorest versions you are using?

Looked into this again and the error occurs in the status polling request:
Successful call to DELETE the resource:
Received Azure RM Request status code 202 Accepted for https://management.azure.com/subscriptions/sub-id/resourceGroups/acctestlbrg-1234/providers/Microsoft.ServiceBus/namespaces/acctestnet1234?api-version=2014-09-01

Error from call to GET the result:
Received Azure RM Request status code 400 Bad Request for https://management.azure.com/subscriptions/sub-id/resourceGroups/acctestlbrg-1234/providers/Microsoft.ServiceBus/namespaces/acctestnet1234/operationresults/acctestnet1234?api-version=2014-09

I'm using the version from the commit 2cdbb8553a20830507e4178b4d0803794136dde7.

Are you still getting this issue?

No response. Assuming it resolved. Closed.

Hey, apologies I missed this.
It appears to have been resolved, cheers.


adding -a switch

Hello,
could xml-to-json-fast be provided with the same switch -a (and, possibly, -m) of xml-to-json?
Without that, the output of top-level multiple curled values results to be defective, since they are supposed to be the elements of a single top-level array, as for RFC 4627 or ECMA-404.
Thank you
Riccardo

Sorry for the delay.
AFAIK XML documents must have a single root node, so if your XML is well-formed you will get a single root JSON object with a property items, an array of all of the root node's children.
I can add the feature anyway, but do you mind sharing the use case?


YoutubeLoader throws 'module not found' error

System Info
Running langchain in Nextjs app
"langchain": "^0.0.175",
"next": "^13.5.2",
"react": "18.2.0",

Who can help?
@eyurtsev
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[X] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I'm using the YoutubeLoader as described in the docs. The YoutubeLoader is part of a route handler in my NextJs application.
// in youtube service
export async function getYoutubeTranscript(youtubeUrl: string) {
  const loader = YoutubeLoader.createFromUrl(youtubeUrl, {
    language: 'en',
    addVideoInfo: true,
  })
  const docs = await loader.load()
  return docs
    .map((doc) => doc.pageContent)
    .join(' ')
    .replaceAll('\n', ' ')
}

// in route handler
const transcript = await getYoutubeTranscript(link)

When using the route, I get an error because of a missing dependency - on my machine the route still works though.

Manually installing canvas via npm i canvas fixes the issue, but when I deploy to vercel, the function exceeds the maximum size limit of 50 MB compressed, because the canvas package is 45 MB compressed...
Not manually installing the dependency causes the route on Vercel to always return a 405 because of the missing dependency:

I realize that this is not caused by the YoutubeLoader itself, but still hoping for any pointers or ideas how to fix this.
Expected behavior
YoutubeLoader works without throwing a 'module not found' error

Not helpful unfortunately


Better visual feedback while data loads

There can be a long wait while navigating between folders resolving links. We need better visual feedback so that users don't go into click-rage.

Lol, you mean instead of just flashing 100% at them?

Fixed in d841ec74b848f9818e1745cb041b0f8d1e3200f3


 Use limine instead of GRUB and re write frame allocator.

Kernel is being ported to x86_64 architecture, so no use of this i686 page manager now. Will start from scratch for x86_64


WarCraft 2000: Nuclear Epidemic

GSC Game...game will crash on startup.
full game
https://www.myabandonware.com/game/warcraft-2000-nuclear-epidemic-bip
game source code
https://github.com/ForNeVeR/warcraft-2000-nuclear-epidemic

Game got a similar bug as Cossacks (made by the same company apparently). Got the crash fixed, but not sure if it's working because it shows a message in russian and doesn'T continue there
cnc-ddraw.zip

Fixed:
cnc-ddraw-war2000.zip

Not sure if there's a game speed limiter, but just in case there is none, here's the game speed limiter build from cossacks:
cnc-ddraw-war2000-speedlimiter.zip

Not sure if there's a game speed limiter, but just in case there is none, here's the game speed limiter build from cossacks multiplayer:
cnc-ddraw-war2000-speedlimiter.zip

Ingame Press F12 open options

Ah nice, thanks! Will be playing this a bit too...
I've actually been working on warcraft 2 for years and made a widescreen patch and many other things but I haven't heard about this game here yet, nice find!

This is a complete remake of the War2 in 1998 by GSC. An absolutely unlicensed work. Due to legal considerations, the GSC team has opened up the game's source code directly.
As you can see, there are tons of settings in there that are similar to the Cossack 1 game. In a sense, it could be some sort of prototype game made before they made Cossack 1.


combine linting

Description

Fixes pyrsia/pyrsia#
This PR does... by accomplishing... and it can be reviewed by... you can also test the changes by running...
Screenshots (optional)
PR Checklist

[ ] I've read the contributing guidelines.
[ ] I've read "What is a Good PR?"
[ ] I've included a good title and brief description along with how to review them.
[ ] I've linked any associated an issue.

Code Contributions

[ ] I've run pre-commit.sh (pre-commit.bat) successfully.
[ ] I've run the integrations tests
on the PR branch and all tests passes.

/easycla

closing.  this was just a test for LF EasyCLA


[DOCFIX] Add javadoc for UfsJournalReaderTest

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14821/
Test PASSed.


using EntwineTest to compare results when the underlying type is a tuple - kind of awkward

First off - I'm the last to say I'm an expert at Swift, or the vagaries of type theory and effectively using a statically type language with generics like we have.
I was creating some tests to using EntwineTests virtual scheduler to illuminate how some of the  Combine operators work - specifically combineLatest and some of the others that merge pipelines together. (ref: https://github.com/heckj/swiftui-notes/pull/56)
What I hit my shins on was that the equatable conformance with Entwine's Signal relies entirely on the underlying type's conformance - totally good, except that the type can be a tuple (and is, in the case of combineLatest, which is merging the output types of the upstream pipelines.
I came up with two options to do the validation regardless, although both are really quite ugly hacks. I'm opening this issue to see if you had any brilliant insights into how this might be done more nicely.
The first was the use the same testing hack I use for comparing Error enums - using the debugDescription() method on the enumeration to generate a string, and comparing that. It's stringly-type-erasing the compiler details away, while providing fairly useful tests.
The second was to create a one-off function that specifically broke down a TestSequence item (itself a tuple of VirtualTime and a Signal enum instance) and return a boolean value if they match up.
Although it's functioning and correct, it feels ugly and awkward, so I was hoping you might have some ideas on how this might be made more elegant.
Although the timing was very useful to show for my combineLatest tests, I also realized that the key of what I was interested in validating was the ordered list of data results, and a lot of the type information around it wasn't as interesting for my specific test.
I'm not sure if there'd be significant value in making a helper operator to pull out just a sequence of the OutputType and make that available from under TestSequence, but it might be useful as an idea.

Sure, I'll comment on the issue you linked to also, but so there's a reference here:
Tuples in Swift still leave a little to be desired, they don't auto-synthesise Equatable or Hashable conformance, and in fact there is no generic way you can conform a tuple to these protocols. From the discussions I've read from the Swift team, tuples often add an additional layer of complication when they're implementing new features and seem to be a general thorn in their sides!
However, they are particularly ergonomic from a coding perspective, so hopefully they'll resolve these issues at some point.
With EntwineTest, the solution I use to make the TestSequence conform to Equatable is to map the tuples to an intermediate struct, I then make that struct conform to Equatable and compare those instead.
You could generalise it, but as I'm only using it in the one place I didn't want to bloat the codebase.
But it's simple enough to do.
The theory behind it is that any tuple can also be represented as a struct. So if you can create an intermediate struct that maps from a tuple and back, you then should have all you need to conform to whatever behaviours you need.
The big thing to remember is that you will need an intermediate struct for each arity of tuple. So for two, three, and four element tuples, you will need the intermediate structs of:
Tuple2<T0, T1>
Tuple3<T0, T1, T2>
Tuple4<T0, T1, T2, T3>
In terms of implementation it's as simple as:
struct Tuple2<T0, T1> {

    let t0: T0
    let t1: T1

    init(_ tuple: (T0, T1)) {
        self.t0 = tuple.0
        self.t1 = tuple.1
    }

    var raw: (T0, T1) { (t0, t1) }
}

And then Equatable and Hashable conformance is just:
extension Tuple2: Equatable where T0: Equatable, T1: Equatable {}
extension Tuple2: Hashable where T0: Hashable, T1: Hashable {}

Specifically with Entwine, though I think the generalised Tuples solution is probably outside the scope, what would probably help is some additional mapping functions so If you have made some intermediate structs – you can use them with ease.
Enabling something like:
    func testTuples() {

        let testScheduler = TestScheduler(initialClock: 0)

        let testablePublisher: TestablePublisher<(Int, String), Never> = testScheduler.createAbsoluteTestablePublisher([
            (  0, .input((0, "A"))),
            (200, .input((0, "B"))),
            (400, .input((0, "C"))),
        ])

        let testableSubscriber = testScheduler.start { testablePublisher }

        let results = testableSubscriber.recordedOutput
        let expected: TestSequence<(Int, String), Never> = [
            (200, .subscription),
            (200, .input((0, "B"))),
            (400, .input((0, "C"))),
        ]

        XCTAssertEqual(results.mapInput(Tuple2.init), expected.mapInput(Tuple2.init))
    }

Where Tuple2 is the struct above.
Does that help? I'll push those mapping utils to master so you can try them out.

thank you for the explanation, that helps considerably, and I'll definitely try out the utilities to map to structs and back. Once you know how to do this, and how to attack it (your description is excellent, for example) it becomes pretty clear to formulate a plan to put it all together.
There's a downside in that a lot of people won't either know or want to do the extra work involving making a struct for the intermediate tuple collections just to make them testable, so in the back of my head I'm a little concerned that they simply wont, and the powerful feature of this library would get missed or neglected (as well as crappier tests would tend to exist)
I apologize, as I'm sure it sounds like I'm complaining about the wonderful feature work and solutions you're providing here - that's not my intent. The core of the question in head is "how does this get made easily apparent to someone else coming in after me?" and I genuinely don't have a good answer there, even as it relates to the my writing/authoring work with Using Combine and other texts.

Glad it was useful, @heckj! And I totally agree, fwiw: It's not completely obvious how to solve these issues when you come across them. The challenge is deciding what should be part of this library and what should be outside of it.
If you make use of tuples frequently, then including a set of intermediate tuple structs in your project is probably a good idea. Maybe there is room for a library that includes just these intermediate structs. Historically I've avoided libraries for smaller utilities that can be copy and pasted into a project though. Maybe a gist?
But as you say, it isn't going to be immediately obvious to most people that this is what they need. Intuition would likely suggest that if you can use the == operator on something, then whatever that thing is must conform to Equatable. Not so, however, and reaching that understanding can be a painful! (Speaking from experience.)
I think a large part of that is down to Swift's generic system actually quite a way from being 'feature complete'. The Swift team themselves have tried to outline a vague plan for generics, initially with the Swift Generics Manifesto, and then more recently Joe Groff's post on the Swift forums Improving the UI of Generics.
What this means in practice is that things that you expect to work intuitively, just aren't available yet. Most recently it took me a while to work out that using the new some keyword to return a publisher was going to pretty useless with publishers as there is no way of constraining to the publisher's output or failure types. However, if you look at the plan – it's likely to arrive at some point. (So eventually we can get rid of all of those .eraseToAnyPublisher() calls.)


chore: support devnet cids

Summary of changes
Changes introduced in this pull request:

Refreshed our copy of builtin_actors_gen.go
Added devnet CIDs

Reference issue to close (if applicable)

Closes
Other information and links

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: lemmih:x: elmatticYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: lemmih:x: elmatticYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.12 :tada:

Comparison is base (af126d5) 9.90% compared to head (1016774) 10.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##            main     #124      +/-   ##
=========================================
+ Coverage   9.90%   10.03%   +0.12%
=========================================
  Files        313      313
  Lines      28801    28801
=========================================
+ Hits        2854     2890      +36
+ Misses     25947    25911      -36

Impacted Files
Coverage Δ

fil_actor_interface/src/builtin/known_cids.rs
100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@elmattic Could you sign the CLA?

The CLA bot is acting up. Let's review this and merge regardless.

In general, it'd be fantastic to make a release after this is merged.


bug: cannot perform file/directory operations within LSP workspaces

Did you check the docs and existing issues?

[X] I have read the docs
[X] I have searched the existing issues

Neovim version (nvim -v)
v0.10.0
Operating system/version
MacOS 14.5
Describe the bug
After updating oil.nvim to the commit, I cannot perform file/directory operations within LSP workspaces.
Error shown:
E5108: Error executing lua: ...local/share/nvim/lazy/oil.nvim/lua/oil/lsp/workspace.lua:80: attempt to call field 'has' (a nil value)
stack traceback:
        ...local/share/nvim/lazy/oil.nvim/lua/oil/lsp/workspace.lua:80: in function 'get_matching_paths'
        ...local/share/nvim/lazy/oil.nvim/lua/oil/lsp/workspace.lua:273: in function 'will_rename_files'
        .../.local/share/nvim/lazy/oil.nvim/lua/oil/lsp/helpers.lua:84: in function 'will_perform_file_operations'
        ....local/share/nvim/lazy/oil.nvim/lua/oil/mutator/init.lua:393: in function 'process_actions'
        ....local/share/nvim/lazy/oil.nvim/lua/oil/mutator/init.lua:567: in function 'cb'
        ...cal/share/nvim/lazy/oil.nvim/lua/oil/mutator/preview.lua:130: in function 'confirm'
        ...cal/share/nvim/lazy/oil.nvim/lua/oil/mutator/preview.lua:182: in function <...cal/share/nvim/lazy/oil.nvim/lua/oil/mutator/preview.lua:181>

What is the severity of this bug?
breaking (some functionality is broken)
Steps To Reproduce

Open any workspace that has LSP triggered.
Open a random file to trigger LSP
Try to delete a file

https://github.com/stevearc/oil.nvim/assets/42376176/bde077a0-17ee-4f99-8d1b-c5ca150716b4
Expected Behavior
I should be able to perform file/directory operations within LSP workspaces.
Directory structure
No response
Repro
-- save as repro.lua
-- run with nvim -u repro.lua
-- DO NOT change the paths
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "runtime", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
        "stevearc/oil.nvim",
        config = function()
            require("oil").setup({
              -- add any needed settings here
            })
        end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Did you check the bug with a clean config?

[ ] I have confirmed that the bug reproduces with nvim -u repro.lua using the repro.lua file above.

This issue was fixed in the PR #411


Error: Unable to login to DBT Cloud

Hi and thanks for this cool project! I'm unable to authenticate with either DBT_CLOUD_ACCOUNT_ID and DBT_CLOUD_TOKEN env vars or explicitly configuring the provider as follows:
# main.tf
terraform {
  required_providers {
    dbt = {
      source  = "GtheSheep/dbt-cloud"
      version = "0.0.67"
    }
  }
}

provider "dbt" {
  account_id  = <account_id>
  token          = "<token>"
}

data "dbt_cloud_project" "dbt_cloud_project" {
  project_id = var.dbt_cloud_project_id
}

I'm getting a Error: Unable to login to DBT Cloud when running terraform apply. I've verified that the account id and token work with the dbt Cloud API v2:
curl --request GET \
  --url https://cloud.getdbt.com/api/v2/accounts/$DBT_CLOUD_ACCOUNT_ID/projects/ \
  --header "Content-Type: application/json" \
  --header "Authorization: Token $DBT_CLOUD_TOKEN" \
  | jq .

Debug logs
2021-10-27T12:49:05.649+0300 [DEBUG] created provider logger: level=debug
2021-10-27T12:49:05.649+0300 [INFO]  provider: configuring client automatic mTLS
2021-10-27T12:49:05.735+0300 [DEBUG] provider: starting plugin: path=.terraform/providers/registry.terraform.io/gthesheep/dbt-cloud/0.0.67/linux_amd64/terraform-provider-dbt-cloud_v0.0.67 args=[.terraform/providers/registry.terraform.io/gthesheep/dbt-cloud/0.0.67/linux_amd64/terraform-provider-dbt-cloud_v0.0.67]
2021-10-27T12:49:05.736+0300 [DEBUG] provider: plugin started: path=.terraform/providers/registry.terraform.io/gthesheep/dbt-cloud/0.0.67/linux_amd64/terraform-provider-dbt-cloud_v0.0.67 pid=22052
2021-10-27T12:49:05.736+0300 [DEBUG] provider: waiting for RPC address: path=.terraform/providers/registry.terraform.io/gthesheep/dbt-cloud/0.0.67/linux_amd64/terraform-provider-dbt-cloud_v0.0.67
2021-10-27T12:49:05.746+0300 [INFO]  provider.terraform-provider-dbt-cloud_v0.0.67: configuring server automatic mTLS: timestamp=2021-10-27T12:49:05.746+0300
2021-10-27T12:49:05.787+0300 [DEBUG] provider: using plugin: version=5
2021-10-27T12:49:05.787+0300 [DEBUG] provider.terraform-provider-dbt-cloud_v0.0.67: plugin address: address=/tmp/plugin595756387 network=unix timestamp=2021-10-27T12:49:05.787+0300
2021-10-27T12:49:15.899+0300 [INFO]  backend/local: plan operation completed
╷
│ Error: Unable to login to DBT Cloud
│
│   with provider["registry.terraform.io/gthesheep/dbt-cloud"],
│   on main.tf line 10, in provider "dbt":
│   10: provider "dbt" {
│
│ unexpected end of JSON input
╵
2021-10-27T12:49:15.901+0300 [DEBUG] provider.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"
2021-10-27T12:49:15.902+0300 [DEBUG] provider: plugin process exited: path=.terraform/providers/registry.terraform.io/gthesheep/dbt-cloud/0.0.67/linux_amd64/terraform-provider-dbt-cloud_v0.0.67 pid=22052
2021-10-27T12:49:15.902+0300 [DEBUG] provider: plugin exited

I'm using Terraform v1.0.1. I get the error whenever I try planning or applying - so if I understood your question correctly, the plan doesn't complete but throws an error before it does.

Ahh ok, got it, will test with that version, thanks!

Can't seem to reproduce this on Mac, so have chucked up this PR to test on Linux and still seems to be fine, not sure if cleaning your workspace/ environment may help here? I figured this branch would ensure it's nothing to do with my local setup.
https://github.com/GtheSheep/terraform-provider-dbt-cloud/pull/42
I note that this is using env vars over configuring the provider explicitly.
Sorry about this, frustratingly hard to reproduce! 😬 The only time I managed to get this to happen the other day was with some terraform files in the dir (.terraform/ and so on), but can't understand why this would cause issue with the provider itself ☹

@GtheSheep Getting back to this old issue after a while. Is there any way to get a log trace of the dbt Cloud HTTP requests?

Hey, I've not implemented much logging yet, I guess try setting TF_LOG_LEVEL=TRACE and see what comes out?

There's nothing related to the HTTP request in the Terraform trace :(

I also got the same error when running it on Terraform Cloud.

Hi, @GtheSheep  - Yes, I am using a service token.   I had a look at this func - NewClient which is used to initialize the client and ran some tests:
This is the URL for authentication in the code:
'''
url := fmt.Sprintf("%s/v2/accounts/%s", *host_url, strconv.Itoa(*account_id))
'''
If I run curl on this URL format, the body of the web response is empty:

Maybe that's what causes the unexpected end of JSON input error.
However,  if I add a '/' at the end of the url,  it now returns a Json message:

Hey @ywan160 thanks for this, I actually had this issue on my account for some of the other endpoints, let me add this and run tests, if it works I'll release a new provider version to try 🤞

Unfortunately, still getting the same error. :(

You're doing this in TF Cloud, right? Does it provide any more detailed logging?

Are you getting "unexpected end of JSON input" or "Unable to login to DBT Cloud"? Anything you could provide from TF_LOG=TRACE would be super helpful as I can't seem to replicate this 😬

Hi @GtheSheep,  I ran with trace logging but couldn't find anything useful.  Unfortunately, the DBT Cloud account that I use is a single-tenant deployment and the log contains some sensitive information so I can't really share it here.  :(

Ahh that's a pain, how are you setting the account_url in the provider for the single-tenant? I don't know much about how the URLs for those look tbh
Thanks so much for all your help on this btw, really appreciate it!

No problem at all. Yes, it works the same as the shared tenant ones except that you can have your own sub-domain on the URL.

Cool, are you configuring it in the provider definition? Can't see it in the example you sent over is all


Reasonable Finality Depth

Problem: We need some reasonable block finality depth when confirming Events or Transactions.
Larger values take longer to confirm but are safer, smaller values are faster but unsafer.
Crypto exchanges use 2-20 blocks, Chainlink seems to use 50.
Solution: Depends on the security that we need, so please discuss here.

In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the Adjudicator and Depositor classes. Or as a global variable of the backend/ethereum/channel package?
And does it make sense to use different depths for different events? Waiting for a Deposited event is more similar to the situation of exchanges. On the other hand, if a malicious Registered event is seen, it may make sense to react quicker, that is, to use a lower finality depth.

In case you didn't already plan it this way, I think it should be configurable, maybe as setters on the Adjudicator and Depositor classes. Or as a global variable of the backend/ethereum/channel package?

I currently use a package variable for all calls, but this is only the first draft for testing.
Deciding how configurable we want/need it is also part of this issue discussion.
I will bring it up in the daily tomorrow, maybe we can make a meeting and sketch it out.

It should be configurable at instantiation. We can also have a separate meeting to talk through it in detail. Let me know.


Item thumbnails exist but do not load on initial route

When I generate thumbnails for items they do not load initially. I can refresh the page but even after I've cleared all related cache I have to re-route the the item for the thumbnail to display.
To reproduce:
Submit a new item.
Run the filter media process.
Route to your new item.
Verify the "No Thumbnail" default display.
Press the back button.
Re-route to the your new item.
Notice the thumbnail now displays.
It's unclear to me why re-routing to an item after initially routing to the item would display the thumbnail.

@cwilper or @AndrewZWood : Have you done any further analysis of the issue here?  This seems like something we may want to solve in 7.0, but also seems low priority.  If you don't feel experienced enough to figure out the issue, we could also pull in @artlowel or someone on his team.
For now, moving this to 7.0 board, flagging as low priority & assigning back to @cwilper and @AndrewZWood (please give feedback on whether I should reassign it though)

Per today's meeting, I'm reassigning this to @artlowel so that he can delegate to appropriate team members to analyze the issue.

Hi, I would like to add an extra scenario that I see and it could be very much related to this bug.

I navigate to an item with thumbnail via links
Thumbnail is displayed in place as supposed.
I hit page refresh (regular and full refresh without cache usage all the same)
Thumbnail does not get loaded (No thumbnail svg in place)

This also has same effect if I pass the item URL to someone else - every attempt to load item fully fails.
P.S.
did not found any thumbnails on demo site, so this is only observed on local installation


Add build steps to workflow

Description
Adds workflow steps to run yarn build and yarn build-docs. These are good as verification steps and also generate oui.d.ts, which will be very useful for #648. They are scheduled to run after both yarn test-unit and yarn lint run because they are pretty hefty commands and should only be run if absolutely necessary.
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Converting to draft to rethink some of the filtering stuff and also get build working on Windows

I removed the path filter. I think at this point, adding a path filter would require more thought and effort than it's worth. I'd just like to get this out, and we can make a follow-up issue to figure out path filters.


add option to [E]dit shell commands

I'd love to see an additional option in the shell command output for Edit, so if you get a close-enough-but-not-perfect result you can update it (or e.g. modify it for another set of options) on the command line before execution. I currently do this by copy-pasting, but that takes my hands off the keys.
The options might end up being
[E]dit, E[x]ecute, [D]escribe, [A]bort or something.

This is perhaps a duplicate of #132, which didn't get a lot of uptake on the discussion forum. Perhaps better tp cpntinue this there.


Relax rack requirement

Makes loading with pow, passenger, etc. easier which may have preloaded a later version of rack.

Thank you @sj26!

This is failing with 1.8. Fine with 1.9, though.