change function invocation for new arrow function

Issue #, if available:
function invoke not working 🙁
Description of changes:
I have been changed function invocation for following arrow function template
arrow function template file
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3178 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #3178    +/-   ##
========================================
  Coverage   59.36%   59.36%
========================================
  Files         254      254
  Lines       12567    12567
  Branches     2590     2419   -171
========================================
  Hits         7461     7461
- Misses       4782     4792    +10
+ Partials      324      314    -10

Impacted Files
Coverage Δ

...psync-simulator/src/resolvers/pipeline-resolver.ts
10% <0%> (ø)
:arrow_up:

packages/amplify-appsync-simulator/src/index.ts
73.68% <0%> (ø)
:arrow_up:

...c-simulator/src/schema/directives/aws-subscribe.ts
26.66% <0%> (ø)
:arrow_up:

packages/amplify-cli/src/context-extensions.ts
25.69% <0%> (ø)
:arrow_up:

...amplify-appsync-simulator/src/server/operations.ts
28.45% <0%> (ø)
:arrow_up:

...mplify-appsync-simulator/src/resolvers/function.ts
10.34% <0%> (ø)
:arrow_up:

...lify-graphql-types-generator/src/compiler/index.ts
90.32% <0%> (ø)
:arrow_up:

...plify-appsync-simulator/src/server/subscription.ts
26.81% <0%> (ø)
:arrow_up:

...y-graphql-types-generator/src/compiler/legacyIR.ts
96.72% <0%> (ø)
:arrow_up:

...ages/amplify-appsync-simulator/src/server/index.ts
64.28% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61c0769...a56f2de. Read the comment docs.

Hi @alikadir, with the latest CLI release (4, we have significantly refactored local function invocation. Can you check if the changes solve this problem for you?

hi @edwardfoyle
I've tried local function invocation with CLI 4.18 but unfortunately my problem is not resolved. 😔
Local function Invocation has sent event parameter (json file) as string
However it should send event parameter (json file) as object because aws console works this way
exports.handler = async event => {
    return typeof event
}
// local invocation via amplify cli = "string"
// upload lambda function and test with event template on aws console = "object"

by the way, how to do debug the function during local invocation?
amplify mock function DisasterApiLogin --inspect=56884 --debug-brk //not working

@alikadir Ah yeah looks like you're right. It was a super small fix so I went ahead and made a PR for it here: https://github.com/aws-amplify/amplify-cli/pull/3895

closing this as #3895 has been merged


feat: Search crud APIs

Describe your changes
This diff implementing the following search APIs

Creating document by Id
Creating multiple documents
Creating or replacing multiple documents
Updating multiple documents
Deleting multiple documents
Reading multiple documents

How best to test these changes
Issue ticket number and link

Codecov Report
Base: 32.42% // Head: 32.20% // Decreases project coverage by -0.23% :warning:

Coverage data is based on head (5df0b24) compared to base (050d47a).
Patch coverage: 28.52% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   32.42%   32.20%   -0.23%
==========================================
  Files         128      133       +5
  Lines       14367    15255     +888
==========================================
+ Hits         4659     4913     +254
- Misses       9277     9866     +589
- Partials      431      476      +45

Impacted Files
Coverage Δ

api/server/v1/cache.go
0.00% <0.00%> (ø)

api/server/v1/marshaler.go
10.84% <0.00%> (-0.38%)
:arrow_down:

api/server/v1/search.go
0.00% <0.00%> (ø)

api/server/v1/validator.go
0.00% <0.00%> (ø)

query/read/fields.go
26.31% <0.00%> (-0.57%)
:arrow_down:

query/update/operator.go
72.09% <ø> (ø)

schema/reserved.go
100.00% <ø> (ø)

server/metadata/database.go
93.93% <0.00%> (ø)

server/metadata/errors.go
30.43% <0.00%> (+30.43%)
:arrow_up:

server/services/v1/api.go
0.00% <0.00%> (ø)

... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Clippy fixes

This PR was compiled with findings from:
cargo clippy --all-targets --all-features -- -Dwarnings

There were 3 other findings not included here because once those tests were fixed they started failing. Looking into that and hopefully there will be a subsequent PR fixing those as well.

Unrelated build failures have been fixed now, please rebate.


Please invite me to the GitHub Community Organization

🎉🎊Welcome to Jaidev Studio🎉🎊!!

Why not contribute to...
Unique-Github-Profiles!

You can also show that you are part of this org, by making yourself public. This will show our profile org on your profile:
Follow This:

After you join the organisation, search your name in the list of people. 🔍
Follow this below: ⬇

i have completed these steps

i have completed these steps

@akshitagupta15june

Your are become a team member of every repo
You can change everything in repo without any push or pull
Thank you
Promise We do our best

@akshitagupta15june
plz collborate with us

Ok, Thankyou


IE11 & Firefox (59.0.2) - Highlighting of text while dragging (before and after drop)

While dragging an element that contains text to the drop area, if you pass over an area that contains text it will become and stay highlighted in IE & Firefox. This was replicated with your demo site. Any way to fix this behavior?

Fixed in https://github.com/mattlewis92/angular-calendar/pull/521

With safari it's required to apply user-select: none to all document elements in order for it to work which is a pain to implement manually, so I've baked the into the package so it all works out the box. You can try it out with:
npm i angular-draggable-droppable@alpha


When BubbleCursor extension is disabled change icon

Currently extension always shows same icon

When we disable extension change icon.

Can you assign this issue to me ?


Fix display of types of polylines issue

For these 4 subtypes of polylines:

polylineOutline
polylineGlow
polylineArrow
polylineDash

The resulting JSON code, did not match the needed format, so they would not display properly.
I added the needed key for formatting them properly and wrote tests for them.

Thanks for your contribution @mstill3 ! Before I have a closer look, it seems that there are some whitespace issues. Would you please run tox -e reformat and commit the result?


Fix CI error due to new numpy

Temporary skip numpy 1.20 deprecation warning as the most stable cupy version does not have guaranteed support for it.

Dup #120


Don't attempt to hide colour picker if it's not visible

Hello,
I have some complicated pages with colour pickers on them, and whenever the user clicks anywhere on the page it triggers a digest cycle. This is a bit of a problem when combined with numeric inputs or other elements on the page which get clicked a lot :) I'm assuming this is necessary to ensure the colour picker hides though, so I was wondering if it would be possible to only trigger the cycle if the colour picker is already showing.
Thanks for your help :)

Thanks for your quick reply. That seems to work great! The colour picker still disappears when clicking off it, and the digest cycle no longer triggers on every mouse click. If you're happy with the change, should I run a grunt build and get the newly generated JS committed?

That would be great. Follow the release file if you haven't already found it. Make it v0.8.2.
Could you also run git rebase -i master to squish the current three commits down into one.
Thanks :+1:

Done. Let me know if I've missed anything!

Merged and released in v0.8.2. Thanks for the pull request!


gaussian splatting

Gaussian splatting close to done in nerfstudio with minimal hacks to have it integrated, anyone else interested in pitching in help clean up some of the residual TODOs I’ve left around for myself and to get some of the bells and whistles like pruning / cloning done.
I tried to focus on making sure this is clean and super easy to merge into main with good typing and minimal changes / still being consistent with all our existing classes and everything, but its still not perfect and in a day or so I’ll open it up as a PR and start taking some feedback. For now, I didnt create any new abstract classes, I just updated the datamanager to output Union[RayBundle, Camera] instead of RayBundle and that sort of thing (and I actually think its pretty clean this way and might keep it this way tbh).
As of writing this, this still uses the original gaussian splatting rasterizing just to make sure that all this infra works, but it should be a drop in replacement with our new homebrew splatting code. Same goes for a bunch of other places in the code that are currently transplants of their code for testing purposes only, with the intent to fully remove and replace those parts of the code with entirely novel code ASAP.

Removing until we have a novel implementation


Reduced several lines

As far as I know, this makes the code equally efficient and slightly more readable.

Apologies if I've done something wrong: I've pretty much never even used Pixi.js or contributed to open source, but this seemed like an innocuous change.

Can you create a jsperf that proves this is the same or faster? Looks like a good change if it is, but I'm not sure that the function call overhead is cheaper..

Apologies. I looked this up beforehand and found a StackOverflow question and attached jsperf which revealed very similar results, but I created a jsperf that directly compares what this code is actually doing and found that the current way is much better than the proposed way.
JSPerf here: http://jsperf.com/math-min-vs-ternary-operators

All good, I had a hunch that might have been the case. Thanks for taking the time to look into this!


feat: ini fly config

Current dependencies on/for this PR:

main

PR #178   👈

This comment was auto-generated by Graphite.


Clean up expired docs.

Motivation:
Since the extractFrame has used retainedSlice to avoid memory copy, we should clean this doc that was expired.
Result:
Better doc.

@netty-bot test this please


opening problem with Manjaro OS

I've recently installed neovide on my Manjaro(KDE) for the handsome gui of nvim.
But when i run neovide my compositor changes OpenGL 3.1 to XRender and my latte-dock freeze. i get this message from the terminal:
Ignored client type property: "methods" Ignored client type property: "attributes" MESA-INTEL: warning: Performance support disabled, consider sysctl dev.i915.perf_stream_paranoid=0
Everything becomes normal when i close neovide.

neovide uses vulkan today. Not opengl. I suspect that is the reason. I know nothing about Manjaro though so I'm not sure how to help debug further.
I am investigating an opengl backend, but I wouldn't hold my breath for it in the immediate short term.

@RomjanHossain would you be willing to try the new main branch? It introduces an opengl renderer.

i just updated the neovide pkg from AUR and it's all OK. I've no longer any rendering issue.

Aur is actually running an older version that is somewhat stable, it just
has a couple rendering quirks and isn't internationally friendly ie it
doesn't have multiple keyboard support.
On Fri, Mar 5, 2021, 5:13 PM Romjan D. Hossain<EMAIL_ADDRESS>wrote:

Closed #477 https://github.com/Kethku/neovide/issues/477.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Kethku/neovide/issues/477#event-4416303328, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6S7PZHRR6WI4YZRCK66ZLTCF6TNANCNFSM4X4SZ23Q
.


SQL Server: ResultSet is read-only when column aliases are used

System information:

Operating system (distribution) and version Win
DBeaver version <IP_ADDRESS>205310836

Connection specification:

Database name and version SQL Server

Steps to reproduce, if exist:
Write a select statement with column aliases in the SQL Editor and execute it
Expected: the table can be edited in the ResultSet
Actual result: the table is read-only

Fixed for all databases.
Now WHERE clause containes resolved column names instead of aliases


Provide a way to customize default serviceName in RequestLog

The default serviceName of a service is an FQCN of the innermost class.
And a serviceName could get overridden by ctx.logBuilder().name(serviceName, methodName).
Sometimes, users want to globally change the serviceName convention to a simple name of the innermost class.
We might provide an option to ServerBuilder such as:
Server.builder()
     .serviceNaming(serviceName -> {
          var lastDotIndex = serviceName.lastIndexOf('.');
          if (lastDotIndex > -1) {
              return serviceName.substring(lastDotIndex, serviceName.length());
          }
          ...
     });

And we can also provide a built-in abbreviation algorithm like logback's Conversion Word.
ServiceNameRule.shorten(15);

For me, it should be useful for sure. Not only abbreviation algorithm but also other rules seems good to be flags. For example,

ServiceNamingRule.dot.last(2) to pick last two concatenation separated by dot.
ServiceNamingRule.simple to pick just class name.
ServiceNamingRule.shorten(15)

That's a nice suggestion. Are you interested in sending a PR? 😉

I hope so. 🤣 I am curious about the preference for this of you. If the user invokes ServerBuilder#serviceNaming and injects MeterIdPrefixFunction, should it be combinable? how can we deal with?
https://github.com/line/armeria/blob/master/spring/boot2-autoconfigure/src/main/java/com/linecorp/armeria/spring/AbstractArmeriaAutoConfiguration.java#L74-L76

I think ServerBuilder.serviceNaming could be applied to RequestLog.serviceName if a user does not specify serviceName explicitly.
MeterIdPrefixFunction will use RequestLog.serviceName itself without any modifications.

The ServerBuilder#serviceNaming will customize the populated newServiceName in the following code.
https://github.com/line/armeria/blob/8689584b4288fe224385f284ec88049afa96e590/core/src/main/java/com/linecorp/armeria/common/logging/DefaultRequestLog.java#L1050-L1068

Before PR, I would like to share the plan first. First of all, I consider to support serviceNaming(Function) without ServiceNameRule and improve later.
For me, the config is supposed to be delivered from ServiceConfig and used under DefaultRequestLog you referred.
In other words, I will propose

AbstractServiceBindingBuilder#serviceNaming
ServiceBindingBuilder#serviceNaming
ServiceConfigSetters#serviceNaming
DefaultServiceConfigSetters#serviceNaming
and call like serviceName = config.serviceNaming().apply(newServiceName) instead of serviceName = newServiceName in DefaultRequestLog#setNamesIfAbsent.

If you mind something, please give me an opinion.

As you know, users can customize the default serviceName using ServiceBindingBuilder.defaultServiceName().
That means we don't need to serviceNaming rule at a service level.
Is it better to apply to a server level by adding ServerBuilder.serviceNaming(Function<String, String>)?

and call like serviceName = config.serviceNaming().apply(newServiceName) instead of serviceName = newServiceName in DefaultRequestLog#setNamesIfAbsent.

Then, this should be ctx.config().server().config().serviceNaming().apply(...).

users can customize the default serviceName using ServiceBindingBuilder.defaultServiceName().

I also thought the case that a user uses serviceNaming without using defaultServiceName. It was because I consider serviceNaming as a post processor. For example, even if users set a default service name to blahblah and the function which picks first two letters is given, the service name become bl finally. IMHO, it will be more useful with logback's shorten algorithm.
If we only apply the rule in server level not service level as you said, is it better to name ServerBuilder#defaultServiceNaming instead of just serviceNaming?
In short, it depends on needs. WDYT?

For me, it should be useful for sure. IMHO, not only abbreviation algorithm but also other rules seems good to be flags. For instance,
1. `ServiceNamingRule.dot.last(2)` to pick last two concatenation separated by dot.

2. `ServiceNamingRule.simple` to pick just class name.

3. `ServiceNamingRule.shorten(15)`

You don't have to implement all of these implementations at once. You might want to start by designing an API and add more implementations later.

I also thought the case that a user uses serviceNaming without using defaultServiceName. It was because I consider serviceNaming as a post processor. For example, even if users set a default service name to blahblah and the function which picks first two letters is given, the service name become bl finally. IMHO, it will be more useful with logback's shorten algorithm.

A serviceNaming function could be applied to a defaultServiceName.
However, I am wondering if users need a serviceNaming rule for a specific service.
Because if a defaulServiceName is set, users already knows when serviceNaming(...) is configured.
Server.builder()
      .route()
      .defaultServiceName("foobar")
      .serviceNaming(name -> name.substring(...))
      .build(new MyService())

Do you have cases that such sophisticated serviceNaming rules are required? Otherwise, I prefer ServerBuilder.serviceNaming() to give simplicity and reduce confusion. :-)

ServerBuilder.serviceNaming()

I see. It seems that I unnecessarily worried layered serviceNaming. Agreed that the suggestion makes the problem simple and reduce confusion. Let me try in that way.

Can we close this issue? @ikhoon

Nice catch! This was fixed by #3453.


HDDS-4171. DEFAULT_PIPELIME_LIMIT typo in MiniOzoneCluster.java

What changes were proposed in this pull request?
DEFAULT_PIPELIME_LIMIT was changed to DEFAULT_PIPELINE_LIMIT in MiniOzoneCluster.java
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4171?jql=project in (HDDS%2C DAFFODIL) AND status in (Open%2C "In Progress") AND text ~ "typos"
How was this patch tested?
N/A since a typo

Thank you for taking this up @shashank195! the changes look good to me, awaiting green CI.

Thanks @shashank195 for the patch, @JyotinderSingh for the review.

How was this patch tested?
N/A since a typo

@shashank195 Note that testing such a change can be as simple as compiling the project.
Also, if you enable workflows in your fork, you can link to a successful CI run.  Here is an example from my fork: https://github.com/adoroszlai/hadoop-ozone/actions/runs/1979061759


Bash completion doesn't work for subcommands of subcommands

My urfave/cli version is
github.com/urfave/cli/v2 v2.23.6
Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

My project is using go modules.

Describe the bug
Bash completion (arg --generate-bash-completion and option EnableBashCompletion) does not provide completion for subcommands of subcommands.
To reproduce
https://go.dev/play/p/aO7adBNLVCf
Observed behavior
It returns commands below alpha.
$ ./app alpha beta --generate-bash-completion
beta
help
h

Expected behavior
It should returns commands below beta  (ie. gamma)
$ ./app alpha beta --generate-bash-completion
gamma
help
h

Run go version and paste its output here
$ go version
go version go1.18.8 darwin/amd64

@tchandelle Can you check if PR fixes your issue ? Thanks

Thanks @dearchap, that was fast! Yes it works!

@tchandelle v2.23.7 has the fix. Thanks for raising the issue


Write a Wiki page to explain how a host app can display a read-only/locked canvas

Ref: 3262

Written! Here: https://github.com/elyra-ai/canvas/wiki/2.4.6-Constructing-a-read-only-or-locked-canvas


[feat] NextJS App

Continuation #42
Next.js application in the project root called blobby that implements the application logic for the Figma designs bootstrapped here:
https://github.com/keep-starknet-strange/blobstream-starknet/issues/59#issuecomment-1930800975

Hi @drspacemn can i take on this

Just merged @faytey's PR setting up the blobby demo's frontend. The following application logic is still needed, from what I understand :

Dynamically generate the SVG base64 encoding from the input on step 1 and output on step 2.
Properly decode and display the SVG in step (6) after input is given

ok i just worked on the dummy UI, the full integration will be done when some things are available as mentioned by @drspacemn

So can i work on another Issue now

Nice work. Feel free to comment on another ticket you would feel comfortable with

Nice work. Feel free to comment on another ticket you would feel comfortable with

Can you assist with open available issues please, @drspacemn @b-j-roberts

Ahh good point. Okay will notify you in TG when we open new issues

Thanks a lot


Can NetherSX2 Have A Music , Video , Player option like the Original PS2 for Nethersx2

There are better ways to listen to music and watch movies on your phone than trying to run it through an emulator


Tag blacklist ignored when supplying credentials to chan.sankakucomplex.com

What steps will reproduce the problem?

Set some blacklisted tags
Supply login details for chan.sankakucomplex

What is the expected behavior? What do you get instead?

Expected: Ignore images with blacklisted tags.
Get: All images downloaded

What version of the program are you using? On what operating system?
5.0.0 Windows 10
Please provide any additional information below

Which blacklist are you referring to, exactly?
Grabber's blacklist, that can be set in the settings, or Sankaku's, that is set on your account settings on their website? (in My account > Settings > Tag Blacklist) If it's the latter, that's "semi-intended", in the way that it's up to Sankaku to return filtered results.
If they don't, the best solution in this case it to simply copy your blacklist in Grabber's settings. This way, it will also be applied to other sources.

Grabber's blacklist is being ignored. If I don't supply credentials grabber ignores images with blacklisted tags. If I supply credentials Grabber will just download everything irrespective of whether or not there are blacklisted tags attached to a file.
I have Sankaku set with the same blacklist minus a few but Sankaku isn't filtering either unless I browse manually but thats an issue for them.

Strange, I just tried (sorry for the delay) and could not reproduce this issue in v5.1.0. Which is pretty expected considering the authentication and blacklist filtering are completely dissociated in Grabber.

Is the "Get blacklisted" column properly set to "false" for these downloads?

Yes, it's set to false by default.
I just tried again however with 5.1.1 and it worked as expected. Not sure who fixed what but I'll keep an eye on it and see if it ignores the blacklist again at any point.

I'm closing the issue then.
Feel free to re-open here if the issue occurs again.
I believe it came from the fact that the Sankaku tag recognition was sometimes broken, leading to having images "without" tags during downloads. And without tags, no blacklist.


Proposal: Better F# support

Proposal: Better F# support

Summary

F# is a popular functional-style programming language that has default support in Visual Studio for .NET console apps and libraries, but not for UI apps. With WinUI 3.0 we have an opportunity to enable first-class support for F# in Xaml apps.
Rationale

Better F# support was noted as a good opportunity to improve WinUI in the 3.0 roadmap discussion issue.
This would enable Xaml apps to use F# where most appropriate, e.g. for business logic to benefit from F#'s concision, testability, type system and correctness guarantees.

Scope

Capability
Priority

Enable using F# for app business logic
Must

Enable using Visual Studio F# tools with Xaml apps
Must

Provide F# samples
Should

Enable using F# for Xaml page codebehind partial classes
Could

Enable mixing and matching languages (e.g. F# for data and logic, C# for UI + bindings)
Could

Provide F# project templates
Could

Important Notes

Open Questions

Is existing xlang support sufficient (with new samples)?

What types of templates or samples would be useful?

Should this include supporting Xaml page codebehind files?

Could/should this include mixing languages in a project?

Duplicate of #736

Duplicate of #736

That's a PR to add it to the roadmap doc - we'd like to have an issue to track this as well 😊

@jesbis  Fair enough.  The more F# the better.  Keep people happy, and ensures WinUI 3.0 encompasses as much of Microsoft dev platforms as possible. 😀

F# I see two important approaches:

Make the F# (mutable) Records XAML Binding Friendly;

Elmish style

Both could be supported, and have samples. Maybe on future only 1 trend become more used.
We will need the F# Project Templates for UI on the .NET 5

It would be great to mix and match F# and C# in a single project.  Use F# for data stuff, and C# for UI/Commanding.

F# only + GUI should work perfectly, standalone.
It if does this, then obviously mix with C# is easy.

@jesbis

Enable using F# for app business logic | Must
Enable mixing and matching languages (e.g. F# for data and logic, C# for UI + bindings) | Could

These seem the same, and are implied by allowing C# projects referencing WinUI to also reference any .Net projects. That should be a given (assuming that you can access WinUI by installing a nuget package).
(But if 5. means mixing and matching languages within the same project, that's not possible because of ordering differences between C# and F#.)

Enable using Visual Studio F# tools with Xaml apps | Must

Can you clarify this? "Xaml" is very confusing at the moment. If "Xaml" means the markup language, then it's a complex issue possibly to be solved with a type provider (see link below). But if "Xaml apps" means "WinUI apps" then this is just part of 1.

Enable using F# for Xaml page codebehind partial classes | Could

See discussion of partial classes/XAML type providers/BAML compilation here: https://github.com/dotnet/wpf/issues/162 .

Currently it is not possible to build UWP UIs in F#. By shipping the whole UI Layer (as planned in Win UI 3.0) this will at least be possible, and I'm impatiently looking forward to it.
1: Is existing xlang support sufficient (with new samples)?
Personally ok with that, basic templates would be nice.
2: What types of templates or samples would be useful?
Basic samples would be a nice starting point.
3: Should this include supporting Xaml page codebehind files?
I think a lot of F# Developers would prefer a MVU approach for building UIs.
Typical XAML + MVVM relies on mutability, something like Fabolous** specific for UWP would be a huge selling point (in my opinion).
4: Could/should this include mixing languages in a project?
Can imagine this to get messy. F# depends on file order.

Something I'll note is that supporting .NET Core completely implies supporting F#. So if a goal is, e.g., supporting .NET Core 3.0, then F# support comes with that. However this does not imply a level of tooling support, such as designers.

If the F# (mutable) Records XAML were Binding Friendly and we had some example, with UI Commands included, I think that the Designer would work with the same tooling from C#, and we would have the "code behind" + Data objects in F#.
For example: How to do a WinUI GUI of a Invoice screen that has Customer, Invoice, Invoice Items. With buttons New Invoice, select customer, Add / Remove Invoice Items.
How to model it in F# and Bind the Data to the UI, and Bind the Button commands to F# functions ?

@TonyHenrique The native binding approach in .Net UIs (WPF/UWP/Xamarin/Avalonia) has severe weaknesses: complete lack of type safety, hacky implementation of maps ("converters"), magic strings everywhere. Not a good fit for F#. It is better to ignore this infrastructure and use either moderate functional approaches (reactive approaches such as Gjallarhorn - you might see these as properly done implementations of binding) or extreme functional approaches (Elmish, e.g. Fabulous).
Better to use xaml purely for design and have a type provider give access to the UI objects (as in FsXaml for WPF).

A WinUI XAML F# type provider would be a cool approach to separate the UI code from the events and data binding code.
(What worries me in elmish is that for large, complex UI, mixed inside the code, It tends to look like old php spaghetti code.)
Now, please release it with a proper sample, having the .xaml and .fs file with, like I said, a Window with 3 level items: customer, invoice, invoice items and add/remove items, for example.

Another thing that could be done is to allow XAML literals in C#/F# code.
This would enable code like this
let myButton title = <Button Text=title />

No thanks, I'm satisfied with the Fabulous/Fable way of declaring views.

@tonyhenrique I disagree. It's not up to MS to decide how we should develop UIs in F#. There's room enough for several approaches, although I personally prefer the Elmish style because it takes full advantage of F# rather than having to mess around with mutable data structures everywhere.

@isaacabraham Is it possible to use Elmish MVU, with a WinUI XAML Type Provider, and having a the UI declaration in a separate XAML file ? This would allow to use the regular XAML editor, but having the immutability and type safety of F#.
About MS deciding this, there are many advantages. Having a proper F# GUI Visual Studio Project template for the selected way (mutable, gjallahorn, or elmish with separate XAML file) would be awesome.
I would be very interested in seeing this.

I can't comment on WinUI but we have WPF apps in a pure F# solution that use the built-in VS XAML designer + the XAML Type Provider. We used FSharp.ViewModule although we'd probably today use the Elmish WPF library.
Regarding templates, I have mixed feelings about them. Firstly, whilst they are useful as a tool to raise marketing and awareness, they are difficult to change and inflexible. A better solution IMHO would be a dotnet template and / or nuget package - something more code focused rather than being coupled into VS - we've moved on (or should be moving away) from that IMHO.
This also comes right back to whether this is a "MS" decision or something that is community led or not. Rather than relying on MS to decide what this looks like, why not be proactive and create something without waiting / relying on someone else.

Thank you @mdtauk @TonyHenrique @charlesroddie @JaggerJo @cartermp @Happypig375 @isaacabraham and others for your thoughtful comments on this issue! I am helping the UWP Xaml team to determine if and how to invest in F# support. What kind(s) of support would be most helpful when creating F# apps?

For me, the most helpful would be to have the F# WinUI GUI project template for Visual Studio 2019, that has a WinUI XAML Type Provider, that allows to use the regular XAML editor, but having the F# Code Behind, in Gjallarhorn and/or Elmish.

@kathyang  The basic thing needed is to allow UWP to be installed via a nuget package. This will allow use of UWP views from any .Net language.
Work to make help type providers would be appreciated but would require some detailed discussion. It's hard to see how the community can maintain 3 type providers, especially because it's currently one person @ReedCopsey doing this (with the FsXaml WPF type provider). A UWP type provider developed separately wouldn't have the usage to justify the work in the near future. If there could be some consolidation of the various Xaml flavours then type providers could be made for WPF/UWP/XF that share the same structure. These type providers wouldn't need have support for all possible Xaml as F# usage doesn't have the same priorities (C# devs often advocate no code in View projects which then requires code-like features in Xaml).

@charlesroddie That's a good point about type providers. Could you clarify for me - when you said "allow UWP to be installed via a nuget package. This will allow use of UWP views from any .Net language", do you mean something different from this?

@kathyang Microsoft.UI.Xaml is the right type of thing (naming aside). If this can be made to work in any .Net project, and contains all the UWP View classes, then it would be the main step in F# support.
Currently Microsoft.UI.Xaml works in special UWP projects (and there is no such project for F#), but not in .Net Standard projects (The namespace UI is not defined).

Thank you to everyone for your helpful knowledge! Our team has discussed this and determined that we don't have the resources to invest in this right now as we're focusing on WinUI 2.2 and WinUI 3 and many important features going into these releases. Once WinUI 3 ships and the XAML framework is decoupled from the OS, we and the community can revisit this together. I’m adding the needs-winui-3 label to this issue, and please continue to share your comments on F# support in this discussion so your voice is heard when we come back to this later!

Is there any update on this?

What kind(s) of support would be most helpful when creating F# apps?
Fix #5402 🙂

I made https://github.com/xperiandri/Elmish.Uno production-ready after the initial work of @jeromelaban.
I have a first-ever enterprise-grade Elmish template working with UWP and all Uno-supported platforms.
You can try it via dotnet new -i "Elmish.Uno.ProjectTemplates.Dotnet::1.0.0-ci-*" --nuget-source "https://www.myget.org/F/elmish_uno/api/v3/index.json"
But after I moved all C# UWP code to F# for WinUI on .NET 5 it no longer works 🙁.

What would it take to move this feature out of the freezer?

XAML Standard is dead. For F# app development look to:

https://github.com/fabulous-dev/Fabulous.Avalonia
https://github.com/fsprojects/Avalonia.FuncUI
https://github.com/RonaldSchlenker/Vide
https://github.com/JordanMarr/Elmish.Avalonia

@Happypig375, I guess you mean https://github.com/microsoft/xaml-standard?
I wasn't hoping to write any XAML, I wanted to write an app with WinAppSDK and F#.

@NickDarvey Ah oops I read the name of this repository wrong. But alternatives are still there for F# desktop development - through Avalonia.


Improve ease to add low level menus

We get very tired while trying to change level of the last menu to 2nd level
https://user-images.githubusercontent.com/1363876/159713111-e2cf3ee4-ddaf-4e8c-904e-1f2d46bdfc73.mov

Hey @sekmenhuseyin,
Exciting to see Cogworks are using Meganav 😎
I can see why the current behaviour is a little frustrating, it might be a bug in the Angular UI Tree library Meganav uses.
We are having some discussions over on #15 about how we can improve the keyboard navigation of the editor, including for moving position of items. If you have any ideas please chip in!
I'd be very happy to accept a PR if you have a fix for this, otherwise any ideas how we can improve it?
Cheers,
Callum

How interesting that the angular ui tree has stopped active development for 4-5 years
and I've noticed it now


SKR networking test

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest

/retest

Approve of https://github.com/kyma-project/kyma-environment-broker/commit/f626e2f342d298979a64ecf428125f360c911023 a nothing else because of previous @szwedm review.

/retest

/retest


Add appendable global .gitattributes file

This should prevent most line-ending issues, e.g. https://github.com/exercism/docs/pull/148.
@SleeplessByte

This seems fairly harmless as it can't delete any labels.

Doesn't seem to copy the files:

https://github.com/exercism/Exercism.jl/pull/28/files (without append)
https://github.com/exercism/julia/pull/409/files (with append)

It works:

https://github.com/exercism/Exercism.jl/pull/29/files (without append)
https://github.com/exercism/julia/pull/409/files (with append)

(cc @sleeplessbyte)

@SaschaMann linked to https://rehansaeed.com/gitattributes-best-practices/ which contains the following:
# Force bash scripts to always use lf line endings so that if a repo is accessed
# in Unix via a file share from Windows, the scripts will work.
*.sh text eol=lf

This is taken from the dotnet/corefx .gitattributes file and I quite like it. Maybe we can add that?

My take on this, is that there's no downside to being over-zealous in this file. While I get it's in some ways annoying to have files listed that shouldn't be in git (and that most-likely won't get to our git repos), I don't see a downside to being overtly cautious. So while adding project files, or IDE files to this may feel unnecessary, if someone starts a track for "CsharpScript" and that reuses `. csproj, I'd rather not have to remember to add this as an append, and if someone does upload an PDF because they feel its important (e.g. a licence), I'd rather that other maintainer who tries to use that repo later doesn't have to fight with line-endings as part of that. Even if we would rather they found a way to not upload the PDF. ie, I'd rather be proactive in this, rather than reactively trying to police all commits to ensure that such files don't get added.
So laying any general thoughts on what should/shouldn't be here in an ideal world, are there any downsides from a functional perspective to adding this file everywhere?

@SaschaMann linked to https://rehansaeed.com/gitattributes-best-practices/ which contains the following:
# Force bash scripts to always use lf line endings so that if a repo is accessed
# in Unix via a file share from Windows, the scripts will work.
*.sh text eol=lf

This is taken from the dotnet/corefx .gitattributes file and I quite like it. Maybe we can add that?

@ErikSchierboom Want to add this as a suggestion in some appropriate spot?

@ErikSchierboom Do you want to add the batch-equivalent listed in that post too?
# Force batch scripts to always use CRLF line endings so that if a repo is accessed
# in Windows via a file share from Linux, the scripts will work.
*.{cmd,[cC][mM][dD]} text eol=crlf
*.{bat,[bB][aA][tT]} text eol=crlf

@ErikSchierboom Want to add this as a GitHub "suggestion" in some appropriate spot?

Done.

@ErikSchierboom Do you want to add the batch-equivalent listed in that post too?

🤷 I find that scenario for more unlikely than the shell based one, so I would be fine with adding it or not having it.

🤷 I find that scenario for more unlikely than the shell based one, so I would be fine with adding it or not having it.

I don't care much either, but there seem to be a fair amount of .bat scripts: https://github.com/search?q=org%3Aexercism++extension%3Abat&type=Code&ref=advsearch&l=&l=

I don't care much either, but there seem to be a fair amount of .bat scripts:

Maybe just add it then?

GitHub's UI is being annoying, need to check manually that the newlines at the end are correct (@ErikSchierboom it's the same issue as we had before)

I'm off today, but I'll check tomorrow @SaschaMann!

@SaschaMann It looked like the newline was indeed missing, so I've added it in https://github.com/exercism/org-wide-files/pull/19/commits/0182cd67a9386d891272ec2a6f18d624d112ce76. I've checked with both vi and a bit of F# code, and both seem to confirm that there is now an empty line at the end of the file.

Any new ideas here?

I think we should still pursue this. I have to get a diff from the existing .gitattributes files.

Recent problem with a track that does have a .gitattributes file: https://github.com/exercism/java/pull/2103
If we do this, do we also need CI to enforce that a PR does not add the wrong kind of line endings?


Add PostgreSQL cli to the existing AWS AMIs

Description:
Need to modify existing Ubuntu & CentOS AMIs to include MySQL cli. This will reduce the burden and time of the product deployment by not-having to install mysql client when deploying the product.
Related Issues:
#412

Added required changes to the AMIs.


prevent crash when event doesn't match

This seems to be happening on MacOS in combination with the Zed editor.
It may be nicer to return a detailed error instead, but that would change the existing API, which I didn't want to do.
Also bumps the devenv so it uses Gleam 1.0

in combination with the Zed editor.

We did a little extra digging and it seems like just a MacOS thing: zed, vscode, vim all had the same error.


Grafana services and docker image update

Can one of the admins verify this patch?

/cc @vishh @jimmidyson
If we have an agreement on using apache + its reverse proxy I can go ahead and complete that as well.

ok to test

LGTM. Thanks for the cleanup @simon3z. Will merge once the tests pass.
@simon3z: Lets discuss about apache vs native go server in #183.

@simon3z: #183 acheives the same goals as this PR. It includes the reverse proxy changes as well. Can you take a look at that and see if that works for you?

@simon3z: I merged #183 yesterday which adds a RP to access Influxdb. Can you see if that works for you?


Authorization fieds

Hi,
In admin page, in a resource, in Authorization section, there are fields for HTTP verbs and resources created in that API.
Which some of them disabled by default due to the fact that they are not made available (to be used), which is a correct behavior.
The problem is, after clicking on the save button (does not matter if you select some check buttons or not) ALL of the fields become available to be selected and saved again.
As far as I know fields that are not available should stay disabled but their state changes after clicking save button.

@baghayi I'm closing this because I tried with the last version of Apigility 1.3.1 and it works fine.


Pre-trained COCO Model Weights

In your README it states that there are pretrained backbones for the COCO dataset. However I am not able to find where they are located. Where can I find them?

We are initializing backbones using weights from pre-trained pytorch/vision models when doing full training, see code.
You can find the url of these weights from pytorch/vision here. I believe these were trained on ImageNet.
We are working on providing fully pre-trained models where the detection model has been trained on COCO, stay tuned.

Hi @florischabert Thanks for providing such a good repo! Any potential dates for the release of the pretrained model?

Sorry, it's not clear yet when it'll be available. I'll ping this thread when it is.

Any pretrained retinanet model available in this fork.

up on pretrained weights


Question: distance measurement

Hi,
I am getting 2 different distances of the same object based on what streams I enable. See the 'z' distance
When i enable on nn stream and see the previewout, i get this
python3 depthai_demo.py  -s metaout previewout,12

But when i enable nn and disparity, i get this
python3 depthai_demo.py  -s metaout previewout,12 disparity_color,12

Am i missing something ? How can we overlay the nn, depth information and disparity_color results into one ?

Hi @abhatikar ,
Currently the NN packet X,Y,Z calculations are not correct when disparity or disparity_color streams are enabled, but only with depth. We will fix this, or first prevent the usage of those streams together with X,Y,Z calc.
About the overlay, you can also try the -bb / --draw-bb-depth argument:
./depthai_demo.py -s previewout metaout depth -bb
The inner blue rectangle represents the area from the depth map that gets averaged for X,Y,Z calculations.

Just as a note this is added to the roadmap to make it so XYZ calculation of the object is not wrong when disparity or disparity_color streams are requested.

Check added in d1caf22 , if disparity/disparity_color stream is requested, depth calculation is disabled, and user is notified.
Will be reverted once support is added.


Manual install of talib and tulind modules necessary. Not documented.

I'm submitting a ...
[ ] bug report
[ ] feature request
[X] question about the decisions made in the repository

Action taken (what you did)

Installed Gecko headless on a box (Ubuntu) following the proper instructions and launched it.

Expected result (what you hoped would happen)

After configuring Gekko properly, when I try to run a back test using preset TULIP or TALIND strategies, it shoud work correctly.

Actual result (unexpected outcome)

The gekko process fails as it cannot find some directories.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

I actually solved the issue by quickly looking into the repo and finding this line in the DockerFile https://github.com/askmike/gekko/blob/stable/Dockerfile#L17
(npm install --production<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Please note that I did not use Docker. It just hinted me toward the right path for fixing the issue. I actually manually ran npm install --production<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>and the problem went away.
Any reason why not to include these dependencies in the package.json (maybe because of Windows) ? If they should be kept out of the package.json, then it might be a good idea to add instructions in the documentation to install them manually to get access to the associated strategies.

Just noticed that a PR was opened a few days ago to address this issue in documentation.
Will be closed by https://github.com/askmike/gekko/pull/1511

@belemaire Came here to tell you I pushed a request for this a few days ago :) In the mean time
npm i talib tulind in case anyone needs to know the answer.

try this if you encounter an error
npm i talib tulind --no-save

not sure what the status was when this issue got opened, but now:
It should be documented: if you run a tulip and talib based strat Gekko will give an error message saying you need to install it!
On top of that it's documented here: https://gekko.wizb.it/docs/strategies/talib_indicators.html


posix: pthread: add logging to pthread key

To align with other POSIX areas, add logging to facilitate better error reporting and diagnostics.

rebased
fixed compliance issue


"input" does not seem to be supported

Thanks for this plugin, it has been very helpful.
I am finding that anytime I have a mutation where one of the fields is an input type using gql I get an "unknown type" error.  In the case below, it will be on SomeInputType.
Everything works fine so the input is probably defined properly.
const SOME_MUTATION = gql`
    mutation updateSomething($id: ID, $foo: SomeInputType!) {   <-- here is where it will show "unknown type"
        updateSomething(id: $id, foo: $foo) {...}
`;

input SomeInputType {
    num: Int!
}

Hi Scott.
Thanks for using the plugin.
Please give the 2.0 beta-1 release a go. Instructions at https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/releases/tag/2.0.0-beta-1
Let me know if there's any issues.
Best regards,
Jim.


Investigate popping from empty stack

This is taken from the squeak-dev list:
"the awful practice of popping an empty stack, leaving stackp = -1, and then pushing back the receiver, something I wish the VM didn't have to support, but does"
Do we also support this?

I think we do, this is used in the ContextPart>>#jump stuff


rtp: add deep copy function for rtcp_msg

We need the deep copy to pass RTCP messages from RX thread to main thread.
Is there a simpler solution? E.g. with encode + decode, or rtcp_msg_print() ?
TODO: retest

But why, I see no writes for rtcp_msg in rtcp handlers? So we have only keep lifetime with mem_ref for mbuf and rtcp_msg right?

But why, I see no writes for rtcp_msg in rtcp handlers? So we have only keep lifetime with mem_ref for mbuf and rtcp_msg right?

Right! After the decoding there should never be a write/change in an rtcp_msg. Yes, a mem_ref() is a good idea.


Issue with k8s.io/docs/concepts/overview/working-with-objects/kubernetes-objects/

This is a Bug Report

Problem:
Proposed Solution:
Page to Update:
https://kubernetes.io/...

the mentioned thing in the deployment files
are enough orelse is there anything else we cam mention ??

Hi @sachet94
Can you explain more about the shortcoming you're reporting here?

/triage needs-information

/close


Add a command to "Search for a string/pattern within a file/standard input"

Add a cross-platform command implementation to search for a string/pattern within an file/standard input similar to 'grep' in Linux.

Hey! I would like to take up on this issue as a student in SLOP. Please assign this issue to me!

Sure, go ahead @kalashjain23

Hey! I was thinking of solving this issue using the Boyer-Moore algorithm (used in GNU grep as well), so am I allowed to make a separate python file in utils.py for that algorithm (namely boyer_moore_algorithm.py) in order to keep pysh.py clean? Or do I have to write that algorithm in pysh.py itself?

Yes @kalashjain23 . You can go ahead and create a separate file for that algorithm.

Hey! Can you please review my PR and tell the required changes to be made!

Sure @kalashjain23


Various fixes

fixes #171 and  #179

there we go much much cleaner pull history now that someone showed me how upstream repo's should work haha


Do events work?

false

https://github.com/project-chip/connectedhomeip/blob/f0f5de0d79ae1c51d7fddbf70900ebac0acd899a/src/app/zap-templates/zcl/data-model/chip/power-source-cluster.xml#L66-L71

This issue was generated by todo-issue based on a TODO comment in f0f5de0d79ae1c51d7fddbf70900ebac0acd899a.

Events generally work.  Nothing right now emits this specific event, as far as I can tell....

@woody-apple Events in the Power source config cluster are optional per latest spec, hence we are not testing for v1.0

Moving out of v1.0 functionality that is optional


MySQL hasOne relation to Mongo

I've never played with MongoDB before but this is really getting me into it. I'm using MySQL to store basic picture data such as filename, filesize etc, and MongoDB to store metadata which might be different for each picture (exif, ifd0) etc.
I've successfully got the MongoDB model set up and saving:
   $user = User::whereUsername('test_username')->first();
   $img = new Image();
   $img->filename = "hello.jpg";
   $img->save();

   $meta = new ImageMeta();
   $meta->exif_maker = "Canon";
   $meta->exif_model = "EOS 500D";
   $meta->save();

   $img->meta()->save($meta);

However when I try to get the metadata back from the image:
   echo $img->meta->exif_maker;

It returns NULL. Am I doing something wrong? If I look at the ImageMeta MongoDB model, I can see an image_id key which is populated with the image_id of the Image model.
Image relation:
$this->hasOne('ImageMeta');

ImageMeta relation:
$this->belongsTo('Image');

Image model table schema:
        Schema::create('images', function(Blueprint $table)
        {
            $table->increments('id');
            $table->string('filename');
            $table->integer('filesize');
            $table->string('hash');
            $table->string('hash_type');
            $table->integer('user_id');
            $table->timestamps();
        });

Any ideas?

https://gist.github.com/ollieread/

can you repost links, i have the same situation.


Use SvelteKit powered docs site

It's using Astro because I couldn't find a good SK option at the time.
https://sveltepress.site/ seems like the best option now.

Closed by #71
A couple of minor issues to fix - such as the logo disappearing when navigating back to the home page (caused by /svelte-headlessui vs /svelte-headlessui/), and it being called Index.


Change to #[styled] #[function_component]

Change #[styled_component] to no longer be a #[function_component] wrapper, and to become a simple function body modifier #[styled] instead.
Breaking changes; low or medium priority. Discussion is not required, PRs can be done either by stylist devs, me, or someone else in the community.
Description
As yew-autoprops 0.4 released, we have been greeted with the following syntax:
#[autoprops]
#[function_component]
pub fn AutopropsComponent() -> Html { ... }

Autoprops only touches props and the function body (to add some implicit clones in front). Assuming #[styled_component] also only slightly modifies the component body, it appears to be changeable to use the same model (becoming #[styled]) with still being able to be compatible with autoprops in either of those two configurations:
#[autoprops]
#[styled]
#[function_component]
pub fn StyledComponent1() -> Html { ... }

#[styled]
#[autoprops]
#[function_component]
pub fn StyledComponent2() -> Html { ... }

[!NOTE]
With yew #3347, the whole chain will look like #[styled] #[autoprops] #[component] or #[autoprops] #[styled] #[component].

Benefits

Shows great future for composability of such procedural macros.
Will give #[styled] to have an easy way to write down some custom options for it (if that will ever be needed).
Consistency with #[autoprops] - this one is fully up to stylist to decide, its just a bonus lol
Changes are independent of Yew's slow development cycle, and can be implemented with a subsequent release at any point.
Will get rid of the need to fix up stylist upon yew #3347, since it will no longer contain references to #[function_component] in its code.

Drawbacks

Extra ] #[function for the users.
Generating #[function_component] ensured that the result will make a yew-compatible code. If stylist uses hooks in the generated body, it will have no proper way to check whether user used #[function_component], which may lead to a non-user-friendly error.

Alternative
Leave only autoprops supporting this. Following syntax should already work now:
#[autoprops]
#[styled_component]
pub fn StyledComponent() -> Html { ... }

[!WARNING]
Mind that yew #3347 will require a stylist change to use #[::yew::functional::component] or something similar.

As was mentioned to me over Discord, this PR combines #[styled_component_impl] and #[styled_component] into #[styled]. Possibly, just rename #[styled_component_impl] then, but still beware of that #[component] Yew PR breaking #[styled_component].

Thank you for the proposal.
The reason why I brought up that #[autoprops] cannot be used to enforce #[function_component] is because that I feel #[autoprops] #[styled_component] is a more natural way to use stylist with #[autoprops].
Subjecting users to use 3 attributes for a component definition and all of them required to be arranged in a specific order is simply not a good user experience.
I would like to reserve the name styled for a macro that can mimic styled-component(JavaScript library)-like styled usage. So I am not in favour of renaming styled_component_impl to styled.
However, I am fine with a different name for styled_component_impl if anyone is able to come up with a better name.
In addition, changing #[function_component] to #[component] is not a breaking change. #[function_component] will continue to work for the next Yew release. Making #[styled_component] to use #[component] internally is not a breaking change as well.
I am not a fan of the current autoprops syntax in general and is fine with stylist not making any accommodations to it if it simply works as-is.

Discussion is not required

Since you said this, I am going to make this as the final decision and will not discuss this any further.

and all of them required to be arranged in a specific order

Gotta point out, only the #[component] would need to be last

styled-component(JavaScript library)

I've only heard negative opinions on that JS library, meanwhile stylist is at least as good as tailwind, about which I heard only positive opinions and it is getting very popular

However, I am fine with a different name for styled_component_impl if anyone is able to come up with a better name.

I can only think of #[with_style] currently

In addition, changing #[function_component] to #[component] is not a breaking change. #[function_component] will continue to work for the next Yew release. Making #[styled_component] to use #[component] internally is not a breaking change as well.

Only if Yew officially has pub use component as function_component; in that PR. By it requiring changes I meant that if Yew will only rename and not keep old one, you will have a broken styled_component

Since you said this, I am going to make this as the final decision and will not discuss this any further.

Thats not what I meant, I meant that if discussion happens, it happens, if not, PRs would suffice, but OK lol
I will stand by my opinion, and keep using use stylist::yew::styled_component_impl as styled; (if I myself ever will need it, I personally only use use_style!).


Implementation of JER smearing with hybrid method

The JER smearing with the hybrid method is implemented, following the recommendations on the corresponding CMS Twiki. The method is a combination of a deterministic scaling method and a stochastic smearing.
The AK4 jets are matched to a gen-jet, if the requirements are met. The 4-momentum of matched jets is corrected by a factor dependent on the transverse momentum difference $p_T - p_{T,gen}$ and the data-to-simulation core resolution scale factor $s_{JER}$.
The 4-momentum of unmatched jets is instead corrected by a stochastic factor dependent on the scale factor $s_{JER}$ and the energy resolution $\sigma_{JER}$.
The energy resolution and scale factors are read from the JSON files recommended by the newest JSON-POG scheme.
In order to enforce reproducibility of the analysis, the random number generator is given a seed as input that is unique for each processed chunk. In this way, if the analysis is rerun with the same configuration and chunk size, the same stochastic smearing is applied and therefore the same results are reproduced. The per-chunk seed is also saved in the output file for bookkeeping.

Good for me, thanks!


Support for TLS 1.3

Does Gost support TLS 1.3?
There seems to be an implementation of the protocol here: https://github.com/bifurcation/mint

The bifurcation/mint is a standalone and very experimental library, and I think TLS 1.3 can be integrated with the crypto/tls seamlessly, so we can use it unconsciously.

https://github.com/cloudflare/tls-tris/
看看这个能不能用于支持 1.3 ？

这个库直接取代了标准库，可以直接用其提供的的方法重新编译即可，不用修改源码，但是它使用的是修改过的go编译器。

好吧，谢谢提醒，空了我用这个编译试试看。

#151


ClientModel: API Updates from architect feedback

Removes non-Core APIs not intended to be called by end-users from ClientRetryPolicy
Changes the name of PipelineMessage.MessageClassifier to RequestClassifier to enable better Azure.Core integration

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel


Spkl not including CanvasApp embedding changes while packing, unpacking CRM solution.

Spkl not including CanvasApp embedding changes while packing, unpacking CRM solution.
While troubleshooting I found that the solution packager works well if we unpack/pack directly using it. But Spkl is not giving proper instructions to solution packager which in turn is causing solution packager to ignore canvas app (power apps) form embedding changes. I have also attached the solution comparison which shows that spkl package is missing canvasapp folder and respective changes.

Hi,
This is likely due to the version of the solution packager that spkl is using. You should be able to update the nuget version of the Core Tools on the project that contains the spkl nuget package reference.

Thank you Scott. This helped :). I updated the core tools to <IP_ADDRESS> and now the packaging and unpacking from spkl shows canvas app control changes.


[arm-exporter] No data in Prometheus & Grafana

Describe the bug
Cannot get my nodes' metrics using arm-exporter.
Troubleshooting

Which kind of Kubernetes cluster are you using? Single node bare metal Kubernetes (v1.19-2) cluster on a RPi 4 8GB (not using any of k3s, minikube or microk8s).
Are all pods in "Running" state? Yes.
You cluster already works with other applications that have HTTP/HTTPS? Yes.
If you enabled persistence, do your cluster already provides persistent storage (PVs) to other applications? I didn't enable persistence. I use hostPath for the volumes.
Does it provides dynamic storage thru StorageClass? No.

Customizations

Did you customize vars.jsonnet? Put the contents below:

{
      name: 'armExporter',
      enabled: true,
      file: import 'modules/arm_exporter.jsonnet',
}

Did you change any other file? No.

What did you see when trying to access Grafana and Prometheus web GUI
No data in prometheus and Grafana.
Additional context
Logs extracted from arm-exporter container running in the pod:
time="2020-09-22T15:58:19Z" level=info msg="Starting rpi_exporter(version=, branch=, revision=)" source="rpi_exporter.go:82"
time="2020-09-22T15:58:19Z" level=info msg="Build context(go=go1.14.8, user=, date=)" source="rpi_exporter.go:83"
time="2020-09-22T15:58:19Z" level=info msg="Listening on<IP_ADDRESS>:9243" source="rpi_exporter.go:115"
time="2020-09-22T15:58:48Z" level=error msg="gpu collector failed after 0.018082s: exit status 255" source="collector.go:142"
time="2020-09-22T15:59:18Z" level=error msg="gpu collector failed after 0.002620s: exit status 255" source="collector.go:142"
time="2020-09-22T15:59:48Z" level=error msg="gpu collector failed after 0.002244s: exit status 255" source="collector.go:142"
time="2020-09-22T16:00:18Z" level=error msg="gpu collector failed after 0.001709s: exit status 255" source="collector.go:142"
time="2020-09-22T16:00:48Z" level=error msg="gpu collector failed after 0.003235s: exit status 255" source="collector.go:142"
time="2020-09-22T16:01:18Z" level=error msg="gpu collector failed after 0.001515s: exit status 255" source="collector.go:142"
time="2020-09-22T16:01:48Z" level=error msg="gpu collector failed after 0.002127s: exit status 255" source="collector.go:142"

In addition to the details already mentioned, when I connect to the containers inside the pod and try to run /opt/vc/bin/vcgencmd measure_tmp i get the following error:
/ # /opt/vc/bin/vcgencmd measure_temp
VCHI initialization failed

User details:
/ # whoami
root
/ # groups
root bin daemon sys adm disk wheel floppy dialout tape video

There were some discussions in the original code for the exporter. Check https://github.com/lukasmalkmus/rpi_exporter. Maybe some incompatibility with the Rpi4. I don't have one to test.

Just trying to help. I think it's not incompatibility with rpi4 as I been using it (4 rpis with 4gb each, k3s 18, Ubuntu 18 and 20)

Just to be sure @fonsecas72, the dashboard reports the temperature correctly?

Yup it seems

cat /sys/class/thermal/thermal_zone0/temp
55017

Thanks! @razerbann might be something block the access for Prometheus to collect the metrics in your PIs or something in it's Linux that does not generate the metrics, like missing Kernel modules.

/ # /opt/vc/bin/vcgencmd measure_temp
VCHI initialization failed

vgencmd needs access to /dev in the container.
This is forbidden by default. You will need to elevate the privileges the container is running with within your POD.

I have submitted a PR for it

Fixed by #97

I can confirm that the issue is no longer present.
Thank you for your help !


set invalid Listener.SupportedKinds to empty list

Fixes: https://github.com/envoyproxy/gateway/issues/4216
Relates to https://kubernetes.slack.com/archives/CR0H13KGA/p1727457195236889

apiVersion: v1
items:
- apiVersion: gateway.networking.k8s.io/v1
  kind: Gateway
  metadata:
    annotations:
      cert-manager.io/cluster-issuer: letsencrypt-production
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"gateway.networking.k8s.io/v1","kind":"Gateway","metadata":{"annotations":{"cert-manager.io/cluster-issuer":"letsencrypt-production"},"name":"https","namespace":"default"},"spec":{"gatewayClassName":"envoy-proxy","listeners":[{"allowedRoutes":{"namespaces":{"from":"All"}},"hostname":"grpc.example.com","name":"grpc.example.com","port":443,"protocol":"GRPC"}]}}
    creationTimestamp: "2024-09-27T18:39:12Z"
    generation: 1
    name: https
    namespace: default
    resourceVersion: "767"
    uid: 70692347-eab4-4051-bd72-5ec5c31d7093
  spec:
    gatewayClassName: envoy-proxy
    listeners:
    - allowedRoutes:
        namespaces:
          from: All
      hostname: grpc.example.com
      name: grpc.example.com
      port: 443
      protocol: GRPC
  status:
    conditions:
    - lastTransitionTime: "2024-09-27T18:39:13Z"
      message: The Gateway has been scheduled by Envoy Gateway
      observedGeneration: 1
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-09-27T18:39:13Z"
      message: No addresses have been assigned to the Gateway
      observedGeneration: 1
      reason: AddressNotAssigned
      status: "False"
      type: Programmed
    listeners:
    - attachedRoutes: 0
      conditions:
      - lastTransitionTime: "2024-09-27T18:39:13Z"
        message: Protocol GRPC is unsupported, must be HTTP, HTTPS, TCP or UDP.
        observedGeneration: 1
        reason: UnsupportedProtocol
        status: "False"
        type: Accepted
      - lastTransitionTime: "2024-09-27T18:39:13Z"
        message: Listener is invalid, see other Conditions for details.
        observedGeneration: 1
        reason: Invalid
        status: "False"
        type: Programmed
      - lastTransitionTime: "2024-09-27T18:39:13Z"
        message: Listener references have been resolved
        observedGeneration: 1
        reason: ResolvedRefs
        status: "True"
        type: ResolvedRefs
      name: grpc.example.com
      supportedKinds: []
kind: List
metadata:
  resourceVersion: ""

/retest


duplicated services  in combobox

reference #6429
skywalking version is  v8.4.0 for H2/MySQL/TiDB/InfluxDB/ElasticSearch 7
when use mysql as storage,the table store all services is table service_traffic and the id is primary key,so when a new service restart today,it insert a record and when it restart tomorrow it will not insert again,it's ok when when search service in the webUI.
but when use es as storage,it split tables by day,such as es_service_traffic-20210303,es_service_traffic-20210304 etc.
when a service restart today,it insert a record in es_service_traffic-20210304,and we restart tomorrow it will insert a record into es_service_traffic-20210305 again,but the http interface /graphql of queryServices collect all the services in the tables by day ,so the services in UI will be duplicated and cause the search problem in #6429
the database has the same data problem but the search is ok:
{
	"data": {
		"services": [{
			"key": "MTkyLjE2OC4xLjk4OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk5OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjgyOjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk5OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjgyOjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk5OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk4OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk5OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk5OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjk4OjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}, {
			"key": "MTkyLjE2OC4xLjgyOjMzMDY=.0",
			"label": "<IP_ADDRESS>:3306"
		}]
	}
}

We explain repeatedly at this, this is not exactly like you described. Please read old issues and the official demo is on es, no duplicated.

@whaon hello, have you solve the problem


attributes on external not preserved during formatting

echo 'external it : string => (unit => unit) => unit = "it" [@@bs.call "it"];' | refmt -parse re -print re -use-stdin true -is-interface-pp false

Output is simply:
external it : string => (unit => unit) => unit = "it";

Really important for bucklescript, since that's how it does the JS FFI.

What's the output here?

Thanks, updated.

Should be closed?

Just saw this. There's another case at #837. Closing this one! Thanks for the reminder.


Straight lines

Describe the problem
Straight lines in biome/region placements:

What Should Happen
Straight lines should not appear, and "proper" interpolation should happen
We can use the latest update with new noise styles & fracturing improvements to make this a reality.
What Biome
All regions have a chance to
Object Id
No response
Minecraft Version
1.17
Iris Version
1.5.10
Relevant log output. (IF APPLICABLE)
No response
Checklist

[X] I am using an unmodified version of the overworld. (If you modified the overworld and see an issue, contact support)
[X] I am using the latest version of the overworld OR I have made sure this issue was not already resolved on the latest version.
[X] I am using Spigot, Paper, Tuinity, or Purpur. (If you are not, and still think it is a valid issue, contact support)

The latest jar does not fix this?
he just added clover, Clover still runs into this issue. like until that artifact can be resolved there's no real point in trying for a workaround

It seems the lines are back in plains too

Fixed on latest dab


Create index.d.ts

A type definition file is needed for typescript. I am using fine uploader in the react project with typescript and unable to use it without type definition file.

In addition to being mostly empty, this type definition file seems to be incorrect, since FineUploaderTraditional is not the only possible value for uploader.
If someone wants to provide a proper and complete definition file, I'll consider packaging it with the npm release.


leaf

🍁

uwunerd

owo i can do that

that is, indeed, what this pr added
thanks for demonstrative imagery


fix #14 check DELETE /data/users

Fix #14  add check in DELETE /data/users

Hi @bglamadrid
Thanks for your feedback. Yup I've just updated it 😄


feat<login,register>: move encrypt login and register parameter logic to sdk

Codecov Report

Merging #137 (85336e8) into release-1.0.0 (b1361d6) will decrease coverage by 0.15%.
The diff coverage is 0.99%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1361d6...85336e8. Read the comment docs.


chore: temporarily fix pterm and lint

📑 Description
Closes https://github.com/goravel/goravel/issues/?

@coderabbitai summary

✅ Checks

[x] Added test cases for my code

Oh, sorry, just found that PR had been merged.

What's the difference between contains env.IsTesting() or not?

What's the difference between contains env.IsTesting() or not?

No different, If use IsTesting, the method will still broken in non-test usecase.


The doc can't be seen and I want to know how to config config.yaml

The following doc can't be seen:
https://github.com/coreos/clair/blob/master/docs/Run.md

Where did you find that URL? This is an old and outdated doc that was removed.
The example config.yml in the root of the project has documentation for all fields.


First pass at converting identifiers/words from en-au -> en-us

Hopefully this isn't controversial to the authors, but in my [obviously biased] experience, open source projects typically prefer to use American English for identifiers and documentation because this practice is standard in the software industry.
As trivial as it may sound at first, as this project grows and more and more people start collaborating (...hopefully), we probably don't want to have mixed dialects, which cause cause bugs or simply developer frustration in remembering the correct form.
This will likely become even more important as various public APIs comes to fruition.
If you disagree, I won't be offended, but I think this is a natural evolution. :smiley:
For your consideration:

:-1: . Americans have taken over enough projects, we should respect Seb's Australian heritage.

I'll submit to my American overlords :cry:

@antn I don't feel this is about respect. There's simply too many dialects and even languages in general for software to be written in. Accepting one is the only sane way to main a large project with a global collaboration...and for reasons out of my control, American English is currently the de facto standard.

It's okay @jayphelps, I was only joking :sweat_smile:.


Demonstrate use of Oracle database in a Senzing Stack

Location of Oracle client libraries:
https://www.oracle.com/database/technologies/instant-client/linux-x86-64-downloads.html


BTPSO do not reconcile CreateFailed serviceinstance

I applied the following two resources together and found that serviceinstance can not reach to ready status even the entitlement is ready for a long time. Seems BTPSO do not reconcile CreateFailed serviceinstance. I tried to restart BTPSO pod, which I thought is a trigger of reconcilation for all resources, but still do not work
（If create the service-manager-api-entitlement first, and then create smapi instance after the entitlement is ready, it can work.）
apiVersion: account.btp.orchestrate.cloud.sap/v1alpha1
kind: Entitlement
metadata:
  name: service-manager-api-entitlement
spec:
  forProvider:
    serviceName: service-manager-api
    servicePlanName: subaccount-developer
    enable: true
    subaccountRef:
      name: lindsay0
  providerConfigRef:
    name: btp-crossplane-account-hana-cloud-dev-cluster-config
---
apiVersion: kubernetes.crossplane.io/v1alpha1
kind: Object
metadata:
  name: smapi
spec:
  readiness:
    policy: SuccessfulCreate
  references:
  # Use dependsOn to declare dependency on other k8s resource for this object
  - dependsOn:
      apiVersion: account.btp.orchestrate.cloud.sap/v1alpha1
      kind: Entitlement
      name: service-manager-api-entitlement
  forProvider:
    manifest:
      apiVersion: services.cloud.sap.com/v1
      kind: ServiceInstance
      metadata:
        namespace: lindsay0
      spec:
        serviceOfferingName: service-manager-api
        servicePlanName: subaccount-developer
  providerConfigRef:
    name: kubernetes-provider

kubectl get entitlement
NAME                              READY   SYNCED   VALIDATION                EXTERNAL-NAME                     AGE
service-manager-api-entitlement   True    True     NoValidationIssuesFound   service-manager-api-entitlement   2m8s

kubectl get serviceinstances -A
NAMESPACE   NAME    OFFERING              PLAN                   SHARED   DATACENTER   STATUS         READY   AGE
lindsay0    smapi   service-manager-api   subaccount-developer                         CreateFailed   False   2m12s

kubectl describe serviceinstances smapi   -n lindsay0
...
      Status:
        Conditions:
          Last Transition Time:  2023-11-15T00:22:29Z
          Message:               ServiceInstance create failed: couldn't find the service offering 'service-manager-api' on dataCenter ''
          Observed Generation:   1
          Reason:                CreateFailed
          Status:                False
          Type:                  Succeeded
          Last Transition Time:  2023-11-15T00:22:29Z
          Message:
          Reason:                NotProvisioned
          Status:                False
          Type:                  Ready
          Last Transition Time:  2023-11-15T00:22:29Z
          Message:               ServiceInstance create failed: couldn't find the service offering 'service-manager-api' on dataCenter ''
          Observed Generation:   1
          Reason:                CreateFailed
          Status:                True
          Type:                  Failed
        Hashed Spec:             79c4edbf176eeb6e5b20f6986c5872f0
        Observed Generation:     1
        Ready:                   False
  Conditions:
    Last Transition Time:  2023-11-15T00:22:29Z
    Reason:                Available
    Status:                True
    Type:                  Ready
    Last Transition Time:  2023-11-15T00:22:29Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:
  Type    Reason                   Age   From                                     Message
  ----    ------                   ----  ----                                     -------
  Normal  CreatedExternalResource  81s   managed/object.kubernetes.crossplane.io  Successfully requested creation of external resource

There is already an open bug for this issue
Reconciliation doesn't continue when error appears #353

will be handled in the next takt


Generic Response mapping using Expr

Fixes #316

Flexible mapping representation using Expr
Although the mapping corresponding to a protocol is parsed during evaluation, a validation is done when we submit the API definition using open API spec as well.
There isn't a performance implication for trying to parse it during evaluation, because Expr is already parsed, and all that's done pattern matching on whether it is Expr::Record, and fetch the status, body and header out of it which is a constant big O.

Not waiting for the worker-executor tests, as the change don't impact this at all.


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Via enabling LTO in the Cargo.toml file we can deliver an LTO-optimized versions of the tool to users with cargo install. Using ThinLTO should also help to reduce the build-time overhead with LTO. E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 40) by adding lto = true to the Release profile. The binary size reduction is from 1.8 Mib to 1.5 Mib.
Thank you.

I agree, no harm in adding LTO for release builds. Appreciate the writing, you can create a PR and I'll merge

Just did it ;) https://github.com/sectordistrict/intentrace/pull/2


[ TEST ] Check minimal monitoring Logstash version

There is a difference in the input http_poller plugin.
Need to verify the minimal Logstash version, that should be installed for the Monitoring Logstash.

Minimal version for ssl_verification_mode in the http_poller plugin: 8.1.0
https://www.elastic.co/guide/en/logstash/current/logstash-8-1-0.html

README file updated


[Refactor][GCS FT] Use DeleteAllOf to delete cluster pods before cleaning up redis

Why are these changes needed?
This PR uses the DeleteAllOf helper to simplify the deletion of head pods and worker pods before Redis cleanup.
Note that we have to use two separate DeleteAllOf calls to delete heads and workers respectively to avoid accidentally deleting cleanup pods.
Also, there is no need to check the DeletionTimestamp of a resource before deleting it. Kubernetes will not change the resource if its DeletionTimestamp is set.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Would you mind adding tests for DeleteAllPods in raycluster_controller_fake_test.go? Thanks!

No problem. In addition to the Test_RedisCleanup which already covered most usages of DeleteAllPods, I have added a new TestDeleteAllPods to test it explicitly.


lancelot-Spark-Rom-pyro-deadaf5

Don't Rerun Builds

Don't Rerun Builds

Sir new build is added gapps kernel tweaks and sound fix

All i saw that is one build you did rerun and one you triggered with a new pr (which means you triggered 2 builds at a same time)

Reruning builds are not allowed
Pushing 2 builds simultaneously not allowed

If i ever again found you doing this will abort your builds and have to get you permanently blocked from @ROM-builders

All i saw that is one build you did rerun and one you triggered with a new pr (which means you triggered 2 builds at a same time)

Reruning builds are not allowed
Pushing 2 builds simultaneously not allowed

If i ever again found you doing this will abort your builds and have to get you permanently blocked from @ROM-builders

Sorry sir I will keep in mind


Refactor UInt{8,16,64,128} into one struct UInt

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Unfortunately I think there's a special impl of ToConstraintField for [u8]s that's used in the new_input_vec impl. Generalizing it to support larger sizes shouldn't be difficult, but would require moving away from calling ToConstraintField. Maybe that's fine though.

Rather than generalizing we could just implement ToConstraintField for &[u16] etc no?

@Pratyush After moving ToBytesGadget to convert, it is no longer part of prelude. Is it intended?
I'm fixing crypto-primitive for this change. For example, in:
https://github.com/arkworks-rs/crypto-primitives/blob/8bbb4824ede5f2cf115f1a37e08410b57944a4f6/src/signature/constraints.rs#L10
It was previously enough to use ark-r1cs-std::prelude::* but now I need either use it explicitly or update the prelude.


Project is live?

Description
Add a detailed description of your issue.
Repro Steps
Layout the steps to reproduce your issue.
Screenshots / Codepen
Add supplemental screenshots or code examples. Look for a codepen template in our Contributing Guidelines.

Yes it is always live


Armada Server integration test fixes

Codecov Report
Base: 70.22% // Head: 75.84% // Increases project coverage by +5.62% :tada:

Coverage data is based on head (1d62b58) compared to base (63ced7d).
Patch coverage: 79.87% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   70.22%   75.84%   +5.62%
==========================================
  Files          11       12       +1
  Lines        1518     1747     +229
==========================================
+ Hits         1066     1325     +259
+ Misses        354      323      -31
- Partials       98       99       +1

Impacted Files
Coverage Δ

controllers/install/eventingester_controller.go
78.66% <40.00%> (-0.11%)
:arrow_down:

controllers/install/binoculars_controller.go
80.27% <70.00%> (+18.83%)
:arrow_up:

controllers/install/lookout_controller.go
75.14% <71.25%> (-3.96%)
:arrow_down:

controllers/install/armadaserver_controller.go
63.82% <92.50%> (+9.70%)
:arrow_up:

controllers/builders/service_account.go
100.00% <100.00%> (ø)

controllers/install/executor_controller.go
74.71% <100.00%> (+0.69%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


pylint/flake8 cleanup for R3

Been awhile since we've burned down the pylint/flake8 for the current R3 repo, so this sprint would be a good opportunity to resolve or suppress as many findings as feasible.
Recent findings for each PGE container build can be found in the Jenkins build/test pipeline for 315_isoMetaData.
Of particular note are the findings for metadata_util.py for both flake8 and pylint. Since we have a lot of test code to create dummy metadata products, we need to add the appropriate statments or pragmas to disable static analysis on the various create_test_<pge>_metadata_product. This will go a long way in trimming the list of findings, so only the legitimate ones should remain.

Closed by #373


Disable SyncDAO tests and document criteria for re-enabling

@adamvy FYI

@m-cheung FYI: disables the tests. Hey, I fixed the tests!

Thanks! I am incorporating your changes now and I believe all the tests should pass now.


Rename property 'text' into 'message'.

@grozdanov In UiDialog.h there is an argument called message (not text) in Create functions.
Based on UiDialog.h we also defined the property message in iOS and Android code.
Shall we change your code so this it is consistent across all platforms?
FYI Native iOS alert also defines title and message fields so I would opt for the 'message' prop. What do you think?

Can we use both text and message properties for the same goal? So all 3 cases will do the same:
<dialog title={'Title'} message={'Some description'} />

<dialog title={'Title'} text={'Some description'} />

<dialog title={'Title'}>Some description</dialog>


I'm seeing cannot use templ.NopComponent error

I am using latest version of templ.
Describe the bug
I'm seeing this everywhere, in both Neovim and VSCode. It wasn't there before, I guess I messed up some config on my system.

To Reproduce
I don't know. Earlier it used to work. But somehow I am seeing the errors in all templ files.
Expected behavior
No errors.

I didn’t do “go mod download”!
Because I had a vendor folder and thought it would work.
So I closed the issue.


fix(KFLUXBUGS-1202): use proper project id when talking with GL project

Bug: When a MR is created from the foked repo, we still try to get/create MR note from
source target project incorrectly

The fix will:
* Get source project ID from PAC annotation
  pac.test.appstudio.openshift.io/source-project-id and create/get
  commitStatus from it
* Get target project id from PAC annotation
  pac.test.appstudio.openshift.io/target-project-id and create/update
  MR note from this project

Signed-off-by: Hongwei Liu<EMAIL_ADDRESS>
Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[x] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[x] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Please update commit message to be more descriptive:

why this path is needed, what is broken
how fix address the issue

Checking PAC codebase, we may need both source and target ID
source will be used for commit status, target for comments :|
https://github.com/openshift-pipelines/pipelines-as-code/blob/1fe9f45d7d35eea6915471450fd6e2dd145f583a/pkg/provider/gitlab/gitlab.go#L213

Good catch!

The code looks good to me, only the gitLint check is failing:
B1 Line exceeds max length (86>72): "Bug: When a MR is created from the foked repo, we still try to get/create MR note from"

Looks good, will add +1 after checks pass.

/test integration-service-e2e

/test integration-service-e2e

/retest

/retest

unfortunately, we still having the openshift CI outage so this will stay blocked till it's fixed

needs rebase to pass EC test

/test integration-service-e2e


Add a progress bar for data ingestion

This PR adds a progress bar for data ingestion.
After executing poetry run python -m explorer.api.ingest [file], the output will be a progress bar
  [####################################]  [number of derivations ingested/number of derivations]  percentage

instead of
INFO:__main__:/nix/store/.....

Both the logging (which I'll turn into structured logging at some point) and the progress bar have their own merits:

the logging will help monitoring ingestions (mainly failures and performances)
the progress bar is helpful for running locally when there is no monitoring to be done

Please make it so we can do both using CLI option flags.


Add support for controlled paging via Gax.

Fixes failures on master following Friday's release of gax-google-pubsub-v1 0.7.6.
@daspecster PTAL.

@daspecster  I don't understand the system-tests failure, but I can reproduce it on my local box:  the gcloud installation is getting hosed:
$ find .tox/system-tests/lib/python2.7/site-packages/gcloud/
.tox/system-tests/lib/python2.7/site-packages/gcloud/
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/subscriber_client_config.json
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/subscriber_api.pyc
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/publisher_api.pyc
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/publisher_api.py
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/subscriber_api.py
.tox/system-tests/lib/python2.7/site-packages/gcloud/pubsub/publisher_client_config.json

Those files should be installed as part of gax-google-pubsub-v1.

Well that's strange. I'll wipe the Travis cache for this PR and I'll try and run the system tests locally.

Locally, if I pip install gcloud==0.15.0 it gets picked up and installs. @tseaver, could this be a tox problem somehow?

It is a problem with gax-google-pubsub-v1 0.7.6.  I've asked @bjwatson to fix it.

Ok great!

0.7.7 has been published to https://pypi.python.org/pypi/gax-google-pubsub-v1

@tseaver LGTM!

Thanks at @bjwatson!

No problem. :)


change the README to use the correct scripts

The start script is node server.js. So the README was basically saying enter node server.js twice.
I also changed the commands to yarn since this project has a yarn.lock file.

Have rewritten the README in PR 33


Prototype using QUIC instead of tcp and proprietary handshakes

While not technically purpose built for p2p applications, QUIC streams could replace our existing mechanisms for multiplexing messages and offer significant benefits. Besides removing multiple round trips per the handshake, QUIC also offers the ability to avoid HOL and to make use of more widely used (potentially more battle tested and debugged) software.
AC
Create a prototype that uses QUIC instead of tcp and secret conn. Compare its high level performance (consensus throughput and peer drops) using our network tests and report them here.

The only reason why we would want to prototype without using libp2p is to help debug the current issues in comet where we are unable to utilize all of the bandwidth with multiple nodes and latency.
tbc, the goal of this issue is not to write a proprietary p2p stack based on QUIC

Investigation setup
We added support for QUIC streams in tendermint here https://github.com/celestiaorg/celestia-core/pull/1466, using go-quic library.
Then, to benchmark the performance, we implemented a mock reactor that floods the network with raw data and traces the data sent/received. This reactor was enabled both for the QUIC refactor: https://github.com/celestiaorg/celestia-core/tree/quic-bench-reactor and also the native tm stack: https://github.com/celestiaorg/celestia-core/tree/updating-the-mock-reactor-updated.
Then, for better results, we disabled all the reactors except PEX so that the only data sent across the network is the mock reactor data.
After running the experiments, we noticed that the quic connections in the QUIC refactor hang after a while. So, to have more accurate results, we implemented a simple project https://github.com/rach-id/quic-bench that uses go-quic to create a QUIC network where each peer floods its peers with random data. This allowed benchmarking the QUIC performance without even the overhead added by tendermint, protobuf encoding/decoding, peers handling, etc.
To run the benchmarks, we used this branch of congest https://github.com/celestiaorg/congest/tree/tm-quic-benchmarks which creates a network of servers, provisions them, runs the network, then collects the logs.
The plots below were generated using the traces collected from the network using congest and processed using https://github.com/celestiaorg/traces_analysis.
The servers' setup:

52 validators distributed across the world. the plots below show the regions.
For the QUIC benchmarks, we increased the udp buffers in all the servers:

sudo sysctl -w net.core.rmem_max=16777216
sudo sysctl -w net.core.wmem_max=16777216
sudo sysctl -w net.core.rmem_default=8388608
sudo sysctl -w net.core.wmem_default=8388608
sudo sysctl -w net.ipv4.udp_mem="8388608 8388608 16777216"
sudo sysctl -w net.ipv4.udp_rmem_min=1638400
sudo sysctl -w net.ipv4.udp_wmem_min=1638400

For the tendermint native stack benchmarks, we used BBR + mptcp in all the servers:

# Load the BBR module
echo "Loading BBR module..."
modprobe tcp_bbr
# Verify if the BBR module is loaded
if lsmod | grep -q "tcp_bbr"; then
  echo "BBR module loaded successfully."
else
  echo "Failed to load BBR module."
  exit 1
fi
# Add BBR to the list of available congestion control algorithms
echo "Updating sysctl settings..."
sysctl -w net.core.default_qdisc=fq
sysctl -w net.ipv4.tcp_congestion_control=bbr

# Enable MPTCP
sysctl -w net.mptcp.enabled=1

# Set the path manager to ndiffports
sysctl -w net.mptcp.mptcp_path_manager=ndiffports

# Specify the number of subflows
SUBFLOWS=16
sysctl -w net.mptcp.mptcp_ndiffports=$SUBFLOWS
# Make the changes persistent across reboots
echo "Making changes persistent..."
echo "net.core.default_qdisc=fq" >> /etc/sysctl.conf
echo "net.ipv4.tcp_congestion_control=bbr" >> /etc/sysctl.conf

Also, we increase the send/receive rate to 100Gbps.
Findings
After running the different networks for a few minutes, we collected the logs and generated the following plots.
Native tendermint stack + BBR + mptcp
Peer upload vs download average speed:

Peer upload vs download progression:

Region upload vs download average speed:

Tendermint stack QUIC refactor + large UDP buffers
Peer upload vs download average speed:

Peer upload vs download progression:

Region upload vs download average speed:

QUIC benchmark tool + large UDP buffers
Peer upload vs download average speed:

Peer upload vs download progression:

Region upload vs download average speed:

Insights
We can see in the plots that the QUIC benchmark tool yields better results than the Tendermint QUIC refactor. So we will use it as a reference for the QUIC performance instead of the QUIC refactor. The reason being is the QUIC refactor was still a WIP and thus the performance can still be improved. However, the QUIC benchmarking tool uses out of the box go-quic without any changes. This makes it a good reference for performance, as that's the best we can.
So, if we compare the QUIC benchmarking tool performance with the native tendermint stack + BBR, we see that in both the worst cases, where we have servers in far places in the world, sometimes in a different continent, and the best cases, where the servers are in the same site, the performance of the native tendermint stack + BBR is better, the bandwidth is better utilized.
Conclusions
Given the above numbers, it seems more reasonable to keep the existing tendermint stack and pair it with BBR to have the best possible performance. Then, we will need to focus on improving the message passing mechanisms to be able to fully utilise the bandwidth. This will be tracked in this issue https://github.com/celestiaorg/celestia-core/issues/1531.

More insights: comparing different data sizes and streams in QUIC vs TCP + BBR +mptcp
The setups are the same as above.
QUIC
500 bytes data in 4 streams

5mb data in 4 streams

Note: when running the experiment, the CPU usage increases with the number of streams we're opening.

1 stream resources usage
![image](https://github.com/user-attachments/assets/9f071595-9a69-4a5e-920c-b2408488f23c)

256 stream resources usage
![image](https://github.com/user-attachments/assets/57abe877-6a28-4d60-b247-edac58f1f171)

opening a new stream every minute
![image](https://github.com/user-attachments/assets/6b2a1327-dc97-4c59-80d0-40359279db2f)
We see that after opening ~20-40 stream, QUIC keeps performing the same way. if we open <20 streams, the performance is best. This could also be due to the data being sent is increased with every stream.

TCP + BBR + mptcp
500 bytes

Apparently, the smaller the data being sent, the more performance we get from the comet's p2p stack.
5mb bytes
There is a memory leak apparently somewhere that makes the nodes OOM after a short while.
We will try to fix it in this issue


Creating directories error: Please import Comet before importing any keras modules

It seems like current code have little bug on comet import
according to the report, we have to import comet before keras modules
Create the trainer
importing trainers.CifarTrainer
getattr CifarTrainer
<class 'trainers.CifarTrainer.CifarTrainer'>
Please import Comet before importing any keras modules

Yeah I ended up resolving it by importing comet in main (hacky fix but not terribly bad)

Yeah I ended up resolving it by importing comet in main (hacky fix but not terribly bad)

Can you please elaborate how did you do it. Importing comet in main will throw the error: "name 'Experiment' is not defined". Thr simple_mnist_trainer.py is not imported with Comet sadly.

Yeah nvm.
Gotta import Comet twice, once in main and once in trainer. Wonder why this error is still not fixed.

Yes, it seems that the module "comet_ml" should be imported at the beginning.