[BUG] delta_login_review method outdated

This occurs when an unknown device logs into your account. From there, you are prompted with a challenge screen to either accept the login or not. The method currently included in the challenge class is outdated and produces this traceback:
from instagrapi import Client
c = Client()
c.login_by_sessionid("susblockedsession")
c.get_timeline_feed()

 File "C:\Users\viral\AppData\Local\Programs\Python\Python39\lib\site-packages\instagrapi\mixins\auth.py", line 215, in get_timeline_feed
    return self.private_request(
  File "C:\Users\viral\AppData\Local\Programs\Python\Python39\lib\site-packages\instagrapi\mixins\private.py", line 443, in private_request
    self.challenge_resolve(self.last_json)
  File "C:\Users\viral\AppData\Local\Programs\Python\Python39\lib\site-packages\instagrapi\mixins\challenge.py", line 78, in challenge_resolve
    return self.challenge_resolve_simple(challenge_url)
  File "C:\Users\viral\AppData\Local\Programs\Python\Python39\lib\site-packages\instagrapi\mixins\challenge.py", line 365, in challenge_resolve_simple
   self._send_private_request(challenge_url, data={"choice":"0"})
  File "C:\Users\viral\AppData\Local\Programs\Python\Python39\lib\site-packages\instagrapi\mixins\private.py", line 310, in _send_private_request
    raise ClientJSONDecodeError(
instagrapi.exceptions.ClientJSONDecodeError: JSONDecodeError Expecting value: line 1 column 1 (char 0) while opening https://i.instagram.com/challenge/?next=/api/challenge/

I have a few accounts that have a suspicious login challenge screen. I do not have the emails or numbers attached to them, however I do have the session IDs in which I used this simple fix to accept the login challenge.
Using burpsuite, I re-simulated the suspicious login process on one of my accounts and found a different endpoint to use as an alternative. I ended up changing a few lines of the challenge_resolve_simple method in challenge.py:
def challenge_resolve_simple(self, challenge_url: str) -> bool:
        """
        Old type (through private api) challenge resolver
        Помогите нам удостовериться, что вы владеете этим аккаунтом

        Parameters
        ----------
        challenge_url : str
            Challenge URL

        Returns
        -------
        bool
            A boolean value
        """
        step_name = self.last_json.get("step_name", "")
        if step_name == "delta_login_review":

            # New endpoint
            endpoint = "bloks/apps/com.instagram.challenge.navigation.take_challenge/"

            # New encoded data
            data = f"should_promote_account_status=0&choice=0&_uuid={self.uuid}&bk_client_context=%7B%22bloks_version%22%3A%2254a609be99b71e070ffecba098354aa8615da5ac4ebc1e44bb7be28e5b244972%22%2C%22styles_id%22%3A%22instagram%22%7D&bloks_versioning_id=54a609be99b71e070ffecba098354aa8615da5ac4ebc1e44bb7be28e5b244972"

            accepted =self._send_private_request(endpoint, data=data,with_signature=False)

            # ==> Json Response/ Test if it was successful
            if accepted.get("status")=="ok":
                print("Accepted delta_login challenge")
                return True
            else:
                print("Failed to accept delta_login challenge")
                return False

Hi, I had the same problem and this solution works for me.
thank you.


Add Presence System

This allows the bot to show their presence to the discord guild as "WATCHING irc://server/+port
This only runs when the .alterPresence option in the config is truthy

https://github.com/reactiflux/discord-irc/pull/423#issuecomment-519559618
Any idea of a consensus between this, #423 and #359?


pythonPackages.setuptoolsTrial: make twisted overridable

This allows matrix-synapse and tahoelafs to share this package, despite relying on incompatible Twisted versions.

Also, this isn't purely an enhancement — tahoelafs has been broken since 2ba13aa534699f519edc1b61c56d451db5ecd24c.


ADD GET /secrets/:id with internal corresponding endpoint

Links

[x] https://github.com/RedHatInsights/sources-api-go/pull/551
https://github.com/RedHatInsights/sources-api-go/issues/549

I added your suggestion, thanks!


Enable elasticsearch 1.7 on production

See https://trello.com/c/EYXNHkyr/524-upgrade-elasticsearch-to-1-7-5-m
Puppet has been temporarily disabled on api-elasticsearch hosts as we need to do a rolling deploy.

:+1:
Merge when green and you are ready.


Azure Monitor Exporter - Adopt allocation less ForEach from OpenTelemetry

Addressing https://github.com/Azure/azure-sdk-for-net/pull/15533#discussion_r498453868
Adopting https://github.com/open-telemetry/opentelemetry-dotnet/pull/1236
PooledList.cs and EnumerationHelper.cs are from Otel repo. This is marked as internal in Otel hence could not take direct reference.

What's the perf gain? It would be helpful to see the benchmark diff.

@reyang
Usage of `PooledList' reduces the data allocation completely with better execution time.
Still PooledList.cs is an implementation from OpenTelemetry repo. Need your guidance to check if we could take copy of this file in our exporter.

Adopting open-telemetry/opentelemetry-dotnet#1236
PooledList.cs and EnumerationHelper.cs are from Otel repo. This is marked as internal in Otel hence could not take direct reference.

@cijothomas @rajkumar-rangaraj would it be possible to access these via reflection + cache, instead of copying the file over? I'm a bit concerned about the license issue.

Removed all source from OpenTelemetry repo. Taken guidance from Minimize large object allocations, learning from PooledList.cs and introduced a new non-generic struct named AzMonList. We could achieve a similar functionality as above with new implementation. Below is the benchmark on new code.


React to changes in DbContext discovery in EntityFrameworkCore

Scaffolding should add a <DbContextClassName>Factory.cs  to the project while creating a new DbContext.

See: dotnet/templating#695 & dotnet/templating#705 for content of the class.

Related:

aspnet/EntityFramework#8314
aspnet/EntityFramework#8326
#466

cc @mlorbetske, @Eilon

@prafullbhosale - is this issue done?

Yes, https://github.com/aspnet/Scaffolding/commit/a6414d24afba24309c099105bd35b3dca4a4f415.
I thought this would have been auto closed when changes got merged to dev, but I guess not.


Re-enable keyboard caret, move test scene

Overview
This change re-enables the caret in the MRTK keyboard. This MAY result in both the MRTK and System keyboards being displayed at the same time (#1940) -- we will continue to investigate this issue separately. Submitting this as not having a caret is a significant usability issue.
The keyboard test scene has been moved from Examples\Input to Examples\UX to avoid confusion, as that is where the scripts reside.
Fixes: #1978

possibly, but not 100% from what I have investigated


ImmutableMap becomes a LinkedHashMap after passing through a process

=> Is probably a nextflow issue, but I need to investigate this further

Something seems wrong with the nf-core modules on normal runs. When running pipelines in stub mode, the meta returns as ImmutableMap

Nvm, I was running the code with -resume after migrating, causing the pipeline to use the old LinkedHashMaps


ClassNotFoundException MutableLongList

Followed the guide but got:
 java.lang.ClassNotFoundException: kotlin.jvm.internal.Intrinsics

More about this error here:
http://stackoverflow.com/questions/43425367/mapdb-classnotfoundexception-kotlin-jvm-internal-intrinsics
It quite urgent, if someone could help/guide me here.

08392254264900.txt
Anvisningar för praktikrapporten.pdf

You need to have all jar files in classpath.


Idea: Alias feature

Here is my rough idea.
New feature called alias feature.
Any feedbacks is welcome.
For now, xpanes has following problems.

Users cannot set pane's title provided by -t individualy.
Re-define xpanes with built-in alias is lazy.

Many escaping
i.e: alias prod-servers="xpanes -c 'ssh {}' \"-i key1 user1@server1\" \"-i key2 user2@server2\" "

Alias feature would solve above problems.
Creating file. It would be TSV, YAML or JSON.
${HOME}/.config/tmux-xpanes/aliases/prod-servers.yaml
- cmd: ssh server1
  title: server1
- cmd: ssh server2
  title: server2
- cmd: ssh server3
  title: server3
- cmd: ssh server4
  title: server4

Execute with --alias, -A + Alias name
xpanes -A prod-servers

Result
    +-------------------------------+------------------------------+
    │$ ssh server1                  │$ ssh server2                 │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    +-[server1]---------------------+-[server2]--------------------+
    │$ ssh server3                  │$ ssh server4                 │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    │                               │                              │
    +-[server3]---------------------+-[server4]--------------------+

did this ever get pushed out? it would totally solve my escape nightmare of aliases right now lol


feat(configurable-logger): logging support in the core library

What
This PR introduces the configurable logger feature. With this enhancement, the core library now boasts a flexible logging system tailored specifically for logging HTTP request and response information. By addressing the lack of a standardized logging mechanism, developers can now effectively debug and monitor network interactions with ease. The implementation includes a modular logging framework supporting customizable logging formats, default logger, and verbosity levels, empowering users to tailor logging behavior to their specific requirements. Additionally, seamless integration with existing logging libraries. This enhancement marks a significant step towards improving the usability and reliability of the core library, enhancing the development experience for our community.
Why

To add configurable logging support

Closes #57
Type of change
Select multiple if applicable.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause a breaking change)
[ ] Tests (adds or updates tests)
[ ] Documentation (adds or updates documentation)
[ ] Refactor (style improvements, performance improvements, code refactoring)
[ ] Revert (reverts a commit)
[ ] CI/Build (adds or updates a script, change in external dependencies)

Dependency Change
If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries
Breaking change
If the PR is introducing a breaking change, please ensure that it adheres to the following guidelines https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries
Testing
List the steps that were taken to test the changes
Checklist

[x] My code follows the coding conventions
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added new unit tests

Please fix the code climate issues here


Using 'let' with rspec resulting in 'NoMethodError'

Hi *,
today, we have updated rspec-core from 3.0.3 to 3.3.2 version in our project and got problems during spec runs:
 Failure/Error: Unable to find matching line from backtrace
     NoMethodError:
       undefined method `fetch_or_store' for nil:NilClass

As far i see, issue was already reported here (https://github.com/rspec/rspec-core/issues/1921), but looks like it was not fixed.
Thanks

As discussed in #1921 this is caused when using something that extends RSpec but uses a private part of our api, in the case of #1921 it was rspec-retry

#1921 was fixed via #1950 before 3.3 was released. In fact, no versions of RSpec have been released with that specific bug (although it appears you have hit a similar bug).
Can you put yogether a code example that demonstrates the issue? Without that there's no way for us to guess what causes this error for you but no one else.


etcdserver: save state before save snapshot

Fix #5664.
The root cause is that etcd save snapshot before save its state. When it recovers, it complaints the snapshot in newer than the state. This patch fixes the problem. The ordering in our raft doc is correct.

@siddontang So it is not a raft bug, but a bug in etcd side.

@LK4D4 Not sure if this also applies to swarmkit (it uses some of the etcd code to drive raft library?). cc'd for safety.

/cc @heyitsanthony PTAL

lgtm


Cambium api additions

Merged develop and test script ran clean.  Let me know if there's any issues!

This looks mostly good to me.
I'm not sure why the Travis CI test failed with:
[ RUN      ] PVSmoothing_lib_battery_dispatch.Generic_w_PV_input_all_on
/home/travis/.travis/functions: line 109:  9180 Killed                  test/Test
The command "if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then test/Test; fi" exited with 137.

I restarted the test and so let's see if it persists.

That failing test was fixed in develop on 7/30/2021.


Revert back to UIViewRepresentable

Hi @gaetanzanella
Unfortunately the solution using UiViewControllerRepresentable does not play nice with NavigationView, for some reason (I was not able to figure out why). When using UIViewRepresentable it works correctly. I have improved the previous solution a little by still using the accessiblityIdentifier.
The problem with NavigationView is that if the content overlay changes such that a .drivingScrollView modified view is added, the title of the NavigationView appears even if somewhere it is set to not do that by .navigationBarHidden(true). If you would like to test that and maybe create a solution of your own based on UiViewControllerRepresentable I have an example here: https://github.com/Lumentus/DynamicOverlay/blob/e3a09e38c4570d5a5ca4b1d9fb7e971f4719ed4d/DynamicOverlay_Example/DynamicOverlay_Example/View/MultipleDrivingScrollViewsView.swift
Just press the "Content swap" button and with the old solution the navigation bar will reappear (at least on iPhone 12 Simulator).
Greetings
Lumentus

Hi @Lumentus it will take a look. I pushed some updates this morning. Can you give your opinion on that?

I will tomorrow.


dashboard-api-python issue

Hi
I am try copy your code to run , I copied and pasted to Pycharm , when I run it , I have get my organization code and get error message as below:
Analyzing organization other license.com:

iterating through 1 networks in organization 66934XXXXXXXXXXXXXX
Finding clients in network API-Lab (1 of 1)
Traceback (most recent call last):
File "/Users/kitoorunoboru/PycharmProjects/dashboard-api-python-master/test.py", line 96, in
main()
File "/Users/kitoorunoboru/PycharmProjects/dashboard-api-python-master/test.py", line 77, in main
field_names = list(field_names)
UnboundLocalError: local variable 'field_names' referenced before assignment

can you help me ? thanks !

Can you add a "print(clients)" line underneath the "if clients:" block, and re-run please? Curious why clients are returned but they do not have keys.

I have add command and rerun , error message is same as before , I have take screen shot as this link https://www.dropbox.com/s/u45hjfr08k1bacn/%E6%88%AA%E5%9C%96%202020-03-05%20%E4%B8%8A%E5%8D%888.59.18.png?dl=0 , thank you !

It seems like you only have one network in this org but there are no clients at all in that single network. Is that correct? Which is why the shortcut here to use CSV field names from the dict/object's keys doesn't work since no clients are returned at all.

thank you ! is my org issue , I'll use another org test .


cmake : add main to cmake

as mentioned in #67 this pr adds the main "example" to cmake

... if you want to merge, its your repo, no one else can :smile:

Nice.


docs(website): migrate main concepts away from first-person

In line with #687, I have begun work towards the migration of the documentation from first-person to a more neutral tone. I was personally amused by the personality at first, but as suggested by many others, it did get old pretty quick.
This PR only adjusts the text for the Main Concepts section of the Guides page. There is a lot more work to do, but I'd like to keep this PR well-scoped in the meantime. Let me know if you have any concerns regarding the updated version of the text.

[!NOTE]
As an aside, I'd like to invite you in accepting this PR as a valid submission for this year's Hacktoberfest. There are two ways to do this: (1) add the hacktoberfest topic to the repository or (2) add the hacktoberfest-accepted label only to this PR if the previous option is not preferable. Thanks! 🚀

Thank you! Please keep to first-person style in the introduction guide. I will have another look at this PR tomorrow.

Please keep to first-person style in the introduction guide.

Yes, the entire Get Started section (which contains the Introduction guide) is untouched. This PR only edits the Main Concepts section: mental model, schemas, pipelines, parse data, infer types, methods, and issues.

I have added the label and topic for Hacktoberfest 🚀

Thanks! Looking forward to seeing this merged. 🙇


How to remove all items from localstorage

I need to empty the localstorage.
Is there a way to remove all the items at once?
Didn't find it in the documentation
Thanks

Hello. You can simply use localStorage API.
localStorage.clear()

Mmh it doesn't seems to work.
I have tried:
this.$localStorage.clear()
And it gives the following error:
this.$localStorage.clear is not a function

Everything else works fine:
this.$localStorage.get
this.$localStorage.set
this.$localStorage.remove

No, you should use global localStorage.
window.localStorage.clear()

Okay thanks in this way it works.
But why I have to use the global localStorage for the clear method?
Would it be possible to include this method and use it as this.$localStorage.clear() ?

Well I think it could probably be more easy to use (and to find in the documentation), but no problem.
Thanks for the help!


[otbn,util] Add clobbered-register print mode for analyzer.

Convenience mode that prints the "clobbered register:" and "clobbered flag groups:" lines as they should appear in the docstring for OTBN functions.
Usage looks like:
 $ hw/ip/otbn/util/analyze_information_flow.py p256_ecdsa.elf --subroutine p256_sign --clobbered
* clobbered registers: x2 to x3, x10, x16, x18 to x22, w0 to w31, acc, mod
* clobbered flag groups: FG0

I've been meaning to do this for a long while, since it's a straightforward extension of the information-flow analyzer we already have and is helpful for writing and checking OTBN docstrings :slightly_smiling_face:

CI failure is pretty clearly not related.


RISCOF redefine of TEST_CASE_1

https://github.com/riscv/riscv-compliance/blob/65cd9556846c60608c06e9db22ab573c1e86fe6b/riscv-test-suite/env/arch_test.h#L14
If I use the test suite with RISCOF TEST_CASE_1 will be defined twice, once from arch_test.h and again with the compiler invocation (test file: RVTEST_CASE, database.yaml, plugin (testentry['macros'])).
When I create a test suite with riscv_ctg, arch_test.h does not contain this definition. But I am not sure if this is needed for the current checks in riscv-compliance. Maybe @neelgala or @pawks can help to clarify this?
The file also differs slightly in two other places (adj_mtval, sv_mtval).
Thanks

The macro TEST_CASE_1 is defined in riscof as a part of command line arguments to enable partial test selections in scenarios where its necessary. This contributes to the dynamic test and test case selection based on the configuration of the DUT. The current framework over here doesn't have the capabilities to handle dynamic test case handling, which is why the TEST_CASE_1 macro is defined by default in the header file.

The macro TEST_CASE_1 is defined in riscof as a part of command line arguments to enable partial test selections in scenarios where its necessary. This contributes to the dynamic test and test case selection based on the configuration of the DUT. The current framework over here doesn't have the capabilities to handle dynamic test case handling, which is why the TEST_CASE_1 macro is defined by default in the header file.

Thanks for the clarification @pawks.
So I guess this will not change until v3 is ready and just be how it is? (Just to make sure)

Thanks for the clarification @pawks.
So I guess this will not change until v3 is ready and just be how it is? (Just to make sure)

Yes, its there so when v3 is deployed, no changes to tests will be necessary.
I believe this is now answered (very belatedly), so I'm c;osing this.


Keep track of the character to glyph mapping in font_renderer.js, to prevent errors when different characters point to the same glyph (issue 7101)

I've not yet had time to create a reduced test-case, and I'm not sure if we'll be able to test this using only an appropriate text rendering mode (i.e. 4 - 7), or if disableFontFace = true is actually necessary.
Fixes #7101.

/botio-windows preview

/botio test

/botio-windows preview

/botio test

Updated to fix a merge conflict in test/pdfs/.gitignore.

Looks good. Thank you for the patch.
/botio makeref


Add Functionality to Better Manage Locked stCELO during CGP Voting

Current Behavior
When a user votes on a governance proposal, their stCELO balance gets locked by the manager contract. This locked stCELO is not automatically unlocked after a proposal voting period has elapsed, and requires the user to manually unlock them.
While their stCELO balance is locked, a user cannot see that balance stCELO.balanceOf(address), or transfer it.
This behavior causes some user to think that their funds are missing.
Expected Behavior
Show the currently voting(locked) stCELO balance to the users.

Add a UI component that shows the current locked balance of a user by calling the view function stCELO.lockedVoteBalanceOf(address)

Add a UI component that shows the locked stCELO currently being used to vote on a proposal. vote.getLockedStCeloInVoting(address)

Add a UI component that allows the user to unlock their balance submitting stCELO.unlockVoteBalance(address) transaction.

This was merged as part of #164 #161

@product-matt can you confirm you're happy with the results ?


Implement chart with temperature and rainfall information

This for reports of OFT. To show the climate indices available on climatrends from planting data to the end of the trial.

Solved here https://github.com/AgrDataSci/ClimMob-analysis/commit/df4de1e6c8d78a6a2ee7f323b27a6f9faf037cb8


Research about UI aspects for the game

The theme and visualization

@vkanduku1995 Could you share what you've discovered on this thread?

https://docs.google.com/document/d/1q_HC6ZjG-svCcsbpovYMg1Od-wl5V0bJ3FuhA4zxA6I/edit


PR: Restore widget shortcuts to Preferences and allow to change them on the fly (Shortcuts)

Description of Changes

Those shortcuts were not shown in Spyder 6, as reported by several users.
That was a regression introduced by #22230, which unfortunately we overlooked.
This also fixes an important usability issue: changing those shortcuts didn't have an immediate effect (like all other shortcuts), but required an app restart. That issue was also present in Spyder 5 and it was very counterintuitive. Now those shortcuts will be updated on the fly.
Introduce a new ShortcutData dataclass to represent shortcut data internally and work more easily with it.
Change context of Switcher plugin shortcuts to be _, i.e. global (before their context was switcher but that made little sense).

Issue(s) Resolved
Fixes #23072
Fixes #22741
Fixes #22516
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@dalthviz, this is ready for review. Please check that:

Shortcuts registered with register_shortcut_for_widget are shown in Preferences.
Changing those shortcuts works immediately (i.e. without a restart) in their respective widgets.

Gave this an initial check and seems like manually changing shortcuts is working and also shortcuts like duplicate line down are being displayed over the shortcuts preferences page :+1: However, when you modify a shortcut and then trigger a reset from the preferences page, the reset changes are not being honored inmediatly:

However, when you modify a shortcut and then trigger a reset from the preferences page, the reset changes are not being honored inmediatly

Thanks for checking that @dalthviz! It should be fixed now.
I also took the opportunity to change the context of the Switcher shortcut actions to be _ because they are actually global shortcuts.

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/config/tests/test_user.py:

Line 379:1: E302 expected 2 blank lines, found 1

@dalthviz, this is ready for another review. Besides addressing your comments, I also took the opportunity to fix other problems with shortcuts I found while doing that in my last four commits.
Specifically, I:

Fixed getting, saving and setting shortcut options with capitalized names (third-party developers could set them like that, so we need to able to process them).
Add a test for registering widget shortcuts for external plugins (so that that doesn't break with future changes).
Validate that shortcut options have the right format (i.e. context/name) when setting defaults. This will ensure that third-party plugins use shortcuts in the way expected by Spyder.

@meeseeksdev please backport to 6.x


Remove 3scale port number from configs

As we no longer use 3scale GET requests to test the setup, we can safely remove this configuration from our setup.
In case we need to check if 3scale has been configured correctly, the best way today would be to send some POST requests to our HTTP API and check the error message, if any.
We can think about including this code in case we decide to meter GETs in the future.

Codecov Report

Merging #1676 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1676   +/-   ##
=======================================
  Coverage   98.46%   98.46%
=======================================
  Files          59       59
  Lines        2862     2862
=======================================
  Hits         2818     2818
  Misses         44       44

If we want to go back to metering GETs in the future, we can always go back in the Git history, since we had that before.

If we want to go back to metering GETs in the future, we can always go back in the Git history, since we had that before.

That's precisely why this is a separate PR and not clubbed with other PRs.

@ttmc Yup. We are good to go wrt grep.


adding placeholder_with_default in order to feed both via dataset and placeholders produces error on GPU

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug or a feature request.
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):1.4.0
Python version: 3.6.2
Bazel version (if compiling from source):0.9.0
GCC/Compiler version (if compiling from source):5.4.0
CUDA/cuDNN version:9.1.85
GPU model and memory:Titan V, 12G
Exact command to reproduce: See below

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
The issue is when you want to train a classifier that takes both placeholder and dataset via queue to feed input. The reason one may want to do that is to run inference via placeholders.
I added the following line under define the model section of train_image_classifier.py of slim library
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
_images = tf.placeholder_with_default(image, shape=[...], name='input)
I get an error of the following kind when running on GPU:
Cannot assign a device for operation 'input': Could not satisfy explicit device specification '/device:GPU:0'

Not sure what can I do, maybe @mahyaar can explain the solution.


Handle Deleted User In Email

This fixes the issue of posts from deleted users showing up in an email campaign. It does two things:

Returns blank if trying to get the profile URL of a user that does not exist
Just displays "Submitted on" instead of "Submitted by user on" if the user does not exists

Here's an example:

Thanks!

I'm actually just refactoring this part of the app, so I'll just merge this is manually. Thanks!

Although, note that the author name is denormalized on the post, so we should always be able to show a name even if the user has deleted their account.

Here's what I ended up doing: https://github.com/TelescopeJS/Telescope/commit/f437153d63a33d7e146346094b3c003b686d864e

@SachaG Nice! That is much nicer. Thanks for the heads up!


Update sum descriptions

Sum does not throw exception anymore when empty array (#251), update this in the descriptions.

Thanx for spotting this. However, These changes itself are not worth pushing a new version. They will be released with a (soon to com) new version. So please, roll back the version update related changes.

Was also wondering whether it was worth to update, removed it.


Using a port other than default results in instant disconnection

Steps:

Set telnet port to 8181
use --port parameter and set to 8181
Console will show connection then instant disconnect. It will loop.

I am unable to replicate this, however I did encounter a similar 'loop' issue a few times during development.
Can you find any other conditions that could be related to the issue?

My bad, I double checked and there was a service running on the same box and the port was in use. Not sure if the code could detect that issue and report back an error message?

No problem at all. I'll look into making the error messages a bit clearer.


feat: adds leaderboards [WIP]

Implements: https://github.com/DarkAtra/v-rising-discord-bot/issues/83
Note: this PR also heavily refactors the DB schema.

The jar version of the bot is now mostly functional and only waiting for the following fix to be released to mvn central: https://github.com/nitrite/nitrite-java/issues/990
The native version is currently failing due to: https://github.com/oracle/graal/issues/7089
I tried both with an older version of GraalVM (the one that used to work up until now) and the most recent version of GraalVM 21. Both are failing with the same error now and i can't narrow down why. There are likely also some runtime hints missing for the new version of nitrite (4.x). It would be great to contribute these hints directly to nitrite.


https://solarsend.intelbras.com.br/

Boa tarde gostaria de saber se alguem conhece alguma integração da intelbras por esse site https://solarsend.intelbras.com.br/

I do not have a login to this website. ——-BradOn Nov 8, 2024, at 8:48 AM, jaisonreiter @.***> wrote:
Boa tarde gostaria de saber se alguem conhece alguma integração da intelbras por esse site https://solarsend.intelbras.com.br/
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

if you can help me, I can send my login to this website.
Today Intelbras is use the Solarman App mobile, and to website  is solarsend.intelbras.com.br,  but, I can't connect direct by Solarman  Services on HA.
Please, if you can help me to connect will be amazing.  You can call by email.
Thanks and have a nice day.


this.wasmModule.OpenModel is not a function

Hi team.
When I try to load the ifc file in my gatsby project, it occurs the error.
Error loading IFC.                              ifc.manager.js 71
TypeError: this.wasmModule.OpenModel is not a function     at IfcAPI2.OpenModel (web-ifc-api.js:61986:1)     at IFCParser.newIfcModel (IFCLoader.js:152:1)     at IFCParser.parse (IFCLoader.js:132:1)     at async IFCManager.parse (IFCLoader.js:2410:1)     at async Object.eval [as onLoad]                        ifc.manager.js 71
My package versions are like this.
"gatsby": "^4.7.0",
"react": "^17.0.1",
"web-ifc": "^0.0.42",
"web-ifc-viewer": "^1.0.218"
Please help me.

Hi @tptspe
We are going to officially release the new library components on September 20. This library will substitute web-ifc-three and web-ifc-viewer. Both WIV and WIT will remain up, but they will be deprecated and won't be maintained any longer.
All our efforts are going towards components now. The API is very similar, so I strongly suggest you make the leap and start using it. You can start using it now (check out the latest alpha version in npm or see the big-restructure branch in the repo. If you still face this issue with it, you can open an issue there and we'll take a look.
Cheers!

Also getting this error, very frustrating after working with the demo for a while only to get to this error with no solution. You should update your docs/examples to mention this.

Hi @agviegas
The API is similar?
before I needed 20 lines of code and it worked flawlessly but now I am ad roughly 100 lines and I needed to make an account on your website and the buttons don't work, the stacking with pointer events don't work and the whole setup is 100x more complicated:
Please just give me a working example from top to bottom in at most 15 lines where I can add an IFC File via input. Everything more is over the top complicated.
Best regards,
Florian


Improve vimspector config file generation

Currently:

the working directory is not set which means access to runtime config files may or may not be possible
on windows, the targetPath is expressed with non-escaped backslashes, which makes the json value not the one the user wants

Thanks @Melandel
I'm away from the computer for the next few days and can't test anything. @jpfeiffer16 are you happy with this?

@nickspoons I'll test it out sometime today.

If you know a good way to translate \ paths into / paths, I would be absolutely interested.
I am currently using substitute(path, '\', '/', 'g') but it has obvious limitations...

@Melandel . I think there is some code in the project somewhere for converting cigwin to windows style paths. I would think that this is exactly what it is doing.

@Melandel , @nickspoons this works as advertised.
I have one concern/question though which is this:
Wouldn't this break workflows where you are trying to, for example access a file relative to the root of your project.
An example of this would be a program that takes a text file as input you would typically run it like so
dotnet run ./test-input-file.txt
If you are setting the cwd to the bin directory, then this way of "running the program" in my current working directory is changed and it would not be able to find the file unless given an absolute path, or the file is marked for copy-to-output. I say this because the way that vscode for example sets up it's launch.json files is so that this "run in the current directory" behavior still works as expected when run in the debugger by default.
So, that would lead me to believe there is an additional reason for having this behavior that I don't understand:

the working directory is not set which means access to runtime config files may or may not be possible

Does this mean that if you debug the project with the CWD set to something other than the bin directory containing the executable that it may not work in some cases?

@jpfeiffer16

Does this mean that if you debug the project with the CWD set to something other than the bin directory containing the executable that it may not work in some cases?

In previous experiences
I did witness the program throwing at the start of its execution, not able to find configuration files such as App.exe.config or appsettings.json for instance - unless it was started from the folder containing the executable.
I am not too used to configuration shenanigans, and in my experience people use this kind of code to setup configuration files:
public Startup(IConfiguration configuration, IHostingEnvironment env)
{
      var builder = new ConfigurationBuilder()
         .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true) // looks for the file in cwd
         .AddEnvironmentVariables();

      Configuration = builder.Build();
}

However
In order to write this post, I took a look at how configuration was handled nowadays and saw that starting with dotnet core 2.1, there is a notion of ContentRoot which determines where the host begins searching for content files and is not the same notion as Current Directory (Directory.GetCurrentDirectory())
I believe that in my previous experiences, the source code was either .NET Framework, either did not use ConfigurationBuilder.SetBasePath(env.ContentRootPath), resulting in the configuration files such as App.exe.config or more recently appsettings.json having to be inside the current working directory.
In short, for my next experiences, I'll start using this line
public Startup(IConfiguration configuration, IHostingEnvironment env)
{
      var builder = new ConfigurationBuilder()
         .SetBasePath(env.ContentRootPath)  // here
         .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
         .AddEnvironmentVariables();

      Configuration = builder.Build();
}

In conclusion

I'll call ConfigurationBuilder.SetBasePath(env.ContentRootPath) in my programs so that there is no need to set cwd to the folder containing the configuration files
I'm removing the code setting cwd in my PR

I think there is some code in the project somewhere for converting cigwin to windows style paths. I would think that this is exactly what it is doing.

Unfortunately not:

let g:OmniSharp_translate_cygwin_wsl=1
echo OmniSharp#util#TranslatePathForClient('C:\Users\tranm\Desktop\tools\vim\pack\plugins\start\omnisharp-vim\README.md')
C:\c\Users\tranm\Desktop\tools\vim\pack\plugins\start\omnisharp-vim\README.md

I'll keep my substitute as is for now!

@Melandel . Thank you for looking into all of that. @nickspoons this looks good to go as far as I am concerned.

Thanks very much @Melandel, and @jpfeiffer16 for the review!


Titles that tell you what's on the page

It might be by design that the title of each page is the same because it makes it obvious for people where they are heading when the website is shared somewhere else.
However, with Open Graph tags, the title of a shared link is customizable separately from the title that's visible in the browser's tab.
I'd be nice to see what feature is being viewed in the browsertab.
I'm thinking something along the lines of:
https://caniuse.com/
  Can I use. Support tables for (new) web features

https://caniuse.com/#search=flexbox
  S: flexbox

https://caniuse.com/#feat=flexbox
  F: CSS Flexible Box Layout Module

Like this, you can still see at least the first few letters of the feature.

Inspired by not being able to differentiate in the history

and https://developer.apple.com/videos/play/wwdc2021/10029/ starting at 7:50 suggesting
<title>Content title | Site Name</title>

a little push maybe, @Fyrd? 0:-)
Picking up the suggestion, I don't think for features the F:  prefix is needed. For others a good solution, e.g. search or the categories. But any form of mentioning the feature would be helpful already, be it in the way suggested by Apple or another, e.g.
<!-- https://caniuse.com/flexbox -->
<title>CSS Flexible Box Layout Module | Can I use... Support tables for HTML5, CSS3, etc</title>

Yeah, agreed. I think it actually used to work similar to this but may have gotten broken in the last major update.

Okay, went ahead and implemented this, let me know what you think!


functools.partialmethod is not supported

import asyncio
from functools import partialmethod

from async_lru import alru_cache

class Obj:
    def __init__(self, loop):
        self.loop = loop

    async def fn(self, x):
        return x

    fn2 = alru_cache(partialmethod(fn, 2))

loop = asyncio.get_event_loop()

obj = Obj(loop)

print(loop.run_until_complete(obj.fn2()))

raises NotImplementedError due
https://github.com/wikibusiness/async_lru/blob/master/async_lru.py#L253

Fixed by https://github.com/wikibusiness/async_lru/commit/ba1c1ed990c851b2fc3e23d7a8b70cc2e71e4f4c


fix: Update cert path

Update the cert path to a more standard default

This PR is included in version 1.1.1 :tada:


[Spotify Controls] - Returns Spotify not installed

Extension
https://www.raycast.com/thomas/spotify-controls
Description
Spotify Controls are returning a Spotify is not Installed message. I have Spotify installed and it is Spotify Premium
I have tried:

Uninstalling Spotify App with Spotify Controls installed
Uninstalling Spotify Controls with Spotify App installed

Steps To Reproduce

Install Spotify Controls
Install Spotify App
Login to premium account
Attempt to use a command e.g. Play
Receive message Spotify is not installed

Current Behaviour
No response
Expected Behaviour
No response

Update on this - once the computer was restarted it works as expected.

I have restarted the computer and it still mentions spotify is not installed.


SagaTestError: Assertion 1 failed: call effects do not match

saga function
export function* signIn(action) {
  try {
    const response = yield call(axios.post, '/api/v1/users/signin',
      {
        email: action.email,
        password: action.password
      });

    const { token } = data.response;
    const decode = jwt.decode(token);
    localStorage.setItem('jwtToken', token);
    yield put({ type: actionTypes.SIGN_IN_SUCCESS, user: decode.user });
  } catch (error) {
    Materialize.toast(error.response.data.message, 4000, 'red');
    yield put({ type: actionTypes.SIGN_IN_ERROR });
  }
}

test using  import { testSaga } from 'redux-saga-test-plan'
const user = {
  email<EMAIL_ADDRESS>  password: 'ABDC123.@'
};

let saga = testSaga(signIn, user);

saga.next().call(mock.onPost, '/api/v1/users/signin', user);
saga.next().put({ type: actionTypes.SIGN_IN_SUCCESS, user: undefined })
saga.next().isDone();

what is fn: [Function: wrap] and the difference between   fn: [Function] and fn: [Function: wrap]

Functions have their unique identity, it's the very same as in:
const foo = {a:1}
const bar = {b:2}
foo === bar // false

If you want to compare effects using deep equality you are probably looking for this:
saga.next().call(axios.post, '/api/v1/users/signin', user);

axios.post will not be executed, because in tests you do not run your effects.


[FSDE-3064][FSDE-3065][FSDE-3067][FSDE-3068][FSDE-3069][FSDE-3378][FSDE-3429] Add support of Vue + nuxt.js implementation of chi documentation

Commit summary

[x] Built Vue + Nuxt.js architecture with PUG pre-processor for Chi documentation
[x] Added support of reusable component for generating Examples with respective code snippet tabs
[x] Added support of Highlighting code snippets to Chi Vue + Nuxt.js implementation of documentation
[x] Migrate Accordion component documentation examples and properties
[x] Added support of reusable page Head and Examples, Properties, Accessibility tabs to Chi Vue + Nuxt.js implementation of documentation
[x] Added support of theme switcher for Chi documentation
[x] Added support of sidebar navigation of Chi documentation pages

https://ctl.atlassian.net/browse/FSDE-3064
https://ctl.atlassian.net/browse/FSDE-3065
https://ctl.atlassian.net/browse/FSDE-3067
https://ctl.atlassian.net/browse/FSDE-3068
https://ctl.atlassian.net/browse/FSDE-3069
https://ctl.atlassian.net/browse/FSDE-3378
https://ctl.atlassian.net/browse/FSDE-3429

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-161/1/. :white_check_mark:

You can check this PRs instance in https://db45dd28af3fa44176ec63dad1eee564498d4958-chi-pr.enterprise.ctl.io


Fix EOF detection while iterating BQ rows + add ASN queries

Changes:

Fixed bug in EOF detection - the exporter previously compared currentRow with itself rather than with lastRow, so only one JSON file per partition was being uploaded
Added ASN queries (thanks @critzo) and fixed null region bug
ASN queries are always sharded by the asn field to improve parallel processing
Inflight uploads are now recorded in a histogram metrics rather than just a gauge. This allows to effectively "see" how much the uploader workers are busy

Dashboard to see the available metrics: https://grafana.mlab-sandbox.measurementlab.net/d/07rwXefMz/stats-pipeline-monitoring?orgId=1&from=now-15m&to=now

This change is

statistics/queries/continent_country_region_asn_histogram.sql, line 26 at r3 (raw file):
Previously, robertodauria (Roberto D'Auria) wrote…
I think you're right, but I'm not sure how it should work right now. We added this to prevent the creation of folders on GCS like v0/EU/IT/IT-/... where the Subdivision1ISOCode code isn't there, which apparently can also happen for measurements from 2020, too. @critzo perhaps you know more about that?

@stephen-soltesz @robertodauria Assuming geo2 annotations are the most correct, and that other ndt data types will be moving to geo2, it is absolutely fine with me if ndt5 and web100 results are excluded until that happens.


model compatibility

Is there any way to transform pytorch model to caffe, or tensorflow?

We plan to add this over time, but at the moment there is no converter.
However, if you look at model.state_dict(), it is a simply python dict with the weights, and you can use this dict to manually copy over the weights to other frameworks.

@soumith   It seems that model saved with model.state_dict() is not portable between different machines?  https://discuss.pytorch.org/t/erros-in-loadding-model-pth/2632/3


More descriptive tab titles

I'm submitting a feature request
At the moment the tab title is always OSMCha. It would be useful to be more specific.
What is the motivation / use case for this feature?
Many browser features are hard to use at the moment, because they rely on descriptive tab titles:

If you have multiple OSMCha tabs open, they all look the same in the tab bar
The browser history and holding the back button shows no useful information

What  is the current behaviour, (attach relevant screenshots) ?

What  is the expected behaviour ?
I suggest showing the name of the current filter for named filters.
For unnamed filters (for example when clicking a username) the most important filter parameters could be shown, e.g. OSMCha  - Flagged from <username>
Please tell us about your environment:
Firefox 91.0 (64-bit)

Absolutely! The navigation usability (at present, as M-Miller-42 aptly illustrates) is horrendous.
Effective (let alone efficient) navigation requires knowing where you've already been (& come from).
The back button is a safety feature for users; what should be an easy way to escape to somewhere more familiar.
Aside from navigation history, another (comparable) scenario which encounters the same problem is if one had multiple tabs, each pointing to (different URLs at) OSMCha.
Which tab is the one that the user wants?
Some relevant usability advice: Microcontent: how to write headlines, page titles, and subject lines.
Though, a couple minor quibbles:

tab title

It's actually (the contents of) the HTML <title> element (in the <head> element).
How it's rendered by an HTTP User-Agent ( e.g. browser) is a different matter. Not all browsers have tabs (and not all HTTP User-Agents have a GUI, or even an interactive UI).
Might I suggest renaming this ticket to page titles (that is; s/tab titles/page titles/)?

OSMCha - Flagged from

The correct typographical character, in that context, would be the Em-Dash (U+2014). The hyphen character is for compounding words.
So, instead, the quoted sample would be
OSMCha — Flagged from <username>

A secondary benefit of resolving the OP problem, is that server-load might (depending on other factors) reduce.
How? I find that I have to step back one URL at a time, because it's unclear which is the right one to select in the list. That's many more requests to the server than if I can jump back to exactly where I want to return (skipping all the intermediaries).


[PE-D][Tester D] Leaving optional fields blank results in empty space in person'

Describe the Bug
Add a person with no optional fields results in the person's row having blank spaces, resulting it in looking out of place. This could be unappealing to certain students looking to use this GUI for an academic or work environment
Corresponding Screenshot

Possible Solutions
Developers can consider reducing the height of the person row if some optional fields are left blank. Another solution could be to add labels for data fields, but display their values at None. So for example, if module was blank, then Module: None could be displayed.

Labels: severity.VeryLow type.FeatureFlaw
original: jayjay19630/ped#7

This bug has been noted and will be solved in future implementations. For now, it will be mentioned in the Developer's Guide for future improvements.


fix(RELEASE-1082): linting issues in push-rpm-manifests-to-pyxis

Describe your changes
Relevant Jira
Checklist before requesting a review

[ ] I have marked as draft or added do not merge label if there's a dependency PR

If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag

[ ] My commit message includes Signed-off-by: My name <email>
[ ] I have bumped the task/pipeline version string and updated changelog in the relevant README
[ ] I read CONTRIBUTING.MD and commit formatting

/retest


Consider implementing ReadPartition in terms of Connection::ReadParams

Currently ReadPartition is implemented as the ReadRequest proto. Changing its implementation may simplify some of the code and increase efficiency.

If/when this change is made, revisit MakeReadParams(ReadPartition const&) and possibly change to pass by value.

Points in favor of leaving ReadPartition as is:

ReadPartition would lose its default constructor because ReadParams contains a Transaction which is not default constructible.
When serializing a ReadPartition, the session_name and transaction ids need to be accessed even though Transaction has no such accessors. Perhaps a call to Transaction::Visit would suffice.
Currently its proto member variable can be directly serialized, but the ReadParams have to be constructed with copies from the proto. This would simply be reversed if the implementation was changed to be ReadParams.
MakeReadParams (which performs the copy) is an internal friend function only called by our code. Serializing and Deserializing are user space functions which require less copying.

Additionally, I'm going to add a private constructor to remove a copy.


Add headers to image request

I have a use case where I'm using authorization headers, and the React Native Image component allows me to pass those directly into the source of an Image.  It would be great if the same thing would work with this library!
Theoretical example:
<FasterImageView source={{
  uri: src,
  headers: {
    Authorization: `Bearer ${token}`,
  },
 }} />

@micahlt live on latest version!

Wonderful!  Thanks so much!


Why Inflector::slug in Yii2 generates wrong latin string from cyrillic?

Inflector::slug in Yii2 generates not correct string from cyrillic.
Example: автоматизация -> avtomatizacia, but it must be avtomatizaciya; зачислить -> zacislit, but it must be zachislit. How to fix it?
This tool is correct https://you.tools/slugify/
I use this for SEO urls. Can this influence if search engines will not recognise the correct keyword to improve SEO results for my website?

Yii uses transliteration for all languages via PHP's intl. You can affect results via configuring it: https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseInflector.php#L290. Not sure how much SEO is affected though.


docs: fix SDK doc link broken

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[x] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

New feature or improvement

Describe the details and related test reports.

Fix the README.md SDK doc link broken.

@stu01509 Well done!


Focus plugin search bar when opening plugin panel

Automatically focusing the search box when opening the plugin configuration panel allows users to open and immediately search for plugins.
Personally when I want to change a plugin setting I use the search to find the plugin 90% of the time.

This looks like regression it was working before.

Fixed locally, will upload a PR soon with a few ui fixes.

@psikoi @deathbeam I'm still seeing this issue in v<IP_ADDRESS>

Really? Has the code on that ui component changed? Haven't been paying much attention due to exams.

Not as far as I can see, it still seems to be in there:
https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/ui/components/IconTextField.java#L169-L174
It just isn't focusing the search bar. :man_shrugging:

Well, thats the code i added to prevent this, but ill take a look at this in a bit


Incompatible Functions

Removed unused/incompatible functions that discord doesnt use for profilesync.
Added note in readme on how to install for manual users.

Thanks :)


Delay random number generation to runtime

Question
Most of the APIs such as POST /tasks expect a mock response with unique id per call, so that UI can be tested with multiple unique values (tasks in this example)
{
  id: 1, << this value should be unique per call at runtime
  ...
}

But the contract API seems to be generating fixed random number in advance at build time & returns only this build time fixed value at runtime instead of generating one at runtime.
Since this is a common requirement, we should delay the number generation to runtime.
Testcase:
import static org.springframework.cloud.contract.spec.Contract.make

make {
  request {
    method GET()
    urlPath('/random')
  }
  response {
    status 200
    body([
        directRandom       : Math.random(),
        anyNumber       : anyNumber(),
    ])
  }
}

One would expect the above API to generate random number per GET, but it returns the same value irrespective of the number of time the API is called

anyNumber() is indeed a fixed value for the producer and that's a good way to do it. There's no obligation to always generate a new value (it's a contract tests, not a functional test). If you need a unique value being generated you can call the new Random as you wrote.

Even the random is generating a fixed value

Can u share an example where I can generate a ransom value per call

Also a section from wiremock

Sometimes, returning wholly static responses to stub requests isn’t practical e.g. when there are transaction IDs being passed between request/responses, dates that must be current. Via WireMock’s extension mechanism it is possible to dynamically modify responses, allowing header re-writing and templated responses amongst other things.

http://wiremock.org/docs/extending-wiremock/
So, we do need dynamic value support, such generating current date, e.t.c

One more project that developed wiremock extensions
https://github.com/teads/wiremock-extensions

I think the issue need to be reopened as currently there is no provision to do what is mentioned in the issue (neither dynamic number nor dynamic date).


Open shading language aka OSL support?

Now that we have OpenEXR and OpenImageIO merged seems the next step..

We can’t reopen this issue until a PR is opened, unfortunately, consider making a pull request!


terminal.quickFixes -> terminalQuickFixes

fix #167577

Does this need adoption in the npm extension?

tested using the npm quick fixes via npm audt and saw the quick fix show up, though not always bc of https://github.com/microsoft/vscode/issues/172068


Removed unused link in faq/help.txt.

Unused since its introduction in 97cb07c3a10ff0e584a260a7ee1001614691eb1d.

Well spotted
I also see 97cb07c3a10ff0e584a260a7ee1001614691eb1d also added "Batman" to AUTHORS. We don't know Batman's real identity do we?

I also see 97cb07c also added "Batman" to AUTHORS. We don't know Batman's real identity do we?

Not really :smile: only Jacob knows the true :bat:


What's the minimum version of CDK?

Had on Cloud9 env with 1.12 and ran into problems

As noted in https://github.com/aws-samples/aws-cdk-transit-gateway-peering/blob/master/requirements.txt#L18
The code tested was with v1.34.1


Parameterization api change

[x] Tag issue being addressed
[x] Add tests
[ ] Update docstrings/documentation, if applicable
[x] Update changelog
[ ] All tests successfully pass

Codecov Report

:exclamation: No coverage uploaded for pull request base (devel@a66394e). Click here to learn what that means.
The diff coverage is n/a.


Animations doc is obsolete.

Animations docs shows commit as Xamarin.Forms did:
animation.Commit(this, "SimpleAnimation", 16, 2000, Easing.Linear, (v, c) => image.Scale = 1, () => true);
but Maui use IAnimationManager:
public void Commit(IAnimationManager animationManger);
CustomAnimation

Ok, there are two animation class:
https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Animation.cs
https://github.com/dotnet/maui/blob/main/src/Core/src/Animations/Animation.cs
The documentation is about first?

Hi @marcoablanco
You should be using the Animation class in Controls, rather than Core. Controls.Animation consumes Core.Animation. If you look at https://github.com/dotnet/maui/blob/main/src/Controls/src/Core/Animation.cs you'll see it derives from BaseAnimation, which is actually https://github.com/dotnet/maui/blob/main/src/Core/src/Animations/Animation.cs.


add option to encapsulate

Checklist

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Resolves #197

Will this change interact safely with fastify-autoload's default with the same name?

Thanks @Eomm; I pushed your changes to this branch


Extracted text keep the color change even the extracted item is deleted. makes ppl annoying.

Description
A clear and concise description of the issue you are experiencing. Remember, this is not a place to ask questions. For that, go to https://discord.gg/vUQhqCT.
Extracted text keep the color change even the extracted item is deleted. makes ppl annoying.
Steps to Reproduce
Tell us how to reproduce this issue.

Go to '...'
Click on '....'
Scroll down to '....'
See error

alt+x to extract some text, then delete that item.
Expected behavior
A clear and concise description of what you expected to happen.
the previously extracted but now not extracted text should return to normal text (i.e. not highlighted)
Logs, Screenshots, ...
If applicable, add relevant files:

Logs (My Documents\SuperMemoAssistant\Logs)
Screenshots
Videos
Contextual files [e.g. SM Collection, PDF document, LaTeX formula]

Environment (fill where applicable)

Version: [e.g. SMA <IP_ADDRESS>, PDF Plugin <IP_ADDRESS>]
SMA 2.1.0 beta.21, PDF plugin 2.1.0 beta 14

Last version that did not exhibit the issue:

SM Version: [e.g. SM 18.04]

SM 18.05

OS: [e.g. Windows 10 64bit]

OS Language: [e.g. English (UK), French (FR)]

Browser: [e.g. Chrome 68, Safari 45]

Additional context
Add any other context about the problem here.

I have the same question as yours, is there a solution?

i gave up on SM, too little ppl use it, and not open source means you cant change it.
i'll say supermemo could survive if they SELL their SM18 as a module and use it inside anki?
somehow make some license protection for that module.


Fix unclickable observations bug (#298)

Fixes issue #298 and #339
Ended up translating the entire list rather than just the header.

@kueda  i'm getting that issue even on the main branch. did a clean build and everything...guessing it's a deeper issue but i havent had much time to debug. will take a look later today or tomorrow

Seems to have occurred in 516b1a487ddc140288eb5a7b35cb52e23b0f1027. I'm spending some time on it today, but holler if you have any ideas.

@kueda I got lucky and was able to get an error message. Pushed the fix along in this pr.

Hm, we've been hitting different problems with the capitalize function in DisplayTaxonName, which probably has to do with unicode handling in Hermes for Android. Replacing the long unicode string at https://github.com/inaturalist/iNaturalistReactNative/blob/main/src/components/DisplayTaxonName.js#L46 with a blank string fixes the problem, so we might have to disable that weird capitalization code for now. We're experimenting with it and may just push a fix to main.

Sounds good to me, appreciate the help on this one

Ok, the Android issue should be fixed in #347, and yeah, definitely unrelated to this work, so I think this is good to go.


Add support for parameter max-series-per-database

According to the changelog they added the parameter max-series-per-database with a default of 1M. This patch should allow the user to disable this limitation, by setting max-series-per-database to 0.

tnx !!


Three Dots in Header Photos

BUG
Current Behavior
Some campaigns have three dots that appear on the left of the header photo, and some don't.
Desired Behavior
Three dots should not appear.
Steps to Replicate
Go to the header photo of the campaigns listed below.
Why This Matters
These dots are weirddd.
OS/Browser (optional)
Chrome
Relevant Screenshots + Links
A campaign with three dots:
https://www.dosomething.org/us/campaigns/pride-over-prejudice

Another campaign with three dots:
https://www.dosomething.org/us/campaigns/school-board-tweeter?source=campaigns

Another campaign with three dots:
https://www.dosomething.org/us/campaigns/re-poppin-bottles?source=campaigns

A campaign without three dots:
https://www.dosomething.org/us/campaigns/birthday-mail

Inspect Element shows:

This looks like an Optimizely problem:

ah! lovely!

there's nothing we can do

@ngjo since this is Optimizely issue, I think it's something that you + me + @DFurnes (our dev Optimizely expert) could handle -- here's something I found on it:
https://community.optimizely.com/t5/Using-Optimizely/Optimizely-breaking-jquery-dotdotdot-ellipsis-feature-when-test/m-p/9085#M2316
Also -- just checked Thor (which Optimizely doesn't run on) and the "..." aren't showing up:
https://www.dosomething.org/us/campaigns/solitary-statements

not seeing this anymeow! 🔮


Popup: close popup when user clicks outside of the popup

Feature Request
There needs to be a possibility to close popup when the user clicks on the document (or focuses element outside of the popup).
Problem description
When the user opens a popup and clicks on the document outside of the popup, the popup remains open.
Proposed solution
Use Portal or portal-like functionality as it was before the refactoring.

This used to work, @kuzhelov I know it was removed as part of Popup refactoring, can we add it back?

#410


Alpaka_Move With Latest Changes

Working version with latest pull request changes. I will post timing and validation plots soon.

Could you rebase the PR on top of the master, so that only your commits are there? Otherwise it would be a nightmare to review...
By the way, why did you create a new PR and not update the one that we have already open, as we have been doing up till now? I can see that the only thing that's missing from that PR is a single commit that rebases (which didn't really work for this PR anyway) and simple setup fixes.

Closing this in favor of rebasing directly on the alpaka_move branch as discussed.


Apartment units

I was wondering if there's currently support for secondary addresses such as apartments, condos, and offices, or if that's outside the scope of libpostal. When I run an address like 1500 CHESTNUT ST APT B, PHILADELPHIA, PA through address_parser I get:
Result:

{
  "house_number": "1500",
  "road": "chestnut st apt b",
  "city": "philadelphia",
  "state": "pa"
}

For my particular purposes it would be great if there were distinct tags for the unit designator and unit num.
Thanks!

It's not implemented yet as there's very little sub-building information available in OSM addresses. I'm working on a branch at the moment called parser-data which generates apartment numbers, PO boxes, etc. in multiple languages and a variety of formats to supplement the OSM addresses.
The new model's not usable at the moment, but once it's trained there will be a distinct tag for "unit" and the parser shouldn't have trouble with sub-building addresses. It's a single tag. Designator/number as a pattern doesn't really cover all unit types (English counter examples: "penthouse" or something like "top right" as seen in Edinburgh). Still, it would be very easy to strip out words like "apt" from the full unit string using a regex and the fairly comprehensive libpostal dictionaries.

Good to hear, I'll keep an eye out for the new model. Thanks!


Credits

Please add your name to the list of contributors http://grmpy.readthedocs.io/en/latest/credits.html

This is done, but #120


Updating IP address of Breeze in Brazil South

Updating IP address of Breeze in Brazil South

@dharmt001 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


chore: apply prettier to more files

Uses .eslintignore as if it were .prettierignore so we can now apply prettier to everything that ESLint should apply to (AND MORE!)
Note: I dropped toml from the list of prettier extensions since it throws an error when it matches due to missing plugin, and the plugin is alpha. The toml file didn't match the previous glob.

 Do they get re-written each time or some how diffed?

@benjie this is actually desired and works great. it just appends the files. so it would be nice to format after every changelog generation, which we do by running lerna publish, which runs lerna version and thus git add/commit under the hood


IOError: [Errno 24] Too many open files: '/proc/cpuinfo'

Platform/operating system (i.e. Raspberry Pi with Raspbian operating system,
Windows 32-bit, Windows 64-bit, Mac OSX 64-bit, etc.):  Raspberry Pi 3

Python version (run python -version or python3 -version):  Python 2.7.13

Error message you are receiving, including any Python exception traces:

File "/usr/local/lib/python2.7/dist-packages/Adafruit_DHT-1.4.0-py2.7-linux-armv7l.egg/Adafruit_DHT/platform_detect.py", line 9
with open('/proc/cpuinfo', 'r') as infile:
IOError: [Errno 24] Too many open files: '/proc/cpuinfo'

List the steps to reproduce the problem below (if possible attach code or commands
to run):

Run a python API that has an endpoint calling Adafruit_DHT.read_retry. Make a cronjob that calls the enpoint every minute.
The problem comes from lines 65 and 92 in:
https://github.com/adafruit/Adafruit_Python_DHT/blob/master/Adafruit_DHT/platform_detect.py
The code is opening the file '/proc/cpuinfo' but not closing it. So if a Python sessions stays open, this will eventually open too many files. The solution is to close the file after reading it.

Well the files are opened using with so they should be closed automatically....still not sure then why I'm getting this error...

we;re deprecating this library soon, please try https://github.com/adafruit/Adafruit_CircuitPython_DHT


Fix broken nounce handling

It seems to me that the current implementation of nounces are broken. Please read my commit messages as they should explain everything:

Remove deprecated "getNonceOldStyle" function
This commit removes the following functions:

getNonceOldStyle
generateNonceStringOldStyle

The functions have been replaced in newer versions of
grav. It seems to me that they only existed in order to make a
upgrade to a newer version of grav painless (i.e. accept both types of
nonce tokens). Nowadays, existing old style nonces are expired long
time ago so it should be save to delete the deprecated funtions.

Don't save nonces in static class variable
Currently, the behavior of getNonce is broken because it saves the
generated nonce in an array and only use the $action as the
key. However, the generated nonce does not only depend on the $action,
but also on $plusOneTick.
I can't imagine that this is a performance critical part of grav. So
the easiest way is to remove the whole "caching" mechanism. If we
really need some kind of caching, we should implement it in a proper
way and also think about how (or when) the cache should be
invalidated.

Fix broken "plusOneTick" for nonces
It looks to me that there is a bug in the current implemention of
verifyNonce. Here is an example:

2018-08-01 10:00: We respond to a request and generate a nonce. The
current tick is at 35489

2018-08-01 10:05: We use the previously generated nonce to make
another request. We compare the given nounce with a new generated
one (based on the same tick). The result is exactly the same and the
request succeeds.

2018-08-01 14:00: We're now one tick ahead. Remember: A day (24
hours) is separated into two ticks (each 12 hours). A request comes
in, we compare the given nounce with a newly generated one based on
the current tick (now at 35490). They don't match (which is totally
okay).
If the comparison fails, we then compare the given nounce with a
another, newly generated one. This time, we pass "plusOneTick", to
the function, which increases the current tick by one. Our tick is
now at 35491. We generate a nonce based on that tick and of course,
it still does not match the given nonce.
Instead of increasing the tick, we should rather decreasing it by
one (i.e. use the previous tick). If the first comparison fails, we
use the current tick (35490), decrease it by one (35489) and then
compare it again. 35489 is the same tick as in the very first
request.

This bug leads to a maximum life time of 12 hours for a nonce and in
worst case only a few seconds (!)
I would like to prove the bug with an unit test but I'm too unexperienced
in PHP. Furthermore it seems that we need some kind of library which
is able to mock builtin functions (like "time"). Maybe
https://github.com/Codeception/AspectMock would be a good canditate?

I did some tests inside a docker container (with libfaketime to modify the time inside the container). I can reproduce the issues and also that my changes fix them.
You can more ore less easily reproduce the issue yourself:

Install grav-plugin-admin and open the admin interface in your brower
Make sure it is before 12:00 (UTC)
Click on "Pages"
Click on "Add" or open an existing page
...wait for the next tick
Click on "Save"

What happens: Now you will see the PLUGIN_ADMIN.INVALID_SECURITY_TOKEN error message.
What I expected: Successful request. The nonce (token) is not older than 24 hours so it should just work.

I believe I've run into the issue a few times (unexpected error messages), so I do think it is important to find a fix for this, but I do agree that the nonce function should still have caching from the reasons given by @rhukster .

@rhukster Now I see your point, thanks for the clarification.
I have updated the PR:

reverted the removal of nonces caching
fix caching so it works with $action and $previousTick
squashed the new commits together
rebased against current development branch

I'll test the changes in the next few days but I think they should work as expected. What do you think?

Can I do anything to speed things up?

I just need to do some testing..

OK, tested and looks good.  Thank!


g_loss divergence

hello
thank you for good implementations
I am training drit for celeba dataset
trainA is black hair and B is brown hair
in training, g_loss  divergence (inf)
please give me a some tip in this case
current args setting is default
thank you

hair change is shape preserving translation
So you use concat = True

I'm tested cat2dog that is concat = False, but didn't g_loss go to infinity...
Does infinity mean nan?

yeah
I meant the nan value.
This does not happen after lr is halved. (lr = 0.00005)
It's a special case
this is good implementation
thank you

I have this nan problem with another dataset. What is the reason, do you have a guess?


Difference between ignored and reviewed

Recently I got a question from my teammate:

What's the difference between reviewed and ignored in .licensed.yml?

I found only the following:
# These dependencies are explicitly ignored.
ignored:
  bundler:
    - some-internal-gem

  bower:
    - some-internal-package

# These dependencies have been reviewed.
reviewed:
  bundler:
    - bcrypt-ruby

  bower:
  - classlist # public domain
  - octicons

For me it's still not really clear when I should put a gem into ignored: and when into reviewed:. Can you guide me?
Probably this should be clarified in the docs or combined into a single category to avoid confusions and save time debating with colleagues.

They do the same thing (@jonabc will correct me if that's not the case) but the use I've seen is like the example implies: ignored for internal dependencies, reviewed for external dependencies that aren't automatically allowed per the allowed list and license detection.
Ideally/wishlist I suppose they could have some different additional tooling, eg check whether a dependency can be moved out of approved and tests still pass, guardrails to detect whether something has changed that might merit a new review, or to detect whether a dependency really is internal.

@sergey-alekseev @mlinksva
reviewed is meant for dependencies that need to be cached and checked, but do not have a license found that matches the allowed configured licenses.
ignored is meant for dependencies that shouldn't be cached at all, and will not have cached metadata written to the repo.
Good question!  I'll update the docs when I have a chance, though I'd also welcome a PR :smile:

Thanks for the clarification! @jonabc
I copy-pasted your comments and made a PR to add the docs change to your to-do list.

An interesting thing though. Chances are an external dependency doesn't have a license info (examples: https://github.com/iain/http_accept_language/issues/72, https://github.com/grosser/i18n_data/pull/47, https://github.com/grosser/sort_alphabetical/pull/23). If added to reviewed then licensed status fails with "missing license text". Hence they should be added to ignored. So I'm not sure whether "but do not have a license found that matches the allowed configured licenses." suits well for reviewed 🤔

@sergey-alekseev what you described is intentional, though I'm not sure what the recommended remediation here is.  @mlinksva any thoughts?

I'd add (and recall having done this) some evidence for the reviewed status in the case no license text at all is extracted. In the case of the first example above, "Released under the MIT license" pulled from https://github.com/iain/http_accept_language/blob/74a6a244afa069154d08df0f5df373a6c7fc4fe2/README.md#with-bundler
Note https://github.com/github/licensed/issues/189 (depending on specific implementation) could make this situation less common: in the case of the first example above again, https://github.com/iain/http_accept_language/blob/74a6a244afa069154d08df0f5df373a6c7fc4fe2/http_accept_language.gemspec#L13 would be recorded by licensed along with any license texts found.

Aside: thank you @sergey-alekseev for making PRs (seen from your examples, also thanks for providing concrete examples!) to improve licensing documentation from projects where it is missing, silently saving time for developers using (as they should) license tooling (licensed or numerous others) who might otherwise need to ask for review of innocuous dependencies.

@mlinksva I probably didn't put enough emphasis on "missing license text". To make sure we are on the same page first let me clarify. licensed cache fetches licenses well for those examples. What's missing in these examples is license text (e.g. from a LICENSE file). See below:
$ licensed status
Checking cached dependency records for project
..........F.F....................F...................
Errors:
* project.bundler.http_accept_language
  filename: project/.licenses/bundler/http_accept_language.dep.yml
    - missing license text

* project.bundler.i18n_data
  filename: project/.licenses/bundler/i18n_data.dep.yml
    - missing license text

* project.bundler.sort_alphabetical
  filename: project/.licenses/bundler/sort_alphabetical.dep.yml
    - missing license text

N dependencies checked, 3 errors found.

project/.licenses/bundler/http_accept_language.dep.yml:
---
name: http_accept_language
version: 2.1.1
type: bundler
summary: Find out which locale the user preferes by reading the languages they specified
  in their browser
homepage: https://github.com/iain/http_accept_language
license: mit
licenses: []
notices: []

project/.licenses/bundler/i18n_data.dep.yml:
---
name: i18n_data
version: 0.7.0
type: bundler
summary: country/language names and 2-letter-code pairs, in 85 languages
homepage: https://github.com/grosser/i18n_data
license: mit
licenses: []
notices: []

project/.licenses/bundler/sort_alphabetical.dep.yml:
---
name: sort_alphabetical
version: 1.1.0
type: bundler
summary: Sort UTF8 Strings alphabetical via Enumerable extension
homepage: https://github.com/grosser/sort_alphabetical
license: mit
licenses: []
notices: []

project/.licensed.yml:
sources:
  bundler: true

allowed:
  - mit

reviewed:
  bundler:
    - http_accept_language # no license file (see https://github.com/iain/http_accept_language/issues/72)
    - i18n_data # no license file (see https://github.com/grosser/i18n_data/pull/47)
    - sort_alphabetical # no license file (see https://github.com/grosser/sort_alphabetical/pull/23)

So if I understand correctly your proposal is to change project/.licenses/bundler/http_accept_language.dep.yml to the following:
name: http_accept_language
version: 2.1.1
type: bundler
summary: Find out which locale the user preferes by reading the languages they specified
  in their browser
homepage: https://github.com/iain/http_accept_language
license: mit
licenses:
- sources: README.md
  text: Released under the MIT license
notices: []

Am I correct?
Also I can fill in recently added license text for project/.licenses/bundler/i18n_data.dep.yml and project/.licenses/bundler/sort_alphabetical.dep.yml even though they didn't have that text at that version. Would that be fine in your view?

Aside: there is still a room for Licensed improvement. For my project I had to change 36 .licenses/bundler/*.dep.yml files manually our of 171 dependencies (21%). 23 times I changed only license: other, 11 times only licenses: [] and 2 times both. Filling in some details manually is quite easy and quick, so I didn't want to spend more time exploring the source code to understand why it happens. However one interesting thing I noticed is Licensee fetching license well from a git source, but not locally:
2.5.5 :001 > require 'licensee'
# => true
2.5.5 :002 > license = Licensee.license '.../gems/awesome_print-1.8.0'
# => #<Licensee::License key=other>
2.5.5 :003 > Licensee.license 'https://github.com/awesome-print/awesome_print/tree/v1.8.0'
# => #<Licensee::License key=mit>

An external dependency that's found but doesn't have license text shouldn't be set as ignored

Does this mean that even though an external dependency has e.g. the MIT license but doesn't have license text you can't use it? At least licensed status will not succeed. I'd agree with this comment, but you know licensing requirements, so can you please clarify? @jonabc
I did a quick search to see whether you had any comments on that during the development, but looks like the requirement was added during the initial release of v1.0.0 in the first commit.

Going to answer as many of these as I can 😄

So if I understand correctly your proposal is to change project/.licenses/bundler/http_accept_language.dep.yml to the following:

Any content licensee detects from a README is already included in cached output, so I don't think it's that.
What would change in this example is that we'd be showing the license specification picked up from http_accept_language.gempsec.  Still working through the best way to show that, but as a possible example
name: http_accept_language
version: 2.1.1
type: bundler
summary: Find out which locale the user preferes by reading the languages they specified
  in their browser
homepage: https://github.com/iain/http_accept_language
license: mit
licenses:
- sources: http_accept_language.gemspec
  text: s.license     = "MIT"
notices: []

If my understanding is correct, this is a slippery slope for the reasons outline by licensee.  If others with better understanding of OSS licensing requirements give a 👍 that representing this content as a license is ok I'm happy to make that change.

For my project I had to change 36 .licenses/bundler/*.dep.yml files manually our of 171 dependencies (21%). 23 times I changed only license: other, 11 times only licenses: [] and 2 times both

Yeah that's painful.  Some feedback around the details of why you had so many adjustments needed would be great

license: other:  Is the license text far enough off from the standard template for the license that a false negative is found?  Are multiple licenses found?  Something else?
licenses: []:  Do all 11 of these not have any LICENSE type file and nothing in the README?

That said, licensed won't overwrite the license field on dependency version updates if the (normalized) license contents are determined to be the same between the cached and new version.  In our experience there is high likelihood that nothing changes re: license contents between versions of a dependency, so a majority of the pain in clarifying licenses is only experienced once.

However one interesting thing I noticed is Licensee fetching license well from a git source, but not locally

That's a better question to ask at Licensee directly, though in my experience I've found this has to do with gem not installing all the files that Licensee uses from the repo as part of the package.

Does this mean that even though an external dependency has e.g. the MIT license but doesn't have license text you can't use it? At least licensed status will not succeed. I'd agree with this comment, but you know licensing requirements, so can you please clarify?

This is the part where I get to say I'm not a lawyer and don't personally have an answer on what constitutes a binding agreement when using an OSS license.  I don't know @grosser personally and couldn't tell you whether his comment is based in legal knowledge or personal opinion.
As I mentioned before, licensee does bring this up in case that helps?

I did a quick search to see whether you had any comments on that during the development, but looks like the requirement was added during the initial release of v1.0.0 in the first commit.

The requirement is older than my involvement in the product 😆 I asked awhile ago whether reviewed dependencies should still surface this error, and the answer was to keep the error in place.  I don't recall whether the question+answer was pre-v1 release or not, but I couldn't find anything in the issue/PR repo history.

Thanks for your answer @jonabc

Any content licensee detects from a README is already included in cached output, so I don't think it's that.

I believe my previous assumption was wrong if I understand your comment correctly. Then I'm not sure how to make licensed status green in this case. Probably with sources: http_accept_language.gemspec as you outlined. Can you please rephrase and clarify, so I can understand better what you mean?

Some feedback around the details of why you had so many adjustments needed would be great

Some examples added to https://github.com/sergey-alekseev/licensed-example. All of them can be fixed manually I believe. Some previous failures were fixed by https://github.com/github/licensed/pull/188 and no longer require manual entry.

so a majority of the pain in clarifying licenses is only experienced once.

Yes. So not really painful.

I believe my previous assumption was wrong if I understand your comment correctly. Then I'm not sure how to make licensed status green in this case. Probably with sources: http_accept_language.gemspec as you outlined. Can you please rephrase and clarify, so I can understand better what you mean?

That sounds like the best option for now as the most straightforward fix.  Hopefully as we figure out https://github.com/github/licensed/issues/189, much of this will just fix itself automatically.  If you have any specific preference beyond "just make it work please", please do to comment on the issue 🙇 😄

Some examples added to https://github.com/sergey-alekseev/licensed-example

I forked your example 👍 I don't have enough time to dig in at the moment but I'd love to look through this and see exactly why each other classification occurred.  It'd be great if we could better support some of these scenarios

Awesome. Hopefully https://github.com/github/licensed/issues/189 will solve the problem.

@sergey-alekseev thanks for your patience!
I just completed a quick audit of the example you provided.  Here's my findings for things without license contents, and those marked other
No license contents
This class of failures is what we're trying to address in https://github.com/github/licensed/issues/189.

aws-eventstream, has license from package manager apache-2.0
aws-partitions, has license from package manager apache-2.0
aws-sdk-core, has license from package manager apache-2.0
aws-sdk-kms, has license from package manager apache-2.0
aws-sdk-s3, has license from pacakge manager apache-2.0
aws-sigv4, has license from package manager apache-2.0
bundler, has license from package manager mit
libv8, has license from package manager mit
paper_trail, has license from package manager mit
rails-settings-cached, has no license as part of release package at version 0.6.5 - https://github.com/huacnlee/rails-settings-cached/tree/v0.6.5.  Upgrade to v2.0.0+ for license inclusion in package

"other" license classification
The list here shows each dependency that was classified as "other", which files licensed found for each dependency, and the resulting classification from licensee for each file.  In the case of other classifications for a file I also added a note on what I was able to tell on why a license wasn't detected
The majority of the failures here were due to deviations from an official license template for various reasons.  I think some of them might be actionable to fix in the license detection logic in licensee, but many are likely to continue to be painful.
It's getting a little late in my day, but I'll open an issue tomorrow over in licensee and link to this + the example repo and see if there are any thoughts on improvements.

activerecord

license - other.  nonstandard additions to mit template, additional copyright
readme - mit
gemspec - mit

awesome_print

license - other.  nonstandard additions to mit template from author contact info
readme - mit
gemspec - mit

bcrypt

license - other.  multiple assertions
gemspec - mit

climate_control

license - mit
readme - other.  does not reference license by title
gemspec - mit

concurrent-ruby

license - other.  license includes markdown code block markers (```) and link to license
gemspec - mit

css_parser

license - other.  nonstandard header
gemspec - mit

domain_name

license - other.  multiple licenses (BSD-3, BSD-2, MPL-2)
readme - other.  multiple licenses
gemspec - other.  multiple licenses

exception_notification

license file - other. looks like it's from inclusion of The MIT License (MIT) as part of the wordset because it's after the copyright notice
readme - other. looks like copyright matching negates the rest of the assertion here maybe, i.e. dependency.readme_file.content_normalized == ""
gemspec - mit

htmlentities

license - other. content above copyright line causes detection mismatch
gemspec - mit

jquery-ui-rails

license - other. non standard mit license content jQuery UI as well as this gem are licensed under the MIT license (see jquery-ui/MIT-LICENSE.txt).
gemspec - mit

method_source

license - other. preamble above license causes detection mismatch
readme - mit
gemspec - mit

mime-types

license: other. nonstandard formatting of header, title, copyright causes misdetection
gemspec: mit

mime-types-data

license: other.  nonstandard formatting of header, title, copyright causes misdetection
gemspec: mit

nokogiri

LICENSE.md - mit
LICENSE-DEPENDENCIES.md - other (multiple license assertions)
README - mit
gemspec - mit

paperclip

license - other.  misunderstood formatting of header LICENSE above The MIT License
readme - mit
gemspec - mit

pathname-common_prefix

readme - other.  ruby license for majority, gnu lgps for setup.rb

pg

license - other.  bsd-3 or ruby license
gemspec - bsd-3

puma

license - other. misunderstood formatting of header / copyright
readme - bsd-3
gemspec - bsd-3

rack

license - other.  missing OR COPYRIGHT HOLDERS from license text is the only difference I can see
gemspec - mit

rails-settings-cached

no license as part of release package at version 0.6.5 - https://github.com/huacnlee/rails-settings-cached/tree/v0.6.5.  Upgrade to v2.0.0 for license inclusion in package

rubyzip

readme - other. ruby license

terrapin

license - other. misunderstood header format
readme - other. doesn't reference the name of the license used
gemspec - mit

unf

license - bsd-2
readme - other. written as 2 clause bsd, where one of bsd 2-clause or bsd-2-clause was expected

websocket-driver

license - other.  uses short form apache-2.0 reference.  Should be detected?
gemspec - apache-2.0

websocket-extensions

license - other.  uses short form apache-2.0 reference.  Should be detected?
gemspec - apache-2.0

@jonabc thanks for improving Licensed! Hope it'll be getting better and better with detecting licenses.
Just wanted to clarify how I fixed the first category of gems. Here is what I filled in manually for the gems with sources:
No license contents
aws-eventstream, has license file
aws-partitions, has license file
aws-sdk-core, has license file
aws-sdk-kms, has license file
aws-sdk-s3, has license file
aws-sigv4, has license file
bundler, has license file
libv8, has license in README
paper_trail, has license file
rails-settings-cached, has license file
So all of them have license files actually.

@sergey-alekseev I agree with you that the remote repositories have license files and/or licenses in the readme, but those files aren't included in the distributed gem - you can check each gemspec spec.files property to see what is included.
The only special case here is bundler, which I've found to kind've do its own thing and may or may not be directly installed with ruby.  For example my local bundler installation doesn't have a README or LICENSE
➜  licensed-example git:(master) ✗ ls -l ~/.rbenv/versions/2.6.4/lib/ruby/gems/2.6.0/gems/bundler-1.17.2/
total 0
drwxr-xr-x  4 jonabc  staff  128 Oct  9 10:28 exe

➜  licensed-example git:(master) ✗ ls -l ~/.rbenv/versions/2.6.4/lib/ruby/2.6.0/bundler/
build_metadata.rb          deployment.rb              gem_helpers.rb             lockfile_generator.rb      ruby_dsl.rb                source.rb                  vendored_persistent.rb
capistrano.rb              deprecate.rb               gem_remote_fetcher.rb      lockfile_parser.rb         ruby_version.rb            source_list.rb             vendored_thor.rb
cli/                       dsl.rb                     gem_tasks.rb               match_platform.rb          rubygems_ext.rb            spec_set.rb                version.rb
cli.rb                     endpoint_specification.rb  gem_version_promoter.rb    mirror.rb                  rubygems_gem_installer.rb  ssl_certs/                 version_ranges.rb
compact_index_client/      env.rb                     gemdeps.rb                 plugin/                    rubygems_integration.rb    stub_specification.rb      vlad.rb
compact_index_client.rb    environment_preserver.rb   graph.rb                   plugin.rb                  runtime.rb                 templates/                 worker.rb
compatibility_guard.rb     errors.rb                  index.rb                   process_lock.rb            settings/                  ui/                        yaml_serializer.rb
constants.rb               feature_flag.rb            injector.rb                psyched_yaml.rb            settings.rb                ui.rb
current_ruby.rb            fetcher/                   inline.rb                  remote_specification.rb    setup.rb                   uri_credentials_filter.rb
definition.rb              fetcher.rb                 installer/                 resolver/                  shared_helpers.rb          vendor/
dep_proxy.rb               friendly_errors.rb         installer.rb               resolver.rb                similarity_detector.rb     vendored_fileutils.rb
dependency.rb              gem_helper.rb              lazy_specification.rb      retry.rb                   source/                    vendored_molinillo.rb

I've updated https://github.com/jonabc/licensed-example/ to include the full content after bundle install --path vendor/gems .  This is the "source of truth" that github/licensed uses to determine dependency data.
It's mostly complete but won't contain data on the ruby default gems like bundler and json

Makes sense, I haven't thought about it. So Licensed can't fetch those license files from local directories as they simply do not exist there. They can still be grabbed from repositories and filled in manually then when necessary.

@mlinksva @benbalter I've pared down https://github.com/jonabc/licensed-example/tree/master/vendor/gems/ruby/2.6.0/gems to only include the dependencies in the audit above.
I'm not expecting anything to be actionable for dependencies on the no license contents list, but for the others it's not immediately clear which cases should be detected or not.  If anyone gets a chance could you take a look and see if there is anything in there you'd expect that licensee would already detect, or would be reasonable to detect with additional work?
🙇


not supported resolving ES modules import

Hi guys. great library you made, was looking for something like this for years.
I have a problem when running a nuxt project (with vite) with this library in docker alpine.
i get the error: [worker reload] [worker init] Directory import '/app/node_modules/sutando/src' is not supported resolving ES modules imported from /app/node_modules/sutando/sutando.mjs
Using the newest sutando version.
The same code works if i dont use with docker, even with the same nodejs version (20 or 21, no difference)
My dockerfile looks like this:
# syntax=docker/dockerfile:experimental
FROM php:8.3-fpm-alpine
RUN apk add --update nodejs npm
WORKDIR /app

In sutando.mjs:
Changing
import Sutando from './src/';
to
import Sutando from './src/index.js';
fixed the issue.
But i thought i would open an issue so you can fix this in the library


Omnisharp VS Code Issue 1814 Fix

https://github.com/OmniSharp/omnisharp-vscode/issues/1814
The issue was arising because there was no code to handle the AttributeSyntax type node(which is the case for the Attribute Constructors). But there was a difference between the type of arguments being used by the InvocationExpressionSyntax class and the AttributeSyntax class.Hence instead of keeping the entire Arguments object, we pulled out the relevant properties at the initial stage itself, and a change was made to the InvocationContext class accordingly. A test case has also been added to verify the behavior.
Please review @rchande @TheRealPiotrP @DustinCampbell .

@akshita31 : Your last commit didn't compile (you didn't replace references to i with semanticModel).

This is looking much better! Just a couple more tiny nits from me and that package-lock.json file looks like it was included unintentionally.

@TheRealPiotrP : Have your requested changes been addressed?