Self sign up/ account unlock - provide the missing information in the doc

Document: https://docs.wso2.com/display/IS550/Account+Locking+by+Failed+Login+Attempts
Specify the following scenario in the doc.

Navigate to the dashboard and self-signup a user.
verify if the user is added to user list in the management console. Follow the configs in doc [1].
Now try 5 invalid login attempts. The account will get locked for 5 minutes.

But after 5 minutes account does not automatically gets unlocked. The user has to log in with the correct credentials and then it will be get unlocked. The account lock checkbox in the user profile gets unticked/false after user logins. Better if we can mention this in the doc.
[1] - https://docs.wso2.com/display/IS550/Self+Sign+Up+and+Account+Confirmation#SelfSignUpandAccountConfirmation-Tryoutselfsignup
Type/Improvement
Affected/5.5.0-Alpha
Severity/Minor
Priority/Normal

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Changed License...

You've licensed your code MIT, but the code you based it on is Licensed Apache.
(Apache is more restrictive).
In general you cannot release code under a less restrictive license than it was initially released.

Now changed to Apache license v2.
Thanks for pointing out the potential issue.

Additionally I've contacted MongoDB and asked they change the license for this code and the ninja file generation code to MIT.
They're working through their internal processes to see if they are able.

That will be great. I will change back to simpler MIT license once MongoDB hopefully changes.

Once the license changes we'll likely look at integrating mongoDB's and your code (if you're o.k with that) code into SCons core.

Sounds good and I am more than happy if the code can be somehow put into SCons core.


_integrate_forces / KinematicCollision3D bug

Godot version
4.2 rc 6 and newer
System information
windows 10
Issue description
I've attached a minimum reproduction project.
The KinematicCollision3D seems to not work the same after 4.2 rc 5.. In rc 6 and newer version it is broken.
rc5:

rc6:

Steps to reproduce
Run example project in rc5 or older, compare to rc6 and newer.
Minimal reproduction project
RigidBody Character Bug.zip

I narrowed the issue down to this recent change that causes the issue:
https://github.com/godotengine/godot/commit/a3278c772eccedd035d2880cc33a11cab00fd0fc
When I revert that change, it works fine.

CC @mihe

Yeah, I've spoken to @prominentdetail offline already. I'm looking at it.
(Also, the mentions of "rc5" and "rc6" are meant to say "beta5" and "beta6" respectively.)

@mihe
I'm not sure- maybe I am not referencing the right commit, but when I commented out these lines from the latest version, it works:

void RigidBody3D::_body_state_changed(PhysicsDirectBodyState3D *p_state) {
	lock_callback();

	if (GDVIRTUAL_IS_OVERRIDDEN(_integrate_forces)) {
		_sync_body_state(p_state);

		//Transform3D old_transform = get_global_transform();
		GDVIRTUAL_CALL(_integrate_forces, p_state);
		//Transform3D new_transform = get_global_transform();

		/*if (new_transform != old_transform) {
			// Update the physics server with the new transform, to prevent it from being overwritten at the sync below.
			PhysicsServer3D::get_singleton()->body_set_state(get_rid(), PhysicsServer3D::BODY_STATE_TRANSFORM, new_transform);
		}*/
	}

	_sync_body_state(p_state);
	_on_transform_changed();

	if (contact_monitor) {
		contact_monitor->locked = true;

Ah, right. Removing the code is different from a revert. Then you effectively end up reverting #84799 in this case, and not #84924 (aka a3278c772eccedd035d2880cc33a11cab00fd0fc).

Just to give a minor update here: I've come to understand what the problem is here, and it breaks down to something quite fundamental about the intended purpose of _integrate_forces.
I've been noodling over this for a few days now, trying to think of how to best fix this, but I think I'll just end up submitting multiple PRs and start some kind of discussion about which might be the best approach.
As far as your specific problem is concerned, @prominentdetail, by commenting out that code you showed above you are effectively turning your "body will sink into floor when landing" workaround into a no-op, since any transform changes you make in _integrate_forces will be overwritten in that _sync_body_state below. So if commenting out that code works for you in your actual project, then you might as well just remove that workaround altogether, which should let you use Godot 4.2-stable as-is.
I also get the feeling that your workaround maybe wasn't doing what you hoped it would, as you (prior to 4.2-beta6) would end up setting the linear velocity for this physics step, but you'd actually set the transform on the next physics step, which is why your character falls down in that repro in 4.1.3-stable when it rightfully should stop dead as soon as it touches the ground. You can achieve the proper effect (before 4.2-beta6) by changing state.transform instead of transform.

@mihe , thanks- I can confirm that 4.2stable as-is works if I just remove the workaround in my main project. I think I remember that the workaround didn't really solve the issue entirely anyway. That is interesting to know about the difference between state.transform and transform. Is that still the case with 4.2? So if I understand- state.transform will change the current step whereas transform will change the next step?

Is that still the case with 4.2? So if I understand- state.transform will change the current step whereas transform will change the next step?

Yes and no. This is what unfortunately changed/broke in 4.2-stable, and which requires further discussion on how to fix properly.
The physics engine in Godot is always one step ahead of the idle tick (and the rendering), and prior to #79977 the state parameter in _integrate_forces essentially served as the input for this next physics frame, without affecting the current physics frame. But now since #79977 we are pulling that state input back into the current physics frame and essentially mixing the two physics frames together, causing these weird problems.
So reverting #79977 and everything that followed from that is one solution to all this, but it re-introduces other weird and unintuitive behaviors, hence why some bigger discussion needs to be had.
I'll try to have it written up properly within the next couple of days.


Benchmarks seem broken

Issue description
The benchmarks page does not seem to display any data for most graphs.
I get "no data available" for all except of "Unary secure throughput QPS (32 core client to 32 core server)" and "Streaming secure throughput QPS (32 core client to 32 core server)" and those are missing the Java data.
Steps to reproduce the issue

Go to https://www.grpc.io/docs/guides/benchmarking/#overview
Go to https://performance-dot-grpc-testing.appspot.com/explore?dashboard=5636470266134528 (aka multi-language performance dashboard)

Expected behavior
There should be benchmark data displayed.
Screenshots

Desktop (if relevant):

OS: Windows 10
Browser: Chrome

FYI: also reported by https://github.com/grpc/grpc.io/issues/337. I've added a note to the benchmarking page (https://github.com/grpc/grpc.io/pull/339).

Hopefully we will be able to revive the dashboard in Q4 2020. We don't plan to performance data snapshot as:

we'd like to focus on a long-term fix (= improve the underlying benchmarking framework) rather than manually generating performance data.
if you need to you can generate the data yourself by using run_performance_tests.py script (https://github.com/grpc/grpc/tree/master/tools/run_tests#performance-benchmarks-run_performance_testspy).
The data we publish in the dashboard are mostly informative - if you are building a performance-sensitive app, you'll need run app-specific benchmarks yourself anyway.

Is it because the default SQL only retrieve data from the pass 2 weeks? Try editing the SQL code to target the data to retrieve desired data.

@kitcheung1480 Thanks for sharing. Somehow my tried your SQL query but it doesn't work out..

@jtattermusch I was wondering if we are getting closer to resolve this issue.

for your reference here:
SELECT
summary.latency50 / 1000 as value,
DATE_ADD(metadata.created, -8, "HOUR") as date,
scenario.name as scenario
FROM
[grpc-testing:performance_released.performance_experiment]
WHERE
metadata.created >= DATE_ADD(CURRENT_TIMESTAMP(), -13, "WEEK") AND
(scenario.name = "java_protobuf_unary_ping_pong_secure" OR
scenario.name = "ruby_protobuf_unary_ping_pong" OR
scenario.name = "node_protobuf_unary_ping_pong" OR
scenario.name = "csharp_protobuf_sync_to_async_unary_ping_pong" OR
scenario.name = "cpp_protobuf_sync_unary_ping_pong_secure" OR
scenario.name = "go_protobuf_sync_unary_ping_pong_secure" OR
(scenario.name = "python_protobuf_sync_unary_ping_pong") OR
scenario.name = "netperf_tcp_rr")
ORDER BY
date;

Thanks, @kitcheung1480  Here is the screenshot from my side. I adjusted the number of weeks, from -13, to -50, -100. No luck so far

We are still working on a new framework to run the OSS benchmarks (in a more stable a maintainable way).
Hopefully we'll have the dashboard populated by the new benchmarks in Q1 2021.
This is the repository to track https://github.com/grpc/test-infra/tree/master/benchmarks

Thanks, @kitcheung1480  Here is the screenshot from my side. I adjusted the number of weeks, from -13, to -50, -100. No luck so far

Have you press refresh afterwards?

Thank you!


Bind operator question

Background
I am trying this library and in specific I am trying the Result Monad. The documentation mentions a function called Result.bind and I have made it work with the following code snippet:
defmodule TestMonadex do
  use Monad.Operators

  import Monad.Result

  def p1(x) do
    x
    |> success()
    |> bind(&plus_1/1)
  end

  defp plus_1(n), do: n + 1
end

And so far so good.
Problem
The problem arises when I try to use the bind operator. According to the docs, this operator is the same thing as the Result.bind function. Following this logic, the following code snippet should work:
defmodule TestMonadex do
  use Monad.Operators

  import Monad.Result

  def p2(x) do
    success(x) ->> (&plus_1/1) # This does not compile!
  end

  defp plus_1(n), do: n + 1
end

Unfortunately, this is not compiling:
(SyntaxError) syntax error before: '>'

Stacktrace:
  │ (elixir 1.11.2) lib/kernel/parallel_compiler.ex:314: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/7

an expression is always required on the right side of ->. Please provide a value after ->

At this point I strongly believe I am not understanding something from the docs or from the library.
Question
What a I doing wrong?

The operator you're looking for is ~>>. It's a tilde instead of a hyphen. Otherwise it's ambiguous with the -> operator.

So the documentation is incorrect:

Or is it displayed differently in your browser?

After a closer look I have realized that my browser's zoom level, together with my font  made the docs harder to read. Everything is correct.
Thank you for answer and I apologize for taking your time. Closing ticket.


Fleet - GitRepo bundleDirs should now be paths in the Create GitRepo UI and generated YAML

Rancher version master-head (09/16/2020) _ 59936f7_
bundleDirs was changed to paths in the latest fleet alpha9 fleet-agent:v0.3.0-alpha9.

Generated YAML:
apiVersion: fleet.cattle.io/v1alpha1
kind: GitRepo
metadata:
  creationTimestamp: "2020-09-16T19:53:59Z"
  generation: 1
  managedFields:
  - apiVersion: fleet.cattle.io/v1alpha1
    fieldsType: FieldsV1
    fieldsV1:
      f:spec:
        .: {}
        f:branch: {}
        f:repo: {}
    manager: rancher
    operation: Update
    time: "2020-09-16T19:53:59Z"
  - apiVersion: fleet.cattle.io/v1alpha1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        .: {}
        f:commit: {}
        f:conditions: {}
        f:display:
          .: {}
          f:readyBundleDeployments: {}
        f:observedGeneration: {}
        f:summary:
          .: {}
          f:desiredReady: {}
          f:ready: {}
    manager: fleetcontroller
    operation: Update
    time: "2020-09-16T19:54:12Z"
  name: test
  namespace: fleet-default
  resourceVersion: "19287"
  selfLink: /apis/fleet.cattle.io/v1alpha1/namespaces/fleet-default/gitrepos/test
  uid: c309776b-18c4-4872-b016-a8c99b126aa8
spec:
  branch: master
  bundleDirs:
  - test1
  clientSecretName: null
  repo: https://github.com/rancher/fleet-examples
status:
  commit: 541764c8c332f2b9a1262b8ef0d9fdc557d01159
  conditions:
  - lastUpdateTime: "2020-09-16T19:54:12Z"
    status: "True"
    type: Ready
  - lastUpdateTime: "2020-09-16T19:54:00Z"
    status: "False"
    type: Reconciling
  - lastUpdateTime: "2020-09-16T19:54:00Z"
    status: "False"
    type: Stalled
  - lastUpdateTime: "2020-09-16T19:54:00Z"
    status: "True"
    type: Synced
  - lastUpdateTime: "2020-09-16T19:54:12Z"
    status: "True"
    type: Accepted
  display:
    readyBundleDeployments: 0/0
  observedGeneration: 1
  summary:
    desiredReady: 0
    ready: 0
type: fleet.cattle.io.gitrepo

Rancher version: master-head (09/23/2020) e9a98a3
Validated the spec is now generated using paths instead of bundleDirs but found #1370 in the process.


Add update permissions to deployments/finalizers for galley clusterrole

This PR addresses the situation described in https://github.com/istio/istio/issues/10311
After adding those permissions, Galley does not complain anymore about lack of them. If you don't allow them, then Galley is just not responding to any validation request.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xeviknal
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/kubernetes/helm/subcharts/galley/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @xeviknal. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/lgtm

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xeviknal, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/kubernetes/helm/subcharts/galley/OWNERS [ymesika]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xeviknal: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3e3d4289d146ede492aff231fb2245e25cc57f98
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xeviknal: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3e3d4289d146ede492aff231fb2245e25cc57f98
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xeviknal: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3e3d4289d146ede492aff231fb2245e25cc57f98
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
3e3d4289d146ede492aff231fb2245e25cc57f98
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ymesika is that alright that the PR is in but there is one test suite not passing? (Don't want to introduce a bug somewhere)


[youtube:user] make user/c regex a separate info IE

Just out of curiosity... can we make the recent user/c patch a separate IE?  (Or any objection if I created a pull request to do this?).  I noticed a build breakage after this.
https://github.com/rg3/youtube-dl/commit/9558dcec9c7806c811f4fe8e7758977eaa01a702
I have some code that's been leveraging the 1:1 relation between an IE and its _VALID_URL _TEMPLATE_URL to create some quick and dirty automated scrapers for a bunch of IE's.  Best part of this is that when you do this, the "unique identity" of a video can be determined while offline for a lot of IE's, and you can reverse the "unique identity" back to a usable url when traversing.
Here's the project and the way we're using these for your consideration:
https://github.com/yuri-sevatz/youtube-sync/blob/master/youtube_sync/__init__.py#L420
I know I should have tried to merge some of this logic to youtube-dl a while ago, but I've been too lazy and shy :)

I suppose alternatively I can make the "unique identity" of a video take an array of arguments (json, etc), but this is not ABI-maintainable between youtube-dl upgrades, unless we start to version them.

In 3rd party code you should neither rely on _VALID_URL nor on _TEMPLATE_URL. As well as you should not make any assumptions about particular extractor implementation details. I don't see much sense to apply such changes just in order to make some 3rd party code relying on that work since some another code may require the opposite.

So I understand the argument and I agree if we don't go into any detail about what these could do.
What I'm saying here is that "some 3rd party code" happens to handle the notion of video identity a little better than youtube-dl, gets Google accounts banned far less often than youtube-dl, and can perform analysis of what a playlist (or any source for the matter) has and doesn't have offline, and can cross-reference any updates with what you want -- without re-running the IE's and harassing the remote servers for everything else that you already have.
Because that's what gets account banned!
... and it does this better than youtube-dl, using mostly the information you already have inside your IE's.  If the only thing you logically need API-wise is the capacity to make video identity both be:

Extracted from an IE.
Re-Inserted into an IE

-- Then why not aim for it because it's easily low-hanging fruit from what you've already got in IE definitions?
I can do it myself, I really just wanted to see what you guys thought.

Even if you don't want to go into any detail on this, there's simple reason why this looks like a contradiction to me:

   # Only available via https://www.youtube.com/c/12minuteathlete/videos

   # but not https://www.youtube.com/user/12minuteathlete/videos

   'url': 'https://www.youtube.com/c/12minuteathlete/videos',

   'playlist_mincount': 249,

   'info_dict': {

       'id': 'UUVjM-zV6_opMDx7WYxnjZiQ',

       'title': 'Uploads from 12 Minute Athlete',

   }

}, {

So, by this logic, a www.youtube.com/channel/* could very well go into the YoutubeUserIE too -- even though the set of videos it returns is mutually exclusive to both www.youtube.com/user/* and www.youtube.com/c/*.    What is the meaning of the YoutubeUserIE?  What is the meaning of the YoutubeChannelIE?
If they're just talking about vague concepts that happen to be convenient to the maintainers of the regexes, and that they mean nothing to userspace, then why even have them exposed to userspace at all?  Why does the user-level api even have different IE's, if there's no distinguishing between the things they're allowed to refer to?

In the example they give:
c/12minuteathlete and user/12minuteathlete are not interchangeable, therefore it begs the question why are they in the same IE?
The underlying user seems to be user/the12minuteathlete when I click on the main channel, so whatever c/12minuteathlete is, it's certainly not a user!


[Q] How to set target and planned things?

I see various sensors which seem to allow planned and delayed charging. How can these be set?

Energy target
planned current
Time until planned current is set

Is there somewhere an input like for charging current?

Hi @PulsarFX
sorry for my late respone. Check the services section under the developer menu.


[FEAT] Use new logo

WIP
If we decided to keep the logo, the svg files must be reviewed

style of the small red circle inside the large circle: keep in white or make transparent?
remove comments
simplify styles?
inline

Nice work 👍🏼
I think it would be better to make transparent the small red circle inside the large circle.


Sync eng/common directory with azure-sdk-tools for PR 1946

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1946  See eng/common workflow

/check-enforcer reset


Radiolist doesn't support boolean as model

Hi.
When editable-radiolist has bind a boolean variable It doesn't reflect the correct value the first time is editing. JSFiddle
Regards.
Update
Please close, the issue was fixed on new versions

Your fiddle is using the wrong angular-xeditable version.  Please see this fiddle


Update ci-fix.md: link to LintDiff rules.md + make the ruleset more discoverable

This PR doesn't update any API specs; instead, it updates API spec validation tooling rule violation troubleshooting guidance at https://aka.ms/ci-fix
I am owner of the tool for which I updated the guidance. (LintDiff / https://github.com/Azure/azure-openapi-validator)

Closing his PR as I erroneously edited the file in master instead of main.


Change required role to add/update application from Admin to Editor

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Change required role to add/update application from Admin to Editor

Way to go 🚀
/lgtm

Okay, editors will get allowed to operate to applications. I'd say they are appropriate roles.
OTOH, it's obviously a fatal breaking change. From now on, all editors get a great responsibility. We must add notes on the next changelog (ideally, it should be applied gradually, but well okay as it's still on the alpha stage)

/approve

Right. This will be noted as a breaking change. 👍


[docs] Add a few more things to the Lexicon.

"AST", "bitcode", "IR", and the suspected etymology of "QoI".
"PRs" welcome for additional contributions to the Lexicon. :-)

@swift-ci Please smoke test and merge

Rather, in the commit messages to them.


debug startup issues: Some problems occurred during startup

➜  jobset git:(main) ✗ kubectl apply --server-side -k  /Users/zhenyu.jiang/go/src/golanglearning/new_project/jobset/config/default
namespace/jobset-system serverside-applied
customresourcedefinition.apiextensions.k8s.io/jobsets.jobset.x-k8s.io serverside-applied
serviceaccount/jobset-controller-manager serverside-applied
role.rbac.authorization.k8s.io/jobset-leader-election-role serverside-applied
clusterrole.rbac.authorization.k8s.io/jobset-manager-role serverside-applied
clusterrole.rbac.authorization.k8s.io/jobset-metrics-reader serverside-applied
clusterrole.rbac.authorization.k8s.io/jobset-proxy-role serverside-applied
rolebinding.rbac.authorization.k8s.io/jobset-leader-election-rolebinding serverside-applied
clusterrolebinding.rbac.authorization.k8s.io/jobset-manager-rolebinding serverside-applied
clusterrolebinding.rbac.authorization.k8s.io/jobset-proxy-rolebinding serverside-applied
secret/jobset-jobset-webhook-server-cert serverside-applied
service/jobset-controller-manager-metrics-service serverside-applied
service/jobset-webhook-service serverside-applied
deployment.apps/jobset-controller-manager serverside-applied
mutatingwebhookconfiguration.admissionregistration.k8s.io/jobset-mutating-webhook-configuration serverside-applied
validatingwebhookconfiguration.admissionregistration.k8s.io/jobset-validating-webhook-configuration serverside-applied

When I use go run main.go, the service starts normally.
➜  jobset git:(main) ✗ go run main.go
2024-02-17T13:03:26+08:00       INFO    setup   both healthz and readyz check are finished and configured
2024-02-17T13:03:26+08:00       INFO    setup   starting manager
2024-02-17T13:03:26+08:00       INFO    setup   waiting for the cert generation to complete
2024-02-17T13:03:26+08:00       INFO    starting server {"kind": "health probe", "addr": "[::]:8081"}
2024-02-17T13:03:26+08:00       INFO    controller-runtime.metrics      Starting metrics server
2024-02-17T13:03:26+08:00       INFO    controller-runtime.metrics      Serving metrics server  {"bindAddress": ":8080", "secure": false}
2024-02-17T13:03:26+08:00       INFO    cert-rotation   starting cert rotator controller
2024-02-17T13:03:26+08:00       INFO    Starting EventSource    {"controller": "cert-rotator", "source": "kind source: *v1.Secret"}
2024-02-17T13:03:26+08:00       INFO    Starting EventSource    {"controller": "cert-rotator", "source": "kind source: *unstructured.Unstructured"}
2024-02-17T13:03:26+08:00       INFO    Starting EventSource    {"controller": "cert-rotator", "source": "kind source: *unstructured.Unstructured"}
2024-02-17T13:03:26+08:00       INFO    Starting Controller     {"controller": "cert-rotator"}
2024-02-17T13:03:26+08:00       INFO    cert-rotation   no cert refresh needed
2024-02-17T13:03:26+08:00       INFO    Starting workers        {"controller": "cert-rotator", "worker count": 1}
2024-02-17T13:03:26+08:00       INFO    cert-rotation   no cert refresh needed
2024-02-17T13:03:26+08:00       INFO    cert-rotation   Ensuring CA cert        {"name": "jobset-validating-webhook-configuration", "gvk": "admissionregistration.k8s.io/v1, Kind=ValidatingWebhookConfiguration", "name": "jobset-validating-webhook-configuration", "gvk": "admissionregistration.k8s.io/v1, Kind=ValidatingWebhookConfiguration"}
2024-02-17T13:03:26+08:00       INFO    cert-rotation   Ensuring CA cert        {"name": "jobset-mutating-webhook-configuration", "gvk": "admissionregistration.k8s.io/v1, Kind=MutatingWebhookConfiguration", "name": "jobset-mutating-webhook-configuration", "gvk": "admissionregistration.k8s.io/v1, Kind=MutatingWebhookConfiguration"}

When I create an example, the error that occurs with the webhook is as follows.
➜  jobset git:(main) ✗ kubectl apply -f examples/simple/max-restarts.yaml
Error from server (InternalError): error when creating "examples/simple/max-restarts.yaml": Internal error occurred: failed calling webhook "mjobset.kb.io": failed to call webhook: Post "https://jobset-webhook-service.jobset-system.svc:443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: connection refused

Is there anything I should have done less?

Maybe the deployment had some issues.
https://github.com/kubernetes-sigs/jobset/blob/main/docs/faq/README.md#1-webhook-not-available-error-when-attempting-to-create-a-jobset

thanks a lot!

Sorry to ask a basic question. I want to use program debugging, but I find that there are always webhook related errors. I would like to ask how you debug your own programs, such as goland.
I use minikube for testing. But this error occurs when I use.
➜  jobset git:(main) ✗ kubectl apply -f examples/simple/max-restarts.yaml
Error from server (InternalError): error when creating "examples/simple/max-restarts.yaml": Internal error occurred: failed calling webhook "mjobset.kb.io": failed to call webhook: Post "https://jobset-webhook-service.jobset-system.svc:443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: connection refused

apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
  name: jobset-mutating-webhook-configuration
webhooks:
  - admissionReviewVersions:
      - v1
    clientConfig:
      url: "https://<IP_ADDRESS>:9443/mutate-jobset-x-k8s-io-v1alpha2-jobset"
#      service:
#        name: jobset-webhook-service
#        namespace: jobset-system
#        path: /mutate-jobset-x-k8s-io-v1alpha2-jobset

➜  jobset git:(main) ✗ kubectl apply -f examples/simple/paralleljobs.yaml
Error from server (InternalError): error when creating "examples/simple/paralleljobs.yaml": Internal error occurred: failed calling webhook "mjobset.kb.io": failed to call webhook: Post "https://<IP_ADDRESS>:9443/mutate-jobset-x-k8s-io-v1alpha2-jobset?timeout=10s": dial tcp <IP_ADDRESS>:9443: connect: connection refused

I found that when I started the program, I could not access port 9443 using <IP_ADDRESS>
➜  ~ curl --location 'https://<IP_ADDRESS>:9443/mutate-jobset-x-k8s-io-v1alpha2-jobset'
curl: (7) Failed to connect to <IP_ADDRESS> port 9443 after 6 ms: Connection refused

The JobSet controller manager deployment resource requirements are 2CPU and 512Mi of memory. If your minikube instance does not have at least that much (plus enough for kube-system pods), the JobSet controller manager pod will not be scheduled and you will see this error.
As explained in the troubleshooting guide, you need to describe the jobset controller manager pod and determine why it is not being scheduled. https://github.com/kubernetes-sigs/jobset/blob/main/docs/faq/README.md#1-webhook-not-available-error-when-attempting-to-create-a-jobset


Exit with an error if minikube fails to start

It doesn't make sense to continue the test if the
k8s cluster is not available.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jwendell
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @jwendell. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @ldemailly

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jwendell, ldemailly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@jwendell: you can't request testing unless you are a istio member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test istio-pilot-e2e

/retest

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
e70fbc0c9976f5b5519da1b5d26b15e125f3778f
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

If you already ran those tests and they fail again try rebasing because sometime there are tests fixes up the stream.

@rshriram why did you close this? This is a trivial patch that doesn't hurt to get it in... Those test failures certainly were not this PR's fault...


Fixed search to trim search term. Fixes #215

Changed ListPackages to trim the query string search parameter before
conducting a search on it.

I merged it.


switch to yaml

#114

haven't added new apps yet.  Threw in the addToTable script for switching between yaml/data frame


Composer and travis fixes

run tests on php 7.1
use actual package of friendsofphp/php-cs-fixer
update dependencies
run phpunit from vendor instead of system on travis

It's impossible to run tests on php 7.2 because phpunit has deprecation which was fixed in this commit. But this versions don't support php versions <5.6

Thanks! 👍


Store presets in db

iD Editor uses JSON presets to define a UI for categories of features to map, which symbol to use, and which fields to show, and how these map to tag key-value pairs.
We currently maintain these as a separate repo and build them into a single JSON that iD can use with id-presets-builder and import that into Mapeo by bundling the presets and the translations file with mapeo-settings-builder and then manually importing this file https://github.com/digidem/mapeo-desktop/blob/master/browser/main.js#L70-L84 and https://github.com/digidem/mapeo-desktop/blob/master/lib/user-config.js#L49-L62
We should store these presets in the DB and sync them. In the future users should be able to update presets themselves, but I think we need for an admin override. Dealing with forks of presets starts to get really complicated for the user to understand, so I think we should have a fork/conflict resolution method for this.

In the future users should be able to update presets themselves, but I think we need for an admin override.

Can you elaborate on this? I could read this as meaning, local edits are doable by anyone, but if an admin pushes out a new version of the presets.. it overwrite any changes they made? Curious what you were thinking (y'know, 5 years ago :P).

Ha! Yes, that was a long time ago! I'm thinking that changing presets should be restricted to an "admin" group, but it will likely need to be more than a single person, so that does introduce the possibility of conflicts (two admins edit the presets). We still need to figure out how to determine an "admin" in a de-centralised system. For something like this I think it would be enough to enforce the "admin" role at the front-end, e.g. anyone who is part of the project with raw access to the Mapeo Core API could theoretically edit a preset, but the UI only allows admins to do that. Similar to the way we restrict editing on mobile to observations you create - there is nothing in the backend stopping that.

I've been thinking about how to implement any kind of admin / role in our db. One thought I had was that each device could just ignore any hypercore entries from devices that it does not consider an "admin".

Similar to the way we restrict editing on mobile to observations you create - there is nothing in the backend stopping that.

I agree that starting here is simplest. The new invite flow for OTF incorporated an isAdmin bit I think, which could be stored locally on disk.

I've been thinking about how to implement any kind of admin / role in our db. One thought I had was that each device could just ignore any hypercore entries from devices that it does not consider an "admin".

Yeah. And then there's the Q of how to set who is an admin. I think materialized-group-auth captures this logic well.


Exceptions handlers

Feature request/ Enhancement.
Add custom exceptions handlers to an application.
You can register an exception type with an handler,
The handler receives the request and exception when the exception type is raised, and converts the exceptions into a response.
Thanks!

You may do it via middleware right now.

Thanks


is't possible to substitute the embedding instance segmentation with mask-rcnn

Hi, Dear authors,
I'm reading and trying to recover this excellent work. For the segmentation branch, based on my previous limited understanding, embedding style segmentation might be less accurate that the mask-rcnn ones. And also the kmeans cluster step is less computing efficient on GPUs for both training and inference. Thus, I wonder does the framework work if replacing the embedding instance segmentation branch with mask-rcnn?

Yes, there are two main approaches to instance segmentation: proposal-based (e.g., Mask RCNN) and proposal-free (e.g., embedding-based). There is a trade-off between segmentation accuracy and speed. The speed is also an important aspect in real-time applications. Further, we use mean-shift instead of k-means clustering.
If you try to work on detection-based method, you can refer to the concurrent work PlaneRCNN.
Best,
Jia

Hi, @bertjiazheng  Thanks for the comment.
My final purpose is to deploy the planar sementation on smart cellphones. I ever looked into the PlaneRCNN repo, the code seemed to be more complex that this one. I prefer this repo as the framework is clean and simple. The trouble for me is the mean shift part for its risking of long exection time on ARM cpus. Thus, I'm considering to replace the embedding style segmentation to proposal one (ARM computing library seems to provide the support of Mask RCNN or NMS already).
Whatever, with no respect to deployment on specific platforms currently, do you think it's promising to obtain the same accuracy (or even better) if substituting embedding segmentation with region proposal one?

We do not have a quantitive comparison with PlaneRCNN since the data is slightly different. But in semantic instance segmentation, the proposal-free fail to perform as well as detection-based methods like Mask RCNN.

@bertjiazheng   Very thanks for the opinion.


v6.7.4 Installation Instructions - The best way now is?

I have exactly the same probleme. thanks to you

See https://github.com/foundation/foundation-sites/discussions/12317


Trying to run the conda environment on the cluster (PBS Pro)

Hello!
Thanks for making the tutorials available!
I'm trying to make a pipeline in python that will make use of MGL Tools as part of the process.
I'm trying to:
(A) Model mutations in a protein
(B) Energy minimize the protein
(A and B in schrodinger).
(C) Prepare the protein in MGL Tools (to add gasteiger charges)
(D) Dock ligands to the mutated proteins using Autodock Vina.
So far, I've managed (A) and (B).
But for C, I'm trying to use the code you have from this tutorial, where you install the conda package of MGLTools in your conda envrionment.
I was able to do that.
However, when I try to run a job on the cluster (PBS Pro), I'm not able to access my conda environment that I created.
Therefore, I can't run the python scripts from MGL Tools.
Any thoughts/ advice?
Regards
Jeremy Burgess

I am not sure if you need to put the whole path for conda to activate the docking module, you might just need to indicate
conda activate open_docking_env
As your module loader is loading the conda module potentially in your path


1.20.1 fixes

ported to 1.20.1
removed your stuff in the gradles for private testing

Do you still actively use Oro-Config? I havent updated this mod in ages since I no longer use it and there are better options for config.

well, i was looking for a platform independent light weight config, since im working on a architectury mod.
i ended up including oroconfig manually at the moment https://github.com/Truly-Modular/Modular-Item-API/tree/main/common/src/main/java/smartin/miapi/config/oro_config
i didnt want to have more external dependencies, thats why i choose oro config

while im not 100% sure, i think https://github.com/Fuzss/forgeconfigapiport is a better option. especially since this mod is not as lightweight as i once thought it to be.

well, yes, but forgeconfigapiport would be a external dependency, and i wanted to avoid those for the time being.
and wdym this sint as lightweight as you thought?

like i said, i wanted something that works on fabric and forge, server and client, and does not require users to download a seperate jar

Makes sense. Ill merge this but i wont publish to maven central as the system i made for it broke. You can use jitpack to build it or do something locally


How to print out every key pair in a .Set?

Could you clarify what you're trying to do? .Set corresponds to the empty set in K, and there are no keys for a set.

Sorry. I made a mistake here. I mean .Map.
Best regards,
Yi Huang
On 2017年5月1日 -0500 PM9:17, ehildenb<EMAIL_ADDRESS>wrote:

Could you clarify what you're trying to do? .Set corresponds to the empty set in K, and there are no keys for a set.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

.Map is the empty map, so it has no keys. If M is a variable of sort Map you can call keys(M) to get the Set of keys of the map.


Update topology.py

This is deliberate: it is more information to print the str representation of what was passed rather than just print its type. The purpose of any error message is to be maximally informative about what just happened.


added rag

Looks good but seems like a specific implementation. This is what I am looking for:

Vectorizer base class, has all the not model/lib specific stuff, leaving run_model function not implemented
VectorStore base class, has ingest_docs, get_k, put functions.
Then the llm class has a self.rag that uses the above functions to retrieve stuff, and pass it to the llm

Then using the above base classes implement a langchain-faiss rag.

Switched to #17


Compile darwin Flutter frameworks with minimum deployment version flags

iOS 8.0 was broken in https://github.com/flutter/flutter/issues/64017 even though it's the documented minimum version supported by the engine.
https://flutter.dev/docs/deployment/ios#review-xcode-project-settings

Flutter supports iOS 8.0 and later.

This may have been detected if the respective iOS/macOS/simulators were compiled with:
-miphoneos-version-min=8.0
-miphoneos-version-min=8.0
-mmacosx-version-min=10.11
https://chromium.googlesource.com/chromium/src/build/config/+/refs/heads/master/ios/BUILD.gn#118
Use these flags so this accidental deprecation doesn't happen again.

gn has something like this in their example app:
https://gn.googlesource.com/gn/+/refs/heads/master/examples/ios/build/config/ios/deployment_target.gni

I can't figure out where it's being set up, but the flag already seems to be set?
[1/97] ../../buildtools/mac-x64/clang/bin/clang++ -MD -MF obj/flutter/shell/gpu/gpu_surface_metal.gpu_surface_metal.o.d ... -miphoneos-version-min=8.0  ...  -c ../../flutter/shell/gpu/gpu_surface_metal.mm -o obj/flutter/shell/gpu/gpu_surface_metal.gpu_surface_metal.o

Same with -mmacosx-version-min for the host.
And that flag wouldn't have prevented #64017, it just seems to do availability-type checks.
@chinmaygarde @dnfield @jason-simmons do you guys know where it's being set to 8.0?

https://github.com/flutter/buildroot/blob/a5d7e3e9b3bb79e92ab89ebacd3779d3ef346753/build/config/ios/ios_sdk.gni#L17

Thanks, @dnfield.  Closing.


Dockerfile expose statement

Home Assistant release with the issue:

0.73.2
Operating environment (Hass.io/Docker/Windows/etc.):

Docker
Description of problem:
Im using Homeassistant together with https://github.com/jwilder/nginx-proxy/ and letsencrypt.
I did have quite some trouble finding out, why the generated nginx proxy config was not working.
I managed to resolve the problem by creating an image based on yours with an EXOPOSE 8123 statement added. So i was wondering if there is a reason you do not include the expose statement in your Dockerfile?

Hello @zn4ke.
Port is configurable. It can be changed in  your configuration.yaml.
So it depends on user which port he would like to use.

I suspect most users are calling docker with -p 8123:8123, which implicitly EXPOSEs the port.
It looks like at one point, there was an EXPOSE line, but @balloob removed it in https://github.com/home-assistant/home-assistant/commit/ed1f434a61f63def495fce2a3bdf9c365bf950e6#diff-3254677a7917c6c01f55212f86c57fbf

we're suggesting to run with net=host so don't need expose

Does having EXPOSE when running net=host cause a problem? If not, then having EXPOSE should let people run hass outside of net=host without specifying a port. It's debatable if that's good or bad.
@zn4ke for your purposes, I think you should be able to just specify the ports to bind to, and that will work with nginx-proxy.

im fine with a derived image. it solves my problem. i basically created the issue as a reference for others who might run into the same issue. it did give me some headaches to find the problem. sorry i forgot to close.


VLM dpo bug

trl/trainer/dpo_trainer.py line 542
The tokenizer for super().init () should be set to self.tokenizer instead of tokenizer, otherwise the previous is_vision_model will be invalid.

what do you mean by

otherwise the previous is_vision_model will be invalid.

?
When the model is a VLM, the transformers.Trainer expect a processor for the arg tokenizer, not a tokenizer.
in other words:
Trainer(
    ...,
    # tokenizer=processor.tokenizer, # NO
    tokenizer=processor, # YES
)

In line 341-343, if self.is_vision_model == True, then self.processor = tokenizer(i.e., processor) and self.tokenizer = tokenizer.tokenizer.
However, In line 536-548, super().init(...) will set self.tokenizer = tokenizer(i.e., processor).
In this case, self.tokenizer & self.processor = tokenizer(i.e., processor)

We are refactoring DPO data processing. The new implementation should be more readable.


Kong serf check needs some cleanup

Summary
Serf version checking has some mismatched function signatures that obscure invalid Serf version errors
Steps To Reproduce
N/A
Additional Details & Logs
local function check_serf_bin (https://github.com/Mashape/kong/blob/release/0.10.0/kong/cmd/utils/serf_signals.lua#L47) compares only a boolean result of the first value of check_version; however, check_version returns a nil and an error string on version mismatch (https://github.com/Mashape/kong/blob/release/0.10.0/kong/cmd/utils/serf_signals.lua#L31). This error is not bubbled up or logged, instead, the user is only told the serf executable could not be found (https://github.com/Mashape/kong/blob/release/0.10.0/kong/cmd/utils/serf_signals.lua#L55). Systems running an invalid Serf version are never informed about this condition.
Additionally, the current version of Serf available for download (v0.8.1) is not compatible based on (https://github.com/Mashape/kong/blob/master/kong/meta.lua#L22), yet this is not clearly identified. https://getkong.org/install/source/ indicates v0.8 should be installed, but if Serf follows semantic versioning, should v0.8.1 not also be available? Either Kong should more flexibly respect semantically-versioned dependencies, or the strict version checking should be more clearly documented.

we've been defensive with versions, only versions we know that work. Hence the strictness.
not sure wether it's worthwhile to update while we progressing to drop Serf...

Sounds like we should:

Document that semver isn't followed
Log and let the user know when an invalid serf version is found
Audit other dependency checkers and make sure they aren't swallowing up errors

I'll have a PR for the second item up shortly. First item sounds like it might fit on getkong.org/install/source? Third item sounds like a backlogged bug ;)

not sure wether it's worthwhile to update while we progressing to drop Serf...

+1
However,

we've been defensive with versions, only versions we know that work. Hence the strictness.

As recently discussed, I think we should be less strict with those and avoid trying to prevent forward compatibility. We should only enforce versions we never tested (< 0.7), but we shouldn't enforce users from using future releases. If they're not tested against, they are on their own, but at least we should be permissive enough to allow it.

https://github.com/Mashape/kong/commit/803646a56376003ad2b1377da34914509db17d30 addresses concerns about dep versions, but I'm not sure where to point the PR given the imminent release of 0.10. Same with https://github.com/Mashape/kong/commit/44c63455c5285e31e6849622d997847353b38c5a and serf search path logging.

btw Serf is in the 0.x phase, hence SemVer does not apply. Only works from 1.x onwards, 0.x is considered unstable.
but if we want the Serf dependency to be less strict then simply specify
serf = {"0.7.0", "0.8.999"},

or even better (but this requires changes elsewhere)
serf = version.set("0.7.0","0.9.0"):disallowed("0.9.0")

the latter has a better error message.

semver doesn't apply to openresty either ;) does this mean we cant imply any sort of minimum version requirement?

we recently saw a breaking change in an y.y.y.x release (enabling lua 5.2 compatibility)
I'm confident that for Serf allowing the whole 7.x and 8.x should be ok though.

Given that Serf is going to be dropped, and the following PRs handled the immediate-term work to be done here:
https://github.com/Mashape/kong/pull/2156
https://github.com/Mashape/kong/pull/2157
Any objections to closing this?

All good, thanks! :)


Add disc labels

This PR aims at adding files containing discs label for most subjects.
All centers have been labeled except:

fslPrima
fslAchieva
mountSinai

It also provides one minor correction to CONTRIBUTION.md.

@lrouhier could you please attach the QC report of these added derivatives, for easy review and track record (the reports are always attached to new releases). Thanks

Qc folder: https://drive.google.com/drive/folders/1_HB7tpg-G_Xq6tQ_nQ1XatBKk8lXSNRf?usp=sharing

Qc folder: https://drive.google.com/drive/folders/1_HB7tpg-G_Xq6tQ_nQ1XatBKk8lXSNRf?usp=sharing

@lrouhier could you instead point to a zipped file (otherwise the google drive API needs to do the zip each time a download is requested-- which is a waste of time)-- thanks

Here is a zip link to the qc: https://drive.google.com/file/d/1wDNaCKI4SaTJVmzS_v-zez0SIHdJyEzW/view?usp=sharing

damn! travis gets stuck with a timeout, which we didn't get in the past (i already restarted the job):
https://travis-ci.com/github/spine-generic/data-multi-subject/builds/181479798#L563

Yes I saw ! Then again that's 484 more files, even if it's not that heavy (because it's just label) I'm guessing it's still adding like a minute or two which might be enough to go overboard.
I'm guessing is due to the fact that the job has no log output (https://docs.travis-ci.com/user/customizing-the-build#build-timeouts), because we use a quiet mode and it takes more than 10 minutes now so it is shutting down.

@lrouhier i've noticed a few problems:

On the T2w images, the labels are often placed too inferiorly with respect to the posterior tip of the disc
On the T2w images, some labels are placed inside the central canal (instead of the posterior tip)
Some labels are missing where discs are visible

I haven't reviewed all of them (only the first ~10%), but I expect the same problem is present in the remaining 90%.
Here are some screenshots of notable problems: problem_discs.zip

Yes I saw. I am correcting that.

Might be due to the fact that I did not label on the same slice as the displayed slice (which can cause a few pixels of difference)

ah! good point. Can you please verify if the displayed slice is the same as the one you used, and if not, let's fix that first

I checked and it does not seem to be that. I am honestly a bit confused. I Check my "straight" label that usually use and these are correct. SO I may have worked with T2 registered to T1 to try and use the T1 label and then corrected on either the T2 registered to T1 or the straighten image. In any case, all the labels have been corrected I will produce the qc In a minute just after I update this PR (so that the data matches the QC)

@kousu can we authorize "squash and merge" for the repos, so the addition/deletion of binaries in non-master branches can be "forgotten" from the history tree?

Here is the qc: https://drive.google.com/file/d/1UHgTXPH2JsDxGalybxrRcnJXwvVRM06G/view?usp=sharing

FYI: with the correction we added the missing subjects so all should be labeled.

@PaulBautin could you please review?

@lrouhier, I'm not finished reviewing but i came across this image. I guess this is just due to the QC image slice:

@lrouhier, I'm not finished reviewing but i came across this image. I guess this is just due to the QC image slice:

indeed, this is a known problem. This PR needs to be ported from the old repos to the new repos: https://github.com/spine-generic/data-multi-subject_DO-NOT-USE/pull/23
I'll do it when i find a minute

defacing problem addressed in https://github.com/spine-generic/data-multi-subject/pull/19.

New qc -->https://drive.google.com/file/d/1LHdernT1sW350IMQ0uSc0mcC_KxP0uLw/view?usp=sharing
sub-Tokyo750w01 now with more label (as per request by @PaulBautin) Tell me it is good now!

Ok, everything looks great. Thanks @lrouhier ! Once this PR and PR #19 are merged we will be ready for a new csa-atrophy processing.


pipdeptree compatibility issue with pip=21.3

pipdeptree used to run fine with the latest version of pip. Since Oct 11th pip version 21.3 is out and it broke the pipdeptree.
#14 [11/18] RUN pipdeptree #14 sha256:7c8f692e9903fb11ca8bb2f9cc2051d6f3fa68285ed3b7caaa0b3a349fa37796 #14 0.638 Traceback (most recent call last): #14 0.638   File "/usr/local/lib/python3.8/dist-packages/pipdeptree.py", line 25, in <module> #14 0.638     from pip._internal.utils.misc import get_installed_distributions #14 0.638 ImportError: cannot import name 'get_installed_distributions' from 'pip._internal.utils.misc' (/usr/local/lib/python3.8/dist-packages/pip/_internal/utils/misc.py) #14 0.638  #14 0.638 During handling of the above exception, another exception occurred: #14 0.638  #14 0.638 Traceback (most recent call last): #14 0.638   File "/usr/local/bin/pipdeptree", line 5, in <module> #14 0.638     from pipdeptree import main #14 0.638   File "/usr/local/lib/python3.8/dist-packages/pipdeptree.py", line 28, in <module> #14 0.638     from pip import get_installed_distributions, FrozenRequirement #14 0.638 ImportError: cannot import name 'get_installed_distributions' from 'pip' (/usr/local/lib/python3.8/dist-packages/pip/__init__.py) #14 ERROR: executor failed running [/bin/sh -c pipdeptree]: exit code: 1 ------

@rickhg12hs @fcastilloec I am also seeing failure of pipdeptree --user-only. Currently on pipdeptree==2.2.0 and pip==21.3.1. @naiquevin I appreciate all you do here. Please get to this when you can.

I've fixed the behaviour of --user-only and --freeze flags in latest commits on master. If any of you are using the --user-only flag, can you please test it against your env?
Will publish a new release sometime this week.

I installed via:
$ python -m pip install --upgrade --user --upgrade-strategy eager git+https://github.com/naiquevin/pipdeptree.git

... and it seems to work, but I'm not sure if it has the same behavior as before.
$ python -m pip --version
pip 21.3.1 from /home/rick/.local/lib/python3.8/site-packages/pip (python 3.8)
$ python -m pip show ansible
Name: ansible
Version: 2.9.21
Summary: Radically simple IT automation
Home-page: https://ansible.com/
Author: Ansible, Inc.
Author-email<EMAIL_ADDRESS>License: GPLv3+
Location: /usr/lib/python3.8/site-packages
Requires: cryptography, jinja2, PyYAML
Required-by:
$ pipdeptree --user-only -p ansible
Warning!!! Possibly conflicting dependencies found:
* bleach==4.1.0
 - webencodings [required: Any, installed: ?]
* Sphinx==4.3.2
 - alabaster [required: >=0.7,<0.8, installed: ?]
 - sphinxcontrib-jsmath [required: Any, installed: ?]
------------------------------------------------------------------------

$ pipdeptree -p ansible
ansible==2.9.21
  - cryptography [required: Any, installed: 3.3]
    - cffi [required: >=1.12, installed: 1.15.0]
      - pycparser [required: Any, installed: 2.21]
    - six [required: >=1.4.1, installed: 1.16.0]
  - jinja2 [required: Any, installed: 3.0.3]
    - MarkupSafe [required: >=2.0, installed: 2.0.1]
  - PyYAML [required: Any, installed: 5.4.1]
$ python -m pip check
No broken requirements found.

Did pipdeptree formerly warn about dependencies met through --user install?

@rickhg12hs Thanks for testing it.

Did pipdeptree formerly warn about dependencies met through --user install?

To be honest, I am not sure. I will try running an older version of pipdeptree (with an old version of pip).
Would it be possible to upload the requirements.txt file of your env and a list of user-only packages?

@naiquevin My python reqs

@rickhg12hs Thanks

@rickhg12hs I could reproduce this issue by installing ansible with --user flag
vagrant@tmpvm:~/pipdeptree$ python3 pipdeptree.py -u -p ansible
defaultdict(<class 'list'>, {<DistPackage("ansible")>: [<ReqPackage("pyyaml")>]})
Warning!!! Possibly conflicting dependencies found:
* ansible==2.9.21
 - PyYAML [required: Any, installed: ?]
------------------------------------------------------------------------
ansible==2.9.21
  - cryptography [required: Any, installed: 2.1.4]
  - jinja2 [required: Any, installed: 2.10]
  - PyYAML [required: Any, installed: ?]
vagrant@tmpvm:~/pipdeptree$ python3 pipdeptree.py -u -p ansible,pyyaml
defaultdict(<class 'list'>, {<DistPackage("ansible")>: [<ReqPackage("pyyaml")>]})
Warning!!! Possibly conflicting dependencies found:
* ansible==2.9.21
 - PyYAML [required: Any, installed: ?]
------------------------------------------------------------------------
ansible==2.9.21
  - cryptography [required: Any, installed: 2.1.4]
  - jinja2 [required: Any, installed: 2.10]
  - PyYAML [required: Any, installed: ?]
vagrant@tmpvm:~/pipdeptree$ python3 pipdeptree.py -p ansible,pyyaml
defaultdict(<class 'list'>, {})
ansible==2.9.21
  - cryptography [required: Any, installed: 2.1.4]
  - jinja2 [required: Any, installed: 2.10]
  - PyYAML [required: Any, installed: 3.12]

Looks like with the -u flag the underlying pip function itself filters the packages ie. the filtering happens before checking for conflicts - and in this case, it's not able to find the version of PyYAML.
But with the -p flag, all packages are loaded into the tree data structure on which conflicts are checked. Then the filtering is done. In this case, the version of PyYAML is found.
To investigate further, I thought I'd try the following:

Uninstall ansible
Uninstall PyYAML
Reinstall ansible and PyYAML both with --user flag

But it doesn't allow me to uninstall PyYAML
Found existing installation: PyYAML 3.12
ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

I am guessing that PyYAML being a distutils project is what's causing it's version to be not found.
I think this is a package specific thing. I am proceeding with the release because the previous one is "more broken" 😅

Published version 2.2.1 to pypi

Yeah, I'm not really sure what the desired behavior should be.  Should a tree be displayed if the root (or some leaves) don't exist (or represent) what below it?  ... or perhaps with added note that root or leaf is satisfied by some other means?
Agreed, release is better. 👍🏻

@naiquevin Thank you! 2.2.1 fixed this.


Optimize the dart:isolate API to use functional programming

Greetings, I wanted to continue now with the isolate API to use functional programming, now we must understand that the management of concurrency and the management of multiple threads of execution is fundamental to perform a lot of parallel computing in a simple way. To achieve this we are going to be inspired by the java.util.concurrent API. We are exactly interested in the Executors class that allows us to create a Pool of threads.
In Dart the concept of thread is represented through what we call Isolate, if we talk in these terms, what we want is an Isolate Pool to implement this demo create the following
The System class
The System class allows us to represent the processor of the hardware where our program is running, the idea is to have the ability to obtain information from our hardware to use it to parameterize our algorithm, the System class could be seen this way

abstract class ChipInformation {
//you code
}

final class CpuInformation extends ChipInformation {
//you code
}

final class GpuInformation extends ChipInformation {
//you code
}

final class IntegratedGpuInformation extends ChipInformation {
//you code
}

final class NpuInformation extends ChipInformation {
//you code
}

class System {
 static CpuInformation getCpu();
 static GpuInformation getGpu();
 static IntegratedGpuInformation getIntegratedGpu();
 static NpuInformation getNpu();
}

To call the System class we could represent it as follows:
void main() {
 CpuInformation info = System.getCpu();

 print(info.name); //print: Intel 14900k
 print(info.numberOfCore); //print: 24
 print(info.numberOfCorePerformance); //print: 8
 print(info.numberOfCoreEfficient); //print: 16
 print(info.cache); //print: 36 MB Intel® Smart Cache
 print(info.numberOfCache); //print: 32
}

The IsolatePoolExecutor class
The IsolatePoolExecutor class allows you to implement an Isolate Pool to execute multiple Isolates in parallel in an efficient and standard way. To understand what this concept would be, we will see an example
import "dart:function";
import "dart:isolate";

class Example implements Callable<int> {
  int _count;
  Example(this._count);

  @override
  int run() {
    int sum = 0;
    final random = new Random();
    for (int i = 0; i < _count; i++) {
      sum += random.nextInt(10000);
    }
    return sum;
  }

}

Callable<int> fn = () {
  int sum = 0;
  final random = new Random();
  for (int i = 0; i < _count; i++) {
    sum += random.nextInt(10000);
  }
  return sum;
};

void main() {
 late pool1;

 if (System.isGpuAvailable) {
   final GpuInformation info = System.getGpu();

   pool1 = IsolatePoolExecutor.newGpuIsolatePool(info.numberOfCore);
 } else {
   final CpuInformation info = System.getCpu();

   pool1 = IsolatePoolExecutor.newFixedIsolatePool(info.numberOfCorePerformance, onlyPerformance: true);
 }

 final result = await pool1.compute(Example(10), 100000000);

 print(result);

 final result2 = await pool1.compute(() => fn(10), 100000000);

 print(result2);
}

The dart:isolate API will be able to provide some interfaces so that developers can implement their own version of an Isolate Pool, an existing library for this is isolate_pool_executor, the creators will be able to implement in the future the new interfaces provided to standardize some APIs.
More information here

The System class

I don't see the need for many of those properties and if a project need this information, it is going to have such specific needs that it is better that the application fetches the information itself using native API's. E.g. this is nonsense for most projects:
print(info.cache); //print: 36 MB Intel® Smart Cache

Having cache to output a String which you then need to manually parse is not developer friendly. It also question what should be considered "cache" since some CPU's have a very complicated relationship what is cache and what is memory.
We need then some platform specific way to get this information but in such way it is also the same across OS'es. That does not sound like something worth doing compared to how few programs needs this kind of information.

The IsolatePoolExecutor class

Should be implemented in a package which have already been done multiple times. There are many ways to do this kind of implementation and it depends on the project which are best fitting. Therefore, it is not something that should be in the Dart SDK. I don't see much value of making a standard way of pooling jobs since it would always be rather project specific.
I think you are looking a bit too much into how Java does things and have the opinion that Dart SDK should contain the same amount/types of features as Java's JDK. Instead, I think JDK contains too much and are rather noisy in containing stuff that is actually not needed to be in JDK but could easily be in dependencies. Therefore I don't think it is best for the Dart SDK to get as filled with stuff that could easily be packages.

@julemand101 Honestly, I am not going to take your opinion into account, because you are a "Hater", you are only criticizing my proposals without any basis, behaving like a 13-year-old teenager, that is unprofessional behavior.
You reflect an irrational hatred for languages like Java or C# which seems stupid to me, my proposals being inspired by the JDK, you are trying to prevent them from being approved due to your irrational hatred, you explicitly demonstrated your hatred in the official Discord
For you it is more important to obstruct my proposals than to contribute positively to the platform, all my proposals are founded and tested by the industry, every Senior programmer who uses reactive and functional programming will appreciate this news
If you on a personal level do not like these new features, do not use them, that does not mean that they should not exist, because on a personal level you do not like them, in your case you can use the usual Object Oriented programming and the world will continue. Going forward, the Dart language must satisfy all paradigms and it will depend on the programmers which paradigm to use.
Stop putting your personal desires above the interests of the platform. The Dart language is an open platform used by thousands of people and companies and must satisfy all needs.

@Ing-Brayan-Martinez Please read: https://dart.dev/community/code-of-conduct
If you have any issue with my behavior here, then report it to the E-Mail on that page instead of making such comments.

you explicitly demonstrated your hatred in the official Discord

The FlutterDev Discord server are not the official Flutter (or Dart) Discord but are fully community driven. If you have a problem with my behavior in that server, please get in contact with the moderators / administrators on that server.


Alias all LFS64 symbols to their non-LFS64 counterparts on musl

As per https://github.com/rust-lang/libc/issues/2934 the LFS64 symbols on musl-libc are simply aliases to the non-LFS64 symbols.  Currently this is done both in the header files (as #define entries) and in the library (as aliasing symbols).  There is a desire in musl to drop the ABI compatibility shims (the symbol aliases) - currently the libc crate exports the LFS64 symbols by extern-ing the compatibility shims which will fail if musl removes them.
This changes the musl build of libc to replicate the aliasing that's in the C header files (with pub use xxx as xxx64) so the API from the libc crate is unchanged, but the crate is now compatible with the upcoming musl release.
I've also checked and all the LFS64 types (e.g. off64_t) are already the same as their non-LFS64 equivalents.
This is an annoying change to test, libc-test seems expect to build against musl 1.1.24 (in fact, does Rust even support musl 1.2?  It's not obvious that it does... e.g. see https://github.com/rust-lang/libc/blob/d99c37d97c7a075ffc7f4260f2dd134d1ee3daaa/src/unix/linux_like/linux/musl/mod.rs#L288-L292)

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

This is a breaking change, we have to deprecate them on musl first otherwise user code depending on them would be broken.

Unless I've missed something, this isn't a breaking change (at a crate API level at least) - all the types and functions that used to exist still do and still have the same name/arguments/structure/alignment etc.  The only difference is that when rust code calls xxx64(*const xxx64_t) it will actually call the xxx function in the musl library (which it was already doing since the xxx64 symbol in the library was a link-time alias to the xxx symbol).
I've done a bit more work on this (ensuring that the complex types are rust-level aliases to each other on musl so they can be passed to either function without failing type checks), though I'm not sure it's complete (I've not done this for the structs in musl's b64 or b32 modules yet - and I'm unsure what needs to happen in the b32 case).

No, we don't support musl 1.2.0 or higher as it contains the time64 change. We've tried to update, and the discussion is ongoing: #2088 I'm not sure how it's related to this change though, does it matter?

There's a proposed patch available today to remove the symbols from the musl library on the 1.2.3 branch, to test this change has sufficiently removed the references to the LFS64 symbols, I plan to use that patched library.  Unfortunately, this also entails making a few changes to the libc crate (e.g. fixing up that linked struct definition) to get the tests passing which are changes that don't want to go into the crate while it's targeting 1.1.
Maybe this PR should be deferred until @wesleywiser's 1.2 support lands - since these symbols won't be disappearing in the 1.1.x releases.

:umbrella: The latest upstream changes (presumably #3095) made this pull request unmergeable. Please resolve the merge conflicts.

I tested this against ToT musl that includes the LFS64 symbol removal (https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4), and it required the attached addition to the second patch:
dirent64.patch.txt.

Thanks @colincross I'd not noticed the extra-traits feature.  Apparently there's a catchup merge/rebase needed too now 💯

Style check is failing, but otherwise this looks good to merge. It is not a breaking change.

From the discussion in #3248 this probably needs some markups.  In that discussion @joshtriplett would prefer the libc crate to expose LFS64 symbols even on Musl 1.2.4 so cross-libc-targeting crates don't need to use #[cfg] to find the 64-bit compatible file operations.  This seems reasonable (if a little unusual, not following the model used elsewhere in the libc crate) but it exposes another few questions about how the libc crate exposes the aliased symbols.
Currently the implementation exposes aliased types with type <foo>64 = <foo> and aliased functions with use <foo> as <foo>64 this has a few impacts:

The two types are not distinct, so (e.g.) trait impls on them overlap where they wouldn't for e.g. glibc
The function type signatures are "wrong", e.g. the <foo>64 function takes *mut <bar> not *mut <bar>64 arguments
The aliased functions are "the same" function (e.g. casting them to raw pointers will give the same value)

The use of use is also fairly messy, use pulls the named symbol into the current module in every namespace (value, function, type) unless there's already a symbol of that name defined directly in the current module.  This, combined with the name clash in stat()/stat64() vs struct stat/struct stat64 means that it's not immediately obvious where symbols are coming from and if they're correct.
An alternative approach would be for the musl backend to define each LFS64-affected type twice and to define shim functions of the form:
fn stat64(path: *const c_char, buf: *mut stat64) -> c_int {
  return stat(path, buf.cast());
}

Which assumes:

The inliner will do the right thing in release builds
The two structures are .cast()-able to each other which would want a regression test (or deterministic codegen?)

Thoughts?

I believe there was some confusion in the discussion in #3248. @joshtriplett was talking about time64, not LFS64.
You're right that changing the *64 types would be a breaking change due to possibe impls, and the alternative solution would be better.

Ok, I've added the set of shim functions (in .../musl/lfs64.rs) and restored the duplicate definitions of the structs.  I think this is now the correct shape for review!

I've tested this against musl 1.1.24 (x86_64 and i686) and against musl 1.2.4 (same architectures) - the former passes cleanly and the latter fails only on the padding changes that are already fixed in #3068.

@bors r+

:pushpin: Commit 04f8a609a1f805598e49bc2fe22fb7afcd28e529 has been approved by Amanieu
It is now in the queue for this repository.

Closing & reopening to hopefully fix a bors bug which is preventing other repos from moving forward...

:hourglass: Testing commit 04f8a609a1f805598e49bc2fe22fb7afcd28e529 with merge a9e79eb1c25c665a586e2b1a5450e3d4bc8dd207...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 5e752449bd051e3d439dc3ce2260cdcc6458bcb8 has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 5e752449bd051e3d439dc3ce2260cdcc6458bcb8 with merge 02d686d588b549affe2d191def2b71003b81881e...

@bors r+

:pushpin: Commit 75ac488063b968699c48881b59d525cd46ca95eb has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 75ac488063b968699c48881b59d525cd46ca95eb with merge 1e8c55cbed0b6e05a6c5063baa1fea50cad49269...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: Amanieu
Pushing 1e8c55cbed0b6e05a6c5063baa1fea50cad49269 to main...

Does this need to be done for other *64 functions? I'm seeing similar build errors regarding fcntl64 trying to statically compile sqlite for x86_64 musl under Linux.


Support Puppet 5 & 6 + stdlib 5.0

This updates the testing infrastructure to support current versions.

I forgot one change in Rakefile. Updating.

@locknut seems I don't have permission to merge this patch. Could you check it out or grant me permission to do such a thing?

@locknut what do you think?

Should be good to merge now.


Flutter DataTable using TextFields (Tab key and Arrow keys are not responsive)

i have a DataTable and added textfield in each cell. i have two columns and three rows . when i press tabkey its not working properly or when i use up and down arrow key it not work properly

Hi @abdulrehmananwar
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

Hi @abdulrehmananwar
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

D:\tag\flutter_datatable>flutter doctor -v
[√] Flutter (Channel master, 1.26.0-2.0.pre.365, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
• Flutter version 1.26.0-2.0.pre.365 at D:\flutter
• Framework revision 9209319dd1 (2 hours ago), 2021-01-15 14:34:03 +0530
• Engine revision efa768683e
• Dart version 2.12.0 (build 2.12.0-225.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.2)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.8.30717.126
• Windows 10 SDK version 10.0.18362.0
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 87.0.4280.141
• Edge (web)        • edge    • web-javascript • Microsoft Edge 87.0.664.75
• No issues found!
--- below is source code
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This is the main application widget.
class MyApp extends StatelessWidget {
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: MyStatelessWidget(),
),
);
}
}
/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
MyStatelessWidget({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return DataTable(
columns: const [
DataColumn(
label: Text(
'Name',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
DataColumn(
label: Text(
'Qty',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
],
rows: const [
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
],
);
}
}

D:\tag\flutter_datatable>flutter doctor -v
[√] Flutter (Channel master, 1.26.0-2.0.pre.365, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
• Flutter version 1.26.0-2.0.pre.365 at D:\flutter
• Framework revision 9209319dd1 (2 hours ago), 2021-01-15 14:34:03 +0530
• Engine revision efa768683e
• Dart version 2.12.0 (build 2.12.0-225.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.2)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.8.30717.126
• Windows 10 SDK version 10.0.18362.0
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 87.0.4280.141
• Edge (web)        • edge    • web-javascript • Microsoft Edge 87.0.664.75
• No issues found!
--- below is source code
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This is the main application widget.
class MyApp extends StatelessWidget {
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: MyStatelessWidget(),
),
);
}
}
/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
MyStatelessWidget({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return DataTable(
columns: const [
DataColumn(
label: Text(
'Name',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
DataColumn(
label: Text(
'Qty',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
],
rows: const [
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
],
);
}
}

D:\tag\flutter_datatable>flutter doctor -v
[√] Flutter (Channel master, 1.26.0-2.0.pre.365, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
• Flutter version 1.26.0-2.0.pre.365 at D:\flutter
• Framework revision 9209319dd1 (2 hours ago), 2021-01-15 14:34:03 +0530
• Engine revision efa768683e
• Dart version 2.12.0 (build 2.12.0-225.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.2)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.8.30717.126
• Windows 10 SDK version 10.0.18362.0
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 87.0.4280.141
• Edge (web)        • edge    • web-javascript • Microsoft Edge 87.0.664.75
• No issues found!
--- below is source code
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This is the main application widget.
class MyApp extends StatelessWidget {
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: MyStatelessWidget(),
),
);
}
}
/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
MyStatelessWidget({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return DataTable(
columns: const [
DataColumn(
label: Text(
'Name',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
DataColumn(
label: Text(
'Qty',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
],
rows: const [
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
],
);
}
}

D:\tag\flutter_datatable>flutter doctor -v
[√] Flutter (Channel master, 1.26.0-2.0.pre.365, on Microsoft Windows [Version 10.0.19042.746], locale en-US)
• Flutter version 1.26.0-2.0.pre.365 at D:\flutter
• Framework revision 9209319dd1 (2 hours ago), 2021-01-15 14:34:03 +0530
• Engine revision efa768683e
• Dart version 2.12.0 (build 2.12.0-225.0.dev)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.2)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.8.30717.126
• Windows 10 SDK version 10.0.18362.0
[√] Android Studio (version 4.1.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.746]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 87.0.4280.141
• Edge (web)        • edge    • web-javascript • Microsoft Edge 87.0.664.75
• No issues found!
--- below is source code
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This is the main application widget.
class MyApp extends StatelessWidget {
static const String _title = 'Flutter Code Sample';
@override
Widget build(BuildContext context) {
return MaterialApp(
title: _title,
home: Scaffold(
appBar: AppBar(title: const Text(_title)),
body: MyStatelessWidget(),
),
);
}
}
/// This is the stateless widget that the main application instantiates.
class MyStatelessWidget extends StatelessWidget {
MyStatelessWidget({Key key}) : super(key: key);
@override
Widget build(BuildContext context) {
return DataTable(
columns: const [
DataColumn(
label: Text(
'Name',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
DataColumn(
label: Text(
'Qty',
style: TextStyle(fontStyle: FontStyle.italic),
),
),
],
rows: const [
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
DataRow(
cells: [
DataCell(
TextField(
)),
DataCell(
TextField(
)),
],
),
],
);
}
}

issue #1   tab key press 2 times instead 1 time for focus to next widget.
issue #2  up and down keys i want to move focus to up row and down row.

issue #1   tab key press 2 times instead 1 time for focus to next widget.
issue #2  up and down keys i want to move focus to up row and down row.

I was able to reproduce this issue.

issue #1 tab key press 2 times instead 1 time for focus to next widget.

This is caused by the TableRowInkWell used by DataRow , it catch the focus that is supposed to be forwarded to the second TextField. To avoid breaking changes, this should be fixed by exposing the canRequestFocus from TableRowInkWell to DataCell so that users can set it to false to avoid it from receiving focus.

issue #2 up and down keys i want to move focus to up row and down row.

For this, please open a new issue. We don't track more than one issue in the same place since they are expected to be fixed in different places and PRs.

flutter doctor -v
/Users/pedromassango/dev/SDKs/flutter_master/bin/flutter doctor --verbose
[✓] Flutter (Channel master, 1.26.0-2.0.pre.364, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.26.0-2.0.pre.364 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision fb9e485dd8 (6 hours ago), 2021-01-15 01:39:02 -0500
    • Engine revision efa768683e
    • Dart version 2.12.0 (build 2.12.0-225.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.2.5
    • Dart plugin version 203.6912

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • sdk gphone x86 64 (mobile) • emulator-5554 • android-x64    • Android 11 (API 30) (emulator)
    • macOS (desktop)            • macos         • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Chrome (web)               • chrome        • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.
Process finished with exit code 0

I was able to reproduce this issue.

issue #1 tab key press 2 times instead 1 time for focus to next widget.

This is caused by the TableRowInkWell used by DataRow , it catch the focus that is supposed to be forwarded to the second TextField. To avoid breaking changes, this should be fixed by exposing the canRequestFocus from TableRowInkWell to DataCell so that users can set it to false to avoid it from receiving focus.

issue #2 up and down keys i want to move focus to up row and down row.

For this, please open a new issue. We don't track more than one issue in the same place since they are expected to be fixed in different places and PRs.

flutter doctor -v
/Users/pedromassango/dev/SDKs/flutter_master/bin/flutter doctor --verbose
[✓] Flutter (Channel master, 1.26.0-2.0.pre.364, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.26.0-2.0.pre.364 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision fb9e485dd8 (6 hours ago), 2021-01-15 01:39:02 -0500
    • Engine revision efa768683e
    • Dart version 2.12.0 (build 2.12.0-225.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.2.5
    • Dart plugin version 203.6912

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (3 available)
    • sdk gphone x86 64 (mobile) • emulator-5554 • android-x64    • Android 11 (API 30) (emulator)
    • macOS (desktop)            • macos         • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Chrome (web)               • chrome        • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.
Process finished with exit code 0

Thanks for your kind response. kindly please share some piece of code to resolve issue #1 thanks

Thanks for your kind response. kindly please share some piece of code to resolve issue #1 thanks

I was able to reproduce this issue.

issue #1 tab key press 2 times instead 1 time for focus to next widget.

This is caused by the TableRowInkWell used by DataRow , it catch the focus that is supposed to be forwarded to the second TextField. To avoid breaking changes, this should be fixed by exposing the canRequestFocus from TableRowInkWell to DataCell so that users can set it to false to avoid it from receiving focus.

How to achieve this?
Related: https://github.com/flutter/flutter/issues/72879#issue-773915406


add newline cushion between tags and python snippet in snippet update script

https://github.com/Azure/azure-sdk-for-python/issues/29166
@xiangyan99 this fixes the rendering issue in the github.io page. I'm not sure if we want to merge this during release week since pipelines might fail - what do you think?

Do we also need to update readmes w/ this change?

Do we also need to update readmes w/ this change?

Yes, that would probably be the best way to do it. I'll check your original PR and update.

API change check
API changes are not detected in this pull request.


Proper SRV for named ports

Given a service "svc" in namespace "ns", with a TCP port "foo", we should generate SRV records for _foo._tcp.svc.ns...
P2 because we COULD cut it, but easy as we do the other work, and enables a lot of standards-based stuff.

Reassigning to @ArtfulCoder!

xref #6666

I think we have to do this at least minimally - not having SRV is going to inhibit a lot of new-generation cloud development that understands SRV.  Openshift has similar constructs, and I think we need to document our DNS schema and it needs to include basic SRV.

Also it is almost done.

resolved by #9073


Add RSS datasource with crawling support

This is still unfinished and makes certain assumptions that will have to
be abstracted. Open TODOs are:

Make crawling and pagination configurable through different Crawler
classes or settings
Survey how different feeds to pagination. A semi-spec (proposed
standard) is documented here: https://www.rfc-editor.org/rfc/rfc5005#section-3
but unclear where it is supported
Add configurable mappers for non-standard fields and allow to create sub-datasources with
feed-specific business logic
Review the ID logic

Regarding the GUID logic, you might have a look at https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/other-recommendations.md#episode-guid


Error in require('nodobjc'): Path must be a string. Received undefined

Hello!
I'm not sure where I have to put my questions – here, in electron repo or in webpack repo.
I have bundle.js bundled by webpack, that I use in main electron window. There I'm trying to require('nodobjc'), but I have this exception:
path.js:7 Uncaught TypeError: Path must be a string. Received undefined
Weird thing that when I stop script with debugger on line where I have this require and do require('nodobjc') in developer console it works.
Full stacktrace if it can help:

Electron versions:
{
  chrome: "50.0.2661.102",
  node: "6.1.0",
  v8: "<IP_ADDRESS>",
  modules: "48",
  electron: "1.1.3"
}

I would appreciate any help, thanks!

Btw, I solved it by adding externals: ['nodobjc'] to webpack config so it can be closed since it is not related to NodObjC package