Relay increases ping even with batchingInterval set to 1

The relay ping from client to backend is higher than client connecting directly to backend even when the relay server is on the same device as the client. I have batchingInterval set to 1, so this may be caused by packet processing.
How to reproduce (noticeable way):

Make a relay to the hive (with batchingInterval set to 1)
Navigate through the menus
Connect directly to the hive and navigate the menus

Observed results:
Menu navigation is slower with relay.
This happens with servers other than the hive too (the other server i tested was zeqa, which uses pocketmine).

One of the consequences of using any proxy is you get a higher ping as information needs to travel farther and be processed for longer. You can expect a ~2-3x bump in ping, with the best case being the proxy running locally (most of overhead is processing) and worst case the proxy running externally (most of overhead is in transit).
There is not enough information here currently to make this issue actionable. To fix that, please provide code that can reliably reproduce high pings, preferably something running locally where the proxy ping is >2x the ping directly connected to a vanilla server.

//process.env.DEBUG = 'minecraft-protocol'
const { Relay } = require('bedrock-protocol')
  const relay = new Relay({
    version: '1.20.0', // The version
    // host and port to listen for clients on */
    host: '<IP_ADDRESS>',
    port: 29132,
    batchingInterval: 1,
    raknetBackend: 'raknet-native',
    /* Where to send upstream packets to */
    destination: {
      batchingInterval: 1,
      host: '<IP_ADDRESS>', // Change this to server ip if needed (hive - dns lookup geo.hivebedrock.network, zeqa - dns lookup zeqa.net). Currently set to local server on default port.
      //logging: true,
      port: 19132
    }
  })
  relay.listen() // Tell the server to start listening.

  relay.on('connect', player => {
    console.log('New connection', player.connection.address)

    // Server is sending a message to the client.
    player.on('clientbound', ({ name, params }) => {
      //console.log(name);
    })
    // Client is sending a message to the server
    player.on('serverbound', ({ name, params }) => {
      //console.log(name);
    })
  })

Ping is much easier to notice on servers like hive and zeqa than vanilla server. Additionally, the server thinks the ping is ping between the relay and backend, not client and backend, when using commands like /ping on zeqa. Equivalent command exists on a lot of servers.

You aren't measuring anything in the code.

You aren't measuring anything in the code.

I can tell ping is definitely higher even without measuring.

We can't do anything if there isn't an objective metric to work with, so that would have to be measured in the code. I will take a look at the local vanilla latency, but I doubt there is anything bad in the current code.

How would i measure the ping from the relay to the client? I thing relay to client is the problem, not relay to backend server.

See my code and comment above

Can confirm ping increase with measuring (by doing client -> relay -> another relay -> backend with both relays printing the timestamp when a command_request is received). The second relay recieved the command about 50 ms later than the first on average, meaning that the relay increases ping by like 50 ms, which is more than it should when running locally.

Ping test: https://gist.github.com/GameParrot/a81e31e834f8bbc6b88c5d897e772fe9
Output I got:
C -> S: 28
S -> C: 41
-------
C -> S: 27
S -> C: 6
-------
C -> S: 29
S -> C: 28
-------
C -> S: 32
S -> C: 20
-------
C -> S: 34
S -> C: 11
-------
C -> S: 36
S -> C: 33
-------
C -> S: 38
S -> C: 24
-------
C -> S: 39
S -> C: 16
-------
C -> S: 41
S -> C: 38
-------

In milliseconds, connected with localhost (i consider this fixed if we can get it under 15 constantly when on localhost)

Closing once extremeheat/node-raknet-native#20 is merged and release is made


No Support For Transcoding

If there is no support for oneof then any services using transcoding won't be supported. I believe this may be an issue for many developers. What's the main issue with supporting this field?

Technically, it is actually achievable, mainly because implementing functions like has_foo and clean_foo in the blueprint will make the generated code more complicated. But I don't quite understand why oneof is related to trasncoding, can you explain? thanks.

Understood, thank you for sharing this information！
I will consider adding these supports in future versions, but it does take some time.

Hi, You can try the new version. For the message file that contains the definition of transcoding, the correct code can be generated now.
But there is a problem that I don't quite understand. If the server uses the REST protocol, then the client can directly use the HTTP protocol and JSON-type data, so you shouldn't need this plug-in. I don't know what I understand. is it right or not?

Hi, You can try the new version. For the message file that contains the definition of transcoding, the correct code can be generated now. But there is a problem that I don't quite understand. If the server uses the REST protocol, then the client can directly use the HTTP protocol and JSON-type data, so you shouldn't need this plug-in. I don't know what I understand. is it right or not?

Great news! I haven't used this plugin in awhile, but when I was working with it I was also able to get it work by modifying your generation script. The use for transcoding is for support outside of gRPC. This plugin won't use this functionality, but it is used other places in the architecture.
I'm not sure if it has since been fixed, but there were some large issues with the protobuf code generator that also makes this plugin useful for me as of now. If I have time in the future I'd be happy to help but I don't at the moment. When I have time I can go into more detail and create a issue on the generator if that is helpful for you.

When using packages with periods (eg- com.website), then the generated code incorrectly uses periods in variable or type names. Sorry I don't remember which it was.
When generating the protobuf messages, it goes through the file linearly (top to bottom). If there are any dependencies between messages, then the generator does not change the order in which they are declared possibly causing issues in C++ if they aren't in a valid C++ order.
Example that would cause a problem for C++:

message MessageA {
  MessageB data = 1;
}

message MessageB {
  string id = 1;
}

Thank you for reply.  The good news is that I have solved the two problems you mentioned in the new version.

When using packages with periods (eg- com.website), then the generated code incorrectly uses periods in variable or type names. Sorry I don't remember which it was.
In the new version, I use the camel-case format of the package name in the UE. For example, there is a protocol file named hello.proto, and the name of the package is example.com. Then the generated UE file file structure is

-SExampleCom
 |--Private
 | |--HelloClient.cpp
 | |--HelloMessage.cpp
 | |-- ...
 |
 |--Public
   |--HelloClient.h
   |--HelloMessage.h
   |--HelloNode.h
   |--HelloService.h
   |-- ...

When generating the protobuf messages, it goes through the file linearly (top to bottom). If there are any dependencies between messages, then the generator does not change the order in which they are declared possibly causing issues in C++ if they aren't in a valid C++ order.
I do not solve this problem by adjusting the message order, because in some cases, this problem cannot be completely solved by the adjustment order. For example, the following two protocols

message MessageA {
  MessageB msg_b = 1;
}
message MessageB {
  MessageA msg_a = 1;
}

My solution is to add data types of TSharedPtr types to USTRUCT,  and then use (native make and native break)[https://docs.unrealengine.com/5.1/en-US/metadata-specifiers-in-unreal-engine/#structmetadataspecifiers] functions to achieve reflection，The code generated now is as follows:
USTRUCT(BlueprintType, meta = (DisplayName="User.MessageA",
    HasNativeMake = "TurboLinkGrpc.GrpcUserMessageAHelperLibrary.MakeMessageA",
    HasNativeBreak = "TurboLinkGrpc.GrpcUserMessageAHelperLibrary.BreakMessageA"))
struct FGrpcUserMessageA : public FGrpcMessage
{
    GENERATED_BODY()
    TSharedPtr<FGrpcUserMessageB> MsgB;
};

USTRUCT(BlueprintType, meta = (DisplayName="User.MessageB"))
struct FGrpcUserMessageB : public FGrpcMessage
{
    GENERATED_BODY()
    UPROPERTY(BlueprintReadWrite)
    FGrpcUserMessageA MsgA;
};

UCLASS()
class UGrpcUserMessageAHelperLibrary : public UBlueprintFunctionLibrary
{
    GENERATED_BODY()
public:
    UFUNCTION(BlueprintPure, Category = "TurboLink|User", meta=(BlueprintThreadSafe))
    static FGrpcUserMessageA MakeMessageA(FGrpcUserMessageB MsgB);

    UFUNCTION(BlueprintPure, Category = "TurboLink|User", meta=(BlueprintThreadSafe))
    static void BreakMessageA(const FGrpcUserMessageA& MessageA, FGrpcUserMessageB& MsgB);
};

FGrpcUserMessageA UGrpcUserMessageAHelperLibrary::MakeMessageA(FGrpcUserMessageB MsgB)
{
    FGrpcUserMessageA MessageA;
    MessageA.MsgB = MakeShareable(new FGrpcUserMessageB(MsgB));
    return MessageA;
}
void UGrpcUserMessageAHelperLibrary::BreakMessageA(const FGrpcUserMessageA& MessageA, FGrpcUserMessageB& MsgB)
{
    MsgB = *(MessageA.MsgB.Get());
}

Nice solution, especially since it looks like it only uses reflection if needed! I'll give the plugin another go when I have time. I think these were my only issues stopping me from adopting this plugin

Works well, thanks for the update!


Update to Clap 3.1.0 and use derive macro

Waiting for #324, to simplify rebasing.

bors try

bors r+


CCDB-4383: Validate server version for pgoutput plugin

Problem
pgoutput is the standard logical decoding output plug-in in PostgreSQL 10+. This is not validated currently and the connector can weirdly fail during runtime with following trace:
io.debezium.jdbc.JdbcConnectionException: ERROR: syntax error
	at io.debezium.connector.postgresql.connection.PostgresReplicationConnection.initPublication(PostgresReplicationConnection.java:180)
	at io.debezium.connector.postgresql.connection.PostgresReplicationConnection.createReplicationSlot(PostgresReplicationConnection.java:343)
	at io.debezium.connector.postgresql.PostgresConnectorTask.start(PostgresConnectorTask.java:125)
	at io.debezium.connector.common.BaseSourceTask.start(BaseSourceTask.java:103)
	at org.apache.kafka.connect.runtime.WorkerSourceTask.initializeAndStart(WorkerSourceTask.java:235)
	at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:196)
	at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:253)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:831)
Caused by: org.postgresql.util.PSQLException: ERROR: syntax error
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2532)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2267)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:312)
	at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:448)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:369)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:310)
	at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:296)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:273)
	at org.postgresql.jdbc.PgStatement.executeQuery(PgStatement.java:226)
	at io.debezium.connector.postgresql.connection.PostgresReplicationConnection.initPublication(PostgresReplicationConnection.java:140)
	... 11 more

Solution
Add validation to cover this scenario

Also, why didn't you consider sending a PR to upstream?

The plan would be to follow up with a PR upstream. The current aim is to hotfix and mitigates this issue on our cloud offering, to start with.

Also, why didn't you consider sending a PR to upstream?

The plan would be to follow up with a PR upstream. The current aim is to hotfix and mitigates this issue on our cloud offering, to start with.

Makes sense.

Looks good. Thanks Chaitanya!
Just one question. Did you check if there are any compatibility checks for other plugins?
I did not check when the incident surfaced.


Install fails possible/probably due to authenticated proxy

Hi!
Type: Bug / Feature Request
NPE version: 3.16
Installed from: ClickOnce
In case of a BUG:

What is the current result? Error msg
What is the expected result? Success
Please post full exception details in case of an Exception (message, stacktrace, inner exceptions) See attachment
Are there any work arounds? No
Is there a version in which it did worked? No
Is there a package on Nuget.org which shows the bug? No

In case of FEATURE REQUEST:

Why do we need it? In a corporate environment with an authenticated proxy firewall it is not possible to install NPE. Please provide either the ability to specify credentials for an authenticated proxy or an alternate installer not Click Once.
Please provide an use case. Same

NuGet Package Manager - Click Once download - 41IK12NC.log.txt

	* [07/06/2016 4:12:38 PM] System.Deployment.Application.DeploymentDownloadException (Unknown subtype)
		- Downloading https://npe.codeplex.com/releases/clickonce/NuGetPackageExplorer.application did not succeed.
		- Source: System.Deployment
		- Stack trace:
			at System.Deployment.Application.SystemNetDownloader.DownloadSingleFile(DownloadQueueItem next)
			at System.Deployment.Application.SystemNetDownloader.DownloadAllFiles()
			at System.Deployment.Application.FileDownloader.Download(SubscriptionState subState)
			at System.Deployment.Application.DownloadManager.DownloadManifestAsRawFile(Uri& sourceUri, String targetPath, IDownloadNotification notification, DownloadOptions options, ServerInformation& serverInformation)
			at System.Deployment.Application.DownloadManager.DownloadDeploymentManifestDirect(SubscriptionStore subStore, Uri& sourceUri, TempFile& tempFile, IDownloadNotification notification, DownloadOptions options, ServerInformation& serverInformation)
			at System.Deployment.Application.DownloadManager.FollowDeploymentProviderUri(SubscriptionStore subStore, AssemblyManifest& deployment, Uri& sourceUri, TempFile& tempFile, IDownloadNotification notification, DownloadOptions options)
			at System.Deployment.Application.DownloadManager.DownloadDeploymentManifestBypass(SubscriptionStore subStore, Uri& sourceUri, TempFile& tempFile, SubscriptionState& subState, IDownloadNotification notification, DownloadOptions options)
			at System.Deployment.Application.ApplicationActivator.PerformDeploymentActivation(Uri activationUri, Boolean isShortcut, String textualSubId, String deploymentProviderUrlFromExtension, BrowserSettings browserSettings, String& errorPageUrl)
			at System.Deployment.Application.ApplicationActivator.ActivateDeploymentWorker(Object state)
		--- Inner Exception ---
		System.Net.WebException
		- Unable to connect to the remote server
		- Source: System
		- Stack trace:
			at System.Net.HttpWebRequest.GetResponse()
			at System.Deployment.Application.SystemNetDownloader.DownloadSingleFile(DownloadQueueItem next)
		--- Inner Exception ---
		System.Net.Sockets.SocketException
		- A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443
		- Source: System
		- Stack trace:
			at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
			at System.Net.ServicePoint.ConnectSocketInternal(Boolean connectFailure, Socket s4, Socket s6, Socket& socket, IPAddress& address, ConnectSocketState state, IAsyncResult asyncResult, Exception& exception)

I don't think we fix this. This is your internet connection or codeplex. :(

You can use the [chocolatey](https://chocolatey.org/packages/NugetPackageExplorer_ package?


Separate private and public API

Nice package! The API docs are kind of cluttered because they're showing every single file and folder, because everything is directly in lib
What you should do instead:

move everything into lib/src
decide which classes/functions you want people to be able to import
out of those, make groups, like IO and args
in lib/, make individual "header files" that just look like this:

// lib/args.dart
export "src/args/parser.dart";
export "src/helpers/arg_tree.dart";
// More arg-related exports here

This way, you split your package into smaller libraries, that each get their own page in the API docs, and that people can import individually, like this
import "package:darted_cli/args.dart";

This also follows the standard pub convention

Thank you so much, @Levi-Lesches, For the feedback!
I do realize I blazed through the development of the package because i needed it for implementation in one of my projects, and neglected a lot of standards.
I will get back and handle everything once i get the time to, hopefully really soon.
Thank you so much once more for taking the time to share your thoughts and help make the package better, I truly appreciate it.

Updated in the 0.1.3 release.
Thanks once more for your feedback.


refactor: don't random sort plugin

Check List
Please read and check followings before submitting a PR.

[ ] I want to publish my theme on Hexo official website.

[ ] I have read the theme publishing doc.
[ ] name is unique.
[ ] link URL is correct.
[ ] preview URL is correct.
[ ] preview URL web site is rendered correctly.
[ ] Add a screenshot to source/themes/screenshots.
[ ] Screenshot filename is same as value of name.
[ ] Screenshot size is 800 * 500.
[ ] Screenshot file format is png.

[ ] I want to publish my plugin on Hexo official website.

[ ] I have read the plugin publishing doc.
[ ] name is unique.
[ ] link URL is correct.

[x] Others (Update, fix, translation, etc...)

Languages:
[ ] en English
[ ] ko Korean
[ ] pt-br Brazilian Portuguese
[ ] ru Russian
[ ] th Thai
[ ] zh-cn simplified Chinese
[ ] zh-tw traditional Chinese

If the plugins are arranged in order, it is easier for users to find the plugins they need.
Because there are many grouped by type e.g. hexo-tag-* hexo-helper-* hexo-generator-* hexo-renderer-*
https://github.com/hexojs/site/pull/1390#issuecomment-783185023


Fix Issue 18082 - Ubuntu/Debian repository installation should mention dub

As we are already at the topic:

there's an internal discussion going on about moving the d-apt repository to dlang-community
it was discussed on the NG that rdmd will be moved into dmd-compiler
even though DMD is now fully open source since May this year, no one has yet stepped up & submitted the package to Debian upstream

CC @leandro-lucarella-sociomantic @jordisayol

I am by no means a Debian Developer, but I have friends that are, so if anyone wants to take on this I can probably get the support from Debian people.

I'm a DD, but haven't had enough time to keep up with things, so I probably can't do the work myself.  But I can help sponsor packages if someone is willing to iron out the wrinkles.
Keep in mind, though, that there was a discussion with other DDs interested in putting dmd into Debian in the D general newsgroup a while back, and the general consensus was to stick with ldc as the official D compiler for Debian packages, and to offer dmd as an alternative, standalone package. See<EMAIL_ADDRESS>also the part starting here<EMAIL_ADDRESS>The primary concerns are that dmd only supports a very small subset of platforms supported by Debian, and also that libraries built using dmd isn't compatible with libraries built using other D compilers.  Debian is pretty strong about being cross-platform, and supports quite a large number of platforms that most may consider as marginal, to the point where a new package almost needs to justify why it doesn't work on a given platform.  Also, compatibility across libraries is pretty important, so the fact that dmd ABI isn't compatible with, say, gdc ABI, means dmd cannot be used as the standard D compiler in Debian (for building official Debian packages -- though there is no such restriction for providing dmd as a standalone package that users can install and use to their hearts' content).
Nevertheless, there is great value to be had in having the official reference compiler as part of the Debian archive, as long as it isn't used as the standard D compiler for archive packages. So I'd be happy to sponsor such packages, if someone can step up to working out the details to make it work.

Thanks for the clarifications!


Ability to add "OpenScriptEditor" button to toolbar

I would like the ability to add a button to the toolbar to open the script editor.

I'll be glad to slip this in the next release.

Thank you


Add support for test container

It would be nice to support the test container (Symfony\Bundle\FrameworkBundle\Test\TestContainer), which allows to fetch private services for testing.
A use case would be the Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::$container. If you currently use this container in the tests, Psalm will report a PrivateService issue and will not know the correct type (only object|null).
I'm not sure how to do this properly. Maybe the ContainerHandler could always set the type, even if the service is not public and then suppress the PrivateService manualy for the tests directory?

@micheh thanks for the report! I think your suggestion is legit.


Q: Chromecast server application

Hi,
I have a question about this API. Would it be possible to use it and implement a Chromecast server? So basically I'd like my app to act as Chromecast dongle and connect my mobile to it and stream the display (video+audio) into the java app.
Thanks

I don't think it can be used this way. The goal of this library is to act as "sender" for chromecast. But you can do some reverse engineering to implement your server so it will emulate chromecast behaviour.

Thank you for the quick answer


mal-aligned grid?

Thanks for the nice library. One small issue where the grid seems  mal-aligned.
See https://d.pr/i/u0iXIL for image.

Am I missing something?

Hello,
This is the expected behaviour. Let's see why...
[
  [ // first row
    Slot(cell: CellMap.self, params: [:]), // cell Map
    Slot(cell: CellChart.self, params: [:]), // cell Chart 1
    Slot(cell: CellChart.self, params: [:]), // cell Chart 2
    Slot(cell: CellLogs.self, params: [:]) // cell Logs 1
  ],
  [ // second row
    Slot(cell: CellCharacter.self, params: ["race": "troll"]), // cell Char 1
    Slot(cell: CellCharacter.self, params: ["race": "elves"]), // cell Char 2
    Slot(cell: CellCharacter.self, params: ["race": "undead"]), // cell Char 3
    Slot(cell: CellCharacter.self, params: ["race": "merfolk"]) // cell Char 4
  ]
]

This grid will have two rows, because the main array have two elements.
| |
| |

Nice. Then, using "a something like stack" we will put each cell on the grid. Since the first cell, Map, has size 2x2, we will have:
| M1 | M1 |
| M1 | M1 |

Okay. Let's put the cell Chat 1. This cell has size 2x1, then:
| M1 | M1 | C1 | C1 |
| M1 | M1 |

Let's put the Chart 2...
| M1 | M1 | C1 | C1 | C2 | C2 |
| M1 | M1 |

Let's put the last cell on the first row, Logs 1. This cell has size 2x1.
| M1 | M1 | C1 | C1 | C2 | C2 | L1 | L1 |
| M1 | M1 |

Okay. We finished the first row. Now, let's start the second row putting the cell Char 1. This cell has as size 1x1.
| M1 | M1 | C1 | C1 | C2 | C2 | L1 | L1 |
| M1 | M1 | X1 |

Let's put the Char 2...
| M1 | M1 | C1 | C1 | C2 | C2 | L1 | L1 |
| M1 | M1 | X1 | X2 |

Let's put the Char 3...
| M1 | M1 | C1 | C1 | C2 | C2 | L1 | L1 |
| M1 | M1 | X1 | X2 | X3 |

And finally, the Char 4:
| M1 | M1 | C1 | C1 | C2 | C2 | L1 | L1 |
| M1 | M1 | X1 | X2 | X3 | X4 |

Finish!
You can see that we have a hole on bellow the L1. But it is expected by the algorithm.
This could be a little confused on the begin, but it is very flexible and very easy to write.


Support Auth Integration

Hey there, I have basically the same package (updating today to apollo 2) and it handles credentials, check it out here: https://github.com/nmaro/ooth/tree/master/packages/ooth-client-react-next-apollo

Thanks @nmaro ! I've also been looking at the official apollo-auth example in the next.js examples directory for inspiration. The challenge is how configurable to make it.


Mandelbrot, vector-add, Nbody samples are marked as Common+Advisor

Description
Mandelbrot, vector-add, Nbody samples are good for showcasing the features of Intel Advisor. The lists of categories for these samples are extended with "Toolkit/oneAPI Tools/Advisor". This change allows to show the mentioned samples in 2 places of the samples tree: in their actual location (see categories in sample.json before change) and in Advisor part of tree without source code duplication. The logic of samples is not changed.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Sample Migration (Moving sample from old repository after completing checklist established)
[X] sample.json update (categories)

How Has This Been Tested?

[X] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode

@JoeOster  Do you mean the readme with the list of samples (https://github.com/oneapi-src/oneAPI-samples/blob/master/README.md) or readme files in the folders with specific samples?
Anyway, what would you like to see in readme? The suggested change does not affect the logic of samples, it just adds one more category to the list in sample.json; please see more details in the updated PR description.
Thanks!


Remove Paypal Logo in DataEntry

How could I remove the paypal logo in DataEntryActivity for manual card number entries?

See the extras that can be supplied when starting the scanning Activity. There are a few different options for the logos that are displayed.


Rancher cluster explorer , view pod logs screen doesn't seem to fit in the frame

Login to rancher
Choose a cluster -> Cluster explorer ,
Pods -> view pod logs
Notice that the bottom portion of the screen is completely cut off and cannot figure out what are the options available, how we can download ,filter logs, change the amount of logs to be displayed etc.
Versions|Rancher v2.5.7 UI: v2.5.6 |

https://github.com/rancher/dashboard/issues/2632
https://github.com/rancher/dashboard/issues/2488


intermittent 404 on https://mines.legumeinfo.org/legumemine/service/web-properties?format=json brings down the server

per discussion started over here
I believe I was seeing something similar (but more frequent) when trying to test on a non-production VM, which I had chalked up to network flakiness on that VM. I'm not clear on why "the web-properties URL is pinged constantly" but clearly the reported error (copied again below) is coming from tomcat so it seems like it's not a networking issue.
graphql-server-110-graphql-server-1  | /app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:95
graphql-server-110-graphql-server-1  |         return new graphql_1.GraphQLError(`${response.status}: ${response.statusText}`, {
graphql-server-110-graphql-server-1  |                ^
graphql-server-110-graphql-server-1  |
graphql-server-110-graphql-server-1  | GraphQLError: 404: 404
graphql-server-110-graphql-server-1  |     at IntermineAPI.errorFromResponse (/app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:95:16)
graphql-server-110-graphql-server-1  |     at IntermineAPI.throwIfResponseIsError (/app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:87:26)
graphql-server-110-graphql-server-1  |     at /app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:199:32
graphql-server-110-graphql-server-1  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
graphql-server-110-graphql-server-1  |     at async IntermineAPI.fetch (/app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:231:56)
graphql-server-110-graphql-server-1  |     at async IntermineAPI.get (/app/node_modules/@apollo/datasource-rest/dist/RESTDataSource.js:111:17)
graphql-server-110-graphql-server-1  |     at async IntermineAPI.webProperties (file:///app/dist/data-sources/intermine/intermine.server.js:54:16)
graphql-server-110-graphql-server-1  |     at async IntermineAPI.verifyIntermineVersion (file:///app/dist/data-sources/intermine/api/index.js:265:32) {
graphql-server-110-graphql-server-1  |   path: undefined,
graphql-server-110-graphql-server-1  |   locations: undefined,
graphql-server-110-graphql-server-1  |   extensions: {
graphql-server-110-graphql-server-1  |     response: {
graphql-server-110-graphql-server-1  |       url: 'https://mines.legumeinfo.org/legumemine/service/web-properties?format=json',
graphql-server-110-graphql-server-1  |       status: 404,
graphql-server-110-graphql-server-1  |       statusText: '404',
graphql-server-110-graphql-server-1  |       body: '<!doctype html><title>HTTP Status 404 – Not Found</title>
HTTP Status 404 – Not Found

Type Status Report

Message The requested resource [/legumemine/service/web-properties] is not available

Description The origin server did not find a current representation for the target resource or is not willing to disclose that one exists.

Apache Tomcat/9.0.80
'
graphql-server-110-graphql-server-1  |     }
graphql-server-110-graphql-server-1  |   }
graphql-server-110-graphql-server-1  | }
graphql-server-110-graphql-server-1  |
graphql-server-110-graphql-server-1  | Node.js v20.9.0

this is a bandaid, but is there any reason not to add a restart: always directive to the compose.prod.yml for this?

this is a bandaid, but is there any reason not to add a restart: always directive to the compose.prod.yml for this?

I wouldn't put it into the repo but it seems a reasonable solution for now.

OK, not sure why it wouldn't be appropriate for the version in the repos, but have just done it locally for now.

Yeah, the graphql-server needs to be resilient to mine outages, obviously. Sometimes LegumeMine drops out (research ongoing) but also I sometimes do a restart on the mines if I've updated the data in some way. (The constant polling of web-properties seems a bit over the top to me, it's certainly annoying when you run graphql-server in dev mode and get log lines output like crazy to the console.)

OK, not sure why it wouldn't be appropriate for the version in the repos, but have just done it locally for now.

You caught me on my way out the door yesterday so when you said "bandaid" my mind immediately went to the proverb, "nothing is more permanent than a temporary solution." I gave you my gut reaction and was on my way.
Adding restart always to compose.prod.yml seems reasonable. Let's keep it out of compose[.dev].yml, though.

Yeah, the graphql-server needs to be resilient to mine outages, obviously.

Agreed. Just because one data source has gone down doesn't mean the whole server should come down. Having the production container always restart is a good fail-safe. I'll open an issue for this.

The constant polling of web-properties seems a bit over the top to me, it's certainly annoying when you run graphql-server in dev mode and get log lines output like crazy to the console.

Yeah, it's super annoying. When I implemented the Intermine version check (which is the source of the polling) I tried to avoid this but the way Apollo Server works made it hard to avoid without some code mangling. I just told it to check the version when an Intermine data source is instantiated; the polling is a side-effect of how Apollo manages its data sources. It's probably worth revisiting at some point...

@adf-ncgr Mind opening a PR that makes the restart always change to the compose.dev.yml file?

sure, but I thought we had agreed it would be only to the compose.prod.yml file- right?

sure, but I thought we had agreed it would be only to the compose.prod.yml file- right?

Yes. Thanks for confirming!

Temporary fix implemented in PR #111. Follow issue #103 for a more robust fix.


[nrf fromtree] Integrate nrfx 3.4.0

Cherry-pick nrfx 3.4.0 integration

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

hal_nordic
https://github.com/zephyrproject-rtos/hal_nordic/commit/5470822384781624efb2fda28cbc6a895a227677
https://github.com/zephyrproject-rtos/hal_nordic/commit/13ac55b5b52c905642e9c54f069109d188aa5840 (master)
<EMAIL_ADDRESS>

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Already pulled-in by https://github.com/nrfconnect/sdk-zephyr/pull/1577


command export LANG=en_US.UTF-8 is incorrectly recognized

With bash -c simply do not work, but without throws error:
thread 'main' panicked at 'Failed to execute command: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/main.rs:69:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This should be described in "constraints".


fix clean copyright

I think there are 2 main problems in current  clean_copyright_comments function https://github.com/togethercomputer/RedPajama-Data/blob/567ac9a0927c6dd3a2bf7e880de191239acfc308/data_prep/github/github_clean_dedup_local.py#L27.
First, It cannot remove the copyright successfully in the following C-style code because of the early return in https://github.com/togethercomputer/RedPajama-Data/blob/567ac9a0927c6dd3a2bf7e880de191239acfc308/data_prep/github/github_clean_dedup_local.py#L37
// Copyright

int main() {
    return 0;

    /* comment */
}

Second, I find that, when the file is large, the regex sometimes costs much time in my experiment, I think we only need to find the copyright in the first 100 lines.

Hi @hust-nj , I had a look at your PR. Here's some feedback:

I would prefer not to limit the search for copyright to the first 100 lines; based on what are you proposing 100 lines?
Your current implementation also gets rid of comments in the beginning of any file, which we would like to keep. For example, this:

// A comment

int main() {
    return 0;

    /* comment */
}

yields
int main() {
    return 0;

    /* comment */
}


[README.md]: Broken Configlet & Test links/badges

Not sure if it is across all browsers.

@ErikSchierboom ?

Isn't it the Exercism Euphoria Track by now?

I started off, a couple of years ago, differentiating between the language and the implementation. It's all Euphoria now but the "Open" appears occasionally

@axtens You can fix this in the README.
The proper badge links can be found in the corresponding workflow page: https://github.com/exercism/euphoria/actions/workflows/configlet.yml

https://github.com/exercism/euphoria/pull/73


Logbook custom currency

Possibility to setup custom currency requirements that a club or the EASA requires for flying a certain airplane in certain situations. An example it would be great to have those displayed easily. Example:

3 take off and 3 landings in the previous 90 days
12 hours as PIC in the last 24months for LAPL renewal
etc.

Foreflight has a similar section in its logbook capability.
Apologies if this is already existing and I have not seen it. I saw the limits section which is, as far as I see, not the same.
Awesome work and thanks !

Hey! It's not yet implemented, but I'm planning to rewrite a front-end UI using the React framework (which I hope to start this month or next), and I will add these new currencies or some sort of support for adding own custom checks.


Add min_value and max_value support for FloatGenerator

Unfortunately, there is no way to input a minimum and maximum value for a FloatGenerator.

Please refer to my pull request #54: https://github.com/gregmuellegger/django-autofixture/pull/54


[java] Add modifiers to markdown output

For example:
public abstract java.lang.String key();
Should output:
*new* abstract method: `String key()`

🎊 My diff is ready for review at http://codereview.cc/D1506


New content data viz

@schalkventer this was a new PR for content that was re-added. Can we in some way or another add this content?


scaffold subgraph generation failing  for contracts using 2D arrays as event params

Which packages are impacted by your issue?
@graphprotocol/graph-ts
Describe the issue
subgraph generation fails for the contracts having 2D arrays as event params
Reproduction

Steps to Reproduce the Bug or Issue
Try to index this contract 0x16C6521Dff6baB339122a0FE25a9116693265353 on Mainnet and subgraph generation will fail with the error
✖ Failed to create subgraph scaffold: ',' expected. (3:26)
  1 |
  2 |   import { assert, describe, test, clearStore, beforeAll, afterAll } from "matchstick-as/assembly/index"
> 3 |   import { Address, Array<BigInt, BigInt } from "@graphprotocol/graph-ts"
    |                          ^
  4 |   import { Exchange } from "../generated/schema"
  5 |   import { Exchange as ExchangeEvent } from "../generated/CurveRouter/CurveRouter"
  6 |   import { handleExchange } from "../src/curve-router"
    SyntaxError: ',' expected. (3:26)
      1 |
      2 |   import { assert, describe, test, clearStore, beforeAll, afterAll }
     from "matchstick-as/assembly/index"
    > 3 |   import { Address, Array<BigInt, BigInt } from
    "@graphprotocol/graph-ts"
        |                          ^
      4 |   import { Exchange } from "../generated/schema"
      5 |   import { Exchange as ExchangeEvent } from
    "../generated/CurveRouter/CurveRouter"
      6 |   import { handleExchange } from "../src/curve-router"
      ```

### Expected behavior

Expect to get scaffold subgraph code but getting `✖ Failed to create subgraph scaffold`

### Screenshots or Videos

_No response_

### Platform

- OS: [e.g. macOS, Windows, Linux]
- NodeJS: [e.g. 18.5.0]
- `@graphprotocol/*` version(s): [e.g. 2.6.2]

### Subgraph Manifest

_No response_

### Subgraph GraphQL Schema

_No response_

### Additional context

_No response_

Seen https://github.com/graphprotocol/graph-tooling/issues/1576
Workaround documented in https://github.com/graphprotocol/graph-tooling/issues/1706


Fullscreen/resize bugs?

Fullscreen and window resizing is pretty much completely untested. There are probably bugs that I haven't found yet as a result. This is a reminder to give those code paths some exercise.

There is a bug in tmux/osx preventing apps launched from tmux to go fullscreen in OSX, but I do not see any obvious bugs in treecount.


Print all constraints when container can't be scheduled

Fixes #1785.
Special case when no healthy node is found, in which case nothing else is printed. The logic is in scheduler/filter/filter.go

ping @dongluochen @jpetazzo @dnephin

Job: Swarm-PRs (engine 1.9) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.9)/29/console):

---
- docker network rm
ok 154 mesos - docker network disconnect connect
ok 155 mesos - docker ps
ok 156 mesos - docker run with wrong user
ok 157 mesos - docker run
ok 158 mesos - docker run short lived
ok 159 mesos - docker run no resources
ok 160 mesos - docker run with long pull
ok 161 mesos - docker stats
ok 162 mesos - docker-compose ps
ok 163 mesos - docker-compose scale
ok 164 mesos - docker-compose up
ok 165 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.9)] $ /bin/sh -xe /tmp/hudson2632563208584611963.sh
+ set +x

---

Job: Swarm-PRs (engine 1.9) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.9)/30/console):

---
- docker network rm
ok 154 mesos - docker network disconnect connect
ok 155 mesos - docker ps
ok 156 mesos - docker run with wrong user
ok 157 mesos - docker run
ok 158 mesos - docker run short lived
ok 159 mesos - docker run no resources
ok 160 mesos - docker run with long pull
ok 161 mesos - docker stats
ok 162 mesos - docker-compose ps
ok 163 mesos - docker-compose scale
ok 164 mesos - docker-compose up
ok 165 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.9)] $ /bin/sh -xe /tmp/hudson6422209000006541757.sh
+ set +x

---

Nice, this looks like it solves the problem. Thanks!

@nishanttotla @vieux With this change, we will have the following problem:

We list all the conditions that the user specified to schedule a container
We don't list the specific condition check that failed

Is this worse than the current error message as the user now has no knowledge of the specific check that failed? Perhaps printing:

Condition 1
Condition 2
Condition 3 [Check failed]
Condition 4

Will be more informational

@amitshukla that is correct, but given that our checks run in a batch, even right now the error message that gets printed doesn't necessarily tell you if that specific check would have failed on its own.
What you're suggesting

Condition 1
Condition 2
Condition 3 [Check failed]
Condition 4

would make sense if it conveyed that Condition 3 fails on its own, To do that, we'd have to run the check on all nodes as opposed to those filtered from checking Conditions 1 and 2, potentially making the overall operation more expensive.

Made a slight update, I think now we have a better solution - now we only print a subset of failing constraints. Out of the 5, the first n constraints that fail as a combination are reported, the rest ignored.
For example in a Swarm with two nodes, assume an nginx container called web is running on node 1, attached to port 80 on the host.
Then, the outputs will look like the following
$ docker -H <manager-ip>:<manager-port> run -d --volumes-from web -p 80:80 nginx
Error response from daemon: Unable to find a node that satisfies the following conditions
[port 80 (Bridge mode)]
[--volumes-from=web]

This is as expected, but if we provide an additional image affinity constraint, the output remains the same, giving strictly more information to help debug
$ docker -H <manager-ip>:<manager-port> run -d --volumes-from web -p 80:80 -e affinity:image==nginx nginx
Error response from daemon: Unable to find a node that satisfies the following conditions
[port 80 (Bridge mode)]
[--volumes-from=web]

Thanks @amitshukla for the discussion on this!

Job: Swarm-PRs (engine 1.10) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.10)/345/console):

---
- docker network rm
ok 154 mesos - docker network disconnect connect
ok 155 mesos - docker ps
ok 156 mesos - docker run with wrong user
ok 157 mesos - docker run
ok 158 mesos - docker run short lived
ok 159 mesos - docker run no resources
ok 160 mesos - docker run with long pull
ok 161 mesos - docker stats
ok 162 mesos - docker-compose ps
ok 163 mesos - docker-compose scale
ok 164 mesos - docker-compose up
ok 165 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.10)] $ /bin/sh -xe /tmp/hudson4981243597244570717.sh
+ set +x

---

Job: Swarm-PRs (engine 1.9) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.9)/47/console):

---
- docker network rm
ok 154 mesos - docker network disconnect connect
ok 155 mesos - docker ps
ok 156 mesos - docker run with wrong user
ok 157 mesos - docker run
ok 158 mesos - docker run short lived
ok 159 mesos - docker run no resources
ok 160 mesos - docker run with long pull
ok 161 mesos - docker stats
ok 162 mesos - docker-compose ps
ok 163 mesos - docker-compose scale
ok 164 mesos - docker-compose up
ok 165 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.9)] $ /bin/sh -xe /tmp/hudson4871897605761827727.sh
+ set +x

---

The test seems to fail repeatedly. Please take a look.

@dongluochen it seems like a zk discovery: node removal test, not sure that it's related.

Job: Swarm-PRs (engine 1.9) [FAILED](https://jenkins.dockerproject.org/job/Swarm-PRs (engine 1.9)/58/console):

---
- docker network rm
ok 160 mesos - docker network disconnect connect
ok 161 mesos - docker ps
ok 162 mesos - docker run with wrong user
ok 163 mesos - docker run
ok 164 mesos - docker run short lived
ok 165 mesos - docker run no resources
ok 166 mesos - docker run with long pull
ok 167 mesos - docker stats
ok 168 mesos - docker-compose ps
ok 169 mesos - docker-compose scale
ok 170 mesos - docker-compose up
ok 171 mesos - zookeeper
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Swarm-PRs (engine 1.9)] $ /bin/sh -xe /tmp/hudson2270914791946341715.sh
+ set +x

---

LGTM.

Ping @docker/core-swarm-maintainers

@nishanttotla any update?

@amitshukla this PR is actually ready on my end, needs review.

@amitshukla @vieux @dongluochen I just rebased this PR. I think we can include it in 1.2.

LGTM

LGTM


Typings development workflow is not cross platform

As mentioned here, Typings development workflow is *nix specific.  In package.json in the scripts element you will find:
    "build": "rm -rf dist/ && tsc",

and
    "bootstrap": "mkdir -p typings && touch typings/main.d.ts && SKIP_PREPUBLISH=true npm install && npm run build 2> /dev/null; cat dist/init.js > /dev/null && node dist/bin/typings.js install",

rm rf and touch are *nix specific.  I think that npm run build 2> /dev/null; cat dist/init.js > /dev/null && node dist/bin/typings.js install may also be but I'm not certain.
It would be good to make it cross platform to allow more people to contribute.  I say this as a Windows user.
I'm pretty sure that rm rf usage can be replaced with rimraf.  I suspect that touch can be replaced with touch.
I'd be happy to handle switching over those as suggested if that's acceptable?
However I'm not too clear on the intent of npm run build 2> /dev/null; cat dist/init.js > /dev/null and so I'm not completely clear how that would be ported.

Yeah, absolutely. The bootstrap command I wasn't sure I could work out how to make that Windows compatible, but mostly it's ignoring the build errors since there's a lot when building TypeScript without type definitions.

I'll look into this; it looks like moving to node scripts might be the only way to make things properly cross platform.
Once the work is done it might be an idea to get CI set up on a Windows environment as well.  AppVeyor offer free CI to open source projects and so they could be worth a look.  It's what we're using on ts-loader alongside Jenkins.  I'll raise an issue for that as well.

Are we ready to close this? :smile: Good job @johnnyreilly

I think it's done for core yes :+1:
Don't know if there's other repos which aren't but we can open new targeted issues if there are.


Please, update the mol file of CHEBI:15379 (O2)

Dear Adnan,
Please could you update the molfile of CHEBI:15379 (O2) which contains Sgroup annotations and is wrongly identified by our procedure as a polymer, preventing us to use it in Rhea.
Thank you for your support,
Anne
CHEBI:15379 current molfile
Marvin<PHONE_NUMBER>2D
2  1  0  0  0  0            999 V2000
-0.4125    0.0000    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
0.4125    0.0000    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
1  2  2  0  0  0  0
M  STY  1   1 SUP
M  SAL   1  2   1   2
M  SMT   1 O2
M  END

molfile now updated. Thanks


Issues with non-ascii characters

When pyrus.phar is launched from a directory whose name contains non-ascii characters pyrus thows an XMLParser\Exception.
For example:
pierre@pierre-K52Jc:~$ php Téléchargements/pyrus.phar

PHP Warning:  XMLReader::setSchema(): Unable to set schema. This must be set prior to reading or schema contains    errors. in phar:///home/pierre/Téléchargements/pyrus.phar/PEAR2_Pyrus-2.0.0a3/php/PEAR2/Pyrus/XMLParser.php on line 171
PEAR2\Pyrus\XMLParser\Exception: Invalid XML document
PEAR2\Pyrus\XMLParser\Exception: Line 0: failed to load external entity "phar:///home/pierre/T%C3%A9l%C3%A9chargements/pyrus.phar/PEAR2_Pyrus-2.0.0a3/data/pear2.php.net/PEAR2_Pyrus/customcommand-2.0.xsd"

PEAR2\Pyrus\XMLParser\Exception: Line 0: Failed to locate the main schema resource at 'phar:///home/pierre/Téléchargements/pyrus.phar/PEAR2_Pyrus-2.0.0a3/data/pear2.php.net/PEAR2_Pyrus/customcommand-2.0.xsd'.

I can reproduce this using the latest version of pyrus.phar as released on http://pear2.php.net/.
However, I cannot reproduce the results using a git clone for Pyrus / Pyrus_Developer... but I suspect the issue is specific to phar.
A similar issue [#69] has been discovered in alpha3 whereby libxml2 fails to load an XML schema when a phar archive or any other PHP stream is used and there are spaces in the path. I think you just found another way to trigger that issue.

Confirmed that this is the same issue as #69 and has been fixed.


when to release code

Dear Authors,
Thanks for your excelllent work! I'm wondering when the source code will be released?

We appreciate your interest in our work🦅.
We will release our code and checkpoints as soon as everything gets ready.


Update Content for Programmer's Guide

Problem Statement
The content in the API Programmer's Guide is out of date. As the ReportStream team, we need to update the content so that it matches the API functionality and we can provide accurate information when we distribute it to API end users.
Acceptance Criteria

Update the API Programmer's Guide so that it matches the API functionality
Include the async progress in the API Programmer's Guide (see Jim Duff's slack)
Review the API Programmer's Guide when changes are complete to ensure they match the API

@jbiskie is working on an updated version of the Programmer's Guide here: https://app.zenhub.com/workspaces/onboarding--operations-6166edbd409257001e09f1b2/issues/cdcgov/prime-reportstream/3627

@BerniXiongA6 I'm planning to complete this sprint.

Update 2.8.2022: Joel Biskie to complete updated version of programmer's guide by end of sprint. I'll do a full content review after that time to finalize a version 2.0 doc. (Couldn't create a dependency on O&O's # 3627 for this Issue, can you help @loripusey ?)

Update 2.24.2022: Received the version 2.0 draft of the programmer's guide for senders from @jbiskie yesterday. Completed content review (containing marked changes and comments) and saved it on shared doc in Experience teams folder for Joel to accept/reject/modify changes and resolve comments. Joel B. to finalize 1) "Appendix A: Fields List..." and 2) routing info via separate API call.

Update 2.25.2022: See new issue # 4555 for "content review" that will need to be done once final updates on schema guidance (and other minor engineering edits) come back from engineering (Joel B.).

Updated 3.10.2022: Saving final API programmer's guide version 2 here.


Improve README steps for putting tilt in PATH

Fix #1208.
The README used to mention that one should create $HOME/.local/bin on Linux and put binaries there, but the Tilt installer will do that for you, creating it if it doesn't already exist. So I've updated the README with instructions that assume you've run the installer, explaining how to check that $HOME/.local/bin is on your PATH and make sure it gets added if it wasn't already there.

@myieye @hahn-kev - Ready for re-review. I've trimmed the bit about reading the script down to a simple "(don't forget to read the script before running it)" parenthetical, and the rest of the changes focus on the new instructions for putting things in the PATH (because "put in $HOME/.local/bin or C:\Users\yourname\bin" is redundant now, since the Tilt install script uses those locations by default and creates them if they don't exist).


Preserve documentation and comments

Currently no comments are preserved.
This is the input:
/** UUID or string. */
type UUIDOrString = UUID | string;

interface Obj {
  /** The object ID. */
  id: string;
  /**
   * A longer description.
   * Part 2.
   * Part 3.
   */
  name: string; // A comment here.
}

Expected output:
UUIDOrString = UUID | str;
"""UUID or string."""

class Obj(TypedDict):
    id: str
    """The object ID."""
    name: str  # A comment here.
    """
    A longer description.
    Part 2.
    Part 3.
    """

An option like --no-comments could exist to ignore comments but keep docblocks, as well as --no-docs. Another option would be to output the alternative field description syntax (#: above the field) but currently VS Code's Python extension does not support this.

As of Version 0.7.5 multiline(!) comments can be preserved with the "--comments"-option. (There was unfortunately a bug in earlier versions that could cause invalid Python-code in some cases. Workaround: Eliminate all comments first.)
I'll think about the other options:
#: should be easy to implement. Does this mean that #: should be put in every line of a multilone doc-string or only the first?
docstrings are bit more complicated, because the comment needs to be moved to another place, but i'd consider this the preferred option.

Great progress!

#: should be easy to implement. Does this mean that #: should be put in every line of a multilone doc-string or only the first?

This one would be very low priority and definitely not a default. Basically this is something 'non-standard' maybe invented by Sphinx for those coming from languages where the documentation is always above the declaration (like Java, PHP, etc):
#: Pie.
#: Line 2.
PI = 3.14

As far as I know, if the line exceeds your max line length, you can break it but every line must start with #:.
I moved away from using the above syntax a long time ago. It is inconsistent when everything else in Python has the documentation coming after the declaration.


Improve CA_CERTS_PATH defined as list warning

Improve "CA_CERTS_PATH defined as list" warning
Description
See https://github.com/apache/libcloud/pull/1114 for details. As requested by @Kami:

Not related to your change, but I would prefer this message to be a bit more explicit and user-friendly - https://github.com/apache/libcloud/blob/trunk/libcloud/http.py#L153. And perhaps also point user to the corresponding documentation section.

Is it better? Should the URL be included?
Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[x] Documentation
[ ] Tests

Codecov Report

Merging #1118 into trunk will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           trunk    #1118      +/-   ##
=========================================
- Coverage   85.4%   85.39%   -0.01%
=========================================
  Files        346      346
  Lines      66190    66191       +1
  Branches    5892     5892
=========================================
- Hits       56527    56525       -2
- Misses      7265     7268       +3
  Partials    2398     2398

Impacted Files
Coverage Δ

libcloud/http.py
88.63% <0%> (-0.68%)
:arrow_down:

libcloud/test/compute/test_ec2.py
97.74% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bf2d9...09f9701. Read the comment docs.

This highlights that this part of the code is not tested. I'll try to add a test.

Test added, please take a look.


Should WithPgAdmin / WithPgWeb wait for Postgres to start?

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
With the new WaitFor, should extension containers such as PgAdmin, PgWeb wait for the parent container.
For example in the below screenshot you can see that PgAdmin has started before the Postgres container has finished pulling.

It doesn't do any harm to start them early, but equally it makes no sense to have them running before the resource they're used for exists.   Similarly if the resource fails of fully initialise, it may be helpful to have the admin tools around to diagnose the problem.  (Does it make sense to have a version of the WaitFor method that only waits for resource start up, and not health checks to pass)
Describe the solution you'd like
If we think they should wait, then we should add the appropriate .WaitFor() calls into the WithPgAdmin, WithPgWeb calls.  (As well as any similar extension container e.g. Redis Commander)
Additional context
Can repro with the following

Remove local postgres images to ensure it takes extra time to stat

docker image rm docker.io/library/postgres:16.4 -f

Run Postgres & PgAdmin.

var builder = DistributedApplication.CreateBuilder(args);

builder.AddPostgres("server")
    .WithPgAdmin();

builder.Build().Run();

Closing this issue. We deliberately don't wait for Postgres to start because in the case of PgAdmin it can connect to multiple servers/databases and having one server fail to start should not preclude you from using it to manage the other databases.
If folks really need it to wait for some reason they can use the callback on WithPgAdmin to add a WaitFor on the postgres resource.


bond tests:Add bond without slaves

Add bond without slaves
Signed-off-by: Sveta Haas<EMAIL_ADDRESS>

Coverage remained the same at 72.395% when pulling 3a7249c359dc601d36ee2d33643b3875017ffbcc on SvetaHBar:bond_eth_tests into 61a47ae5f13b92cf344ef9373d96eb642963ded2 on nmstate:master.

ci test please


Book recommendation page not found error

The book recommendation page is missing.
It shows 404_NOT_FOUND error when clicked on Book recommendations.

please assign me this issue under gssoc levels @anuragverma108

Assigned!

@anuragverma108 do you want book recommendations page to open in new tab or the same tab?

On same tab

@Taniishaaa After doing the work! Show the screenshots to me on my discord anuragverma_108.

@anuragverma108  Sent the screenshot to you on discord and created a pull request.


Ads not showing when downloaded from Play Store?

Hi,
I can see my ads in test emulator and also can see ads by installing apk directly to device.
But I can not see any ads when my app is downloaded from Play Store?

I have added Firebase to my project. And it's fixed.

@emretekince Wait what? Do we need to add Firebase? @sbugert


Framework settings in Jobs

I'm not sure what the expected behaviour is supposed to be, but I don't think we're handling the Framework setting in the right way.
For instance, if you write a Config like so, would you expect it to run your benchmarks twice, once under .NET 4.5.2 and once under .NET 4.6?
private class Config : ManualConfig
{
	public Config()
	{
		Add(new Job { Framework = Framework.V452 });
		Add(new Job { Framework = Framework.V46 });
                ....
	}
}

Well it doesn't and I'm not sure if it's even possible? Since .NET 4.0 all the updates have been in-place, i.e they install on-top of each other. AFAIK I know if you have .NET 4.6 installed, there's not a way to tell it behave like .NET 4.5 at runtime. The only setting you seem to have is <supportedRuntime version="<version>"/>, but that doesn't seem to offer what we'd need.
What we do change is the <TargetFrameworkVersion> setting in the Program.csproj we generate. This affects what happens at compile-time, but only effects the compilation of the scaffolding code that BenchmarkDotNet generates, not any of the user code that is annotated with [Benchmark] as that has already been compiled. To really change the users benchmark code, they would have to change their project settings, which BenchmarkDotNet can't do:

I came across this because I wanted to check out the Array.Empty<T> optimisation that the Roslyn compiler added in .NET 4.6 (see some of it's perils and more info here). So I wanted to write some code and then see the difference between the old .NET 4.5.2 behaviour and the optimised .NET 4.6 version.
Thoughts, idea? Am I doing it wrong?
Is this something we even want to support? If not, why do we allow specifying the Framework value, does it even make sense? Especially if we plan to remove .NET 3.5 and only allow .NET 4.0 and upwards.
What's a valid reason for specifying the Framework value in a job?

@mattwarren Actually, there is, however it's almost undocumented and it changes not so much.
I'm talking about <supportedRuntime>'s SKU attribute.
It's per-appdomain setting and there's list of what it changes (look for retargeting changes sections).
Bad news: there're some compile-time retargeting changes (to be honest I can remember only the one with Array.Empty<T>). And there're runtime changes you cannot toggle at all.
So, I'm second here. Don't see any reason to keep the Framework option at all.
As a sidenote. I'd propose to enable validators that can be run in same process the benchmark is run. It will allow to detect cases when environment does not match job settings.
Something like this, I guess.
Offtopic: what about #190? Still waiting for comments before doing PR (there were minor changes but the code is pretty much the same):)

I'm talking about 's SKU attribute.
It's per-appdomain setting and there's list of what it changes (look for retargeting changes sections).

Hmm, seems I misunderstood what <supportedRuntime> actually does. Although as you say, it's still limited, i.e it only changes the behaviour of "Retargeting changes" (am I understanding correctly?)

As a sidenote. I'd propose to enable validators that can be run in same process the benchmark is run. It will allow to detect cases when environment does not match job settings.

Yeah that would be nice, the more validators the merrier!! I've been saved from producing bad benchmark results several times, thanks to JitOptimizationsValidator.FailOnError

Offtopic: what about #190? Still waiting for comments before doing PR (there were minor changes but the code is pretty much the same):)

Sorry, I completely forgot about that, I'll take a look now.

i.e it only changes the behaviour of "Retargeting changes" (am I understanding correctly?)

Yep. At least as far as I know. Here's example of settable compatibility switches.

Yeah that would be nice, the more validators the merrier!!
Ok. Will fill an issue.

Yep. At least as far as I know. Here's example of settable compatibility switches.

Oh I see, so it's not a runtime-wide settings, i.e. "Enable all 4.5.1 comparability switches" (when running under 4.5.1 for example), it's per feature, i.e. "NetFx40_TimeSpanLegacyFormatMode" or "NetFx40_LegacySecurityPolicy".

@mattwarren as far as I can remember these switches are also toggled on or off depending on SKU. Could not find a good proof as I've looked at the code a year or two ago.

@AndreyAkinshin @adamsitnik have you got any objections to the Framework setting being removed? (see the top of this thread for the reasons)

No objections.

No objections.

Same here. The less settings the better! I think that we should make it [Obsolete] first to not break people's code.

thanks, I'll go ahead and make the changes

@mattwarren I have removed it just to make sure we don't release new version with settings that can affect nothing (after moving to Roslyn it's irrelevant)

@adamsitnik thanks for doing that
I tried to do it myself the other week but found that Framework was being used by the Toolchain code and so I left it till the Roslyn work was done.

You should probably remove it from documentation too: https://perfdotnet.github.io/BenchmarkDotNet/Configuration/Jobs.htm

@Tornhoof, Thanks for the notice. However, in the next version of BenchmarkDotNet, we have a lot of improvements in the API and we have completely rewritten documentations for Jobs: https://github.com/PerfDotNet/BenchmarkDotNet/blob/master/docs/guide/Configs/Jobs.md


Strict mode and review CSS Types

Taking over from #116
This PR adds a strict mode feature, originally proposed by @fgnass
Strict mode is false by default.
I also did a review of the CSS Types, which closes #48. For example, this allows numbers in margin properties, since internally we convert them to px.

Important note
When strict: true shorthands have a stricter syntax:

AFAIK its not possible to type strings that can contain multiple values.
Unless, somehow, we create all the possible combinations of all tokens? (sounds like a terrible, terrible idea)
Say you have 4 space tokens: $1, $2, $3, $4
And you wanna add margin on all sides, you can do:
margin: "$2" // this passes validation, because its a single value in a string and its a token
Now you wanna set margin top/bottom and margin left/right
margin: "$2 $4" // As far as TS is concerned, this is still a single string so it cant offer you autocomplete
The only way would be to construct all the possible strings:
"$1"
"$2"
"$3"
"$4"
"$1 $1"
"$1 $2"
"$1 $3"
"$1 $4"
"$1 $1 $1"
"$1 $1 $2"
"$1 $1 $3"
"$1 $1 $4"
"$1 $1 $1 $1"
"$1 $1 $1 $2"
"$1 $1 $1 $3"
"$1 $1 $1 $4"
"$2 $1"
"$2 $2"
"$2 $3"
"$2 $4"
etc....

If I understand it correctly this new TypeScript feature may allow for typing the shorthands: https://github.com/microsoft/TypeScript/pull/40336

@drewbourne i thought so too, but after speaking briefly with @benoitgrelard it doesn't seem like it.
But we could be wrong.
If that feature works for us, that would be amazing!

At first glance I didn't think so, but yeah I could be totally wrong.
I'm not sure I understand it enough to be completely honest!
On a second look, it does seem that TS would be able to infer parts of a string (the Split example they give is quite telling for example: type T41 = Split<'foo.bar.baz', '.'>;  // ['foo', 'bar', 'baz'])
I need to take a deeper read…
Do we know if this is released or when it is due to be released?

@benoitgrelard I think it's now in v4.1.0-dev.20200911 https://www.npmjs.com/package/typescript/v/4.1.0-dev.20200911

Yes, typescript 4.1 supports this!

@dirtyrolf daaamn that is slick! Thanks for looking into it!


Add --ignoreProjects CLI argument to ignore test suites by project name

Summary
Add --ignoreProjects CLI argument to ignore test suites by project name
close https://github.com/facebook/jest/issues/12618

Test plan

Just thinking out loud. I am fine with the implementation, only not so sure if word ignore is describing the option well?
What about --omitProjects? Or perhaps --skipProjects? (A pair of --onlyProjects and --skipProjects might be a good choice, but perhaps that is unnecessary change.)

Just thinking out loud. I am fine with the implementation, only not so sure if word ignore is describing the option well?
What about --omitProjects? Or perhaps --skipProjects? (A pair of --onlyProjects and --skipProjects might be a good choice, but perhaps that is unnecessary change.)

@mrazauskas  I will vote for --ignoreProjects. jest already has an --testPathIgnorePatterns cli option. ignoreProjects will make cli option more consistent.
and ignore is used a lot more than the skip word in the javascript community.

thanks, I like it! can you add a changelog entry as well?

done.

https://github.com/facebook/jest/releases/tag/v28.0.0-alpha.8


[main] Upgrade to latest dependencies

prepare for release -nader-ziada
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/reconciler-test 55eab02...994f0c3:
  > 994f0c3 upgrade to latest dependencies (# 329)
  > 6da8e62 Update actions (# 327)
  > 0c8c4d7 upgrade to latest dependencies (# 328)

/retest


Fix Blas operations heading/link

The navigation at the top of the Quick Reference page was broken because of a typo in the Blas operations section of that page.
I wasn't able to run mkdocs build successfully, but fixing the typo should fix the navigation.

Thanks!


Document MongoDB Authenticatable class usage

This pull request adds missing guide for MongoDB Authenticatable class usage to the README.md

Codecov Report

Merging #2063 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2063   +/-   ##
=========================================
  Coverage     86.90%   86.90%
  Complexity      672      672
=========================================
  Files            31       31
  Lines          1558     1558
=========================================
  Hits           1354     1354
  Misses          204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1375cdd...7c6f5d6. Read the comment docs.


Add more command line options

Enhance the command-line interface with more options, like specifying which ports to skip or to scan only a specific range of ports.

@theinit01 can you please assign this to me?

@ShrutiKolla, sure I am assigning this issue to you.

@theinit01 i created a pull request. can you review it?


Add tests to compare source-built SDK to official SDK

These can probably be added to the smoke-testing section of the build.  Also add to the release checklist.

My super-quick tests that I used in https://github.com/dotnet/source-build/issues/1123 did:
diff -u <(cd "${DIR1}" && find | sort) <(cd "${DIR2}" && find | sort)

#1611 is a start on this.

[Triage] This was implemented in the 6.0 timeframe - https://github.com/dotnet/installer/blob/main/src/SourceBuild/tarball/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/SdkContentTests.cs


inference time on CPU take so long

I fine-tuning a classification model using bert, however the inference time on CPU is so long,
I run the inference process is so long. It takes nearly 15 seconds for one call (15s is only for prediction, not for loading the model). Below is the code for the inference:

print("time 10: ", datetime.datetime.now())
result = estimator.predict(input_fn=predict_input_fn)
print("time 11: ", datetime.datetime.now())
predicts = []
i = 0
for prediction in result:
    print("time 11-1: ", datetime.datetime.now())
    probabilities = [p for p in prediction["probabilities"]]

and here is the output of time:

time 10:  2019-02-11 13:06:25.594185
time 11:  2019-02-11 13:06:25.594229
time 11-1:  2019-02-11 13:06:39.175300

How we can serve faster ?
Thank you very much.

I think tensorflow estimators reload the graph during predictions (estimator.predict(input_fn=predict_input_fn)). Therefore, you may still be including model load time during predictions. Do confirm on this.
 If its too big you can chunk the passage and pass the most relevant chunk as
an input to the BERT model.

Thank you for your comment.

I think tensorflow estimators reload the graph during predictions (estimator.predict(input_fn=predict_input_fn)). Therefore, you may still be including model load time during predictions. Do confirm on this.

I think that is the reason for time-consuming. Do you have any idea to avoid this ?

 If its too big you can chunk the passage and pass the most relevant chunk as
an input to the BERT model.

My input length is 128. I think that is not too big.

You can try pytorch implementation of BERT from this repo: https://github.com/huggingface/pytorch-pretrained-BERT. I am not very comfortable in tensorflow.

adjust input length and layers deep can faster than before.

The idea I found is to export it as a static graph and use tensorflow serving to do the predictions. But am stuck onhow to export it. I get Couldn't find trained model at model  when using estimator.export_savedmodel

I have sold this issue by using estimator.export_savedmodel, however, although the inference time is reduced from ~10s --> ~1-2s/time however this number is difficult for a product. Do you have any ideas on how to use BERT in production?

can you elaborate what you did with estimator.export_savedmodel ? I am trying to do the inference stuck at "it's loading the graph everytime". I am using FLAGS.do_predict in run_classifier.py for inference.


Migrate to Glimpse

Migrate to GL2ES2 with shaders.
Use Glimpse for that purpose.

From glLineWidth documentation:

Only width 1 is guaranteed to be supported; others depend on the implementation.

For some users, line width will no longer work after migrating to GL2ES2. However, setting different line width seems less important than the benefits of using shaders.


create homepage

the home page

Could you please open an issue first please. Not clear what this PR is trying to solve.


Exception while debugging on VS Code

The bluebird is throwing exception while debugging on VSCode.
Exception has occurred: Error
Error
at Object. (/node_modules/bluebird/js/release/util.js:378:12)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at module.exports (/node_modules/bluebird/js/release/promise.js:14:12)
at Object. (***/node_modules/bluebird/js/release/bluebird.js:9:36)

Turn on long stack traces and show the error you get with them.
Promise.config({longStackTraces: true})

I am not using bluebird... it's being used by some third party

You can set the appropriate environment variable instead then: http://bluebirdjs.com/docs/api/environment-variables.html

@sharma02gaurav @benjamingr Any resolution?

@jainmitesh09 I don't know. It was a weird issue. Seems like package was broken or something. I re-clone my repository and installed dependency and after that It started working. Not a proper solution though but i don't know why?

@petkaantonov can you please update?

@sharma02gaurav turning off the breakpoints for all exceptions helps for now.

Turning off all breakpoints also resolved the issue for me.

if turnning off all breakpoints,,then debug is meanless,,,

Sorry @edward12699 I didn't explain that very well. The issue was caused by me clicking "Debug -> Enable All Breakpoints". To resolve the issue, I clicked "Debug -> Disable All Breakpoints" and then manually enabled the breakpoints I needed one at a time. Hope this helps!

It took a while for me to get that too. Thanks @jollifft !

Ran into this as well and was able to use the skipFiles option in the debug config to ignore all packages:
https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_skipping-uninteresting-code-node-chrome
I like this because it still allows me to debug with all exceptions. Hope this helps anyone else who has found their way here.


fix: formatting in debug window

Before:

After:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.415%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3681

Relevant Lines:
18298

💛  - Coveralls


Crash

Hi, Im trying with ios 9 simulator xcode 7.01 and ios 8 iphone 4s to share text to mail, and after mail displayed, it crashed, just calling socialShare.shareText("I love NativeScript!"); no I love Nativescript in the mail app too, just empty text
Is it just me ?
Edit:Share to copy text is working fine
Edit:In device now its working, simulator still crashes (weird) :)

Hey @x4080,
Sorry for the late response. Yeah this is a known thing that if you don’t have any email accounts setup on the iOS simulator it’ll just crash.
This shouldn’t be related to the plugin at all. If you try this on a physical device it should work. If you run into any other issues let me know.


When you logout, the app should recalculate the locale based on the browser settings instead of the logging-out user's

As mentioned by @jfresco on #835

Let's put this on hold until somebody actually complains about it.

:+1: @gvilarino

I can't even log out

@Istenais can you provide additional details?

I get these lines when I try to log out
democracyos:jwt Attempting to decode token... +48s
democracyos:jwt Token decoded successfully +18ms
democracyos:jwt Logging in user 555e3a40881b39b86badde2f +1ms
Basically when I click on "logout" website refreshes and it logins me back in.

Any additional info on what version of DemocracyOS you're using? That would help a lot. Try to run master and clear the database, and see if it happens again.

DemocracyOS version is 0.17.3
you can see live preview here http://tupodergt.com

May these cause problems? http://pastebin.com/jnr15FeY

@Istenais Seems to be other problem. You have one instance of the app running and you want to start another. Check if you have other terminal window or tab with an instance running. If you can't find it, restart your machine.

@jfresco thanks, I got rid of these errors except bson module, but that doesnt solve logout issue.

The BSON error isn't breaking, it's just that because of the OS you use, there is no available native implementation of BSON serializing and it will fall back to a software implementation.

@Istenais We are trying to solve the logout stuff. I think is already solved in the add/http-only branch, but it is not officially released yet. Thanks for the patience :-)

Great, thank you guys!


download cache error.

i install tlrc by homebrew on macos. When i input tldr fd , it show
info: cache is empty, downloading...
info: downloading 'tldr.sha256sums'... error: https://github.com/tldr-pages/tldr/releases/latest/download/tldr.sha256sums: Connection Failed: Connect error: SOCKS feature disabled.

how can i fix it?

It seems like SOCKS support is disabled by default in the HTTP client used by tlrc. I'll try to fix this later in a new release.
How did you configure the proxy?

I executed the export command in the shell. I did not add it to the .zshrc file.

So do I need to download in a shell without proxy configuration?

For now, this is the only way. I'll fix it in a new release.

So do I need to download in a shell without proxy configuration?

For now, this is the only way. I'll fix it in a new release.

thks.

Reopening the issue, as a reminder to fix it before the next release. (Note: It will be closed by the respective maintainer when committing the fix)

Fixed in https://github.com/tldr-pages/tlrc/commit/9abe507f85a76d121ccf428108fc1d9e85d443f9.


Cab url

@kevinrue, I modified the shortcode. URLs can be added to the title name by setting
paper: "bioc" and title_link: "http://bioconductor.org/about/community-advisory-board/" in the yaml (example in the files changed in this PR).


CHIPs Meeting: CHIP-8 (NFT royalty splitting) discussion

Time: September 26, 2022, 21:00 CEST / 15:00 EDT
Purpose: Community call to discuss CHIP-8
Audience: Any developers interested in the proposal for NFT royalty splitting
Zoom Link: TBD
Agenda:

~10 minutes: CHIP Walk through
~10 minutes: Alternative approaches
Remainder: Q/A regarding this CHIP

FYI the CHIP is located here: https://github.com/Chia-Network/chips/pull/30
Discuss this CHIP here: https://developers.chia.net/t/chip-0008-nft-royalty-splitting


OPEN LDAP Error

I found that when configuring the Auth model with OpenLDAP like when I create the Active Directory, the Redis base stops, and the application needs to restart. Also, is it not possible to connect users using OpenLDAP?

let's check for more details.

please activate OpenLDAP authentication and disable ActiveDirectory
please activate ActiveDirectory authenticaton and disable OpenLDAP


[Docs] Update installation docs to reference io.js instead of Node

It's pretty straightforward -- io.js is available through Homebrew so all you run is brew install iojs and then you can still run node from the command line. Also mentioned nvm since it's really good for switching between Node/io.js versions.
Docs for #1737

@brentvatne could you review and merge this when you have a chance?

lgtm @ide!


fix: replace web dev server with vite

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: replace d2-ui-core loading mask with ui-core component

This is WIP at the moment because the mask appears behind dashboard components and we are waiting for a fix to this (i.e, set z-index) in ui-core (issue: https://github.com/dhis2/ui-core/issues/217)

https://github.com/dhis2/ui-core/pull/223
This PR should resolve it. I linked it locally and seemed to work. Approve the PR if it works for you!

The latest from ui-core looks good. Just waiting for it to be published.

@jenniferarnesen 2.2.0 is published and should be ready to use.

Looks good now. One very minor issue (which I can fix with a style override) is that the material-ui Snackbar appears behind the overlay.


Add some EventRecorder events from jobset

What would you like to be added:
I noticed that the events generated by EventRecorder are not comprehensive enough. I plan to add more events in the controller, such as events for handling deletion errors or generating some common errors
Why is this needed:
The events generated by EventRecorder can be viewed for more critical events when executing kubectl describe jobset.

/assign

@danielvegamyhre @kannon92 Can I attempt to enhance this feature?

I'm not sure if the pod controller also needs the related events generated by EventRecorder. I don't think we would specifically look at the pods generated by the jobset.

What would you like to be added: I noticed that the events generated by EventRecorder are not comprehensive enough. I plan to add more events in the controller, such as events for handling deletion errors or generating some common errors Why is this needed: The events generated by EventRecorder can be viewed for more critical events when executing kubectl describe jobset.

I don't think an event for failing to delete a job is needed. Failing to create jobs is what we care about more; specifically, the first failed job which led to the jobset failing. We have an event emitted for this already.

@danielvegamyhre  I have also added events for the failure to delete a job and the failure to create a headless service. So, the meaning is to keep the latter and remove the former, right?

Done！thanks @danielvegamyhre @kannon92


update viewer version

:robot: please make sure all the checks pass before merging @Josmorsot @AdriSolid


Some improvements to integration test speeds

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test unit-tests_istio

integ-local-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test lint_istio

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test unit-tests_istio

integ-local-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-local-tests_istio

integ-telemetry-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test gencheck_istio

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test unit-tests_istio

integ-local-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-local-tests_istio

integ-telemetry-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
2d0c8678b5b36ab397e0c09d030df57e0b925962
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test unit-tests_istio

integ-local-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-local-tests_istio

integ-telemetry-k8s-tests_istio
2b671a4d6b7403042fe43d3c0effe634154c995b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
2d0c8678b5b36ab397e0c09d030df57e0b925962
link
/test lint_istio

gencheck_istio
2d0c8678b5b36ab397e0c09d030df57e0b925962
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Test times with this pr

distroless: 18min -> 13min
pilot: 27min -> 21min
security: 51min -> 31min

/cherrypick release-1.5

@howardjohn: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Do you still plan to remove the 10s sleep in the other CL? It's ok to do in different CL to track for stability.

maybe, I'll see if I can get it to query directly to see if it's applied. it has a fixed delay of 1min (since there is a few cases) which isn't too bad. I'll definitely do it in another PR though

@howardjohn: new pull request created: #21679

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn great work!


Occasional connection issues with the sandbox interpreter

Describe the bug
We've started seeing elevated rates of "Sandbox not found" exceptions from the past month. Here's the error trace:
SandboxException: Sandbox XXXXXX failed because it cannot be found
  File "threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
  File "e2b/sandbox/sandbox_connection.py", line 439, in _refresh
    raise SandboxException(

To Reproduce
A boiled down version of our code:
from e2b_code_interpreter import CodeInterpreter
code_interpreter = CodeInterpreter(api_key="XYZ", cwd=".", timeout=6000)
code_interpreter.notebook.exec_cell("print(1)", timeout=6000)

We're using the e2b-code-interpreter==0.0.3 SDK
Expected behavior
No "Sandbox not found" exceptions.
Additional context
This only happens very occasionally (<5 events per month) and so far we've been unable to track down anything in our code that may be causing this.

I recommend checking the Beta SDK (https://pypi.org/project/e2b-code-interpreter/0.0.11b10/) which reworked how sandbox connections work.
We have a migration guide here — https://e2b.dev/docs/guide/beta-migration


${WORKSPACE} is now /tmp/workspace/

I don't know when or how this changed from ./.jenkins-slave but it is now copying to this directory.
i have tried manually defining /home/ubuntu/.jenkins-slave but this fails as the directory does not exist

Hi @sce81, thanks for raising this. Thisbehavior was changed with #44 and released with version 3.0.1.
By specifying Remote Location in your instance configuration, you can change this from /tmp to any path you choose. workspace and job name are appended to the path by Jenkins. It looks like the documentation in the help file for this field is outdated so I will fix that. Thanks for bringing this to our attention.

great thanks.


mempool: Mempool constructor does not need to be async

The mempool object is initialized in a separate task, meaning the constructor itself does not need to be async.

Just checked and Clippy has a lint for this [1] but it's disabled by default.
[1] https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

It is interesting that the compiler doesn’t produce the “a function doesn’t need to be async” warning.

Just checked and Clippy has a lint for this [1] but it's disabled by default.
[1] https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Interesting, it does not seem to flag up anything for me, probably broken?

It is interesting that the compiler doesn’t produce the “a function doesn’t need to be async” warning.

Just checked and Clippy has a lint for this [1] but it's disabled by default.
[1] https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

It did work for us before. It made me remove a few asyncs from p2p


feat(home-manager): init wofi module

Adds support for wofi.
In case it matters, the Catppuccin GitHub organization declined taking the theme's repo because of how wofi is technically unmaintained: https://github.com/catppuccin/catppuccin/issues/2165.
The theme has a specific font hardcoded, so I took the liberty of making a font option for it for people that wish to override it.

In case it matters, the Catppuccin GitHub organization declined taking the theme's repo because of how wofi is technically unmaintained: https://github.com/catppuccin/catppuccin/issues/2165.

i'm going to have to agree with hammy here, as well as state that i don't think i'll be accepting unofficial ports into this repository anytime soon. i'll be adding this to the contribution guidelines now, as i would rather not have anyone spending time on these when they won't be accepted. i'm sorry i didn't have it there in the first place :(

Fair enough. Thanks anyways.