fix: update postgres image

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 62.759%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
7
7.94%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
4491

Relevant Lines:
7156

💛  - Coveralls

Just a question.
How can I use the latest docker image locally?
I want to use Pg15Image = "supabase/postgres:<IP_ADDRESS>" for test supabase/postgres#656 PR.
In this case, do I have to rewrite this cli on my own or wait for the release?

Hi @3ru I will merge this PR now so it will be available in our beta release channel in a few minutes.
Once released, you can use npx to install the beta version, for eg. npx supabase@beta help


Space Hub

Dear reviewer, we are a team of two
Here is the link to the project [https://github.com/osbentech/space-hub/projects/1]

Hello @Peter1907 and @osbentech          :wave: ,
I am Nemwel your reviewer for this PR :man_beard:
Thank you for meeting all the project requirements good job! :partying_face:
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! :partying_face: 🎉

Highlights
Great job setting up the correct linters ✔
Professional documentation ✔
Correct workflow ✔
Meaningful commit messages ✔
Met all the milestone requirements ✔
[Optional] suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Change emitted().someEvent to emitted('someEvent')

Hi,
Sorry for a lot of issues lately. vue test utils is getting heavy use in my project (that's good!).
I often have tests that check if an event was emitted with the correct arguments. For example, I click a button, and it emits some updated text. In that case, at the moment I do
wrapper.find('#caption-input').element.value = 'New caption')
wrapper.find('#caption-button').trigger('input')
expect(wrapper.emitted().captionChanged[0][0]).toBe('New caption')

Especially the [0][0] is a awkward to type and know what is going on.
What I would like to be able to do:
expect(wrapper.emitted('customEvent').toBeTruthy()

// and something like this for checking the emitted payload, not sure if payload is the right word here though
expect(wrapper.emitted('customEvent').payload.toEqual('newCaption')

If accepted I will make the PR.

I like this emitted('customEvent'), its fairly easy to implement and maybe more intuitive. However [a][b] notation is pretty standard.
you can create an helper to achieve what you want:
expect(hasPayload(wrapper.emitted('customEvent'), 'newCaption').toBeThruthy()

const hasPayload = (calls, payload) => {
// search trough your calls arrays to find your payload
}

I honestly would not recommend it because you want your components to always emit the same and brake if something change. In method, this payload detection is unaware of when he has been called
eg
wrapper.vm.$emit('foo')
wrapper.vm.$emit('foo', 123)
expect(hasPayload(wrapper.emitted('foo'), '123').toBeThruthy() // true

Then one of your dev mess up and actually change the order of emits
wrapper.vm.$emit('foo', 123)
wrapper.vm.$emit('foo')
expect(hasPayload(wrapper.emitted('foo'), '123').toBeThruthy() // still be true

==> No tests breaks while the behavior has changed
wdyt ?
That's my 2 cents :)

Hm, I did not think about the order. Say I want to have multiple emits, I guess it would look like:
// emit an event w/o payload
expect(wrapper.emitted('customEvent')[0]).toBeTruthy

// emit an event w/ payload
expect(wrapper.emitted('customEvent')[0].payload).toEqual('new caption')

I didn't know [a][b] notation was standard. For this case, I can see what we have [a] - there could be many emits. However for emits, do people ever have more than one arg? I tend to always emit an object in that case, with all the properties. I can't imagine a situation where you would do wrapper.emitted[0][1] - would that ever contain anything?
I still would prefer wrapper.emitted('foo')[0].payload to wrapper.emitted().foo[0][1], I think it's more intuitive. If there is a common notation like [a][b] though, convention > configuration.

Will get started on a PR if @eddyerburgh is okay with this feature :)

The reasoning behind the array is that you can tell what order the events were emitted in.
We can have both syntax, so I'd be happy for a PR that implements emitted('customEvent')

Hey, just an update, have made start, hopefully get a first PR up by this weekend.

#181 add this feature. :party:


Make "name" optional in config when driver = localstorage

I am trying to read key "counter" from localstorage, but can't, because it tries to read "/counter" if I set name to "". If I set name to "whatever" it reads "whatever/counter".
Can you change line 20 in localForage/src/drivers/localstorage.js from
dbInfo.keyPrefix = dbInfo.name + '/';
to something like
dbInfo.keyPrefix = (dbInfo.name && dbInfo.name != "") ? dbInfo.name + '/' : '';

I think that such change would be breaking.
We can discuss it for v2 probably.
So I would suggest such db inspections to be handle on the devs code using localstorage directly.

We could definitely accept either a PR like this or throw an error with empty names (my preference). Agree that it's a breaking change, but in this case I would say in the short term using empty values for configs is not a great idea, though our docs could be better at explicitly stating this.
If you wanted to update the docs that would be great, @NullIsNot0, if you have time. Thanks for filing this though!


Map screen

Added a map screen where the user can move his player icon over a map and choose  which of his created characters is linked to the icon. The icon maintains its position relative to the map when browser window is resized and map size changes.
Added basic CSS to the app
Refactored some code to improve readability
Token and form related functions moved to /utils

Closes #8

@w1000w

I think the commits could be slightly more atomic and seem to cover more features than needed. You may also want to separate styling to separate commits, it can be bit of a pain in the ass to read through the styling changes at times.

 I'm not approaching this project in an organized manner. There is no actual backlog and in my head I always want to add extra tasks when working with each feature. The styling of the app could have been done as an individual task in its own branch. It is often no small undertaking and takes a bit of experimentation.

Have you thought about using some prebuilt library for managing CSRF tokens? Could Flask's 'before_request' decorator help deal with the repeated calls to 'get_csrf_token()'?

No, I have been too focused on getting the features done to actually do some refactoring on those. I'll be sure to give it a look if I end up switching to Flask Blueprints.

Is there a particular reason event listeners are not being used here? Personally I find them easier to read and pick up from the code.
draggableElement.onmousedown = initiateDrag;

Yes. I haven't written JS in a while and wanted to do it as much from memory as possible. I also want to invoke as many comments on my coding style as possible so I'm not exactly trying to avoid unorthodox solutions and convolutions of habit.

For routing, Flask blueprints could make sense, especially if the programs continues to grow as it would allow you to modularize your code going forward.

Yeah, that point has been made earlier. Modularization is the way to go pretty much always, but for some reason I don't like the way Flask Blueprints work. Maybe because I don't want to fracture my routing... I might make this my next week's refactoring target though and leave the next feature for later.
Thanks for the comment!

Well, the previous commenter wrote pretty much everything that came to my mind as well. I'll still write my observations, but you don't have to respond to them, since I've already read the responses to the previous review myself.
The code is quite readable and well-structured, but I'm having trouble grasping the app's purpose from the README. The title hints at something for gamers, but the details are a bit elusive. I'm not an RPG player, so it might not be my cup of tea. Any chance we can get a bit more clarity in the README? Thanks a bunch!

My personal opinion: commits should be short :) if a commit message is so long that you have to expand it to get the gist of it, it's probably better to split it into a couple of commits. The second commit on the screenshot is the best!

Here it seems to be two different routes. You have defined the modify_character_get route twice with the same URL pattern. Should it be POST in a second route? What is the purpose of those route?
You use here the onmousedown

And here addEventListener

Why not just bring it to one view and use addEventListener when required for better flexibility and compatibility? Is there any particular purpose for using onmousedown and onmouseup specifically? I would also add window.onload here, but not sure about it.
And to wrap it up: great job! Really!

@elenabli

The code is quite readable and well-structured, but I'm having trouble grasping the app's purpose from the README. The title hints at something for gamers, but the details are a bit elusive. I'm not an RPG player, so it might not be my cup of tea. Any chance we can get a bit more clarity in the README? Thanks a bunch!

The purpose of the app is explained with the feature list but yes, it could also be in the initial description. I will look into changing it before merging to main.

My personal opinion: commits should be short :) if a commit message is so long that you have to expand it to get the gist of it, it's probably better to split it into a couple of commits. The second commit on the screenshot is the best!

That's also my view of the commit messages, but for the sake of DX I added more descriptive messages. Maybe it would be a good idea to fit a concrete "what was done" on the visible line and then the how and why can be viewed when expanded.

Here it seems to be two different routes. You have defined the modify_character_get route twice with the same URL pattern. Should it be POST in a second route? What is the purpose of those route?

Yeah, that's a lapse on my part. For some reason the GET that is supposed to be POST still works. Weird.

Why not just bring it to one view and use addEventListener when required for better flexibility and compatibility? Is there any particular purpose for using onmousedown and onmouseup specifically? I would also add window.onload here, but not sure about it.

Nah, it's just me being tired and trying to write JS without the help of any documentation. Don't remember anymore, but I'm pretty sure this choice was a quick patch to avoid some quirk in the functionality in the code. I might return to this when I start to work on the multiple user session.


Application type mismatch with _nested argument

Prerequisites

[X] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[X] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[X] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
The following code
namespace List
  def keys (pairs : List (α × β)) : List α
    := match pairs with
      | [] => []
      | ⟨a, _⟩ :: rest => a :: keys rest

  def values (pairs : List (α × β)) : List β
    := match pairs with
      | [] => []
      | ⟨_, b⟩ :: rest => b :: values rest
end List

inductive Term : Type where
  | var : String → Term
  | app : Term → Term → Term
  | lam : String → Term → Term
  | record : (entries : List (String × Term)) → (unique : entries.keys.Nodup) → Term

results in an error:
application type mismatch
  List.keys entries
argument has type
  _nested.List_1
but function has type
  List (String × Term) → List String

Context
People on Lean Zulip suggested to file a bug report.
Steps to Reproduce
Put the code above into VSCode editor, wait  for lean infoview to execute.
Expected behavior: The code should type check
Actual behavior: Error thrown
Versions
Lean version: 4.11.0-rc1

A somewhat related issue is #4824, where values in optParams aren't being updated when processing nesting. There's another solution in that case, but this issue is fixed first it's worth seeing if it closes that one as well.

I doubt that this issue will be fixed soon (besides, maybe, with a better error message), unless I am mistaken. This kind of nesting is hard™ to do.


Restored ThemeEditor.Zip, fixed README.md links

During commit 84ece79 the Theme Editor link was changed, rather than Review Tool link. I have uploaded the ThemeEditor.zip file to the correct path and changed both of the links within the README.md to now point correctly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: iAmManCat sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Crystal compiler not found after upgrade vscode to 1.26.0

Microsoft/vscode#56659
Hi! I got some issue when use this extension in vscode 1.26.0 or higher.
My crystal version is 0.26.0

Hi @TsumiNa, Do you still have this issue?

I'm having this issue on Debian with Code 1.35. I'm using asdf version manager to install crystal, but I did try including the absolute path to crystal in the settings and it didn't work

I'm having the same problem too. VSCode 1.34 with Crystal 0.28.0 (installed from Arch repos at /usr/bin/crystal). I've also tried changing the path in the settings to no avail.

@faustinoaq seems like this needs to be reopened.

@faustinoaq  Why didn't you commit this solution(https://github.com/crystal-lang-tools/vscode-crystal-lang/issues/86#issuecomment-462048696) to master branch yet? Is there any problems?

In my case, executing crystal env in crystalUtils.ts(js) caused an error like this.

Error: Command failed: /usr/local/bin/crystal env
Missing ENV key: "HOME" (KeyError)
from Path::home:Path
from Path#expand:Path
from File::expand_path:String
from Crystal::CacheDir#compute_dir:String
from Crystal::Command#run:(Bool | Crystal::Compiler::Result | Nil)
from main
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

When I add { cwd: ROOT, env: CRENV, stdio: ["ignore", "pipe", "pipe"] } as second argument of execSync, the error disappeared.


topolvm-controller is crashing due to 2 processes is failing to run

Error: failed to start container "csi-snapshotter": Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"/csi-snapshotter\": stat /csi-snapshotter: no such file or directory": unknown

Error: failed to start container "csi-attacher": Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"/csi-attacher\": stat /csi-attacher: no such file or directory": unknown

Kubernetes Version: 1.20.13
topolvm-operator Version: 2.2.0
topolvm-with-sidecar Version: 0.10

please use topolvm-operator Version: 2.3.0


Custom topic name upload

I guess It have so many commits to merge because branch master of pinterest/secor is ahead from chaordic/secor/master.

@zago

@giancarlosouza

@fabiomoreiragit

@vitoravancini


Angular 13 error

After upgrade rxjs 6 to 7
Error: src/app/_helpers/app.initializer.ts:8:18 -
error TS2345: Argument of type '(value: unknown) => void' is not assignable to parameter of type 'TeardownLogic'.
  Type '(value: unknown) => void' is not assignable to type '() => void'.

8             .add(resolve);
                   ~~~~~~~

Somebody know how to fix it?
Is there angular 13 version of this example?

I have same error. @cornflourblue Can you help me?

Have you try this?
// app.initializer.ts
import { AuthenticationService } from '@app/_services';

export function appInitializer(authenticationService: AuthenticationService) {
    // return () => new Promise(resolve => { // <-- Previus version
    return () => new Promise((resolve: any) => { // <-- Not the best solution but put a type of any
        // attempt to refresh token on app start up to auto authenticate
        authenticationService.refreshToken()
            .subscribe()
            .add(resolve);
    });
}

Pass a lambda:
export function appInitializer(authenticationService: AuthService) {
  return () =>
    new Promise((resolve) => {
      // attempt to refresh token on app start up to auto authenticate
      authenticationService
        .refreshToken()
        .subscribe()
        .add(() => resolve);
    });
}


Update to use torch.nn.attention.sdpa_kernel

The main reason I didn't do this previously is worry that this'll cause the code to hard break on older versions. When was this new API added?

It added two months ago (https://github.com/pytorch/pytorch/commit/4e29f01bf2edfe40d6fb8b38228199185645b6af). I understand the concern, don't have strong opinion on changing this.


load more..

as a user I want to quickly get to the Zimbabwe link by loading more country links in the sidebar
Currently we only load 10 more. It therefore takes a long time before we get to Zimbabwe.
change the load more to..
20
load all

the % complete is not loading.  lets group the alphabet into five groupings.
http://www.java-forums.org/new-java/52953-sort-list-alphabetically-split-into-groups-e-f-j.html
I think we will need to place these links horizontally below '175389 healthsites listed'
@MariaSolovyeva lets have a call and discuss the layout of this sidebar.


Pre-built tool list

Issue with current documentation:
I haven't been able to find any documentation on a comprehensive list of pre-built tools available on Langchain, for example, there is nothing in the documentation that suggests we're able to load the "llm-math" tool?
Idea or request for content:
It would be good to have a list of all pre-built tools!

hii @florence26 I want to work on this please assign this to me
thank you...


Docs online for format missing /NoTrim flag

Using the format command line, I see there is a flag called /NoTrim with the following help text:
/NoTrim         Skip sending trim (delete notification) during format.
I did not see an entry for /NoTrim in the format documentation.
(I am running Windows 11 version 22H2 (OS Build 10.0.22621.1702.)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c9fbdba6-cfee-e68d-e1a9-e97d09f0cfad
Version Independent ID: 26f12948-5d6d-41c2-21ac-538da6e25f7a
Content: format
Content Source: WindowsServerDocs/administration/windows-commands/format.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Hey paulfwilliams,
Thanks again for contacting Microsoft. We value your feedback.
A documentation change has been made adding the following parameters:

/NoTrim
/SHA256Checksums
/Y

Changes will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.
#please-close


"*_actions.rs" in "target" should be always regenerated

Reproduction
Create these files in some test dir:
Cargo.toml:
[package]
name = "test-proj"
version = "0.1.0"
edition = "2021"

[build-dependencies]
rustemo-compiler = "0.6.0"

[dependencies]
colored = "2.1.0"
once_cell = "1.19.0"
regex = "1.10.5"
rustemo = "0.6.0"

build.rs:
fn main() {
    rustemo_compiler::Settings::new()
        .process_dir().unwrap();
}

src/a.rustemo:
A: foo;

terminals
foo: "abc";

src/main.rs:
rustemo::rustemo_mod!(a, "/src");
rustemo::rustemo_mod!(a_actions, "/src");

fn main() {
    use rustemo::Parser;
    println!("{:#?}", a::AParser::new().parse("").unwrap());
}

Make sure nothing else exists in the dir. In particular, make sure there is no target dir.
Now run cargo build. Everything will build successfully (modulo some warnings). Then replace all foos with bars in src/a.rustemo, i. e. you should get this:
A: bar;

terminals
bar: "abc";

Now, without removing target, run cargo build. You will see this error message (I ommited warnings):
error[E0599]: no variant or associated item named `bar` found for enum `A` in the current scope
  --> /tmp/test-proj/target/debug/build/test-proj-5f0af2ed166c1a89/out/src/a_actions.rs:17:8
   |
10 | pub enum A {
   | ---------- variant or associated item `bar` not found for this enum
...
17 |     A::bar
   |        ^^^ variant or associated item not found in `A`

For more information about this error, try `rustc --explain E0599`.
warning: `test-proj` (bin "test-proj") generated 4 warnings
error: could not compile `test-proj` (bin "test-proj") due to 1 previous error; 4 warnings emitted

Now remove target and run cargo build again. Everything will be built successfully.
So, we see that rm -r target is needed to build project. This never should be necessary.
I thing the reason is so: rustemo doesn't regenerate a_actions.rs (despite a_actions.rs is located in target). I think this is wrong, because this behavior necessitates using of rm -r target. So, if *_actions.rs is located in target, then always regenerate it

To regenerate all action files, I think we can use force(true) in rustemo_compiler::Settings. For example, in build.rs, use the following code:
fn main() {
    rustemo_compiler::Settings::new()
        .force(true)
        .process_dir()
        .unwrap();
}

This should solve the problem mentioned in the post.

@fogarecious , yes, but anyway I think current behavior is a bug. force(true) should be applied. rm -r target should never be needed

I agree. This should be treated as a bug as the product of parser compilation should not depend on what is already in the target folder. Until the bugfix is released @fogarecious workaround can be used.


[Bluetooth Remote Control] HID report map parsing

Enable key input notifications (may be multiple) based on information from the HID report map.

https://jenkins.code.rdkcentral.com/job/github-triggered/1267/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1270/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1275/ started


StringRouteConstraint implementation

related aspnet/MVC#4846
@rynowak @Eilon

Hi @iscifoni, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

A few small comments, overall looks good :+1:

:up: :date:

:up: :date:

:shipit: - looks good, I'll merge

88de3d50703dd9f697df9fd4654f2a1157bcd3a3

FYI - build 21795 and later will have this change

Ok thanks


Add hero section to browse boats

A small-ish gallery and some text would improve the UX on first entry.

added text


missing frfuel.net.dll

Same, I'm missing the frfuel.net.dll :/

Hello there, the developers put multiple downloads and versions of V 1.7.0. I'm guessing you're going off the many tutorials on YouTube, and that download can be found here. [https://github.com/thers/FRFuel/releases/download/v1.8.0/frfuel_v1.7.0.zip]


Add public accessor methods to Point

When writing tests for projects that use influxdb-java I've found myself wanting to be able to access the fields on a Point object.  This adds public accessor methods to allow doing so.

Hi @ajsquared
Thanks for interest and contribution to influxdb-java.
Adding public methods for testing only is a weak argument, i prefer narrow APIs with the least necessary visibility to keep it side effect free as possible.
For testing the resulting lineprotocol is visible which is the only purpose of a point object. You can either test againts this, or use reflection to access the properties in you tests.
Greetings
Stefan

Okay, that's fair enough.  Thanks!


Add javascript boilerplate code to plugin generator

Example: rails generate manageiq:plugin MyPlugin --js
Fixes https://github.com/ManageIQ/manageiq/issues/21851

Files like yarn.lock and .yarn/releases/* look like they should be generated rather than templated.  @Fryguy what yarn commands would have to be run to set this up properly?  When running just yarn install I get a failure about .yarn/releases/yarn-3.0.2.cjs not existing so think there is more to it

I can go over the yarn commands with you... Can we run arbitrary commands after install as part of the generator?

Can we run arbitrary commands after install as part of the generator?

We haven't to date, but I was going to try and see if it works

Files like yarn.lock and .yarn/releases/* look like they should be generated rather than templated. @Fryguy what yarn commands would have to be run to set this up properly? When running just yarn install I get a failure about .yarn/releases/yarn-3.0.2.cjs not existing so think there is more to it

As discussed, we should commit .yarn/releases/yarn-3.0.2.cjs and yarn.lock because that's how .yarn works.

Yarn install runs in the generated plugin with no local changes after:
$ yarn install
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done in 0s 38ms
adam@desktop:~/src/manageiq/manageiq/plugins/my_plugin$ git status
On branch master
nothing to commit, working tree clean


Packages in Gallery appear as not indexed

We are seeing a strange behavior that some old packages in the Gallery appear as not indexed.

Rollback mitigated the issue.

@skofman1 would be cool to include the commit as well as the PR


@material-ui/styles dependency missing

This example app requires @material-ui/styles to run with both yarn and npm after initial download

Dependency is listed in _document.tsx line 5 import { ServerStyleSheets } from '@material-ui/styles'

The dependency was not listed in package.json and wouldn't run until installed.
This pull request resolves this issue and allows the app to run on initial clone & install.

[x] I have followed (at least) the PR section of the contributing guide.

Issue is a continuation of #26567 as removal of the import of this package causes app to crash.

Thanks for looking into this issue. How about instead of this, we remove everything related to JSS from the examples? We could do the following:
index 3ccbbc0a2a..b8aa2095b1 100644
--- a/examples/nextjs/pages/_app.js
+++ b/examples/nextjs/pages/_app.js
@@ -12,14 +12,6 @@ export const cache = createCache({ key: 'css', prepend: true });
 export default function MyApp(props) {
   const { Component, pageProps } = props;

-  React.useEffect(() => {
-    // Remove the server-side injected CSS.
-    const jssStyles = document.querySelector('#jss-server-side');
-    if (jssStyles) {
-      jssStyles.parentElement.removeChild(jssStyles);
-    }
-  }, []);
-
   return (
     <CacheProvider value={cache}>
       <Head>
diff --git a/examples/nextjs/pages/_document.js b/examples/nextjs/pages/_document.js
index 1fd49465fe..465288344d 100644
--- a/examples/nextjs/pages/_document.js
+++ b/examples/nextjs/pages/_document.js
@@ -2,7 +2,6 @@ import * as React from 'react';
 import { CacheProvider } from '@emotion/react';
 import createCache from '@emotion/cache';
 import Document, { Html, Head, Main, NextScript } from 'next/document';
-import { ServerStyleSheets } from '@material-ui/styles';
 import createEmotionServer from '@emotion/server/create-instance';
 import theme from '../src/theme';

@@ -59,8 +58,6 @@ MyDocument.getInitialProps = async (ctx) => {
   // 3. app.render
   // 4. page.render

-  // Render app and page and get the context of the page with collected side effects.
-  const sheets = new ServerStyleSheets();
   const originalRenderPage = ctx.renderPage;

   const cache = getCache();
@@ -68,7 +65,6 @@ MyDocument.getInitialProps = async (ctx) => {

   ctx.renderPage = () =>
     originalRenderPage({
-      enhanceApp: (App) => (props) => sheets.collect(<App {...props} />),
       // Take precedence over the CacheProvider in our custom _app.js
       enhanceComponent: (Component) => (props) =>
         (
@@ -94,7 +90,6 @@ MyDocument.getInitialProps = async (ctx) => {
     // Styles fragment is rendered after the app and page rendering finish.
     styles: [
       ...React.Children.toArray(initialProps.styles),
-      sheets.getStyleElement(),
       ...emotionStyleTags,
     ],
   };

And revert back the changes done in package.json. We should do this for the other SSR examples, like nextjs-with-typescript, ssr, gatsby etc.

Duplicate of #26567


Pocketbook EPUB viewer 3 crash

When I access certain parts of the omnivore epub using the default pocketbook viewer (3), the viewer crashes. I can mitigate this crash by opening it in the epub 2 viewer. I'm on a pocketbook era with software U7<IP_ADDRESS>11
Steps to reproduce crash:

Add this article to your omnivore library.
Make and move epub to pocketbook era.
Attempt to view that section of the epub.

Maybe there's something corrupted in the epub in that section, or maybe the pocketbook reader has a bug.
If you need someone with the device to test a fix, I'd be happy to help!

Thanks for reporting the issue.
I am unable to reproduce this on my 11th gen Kindle Basic and am able to read the article without issues.
The most likely cause I can come up with is pocketbook having trouble displaying long, unsplit chapters. To confirm whether this is the case, can you try to load some huge article and see if it works. Something like Gulliver’s Travels | Project Gutenberg should do.
In the article you linked, there is a dead link to an image. There is a chance pocketbook crashes because it's trying to render a non-existent image. To test this, can you set allowImages in the config to false and try again.
My kindle handles both cases without issues so I am unable to test it further.

Gulliver's Travels works. In addition, turning off images seemed to help, but when I turned on images again, the entire file works somehow.
There's a chance that I was running into a PocketBook issue. The device doesn't seem to enjoy me updating books that I've already opened on the device. Even after pushing an updated epub to the tablet, the tablet shows the old version of the epub. The Pocketbook is caching my epubs. Maybe things get corrupted when the cached version doesn't match the one in files.
More info:
The tablet makes a cached copy of epubs which have been opened in /system/state/optimize/. Deleting the specific file's cache when I update the epub seems to fix all issues I've been having. This could be a useful tip to include in the readme, if it's in-scope for the project to include advice like this.

Update:
On some versions of the file, it still crashes. I haven't gotten a crash with images turned off, but also, crashes have occurred on pages without images. I'll see if I can troubleshoot this problem any further.
If the issue turns out to be bad image links, do you think it would be possible to remove those when making the epub?

Maybe you could open a support ticket with Pocketbook as well? I think their reader shouldn't crash. Hopefully they can fix it.
I use Koreader on my Pocketbook. I can highly recommend it in general and did not have any problems on my Pocketbook with epub files created from this script.

@TylerLaBree The library I am using to generate epub files (epub-gen-memory) does have an option to throw an error for bad image links. But I have set it to ignore errors because too many articles have dead links and it didn't seem like a good idea to terminate the program because a certain link is unreachable. The relevant section is below. But it doesn't seem to have an option to detect and selectively remove bad links.
diff --git a/main.ts b/main.ts
index f1c1500..e88b79d 100644
--- a/main.ts
+++ b/main.ts
@@ -198,7 +198,7 @@ async function makeEbook() {
       author: config.author,
       cover: config.cover,
       description: config.description,
-      ignoreFailedDownloads: true,
+      ignoreFailedDownloads: false,
     },
     chapters,
   );

Including details about PocketBook internals does seem fairly out of scope, but I am not opposed to including it if it seems to be a recurring issue.
I agree with @sascharucks that reporting it to PocketBook might be the best option here.
I too would use koreader on my Kindle if amazon was not determined to make it more locked down than iphones 😞.

Closing this issue since there haven't been any more reports for this.


Admin UI Not Showing All Servers

Hello there,
I have implemented my Socket.io server using multiple nodes. My script starts 4 Socket.io servers at a time, and all these servers are connected via the MongoDB adapter. An Nginx server works as a reverse proxy between my servers and the users, and my clients are connecting to my server using the WebSocket transport because the Nginx sticky sessions never worked for me for whatever reason. Due to the shortage of time, I skipped setting up the sticky sessions at that moment and proceeded with only WebSocket transport.
One other thing worth mentioning here is that my local development server, and the production server, both are connected to the same capped collection of MongoDB for listening to the adapter events.
Now the problem is, whenever I try to connect Admin UI with my Socket.io server, it connects successfully. But it only shows me stats for that one specific instance of Socket.io server with which Admin UI is connected. To my surprise, I see my local development (Socket.io) server, when it is running locally, listed in the list of servers. Although I connect my Admin UI specifically with the URL of my production app URL.
Can you please help me figure out what is happening here? Why my all production servers are not being listed in Admin UI, and why am I seeing my local dev server in the list of production servers?

You might need to customize the serverId attribute of the server: https://socket.io/docs/v4/admin-ui/#serverid
Regarding your dev server, I don't think this is a good idea to use the same collection for both environments.

Hey, thanks for the tip @darrachequesne. It worked by just adding this serverId attribute. Now one other concern is this:

As you can see, both of my servers have the same number of clients. When I looked at the list of connected sockets, I had sockets connecting from the same IPs:

Does this mean that all of my clients are connected with all the available servers? I'm using the websocket transport to connect to my server.

If I recall correctly Nginx load-balances the requests in a round-robin fashion by default, so that should explain the fact that there is more or less the same number of clients on all servers.
Regarding the duplicate IPs, maybe some users have multiple browser tabs (one WebSocket connection per tab)?


showing UserProfileMenu on hovering name in appbar

Codecov Report
Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (664fa7d) to head (40ca175).

Files
Patch %
Lines

...ompliance-web/src/components/Shared/CopyButton.tsx
22.22%
7 Missing :warning:

...nce-web/src/components/Shared/Header/EAOAppBar.tsx
50.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #6      +/-   ##
===========================================
+ Coverage    41.34%   41.81%   +0.47%
===========================================
  Files           35       37       +2
  Lines          312      330      +18
  Branches        59       61       +2
===========================================
+ Hits           129      138       +9
- Misses         170      192      +22
+ Partials        13        0      -13

Flag
Coverage Δ

compliance-web
41.81% <47.36%> (+0.47%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Pure Java implementation

The current version is implemented by using GraalVM and an existing JavaScript implementation. This causes troubles with other JVMs, such as the Eclipse OpenJ9 VM: https://github.com/eclipse/openj9/issues/11555.
This issue tries to make the desire of a pure Java implementation explicit. Maybe, it helps to shape a project tackling this wish.
Side note: There are transpilers from Java to JavaScript available (e.g., jsweet or j2cl), however, there is no JavaScript to Java transpiler (cf. https://awesomeopensource.com/projects/transpiler).
Also refs https://github.com/JabRef/jabref/issues/5622#issuecomment-590334280.

@koppor The pure Java version already exists. It's called "experimental" mode and is available in the latest snapshot. As far as I know we've already integrated this snapshot in JabRef and enabled experimental mode, haven't we? If yes, and if the results look OK, I can of course release a final version of it if you wish.

@koppor The pure Java version already exists. It's called "experimental" mode and is available in the latest snapshot. As far as I know we've already integrated this snapshot in JabRef and enabled experimental mode, haven't we? If yes, and if the results look OK, I can of course release a final version of it if you wish.

I totally forgot about the status. Yes, we integrated it and had no complains.
I digged into the dependencies. The tree shows as follows. org.graalvm should be obsolete now, shouldn't it? Does it require a separte branch to remove that (e.g., https://github.com/michel-kraemer/citeproc-java/blob/5d119ecde0e21b53e217be33730fa3dd8901c99c/citeproc-java/build.gradle#L25) or should we do it with gradle dependency management magic? I would prefer to remove the whole depedency in the current implementation to have a clean state. Maybe, a call for releasing a 3.0 version, even though it's "only" an internal dependency change?
+--- de.undercouch:citeproc-java:2.1.0-SNAPSHOT
|    +--- org.apache.commons:commons-lang3:3.9
|    +--- org.apache.commons:commons-text:1.8
|    |    \--- org.apache.commons:commons-lang3:3.9
|    +--- org.jbibtex:jbibtex:1.0.17
|    +--- org.antlr:antlr4-runtime:4.7.2 -> 4.9
|    +--- org.graalvm.sdk:graal-sdk:19.2.1
|    \--- org.graalvm.js:js:19.2.1
|         +--- org.graalvm.regex:regex:19.2.1
|         |    \--- org.graalvm.truffle:truffle-api:19.2.1
|         |         \--- org.graalvm.sdk:graal-sdk:19.2.1
|         +--- org.graalvm.truffle:truffle-api:19.2.1 (*)
|         +--- org.graalvm.sdk:graal-sdk:19.2.1
|         +--- org.ow2.asm:asm:6.2.1
|         +--- org.ow2.asm:asm-tree:6.2.1
|         |    \--- org.ow2.asm:asm:6.2.1
|         +--- org.ow2.asm:asm-analysis:6.2.1
|         |    \--- org.ow2.asm:asm-tree:6.2.1 (*)
|         +--- org.ow2.asm:asm-commons:6.2.1
|         |    +--- org.ow2.asm:asm:6.2.1
|         |    +--- org.ow2.asm:asm-tree:6.2.1 (*)
|         |    \--- org.ow2.asm:asm-analysis:6.2.1 (*)
|         +--- org.ow2.asm:asm-util:6.2.1
|         |    +--- org.ow2.asm:asm:6.2.1
|         |    +--- org.ow2.asm:asm-tree:6.2.1 (*)
|         |    \--- org.ow2.asm:asm-analysis:6.2.1 (*)
|         \--- com.ibm.icu:icu4j:62.1

I totally forgot about the status. Yes, we integrated it and had no complains.
I digged into the dependencies. The tree shows as follows. org.graalvm should be obsolete now, shouldn't it? Does it require a separte branch to remove that (e.g., https://github.com/michel-kraemer/citeproc-java/blob/5d119ecde0e21b53e217be33730fa3dd8901c99c/citeproc-java/build.gradle#L25) or should we do it with gradle dependency management magic? I would prefer to remove the whole depedency in the current implementation to have a clean state. Maybe, a call for releasing a 3.0 version, even though it's "only" an internal dependency change?
+--- de.undercouch:citeproc-java:2.1.0-SNAPSHOT
|    +--- org.apache.commons:commons-lang3:3.9
|    +--- org.apache.commons:commons-text:1.8
|    |    \--- org.apache.commons:commons-lang3:3.9
|    +--- org.jbibtex:jbibtex:1.0.17
|    +--- org.antlr:antlr4-runtime:4.7.2 -> 4.9
|    +--- org.graalvm.sdk:graal-sdk:19.2.1
|    \--- org.graalvm.js:js:19.2.1
|         +--- org.graalvm.regex:regex:19.2.1
|         |    \--- org.graalvm.truffle:truffle-api:19.2.1
|         |         \--- org.graalvm.sdk:graal-sdk:19.2.1
|         +--- org.graalvm.truffle:truffle-api:19.2.1 (*)
|         +--- org.graalvm.sdk:graal-sdk:19.2.1
|         +--- org.ow2.asm:asm:6.2.1
|         +--- org.ow2.asm:asm-tree:6.2.1
|         |    \--- org.ow2.asm:asm:6.2.1
|         +--- org.ow2.asm:asm-analysis:6.2.1
|         |    \--- org.ow2.asm:asm-tree:6.2.1 (*)
|         +--- org.ow2.asm:asm-commons:6.2.1
|         |    +--- org.ow2.asm:asm:6.2.1
|         |    +--- org.ow2.asm:asm-tree:6.2.1 (*)
|         |    \--- org.ow2.asm:asm-analysis:6.2.1 (*)
|         +--- org.ow2.asm:asm-util:6.2.1
|         |    +--- org.ow2.asm:asm:6.2.1
|         |    +--- org.ow2.asm:asm-tree:6.2.1 (*)
|         |    \--- org.ow2.asm:asm-analysis:6.2.1 (*)
|         \--- com.ibm.icu:icu4j:62.1

My proposal would be to release both 2.1.0 (still with GraalVM for people who still want to use it) and 3.0 (with the pure Java experimental mode promoted to the default and GraalVM removed). If you like I can try to release the new version as soon as possible (maybe on the weekend or some time next week).

My proposal would be to release both 2.1.0 (still with GraalVM for people who still want to use it) and 3.0 (with the pure Java experimental mode promoted to the default and GraalVM removed). If you like I can try to release the new version as soon as possible (maybe on the weekend or some time next week).

I would be very happy if you could release a 3.0.0-SNAPSHOT. This would really simplify our solution. And probably also unblock https://github.com/JabRef/jabref/pull/7126#issuecomment-735433801 (caused by too many dependencies in our module)

I would be very happy if you could release a 3.0.0-SNAPSHOT. This would really simplify our solution. And probably also unblock https://github.com/JabRef/jabref/pull/7126#issuecomment-735433801 (caused by too many dependencies in our module)

I just published a first 3.0.0-SNAPSHOT without GraalVM dependencies:
https://oss.sonatype.org/content/groups/public/de/undercouch/citeproc-java/3.0.0-SNAPSHOT/
Please test and let me know if there are any problems.

I just published a first 3.0.0-SNAPSHOT without GraalVM dependencies:
https://oss.sonatype.org/content/groups/public/de/undercouch/citeproc-java/3.0.0-SNAPSHOT/
Please test and let me know if there are any problems.

It's in JabRefs main branch now. In case we experience issues, we will report back. Thank you for the quick action taken! 🎉

It's in JabRefs main branch now. In case we experience issues, we will report back. Thank you for the quick action taken! 🎉

@michel-kraemer Would it be possible to create a 3.0.0-alpha release or similar? Since the constructor changed in the SNAPSHOT release (which is OK for a snapshot), there were build issues at JabRef. See the discussions at https://github.com/JabRef/jabref/pull/7514. I think, it might be too early for a 3.0.0 release, but maybe a tagged release could be possible? This would help us to get a reproducible build.

@koppor Sure, no problem. I've just released version 3.0.0-alpha.1


add a bit of info

Actually I don't know for sure all the steps. Can someone complete ?

Coverage report

This PR does not seem to contain any modification to coverable code.


Spyder 3.1.2 cannot connect to kernel as 3.0.2

I can choose the file directory to connect to a kernel like "kernel-100.json",
but when I just type 100, It shows that cannot connect to kernel, however this can be done in spyder 3.0.2

@mariacamilaremolinagutierrez, this is a regression over our previous behavior. Please fix it.


#52 Refactor of setting to use new error type/handling

New generic type used throughout settings, gets rid of FatalProviderError type.
FatalProviderError is replaced with a new interface called Error
type Error interface {
	error
	MissingKeys() []string
	FatalError() error
}

This Error interface is used by the ProviderError struct and which is seen throughout the Settings package.
The aim of removing FatalProviderError was to get rid of situations where errors needed to be casted to decipher whether the error thrown was indeed fatal or "simple" e.g:
	if fatalProviderError, isFatal := err.(FatalProviderError); isFatal {
		// if the error is fatal, propagate it back up
		return map[string]Setting{}, fatalProviderError
	}

Tests have been modified inline with the original implementation but for swapping out the new type and associated functions.
Much of the surrounding code around the error's has been left untouched but if any changes are requested I'm happy to pick up in a separate issue.
p.s. Apologies for the big PR!

@alessandrozucca and @alasdairlaw updates pushed as requested. Let me know if there is anything else.

Closes #52


Enable adjustments of calculated heights in beforeToggle hook

See https://github.com/jedfoster/Readmore.js/issues/243
This is only meant as a workaround, it gives you the option to overwrite element.readmore properties in the beforeToggle hook, which will then be used to set the new height.

Closing this PR since we're not using Readmore.js anymore.


python3Packages.pylint: 2.10.2 -> 2.11.1

python3Packages.pylint: 2.10.2 -> 2.11.1

python3Packages.astroid: 2.7.3 -> 2.8.2
python3Packages.python-lsp-server: unlock pylint

pylint upgrade came up as a dependency of fixing spyder for Python38. As this seems a change with large effects. I'll try to avoid this. [Back to drawing board.]

Pylint and astroid are already part of #141037.

❯ nom-build -A python3Packages.spyder
error: python-language-server-0.36.2 not supported for interpreter python3.9

Pretty sure python-language-server still does not support python3.9 (and jedi 18.0), so the situation is bad.

You can try to fix it based on python-unstable if you like, but it's only going to open for a few more hours before it hits staging.


remove old (pdf) version of Diglab

Pull Request Test Coverage Report for Build 957411934

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 89.189%

Totals

Change from base Build 946347813:
-0.1%

Covered Lines:
264

Relevant Lines:
296

💛  - Coveralls


npm install, the dependencies resolve failed

看起来是 node 16 和 npm8 才会出现，请拉一下 main 分支的代码再试试？

先用 npm i --legacy-peer-deps 安装下，npm8 导致有一些依赖需要升级

npm install 成功了，但是 npm run build 失败了
npm run build

> build
> rimraf -rf ./app && rimraf -rf ./out && run-p build:*

> build:browser
> webpack --config ./build/webpack.browser.config.js

> build:main
> webpack --config ./build/webpack.main.config.js

> build:node
> webpack --config ./build/webpack.node.config.js

> build:webview
> webpack --config ./build/webpack.webview.config.js

> build:extension
> webpack --config ./build/webpack.extension-host.config.js

asset host-preload.js 22.3 KiB [emitted] (name: main)
asset plain-preload.js 1.35 KiB [emitted] [from<EMAIL_ADDRESS>[copied]
modules by path<EMAIL_ADDRESS>2.12 KiB
<EMAIL_ADDRESS>54 bytes [built] [code generated]
<EMAIL_ADDRESS>2.07 KiB [built] [code generated]
modules by path<EMAIL_ADDRESS>15.2 KiB
<EMAIL_ADDRESS>12.6 KiB [built] [code generated]
<EMAIL_ADDRESS>2.57 KiB [built] [code generated]
external "electron" 42 bytes [built] [code generated]
webpack 5.72.1 compiled successfully in 150 ms
asset index.js 1.72 MiB [emitted] (name: main) 1 related asset
runtime modules 793 bytes 4 modules
modules by path ./node_modules/ 1.54 MiB
  cacheable modules 1.54 MiB 339 modules
  ./node_modules/yargs/ sync 160 bytes [built] [code generated]
  ./node_modules/yargs/build/ sync 160 bytes [built] [code generated]
  ./node_modules/yargs-parser/build/ sync 160 bytes [built] [code generated]
modules by path ./src/ 11.3 KiB
  modules by path ./src/main/ 9.37 KiB
    modules by path ./src/main/*.ts 7.39 KiB 3 modules
    modules by path ./src/main/services/*.ts 1.99 KiB 2 modules
  modules by path ./src/common/ 1.94 KiB
    ./src/common/types.ts 150 bytes [built] [code generated]
    ./src/common/node/utils.ts 1.1 KiB [built] [code generated]
    ./src/common/constants.ts 706 bytes [built] [code generated]
+ 17 modules

WARNING in ./node_modules/yargs/build/index.cjs 1:60106-60113
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
<EMAIL_ADDRESS>5:16-32
<EMAIL_ADDRESS>4:21-37
<EMAIL_ADDRESS>5:21-43
 @ ./src/main/launch.ts 8:33-76
 @ ./src/main/index.ts 6:17-36

WARNING in ./node_modules/yargs/build/index.cjs 1:60498-60505
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
<EMAIL_ADDRESS>5:16-32
<EMAIL_ADDRESS>4:21-37
<EMAIL_ADDRESS>5:21-43
 @ ./src/main/launch.ts 8:33-76
 @ ./src/main/index.ts 6:17-36

WARNING in ./node_modules/yargs/index.cjs 12:39-46
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>5:16-32
<EMAIL_ADDRESS>4:21-37
<EMAIL_ADDRESS>5:21-43
 @ ./src/main/launch.ts 8:33-76
 @ ./src/main/index.ts 6:17-36

3 warnings have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.72.1 compiled with 3 warnings in 1666 ms
asset index.js 6.8 MiB [emitted] (name: main) 1 related asset
runtime modules 1.04 KiB 5 modules
javascript modules 5.29 MiB
  modules by path ./node_modules/ 5.28 MiB
    cacheable modules 5.28 MiB 1016 modules
    + 5 modules
  modules by path ./src/ 10.9 KiB 6 modules
  + 31 modules
json modules 925 KiB
  modules by path ./node_modules/har-schema/lib/ 6.93 KiB 18 modules
  modules by path ./node_modules/iconv-lite/ 86.7 KiB 8 modules
  modules by path ./node_modules/ajv/lib/ 5.58 KiB 3 modules
  modules by path ./node_modules/@opensumi/ 5.63 KiB
<EMAIL_ADDRESS>4.04 KiB [built] [code generated]
<EMAIL_ADDRESS>1.59 KiB [built] [code generated]
  + 6 modules

WARNING in<EMAIL_ADDRESS>292:25-32
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>13:32-57
<EMAIL_ADDRESS>11:35-72
 @ ./src/node/index.ts 12:15-58

WARNING in ./node_modules/chrome-remote-interface/node_modules/ws/lib/BufferUtil.js 35:21-42
Module not found: Error: Can't resolve 'bufferutil' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/chrome-remote-interface/node_modules/ws/lib'
Did you mean './bufferutil'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
 @ ./node_modules/chrome-remote-interface/node_modules/ws/lib/Receiver.js 13:19-42
 @ ./node_modules/chrome-remote-interface/node_modules/ws/index.js 12:21-46
 @ ./node_modules/chrome-remote-interface/lib/chrome.js 7:18-31
 @ ./node_modules/chrome-remote-interface/index.js 6:15-41
 @ ./node_modules/v8-inspect-profiler/index.js 10:12-46
<EMAIL_ADDRESS>32:81-111
<EMAIL_ADDRESS>9:37-76
 @ ./src/node/index.ts 12:15-58

WARNING in ./node_modules/chrome-remote-interface/node_modules/ws/lib/Validation.js 10:22-47
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/chrome-remote-interface/node_modules/ws/lib'
 @ ./node_modules/chrome-remote-interface/node_modules/ws/lib/Receiver.js 12:20-43
 @ ./node_modules/chrome-remote-interface/node_modules/ws/index.js 12:21-46
 @ ./node_modules/chrome-remote-interface/lib/chrome.js 7:18-31
 @ ./node_modules/chrome-remote-interface/index.js 6:15-41
 @ ./node_modules/v8-inspect-profiler/index.js 10:12-46
<EMAIL_ADDRESS>32:81-111
<EMAIL_ADDRESS>9:37-76
 @ ./src/node/index.ts 12:15-58

WARNING in ./node_modules/vscode-languageserver-types/lib/umd/main.js 3:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>10:38-76
<EMAIL_ADDRESS>9:23-48 10:21-46
 @ ./src/node/index.ts 6:15-61

WARNING in ./node_modules/ws/lib/buffer-util.js 105:21-42
Module not found: Error: Can't resolve 'bufferutil' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/ws/lib'
 @ ./node_modules/ws/lib/websocket.js 27:21-45
 @ ./node_modules/ws/index.js 3:18-44
<EMAIL_ADDRESS>6:37-50
<EMAIL_ADDRESS>9:21-56
<EMAIL_ADDRESS>7:15-59
<EMAIL_ADDRESS>8:21-44
 @ ./src/node/index.ts 5:24-58

WARNING in ./node_modules/ws/lib/validation.js 86:20-45
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/ws/lib'
 @ ./node_modules/ws/lib/receiver.js 13:43-66
 @ ./node_modules/ws/index.js 7:21-46
<EMAIL_ADDRESS>6:37-50
<EMAIL_ADDRESS>9:21-56
<EMAIL_ADDRESS>7:15-59
<EMAIL_ADDRESS>8:21-44
 @ ./src/node/index.ts 5:24-58

WARNING in ./node_modules/yargs/build/index.cjs 1:60106-60113
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
 @ ./src/node/server.ts 6:35-51
 @ ./src/node/index.ts 4:17-36

WARNING in ./node_modules/yargs/build/index.cjs 1:60498-60505
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
 @ ./src/node/server.ts 6:35-51
 @ ./src/node/index.ts 4:17-36

WARNING in ./node_modules/yargs/index.cjs 12:39-46
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./src/node/server.ts 6:35-51
 @ ./src/node/index.ts 4:17-36

9 warnings have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.72.1 compiled with 9 warnings in 3020 ms
asset index.js 5.08 MiB [emitted] (name: main) 1 related asset
runtime modules 1.04 KiB 5 modules
cacheable modules 4.54 MiB 715 modules
+ 27 modules

WARNING in ./node_modules/vscode-languageserver-types/lib/umd/main.js 3:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>7:38-76
<EMAIL_ADDRESS>12:50-93
<EMAIL_ADDRESS>17:28-58
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

WARNING in ./node_modules/ws/lib/buffer-util.js 105:21-42
Module not found: Error: Can't resolve 'bufferutil' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/ws/lib'
 @ ./node_modules/ws/lib/sender.js 12:38-62
 @ ./node_modules/ws/index.js 8:19-42
<EMAIL_ADDRESS>6:37-50
<EMAIL_ADDRESS>9:21-56
<EMAIL_ADDRESS>9:15-59
 @ ./src/extension/index.ts 3:30-95

WARNING in ./node_modules/ws/lib/validation.js 86:20-45
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/ws/lib'
 @ ./node_modules/ws/lib/sender.js 11:30-53
 @ ./node_modules/ws/index.js 8:19-42
<EMAIL_ADDRESS>6:37-50
<EMAIL_ADDRESS>9:21-56
<EMAIL_ADDRESS>9:15-59
 @ ./src/extension/index.ts 3:30-95

WARNING in ./node_modules/yargs/build/index.cjs 1:60106-60113
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
<EMAIL_ADDRESS>21:13-34
 @ ./src/extension/index.ts 3:30-95

WARNING in ./node_modules/yargs/build/index.cjs 1:60498-60505
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
 @ ./node_modules/yargs/index.cjs 5:29-57
<EMAIL_ADDRESS>21:13-34
 @ ./src/extension/index.ts 3:30-95

WARNING in ./node_modules/yargs/index.cjs 12:39-46
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>21:13-34
 @ ./src/extension/index.ts 3:30-95

6 warnings have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

ERROR in<EMAIL_ADDRESS>11:17-60
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode'
<EMAIL_ADDRESS>12:50-93
<EMAIL_ADDRESS>17:28-58
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

ERROR in<EMAIL_ADDRESS>6:25-83
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common/testCollection' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode/testing'
<EMAIL_ADDRESS>26:25-81
<EMAIL_ADDRESS>36:25-52
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

ERROR in<EMAIL_ADDRESS>7:17-67
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common/testId' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode/testing'
<EMAIL_ADDRESS>26:25-81
<EMAIL_ADDRESS>36:25-52
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

ERROR in<EMAIL_ADDRESS>20:25-83
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common/testCollection' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/hosted/api/vscode'
<EMAIL_ADDRESS>36:25-52
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

ERROR in<EMAIL_ADDRESS>21:17-67
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common/testId' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/hosted/api/vscode'
<EMAIL_ADDRESS>36:25-52
<EMAIL_ADDRESS>13:28-69
<EMAIL_ADDRESS>73:22-43
 @ ./src/extension/index.ts 3:30-95

5 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.72.1 compiled with 5 errors and 6 warnings in 3238 ms

asset index.worker.js 3.48 MiB [emitted] (name: main) 1 related asset
runtime modules 1010 bytes 5 modules
modules by path ./node_modules/@opensumi/ 2.04 MiB 343 modules
modules by path ./node_modules/jschardet/ 451 KiB 43 modules
modules by path ./node_modules/iconv-lite/ 198 KiB
  modules by path ./node_modules/iconv-lite/encodings/ 188 KiB 18 modules
  modules by path ./node_modules/iconv-lite/lib/*.js 10.6 KiB 3 modules
modules by path ./node_modules/uuid/dist/esm-browser/*.js 19.1 KiB
  ./node_modules/uuid/dist/esm-browser/index.js 412 bytes [built] [code generated]
  + 14 modules
modules by path ./node_modules/shortid/ 6.88 KiB 9 modules
modules by path ./node_modules/vscode-languageserver-types/lib/umd/ 90.6 KiB
  ./node_modules/vscode-languageserver-types/lib/umd/main.js 90.5 KiB [built] [code generated]
  ./node_modules/vscode-languageserver-types/lib/umd/ sync 160 bytes [built] [code generated]
+ 23 modules

WARNING in ./node_modules/vscode-languageserver-types/lib/umd/main.js 3:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
<EMAIL_ADDRESS>7:38-76
<EMAIL_ADDRESS>10:50-93
<EMAIL_ADDRESS>14:27-64
<EMAIL_ADDRESS>12:31-75
<EMAIL_ADDRESS>8:22-46
 @ ./src/extension/index.worker.ts 3:0-65

1 warning has detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

ERROR in<EMAIL_ADDRESS>11:17-60
Module not found: Error: Can't resolve '@opensumi/ide-testing/lib/common' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode'
resolve '@opensumi/ide-testing/lib/common' in '/Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode'
  Parsed request is a module
  using description file<EMAIL_ADDRESS>(relative path: ./lib/common/vscode)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/vscode/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/common/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/lib/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-extension/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules
        /Users/xiangyue/Desktop/opensumi-workspace/ide-electron/node_modules/@opensumi/ide-testing doesn't exist
      /Users/xiangyue/Desktop/opensumi-workspace/node_modules doesn't exist or is not a directory
      /Users/xiangyue/Desktop/node_modules doesn't exist or is not a directory
      /Users/xiangyue/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
<EMAIL_ADDRESS>10:50-93
<EMAIL_ADDRESS>14:27-64
<EMAIL_ADDRESS>12:31-75
<EMAIL_ADDRESS>8:22-46
 @ ./src/extension/index.worker.ts 3:0-65

webpack 5.72.1 compiled with 1 error and 1 warning in 2816 ms
ERROR: "build:extension" exited with 1.
➜  ide-electron git:(main) ✗ node -v
v16.15.0
➜  ide-electron git:(main) ✗ npm -v
8.5.5

拉下 main 分支代码，新增的依赖包 @opensumi/ide-testing

@yantze 多谢回复，能够运行起来了，但是运行的时候有个如下的错误，会有啥问题没？

@yantze 多谢回复，能够运行起来了，但是运行的时候有个如下的错误，会有啥问题没？

这个是正常的，尝试去删除之前的通信 socket，这个之后会修复下

好的 多谢


python311Packages.qingping-ble: 0.8.2 -> 0.9.0

Diff: https://github.com/bluetooth-devices/qingping-ble/compare/refs/tags/v0.8.2...v0.9.0
Changelog: https://github.com/Bluetooth-Devices/qingping-ble/blob/v0.9.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 275256 run on x86_64-linux 1

4 packages built:

python310Packages.qingping-ble
python310Packages.qingping-ble.dist
python311Packages.qingping-ble
python311Packages.qingping-ble.dist


memory or cpu question

when I not open virocore , I do audio convert is fast , when I open virocore then do audio format is slow , for I use ffmpeg demo do wav->m4a (11s audio need near 5s), in arproject do wav->m4a (11s audio need near 15s)， virocore use so much thear and memory ?

@dthian

Hi @544531645, memory use depends on how many models, textures and other assets you load for your AR Scene. You can use the android profiler in android studio to see the memory usage. If your scene is using high resolution textures plus complicated models w/ animations then memory use will likely be high.
CPU usage is also driven by how complicated your scene is. If you have a scene with animations, lighting and shadows then cpu use will be higher vs a more simple scene.

yes ,I have animations, lighting and shadows , but when I convert audio so slow , It affects the user experience, but again on ios, scenekit's speed is not affected at all. Is there a good solution?

Hi @544531645, the speed and performance depends on the phone you are using. What phone are you seeing this type of performance on? On older android phones, I'd recommend leaving out some features(such as shadows and complicated lighting, use flat lighting). On newer Android devices(like Samsung s8 and higher) then you can include more complicated scenes. Is the audio conversation slow on some devices or all of them?


Why don't use a debian/rpm package?

$ sudo apt install gorched
[sudo] password for user: ************************************************* (very long)
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package gorched

Currently,no package named "gorched"
So is it possible to build a deb/rpm package?

Hi,
Packages can be build quite easily, I have added deb/rpm to the release v1.6.
I have no previous experiences with publishing deb/rpm into public repositories, so I need some time to investigate it first.

hello, why does the program run, it is the different from your picture . it appears green ,red and blue blocks, besides english word , numbers and special symbols. "@" symbols appears most of the times.
How can i do it to run the program correctly like you? Thank you.


Problem when not using default Wire channel

I have finally gotten to the bottom of why the library doesn't work on an Adafruit Feather RP2040! The problem is here:
uint8_t AD524X::send(const uint8_t cmd, const uint8_t value)
{
  Wire.beginTransmission(_address);
  Wire.write(cmd);
  Wire.write(value);
  return Wire.endTransmission();
}

This code uses the default Wire channel rather then the one specified during initialization. Changing the code to this, fixed the problem:
uint8_t AD524X::send(const uint8_t cmd, const uint8_t value)
{
  _wire->beginTransmission(_address);
  _wire->write(cmd);
  _wire->write(value);
  return _wire->endTransmission();
}

Although I am not using it, I believe this:
uint8_t AD524X::readBackRegister()
{
  Wire.beginTransmission(_address);
  Wire.endTransmission();
  Wire.requestFrom(_address, (uint8_t)1);
  return Wire.read();
}

should be changed to this:
uint8_t AD524X::readBackRegister()
{
  _wire->beginTransmission(_address);
  _wire->endTransmission();
  _wire->requestFrom(_address, (uint8_t)1);
  return _wire->read();
}

Thanks again for all the hard work in producing this library.

Thanks for reporting, I am quite busy and think it will be tomorrow before I can dive into it.

Your analysis indeed shows it is a big BUG (with capitals) and shows I must test more.
(so little time, so much fun to do)

I'm glad it was an easy fix.

Fixed in version 0.4.0


Items requesting never ends

If during data loading (and till it has been got) the scroller to be destroyed (i.e. by the transition to the other screen of the app or some other way) then data requesting will never stop till the eof/bof is reached.
The source of this issue is here: https://github.com/angular-ui/ui-utils/issues/356.

Hello, thanks for this incredible directive. But with v1.1.0 and when a tabbed page (with ui-scroll) is destroyed , an jqlite error is signaling (with jquery on, there is no problem) :
TypeError: Cannot read property 'length' of null
at JQLite.(anonymous function) (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:3250:30)
at Scope.$get.Scope.$broadcast (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14720:28)
at Scope.$get.Scope.$destroy (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14340:14)
at z (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:185)
at http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:456
at publicLinkFn (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:6956:29)
at $get.boundTranscludeFn (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:7096:16)
at controllersBoundTransclude (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:7756:18)
at x (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular-route.min.js:6:364)
at Scope.$get.Scope.$broadcast (http://localhost:8383/Psp-Compta/libs/angularjs-1.3.13/angular.js:14720:28)

Can you please post a repro?

@jcstritt : I think Denis nailed it down. Can you please confirm?

v1.1.1 is available.
And here is the fixing PR for ui.utils.

v1.1.1 tryed. No more error. Thank you @dhilt ! Have a good day.


Namespace sync controller is run when --limited-scope=true

With --limited-scope=true (namespace-scoped deployment) the federation control plane operates on a single namespace. As a result, the Namespace sync controller is not necessary as the creation and deletion of the namespace is not up to the federation controller, nor does it have the permissions necessary for it. There is a check for this in the testing code, but a check needs to be added to the main path.

@font I think we can close this one as namespace sync controller will not run after PR #299

Fixed by #299.


The action 'Export' is enabled for one empty table

Storage Explorer Version: 1.29.0-dev
Build Number: 20230224.3
Branch: feature/table-explorer-react
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.2.1 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.28.0)
Bug Descriptions

When no entity is selected, the action 'Export / Export Selected....' is enabled.
For one empty table, the action 'Export / Export Selected....' is enabled.

Steps to Reproduce

Expand one storage account -> Tables.
Create a new table -> Close the opened tab.
Right click the table -> Click '[2] Open'.
Observe the toolbar.
Check whether the action 'Export' is disabled.

Expected Experience
The action 'Export' is disabled.

Actual Experience
The action 'Export' is enabled.

Verified this issue on the feature build 20230307.3. Fixed.


Approve / Reject status needs to be communicated through database

When a house is bought, sold, or when the player decides to stay in the current house, the facilitator needs to approve or reject the player's intended decision (which could be buying a house that is too expensive, e.g., because no other houses are available on the market anymore).
The only way in which the facilitator and player can communicate this, is through the database.

The houseround record looks like the right place to communicate the negotiation.
Notes:

Players create houseround records.
houseround records do typically not get deleted, the link with the groupround remains intact.
If a player buys a house in round 1, there is one houseroundrecord attached to the playerround: the bought house.
When a player sells a house, there are two houseround records attached to the playerround at the end of that round: one for the (approved) sell, and one for the (approved) buy.
When a player stays in their house, there are two houseround records attached to the playerround at the end of that round that both point to the same houseround.
The houseround record gets an extra field called state that indicates the state of approval by the facilitator.

The following flow is foreseen.
ROUND 1

start of round 1: both start_houseround_id and end_houseround_id are null.
player chooses a house and clicks BUY HOUSE.
houseround record is created for that house, and linked to the groupround record and to playerround.end_houseround_id
the status of the houseround is UNAPPROVED_BUY.
the facilitator can approve the buy, setting the houseround status to APPROVED_BUY
the facilitator can reject the buy, setting the houseround status to REJECTED_BUY
if the buy is approved, the houseround record remains in the database, and the player can progress
i the buy is rejected, the houseround record is deleted when the player moves back to the buy-house screen, and the pointer playerround.final_houseround_id is set to NULL again; the player can retry buying another house (or the same house for another price).

ROUNDS 2 AND UP: SELLING

start of round 2 and up: start_houseround_id pointa to the current house. final_houseround_id is null.
the state of the current (start) houseround is COPIED to indicate that the data for the start houseround is just copied from the final houseround of the previous round, except for the state field..
player looks for a new house in the sell-house screen and clicks SELL HOUSE.
the status of the houseround is UNAPPROVED_SELL.
the facilitator can approve the sell, setting the houseround status to APPROVED_SELL
the facilitator can reject the sell, setting the houseround status to REJECTED_SELL
if the sell is approved, the player can progress.
if the sell is rejected, the houseround record stays in the database when the player moves back to the sell-house screen; the state is reverted to COPIED; the player can choose to stay or sell for another price.

ROUNDS 2 AND UP: STAYING

start of round 2 and up: start_houseround_id points to the current house. final_houseround_id is null.
the state of the current (start) houseround is COPIED to indicate that the data for the start houseround is just copied from the final houseround of the previous round, except for the state field..
player looks for a new house in the sell-house screen and clicks SELL HOUSE.
the status of the houseround is UNAPPROVED_SELL.
the facilitator can approve the sell, setting the houseround status to APPROVED_SELL
the facilitator can reject the sell, setting the houseround status to REJECTED_SELL
if the sell is approved, the player can progress.
if the sell is rejected, the houseround record stays in the database when the player moves back to the sell-house screen; the state is reverted to COPIED; the player can choose to stay or sell for another price.

ROUNDS 2 AND UP: BUYING

start of round 1: both start_houseround_id and fiinal_houseround_id are null.
player chooses a house in the buy-house screen and clicks BUY HOUSE.
houseround record is created for that house, and linked to the groupround record and to playerround.final_houseround_id
the status of the houseround is UNAPPROVED_BUY.
the facilitator can approve the buy, setting the houseround status to APPROVED_BUY
the facilitator can reject the buy, setting the houseround status to REJECTED_BUY
if the buy is approved, the houseround record remains in the database, and the player can progress
if the buy is rejected, the houseround record is deleted when the player moves back to the buy-house screen, and the pointer playerround.final_houseround_id is set to NULL again; the player can retry buying another house (or the same house for another price).

At the start of a round, the following start_houseround and finish_houseround status can exist:

start: NULL, finish: NULL (round 1)
start: COPIED, finish: NULL (rounds 2 and up)

At the end of a round, the following start_houseround and finish_houseround status can exist:

start: null, finish: APPROVED_BUY (round 1)
start: APPROVED_STAY, finish: APPROVED_STAY (rounds 2 and up). Note that the start and finish statuses have to be the same, since they point to the same record.
start: APPROVED_SELL, end: APPROVED_BUY (rounds 2 and up)

Many intermediate status combinations exist, as shown in the previous comments.

A houseround record should get a playerround_id to identify the player and round of ownership.

The fields and relations have been inserted into the database:

Fully implemented with trabsactions.


Error handling / recovery rules for corrupted / malformed frames is not defined

How should the Reactive Socket stack handle receipt of corrupted frames? Either that results in parsing failures or messed up data lengths that cause incorrect parsing and the next byte no longer being the start of the next frame?
When this happens, what is told to the application? How should the next frame be properly identified to recover the communication channel?
The protocol definition only specifies the underlying protocol is reliable, which only refers to delivery and non-delivery of data. It does not specify that it also provides data integrity.

You're right, we should explicitly recommend a behavior in the spec.
I believe we should close the connection, and we shouldn't try to recover from that.

Yes, we are missing a connection level error. I discuss this in #59 where I reference the approach HTTP/2 takes with the GOAWAY frame. It is a best-effort termination of a connection. We could send it then shut down the connection. The receiver may or may not receive the GOAWAY frame depending on the nature of the failure, but it's better than just killing a connection without any signal.
I don't think we should call it GOAWAY though, but something like CONNECTION_ERROR as opposed to ERROR which we already have.

CONNECTION_ERROR has been added as an error code to the ERROR frame. So that can be used.

Language around, transport protocol requirements, frame validation, and handling the I bit has been added that clarify the protocol responsibility have been added.


Setting value using dangerouslySetInnerHTML doesn't work

Hey! Here is my code:
React = require('react')
ReactQuill = require('react-quill')

module.exports = React.createClass
  quillItems: ->
    [
      { label: 'Text', type: 'group', items: [
        { type: 'bold', label: 'Bold' },
        { type: 'italic', label: 'Italic' },
        { type: 'underline', label: 'Underline' },
        { type: 'separator' },
        { type: 'link', label: 'Link' }
      ]},

      { label: 'Blocks', type: 'group', items: [
        { type: 'bullet', label: 'Bullet' },
        { type: 'separator' },
        { type: 'list', label: 'List' }
      ]},

      { label: 'Formats', type: 'group', items: [
        { label: 'Alignment', type: 'align', items: [
          { label: '', value: 'center' },
          { label: '', value: 'left' },
          { label: '', value: 'right' },
          { label: '', value: 'justify' }
        ]}
      ]},
    ]
  getValue: ->
    @refs.editor.getEditor().getHTML()
  render: ->
    <ReactQuill theme='snow' ref='editor'>
      { console.log @props.content }
      <ReactQuill.Toolbar key='toolbar' ref='toolbar' items={@quillItems()} />

    </ReactQuill>

I've tried to pass anything to __html, but anyways I have

 as its value
UPD
<ReactQuill theme='snow' ref='editor'<EMAIL_ADDRESS>/> works as planned

The problem looks to be solved by using this:
<ReactQuill theme='snow' ref='quill-editor' toolbar={@quillItems()}<EMAIL_ADDRESS>/>

But I'm still interesting in why my approach does not work...

I'm sorry I wasn't able to catch up to this. Do you still have issues?
One thing I can say is that you shouldn't recreate the toolbar items at each render, because that causes needless re-renders of the editor (which are very costly and cause a number of other issues). Define your toolbar items somewhere, and always pass the same instance.

Hello @zenoamaro, no, I haven't issues. Thanks!


confirmation missing --- after changing settings

It is not obvious if the changes made to the settings dialogue are applied; please insert a confirmation|status-change-notification or point to the locations in the code where it would be appropriate to insert, so one can commit a change therefore.

I removed the options in the last version.


 doesn't display any icon at all

 doesn't display any icon at all and it's content is empty

Sorry, my error. Should used "icon-on" not "iconOn".


NuGet.Server - Don't serve .symbols.nupkg if .nupkg exists

NuGet.Server - don't serve .symbols.nupkg if .nupkg exists
https://github.com/NuGet/Home/issues/1854#issuecomment-165878605

This functionality has been added as an option.
When ignoreSymbolsPackages is set to true, the server will never add symbols packages (that is if the file is named .symbols.nupkg or there is a /src folder in the package).
It is recommended to also set the allowOverrideExistingPackageOnPush option to false to ensure no packages are overwritten, e.g. when pushing a symbols package to NuGet.Server.
A prerelease version of this package is now available: https://www.nuget.org/packages/NuGet.Server/2.10.0-master-0006


Death Masking different from the paper

Hello!
I checked your paper and found in section 4.5 that the "death masking" is to simply use an agent-specific
constant vector, i.e., a zero vector with the agent’s ID, as the input to the value function after an agent dies. However, I can't find the corresponding code in this project. You seem to apply "active mask" to the entropy term, not the state.
Do I miss any important message in this project?

Hi, thanks for taking a look at our work! We formulate the agent-specific constant vector for dead agents ("death masking") in the environment code itself: please see here for the code that does this. The "active_mask" which specifies which agents are active/dead is used in 3 places: the policy(actor) loss, in GAE normalization, and in the entropy term. In these last three points of the code, the active mask is used to mask out data in which the corresponding agents are dead.  Please let us know if this clarifies and if there are further questions!

Got it! Thanks!


Add simple test framework

Add a framework to validating reported problems are fixed and to prevent
against future regressions.
Meant to be run from the tests/. stderror gives the output of failed tests. And all tests are from from a temporary directory which is reset at the end of every test.
./test.sh 2>/dev/null
Running 00-sanity.sh...passed
Running 01-build-and-install-depends.sh...passed
Running 10-do-not-rebuild-make-depends-if-pkg-is-built.sh...failed
Running 10-install-depends-in-correct-order-when-building.sh...failed
Running 10-install-depends-in-correct-order-when-updating.sh...passed
Passed 3/5 tests
Failed tests:
        10-do-not-rebuild-make-depends-if-pkg-is-built.sh
        10-install-depends-in-correct-order-when-building.sh

I imagine this would be useful to validate fixes and as a git workflow to guard against regressions.
I just threw this together, but think the main problem relates to needing to become the super user to install even through the KISS_ROOT points to a directory the user has permission to. So may want to have an option for KISS_SU to be a no-op and/or control what users to install as instead of hard coding root.
Thoughts?

I have adopted shellspec for doing unit-tests on cpt, I have found it to be really useful for uncovering obscure in-function bugs that would be otherwise hard to discover.
My current tests are nowhere near completion, but some of them could be adopted for kiss.

CI/CD is fun and test-suites are exciting. If it means less typing in the long-run...

Looks like this has been abandoned...?


One explicit cast was omitted

The diff is actually quite small, but there was some extraneous spaces as well.

I will merge it, because this was really a bug.


disable signup doesn't work

i deployed an own instance via the guideline, but wanted to disable signups since we will be able to give access to selected users only.
in the file supabase/config.toml there is line 68 stating one can disable signups by setting this to false:
# Allow/disallow new user signups to your project.
enable_signup = true

error description:  this doesn't have the expected effect. after redeployment the signup button and process still works.
expected behaviour: no signup button there and possible after setting this to false

confirmed same issue here. I would like to disable it as well

If it's for hosted version you can disable in the Supabase UI.


update p004-Layers-and-Object.cpp

@shreeviknesh As this changes your implementation, what do you think about these changes?

I'm going to accept that then.
Thank you for your submission!

I'm going to accept that then.
Thank you for your submission!


Upgrade construct query functionality (builds the visJs graph results)

Current functionality doesn't separate the CONSTRUC and WHERE clauses, so query generation is haphazard.

fix query generation
create wizard or other UI features that make it easier to use (e.g. wizard: set all nodes to return)

Done