TF model convert to TFLite

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu18.04.3
TensorFlow installed from (source or binary):
TensorFlow version (or github SHA if from source):1.9.0

Command used to run the converter or code if you’re using the Python API
If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf
graph_def_file = "/home/pychen/MobileNetV2-SSD/MobileNetV2-SSD_600x300/frozen_inference_graph.pb"
input_arrays = ["image_tensor"]
output_arrays = ["detection_classes", "detection_boxes", "detection_scores"]
converter = tf.contrib.lite.TocoConverter.from_frozen_graph(
graph_def_file=graph_def_file, input_arrays=input_arrays, output_arrays=output_arrays)
tflite_model = converter.convert()
open("MobileNetV2_SSD.tflite", "wb").write(tflite_model)
# Copy and paste here the exact command

The output from the converter invocation
# Copy and paste the output here.

Also, please include a link to the saved model or GraphDef
# Put link here or attach to the issue.

Failure details
If the conversion is successful, but the generated model is wrong,
state what is wrong:

Producing wrong results and/or decrease in accuracy
Producing correct results, but the model is slower than expected (model generated from old converter)

RNN conversion support
If converting TF RNN to TFLite fused RNN ops, please prefix [RNN] in the title.
Any other info / logs
Traceback (most recent call last):
File "/home/pychen/.local/lib/python3.6/site-packages/tensorflow/python/framework/importer.py", line 418, in import_graph_def
graph._c_graph, serialized, options)  # pylint: disable=protected-access
tensorflow.python.framework.errors_impl.InvalidArgumentError: NodeDef mentions attr 'Truncate' not in Op<name=Cast; signature=x:SrcT -> y:DstT; attr=SrcT:type; attr=DstT:type>; NodeDef: ToFloat = CastDstT=DT_FLOAT, SrcT=DT_UINT8, Truncate=false. (Check whether your GraphDef-interpreting binary is up to date with your GraphDef-generating binary.).
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "tf_to_tflite_graphdef.py", line 8, in
graph_def_file=graph_def_file, input_arrays=input_arrays, output_arrays=output_arrays)
File "/home/pychen/.local/lib/python3.6/site-packages/tensorflow/contrib/lite/python/lite.py", line 204, in from_frozen_graph
import_graph_def(graph_def, name="")
File "/home/pychen/.local/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py", line 432, in new_func
return func(*args, **kwargs)
File "/home/pychen/.local/lib/python3.6/site-packages/tensorflow/python/framework/importer.py", line 422, in import_graph_def
raise ValueError(str(e))
ValueError: NodeDef mentions attr 'Truncate' not in Op<name=Cast; signature=x:SrcT -> y:DstT; attr=SrcT:type; attr=DstT:type>; NodeDef: ToFloat = CastDstT=DT_FLOAT, SrcT=DT_UINT8, Truncate=false. (Check whether your GraphDef-interpreting binary is up to date with your GraphDef-generating binary.).
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

frozen_inference_graph.zip

Do I need to retrain the model using TensorFlow v1.15 and use export_tflite_ssd_graph.py to convert Mobilenet v2 SSD to tensorflow lite?

@ivs-pychen Looks like this model have control flows. Can you please enable control flow v2 in TF, so your model will use control flow v2 instead of v1 (which we don't support)
You can add tf.enable_control_flow_v2()
Thanks


is it possible to customize new format ?

almost just like mongodb but a little bit different :

Operator
Description

$eq
Equal

$eqi
Equal (case-insensitive)

$lt
Less than

$lte
Less than or equal to

$gt
Greater than

$gte
Greater than or equal to

$in
Included in an array

$nin
Not included in an array

$contains
Contains

$not
not

$exists
Exists

$startsWith
Starts with

$endsWith
Ends with

$or
Joins the filters in an "or" expression

$and
Joins the filters in an "and" expression

example :
$or: [
{
$and: [
{ title:  { $contains: 'Hagiographie' } },
{ code: { $eqi: 'xytr2' } },
{ code: 'XyTr2' },
{ tags: { $in: ['tag1', 'tag2'] } },
{ tags: { $exists: true } },
{ price: { $not: { $lt: 10 } } },
],
},
{
tags: { $nin: ['tag1', 'tag2'] },
price: { $gte: 12 },
code: { $not: { $exists: true } },
content: {
$startsWith: 'blah blah' ,
},
},
],

Have you tried using the "mongodb" export with a custom ruleProcessor?


docs: add basic list example notebook

Should we close this? Dust it off and merge it?

Will do some cleanup of this today


[UX/UI] Enhance design of tx-graph in send tab

The current tx graph in the send tab is reduced to the minimum (meant in a positive sense) and therefore easily understandable. I guess we could add a little more information for fast sanity checks - either by stating the absolute and/or relative amounts of each inputs and putputs.
For even faster understanding of the transaction one could add visual hints like "loading bars" or "arrow thickness" according to the relative "weight" (in terms of send amount) of each utxo. Example 5) is inspired by the transaction representation of oxt.me, see random example used here.
Please excuse my limited design skills as it was just intended as a fast sketch.

Thanks for the suggestions. Please see https://github.com/sparrowwallet/sparrow/issues/320#issuecomment-994751040 for how this has been implemented.


I cannot perform FW upgrade anymore from icub-firmware/build

Hi everybody, on my iCubGenova04 I have just updated the svn repository icub-firmware and ... the /build folder has just disappeared. The problem now is that I don't know how to perform FW update.
Is there anybody who can help me?

I guess you should use the new https://github.com/robotology/icub-firmware-build repo?

Hi,
I have seen that on the svn repository  everything has disappeared apart from the file called "we.have.moved.to.github.readme.txt".
That means that the svn repository you are using is not made obsolete.
If you read the file, you have instructions of how to retrieve on your iCub the binary files that you need to perform FW update.
The binaries have moved into the following github repository:  https://github.com/robotology/icub-firmware-build
All you just need to do is:

remove folder icub-firmware, or rename it (so that any other user of the robot knows it is obsolete)
retrieve the new repository with commend "git clone https://github.com/robotology/icub-firmware-build".

Inside folder icub-firmware-build/ there are the binaries that you need.

Yes, Silvio indeed.
The old svn repo is now obsolete and has been split into two new git repositories:

one is https://github.com/robotology/icub-firmware-build and contains whatever is needed on iCub;
https://github.com/robotology/icub-firmware and contains the source code, which is not used by iCub.

On iCubGenova04 icub-firmware-build is already installed. I wrote this Q&A so that people using other robots can solve in case they make an update to the svn repository and lose their data.

Sorry, I did not get it was a fictitious question. :D
For properly notify that the procedure for installing the firmware has changed we should updated the Firmware wiki documentation at http://wiki.icub.org/wiki/Firmware (that I guess it's the first hit on google for the search "icub firmware").


Increment versions for sphere releases

Increment package versions for sphere releases

API change check
API changes are not detected in this pull request.


Uncaught ReferenceError: Gmail is not defined

For below line of code, the error is thrown: "Uncaught ReferenceError: Gmail is not defined"  :--
var gmail = Gmail();
Kindly provide me solution ASAP

How are you using this? I would recommend that you use the following sample chrome extension to get the example up and running https://github.com/KartikTalwar/gmail-chrome-extension-boilerplate

Hello Kartik,
Thank you so much for prompt response.
And You have built a great thing "Gmail.js".Congratulations from Me & My team. Proud to be an Indian.
Would like to keep in touch with you. Thanks once again !
-Ami


Use crevice to write LightsUniform

This is a draft of what usage of crevice for writing Std140 layout looks like, see #1779.
Note that WriteStd140 is fairly low overhead, it converts glam types into Std140 primitives before serializing). AsStd140, which can be derived in many cases, potentially has more overhead, since it converts the entire struct into a version with padding and Std140 primitives.
Dynamic sizing of WriteStd140 is also not without cost, since it serializes the type to io::Sink() and uses writer.len() to calculate the size.
This draft currently depends on an upcoming PR on crevice that adds the StaticStd140Size trait, so that the maximum size of LightsUniform can be calculated.
Additionally there's draft PR to glam to implement crevice traits. This is probably the most problematic part of crevice right now. Because of the orphan rule it's impossible to implement crevice traits without newtype wrappers on foreign types. There might be an upcoming solution, Lucien has been very welcoming in discussing improvements.

I'm very interested in this to keep backends other than the official one (mainly WebGL2) working.
For example, the WebGL2 shader currently fails after #1778 got merged, even after applying the changes, to do a wrongly sized buffer

I'm very interested in this to keep backends other than the official one (mainly WebGL2) working.
For example, the WebGL2 shader currently fails after #1778 got merged, even after applying the changes, due to a wrongly sized buffer

Crap, that sucks. I need to make testing webgl part of my workflow for any future changes to shaders.

Closing this now that bevy_crevice is used for all of our rendering pipelines.


Problems encountered when using robotiq 2f-85 for gripping simulation

https://github.com/deepmind/mujoco/assets/58319077/d1a77858-6bf8-490c-a49e-4d58b2381433
Hi,
I'm a student and I'm trying to use MuJoCo for academic research.
I'm looking for some help implementing a grasping simulation in MuJoCo.
When I use the robotiq_2f85 gripper in mujoco_menagerie for object grasping simulation, stable gripping and lifting cannot be achieved, there seems to be a collision between the gripper and the object that is not properly defined.
I just control the position of the jaws and apply an external force on the drive joint, code show as below:
def init_controller(model,data):
...
data.ctrl[6] = 90
data.qfrc_applied[7] = 1
data.qfrc_applied[11] = 1
...
Then this is the xml code of the object：
<body name="grabbable_object" pos="-0.134 0.79213164 0.3">
    <geom type="box" size="0.03 0.03 0.1" rgba="1 0 0 1" friction="1 1 1"
        solimp="0.95 0.99 0.001" solref="0.004 1" condim="3" priority="0"/>
    <joint armature="0" axis="0 0 1" damping="0" limited="false" name="box_1_z" pos="0 0 0" stiffness="1" type="slide"/>
    <inertial pos="0 0 0" mass="0.01" diaginertia="1.98e-5 1.98e-5 5.45e-6"/>
</body>

Here is a screenshot / video, illustrating my question:

Thanks in advance.

I believe this is now fixed at HEAD, see this comment.
Closing for now, let us know here if this did not solve your problem.


Add a Make task for renewing my certbot certificates

This can only be run on my web server (so it’s not that useful for anybody else), and I still need to edit the nginx config manually, but it's another thing I don't have to do by hand.

And indeed, just testing this while renewing my SSL certificates. \o/


Snakes and Ladders Game  using python

It will be the classical Snakes and Ladders using python

Kindly assign me this issue for gssco22


clues: Count Ghommal's Avernic defenders for Warriors' Guild emote clue

Removes the old Warriors' Guild emote step (used to be push up emote).
Updates the current step (Raspberry) to count Ghommal's avernic defenders for the dragon defender item requirement.

avernic change will be handled by #17670


fix: fix base url for preview command

Description
This PR will fix the base URL config in the /preview command.
The config will read the env first to set the base URL, so in the action, we set the env to pull_${pull_number}, so the deployed website will use this as the base URL which not break all the relative links in the website.
Resolved issues
Closes #26
Before submitting the PR, please take the following into consideration

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
[x] Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
[x] The description should clearly illustrate what problems it solves.
[x] Ensure that the commit messages follow our guidelines.
[x] Resolve merge conflicts (if any).
[x] Make sure that the current branch is upto date with the main branch.

/preview

/preview

/preview

/preview

/preview

/preview

/preview


Update mongodbhandler.py

latest pymongo library doesn't have the attribute 'Connection'.
Changed it to MongoClient.

Thanks @DeepthiGaddam!


Update Composer dependencies (2021-10-23-00-07)

Visual regression test passed!
View the visual regression test report


[Feature Request] Change element type

Hello,
After sending a big wishlist, in the General Archi Discussion forum, I started a local test on the "Change type' issue.
As you already answered several times, changing the type of an element (or a relationship) is a complex stuff.
And I can confirm that, after fighting several hours on this one. Discovering EMF is already a journey.
:)
BTW, the jArchi plugin allows to do this. And it seems to me that the code in jArchi could be incorporated in archi, in a way or another.
Is there a reason why it's not done ?
I can see several such reasons:

It would not work
You don't have time (I can help, here)
You don't want to, to encourage donation on jArchi

So my question here is a simple one (to begin with :) ):
If I work on this "Change Type" capability (for instance, changing a BusinessRole into a BusinessActor) in archi.exe, would it be a good idea according to you and what you want archi to be?
Etienne

I might consider implementing it natively in Archi in 2021.

It would not work

It would work.

You don't have time (I can help, here)

Correct. I don't need help - it would take longer.

You don't want to, to encourage donation on jArchi

Wrong.
Note - everyone wants their favourite Archi feature done now and for free, and of course with free 24/7 support. I'm growing tired of the continual sense of entitlement.

Closing this as it's covered in #663

Hello,
I know you just closed it, but it's not really covered by #663, as this one is about relation ship.
And when I say I can help: I've already done a good part of the job, and I'm willing to help.
I'm not asking you to do it.
I'm sorry if I was unclear, so here is my real question: if I do it properly, would you accept the PR ?
Etienne

would you accept the PR ?

It would take me longer reviewing and re-writing a PR than if I just implemented it myself. I don't have the time to look at this right now. We have a roadmap for Archi on the website, and there are greater priorities before this.

Hi guys,
It seems to me that there is some misunderstanding here.
@Phillipus I don't read Etienne's issue as "I want this now", so if he wants to try working on this and don't expect you (or me) to review it before some weeks or month, then that might be a good way for him to start understanding the codebase. It will of course take him more time than your (or even me) to do it, but that's how someone learn. 8 years ago it was taking me ages to create some bad hack in Archi's code ;-)
@etienne-sf:
The main reason why we don't work on this kind of request is because it can be done with jArchi. Creating jArchi (which is opensource so anyone can clone the code and compile it) was a way for us to make it easier for people to code the feature they want for Archi so that we can focus on the real difficult (thus core) ones. This specific use-case is covered by the script I shared some time ago, making it not urgent for us.
One important thing to know is that working with EMF is easy, but making things available in Archi's UI taking the undo/redo stack into account is more difficult and takes time. For jArchi to work and in order to be able to undo the changes made by a script, Phil had to create a jArchi specific undo/Redo mecanism. That's the reason why jArchi is so powerful, but also why something that can be done with it has to be full coded again (and in a different way) in the core of Archi if we want this feature to be "native".
So to answer your question: you can of course work on this and submit a PR, but understand that it will certainly take some (read a lot) of time before we can review it, not because we don't want it, but because we don't have much time and we are focusing on other features.
BTW, I read your post the day you posted it (and liked it very much), but more than 2 months after, I still havent found time to reply because there's only one me and I have only few hours available each week. I wish I could have more time ;-)

OK, I understand Philippus's point.
It's true that the code is both really complex, and very clean and stable. And I understand that you don't want to break it.
And you think that receiving help will consume more from your time in code check, than your time to develop it.
It's a little sad to me, as I think I've done a good part of the way, to get it done. And I think I'll be conform to your code quality standard (including undo and redo). But there is no issue there, as you where very precise on this point ("Do not just submit code or a Pull Request without prior agreement. It will be rejected.").
@ jbsarrodie,
Thanks for your answer. I feel better with this one.
But I'm unable to use jArchi. It seems nice. I don't have credit for a donation. And I've not been able to use it with archi from its source code.
I find it simpler to implement it in archi (despite undo, redo, integration in EMF, managing folder and other featureIDs...)
But, then, how can others contribute to archi ?
Or, simpler : how can I help?
Etienne

It's a little sad to me, as I think I've done a good part of the way, to get it done. And I think I'll be conform to your code quality standard (including undo and redo). But there is no issue there, as you where very precise on this point ("Do not just submit code or a Pull Request without prior agreement. It will be rejected.").

 We don't say we won't look at it, but it will take time for us to be able to do so (and you might expect 6 month before we do it).

But I'm unable to use jArchi. It seems nice. [...] And I've not been able to use it with archi from its source code.

Well, download Archi's code, download jArchi's code, then simply compile jArchi as a plugin like any other plugin you would have developed (See https://github.com/archimatetool/archi/wiki/Developing-Import-and-Export-Plug-ins#deploying-the-plug-in).

I don't have credit for a donation.

That's not needed as its open source. We simply decided to not make the binary version available outside of Patreon. That being said, we'll be very happy with a small donation ;-)

I find it simpler to implement it in archi (despite undo, redo, integration in EMF, managing folder and other featureIDs...)

Did you manage to check that all relationships are still valid after having changed the type? If they are invalid, do you prompt the user to offer him to stop and roll back, or to continue and remove them, or to continue and convert them to association, and then, do you offer to keep track of the fact that they were converted as a side effect of another conversion? And even if relationships are still allowed this doesn't make them valid, so how to you manage this ? etc...

But, then, how can others contribute to archi ?
Or, simpler : how can I help?

That's a good question. I must admit that, because nobody actually contributed features (except Mads 7 years ago and of course Herve with its plugins), we're not that good and maintaining a list of things that people could contribute too, because this costs us time we don't have.
So I guess that these ideas could be considered:

Test new versions and provide feedback
Provide support to other people on the forum
Provide new features through jArchi (this makes it easy for people to test them)
Provide new features as plugins
Look at opened issues (and some closed one) to see potential new features for Archi itself or coArchi or jArchi, write a good description of the addressed use-case and the potential solution in a wiki page and discuss it with me. I'm usually acting as a kind of product owner and if the described feature insert itself into a bigger use-case we have in mind, then we'll be able to dispatch the work.

TBH, while I write these lignes, I think there's a real need to extend jArchi to expose new methods and support new use-cases. We're also working on coArchi 2 so it might be worth looking at it (we'll soon have to rewrite from scratch a new diff/merge engine).

Re-opening...

Hi,
I've noticed #699. Before moving on and implementing this, we should first agree on the behavior as it can't be as simple as selecting the target type only. Might be worth looking at this issue for a reminder of previous discussions about it.
So again, here are the key points, based on the implementation done in my jArchi scripts set:

User should first decide what to do with invalid relationships. Only two options here: abort or convert to associations (and then keep track of previous type in a comment added into the documentation attribute).
If 'abort', then the whole operation should succeed only if all elements can be converted. This means that as soon as converting one element leads to unvalid relationship, we should roll-back the whole operation.
The new feature should be able to also change type of relationships. But this adds additional checks (junctions)
The "new" concept should have a new id and not reuse the old one as this is no more the same concept (this is to avoid side effects on model import feature, coArchi...)

Btw, "refactor" is not really a good menu name (sounds too technical to me). A simple "Change type..." menu with per layer sub-menus seems better.

Hello,
You just closed the #700 Pull Request.
And restricted comments to collaborators
FYI:

There is no link with an issue about donating 1$. My use of archi is not big enough to justify learning an additional tool. That's all.
As I explained, I'm working on another open source project, where there is feedback that I must take into account.
I'm still willing to implement this #700 PR, and respect the guidelines and comments you provided.

But perhaps it's too late now.
Etienne


[Suggestions] include .rgadget file in the examples

Include .rgadget files in the examples, so users can use examples easier.
The .rgadget files are located at:
My Documents\My Games\Retro\Gadgets
The file name can be obtained within the game:

Examples have been moved to other repo.


Introduce block builder

Description
This PR introduces the block builder object to construct blocks with transactions from the pool. Any consensus protocol will use this object to abstract functionality.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist

[ ] I have assigned this PR to myself
[ ] I have added at least 1 reviewer
[ ] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[ ] I have tested this code with the official test suite
[ ] I have tested this code manually

Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Bug] Build error on 5.13.0 and newer

Bug Report
Describe the bug
We have a monorepo with several apps. One uses app router, and there are no issues with building the app.
However another one that uses pages router, gets the following build error on 5.13.0 or newer only:
info  - Collecting page data ...Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/philip/projects/mono/node_modules/next/image' imported from /home/philip/projects/mono/node_modules/next-cloudinary/dist/index.mjs
Did you mean to import next/image.js?
    at finalizeResolution (node:internal/modules/esm/resolve:255:11)
    at moduleResolve (node:internal/modules/esm/resolve:908:10)
    at defaultResolve (node:internal/modules/esm/resolve:1121:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///home/philip/projects/mono/node_modules/next/image'
}

Is this a regression?
Yes, since this does not happen before 5.13.0.
Your environment

OS: Windows 11 | 23H2 (but this also happens on our GitHub bots that use Linux).
Node version: 20.10.0
Npm version: 10.2.3

ill see if i can reproduce this, havent seen this one yet. what package manager / monorepo tooling are you using?

looks like this isn't a mono-repo specific issue its a Pages router issue

i suspect its related to foundational work to set up subpath imports via https://github.com/colbyfayock/next-cloudinary/pull/370/files
will see what i can find

seems to be a known issue with regards to ESM for the next/image component. trying these workarounds: https://github.com/vercel/next.js/issues/54777#issuecomment-1808505837

getting somewhere with:
import { Image } from 'next/dist/client/image-component.js';

but now running into the same issue with Head

i dont think i'll be comfortable pushing this out right before the holidays either way since it feels like a risky fix, for now hopefully keeping it pinned to a lower version is sufficient

You could potentially try using them the same way with a ts-ignore above each prop. They technically should get passed through I believe just not typed

looping back around to this, im struggling to get all of the imports working properly, particularly, i guess due to how the Head components exports are set up, i'm having issues with React, which i suspect is due to multiple versions which is creating an issue for consumer apps using it
i'm not having much luck finding a solution so my intent at this time is to work on a #363 and introduce a breaking change in the CldVideoPlayer component where for Pages apps, requires manually importing the CSS file, similar to how it would be required in the App directory
CldOgImage still uses the Head component, so im unsure if that will be impacted as well, but will have to see as im digging through everything

update: im going to revert the subpath changes for 5.x as they were never documented and add those base in 6.x as part of an overall breaking change

@PhilipAngelinNE should be good to go with 5.17.0 which reverts the import changes and should include the latest other features. please let me know if you run into any issues, i appreciate your patience

Worked like a charm for me - thanks @colbyfayock!


fix(query): fix tf gcp "IP Forwarding Enabled" query to use resource

Closes #6166
Proposed Changes

Fix "IP Forwarding Enabled" Terraform GCP query to use document resources instead of data sources
Update positive and negative test files and accompanying positive_expected_result.json file

I submit this contribution under the Apache-2.0 license.

Saw some failing PR checks unrelated to the rule itself. Updated fork with latest KICS master branch to see if that'll resolve the issues.

Hi @pauly4it,
Yes it should fix the errors.


docs: Added an example implemetation of JSON schema validation that uses fastjsonschema

Supersedes https://github.com/meltano/sdk/pull/2066
Co-authored-by: Dan Norman<EMAIL_ADDRESS>

📚 Documentation preview 📚: https://meltano-sdk--2231.org.readthedocs.build/en/2231/

cc @BuzzCutNorman


getting Json data from tcp link

Hi
I have a hardware connected to my pi with ethernet. It is on <IP_ADDRESS> and puts out a json file if i go to <IP_ADDRESS>/current_state.json?pw=, in by browser, that looks like this;
{   "CurrentState": {     "DigitalInput": [       {"Name": "DI1", "Value": "0", "Count": "0"},       {"Name": "DI2", "Value": "0", "Count": "0"},       {"Name": "DI3", "Value": "0", "Count": "0"},       {"Name": "DI4", "Value": "0", "Count": "0"},       {"Name": "DI5", "Value": "0", "Count": "0"},       {"Name": "DI6", "Value": "0", "Count": "0"},       {"Name": "DI7", "Value": "0", "Count": "0"},       {"Name": "DI8", "Value": "0", "Count": "0"}     ],     "AnalogInput": [       {"Name": "AI1", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI2", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI3", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI4", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI5", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI6", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI7", "Value": "0", "Measure": "0.0 mV"},       {"Name": "AI8", "Value": "0", "Measure": "0.0 mV"}     ],     "Output": [       {"Name": "DO1", "Value": "0"},       {"Name": "DO2", "Value": "0"},       {"Name": "DO3", "Value": "0"},       {"Name": "DO4", "Value": "0"},       {"Name": "DO5", "Value": "0"},       {"Name": "DO6", "Value": "0"},       {"Name": "DO7", "Value": "0"},       {"Name": "DO8", "Value": "0"},       {"Name": "DO9", "Value": "0"},       {"Name": "DO10", "Value": "0"},       {"Name": "DO11", "Value": "0"},       {"Name": "DO12", "Value": "0"},       {"Name": "DO13", "Value": "0"},       {"Name": "DO14", "Value": "0"},       {"Name": "DO15", "Value": "0"},       {"Name": "DO16", "Value": "0"}     ],     "PWM": [       {"Name": "PWM1", "Value": "0"},       {"Name": "PWM2", "Value": "0"}     ]   } }
I would like the value of the Outputs shown as a swich on the dashboard and later control by sending a statement back.
For example if i go to <IP_ADDRESS>/current_state.json?pw=&Output1=1, in my browser,
it changes the output 1 to the value 1
I've made the following flow, and the tpc says "connected".
[{"id":"abe071e6.e4c1a","type":"tab","label":"Flow 1"},{"id":"c53ec1e9.52508","type":"debug","z":"abe071e6.e4c1a","name":"","active":true,"console":"false","complete":"payload","x":660,"y":120,"wires":[]},{"id":"93e2588c.cd4438","type":"function","z":"abe071e6.e4c1a","name":"","func":"var msg1;\nmsg.topic === 'current_state'\nvar msg1 = { payload: Output1 };\nreturn [ [msg1] ];","outputs":1,"noerr":0,"x":620,"y":220,"wires":[["bd1022ee.11c6b"]]},{"id":"31198b1a.c15224","type":"tcp in","z":"abe071e6.e4c1a","name":"","server":"client","host":"<IP_ADDRESS>","port":"80","datamode":"single","datatype":"base64","newline":"","topic":"current_state","base64":false,"x":190,"y":120,"wires":[["74e8eab8.439654"]]},{"id":"3486fe27.bec782","type":"function","z":"abe071e6.e4c1a","name":"prepara params","func":"//http://<IP_ADDRESS>/current_state.json?pw=\nmsg.url = 'http://<IP_ADDRESS>:80/current_state.json?pw=';\nconsole.log('req.url:' + msg.url );\nreturn msg;","outputs":1,"noerr":0,"x":340,"y":260,"wires":[["93e2588c.cd4438","c53ec1e9.52508"]]},{"id":"74e8eab8.439654","type":"jsonpath","z":"abe071e6.e4c1a","expression":"/current_state.json?pw=","split":false,"name":"","x":320,"y":180,"wires":[["3486fe27.bec782","c53ec1e9.52508"]]},{"id":"bd1022ee.11c6b","type":"ui_switch","z":"abe071e6.e4c1a","name":"test","label":"test","group":"9b9a5d45.ec9c5","order":0,"width":0,"height":0,"passthru":true,"decouple":"false","topic":"current_state","style":"","onvalue":"1","onvalueType":"num","onicon":"","oncolor":"","offvalue":"0","offvalueType":"num","officon":"","offcolor":"","x":840,"y":240,"wires":[[]]},{"id":"9b9a5d45.ec9c5","type":"ui_group","z":"","name":"Swichboard 1","tab":"11095a28.3a1c96","order":1,"disp":false,"width":"6"},{"id":"11095a28.3a1c96","type":"ui_tab","z":"","name":"Electric","icon":"dashboard","order":2}]
What am I doing wrong?

Hi, thanks for raising an issue.
If you check out our contribution guidelines you'll see we prefer to handle this sort of thing on the mailing list, slack team or you could ask a question on Stack Overflow and tag it node-red. That way the whole Node-RED user community can help, rather than rely on the core development team.
Thanks!

However - if you are getting the right sort of response from a browser... why not use an http-request node to get the same thing ? (Why use tcp ?)

@dceejay
Because I don't know how to do that. I'm kind of new with this, and when I saw the little green dot saing "connected" beneath the tcp, I was about to pop the champagne....
I've done as @knolleary asked me, and posted the question here: [https://stackoverflow.com/questions/44854220/troubles-getting-data-from-json-source-in-node-red]

Closing as this has been asked and answered on SO


Color Contrast

I love WebAim.  They are great. No problem with you promoting their terrific work:
https://accessibility.civicactions.com/guide/tools#quick-tests
That said, we're promoting two other tools for color contrast because they are open source:
https://accessibility-manual.dwp.gov.uk/tools-and-resources/manual-accessibility-testing
The other big advantage of https://contrast-ratio.com/ is that it can take more than HEX values. HSLA works well in the web & transparencies are increasingly important.

Hi @mgifford I think some of those links are in the wrong order. I've tried to work it out, and I think I've deduced that the two tools are:

contrast ratio
contrast checker (glitch)

I've added contrast ratio to the documentation for the next release, but it looks like the glitch application doesn't load on DWP equipment, so i've held off adding that one for now until I can see if we can get it whitelisted.

Closing issue. One tool was added but one tool doesn't work on DWP equipment. Appreciate this isn't really a great reason to omit it, but as it's the DWP Manual I don't want to cause confusion for DWP staff.


Add an example for TCP package

Description:
Add an example for the TCP package.

HTTP echo server/client written using TCP package
This example will demonstrate how the TCP package can be used to send a simple text message and receive the echoed response from the server.
This example will have 2 parties.

TCP Client

TCP client has two records to represent the HTTP request and the response.
type Request record {
    map<string> headers;
    string body;
};

type Response record {
    map<string> headers;
    string body;
};

The client will send a POST request as per the headers and body defined in the Request record. Then read the response coming from the server and then map the details of the response to the Response record.

TCP server

The server will accept only the POST requests coming to the defined port and then echo back the payload as an HTTP response. The requests other than POST will be responded to with the status code 400 Bad Request . The incoming request will get mapped to a Request record and the sending response will get mapped to a Response record similar to the client.


pytest crashes CI on freshly baked projects due to a lack of tests

The solution is to use the plugin https://github.com/yashtodi94/pytest-custom_exit_code and add the --suppress-no-test-exit-code flag when we call pytest in the Makefile

Closed by #13


Filtering on simulation status is not yet working as intended.

In order to not blow up #27 too much, I have pulled this into a separate issue that can then also be fixed by a separate PR.
The sim status filtering is not currently working as intended. If I look here (which I hope is the right place):
https://github.com/key4hep/dmx/blob/23a1eb2cc4ed4fb3200a4d38ee70e464a180a21f/js/menu/filter/parameters.js#L114-L118
This checks whether the sim status is exactly the value of the check boxes that appear on the page:

However, these are the bits in the sim status that are set if a condition is met:
https://github.com/key4hep/EDM4hep/blob/0784e02caf09ee89a728b4dd17ed74ef082e4d66/edm4hep.yaml#L297-L304
So there are two things that would need to be improved / fixed

The current display should not display the bit numbers, but rather their meaning. E.g. 23 -> Overlay
The actual filtering should be checking the bits of the simulator status, not the actual value

The current display should not display the bit numbers, but rather their meaning. E.g. 23 -> Overlay

This seems easy to implement. However, there are cases when the bit is completely different from the specification (like 0 or some other number). In that case, what should be displayed?

2. The actual filtering should be checking the bits of the simulator status, not the actual value

Sorry, I don't quite understand what you mean by "not the actual value"? I mean, the condition checks if simStatus is the same as the simStatus of the particle.

To clarify what I mean by not the value, the check that is currently there is effectively
return particle.simStatus === filterSimStatus;

Where filterSimStatus is taken from the input (i.e. something between 23 and 30 inclusive). However, what we would actually want to have is a check like this
return (particle.simStatus & (1 << filterSimStatus)) !== 0;

This way the filter would check whether a certain bit is set in simStatus. I suppose you would have to introduce a new class inheriting from FilterParameter that works similar to the Checkbox does now, but has a different implementation for buildCondition. Alternatively, subclass the Checkbox and make a ValueCheckbox (that keeps the current behavior) and a BitfieldCheckbox that implements the proposed behavior here.

Ohh so it's not a direct comparison. Instead, some math to check the status. I've implemented these changes in this commit. The new check works as intended, by making the bit operations, and shows the simulation status name (overlay, stopped, etc) if the simStatus of the particle is defined here. However, I show the number instead if the simStatus is not found.

I just noticed that I confused simStatus with genStatus. genStatus was using the simStatus implementation and vice versa. But now is fixed.


Delete/Map/Unmap bugs

Delete the first entry in the apps routes list leads to  ERROR TypeError: Cannot read property 'entity' of undefined
  at Object.exports.isTCPRoute (routes.helper.ts:4)
  at eval (application.service.ts:273)
  at Array.filter (<anonymous>)
  at MapSubscriber.eval [as project] (application.service.ts:273)
  at MapSubscriber._next (map.js:79)
  at MapSubscriber.Subscriber.next (Subscriber.js:92)
  at FilterSubscriber._next (filter.js:90)
  at FilterSubscriber.Subscriber.next (Subscriber.js:92)
  at MapSubscriber._next (map.js:85)
  at MapSubscriber.Subscriber.next (Subscriber.js:92)

route added via map existing fails to appear in app routes list
unmap fails to remove entry in app routes list
unmap clears entire table in space routes list

Should look at #1981 at the same time


Modify UI to include label for date applied

Included a small label above application list to explain the meaning of the dates

It would also be good to change the d/DATE to d/DATE_APPLIED in the usage message in the AddCommand and EditCommand classes Also, personally I think the UI label is a bit too faint, kinda hard to read. 😅 Not sure what the rest think though
Thanks for working on this!

oh right thanks for pointing out edits for the command classes.
For the UI  label, how's this instead? 😅

Not sure if it looks out of place? But definitely easier on the eyes compared to the previous one. What do the rest think? @nmtuan2001 @eesung00 @jhchee18

Not sure if it looks out of place? But definitely easier on the eyes compared to the previous one. What do the rest think? @nmtuan2001 @eesung00 @jhchee18

I think it looks fine. I get why you asked if it looks out of place though, but not really sure how to make it better. For now, it's fine imo.

It would also be good to change the d/DATE to d/DATE_APPLIED in the usage message in the AddCommand and EditCommand classes Also, personally I think the UI label is a bit too faint, kinda hard to read. 😅 Not sure what the rest think though
Thanks for working on this!

oh right thanks for pointing out edits for the command classes.
For the UI label, how's this instead? 😅

Not sure if it looks out of place? But definitely easier on the eyes compared to the previous one. What do the rest think? @nmtuan2001 @eesung00 @jhchee18

I think we might need to keep it similar width x height with the original one?

I think we might need to keep it similar width x height with the original one? Not sure is for mock UI only or general UI size

Probably just for mock UI imo but we can check just in case

It would also be good to change the d/DATE to d/DATE_APPLIED in the usage message in the AddCommand and EditCommand classes Also, personally I think the UI label is a bit too faint, kinda hard to read. 😅 Not sure what the rest think though
Thanks for working on this!

oh right thanks for pointing out edits for the command classes.
For the UI label, how's this instead? 😅

Not sure if it looks out of place? But definitely easier on the eyes compared to the previous one. What do the rest think? @nmtuan2001 @eesung00 @jhchee18

I think we might need to keep it similar width x height with the original one? Not sure is for mock UI only or general UI size

For this, I didn't actually change the default width and height, just maximised the window here so easier to see 😅

Looks clean and clear! 👍 Just another thought maybe we can refine the UI as

Google
Contact: 68882888
Position: Software Engineer Intern
Email<EMAIL_ADDRESS>Date applied: Sep 10 2022

Since we got space to expand it horizontally, instead of eating up space for vertical scrolling.
Anyway, this is good enough already!

hmm yeah I thought about it as well, but since the contact, position and email fields are pretty intuitive, I thought that including it would clutter up the space since there is not much value-add. Anyway, thanks for the suggestion! I'll go ahead with the one-liner label in brighter font and we can always change it afterwards if we want to

It would also be good to change the d/DATE to d/DATE_APPLIED in the usage message in the AddCommand and EditCommand classes Also, personally I think the UI label is a bit too faint, kinda hard to read. 😅 Not sure what the rest think though
Thanks for working on this!

oh right thanks for pointing out edits for the command classes.
For the UI label, how's this instead? 😅

Not sure if it looks out of place? But definitely easier on the eyes compared to the previous one. What do the rest think? @nmtuan2001 @eesung00 @jhchee18

I think we might need to keep it similar width x height with the original one? Not sure is for mock UI only or general UI size

For this, I didn't actually change the default width and height, just maximised the window here so easier to see 😅

Oh haha then should be fine. Yup other than that looks good to me.

Codecov Report

Merging #102 (3aa05a5) into master (a3a90bb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #102   +/-   ##
=========================================
  Coverage     62.22%   62.22%
  Complexity      510      510
=========================================
  Files            94       94
  Lines          1787     1787
  Branches        215      215
=========================================
  Hits           1112     1112
  Misses          620      620
  Partials         55       55

Impacted Files
Coverage Δ

...a/seedu/application/logic/commands/AddCommand.java
85.71% <ø> (ø)

.../seedu/application/logic/commands/EditCommand.java
92.40% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


THIS REPO IS NOT ACTIVE

@chjj please respond if this repo is still active.
For anyone looking for an active fork look at 8fold-marked

Good decision

Reached out to @chjj to see about transferring the project to 8fold. We'll see how that goes.

Why are you not using markdown-it?

@caub - Me personally? Because I don't control the Markdown compiler used in https://github.com/sparksuite/simplemde-markdown-editor
I think a lot of us don't actually use Marked directly. Instead, we use other libraries that use Marked.

@joshbruce how is it going with the transfer? Were you able to get ahold of @chjj?

@UziTech: Haven't heard back. Was just about to put a second email together. Was planning on CCing you on it this time. So, not well, I suppose??

indeed I see marked in most of my node_modules, I think the best would be to deprecate this lib
and help transitioning like: https://github.com/graphql/graphiql/pull/581/files

@caub: What we've been trying to do in the meantime is I have a fork the community is starting to use:
https://github.com/8fold/marked
https://www.npmjs.com/package/8fold-marked - it seems to be getting used. Therefore, it seems like there is a significant chunk of the community who want to keep this library alive.
I would prefer to keep the library alive as "marked" instead of "8fold-marked".

the problem is deeper, I think handling markdown with regexes like marked did, is too limited, too soon (for GFM, etc..)

That may be. I'm not sure how Marked is limiting compared to alternatives considering the specification for Markdown, Multi-Markdown, and other variations are pretty well established...and spit out the same HTML no matter what...but I'm not building Markdown editors, just using one. Curious to know what you're seeing there. (I don't know what GFM stands for, I do apologize.)
Having said that, this is starting to feel like a "we shouldn't use alkaline batteries" discussion...despite there being thousands of people dependent on alkaline batteries.
This project is used by a lot of other packages. Those packages are used by a lot of other people and sites. I'm sure some of the packages who depend on it don't know the state of the project, which is arguably on them.
Whether regex is the best approach is not in question at the moment. Instead, the question is: How do we help other people dependent on this package? (Some will just switch to something else...others won't or can't...or don't know @chjj sorta wants to move on from it. Marked has 15,000 stars, 2,000 forks, 300 watchers, 50 contributors, 150 PRs, and 3.5 Million downloads in the last month...almost a million of those in the last week, which is where Markdown-it is for the month.)
Solve the immediate need, then figure out the long-term strategy; be it moving Marked away from regex, getting everyone off Marked, or whatever.

@joshbruce can you enable issues on 8fold/marked then as well please? :)

@ankon have you tried markdown-it? well, I'll unsubscribe, can't make thousands people migrate to a stable markdown lib alone

@caub, no, I haven't. markdown-it might be totally awesome, and certainly has a right to exist. But I don't think you can "make thousands people migrate to a stable markdown lib alone" by just asking that question and assuming that people will jump immediately towards the same conclusions you seem to have reached.
The reason I'm asking to enable issues on 8fold/marked is so that we can start working further on marked. This project is a dependency of a couple of our projects, and right now has issues/PRs that affect us. Spending time to switch libraries is not right now something I'm interested in.

Well good luck rebuilding a markdown lib

@ankon: Went ahead and turned on issues - wasn't planning on things going this route. To the best of my knowledge, I still haven't heard anything from @chjj re transferring the base project. Also turned on security vulnerability notifications.
@UziTech: Have you heard anything? Maybe I just missed something.

When I contacted @chjj I cc'd<EMAIL_ADDRESS>as it says in npm's disputes article. NPM did get back to me and asked if I wanted them transfer the marked name. I thought we were getting somewhere with @chjj and wouldn't need their intervention but maybe I was wrong.
Try emailing @chjj and cc<EMAIL_ADDRESS>maybe they can transfer the name and we can just start over with the repo at 8fold/marked.

@joshbruce Should we close this issue now that you can update this repo and the npm package?

@UziTech: That's a good question. After thinking about it, I tend to agree.
The ticket clutters the visibility of the other one, and we can always reopen it. Having said that, right now, this is a 30-day time-box for me to see how it goes. This project may actually be at the end of its life, and the focus may need to shift to helping transition and notify other packages and developers transition to something else.
If we (not I by myself) cannot make good strides in our efforts here given the constraints at hand (probably one of the biggest being my limited knowledge), then we'll have to change direction.


feat(pint): Improve pint cmd

Check if pint is available in PATH before using project specific version

imo it should use per-project installation first, then globally available ones.


Tagalog Translation for alert.md

Fixes #
Proposed Changes

wow, you're super fast

@tabuna  it's the way it is, if my method of translation is thought-by-thought and not word-for-word :)


COM-32 :: Add logging over oversized Server Push HTTP headers

Normally we use LoggerInterface to logs. It'd be a hassle  to use it so error_log is fine imo

Our WordPress logger logs to error_log anyway too.


inclusion rate is not updated for many nodes

The inclusion rate in the json is not updated reliably since Sept 10. Many nodes that are not active / nominated have a constant inclusion rate. This has a big negative impact on the calculated inclusion scores (200 in total) keeping these nodes from being selected.
Here is a graph of my two nodes. These are not an exception.

However, not all nodes have constant score. If they are active, the score changes.

Small update: over the last 24h, the inclusion field got updated once. However, before it updated more than once a day. Maybe every hour?

The backend is updating the inclusion rate regularly again. Here is an example of the 2 nodes and 4 additional ones (no legend for privacy reasons).

Feel free to close this issue since it seems to fixed (for now?).

Spoke too soon. The inclusion rate stays again constant for nodes that have not been active. The rate should decrease with each hour. In addition, the score.updated field is not even updated for many nodes.

closing this as it's likely outdated


[HOLD for payment 2023-10-12] [$500] Address remaining design inconsistencies for distance requests

From a post by @shawnborton (cc @dannymcclain)

Changed required:

Each push-to-page row has margin-bottom: 8px - let’s get rid of that so it’s a bit more compact and matches existing styles
the map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px
The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row
Let’s make the map preview image use the same border radius as other receipt previews, which I think is 16px

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a22578e8f0e37d00
Upwork Job ID:<PHONE_NUMBER>509253632
Last Price Increase: 2023-09-15
Automatic offers:

situchan | Reviewer | 26849648
akinwale | Contributor | 26849649

Let’s make the vertical margin on the map image something like 8px or 12px

Coming back to this one, we should decide one way or the other.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Design inconsistencies for distance requests.
What is the root cause of that problem?
None. New feature.
What changes do you think we should make in order to solve the problem?

Each push-to-page row has margin-bottom: 8px - let’s get rid of that so it’s a bit more compact and matches existing styles
Update MoneyRequestConfirmationList and conditionally remove the styles.mb2 style from each displayed MenuItemWithTopDescription if the distance request condition is true.

The map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px
Update styles.mapPendingView with the new vertical margin.

The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row
Update MoneyRequestConfirmationList and conditionally set the height and margins if it is a distance request.

Let’s make the map preview image use the same border radius as other receipt previews, which I think is 16px
Change borderRadius for styles.mapView to 16.

What alternative solutions did you explore? (Optional)
None.

@akinwale thanks for your proposal. Can you please share demo screenshot after applying your changes?

@akinwale thanks for your proposal. Can you please share demo screenshot after applying your changes?

@situchan Here's a screenshot with my changes applied.

@situchan Some additional notes about the margins used. Everything else updated to follow the original post.

the map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px

Used 8px margin here for both top and bottom.

The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row

Used 8px margin for the top here.

Proposal
Please re-state the problem that we are trying to solve in this issue.

Distance Request has design inconsistencies like extra spacing between fields and map.

What is the root cause of that problem?

It was implemented this way only.

What changes do you think we should make in order to solve the problem?
Solution for 1st and 2nd Points
1. Each push-to-page row has margin-bottom: 8px - let’s get rid of that so it’s a bit more compact and matches existing styles
2 .The map image itself has a bunch of vertical margin (20px) and thus it feels quite far away from the push row below it which also has vertical margin. Let’s make the vertical margin on the map image something like 8px or 12px

We will update in MoneyRequestConfirmationList with below styles:

styles.confirmationListMapItem (spacing.mv3 bcoz we want to update vertical spacing only and as all the items have 24px spacing in between so this keeps the consistency )

- {...spacing.m5, height: 200, }
+ {...spacing.m5, ...spacing.mv3, height: 200, }

Remove each styles.mt2 / styles.mb2 which is used with styles.moneyRequestMenuItem.

Solution for 3rd Point
3. Let’s make the map preview image use the same border radius as other receipt previews, which I think is 16px

For radius of map referring styles.reportActionItemImages which is 16px.

We will update borderRadius in styles.mapView from 20 to 16. (this will update in other places also.)

Solution for 4th Point (I have two solutions)
4. The “To” field above the workspace has a height of 32px. Let’s remove the height and just have some margin-top, but no need for margin below as the workspace row (avatar + name) already has vertical margin. This change should be applied everywhere we have a “To” row

Update styles.optionsListSectionHeader to {...spacing.mv1}. (Such that it doesn't cause much UI regression in other places like below). But this will create inconsistency in UI in other places.

Above issue will emerge if we only give marginTop to styles.optionsListSectionHeader

Add a overrideHeaderStyle to sections

    sections.push({
        title: translate('common.to'),
        ...rest,
        overrideHeaderStyle: {...spacing.mv1},
    });

and in BaseOptionsList update
- const renderSectionHeader = ({section: {title, shouldShow}}) => {
+ const renderSectionHeader = ({section: {title, shouldShow, overrideHeaderStyle}}) => {
- <View style={[styles.optionsListSectionHeader, styles.justifyContentCenter]}>
+ <View style={[overrideHeaderStyle || styles.optionsListSectionHeader, styles.justifyContentCenter]}> // we can add additional checks if required

What alternative solutions did you explore? (Optional)

N/A

But this will create inconsistency in UI in other places.

Good catch, so maybe we do need to give it at least 4px bottom margin then.

Not overdue. ☝

As this is straightforward style fix, I think we can go with first proposal.
@akinwale's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

@situchan any thoughts on my proposal?

@situchan any thoughts on my proposal?

I checked your proposal and not found any significant difference from former proposal.

Okay, just wanted to stop a regression from happening which Is mentioned in my Proposal.

Okay, just wanted to stop a regression from happening which Is mentioned in my Proposal.

yeah, regression fix is one of the main factors to pick up the proposal. But not for this one as they will be easily caught during PR review and testing.

I also had that confidence 😓, which broke today where i forgot to test the PR for longer sentences and reviewers also forget and it caused a regression. So saying from experience, the testing might miss this regression.

You can go with @akinwale ‘s Proposal, that I don’t mind. Just that be careful while testing and try to make the Proposers PR as regression free as we can.

@shawnborton Are the preview (date, description, etc) changes applicable to "only" distance requests? Trying to clarify because other money request previews share the same layout, sans the map view.

Those things are definitely applicable to all request types.

And yeah, ideally we have them as consistent as possible across all of them.

@akinwale's https://github.com/Expensify/App/issues/27052#issuecomment-1712142719 looks good to me.

I'm good with @akinwale's proposal.

@situchan My PR is ready for review.

Payment summary:

Issue reporter: N/A
Contributor: @akinwale $500
Contributor+: @situchan $500

Payment summary:

Issue reporter: N/A
Contributor: @akinwale $500
Contributor+: @situchan $500

There were a couple of days of delays during the PR review, and before the eventual PR merge action. Taking these into account, would this possibly be considered eligible for the urgency bonus? Thanks.

3 business days of delay was from internal review.
Here's proof:
https://github.com/Expensify/App/assets/108292595/0961e3e7-d993-4113-b839-7aa606a7c85a

@joelbettner Can to confirm these more recent comments?

@JmillsExpensify Yep, it took me a while to get around to reviewing. I've been completely inundated with auto assigned issues and reviews all the while trying to get higher priority code written for other projects.

Payment summary:

Issue reporter: N/A
Contributor: @akinwale $750
Contributor+: @situchan $750

Ok great thanks! I've updated the summary.

Still waiting on the BZ checklist from @situchan though in the meantime, I've paid out @akinwale.

This is just design inconsistency, not bug. I don't think regression test applies here.


"error": "11 OUT_OF_RANGE: invalid message"

Hi,
I'm a big mountebank API user and as my company is moving towards gRCP I'd thought I'd get ahead of the development and have setup a simple service to learn more about it..
I believe I have configured it correctly but it is failing when I send a message :(
Any advice would be appreciated.
Problem: Request is returning
{
  "error": "11 OUT_OF_RANGE: invalid message"
}

Setup
protocols.json
{
    "grpc": {
        "createCommand": "node /Users/tim/mountebank-grpc/src/index.js"
    }
}

Imposters (loaded successfully via postman)
{
    "protocol": "grpc",
    "port": 5050,
    "loglevel": "debug",
    "recordRequests": true,
    "_note_services": "need the name of the package, service and protofile location for this to load",
    "services": {
        "example.ExampleService": {
            "file": "/Users/tim/mountebank-grpc/src/protos/example.proto"
        }
    },
    "options": {
        "protobufjs": {
            "_note": "any options to protobufjs",
            "includeDirs": ""
        }
    },
    "stubs": [{
        "predicates": [
            {
                "matches": { "path": "UnaryUnary" },
                "caseSensitive": false
            }
        ],
        "responses": [
            {
                "is": {
                    "value": {
                        "_note": "gRPC mock unary call response",
                        "_note_streaming": "this is a unary/unary call, streaming requests need the value to be an array",
                        "id": 100,
                        "data": "mock response"
                    },
                    "metadata": {
                        "_note": "gRPC mock initial/trailing metadata response",
                        "initial": {
                            "metadata-initial-key": "metadata-initial-value"
                        },
                        "trailing": {
                            "metadata-trailing-key": "metadata-trailing-value"
                        }
                    },
                    "error": {
                        "_note": "gRPC mock error",
                        "status": "OUT_OF_RANGE",
                        "message": "invalid message"
                    }
                }
            }
        ]
    }]
}

Request (loaded via bloomRPC to <IP_ADDRESS>:5050)
{
  "id": 10,
  "data": "Hello",
  "common": {
    "operators": {
      "eq": true,
      "ne": true,
      "in": true,
      "and": true,
      "or": true
    }
  }
}

Response:
{
  "error": "11 OUT_OF_RANGE: invalid message"
}

mb.log
{"message":"[mb:2525] Loaded custom protocol grpc","level":"info","timestamp":"2021-07-02T06:50:56.496Z"}
{"message":"[mb:2525] mountebank v2.4.0 now taking orders - point your browser to http://localhost:2525/ for help","level":"info","timestamp":"2021-07-02T06:50:56.529Z"}
{"message":"[mb:2525] POST /imposters","level":"info","timestamp":"2021-07-02T06:51:02.461Z"}
{"message":"[grpc:5050] Open for business...","level":"info","timestamp":"2021-07-02T06:51:02.681Z"}
{"message":"[grpc:5050] [2021-07-02T06:51:02.679Z] server started on port '5050'","level":"info","timestamp":"2021-07-02T06:51:02.689Z"}

Clearly I understand little of gRPC so did a bit of reading and a bit of time messing with the impostor code and managed to get it working. :)
The code below works just fine.
Now to figure out how to get injection code to work 👍
'''{
"protocol": "grpc",
"port": 5050,
"loglevel": "debug",
"recordRequests": true,
"_note_services": "need the name of the package, service and protofile location for this to load",
"services": {
"example.ExampleService": {
"file": "/Users/tim/mountebank-grpc/src/protos/example.proto"
}
},
"options": {
"protobufjs": {
"_note": "any options to protobufjs",
"includeDirs": ""
}
},
"stubs": [{
"predicates": [{
"contains": {
"path": "UnaryUnary"
},
"caseSensitive": false
}],
"responses": [
{
"is": {
"value": {
"_note": "gRPC mock unary call response",
"_note_streaming": "this is a unary/unary call, streaming requests need the value to be an array",
"id": 100,
"data": "mock response"
},
"metadata": {
"_note": "gRPC mock initial/trailing metadata response",
"initial": {
"metadata-initial-key": "metadata-initial-value"
},
"trailing": {
"metadata-trailing-key": "metadata-trailing-value"
}
}
}
}
]
}]
}
'''


Android Basics: Viewmodel and State in Compose

In section 9, in the fourth step under 'To implement game-end logic' , there's sample code mistake:
With the current code, currentWordCount would be over 10.
I would change it as follows and it should be fine
private fun updateGameState(updatedScore: Int) {
   if (usedWords.size == MAX_NO_OF_WORDS){
       //Last round in the game, update isGameOver to true, don't pick a new word
       _uiState.update { currentState ->
           currentState.copy(
               isGuessedWordWrong = false,
               score = updatedScore,
-              currentWordCount = currentState.currentWordCount.inc(),
               isGameOver = true
           )
       }
   } else{
       // Normal round in the game
       _uiState.update { currentState ->
           currentState.copy(
               isGuessedWordWrong = false,
               currentScrambledWord = pickRandomWordAndShuffle(),
               currentWordCount = currentState.currentWordCount.inc(),
               score = updatedScore
           )
       }
   }
}

@yothio
Yes, I just saw that too.... why counting anyway, if the game is over? :-) Maybe it solves when the next step is implemented? Let's see what ist coming...

Hello @yothio, @AAB999,
Thank you so much for reaching out to us. This line definitely needed to be removed. The code snippet has been updated:

Happy coding!


[POAE7-2525] [Code Refactor] [Cider-Velox] Code refactor to passing references with const qualifier instead of passing value  for memory consideration

What changes were proposed in this pull request?

Code refactor to passing references with const qualifier instead of passing value  for memory consideration
Why are the changes needed?

improve code quality
Does this PR introduce any user-facing change?

No
How was this patch tested?

Passed existing UT
Which label does this PR belong to?

veloxIntegration

@harborn @XinDongIntel @ZJie1 please help to review


Route matching appears to ignore methods

Describe the bug
I am attempting to use routes and files to simulate API calls.
The documentation for application configuration contains the following rule for Routes:

Rule evaluation stops at the first match. A match occurs when the route property and a value in the methods array (if specified) match the request. Each request can match at most one rule.

When I have the same route with different methods configured, the second one is never considered, resulting in a 405 Method not allowed response
To Reproduce
Configuration:
{
  "routes": [
    {
      "route": "/items",
      "methods": [ "GET" ],
      "rewrite": "/getItems.json"
    },
    {
      "route": "/items",
      "methods": [ "POST" ],
      "rewrite": "/newItem.json",
      "headers": {
        "Location": "/items/f2906fe1-f647-4ce0-81fd-1de4884c4cca"
      }
    }
]

Calls to GET /items work.
GET https://<snip>.azurestaticapps.net/items HTTP/1.1

HTTP/1.1 200 OK

Calls to POST /items do not work
POST https://<snip>.azurestaticapps.net/items HTTP/1.1

HTTP/1.1 405 Method Not Allowed

Expected behavior
The POST call should return the contents at the configured rewrite location with the configured headers.

Hi, was this ever updated on the docs? We have been trying to make POST calls to an endpoint on our Nuxt app and could not figure out why it wasn't working until now.
Based on this article, it sounds like /api is the only place that POST calls can be made. If this is true, then your documentation on Nuxt sorely needs to be updated accordingly. Likewise, if we want to host a Nuxt app on Azure that has the ability to accept POST requests outside of /api what other options do we have? Just a node.js app service?
Thank you for your time!


make primitive creation aware of reorder_src/reorder_weight setting

As the title, we should make primitive creation aware of the reorder_src/reorder_weight setting.

@jgong5, @EikanWang, please help review this PR.


Remove device_get_binding from more samples

Incremental progress towards https://github.com/zephyrproject-rtos/zephyr/issues/32139 and generally moving towards the new devicetree-aware device model macros.
This is a subset of the work needed in samples/drivers.

This is finally green; please review

@Mani-Sadhasivam ping


v8.0.0 tag does not exist on Github

We can see the PR landed (#75), and npmjs.com show the latest version as v8.0.0, but the tag does not exist on Github: https://github.com/csstools/postcss-nesting/tags
Perhaps it was not pushed?

Version 8 has now been tagged on GitHub, as well as v8.0.1, which resolves an issue in CommonJS environments.
https://github.com/csstools/postcss-nesting/releases/tag/8.0.0
https://github.com/csstools/postcss-nesting/releases/tag/8.0.1


Make MSI publish pre-build event more robust to Visual Studio paths

Currently in order to use the msbuild command in the pre-build event, we follow the same procedure that is done in build.cmd for the pipeline, i.e.
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64 -winsdk=10.0.18362.0
This however would not work if the user has Community edition of VS or if it is in another location as observed by @jyuwono , so we should tweak this to make it more robust.

Is this still relevant for the latest version?
/needinfo


Explicitly triggering Karpenter to scale up?

Tell us about your request
I'd like there to be a mechanism to force Karpenter to scale up nodes, even when Pods are not in a Pending state. I could imagine it is an annotation that is applied manually to the Provisioner resources.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
There are going to be situations where we need more hardware to be scheduled, even if Pods may not be requesting it yet. Whether that is pre-scaling for some event, or due to a scaling bug (eg https://github.com/aws/karpenter/issues/1888) where Karpenter is not scaling up even though we need it to. Most other managed platforms provide a mechanism to tell the system to scale up "anyways".
Are you currently working around this issue?
Right now we have a shortcut tool for launching a pod with specific node selectors, and we just launch a blank pod that has that selector.. but that is clumsy.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hey @diranged, thanks for opening this issue.
Can you expand more on how you might want to see these surfaced as controls? Here is a feature request for overprovisioning, does this fit the same use-case?
In any case, forcing Karpenter to scale up when there are no pending pods would need to also implement special scale-down logic in order to maintain the forced extra capacity (think ttlSecondsAfterEmpty). In addition, if you want controls to manually dictate a Provisioner to provision, you also need to dictate the properties of that node and underlying instance, since these properties are computed based on the existing set of pending pods in the cluster.

I definitely understand that this isn't a trivial change - it seems that if the user wants to scale up nodes explicitly, there is going to have to be some amount of configuration available to them at the time to do it. I could imagine a few different scenarios.
Launch a node, any node
Launch a single node.. any node that could be launched by the Provisioner. Perhaps in this mode, its a random lottery for which node type gets launched.
$ kubectl annotate provisioner default karpenter.sh/launch=1
provisioner.karpenter.sh/default annotated

Launch a specific node type
Launching a specific node type from a Provisioner...  allowing us to proactively launch X number of a specific instance type.
$ kubectl annotate provisioner default karpenter.sh/launch/c6i.4xlarge=10
provisioner.karpenter.sh/default annotated

Setting the TTL for manually launched nodes
When manually launching a node, I could imagine that the Provisioner has a TTL that is set as part of its configuration.... .spec.ttlGracePeriodAfterManualLaunch: 3600. When a manually launched node is created, the node could be annotated immediately with this grace period, and only after that grace period would the node become eligible for "normal" lifecycle behaviors.

Oh here's another one that would be useful:
Rolling replacement of all nodes in a Provisioner
$ kubectl annotate provisioner default karpenter.sh/roll=true

This would be useful to let the provisioner do a rolling replacement of nodes. Obviously this adds a lot of logic, but we use this functionality regularly in our Spot.io managed groups.

Related: https://github.com/aws/karpenter/issues/2050


Error message when trying to calculate values of the structures with the hydrogen and dative bonds

Tested on Ketcher v2.2.1-115-gaf97cc42
Steps to reproduce:

Launch Ketcher.
With the 'Hydrogen Bond' tool draw a bond on the canvas.
Click on the 'Calculated Values' button.

Expected result: The fields in the "Calculated Values" window are filled with the correct data.
Actual result: An alert appears

"Error: IndigoException: molfile loader: unknown bond type: 10"  (remote mode).

"Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'molfile loader: unknown bond type: 10', 'molfile loader: unknown bond type: 10', 'RXN loader: bad header ', 'RXN loader: bad header " (standalone mode).

The issue is reproduced with the structures with the dative bonds.

Related issue https://github.com/epam/Indigo/issues/413

Reopen.
Only for Standalone version
Steps to reproduce:
1st case

Launch Ketcher.
With the 'Hydrogen Bond'/ 'Dative Bond' tools draw a bond on the canvas.
Click on the 'Calculated Values' button.

Expected result: The fields in the "Calculated Values" window are filled with the correct data.
Actual result: The error appears in the console. The fields in the "Calculated Values" window aren't filled.

2nd case

Launch Ketcher.
With the 'Any Bond'/ 'Aromatic Bond'/  'Single/ Double Bond' / Single/ Aromatic Bond' / 'Double/ Aromatic Bond' tools draw a bond on the canvas.
Click on the 'Calculated Values' button.

Expected result: There is no error in console. The fields in the "Calculated Values" window are contain text 'Cannot calculate properties for structures with query features'.

Actual result: The error appears in the console. The fields in the "Calculated Values" window aren't filled.

Fixed, tested v.2.4

https://github.com/epam/Indigo/issues/552


Name the default config default

Currently, if a dataset has no configuration, a default configuration is created from the dataset name.
For example, for a dataset loaded from the hub repository, such as https://huggingface.co/datasets/user/dataset (repo id is user/dataset), the default configuration will be user--dataset.
It might be easier to handle to set it to default, or another reserved word.

Addressed in #5331.


How can I define the combine and reduce operator in matrix-vector multiplication?

When I compute a matrix-vector(like y=A*x) product,I  want to define different operator to replace the original combine function(i.e. multiplication) and original reduce function(i.e addition).
However, it seems that cusp::multiply can only support to those function defined in cuda/functional.h, which is based on thrust/functional.h.
I wonder that if cusp supports to user-defined combine and reduce function in spmv. If not, can you give me some suggestions to achieve it? I guess  revising thrust/functional.h may be help.
Please give me some suggestion or solution. Any info will help, thank you !!

Is there any progress?  I also have this question:)


Fix various UI things in our paella integration

This mainly does two things:

some buttons are moved into a settings menu to make the player appear less crammed on smaller screens (resolution, captions and video layout)
the control elements (which are also buttons) inside the videos (i.e. maximize video, switch sides etc.) are now less opaque and also smaller when their containers are below a certain width (currently 400px)

Also:

the fullscreen button is now always on the rightmost side of the control bar (as you would expect)
the buttons for slide navigation were added to presentation videos

Things mentioned in #1196 but missing here:

hide Firefox PiP button:
-> this is not technically possible. Users need to disable it themselves in their browser.
hover color of vertical separation lines:
-> I believe this needs to be fixed in paella-skins as any custom changes are always overwritten by that.

Oh and I also noticed the thing @dagraf mentions in https://github.com/elan-ev/tobira/issues/1196#issuecomment-2218695823: Open submenus are not fixed but move with the screen when scrolling up or down. This also needs to be fixed in paella.
Closes #1196
Marked as draft bc I still need to figure out how to hide the settings menu when there are no menu items 🙈

Basically all changes look good to me and are a clear improvement! Code looks good as well. I have only two remarks:

the control elements (which are also buttons) inside the videos (i.e. maximize video, switch sides etc.) are now less opaque

I know this was discussed in the issue, but it's worth noting that this is also an accessibility concern. Making them less opaque obviously reduces contrast, and makes it hard to see for some people. Tobira does not yet have a high contrast mode, otherwise we could at least improve the situation in that mode. So yeah, maybe Olaf and David can reconsider whether the buttons in the current form (without this PR) are really too distracting.

Marked as draft bc I still need to figure out how to hide the settings menu when there are no menu items 🙈

I think I would prefer if the quality selection thing could always be there, even if there is only one quality. Then at least users can see the quality they are currently watching. I am not sure if it's possible to convince Paella of that though...

Testing this on a large screen, for once. A certain improvement can be seen, thanks.
However, adding the "Seek video to the previous/next slide" icons was not a request from my end, it was a fear I expressed because it leaves us with eight (!) icons within the video canvass. Which makes me give up on the idea of making them more opaque/"invisible", also in conjunction with the hover-over effect, the different black and grey backgrounds, Firefox adding its thing with a different grey, and the accessibility concerns Lukas mentions. Is there a chance therefore of hiding icons individually the way you added the icons for slide navigation?

I think I would prefer if the quality selection thing could always be there, even if there is only one quality. Then at least users can > see the quality they are currently watching. I am not sure if it's possible to convince Paella of that though...

+1. Which kind of kills the settings menu, does it? The additional "CC" probably shouldn't be hidden there.

Alright, I can certainly remove the changes to the button opacity again, and also the settings menu if we pull out captions and quality selection (which isn't what Lukas was saying with his comment - at least I don't think so - but I see how it could be read like that and you seem to be agreeing with that point, however interpreted).

Is there a chance therefore of hiding icons individually the way you added the icons for slide navigation?

Hm sorry, I'm not sure I understand. In which case should they be hidden and when are they supposed to be shown? In any case, I don't think paella supports that.
An alternative to the slide navigation buttons at the top is to have them at the sides of the video container (which are still inside the container, so that doesn't necessarily improve the overall situation:

Or should we just leave out that feature altogether?

also, re this comment (sorry for not adressing this yet): https://github.com/elan-ev/tobira/issues/1196#issuecomment-2206112365:
would you prefer it like this (with blod playtime and colors of the quality selector inverted, if we get rid of the settings menu again)?:

Alright, I can certainly remove the changes to the button opacity again, and also the settings menu if we pull out captions and quality selection (which isn't what Lukas was saying with his comment - at least I don't think so - but I see how it could be read like that and you seem to be agreeing with that point, however interpreted).

I see what you mean, maybe I misread Lukas' comment.

Is there a chance therefore of hiding icons individually the way you added the icons for slide navigation?

Hm sorry, I'm not sure I understand. In which case should they be hidden and when are they supposed to be shown? In any case, I don't think paella supports that.

Version 6 used to allow this. And with adding/removing the slide navigation icons, I thought this might be possible for other icons as well.

An alternative to the slide navigation buttons at the top is to have them at the sides of the video container (which is still inside the container, so that doesn't necessarily improve the overall situation:
Or should we just leave out that feature altogether?

Let's discuss this in our meeting.

I have opened https://github.com/polimediaupv/paella-core/issues/368 to address the issue of open submenus not being fixed to their trigger button, and https://github.com/polimediaupv/paella-skins/issues/6 to figure out what to do with the vertical lines in the progress bar.

For reference, I just checked: it is possible, by changing the Tobira configuration (specifically player.paella_plugin_config) to disable some buttons. For example:
paella_plugin_config = """{
    "es.upv.paella.frameControlButtonPlugin": { "enabled": false }
}"""

This disables the button that lets you see all slide previews. Sadly, the buttons that you, Olaf, wanted to remove most of all -- e.g. the "enlarge" button hovering over the video -- don't seem to be controlled by plugins? Or at least I don't see which ones are responsible for that so I can't disable it right now. But if we are really interested we could dig deeper or ask the Paella devs.


All dark color themes are broken after 1.78 update

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.78.2
OS Version: MacOS Ventura 13.3.1 (a)

Steps to Reproduce:

Download the latest (1.78) version of the VSCode
Set "Dark (Visual Studio)" or any other dark color theme
See brighter background around the code and darker in all other places. See the bright border around the terminal. Etc.

Before (1.77.3):

After (1.78.2):

The problem seems to happen only for dark color themes, light ones still work as before.

Can you test if the issue is present with our exploration builds based on a newer version of the runtime, https://az764295.vo.msecnd.net/exploration/2a026dbfa74a48e629f23f1d54fd7cd788a44ffb/VSCode-darwin-universal.zip

Can you try running with code-insiders --disable-gpu

@deepak1556 that fixes the problem

Thanks for confirming, please use the following setting https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration to disable hardwarre accleration until the issue is resolved. Can you provide the output of system_profiler SPDisplaysDataType

@deepak1556
Graphics/Displays:
Apple M1:

  Chipset Model: Apple M1
  Type: GPU
  Bus: Built-In
  Total Number of Cores: 8
  Vendor: Apple (0x106b)
  Metal Support: Metal 3
  Displays:
    Mi Monitor:
      Resolution: 3440 x 1440 (UWQHD - Ultra-Wide Quad HD)
      UI Looks like: 3440 x 1440 @ 100.00Hz
      Main Display: Yes
      Mirror: Off
      Online: Yes
      Rotation: Supported

@deepak1556 thanks for the help!

Omg you are right, it works fine for built-in display! And even after I close macbook and switch to the external display, it works without any problems. Only after reloading the problem appears again. I use a custom color profile for the external monitor, but for any other color profiles the problem seems to persist


add cumulative returns computed from returns just in the returns distribution tails

Might be able to just tack these plots onto the "Stress Scenario" grid of plots

As discussed: Use 2 standard deviations to filter.

As I thought about this further I think the best way for us to visualize this is to plot just these > +/-2 standard deviation daily returns as a continuous equity curve.  So basically just setting equal to 0 all returns that fall in between +/- 2 standard deviations, and then doing cum_return(all_tail_returns)
so by looking at this next to the overall equity curve of the algo we can visualize whether all of the tail returns are clustered near each other (e.g. like SP500 tail returns would be clustered in 2008/2009), as well as whether the negative or positive tail returns happen to to be auto-correlated with one another, etc.


Firestore distributed counters samples

Add new samples for distributed counters page. Continuation of: Go samples, Python samples

@samtstern, @BenWhitehead, please, review

These are great thank you!


Get-TfsWorkItem : Error invoking async operation (VS403474: You requested 279 work items which exceeds the limit of 200. )

This used to work. Recently I installed a new Win11 and the latest tfscmdlets.
Ran existing script and
$CSOs = Get-TfsWorkItem -Collection $coll -Project $proj -WorkItemType 'Repair Items' -IncludeLinks
this line now fails.  Is there a way to have it get all 279 items?

@lukeb1961 that was a known issue in versions 2.2.0 and 2.2.1. Next release (2.3.0) fixes it.
2.3.0 is likely to be released today or tomorrow.

2.3.0 is released. Closing this issue.
As always, thanks for the feedback!


Changes in pwa.yaml needs Symfony cache clear to works well

Description
Changes into pwa.yaml config requires a Symfony's cache clear to works well.
I've tried to require this bundle into a brand new Symfony demo project and after I've installed, following this page rendering instructions, the <link rel="manifest" href="/site.webmanifest"> HTML node doesn't appears until I've removed the Symfony's cache.
Maybe will be helpfull for others warns about to clears the cache, as a reminder, to save time looking for the missing manifest <link rel="manifest" href="/site.webmanifest"> rendering...
I can provide a PR into doc repository with a warning if you wants.

I updated the documentation pages.
This may be caused by the enabled configuration option that turns to true and has an impact on the Twig pages.

Great! Many thanks!!


Reset password flow not working correctly

What

The email received after asking to reset password is

no longer pulling in the name (says 'undefined')
no longer includes the link to reset the password on the button
no longer includes the link to reset the password in the email text

Therefore the user is unable to reset their password.
Where

Password reset email

This is what's expected

Mitigation for logging in is that people can still reset their password from the 'Forgot password' link via https://search.wellcomlibrary.org.

Oops, this'll be my fault! Will take a look shortly


How do I change installation for alternate location of libstdc++.so.6?

When I run ./bootstrap-vcpkg.sh and then ./vcpkg integrate install I get the following output:
(base) msewell@cluster:~/vcpkg$ ./bootstrap-vcpkg.sh
-- The CXX compiler identification is GNU 9.2.0
-- Check for working CXX compiler: /home/msewell/GCC-9.2.0/bin/g++
-- Check for working CXX compiler: /home/msewell/GCC-9.2.0/bin/g++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting the C++ standard library
-- Detecting the C++ standard library - libstdc++
-- Detecting how to use the C++ filesystem library
-- Detecting how to use the C++ filesystem library - <filesystem>
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/msewell/vcpkg/toolsrc/build.rel
[0/2] Re-checking globbed directories...
[76/76] Linking CXX executable vcpkg
Telemetry
---------
vcpkg collects usage data in order to help us improve your experience.
The data collected by Microsoft is anonymous.
You can opt-out of telemetry by re-running the bootstrap-vcpkg script with -disableMetrics,
passing --disable-metrics to vcpkg on the command line,
or by setting the VCPKG_DISABLE_METRICS environment variable.

Read more about vcpkg telemetry at docs/about/privacy.md

(base) msewell@cluster:~/vcpkg$ ./vcpkg integrate install
./vcpkg: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by ./vcpkg)

My guess is that Performing Test CMAKE_LIBC_PTHREAD - Failed is causing the problem with ./vcpkg integrate install when it looks for libstdc++.so.6: version `GLIBCXX_3.4.26' in /usr/lib/x86_64-linux-gnu. I installed a newer version of gcc in my home directory because the one in /usr/bin is gcc-5. vcpkg requires gcc7 or higher. My understanding is version GLIBCXX_3.4.26 is found in the new libstdc++ libraries used by gcc 9.2.0. I wonder if the bootstrap.sh or cmake files are not finding the newer version of gcc installed in it's own directory that is causing the problem.
CMakeOutput.log
CMakeError.log

Can't reproduce this issue with the latest vcpkg 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8.


wrong link to Pix2Pix on README.md

the link under Pix2Pix goes to PosetNet instead of Pix2Pix

Resolved via https://github.com/PracticalDL/Practical-Deep-Learning-Book/pull/68.


Is it possible to support React Native?

Might have better performance.
Also, if it is ported to React Native and published to App Store, users like me can pay for this great work!

Thanks.
It's not supported currently, and i'm to busy. 😩
if you have some good ideas, welcome to Pull Requests!

OK. I will see if I can get some time for this.
On Wed, Feb 15, 2017 at 21:03 xwartz<EMAIL_ADDRESS>wrote:

Thanks.
It's not supported currently, and i'm to busy. 😩
if you have some good ideas, welcome to Pull Requests!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/xwartz/PupaFM/issues/16#issuecomment-280206937, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYt7wNrci4Tdl05yDRKyvUKx-vpUvbBks5rc66FgaJpZM4MBy-N
.


Backport PR #1941, fix TLS handshake, to 6.2.x.

Tested using the ssl-post test by hand.

I already merged this before I noticed, but it was missing the commit body style for backports. Please do this in the future. It helps at least that this one has the original PR in it though.

Sorry.  I ended up applying the patch by hand and forgot to add back in the commit #.


add initial working m5stack_stamps3

Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

[X] Please provide specific title of the PR describing the change
[X] Please provide related links (eg. Issue which will be closed by this Pull Request)
[X] If you are adding an new boards, please make sure

[X] Provide link to your allocated VID/PID if applicable
[X] Add your board to action ci in correct workflow and alphabet order for release binary
[X] UF2_BOARD_ID in your board.h follow correct format from uf2 specs

This checklist items that are not applicable to your PR can be deleted.

Description of Change
Adding setup for m5 stack stamp s3

thank you @hathach, I think this is all set now, please let me know if I missed anything.

@jamesjnadeau In leu of making another PR I commented the fixes for the open changes

@hathach this should now be fixed, thanks @panguin6010  for the help!


fixing whitespace in string to double conversion

Current solution would trim leading and trialing whitespace, but will throw an error if its inbetween the string.

Thanks @gangatp .
Did you reformat the file?
If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

Thanks @gangatp . Did you reformat the file?
If these files require reformatting, please do this in a separate commit , as the intended change cannot easily be recognized in the diff.

yes by mistake will clear it


Evaluate using Tauri instead of Electron for wrapping into desktop application

Tauri has recently hit stable release making it a viable option for our desktop needs.  It has many advantages over electron (size, security, speed), and it is Rust after all. Right now they are also working on mobile support (still some time away though).
There are also plenty of open-source apps already using it - see here
This is only for a time-boxed exploratory work that can help us with evaluation (and as a backup in case we run into issues with wrapping electron in #2889 ).

The idea of cheap desktop was to get a fast working solution without changing anything in our codebase at all. If we plan to do proper desktop we can evaluate Tauri.
The advantage of electron should be that we do not have to maintain 2 different code bases / logics for the frontend.
I'm closing this for now.

just to clarify: this was meant as back-up in case the electron integration will turn out to be harder than we think and was not schedule in any iteration.


[BEAM-10887] Timer clear Reapply timer clear

Resubmitting this PR without the unrelated changes to the Dataflow runner.

Run Java PreCommit

Run Java PreCommit

Is it possible that this caused the recent failure in testTwoTimersSettingEachOtherWithCreateAsInputUnbounded  https://issues.apache.org/jira/browse/BEAM-12589 ?

When was the failure seen? The prior version of this PR that I rolled back
could definitely have caused this.
On Thu, Jul 8, 2021 at 3:54 PM Tyson Hamilton @.***>
wrote:

Is it possible that this caused the recent failure in testTwoTimersSettingEachOtherWithCreateAsInputUnbounded
https://issues.apache.org/jira/browse/BEAM-12589 ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/15135#issuecomment-876794533, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAYJVKM3QT6Q6PZEZ67HJ3TWYUCRANCNFSM477KW2QQ
.

Looking at the failure, I suspect this was caused by the bad PR, which I
have already rolled back.
On Thu, Jul 8, 2021 at 4:39 PM Reuven Lax @.***> wrote:

When was the failure seen? The prior version of this PR that I rolled back
could definitely have caused this.
On Thu, Jul 8, 2021 at 3:54 PM Tyson Hamilton @.***>
wrote:

Is it possible that this caused the recent failure in testTwoTimersSettingEachOtherWithCreateAsInputUnbounded
https://issues.apache.org/jira/browse/BEAM-12589 ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/15135#issuecomment-876794533, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAYJVKM3QT6Q6PZEZ67HJ3TWYUCRANCNFSM477KW2QQ
.

OK thanks, I'll keep an eye on the next run.

@tysonjh that test should be excluded currently from the Dataflow runner (the rolled-back PR accidentally removed that exclusion)