Added ETCD as backend

I have decided to add ETCD as a new backend since it is well integrated into Kubernetes. All the tests and the benchmarks pass without any problem, but I left that section in the README empty because I run it all in a Macbook pro M1, so I think it would be preferable to run it on the same machine again.

Nice, thanks for the effort, was thinking also to add this but hadn't enough time. Can you look for the linter errors ?

@majst01 hi, the problem is TLS InsecureSkipVerify set true. but it is possible to set to true that variable, in our case we use a custom SSL cert so we need to pass InsecureSkipVerify= true.

@majst01 hi, the problem is TLS InsecureSkipVerify set true. but it is possible to set to true that variable, in our case we use a custom SSL cert so we need to pass InsecureSkipVerify= true.

you can silent this linter error with `// nolint:gosec`` bevore the line of the complain

Codecov Report

Merging #74 (e1fe134) into master (8b60c49) will decrease coverage by 2.22%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   78.50%   76.28%   -2.23%
==========================================
  Files           7        8       +1
  Lines         642      759     +117
==========================================
+ Hits          504      579      +75
- Misses         74       99      +25
- Partials       64       81      +17

Impacted Files
Coverage Δ

etcd.go
64.10% <64.10%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b60c49...e1fe134. Read the comment docs.

Hi @majst01 I think all is good now

Awesome, thanks for this contribution.


Athenz installation problem - illegal option -o pipefail

When trying to run the script start-local-athenz.sh the following error appeared:

Upon further research it appears that this is a problem with sh in newer versions of ubuntu. After changing the script line from #!/bin/sh to #!/bin/bash the script behaved as expected, but showed errors in other scripts that used the same shell.
The script only ran successfully when I:

Changed scripts that use the set -o pipefail command to bash
Changed docker/Makefile to use bash instead of sh when running scripts on my computer
Changed the BASE_DIR to my Athenz folder location

@abvaidya do we need to keep the default sh in these scripts (looks like on ubuntu the default is dash which doesn't support pipe fail)? We can either switch to bash or just drop the pipefail option - is this required?

I dont see any harm moving to bash. Will do a trial run and see if we run into any issue.


Mock verification

faux should support verification that a mock got called with certain arguments.
cc: @muscovite

Are there any plans in the near future for this feature?

"near future" is overstating it but I definitely want to add this sooner rather than later. I actually did a proof of concept for this on some branch a while ago so it's very doable, I think I just got a little stuck in the UX for it and then stuff came up so I forgot about it and got stale. So hopefully in the near-ish future, but it largely depends on whether I get time/motivation for it or if someone puts a PR up for it.

@nrxus hi!
Is there some branch which is a good start point for delving in implementation of verification feature?

@BogdanKosarev I started working on it here a while ago: https://github.com/nrxus/faux/tree/mock-expectations
but it's fairly stale so no promises that it is easy to pick back up 😅


Errors should no longer be cleared

We should now seek to follow the error behaviour of module scripts, as detailed in https://github.com/whatwg/html/pull/2595.
In short:

Retain the error state in the registry indefinitely
Abort the instantiation process if there is a load error
Rethrow only at the execution phase if there is an execution error.

This has been implemented, with support for System.delete to clear this state (even though it isn't visible in the public registry.

Released in 2.2.0.


Output GPS accuracy in the GPX export

Having GPS accuracy somewhere in the GPX export would be very helpful for troubleshooting.
I'll implement this and provide a PR.

For backwards compatibility it would make sense.


Issue-434: Forcing pulling images from BC when latest is set

Description of the change:
In this PR, we turn a flag in the internally managed OpenShift build to force pull the images in the builder Dockerfile to refresh the latest tag.
Together with #416 we should be able to have a more robust and flexible approach to deal with image tags.
Motivation for the change:
Fixes #434
Checklist

[ ] Add or Modify a unit test for your change
[ ] Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@jakubschwan @domhanak can you please verify?


Fix client event buffering

I rushed a little with removing generics.
We need to keep separate buffer for each event, otherwise events of
different types encoded in Bytes will be mixed together.
This commit is partial revert of e98a940a9f746cc5c3a2fd8bbb7a10506476b125.

@UkoeHB done!


lua dependencies not seen for vim plugins built with buildNeovimPlugin

Describe the bug
Neovim does't see the dependencies of some plugins, for instance luasnip and jsregexp and reported here https://github.com/NixOS/nixpkgs/pull/311386 and  https://github.com/NixOS/nixpkgs/issues/306367 (there are other occurrences that we can link to this ticket).
Steps To Reproduce
add luasnip to neovim plugins and notice that checkhealth warns about missing jsregexp.
Expected behavior
No warning
Additional context
I solved the problem locally some time ago by creating a lua env with the closure of all vim plugins but it's not upstreamable IMO, not efficient nor clean.
I started writing a test to see how it worked on master and saw jsregexp was loaded into the packpath as a lua plugin. That's because of https://github.com/NixOS/nixpkgs/pull/311386 and is a red herring.
My current plan is:

to customize  vimUtils.packDir to aggregate the different propagated-build-inputs from the various plugins
and call addToLuaPath (a variant I have that loads propagatedBuildInputs as well) on the packpath dir.
wrap neovim with LUA_PATH and LUA_CPATH generated by this call.

NB: https://github.com/NixOS/nixpkgs/pull/311386 made me realize that packDir will pull transitive deps in the packdir regardless of if they are vim plugins. I think we should only include vim plugins in the closure to avoid mistakes but I will let that for the future as it could break stuff.
Notify maintainers
cc @teto

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

Current attempt https://github.com/NixOS/nixpkgs/pull/319325

Isn't this what the extraLuaPackages option is for?

fixed now that the PR reaches nixos-unstable \o/
The listing of propagatedbuildinputs in the packpath dir lets us wrap neovim with plugin executable dependencies too though that's not done yet.

https://github.com/lovesegfault/nixpkgs/blob/9b2e62243919d17b76d7a708e691cf4086e78802/pkgs/applications/editors/vim/plugins/overrides.nix
So to clarify, we can add propagatedBuildInputs into these now? or do we just put them in the normal dependencies key and it figures out whats a library and whats a plugin?

for now it just wraps lua libraries
https://github.com/NixOS/nixpkgs/blob/56d6da9252d433938ad9ae53b7c50f8bab10482e/pkgs/applications/editors/neovim/wrapper.nix#L174
but one could wrap executables, python dependencies etc. Just a matter of reading the propagated-build-inputs file in finalPackdir and select what we want to wrap.

Im just trying to figure out how a plugin author would go about declaring these. Would you just put it in dependencies in overrides.nix? So, this dependencies list is what is added to propagated-build-inputs?
Or is jsregexp also declared somewhere else as a propagatedBuildInput and thats just extra?

I agree that being able to specify required binaries and libraries for plugins in nixpkgs that would then properly be wrapped is very cool, after all I made an entire framework where thats a large part of why it exists. But if every single one is also getting added to the packpath that feels a little messy, hence the question, can we use propagatedBuildInputs in those overrides instead so that they can still be resolved via this mechanism without ending up in the packDir

Tested it out. You can in fact add it to propagatedBuildInputs instead of dependencies and it still works.
Maybe I can go through and move all the non-plugin dependencies in the dependencies lists in that file into propagatedBuildInputs so that they no longer show up in that packDir? or would that make vim users mad?


[SMALLFIX] Java 8 Improvement: replace lambda with method reference i…

…n alluxio.worker.file.FileDataManager#FileDataManager

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/855/
Test PASSed.


Clicking on the edit button reloads the page.

clicking on the edit button of the subject reloads the page for the first time

Hello, @ADRE9  for admin it is not reloading, please give more details.

Can you try it out on mobile and confirm.

Yeah i found out too many errors occur in mobile.I will look into this tomorrow.

I want to work on this issue.

@micksharma yeah you can do it.

I can work on this issue as a GSSOC participant

@ashirbad29 go ahead. @Mustafiz04 can you assign him. I am traveling and mobile doesn't have the feature of assigning people.


Provide session data for event

Parameters

start time (session time, record stamp)
number of entries to fetch

see issue on iracelog-protobuf


support for docker

Added this as an accident, wanted to merge this into my fork
However, decided still to leave it as a closed PR, since maybe someone would wanna write this a bit better than me :)


Mpu makefile changes

This set of changes adds support for MPU constraints.  Specifically, this fixes alignment for application memory areas, privileged stack generation, and specific linker implementation for the ARM processors with MPU support.

Codecov Report

Merging #6008 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6008   +/-   ##
=======================================
  Coverage   52.51%   52.51%
=======================================
  Files         406      406
  Lines       39683    39683
  Branches     7715     7715
=======================================
  Hits        20839    20839
  Misses      15663    15663
  Partials     3181     3181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6324d11...7d7b9ff. Read the comment docs.


Auto restore RED indices

Is your feature request related to a problem? Please describe.
RED Cluster is one of the major issue in today’s elasticsearch and opensearch cluster, where because of various reasons indices turn RED and hence searches will return partial results, and indexing into that index will return errors.
In simple words cluster is RED means: some primary shards are not assigned, which means that cluster data is not fully available in cluster.

Describe the solution you'd like:
To this problem I am proposing solution of auto recovering these RED indices from past successful snapshots with no data loss.
Recovering RED indices is two step process:

Identifying there will be no data loss after recover.
Recover RED indices from past successful snapshots.

Identifying there will be no data loss after recover:
For each shard opensearch maintains two special seq#:

local checkpoint# - this is the highest seq# for which all lower seq# have been processed in data node .
global checkpoint# (or just checkpoint#) - the highest seq# for which the local shard can guarantee that all previous (included) seq# have been processed on all active shard copies (i.e., primary and replicas).This Global check runs at every 30s interval.

Each and every opensearch node maintain sequence number of segments for the shard they are holding. When ever there is any update operation to a shard this sequence number is incremented. These two numbers are maintained in memory but also persisted in the metadata of every lucene commit.
public class SeqNoStats implements ToXContentFragment, Writeable {
private static final String SEQ_NO = "seq_no";
private static final String MAX_SEQ_NO = "max_seq_no";
private static final String LOCAL_CHECKPOINT = "local_checkpoint";
private static final String GLOBAL_CHECKPOINT = "global_checkpoint";

private final long maxSeqNo;
private final long localCheckpoint;
private final long globalCheckpoint;

But problem with sequence number is that it is maintained at each node level and if the node goes down, we lose the sequence number information details.
Hence Idea is to maintain the index write status at cluster level. Below is the approach via which we can determine if an index is fully recoverable from past snapshots without data loss or not:

Index Write :

Whenever there is index write to an index in Data Node

Check if snapshot is in progress
If Snapshot for index is in progress

If clean_to_restore_from_snapshot  is TRUE

Update clean_to_restore_from_snapshot to FALSE  in index setting
Update Index_Update_Time_Stamp with current time stamp  in index setting

Else If clean_to_restore_from_snapshot  is FALSE and Index_Update_Time_Stamp  is less than snapshot_start_time, then

Update Index_Update_Time_Stamp with current time stamp  in index setting

Else

NO ACTION

Else

if clean_to_restore_from_snapshot for index is  TRUE

Update clean_to_restore_from_snapshot to FALSE in index setting
Update Index_Update_Time_Stamp with current time stamp  in index setting

Else

NO ACTION

Snapshot :

When Snapshot creation completes for an index

If snapshot for the index was sucessful

If clean_to_restore_from_snapshot is FALSE

If Index_Update_Time_Stamp > SNAPSHOT_START_TIME for the index,

DO NOTHING , as there was index write after snapshot was started for the index.

Else update clean_to_restore_from_snapshot to TRUE

Else if Snapshot was failure for the index

NO ACTION

Batching Updates:
In order to ensure we don’t update cluster state for same index again and again for same value, batching mechanism is been  introduced. Batching mechanism works in following way:

Data nodes and Master node Push all request to update index setting to queue in elected master node
Elected master flush all request from queue every 30 seconds
Batch all request request together for same index together
Update index setting clean_to_restore_from_snapshot and Index_Update_Time_Stamp as needed.

Setting to be introduced as part of this feature:

clean_to_restore_from_snapshot : Index setting (Boolean) indicate if there was any write to index or not after past successful snapshot for the index.
clean_to_restore_from_snapshot_update_time : Index setting (TimeSatmp) indicate time when “clean_to_restore_from_snapshot” time was updated . [restore _snapshot_update_time?]
auto_restore_red_indices_enable : Cluster Setting (Boolean) to enable or disable auto recover red indices feature. TRUE by default.
auto_restore_red_indices_if_no_data_loss : Cluster Setting (Boolean) to choose if to restore RED indices if there was data ingested to index after past successful snapshot. FALSE by default.
auto_restore_red_indices_repository : Cluster Setting (String) to choose from which repository to auto restore red indices.

Pre-Conditions for auto recover:

RED Indices are HOT indices
There is no change in data after past successful snapshot in the RED indices (Configurable: This condition can be relaxed with cluster setting)
There is enough disk available on cluster to restore the data
JVM and CPU utilization is below 80% (configurable)
RED Indices are present in past snapshots
Recover Failure throttling limit is not reached

Recovering RED Indices:
We will have a scheduler running on elected master at at regular interval of time to recover RED indices .The recovery will work in following fashion:

Check existing RED index in regular interval(customer customizable, defaults to 60 mins)
and make sure the index is in RED state for x amount of time (customer customizable, defaults 24*60 mins) ,
and the index is/are recoverable from past snapshots with no data loss.
No snapshot restore in-progress
No snapshot deletion is in-progress
Get latest Snapshot Index mapping in which index is present
For all indices for which the above conditions are met it will

Close index
Get latest Snapshot in which the index is present from Snapshot Index mapping
recover the index and
reset the  “clean_to_restore_from_snapshot’ to true

Speedup Recover process:
Snapshot recovery is time consuming process and can take hours for index to get restored. Our idea is to optimize the total time taken to restore index. We will implement following mechanism to speedup restore process:

Restore at shard level
Increase upper limit of number of SNAPSHOT threads used for RESTORE operation

Api to track auto restore:
Will introduce an API to to track past auto restore events that happened . with response containing following details :

List of red Indices auto recovered with SUCCESS/FAILURE
Total time taken to restore (with start time and end time)
Snapshot name and snapshot time from which indices are been recovered

Additional context
Add any other context or screenshots about the feature request here.

Hi @piyushdaftary!
I really like this design, at Logz.io we have a (very) similar backend functionality already in place. We have experience implementing such mechanisms in production using mostly external services.
Therefore, I have one major suggestion -
Please split the feature into two parts:

the decision of whether a cluster requires a recovery operation AND is ready for that operation
the recovery operation task and logic

I highly recommend starting with (2) and creating endpoints to trigger the action first.
The reason is that (1) may differ based on the way you manage the cluster! maybe it would be better as a plugin of its own.
For example - if the node count is not what we expect it to be (cluster can be red due to data node failure) then we won't want to perform the recovery yet. A k8s operator may have trouble allocating the required resources for the new data node, and in the meantime, the recovery will start, not knowing the situation outside the cluster. There are different approaches to this process so I think it is more suitable as part of the mechanism of a k8s operator or other cluster governance operators out there. It seems like the "interchangeable" portion of the feature.
Having said that, I think if you consider that there is always data that has been indexed after the last snapshot you can minimize the size of the feature:

Anyone using OpenSearch for logging probably does periodically create snapshots but they are momentary and logs are always flowing in. Statistically speaking, logs always arrive after the last snapshot.
Recovery is better than not recovering, if you implement just the recovery process in one phase and the "auto" part as a plugin then users can decide how and when to do this.

I am having a call this week with the people that implemented this level of code at logz.io. I will add more insight if there is any once I have done that.

Hi @AmiStrn
Thanks for looking into the proposal and liking the design :) .
If I break the feature into two parts, then just implementing "recovery operation" first wouldn't add much value to opensearch as there already exists an API to restore indices from past snapshots.
As opensearch is self sufficient software, I feel it's better to implement the default version of restore feature (As proposed in design) as default in core and expose interface. So that if anyone want to implement different logic of restoration can easily implement it via their plugin. The default version of restore feature will ensure that restore is only triggered if there are enough resources available on cluster. Please see section "Pre-Conditions for auto recover:" section in design for details.
If customer wants to turn off the auto restore feature they can easily do it dynamically by updating cluster setting auto_restore_red_indices_enable to false.
For snapshot time, Yes you are right, its already available in repository and we are not again storing snapshot time. The two different time metrics are been captured in the feature design are :

When an index became dirty (means there was difference in data of index in cluster w.r.t. data in repository) and index setting clean_to_restore_from_snapshot updated
Restoration time of RED index by autorecover feature.

The Design also ensures that we don't update index setting clean_to_restore_from_snapshot on every index write/update. It is updated only when there is first write to index or if there is any write to index after last successful snapshot of the index. Details of the logic is mentioned in "Index Write :" and "Snapshot :" section of design. This also ensures we don't update the index setting unnecessarily for Inactive indices.
Customer can also update the setting auto_restore_red_indices_if_no_data_loss to TRUE if they want to restore only red indices where restoration will lead to no data loss. For remaining red indices they can plan to restore as they want.
Please share your view and also please feel free to point out if I missed anything.

If I break the feature into two parts, then just implementing "recovery operation" first wouldn't add much value to opensearch as there already exists an API to restore indices from past snapshots.

I think this separation will have some benefits

the PRs will be smaller
the separation is a logical one allowing other code to use this recovery based on different conditions
the separation allows for easy test separation as well

By saying separation I'm not saying you should abandon the auto recover part, just separate it in terms of phases and logic.
However, after running massive clusters for years I can say for sure that the most common reason for a red cluster is node failure. This means that in the design under "Recovering RED Indices:"  (I assume you are missing the validation section there) the part where you validate the cluster is ready for the recovery will most likely (from experience) fail until the cluster is ready. which means there will be many failed attempts until the cluster is ready, which may take a while, resulting in many redundant checks rather than only beginning the process when the cluster is ready for it.
At logz.io we use an event-based approach:
If the cluster is red (and a snapshot exists) the recovery starts by fixing the cluster nodes (if required), and then the event of that being done triggers the recovery from the snapshots.
This approach requires monitoring of the cluster health externally since we need to fix the nodes.
If it was a must that the cluster do this on its own, then the validation should have some sort of backoff mechanism to revalidate if the cluster is ready after some time. Otherwise, it will be a busy-wait or failed recovery situation pretty much every time a cluster is red due to node failure (which is almost every time a cluster is red).
Sometimes users will use shard allocation and routing settings to allocate certain shards to certain nodes. In this case, simply having enough disk space and CPU/JVM won't be enough to start the recovery. I feel like this part really needs to be handled more carefully. A default auto-recovery should be really conservative in my opinion if it is to be implemented.
If you want to go through with the full design you propose anyway, then please at least separate it as you said, so there are:

pluggable way to override and change the auto-recovery behavior.
the recovery part is separate allowing other users to use it in a flexible way (via API perhaps?)

Cheers:)
Amitai

Thanks @AmiStrn for your inputs.
I will try to phase out the PRs so that it is easy to review.
As Opensearch is self sufficient software, hence want the autorecover logic to be in core software logic itself.
Will make recover interface abstract so that if someone want to write custom plugin for recover they can easily do that.
I have added precondition check (please refer to section : "Pre-Conditions for auto recover"), to ensure existing cluster is capable of restoring from past snapshots. Please Let me know if I should add more conditions here.
Please do feel free to revert incase I missed anything.

What about my comment regarding: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-cluster.html#modules-cluster
There may be other cases like this..
I suggest looking at the implications and adding to the section you referenced regarding pre-conditions.
I asked other people maintaining production clusters and the general response I get is that the nodes must be fixed first, about 95% of the time, before recovery is done, and wherever there are routing settings things get even more complex. Please verify with opensearch operations teams at AWS that this design fits their needs, I am curious what they think as well:)
Also, I am not familiar with the notion of this system being "self sufficient".
I mean, the cluster can't reach out and repair its own hardware (yet!) - where do we draw the line on self sufficiency? In this case the logic would be to fix nodes and then recover, but in this design the cluster can only just try to recover in a rare set of cases that meet of all the preconditions (and flags). If you were the devOps person, would you truly rely on this working most of the time?
Thanks for the response!
Amitai

Hi @AmiStrn
Ack on point to explicitly do precondition check for shard allocation and routing settings before triggering  recover(missed to call it out in proposal). Thanks for suggesting it.
By self sufficient I mean say that instead of any external process triggering recovery,  opensearch code itself should be able to do the recovery.
It's true opensearch can't repair hardware on its own. To fix a hardware you need manual intervention which is usually time consuming process and during this duration data availability will be impacted. In multiple data node cluster, let's say if few of nodes failed which makes cluster to go in red state and remaining of the available cluster can sustain the load of cluster then autorestore will come as savior and will help in data availability in cluster. We have seen many instances (much more than 5% for sure) where autorecover can help without even manual intervention. And once let say after manual intervention the node failure is been fixed and node joins back the cluster, then shard relocation via BalancedShardsAllocator will evenly distribute the shards across data nodes. The main focus of auto restore feature is to make data available for search as soon as possible.

remaining of the available cluster can sustain the load of cluster

This implies the cluster could have been smaller in the first place. Which is usually not the case when trying to reduce costs.
Its almost as if you propose to have more memory and nodes than required in order for this to fully be operational?


Release-please did not open a release PR after merging to main

I merged https://github.com/googleapis/proto-plus-python/pull/301 which contained a conventional commit with prefix fix: however release-please didn't open a pull request.
The specific commit which should have triggered release-please to open a PR is https://github.com/googleapis/proto-plus-python/commit/c9a77df58e93a87952470d809538a08103644364 . See all commits to main here.

I'm also seeing this issue in https://github.com/googleapis/gapic-generator-python, after merging https://github.com/googleapis/gapic-generator-python/pull/1210. See commit https://github.com/googleapis/gapic-generator-python/commit/e8951064827c726bb651801336b86188e2628386 here .

The release PRs are now open on both repos.


Error while configuring using cmake (unable to find boost)

I get the following error while using Ubuntu 18 and cmake 3.19. Is "boost_headers" a package name or am  I missing something here?
############################################
CMake Error at CMakeLists.txt:10 (find_package):
Could not find a package configuration file provided by "boost_headers"
(requested version 1.71) with any of the following names:
boost_headersConfig.cmake
boost_headers-config.cmake

Add the installation prefix of "boost_headers" to CMAKE_PREFIX_PATH or set
"boost_headers_DIR" to a directory containing one of the above files.  If
"boost_headers" provides a separate development package or SDK, be sure it
has been installed.
-- Configuring incomplete, errors occurred!
######################################################

This solved it for me:
diff --git a/libjsonutils/CMakeLists.txt b/libjsonutils/CMakeLists.txt
index aabe7fc..eb6d87d 100644
--- a/libjsonutils/CMakeLists.txt
+++ b/libjsonutils/CMakeLists.txt
@@ -6,9 +6,11 @@ list(INSERT CMAKE_MODULE_PATH 0 ${CMAKE_SOURCE_DIR}/cmake)

 ##############################################
 # Declare dependencies
-set(MIN_BOOST_VERSION 1.71)
-find_package(boost_headers ${MIN_BOOST_VERSION} REQUIRED CONFIG)
-find_package(boost_regex ${MIN_BOOST_VERSION} REQUIRED CONFIG)
+set(MIN_BOOST_VERSION 1.75)
+find_package(Boost ${MIN_BOOST_VERSION} REQUIRED COMPONENTS
+             regex)
+#find_package(boost_headers ${MIN_BOOST_VERSION} REQUIRED CONFIG)
+#find_package(boost_regex ${MIN_BOOST_VERSION} REQUIRED CONFIG)

 set(MIN_RapidJSON_VERSION 1.1)
 find_package(RapidJSON ${MIN_RapidJSON_VERSION} REQUIRED MODULE)

Thank you both! @maggu2810 jut uploaded the project with your changes.


Crypto-coins errors on sell and buy

Hi fox,
i'm coding a scanner bot for short term profit however since the prices are different from coins to coins i got exceptions when buying and selling,i'm 99.9 sure that it has a relation with decimals and the way the function round() is doing the rounding. Here is a block of code:
        m1=client.get_klines(symbol=mycoin, interval='1m')
        tim=datetime.fromtimestamp(int(m1[-1][0])/1000)
        xlslog['Entred time'].append(tim)
        EnterPrice=round(float(m1[-1][4]),7)
        xlslog['inPrice'].append(EnterPrice)
        stoprsi=False
        buystat=True
        xt+=1
        Ploss=(float(EnterPrice)*0.08)/100
        divrsi=(float(EnterPrice)*0.6)/100
        Ploss=float(EnterPrice)-Ploss
        divrsi=round(float(EnterPrice)+divrsi,7)
        inprice=round(float(EnterPrice),7)
        qnt=round(float(15/inprice),4)
        try:
            buyorder = client.order_market_buy(symbol=mycoin,quantity=qnt)
        except BinanceAPIException as e:

            # error handling goes here
            qnt=int(qnt)
            buyorder = client.order_market_buy(symbol=mycoin,quantity=qnt)

Can any experienced coder that dealed with this issue before advise on an idea of how to solve it please?
Thank you in advance,
Regards,

Nobody?

What exception are you getting? I would need to see the full error message. If you are getting a Binance API exception, a complete guess without looking at anything is that you are not meeting the minimum order size or tick size.


Pointer is overlapping the text

VSCode Version: 1.15.1
OS Version: Windows 10

Steps to Reproduce:

Move the pointer to > 100 columns and it start to overlapping the text.

Reproduces without extensions: No

I could reproduce on Windows, with the default settings, on a line around column 800. From experimentation, I have noticed that the rounding errors are negligible up to column 300, so that is the new value I have hard-coded in the view line rendering.


broken image ?

In the latest image (2c241b797aff) I can't access the web ui (the connection is closed right away without any response). The moment I've switched to an older image (b66b4dfa1a5e ) it all works fine.

Can't confirm. I just did a git clone and docker-compose up and everything is running perfectly.

All looks fine for me. Closing the issue.


Ineed to enter the password again

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
Hi there,
I have the problem that he irregularly requests the password and I cannot use the control until I have re-entered the password and he has reconnected.
Can someone help me there?
What version of this integration (ha-tahoma) has the issue?
v2.10.1
What version of Home Assistant Core has the issue?
2021.12.1
Which gateway / hub do you use?
somfy connexoon
Device model
No response
Home Assistant log
No response
Additional information
No response

Please see the pinned issue. https://github.com/iMicknl/ha-tahoma/issues/599. This is a known issue.


Move provider to new "provider" package

This is done to allow testing only part of the resources
Include also moving resources into their own package

clusterwaiter
dnsdomain
clusterrosaclassic

Include also moving data sources into their own package

cloudprovider

/lgtm
/approve

/hold

@nirarg please rename the PR title

/hold cancel

/lgtm


Feature request: Auto-sync: Turn untimed transcript text into captions like YouTube Studio and Descript

Thanks for the great software! I wanted to share the following feature request:
YouTube allows people to paste or upload a plain text transcript for a video, and it will automatically assign timings for the text to generate timed captions, which can then be exported as .srt, .vtt, etc. This feature is called Auto-Sync. Descript offers a similar syncing feature.
The procedure would be that user has a video or audio with text transcript of the media. The text has no timing information, and the user would like to generate captions/subtitles from that text. So the user provider the media and the text, and the platform automatically adds timing and syncs up the text to the media.
This tutorial provides a good demo of the feature on Descript: https://www.youtube.com/watch?v=dzAexFlyNNI

There is currently a lack of a tool that can directly translate srt or txt file subtitles into other languages.  I have searched through github, but have not yet found such software

Hi @wzgrx : This issue isn't about translating captions to another language (which is already possible in YouTube, Memo AI (instructions), etc.)
It's about automatically adding timings to a text transcript that originally had no timings, based on the audio file.

Thanks Candideau for clarifying. Was just trying to help. Where is the most apppropriate spot to ask about the most recent update being ported over to Mac. I haven't seen it in the Mac App Store nor with the other releases. Cheers and thanks muchly.

@Sircam19 I would suggest searching existing Issues and Discussions on the relevant topic and adding comments to those, or creating your own Issue or Discussion post.
Good luck!

Since version 1.0.0 Buzz supports translations via AI, for more information see this https://chidiwilliams.github.io/buzz/docs/usage/translations
Regarding adding timings to the existing text, I am doubtful Buzz will integrate this feature any time soon. What is the use case? Transcription in your language has poor quality and that is the reason you would like to use existing test?
Currently you can just ignore the existing test you may have and generate new subtitles from audio or video. So curious why this scenario does not suit you and why you would like to use existing text?

Regarding adding timings to the existing text, I am doubtful Buzz will integrate this feature any time soon. What is the use case? Transcription in your language has poor quality and that is the reason you would like to use existing test?
Currently you can just ignore the existing test you may have and generate new subtitles from audio or video. So curious why this scenario does not suit you and why you would like to use existing text?

@raivisdejus If I write up a script, and then read that script for a video (because I memorized it, or because I was using a teleprompter), it's a lot more efficient to add timed captions to that existing text, than to generate new captions which won't be 100% accurate (because misspelled names, acronyms, punctuation that is off, homophones, etc.). It saves the hassle of having to go over the generated captions to correct mistakes. I've used Whisper in both French and English, two well-supported languages, and it never gets it 100% right.
I've had to do this in the past for the following kinds of footage:

Live speeches
Recorded presentations and lectures
Scripted fiction (TV episodes, films -- anything with an existing script)
News anchor segments
Livestreamed intros

YouTube and Descript are the only tools that have that feature that I've found, but they are proprietary tools, and require the user to upload their content to their servers. There are certain industries where sensitive information can only be processed locally, hence making a FOSS tool like Buzz important.


ticktick: init at 1.0.80

Description of changes

This is a proprietary task management & time tracking app I use on iOS. It's a repackage of the public-available .deb packages they provide for Debian derivatives.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ah and please also rename the title of this PR to "ticktick: init at 1.0.80" (include the version too)

Ah and please also rename the title of this PR to "ticktick: init at 1.0.80" (include the version too)

Done

also the part in the maintainers list needs to be a separate commit.

Is this going to need me to rewrite the whole PR? I'd need to go back to when I implemented that and redo the commit.

Also I dont think you need a new commit for the conversion to finalAttrs.

It's a refactor I made after rebasing, so it still gets a commit

It's a refactor I made after rebasing, so it still gets a commit

Sure, but you dont need a handful of commits if you just introduce a package, you can squash them. After that it looks good to me.

It's a refactor I made after rebasing, so it still gets a commit

Sure, but you dont need a handful of commits if you just introduce a package, you can squash them. After that it looks good to me.

I'll squash once I finish work later then.


progress-bar float tracker

minepkg-companion now displays the progress float during the splash screen.
Please review my PR!

Also, maybe I'm missing something, but doesn't the splash screen already have a progress bar? Why does the console need one?
Since SplashOverlay is a client-side class, this also won't work for servers, though I guess servers have the "Preparing spawn area" progress, so that's fine.

Hey, thank you for the review! fiws made me to do it, I think it ties into some other feature coming later on.

fiws made me to do it

Blink twice if you are in need of help :detective:

I think it ties into some other feature coming later on

I think I know what that feature is and now the progress in the console makes sense - it's probably a secret so I won't tell.

While testing this, I found that it could sometimes log a 100% progress multiple times and maybe that's fixed or at least reduced when injecting into renderProgressBar instead of render, since the first won't be called once the reloadCompleteTime is set.
(It also often happens that the progress doesn't reach 100% but I guess that doesn't really matter that much.)
Apart from that, the TODO is probably not needed anymore.


Hide Minimap?

Since the virtual screen uses the bounds of the view anyway, I don't see any point in displaying the minimap.

I attempted an implementation for this but it seems you must set the minimap visibility via the window object. There's no way to subscribe to an event that tells you if the minimap visibility changed, so while you can remember the last setting in a view event listener there's no way to listen to a changing event. I suggest to make this low priority.

As far as I know its not possible for at plugin to control the minimap ?

It's available under view.window().set_minimap_visible(True/False) and view.window().is_minimap_visible(). The problem then is that the minimap being visible is a property of the window, for our purposes it should have been a property of the view.

Oh didn't know that :-) But yea - we probably shouldn't mess with the window.

I guess we can close this.


I have to reset server when i create new pages

Versions

nuxt: v2.14.7
node: v12.20.1

Reproduction

Main OS: Windows 10
Working on: Debian virtual server with virtualbox and shared folders
Dockerized node

Steps to reproduce
Create a new nuxt project
Add new page called for example: "new.vue"
Check .nuxt/routes.json and server console, the new page is not added to routes.json and you can't access the page on localhost/new
What is Expected?
The routes.json file should refresh automatically.
What is actually happening?
The routes.json keep the old configuration. I have to restart my docker to make the new page work.
It's probably due to shared folders. The new file creation is not detected.

@ghostlexly Check out https://github.com/nuxt/nuxt.js/issues/2481#issuecomment-356074552 and let me know if that solves things for you.


marti_messages: 0.0.1-1 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository marti_messages to 0.0.1-1:

upstream repository: https://github.com/swri-robotics/marti_messages.git
release repository: https://github.com/swri-robotics-gbp/marti_messages-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: null

@evenator Please close your superseded PRs (#9544) next time.

Thanks, I'll do that in the future.


⚠ Bofrost.at has degraded performance

In 64ba541, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1184 ms

Resolved: Bofrost.at performance has improved in c3b1da8.


Remove external/ directory

This removes the (no longer used) external/ directory and the code that was in it.  See #978 for some background.

coverage: 94.425%. remained the same
when pulling 3ec2f880eab875c51b5ad2893502fcbb448bec43 on murrayrm:delete_external-30Mar2024
into 4d878a966ca576f53b0d2ae9fd93ce598f60d748 on python-control:main.


Usage in production

Is it OK to use this package for production or it has some negative implications? Are there some performance or security issues when comparing to "native" PHP 5 code?
Also, is PHP 7.2 supported and what version of PHP 5 is this (PHP 5.5, PHP 5.6)?

We are not maintaining this package any more. Feel free to fork our code and maintain your own copy.


chore(tauri.js): Update yarn.lock

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[x] Other, please describe: Chore

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[x] No

The PR fulfills these requirements:

[x] It's submitted to the dev branch and not the latest branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
yarn.lock was out of sync

🤔 I thought we weren't shipping lock-files?

Right, libraries don't usually ship lockfiles. However, yarn audit requires either a lockfile or node_modules folder


Restructure the data

the data folder is spammed with lootr.dat files (over 2600 files from 3 weeks)
My suggestion would be creating a parent folder for this
/world/data/lootr
image

Hey!
Unfortunately, this isn't something that I actually have any control over. It will generate 1 file for each chest/container that spawns on the server. This is primarily to prevent corruption which might occur if all of the data was stored in the same file.
As I rely on Minecraft's SavedData, I can only control the name of the file, I can't actually control the directory that it's in.

Oh hm... there is a mod called "FLAN" that adds a "claimdata" folder into the data folder. any chance I can send you the repo to see how they did it?

Okay, looking further into the FLAN mod, it looks like they use a custom data system to save information.


Cannot find module 'react'

I get an error
Cannot find module 'react' from<EMAIL_ADDRESS>I installed react both in dependencies and devdependencies
Here's my test file:
import React, { useEffect, useState  } from "react";
import Enzyme from 'enzyme';
import EnzymeAdapter from '@wojtekmaj/enzyme-adapter-react-17';

import App from './App'
Enzyme.configure({ adapter: new EnzymeAdapter() });
test ('renders learnt react link', ()=> {
    const {getByText} = render(<App />);
    const title = getByText("Search and Select Snippets");
    expect (title).toBeInTheDocument();
})

Here's my package.json:
{
  "name": "axwayprerequisites",
  "homepage": ".",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@testing-library/jest-dom": "^5.11.4",
    "@testing-library/react": "^11.1.0",
    "@testing-library/user-event": "^12.1.10",
    "axios": "^0.21.0",
    "bootstrap": "^4.5.3",
    "dompurify": "^2.2.0",
    "env-cmd": "^10.1.0",
    "jquery": "^3.5.1",
    "logrocket": "^1.0.14",
    "react-bootstrap": "^1.4.0",
    "react-dom": "^17.0.1",
    "react-hook-form": "^6.9.6",
    "react-scripts": "4.0.0",
    "react-select": "^3.1.0",
    "react-tabs": "^3.1.1",
    "web-vitals": "^0.2.4"
  },
  "scripts": {
    "start": "react-scripts start",
    "start:local": "env-cmd -f ./.env.local  react-scripts start",
    "start:testlocal": "env-cmd -f ./.env.testlocal  react-scripts start",
    "start:test_remoteserver_localclient": "env-cmd -f ./.env.test_remoteserver_localclient  react-scripts start",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
    "build": "env-cmd -f ./.env.local react-scripts build",
    "build:local": "env-cmd -f ./.env.local react-scripts build",
    "build:prod": "env-cmd -f ./.env.prod react-scripts build",
    "build:remoteTestServer": "env-cmd -f ./.env.remoteTestServer react-scripts build",
    "toto": "env-cmd -f ./.env.toto node toto.js"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "devDependencies": {
    "enzyme": "^3.11.0",
    "react": "^17.0.1"
  }
}

"react" probably shouldn't be in devDependencies, but rather in dependencies.

Hi wojtekmaj , thanks for answering
react was initially in dependencies. I added it to devdependencies because I read somewhere that that could solve this kind of problem.
Anyway I tried with a) in dependencies, b) in devdependencies, c) in both, and the error persists.

I'm sure that react should be in dependencies.
Consider removing your package-lock.json or yarn.lock (depending on the package manager used, but given the weirdness of this issue I suppose it's NPM ;) ), remove node_modules and try installing your app again.
Check npm list react if you didn't get multiple copies of React in your repository.

Can it reside in the peerDependencies instead? I have a library which gets included in other local React project.

In adapter they are in peerDependencies. We were discussing OP's own package.json.

I believe we are talking about the same thing.
Can the React dependency reside in the peerDependencies instead of the dependencies, as discussed above?

I no longer have this problem, not sure how it occurred or how it disappeared. I'm closing it. My thanks to @nemanjamilosavljevic-newtron  and @wojtekmaj

I no longer have this problem, not sure how it occurred or how it disappeared. I'm closing it. My thanks to @nemanjamilosavljevic-newtron  and @wojtekmaj


Iteartion on Process -> Extract data

Description

Update action name "Process" -> "Extract"
Update icon
Show tags filtering only on Folders

Risk
N/A
Deploy Plan

deploy front

PMRR


Update Onfido SDK to 13.1.0

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17395
PROPOSAL:
Tests

Tests are only relevant for Web and desktop:

Click on ‘profile’ avatar
Click on ‘Workspace’ link
Open an existing ‘Workspace’
Click on “Connect bank account’ link
Click on “Connect manually” link
Fill out all forms, and click submit button leading up to “Get secure link” page
Click on ‘Get link via SMS’
Enter number and click on ‘Send link’ button
Verify there is a Try another method option
Verify that clicking it navigates back to the Get secure link page

Offline tests

NA
QA Steps

Same as test steps

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/12268372/11260d44-83fd-40d4-acc6-94070fd82250

Mobile Web - Chrome

NA

Mobile Web - Safari

NA

Desktop

https://github.com/Expensify/App/assets/12268372/cab2fdbf-2f7f-4657-b6c5-74f15d062183

iOS

NA

Android

NA

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

uploadFallback is removed. Let's remove it as well.

Thanks for catching that, @parasharrajat! Created a follow up PR here: https://github.com/Expensify/App/pull/23983

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.50-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore(deps): update

:tada: This PR is included in version 1.4.4 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Adjust diff granularity

Changes

Updates the diff in the following ways:

Remove upper limit on diff
Split changes across nodes
Split insertions that span multiple nodes

Notes for reviewers

Easiest to go commit by commit, the commit messages should suffice in explaining the change alongside the accompanying test
Use yarn link to and build this locally, try checking the diff on multiple documents

Checklist
Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

@dakotalraymond thanks for the review, there is one failing test which I've struggled to follow, it might be that the expected value just needs to be updated, but would be great to get your help with it


Included collection of DscEngineCache.mof contents

This change is

Hi @Indhukrishna, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Indhu Sivaramakrishnan). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

CollectDscDiagnostics.psm1, line 382 [r1] (raw file):
This is surely a simple change, and can we still include a simple corresponding test?

Comments from Reviewable

Added a unit test

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


feat: invite flow without escrow payments

Description
This PR:

add inviteMethod remote config (enum)
the send amount button now displays loading state when verifying phone number OR reviewing amount
if the phone number is unverified, display a full screen modal with share option

https://user-images.githubusercontent.com/20150449/186867113-26b9ddf9-c1e7-431d-8fa9-a2be57f5cc3b.mp4
Other changes
N/A
Tested
Manually
How others should test
In alfajores, when sending to a contact that is not verified on Valora, the flow https://www.figma.com/file/8ig95B4sfsYIDIpg3JGP03/Phone-Verification?node-id=1336%3A19069 should be triggered (instead of continuing to send the payment to escrow)
Related issues

Fixes RET-379

Backwards compatibility
Yes

Hey @MuckT we have verified the above task on Latest iOS Alfajores build V 1.40.0 and updated status in Test Rails.
Observation :

URL seen in prefilled message while sending invite is seen different as compared with Figma screen shared in the PR and we have raised query for it

New Query : link
Test Rail link:
iOS 14: https://valoraapp.testrail.io/index.php?/tests/view/69516
Device : iPhone 12(14.7.1)
CC : @kathaypacific
Thanks.!

@ValoraQA for this pull request the invite link is expected to be generic as mentioned in the AC for RET-379.

Hey @MuckT we have verified the above task on Latest Android Alfajores build V 1.40.0 and updated status in Test Rails.
Observation :

Green colored line is seen on send invite link page for Android platform, which is not seen on iOS platform and we have raised bug for it
New Bug : https://github.com/valora-inc/wallet/issues/2852

Test Rail link:
Android 11 : https://valoraapp.testrail.io/index.php?/tests/view/69547
Device : Google Pixel 2XL(11.0)
CC : @kathaypacific
Thanks.!


needs update

This is a great mod so it should be continued.

Do you have any suggestions on what to do with it? I feel like the mod is fine as is

you should have the reel spawn mobs you have to fight for good rewards its the nether, ya know? if your fishing in lava it makes sense. maybe its like a turtle and you can kill it for scales to brew with and to have a fire res Armour.

also strides scare the turtle.

don't call it a turtle I just thought it would be fairly do-able graphically.


Atom not saving theme settings

Description
Although I change theme, everytime I start atom, default theme is loaded. No external package is installed yet.
Steps to Reproduce
1.- Change default theme
2. Close Atom
3. Open Atom
Expected behavior: The theme I choose is loaded. Welcome tabs are not opened.
Actual behavior: Default theme is loaded. Welcome tabs are opened.
Reproduces how often: Everytime I run Atom
Versions
Atom : 1.52.0
Electron: 6.1.12
Chrome: 76.0.3809.146
Node: v12.4.0
OS version; Mac OS Mojave 10.14.6

I tried changing the theme on atom 1.52.0 macOS catalina 10.15 it worked as expected and the change was saved after reloading. Have you tried running atom in safe mode?

I fixed the issue by adding in config.cson following lines:
  themes: [
    "one-light-ui"
    "one-light-syntax"
  ]


Run downstream pipeline jobs

This is in response to Issue  #876. The problem was/is that the job I tried to run actually triggers a downstream pipeline. gitlab-ci-local does not run the jobs contained in that downstream pipeline. Is this a known limitation? Is there another way I can run downstream pipeline jobs? Here is a minimal example: https://github.com/Time0o/gitlab-ci-local-test.
gitlab-ci-local downstream-pipeline outputs:
parsing and downloads finished in 31 ms
downstream-pipeline starting shell (test)
downstream-pipeline finished in 4.99 ms

 PASS  downstream-pipeline

And gitlab-ci-local test-job yields:
parsing and downloads finished in 30 ms
test-job could not be found

It looks like a duplicate of this issue https://github.com/firecow/gitlab-ci-local/issues/94


style: Lint tests folder

Pylance was flagging many lines. Added tests folder into the type checker.

Yes. Great idea


Custom status max size 16Kb -> 64kb ?

About the statement:

The custom status payload is limited to 16 KB of UTF-16 JSON text because it needs to be able to fit in an Azure Table Storage column. We recommend you use external storage if you need a larger payload.

AFAIK the table storage max column size it's 64kb not 16kb

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 921c8c10-74b3-9cac-1eb3-3a9f9a1cabed
Version Independent ID: 6bc27b8e-b629-613e-dfb2-5ff8ae7a8a3b
Content: Custom orchestration status in Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-custom-orchestration-status.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: azfuncdf

Hi @gunzip Thanks for your feedback. We will review and update as appropriate.

@gunzip I have assigned this to content author for further review and update as appropriate.


Reference cis2 settings from credentials

This just about completes the migration from using MAVIS__ environment variables for secrets to using the Rails credentials.

Have added SENTRY_DSN to this as well.


Changing pageSize based on container height

So, I've accomplished to change the pageSize based on my live resizable container: It works well until I change page.
Once I change page, if i reduce the height of the container, the height of the table can't go lower then the height when I changed the page.
In other words when I change the page (from page 1 to page 2 for example), let's say the height is 360px with ~12 rows, if I go higher the 360px rows are "added" smoothly, but when I go under 360px, the height of the table doesn't change anymore.
NOTE: before changing the page everything works smoothly.

This is an implementation issue. We suggest you join the #react-table Slack channel where there are a wider range of people to assist with your question. You may also like to consider putting up a codesandbox of the issue for others to review. Thanks.

Is this really an implementation issue? My implementation is pretty straight forward:
import React from "react";
import ReactTable from 'react-table'

export default class Table extends React.Component {

  componentWillReceiveProps(newProps) {
    if (this.props.y != newProps.y) {
      // size row
      let rowHeight = 32.88;
      // size resizable panel
      let panelHeight = newProps.y;
      // size of the extra y of the table (header + footer)
      let extraTable = 27 + (this.props.x < 650 ? 75 : 45);
      // setting pageSize of the table
      this.setState({pageSize: parseInt((panelHeight - extraTable) / rowHeight)});
    }
  }

  render() {
    return (
      <ReactTable
        data={this.props.data}
        columns={this.props.columns}
        pageSize={this.state.pageSize}
      />
    )
  }
}

Given that react-table is designed for fixed page sizes (modified by the using by setting the the provided page size dropdown) this more dynamic use of pageSize could potentially break due to how react-table tries to pad rows to maintain the page size.
You could try using defaultPageSize as the prop instead. You may need to consider setting the pageSizeOptions to a finer level of detail (even though you have them disabled.
This is why I said it was an implementation issue because even though what you want to do may seem simple it may be fighting against some of the design goals of react-table.

Solved by using the defaultPageSize instead of pageSize, and changing the key of the component to force re-render (based on the pageSize itself):
render() {
return (

)
}


reset setting

how can I reset visual studio code to factory default

@NgocAnh5965 you may be interested in https://github.com/microsoft/vscode/issues/130510

https://code.visualstudio.com/docs/setup/setup-overview#_how-can-i-do-a-clean-uninstall-of-vs-code


feat(styles-migration): add automatic migration for bootstrap button component btn-icon class

Preview environments are getting posted here, as soon as they are ready!


chart: Add option for separate /v1/update and /flatcar ingress

Add option for separate /v1/update and /flatcar ingress
Optionally add an extra ingress handling paths /v1/update and /flatcar,
allowing different whitelisting options to the user interface and the
update endpoints.
How to use
Enable extra ingress and set different annotations. Example values.yaml snippet:
ingress:
  enabled: true
  annotations:
    # address anonymized
    nginx.ingress.kubernetes.io/whitelist-source-range: <IP_ADDRESS>
  update:
    enabled: true
    annotations: {}

Testing done
Web interface is only accessible from <IP_ADDRESS>, flatcar nodes from anywhere can be upgraded.

Hi @robinelfrink , can you give me a bit more context about this change (we don't have a /flatcar endpoint)?

Hi @robinelfrink , can you give me a bit more context about this change (we don't have a /flatcar endpoint)?

This what my ingress controller says (anonimized) when I leave that path out:
[ingress-nginx-controller-5j4q6] <IP_ADDRESS> - - [23/Mar/2021:14:31:02 +0000] "GET /flatcar/flatcar-amd64-2765.2.1.gz HTTP/1.1" 403 153 "-" "-" 90 0.000 [nebraska-nebraska-80] [] - - - - f18726db811732e0075e0c06a33fce01

Maybe it's because we have config.syncer.enabled: true ?

Found it here:
PackagesURL:       conf.nebraskaURL + "/flatcar/",

You're right!! The hosting option!
Cool. I will let @knrt10 review.

Now that I know where it's coming from, I think it should be configurable.
The least I can do is wrap an {{- if .Values.config.hostFlatcarPackages.enabled }} around it, and if possible even check if ingress.hosts matches config.hostFlatcarPackages.nebraskaURL and try to get the absolute path from that.

I added logic to extract the endpoint from config.hostFlatcarPackages.nebraskaURL.

Merged. Thanks @robinelfrink and @knrt10 .


FileNotFoundError: [Errno 2] No such file or directory: 'COCO_ROOT/annotations/instances_trainval35k.json'

When I run train.py It shows an error: FileNotFoundError: [Errno 2] No such file or directory: 'COCO_ROOT/annotations/instances_trainval35k.json' but only have 'instances_trainval35k.json.zip' in that place.Whaat's wrong???

loading annotations into memory...
Traceback (most recent call last):
File "train.py", line 259, in
train()
File "train.py", line 82, in train
MEANS))
File "/home/chenzw/tensor/ssd/data/coco.py", line 92, in init
INSTANCES_SET.format(image_set)))
File "/home/chenzw/anaconda3/envs/tensor3/lib/python3.5/site-packages/pycocotools/coco.py", line 84, in init
dataset = json.load(open(annotation_file, 'r'))
FileNotFoundError: [Errno 2] No such file or directory: 'COCO_ROOT/annotations/instances_trainval35k.json'

I have the same problem, have you solved the problem?

I have the same problem also, was this solved?

I'm not able to download the file "https://s3.amazonaws.com/amdegroot-datasets/instances_trainval35k.json.zip". The COCO data preparation script tries to download this file, but I end up with a "instances_trainval35k.json.zip" that just contains an error message.

@AllenMao can you please explain how to fix it?

Thank you very much!
I was able to make it train on coco, but unfortunately, whatever i do i
cannot make it evaluate on coco. can you please help me on that ?
On Fri, Jul 6, 2018 at 5:25 AM Allen Mao<EMAIL_ADDRESS>wrote:

@isalirezag https://github.com/isalirezag Details see Line 480~482 in "
https://github.com/matterport/Mask_RCNN/blob/master/samples/coco/coco.py".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/amdegroot/ssd.pytorch/issues/137#issuecomment-402980351,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL293ipVz6iOMLNStkqmY_vUnTeZUKIVks5uDyz6gaJpZM4TCdf4
.

--
Alireza

Thank you very much!
I was able to make it train on coco, but unfortunately, whatever i do i cannot make it evaluate on coco. do you have any suggestion on that ?

@isalirezag i update coco.py, and update eval.py in this repository. evaluate coco with below:
"COCODetection(args.voc_root, ['minival'],
BaseTransform(300, dataset_mean),
COCOAnnotationTransform())"

@Bigwode
You can download that file below.
https://dl.dropboxusercontent.com/s/s3tw5zcg7395368/instances_valminusminival2014.json.zip
After download that, just rename filename and paste it at correct directory.

@seongkyun It is just valminusminival2014.json, it contains 35k val images.
However, coco trainval35k datasets include 82k train images + 35k val images. So if you rename it, you just use 35k val images to train rather than trainval35k images.

@ujsyehao I've got it. Then if i want to use whole the images (82k + 32k) for training phase, which file should I use? or is there any link to download correct json file?

Same problem, can anyone fix it?

zip“instances_trainval35k.json.zip” and put "instances_trainval35k.json" in correct file

@YLONl But the thing is that file you've told "instances_trainval35k.json.zip" is the incorrect file. Nobody can not unzip or run that "*.json" file even just deleting the ".zip" in the filename.

@Bigwode
You can download that file below.
https://dl.dropboxusercontent.com/s/s3tw5zcg7395368/instances_valminusminival2014.json.zip
After download that, just rename filename and paste it at correct directory.

this solution works for me.
file instances_valminusminival2014.json and instances_trainval35k.json should be the same file just with different name. Besides, I dont think there are 35k images in the trainval35k folder. Does anybody know what's the real meaning of 35k?

@ujsyehao I've got it. Then if i want to use whole the images (82k + 32k) for training phase, which file should I use? or is there any link to download correct json file?

I'm with the same question in mind. Does anyone know how to do it?

@ShangyinGao, as you can see in the next picture, it is more than 120k photos.


Local only execution

I would like to run some documents without having to upload them anywhere (Google, Amazon OCR, etc). Is there some way I can run this tool locally?

Thank you!


Some ROS packages are not ported to python3

A number of packages contain scripts that seem to require python2.
Hence, core-image-ros-world -k (with ROS_USE_PYTHON3 = "yes") fails with a number of do_package_qa issues:
ERROR: camera-calibration-1.12.21-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/camera_calibration/cameracheck.py contained in package camera-calibration requires /usr/bin/python, but no providers found in RDEPENDS_camera-calibration? [file-rdeps]
ERROR: actionlib-1.11.9-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/actionlib/axclient.py contained in package actionlib requires /usr/bin/python, but no providers found in RDEPENDS_actionlib? [file-rdeps]
ERROR: tf2-kdl-0.5.16-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/tf2_kdl/test.py contained in package tf2-kdl requires /usr/bin/python, but no providers found in RDEPENDS_tf2-kdl? [file-rdeps]
ERROR: diagnostic-analysis-1.9.2-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/diagnostic_analysis/export_csv.py contained in package diagnostic-analysis requires /usr/bin/python, but no providers found in RDEPENDS_diagnostic-analysis? [file-rdeps]
ERROR: tf2-tools-0.5.16-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/tf2_tools/view_frames.py contained in package tf2-tools requires /usr/bin/python, but no providers found in RDEPENDS_tf2-tools? [file-rdeps]
ERROR: fake-localization-1.12.13-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/fake_localization/static_odom_broadcaster.py contained in package fake-localization requires /usr/bin/python, but no providers found in RDEPENDS_fake-localization? [file-rdeps]
ERROR: velodyne-pointcloud-1.3.0-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/velodyne_pointcloud/gen_calibration.py contained in package velodyne-pointcloud requires /usr/bin/python, but no providers found in RDEPENDS_velodyne-pointcloud? [file-rdeps]
ERROR: move-base-1.12.13-r0 do_package_qa: QA Issue: /opt/ros/indigo/lib/move_base/warner.py contained in package move-base requires /usr/bin/python, but no providers found in RDEPENDS_move-base? [file-rdeps]

The recommendation for ROS is to make all python scripts compatible with both python2 and python3.
The OE-Core developers don't believe that scripts can be compatible with python2 and python3 at the same time, so I had to add this workaround in Refkit [1].
[1]  https://github.com/intel/intel-iot-refkit/commit/9e236306be37d3b3368b35e0634dceb2090bd3ca

Okay, I might just add that workaround in meta-ros as well, and check if the workaround resolves this issue.


Updates version of package used in typescript config docs

I ran into a few bugs before realizing the docs used for the typescript config types are out of date. This is just a small change to use version 1.5.0
Might be worth considering some better approaches to keeping versioned imports in docs up to date or removing them entirely.

This was fixed in a better way. See https://github.com/jurassiscripts/velociraptor/issues/48#issuecomment-1159550516


Unexpected static libraries

Hello!
I am having this warning when run brew doctor
Warning: Unbrewed static libraries were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.
Unexpected static libraries:
/usr/local/lib/libFaceGen_Macosx.a
/usr/local/lib/libGranny.a
/usr/local/lib/liblibexpat.a
I read some posts about libraries but any with those names. I would like to know if I ingnore this or need to do something?
Thanks!

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.

If you add the necessary information this issue may be reopened.
Also, from brew doctor's output it says you can ignore them.

Sorry, but where is this issue checklist?

@Siri-O You deleted it when you created the issue.

So, I need to create again?

No, I answered your question. You need to read my reply and, in future, read the issue template.


CAMEL-10127: call parent constructor of OsgiDefaultCamelContext with registry

calling super with registry or a new OsgiServiceRegistry if not specified

Thanks for the PR it has been merged. Do you mind closing this?

Thank you!


can't keepalive

connect between client and server will broken after a while,

defmodule REPLTalk do

	def repltalk(channel) do

		questionAsking = IO.gets "> "
		if (byte_size(questionAsking) <= 1) do
			repltalk(channel)
		else
			#IO.puts("thinking...")
			reply = channel |> Talker.Talker.Stub.ask_question(Talker.Ask.new(question: questionAsking))
			IO.inspect reply.answer
			repltalk(channel)
		end
	end
end

GRPC.Server.start(Talker.Talker.Server, "localhost:50051", insecure: true)
{:ok, channel} = GRPC.Stub.connect("localhost:50051", insecure: true)
REPLTalk.repltalk(channel)

** (exit) exited in: :gen_fsm.sync_send_all_state_event(#PID<0.321.0>, {:new_stream, #PID<0.71.0>})
** (EXIT) no process
(stdlib) gen_fsm.erl:249: :gen_fsm.sync_send_all_state_event/2
(grpc) lib/grpc/adapter/chatterbox/client.ex:37: GRPC.Adapter.Chatterbox.Client.send_header/2
(grpc) lib/grpc/adapter/chatterbox/client.ex:28: GRPC.Adapter.Chatterbox.Client.send_request/3
(grpc) lib/grpc/adapter/chatterbox/client.ex:21: GRPC.Adapter.Chatterbox.Client.unary/3
(grpc) lib/grpc/stub.ex:70: GRPC.Stub.send_request/5
run.exs:12: REPLTalk.repltalk/1
16:50:19.230 [error] GenServer GRPC.Adapter.Cowboy.ServerSup terminating
** (stop) exited in: :gen_fsm.sync_send_all_state_event(#PID<0.321.0>, {:new_stream, #PID<0.71.0>})
** (EXIT) no process
Last message: {:EXIT, #PID<0.71.0>, {:noproc, {:gen_fsm, :sync_send_all_state_event, [#PID<0.321.0>, {:new_stream, #PID<0.71.0>}]}}}
State: {:state, {:local, GRPC.Adapter.Cowboy.ServerSup}, :one_for_one, [], :undefined, 1, 5, [], 0, GRPC.Adapter.Cowboy.ServerSup, []}

Yes. Chatterbox will disconnect when being inactive for a while. I'll fix this later.

It's fixed on master. Please update grpc and cowboy


Increase heap for Gradle

and add some more swap to the GH runner (action copied from projectnessie/nessie)

Finally... separating "javac" and publishing and increasing the heap for these steps seems to finally help.
Reduced the default min-heap setting.


How about change the route.routes.receiver to list?

What did you do?
What did you expect to see?
What did you see instead? Under which circumstances?
Environment

System information:
insert output of uname -srm here

Alertmanager version:
insert output of alertmanager --version here (repeat for each alertmanager
version in your cluster, if relevant to the issue)

Prometheus version:
insert output of prometheus --version here (repeat for each prometheus
version in your cluster, if relevant to the issue)

Alertmanager configuration file:

insert configuration here

Prometheus configuration file:

insert configuration here (if relevant to the issue)

Logs:

insert Prometheus and Alertmanager logs relevant to the issue here

As-Is, we could route the alerts with their labels.
To do so, we set route.routes like below
route:
  routes:
  - receiver: dev-receiver
    matchers:
    - test="true"
    continue: false
    repeat_interval: 6h
  - receiver: default-receiver
    matchers:
    - test="false"
    continue: false
    repeat_interval: 6h
  - receiver: another-receiver
    matchers:
    - test="true"
    continue: false
    repeat_interval: 6h

If alerts are fired, then the alertmanager would check the label "test" to route those alerts.
If the label "test" has value "true", then "dev-receiver"  would receive the alert from the alertmanager, but "another-receiver" will get no alert.
Alerts could be sent to multiple receivers, like if some nodes are down then the infra, platform and developer team should get alerts.
In this case, the receiver would proxy the alert from the alertmanager to another receiver "infra, platform and dev", which is adding one more hop in the alert system.
If alertmanager could send the alerts to several receivers, then we could make the alert system fit.
So finally, the alertmanager.yaml would be
route:
  routes:
  - receiver:
    - dev-receiver
    - another-receiver
    matchers:
    - test="true"
    continue: false
    repeat_interval: 6h
  - receiver:
    - default-receiver
    matchers:
    - test="false"
    continue: false
    repeat_interval: 6h

The usual approach is to configure all the integrations in a single receiver so you're sure that all systems have an up-to-date view of the incident.
E;g. how would you deal with receivers that return transient errors?

initial notification goes to dev-receiver
updated notification (more alerts firing) goes to another-receiver
resolved notification goes to  dev-receiver

Now  another-receiver doesn't know about the resolved incident?

The usual approach is to configure all the integrations in a single receiver so you're sure that all systems have an up-to-date view of the incident. E;g. how would you deal with receivers that return transient errors?

initial notification goes to dev-receiver
updated notification (more alerts firing) goes to another-receiver
resolved notification goes to  dev-receiver

Now another-receiver doesn't know about the resolved incident?

I have no idea about what you said above.
The another-receiver would get no alert from the alertmanager in my case.

My point is that at the second step (updated notification), dev-receiver is down so Alertmanager decides to send the notification to another-receiver. If dev-receiver is available again when the resolved notification is sent then another-receiver would never receive the resolved notification. Does it make sense?

If at the second step (updated notification), dev-receiver is down then Alertmanager decides to send the notification to another-receiver (assuming it is up). If dev-receiver is available again when the resolved notification is sent then another-receiver would never receive the resolved notification. Does it make sense?

Are you considering the multiple receiver in .route.routes.receiver? or talking with just as-is?
For the former, the alertmanager should check whether those receivers in .route.routes.receiver get the notification.
If some of them don't get the updated notification because of some error (network, health ... so on), then the alertmanger sends the alerts again for them.
For the latter, I don't know the how alertmanager send the alert to receiver.
Since it is the webhook, I think, the alertmanager would check the response code from the receiver when alerts were sent to that. If the alerts failed to be sent to the receiver, then alertmanager would try again to deliver the notification to the receiver.


HBASE-28887 Fix broken link to mailing lists page in reference guide

The Reference Guide (book) link to the mailing lists page is broken.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

_ Patch Compile Tests _

_ Other Tests _

1m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6311/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6311

Optional Tests

uname
Linux c17683f8fab2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 561e4dcd5c04dc999f02d426212e7fc9a4afd647

Max. process+thread count
43 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6311/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  3s

master passed

+0 :ok:
refguide
2m 11s

branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 43s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+0 :ok:
refguide
1m 55s

patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 42s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

13m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6311/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6311

Optional Tests
dupname asflicense codespell detsecrets refguide spotless

uname
Linux f732c18e6bef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 561e4dcd5c04dc999f02d426212e7fc9a4afd647

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6311/1/yetus-general-check/output/branch-site/book.html

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6311/1/yetus-general-check/output/patch-site/book.html

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6311/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Nice catch !

Thanks @NihalJain!


Build failure: eza

Steps To Reproduce
Steps to reproduce the behavior:

build eza

Build log
 Compiling url v2.2.1
   Compiling eza v0.18.2 (/build/source)
thread 'main' panicked at cargo-auditable/src/collect_audit_data.rs:77:9:
cargo metadata failure: error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=split-debuginfo --print=crate-name --print=cfg` (exit status: 1)
  --- stderr
  error: unknown start of token: `
   --> <anon>:1:19
    |
  1 | warning: function `foo` is never used
    |                   ^
    |
  help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
    |
  1 | warning: function 'foo` is never used
    |                   ~

  error: unknown start of token: `
   --> <anon>:1:23
    |
  1 | warning: function `foo` is never used
    |                       ^
    |
  help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
    |
  1 | warning: function `foo' is never used
    |                       ~

  error: unknown start of token: `
   --> <anon>:7:11
    |
  7 |   = note: `#[warn(dead_code)]` on by default
    |           ^
    |
  help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
    |
  7 |   = note: '#[warn(dead_code)]` on by default
    |           ~

  error: unknown start of token: `
   --> <anon>:7:30
    |
  7 |   = note: `#[warn(dead_code)]` on by default
    |                              ^
    |
  help: Unicode character '`' (Grave Accent) looks like ''' (Single Quote), but it is not
    |
  7 |   = note: `#[warn(dead_code)]' on by default
    |                              ~

  error: unexpected closing delimiter: `)`
    --> <anon>:11:6
     |
  4  | 1 | const unsafe fn foo(p: *const u8) -> isize { p.offset_from(p) }
     |                                                -                  - ...matches this closing brace
     |                                                |
     |                                                this opening brace...
  ...
  11 | ccess)]
     |      ^ unexpected closing delimiter

  error: aborting due to 5 previous errors

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: could not compile `eza` (build script)
warning: build failed, waiting for other jobs to finish...
error: build of '/nix/store/rmbcmars3mg712rmsz03vjrxjpnbfc8p-eza-0.18.2.drv' on<EMAIL_ADDRESS>failed: builder for '/nix/store/rmbcmars3mg712rmsz03vjrxjpnbfc8p-eza-0.18.2.drv' failed with exit code 101;
       last 10 log lines:
       >   ...
       >   11 | ccess)]
       >      |      ^ unexpected closing delimiter
       >
       >   error: aborting due to 5 previous errors
       >
       >
       > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       > error: could not compile `eza` (build script)
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/rmbcmars3mg712rmsz03vjrxjpnbfc8p-eza-0.18.2.drv'.
error: builder for '/nix/store/rmbcmars3mg712rmsz03vjrxjpnbfc8p-eza-0.18.2.drv' failed with exit code 1

Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.7.3, NixOS, 23.11 (Tapir), 23.11.4144.c1a3b4e3ddda`
 - multi-user?: `yes`
 - sandbox: `relaxed`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"alien, android-nixpkgs, nixgl, nixos-23.11-small, nixpkgs1809-18.09-small, nixpkgs2003-20.03-small, nixpkgs2009-20.09-small, nixpkgs2105-21.05-small, nixpkgs2111-21.11-small, nixpkgs2205-22.05-small, nixpkgs2211-22.11-small, nixpkgs2305-23.05-small, nixpkgs2311-23.11-small, nixpkgsmaster, nixpkgsunstable, nur"`
 - channels(sss): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

I can't reproduce this on nixos-unstable, nixos-23.11, or master; can you provide the exact commit and build command used?

it seems i can't reproduce it anymore.
sorry for disturb....


Only works around  ?

I'm trying to use LinearGradient as a background, but it won't appear unless there is a text component directly in it.
Is it possible to make it fill in all of the screen space with flex: 1?
Even width: 100, height: 100 doesn't seem to do anything.

Here's a minimal example I used to create a flex: 1 gradient component without children that works on both Android and iOS. Could you please try to reproduce the problem with the following example using the latest stable version of react-native and react-native-linear-gradient?
import React from 'react';
import {
  AppRegistry,
  StyleSheet,
  View,
} from 'react-native';
import LinearGradient from 'react-native-linear-gradient';

const App = () => (
  <LinearGradient
    colors={['red', 'blue']}
    style={styles.gradient}
  />
);

const styles = StyleSheet.create({
  gradient: {
    flex: 1,
  },
});

AppRegistry.registerComponent('ExampleApp', () => App);

Here's a screenshot:

Running exactly your code on React Native 0.27 I get the following result:

Whoops, nevermind :) Forgot to rebuild the iOS project...
Weird that there's no warning for that.

Hey! I'm closing this since this is a stale issue. If you believe it's still relevant to fix, post a comment and I'll reopen.


fwupd: 1.8.4 -> 1.8.9

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build fwupd

 ➜ ldd ./result/bin/.fwupdtool-wrapped
        linux-vdso.so.1 (0x00007ffd94ffa000)
        libfwupdengine.so => not found
        libfwupdutil.so => not found
        libfwupd.so.2 => /nix/store/kynnzqab1d12frjpjvzh1qirrmvn95p3-fwupd-1.8.9-lib/lib/libfwupd.so.2 (0x00007f05a032d000)
        libfwupdplugin.so => not found

some meson variable is still wrong.
Using patchelf is probably not the right choice here.

Only testing the cli and the shared objects with ldd, testing the daemon on a real system tomorrow.

It still looks like result/bin/.fwupdmgr-wrapped and .dfu-tool-wrapped are missing the rpath.

Now, looking at lddtree result/bin/.*, it appears result/bin/.dbxtool-wrapped and result/bin/.fwupdate-wrapped. And result/libexec/fwupd/.fwupdoffline-wrapped and result/libexec/fwupd/.fwupd-wrapped.
Now I am starting to wonder if we should not just change the value of libdir_pkg to be relative to prefix. It’s not like anything within goes to the lib output.

tests fail with:
/nix/store/5gv5js1wm7ff474s754krk17dzq392g7-fwupd-1.8.9-installedTests/libexec/installed-tests/fwupd/acpi-dmar-self-test: error while loading shared libraries: libfwupdplugin.so: cannot open shared object file: No such file or directory
FAIL: fwupd/fwupd.test (Child process exited with code 127)
Running test: fwupd/fwupdmgr-p2p.test
Starting P2P daemon...
/nix/store/c5hkxijdxggji933pm5bzlgfly6g9mrp-fwupd-1.8.9/libexec/fwupd/fwupd: error while loading shared libraries: libfwupdengine.so: cannot open shared object file: No such file or directory
Executing: fwupd/fwupdmgr-p2p.test
Executing: fwupd/fwupdmgr-p2p.test
Executing: fwupd/fwupdmgr-p2p.test
Executing: fwupd/fwupdmgr-p2p.test

Yes, that is still missing rpath in fwupd, as mentioned above.

nix-build -A fwupd.passthru.tests now succeeds.

I don't have currently any firmware to upgrade but refreshing and updating works.

Thanks for taking this over! We should probably make those patches ordered, so it's easier to git am/git format-patch for rebasing in the future.

Looks like the module needs updating or fwupd will crash:
Jan 26 23:12:44 theo fwupd[142266]: 22:12:44.245 FuEngine             migrating OverrideESPMountPoint=/boot to EspLocation
Jan 26 23:12:44 theo fwupd[142266]: Failed to load daemon: failed to load engine: Failed to create file ?/etc/fwupd/daemon.conf.6HZBZ1?: Read-only file system