1.20.1 Too Fast Mixin crash

Hey Noobanidus :)
Please see below as discussed. Crash and Mod list below it.
Carpet mod was removed prior to installing Too Fast.
FabricLoader/Mixin
main
Mixin apply for mod toofast failed toofast.mixins.json:ServerPlayNetPlayMixin from mod toofast -> net.minecraft.class_3244: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @ModifyConstant annotation on toofast_PlayerMaxSpeed could not find any targets matching 'Lnet/minecraft/class_3244;onPlayerMove(Lnet/minecraft/class_2828;)V' in net.minecraft.class_3244. Using refmap toofast-fabric-1.20-refmap.json [PREINJECT Applicator Phase -> toofast.mixins.json:ServerPlayNetPlayMixin from mod toofast -> Prepare Injections ->  -> constant$fkh000$toofast$PlayerMaxSpeed(F)F -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @ModifyConstant annotation on toofast_PlayerMaxSpeed could not find any targets matching 'Lnet/minecraft/class_3244;onPlayerMove(Lnet/minecraft/class_2828;)V' in net.minecraft.class_3244. Using refmap toofast-fabric-1.20-refmap.json [PREINJECT Applicator Phase -> toofast.mixins.json:ServerPlayNetPlayMixin from mod toofast -> Prepare Injections ->  -> constant$fkh000$toofast$PlayerMaxSpeed(F)F -> Parse]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.validateTargets(InjectionInfo.java:656)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.findTargets(InjectionInfo.java:587)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.readAnnotation(InjectionInfo.java:330)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.<init>(InjectionInfo.java:316)
	at org.spongepowered.asm.mixin.injection.struct.ModifyConstantInjectionInfo.<init>(ModifyConstantInjectionInfo.java:54)
	at jdk.internal.reflect.GeneratedConstructorAccessor68.newInstance(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo$InjectorEntry.create(InjectionInfo.java:149)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.parse(InjectionInfo.java:708)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1329)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1053)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:395)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_8162.<clinit>(class_8162.java:33)
	at net.minecraft.class_1802.<clinit>(class_1802.java:1285)
	at net.minecraft.class_6089.method_9530(class_6089.java:56)
	at net.minecraft.class_4970$class_4971.method_26172(class_4970.java:1032)
	at net.minecraft.class_4970$class_4971.method_26218(class_4970.java:1028)
	at net.minecraft.class_4970.method_9549(class_4970.java:349)
	at net.minecraft.class_4970$class_4971$class_3752.<init>(class_4970.java:1293)
	at net.minecraft.class_4970$class_4971.method_26200(class_4970.java:843)
	at net.minecraft.class_2246.<clinit>(class_2246.java:1185)
	at net.minecraft.class_2358.method_10199(class_2358.java:326)
	at net.minecraft.class_2966.method_12851(class_2966.java:54)
	at net.minecraft.client.main.Main.main(Main.java:166)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
12:16:58.953
FabricLoader
main
Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.ExceptionInInitializerError
	at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.ExceptionInInitializerError
	at net.minecraft.class_1802.<clinit>(class_1802.java:1285)
	at net.minecraft.class_6089.method_9530(class_6089.java:56)
	at net.minecraft.class_4970$class_4971.method_26172(class_4970.java:1032)
	at net.minecraft.class_4970$class_4971.method_26218(class_4970.java:1028)
	at net.minecraft.class_4970.method_9549(class_4970.java:349)
	at net.minecraft.class_4970$class_4971$class_3752.<init>(class_4970.java:1293)
	at net.minecraft.class_4970$class_4971.method_26200(class_4970.java:843)
	at net.minecraft.class_2246.<clinit>(class_2246.java:1185)
	at net.minecraft.class_2358.method_10199(class_2358.java:326)
	at net.minecraft.class_2966.method_12851(class_2966.java:54)
	at net.minecraft.client.main.Main.main(Main.java:166)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	... 2 more
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_3244 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_8162.<clinit>(class_8162.java:33)
	... 14 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
	... 19 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [toofast.mixins.json:ServerPlayNetPlayMixin from mod toofast] from phase [DEFAULT] in config [toofast.mixins.json] FAILED during APPLY
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379)
	... 22 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @ModifyConstant annotation on toofast_PlayerMaxSpeed could not find any targets matching 'Lnet/minecraft/class_3244;onPlayerMove(Lnet/minecraft/class_2828;)V' in net.minecraft.class_3244.   I'll dig into it deeper. Is this 1.20.1 or 1.20.0?

Looks like the refmap isn't being created properly. I'll look into it.

Ah, I forgot to update Loom. 1.2.0 should fix this, I'm uploading it now.


Confusing command naming|pairing: helm create & helm install|delete

As a noob, I must resort to reviewing helm's commands because create, install and delete seem inconsistently named:
helm create: Creates a helm [chart] directory with template files and directories
helm install: Deploys (!) a helm [chart] to a Kubernetes cluster [creating a release?]
helm delete: Uninstalls (!) a helm release
Recommend:
Reflecting kubectl (and other CLIs') use of [command] [type] [name] to aid memorization.
Perhaps helm [create|delete] [chart|release]?
Easily extended to the other currently very synonymous names to e.g. helm [describe|get] [release]

This will definitely not change for backward compatibility reasons.
During Helm 2's dev cycle, this was the subject of much debate. We analyzed many different tools, and decided (by vote) on what we have now. kubectl, incidentally, is far from the norm on their CLI options. The typical pattern is actually CMD NOUN VERB, while kubectl uses CMD VERB NOUN sometimes and CMD NOUN VERB other times.


OfferBullets

Parameter: List
Components:

Title

all caps
16pt bold
margin-top: 16
weight: bold

Offer item bullet: leading icon (❌ or ✔) with description

weight: bold
16pt.
margin-top: 16
color: #000 alpha 60%
pading: 50


MySQL: SSL warning despite useSSL=false

Hello,
I'm trying to set up LP with a locally hosted MySQL db.
Everything works -- the permissions data is correctly stored in the database.
I seem to be running into a persistent/spammy (and somewhat annoying) console warning. This warning is flashed ~10 consecutive times at boot, and every 10-20 minutes:
[18:15:51 WARN]: Mon Apr 20 18:15:51 UTC 2020 WARN: Establishing SSL connection without
server's identity verification is not recommended. According to MySQL 5.5.45+, 5.6.26+ and 5.7.6+
requirements SSL connection must be established by default if explicit option isn't set. For
compliance with existing applications not using SSL the verifyServerCertificate property is set to
'false'. You need either to explicitly disable SSL by setting useSSL=false, or set useSSL=true and
provide truststore for server certificate verification.

To access the db, I created a mysql user with an associated password, and granted it all privileges.
Here's my config file, where I have in fact set useSSL=false:
137     # By default, the following options are set to enable utf8 encoding. (you may need to remove
138     # these if you are using PostgreSQL)
139     #   useUnicode: true
140     #   characterEncoding: utf8
141     #
142     # You can also use this section to disable SSL connections, by setting:
143     useSSL: false
144     verifyServerCertificate: false
145     properties:
146       useUnicode: true
147       characterEncoding: utf8

When I look up the issue, it seems that using useSSL=false should fix the issue, yet it has not for me this far. Anyone know what the problem might be? Thanks :pray:

it should be:
    properties:
      useUnicode: true
      characterEncoding: utf8
      useSSL: false
      verifyServerCertificate: false```

as stated in the wiki here: https://github.com/lucko/LuckPerms/wiki/Storage-system-errors#mysql-ssl-errors

Argh my bad. Thanks so much!


NODE CONTEXT MENU: Add Cut, Copy, and Disable/Enable

Is your feature request related to a problem? Please describe.
Can we get "cut" and "copy" added to this menu? It sucks to have to keep going up to "Edit" every time:

--
copied from #3950
Currently, to disable actions in the visual editor, user's have to focus on the actions they want to disable and then click the disable button in the editor menu. We should consider adding the enable and disable options to the node's menu options.

Similar ask to https://github.com/microsoft/BotFramework-Composer/issues/3950

Those would be good adds as well

@Stevenic why not use the keyboard commands? ctrl+c

@cwhitten  because I didn't know they were supported :)
You should list them on the menu...

great point. Design is working on improving the contextual menu..

Combined #3950 with this one. Design solution should address both.

Captured in NODE CONTEXT MENU: Add actions to Cut, Copy, Move, Delete, and Disable/Enable #3734, so closing.


Add Timeline Embed

Made a few changes to support timeline embed
Demo: https://www.loom.com/share/a21a753a5d014abe9835162a6954bcff

📝 Changed routes:

/embed/[id]
/

(view full size)
(view full size)

Commit 211c94fa8d9e70032dd5778222cfa97cf734924b (https://lens-embeds-bz7w4rqgd-m1guelpf.vercel.app).


Fix big gun rocket exploding when spawned.

Fix a possible crash with biggun if CreateItem() is saturated.

Fix #1006

Waiting for approve :)


implement faster reflective calls

LambdaMetafactory is the closest speed, as of now, that you'll get to direct access calls. As opposed to reflection being approximately 103-105% slower than direct access, LambdaMetafactory is only about 30-34%.

Thanks for your submission -- I think the general idea is good, more performance never hurts, but:

Why use the LambdaMetafactory and not a MethodHandle directly?

What made you choose those two methods to convert, and not the rest of the (also public) methods/constructors?

How will these changes impact cross-version compatibility? At this point, any changes to the adapters should take into account expected signature changes -- for example the chat packet's constructor changes in the current snapshots. Since this is a fallback adapter, I don't think improved performance would be worth any loss of compatibility.

Thanks for your submission -- I think the general idea is good, more performance never hurts, but:

Why use the LambdaMetafactory and not a MethodHandle directly?
What made you choose those two methods to convert, and not the rest of the (also public) methods/constructors?
How will these changes impact cross-version compatibility? At this point, any changes to the adapters should take into account expected signature changes -- for example the chat packet's constructor changes in the current snapshots. Since this is a fallback adapter, I don't think improved performance would be worth any loss of compatibility.
Using MethodHandle directly has proven to be slower, although not as slow as traditional reflection,  reflective calls can still be faster. In some rare scenarios, traditional reflection can actually out-perform MethodHandle. Ultimately, the use of MethodHandle alone is not sufficient to get us close enough to the performance of direct access.

I've actually only started to implement the LambdaMetafactory into my own project, and plan to expand to other areas. As of now, was just testing the waters to see if this is something you guys would be interesting in implementing into the adapter. If so, I can gladly provide the title implementation.
From what I've tested so far, the use of this implementation is compatible from 1.8-1.15.2.  I doubt any of the internal packet handling will be changed anytime soon. As for upcoming changes in the chat packets, if the LambdaMetafactory is of interest, the changes can surely be accounted for by providing a fallback constructor lookup or other similar solution.

This pull request is no longer compatible with the current codebase, and we have made significant changes to how this works as well. Thank you for the submission.


Module 4 exercises [Celestina Deku]

Please "drag & drop" exercise 1 excel file below.
Mod 4 Ex 1.xlsx

Please "drag & drop" exercise 2 excel file below.
Mod 4 Ex 2.xlsx

Please "drag & drop" exercise 3 pdf file below.
Rank Reciprocal Method Map.pdf
Rank Sum Method Map.pdf

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 4 and make sure to take
the post-training survey. Participating in surveys is required for receiving
the "GALUP Certificate" by the University of Florida.

Well done, Celestina. You clearly grasped the material outlined in Module 4 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


Build with openjdk 8

Signed-off-by: Weichen Xu<EMAIL_ADDRESS>Build with openjdk 8

@jsleight
Can we make mleap CI running against JDK 8 ? Databricks runtime is still using jdk 8 .

Run sbt test with jdk 8 passed on my development ubuntu machine.

The latest tensorflow-java versions are only building for java 11 https://github.com/tensorflow/java/blob/master/README.md#tensorflowjava-version-support
So downgrading to java 8 would prohibit us from upgrading tensorflow.

ok I see.


arguments_dict error messages improved

Mandatory Checklist
Please ensure that the following criteria are met:

[ ] Title of pull request describes the changes/features
[ ] Request at least 2 reviewers
[ ] If new files are being added, the files are no larger than 100kB. Post the file sizes.
[ ] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
[ ] New features have appropriate documentation strings (readable by sphinx)
[ ] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.
Description
This PR improves the error message you get when you try to get a scalar or a pyarray of the wrong type from the argument dictionary object.
Old behavior:
// The following is wrong, it should ask for a pyarray of double
xt::pyarray<int>& mesh_trial_ref = args.m_iarray["mesh_trial_ref"];
// Throws an error whose message is:
// mesh_trial_ref not found

New behavior:
// The following is wrong, it should ask for a pyarray of double
xt::pyarray<int>& mesh_trial_ref = args.array<int>("mesh_trial_ref");
// Throws an error whose message is:
// mesh_trial_ref not found in the dict of pyarray<int> but found in the dict of pyarray<double>

@cekees @zhang-alvin @tridelat this is ready for review.


refactor: Restrict scope of radical to UniqueFactorizationDomain

Restrict scope of radical as suggested in this comment by @YaelDillies.

Can you also fix the Jineon Back and Seewoo Lee -> Jineon Baek, Seewoo Lee in the copyright statement?

That's fixed here! https://github.com/leanprover-community/mathlib4/pull/15818

Ah great!
maintainer merge


C++ fixes

I am not sure where to add a test for this: the repro code looks like:
from libcpp.vector cimport vector
cimport numpy as np

cdef f(vector[np.int64_t]& out_vector):
    cdef size_t count = 5  # any value
    cdef np.int64_t value = 0  # any value

    out_vector.insert(out_vector.end(), count, value)

This uses the following dispatch: iterator insert(const_iterator pos, size_type count, const T& value)
The problem is that the template dispatch is tried first:
template< class InputIt >
iterator insert(const_iterator pos, InputIt first, InputIt last)

but this fails to specialize because size_t is not an input iterator. This tries to add a possible error to the list; however, the code references undefined variables (in Py3).

Thanks, these both look good.

I don't mind adding a test as I now depend on this fix. Can you point me at some tests for related C++ features so that I can add one?

Tests would be great. Maybe https://github.com/cython/cython/blob/master/tests/run/cpp_stl_vector.pyx ? Could you use a different typedef rather than depending on numpy?

Sure, assuming that isn't part of the problem. I will start with long.


[ERROR] cuda device not available

I get this error when running the complete example of the section Control your Robot.

@krenax , this is most likely not a Genesis project issue. Would you please provide your environment details (OS, Conda/Venv config, etc. )?

My machine is running Linux Mint 21.3 x86_64 with an AMD Radeon RX 7900 XTX. Which config would be helpful?

@krenax , Cuda is an Nvidia GPU framework. Unfortunately, your AMD GPU is not compatible with Cuda.

Perhaps I do misunderstand the description, but: The project description states that this project is cross-platform and runs across different compute backend (AMD GPU included).

hi, Nvidia Gpus contain multiple cuda units, if you have a nvidia gpu, gs.cuda() works. AMDs should find another way


[8.x] Add query execution start timestamps to DB queryLog

Timestamp of query execution start should be part of queryLog information, so that this information could be retrieved in DB::getQueryLog().

These are breaking changes to method signatures. Please send this to master.

@driesvints OK, but I took care to keep backwards compatibility by only adding an optional function param.
How about adding onlime/framework@3b3c984 to this PR and reopening it?

Still a breaking change to the method signature for anyone overriding it.

sorry man, you're right! sent this to master, #37514


Keeping the app in background causes it show Source Not Installed and no download buttons

Steps to reproduce
These steps are kinda rough I know but I can't really describe it very well so sorry about that

Open a manga
keep the app in recents and switch to other apps for atleast an hour or few hours
Switch back to the app to land on the same manga page that you left it at

Expected behavior
the manga page is the same as you left it and you can see the source name and downloaded chapters
Actual behavior
Source shows up as unrecognized and downloaded chapters arent displayed

Crash logs
N/A
Tachiyomi version
528
Android version
13
Device
Galaxy Note 10 Lite
Other details
happens more often on sy imo but maybe thats just placebo 🤷
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.9.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Likely related, leaving the app on a source and switching back after a while gives a "Source not installed" error message. It seems like sources aren't loaded properly when SY loads into a screen other than the default

Likely related, leaving the app on a source and switching back after a while gives a "Source not installed" error message. It seems like sources aren't loaded properly when SY loads into a screen other than the default

Known Main Tachi issue, I would not be surprised if it was more prevalent in SY since it does a few extra things in source init, but they are needed. But the root cause is still main Tachi


Update Git typo mibstd2-tools.esd

Git => GitHub

Oops - the " right before the got lost. Can you fix that directly? Because this change need hashes fix afaik and I dont know how to generate.
Sorry!


I cannot thank you enough!

Dear @jacob-j
I cannot thank you enough for this amazing extension! This is the best thing since sliced bread. It helps me greatly with navigating large codebases, that have 5+ directory depths at times.
I've been missing this feature from VSCode since I've parted ways with Jetbrains products.
🙏 🙇

Thank you so much for the kind words! 🥰
Wish I had more time to go through the issue list, but currently swamped at work


[TF:TRT] Fix the AlgorithmSelector

This change allows the algorithm selection mechanism to be used in TensorRT 7.1. Previously, the code disabled the algorithm selector unless the TRT version is greater than 7.2. However, the true issue is that TRT7.1 has a bug when the algorithm selector is used in conjunction with calibration and INT8 mode.
In addition, this change cleans up the TfTrtAlgorithmSelector class. It removes all assert and CHECK statements and refactors the code to conform with standards in the rest of the code base. Use of the preprocessor for conditionals is reduced to only necessary cases.

TODO: QA

@christopherbate  This PR is in draft, any update on this? Please. Thanks!

@bixia1 This is ready for your review.

Applied fixes and squashed, thanks

Getting these errors:
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.cc:16:
./third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.h:64:14: error: implicit instantiation of undefined template 'std::array<int, 4>'
TRTVersion version_;
^
third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.cc:16:
./third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.h:44:35: error: implicit instantiation of undefined template 'std::array<int, 4>'
const TRTVersion& version = CompileTimeTRTVersion())
^
third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.cc:16:
./third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.h:38:31: error: implicit instantiation of undefined template 'std::array<int, 4>'
static constexpr TRTVersion CompileTimeTRTVersion() {
^
third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.cc:16:
./third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.h:39:12: error: implicit instantiation of undefined template 'std::array<int, 4>'
return TRTVersion{NV_TENSORRT_MAJOR, NV_TENSORRT_MINOR, NV_TENSORRT_PATCH,
^
third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.cc:16:
./third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector.h:39:12: error: implicit instantiation of undefined template 'std::array<int, 4>'
return TRTVersion{NV_TENSORRT_MAJOR, NV_TENSORRT_MINOR, NV_TENSORRT_PATCH,
^
third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
^

OK looks like a libstdc++ vs libc++ error. With GCC7/8 and libstdc++ it builds fine.
It looks like we just need to include array.h at the top of algorithm_selector.h.

I pushed up the inclusion of <array>

third_party/tensorflow/compiler/tf2tensorrt/convert/algorithm_selector_test.cc:85:67: error: no member named 'kHWC16' in 'nvinfer1::TensorFormat'
nvinfer1::TensorFormat::kHWC16));
^
./third_party/googletest/googletest/include/gtest/gtest.h:1814:50: note: expanded from macro 'EXPECT_TRUE'
#define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
^
./third_party/googletest/googletest/include/gtest/gtest.h:1798:23: note: expanded from macro 'GTEST_EXPECT_TRUE'
GTEST_TEST_BOOLEAN_(condition, #condition, false, true,
^
./third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1504:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
::testing::AssertionResult(expression))
^~

@christopherbate Can you please check @bixia1's comments and keep us posted ?  Those should have been removed. I pushed up the fix, but I won't be able to re-run TRT7 tests from my end until late today

TensorRT7_2 still fails with the same message.

I am still running tests, will let you know when I am done, thanks!

Everything passes on my end. Did you use the commit 54c6ee5ed4f3d99f739f34a86f10b5e447ecc960? I might have pushed that one up after you tested.


fix(node): Improve chunk flushing

Description

improve chunk flushing by using module wrappers to track usage and invocations

Better ssr printing of js assets by tracking them via wrapped module, works similar to next/dynamic hoc
Related Issue

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] I have updated the documentation.

@ScriptedAlchemy please could you publish a test version from main including these latest enhancements?


Can't get a clean build (on windows) for angular hello-world

Describe the bug
can't get a clean build (on windows)
node --version v14.20.0
npm --version 6.14.17
npm run install:all

<EMAIL_ADDRESS>install:all C:\na\code\vscode-ext\hello-world
npm install && npm --prefix ./webview-ui install ./webview-ui

npm WARN deprecated<EMAIL_ADDRESS>This package has been renamed to @vscode/test-electron, please update to the new name
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.
added 184 packages from 150 contributors and audited 186 packages in 14.802s
28 packages are looking for funding
run npm fund for details
found 0 vulnerabilities
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2.  EEXIST: file already exists, cmd shim<EMAIL_ADDRESS>-> 'C:\na\code\vscode-ext\hello-world\webview-ui\parser.cmd'
npm ERR! File exists: C:\na\code\vscode-ext\hello-world\webview-ui\parser.cmd
npm ERR! Remove the existing file and try again, or run npm
npm ERR! with --force to overwrite files recklessly.
npm ERR!      C:\Users\na\AppData\Roaming\npm-cache_logs\2022-09-06T20_35_38_801Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install:all: npm install && npm --prefix ./webview-ui install ./webview-ui
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install:all script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\na\AppData\Roaming\npm-cache_logs\2022-09-06T20_35_38_947Z-debug.log
Desktop (please complete the following information):

OS Version: windows
Toolkit Version:
node --version v14.20.0
npm --version 6.14.17

Solved by using --force
"install:all": "npm install --force && npm --prefix ./webview-ui install --force ./webview-ui",
Other Errors:
An unhandled exception occurred: C:\na\code\vscode-ext\hello-world\webview-ui contains both .browserslistrc and browserslist
had to manually delete these files


Old format

No matter what I do it still converts to old format

Please join the discord and we will get you situated
On Sun, Jun 23, 2024, 6:35 AM ethanhp1991 @.***> wrote:

No matter what I do it still converts to old format
—
Reply to this email directly, view it on GitHub
https://github.com/Court-Room-Gaming/Qb-Core-vehicle-shared-lua/issues/3,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2UI56ZZE6ETDRLGETYWQQ3ZI26KJAVCNFSM6AAAAABJYKSY4SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3DQNJUGEZTONA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


I’m update from 4.9.0 to 4.10.3 and all accessories are not responding

Describe The Bug:
I’m update from 4.9.0 to 4.10.3 and all accessories are not responding
To Reproduce:
Update module
Expected behavior:
All works fine
In logs work all fine
Please help!

I think hb-service can be the cause...


feat(dbm-services): drs服务支持对sqlserver的请求

关联研发信息
dev_branch: feat/sqlserver_for_drs/#2889
target_branch: v1.3.0


Make sure that vanilla architecture earns high reward on multiple envs

Breakout
SpaceInvaders
Seaquest

Algos:

PPO
DQN

Dune sufficiently extensive testing with PPO.


Add unit tests for decimal not-equal functions

The neq functions are registered as part of this PR https://github.com/facebookincubator/velox/pull/4638.
This change adds some unit tests for neq decimal function.

Looks good just a small nit

@karteekmurthys can we hold on to merging this PR until this  https://github.com/facebookincubator/velox/pull/4434 lands?
Thanks.

The reason to block is that https://github.com/facebookincubator/velox/pull/4434 implements decimal type as a logical type and it impacts all decimal code changes. We want to minimize the diff.


Make git maintenance optional

Maybe an environment variable to turn this off? Because I am in a WSL environment with no cron facilities. So git maintenance can't run at a schedule.

What happens when you run git maintenance start inside a repo on WSL?

Nothing on the output. However git does the following:

Add 3 maintenance cron entries in my per-user crontab.
Add a maintenance section to my global .gitconfig listing the repo that I just ran maintenance start in.
Set maintenance.auto=false and maintenance.strategy=incremental in local repo config.

Effectively this disables the automated maintenance when you do git pull and others and shift this into cron. On WSL where there is no running cron daemon no maintenance will run, ever, for any repo that is registered to do scheduled maintenance.

Have you tried sudo service cron start?

You can do that, but once you reboot the machine cron won't be started automatically, because WSL doesn't run a normal init process at start.
They have introduced an option to run a script on start in Windows Insider builds but that still depends on the user to produce a script to explicitly start cron. So there is no guarantee for cron to be available.


bugfix - prevent: TypeError: a bytes-like object is required, not 'str'

content is binary substr should be binary too (python2.7 & 3 compatible)

Coverage decreased (-0.7%) to 53.485% when pulling dfeb60a458c4a7365059d04eff4d845b63437d13 on hagai26:master into 847ec28bb3ad092fa9c0ec288f278cffed5b7ac2 on DenisCarriere:master.

👍 Thanks!


add core logic to support access token in postgres scaler

Provide a description of what has been changed
This PR purpose is to add the necessary code for the Postgres scaler to support Azure Access Token authentication.
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes https://github.com/kedacore/keda/issues/5823

Relates to #

TODO:

Create an issue for this feature and edit this PR's description.
Write / Improve the documentation related to this feature.

Dear reviewers,
I have some doubts regarding the following topics and would appreciate assistance / guidance please:
(1) Should I change the logic of how an Azure Access Token is retrieved to be able to mock it and write some specific PodIdentityProviderAzureWorkload tests? If yes, I am thinking about the following tests, based on what I wrote:

Check that the config is successfully parsed when using the podIdentity kedav1alpha1.PodIdentityProviderAzureWorkload.
Check that the Access Token (i.e. the password) is updated when it is expired or about to expire. This might be difficult because this part happens when performing the query, so it happens at "runtime" and it seems that the tests are not covering "runtime" behaviors, right?

(2) I used regexp pattern matching and replacement to find and replace the connection string and the DB connection, is it robust?

I could also split the connection string into an array, replace the password entry, and then reconstruct the string, but I felt like regexp could do the same job or even better.

(3) To be honest, I got inspired by both the Azure Blob and Azure pipelines scalers. The latter also uses an Access Token but with a different scope, so I am wondering if it could be a good idea to deduplicate and generalize the logic of generating an Azure Access Token to have it in one place.

If it makes sense, I would say that this should be done in another PR, so that this one remains focus on the Postgres scaler.

I think that the changes look nice! :heart:

@Ferdinanddb any update?

Hi @JorTurFer , sorry I was busy with other things but I found the time to change some things in the PR.
I tested my change within my own Azure subscription during the weekend, and it works, so I would say that the PR is ready to be reviewed :).
I deployed the KEDA resources using the Helm chart + custom container images built using this branch's code, and let the resources run for more than 24 hours because the Access Token in my case would expire after 24 hours, and it works.
I tested the change by deploying an Airflow cluster on an AKS cluster and creating an Azure Postgres Flexible Server, I had to adapt a bit the Airflow helm chart (specifically the part linked to using KEDA to scale the Airflow workers) but nothing rocket science.
One observation is that, during my test, I tried to use the PGBouncer feature offered by the Azure Postgres Flexible Server resource, and it is not working, I think it is somehow related to this issue.
But if I don't use the PGBouncer port which is "6432", so if I use the normal port of the server (i.e. "5432") then it works fine.
Another observation is regarding how Azure provides Access Token: if there is already an active Access Token and not yet expired, Azure will provide this Access Token until it expires. So I modified the part where we renew the Postgres connection to:

Verify if the Access Token expired by comparing its ExpireOn value to Time.Now(). If the Access Token expired:

the Postgres connection object is closed,
a new Access Token is retrieved,
a new Postgres connection object is created and replaces the previous connection reference.

What do you think about this?
TODO:

Reference this change in the CHANGELOG.md file,
Modify the doc to document this new way of connecting to an Azure Postgres Flex server,
Maybe add more tests?

Thank you !

@JorTurFer Thanks for your feedback!
Got you, I will try to propose something before next week, to resume:

Create or update Terraform modules regarding the following cloud resources in this repo:

Update Managed Identity module to add an Azure User Managed Identity,
Update the AKS module to add a federated identity,
New module to create an Azure Postgres Flexible Server.

Add an e2e test scenario for this feature in this repo:

I will duplicate the HA test and adapt specific parts so that it uses this new feature.

Does that sound good?
Also, once that is done, I plan to propose a PR to update the doc regarding this feature.

For info, I just created this issue and this PR to add a new module to create an Azure Postgres Flexible Server.
And I will add an E2E test on this branch soon.

@JorTurFer I added an e2e test in this PR which is very similar to the Postgres standalone e2e test.
The logic is the following:

Create a local PostgreSQL server as it is done in the standalone test,
Create a table on the (remote) Azure Postgres Flexible server,

The creation is done by connecting to the pod of the local PostgreSQL server and run a psql command to be executed on the remote Azure Postgres Flexible server (using the admin username and password).

Perform the same test actions as in the standalone test (activation, scale-out, scale-in).

The scripts used to add rows in the table use the admin credentials, but the ScaledObject uses the UAMI identity.

Drop the (remote) PostgreSQL table and destroy the local PostgreSQL server.

I did that because the test needs to run psql commands, and this can be done from a Postgres server's pod.
So, no data manipulation actions will happen on the local PostgreSQL server, but it will be the candidate resource that will see its number of replicas being scaled in and out.
Please let me know if that makes sense!
Remark:

Unfortunately, I was not yet able to run this e2e test locally because I don't really know how to do it (and I did not search a lot to be honest). But I will try to find the time for this soon!

Is there a doc describing how to run a single e2e test, by any chance?

What I don't really understand is that the test needs a "custom" container image (at least in this case) and I didn't find where the build (and eventually the push) of the image is done.
If no doc, then I can also try to write a little one explaining how to do it, and it could also include what I did for creating the Azure resources via IaC from this PR.

/run-e2e azure_postgresql

Unfortunately, I was not yet able to run this e2e test locally because I don't really know how to do it (and I did not search a lot to be honest). But I will try to find the time for this soon!

Is there a doc describing how to run a single e2e test, by any chance?

https://github.com/kedacore/keda/blob/main/tests/README.md#specific-test

What I don't really understand is that the test needs a "custom" container image (at least in this case) and I didn't find where the build (and eventually the push) of the image is done.
If no doc, then I can also try to write a little one explaining how to do it, and it could also include what I did for creating the Azure resources via IaC from this PR.

Custom images are needed when the e2e tests uses some custom applications or something that we need to build, in this case we want to have the source code in our repo:
https://github.com/kedacore/test-tools/tree/main/e2e

@zroubalik thank you, that is good to know! The e2e test might not work because this PR has not been merged yet.

I was able to run the e2e test locally after creating the Terraform resources and setting up KEDA with workload identity with my own image (thanks to the doc links inside @zroubalik 's message) !
Once this PR is merged then the e2e tests of this CICD should work. Here is the output I got when running this new e2e test locally:
# go test -v -tags e2e ./scalers/postgresql/azure_postgresql_flex_server_aad_wi/azure_postgresql_flex_server_aad_wi_test.go
=== RUN   TestPostreSQLScaler
    helper.go:246: deleting namespace azure-postgresql-test-ns
    helper.go:299: waiting for namespace azure-postgresql-test-ns deletion
    helper.go:233: Creating namespace - azure-postgresql-test-ns
    helper.go:548: Applying template: postgreSQLStatefulSetTemplate
    helper.go:462: Waiting for statefulset replicas to hit target. Statefulset - azure-postgresql, Current  - 0, Target - 1
    helper.go:462: Waiting for statefulset replicas to hit target. Statefulset - azure-postgresql, Current  - 0, Target - 1
    helper.go:462: Waiting for statefulset replicas to hit target. Statefulset - azure-postgresql, Current  - 0, Target - 1
    helper.go:462: Waiting for statefulset replicas to hit target. Statefulset - azure-postgresql, Current  - 0, Target - 1
    helper.go:462: Waiting for statefulset replicas to hit target. Statefulset - azure-postgresql, Current  - 1, Target - 1
    helper.go:187: Waiting for successful execution of command on Pod; Output: NOTICE:  table "task_instance" does not exist, skipping
        DROP TABLE
        , Error:
    helper.go:187: Waiting for successful execution of command on Pod; Output: CREATE TABLE
        , Error:
    helper.go:187: Waiting for successful execution of command on Pod; Output: GRANT
        , Error:
    helper.go:548: Applying template: azureSecretTemplate
    helper.go:548: Applying template: deploymentTemplate
    helper.go:548: Applying template: azureTriggerAuthenticationTemplate
    helper.go:548: Applying template: azureScaledObjectTemplate
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 0, Target - 0
    azure_postgresql_flex_server_aad_wi_test.go:178: --- testing activation ---
    helper.go:596: Applying template: lowLevelRecordsJobTemplate
    helper.go:500: Waiting for some time to ensure deployment replica count doesn't change from 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    helper.go:507: Deployment - azure-postgresql-test-deployment, Current  - 0
    azure_postgresql_flex_server_aad_wi_test.go:185: --- testing scale out ---
    helper.go:596: Applying template: insertRecordsJobTemplate
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 0, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 0, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 1, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 1, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 1, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 1, Target - 2
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 2
    azure_postgresql_flex_server_aad_wi_test.go:193: --- testing scale in ---
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 2, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 1, Target - 0
    helper.go:442: Waiting for deployment replicas to hit target. Deployment - azure-postgresql-test-deployment, Current  - 0, Target - 0
    helper.go:187: Waiting for successful execution of command on Pod; Output: DROP TABLE
        , Error:
    helper.go:617: Deleting template: azureScaledObjectTemplate
    helper.go:617: Deleting template: azureTriggerAuthenticationTemplate
    helper.go:617: Deleting template: deploymentTemplate
    helper.go:617: Deleting template: azureSecretTemplate
    helper.go:617: Deleting template: postgreSQLStatefulSetTemplate
    helper.go:246: deleting namespace azure-postgresql-test-ns
    helper.go:299: waiting for namespace azure-postgresql-test-ns deletion
    helper.go:299: waiting for namespace azure-postgresql-test-ns deletion
    helper.go:299: waiting for namespace azure-postgresql-test-ns deletion
--- PASS: TestPostreSQLScaler (167.59s)
PASS
ok      command-line-arguments  167.607s

I have a remark regarding my e2e test and I would like your opinions please:
The way I grant permissions on the table to the Azure identity is subject to SQL injection if someone is able to change the value of azurePostgreSQLAdminUsername  = os.Getenv("TF_AZURE_POSTGRES_ADMIN_USERNAME").
If the value of this becomes "; DROP DATABASE postgres ;" then we have a problem because we will have:
grantPrivilegesSQL := fmt.Sprintf(`GRANT ALL ON task_instance TO \"%s\";`, azurePostgreSQLUamiName)
// This will become GRANT ALL ON task_instance TO ""; DROP DATABASE postgres ;"";

The solutions I see for this:

Hard-code the value of azurePostgreSQLUamiName.

This will work until the identity name, that is created by Terraform, gets modified.

Add a regex check prior to this part to check that the value of azurePostgreSQLAdminUsername respects a specific pattern like 1231r-1f111-11f31d-1d1q.

This can work but is a bit restrictive since a username (identity name) could be abc123 or abc_123... But something that is sure is that the character ; should not be present.

Add a check prior to this part to get the users listed in the server, and since the user we want to grant permissions to will be one of the users returned by the query, meaning if azurePostgreSQLAdminUsername is present in the query result, then we can proceed.

To query users listed in the server, we can use the following query select * from pgaadauth_list_principals(true); .
If the value of azurePostgreSQLAdminUsername is present in the result, then we can go further, else there is a problem.

Another (more complex) solution could be to manage the permissions in Terraform directly using null_resource resources and local-exec provisioners, but it means that:

The Azure identity that executes Terraform needs to be granted Entra AD Admin role on the PG server.
A firewall rule needs to be added to authorize connection coming from the IP or range of IPs of the VM where the code of GitHub Actions is executed. This is not needed if the code of GitHub Actions is executed from an Azure machine (and so has an Azure IP).
One or several null_resource with local-exec to connect to the pg server and runs different queries for:

Authorize one or many Azure identities to connect to the server (in this case we just need one Azure identity, but maybe more in the future).
Grant permissions at the server, database or table level to the previously added Azure identities.
Revoke permissions and/or remove an Azure identity if it is not listed in Terraform anymore.

The benefit of this last solution is that basic authentication isn't needed anymore, and imho this is a good way of tackling the problem at a high scale. But it is more complex.

/run-e2e azure_postgresql

/run-e2e azure_postgresql

/run-e2e azure_postgresql

I have a remark regarding my e2e test and I would like your opinions please:
The way I grant permissions on the table to the Azure identity is subject to SQL injection if someone is able to change the value of azurePostgreSQLAdminUsername = os.Getenv("TF_AZURE_POSTGRES_ADMIN_USERNAME").
If the value of this becomes "; DROP DATABASE postgres ;" then we have a problem because we will have:
grantPrivilegesSQL := fmt.Sprintf(`GRANT ALL ON task_instance TO \"%s\";`, azurePostgreSQLUamiName)
// This will become GRANT ALL ON task_instance TO ""; DROP DATABASE postgres ;"";

The solutions I see for this:
* Hard-code the value of `azurePostgreSQLUamiName`.

  * This will work until the identity name, that is created by Terraform, gets modified.

* Add a regex check prior to this part to check that the value of `azurePostgreSQLAdminUsername` respects a specific pattern like `1231r-1f111-11f31d-1d1q`.

  * This can work but is a bit restrictive since a username (identity name) could be `abc123` or `abc_123`... But something that is sure is that the character `;` should not be present.

* Add a check prior to this part to get the users listed in the server, and since the user we want to grant permissions to will be one of the users returned by the query, meaning if `azurePostgreSQLAdminUsername` is present in the query result, then we can proceed.

  * To query users listed in the server, we can use the following query `select * from pgaadauth_list_principals(true); `.
  * If the value of `azurePostgreSQLAdminUsername` is present in the result, then we can go further, else there is a problem.

* Another (more complex) solution could be to manage the permissions in Terraform directly using `null_resource` resources and `local-exec` provisioners, but it means that:

  * The Azure identity that executes Terraform needs to be granted Entra AD Admin role on the PG server.
  * A firewall rule needs to be added to authorize connection coming from the IP or range of IPs of the VM where the code of GitHub Actions is executed. This is not needed if the code of GitHub Actions is executed from an Azure machine (and so has an Azure IP).
  * One or several `null_resource` with `local-exec` to connect to the pg server and runs different queries for:

    * Authorize one or many Azure identities to connect to the server (in this case we just need one Azure identity, but maybe more in the future).
    * Grant permissions at the server, database or table level to the previously added Azure identities.
    * Revoke permissions and/or remove an Azure identity if it is not listed in Terraform anymore.

The benefit of this last solution is that basic authentication isn't needed anymore, and imho this is a good way of tackling the problem at a high scale. But it is more complex.

I would personally prefer some simple solution, if we are talking about e2e. In general, we would like to have reproducible isolated e2e test runs.
But I'd love to hear @JorTurFer's opinion here

I see that the e2e test failed again :/ .
The error is:
psql: warning: extra command-line argument "54***" ignored
        psql: could not translate host name "-p" to address: Name or service not known

There are 2 things:

A command line argument is not considered, and I guess this is the part PGPASSWORD=%s psql ....
The azurePostgreSQLFQDN is empty (but why) so psql -h %s -p 5432 becomes psql -h -p 5432.

I thought about the following:

The PGPASSWORD and the -h values need to be quoted, but I did not have this issue locally and the password is generated such that it doesn't contain special characters.

The env variables values should be referenced inside CICD pipeline definition file(s) like v1-build.yml (or similar) to look something like:

...
 - name: Run end to end tests
        env:
          TF_AZURE_SUBSCRIPTION: ${{ secrets.TF_AZURE_SUBSCRIPTION }}
          TF_AZURE_RESOURCE_GROUP: ${{ secrets.TF_AZURE_RESOURCE_GROUP }}
          TF_AZURE_SP_APP_ID: ${{ secrets.TF_AZURE_SP_APP_ID }}
          AZURE_SP_KEY: ${{ secrets.AZURE_SP_KEY }}
          TF_AZURE_SP_TENANT: ${{ secrets.TF_AZURE_SP_TENANT }}
          TF_AZURE_STORAGE_CONNECTION_STRING: ${{ secrets.TF_AZURE_STORAGE_CONNECTION_STRING }}
          TF_AZURE_LOG_ANALYTICS_WORKSPACE_ID: ${{ secrets.TF_AZURE_LOG_ANALYTICS_WORKSPACE_ID }}
          # Add the following
          TF_AZURE_POSTGRES_ADMIN_USERNAME: ${{ secrets.TF_AZURE_POSTGRES_ADMIN_USERNAME }}
          TF_AZURE_POSTGRES_ADMIN_PASSWORD: ${{ secrets.TF_AZURE_POSTGRES_ADMIN_PASSWORD }}
          TF_AZURE_POSTGRES_FQDN: ${{ secrets.TF_AZURE_POSTGRES_FQDN }}
          TF_AZURE_POSTGRES_DB_NAME: ${{ secrets.TF_AZURE_POSTGRES_DB_NAME }}
        run: make e2e-test

What do you think about this?

I just did again the whole test on my personal machine and it works, what I did is the following:
# At the root folder of my KEDA GitHub repo, build and publish the images
IMAGE_REGISTRY=docker.io IMAGE_REPO=ferdi7 make publish-multiarch

# In the mean time, inside my testing-infrastructure GitHub repo, I did the necessary to create the resources via Terraform
# (.i.e an AKS cluster and the Azure Postgres Flexible Server)

# Login to Azure and get AKS creds
az login
az aks get-credentials --resource-group MY-RG-NAME --name AKS-CLUSTER-NAME --overwrite-existing

# Export the following env variables to install KEDA and run the e2e test (I did not use any quotes)
export TF_AZURE_POSTGRES_ADMIN_USERNAME=USERNAME
export TF_AZURE_POSTGRES_ADMIN_PASSWORD=PASSWRD
export TF_AZURE_POSTGRES_FQDN=SERVER-NAME.postgres.database.azure.com
export TF_AZURE_POSTGRES_DB_NAME=DB_NAME
export TF_AZURE_SP_TENANT=AZURE-TENANT-ID
export TF_AZURE_IDENTITY_1_APP_ID=UAMI-IDENTITY-CLIENT-ID
export TF_AZURE_IDENTITY_1_NAME=UAMI-IDENTITY-NAME
export AZURE_RUN_WORKLOAD_IDENTITY_TESTS=true

# Deploy KEDA and run e2e test
cd tests
IMAGE_REGISTRY=docker.io IMAGE_REPO=ferdi7 go test -v -tags e2e ./utils/setup_test.go
go test -v -tags e2e ./scalers/postgresql/azure_postgresql_flex_server_aad_wi/azure_postgresql_flex_server_aad_wi_test.go

# Uninstall KEDA
go test -v -tags e2e ./utils/cleanup_test.go

This works on my end, so I have 2 remarks which could explain the error:
Remark 1: The environment variables provisioning is handled by Terraform as follows, for example:
...
    {
      name  = "TF_AZURE_POSTGRES_ADMIN_USERNAME"
      value = module.azurerm_postgres_flexible_server.admin_username
    },
    {
      name  = "TF_AZURE_POSTGRES_ADMIN_PASSWORD"
      value = module.azurerm_postgres_flexible_server.admin_password
    },
...

But I just realized that the admin_password variable is sensitive! So maybe something weird happen, and we should have the following if that makes sense (notice the use of the Terraform function nonsensitive()):
...
    {
      name  = "TF_AZURE_POSTGRES_ADMIN_USERNAME"
      value = module.azurerm_postgres_flexible_server.admin_username
    },
    {
      name  = "TF_AZURE_POSTGRES_ADMIN_PASSWORD"
      value = nonsensitive(module.azurerm_postgres_flexible_server.admin_password)
    },
...

Remark 2: The other thing (or in addition to the previous remark) that could explain the error is what I said in a previous comment:

The env variables values should be referenced inside a CICD pipeline definition file(s) like v1-build.yml (or similar) to look something like:

...
 - name: Run end to end tests
        env:
          TF_AZURE_SUBSCRIPTION: ${{ secrets.TF_AZURE_SUBSCRIPTION }}
          TF_AZURE_RESOURCE_GROUP: ${{ secrets.TF_AZURE_RESOURCE_GROUP }}
          TF_AZURE_SP_APP_ID: ${{ secrets.TF_AZURE_SP_APP_ID }}
          AZURE_SP_KEY: ${{ secrets.AZURE_SP_KEY }}
          TF_AZURE_SP_TENANT: ${{ secrets.TF_AZURE_SP_TENANT }}
          TF_AZURE_STORAGE_CONNECTION_STRING: ${{ secrets.TF_AZURE_STORAGE_CONNECTION_STRING }}
          TF_AZURE_LOG_ANALYTICS_WORKSPACE_ID: ${{ secrets.TF_AZURE_LOG_ANALYTICS_WORKSPACE_ID }}
          # Add the following
          TF_AZURE_POSTGRES_ADMIN_USERNAME: ${{ secrets.TF_AZURE_POSTGRES_ADMIN_USERNAME }}
          TF_AZURE_POSTGRES_ADMIN_PASSWORD: ${{ secrets.TF_AZURE_POSTGRES_ADMIN_PASSWORD }}
          TF_AZURE_POSTGRES_FQDN: ${{ secrets.TF_AZURE_POSTGRES_FQDN }}
          TF_AZURE_POSTGRES_DB_NAME: ${{ secrets.TF_AZURE_POSTGRES_DB_NAME }}
        run: make e2e-test

What do you think about this?

@zroubalik Can you write the comment "/run-e2e azure_postgresql" to execute the e2e tests, please?

/run-e2e azure_postgresql

I guess that something isn't wrong with any string generation because there are a lot of errors like this during e2e tests: https://github.com/kedacore/keda/actions/runs/9645629374/job/26600554311#step:9:278
helper.go:***87: Waiting for successful execution of command on Pod; Output: psql: warning: extra command-line argument "54***" ignored
        psql: could not translate host name "-p" to address: Name or service not known
        , Error:

Let me trigger the test again and check the Env vars used

/run-e2e azure_postgresql

@JorTurFer @zroubalik I think I have a little clue regarding why the test is failing. At this stage of the GitHub Actions, during the oNaiPs/secret-to-env-action job, I see that the following secrets are not listed:

TF_AZURE_IDENTITY_1_NAME,
TF_AZURE_POSTGRES_FQDN.

But what I don't understand is that the other secrets related to the Azure Postgres (TF_AZURE_POSTGRES_ADMIN_USERNAME, TF_AZURE_POSTGRES_ADMIN_PASSWORD and TF_AZURE_POSTGRES_DB_NAME) are listed.
Do you maybe know why this could be the case?
Maybe it could be worth rerunning the KEDA testing-infrastructure's GitHub Actions pipeline, even though I just verified the terraform apply stage from the last run, and we can see that:

The GitHub secret TF_AZURE_POSTGRES_FQDN seems to have been created,
The GitHub secret TF_AZURE_IDENTITY_1_NAME seems to have been created.

Hi @JorTurFer and @zroubalik, may I ask you if you had the time to look at my previous comment please?

/run-e2e azure_postgresql

Sorry @Ferdinanddb
I've been really busy last months with a project and now I'm checking the delayed things. I'm reviewing this atm, I'll give you any insight that I find

Okey, the values now are there:

ignore the ***, it's the shitty anonymization process that GH does (apparently "1" it's a sensitive value)

I've solved some infra issues and it seems that works, but currently the scaling in process isn't working because it needs more time accessing azure database than local db. Let me update the PR with a fix

/run-e2e azure_postgresql

/run-e2e azure_postgresql

/run-e2e azure_postgresql

Hi @JorTurFer,
No worries for the delay, and thank you very much for your support and involvement!
Yes, I will update the doc by the end of tomorrow, I will open a PR in this keda-docs repo.
Just FYI, I faced a weird case while developing this feature: I could not make it work with PGBouncer, and I did not really understand why, but I will mention it in the documentation.

To be specific, the PGBouncer feature in Azure PG Flex server gives the ability to interact with the server using the port 6432 in addition to the default port 5432.

When I ran my test using the port 6432 it did not work, but it worked using the port 5432.
So, KEDA """needs""" to use the default port 5432 but the other applications interacting with the PG Flex server are free to use the PGBouncer port 6432. I will try to mention that in a clear way in the doc.

/run-e2e azure_postgresql

Thanks a lot! I'll be afk until Sunday night, but once I come back I'll check both PR and merge them if they are ready. We plan to cut a release next week, so this feature will be available soon :)

/run-e2e azure_postgresql

/run-e2e azure_postgresql

I just opened the following PR in the keda-docs repo.

/run-e2e azure_postgresql

Thanks a lot for the improvement!


[WIP] Swagger spec

Don't merge yet.

Closed by https://github.com/CartoDB/Windshaft-cartodb/pull/879


[VCPKG] create .. failed

example
vcpkg create draco-lanl https://github.com/lanl/Draco/archive/ffeff6b112924488c58024cab181ed6629a1ddc6.zip
CMake Error at scripts/ports.cmake:15 (message):
          Your vcpkg executable is outdated and is not compatible with the current CMake scripts.
          Please re-build vcpkg by running bootstrap-vcpkg.

vcpkg version
Vcpkg package management program version 2019.09.12-nohash-external
additional options do not help
vcpkg create --vcpkg-root E:\tools\vcpkg ...
set VCPKG_ROOT=E:\tools\vcpkg

vcpkg/scripts/ports.cmake
the reason is in recent fixes, not working code

#Detect .vcpkg-root to figure VCPKG_ROOT_DIR, starting from triplet folder.
set(VCPKG_ROOT_DIR_CANDIDATE ${CMAKE_CURRENT_LIST_DIR})

if(DEFINED VCPKG_ROOT_PATH)
    set(VCPKG_ROOT_DIR_CANDIDATE ${VCPKG_ROOT_PATH})
else()
    message(FATAL_ERROR [[
        Your vcpkg executable is outdated and is not compatible with the current CMake scripts.
        Please re-build vcpkg by running bootstrap-vcpkg.
    ]])
endif()

# Validate VCPKG_ROOT_DIR_CANDIDATE
if (NOT EXISTS "${VCPKG_ROOT_DIR_CANDIDATE}/.vcpkg-root")
    message(FATAL_ERROR "Could not find .vcpkg-root")
endif()

the old code fulfills normally
macro(prettify_command INPUT_VAR OUTPUT_VAR)
  set(${OUTPUT_VAR} "")
  foreach(v ${${INPUT_VAR}})
    if(${v} MATCHES "( )")
      list(APPEND ${OUTPUT_VAR} \"${v}\")
    else()
      list(APPEND ${OUTPUT_VAR} ${v})
    endif()
  endforeach()
  list(JOIN ${OUTPUT_VAR} " " ${OUTPUT_VAR})
endmacro()

#Detect .vcpkg-root to figure VCPKG_ROOT_DIR
SET(VCPKG_ROOT_DIR_CANDIDATE ${CMAKE_CURRENT_LIST_DIR})
while(IS_DIRECTORY ${VCPKG_ROOT_DIR_CANDIDATE} AND NOT EXISTS "${VCPKG_ROOT_DIR_CANDIDATE}/.vcpkg-root")
    get_filename_component(VCPKG_ROOT_DIR_TEMP ${VCPKG_ROOT_DIR_CANDIDATE} DIRECTORY)
    if (VCPKG_ROOT_DIR_TEMP STREQUAL VCPKG_ROOT_DIR_CANDIDATE) # If unchanged, we have reached the root of the drive
        message(FATAL_ERROR "Could not find .vcpkg-root")
    else()
        SET(VCPKG_ROOT_DIR_CANDIDATE ${VCPKG_ROOT_DIR_TEMP})
    endif()
endwhile()

hmm is that not enough: Please re-build vcpkg by running bootstrap-vcpkg.
Maybe it should tell you to rerun bootstrap.bat or bootstrap.sh (or only bootstrap) instead of bootstrap-vcpkg. (Misunderstanding here?)
Just rebuild vcpkg?

@Neumann-A
thank you for your responsiveness
need to still test, imports and exports

need to still test, imports and exports

neither of them are creating a process which calls cmake in script mode


Is it possible to use pure java code to make a detached signature ?

I want to develop a web service to publish my SDK to maven central repository automatically. It is necessary to create a detached signature during the pipeline wrote in Java.
What should I do if jpgpj can't create a detached signature?

来信已收到，我会尽快处理。加急请联系：13675888422谢谢叶熊

You can use the Bouncy Castle library directly to create a detached signature; see this example code:
https://github.com/bcgit/bc-java/blob/master/pg/src/main/java/org/bouncycastle/openpgp/examples/DetachedSignatureProcessor.java

Thank you. I'll look into this example.


AzGovViz relocation

AzGovViz relocation.
Removes everything in the \govern\AzureGovernanceVisualizer subdirectory EXCEPT readme.md.
Readme.md has also been updated with a pointer to the new repo (https://aka.ms/alz/azgovviz)

@JulianHayward, @jtracey93 - per @paulgrimley, please let us know if you have any feedback on this PR. We will be merging this in sync with the following PRs, as we move to the new AzGovViz repo:
https://github.com/MicrosoftDocs/cloud-adoption-framework-pr/pull/4761
https://github.com/MicrosoftDocs/well-architected-pr/pull/802


(feat): add nightly cron job

OK, regarding if, here are the docs: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif

When you use expressions in an if conditional, you can, optionally, omit the ${{ }} expression syntax because GitHub Actions automatically evaluates the if conditional as an expression. However, this exception does not apply everywhere.
You must always use the ${{ }} expression syntax or escape with '', "", or () when the expression starts with !, since ! is reserved notation in YAML format.

The docs for status check functions are here: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#status-check-functions
The important part is:

A default status check of success() is applied unless you include one of these functions.

So if you use none of these functions, your condition effectively gets prepended with success() &&


Change columns names

Is there a way to change displayed name of the column from columns option?, without change object keys.

Use the heading property.
headings: {
        [Column_Name_From_DataSet]: [Custom_name],
        [Column_Name_From_DataSet]: [Custom_name],
        [Column_Name_From_DataSet]: [Custom_name],
    },

That's what I needed, thanks!


Document use of retry_on_error for dedicated inference endpoints

Shortly after #549, the inference endpoint backend
was updated to block by default on model loading.
This PR adds documentation explaining how to
circumvent that blocking so that the user, if
desired, can handle the 500 errors themselves.

CC: @coyotte508

Thank you!
Just a note, the backend hasn't been updated yet but should be in the coming days.
(And waiting for endpoints to be scaled actually needs https://github.com/huggingface/huggingface.js/pull/555, my bad)

Backend was updated, and version 2.6.6 on the lib should work fine with inference endpoints :)

Amazing (: will give it a try soon-ish and report back.


Fix for data validator with format

The date validator is not working with format specified.
It always says invalid value.
It is first validated without the format, returns false, since Date() cannot parse it and then will return an error message and never tries with the format.
This fix skips the Date() check if format is specified
and fixes the data validator test to use a format that is not parsed by
Date()

@patricklx thank you catching this! I made a couple comments, once they get resolved I will merge.

done ;)

Perfect! Thanks again 😺


Magnifying Glass needs to check for returned cards

public function afterInteraction() {
if (self::isNonDemand() && self::isFirstNonDemand()) {
self::draw(self::getLastSelectedAge() + 2);
}
}
NumChosen() isn't present in this check.
https://boardgamearena.com/bug?id=96323

Well actually we don't need to check numChosen. We don't get this far if there are not 3 cards of the same value (since there is the word "exactly"). But the problem is that we are executing this logic too early. We have to wait until the second interaction.


Not able to restore the wallet.

I had completed level 3, the message was right on the home page too. But when I restored the wallet, the accounts were missing from the home page.
The same thing happens when Level 1 is completed

@Parsh need to check why transactions are not getting restored

I can see the balance on the home page and also on the accounts.
I can also create and send gifts. Only I can't see the transaction on the account page and in the list of all transactions.

Unable to replicate.
I've been able to perfectly restore my level-3 backed-up wallet.
Pre-restore:

Post restore(All accounts available as well the transactions appeared as they should have)

Verified this issue on dev app v2.0.70(431)


Lazy loading fails because of not closed connection

Hi, I have the following code which was working in 6.1.3
foreach(Job job in container.Jobs) // First query
{
  if (job.QueuedJob != null) // Second query
	job.QueuedJob.Priority = 1;
}

In 6.2.0 the following exception is thrown:

There is already an open DataReader associated with this Command which must be closed first

If I add ToList() in the first line, it does work. I understand that when using IQueryable the underlying connection is not disposed.
Is it a bug or that's how it will be from 6.2.0 and I have to update my code?
Further technical details
EF version: 6.2.61023.0
Database Provider: EntityFramework.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017 15.6

EF Team Triage: This issue is lacking enough information for us to be able to effectively triage it. In particular, it is missing the following information requested in the new issue template. Can you please provide this information?

Steps to reproduce

Ideally include a complete code listing that we can run to reproduce the issue.
Alternatively, you can provide a project/solution that we can run.
BTW we're not just doing this to be mean :smile:... we get a lot traffic on this project and it takes time to attempt to reproduce an issue based on fragments of information. In addition, our attempt is often unsuccessful as the exact conditions required to hit the issue are often not explicitly included in the code provided. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we ask that folks give us a self-contained way to reproduce an issue.
For a guide on submitting good bug reports, read Painless Bug Tracking.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.

Hi,
It occured that the connection string in my project was missing MultipleActiveResultSets=True. Without it, it is failing in 6.2.0, but not in 6.1.3.
I tried to recreate this issue using this sample https://github.com/aspnet/AspNetCore.Docs/tree/master/aspnetcore/data/entity-framework-6/sample, but I could not do it. It is working in both 6.1.3 and 6.2.0.
I don't know why it is failing in my project but not in this sample. Maybe because my project is using .NET 4.5 whereas this sample is made with .NET Core. I don't have any other clue.
If you know the cause of the problem, I would like to hear it from you. If not, then please close the issue.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


This will cause the effect to appear broken until opacity returns to 1.

<PKHUD.FrameView 0x7f999a78e2f0> is being asked to animate its opacity. This will cause the effect to appear broken until opacity returns to 1.

See #6. This is nothing to be worried about.


proposal: x/net/http2: enable extension frame handling for HTTP/2

HTTP/2 library currently ignores HTTP/2 frames with an undefined type. The proposal is to enable the library to handle the extension frames. The change will enable HTTP/2 Go's feature parity to nghttp2 (a popular HTTP/2 library in c).
Requirement:

The change needs to include a feature flag to turn on the extension frame handling when needed.
The change needs to support extension frames associated with a stream. Connection level extension frames are not required in this change, but may be needed in the future.
Extension frames can't be used to open or close a stream, and should not be counted against flow control.

I would like to take the issue. Thanks!

cc @fraenkel

Can someone write down the additional API that is being proposed?  That is, all the new exported names that would be added to the x/net/http2 package.  Thanks.

The new API include a reader interface which can be called by both servers and clients, a write function called by servers and a write function called by clients. In addition, the PR also propose an unknown frame info struct.
// Server side usage:
// func ServeHTTP(rw http.RequestWriter, r *http.Request) {
//	...
//	ufr := r.Context().Value(http2.UnknownFrameReaderKey)
//	reader, ok := ufr.(UnknownFrameReader)
//	f, err := reader.ReadUnknownFrame(context.Background())
//	...
// }
//
//   Client side usage:
//	response, err := transport.RoundTrip(request)
//	rwuf, _ := response.Body.(UnknownFrameReader)
//	f, err := rwuf.ReadUnknownFrame(context.Background())
type UnknownFrameReader interface {
// If no new unknown frame has been received, the function will return
// error "haven't received unknown frames". If there will be no more unknown frames, the
// function will return error "no more unknown frame".
ReadUnknownFrame(ctx context.Context) (*UnknownFrame, error)
}
// Servers call WriteUnknownFrame writes unknown frames.
func (w *responseWriter) WriteUnknownFrame(t FrameType, flags Flags, payload []byte) error
// Clients call AddUnknownFrame to add an unknown frame to http.Request on the client side. This function can
// be called multiple times, in case multiple unknown frames need to be added.
// This function must be called before RoundTrip().
func AddUnknownFrame(req *http.Request, uf *UnknownFrameInfo) (*http.Request)
// UnknownFrameInfo is a struct to store unknown frame fields.
type UnknownFrameInfo struct {
Type  FrameType
Flags Flags
Body  []byte
}

cc @ianswett @birenroy

There are four new operations required to support sending and receiving extension frames: Send and receive for client and server.
Under this proposal:

Server sends a frame: Type assert the http.ResponseWriter to an type which permits sending frames.
Server receives a frame: Retrieve a value which permits reading frames from the request context.Context.
Client sends a frame: Pass a (http.Request).Body value that includes the unknown frames. This value is an unexported type; an exported function initializes the Body field.
Client receives a frame: Type assert the (http.Response).Body to a type which permits accessing frames.

There are some clear asymmetries in here. Clients pass frames via the request/response body, but the send API looks quite different from the receive one. Servers get an UnknownFrameReader from the context, while clients get one from the response body. I think we need a more consistent API across common operations.
Incoming frames are added to an infinite buffer. This seems hazardous. Since there is no flow control on frames (AFAIK, I may be missing something here), I think it would be better to deliver incoming frames immediately to a callback. This does open the question of how to dispatch extensions frames received before the response.

I wanted to pick this up. The main idea of this proposal relates to https://datatracker.ietf.org/doc/html/rfc9113#name-extending-http-2 allowing for adding new frame types but go http2 simply errors out https://cs.opensource.google/go/x/net/+/master:http2/transport.go;l=2322;bpv=1;bpt=1
This is how nghttp2 handles it as extensions https://nghttp2.org/documentation/programmers-guide.html#implement-user-defined-http-2-non-critical-extensions and it allows anyone to add a frame type. I will figure out a clean api and submit it for approval shortly. I just wanted to see what the community has to say about this proposal since it is almost a year old.

At a high level, I think supporting user access extension frames seems reasonable. The question is what the API should look like.
We have a medium-term project to fully merge golang.org/x/net/http2 into net/http, so any additions here should be something that we can support entirely in net/http. Ideally, the new API should not require any references to the http2 package.
We would like to support HTTP/3 in net/http at some point. HTTP/3 also supports extension frames (https://www.rfc-editor.org/rfc/rfc9114.html#name-extensions-to-http-3), so this proposal should be something that can be extended to cover HTTP/3 in the future.
Buffering received frames is problematic without some form of limit on buffer growth. Capping the buffer size leaves the question of what to do when an extension is received when the buffer is full. I think a callback-based approach is going to work better, since it adds a natural pushback mechanism.
A connection-level callback for unrecognized frames would be easy to implement. Associating frames with streams (requests) is harder. We could expose the stream id in requests somehow and leave it up to the user to figure out how to move the frame from the callback to the request handler; that's not the most ergonomic approach, but I don't have any better ideas at the moment.
Sending frames has the interesting question of where to put the send-frame method. If frames are a connection-level concept, then a method on http2.ClientConn would be logical, but we don't really expose ClientConn outside of the mostly-vestigial HTTP/2 connection pool. Also, ClientConn is only defined in the http2 package, which is a problem if we want this API to be in net/http. We could instead put a send-frame method on http.ResponseController, but that associates sending frames with a specific stream rather than the connection as a whole. I don't have any good ideas here at the moment, and I'd be interested to hear ideas on how to handle this.


RUM-3276: Fix image resizing issue

What does this PR do?
Fixes an issue where the image in the viewtree resizes due to setbounds on the drawable. We need to perform this operation on a copy of the drawable to avoid modifying the viewtree.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1897 (26de2cb) into develop (cce49b2) will increase coverage by 0.15%.
The diff coverage is 95.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
+ Coverage    83.19%   83.34%   +0.15%
===========================================
  Files          479      479
  Lines        16958    16948      -10
  Branches      2528     2526       -2
===========================================
+ Hits         14107    14124      +17
+ Misses        2153     2132      -21
+ Partials       698      692       -6

Files
Coverage Δ

...eplay/internal/recorder/base64/Base64Serializer.kt
96.89% <100.00%> (+0.12%)
:arrow_up:

...y/internal/recorder/base64/ImageWireframeHelper.kt
95.49% <100.00%> (+0.29%)
:arrow_up:

...roid/sessionreplay/internal/utils/DrawableUtils.kt
95.71% <80.00%> (+1.60%)
:arrow_up:

... and 22 files with indirect coverage changes


RetryFailed mechanism does not run properly

We run our test with dataProvider. Every method run with different test parameter.
From time to time, the Selenuim WebDriver get an TimeOut for page load. In these cases we want to rerun the testcase.
Therefor we have annotated an RetryAnalyzer at these methods.
Every testCase which got an TimeOut exception from WebDriver  should rerun the one time again.
For the first testCase failed looks everything fine. The case failed because method got the TimeOut exception. The rerun after, works fine and the testCase return with success.
A second testCase failed with TimeOut exception and start the rerun. The rerun works fine again and the testCase return with succes too. But then, the rerun starts a second time with same parameters. This seems like a bug in Invoker class. The instances saved in the FailureContext never removed after testCase is done, but it should.
The loop in this part of the code run through the saved instances of retryFailed.
Invoker.java - line 1142
           if (failure.instances.isEmpty()) {
                       result.addAll(tmpResults);
            } else {
                  for (Object failedInstance : failure.instances) {
                    List<ITestResult> retryResults = Lists.newArrayList();
                    failure.count = retryFailed(
                            failedInstance, testMethod, suite, testClass, beforeMethods,
                     afterMethods, groupMethods, retryResults,
                     failure.count, expectedExceptionHolder,
                     testContext, parameters, parametersIndex);
                  result.addAll(retryResults);
                  }
              }

The Failed Instances add to FailureContext at line 1363.

It looks like you've already made the analyze.
Why not proposing a pull-request with a test case and the appropriate fix? :)

yes, I want to do it.
First of all I have to test it locally.
What I`m missing is the remote package for using testNG in Eclipse.
Do you know something about it.

TestNG remote moved here: https://github.com/testng-team/testng-remote
But I don't understand why you need it because you should be able to write an unit test without it.

Yes you are right.
Thanks.


Warning when trying to Load CIFAR10 in Tensorflow 1.x

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab
TensorFlow version (use command below): v1.15.2-0-g5d80e1e8e6 1.15.2
Python version: 3.6.9

Describe the current behavior
WARNING:tensorflow:Entity <function _get_dataset_from_filename at 0x7f1866eac6a8> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: module 'gast' has no attribute 'Num'
WARNING:tensorflow:Entity <function _get_dataset_from_filename at 0x7f1866eac6a8> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: module 'gast' has no attribute 'Num'
WARNING: Entity <function _get_dataset_from_filename at 0x7f1866eac6a8> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: module 'gast' has no attribute 'Num'
WARNING:tensorflow:Entity <bound method TopLevelFeature.decode_example of FeaturesDict({
'image': Image(shape=(32, 32, 3), dtype=tf.uint8),
'label': ClassLabel(shape=(), dtype=tf.int64, num_classes=10),
})> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: Bad argument number for Name: 3, expecting 4
WARNING:tensorflow:Entity <bound method TopLevelFeature.decode_example of FeaturesDict({
'image': Image(shape=(32, 32, 3), dtype=tf.uint8),
'label': ClassLabel(shape=(), dtype=tf.int64, num_classes=10),
})> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: Bad argument number for Name: 3, expecting 4
WARNING: Entity <bound method TopLevelFeature.decode_example of FeaturesDict({
'image': Image(shape=(32, 32, 3), dtype=tf.uint8),
'label': ClassLabel(shape=(), dtype=tf.int64, num_classes=10),
})> could not be transformed and will be executed as-is. Please report this to the AutoGraph team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output. Cause: Bad argument number for Name: 3, expecting 4
Describe the expected behavior

@ayushm-agrawal
Please provide simple stand alone code to replicate the issue faced.


DIR console command

Good day! I saw that the DIR console command does not work in the local version of Win XP. Reports: file system is empty try to use ADD command. Although the files are located in the working directory C:\Documents and Settings\cito1\Application Data\TIC - tiny computer\0.16.0 dev

Fixed, please check it tic_fixed_dir.zip

It's worked well. Thank You!


Use of pre-commit

Description
I added the https://pre-commit.ci/ GitHub App to the org.  By default this means that any repo with a .pre-commit-config.yaml file will get a weekly PR to update the versions used.  This will help us keep them up to date easier.
cf https://github.com/jupyterlab/jupyterlab/issues/12272

I hope this should have reached the intended audience by now :)


disable compile tests for torch<2.0

Tests running older version of torch will fail the compile tests added in #4878.

Ah good catch on 2.1+


Remove OCL backend

resolves #840
Summary:
Remove the OCL backend, which no longer works, and can probably not be made to work anymore.

I found "Ocl" in .jenkins/common.groovy.
Probably better to update it as well.

maybe better to grep "OpenCL" as well as "ocl"
I found the following line in Signature.py.
       kStr += "    .language:                   %s%s" % ("OpenCL C", writer.endLine)
I am not sure if we need to change this or not.

Sorry, I thought I did grep for both "ocl" and "opencl", case insensitive.

OK. Thanks for your update. I would like to wait for comments from @AlexBrownAMD

One of these tests is still pending, is there anything I need to do here? I can't tell from the testing details what is wrong.

CI didn't have any log files so not sure if they were deleted or the tests didn't run. I just kicked off a rebuild so we can check back in a bit

Looks like the only failing pipeline is for gfx1151, and the PR to enable 1151 support just got merged. So you could pull latest changes to your branch and rerun CI to make sure those tests pass as well, otherwise I think this change is safe to merge.

It says I'm not authorized to merge this PR.


Replace adhoc font rendering with the font-rendering engine instead.

In programs such as Pilot Episode and LapSim Lite etc, the text (font) glyphs are typed in by hand, piece by piece. We want to replace this adhoc code with the new ASCII Font rendering system.

I belive I've vanquished all ad-hoc font rendering everywhere and in all projects.


Upgrade driver dependencies and images

We have been getting flagged for CVEs and other issues due to using older versions in this CSI driver. This commit upgrades all of the affected driver dependencies, as well as the sidecar images and the driver base image.
Some minor code changes were necessary to migrate from the deprecated protobuf library to the currently supported version.
Replace rules were added to ensure the correct kubernetes library versions are used, as the library has a non-standard dependency configuration which would otherwise cause the go commands to always attempt to downgrade the library.
It is now possible to run some of the tests that were being skipped, as the CSI driver now supports that functionality. The remaining tests that are being skipped are due to the driver's lack of proper dynamic provisioning functionality.
There are still some tests that were never in the skipped list that fail sporadically due to concurrency issues, because of the same dynamic provisioning concerns. These will be left as is until proper dynamic provisioning functional is added, as it is already a high priority roadmap item.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We have been getting flagged for CVEs and other issues due to using older versions in this CSI driver. This commit upgrades all of the affected driver dependencies, as well as the sidecar images and the driver base image.
Which issue(s) this PR fixes:
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

/lgtm

/lgtm


Non-admins can use the "fuckrules" command

Description
I enjoy using this command, but it should probably be limited to just admins so shitters/raiders can't instantly ban-evade and rejoin.
Reproduction
 Join game, rules pop-up, open console, type "fuckrules", rules are skipped and you go straight to lobby
Screenshots

Additional context
Other non-wizden servers have this fixed.

IMO, if people know enough about the game to know about the fuckrules command, and want to use it instead of reading the rules then they were probably never going to read them in the first place, so the permissions don't really matter. And the timer is there to try get people to read it, not to somehow block shitters/raiders. Making them stare at the button timer isn't going to reform them.

Either way alt tabbing for a minute is still an option. fuckrules may rarely come in handy when Urist is joining a round during the pre-round screen but gets the occasional "hey re-read the rules" pop-up. In this edge-case using fuckrules may give them enough time to ready up instead of waiting through the full minute, the round starting, and having to latejoin/observe.

 Locking it behind admins would defeat that purpose.
Electro already pointed out why it doesn't matter to anybody who isn't intent on following the rules anyways.


update yansi to 0.5

Rocket itself depends on yansi 0.5 so this fixes having duplicate crate versions.
I see something was already done in #15 but I'm not sure what happened with that since Pear is still using yansi 0.4

Apologies, looks like https://github.com/SergioBenitez/Pear/pull/21 accomplished the same thing, which I've just merged. Thank you!


Try out Prithvi 100M model

The easiest way to do this is probably: https://huggingface.co/spaces/ibm-nasa-geospatial/Prithvi-100M-sen1floods11-demo
Also try to run it locally, pre-trained model here: https://huggingface.co/ibm-nasa-geospatial/Prithvi-100M-sen1floods11
Output should probably be some code snippets that pull the model and make a prediction on some test data
Also a requirements.txt file or environment.yml or something else if there are weird system dependencies

For now we will focus on Sentinel-1 models that use radar data instead of optical, preferably including classification of waterbody vs flood