fix: New table widget migration to sanitize primaryColumn, columnOrder and binding paths

Description
This PR adds a new migration to mitigate the issue due to bad merge in CE and EE which resulted into inconsistent table widget dsl where the the table keys were not sanitized properly.
Fixes #6897
Steps to reproduce.

To reproduce this, local environment setup is required

Checkout to the master branch
Create a new application
Add a table widget
Add some datasource (eg. users)
Open table widget property pane and add the following to the data property {{users.data.concat({ "'new header": 100})}}

Export the application
Checkout to release branch
Import the application

After importing the application should ideally crash.
Reason for the crash -
Background - Due to some recent bad merge from release to master, certain pieces of code got reverted. CE master has the bad code but release has the appropriate changes.
Now when the application is exported while being on the master branch, the bad dsl (due to bad code) goes out and the dsl is on the latest version (migration wise).  When this code is imported while being on the release branch, the code sees that the dsl is on the latest migration version, it does not try to fix the issue present on the dsl (even though previous migration can somewhat fix the dsl). The bad un-sanitized DSL goes in and crashes the application.
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manual
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/6897-table-migration-sanitize-keys

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.07 (0.04)
36.97 (0.05)
33.93 (0.03)
55.61 (0.04)

:red_circle:
app/client/src/pages/Editor/GeneratePage/components/CrudInfoModal.tsx
78.85 (-1.92)
89.66 (0)
33.33 (-8.34)
77.08 (-2.09)

:green_circle:
app/client/src/utils/WidgetPropsUtils.tsx
75 (0.12)
66.41 (-0.06)
69.89 (0)
74.05 (0.14)

:red_circle:
app/client/src/utils/helpers.tsx
63.87 (-1.58)
37.89 (-3.16)
45.16 (-3.23)
60.93 (-1.32)

:green_circle:
app/client/src/utils/migrations/TableWidget.ts
81.87 (6.52)
73.13 (2.68)
91.3 (7.97)
84.38 (5.47)

Note: This issue can now only be reproduced on master on commit: 6754cc01d2e54db072cc8f181895a9775aa09f5e. Latest master has code discrepancy fixes.

@riodeuno please look into this, This should get merged into release soon.

@vivekverma2312 You can now test the DP

Tested on Deploy Preview and working fine.


Fix virtual keyboard on wasm

Hello,
I have made several corrections to stabilize the virtual keyboard on Android and IOS (Chrome and Safari).
I don't know if these corrections can have a negative impact in certain situations, but at the moment they don't cause me any problems.
I'll be happy to answer any questions you may have about these fixes.
These fixes correct several issues with the display of the virtual keyboard, particularly since update 0.28, which can be reproduced on the egui demo site.
We hope to be able to help you.
Thanks a lot for your work, I'm having a lot of fun with egui :)

Hello,
I have carried out several tests of my own and they all seem to work.
Do you need me to make any other corrections or do you have any other questions?
Thanks again for your library

@emilk do you think you could give this another review? I'm trying to hackily copy text_agent behavior into bevy in https://github.com/mvlabat/bevy_egui/pull/279 and this change would help.

Need a rebase (and retest!) on top of https://github.com/emilk/egui/pull/4848

You should be able to fix this branch with git rebase master -i and selecting only the relevant commits, or undo your rebase and do a merge instead

I think I succeeded, I'm sorry for the amount of commits and the repetition of texts... :/
I've tested the last commit, it seems OK. The script check went through.
I'm not very proficient with GIT outside the basics, but I'll do better next time.
Let me know if I need to make any other corrections.

I tested it again now, and on iOS Safari it now works great. Awesome work!


Adding missing Rate reminder from app open

Rate reminder from App open was missing

Shouldn't we link to these files somewhere? @lucassales2

@Casperhr added in PR #42


Android 8 or 9 : with most apps, the items array is empty

I can't understand why most of the time, the items array is empty when I share content.
Don't know how to investiguate
Object
action: "SEND"
exit: false
items: Array(1)
0: null
length: 1__proto__: Array(0)proto: Object

Same Problem here with Android 8. Haven't dived into it deeper, but it seems like the Serialization of the Intent doesn't work properly (in https://github.com/j3k0/cordova-plugin-openwith/blob/master/src/android/cc/fovea/openwith/OpenWithPlugin.java). Will try to dive deeper into it later on.

@SimplyLab The plugin doesn't seem to support the text datatype on Android. If this is also the problem in your case, you can have a look at my fork with a fix: https://github.com/JochenHeizmann/cordova-plugin-openwith/commit/331e244a048c8aead1f58cc2e7e836893b0ddc55
(I haven't issued a pull request yet)

Yeah there seems to be problem with text content on Android (at least). The intent items are null. Have you tested your fixes @JochenHeizmann, could it be opened as PR?

I confirm this problem .  Still  exist.
@JochenHeizmann  's   solution fix this , confirm .

@JochenHeizmann the real mvp


Team2 Review: Potential Risks with DB

@samm82
Name: Team 2 Review
About: Missing risks with database in section 5.1 Risks

Summary

Since the game includes functions like save and load games, it should store the game information and user information somewhere in the backend. If the database is included in the design, potential risks like data branch and data loss should be considered.

Deadline

23/10/2023

Estimated Work Hours

20 min

Completed in commit ID: d9d136da73141de01d320198e16eb7254ec3ecda


[Q] image contains containerd configuration but no cri-o systemd unit?

Background: I want to run unit tests for a CRI API container event consumer against not only containerd, but also cri-o. For containerd, I use a kindest/base-derived image that only deploys containerd with a working CNI configuration, but no k8s components. For cri-o I would like to do similar, if possible. I don't care about rootless, it might even introduce lots of difficult to maintain quirks.
When looking at this repository, I notice that...

there is still an etc/containerd/config.toml present,
but I could find no etc/systemd/system/cri-o.service or similar?

I've only now noticed that there is a cri-o.service installed when installing the crio deb package.


routeMap key is handler name, if different url paths route to same handler, only the last one is available to trace, consider using Method+Path as the key?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
routeMap key is handler name, if different url paths route to same handler, only the last one is available to trace, consider using Path as the key to solve this? or any other solutions?
mm[r.Handler] = routeInfo{                     operationName: fmt.Sprintf("/%s%s", r.Method, r.Path),                 }
described situation can be avoided by using different handlers for different urls, but it takes time to find why when it happens.
Additional context
Add any other context or screenshots about the feature request here.

Hi @Logic0
Glad to receive your feedback. I don't quite understand what you said. Could you give me an example :)

if we have a handler like:
func doSomething( c *gin.Context ) {...}
then register 2 handler:
eg = gin.New()
eg.Use( Middleware(eg, tracer) )
eg.POST( "/api/v1/m1", doSomething )
eg.POST( "/api/v1/m2", doSomething )

according to the code in go2sky gin plugin:
mm[r.Handler] = routeInfo{ operationName: fmt.Sprintf("/%s%s", r.Method, r.Path), }
the mm will be:
mm['doSomething'] = "/POST/api/v1/m1"         // will be overwrited by m2
mm['doSomething'] = "/POST/api/v1/m2"

hope this helps.

Thank you. It does happen. Let me see how to solve it.

Hi @Logic0, If use http.request.Method + http.request.URL.path as the operation name, so /user/:name will generate multiple operation names, I will keep the current solution until there is a better solution.

We added the logic endpoint concept in the next 8.1 release. https://github.com/apache/skywalking/pull/4985
I am feeling it matches this? The core point of the operation name should be metrics only, right?

We did a discussion, this should be plugin FAQ.

@Logic0 As you have known the logic behind this, I recommend using a method wrapper to make this conflict gone. I have talked with @arugal, my suggestion would like to add a FAQ document with an example.

Hi @Logic0 https://github.com/SkyAPM/go2sky-plugins/tree/master/gin/v3 We provide a new version, welcome to use.


Display setpoint while turning knob, then switch back to previous readout after 1s.

Very nice, and minimal too. Thanks!


The sensor's frame rate differ a lot on multiple GPU, version 0.9.15

I am working with carla-0.9.15 on a  4*RTX3090 workstation, after the document [https://carla.readthedocs.io/en/latest/adv_multigpu/]
I start one primary server and three secondary servers, (the 4th server alwarys crash, that's another story, u can find it in another post)
Then I start the Client, with 12 cameras (7x8M, 4x3M, 1x2M), the 12 cameras are assigned to 3 GPUs automatically.
The Problem is, frame rate of the 12 cameras differs a lot, here is my log,  you can see the fps of [RGBCamera][1~12] differ from 2.1 ~ 5.1  which is critical for BEV algorithms, Any Suggestions?

我理解了一下你的工况，你看我理解的对吗：12个Camera分配到三个Secondary上，并且在Python端统计FPS。
首先我可以分享几个主从架构的信息：
1、在同一个Secondary CARLA上的传感器，World FPS是一致的。
2、Python端是通过RPC/TCP传输，LibCarla反序列化，Callback函数处理后的结果。在Python Client端统计FPS会很不准确。
我们已实现11V3R1L的方案，感兴趣的话可以联系我们深信科创。我的微信号：1824729026
I have reviewed your situation and want to make sure I understand it correctly: 12 cameras are assigned to three secondary CARLA, and FPS is being calculated on the Python client side.
First, let me share some information about the primary-secondary architecture:
1.The World FPS for sensors on the same Secondary CARLA is consistent.
2.On the Python client side, the data is transmitted via RPC/TCP, deserialized by LibCarla, and processed by callback functions. Calculating FPS on the Python client side can be quite inaccurate.
We have implemented the 11V3R1L solution. If you are interested, you can contact us at SYNKROTRON(https://www.synkrotron.ai/) Innovation. My WeChat ID is:<PHONE_NUMBER>.

Hi,
if it is important to have a constant fps, use the synchronization  mode.
https://carla.readthedocs.io/en/latest/foundations/#setting-synchronous-mode
Example:
https://github.com/carla-simulator/carla/blob/dev/PythonAPI/examples/sensor_synchronization.py
Without the synchronization mode, the sensor data comes if Carla is done processing, which is not constant.

Hi, if it is important to have a constant fps, use the synchronization mode. https://carla.readthedocs.io/en/latest/foundations/#setting-synchronous-mode
Example: https://github.com/carla-simulator/carla/blob/dev/PythonAPI/examples/sensor_synchronization.py
Without the synchronization mode, the sensor data comes if Carla is done processing, which is not constant.

Well, actually, CARLA is set to synchronization mode if it's Muli-GPU mode or Primary-Secondary mode. But the Secondary CARLA can be Asynchronous, the frame rate of sensor depend on capability of hardwares, like CPU or GPU.
See code in CarlaEngine.cpp
void FCarlaEngine::OnPreTick(UWorld *, ELevelTick TickType, float DeltaSeconds)
{
  TRACE_CPUPROFILER_EVENT_SCOPE_STR(__FUNCTION__);
  if (TickType == ELevelTick::LEVELTICK_All)
  {

    if (bIsPrimaryServer)
    {
      if (CurrentEpisode && !bSynchronousMode && SecondaryServer->HasClientsConnected())
      {
        // set synchronous mode
        CurrentSettings.bSynchronousMode = true;
        CurrentSettings.FixedDeltaSeconds = 1 / 20.0f;
        OnEpisodeSettingsChanged(CurrentSettings);
        CurrentEpisode->ApplySettings(CurrentSettings);
      }

      // process RPC commands
      do
      {
        Server.RunSome(1u);
      }
      while (bSynchronousMode && !Server.TickCueReceived());
    }
    else
    {
      // process frame data
      do
      {
        Server.RunSome(1u);
      }
      while (!FramesToProcess.size());
    }

    // update frame counter
    UpdateFrameCounter();

    if (CurrentEpisode)
    {
      CurrentEpisode->TickTimers(DeltaSeconds);

      if (!bIsPrimaryServer)
      {
        if (FramesToProcess.size())
        {
          TRACE_CPUPROFILER_EVENT_SCOPE_STR("FramesToProcess.PlayFrameData");
          std::lock_guard<std::mutex> Lock(FrameToProcessMutex);
          FramesToProcess.front().PlayFrameData(CurrentEpisode, MappedId);
          FramesToProcess.erase(FramesToProcess.begin()); // remove first element
        }
      }
    }
  }
}

I don't know where you get the fps value, but I guess you calculate it.
The fps value is not in the output of the Camera Sensor

https://carla.readthedocs.io/en/0.9.15/ref_sensors/#rgb-camera
The frame rate is always different from the real time, except you write a code to synchronize the time of the simulation to the real time. I can't tell if it is right, without seeing how you calculate the fps, but I noticed that the timestamp is real time and not simulation time. If you calculate the fps with real time and not simulation time, it is expected to not have a constant fps.
To be sure the camera sensor is not the problem, you can set the "sensor_tick" of the sensor to "fixed_delta_seconds" but this should not make a difference.
Did you test and look if the synchronization mode is active, or did you just look in the code and expect to be active?
client = carla.Client(HOST, PORT)
world = client.get_world()
settings = world.get_settings()
print(settings.synchronous_mode)


Added new template mobile-app-landing

Pull Request
Contribution type

[ -] New template contribution
[ ] Existing template update
[ ] Issue fix
[ ] README.md update

Contribution Description
added new template for mobile app startups
demo: https://gateway.pinata.cloud/ipfs/QmbcBCnNMDbWqS1qKaHzTwhzr7hU2u55NVT2pZFbKF7dvS/
[ ] I would like my template to be added to the Unstoppable Domains' website builder
Unstoppable Domain Name:
If you would like to submit this template as part of our bounty please add your domain name here.
If you don't have a domain yet contact<EMAIL_ADDRESS>for a free domain.

Hey,
Matias from Unstoppable Domains here.
Thanks for submitting a template!
We will be reviewing all pull requests this week.
Best,

Hi, thank you for your submission. We've decided not to accept your submission as part of the bounty competition because it is too complicated to be added to our current website builder. If you would like to simplify it or have it be added after the bounty competition is over feel free to leave this pull request open

I am closing this PR due to inactivity


wait for all get request done and get data

Hi,
I'm doing a GET request to an URL, it will take a moment to get all http responds. I want to wait until all requests done and get the request URL. But I stuck here, fetch node only get one result and it doesn't show the data as I want to.
fetch(URL)         .then(res => console.log(res))
As you can see at the image below, I want to wait all 3 requests done and then copy the URL path. But I dont know how it done with fetch node.

Thank you for help

@kien-pham If you want to wait for all three req's to complete you can use a Promise.all
Promise.all([
	fetch("url1"),
	fetch("url2")
])

You can then attach a .then and get the values from all three responses.


song progress not working

the song progress on spotify stays at 00:00 and 0%

Having the same issue. Did you ever find a fix?

Neverming - I figured it out. If you're still having the problem, you need to change the Player from Spotify to WebNowPlaying and use spicetify-cli to enable the webnowplaying extension. I had tried this and at first it wasn't even retrieving song info from Spotify but after about 10 seconds it finally pulled the data in and properly displayed song and progress info.
https://github.com/khanhas/spicetify-cli/wiki/Guide-for-Rainmeter-user

Yup, I have also outlined the same on my wiki entry. Thanks @jrkmtf for responding to him!


Constraint not satisfied

My design is as follow :

I've set the height constraint for the bottom forgot your password button and login now button, but not the table view in the middle ( which i shouldn't) . The constraint is fine if i run the app without the pager ( with the navigation bar) , but the constraint isn't satisfied when i run the app with the pager. It looks fine to me, but i'd prefer no constraint problem showing in my xcode. Any help?
p.s. : I tried to delete the table view and only keep both buttons, but it still fails.

Fixed in #121


resetStores should also clear the storage (Problems with lazy loaded modules)

When selectPersistStateInit observable fires Akita has not initialized stores from lazy loaded modules. So calling resetStores then doesn't have any effect on those stores. These stores still get restored, when the lazy loaded module gets initialized. Currently the only way I see is clearing the storage manually.
I think resetStores should also delete everything from the persisted State (that is not excluded from resetting). Because when I call resetStores, why would I wanna keep something in the localStorage that then accidentally gets restored, because the module was not initialized.
Edit:
Even clearing the storage manually doesn't help. After akita initialized the persisted state, but has not initialized lazy loaded stores, the state is somewhere hidden and untouchable.

resetStores and persistState are unrelated functionalities. If you want to clear the storage, you can use the API.

Imagine the following scenario:

user navigates through the whole app and all stores get persisted
user refreshes the page, and not opens all lazy loaded modules and then loggs out.
on logout we call resetStores, but only the stores which are initialized get reset. The stores which were not initialized, still stay in the storage and when another user loggs in and navigates to one of the lazy loaded modules, the state from the storage (which belongs to the previous user) gets restored.

I understand the use case. But as I said, those features aren't coupled. When you call resetStores, also call storage.destroy()


Using autoloader in command

I dont know how this line can work; https://github.com/creads/api2symfony-bundle/blob/master/src/Command/RamlGenerateCommand.php#L43
Autoload always will already be required before. So $loader will always be true.
https://github.com/creads/api2symfony-bundle/blob/master/src/Command/RamlGenerateCommand.php#L48 Will raise an error every time.
@pitpit ?

Actually, $loader will be set with the value returned in the file app/autoload.php, which is the composer class loader
I need the loader to find real path to the the directory where controllers stand in the bundle : https://github.com/creads/api2symfony-bundle/blob/master/src/Command/RamlGenerateCommand.php#L48 but i did not find another way to properly retrieve the composer loader


Can't Create SocketAddress Object

When creating a SocketAddress object with the code below, I am getting the following error:
load: 'src/net/sockets.slate'

[| addr |
  addr: (Net SocketAddress newOn: '<IP_ADDRESS>:61613').
] do.

The method #subexpression: was not found for the following arguments: {#(Matcher subexpressions:  #(Dictionary ...). matchee: '<IP_ADDRESS>:61613'. regex: #(Expression ...). Fail: -1). 0}

Am I doing something wrong, or is there a bug there?

It starts here: https://github.com/briantrice/slate-language/blob/master/src/net/sockets.slate#L100C3-L100C3
But I think it's traced to @timmydo's work on the regex update, where the regex library was swapped out without updating the callers fully, here:
https://github.com/briantrice/slate-language/commit/3b8a08bf0b12b6bf58c1834b14c64f96357d4249
Basically, it's calling the old library's subexpression: method, which wasn't ported to the new library per se, and it should be calling subexpressionAt: instead.

I've created a PR I think addresses this, will have to test: https://github.com/briantrice/slate-language/pull/4


prog: use type size when generating/mutating ints

Update #1381

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

Codecov Report

Merging #1395 into master will increase coverage by 0.06%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
+ Coverage   57.82%   57.88%   +0.06%
==========================================
  Files         131      131
  Lines       24849    24856       +7
==========================================
+ Hits        14368    14387      +19
+ Misses       9812     9799      -13
- Partials      669      670       +1

Impacted Files
Coverage Δ

prog/size.go
91.66% <100%> (ø)
:arrow_up:

prog/mutation.go
95.69% <100%> (+0.4%)
:arrow_up:

prog/rand.go
86.21% <91.66%> (+0.5%)
:arrow_up:

prog/checksum.go
76.92% <0%> (-13.19%)
:arrow_down:

pkg/csource/csource.go
81.57% <0%> (+5.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb93629...942f76e. Read the comment docs.

PTAL @dvyukov

PTAL @dvyukov

PTAL @dvyukov

PTAL @dvyukov

Looks good to me!


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/64 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 0c9561d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-25-13-09-15 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-25-13-09-15

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Send messages via PHP

Hello,
I have already running at 3000 port in my server. I want to send messages via PHP. But I can't find a way. I hope it can do by POST method or something.
Thank You.

you can use Guzzle Http
<?php
$client = new Client();
$headers = [
  'Authorization' => 'Basic a2VtYWw6MjEwNA=='
];
$options = [
  'multipart' => [
    [
      'name' => 'phone',
      'contents' => '6283866237125-1365595428'
    ],
    [
      'name' => 'file',
      'contents' => Utils::tryFopen('/Users/aldinokemal/Pictures/bbkkp.png', 'r'),
      'filename' => '/Users/aldinokemal/Pictures/bbkkp.png',
      'headers'  => [
        'Content-Type' => '<Content-type header>'
      ]
    ],
    [
      'name' => 'caption',
      'contents' => ''
    ]
]];
$request = new Request('POST', '{{HOSTNAME}}/send/file', $headers);
$res = $client->sendAsync($request, $options)->wait();
echo $res->getBody();

Thank you very much, i will try this now


Routing strage!

First of all, thank you for your great library!
Here is how to reproduct issue.

define two pages [A, B] with names by getPages in app
on A page, show overlay (any one of dialog, bottom sheet and/or snackbar).
close overlay by Get.back() then move to B by Get.toNamed

Expected.
Stack will be A and B
Current
Page A has been removed and B pushed.
Here is some log for above issue.

Thank you

Could you edit the question with a reproduction case?

on A page
Get.dialog(~~~);
Fututre.delay(Duration(seconds: 3), () {
    Get.back(); // dismiss dialog
    Get.toNamed('/b');
});

My bad, I am sorry.

My bad, I am sorry.

what happened? how did you solved this issue? it would be nice if you tell us


Added new gemini family of medlm large 1.5 preview

Google has released a new model, medlm-large-1.5-preview, as part of the Gemini family.
Changes:

Updated _utils.py to incorporate the new model.
Modified test cases to reflect the updates.

Please review the changes and provide feedback.

Would you please check if you have access to the new model?
"Project<PHONE_NUMBER>70 is not allowed to use Publisher Model projects/llm-integration-tests/locations/us-central1/publishers/google/models/medlm-large-1.5-preview"

Would you please check if you have access to the new model?
"Project<PHONE_NUMBER>70 is not allowed to use Publisher Model projects/llm-integration-tests/locations/us-central1/publishers/google/models/medlm-large-1.5-preview"

Pipeline GCP project does not have access to new models.
"Project<PHONE_NUMBER>70 is not allowed to use Publisher Model projects/llm-integration-tests/locations/us-central1/publishers/google/models/medlm-large-1.5-preview"
Should i keep the integration tests or remove them?

/gcbrun

Pipeline GCP project does not have access to new models.
"Project<PHONE_NUMBER>70 is not allowed to use Publisher Model projects/llm-integration-tests/locations/us-central1/publishers/google/models/medlm-large-1.5-preview"
Should i keep the integration tests or remove them?

I removed the integration test cases now.


Ar test declaration

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-icons@4.12.2-alpha.c12cc9.0@codecademy/gamut-illustrations@0.14.3-alpha.c12cc9.0@codecademy/gamut-kit@0.3.95-alpha.c12cc9.0@codecademy/gamut-labs@15.8.8-alpha.c12cc9.0@codecademy/gamut-patterns@0.1.3-alpha.c12cc9.0@codecademy/gamut-styles@9.9.1-alpha.c12cc9.0@codecademy/gamut-tests@2.3.30-alpha.c12cc9.0@codecademy/gamut@32.18.3-alpha.c12cc9.0@codecademy/konamimojisplosion@0.2.30-alpha.c12cc9.0@codecademy/markdown-overrides@0.5.42-alpha.c12cc9.0@codecademy/styleguide@37.5.3-alpha.c12cc9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://609c4de5d79ae63cb90223cc--gamut-preview.netlify.appDeploy Logs


Query: upstreaming _lib._array_api discussion

Is your feature request related to a problem? Please describe.
Hello,
We would like to implement support for the Python Array API standard in Colour as per https://github.com/colour-science/colour/issues/1244. The work you did in scipy/_lib/_array_api.py seems incredibly useful for that purpose.
Describe the solution you'd like.
We would be keen for the scipy._lib._array_api module to either be made public or, even better, to be moved to its own repository.
Describe alternatives you've considered.
The alternative would be to copy the code entirely into Colour which seems wasteful.
Additional context (e.g. screenshots, GIFs)
No response

hey @KelSolaar ! The plan is to eventually upstream everything in that file that isn't SciPy-specific. Some of it will belong in array-api-compat as helpers. Scikit-learn has a similar file with different functions in it, so the upstreaming process should ideally consolidate the two.
There isn't a timescale on this yet though, as the functions in that file are still going through lots of change as we figure out exactly what we need/want.
Which functions in particular would be useful for you right now? We could discuss whereabouts upstream they might belong.

We won't be making it public though - everything is still very experimental, and most things there would not really belong in the SciPy API.

Hey @lucascolley,
Thanks for the fast reply! At first glance we would likely use all those functions:

array_namespace
atleast_nd
copy
xp_assert_equal
xp_assert_close
xp_minimum would also need xp_maximum
xp_clip
xp_sign

I suspect that the is_numpy one would see good use.

array_namespace

This function is a SciPy-specific wrapper around https://data-apis.org/array-api-compat/helper-functions.html#array_api_compat.array_namespace.
if not _GLOBAL_CONFIG["SCIPY_ARRAY_API"]:
    # here we could wrap the namespace if needed
    return np_compat

_arrays = [array for array in arrays if array is not None]

_arrays = compliance_scipy(_arrays)

return array_api_compat.array_namespace(*_arrays)

I recommend writing your own wrapper for Colour. You could use the same switch of an environment variable or something different at the start. You could replace compliance_scipy with whatever input validation you would like for array types.

is_numpy

Likewise here, you should just make your own version, depending on the relative path of your vendored array-api-compat.
def is_numpy(xp: ModuleType) -> bool:
    return xp.__name__ in ('numpy', 'scipy._lib.array_api_compat.numpy')

atleast_nd

This falls into the category I would describe as "array-api-extra" - array-agnostic functions which sit just on top of the standard, on the borderline between the array-producer and array-consumer library levels. I envision the creation of a new upstream repo to house functions like this; a sort of purgatory between inclusion in the standard, and finding a suitable home in a downstream repo's API.
But, there has been no work towards such a repo yet (that I am aware of).

xp_minimum, xp_maximum, xp_clip, xp_sign

These were recently added to the standard (https://data-apis.org/array-api/draft/changelog.html#additions), and are waiting for array-api-compat implementations. They will become available there in due course (https://github.com/data-apis/array-api-compat/issues/127).

copy

I think that we could look into getting this upstreamed to array-api-compat, alongside its subroutine _asarray.

xp_assert_equal, xp_assert_close

These are rather in flux. You are in good company with @ilayn (and myself) in hoping for these to be provided upstream. See gh-21044 for the contemporary discussion on where we would like these to go in SciPy. After that is all decided and implemented, we should also try to consolidate with whatever scikit-learn is using, before we think about trying to upstream.

cc @ogrisel @betatim for vis

The backlog of APIs to be added to array-api-compat, like minimum, copy, etc., will be worked on very soon - perhaps @asmeurer has already started on it.
For the rest, I think I agree with the answers by @lucascolley and @betatim. A new array-api-extra package will be useful and necessary, but right now is a bit too early to consolidate. I'd recommend borrowing from scipy and scikit-learn what you need for the time being.

Yes, I am working on updating array-api-compat now for 2023 support now.
I agree that any array functions that aren't part of the standard (like atleast_nd) should go in a separate array-api-extra package. It's been brought up multiple times before, so we should probably find a more central place to discuss it. Right now, things like that are out of scope for array-api-compat, because I want to keep that library as a compat layer for the standard only.
Helper functions, though, are in scope, and if SciPy has any that aren't already implemented we can move them over. Note that array-api-compat does already have is_numpy_array https://data-apis.org/array-api-compat/helper-functions.html. which I think is the same as SciPy's is_numpy. Also if there are any features missing from the array-api-compat helpers like array_namespace we can add them. I already have one proposed change to array_namespace which is similar to what SciPy is doing in its wrappers.
Ideally libraries shouldn't need any of their own wrapping code, unless they are really doing things specific to themselves, like SciPy's SCIPY_ARRAY_API environment variables or special handling of numpy.matrix.

Note that array-api-compat does already have is_numpy_array https://data-apis.org/array-api-compat/helper-functions.html. which I think is the same as SciPy's is_numpy.

is_numpy_array takes an array as input. SciPy's is_numpy takes a ModuleType (xp).

I see. I didn't realize doing that way would be more useful, but we can add similar helpers to array-api-compat.

When generating arrays (which sometimes happens without an array already accessible), it is easier to switch on the namespace than have to generate an array or pass one in to switch on.

It would probably be good if we could add a warning in the case that a namespace is passed to is_numpy_array, and similarly for if an array is passed to is_numpy.

https://github.com/data-apis/array-api-compat/issues/156

Thanks a lot for the insights guys, very much appreciated! That certainly gives me a good direction to follow.

Great, glad we have a good way forward. I think this can be closed now. @KelSolaar please do feel free to continue the discussion as needed of course. I think we're all keen to figure this stuff out collectively.


Reorder _global-styles.scss

The _global-styles.scss file is growing in size and it currently contains different kind of customizations.
I propose to split this file in multiple files, each containing:

actual "global" style

additional styles that should be applied everywhere
styles that cannot be placed inside a component unless ::ng-deep is used (*)

Bootstrap overrides
Utility classes (e.g. .dont-break-out and .gap-* clases)

Some styles should be moved inside the component they're being used (e.g. ds-admin-sidebar, .outer-wrapper, .inner-wrapper)
Also - not necessarily as part of this issue - we should move any component style that uses ::ng-deep inside the global styles, as ::ng-deep has been deprecated and its use is a code smell.
(*) We must make sure that homonymous classes won't cause any trouble, either by wrapping the style inside the component selector or by adopting a convention on the class names (e.g. .ds-[component selector] or .ds-[component path]-[component selector])

Seems reasonable, but may need to be done in 8.0 only.  I'm slightly worried that moving styles around in 7.6.x would get confusing for anyone updating to latest 7.x.  This is really just a note for myself that we should likely not backport any of these changes should they make it into 8.0

@tdonohue I could work on this one, on top of #2656


docs: add usage guide for lvmo [skip ci]

Signed-off-by: Leela Venkaiah G<EMAIL_ADDRESS>

You might consider breaking this up into multiple docs and have a main doc that links to the others, just a suggestion for a future PR.

ack, the doc/user-guide/index.md is already in place, when the usage guide grows over current file then we'll break it up.
below is the index if link changes

# Contents

The user-guide describes alternate installation methods and usage.

1. [Deploy Operator via OLM][alt-deploy]
2. [Alternate Usage][alt-install]

[alt-deploy]: ./alt-deploy.md
[alt-install]: ./alt-install.md


Edit any room informations (IDOR)

1-Go to any room
2-Copy room id
3-Send this websocket request ({"op":"edit_room","d":{"name":"test","privacy":"public","description":"test"},"fetchId":"Room id here"})
4-Now you edited the room informations without any permessions
(wrong place , sorry for that)

(fixed)


[WIP] New return for sleep architecture

The PR proposes a new way to choose which layers of the architecture is return.
The old architecture had a bool parameters called "return_feats" allowing to choose to return the prediction for the classifier if it was false and to return the features (i.e. the output of the features extractor) if it was True.
I propose to change this parameters by a string called "layers_returned". This string allows to return the prediction for the classifier if it equals to "classifier", to return the features (i.e. the output of the features extractor) if it equals to "features" and to return both prediction and features if it equals to "all".
My changes are motivated by the application domain adaptation methods to sleep staging which requires both prediction and features.
@agramfort

Hello @tgnassou,
I saw that you closed the PR. Do you need some help with this new functionality? I think this new return could be very interesting.

Hi @bruAristimunha,
Finally I don't need this PR anymore. To deal with my problem, I chose to use hook of pytorch. It allows me to be able to get as many as intermediate layer outputs that I want without change the API of braindecode.


Continue E2E cleanup if apiserver is down

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Proceed with cleanup if apiserver is down and logs cannot be obtained.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/retest
opened #911 to investigate flakiness


GitLab catalog discovery does not stop processing when schedule timeout is reached; task is not refreshed

📜 Description
When using the GitLab catalog discovery, if the discovery task does not complete within the scheduled timeout, the task continues to scan GitLab. This also leads to the task being lost and a refresh never being scheduled, meaning GitLab will not be scanned again.
👍 Expected behavior
The GitLab discovery task would stop scanning when the timeout is reached, and schedule another refresh for the task to scan again.
👎 Actual Behavior with Screenshots
A warning log message shows the task timed out.
warn Task timed out and was lost: GitlabDiscoveryEntityProvider:,my-gitlab:refresh type=taskManager

Debug logs also show that requests to GitLab are still being made.
Once the original task has finished searching for projects, another run of the discovery task never occurs.
👟 Reproduction steps
Use the example catalog config for the catalog discovery:
catalog:
  providers:
    gitlab:
      my-gitlab:
        host: my-gitlab.com
        skipForkedRepos: true
        entityFilename: catalog-info.yaml
        projectPattern: '[\s\S]*'
        schedule:
          frequency: { minutes: 2 }
          timeout: { seconds: 1 }

Configure the schedule and target host to scan something such that, it will not be able to fully complete before the timeout.
📃 Provide the context for the Bug.
I'm not sure if this is the right direction, but the GitlabDiscoveryEntityProvider does not appear to utilize the abort signal from the TaskWorker. It seems like the PluginTaskSchedulerJanitor clears information from the task, including the current_run_ticket. This may be affecting the release of the task by the TaskWorker.
When checking for that signal with these changes, the task stops scanning GitLab once the timeout is reached. As well, I can see a debug log for the task refresh now occuring, which eventually leads to a new task run.
debug task: GitlabDiscoveryEntityProvider:my-gitlab:refresh will next occur around 2023-12-05T16:20:47.563-06:00 type=taskManager task=GitlabDiscoveryEntityProvider:my-gitlab:refresh

I'm not sure if this is the right direction, because looking at other providers, such as Azure DevOps, BitBucket, and GitHub, none of them utilize the abort signal either.
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

The task scheduler is a standalone library functionality that doesn't directly affect the scheduled work. All it does is to provide an AbortSignal that the scheduled work can choose to react to, or not. The reason for this is that in Node, we can't really pre-empt work or kill a thread or similar. Well, unless we start going into workers and stuff, but it's still often not desirable since it can leave external effects half-done etc.
https://github.com/backstage/backstage/blob/master/packages/backend-tasks/src/tasks/types.ts#L31
What's needed here is probably to add the feature of abortability to that provider., such that it properly reacts when the abort signal triggers. Adding a help wanted label.

Yep, pretty much.


Hotfix driver display gc9x01x

The purpose of this Pull Request is to fix GC9X01X driver:

documentation with a duplicated entry
an include not properly done and not checked during the integration of this driver few weeks ago

@fabiobaltieri here it is the most important fix from my board PR for 3.6.0-rc1 :)

Hey thanks, the test was ineffective as it turns out, queued up https://github.com/zephyrproject-rtos/zephyr/pull/68526 to fix it (needs this to go in first obs)

Merging as hotfix since it fixes a build error (and so I can kick the other PR that makes the CI actually fail)


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit fb33524:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch 7813f285-6c88-4191-8010-2e1d335325ea has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


jobs: allow blocking job adoption via sentinel file

PR: https://github.com/cockroachdb/cockroach/pull/44786
From release notes:

It's now possible to disable job execution on a node in emergency cases. To do so, place a DISABLE_STARTING_BACKGROUND_JOBS file in the node's first store directory. [#44786][#44786] {% comment %}doc{% endcomment %}

Closing this issue - chatted with @dt and @mwang1026. Both are 50/50 on if we need to document it or not. Michael brought up that even if we do document it, people might be hesitant to use the file and reach out to support anyway. I think leaving this undocumented (for now) is fine.


[SPARK-21031] [SQL] Clearly separate spark's stats and hive's stats

What changes were proposed in this pull request?
Currently, hive's stats are read into CatalogStatistics, while spark's stats are also persisted through CatalogStatistics. Therefore, in CatalogStatistics, we cannot tell whether its stats is from hive or spark. As a result, hive's stats can be unexpectedly propagated into spark' stats.
For example, for a catalog table, we read stats from hive, e.g. "totalSize" and put it into CatalogStatistics. Then, by using "ALTER TABLE" command, we will store the stats in CatalogStatistics into metastore as spark's stats (because we don't know whether it's from spark or not). But spark's stats should be only generated by "ANALYZE" command. This is unexpected from this command.
Secondly, now that we store wrong spark's stats, after inserting new data, although hive updated "totalSize" in metastore, we still cannot get the right sizeInBytes in CatalogStatistics, because we respect spark's stats (wrong stats) over hive's stats.
To fix this, we need to clearly separate spark's stats and hive's stats in CatalogStatistics.
How was this patch tested?
Modified existing tests and added a new test.

Test build #77837 has started for PR 18248 at commit 0d56f16.

cc @cloud-fan @gatorsmile

To be honest, I also hit this error and plan to fix it. Fortunately, I have not started it yet. : )

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77837/
Test FAILed.

retest this please

Test build #77847 has started for PR 18248 at commit 0d56f16.

Test build #77847 has finished for PR 18248 at commit 0d56f16.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ExternalStatistics(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77847/
Test FAILed.

Test build #77860 has started for PR 18248 at commit 835b6f2.

Test build #77860 has finished for PR 18248 at commit 835b6f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77860/
Test FAILed.

I think the real issue is that, we mistakenly add statistics in ALTER TABLE. This is because ExternalCatalog.alterTable is heavily used when we wanna change something for a table. I think it would be better to introduce a ExternalCatalog.alterTableStats and use it in ANALYZE TABLE, so that ALTER TABLE won't add statistics.

@cloud-fan Actually that is my first version.
It also has problems: if we generate spark's stats first (through analyze command and alterTableStats), then do a regular alter table command, the stats will lost. Because we don't store stats info (which is fromCatalogStatistics) through alterTable, and we don't know where the stats info come from (hive or spark), so we can't decide whether to store the stats or not in alterTable.

alterTable won't set new stats but can still keep existing states, can we implement this?

@cloud-fan How can we tell in alterTable whether it's new stats or not?

I mean how can we keep existing stats? Since we cannot tell whether it's from hive or spark, if we store it as spark's stats, then we come back to the problem. If we don't, then we lost stats if it's generated by spark.

alterTable can read states from the old table and keep it: https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L564
basically alterTable should ignore the stats from input table metadata and keep the stats as it was in the old table metadata.

@cloud-fan Oh, right, let me try. Thanks!

Test build #77867 has started for PR 18248 at commit 2649135.

Test build #77868 has started for PR 18248 at commit 38d03d7.

LGTM except one minor comment

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77868/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77867/
Test FAILed.

Test build #77869 has started for PR 18248 at commit 0ba01ac.

Test build #77869 has finished for PR 18248 at commit 0ba01ac.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77869/
Test FAILed.

retest this please

Test build #77877 has started for PR 18248 at commit 0ba01ac.

Test build #77877 has finished for PR 18248 at commit 0ba01ac.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77877/
Test FAILed.

retest this please

Test build #77885 has started for PR 18248 at commit 0ba01ac.

In addition to e2e test cases, we also need to add unit test cases in SessionCatalogSuite and ExternalCatalogSuite.

LGTM except the above two comments.

Test build #77885 has finished for PR 18248 at commit 0ba01ac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77885/
Test PASSed.

Test build #77896 has started for PR 18248 at commit 221d052.

Test build #77896 has finished for PR 18248 at commit 221d052.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77896/
Test PASSed.

thanks, merging to master!


multiple disable_gradient_checkpointing #69

#69

Hey @FurkanGozukara. If you're still having this issue, please open one so I may look into it.


Load solium config from .soliumrc.json on root project folder

Fix #103
Probably still needs some extra work, but already in action.

While doing this I found one thing, I think we can reuse some code between linters. Yes, I know they work in different ways, but we can use the same code to load files and also, we can use the same methods name for each linter, which makes code more consistent. I didn't happened an issue for this, because maybe it does not makes sense. Please give me your opinion.

That is a tricky one, especially as we don't control the direction and things might change. Although if it makes sense sure.

One thing that it could be used, is for the client to notify the server of those file changes. So that will be probably the direction to use. That way it could be reused for any other type of file.
So the client will have something like:
    // Options to control the language client
    let clientOptions: LanguageClientOptions = {
        // Register the server for plain text documents
        documentSelector: [{ scheme: 'file', language: 'plaintext' }],
        synchronize: {
            // Notify the server about file changes to '.clientrc files contained in the workspace
            fileEvents: workspace.createFileSystemWatcher('**/.clientrc')
        }
    };

and the server this:
connection.onDidChangeWatchedFiles(_change => {
    // Monitored files have change in VSCode
    connection.console.log('We received an file change event');
});

From the docs
https://code.visualstudio.com/docs/extensions/example-language-server

Many thanks by the way :) 👍

May I ask what if the .soliumrc.json file is not in project's root folder? How can I specify the plugin to read from specific folder and add customized solium rules? Thanks!

From my experience, it works even with .soliumrc.json in any folder inside the project folder. If you have more than one, what I think that happens is that it tries to load one of the files.
You only have to follow the README to make it work.
If you have doubts, ask on gitter.


Add a new conversion option DisableDetectScaleUnits to Azure Object Anchors

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.MixedReality.ObjectAnchors.Conversion

Can anyone help merge this PR?

£
0
Bn,
On October 22, 2022 8:36:08 AM GMT+08:00, Bing Hu @.***> wrote:

Can anyone help merge this PR?
--
Reply to this email directly or view it on GitHub:
https://github.com/Azure/azure-sdk-for-net/pull/31850#issuecomment-1287558829
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

V PTA*.,0l3@ L+b=I6
On October 22, 2022 5:18:40 AM GMT+08:00, "Ramón Argüelles" @.> wrote:
@. approved this pull request.

--
Reply to this email directly or view it on GitHub:
https://github.com/Azure/azure-sdk-for-net/pull/31850#pullrequestreview-1151562950
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

Validated that the package name has been approved and it is a preview release.


WIP

@rynowak are there any chanches to allow async model validation? ;)

@ilmax - not part of this change. Feel free to open an issue but it's something we're very unlikely to do because it increases the overhead significantly in a very hot path.
A more workable solution would to be implement whatever you need in an action filter, or replace the IControllerActionArgumentBinder which are both async.

Thak you @rynowak for your quick response, I've already opened an issue in the past around a sync model validation. Performance is a fair argument to exclude the feature, but sometimes is useful (or even required) to hit some external resources to perform model validation.
What I would like to have (as a opt-in feature maybe via a different package) is the ability to hook into the validation phase and write async logic without rewrite the whole validation components, is that possible in some way?

What I would like to have (as a opt-in feature maybe via a different package) is the ability to hook into the validation phase and write async logic without rewrite the whole validation components, is that possible in some way?

You can do this today by replacing IControllerActionArgumentBinder with your own implementation. You'd need to replace this code with your own validation system: https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/Controllers/DefaultControllerActionArgumentBinder.cs#L98
We'd be open to changes to make this kind of extensibility easier, but it's unlikely we'd put it in the box.

@dougbu  - updated with docs and such. My only outstanding TODO that I know of here is to write unit tests for each of the validation strategies.

Only found small issues. You gots a :shipit: from me :smile:


Improve the error message

Codecov Report

Merging #6 (42c5447) into master (5143cb4) will decrease coverage by 0.89%.
The diff coverage is 57.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   91.42%   90.54%   -0.89%
==========================================
  Files           1        1
  Lines          70       74       +4
==========================================
+ Hits           64       67       +3
- Misses          6        7       +1

Flag
Coverage Δ

unittests
90.54% <57.14%> (-0.89%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

rmdir.lua
90.54% <57.14%> (-0.89%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allow pasting algebraic lines into the repertoire builder

It would really speed things up for me. Thanks for the great app!

In the meantime, I created a (very minimal) utility that can combine lines (which can then be imported with the import PGN feature): https://www.brick.codes/pgn/
1.e4 e5 2.Nf3 Nc6 3.d4 exd4 4.Nxd4 Nxd4 5.Qxd4 d6 6.Nc3 Nf6 7.f3 Be7 8.Be3 O-O 9.O-O-O
1.e4 e5 2.Nf3 Nc6 3.d4 d6 4.d5 Nce7 5.c4 Nf6 6.Nc3 Ng6 7.h4 Bg4 8.Be2 c6 9.Be3 Be7 10.g3

->
1. e4 e5 2. Nf3 Nc6 3. d4 exd4 (3... d6 4. d5 Nce7 5. c4 Nf6 6. Nc3 Ng6 7. h4 Bg4 8. Be2 c6 9. Be3 Be7 10. g3) 4. Nxd4 Nxd4 5. Qxd4 d6 6. Nc3 Nf6 7. f3 Be7 8. Be3 O-O 9. O-O-O


Support Reporter

Sorry, what is this PR about? You changed the project name and all? Is it a mistake?


Adds ability to compile the compiler as a wasm module

This allows the compiler to be a wasm module that can be called from typescript.
There is a caveat:

The standard library cannot be compiled with the wasm version of the compiler. An issue for this will be opened.

To compile the wasm crate, you can:

cd crates/wasm
wasm-pack build --target nodejs

Currently, we use Serde for ACIR. We should add a .to_bytes and .from_bytes to ACIR as we can expect it to be used in other languages.

The pkg folder is autogenerated by wasm-pack I've included it because I made some minor changes such as "changing the package name" and "including all files" to it and uploaded it to npm.

Currently, we use Serde for ACIR. We should add a .to_bytes and .from_bytes to ACIR as we can expect it to be used in other languages.

Serde shouldn't have any relevance here, we use serde-json so other languages can use their own json en/decoders. If the issue is calling noir compiler functions from other languages, we can expose C bindings as well.

Currently, we use Serde for ACIR. We should add a .to_bytes and .from_bytes to ACIR as we can expect it to be used in other languages.

Serde shouldn't have any relevance here, we use serde-json so other languages can use their own json en/decoders. If the issue is calling noir compiler functions from other languages, we can expose C bindings as well.

A json representation would be good for when the program is small and one wants to debug the ACIR circuit. Doesn't really need to be JSON, just something readable for debugging.
For serialising ACIR for wasm (or later for native) we want a compact representation of ACIR. Using bytes seemed like the best alternative as it does not assume anything apart from the developer being able to unpack bytes into an ACIR structure and it should also be efficient space wise. I thought of using some sort of serde_bin crate, but I opted not to as it seems like an unecessary dependency that may require non-rust developers to look into serde_bin to see how exactly it is serialising the structure to bytes.

That makes sense, I was confused by the inclusion of serde. Looking at https://serde.rs/ there are other more popular binary formats we could choose from as well that have standards and have en/decoders in other languages. A few options are: MessagePack, BSON, Avro, FlexBuffers, Bencode, and a few others


Design QA: App bar + nav bar: Nav bar styling

https://www.figma.com/file/bZh7tOiLm6Ls9Hl4RL6qMC5X/Augur-Redesign?node-id=425%3A93

[x] 48px height

[ ] Update text size and style

[x] Check background colour is correct

[x] Active item underline sits on the bottom of bar

Background colour should be #161518

Font should be Mono Bold 12px


Rename a label to reflect current default

Please see https://help.github.com/articles/about-labels/. good first bug was probably an old name of that default label. I updated it across all translations to good first issue.

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Thanks again @katrinleinweber!

You're welcome :-)

cPro Marketplace makes it easy to find great deals on the things you want
and make money on the things you want to sell:
Android: https://play.google.com/store/apps/details?id=craigs.pro.plus
iPhone: https://itunes.apple.com/us/app/id1249096797?mt=8
Please download the app onto your iPhone or Android phone, and I will get
1,500 cPro Coins for shopping on cPro Marketplace.
Thanks!


Add requirements.txt? and other questions & suggestions

Hello,
I'm the maintainer of gh-md-to-html and I have some questions and suggestions regarding gh-md-to-moodle, if that's okay with you :)
I noticed gh-md-to-moodle declares its dependencies in your setup.cfg-file. Whilst this is (as far as I'm aware?) the recommended method, it is neither recognized by dependabot, nor is it recognized by the GitHub Dependency Graph, who both only look at setup.py and requirements.txt.
Having the project's dependencies recognized by the GitHub Dependency Graph means that (a) you are notified of potential vulnerabilities in your dependencies if they arise, (b) your dependencies are publically and easily visible in the Insights-Tab of your repository, and (c) your project gets listed in the dependents of the repositories you depend on, which potentially helps their maintainers (like me) become aware of your usage of your tool (potentially useful if they want to learn more about their user base), plus it looks good in their repositories (which actually is the main reason I decided to file this issue for).
You might consider additionally adding your dependencies to a requirements.txt-file for the reasons above.
Another thing I noticed is that you strip the newline after and in front of opening and closing code-tags. I'm not exactly sure why you are doing this, but if this serves to compensate for a bug in gh-md-to-html, then I'd be happy to fix said bug! :D
It also seems like you inject some JavaScript into the generated page, that then embeds some CSS into the page's header, which causes Moodle not to display the file correctly in the preview (according to your README). Did you consider using the extra_css argument in gh_md_to_html.main() to add some additional HTML like gh-md-to-html's README suggests? It might work too (unless you need the CSS to be specifically part of the header of the page), and display better in the preview.
It also seems to me like you are trying to reverse the effects of gh-md-to-html caching images and changing links to images within the rendered HTML. You can do this supplying enable_image_downloading=False to gh_md_to_html.main, which is probably a cleaner solution (not properly documented yet, though, admittedly).
I'm also somewhat confused about the nature of the CSS you inject: Is it merely supposed to make the generated page blend in with Moodle better (as seems to be the case with the pink color for code blocks), or does it also fix potential problems with the styling gh-md-to-html injects? If it's (partially) the later one, feel free to file an issue in gh-md-to-html (or tell me about it in this issue) so I can try to fix them. :)

Hi, thanks for your comments and for the great tool you made I really enjoy using it!
sure, I can add a requirements.txt in the next days, or you can just send a PR if you want to. Github unfortunatelly refuses to implement proper parsing of setup.cfg this has been a known issue for quite some time now...

Another thing I noticed is that you strip the newline after and in front of opening and closing code-tags.

I think there was an issue with the code formatter I used from BeatufilSoup. It would create newlines after the code tags which would cause the page not rendering correctly -- not sure why this is the case though. I did not want to put too much effort into this so I must admit this is a hacky solution.
this would be the formatted html output:

Assign one of the following data types

int

,

float

,

str

,

bool

to the statements below:

but it would render as:

It also seems like you inject some JavaScript into the generated page

This whole solution is trying to work with the little options moodle provides for easily providing syntax highlighted code snippets. So the issue I initially wrote this tool for was me having to create exercises for programming courses. So it is really convenient to write markdown for this, but moodle can't handle it natively. Of course I could have provided pdfs, but I wanted to integrate it so no files had to be downlaoded. Moodle has a built in text editor where you can edit the page you are creating either in formatted text where the html is done behind the scenes or as plain html. This editor/the whole page does not allow additional style sheets (they are removed when parsing your provided input). But moodle allows


[Enhancement] Export view as PDF

Use case: Bob wants to export 1 view into PDF from the model / .archimate file, which contains more views.
Current situation:

Bob can export 1 view to the Image (right click - Export -> View as Image
Bob can export whole model into PDF (File -> Report -> Jasper ...)

Current workaround:
Bob copies content of the particular view (CTRL A) into the new model.
Bob uses Jasper report to create the PDF file.
note: Bob has to set Jasper related attributes in the new model if needed.
Desired situation:
Bob right clicks on the view (Export -> View as Jasper report), which would initiate the Jasper dialog with the scope of that particular view and model's elements, which are present on the view.

Did you try the Export View as Image and select the PDF option from the drop-down in the dialog?

Or Bob can put tags on views and run the Jasper report using the #tag selector...
See Archi USer Guide on page 90:
Report:View:Tag

Use this property to tag a view (you can use this property multiple time). Tags can then be used to create a report containing only one specific tag. To do this add "#tagname" to the end of the report title (case insensitive). You can make a view visible for all tag using the special tag "all".

Shall we close this one? I think Bob has some good options, now.

Shall we close this one? I think Bob has some good options, now.

One action (on my side) is be make it more clear that Jasper support this use case. I'll update user manual in HTTP for upcoming 4.7 (I've seen a new branch for that).
Reopening until this is done

@Phillipus , @jbsarrodie Thanks for the answers.
The added value of the PDF export is to report also the (non visible) content, such as descriptions, etc.
Therefore export -> view as image -> PDF file looses this added value. Though Bob appreciates that such convenient function is available ;)
I tested the tag option (thank you for mentioning that):

only the tagged view was exported, however for other content (relations, elements, etc.) the whole file's model was exported. Which makes the bloated PDF with data tables and one desired view.

Comparing to the mentioned workaround where only view related elements and relations were exported.

however for other content (relations, elements, etc.) the whole file's model was exported. Which makes the bloated PDF with data tables and one desired view.

Read the full page 90 for an answer ;-)

I've seen a new branch for that

@jbsarrodie Yes, all help changes for 4.7 are in that branch. That means we can make multiple changes and correct our own errors. When done, I'll squash and cherry pick into master.

however for other content (relations, elements, etc.) the whole file's model was exported. Which makes the bloated PDF with data tables and one desired view.

Read the full page 90 for an answer ;-)

I might be blind - my apologies - I do not see the property which would state "limit the scope of reported elements to rendered views only"
Or do you mean "Report:View:Detailed" ?  That did not limit that.
I also tested:
Report:Model:Hide:Relations: true @ model file level (resp. all properties set to hide, but Views, and ViewNumbering)
and
Report:View:Detailed: true @ view
Which resulted in the limited report (view + related elements), but without related relations.
Ideal output scope is selected view + view related elements + view related relations.

I might be blind - my apologies

No need to apology, this tends to proove that this part of the doc has to be rewritten.
You have to set all these properties to true at model level:

Report:Model:Hide:Strategy
Report:Model:Hide:Business
Report:Model:Hide:Application
Report:Model:Hide:Technology&Physical
Report:Model:Hide:Motivation
Report:Model:Hide:Implementation&Migration
Report:Model:Hide:Other
Report:Model:Hide:Relations

This will keep only the "Views" section which you can further filter using a tag. You can then set Report:View:Detailed to true to get a more complete list of elements.

Which resulted in the limited report (view + related elements), but without related relations.

Yes, per view list of relations is not supported.

Which resulted in the limited report (view + related elements), but without related relations.

Yes, per view list of relations is not supported.

So in fact the enhancement could be that this would become supported :)
I.e. view only property:
Report:View:Relations: true / false


Fix mustSatisfyAnyOf logic (fix #101).

should fix #101
Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x]  Relevant tickets are mentioned in commit messages
[ ] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Seems fine @ak3n ; but I note that the PIR gets larger, and some of the golden outputs (amounts) change? Is that because the PIR got larger? Is that expected?

@silky I think they get changed each time in renderGuess.txt.
At least it was true for https://github.com/input-output-hk/plutus-apps/commit/63123ffb527a37ba357e4cb38690625f945710b9, and for others commits in the history of that file.

@ak3n I'm happy then if you're happy :)


Its not working for me module.js:591 throw err^

syntax error token M is at position 15
then keeps saying goto start
node self.js

C:\WINDOWS\system32>goto START
C:\WINDOWS\system32>node self.js
module.js:471
throw err;
^
Error: Cannot find module 'C:\WINDOWS\system32\self.js'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:393:7)
at startup (bootstrap_node.js:150:9)
at bootstrap_node.js:508:3
C:\WINDOWS\system32>goto START
C:\WINDOWS\system32>node self.js

i have been trying to fix this for days then i decided to get help and i don't know how to fix this and i'm an expert with computers

i have tried to install a later version of node and it still wont work

it might be an issue with self.js
cause i cant find what to open it with
and same with the json files

Huh? After you install node and run the installer.bat file (if the file doesnt work just open a terminal inside of the folder where your files are and run npm i).  You can right click the .js file and click on open with Notepad++, but that will just show the code. To actually run it you need the console to do so. By the looks of the second comment (C:\WINDOWS\system32) it looks like the computer is trying to run it with administrator permissions and not in the file where the self.js is, thats why it errors, because it isnt able to find it.

oh
thats too much tho i need to fix it is there an easy fix?

There isnt really anything to fix. You are just probably starting it in the wrong folder. Try opening a terminal inside of the folder where the selfbot files are and running node self.js. Not to mention syntax error token M is at position 15 seems to be a config file error, but the second one with C:\WINDOWS\system32 is already related to the starting of the bot itself.

well i have an error running self well i runned it with node.js and i cant get it back to its default and i cant change it when i try to run it it says syntax error this is all with the .js files which i set the file location as node and i cant change that

need help changing that

well i saw it was changed but it still has node icon but then it has opened with microsoft thing thats why there is a syntax error but i need help with that too

Are you trying to run the batch file inside of 7zip or WinRAR?

idk
which should i use

Don't use any, extract the files first before you try to start up the bot.

i did the files are messed up

From what I can tell, you're trying to run the bot with Administrative permissions, thus it's looking for self.js in C:\WINDOWS\system32\.
*If you're right clicking on the batch file and clicking Eun as Administrator, don't click that. Just run the file as any other file.
*If the file is running as Administrator regardless, click click on the batch file and navigate to Properties > Comparability and uncheck Run This Program As An Administrator. be sure to click OK (this will apply the settings and close the window). Now to try run the file.

The comment above should fix it. Make sure you are doing everything right. Feel free to re-open this if the problem still happens.


Refs #32062 -- Added "%b" option in "Date.strtime"

Added "%b" option in "Date.strftime" method to render abbreviated
month name in Associated Press style

Why did you use %b for this AP style? It doesn't seem consistent with Python or Django.
%b in Python's datetime is "Month as locale’s abbreviated name." which makes returns "Mar" for March. Django's date template filter adds "N" as the Associated Press style which returns "March", as you have here in the code.

Thanks for pointing that out Adam. I overlooked the difference between %b and %N. I went with adding AP style because I thought it would be more consistent with what Django admin already displays for dates and it will be better to be able to format dates like that.
%b in Django's date template formats month in 3 characters lowercase format, e.g. jan, feb
%b in Python's datetime  formats month as abbreviated month name by capitalising first character, e.g. Jan, Feb
I think it will be better to follow the Python's conventions of datetime implementation since %B option already does that.
Should I also add %N option as it can come handy in future?

@pandafy Thanks for this patch 👍 Please limit this PR only to the "%b" format, you shouldn't add features not accepted in the ticket.

@pandafy Thanks for this patch  Please limit this PR only to the "%b" format, you shouldn't add features not accepted in the ticket.

I have removed the implementation for "%N" option. I will always keep this in mind to limit the scope of a PR to only thing accepted in the ticket while making contributions in future. :smile:

What about documentation for this change, is there not a place in the documentation this is represented?

I failed to find documentation for implementation of strftime in JavaScript. It will be really helpful if you can point me to the documentation. I searched for strftime in the docs directory and looked at commits adding strftime in code.
I think it was supposed to be just used internally in Django and not to be offered to users. Since, it can be useful to users(at least it was to me) it will be worth documenting. Should I create a new ticket for documenting strftime and strptime ?

@pandafy Welcome aboard :boat:

buildbot, test on selenium.

👍 Thanks @pandafy and @felixxm !


[release-1.8] make: cmctl and kubectl-cert_manager were using two -ldflags

Manual backport of #5022 - part of #5020
(Actually not that manual; this is the original commit which @maelvls wrote. #5022 now applies against master and release-1.9 and the original applies against release-1.8)
Kind
/kind bug
Release Note
`cmctl` and `kubectl cert-manager` now report their actual versions instead of "canary", fixing issue [#5020](https://github.com/cert-manager/cert-manager/issues/5020)

flake
/test pull-cert-manager-e2e-v1-24


Use periods consistently

As it stands, some abbreviations include periods, while others don't. Compare for example "Quality Assurance in Health Care" (Qual. Assur. Health Care) and "Quality Assurance in the Fish Industry" (Dev Food Sci).
Is there any reason for this inconsistency? I think it would be best to always use the period or not and to possibly leave the choice up to the user.

This somehow relates to https://github.com/JabRef/abbrv.jabref.org/pull/54.
I think, we did not properly document how the whole journal abbreviation lists are created, combined, etc.
We have some initial documentation at https://docs.jabref.org/advanced/journalabbreviations. And we are automatically importing the journal lists from here via https://github.com/JabRef/jabref/blob/master/.github/workflows/refresh-journal-lists.yml.
I currently have no time to dive into this topic further. Maybe you can? I know this it hard stuff and will take much time.

Hi koppor, thanks for looking into this.
I am not sure how the lists are created. It says in the workflow you linked to:
      # remove all lists without dot in them
      # we use abbrevatiation lists containing dots in them only (to be consistent)

But on the other hand there is a Python script in the merge you linked to that uses those lists.
Anyway, one idea for adding the dots would be to not add them to non-abbreviated words only. For that, you could look for exact matches in the abbreviated and non-abbreviated columns and assume that the ones which are the same are non-abbreviated words which require no dot.
I am not sure if that makes sense for all cases, as it does not apply for the example I listed ("Quality Assurance in the Fish Industry" -> "Dev Food Sci"), but to be honest, I am not sure if this is not an error anyway.
I also don't know if you would want to go ahead with modifying the lists at all or rather keep them intact and separate them into "with dots" and "dotless" only.
Let me know what needs to be done and I can judge better if I would be able to do that.

We have no documentation how the lists are created. One has to check the log of each file https://github.com/JabRef/abbrv.jabref.org/tree/main/journals. I hope, someone refines the README.md stating the source of the lists.
One has to note that

The lists in JabRefs distribution are created at https://github.com/JabRef/jabref/blob/3d7521c29145a24f473efe9a743d8d730ceef588/.github/workflows/refresh-journal-lists.yml#L48. It takes the dotless lists only
I have no clue who uses the Python scripts. The lists type dot / dotless are hardcoded in the python scripts: https://github.com/JabRef/abbrv.jabref.org/blob/08255f6bf7d1daef55b526e406a632affc494491/combine_journal_lists_dots.py#L19
I think, the script https://github.com/JabRef/abbrv.jabref.org/blob/main/combine_journal_lists.py is only there for completeness.

Anyway, one idea for adding the dots would be to not add them to non-abbreviated words only. For that, you could look for exact matches in the abbreviated and non-abbreviated columns and assume that the ones which are the same are non-abbreviated words which require no dot.

I second this approach. It seems like it would easily allow to automate this and it also appears to cover most cases (correctly).
Are there objections to adding a script to this repo that applies this rule to all CSV files and which is then also used on a PR-Check to ensure that proper punctuation is continued to be used?

@Krzmbrzl  I think this sounds like a valid idea! You are welcome to provide a script!

So I gave this a try and came up with
#!/usr/bin/env python3

import argparse
import os
import csv

# A list of CSV filenames that shall be excluded from being processed
blacklist = [
        "journal_abbreviations_annee-philologique.csv"
]

def main():
    parser = argparse.ArgumentParser("This script will make the use of periods in journal name abbreviations consistent (make sure they are used)")
    parser.add_argument("--journal-dir", help="The path to the directory containing the journal CSVs", metavar="PATH", default="journals")

    args = parser.parse_args()

    for currentFileName in os.listdir(args.journal_dir):
        if currentFileName in blacklist or not currentFileName.endswith(".csv"):
            continue

        changedEntries = 0
        changedRows = []

        with open(os.path.join(args.journal_dir, currentFileName), "r", newline="") as currentFile:
            # Assume files are small enough to easily fit in memory
            reader = csv.reader(currentFile, delimiter=";")

            for row in reader:
                if len(row) == 0:
                    # Skip empty lines
                    continue

                # columns are separated by semicolon

                assert len(row) >= 2 and len(row) <= 4, "Invalid column count in CSV file"

                fullName = row[0]
                abbreviation = row[1]
                # shortestUniqueAbbreviation = elements[2]
                # frequency = elements[3]

                specialChars = [",", ":", ";", "(", ")", "[", "]", "{", "}", "\"", "'"]

                fullWords = [x.strip().lower() for x in fullName.split(" ")]
                abbrWords = [x.strip() for x in abbreviation.split(" ")]

                # Replace special chars in full word list
                for currentChar in specialChars:
                    for i in range(len(fullWords)):
                        fullWords[i] = fullWords[i].replace(currentChar, "")

                # Remove empty entries
                fullWords = list(filter(None, fullWords))
                abbrWords = list(filter(None, abbrWords))

                changed = False

                for i in range(len(abbrWords)):
                    if any(char in specialChars for char in abbrWords[i]):
                        # Word contains a special character -> rather leave it alone
                        continue
                    if "-" in abbrWords[i]:
                        # Dashes in words are suspicious as well -> let's rather not touch these
                        continue

                    if abbrWords[i].endswith("."):
                        # Is already using a period
                        if abbrWords[i][ : -1].lower() in fullWords:
                            # The word was used as an abbreviation, but it appears that it wasn't really abbreviated -> remove period
                            abbrWords[i] = abbrWords[i][ : -1]
                            changed = True
                    else:
                        if abbrWords[i].lower() in fullWords:
                            # Assume that every word that appears in the full journal name as-is, is not
                            # abbreviated and therefore also should not get a period attached to it
                            continue
                        else:
                            # Since the current word is not part of the full journal name, we assume that it
                            # was abbreviated and thus, we add a period to it
                            abbrWords[i] += "."
                            changed = True

                if changed:
                    changedEntries += 1
                    row[1] = " ".join(abbrWords)
                    # print(" ".join(fullWords), "->", " ".join(abbrWords), "(", abbreviation, ")")

                changedRows.append(row)

        if changedEntries > 0:
            # Write out new content
            with open(os.path.join(args.journal_dir, currentFileName), "w", newline="") as currentFile:
                writer = csv.writer(currentFile, delimiter=";", lineterminator="\n")
                writer.writerows(changedRows)

        print("======== Changed %d entries for %s" % (changedEntries, currentFile.name))

if __name__ == "__main__":
    main()

However, as it turns out, there appear too many exceptions that can't be handled properly using this simple approach. From what I have seen so far, I would even go as far as to say that an automated approach is probably not really feasible and any changes have to be performed manually by someone who knows what they are doing :shrug:

So wee need to have seperate lists with dots and without dots? Maybe your script can generate a basis...

I think we should use ISO 4 journal abbreviations with periods, because removing periods is much more reliable than adding them, as suggested by another similar program, Zotero ^1.
JabRef could perhaps have a built-in feature for removing periods, or this repository could store only abbreviations with periods, and output a copy of the abbreviations without periods (in a combine script)

Our documentation at https://docs.jabref.org/advanced/journalabbreviations has journal lists with dots. We have documentation on our lists at https://github.com/JabRef/abbrv.jabref.org/tree/main/journals#readme.
"Entrez", "Index Medicus" provides dotless abbreviations only. How to handle these?
I think https://github.com/JabRef/jabref/issues/10557, needs to be fixed. Then, the combined journal list is obsolete. Then we can do lists per area (e.g., medicine, computer science, ...)


remove ChangeRecord.changes

it's a terribly confusing name.
Ideally we can remove the ChangeRecord base type.

This issue has been moved to dart-lang/observe#48.


[Feature request] Custom file naming scheme of modules and chunks

Versions
@angular/cli - All versions

Feature request
Currently there is no way to use custom file naming schema for modules and chunks.
For example, when building production application with CLI, the chunks start with number. And a production server of clients we are working for won't serve any files that start with number.
In Webpack we can change the file naming convention easily in configuration like this  [name].[hash].bundle.js.
It would be nice to have this, so auto-build systems can just run CLI and pack and publish Angular along with .NET Core and similar technologies.
Observed behavior
No file naming schema options
Desired behavior
A variable in angular.json that will pass specified file naming schema to webpack config and/or command parameter with same role.

Any update on this feature?

You can use namedChunks to output the bundle with a name instead of a number.
See: https://angular.io/cli/build
I am closing this issue, as namedChunks is sufficient for this use case. If there is any other use case this is not covered by this. Kindly open a new issue explain the use case of having a different named chunk from the default provided.
Thanks.


Add German translation

Awesome @tomlutzenberger. Thank you so much for your contribution.
Merging

You're welcome 😃


Global Import in Bootstrap.js files

Adding
window.route = require('./routes.js').route;
to bootstrap.js is an easier, more reliable way of importing the routes into webpack and doesn't require editing the Mix JS file
Note: Not really an issue, more of a suggestion, but wanted to add it here for users to see

Thanks for the advice, added to README


Streamline the configuration

The installation of dependencies and setup for Windows has been removed
Instead of uploading all files from the install directory, only specific shared libraries are uploaded now.

Todo: need to check that the artifacts are correctly uploaded

Was it not possible to use Clang-cl instead of cl? libriscv definitely builds and runs complex programs on Clang-cl. It's one of the things I test for each release.
It also builds in MinGW - which is how I build my game client.

Does clang-cl ship with microsoft visual studio?

Yes, it's one of the install options. Same with git (which might be OK to have)

There's three bugs here. One is windows support, the other is failing to upload and a can't compile bug.
So I want to focus on the upload shared library here.
# For the other pr.
    - name: Install Dependencies (Windows)
      if: matrix.config.os == 'windows-latest'
      run: |
        choco upgrade ccache ninja

    - name: Setup MSVC (Windows)
      if: matrix.config.os == 'windows-latest'
      uses: ilammy/msvc-dev-cmd@v1


Update spec with the newly discussed design

Summary
References can be found in this issue and PR

applied the new spec design on the latest master branch code base


[SPARK-11973][SQL] Improve optimizer code readability.

This is a followup for https://github.com/apache/spark/pull/9959.
I added more documentation and rewrote some monadic code into simpler ifs.

cc @davies

Test build #46761 has started for PR 9995 at commit fe3a9a4.

Test build #46761 has finished for PR 9995 at commit fe3a9a4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46761/
Test FAILed.

Test build #46775 has started for PR 9995 at commit 95b2e0d.

Test build #46775 has finished for PR 9995 at commit 95b2e0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46775/
Test PASSed.

LGTM


add overflow rule to contain

right now scrolling the sidebar means hitting a 1px target. If the overflow is auto (and thus scrolling) you can scroll in there with your scroll wheel.

Your scroll wheel doesn't work for the sidebar? Mine certainly does, as well as trackpad scrolling, in Chrome on a Mac.

Well in Safari, for example this page doesn't act as a regular "overflow inside an overflow" would. I did notice that the style changed since I made this pull request, I'm not sure if the fix would still do it.  In Chrome I do get intended behaviour

Thanks - implemented a similar fix in ffdf4a6123b443f296fd22f8c1bf57720ac979ce which removes the fancy scrollbars entirely.

I assume this needs some time to work through all the pages? The link I posted last time still has the old way of sidebar?
Anyways, thanks for making this easier


Long Titles in Search Results Overflow in Full Text Search

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[X] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Longer Titles Overflow in Full Text Search Results in the Dendron Documentation

To Reproduce
Steps to reproduce the behavior:

Click the search bar in https://wiki.dendron.so/
Type"? 12 - I was stuck" in the search bar. Look at the first result.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
N/A
Desktop (please complete the following information)

Browser: edge

Additional context
N/A
Dendron Log file
N/A

thanks for the issue. we'll add this to our publishing backlog for this year