dynamic resolution with xrdp disconnects with new state machine

with current master/the new state machine /dynamic-resolution with xrdp does not work anymore.
the "first" connection works as expected, but as soon as a resolution change is triggered the connection gets dropped.
The relevant part of the log is the following
[09:27:12:717] [11214:11216] [DEBUG][com.freerdp.channels.disp.client] - disp_send_display_control_monitor_layout_pdu: NumMonitors=1
[09:27:12:717] [11214:11216] [DEBUG][com.freerdp.channels.disp.client] -        0 : Flags: 0x00000001 Left/Top: (0,0) W/H=1920x1006)
[09:27:12:717] [11214:11216] [DEBUG][com.freerdp.channels.disp.client] -           PhysicalWidth: 650 PhysicalHeight: 340 Orientation: 0
[09:27:13:370] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:370] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1024x768, desktop: 1024x768
[09:27:13:370] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:764] [11214:11231] [DEBUG][com.freerdp.channels.drdynvc.client] - process_close_request: Sp=0 cbChId=0, ChannelId=1
[09:27:13:764] [11214:11231] [DEBUG][com.freerdp.channels.drdynvc.client] - sending close confirm for 'Microsoft::Windows::RDS::Graphics'
[09:27:13:764] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:764] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1024x768, desktop: 1024x768
[09:27:13:764] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1024x768, desktop: 1024x768
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1024x768, desktop: 1024x768
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1024x768, desktop: 1024x768
[09:27:13:766] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_ACTIVE] received flag FINALIZE_DEACTIVATE_REACTIVATE| [0x0200]
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_ACTIVE --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE --> CONNECTION_STATE_FINALIZATION_SYNC
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_SYNC] reset finalize_sc_pdus
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x1f size=37 channelId=1008)
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_SYNC --> CONNECTION_STATE_FINALIZATION_COOPERATE
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_COOPERATE] reset finalize_sc_pdus
[09:27:13:815] [11214:11216] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_COOPERATE --> CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL] reset finalize_sc_pdus
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL --> CONNECTION_STATE_FINALIZATION_FONT_LIST
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_FONT_LIST] reset finalize_sc_pdus
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.rdp] - rd[09:27:13:819] [11214:11216] [ERROR][com.freerdp.core.rdp] - rdp_recv_callback_int: CONNECTION_STATE_FINALIZATION_CLIENT_SYNC status STATE_RUN_FAILED [-1]
[09:27:13:819] [11214:11216] [ERROR][com.freerdp.core.transport] - transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED [-1]
[09:27:13:819] [11214:11216] [ERROR][com.freerdp.core] - freerdp_abort_connect_context:freerdp_set_last_error_ex ERRCONNECT_CONNECT_CANCELLED [0x0002000B]
p_send_data_pdu: sending data (type=0x27 size=41 channelId=1008)
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_FONT_LIST --> CONNECTION_STATE_FINALIZATION_CLIENT_SYNC
[09:27:13:816] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_event_ConfigureNotify: x=1920, y=29, w=1920, h=1007
[09:27:13:817] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390025cf0
[09:27:13:817] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[09:27:13:817] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_New: 0x7f8390029220
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Free: 0x7f83910e4240
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f8390029220
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: cursorIndex -1 scaling pointer 32x32 --> 32x32 [1,000000x1,000000]
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.core.rdp] - transport_check_fds() - -1
[09:27:13:819] [11214:11216] [DEBUG][com.freerdp.core] - rdp_check_fds() - -1
[09:27:13:819] [11214:11216] [INFO][com.freerdp.client.common] - Network disconnect!

(btw, it is the client that disconnects the connection. I think this is to be expected since it transitions to STATE_RUN_FAILED)
Comparing with windows 11 the state machine does not seem to kick in (FINALIZE_DEACTIVATE_REACTIVATE is not triggered)
I don't know if xrdp is wrong here, but it works with microsoft's android and ios clients.
note that the STATE_RUN_FAILED is "in the middle" of the log output, so it probably comes from another thread. My first guess is that there is a race issue

@akarl10 could you please state which version you are using?
there have been similar reports, but for example https://github.com/FreeRDP/FreeRDP/pull/8410 have addressed a few problems already.

the version I used is current master (1304af47480295707ce93ab8c445eccd4cf7b6bd)

@akarl10 thank you. could you also please post a full log? I assume the issue is a bug in xrdp resolution change state transitions (that were not detected by previous lax state checks in freerdp)

xrdp.log
xfreerdp - full-log.txt
it could be that the issue is on xrdp's side, but as said, microsoft's clients seem to work..

@akarl10 your log is missing all stderr messages.
as for mstsc works, yes, may be but we are currently locking down protocol violations and possible workarounds get added later on. (master is development after all)

@akarl10 I´ve created https://github.com/FreeRDP/FreeRDP/pull/8459 to add some more logging for this specific error.

I have some issue multiplexing both in one file..
but the relevant information you want is
[10:33:45:667] [18099:18100] [ERROR][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] expected FINALIZE_SC_SYNCHRONIZE_PDU|FINALIZE_SC_CONTROL_COOPERATE_PDU|FINALIZE_SC_CONTROL_GRANTED_PDU|FINALIZE_SC_FONT_MAP_PDU| [0x000f], got FINALIZE_DEACTIVATE_REACTIVATE| [0x0200]
full-log-stderr.txt
full-log-stdout.txt

@akarl10 your log is missing all stderr messages. as for mstsc works, yes, may be but we are currently locking down protocol violations and possible workarounds get added later on. (master is development after all)

That is fine for me. I don't expect master to be bug free, but if nobody checks for possible regressions this might have an effect on stable releases. If this is really a regression or a plain bug on the other end is something I am not able to tell as I did not study the protocol details.
If you prefer that issues with master are discussed on the matrix channel that would also be fine for me.

@akarl10 regarding xrdp, you are using normal ubuntu setup? I think it will be best to test this against a vm with similar versions

hmm, I currently use a developement branch. but since xrdp 0.9.19 already had dynamic resolution I expected this to be "stable".
Now I see that on the branch I am, yesterday there was a push with "Resolution switching without reconnecting" in the title.
I will try to update to that and report back..
btw the setup is this one: https://github.com/neutrinolabs/xrdp/discussions/2383

I see you changed the log output..
now I get [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] expected change, started with NO_FLAG_SET| [0x0000], got NO_FLAG_SET| [0x0000]
If I "skip" if uflags == 0 (just to get past the error and see what happens) I get
[14:16:09:913] [115525:115526] [DEBUG][com.freerdp.channels.disp.client] - disp_send_display_control_monitor_layout_pdu: NumMonitors=1
[14:16:09:913] [115525:115526] [DEBUG][com.freerdp.channels.disp.client] -      0 : Flags: 0x00000001 Left/Top: (0,0) W/H=1920x1006)
[14:16:09:913] [115525:115526] [DEBUG][com.freerdp.channels.disp.client] -         PhysicalWidth: 650 PhysicalHeight: 340 Orientation: 0
[14:16:10:926] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - process_close_request: Sp=0 cbChId=0, ChannelId=1
[14:16:10:926] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - sending close confirm for 'Microsoft::Windows::RDS::Graphics'
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_ACTIVE] received flag FINALIZE_DEACTIVATE_REACTIVATE| [0x0200]
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_ACTIVE --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE --> CONNECTION_STATE_FINALIZATION_SYNC
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_SYNC] reset finalize_sc_pdus
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x1f size=37 channelId=1008)
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_SYNC --> CONNECTION_STATE_FINALIZATION_COOPERATE
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_COOPERATE] reset finalize_sc_pdus
[14:16:10:953] [115525:115526] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_COOPERATE --> CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL] reset finalize_sc_pdus
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL --> CONNECTION_STATE_FINALIZATION_FONT_LIST
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_FONT_LIST] reset finalize_sc_pdus
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x27 size=41 channelId=1008)
[14:16:10:954] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_FONT_LIST --> CONNECTION_STATE_FINALIZATION_CLIENT_SYNC
[14:16:10:956] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_event_ConfigureNotify: x=0, y=29, w=1920, h=1007
[14:16:10:956] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f66613cc810
[14:16:10:956] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[14:16:10:956] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_New: 0x7f6660027dd0
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Free: 0x7f66613c8e20
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f6660027dd0
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: cursorIndex -1 scaling pointer 32x32 --> 32x32 [1,000000x1,000000]
[14:16:10:959] [115525:115526] [ERROR][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] expected change, started with NO_FLAG_SET| [0x0000], got NO_FLAG_SET| [0x0000]
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_New: 0x7f666002abf0
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Free: 0x7f66613cc810
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f666002abf0
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[14:16:10:959] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: cursorIndex -1 scaling pointer 32x32 --> 32x32 [1,000000x1,000000]
[14:16:10:960] [115525:115526] [ERROR][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] expected change, started with NO_FLAG_SET| [0x0000], got NO_FLAG_SET| [0x0000]
[14:16:10:960] [115525:115526] [ERROR][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] expected change, started with NO_FLAG_SET| [0x0000], got NO_FLAG_SET| [0x0000]
[14:16:10:960] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - process_create_request: ChannelId=1 ChannelName=Microsoft::Windows::RDS::Graphics
[14:16:10:960] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - listener Microsoft::Windows::RDS::Graphics created new channel 1
[14:16:10:963] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - channel created
[14:16:10:963] [115525:115553] [DEBUG][com.freerdp.channels.drdynvc.client] - open_channel: ChannelId 1
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - recv Synchronize Data PDU (0x1F), length: 22
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] received flag FINALIZE_SC_SYNCHRONIZE_PDU| [0x0001]
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_SYNC --> CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - recv Control Data PDU (0x14), length: 26
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE] received flag FINALIZE_SC_CONTROL_COOPERATE_PDU| [0x0002]
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE --> CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - recv Control Data PDU (0x14), length: 26
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL] received flag FINALIZE_SC_CONTROL_GRANTED_PDU| [0x0004]
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL --> CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - recv Font Map Data PDU (0x28), length: 26
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP] received flag FINALIZE_SC_FONT_MAP_PDU| [0x0008]
[14:16:10:971] [115525:115526] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP --> CONNECTION_STATE_ACTIVE
[14:16:10:015] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_event_ConfigureNotify: x=0, y=29, w=1920, h=1007
[14:16:10:015] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_Set: 0x7f666002abf0
[14:16:10:015] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: scaled: 1920x1006, desktop: 1920x1006
[14:16:10:015] [115525:115526] [DEBUG][com.freerdp.client.x11] - xf_Pointer_GetCursorForCurrentScale: using cached cursor 0

I updated "my" xrdp branch, but still get the same. Currently I don't have my gpg key so I cannot upload an updated package, but it seems to behave the same way.

@akallabeth now I updated the ppa. Still behaves the same way (that is ignoring the "NO FLAG" state works around the issue). What I don't understand where this comes from/what PDU's arrive that trigger this expected state change. As soon as the Synchronize Data PDU (0x1F), length: 22 arrives it continues as normal

checking the flow with wireshark I see the following (maybe you understand what's wrong/what xrdp should change)
server -> client: close request (Microsoft::Windows::RDS::Graphics)
client -> server: close request (Microsoft::Windows::RDS::Graphics)
server -> client: Deactivate All PDU
server -> client: Demand Active PDU
client -> server: Confirm Active PDU
client -> server: RDP PDU Type Syncronize
client -> server: RDP PDU Type Control, Action: Cooperate
client -> server: RDP PDU Type Control, Action: Request control
client -> server: RDP PDU Type FontList
server -> client: Fast-Path PDU
server -> client: Fast-Path PDU
server -> client: ChannelCreate Request (Microsoft::Windows::RDS::Graphics)
client -> server: ChannelCreate Response (Microsoft::Windows::RDS::Graphics)

without the workaround mentioned the connection drops when receiving the fast-path PDU after FontList

@akarl10 see MS-RDPBCGR <IP_ADDRESS> Connection Sequence
the reactivation sequence is a bit different from the initial connection sequence.

@akarl10 if the log you posted is correct, xrdp does not send the server -> client messages of the Connection Finalization sequence

@akallabeth I have cut the log.. sorry.  after the channelCreate Request there is
server -> client: RDP PDU Type Syncronize
server -> client: RDP PDU Type Control, Action: Cooperate
server -> client: RDP PDU Type Control, Action: Request control

I am not a xrdp developer so I don't know the details (and reading the whole MS-RDPBCGR is a bit too much for me now 😕), but they have a check_for_app_input flag that gets unset when a Deactivation-Reactivation Sequence is running.
    /* shut down the rdp client
     *
     * When resetting the lib, disable application input checks, as
     * otherwise we can send a channel message to the other end while
     * the channels are inactive ([MS-RDPBCGR] <IP_ADDRESS>.1 */
    session->check_for_app_input = 0;
    if (xrdp_rdp_send_deactivate((struct xrdp_rdp *)session->rdp) != 0)
    {
        LOG(LOG_LEVEL_ERROR, "libxrdp_reset: xrdp_rdp_send_deactivate failed");
        return 1;
    }

    /* this should do the resizing */
    if (xrdp_caps_send_demand_active((struct xrdp_rdp *)session->rdp) != 0)
    {
        LOG(LOG_LEVEL_ERROR, "libxrdp_reset: xrdp_caps_send_demand_active failed");
        return 1;
    }

    /* Re-enable application input checks */
    session->check_for_app_input = 1;

the issue might be that xorgxrdp triggers cursor/pointer updates immediatly after the resize before the end of the re-enable sequence. A quick check might be to skip this updates when this flag is set. If that fixes the issue I will open a issue on there side since I am not able to figure out how to remember the missed events and send them after the resize.

@akarl10 yes, sending anything else before the sequence is complete is not allowed.
as for the server -> client messages, the server -> client: RDP PDU Type Control, Action: Request control is that just a buggy log message? because it should be a Granted control type message

yes, it was a typo.

I suspected the same after I noticed the fastpath PDU's inbetween (Although I did not understand the details..)
Does that mean that the virtual channel for the display must also be after the PDU's I was missing in the log above?

@akarl10 looks like we also need some fine adjustment in FreeRDP:
Once the client has sent the Confirm Active PDU, it can start sending mouse and keyboard input to
the server, and upon receipt of the Font List PDU the server can start sending graphics output to
the client.

what is in this case is however that the server sends a fastpath pointer update after confirm active. I don't really read that that is allowed. I also don't read anything about channel creation (only graphics update, it could still be allowed to create the channel but send updates after the Font List PDU)

@akarl10 yes, that is not correctly handled.
but from the above description it means that a conforming client might send input PDU mixed with any synchronize/control/font pdu that the client must send to the server and on the other side a server might send graphics pdu (or channel stuff for that matter) before responding to any of the synchronize/control/font PDU.
so, while our handling is not perfect (we assume that the client or server sends the synchronize/control/font PDU before anything else), the one of xrdp is definitely broken with regard to the RDP state machine

ah ok, when I first read the statement about what when I took the server->client FontList PDU, but rereading upon receipt would not make any sense and, as you say, the "reference" PDU is the client->server one
If interpreted in that way, even tough xrdp is not perfect, it should work without patching xrdp since the currently offending packets/PDU's are sent after client -> server: RDP PDU Type FontList

@akarl10 ok, I will check tomorrow, then I´ll have access to some more hardware to properly test that.

I'm wondering if I'm not hitting the same kind of bug with the proxy.

hmm, with current master (a5d9c3b8464174e80cfa28ceeb55df4302087c16) now it is even impossible to connect to xrdp
[07:50:23:046] [16063:16063] [DEBUG][com.freerdp.client.common] - This is 3.0.0-dev Build configuration: BUILD_TESTING=OFF HAVE_AIO_H=1 HAVE_EXECINFO_BACKTRACE=1 HAVE_EXECINFO_BACKTRACE_SYMBOLS=1 HAVE_EXECINFO_BACKTRACE_SYMBOLS_FD=1 HAVE_EXECINFO_H=1 HAVE_EXECINFO_HEADER=1 HAVE_FCNTL_H=1 HAVE_GETLOGIN_R=1 HAVE_GETPWUID_R=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_PIXMAN_REGION=OFF HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_STDBOOL_H=1 HAVE_STDINT_H=1 HAVE_STRNDUP=1 HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_UNWIND_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ADD_PLUGIN_TO_RPATH=OFF WITH_ALSA=ON WITH_CAIRO=OFF WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_EVENTS=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_URBDRC=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=OFF WITH_DSP_FFMPEG_AVAILABLE=1 WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=ON WITH_FAAD2=ON WITH_FFMPEG=ON WITH_FREERDP_DEPRECATED=OFF WITH_FREERDP_DEPRECATED_COMMANDLINE=OFF WITH_FUSE=ON WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=On WITH_GSS_NO_NTLM_FALLBACK=OFF WITH_ICU=OFF WITH_INTERNAL_MD4=OFF WITH_INTERNAL_MD5=OFF WITH_IPP=OFF WITH_JPEG=OFF WITH_LAME=ON WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_NATIVE_SSPI=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=OFF WITH_PCSC=ON WITH_PKCS11=OFF WITH_POLL=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=OFF WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_EMULATE=OFF WITH_SMARTCARD_INSPECT=OFF WITH_SMARTCARD_PCSC=ON WITH_SOXR=OFF WITH_SPNEGO=On WITH_SSE2=ON WITH_SWSCALE=ON WITH_THIRD_PARTY=OFF WITH_VAAPI=OFF WITH_VAAPI_AVAILABLE=1 WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_VERBOSE_WINPR_ASSERT=ON WITH_VIDEO_FFMPEG=ON WITH_VIDEO_FFMPEG_AVAILABLE=1 WITH_WAYLAND=ON WITH_WINPR_DEPRECATED=OFF WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:               -fPIC -Wall -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -fno-omit-frame-pointer
Compiler:            GNU, 12.2.0
Target architecture: x64

[07:50:23:046] [16063:16064] [DEBUG][com.freerdp.core] - freerdp_connect_begin:freerdp_set_last_error_ex resetting error state
[07:50:23:803] [16063:16064] [DEBUG][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[07:50:23:803] [16063:16064] [DEBUG][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[07:50:23:803] [16063:16064] [DEBUG][com.freerdp.channels.cliprdr.client] - VirtualChannelEntryEx
[07:50:23:803] [16063:16064] [DEBUG][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[07:50:23:804] [16063:16064] [DEBUG][com.freerdp.channels.drdynvc.client] - VirtualChannelEntryEx
[07:50:23:804] [16063:16064] [DEBUG][com.freerdp.client.common.cmdline] - loading channelEx drdynvc
[07:50:23:810] [16063:16064] [DEBUG][com.freerdp.primitives] - primitives benchmark result:
[07:50:24:968] [16063:16064] [DEBUG][com.freerdp.primitives] -  * generic= 41
[07:50:24:120] [16063:16064] [DEBUG][com.freerdp.primitives] -  * optimized= 102
[07:50:24:120] [16063:16064] [DEBUG][com.freerdp.primitives] - primitives autodetect, using optimized
[07:50:24:139] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling security layer negotiation: TRUE
[07:50:24:144] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling restricted admin mode: FALSE
[07:50:24:144] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling RDP security: TRUE
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling TLS security: TRUE
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling NLA security: TRUE
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.nego] - Enabling NLA extended security: FALSE
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_INITIAL --> CONNECTION_STATE_NEGO
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_NLA
[07:50:24:145] [16063:16064] [DEBUG][com.freerdp.core.nego] - Attempting NLA security
[07:50:24:147] [16063:16064] [DEBUG][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[07:50:24:149] [16063:16064] [DEBUG][com.freerdp.core] - freerdp_tcp_default_connect:freerdp_set_last_error_ex resetting error state
[07:50:24:149] [16063:16064] [DEBUG][com.freerdp.core] - connecting to peer .....
[07:50:24:150] [16063:16064] [DEBUG][com.freerdp.core.nego] - RequestedProtocols: 3
[07:50:24:162] [16063:16064] [DEBUG][com.freerdp.core.nego] - RDP_NEG_RSP::flags = { [0x01] |EXTENDED_CLIENT_DATA_SUPPORTED }
[07:50:24:162] [16063:16064] [DEBUG][com.freerdp.core.nego] - selected_protocol: 1
[07:50:24:163] [16063:16064] [DEBUG][com.freerdp.core.nego] - state: NEGO_STATE_FINAL
[07:50:24:163] [16063:16064] [DEBUG][com.freerdp.core.nego] - Negotiated TLS security
[07:50:24:163] [16063:16064] [DEBUG][com.freerdp.core.nego] - nego_security_connect with PROTOCOL_SSL
Password:
[07:50:26:005] [16063:16064] [WARN][com.freerdp.crypto] - Certificate verification failure 'certificate has expired (10)' at stack position 0
[07:50:26:005] [16063:16064] [WARN][com.freerdp.crypto] - C .....
[07:50:26:006] [16063:16064] [DEBUG][com.freerdp.crypto] - known_hosts=1
[07:50:26:011] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_NEGO --> CONNECTION_STATE_MCS_CREATE_REQUEST
[07:50:26:011] [16063:16064] [DEBUG][com.freerdp.core.gcc] - Sending highColorDepth=0x0018, supportedColorDepths=0x000f, earlyCapabilityFlags=RNS_UD_CS_WANT_32BPP_SESSION|RNS_UD_CS_VALID_CONNECTION_TYPE|RNS_UD_CS_SUPPORT_NETCHAR_AUTODETECT|RNS_UD_CS_SUPPORT_DYNVC_GFX_PROTOCOL|RNS_UD_CS_SUPPORT_HEARTBEAT_PDU| [0x05a2]
[07:50:26:011] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CREATE_REQUEST --> CONNECTION_STATE_MCS_CREATE_RESPONSE
[07:50:26:018] [16063:16064] [DEBUG][com.freerdp.core.gcc] - Server rdp encryption method: NONE
[07:50:26:018] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CREATE_RESPONSE --> CONNECTION_STATE_MCS_ERECT_DOMAIN
[07:50:26:018] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_ERECT_DOMAIN --> CONNECTION_STATE_MCS_ATTACH_USER
[07:50:26:018] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_ATTACH_USER --> CONNECTION_STATE_MCS_ATTACH_USER_CONFIRM
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_ATTACH_USER_CONFIRM --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:019] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST
[07:50:26:020] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_REQUEST --> CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE
[07:50:26:021] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_MCS_CHANNEL_JOIN_RESPONSE --> CONNECTION_STATE_SECURE_SETTINGS_EXCHANGE
[07:50:26:021] [16063:16064] [DEBUG][com.freerdp.core.info] - Client Info Packet Flags = INFO_MOUSE|INFO_DISABLECTRLALTDEL|INFO_AUTOLOGON|INFO_UNICODE|INFO_MAXIMIZESHELL|INFO_LOGONNOTIFY|INFO_COMPRESSION|INFO_ENABLEWINDOWSKEY|INFO_FORCE_ENCRYPTED_CS_PDU|INFO_LOGONERRORS|INFO_MOUSE_HAS_WHEEL|INFO_NOAUDIOPLAYBACK
[07:50:26:021] [16063:16064] [DEBUG][com.winpr.timezone] - winpr_get_unix_timezone_identifier_from_file: tzid: Europe/Rome
[07:50:26:021] [16063:16064] [DEBUG][com.winpr.timezone] - winpr_get_timezone_from_link: tzid: Europe/Rome
[07:50:26:021] [16063:16064] [INFO][com.winpr.timezone] - tzid: Europe/Rome
[07:50:26:021] [16063:16064] [DEBUG][com.winpr.timezone] - tz: Bias=-60 sn='W. Europe Standard Time' dln='W. Europe Daylight Time'
[07:50:26:021] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_SECURE_SETTINGS_EXCHANGE --> CONNECTION_STATE_CONNECT_TIME_AUTO_DETECT_REQUEST
[07:50:26:026] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CONNECT_TIME_AUTO_DETECT_REQUEST --> CONNECTION_STATE_LICENSING
[07:50:26:026] [16063:16064] [ERROR][com.freerdp.core.license] - license binary blob::type expected BB_UNKNOWN, got BB_ERROR_BLOB
[07:50:26:026] [16063:16064] [WARN][com.freerdp.core.license] - license binary blob::type BB_ERROR_BLOB, length=0, skipping.
[07:50:26:026] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_LICENSING --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_DEMAND_ACTIVE --> CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_CAPABILITIES_EXCHANGE_CONFIRM_ACTIVE --> CONNECTION_STATE_FINALIZATION_SYNC
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_SYNC] reset finalize_sc_pdus
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x1f size=37 channelId=1008)
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_SYNC --> CONNECTION_STATE_FINALIZATION_COOPERATE
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_COOPERATE] reset finalize_sc_pdus
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_COOPERATE --> CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL] reset finalize_sc_pdus
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x14 size=41 channelId=1008)
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_REQUEST_CONTROL --> CONNECTION_STATE_FINALIZATION_FONT_LIST
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_FONT_LIST] reset finalize_sc_pdus
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.rdp] - rdp_send_data_pdu: sending data (type=0x27 size=41 channelId=1008)
[07:50:26:027] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_FONT_LIST --> CONNECTION_STATE_FINALIZATION_CLIENT_SYNC
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - recv Synchronize Data PDU (0x1F), length: 22
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_SYNC] received flag FINALIZE_SC_SYNCHRONIZE_PDU| [0x0001]
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_SYNC --> CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - recv Control Data PDU (0x14), length: 26
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE] received flag FINALIZE_SC_CONTROL_COOPERATE_PDU| [0x0002]
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_COOPERATE --> CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - recv Control Data PDU (0x14), length: 26
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL] received flag FINALIZE_SC_CONTROL_GRANTED_PDU| [0x0004]
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_GRANTED_CONTROL --> CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - recv Font Map Data PDU (0x28), length: 26
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP] received flag FINALIZE_SC_FONT_MAP_PDU| [0x0008]
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_FINALIZATION_CLIENT_FONT_MAP --> CONNECTION_STATE_ACTIVE
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - rdp_recv_callback_int: CONNECTION_STATE_ACTIVE - rdp_recv_pdu() - STATE_RUN_FAILED [-1]
[07:50:26:030] [16063:16064] [ERROR][com.freerdp.core.rdp] - rdp_recv_callback_int: CONNECTION_STATE_ACTIVE status STATE_RUN_FAILED [-1]
[07:50:26:030] [16063:16064] [ERROR][com.freerdp.core.transport] - transport_check_fds: transport->ReceiveCallback() - STATE_RUN_FAILED [-1]
[07:50:26:030] [16063:16064] [DEBUG][com.freerdp.core.rdp] - transport_check_fds() - -1
[07:50:26:030] [16063:16064] [ERROR][com.freerdp.core] - rdp_client_connect:freerdp_set_last_error_ex ERRCONNECT_CONNECT_TRANSPORT_FAILED [0x0002000D]
[07:50:26:031] [16063:16064] [DEBUG][com.freerdp.core.rdp] - [CONNECTION_STATE_ACTIVE] reset finalize_sc_pdus
[07:50:26:031] [16063:16064] [DEBUG][com.freerdp.core.connection] - rdp_client_transition_to_state CONNECTION_STATE_ACTIVE --> CONNECTION_STATE_INITIAL

@akarl10 yes, that was a tricky one. Fixed in https://github.com/FreeRDP/FreeRDP/pull/8468
have a test setup available today, so I´ll do a few tests to find out if that is sufficient.

@akarl10 ok, tested against ubuntu 22.04 with your ppa
it works now, only a few log messages are shown as the expected finalize flags are sent later


fix CheckPermissionRequest schema in caveats.md

The CheckPermissionRequest example is incorrect — rather than specifying the Relation field, the example should specify the Permission field.

I have read the CLA Document and I hereby sign the CLA

recheck


Canvas is a directive, consider rewriting it as a component

Consider rewriting the canvas directive as a component.
From slack:

dana [6:27 AM]
Canvas is actually a directive internally - it has a link function and binds to several document listeners

@jeff-phillips-18 I chatted with @dgutride briefly on this issue. Curious if you have any thoughts on the sentiment above?

Should be an easy fix.

there are a couple of other directives that ought be components as well
https://github.com/patternfly/angular-patternfly/blob/master/src/canvas-view/canvas-editor/toolbox-items.directive.js
https://github.com/patternfly/angular-patternfly/blob/master/src/canvas-view/canvas/node-toolbar.directive.js

Hi, the pfCanvas and pfCanvasEditor are rather complex directives which use a MVVM pattern.  The code was originally ported from a "SVG and AngularJS Flowchart" article.  Read this for some background information and architectural decisions.

Thanks for the background info @dtaylor113. The pfCanvas is definitely more complex than I originally thought when I started the conversion process. Myself and @cliffpyles @TheRealJon were going to try to tackle it, is this something that we really want to convert to a component or should we hold off?

Hi, just spoke to @dgutride about the history behind this "ask".  I think this issue was filed just because, in general, we should stay away from using directives as they are not supported in Angular 2+ (nor $scope, $broadcast, $emit, etc...).   I don't believe any team has specifically asked for the pfCanvas to be converted.  IMO converting this probably doesn't buy us much.  I certainly wouldn't pick up this work as a way to 'dive into angular-patternfly'.  -thanks :-)

I agree @dtaylor113

@jeff-phillips-18 and I agree that converting it to a component would be 'real nice' :-) and would allow us to eventually port it to angular-patternfly-ng.   I think a good start would be to see if you could convert it to a component and use the new bindings and replace/move the post-link directive methods to perhaps $postLink.   I know the canvas directives use a lot of $scope and $broadcast/$emit to communicate between themselves.  I would suggest leaving $scope in for now and just concentrate on doing the bare minimum to convert them to components  -if you decide you want to take this work on.   :-)  Thanks!


modified YamlExpressionParser processResult to not throw exception w…

…hen there is more than one result
The reusable method should not have constraint around size > 1. Instead move the constraint to methods that need it

There are too many changes in this pull request, please update the .gitignore file accordingly.
Also, I don't see any new tests that prove the issue that it's meant to be fixed here. Let's discuss it in https://github.com/yaml-path/YamlPath/issues/120#issuecomment-1647217907.


Added underscore entry_point for babel.extractors

Registered the underscore entry_point, as described in the Babel documentation.

I'm soooo sorry, I didn't see this pull request. Thanks a lot @singingwolfboy :cake: :beers: :bow:


Design MDroid2 Project to properly separate Features

We're in the beginning of the MDroid2 App development. The few features we already developed but do not have a Database:

Iqama Notification on Discord
Automated Recordings for Lessons
Discord Commands for Starting/Stopping/Monitoring Recordings
Youtube Uploader

Those were developed in Golang, but for adoptability and ease of Maintainability I believe we should rewrite them in Python (Using Django)
A Design Documentation and a proper File Structure will be required to close this Ticket.

This is too big of an issue (lol) I will close and we can take care of this separately.


Lspsaga Rename doesn't work

Describe the bug
Hi, When I typed "Lspsaga rename". This errors occurs, idk why, can you help me please ?
this is my very light saga setup from lazy.nvim
{
		"glepnir/lspsaga.nvim",
		event = "BufRead",
		dependencies = { "kyazdani42/nvim-web-devicons" },
		config = function()
			require("lspsaga").setup({
			      ui = {
                                      theme = "round",
                                      title = true,
                                      border = "solid",
                                      winblend = 0,
                              },
                              rename = {
                                  quit = "<C-c>",
                                  exec = "<CR>",
                                  mark = "x",
                                  confirm = "<CR>",
                                  in_select = true,
                                },
                             })
		end
}

**Error executing Lua callback: vim/keymap.lua:0: lhs: expected string, got table** stack traceback:         [C]: in function 'error'         vim/shared.lua: in function 'validate'         vim/keymap.lua: in function 'set'         ...ocal/share/nvim/lazy/lspsaga.nvim/lua/lspsaga/rename.lua:36: in function 'apply_action_keys'         ...ocal/share/nvim/lazy/lspsaga.nvim/lua/lspsaga/rename.lua:189: in function 'lsp_rename'         ...cal/share/nvim/lazy/lspsaga.nvim/lua/lspsaga/command.lua:14: in function <...cal/share/nvim/lazy/lspsaga.nvim/lua/lspsaga/command.lua:13>         ...cal/share/nvim/lazy/lspsaga.nvim/lua/lspsaga/command.lua:60: in function 'load_command'         ...l/.local/share/nvim/lazy/lspsaga.nvim/plugin/lspsaga.lua:8: in function <...l/.local/share/nvim/lazy/lspsaga.nvim/plugin/lspsaga.lua:7> **Press ENTER or type command to continue**
Steps to reproduce
I hovered my cursor into one variable, then I press "gr" which set to **Lspsaga rename**, then this error occurred, then I tried by using the command line instead of my custom binding gr, but the same error still occurred.
Expected behavior
This should work as the demo hemmp, what did I do wrong ??
Neovim version (nvim -v)
Nightly
lspsaga commit
Idk, I follow the main branch
Terminal name/version
Kitty

wired i can't reproduce with a min config

something wrong in your local . need clean your local. looks like have other config ?

the error message
Error executing Lua callback: vim/keymap.lua:0: lhs: expected string, got table

mean there has a table as key passed into the vim.keymap.set in rename apply_action_keys function. please try the min config .should some wrong in you local


HSEARCH-2642 Automatic translation of TypeTokenFilterFactory to Elasticsearch turns blacklists to whitelists

https://hibernate.atlassian.net/browse/HSEARCH-2642

merged. Thanks!


Flutter for Desktop [Windows] : Exception: Unable to generate build files

My Flutter setup is complete and working fine for Android and Web
But when I try to build for windows it generates
'Exception: Unable to generate build files'
Logs

Flutter Doctor

You'll need to provide the output (as text, not screenshots of text) of building with the -v flag to see what the specific error is.

[√] Flutter (Channel beta, 2.2.2, on Microsoft Windows [Version 10.0.19042.1052], locale en-US)
• Flutter version 2.2.2 at C:\Users\User\FlutterSDK\flutter
• Framework revision d79295af24 (13 days ago), 2021-06-11 08:56:01 -0700
• Engine revision 91c9fc8fe0
• Dart version 2.13.3
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\User\AppData\Local\Android\Sdk
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = C:\Users\User\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.10.2)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.10.31410.357
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 47.1.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] VS Code (version 1.57.1)
• VS Code at C:\Users\User\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.23.0
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.1052]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.114
• Edge (web)        • edge    • web-javascript • Microsoft Edge 91.0.864.54

That's the verbose doctor output, not the verbose build output.

[  +74 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +449 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +2 ms] d79295af24c3ed621c33713ecda14ad196fd9c31
[   +1 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[  +65 ms] Exit code 0 from: git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[        ] 2.2.2
[   +6 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +34 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [C:\Users\User\FlutterSDK\flutter/] git ls-remote --get-url origin
[  +30 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +117 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git rev-parse --abbrev-ref HEAD
[  +34 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[ +101 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +70 ms] executing: C:\Users\User\AppData\Local\Android\Sdk\platform-tools\adb.exe devices -l
[  +45 ms] List of devices attached
[   +5 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[  +12 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +36 ms] "flutter run" took 224ms.
[  +18 ms] Target file "windows" not found.
[   +2 ms]
#0      FlutterCommand.validateCommand (package:flutter_tools/src/runner/flutter_command.dart:1322:9)
#1      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:448:19)
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1148:11)

#3      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1043:27)

#4      AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#5      CommandRunner.runCommand (package:args/command_runner.dart:196:13)

#6      FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)

#7      AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#8      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:232:5)

#9      run.. (package:flutter_tools/runner.dart:62:9)

#10     AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#11     main (package:flutter_tools/executable.dart:91:3)

[ +271 ms] ensureAnalyticsSent: 261ms
[   +6 ms] Running shutdown hooks
[   +2 ms] Shutdown hooks complete
[   +2 ms] exiting with code 1

What command did you run? That is not the same failure that you showed in your original report; it looks like your build command was malformed.

My bad the above error is produced using (flutter run -v windows)
With (flutter build -v windows)
There you go
[  +72 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +444 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +2 ms] d79295af24c3ed621c33713ecda14ad196fd9c31
[   +1 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[  +68 ms] Exit code 0 from: git tag --points-at d79295af24c3ed621c33713ecda14ad196fd9c31
[        ] 2.2.2
[   +6 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +38 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [C:\Users\User\FlutterSDK\flutter/] git ls-remote --get-url origin
[  +38 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +130 ms] executing: [C:\Users\User\FlutterSDK\flutter/] git rev-parse --abbrev-ref HEAD
[  +36 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[ +104 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +67 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +52 ms] Skipping pub get: version match.
[ +127 ms] Generating C:\Users\User\VS_Projects\flutter_application_windows\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +74 ms]  Building with sound null safety
[  +13 ms] executing: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -format json -products * -utf8 -latest -version 16 -requires Microsoft.VisualStudio.Workload.NativeDesktop
Microsoft.VisualStudio.Component.VC.Tools.x86.x64 Microsoft.VisualStudio.Component.VC.CMake.Project
[  +34 ms] Exit code 0 from: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe -format json -products * -utf8 -latest -version 16 -requires Microsoft.VisualStudio.Workload.NativeDesktop
Microsoft.VisualStudio.Component.VC.Tools.x86.x64 Microsoft.VisualStudio.Component.VC.CMake.Project
[   +1 ms] [
{
"instanceId": "796077dd",
"installDate": "2020-03-05T14:47:17Z",
"installationName": "VisualStudio/16.10.2+31410.357",
"installationPath": "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community",
"installationVersion": "16.10.31410.357",
"productId": "Microsoft.VisualStudio.Product.Community",
"productPath": "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\devenv.exe",
"state":<PHONE_NUMBER>,
"isComplete": true,
"isLaunchable": true,
"isPrerelease": false,
"isRebootRequired": false,
"displayName": "Visual Studio Community 2019",
"description": "Powerful IDE, free for students, open-source contributors, and individuals",
"channelId": "VisualStudio.16.Release",
"channelUri": "https://aka.ms/vs/16/release/channel",
"enginePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service",
"releaseNotes": "https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-v16.10#16.10.2",
"thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=660909",
"updateDate": "2021-06-22T20:36:29.4745279Z",
"catalog": {
"buildBranch": "d16.10",
"buildVersion": "16.10.31410.357",
"id": "VisualStudio/16.10.2+31410.357",
"localBuild": "build-lab",
"manifestName": "VisualStudio",
"manifestType": "installer",
"productDisplayVersion": "16.10.2",
"productLine": "Dev16",
"productLineVersion": "2019",
"productMilestone": "RTW",
"productMilestoneIsPreRelease": "False",
"productName": "Visual Studio",
"productPatchVersion": "2",
"productPreReleaseMilestoneSuffix": "1.0",
"productSemanticVersion": "16.10.2+31410.357",
"requiredEngineVersion": "2.10.2174.31177"
},
"properties": {
"campaignId": "Unity3d_Unity",
"channelManifestId": "VisualStudio.16.Release/16.10.2+31410.357",
"nickname": "",
"setupEngineFilePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installershell.exe"
}
}
]
[  +11 ms] Building Windows application...
[  +19 ms] executing: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -S C:\Users\User\VS_Projects\flutter_application_windows\windows -B
build\windows -G Visual Studio 16 2019
[  +40 ms] Building Windows application... (completed in 49ms)
[   +1 ms] "flutter windows" took 521ms.
[   +7 ms] Unable to generate build files
[   +2 ms]
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      _runCmakeGeneration (package:flutter_tools/src/windows/build_windows.dart:188:5)

#2      buildWindows (package:flutter_tools/src/windows/build_windows.dart:76:5)

#3      BuildWindowsCommand.runCommand (package:flutter_tools/src/commands/build_windows.dart:55:5)

#4      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1043:27)

#5      AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#6      CommandRunner.runCommand (package:args/command_runner.dart:196:13)

#7      FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)

#8      AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#9      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:232:5)

#10     run.. (package:flutter_tools/runner.dart:62:9)

#11     AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#12     main (package:flutter_tools/executable.dart:91:3)

[ +292 ms] ensureAnalyticsSent: 286ms
[   +2 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[   +3 ms] exiting with code 1

Odd, CMake appears to have returned a non-zero exit code but there's no output from it there.
Does running "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -S "C:\Users\User\VS_Projects\flutter_application_windows\windows" -B build\windows -G "Visual Studio 16 2019" directly give any output?

Thank you for pointing me to the right direction
The issue was with the installing of Microsoft Visual C++
vcruntime140_1.dll was not found when executing cmake.exe
Re-installing Microsoft Visual C++ 2015-2019 resolved the issue


Make Identifier field voluntary and fix the readme

This field is useful for those who care about unique ids. It should be easy to skip, though. And the way it's described in the readme doesn't make sense.

Yeah it's just a nickname or reference. Useful for some, I like being able to name my things so 😂
It was meant to be optional sure, I thought it defaulted to use the ip address if missing.

"XComfort Bridge" makes sense as a default.

Fixed this is the last build


SSH Tunnel for jobui failed to open in localhost

The ssh tunnel for port 4040 currently results in a connection refused error.

Made a workaround for this:

Root use of port 4040 was for access to the job ui and log files.

Workaround is to use the aztk spark cluster app-logs command within the CLI to obtain the logs for a job.

@audac1ty - This is actually part of the Spark Jobs UI design. If there are no jobs running, then the :4040 port doesn't render anything.
The way you worked around this is one of the two supported ways. The second way would be to enable the history server in your spark-defaults.conf. Set the history server log path to something local like file://tmp/spark-logs

Yeah that was assumed after some investigation on my part, resolved fairly easily after acknowledgement


install king-phisher template

Hello ,
can you tell me how to install King-phisher template from these repository
https://github.com/securestate/king-phisher-templates
sorry i mean where to place the landing pages on king phisher car on the wiki there isn't more details
give juste simple diescription of differente steps
Thank you

A template is essentially a landing page, what I told you in issue #87 applies here as well. Doesn't matter if it's a template from the templates repo or a cloned landing page, it goes into the web root. Look at your server's configuration for the web_root option, it's probably /var/www (the default).


DBZ-5962:Sink adapter for Apache RocketMQ

Add apache RocketMQ sink adapter for debezium server

Thanks a lot, this is a great start! I left couple of comments. Could you lease also squash all commits into a single one and make sure the commit message it is prefixed with DBZ-5962? Also what is your name so we can add you to the copyright list?

Thanks for the review. My name is  Xiaojian Sun ( @sunxiaojian )，I have made changes according to the suggestions given

@sunxiaojian Could you please squas all commits to a single one and expecially emove the merge commit? Thanks.


Can Canvas receive onKeyDown or onTextInput?

I'm trying to write a program which shows different bits of text at various coordinates in the window depending on what the user types into it. In some ways what I want to make is similar to a game - I need to draw things on the screen and receive keyboard events (and eventually mouse ones too). I've attempted to do this by making a Canvas with functions defined for onKeyDown/onTextInput, but they don't seem to get run. Am I doing anything wrong? Is there another way of doing this? Thanks.

have you found suitable solution?

Closing this issue as it seems to be abandoned.
Feel free to reopen if needed.


Bugfix/home page typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: amsalways sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Runtime error SYSTEM_NO_ROLL in background mode

Hello abapGit community,
I am encountering runtime error SYSTEM_NO_ROLL when executing the background mode. The memory is getting too full.
The background mode is initiated from method RUN of ZCL_ABAPGIT_BACKGROUND. It seems like each individual repository can be processed just fine. However, every instance of ZCL_ABAPGIT_REPO_ONLINE still remains in the session with a lot of data.
Here's an excerpt from the dominator tree after a few repositories have been processed:

Each instance still needs memory because the tables MT_LOCAL, MT_REMOTE and MT_OBJECTS remain filled. I think it would be a good idea to somehow "reset" / "clear" a repository instance after it has been processed.
Another cheap alternative could be to process each repository in a separate session using destination NONE.
What are your thoughts on this?

suggest adding a method in ZCL_ABAPGIT_REPO_SRV to clear the MT_LIST (take care of MV_INIT too?)

I'll try this and report back, thanks.

or alternatively try calling ZIF_ABAPGIT_REPO~REFRESH

@larshp, can you please re-open this issue? I'm getting the same error again, so some more optimizations are needed.
I suspect that MT_OBJECTS needs to be cleared as I mentioned in #6728, but I'll do some additional analysis first

@ConjuringCoffee just open another issue, with a link to this one, if its related


How to make multiple pins as input/output in one line?

I am just trying to declare multiple pins as inputs or outputs.  I am not exactly getting dedicated API for that. In my application I am using plenty of IO's and every time declare as to gpio_pad_select_gpio(pin number) and so on, I feel is unconventional method.
Is there any API or function through which I can pass Pin number and mode at a time !?
#include<stdio.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "driver/gpio.h"
#include "sdkconfig.h"

#define INPUT_GPIO_NO 34
unsigned int GPIOlevel;

void blink_task(void *pvParameter)
{
    gpio_pad_select_gpio(INPUT_GPIO_NO);
    gpio_pullup_dis(INPUT_GPIO_NO);
    gpio_set_direction(INPUT_GPIO_NO, GPIO_MODE_INPUT);

	while(1)
	{
        GPIOlevel = gpio_get_level(INPUT_GPIO_NO);
		if (GPIOlevel == 1)
		{
			printf("GPIO Level is HIGH !!!\n");
		}
		else
        {
			printf("GPIO Level is LOW \n");
        }
		vTaskDelay(100 / portTICK_PERIOD_MS);
	}
}

void app_main()
{
    xTaskCreate(&blink_task, "blink_task", configMINIMAL_STACK_SIZE, NULL, 5, NULL);
}

gpio_config

You can use gpio_config_t and use bit mask. Checkout Gpio example code in esp-idf here: https://github.com/espressif/esp-idf/blob/master/examples/peripherals/gpio/main/gpio_example_main.c

Hi @sjoteppagol, did the above suggestion help you resolve the issue?

Here is simple example, lets assume we have 2 inputs BUTTON1 and BUTTON2 connected to Pin no 32 and 35. We have 2 output's LED1 and LED2 connected to pin 5 and 25 respectively.
My question is instead of initializing these pins separately as shown in gpio_init(), is there any API through which I can pass pin and mode as a parameters and initialize all pins in one line.
#define BUTTON1 GPIO_NUM_32
#define BUTTON2 GPIO_NUM_35
#define LED1 GPIO_NUM_5
#define LED2 GPIO_NUM_25
void gpio_init()
{
   gpio_pad_select_gpio(BUTTON1);
   gpio_set_direction(BUTTON1, GPIO_MODE_INPUT);
   gpio_pad_select_gpio(BUTTON2);
   gpio_set_direction(BUTTON2, GPIO_MODE_INPUT);

   gpio_pad_select_gpio(LED1);
   gpio_set_direction(LED1, GPIO_MODE_OUTPUT);
   gpio_pad_select_gpio(LED2 );
   gpio_set_direction(LED2 , GPIO_MODE_OUTPUT);
}

Hi sjoteppagol, I understand you close this issue now, but have you find a way to perform multiple gpio initialisation, or one after another.


Enable changelogs via lerna

Ello'! 👋
So lerna still handles changelog stuff internally, which is gggreat. The changes in this PR haven't been tested, and are instead a kickstart for you to get across the things necessary to automatically create changelogs for Radix. It's well worth getting across IMO - let me know if you're holding off on this kind of stuff though.
I've also updated the top-level readme so that folks in the team know how to release new versions without realtime-handholding.

Notes

Options passed to lerna publish are also passed to lerna version
The --github-release is pretty cool, but I personally have never used it... keen to try?
I've removed the postinstall hooks because it was slowing down my local dev
I've added prepublishOnly hooks to radix and radix-icons so that yarn release will fer-sure have latest dists

Will re-visit in the future.


feat: support blockscout in cast etherscan-source

Component
Cast
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (f7a535d 2023-04-03T00:04:12.007857053Z)
What command(s) is the bug in?
cast etherscan-source
Operating System
Linux
Describe the bug
As i understand https://github.com/gakonst/ethers-rs/blob/master/ethers-etherscan/src/contract.rs#L378 does a simple get call to a "etherscan like api".
Blockscout seems to follow that exact api:

So i think the command should probably be agnostic e.g. cast source and support a --api-url parameter or source the api from toml (not sure how reasonable this is as technically it's not etherscan?
[etherscan]
metis = { key="any", chainId=1088, url='https://andromeda-explorer.metis.io/api/' }

For future reference: cast etherscan-source should be generalized to cast source and support alternative block explorers


Aftab ansari/angular js solution explorer

Correct and right image added.
Instead of AngularSample it must be AngularJsSample.
Bower dependencies should appear at top.

@aftab10662,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Rick-Anderson Please review the changes.

@fiyazbinhasan  please review.

@Rick-Anderson reviewed. looks good :)

@AftabAnsari10662  @fiyazbinhasan  Thanks guys.


WIP: utils: Add swiftenvs, which allow the overriding of compiler tools.

This PR lets you fake a build or instrument an actual build of Swift using build-script and cmake. My hope is that it will reduce the compilation time to seconds and allow faster iteration on cmake changes. This is just to test that it can pass CI tests--it needs some documentation as well.
I know there are builtin ninja and cmake tools to do things like this.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test Linux

On Mar 20, 2017, at 1:06 AM, Doug Coleman<EMAIL_ADDRESS>wrote:
My hope is that it will reduce the compilation time to seconds

This part sounds like my fantasy but not very likely!  Missing context?

Right now it's a fake build that writes out the command-line arguments to the .o, .dylib files so we can do things like test that asserts are enabled. I got sick of waiting hours for a build to finish just to check that compiler flags are correct.
However, I think it's possible to speed up actual compilation as well...

Nice! Minor nit - consider addressing the shellcheck-warnings for the shell scripts in this PR :-)

@swift-ci Please test Linux

@swift-ci Please clean test Linux platform

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 484a08bb30ee50d412ff437657f64012a1d8d970
Test requested by - @erg

@swift-ci Please smoke test

@practicalswift I fixed all but two shellcheck errors that seem bogus:
In utils/swiftenv-script line 115:
    local command; command="${script_args[@]:0:1}"
                           ^-- SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

In utils/swiftenv-script line 125:
                *) subcommand="${command_args[@]:0:1}"; subcommand_args=("${command_args[@]:1}");;
                              ^-- SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge


mp3 not working in 2.11.1 on firefox

Control elements are empty and audio can not be played.
It works fine with version 2.10.3.
Tested on debian and windows.
I can give further information if needed.

@steros Is this still an issue?

Sorry currently no idea.
On Aug 4, 2016 06:28, Rafael Miranda<EMAIL_ADDRESS>wrote:@steros Is this still an issue?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

@steros thanks for your response. I'll close this and we can reopen this if appears in the future


Rectified error in docs to make the link functional

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
Rectified error in docs to make the link functional[GSSOC'21]

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes https://github.com/TesseractCoding/NeoAlgo/issues/5080

Please make an issue here and raise a PR, for an article as part of our Docs repository: https://github.com/TesseractCoding/NeoAlgo-Docs
It would be much appreciated. Thanks!


colab example train failed with no log in https://app.lamini.ai/train

I try to follow the https://colab.research.google.com/drive/1QMeGzR9FnhNJJFmcHtm9RhFP3vrwIkFn?usp=sharing  on readme
The train step
start=time.time()
finetune_model.train(enable_peft=True)
print(f"Time taken: {time.time()-start} seconds")

always failed with
Training job submitted! Check status of job 3459 here: https://app.lamini.ai/train
Job failed: {'job_id': 3459, 'status': 'FAILED', 'start_time': '2023-09-27T12:52:33.304092', 'model_name': None, 'custom_model_name': None, 'is_public': None}
Time taken: 35.00070023536682 seconds

I tried to specify different model names but it does not help. What make it harder is the log tab on https://app.lamini.ai/train is also empty.

how should I go from here? any suggestions are greatly appreciated!

Hello!! Checking this out now 👀
Thank you for bringing this to our attention!

Fixed!! Please try again 🙏  The logs should appear as well.
(We recently rotated some keys and missed a spot 😅 )

Just tried again, now the job is in queued state, fingers crossed

My last run finished successfully, with eval results and log in dashboard. Thanks for the quick turn around

I had also met this kind of problem.Help.What I should do


'continued' text option causes 'link' to persist, even if value explicitly null or undefined

When rendering an inline link, all text that is continued after that link repeats that link. My expectation would be that changing the link option to undefined or, at minimum the more explicit value null, would reset the underlying link option to undefined. (I did find however that other falsey values -  0 and false - did behave as expected). You can see the behavior by placing the following text in the browser demo:
// create a document and pipe to a blob
var doc = new PDFDocument();
var stream = doc.pipe(blobStream());

// draw some text
doc.fontSize(25)
   .text('Lorem ipsum dolor ', 100, 80, {continued: true})
   .text('sit amet', {continued: true, link: 'http://pdfkit.org', underline: true})
   .text(', consecteteur adipiscing elit.', {continued: false, link: null, underline: false});

// end and display the document in the iframe to the right
doc.end();
stream.on('finish', function() {
  iframe.src = stream.toBlobURL('application/pdf');
});

This is the line of coffeescript causing the behavior:
options[key] ?= val

This doesn't simply override undefined options, but also null values. My guess is that the intended behavior was to fill in the undefined values. Perhaps this coffeescript instead?
if options[key] == undefined
   options[key] = val

Seems null will now end the link (in 0.11.0)
Can be closed?


Removing multiple slashes if they are at the start of pathname

While upgrading normalize-url from 3.1.0 to 4, I noticed that removal of duplicate slashes started to fail in our project. The added tests demonstrate the issue.

This should fix #76


World generator crashes at large world sizes!

Referred to you from the Nucleus team @  #1136
My problem:

Short version: Can't generate large worlds because the server crashes.
Long version: I can only generate a world so large before the server inevitably crashes with an "java.lang.OutOfMemoryError" exception. I don't understand programming so I'm wondering if there's a possible resolution to this.
The following commands I'm attempting to type with Nucleus:
world border set "Survival" 0 0 102400
world border gen "Survival"

Nucleus's response:

Nucleus simply invokes the Sponge world pre generator, so it's down to that, it's not Nucleus. It tries to manage the memory but sometimes it just can't....
...Ultimately, not a Nucleus problem.

~move to sc

Hey @githubl0ver69! I've moved your issue to SpongePowered/SpongeCommon#1883.


Cloudwatch_metrics_collector launching but not publishing metrics

Hello, I want to monitor custom metrics of my robot on cloudwatch, when  I launch using  sample_application.launch it works. But when I use a launch file from a different package and include the cloudwatch_metrics_collector.launch file and provide arg for config file (same as in sample_application.launch), it doesn't work. Please help me with this issue.
@jpeddicord @dabonnie @mm318 @timrobotson

Hello @maarufvazifdar, sorry you're currently having issues! Could you please provide your launch file for us to review? @jikawa-az @emersonknapp please take a look.

Like @dabonnie said - please provide your launchfile, and a copy-paste of the terminal output when it fails, we don't have quite enough information to help.

Hi, I was publishing around 50 metrics so after increasing the  request_timeout_ms and connect_timeout_ms to 20 seconds it worked.


don't remove the wwids and bindings at the end of refreshbootmap

some times the multipath is left there even though the multipath flush cmd reports successful
If we delete the wwids and bindings, the same name maybe reused by future deploy.
enhance the logs to collect more info.

Signed-off-by: dyyang<EMAIL_ADDRESS>

I will do more test, please do not merge before I confirm. Thanks！


go-langserver: invalid root path "file://": must be file:/// URI

From @Dominik-K on February 9, 2018 12:31
In a new VSCode (1.21.0-insider, d28f0960) window, I opened a simple Go file /tmp/vscode-test.go and get the following error message popup:

(BTW: Would be good that the "output" channel will be shown in the message popup.)
It's from the activated go-langserver (current master version https://github.com/sourcegraph/go-langserver/commit/c0ef041f)
[Error - 1:19:09 PM] Server initialization failed.
  Message: invalid root path "file://": must be file:/// URI
  Code: 0
langserver-go: reading on stdin, writing on stdout
--> request #0: initialize: {"processId":40939,"capabilities":{},"trace":"off"}
<-- error #0: initialize: {"code":0,"message":"invalid root path \"file://\": must be file:/// URI","data":null}
--> request #1: shutdown: null
<-- error #1: shutdown: {"code":0,"message":"server must be initialized","data":null}

Copied from original issue: Microsoft/vscode-go#1504

I can see this happening when opening a stand alone go file, but not when opening a folder.
@slimsag @keegancsmith Looks like the language server fails when there is no folder open

From @keegancsmith on February 16, 2018 15:46
Yeah right now go-langserver doesn't support not having a rootPath or rootURI. I'll see how easy it is to add, but we have in quite a lot of places baked in the assumption of a rootPath.

We could start with just current directory and log the fact that we are doing so since going beyond is expensive.

From @keegancsmith on February 27, 2018 14:57
I'm unsure how well this would work, but we could just pretend that rootPath = "/". For operations that inspect the workspace (like references), this would end up being very very costly. So it doesn't seem like the correct solution.
@ramya-rao-a what functionality is expected to work when there is no workspace? If we can rule out references and workspace/symbols that seems fine to me. If references are expected to work, in what scope? Just the current file / current directory / more (GOPATH?)

When this is going to be fixed?

It would probably be addressed as part of the work to use the new go/packages. See https://github.com/sourcegraph/go-langserver/issues/293
We welcome contributions.

@keegancsmith I have noticed that IsURI has some defect here. According to RFC 8089 §2, /, // and /// abide by as a file hierarchy part.

Great, can ya send up a PR?


[FEATURE] search by clicking on user's tags

Description
Currently we can add tags to our profiles, but it would be good to be able to search for these and also by clicking them it goes to the search page with it pre-filled
Screenshots
No response
Additional information
No response

Hey, @eddiejaoude I would like to work on this. Before that, I just want to confirm what I understood.
So in the first case, if we search for any tags, It should display profiles with those tags, right?

And in the second case, if we click on any tags from the profile, we should redirect the user to the search page and the selected tag will be typed in the text box right?

after clicking

If this is what we want can you assign this to me? Or can you please explain where I went wrong?

Wow this is explained super well 👍  yes that is correct @joeshajan 💯
Would you like me to assign it to you?

Hey, @eddiejaoude I would like to work on this. Before that, I just want to confirm what I understood.
So in the first case, if we search for any tags, It should display profiles with those tags, right?

And in the second case, if we click on any tags from the profile, we should redirect the user to the search page and the selected tag will be typed in the text box right?

after clicking

If this is what we want can you assign this to me? Or can you please explain where I went wrong?

😎


Contrast stretching

Hello,
I am interested in implementing the contrast stretching [1] feature in the OHIF Viewer.
Would you be able to give some high-level guidance on how I can go about doing the same.
Best, Anupam

http://what-when-how.com/embedded-image-processing-on-the-tms320c6000-dsp/contrast-stretching-image-processing/

I could be mistaken, but isn't contrast stretching another name for windowing/leveling? I believe this is already implemented with the Cornerstone WWWC tool.
https://radiopaedia.org/articles/windowing-ct?lang=us
Closing for now. More than happy to take another peak if you can provide more information.


Fibaro hub friendly_name key error

Home Assistant release with the issue:

0.83.0
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):

Docker version 18.09.0, build 4d60db4 on Debian GNU/Linux 9.6 (stretch) on Kernel 4.9.0-8-amd64
Component/platform:

https://www.home-assistant.io/components/fibaro/
Description of problem:
Adding the Fibaro hub component with basic config throws errors.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
fibaro:
  url: http://<IP_ADDRESS>/api/
  username: hass
  password: 12345678

Traceback (if applicable):
2018-11-30 09:48:05 WARNING (StateHandler) [fiblary3.client.v4.client] Connection Error. Attempt number: 1
2018-11-30 09:48:05 ERROR (StateHandler) [fiblary3.client.v4.client] Exception: (<class 'KeyError'>, KeyError(81,), <traceback object at 0x7f419c122cc8>)
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/fiblary3/client/v4/client.py", line 267, in run
    self.callback(state)
  File "/usr/src/app/homeassistant/components/fibaro.py", line 111, in _on_state_change
    self._device_map[dev_id].friendly_name,
KeyError: 81
2018-11-30 09:48:05 WARNING (StateHandler) [fiblary3.client.v4.client] Waiting for next attempt 1 second(s)

Additional information:
Api call response for device 81:
{
  "id": 81,
  "name": "81",
  "roomID": 10,
  "type": "com.fibaro.zwaveDevice",
  "baseType": "com.fibaro.device",
  "enabled": true,
  "visible": false,
  "isPlugin": false,
  "parentId": 1,
  "remoteGatewayId": 0,
  "interfaces": [
    "battery",
    "zwave",
    "zwaveAssociation",
    "zwaveSlaveRouting",
    "zwaveWakeup"
  ],
  "properties": {
    "associations": "[{\"endPointId\":0,\"groups\":[]}]",
    "batteryLevel": "56",
    "batteryLowNotification": "true",
    "configured": true,
    "dead": "false",
    "deadReason": "",
    "defInterval": "300",
    "deviceControlType": "0",
    "deviceIcon": "28",
    "deviceSpecificData": "",
    "deviceSpecificIdType": "",
    "deviceState": "Configured",
    "emailNotificationID": "0",
    "emailNotificationType": "0",
    "endPointId": "0",
    "lastWorkingRoute": "[1,8]",
    "lastWorkingRouteRequestStatus": "ok",
    "lastWorkingRouteRequestTimestamp": "0",
    "lastWorkingRouteResponseTimestamp": "1543544143",
    "log": "",
    "logTemp": "",
    "manufacturer": "",
    "markAsDead": "true",
    "maxInterval": "1800",
    "minInterval": "60",
    "model": "",
    "neighborList": "[8,25,85,92,112]",
    "neighborListRequestStatus": "ok",
    "neighborListRequestTimestamp": "0",
    "neighborListResponseTimestamp": "1543544143",
    "nodeId": "15",
    "parameters": [],
    "parametersTemplate": "322",
    "pollingTimeSec": 0,
    "productInfo": "0,2,0,5,0,4,1,1",
    "pushNotificationID": "0",
    "pushNotificationType": "0",
    "remoteGatewayId": "0",
    "saveLogs": "true",
    "serialNumber": "",
    "smsNotificationID": "0",
    "smsNotificationType": "0",
    "stepInterval": "60",
    "useTemplate": "true",
    "userDescription": "",
    "wakeUpTime": 600,
    "zwaveCompany": "Danfoss",
    "zwaveInfo": "6,3,67",
    "zwaveSoftwareVersion": "{}",
    "zwaveVersion": "1.1"
  },
  "actions": {
    "reconfigure": 0,
    "setInterval": 1
  },
  "created":<PHONE_NUMBER>,
  "modified":<PHONE_NUMBER>,
  "sortOrder": 24
}

CC @pbalogh77

@makuser could you please try again with 0.83.2, it should be fixed now

@makuser could you please try again with 0.83.2, it should be fixed now

Looks great!
What was the cause? Some devices didn't have a name and the library threw an error because of this? Device 81 on fibaro is a zwave master device for a heating controller, it has two slaves, and I generally don't give the master any name at all. But even after I gave it a name, the error persisted.
So what was it actually?
2018-12-01 14:25:59 INFO (MainThread) [homeassistant.loader] Loaded fibaro from homeassistant.components.fibaro
2018-12-01 14:25:59 INFO (MainThread) [homeassistant.setup] Setting up fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.setup] Setup of domain fibaro took 0.5 seconds.
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.loader] Loaded binary_sensor.fibaro from homeassistant.components.binary_sensor.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.loader] Loaded cover.fibaro from homeassistant.components.cover.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.loader] Loaded switch.fibaro from homeassistant.components.switch.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.components.cover] Setting up cover.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.components.switch] Setting up switch.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.loader] Loaded light.fibaro from homeassistant.components.light.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.components.light] Setting up light.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.loader] Loaded sensor.fibaro from homeassistant.components.sensor.fibaro
2018-12-01 14:26:00 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.fibaro

It was a stupid mistake. If I received an update for a device that was not mapped (e.g. imported) into Home Assistant, it'd crash like this.


Fix Android Studio java gradle migrator null check

This PR fixes the fact that this null check is not safe, as discussed here.
Fixes:
https://github.com/flutter/flutter/issues/125712
https://github.com/flutter/flutter/issues/125684
https://github.com/flutter/flutter/issues/125687
Note that while the linked issues don't note that this is due the bad use of a null check operator, that is because the crash output includes a preformatted link to post into the browser to create a github issue, and for some reason that autofilled issue doesn't indicate the actual cause. This is a sample link from local reproduction, but above that we can see the actual cause
Oops; flutter has exited unexpectedly: "Null check operator used on a null value".
A crash report has been written to /Users/mackall/development/BugTesting/OldFlutter/test7/flutter_02.log.
This crash may already be reported. Check GitHub for similar crashes.
https://github.com/flutter/flutter/issues?q=is%3Aissue+Null+check+operator+used+on+a+null+value

To report your crash to the Flutter team, first read the guide to filing a bug.
https://flutter.dev/docs/resources/bug-reports

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Closing as the original PR was reverted, putting up a PR for a patched version shortly.


Feature Request: Add support for tasklist.

As react-markdown does have support for plugins it would be pretty easy to add support for advanced markdown integration like tasklist:
* Lists
* [ ] todo
* [x] done

I'm not a react or vscode plugin specialist but as is see to make that happen is:

Add remark-gfm to package.json
Add remark-gfmas import to task.tsx
Change in task.tsx lines 70-73 from

<ReactMarkdown>
    {data.text || '_enter text or markdown here_'}
</ReactMarkdown>

to
<ReactMarkdown remarkPlugin={[remarkGfm]}>
    {data.text || '_enter text or markdown here_'}
</ReactMarkdown>

How to integrate a plugin is descripted here: react-markdown
I have no experience in writing github issues so please exuse me if something not formatted right.

This issue is going on the backburner for now. By all accounts, your suggested change should work. The documentation for remark-gfm and react-markdown also specify that format. For whatever reason though, this crashes the extension when you try to edit the text.
I also would like to use task lists, so I will get around to this. But debugging interactions between npm packages is not fun 🥴

react-markdown got an update which fixed the bug with remark-gfm! This feature is in 1.7


Add proxy-internal service to Kubernetes

Motivation
This service will be needed so that the internal port of the validators work properly
Proposal
Add the service
Test Plan
This was tested by running the e2e tests locally with Kubernetes

Current dependencies on/for this PR:

main

PR #1314   👈

PR #1315

This stack of pull requests is managed by Graphite.


Add general data reader

Refactoring data readers for better code reuse.

Technically DemographicsData doesn't really use anything from DataReader and thus doesn't need to inherit from it, but I decided to add the inheritance anyway for consistency (and in case it ever does need to make use of some DataReader functions in the future).


remove roleId from the login controller

Coverage remained the same at 96.863% when pulling dbaaa769065a33378884f8b657f2245cc1e6f29b on chore/quick-fix into d5275d3be79ab65e80635a9336dafa473c356684 on development.


feat(menu): add a color distinction between selected and unselected arrow

close #1535

The icon color is not activated when active. I think this is needed.

The icon color is not activated when active. I think this is needed.

The arrow will set color just on selected and hovered.

The icon color is not activated when active. I think this is needed.

The arrow will set color just on selected and hovered.

OK