QueryResultTypeWalker: add option not to stringify expressions

Currently, inferring numeric types (mainly results of AVG, SUM etc) is imperfect as it is currently implemented to serve all configurations resulting in union types like int|numeric-string. This is painful to work with in real codebase with some specific configuration where you know it is always int.
To match setup of modern PHP versions (8.1.25+) using most used driver (PDO), I added option not to stringify such expressions.

To match setup of modern PHP versions (8.1.25+) using most used driver (PDO), I added option not to stringify such expressions.

What about auto-detecting this from PhpVersion, and also from objectManagerLoader if one is provided?

Note: this is still WIP and I still plan to finalize this, but implementing all the built-in SQL functions is non-trivial when considering all edge-cases. To be able to implement it properly, I created test repository to verify all differences: https://github.com/janedbal/php-database-drivers-fetch-test/

Hi @janedbal, I need this PR to move on mine https://github.com/phpstan/phpstan-doctrine/pull/520.
What is missing here (maybe writing tests ?) ; do you need help ?

@VincentLanglet Jan already drowned dozens of hours to get this right, it's a very complex topic as you can see in here https://github.com/janedbal/php-database-drivers-fetch-test/. Don't rush this :)

@VincentLanglet Jan already drowned dozens of hours to get this right, it's a very complex topic as you can see in here janedbal/php-database-drivers-fetch-test. Don't rush this :)

Sorry if my message was heard like this, wasn't my intention. I thought one of the issue with this big PR was to write tests for all the build-in method, and that maybe I could find and offer time to this.
Anyway, it will take the time it need to take ! :)

The green CI here is misleading, there is still ton of work awaiting (walkFunction is wrong, DoctrineTypeDescriptor::getDatabaseInternalType has no access to driver so it cannot return proper type, tests need to be MUCH better). I just didnt push my local WIP (maybe I should) :)

@VincentLanglet Pushed the WIP so that you can check the direction I'm leaning towards.

@VincentLanglet Pushed the WIP so that you can check the direction I'm leaning towards.

Thanks, can I help you on this ?
If I understand correctly the goal is to uncomment the tests and make them pass or is there something else ?
Do you need more test to be written ?
I notice there was conflict with the 1.3.x branch, do you have time to solve them or do you want me to try ? :)

@VincentLanglet I've some stuff in backlog to do first before returning to this. But the outline what needs to be done:

(1) Decide how to deal with untested drivers. For example how BOOL column is fetched. Do we want to:

Produce best guess?

Currently only postgre uses bool, any other driver is just 1|0 (or '1'|'0' when stringified). So what do we produce for "other driver"? Sidenote: I think bool is currently completely broken for postgre.

Return mixed?
Return benevolent-union of some reasonable value? What is reasonable value, those other drivers ever used?

(2) Carefully finalize the implementation (mainly all the aggregate functions, which are tricky)

There are plenty of edge-cases to decide.

For example SQRT(negative) leads either to NULL or a failure depending on a driver. But I assume we dont want to add NULL to the result just because of this. Or do we?

(3) Test every supported driver

This requires completely new set of tests and new CI runs as it need to start real database to test our PHPStan types against (just like here, but for much bigger matrix of PHP versions, drivers and their configs)
Basically, we need very similar CI run as used in https://github.com/janedbal/php-database-drivers-fetch-test/blob/master/test-all-php-versions.sh

(4) Solve the BC break introduced

And maybe more stuff I already forgot. I think you can easily help with (3) as such test can be added in standalone MR and possibly merged beforehand. The rest is just digging in code.

@VincentLanglet I've some stuff in backlog to do first before returning to this. But the outline what needs to be done:

(1) Decide how to deal with untested drivers. For example how BOOL column is fetched. Do we want to:

Produce best guess?

Currently only postgre uses bool, any other driver is just 1|0 (or '1'|'0' when stringified). So what do we produce for "other driver"? Sidenote: I think bool is currently completely broken for postgre.

Return mixed?

Return benevolent-union of some reasonable value? What is reasonable value, those other drivers ever used?

I would take the little step by little step approach: untested drivers will returns the same type than before.
This way, when this PR is merged:

tested drivers users will have a better type
untested drivers won't have anything changed

And if a untested-drivers user complains about the type, he/we just have test this drivers and update the code to support it.

(2) Carefully finalize the implementation (mainly all the aggregate functions, which are tricky)

There are plenty of edge-cases to decide.

For example SQRT(negative) leads either to NULL or a failure depending on a driver. But I assume we dont want to add NULL to the result just because of this. Or do we?

What about starting with only the existing implemented aggregate functions ?
https://github.com/phpstan/phpstan-doctrine/blob/5ca0f53c60494fa3f2f4792e385b8233bda474fd/src/Type/Doctrine/Query/QueryResultTypeWalker.php#L931
It could be easier to first, make a PR with those aggregate functions and then adding other aggregate one by one ?

(4) Solve the BC break introduced

The options I see are

Changing the signature to

public function getDatabaseInternalType(/** Driver $driver */): Type;

and passing the driver. In next major the param will be required. This is often done by Symfony.

Creating an interface with a different method

interface DriverAwareDoctrineTypeDescriptor {
     public function getDatabaseInternalTypeFromDriver(Driver $driver): Type;
}

and implementing the interface ; then the check
$typeDescriptor instanceof DriverAwareDoctrineTypeDescriptor
    ?  $typeDescriptor->getDatabaseInternalTypeFromDriver($driver);
    :  $typeDescriptor->getDatabaseInternalType();

could be made.
I think the decision is more on @ondrejmirtes about how he wants to proceed in order to evolve such method signature.

Awesome, thanks a lot for this @janedbal

Thanks @janedbal for your continued work on making this smarter and smarter 💙

After discussion with @ondrejmirtes we decided to separate some stuff to other PRs:

https://github.com/phpstan/phpstan-doctrine/pull/577
https://github.com/phpstan/phpstan-doctrine/pull/578
https://github.com/phpstan/phpstan-doctrine/pull/579
https://github.com/phpstan/phpstan-doctrine/pull/580
https://github.com/phpstan/phpstan-doctrine/pull/581
https://github.com/phpstan/phpstan-doctrine/pull/582
https://github.com/phpstan/phpstan-doctrine/pull/583
https://github.com/phpstan/phpstan-doctrine/pull/584

To minimize conflicts upon rebase, I squashed this MR. Here is a link to old commits if I ever need to check the real history: https://github.com/phpstan/phpstan-doctrine/commits/8c333fe

@ruudk, @arnaud-lb, @VincentLanglet Would you mind testing this in your codebases? It would be very helpful to have this verified by more real-world codebases. Thank you!
{
    "require-dev": {
        "phpstan/phpstan-doctrine": "dev-option-not-to-stringify-numeric-types"
    },
    "repositories": [
        {
            "type": "git",
            "url": "git@github.com:janedbal/phpstan-doctrine.git"
        }
    ]
}

I tested it out on our large application (182 repositories, 16k files) and it works. Unfortunately, it could only remove 3 ignored errors 😅. I guess we don't use that many expressions, or we used Assert.

I won't be able to test on a meaningful code base, but maybe @Kmecnin can?

I tested it out on our large application (182 repositories, 16k files) and it works. Unfortunately, it could only remove 3 ignored errors 😅. I guess we don't use that many expressions, or we used Assert.

It may remove more ignored errors with https://github.com/phpstan/phpstan-doctrine/pull/520.
I also tried the branch @janedbal and

getting 0 new errors
removed 0 ignored errors

It's mainly because we already typed our code with things like int|string or numeric.
But this PR will help us to change the numeric type by the right type from the database. :)

Thank you so much! Let's see how well this fares in real-world project s:)

It's mainly because we already typed our code with things like int|string or numeric.

Yeah, because PHPStan generally allows type widening.
In our case, we have:

Custom rule for direct return of Doctrine type where we deny widening (https://gist.github.com/janedbal/08ec3d5f45dad8627d2cf6499b082512)

e.g. return $query->getResult()

Custom rule that enforces inline vardoc when Doctrine type is assigned to a variable (vardoc allows only narrowing by default)

e.g. $result = $query->getResult()

Those two rules ensure that I fix the types at least near the source and I can verify that the changes I made here are valid all over our codebase.


fix: reordered content and added headers

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x]  My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Created this PR as part of a cleanup after merging some other PRs.  Changed the order of one section and replaced the bolded section titles with headers.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Add colors for Neovim :terminal

There are no colors defined for Neovim's terminal, so it uses the less than ideal defaults.
See onedark.vim for an example.

That's a nice featured I didn't think about. Thank you

These should be the colors:
let g:terminal_color_background =  "#1e1e1e"
let g:terminal_color_foreground =  "#adadad"
let g:terminal_color_0 =  "#1e1e1e"
let g:terminal_color_1 =  "#b60024"
let g:terminal_color_2 =  "#8e9d05"
let g:terminal_color_3 =  "#c8ac74"
let g:terminal_color_4 =  "#63c3f1"
let g:terminal_color_5 =  "#c76fbd"
let g:terminal_color_6 =  "#259286"
let g:terminal_color_7 =  "#eaeaea"
let g:terminal_color_8 =  "#262626"
let g:terminal_color_9 =  "#ee1c42"
let g:terminal_color_10 =  "#bec94a"
let g:terminal_color_11 =  "#fdb63b"
let g:terminal_color_12 =  "#a5d6eb"
let g:terminal_color_13 =  "#e24d8e"
let g:terminal_color_14 =  "#00b39e"
let g:terminal_color_15 =  "#eaeaea"

@metalelf0 thanks, but Tender is generated by Estilo so I need to fix jacoborus/estilo#18 before

Yes you're right, I converted colors from the iterm scheme someone posted on reddit and thought this can be a useful workaround for someone while you fix it :) Keep up the great work, Estilo is gonna rock! ;)


Hack to fix exponential event listeners

:+1:

@paf31 @puffnfresh As discussed, I don't think this is the right place to put this (best to put it into driver), but I do think it's the correct thing to do (given the current architecture of halogen). Merged for now since it's an improvement.


Need help with FPGA Mod + external RGB2HDMI

Hi,
I do not know if I have to post this here or to the rgb2hdmi page..
I am trying here. I just added the external RGB2HDMI to the FPGA mod in a C64.
FPGA mod is working perfectly...
I have problem with the RGB2HDMI mod :-(
See the pictures. Colours are not good. I have the last version on the FPGA board. So I did not had to programm the C64 palette.. I put a bridge on the pin 9&10 from the fpga jtag connector. The switch is on the right side (facing the C64).
My cable seems to be OK, I checked it again now..
I am afraid it could be a problem with the analog board issue 3... I do not know where to look.
All parts of the analog Board are from Mouser except the MAX5259+ (not available. Found @ ebay china
D1 is not the one from the bom, not available. I took another one
https://www.mouser.de/api/CrossDomain/SetContext?qs=bBn1FhEllS9U0dDp%2F71pOPiUJe3tZ6Ip1ZMh3OE2nv0xUzF%2FMuylote9ddp3rOYYukiihePXlcDfag7OjsvTE9Upa0FNsRpkpRGisA8gBCj1r0jQkZNiQeZi1b8vHpd5bz32F3qdT90y4S4tI8U0LCjUVemRndietnon4CL8ld1A5L7yaCdPGXMX%2FSLNpuxov17YS2IDKYUPVMQolWxU%252BT5T2sK6MSD8CpvijeuUHnKalKVlkhdBx6kG0HXwNonc&syncDomain=de&async=False
Could someone help me. Thank you.

When the mod board gives correct colors in normal operation (no jumper), then it is very unlikely that this is the problem.
So the issue is either with the cabling (if you are lucky) or with the analog board (unlucky) or it is just a matter of correctly calibrating the input voltage levels (extremely lucky).
Try playing with the rgb2hdmi settings first and see if you can make the board discriminate 3 different input levels on each of the signal components (Y, Pb, Pr). The sync already is detected perfectly.
I don't remember how to use the settings menu of the RGB2HDMI but after pressing the button, you should be able to guess your way through the menu.

It's like it's missing red and blue colours... I saw yellow, black, braun,....
I re-checked the cable. I do not see a mistake...
I changed the only parts coming from ebay china with another from the lot I bought, just in case... Same result.
I went in Menu and tried to change what I could, like contarst etc....  Dors not help.
I also connect all on another monitor. Same....
How do I calibrate the output voltage ? I did another board, digital for C128 and this one worked directly with default setting on the same monitor...

Just found an error I did on the analog board......
Maybe it's the problem.
R1 should be 470 ohm... I do not know why, I put one of 100 ohm....

Tried with R1 470 Ohm on the analog board. No difference...
A last question, on my FPGA board, I replace R18 and R19 by 75 Ohm, should I put the original value one ?
Can this be a problem ?
I also put my cable connection here just in case......  If I well understood the wiki, this should be correctly connected...

Yes, this would definitely make a difference. With this lower-value resistors the output levels for Pb ad Pr would be muhc lower. This would lead to less saturated colors when used with a normal YPbPr-enabled TV. But due to the the way the RGB2HDMI reads the analog signals, whis would very likely cause the input to be incorrectly interpreted when using the default settings.
So either replace the resistors again or reconfigure the input voltage levels for the red and blue lines using the RGB2HDMI's settings menu.

Have a look at
https://github.com/hoglet67/RGBtoHDMI/wiki/Reference-Guide
in the section Sampling Menu (6 BIT RGB analog inputs)
This is where you can reconfigure the analog voltage levels.

Problem fixed...
Yes, it was only the 2 resistor I replaced. I put the original value back on the board and now, all is working perfectly !
Thank you for all.


Allow multiple TurnstileWidget in one page

For multiple form in one page

Thanks for the PR! Curious as to the purpose behind this though? If you have multiple forms on a page. Why would you need/want more than 1 Turnstile?

Thanks for the PR! Curious as to the purpose behind this though? If you have multiple forms on a page. Why would you need/want more than 1 Turnstile?

For example : in all the website, in the footer, there is a newsletter subscription form. If you go to the login page, you will have two forms : one for login and one for the newsletter at the footer.
Why would I display Tunrstile for the two forms ?


device_energy entity not created in a group?

System Health details
System Information

version
core-2023.9.1

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.11.5

os_name
Linux

os_version
6.1.45

arch
x86_64

timezone
Europe/Amsterdam

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
5000

Installed Version
1.32.1

Stage
running

Available Repositories
1290

Downloaded Repositories
56

HACS Data
ok

Home Assistant Cloud

logged_in
true

subscription_expiration
31 augustus 2024 om 02:00

relayer_connected
true

relayer_region
eu-central-1

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
true

remote_server
eu-central-1-5.ui.nabu.casa

certificate_status
ready

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 10.5

update_channel
beta

supervisor_version
supervisor-2023.09.0

agent_version
1.5.1

docker_version
23.0.6

disk_total
458.4 GB

disk_used
25.8 GB

healthy
true

supported
true

board
generic-x86-64

supervisor_api
ok

version_api
ok

installed_addons
Log Viewer (0.15.1), MariaDB (2.6.1), Samba share (10.0.2), Terminal & SSH (9.7.1), Mosquitto broker (6.3.1), Z-Wave JS (0.1.90), ESPHome (2023.8.3), Studio Code Server (5.10.1), Home Assistant Google Drive Backup (0.111.1), Whisper (1.0.0), SQLite Web (3.9.2), Piper (1.3.2)

Dashboards

dashboards
10

resources
36

views
84

mode
yaml

Recorder

oldest_recorder_run
7 september 2023 om 06:15

current_recorder_run
12 september 2023 om 09:31

estimated_db_size
1387.29 MiB

database_engine
sqlite

database_version
3.41.2

Spotify

api_endpoint_reachable
ok

Checklist

[X] I have read the FAQ to see if there is a known solution to my problem.
[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
went to a grouped config all over, and now several device_energy sensors are no longer created.
The group is showing, but the source sensors in the attributes are not created at all.
Not are the device_energy_yearly for that matter, which should have been made according to the main config.
note the referenced device_energy sensors in the attributes are not created, nor are the _yearly entities

these are the device_power entities

the main group is showing unknown on the energy sensors too:

Reproduction steps

use a list of fixed configs in a group
check main group

...
Debug logs
need to find the relevant detail in that yet...

Diagnostics dump or YAML config
this was my original group
    - create_group: Heaters combined total
      unique_id: powercalc_group_heaters_combined_total
      energy_sensor_naming: '{} energy'
      power_sensor_naming: '{} power'
      entities:

# are device_energy entities not created
#         - create_group: Heaters combined devices
#           unique_id: powercalc_group_heaters_devices
#           entities:
#             - entity_id: device_tracker.heater_dorm
#               <<: &mill_heater
#                 fixed:
#                   states_power:
#                     home: 1.7
#                     not_home: 0
#             - entity_id: device_tracker.heater_library
#               <<: *mill_heater
#             - entity_id: device_tracker.heater_office
#               <<: *mill_heater

        - create_group: Heaters combined consumption
          unique_id: powercalc_group_heaters_consumption
          energy_sensor_naming: '{} energy'
          power_sensor_naming: '{} power'
          entities:
            - power_sensor_id: sensor.heater_library_current_power
              force_energy_sensor_creation: true
            - power_sensor_id: sensor.heater_office_current_power
            - power_sensor_id: sensor.heater_dorm_current_power

and commented because I tried to take that group out of the nest and use its stand alone like
    - create_group: Heaters combined devices
      unique_id: powercalc_group_heaters_devices
      entities:
        - entity_id: device_tracker.heater_dorm
          <<: &mill_heater
            fixed:
              states_power:
                home: 1.7
                not_home: 0
        - entity_id: device_tracker.heater_library
          <<: *mill_heater
        - entity_id: device_tracker.heater_office
          <<: *mill_heater

in the main config, which is:
powercalc:
  disable_extended_attributes: true
  enable_autodiscovery: false
  energy_sensor_naming: '{} device energy'
  power_sensor_naming: '{} device power'
  ignore_unavailable_state: true
  energy_sensor_precision: 2
  unavailable_power: 0
  create_utility_meters: true
  utility_meter_types:
    - daily
    - yearly

  sensors:

clarifying:
    - create_group: Heaters combined total
##########################################################################################
# creates correctly:
# sensor.heaters_combined_total_energy
# sensor.heaters_combined_total_energy_daily
# sensor.heaters_combined_total_energy_yearly
# sensor.heaters_combined_total_power
##########################################################################################
      unique_id: powercalc_group_heaters_combined_total
      energy_sensor_naming: '{} energy'
      power_sensor_naming: '{} power'
      entities:

        - create_group: Heaters combined devices
##########################################################################################
# creates:
# !! sensor.heaters_combined_devices_device_energy  unknown
# !! sensor.heaters_combined_devices_device_energy_daily 0
# !! sensor.heaters_combined_devices_device_energy_yearly unknown
# sensor.heaters_combined_devices_device_power seems ok
# correct individual sensor.[object_id]_device_power
# !! NO individual sensor.[object_id]_device_energy !!
##########################################################################################
          unique_id: powercalc_group_heaters_devices
          entities:
            - entity_id: device_tracker.heater_dorm
              <<: &mill_heater
                fixed:
                  states_power:
                    home: 1.7
                    not_home: 0
            - entity_id: device_tracker.heater_library
              <<: *mill_heater
            - entity_id: device_tracker.heater_office
              <<: *mill_heater

        - create_group: Heaters combined consumption
##########################################################################################
# creates correctly:
# sensor.heaters_combined_consumption_energy
# sensor.heaters_combined_consumption_energy_daily
# sensor.heaters_combined_consumption_energy_yearly
# sensor.heaters_combined_consumption_power
# required a lot of manual editing of the 'Dummy' object_ids and not use the default
# _device_energy naming....
##########################################################################################
          unique_id: powercalc_group_heaters_consumption
          energy_sensor_naming: '{} energy'
          power_sensor_naming: '{} power'
          entities:
            - power_sensor_id: sensor.heater_library_current_power
            - power_sensor_id: sensor.heater_office_current_power
            - power_sensor_id: sensor.heater_dorm_current_power

I see you are mixing all kind of energy_sensor_naming and power_sensor_naming all over the place which is asking for troubles.
You have defined energy_sensor_naming: '{} energy' on group Heaters combined total.
All nested groups below that will inherit configuration from the parents.
So the same entity naming will also apply to Heaters combined devices, because that is set up as a child under the group.

I need to check that indeed, but what happened eg on the bottom group, the Heaters combined consumption, is that the group entities did get the naming as set in the group, but the individual entities were named according to the main config (device_energy/device_power)
I would have expected that same strategy to be applied to the Heaters combined devices, since I didnt set a naming there, and that is what I need them to be named.
the individual energy sensors in that device group simply are not created:

as said, the device_energy_daily is using that (non-existing) entity as source..

given the source power sensors  of the Mill integration are unreliable as can be, I am tempted to simply connect them over a smart plug and be done with it. I wouldn't have to worry about standby power and consumption any longer, just for the plug itself.
Yet, I dont have those yet, and would think I could do it within the nested groups. Not really sure what I am doing wrong here

Maybe they have the old naming because these individual entities did exist already before?
You should really enable debug logging and have a look at the logs to see what's going wrong.
There is so much configuration in play here. Hard to say what is the problem, without any logs.

will check debug.
its not old naming that is the issue, its not creating entities in the first place.
ill try to figure it out, and report back.

Sorry need some more time. Will be not in the opportunity next 2 weeks to test. Please keep open

so Ive tested this with various configs, deleting the original entities, hoping it would rebuild correctly, but nt make it happen.
nothing stands out in the debug log as far as I can see...

please see https://github.com/bramstroker/homeassistant-powercalc/issues/1881#issuecomment-1808074149
it was finally solved


The mode parameter has been deprecated. Please set the mode using the network option, wn.options.hydraulic.demand_model.

https://github.com/glorialulu/TSNet/blob/f005b5b6589f4aef85697430f6d8501ca01785e8/tsnet/simulation/initialize.py#L70

Using version 0.2.3 of WNTR library solve the isssue.


Investigate the private repository + artifact registry + artifact registry scanning issue

[ ] Make sure the end-to-end GH workflow + repo tag + cloud build + push + registry scan works correctly.

https://github.com/PHACDataHub/infra-core/pull/50/files

Closed by https://github.com/PHACDataHub/infra-core/pull/50/files


KubeCluster

KubeCluster provides access to managing a Kubernetes cluster. It abstracts the configuration of the Kubernetes client from it's usage.
Requirements

should be able to be created from a kubectl context (including default)
should be able to be created using kubectl parameters
should implement Deployer from #19 (eventually we want to implement Manager)

Implementation
The type wraps the Kubernetes API client using the configuration specified in the constructor either with a kubectl context or the individual parameters.
Deploy method
Iterates through each typed slice of Kubernetes objects in the Deployment and creates it within the cluster. The Deployment name should be recorded in an annotation. Return errors if any object is unable to be created.
Rollback
I'm not sure of the ideal behavior for rolling back deploys, let's wait for user feedback and decide.

Checkout https://github.com/kubernetes/kubernetes/blob/cfa3f037fdc34f1195976d9fc822d127ed6939db/pkg/client/unversioned/clientcmd/api/types.go

<EMAIL_ADDRESS>


Windows get resized when switch to fullscreen and back to desktop

Environment

Item
Value

OS, Version / Build
Windows 10 version 10.0.19041.388

Processor Architecture
AMD64

Processor Type & Model
Core i5 (Skylake)

Memory
8GB

Storage Type, free / capacity (e.g. C: SSD 128GB / 512GB)
SSD 256GB

Relevant apps installed
___

Description

When switching to full screen in some apps/games, when going back to the desktop, most of my windows get messed up: they are moved/resized.
Steps to reproduce

download dosbox
open any windows and maximize them
start dosbox and press alt + enter
press alt + enter to switch back to window mode

Expected behavior

Previously opened windows should be left untouched: positioned at the same position and with the same size.
Actual behavior

Some windows get moved/resized.
See this video: https://youtu.be/UtB7P8f2j2A
As you can see, the Chrome Window takes most of the screen before switching to fullscreen and get resized when switching back to window mode.

(Get this is not current meaning of "performance.")
I haven't seen such a blatant case.  What happens for some games that run full-screen is afterwards, my Bing Toolbar is moved from where I always park it to the middle of my screen somewhere.  I suspect some sort of (usually invisible) screen re-sizing/scaling that happens when the game starts up.  Since only some games do it, I suspect it is the game engine and not Windows that is the miscreant.

Since I remember it happening already in the XP days, I guess it's not an engine problems but rather a problem with Windows. Back then I didn't care. Right now I'm using my computer to do serious work as well as occasional playing.

(Get this is not current meaning of "performance.")
I haven't seen such a blatant case. What happens for some games that run full-screen is afterwards, my Bing Toolbar is moved from where I always park it to the middle of my screen somewhere. I suspect some sort of (usually invisible) screen re-sizing/scaling that happens when the game starts up. Since only some games do it, I suspect it is the game engine and not Windows that is the miscreant.
[PS: On a (Windows XP) tablet PC there was a problem if I changed verticality. The remushing of desktop icons would be indelible, so I learned to arrange my desktop icons in a rotation-preserved corner.]

From my experience, this happens with games in exclusive full-screen mode that use a smaller screen resolution than the desktop, though I think that's a different case than the one in this issue.

@adrianghc I think that's what you describe. Games/apps use indeed a smaller screen resolution than the desktop.

@adrianghc I think that's what you describe. Games/apps use indeed a smaller screen resolution than the desktop.

Yes, but considering the very strange aspect ratio your Chrome window acquires, I'm not sure that's what's at play here, is it? I'm also missing the usually more pronounced delay when entering and leaving exclusive full-screen.

(Get this is not current meaning of "performance.")
I haven't seen such a blatant case. What happens for some games that run full-screen is afterwards, my Bing Toolbar is moved from where I always park it to the middle of my screen somewhere. I suspect some sort of (usually invisible) screen re-sizing/scaling that happens when the game starts up. Since only some games do it, I suspect it is the game engine and not Windows that is the miscreant.
From my experience, this happens with games in exclusive full-screen mode that use a smaller screen resolution than the desktop, though I think that's a different case than the one in this issue.
I think that is my experience, the game opens to a default resolution that is less than my screen resolution and snaps to my full-screen faster than I can notice, probably before anything paints.  I don't think I have seen the case identified in this issue though.

Unfortunately, this issue is out of scope for this repo, so it won't be tracked here. BUT the team responsible for this issue gets feedback and bug reports via Feedback Hub! Please file this issue in the Feedback Hub under "Displays and Graphics -> Multiple Displays". Once you've done this, please paste the link here and I can go ahead and give the feedback an upvote.
I've reached out to the team responsible and it looks like they're already tracking this bug and exploring solutions. Thanks for filing!

@AvriMSFT, This bug isn't about multiple displays. Should feedback still be filed there?

Yes. I spoke with a rep and they recommended you file there.

I filled an issue in FH: https://aka.ms/AAbz26p

Upvoted


Cannot find doc on tsc --in myfile.es6 --out myfile.js

I cannot find any comments on this anywhere on the internet.
I prefer to name my es6 files something other than *.ts
Thanks,  Maybe some version in the future.

To clarify, are you asking about compiling files with a .js extension? Our compiler currently doesn't support this. Is there any specific reason you feel averse to using the .ts extension? Are there any downsides to doing so?

I'm sorry, that was pretty dense on my part.
I want to name my files *.es6 (but the extension should be irrelevant).
Maybe something like this:  tsc --in myfile.es6 --out myfile.js
As programs like typescript and babel mature they will complement each.  And as newer versions of ECMAscript come out I could use *.es7, *.es6 on the same line...
But I can always preprocess my files if I want to rename them.

Thanks, that pretty much confirms what I was thinking.
TypeScript works great, I'll be using it regularly.

Glad to hear it, hope it isn't too much trouble. We're very much committed to conforming closely to ES6 and as it becomes more concrete, ES7, so ideally you shouldn't ever need to feel concerned about which edition of ECMAScript since TypeScript will support it.


FUSED-models

The idea is to create a generic assembly, or a special type of assembly / component, that can do model aggregation. Several models that have similar I/Os for similar purpose would be able to be run in parallel, and their results would be "fused" together. The methodology could follow e.g some Bayesian model averaging flavour.

that's good idea,we face this situation now,  have you finish coding and have someone use this  aggregation?


questions about training a multi-speaker model

Are there any differences in training a multi-speaker compared to single-speaker?
After adding corresponding data and IDs to filelist.txt，more speakers require more epoch? could you give some suggestions, thanks in advance.  @RVC-Boss

It is recommended that the sample size of different speakers should not differ too much.
More epochs can make the trained model's inferred speech timbre more similar to the target speaker.


feat: add resizeMode prop for Carousel

add resizeMode prop for Carousel

@zrg-team: those implements that you suggest is very good. I think we should do it on another ticket because this is out of scope for current ticket. Beside of that, we also need build properties for mobile editor for these implement too.


Support NF4/FP4 data type in weight-only

Type of Change
feature
Description
support NF4/FP4 data type in weight-only, allow tuning dtype and compressing nf4/fp4 model
Expected Behavior & Potential Risk
UT pass
How has this PR been tested?
local test
Dependency Change?
N/A

Which FP4 format? Should specify FP4_E3M0, FP4_E2M1. You can align with Penghui.

Which FP4 format? Should specify FP4_E3M0, FP4_E2M1. You can align with Penghui.

FLOAT_MAPPING = {'nf4': NF4, 'fp4': FP4_BNB, 'fp4_bnb': FP4_BNB, 'fp4_e2m1': FP4_E2M1, 'e2m1': FP4_E2M1}
By default, fp4 is the one bitsandbytes used. Developers can select from ['fp4_e2m1',  'fp4_bnb']

We still miss GTPQ and TEQ to support NF4/FP4, it will happen in late PRs.


Cannot create json setting for dedicated mapper

Thank you for an excellent extension.
I am trying to extend the mapper for markdown files. When I add the required setting in the VS Code settings json file for the new dedicated mapper as follows:
"codemap.md": "D:\\Dropbox_local\\software\\V\\Visual Studio Code\\extensions\\mapper_md.js",
I receive the error:
Regex-based definition of the mapping rules for Markup syntax.
Incorrect type. Expected "array".
Any advice would be much appreciated.
Thank you.

Sorry for the delayed response.
It is a defect.
I did not realize the way setting file in VSCode is processed prevents user from changing the config value type.
In your case the config value is declared in the default config as array (because it is a RegEx based mapper). You want to create a new dedicated mapper for the same syntax (MD) so the config value must become  a string.
The only way out is to allow a new overloaded value via slightly different config name:
"codemap.overloaded.md": "D:\\Dropbox_local\\software\\V\\Visual Studio Code\\extensions\\mapper_md.js",

And this is what is done with the commit af48179
The fix vill be available with the very next release.

Thank you very much. I will wait for the next release and then try again with the config name you described above. Kind regards.

Thank you for the release.
Should I now be able to define "codemap.overloaded.md": ?
This configuration setting does not seem to be known to Visual Studio Code, or is there something else I need to refresh or install?
Thanks again.

codemap.overloaded.md cannot be recognized by VSCode as it is a custom user settings value.
Just add the line as below to the settings.json file and the extension will read the setting at runtime:
"codemap.overloaded.md": "D:\\Dropbox_local\\software\\V\\Visual Studio Code\\extensions\\mapper_md.js",

Thank you. I will experiment.

Thank you once again. This is now working perfectly!
I went down this path because I wanted to capture headings in markdown files, eg
example heading level 1
=====================================================

example heading level 2
------------------------------------------------------------------------------------------

where the heading level is indicated by the underline style and hence is a multiline check and hence (if I understand correctly) requires a dedicated mapper.

As an aside, the Donate button on Github (or within Visual Studio Code which i guess is the same thing) doesn't seem to go anywhere.

Now it does. :o)
Sorry, It's rather embarrassing. I have moved my all projects web hosting to the GitHub pages but forgot to update the donations new url. Thank you for letting me know. Fixed now.


I want to know your Arch customizations

Hello, I have seen your arch rice, it's so awesome. Can you give me the list of theme, icon, terminal and DE, WM in the picture with Heapbytes theme. Thank a lots

hello there @hoagduonwg,

the terminal blur theme is because of picom (you can see my dotfiles repo for picom config, use animation fork of picom)
No external icon is needed for this terminal theme
I don't use DE, I am using bspwm WM.
For the line that comes at bottom of the terminal it's oh-my-tmux.
You need to start tmux session with tmux -u for all fonts to work properly.

Feel free to reach out to me anytime if you face any issue later. I am glad you liked the theme :smile: .


[FR] Show packet name

First, a few things...
No response
😄 Describe the solution you'd like
Show the packet's name when it is unable to find the packet's serializer when the program is running in development mode.
🧠 Describe alternatives you've considered
No response
🤚 Drawbacks
No response
💻 Platform
All
⭐ Environment
1.0.6-SNAPSHOT
✍ Additional context
No response

I think this will make the project so much more complex, and decrease the performance, even if it is only in the dev mode


Implement collections.defaultdict

@freakboy3742 Sorry my brain got short-circuited just now 😅. Actually the reason I make a private __getitem__ on org.python.types.Dict is to preserve dict behavior on defaultdict. You see, other than __getitem__, defaultdict has exactly the same behavior as dict when other methods are call.
e.g. defaultdict.get(x) should return None (same as dict) when x is not a key instead of invoking the default_factory for missing value.
However the implementation of get(x) in voc calls __getitem__(x) which indirectly calls __missing__(x), causing defaultdict to return default_factory value instead of None, hence the need of another __getitem__ without calls to __missing__.


Weird bug where page is not fully loaded after load event

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.18.1
Platform / OS version: Linux in a docker container
URLs (if applicable): -
Node.js version: 12.2

What steps will reproduce the problem?
I can't really reproduce the problem as it does not occur reliably and it seems linked to one of the page I'm working on but we don't seem to be able to make it reproducible.
But here is the gist of it:
Promise.all([
    page.waitForNavigation(),
    page.click(".some-link"),
    page.waitFor(5000)
  ]).then(() => page.type("input[type=email]", email, { delay: 50 }))

(I know the page.waitFor(5000) is not necessary but it's in a generic clickAndWait function because we have to deal with several redirects in other parts of our tests. This is not the case here but I let it for completeness sake)
Sometimes the type works, other times it doesn't because the page is not fully loaded.
Here is what I attempted to troubleshoot the problem:
Promise.all([
  page.waitForNavigation(),
  page.click(".some-link"),
  page.waitFor(5000)
]).then(() => page.$("input[type=email]"))
.then(input => {
  if (input === null) {
    return page.content().then(console.log)
  }
).then(() => page.type("input[type=email]", email, { delay: 50 }))

And here is the weird part, the console.log of the HTML was not consistent, we had either the full page loaded correctly or a shell of page with the <head> that was correct and the first two lines of the <body> but in both cases, the input was not found so I assume that the partially loaded page is the culprit.
Keep in mind that there was times where there was no problem and the input was typed into correctly. I don't have a reliable percentage of occurrences but it failed roughly 30 to 50% of the time.
I assume that we sometimes have the full page because page.content is asynchronous and sometimes the page had the time to load between the page.$ and the page.content.
What is the expected result?
page.waitForNavigation by default wait for the load event which means that the whole page should have loaded.
What happens instead?
In some cases, it seems to load before the whole page has loaded.

We ended up adding
  page.waitForSelector('input[type=email]', { visible: true, timeout: 0 })

before calling page.type which seems to work for now but it seems weird to do more waiting. The page should be loaded in those 5 seconds.
I'm really sorry to not have a reproducible error but I would be glad if somebody had ideas as to what happens and what to do.

If the page has some animation. It would be possible that the input is not ready on load.
I tend to use waitForSelector in these scenarios. There is nothing wrong with that.

Thanks for the input.
Yes that would be a scenario where I would find that normal too. But this is a plain web page, served by an elixir app without anything fancy. There is no lazy loading, no client javascript (no react/angular/vue or the like). The page is sent plain and simple.


Don't reset the H2 DB when it's at a non-standard path

When using a H2 JDBC address with a custom file path (not the default "%s"), the DB is always erased.
In the ConnectionFactory, such "jdbc:h2:file:" JDBC addresses are treated as a special case, to create the schema if the h2.db file is not found at the expected path (which is fine). The issue is that, when checking for existence of this file, its path is not extracted from the actual JDBC address, but assumed to be the default one, in the data directory.  Since there is no such file, the schema is re-created.
FYI, my use case for customizing this H2 JDBC address is to get a shared DB for Jenkins analysis.  I'm setting, in Jenkins global configuration, the H2 JDBC address to "jdbc:h2:file:~/something/blah;OPTIONS...", and this way I don't have to modify the data configuration in each job.

This commit will likely break Dependency-Track, and the Dependency-Check Jenkins plugin along with all other integrations that already use dependency-check in non-standard paths.
Why does the code not use Settings.getDataDirectory()? Many integrations specify the data directory this way.

I don't understand.  I'm sure you're rightly smelling some potential issues with this change that I will have overlooked, but I can't figure out what exactly.  Could you be more specific?
All I can see, so far, is an issue in the current ConnectionFactory code:

on the one hand it is possible to set an arbitrary H2 URL, and thus to choose an arbitrary name and location for the .h2.db file,
on the other hand, the decision to (re)initialize the H2 DB is made by checking existence of a .h2.db file specifically in the data directory, so basically assuming that the H2 URL has not been customized.

An other way to look at this issue is that, currently, the same logic to build the default H2 filepath (based on the data dir and db name) is duplicated in these two methods:

Settings.getConnectionString(String, String)
ConnectionFactory.h2DataFileExists()
...except that in Settings.getConnectionString it's only used if the URL happens to includes a %s place-holder, whereas in ConnectionFactory.h2DataFileExists it is used unconditionally.
My patch is an attempt at leaving Settings.getConnectionString() alone in charge of determining the actual JDBC URL, and making ConnectionFactory.h2DataFileExists() simply go with it and trust whatever filepath has been set or substituted in this URL.

As for my use case for hitting this issue, in case it was not clear, it is something like this:

I'm in Jenkins, using the plugin in version 1.4.3
I want to share my H2 database between different jobs, to save time/bandwidth (and obviously, I can configure the required locks / exclusions to make this viable)
one option would be to keep the default H2 URL (jdbc:h2:file:%s;SOMETHING) in the Jenkins global configuration, and to set the same data directory in each job configuration. It works fine, and the DB file is kept with its full contents at the end of a job execution, and then reused.  But it is not convenient to setup, because it implies repeating the same specific configuration (the data dir path) in every single job.
my other option would be to customize the H2 URL once for all in the global Jenkins configuration, with a fixed file path (for instance jdbc:h2:file:/home/jenkins/depcheck;SOMETHING), and voilà!  Except it doesn't work, because each time a JDBC connection is created, h2DataFileExists() decides the database is missing, so the schema gets re-created, and the next job has to reimport the complete NVD again.

Thanks for clarifying the issues you're running into and the proposed solution. I think I understand the issue and agree that setting up the data directory for each job can be a pain if you have a lot of jobs. I'm running into the same situation personally.
With this fix, it seems like you've corrected part of the issue. The data directory will still be created in the projects workspace (by default) however. So you'll have duplicate lucene indexes for every job.
Ideally, you'll want a global configuration in the Jenkins plugin to specify the data directory and then on a per-job basis have the option to override the global config if necessary. I've created a ticket for this and will include it in the next version of the Jenkins plugin.
https://issues.jenkins-ci.org/browse/JENKINS-38938

Thanks a lot Steve for JENKINS-38938. Now using a custom build of Jenkins dependency-check plugin 1.4.3 + your globalDataDirectory patch, and no more custom H2 JDBC URL. It works perfectly fine for my use-case.
I still think there is something to fix in dependency-check itself about ConnectionFactory.h2DataFileExists() making too much assumptions on the expected .h2.db file path, but I don't hit this bug anymore, thanks to your changes on the Jenkins plugin.

So you'll have duplicate lucene indexes for every job.

Actually, I've not yet seen any Lucene index files in the data directory...  On my Jenkins agents, in these directories, I've always only seen some .h2.db files (and sometimes the corresponding .trace.db files, in case of warning message), that's why I was assuming that me changing the H2 JDBC URL was enough to share the data between jobs.  But maybe it depends on some options or features I've not enabled?

@thomasgl-orange Glad it's working for you. I've been meaning to add that feature anyway, so this ticket provided motivation to actually get it done.
I'll let @jeremylong work the rest of this pull request.

@thomasgl-orange the lucene index is an in memory index that gets built during each execution.
As to the path in the connection string, yes I completely understand the concern, but if using the built in H2 database it is far better to use the --data to move the database to another location.


Move License information to make it easier to access

Currently the license is positioned at the bottom and it's hard to find it. So what do you think about moving it to the top and/or creating a license file in the repository itself?

I vote for license file and a link to it.

The advantage of license file is that GitHub understand it and shows in summary bar.

👍


Make Scrollable.ensureVisible document clearer that it would scroll all enclosing Scrollable

The current documentation for Scrollable.ensureVisible could be misunderstood as if it only scroll the closest Scrollable.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@nate-thegrate Can you take a look?


Update overview-of-the-upgrade-process.md

Added TIP to begin addressing #582.

@Techwriter40 Can I merge this?


loadingContext is missing in CoreOptions

Error: node_modules/@adyen/adyen-web/dist/types/core/Analytics/Analytics.d.ts:2:48 - error TS2344: Type '"amoun" | "loadingContext" | "locale" | "clientKey" | "analytics"' does not satisfy the constraint 'keyof CoreOptions.
Type '"loadingContext"' is not assignable to type 'keyof CoreOptions'.
2 export type AnalyticsProps = Pick<CoreOptions, 'loadingContext' | 'locale' | 'clientKey' | 'analytics' | 'amont'>;
As you can see on the error, there is a problem with the 'loadingContext' in the CoreOptions.
In your CoreOptions (../types/core/types.ts) 'loadingContext' is missing. Please add the attribute and fix your package.

Hi @david-eventfrog ,
Which version are you testing? It seems like we have the loadingContext defined in the CoreOptions object

Hi @ribeiroguilherme
I am using version 5.44.0.
And yes, I see you have loadingContext defined in your CoreOptions.
BUT: You have declared it as @internal, see here and set stripInternal to true in tsconfig.json. So the variable is not exposed and not available in your package.
You can find more information about this topic here.


Optimize package startup time

Minimize the main coffee file to speedup parsing and load all dependencies async during activation. This is especially relevant after PR #88 because it activates the package on atom startup.

Moving to https://github.com/Hackafe/atom-sync-settings/pull/97


feat: allow /ban to be used in multiple channels at once

example:
/ban --channel 11148817 --channel 117166826 forsen game complainer
this would ban forsen with the reason game complainer in the two
listed channels

In your example, you're using raw IDs but in other commands IDs have to be prefixed with id:. Could the same behaviour be used here to support both channel names & IDs? Keeps it consistent.
Also, are ---prefixed arguments used anywhere else? I don't have a better idea, but they feel very programmer-y which might feel weird to users.

-- prefixes are used in /openurl - I'm ok with them being a bit programmery since this use case is a bit programmery
I'm fine with --channel accepting the same type of input, e.g. 11148817 or pajlada


Just why?

why would someone go to the hassle of installing a mod instead of just opening a file and changing false to true?
like neither involve much effort, but that has to be so much slower.

Thanks for asking, This mod is not intended for server owners. It is aimed at developers who do server side dev. You can add this mod to your development environment (via build.gradle) and then anywhere your environment is spun up, you wont need to deal with eulas. Again this is not intended for server owners, as yes that makes no sense. Please see the readme.

That was pretty snarky of me, sorry.
The idea seems really neat, and in my limited experience with mod development seems pretty handy.
Cheers for the kinda and genuine response.


[UI] Change the toast notification message

Current Behavior

When we click on "undeploy" and try to undeploy a design in meshmap, we receive a toast notification about the design being "deployed"
https://github.com/user-attachments/assets/6a9bd97e-b823-4707-bbbc-e50940b8ba28
Expected Behavior

Since the design is being "undeployed", we would need a notification regarding the undeployment of the design. We can instead write the message like "Undeployed design 'name of the design' ".
Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I would like to solve this issue

Go ahead @102vansh 🚀

@102vansh any luck?

Hey @hargunkaur286 can I work on this issue?

Since we haven't heard back from @102vansh , I am assigning the issue to @Sumitsh28 . please go ahead 🚀

@hargunkaur286  I will do this if there are not any...

@hargunkaur286 , @theavitw I have started working on this issue

@hargunkaur286 how do i verify that on the backend it is getting undeployed.


POST Query breah details

💡 Summary
Add new REST endpoints that mirror existing sql queries and replace existing sql query with REST
Specifically: Convert "query_breachdetails_view)" TSQL query to an API endpoint
Motivation and context
There are two major reasons to use endpoints in place of sql queries.

Replace the need to know t-sql
Off load data aggregation to fastapi parallel workers

Implementation notes

Gather existing queries from code.
Create new endpoints at fastapi.
Secure new endpoints in same fashion as existing endpoint.

Acceptance criteria

[X] home/models.py model created
[X] dataAPI/schemas.py schema created
[X] dataAPI/views.py functions created
[X] dataAPI/tasks.py function created
[X] Verified endpoint is working

Endpoint has been implemented, integrated, and pushed to staging


DBeaver eclipse plugin automatically opens first project in Project Explorer list during startup

I've recognized that, probably caused by the DBeaver eclipse plugin, the first project in the Package Explorer project list is automatically opened during eclipse startup if it was closed before. Without DBeaver the project is not opened automatically.
I've tested this with a fresh setup (Eclipse + workspace) as well to exclude side effects by other plugins or a messed up workspace.
I've used the following versions for testing under Windows 10:

Eclipse Neon.2 Release (4.6.2) Build id: 20161208-0600 (Eclipse IDE for Java Developers package)
DBeaver 4.0.2 as eclipse plugin (core components only) installed using the Eclipse Marketplace
fresh workspace with 2 default/fresh gradle projects (using new gradle project wizard generating default test project)

It opens not the first but the active project. You can change current active project in DBeaver "Projects" view.
Active project is used to display contents of database navigator and project explorer views.

Thank you very much for the clarification, now I understand the behavior.
There is no way to turn this off, i.e. have no active DBeaver project at all, right?

Yes, I'm afraid so.

Thank you very much again. I've found a viable way for me to go along with my usage of projects and working sets: just create an empty eclipse project with no content in a separate working set and make this one the DBeaver active project when no other project requires DBeaver.

Yep, creating separate project for DBeaver makes sense.

I would like to request this behavior to be changed.
It would be nice if DBeaver would check if the active project is otherwise closed and do not attempt to open it. At least not until I change to the DBeaver perspective.
Should I file a separate bug report (as I consider this a bug) or should we keep this ticket for this purpose?


fixed typo in en-us.yaml translation

Typo in action: switchEnvironment fixed

Fixed already in https://github.com/rancher/ui/pull/691, thanks.


Fix bootstrap.sh

Add sudo prefix to aptitude commands.
Fix misspelled commands -qq to -q.
Remove invalid source command to unexistent path.

Coverage remained the same at 99.437% when pulling 458875df624f995c7dc460a5894f8b5f24b49313 on ignaciots:bootstrap-fix into 63abe5a5d6775573f15f5d188f17b4af2c30a12f on openfarmcc:master.

Hey @ignaciots, thanks so much for the PR!
I left a comment in Slack, but I'll repeat it here:
-qq is actually not a misspelling - it was a conscientious choice on my part. This doesn't mean it was a good choice, mind you, but it was on purpose :P. Adding more qs to -q quiets the logs to a higher level, from man:
-q, --quiet
           Quiet; produces output suitable for logging, omitting progress
           indicators. More q's will produce more quiet up to a maximum of 2.
           You can also use -q=# to set the quiet level, overriding the
           configuration file. Note that quiet level 2 implies -y; you should
           never use -qq without a no-action modifier such as -d, --print-uris
           or -s as APT may decide to do something you did not expect.
           Configuration Item: quiet.

As you can see there it's not recommended to use qq without other modifiers. What I was trying to achieve was a "seamless" installation that doesn't spit out lots of stuff related to all these things being installed that the developer might not care about. I can't quite remember what the level of logging of -q vs -qq is, and I'm curious if there's other solutions. None of the suggestions from the man make sense to me though. We want to execute the entire thing. Any thoughts?

Coverage remained the same at 99.437% when pulling c7bfae5488ca5ad871178b227c18614a9d33dfbb on ignaciots:bootstrap-fix into 63abe5a5d6775573f15f5d188f17b4af2c30a12f on openfarmcc:master.

Awesome, thanks for doing this!


Facing the same issue

Hi,
I am facing the same issue. Is there a work around to it?
Warm Regards
Tanjim

Thank you very much for testing this plugin.
In fact there is an error in documentation. The plugin name is in fact: geo_point_clustering.
I'm updating the documentation.


Update Insights Agent Helm chart link

Fixed link for Insights Agent Helm chart in README.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Explicit lodash dependency needed in package.json

cucumber_test_framework.ts file requires lodash but this dependency is not explicitly defined in package.json .
As I have a code that started off with grunt, I have lodash 0.9 that gets in the way :).

Well spotted, thanks @myukselen!


 Waiting to see what janky thinks about it.

CI has issues, we need to run the tests locally

@vdemeester @runcom @calavera @coolljt0725 fixed thank you

@tiborvass it looks like c.Warn does not exist:
docker_utils.go:1010: c.Warn undefined (type *check.C has no field or method Warn)

@tiborvass you need this patch:
diff --git c/integration-cli/docker_utils.go i/integration-cli/docker_utils.go
index 8aea980..581766d 100644
--- c/integration-cli/docker_utils.go
+++ i/integration-cli/docker_utils.go
@@ -785,7 +785,7 @@ func dockerCmdInDirWithTimeout(timeout time.Duration, path string, args ...strin
 func findContainerIP(c *check.C, id string, network string) string {
        out, _, err := dockerCmdWithError(c, "inspect", fmt.Sprintf("--format='{{ .NetworkSettings.Networks.%s.IPAddress }}'", network), id)
        if err != nil {
-               c.Warn(err)
+               c.Log(err)
        }
        return strings.Trim(out, " \r\n'")
 }
@@ -793,7 +793,7 @@ func findContainerIP(c *check.C, id string, network string) string {
 func (d *Daemon) findContainerIP(id string) string {
        out, err := d.Cmd("inspect", fmt.Sprintf("--format='{{ .NetworkSettings.Networks.bridge.IPAddress }}'"), id)
        if err != nil {
-               d.c.Warn(err)
+               d.c.Log(err)
        }
        return strings.TrimSpace(out)
 }

@calavera yes thank you I noticed it while rebasing :)

LGTM

putting merge label, since it already got okays in the pr this is carrying.

@tiborvass
docker_cli_links_test.go:140:
    c.Fatal(err)
... Error: failed to inspect container one: Template parsing error: template: :1:18: executing "" at <.NetworkSettings.IPA...>: IPAddress is not a field of struct type *types.NetworkSettings

@calavera fixed

changes LGTM. Let's wait for the CI to become green

@mrjana CI has issues, please test locally

LGTM. We're going to open a PR in docker-py to fix the functional suite.
Merging.

Ping @dnephin @aanand @shin- @abronan @vieux @aluzzardi this requires an API update.

@thaJeztah removing changelog, since it's part of the new networking feature which is already in the changelog.


mixin: grid

grid.scss use some sass functions that need to be implemented in javascript.
There is no library to fulfill this feature yet.

Landed in 37ae363 and a6eda71


No file/schema validation on data import

Describe the bug
When importing a csv file there is no validation on the schema file that os selected. you can select any type of file the tools will try to import and report no errors.
To Reproduce
Tab "Data Import" , Select CSV, select a txt file and continue
Expected behavior
File Schema validation and error
.

this issue has now been addressed by the make-open-source pull request


TimeArgument type could be more precise

Instead of number | LiteralUnion<'1t' | '1s' | '1d'>, it could be number | `${number}${'t' | 's' | 'd'}` (or something equally restrictive that still includes '1t', '1s', and '1d' as auto-complete options).

That's right! Didn't think about that. I'll change it.


Fixed Quickstart

The quickstart were outdated since the new version of create-near-app came out.

@bucanero I think the link checker is failing because I added a link in the sidebar to a new page, and is checking for the page on near.org instead of localhost, but otherwise it should work


stopped working

maybe the site has been updated and broke the script.

fixed, thanks for submitting the issue!


create a distribution dir with final compiled versions

the dist dir need to have:

source js
minified js
source map file

done


Rerun the landing zone procedure

turn off location restriction when running bootstrap.sh
delete existing org level services like
Access Context Manager - Access Level
and VPC Service Control - Access Policy
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/docs/google-cloud-security-controls.md#security---vpc-service-controls
temporarily turn off all experiments for terraform 1.0.10 for running in the gcloud shell under 1.3.7
set billing id of boot project to other than current billing if the 5 billing/project quota is not increased
set the prod cloud build trigger to disabled to keep new projects at 5
temporarily add owner to the TF service account

prereq
remove acm policy on common run
module.net-private-perimeter-firewall.google_compute_firewall.custom["allow-egress-internet-pr"]: Creation complete after 13s [id=projects/tzpe-tlz-tlz-perim/global/firewalls/tzpefwl-allow-egress-internet-pr-fwr]
module.net-private-perimeter-firewall.google_compute_firewall.custom["allow-ssh-ingress"]: Creation complete after 13s [id=projects/tzpe-tlz-tlz-perim/global/firewalls/tzpefwl-allow-ssh-ingress-fwr]
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│
│   on terraform.tf line 19, in terraform:
│   19:   experiments = [module_variable_optional_attrs]
│
│ Experimental features are subject to breaking changes in future minor or
│ patch releases, based on feedback.
│
│ If you have feedback on the design of this feature, please open a GitHub
│ issue to discuss it.
│
│ (and 23 more similar warnings elsewhere)
╵
╷
│ Error: Error creating AccessPolicy: googleapi: Error 409: Policy already exists with parent organizations/131880894992
│
│   with module.access-context-manager.google_access_context_manager_access_policy.access_policy[0],
│   on ../../modules/vpc-service-controls/main.tf line 19, in resource "google_access_context_manager_access_policy" "access_policy":
│   19: resource "google_access_context_manager_access_policy" "access_policy" {
│

delete vpc sc

add IAM role
https://cloud.google.com/access-context-manager/docs/manage-access-policy#delete
get ID from asset inventory under identity.AccessPolicy
Display name
[tspevsc_tlsacm_vsc](https://console.cloud.google.com/#)
Resource type
identity.accesscontextmanager.googleapis.com/AccessPolicy
Name
[//accesscontextmanager.googleapis.com/accessPolicies/1021375921638](https://console.cloud.google.com/#)
Organization
[organizations/131880894992](https://console.cloud.google.com/#)
Parent asset type
[cloudresourcemanager.googleapis.com/Organization](https://console.cloud.google.com/#)
Parent full resource name
[//cloudresourcemanager.googleapis.com/organizations/131880894992](https://console.cloud.google.com/#)

enable role, delete vpc sc

root_@cloudshell:~ (lz-tls)$ gcloud access-context-manager policies delete accessPolicies/1021375921638
You are about to delete policy [1021375921638]

Do you want to continue (Y/n)?  y
API [accesscontextmanager.googleapis.com] not enabled on project [308673020059]. Would you like to enable and retry (this will take a few minutes)? (y/N)?  y

Enabling service [accesscontextmanager.googleapis.com] on project [308673020059]...
Operation "operations/acat.p2-308673020059-bb01eee4-4f53-469f-987f-5179f0c8f6c6" finished successfully.
Deleted policy [1021375921638].

common ok

rerunning non-prod (2_folders is up now)
prod ok

prod - need to rename project - as deleted 30 day project still up after billing quota error earlier
Step #4 - "tf apply": │ Error: error creating project tzpe-tlz-tlzprod-host2 (TzPe-tlz-tlzprod-host2): googleapi: Error 409: Requested entity already exists, alreadyExists. If you received a 403 error, make sure you have the `roles/resourcemanager.projectCreator` permission
Step #4 - "tf apply": │
Step #4 - "tf apply": │   with module.net-host-prj.module.project.google_project.project,
Step #4 - "tf apply": │   on ../../modules/project/main.tf line 19, in resource "google_project" "project":
Step #4 - "tf apply": │   19: resource "google_project" "project" {

fix

prod_host_net = {
  user_defined_string            = "tlzprod" # Must be globally unique. Used to create project name
  additional_user_defined_string = "host3"#"host2"

root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (lz-tls)$ git status
On branch main
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   environments/prod/prod-network.auto.tfvars

no changes added to commit (use "git add" and/or "git commit -a")
root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (lz-tls)$ git add environments/
root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (lz-tls)$ git commit -m "new proj name for prod"
[main 6da67af] new proj name for prod
 1 file changed, 1 insertion(+), 1 deletion(-)
root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (lz-tls)$ git push csr main

prod ok

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


tagger_net.py

Hi, I'm trying to work on your codes but have a problem.
Basic informations are tensorflow : 1.8 (But I have tried 1.2, 0.12)
theano:0.82 (also tried 0.9)
keras: 1.1
The problem I'm having is the value error. ValueError: total size of new array must be unchanged.
It looks like dimension problem but can't solve it.
Using Theano backend.
/usr/local/lib/python2.7/dist-packages/h5py/init.py:34: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated. In future, it will be treated as np.float64 == np.dtype(float).type.
from ._conv import register_converters as _register_converters
Traceback (most recent call last):
File "quick_test.py", line 36, in
model = MusicTaggerCRNN(weights=None, input_tensor=(1, 96, 1366))
File "/home/lg/Downloads/Music-Genre-Classification-with-Deep-Learning-master/tagger_net.py", line 116, in MusicTaggerCRNN
x = Reshape((15, 128))(x)
File "/usr/local/lib/python2.7/dist-packages/keras/engine/topology.py", line 514, in call
self.add_inbound_node(inbound_layers, node_indices, tensor_indices)
File "/usr/local/lib/python2.7/dist-packages/keras/engine/topology.py", line 572, in add_inbound_node
Node.create_node(self, inbound_layers, node_indices, tensor_indices)
File "/usr/local/lib/python2.7/dist-packages/keras/engine/topology.py", line 152, in create_node
output_shapes = to_list(outbound_layer.get_output_shape_for(input_shapes[0]))
File "/usr/local/lib/python2.7/dist-packages/keras/layers/core.py", line 304, in get_output_shape_for
return (input_shape[0],) + self._fix_unknown_dimension(input_shape[1:], self.target_shape)
File "/usr/local/lib/python2.7/dist-packages/keras/layers/core.py", line 299, in _fix_unknown_dimension
raise ValueError(msg)
ValueError: total size of new array must be unchanged
Does anybody solve this problem?

I have same issue..

I have same issue. @simson1 I changed my keras.json to
{
"image_dim_ordering": "th",
"backend": "theano",
"floatx": "float32",
"epsilon": 1e-07
}
Before doing this, I did the change suggested in https://github.com/jsalbert/Music-Genre-Classification-with-Deep-Learning/issues/3#issuecomment-383325484 by @akhil1312
But I am still getting the same issue as stated above.


EDL CMX 3600 Adapter: Fix Source Out calculation when a TimeWarp retiming effect is present

Signed-off-by: Nikita Glukhov<EMAIL_ADDRESS>Link the Issue(s) this Pull Request is related to.
Fixes #1458
Summarize your change.
Fixed an error in calculating the Source Out timecode value.
The division is replaced by multiplication. Fixed math of clip length summation.

Can you please include a unit test?
Added.

Going to close and re-open to trigger CI

CI is failing for a reason that seems unrelated to this PR, I can't see the trailing whitespace. @ghost-luck @reinecke can you see it?
lists of files in version control and sdist match
check-manifest succeeded
./src/py-opentimelineio/opentimelineio/adapters/cmx_3600.py:1003:84: W291 trailing whitespace
make: *** [Makefile:159: lint] Error 1
Error: Process completed with exit code 2.

@ghost-luck So sorry to have lost track of this item. I've been doing a re-build of the CMX reader from scratch to address a collection of these kinds of issues. Would you be able to take a look at that branch and let me know if it addresses this issue?
When I ran your sample test case through my branch, I got this error:
E           AssertionError: 'TITL[19 chars]ARP\n\n001  B113RPTW V     C        00:32:02:0[100 chars]01\n' != 'TITL[19 chars]ARP\n001  B113RPTW V     C        00:32:02:06 [98 chars]01\n'
E             TITLE: SOURCE_OUT_TIMEWARP
E           -
E           - 001  B113RPTW V     C        00:32:02:06 00:32:06:20 01:34:53:09 01:34:57:13
E           ?                                                   ^^
E           + 001  B113RPTW V     C        00:32:02:06 00:32:06:19 01:34:53:09 01:34:57:13
E           ?                                                   ^^
E             M2   000001		26.4			00:32:02:06
E             * FROM CLIP NAME:  000001

tests/test_cmx_3600_adapter.py:1429: AssertionError

Is it possible this off-by-one is a rounding issue?


Show the derivative of the star history curve

Would it make sense to show the derivative of the star history curve? This corresponds to the acceleration of the curve (or acceleration) and would help spot the speed or slowdown of the number of stars on a repo.
Doing the difference between one point of the curve and the next one and showing this curve would probably make it too 🤔

Hi @Kerollmops, that's a good idea.
I have a PR where I'm trying to get a good trend line, I tried LOESS but I guess there must be something better.
I think for the acceleration I should use second derivative, curious to see how it looks like and if it's giving some indication.

@Kerollmops I've been working on adding some new data manipulation options, which I'm tentatively calling "transformations" for now. These include calculations for the first and second-order derivative.
To further enhance trend identification, I'm also exploring alternatives to LOESS. Splines might be a promising approach.
Running average now has a hardcoded 120 days size window, which might not be suitable for repos that have been created recently.
Any suggestion is welcome!

I tried the feature on the meilisearch repository and found it hard to understand what all those curves mean and how they can be interpreted. What could be fantastic is a small description of how to read the blue curve.
Also, a good explanation of how the running median/average work could be interesting because, as I understand it, it becomes unusable on the far right points of the graph. Because it will only average/median the 60 points on the left of it.

LOESS: What is it? How does it work?
Running Average: Does it mean that the mounts correspond to periods when you get a lot of stars?
Running Median: Is it the same as the average?
Derivative: Is it the speed or the acceleration? It seems to be the latter, but how can we see the speed?
Second Derivative: What does it correspond to? Is it the acceleration of the acceleration?

Thank you very much for the great soft!

Added the ability to select different ways to aggregate or calculate the original data, this include the derivative: https://github.com/emanuelef/daily-stars-explorer/blob/main/aggregate.md#derivative
I created a discussion https://github.com/emanuelef/daily-stars-explorer/discussions/102 so it's possible to make other suggestions.


Improve flexibility of column keys in generic parser

Allow multiple options for each column + other column rigidity options

Codecov Report

Merging #223 (9cf2256) into dev (fd45412) will increase coverage by 0.67%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##              dev     #223      +/-   ##
==========================================
+ Coverage   53.58%   54.25%   +0.67%
==========================================
  Files          57       57
  Lines        4130     4171      +41
==========================================
+ Hits         2213     2263      +50
+ Misses       1917     1908       -9

Impacted Files
Coverage Δ

sample_metadata/parser/generic_metadata_parser.py
74.77% <ø> (+2.67%)
:arrow_up:

sample_metadata/parser/generic_parser.py
74.65% <84.21%> (+0.82%)
:arrow_up:

sample_metadata/parser/sample_file_map_parser.py
70.00% <100.00%> (+1.57%)
:arrow_up:

test/test_parse_generic_metadata.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd45412...9cf2256. Read the comment docs.


To Do List

To Do list: list structure
In this first milestone, I:

Set up a new project with webpack
Created an index.html file
Set index.html as a template using the HTML Webpack Plugin
loaded CSS by Webpack Style/CSS Loader

Hello @rushemaa  I'm reviewing your Project but I don't know why you still commit on this PR , you are not allowed to push on this PR once being submitted :pray:

I am really sorry, I won't do it again

Hello @rushemaa I'm reviewing your Project but I don't know why you still commit on this PR , you are not allowed to push on this PR once being submitted 🙏

I am really sorry, I won't do it again