[ Bug ] Showing one Inhibitor Side, shows both instad

Describe the bug
Whenever I use Show Red Inhib or Show Blue inhib, instead it inserts the "Both" class to show both inhibitor sides.
To Reproduce
Show one side of inhibs
Expected behavior
Only one side is shown in whole window
Screenshots

System:

OS: Windows 10
Node: 8.13.2
Prod Tool Version: 1.4.1
Observer Tool Version: 5.0.0
Streaming Software & Version: OBS
Browser: Chrome

Additional context
I tried using the red and blue class and whenever modified, it instanty changes back to both

And then:

I am unable to reproduce this on my side.
Have you made any modifications to the ingame module in code/through a theme?
Could you double-check your node version? (I assume what you listed is the npm version but just making sure)

Here is the theme I use:
:root {
    --blue-team: #029ef7;
    --blue-team-dark: hsl(202, 98%, 40%);
    --blue: #029ef7;
    --blue-dark: hsl(202, 98%, 40%);
    --red-team: #ff5a64;
    --red: #ff5a64;
    --red-dark: hsl(356, 100%, 59%);
    --red-team-dark: hsl(356, 100%, 59%);
    --accent-color: #d8ef5e;
    --text-color: #fafafa;
    --background-color: #051c2c;
    --primary-font-family: monospace;
    --secondary-font-family: sans-serif;
    --logo-path: url(/pages/op-themeing/active/logo.png);
}
.sb-blue {
  background: linear-gradient(90deg, var(--blue-team-dark) 0%, var(--background-color) 26%, var(--background-color) 100%)!important;

  .sb-team-info {
    color: var(--blue-team);
  }
  .sb-stat {
    color: var(--blue-dark)!important;
  }
}
.sb-red {
  background: linear-gradient(90deg, var(--background-color) 0%, var(--background-color) 74%, var(--red-team-dark) 100%)!important;

  .sb-team-info {
    color: var(--red-team);
    padding: 5px 20px 0 0px!important;
  }
  .sb-stat {
    color: var(--red-dark)!important;
  }
}
.sb-kills-blue {
  color: var(--blue-dark)!important;
  margin-bottom: 5px;
}
.sb-kills-red {
  color: var(--red-dark)!important;
  margin-bottom: 5px;
}

.sb-kills {
  background: var(--background-color)!important;
}

.sb-team {
  font-size: 20px;
}

.sb-red.power-play {
  padding-left: 10px!important;
}
.sb-blue.power-play  {
  padding-right: 10px!important;
}
.power-play.baron {
  background: rgb(101,0,246)!important;
  background: linear-gradient(90deg, rgba(101,0,246,1) 0%, rgba(121,9,91,1) 52%, rgba(169,0,255,1) 100%)!important;
}

.power-play {

    .timer {
        font-size: 25px;
    }
    .pp-box {
      h1 {
        font-size: 25px;
        letter-spacing: 0px!important;
      }
      h3 {
        font-size: 25px;
      }
    }
}

Sorry about the node version, it seems it has recently updated: v16.15.1

Is this a standard installation of the toolkit using the release build? I am unable to reproduce this on a fresh install using your theme.
Its worth noting we develop/test on node 16.7 (although I couldn't reproduce the issue with 16.15.1 either).

I am using the fresh install with latest module updates.
I will retest this issue with another replay and see if it happens again.
El lun, 6 mar 2023 17:24, Dominik @.***> escribió:

Is this a standard installation of the toolkit using the release build? I
am unable to reproduce this on a fresh install using your theme.
Its worth noting we develop/test on node 16.7 (although I couldn't
reproduce the issue with 16.15.1 either).
—
Reply to this email directly, view it on GitHub
https://github.com/RCVolus/league-prod-toolkit/issues/252#issuecomment-1456447703,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI2UUOLJXHYV5AVIKAOBIH3W2YFTTANCNFSM6AAAAAAVQGKKLQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

No need to retest, I have found the issue. It only occurs when Farsight is synced.

Okay. I will wait for the fix then. Thanks.

with the newest patch of the ingame module 4.0.2, this issue will be fixed.


[enhancement] Add missing bower.json.

Hey, maintainer(s) of typekit/webfontloader!
We at VersionEye are working hard to keep up the quality of the bower's registry.
We just finished our initial analysis of the quality of the Bower.io registry:
7530 - registered packages, 224 of them doesnt exists anymore;
We analysed 7306  existing packages and  1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).
Sadly, your library typekit/webfontloader is one of them.
Can you spare 15 minutes to help us to make Bower better?
Just add a new file bower.json and  change attributes.
{
  "name": "typekit/webfontloader",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.
NB! Please validate your bower.json with jsonlint before commiting your updates.
Thank you!
Timo,
twitter: @versioneye
email<EMAIL_ADDRESS>VersionEye - no more legacy software!

Would be nice to reconsider bower publish

The Web Font Loader is available on NPM, so you don't need bower.

I thought npm was dedicated to node modules only?
Wouldn't this decision make things difficult for users maintaining their web packages through bower?
A case example:
User having

/package.json defining test/build and deployment dependencies in order to generate output directory.
/bower.json defining web app dependencies which will be installed into src/vendor directory

Structure:
.
├── bower.json
├── package.json
├── node_modules
└── src
    └── vendor

Wouldn't this mean that if I also need node-only packages available at node_modules and not under src/vendor I then wouldn't be able to install webfontloader throught npm in this case since it would be installed under node_modules and not src/vendor as with other browser related packages?

+1 for having bower install option.  It's dead simple to add the config and gives developers the ability to leverage whatever package installer they already have setup with their dev ecosystem.  What's the reason to not use bower?

@bramstein I would also appreciate this on bower, I use bower for frontend resources, and, npm for gulp things.
I did once try just using NPM instead of bower, but, I found it very unhelpful. When using NPM only, you can't do any sort of logic in the package.json because it's json.
I do hope you change your mind,
Many thanks


Append pV tag to grafana view

Is your feature request related to a problem? Please describe.
Currently you need to name the processValues like this "laser1distance", to be able to differentiate between different sensors on an asset.
Describe the solution you'd like
Our stack already partly supports using an tag after the processValue inside the topic name (ia/factoryinsight/testLocation/testMachine/processValue/laser1distance).
This should be extended, so that grafana shows:
process_TAG_Name
Example:
msg.payload = {
    "timestamp_ms": Date.now(),
    "laser1distance": parseInt(msg.payload)
}
msg.topic = "ia/factoryinsight/testLocation/testMachine/processValue/abc"
return msg;

Should be process_abc_laser1distance

Maybe also split it in the Grafana view to have a selector for Location, Asset, Value (but value only shows processValue)
If pV is selected show a selector for Tag and name

let's combine it with the historian work stream of @DaruZero and discuss potential other implementations. let's call this feature also "grouping tag values"
The current approach is not ideal if you want to use a processValue/XXX topic without using a group


Fix for collection name

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 5 (20.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 66.201%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utilities/prepareExport.ts
0
1
0.0%

src/utilities/getVariables.ts
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
496

Relevant Lines:
734

💛  - Coveralls


Add validation support

Adds validate method to wasm export
allows for validation to run for a policy and schema, returning the results as json

Hey @JoshuaWilkes! Thanks for opening this PR, is it possible to use your addition? Indeed, I think this is a great addition to cedar-go :+1:

Hey, certainly, I opened this PR up prematurely as I was testing the functionality in our app.
Thanks for kicking off this project 👍
I don't normally work in rust, so was trying to find the best way to extract the information from ValidationResponse, hence the use of some additional structs.
My understanding is that the default ValidationResponse struct is not json serialisable, however if it is, then this PR could be simplified

Yes, that is the only solution to handle this as ValidationResponse doesn't implement json traits. I'll cherry pick some stuff in this PR to enhance this binding.


Webeditor styling and example loading fix

Fixes loading of examples in the editor only after clicking into it.
Fixes the style of the editor no being applied without loading an example.
Updates the CodeMirror dependency.

I took the freedom to delete the unused file editor.js and renamed the existing and used editor2.js to editor.js.
fixes #1030 (maybe more, but quick look over issues did not bring anything to my attention)

@NilsKrause thanks for the fixes! i'll try these out this weekend.

Don't worry about 'additional' work 😄  it really isn't much and you're absolutely right. I didn't notice them on my mac, but in your screenshot it's not very aesthetic.
I'll look into it on the weekend.
If there are any more webeditor related issues we could include in the PR let me know.

This might be a question for @z3dev but we have almost-duplicate code in packages/web/css/editor.css and packages/web/css/codemirror.css I wonder what the difference is? Is one dead code? Both seem to be referenced in different places.
Also, does the CSS need to be updated at the same time as the codemirror js version?

This might be a question for @z3dev but we have almost-duplicate code in packages/web/css/editor.css and packages/web/css/codemirror.css I wonder what the difference is? Is one dead code? Both seem to be referenced in different places.

The whole CSS needs a review, pruning, and improving. There’s probably a lot of junk left over from V1.

Also, does the CSS need to be updated at the same time as the codemirror js version?

I would suspect so, as that was the original as provided with CodeMirror.

Tested the new changes locally, and can confirm that it fixed the scrollbar issue on linux. Cleaning up the duplicated code looks good to me too.
Thanks for a killer first contribution @NilsKrause !


Issues opening data frames in Variable Explorer

I get this error when trying to open a data frame.
Must be due to the data structure in the file as I generally have no issue, but it's difficult to figure out what exactly is the problem.
Let me know how to help narrowing it down.
Note: Changed the true data values to xxx for data privacy reasons.
Here is the error:
Error: Failure during variable extraction: --------------------------------------------------------------------------- JSONDecodeError Traceback (most recent call last) ~/analytics/consolidatedCRM/consolidatedCRM/py_modules/formstack_client.py in  9 # In IJupyterVariables.getValue this '{"count":527,"name":"answers_data","shape":"(527, 6)","size":0,"supportsDataExplorer":true,"truncated":true,"type":"DataFrame","value":"form_name question_1 \\n 0 Care_Kit_FR first = xxx\\nlast <...>\n 72 address = xxx\\ncity = xxx... xxx\n "}' will be replaced with the json stringified value of the target variable 10 # Indexes off of _VSCODE_targetVariable need to index types that are part of IJupyterVariable ---> 11 _VSCODE_targetVariable = _VSCODE_json.loads("""{"count":527,"name":"answers_data","shape":"(527, 6)","size":0,"supportsDataExplorer":true,...

I think this issue needs to be raised at https://github.com/microsoft/vscode-python


Unable to add Datasource projects and Dataservice projects under Multi-module maven project

Description:
Unable to add Datasource projects and Data service projects under Multi-module maven project
Affected Product Version:
7.0.2 RC2
OS, DB, other environment details and versions:
Windows
Steps to reproduce:

Create a multi-module maven project.
Create a Data source project. In the wizard, select created multi-module maven project above.
When click finished, no project is created !!

We tested the above scenario in Mac, Windows and Linux platforms. but could not able to reproduce the issue. Hence, close this issue.


adding first rules draft for llama2_70b_lora

Thanks @itayhubara . Can you also include a row for lora in Section 12 for number of runs required.

I think it is ready to merge


Why not submit to Go standard library?

I think the answer should be added into readme.

Really great question, one about which I've thought quite a bit.
My actual reason for not doing so is inertia, and I have no idea how much energy it would take to work through the red tape of submitting a change to Go standard library, only to have it rejected because reason X.
godirwalk has a different API than the Go standard library directory walk function. If I submitted something, it would have to sit alongside the other library, awkwardly next to it. And I would not be happy unless I structured the update to vastly improve the performance of both the standard library, and the new library call, while obviously only the new call would be able to realize all of the benefits, because in the end there are differences between both approaches. This amount of work is unbounded.
Along with these unknowns, I have a lot of unfinished work I personally want to complete on another open source library I am trying to find time to work on.


Loophole doesn't reconnect after a network outage

My wireless network connection is occasionally disrupted. Whenever this happens, Loophole attempts to reconnect 5 times and then quits.
Instead of quitting when the network goes down, should Loophole stay open and attempt to reconnect when the network is available again?

Hi @jarble we have a hard-coded retry count here: https://github.com/loophole/cli/blob/06767ef30bebf6095f1d93f6552d4727cc7ce241/internal/app/loophole/loophole.go#L102-L120 We could either always make it retry forever, or make the retry configurable via cli argument. @Morishiri what would you prefer?

let's make it configurable via cli

@Morishiri and @0x7f Is it configurable now? I think it should be "infinity" by default.

Hello, will this be a thing?
My network is also a little unstable, and sometimes it disconnects in the middle of the night, then for me find out just in the morning it was down for several hours.


DPGlobal.parseDate fails for Peruvian culture

As the Peruvian culture has rather strange designators for Meridian (a. m. and p. m.), the library internals fail to parse manually written datetime:
E.g. 25/01/2016 01:00 P. M. is not parsed as a valid date, as there is no matching part in case of the corresponding pattern d/mm/yyyy H:ii P because the part P standing for meridian designator is not matched with parts of the date as parts are parsed in a way that instead of last part being P. M. it has two parts: P and M.
That is caused by matching the regex nonpunctuation (/[^ -\/:-@\[-`{-~\t\n\rTZ]+/g).

Would you mind filing a PR for this? :)

I'm currently trying to find a fix...
Fri, 5 Feb 2016 v 12:36 odesílatel vaas<EMAIL_ADDRESS>napsal:

Would you mind filing a PR for this? :)
—
Reply to this email directly or view it on GitHub
https://github.com/smalot/bootstrap-datetimepicker/issues/488#issuecomment-180309619
.

+            var designatorMatch = dates[language].meridiem[1].match(this.nonpunctuation);
 +            var crazyDesignator = designatorMatch && designatorMatch.length > 1;
 +            var crazyDesignatorFound = null;
 +            if (crazyDesignator) {
 +                _.each(dates[language].meridiem, function(designator, idx) {
 +                    if (date.toLowerCase().indexOf(designator.toLowerCase()) > -1) {
 +                        date = date.replace(designator.toLowerCase(), '');
 +                        date = date.replace(designator.toUpperCase(), '');
 +                        crazyDesignatorFound = idx;
 +                        format.parts = _.without(format.parts, 'P', 'p');
 +                    }
 +                });
 +            }

-                var meridian = Math.max(format.parts.indexOf("P"), format.parts.indexOf("p"))
 -                if (meridian != -1) {
 -                    if (parts[meridian].toLowerCase() == dates[language].meridiem[1].toLowerCase()) {
 +                var meridian = Math.max(format.parts.indexOf("P"), format.parts.indexOf("p"));
 +                if (meridian != -1 || crazyDesignatorFound === 1) {
 +                    if (crazyDesignatorFound === 1 || parts[meridian].toLowerCase() == dates[language].meridiem[1].toLowerCase()) {
                          date.setTime(date.getTime() + (12 * 60 * 60 * 1000));
                      }
                  }

This is my patch so far. If the solution seems OK-ish to you, I can file a PR on the latest version of the lib.


Please sign releases

Please sign each release, so we can know provenance of future releases, and help protect against malicious updates.

@ben-willow
Can you point to any case of malicious updates ?

It's common sense to install only signed packages. I may even be company policy and would increase acceptance. Don't wait for a malicious update to happen. Prevent it in the first place.

For non Eclipse foundation plugins, I know only @jeeeyul Lee signing.
And that only creates additional questions asked to user
(while for Eclipse signed binaries there's no question asked)

I agree this is common sense but I am unsure how to implement it. I've read through https://wiki.eclipse.org/JAR_Signing but this does not provide any advice for 3rd-party plugin authors. Nor did I find any advice when quickly searching through "Mastering Eclipse Plug-in Development" and "Eclipse Plug-ins, Third Edition". Any advice on how this should work.

@ncjones Nathan, you can ask @jeeeyul
but I would suggest not to spend time on this

+1


merge rigid types in TyKind into a single variant.

Proposal
Incrementally work towards merging all variants which are rigid type constructors with the goal of having the following final enum:
enum RigidTy<'tcx> {
    Bool,
    Char,
    // ...
}

enum TyKind<'tcx> {
    Rigid(RigidTy<'tcx>, SubstsRef<'tcx>),
    /// We can keep `Projection` and `Opaque` separate for now.
    Alias(AliasTy<'tcx>, SubstsRef<'tcx>),
    Infer(...),
    Placeholder(...),
    Bound(...),
    Error(...),
}

This greatly simplifies type relations and makes it easier to use a TypeFolder for generalization, as getting variance right will be a lot easier by adding a method fn RigidTy::variances(self) -> &'tcx [ty::Variance] which we then use to relate the SubstsRef.
It should have a minimal (potentially even positive) impact on performance and a noticeable impact on readability.
Mentors or Reviewers
I am up to mentor and review this work.
Process
The main points of the Major Change Process are as follows:

[x] File an issue describing the proposal.
[ ] A types team member or contributor who is knowledgeable in the area can second by writing @rustbot second.

Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
Types team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.

[ ] Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

closing this due to concerns over perf https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/merge.20rigid.20types.20in.20.60TyKind.60.20into.20a.20single.20v.E2.80.A6.20types-team.2364


Dovecot locking issues on Kubernetes

Hi All
Have managed to get a mailserver container running with ingress on my AKS instance but am receiving errors like the following when the IMAP client connects to the service:

imap(user@domain.net)<7245><**************>: Error: Mailbox INBOX: Failed to autocreate mailbox: Internal error occurred. Refer to server log for more information. [2023-11-13 16:01:01]

Nov 13 16:01:01 mail dovecot: imap(user@domain.net)<7245><**************>: Error: Couldn't create mailbox list lock /var/mail/domain.net/{user}/mailboxes.lock: file_create_locked(/var/mail/domain.net/user/mailboxes.lock) failed: link(/var/mail/domain.net/user/mailboxes.lockcf866fd722cae35e, /var/mail/domain.net/user/mailboxes.lock) failed: Operation not supported

Nov 13 16:01:01 mail dovecot: imap(user@domain.net)<7245><**************>: Error: Mailbox Drafts: Failed to autocreate mailbox: Internal error occurred. Refer to server log for more information. [2023-11-13 16:01:01]

I am using SMB 3.0 mount with the following parameters for the mail data directory
:
mountOptions:

dir_mode=0777
file_mode=0777
username={{ .Values.userName }}
password={{ .Values.storageAccountKey }}
mfsymlinks
nobrl
vers=3.0
serverino

Is there by any chance a requirement that dovecot needs to have an NFS volume mount and this might be what's causing the issue? I am in a little uncharted territory here.
Any input would be most welcome. I'd love to get this up and running for my deployment.

Could you try the latest chart. By default config files are stored on a Volume which would be mounted as ReadWriteOnce.

Going to close this - reopen if you still have issues with the new chart.


Block Library Export

In factory.js
Created Block Library Export Namespace, which contains getBlockDefs function and the getGeneratorCode function.

getBlockDefs returns the language code for multiple blocks, given the list of block types of interest and the desired format.
getGeneratorCode returns the generator stubs for multiple blocks, given the list of block types of interest and the desired language.

In order to build upon Block Factory's infrastructure, Block Factory Export has its own preview and main workspaces that are used in getBlockDefs and in getGeneratorCode.
in index.html

houses the hidden divs that hold the export workspaces.

This change is

@vicng @picklesrus @evd2014
Let me know if in a separate CL, I should turn the Export into a class rather than have it as a namespace. I also know i have a TODO in there in regards to injecting the export workspaces--considering having that within the constructor of the Export class, where parameters would be the id's of the div in which we inject the workspace.
Thanks!

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.

demos/blockfactory/factory.js, line 912 [r1] (raw file):

 * Saves block to block library.
 *
 * @param {string} blockType - name of block

If this is really the name of the block, not the type, the variable name should probably be changed to blockName. Same for removeBlock below.

demos/blockfactory/factory.js, line 1066 [r1] (raw file):

 * @type {Blockly.Workspace}
 */
BlockLibrary.Export.mainWorkspace = null;

I wonder if a different variable name would be useful.  You already have a mainWorkspace above (different namespace I know),  but I still got confused for a moment.
Maybe:
blockBuilderWorkspace
previewWorkspace
exporterWorkspace?
Except, I forget what your demo looks like so am having a hard time remembering what the exporter workspace is for.  Would you show me again?

demos/blockfactory/factory.js, line 1145 [r1] (raw file):

 * @return {string} generator code for multiple blocks.
 */
BlockLibrary.Export.updateGenerator = function(block, generatorLanguage){

This is pretty close to the code in the updateGenerator function above.  Is there a reason not to use that one?

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 5 unresolved discussions.

demos/blockfactory/factory.js, line 1066 [r1] (raw file):

 * @type {Blockly.Workspace}
 */
BlockLibrary.Export.mainWorkspace = null;

You're right in that Export should be a class and not a namespace.
Objects first, static methods second, global variables almost never! :)

demos/blockfactory/factory.js, line 1083 [r1] (raw file):

 * language code.
 */
BlockLibrary.Export.getBlockDefs = function(blockTypes, definitionFormat) {

Are the 2 methods below supposed to replace something from above? The code that is being replaced should be deleted within this CL too. It makes it easier for us to see what is refactored code and what is new code.

Comments from Reviewable

demos/blockfactory/factory.js, line 1145 [r1] (raw file):
Previously, picklesrus wrote…
> This is pretty close to the code in the updateGenerator function above.  Is there a reason not to use that one?

the updateGenerator code  injects the code into the generator preview text area whereas I just want it
called at the end of it, but I can move it out so that I can reuse the updateGenerator function.
does that sound good?

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 5 unresolved discussions.

demos/blockfactory/factory.js, line 912 [r1] (raw file):
Previously, picklesrus wrote…
> If this is really the name of the block, not the type, the variable name should probably be changed to blockName. Same for removeBlock below.

changed from name of block to type of block. block name and block type are synonymous, but in the code i've been using block type since we are literally looking at the block's type.

demos/blockfactory/factory.js, line 1066 [r1] (raw file):
Previously, picklesrus wrote…
> I wonder if a different variable name would be useful.  You already have a mainWorkspace above (different namespace I know),  but I still got confused for a moment.
>
> Maybe:
> blockBuilderWorkspace
> previewWorkspace
> exporterWorkspace?
>
> Except, I forget what your demo looks like so am having a hard time remembering what the exporter workspace is for.  Would you show me again?
>
>

yes, the exporter has its own main and own preview workspaces so that the xml stored in the block library can go through the same pipeline to generate the block definitions and generator stubs for the blocks selected for export.
I call it Export.mainWorkspace because it is a parallel that of the blockfactory main workspace.

demos/blockfactory/factory.js, line 1083 [r1] (raw file):
Previously, vicng wrote…
> Are the 2 methods below supposed to replace something from above? The code that is being replaced should be deleted within this CL too. It makes it easier for us to see what is refactored code and what is new code.

No, they aren't supposed to replace code from above.

Comments from Reviewable

demos/blockfactory/factory.js, line 1066 [r1] (raw file):
Previously, vicng wrote…
> You're right in that Export should be a class and not a namespace.
>
> Objects first, static methods second, global variables almost never! :)

done~

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 5 unresolved discussions.

demos/blockfactory/factory.js, line 1066 [r1] (raw file):
Previously, quachtina96 (Tina Quach) wrote…
> done~

Is it possible to create a workspace without a hidden div or by creating a hidden div inside the exporter and using that? It'd be ideal if the Controller could just create an Exporter and not have to worry about specifying a hidden div.

demos/blockfactory/factory.js, line 1083 [r1] (raw file):
Previously, quachtina96 (Tina Quach) wrote…
> No, they aren't supposed to replace code from above.

Will the above code eventually get deleted? This method is very similar to updateLanguage(), so I assume that will go away eventually.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 5 unresolved discussions.

demos/blockfactory/factory.js, line 912 [r1] (raw file):
Previously, quachtina96 (Tina Quach) wrote…
> changed from name of block to type of block. block name and block type are synonymous, but in the code i've been using block type since we are literally looking at the block's type.

Done.

demos/blockfactory/factory.js, line 1066 [r1] (raw file):
Previously, vicng wrote…
> Is it possible to create a workspace without a hidden div or by creating a hidden div inside the exporter and using that? It'd be ideal if the Controller could just create an Exporter and not have to worry about specifying a hidden div.

done in next CL

demos/blockfactory/factory.js, line 1066 [r1] (raw file):
Previously, quachtina96 (Tina Quach) wrote…
> yes, the exporter has its own main and own preview workspaces so that the xml stored in the block library can go through the same pipeline to generate the block definitions and generator stubs for the blocks selected for export.
>
> I call it Export.mainWorkspace because it is a parallel that of the blockfactory main workspace.

Done.

demos/blockfactory/factory.js, line 1083 [r1] (raw file):
Previously, vicng wrote…
> Will the above code eventually get deleted? This method is very similar to updateLanguage(), so I assume that will go away eventually.

created getBlockDef function from update

demos/blockfactory/factory.js, line 1145 [r1] (raw file):
Previously, quachtina96 (Tina Quach) wrote…
> the updateGenerator code  injects the code into the generator preview text area whereas I just want it
> called at the end of it, but I can move it out so that I can reuse the updateGenerator function.
>
> does that sound good?

created getGeneratorStub function that is shared by export  & factory.js

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


Intel CAVS: log missing of tests/lib/p4workq/

Describe the bug
tests/lib/p4workq/ has 4 test functions
test_p4wq_simple
test_resubmit
test_fill_queue
test_stress

On Intel CAVS platform, we lost the log of test_resubmit and test_fill_queue
To Reproduce
Steps to reproduce the behavior:

twister -W -p intel_adsp_cavs15 --device-testing --device-serial-pty=$HOME/zephyrproject/zephyr/soc/xtensa/intel_adsp/tools/cavstwist.sh --west-flash=$HOME/zephyrproject/zephyr/soc/xtensa/intel_adsp/tools/cavstwist.sh -T tests/lib/p4workq/ -vv

Expected behavior
We should have intact log of test functions.
Logs and console output
Running TESTSUITE lib_p4wq_test
===================================================================
START - test_p4wq_simple
PASS - test_p4wq_simple in 0.15 seconds
===================================================================
START - test_resubmit
priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
W: Out of worker threads, priority guarantee violated
PASS - test_stress in 0.211 seconds
===================================================================
TESTSUITE lib_p4wq_test succeeded
===================================================================
RunID: 2cd902de93d17fdc88b6c7949b8f76f8
PROJECT EXECUTION SUCCESSFUL

Environment (please complete the following information):

OS: Linux
Toolchain 0.14.1
Commit d78194546746

the warning log message above is flooding the buffer, if you remove it, you get the expected output, this is the same bug we have seen before with the memory window not able to handle message floods...
Running TESTSUITE lib_p4wq_test
===================================================================
START - test_p4wq_simple
 PASS - test_p4wq_simple in 0.15 seconds
===================================================================
START - test_resubmit
 PASS - test_resubmit in 0.101 seconds
===================================================================
START - test_fill_queue
 PASS - test_fill_queue in 0.3 seconds
===================================================================
START - test_stress
 PASS - test_stress in 0.111 seconds
===================================================================
TESTSUITE lib_p4wq_test succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

not related to twister, it is a logging backend issue of ADSP.


Does the package update the app or simply tell if an update is available?

it will just tell update available or actually update the app ?

Hello, @Faizi-Apps.
As it is written in the documentation, this package only provides the bare-minimum to tell if there is any update available. It doesn't do the update, nor provide any screen or anything. It will simply return the info regarding an availability or not of an update.

OK, thanks


NodeMCU support?

Hi,
I'm pretty new to microprocessor development. I have a NodeMCU board, however, it doesn't seem to work with Arduino-Lufa. It's ESP-12/ESP8266-based, and with that being a different architecture, compiling this software for that board without extensive modification is out of the question, correct? Or am I missing something? My Arduino IDE can compile other Arduino software onto my NodeMCU just fine.
Thanks!

Short answer: never.
Long answer:
NodeMCU use ESP8266, which is a total different architecture (xtensa32) than AVR.
LUFA utilize hardware support exists in the MCU, only a few models supports it.
There is no hardware USB facilities on ESP8266 (nor ESP32), even if it does, the register and behaviors would be very different than the ones on AVR.
LUFA will probably never supports MCUs not found in this list, thus this project.
For other AVR MCUs, you can bet on the VUSB project.
For esp8266, it's actually pretty interesting, I once wanted to hack out a software USB stack (borrowing codes from VUSB), but never really got it working.
Maybe I'll release the corpse project someday in the future when I have some free time, but it's not for newbie (not going to be a clone-the-repo-and-it-works project), anyway.

Thanks for the info. I ended up buying a Teensy++ 2.0, and since that has an AVR chip, LUFA is working great!


Invalid request line for RqFake

The first request line in RqFake is not correct. According to RFC2616 the request line should be:
Request-Line   = Method SP Request-URI SP HTTP-Version CRLF

But new RqFake() returns: GET / ("Method SP Request-URI CRLF"), it means HTTP-Version component is missing. The correct default request line could be: GET / HTTP/1.1 or any other valid request line.

@paulodamaso/z please, pay attention to this issue

@0crat in

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

@baudoliver7/z resigned from #1024, since the job is not in scope anymore


function keyword arguments (kwargs) implementation

This PR implements keyword arguments on functions.

Hi, I am on holiday now, I will check this PR in July.

Hi, changes are significant and I cannot add a nice-to-have feature with that much change. I could only review it with a minimal amount of breaking changes.


Chromium/Firefox Browser Enhancement

Hello i saw you start adding some of the games from the list i give you in the script thank you.
Can you include flash player plugin also to be installed by default with chromium browser and firefox-esr browser ?
Thank you

If it helps the command to install flash for chrome is sudo rpi-chromium-mods for firefox i dont know it
Thank you

rpi-chromium-mods is the package that needs to be installed for Chromium to play Flash, you're saying?

Yes its includes flash player and an adblocker.


try to keep the old row and column selected when setting items

Hey, don't have time to do much iteration on this so feel free to aggressively reject or modify all you like.
I made these changes to the library to support a TUI that I am working on.  When set_items() gets called, it will try to preserve the currently selected row/column indices. Out-of-bounds columns just deselect all columns, out-of-bounds rows will reset to zero.

Thanks for the work! The current version should not have this issue.


Elevate Privs to load TLS Session Ticket key file

I would recommend not making PRs from your private master branch. Better to make a branch off master, and put that new branch to your private remote.


Fix array index out of bound when encoding

What problem does this PR solve?
fix https://github.com/pingcap/tispark/issues/1959
Fix array IndexOutOfBound when decoding using RowEncoderV2.
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

/run-all-tests


Add consul_agent to the api_z1 job in the example manifest stub

We noticed that the consul_agent is missing from the api_z1 job in the example stub at https://docs.cloudfoundry.org/deploying/openstack/cf-stub.html. Without it the api VM won't come up properly.
I also noticed that java-buildpack and java-offline-buildpack are missing and cloud_controller_clock  and cloud_controller_worker were added compared to the default values. Are those changes still supposed to be there?

Thanks for the contribution!
Chunyi & @APShirley


pkg/profile: Replace gzip package to reduce allocs

A drop-in replacement for gzip has impressively low allocs with decent speed/compression https://github.com/klauspost/compress/pull/216.

Just deployed this on the demo cluster, and I'm happy to report that this got us a healthy ~20% decrease in CPU usage, nice job, and thank you very much!

I'm especially impressed that this didn't need any pooling of byte buffers, just the replacement 🤯

Awesome! I am glad the change made a positive impact.


Datetime picker dissapears on navigation click

Describe the bug
Whenever navigating through the dates in the datetime picker component, it auto closes.
To Reproduce
Steps to reproduce the behavior:

Open the datetime picker
Click anywhere

Expected behavior
Just like the demo page here, it should be able to navigate through the dates.
Screenshots
If applicable, add screenshots to help explain your problem.
https://user-images.githubusercontent.com/8738094/128228916-bfefabcf-aed6-4ed6-b2bf-fd862d7c4e79.mp4
<x-datetime-picker                             without-time                             label="Birthday"                             display-format="DD-MM-YYYY"                             parse-format="YYYY-MM-DD"                             wire:model="personalCard.birthday"                         />
It's also worth noting that it also has the same behaviour when no attributes are defined. i.e <x-datetime-picker />
Desktop (please complete the following information):

OS: Windows
Browser: Chrome (Version 92.0.4515.131 (Official Build) (64-bit))

Additional context
I'm using AlpineJS version 2.8.2.
Thank you for this awesome package <3

Hello @Quintenps, thanks for your report
This package is not fully compatible with alpine v2.x
Can you use alpine v3?

Thanks for the quick response.
Oh I tried checking package requirements but didn't see them anywhere.

Issue can be closed :)

Is very simple to update to v3
https://alpinejs.dev/upgrade-guide


View of menu not showing properly in iPhone 6+

Hi,
I use a QBPlasticPopupmenu with 4 items, everything OK for iPhone 4,5,6 but when trying for iPhone 6+ the menu gets cut and the separators don´t appear where they should.... the last item gets cut and also do the arrow and bottom part of the menu. I use exactly  the same code than your example.
Some idea?

I'm using Latest commit d39a59e  on May 3, 2015 on iPhone 6+ and have no such problems.


Text selection color for Code Block is invisible (light mode only)

Description
When browsing the component docs on the developer site, you can select text within the Code Block component. Unfortunately, the text selection / "highlight" color is not visible while on the light theme. This is not an issue on the dark theme.
Steps to reproduce

Go to a component doc page.
Ensure you are on the light mode.
Select text within Code Block.

Expected behavior
This color should be visible so the user knows what they are currently selecting.

This doesn't seem to be an issue when using the CodeBlock component from gatsby-theme-newrelic. Once that component is released, we can use it on the developer site, which should resolve this issue.


Infinite scroll doesn't delete elements

Hi all,
I'm implementing infinite scroll and when I go to the bottom of the page it ever loads two or more times the new event:
1, 2, 2, 3, 3, 4, 4, 5, 6, 6, 7, 7, 7, 8, 8, 9, 9, 10, 11, 11, 11, 12, 13, 12, 14, 15, 14, 16, 17, 16, 18, 18, 19, 20, 20, 20, 21
Debugging, I see that the client sent multiple times a request on the same page.
It seems a concurrency problem?

I'm sorry, it was my fault


Question: Verification always fail

Hello everyone, I'm new here, trying to use the next branch of midenVM .
I have a question which is probably a bit silly. I tried to use Miden (next branch) and found that no matter what program I use, the verification result is Err (VerifierError (InconsistentOodConstraintEvaluations)).
If the program has push operation, i might have the assertion error:
thread 'main' panicked at 'assertion failed: `(left == right)`
left: `QuadExtension(BaseElement(9801321997299852158), BaseElement(10889698089612978941))`,
right: `QuadExtension(BaseElement(1), BaseElement(0))`', /Users/lisalora/.cargo/git/checkouts/miden-4241ff496f7b0a1f/8b07d87/processor/src/trace/utils.rs:188:9

The program i used is as follows:
use miden;
fn main() {
    // or `begin add end`
    let program = "
    begin
        push.1
    end";

    let options = &miden::ProofOptions::with_96_bit_security();
    let assembler = miden::Assembler::new(true);
    let program = assembler.compile(&program).unwrap();
    let inputs = miden::ProgramInputs::new(&[1,2,3],&[],vec![]).unwrap();

    let num_stack_outputs = 5;
    let proof = miden::prove(&program, &inputs, num_stack_outputs, options);
    let (output, proof) = proof.unwrap();
    let verify_result = miden::verify(program.hash(), &[], &output, proof);
    println!("verify_result is {:?},output is {:?}",verify_result,output);
}

Could somebody possibly tell me whether it is my fault or i used the wrong commit of miden?
If the latest commit cannot be verified, what is the latest workable commit? (I want to try some new function of next(such as read-write random-access memory, etc.), rather than the main version)
Thanks for any reply

Hi there! Not sure if this will solve this, but one issue that I'm seeing is that you are not using the same inputs for generating and verifying the proof. Try changing:
let verify_result = miden::verify(program.hash(), &[], &output, proof);

To:
let verify_result = miden::verify(program.hash(), &[1, 2, 3], &output, proof);

And see if that fixed it.

Hi there! Not sure if this will solve this, but one issue that I'm seeing is that you are not using the same inputs for generating and verifying the proof. Try changing:
let verify_result = miden::verify(program.hash(), &[], &output, proof);

To:
let verify_result = miden::verify(program.hash(), &[1, 2, 3], &output, proof);

And see if that fixed it.

sorry... my bad. But after fill in the input[1,2,3], the verification result is still Err(VerifierError(InconsistentOodConstraintEvaluations)).

Seems like there are a couple of other things happening here:

Miden VM expects that stack depth at the end program execution is exactly 16. We should document this much better and also show a much better error message if the stack depth is not 16 by the end of the program.
It seems like setting number of outputs to greater than 1 also causes issue. This is probably a bug that we'll need to investigate.

If you set your program to something like:
begin
    push.1
    movup.5
    drop
end

And set num_stack_outputs to 1 - it should work.

Looking a bit more into the number of outputs bug - the issue is that the verifier interprets the output vector in a different order (so, if we reverse the output vector before feeding it to the verifier, everything should work). We should make sure to interpret the order of inputs and outputs consistently in the prover and the verifier and also create a test which covers the cases with more than one output.

Looking a bit more into the number of outputs bug - the issue is that the verifier interprets the output vector in a different order (so, if we reverse the output vector before feeding it to the verifier, everything should work). We should make sure to interpret the order of inputs and outputs consistently in the prover and the verifier and also create a test which covers the cases with more than one output.

Great! After reversing the output, it works!

Seems like there are a couple of other things happening here:

Miden VM expects that stack depth at the end program execution is exactly 16. We should document this much better and also show a much better error message if the stack depth is not 16 by the end of the program.
........

Another question about the 1, how could the stack depth becomes exactly 16 at the end of the program?(after adding the two operations: movup.5 & drop)
I did another test for dup.0, the program shows next will fail (the origin_input on stack is [22,22])
begin
     dup.0
end

But the program adding movup.5 & drop works fine, I would appreciate it if you tell me what happened here.

@Lisalora I agree with @bobbinth that we should make some adjustments for usability, so thanks for bringing this up! For now, here's an explanation of what's going on.
TL;DR For any stack depth increase that occurs during program execution, there must be a corresponding stack depth decrease before the execution ends. (e.g. dup.0 must be accompanied by a drop at the end)
In more detail -
MIden VM allows a practically unlimited stack depth, but it does this by using an "overflow table" for all items deeper than the 16th spot. For this construction we have two requirements:

The stack must have a minimum depth of 16 during execution, which we do to simplify constraints. This means that if fewer than 16 inputs are provided, the rest of it is padded with zeros before execution begins. That means the initial stack when your program was started was actually [22,22,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
The "overflow table" be empty at the end of the program (functionally, this means that the stack will have exactly 16 elements at the end.)

So what's happening here is that the stack has a depth of 16 when execution starts, then you call dup.0 which increases the depth to 17 and pushes the deepest item onto the overflow table. In order for execution to succeed, you just need to call drop again, which will remove the top item and move the other item out of the overflow table and back onto the stack.
You can read more about the design here

@Lisalora We have a stdlib function that can be called at the end of execution to resolve the stack depth issue: https://maticnetwork.github.io/miden/user_docs/stdlib/sys.html

@Lisalora We have a stdlib function that can be called at the end of execution to resolve the stack depth issue: https://maticnetwork.github.io/miden/user_docs/stdlib/sys.html

Thanks!! An unexpected error comes when trying to figure out how to use finalize_stack:
The program with gte not works great:
   begin
        push.1
        push.2
        gte not
        exec.sys::finalize_stack
    end

However, replace gte not with lt (which sounds equal) leads to an unexpected error.
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `QuadExtension(BaseElement(8775471544908860125), BaseElement(15028436441736881570))`,
 right: `QuadExtension(BaseElement(1), BaseElement(0))`'

This confuses me a little, should I also lookup for the reason in the design here

This could be a bug inside finalize_stack procedure. We'll need to investigate. Thank you for finding all these!

This fails with a debug assertion failure while building the Range checker's p1 auxiliary column (it's not ONE where it's expected to be):

I think it might be because of the fact that we are doing an u32overflowing_sub on 1 & 2 here (1 - 2). The lo & hi are result(1-2) in 2's complement as u32 and 0. Decomposing the result as u32 in two 16-bit numbers will yield two U16MAX - 1.
When we are building the running product column for 16-bit section of the range checker table, we are stopping the iteration right before U16MAX - 1 due to which component of U16MAX - 1 are not getting incorporated into the running product and that's why p1 is not coming out to be 1.
We will see this error for the following case as well where we are getting two U32MAX - 1 on decomposing the result in two 16-bits number:
   begin
        push.1
        push.U32MAX - 2
        u32overflowing_add
        drop
        drop
    end

In the case of gte, the reason for not seeing this issue is because here we are doing 2-1 which will not decompose into U16MAX - 1 during range check operations. Although now I'm seeing a new error when I tried to incorporate U16MAX-1 into the p1 product column.
thread 'examples::testing::test_get_example' panicked at 'trace does not satisfy assertion aux_trace(5, 1022) == (1, 0)', /home/miden/.cargo/registry/src/github.com-1ecc6299db9ec823/winter-prover-0.4.0/src/trace/mod.rs:151:17

@0xKanekiKen thanks for your insights on this! I'll dig into it more today

Closing this as after #346 and #353 the bugs should be fixed. Figuring out the best way to simplifying stack management is moved to #347.
@Lisalora - thank you again for bringing these up! Feel free to open other issues if you come across anything else.


remove asserts

What if I start downloading messages when this controller is already shown? I will know senderId and senderDisplayName only when messages are already downloaded.

Hey @iSevenDays - see #895.


NIFI-4193 Converting to use the dockerfile-maven plugin

NIFI-4193 Converting to use the dockerfile-maven plugin to replace deprecated plugin.

Reviewing for once

@jfrazee Indeed... you didn't happen to notice this before updating your pull did you?  I seem to have completely lost it on my local repo (and I'm thinking I compounded issues by picking an untimely point to do a manual gc)

well, git reflog has saved me.  will fix this up

okay, should actually have the material changes too!  thanks for alerting me.

LGTM +1
Successfully ran build w/ -Pcontrib-check and tested image w/ docker run -it -p 8080:8080 apache/nifi:latest


Seniority filter

This pull request add the list of city in the dropdown filter seniorities
Why ?
it gives users the possibility to filter their result on seniorities
** Screenshots (optional)
no screen is available right now because the stage backend is down

@Zaker237 thanks, can you add a short mp4 video? On the screenshot section of the description for both PRs ?


Error with npm run production

When I use (npm run dev) everything done as is. but when use (npm run production) I got error with following:
npm ERR! Linux 4.4.0-59-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "production"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR! @ production: node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the @ production script 'node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node_modules/cross-env/bin/cross-env.js NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/mohamedsabil83/www/blacklist/npm-debug.log
npm-debug.log.zip

1 with this. but mine run on npm run dev (non laravel project)

+1 Same here, npm run production

Well, I've found my problem. One thing was I didn't have webpack installed gloablly on that server (every other project I have on this particular server uses gulp or laravel-elixir), as well, I had two versions of node (5.8 && 7) and I ran npm install then upgraded my system which set 7 as my primary, but compile with 5. Sorry... Non issue

@betteryourweb I'm upgrading to node7 many days ago but not sure for that. you suggest to remove npm package from my laravel project and install it again the try (npm run production) again?

Essentially, that would have worked for me. So I say try it...

Thanx @betteryourweb, as you suggest, I removed node_modules folder and install libraries again with order (npm install). now it's work at a glance.


Different behaviour in FF and Chromium with flexbox

I'm using CodeMirror with a flexbox layout. I see differences between Firefox (39.0a2, 2015-04-29) and Chromium (41.0.2272.118), both on Debian. I can get it work properly with either of them, but not both at the same time.
Please see this minimal example and the comment in the CSS for more:
http://output.jsbin.com/vapudetemi/1/edit?css,output

There is nothing in the CSS of the jsbin you linked.

I've updated the original comment to contain the correct link.

That is interesting. This looks like a browser bug -- Chrome interpreting the height: 100% of the CodeMirror instance in a weird way. Even if I make .item have position: relative, the editor ends up too high. I don't have much experience with flexbox, but I don't think it is supposed to violate height calculation expectations like that. Even if I replace the editor instances with simply a div with class CodeMirror, the problem persists (the divs are the height of the outer element, rather than the inner ones).

I am now getting even stranger behavior in Firefox. Closing this on the assumption that the browser are buggy and this isn't something CodeMirror itself can help (the issues show up even if CodeMirror is removed from the equation)


Add OSV scanner and GitHub actions to home page

This change adds:

two code boxes to display usage example for osv-scanner fix for both basic(non-interactive) and advanced (interactive) use cases.
Adds a new section to display information about Github Actions Tools
Adds a button on top of the Home page to point to the Github Action section

resolves https://github.com/google/osv.dev/issues/2085
https://github.com/google/osv.dev/assets/73332835/13da2482-8ca4-4fea-9644-1e3c8327fd88

Updated the PR. Here is how it looks like:
https://github.com/google/osv.dev/assets/73332835/5a57fe1a-c968-4886-8a37-2f979a5f11d1

Updated the PR. Here is how it looks like:
Screen.Recording.2024-05-08.at.9.59.28.AM.mov

@zahraaalizadeh thanks. Are your changes pushed? It looks like what's in this PR is not consistent with what's shown in your video.

Oops! Just pushed it 😅 Thanks for the heads up!

Thanks @zahraaalizadeh.
I'm running this locally and I see this for GitHub actions:

Which doesn't look like it's formatted correctly?

I'm running this locally and I see this for GitHub actions:
Which doesn't look like it's formatted correctly?

Thanks, @oliverchang. I couldn't reproduce the issue on my local machine. Could you let me know which browser and configuration you're using? This will help me further investigate the problem.

I'm running this locally and I see this for GitHub actions:
Which doesn't look like it's formatted correctly?

Thanks, @oliverchang. I couldn't reproduce the issue on my local machine. Could you let me know which browser and configuration you're using? This will help me further investigate the problem.

I'm using Chrome 123.0.6312.134 on Chrome OS.

I'm running this locally and I see this for GitHub actions:
Which doesn't look like it's formatted correctly?

Thanks, @oliverchang. I couldn't reproduce the issue on my local machine. Could you let me know which browser and configuration you're using? This will help me further investigate the problem.

I'm using Chrome 123.0.6312.134 on Chrome OS.

My bad, please ignore. It looks like my local CSS was style somehow. It now renders correctly for me.


npm caching by default

https://github.com/travis-ci/product/issues/206

We should add a couple of specs that checks that the generated Node.js script:

includes commands related to casher when the cache key is absent in config
excludes commands related to casher when the config explicitly disable caching with cache: false (or equivalent)


chore(metastore-cache): add codec support

SUMMARY
This PR adds the option to use a custom codec for serializing/deserializing values in the SupersetMetastoreCache. In addition, the default Explore form data and Dashboard filter state cache config is changed to use the JSON key-value codec.  This will not affect deployments that are using Redis or another cache. In addition, we're already emitting a warning when using it in prod, and since it will only cause a problem if a user happens to refresh their browser right after the state has last been updated, there is minimal risk that this will cause issues for users.
Tests are added to ensure that the cache works as expected with both the JSON and Pickle codecs.
TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@michael-s-molina I see that this PR is flagged for 3.0. You'll probably also want to bring in https://github.com/apache/superset/pull/24970

@michael-s-molina I see that this PR is flagged for 3.0. You'll probably also want to bring in #24970

Thanks @eschutho. Will do.


NPM - package.json

I saw that there is a package on npm for jsdo, but in the repo there is no package.json

Missed these  #2 & #55


help on integrating @angular/upgrade (ng-upgrade)

I was able to do the similar thing with the angular 2 quick start which uses systemjs, but I am having trouble getting it work with webpack.  Can someone share how I can get this working?:
In the package.json, I have added:
"dependencies": {
  ...,
  "@angular/upgrade": "2.0.0-rc.6",
  ...
}

In src/vendor.ts, I have added:
import '@angular/upgrade';

I have changed my src/main.ts to:
import { AppModule } from './app/app.module';
import { UpgradeAdapter } from '@angular/upgrade';
declare var angular : any;
let upgradeAdapter = new UpgradeAdapter(AppModule);
angular.module('ng1module', []);
upgradeAdapter.bootstrap(document.documentElement, ['ng1module']);

In src/public/index.html, I have added:
<script<EMAIL_ADDRESS>src="https://ajax.googleapis.com/ajax/libs/angularjs/1.5.8/angular.js" data-semver="1.5.8"></script>

(not sure if this is the right way to include angular 1x)
When I run the app, I get these errors:

Do you find a solution ? I've the same issue


[$250] Text pasted from Slack won't send or disappears in NewDot.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.61-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712695994757859
Action Performed:
Scenario 1:

Copy text from from Slack
Paste text in compose box
Tap return

Scenario 2:

Copy text from from Slack
Type > in compose box
Paste text after > (and a space after)
Tap return

Expected Result:
Message is sent
Actual Result:
Scenario 1: Message stays in compose box and won't send. Cursor stays at the beginning of the message
Scenario 2: Only the > part of the message sends.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/e5d2ba57-5336-40ce-9aa7-6800505cc0e8
https://github.com/Expensify/App/assets/38435837/384d0321-b113-4ea0-8537-3fb1990be135

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01892e3b8e5931a268
Upwork Job ID:<PHONE_NUMBER>225918976
Last Price Increase: 2024-04-12
Automatic offers:

jayeshmangwani | Reviewer | 0
kpadmanabhan | Contributor | 0

@roryabraham been discussing here with @thienlnam that this is specific for Slack it seems so we should not have to hold deploy for this bug

@m-natarajan can you pls paste the unformatted content of the slack message? initial suspicion is > symbol is treated with a special character when you copy to clipboard.

Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01cef163ba3c7ed327?mp_source=share

Also happens when trying to copy/paste from https://github.com/Expensify/App/blob/main/contributingGuides/HOW_TO_BECOME_A_CONTRIBUTOR_PLUS.md

making this external

Proposal
Please re-state the problem that we are trying to solve in this issue.
Text pasted from many editors including TextEdit or Notepad with a triple click to the NewDot report composer is not enabling "Send" button.
What is the root cause of that problem?
When you triple click and copy a text to clipboard, it brings along hidden CR LF characters along with it. After pasting cursor goes to position zero.
NOT WORKING STRING

However, if you copy a line from start to end by drag and select and copy, the CR LF characters do not come along with it. After pasting, cursor goes to end of string.
WORKING STRING

In this case the Send button is enabled.

Drag and drop of multi-line text works fine as long as you copy till end of line and NOT include newline.

WORKING STRING

Multi-line that include trailing CR LF is not working as well. Note that in this case cursor is in position 0.

NOT WORKING STRING

NOT WORKING STRING results in following to be TRUE in ReportActionComposer.tsx.
  var isSendDisabled = isCommentEmpty || isBlockedFromConcierge || !!disabled || hasExceededMaxCommentLength;

This is because isCommentEmpty returns TRUE.
ONYX update in ComposerWithSuggestions.tsx  for NOT WORKING STRING is not fired through onChangeText event and hence draft report is not saved to ONYX. This is because useHtmlPaste hook handles paste action, but captures cursor position with startIndex as 0 and endIndex as 0 due to additional CR LF at the end of string.
What changes do you think we should make in order to solve the problem?
There are 2 ways to handle this issue.

Before pasting, remove the trailing carriage return and line feed in useHtmlPaste --> index.ts and paste the text without these, so that ONYX update can be fired as expected.

var handlePastePlainText = useCallback(function (event) {
    . . .
    plainText = plainText.replace(/^\s+|\s+$/g, '');
    if (plainText) {
      paste(plainText);
    }
  }, [paste]);

Fix the index issue. Make sure that start and end index are calculated correctly in useHtmlPaste --> index.ts  by insertAtCaret() so that the paste is handled correctly and subsequent events are fired accordingly.

. . .
    // Move caret to the end of the newly inserted text node.
    range.setStart(node, node.length);
    range.setEnd(node, node.length);
    // If the node picked up is only CR and LF, then move to end of previous node and then set the range.
. . .

Both will involve a little extensive regression testing effort to make sure that no other components using the same hooks are affected by this change.
What alternative solutions did you explore? (Optional)
After pasting a NON WORKING STRING, move to end of string and programmatically add a white space at end of string. This will enable the "Send" button.

Reviewing Proposal

Proposal
Please re-state the problem that we are trying to solve in this issue.
Every time the user pastes anything with the new line in the end the cursor is incorrectly put in the beginning of the text, so if you were to triple click something copy and paste as well as copying and pasting anything with a new line this issue appears.
What is the root cause of that problem?
The root problem is that in "insertAtCaret" function in useHTMLPaste hook the selection range start and end index is determined incorrectly in cases there is a new line in the end of the insertion.
What changes do you think we should make in order to solve the problem?
I suggest using document.execCommand('insertHTML', false, text); instead of implementing it by ourselves (insertAtCaret). Method execCommand is being deprecated, however it is already being used in insertByCommand function as well as "copy" functionality and it does not seem like there is a valid alternative right now.
What alternative solutions did you explore? (Optional)
N/A

@roitman-g We can not replace insertAtCaret with document.execCommand altogether, as it was added intentionally to handle the other custom functionalities in the app; instead, can we fix in theinsertAtCaret function that is causing this issue ?

@jayeshmangwani do you mean that dispatching a 'paste' and 'input' event is necessary? If that is the case
we can replace only these lines in insertAtCaret with execCommand.
        const range = selection.getRangeAt(0);
        range.deleteContents();
        const node = document.createTextNode(text);
        range.insertNode(node);

        // Move caret to the end of the newly inserted text node.
        range.setStart(node, node.length);
        range.setEnd(node, node.length);
        selection.removeAllRanges();
        selection.addRange(range);

If not, could you say which kind of functionalities so I can test? I tried pasting all kind of things and it seems like besides the end of the line edge case, this piece of code works the same as execCommand('insertHTML, .....).
Also, there is issue  which probably a duplicate, they have the same root cause.

@jayeshmangwani this case works the same for me with execCommand('insertHTML',  false, text). The result I get when pasting it:

##Proposal
Updated

@brkdavis's Updated proposal looks good to me
@brkdavis Just one suggestion(question): rather than removing all the whitespace from the beginning and end of a string, can we remove the carriage return and line feed characters only from the start and end like this /^[\r\n]+|[\r\n]+$/g ?
🎀 👀 🎀 C+ reviewed

there is also a bug worth mentioning though probably not related to the paste functionality - if you copy whatever is in the "copy the following text" manually (so not with copy icon button and it is copied as a code block) and paste it - you cannot send the message and chat box is not expanded.

@roitman-g The Purpose of this logic was this PR #39177. Now, if you want to verify that your suggested changes will not recreate the issue mentioned in the PR, then you can follow the Tests section of PR after applying your suggested changes; I am copying the Tests from the PR below.

Copy following text:

https://expensify.com
# Lorem ipsum
> Hello world
`foo`
@here

<EMAIL_ADDRESS>

Enter any chat
Paste copied text from step 1 into main composer
Verify if cursors is positioned properly, it should be at the end of the pasted text
Verify if there are no extra new lines. Especially verify if the empty line is inside the text from step 1, hasn't been duplicated

@roryabraham I will be out until 4/22, looks like the ball is in your court at the moment.  Not adding another BZ since this looks like it's in a good place.

@brkdavis's Updated proposal looks good to me
@brkdavis Just one suggestion(question): rather than removing all the whitespace from the beginning and end of a string, can we remove the carriage return and line feed characters only from the start and end like this /^[\r\n]+|[\r\n]+$/g ?
🎀 👀 🎀 C+ reviewed

Sure. I will test with removal of trailing CR LF alone and proceed if looking good.
@jayeshmangwani / @roryabraham : shall I proceed with a PR? but I still do not see an offer yet on upwork?

@brkdavis do not proceed with PR, we still need approval from @roryabraham , and then you will get an upwork offer then you can start with the PR

@brkdavis As you are a new contributor and its your first assigned issue according to our contributing guidelines New contributors are limited to working on one job at a time, please do not post proposal on any other issue until this issue got completed(PR hit production) and if you have already submitted proposal on any other issue and if your proposal selected then please let the c+ know that your first PR is in review.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01063aad97ce0e22c6
@roryabraham : can you please help me link to my correct upwork account?

@brkdavis You have linked your account with the below details; what's the issue?
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01cef163ba3c7ed327?mp_source=share

@jayeshmangwani : melvin-bot was not picking my upwork profile. I think it is linked to another email of mine.
I created a dummy upwork profile to confirm this. Unfortunately, now my account is linked to this dummy upwork profile.
I would like to use this upwork profile: https://www.upwork.com/freelancers/~01cef163ba3c7ed327?mp_source=share
How can this be corrected now?

@brkdavis I don't know how to update the Upwork profile in melvin-bot; you can raise the issue on Slack in #expensify-open-source

@jayeshmangwani : I will do that. Or is re-assigning this issue to another account of mine faster?
https://github.com/kpadmanabhan

@jayeshmangwani : I will do that. Or is re-assigning this issue to another account of mine faster? https://github.com/kpadmanabhan

Can you please re-assign this to this account of mine?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01063aad97ce0e22c6

@roryabraham We have been getting some strange issues here, @brkdavis is having some issues with storing their Upwork profile data in melvin-bot. They have another Github and an Upwork account; that account is linked correctly. Should we assign it to their new GH account @kpadmanabhan so we can move forward with PR?

@kpadmanabhan What's your ETA for PR?

@jayeshmangwani Code changes are good. Working on the unit test strategy for the change.
@jayeshmangwani / @roryabraham : Does writing a test for the string.replace(...) add value? I dont think it does.
Hence working on following strategies for unit tests / integration tests

for useHtmlPaste hook. But this cannot cover if the send button will be enabled or not. This has to be checked in manual test or e2e automated test. Did you mean e2e test when you said unit tests? Facing challenges with heavy consumption of UI components (window and DOM) inside the hooks.
for composer. This will cover paste and send button by mocking other components around it.

Or do you mean test the newly written regular expression alone? Either by mocking UI components or by extracting string sanitization into a different function and test that alone?
Please let me know your thoughts.

@kpadmanabhan thanks for putting some thought into an automated testing strategy. I think that tests in useHtmlPaste covering the removal or carriage returns might be sufficient, and including tests for composer that covers paste and send button would be above-and-beyond (would love to see it). Tests for useHtmlPaste can probably be classified as unit tests, while tests for composer might be more accurately classified as "ui tests", probably relying on react-native-testing-library for mocked renders.
We do not currently have any functional e2e tests, so we shouldn't try to establish a new pattern by adding them here.

Thanks @roryabraham.
Concept for ui tests for composer
        const pasted = jest.fn(() => null);
        const changed = jest.fn(() => null);

        render(<AnimatedMarkdownTextInputRef data-testid="composer-input" />);

        const composerElement = screen.queryByTestId('composer-input');
        useHtmlPaste(composerElement, handlePaste, true);

        const pasteFromClipboard = createEvent.paste(composerElement, {
            clipboardData: {
              getData: () => '123456',
            },
          });

          fireEvent(composerElement, pasteFromClipboard);

          expect(pasted).toHaveBeenCalled();
          expect(pasted).toHaveBeenCalledWith('123456');

We use testing-library for react, but this will need some changes to the component as well to support testability.

We use testing-library/react

Let's use testing-library/react-native ?

@kpadmanabhan do you have an update on this?

@slafortune: There is no unit test that exists for the hooks in our codebase. useHtmlPaste uses window.getSelection as well as Selection.getRange(). Landing up into issues mocking these. I will use #expensify-open-source to get some help on this. Targetting PR on priority today.

@kpadmanabhan Please raise a PR(or Draft) with the regex changes; we can discuss the tests on the PR.

@kpadmanabhan @jayeshmangwani do you have an update?  Looks like the draft is waiting on you @kpadmanabhan .

We await the update for the @kpadmanabhan; yesterday bumped on PR https://github.com/Expensify/App/pull/41265#issuecomment-2102701521

PR was abandoned, so we're looking to hire another contributor to take this one on.

Sorry for that.
Update:
https://github.com/Expensify/App/pull/41265#issuecomment-2118674202

Hope you're feeling better @kpadmanabhan .  Please post daily updates on the GH or PR til it's finished. Thx

@jayeshmangwani  - C+ role ~ will be paid via New Dot $250
@kpadmanabhan  - Contributor role ~ will be due $250
I will be on vacation until June 4th so adding another BZ in the meantime.  I will take this back on the 4th.

@kpadmanabhan appears to have picked the PR back up

@kpadmanabhan appears to have picked the PR back up

yes @roryabraham . tested in all platforms and all artifacts are attached in PR template.
can you pls review?

I'm heading ooo but Steve is due back on Tuesday, and I don't think any action will be required before then from the BZ team.

Hi, I’m Bartosz from SWM react-native-live-markdown team. We’ve recently decided that it would be best to actively participate in all of the issues related to the library we’re working on. That means reviewing proposals together with the Expensify team and supporting external contributors to ensure quality solutions that won’t introduce any additional regressions. 🙌🏻
I’m currently going through all of the issues that could require any changes to the library. Feel free to tag me if you need anything, later I’ll be diving into the issues more in-depth, but there’s quite a few of them so it can take a while for me to catch up. Oh and feel free to tag me in any live-markdown related issues in the future! 😄

Moved to Live Markdown project
@kpadmanabhan once https://github.com/Expensify/App/pull/42892 hit production, please hold on proceeding til we have feedback from @BartoszGrajdek .  Thx

@MelvinBot this is blocked because of the PR that is on hold.
@jayeshmangwani / @roryabraham : how should we proceed here?

how should we proceed here?

@kpadmanabhan We are still waiting for the other contributor to update their PR and get it ready for merging. Until then, we are blocked.
How should we proceed from here? I am quite confused.
@mallenexpensify  might be the savior here

We are still waiting for the other contributor to update their PR and get it ready for merging. Until then, we are blocked.

Exactly. But it has been quite a long wait is my worry.
@mallenexpensify : what do you suggest?

@jayeshmangwani @kpadmanabhan , sorry, I'm confused.  I've checked links but I'm unsure where we're at.  Is it....

@kpadmanabhan was hired here
We put it on hold pending https://github.com/Expensify/App/pull/42892
https://github.com/Expensify/App/pull/42892 never got completed/fixed via the PR, it was fixed elsewhere
Now we have this open issue, with no action needed.   We need to figure out potential compensation.

Is that right?

@mallenexpensify in a sense that's correct.

Is that right?

Yes, that's correct! I had opened the discussion a few days ago for this issue here https://expensify.slack.com/archives/C02NK2DQWUX/p1719300668647629

OK.. since @kpadmanabhan was hired and invested a non-immaterial amount of work, compensation should be do.
My gut says either 50 or 100%.  What do you think @jayeshmangwani and @roryabraham ?

@mallenexpensify Generally, we should have given 100% as the PR was almost in a mergeable state, but since the raised PR had one regression found during testing, I would say 50% compensation should be given.

Thanks @jayeshmangwani .  Does that sound good n' fair to you @kpadmanabhan ?

@mallenexpensify though task was for completing the bug fix, I did a lot more than that following up on other bugs and PRs in the related area. However, I am fine with the suggestion from you and @jayeshmangwani .
Sad that my changes couldn't hit production. Looking forward to that in next proposals.

I did a lot more than that following up on other bugs and PRs in the related area

@Krishna2323 if you want to provide links and details to the additional work, it's possible that could influence the compensation amount.   We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

@mallenexpensify tagged the wrong contributor 🙂 ; the message was meant for you, @kpadmanabhan.

@kpadmanabhan if you want to provide links and details to the additional work, it's possible that could influence the compensation amount. We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

thanks @mallenexpensify and @jayeshmangwani.
I am fine with any compensation that Expensify considers fair.
anyhow noting down my contribution for this issue and the issues that I was keeping track of.
addition of unit tests in my PR for this issue, which i do not see covered in any of the merged PRs from others for this issue.

https://github.com/Expensify/App/issues/39971#issuecomment-2070625886
https://github.com/Expensify/App/pull/41265/files

other related issues that i kept track of.

https://github.com/Expensify/App/pull/42892#issuecomment-2168653907
https://github.com/Expensify/App/issues/43331#issuecomment-2167821876
https://github.com/Expensify/App/issues/42216#issuecomment-2140491997
https://github.com/Expensify/App/issues/40033#issuecomment-2057600733
https://github.com/Expensify/App/issues/43808#issuecomment-2171064361

not counting the other proposals that i submitted.

but since the raised PR had one regression found during testing,

and, from CONTRIBUTING.md

If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

@jayeshmangwani, was the regression found during testing before the code was merged?

@jayeshmangwani, was the regression found during testing before the code was merged?

@mallenexpensify : jayesh found it when everything looked good during final review.
you may refer to this comment and the surrounding comments in the PR.
https://github.com/Expensify/App/pull/41265#issuecomment-2134547724
correct me if i am wrong @jayeshmangwani

was the regression found during testing before the code was merged?

@mallenexpensify Yes, found when testing the PR.

Since the regression was found before being merged, that would be normal testing. We don't have documentation stating there are penalties for that.  Based on that, and @kpadmanabhan 's breakdown above, I think we shoudl compensate 100% here for both @kpadmanabhan and @jayeshmangwani.  They were both hired/assigned and started work on the PR.

Contributor: @kpadmanabhan  paid $250 via Upwork
Contributor+: @jayeshmangwani paid $250 via Upwork
Thanks!


Adds instructions for enabling cloud sync

I know Cloud Sync is out of scope for the project. However would it be OK to merge some instructions to enable it for folks that want local file encryption in case the device is lost/stolen, but are willing to accept the reMarkable Cloud attack vector?

Thanks for the PR. We can definitely point users in the right direction if they want to enable cloud sync as long as we add the necessary disclaimers. We'll think about how exactly we want to present this information in this repository and merge it in one way or another as soon as we find the time.


libjpeg and libpng version problem

I'm running to an issue where the version of the packages are just not right. I ran
th run_model.lua -input_image imgs/test.png -gpu -1
It says:
libpng warning: Application built with libpng-1.4.12 but running with 1.6.34
/Users/yanchenm/torch/install/bin/lua: /Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:156: [read_png] png_create_read_struct failed
stack traceback:
	[C]: in function 'load'
	/Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:156: in function 'loader'
	/Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:388: in function 'load'
	run_model.lua:67: in function 'run_image'
	run_model.lua:164: in main chunk
	[C]: in function 'dofile'
	...henm/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: in ?

And if I used .jpg
th run_model.lua -input_image imgs/elephant.jpg -gpu -1
/Users/yanchenm/torch/install/bin/lua: /Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:235: Wrong JPEG library version: library is 90, caller expects 80
stack traceback:
	[C]: in function 'load'
	/Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:235: in function 'loader'
	/Users/yanchenm/torch/install/share/lua/5.2/image/init.lua:388: in function 'load'
	run_model.lua:67: in function 'run_image'
	run_model.lua:164: in main chunk
	[C]: in function 'dofile'
	...henm/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: in ?

I've tried to uninstall libjpeg and libpng, and also had libjpeg8d (with 9 and w/o), and libpng1.4.12 (with 1.6 and w/o) copied in the same location. I tried both lua5.2, 5.3.
I'm using MacOS 10.12.6. Please help!

Did you find any solution??
same issue here..

the same question, and many methods have tried but no one succeed...  TAT


Update Magic Logbow Western Provinces Diary Step

Have not done the quest and this is the new text.


Allow travis failures of 1.8.7 and REE for now

Currently these Travis CI builds are failing to access Rubygems with following error:
Unable to download data from https://rubygems.org/ - hostname was not
match with the server certificate (https://rubygems.org/specs.4.8.gz)

This commit simply allows them to fail in CI without failing the entire build. As a
next step, we must either find a way to fix these test builds, or move forwards to
officially remove support for Ruby 1.8.

Probably the relevant documentation:
https://bundler.io/v2.0/guides/rubygems_tls_ssl_troubleshooting_guide.html#troubleshooting-certificate-errors
Need to discuss with Travis on an issue, most likely

See Travis CI topic here:
https://travis-ci.community/t/ruby-1-8-7-and-ree-builds-broken-by-ssl-certificate-failure/10866


Introduce new variant token type

An interesting approach to variants and components could be to introduce a variant token type. Users could specify size: 300 and the plugin would switch a layer where that token is applied to the variant of size: 300. In Figma that would mean that we look at other currently applied variants and then only change the one affected. This does require that there's a variant like this existing in the main component, though.
From Slack:
Hey, I’d love to have the component property or variant token type to be able
to control properties of the component and use compositions effectively.
For example I use Container component to specify different sizes of the graphic
elements (eg icons). Then If I use the Container in other UI components I need
to specify the token for it. But now I can do that only in the pixel values,
eg size: 24 instead of the convenient size: 300 which is a variant of the Container

+1 from me 👍🏼

@six7 proposing we archive this one until it comes up again its a couple years old.


chore: deps

Description
Updates dependencies

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#126 👈
main

This comment was automatically generated by st.


feat(rpc-types-beacon): BuilderBlockValidationRequestV4

Motivation
As suggested by @mattsse here this is a simple type alias for BuilderBlockValidationRequestV4.
I still think we should consider refactoring these structs to use an explicit versioned ExecutionPayloadV* instead of the enum, but I'm not sure how we feel about breaking compat on the V1 and V2 structs.
We could also move them from ::relay to ::validation to mirror the layout in reth: https://github.com/paradigmxyz/reth/blob/3daec1d9b97c2d654c7f84e8521ac552dcaf4928/crates/rpc/rpc-api/src/validation.rs
Solution
Anyways the type alias works for Pectra in the short-term, but happy to make the other changes if people are ok with that.
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

We could also move them from ::relay to ::validation to mirror the layout in reth:

that makes sense


Optical Filter should specify 2-wavelength passband

The optical filters from doric lenses don't really have a peak wavelength, but rather a flat pass band. See figure 3.1 here.
So, instead of peak_wavelength and bandwidth, we should specify a 2-wavelength passband ex.
emission_filter = OpticalFilter(
            name="emission_filter",
            description="...",
            manufacturer="Doric Lenses",
            model="4 ports Fluorescence Mini Cube - GCaMP",
            pass_band_in_nm=(460.0, 490.0)
            filter_type="bandpass",
        )

Update: In the previous comment, I missed that bandwidth_in_nm is already a 2-element float that would refer to the pass band in this case. But I still think at the very least the naming is a bit confusing, since bandwidth usually refers to a single width (ex. 30nm) rather than the range of the pass band (ex. 460nm-490nm).

I agree pass_band_in_nm is a better name for that. However I don't think we should remove the peak_wavelength, usually filters are reported as wavelength/bandwidth, eg. 920/30 nm where the 30 nm large bandwidth is centered at 920.  Maybe we can change the name in central_wavelength or something like this, but still keep this information


Some changes to make example work on first build

Hey,
Is there a reason for the references to a folder called cornerstoneWebImageLoaderBuild?
This PR just changes the gruntfile and example a bit so that we can run the example after a fresh clone + build.

Yes, I switched to using github pages and am putting the build output in that directory so I can easily check it into the gh-pages branch. I am open to easier/better ways if you have any ideas..

Ah yeah that's what I figured. No I don't have a better solution just yet. I think I'll add something similar to cornerstoneTools. I guess the easiest is to keep a separate grunt task, like "grunt gh-pages" to build everything for copy/pasting to the branch.

I ended up reverting back to rawgit, closing this


README should mention firewall issues

Thanks for building this very useful utility!
After installing the virtualbox_WSL2 plugin, I found that it was not working for me. After some troubleshooting, I found that the problem was the Windows Firewall. It worked fine with the firewall disabled.
This should be documented in the README.
The specific problem is that from the host's perspective, the VirtualBox VMs appear to be in the public zone. This cannot be changed (Windows limitation). In addition, depending on your configuration, traffic in or out of the VM may get blocked by the firewall.
I found that the following PowerShell script opens the firewall enough, without completely disabling it. Note: this script only allows DNS traffic, which was the problem for me. You may need to open additional ports.
$adapters=(Get-NetAdapter | Where-Object Name -like 'vEthernet*')

Set-NetFirewallProfile -DisabledInterfaceAliases $adapters.Name

# For VirtualBox, we also need to allow DNS to/from anywhere
# If security is a concern, you could also set -RemoteAddress but we do not do that here
# for flexibility
New-NetFirewallRule -Name UsdDNSReq  -DisplayName "Allow DNS Req" -Direction Inbound  -LocalPort 53 -Protocol UDP -Action Allow
New-NetFirewallRule -Name UsdDNSResp -DisplayName "Allow DNS Resp" -Direction Inbound -RemotePort 53 -Protocol UDP -Action Allow
New-NetFirewallRule -Name UsdDNSTCPReq  -DisplayName "Allow DNS TCP Req" -Direction Inbound  -LocalPort 53 -Protocol TCP -Action Allow
New-NetFirewallRule -Name UsdDNSTCPResp -DisplayName "Allow DNS TCP Resp" -Direction Inbound -RemotePort 53 -Protocol TCP -Action Allow

I didn't go with those specific rules but @kkeane description helped me. Since I don't want to get to powershell about this, these were the steps I followed to enable the firewall rules the Windows UI way (PLEASE don't do this unless you're in a safe network):

Open the Windows Defender Firewall application.
Look for "VirtualBox Headless Frontend" rule name, "Public" profile. You'll see one rule for TCP and another one for UDP.
Right click on each of them, hit Properties.
Set to "Allow connection" in the Action section of the "General" tab.

The option names might differ, my windows is in spanish.
Once again, PLEASE don't do this unless you're in a safe network or revert the changes once you're done.

Hi, you should definitly mention your previous message in your README (authorizing Public rules). Not sure how long that would have taken me to find it out by my self. Thanks !

To reiterate on what @hlombard said, to set the mentioned firewall rules to Public, run the following command in an elevated PowerShell (on Windows, not within WSL2):
Get-NetFirewallRule -DisplayName "VirtualBox Headless Frontend" | Set-NetFirewallRule -Profile Public

Also, as @mxdlx mentioned, only do this on a safe network.


Some datasets are converted to parquet with too big row groups, which makes the viewer crash

... and workers to OOM
eg IDEA-CCNL/laion2B-multi-chinese-subset
In [1]: import fsspec; import pyarrow.parquet as pq

In [2]: url = "https://huggingface.co/datasets/IDEA-CCNL/laion2B-multi-chinese-subset/resolve/main/data/train-00000-of-00013.parquet"

In [3]: pf = pq.ParquetFile(fsspec.open(url).open())

In [4]: pf.metadata
Out[4]:
<pyarrow._parquet.FileMetaData object at 0x11f419450>
  created_by: parquet-cpp-arrow version 7.0.0
  num_columns: 10
  num_rows: 11177146
  num_row_groups: 1
  format_version: 1.0
  serialized_size: 5880

In [5]: pf.metadata.row_group(0).total_byte_size
Out[5]:<PHONE_NUMBER>

In [6]: pf.metadata.row_group(0)
Out[6]:
<pyarrow._parquet.RowGroupMetaData object at 0x106609590>
  num_columns: 10
  num_rows: 11177146
  total_byte_size:<PHONE_NUMBER>

Ah apparently it was converted to parquet before #1497
I just restarted the config-parquet-and-info job

Actually it copied the file anyway because the check on row groups didn't run, let me fix this

Is it the case for https://datasets-server.huggingface.co/rows?dataset=bigcode/the-stack-metadata&config=bigcode--the-stack-metadata&split=train&offset=500&length=100? Or is it another issue? The request takes too much time and the reverse-proxy emits a 504 Gateway Time-out error

OK! In this case it's bigcode/the-stack-metadata, not garythung/trashnet, but I imagine it's the same. For reference, https://datasets-server.huggingface.co/rows?dataset=bigcode/the-stack-metadata&config=bigcode--the-stack-metadata&split=train&offset=500&length=100 currently takes about 9s to respond

yes bigcode/the-stack-metadata should be fixed with https://github.com/huggingface/datasets-server/pull/1520 : it has too big row groups

ah actually I can just refresh it I think


Hot reload markdown content

Hi I'm very new to astro and was wondering if there's a way to get the markdown content itself to hot reload. The astro templates do hot reload when editing directly but not the blog content which I have to do a pge refresh to see. I'd love to edit the content with realtime updates to see how it would look like on prod instead of in my editor built in markdown preview tool (github styled)

Check out this VS Code extension called FrontMatter https://frontmatter.codes/
Setup is a pain, but well worth it!
James Q Quick features a one hour long video with the lead developer of FrontMatter. At the 56 minute 09 second mark, he shows the live preview with hot reloading https://www.youtube.com/watch?v=aCkkEDsJgL0&t=3369s

Oh thanks for the suggestion. This extension is crazy featureful!
I got the live side-by-side preview running but unfortunately it has the same problem as a normal website: there is no hot reloading of the .md content. I believe this has to do with the way this blog template reads files in src/lib/markdoc/read.ts not refreshing with HMR. Now that I think about I'm not sure how I would get the astro dev server to detect a change in the content folder...

James Q Quick has an Astro Course coming up. I heard him mention it a few times on his podcast https://astrocourse.dev/
He said recently it'll be a few more weeks, so estimated early June 👍
Hopefully then, or by then, someone comes up with a solution to the HMR for MD files.
In the meantime, check out the current issues, perhaps it's already been mentioned?
https://github.com/estruyf/vscode-front-matter/issues