h1 line height different in Safari and Firefox (last version)

I've noticed a difference in the line height of
 tags between these two and I've created this issue to know if normalize tries to mitigate this kind of differences too.
In case maintainers feel it should I can take care of creating the pull request. Thank you.

if you zoon out on Firefox to 80% show the same size as in Safari or Chrome?

@Karklis nope, in Safari and Chrome the line-height is 50px and in Firefox it's 39.4px' and zooming out barely increases it to 39.9px`

Could you provide code and all steps to reproduce this behavior? Are you using just default normalize css without any other css code, or mix something?

Create a new page with this content:
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title>Line height diff in h1 tags</title>

    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/normalize/4.1.1/normalize.min.css">

line height diff in h1 tags

line-height:

You will be able to see the computed line height on page or open the web inspector in Safari and Firefox and check the resulting computed styles for line-height property.
Results
Firefox: 33px
Safari: 37px
Considering that in both the font-size is 32px, conclusions point that Firefox is assigning only 1.03em of line-height while Safari and Chrome 1.15625em.

Hi @Karklis, were you able to test this? Do you prefer another presentation for the test case?

I’ve put your test on CodePen. I see a difference between Chrome and Firefox, between Firefox Mac and Firefox PC, and possibly by a fraction of a pixel in Edge/IE.
http://codepen.io/jonneal/details/RRNpLB/

So, what do we take as a standard to make them all match? I'll create the
PR :)
On Tuesday, 31 May 2016, Jonathan Neal<EMAIL_ADDRESS>wrote:

I’ve put your test on CodePen. I see a difference between Chrome and
Firefox, between Firefox Mac and Firefox PC, and possibly by a fraction of
a pixel in Edge/IE.
http://codepen.io/jonneal/details/RRNpLB/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/necolas/normalize.css/issues/593#issuecomment-222878823,
or mute the thread
https://github.com/notifications/unsubscribe/ADrYYaQwXDyO_wsmqmZymKdVHFAEyEooks5qHPNYgaJpZM4IWzOl
.

--
Jeremias Menichelli
web developer
skype | jeremias.menichelli
http://jeremenichelli.github.io
github | jeremenichelli

The CodePen test measures the height of single-line h1 headings using either the initial or sans-serif font. Here are its results when run with a large stack of popular browsers.

Browser
Font
Line Height

And Chrome
initial
136px

And Chrome
sans-serif
117px

Mac Chrome
initial
115px

Mac Chrome
sans-serif
115px

Win Chrome
initial
115px

Win Chrome
sans-serif
115px

Mac Firefox
initial
120px

Mac Firefox
sans-serif
101px

Win Firefox
initial
118px

Win Firefox
sans-serif
118px

iOS Safari
initial
117px

iOS Safari
sans-serif
117px

Mac Safari
initial
115px

Mac Safari
sans-serif
115px

Win Edge
initial
114.999px

Win Edge
sans-serif
114.999px

Win IE11
initial
114.999px

Win IE11
sans-serif
114.999px

Win IE10
initial
114.999px

Win IE10
sans-serif
114.999px

Win IE9
initial
114.999px

Win IE9
sans-serif
114.999px

Mac Opera
initial
115px

Mac Opera
sans-serif
115px

Win Opera
initial
115px

Win Opera
sans-serif
115px

When the font size was 100px, the most common line height was 115px. However, results varied from 101px on Mac Firefox to 136px on Android Chrome.

So it seems like something between 1.5em and 1.15625em should be the normalized value of the line-height. I saw you noticed differences in both h1 and h2 elements, should we applied this fix to all headings?

And here are the results for a normalized test where the line height of h1 headings is defined as 1.15.

OK, so should I make the PR containing fix for all the heading tags to 1.15?

Sure. Remember, the comment will need to specify which browsers this normalization is targeting, and this would be the most particular list I have yet seen in the project, and you’ll need to manage the line breaks to follow the style guide of the project. If there are issues, I will still take in your PR, but also correct them during the merge.

Great, will get that done and tag you. Thank you for your help.

Thanks :)

Digging this up as I've got another issue with line height on firefox.
See codepen attached here
Firefox: (text is not vertically aligned on the background color)

Chrome: (text is aligned)

Any idea on how to resolve this? Tried with the 1.15 fix but didn't help.
Thanks

@klig1 You aren't using normalize.css in the codepen so I'm not sure why you are asking your question here. Even adding it in there, I don't see the same behavior.
Windows 10
Chrome 80
Firefox 74


Release 3.2.2: Update Known Issues for the client.

Updated the known issues document with input from Jaap.

Looks good to me!


[Bug] Video download is not actually downloading

It opens video in the browser, use download same as context menu (use js)

Found it. Solved it on zipfly version. Will merge


32-view invite

Is the main route changed on other repos?
const routes = {
path: '/',

component: Create,

component: Invite,
childRoutes: [
{ path: '/plan/create',       component: Create },
{ path: '/plan/collaborate',  component: Collaborate },


MeshConfig.ExtensionProvider requires name property but installation doesn't fail when not set

Bug Description
When configuring custom logformat through the new MeshConfig.ExtensionProvider config block, it is possible to omit the name property even though it is required. The installer will not fail with a validation error.
The following configuration is accepted while it doesn't work / have any effect:
        extensionProviders:
        - envoyFileAccessLog:
            path: "/dev/stdout"
            logFormat:
              labels:
                source_host: "%HOSTNAME%"

Version
Istio 1.13.1

Additional Information
No response

How did you install?

Using istioctl with a values file.

what do you mean have any effect ? did you setup anything in defaultProviders or WasmPlugin?

if you do not set any defaultProviders or config via Telemetry API, istio will fall back to leacy way
https://github.com/istio/istio/blob/d667fd9bf7595b8d29f7d951b389eff4b64d4205/pilot/pkg/networking/core/v1alpha3/accesslog.go#L154


Enable travis

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Enable CI/CD

What is the current behavior?
We don't have a CI/CD workflow

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

What is the expected behavior?
Every PR should be tested using Travis

What is the motivation / use case for changing the behavior?
A more stable master branch

Please tell us about your environment:

Angular version: 2.0.0-beta.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

great idea

@gdi2290, can you please enable travis? it has to be done by an admin.

@mastertinner sorry, it's on now

Thanks!


CHAD-8725 - adds a new device profile for Aeotec aerQ sensors

CHAD-8725 - new device profile for Aeotec aerQ sensors
@SmartThingsCommunity/srpol-pe-team @greens

both the devices that use this profile use the same ocf device type
you should not have created a new profile here, and now the original profile also needs to be fixed because, upon inspection, the Popp multisensor also uses a thermsotat device type.

@greens You're right, that was in the definition() of the DTH. New PR is coming.


Return less errors; Fixes #118

For details about this solution see the documentation for acceptError, panicError, and issue #118.
Present
I fairly confident this change will work appropriately, but I've only tested against my applications. As it's a rather large change, I would appreciate help reviewing / ensuring correctness and testing against any apps you might have.
Future
acceptError will panic on unexpected error codes (ones that are not programmer errors or accepted by the calling function). This ensures that we will be able to catch such errors should we accidentally miss them in the future when updating the 'vendored' GLFW C sources.
I'm confident this change works with GLFW 3.1, but in the future we will need to carefully review changes to the C sources (specifically looking for new places errors might be generated) to ensure that we return them appropriately.

Everything looks in correct order.

glfwCreateWindow
glfwInit
glfwIconifyWindow
glfwRestoreWindow
glfwGetClipboardString

Just in case let's take some time to make sure that above are the only functions with recoverable errors. Because if not we will have to break compatibility after the release. Or worse, live with an inconsistent API :p

Sorry I've not yet had a chance to give this as much attention as I want to, but I just want to quickly comment now that from my brief look, this is a good change and it has my support.

Ok, I've looked the PR over and I think it looks good. I would say we could merge it (into devel_glfw3.1 branch), and continue testing it with our own apps before official 3.1 PR merge into master.
However, before I say that, I want to bring up a point that I've discovered in the last hour when I was hacking on my experimental browser backend for glfw.
Namely, consider this func:
func (w *Window) SetInputMode(mode InputMode, value int) error

After this PR, it becomes:
func (w *Window) SetInputMode(mode InputMode, value int)

It seems that on all curent desktop backends (Win32, Cocoa, X11, Wayland, MIR, etc.) all input modes can never fail.
On the other hand, something like glfwIconifyWindow or glfwGetClipboardString can fail and it maintains an error return.
So, when implementing SetInputMode for the web, namely setting the cursor mode to one of CursorNormal, CursorHidden, or CursorDisabled, I realized that the first two will always succeed so no error return is needed, but CursorDisabled requires use of Pointer Lock API, which prompts the user for permission:

If the user says no, setting the cursor mode to CursorDisabled will fail, and ideally I would like for SetInputMode to be able to return an error code indicating denied permission, etc.
What if one of the desktop backends in the near future will have similar reasons why SetInputMode can sometimes fail, will we be able to easily add a return error type?
Just... wanted to share my findings, any thoughts? Basically, I'm starting to worry we're locking ourselves to current situation in terms of which funcs can return errors, and should anything unexpected happen and a new func needs to return errors, we have no way to do that except to break API. :/

Basically, I'm starting to worry we're locking ourselves to current situation in terms of which funcs can return errors, and should anything unexpected happen and a new func needs to return errors, we have no way to do that except to break API. :/

That worries me as well. Because of the way GLFW handles errors, it's easy for mainstream to return errors and not break API.

Although, with SetInputMode you don't necessarily break API as the return value will just be ignored. It's a problem when there is multiple return values.

Although, with SetInputMode you don't necessarily break API as the return value will just be ignored. It's a problem when there is multiple return values.

That's true, but SetInputMode is just an example that I ran into. Another func may already have a return value, so adding error cannot be done seamlessly.

The advantage of having errors in the API, while sometimes more verbose, is that future error changes will not create extra work for us and users to update. It makes the API more future proof.

I really wish GLFW was just using the C method of handling errors which is just return it. That would a lot easier for us but also for GLFW users as well I believe.

I really wish GLFW was just using the C method of handling errors which is just return it.

I don't see how that's relevant to us, since we achieved that by using channels (aside from making our API more different than the C one). But I don't think the C API can have that because C doesn't support multiple return values, so a func like window = glfwCreateWindow cannot return both a window and error code.

The primary problem, as discussed largely already, is that GLFW does not document which functions exactly return which errors. Moreso, the C API is not as strictly tied to this documentation (if it existed).
If we return an error from every function
It's rather annoying and people will likely end up either ignoring them (which is fine for now, because not many functions generate errors, as seen here) or "just" printing them to stdout/stderr (is this really any better than a error handler callback?).
If we return an error for just those that actually generate them today
People will be more inclined to actually prepare to handle them appropriately and I think less buggy code will be written by the community at large.
Conclusion
I realize that this change isn't backwards compatible for future GLFW versions. If we merge this change, we're going to end up exposing more errors later (I have no doubt).
But I fear if we don't merge this, we risk creating a bad API that will encourage developers to write programs that don't handle errors -- just because we want to keep future compatibility.

Whoops, I was swiping dust off my trackpad, and... Sorry.

I'm inclined to agree with you. Let's merge this and test it.
Any new errors will have to wait for 3.2 then.

Hypothetically speaking: if GLFW uses semantic versioning, they should not add new errors for any existing functions as C code using it would also not be prepared to handle it.


Mekanism has built-in crafttweaker support now(1.16)

can you add mekanism to the docs? That's my go to for scripts, an I assumed it wasn't supported when it was missing. Just found out you can get scripts with /ct examples.

It's being worked on https://github.com/CraftTweaker/CraftTweaker-Documentation/pull/498


Automated cherry pick of #4533: devtool: use public influxdb endpoint

Cherry pick of #4533 on release/3.0.
#4533: devtool: use public influxdb endpoint

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.0@275832f). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.0   #4534   +/-   ##
=============================================
  Coverage               ?   6.83%
=============================================
  Files                  ?     522
  Lines                  ?   88600
  Branches               ?       0
=============================================
  Hits                   ?    6052
  Misses                 ?   82043
  Partials               ?     505

Flag
Coverage Δ

#aFlag
6.83% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275832f...a47bdf3. Read the comment docs.


Initial commit for milestone 3

Modules for rest and spring mvc are created.
Started work with rest.

Also we should probably log all operations on REST and WebUI layer (probably with TRACE level).

I think the logging in this way will be enough. The missing javadoc will be added later, while testing the usability. In case I have forgotten anything else please write it here.


password

hello could you tell me what is the password to access the website and thank you

I have update, please create a file: .env from .env.example then change password in key: TRADOVATE_AUTHENTICATION_PASSWORD

asd123


Request to add two new talks for 2015

Hello,
Great initiative. I use this repo as a reference many times. I would like to point out two recent talks.

What if the user was a function?
** This is an interesting talk about modeling interaction with computers as a pure function, and just a description of functional programming but applied to the ui. It is a novel way of thinking about user interactions, async events, etc. Fits in well with a couple of other talks on the list about functional reactive programming.
Transform your code
** Very informative talk from the gentleman at Etsy about maintainability of code and code-bases and how to evolve them step by step. Very helpful after the initial design stage of the code. Since majority of time is spent maitaining code, I personally get a lot of utility out of practical talks such as this.

Thanks

:+1:

@a-s-o, thanks for the PR. I'll watch them later this week so we can discuss.

@a-s-o, merged. Thanks :+1:


Restore original url after completion

I think whats currently a little annoying with this extension is that it doesn't reload the original page I was trying to open or had open (after computer restart). This makes it hard to remember what I was planning to do or doing the day before. The only solution is to go through your browser history to find it.
I'm probably going to work on this myself and push a fix out there.

welp, i spent an entire day trying to figure this out and nothing quite worked like I wanted it to. Does anyone have any suggestions? Somehow I want to capture the searched URL before it redirects. The listener keeps updating the value which doesn't work when you have multiple tabs. I think the issue has to do with how the redirect is set up, not letting the initial query load nor saving it, simply forcing a redirect regardless of query.


Will Terra 1 to 1 for 1.18 come at some point?

Because it's boring with 1.12.

Considering the fact that Terra 1 to 1, and It's fork TerraPlusPlus both use CubicChunks to support "unlimited" heights, It's all dependent on the development of CubicChunks. Last time I checked on their Discord, the Fabric version for 1.17 is in development with the Forge version coming later.

btw the 1.17.1 version is out


refactor: move function for creating managed field entries

Extracted from https://github.com/cert-manager/trust-manager/pull/378 - which should show the motivation for this refactoring: I want to extract the code for handling configmap/secret targets out of the huge bundle package. The test utility function moved in this PR is used in tests that I want to move, but also in tests that should remain in the package.
If you think there is a better location (package) for this test utility code, please let me know.

@SgtCoDFish I have now resolved the conflicts (and added a missing import alias). Could you take another look, please? :-)


Fixes error when no transactions are returned

If the API returns no transactions response.json().history is not an array, so length method causes error.

thanks @rjmacarthy !


Is this the correct way to resolve an illegal memory access error during Triton sample run?

I have tried to do a sample run of attitude pose estimation in Triton at the following URL
https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_pose_estimation/blob/main/docs/dope-triton.md
During the inference, the following error occurred and Triton stopped.
[component_container_mt-1] I0126 01:35:07.639006 9674 tensorrt.cc:1546] Created instance Ketchup on GPU 1 with stream priority 0 and optimization profile default[0];
[component_container_mt-1] I0126 01:35:07.639250 9674 model_lifecycle.cc:693] successfully loaded 'Ketchup' version 1
[component_container_mt-1] [INFO] [1674696951.465031002] [NitrosContext]: [NitrosContext] Loading application: '/workspaces/isaac_ros-dev/install/isaac_ros_nitros/share/isaac_ros_nitros/config/type_adapter_nitros_context_graph.yaml'
[component_container_mt-1] INFO: infer_simple_runtime.cpp:70 TrtISBackend id:90 initialized model: Ketchup
[component_container_mt-1] 2023-01-26 01:35:51.851 WARN  extensions/triton/inferencers/triton_inferencer_impl.cpp@419: Incomplete inference; response appeared out of order; invalid: index = 1
[component_container_mt-1] 2023-01-26 01:35:51.851 WARN  extensions/triton/inferencers/triton_inferencer_impl.cpp@421: Inference appeared out of order
[component_container_mt-1] 2023-01-26 01:35:53.663 WARN  extensions/triton/inferencers/triton_inferencer_impl.cpp@419: Incomplete inference; response appeared out of order; invalid: index = 2
[component_container_mt-1] 2023-01-26 01:35:53.663 WARN  extensions/triton/inferencers/triton_inferencer_impl.cpp@421: Inference appeared out of order
[component_container_mt-1] ERROR: infer_trtis_server.cpp:259 Triton: TritonServer response error received., triton_err_str:Internal, err_msg:INPUT__0: failed to perform CUDA copy: an illegal memory access was encountered
[component_container_mt-1] ERROR: infer_trtis_backend.cpp:603 Triton server failed to parse response with request-id:436 model:
[component_container_mt-1] ERROR: infer_trtis_server.cpp:259 Triton: TritonServer response error received., triton_err_str:Internal, err_msg:INPUT__0: failed to perform CUDA copy: an illegal memory access was encountered
[component_container_mt-1] ERROR: infer_trtis_backend.cpp:603 Triton server failed to parse response with request-id:437 model:
[component_container_mt-1] [ERROR] [1674696993.171526632] [NitrosImage]: [convert_to_custom] cudaMemcpy2D failed for conversion from sensor_msgs::msg::Image to NitrosImage: cudaErrorIllegalAddress (an illegal memory access was encountered)
[component_container_mt-1] 2023-01-26 01:36:33.172 WARN  gxf/std/greedy_scheduler.cpp@221: Error while executing entity 101 named 'UHCWSJBWPU_tensor_copier': GXF_OUT_OF_MEMORY
[component_container_mt-1] 2023-01-26 01:36:33.172 ERROR gxf/std/entity_executor.cpp@200: Entity with 108 not found!
[component_container_mt-1] [ERROR] [1674696993.172143709] [dope_inference]: [NitrosPublisher] Vault ("vault/vault", eid=108) was stopped. The graph may have been terminated due to an error.
[component_container_mt-1] terminate called after throwing an instance of 'std::runtime_error'
[component_container_mt-1] terminate called recursively
[ERROR] [component_container_mt-1]: process has died [pid 9674, exit code -6, cmd '/opt/ros/humble/install/lib/rclcpp_components/component_container_mt --ros-args -r __node:=dope_container -r __ns:=/'].

I searched for the error statement  and found a method to change the environment variable GPU_LAUCH_BLOCK=1.
I tried this environment variable and it now runs without errors.
Is this the correct way to resolve this error?

The error is that your device ran out of GPU memory when loading this model and running inference. Using CUDA_LAUNCH_BLOCKING=1 (see here), we force CUDA to load launch blocks in sequence rather in parallel which is likely lowering your memory high watermark enough to run. It will resolve the error for you at the cost of launch time performance.


Refactor Muted Topics into a single class

Consolidating logic for Muted Topics into a single class, removing it from the startup path in ZulipApplication onCreate.
Also includes upgrade to Gradle packages.

Automated message from Dropbox CLA bot
@niftynei, it looks like you've already signed the Dropbox CLA. Thanks!

This has been merged.


Update supported versions

We only officially support 1.11 LTS and 2.0 in the latest version.

Coverage remained the same at 94.267% when pulling 3717b6e2494a9f5e8b1ac388aee7b261b150321c on slurms:patch-3 into db4474dc149245164457ba2d262a17bbeb4ebf0a on justquick:master.

Coverage remained the same at 94.267% when pulling 3717b6e2494a9f5e8b1ac388aee7b261b150321c on slurms:patch-3 into db4474dc149245164457ba2d262a17bbeb4ebf0a on justquick:master.

Coverage remained the same at 94.267% when pulling 3717b6e2494a9f5e8b1ac388aee7b261b150321c on slurms:patch-3 into db4474dc149245164457ba2d262a17bbeb4ebf0a on justquick:master.

Coverage remained the same at 94.267% when pulling 3717b6e2494a9f5e8b1ac388aee7b261b150321c on slurms:patch-3 into db4474dc149245164457ba2d262a17bbeb4ebf0a on justquick:master.

Coveralls is being crazy, perhaps the travis config isn't quite right :joy:


Spirit items

Some people in Mage discord were asking for these 2 spirit buffs to be available in the sim, so I added them.

Is there any link for some proof that this stacks?
Not that I don't believe it I just wanna make sure we're right about this.
Don't have any kreegs in my bank unfortunately.

I made my guildmate who asked for this change do some more tests. Here's the results showing that Kreegs and spellpower food (for example) can stack, as well as Divine Spirit.
https://cdn.discordapp.com/attachments/684044330066771989/860252321333772318/unknown.png


Images do not have alt atributes

All have been done besides the hero div, which requires changes to the CSS and HTML to get done.

All images are now linked in the HTML and have attributes.


Add batched mode for faster inference on pre-recorded conversations

Problem
Running the online diarization pipeline on an entire dataset can be difficult and slow because the current implementation simulates an online scenario and processes one chunk at a time.
This is the way to go in a real-time scenario but it would be very useful to have a faster implementation for evaluation, for example to see the performance impact of swapping a component (issue #34 is a good example).
Idea
Pre-calculate segmentation and embeddings for all chunks in a file and only run clustering and output reconstruction online, this would considerably speed up the process. It could be hosted in a new BatchedOnlineSpeakerDiarization class implementing the same interface as OnlineSpeakerDiarization

Changes added as part of PR #46.
Implemented as OnlineSpeakerDiarization.from_file()


KYLIN-4112: Add hdfs keberos token delegation in Spark to support se and MR use different HDFS clusters

See: https://issues.apache.org/jira/browse/KYLIN-4112

Codecov Report

Merging #774 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #774      +/-   ##
============================================
- Coverage     25.69%   25.68%   -0.01%
+ Complexity     6022     6020       -2
============================================
  Files          1387     1387
  Lines         82868    82873       +5
  Branches      11598    11600       +2
============================================
- Hits          21295    21289       -6
- Misses        59521    59536      +15
+ Partials       2052     2048       -4

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/kylin/engine/spark/SparkExecutable.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...ream/core/storage/columnar/ColumnarStoreCache.java
51.16% <0%> (-3.49%)
8% <0%> (ø)

...eam/core/storage/columnar/DataSegmentFragment.java
57.37% <0%> (-1.64%)
17% <0%> (-1%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
70.21% <0%> (-0.92%)
7% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
66.15% <0%> (+2.3%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d3d12...3b68815. Read the comment docs.

Pull Request Test Coverage Report for Build 4792

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.007%) to 28.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java
2
56.98%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/DataSegmentFragment.java
6
67.21%

Totals

Change from base Build 4778:
-0.007%

Covered Lines:
23340

Relevant Lines:
82873

💛  - Coveralls

@shaofengshi Thanks for your reminding.
We use spark 2.1 in xiaomi.
I will check the config in Spark 2.2 and update the PR.

@shaofengshi The config is changed since spark 2.2
"spark.yarn.access.hadoopFileSystems" -> Seq(
  AlternateConfig("spark.yarn.access.namenodes", "2.2")),

@shaofengshi  @nichunen I will compress the pr if the update is OK.


Paraquire - paranoidal require

NPM ecosystem is quite unresistant against dependency attacks. It means that if a hacker gets control over one small abandoned package, the hacker gets control over all it's dependents, dependents of dependents, etc.
So, hijacking only one of small chalk's dependencies will be very crucial for whole NPM ecosystem. This PR improves chalks's security by jailing most dependencies into paraquire - secure alternative for standard require.

:-1: Have never seen this happen, and we control all of our dependencies (e.g. @sindresorhus and I own all of them).
Further, this would introduce yet another dependency that we do not control, and at 32+ million downloads a month I don't even want to begin chancing something like this.
Sorry but I have to decline.


The XNA/MonoGame sample doesn't build

I'm incorporating the XNA/MonoGame ImGui.NET sample code into my blank MonoGame project.
I've added ImGui.NET 0.4.7 as a reference via Nuget and added the import ImGui; line at the top of the ImGuiRender.cs file.
I'm greeted with a slew of errors upon building however:
private unsafe void RenderDrawData(ImDrawDataPtr drawData)
"The type or namespace name 'ImDrawDataPtr' could not be found (are you missing a using directive or an assembly reference?) (CS0246) (MonoBoy.Desktop)"
var context = ImGui.CreateContext(); ImGui.SetCurrentContext(context);
"ImGui does not contain a definition for 'CreateContext()'"
"ImGui does not contain a definition for 'SetContext()'"
var io = ImGui.GetIO(); io.Fonts.GetTexDataAsRGBA32(out byte* pixelData, out int width, out int height, out int bytesPerPixel);
"IO does not contain a definition for 'Fonts"
There are more, but I think you get the picture.
Any ideas what's going on here?

The sample code that is in master now works with the 1.65.0-beta1 NuGet package, and isn’t compatible with the 0.x versions. You could either grab that version (which should be reasonably stable despite being a beta), or you could go back a few commits and grab the 0.x-compatible sample code.
Let me know if that helps.

I see what's going on now (I was actually "using" 1.65.0-beta1.
Could not install package 'ImGui.NET 1.65.0-beta1'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
I forgot that ImGui.NET (your version) only targets .Net Core

ImGui.NET targets .NET Standard 2.0, not .NET Core. You can reference it from .NET Framework, mono, or .NET Core, but not such an old version of .NET Framework. You can just upgrade your target to netfx 4.7 and then install ImGui.NET. If it’s any encouragement, I don’t think .NET 4.5 is even supported anymore.


Certain exercises not working

Matching pairs
https://user-images.githubusercontent.com/126022857/220459174-e101d4be-e016-4e78-964f-d16bd8dbd2a4.mov
Fill in the blanks (with images)
https://user-images.githubusercontent.com/126022857/220460221-15d904d0-72bd-42f2-b99c-396be91f0bf0.mov
not being impatient but is this repo gonna get updated eventually?

Yeah blanks not working for me either, it does work on less developed languages like Zulu and others which don’t have the fill in the blanks. It doesn’t work in Spanish Russian or french for me. Which language are you using it on?

The matching pairs video is from the Esperanto course (pretty much for every course). The fill in the blanks was recorded from the French course (the ones with images are for the major courses, like Spanish, French)

grammar concepts (german and spanish)
https://user-images.githubusercontent.com/126022857/220665269-ddbc9173-8721-4ef1-96ca-364b949c424f.mov
https://user-images.githubusercontent.com/126022857/220667387-d4581ee6-a302-40b6-8c2d-1da22aec784e.mov

yeah thats exactly the issue im having :/
hopefully the issue is updated.

YES, I AM GETTING TONS OF ERRORS in the extension developer part of my browser. The common one being about a 'typing enabled' part of the code? had issue before and is persistent on and off???
reply thanks :)

i got it working, look at my recent issues post or my repository of autolingo titled FIXED. 👍


[STYLE CHANGE] Upgrade Error Notifications to React Toastify Notifications. {GSSoC'23}

Description:
Change the user not found error event notification from a simple notification to a React Toastify notification to enhance the visual appearance.
Reason for Change:
Description:
Change the user not found error event notification from a simple notification to a React Toastify notification to enhance the visual appearance.
Reason for Change:
The current simple notification style lacks visual appeal and may not effectively capture the user's attention. By using React Toastify notifications, we can improve the overall user experience and provide a more visually appealing way to communicate error events.
Current Styling:
Currently, when a user is not found, or any error events a simple notification appears there itself. The notification is plain and lacks any specific styling or animation effects.
Proposed Styling:
The proposed styling involves using React Toastify notifications for the user not found error event. React Toastify provides customizable, animated notifications that can be styled to match the application's design and branding. The notification should have a distinct appearance to differentiate it from other notifications.

Priority Level (optional):

[ ] Low
[x] Medium
[ ] High

Possible Implementation Approach:

Install the React Toastify package using a package manager like npm or yarn.
Create a new component or modify the existing notification component to use the React Toastify API.
Customize the notification appearance and animation according to the application's design.
Update the error handling logic to trigger the React Toastify notification for the user not found error event.
Test the implementation thoroughly to ensure proper functionality and visual appeal.

Additional Information:
Please assign this issue to me under GSSoC'23 so that I could change the style ASAP.

We don't need that notification. You can see it everywhere, it will look so common.


Fancy Zones always forgetting layout

Microsoft PowerToys version
0.56.2
Running as admin

[ ] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
often after sleep but also just periodically. Need to force close PowerToys and reopen to reset Layout to my custom one. really gets on my nerves as the custom layout is the main thing I use PowerToys for. And "almost" every time I'd like to use FancyZones I have to first cycle PowerToys which kind of defeats the purpose of it.
✔ Expected Behavior
FancyZones should just remember my Layout
❌ Actual Behavior
Fancy Zones forgetting my Layout and just showing the default one.
Other Software
No response

/bugreport

PowerToysReport_2022-03-22-10-12-31.zip

I also see this problem.  This isn't a new issue with the latest update.  This has been an issue since I installed this a couple of years ago.  I keep hoping it'll be fixed every time I update, but so far, no-luck.  I haven't been able to identify what causes it (like a reboot or anything).

I'm also getting this.

Thanks for the reply. As I can see in the applied-layouts.json, there are both resolution problem and wrong monitor names. This issue will be resolved with those two: https://github.com/microsoft/PowerToys/issues/16370, https://github.com/microsoft/PowerToys/issues/14261.
I'll close this one as a /dup.


Same credentials works on mac but not on Linux

SQL Operations Studio Version:
MAC - Version 0.30.6
Ubuntu - Version 0.30.6

Steps to Reproduce:
We are trying to connect a remote SQL server. When we try to connect through mac it connects successfully whereas when we try to connect though linux(Ubuntu 16.04) it gives the following error:
System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 35 - An internal exception was caught) ---> System.Net.Internals.SocketExceptionFactory+ExtendedSocketException (00000005, 6): No such device or address    at System.Net.Dns.InternalGetHostByName(String hostName)    at System.Net.Dns.GetHostAddresses(String hostNameOrAddress)    at System.Data.SqlClient.SNI.SNITCPHandle.Connect(String serverName, Int32 port, TimeSpan timeout)    at System.Data.SqlClient.SNI.SNITCPHandle..ctor(String serverName, Int32 port, Int64 timerExpire, Object callbackObject, Boolean parallel)    at System.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling)    at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)    at System.Data.ProviderBase.DbConnectionFactory.CreateNonPooledConnection(DbConnection owningConnection, DbConnectionPoolGroup poolGroup, DbConnectionOptions userOptions)    at System.Data.ProviderBase.DbConnectionFactory.<>c__DisplayClass40_0.<TryGetConnection>b__1(Task1 _)
at System.Threading.Tasks.ContinuationResultTaskFromResultTask2.InnerInvoke()    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location where exception was thrown ---    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.SqlTools.ServiceLayer.Connection.ReliableConnection.ReliableSqlConnection.<>c__DisplayClass28_0.<<OpenAsync>b__0>d.MoveNext() in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Connection\ReliableConnection\ReliableSqlConnection.cs:line 298 --- End of stack trace from previous location where exception was thrown ---    at Microsoft.SqlTools.ServiceLayer.Connection.ConnectionService.TryOpenConnection(ConnectionInfo connectionInfo, ConnectParams connectionParams) in D:\a\1\s\src\Microsoft.SqlTools.ServiceLayer\Connection\ConnectionService.cs:line 542 ClientConnectionId:00000000-0000-0000-0000-000000000000
We have cross-checked multiple times to make sure the server name and credentials are same on both mac and linux, still no success.

It works now. We were trying to connect using server name before, then when we tried using server IP and sql operations studio got connected on linux.
The SQL server version is Microsoft SQL Server 2012  - 11.0.7462.6 (X64).

@naureen-34 thanks for the update.  This sounds like a network or DNS issue on the Linux machine.  I'll close this issue.  Please reactive if you have additional issues.


QuickJS C to host error after event triggered many times with certain params of postMessage

Describe the bug
When use a plugin using react & react-dom (project struture similar to plateauview project repo) after plugin events triggered a certain times there comes the error [C to host error: returning null] Error: QuickJSContext had no callback with id -32379;
NOTICE:

Here's a simplified js version:

reearth.ui.show(`
  <script>
    addEventListener("message", e => {
      if (e.source !== parent) return;
      console.log('mousemove with pure javascript');
    })
  </script>
`);

reearth.on('mousemove', (e)=>{
  reearth.ui.postMessage(e);  // This works fine.
  reearth.ui.postMessage({foo:e}); // This will lead to error.
});

To Reproduce
Steps to reproduce the behavior:

Copy the upper code into plugin editor and run it.
Mouseover and watch the console log.
See the error (after around 4648 triggers on my machine).

OR -

Download & install the test plugin zip file from https://github.com/airslice/reearth-plugin-toolbox/tree/event-tester/package
Add widget.
Mouseover and watch the console log.
See the error (after around 4648 triggers on my machine).

Expected behavior
Should not has the error.
Screenshots

Desktop (please complete the following information):

OS: [macOS]
Browser [chrome]
Version [104.0.5112.101]

Additional context
Add any other context about the problem here.

reearth.ui.postMessage({ foo: mousedata }) -> error
reearth.ui.postMessage(mousedata) -> fine

Update: this error contiunes throwing out when enabled some plugin widget.
Reproduce on test env:

Create a new project.
Install example plugins. (https://github.com/reearth/plugin-example)
Add the ISS widget.
Wait for about 40 seconds and watching the console log.
See the error.

For plugin developers: you can try JSON stringify the data object and use the json string as post data to temporarily avoid meeting this bug.


Adding support to table of contents

Adding support to left menu

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

MicrosoftCollaboratePortal/TOC.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


WebComponent: Setting groupColumnDef causes exception

I'm attempting to specify a group column manually, but it looks like there's a some sort of missing reference.
Looking at line the following (compiled) line
AgileGridProto.onChange = function (changes) {
grid.ComponentUtil.processOnChange(changes, this.gridOptions, this);
};
Should actually be this._gridOptions. That said, with that modification the eventing gets in a change loop and crashes.
It doesn't appear possible at the moment to use groupColumnDef

are you trying to set columnDefs?
there is no such property groupColumnDef. you specify the groups as columns and then set using columnDefs property.
see the online examples for how to create groups of columns:
http://localhost/angular-grid-grouping-headers/index.php

No? It's mentioned in the API several times, and the code?
http://www.ag-grid.com/angular-grid-grouping/index.php
"groupColumnDef	Allows specifying the group 'auto column' if you are not happy with the default. If grouping, this column def is inc"
The property is also exposed as a simple attribute.
Has this been deprecated?

I had originally used columnDefs, and groupKeys but assumed the groupColumnDef provided more functionality. In that case am I best using columnDefs and specifying a group renderer?

ops, sorry, my fault, i take back all of the above!! my head is deep in code and i'm trying not to take to much time on forums etc as it distracts me. let me take a look . . . .

No worries, I use your library quite heavily so if I spot something I'll generally have a dig through the code first to see if I can spot anything

great your using the grid heavily. with such a small complain, sounds like it's working out quite well for you!

i am guessing you are setting the property AFTER you initialise the grid? not all the properties are updatable via web components properties yet. just i haven't gotten around to it. to see the status, you can check it here:
https://github.com/ceolter/ag-grid/blob/master/src/ts/components/componentUtil.ts
basically the properties WITH_IMPACT_ are the ones that you can set after the grid is initialised. the other ones, you only get to set them once, and if you want to change them, then you have to either set them directly on the gridOptions, or use an appropriate API method (if it exists).
in time, i'll change all the properties over to 'have impact', especially given i'm starting to integrate now with React, which will have the same problem and i presume many more people using React and ag-Grid than web components.
in the mean time, set the property you need on gridOptions. the one in question, groupColumnDef, doesn't actually do anything when you set it, it just 'gets used' next time the grid is rendering. so set it, then call one of the api.refresh methods.
ps i'm closing this, as it's not specific to groupColumnDef. if you want to open up another one for 'have all options impact' then you can, but i'm aware of this, and as i said, with react coming online with ag-Grid, i'll be dealing with this anyway.


Media Manager revamp (2.0)

I think we have to improve the media manager, quite a lot if we want to provide better handling of file-related input fields.
Why?

The main point is being able to select a file (or files) from BREADs by simply browsing a list of files or upload a new one in the moment. Actually, you can only modify a file for a BREAD by uploading a new one, and "leave it blank" when editing the whole BREAD entry. We can't use something like required validation rule on that field because of that.
This is an example of what I'm talking about #973

How?
This is how I would address the project

Create 2 components: media/Browser.vue and media/FileInput.vue with the following API:

Browser.vue

Props
Values
Description
Default

selectable
(string) single/multiple
If provided, an extra button will show up when selecting one (or more if its `multiple`) file to chose it, and set the input to the file's URL(s)
null

file-types
(array) []
If provided, the browser shall list only the given file types (for input modals mostly)
[]

accepts
(array) []
Used for file upload puproses, see input
['jpg','png','gif']

FileInput.vue

Props
Values
Description
Default

Since its kind of a wrapper for the browser, it accepts all props for Browse.vue plus some more. It doesn't shows the file browser by default, just opens a modal with it instead and displays selected files as thumbnails with controls

Then call Browser.vue from /admin/media and FileInput.vue from /{bread}/{create / edit} (which can be a bit tricky at the moment of loading the js file once, the formField view should be able to @push('scripts') this file, but we have to realize how to handle multiple file fields.

Basically, FileInput component hides a text input with a "stringified" JSON that we json_decode/encode server-side for a list of files, depending if the field works for single or multiple files, and save it into DB just like that.
Internally, the Browser may calculate the directories (like a router) based on the file URL and open in that specific folder if a file was already chosen previously.
Caveats:

A proper vue.js development implies the use of a build tool (like laravel-mix). We can't force every user to manually include our assets to their webpack.mix.js file so in that case, I think a new command php artisan voyager:build or something like that (we can even extend the current voyager:install to also compile assets) would be needed. Unless we want to provide a built-in bundle and simply use the publishing functions, to be honest, I'm not sure about it.

I'd like to know your thoughts and suggestions on this before getting hands dirty.

At the moment I still don't know how the Media Manager works. Will take a look at it later.
For developing View components, we can use Blade (like in the database section).
Using that approach, we won't need a build tool. Also, they will be easy to include in the Views, we can create helper functions for that. And in case we ever need to switch to proper single file components, it won't be hard to migrate them.

While doing this complete remake. I also recently found this Finder that we maybe could get a lot of experience from. Their system reminds me a lot of the finder that is available on Mac.
According to handling the Vue.js development and allowing full flexibilty to the users, we should publish and build the Vue components as you say, but let anyone overwrite any component if possible.

@abdgad I think you got reaaally confused about Vue and components. I was not talking about Blade at all.
@marktopper that library looks really good, but I think it would be a bit easier to implement our own media browser, instead of trying to adapt that one to our needs. Specifically talking about file inputs, input edition, thumbnails and such...
Also there's a contradiction on that about overwriting vue components. That's not possible if we provide the already-bundled js file. I think they can simply override the php view and provide their own libraries, but to be honest, I don't see the point to let users override specific components of the media manager interface.
If we provide the js bundle, then we may need to work with our own compilation script and commands, which is not a big deal but its something to take in mind.
I'm talking about npm run dev commands but instead of the ones at the project's root, we use a package.json on voyager's root.
Now my question is, laravel-mix or laravel-elixir-webpack? Because mix comes with L5.4+, we have to be able to compile these assets also in previous versions. Which leads us to make probably laravel-mix a dependency of voyager.
And that leaves us clean road to keep migrating any other UI components to Vue (or similar) in the future, if needed.

@Frondor the database manager is built with Vue components, which are put inside Blade templates (example).
I know this approach isn't the best, but it doesn't require any build tools. And it can be easily migrated to Vue single file components.

Now I think I get you! Hmm... Yes, that practice is not good at all.

Hi, I have successfully installed voyager but images are not showing. It says, permission denied(firebug). All image links are not working.
How can I go about this? It looks like storage folder is not accessible publically.

I am fine with including it in the install as long as there's an option to only build.
e.g. php artisan voyager:install --build


Updates to Transceiver-3:zr_firmware_version_test

Corrected the logic to get the opticalComponentName, in accordance with the YANG documentation.
In the previous logic the code was to get the optical component name by traversing through the parents of the PORT component, this was leading to no results. Hence changed it to find the OPTICAL_CHANNEL comp first and match its parent against HARDWARE_PORT of the interface.
Current flow :                     PORT <-- TRANSCIEVER <-- OPTICAL_CHANNEL

Pull Request Functional Test Report for #2891 / 6571db4fef174b18eda35f76cb3748ed8490acba
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Cisco 8000E

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Cisco XRd

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Juniper ncPTX

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Nokia SR Linux

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Openconfig Lemming

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Cisco 8808

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Juniper PTX10008

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Nokia 7250 IXR-10e

TRANSCEIVER-3: Telemetry: 400ZR Optics firmware version streaming

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.448%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1949

Relevant Lines:
3515

💛  - Coveralls

A couple things:

You might have an old version of the tests. The func you are modifying is in this file. Can you please update:
https://github.com/openconfig/featureprofiles/blob/main/internal/components/components.go#L203

I agree the current approach could probably be improved. Looking at the code the "PORT" referenced above and what is used in that function is the "interface" name:
interfaces/interface/[name]

Technically, to traverse through OpenConfig to an OpticalChannel you'd have to go through the terminal-device logical-channels

But I think a simpler option is to utilize this path which is a reference to a transceiver:
interfaces/interface/[name]/state/transceiver
If we read that leaf you'd then have the transceiver component to look up. We could then get the subcomponents of the transceiver component to find the optical-channel component.
I don't think this is too far from your current approach, but avoids creating any expectations of interface and component names being equal.

@ejbrever I have changed the code to directly use AssociatedOpticalChannel Leaf.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 55.407%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/components/components.go
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>8:
0.2%

Covered Lines:
1983

Relevant Lines:
3579

💛  - Coveralls


Staging

Coverage decreased (-4.0%) to 92.742% when pulling 9ff82d0524b013047cb42f17c654916bd2d333c9 on staging into 9c96c92b39a3a186c3718d55e988a8a4b274ce42 on master.


Username and password not working

Can we adjust the code so that when an update is being made to the editor it does not wipe out username and password too?

Yes, this should be working by 6/3.

@carmstrong1gw this has been solved, correct? Please comment with commit and close if so.

This has now been resolved and I can use the same login credentials that I've created.


Due to the large size of the trace file, using the --httpd method to display it in the Perfetto UI is very slow. When selecting a range or an event, the query response is extremely slow. I suspect this is due to the slow performance of SQLite queries. Additionally, updating the web interface is also very slow, and sometimes it doesn't return results at all.

Given this issue, my current consideration is to record for a certain period, then stop, and start a new recording to continue.

Additionally, updating the web interface is also very slow, and sometimes it doesn't return results at all.

Can you check if this happens only if you have a search open or all the time? There's a KI where having a search slows everything else down.

When selecting a range or an event, the query response is extremely slow

I'd rather spend engineering time fixing these issues than making splitting/merging work properly :)

Sure, once I finish the work at hand, I'll come back to analyze this issue. There's a time difference of about 6 hours between us, so my responses might be a bit slow.


[stable/keycloak] Use standalone.xml config file when only using 1 replica

Signed-off-by: Michael Dop<EMAIL_ADDRESS>What this PR does / why we need it:
Use standalone.xml config file when only using 1 replica
Which issue this PR fixes
fixes #7679
fixes #9070

/ok-to-test

/retest

/lgtm

@unguiculus Disclaimer, I am exploring the tool now, so I am not aware of the details of the implementation.
standalone-ha.xml is configured on several other locations. Should not this logic be applied there too, or maybe use a helper variable instead?
Example other location: https://github.com/helm/charts/blob/577a48db1bb1fd6fa931b74f411b83526a598cb1/stable/keycloak/templates/configmap.yaml#L28


HSEARCH-3530 Update the date formats in the reference documentation

https://hibernate.atlassian.net//browse/HSEARCH-3530

Pull Request Test Coverage Report for Build 1

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.695%

Totals

Change from base Build 180:
0.0%

Covered Lines:
16546

Relevant Lines:
18655

💛  - Coveralls

Merged, thanks!


Client crash on out-of-range integer update using Postgres

Bug description
When working with postgres integer columns, certain javascript numerical values produce unexpected results or even cause a full client crash.

Attempting to update an integer column to 32e100 (out of range) causes a full client crash
Attempting to update an integer to<PHONE_NUMBER> (out of range by 2) causes a wrap around to -2147483647

How to reproduce
A minimal reproduction is available at https://github.com/gristow/prisma-int-overflow
schema.prisma
// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Integer {
  id Int @id @default(autoincrement())
  integer Int @default(1)
}

To reproduce client crash:
  const firstRecord = await prisma.integer.create({
    data: {
      integer: 1,
    },
  });

  // This is well outside the limit for a Postgres integer type.
  const newIntegerValue = 32e100;

  // This update should throw an error, ideally an "integer out of
  // range" error, as Postgres would. Instead, it crashes the
  // prisma client.
  await prisma.integer.update({
    where: {
      id: firstRecord.id,
    },
    data: {
      integer: 32e100,
    },
  });

To reproduce the unexpected integer wrap-around:
  const record = await prisma.integer.create({
    data: {
      integer: 1,
    },
  });

  // The max value for a PG integer is<PHONE_NUMBER>. This value is intentionally
  // too large.
  const newIntegerValue =<PHONE_NUMBER>;

  // This update should throw an error -- ideally an "integer out of range" error
  // as postgres would directly. But it throws no error.
  await prisma.integer.update({
    where: {
      id: record.id,
    },
    data: {
      integer: newIntegerValue,
    },
  });

  const updatedRecord = await prisma.integer.findUnique({
    where: {
      id: record.id,
    },
  });

  // Instead, the value is set to the negative wrap-around.
  assert(
    newIntegerValue === updatedRecord?.integer,
    `Expected ${updatedRecord?.integer} to be ${newIntegerValue}`
  );

Expected behavior
When attempting to update an integer column with a value that is outside of the acceptable ranges, the Prisma client should return an error, ideally one that indicates that the integer is out of range, as Postgres does natively.
Prisma information
See steps to reproduce above.
Environment & setup
MacOS 12.2.1
Prisma 3.12.0
PostgreSQL 12.8 (Debian 12.8-1.pgdg110+1) on aarch64-unknown-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
Node 16.12.0
Prisma Version
prisma                  : 3.12.0
@prisma/client          : 3.12.0
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 22b822189f46ef0dc5c5b503368d1bee01213980 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt 22b822189f46ef0dc5c5b503368d1bee01213980 (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash    : 22b822189f46ef0dc5c5b503368d1bee01213980
Studio                  : 0.459.0
Preview Features        : filterJson

Possibly related to #12526?

There's two parts to this: The crash shouldn't happen, it's more appropriate to throw an error. The other part is the overflow: This would be a feature/improvement in which the native type annotations are used for validations, because as it is, a normal int in PG is 32 bits, but we parse as 64 bit signed integer. This improvement will certainly happen at some point in the future.


Neo4J keyword index creation problem

System Info
Name: langchain
Version: 0.0.320
Who can help?
@agola11
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
When you try the tutorial:
index_name = "vector"  # default index name
keyword_index_name = "text_index"  # default keyword index name

store = Neo4jVector.from_existing_index(
    OpenAIEmbeddings(),
    url=url,
    username=username,
    password=password,
    index_name=index_name,
    keyword_index_name=keyword_index_name,
    search_type="hybrid",
)

It produces an error because in fact the keyword index is not created yet:
ValueError: The specified keyword index name does not exist. Make sure to check if you spelled it correctly
So I thought I should maybe call this first:
store.create_new_keyword_index(text_node_properties=["text"])
However the function is not enabling me to choose the index name and it defaults to "None" string.
I suggest the last method should include the name of the index.
Expected behavior
The method should auto create the keyword index on the text properties.

This my workaround for now, I perform the query creation before loading it.
index_name = "vector"  # default index name
keyword_index_name = "text_index"  # default keyword index name
store.query("""CREATE FULLTEXT INDEX text_index IF NOT EXISTS FOR (n:Chunk) ON EACH[n.text]""")

store = Neo4jVector.from_existing_index(
    OpenAIEmbeddings(),
    url=url,
    username=username,
    password=password,
    index_name=index_name,
    keyword_index_name=keyword_index_name,
    search_type="hybrid",
)


feat: Custom index for buttons in ActionSheet

Type: feat
Platform: all
It would be very helpful to be able to set custom index for buttons in ActionSheet.
At the moment we use the array index to indentify what button was pressed, but sometimes (actually lot of times) we need to dynamically add and remove buttons from menus and then it gets very inefficient to handle the button actions.
it would be so much better to be able to do:
{text: 'Button 1', index: 'button1'}

Example - Document menu
 var menuOpt = {
 buttons: [
     {text: ' Share'},
     {text: ' Page Info'}
 ],
 buttonClicked: function(index){
     if ($scope.pageAccess && $scope.pageAccess.is_administrator && $scope.page.special_page_type<1) {             // Handle admin menu
         switch (index) {
             case 0:
                 // Page Settings
                 $scope.pageSettings();
                 break;
             case 1:
                 $scope.sharePageToggle();
                 break;
             case 2:
                 $scope.showInfo();
                 break;
         }
     } else {
         switch (index) {
             case 0:
                 $scope.sharePageToggle();
                 break;
             case 1:
                 $scope.showInfo();
                 break;
         }
     }
     hideSheet();
 },
 cancelText: 'Cancel'
 };

if ($scope.pageAccess && $scope.pageAccess.is_administrator && $scope.page.special_page_type<1){ // Admin extra stuff
menuOpt.buttons.unshift({text: ' Settings'});

menuOpt.destructiveText = ' Delete Page';
menuOpt.destructiveButtonClicked = function(){
    var popup = $ionicPopup.confirm({
        title: 'Delete Page',
        template: 'Are you sure you want to delete this page? This cannot be undone'
    });

    popup.then(function(res){
        if (res) {
            deletePage();
        }
    });
    hideSheet();
}
}

var hideSheet = $ionicActionSheet.show(menuOpt);

You cna see what a pain it becomes to handle the action in ActionSheet. If we could set custom indexes it would simply the process a lot.

Actually, I am closing this as this is very easily extensible - didn't think of that - MONDAY!
You can simply add id yourself as follow:
buttons: [
    {text: ' Share', index: 'share'},
    {text: ' Page Info', index: 'info'}
],

And then handle actions:
buttonClicked: function(index){
    switch (this.buttons[index].index) {
        case 'settings':
            $scope.pageSettings();
            break;
        case 'share':
            $scope.sharePageToggle();
            break;
        case 'info':
            $scope.showInfo();
            break;
    }
    hideSheet();
},

@Tomino2112 It helped me a lot. Thanks


docs: Update README.md

I discovered some typos. Then I fix them together.
The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @miles-six thanks so much for taking the time to submit a pull request! We sincerely appreciate PRs from the community. We would love to get this change in, can you please just resolve the merge conflict and then re-request a review from me? I can make sure to get this moved through our pipeline and so sorry for the delay.

@jparr721  already down


Question for "Android Compose Add a Scrollable List"

Name of the Codelab or Codelab URL
https://developer.android.com/codelabs/basic-android-kotlin-compose-training-add-scrollable-list
Describe the problem
Just a question: in the Text composable, loading the text is achieved by
Text(text = LocalContext.current.getString(affirmation.stringResourceId))

Why is not this code used:
Text(text = stringResource(id = affirmation.stringResourceId))

What are the internal differences? Are there any benefits by using the first one? Maybe performance?
In which lesson and step of the codelab can this issue be found?
Step 3 (add a list to your app)
Versions
Android Studio Hedgehog | 2023.1.1 Canary 10
Build #AI-231.9011.34.2311.10366083, built on June 22, 2023
Runtime version: 17.0.7+0-b2043.56-10353782 amd64
codelab: basic-android-compose-training-add-scrollable-list

Hi @diskostu
Thank you for writing in with your question.
They are actually both calling the same code in the Resources.java file.
If you drill down in Android Studio on each statement they will end up at the same place in the code.
Hope you are enjoying the course!
Regards.


Fix missing srcset attributes

Build the site locally to debug and fix images with missing srcset attributes. Working only on master branch.
Missing srcset attributes (this one is a bit tricky because it may be set dynamically with .js lazyloading)

migrate to pupil docs website. closing.


268 create a max signing pages settings

[x] Change nano home and settings according to app boilerplate

[x] Created a global setting called max_pages

[x] update ux for nano to show max_pages in settings

[ ] update stax ux to show max pages in settings

UX update for stax is remaining. This PR only adds the settings. Does not use the settings. Need to create another PR where based on the settings the warnings and summary is displayed.

There are warnings during compilation. It would be better if there were none.

There are warnings during compilation. It would be better if there were none.

Removed warnings. Thanks


SubGraph Example from help doesn't work

Hi,
I was looking into the SubGraph functionality, and noticed that the example in the documentation wasn't working:
graph {
    subgraph -Attributes @{label='DMZ'} {
        node web1,web2,reports
        edge report -To web1,web2
    }
    edge loadBalancer -To web1,web2
    edge user -To loadBalancer,report
    edge web1,web2,report -To database
} | show-psgraph

this is the the message i get back:
cmdlet SubGraph at command pipeline position 1
Supply values for the following parameters:
ScriptBlock:

Ok, I found the issue:
The positional parameter for the ScriptBlock doesn't seem to work. Using a named parameter solved the issue.
For example, calling the snippet like this, works:
graph {
    subgraph -Attributes @{label='DMZ'} -ScriptBlock {
        node web1,web2,reports
        edge report -To web1,web2
    }
    edge loadBalancer -To web1,web2
    edge user -To loadBalancer,report
    edge web1,web2,report -To database
} | show-psgraph


Set User-Agent header in client

This sets the user agent for api client.
Using Provider.UserAgent to set the header.
Also, this can now take a version coming from ldflags which is added as a suffix.
Rendered example:
Terraform/ (+https://www.terraform.io) Terraform-Plugin-SDK/2.0.3 buildkite/v0.14.0-1-g3539448

Yesterday we had an acceptance spec failure caused by the test org not being cleaned properly, and I manually deleted a lingering pipeline. It's possible rebasing this on main (to get the merged GET body fix) and triggering a new build might Just Work.

I don't think it's a deal breaker in the short term, but looking at the user agents we're logging in production now it seems like maybe this only sets it for REST API calls, and not for graphql ones?

Actually yes @yob that is correct. I'll create another task to do this for graphql as well


Support Request - Terraform Provider setup for multiple accounts.

OK, so i've got a customer who has undergone this 'cloud transformation into azure' and for the most part it's gone really well.
One thing am really frustrated with is the Provider setup, with the use of "provider= azurerm.{alias}".  And more to the fact, I have to initialise 9x copies of the aztfmod module file-system, taking an absolute age to prepare a terraform-plan/apply.
Here is what I have:
<repo>
  company.tfvars
  main.tf
  provider.tf
  variables.tf

Inside provider.tf, we have:
provider "azurerm" {
  features {}
  skip_provider_registration = true
}
provider "azurerm" {
  alias           = "hub"
  subscription_id = try(var.azurerm_config["HUB"].subscription_id, null)
  client_id       = try(var.azurerm_config["HUB"].client_id, null)
  client_secret   = try(var.azurerm_config["HUB"].client_secret, null)
  tenant_id       = try(var.azurerm_config["HUB"].tenant_id, null)
  features {}
}
provider "azurerm" {
  alias           = "prd"
  subscription_id = try(var.azurerm_config["PRD"].subscription_id, null)
  client_id       = try(var.azurerm_config["PRD"].client_id, null)
  client_secret   = try(var.azurerm_config["PRD"].client_secret, null)
  tenant_id       = try(var.azurerm_config["PRD"].tenant_id, null)
  features {}
}
provider "azurerm" {
  alias           = "dev"
  subscription_id = try(var.azurerm_config["DEV"].subscription_id, null)
  client_id       = try(var.azurerm_config["DEV"].client_id, null)
  client_secret   = try(var.azurerm_config["DEV"].client_secret, null)
  tenant_id       = try(var.azurerm_config["DEV"].tenant_id, null)
  features {}
}
#etc

Clearly these config values for initialising the AzureRM providers, are referencing a variable called azurerm_config.
like so:
azurerm_config = {
  HUB : {
    tenant_id           = "**************************************"
    management_group_id = "hub"
    subscription_id     = "**************************************"
    client_id           = "**************************************"
    client_secret       = "**************************************"
    resource_group_name = "TEST-rg-hub"
  }
  PRD : {
    tenant_id           = "**************************************"
    management_group_id = "prod"
    subscription_id     = "**************************************"
    client_id           = "**************************************"
    client_secret       = "**************************************"
    resource_group_name = "TEST-rg-prd"
  }
  DEV : {
    tenant_id           = "**************************************"
    management_group_id = "dev"
    subscription_id     = "**************************************"
    client_id           = "**************************************"
    client_secret       = "**************************************"
    resource_group_name = "TEST-rg-dev"
  }
  #etc
}

Note: This entire variable is generated from a devops pipeline task, calling a PS1 script, that echo's values out of each key-vault. So these masquaraded values are never visible to developers with permission to run/troubleshoot the pipeline.
Now for my issue... calling Initialising the module.  Inside main.tf, we have:
# HUB NETWORK
module "aztfmod_hub" {
  source  = "aztfmod/caf/azurerm"
  version = "5.7.3"
  providers = {
    azurerm.vhub = azurerm.vhub // required even though there is no vhub resource in-scope
    azurerm      = azurerm.hub
  }
  global_settings          = var.global_settings
  resource_groups          = var.hub.resource_groups
  diagnostics_definition   = var.hub.diagnostics_definition
  diagnostics_destinations = var.hub.diagnostics_destinations
  # CORE NETWORKING COMPONENTS ONLY
  networking = {
    route_tables                                   = var.hub.route_tables
    routes                                         = var.hub.routes
    network_security_group_definition              = var.hub.network_security_groups # Adding rules inside each ENV afterwards
    vnets                                          = var.hub.vnets
    public_ip_addresses                            = var.hub.public_ip_addresses
    local_network_gateways                         = var.hub.local_network_gateways
    virtual_network_gateways                       = var.hub.virtual_network_gateways
    virtual_network_gateway_connections            = var.hub.virtual_network_gateway_connections
    vnet_peerings                                  = var.hub.vnet_peerings
    log_analytics_workspaces                       = var.hub.log_analytics_workspaces
    azurerm_firewalls                              = var.hub.azurerm_firewalls
    azurerm_firewall_policies                      = var.hub.azurerm_firewall_policies
    azurerm_firewall_policy_rule_collection_groups = var.hub.azurerm_firewall_policy_rule_collection_groups
  }
}
# PRD NETWORK
module "aztfmod_prd" {
  source  = "aztfmod/caf/azurerm"
  version = "5.7.3"
  providers = {
    azurerm.vhub = azurerm.vhub
    azurerm      = azurerm.prd
  }
  global_settings = var.global_settings
  resource_groups = var.prd.resource_groups
  # CORE NETWORKING COMPONENTS IN-SCOPE ONLY
  networking = {
    route_tables            = var.prd.route_tables
    routes                  = var.prd.routes
    network_security_groups = var.prd.network_security_groups
    vnets                   = var.prd.vnets
  vnet_peerings = var.prd.vnet_peerings }
}
# DEVNETWORK
module "aztfmod_dev" {
  source  = "aztfmod/caf/azurerm"
  version = "5.7.3"
  providers = {
    azurerm.vhub = azurerm.vhub
    azurerm      = azurerm.dev
  }
  global_settings = var.global_settings
  resource_groups = var.dev.resource_groups
  # CORE NETWORKING COMPONENTS IN-SCOPE ONLY
  networking = {
    route_tables            = var.dev.route_tables
    routes                  = var.dev.routes
    network_security_groups = var.dev.network_security_groups
    vnets                   = var.dev.vnets
  vnet_peerings = var.dev.vnet_peerings }
}
#etc

Clearly this is becoming a large main.tf file, as the providers have to be passed down to each module.
To my understanding we have 2x approaches:

Explicitly referencing individual the provider-names when utilising an instance of the module (my example above)
Implicitly referencing all the provider-names to the module (what am looking for support with, attempted below)

I tried to create 3x resource groups, using the 3x different providers and failed miserably.. lets say i called the module just once, and passed down all the providers in a list.
module "aztfmod" {
  source  = "aztfmod/caf/azurerm"
  version = "5.7.3"
  providers = {
    azurerm.vhub = azurerm.vhub
      azurerm      = azurerm.hub
      azurerm      = azurerm.prd
      azurerm      = azurerm.dev
  }
  global_settings = var.global_settings
  resource_groups = var.resource_groups      // <<<< NOTE THIS IS A DIFFERENT VARIABLE TO ABOVE
}

And the resource_groups variable, looks like this:
resource_groups = {
   HUB = {
      name = "uks-hub"
      region = "UKS"
      provider = "azurerm.hub"       #must be a quote encapsulated string or tf validate complains
   }
   PRD = {
      name = "uks-prd"
      region = "UKS"
      provider = "azurerm.prd"
   }
   DEV = {
      name = "uks-dev"
      region = "UKS"
      provider = "azurerm.dev"
   }
   # etc
}

Unfortunately, these are ALL created with the provider called 'azurerm`, not the aliased-providers passed-down.
Terraform also complained the providers were not initialised properly; yet i know they were, as I built the entire wheel successfully using the explicity mechanism.
Can someone please offer some advice on what I am doing wrong with initialising the providers, implicitly referencing the provider when calling the module, and how to reference it within each tfvars set resource ?

I'm experiencing the same problem.
In my scenario, I'm creating a VM in a subscription and I would like to save the KV information that is mandatory for creating the VM in an existing KV that is in another subscription for organizational reasons.
The fact that the KV is in another subscription does not locate the module used to create the VM because the provider is different and if I add another block of the caf module, there is no communication between them.
Did you find a solution to your problem?


docs: highlight returning from SubmitFunction won't update the page

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

resolves #9770

Honestly I prefer the previous version. When reading this one it's spread out between one sentence, then one warning block, then another sentence, and it reads less clear to me. I'm tempted to close the related issue with a link to the existing docs.

Yeah, I'm inclined to agree — this is more words, but not more information :)


docs: fix typo

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Fix typo in cluster preset docs.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks


Add Dane Touch Launcher

Added a version of the Touch Launcher that fits with the Watchface "Digital Assistant, Not EDITH"

Nice - thanks!

Do you have an icon for this? Looks like the one in here is the placeholder

Do you have an icon for this? Looks like the one in here is the placeholder

Not yet, but I will add one soon, after moving the code for the shared UI of Watchface and Launcher into a module to avoid duplicates


DialogFragment api is deprecated

Hi,
I'm running into this issue where when I'm using this library, that Android Studio gives me an error, saying that the DialogFragment API is deprecated. If I've understood the Android documentation correctly, we could solve this problem by switching to the support library or to androidX.
What do you think?
Cheers,
Tom

Thanks for pointing this out. I would love to get some help on fixing this if anyone is interesting in putting out a PR for this.
If not, it will be the first thing I take up in my next lib update stretch

I stumbled on the same issue, any updates on androidx?

+1 with the issue. Any updates?

+1

I solved it with the deprecated fragment manager from Activity
activity?.fragmentManager?.beginTransaction()?.add(picker, "")?.commit()

+1

+1

+1
If anyone have found a solution, I'd love to have it.

+1


SyncVars are not always synced on client after OnStartClient

Describe the bug
SyncVars are not always synced when the OnStartClient function gets called.
I have a simple bool syncvar with a hook. The value is true on the host while it is false when OnStartClient is called and then few frames later the hook gets called and the bool is true as it is supposed to be.
Expected behavior:
"OnStartClient: The values of SyncVars on object are guaranteed to be initialized correctly with the latest state from the server when this function is called on the client."
 I believe its only guaranteed if you set it before.

Are you setting it after the NetworkServer.Spawn call? I believe its only guaranteed if you set it before.

I set it on the server before the client connects so I guess it should be synced....
My case is the following:
1: Object gets spawned on the server
2: I Set the syncvar to true
3: Client connects
4: On client side the bool is false OnStartClient
5: bool is true a few frames later when the hook gets called.
Honestly I thought the hook wouldn't be called on init, only later if the value changes but it is not a problem at all... the problem is that unless I use hooks everywhere, there is no way to know if a syncvar is updated on client after connection or not.

I set it on the server before the client connects so I guess it should be synced....
My case is the following:
1: Object gets spawned on the server
2: I Set the syncvar to true
3: Client connects
4: On client side the bool is false OnStartClient
5: bool is true a few frames later when the hook gets called.
Honestly I thought the hook wouldn't be called on init, only later if the value changes but it is not a problem at all... the problem is that unless I use hooks everywhere, there is no way to know if a syncvar is updated on client after connection or not.

Which OnStartClient are you in?  Network Manager's, or a Network Behaviour on the object?

Which OnStartClient are you in?  Network Manager's, or a Network Behaviour on the object?

Network Behaviour (same object where the syncvar is)

Network Behaviour (same object where the syncvar is)

Cannot reproduce.
Created new scene with custom NetworkManager from Script Templates with this code:
    public override void OnStartServer()
    {
        NetworkServer.Spawn(Instantiate(spawnPrefabs[0]));
    }

Made cube prefab and added to Registered Spawnable Prefabs list with this NetworkBehaviour:
using UnityEngine;
using Mirror;

public class TestSyncVar : NetworkBehaviour
{
    [SyncVar(hook = nameof(OnValueChanged))]
    public bool test;

    void OnValueChanged(bool oldValue, bool newValue)
    {
        Debug.Log($"OnValueChanged {test} {oldValue} -> {newValue}");
    }

    public override void OnStartServer()
    {
        test = true;
    }

    public override void OnStartClient()
    {
        Debug.Log($"OnStartClient {test}");
    }

    void Start()
    {
        Debug.Log($"Start {test}");
    }
}

Build and run as server, play client in editor, console output as expected:

Additionally, I added similar debug logging to the RandomColor script used in the Room Example for the spawned Prize object, and got exactly the same results for all of them.

Cannot reproduce.
Created new scene with custom NetworkManager from Script Templates with this code:
    public override void OnStartServer()
    {
        NetworkServer.Spawn(Instantiate(spawnPrefabs[0]));
    }

Made cube prefab and added to Registered Spawnable Prefabs list with this NetworkBehaviour:
using UnityEngine;
using Mirror;

public class TestSyncVar : NetworkBehaviour
{
    [SyncVar(hook = nameof(OnValueChanged))]
    public bool test;

    void OnValueChanged(bool oldValue, bool newValue)
    {
        Debug.Log($"OnValueChanged {test} {oldValue} -> {newValue}");
    }

    public override void OnStartServer()
    {
        test = true;
    }

    public override void OnStartClient()
    {
        Debug.Log($"OnStartClient {test}");
    }

    void Start()
    {
        Debug.Log($"Start {test}");
    }
}

Build and run as server, play client in editor, console output as expected:

Additionally, I added similar debug logging to the RandomColor script used in the Room Example for the spawned Prize object, and got exactly the same results for all of them.

As there was a bug in the latest Mirror that did not allow an android client to connect, I am using 26.2.2 right now so maybe this is the reason I experience it and you don't?

As there was a bug in the latest Mirror that did not allow an android client to connect, I am using 26.2.2 right now so maybe this is the reason I experience it and you don't?

As there was a bug in the latest Mirror that did not allow an android client to connect, I am using 26.2.2 right now so maybe this is the reason I experience it and you don't?

Unlikely since no work has been done in this area in quite some time, but the Android issues have been resolved if you want to try the latest build.
If using Kcp Transport, make sure to reset all in-place Kcp Transports already in use.

As there was a bug in the latest Mirror that did not allow an android client to connect, I am using 26.2.2 right now so maybe this is the reason I experience it and you don't?

Unlikely since no work has been done in this area in quite some time, but the Android issues have been resolved if you want to try the latest build.
If using Kcp Transport, make sure to reset all in-place Kcp Transports already in use.

It is not working because OnStartServer working when there is no client joins yet. That's why there is no client to change their syncvar's. Make all syncvar changes after OnStartClient.


Add role to deploy 17.1 env for adoption

Add a new role that will deploy a tripleo environment that will serve as
source for adoption. This role is expected to cosume the infra created
by [1], and a 17.1 scenario definition from the data-plane-adoption
repo, introduced by [2].
It also introduce a small fix to the deploy-ocp.yml so the resulting ocp
cluster is ready (the nodes needed to be uncordoned).
[1] https://github.com/openstack-k8s-operators/ci-framework/pull/2285
[2] https://github.com/openstack-k8s-operators/data-plane-adoption/pull/597

@lewisdenny thanks for the extensive review, I've updated the PR with some changes, please take a look when you have some time

There are already detailed reviews so i just did a higher level "let me grasp what's going on" review.
I just wondered whether we'll want to support deployment without subscription-manager (with rhos-release), but that's yet another potential enhancement that should probably not be included in this PR anymore :)
Thank you very much for the work on this. LGTM :+1:

I will take another pass after @pablintino review is addressed

@pablintino thanks for the review, I think I've addressed all your comments @lewisdenny I've updated the PR with the changes after testing locally, ptal when you have some time

/approve

/lgtm


Remove ACCESS_TYPE_ONLY_ADDRESS?

Now that we have ACCESS_TYPE_ANY_OF_ADDRESSES, can we remove ACCESS_TYPE_ONLY_ADDRESS or is there any good reason to preserve that long term?
I think a migration path could look something like this (over multiple wasmd releases, multiple months):

Disallow storing new codes with ACCESS_TYPE_ONLY_ADDRESS (hint to ACCESS_TYPE_ONLY_ADDRESSES in error message)
Create a migration that converts all ACCESS_TYPE_ONLY_ADDRESS -> ACCESS_TYPE_ONLY_ADDRESSES and string address = 2 -> repeated string addresses = 3.
Delete enum case ACCESS_TYPE_ONLY_ADDRESS and field 2 from protos

Thanks for the issue. There are no plans to preserve the type. It was deprecated in code already and can be removed. Your migration path makes sense 👍

Cool, I'll split the steps in small tickets such that we can do them over time.


Command line does not support cut/paste

It would be nice to be able to paste text in the command line especially when doing search/replace.

The cmdline and status bar are pretty wimpy right now too. I'm kinda waiting on https://github.com/neovim/neovim/pull/6162 to make visual improvements (like your cursor doesn't show up right now), but it should be possible to hook the paste TextCommand in Sublime while the cmdline is open and convert it into key presses.

Partial fix in 0.9.14 (cmdline now pops out as a real input box, and you can paste in it)


[Bug]: Not able to deploy proxy on Netlify

What happened?
Hi 👋 ,
I tried to deploy the proxy in netlify as per the doc, but I am getting the following error.

this what netlify ai suggesting,

What browsers are you seeing the problem on?
Chrome
Steps to reproduce?

go to deploy the proxy
click deploy to netlify
approve all steps and trigger the deploy

Other relevant information
No response

Just use cf workers

In Build & Deploy -> Build Settings, set Functions directory to .netlify, fixes this problem


Width of tooltip window for inspection of debug variables is unpractical

VSCode Version: Version: 1.51.1
OS Version: Windows 10

Steps to Reproduce:

Start a debug session, pause process execution.
Hover mouse over struct variable to inspect its fields that have long string content.

Actual result: tooltip window appears with variable content truncated.
Expected result: UI should provide convenient means to see full content of a variable.

Does this issue occur when all extensions are disabled?: Yes/No

The limit of max width in the debugHover.css is the reason for this problem.
.monaco-editor .debug-hover-widget .complex-value {
	max-width: 700px;
}

Try to change the max width from 700px to fit-content，problem is sovled.
.monaco-editor .debug-hover-widget .complex-value {
	max-width: fit-content;
}

[Problem]

[After Fix]

@isidorn Could you help to review this pr？Thanks a lot.
https://github.com/microsoft/vscode/pull/111927

This is a fair issue and I agree we could improve this.
@ashtongao thank you for your PR, I have commented on it.


Add material to stdio handling

And here is how you would handle https://github.com/rust-lang/rfcs/pull/899#issuecomment-79091963 with this design:
Since you're writing a TUI, you're interacting with fds 0 and 1 directly anyway. Therefore, at the start of your program, you set thread::set_stdout to io::Sink and thread::set_stderr to a log file.

Unfortunately, the Windows console do not make Write nor Read usable in a generic way.
cc #972

This RFC does not touch the raw versions.

I might just not understand some fundamental limitation of the design space, but I'm curious why concurrent synchronization is being used (Arc and Mutex) to control a thread-local variable, which seems to only be modifiable from one thread. As a result, Rc and RefCell could be used, which would be more efficient.

@reem

I'm curious why concurrent synchronization is being used

+Unless other streams or another buffer mode has been explicitly specified via
+the thread-builder, these settings will be inherited by child-threads.

Ah, I figured I had just missed something.

I think making println and panic reference a thread-local, inherited, overridable notion of stdout and stderr is a good move, for composability/capture purposes. So :+1: to the overall idea here.
One question: are the raw versions tied to the process-level handles? That is, does std give you any way to get at these underlying handles?
I'm a little unsure about the exact signatures/locations of some of the functions proposed here, but I want to think a bit more about a possible alternative for concrete comparison. I'll try to do so soon.

@aturon

One question: are the raw versions tied to the process-level handles? That is, does std give you any way to get at these underlying handles?

This RFC does not make any changes to the raw section which is marked as a sketch anyway. Raw handles will have to refer to the 0, 1, 2 fds on unix directly.

Is there any way to make some of this more opt-in so threads that don't do IO don't need to carry all this baggage around? All the behind the signs dynamic dispatch and thread local stuff reminds me a bit of the old green/native IO system.
 The fact that we need to such things as are proposed here to fix them I take is evidence of the fact. I rather hook up panicking to the liblog infrastructure than bake this stuff into std::thread.

all this baggage around?

 That's an interesting thought.

RFC issue https://github.com/rust-lang/rfcs/issues/1050


Adding Python 3.9 to github actions workflow.

Opened a new PR: https://github.com/IBM/lale/pull/946.


Create Detect_Loop_in_Linked_List_Without_Floyd_Algorithm.cpp

I have added C++ code for detecting loop in linked list without Floyd Algorithm.

@all-contributors please add @VARUN-K-BANSAL  for his code