[Bug]: Alignment of field labels are off on generate CRUD page

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Field labels are not uniformly aligned on the generate CRUD page.

Steps To Reproduce

Add a new page and select CRUD option and observe the label alignment

Environment
Release
Version
Cloud

@jsartisan  Can you check if this was due to tailwind changes or not?

Let me check

@Rishabh-Rathod Yes. This was due to tailwind only. I'll fix this. Let me know if there are any other places where things might be misaligned due to tailwind.

@jsartisan can you search for "ADS component issue" labelled issues. I created that particular label for such internal issues to help me find them.

Still see the same issue so reopening the issue
https://github.com/appsmithorg/appsmith/issues/8438

@RakshaKShetty this seems strange as for me.
On DP

On Release

This did work as expected. Can you please check again?

The alignment is as expected on release now. Thanks @Rishabh-Rathod


prisma deploy

You can use the prisma CLI without having it globally installed because it's listed as a development dependency in package.json.

I believe this is not correct. You have to define script in package.json otherwise you will get prisma: command not found

Thanks a lot for pointing this out @developer239, the statement was indeed incorrect. package.json has been updated and prisma is now also listed as a script which allows to invoke it by prefixing it with yarn: yarn prisma deploy. 🙂


Architect builder is not compatible with Angular 8

In Angular 8 architect API has changed and extracting i18n results in error.
https://docs.google.com/document/d/1SpN_2XEooI9_CPjqspAcNEBjVY874OWPZqOenjuF0qo
Tested it using CLI v.8.0.0-rc.4

ng new i18test
ng add @ngx-i18nsupport/tooling --project=i18test --i18nFormat=xlf2 --languages=en,de,ru
ng xi18n i18test --i18n-format xlf2 --output-path i18n --i18n-locale en && ng run i18test:xliffmerge

Could not find the implementation for builder @ngx-i18nsupport/tooling:xliffmerge
Error: Could not find the implementation for builder @ngx-i18nsupport/tooling:xliffmerge
    at WorkspaceNodeModulesArchitectHost.resolveBuilder (C:\Users\wilhelmolejnik\Desktop\sandbox\i18test\node_modules\@angular-devkit\architect\node\node-modules-architect-host.js:49:19)
    at RunCommand.runSingleTarget (C:\Users\wilhelmolejnik\Desktop\sandbox\i18test\node_modules\@angular\cli\models\architect-command.js:176:55)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)

Yes I am aware of this. There is already a branch to solve it when ng 8 is available (should come this week).
The architect support in ng 7 was experimental and undocumented and they incompatible changed it in 8.
In ng 8 they now start to have an official and documented API (although the documentation is far away from being good).

Thanks for the fantastic project Martin. It looks like Angular 8 has been released at this point. Any idea when the feature-ng8 branch will be merged? I'm having the same problem Wilhelm described above unfortunately. Cheers!

publish version 8.0.0 of tooling


Use tsc to build the project and prepare converting js to ts.

made compatible accumating changes for converting js files to ts.
it's build-able using tsc but need manual intervention for successful build. will focus fix in next slice.
next: fix import error for all of the helper js files and automate the process to copy over necessary static files.

Good job! I assume this jlpm will be able to build as it is and you will change other js to ts?


Moving feature flag out of crate root breaks build when using portable_simd

This conditional feature gate needs to go at the top of lib.rs.
Without that change, I get the following error:
warning: crate-level attribute should be in the root module
 --> src/glam_ext.rs:1:68
  |
1 | #![cfg_attr(not(any(target_arch = "x86", target_arch = "x86_64")), feature(portable_simd))]
  |                                                                    ^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_attributes)]` on by default

error[E0658]: use of unstable library feature 'portable_simd'
  --> src/glam_ext.rs:10:5
   |
10 | use core::simd::*;
   |     ^^^^^^^^^^
   |
   = note: see issue #86656 <https://github.com/rust-lang/rust/issues/86656> for more information
   = help: add `#![feature(portable_simd)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'portable_simd'
  --> src/glam_ext.rs:15:14
   |
15 | type F32x4 = f32x4;
   |              ^^^^^
   |
   = note: see issue #86656 <https://github.com/rust-lang/rust/issues/86656> for more information
   = help: add `#![feature(portable_simd)]` to the crate attributes to enable

I'd PR the one-line fix, but I'm not in a position to do so at the moment. Dropping an issue as a reminder for myself to do so next time I'm working on rocketsim-rs (or just in case @VirxEC wants to get to it before me).

Not PRing this right now because the ugly autocxx issue came back to the current HEAD of master, and I don't want to troubleshoot that first.

The reason the current version isn't building is because of a mistake in RocketSim itself, Zealan made a mistake and once he fixes it I'll just need to update to the latest commit. I'll fix this issue too when I do.

Fixed with commit a11379b


Create snmpv3 users and traps for logical interconnect group ( not for appliance)

Scenario/Intent
Want to create snmpv3 users and traps for Logical Interconnect Groups not for appliance
There is library to create snmp user for appliance but not for LIG
Module Version: 5.9.0
Ansible Version: 2.9
OneView Appliance Version: 5.4
OneView Client API Version: 2000
Python Version: 2.7
python-hpOneView SDK Version: 5.5.0
Platform: Linux distribution

@DungKHoang, What do you mean by snmpv3 traps for LIG..? Can you please provide us reference apis or screenshots.

Hi @DungKHoang, Please add this block in your logical interconnect group payload to create snmpv3 users for LIG.
          snmpConfiguration:
            type: snmp-configuration
            snmpUsers:
              - snmpV3UserName: lig-snmpuser
                userCredentials: []
            enabled: false
            v3Enabled: true

Below I have attached the complete LIG payload for 3 enclosure having no uplink sets and having snmpv3 user creation.
    - name: Create a Logical Interconnect Group
      oneview_logical_interconnect_group:
        config: "{{ config }}"
        state: present
        data:
          name: 'LIG_with_snmp_user'
          enclosureType: 'SY12000'
          uplinkSets: []
          interconnectBaySet: 3
          enclosureIndexes: [1,2,3]
          snmpConfiguration:
            type: snmp-configuration
            snmpUsers:
              - snmpV3UserName: lig-snmpuser
                userCredentials: []
            enabled: false
            v3Enabled: true
          redundancyType: "HighlyAvailable"
          interconnectMapTemplate:
            interconnectMapEntryTemplates:
              - enclosureIndex: 3
                logicalLocation:
                    locationEntries:
                        - relativeValue: 3
                          type: "Enclosure"
                        - relativeValue: 6
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_2 }}"
              - enclosureIndex: 2
                logicalLocation:
                    locationEntries:
                        - relativeValue: 2
                          type: "Enclosure"
                        - relativeValue: 6
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_1 }}"
              - enclosureIndex: 2
                logicalLocation:
                    locationEntries:
                        - relativeValue: 2
                          type: "Enclosure"
                        - relativeValue: 3
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_2 }}"
              - enclosureIndex: 3
                logicalLocation:
                    locationEntries:
                        - relativeValue: 3
                          type: "Enclosure"
                        - relativeValue: 3
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_2 }}"
              - enclosureIndex: 1
                logicalLocation:
                    locationEntries:
                        - relativeValue: 1
                          type: "Enclosure"
                        - relativeValue: 6
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_2 }}"
              - enclosureIndex: 1
                logicalLocation:
                    locationEntries:
                        - relativeValue: 1
                          type: "Enclosure"
                        - relativeValue: 3
                          type: "Bay"
                permittedInterconnectTypeName: "{{ permitted_interconnect_type_name_1 }}"
               # Alternatively you can inform permittedInterconnectTypeUri
      delegate_to: localhost

I have tested with the above playbook and it worked for me. Please give a try and close the issue if it helps.

We are closing this issue since we didn't hear back from you. Please feel free to reopen if any help needed.


Empty directories should not be displayed

Hi,
I'm using your tool on gherkin files parsed by Behat which expects a boostrap directory at the same level as the feature files/directories themselves.
When I ignore all those php files through the .featurebookignore, the bootstrap directory and all its subdirectories appear in the spec tree, empty.

Hey @CaptainQuirk can you send me your .featurebookignore file plz?


[SPARK-15655] [SQL] Fix Wrong Partition Column Order when Fetching Partitioned Tables

What changes were proposed in this pull request?
When fetching the partitioned table, the output contains wrong results. The order of partition key values do not match the order of partition key columns in output schema. For example,
CREATE TABLE table_with_partition(c1 string) PARTITIONED BY (p1 string,p2 string,p3 string,p4 string,p5 string)

INSERT OVERWRITE TABLE table_with_partition PARTITION (p1='a',p2='b',p3='c',p4='d',p5='e') SELECT 'blarr'

SELECT p1, p2, p3, p4, p5, c1 FROM table_with_partition

+---+---+---+---+---+-----+
| p1| p2| p3| p4| p5|   c1|
+---+---+---+---+---+-----+
|  d|  e|  c|  b|  a|blarr|
+---+---+---+---+---+-----+

The expected result should be
+---+---+---+---+---+-----+
| p1| p2| p3| p4| p5|   c1|
+---+---+---+---+---+-----+
|  a|  b|  c|  d|  e|blarr|
+---+---+---+---+---+-----+

This PR is to fix this by enforcing the order matches the table partition definition.
How was this patch tested?
Added a test case into SQLQuerySuite

Test build #59624 has started for PR 13400 at commit 5bc8996.

Test build #59624 has finished for PR 13400 at commit 5bc8996.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59624/
Test PASSed.

cc @liancheng @andrewor14 @cloud-fan Could you please review this? Thanks!

ping @andrewor14  : )

retest this please

Test build #60100 has started for PR 13400 at commit 5bc8996.

Test build #60100 has finished for PR 13400 at commit 5bc8996.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60100/
Test PASSed.

@rxin @andrewor14 @cloud-fan This returns a wrong result. Do you think we should fix it in Spark 2.0? Thanks!

retest this please

Test build #60240 has started for PR 13400 at commit 5bc8996.

Test build #60240 has finished for PR 13400 at commit 5bc8996.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60240/
Test PASSed.

Merged build finished. Test PASSed.

retest this please

Test build #60409 has started for PR 13400 at commit 5bc8996.

Test build #60409 has finished for PR 13400 at commit 5bc8996.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60409/
Test PASSed.

Looks good to me except one minor test issue.

@cloud-fan @clockfly Thank you for your review! Let me know if the latest code changes look fine. Thanks!

Test build #60470 has started for PR 13400 at commit 351806d.

LGTM, pending jenkins

Test build #60470 has finished for PR 13400 at commit 351806d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60470/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master/2.0!


Polish the structure of chapters and Add a new chapter '算法与数据结构'

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@imdonnie
Thank you for your contribution to the page! 👍 We're happy to accept these changes and look forward to future contributions.


Feature Request: Possibility to have a return value in the execute function

Imagine following scenario:
Creating a Unit Entity
After that create a Player Entity which can control this unit
onJoin(client: Client, options: any, auth: any) {
    const unit = this.dispatcher.dispatch(new UnitAddCommand(),{})
    this.dispatcher.dispatch(new PlayerAddCommand(), {
        sessionId: client.sessionId,
        unitId: unit.id
    });
}

So i would like to create a command like this:
export class UnitAddCommand extends Command<RoomState, UnitAddPayload> {
   execute(payload: UnitAddPayload): UnitState {
       const unit = new UnitState()
       this.state.units.set(unit.id, unit)
       return unit
   }
}

This would be a really nice feature IMO.
Feel free to ask questions.

I want to do the same thing. Any updates or workarounds for this to work?


Came across this project

Anyway we can get a clear schematic diagram showing all the connections and parts used.
For whatever reason I can't tell by your pictures the layout of the circuit.
Thank you

Sure, give me a moment!

Hope this helps!


Module 1.2 Assignment

@aalexandrescu I don't see the commit command being used here, but clearly you have committed your README.md file.
Please let me know if you happen to have any questions.

Sometimes some git commands that I previously entered in Atom do not appear any more in the console.
I will retake the assignment and upload a proper printscreen.

Nevermind, I noticed now that you labeled the activity as complete.

@aalexandrescu not an issue at all. I can see that everything is being done, but in a majority of your assignments I notice that commands are missing. It is not an issue as long as I can see you under the main ideas of the lesson.


Rename glib::GString to glib::CString to avoid confusion with the C GString (aka glib::String)

And potentially also rename glib::String to glib::StringBuilder (which Vala did, for example), but OTOH the Rust "string builder" type is also just called String.
@bilelmoussaoui @GuillaumeGomez Opinions?

For what is worth I found GString super confusing at the beginning. I like the plan proposed in the last comments!

For what is worth I found GString super confusing at the beginning. I like the plan proposed in the last comments!

You mean removing glib::String (the C GString string builder) and keeping glib::GString (the string with the GLib allocator)?

Yes, and renaming that to glib::String

First part in https://github.com/gtk-rs/gtk-rs-core/pull/332 . I'll do the renaming once this is in, it requires gir changes and manual changes all over the place.

@GuillaumeGomez for renaming, you were very much against CString, but String would be OK for you?

I'd still prefer GString but don't want to drag the debate forever.

IMHO GString is better than String (our thing is a Box<str> but String is a string builder!), but CString would be best (our thing is an owned, NUL-terminated C/FFI string just like CString but in addition also guaranteed UTF-8).
I'm a bit hesitant to rename it to String because of that :)

Let's keep it like this then. No more glib::String and keeping glib::GString


Fix subject paths.

This hopefully addresses Issue #212. @rossbar
For anybody who cares: it appears that a few of the files were using the old method for getting all subject paths. Nobody picked up on this, because we all had the old data saved from previous runs. Also, some people put ".nii" instead of ".nii.gz" in their BOLD file paths-- the files should have an ".nii.gz", extension. This may also be the source of the problem.

I just added a remote to janewliang's repo, checked out the subpaths branch (commit e8def91) and re-ran make analysis. Now I get a different IOError, but it's still not working.

What's the error message?

Smoothing data, with sigma=1:  [-------------Traceback (most recent call last):
  File "smooth_final.py", line 59, in <module>
    img = nib.load(path_to_data + name + "/BOLD/task001_run001/bold.nii.gz")
  File "/usr/local/lib/python2.7/dist-packages/nibabel/loadsave.py", line 44, in load
    return guessed_image_type(filename).from_filename(filename, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/nibabel/loadsave.py", line 76, in guessed_image_type
    with BinOpener(filename) as fobj:
  File "/usr/local/lib/python2.7/dist-packages/nibabel/openers.py", line 120, in __init__
    self.fobj = opener(fileish, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/nibabel/openers.py", line 63, in _gzip_open
    gzip_file = BufferedGzipFile(fileish, *args, **kwargs)
  File "/usr/lib/python2.7/gzip.py", line 94, in __init__
    fileobj = self.myfileobj = __builtin__.open(filename, mode or 'rb')
IOError: [Errno 2] No such file or directory: '../../data/ds009/sub001/BOLD/task001_run001/bold.nii.gz'

That's definitely really weird. I doubt that the problem is the file path in smooth_final that's at fault. The other subjects' BOLD data were accessed using the same method for getting file path names, and at least 10-15 or so of them seemed to have done it correctly on your computer (I'm not getting this error message at all) before failing for Subject 1. I can go re-download and unpack the data from OpenfMRI to see if they've changed it or something since we first downloaded it for this project, but that's the only thing I can think of.

I will delete the data and try to re-download to see if that helps... stay tuned

Now I've run out of drive space... I won't be able to test it til later. If one of your group members manages to get this to succeed with a fresh install (i.e. reclone the project and run through the make steps successfully), please merge this PR and notify me

@rossbar We're downloading and checking out the data, so we'll get back to you, but if you check the hashes of your data by calling "make validate" in the data directory, an error should also be raised if a file that is saved in the dictionary of file hashes (ds009_hashes.json) is not present in the right place. ds009_hashes stores the file names and hashes ask key-value pairs. I created it based on the data stored on my computer, so it does have  a BOLD file saved at "project-alpha/data/ds009/sub001/BOLD/task001_run001/bold.nii.gz".

The hashing checked out so it wasn't that. I probably screwed it up when I tried to fix it the first time around. My suspicion is one of my changes caused the data to be unzipped but then when it still failed, that file, which your code was expecting to be a .gz had already been unzipped on disk.

Cool. Then hopefully things will run with my fixes after redownloading the data. Sorry for all the confusion! Let us know if you're still getting errors.

Almost made it all the way through this time. Here's the most recent error:
Traceback (most recent call last):
  File "event_related_plots.py", line 61, in <module>
    cond_all=np.loadtxt(condition_location+"cond_all.txt")
  File "/usr/local/lib/python2.7/dist-packages/numpy/lib/npyio.py", line 738, in loadtxt
    fh = iter(open(fname, 'U'))
IOError: [Errno 2] No such file or directory: '../../data/ds009/sub001/model/model001/onsets/task001_run001/cond_all.txt'

That should do it. Sorry!
@benjaminleroy would like to say "dang it- that was my fault". And it was, but we still should have caught it.

Merging this, because it should address at least some of the reproducibility issues.


Modrinth: log known repositories for bundled mods

When exporting to Modrinth and linkable jars are not found for some mods, the script should continue to bundle them but also fetch source repo links (like #1) and post them to the terminal log.
Then the user could copy them into the changelog to be compliant with the mod licenses.
If a repo was not found, list any other known link (e.g. CurseForge listing)
Edit: separate GitHub links from other links to highlight the point that not any mod can be added unless the license allows.
As Modrinth uses Markdown, it could be instantly formatted as such:
Sources for bundled mods:

* [Mod1](https://github.com/user/mod1)
* [Mod2](https://github.com/user/mod2)
* [Mod3](https://github.com/user/mod3)

This is why:
https://blog.modrinth.com/modpack-changes/

PS C:\Users\Madis> mmc-export -i "C:\Users\Madis\Desktop\Fabulously Optimized 3.8.3 MR.zip" -f Modrinth -o "C:\Users\Madis\Desktop" --exclude-providers CurseForge --modrinth-search loose
59/60 GitHub searches remaining, after that only cached results will be used.
To get more searches, sign in with mmc-export gh-login or wait until 22:18 to get 60 searches again.
Specify modpack version: 3.8.3-mr.2
No config entry found for resource: CIT Resewn
No config entry found for resource: Cloth API
No config entry found for resource: Cloth Config v6
No config entry found for resource: DCCH
No config entry found for resource: Fabric Language Kotlin
No config entry found for resource: Farsight Mod
No config entry found for resource: Not Enough Crashes
No config entry found for resource: ToolTip Fix
No config entry found for resource: YOSBR
No config entry found for resource: Mod Menu Helper

The mods that gave warnings were properly placed in the result zip, but bundled_links.md contents were empty:
Sources for bundled mods:

GitHub links

Other links

Always check the licenses to see if they allow distribution!

Because it was bundled on config parseing stage, to get bundled links you must enable CF as well


TST: speed up test_import_cycles

What does this implement/fix?
This runs the same checks that the existing test_import_cycles does, but instead of running each Python subprocess one-by-one in blocking mode, it kicks off all the subprocesses in the background before checking that each one returned successfully.
On my local machine, this brings the test_import_cycles execution time from ~11s down to ~2.5s. It should also make it cheaper to add additional modules to the list that we're checking here.

@tupui The test was (and still is) running each import in a separate process, so running them sequentially or concurrently won't make a difference in the behavior being tested.
As I understand it, the original intent of the test was to catch problems that don't appear if you do import scipy; import scipy.submodule but do appear if you only do import scipy.submodule directly. That's still being checked with this PR.

🤦 yes sorry for some reason I completely misread the diff on my phone (right after we discussed this lol)


firefox-bin: provide wrapper with firefoxLibName

Motivation for this change

The wrapper was configuring the wrong directory, and would write to $out/lib/firefox/ instead of the proper lib path.
$out/lib/${firefoxLibName}/firefox-bin must not be left as a symlink, because firefox will still read configs/data from the original unwrapped directory.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121596 at 04933663 run on x86_64-linux 1

1 package skipped due to time constraints:

slimerjs

3 packages built successfully:

dropbox
dropbox-cli
mate.caja-dropbox

Rebased and adjusted for conflicts introduced by #130116

@taku0 that example now fails to evaluate because it presumably wasn't meant to work:
error: Nix addons are only supported in Firefox ESR

thunderbird also calls wrapFirefox (see pkgs/applications/networking/mailreaders/thunderbird/). Does this PR affect thunderbird?

Does this PR affect thunderbird?

It mostly just tweaks the defaults of the wrapper, so doesn't really change anything:

thunderbird sets libName explicitly, so overrides / is unrelated to what most of this PR does.
thunderbird-bin doesn't seem to use wrapFirefox at all


Add rule: Function names should use PascalCase and follow Noun-Verb convention if possible

https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#function-names-should-use-pascalcase-and-follow-noun-verb-convention-if-possible

I'm sure the original author meant "follow verb-noun convention" ... why are we linking to a document that didn't even get the basics right?
Since there's already a rule for testing approved verbs, and even one for testing pluralized nouns, this issue/idea is incomplete, at best -- what rule(s) actually still need to be implemented?
@raghushantha Why is this labelled "up-for-grabs" when it's not specified enough for anyone to implement it?


Add HasConfigs instance for ModalT

Same as #134 - but this time the PR is against develop.

Thanks :blush:


[RELEASE] Release version 1.2.1

Release OpenSearch and OpenSearch Dashboards 1.2.1
This is an out of band release, it will follow the release process but normal steps will be abbreviated
Preparation

[x] Assign this issue to a release owner.
[x] Document any new quality requirements or changes.
[x] Create a version label in each component repo for this, and the next minor release.
[x] Confirm that OpenSearch-Dashboards does not need an updated manifest

Development

[x] OpenSearch core has update for 1.2.1
[x] Security has update for 1.2.1
[x] common-utils https://github.com/opensearch-project/common-utils/pull/103
[x] job-scheduler https://github.com/opensearch-project/job-scheduler/pull/108
[x] alerting https://github.com/opensearch-project/alerting/pull/255
[x] asynchronous-search https://github.com/opensearch-project/asynchronous-search/pull/77
[x] index-management https://github.com/opensearch-project/index-management/pull/222
[x] k-NNhttps://github.com/opensearch-project/k-NN/pull/241
[x] security https://github.com/opensearch-project/security/pull/1518
[x] performance-analyzer https://github.com/opensearch-project/performance-analyzer/pull/87
[x] anomaly-detection https://github.com/opensearch-project/anomaly-detection/pull/327
[x] cross-cluster-replication https://github.com/opensearch-project/cross-cluster-replication/pull/266
[x] sql https://github.com/opensearch-project/sql/pull/325
[x] dashboards-reports https://github.com/opensearch-project/dashboards-reports/pull/253
[x] opensearch-observability https://github.com/opensearch-project/trace-analytics/pull/317
[x] Make pull requests to add each component to manifests/1.2.1/opensearch-1.2.1.yml https://github.com/opensearch-project/opensearch-build/pull/1299
[x] All components have been updated (+1 hour)
[x] Declare a release candidate build
[x] Create an issue publish all test results.  (+1.5 hour)

[X] Performance tests, tracked on this issue
[x] Integration tests, tracked on this issue

[x] Verify all issued labeled v1.2.1 in all projects have been resolved.
[x] Complete documentation for this release.
[x] Maven release (+1 hour)

https://github.com/opensearch-project/opensearch-infra/pull/139
https://github.com/opensearch-project/opensearch-infra/pull/140
https://github.com/opensearch-project/opensearch-infra/pull/141

[x] Native plugins release
[x] Publish Docker images (+.5 hour)
[ ] Author blog post for this release.
[ ] Gather, review and publish release notes. git-release-notes may be used to generate release notes from your commit history.
[ ] Publish this release on opensearch.org.
[ ] Publish forum posts - release is launched!
[ ] Publish blog post - release is launched!

Post Release

[ ] Create release tags for each component.
[ ] Replace refs in manifests/1.2.1 with tags.
[ ] Update this template with any new or missed steps.
[ ] Conduct a postmortem, and publish its results.

We need to rev all version number, will be adding a new checklist for all the version to be rebuild

Release candidate testing instructions

Use Docker-Compose to setup a cluster

Download this gist as docker-compose.yml on your machine
Get latest image versions docker-compose pull
Start the cluster docker-compose up

OpenSearch docker

Start without security

Docker command docker pull opensearchstaging/opensearch:1.2.1 && docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:1.2.1
Connect command curl https://localhost:9200

Start with security

Docker command docker pull opensearchstaging/opensearch:1.2.1 && docker run -it -p 9200:9200 -e "discovery.type=single-node" opensearchstaging/opensearch:1.2.1
Connect command curl --insecure https://admin:admin@localhost:9200

Use TARs to deploy OpenSearch Manually (Updated 2021/11/22 11:00 PST)

OpenSearch - Build 1127

x64 [manifest] [tar]
arm64 [manifest] [tar]

From Docker Release

Performance testing has been triggered, tracking numbers for the results.

5453d4e4-9f6c-439a-be0c-09878412905c
296bec5f-1b35-46c7-b9cd-2dc370546583
17ee8f29-e0b9-4a4e-b309-653adead9671
62ed636e-3a3b-48a8-9f5f-a1da78348c50

Integration testing kicked off - results will come tomorrow
./test.sh integ-test manifests/1.3.0/opensearch-1.3.0-test.yml --paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.2.1/53/linux/x64

./test.sh integ-test manifests/1.3.0/opensearch-1.3.0-test.yml -paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.2.1/53/linux/arm64

Needed to work around an upload issue for https://github.com/opensearch-project/opensearch-build/issues/1261 RC artifacts have been uploaded

Maven up: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/opensearch/1.2.1/
Waiting for sync from the central: https://repo1.maven.org/maven2/org/opensearch/opensearch/1.2.1/

All tar are pushed to production bucket.

Native plugins live:
% ./bin/opensearch-plugin install repository-s3
-> Installing repository-s3
-> Downloading repository-s3 from opensearch
[=================================================] 100%
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@     WARNING: plugin requires additional permissions     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
* java.lang.RuntimePermission accessDeclaredMembers
* java.lang.RuntimePermission getClassLoader
* java.lang.reflect.ReflectPermission suppressAccessChecks
* java.net.SocketPermission * connect,resolve
* java.util.PropertyPermission opensearch.allow_insecure_settings read,write
See http://docs.oracle.com/javase/8/docs/technotes/guides/security/permissions.html
for descriptions of what these permissions allow and the associated risks.

Continue with installation? [y/N]y
-> Installed repository-s3 with folder name repository-s3

Docker up:
https://hub.docker.com/r/opensearchproject/opensearch/tags
$ curl https://localhost:9200/ -u admin:admin --insecure
{
  "name" : "opensearch-node1",
  "cluster_name" : "opensearch-cluster",
  "cluster_uuid" : "teJylxlBQVKqXt_doKdSxQ",
  "version" : {
    "distribution" : "opensearch",
    "number" : "1.2.1",
    "build_type" : "tar",
    "build_hash" : "e3a44fa71b290fb265a94ef4297f044b9a63a762",
    "build_date" : "2021-12-11T04:24:30.324011Z",
    "build_snapshot" : false,
    "lucene_version" : "8.10.1",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}
$ curl https://localhost:9200/_cat/plugins -u admin:admin --insecure
opensearch-node2 opensearch-alerting                  <IP_ADDRESS>
opensearch-node2 opensearch-anomaly-detection         <IP_ADDRESS>
opensearch-node2 opensearch-asynchronous-search       <IP_ADDRESS>
opensearch-node2 opensearch-cross-cluster-replication <IP_ADDRESS>
opensearch-node2 opensearch-index-management          <IP_ADDRESS>
opensearch-node2 opensearch-job-scheduler             <IP_ADDRESS>
opensearch-node2 opensearch-knn                       <IP_ADDRESS>
opensearch-node2 opensearch-observability             <IP_ADDRESS>
opensearch-node2 opensearch-performance-analyzer      <IP_ADDRESS>
opensearch-node2 opensearch-reports-scheduler         <IP_ADDRESS>
opensearch-node2 opensearch-security                  <IP_ADDRESS>
opensearch-node2 opensearch-sql                       <IP_ADDRESS>
opensearch-node1 opensearch-alerting                  <IP_ADDRESS>
opensearch-node1 opensearch-anomaly-detection         <IP_ADDRESS>
opensearch-node1 opensearch-asynchronous-search       <IP_ADDRESS>
opensearch-node1 opensearch-cross-cluster-replication <IP_ADDRESS>
opensearch-node1 opensearch-index-management          <IP_ADDRESS>
opensearch-node1 opensearch-job-scheduler             <IP_ADDRESS>
opensearch-node1 opensearch-knn                       <IP_ADDRESS>
opensearch-node1 opensearch-observability             <IP_ADDRESS>
opensearch-node1 opensearch-performance-analyzer      <IP_ADDRESS>
opensearch-node1 opensearch-reports-scheduler         <IP_ADDRESS>
opensearch-node1 opensearch-security                  <IP_ADDRESS>
opensearch-node1 opensearch-sql                       <IP_ADDRESS>

The 1.2.1 release is live everywhere!


Also sort alerts by Expr to ensure order when same name

We should sort the alerts also by Expr to ensure when there are multiple alerts created with the same name but different expressions, the output is always the same for the same state.

/approve


Profile not working fight

I thing this says it all

Can you please test if zoxide is installed on your system?

I just used UniGetU and installed this

and reinstall it.

It is working now


gh-631 - Add support for customizing OAuth2FeignReqeustInterceptor.accessTokenProvider (injecting e.g. LoadBalancerInterceptor)

1. Added support to customize OAuth2FeignReqeustInterceptor's internal AccessTokenProvider through OAuth2FeignReqeustInterceptorBuilder and OAuth2FeignRequestInterceptorConfigurer.
Before OAuth2FeignReqeustInterceptor is created and injected into context, instances of OAuth2FeignRequestInterceptorConfigurer are resolved and used to customize properties of internal AccessTokenProvider.
2. Extended FeignAutoConfiguration so that it can create  OAuth2FeignReqeustInterceptor with RetryLoadBalancerInterceptor or LoadBalancerInterceptor (depends what bean is already managed).
IMPORTANT: Load balancing is enabled only on flag: "feign.oauth2.load-balanced=true" in order to be backward compatible, but maybe it should be default behaviour in the same way as feign load balancing.

@eleftherias could you please review since it relates to Spring Security integration?

Fixes gh-631.

@OlgaMaciaszek Done.


Way to define Interceptors or Middlewares for OAuth?

Hi,
Is there a way or is planned to define some kind of Interceptors or Middlewares for this gRpc server?
Something like in this post would be great I guess:
https://texlution.com/post/oauth-and-grpc-go/

Yes, you can define Interceptor by implementing InvokerInterface:
https://github.com/spiral/php-grpc/blob/master/src/InvokerInterface.php
And pass it the server: https://github.com/spiral/php-grpc/blob/master/src/Server.php#L33
You can wrap default Invoker to implement needed functionality.

Yes, I can see that.
Thank you for your answer and this work.


Update .ci.yaml to use either macOS 12 or 13

Prerequisites:

https://github.com/flutter/flutter/issues/134735
All tests must pass on macOS 13
All bots types (chromium x86, chromium arm64, devicelab x86 with iOS device, devicelab arm64 with iOS device) must be tested

Update in all repos:

[x] flutter/flutter https://github.com/flutter/flutter/pull/137365

[x] Blocked by: https://github.com/flutter/flutter/issues/136651
[x] Blocked by: https://github.com/flutter/flutter/issues/136256
[x] Blocked by: https://github.com/flutter/flutter/issues/136549

[x] flutter/packages https://github.com/flutter/packages/pull/5089
[x] flutter/engine https://github.com/flutter/engine/pull/47606

[x] Blocked by: https://github.com/flutter/flutter/issues/136257
[x] Blocked by: https://github.com/flutter/flutter/issues/135620
[ ] Blocked by: https://github.com/flutter/flutter/issues/137547
[ ] Blocked by: https://github.com/flutter/flutter/issues/136274
[ ] Blocked by: https://github.com/flutter/flutter/issues/136279
[ ] Blocked by: https://github.com/flutter/flutter/issues/136972
[x] https://github.com/flutter/flutter/issues/134740

[x] flutter/cocoon https://github.com/flutter/cocoon/pull/3136

All repos have been updated to run on ether macOS 12 or 13 with the exception of Mac subtests of Linux linux_web_engine.

All repos have been updated to run on ether macOS 12 or 13 with the exception of Mac subtests of Linux linux_web_engine. We'll need to keep some bots on macOS 12 until those tests are fixed. Closing this issue as done, though.


New Landscape Entry - [MachineWare]

Project Name
MachineWare
Description
MachineWare's virtual prototypes simulate RISC-V hardware at bit-level accuracy, shortening development time and enhancing software security, stability, and quality.
Homepage URL
https://www.machineware.de/
Repository URL
https://www.machineware.de/
Organization hosting or owning the project
MachineWare GmbH
Evidence of RISC-V ecosystem support
MachineWare is a member of RISC-V International.
Could you list us under "Services".
It is not selectable in the dropdown menu.
Logo

Category
Design Tools

@bprestonlf +1

@aut0 - Would you prefer we use the logo you have attached, or the logo available at https://landscape.riscv.org/card-mode?selected=machine-ware ?

@bprestonlf If possible we would like to use the attached logo as it is easier to recognize.
Thank you.

+1


Feature syslog-ng Elasticsearch output

This PR provides support for OpenSearch/Elasticsearch HTTP output vi syslog-ng. The goal is to be able to swap from fluentd elastic output (https://github.com/uken/fluent-plugin-elasticsearch) as smoothly as possible.
Options available:

[ ] All HTTP options
[ ] Logstash format (prefix, suffix) with good defaults
[ ] Index name
[ ] authentication (username, password)

Seems like I can not ask for a review from the PR's author, so asking a review from @tarokkk here :).

Also here are some notes regarding a simple test deployment for this branch:
https://gist.github.com/OverOrion/57c918f2c75c35af30b2a0531924780d


MariaDB: Fails silently

If one doesn't read the docs and starts the Addon with the default configuration then the Addon fails silently at first glance. From an user perspective/experience point of view is this not optional, especially as this is targeting users which are not familiar with the inner workings.
The default config doesn't pass the validation
databases:
  - homeassistant
logins:
  - username: homeassistant
    password: null
rights:
  - username: homeassistant
    database: homeassistant

My suggestion is to not only log the issue in the system's log but also in the Addon's log. Thought?

Not quite sure... so, quite possibly the frontend is already able to determine this? And thus maybe even possible to disable the start button with a message?
Just thinking out loud as well now. However, for the near future, a UI would be created to handle the options (instead of YAML). The UI schemas have recently been added to the Supervisor API.


Annotated tags are ignored

If you create an annotated version tag with a message like so:
git tag -m "Message" 0.2.0

The tag will not be considered when calculating the next tag.
So given the following commits where 0.2.0 is annotated, the calculated next version will be 0.2.0 because 0.2.0 is ignored and 0.1.0 is used as a starting point.
9f807d5 feat: Feature D
9f807d4 feat: Feature C (tag: 0.2.0)
9f807d3 feat: Feature B (tag: 0.1.0)
9f807d2 feat: Feature A
9f807d1 chore: Inital commit (tag: 0.0.1)
The next tag in this example should be 0.3.0.

Hi @davidolrik, thank you for raising this. This issue has been fixed in v0.15.3.


New extension :  Open in Visual Studio Code

Description
Open current Finder directory, selected folder or file in Visual Studio Code.
Screencast
screencast.webm
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@shubzkothekar great first contribution! The functionality that you built in AppleScript is available in our API as well. I changed your code to use the API instead. This has the benefits that it's faster and easier to maintain. Plus, it supports multi-selection.
Please take a look and let me know if that works for you. Then we can merge it. Another alternative would be to add a new command to the Visual Studio Code Recent Projects extension and rename it. But not sure if we need to have that at this point.

Hey, @thomaspaulmann Thanks for your feedback and replacing AppleScript with Raycast's API. getSelectedFinderItems is not documented on the website, so I didn't know about its existence.
I am okay with the current implementation, except there is one functionality missing. If no finder item is selected, then this command should open the active finder window in Visual Studio Code. Do we have an API for getting the path of the current active finder window? If not, then can I use AppleScript to implement this missing functionality alongside the current updated code? What do you suggest?

You can find the docs here.
Oh, I missed that. We don't have an API for that but you can do that with AppleScript yes. Just not sure if you need it because I would assume you use the extension only with an active Finder window anyways?! I leave it up to you.

Can you fix the linters, then we should be good to go.

Done

Congrats to your first extension in the store 👏


Fix cpu import error

From triton commit 768fc1fcd98ecfc0892f8982b0bb009dd7bb11ea, the functon version_key() is no longer there.

Thanks @yuanfz98, would you mind also updating the commit hash in .github/workflows/integration-tests.yml as well? Otherwise the change looks good to me.


blog for continuous benchmarking

Hey, the blog shows at the bottom of the second page for some reason :shrug:

Really nice post :+1: @mfelsche found all the tiny things :D nothing to add other than: great work :rocket:


Compilation issue with CAN communication on MCP chip

Compilation error: 'MCP2515Class' does not name a type; did you mean 'MCP2515_INT'?
Trying to compile SineWaveCAN on ESP32 (M5Stack Basic) with MCP2515 chip (M5Stack COMMU)
Board: M5Stack-Core-ESP32
Dependencies:

arduino-CAN 0.3.1
MCP_CAN_lib 1.5.1
ODriveArduino 0.10.0

Error output:
In file included from /private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:50:
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:21: error: 'MCP2515Class' was not declared in this scope
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                     ^~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:21: note: suggested alternative: 'MCP2515_INT'
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                     ^~~~~~~~~~~~
                     MCP2515_INT
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:35: error: 'can_intf' was not declared in this scope
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                   ^~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:35: note: suggested alternative: 'wprintf'
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                   ^~~~~~~~
                                   wprintf
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:54: error: expected primary-expression before 'id'
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                                      ^~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:66: error: expected primary-expression before 'length'
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                                                  ^~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:74: error: expected primary-expression before 'const'
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                                                          ^~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:17:93: error: expression list treated as compound expression in initializer [-fpermissive]
 static bool sendMsg(MCP2515Class& can_intf, uint32_t id, uint8_t length, const uint8_t* data) {
                                                                                ^
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:35:24: error: variable or field 'pumpEvents' declared void
 static void pumpEvents(MCP2515Class& intf) {
                        ^~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:35:24: error: 'MCP2515Class' was not declared in this scope
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:35:24: note: suggested alternative: 'MCP2515_INT'
 static void pumpEvents(MCP2515Class& intf) {
                        ^~~~~~~~~~~~
                        MCP2515_INT
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:35:38: error: 'intf' was not declared in this scope
 static void pumpEvents(MCP2515Class& intf) {
                                      ^~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:35:38: note: suggested alternative: 'rintf'
 static void pumpEvents(MCP2515Class& intf) {
                                      ^~~~
                                      rintf
In file included from /private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:3:
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:41:25: error: 'MCP2515Class' was not declared in this scope
 CREATE_CAN_INTF_WRAPPER(MCP2515Class)
                         ^~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveCAN.h:12:40: note: in definition of macro 'CREATE_CAN_INTF_WRAPPER'
     ODriveCanIntfWrapper wrap_can_intf(TIntf& intf) { \
                                        ^~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:41:25: note: suggested alternative: 'MCP2515_INT'
 CREATE_CAN_INTF_WRAPPER(MCP2515Class)
                         ^~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveCAN.h:12:40: note: in definition of macro 'CREATE_CAN_INTF_WRAPPER'
     ODriveCanIntfWrapper wrap_can_intf(TIntf& intf) { \
                                        ^~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveCAN.h:12:47: error: 'intf' was not declared in this scope
     ODriveCanIntfWrapper wrap_can_intf(TIntf& intf) { \
                                               ^~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:41:1: note: in expansion of macro 'CREATE_CAN_INTF_WRAPPER'
 CREATE_CAN_INTF_WRAPPER(MCP2515Class)
 ^~~~~~~~~~~~~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveCAN.h:12:47: note: suggested alternative: 'rintf'
     ODriveCanIntfWrapper wrap_can_intf(TIntf& intf) { \
                                               ^~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:41:1: note: in expansion of macro 'CREATE_CAN_INTF_WRAPPER'
 CREATE_CAN_INTF_WRAPPER(MCP2515Class)
 ^~~~~~~~~~~~~~~~~~~~~~~
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveCAN.h:12:53: error: expected ',' or ';' before '{' token
     ODriveCanIntfWrapper wrap_can_intf(TIntf& intf) { \
                                                     ^
/Users/julesberhault/Documents/Arduino/libraries/ODriveArduino/src/ODriveMCPCAN.hpp:41:1: note: in expansion of macro 'CREATE_CAN_INTF_WRAPPER'
 CREATE_CAN_INTF_WRAPPER(MCP2515Class)
 ^~~~~~~~~~~~~~~~~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:90:1: error: 'MCP2515Class' does not name a type; did you mean 'MCP2515_INT'?
 MCP2515Class& can_intf = CAN;
 ^~~~~~~~~~~~
 MCP2515_INT
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino: In function 'void receiveCallback(int)':
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:108:37: error: 'CAN' was not declared in this scope
   CanMsg msg = {.id = (unsigned int)CAN.packetId(), .len = (uint8_t)packet_size};
                                     ^~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:108:37: note: suggested alternative: 'NAN'
   CanMsg msg = {.id = (unsigned int)CAN.packetId(), .len = (uint8_t)packet_size};
                                     ^~~
                                     NAN
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino: In function 'bool setupCan()':
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:115:3: error: 'CAN' was not declared in this scope
   CAN.setPins(MCP2515_CS, MCP2515_INT);
   ^~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:115:3: note: suggested alternative: 'NAN'
   CAN.setPins(MCP2515_CS, MCP2515_INT);
   ^~~
   NAN
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino: At global scope:
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:144:31: error: 'can_intf' was not declared in this scope
 ODriveCAN odrv0(wrap_can_intf(can_intf), ODRV0_NODE_ID); // Standard CAN message ID
                               ^~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:144:31: note: suggested alternative: 'wprintf'
 ODriveCAN odrv0(wrap_can_intf(can_intf), ODRV0_NODE_ID); // Standard CAN message ID
                               ^~~~~~~~
                               wprintf
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino: In function 'void setup()':
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:204:16: error: 'can_intf' was not declared in this scope
     pumpEvents(can_intf);
                ^~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:204:16: note: suggested alternative: 'wprintf'
     pumpEvents(can_intf);
                ^~~~~~~~
                wprintf
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:204:5: error: 'pumpEvents' was not declared in this scope
     pumpEvents(can_intf);
     ^~~~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:204:5: note: suggested alternative: 'ETSEvent'
     pumpEvents(can_intf);
     ^~~~~~~~~~
     ETSEvent
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:238:18: error: 'can_intf' was not declared in this scope
       pumpEvents(can_intf);
                  ^~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:238:18: note: suggested alternative: 'wprintf'
       pumpEvents(can_intf);
                  ^~~~~~~~
                  wprintf
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:238:7: error: 'pumpEvents' was not declared in this scope
       pumpEvents(can_intf);
       ^~~~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:238:7: note: suggested alternative: 'ETSEvent'
       pumpEvents(can_intf);
       ^~~~~~~~~~
       ETSEvent
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino: In function 'void loop()':
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:246:14: error: 'can_intf' was not declared in this scope
   pumpEvents(can_intf); // This is required on some platforms to handle incoming feedback CAN messages
              ^~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:246:14: note: suggested alternative: 'wprintf'
   pumpEvents(can_intf); // This is required on some platforms to handle incoming feedback CAN messages
              ^~~~~~~~
              wprintf
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:246:3: error: 'pumpEvents' was not declared in this scope
   pumpEvents(can_intf); // This is required on some platforms to handle incoming feedback CAN messages
   ^~~~~~~~~~
/private/var/folders/0y/hgrmrp757yzggl0t3b389nh40000gn/T/.arduinoIDE-unsaved202449-82551-1bp13dc.h7akg/SineWaveCAN/SineWaveCAN.ino:246:3: note: suggested alternative: 'ETSEvent'
   pumpEvents(can_intf); // This is required on some platforms to handle incoming feedback CAN messages
   ^~~~~~~~~~
   ETSEvent

exit status 1

Compilation error: 'MCP2515Class' does not name a type; did you mean 'MCP2515_INT'?

It seems you're using a different MCP library. The ODrive library assumes this one, which looks like this in the library manager:

If you prefer MCP_CAN_lib instead, you would have to write a small glue layer similar to the existing "ODriveMCPCAN.hpp".


WebDriver session Still active

First off, this is crazy helpful in letting me know when and why something is failing. My problem, however is that after the fail the session is still active so then I have to open up the WebDriver hub, refresh sessions, then delete the sessions.
It's not a big deal but it would be super if fail whale did this automatically.

Interesting, I'd like to help. Can you tell me more about opening up the WebDriver hub and refreshing/deleting?
This is not something I am familiar with, can you describe the steps you take in more detail?

In the config file there's the exports.config = {};
inside there's the options for the seleniumAddress
by default it is "http://localhost:4444/wd/hub"
So it looks like
exports.config = {
  seleniumAddress: 'http://localhost:4444/wd/hub',
  specs: ['path/to/file.js']
}

In the browser at the given addres "http://localhost:4444/wd/hub", as Protractor is running, there's a button with the name "refresh sessions". If that button is clicked, it will show tabs of each instance being run. For each tab there are the options "Take Screenshot  |  Delete Session  |  Load Script".
I use this place to delete any sessions that are stalling too much. Normally after a protractor instance is done running, the session goes away as well. In the case of an error the sessions stay around for longer or are never deleted automatically, so I delete them to help not slow down and to keep track of what I have running.
With fail-whale, when an error occurs, my console displays the whale, displays the camera, but does not close the browser currently being tested in, and if I go to the url 'http://localhost:4444/wd/hub' and click refresh sessions, all of the sessions are still running from the fails.
I hope this helps you in understanding what I am talking about

Ok I think I found what you are talking about...

I've actually not seen or used that before.
I will look into this. I'm assuming protractor is doing some cleanup internally which we can probably hook into from the failwhale reporter.

Yes that is exactly what I'm talking about.
I'm pretty sure removing the session closes the browser in addition to removing the session. If it does do this when removing the session programmatically, the option to have the session removed on failure could be an option in the same way showStack or screenshot are boolean options: some people might like to inspect elements on a page after the failure to see why failures are happening.

Ok I think I have that fixed.
Can you npm install protractor-jasmine2-fail-whale again and confirm that it exists for you?
BTW: You on OSX?

The computer I was using was a windows10 computer but I was going to try it out on OSX tonight. I'll let you know how it goes with the update as well as on OSX.

Sounds good. Thanks @zatchgordon

Did you have any luck @zatchgordon?

Whoops. I typed in this message and then never hit comment.
I re-installed it on the Windows10 and installed it on OSX and happy to say it works on both.
The only difference was the path to where the image is saved is a little different, but that's to be expected. If OSX was having problems saving any images I just ran protractor as sudo.

Interesting. Thanks @zatchgordon.
In case it helps: I am not running sudo to save images/screenshots on OSX. I wonder if you may have installed Node, or one of your node packages using sudo, or you are trying to write to a directory outside of your repo.
You happy for me to go ahead and close this issue?

Yeah I had the route to save the image outside of my home directory by accident. On windows i could use the ./screenshot notation to save it in the current folder wherever I was but it wasn't working on OSX so it save it elsewhere. Once I changed the save location to to correct location I ran it without sudo and it worked just fine.

Great!

Closing issue.


Random equation

Reference Issues/PRs
#32
What does this implement/fix? Explain your changes.

Random equations mode added
Test system updated

Any other comments?

Codecov Report

Merging #79 (5c248d5) into dev (c300562) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          206       226   +20
  Branches        24        30    +6
=========================================
+ Hits           206       226   +20

Impacted Files
Coverage Δ

samila/functions.py
100.00% <100.00%> (ø)

samila/genimage.py
100.00% <100.00%> (ø)

samila/params.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c300562...5c248d5. Read the comment docs.

@sadrasabouri Please review this PR 💯


Add signatures to functions and modules

Ensures that we can still call a remote module or function even if the local code isn't present.
Runs with LOCAL and MINIMAL for both test_function and test_module.

Current dependencies on/for this PR:

main

PR #192

PR #200   👈

This stack of pull requests is managed by Graphite.

@rohinb2 fix small bug so unit tests now pass

In general, looks good, I'm not extremely familiar with some of the nuances here to comment extremely deeply on logic, but good to merge

Merge activity

Dec 11, 12:07 PM: @@dongreenberg started a stack merge that includes this pull request via Graphite.


joyent/node-http-signature#123 Need to update jsprim due to vulnerability in json-schema

Obsoletes #124
Testing notes in #123.

+1 on this, for upstream dependencies :)


kubemark-500 test should not use exempt priority level

What happened:
after analyzing the httplog entries from a kubemark-500 test job, we see a lot of requests using the exempt priority level.  Using a limited priority level with a concurrency limit (workload-low priority level for example) will put apf to the test.
If my calculation is correct, roughly 25% of the requests use the exempt priority level.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Network plugin and version (if this is a network-related bug):
Others:

/remove-lifecycle stale

/cc @MikeSpreitzer

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle rotten

I'm closing in favor of https://github.com/kubernetes/kubernetes/issues/104809


Adding templates necessary to support kube-state-metrics

Part of the fix for https://bugs.launchpad.net/charmed-kubernetes-bundles/+bug/1850710
This provides scrape jobs for prometheus to scrape kube-state-metrics endpoints.
Tested by deploying to AWS with https://github.com/charmed-kubernetes/cdk-addons/pull/156 and verifying I could create graphs with kube-state-metrics data.

LGTM


Unable to run proxy as a Linux service

It seems not possible to run the email-oauth2-proxy as a headless service in Linux.
Despite the start-up of the emailproxy.py with option --no-gui and the env variable EMAIL_OAUTH2_PROXY_REQUIREMENTS_NO_GUI=1, the prpograms ends with the following message:
-----8<-----
Traceback (most recent call last):
File "emailproxy.py", line 39, in
import pystray
File "/home/fetch/.local/lib/python3.6/site-packages/pystray/init.py", line 64, in
Icon = backend().Icon
File "/home/fetch/.local/lib/python3.6/site-packages/pystray/init.py", line 56, in backend
return candidate()
File "/home/fetch/.local/lib/python3.6/site-packages/pystray/init.py", line 36, in xorg
from . import _xorg as backend; return backend
File "/home/fetch/.local/lib/python3.6/site-packages/pystray/_xorg.py", line 36, in
display = Xlib.display.Display()
File "/home/fetch/.local/lib/python3.6/site-packages/Xlib/display.py", line 89, in init
self.display = _BaseDisplay(display)
File "/home/fetch/.local/lib/python3.6/site-packages/Xlib/display.py", line 71, in init
protocol_display.Display.init(self, *args, **keys)
File "/home/fetch/.local/lib/python3.6/site-packages/Xlib/protocol/display.py", line 84, in init
name, protocol, host, displayno, screenno = connect.get_display(display)
File "/home/fetch/.local/lib/python3.6/site-packages/Xlib/support/connect.py", line 73, in get_display
return mod.get_display(display)
File "/home/fetch/.local/lib/python3.6/site-packages/Xlib/support/unix_connect.py", line 76, in get_display
raise error.DisplayNameError(display)
Xlib.error.DisplayNameError: Bad display name ""
-----8<-----
The program clearly looks for the DISPLAY variable, which in my non graphical envrion,ent is not set.
What do I miss here?
Thanks for your help.

Is this just with the most recent release (2022-08-22), or do you also get this with the latest commit (which removes the need for the environment variable)

Is this just with the most recent release (2022-08-22), or do you also get this with the latest commit (which removes the need for the environment variable)

Hi Simon,
I'm using version 2022-07-09. So then do you recommend me to try the commit of today Aug, 29?
Thanks
From: Simon Robinson @.>
Sent: 29 August 2022 12:02
To: simonrob/email-oauth2-proxy @.>
Cc: BRASPENNING Eddy @.>; Author @.>
Subject: Re: [simonrob/email-oauth2-proxy] Unable to run proxy as a Linux service (Issue #56)
U ontvangt niet vaak e-mail van @.*** Meer informatie over waarom dit belangrijk ishttps://aka.ms/LearnAboutSenderIdentification
Is this just with the most recent release (2022-08-22), or do you also get this with the latest commit (which removes the need for the environment variable)

Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsimonrob%2Femail-oauth2-proxy%2Fissues%2F56%23issuecomment-1230070705&data=05|01|eddy.braspenning%40soprasteria.com|019b67bede87421128dc08da89a574df|8b87af7d86474dc78df45f69a2011bb5|0|0|637973640968203312|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=B63%2FsUGzfScbg5NXZNcuTN5y7JPvxYngjJp%2FaVKb7Nk%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALM2WTA3WL72IY6R62MR5JDV3SC73ANCNFSM5742WQLQ&data=05|01|eddy.braspenning%40soprasteria.com|019b67bede87421128dc08da89a574df|8b87af7d86474dc78df45f69a2011bb5|0|0|637973640968203312|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2Be%2FN8eDLogsLt4Qy5jyQB3oqCHFoVUgwqu7v5gVIDd4%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Yes - it removes the need for the environment variable, and you can just use --no-gui.

Latest build of today installed, which starts successful with just the -no-gui option.
Thanks!
From: Simon Robinson @.>
Sent: 29 August 2022 13:50
To: simonrob/email-oauth2-proxy @.>
Cc: BRASPENNING Eddy @.>; Author @.>
Subject: Re: [simonrob/email-oauth2-proxy] Unable to run proxy as a Linux service (Issue #56)
U ontvangt niet vaak e-mail van @.*** Meer informatie over waarom dit belangrijk ishttps://aka.ms/LearnAboutSenderIdentification
Yes - it removes the need for the environment variable, and you can just use --no-gui.

Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsimonrob%2Femail-oauth2-proxy%2Fissues%2F56%23issuecomment-1230179955&data=05|01|eddy.braspenning%40soprasteria.com|1578bcc3c30e4f475f0908da89b4a2aa|8b87af7d86474dc78df45f69a2011bb5|0|0|637973706160092311|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ZDV2nAxG7PR4NkP4UVylX%2BiFpY4cqJUKTzOYw%2FZO%2F28%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALM2WTBL5467XHYQLMOMLA3V3SPXJANCNFSM5742WQLQ&data=05|01|eddy.braspenning%40soprasteria.com|1578bcc3c30e4f475f0908da89b4a2aa|8b87af7d86474dc78df45f69a2011bb5|0|0|637973706160092311|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RMpMk7Lu3gcl3RzYWZ4kelOgayg7S%2B%2Bdo8J2skiJPUs%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


[BUG] - DropDownMenu not supporting items to spread across grid columns

NextUI Version
2.2.9
Describe the bug
I want to basically create a mega menu by spreading dropdown menu items column wise upto a certain height and wrap the next set of items in the next column and so on. I tried this by doing the below code but still the items span only through a single column.
<DropdownMenu
    aria-label="Menu"
    className="grid grid-cols-2 w-[400px] gap-3 text-center"
    itemClasses={{
        base: "gap-4"
    }}
    as="div"
>
    <DropdownItem as="div">T-shirt1</DropdownItem>
    <DropdownItem as="div">T-shirt2</DropdownItem>
</DropdownMenu>

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
.
Expected behavior
I want dropdown menu items to spread column wise upto a certain height and wrap the next set of items in the next column and so on..
Screenshots or Videos

Operating System Version
macOS
Browser
Firefox

You can pass className to the menu list through slots. Try this:
<DropdownMenu
    aria-label="Menu"
    classNames={{list: "grid grid-cols-2 w-[400px] gap-3 text-center"}} // slots
    itemClasses={{
        base: "gap-4"
    }}
    as="div"
>
    <DropdownItem as="div">T-shirt1</DropdownItem>
    <DropdownItem as="div">T-shirt2</DropdownItem>
</DropdownMenu>

example

Wow, that worked well for me. Thanks a lot for the help. Will close the issue.

Hi guys, I also want to build a responsive megamenu. Anyone can help? Thanks.


UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 918: ordinal not in range(128)

I'm getting that when I try to run this in Python 3.
I'm able to run demo.py in Python 2.
Is it possible to get a pretrained model for Python 3?  I'm also unable to convert the Python 2 model to Python 3.

This is the reason of python's version, please check https://github.com/twtygqyy/pytorch-vdsr/issues/21#issuecomment-372150250


Civilian equipment

Federal agents and military types have reasonably good equipment defined, but there's little or nothing set up for civilians. I'd like to improve that.

I was thinking stuff like 95% chance of a smartphone, 25% chance of a laptop, 25% chance of a handgun, 25% chance of a pocket knife or tool, that kind of thing. 100% chance of a laptop for computer scientists, of course.

Maybe some ideas here.

Always happy to revisit and improve, but closing for now.


Remove shader check. Made blacklist a table and added documenting to it.

Tested and working

This is back to only checking pp/copy. Is this ok? Wasn't there one additional specific material that was bad? In any case, I can approve this now and then wait a while for possible responses and then merge.
Also: I saw some benchmarking tests where for was faster than ipairs (but not if luaJIT was enabled, then they were the same). It won't matter at all for this use case, just wanted to mention it.

Oh wow. Yet another wrong solution... @thegrb93 you really don't know what you are doing there. Go stick to your Starfail (StarfallEx)...
Thanks to @thegrb93's new implementation: Any material containing pp/copy will now be blocked as well, certain materials won't work...
Consider the following case:
A custom material called hdpp/copybypixel.
When I try to use it via E2, it will run down to E2Lib.validMaterial("hdpp/copybypixel") which will return an empty string and prevent it from being set:
Because it is using a bad pattern.
@Divran So, please fix the pattern or revert his terrible solution.
/change-requested

This is exactly how it was before. You can complain about it being incorrect but it didn't break anything compared to how it was before #1245.

This is exactly how it was before. You can complain about it being incorrect, but it didn't break anything compared to how it was before #1245.

What are you talking about?! That's now how it was before, validMaterial and the patterns is the new code introduced by @thegrb93.
This is how E2 setMaterial functions used to do it:

This is exactly how it was before. You can complain about it being incorrect, but it didn't break anything compared to how it was before #1245.

What are you talking about?! That's now how it was before, validMaterial and the patterns is the new code introduced by @thegrb93.
This is how E2 setMaterial functions used to do it:
if string.lower(material) == "pp/copy" then return end
The above code is wrong too, but @thegrb93 implementation and attempts to fix it, are done wrong too.

@bigdogmat

This is exactly how it was before. You can complain about it being incorrect, but it didn't break anything compared to how it was before #1245.

What are you talking about?! That's not how it was before, E2Lib.validMaterial and the need for Lua pattern is the new code introduced by @thegrb93.
This is how E2 setMaterial/holoSetMaterial functions used to do it:
if string.lower(material) == "pp/copy" then return end
The above code is wrong too, but @thegrb93's implementation and attempts to fix it, are done wrong too.
Perhaps (learn to) use Git(Hub)?

Sorry about that, looked at the wrong diff.

Ok just change the pattern to "pp[%./\\]+copy$"
@CaptainPRICE if the pr hadn't been accepted, nobody would've found that issue.

I don't see you making any improvements to it.

@thegrb93 Read my comments (and complains) at the "#dev-wiremod" (Wiremod) Discord channel.
In short: Using Lua patterns to fix this is a dirty way for a couple of reasons.
Even with your new stricter pattern, it is still a wrong solution, because there is no starting anchor (^).
Uh-oh, hdpp/copy is now blocked. If you were to add the starting anchor, you should realize that you will introduce workarounds again (i.e. ../materials/pp/copy). And there you have it, dirty fella.
The only perfect solution to this issue is to make use of the "filesystem parser" (but I'll stop here for a reason).
(Hopefully this will move it into the right direction from now on; stop relying on Lua [shitty] patterns.)

I think I know a better solution to this (alternative to mine suggestion above "filesystem parser).
But, let me test it first :)
I will push my own PR in a short if it is a success.

Whatever makes your epeen harder

And it doesn't need a starting anchor, checking the top folder and material name is enough.

Couldn't you just block any material containing /. or ./ ? AFAIK those should never show up in valid material names, and should block all relative path tricks.

A folder/material name can contain dots (maybe valve's filesystem allows it?), but I'm not sure. I've never seen one that uses a dot though so it would probably be safe. This current method works well enough though.

They can contain dots, sure - however ones ending in a dot will behave oddly on Windows, and ones starting with a dot will behave oddly on Linux, so I expect it to be a much safer bet than that textures won't contain ppcopy.

Oh wow. Yet another wrong solution... @thegrb93 you really don't know what you are doing there. Go stick to your Starfail (StarfallEx)...

@CaptainPRICE, this kind of attitude to other members in the Wiremod community is unacceptable. I don't want to ban anybody from being able to contribute to Wiremod, but you spend a lot of time insulting other users, causing arguments, and acting against the best interests of the community. I advise you to take some time away from this discussion to think about the way you're acting, and to be on your best behaviour from now on.


Options for abbreviating paths in the Buffers command

Description
As far as I can see from the docs for the Buffers command, there isn't a way to make long paths in buffer list more readable. I should always be able to see the filenames of buffers here, even for small window widths.

Ideally, config would be available to let me declare how many parent directories should be shown. Alternatively, something like the Files command's path_shorten would help!
The reach.nvim plugin uses a fancy "lowest unique parent directory" system, which would be quite neat.

I'd be happy to have a go at these changes myself with a bit of guidance: which solution you prefer, where I can find the relevant files, things to watch out for.

Alternatively, something like the Files command's path_shorten would help!

https://github.com/ibhagwan/fzf-lua/commit/180c4650cb215a21c489290b01726a158801299c
Ty for raising this issue @egargan, apparently I accidentally missed path_shorten support for buffer providers (buffers, tabs).


Add generic ReferenceRegion pushdown for parquet files

Would look like this:
val predicate: FilterPredicate = ((LongColumn("end") >= region.start) && (LongColumn("start") <= region.end) && (BinaryColumn("contigName") === Binary.fromString(region.referenceName)))

+1

Sitting on a personal branch: https://github.com/akmorrow13/mango/blob/middle-cache/mango-core/src/main/scala/org/bdgenomics/mango/util/ResourceUtils.scala#L32
Do we want to put this in a more central location @heuermh @fnothaft @devin-petersohn ?

In #1324, there has been some discussion between @fnothaft, @heuermh, and me around the possibility of using ReferenceRegion in Formats. Should we revisit this?

I'm triaging this to 0.24.0.


root_id when loading graph

When loading graph, we need to provide the root_id, but how would I know the root_id? For example,
from llama_index.indices.composability import ComposableGraph
llm_predictor = LLMPredictor(llm=ChatOpenAI(temperature=0, max_tokens=512, model_name='gpt-3.5-turbo'))
service_context = ServiceContext.from_defaults(llm_predictor=llm_predictor)
storage_context = StorageContext.from_defaults()

graph = ComposableGraph.from_indices(
    GPTListIndex,
    [essay_index, empty_index],
    index_summaries=[essay_index_summary, empty_index_summary],
    service_context=service_context,
    storage_context=storage_context,
)

Then when we reload:
from llama_index.indices.loading import load_graph_from_storage
storage_context.persist('data/heterogenous_graph_test')
graph=  load_graph_from_storage(storage_context, root_id=graph.root_id)

But graph would not be defined at reloading without reconstructing graph

I save the root_id and reload graph, but the graph have  KeyError, can't find the docs relation.

I save it in the file name of the folder for example graph_name__id, but later I get an error like this:
File "G:\Other computers\My Computer\dashboard_v2.py", line 343, in main
print(graph.root_index)
File "C:\Users\Risto Trajanov\anaconda3\envs\myenv_3.8\lib\site-packages\llama_index\indices\composability\graph.py", line 34, in root_index
return self._all_indices[self._root_id]
KeyError: '7b2b0f99-8045-4ba6-b843-5cf5ca5935ae'

You get that error because of the storage context.
Try doing this if you have the default.
storage_context = StorageContext.from_defaults(persist_dir="./storage")

I have the same issue. After creation of the graph i copied the root_id. In next step i tried to load the graph with the copied root_id and in Debugger the graph is loaded, the error (KeyError) occurs, while query is running.

graph

even if you try setting the persist_dir on the fly, you still run into the issue of  root_id not defined when you refresh the notebook / code.
from llama_index import load_graph_from_storage
graph = load_graph_from_storage(
    # root_id=root_id,
    service_context=service_context,
    storage_context=StorageContext.from_defaults(persist_dir='./data/uber_index/root'),
)

If you try commenting root_id out, it will return
TypeError: load_graph_from_storage() missing 1 required positional argument: 'root_id'

+1 to the issue.
Getting the KeyError whenever trying to load the graph and query it.


websafe_svg does not work in flutter web 2.0

Hi,
If I run the app in a mobile emulator it works perfectly, however if I run the app in web mode the icons are not shown, only a rectangle with an x inside is shown.
In debug console:
Exception caught by image resource service
Failed to decode image data.
Image source: data:image/svg+xml;base64,PHN2Z...................................
Flutter 2.1.0-11.0.pre.145 channel master
Dart 2.13.0
Please is there a solution for this problem.
Thanks a lot.
Regards,
Jose

I confirm this bug...

Did you find any other way to display the svg images in the flutter web?

Same issue.

Same +1
════════ Exception caught by image resource service ════════════════════════════
The following ImageCodecException was thrown resolving an image codec:
Failed to decode image data.
Image source: data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCEtLSBHZW5lcmF0b3I6IEFkb2JlIElsbHVzdHJhdG9yIDIyLjEuMCwgU1ZHIEV4cG9ydCBQbHVnLUluIC4gU1ZHIFZlcnNpb246IDYuMDAgQnVpbGQgMCkgIC0tPgo8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4IgoJIHZpZXdCb3g9IjAgMCAyNTYgMjA3LjYiIHN0eWxlPSJlbmFibGUtYmFja2dyb3VuZDpuZXcgMCAwIDI1NiAyMDcuNjsiIHhtbDpzcGFjZT0icHJlc2VydmUiPgo8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoJLmNvbW1lbnQtMHtmaWxsOm5vbmU7c3Ryb2tlOiNGRkZGRkY7fQo8L3N0eWxlPgo8cGF0aCBjbGFzcz0iY29tbWVudC0wIGZpbGwtbm9uZSBzdHJva2Utd2hpdGUiIHN0cm9rZS13aWR0aD0iMyIgc3Ryb2tlLW1pdGVybGltaXQ9IjEwIiBzdHJva2Utb3BhY2l0eT0iMC41IiBzdHJva2UtZGFzaGFycmF5PSIxMCIgZD0iTTEuNSwxNzJWNy41YzAtMy4zLDMuMy02LDcuMy02aDIzOC42YzMuOSwwLDcuMSwyLjYsNy4xLDUuOHYxNjRjMCwzLjYtMy41LDYuNS03LjksNi41SDYyLjQKCWMtMywwLTUuNiwxLjQtNi44LDMuN2wtMjIsMjIuNmwtMC4yLTIyLjRjLTEuMS0yLjMtMy44LTMuOS02LjgtMy45SDguNkM0LjcsMTc3LjgsMS41LDE3NS4yLDEuNSwxNzJ6Ii8+Cjwvc3ZnPgo=

Have you tried using flutter_svg in the pre-release?  I've had some success with that.  This appears to be related to the canvas vs HTML based rendering.  HTML based works, canvas does not.

using flutter run -d chrome --web-renderer html, it's displayed , ok
but using vscode debug model like this launch.json file config don't display svg:
"name": "Flutter",
"type": "dart",
"request": "launch",
"program": "lib/main.dart",
"args": ["--web-renderer html"]

Fixed:
https://pub.dev/packages/websafe_svg/versions/2.0.0-nullsafety.0
Unfortunately, it has to stay a pre-release version until flutter_svg releases Null Safety on Stable too.


Allow to change popup properties after it was initialized

Currently, it's not possible to change popup properties after it was initialized. Extend showPopup allowing to change title, subtitle, buttons, cssClass after popup was displayed using original "options" object. Example:
var popupOptions = {
  title: 'Initial Title'
};
$ionicPopup.show(popupOptions);
popupOptions.title = 'New Title';

Change doesn't affect built in 'alert', 'prompt' and 'config' functions.

@adamdbradley, @mlynch,
Can you, please, take a look at this PR? I don't ask to merge it right away, just to know whether it makes sense to you. We heavily depend on this and if it doesn't make sense, will have to look for another option (maybe you can suggest a better one).

Sorry but this change I think could be dangerous and have unwanted side effects. I'd also worry this would cause issue from the option variables being reused, rather than copied.


Empty database fix

Avoid to find an empty database in certain cases.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


[Feature Request] Add support for podman-systemd.unit

a systemd replacement for docker-compose
The Document

Thanks, I will take a look on it recently


Change String[] @db.Array(ObjectId) to String[] @db.ObjectId

Problem

The recommended way to model many-to-many's is with a list of ObjectIDs. Taken from our documentation:
model Post {
  id          String     @id @default(dbgenerated()) @map("_id") @db.ObjectId
  categoryIDs String[]   @db.Array(ObjectId)
  categories  Category[] @relation(fields: [categoryIDs])
}

model Category {
  id      String   @id @default(dbgenerated()) @map("_id") @db.ObjectId
  postIDs String[] @db.Array(ObjectId)
  posts   Post[]   @relation(fields: [postIDs])
}

The @db.Array(ObjectId) doesn't align with our other databases, which would represent the native type as @db.X See this comment for how other databases handle it.
Suggested solution

Align MongoDB with the other databases
model Post {
  id          String     @id @default(dbgenerated()) @map("_id") @db.ObjectId
- categoryIDs String[]   @db.Array(ObjectId)
+ categoryIDs String[]   @db.ObjectId
  categories  Category[] @relation(fields: [categoryIDs])
}

model Category {
  id      String   @id @default(dbgenerated()) @map("_id") @db.ObjectId
- postIDs String[] @db.Array(ObjectId)
+ postIDs String[] @db.ObjectId
  posts   Post[]   @relation(fields: [postIDs])
}

Using this example repository, I tried removing @db.Array, re-generating and running the Prisma Client, I get the following run-time error:
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', query-engine/connectors/mongodb-query-connector/src/root_queries/read.rs:112:74
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
PrismaClientUnknownRequestError:
Invalid `prisma.post.findMany()` invocation in
/Users/m/dev/src/github.com/prisma/prisma-mongodb-relations/index.ts:6:35

  3
  4 async function main() {
  5   // From the post side
→ 6   const posts = await prisma.post.findMany(
  called `Option::unwrap()` on a `None` value
    at cb (/Users/m/dev/src/github.com/prisma/prisma-mongodb-relations/node_modules/@prisma/client/runtime/index.js:38695:17) {
  clientVersion: '3.9.0-dev.15'

Some additional todos:

[x] Fix breaking behavior in Query Engine
[x] Invalidate @db.Array(...) in schema validation (for prisma format etc)

[x] Consider the migration path from the internal document: https://www.notion.so/prismaio/Design-discussion-the-Array-native-type-on-MongoDB-c67615379df6453d88d5d7b7e9768966#0f2fc74fff0548cbb0265746d854f4ed

[x] Communicate this as a "breaking change" in the Release Notes. MongoDB is still in Preview though.
[x] Update the docs.

Additional context

Internal design document

I think it was closed by a mention involuntarily. So reopening as it seems some tasks are still to be done.

Left to be done:

Communicate as breaking change
Update the docs

Docs already has an issue they're tracking and this will be in the release notes. Closing.

i am having this same error, and nothing is working out

You definitely don't as that change was made years ago. Please open a new issue and describe the actual you are having by filling the issue template. Thank you.


Write a C++ program to find factorial of a number

Description
Write a C++ program to find factorial of a number
Factorial of N = N (N-1) (N-2) ... 1
Input  : 5
Output : 120

How to contribute

Save the solution in program/FindFactorialOfANumber.cpp file
Add FindFactorialOfANumber.cpp file in find-factorial-of-a-number folder

!assign

!assign


best way to clone node & have two instances of a controller running?

I'm trying to create two instances of 1 widget Box; is this the best way?
Also bug report? Its not working.

var Box = Controller.extend({
	init:function(){},
	render:function(){
		return {
			view: { html: 'adsfasdfdsfadfsa' }
		}
	},
	click:function(){},
})

window.app = new Box({view: 'appwrapper' })
window.app2 = new Box({ view: 'appwrapper' })

// nothing is displayed and no errors are given
// 	window.app = new Box({view: document.getElementById('app') })
// works
from the docs:
If options.view is a string, then it is used to locate the DOM node by ID and clone its first child. This is much faster than doing templating and parsing templates using innerHTML.
not sure if its not working or im doing it wrong. Chrome 33 on linux.

I have one other question for you -- I'm doing emit wrong..
I wrote a quick fn to extend Collection; it changes every item in the collection,
mycollection.setAllKeyToValue('image', '')
heres the fn
Collection = Collection.extend({
	setAllKeyToValue:function(key,value){
		for (var i = 0; i < this.items.length; i++){
			this.items[i][key] = value
			this.emit('change', { updated: this.items[i], index: i });
		}
	}
    })

im not getting the change event when i use it -- im not sure what im supposed to pass as the value for updated -- ive tried a few things here, maybe you can help?

View refers to the current view element. You should not use that as a ref. change the ref name to something else.

On 4 Feb 2015, at 08:31, falafflepotatoe<EMAIL_ADDRESS>wrote:
I'm trying to create two instances of 1 widget Box; is this the best way?
Also bug report? Its not working.

var Box = Controller.extend({
init:function(){},
render:function(){
return {
view: { html: 'adsfasdfdsfadfsa' }
}
},
click:function(){},
})
window.app = new Box({view: 'appwrapper' })
window.app2 = new Box({ view: 'appwrapper' })
// nothing is displayed and no errors are given
// window.app = new Box({view: document.getElementById('app') })
// works
from the docs:
If options.view is a string, then it is used to locate the DOM node by ID and clone its first child. This is much faster than doing templating and parsing templates using innerHTML.
not sure if its not working or im doing it wrong. Chrome 33 on linux.
—
Reply to this email directly or view it on GitHub.

In the future, if you don't know how to do something please email me instead of opening an issue.  Also I suggest reading the source code as its very small, and is the best way to understand how everything works.

works fine for me: http://jsfiddle.net/qz5p73yr/
make sure you add the event listener before calling setAllKeyToValue

On 4 Feb 2015, at 10:30, falafflepotatoe<EMAIL_ADDRESS>wrote:
I have one other question for you -- I'm doing emit wrong..
I wrote a quick fn to extend Collection; it changes every item in the collection,
mycollection.setAllKeyToValue('image', '')
heres the fn
Collection = Collection.extend({
setAllKeyToValue:function(key,value){
for (var i = 0; i < this.items.length; i++){
this.items[i][key] = value
this.emit('change', { updated: this.items[i], index: i });
}
}
})
im not getting the change event when i use it -- im not sure what im supposed to pass as the value for updated -- ive tried a few things here, maybe you can help?
—
Reply to this email directly or view it on GitHub.

yea thanks for your help tho.
regarding the first issue i think it may be a bug. specifically/only the case where the view option is a string.
the docs say it should find that element and clone the first child, but nothing is happening in chrome.
http://jsfiddle.net/xccbhu7s/
remembering back from the source i think i saw you use something like cloneNode:true option -- maybe im forgetting to pass that option as well? (not sure if its listed in the docs)

yea sorry i think i didnt understand the docs
|  If options.view is a string, then it is used to locate the DOM node by ID and clone its first child.
I understood this as you can create one template with html and clone it to as many widgets as you want -- i dont think thats possible nor the intention of that line of docs...

that is the intention, you just not adding those views to the DOM after you instantiate them :) see this:
http://jsfiddle.net/xccbhu7s/1/
you can create a controller that is either bound to an existing DOM element:
window.app = new Box({view: document.getElementById('app')})
OR clones an existing element:
app = new Box({view: 'appwrapper' })
in which case the clone is in memory, you have to append it to the DOM, the same way render() returns a { list: new List(…) }

On 5 Feb 2015, at 12:47, falafflepotatoe<EMAIL_ADDRESS>wrote:
yea sorry i think i didnt understand the docs
| If options.view is a string, then it is used to locate the DOM node by ID and clone its first child.
I understood this as you can create one template with html and clone it to as many widgets as you want -- i dont think thats possible nor the intention of that line of docs...
—
Reply to this email directly or view it on GitHub.

ahh ok - thanks a bunch


Officially supported Octopus Deploy plugin for Jenkins

This PR reflects a change in ownership of the plugin code from community members to the Octopus Deploy organisation.  The plugin has been re-implemented to more closely align with the extensibility goals of Octopus Deploy.
The plugin requires the Octopus command line tool in order to perform operations.
The following steps have been added:

Create package
Push package
Push build information

The plugin is now compatible with Spaces.

Will this also add the ability to work with pipeline scripting?

Will this also add the ability to work with pipeline scripting?

@LeoDOD not yet but it is on our radar.

Please also see https://github.com/OctopusDeploy/octopus-jenkins-plugin/issues/60

I am noticing a lot of issues with the current plugin to support agent executions. For example, when publishing a zip package, it expects the path to exist on the Jenkins master and fails if it doesn't.
However, for my case, the files exist on the job agent instead.
Does this PR introduce fixes for that?


Documentation: Minor inaccuracy in Building CM-Well

In https://github.com/thomsonreuters/CM-Well/blob/master/docs/Tutorial.Building.md, there is the following:
Add the scala binary directory to your path
$ PATH=$PATH:$SCALA_HOME/bin;export $PATH
The last '$' in the line should be removed.
If I am being perfectly picky about it, the line of text before it should capitalize "Scala" and have a colon at the end of the line.

That's one of mine.. I'll fix now

Fixed in #313


Added support for half precision type in linear algebra operators

Fixes #22086
Following changes were made:

Added float16 support to relevant ops defined in linalg_ops.cc
Added unit tests in linalg_ops_test.cc for validation of float16 support.

I am new to tensorflow development. So it would be nice if someone can review the code and suggest any edits if any.

Patrick, can u take a look? Thanks.

The clang format check is failing, see https://source.cloud.google.com/results/invocations/70c2c0dc-d4b3-4074-a5c3-415c740c1c22/targets/%2F%2Ftensorflow%2Ftools%2Fci_build:gen_ci_clang_format_out/log
diff --git a/tensorflow/core/ops/linalg_ops_test.cc b/tensorflow/core/ops/linalg_ops_test.cc
index 8bcd271660..52d77991bd 100644
--- a/tensorflow/core/ops/linalg_ops_test.cc
+++ b/tensorflow/core/ops/linalg_ops_test.cc
@@ -84,7 +84,7 @@ TEST(LinalgOpsTest, SelfAdjointEigV2_ShapeFn) {
.Input({{"input", 0, DT_FLOAT}})
.Attr("compute_v", compute_v)
.Finalize(&op.node_def));

//test for float16

// test for float16
TF_ASSERT_OK(NodeDefBuilder("test", "Pack")
.Input({{"input", 0, DT_HALF}})
.Attr("compute_v", compute_v)

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 43 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


Firefox rejects DTLS certificate when connected to multiple processes running str0m

For context, we use str0m as an SFU. Due to our unique setup, a single browser client may be connected to multiple SFUs at the same time. Our SFUs generate one DTLS certificate each on startup and then re-use it for all of that SFU's rooms.
Firefox clients fail to connect to the second SFU in this setup, with an error of:
Dtls(Io(Custom { kind: InvalidData, error: Error { code: ErrorCode(1), cause: Some(Ssl(ErrorStack([Error { code: 167773202, library: "SSL routines", function: "dtls1_read_bytes", reason: "sslv3 alert bad certificate", file: "ssl/record/rec_layer_d1.c", line: 613, data: "SSL alert number 42" }]))) } }))

This seems like a resurfacing of https://github.com/versatica/mediasoup/issues/127, which we have a workaround for here. The problem is that both SFUs generate their certificate with the same starting serial number of 1, since they are different processes. This brings us to the same situation again - same serial + issuer, but different certificate.
The problem seemed to be fixed when I replaced this atomic increment with a randomly-generated 128-bit number. Would that be an okay solution?

Sure, I don't care as long as it works with all browsers.


feat: Adding global ASDF plugin ability (+golang) while ensuring asdf

closing this PR in favor of a more extensive work item to do this more comprehensively/properly


Command with no icon causes problem debug/toolbar menu contribution

Found this while verifying #69340:
For such as contribution:
{
  "contributes": {
    "commands": [
      {
        "command": "extension.helloWorld",
        "title": "Hello World"
      }
    ],
    "menus": {
      "debug/toolbar": [
        {
          "command": "extension.helloWorld",
          "when": "debugType == chrome"
        }
      ]
    }
  }
}

Here's the display:

I suggest showing a warning notification and not display the broken icon in this case (similar to how you handle menu contribution with no corresponding command).

Dup of #69395