Swarm commands should error out if token flag does not contain "://"

The "--swarm-discovery token://" option should error out if the user does not specify "token://".
I have watched two people complete the Swarm "Getting Started" guide, and both specified "token:flkajdkasdl" instead of "token://flkajdkasdl".
For both cases, the individuals were confused by the documentation, and thought the '//' meant that the token value was a comment.  They didn't realize that :// is required.
To avoid confusion, the command should terminate with an error when 'token://' does not include the double-slashes.

I think that's a flag for docker-machine and not swarm, but swarm also gets passed tokens.

/cc @ehazlett @nathanleclaire

Fixed in : https://github.com/docker/machine/pull/1606 thanks @hairyhenderson!


vagrant: Configure hosts & hostname in Sol10 VF

Fixes: #2349 , Ref: VPC-1336
This resolves the issue that VPC has been having, in that updating  sudo to the latest version, causes it to stop working. The error message says:
sudo: unable to resolve host adoptopenjdkSol10: node name or service name not known\r\r\nsudo: error initializing audit plugin sudoers_audit\r\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error

For some reason, the 'unable to resolve host' message had never caused sudo to fail, however with the newest update (1.9.8p2) it does. When I set adoptopenjdkSol10 as the hostname, and add it to /etc/hosts, the error no longer occurs.
This PR should fix both the GitHub check and VPC, as they use the same Vagrantfile.
Checklist

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

In case it isn't obvious, @gdams has also unpinned the vagrant version for the GitHub checks. The Solaris check has passed, so, merging


Scrollbar indicators get out of step for very large line numbers

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Version: 1.64.2
OS Version: 10.15.7

Steps to Reproduce:

Open a large file with merge conflicts
At lines > 10k, the merge conflict indicator in the scroll bar is not correctly positioned relative to the viewport indicator. Eg in the screeshot, the conflict is at the top, but the scrollbar shows it as being at the bottom.

Let's track in #82087. This is because we artificially enforce a min height of 20px on the scrollbar slider. See also https://github.com/microsoft/vscode/issues/82087#issuecomment-768601184 for a visual comparison about how the artificial min height affects the geometry of the scrollbar.


[Bug] advanced unstuck doesn't cancel vnavmesh path and therefore remains in place when trying to move backwards

^

This is intentional. Canceling a pathing task while vnavmesh is generating a path will cause vnavmesh to lock up entirely in some situations. Advanced unstuck is intended to 'trick' vnav into generating a path when it's not able to normally.


refactor: Perform plugin resolution per platform

Part of #137040 and #80374
possibleResolutions and possibleResolutions used a key containing the platform and the plugin name via getResolutionKey. The global list is not necessary and also confusing. It can be avoided by handling the resolution of plugins per platform. This helps to have a more self-contained plugin resolution. This also is necessary to reuse the plugin resolution logic (per platform) for #137040.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Blocked by #144214

@christopherfujino @stuartmorgan for review / adding reviewers and adding test-excempt. Thank you for your time.

Any chance to get this reviewed @christopherfujino? Or at least adding you as reviewer? I can't do that unfortunately. Sorry to bother you.

test-exempt: code refactor with no semantic change

Thank you both for shipping :D


[DB Scripts] CON_APP_KEY constraint contains TOKEN_ID column

Description:
A token field is included(TOKEN_ID) in the CON_APP_KEY constraint definition, which leads to allow multiple access tokens even other constraints are unique(i:e same grant type, same user, the same set of scopes but 2 access tokens).
This issue is there in oracle_rac.sql, postgresql.sql and oracle.sql scripts
This issue has observed in  an IS-as-KM cluster with high concurrency level(~200 identical token requests)
Affected Product Version:

Latest IS-KM server ATM

OS, DB, other environment details and versions:

Oracle 12C rac

Steps to reproduce:

Create an Application from API Manager store
Make burst of an access token requests with client credential grant type
You will see multiple access token records created for the same application

Related to https://github.com/wso2/product-is/issues/4197


Error when using with pd.read_parquet with threading on

Since updating to latest version I randomly get errors like this:
Traceback (most recent call last):
  File "print_parquet_metadata.py", line 28, in <module>
    df = pd.read_parquet(args.file, use_threads=True)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pandas/io/parquet.py", line 282, in read_parquet
    return impl.read(path, columns=columns, **kwargs)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pandas/io/parquet.py", line 129, in read
    **kwargs).to_pandas()
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pyarrow/parquet.py", line 1216, in read_table
    use_pandas_metadata=use_pandas_metadata)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pyarrow/parquet.py", line 216, in read
    use_threads=use_threads)
  File "pyarrow/_parquet.pyx", line 1086, in pyarrow._parquet.ParquetReader.read_all
  File "pyarrow/error.pxi", line 87, in pyarrow.lib.check_status
pyarrow.lib.ArrowIOError: Unexpected end of stream: Page was smaller (26292) than expected (59582)

I'm pretty sure that the file is not corrupted because sometimes it can be read successfully, and it can also be read when the file is local.
It is also very hard to reproduce consistently but if I try to read the file in a loop, I realize a pattern:
This will succeed 30 times in a row without a problem
f = "s3://<bucket>/<parquet_file>"
for i in range(30):
    pd.read_parquet(f, use_threads=False)

This will fail sometimes on the first iteration, sometimes on the second, and never got to iteration number 5:
f = "s3://<bucket>/<parquet_file>"
for i in range(30):
    pd.read_parquet(f, use_threads=True)

I suspect that it has something to do with random access with multiple threads, and the cache is not handling it correctly.
Finally this is the debug log which I hope will help
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): mybucket.s3.us-west-2.amazonaws.com
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /?list-type=2&prefix=&delimiter=%2F&encoding-type=url HTTP/1.1" 200 None
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /?list-type=2&prefix=temp%2F&delimiter=%2F&encoding-type=url HTTP/1.1" 200 None
DEBUG:fsspec:<File-like object S3FileSystem, mybucket/temp/data.parquet> read: 18606060 - 18671596
DEBUG:s3fs.core:Fetch: mybucket/temp/data.parquet, 18606060-23914476
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /temp/data.parquet HTTP/1.1" 206 65536
DEBUG:fsspec:<File-like object S3FileSystem, mybucket/temp/data.parquet> read: 18176581 - 18670182
DEBUG:s3fs.core:Fetch: mybucket/temp/data.parquet, 18176581-18606060
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /temp/data.parquet HTTP/1.1" 206 429479
DEBUG:fsspec:<File-like object S3FileSystem, mybucket/temp/data.parquet> read: 4 - 7237571
DEBUG:s3fs.core:Fetch: mybucket/temp/data.parquet, 4-12480451
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /temp/data.parquet HTTP/1.1"<PHONE_NUMBER>7
DEBUG:fsspec:<File-like object S3FileSystem, mybucket/temp/data.parquet> read: 8274755 - 18176458
DEBUG:s3fs.core:Fetch: mybucket/temp/data.parquet, 8274755-10485764
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /temp/data.parquet HTTP/1.1"<PHONE_NUMBER>
DEBUG:fsspec:<File-like object S3FileSystem, mybucket/temp/data.parquet> read: 7237648 - 8274676
DEBUG:s3fs.core:Fetch: mybucket/temp/data.parquet, 7237648-8274755
DEBUG:urllib3.util.retry:Converted retries value: False -> Retry(total=False, connect=None, read=None, redirect=0, status=None)
DEBUG:urllib3.connectionpool:https://mybucket.s3.us-west-2.amazonaws.com:443 "GET /temp/data.parquet HTTP/1.1"<PHONE_NUMBER>
Traceback (most recent call last):
  File "print_parquet_metadata.py", line 28, in <module>
    df = pd.read_parquet(args.file, use_threads=True)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pandas/io/parquet.py", line 282, in read_parquet
    return impl.read(path, columns=columns, **kwargs)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pandas/io/parquet.py", line 129, in read
    **kwargs).to_pandas()
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pyarrow/parquet.py", line 1216, in read_table
    use_pandas_metadata=use_pandas_metadata)
  File "/Users/mtrbean/.pyenv/versions/stats3/lib/python3.6/site-packages/pyarrow/parquet.py", line 216, in read
    use_threads=use_threads)
  File "pyarrow/_parquet.pyx", line 1086, in pyarrow._parquet.ParquetReader.read_all
  File "pyarrow/error.pxi", line 87, in pyarrow.lib.check_status
pyarrow.lib.ArrowIOError: Unexpected end of stream: Page was smaller (26292) than expected (59582)

Please post/link to pyarrow too. s3fs does not do anything particular with threads, the S3FileObjects are independent instances, but S3FileSystem is a singleton (for given parameters) with shared state.

I don't think it's a problem with pyarrow per se, as it's always trying to read regions that do not have overlap. And reading a local file always succeeds, threading turned on or not. Below is my understanding of the issue, and apologies if I misunderstood anything:
If you read the lines starting with DEBUG:fsspec in the debug logs above, the parquet file is read in 5 chunks. The first chunk is 65536 bytes of metadata at 18606060 - 18671596 (which is at the end of the file), and then the following blocks in parallel when threading is turned on:

4 - 7237571
7237648 - 8274676
8274755 - 18176458
18176581 - 18670182

However s3fs.core:Fetch is pulling

(metadata) 18606060 - 23914476 <- beyond end of file but harmless
4 - 12480451
7237648 - 8274755
8274755 - 10485764   <- much less than the requested range
18176581 - 18606060  <- also less than the requested range, but the missing range 18606060 - 18670182 is already covered by the first metadata fetch (18606060 - 18671596)

which seems to suggest that s3fs.core:Fetch is confused about what is in cache and what is not. The range 10485765 - 18176458 was never downloaded.

I currently work around it by turning off threading in pyarrow, but I think the best way is to turn off caching. What is the best way to turn off fsspec’s caching? @martindurant

Yeah, I didn't at first realise that the same file instance was being shared across threads - that's not how I normally think about things from a Dask perspective.

What is the best way to turn off fsspec’s caching?

Yes, that's the conclusion I was coming to also. You can use open(.., cache_type='none') to make a file instance and pass that instead of the URL. There is no way to change the default (except monkey patching)

Should we expose default cache_type in the AbstractFileSystem? I'm happy to submit a PR to fsspec. Also happy to implement a threadsafe cache

Both of those sound reasonable.
Note on a threadsafe cache: I would still want the file instance to be pickleable, so presumably the cache in instances reconstituted by pickle would always have empty caches (unless they happen to be in the same thread?).

I decided to implement default cache_type in s3fs (PR #214 ).
However when working on the cache I found that currently MMapCache is not pickleable. I guess it needs to be fixed as well?

Good point.
https://github.com/intake/filesystem_spec/pull/99 does this, but cloudpickle only. Would be good not to have to use it, you might have a better idea.

If you don’t mind losing the cache content, you can try implementing  getstate and setstate

I think I'll park it there and see what people think. If you have a nice implementation, would be happy to see it, and indeed one for a threadsafe bytes cache. I don't know when I would get to this.

You know, I may even back away from saying that files should be pickleable, since we do have OpenFile after all, specifically for passing around things that are pickleable, but can be made into files with with.

Hello, do you have any updates on this issue ?

Apparently boto3 sessions are not thread-safe, but we have not come across this before, so maybe previously they accidentally were. Certainly, s3fs instances get shared, but this is not new behaviour. I do not have a good idea of how to produce thread-local boto sessions.


current is set to Window node after using OS window mode

Describe the bug
Maybe related to #171.
current variable of interactive shell is set to Window node when using OS window mode.
When this problem happens, the correct current node will be unavailable until current scene is switched, reloaded or the game is restarted.
(note)
I inserted print_debug and found that func _get_valid_root_nodes() -> Array in modules/variable_tracker/module.gd returned:
[@Window@36:<Window#172905991182>, Main:<Node3D#74255959313>, ...]
To Reproduce
Steps to reproduce the behavior:

launch game
open PankuConsole
open any tools in OS window mode
current node is set to Window node

Expected behavior
current should be same as current_scene of game
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Pro
Version: 23H2

Additional context

Thanks for report. If you need quick temporary solution right now, you can add 'Window' match to panku settings -> variable_tracker -> root_node_exceptions field. We will add os windows to exceptions by default in the future.


Maximum Bond of Life is not implemented

Maximum Bond of Life is not implemented.
What is the maximum value? I've seen 200% and 250% max HP, but did not find a source

fixed #2184


Feature: Add Filesystem and Database excludes as array

The possibility to add excludes as an array.
$config = new \PHPSu\Config\GlobalConfig();
$config->addFilesystem(...)
    ->addExcludes(['*.mp4', '*.mp3', '*.zip']);
$config->addAppInstance(...)
    ->addDatabase(...)
    ->addExcludes('table1', 'table2');

First version: https://github.com/phpsu/phpsu/pull/70
Second maybe better version: https://github.com/phpsu/phpsu/pull/71

I like #70 a lot more than #71. But the PR needs Tests so we can merge it.


[Docs] Missing "kubectl" in command

https://github.com/microsoft/retina/blob/735192eb444bcf4413019c4fe68378b43e30299f/docs/04-Captures/cli.md?plain=1#L9
This should read kubectl retina capture....

The Retina CLI can be invoked directly, it does not need to be kubectl plugin, so this would actually work. It is a bit confusing that all of the subsequent examples in this page invoke it as a plugin though. This should be explained and made consistent.

Yes, it should be unified to make it consistent.
And: When I download the tarball from the release, there is only a kubectl-retina binary in it, without further instructions. Moving that to a directory in my PATH means I can call kubectl retina ..., but not retina directly.
As this is the only command without kubectl, I would propose to stick to the usage with kubectl retina ....


Include code

Hi i'm working on a project and I'd like to use your model for it, so I'd like to know when do you estimate that the code and the pretrained checkpoints will be released?
Thanks for your incredible work it looks great hopefully I'll be able to try it soon.

Thanks for your question! The code and model will be released in June-July.

@nathankaha All the code and models are released. Have a try and don't hesitate to open an issue if you meet any problem.


Website text is unnecessarily and illegibly large on my mobile device

Website looks huge on my Nexus 9:

Makes it very hard to read.
It's also huge in portrait mode.
I can look into this and create a pull request if you agree this is an issue.

Thanks @mroch


Assume HTML in case there is no extension (e.g. for URLs)

Turns out a general solution is harder than I thought. As of now, I changed the default file type to HTML to fix #183.
Eventually we should revisit that and impl From<Url> for FileType as described in the FIXME.
https://github.com/lycheeverse/lychee/pull/217/files#diff-f3fcb4eeee8bd925542056f5ea55be80ef332b1c41fd746b30e0fc255813e8bfR35-R42

@pawroman fyi


maximum similarity to "a part of" the existing usernames

Hi @oplik0 ,
Instead of including all usernames, can we have an option to specify a list of usernames or group names?
We want to limit the usernames to the moderators and highly active users who are in specific groups(these users are added to these groups automatically by their post or reputation numbers)...
With the user base growing steadily, a very general approach is causing some issues. Could the plugin prompt us to input the usernames or group names to be checked for this rule? We can provide a list of usernames or, preferably, specify a group name for these members. This would be more efficient, especially since new active members are periodically added to these groups.
Thank you very much in advance.

Sure, I'll look into that in a few days (remind me if I don't add it or at least respond in like a week)

Added in 0.7.0 - the groups selection applies to similarity and the new phonetic filters, the rest work same way they did before.


SOLR-16429: Add AWS STS support in s3-repository

https://issues.apache.org/jira/browse/SOLR-16429

@joshsouza let me know what you think


What is the difference between Tag and Tags

What is the difference between Tag and Tags?
IMO, these can be merged into one class.

According to API,
Tags: get "multiple" tags
Tag: post, put and delete "one" tag

According to your response, Tags should be a container that can contain multiple Tags?
But that seems to only can has one tag information?

In fact, it can contain various tag information.
in some functions,  I use tags to search what I want, so it will seem to have on tag information in some conditions.

Why don't you just use Tag?


Added mode: BigClock

Added new symbols to signs.cpp with bigger, bolder numerals.
Added a new mode BigClock that displays the bolder numerals. This does not replace the existing clock mode.
Rebuilt the webgui to run on ESP32

Thank you!


UTF-8 Encoding troubles

When downloading a RIS file from scopus.com it looks like the python lib is not able to handle the file. Workaround is to convert the RIS file to good old ASCII and then problem is solved.
To repeat the error , just search scopus for anything and download 2000 records to RIS format and start the asr.
Error is:
"c:\users\hacke101\appdata\local\programs\python\python37\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 3613: character maps to

Thanks for bringing the issue to our attention.
Personally, I can't reproduce the error on OS X (I downloaded a random 2K line RIS file from scopus and it worked fine for me).
Could you provide a sample?

@qubixes Encoding is platform specific. This is a common issue with Python on Windows. I think I know the solution and I'm working on a fix with unit test.

I have tested the software on windows 10.  Attached a RIS file for reproducing the error.
scopus.ris.zip

This should be fixed with the latest commit. Feel free to reopen if this is not the case.


game crashes while using chart editor on 0.6 and onward

Describe your bug here.
every time i try to chart a song in the chart editor, after about 2-3 minutes, the game suddenly crashes. and if I save the json before the game crashes then try to play the chart, the game also crashes.
Command Prompt/Terminal logs (if existing)
Uncaught Error: Could not create thread
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

> Crash Handler written by: sqirra-rng

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No.

I've also been having this issue.

I can fix the chart crashing when played issue, check if it’s a .json or a “file”, if it’s “file” then add .json and it’ll work

Does it fix the fact that whenever I press a key, it has a chance of crashing?

BlazingDragonsYT

This is not the same problem, here you're missing notesplashes

Alright, I think I might have an idea. Are using a JSON from an older version? Are you using events?

no older versions, no events, the game just crashes after a while

Well, mine now only happens when I use a malformed event.


Presentation Mode not working in Safari

Hello,
Just me again... your friendly-neighborhood bug reporter ;)
It appears that Presentation Mode (aka Fullscreen mode) isn't working in Safari (at least not on MacOS).
I found this SO issue and it seems to apply: http://stackoverflow.com/questions/8427413/webkitrequestfullscreen-fails-when-passing-element-allow-keyboard-input-in-safar
Basically, if you drop Element.ALLOW_KEYBOARD_INPUT from the call to webkitRequestFullScreen it sort of works. E.g.
//this.container.webkitRequestFullScreen(Element.ALLOW_KEYBOARD_INPUT);
this.container.webkitRequestFullScreen();  // probably breaks Chrome, through.

I doesn't render well though… e.g. if the developer bar was open at the bottom when webkitRequestFullScreen is called, then there's a gap in the fullscreen view where the dev bar was.
Could we maybe hide the Presentation Mode in Safari until it can be rendered correctly?

Hi,
Safari on ipad 8.4.1 doesn't show fullscreen button on the demo page (https://mozilla.github.io/pdf.js/web/viewer.html) .
Is this problem solver or not?

If the button is not showing, then we have detected that presentation mode is not working and we have disabled it to avoid problems with browsers that do not (fully) support the Fullscreen API.

HI,
Facing same issue as mentioned by @abioneperhobby
Doesn't show fullscreen button on iPad and iPhone devices.
Same issue with https://github.com/kogmbh/ViewerJS.
Is there any possible solution for this issue?

This is not working (anymore) on newest Safari and iOS version. The button is not shown, and if I disable the check to show it there is nothing happening after I click on it.


TFlite fails to run on GPU with - ERROR: TfLiteGpuDelegate Prepare: No shader implementation for reduce_sum

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
tf-nightly from source
TensorFlow version (or github SHA if from source):
2.4 nightly

Provide the text output from tflite_convert
non conversion issue but run time on mobile GPU
INFO: Initialized TensorFlow Lite runtime.
INFO: Interpreter::UseNNAPI() is deprecated. Use tflite::NnApiDelegate() directly instead.
INFO: Created TensorFlow Lite delegate for GPU.
ERROR: TfLiteGpuDelegate Prepare: No shader implementation for reduce_sum
ERROR: Node number 51 (TfLiteGpuDelegate) failed to prepare.

tflite model attatched.
[MyModel2.zip](https://github.com/tensorflow/tensorflow/files/5657747/MyModel2.zip)

@shlomi-amitai
Please, share colab link or simple standalone code to reproduce the issue in our environment. It helps us in localizing the issue faster. Thanks!

@shlomi-amitai Can you share your inference code? The logs mention both NNAPI & GPU (TFLite usually works best with only one of the two delegates).
The "No shader implementation" log line is probably a bug. CC'ing @impjdi who might know more.

I couldn't spy which op triggers reduce_sum.  Can you pinpoint?

@shlomi-amitai Could you please try on latest stable version of tf 2.5 and let us know if this is still an issue.Thanks!

@shlomi-amitai Is this still relevant?


Services are not killed

I use moon 1.2.0. After some time there are services that were not removed (see screenshot above). For now I delete them time to time manually. Would be nice to clean up services automatically

@SergeyPirogov did you notice any OOMKilled pods? Could be related to #95.

Fixed in aandryashin/moon#164.


simp * at * does not preserve validity

Prerequisites

[x ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.

Specifially, check out the wishlist, open RFCs,
or feature requests.

Reduced the issue to a self-contained, reproducible test case.

Description
I just noticed something interesting, namely, that in contrast to other interactive variants of simp, simp * at * does not preserve validity. The first example below is the simplest illustration of what is going on, and the next two provide provable goals that are simplified into unprovable ones.
example (p q : Prop) (h₁ : p) (h₂ : p) : q :=
begin
  simp * at *
  -- p is replaced by 'true' in h₁ and h₂
end

example (a : ℕ) (h₁ : a < 1) (h₂ : a < 1) : a < 2 :=
begin
  simp * at *
  -- h₁ and h₂ become 'true' and the goal becomes unprovable
end

example (a b c d e : ℕ) (h₁ : a + 1 = 0) (h₂ : a + 1 = b) : false :=
begin
  -- injective h₁ solves the goal
  simp * at *
  --  now we only have '0 = b' and 'true' in the context
end

What is going on is that simp_all remembers all the previous versions of the hypotheses when they are used to simplify each other and the goal, but only keeps the final versions at the end. A weaker version of simp_all would only use the most recent version of each hypothesis at each step.
Is the current behavior desirable? I am willing to write the weaker one, e.g. for use in library_dev, if we want to keep the stronger behavior for simp * at *.

I am aware of this problem. The problem is that we currently do not have an efficient way of deleting a simp lemma from a simp set. This will be fixed after I implement the new data structure for storing simp lemmas.
The new data structure is needed anyway for other performance reasons.

Is the current behavior desirable?
No, it is not.

Very good. Feel free to close this issue, or leave it open, whichever is more useful to you.


Question about fundamental differences between postgrest-starter-kit vs subzero-starter-kit

Hi,
I just started to learn postgrest-starter-kit, subzero-starter-kit and jekirl/postgrest-starter-kit and I found that, even they more-or-less provide solution for the "same" problem, they provide different functionality and services when we look at the details.
If I am right, some basic differences are:

subzero-starter-kit focuses on using postgrest-plus in the background and provide tools for easy subzerocloud migration/support
postgrest-starter-kit is for open-source postgrest not as tightly boundled to subzero
jekirl/postgrest-starter-kit is a restructured and modified subzero-starter-kit
all-of-them basically based on docker
only subzero provides a logout function which deletes the cookie on the client using set-header function

Feature
subzero-*
postgrest-*
jekirl-*

postgrest

X
X

postgrest-plus (1 connection)
X

docker image all-included except pgsql
X

separate docker images for components (db, postgrest, rabbitmq, openresty)

X
X

supports cookies via set-header
X

provides logout function out of box by deleting cookie
X

Anything else, which should be important?
(I will extend this post as I will have more time)

The first major difference is that subzero-* (while the code in repo is MIT) uses the docker images from subzero which are commercial products.
Other notes:

jekirl-* seems to be a fork of the old postgrest starter kit, not seeing any "restructuring/improvements"
cookies-* can be used postgrest-* but the thing that makes them work in this context is the "cookie auto refresh" mechanism which is part of the subzero's commercial offering.
separate containers - there are separate containers for subzero-* also however a single container is a feature, not a weakness (easier to deploy, faster intercontainer communication )
subzero-* (through a combination of code in postgrest-plus and openresty) provides analytical queries (groupby, window functions), function call in select, graphql api and (upcomming) odata api.

that's a bird-eye view

Thank you, that explain what I experienced when I evaluated all the three variants.
From my point of view, docker is not an option, but it was really easy to test them and I can imagine the benefits of using them for those folks, who use docker as basis.
Thanks again!

docker is not the only option (after all it only wraps binaries configs and lua scripts) however it's much more tedious to setup

Sorry, my bad, I was not so careful when I wrote that.
So, I have different existing infrastructures where I plan to use postgrest-starter-kit, but without any docker related magic or subzero-cli. This is because I prefer the existing infrastructure, where I already have some of the stack components.
I really like this kind of stack (pgsql + postgrest + rabbitmq + openresty) and the way you bundled into a template in your commercial container with postgrest-plus and into an open source free psk.


[New Port Request] muparserx

Library name: muparserx
Library description: muparserx is a library for parsing mathematical expressions (extended version of "muparser").
Source repository URL: https://github.com/beltoforion/muparserx
Website: https://beltoforion.de/en/muparserx

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


linalg matrix norm

need a function to compute matrix norm and by default it should be Frobenius norm.
does this exist? assuming not, because linalg namespace isn't available yet.

Not yet. For a frobenius norm you can do:
mx.sqrt(mx.sum(mx.square(matrix)))
Other norms are more complicated.
Closing as dup of #24 which is being addressed in #187.  If there are specific norms you need other than Frobenius, feel free to file an issue for them.

I think the way the Mixtral model does quantization might solve this already. It operates only on shards (the non evaled arrays are never materialized.
Take a look you might be able to mostly reuse that as is. If you are up for giving that a go, that woud be awesome! If not, maybe we can find a way to include your changes (when not quantizing) and o/w load the full model.


CVE-2007-4559 Patch

Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

I doubt this is an issue. Noone uses this project for that. I bet this is only used localy with full control by the user. Exploitability is extremely low.


Dev cc docker

Addressing shortfalls in the Dockerfile that were encountered when building the image within a different environment (Ubuntu 18.04 vs Mac)

FYI @arose


Any way to specify additional ECR registries to log in to?

I'm trying to sm-docker build a container derived from SageMaker Scikit-Learn framework container in ap-southeast-1, something like the following:
base_docker_uri = sagemaker.image_uris.retrieve(
    sagemaker.sklearn.defaults.SKLEARN_NAME,
    smsess.boto_region_name,
    version="0.23-1",
    instance_type="ml.m5.xlarge",
)
#<PHONE_NUMBER>41.dkr.ecr.ap-southeast-1.amazonaws.com/sagemaker-scikit-learn:0.23-1-cpu-py3

...so Dockerfile is FROM<PHONE_NUMBER>41.dkr....etc
Seems like the CLI tool spins up successfully and logs in to a load of other ECR registries, but not<PHONE_NUMBER>41: Then fails on step 1 with:
[Container] 2021/04/20 02:54:22 Running command docker build -t $IMAGE_REPO_NAME:$IMAGE_TAG .
Sending build context to Docker daemon   7.68kB
Step 1/2 : FROM<PHONE_NUMBER>41.dkr.ecr.ap-southeast-1.amazonaws.com/sagemaker-scikit-learn:0.23-1-cpu-py3
Get https://121021644041.dkr.ecr.ap-southeast-1.amazonaws.com/v2/sagemaker-scikit-learn/manifests/0.23-1-cpu-py3: no basic auth credentials

[Container] 2021/04/20 02:54:22 Command did not exit successfully docker build -t $IMAGE_REPO_NAME:$IMAGE_TAG . exit status 1

I've since tested and on a SageMaker Notebook Instance I can build the same Dockerfile fine, so long as I log in to the<PHONE_NUMBER>41 ECR first.
From a cursory look at the job logs and #12, it looks like the current strategy is to have the tool ecr login to every AWS account on which AWS DLCs are provided?
...So would the correct fix be to add every account Id listed here to support SKLearn?
I was thinking it might be preferable to also add a way for users to indicate extra required account IDs through the CLI, since:

This list is going to start getting pretty long
(Like in #12 and this issue) I guess there might always be some gaps introducing bugs
In some rarer cases, I guess users might have private cross-account ECR needs too?

Thanks for the detailed write-up.
Agreed that the preferable approach would be to not require logging into each and every ECR registry. Your suggestion of adding a registry-id parameter  works, however we could make this seamless by auto-detecting the base ECR registry and region and logging into it. Here's how that could work

Read the provided Dockerfile from disk and extract the FROM statement
If the FROM is an ECR repository, then extract the registry ID, region, and partition
Log into the detected ECR registry in the right region and partition.

Yeah auto-detection was my first thought & preference too - but then wondered if there might still be some edge cases a naïve implementation could miss... E.g. there could be multi-stage builds with multiple FROM statements (which should be easy enough to handle), or maybe there are use cases where it's not obvious from the Dockerfile at all which registri(es) are needed? I don't know enough to rule it out.

The underlying tenet of this library is that is works out of the box without requiring any additional inputs over a regular docker build . This works by setting sensible defaults for underlying AWS resources like S3 and CodeBuild.
There may well be edge-cases,  but if we can handle 80% of the use-cases with auto-detection then that is default behavior to go with, while allowing power users to specify additional, optional fields to override the defaults.

Is there any work around for this problem?
I'm trying to run the following dockerfile https://github.com/aws/amazon-sagemaker-examples/blob/master/training/distributed_training/tensorflow/data_parallel/maskrcnn/Dockerfile

I get the same error when I try to build an image based on this FROM statement.
FROM<PHONE_NUMBER>78.dkr.ecr.us-east-1.amazonaws.com/sagemaker-xgboost:1.2-1
I thought the account<PHONE_NUMBER>78 was logged in with the following command, but what could be the cause or workaround?
Running command $(aws ecr get-login --no-include-email --region $AWS_DEFAULT_REGION --registry-ids<PHONE_NUMBER>78)


[hmac/rtl,dv] Signal SW error at invalid HMAC configuration

This PR implements support in the RTL to signal an error to SW when HMAC is triggered to start with an invalid configuration, namely: invalid/unsupported digest size, unsupported key length when keyed HMAC is enabled, or 1024-bit key for SHA-2 256 when keyed HMAC is enabled. This also adds preliminary DV support in the smoke tests to check that the error is successfully signaled and HMAC is indeed not started, and the digest CSRs are not updated.
This would close https://github.com/lowRISC/opentitan/issues/22312.
Once this is in, we would need to update the DIFs respectively (captured in the open DIFs issue already), as well as the documentation and programmer's guide with more detail on what defines a valid/invalid configuration.
In a followup PR, I would incorporate the digest comparison checks for the new digest sizes and key lengths.

@andreaskurth @martin-velay my last forced push addresses your comments and tests different invalid configurations successfully. The vectors tests only test SHA-2 256 with 256-bit key for now; but changes for testing other modes would come in follow-up PRs. This only fails at linting in CI but it's an issue at Microsoft's end, all changes pass Verible linting locally. Do we go ahead and merge?


[Bug] Navigating search result image previews with arrow keys runs out of results

Repro:

Image Search, perform search with large number of results
Click image to open preview
Use arrow keys to move through results
Eventually the results end and cannot continue moving with arrow keys, but if you close the preview it jumps to the current page and there are more results

Seems like the loading of additional pages of results fails when navigating from inside the image preview.  Occurs in both the default layout and the "Experimental Side-by-Side Layout".

This issue has been fixed.


Support for Guzzle 7.0.1

Please add support for Guzzle 7.0.1

I made a PR here: #18

Any update on this issue?

Same with me. current guzzle version is 7.2.0

+1
require digitonic/iex-cloud-sdk fails as it conflicts with root composer.json require (^7.0.1).


eth-tester[pyethereum16] filter 'toBlock' is exclusive

Version: eth-tester==0.1.0b21
Python: 3.6
OS: osx

What was wrong?
I'm not sure where to report this best, but as it happens on a eth-tester based chain I think this is a good place.
The issue is that creating a filter with the toBlockparameter set to a block number behaves differently when eth-tester with the pyethereum1.6 backend than with geth.
Geth's toBlock is inclusive while the eth-tester filter excludes it. Even though this is a backend related problem this should probably be handled by eth-tester or the backend plugins and tested.
How can it be fixed?
Handle filter behaviour and test that toBlock is inclusive.

Since all filtering logic is handled locally in eth-tester this is likely as simple as changing some comparisons from < to <= and updating some tests.

just ran into the same issue. i should have some time early next week to take a stab at this.

@pipermerriam @carver
i've had a look at that and i don't think it's in eth tester:
# eth_tester/utils/filters.py
114      elif is_integer(to_block):
115        return is_integer(block_number) and block_number <= to_block

after some detours since i failed to replicate my issue (infura, Geth/v1.8.3-patched-cad76670/linux-amd64/go1.9.2) i upgraded web3 and happened to run into this:
>>> from web3 import Web3, EthereumTesterProvider
>>> from eth_tester.backends import PyEthereum16Backend
>>> w3 = Web3(EthereumTesterProvider(PyEthereum16Backend))
>>> w3.isConnected()
True
>>> w3.eth.accounts
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/eth.py", line 105, in accounts
    return self.web3.manager.request_blocking("eth_accounts", [])
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/manager.py", line 103, in request_blocking
    response = self._make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/manager.py", line 86, in _make_request
    return request_func(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/gas_price_strategy.py", line 18, in middleware
    return make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/formatting.py", line 23, in middleware
    response = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/attrdict.py", line 18, in middleware
    response = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/formatting.py", line 23, in middleware
    response = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/normalize_errors.py", line 9, in middleware
    result = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/validation.py", line 46, in middleware
    return make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/formatting.py", line 23, in middleware
    response = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/providers/eth_tester/middleware.py", line 322, in middleware
    return make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/fixture.py", line 12, in middleware
    return make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/middleware/formatting.py", line 23, in middleware
    response = make_request(method, params)
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/providers/eth_tester/main.py", line 46, in make_request
    response = delegator(self.ethereum_tester, params)
  File "cytoolz/functoolz.pyx", line 236, in cytoolz.functoolz.curry.__call__
  File "cytoolz/functoolz.pyx", line 232, in cytoolz.functoolz.curry.__call__
  File "/Users/93501/localDev/source-code/forks/web3.py/web3/providers/eth_tester/defaults.py", line 36, in call_eth_tester
    return getattr(eth_tester, fn_name)(*fn_args, **fn_kwargs)
  File "/Users/93501/.virtualenvs/web3-4.1/lib/python3.6/site-packages/eth_utils/functional.py", line 22, in inner
    return callback(fn(*args, **kwargs))
TypeError: get_accounts() missing 1 required positional argument: 'self'
>>> w3.version.api
'4.1.0'
>>>

this maybe due to a version incompatibility with the 4.10 dev install:
py-evm]==0.1.0-beta.23->web3==4.1.0)
**py-evm 0.2.0a14 has requirement eth-tester==0.1.0b21, but you'll have eth-tester 0.1.0b23 which is incompatible.

but i doubt it.
regardless, i started to look at the backend but ran out of time. i'm out of pocket for a couple days but should be able to re-engage wednesday.

it's been working for me. i'm certainly willing to look some more but i'd need more info to be able to recreate the issue. in my case, i probably forgot to press the return key in one of the terminals.

Closing since pyethereum is no longer maintained.


zar prototype

For anyone who wants to try this out, see https://github.com/brimsec/zq/blob/master/cmd/zar/README.md. If you do happen to give it a test drive and have any feedback or questions, come talk to us on the Brim public Slack. We'd be interested in discussing your log archive use cases.


Proposal: Add a CLI option that allows filtering tests by Jest environment

🚀 Feature Proposal
Add a CLI option that allows filtering tests by Jest environment
Motivation
Jest environments are handy for optimizing tests that only need certain resources, e.g. jsdom or not. We also use custom environments that are further configured in jest-setup.js to automatically mock or unmock things depending on the active environment. Typically tests in a node environment will run relatively fast, while those in a jsdom environment will run relatively slowly; we also make a distinction between normal tests, and full integration tests where almost nothing is mocked. It would be nice to be able to run these logically grouped tests independently, without requiring some duplicative method of identifying the tests like a special file name or path convention.
Example
Users may use named environments to provide different resources for a test, using the test environment comment convention. e.g. :
/**
 * @jest-environment jest-env-integration
 */

Pitch
This gives developers an easy way to group tests using a naming convention and logical division that is already supported by jest, without requiring some other mechanism to divide the tests such as locating them in a different folder or naming the files differently.

We don't currently keep that information. We look at the source code when we wanna execute the test, and fall back to the environment defined in config if the environment is not in a docblock. To implement this, we would have to stick in the hastemap I think
Current way of doing it is to have it in the file name and use different projects with different testMatches. Is that bot enough for you?
/cc @rickhanlonii @thymikee

We do it that way now (we have a filename convention), but they can become out of sync easily, and you might not notice for a long time that something is misnamed. It would just be nice to not have that duplication & maintenance effort.


License

Could you please pick a license for the project and add it to the repo? Thanks!

Cargo.toml and README.md says this is licensed under the MIT license. All that's needed is the inclusion of the license text in a LICENSE file.


feat(bump): Support workspace protocol in release and bump tools

Summary
This PR encompasses three major changes:

Adds a config setting to control the default interdependency ranges for release groups.
Refactors the bump-related functions into set functions.
Adds support for the workspace protocol.

Default interdependency range setting
Adds a configuration setting to release groups that controls their interdependency range type. This is a companion change to #15158 and similar changes. That change (and related changes) allowed setting explicit range types in the CI pipeline and used that capability to release builds with ~ interdependencies.
On the other hand, this change adds a setting to the fluid-build configuration that is then used as a default in relevant places rather than the ^ default that was there previously. With this change, the flub release and related commands will use the configured interdependency range type unless one is passed as an argument.
I introduced a couple of new types to help consolidate disparate string union types. I also took this opportunity to deprecate and replace the poorly named exactDepType flag. It's been replaced by the interdependencyRange flag, a name which we use throughout the code to refer to this concept.
Refactoring bump and version handling
The existing code mixed determining the version to set with setting the version. This led to unwieldy 'bump' functions that have been refactored or in some cases removed. The primary replacement functions are setVersion and setPackageDependencies.
setVersion can be used to set a package or release group to a particular version. It properly reads the default config setting described above and has parameters that can be used to override the defaults. Once it determines the correct interdependency ranges, it calls setPackageDependencies to set the interdependencies across the release group.
The bumpReleaseGroup function was refactored to call setVersion. It may be removed in a future PR.
Workspace protocol support
The workspace protocol enables pnpm to always link the workspace version of a package. It also enables pnpm to help enforce that versions are consistent between interdependent packages.
Because of our custom version schemes, we use custom bump and version tools. I've updated these tools to partially understand the workspace protocol. The bump command's interdependencyRange flag can be set to values like workspace:^, enabling us to set workspace ranges in CI and elsewhere.
Fixes AB#3422.
Examples
These examples can be run on the FluidFramework repo (with the changes in this PR applied, of course).
Sets the version of the build-tools release group to 0.16.0, and use "workspace:*" for dependencies on other packages within the workspace.
flub bump build-tools --exact 0.16.0 -d "workspace:*"

Bumps the client release group to the next minor version using the default interdependency range configured for the client release group in the fluidBuild config file.
flub bump client -t minor

Other changes

Removed the unused packageVersion files from all the build-tools packages. They were unused.

Breaking changes
BREAKING CHANGE: The --exactDepType flag in the bump command no longer has a default value. It has also been deprecated. It has been replaced by the --interdependencyType flag. The deprecated flag will be removed in an upcoming release.

Thanks for the review, @RishhiB and @zhenmichael!


Multi app with modules for each

Laravel Version: 5.5
PHP Version: 7.1
Database Driver & Version:

Description:
I'm looking for a solution where i can produce multiple applications or modules under the same laravel installation. For Example, my project consists of a search directory where users can find nearby professionals and businesses, a community system like flarum, a erp tool and a social network.
In yii2 framework we have a common folder(shared resources), backend folder (for administration), frontend folder(customer facing). Each folder represents a application. We can create modules in each app for our features. Or we could clone frontend to make a new app. For example, clone frontend folder and rename it to community and adjust config and aliases. This results in a multi app. Each app has a modules folder inside to add features as modules.
And a rbac for the project to handle roles and permissions for all the folders(appplications)
I have moved to laravel as i feel more complex things could be achieved with it and also i want to use a javascript like vuejs for the frontend. All i'm confused right now is with the structure of laravel. I have gone through few articles like pingpong modules, multi tenancy, multi site and other. But i didn't find an answer.
Does anyone know how i could achieve a architecture as mentioned above in yii2 framework which makes the job easy for me. I know laravel is a different framework and im not comparing it to yii2. But i feel if that can be achieved in yii2, it should also be achieved in laravel. And the best way to learn things is by trying instead of giving up on laravel and moving back to yii2.
So any tutorials, links or suggestions will really help me kickstart my project.

This is no bug, go look in forums.
You may take a look at:
https://github.com/nWidart/laravel-modules
https://github.com/apiato/apiato
Do not forget to close this issue, since it is no issue.

Thanks. Ill give it a try


Unexpected JSON error when installing a new project

🐞 Bug report
Command (mark with an x)

- [X] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
Used to work but I'm not sure what version it used to work on.
Description
 A clear and concise description of the problem...
When I try to install my project, installation fails with the folliowing error:

npm ERR! Unexpected end of JSON input while parsing near '...mon-6.0.0-beta.8.tg z"'
Package install failed, see above.

🔬 Minimal Reproduction
Just trying to install a new project should do it I think. I don't really understand how all of this works so I can't say for sure.
🔥 Exception or Error
2216 verbose stack SyntaxError: Unexpected end of JSON input while parsing near '...mon-6.0.0-beta.8.tgz"'
2216 verbose stack     at JSON.parse ()
2216 verbose stack     at parseJson (C:\Program Files\nodejs\node_modules\npm\node_modules\json-parse-better-errors\index.js:7:17)
2216 verbose stack     at consumeBody.call.then.buffer (C:\Program Files\nodejs\node_modules\npm\node_modules\node-fetch-npm\src\body.js:96:50)
2216 verbose stack     at process.internalTickCallback (internal/process/next_tick.js:77:7)

🌍 Your Environment
Angular CLI: 7.1.4
Node: 11.6.0
OS: win32 x64
Angular:
...                                                                                Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.11.4
@angular-devkit/core         7.1.4
@angular-devkit/schematics   7.1.4
@schematics/angular          7.1.4
@schematics/update           0.11.4
rxjs                         6.3.3
typescript                   3.1.6

Anything else relevant?
Probably not.

This seems like a problem with your node/npm and not with Angular CLI.
Please have a look at the fixing npm permissions page, common errors page, npm issue tracker, or open a new issue in that issue tracker if the problem you are experiencing isn't known.

Yeah because node just breaks randomly one day with no changes made to the system that its on...


Add release_arm64.go

Adds a release_arm64.go file referencing OCP's 4.10.18 images for ARM.
Closes USHIFT-118
Signed-off-by: Frank A. Zdarsky<EMAIL_ADDRESS>

I tested this and looks like only kubevirt/hostpath is doesn't built for arm  (https://quay.io/repository/kubevirt/hostpath-provisioner?tab=tags) and cause issue.
$ sudo crictl ps
CONTAINER           IMAGE                                                                                CREATED             STATE               NAME                    ATTEMPT             POD ID
dbc6681689bb7       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2d8319a33aa781918a3173e2061635d8534cc5e4a39171775830ff7e2ce646ac   5 minutes ago       Running             kube-rbac-proxy         0                   72ffa57412819
085c75ac10e3f       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2619cbcbc5ea990bd8349848d410cc4040aea0265821b9d1e46b364f0519481b   5 minutes ago       Running             dns                     0                   72ffa57412819
ee9632ac6affb       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:972f3fadc1b7eab2eaa02eff4128149eabe9577943dcb3e56f44dad7fc14059e   6 minutes ago       Running             router                  0                   d1b09e7d9cb49
d9addc705ca0a       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:97a7d56ac6d6a38f7977b0759bb1b97fe3895e6020364e60a8a2926f3fd0084e   6 minutes ago       Running             service-ca-controller   0                   ac7f3f8fcbecb
ef43f2132469c       85fc911ceba5a5a5e43a7c613738b2d6c0a14dad541b1577cdc6f921c16f5b75                                                         6 minutes ago       Running             kube-flannel            0                   0ada7b07c4c34
2a242c7ce73ce       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:65889fde898f3025462f1344bd93e4a1d8ae5a764224b61b4f0b7e46cc1108e4   6 minutes ago       Running             dns-node-resolver       0                   fc71ab554175f

$ sudo crictl logs eef0c827c5828
exec /hostpath-provisioner: exec format error

I tested this and looks like only kubevirt/hostpath is doesn't built for arm (https://quay.io/repository/kubevirt/hostpath-provisioner?tab=tags) and cause issue.
$ sudo crictl ps
CONTAINER           IMAGE                                                                                CREATED             STATE               NAME                    ATTEMPT             POD ID
dbc6681689bb7       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2d8319a33aa781918a3173e2061635d8534cc5e4a39171775830ff7e2ce646ac   5 minutes ago       Running             kube-rbac-proxy         0                   72ffa57412819
085c75ac10e3f       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2619cbcbc5ea990bd8349848d410cc4040aea0265821b9d1e46b364f0519481b   5 minutes ago       Running             dns                     0                   72ffa57412819
ee9632ac6affb       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:972f3fadc1b7eab2eaa02eff4128149eabe9577943dcb3e56f44dad7fc14059e   6 minutes ago       Running             router                  0                   d1b09e7d9cb49
d9addc705ca0a       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:97a7d56ac6d6a38f7977b0759bb1b97fe3895e6020364e60a8a2926f3fd0084e   6 minutes ago       Running             service-ca-controller   0                   ac7f3f8fcbecb
ef43f2132469c       85fc911ceba5a5a5e43a7c613738b2d6c0a14dad541b1577cdc6f921c16f5b75                                                         6 minutes ago       Running             kube-flannel            0                   0ada7b07c4c34
2a242c7ce73ce       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:65889fde898f3025462f1344bd93e4a1d8ae5a764224b61b4f0b7e46cc1108e4   6 minutes ago       Running             dns-node-resolver       0                   fc71ab554175f

$ sudo crictl logs eef0c827c5828
exec /hostpath-provisioner: exec format error

Yes, this patch is only for arm64. While ARM32 is possible for the product version we are focusing on arm64 so far. This is likely to change when we focus on a new community release once all the productization work is finished.

I tested this and looks like only kubevirt/hostpath is doesn't built for arm (https://quay.io/repository/kubevirt/hostpath-provisioner?tab=tags) and cause issue.
$ sudo crictl ps
CONTAINER           IMAGE                                                                                CREATED             STATE               NAME                    ATTEMPT             POD ID
dbc6681689bb7       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2d8319a33aa781918a3173e2061635d8534cc5e4a39171775830ff7e2ce646ac   5 minutes ago       Running             kube-rbac-proxy         0                   72ffa57412819
085c75ac10e3f       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:2619cbcbc5ea990bd8349848d410cc4040aea0265821b9d1e46b364f0519481b   5 minutes ago       Running             dns                     0                   72ffa57412819
ee9632ac6affb       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:972f3fadc1b7eab2eaa02eff4128149eabe9577943dcb3e56f44dad7fc14059e   6 minutes ago       Running             router                  0                   d1b09e7d9cb49
d9addc705ca0a       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:97a7d56ac6d6a38f7977b0759bb1b97fe3895e6020364e60a8a2926f3fd0084e   6 minutes ago       Running             service-ca-controller   0                   ac7f3f8fcbecb
ef43f2132469c       85fc911ceba5a5a5e43a7c613738b2d6c0a14dad541b1577cdc6f921c16f5b75                                                         6 minutes ago       Running             kube-flannel            0                   0ada7b07c4c34
2a242c7ce73ce       quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:65889fde898f3025462f1344bd93e4a1d8ae5a764224b61b4f0b7e46cc1108e4   6 minutes ago       Running             dns-node-resolver       0                   fc71ab554175f

$ sudo crictl logs eef0c827c5828
exec /hostpath-provisioner: exec format error

Yes, this patch is only for arm64. While ARM32 is possible for the product version we are focusing on arm64 so far. This is likely to change when we focus on a new community release once all the productization work is finished.

@mangelajo Yes I meant arm64 only but the hostpath-provisioner image is not built for arm64, need to check with that team if they can also build multi arch image and push it to quay.

/lgtm
/approve


Add support for PHP 8.4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.65%. Comparing base (8ed49d7) to head (8c49447).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #9      +/-   ##
============================================
+ Coverage     89.09%   89.65%   +0.56%
  Complexity       22       22
============================================
  Files             2        2
  Lines            55       58       +3
============================================
+ Hits             49       52       +3
  Misses            6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


update the look of the definition list

Looks like that some of these fixes have also been addressed in #499 , we should double check the differences.
On which specific issues is related this PR?

#499 is an issue that mentions some of these changes. So this fixes #499, and perhaps others. Merging this should close #499

thanks. yeah, some of these ui changes came from just messing around on the fly and weren't fully thought through. I was hoping to address any feedback about the look or feel here in this PR thread.
There are some structure changes here that still need to be reflected in the e2e tests

actually, looking into this more, the maps are fine the way they are structured. pretty cool.
Any feedback on the way this looks/feels?
browse
fullDetail


Please advice: how to POST and accept empty reponse of 204 status?

I have the followng code, which stays as pending requiest until timeout error is thrown:
fetch(`/api/users/logout?access_token=${token}`, {
        //body: null,
        credentials: 'include',
        method: 'post',
        headers: {
          'Accept': 'application/json, application/xml, text/plain, text/html, *.*',
          'Content-Type': 'application/x-www-form-urlencoded; charset=utf-8'
        },
      })
      .then(response => {
        console.log('Test!'); // It will get here only after a huge timeout, not right after request
        if (response.status === 200) return response.json();
        return response.json();
      })

So issue is that I can't make this request really work - it does not get to then() part unless i wait few minutes.Please, advice!

It seems likely that the API your calling is just really slow.  Have you tried making the same call with another library?  Or perhaps with curl?  At first glance this doesn't look like a problem with isomorphic-fetch.


Fix deserialization error with IdTokenAttestation scope property

Problem:
IdTokenAttestation scope property did not deserialize as expected
Solution:
Fix bug in populateFrom function and amend unit test to ensure correct deserialization
Validation:
Unit test was fixed
Type of change:

[ ] Feature work
[x] Bug fix
[ ] Documentation
[ ] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk:

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.
Documentation Links:
Please include here links to any related background documentation for this PR.

wrong pull


Properly document local installation methods

Cloning locally and:
pip install .

(plus -e if desired).

Resolved with the release of v1.0.0.


Unable to reference libraries on an iASP

Code for IBM i version 2.13.5 - clean installation on new installation of VS Code 1.94.2
Steps to reproduce:

Create new connection
Add a library on an iASP to the library list
Or
Create a filter in the object browser using a library on an iASP

Error message 'Library  does not exist' will be displayed.
I have tried setting the 'Source ASP' setting on the 'Source Code' settings tab but this does not have any impact. I do have access to QSYS2.ASP_INFO.
There does not appear to be any other way to try and specify an iASP on the connection properties.
Please note - developers on our site do not have *SECADM rights and cannot change their profile's job description so cannot set the iASP with this method.

@StuBramley You should take a look at the "Help and Support" section of the documentation. There are a couple of things you can do to help the maintainers.

I tried but can't use the 'Report an Issue' tool unfortunately.. the software is running in a Citrix environment and the server cannot access the internet. Happy to try and gather any information manually that will help..

Sadly it's been this way for a little while. For now, the only way to make VS Code understand iASP is to set it at the user profile level.


Clear field meta data during reading so that it can be processed

This PR aims to demonstrate the issue described in LanceDB/lance#2947, where a dataset containing a nested field with associated metadata can be written successfully but cannot be read correctly by Lance.
In this PR, I propose a quick fix that clears the field metadata when reading from the manifest. However, this approach doesn't seem to be a perfect solution to the issue. I also attempted to remove the field metadata right before the decode method’s StructArray::try_new call, but there appear to be multiple places with similar issues, so I opted to clear the metadata once when reading the field from the manifest instead.
It would be great if we have better solution to this issue. Thanks.

Codecov Report
Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (681db8c) to head (363e55d).

Files with missing lines
Patch %
Lines

rust/lance/src/dataset.rs
98.48%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2949      +/-   ##
==========================================
+ Coverage   78.99%   79.01%   +0.02%
==========================================
  Files         234      234
  Lines       72822    72890      +68
  Branches    72822    72890      +68
==========================================
+ Hits        57525    57596      +71
+ Misses      12332    12325       -7
- Partials     2965     2969       +4

Flag
Coverage Δ

unittests
79.01% <98.57%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Close this PR in favor of https://github.com/lancedb/lance/pull/2950


Consider splitting IRequestHandler<TRequest, TResponse> into two interfaces

Generic abstractions are often defined for architectural artefacts. This means that everything that belongs to the same architectural concept, should typically be placed behind that same abstraction. This makes code really clean and gives some sort of 'architectural domain language' to communicate between developers.
In my opinion, commands and queries are two completely different concept. Commands mutate state and don't return data. Queries return data, but don't return state. This makes it really useful to make this strict separation in code with the interfaces as well.
Another way to look at this is from the view point of cross-cutting concerns. Those generic abstractions are usually the place where cross-cutting concerns are applied. This project defines decorators around IRequestHandler<,> to apply cross-cutting concerns. But commands and queries both often require a different set of cross-cutting concerns. Queries need caching and performance measuring, while commands need transaction handling, validation, handling of business rules, deadlock retry handling, audit trailing and deduplication. Letting commands and queries share the same generic abstraction means that most decorators need to be applied conditionally (which increases complexity and is impossible to achieve with most DI containers and Pure DI), or the conditional checks need to be implemented inside the decorator itself (which is ugly).
So from both an architectural and practical point of view, it is wise to consider splitting the IRequestHandler<TRequest, TResponse> interface into an ICommandHandler<TCommand> and IQueryHandler<TQuery, TResult> interface.

In my previous projects I used the ICommandHandler<TCommand> and IQueryHandler<TQuery, TResult> interfaces and currently I am using IRequestHandler<TRequest, TResponse> interface.
Obviously the big advantage is that you have a common interface, that's why we're using Command Oriented Interface and applying decorated commands. Indeed the re-usability isn't that big between command and query decorators. Like always it's a trade-off....
Initially I hesitated to show the sample solution through ICommandHandler<TCommand> and IQueryHandler<TQuery, TResult> or IRequestHandler<TRequest, TResponse>.
I know we shouldn't do it, but there are some cases (due to legacy, constraints, ...) that a command need to return data. In that case I like more the approach of IRequestHandler<TRequest, TResponse> because it still cleanly separates the request and the response. Otherwise you need to do something similar like you mention here. In that case from a signature point of view it's not clear that the command returns data, whether the IRequestHandler<TRequest, TResponse> interface is always very explicit about that, can be a Unit or a generated response id.

I really wished I hadn't written this article, but I admitted my mistake and added a read note at the start of the article to make that clear.
At least you are well aware of the downsides of having a single interface and are making a very explicit trade-off, considering you're building on top of a legacy system.

Speaking of legacy systems, I think Oracle spoiled everyone with Update Returning Into. Its too tempting to not have one query instead of 2!
I have the same thing for same reasons! :laughing:

What was the resolution?

I am still in favor of having a common interface and that in some circumstances you need to return data from a command.
What I do to make it more explicit is by decorating the request through an attribute (Command or Query).
[Command]
public record CreateNewTask : IRequest<Unit>
{
   public Guid TodoId { get; init; }
   public string Title { get; init; }
}

[Query]
public record GetTodoDetail : IRequest<TodoDetailModel>
{
    public Guid TodoId { get; init; }
}

That way you can also filter out some decorators that are specific to a command, for example Transaction.
But also reuse decorators like logging and validation despite Command or  Query.
if (request.GetType().IsCommand())
{
    using (var scope = new TransactionScope(TransactionScopeOption.Required)
    {
        var response = await next();
        scope.Complete();
        return response;
    }
}
else
{
    return await next();
}

I updated the sample to illustrate this.


Check product names

The old official product names ("Aiven Kafka" etc) were changed to the new ("Aiven for Apache Kafka") sometime in 2020. When transferring (or editing) content, check that product names follow the new format and the conventions as specified here: https://docs.google.com/document/d/1PklbdRuxSUycQ2vtSkYfdZZY7MokdR-sGkQYcZnzr-E/edit?usp=sharing
NOTE: M3 is the only product new enough to only have a new format name.

Thanks @aposous are there any obvious misuses we should look out for? I can for example add "Aiven Kafka" to the reject word list, what else?

We should also reject "Aiven for Kafka" - and I'm not sure we can do word rejects but we should be able to create Vale rules if not.


Fee estimation on shelley wallet when tx amt > available balance takes much longer time

Context
Observed by @alan-mcnicholas on Daedalus Windows on shelley testnet. I am also able to observe on Linux, however the difference in time is not so siginficant.
While fee estimation of normal transaction takes 2-4 seconds, when we try to estimate tx that amt > utxo the estimation takes even 13s after it reaches not_enough_money.

Information
-

Version
Daedalus / 2020.7.6 (git revision: f1a0511f58f70e33c143aa567f36b549d2aeb01a)

Platform
Windows / Linux

Installation
Daedalus / from source

Steps to Reproduce

Run fee estimation endpoint with amount > wallet's utxo.

Expected behavior
time should be more or less the same as when estimating regular transaction.
Actual behavior
Fee estimation time is twice, three times as long.

Resolution

QA

duplicate of: https://github.com/input-output-hk/cardano-wallet/issues/2006

No longer observed.


Removed Bouncing Animation for to-do title

I have removed the animation styling in style.css, so the "To-Do's" bouncing animation has been stopped.
Description
This commit removes the bouncing animation from the .subtitle class in the CSS file. The animation was found to be unnecessary for the overall user experience and has been eliminated to provide a cleaner and more consistent interface. This change enhances the readability of the subtitle without the distraction of animation effects.

I have removed the animation styling in style.css, so the "To-Do's" bouncing animation has been stopped.


Add customise order feature

Add customise order command
Add tests for the CustomiseCommand and CustomiseCommandParser classes
customise order p/ t/ a/ e/ now works
customise order a/ also works (autofill the remaining missing attributes in the default order)

Codecov Report
Base: 60.18% // Head: 59.18% // Decreases project coverage by -1.00% :warning:

Coverage data is based on head (7f2fcbe) compared to base (c30e488).
Patch coverage: 41.40% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     60.18%   59.18%   -1.01%
- Complexity      404      425      +21
============================================
  Files            81       83       +2
  Lines          1497     1612     +115
  Branches        162      185      +23
============================================
+ Hits            901      954      +53
- Misses          559      604      +45
- Partials         37       54      +17

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
80.00% <0.00%> (-4.22%)
:arrow_down:

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <0.00%> (ø)

...u/address/logic/parser/CustomiseCommandParser.java
46.80% <46.80%> (ø)

...n/java/seedu/address/commons/core/GuiSettings.java
74.19% <55.55%> (+4.96%)
:arrow_up:

...seedu/address/logic/commands/CustomiseCommand.java
78.78% <78.78%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM! But I think the Codecov Report is warning us about the decrease in project coverage (code not tested)?


add some more beasts to the Animals pack

including new emoji
:columbian-mammoth: :dodo: :emu: :platypus: :sabre-tooth-tiger: :wildebeest: :wooly-mammoth: :zebra: :arctic-fox: :desert-fox: :festive-reindeer: :great-auk: :great-owl: :hawk: :moa: :moose: :reindeer-crash: :reindeer-harness: :beluga-whale: :blue-whale: :grey-seal: :humpback-whale: :killer-whale: :narwhal2: :raccoon: :robot-dog: :robot-scorpion: :robot-shark: :coyote:

happy emoji


BigQuery: Partitioning by field attribute in Table class missing

I need to create a table in Bigquery partitioned by a specific field. I have noticed that this is only available via API Rest.
The class missing the attribute in the Python API is: google.cloud.bigquery.table.Table.
In the REST Reference the time partitioning attributes are defined as:
"timePartitioning": {
    "type": string,
    "expirationMs": long,
    "field": string,
    "requirePartitionFilter": boolean
  }

A new attribute to define the field named field above will be required

PR #5267 added support for time partitioning.  That feature was released in bigquery-1.2.0.
See the docs for Table.time_partitioning


Empty URL causes imagefetcher to except

While it's probably correct for it to do so, issueidentifer then fails on get_issue_cover_match_score. I've put this fix in but maybe another solution is better?
Index: comictaggerlib/issueidentifier.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/comictaggerlib/issueidentifier.py b/comictaggerlib/issueidentifier.py
--- a/comictaggerlib/issueidentifier.py	(revision 04ad588a58a5085a4b3cb9918fa2306742479c6d)
+++ b/comictaggerlib/issueidentifier.py	(date<PHONE_NUMBER>903)
@@ -251,6 +251,10 @@
         # local_cover_hash_list is a list of pre-calculated hashes.
         # use_remote_alternates - indicates to use alternate covers from CV

+        # If there is no URL return 0
+        if not primary_img_url:
+            return Score(score=0, url="", hash=0)
+
         try:
             url_image_data = ImageFetcher().fetch(primary_thumb_url, blocking=True)
         except ImageFetcherException as e:

Context?
What causes this?

If a comic has no image URL ii will still try to hash it. It's an edge case that a comic won't have a cover image but is still possible.

Make a PR and I'll merge it


It looks like the icon "dialogue list" always has a notification

Describe the bug
The icon to open the dialogue list always has a blue circle. This missleads users to think they have unread messages.
Expected behavior
The blue cirle should only be shown when there is unread messages.
Additional context
I know this is not a technical fault. But UX wise, it is a faulty design.
Also it is likely to raise our bounce rate as it frustrates first time users. They think they should click on this icon, but when they do, nothing happens and they get even more confused.

Solved! no message = no counter


Master

:)

Hi @phuocle,
wow, thanks a lot :)
I'll deploy this to my development environment tomorrow and give it a spin.
When it works without issues, I'll publish an update asap.
Kind Regards,
Florian

working on Dashboard. Will send PR soon.

@phuocle
Is this PR in here not already done? What will be contained in the new PR?

@phuocle
I tested it and it works as expected, thanks a lot :)
Released as v3.5.0.


Get send/receive to work with AWX 8.0.0 and JT credentials

Yanked the JT code from https://github.com/ansible/tower-cli/pull/610
This is so that the tower_send and tower_receive modules become self-consistent (creates the data it receives) for the AWX collection version 8.0.0+

Now replaces https://github.com/ansible/tower-cli/pull/734/commits as well.

Coverage decreased (-0.3%) to 64.139% when pulling 8822729d92885fe54fd7dada810d995a4ec1b1fa on AlanCoding:to_the_future into d764b3b4a19b9f4a88706b1a2c9c442eb7a05f62 on ansible:master.


Can i use it on windows platform?

Can i use it on windows platform?

I don't think this can be done. Not sure though


Add in feedback export

Add in ability to export the results from a feedback form into xls format, possible with some sort of date range as well

@atoff Moved to medium following a request for this feature.


Release 4.1.0

Approving, but don't forget to regenerate the matrix!

I remembered, but just hadn't pushed it.


Adds Matthew Podwysocki to streamers list

Adds Matthew Podwysocki to the list including what I stream and my links

@mblayman fixed!


deploy.ps1 error

Hi all,
There is an issue in the deply.ps1 file. It is using outdated and unsupported parameters when creating the app.
On line number 204 & 217 there is a command:
az ad app create --display-name $appName --available-to-other-tenants $MultiTenant --oauth2-allow-implicit-flow $AllowImplicitFlow
This needs to be be changed to:
az ad app create --display-name $appName --sign-in-audience AzureADMultipleOrgs

Hi @Hennericho ,
Thanks for the suggestion. We will look into the inputs suggested and verify it from our end. Then will do the necessary

@Hennericho To avoid errors during deployment, we recommend using Azure CLI version 2.30.0. In future releases, we will address the highlighted issue and provide support for the latest Azure CLI version, which in turn utilizes the latest parameters.


Possible to export minimum spanning tree cluster x-y coordinates?

The ability to export minimum spanning tree cluster spatial coordinates along with event would be useful for doing analysis and gating on the spanning tree in 3rd party applications.  Similar to the 'export cell coordinates' option for the force directed layouts.

@AndyinMission  - Barring the addition of such a capability to vortex, knowing your an R adept, I recommend you re-layout the vortex clusters in R using igraph's force directed layout, which will probably yield results most similar to the org.gephi.layout.plugin.forceAtlas2.ForceAtlas2 used in this project, and from which you can obtain the graphical coordinates to feed to your 3rd party application.

Thanks @malcook .  But it's actually the minimum spanning tree functionality that I want to export node coordinates for.  The force directed layout already allows this straight from vortex.

Perhaps re-do both the MST and the layout???  The MST part should be deterministic, so the result should be the same as Vortex' version....

Have you tried exporting it as GraphML and then redoing the layout in Gephi
or Cytoscape or R?
Let me know if this might work
Nikolay
On Mon, Oct 23, 2017 at 11:36 AM Malcolm Cook<EMAIL_ADDRESS>wrote:

Perhaps re-do both the MST and the layout??? The MST part should be
deterministic, so the result should be the same as Vortex' version....
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nolanlab/vortex/issues/5#issuecomment-338755621, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADacL6ZFZMYEzO4fI54tfzF9o1MdDoowks5svNyugaJpZM4NubnU
.

--
Nikolay

This message is intended for the named addressee(s) only. It may contain
privileged and confidential information and protected by a copyright. Any
disclosure, copying or distribution of this message is prohibited and may
be unlawful. If you are not the intended recipient, please destroy this
message and notify me immediately. Thank you for your cooperation.

Thanks @nsamusik , however I'm not seeing 'export as graphML' option for the MST, only for the force directed graphs.  MST graphing only shows 'export images' and 'save as pdf' options.

Aah, OK sorry yes - let me add it then
On Mon, Oct 23, 2017 at 11:49 AM Andrew Box<EMAIL_ADDRESS>wrote:

Thanks @nsamusik https://github.com/nsamusik , however I'm not seeing
'export as graphML' option for the MST, only for the force directed graphs.
MST graphing only shows 'export images' and 'save as pdf' options.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nolanlab/vortex/issues/5#issuecomment-338759413, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADacLw0lGUuZmGrvzlRP3yqOPvaHwQy4ks5svN-5gaJpZM4NubnU
.

--
Nikolay

This message is intended for the named addressee(s) only. It may contain
privileged and confidential information and protected by a copyright. Any
disclosure, copying or distribution of this message is prohibited and may
be unlawful. If you are not the intended recipient, please destroy this
message and notify me immediately. Thank you for your cooperation.

That's @nsamusik  excellent, thanks!


Add meta info as new attribute _meta to TickerBase

Meta information is returned by Yahoo anyway and can for example be used
to check the currency of the data retuerned. Like so:
from yfinance import ticker
msft = ticker.Ticker("MSFT")
hist = msft.history()
print(msft._meta["currency"])

See also https://github.com/ranaroussi/yfinance/issues/1195

Needs polish. Some quick initial thoughts:

variable name needs to clearly indicate this is price metadata not e..g earnings
why default to {} instead of None?
needs documenting in README, and maybe a property accessor in ticker.py

Touch base with @fredrik-corneliusson , seems he's implemented as well. #1197

Variable name: How is this just price metadata? Looks like general metadata to me. So _meta seems a fair name. It's also called meta in the returned data dict. – If you don't agree, please suggest concrete name.
{} default: Because it's a dictionary. Similary, _expirations is defaulted to {} and _news to [].
README: Happy to add once we have alignment on 1, 2, 4.
Had a quick review of #1197, but that looks like a significant refactoring with uncertain deadline. Please chime in @fredrik-corneliusson if there is a clear timeline there.

I suppose it's more exchange metadata than prices - currentTradingPeriod, exchangeTimezoneName. Word "metadata" on it's own needs context - meta of what data? And to better distinguish against info[] which is also a form of general stock/company metadata.
Ok
Deadline irrelevant here, implementations take however long they need, get merged when good enough. Point is it's implementing same feature request.

@ymyke I made the PR before I saw you also made one, in retrospect and with @ValueRaider comments on that PR I think that mine can be scrapped.
I agree with @ValueRaider that it probably need a public accessor if it is supposed to be an official part of the API as accessing a private property ("_meta") is not something a consumer of the API is supposed to do.
I would suggest if the meta value is accessed and no history has been fetched a suitable  exception with message should be raised instead of just empty dict or None.
Regarding the naming, the API is already quite a handful, and careful naming of any new properties is needed.
The method that sets the metadata is named history, maybe "history_metadata" would make it clear what produced it?

Alright, thanks for the discussion. I'll work some more on it. Accessor makes sense and I'll add one.
Open questions:

Naming: Either exchange_metadata or history_metatadata. I'd go with the former (exchange_metadata). → Agree?
Behavior if history() not called yet.
a. Raise exception: I don't like that because none of the other accessors behave that way.
b. Just return {}. Works, in line with other accessors. Con: User needs to have implicit knowledge that an empty dict can mean either "no metadata available" or "no retrieval done yet".
c. Call history() to make sure the metadata gets called and stored. Also the approach by some of the other accessors, however, there it's usually with really history-related data. Here, we'd call history() to retrieve something not history-related. Pro: Somewhat clearer behavior from user's perspective. Con: Call to history() feels like a strange side effect; takes time; potential to override earlier history results that were retrieved with different parameters.
→ I'd go with b. WDYT?

Meta question, help please: My original PR was for main rather than dev. I simply changed that online to dev via Github GUI. But now I need to continue working on it. What is the best way to proceed to work on right files locally? Should I better start off with a new PR?

Meta Q - backup your code folder then try git rebase dev on your branch (remember to pull dev first). Should work here. Then verify by viewing diff of backed-up-branch vs main, and comparing against diff of rebased-branch vs dev.

Either is fine
I would probably want a way to differ missing metadata because of history not called or if the metadata was actually returned as empty. Making it return None instead of a empty dict would make it more obvious.  Either way I think it would be nice if accessing the property before it is set by a history call shows a warning message so that users will not be fooled that metadata is missing for ticker .

Regarding None vs {}:

{} default: Because it's a dictionary. Similary, _expirations is defaulted to {} and _news to [].

In both these cases they are not returned directly but accessing them via the public API will trigger requests to get the actual data first.
Note: In Python variables starting with underscore is considered private and not public:
https://docs.python.org/3/tutorial/classes.html#private-variables

Looking at the code some more, I'd reconsider the "no history behavior". Cf get_dividends, get_splits, get_capital_gains, etc. – they all get the history if it hasn't been retrieved yet. Example:
    def get_dividends(self, proxy=None):
        if self._history is None:
            self.history(period="max", proxy=proxy)
        if self._history is not None and "Dividends" in self._history:
            dividends = self._history["Dividends"]
            return dividends[dividends != 0]
        return []

So, even though the exchange metadata is not part of the history key, it at least gets retrieved together with the history and I therefore suggest to go down that route, which would be option 2c above.
WDYT, @ValueRaider @fredrik-corneliusson ?

I wasn't around when get_dividends and get_splits were implemented, but I think they are terrible functions . Reasons: What if user called history(interval="1m") before? What if user wants different period?
So implement meta independently, however seems best. If you want to fetch history if None,  use period=1d.

Got it, thanks. 👍

Closing, see #1235.


Mass Entry of Categories and Subcategories

Body of the issue
I have a list of categories and subcategories to go with the categories. Is there a means of mass entering this information? If so, how?

You can use the import tool in the admin center of platform ui for that. Then simply select the csv,excel,... table where you have all your categories and map the columns accordingly.

I don't know if that will work. I go to the Admin Center and find IMPORTER, select Data import rows, and it comes up with "Select data import row to change". This opens a box supposedly where you enter whatever data, but how does the program know where the data is supposed to go? I have a separate user name that I have for using InvenTree and I can't pull up my Libre Office Calc spreadsheet I have saved to a USB drive from my main user name. The USB drive won't download the file I have. Any suggestions along those lines?

You can create a file like:
name,description
Electronics,Electronic parts
Mechanics,Mechanical parts

And upload it here (https://your-server/platform/settings/admin/import), and select "Part Category" as model type.

I actually thought that something like this works, but after trying, I found out that this does not work. This is maybe a missing feature, e.g. see #7574 .
pk,name,parent
0,Electronic Parts,
1,Passives,0
2,Resistors,1
3,Capacitors,1
4,IC,0
5,Mechanic Parts,

@SchrodingersGat any thoughts, is this supposed to work already, or can't I reference currently importing rows by their index or a separate pk column?

Here is my list.  And as far as the path given by https://your-server/platform/settings/admin/import I don't know what that means for my OS. I guess that means hand entry for now?

@wolflu05 using the exact same data as you pasted above, here are my results:

Obviously 0 is not a valid database ID, but there was a matching category for ID 1.
Note that further work will allow "natural key" import - i.e. lookup based on other fields such as "name" (etc): https://github.com/inventree/InvenTree/issues/7574

That doesn't look anything like my data, and so I don't know what you are trying to show. That looks like a previous posting and doesn't make any sense to me. Thanks for replying.

@LarryJoy To clarify, the post from SchrodingersGat was a reply to my comment from above.
I was thinking you could use the importer to import a tree of categories in mass, but was not sure why my testing was not working with some simple sample data like I expected it.
He now confirmed (he as a better understanding of the importer as he has developed it) that referencing importing rows (to build the tree - all levels at once) is not possible and will not be solved by #7574. So this is not really the solution to your problem currently as this is the essential part of your request.
The only thing which is currently possible is to import the categories "level by level" or by just creating them manually.