float field may lead to binlog player append data inconsistent

during a binlog player running, if binlog_format=row and a table has float filed, update or delete operation may lead to data inconsistent,  for example  table t has float filed f;
create table t(id int, f float);
a delete operation on source shard: delete from t where id = 1;
binlog_format is row,then  a sql genetate by binlog streamer like this:  delete from t where id = 1 and f=3.14;
the float filed f=3.14 in destination shard can't match any row. We can't use  compare equal on float value.   the same as update operation.
binlog_format=statement is ok.

Looking into this, this is a real issue. I don't have any idea on how to fix it. Any idea, anyone?
(well the long term plan we may have is as follows: instead of connecting to MySQL and converting RBR events into SQL and sending them, we configure MySQL to connect to the local vttablet as a slave and send the events as is. That way we don't have to print the fields as SQL, they can just stay binary. That's a big change).

I discussed this with @alainjobart. For the short term, we're thinking of changing the player to update by primary key. Of course, this will make it vulnerable to on-the-fly schema changes, but it's better than the current behavior.

Another workaround is to use the:
binlog_row_image=minimal
MySQL option. When doing so, MySQL will only use the primary key to identify rows (or a unique index). I'm assuming your float columns are not part of the primary key? Then Vitess will only use what MySQL gives to identify the columns, and not the float columns.
See:
https://dev.mysql.com/doc/refman/5.7/en/replication-options-binary-log.html#sysvar_binlog_row_image

Now, I just skip the float and double field, and  other fileds reserved.
Why we can not  use  '>' and '<' compare float field，for example f is 3.14, rewrite where condition : where f >3.139 and f < 3.141 .

In that case 3.14 and 3.1401 would be considered equal

yes, but there still primary key  and other filed in where condition， just a  compromise.

I think a primary-key based update will cover all the common use cases, maybe even all. This is because we don't expect you to apply schema changes during a resharding process. I believe the current process requires you to independently deploy schema changes on source and target tablets, and then resume filtered replication.


Add HttpRefererFilter to HTTP section

Library URI: https://github.com/GabrielJMJ/HttpRefererFilter

Thanks for the suggestion.


"Cannot read property 'sha' of undefined" when nothing to merge

Hi, and thanks for this GitHub Action which is great!
We just started using it in our repository. We use it to merge fixes from stable branches into our development branches automatically.
We got this error which happened where there was nothing to merge between two branches:
Error: An unexpected error occurred: Cannot read property 'sha' of undefined

Is there a way to handle this edge case?

Hi Paul,
Let me check this and I'll get back to you.

Yes, I'll be updating the action to better handle non-success cases.
New version should be available tomorrow.

Wow, awesome! I'll be glad to test and give feedback.

A 2.0 version of the action has been published.
Hope that it will resolve the problems that had emerged so far.
And of course, any feedback is very welcome.

Very much appreciated, thanks a lot.
We'll upgrade our dependencies and let you know.

Confirming that the new version works well 👍
Thanks again!

You're welcome and thank you for the update.


Maintainer Wanted

A number of people have opened issues on this repository asking why it has been deprecated (since there is not any information about this in the README etc) and why certain portions of the live app (backend) do not work anymore. Answer: I let the hosting for the database expire (though I have a dump of all the data) because I no longer have the time to maintain this project the way I wish I could.
However, this provides a good opportunity for the community, as I'm looking for a maintainer to step in! If I could give someone worthy, write-access to the repository so they can build it up again and update all the dependencies etc that would be a huge help. If anyone is interested in contributing please let me know via email<EMAIL_ADDRESS>or comment on this issue and I'd be happy to talk to you. Submitting a PR to update the application's dependencies and make it work with all the new jazz would be a great first step :)

Might be nice to merge this with https://github.com/DavideViolante/Angular-Full-Stack as it is being maintained and uses the latest dependencies. I can port the passport openAuthWindow stuff etc - what are your thoughts?

Hmm that sounds like a pretty good plan I think, if you would like to head up the initiative on that, it would be much appreciated!

I'd be willing to take up maintainership for this project. My company is looking to use this project, I'm a core team member of the popular node-fetch package since the very first besinning and takes care of a number of other popular open source project.
I know a thing or two about open source and making sure it's harmful and well documented and safe
That being said, I have had a fascination of getting things modernized. My motivations are not to prioritize the needs of my company over the needs of the community. Looking through the issues, I think that I could help with answering the questions people have or looking into (and potentially fixing) the problems that are presented.
If it's alright with you then I would like to get full maintainership of npm package and that the github is transfered to my account along with all the issues/PR that comes with it
Just let me know 👍

Much appreciated @jimmywarting. Regarding:

Submitting a PR to update the application's dependencies and make it work with all the new jazz would be a great first step :)

If you wouldn't mind starting all of this over here before we consider a transfer or some kind, that would be great.


Implemented functions to control the volume of the video being played.

Need the ability to control volume and thought I could save someone else some time while I was at it.

Thank you for the contribution!


Error while running the pipeline - [Error: Process completed with exit code 1.]

I get the following traceback when running Sourcery-CLI on my repository

Hey @vishrutkmr7! Thanks for reporting this issue - no one else has reported it yet!
Can you clarify a couple of things, please?

does this happen in CI (for instance, using the Sourcery GitHub Action), or locally by running sourcery review <...>, or in both?
what Sourcery version are you using? You can check that by running sourcery --version.
do you have a piece of code that I could use to reproduce your issue?

This is happening only on the GitHub action and not locally
sourcery, version 0.12.9
I've been using it on my public repository My Leetcode Submissions

Hi @vishrutkmr7, I've just had a look at this and I've been able to reproduce it -- you can actually get the same result locally by using the --verbose flag while running sourcery review.
This is a bug in our core engine, so we'll work towards a fix for the root cause in the next release.
For a quick fix, I'd suggest setting verbose: false in the sourcery.yml file for your action, like this:
name: Check codebase using Sourcery

on:
  workflow_run:
    workflows: [Sync Leetcode]
    types:
      - completed
  push:
    branches: [main]

jobs:
  review-with-sourcery:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3

      - uses: actions/setup-python@v4
        with:
          python-version: "3.10"

      - uses: sourcery-ai/action@v1
        with:
          token: ${{ secrets.SOURCERY_TOKEN }}
          verbose: false

This should bypass the verbose output and allow Sourcery to exit successfully.

@bm424 I implemented the change to the pipeline, it does go through the refactoring process. Although, its exit still isn't graceful, as seen in the screenshot below

Hi @vishrutkmr7 glad that fixed the crash.
The exit code is the default behaviour if it finds issues - you can switch it off via the check option:
https://github.com/marketplace/actions/sourcery-action#check

Also I have just merged a fix for the original issue - should be in our next release.

I think we can close this issue?

Hi, @vishrutkmr7!
You're right. I'll close this issue as completed since all issues reported seem to have been fixed. Please don't refrain from reporting any other problems you have while using Sourcery :smile:


Add pickier checks on SPDX license expression on client, fixes #916

Check that only valid characters are included in
a SPDX license expression on the client.
This isn't a rigorous check, but it eliminates some nonsense.
This commit only checks on the client side (using HTML5 patterns);
we don't need to do more, because invalid SPDX license expressions
aren't a security vulnerability.  Instead, we simply want to
make it a little harder to enter data that is clearly nonsense.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

I think it's pretty easy to add a migration that fixes the data. Though I'm
not volunteering.
--
Dan Kohn<EMAIL_ADDRESS>Executive Director, Cloud Native Computing Foundation https://cncf.io/
tel:+1-415-233-1000
On Thu, Aug 17, 2017 at 5:18 PM, David A. Wheeler<EMAIL_ADDRESS>wrote:

@david-a-wheeler commented on this pull request.
In app/views/projects/_form_0.html.erb
https://github.com/coreinfrastructure/best-practices-badge/pull/918#discussion_r133831827
:

                          class: 'form-control', hide_label: true,

                        pattern: '(|[()A-Za-z0-9\-.+ ]*)',

Yes, I know, I even documented that in the commit comment. I don't think
it's all that critical to implement more model validation in this case. It
can't be a security vulnerability, and implementing serious license
expression validation is way more effort (because it's a context-free
grammar).
We can add it as a model validation, it's not too hard to add. There is a
complication: There are existing records that don't meet it (which is
why I added this function). That's kind of a pain to deal with.
Because of the existing records, I think I'd rather start by checking just
on the web page, and let people fix them as they go. We can then add a
model validator once a lot of the data has been fixed up.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/coreinfrastructure/best-practices-badge/pull/918#discussion_r133831827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC8MBsqTRRdYuTgUk4k3WeXEZKnuwAYHks5sZK4tgaJpZM4O6paE
.

It is definitely not easy to add a migration.
Running this SQL query:

select id,left(name,20),license from projects where license !~ '^(|[()A-Za-z0-9-.+ ]*)$';

Produces 12 results:

id
left
license

628
dpkg
GPL-2.0+, GPL-2.0, BSD-3-Clause

675
User mode file syste
LGPL-3.0, MIT

306
~/bin/
GPL-2.0+, Beerware-modified

212
photon
https://github.com/vmware/photon/blob/master/NOTICE

1037
NetSurf Browser
BSD-3-Clause, GPLv2-Only

164
OPNFV
Apache 2.0 For mer info please visit:: https://wiki.opnfv.org/display/DEV/Licensing+in+OPNFV

725
Gitano
BSD-3-Clause, CC-BY-SA-4.0

765
yoctoproject
All metadata is MIT licensed unless otherwise stated. ref: http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/LICENSE

137
esapi-java-legacy
BSD-3-Clause, documentation released under Creative Commons BY-SA licenses (both 2.0 and 3.0, depending on when authored).

286
Blender
GNU GPL 2 and 3, Apache 2.0

307
LibreOffice
Binaries under MPL-2.0, code contributions under MPL-2.0 and LGPL-3.0+

437
GNU Image Manipulation...
GPL-3.0+, LGPL-3.0+

Figuring out the details of each license is complicated; to create a migration we'd rather to grovel through the license statements to figure them out.  I'd much rather let the project tell us (they're more likely to know).
So again, I would like to start with just a client-side check to prevent further bleeding now, and hopefully it will get some of our current projects to clean it up over time.  After a while there will hopefully be fewer projects that need fixing, and then we can fix the rest and add a model validation.

OK.
--
Dan Kohn<EMAIL_ADDRESS>Executive Director, Cloud Native Computing Foundation https://cncf.io/
tel:+1-415-233-1000
On Thu, Aug 17, 2017 at 6:20 PM, David A. Wheeler<EMAIL_ADDRESS>wrote:

It is definitely not easy to add a migration.
Running this SQL query:
select id,left(name,20),license from projects where license !~
'^(|[()A-Za-z0-9-.+ ]*)$';
Produces 12 results:
id left license
628 dpkg GPL-2.0+, GPL-2.0, BSD-3-Clause
675 User mode file syste LGPL-3.0, MIT
306 ~/bin/ GPL-2.0+, Beerware-modified
212 photon https://github.com/vmware/photon/blob/master/NOTICE
1037 NetSurf Browser BSD-3-Clause, GPLv2-Only
164 OPNFV Apache 2.0 For mer info please visit:: https://wiki.opnfv.org/
display/DEV/Licensing+in+OPNFV
725 Gitano BSD-3-Clause, CC-BY-SA-4.0
765 yoctoproject All metadata is MIT licensed unless otherwise stated.
ref: http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/LICENSE
137 esapi-java-legacy BSD-3-Clause, documentation released under Creative
Commons BY-SA licenses (both 2.0 and 3.0, depending on when authored).
286 Blender GNU GPL 2 and 3, Apache 2.0
307 LibreOffice Binaries under MPL-2.0, code contributions under MPL-2.0
and LGPL-3.0+
437 GNU Image Manipulation... GPL-3.0+, LGPL-3.0+
Figuring out the details of each license is complicated; to create a
migration we'd rather to grovel through the license statements to figure
them out. I'd much rather let the project tell us (they're more likely to
know).
So again, I would like to start with just a client-side check to
prevent further bleeding now, and hopefully it will get some of our
current projects to clean it up over time. After a while there will
hopefully be fewer projects that need fixing, and then we can fix the rest
and add a model validation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/coreinfrastructure/best-practices-badge/pull/918#issuecomment-323210121,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC8MBpgUn3mSVvM0cHxiArzIG09KJVPoks5sZLzGgaJpZM4O6paE
.

My amazing plan: Let's pull this, and I'll add a separate issue to create a migration.  But I think we'll need to wait a little while before implementing the migration; we need to know what the data should be, and in these cases it's tricky.  I'd much rather let the projects tell us what the licenses are, instead of trying to be a lawyer and figure it out.


Add Thelia CMS

[x] verified that the CMS I'm adding is still maintained.
[x] read CONTRIBUTING.md.
[ ] did not generate README.md.

Thanks, @gillesbourgeat! Manually merged in this commit.


Bump TCA to 0.18.0

@stephencelis you're right, this isn't necessary.
We recently started using both TCA & CCL. In some modules we cannot link TCA, only CCL b/c it already exports TCA with it. We're not version locking our dependencies, and I was seeing some funky behavior, so my initial thought was that maybe SPM is mistakingly importing a wrong version of TCA (declared in CCL). Fortunately, this is not the case, as SPM correctly resolves the main TCA package version.


some refactor and change in UDWF

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] others

Problem Summary(Required) ：

use windowUpdate instead of batchUpdate
use finalize instead of getValues
use Analytic instead of isAnalytic when create function
some refactor to clean up code

run starrocks_fe_unittest

run starrocks_fe_unittest


Add IaaS ops files to bare

This adds the IaaS related ops files to the things that are ignored when bare is specified.
This is the least that should be done. Discussing with some others, it might be worth just excluding these all together. Allow them to be specified specifically as with other ops files.
I invite discussion and alternative solutions from the community.

This has been implemented in a slightly different way, but used this as guidance.  Thank you for your contribution.

This has already been resolved - thanks.


Describe roadmap/plan/why this is better

Why have you forked Erubis? What's missing? What are the planned improvements?

Erubis is not maintained anymore and we will provide capture support on the ERB level at some point. Does that help? :beers:

Yeh.


NETOBSERV-1451: Bump ubi 9.3 / go 1.21

Description

Dependencies

n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[x] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
[x] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[ ] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[x] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Is it time to make go1.21 is the required ci test instead of 1.20?

@msherif1234 we can do it as soon as the PRs are approved

/approve


Snappied RStudio deploy

What

Removed delay after clicking "Deploy", user is redirected straight away
Show the non-deployed RStudio tool in the table of tools
When RStudio is not deployed show the "Deploy" button as an action
After the user click on "Deploy" we set rstudio_is_deploying in the
session so we show "Deploying" in its status and we hide the "Deploy"
button

NOTE
This is based on the ag-tool-model branch at the moment which is under review here.
Ticket
https://trello.com/c/ZLa2RCfo/569-2-remove-2-second-delay-from-deploy-r-studio

@andyhd Do you want to have a look at this but then I'll merge these PR with the other one to avoid conflicts, etc?


Ruby plugins are deprecated :( :( :(

$ heroku surrogate run-cool-stuff
WARNING: https://github.com/tpope/heroku-surrogate is a deprecated Ruby plugin
WARNING: Check to see if there is a version of this plugin using the new Node.js Heroku CLI

Heroku is mad this plugin is written in Ruby instead of Javascript. Will there ever be a version of this plugin that does not make Heroku mad? I am worried they will stop letting me use it soon. :sob:

@indirect you may be interested in my heroku-run-local plugin, which is very similar to heroku-surrogate.

@uhoh-itsmaciek oh awesome, you just saved me from implementing this tonight after work 😅


Issues tab not showing correctly

We have an issues tab for an application that shows the current list of open issues on GitHub. Here is my current list of issues for the HTAP Demo:

The problem is that on open exchange this appears like this:

Thanks, Amir!
Is it a mobile device?
вт, 14 янв. 2020 г. в 23:41, Amir Samary<EMAIL_ADDRESS>
We have an issues tab for an application that shows the current list of
open issues on GitHub. Here is my current list of issues for the HTAP Demo:
[image: image]
https://user-images.githubusercontent.com/6372644/72380816-3225c180-36e4-11ea-9996-7ea005bcdcab.png
The problem is that on open exchange this appears like this:
[image: image]
https://user-images.githubusercontent.com/6372644/72380830-3d78ed00-36e4-11ea-88d8-b912d6cf3db1.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/intersystems-community/openexchange/issues/100?email_source=notifications&email_token=AAVHEP36STFLDFEVJYLX4JLQ5YPN5A5CNFSM4KGZHOU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGFMAHQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVHEP6TAALKGQ6KPKJU2DTQ5YPN5ANCNFSM4KGZHOUQ
.

Got it, thanks. Will be fixed in next release

No. It’s Safari, on my Mac.

On Jan 14, 2020, at 3:45 PM, Evgeny Shvarov<EMAIL_ADDRESS>wrote:
Thanks, Amir!
Is it a mobile device?
вт, 14 янв. 2020 г. в 23:41, Amir Samary<EMAIL_ADDRESS>
We have an issues tab for an application that shows the current list of
open issues on GitHub. Here is my current list of issues for the HTAP Demo:
[image: image]
https://user-images.githubusercontent.com/6372644/72380816-3225c180-36e4-11ea-9996-7ea005bcdcab.png
The problem is that on open exchange this appears like this:
[image: image]
https://user-images.githubusercontent.com/6372644/72380830-3d78ed00-36e4-11ea-88d8-b912d6cf3db1.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/intersystems-community/openexchange/issues/100?email_source=notifications&email_token=AAVHEP36STFLDFEVJYLX4JLQ5YPN5A5CNFSM4KGZHOU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IGFMAHQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVHEP6TAALKGQ6KPKJU2DTQ5YPN5ANCNFSM4KGZHOUQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/intersystems-community/openexchange/issues/100?email_source=notifications&email_token=ABQT2JFDDEJ5ZK6KOAVAHSDQ5YP5XA5CNFSM4KGZHOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI6B7NQ#issuecomment-574365622, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQT2JCPFQXIXYSRMWYMOT3Q5YP5XANCNFSM4KGZHOUQ.


Articles rail

[x] Started on Relay stuff for articles
[x] Basic Article component
[x] Figure out best way syntactically to render a possibly large array of articles into a horizontal ScrollView
[x] Polish UI

Figure out best way syntactically to render a possibly large array of articles into a horizontal ScrollView

Should probably first figure out if there will ever be a lot of articles, otherwise you might end-up optimising prematurely. Like, what’s the artist that currently has the most associated articles and how many are those?

What's the fastest way to find out which artist has the most articles?

Nevermind, the warning disappeared. Maybe my syntax is correct after all!

What's the fastest way to find out which artist has the most articles?

I’m not sure, maybe that data is available in Looker? Maybe ask Ani in #analytics-help.

@alloy ready for review

🍏

Aight!


Expanded - Refactor authorization

This builds on #92, #93 and resolves #24
@smellsblue I think this covers off all your feedback - thanks!
This PR contains:

Iteration on @smellsblue's work on the Authorization refactor
protected_fetch (default false) in Gemstash::Configuration
Configuration of protected_fetch via $ gemstash setup
A new fetch permission for Authorization
Authentication via HTTP Basic Auth (token as username) to support gem, bundler and uri based auth in Gemfiles
Docs to suit.

@smellsblue if this is acceptable I'll do the serve_gem and serve_marshal methods in a similar way and stick them in this PR too.

@smellsblue Pending any further feedback, this should be good to go


Tomba! 2 - The Evil Swine Return (USA) and Other Anti-Modchip Games Trigger Protection

On previous versions and the latest one (1.2.1) Tomba! 2 boots but triggers the anti-modchip protection. I'm not familiar with how the games detect modchips, I suppose since this is a softmod it has to be checking memory somewhere.
On an older version I also had this happen to Aconcagua (Japan). I have been able to boot both games on a softmodded PS2 via the PSX Launch program, so I don't believe they also have libcrypt but I am not entirely sure.
As with the last issue I opened, let me know if my BIOS version would help. It is one of the small white psone models (US).

libcrypt and antimodchip are two different beasts. The former requires properly writing the subchannel data to disc, which is doable. The later however checks for the presence and/or absence of the SCEx string, which is something that can't be replicated nor I can from tonyhax emulate.
tonyhax can't do anything regarding this, other than patching the game's executable on a case by case basis to disable it, something I am not against but would require considerable work.

Well that was easy. Tomba 2! booting is supported in d3b4930a919f420945dc311ddcb79e31048af4f8.
tonyhax will automagically patch this game at boot so that the antipiracy check is completely skipped.

Just wanted to say thanks for the quick fix and adding a framework in for other patches! I tested Tomba 2 a bit ago and it works great now.


Set interactiveConsent to true by default for native apps

Previously we were setting "cookie" to "includeCookie" which corresponds to whether or not we dropped a cookie, and not to the "interactiveConsent" flag (https://github.com/microsoft/pxt/pull/7494/files#diff-8957ba59dbfacd963c66897334cdb7040d8a10b172f100090eb857c2e7e28245L22)
We could revert to this behavior (set cookie directly equal to "isProduction" here: https://github.com/microsoft/pxt/blob/master/docfiles/pxtweb/cookieCompliance.ts#L220), but I think it's more correct to automatically set "interactiveConsent" to true for native apps (since we automatically trust them).
@abchatra thoughts?

Probably we need to discuss with @Jaqster I like new behavior but unfortunately it causes issue with the consistency with legacy metrics.

@abchatra actually, better idea--we can keep the cookie behavior as it was before, since i think we do still need some kind of flag for discarding forked editor ticks, and add a new custom metric that is "interactiveConsent" = true (or some more descriptive name), for if we want to filter on this new metric?

@shakao that sounds good. I though @riknoll had a interactiveconset as  a new tick just for this.

Yes I do remember adding that

okay so here is the updated behavior:

cookie = true if "includeCookie" is true (anywhere we request that the cookie be dropped, regardless of the "interactiveConsent" flag)
interacted = true (<- can rename this) if cookie is dropped (production sites & electron) and the user meaningfully interacts with the page
interactiveConsent set to true automatically for native apps (minecraft, electron, etc)

@abchatra

A few questions:

What's the difference between interacted and interactiveConsent?  Don't they mean the same thing?  Just that for apps we're setting the flag automatically?
What's the new cookie behavior again?  We drop it automatically on page load?
How is this going to affect our MAU queries?

This needs a quick sync for us to discuss.

@shakao your proposal is good for me. Lets discuss in a 15 min sync tomorrow?

sounds good, i can do a quick chat whenever!


Run tests on schedule

Currently, tests are only executed on push / merge. In the .github/workflow, tests should be executed on schedule (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule) to assure this repository is up to date with changes in ros. Additionally, build-status should be re-added to the readme.

addressed in #69 #70 , to be moved to foxy galactic noetic melodic

addressed in #72 , #73 , noetic and melodic missing


Fix max call stack exceeded error

@yuanchuan ?
If a directory has a lot of files (in my case around 80,000) then I get a max call stack exceeded error.

Thanks for the patch


Updated pull request template

Description
Updated pull request template
Fixes #468
Type of change

Documentation update

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #469 (cb3e88a) into master (a0d540e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   70.95%   70.95%
=======================================
  Files          12       12
  Lines         730      730
=======================================
  Hits          518      518
  Misses        208      208
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d540e...cb3e88a. Read the comment docs.


Need to add full cross-struct validation in both front-end and back-end

We could just do cross-struct validation in the back-end, but we'd need a way to map the errors from the back-end up to the equivalent fields and values in the front-end.  This would probably require some more machinery to specify field mappings.
Alternatively, just implement front and back end cross struct validators.  The back-end validation will be required by Felix-go.

Fixed by  #151


Fix #61 - Remove double output when cljx auto task is executed.

The bug is mainly caused by wrong relativize behavior when a file
does not corresponds to the same rootpath, appending unexpected
and/or wrong handled file:// prefix.
This fix, adds additional step that filters the incoming file list
by corresponding rootpath, allowing to relativize working correctly
and add additionally strip the file:// prefix from result of
relativize if it appears unexpectly.
NOTE: replaces #62, now compatible with jdk6 and in one unique commit.

:+1:
This also fixes using relative source-paths, like "../shared/src/cljx".

Thank you for your work in this @niwibe, but the proposed changes were quite large for the problem at hand. I believe I've fixed this on master, available in [org.clojars.cemerick/cljx "0.6.0-SNAPSHOT"] until the final 0.6.0 release is cut.
@Deraen The change I just made does seem to work well with relative source paths like you suggest…however, I wouldn't rely on such things to work. Projects should be contained within a particular directory; I'd suggest using symlinks to bring in other directories if you absolutely have to, rather than using relative paths.


Broken with React 16.9?

Hi, I'm trying to refactor react-select v1.x to work with React 16.9, and the test suite for that version are using unexpected-react.
A few of the tests are failing, with output like:
UnexpectedError:
expected null to contain

Yes

No

After digging into one of the failing tests with the node debugger, I traced the problem to the call to this function returning null: return RenderHook.findComponent(component);
So it seems like react-render-hook might not be working with React 16.9 ? If I remember correctly, this latest version of React shipped with a new dev tools API...

Sorry to hear that. This library is not well maintained, but I still hope that somebody will fix the problem. Most of the core unexpected devs has moved to unexpected-reaction.
How many test does react-select have, I might contribute a conversion to unexpected-reaction if the task isn't super large.

Thanks for the response! There were quite a few tests in react-select, and it's actually an old unmaintained fork, so I'd say not worth your time unless there's a trivial way to fix the react-render-hook package to get this package working again...

Just a quick update on this: I am actually looking into this, and updating the render hook to work with the latest react. It's not quick, but I have a vested interest in getting this working :), so it will happen.

Awesome, thanks for looking into this!
I'll try it out the next time I tinker with the related tests.


build: Add Dockerfile docker-compose.yml

Codecov Report

Merging #11 (aeeb7fb) into main (251e10a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   81.39%   81.39%
=======================================
  Files           3        3
  Lines          86       86
=======================================
  Hits           70       70
  Misses         14       14
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251e10a...aeeb7fb. Read the comment docs.


Update slides to explain the evolution prior to ARM templates e.g. Imperative vs Declerative

Added to slide notes

Added to slide notes


NullPointerException in ft_string_indexer

Hello!
I tried to use ft_string_indexer with two variables of a dataframe I loaded into spark. With one of them the result was fine. But with the other one I got the following error:
Error: java.lang.NullPointerException
	at org.apache.spark.sql.types.Metadata$.org$apache$spark$sql$types$Metadata$$hash(Metadata.scala:215)
	at org.apache.spark.sql.types.Metadata$$anonfun$org$apache$spark$sql$types$Metadata$$hash$2.apply(Metadata.scala:203)
	at org.apache.spark.sql.types.Metadata$$anonfun$org$apache$spark$sql$types$Metadata$$hash$2.apply(Metadata.scala:203)
...

The code I used is:
base2<-bas %>%
+   ft_string_indexer(input_col = 'REGIONAL_COLOCACION', output_col = 'REGIONAL_COLOCACION_num')

I checked the column is in the dataframe with:
bas %>%
+   select(REGIONAL_COLOCACION) %>%
+   summarise(count = n() )
Source:   query [1 x 1]
Database: spark connection master=local[4] app=sparklyr local=TRUE

   count
   <dbl>
1 400766

Thanks for your help!

My best guess -- the REGIONAL_COLOCACION variable contains NULL values (or possibly empty values) and that's causing issues for the feature transformer.
You might have to explicitly drop missing values with e.g. na.omit().

Hi! Your guess is right, when I do the following I can use ft_string_indexer.
base2<-bas %>%
  select(REGIONAL_COLOCACION) %>%
  na.omit() %>%
  ft_string_indexer(input_col = 'REGIONAL_COLOCACION', output_col = 'REGIONAL_COLOCACION_NUM')

Nevertheless, when I do:
base2<-bas %>%
  select(REGIONAL_COLOCACION, var1, var2, ..., var25) %>%
  na.omit() %>%
  ft_string_indexer(input_col = 'REGIONAL_COLOCACION', output_col = 'REGIONAL_COLOCACION_NUM')

R  reply * Dropped 27276 rows with 'na.omit' (400766 => 373490) and then it never respond. Do you have any idea what I'm doing wrong?
Thanks!

My only guess is that the string indexer is working much more slowly than one might expect -- if you look at the Spark UI, do you see any active jobs re: the ft_string_indexer call?

I tried at first selecting 8 variables and it worked perfectly. Now I'm selecting 31 variables and it is not responding.
Now, regarding to your question: no, I don't see any active executors at the Saprk UI.
Any idea? Thanks!

Hi @monicarodguev , the code/data be hitting against the limit of the computer or Spark session.  A couple of settings to check:
conf <- spark_config()
conf$sparklyr.shell.driver-memory <- "16G"
conf$spark.memory.fraction <- 0.8
The driver memory has to be adjusted based on the RAM in your computer.  The memory fraction reserves part of the memory requested for metadata and other tasks.
Also, instead of going from 8 to 31 variables, can we try half that difference and try 20 first?

Hello @edgararuiz ,
I made the settings. But my machine is not that good so I configured Spark with:
config <- spark_config()
config$"sparklyr.shell.driver-memory" <- "6G"
config$spark.memory.fraction <- 0.8

I tried with 10 variables and it worked, but it didn't when I tried with 12.
Something to mention is: my initial dataframe has 31 variables. If I remove the select line (I use all the 31 variables), the statement runs correctly.

@monicarodguev sorry for the late reply, a few things to try:

Upgrade the sparklyr package from CRAN.
Try with Spark 2.1 using spark_installed_versions(), spark_unintall(), spark_install() to uninstall your current version and move up.

Just to make sure this is not related to number of columns, I ran this over the flights table which comes with 19 columns:
library(sparklyr)
library(dplyr)
library(nycflights13)

sc <- spark_connect(master = "local", version = "2.1.0")
flights_tbl <- copy_to(sc, flights)

flights_tbl %>%
  na.omit(tailnum) %>%
  ft_string_indexer(input.col = "tailnum", output.col = "tailnum_idx")

* Dropped 9430 rows with 'na.omit' (336776 => 327346)
# Source:   table<sparklyr_tmp_26f195cebb2> [?? x 20]
# Database: spark_connection
    year month   day dep_time sched_dep_time dep_delay arr_time sched_arr_time arr_delay
   <int> <int> <int>    <int>          <int>     <dbl>    <int>          <int>     <dbl>
 1  2013     1     1      517            515         2      830            819        11
 2  2013     1     1      533            529         4      850            830        20
 3  2013     1     1      542            540         2      923            850        33
 4  2013     1     1      544            545        -1     1004           1022       -18
 5  2013     1     1      554            600        -6      812            837       -25
 6  2013     1     1      554            558        -4      740            728        12
 7  2013     1     1      555            600        -5      913            854        19
 8  2013     1     1      557            600        -3      709            723       -14
 9  2013     1     1      557            600        -3      838            846        -8
10  2013     1     1      558            600        -2      753            745         8
# ... with more rows, and 11 more variables: carrier <chr>, flight <int>, tailnum <chr>,
#   origin <chr>, dest <chr>, air_time <dbl>, distance <dbl>, hour <dbl>, minute <dbl>,
#   time_hour <dbl>, tailnum_idx <dbl>

I'll close this one but do open a new one if you are still experiencing issues, thank you!


Why is the display effect lower than expected

Hello, I used supersplast and Unity to test the display effect of my ply file separately. Why is the display effect lower than expected in supersplast? Is there a problem with my ply file? Or am I using it improperly? thank you
supersplast：

unity：

The baidu website doesn't allow me to download the file without installing an app (?!?). So if you can send to my email that'd be great thanks<EMAIL_ADDRESS>

Okay, it has been sent to you. Thank you very much

Thanks I got the file and will take a look, hopefully in the next few days.

谢谢我拿到了文件，希望在接下来的几天里能看一下。

Hello, have you tested it? thank you

Hi @DreamerYinYu ,
I looked at your scene in Supersplat and Postshot and I don't see a big difference to be honest.
The scene is quite noisy and I suspect the viewpoint must be perfectly aligned to cameras.json for it look good. If the camera is off at all off then the scene looks noisy.
Supersplat doesn't actually set the camera pose exactly (camera FOV isn't set and the camera twist isn't set) and perhaps that is making the difference in this case.
Either way, I don't think you're doing anything wrong on your end. All I can suggest is to improve your model by taking more photos from different locations in the space.
Thanks!

Closing this issue. If you believe there is still a problem, please reopen it @DreamerYinYu.


"in" style scheduling throws timzone warning

Hi,
"in" style scheduling throws the following timezone warning
/home/kaung/.rvm/gems/jruby-1.7.19/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler/zotime.rb:48 warning: Unrecognized time zone: 2s
It seems to be a bug?
bash> irb
jruby-1.7.19 :001 > require 'rufus/scheduler'
jruby-1.7.19 :002 > scheduler = Rufus::Scheduler.new(:max_work_threads => 1)
jruby-1.7.19 :003 > scheduler.in "2s" do
jruby-1.7.19 :004 >     print 'hello'
jruby-1.7.19 :005?>   end
/home/kaung/.rvm/gems/jruby-1.7.19/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler/zotime.rb:48 warning: Unrecognized time zone: 2s
 => "in_1468435683.801_0.0_651100072"
jruby-1.7.19 :006 > hello

Hello,
I wouldn't say it's a bug since it is working (hello getting printed).
I tried on jruby 1.7.22 (1.9.3p551) 2015-08-20 c28f492 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_60-b27 +jit [darwin-x86_64] and there was no warning.
I think it was fixed in https://github.com/jruby/jruby/issues/2759
Best regards.

Thanks, I confirmed that warning message is not reproducible in 1.7.22


fix(#28): warning severity instead of error for abstract-decorate lint

In this pull I've changed severity of abstract-decoratee lint from error to warning.
closes #28

@yegor256 take a look, please

@yegor256 take a look, please

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min).


Sigmoid before classification

Hi,
If I got it right, models.py > ConvAttnPool is the relevant model to the suggested CAML architecture in the article.
Looking in the forward function, I see that the last action occuring before calculating loss is linear (multiplying by final.weight & adding final.bias):
       y = self.final.weight.mul(m).sum(dim=2).add(self.final.bias)
but theres no sigmoid after that, as suggested in the paper:

What did I miss?
Thanks :-)
Mor

Happens here: https://github.com/jamesmullenbach/caml-mimic/blob/7d8ce1585e2fe13fbd5e777d2206a82b0086fb1c/learn/training.py#L261
Also see #14


'Apply filters' is overlapped by the footer if there is no post to display

Navigate to helpboard and apply filter so that there is no result/post is returned.
Sample test data:
Provider: Startup
Type: Legal
-> apply filter

You will observe that no post exist.
Issue: When user scroll on this 'no post' page, you will observe that 'Apply filters' is overlapped with the footer of the page.
Refer attached GIF
https://share.getcloudapp.com/nOuneepw
Please note this works fine on mobile, refer below GIF
https://share.getcloudapp.com/nOunee82

This issue also exists in prod but since I started looking into I'll just include this as well. Should be a quick fix.


formatOnPaste + code with errors, errors show in wrong location

Open some .ts file
Have formatOnPaste enabled
Paste some code that will have errors. It must be multiple lines of text.
Red squiggles are in the wrong place. They aren't fixed until I make another edit or close/open the file

It works in 1.23
Also notice that only the f of the first foo is gray.

Can you please re-test this in a workspace that uses the final release of TE 2.9.1 (not the insiders release of TS). We just picked up this version today and it will be in the next VS Code insiders. After updating, I can't repo this anymore

Yeah we good

Adding verified since @roblourens says this fixed it


Ensure lines are at least as long as the header before finding separators

Closes #1

Thanks! :)
Happy to receive performance improvements if you have such needs.

I was actually going to ask whether you'd be willing to accept an optimizations PR. :P
To answer your original question, I'm writing a web-based system monitor that polls the output of ps and lsof, which means that if there are 6K processes, there will be 2 batches of 6K lines to process. If this takes too much time, user experience is degraded.
Keep it up @sindresorhus!


[DO NOT MERGE] Force<EMAIL_ADDRESS>in macos-setup-brew

Testing if CI builds with<EMAIL_ADDRESS>

Closing as it's part of hotfix/winter-special


Can't create migration after changing pgvector length

EdgeDB Version: 4.5+28216a1
EdgeDB CLI Version: 4.0.2+be1da73
OS Version: GNU/Linux 6.7.3-arch1-1

scalar type SearchEmbeddings extending ext::pgvector::vector<384>;
abstract type DealBase {
   embeddings: SearchEmbeddings;
}

create some DealBase with pgvector (attached example json with vector of 384 length)
deal.json
Change pgvector length (e.g. to 768) and try to apply create migration. I'm getting following error:
edgedb error: EdgeDB could not resolve migration with the provided answers. Please retry with different answers.

We should produce a better failure than this, probably, but I think even if that is fixed it probably won't be possible to migrate directly like this.
You'll need to drop and recreate the embeddings field or you'll want to create a new search embeddings type, change the type in place (providing a conversion expression), and then drop the old type and rename


feat: fix to unoThemes issues

GitHub Issue: #
Proposed Changes

[x] Bug fix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Other, please describe:

Description

Fix canary issues relating to unothemes namespace change (https://github.com/unoplatform/Uno.Themes/blob/master/doc%2Fmaterial-migration.md#updating-to-unothemes-v50 )
Impact on version

[ ] Major

The template structure was changed.

[ ] Minor

New functionalities were added.

[ ] Patch

A bug in behavior was fixed.
Documentation was changed.

PR Checklist
Always applicable
No matter your changes, these checks always apply.

[ ] Your conventional commits are aligned with the Impact on version section.
[ ] Updated CHANGELOG.md.

Use the latest Major.Minor.X header if you do a Patch change.
Create a new Major.Minor.X header if you do a Minor or Major change.
If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.

[ ] Documentation files were updated according with the changes.

Update README.md and TemplateConfig.md if you made changes to templating.
Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
Update Diagnostics.md if you made changes to diagnostic tools.
Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.

[ ] Images about the template are referenced from the wiki and added as images in this git.
[ ] TODO comments are hints for next steps for users of the template and not planned work.

Contextual
Based on your changes these checks may not apply.

[ ] Automated tests for the changes have been added/updated.
[ ] Tested on all relevant platforms

Other information

Internal Issue (If applicable):

The PR template should probably be updated on this canary repo because it doesn't make sense.

should i merge this one and create another PR for the Template fix?? @jeanplevesque

should i merge this one and create another PR for the Template fix?? @jeanplevesque

@Arieldelossantos Fix it in this PR so that you can also have a better PR template for this PR.

These are wrong, no? I'm not sure to understand how you can have both these pipelines in the PR validation?

we're investigating why the variable is not restricting this validation, because we have one to check whether is a PR or not :/


PR: Fix conda environment list on Windows application

Description of Changes

add SYSTEMDRIVE to required environment variables on Windows for alter_subprocess_kwargs_by_platform
fixes issue where interpreter environments are not found
fixes issue "pywintypes.com_error: (-2147024893, 'The system cannot find the path specified.', None, None)"

Upon testing the Windows installer for 4.2.0 release, I discovered that external conda environments were not found.
Further investigation from the internal console revealed the following traceback.
Traceback (most recent call last):
  File "C:\Users\rclary\Anaconda3\Scripts\conda-env-script.py", line 5, in <module>
    from conda_env.cli.main import main
  File "C:\Users\rclary\Anaconda3\lib\site-packages\conda_env\cli\main.py", line 44, in <module>
    from . import main_create
  File "C:\Users\rclary\Anaconda3\lib\site-packages\conda_env\cli\main_create.py", line 19, in <module>
    from .. import exceptions, specs
  File "C:\Users\rclary\Anaconda3\lib\site-packages\conda_env\specs\__init__.py", line 8, in <module>
    from .binstar import BinstarSpec
  File "C:\Users\rclary\Anaconda3\lib\site-packages\conda_env\specs\binstar.py", line 11, in <module>
    from binstar_client import errors
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\__init__.py", line 17, in <module>
    from .utils import compute_hash, jencode, pv
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\utils\__init__.py", line 17, in <module>
    from .config import (get_server_api, dirs, load_token, store_token,
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\utils\config.py", line 81, in <module>
    dirs.site_data_dir,
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\utils\appdirs.py", line 250, in site_data_dir
    version=self.version)
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\utils\appdirs.py", line 107, in site_data_dir
    path = os.path.join(_get_win_folder("CSIDL_COMMON_APPDATA"),
  File "C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client\utils\appdirs.py", line 285, in _get_win_folder_with_pywin32
    dir = shell.SHGetFolderPath(0, getattr(shellcon, csidl_name), 0, 0)
pywintypes.com_error: (-2147024893, 'The system cannot find the path specified.', None, None)

Subsequent investigation revealed that the Windows environment variable SYSTEMDRIVE was required for successful run_shell_command execution.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@mrclary

@dalthviz @ccordoba12 @steff456,
Can anyone else confirm this issue? I tested on Windows 10 VM with the latest 4.2.0 release.

@dalthviz, tangentially, how do I set Spyder to be the default application that opens python files on Windows?

"C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client_init_.py"

Given this line in your traceback, I'd say the problem happens because you have the anaconda-client package installed in your base env.
And It didn't appear in our tests because that package is required to upload packages to anaconda.org (so it's more for developers than regular users). However, we'll test your changes with anaconda-client and let you know how it goes.

@dalthviz, tangentially, how do I set Spyder to be the default application that opens python files on Windows?

We didn't have time to implement that for 4.2.0, but it's in @dalthviz's todo list for 4.2.1.

"C:\Users\rclary\Anaconda3\lib\site-packages\binstar_client__init__.py"

Given this line in your traceback, I'd say the problem happens because you have the anaconda-client package installed in your base env.
And It didn't appear in our tests because that package is required to upload packages to anaconda.org (so it's more for developers than regular users). However, we'll test your changes with anaconda-client and let you know how it goes.

Okay, so I uninstalled my existing Anaconda, downloaded their latest 64bit graphical installer, and installed with all the default recommended options (my user only, registered Anacona3 as default Python). anaconda-client is installed in the base environment by default and I get the same error.
I can confirm that the error does not manifest after removing anaconda-client from the base environment, so @ccordoba12's deduction is correct.


Issue in the bagging and stacking

Hi developers,
I found some unexpected results with the bagging and stacking.
I pass the argument auto_stack=True  to predictor.fit() and then the stacking levels is set 2 (num_stack_levels=2) and number of folds is set 8 (num_bag_folds=8). Finally, it outputs the following models:
'CatBoost_BAG_L1'
'CatBoost_BAG_L2'
'ExtraTreesEntr_BAG_L1'
'ExtraTreesEntr_BAG_L2'
'ExtraTreesGini_BAG_L1'
'ExtraTreesGini_BAG_L2'
'KNeighborsDist_BAG_L1'
'KNeighborsUnif_BAG_L1'
'LightGBMLarge_BAG_L1'
'LightGBMLarge_BAG_L2'
'LightGBMXT_BAG_L1'
'LightGBMXT_BAG_L2'
'LightGBM_BAG_L1'
'LightGBM_BAG_L2'
'NeuralNetFastAI_BAG_L1'
'NeuralNetFastAI_BAG_L2'
'NeuralNetTorch_BAG_L1'
'NeuralNetTorch_BAG_L2'
'RandomForestEntr_BAG_L1'
'RandomForestEntr_BAG_L2'
'RandomForestGini_BAG_L1'
'RandomForestGini_BAG_L2'
'XGBoost_BAG_L1'
'XGBoost_BAG_L2'
'WeightedEnsemble_L2'
'WeightedEnsemble_L3'

Here comes two issues about that:

The first one is that "KNeighbors" model seems not be used for the Stacking Layer 2, since I did't find KNeighborsDist_BAG_L2 and KNeighborsDist_BAG_L2.

The other one is that not all models are trained by the k-fold strategy. I found only "CatBoost", "XGBoost", "LightGBM", and "NeuralNet" have 8 trained models (S1F1, S1F2, ..., S1F8).  Other models, such "ExtraTrees", "RandomForest", etc , only have one trained model (only have S1F1)

I would like to know how such strategy determined and if I could specify such two arguments for each base models?
Thank you very much!

The settings are like this because they work best in practice on average across a wide range of datasets. RF, XT, and KNN only fit 1 model because of an optimization trick.
To bag all models:
predictor.fit(..., ag_args_ensemble={'use_child_oof': False})
To get KNN to be used in layer 2 (you probably don't want to do this):
predictor.fit(..., ag_args={'valid_stacker': True})
You can also apply these arguments to the model specific configs if you want 1 RF to be bagged and another to not be.

That works. Thanks you, Innixma!


[AIRFLOW-3002] Correctly test os.stat().st_size of local_file in goog…

…le_cloud_to_local
Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3002
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
N/A

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Good Spot. Thanks

Will merge once the Travis passes.

@jeffkpayne Can you please add a unit test for this as well ?

Codecov Report

Merging #3843 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3843   +/-   ##
=======================================
  Coverage   77.43%   77.43%
=======================================
  Files         203      203
  Lines       15846    15846
=======================================
  Hits        12271    12271
  Misses       3575     3575

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da052ff...df9ef49. Read the comment docs.

@kaxil Will do, but wrt squashed commits, I only had one commit so far ;)

Looks like the 2.7 builds are failing.  Looking into this...

Gah, found it...


style: fix IDE-reported ESLint Error: Remove ␍ Error

Types of changes

[ ] New feature
[ ] Bug fix
[ ] Enhancement
[ ] Component style change
[ ] Typescript definition change
[ ] Documentation change
[x] Coding style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Breaking change
[ ] Others

Background and context
This PR addresses an issue reported by the IDE regarding an ␍ error caused by ESLint and Prettier. The problem primarily stems from formatting discrepancies due to newline characters.
Solution
The formatting issue was resolved by adjusting the code formatting to eliminate newline-related formatting problems. Additionally, Prettier configurations were updated to ensure consistent code style.
How is the change tested?
The change was tested by running the test suite using npm run test. No new unit tests were required for this coding style change.
Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Coding Style
修复了导致"␍"错误的格式问题
Fixed formatting issue causing ␍ error
None

Checklist:

[x] Test suite passes (npm run test)
[x] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[x] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information
No further information to provide.

@kirklin 学习了


[STORY]: Process for "dif check" between treasury files

Full User Story
As a usdr team member, I want to have a defined process of comparing two versions of the treasury output files so I can identify differences between them.
Why is this issue important?
It is difficult to manually catch all differences between all treasury files, and it is often necessary to catch exact changes for two reasons:

it can impact overall data entry requirements (i.e. fields that were previously optional are now required, new fields are added, etc)
it almost always impacts the format of the treasury file that is generated from the usdr web tool - even things like fixing typos is important to catch and match so the treasury file generated from the usdr web tool will successfully upload to the treasury portal.

Action Plan

[x] Initial design drafted
[ ] Initial acceptance criteria drafted
[x] High level technical approach & feature flag use determined
[ ] Designs & Acceptance criteria finalized
[x] Eng task breakout complete
[ ] Assessment of whether partner training & communication actions are needed
[ ] Acceptance criteria testing completed & passed in staging
[ ] Feature flags enabled in production
[ ] Feature flags are removed once the feature is deemed stable

Engineering Tasks

[ ] #270

Acceptance Criteria
We should be able to compare treasury output files for cpf, including the following template types:

Subrecipient
Subaward
1ABroadbandInfrasturcture
1BDigitalConnectivityTech
1CMultiPurposeCommunity

Given that this is going to be an internal tool for USDR staff or volunteers, the design recommendation are minimal. The problem has been defined in ticket #270 for an engineer to build a local utility that can be run ad-hoc by any eng-staff or volunteer.


Support L5.5

Hi
I'm trying to add dingo to my project L5.5
But when I run composer require dingo/api

composer require dingo/api
Using version ^0.10.0 for dingo/api
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for dingo/api ^0.10.0 -> satisfiable by dingo/api[v0.10.0].
    - dingo/api v0.10.0 requires league/fractal 0.12.* -> satisfiable by league/fractal[0.12.0] but these conflict with your requirements or minimum-stability.

also when I change league/fractal to 0.12 v , it cause problem with another package

Problem 1
    - The requested package league/fractal (locked at 0.17.0, required as ^0.12.0) is satisfiable by league/fractal[0.17.0] but these conflict with your requirements or minimum-stability.
  Problem 2
    - spatie/fractalistic 2.7.0 requires league/fractal ^0.17.0 -> satisfiable by league/fractal[0.17.0] but these conflict with your requirements or minimum-stability.
    - spatie/fractalistic 2.7.0 requires league/fractal ^0.17.0 -> satisfiable by league/fractal[0.17.0] but these conflict with your requirements or minimum-stability.
    - spatie/fractalistic 2.7.0 requires league/fractal ^0.17.0 -> satisfiable by league/fractal[0.17.0] but these conflict with your requirements or minimum-stability.
    - Installation request for spatie/fractalistic (locked at 2.7.0) -> satisfiable by spatie/fractalistic[2.7.0].

@abosami2000 This has been mentioned a lot in issues lately. The project really needs a maintainer to push the project forward. There's an ongoing discussion here as well: https://github.com/dingo/api/issues/1413

#1445

Try this https://github.com/dingo/api/releases/tag/2.0.0-alpha1 :+1:


Sneak+toggle button crashes the server

When I sneak and press toggle button to switch from utility belt to hotbar it crashes server with message "Internal Exception: java.lang.ArrayIndexOutOfBoundsException"

Oh, forgot to say. I have version 1.19.3 of minecraft with 0.14.14 fabric loader.

I cannot do anything about this without a log, and I'm assuming that hasn't been saved. Hopefully it will be fixed by me going and fixing other issues, feel free to reopen if you run into it again.


  This library is really well put-together, but I'm having one significant problem.
I'm reading an array out of a PE with an RVA I got from the pdb crate.  I've marked the structure as [repr(C)] and POD.  The code is something like this:
    let file = FileMap::open(filename)?;
    let pe_file = PeFile::from_bytes(&file)?;

    // ...

    for sym in &pdb.symbols {
        let fields = pe_file.derva_slice::<myStruct_t>(sym.rva, sym.count)?;
        println!("{:?}", fields);
    }

The element is something like 40 bytes and the array has 2600 elements.  After 500-or-so elements I start getting all zeroes.  Prior to that the data is correct.
I'm wondering if there's something big that I'm missing here.   I get identical results if I do any of the following:

Switch to ImageMap and PeView instead of PeFile.
Read the file directly using std::fs::read.
Read each element manually by incrementing the rva by the structure size.
Switch from an optimized executable to a debug executable.

I've debugged into derva_slice and everything looks ok... the array fully fits into the section's memory.  I just get zeroes for most of the data.
Edit: Now I've also looked at it in CFF explorer and can confirm that the zeroes are there, which further exonerates the library, but it's still unclear where the data is coming from when the PE is actually loaded.
Any ideas what's going wrong?

Thanks for coming by! Getting any kind of feedback of how pelite is used by third parties will never be a waste of time.
 In the past I've tried to half-ass execute instructions which simply write to global memory and found it... lacking.
I've thought about partially loading the target executable and... simply running the initialization code (intercepting required imports so no other dependencies are needed) but never got to really experiment with it.


Supported Configurations for Dual Graphics Card (Dual GPU) Hosts

Hey bro~ I'm sorry that my problem is a bit specific, because the local machine is a dual 4090 video card machine, so after I successfully installed and deployed fluxgym, I reported an error after debugging the relevant parameters and clicking start training, which according to the prompt I think is due to the recognition of more GPUs.
I also consulted chatGPT for these issues, but since I am a code noob, I really can't complete the related debugging by myself.
The feedback from the backend is as follows:
[2024-09-17 14:55:15] [INFO] Running F:\pinokio\api\fluxgym.git\outputs\fog\train.bat
[2024-09-17 14:55:15] [INFO]
[2024-09-17 14:55:15] [INFO] (env) (base) F:\pinokio\api\fluxgym.git>accelerate launch   --mixed_precision bf16   --num_cpu_threads_per_process 1   sd-scripts/flux_train_network.py   --pretrained_model_name_or_path "F:\pinokio\api\fluxgym.git\models\unet\flux1-dev.sft"   --clip_l "F:\pinokio\api\fluxgym.git\models\clip\clip_l.safetensors"   --t5xxl "F:\pinokio\api\fluxgym.git\models\clip\t5xxl_fp16.safetensors"   --ae "F:\pinokio\api\fluxgym.git\models\vae\ae.sft"   --cache_latents_to_disk   --save_model_as safetensors   --sdpa --persistent_data_loader_workers   --max_data_loader_n_workers 2   --seed 42   --gradient_checkpointing   --mixed_precision bf16   --save_precision bf16   --network_module networks.lora_flux   --network_dim 4   --optimizer_type adamw8bit --sample_prompts="F:\pinokio\api\fluxgym.git\outputs\fog\sample_prompts.txt" --sample_every_n_steps="400"   --learning_rate 8e-4   --cache_text_encoder_outputs   --cache_text_encoder_outputs_to_disk   --fp8_base   --highvram   --max_train_epochs 16   --save_every_n_epochs 4   --dataset_config "F:\pinokio\api\fluxgym.git\outputs\fog\dataset.toml"   --output_dir "F:\pinokio\api\fluxgym.git\outputs\fog"   --output_name fog   --timestep_sampling shift   --discrete_flow_shift 3.1582   --model_prediction_type raw   --guidance_scale 1   --loss_type l2
[2024-09-17 14:55:18] [INFO] The following values were not passed to accelerate launch and had defaults used instead:
[2024-09-17 14:55:18] [INFO] --num_processes was set to a value of 2
[2024-09-17 14:55:18] [INFO] More than one GPU was found, enabling multi-GPU training.
[2024-09-17 14:55:18] [INFO] If this was unintended please pass in --num_processes=1.
[2024-09-17 14:55:18] [INFO] --num_machines was set to a value of 1
[2024-09-17 14:55:18] [INFO] --dynamo_backend was set to a value of 'no'
[2024-09-17 14:55:18] [INFO] To avoid this warning pass in values for each of the problematic parameters or run accelerate config.
[2024-09-17 14:55:18] [INFO] W0917 14:55:18.961000 20576 Lib\site-packages\torch\distributed\elastic\multiprocessing\redirects.py:29] NOTE: Redirects are currently not supported in Windows or MacOs.
[2024-09-17 14:55:21] [INFO] Traceback (most recent call last):
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\bin\miniconda\lib\runpy.py", line 196, in _run_module_as_main
[2024-09-17 14:55:21] [INFO] return _run_code(code, main_globals, None,
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\bin\miniconda\lib\runpy.py", line 86, in run_code
[2024-09-17 14:55:21] [INFO] exec(code, run_globals)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\Scripts\accelerate.exe_main.py", line 7, in
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\accelerate\commands\accelerate_cli.py", line 48, in main
[2024-09-17 14:55:21] [INFO] args.func(args)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\accelerate\commands\launch.py", line 1097, in launch_command
[2024-09-17 14:55:21] [INFO] multi_gpu_launcher(args)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\accelerate\commands\launch.py", line 734, in multi_gpu_launcher
[2024-09-17 14:55:21] [INFO] distrib_run.run(args)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\run.py", line 910, in run
[2024-09-17 14:55:21] [INFO] elastic_launch(
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\launcher\api.py", line 138, in call
[2024-09-17 14:55:21] [INFO] return launch_agent(self._config, self._entrypoint, list(args))
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\launcher\api.py", line 260, in launch_agent
[2024-09-17 14:55:21] [INFO] result = agent.run()
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\metrics\api.py", line 137, in wrapper
[2024-09-17 14:55:21] [INFO] result = f(*args, **kwargs)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\agent\server\api.py", line 696, in run
[2024-09-17 14:55:21] [INFO] result = self._invoke_run(role)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\agent\server\api.py", line 849, in _invoke_run
[2024-09-17 14:55:21] [INFO] self._initialize_workers(self._worker_group)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\metrics\api.py", line 137, in wrapper
[2024-09-17 14:55:21] [INFO] result = f(*args, **kwargs)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\agent\server\api.py", line 668, in _initialize_workers
[2024-09-17 14:55:21] [INFO] self._rendezvous(worker_group)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\metrics\api.py", line 137, in wrapper
[2024-09-17 14:55:21] [INFO] result = f(*args, **kwargs)
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\agent\server\api.py", line 500, in _rendezvous
[2024-09-17 14:55:21] [INFO] rdzv_info = spec.rdzv_handler.next_rendezvous()
[2024-09-17 14:55:21] [INFO] File "F:\pinokio\api\fluxgym.git\env\lib\site-packages\torch\distributed\elastic\rendezvous\static_tcp_rendezvous.py", line 67, in next_rendezvous
[2024-09-17 14:55:21] [INFO] self._store = TCPStore(  # type: ignore[call-arg]
[2024-09-17 14:55:21] [INFO] RuntimeError: use_libuv was requested but PyTorch was build without libuv support
[2024-09-17 14:55:21] [ERROR] Command exited with code 1
[2024-09-17 14:55:21] [INFO] Runner:

I have the same issue running both 4070 and 4060 ti. It worked yesterday, since the update I am no longer able to apply fix from previously Closed issue: "Thanks to @morpheus on Discord, we solved this. It's specific to systems with dual GPUs. In order for the training to run on a multi-GPU system on Windows, click on the ^ after the first accelerate launch, shift-enter and add
--num_processes=1^
Before the line about mixed_precision bf16. Training should now run."

I'm also experiencing this issue, the train script field is not editable so cannot use the num_processes=1 fix

You can try special launch method. Example (for windows):
env\Scripts\activate
set CUDA_VISIBLE_DEVICES=0 & python app.py


initialBlockFocus setting should be documented

https://github.com/plone/volto/blob/9e481f0f361a201d1c53892348d447aabab59813/src/components/manage/Form/Form.jsx#L185

@tiberiuichim can you elaborate about the issue?

@ayushanand308 https://6.dev-docs.plone.org/volto/configuration/settings-reference.html should have documentation about that setting


TST: fix more cases of fd leaks from np.load()

Reference issue
n/a
What does this implement/fix?
Fix a few more cases of np.load() results not being closed. To confirm them, I've used the following hack:
from test.support.os_helper import fd_count

@pytest.fixture(autouse=True)
def fd_leak():
    before = fd_count()
    yield
    assert fd_count() == before

Additional information
Suggested in https://github.com/scipy/scipy/issues/19553#issuecomment-1883040331
With the hack, I'm seeing some more tests failing with possible fd leaks but I don't have the energy right now to try to confirm them better and/or figure out where they come from.

So is the take home message that np.load in tests should be used as a context manager?

Thanks @mgorny for the fix, @lucascolley for the review! Merged.

So is the take home message that np.load in tests should be used as a context manager?

Yes, but sometimes it is more complex than that if there have been attempts for it to be reusable across multiple tests, see gh-19842

Is there any chance PChip can be extended to 2+ dimensions and avoid needing the recursive evaluation?

In principle, yes. Needs a champion to figure out the mechanics of constructing an NdPPoly instance to match RGI(..., 'pchip'). Would you be willing to take a lead on this?
At any rate best discuss this in a different issue to keep the discussion discoverable.


Stop warning on state change for seft redownload

What and why?
When a user downloads a SEFT instrument from NOT_STARTED, it goes to INPROGRESS and there is an info level log line.
When a user downloads the instrument a second time, it goes from INPROGRESS to INPROGRESS (which is right as the state hasn't really changed) but theres a warning level log line as that state transition isn't in the state machine despite it being a completely valid action. This PR fixes that so the log line that gets generated is at info level because it's a valid thing to do.
How to test?

Run SEFT acceptance tests
Download SEFT file (notice NOT_STARTED to INPROGRESS)
Download the file again, it should warn saying INPROGRESS to INPROGRESS via the COLLECTION_INSTRUMENT_DOWNLOADED event isn't allowed.
Deploy PR to your environment
Download it again.  Notice how the log line is at level info as it's an accepted event.

Trello

/deploy manna

/deploy crockerm


Gh-308: Remove Guava dependency

Related Issue

Resolve #308

Codecov Report

Merging #309 (8be539b) into develop (5b167b0) will decrease coverage by 0.05%.
The diff coverage is 86.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@              Coverage Diff              @@
##             develop     #309      +/-   ##
=============================================
- Coverage      82.20%   82.15%   -0.05%
- Complexity      1618     1626       +8
=============================================
  Files            194      194
  Lines           4326     4338      +12
  Branches         436      436
=============================================
+ Hits            3556     3564       +8
- Misses           591      594       +3
- Partials         179      180       +1

Impacted Files
Coverage Δ

.../java/uk/gov/gchq/koryphe/util/ReflectionUtil.java
80.00% <0.00%> (ø)

...in/java/uk/gov/gchq/koryphe/util/IterableUtil.java
75.00% <71.42%> (-5.00%)
:arrow_down:

...ryphe/serialisation/json/SimpleClassNameCache.java
68.61% <75.00%> (ø)

...a/uk/gov/gchq/koryphe/impl/function/FirstItem.java
100.00% <100.00%> (ø)

.../uk/gov/gchq/koryphe/impl/function/FirstValid.java
100.00% <100.00%> (ø)

.../gov/gchq/koryphe/impl/function/FunctionChain.java
100.00% <100.00%> (ø)

...ava/uk/gov/gchq/koryphe/impl/function/IsEmpty.java
100.00% <100.00%> (ø)

...va/uk/gov/gchq/koryphe/impl/function/LastItem.java
100.00% <100.00%> (ø)

...java/uk/gov/gchq/koryphe/impl/function/Length.java
98.00% <100.00%> (ø)

...ava/uk/gov/gchq/koryphe/impl/function/NthItem.java
100.00% <100.00%> (ø)

... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Further work is needed and ideally Java 8 support should be dropped first, as it would be much easier to replace some methods by moving to Java 11 where they are built in.


Add Python-ref cloning GILOnceCell::<Py<T>>::clone_ref

This adds a helper method to GILOnceCell containing Py pointers, allowing a cheap clone by Python-space incref.  This might want to be supplanted/supplemented by a derive macro as part of #4133.
Close #4428
As an aside: I'm on an Intel Mac and wasn't able to run nox -s clippy-all due to pre-existing failures in some sort of macro expansion such as:
nox > cargo clippy '--features=full multiple-pymethods' --all-targets --workspace -- --deny=warnings

error: custom attribute panicked
   --> src/coroutine.rs:125:1
    |
125 | #[pymethods(crate = "crate")]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: message: Unrecognized literal: `c"__name__"`
    = note: this error originates in the macro `crate::inventory::submit` which comes from the expansion of the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info)

I assume this is what you were seeing in CI prior to #3985.

Not sure about your local clippy issue. Does running cargo update resolve it?


[DOCFIX] Inline documentation code snippets in docs/en/deploy/Running…

…-Alluxio-Locally.md

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3042/
Test PASSed.

alluxio-bot, merge this please

LGTM

alluxio-bot, merge this please


Enhancement/lower max attempts for enqueued task for development environment

closes #393
/claim #393
In this PR I have done the below changes :

added a new optional boolean flag skipRetrying for the options of enqueueRunExecutionV2 to restrict maxAttempts to 1 if the flag is true.
updated the calls to enqueueRunExecutionV2 so that it skips retrying for development enviroment.
updated the workerQueue.enqueue call for deliverHttpSourceRequest so that it just attempts once for development enviroment.
updated the workerQueue.enqueue call for indexEndpoint so that it just attempts once for development enviroment.

Note: I have
n't updated the call from this function as it only fetches the endpoints which are already having a enviorment type of production

Please let me know if any further changes is required, Thank You. It was fun contributing this awesome codebase

There is some wrong code


Figure out how to handle moderately large data

Species coverage is a large enough dataset that reading it into memory from the db is fairly time consuming. Sarah will come up with some options to run by Jake

I figured out what I was doing wrong that prevented ReadFTPC from returning database table connections (i.e. without calling dplyr::collect() first)! Which means that we should be able to just do our filtering and summaries on the database side for the large data tables without making any big changes to the existing code. Certain things will be unavoidably slow, like exporting the full dataset to CSV, but it looks to me like most of the summary statistics listed in the background doc can be done using dbplyr.


change so that hex-strings are left padded when bytesX params

Now: if type of argument to function with bytesX param is string, it's left-aligned, otherwise (number, bignum) right.
Then: if type of argument is non-hex ascii - it's left-aligned. otherwise right.
Hex strings would be ok both with and without '0x'. If someone absolutely wants to store "0x1234" as a string (left-aligned), then they can use the hexToAscii convertion method.

bytes are always left padded. the solidity string type is used for ascii.


[Bug]: Redirect Citra and Yuzu to functional repo

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
Citra and Yuzu
Expected/Current Behaviour
Since the app will be DMCA. it will be better to redirect it to other sources
https://github.com/PabloMK7/citra/releases/tag/v2.1
https://github.com/pineappleEA/pineapple-src/releases
scoop install games/citra
scoop install games/yuzu
Steps to Reproduce
it will be gone soon

Possible Solution
redirect it to other repo
Scoop and Buckets Version
0.3.0

Scoop Config
3.0

PowerShell Version
7.4.2

Additional Softwares
https://www.pcgamer.com/software/nintendo-3ds-emulator-citra-taken-offline-as-collateral-damage-in-yuzu-settlement/

I've removed the existing manifests in https://github.com/Calinou/scoop-games/commit/9cfaf6ae2efc190c10bb2d7e048388d955ca1149.
Regarding adding manifests from forks, I prefer to wait a few weeks until the situation stabilizes to see what happens next. Feel free to open pull requests to readd manifests that install forks, but the forks need to be from a reasonably trustworthy source. It's probably a good idea for these forks to use a different name too.

Not sure how would yuzu and citra redirection to sudachi and lime3ds work (especially since it's separate continuation projects)


[release-1.11] server: serve streaming on localhost on a random port

same as https://github.com/kubernetes-incubator/cri-o/pull/1714 but for release-1.11
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

LGTM

Can we manually test and make sure that cross host oc exec/attach work fine with this? The e2e won't test it.

@runcom did you manually test this so we can merge it?

/test all

/test e2e_fedora

/test e2e

/test e2e

/test e2e

/test e2e

/test e2e

/test e2e

/test e2e

/test critest

/test integration

/test critest

/test all

/test all

LGTM
@mrunalp tests are green.

/lgtm


feat: allow multiple HTTP request methods/verbs

See discussion in #627.
To do

[x] underlying stuff
[x] Axum integration
[x] Viz integration
[ ] Actix integration
[ ] testing and examples

Looking good! Is the expectation that people will get the Method from the Request to do conditional stuff in the component?

Looking good! Is the expectation that people will get the Method from the Request to do conditional stuff in the component?

Yeah I've been messing with an example so I've got to include that so it makes more sense. It's interesting to see the patterns emerge.
I found that the Axum FromRequest extractor is async, so I actually ended up pulling the form data parsing out of the component into a server function, which... kind of makes sense anyway! Saving me some cfg flags inside the component. And with async rendering it just held the hold page so the page waits for the resource to load anyway. And then it can be reused as a server action etc if it needs to be.

Nice to see I'm not the only one haunted by rustftm.
I really like that idea, we colocate a server fn with the route it handles, and that fn handles everything!


API and implimentation separation ignored by distZip and distTar operations

When using the java-library-distribution plugin, the distZip and distTar tasks ignore api dependencies instead of packaging them in the distribution.
Expected Behavior
I would expect the distZip and distTar operations to include all dependencies required at runtime in the distribution. When using the java-library plugin, the documentation says that API and implementation dependencies should be separated, but I would expect API dependencies to be required at runtime (and so bundled).
Current Behavior
Currently, only dependencies that are used by the runtime configuration are bundled, which includes neither implementation or api dependencies.
Context
This was hit when migrating our gradle files from using the java plugin to the java-library plugin (as we are actually shipping a library, and moving our dependencies to use the best-practice layout at the same time.
Steps to Reproduce (for bugs)
The following minimum build.gradle will hit this issue:
plugins {
    id 'ivy-publish'
    id 'java-library'
    id 'java-library-distribution'
}

group = 'test'
version = '0.0.1'

dependencies {
    api 'com.google.code.gson:gson:2.3.1'

    testImplementation 'junit:junit:4.12'
    testImplementation 'org.hamcrest:hamcrest-library:1.3'
}

publishing {
    repositories {
        ivy {
	   url = "/tmp/local-ivy-repo/"
        }
    }
    publications {
        ivy(IvyPublication) {
            from components.java

	    artifact distTar
	    artifact distZip
        }
    }
}

Your Environment
Output of ./gradlew --version:
------------------------------------------------------------
Gradle 4.10.1
------------------------------------------------------------

Build time:   2018-09-12 11:33:27 UTC
Revision:     76c9179ea9bddc32810f9125ad97c3315c544919

Kotlin DSL:   1.0-rc-6
Kotlin:       1.2.61
Groovy:       2.4.15
Ant:          Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM:          1.8.0_171 (Oracle Corporation 25.171-b11)
OS:           Linux 4.18.0-1-amd64 amd64

Seems to be a duplicate of #5695.

Yep, this is fixed for 5.0


Installation steps for Windows 7

Good day, do you have an .exe installer for windows 7.

Hello sir, I will answer to the mail you send us!


Add basic hostname validation on Windows

alphanumeric, -, . or _
Starts with an alphanumeric
We could get a lot more complex here and that might not be a bad idea, but this is probably a step in the right direction.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

hrm, isn't this one of those things that we should typically let the underlying operating system just fail on and surface the error?  similar to the username and group regexps?

It might fail on Linux, but it's pretty clear you can pass bogus data to windows the way we're doing it.

At the very least we're going to have to have some Windows specific regex because we'll just reboot forever trying to set the hostname

Yeah that might be better to clean up windows since it explodes the server if you don't.

Round 2:

Moves ohai into non-windows only since we don't use it on windows
Raises if you put a period in the hostname on windows

Here’s the reference I use for naming on Windows: https://support.microsoft.com/en-gb/help/909264/naming-conventions-in-active-directory-for-computers-domains-sites-and
This PR looks like a good gate stop though to catch the most likely cause of failure.

@stuartpreston I started with that doc and I still think we could benefit from a nice validation here, but it would potentially get a bit tricky since it's different on windows vs *nix


Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properties

Description
This system property was introduced in https://github.com/opensearch-project/OpenSearch/commit/34ccd3f0dcab434302a68ef04d3a1f92fb80e31b to resolve an issue connecting to services at build time that did not support TLSv1.3.
I'm opening this PR to add TLSv1.3 to this systemProp.
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @cwperks !


Crash near DUK_UNLIKELY?

I use duktape on android devices, the crash reports reflects a frequently crash at duk_api_stack.c:264:
file: duktape.c
17449
17450     DUK_ASSERT_CTX_VALID(ctx);
17451     DUK_ASSERT(DUK_INVALID_INDEX < 0);
17452
17453     vs_size = (duk_idx_t) (thr->valstack_top - thr->valstack_bottom);
17454     DUK_ASSERT(vs_size >= 0);
17455
17456     if (index < 0) {
17457         index = vs_size + index;
17458         if (DUK_UNLIKELY(index < 0)) { // crash at this line
17459             return NULL;
17460         }
17461     } else {
17462         DUK_ASSERT(index != DUK_INVALID_INDEX);
17463         if (DUK_UNLIKELY(index >= vs_size)) {
17464             return NULL;
17465         }
17466     }
17467
17468     DUK_ASSERT(index >= 0);

the crash stack:
signal 11 (SIGSEGV)  code 1 (SEGV_MAPERR)  fault addr 0000004c
r0 6f6cf1b8  r1 00000000  r2 400bdbd4  r3 80596fc0
r4 00000000  r5 6ddb5df0  r6 400bdbd4  r7 6f6cf1b8
r8 400bdbd4  r9 00000000  10 00000388  fp 00000067
ip befcc730  sp befcbe00  lr 6dd965b5  pc 6dd961e2  cpsr 400f0030
00  pc 000241e2  my.so
00  pc 000241e2  my.so
01  lr 000245b5  my.so

Can anybody give me some clue on this crash?

DUK_UNLIKELY is a branch hint:
#define DUK_UNLIKELY(x)  __builtin_expect((x), 0)

It's not an actual function call so it shouldn't be able to crash (it only affects compiler code generation by possibly affecting e.g. code layout). The actual crash reason might be close to that site however.
What compiler / Duktape config options are you using?

This might give a clue:
signal 11 (SIGSEGV)  code 1 (SEGV_MAPERR)  fault addr 0000004c

The fault address is 0x4c so there's a high likelihood some call site is using a NULL pointer returned from the quoted function (which I think is the internal duk_get_tval()) to read/write a struct offset 0x4c.

What compiler / Duktape config options are you using?
I use the arm-linux-androideabi-gcc(version 4.9) compiler. Duktape config i use the default duk_config.h in duktape v1.3.0.

If you could provide a full call stack (or at least a few levels below the crash site) it'd probably be quite helpful.
the line number corresponding to 01  lr 000245b5  my.so is duk_js_compiler.c:625 which is a comment line(I don't know the meaning of 01  lr 000245b5  my.so(google tells that it's a linker register) and i just try to treat it as a code address).
I can't retrieve any more call stack. the crash rate of this case is about 15 crashes per 100000 users in one day.

Anyway, @svaarala thanks for your professional advice and support.

@faywong You're quite welcome, let's see if we can figure this out.
One reason I asked about the config was that sometimes people enable DUK_USE_VALSTACK_UNSAFE for footprint/performance reasons; it makes Duktape behave like Lua in that there are no checks for a value stack overrun if you fail to duk_require_stack() before pushing in values. But that shouldn't be the case here if you're using the default options.
Are you using the 1.3.0 release by the way? If so, could you upgrade to 1.3.3; there have been some crash fixes in the patch releases (finalizer related, for example).

Yes, I use the 1.3.0 release. I will evaluate the risk and consider a special window to observe the performance of 1.3.3 release.
By the way, i also noticed some crashes when invoking duk_push_heapptr(i create and reference a js object in c and then use it sometime later with duk_push_heapptr), it this involves the finalizer related stuff?

That shouldn't be finalizer related necessarily.
By the way, when you use duk_push_heapptr it's crucial to ensure the object is never in an unreferenced state between its creation and a later duk_push_heapptr. Otherwise memory unsafe behavior may occur, but it may not happen systematically. Could this be possible in your case?

I will evaluate the risk and consider a special window to observe the stability of 1.3.3 release.

I admit I don't know what your specific situation is but there shouldn't be any risk?  The patch releases receive only bug fixes, mostly security/crash related, so there's no new code or features that need to be tested.
But yes like @svaarala says duk_push_heapptr() can get you in trouble if you're not careful.    Usually this means placing the object in the global stash, which is invisible to Ecmascript but still counts as reachable to Duktape.

@fatcerberus
@svaarala

@faywong Sounds like a careful upgrade test to 1.3.3 might be useful, especially if your code does use finalizers :)

@faywong Was this resolved for your case?

Not yet. Per the discussion result of our team, we doesn't want to migrate to the bugfix version you mentioned above. The crashes is present as well:
stack trace:
signal 11 (SIGSEGV)  code 1 (SEGV_MAPERR)  fault addr 00000044
 r0 00000000  r1 00000040  r2 00000004  r3 00000002
 r4 00000002  r5 00000001  r6 13e9d940  r7 ab455e28
 r8 13e9d940  r9 ab455e28  10 13743340  fp 141add60
 ip d8d083c1  sp ffaa4384  lr d8d0a591  pc d8d0a43c  cpsr 00030030
         #00  pc 0001243c                          my.so
         #00  pc 0001243c                          my.so
         #01  lr 00012591                           my.so

arm-linux-androideabi-addr2line -e my.so 0001243c
duk_api_stack.c:633

17825     DUK_ASSERT(thr->valstack_top >= thr->valstack_bottom);
17826     DUK_ASSERT(thr->valstack_end >= thr->valstack_top);
17827
17828     old_size = (duk_size_t) (thr->valstack_end - thr->valstack);

Anyway, i will return to this(or similar) problem later.

Hm, it looks like it's crashing during value stack resize.  I wonder if it's an out of memory condition.

If so, it should be preceded by an alloc/realloc call returning NULL.

@fatcerberus @svaarala
Thanks for your remind. On an ordinary android device, the heap space is larger than 48MB, on what possibility will this happen?
Moreover, today i noticed another crash case:

signal 11 (SIGSEGV)  code 1 (SEGV_MAPERR)  fault addr 00000017
 r0 5c583f10  r1 0000001b  r2 fff20000  r3 00000013
 r4 40087394  r5 00000002  r6 6701b110  r7 668db518
 r8 beb1a1e4  r9 5754adf8  10 41516880  fp beb1a1fc
 ip 00000000  sp beb1a188  lr 6626c021  pc 6626bf06  cpsr 00070030
         #00  pc 00014f06  /data/app-lib/com.eg.android.AlipayGphone-2/libflybird.so (duk_push_undefined)
         #01  pc 0001501c  /data/app-lib/com.eg.android.AlipayGphone-2/libflybird.so (duk_push_heapptr)

the involved code snippet:
21274 DUK_EXTERNAL duk_idx_t duk_push_heapptr(duk_context *ctx, void *ptr) {
21275     duk_hthread *thr = (duk_hthread *) ctx;
21276     duk_idx_t ret;
21277
21278     DUK_ASSERT_CTX_VALID(ctx);
21279
21280     ret = (duk_idx_t) (thr->valstack_top - thr->valstack_bottom);
21281
21282     if (ptr == NULL) {
21283         goto push_undefined;
21284     }
21285
21286     switch (DUK_HEAPHDR_GET_TYPE((duk_heaphdr *) ptr)) {
21287     case DUK_HTYPE_STRING:
21288         duk_push_hstring(ctx, (duk_hstring *) ptr);
21289         break;
21290     case DUK_HTYPE_OBJECT:
21291         duk_push_hobject(ctx, (duk_hobject *) ptr);
21292         break;
21293     case DUK_HTYPE_BUFFER:
21294         duk_push_hbuffer(ctx, (duk_hbuffer *) ptr);
21295         break;
21296     default:
21297         goto push_undefined;
21298     }
21299     return ret;
21300
21301  push_undefined:
21302     duk_push_undefined(ctx);
21303     return ret;
21304 }

Hm, 48MB seems a little tight.  If you end up doing a lot of allocations and you're not using a pooled allocator, I could see running out of memory, due to fragmentation if nothing else.  Not saying that's the issue here, but it's a possibility.
The crash in duk_push_heapptr() looks like you're mismanaging a heap pointer somewhere and the object it points to has been GC'd.    I would go through the code and double check that all heap pointers are being stashed to keep them reachable.

And the possibility of the latter crash is about 1/1000(about 3 crashes on 3000 devices).

@svaarala What's the differences between version 1.3., 1.4., 1.5.*？

Duktape follows semantic versioning pretty closes, so that for example:

1.3.0 -> 1.3.1: bug fixes with as few feature changes as possible (source compatible)
1.3.0 -> 1.4.0: new features, source compatible
1.4.0 -> 2.0.0: new features, not source compatible

You can see the changes in releases from http://duktape.org/download.html, which is autogenerated from https://github.com/svaarala/duktape/blob/master/RELEASES.rst.

Got it. Thanks for clarifying it.


Add FxCop analyzers to the project

https://docs.microsoft.com/en-us/visualstudio/code-quality/install-fxcop-analyzers?view=vs-2019

All assemblies other than WsFederation now have analyzers
WsFederation analyzers will be added in #1453


HTTP Sink Unit Test

Summary
Add tests
**PR Type: Feature **
Status: Ready to review
Breaking change? No

Codecov Report

Merging #145 (931899f) into master (2135251) will increase coverage by 0.87%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   62.77%   63.64%   +0.87%
==========================================
  Files         125      125
  Lines        5368     5370       +2
  Branches      257      260       +3
==========================================
+ Hits         3370     3418      +48
+ Misses       1998     1952      -46

Flag
Coverage Δ

unittests
63.64% <93.33%> (+0.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...in/scala/ai/starlake/job/ingest/IngestionJob.scala
58.74% <0.00%> (ø)

...in/scala/ai/starlake/job/sink/kafka/KafkaJob.scala
76.74% <100.00%> (+0.84%)
:arrow_up:

...la/ai/starlake/job/sink/kafka/KafkaJobConfig.scala
89.28% <100.00%> (-0.37%)
:arrow_down:

...main/scala/ai/starlake/privacy/PrivacyEngine.scala
84.41% <0.00%> (+1.29%)
:arrow_up:

...a/ai/starlake/job/sink/http/HttpSinkProvider.scala
83.33% <0.00%> (+80.00%)
:arrow_up:

...ala/ai/starlake/job/sink/http/HttpSinkClient.scala
91.30% <0.00%> (+91.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afc6e4...931899f. Read the comment docs.


Should AdaptiveOpenUrlAction Url property be a Uri?

I only just noticed that it is still a string. Should this not be changed to reflect all other Url property types?

Indeed it should, I'll get to this soon

I just submitted a PR for this but I assume all the other platforms will also need to change?

This change is in master now, and live in beta08 package, thanks!


Request to add kinozal.tv to as a provider.

hello can add this site on torrentio scrapper ? Couse I found out it have many movie that rutor dun have.
example show
2DEZIT
Thanks appreciate!!

This is a private tracker, so it's not possible to add it to Torrentio. Also atm I'm not planning on adding new providers.


Property 'selectedFlatRows' does not exist on type 'TableInstance'.

i was following this example
and trying to add selectedFlatRows,state: { selectedRowIds } in instance but both return this error
packages  "react-table": "^7.6.2","@types/react-table": "^7.0.25","@types/react": "^16.9.56","react": "^17.0.1",

I've run into the same problem.
"react": "^17.0.1"
"@types/react": "^17.0.0"
"react-table": "7.6.3"
"@types/react-table": "7.0.28"

Guys follow instructions here - https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-table .
Create a react-table-config.d.ts with all the code mentioned in docs.