kumarsaurav123-> Attempt#2

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh

Execution time:
Execution time of reference implementation:

Can you please squash that into a single commit, off of current main? Thx.


[Request] self-update command

Is it possible to make a self-update command, like composer and other CLI tools?
Right now you have to re-download the files and overwrite them, right? (When using the standalone .phar file).
You are using the Box Project, so does this apply? http://moquet.net/blog/distributing-php-cli/#auto-updates

That's done on 3.0, just not ported to 2.0 yet


Remove scripts/write-env-variables.ts

I don't see this ever being used (over this kind of usage, which has you use the correct version). @andreogle should we remove it for simplicity?

Yeah I'm fine with removing it


feat: add typedoc support

This PR
Generates documentation based on TypeScript types and deploys the docs using GH pages.
How to test
This was tested in a fork. The generated GH page can be seen here.
Signed-off-by: Michael Beemer<EMAIL_ADDRESS>

Codecov Report

Merging #263 (0c9a853) into main (49a734b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files          15       15
  Lines        1217     1236   +19
  Branches       97       97
=======================================
+ Hits         1213     1232   +19
  Misses          4        4

Impacted Files
Coverage Δ

src/index.ts
100.00% <100.00%> (ø)

src/open-feature.ts
98.52% <100.00%> (+0.10%)
:arrow_up:

src/types.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closing in favor of this PR


Splash screen texture background is moving/switching

@LiavGut what does that mean? please give screen shots

@sirpy I can't screenshot that.. :)
Just look at the background while the logo animation plays and you'll see that the wave texture of the background changes...

I dont see it.
make a screen recording then. (you can use "quicktime" on mac)

@sirpy
wave_texture_shifts.zip

Verified as done.
Checked on the Dev env. v0.18.1-2
Devices:
Desktop - Google Chrome 81.0
Redmi Go // Android 8.1.0
Video: https://www.screencast.com/t/uvhUQIU2


The login_hint to scoping element is broken

This issue is imported from pivotal - Originaly created at Nov 5, 2020 by Bart Geesink
When I try to use the login_hint feature, it seems that the requested idp is not adding the saml2p:IDPList element
Now:
<saml2p:Scoping ProxyCount="1">
saml2p:RequesterIDplayground_client</saml2p:RequesterID>
saml2p:RequesterIDhttp://mock-idp</saml2p:RequesterID>
</saml2p:Scoping>
expected:
<saml2p:Scoping ProxyCount="1">
saml2p:IDPList
<saml2p:IDPEntry ProviderID="http://mock-idp" />
</saml2p:IDPList>
saml2p:RequesterIDplayground_client</saml2p:RequesterID>
</saml2p:Scoping>

https://github.com/OpenConext/OpenConext-oidcng/commit/764c0b0123057fb045d321b597c17916e418772b (Okke Harsta - Nov 6, 2020)


[Feature] Verbose Debug mode?

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe.
I'm having such a terrible time troubleshooting this. I'm using your Pqina editor along with this package inside a Vue/Cordova setup. ~75% of my users have issues with uploading files, especially when they attempt to upload multiple files at once. I so wish there was a way to force them to upload only a single file at a time.
In the meantime, is there a way to enable a debug mode of sorts that will be verbose and spit out warnings/errors whenever it encounters any kind of issue?
I've added lots of logging myself but I can't seem to pinpoint the source of the issues.. I suspect some kind of race condition or buffering/chunking issue.. but it's so hard to get to the bottom of it.
A debug mode would be helpful.
Otherwise, are you by any chance available for one-on-one support? We'll pay of course. At this point I have spent 30+ hours trying to get this to work perfectly and I'm starting to run out of ideas and getting a bit desperate.
Describe the solution you'd like

Describe alternatives you've considered

You could set maxParallelUploads to 1 but maybe that's not what you mean?
Additionally if you are only uploading one file I'd stay away from FilePond and use the included  element. It's a lot more lightweight and Pintura can handle file uploads as well.
https://pqina.nl/pintura/docs/v8/getting-started/installation/pintura-input/
If that doesn't work, please reach out using the support form on the customer portal, happy to discuss this but it's better to do that outside GitHub.
Will close this for now as the feature request is intertwined with other issues. If needed I'll clean this up later.

Glad to hear that.
I'm not aware of any attribute on the file input element that allows you to limit the amount of files you select, the only thing you can do is hint at the file types the user can select, but that isn't supported on every OS.


About benchmarking results

Benchmarking results in Sec. B.2 (Table 8~11) show models trained on COCONut-S perform worse on COCO-val than those trained on COCO. Is this because COCO and COCONut have different quality of annotations, resulting in models trained by COCONut-S actually getting better results, but being incorrectly evaluated by COCO-val?

Benchmarking results in Sec. B.2 (Table 8~11) show models trained on COCONut-S perform worse on COCO-val than those trained on COCO. Is this because COCO and COCONut have different quality of annotations, resulting in models trained by COCONut-S actually getting better results, but being incorrectly evaluated by COCO-val?

yes, basically better quality data will train better model, since the evaluation set is pretty wrong and thus result in worse performance, because the predictions will do better job than the GT in val set, you can compare the model prediction to the original COCO val set by visualizing some example images.


[Improvement] Fixed code quality issues

Description
Hi :wave:
I ran the DeepSource static analyzer on the forked copy of iris repo and found some interesting code quality issues.
Summay of changes

Remove unnecessary comparison with bool
Combine multiple appends into a single call
Fix check for empty string
Add .deepsource.toml config

Type of change

[x] Bug fix :bug:

Checklist:

[x] I have signed the appropriate Contributor License Agreement

I've signed the CLA!

Hey @withshubh ,
Thanks for your contribution! I'm not sure what's up with the CLA bot. I think it may be confused because DeepSource Bot is listed as a contributor. Would you be willing to open a new PR and make the changes manually, such that you are the only contributor?

Hey @withshubh ,
Thanks for your contribution! I'm not sure what's up with the CLA bot. I think it may be confused because DeepSource Bot is listed as a contributor. Would you be willing to open a new PR and make the changes manually, such that you are the only contributor?

@genevieveluyt fixed it :sparkles:

@genevieveluyt fixed it :sparkles:


Insert mapping: fix {rhs}= mappings; add 2+ chars {lhs} support

Fixes #201 and #205
Add support for 2+ chars {lhs} mapping as well.
E.g.:
imap jan january
Tests checking those features have been added.
bundle exec rake is passing.
Cheers,
Antoine

I don't think I knew about mapargs when I wrote the code to do multi_cursor_insert_maps... I suppose the custom hash isn't really a good solution if vim will just tell you, is it?

@eapache the 2nd commit is a cleanup.
Despite what TravisCI says, bundle exec rake passes :)
Regarding maparg() are you saying that there is a way to know if a letter starts a mapping ?
The way I use it is to resolve mapping {lhs} into its {rhs}, if char does not match any mapping, maparg() returns an empty string.
I will look into what you are suggesting today.
Cheers,
Antoine

Ah, I get it, thank you. I'm not sure my suggestion makes sense anymore, but I haven't looked at this code in a while.


Display .gitignore in file browser

Hello!
Could you please advise - how to show .gitignore file in file browser, as well as .git subfolder?
I tried to change it in options of the project, the option Skip subdirectories, but it didn't help.
Thank you in advance, George.

Alex, I'm really a bad mantainer.. but RADXIDE has an elaborated section
about hidden files in the scanning func of its tree.tcl:
https://github.com/par7133/RADXIDE/blob/main/tree.tcl
I hope you can find it hintuitive enough and helpful (ahah, I remember nothing of Tlc at time...)
;-)
-CC
Jul 8, 2024 16:28:02 Alex Plotnikov @.***>:

I'll fix this on Wednesday.
Just now, alited uses /glob/ command that skips all hidden files. So that this issue is shown in Linux and isn't in Windows.
—
Reply to this email directly, view it on GitHub[https://github.com/aplsimple/alited/issues/22#issuecomment-2214231707], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFONMRBYAUAOJ5SIY3GR6M3ZLKOW3AVCNFSM6AAAAABKQYCGQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUGIZTCNZQG4].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AFONMRBBM374ZR2KKVSBGHLZLKOW3A5CNFSM6AAAAABKQYCGQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUD7J7JW.gif]

Fixed in v1.8.6b2

Daniele, thanks for advice. As for RADXIDE project, is it suspended?

RADXIDE is much more simpler project then Alited, after some two-three important indipendent bug fixes code is actually is standby
but project is not suspended, RADXIDE remain a tool part of my dev environment indeed, actually working perfectly under Unix.
But I have to be sincer saying that I'm 90% of my time on web development and 10% for OpenBSD and as RADXIDE born from a subset of an old version of Alited code and doesnt follow up on Alited code (also because doesnt have tabs, system integration, etc)..it has its life, and as Alited is upgrading and bugfixing, as Tcl/tk is upgrading and bugfixing..although slowly these processes can happen I don't feel like the proper conditions to maintain RADXIDE.
Maybe for personal needs RADXIDE developmemt and maintenance could anyway happen but as one developer from its own
I can't garantee anything to RADXIDE users.
-CC
Jul 8, 2024 20:14:50 Alex Plotnikov @.***>:

Fixed in v1.8.6b2

Daniele, thanks for advice. As for RADXIDE project, is it suspended?
—
Reply to this email directly, view it on GitHub[https://github.com/aplsimple/alited/issues/22#issuecomment-2214868457], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFONMRBYOPD3MIEXOFDBZFTZLLJJNAVCNFSM6AAAAABKQYCGQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHA3DQNBVG4].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AFONMRBOT5VKJMV2VDPHN4DZLLJJNA5CNFSM6AAAAABKQYCGQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUEAQ26S.gif]

Fixed in v1.8.6b2
Thanks a lot 😊


Requested changes to 2.4's taptree0.jpg image

ABC TapBranch has 'AB & D' text, should be 'AB & C'

@jachiang

Sorry, I thought I had corrected this. Will open a separate PR now.


Write to 4-dimensional position access and shader graph code generation fix.

I added the ability to write to the 4-dimensional position vector in custom vertex shader code since I needed direct access for a shader I'm working on. While I was at it, I fixed some code generation bugs concerning converting xforms to vectors and vice versa in the shader graph. Also changed mode_replace_table entries to use enums rather than numbers to prevent potential mistakes.

nice clean up!


fix: update return type of createPolygon in google maps api wrapper

Return type now returns Polygon instead of Polyline.
Closes #1304

Whoops didn't realize #1304 was a PR


adding HBN easy-to-convert assessments (12 in total)

In this PR, I added those easy assessments from HBN. By "easy", I mean (1) no need to compute the subcategories ( see #66 ) and (2) questions in the same assessment have the same value scale.
currently, there are 12 of them:

[X] ASSQ
[X] IAT
[X] PCIAT
[X] MFQ_P
[X] MFQ_SR
[X] CIS_SR
[X] CIS_P
[X] SCQ
[X] ACE
[X] ICU_P
[X] ICU_SR
[X] ARI_P

@djarecka can you enable the workflow? thx!

@yibeichan - when you do the assessments, do check if they are already there and if so update existing one. also for those that can be completed by someone for someone else it would be useful to add that as a set of items instead of creating two separate assessments (unless the questions are different).

@satra I checked it when I first converted hbn_asr, but I didn't add a line to my script to automatically check whether the about-to-be-converted one exists. I will do it.
I have a question about naming those activities. I currently adopted the naming from ABCD, which is abcd_{assessment_name}. So for the ones used in HBN, some are specific HBN, and some may be more general. Should I add the prefix hbn_ or not?
Also, some activities in reproschema-library have uppercase names, but others (especially the abcd ones) have lowercase names.  I'm not aware of a document anywhere that has such details about when I should use uppercases or lowercases (maybe I missed it?).

the schema name itself does not matter too much since it's just an id. using hbn_ is fine. the abcd_ prefix was used since it was converted automatically from NDA schemas. for common activities we were preferring using their standard shortform if available (e.g., PHQ9), but that's not a requirement anywhere.

okay, I'll keep hbn_{assessment_name} since assessment_name is from HBN dictionary. for example, ASR means adult self-report, which I don't think is a generalized assessment across studies.

I'm done with converting easy/simple assessments and have updated the list at the beginning of this PR. Some updates:

as a follow-up to the above discussion with @satra, I went to look up the original HBN assessment list and found that some of those assessments have "reference." for those assessments, I treated them as independent of HBN (aka use their own name -> {assess_name}_schema). Only for assessments of which reference=="" or reference=="Project Developed", I name them as hbn_{assess_name}_schema. So far, none of the above 12 assessments are HBN-specific.
in this new version, I added more detailed description, citation, preamble, and compute, for example:"description": "The ASSQ is a 27-item checklist for completion by lay informants when assessing symptoms characteristic of Asperger's Syndrome or high-functioning autism spectrum disorders.",
"schemaVersion": "1.0.0-rc4",
"version": "0.0.1",
"citation": "Ehlers S., Gillberg C., Wing, L. (1999). A screening questionnaire for Asperger\u00a0syndrome\u00a0and other high-functioning autism spectrum disorders in school age children. Journal of Autism Developmental Disorders 29, 129-41.",
"preamble": null,
"compute": [
    {
        "variableName": "ASSQ_total_core",
        "jsExpression": "ASSQ_01 + ASSQ_02 + ASSQ_03 + ASSQ_04 + ASSQ_05 + ASSQ_06 + ASSQ_07 + ASSQ_08 + ASSQ_09 + ASSQ_10 + ASSQ_11 + ASSQ_12 + ASSQ_13 + ASSQ_14 + ASSQ_15 + ASSQ_16 + ASSQ_17 + ASSQ_18 + ASSQ_19 + ASSQ_20 + ASSQ_21 + ASSQ_22 + ASSQ_23 + ASSQ_24 + ASSQ_25 + ASSQ_26 + ASSQ_27"
    }
],

all my information comes from HBN materials, which may have errors and incomplete info. so a potential problem is that I don't know which part would be erroneous or incomplete unless I manually examine each of them.

Hi @satra I went through reproschema doc website and github repo, don't think there is anything that can be used to indicate proprietary.
should we add one to reproschema? if we add something for proprietary assessment, should we also add something for levels of measurement (categorical, nominal, rank, ratio) (based on the lab meeting discussion)? or we can add those two one by one, not necessarily simultaneously.

aha, how about this one isAccessibleForFree from schema.org

you could just use this https://schema.org/isProprietary at the assessment level. it's a simple boolean.

ah okay, I didn't find it? (i was overthinking I guess. I'll add it and use the csv that maedbh generated to rerun the whole converting thing again.

okay, I redid those 12 assessments with maedbh's csv (still kept some of my original fields, such as citation tho), and also sent PRs to maedbh's repo to fix some minor issues.
even though all the checks have passed, I do think we (me and @djarecka ) need to go through them one by one before we merge them.

hello, I finished checking the content part for the following, mostly adding preamble and fixing typos. By checking, I mean I found some of those assessments online (see here, only SIG people have access), compared the content from those online pdf with the ones provided by HBN, and some adjustment.
so you may notice that SCQ is proprietary that means I could only used the information HBN provided.

[X] ASSQ
[X] IAT
[X] PCIAT
[X] MFQ_P
[X] MFQ_SR
[X] CIS_SR
[X] CIS_P
[X] SCQ (proprietary)
[X] ACE  (TBD)
[X] ICU_P
[X] ICU_SR
[X] ARI_P

Here are some questions:

how to address skipping logic, for example , in SCQ_01 "Is she/he now able to talk using short phrases or sentences? If no, skip to question 8."
ACE is a bit confusing here. I contact the UCSF person from the reference listed on HBN. And they told me

ACE does not have questions per se, but is a battery of objective measures of cognitive control.  So it is unclear to me how these would be placed into a github repository in any meaningful way.

I might have some miscommunication with the UCSF person, I'll explain to them later.
also, in the HBN assessment list, this assessment is actually documented as the following. In other words, there is no single assessment called ACE. but we have ACE in the data dictionary from HBN.

Domain
Measure
Abbreviation(s) COINS
Abbreviation(s) LORIS
Description
Reference

Cognitive Testing
Adaptive Cognitive Evaluation
ACE_Boxed, ACE_BRT, ACE_Flanker, ACE_SAAT, ACE_Spatial_Span_B, ACE_Spatial_Span_F
ACE_Boxed, ACE_BRT, ACE_Flanker, ACE_SAAT, ACE_Spatial_Span_B, ACE_Spatial_Span_F
Mobile cognitive control assessment battery containing standard tests that assess different aspects of cognitive control (attention, working memory, and goal management), modified by incorporating adaptive algorithms, immersive graphics, video tutorials, motivating feedback, and a user-friendly interface.
Neuroscape Technology

for next steps: @djarecka I need your help to check the structure, whether we need to add more fields or not. Since all the above assessments were generated by the same script in the first place, they should have the same structure. So you only need to pick one and check it. I would suggest that once we agree on the structure, we merge this PR. If issues come up later, we will fix them in a way that each assessment will have their own PR.

for skipping logic see the 10th item in phq-9. also phq-9 is an example where the total score itself is an item. for the SCQ that should be added.
for something like ACE, the data elements for the scores can still be added even if the task items are not.

okay, SCQ fixed, set the skipping logic, and added SCQ_total_score. but in general, when should I add the total score to the item? I mean, are there any criteria? If there is a skipping logic, then we add the total score? I notice that PHQ_XXXs have those total scores, but I don't actually know why they have it.

I notice that PHQ_XXXs have those total scores, but I don't actually know why they have it.

because each item is a data element, and anything that has a recordable value associated with it should be a defined entity.

I see, PHQ is a family of assessments, so each of those PHQ_XXXs' total score should be calculated for further computation

I went back to the reproschema repo and realized that I should add total_score for each of those assessments, not only those that are subsets of a family of assessments. So, I revised all those 12 assessments & fixed some typos.
A note to myself: MFQ_SR is a bit weird in that usually, the parent report version and the self report version have the same amount of items that are framed in different ways. But MFQ_SR has only 33 items while MFQ_P has 34 items. This is te information I can get from the HBN dictionary; no full MFQ online was found yet.

for mfq: https://psychiatry.duke.edu/research/research-programs-areas/assessment-intervention/developmental-epidemiology-instruments-0

I think we should improve the automatic validations of new schemas, but we just reviewed with Yibei and they look similar to others. We made some notes that we want to discuss for the future


LinearLayout conversion interface

This PR closes #1874
Instead of detecting and calling DPAStoLinearLayout whenever it is needed, now we can use generic toLinearLayout for DPASEncodingAttr layouts.
Also fixed the DPAS->LL logic bug and updated the LIT/unit tests accordingly.
The interface change will be upstreamed after merging(#1785)

Because this change increases our differences from upstream code we can change it to a draft and resume the work once the code changes in common files have been merged upstream.

Merged in https://github.com/intel/intel-xpu-backend-for-triton/pull/1942.


feat(footer): create footer react wrapper

Related Ticket(s)
[footer]: create React wrapper #8638
Description
Add React wrapper for footer component + codesandbox
Changelog
New

footer react wrapper
footer react wrapper codesandbox example

Looks good! but the Short with Adjunct Legal links story is missing the locale button

Yep! Pushed out a commit to fix that! Thanks for pointing that out!


fix: Changes to make regex patterns more efficient, accurate and simpler

This PR contains changes to address regex issues discovered by CodeQL:

https://github.com/opentdf/web-sdk/security/code-scanning/8
https://github.com/opentdf/web-sdk/security/code-scanning/9

Changes (see also commit messages):

First commit contains two changes.  First to ensure that . characters in the url and ip addresses match only the literal . vs interpreted as "any character".  This is both a fix to make the patterns more precise, as well as more efficent.
The first commit also fixes the WWW_HOST TLD part of the pattern.  Specifically ^s was switched to a-z.  ^s will match any character except s, it is assumed that ^\s was expected (to match any non-whitespace character).  However the a-z check is simpler and more precise.
The second commit addresses potential backtrack inefficiency by replacing [^>]* with [^>]*?.  The additional ? will result in a non-greedy match (resulting in as minimal backtracking as possible to find a match).

After discussing with @dmihalcik-virtru we decided to further simplify WWW_HOST pattern.  We are able to remove the www and negative www check, remove the group capturing, and simplify the subdomain pattern.  Overall this notably improves the performance and understanding of this pattern.

sorry approved in wrong profile


Allow clients to customize ringpop stats prefix

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Overall looks good. Could you add tests to make sure the option is propagated correctly? Also, It looks like statHostPort is never used (except for one test). Lets remove it?


for maven it is not working

while adding dependency not working

Could you please add more description?

i am reinstalling and will follow each step i will let you know if any
issue arises.
thanks a lot for replying
On Sat, Jan 21, 2017 at 7:01 AM, spfrommer<EMAIL_ADDRESS>wrote:

Could you please add more description?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spfrommer/JCommunique/issues/4#issuecomment-274222253,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKUaUlQHuSDBI3Ly7v5TU2WJ0mCTTL9Iks5rUWAJgaJpZM4JtAVy
.


[8.x] Change Collection's implode method's first parameter to be optional

This Pull Request changes the Collection's implode method's first parameter $value to be optional. As the built-in php implode function's glue is also optional, I think this change makes sense as it will not be necessary to add an empty string to the collection implode's first parameter when someone wants to concatenate a simple list of strings.
echo collect(['taylor', 'dayle'])->implode(); // taylordayle
If the collection is a list of nested elements (arrays or objects) and no $value is passed, it will trigger a notice Notice: Array to string conversion (as implode() normally does this when passing a nested array).
echo collect([['name' => 'taylor'], ['name'=>'dayle']])->implode(); // Notice: Array to string conversion

These are breaking changes unfortunately

@driesvints Hi Dries, I was about to open the same PR. Why do you say it's a breaking change? Making a parameter optional shouldn't break anything, because no one is using the ->implode method without parameters. Can you reconsider merging this PR?

The changes to the method signature are breaking for anyone overriding it.


🌱 Added for import aliases for kubernetes packages

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1246
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:

[ ] squash commits
[ ] include documentation
[ ] add unit tests

@kranurag7 this PR did not trigger any Go-related CI jobs.. It should of course.. This is about linting Go! Can you fix this?

converting to draft until checks are running locally

plz add the aliases again that you removed ;)

plz add the aliases again that you removed ;)

those are causing errors in the checks

@janiskemper I've squashed the commits

@yrs147 please rebase as well because of settings.


Administrative things

Administrative tasks to take care of:

[ ]  Add license.  I think we've agreed on BSD-3 clause with an AUTHORS file for copyright purposes.  I've opened https://github.com/samtools/htsjdk-next-beta/pull/2 to add that.
[ ]  Add contributing page describing the process for making a contribution.  This will probably need to evolve over time.
[ ]  Add code of conduct.  I think we can probably use one of the ones that github recommends.
We do need an email address that someone can report incidents to.  Maybe a google group for the maintainers?  I created a maintainers github team but I'm not sure it can be emailed.

For the code of conduct, I recommend Covenant. I will do a PR now. We should still decide an email


Docs application dependency update for elixir 1.4

Mix v1.4 now automatically infers the applications list
as long as you leave :applications key empty

Coverage remained the same at 56.296% when pulling 11acc2c55c1925524ecd22f833c05bd8a1a3f842 on pauloancheta:master into db43c38f5b6aba0ee8d489118677c43df0782e2d on smeevil:master.

Coverage decreased (-1.7%) to 54.61% when pulling f4540cf5e94d42611e5b4dd6feaab2d735f99c68 on pauloancheta:master into db43c38f5b6aba0ee8d489118677c43df0782e2d on smeevil:master.

Coverage decreased (-1.7%) to 54.61% when pulling 7f7742fcfaf5189de0f2d11d5808641db3f1bdd5 on pauloancheta:master into db43c38f5b6aba0ee8d489118677c43df0782e2d on smeevil:master.

Coverage remained the same at 56.296% when pulling 11acc2c55c1925524ecd22f833c05bd8a1a3f842 on pauloancheta:master into db43c38f5b6aba0ee8d489118677c43df0782e2d on smeevil:master.

thank you :D


Adding Spinner Properties

I have been working on issue #211. Also, to solve some issues with Spinner not having a default value as mentioned in issue #309, I set the initial Selection to the empty string and the initial SelectionIndex to 0.
I have implemented successfully the following properties:
enabled
font bold/size/color
BeforeSelecting event and handler
I need help with the following properties:
background color -- currently I am able to change the background color of the selected item's TextView. This however does not change the color of the whole button and looks unpleasant.
font italic/typeface -- Though these are currently implemented very similarly to Font Bold and TextColor, I cannot figure out why these methods are not working.
text alignment -- There is a very strange bug happening with TextAlignment, if it is not set to the default value, nothing appears in the spinner. I cannot understand why this is happening and would appreciate help with this.
height -- I am still currently working on this.

Hi @ReachAayush thanks for the pull request. I see it's still a work in progress but can you please have a look a the comments inline?
Also, if you need help with something, please also open a thread in the oss forum explaining what's needed. Might get some readers there that won't notice a pull request.

this pull request needs answers to comments. @ReachAayush are you planning on finishing this up or shall I close it?

no reply in a month, closing down.


move unittests outside dojo folder

The unittests are inside the dojo folder, which I think is against recommendation to keep tests in a separate folder, outside of the app sourcecode.
Also, the current django docker image that we build is 939MB large. 115MB of this is occupied by unittests. So by moving the unittests outside the dojo folder we also save on image size (an build time and GitHub Actions build times).
Also added --no-install-recommends where it was not yet used for apt-get install.

Love this idea.  Waiting for the tests to complete...

@mtesauro it's green now

conflicts resolved, tests green.


[$1000] Chat - Copy-pasting emoji names with keyboard shortcut doesn't paste the right emoji name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open an existing chat with a user
Send message
Apply emoji reaction on the sent message
Right-click on the emjoi you applied on the message
Triple click on the emoji name
Press 'Ctrl + C' to copy the name
Open emoji picker & paste the content to the search field

Expected Result:
The right emoji name should be pasted
Actual Result:
Wrong, long emoji name is pasted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/0384bf71-559d-4c5c-9cc1-3d291701b8d7
https://github.com/Expensify/App/assets/43996225/6ce8513a-e2f8-4d3e-805f-e7e2ba246a65
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691060569144289
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01de88e41de20d9ce9
Upwork Job ID:<PHONE_NUMBER>321337344
Last Price Increase: 2023-08-23

Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - Copy-pasting emoji names with keyboard shortcut doesn't paste the right emoji name
What is the root cause of that problem?
Triple click selects avatar's svg style of  nested reaction list

What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/c08d5887b18914d95e64e925bfed290fecfffc94/src/pages/home/report/ReactionList/BaseReactionList.js#L78
Add styles.userSelectNone in this line
style={{maxWidth: variables.mobileResponsiveWidthBreakpoint, ...styles.userSelectNone}}

What alternative solutions did you explore? (Optional)
N/A

Reproduced

Proposal
Please re-state the problem that we are trying to solve in this issue
Copy-pasting emoji names with keyboard shortcut doesn't paste the right emoji name
What is the root cause of that problem?
The function attempts to get the selected text using SelectionScraper.getCurrentSelection() on useCopySelectionHelper.js hooks, but it does not handle the case when an emoji is selected. Instead, it assumes that the selected text is always a non-emoji text.
This leads to incorrect behavior when copying and pasting emoji names, as the function does not properly handle the case when an emoji is selected and tries to convert it to an emoji name.
What changes do you think we should make in order to solve the problem?
In this solution, we are using the getEmojiNameByUnicode function from EmojiUtils to get the emoji name by its Unicode. If an emoji name is found, we wrap it with colons : (which is the standard way to represent emojis in text), otherwise, we use the selected text as it is. This ensures that when an emoji is selected and copied, its name is copied instead of the emoji itself.
import {useEffect} from 'react';
import ExpensiMark from 'expensify-common/lib/ExpensiMark';
import CONST from '../CONST';
import KeyboardShortcut from '../libs/KeyboardShortcut';
import Clipboard from '../libs/Clipboard';
import * as EmojiUtils from '../libs/EmojiUtils'; // Add EmojiUtils
import SelectionScraper from '../libs/SelectionScraper';

function copySelectionToClipboard() {
    const selection = SelectionScraper.getCurrentSelection();
    if (!selection) {
        return;
    }
    const parser = new ExpensiMark();
    const selectedEmojiName = EmojiUtils.getEmojiNameByUnicode(selection); //handleEmojiUnicode
    const textToCopy = selectedEmojiName ? `:${selectedEmojiName}:` : parser.htmlToMarkdown(selection); //copied text
    if (!Clipboard.canSetHtml()) {
        Clipboard.setString(textToCopy); //set textToCopy
        return;
    }
    Clipboard.setHtml(selection, parser.htmlToText(selection));
}

export default function useCopySelectionHelper() {
    useEffect(() => {
        const copyShortcutConfig = CONST.KEYBOARD_SHORTCUTS.COPY;
        const unsubscribeCopyShortcut = KeyboardShortcut.subscribe(
            copyShortcutConfig.shortcutKey,
            copySelectionToClipboard,
            copyShortcutConfig.descriptionKey,
            copyShortcutConfig.modifiers,
            false,
        );

        return unsubscribeCopyShortcut;
    }, []);
}

What alternative solutions did you explore? (Optional)
None
Demo
https://github.com/Expensify/App/assets/20473526/6b61f4e3-186f-4805-841a-44551085a7ac
cc: @eVoloshchak

@studentofcoding you need to triple-click so that the colons on each side (and hidden text) are copied. Just copying the text is not broken

Okee @joh42, the triple-click (or copy of all the colons) is covered in my solution too ;)

Heading ooo for a week - @sakluger, we're still in the proposal review stage here, so no action required from you at the moment. I can take this back over next week when I return.

Assigning a new C+ to keep this moving forward. @sobitneupane could you please review the proposals we've received so far? Thanks!

I will review the proposals today.

@sobitneupane were you able to review proposals?

Thanks for the proposal everyone.
Proposal from @bernhardoj looks good to me.
🎀 👀 🎀 C+ reviewed

Thanks for the proposal everyone.
Proposal from @bernhardoj looks good to me.
🎀 👀 🎀 C+ reviewed

Can you share why we have to do such a complicated changes where we only needed to include getEmojiByUnicode function like I Proposed ? Thanks

@studentofcoding The issue is not confined to emoji only. Please go through the RCA section of the proposal for other instances of the issue.

As I recall, the expected behavior should be pasting the Emoji name with the : symbol
And for this could you share why we pursue A manual implementation of dom & nodes (that more like workaround) when we can simply use our EmojiUtils function instead?
Am I missing something @sobitneupane ?

And for this could you share why we pursue A manual implementation of dom & nodes (that more like workaround) when we can simply use our EmojiUtils function instead?

@studentofcoding We always try to find the root cause and solve the issue there. Root Cause Analysis in this proposal looks promising. Please let us know if you find any issue with the solution.

The thing is

The video demonstration is not on Emoji selection rather than a profile selection, when we only need to use EmojiUtils.getEmojiUnicode to handle the case, instead of changing (with my RCA reasoning below) as introducing changes into SelectionScraper file might introduce regression & as we might want to keep the behavior on another component

The function attempts to get the selected text using SelectionScraper.getCurrentSelection() on useCopySelectionHelper.js hooks, but it does not handle the case when an emoji is selected. Instead, it assumes that the selected text is always a non-emoji text.`

But it's just my concern, and whoever gets selected, it's serve the same result

@sakluger @bfitzexpensify this bug feels like a waste of time to me.

@marcaaron I agree, I didn't look too closely at the issue when it was reassigned to me. I'm not sure if anyone actually would copy the emoji name from that menu in real life, and if they did, it would likely be someone who could figure out how to edit the name to work properly.

Could you share more why this is a waste of time @marcaaron ?
Also given mind that the user can and possibly do this, that behaviour itself its making this bug valid, no @sakluger ?
Im just want to ask and clarify things as its not clear why its abruptly being closed where this is a valid bug
Thanks

I'd give the same reasoning as @sakluger. It's just not really something that a user seems like they would do.  I don't think anyone has said it's "invalid" though. The complexity in fixing it don't align with the value we would get by fixing it.

I'd give the same reasoning as @sakluger. It's just not really something that a user seems like they would do.  I don't think anyone has said it's "invalid" though. The complexity in fixing it don't align with the value we would get by fixing it.

I beg to differ on the complexity in fixing it. In the end its just a simple fix, with using 'getEmojiNameByUnicode' from 'EmojiUtils'
With this in mind, did it really wasting the effort here?

Apologies in advance if I'm not aligned with anyone's opinion.
I personally don't find this issue valuable to fix since it's not something a user will do in most cases.
I'd say if we keep on fixing such bugs saying simple or small then we will end up with not utilising available resources (C++ & internal team time, then testing team time and of course money is another player in the game).
Since we already reduced bounty price to make open source sustainable for long run.

Thats totally ok, and I understand you POV, especially for Issue after the price reduction is announced
But in this case, 1. Its not a part of price reduction, and 2. Its a still a valid bug, and The solution is simple. Its just dont fair for external contributor, to close and change the procedure middle way dont you think?
On another aspect, I think I and @bernhardoj will understand if this issue are decreased to half ($500) as we also have a mechanism for low-priority bug

I'll wait for Internal Team to shed a light on this

I'll defer to @sobitneupane as they should be managing this issue and selecting a proposal. The linked proposal has 3 different solutions. There is also various discussion happening and challenges to that proposal.
@sobitneupane Please be decisive, manage this conversation, and offer us a path forward. If the final proposal is clear and looks easy to implement then I will agree to reopen it and get it done.

I agree with @marcaaron and @sakluger. I don't think the issue carries much value. The reproduction step are very specific and rare. So, my vote is on closing the issue.


kv.namespaces.bulk.delete is missing body param

Seen here, the body param, which is a string array, is missing from the typescript definition. This is probably because it's a raw array without an object wrapper.
https://github.com/cloudflare/cloudflare-typescript/blob/5aef60e067b25d21faac8b0a2786b281928a1f7c/src/resources/kv/namespaces/bulk.ts#L104-L109

Based on our understanding of the HTTP spec (RFC9110) a DELETE method shouldn't have a request body param, it is likely to be an error in Cloudflare's OpenAPI spec file.
We are still discussing how to approach this situation, I will follow-up once I have more details.


Disabled not affecting TextBox inside NumberBox

Before you start...

[X] Have you updated your dependencies? You might be using an old version of the library.
[X] Have you checked for an existing issue on this topic? If there is one, post a comment on it instead.

What browsers are you seeing the problem on?
Microsoft Edge
Description
When using the property disabled of NumberBox, we can still update the text inside the TextBox, whether the property is true or false.
Steps To Reproduce
No response
Expected behavior
When disabled is set to true, we should not be able to update the text inside the TextBox.
Relevant Assets
No response

Thanks for finding this! I've located the issue and fixed it locally; will keep you updated.

Have pushed a fix; expect it to be working in the next release.

Hello @Tropix126
When do you expect to publish a new version of the lib?

I plan for it to be out by the end of today :)

Fixed as of 1.3.0.


fix: invariant culture for version field

Writing version field depends on current system culture
version: '1.13.0' for en-US
version: 1.13.0 for en-GB
existing workaround:
set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT environment variable
https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode

It looks like one of the checks is not able to report status. How can I force to restart the check?


Mappers are not used for union types

GraphQL schema:
type A {
  id: ID!
  a: Int!
}

type B {
  id: ID!
  b: Int!
}

union AOrB = A | B

codegen config:
mappers:
  A: ./types#MyA
  B: ./types#MyB

Expected behavior
The union AOrB type should be automatically mapped to MyA | MyB, but it doesn't.
A quick workaround is to manually map it like this:
mappers:
  A: ./types#MyA
  B: ./types#MyB
  AOrB: ./types#MyAOrB

where MyAOrB is simply MyA | MyB.

I see, so what you are asking for is a way to have a mapper for the entire union? For a use case where you have a third custom type, that represents the possible implementation of A and B?

Not exactly, it's already possible to have a custom mapper for a union type:
  AOrB: ./types#MyAOrB

The previous snipped declares a custom mapper for the AOrB union type and works fine.
The issue is that if don't declare mappers for each and every union the codegen won't automatically use their base type mappers when it generates the typings for the unions.
In short without the previous snippet AOrB would be just A | B instead of MyA | MyB, while if I specify mappers for the base types of a union those should be automatically used for the union itself.

@dotansimha it looks like it works if you return a union on the top level of a query, but if you return a type which returns a union (like for example a paginated list) it won't
union AOrB = A | B

type Connection {
  count: Int!
  edges: [Edge!]!
  pageInfo: PageInfo!
}

type Edge {
  cursor: DateTime!
  node: AOrB!
}

type PageInfo {
  startCursor: DateTime
  endCursor: DateTime
  hasNextPage: Boolean!
  hasPreviousPage: Boolean!
}

extend type Query {
  simple: AOrB!
  paginated(
    first: Int
    last: Int
    after: DateTime
    before: DateTime
  ): Connection!
}

In the previous example simple will work, but paginated won't.

I think maybe Omit is missing there? I'll add a test to make sure. Thanks @darkbasic

@darkbasic still not able to reproduce....
I have this schema, with an explicit usage of the union, but also a proxied one:
        type Query {
          explicitUnion: U!
          proxyToUnion: UnionProxy!
        }

        union U = A | B

        type UnionProxy {
          u: U
        }

        type A {
          a: String
        }

        type B {
          b: String
        }

I created mappers for the types only:
      const config = {
        noSchemaStitching: true,
        mappers: {
          A: 'number',
          B: 'number',
        },
      };

The output code is:
export type ResolversTypes = {
  String: ResolverTypeWrapper<Scalars['String']>;
  Boolean: ResolverTypeWrapper<Scalars['Boolean']>;
  Query: ResolverTypeWrapper<{}>;
  U: ResolversTypes['A'] | ResolversTypes['B'];
  UnionProxy: ResolverTypeWrapper<Omit<UnionProxy, 'u'> & { u?: Maybe<ResolversTypes['U']> }>;
  A: ResolverTypeWrapper<number>;
  B: ResolverTypeWrapper<number>;
};

And the resolvers code is using Omit correctly to replace all usages of the union original type, and replace it with the resolvers relevant types (see UnionProxy).
Also, the Query type is using it correctly:
export type QueryResolvers<ContextType = any, ParentType extends ResolversParentTypes['Query'] = ResolversParentTypes['Query']> = {
  explicitUnion?: Resolver<ResolversTypes['U'], ParentType, ContextType>;
  proxyToUnion?: Resolver<ResolversTypes['UnionProxy'], ParentType, ContextType>;
};

I tried to create a code that replicates that exact usage, and return the mapped values in all possible forms, it always works when I returns the mapped value:
const resolvers: Resolvers = {
  Query: {
    explicitUnion: () => {
      return 10; // works
    },
    proxyToUnion: () => {
      return {
        u: 10 // works
      };
    }
  },
  UnionProxy: {
    u: () => {
      return 10; // works
    },
  }
}

You can find a working output here in TS Playground
@darkbasic can you please create a reproduction in a codesandbox? we have a template here: https://codesandbox.io/s/github/dotansimha/graphql-code-generator-issue-sandbox-template

@dotansimha unfortunately the codesandbox gives me 502, so I uploaded a repro on github: https://github.com/darkbasic/codegen-gh3979
Try to comment out the following (https://github.com/darkbasic/codegen-gh3979/blob/master/codegen.yml#L14) and paginated will error out because of typings (https://github.com/darkbasic/codegen-gh3979/blob/master/src/resolvers.ts#L18)

@darkbasic I think this PR also fixes your issue: https://github.com/dotansimha/graphql-code-generator/pull/4531 (since it changes the order of mapper checking, so I think it should work for unions as well).

Fixed in<EMAIL_ADDRESS>

I think there was a regression since I'm now seeing this in<EMAIL_ADDRESS>


[Dev Task] [Activity Logs Consolidation] LogAggregatorAPI - Strategy to retrieve  ListSubsequentActivityLogs and ListCorrelatedActivityLogs  for Activity logs

Introduction
The MessagingStrategy for ListPremierActivityLogs and ListCorrelatedActivityLogs is designed to handle data retrieving for view Activity logs. This strategy will be invoked by the management portal API through RabbitMQ using MassTransit.
Suggested Code Changes

Implement ListPremierActivityLogsStrategy.cs
File: KN.KI.LogAggregator.Application > Masstransit > MessagingStrategy > ListPremierActivityLogsStrategy.cs

Dependencies:

IInterserviceRequestMsg: Interface for managing job operations.

Output: ListPremierActivityLogsResponse

Properties:

Message: A message indicating the result of the operation.
IsError: A boolean indicating whether an error occurred.
ErrorMessage: Details of the error, if any.

Implement ListCorrelatedActivityLogsStrategy.cs
File: KN.KI.LogAggregator.Application > Masstransit > MessagingStrategy > ListCorrelatedActivityLogsStrategy.cs

Dependencies:

IInterserviceRequestMsg: Interface for managing job operations.

Output: ListCorrelatedActivityLogsResponse

Properties:

Message: A message indicating the result of the operation.
IsError: A boolean indicating whether an error occurred.
ErrorMessage: Details of the error, if any.

Expected Output

Success:

For ListPremierActivityLogsStrategy. Response Type: ListPremierActivityLogsResponse

Message: Empty string
IsError: false
ErrorMessage: null

For ListCorrelatedActivityLogsStrategy.  Response Type: ListCorrelatedActivityLogsResponse

Message: Empty string
IsError: false
ErrorMessage: null

Error:

Returns a standard error response with details of the issue.

Unit Tests

Not Applicable (N/A)

Impacted Components

Not Applicable (N/A)

Dependent Tasks

Not Applicable (N/A)


low latency live stream, recommended settings?

i'd like to live-stream content with as little latency as possible, even if it causes occasional stutter or choppiness. what configuration options do you recommend?

The important pieces for this kind of a steam would be in the manifest itself.  If we're talking about DASH, I would suggest:

(highly recommended) Use SegmentTemplate with duration.  This ensures that we don't need to do manifest updates to learn about future segments.  The manifest will include info about all future segments.
If you must use SegmentTimeline or SegmentList, set a low minimumUpdatePeriod.  The spec says 0 is valid, but we will override it with a minimum of 3 seconds between updates.  If you use SegmentTemplate with duration, set this to a high value to avoid useless network activity.
Set a low minBufferTime.  This allows faster recovery from stalls by allowing us to start playing with less content, at the cost of a higher chance of another stall.
Use short segment sizes.  It is common to use 2 second segments for live streams.  You could reduce that to 1 to reduce delay.  But that will only help if we don't require manifest updates.
Set a value of suggestedPresentationDelay.  If you don't set it, we will pick a default of 1.5 times minBufferTime.  This affects the delay between the calculated live edge and the one we use.  A lower value will make us play closer to the real live edge, but we will stall more if the segments aren't available yet.
Make sure you have a UTCTiming element for clock-sync.

You should look at the documentation of your packager to see how to set these values in your live stream.
The only real Player setting that would affect latency would be streaming.rebufferingGoal.  It is similar to minBufferTime, setting a smaller value will allow us to play with less content.

@gabor does that help? Please let us know if there's anything else we can do for you! Otherwise we'll go ahead and close the issue.

@ismena thank you, this is enough for me, please feel free to close the issue.


Using bind for add/rm change listeners

This isn't an issue in the tutorial the components never actually unmount, but it would break if they did!

eek this isn't right, will have another PR soon


does this actually work?

git clone / python setup.py install
and then?
running an example I get:
ImportError: No module named machinetalk.protobuf.message_pb2

Requires the machinetalk-protobuf libraries.

well yes - but so far no humanly possible way to install them ;)


nvgre parsing

Nvgre output was added by PR #308 Add ST route type.
Is there also a requirement for parsing incoming nvgre packets?

No support for packets coming to the pipeline, they can only go out.
No use for it right now (no implementation for nvgre on ingress), but may be in the future, and we would need to add the code.
Assumption is that 2 DASH devices would not communicate using nvgre.
ST is a tunnel towards a public IP (on the Internet).  Do packets return on nvgre?  Ask @prsunny

Added @pranjal-git in case he may know

Hi @budgrise, on high level, the packet transformation will still follow this doc: https://github.com/sonic-net/DASH/blob/main/documentation/general/sdn-pipeline-basic-elements.md#service-tunneling, and I am sure you are already aware of it:
In my understanding, the return packet will rely on reverse flow to do the transformation:

The return packet will have 2 layers of encaps, which will be all decap'ed before sending to the pipeline. However, this is not modeled today in DASH and our BM, but this is what should be happening.
After decap, the flow matching will only use the 5 tuples from the inner most packet. This will find the reverse flow and apply the transformations.

Hi Bud, I have updated the proposal for making this behavior clarified as well as addressing certain future cases. Please feel free to take a look and let me know what you think: https://github.com/r12f/DASH/blob/user/r12f/pipeline/documentation/general/dash-sai-pipeline-packet-flow.md#54-packet-decap.
The PR can also be found here: https://github.com/sonic-net/DASH/pull/449. Feel free to leave me comments as well! :D

Closing in favor of PR449 per Community Call


Is it possible for OpenSFM to be used in image stitching

Hi,
I use OpenCV to obtain mosaic images, and the there is an example module named stitching in OpenCv to mosaic images. But the problem is that the bundle adjustment functions (BundleAdjusterReproj ) used in OpenCV is time-consuming. So, Is it possible for me to used the OpenSFM to replace BundleAdjusterReproj to improve the performance.
By the way, I am one of the Open Drone Map user, but what is need is just an mosaic image without any geolocation information, the speed of the process is the most important factor.

Why not consider to use Hugin?

great idea, I will try it. But, it seems Hugin is too big for me to obtain what I need.

Do you want to stitch panoramas or aerial images?
If you want panoramas, Hugin should have what you need with a proper UI. OpenSfM assumes that the cameras move and has no support for panoramic sequences at the moment.
If you want to stitch aerial images, Hugin may also work for flat terrains. Otherwise you need to do a 3D reconstruction. OpenDroneMap will do that but quite slowly.

@paulinus aerial images, e.g. UAV. What I want to do is get the stitch aerial images as fast as possible without consider altitude difference, then I will decide if use the OpenDroneMap to do a 3D reconstruction, or get the orthogonal image.
Image Composite Editor provided by Microsoft is a good choice, but it is not an open source software. May be Hugin is one of the good choice.

Both Image Composite Editor and Hugin are designed for panoramas. They can work to some extend for UAV images as long as the terrain is approximately flat.  I would give a try to Hugin.
Another option is to run OpenDroneMap with low resolution images first.

Okay, I will try it later.

I have used the Hugin to stitch the images. But the result was not as good as ICE did.


Active Directory Users do not show up in Rancher UI

I deployed Rancher 2.3.5 clean and built a new cluster.
Setup AD authentication.
I can log in successfully with AD authentication but the users that logged in using AD are not listed under Global/Users so a Role can be assigned or when assigning Members to a cluster resource. That only lists the domain admins group and not all users and groups under the LDAP search root.

Rancher
v2.3.5

User Interface
v2.3.36

Helm
v2.14.3-rancher1

Machine
v0.15.0-rancher29

Users are added to the list, after they logged in to Rancher for the first time. At least this is how it looks like for me.
The user you tested the AD authentification with during setup, is automatically assigned the administrator role c.f. https://rancher.com/docs/rancher/v2.x/en/admin-settings/authentication/ad/#test-authentication

Thanks this is resolved


The train data of BIRD-SQL is uncompressed failed.

I try to uncompress the zip package of train data in BIRD-SQL，but got the follow error message:
unzip train.zip
Archive:  train.zip
creating: train/
inflating: __MACOSX/.train
inflating: train/.DS_Store
inflating: __MACOSX/train/..DS_Store
inflating: train/train_databases.zip
error:  invalid compressed data to inflate
bad CRC b09490af  (should be 2eea441e)
inflating: __MACOSX/train/._train_databases.zip
inflating: train/train.json
inflating: __MACOSX/train/._train.json
inflating: train/train_gold.sql
inflating: __MACOSX/train/._train_gold.sql

This looks like the zip file was damaged due to incomplete download, can it be reproduced by re-downloading it again?

Hi
I have downloaded the train.zip file three times from the given link, but I always get the error "error: invalid zip file with overlapped components (possible zip bomb)" while unzipping it. If I continue unzipping by setting UNZIP_DISABLE_ZIPBOMB_DETECTION=TRUE, about 30 databases turn up empty.
Is it possible to provide the dataset elsewhere? Thanks


Synchronize child records for siblings: professional photo checkbox, date of professional photo

For child records, update the checkbox "professional photo", under Photolisting Information, to add synchronizing functionality between sibling records. Update should be such that:
-when siblings are linked as "must be placed together"
-if "professional photo" is unchecked or checked on a single child's record
-change is reflected on all linked sibling records
-when siblings are first linked together, the status of the "professional photo" checkbox should be set to unchecked
This should also be the case for "date of professional photo" - the date entered on any sibling's record is reflected in all other records. When siblings are first linked together, this field should default to an unset date. If defaulting to an unset date cannot be accomplished, and there are two competing pieces of data when the children are linked, the more recent date should be preferred.

@jeremysMARE doing some clean up of the board and wondering if this story is still an issue/priority?

This would still be a great quality of life improvement to prevent user error.

From: bchiaruttini @.>
Sent: Tuesday, March 23, 2021 9:59 AM
To: mareinc/mare @.>
Cc: Jeremy Smith @.>; Mention @.>
Subject: Re: [mareinc/mare] Synchronize child records for siblings: professional photo checkbox, date of professional photo (#234)
@jeremysMAREhttps://github.com/jeremysMARE doing some clean up of the board and wondering if this story is still an issue/priority?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/mareinc/mare/issues/234#issuecomment-804925884, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRQKZFVSHFQELKYXAJS433TFCNFNANCNFSM4HDMXVDA.


Classes and elements not defined when creating custom node

I am following the "Quick start" tutorial and I have an unexpected error in the "Defining node" section.
Here is simplified version of the tutorial with the error :
from ryven.NENV import *

class PrintNode(Node):
    title = 'Print'
    init_inputs = [
        NodeInputBP(),
    ]

    def update_event(self, inp=-1):
        print(self.input(0))

I have the following error :
Traceback (most recent call last):
  File "c:/Users/xyz/.ryven/packages/xyz/nodes.py", line 4, in <module>
    class PrintNode(Node):
  File "c:/Users/xyz/.ryven/packages/xyz/nodes.py", line 7, in PrintNode
    NodeInputBP(),
TypeError: 'NoneType' object is not callable

Also, I have the same error with the RandNode and dtypes :
    NodeInputBP(dtype=dtypes.Data(default=1))
AttributeError: 'NoneType' object has no attribute 'Data'

I am working with Python 3.7.5 on Windows 10 64 bit.
PS : Great project !

yes, glad you resolved it!


[5.9🍒] Prevent noncopyable metatypes from being converted to Any

• Description: Through a convoluted series of casts, one could possibly cast a noncopyable type's metatype to some existential's metatype and then construct instances of the underlying noncopyable type behind the existential's facade. Those existentials would then be permitted to be copied, which is a Bad Thing.
• Risk: There's not a whole lot the metatype can have done for you given there are very limited existentials or protocols in general that a noncopyable can conform to anyway. So far the only uses I ran into in the compiler were implicit casts to Any while turning NoncopyableType.self into a String to get its name. Simple enough for users to workaround, but does introduce a source break for them.
• Original PR: https://github.com/apple/swift/pull/65606
• Reviewed By: pending
• Testing: regression tests included
• Resolves: rdar://106452518

@swift-ci please test

@swift-ci please test


This is still work in progress.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as permissions, server_permissions.

While we're addressing toxicity, it might be worth to take a look at the self-defined dictionary which among other things list examples of toxic language and ways to replace them, e.g. https://www.selfdefined.app/definitions/sanity-check/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10624/

@pluma: just replaced "sanity check" in many places. I won't have time to scan the whole dictionary.
Let me know of other terms that you think are inadequate.
Thanks!

At a glance we seem to be clear on most of the relevant ones, except for some 3rdParty code that is not under our control. :+1:

@pluma: option names seem to be ok now. The internal code still has a lot of occurrences of the terms "master" and "slave", for the replication. I think I will address this in a separate PR, otherwise this PR will get too big.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10879/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10894/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10897/

Tests blue


Addition of new Module - Azure Active Directory Domain Services(Azure ADDS)

#Adding new module - Azure Active Directory Domain Services(Azure ADDS)

There is no existing module in the list for deploying Azure ADDS. This module can be reused for any new deployments specific to Azure ADD Services.

Type of Change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update (Wiki)

Checklist

[ ] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (readme)
[ ] I did format my code

Hey @mararam that's an awesome contribution. I'll see to review it in depth soon. 👍

Hey @mararam, thanks already for working in the requirements.
To your question if you should resolve the comments: Feel free to do so for the once where I 'added a suggestion'. These kind of comments should allow you to the proposed changes with a press of a button - and in the process auto-resolve the comment.

I have made the changes as requested:

Renamed folder to Microsoft.AAD/DomainServices
Update the references in the pipelines accordingly with renaming the parameter file to parameters.json

Thank you for all the help, guidance and support so far. Appreciate it.

Something is off with the folders ;)

Please remove the duplicates.

I have deleted the stale entries now. please check. Thank you.

For you information @mararam: I opened a follow-up PR to fix some remaining issues I encountered when testing the module and to get it ready for the environment. You may find the updates interesting.


failed to cherry pick PR 3906 from cyclinder, to branch release-v0.9

commits 53dcfeb91aa4d55f1d7b264c5f810d439fa9fe6f of cyclinder conflict when merging to branch release-v0.9, please manually cherry pick it by yourself.
PR https://github.com/spidernet-io/spiderpool/pull/3906 ,  action https://github.com/spidernet-io/spiderpool/actions/runs/10554320193
Auto-merging charts/spiderpool/crds/spiderpool.spidernet.io_spidermultusconfigs.yaml
Auto-merging docs/concepts/coordinator.md
Auto-merging docs/usage/install/overlay/get-started-calico-zh_cn.md
Auto-merging docs/usage/install/overlay/get-started-cilium-zh_cn.md
Auto-merging docs/usage/install/underlay/get-started-macvlan-zh_CN.md
CONFLICT (content): Merge conflict in docs/usage/install/underlay/get-started-macvlan-zh_CN.md
Auto-merging docs/usage/install/underlay/get-started-macvlan.md
CONFLICT (content): Merge conflict in docs/usage/install/underlay/get-started-macvlan.md
Auto-merging docs/usage/install/underlay/get-started-ovs-zh_CN.md
Auto-merging docs/usage/install/underlay/get-started-ovs.md
Auto-merging pkg/k8s/apis/spiderpool.spidernet.io/v2beta1/zz_generated.deepcopy.go
Auto-merging pkg/multuscniconfig/multusconfig_informer.go
CONFLICT (content): Merge conflict in pkg/multuscniconfig/multusconfig_informer.go
Auto-merging pkg/multuscniconfig/utils.go
Auto-merging test/e2e/coordinator/macvlan-overlay-one/macvlan_overlay_one_test.go
error: could not apply 53dcfeb9... Merge pull request #3906 from cyclinder/spidermultusconfig/hostRPFilter
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

https://github.com/spidernet-io/spiderpool/pull/3968


mostly fix Issue 14280 - Links to command line tools have disappeared fr...

...om navigation
Not considered here: overview.html and spec.html.
Adding a new menu section: Compilers & Tools. Adding dmd-windows.html,
rdmd.html, windbg.html, and htod.html. Also adding links to gdc and ldc.
dmd-linux.html, dmd-freebsd.html, and dmd-osx.html can be reached through
dmd-windows.html.
Adding const-faq.html, rationale.html, code_coverage.html, and everything
from SUBNAV_ARTICLES to Books & Articles.
Adding http://wiki.dlang.org/Editors, http://wiki.dlang.org/IDEs, and
glossary.html to Resources.
http://digitalmars.com/ctg/optlink.html is already linked from
dmd-windows.html, good enough.
http://digitalmars.com/ctg/trace.html is already linked from dmd-*.html,
good enough.
Leaving debugger.html dead.
Leaving features2.html and ascii-table.html orphaned, because they don't
add value.
Leaving appendices.html and memory.html orphaned, because they're just
redirects.

A shot of the new menu section:

This has a little issue: on dmd-{linux,freebsd,osx}.html the Compiler & Tools section isn't expanded. That's because the URL doesn't match, of course. I'm not sure how to tackle this.

In general we need to look closely at all the "missing" pages. Many of them were removed purposefully, because they are now outdated. Adding them back may not be a good move.

In general we need to look closely at all the "missing" pages. Many of them were removed purposefully, because they are now outdated. Adding them back may not be a good move.

After a fuck-up like this, I think the emergency action should be to bring stuff back. Weeding out can happen later.

OK I'm fine with the additions. Thanks.

Only listing dmd-windows doesn't make sense.
I think those pages should become clear installation instruction and should be linked to from the download page, right after each OS.
And the rest should be submenus of Download.


makeImageSnapshot crashes Android app

Description
See Snack for reference code
When invoking makeImageSnapshot directly when a component loads, directly an snapshot is captured from the visible canvas using the useAnimatedReaction hook. However, the app crashes immediately. In sentry I can see that it is a segmentation fault.
When I am running makeImageSnapshot after trigger it by a separate button at a later moment, the app doesn't crash.
Version
1.3.9
Steps to reproduce
Run example with and without line 54 commented out.
Snack, code example, screenshot, or link to a repository
this snack was tested using a development build in a local repo instead, due to the dependencies

I believe I'm encountering the same issue on iOS. It seems to me that the issue is with the API — there's no way to tell when the Skia view has finished rendering. If I do this:
const handleLayout = () => {
    const image = canvasRef.current?.makeImageSnapshot()
}

return (
    <Canvas
        ref={canvasRef}
        onLayout={handleLayout}
    />
)

It seems like there's a race condition — sometimes the snapshot is taken successfully, other times the app crashes with a "no Skia view available" error. It seems like all I can do is wrap the makeImageSnapshot in a timeout.

This should be fixed in v1.6.0, if not please let me know.


Alamofire 4.0 doesn't send Authorization header when following redirects

I'm using a token-based authentication for my client app, but Alamofire doesn't sends authorization headers when following redirects so the server responds Forbidden
When I try sending this request manually from postman or even curl command in terminal, everything works as well, so what should I do with that problem?
I'm using Alamofire 4.0 and swift 3

This is just the way things work on Apple platforms with the Authorization header. The reason (we think) that Apple doesn't automatically pass that header through is that some servers will reject the redirected request if it contains the Authorization header and shouldn't.
We actually already have a test for this behavior as well as the implementation for how to modify the session delegate to actually pass that header through. If you implement something similar to that logic in your app, you should be good to go.
Cheers. 🍻


Error when running npm install

I just cloned the repo and when I run npm install, I get:
npm http 404 https://registry.npmjs.org/angular/core/2.0.0-rc.0
npm ERR! 404 'angular' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it

Should I change something? Thanks!

Should work. Just tried it for RC1.  What version of node and npm are you using?
That link seems weird. Where did that come from?  I don't see the leading @ in front of Angular
You can download that package specifically with<EMAIL_ADDRESS>Closing because can't repro

I tried it again, and it did work. Not sure how I broke it before. Thanks.


WebGL / Implement the line-metric operator to apply styles/filter along a line

This Pull Request implements the ['line-metric'] operator, which returns the M value alongside a LineString. This can be used to filter parts of a line, change its color, etc. When no M component is available (e.g. the LineString has an XY or XYZ layout), the operator returns 0.
To implement this operator the following changes were made in the WebGL rendering pipeline:

instead of storing LineString coordinates as [x, y] in the WebGL buffers, we store them as [x, y, m]
the default LineString shaders were adapted to read the new M component, which is interpolated between vertices of a LineString
because of the way the LineString buffers are built, the memory consumption for these geometries is increased by up to 20-25%

A new example as well as a rendering test were added, see:
https://deploy-preview-15961--ol-site.netlify.app/en/latest/examples/filter-webgl-line.html

Todo:

[x] fix rendering test (failing)
[x] improve the example

Done in pair-programming with @jahow
Follow-up of https://github.com/openlayers/openlayers/discussions/15790

This is now ready for review, please let us know if anything more is required to help with reviewing. Thanks a lot in advance

thanks for the review @fredj !!


Update server-side Blazor template LogOut endpoint to require POST

We shouldn't use GET because it's not idempotent.
Additionally, POST means that same-site cookies won't be included in the request if sent from another origin.

Done in #12419


Power down function HELTEC Wireless Tracker

Hello,
The power down function in the menu doesn't seem to work on the HELTEC Wireless Tracker.
Probably some other boards have more buttons?
Software power down would be handy when installing the tracker into a case without a physical on/off switch.
Best regards,
Mark

I also agree with this request. This feature would be useful, like in the Meshstatic software.
Best regards
Matteo IZ1HMT

this was yesterday added...
all NON T-Beam boards will go into DEEP SLEEP using less than 1mA of current (as there is no physical switch you should know that eventually if the board is left un-used the battery will dischard fully and be damaged) but a less than 1mA current consumption rate it should last easy more than 80 days with 2200mA battery and still be ok)
to powerOff: triple press user button
last firmware = 2024.05.30

Thank you very much (also for pointing out the 1mA current while "off")
Best regards and keep up the good work!
Mark PC9DB


add @ignore to testInterestPostingForSavingsJobOutcome

added @ignore to testInterestPostingForSavingsJobOutcome due to consecutive failing in two builds (https://travis-ci.org/github/apache/fineract/builds/680976084) and (https://travis-ci.org/github/apache/fineract/builds/682249846) in #738

@rrpawar96 Tx! FYI there are 2 more failing on #789, I'm just ignoring those as well.


Main navigation bar

https://housingbayarea.mtc.ca.gov/ (and everywhere on the site)
Issue 1:

Issue: Expandable main nav dropdown links (Help Center & Partners) not activating when using tab key
Fix: These should be activated by the tab key

Issue 2:

Issue: Help Center and Partners drop down buttons on main nav do not communicate to screen reader users that they're expandable.
Fix: Add a nested navigation menu to the main nav for the both button which will communicate to screen reader users that it's expandable and the current state, expanded or collapsed as well as how many list items.

Issue 3:

Issue: Using keyboard navigation, once I open the nav bar’s dropdown menu, I should be able to use the arrow keys to navigate through the items but i can’t.
Fix: I should be able to navigate through the dropdown with my arrow keys once it's selected.

Can we just build the new, simplified header that Jesse is proposing?


Not able to install clippy-sarif

Hello,
Tried to install clippy-sarif using cargo command:
cargo install clippy-sarif

Got below errors:
...
error[E0599]: no method named `about` found for struct `Arg` in the current scope
  --> /home/yongyan/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy-sarif-0.2.20/src/bin.rs:90:18
   |
90 |                 .about("input file; reads from stdin if none is given")
   |                  ^^^^^ method not found in `Arg<'_>`

error[E0599]: no method named `about` found for struct `Arg` in the current scope
  --> /home/yongyan/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy-sarif-0.2.20/src/bin.rs:95:18
   |
95 |                 .about("output file; writes to stdout if none is given")
   |                  ^^^^^ method not found in `Arg<'_>`

For more information about this error, try `rustc --explain E0599`.
error: failed to compile `clippy-sarif v0.2.20`, intermediate artifacts can be found at `/tmp/cargo-installg97K0W`

Caused by:
  could not compile `clippy-sarif` due to 2 previous errors
...

Got similar errors installing sarif-fmt and other components under sarif-rs. Please take a look.

hi, @yongyan-gh  thank you fore reporting, this should be fixed with version 0.2.21. sorry for the delay i was mostly away from the computer during the holidays and had a bit of a backlog.
if you still run into issues, please feel free tor re-open!


Feature/support bazarr

Description of the change
Support Bazarr metrics
Most of the changes are isolated to bazarr specific code flow except the change around the param handling,
see this commit
I think this change should be safe as itll just work as it did before without any ,
This was required as i couldn't figure out any way to provide multiple ids to the same parameter. as without it the pull was talking around 10 minutes (getting all series, looping all series then having to get all episodes then looping those ), after pulling all episodes at once it went down to 20 seconds and bazaars api doesnt support getting all items.
Also added a makefile for quick dev "up and go", but i can revert this and add it to the gitignore if you prefer
Possible drawbacks
requires changes in https://github.com/morpheus65535/bazarr/pull/2252 to support filesize and support /v1
Applicable issues
closes #6
Additional information

Still need todo the tests but wanted to get some eyes on this in its current state.
i gave async a go (similar to how the sab collector does things) but it actually ran slower so i ditched those changes.
it sits at around 210/220 MB when its scrapping incase memory needs to be benchmarked
Also this is my second time playing with golang so i open to any feedback
Thanks!

I'll have a closer look at this early October when I'm back home. Sorry for the delay.

@onedr0p no rush :)

Question for when you review, would it be okay to lax the requirement for an api version? turns out aliasing the api is impossible bazarr side due to the framework it uses just does not allowing alaising for some reason..

I believe that should be fine, bazarr is a bit bazaar so I'm sure there are some things like this that don't carry over from the other arr apps that well.

The test failure is just yelling because go.mod isn't consistent with the code. if you run go mod tidy real quick, that test should pass.

thanks for the reviews gang
@onedr0p no more code to commit.
i agree interms of maintenance feel free to ping me if there are issues with the bazarr provider reported.
ill fix up the tests later today

@rtrox my bad, i initially made the change to the workflow thinking it would let me run tests per commit.  then forgot that it wasn't actually running due to me not being a valid contributor yet.
Will update the tests for the rest of the providers in a few days and revert that change if it isnt done already


Added func SetUpConn that wraps SetUp and returns ircConn plus bot

Added a new function, "SetUpConn" that addresses #72 .

Coverage remained the same at 96.748% when pulling 104e7e2eaae9f60a35c2ee965100002ea9fd2074 on oddlid:master into 3e6edb86f5c95cffb7a8fa6767f4ec3b04613ad2 on go-chat-bot:master.


changed snackbar notication hook to custom notification hook

Notes for Reviewers
This PR fixes #8512
this pr changed snackbar hook to custom hook
Signed commits

[x] Yes, I signed my commits.

@aabidsofi19 please take a look.

@EraKin575  sorry to say but you and Rajdip  have worked on common changes ( i clearly told not to )   so  i would like you to slow down as he has finished it in all places now . dont worry i will assign you some other issue  .

@EraKin575 sorry to say but you and Rajdip have worked on common changes ( i clearly told not to ) so i would like you to slow down as he has finished it in all places now . dont worry i will assign you some other issue .

@aabidsofi19 oh. Alright, no worries.I will work on another assigned issues


Precompile fails with >64 threads

This line fails: https://github.com/JuliaSIMD/CheapThreads.jl/blob/master/src/CheapThreads.jl#L21 if dynamic_thread_count() is greater than 64. For example, (1 << (65 - 1)) - 1 == -1, which can't be stuffed into a UInt128. Casting the leftmost 1 to a UInt128 at least allow the precompile to work, but I don't know if that is actually correct in the context of the package.

Can reset_workers! and the call to it in __init__ just be removed? It isn't used anywhere from what I can tell.
Is WORKERS meant to be a bitfield describing the status of each thread? If so, even a UInt128 won't work when there are >128 threads. BigInt would work, but is slow even with bit bashing tricks.
This is currently preventing me from using LoopVectorization on certain machines.

Yes, the integer is a bitfield describing the status of each thread.
Regarding supporting >128 threads, it seems like I'll need to add UInt256 and UInt512 support, or maybe cap the number of threads used to 128 as a temporary workaround (better than throwing an error).
The actual integer type used will depend on how many threads the host computer has, so adding UInt512 (for example) support won't impact performance on systems with fewer threads.

Oops, I see, WORKERS is indirectly referenced via worker_pointer. Maybe WORKERS could be an array or tuple of UInt128s? It seems like a tuple of several could be still be somewhat efficient with compiler unrolling. Definitely more cumbersome, though.
Maybe a stopgap is to just cap the number of threads to 64/128 for now?

Yeah, actually a tuple of UInt128 would be best. Most computers support 128 bit atomic instructions, and we don't really need more than that to be atomic at a time (i.e., 2x 128 bit atomic operations is fine).

For now, this should fix <=128 threads:
https://github.com/JuliaSIMD/CheapThreads.jl/commit/efd59078593373c71938f5699daeb5713f248323

Awesome, thanks.

I notice with this change that:
julia> (one(UInt128) << (128 - one(UInt128))) - one(UInt128)
0x7fffffffffffffffffffffffffffffff

julia> (one(UInt128) << (256 - one(UInt128))) - one(UInt128)
0xffffffffffffffffffffffffffffffff

So this compiles with >128 threads, but it seems like it won't work right. Does a 128 in the min in dynamic_thread_count fix things?
Also, is the leading bit meant to be 0 in the 128 case? The mismatch between dynamic_thread_count and the number of threads managed by WORKERS seems odd, but I could see that being on purpose so that you're leaving at least one thread open for the caller.

Also, is the leading bit meant to be 0 in the 128 case? The mismatch between dynamic_thread_count and the number of threads managed by WORKERS seems odd, but I could see that being on purpose so that you're leaving at least one thread open for the caller.

Yes. It's strongly recomended that when using ThreadingUtilities and CheapThreads that, when wanting to run a program on N threads, you have the main thread launch N-1 threads, and then have it run the Nth chunk itself.
LoopVectorization.@avxt, Octavian.matmul!, and CheapThreads.batch/CheapThreads.@batch all do this.
The reason for this is that ThreadingUtilities.wait uses a spin and wait loop. That thread is blocked but does not go to sleep.
It's thus best to minimize the amount of time spent having any thread waiting, e.g. by having it do one of the chunks of worse first.

No idea what the implications are.

That should be fine.

Ok, thanks for the explanation. The big picture makes a lot of sense.
I'll test this tomorrow with my Tullio / LoopVectorization code on a 128 core / 256 thread machine.

Given that 256 threads didn't work locally (on a 10 core/20 thread machine), I'm not optimistic.
I'll leave this open until CheapThreads supports >128 threads by either switching to

Using NTuple{N,UInt128} to describe worker states.
Switches to decentralized thread management.

Although I'd probably create a new library if/when I wanted to pursue "2.".
Also, I'm curious how well threading works generally on your 128 / 256 thread machine.
A lot of code I work on that uses multithreading (built on Threads.@spawn or Threads.@threads) ends up with 50-80% GC time on an 18 core/36 thread machine, and I imagine this will only get worse.

Yeah, the GC can rapidly become an issue in heavily allocating code. I've generally pursued threading over Distributed due to long process start up times and/or needing reductions over many fairly large arrays. In very highly parallel code I've mostly opted for higher levels of abstraction than direct Threads.@spawn calls. For the problems it fits into, Tullio makes scaling pretty easy. ThreadsX and Transducers require some more effort to avoid allocations, but I've used them to solve some problems that would be impossible in Matlab/Python and difficult in C/C++.
I have noticed some weird plateaus that I think are hardware specific. The machine is a dual socket AMD Epyc server, and things start to seem to scale worse after 64 threads. I'm guessing it has something to do with spilling threads across sockets, but even threaded code with almost no inter-tread communication slows down. It could also be something with AMD's chiplet architecture, I suppose. I have no idea how Linux assigns threads to cores with this somewhat unusual hardware set up.
It would be nice if Julia's GC scaled better with multithreaded code, but I'm sure that's a huge undertaking. Some libraries that helped with setting up preallocation would help. For example, I think thread-safe lazy memory pools would be really nice for avoiding excessive preallocation in code with nested tasks.


Startup error, logs requested, no noticeable problems

I was just informed that I had a startup error and that I should send you my logs! I haven't really noticed any bad behavior, though, so... shrug
Feel free to close.
my log id: 11574b761009d1fa3ea0a71c

I got the same thing when my laptop came back from suspend.  Never saw it before upgrading this evening.  @cjb?

It was added by @MarcoPolo yesterday, I think for situations where the service fails to answer a getConfig RPC.


Provide information on valid config file options and values

please complete the following information:

OS version: Ubuntu 20.04
Editor: vscode
Editor version:	1.74.3
Programming language: js, php
TabNine extension version: 3.6.36
Engine version (could be located within Tabnine Hub): 4.4.225-60

Issue Details:
Since the removal of the user-friendly preferences option (a backwards move imo), we are left with having to edit  the tabnine_config.json file manually.  Ok, we're programmers, no problem, right?  Well, the problem comes that we don't know what all the options necessarily do within this config file, nor what the valid values for the options are.  Since this is now our only way to configure most Tabnine preferences, it would be helpful if this information was readily available and easily accessible, somehow.  A help page on the website, a wiki page in GitHub, something.

(related to Zendesk ticket #20996)

(related to Zendesk ticket #20996)

(related to Zendesk ticket #20996)

Hi @oldmansutton
Our product team would like to understand what exactly would you like to configure/change in Tabnine. Can you please attend a 15 minutes session with Daniel from our product team? If so, please make your appointment here

Highly unlikely that I can take time out from my workday.  The issue isn't that I'm looking to change something specifically, the issue is that I have no idea what I CAN change, what the various options (keys in the JSON file) DO, or what the available values for these keys ARE.  The product USED to have a user friendly configuration, now people are pointed to the .json file to configure TabNine, but the .json file is a black box.

@oldmansutton Thanks. At the moment, Tabnine configuration is only via the Hub. In the past, we let users change some keys in the config file only for technicality, but it is not available anymore. We encourage you to meet with our product manager to help us understand your exact needs from Tabnine.

@TzufTabnine I'm sorry, but Tabnine configuration is NOT only via the Hub, please reference Issue 541 for example, where we are required to use the config file to change basic options.
Since we are forced to manually update the config file, I really don't think it's asking a whole heck of a lot to know what is in that file.


Missing joinExit and Swap events

I'm querying the subgraph to get joinExit and Swap events for pool address 0xA6F548DF93de924d73be7D25dC02554c6bD66dB5; however, there appear to be missing entries when comparing the results to asset quantities in the pool over time.
For example, see the following log:
2022-05-11 06:28:00 2022-05-11 06:29:00
INITIAL QUANTITY: [ 1881.10637688 24899.32022098]
QUOTE: [0. 0.]
POOL FEE: [0. 0.]
FINAL_QUANTITY: [ 2131.29363868 28211.1628769 ]

In order for the asset quantities to change in this way, there has to be at least one quote (LP event) in the period.
The events show up correctly when querying mainnet logs directly; however this approach is slower and would prefer to get data from the subgraph, any ideas what's happening here?
My query strings to get joinExit events:
query_string = f"""
            query {{
                joinExits(
                    where: {{pool: "{pool_id}", timestamp_gte: {int(start.timestamp())}, timestamp_lt: {int(end.timestamp())}}}
                ) {{
                    type,
                    amounts,
                    timestamp,
                    pool {{
                        tokens {{
                            symbol
                        }}
                    }}
                }}
            }}
        """

and for swaps:
query_string = f"""
            query {{
                swaps(
                    where: {{poolId: "{pool_id}", timestamp_gte: {int(start.timestamp())}, timestamp_lt: {int(end.timestamp())}}}
                ) {{
                    tokenInSym,
                    tokenOutSym,
                    tokenAmountIn,
                    tokenAmountOut,
                    timestamp,
                }}
            }}
        """

How are you fetching those initial and final quantities? This query seems to return consistent amounts: the balances don't change between the timestamps you mention, and there's no activity in the pool

Agreed I probably did something wrong with asynchronous requesting, apologies, we've moved to directly reading on-chain anyway to get closer to the source of truth, thanks for replying! :)


chore(RHTAPWATCH-160): Run SAST checks for each opened PR

Description

Run SAST checks for each opened PR

Issue ticket number and link
RHTAPWATCH-160
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key (if applicable)
[ ] I have updated labels (if needed)

please rebase and resolve conflicts

@Kousalya1998 it seems like the pre-commit checks are not running\stuck.
also you should resolve the conflict with the pre-commit-config file, it may help.

@Omeramsc I resolved the conflicts but the CI keeps failing

@Omeramsc I resolved the conflicts but the CI keeps failing

one failure is gitlint. You need to fix the commit message (missing colon after the closing brackets)

@Omeramsc I resolved the conflicts but the CI keeps failing

one failure is gitlint. You need to fix the commit message (missing colon after the closing brackets)

Updated. Thanks.

@Omeramsc I resolved the conflicts but the CI keeps failing

one failure is gitlint. You need to fix the commit message (missing colon after the closing brackets)

The second one is about the revision. It tells which release of the pluging repo should be taken. You need to open the URL mentioned under repo and on the right you'd see Releases. You need to take the latest one from there. The one you have at the moment does not exist.

@Omeramsc I resolved the conflicts but the CI keeps failing

one failure is gitlint. You need to fix the commit message (missing colon after the closing brackets)

The second one is about the revision. It tells which release of the plugin repo should be taken. You need to open the URL mentioned under repo and on the right you'd see Releases. You need to take the latest one from there. The one you have at the moment does not exist.

Okay added v0.5.0

@Kousalya1998 still need to fix multiple CI failures.

/retest

go-sec-mod...............................................................Failed
- hook id: go-sec-mod
- duration: 0.01s
- exit code: 1

error: command not found: gosec

seems like this check still fails

Updated the code. Ignore this version.

go-sec-mod...............................................................Failed
- hook id: go-sec-mod
- duration: 0.01s
- exit code: 1

error: command not found: gosec

seems like this check still fails

snyk check passes now.

@Omeramsc @hmariset @amisstea Need your reviews.

@Kousalya1998 assuming the SASK task image version is being updated by renovatebot like the other images in the pipeline to we really still need this PR?

assuming the SASK task image version is being updated by renovatebot like the other images in the pipeline do we really still need this PR?

As far as I can tell, the SAST check passed now and that was the requirement for this task. I am not sure about renovatebot..

Where does this change stands? Are we planning to use it?
(If so, please rebase and solve conflicts)

/retest

/retest

/retest

I can see the SNYK check is running now:

But its failing with these errors in the logs:
[sast-snyk-check] sast-snyk-check test failed because of the following issues:
[sast-snyk-check] Snyk Code is not supported for org: enable in Settings > Snyk Code
[sast-snyk-check] {"result":"ERROR","timestamp":"1701929575","note":"Task sast-snyk-check failed: For details, check Tekton task log.","namespace":"default","successes":0,"failures":0,"warnings":0}

What will it take to make it pass?

I can see the SNYK check is running now:

But its failing with these errors in the logs:
[sast-snyk-check] sast-snyk-check test failed because of the following issues:
[sast-snyk-check] Snyk Code is not supported for org: enable in Settings > Snyk Code
[sast-snyk-check] {"result":"ERROR","timestamp":"1701929575","note":"Task sast-snyk-check failed: For details, check Tekton task log.","namespace":"default","successes":0,"failures":0,"warnings":0}

What will it take to make it pass?

@ifireball I saw that too. So, to make it SUCCESS we need that Snyk subscription account. I am trying to get that access. It throws an error because I used a free trial version.

/retest

/retest

@ifireball @amisstea I FINALLY  got the Red Hat SSO access to the SNYK tool!! updated the secrets. However, it still gives the ERROR message. Something else is wrong now. Checking on that with the #rhtap developers channel.

/retest

/retest

/retest

/retrigger

Similar issues have arisen with the 'service-provider integrator' team, who have claimed they merged the PR without any issues even after the FAILURE message. Testing it.
https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1702020501097879

/retest

/rebuild

@ifireball I had a meeting with Scott Hebert today and we came across an image that we are using in the segment-bridge's Dockerfile:
# Second stage: Create the final container image
FROM registry.redhat.io/openshift4/ose-tools-rhel8:v4.13.0-202311211131.p0.gc7c6eb2.assembly.stream

Also, I see that tools for Red Hat appstudio's Dockerfile  use a different image which looks like:
RUN \
    curl -L https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.12.36/openshift-client-linux.tar.gz \
    | tar -C /opt/app-root/bin/ -xvzf - oc \
    && /usr/libexec/s2i/assemble

I guess the image that we are using causes HIGH vulnerability and that is making the SAST check Fail. However, with the tools repo if you see the SAST check passes with a different image:

@ifireball I had a meeting with Scott Hebert today and we came across an image that we are using in the segment-bridge's Dockerfile:
# Second stage: Create the final container image
FROM registry.redhat.io/openshift4/ose-tools-rhel8:v4.13.0-202311211131.p0.gc7c6eb2.assembly.stream

Also, I see that tools for Red Hat appstudio's Dockerfile  using a different image which looks like:
RUN \
    curl -L https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.12.36/openshift-client-linux.tar.gz \
    | tar -C /opt/app-root/bin/ -xvzf - oc \
    && /usr/libexec/s2i/assemble

I guess the image that we are using causes HIGH vulnerability and that is making the SAST check Fail. However, with the tools repo if you see the SAST check passes with a different image:

I think the issues Scott talked about have to do with the Clair scan and not the SAST scan. From looking at the logs it seems the SAST scan is failing on issues in the kwok/host-operator directory which is a Git submodule linking to the host-operator repo that we don't own. We can't do much about SAST issue in it.
If the SAST scan is running and failing on actual security issues v.s. system/invocation issues we can regard this task as successful.

Due to losing access to my current GitHub account, I am closing this PR and opening a new one
https://github.com/redhat-appstudio/segment-bridge/pull/147

Closing as a new PR opened instead.