Remove NodeIO PhET-iO sub Properties

Now that we have Properties in Node (see https://github.com/phetsims/scenery/issues/490), (work stemming from discussion in https://github.com/phetsims/phet-io/issues/1642), we can likely replace the complicated pattern of having NodeIO defined PhET-iO instrumented Properties for instrumented Nodes.
Some of the specification that apply to this issue were outlined in https://github.com/phetsims/scenery/issues/490#issuecomment-611656267 at last developer meeting:

Eliminate NodeIO visibilityProperty, pickableProperty, opacityProperty ?
Should pickableProperty and opacityProperty iO instrumentation be replaced by enabledProperty?
Can visibleProperty be passed in via options? How about other Properties?

These are all good questions for this issue when @jonathanolson, @samreid, @chrisklus and I meet today to work on this issue.

@jonathanolson, @samreid, @chrisklus, and I all worked on passing in visibleProperty to Node, and supporting it as an "instrumented sub Property" in the correct cases. This involved adding TinyForwardingProperty to make sure that Node.visibleProperty references would always be correct. We thought through multiple use cases, testing many of them, and they seemed to work in simple runs. We will want to create a better test suite though before too long.
There were a couple of loose ends that we want to try to fix before allowing opening up the visibleProperty API for mass consumption:

Currently, if you instrument a Node it will create an instrumented sub Property. Then if you pass in an instrumented Property as the visibleProperty later, it will try to dispose the sub Property before swapping it out. PhET-iO API Validation does now allow disposal of stuff like this after sim startup. This may be a challenge to get around, and likely will need to be solved with dynamic element support.
We set up logic that will add a LinkedElement to point to the passed in visibleProperty. We think it makes sense to add support to LinkedElement to "forward" client requests to its core type. That way you could still setValue on any LinkedElement. This may not be too important for Studio (since it shows the UI of the core element in a cut out), but it is likely that for invoke calls that we should support this. I'll create a new issue. (see https://github.com/phetsims/tandem/issues/171).
There are some TODOs to try to fix some hackary in Joist for PhetMenu and PhetButton. Before we were using IO Types to remove the visiblePropertys from these, but I think that read-only should be plenty fine for making sure that clients don't make them invisible. The TODOs are linked to this issue.
We still want to handle opacity and pickable Properties (see https://github.com/phetsims/scenery/issues/1047).
@samreid mentioned seeing a lot of ownsXProperty booleans, and wonders if we shouldn't try to use this new TinyForwardingProperty pattern that was added for Node. (I think this deserves more discussion).
We think some time should be taken to see if there are spots (especially in common code) where we can pass in a visibleProperty instead of using workaround-ish patterns that are there now before we had the visibleProperty option.

visibleProperty is broken in Studio on master. Marking blocks-publication and adding to the list in https://github.com/phetsims/ph-scale/issues/164.

Fixed in the commit above. When creating the default instrumentedVisibleProperty, we were linking the not-yet-assigned class property instead of the Property variable. Tested with a few sims in Studio and phet-brand. Unmarking for blocks-publication.

I see these points to move forward here:

Wait on conclusion in https://github.com/phetsims/scenery/issues/1047 as to whether or not we need to support a default, phet-io instrumented,
Support passing in Properties via options for anything else that is desired beyond visibleProperty
Review changes, especially with usages of ForwardingProperty.

The second bullet feels like something we could determine without knowing the outcome of the first.

I think that the visibilityProperty support code added above also needs a review here. I will do that as part of my review in https://github.com/phetsims/scenery/issues/490. Some TODOs will be linked here though.

[ ] We should not forget to try to apply the same patter for TextIO.textProperty. Though I'm not sure how.

After reviewing in https://github.com/phetsims/scenery/issues/490, I would say that this issue is blocking publication until we feel confident that visibleProperty is being handled well in Node.js.

@zepumph @chrisklus and I ran a number of tests using phet-io-test-sim as a harness, for example, testing a Node with a visibleProperty set in the constructor, or set after construction, and everything seemed sensible.  We used a setTimeout to change the visibility after construction.
@zepumph said he'd like to continue by adding unit tests around these features.  We'll also continue in #1047 by applying this pattern to opacity and pickability.

I know this has been high priority for some time, but there are culminating priorities (phetsims/tandem#211 and https://github.com/phetsims/sun/issues/257) that are getting momentum that this issue will be good to work on too.

I pointed a few TODOs to this issue, a reminder to skim for TODOs in the code as part of the work for this issue.

@samreid and I worked on this today.

Refamiliarizing ourselves with the visibleProperty logic in Node
Adding NodeTests to outline all the use cases for visibleProperty we could think of.
https://github.com/phetsims/scenery/issues/1087 with @jonathanolson
instrumenting again phetbutton and phetmenu's visibleProperty, but making it read only (which was already accidentally (?) committed.
Update TODOs to some other issues

[ ] We need to go through and clean up usages of "mergePhetioComponentOptions", and hopefully get rid of that function. All the usages I see apply to the visibleProperty, and not to pickable/opacity (which is good, because those will be uninstrumented).
[ ] Get one test to work still, likely by adding an assertion in visibleProperty, or by adding a remove linkedElement function that can cause an API error in that case.

@samreid, can we work on the above two this Friday?

Above is a large refactor of how setVisibleProperty works. It makes the linked element function (updateLinkedElementForVisibleProperty) much more graceful, and also simplifies Node.initializePhetioObject().
@samreid, since you left, the main change was that multiple Nodes in tests could not be disposed because they were created while expecting an assertion (via assert.throws()), and so had an inconsistent state that caused errors when calling dispose on them. I tried to document as best as I could. There are also a couple of new issues linked above coming from this work.
Next we need to work on mergePhetioComponentOptions and their usages for visibleProperty. Ideally we could remove this line soon:
Index: js/nodes/Node.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- js/nodes/Node.js	(revision 3c13c3f7348a650fc8488e3dc2b2d816eaeeac44)
+++ js/nodes/Node.js	(date<PHONE_NUMBER>745)
@@ -5291,7 +5291,7 @@
           phetioReadOnly: this.phetioReadOnly, // pick the baseline value from the parent Node's baseline
           tandem: this.tandem.createTandem( 'visibleProperty' ),
           phetioDocumentation: 'Controls whether the Node will be visible (and interactive), see the NodeIO documentation for more details.'
-        }, this.phetioComponentOptions, this.phetioComponentOptions.visibleProperty, config.visiblePropertyOptions ) );
+        }, config.visiblePropertyOptions ) );

         this.setVisibleProperty( this.ownedPhetioVisibleProperty );
       }

@samreid does this belong in a separate issue?
Please review the above commits.

This unit test is failing:
    window.assert && assert.throws( () => {
      instrumented3.mutate( { visibleProperty: otherInstrumentedVisibleProperty } );
    }, 'cannot swap out one instrumented for another' );

I traced this and saw that when the LinkedElement is disposed, launched is false, so it is only being removed from the tandem buffer, not from the phetioEngine, so it is not triggering a validation error.

The commits look great, I don't have any recommendations aside from the commits I made in NodeTests.js.  I'm not confident to proceed on mergePhetioComponentOptions or phetioComponentOptions without further discussion--is our goal that we will replace all occurrences of phetioComponentOptions with passing in a custom instrumented BooleanProperty (which will be instrumented and linked instead of direct)?  If so, I want to make sure that is an improvement before we proceed.

@samreid and I thought about a patch like this, but I think it is too constraining. For example if Panel wants its default visibleProperty to act a certain way, but we also support passing in a usage-specific visibleProperty. I think we should be tolerant of that:
Index: js/nodes/Node.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- js/nodes/Node.js	(revision e4673533f38500674f39a1a2d65bb78e306fa65a)
+++ js/nodes/Node.js	(date<PHONE_NUMBER>420)
@@ -5297,6 +5297,10 @@
       }
       else {

+
+        // TODO: I'm worried this will be too constraining, what if a default button options want to add metadata https://github.com/phetsims/scenery/issues/1046
+        assert  && assert( !config.visiblePropertyOptions , 'Cannot specify visibleProperty and visiblePropertyOptions for default instrumented Node.visibleProperty.' );
+
         // Since we are just now instrumented, and linked elements can't be added to linked Elements until the PhetioObject
         // is instrumented, we need to retroactively link to whatever forwardingProperty may have been added before.
         this.updateLinkedElementForVisibleProperty( null, this.visibleProperty.forwardingProperty, false );

RE: https://github.com/phetsims/scenery/issues/1046#issuecomment-708561954, @samreid and I updated documentation, and are ok with not asserting.

@samreid and I have completed all that we can see in this issue, and created side issues for next steps. We are now going to head over to https://github.com/phetsims/scenery/issues/1047 to duplicate part/all of this pattern for opacity/pickable.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

Thank you for considering my plugin for awesome-zsh-plugins. I apologize for the oversight of not including a license file. I have now added a license file to the plugin and have chosen the MIT license. Please let me know if there are any further concerns or issues. Thank you again for your interest in my plugin


Make Jenkins steps show console in place

We should be able to expand a step in place to see the console.


Unwarranted UI animation

Blue line pushing on text, making it jump to next line

as seen from my tele vid 💀

Should probably put it here as well. So that others don't have to scroll to their tele history when referencing this issue.

Um ok, I can't save the tele video. just describe ah ok


Update preprint

@davharris - if you haven't already we should submit the revised version to bioRxiv.

:muscle:


Can’t boot ibss/ibec on T2 devices, stays in dfu

when u boot ibss or ibec on T2 MacBooks it stays in dfu and doesn’t go in recovery

worked for me no issue, depend which ibss/ibec brideos used and which patcher like kairos

worked for me no issue, depend which ibss/ibec brideos used and which patcher like kairos

Are you using irecovery to send img4 format? I m using the earliest bridge os 4.2. I did patch it with kairos and signed as well with fake im4m

yes, irecovery, kairos but not last version, and bridgeos 5.1, all fine

I have tried 5.1 but it stays in dfu doesn’t go in recovery at all. Will u be able to check or can You check my files if I upload them?


Inconsistent iOS deployment targets

iOS deployment target in the Xcode project (8.0; used by the Carthage build) doesn't match the one in the Podspec (6.0; used by the CocoaPods build).

Sorry for late, I know that, but I was wondering that what is your concern?


Document methods in the repo

Background:
We're (unfortunately) lacking method docs, and having some would be amazing.
Task Details:
Consider covering methods in the repo, especially public and less straightforward, with some jsdocs style comment
example
/**
   * Handler for opening websocket event - `connection`.
   * Sets listeners for `message`, `pong`, `close`, and `error` events.
   */
#handleConnection(socket: WebSocket, _request: IncomingMessage): void {
  const dwn = this.dwn;
  // ...rest of the code...

Picking Up This Issue:

If you'd like to work on this, please comment "picking this up" below, and I'll assign the issue to you

Questions:

If you need assistance or clarification, feel free to comment below.
Feeling overwhelmed? Join our #hack-together channel and collaborate with a buddy.
New to open-source? Check out our Hacktober #getting-started channel.
Leaderboard: Check your ranking after finishing this task.

Resources:

Creating a Pull Request: If you're new to GitHub and unsure how to create a pull request, follow this step-by-step guide.

Remember, communication is key! If you have any questions or face any challenges, we're here to help so please don't hesitate to reach out.
Good Luck! 🍁

Picking this up! :)

@MaticSulc yay! I've assigned it to you!
I'd also like to note that Hacktoberfest officially kicks off on October 1st. Contributions made before the event may not be eligible for the challenge. However, feel free to start working on it, but I'd recommend holding off on submitting your PR until the event begins.

to be eligible for Hacktoberfest's official prizes make sure you're registered, registration is now OPEN.

Hey @MaticSulc would you still like to work on this issue?

Hey @MaticSulc would you still like to work on this issue?

Can I pick this one up if it's not being worked on?

Hey @KhoiUna yes you can work on it, thanks!

@EbonyLouis Submitted a PR


[2] Feat/add params for normal task

Description
After #17 is merged, merge main back into this branch and review
Part 3 /3 for the #7. This adds parameter processing when there's no task token.
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] Manual tests
[x] Unit tests

there's conflicts with the past merged PR


Can't run two web worker test cases in one file

Describe the bug
Firstly, I used @vitest/web-worker to simulate web worker:
export default defineConfig({
  test: {
    globals: true,
    environment: 'jsdom',
    setupFiles: ['@vitest/web-worker'],
  },
})

Next, I wrote two test in one file(If I only add one test, It will be OK).
const createWorker = () => new Worker(new URL('./fibonacci', import.meta.url), {
  type: 'module'
})

test('run MyWorker first time', async () => {
  const worker = createWorker()
  const ret = await promiseWorker(worker, 10)
  expect(ret).toBe(89)
})

// The second test will print such errors:
// Error: Test timed out in 5000ms.
// If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
test('run MyWorker second time', async () => {
  const worker = createWorker()
  const ret = await promiseWorker(worker, 10)
  expect(ret).toBe(89)
})

function promiseWorker(worker: Worker, n: number) {
  return new Promise((resolve, reject) => {
    worker.onmessage = function({data}) {
      resolve(data)
    }
    worker.onmessageerror = function({data}) {
      reject(data)
    }

    worker.onerror = function(e) {
      reject(e)
    }

    worker.postMessage(n)
  })
}

This is my fibonacci.ts file, If I not import exportWorker but inline it, the tests will all passed :
import exportWorker from "./exportWorker"

// If I use the `exportWorker` from ./exportWorker.ts , It will be broken.
exportWorker(fibonacci)

// If I use inline exportWorker, It will passed
// function exportWorker(fn: CallableFunction) {
//   self.onmessage = function({data}) {
//     const result = fn(data)

//     self.postMessage(result)
//   }
// }

Reproduction
vitest-web-worker-reproduction
System Info
System:
    OS: macOS 12.4
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
    Memory: 16.84 MB / 8.00 GB
    Shell: 3.2.57 - /bin/sh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.14.2/bin/yarn
    npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
  Browsers:
    Firefox: 80.0.1
    Safari: 15.5
  npmPackages:
    vite: ^3.0.0 => 3.0.8
    vitest: latest => 0.22.1

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Yeah, dependencies of worker are not cleared, but should be.

Yeah, dependencies of worker are not cleared, but should be. There is invalidates that should be populated on import:
https://github.com/vitest-dev/vitest/blob/285ac7c24ef74ee244ce927b5e3bc757feaa918a/packages/web-worker/src/pure.ts#L116
And we actually have a function that can do that now: b8922aa

I can offer a PR @sheremet-va.


Fix Responsiveness and Alignment Issues on Contributors Page

Description
Hey @sunny0625 and @khushi-joshi-05

issue closes #1430

I have made the responsiveness and alignment on the contributors' page

Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@khushi-joshi-05 Please merge this PR and add lavels

@sunny0625, @khushi-joshi-05 Please merge this PR

@sunny0625, @khushi-joshi-05 Please merge this PR and add levels

@sunny0625 @khushi-joshi-05  Please merge this PR as the GSSOC is near to it's end


[GHSA-c2qf-rxjj-qqgw] semver vulnerable to Regular Expression Denial of Service

Updates

Affected products

Comments
https://www.first.org/cvss/v3.1/user-guide

Hi @sammyfilly, I see you are proposing a change to the affected product(s) but you linked the CVSS 3.1 User Guide. Was this in error? What exactly are the changes you are proposing?

Trying to make sure that the base is staging


Renaming a Feature keeps the old named Feature visible within Test Explorer

Hi,
I went to rename a feature and noticed that one the the feature was renamed the original name was still present in the Test Explorer
Example.
I started with the following basic named feature files.

I renamed FeatureOne to become FeatureThree and FeatureThree appears but FeatureOne is still present

If you select the to Go to Test on Feature One it will display the "the editor could not be opened because the file was not found"

If you restart Visual Studio Code, it does remove FeatureOne.
Pressing the Refresh Tests does not remove the old named feature

If the Feature file is within the folder features, it will rename ok.
If the feature file is outside of this folder then it doesn't auto update

I can confirm this is now working. Thanks


UI: Make the random password generation button square without borders

Fixed by 5f1964a commit

Fixed by 5f1964a commit


Correcting wrong Quotes

@Nepomuceno : Thanks for your contribution! The author, @rboucher, has been notified to review your proposed change.

Looks good.  Thanks for fixing that @Nepomuceno .

#sign-off


Add Team Cape 0/X/I to clue step

Hopefully correctly added TEAM_CAPE_ZERO, TEAM_CAPE_X, and TEAM_CAPE_I to the Barbarian Agility Arena clue.
First RL PR, apologies for anything done incorrectly.
Fixes #17269

This change looks good now. Can you also apply it to another clue step I found here? At this point, it may be worth defining an AnyRequirementCollection var for "Any team cape" so this particular code doesn't have to be repeated in multiple places.

I went ahead and added it again in the current format to the other clue step.
I looked into the AnyRequirementsCollection briefly and couldn't get it working very quickly.
I want to look into it more, but Leagues atm. So I figured I'd just do the current solution for now. :D


Adds test for InlineObjectSchemaValidator

Description
Adds test for InlineObjectSchemaValidator
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Linter complained, https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9024077713/job/24797246589?pr=289.

@dblock Fixed this, editor hadn't actually saved/flushed some of my other changes at commit time 🤦


Difficult/unintuitive to modify individual VS Code & ext. settings: WSL+Anaconda issue - conda: command not found

Issue Type: Feature Request
I try to use the WSL terminal integrated into VS Code.
I'm filing this as a feature request, whereas I intend it as constructive criticism towards some specific elements of the UI (graphical and otherwise), and I would possibly hope for some helpful pointers in return.
Problem as in action, until today:
Until today, every time I open new terminal, some process will be trying to launch a script from a preconfigured path to Anaconda in ..\ProgramData\et cetera, into the current WSL.
WSL would then interpret this command and fail, considering that the preconfigured path was full of backslashes, which it would read as escape characters; certainly not interpreting it as the intended command: "activate conda".
This error message's behaviour persisted even when I tried to choose either of my python interpreters:

"Python 2.7.15 64-bit ('base': conda) - C:\ProgramData\Anaconda2\python.exe", or
"Python 2.7.15 64-bit ('Anaconda2': conda) - ~\Anaconda2\python.exe"

I've had to spend good hours for days now, towards figuring out even why this is/which settings does this/where can I modify them.
Reflections, as in: "Letting you understand the circumstances of my problems, and bullet pointing my suggestions for you" (it may be a wall of text for you, but it might also be valuable for you to know how your interface is perceived from even a single user's experience)
I am a newcomer to VS Code, having been using Sublime Text for years (simply decided to try out VS Code because it was bundled with Anaconda, and I'm very pleased overall). However, to me the problem here is not a lack of implementation on VS Code's part, but to provide a relatively intuitive way of leading the user towards the correct settings involved in this. As requested in Globally WSL support , there should be an over-arching portion of the settings concerning how the integrated terminal and the extensions are directed to a specific command terminal, be it bash or cmd.

I've already upvoted the afore-linked issue, because this seems to be a feature that should be taken for granted to be included, when the rest of VS Code appears to so well-made and polished (and I think it is, so please take this as a compliment). While his and my own problem are not exactly the same, I believe our problems are connected in how VS Code is currently designed/developed.

I'm also perplexed to the contrast of how well-documented every single feature of VS Code is - except for how to manually edit individual settings for individual extensions (for, after all, my issue could stem from one of my extensions!). I've also google this, but I suspect that the last few years of sifting through StackExchange- and Numpy sites, by way of google, is polluting the results somewhat: only to say that I've never had these specific problems before. In any case: surely, these extensions have their own settings that should be configurable, but I've looked through UI elements of VS Code that would otherwise be logical places to find these configurables, or even through the settings.json that I could find: and I couldn't find any settings towards modifying extensions, nor anything that lead toward an Anaconda-launchable script's path related to ProgramData.
So, as far as I can tell, it seems that the user is intended to add their extension-specific settings' modifications into settings.json (as modifyable by the user). Am I correct?

edit1: It seems that this is how the user is meant to specify extension-related settings - no extra files for extension-specific settings. Nice! Embarrassingly - upon a VS Code restart and closer inspection - I see that searching for specific extensions in the normal settings.json would display these settings vividly.
I might simply have not noticed that the settings-results that were displayed as I was searching earlier, were in fact related to extensions that I had installed (and maybe my VS Code at some point simply needed to restart in order to work properly, although it didn't tell me to reload).
As such, because I've spent a good deal of time probably looking at extension-specific settings while looking for them; having them staring at me right back into my face, while I myself believed that I was looking at VS Code's default jungle of settings:

It might be a good idea to simply label extension-specific settings in the settings.json (color code, for instance), so that it is immediately clear to a user trying to skim through settings, which options are indeed extension-specific.

In case I am, how about the same solution as how one would edit the settings.json, i.e.:

I think that you should be able to open the extensions' bar, right-click an extension, and that there should be an option to "open extension's settings". Selecting/clicking this option should then open a double-column layout of the specific extension's modifyable settings on the left column (un-editable, as always); and on the right column there would be the settings.json file that is intended for the user.

edit1: In other words, simply a hyperlink of the default behaviour from looking through the settings the normal way.

I did find launch.json by accident in the settings-GUI, and could not remember how to get back to it, until I today found it in the drop-down menu from "Debug", called "Add configuration" - not at all my first thought, when I'm "merely" looking for how the 'integrated terminal' works. So then, finally, I thought; that these were settings that might have something to do with the that issue I began with, but it became clear to me that the file didn't mention Anaconda, nor did it refer to a pre-configured path related to the Windows-folder ProgramData: so again, a dead end.
My reason for not-yet-disabling my extensions, was that when I even booted up VS Code for the very first time, it was to open a python script, and several things immediately installed by their own - and I was also fairly quick to configure VS Code to utilize WSL, too: And with these circumstances, along with that I've always seen that Anaconda-related error message when opening the terminal, led me to believe that the problem was fairly ingrained in VS Code's interpretation of WSL, and not to do with the extensions in themselves - maybe even in the fact that installing VS Code from Anaconda ingrained Anaconda itself into VS Code; and I don't consider Anaconda itself to be an extension to VS Code.
As it turns out, I believe there was some truth to my hunch: the error message finally stopped when I created a ~/.bash_profile-file in WSL (...didn't need one until now!), wherein I sourced the my WSL's ~/.bashrc file - into which I also added the line source ~/Anaconda2/etc/profile.d/conda.sh. Seeing as I mostly install Anaconda from convention, merely for acquisition of the collection of python packages found within, this was not my first thought, and thus I give cudos to source activate is broken in 4.4 for zsh .
At this point I went back to VS Code settings, and made sure that both the pythonPath and the condaPath refer to their installations within the WSL environment: "python.pythonPath": "~/Anaconda2/bin/python" and "python.condaPath": "~/Anaconda2/bin/conda", respectively. Opening the terminal now only shows me what I've myself set the ~/.bashrc to display upon startup; no error messages.
I still have no idea if there's some part of Anaconda that has ingrained itself into VS Code, and is actively trying to be able to activate in the background without my knowing, because that is exactly how it seems like they are doing:
That the error message which I had from the beginning, was simply Anaconda from the Windows side (and not inside WSL) that has somehow configured VS Code into checking any terminal environment that opens, if there is Anaconda inside - not even running Anaconda, just checking if Anaconda is potentially there to be run.
And I say "seems", because I still cannot find any settings, modified or not, that tells any integrated terminal to do this. At least now, if it's still doing it, then thankfully it's keeping it to itself.

"Snakes! - Why did it have to be snakes?!"

VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

Thanks for the feedback. We're looking at improving the overall WSL experience in https://github.com/Microsoft/vscode/issues/63155, your problem seems largely a problem with the Anaconda build though so you might have more luck going over the flow with them.


Support Clang 3.4

While the compiler is rather old it seems trivial enough to support Clang 3.4.
Although I basically have no idea what the effects of this small change are...
I personally don't care much about performance on this old compiler.
Note: it's also possible to add clang-3.4 to GitHub Actions. I can add this to the pull request if you like.
It's something like:
            if [ "${{ matrix.config.version }}" = "3.4" ]; then
              echo "CC=clang" >> $GITHUB_ENV
              echo "CXX=clang++" >> $GITHUB_ENV
              echo "CXXFLAGS=-stdlib=libc++" >> $GITHUB_ENV

              # clang-3.4 is available from trusty
              sudo add-apt-repository "deb http://dk.archive.ubuntu.com/ubuntu/ trusty main"
              sudo add-apt-repository "deb http://dk.archive.ubuntu.com/ubuntu/ trusty universe"
            fi
            sudo apt install -y clang-${{ matrix.config.version }} g++-multilib

Thanks!


Fix relative time filter

Description & motivation 💭

Update time range filter values when Relative is toggled on/off
Converts relative time filter to a date to fix Invalid Date error
Fixes position of datetime filter dropdown

Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻

[x] Manual testing
[ ] E2E tests added
[ ] Unit tests added

Steps for others to test: 🚶🏽♂🚶🏽♀

[ ] Verify the datetime filter dropdown is positioned correctly and does not go off the page

In Labs mode

[ ] Verify a time range value is updated with Relative is togged on/off
[ ] Verify selecting a relative time works as expected (and is converted to the timezone selected)

Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?

When was it offscreen? When it's small screen, position right is cut off. Position left doesn't.

Yeah agree, I think we want this position="left"

@Alex-Tideman I just fixed the position for the existing datetime filter dropdown in this PR ⬇

Before
After

For the timezone dropdown responsiveness I believe @rossedfort has some goodness in the new combox PR.


Quota Exceeded although no files are currently served

There is a problem with the quota limit thing.

Problem never showed up again, so I guess this can be closed. Please reopen if it happens again.


Fix inconsistent alerts by using the markdown notation - part 2

Why:
As described in the issue #35195 the display of alerts is inconsistent across the documentation.
As the original PR #35216 exceeds the linter limit of 300 files, this PR is part 2 of the changes. It provides changes to alerts across the documentation according to the docs guidelines using the Markdown notation.

What's being changed (if available, include any code snippets, screenshots, or gifs):
Alerts for note, tip, important and warning have been changed and unified from the liquid notation ({% note %}) to the Markdown notation (> [!NOTE]) according to the docs guidelines.

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@akordowski Reviewing this now! 💛

@akordowski Part 2 approved! ✨
I know we're only halfway through this PR series, but I wanted to relay thanks from the team for this undertaking 💛 I'll have this merged shortly.

@nguyenalex836

I wanted to relay thanks from the team for this undertaking

Thank you very much! ☺ It's my pleasure to give something back.

I'll have this merged shortly.

No rush! Thank you for your effort to review this big chunks.


remove mime sniffing from all streams except file

With https://github.com/http-rs/http-types/pull/102 implementing Body::from_file we should probably remove the magic-bytes based mime sniffing from the other streams, and only keep it for Body::from_file.
Additionally we should expand our sniffing capabilities similar to https://github.com/http-rs/tide/pull/461, but probably using a manual mapping instead of using mime_guess. We already cover most AV formats through the magic bytes, all we'd need to do is add some basic mappings for e.g. JS, HTML, CSS, SVG.

Oh, looks like we dropped magic-bytes based sniffing already. Great!


Re-think naming of component

Currently this is using;
<pro-resource-calendar [dates]="dates" [events]="events">
</pro-resource-calendar>

You know what kind of history we have had with that pro term - right? So what about if we use following instead;
<ptc-resource-calendar [dates]="dates" [events]="events">
</ptc-resource-calendar>

Fixed


Create Dropdown with default labels

Describe the bug
I want to create drop down with default options, I have tried with defaults option but not working.
Steps to reproduce

Embed the SDK in an app
Call mutation { create_column(board_id: <bordId>, title: "DropDown 3", column_type: dropdown, defaults: "{\"labels\":[\"My label\"]}") {  id } }
See the request fails
Only create column without any default label

Expected behavior
There should be new column with default value which passed in default labels

Follow up in this community conversation


I want drag many items in a list to anther list  by select checkbox in items

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
@jvielrco  I want the feature Pelese help me

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar.

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 2.X.X
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Sorry, I am not the author of this library, and I am not sure you can do this easily with ng2-dnd. I can't help you.


shellIntegration.bash incorrectly sources /etc/profile and ~/.bash_profile

Describe the bug
When starting is, it sources all three of ~/.bashrc, /etc/profile, and ~/.bash_profile. This is not how bash startup is supposed to work.
For interactive shells, bash either sources /etc/profile and ~/.bash_profile (for login shells), or ~/.bashrc only (for non-login shells). See https://www.gnu.org/software/bash/manual/bash.html#Bash-Startup-Files
is should act like a non-login shell and only source ~/.bashrc, i.e., these lines should be deleted: https://github.com/microsoft/inshellisense/blob/9db5beea23e1f371ff80e3bc1390d19ed882942a/shell/shellIntegration.bash#L4-L13
If you wanted, you could provide a --login option like bash does and instead load /etc/profile and ~/.bash_profile in that case, though I'm not sure there's a good use case for that.
Environment

OS: macOS Sonoma
Output of is --version: 0.0.1-rc.10
Nodejs Version: 20.11.1
Shell: bash
Shell Version: 5.2.21

Reopening this since I think adding the --login option could be useful for some users


🐛 InputImage.zzb - java.lang.IllegalStateException - Image is already closed

What's happening?
I received an error in production and encountered a crash in Firebase Crashlytics. However, when I attempted to reproduce it, I couldn't replicate the crash.
Below device and version affected :

Reproduceable Code
const { hasPermission, requestPermission } = useCameraPermission();
  const [isCameraInitialized, setIsCameraInitialized] = useState(false);

  const isActive =
    isFocused &&
    isForeground &&
    !isKeyboardVisible &&
    !isScanned &&
    !isLoading

// some code

 const codeScanner = useCodeScanner({
    codeTypes: ["qr", "ean-13"],
    onCodeScanned: (codes) => {
      setisScanned(true);
      const val = codes[0];
      // simpleToast(codes[0].value as string);
      setisScanned(true);
      if (!isgetscanqrcode) {
        if (scanQrCode.length < 1) {
          Vibration.vibrate(300);
          setisGetScanQrCode(true);
          let scanValue = "";
          if (val.value?.toString().includes("21/")) {
            consoleLogs(val.value, "https");
            scanValue = getCodeFromUrl(val.value as string);
            if (scanValue.length != 13 && scanValue.length != 12) {
              setTimeout(() => {
                setisGetScanQrCode(false);
              }, 300);
            } else {
              scanValue = getCodeFromUrl(val.value as string);
            }
          } else {
            consoleLogs(val.value, " ");
            if (
              val.value?.toString().trim().length != 13 &&
              val.value?.toString().trim().length != 12
            ) {
              setTimeout(() => {
                setisGetScanQrCode(false);
              }, 300);
            } else {
              setScanQrCode([...scanQrCode, val.value.toString().trim()]);
              scanValue = val.value as string;
            }
          }
          if (scanValue.trim().length != 13 && scanValue.trim().length != 12) {
            setTimeout(() => {
              setIsSingleScanFailedVisible(true);
              setIsErrorString(t("earningerrors.invalid"));
              setIsErrorStringDetail(t("earningerrors.invaliddetail"));
            }, 300);
          } else {
            if (
              type === userForAnalytics.painterType &&
              scanValue.trim().length < 13
            ) {
              setIsSingleScanFailedVisible(true);
              setIsErrorString(t("earningerrors.eligible"));
              setIsErrorStringDetail(t("earningerrors.eligibledescription"));
              setisGetScanQrCode(false);
              setScanQrCode([]);
            } else {
              ScanCode([scanValue], "Camera");
            }
          }
        }
      }
    },
  });

// some code

        <ScrollView
        contentContainerStyle={{ flexGrow: 1 }}
        bounces={false}
        keyboardShouldPersistTaps="handled"
      >
        {device != null && hasPermission && (
          <Camera
            style={
              isCameraInitialized
                ? StyleSheet.absoluteFill
                : [
                    {
                      height: gWindowHeight,
                      width: 0,
                      aspectRatio: gWindowHeight / gWindowWidth,
                    },
                    StyleSheet.absoluteFill,
                  ]
            }
            device={device}
            onInitialized={() => {
              setTimeout(() => {
                setIsCameraInitialized(true);
              }, 120);
            }}
            isActive={isActive}
            torch={isTorchOn ? "on" : "off"}
            codeScanner={codeScanner}
            video={false}
            photo={false}
            audio={false}
            onError={(error) => {
              // console.log(error);
            }}
          />
        )}
    <>
    {/*Some code */}
    </>
    </ScrollView>

Relevant log output
Fatal Exception: java.lang.IllegalStateException: Image is already closed
       at android.media.Image.throwISEIfImageIsInvalid(Image.java:70)
       at android.media.ImageReader$SurfaceImage.getFormat(ImageReader.java:821)
       at com.google.mlkit.vision.common.InputImage.zzb(InputImage.java:12)
       at com.google.mlkit.vision.common.InputImage.fromMediaImage(InputImage.java:1)
       at com.mrousavy.camera.core.CodeScannerPipeline._init_$lambda$4(CodeScannerPipeline.java:34)
       at android.media.ImageReader$ListenerHandler.handleMessage(ImageReader.java:800)
       at android.os.Handler.dispatchMessage(Handler.java:106)
       at android.os.Looper.loop(Looper.java:201)
       at android.os.HandlerThread.run(HandlerThread.java:65)

Camera Device
{}

Device
Vivo, Oppo , Xiaomi
VisionCamera Version
4.0.0-beta.10
Can you reproduce this issue in the VisionCamera Example app?
I didn't try (⚠ your issue might get ignored & closed if you don't try this)
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

I need log output for this. ADB does also log in production, no?

I need log output for this. ADB does also log in production, no?

firebase-crashlytics-stacktrace.txt
It's found in production, so I have the Firebase stack trace.
I can't reproduce it in development.

This is just the tombstone/stacktrace, are there any logs? I need to know what happened before this crash.

Crashlytics - Custom logs
Application: com.packagename
Platform: android
Date: Wed Apr 10 2024 16:11:34 GMT+0530 (India Standard Time)
0 | Wed Apr 10 2024 16:10:40 GMT+0530 (India Standard Time) | screen_view (MainActivity)
1 | Wed Apr 10 2024 16:10:45 GMT+0530 (India Standard Time) | mounted screen: SplashScreen
2 | Wed Apr 10 2024 16:10:51 GMT+0530 (India Standard Time) | mounted screen: HomeScreen
3 | Wed Apr 10 2024 16:10:52 GMT+0530 (India Standard Time) | screen_view (HomeScreen)
4 | Wed Apr 10 2024 16:11:03 GMT+0530 (India Standard Time) | Click on Scan
5 | Wed Apr 10 2024 16:11:03 GMT+0530 (India Standard Time) | mounted screen: ScanScreen
6 | Wed Apr 10 2024 16:11:04 GMT+0530 (India Standard Time) | screen_view (ScanScreen)
7 | Wed Apr 10 2024 16:11:30 GMT+0530 (India Standard Time) | Code Scanner Start
8 | Wed Apr 10 2024 16:11:31 GMT+0530 (India Standard Time) | Code Scanner Complete
When Code Scanner Start we show the loader ( modal )
When Code Scanner Complete we close the loader ( modal )

I have the same issue.
Fatal Exception: java.lang.IllegalStateException: Image is already closed
       at android.media.Image.throwISEIfImageIsInvalid(Image.java:79)
       at android.media.ImageReader$SurfaceImage.getFormat(ImageReader.java:1158)
       at com.google.mlkit.vision.common.InputImage.zzb(com.google.mlkit:vision-common@@17.3.0:8)
       at com.google.mlkit.vision.common.InputImage.fromMediaImage(com.google.mlkit:vision-common@@17.3.0:1)
       at com.mrousavy.camera.core.CodeScannerPipeline._init_$lambda$4(CodeScannerPipeline.kt:53)
       at com.mrousavy.camera.core.CodeScannerPipeline.$r8$lambda$J9uS5V_QrF4Y46dODUvYa6w1Wm0()
       at com.mrousavy.camera.core.CodeScannerPipeline$$ExternalSyntheticLambda0.onImageAvailable(:4)
       at android.media.ImageReader$1.run(ImageReader.java:916)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:240)
       at android.os.Looper.loop(Looper.java:351)
       at android.os.HandlerThread.run(HandlerThread.java:67)

Hey - I think this issue has been fixed in VisionCamera 4.0.0. 🥳
Please try V4 and let me know if you still experience this issue;

if not, please consider 💖 sponsoring me on GitHub 💖 to support the development of VisionCamera and thank me for my time spent on fixing bugs and building new features.
if you still see this issue, please comment and we can re-open this. But please update your native logs with the native (Xcode/Android Studio) logs from running VisionCamera V4 so I can investigate this.

Version 4 has different dependencies with who knows what side effects.
A simple try/catch around the CodeScannerPipeline lambda would probably fix this issue even in V3.

A simple try/catch around the CodeScannerPipeline lambda would probably fix this issue even in V3.

A PR would be much appreciated :)


[Bug]: Running with ESM breaks js_dev_server

What happened?
When trying to run js_dev_server, node throws an error because the aspect runner is a .js extension that uses a commonjs module syntax
file:///private/var/tmp/_bazel_davidaghassi/30b12e6784b9304c95faa3f4506c5839/execroot/rh/bazel-out/darwin_arm64-fastbuild/bin/web/web-app/app/dev.sh.runfiles/aspect_rules_js/js/private/js_run_devserver.js:1
const path = require('path')
             ^

ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/private/var/tmp/_bazel_davidaghassi/30b12e6784b9304c95faa3f4506c5839/execroot/rh/bazel-out/darwin_arm64-fastbuild/bin/web/web-app/app/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///private/var/tmp/_bazel_davidaghassi/30b12e6784b9304c95faa3f4506c5839/execroot/rh/bazel-out/darwin_arm64-fastbuild/bin/web/web-app/app/dev.sh.runfiles/aspect_rules_js/js/private/js_run_devserver.js:1:14
    at ModuleJob.run (node:internal/modules/esm/module_job:183:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)
    at async handleMainPromise (node:internal/modules/run_main:63:12)
^C

Version
Development (host) and target OS/architectures:
Output of bazel --version:
bazel 6.0.0-pre.20221020.1
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 1.6.9
Language(s) and/or frameworks involved: Typescript/SWC
How to reproduce
Set `package.json` to `type: "module"` and then run the dev server. Here is how mine looks

js_run_devserver(
    name = "dev",
    args = [
        "serve",
        "--config",
        "webpack.config.mjs",
    ],
    chdir = package_name(),
    # See WORKSPACE file for the linking setup for this
    command = "./node_modules/.bin/webpack-cli",
    data = [
        "server/template.html",
        "webpack.config.mjs",
        ":node_modules",
        "//web/web-app/app/kernel",
    ],
    # This is so that we don't fail CI due to plugins or logic
    # we may need during the dev server only
    env = {
        "LOCAL_DEV_SERVER": "true",
    },
)

And this causes the failure. If I remove type: "module" things work, but I have other issues.

### Any other information?

_No response_

### Fund our work

- [ ] Sponsor our open source work by donating a [bug bounty](https://opencollective.com/aspect-build/)

This is the file in question https://github.com/aspect-build/rules_js/blob/main/js/private/js_run_devserver.js#L1

I can confirm that changing the file extension to .cjs does alleviate the problem on my end

Oh right. I hit something similar when working in rules_jest last week. The fix is to use .mjs for the runner. I'll put up a PR later today.


Add nightfly.palette available externally

SSIA
When setting up status-line, etc., it would be useful to get a list of the colors used by that color scheme.

I have a big PR upcoming in lua-conversion branch.
So for the moment, I don't want to merge anything that will break that branch, which contains many changes.
I am waiting for Neovim 0.9 to release before merging.
As for this one, on first glance I am not a huge fan of M.palette.<COLOR> in the highlight statements. My preference is to have a M.palette function that returns a table of the colors without touching any of the highlight statements. I don't want to uglify the code just for one use case.
Cheers.

I see. I made sure that no changes were made in other areas. How about this?

Yes, I like that much better.


Create geonames benchmark data S3 bucket.

We need to create a bucket and update the README accordingly
https://github.com/opendistro-for-elasticsearch/search/tree/main/client/benchmark#bulk-indexing

Does this need a corresponding ticket/belong in https://github.com/opensearch-project/opensearch-build ?

@adnapibar what is needed for this issue to be resolved? I am unable to understand the problem here.

@adnapibar what is needed for this issue to be resolved? I am unable to understand the problem here.

Currently the dataset for the benchmarking is downloaded from the S3 bucket hosted by Elastic (http://benchmarks.elasticsearch.org.s3.amazonaws.com/corpora/geonames/documents-2.json.bz2).
The issue is to host the dataset in an OpenSearch managed bucket.

@adnapibar can you provide details of the impact of this?

@adnapibar can you provide details of the impact of this?

The S3 bucket is managed by elastic, which I don't think should be in the README. Also, the S3 URL can change and in that case the instructions in the README will become inaccurate.

Looks like we utilize our own providers now: https://github.com/opensearch-project/opensearch-benchmark-workloads/commit/5b502c1818e3813f8c22d93919d72309b8fa5f03


[Build Error] Video player Injector Error

From video_player 0.11.x, FlutterInjector has been introduced and causing error in SDKs lower than stable on Android.
If you are suffering from this issue, please override the package to 0.10.12+5.
dependency_overrides:
  video_player: 0.10.12+5

By using SDK upper than 1.20.0, this issue will be solved. Scheduled to drop the support in one week.

By using SDK upper than 1.20.0, this issue will be solved. Scheduled to drop the support in one week.

Dropped in 5.0.0-dev.4 .

Dropped in 5.0.0-dev.4 .


Double click on Row detail in Standings row crashes application.

Describe the bug
If you expand row to see counted races in standings and double click on a race row the application crashes instantly.
To Reproduce
Steps to reproduce the behavior:

Go to Standings page
Exapnd a row
Double click on a race

Expected behavior
Nothing

This is fixed in v0.5.2


Suggested changes for fix-atest

@robinmatz I will review your changes this evening (if possible).


Avoid overflow in calculateNumTiles when size=MAX_INT

Addresses https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25297
Signed-off-by: Cary Phillips<EMAIL_ADDRESS>

Does this really need to avoid this case and throw an exception, just because an intermediate sum might overflow as an int?
Using 64 bit computation would prevent an overflow, but 'size' here is the width or height of a tile. Why would anyone want to write an image that's 4gigapixel wide and only has one tile? There's also a limit to INT_MAX bytes per tile, which would be reached well before these width/height limits.

I think bailing early is sensible, to help protect against any other issues that might be uncovered handling very large files.

size is an int. The resolution of the MIPmap level, L is an int. The number of tiles will be an int, since it is, mathematically, ceil(L/size), and thus smaller than L.
The current code oddly disallows the level resolution to be close to intmax, not because it's a real limit, but simply because some values of an intermediate calculation of the expression (L+size-1)/size will cause an overflow in the implied temporary that will hold L+size (because both operands are int, so will be the temporary).
By declaring L as an int64_t, that will make the temporary wide enough to do the (L+size-1)/size calculation correctly, for any valid int value of L.

Ah yes, so you can overflow with an image which is only just under INT_MAX wide, even with plausible sized tiles.
Is it correct that the code wouldn't overflow for any mipmap level in any rounding mode if (width of dataWindow)+(tile width) and (height of dataWindow)+(tile height) are both less than INT_MAX-1? That seems like a sane limit to have anyway, since both individually have to be less than INT_MAX.
My point was really that these are insane situations anyway, since the practical limit to image dimensions is significantly less than INT_MAX. All these tests and workarounds do is to protect against 'non-legit' EXR files.
I suppose switching everything to 64 bit would allow the test and the exception to be removed, so would be more efficient, and might be a better way to go.

Good thought, it makes sense to switch to i64 for those reasons.


New describe command

It may be useful to have a command grambank describe SHEET, which

lists all contributing coders
gives summary stats on the values
lists all (author, year, page) triples which can be parsed from Sources

basically a tailor-made version of csvstat for grambank sheets.
The idea is that this command should be run as final plausibility check on changed sheets - before running grambank cldf on the whole repos.

So here's what I have so far:
$ grambank describe original_sheets/SVM_tafi1243.tsv

Path:
original_sheets/SVM_tafi1243.tsv

Check:

Values:
0	 46
1	 43
2	  4
?	  1
	 94

Sources:
Bobuafor 2013:	 94

Coders:
SVM	Suzanne van der Meer:	 94
ML	Mandy Lorenzen:	 13

looks good. What about including any warnings from grambank check?

That's included (my example above just happened to have none):
$ grambank describe original_sheets/CB-PE-AS_yind1248.tsv

Path:
original_sheets/CB-PE-AS_yind1248.tsv

Check:
CB-PE-AS_yind1248	WARNING	GB117	source given, but no value
CB-PE-AS_yind1248	WARNING	GB117	comment given, but no value

Dimensions:
88 rows
5 columns

Values:
?	 40
0	 33
1	 12
3	  2
	 87

Sources:
Breen 2000:	 98

Coders:
CB	Claire Bowern:	 87
PE	Patience Epps:	 87
AS	Amalia Skilton:	 87

cool!


Test new implementation of vcl::utils::Pos

Test this version with casting operator of OpenCV type cv::Point_.

Completed & tested via #142.


correct bitrate range

Can you add the bit about the VIP servers?

What do you exactly mean?
(If you give me collabrator on your fork I could directly commit saving you the extra step of needing to merge each PR)

the bitrate (in bits) of the voice channel; 8000 to 96000 (128000 for VIP servers)

I'll just stash that commit and commit a new one... Thanks!


Generate default domain for Shoots

What this PR does / why we need it:
In case the Shoot manifest does not have any domain configured in
.spec.dns.domain and spec.dns.provider field is not unmanaged,
the ShootDNSHostedZone admission plugin generates
a domain for it by applying the following pattern:
<shootName>.<projectName>.<managed-domain>
Which issue(s) this PR fixes:
Fixes #544
Release note:

Gardener now generates a default domain <shootName>.<projectName>.<managed-domain> when a Shoot cluster is created for which no `.spec.dns.domain` has been set and `.spec.dns.provider` field is not `unmanaged`.

Thanks for your review @rfranzke! I've addressed your comments, PTAL.


GH-1577 / Make processNewOrUpdatedSchema asynchronous

Short term fix for of https://github.com/Hyperfoil/Horreum/issues/1577
Feature idea.
Since fixing https://github.com/Hyperfoil/Horreum/issues/1577 in the proper way could require some additional refactoring, that could have other implication, as short-term goal we decided to make the processNewOrUpdatedSchema https://github.com/Hyperfoil/Horreum/blob/3849f043bb457deb86df5fb8ecab5fc8fc3de588/horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java#L176-L182
asynchronous, such that the creation/update of a Schema would become quite immediate and the run_schemas update (especially the FIND_RUNS_WITH_URI query execution) is handled asynchronously.
Describe the solution you'd like
Create a new channel to manage this new event type, on event receiving, trigger the processNewOrUpdatedSchema method.
Additional information
n/a

Worth to note that with this (temporary) approach we should stick with an increased transaction timeout (~120s) otherwise the FIND_RUNS_WITH_URI query will go in timeout even in the async process.

This approach should also include some update to the UI so that the user knows the change is being processed in the background. There are parts of UI (e.g. assigning a run's schema) that relied on this being a synchronous operation.

This approach should also include some update to the UI so that the user knows the change is being processed in the background. There are parts of UI (e.g. assigning a run's schema) that relied on this being a synchronous operation.

Good point, since this is meant to be (hopefully) a temporary solution, do you think it would be enough to show a popup/warning/alert on schema save?

Something in the banner display or any other inline popup might work. I would avoid any use of alert or a modal.


Can cause crashes when used with multiple threads at once - thread-safety

After trying to diagnose an intermittent crash in some software, I finally came to the realisation that multiple threads were querying the ADS at once. Due to the way the code works, it currently isn't thread safe and can deadlock waiting for a response from the ADS.
I've made a solution in the software using threading.RLock, but I was wondering if anyone would be interested in fixing this upstream in this code as well. If so, I'll fork, make my modifications, and submit a pull request.
Hamish

ideally we would add peripheral locking support to blinka - we do in the microcontroller - then this line would lock the peripheral
https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15/blob/master/adafruit_ads1x15/ads1x15.py#L198
let me know if you're interested in doing that, it would solve the problem over all for any sensor then :)

That sounds like a good idea.
I'm not familiar with blinka, but by the sounds of it that would be a much more helpful fix. I don't have any ADS/other adafruit devices to hand to make sure it works, so would someone else be able to test it works with real hardware for me?

Looks like blinka is a pretty complex project. Are there any docs that could help me get an idea of what is where?

how are you testing this PR?

I tested the software modification I made to my project with real hardware, but I don't have access to it any more - it's part of an operational system. I may be able to write a test program that exhibits the issue for a colleague, who can then check that the fix works.

I've sorted this out with my colleague - I can borrow some hardware from them to work on and test this fix. I'll start work on this next week and hopefully will have something ready at the weekend.

Do you have a unit test framework for Blinka? I'm wondering how to make an automated test for this fix. I can write a test program, but I assume it would be better to integrate it into the unit tests.

we do, however nothing finds bugs like real hardware uses :)

Apologies for the delay.
I have added my fix into the repository at https://github.com/hamishmb/Adafruit_Blinka. I have also written a test program, which is attached. I'm having issues getting it to crash for some reason, but it works fine with the modified, thread-safe version.

hiya yes please submit PR's to Blinka, our maintainer will look & test :)

Looks like this was handled with PR #170  from the Blinka project. I'm going to close the issue here.


Added ability to print version info

This resolves #306

This way, there is only one version number, in pyproject.toml.
For the develop branch, I suppose I can bump the version number and test against that.

@mathomp4 On second thought, it's probably best to test against the last released version number.


[Java Client] Fix wrong schema version of messages without schema

Motivation
When I tried to consume a topic via a consumer with Avro schema while
the topic was produced by a producer without schema, the consumption
failed. It's because MultiVersionSchemaInfoProvider#getSchemaByVersion
doesn't check if schemaVersion is an empty byte array. If yes, a
BytesSchemaVersion of an empty array will be passed to cache.get and
then passed to loadSchema.
https://github.com/apache/pulsar/blob/f90ef9c6ad88c4f94ce1fcc682bbf3f3189cbf2a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/MultiVersionSchemaInfoProvider.java#L94-L98
However, LookupService#getSchema cannot accept an empty byte array as
the version, so loadSchema failed.
The root cause is that the schema version was set unexpectly when
messages were sent by a producer without schema. At broker side, the
returned schema version is never null. If the schema version was an
empty array, then it means the message doesn't have schema. However, at
Java client side, the empty byte array is treated as an existing schema
and the schema version field will be set. When consumer receives the
message, it will try to load schema whose version is an empty array.
Modifications

When a producer receives a response whose schema version is an empty
byte array, just ignore it.
Fix the existing tests.
Add testConsumeAvroMessagesWithoutSchema to cover the case that
messages without schema are compatible with the schema.

This patch also modifies the existing behavior when
schemaValidationEnforced is false and messages are produced by a
producer without schema and consumed by a consumer with schema.

If the message is incompatible with the schema

Before: getSchemaVersion returns an empty array and getValue
fails with UncheckedExecutionException:

com.google.common.util.concurrent.UncheckedExecutionException: org.apache.commons.lang3.SerializationException: Failed at fetching schema info for EMPTY

After: getSchemaVersion returns null and getValue fails with
SchemaSerializationException.

Otherwise (the message is compatible with the schema)

Before: getSchemaVersion returns an empty array and getValue
fails with UncheckedExecutionException.
After: getSchemaVersion returns null and getValue returns the
correctly decoded object.

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] no-need-doc
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

I found https://github.com/apache/pulsar/pull/14626 also tried to fix the similar issue but it didn't fix in a correct way.

        if (version != null && version.length == 0) {
            schemaFuture.completeExceptionally(new SchemaSerializationException("Empty schema version"));
            return schemaFuture;
        }

This error message added in #14626 could make users more confused. A SchemaSerializationException should represents the error when a byte array is serialized by an Avro schema. "Empty schema version" doesn't indicate anything because schema version is not a part of the message itself.

@BewareMyPower @Technoboy- I think this one is related to the discussion in the mailing list?

@codelipenghui Thanks, I will reply in the email.
@Technoboy- Because it still tried to perform topic look up with an empty byte array schema version, which always throws an exception before decoding the message value. #14626 just modifies the error message caused by the unexpected look up. See more details in the PR description and my previous explanation.

There are still other failed tests caused by this change, I'll fix them soon.

@codelipenghui @congbobo184 @Technoboy-  @mattisonchao Now all required tests passed, PTAL.


End recording and start streaming again - bug fix

After recording is finished record_device destructor is called. The vector of shared_ptr that points to each record_sensor is cleared but record_sensor isn't destructed.
It is caused because the lambda function in record_device::create_record_sensors calls recording_sensor (shared_ptrlibrealsense::record_sensor) without using weak_ptr.

removed paramaters that are not used inside the function.

Tracked by?

BTW, do you think we can add a UT for this?
That fail before the fix and pass after it?


nng: 1.6.0-prerelease update for rPackages.nanonext

Description of changes
Updating 1.6.0-prerelease to 8e1836f for rPackages.nanonext, which is the only dependent package on this library in nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

Result of nixpkgs-review pr 240442 run on x86_64-linux 1

1 package built:

nng

Thanks @jbedo. Ready for merge


[RSunstone] Add --force option to OneFlow Service Recover

Description
In order to recover a OneFlow service, Sunstone presents an Action Button. This button sends a flat Recover order, and it is not possible to specify the --force option, which is needed for some service transient states
Use case
Recover a service in FAILED_DEPLOYED.
Interface Changes
Add a modal dialog containing the name of the service and an optional checkbox for --force.
Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

wontfix


Run multiple Appium server in a single machine

Current architecture allows me run one instance of Appium server on a single machine at port 4723. But there should be a provision to run multiple instances of Appium server on a single machine on different ports as Appium supports multiple instances.

Hi @sohammukherjee,
It's possible to run multiple Appium servers on a single machine with Grid Extras. You should create a json file for each Appium server with different ports and add file names to node config files list.
appium_node_4723.json:
"configuration": {
  ...
  "port": 4723,
  "host": "host_ip",
  "url": "http://host_ip:4723/wd/hub",
  "appiumStartCommand": "appium",
}

appium_node_4725.json:
"configuration": {
  ...
  "port": 4725,
  "host": "host_ip",
  "url": "http://host_ip:4725/wd/hub",
  "appiumStartCommand": "appium",
}

selenium_grid_extras_config.json:
"node_config_files": [
  "appium_node_4723.json",
  "appium_node_4725.json"
],

Thanks a lot @rgonalo

why we have to create seprate json files for appium and then combine them into one later?

@rgonalo rgonalo


Add GCP install script

This PR adds simple deploy script into Google Cloud
We'll add docs into matic-docs repo

IMO this could be done using Ansible itself, also having hardcoded versions makes it difficult to maintain.

also having hardcoded versions makes it difficult to maintain.
it has been partially addressed per https://github.com/maticnetwork/node-ansible/pull/34


change deprecated usage of res.send

Summary
Small fix to replace deprecated usage of res.send(); for status codes.
Currently, a deprecation warning will get propagated down to bolt users if they hit this catch block.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

Your change looks good to me. I will wait for responses from other maintainers for a few business days before merging it. Thanks for fixing this!


kernel.yama.ptrace_scope default

Feature Request or Enhancement

[ ] Feature
[x] Enhancement

Summary of Request
Can't find any mentions of yama nor ptrace in source code or docs. System seems to use RHEL default:
$ sysctl kernel.yama.ptrace_scope
kernel.yama.ptrace_scope = 0

even after hardening. Seems super lax to me, but I guess it can also be argued that this is just a baseline. Any thoughts?
https://www.kernel.org/doc/html/latest/admin-guide/LSM/Yama.html
Cheers, Juho

hi @jukuisma
This is actually part of the v2.0.0 CIS benchmark, which is due to be released in the next couple of weeks.
Many thanks
uk-bolly


Invalid VNode breaks conditionals

Version
3.0.6
Reproduction link
https://codesandbox.io/s/invalid-vnode-breaks-conditionals-39zqo
Steps to reproduce
In a conditional group, render an invalid vnode, then change the condition so that it'll render a valid vnode.
What is expected?
It should render the valid vnodes after having rendered an invalid vnode.
What is actually happening?
The conditional group breaks with Cannot read property 'parentNode' of undefined errors.

The runtime raises the [Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. warning.
This issue came up when a user tried to define an async component as a function returning the result of calling defineAsyncComponent.
{
  component: () => defineAsyncComponent(() => import('./Foo.vue'))
}

This seemingly makes the runtime think it's a functional component, which returns the resulting object of defineAsyncComponent(...), and that is of course not a valid vnode.

It should render the valid vnodes after having rendered an invalid vnode.

Not sure how to interpret that.
What do you expect Vue to render/do when it receives a "functional component" that really isn't one? just render nothing, and essentially silently fail? Throw a warning? an error?
I think we can improve the error message here, but it should throw an error when a functional component doesn't return a vnode like it's supposed to, shouldn't it?

It's not intuitive to me that something that only raises a warning should then make the component break. As there's no error after rendering the invalid vnodes was attempted, I think it's reasonable to think that it should continue without error. Especially when the proceeding actions are completely valid.

I may make sense in this scenario, but may cause a break later in other scenarios, which then would have to be traced back to the warning.
If you try to render something that is not a valid vnode / component / null, you wrote code that is fundamentally wrong and you probably shouldn't be able to ignore a warning and proceed with your development - maybe ending up commiting code that breaks the app. You should stop, find the fundamental error in your code and fix it before moving on.
Though we could support that with better errors, hopefully.


[HELP] Toggle Not Rendering, Shows Checkbox

I am not sure if this is a bug or not, so I am asking for help to confirm.
I am on ASP.net Core 6 Razor Pages, Bootstrap v5.3.2, latest release of BS5-Toggle. Following the exact instructions provided on https://palcarazm.github.io/bootstrap5-toggle/#usage-1 resulting in this basic markup:

	<input type="checkbox" id="isLockedOut" data-toggle="toggle" data-size="lg" data-onstyle="danger" data-onlabel="Locked Out" data-offlabel="Unlocked" data-style="quick" data-onvalue="true" data-offvalue="false" aria-required="true" @(Model.IsLockedOut ? "checked" : "") />

and the result is this:

can anyone see a problem or suggest a solution? thank you.

Same issue here, not found a solution yet...

Hi,
I'm not in asp.net, I can't help you.
The issue is the js is been executed when the checkbox haven't been already render by asp.net.
I don't know if we can schedule de js to be launch when asp.net had finished.

@palcarazm ASP.net is nothing special in that regard, CSS and scripts are loaded client side and is simple HTML, only the event management server side is what can be "in limbo". Unfortunately I had to meet a deadline and decided to just use the default toggle that is in Bootstrap 5. But I'd like to use this in the future so a solution would be appreciated.
Also, to add, I did a very very stripped down code for the toggle and it worked, but in the full context of Bootstrap added, it fails. I didn't think they would be relevant to each other, perhaps a CSS is overriding it? Missing an !important somewhere maybe? Not sure, just thinking out loud.

Hi @Major-Mike ans @SnakeME ,
It seems that asp.net throws the "loaded" event before all the components or sections have actually been loaded.
This assumes that the autorender included in the library is triggered prematurely (when your checkboxes are not yet in the DOM).
The solutions I can think of involve rendering by hand.
Here a simulation : https://codepen.io/palcarazm/pen/poBqzwj
Either by giving your checkbox the attributes in the HTML and launching the manual rendering from the same file where your checkbox is generated:

	<input type="checkbox" id="my-unique-id" data-toggle="toggle" data-size="lg" data-onstyle="danger" data-onlabel="Locked Out" data-offlabel="Unlocked" data-style="quick" data-onvalue="true" data-offvalue="false" aria-required="true" @(Model.IsLockedOut ? "checked" : "") />

Either by directly generating the element from JS in the file where the toggle should be:

	<input type="checkbox" id="my-unique-id" aria-required="true" @(Model.IsLockedOut ? "checked" : "") />

Sorry for the late solution. I had to attend to other projects.


[enhancement] Add missing bower.json.

Hey, maintainer(s) of eu81273/angular.treeview!
We at VersionEye are working hard to keep up the quality of the bower's registry.
We just finished our initial analysis of the quality of the Bower.io registry:
7530 - registered packages, 224 of them doesnt exists anymore;
We analysed 7306  existing packages and  1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).
Sadly, your library eu81273/angular.treeview is one of them.
Can you spare 15 minutes to help us to make Bower better?
Just add a new file bower.json and  change attributes.
{
  "name": "eu81273/angular.treeview",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.
NB! Please validate your bower.json with jsonlint before commiting your updates.
Thank you!
Timo,
twitter: @versioneye
email<EMAIL_ADDRESS>VersionEye - no more legacy software!

+1
I would really like to be able to install eu81273/angular.treeview using bower

+1
yeah, it causes some issue when you use gulp to filter the bower dependencies since there is no "main: path/to" in bower.json file


OpenPgpMetadata.isIntegrityProtected() is no longer there

What is instead of it? I remember we were discussing that some exception should be there instead of it and there must be a way to suppress that exception. But I also think if you suppress exception you should have such flag to be able to check it.

PGPainless now requires data to be integrity protected.

At least my current code uses it. I just upgraded to a new version and facing that my code no longer compiles. I will explore a new solution (exceptions) and let you know if that works good enough.

For reference:
The sequoia test suite shows no implementation allowing unprotected data to be acceptable ("Downgrade to SED").
If not required, I would prefer not to add support for insecure data.

Exception seems to work. So closing this one.


Saving the best model

Hi,
Nice work and I would love to hear back from you.
I just realized in your README that you record the best model during training. For that are you using the testing data or validation data?

Yes, it is for testing data.
Thank you!

I will close the issue for now. Feel free to reopen it if you have any further questions.


SubmissionsController: provide helpful redirects when invalid URLs are accessed

What does this PR do?
This PR updates the SubmissionsController to add an index action and update the new action.

In the case of the index action, we redirect to the proposals #index route and display a notice flash message.
In the case of the new action, if there is no proposal provided, we redirect to the proposals #index route and display a notice flash message.

Why was this work done? Is there a related Issue?
This work was done in response to Issue Number 48, which notes that if someone happens to alter the URL (likely with knowledge of rails routes) to try to view the submissions index/new pages, an unhelpful error page is shown. The flash message should help contextualize the role of a submission, articulating why these pages do not exist (or need to exist).
Are there any manual testing steps?

Navigate to http://localhost:3000/submissions/new
Navigate to http://localhost:3000/submissions

Caveat about styling
This related CR by Hilary styles the flash messages, so they will look much better than shown below!!

Screenshots
http://localhost:3000/submissions/new

http://localhost:3000/submissions

Great stuff! I'm going to change the wording of the flash messages slightly, but other than that: awesome! Thank you!


deb-src packages not published

Prerequisites

[X ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom PPA repo contains binary amd64 and x86_64 DEB packages but no apt-src packages which makes anyone using other architectures very sad.
Steps to Reproduce

Use RaspberryPi or Pinebook or any other armhf architecture
Configure deb--src repository in /etc/apt/sources.list.d/atom.list per instructions
Run apt-src install atom

Expected behavior:
Run apt-src install atom and apt-src build atom to build a new binary package for your architecture on any platform from source.
Actual behavior:
apt-src install atom fails because the source DEB packages are not published in the above repo
Reproduces how often:
Alwasy.
Versions

Additional Information
This is a simple omission in the CI/CD system I suspect that should be easy to fix as the DEB source packages are natural part of the binary DEB build cycle, they just need to be published into the repo.

Unfortunately, despite being based on Electron, Atom is not maintained on ARM architecture as has been explained before. We aren't going to officially distribute a package we know is broken, sorry!