NIFI-3914: Do not validate that remote group ports can start transmit…

…ting if there is no connection
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

will review

code changes look good.  verified issue before patch and correction with new code.  Travis builds all failed in different ways but had successful build locally with tests


gluet.get_tables() method should return catalog id, which is the<PHONE_NUMBER>12, the fake AWS Account Id

Based on boto3 document, glue.get_tables() should return {"Name": "table_name", "DatabaseName": "database_name", "CatalogId": "AwsAccountId", more attributes here}
However moto doesn't returns catalog id, which is a very important component for unique id / arn.
I checked the source code the FakeDatabase and the FakeTable implementation are not correct, they should take a catalog_id argument, which is AWS Account Id of this account. The catalog id is designed for sharing glue table across account. You can find more information about catalog id in this RePost
Here's my suggestion how to fix it:

first, go to fake database and fake table data class add catalog_id attribute.
second, go to create_database and create_table method, since the self is the Backend object, it has an attribute account_id, just pass it to the dataclass.
third, check the get_database / get_databases / get_table / get_tables method, see if you return the catalog_id propertly.

Thank you for the awesome project

Thanks for raising this @MacHu-GWU - I'll have a PR ready shortly that fixes this.


Type config Phaser.Tilemaps.LayerData.data is not right, impossible to loop over 2D array in TypeScript

Type of data member in Phaser.Tilemaps.LayerData is not Array of Number but rather an array of an array of Tiles. This is an issue when manually looping over the data Array, as Typescript doesn't allow you to dig in the multidimensional array.
https://photonstorm.github.io/phaser3-docs/Phaser.Tilemaps.LayerData.html#data__anchor

How can I fix it quickly?

I worked around it for now by casting the result to any:
let sub:Phaser.Tilemaps.Tile[] = layer.layer.data[i] as any;
However, might be good if the typings themselves are also fixed...

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Suggestion: TV Show episode rename

Can you make the tv show episode name in this format (Series title - Season Number Episode Number - Name of episode)  Is that possible? or the original file name?

Hello
I know you waited almost a year, I'm really sorry for that!
I changed the name to the format 'Series name - SxxExx - episode name.container'. I hope that does what you want.


[Bug report]: TdsTextField not marked as 'touched' after unfocusing

Requirements before reporting

[X] No duplicated issue reported.
[X] I have checked the latest version if the bug exist there. See all available packages at npmJS.com
[X] I have followed the installation guide.

Package versions
@scania/tegel-angular: 1.6.1
Browser
Firefox
Framework
Angular
Version
Angular 16.2.0
Reproduction steps

Add <tds-text-field> to html template
Add formControl property to it
Log or render the touched property
Click inside the textbox
Click outside the textbox

Code example
<form [formGroup]="testForm">
  <tds-text-field
    ngDefaultControl
    [formControl]="testForm.controls.text"
    type="text"
    size="lg"
    label="Bugreport"
    label-position="inside"
    placeholder="Bugreport" />

Touched: {{ testForm.controls.text.touched }}

</form>

interface TestForm {
  text: FormControl<string | null>;
}

@Component({...})
export class TestComponent {
  readonly testForm = this.fb.group<TestForm>({
    text: this.fb.control(''),
  });
}

Now I have temporarily solved this issue by creating a directive for the tds-text-field. I manually mark the control as dirty and subsequently mark the view as changed in the tdsBlur() handle:
@Directive({ selector: 'tds-text-field[tdsExt]' })
export class TdsTextFieldExtDirective implements OnDestroy {
  private readonly tdsTextField = inject(TdsTextField);
  private readonly cdr = inject(ChangeDetectorRef);

  @Input({ alias: 'formControl', required: true }) control!: FormControl;

  private readonly tdsBlurSub = this.tdsTextField.tdsBlur
    .pipe(
      tap(() => {
        this.control.markAsTouched();
        this.cdr.markForCheck();
      })
    )
    .subscribe();

  ngOnDestroy(): void {
    this.tdsBlurSub.unsubscribe();
  }

  // ...
}

Screenshots
Current:

Expected:

Expected behaviour
When a user focuses on a text field and subsequently unfocuses, the field should be marked as touched.
Console errors
No response
Contact information
<EMAIL_ADDRESS>

Since we are working with custom events the directive you have created above might be the only solution. And since we aren't really building angular components (web-components wrapped in angular) I don't think we can include this directive and support it out of the box.
I'm guessing touched runs on "blur" but we can't emit a native blur event, and that's why we have added the "tdsBlur"

Hey @Patrick2607 , we are also using the tegel-angular package on my project and I decided to create an MR that adds reactive form support from tegel.
You can check out the PR here: https://github.com/scania-digital-design-system/tegel/pull/598
This is the beta version that contains the changes<EMAIL_ADDRESS>Could you install this version and test if it solves your issue?

The user confirmed that the issues are gone after updating to the newer version of code that contains Jernej's changes.


Can't run viewer

Here is what I get...
C:\Users\808\Android\Cozmo-Explorer-Tool>py viewer.py
Traceback (most recent call last):
File "viewer.py", line 23, in
from flask import request,make_response, send_file, Blueprint
ModuleNotFoundError: No module named 'flask'

Hopefully this issue is resolved. Closing it due to time passed. Please create a new issue if the problem persists.


[cwc-v2] Wrong button icon position

Description
With the @carbon/web-components@1:

https://stackblitz.com/edit/vitejs-vite-fxvejh?file=index.html
With the @carbon/web-components@2:

https://stackblitz.com/edit/vitejs-vite-tkmrdt?file=index.html
Component(s) impacted
cds-button with icons
Browser
No response
Carbon for IBM.com version
v2 beta
Severity
Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.
Application/website

Package
@carbon/web-components
CodeSandbox example
https://stackblitz.com/edit/vitejs-vite-tkmrdt?file=index.html
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[x] I checked the current issues for duplicate issues

In v1 did this the trick:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/9cd56a3940bfa0fdcb7d454cb9e826d11a8a44f6/packages/carbon-web-components/src/components/button/button.scss#L23-L28

And @carbon/styles has:
https://github.com/carbon-design-system/carbon/blob/033ecc706d181d640d4b02ded0baddf0852f8f21/packages/styles/scss/components/button/_mixins.scss#L83-L95

Closed by https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/10614


chore(util): add utility for fetching block timestamp

:tada: This PR is included in version 2.4.0-alpha.13 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The panel not showing any graphics - module.js error

Hi,
The panel worked before (Grafana 7.3.6) although I have only been experimenting with it previously. Recently, I resumed my experimentation but I'm getting an error coming up in Chrom console:

I don't seem any graphics displayed, either in edit or display mode. If I open in draw.io, the drawing displays, so it's not an issue with a drawing.
I have updated to latest 7.5.0 to see if it can clear the issue but no luck.
Exception happens in this bit of code when running new Graph(this.container)  (at line 10452 of module.js once prettified in Chrome):
key: "initGraph",
                    value: function() {
                        var t = p.a.trace.before(this.constructor.name + ".initGraph()");
                        return this.graph = new Graph(this.container),
                        this.graph.setPanning(!0),
                        this.clickBackup = this.graph.click,
                        this.dbclickBackup = this.graph.dblClick,
                        mxEvent.addMouseWheelListener(mxUtils.bind(this, this.eventMouseWheel), this.container),
                        (mxClient.IS_IE || mxClient.IS_EDGE) && mxEvent.addListener(this.container, "wheel", mxUtils.bind(this, this.eventMouseWheel)),
                        mxEvent.addListener(document, "keydown", mxUtils.bind(this, this.eventKey)),
                        this.container.addEventListener("contextmenu", (function(t) {
                            return t.preventDefault()
                        }
                        )),
                        this.graph.dblClick = this.eventDbClick.bind(this),
                        t.after(),
                        this
                    }

I don't know if this is enough info to investigate further but I'm happy to provide more if pointed in the right direction.
Cheers.

Ok, further digging into the exception debugging revealed the culprit - another panel's module.js seems to be interfering with this panel when in the same dashboard. Simple solution is to use a separate dashboard for my experimentations.
ReferenceError: Graph is not defined
at t.value (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:199167)
at new t (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:195973)
at t.value (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:258068)
at t.value (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:260105)
at eval (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:269791)
at Array.forEach ()
at t.value (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:269768)
at t.eval (http://tas-hist02/public/plugins/agenty-flowcharting-panel/module.js:2:267185)
at c (http://tas-hist02/public/plugins/jdbranham-diagram-panel/module.js:2:642713)
at Generator.eval [as _invoke] (http://tas-hist02/public/plugins/jdbranham-diagram-panel/module.js:2:642466)


Add basic support for LTDC screen controller

Addded:

LTDC config
Layers config

Tested on STM32F7DISCO board with embedded graphics with pixel formats L8 and RGB565.
Question : The LTDC periph needs and address and a length to know where to find the FrameBuffer(s). For now a frame buffer is just a  &'static mut [T] with T: SupportedWord but I'd like to make it more general.
The DMA already includes some buffer trait and struct, should I put it in a separate module or use it from ltdc ?

The LTDC periph needs and address and a length to know where to find the FrameBuffer(s). For now a frame buffer is just a &'static mut [T] with T: SupportedWord but I'd like to make it more general.
The DMA already includes some buffer trait and struct, should I put it in a separate module or use it from ltdc ?

Good question. IMO seems reasonable to share Buffer/PtrBuffer with ltdc and it would probably be clearer if we broke out those types into their own module (buffer.rs or something). Also, I'm cool if we do that in this patch or save it for future work. Let me know what you think @grodino ?

I do have an example but it is quite messy for now. I'm working on hardware acceleration now, I will clean up the example after.
You can merge now or then, as you want !

I do have an example but it is quite messy for now. I'm working on hardware acceleration now, I will clean up the example after.

Sounds good!


uninitialized constant Fleek::Server::Listen (NameError)

=> Booting Puma
=> Rails 5.0.0.beta3 application starting in development on http://<IP_ADDRESS>:3000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Exiting
/Users/username/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/fleek-0.1.2/lib/fleek/server.rb:13:in `initialize': uninitialized constant Fleek::Server::Listen (NameError)

any ideas @bouk ?

they probably changed something with Listen not being loaded by default in the new beta, I'll probably have to add a require 'listen' in that file


Solved issue #140

when a staff cancel answering a question, the messages on the button and modal are more clear

which one is the linter issue? Sure I will change the text on button

Click on the Travis status check and read through for errors.

There seems to be test cases for the button with message “cancel”, should I change those test cases as well?

I think I accidentally added yarn to the dependency. I will remove that

Almost there! The text that a person sees when they click cancel but aren't the one answering is a bit confusing; it's the same "You will stop answering this question but this question will stay in the queue." that a person who is answering will see. Can you look into improving that?

Do you know how can I sign in when running locally as another user? Both as a non admin staff and as a student, so that I can see the result of my changes.

Check the Readme: https://github.com/illinois/queue#multiple-users-in-dev-mode

Does "Someone else is answering this question and you will interrupt it. This question will stay in the queue." sound good? The confirm button text will be "interrupt" and the cancel button will say "cancel"

#140

@Xiangmingchen can you fix the newly broken test?

Thanks for reminding, I have updated the Changelog.


Add a state-lock call-tracker for detecting interrupt-cycles

This change introduces a new FSM call-tracker that is attached to select
recursive APIs (list/setAttributes/setAcl) in order for them to
respect a pending backup and bail.
pr-link: Alluxio/alluxio#11592
change-id: cid-4a140127d2f37aa1bca4d1283ad035371abdaab0

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10122/
Test FAILed.

alluxio-bot, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10123/
Test PASSed.

alluxio-bot, merge this please


Add favicon-based identicons

Thank you for this useful App. Can you please consider adding favicons to the identiconizer? Favicons are easier to tell apart than identicons because they tend be more unique, and they're generally more relevant than an algorithmic identicon.
For instance,

If the contact's email address is<EMAIL_ADDRESS>then download http://xposed.info/favicon.ico and use it as the photo.
If that favicon is not found, then search for favicons using the other email or website fields of that contact.
If no favicons can be found, then generate a regular identicon.
To ensure that several contacts using popular webmail addresses such as gmail or Yahoo don't end up with identical favicons, either (1) use the selected default identiconizer style, then add that domain's favicon in the lower right corner of that identicon, or (2) overlay the first character of their name over the favicon

For more flexibility, you could add a favicon-to-identicon threshold: if there are more than x contacts (e.g. 5) with the same favicon in the contact list, then combine the favicon with a single character overlay to distinguish them from each other. This will ensure that contact photos using common email addresses such as gmail or Yahoo don't look identical.

(Sorry for the late reply, but I'm going through the issues now after a long break from identiconizer.)
Unfortunately, favicons are usually of extremely low resolution compared to what would look good for a contact's photo (usually less than Identiconizer's lowest setting, 96x96, which is also becoming quite small on modern smartphone resolutions).
Pull requests would be welcome, and I might even look into it if there's interest, but it seems like a fair amount of work for a suboptimal feature.


NME: Added a SceneDepth block to access the scene depth buffer

See https://forum.babylonjs.com/t/about-node-material-questions/21498/3

This is super neat! thanks a lot!


Unnecessary Rumination

Rumination occurs near end of sequence even though no CP-using moves occur after it in the sequence.  Waste of a cross-class slot, a macro line, and time.  Inefficient.
Seed 51824
Blacksmith, Initiate's Head Knife, Level 17, Craft 113, Control 111, CP 243, Start Quality 274

Answered in #84.

Was trying to separate issues out as you requested in the other one.  Plus, 84 is marked closed, so while the double inner quiet doesn't occur any longer, this still does.  =/

@Thortok Regardless, it has been answered previously.


Clarification on config.json arguments and usage of bot

Dear Community, dear @Poryaei,
I would like to clarify some points about the arguments in the config.json file:
"api_id": 8086441,
"admin":<PHONE_NUMBER>,

In the README.md, it is stated:
"Replace the value of admin with the numeric ID of the admin. You can get this ID by contacting @chatIDrobot on Telegram."
I contacted this bot and received the following:
name: "My_name"
🆔 username: @my_name
📱 chat_id: 86125206
🉐 language: en

The chat_id I received (86125206) is quite different from the example value of admin<PHONE_NUMBER>) in the default configuration.
Should I add this value, or am I missing something?
Could you please explain and possibly add to the documentation what "api_id", "api_hash", and "admin" are used for?
I created the bot and added the token to "bot_token", but I am unclear about the bot's purpose.
I would like to ask for some clarification regarding the max_days_for_return parameter in the documentation. By default, it is set to 5, but I am unsure how the bot will behave once all cards exceed this value. Will the farming process continue effectively?
For example, I have multiple accounts: one is new, and another has an income of 1 million per hour. Naturally, they have different payback periods, and for the latter, the profitable cards may have a payback period of up to 100 days. However, I do not want to change the setting in a way that would negatively affect the new account.
Could you please explain how the bot handles this situation and if there are any recommended practices for managing multiple accounts with varying income levels?
Best regards,

I just figured out that the "admin" parameter actually means the referral code for the Hamster bot. This wasn't immediately obvious. Could the description in the documentation be updated to reflect this?


feat(pointcloud_preprocessor): support for 3d distortion correction algorithm and refactor distortion correction node

Description
This PR solved the issue https://github.com/autowarefoundation/autoware.universe/issues/6657.
This PR provides an option for the user to choose a 3d distortion corrector instead of using the current 2d distortion corrector.
Note that by using this, the time will increase around 50 percent.
This PR also refactored the distortion correction node to make the code cleaner and support different undistortion strategies (ex: hybrid 2d/3d) in the future.
Changes:

once the node gets the TF information between imu, baselink, and lidar, it will stop getting the transformation again.
add 3d undistorted algorithm
refactor the code.

Related links
https://github.com/autowarefoundation/autoware.universe/pull/7031
https://github.com/autowarefoundation/autoware.universe/issues/6657

Tests performed
I tested this PR and ensured the pointcloud output is the same and the processing time has a negligible time difference (the result is different every time).
Before the PR
Input: mirror pointcloud  (58 frames)
distortion corrector: 2d

Minimum
Maximum
Average

Time
7.15
15.29
10.09

After the PR
Test 1:

Minimum
Maximum
Average

Time
7.516
12.719
9.47

Test2:

Minimum
Maximum
Average

Time
7.5
14.9
10.5

Input: mirror pointcloud  (58 frames)
distortion corrector: 3d
After the PR

Minimum
Maximum
Average

Time
13.02
22.26
16.05

Per point calculation time

test with 58 frames * 3 times
2d algorithm

Before PR

Minimum
Maximum
Average
Std Dev
50%
99%

Time
4.000000e-08
3.256100e-05
5.722510e-08
3.861742e-08
5.600000e-08
7.000000e-08

After PR

Minimum
Maximum
Average
Std Dev
50%
99%

Time
4.400000e-08
3.476100e-05
5.898946e-08
4.029356e-08
5.800000e-08
7.200000e-08

Pointcloud comparison
@meliketanrikulu
Checked distortion corrector input point cloud and output point cloud for understanding difference coming with this PR. I did this test by viewing the moments when it passed through speed bumps.
Before this PR:

Blue pc : Input of the distortion corrector
White pc : Output of the distortion corrector
We can see here pc which is output of the distortion corrector does not changes in direction z

After this PR:

Blue pc : Input of the distortion corrector
White pc : Output of the distortion corrector

We can see here pc which is output of the distortion corrector is changes in direction z.
After seeing this change, I tested it with ground segmentation to see if it provided an improvement.
Test with Ground Segmentation:
You can see below that ground segmentation adds ground points to non-ground points when passing through speed bump before the changes occur.
Before 3d distortion corrector (ground segmentation test) Video link is here
I observed that this error did not occur after checkout the 3d distortion corrector branch.
After 3d distortion corrector (ground segmentation test) Video link is here
Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf
This PR and https://github.com/autowarefoundation/autoware.universe/pull/7031 contain all the core changes to the distortion correction and thus makes no sense (to me) to have them split like this. If you only want us to check the refactor part in this PR, should the base not be the other PR rather than main? Otherwise it is really double work.

(I am aware that you want to merge the other one first, in which case this PR automatically would show only the rafactor changes, but 1) main is blocked right now. 2) the PRs should be merged rather together)

@knzo25
Thanks, then I will close another PR and put the results in this PR.
I will also make the changes for the new pointcloud type.

@vividf
I was sure I wrote it somewhere before, but you need to make sure of the availability of the library that you are using.
Please take a look at the documentation regarding package.xml and rosdep

@vividf
The name undistorter seems quite unnatural to me.
I would recommend changing distortion_corrector.cpp to be in line with the other nodelets and use it as a change to call your undistorter -> distortion_corrector.cpp. Is there any technical reason to put is an additional library? Why not just as a source file in the pointcloud_preprocessor_filter target?

@knzo25  Thanks, I fixed in this commit https://github.com/autowarefoundation/autoware.universe/pull/7137/commits/b3504a532c4be29561332379e8c3f91e729e0b2b
However, after changing the name, it will be a bit hard to do the code review by comparing the differences.
As the distortion_corrector.cpp -> distortion_corrector_nodelet.cpp
and the undistorter.cpp -> distortion_corrector.cpp

@vividf There is a comment regarding file names.
The name nodelet is a remnant of ROS1 and does not exist in ROS2. Therefore, it may be better to use node instead of nodelet.

@yukkysaito
Thanks, I also consider writing it as distoriton_corrector_node. However, as other nodes are also written in nodelet, so I thought I should write in this way.
I will change to node instead of nodelet in this PR (only for the distortion correction node). For other nodelets (nodes), I can create another PR to fix those together.

@knzo25 Thanks, I fixed in this commit b3504a5
However, after changing the name, it will be a bit hard to do the code review by comparing the differences. As the distortion_corrector.cpp -> distortion_corrector_nodelet.cpp and the undistorter.cpp -> distortion_corrector.cpp

That is why I requested structural changes before going in detail with the code :innocent:

@drwnz
Thanks for the review and suggestions.
Before modifying the name we both agree on changing
distortion_corrector to distortion_corrector_nodelet and  undistorter to distortion_corrector.
As Saito-san and your suggestion, I will now change from distortion_corrector_nodelet  to distortion_corrector_node
[Apology that I told these to Kenzo in Slack, but I should explain here as well for other reviewers]
Regarding adding a library, it is because a colleague and I misunderstood this https://github.com/autowarefoundation/autoware.universe/pull/7137#discussion_r1616173584, so we thought we should change it to the library.

@vividf Hi, would you fix the cppcheck-differential CI? https://github.com/autowarefoundation/autoware.universe/actions/runs/9493353799/job/26161904404
Although it is not a mandatory CI for now, but is likely to be in a near future, so I would recommend to fix these as well. Thanks!
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:101:16: style: The function 'initialize' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
  virtual void initialize() = 0;
               ^
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:[5](https://github.com/autowarefoundation/autoware.universe/actions/runs/9493353799/job/26161904404#step:7:6)7:16: note: Virtual function in base class
  virtual void initialize() = 0;
               ^
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:101:1[6](https://github.com/autowarefoundation/autoware.universe/actions/runs/9493353799/job/26161904404#step:7:7): note: Function in derived class
  virtual void initialize() = 0;
               ^
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:113:16: style: The function 'setPointCloudTransform' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]
  virtual void setPointCloudTransform(
               ^
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:55:16: note: Virtual function in base class
  virtual void setPointCloudTransform(
               ^
sensing/pointcloud_preprocessor/include/pointcloud_preprocessor/distortion_corrector/distortion_corrector.hpp:[11](https://github.com/autowarefoundation/autoware.universe/actions/runs/9493353799/job/26161904404#step:7:12)3:16: note: Function in derived class
  virtual void setPointCloudTransform(
               ^

@vividf
Just in case you missed, I am still waiting for you to fix the sophus part

@kminoda
Thanks, I fixed them in https://github.com/autowarefoundation/autoware.universe/pull/7137/commits/32fcd04373e15d227b25b3144a75081a616c74a2

@vividf
I made some comments. While most of them are inocuous, I am curious about the inlining one.
Once the comments are addressed and I test the PR for form's sake, I will approve it :+1:

Result of comparing processing time of undistortPointcloud function
Before this PR

Test1: mean: 0.006440001206896551, std: 0.0014093338616928428
Test2 :mean: 0.0065778855172413785, std: 0.0013745705415701003
Test3: mean: 0.006549803103448276, std: 0.0013671630420997608

Before adding inline specifier

Test1: mean: 0.00611750724137931, std: 0.0001756723813473595
Test2: mean: 0.0066553743103448275, std: 0.000804669277478411
Test3: mean: 0.008077704827586208, std: 0.0009599856868351832

After adding inline specifier

Test1: mean: 0.006277571034482758, std: 0.0008252748454254698
Test2: mean: 0.006528753793103449, std: 0.000938895249063067
Test3: mean: 0.00644302051724138, std: 0.0009676894234890093

@vividf
There is one comment left + the conflicts

@knzo25
Thanks, I fixed the conflicts and reply the symbol check at https://github.com/autowarefoundation/autoware.universe/pull/7137#discussion_r1652526179

Hello @vividf . Thanks for your work. If it's ready to be merged and you're not planning any other changes, I can test it again. Because a lot of things seem to have changed.

@meliketanrikulu
Sure, would be nice if you could test it again!
Thanks!

Note:
As this PR remove the default value, this PR shouldn't be merged before adding the parameter file for nebula_node_container.launch.py

@drwnz This PR requires your approval :smiley:

@vividf it would be good to sign all your commits to pass DCO.


Improve readme docs, fix local dev env & stake panels errors 🚀

Issues solved in this PR:

[x] [env] Fix app not starting locally due to missing env key variables - add sample .env config for local dev
[x] [Readme] Add proper notes: short overview, requirements, get started steps, notes regarding 'env' config variables and community links
[x] [Stake] Fix React render errors in StakePanel & UnstakePanel when showing a Spinner inside the Text node (invalid DOM nesting on div in p) #minor

@yellowgh0st : As requested.
Also, can we have that infographic image that's used here and in the Vader docs in some common repo (like: vetherasset/branding, maybe under a 'community' dir?) - so we can link it from there instead of the hard one from the Vader docs right now or even adding it to this repo as a file .. ? :/

Awesome

You've located the DOM nesting issue. I really enjoy that.

@yellowgh0st : As requested.
Also, can we have that infographic image that's used here and in the Vader docs in some common repo (like: vetherasset/branding, maybe under a 'community' dir?) - so we can link it from there instead of the hard one from the Vader docs right now or even adding it to this repo as a file .. ? :/

Yes, this is a better approach. I agreed it can be collected in that location.

@yellowgh0st : As requested.
Also, can we have that infographic image that's used here and in the Vader docs in some common repo (like: vetherasset/branding, maybe under a 'community' dir?) - so we can link it from there instead of the hard one from the Vader docs right now or even adding it to this repo as a file .. ? :/

Yes, this is a better approach. I agree it can be collected in that location.

Naisu! 👍


Can't build 5.12 or 5.11?

I checked out the repo and tried to build 5.12 but I get an error. I haven't modified anything and had checked out the tag for 5.12 and even tried 5.11
nathanvanfleet@nvanfleet-MBP114:~/src/maplibre-gl-native/platform/ios$ make iproj
mkdir -p build/ios
(cd build/ios && cmake -G Xcode ../../../../ \
		-DCMAKE_SYSTEM_NAME=iOS )
-- Configuring GL-Native with OpenGL renderer backend
CMake Error at vendor/mapbox-base.cmake:4 (add_subdirectory):
  The source directory

    /Users/nathanvanfleet/src/maplibre-gl-native/vendor/mapbox-base

  does not contain a CMakeLists.txt file.

I don't think these are the root problem, but you can verify:

As of this writing, we only support up to Xcode 12.4
Do you have all the Git Submodules:  e.g., git clone --recurse-submodules
Please verify that you have the dependencies listed here.  These are what the Continuous Integration scripts rely on:

https://github.com/maplibre/maplibre-gl-native/blob/master/.github/workflows/ios-ci.yml#L42-L45

Also make sure to install all of the requirements: https://github.com/maplibre/maplibre-gl-native/blob/master/platform/ios/platform/ios/INSTALL.md

Okay that seems to be it. I can see there is no recurse submodules command here though btw https://github.com/maplibre/maplibre-gl-native/blob/master/platform/ios/platform/ios/INSTALL.md#building-the-sdk

@nvanfleet Most of the stuff on that INSTALL document is from the old mapbox install. Just the first requirements section is relevant.

@nnhubbard  does something like make iframework FORMAT=static BUILDTYPE=Release still work? I am trying to get it to work but am not sure if it's still functional

mkdir -p build/ios
(cd build/ios && cmake -G Xcode ../../../../
-DCMAKE_SYSTEM_NAME=iOS )
-- Configuring GL-Native with OpenGL renderer backend
CMake Error at scripts/license.cmake:24 (message):
License not found for target: Mapbox::Base::shelf-pack-cpp
Call Stack (most recent call first):
scripts/license.cmake:40 (mbgl_generate_license)
CMakeLists.txt:1038 (include)
-- Configuring incomplete, errors occurred!
happened to me in m1x mac, how to fix it?


Fix generateDocs script and rebuild docs

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #105
Summary:
Adds in the fixed generateDocs.js file regex that was replacing name attributes in the API.md with the name of the component.
Rebuild the docs with this change and update the dependencies.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The official website is wrong about calling Python file?

Official website：https://dolphinscheduler.apache.org/zh-cn/docs/1.3.2/user_doc/system-manual.html There is a problem with the compilation of information about python calls.
as follows:

Can be called in python script
python test.py?
Or is it the special processing done by the backend?
When I tried to call like this again without success,
This can easily be misleading.

did you  upload your test.py to resource center？and did you notice that you should choose this test.py first. as follow:

By the way, as a global project, please update/add title and desc in English, thx

Yes,I uploaded my script in the resource center，But it still did not execute successfully。
as follows:

But keep getting wrong results

I can execute successfully in the background of the server

This is my environment configuration

This is the log

What is my possible mistake？？

You can refer to the figure below, to quote the py file in the directory, you need to quote init.py


Remove some overhead caused by unnecessary memory allocations (improving performance by 40%)

The two commits address the unnecessary allocation of message summary for each message passed via Raft and unnecessary allocations of membership infos before publishing metrics.
This alone improved the performance (in ops/second) of an empty Raft with a dummy state machine by about 40%.

Thank you @schreter
It's amazing this small patch boosts the performance by 40%.
BTW, what's the cluster setup and load pattern for this benchmark?
I'd like to set up a standard benchmark to show how a modification affects performance.

Hi @drmingdrmer

BTW, what's the cluster setup and load pattern for this benchmark?

Currently, it's a completely in-memory operation. There are three replicas, each holding a trivial "state machine" holding nothing (both data and response are empty) and a log, which is a map of log index to the Entry in an EBR-protected container (our own EBR implementation with only 7-12ns/protect op overhead on current machines, but the one in crossbeam should be reasonably close performance-wise). The Network implementation directly pushes the RPCs into corresponding Raft instances into follower replicas. So in the end, we have six tasks running, one feeding the Raft with requests (and doing the timing), one running Raft core of the leader and two replication tasks feeding two Raft core tasks of the replica (those two and two are running in lockstep, so basically we can load at most 4 CPU threads).
This setup is chosen intentionally so to pinpoint the overhead in the Raft framework itself and its surrounding code. In the ideal case, we'd have 4 cores running the whole time close to 100%, which is, unfortunately, not the case. In fact, the tasks do not strictly share a single thread, but they effectively only use ~100% of CPU time instead of ~400%, scheduling all over the place across 4 threads. That's a bug (or feature?) in Tokio framework - task stealing simply doesn't work decently. This is one of the two big bottlenecks (the other being  the memory allocation due to async_trait) we are addressing in our project and the one which makes any performance regression tests basically impossible (unless run on a single-threaded runtime). For that, we are considering importing our C++ implementation of task scheduling into Rust, but Tokio framework needs to be changed to allow external runtimes (currently, all of it is private, which is a problem). When I turn off the replication (single leader node), I get almost an order of magnitude more ops/sec (500K/s vs. 67K/s on my machine), though it should be "only" about factor 3. That's the scheduling bug effect. Therefore, I'm quite sure that we'll reach our internal target of 1M Raft ops/sec in the end (on the dummy state machine), which should give us >= 200K/s over the network (not the OS-based TCP/IP, though :-)) and with a "real" state machine.
What I also see is a huge amount of TLS accesses by the tracing framework (to check for trace settings). There seems to be some bug in that as well - if no traces are active, then reading a global variable should prevent accessing any further TLS-local or other data. This is, however, only the third or fourth bottleneck based on the severity.
We need to first clear the memory allocation bottleneck and ideally the scheduling bottleneck, because they are completely polluting the traces and thus I don't see the forest for the trees :-).

I'd like to set up a standard benchmark to show how a modification affects performance.

That's a good idea. But, as mentioned above, the non-determinism will be breaking the benchmark all the time. Also, when executing them, you'll likely suffer from "noisy neighbour" problem when running it in the cloud, unless the benchmark instances are going to be completely isolated from outside influences. Even this simple benchmark I wrote is fluctuating about 5% in a controlled environment.


DSU does not install GSI to sd card

I have an SD card in the device, and go to flash a GSI rom with DSU, but it still says that the size limit is just 40G when the SD card is 512G, and when I try and install it installs to the normal filesystem instead of the SD card. Have tried with the card in exFAT and FAT32 formats, any help would be appreciated.
Thank you!

Some devices may allocate DSU files in internal storage, even when a SD card is available, if you tried to install a GSI, and the SD Card keep being not used, that is what is likely to be happening, also, DSU Sideloader, at least by now, cannot enforce installation on SD, no clue if that is even possible, requires some investigation.


Archive to SFTP

Maybe we'll do this if people express interest.

I think this could be simplified by using rsync (or could even be another archival method using it).
It would be as simple as running rsync -au $ARCHIVE_DIR $FTP_USER@$FTP_SERVER:$FTP_DIR which would copy the contents of the $ARCHIVE_DIR directory (in this case, the mnt/cam/TeslaCam/saved/ folder, could also tie in with #37 maybe?) to $FTP_DIR on another machine, over ssh.
I will use something like this with another storage pi on my network, with a generated ssh keypair from the teslausb pi as authentication. Once I get it working I can open a PR with it.

I'm currently hitting a few snags with my implementation. I'm using campercent=100 on a 64GB card, and it creates a ~53GB CAM mount just fine. I can put a TeslaCam folder on it and put files in that folder on Windows, but now the problem comes from reading that drive on the teslausb pi. For some reason, the /mnt/cam/ folder is empty, despite having the TeslaCam folder (and files in it) that persists through ejecting and plugging back in the teslausb pi. Is my script looking at the wrong spot? I know the traditional method is to move the files over from the cam mount to the archive mount, which is mounted to a shared drive. But that isn't needed for rsync, since it can just copy directly from the mount folder.
Another issue is that it also keeps disconnecting even though the archive server is reachable. Individual, repeated calls to ping to the ftp/rsync server return the packet just fine, so for some reason it can't reach it, unmounts the USB, remounts the USB, and tries to archive again. It's bizarre.

So I did some further digging and was able to figure out the first issue! It was due to the connection to the ftp server requiring accepting the authenticity of the FTP server's host key (needed to type 'yes'), so I'll be updating the instructions to help ensure people don't have this bizarre issue.
The other two issues remain though, and other than the weird disconnection issue causing the teslausb pi to just spam my computer as if I was plugging in and out a USB drive every 5-20 seconds, it should be ready for merge.

I see the malfunctioning device warning, too. It's seemed benign, so I haven' investigated it.
To figure out why the process is deciding that the archive server is unreachable try changing line 14 archiveloop to capture the output of the ping command. Maybe something like this:
ping -q -w 1 -c 1 "$ARCHIVE_HOST_NAME" > /tmp/ping.log 2>&1 || reachable=false

If you're parked so that the Pi is barely connected to the wireless network I could imagine that this test would flip flop. It is a pretty simple heuristic; perhaps it could be improved to calculate some percentage of successful ping results?

When you're ready to merge please submit a pull request.

If you're parked so that the Pi is barely connected to the wireless network I could imagine that this test would flip flop. It is a pretty simple heuristic; perhaps it could be improved to calculate some percentage of successful ping results?

Interestingly enough it wasn't in the car when it was happening, but rather right at my PC, in really good range of the access point. I will try that command though and let you know!
Perhaps running the 10-try retry on the connection method inside archiveloop could be worth doing?

So, I changed the ping to use the output log and couldn't find anything out of the ordinary. Introducing the 10-step retry to archiveloop has worked. I'm not sure if this causes any unintended behavior, since the wait_for_archive_to_be_unreachable function should be sure that the archive is unreachable, right? So if all 10 pings fail, it would be pretty safe to assume the car/pi cannot reach the archive server.

The retry makes sense.
I think we should also add retries for individual file copies.
I expect to be able to regression test your branch on Wednesday evening, if nobody beats me to it.

Alright, I'll open another PR with these changes added!

I'm merging this in u/gocnak/rsync_archive.

This has been merged. I added an "Expermintal" disclaimer in the main readme. I verified that the merge didn't introduce regressions in the existing CIFS archive scenario but didn't verify that the rsync archiving worked.

@Gocnak - Thanks for laying the foundation for me. I haven't tested the actual rsync part but I can verify that the basic structure works since I followed the exact same structure for the rclone version. The only difference is the actual rsync command and those are pretty straightforward. It's worth noting that we can't keep adding more methods like this since it makes the code a little messy but hopefully our 3 methods cover the majority of the use cases now.

@cimryan - I've been using my implementation of it for a while but I do need to reflash with the latest changes. Once I'll do that, I can let you know how it works and we can close the issue.
@rtanaka - No problem! I agree that it could get a little cluttered, especially since this is mostly pure bash, but if the need ever arises, there could be some merit to organize it with some sort of global config or script or something. The idea would be to set the config beforehand, run the setup script, and the archive loop will properly archive to the desired outputs a user wants.

I'm going to assume this works until we hear otherwise.


[9.18] Adding 'stats' property to Commit model

So, when I'm trying to get list of commits with 'with_stats' property - the array 'stats' which Gitlab returns dissapears because no such property added.

Thanks for this. :)

I've added the relevant property to the class level phpdoc too.


Add flag to install dependency only

Signed-off-by: cwen0<EMAIL_ADDRESS>What problem does this PR solve?

Add a new flag to install dependency only by install.sh
Update install.sh
Use IfNotPresent instead of Always

Codecov Report

Merging #631 into master will decrease coverage by 0.16%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   55.78%   55.61%   -0.17%
==========================================
  Files          68       68
  Lines        4383     4398      +15
==========================================
+ Hits         2445     2446       +1
- Misses       1768     1782      +14
  Partials      170      170

Impacted Files
Coverage Δ

controllers/networkchaos/ipset/ipset.go
37.14% <0.00%> (ø)

pkg/store/experiment/experiment.go
32.20% <0.00%> (-6.58%)
:arrow_down:

pkg/utils/chaosdaemon.go
51.21% <0.00%> (ø)

pkg/utils/grpc.go
0.00% <0.00%> (ø)

controllers/twophase/types.go
54.20% <33.33%> (-1.68%)
:arrow_down:

controllers/networkchaos/netem/types.go
47.27% <50.00%> (ø)

controllers/podchaos/containerkill/types.go
64.38% <100.00%> (ø)

controllers/timechaos/types.go
61.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb8d81...10a9d0e. Read the comment docs.


Backup not triggered with incoming/outgoing calls

Hello,
I'm currently testing the latest beta version of SMS Backup Plus and remarked something that may appears as a small bug. First of all, I installed SMS Backup Plus on my Google Pixel XL Smartphone running Nougat 7.1.1. I've, I think, correctly set up SMS Backup Plus as when I send or receive an SMS, the backup is triggered automatically within the time I setup in the software. This is not the case with a phone call (outgoing/incoming call).
Any idea of what I maybe missed or is it a bug ?
Thx for your feedback and also thank you for the work made with this awesome application!

This is possible in the latest beta

Please try out the beta and let us know if it's still an issue https://github.com/jberkel/sms-backup-plus#beta


Make fails when updating form lnd version 0.7.1

Background
Updated client to most recent version in accordance with prescribed directions
When finalizing the update via execution of $ make, there was a failure reported
Environment
lnd version 0.7.1-beta commit=v0.7.1-beta-94 g80c675914027aaf724ad1d5369f4caf94a629da4

go version go1.13 linux/amd64

GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/plato/gocode/bin"
GOCACHE="/home/plato/.cache/go-build"
GOENV="/home/plato/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/plato/gocode"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/plato/gocode/src/github.com/lightningnetwork/lnd/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build977925277=/tmp/go-build -gno-record-gcc-switches"

Linux platolinux 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Steps to reproduce
$ cd $GOPATH/src/github.com/lightningnetwork/lnd
$ cd git pull
$ make clean && make && make install

command "$make" fails and command "$make check" fails too
Execution of $ make check outputs the following:
Building debug lnd and lncli.
GO111MODULE=on go build -v -tags="dev" -o lnd-debug -ldflags "-X github.com/lightningnetwork/lnd/build.Commit=v0.8.0-beta-86-gfcf81ed8ffb7b5b4e4a1aa6ac717a88de28361ee" github.com/lightningnetwork/lnd/cmd/lnd
runtime
'# runtime
/usr/local/go/src/runtime/stubs_x86.go:10:6: stackcheck redeclared in this block
	previous declaration at /usr/local/go/src/runtime/stubs_amd64x.go:10:6
/usr/local/go/src/runtime/unaligned1.go:11:6: readUnaligned32 redeclared in this block
	previous declaration at /usr/local/go/src/runtime/alg.go:321:40
/usr/local/go/src/runtime/unaligned1.go:15:6: readUnaligned64 redeclared in this block
	previous declaration at /usr/local/go/src/runtime/alg.go:329:40
Makefile:91: recipe for target 'build' failed
make: *** [build] Error 2

Execution of $ make check outputs the following:
Installing btcd.
cd /tmp && GO111MODULE=on go get -v<EMAIL_ADDRESS>go: finding github.com/btcsuite v0.20.0-beta
go: finding github.com v0.20.0-beta
runtime
'# runtime
/usr/local/go/src/runtime/stubs_x86.go:10:6: stackcheck redeclared in this block
	previous declaration at /usr/local/go/src/runtime/stubs_amd64x.go:10:6
/usr/local/go/src/runtime/unaligned1.go:11:6: readUnaligned32 redeclared in this block
	previous declaration at /usr/local/go/src/runtime/alg.go:321:40
/usr/local/go/src/runtime/unaligned1.go:15:6: readUnaligned64 redeclared in this block
	previous declaration at /usr/local/go/src/runtime/alg.go:329:40
Makefile:83: recipe for target 'btcd' failed
make: *** [btcd] Error 2

Try with at least Go 1.13 or beyond. It looks like something is up with your Go installation as you're unable to build any package at all.

Actually I have go 1.13 installed.
go version go1.13 linux/amd64

I could build LND v0.7.1 with go 1.11 time ago. But after updating to go 1.13 build fails

Did you remove go1.11 before installing go1.13?

Thanks. No I didn't. I think this may be the issue. After reading around I found this.
$ sudo rm -rf /usr/local/go

Then, download the new version
$ sudo tar -C /usr/local -xzf /path/to/downloads/go1.x.x.linux-amd64.tar.gz

This should work right?

Yes, removing the old version should help.
Also make sure your GOROOT environment variable isn't pointing to any old installation.

After reproducing this issue, the problem seems to be wth the 1.13.4 amd64 version of Go. There are indeed two symbols that are defined multiple times confusing the compiler.
Please try removing 1.13.4 and install 1.13.3 amd64. That should build successfully.

Problem was my go installation.
Once I removed my former version  $ sudo rm -rf /usr/local/go and reinstalled the new one, it all worked perfectly.
Thanks to everyone


[doc] Include drop counters in HA API.

Packet drops is one of the major common problem in network that needs to be monitored. This change adds the drop counters that we need to monitor in DASH pipeline.
Since the drop counters are not too complicated and also could be counted as part of the HA design, hence we are adding them as part of the HA API doc.

thanks Marian for the review!


Enhancing getting started doc

The getting started document: https://github.com/zulip/zulip-mobile/blob/master/docs/getting-started.md does not have react-native run-ios command. I would like to edit it and add more information about.

@zulipbot claim


Add support for BotAppId via proactive endpoint

Fixes issues related to the proactive endpoint that the ASP.NET
integration libraries where it was calling the base
BotAdapter::ContinueConversation vs the BotFrameworkAdapter
specific overload of ContinueConversation which takes the botAppId.
This adds the ability to specify the botAppId as either an HTTP
header named "MS-BotFramework-BotAppId" or a querystring parameter
named just "BotAppId".

@JonathanFingold , please note the changes here, as it may mean a (minor) docs update for you.

@cleemullins , thanks for the heads up. There are scheduled for a doc review this week, so perfect timing.


[v2] Integrated Feedback Widget

🚀 Feature: Integrated Feedback Widget

This is an adaptation of https://docusaurus.io/feedback/p/feedback-widget.

Finding out whether users actually deem the content on your site useful can be very helpful to gain insights into the quality and clarity of the actual content. Most documentation sites have integrated feedback widgets, and I (and according to the feedback page many others) think that this could be a valuable addition.
Have you read the Contributing Guidelines on issues?
Yes!
Motivation
I have been browsing around various documentation pages, trying to find out which features are currently lacking in Docusaurus, that could be deemed useful to developers. When I found the post on the feedback page (from 2 years ago!) I wanted to bring the idea back up. I apologize in advance if this is already implemented and was simply overlooked by me.
Pitch
I believe this can be seamlessly integrated into a new package, which could potentially even ship with the default theme. Users would simply have to decide between a layout (with a default given) and a reporting method (more later) to activate the widget.
Reporting
I will describe two possible methods that came to my mind. Since the site is completely static, there's no way for us to store data on the site. Using a tool like staticman could work, but is too tedious to use in this case (in my opinion), since it forces you to continuously merge the reported data into your actual repository.
Google Sheets
Simple; use a public Google Sheet where the data is stored. Data can be queried to display the overall feedback on a single page and can be posted to update the data.
The huge disadvantage is that the sheet is public, no one prevents users from just opening the sheet themselves and mess around with it.
Google Analytics
Slightly more setup, but could be well worth it.
I found that the feedback widget on the React-Native Docusaurus page uses Google Analytics to report the feedback. Using the Analytics Reporting API v4 from Google, we could send and query data directly from Google Analytics. This could potentially even synergise together with the existing Google Analytics plugin.
Layouts
Various layouts could be supported, since they all cover the same values (negative/(neutral)/positive). Examples:

GitBook
React-Native
Unknown (taken from the feedback page)

I'd be happy to give developing this a try, even if it will not be officially integrated. I would love some feedback on the idea overall and the pitched implementation concepts!

Hi,
I have some opinions on how to provide such a feature.
I don't want it to be tightly coupled to a specific provider, and give maximum flexibility to the end-user.
So my idea is more to create some kind of component placeholders in the theme page layouts so that users can fill those placeholders with the content of their choice, including feedback widgets, a comment system or whatever.
For example, the ReactNative site could add this widget by providing an "AfterrDocContent" component.
Somehow, this is a bit similar to swizzling components, except those placeholders components are made for this on purpose, and would permit to reduce the amount of code the user has to maintain (ie copied from the theme) to add such feature

BTW, this feature request is part of what I'd like to work on for the beta phase, as explained here: https://docusaurus.io/blog/2021/05/12/announcing-docusaurus-two-beta#what-are-the-goals-of-the-beta
I think this belongs to "extending an existing theme"

Thanks for your input!

I don't want it to be tightly coupled to a specific provider, and give maximum flexibility to the end-user.

This is always the ideal case. With provider in this case you mean using Sheets vs Analytics vs Custom Provider?

So my idea is more to create some kind of component placeholders in the theme page layouts so that users can fill those placeholders with the content of their choice, including feedback widgets, a comment system or whatever.

That sounds great! So you can sort of "hook" into the layout of the theme, and place components wherever you like? I'm all for it!

Closing in favor of #5380. We won't provide any OOTB feedback widget, but we would make it very easy to implement in userland.


Add configuration to serve aspx files from a specific folder like Pages

Is it possible to serve the aspx files out of the Pages or another configurable folder?
Is this doable? if you point me in the direction can create a PR.

The compilation currently grabs the content directory from IHostEnvironment. For example see:
https://github.com/CoreWebForms/CoreWebForms/blob/69d9da0e56b495607190023a3de18506c0b2837c/src/Compiler.Dynamic/SystemWebCompilation.cs#L82
Feel free to move it to PageCompilationOptions and have it default to being set by IHostEnvironment. Then you could replace it, create a composite file provider, etc

I assigned you if that's ok :)


[extractor/nubilesporn] Add NubilesPorn extractor

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

ADD DESCRIPTION HERE
Fixes #
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

@pukkandan In terms of approval and merging, is there some step that I need to take that isn't in the contribution guide? Or is the queue just long?

There is a indeed a lot for me to get to.
But if you were to look at some other recent extractors (E.g. https://github.com/yt-dlp/yt-dlp/pull/6309, ) and try to adjust your code style accordingly, it would reduce how much changed I'd need to make and would incentivize me to push it to the front of the queue.

Appreciate the reply and the comments, will action, thanks 👍🏻👍🏻


Decorator Divs don't appear when printed?

Great project btw! 👍

In Google Chrome this is fixed by selecting the "Background Graphics" option in the Print dialog


scapegoat failOnError := false

Hi,
Is there any way to do NOT fail if an error is found while scapegoat task is executed?
Since I have to upload the scapegoat-report to sonar, wouldn't be better to have this option?
Do you have some example in order to go ahead even if errors are found?
Thanks in advance.

Seems like there is an option to allow some warnings/errors before failing the build, but I could not make it work with 1.0.5. See issue #60

Same here, couldn't make it work.
Is making the build fail on the report intended?
I would expect it to go through so you can send report to sonar as well.

I think this is related to #72 .

It would be great to have this in place. Any news regarding this? Any workaround?

If you want to upload the report to Sonar you can change the level of Error inspections to Warning. Doing this the run don't fail (even with warnings) and given that what you really want is to see the quality profile of Sonar not the real scapegoat report it "solves the problem".
You can add to you project settings
scalacOptions in Scapegoat ++= Seq("-P:scapegoat:overrideLevels:ArraysInFormat=Warning:CatchNpe=Warning:ComparingFloatingPointTypes=Warning:ComparingUnrelatedTypes=Warning:EitherGet=Warning:EmptyInterpolatedString=Warning:IllegalFormatString=Warning:ImpossibleOptionSizeCondition=Warning:IncorrectNumberOfArgsToFormat=Warning:IncorrectlyNamedExceptions=Warning:LonelySealedTrait=Warning:MapGetAndGetOrElse=Warning:NanComparison=Warning:OptionGet=Warning:OptionSize=Warning:StripMarginOnRegex=Warning:TraversableHead=Warning:TraversableLast=Warning:TryGet=Warning:UnsafeContains=Warning")
Is not the best option but it works at least with Sonar. Anyway as you say, it would be great to have this failOnError := false option instead of doing this hack.

Another workaround is to do sbt scapegoat || true. This will ignore any errors and with the next command you can upload the report to SonarQube.

I can see the situation haven't changed anything.
It's sad, that we have to do those workarounds. I would like to help in order to inject this failOnError := false, but im only a grey-user, who doesn't really know how to Scala :D


Not able to import module nexmo

When we try to import the module using require("nexmo"), it throws the below error.
"Cannot find module 'verror'"

What version of Node.js are you running? And which version of the nexmo library are you trying to import?

Closing due to inactivity, but please do re-open if you have any more information that would allow us to help more with this issue!


[Event Dashboard] Alert window about confirmation or not confirmation of the past event's deleting  does not match to the Mockup

Environment: Windows 10x64, Google Chrome 116.0.5845.189
Reproducible: always
Build found: 04.10.2023
Preconditions

https://www.greencity.social/#/profile is opened.
The admin is logged in.
The Event page is opened.
There is at least one past event.

Steps to reproduce

Click the 'Delete' button for the past event on the Event card (see preconditions).
Compare the alert window to the mockup.

Actual result

Expected result

User story and test case links
E.g.: "User story #3196
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), Type ("UI").

Can not reproduce


Add how does it work section on readme

Codecov Report

Merging #46 (28161cf) into main (cbf9a86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   82.36%   82.36%
=======================================
  Files          13       13
  Lines         635      635
=======================================
  Hits          523      523
  Misses         66       66
  Partials       46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf9a86...28161cf. Read the comment docs.


👩💻📞 WinUI Community Call (March 18, 2020)

Hi all -
The next WinUI Community Call will be on Wednesday March 18.
We'll be broadcasting live on Microsoft Teams:
https://aka.ms/winuimarchcall
Details
Date: Wednesday March 18
Time: 17:00-18:00 UTC (9:00-10:00am Pacific)
Anyone and everyone is welcome - no pre-registration is required.
This will be an informal online call directly with members of our engineering team.
Please leave questions/topics/feedback!
We'll be dedicated a portion of the call to answering your questions, so please leave comments in this issue if there are any questions or topics you'd like us to cover next week!
If you've tried out the new WinUI 3 Alpha Feb 2020 update then we'd also love to talk about any feedback you might have so far on WebView2 or anything else.
Agenda

Quick intro/recap on WinUI
Community Spotlight: TabView updates & sample demo with Marcel (@chingucoding) and Steven (@stmoy )
Brief update on this month's progress
Deep-dive with @ryandemopoulos: Demystifying how WinUI 3 relates to Desktop Apps, Win32, UWP, WinUI 2, and other frameworks like Xamarin.Forms and React Native.
Q&A - we'll answer your questions from this issue (leave a comment!) and anything that comes up during the call!

We'll have a few dev team leads around this month to help answer questions on the call and in the live chat stream.

I'm looking forward to the call. Are the issues with ObservableCollection expected to be resolved when the preview ships? Could the team talk about progress with known issues? Thanks!

Grab the ICS for the community call from the new WinUI website:
https://microsoft.github.io/microsoft-ui-xaml/WinUICommunityCall.ics

It would be great to have more information on the recently published MUX.Window spec. The spec covers very basic things.

Will MUX.Window have a cool modern UWP look by default even on Win32? (ApplicationFrame-like, titlebar+window control buttons)
What about proper styling? Glow (like VS), shadow, theme (Force/Prefer Dark/Light), border width (possibly 0) and color?
Will it be possible (and simple) to specify custom draggable area and extend view into titlebar?
What about rendering? An option to create no redirection bitmap (enabling bug-free acrylic on Win32) would be great to have.
Will it be implemented for Win32 as an ordinary window with a single XAML Island? Or in a proper way (full-XAML window without an Island), without unnecessary layer of complexity and potential issues related to window event handling?
Digging a bit deeper, will the window be in ZBID_UIACCESS band when the user has UIAccess token? Will topmost be supported, at least on Win32?

Looking forward to hearing more information on the matter.
P.S. I also hope we will see CsWinRT and .NET 5.0 for UWP Preview SDK soon, but I suppose that's not WinUI team responsibility.

By the way, #2007 is closed by recent TabView PR, but it would be nice to have it confirmed WinUI TabView has feature-parity with WCT version and the ability to make it look exactly like in Microsoft Edge (UWP, not the Chromium one).

By the way, #2007 is closed by recent TabView PR, but it would be nice to have it confirmed WinUI TabView has feature-parity with WCT version and the ability to make it look exactly like in Microsoft Edge (UWP, not the Chromium one).

TabView customizability (and the customizability of all controls) is an important part of the feature set. This has been an area of active investigation lately (#2100). Philosophically, we want to support reasonable control styling and customization across our controls; however, enabling TabView look exactly like ye olde UWP Edge isn't a high priority for the team. We'll continue to invest in ensuring that our controls are aligned with the latest Fluent patterns (including rounded corners, shadows), while supporting appropriate customization options.

Is there a timeframe for when missing features like the XAML Ribbon are due to be implemented?

@stmoy it's great to hear WinUI team doesn't forget about customization options.
I really like Fluent design system, and I welcomed all incremental changes introduced over the last 5 years (well, Fluent was only formulated like 2-3 years ago, but the general idea was right there from the start of Windows 10). All but rounded corners. I accept them now, in all controls, except for top-level ones: window (ContentDialogs, context menus and Flyouts look fine rounded), TabView, Ribbon (if only we had one), NavigationView. I hope, that a way to preserve the rectangular shape in aforementioned controls will still be there in WinUI 3 and later versions. Acrylic appearance should just be the ability to customize the background of the whole TabView, I think this should work even now. Full-height items (without that padding) — not so sure.
I really want WinUI to be a good (better) alternative to WPF. It is somewhat disappointing now and again: old .NET runtime (UWP fault, but still), excessively locked down API surface (again UWP), lack of customization options and 3rd party controls. Official Ribbon implementation is still missing too, despite clearly existing and being used in Office UWP apps. I just hope WinUI will remain solid, but make progress with more thoughts on customizability and presenting the developers with a choice, especially when something changes in the design spec.

Please shade more light on the UWP, WinUI and .NET 5 story

The disparity in functionality of Window in UWP and Win32 feels like WinUI desktop is just WPF reskinned.  I was personally hoping that functionality would work the same except where sandbox restrictions apply, meaning that targeting Win32 should match UWP 100% plus things UWP cannot do.

Will WinUI 3 be backward compatible down to Windows 10 build 15063 like WinUI 2? Or it'll keep the current (3 alpha) compatibility down to build 17134?

It would be great to have more information on the recently published MUX.Window spec. The spec covers very basic things.

Will MUX.Window have a cool modern UWP look by default even on Win32? (ApplicationFrame-like, titlebar+window control buttons)
What about proper styling? Glow (like VS), shadow, theme (Force/Prefer Dark/Light), border width (possibly 0) and color?
Will it be possible (and simple) to specify custom draggable area and extend view into titlebar?
[...]

Good points! I would add:

Will it be possible to make the window frameless (no border)?
Will it be possible to make the window transparent (with mouse events over transparent areas falling through to whatever is below the window)?

Those are both features from WPF that are not possible with current UWP, and would be great to have in WinUI. They're critical for apps like launchers, e.g. building something like Alfred on Windows.

Can you talk about titlebar cutomisation consistency between UWP and Desktop app model
#2124

How difficult is it to / what is the process for extending native controls in C#. What level of control do you have - are there things that are really only exposed on the native side?

For enterprise desktop development where performance matters, what - if any - is the pressure to write your own controls natively to continue to get high performance out of the framework. Is the expectation that all performance critical user controls be written that way in the future?

Modern UI has a much bigger focus on supporting clean icons. Will there be better support for things like font glyphs or SVGs to make them less painful to use? Are there any plans to have a Microsoft made, community driven, library of icons to help reduce the dependencies on 3rd party icon sites for core/common icons and help provide continuity between different desktop applications?

Will it be possible to just use AppWindows in the win32 app model? My use case is to use (non-UI) libraries that do not work in the UWP context. All UI-related parts can be completely UWP/WinUI.

WinUI Proposal: Allow the App to Print without showing the Confirmation Dialog to user https://github.com/microsoft/microsoft-ui-xaml/issues/2126

Join us on teams for this call due to technical issues:
https://aka.ms/winuimarchcall

Will Preview 1 support visual basic project types ?

@andrew-boyarshin and @sharpninja The MUX-Window work is split into several phases. We just make public the P0 APIs, that fundamental ones. Once this phase is done, we will prioritize the second round of APIs. Win32 window APIs are very powerful, and let you know to do a lot of things. To unblock your scenarios we will expose the underneath HWnd in Win32 so you can manipulate the window using Win32 APIs meanwhile MUX-Window doesn't have a convenient API.
Q: Will MUX.Window have a cool modern UWP look by default even on Win32?
It's on the backlog. The first Preview will have the Win32 window style.
Q: What about proper styling? Glow (like VS), shadow, theme (Force/Prefer Dark/Light), border width (possibly 0) and color?
Given there won't be proper WInUI3 APIs for doing this in the first phase, the Window class will expose the underneath HWnd so you can manipulate the window using Win32 APIs.
Q: Will it be possible (and simple) to specify custom draggable area and extend view into titlebar?
No in the first phase. It's on the backlog.
Q: What about rendering? An option to create no redirection bitmap (enabling bug-free acrylic on Win32) would be great to have.
Please, open a feature request describing the scenario. This is not being tracked at the moment.
Q: Will it be implemented for Win32 as an ordinary window with a single XAML Island? Or in a proper way (full-XAML window without an Island), without unnecessary layer of complexity and potential issues related to window event handling?
It's being implemented properly, for sure :) I trust in our developer team. If you are curious about, we are using DesktopWindowXamlSource and other APIs to expose the XAML framework in Hwnds.
Q: Will the window be in ZBID_UIACCESS band when the user has UIAccess token?
This is out of our radar. Can you create a feature request, please?
Q: Will topmost be supported, at least on Win32?
I think you can set the topmost flag if you get the Hwnd of the Window. But having an API in MUX.Window will help, for sure.

@lhak,
Q: Will it be possible to just use AppWindows in the win32 app model?
Unfortunately, the current plan is that AppWindow won't work in WinUI 3.0 neither UWP nor Win32. In the backlog for future releases.

@JosephusPaye
Q: Will it be possible to make the window frameless (no border or title bar)?
This is in the backlog, but it's no part of the phase 1.
Q: Will it be possible to make the window transparent (with mouse events over transparent areas falling through to whatever is behind the window)?
Same answer as above. However, making the Window transparent is a little more challenging, given we need to make transparent the XAML framework and this no part of phase 1.

@marb2000 thank you for your answer. I didn't quite catch the very important detail about phases. Which will make into WinUI 3 RTW?
It's great to have Hwnds, and it does solve a lot of problems. Still, WS_EX_NOREDIRECTIONBITMAP can only (to the best of my knowledge) be applied during window creation. It would be great if window creation flags API makes it into WinUI 3.
There is one more point. I trust the WinUI developer team too. But it's much easier to reuse XAML Islands code (like DesktopWindowXamlSource), than go one level deeper. The problem with this approach is that there is HWND-UWP-HWND-UWP sandwich in the resulting visual tree. A lot can go wrong, not to mention the amount of overhead it implies. Just look at this: hit test first received by Win32 window, then passed to DesktopWindowXamlSource, hit test again, then internal Hwnd hit test again, finally we are in the target UWP land, do the hit test again. Don't forget to marshal data every step of the way, we are passing COM boundaries after all. I read right now the early XAML Islands design doc (pity such informative docs are so rare) and see the list of issues (scrolling, UI synchronization issues, etc) with Hwnd-based interop, and the simpler way uses 2 Hwnds! It is obvious this can be greatly simplified to match what CoreWindow appframe does under covers, but it takes a little more effort. I hope WinUI will take the better option, not the simpler one.

Hey @alvinashcraft - sorry for the ping, I was just curious to what "issues with ObservableCollection<T>" were you referring to in your question 🤔
Were you referring to the missing APIs that are being worked on in https://github.com/dotnet/runtime/issues/18087?
Or is there some other issue with that specific type I'm missing?
Thanks! 😄

Hey, @Sergio0694. No problem. I was talking about the INotifiyPropertyChange issue with ObservableCollection that is referenced on the MS Docs page for the Alpha release:

The .NET interfaces System.ComponentModel.INotifyPropertyChanged and System.Collections.Specialized.INotifyCollectionChanged are projected into the WinRT Windows.UI.Xaml namespace as Windows.UI.Xaml.Data.INotifyPropertyChanged and Windows.UI.Xaml.Interop.INotifyCollectionChanged, respectively. However, WinUI 3.0 depends on interfaces in the Microsoft.UI.Xaml namespace, so types that implement these .NET interfaces do not function well with WinUI 3.0. To work around this issue, your type should implement the corresponding Microsoft.UI.Xaml interfaces.
As a result of this issue, ObservableCollection does not work well in conjunction with WinUI 3.0.

I've seen this issue when using ObservableCollection as an ItemsSource on a ListView in the Alpha.

Why can't the less common one inherit the more common?  The ObservableCollection works everywhere.

From: Alvin Ashcraft<EMAIL_ADDRESS>Sent: Wednesday, March 18, 2020 6:08:25 PM
To: microsoft/microsoft-ui-xaml<EMAIL_ADDRESS>Cc: The Sharp Ninja<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/microsoft-ui-xaml] 👩💻📞 WinUI Community Call (March 18, 2020) (#2104)
Hey, @Sergio0694https://github.com/Sergio0694. No problem. I was talking about the INotifiyPropertyChange issue with ObservableCollection that is referenced on the MS Docs pagehttps://docs.microsoft.com/en-us/uwp/toolkits/winui3/ for the Alpha release:
The .NET interfaces System.ComponentModel.INotifyPropertyChanged and System.Collections.Specialized.INotifyCollectionChanged are projected into the WinRT Windows.UI.Xaml namespace as Windows.UI.Xaml.Data.INotifyPropertyChanged and Windows.UI.Xaml.Interop.INotifyCollectionChanged, respectively. However, WinUI 3.0 depends on interfaces in the Microsoft.UI.Xaml namespace, so types that implement these .NET interfaces do not function well with WinUI 3.0. To work around this issue, your type should implement the corresponding Microsoft.UI.Xaml interfaces.
As a result of this issue, ObservableCollection does not work well in conjunction with WinUI 3.0.
I've seen this issue when using ObservableCollection as an ItemsSource on a ListView in the Alpha.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/microsoft-ui-xaml/issues/2104#issuecomment-600902610, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD3GCLCOPVTZOVYPMI6SIBTRIFH6TANCNFSM4LGVVDEA.

@anawishnoff Do we have the recording please?

@sharpninja
ObservableCollection works only on .Net, when WinUI supports more platforms.

@alvinashcraft  Thanks for providing the details. The problem with ObservableCollection that you see in the Alpha bits is tracked by #1557.

Id really like to watch a recording, unfortunately I was unable to make the call

@harvinders @deanchalk Recording will be uploaded shortly. :)

Recording has been uploaded! Check it out here:
https://youtu.be/kVbu2ZWCMhU

Ryan asked what "cross platform means to you".  From an enterprise desktop app perspective, I want WinUI apps to be an alternative to developing web apps.  Since web apps are by nature "cross-platform" (depends on your def of platform), we need something that will run on the prevalent desktop OS's in business.  Windows, Mac OS, iOS and Linux Desktop.  I'm on the fence about iOS because, I particularly care about workstations with keyboard and mouse.
Do I care if a Fluent-looking app is running on OS X or Ubuntu?  I will take consistent UI functionality over some religious argument that its not being true to the native OS.  Do businesses care?  I don't know, I think they care more about spending less time developing/tweaking per platform/OS.
WinUI 3 targeting desktop OS's other than Windows is going to be a game changer.  I would hope that leadership would see its importance and rank it high on the to-do list after 3.0 ships.
One other thought, why (as an industry) are we spending so much time on PWAs, Electron, Blazor/WASM to get around the performance of browser-based apps?  Simple. Because there is no (free) alternative to build and deploy desktop apps.  MS is the one company that can challenge the status quo and give developers and alternative to the browser (the establishment).  If you're picturing someone throwing a large hammer at a television, sit and ponder that irony.


[FLOC-1542] Split container discovery

Will be more readable once #1233 is merged (which can be done as soon as buildbot is green).

Thanks.  Seems sensible.  Some inconsistencies, probably fine, but please address those and submit for one more quick look.

Great, thanks.  Left one more question inline but I'm pretty sure I know the answer.  Please proceed.

Thanks.  Please address inline comments and then merge.

(Also green buildbot etc)


Added CIOU loss function

#2980
Reference
cc: @oke-aditya  @datumbox
Yet to add Tests hence converting pr to draft.

Hi. It's late in India rn. Will review it in daytime.

Working on dIoU, I have noticed that many things can be refactored between gIoU, cIoU, and dIoU.
I will push my contribution anyway but we can discuss what can be done next to improve things. :ok_hand:

yeah :) There is a neat relation between these 3 and code can be re-used. :smile:

yeah :) There is a neat relation between these 3 and code can be re-used. smile

Yes, I guess we can repeat some of the code for now since we have two branches at the same time + the existing gIoU. Next, we can start a new PR to refactor things a bit.

Please add docs in docs/ops.rst

Once CI goes green (which probably should) please UNmark this as draft. @abhi-glitchhg

@abhi-glitchhg @oke-aditya Thank you very much for your contributions and reviews so far.
Apologies for the delayed response, but I was OOO. I might be missing something but what is the reason we have duplicate implementations for cIoU in the loss and the box version? Is there a reason we don't share some of the code?

@abhi-glitchhg @oke-aditya Thank you very much for your contributions and reviews so far.
Apologies for the delayed response, but I was OOO. I might be missing something but what is the reason we have duplicate implementations for cIoU in the loss and the box version? Is there a reason we don't share some of the code?

As far as my exploration goes, it seems it is the case for gIoU as well and I haven't found any reason why this should be the case but maybe I am missing something. I have also duplicated some code in dIoU. Perhaps it is best to have a PR to refactor some of the shared code between gIoU, cIoU, and dIoU?

@yassineAlouini I think sending a separate PR to refactor gIoU makes a lot of sense. For new code (cIoU and dIoU) I would fix in the current open PRs.

@datumbox Noted, I will work on this (when I have allocated time) and update the code. :ok_hand:

Kindly let me know what direction you would like us to take now. We could bring both PRs on a similar state as this one and merge and then 1 of you can pick up the cleaning bit. Alternatively we can keep iterating on the current PRs until the nits are taken care of. It's up to you and I'm happy to take your preferred approach, I just want to make sure the implementations will be cleaned up prior the next release.

I would prefer the first approach(bring both PRs to similar state, merge, and then do refactor) but I'm also open to the second approach.

Hey, @datumbox , what's the expected date for next release?

Tentative date for branch cut, i.e. "feature freeze", is on 19th of May. After that it will be roughly one month until release, but no official date is set yet.


Updates real world links

These pinned commits have changed a lot in the default branches

Thanks @austinpray-mixpanel. I was inactive on the project for a longer time. I'm glad to see they are still using it :)


Replace Eschbach2019 doi with FBrf when available

doi:10.1101/649731
Also update date in definition text

looks like this is the same paper as https://www.nature.com/articles/s41593-020-0607-9 = FBrf0245294
check that nothing obviously changed and replace reference


android_plugin always null

First of all, Kudos on all the effort and knowledge you share!
I'm having trouble integrating the plugin in an existing game.
What has been done so far...:

Extracted addons in root folder
Enabled plugin under Project Settings
All autoload files got auto loaded automatically
Adjusted manifest as guided in the Youtube video

GodotPlayGameServices.android_plugin remain null even though attempts providing the plugin.
I've attempted copying GodotPlayGameServices/bin/release/GodotPlayGameServices-release.aar to project_root/android/plugins and still no go, the android_plugin remain null.
The call to signin is made via a different autoload script which is located last in the order (I'm unsure if autoload order matter, but if it is I'd assume having my using script last should be good enough)
I'm using Mac OS m1 if it might be related (not too sure it is).
Would appreciate your aid

Hi @Shahar-Galukman thanks a lot for your kind words!
I'm a bit confused with your problem, though. What youtube video do you refer to? This plugin has an in-editor screen to put your game id from Google so you don't have to mess with the manifest at all. Can you check that again, just to be sure that you refer to the proper plugin? The version of the plugin for Godot 3.x needs messing with manifest, but not this one.
I also don't know if working on a Mac is problematic. I haven't tested there, but I don't think this should be an issue.
Please let me know if you can follow all the steps in the readme and your problem persists. Also, there's a second readme in the demo folder, with common troubleshooting and small examples on how the demo project is using the plugin.
Thanks again for your interest in the plugin!

Thank you kindly for the quick response, indeed my initial post was bit messy so I took your suggestion and had another attempt.
Sadly yet managed to succeed.
Before my attempt I removed android and addons folder and started all over (as well ensured to remove autoloaded plugin files in Godot's autoload tab)
I'm using this plugin, for Godot 4.2.
Here are now the steps I took;

Downloaded https://github.com/Iakobs/godot-play-game-services/releases/tag/v1.7.0 addons.zip
Extracted the zip to Godot project's root (res://addons)

I've then enabled the plugin as expected

All the plugin autoload files got added to Autoload successfully.
I've submitted my game id as mentioned

I've installed the andoird template and turned on "Use Gradle Build"
When I try to run the SignInClient.sign_in() method in the _ready of my game's main scene I get to no plugin found err:

I hope this makes my usage more clear and perhaps aid in better understand the issue I tackle.
I do feel like I miss something plain though significant (isn't it always the case ;))
I tried backward engineer the source of android_plugin variable definition though coulnd't easily from Godot, therefore I assume it gets loaded somehow from the Kotlin projects build. (less familiar yet with that area in the code).

"If the project is not run in an android device (let it be real or emulated), the plugin doesn't load at all."
Ohh my, was not aware of it, indeed was not running via an android device nor emulator.
A rookie mistake it is then, pardon the trouble.
Keep being awesome, I really do learn a lot from you and appreciate all of your contribution to this amazing community.
I'll now close the ticket, blushing on the corner.

No worries at all, @Shahar-Galukman !! I'm actually realising that I never stated that in the docs like in any obvious place, it's just mentioned briefly in a line, so I will add a warning somewhere to make it more evident.
Thanks for pointing out this issue!

Rejoice :)

yay! so glad it works now!


feat: zoom in out

Description
Done

Use Ctrl + Mouse wheel to zoom in / zoom out

TODO

Create a miniMap for Editor.

Task Item
ref #3449
Screenshots

Coverage decreased (-0.05%) to 55.263% when pulling e25331734477af9aea393244a18929ddf196bbf0 on alanlong9278:julong/zoom-in-out into 9ba5e8412eb81852fdd140b692ad46528f9c7b1b on microsoft:main.

@alanlong9278 is this feature going to be paired with panning?

@alanlong9278 is this feature going to be paired with panning?

This feature only includes zoom in/out and focus, not pair with panning


Proposal: Support peering links between core and non-core ASes

Many existing ASes that would become SCION core ASes presumably have a lot of existing peering connections. Any of those peers that become SCION core ASes would have their peering upgraded to a core link. So far so good. But it's likely that many of those peers would not be SCION core ASes, and may in fact be in separate ISDs. In order to support this, the proposal is to allow peering links between core and non-core ASes. This would work in the following way:
When a core AS registers a core segment to its local PS, it would add peering HopEntries to the path segment. (Note: it would not propagate a beacon containing peering HopEntries). During path combination, as well as checking for peering links between non-core ASes, the path combinator would also check for peering interfaces between the up-segment and the start of the core segment, and the down-segment and the end of the core segment.

We'll probably revisit this in the future because it's something we're keeping an eye on. However, I'm going to close this because the data-plane path format and control-plane service structure have changed recently, so this is no longer up to date.

We'll probably revisit this in the future because it's something we're keeping an eye on. However, I'm going to close this because the data-plane path format and control-plane service structure have changed recently, so this is no longer up to date.


breaking: bump<EMAIL_ADDRESS>

Motivation and Context

Bump cordova-common to latest

Testing

npm t

Checklist

[x] I've run the tests to see all new and existing tests pass

Guess this needs a rebase, fs-extra causes the failure.

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   39.34%   39.34%
=======================================
  Files           5        5
  Lines         427      427
=======================================
  Hits          168      168
  Misses        259      259

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfcb4bd...605bc97. Read the comment docs.


RoundMaster API

This is the first releasable version of RoundMaster, with full documentation, after over 1 year of testing and fixing with a group of 3 DMs and 9 players.  Its purpose is to extend the functionality of the Turn Tracker capability already built in to Roll20.  It is one of several other similar APIs available on the platform that support the Turn Tracker and manage token and character statuses related to the passing of time: the USP of this one is the full richness of its functionality and the degree of user testing that has occurred over a 12 month period.  RoundMaster is based on the much older TrackerJacker API, and many thanks to Ken L. for creating TrackerJacker.  However, roundMaster is a considerable fix and extension to TrackerJacker, suited to many different applications in many different RPG scenarios.  RoundMaster is also the first release as part of the wider RPGMaster series of APIs for Roll20, composed of RoundMaster, CommandMaster, InitiativeMaster, AttackMaster, MagicMaster and MoneyMaster - other than RoundMaster (which is generic) these initially support only the AD&D2e RPG.  On loading, RoundMaster will create handouts in the Campaign with help on all its commands and functions.  It will also create a Character Sheet database of Effect macros - see the documentation in the handouts for more information.

Have replaced MS file types with RTF and MHT (single file HTML).  I hope this solves the problem.

Is there a reason why you submitted versions v3.004 through v3.019? Seems a bit redundant to do with the initial commit of the API, especially when you have only made v3.020 selectable in the "previous versions" section.

Have replaced MS file types with RTF and MHT (single file HTML). I hope this solves the problem.

You still have RoundMaster/v3.020/Effect Documentation.docx and RoundMaster/v3.020/RoundMaster Documentation.docx to change.

Anduh, sorry I've not done this before.  I had a look at other Roll20 API directories on GitHub and saw lots of older versions and I thought you might need to review the development cycle I'd gone through to get to this point.  As you can see from the version numbering and the change log I've not loaded anything before v3.001 (there are plenty before that!).  This also ensures I have yet another backup for my own purposes, but if you want me to remove them, I'll do so.
I have 4 other APIs nearly ready to post, so I'm using this one as a test to get to know the process.
Also, sorry I forgot I'd put the supporting documents in the v3.020 folder.  I'll just copy over them.

I've replaced all the MS files now - hope that's OK

Thanks for the detailed help - it will be much smoother with the next 4 APIs!  I've made the changes requested, and snuck in the very latest release (just handout avatar & version control changes - no real functionality change).  Happy to take any more comments and make changes as needed.

@DameryDad OK I did have to make a few minor changes that you might want to look at when you get a chance, but other than that, everything looks good to go now. Thanks for your patience here! Excited to see your script on the site.

Thanks.  I'll update the Wiki.  Is this going to be loadable by One-Click?