Mac OS X Application named "nwjs", no way to change to WaveDromEditor

This is a minor and cosmetic issue, but a bit odd.
The name of the WaveDromEditor application icon in Mac OS X always shows up as "nwjs" in Finder or Launchpad.
I tried to rename it to WaveDromEditor, but it still remains "nwjs".  In the Terminal, it shows up as WaveDromEditor.app. (!)
It must be something inside the .app bundle that makes any GUI interpret the name as something other than "WaveDromEditor" .

Figured out how to fix it.
In file:
WaveDromEditor.app/Contents/Resources/en.lproj/InfoPlist.strings
you just need to change the line from
CFBundleDisplayName = "nwjs";
to:
CFBundleDisplayName = "WaveDromEditor";

https://kb.applingua.com/2011/10/how-to-localize-app-names/

Thanks. I have no OSX to try, but I will try to incorporate this change into the next build.

@itsayellow could you try v1.3.1 ?

Looks great.  Installs as "WaveDrom" and shows up both in Finder and in Launchpad under that name.


Upgrade to TypeScript v5.1

As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.1, with the goal of eventually upgrading to the latest version.
Prior to starting the upgrade process, we should read through the v5.1 release announcements and make note of the following in this ticket:

New language features that we should apply in our code (e.g. satisfies operator in v4.9).
Breaking changes and possible regressions (e.g. change in type narrowing behavior in v5.0).

For breaking changes, look at the wiki.
For regressions, also look at google search results: e.g. site:github.com typescript 5.1 regression

Blockers for implementation (e.g. fixing type declarations in dependencies to be ESM-compatible was a prerequisite for the v5.0 upgrade).

We should also do a trial run of bumping TypeScript versions in core packages and seeing what  (if any) error messages we get when we run yarn build and yarn test. These errors should be recorded in this ticket.

For the trial run, branch from this PR where the v5.0 upgrade is in place: https://github.com/MetaMask/core/pull/3645. If the PR is merged, use the latest version of core.

@kanthesha should this be in "needs dev review"? Or "ready for dev"?

Should we move this to Blocked since it's dependent on first bumping to TypeScript 5.0?


Added changelog entry for #49.

Codecov Report

Merging #50 into release/2.0.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/2.0.0      #50   +/-   ##
==============================================
  Coverage          96.63%   96.63%
==============================================
  Files                 33       33
  Lines               1220     1220
==============================================
  Hits                1179     1179
  Misses                41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43f2ed...2650407. Read the comment docs.

This radical change looks good. Will merge as soon as the CI re-runs.


Specify project name does not work

Once i specify a project name, for example :
domain.com@@myproject
I got : The URL "is not whitelisted".
However if i just put :
domain.com
I correctly send heartbeat. I've verified it in the plugin console.

@jvelezpo this bug is from 2009, maybe it's fixed with the recent changes?
Instead of using @@ and parsing, I want to switch to a structured input in a future release.

When you say structure you mean something like a JSON structure?

It could be stored as JSON but the input should be html form elements so the UI allows entering the domain and corresponding project separately.


As expression in const Constructor initializer List.

Thank you for taking the time to file an issue!
This tracker is for issues related to:

Analyzer

If you aren't sure, file the issue here and we'll find the right home for it.
In your issue, please include:

Dart SDK Version (2.4.1)
MacOSX mojave

I have a situation where I am trying to figure out a way to pass a default argument to a const constructor, but the argument is a set that I cannot create because of the fact that the arguments to the set override the == operator.
One of the workarounds that I tried was to create a const List with the values and then in the initializer list I wrote,
: _daysOfWeek = daysOfWeek as SplayTreeSet<DayOfWeek> ?? everyDay as SplayTreeSet<DayOfWeek>;
This results in a compiler error when testing
**Error: As expression is not a constant expression.**
The analyzer did not report anything during the implementation of this code.
Not sure if this is by design, but it would probably be helpful to report this as an error before hand.

Sounds like a version issue. An as expression is constant (with suitable operands). Both the dartanalyzer and dart from commit 8a670d773bccdea29b8f76249317a6e054d7c50a are happy about the following program:
class A {
  final int x;
  const A(Object o) : x = o as int;
}

main() {
  const A(42);
}

It looks like there is no bug as reported in the current versions of our tools, so I'll close the issue. @G5Becks, please re-open and provide more information if you disagree!


Fixing branch name in contributore guide link - Update stale.yml

Docs Build status updates of commit f076af5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/workflows/stale.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Upgrade to jsonld-java version 0.12.0, which contains critical performance enhancements

Cf. https://github.com/jsonld-java/jsonld-java/pull/228 (critical) and https://github.com/jsonld-java/jsonld-java/pull/224 (non-critical, but nice to have)

This will require a new CQ.

CQ opened at https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16357

CQ approved, so if someone wants to put up a PR with this version bump, we can include it.

And probably two  additional PRs for rdf4j-storage and rdf4j-tools ?
Storage and tools are still using jsonld-java 0.8.3...

https://github.com/eclipse/rdf4j-storage/blob/develop/pom.xml
https://github.com/eclipse/rdf4j-tools/blob/develop/pom.xml

@barthanssens I wonder if those deps in storage and tools are just leftovers. Can they be removed instead of bumped? I would expect them to just use the version that rdf4j-client provides...

Could very well be... I'll guess the same goes voor the spring dependency (and maybe some others)

All done :+1:


Fix hold msg for jobs not picked up by the JR (SOFTWARE-2539)

https://jira.opensciencegrid.org/browse/SOFTWARE-2539
There are at least 3 reasons that the Job Router will ignore idle jobs
in the Schedd for 30 min+:

Job did not match any available job routes
All potential job routes are full (i.e. reached MaxJobs)
Routed jobs are failing and throttling occurs; job submission rates
drop and the job router does not pick up new jobs until the failure
rate drops below the configured threshold

Rather than including them in a very long hold message, it makes more
sense to elaborate the reasons in our documentation.

Just to elaborate, so the hold message "knows" why the job was put on hold.  But we have chosen to not list it?

Well, we know why the job was held, it wasn't picked up by the job router for 30+ min. The reasons why the JR may have done that are varied and if we listed them all would result in a very long hold message. Plus, if we find another reason that the JR didn't pick up the job in time, we can just update the documentation instead of having to cut a new version of HTCondor-CE.

So our choices where:

Give detailed error message, that lists the known possible issues, but may not list all the possible problems.
Give an error message that lists none of the problems, and instead says "see troubleshooting docs", and not even a link?

Results in an obscenely long hold message
We can add a link but I think it's unnecessary with the correct document being the top link for the 'troubleshooting htcondor-ce' google search

I like error messages that are descriptive.  A long hold (or error) message does not bother me at all, if it describes the problem.  You could even include the text "see troubleshooting docs" in the hold message if necessary.

@djw8605: I've updated the commit, how's it look now?


[material-ui/system] Create separate margin and padding functions

[X] This is not a v0.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Keep spacing for instances where you would want to allow both margin and padding:
import { spacing } from '@material-ui/system';

const Thing = styled.div`
  ${spacing}
`

but also provide functions for margin and padding specifically for cases where you would want to use one but not the other:
import { margin } from '@material-ui/system';

const Thing = styled.div`
  ${margin}
`

import { padding } from '@material-ui/system';

const Thing = styled.div`
  ${padding}
`

Context 🔦
We have had situations where we want to allow applying margins via props but not padding and have had to work around this.

@Steveeeie I agree, this sounds like a legitimate use case.

Is this something your still keen to do, it's no much work to refactor.
I could push a PR ?


Schema Creator updated

Now we can use many commands:
E.g.
name:string,255:nullable
amount:decimal,5,2
role:string:default,invited

Hi man, i like your code.
What do you think about this?

Thanks @Reta110,
I will look into it and will merge it soon.


SUBMARINE-861. Trim the size of pysubmarine

What is this PR for?

Trim the size of pysubmarine, in other words,we let the user install the package such as pytorch and Tensorflow by themself instead of pre-installation from pysubmarine
What type of PR is it?
Improvement
Todos
[ ] - Deal with Jupiter Lab
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-861
How should this be tested?

Screenshots (if appropriate)
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? No
Does this need new documentation? No

@ByronHsu
I'm not sure if I finished all the requirement, and  whether I should deal with the installation of package in Jupiter Lab or not.

Thanks for your contribution.
I thought that we can rely on extras_require to get rid of explicitly installing ML framework.
extras_require means the dependencies for additional features, pip will not install them by default.
Users can use something like pip install apache-submarine[feature1, feature2] to explicitly install the dependencies for features.

@featherchen Yes, you should modify the jupyter dockerfile too.

@ByronHsu

@ByronHsu  I failed on the Integration test,maybe it is the bug you mentioned earlier?

@ByronHsu  I wonder why in integration test it didn't pip install pytorch and Tensorflow,which are be wriiten in ./github/workflow/python.yaml.An alternative solution is that use pip install --no-cache-dir ./submarine-sdk/pysubmarine/.[tf.pytorch] , but it didn't really fix the problem though.

@featherchen There are two workflows in python.yml: unit test and integration test. Only unit test install pytorch and tf beforehand, but integration did not. You can check here: https://github.com/apache/submarine/blob/master/.github/workflows/python.yml#L133.
I wonder why pip install --no-cache-dir ./submarine-sdk/pysubmarine/.[tf.pytorch] cannot solve the problem?

@featherchen There are two workflows in python.yml: unit test and integration test. Only unit test install pytorch and tf beforehand, but integration did not. You can check here: https://github.com/apache/submarine/blob/master/.github/workflows/python.yml#L133.
I wonder why pip install --no-cache-dir ./submarine-sdk/pysubmarine/.[tf.pytorch] cannot solve the problem?

Thanks for your contribution! LGTM.
Can you open an issue to update the usage of submarine-sdk?


#including MddBootstrap.h produces 300 errors in a non-packaged CPPWinrt application.

Describe the bug
Looking through the myrad of WIndows App SDK docs, if I want to call MddBootstrapInitialize2  from a non-packaged cppwinrt app I need to

declare <WindowsAppSdkBootstrapInitialize>false</WindowsAppSdkBootstrapInitialize> from Opting out of automatic module initialization
#include "MddBootstrap/h" from MddBootstrapInitialize2 function
I do that.  Then I get, in this instance, 298 error.  Mostly it looks like somethig, somewhere, is redefining stuff in AppModel.h

Steps to reproduce the bug

Create a new project
Select Windows Console Application (C+/WinRT)
Name the project what you want

Target Version: 22621
Minimum Version 17763

Open up `Manage Nuget Packages for Solution"
Install Windows App SDK.  My example uses 1.1.4
Add #include "MddBootstrap.h" to main.cpp
Build, or wait for intellisense to catch up.
Get errors.

Expected behavior
No errors.
Screenshots

NuGet package version
1.1.4
Packaging type
Unpackaged
Windows version
Insider Build (xxxxx)
IDE
Visual Studio 2022
Additional context

If you include Windows.h before MddBootstrap.h, does this help?
I'm thinking that appmodel.h uses definitions from the core windows headers, but it doesn't include it itself. MddBootstrap.h only includes appmodel.h so it doesn't satisfy the requirements for including it.

@DarranRowe That was the fix.  Adding #include <windows.h> before `#include "MddBootstrap.h" fixed the issue.

Good bot.


Create a Github Page

References #183

[t:60]

Learning how to create GitHub page
Learning how to use Jekyll theme
Writing up page and capturing images


Drawsprite && new style && th locale

// add
-- new style
-- draw sprite on everything can target
-- thai locale
// fix
-- fix no close when selected

Nobody asked for these stupid style changes.

What's the point of drawing sprites (which you randomly again changed the style of) for entities that don't have options?

Do you really expect me to merge this?

Next time save us all time and ask if this is even desired.

I'm just trying to offer it. may not be very good But I didn't think you'd be so angry.


Refactoring Part 2

I believe there can be a class Called SoundOperations or something like that where all the methods that make sounds.
You can make the same noise to be as one method and give them names like _soundOperations.PlayGetReadyBeep()
@Dayset if you want you can give it a go?

Thanks for participation. This project is done.


can't create ipmi obm settings from rmm catalog

Background: We have EMC ECS hardware. The OBM that rackhd needs to control is in the rmm catalog (ipmi channel 3).  Discovery has no problem generating the bmc and rmm catalogs, but when we attempt to run a workflow that create obm ipmi settings, it fails. We end up with no obm settings available.
# curl -s http://localhost:8080/api/1.1/nodes/588914caf5fef0a55f1db847/obm |python -mjson.tool
[]

we created a workflow
{
    "friendlyName": "ECS Create IPMI",
    "injectableName": "Graph.Rubicon.ECS.IPMI",
    "options": {
        "create-ipmi-obm-settings": {
            "ipmichannel": 3,
            "password": "password",
            "user": "root"
        }
    },
    "tasks": [
        {
            "label": "bootstrap-ubuntu",
            "taskName": "Task.Linux.Bootstrap.Ubuntu"
        },
        {
            "label": "create-ipmi-obm-settings",
            "taskName": "Task.Obm.Ipmi.CreateSettings"
        }
    ]
}

We run the workflow, and when it gets to the "create-ipmi-obm-settings" task, it fails with this error:
    "77bd5269-b4a2-49a7-8c9d-bea22680f274": {
        "error": "TypeError: Cannot read property 'data' of undefined\n    at /var/renasar/on-taskgraph/node_modules/on-tasks/lib/jobs/create-ipmi-obm-settings.js:76:49\n    at tryCatcher (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/util.js:26:23)\n    at Promise._settlePromiseFromHandler (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:503:31)\n    at Promise._settlePromiseAt (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:577:18)\n    at Promise._settlePromises (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/promise.js:693:14)\n    at Async._drainQueue (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:123:16)\n    at Async._drainQueues (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:133:10)\n    at Immediate.Async.drainQueues [as _onImmediate] (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/waterline/node_modules/bluebird/js/main/async.js:15:14)\n    at processImmediate [as _immediateCallback] (timers.js:396:17)",
        "friendlyName": "Create IPMI OBM settings",
        "ignoreFailure": false,
        "implementsTask": "Task.Base.Obm.Ipmi.CreateSettings",
        "injectableName": "Task.Obm.Ipmi.CreateSettings",
        "instanceId": "77bd5269-b4a2-49a7-8c9d-bea22680f274",
        "label": "create-ipmi-obm-settings",
        "name": "Task.Obm.Ipmi.CreateSettings",
        "options": {
            "_taskTimeout": 86400000,
            "ipmichannel": 3,
            "password": "password",
            "user": "root"
        },

If we look at create-ipmi-obm-settings.js:76
    if (this.options.ipmichannel === '3') {
        catalogSource = 'rmm';
    } else if (this.options.ipmichannel) {
        catalogSource = 'bmc-%s'.format(this.options.ipmichannel);
    } else {
        catalogSource = 'bmc';
    }

    // TODO: Once a BMC can be referenced by mac address in order to get the IP
    // address dynamically via the lookup service, then we won't need to grab
    // the IP from the catalog anymore. Short term solution.
    return waterline.catalogs.findLatestCatalogOfSource(self.nodeId, catalogSource)
    .then(function(catalog) {
        self.obmConfig.config.host = catalog.data['MAC Address'];

Both my "rmm" and "bmc" catalog have a data block.
  root@rackhd01:# curl --silent http://localhost:8080/api/1.1/nodes/588914caf5fef0a55f1db847/catalogs/bmc |python -mjson.tool
  {
      "createdAt": "2017-01-25T21:13:24.319Z",
      "data": {
          ..snip..
          "MAC Address": "00:1e:67:bc:ed:74",

  root@rackhd01:# curl --silent http://localhost:8080/api/1.1/nodes/588914caf5fef0a55f1db847/catalogs/rmm |python -mjson.tool
  {
      "createdAt": "2017-01-25T21:13:24.347Z",
      "data": {
        ..snip..
        "MAC Address": "00:1e:67:bc:ed:76",

it looks like host should be defined after line 47
https://github.com/RackHD/on-tasks/blob/master/lib/jobs/create-ipmi-obm-settings.js#L47

After working with @manfrednde we believe that the else if is causing catalogSource = 'rmm'; to never occur. When I get rid of the else if block, it works for me.
        if (this.options.ipmichannel === '3') {
            catalogSource = 'rmm';
        } else if (this.options.ipmichannel) {
            catalogSource = 'bmc-%s'.format(this.options.ipmichannel);

After review, this block is expecting ipmichannel to be a string, not an integer. Once I updated my workflow to send a string "3", workflow started working for me.
For those less familiar with javascript comparators (like me), my recommendation is that we put a comment above this block drawing attention to the string requirement.

Opened https://rackhd.atlassian.net/browse/RAC-4123

Closing this github issue out to continue discussion in the RAC @johren opened.


CL APR: pools table

What is the purpose of the change

Adds APR to pools table. It is the APR for a full range position. Notice the APR for pools with stablecoins is low since so much liquidity is concentrated at $1.

ClickUp Task
ClickUp Task URL
Brief Changelog

Testing and Verifying

Documentation and Release Note

@jonator Do you think it would make sense that for stables we set the range closer to 1 so it's more accurate?

@jonator Do you think it would make sense that for stables we set the range closer to 1 so it's more accurate?

What range do you propose? IMO it's nice that it illustrates the potentially low APR even if you concentrate since there's no impermanent loss


Add a civic.json file to be featured on Code for DC's project list

To let others know more about this project, show off your progress, and get contributors (if you want them), you should add a civic.json file to the repository.
You can use the web form here to create and download one: http://open.dc.gov/civic.json/builder.html
Feel free to respond with any questions!

Emailed civic.json document to team leader. Should be in the repository shortly.


Connect the process_create_order in the PolkaDexGatewayCallback

The PolkaDexGatewayCallback needs to connect its interface function of process_create_order with the real implementation.
https://github.com/Polkadex-Substrate/polkadexTEE-worker/blob/13ad6ce39b76b8fe2caef09a11896256105e5c39/enclave/src/polkadex_gateway.rs#L112-L114
It is possible that the process_create_order needs to be updated as well to work with the latest version of the cache.
See: https://github.com/Polkadex-Substrate/polkadexTEE-worker/blob/13ad6ce39b76b8fe2caef09a11896256105e5c39/enclave/src/polkadex_gateway.rs#L392-L410

Starting work on this


Made the Find A Doctor/Doctor Experience page responsive .

Description
Made the Find A Doctor/Doctor Experience page responsive . Made changes in navbar , main content , footer.
Related Issues
#894
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Also added icons on the navbar similar to home Page

@varshith257 please review and merge this .

@varshith257 please have a look .

@varshith257 please review and merge.

Will merge all the linked issues of mobile responsive together.

@Anjaliavv51 PTAL
/approve or request changes

@meetarora10 reduce the gap after in the below ss

and also in footer y the below content is moved to left side at the bottom?

Ok @Anjaliavv51

@Anjaliavv51 @varshith257 done changes .

@meetarora10 missing of nav bar and in footer sentence is overflowed

@meetarora10 Do  above changes as requested and looks good to mege

@Anjaliavv51 @varshith257 done .

@Anjaliavv51 @varshith257 please have a look .


QoL on removal perks

I think it would help with knowing whats getting decreased if the perks or the text of the perks that are 'to be removed' are highlighted in a red colour.

https://github.com/Grimy/Grimy.github.io/commit/87f32b137a74c4f7704866155d3f8bdfddf89c97

Thanks for the suggestion!


Fix theming of native select elements (currently used in SessionDetail

Looks good. Nice find. Thank you for your contribution! To be eligible for swag, please sign-up for Yahoo! Hack Together, if you have not done so, yet.


A good way to embed the chart into a dashboard?

Hi, We'd love to use your burndown chart in our internal dashboard. Is there a recommended way to iframe or embed just the chart ? Thanks for the hosted service!

hey @sethladd, thanks for filing this! this would be a nice new feature to support, but would be a considerable amount of effort based on the current way this is implemented.
so i'm going to leave this open for now and I'll try to think of ways to reduce the scope to make this smaller in size 👍


Fix reading of environment variables

Otherwise wrong environment variables without "SEARCHTWEETS_"-prefix are read.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


chore (client): prioritize UI queries over Satellite queries

This PR modifies the generic DB adapter and the capacitor-sqlite DB adapter to use a priority-aware mutex such that UI queries have higher priority than Satellite queries.

👋 we've been working the last month on a rebuild of the Electric server over at a temporary repo https://github.com/electric-sql/electric-next/
You can read more about why we made the decision at https://next.electric-sql.com/about
We're really excited about all the new possibilities the new server brings and we hope you'll check it out soon and give us your feedback.
We're now moving the temporary repo back here. As part of that migration we're closing all the old issues and PRs. We really appreciate you taking the time to investigate and create this improvement!


System.NullReferenceException when downloading or initializing

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Strawberry Shake
Describe the bug
We are trying to initialize a new project and fetching the schema from an external graphql endpoint.
dotnet graphql init https://some-graphql.endpoint/graphql -n MyProject -p . -x "Authorization=Bearer xyz" -x "OtherHeader=value"
Unfortunately it seems to fail as well if we try just to download the Schema.
Download schema started.
Download schema completed in 1425 ms
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 354
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 364
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 356
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 364
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 356
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 364
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypeReference(TypeRef typeRef) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 356
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateFields(IEnumerable`1 fields) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 212
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateObject(FullType type) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 194
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypes(FullType type) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 95
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.CreateTypes(ICollection`1 types)+MoveNext() in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 77
   at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
   at HotChocolate.Utilities.Introspection.IntrospectionDeserializer.Deserialize(IntrospectionResult result) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionDeserializer.cs:line 15
   at HotChocolate.Utilities.Introspection.IntrospectionClient.DownloadSchemaAsync(HttpClient client, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionClient.cs:line 78
   at HotChocolate.Utilities.Introspection.IntrospectionClient.DownloadSchemaAsync(HttpClient client, Stream stream, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/HotChocolate/Utilities/src/Utilities.Introspection/IntrospectionClient.cs:line 49
   at StrawberryShake.Tools.DefaultFileSystem.WriteToAsync(String fileName, Func`2 write) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/DefaultFileSystem.cs:line 81
   at StrawberryShake.Tools.IntrospectionHelper.DownloadSchemaAsync(HttpClient client, IFileSystem fileSystem, IActivity activity, String fileName, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/IntrospectionHelper.cs:line 21
   at StrawberryShake.Tools.InitCommandHandler.DownloadSchemaAsync(InitCommandContext context, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/InitCommandHandler.cs:line 110
   at StrawberryShake.Tools.InitCommandHandler.ExecuteInternalAsync(InitCommandContext context, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/InitCommandHandler.cs:line 87
   at StrawberryShake.Tools.InitCommandHandler.ExecuteAsync(InitCommandArguments arguments, CancellationToken cancellationToken) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/InitCommandHandler.cs:line 73
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.ExecuteAsync(String[] args, CancellationToken cancellationToken)
   at StrawberryShake.Tools.Program.<Main>(String[] args)

We tried other Tools like Apollo to fetch the GraphQL Schema which works, but when we try to import from this file we get an error while building. But that might be due to different Schemas between Apollo and Strawberry?
Determining projects to restore...
  All projects are up-to-date for restore.
  Generate C# Clients started.
  Generate CMSClient started.
  Generate CMSClient completed in 317 ms
  Generate C# Clients completed in 466 ms
  Unhandled exception. System.AggregateException: One or more errors occurred. (The type structure is invalid.)
   ---> System.ArgumentException: The type structure is invalid.
     at HotChocolate.Types.TypeExtensions.NamedType(IType type) in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/Types/Extensions/TypeExtensions.c
  s:line 297
     at HotChocolate.Configuration.Validation.InterfaceHasAtLeastOneImplementationRule.Validate(ReadOnlySpan`1 typeSystemObjects, IReadOnlySchemaOptions
   options, ICollection`1 errors) in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/Configuration/Validation/InterfaceHasAtLeastOneImplementationRu
  le.cs:line 52
     at HotChocolate.Configuration.Validation.SchemaValidator.Validate(IEnumerable`1 typeSystemObjects, IReadOnlySchemaOptions options) in /home/vsts/wo
  rk/1/s/src/HotChocolate/Core/src/Types/Configuration/Validation/SchemaValidator.cs:line 38
     at HotChocolate.Configuration.TypeInitializer.Initialize() in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs:
  line 108
     at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types) in /home/vsts/work/1/
  s/src/HotChocolate/Core/src/Types/SchemaBuilder.Setup.cs:line 198
     at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context) in /home/vsts/work/1/s/src/Hot
  Chocolate/Core/src/Types/SchemaBuilder.Setup.cs:line 63
     at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder) in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/SchemaBuilder.Setup.cs:lin
  e 28
     at HotChocolate.SchemaBuilder.Create() in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/SchemaBuilder.Create.cs:line 10
     at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create() in /home/vsts/work/1/s/src/HotChocolate/Core/src/Types/SchemaBuilder.Create.cs:l
  ine 29
     at StrawberryShake.CodeGeneration.Utilities.SchemaHelper.Load(IReadOnlyCollection`1 schemaFiles, Boolean strictValidation, Boolean noStore) in /hom
  e/vsts/work/1/s/src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/SchemaHelper.cs:line 88
     at StrawberryShake.CodeGeneration.CSharp.CSharpGenerator.TryCreateSchema(IReadOnlyList`1 files, Dictionary`2 fileLookup, ICollection`1 errors, Bool
  ean strictValidation, Boolean noStore, ISchema& schema) in /home/vsts/work/1/s/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/CSharpGene
  rator.cs:line 423
     at StrawberryShake.CodeGeneration.CSharp.CSharpGenerator.GenerateAsync(IEnumerable`1 fileNames, CSharpGeneratorSettings settings) in /home/vsts/wor
  k/1/s/src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/CSharpGenerator.cs:line 101
     --- End of inner exception stack trace ---
     at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
     at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
     at StrawberryShake.Tools.GenerateCommand.GenerateCommandHandler.GenerateClient(String clientName, String[] documents, CSharpGeneratorSettings setti
  ngs) in /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/GenerateCommand.cs:line 164
     at StrawberryShake.Tools.GenerateCommand.GenerateCommandHandler.ExecuteAsync(GenerateCommandArguments args, CancellationToken cancellationToken) in
   /home/vsts/work/1/s/src/StrawberryShake/Tooling/src/dotnet-graphql/GenerateCommand.cs:line 124
     at McMaster.Extensions.CommandLineUtils.CommandLineApplication.ExecuteAsync(String[] args, CancellationToken cancellationToken)
     at StrawberryShake.Tools.Program.<Main>(String[] args)

Any Idea how to solve this?
Steps to reproduce

dotnet graphql init
dotnet build

Relevant log output
No response
Additional Context?
No response
Version
13.0.5

Can you attach the schema?

I need to clarify this. I know this makes it harder to diagnose. But it is an internal API and I am not sure if I am actually allowed to do this.

Does your schema has a type with more than 2 list levels ... like [[[Foo]]]?

The validation check that throws detected a level of type depth greater than six which indicates that there must be a list structure deeper than three. Is this the case? We have limited list nesting to two levels as the spec only defines things to that level. It is not forbidden to have deeper nesting but what is the use-case for this and how deep is the nesting.

Yes, it seems so. I tried to remove those and it seems that those issues are gone now. I will check if I need those types at all .
Will do more tests on Monday
Thank you so far :)

How many levels of list does your schema have? We could increase it if there is a use-case for it that makes sense.

For my current use case I really don't need those (as far as I am aware right now). The current depth looks like 3 - but I am not that familiar with the schema as I am just consuming it


Where are the source codes

Hi,
In order to learn the details of the different algorithms and how to implement them, I am wondering whether the source codes of the different algorithms such as GAMI-Net, Unwrapping Deep ReLu, fairess, etc are available? What programing language do you use to write the algorithms?
Thanks,

Hi @jtonh,
PiML is developed based on Python. However, the source codes are not open-sourced for the time being.
For the GAMI-Net model, refer to the source codes (https://github.com/ZebinYang/gaminet) I developed years ago.


refactor(gateway): replace StreamExt::next with Stream::poll_next

The re-export of Stream in the crate root was only recently added to futures-util, for the sake of minvers you'll have to use it from the stream module


TECH-150: Add OpenAPI spec for Voucher APIs

Add OpenAPI spec for Voucher APIs
Description
Add OpenAPI spec for Voucher APIs. Verified linked APIs and add them to repository

@conradsp  I realized that in the api folder, files swagger.json and swagger.yaml are empty.
If you do not mind I will add API specs to these files. In that case, do you think we should also keep API specs in the test folder as I did?

I seem to remember there being a complex history around the apis in payments. Not sure who would be able to give detail. Jaume?

@rachellawson
Thank you for your comment.
Before starting working on cucumber test for Payments BB - Voucher APIs we received form Vijay Mauree the link to the swagger with correct API specs here: https://app.swaggerhub.com/apis/AKibuuka/voucher/1.0.3#/VoucherPreactivation/VoucherPreactivationPOST :)

Hi @conradsp and @oscarcorreia43 ,
Can we merge the PR?


Remove remnants of native/code generator functionality

With #265 closed, we can drop nutils.py and native.py.
Also mkpython and pyconstruct are obsolete.
README for OSX not required anymore.
Installation instructions should reflect no need for gcc anymore.

Merged in #274


[Feature][JsonSplit-api]processDefinition queryProcessDefinitionAllByProjectId interface

from #5498
Change the request parameter projectId to projectCode,including the front end and controller interface

I will implement the back-end java code logic

fixed by #5744


Explosion Block_Damage

Has this issue already been reported? Did you ask for help before making this report?

[X] I have searched the existing issues
[x] I have asked for help

Current Behavior
When only $GLASS is defined in Block_List and Spawn_Falling_Block_Chance: 0.75

With Blacklist: true
All blocks expect GLASS gets destroyed, but Spawn_Falling_Block_Chance is also used for GLASS blocks that aren't destroyed. This is only a visual bug.

With Blacklist: false
Correct blocks (GLASS) gets destroyed properly. Null is thrown at this line. Id expect spawn falling block bug is here also for all blocks.

Expected Behavior
When a block isn't actually destroyed its falling blocks won't be sent either
Steps To Reproduce
RPG-7:
  Info:
    Weapon_Item:
      Type: "FEATHER"
      Name: "&6RPG-7"
      Unbreakable: true
      Hide_Flags: true
      Attributes:
        - "GENERIC_MOVEMENT_SPEED--0.02855"
      Deny_Use_In_Crafting: true
    Weapon_Info_Display:
      Action_Bar:
        Message: "&6RPG-7 &7«&6%ammo-left%&7»&6%reload%"
        Time: 40
    Weapon_Get_Mechanics:
      Sounds:
        - "ITEM_ARMOR_EQUIP_CHAIN-1-0.75"
    Cancel:
      Drop_Item: true
      Swap_Hands: true
      Arm_Swing_Animation: true
  Skin:
    Default:
      Custom_Model_Data: 101
    Scope:
      Custom_Model_Data: 111
  Projectile: "rocket_launcher.Projectile"
  Shoot:
    Trigger:
      Main_Hand: "RIGHT_CLICK"
      Off_Hand: "RIGHT_CLICK"
      Deny_When:
        Swimming: true
    Projectile_Speed: 40
    Spread:
      Base_Spread: 0.55
      Modify_Spread_When:
        Zooming: 50%
        Sneaking: 50%
        Walking: 0.1
        In_Midair: 150%
        Gliding: 200%
    Recoil:
      Push_Time: 200
      Recover_Time: 200
      Horizontal:
        - 11
        - -11
      Vertical:
        - 11
    Mechanics:
      Sounds:
        - "custom:shoot.rpg7-6-1-0-0.1"
  Reload:
    Trigger:
      Main_Hand: "DROP_ITEM"
      Off_Hand: "DROP_ITEM"
    Magazine_Size: 1
    Reload_Duration: 71
    Start_Mechanics:
      Sounds:
        - "BLOCK_NOTE_BLOCK_HAT-0.5-1-0-0.1"
        - "BLOCK_PISTON_CONTRACT-0.5-1-2-0.1"
        - "ITEM_FLINTANDSTEEL_USE-0.5-1.5-33"
        - "ITEM_FLINTANDSTEEL_USE-0.5-1.7-35"
        - "ITEM_FLINTANDSTEEL_USE-0.5-1.9-37"
        - "BLOCK_PISTON_EXTEND-0.5-1-69-0.1"
  Damage:
    Base_Damage: 12.2
    Base_Explosion_Damage: 12.2
    Fire_Ticks: 40
    Armor_Damage: 4
  Explosion:
    Explosion_Exposure: "DEFAULT"
    Explosion_Shape: "SPHERE"
    Explosion_Type_Data:
      Radius: 5.6
    Detonation:
      Impact_When:
        Entity: true
        Block: true
    Block_Damage:
      Break_Blocks: true
      Spawn_Falling_Block_Chance: 0.75
      Blacklist: false
      Block_List:
        - "$GLASS"
    Regeneration:
      Ticks_Before_Start: 300
      Max_Blocks_Per_Update: 3
      Ticks_Between_Updates: 5
    Flashbang:
      Effect_Distance: 11.2
      Mechanics:
        Potion_Effects:
          - "CONFUSION-200-3-false"
  Scope:
    Trigger:
      Main_Hand: "LEFT_CLICK"
      Off_Hand: "LEFT_CLICK"
    Zoom_Amount: 6
    Mechanics:
      Sounds:
        - "custom:scope.in-0.5-1-0-0.1"
    Zoom_Off:
      Mechanics:
        Sounds:
          - "custom:scope.out-0.5-1-0-0.1"

rocket_launcher:
  Projectile:
    Projectile_Settings:
      Type: "WITHER_SKULL"
      Minimum:
        Speed: 25
      Gravity: 0.02
      Decrease_Motion:
        Base: 0.99
        In_Water: 0.96
        When_Raining_Or_Snowing: 0.98

Frequency
100%
Version and Log
https://imgur.com/qqsEO7Z
[21:17:10] [Server thread/WARN]: [WeaponMechanics] Task #524 for WeaponMechanics v0.3.0 generated an exception
java.lang.NullPointerException: Cannot invoke "me.deecaad.weaponmechanics.weapon.damage.BlockDamageData$DamageData.isBroken()" because "data" is null
        at me.deecaad.weaponmechanics.weapon.explode.Explosion.damageBlocks(Explosion.java:368) ~[?:?]
        at me.deecaad.weaponmechanics.weapon.explode.Explosion.explode(Explosion.java:273) ~[?:?]
        at me.deecaad.weaponmechanics.weapon.projectile.weaponprojectile.RayTraceResult$1.run(RayTraceResult.java:129) ~[?:?]
        at org.bukkit.craftbukkit.v1_18_R1.scheduler.CraftTask.run(CraftTask.java:82) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at org.bukkit.craftbukkit.v1_18_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:415) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1255) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:428) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1206) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1034) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.18.1-R0.1-SNAPSHOT.jar:3368-Spigot-8965a50-2a2caa7]
        at java.lang.Thread.run(Thread.java:833) [?:?]

Anything else?
No response

Forgot to check if a block was blacklisted from block damage, fixed in commit https://github.com/WeaponMechanics/MechanicsMain/commit/6129b42a155ec03656faf56d28dad96f8347569d


Add support for date format string

Is your feature request related to a problem? Please describe.
Want to add support for date formatting to let others choose how dates will be displayed on HTML certs

6/20/24: Dmitri asks if our deployers need this


Feature Request: VNET Peering to the Managed VNET

Is your feature request related to a problem? Please describe.
I would like to consult on and / or request the posibility to Peer a VNET to the managed self-provided VNET created by an ACA Environment.
Describe the solution you'd like.
Being able to peer into the VNET should allow for it to do its managed stuff while allowing easy interaction with other VNETs and services.
For example, if I have a set of microservices bundled together and do not care about their vnet / environment for no other reason besides protecting their front-facing interactions or allowing them to communicate with other services that are hosted on their own vnets.
Describe alternatives you've considered.
My current understanding is that, for example, in order to provision an Application Gateway in front of an ACA Environment, my only choice is to provide a Custom VNET with an Internal Environment. Even in that case, I'm not entirely sure it'll work as it might depend on the same principles as why a Firewall is still not supported:

Using custom user-defined routes (UDRs) or ExpressRoutes, other than with UDRs of selected destinations that you own, are not yet supported for Container App Environments with VNETs. Therefore, securing a Container App Environment with a firewall is not yet supported.

Clarification and correction on this is greatly appreciated :)
Additional context.
As of today, I seem to remember that further documentation on how an External Managed Environment is secured is being worked on -- so for now, directly exposing the external ingress endpoint without any other protections (ie AG, AFD, NSGs, Firewall, etc) might not be the best choice for us.
Regardless of the interest or usefulness of the request itself, I'd be more than welcome to recieve guidance or opinion on this.
Thanks!
EDIT: Might be related #318

@kendallroden Can you please validate if VNET peering is supported or not?
It seems that when I enable it my App Environment is not responding and application's don't start up.
Disabling it brings back the functionality.
I need VNET peering as my container app is calling some internal services that are not on the same VNET and some are on-premises. Pretty much I'm trying to peer to my Hub spoke.
If this is not supported what is currently the alternative for a container app to talk to other internal services?
In my case, I'm using External Endpoint for simplicity with Internal VNET.

VNet peering is supported for custom VNets. This is not something we plan to support for non-custom VNets.


nationalist_dictatorship and populist_dictatorship naming

by Skyhascheese,
Why does the populist Dictatorship have elections?[/QUOTE]
by simsulla
Populist dictatorship (populist_dictatorship) is used for sectarian majority culture nations. Sectarian Dictatorship (nationalist_dictatorship) for sectarian minority authoritarian rule. To call them "dictatorships" is wrong localization.
1992 populist_dictatorship: Bantustans in South Africa, Sudan, Zaire, Zimbabwe, Serb republics
1992 nationalist_dictatorship: South Africa, Syria, Iraq
Populist dictatorship is a bad name for these type of strongly nationalist regimes. They are "democratic" but within a confined setting, modded as only populist and conservative parties allowed in the elections.
Sectarian Dictatorship (nationalist_dictatorship) is used for "flag" reasons in many cases. these are countries where a minority has obtained absolute power (like Sunni in Iraq under Saddam, or shia in Syria under Assad). By necessity they need to fudge elections. Will remove the elections for them.
I am open to a better suggestion for "localization" name for these two types of regimes. Don't like to use "dictatorship" for any type of regime except perhaps presidential_dictatorship. For example, renamed proletarian_dictatorship People's Republic.

Did some research.. starting with nationalist_dictatorships
Rwanda: Republic of Rwanda
Irak (under Sadam): Iraqi Republic
Syria (under Assad's): Syrian Arab Republic
South Africa (under Apartheid):Republic of South Africa
All style them selves as Republics.

then we have the** populist_dictatorship's**
Francoist Spain: Spanish State
Estado Novo Portugal: Portuguese Republic
Zaire: Republic of Zaire
Republics Srpska: Serb Republic
Rwanda (Interahamwe): Republic of Rwanda
Mot often that not these nations name them self after the "dominating" group or even giving the nation a new name.

So till soemone commes up with a better suggestion both will be called Republic (populist_dictatorship) and Republic of (nationalist_dictatorships).

hms_government: Parliamentary Democracy (previously gov. of the Realm)


[Ionic 4] there is no plugin Google Maps ?

Support Question
Where can i found the plugin Google maps for ionic 4 ?
Thx

You mean the wrapper? The google map native wrapper has been moved out of the main repo because it's contributor didn't wanted to have it there
https://forum.ionicframework.com/t/why-native-google-maps-is-removed/128077

Ok thx, did you test it with ionic 4 ?
Because i tested this https://github.com/mapsplugin/ionic-googlemaps-quickdemo-v4 and it seem not compatible with rxjs
"@ionic-native/google-maps": "5.0.0-beta.17"
Error: Can't resolve 'rxjs/Observable' in '/node_modules/@ionic-native/google-maps/ngx'

No idea, I don't use the google map plugin

@Anthony2539 you should probably close this issue and open a support request on the Ionic Forum, I don't think that a problem related to Ionic


Support shellcheck for checking commands inside recipes

Expected behaviour
Shell code is expected to be linted.
Actual behaviour
Now no errors are thrown for incorrect shell commands.
Output of checkmake --version
Output of checkmake --debug <your makefile>
Output of make --version
Sample Makefile to reproduce issue
(some of these things might not apply but the more you can provide the easier
it will be to fix this bug. Thanks!)

If the linted Makefile sets the shell then running shellcheck on individual recipes would make a lot of sense.

One thing to note is that there are a few differences between shell commands as embedded in Makefiles, and normal shell commands... like, shellcheck's rule about using $(...) instead of backticks probably wouldn't make as much sense when run from within checkmake, since $(...) has its own separate meaning from within the Makefile context, and there's that rule about doubling up on dollar signs...

One thing to note is that there are a few differences between shell commands as embedded in Makefiles, and normal shell commands... like, shellcheck's rule about using $(...) instead of backticks probably wouldn't make as much sense when run from within checkmake, since $(...) has its own separate meaning from within the Makefile context, and there's that rule about doubling up on dollar signs...

In which case it should be escaped using $$(...) as you can see in this Makefile.

One thing to note is that there are a few differences between shell commands as embedded in Makefiles, and normal shell commands... like, shellcheck's rule about using $(...) instead of backticks probably wouldn't make as much sense when run from within checkmake, since $(...) has its own separate meaning from within the Makefile context, and there's that rule about doubling up on dollar signs...

In which case it should be escaped using $$(...) as you can see in this Makefile.

Is there a way to edit shellcheck's output to get it to say that instead, though?

Is there a way to edit shellcheck's output to get it to say that instead, though?

You mean ask shellcheck to propose $$(...) to replace backticks if it checks Makefile recipes?

Is there a way to edit shellcheck's output to get it to say that instead, though?

You mean ask shellcheck to propose $$(...) to replace backticks if it checks Makefile recipes?

Well, I'm not quite sure: is this the kind of thing that should be done on shellcheck's end, or should checkmake instead handle transforming shellcheck's output itself before passing it along to the user?

Well, I'm not quite sure: is this the kind of thing that should be done on shellcheck's end, or should checkmake instead handle transforming shellcheck's output itself before passing it along to the user?

Can checkmate relay the output? That’d be very useful, esp if it can readjust the line numbers. Regarding the escaping, I think checkmate should warn and suggest these two options — hopefully the user understands the difference and chooses whichever works best for her in context.

Well, I'm not quite sure: is this the kind of thing that should be done on shellcheck's end, or should checkmake instead handle transforming shellcheck's output itself before passing it along to the user?

Can checkmate relay the output?

I don't know; hey @mrtazz can it do so?


limit is not applied when used with patch

Environment
Knex version: 0.14.3
Database + version: pg 6.4.2
OS: ubuntu 17.10
Bug
I was trying to make objection.js model to update 10 items with couple of conditions:
await NotificationQueueModel.query()
    .patch({
      state: 'PROCESSING',
      pid: batchId
    })
    .whereNull('state')
    .andWhere(builder => {
      builder.where('scheduled', '<=', timestamp).orWhereNull('scheduled')
    })
    .orderBy('created_at', 'asc')
    .limit(10)

The resulting query looks like this:
  knex:query update "notification_queue" set "state" = $1, "pid" = $2, "updated_at" = $3 where "state" is null and ("scheduled" <= $4 or "scheduled" is null) +1s
  knex:bindings [ 'PROCESSING',
  knex:bindings   'f34e0a43ec33901c',
  knex:bindings   2018-02-12T17:58:22.964Z,
  knex:bindings   moment("2018-02-12T18:58:22.964") ] +1s

Is this correct? I think postgreSQL does allow to use the LIMIT with update query so why did knex ignore it?
I did resolve my issue by doing a select instead of UPDATE. There LIMIT is applied correctly, but I really wonder where the problem is.

Why do you think postgresql supports limit in update?
knex_test=# update accounts set last_name = 'foo';
UPDATE 47
knex_test=# update accounts set last_name = 'foo' where last_name = 'bar';
UPDATE 0
knex_test=# update accounts set last_name = 'foo' where last_name = 'bar' limit 1;
ERROR:  syntax error at or near "limit"
LINE 1: ...ounts set last_name = 'foo' where last_name = 'bar' limit 1;
                                                               ^
knex_test=#

@elhigu thanks, should have tried it in postgre console before posting.
Just one more question-wouldn't we want to throw an error in the query builder when limit is used with update? It's rather and edgecase, but it appears on stackoverflow for example here:
https://stackoverflow.com/questions/6289729/mysql-update-query-with-limit
https://stackoverflow.com/questions/11432155/limiting-postgresql-update-command
currently knex just ignores it which can badly suprise you if you're like me and you don't know that limit cannot appear in UPDATE query.  There should be a condition which checks this already and skips the limit. Wouldn't it make more sense to throw instead of just skipping?

I would be happy to accept pull requests, which are throwing errors when knex are used in a wrong way... to me silently ignoring stuff from builder is worse that actually building invalid SQL. At least from invalid SQL we get error from server side.
Though many times it is hard work to investigate if certain combination actually is allowed in some SQL dialects, so adding those errors and testing them is not always trivial.

@elhigu good to hear.
Quickly searching for dialects it seems no other dialect supports it.
SQLite supports it only with a special compile flag(https://stackoverflow.com/a/29074519/671457), so I'd ignore that.
MsSQL has it's special top: https://stackoverflow.com/a/1198404/671457 which is unsopported by knex
Postgre and Mysql doesn't support it like we've already established. So I'd say it would be best to throw when limit is used with UPDATE query. I will try to pull together some PR when I get some time.


Clean way to disconnect sf::Music from stream.

I've been using sf::Music with custom FileStreams up from SFML-2.1
Now with SFML-2.3.1 I suddenly have a new issue. Before, I relied on the unspecified behavior that when you called sf::Music::stop(), the file stream is no longer accessed. And thus, I could destroy the underlying sf::InputStream just fine.
While all is fine during runtime (minor tweak needed to keep the old stream alive while the new stream is opened). During shutdown of my program I run into the problem that the resource system is destroyed before the sound system.
Right now, I'm doing a:
sf::music::openFromMemory("", 0);

On the music entities before I start shutting down all systems of the program. But it's quite a bit of a hack.
(Due to the fact that I'm using static objects, of which the construction and destruction order is not guaranteed)

The issue tracker is for confirmed issues only. Discussions about changes or usage of the API should take place on the forum. Thank you.

Small tip in that case:
https://help.github.com/articles/setting-guidelines-for-repository-contributors/

https://github.com/SFML/SFML
Scroll all the way to the bottom of the page.
GitHub might support parsing a CONTRIBUTING file if one exists, but providing information in the readme located at the root of the repository is a more general approach that works regardless of where the project is hosted.


Allow or deny vanilla command overrides

Similar to cmi's commands, cmi will allow or deny vanilla commands to be overridden in aliased commands.
If you refuse to overwrite the vanilla command "/cmi tp"

Duplicate of #154


rename bpfd to bpfman

The bpfd project has been renamed to bpfman. This commit fixes up the website, updates the descriptions, and adds the new logo.
see https://bpfman.io/main/blog/2023/11/23/bpfd-becomes-bpfman/ for more information!

Thanks for the update!


Background service stop working when app is killed

Your Environment

Plugin version:
Platform: iOS or Android
OS version:
Device manufacturer and model:

Running in Simulator:
React Native version:
Plugin configuration options:
Link to your project:

Context

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Context

Debug logs

BackgroundGeolocation.configure({
  desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
  stationaryRadius: 50,
  distanceFilter: 50,
  debug: true,
  startOnBoot: true,
  stopOnTerminate : false,
  locationProvider: BackgroundGeolocation.ACTIVITY_PROVIDER,
  interval: 1000,
  fastestInterval: 5000,
  activitiesInterval: 1000,
  stopOnStillActivity: false
});

I implemented react headless js to work around this...
https://github.com/eacbkk/react-native-background-geolocation
Here's what you need to do:
https://github.com/eacbkk/react-native-background-geolocation#react-android-headless-location-service-experimental
Here is the commit:
https://github.com/eacbkk/react-native-background-geolocation/commit/8e0645588b7e950e6abadd8808523506ebca11c5
@mauron85 This could be useful. would you consider adding this feature?

@eacbkk should i need to switch the current package with this package?

@eacbkk thanks for reply
After implementing this it's working in background when app is kill but i see multiple logs of it,
componentWillMount(){
AppRegistry.registerHeadlessTask('RNLocationHeadlessService', () => this.locationHeadlessService);
}
locationHeadlessService = async (location) => {
console.log(location , "kia scene ha");
return Promise.resolve();
};

It's because you've put the AppRegistry.registerHeadlessTask in componentwillmount. It should go to your indexjs where you register the React application. Search for AppRegistry.registerComponent in your source. you have to put AppRegistry.registerHeadlessTask on the same place.

@eacbkk how should i able to update the state then?

@eacbkk is your experimental branch replacing my impl of headless with react native headless version? If so feel free to push PR, so I wont loose track of this.

@mauron85 i have test this commit it works great.

@eacbkk  ^^^ ?

@mauron85 it does not replace it. Because 'background-geolocation-android' currently doesn't have React as a dependency. My implementation is on 'react-native-background-geolocation'. If you think it's okay to include react as a dependency in that layer, I can look into replacing that.

@eacbkk how should i able to update the state then?

you headless implementation shouldn't be used to update ui state... It doesn't work when UI is visible. It's only for background operation.

@eacbkk even i place code in root file still getting multiple logs.
import { AppRegistry } from 'react-native';
import App from './App';
import { name as appName } from './app.json';
/* call the endpoint in background */
locationHeadlessService = async location => {
console.log(location, 'kia scene ha');
return Promise.resolve();
};
AppRegistry.registerHeadlessTask(
'RNLocationHeadlessService',
() => this.locationHeadlessService,
);
AppRegistry.registerComponent(appName, () => App);

@eacbkk I was calling background.start() multiple times that why multiple logs happens

@eacbkk is there any way to de register headlesstask
AppRegistry.registerHeadlessTask('RNLocationHeadlessService', () => this.locationHeadlessService);

@eacbkk is there any way to de register headlesstask
AppRegistry.registerHeadlessTask('RNLocationHeadlessService', () => this.locationHeadlessService);

what's the use case. I don't believe react native supports deregistering.

@eacbkk I'm working on live tracking app, i want to use background location only when rides starts and stop using background location when rides ends.

@eacbkk I'm working on live tracking app, i want to use background location only when rides starts and stop using background location when rides ends.

Yah. But why would you need to de-register the headless service? Calling the stop function should suffice. If you don't want to do that, check for some condition in your js function I guess.

@eacbkk i tried your commit and it works as expected. I used registerHeadlessTask at the componentDidMount
  componentDidMount() {
    console.log('map did mount');
    AppRegistry.registerHeadlessTask('RNLocationHeadlessService', () => this.locationHeadlessService);

I think you can create pull request about it because otherwise it does not work when app is killed.

Do we have better solution or still going for @eacbkk  workaround?

I implemented react headless js to work around this...
https://github.com/eacbkk/react-native-background-geolocation
Here's what you need to do:
https://github.com/eacbkk/react-native-background-geolocation#react-android-headless-location-service-experimental
Here is the commit:
eacbkk@8e06455
@mauron85 This could be useful. would you consider adding this feature?

is possible in IOS ?

@mauron85 do you think we can integrate the implementation? It has been in my production application for the last few months. And I can report it has been working great. The only catch is I need to include the react-native library in the android commons project.

Any news about this feature ! We need it here

to revive this..

@eacbkk is your experimental branch replacing my impl of headless with react native headless version? If so feel free to push PR, so I wont loose track of this.

I don't see PR in the list ? @eacbkk

@eacbkk
Thanks for the patch (https://github.com/eacbkk/react-native-background-geolocation/commit/8e0645588b7e950e6abadd8808523506ebca11c5)
I've managed to run it fine.
However I find sometime the headless task is not called out of sudden , I find restarting app a few times fixes the problem.
Has anyone encountered such problem?

Why on me, headless task only work once. If I close the app for second time headless task does not work anymore.

Are you watching the logs?

Sorry my bad, the problem I guess was I keep calling  BackgroundGeolocation.stop();.  on componentWillUnmount followed by   BackgroundGeolocation.start();.  The listener might not rebinding, when I remove .stop() it works

After call BackgroundGeolocation.stop(); and then i call BackgroundGeolocation.start(); headlesstask won't start again.

anything update?

I implemented react headless js to work around this...
https://github.com/eacbkk/react-native-background-geolocation
Here's what you need to do:
https://github.com/eacbkk/react-native-background-geolocation#react-android-headless-location-service-experimental
Here is the commit:
eacbkk@8e06455
@mauron85 This could be useful. would you consider adding this feature?

It stop working when clear all app from recently. but in few minute foreground notification pop up and i debug in android studio location still update but headlesstask not working.

@eacbkk is it necessary to perform stuff inside headlesssLocationService.js file? Because I'm sending my data directly through url parameter, if my app is terminated headlesssLocationService.js works but at the same time my BackgroundGeolocation.configure settings also working.
My headlessLocationService.js. This works if I terminate the app
export default async (Location) => {
  console.log(location);
  // do something here
  return Promise.resolve()
}

But at the same time this also working if I terminate the app.
BackgroundGeolocation.configure({
      desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
      stationaryRadius: 5,
      distanceFilter: 5,
      notificationTitle: 'Trackme GPS Tracking',
      notificationText: 'Enabled',
      notificationIconColor: '#3D80E5',
      notificationsEnabled: true,
      debug: true,
      startOnBoot: false,
      stopOnTerminate: false,
      locationProvider: BackgroundGeolocation.ACTIVITY_PROVIDER,
      interval: interval,
      fastestInterval: 5000,
      activitiesInterval: 5000,
      stopOnStillActivity: false,
      url: `${Config.API_DEV}/api/services/location`,
      syncUrl: `${Config.API_DEV}/api/services/sync_location`,
      syncThreshold: 100,
      httpHeaders: {
        Accept: 'application/json',
        'Content-Type': 'application/json',
      },
      // customize post properties
      postTemplate: {
        id: '@id',
        lat: '@latitude',
        lon: '@longitude',
        gps_time: '@time',
        speed: '@speed',
        bearing: '@bearing',
        altitude: '@altitude',
        accuracy: '@accuracy',

        macaddress: data ? data.macaddress : null,
        objectid: data ? data.objectid : null,
        statusDesc: this.appstate,
      },
    })

Which one should I follow?

@eacbkk is it necessary to perform stuff inside headlesssLocationService.js file? Because I'm sending my data directly through url parameter, if my app is terminated headlesssLocationService.js works but at the same time my BackgroundGeolocation.configure settings also working.
My headlessLocationService.js. This works if I terminate the app
export default async (Location) => {
  console.log(location);
  // do something here
  return Promise.resolve()
}

But at the same time this also working if I terminate the app.
BackgroundGeolocation.configure({
      desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
      stationaryRadius: 5,
      distanceFilter: 5,
      notificationTitle: 'Trackme GPS Tracking',
      notificationText: 'Enabled',
      notificationIconColor: '#3D80E5',
      notificationsEnabled: true,
      debug: true,
      startOnBoot: false,
      stopOnTerminate: false,
      locationProvider: BackgroundGeolocation.ACTIVITY_PROVIDER,
      interval: interval,
      fastestInterval: 5000,
      activitiesInterval: 5000,
      stopOnStillActivity: false,
      url: `${Config.API_DEV}/api/services/location`,
      syncUrl: `${Config.API_DEV}/api/services/sync_location`,
      syncThreshold: 100,
      httpHeaders: {
        Accept: 'application/json',
        'Content-Type': 'application/json',
      },
      // customize post properties
      postTemplate: {
        id: '@id',
        lat: '@latitude',
        lon: '@longitude',
        gps_time: '@time',
        speed: '@speed',
        bearing: '@bearing',
        altitude: '@altitude',
        accuracy: '@accuracy',

        macaddress: data ? data.macaddress : null,
        objectid: data ? data.objectid : null,
        statusDesc: this.appstate,
      },
    })

Which one should I follow?


Documentation - Roadmap: add @nuxt/test-utils

Environment
Not Applicable
Reproduction

Go on https://nuxt.com/docs/community/roadmap
Check that there is no mention of @nuxt/test-utils

Describe the bug
(Not really a bug, but not really a feature request)
The testing section is mentioning that @nuxt/test-utils is still in development (https://nuxt.com/docs/getting-started/testing) but I cannot seem to find any place where there are some ETA or rough estimation.
To me, the Roadmap page is the perfect place for such information https://nuxt.com/docs/community/roadmap.
Additional context
No response
Logs
No response

Is there an update when @nuxt/test-utils will be production ready?

I would like to help fix this, @danielroe is there additional information I should note

We need to add documentation for Nuxt Test Utils and indicate that it is stable and suitable for use. Some documentation can be found at https://nuxt.com/docs/guide/going-further/modules/#testing.

Thanks for the update, I'll get started on it @danielroe


Sonoff Bulb B-02-B-A60 doesnt have attributes

Sonoff Bulb B-02-B-A60 doesnt have attributes like brightness & color temp. Recognized like switch. by default.
If I change it to light via configuration, nothing changes except domain name (switch to light)

Have you tried latest beta?

Have you tried latest beta?

v2.4b1 doesnt recognises at all.  v2.4b0 just like switch same as latest stable version

some logs on v2.4b1
2021-02-19 11:16:53 ERROR (MainThread) [homeassistant.components.light] Error adding entities for domain light with platform sonoff
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 315, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 421, in _async_add_entity
    capabilities=entity.capability_attributes,
  File "/config/custom_components/sonoff/light.py", line 608, in capability_attributes
    ATTR_MIN_MIREDS: round(self._min_mireds),
TypeError: type NoneType doesn't define __round__ method
2021-02-19 11:16:53 ERROR (MainThread) [homeassistant.components.light] Error while setting up sonoff platform for light
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 206, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 315, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 421, in _async_add_entity
    capabilities=entity.capability_attributes,
  File "/config/custom_components/sonoff/light.py", line 608, in capability_attributes
    ATTR_MIN_MIREDS: round(self._min_mireds),
TypeError: type NoneType doesn't define __round__ method

Latest version fixed it for me!

Latest version 2.4 fixed it for me!

In general, yes. But still there is an issue with color temp. In Developer Tools for color temp reported values range
from 153 (for warm) to -148 (for cool)

at the same time in lovelace range of color temp from 153 to 454

So if you change colortemp in lovelace it always shows value 153

Fixed


Can't update, "WARNING: The following packages cannot be authenticated!" ?

I had a crouton chroot running trusty fine, then I went to try to update.
It balked at updating R with the following error:
WARNING: The following packages cannot be authenticated!
r-cran-codetools r-cran-foreign r-cran-mass r-cran-matrix r-cran-nlme
E: There are problems and -y was used without --force-yes
Failed to complete chroot setup.
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...

I then tried to enter the chroot and manually apt-get update R, but X11 was borked: "X11 backend not set.".
Any tips on how I can either get R to update from the ChromeOS side or just uninstall it and reinstall from inside the chroot?
Thanks!

Sorry, fixed it myself after enough googling.
For future reference:
Enter the CLI for the chroot (skipping X11) using sudo enter-chroot -n trusty
"d" deletes the old script
Then, you're at the command line. From there, add the public key for R from the cran repository:
sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys E084DAB9
Finally, update packages from within the chroot:  sudo apt-get update -y --force-yes
Exit the chroot, and the regular crouton update script works fine.
BTW, thank you David and others for all your hard work.  :)


Check against valid category ID in Shopware_Controllers_Backend_Category::saveDetail

1. Why is this change necessary?
Trying to update a category that has been removed by another user will result in an uncatched error.
2. What does this change do, exactly?
Check if a category could be found and otherwise return a more descriptive error to the end user.
3. Describe each step to reproduce the issue or behaviour.

Use 2 tabs/windows with the backend and open the same category
modify something in first tab
delete category in second tab
try saving in first tab
-> error

4. Please link to the relevant issues (if any).
This is #2322 but without refactoring & translation. I will add a follow up PR with that changes.
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25319
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


Added CircleCI config

This runs linting and TS type checking per #196
We will still need to copy over what's on Jenkins to enable testing

Temporarily closing and reopening this PR to see if CircleCI builds it

Looks like that didn't work either (build log) but feel free to make changes on master to try to get it to work.


Tracking issue for RFC-5: BeyondFS Design

RFC PR

Steps

[ ] implement a POSIX-ish file system that only caches metadata locally.
[ ] performance improvement including prefetch and cache logic.
[ ] extend our metadata cache logic to other key/value systems.

Maybe we can use https://github.com/dgraph-io/ristretto for memory cache.


How to make specific feature not support

Hi.
When server request SupportedFeatureProfiles of GetConfiguration, I want the device response without including LocalAuthListManagement.
Where can I config the supported feature?

Hi @JungHeum-Park, you can set the build flag MO_ENABLE_LOCAL_AUTH=0 which disables that feature and the corresponding entry in the SupportedFeatureProfiles won't show up.


Can't build due to usage of removed std::num::FromPrimitive

I cloned the examples repo, https://github.com/rust-gnome/examples, and tried to build it with the latest Rust nightly. However, it fails since gtk-sys depends on std::num::FromPrimitive which has been removed from Rust's API. Here's another project that experienced the same problem: https://github.com/brson/rust-sdl/issues/165
My terminal output:
$ rustc --version
rustc 1.1.0-nightly (5fb0259ed 2015-04-26) (built 2015-04-27)
$ cargo clean
$ cargo build
  Compiling libc v0.1.6
  Compiling gcc v0.3.4
  Compiling bitflags v0.1.1
  Compiling c_vec v1.0.11
  Compiling pkg-config v0.3.3
  Compiling gtk-sys v0.1.0 (https://github.com/rust-gnome/gtk#0121d69b)
  Compiling gdk-sys v0.1.0 (https://github.com/rust-gnome/gdk#2b1fc225)
  Compiling pango-sys v0.1.0 (https://github.com/rust-gnome/pango#3ce36f5e)
  Compiling glib-sys v0.1.0 (https://github.com/rust-gnome/glib#e8fc0580)
  Compiling cairo-sys v0.1.0 (https://github.com/rust-gnome/cairo#93cb13e5)
  Compiling glib v0.0.1 (https://github.com/rust-gnome/glib#e8fc0580)
  Compiling pango v0.0.1 (https://github.com/rust-gnome/pango#3ce36f5e)
  Compiling cairo v0.0.1 (https://github.com/rust-gnome/cairo#93cb13e5)
  Compiling gdk v0.0.1 (https://github.com/rust-gnome/gdk#2b1fc225)
/home/matachi/.cargo/git/checkouts/gtk-d0515cff4231591e/master/gtk-sys/src/enums.rs:816:47: 816:60 error: use of undeclared trait name `std::num::FromPrimitive`
/home/matachi/.cargo/git/checkouts/gtk-d0515cff4231591e/master/gtk-sys/src/enums.rs:816 #[derive(Clone, PartialEq, PartialOrd, Debug, FromPrimitive, Copy)]
                                                                                ^~~~~~~~~~~~~
/home/matachi/.cargo/git/checkouts/gtk-d0515cff4231591e/master/gtk-sys/src/enums.rs:816:47: 816:60 note: in expansion of #[derive_FromPrimitive]
/home/matachi/.cargo/git/checkouts/gtk-d0515cff4231591e/master/gtk-sys/src/enums.rs:816:47: 816:60 note: expansion site
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `gtk-sys`.

To learn more, run the command again with --verbose.

I think that just changed in rust nightly. I'll fix that tonight (or maybe you wanna fix it yourself ? Feel free to open a PR).

I'm not very experienced with Rust. But applying this change makes it compile:
diff --git a/gtk-sys/src/enums.rs b/gtk-sys/src/enums.rs
index 3c04636..42aad25 100644
--- a/gtk-sys/src/enums.rs
+++ b/gtk-sys/src/enums.rs
@@ -813,7 +813,7 @@ pub enum License {
 /// Predefined values for use as response ids in gtk_dialog_add_button().
 /// All predefined values are negative, GTK+ leaves positive values for application-defined response ids.
 #[repr(C)]
-#[derive(Clone, PartialEq, PartialOrd, Debug, FromPrimitive, Copy)]
+#[derive(Clone, PartialEq, PartialOrd, Debug, Copy)]
 pub enum ResponseType {
     /// Returned if an action widget has no response id, or if the dialog gets programmatically hidden or destroyed
     None        = -1,

However, I not experienced enough to know what side effects this change might have.

We should probably start targeting rust-beta instead of nightly.

@gkoz: not for now. When rust 1.0 will be out, we'll create a branch to support nightly.

The 1.0 release is very close. We won't fix everything overnight. Also I'm not sure there's much benefit to tracking nightlies at the moment.

It's about to give the possibility, nothing more. The master will be on the release. And try to compile rgtk with the beta. =D

I know it doesn't build on beta today. Two weeks is about the right amount of time to fix everything but we can't do that if we don't decide to start tracking beta.

It's not a problem if we're not compiling on the release the first day. I prefer wait and then start the work.

Evidently it's already become an issue for someone and the number of people expecting the project to build on the beta and then the stable channel is going to increase every day now.

We can't compile with the beta since it's all buggy. Features aren't working for example.

Whatever hasn't been stabilized will need to be let go or worked around.  ;)

You couldn't guess, that's not a problem, we'll change it if it is needed.

I suppose this issue can be closed now ?
@gkoz: Unique won't be stabilized before 1.0 release.

@GuillaumeGomez so do we back it out of c_vec or eliminate the c_vec dependency here? Not bumping c_vec to at least 1.1 bites us now because we could've maintained parallel branches with different APIs.

I think it's better to update c_vec. gtk isn't the only project to use it so I'll have to change it a day or another before the 1.0 release.
I'll update it tonight, or maybe you wanna do it ? You implemented the Unique part so as you prefer.

Maybe we still can solve this relatively gracefully: you make another branch and bump one of them to 1.1 now and then we can also release 1.0.12 with Unique removed.

I think it would be preferrable to just remove Unique with version 1.0.12. People who want to keep the Unique handling will just stay on the 1.0.11.

That wouldn't let us fix anything else that could need fixing in 1.0.11.
Unique will get stabilized sooner or later so it's the Rust 1.0 needs that are temporary but a forward-looking branch doesn't need to break at all. I we make a 1.1 branch now, users that are cool with nightlies will not experience any breakage at all and those targeting Rust 1.0 can stay on c_vec 1.0.

Okay, I didn't saw it that way. I create the 1.1 branch.

Meh. Turns out neither of std::thunk and FnBox is stable so we can't make c_vec with destructors work with 1.0. We may have to remove this dependency from gtk after all...

And so the 1.1 branch isn't needed anymore. Why not ? We should give it a try.

This seems to be resolved.

Indeed.


Migrate to GitHub Actions.

Travis CI has a new pricing model which places limits on open source.

https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
https://www.jeffgeerling.com/blog/2020/travis-cis-new-pricing-plan-threw-wrench-my-open-source-works

Many projects are moving to GitHub Actions instead, including Jazzband projects

https://github.com/orgs/jazzband/projects/1
https://github.com/jazzband-roadies/help/issues/206

This is based on https://github.com/jazzband/contextlib2/pull/26.
TODO:

[x] @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.
[x] @jezdez to add @iMerica as project lead (refs #1).

Do not merge. This project doesn't use Travis CI.

I'd prefer to transfer out of Jazzband. Not because I like Circle CI or dislike GitHub Actions, (both are great) but because I don't like the way this is being handled. A bit too unilateral and oligarchical - against the ethos of open source.
Please close this PR and we can discuss transferring back to my personal account.
Thank you,
Michael

I'd prefer to transfer out of Jazzband. Not because I like Circle CI or dislike GitHub Actions, (both are great) but because I don't like the way this is being handled. A bit too unilateral and oligarchical - against the ethos of open source.
Please close this PR and we can discuss transferring back to my personal account.
Thank you,
Michael

Hey Micheal, I'm sorry this rubs you the wrong way, all I can say is that I'm not making this unilaterally (e.g. requested your code review right here) or oligarchically (wow!). I want to move to one CI solution (GitHub Actions) since I realized that it's easier and less risky to maintain all Jazzband projects if they are a bit more consistent.
I'm not sure how this is against "the ethos of open source" to be quite honest, but I'd be interested to hear how you'd have handled this instead. Remember I'm not getting paid to do this work.
There isn't much to discuss regarding the transfer to your personal account, except:

For some reasons on GitHub's side I'll have to first transfer the repo to my personal account since organization repos can't be transferred to personal accounts of organization members that aren't owners. Once in my personal account I'll immediately request the transfer to you.

Once requested, you'll have to accept the repo transfer using the email GitHub sends you.

Remember to remove the Jazzband accounts from ReadTheDocs and PyPI.

Please let me know if you have any other question before I do that.

Hey @iMerica! Just chiming in with my personal thoughts since I already participated in the PR process and this caught my eye in the GitHub backlog. Please feel free to disregard my notes here if they don't seem relevant.
A fact behind this PR is that the majority of the Jazzband projects have been running on Travis CI and need to be migrated to another solution, and one of the viable solutions is GitHub Actions which has proven to be quite handy CI service with Python based projects. This migration is being performed as bulk work that needs to be done on dozens of repos, so dj-rest-auth might have been caught, maybe unnecessarily, in that process?
I think people in Jazzband are mainly trying to help out with the package maintenance. Jannis has personally done a lot for the community, offering infrastructure as well as maintenance help for projects on his free time, and I can't imagine his intents being malevolent here?
If this PR process or Jazzband community has violated your maintenance model for the project or was done in an unsuitable way I understand that you need to move the project to your personal account.
However, I would also see this as an opportunity for discussion and improvement on the ways of collaborating. I'm pondering on how could the PR and contributions process be improved for maximum transparency, and what would you like to have seen to be done differently in the Jazzband organization?

@jezdez

Remember I'm not getting paid to do this work.

None of us are. We all have this in common.

all I can say is that I'm not making this unilaterally

This is clearly not true. A unilateral decision doesn't become less unilateral because you add someone as a reviewer to the PR with the choices: approve the PR or leave. You even go on to say "the decision is final" (whose decision?) in this PR and in #1 you state "I'm porting all Jazzband projects to GitHub Actions" (emphasis mine). I use the word unilateral very deliberately here because it perfectly describes the situation at hand.
There might be completely valid reasons for moving to Github Actions, but as the leader of this project with the most skin in the game, I wasn't even consulted to hear those reasons or weigh in. This sets a very bad precedent no matter how well intentioned.
I'm going to close this PR now since it doesn't solve a specific concrete problem in this project and Circle CI has been working well for us. Overall my preference is to stay in Jazzband, but if it means unilateral PRs with the ultimatum approve or leave, then I would prefer to port this project back to my account.

@jezdez

all I can say is that I'm not making this unilaterally

This is clearly not true. A unilateral decision doesn't become less unilateral because you add someone as a reviewer to the PR with the choices: approve the PR or leave.

What you may not know is that I've seen primarily positive feedback from other Jazzband proejcts about the migration to GitHub Actions prior to this PR when the issue of Travis came up. The effect of Travis throttling test runs for Open Source projects was noticable (long delays, tests ran the next day). ~40 projects have already been ported and it was dj-rest-auth's turn to be ported. So I sent this pull request like with all the other PRs I sent to other Jazzband projects. I could have made the change directly but have strived to involve the project leads to keep them informed about infrastructure changes.
To give a bit of context: when Jazzband started, it was basically fair-game to just continue to use whatever service a project may have used before it was transferred. With the recent changes at Travis, I came to realize that if Jazzband wants to stay maintainable long-term, we'll have to revisit that lax pattern of use. That's why we've stopped using AppVeyor, Semaphore, Landscape.io, Coveralls (still ongoing) and many other minor services.

You even go on to say "the decision is final" (whose decision?) in this PR and in #1 you state "I'm porting all Jazzband projects to GitHub Actions" (emphasis mine). I use the word unilateral very deliberately here because it perfectly describes the situation at hand.

The decision to move to GitHub Actions was mine, since I'm a Jazzband roadie (read: admin) whose task is mainly to make sure the Jazzband projects can continue to be maintained. As project lead you may disagree with the decision of course and take the repo elsewhere. I totally understand if you have other priorities and hope you understand that I need to keep the larger goal of Jazzband in mind.
I said "I'm porting all Jazzband projects to GitHub Actions" in #1 since I planned and led the work of manually porting Jazzband projects to GitHub Actions that weren't themselves already using GitHub Actions. Of course there are many other people involved: reviewers, project leads, code contributors. I'm sorry if my choice of words implied it was just me doing the work.

There might be completely valid reasons for moving to Github Actions, but as the leader of this project with the most skin in the game, I wasn't even consulted to hear those reasons or weigh in. This sets a very bad precedent no matter how well intentioned.

Making infrastructure decisions for Jazzband has always been the prerogative of roadies, so this isn't setting a precedent but continues previously agreed upon separation of concerns in the Jazzband GitHub organization. I do think that our discussion here has again proven that we a) need more roadies (https://github.com/jazzband-roadies/help/issues/196) and b) that we need to be clear about expectations when we onboard new projects.

I'm going to close this PR now since it doesn't solve a specific concrete problem in this project and Circle CI has been working well for us. Overall my preference is to stay in Jazzband, but if it means unilateral PRs with the ultimatum approve or leave, then I would prefer to port this project back to my account.

Circle CI has been working well so far similar to how Travis worked well until it didn't anymore. This PR is a course correction to make sure Jazzband's infrastructure is maintainable in the future.
Thank you for your willingness to share your concerns here and give feedback so that I can improve the onboarding process and roadie/project lead communication.
I'll be transferring the repo momentarily to your account (see https://github.com/jazzband/dj-rest-auth/pull/197#issuecomment-749179767 for how it works). Please remember to remove Jazzband accounts from PyPI and Readthedocs again.

@jezdez

all I can say is that I'm not making this unilaterally

This is clearly not true. A unilateral decision doesn't become less unilateral because you add someone as a reviewer to the PR with the choices: approve the PR or leave.

What you may not know is that I've seen primarily positive feedback from other Jazzband proejcts about the migration to GitHub Actions prior to this PR when the issue of Travis came up. The effect of Travis throttling test runs for Open Source projects was noticable (long delays, tests ran the next day). ~40 projects have already been ported and it was dj-rest-auth's turn to be ported. So I sent this pull request like with all the other PRs I sent to other Jazzband projects. I could have made the change directly but have strived to involve the project leads to keep them informed about infrastructure changes.
To give a bit of context: when Jazzband started, it was basically fair-game to just continue to use whatever service a project may have used before it was transferred. With the recent changes at Travis, I came to realize that if Jazzband wants to stay maintainable long-term, we'll have to revisit that lax pattern of use. That's why we've stopped using AppVeyor, Semaphore, Landscape.io, Coveralls (still ongoing) and many other minor services.

You even go on to say "the decision is final" (whose decision?) in this PR and in #1 you state "I'm porting all Jazzband projects to GitHub Actions" (emphasis mine). I use the word unilateral very deliberately here because it perfectly describes the situation at hand.

The decision to move to GitHub Actions was mine, since I'm a Jazzband roadie (read: admin) whose task is mainly to make sure the Jazzband projects can continue to be maintained. As project lead you may disagree with the decision of course and take the repo elsewhere. I totally understand if you have other priorities and hope you understand that I need to keep the larger goal of Jazzband in mind.
I said "I'm porting all Jazzband projects to GitHub Actions" in #1 since I planned and led the work of manually porting Jazzband projects to GitHub Actions that weren't themselves already using GitHub Actions. Of course there are many other people involved: reviewers, project leads, code contributors. I'm sorry if my choice of words implied it was just me doing the work.

There might be completely valid reasons for moving to Github Actions, but as the leader of this project with the most skin in the game, I wasn't even consulted to hear those reasons or weigh in. This sets a very bad precedent no matter how well intentioned.

Making infrastructure decisions for Jazzband has always been the prerogative of roadies, so this isn't setting a precedent but continues previously agreed upon separation of concerns in the Jazzband GitHub organization. I do think that our discussion here has again proven that we a) need more roadies (https://github.com/jazzband-roadies/help/issues/196) and b) that we need to be clear about expectations when we onboard new projects.

I'm going to close this PR now since it doesn't solve a specific concrete problem in this project and Circle CI has been working well for us. Overall my preference is to stay in Jazzband, but if it means unilateral PRs with the ultimatum approve or leave, then I would prefer to port this project back to my account.

Circle CI has been working well so far similar to how Travis worked well until it didn't anymore. This PR is a course correction to make sure Jazzband's infrastructure is maintainable in the future.
Thank you for your willingness to share your concerns here and give feedback so that I can improve the onboarding process and roadie/project lead communication.
I'll be transferring the repo momentarily to your account (see https://github.com/jazzband/dj-rest-auth/pull/197#issuecomment-749179767 for how it works). Please remember to remove Jazzband accounts from PyPI and Readthedocs again.

@iMerica Whelp, there is already dj-rest-auth repo under your namespace. I'll be renaming the intermediate repo to make sure you can transfer the repo as fast as possible.

@iMerica Whelp, there is already dj-rest-auth repo under your namespace. I'll be renaming the intermediate repo to make sure you can transfer the repo as fast as possible.

@iMerica Sigh, GitHub doesn't allow transfer a repo (even if not having the same name) if you already have a repo under your account in the network of the repo to be transferred. Could you please remove the repo in your account or let me know where to transfer the repo instead?

@iMerica Sigh, GitHub doesn't allow transfer a repo (even if not having the same name) if you already have a repo under your account in the network of the repo to be transferred. Could you please remove the repo in your account or let me know where to transfer the repo instead?

@iMerica I've moved the repo back to the Jazzband org until we can unblock the transfer back to you. Apologies for the complications.

@iMerica I've moved the repo back to the Jazzband org until we can unblock the transfer back to you. Apologies for the complications.

No hard feelings. When I joined I was under the impression Jazzband was a group of open source authors helping each other maintain their projects, not a group ruled by the whims of a single person who can make sweeping changes across every repo.
The repo on my namespace has been renamed. Best of luck!

No hard feelings. When I joined I was under the impression Jazzband was a group of open source authors helping each other maintain their projects, not a group ruled by the whims of a single person who can make sweeping changes across every repo.
The repo on my namespace has been renamed. Best of luck!

No hard feelings. When I joined I was under the impression Jazzband was a group of open source authors helping each other maintain their projects, not a group ruled by the whims of a single person who can make sweeping changes across every repo.

Noted.

The repo on my namespace has been renamed. Best of luck!

Thanks, but renaming seems to be not enough, GitHub expects there to be no repo under a namespace in a repo's "network", aka forks:

I've moved the repo back to Jazzband until this is unblocked.

No hard feelings. When I joined I was under the impression Jazzband was a group of open source authors helping each other maintain their projects, not a group ruled by the whims of a single person who can make sweeping changes across every repo.

Noted.

The repo on my namespace has been renamed. Best of luck!

Thanks, but renaming seems to be not enough, GitHub expects there to be no repo under a namespace in a repo's "network", aka forks:

I've moved the repo back to Jazzband until this is unblocked.

I've completed deleting that other repo. Can you try again? Thank you.

I've completed deleting that other repo. Can you try again? Thank you.

I've deleted that other repo. Can you try again? Thank you.

I've sent the transfer request, thank you for your patience.

@iMerica Hi Michael, just checking in to see if the transfer request has reached you? I think I may need to send it again since it expires after a while, but I'm not sure after how long. Let me know if that's the case so I can resend the transfer request. Thank you!

That link expired unfortunately. Can you try again?

That link expired unfortunately. Can you try again?

Done.

Thanks 👍

@jezdez nothing personal but I think this org is too centralized & on an administrative level only managed by one person.

@jezdez nothing personal but I think this org is too centralized & on an administrative level only managed by one person.

Hey thanks for the input @auvipy, I think. I totally agree that Jazzband has grown so much that it's way overdue to add a few more people to the Jazzband roadies. This is tracked in https://github.com/jazzband-roadies/help/issues/196 where I also shared circumstances for my interest in growing the roadies and some of my plans.
Generally speaking I've learned over the years of managing Jazzband that while there is some concern around the bus-factor, it's much harder to scale Jazzband since it's a volunteer organization (read: few want to do the admin work), and there is no staff or legal structure that would simplify scaling up. Making sure that Jazzband retains its characteristics while it's growing is also difficult but something that must be tackled, I'm certain of that. Until I have more concrete steps to show though, I have to live with feedback like yours or Michael's above. I don't blame you for being frustrated, I really understand it.

but consider my input as feedback to improve the overall exp. thanks for your works btw

but consider my input as feedback to improve the overall exp. thanks for your works btw

Absolutely, thank you for YOUR contributions as well!