When will a branch with mac support be developed?

mac M3 arm64 error:
RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.

Could you please post full ComfyUI log?

On my Mac M2 Max (arm64) I have exactly the same error in node PowerPaintCLIPLoader. Fully ComfyUI log is as follows:

Using split attention in VAE
Using split attention in VAE
Using split attention in VAE
Using split attention in VAE
PowerPaint model type: SD1.5
PowerPaint model file: /Users/chris/git/ComfyUI/models/inpaint/powerpaint/powerpaint_v2.safetensors
PowerPaint model is loaded
clip missing: ['text_projection.weight']
PowerPaint base CLIP file:  /Users/chris/git/ComfyUI/models/clip/model.fp16.safetensors
Successfully add external embeddings: P_ctxt, P_shape, P_obj. current
Successfully add trainable external embeddings: P_ctxt, P_shape, P_obj current
!!! Exception during processing!!! Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.
Traceback (most recent call last):
File "/Users/chris/git/ComfyUI/execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/Users/chris/git/ComfyUI/execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/Users/chris/git/ComfyUI/custom_nodes/ComfyUI-0246/utils.py", line 381, in new_func
res_value = old_func(*final_args, **kwargs)
File "/Users/chris/git/ComfyUI/execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/Users/chris/git/ComfyUI/custom_nodes/ComfyUI-BrushNet/brushnet_nodes.py", line 173, in ppclip_loading
pp_text_encoder.load_state_dict(torch.load(pp_CLIP_file), strict=False)
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 1026, in load
return _load(opened_zipfile,
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 1438, in _load
result = unpickler.load()
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 1408, in persistent_load
typed_storage = load_tensor(dtype, nbytes, key, _maybe_decode_ascii(location))
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 1382, in load_tensor
wrap_storage=restore_location(storage, location),
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 391, in default_restore_location
result = fn(storage, location)
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 266, in _cuda_deserialize
device = validate_cuda_device(location)
File "/Users/chris/git/ComfyUI/venv/lib/python3.10/site-packages/torch/serialization.py", line 250, in validate_cuda_device
raise RuntimeError('Attempting to deserialize object on a CUDA '
RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.

Ok, this is something. I don't have access to Mac, so if you will post errors we can try to fix it together. I removed torch.load, update and try it.

Thank you. It seems it fixed the issue - there is no error on my Mac now and object removal using PowerPaint v2 works as expected.

Great! That you too.

Great!


Add files param to package.json to reduce file size of npm package

On master, this module currently package up 169 files amounting to 4.4 MB. By specifying only the dist directory in the package.json, we can eliminate the test and example app code from npm and bring it down to 10 files amounting to 1.2 MB.
I wrote a small module to assist with showing what is getting packaged up called npm-unpack.
$ npm i -g npm-unpack
$ npm-unpack
Packing<EMAIL_ADDRESS>
Number of files: 10

package.json
README.md
index.js
LICENSE.txt
dist/checkout.js
dist/checkout.lib.js
dist/checkout.min.js
dist/checkout.js.map
dist/checkout.lib.js.map
dist/checkout.min.js.map

I'd actually like to keep src/. If another module requiring paypal-checkout uses ES6 with webpack, they can just require us from src/ directly and the resulting bundle stays deduped. We're using this pattern internally for our dependency graph between paypal-checkout, xcomponent and post-robot.
So I'm thinking we can keep:
src/**```

We can dump the other stuff from dist/ since that's mainly geared towards paypalobjects -- `checkout.lib.js` is the UMD module designed for consumption through npm.

That work?

Makes sense to me. That brought down the package size to 468K.

Perfect. Merging this once the build passes.


[Security] Getting Started with Nessus Scanner

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #5934

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.
No

Hello @Adespscientist ,
Welcome to EngEd community!
Your PR has entered our reviewing queue. Please wait until a peer-reviewer pings you for the revisions to be made.
Meanwhile, we suggest you to go through the published articles or approved PRs to see how the other authors have formatted their articles to avoid any potential closure of PRs.
Thanks.

@Adespscientist
Can you please link this PR to an issue?

@Adespscientist
Can you please link this PR to an issue?

Thank you.
I have linked this PR to an issue.

Plagiarism check done ✅

@Adespscientist Did you forget to upload your author bio?

@Adespscientist Did you forget to upload your author bio?

I have updated the author bio sir.
Thank you

@Adespscientist I will be closing this PR. It has a lot of grammatical errors. Go through the few suggestions I've made to help you understand where you're going wrong. Also, you can leverage grammarly premium to help correct your grammar. Finally, I really recommend you take the tech writing course provided by Google: https://developers.google.com/tech-writing
Let me know when do so that we can reopen this PR. As it is, the article doesn't match our publishing level.
cc: @section-engineering-education/content-moderator-team

Thank you.. I will work on it asap
On Wed, Feb 9, 2022, 9:19 AM Willies Ogola @.***> wrote:

Closed #6155
https://github.com/section-engineering-education/engineering-education/pull/6155
.
—
Reply to this email directly, view it on GitHub
https://github.com/section-engineering-education/engineering-education/pull/6155#event-6032349076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4IMNSD4FBF2FP6BF2A36TU2IPP5ANCNFSM5MM3LWFA
.
You are receiving this because you were mentioned.Message ID:
<section-engineering-education/engineering-education/pull/6155/issue_event/6032349076
@github.com>

I have made changes to the PR. Thank you sir
On Wed, Feb 9, 2022, 9:32 AM Peter Adeshina @.***>
wrote:

Thank you.. I will work on it asap
On Wed, Feb 9, 2022, 9:19 AM Willies Ogola @.***>
wrote:

Closed #6155
https://github.com/section-engineering-education/engineering-education/pull/6155
.
—
Reply to this email directly, view it on GitHub
https://github.com/section-engineering-education/engineering-education/pull/6155#event-6032349076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4IMNSD4FBF2FP6BF2A36TU2IPP5ANCNFSM5MM3LWFA
.
You are receiving this because you were mentioned.Message ID:
<section-engineering-education/engineering-education/pull/6155/issue_event/6032349076
@github.com>

@hectorkambow, @WanjaMIKE, Please what is the update on my PR. Thankyou

Hello @WanjaMIKE , please what is the update on my PR.

jumping on this one

Just finishing up @hectorkambow

Just finishing up @hectorkambow

thank you for letting me know 🚀
I'll jump on another one.

There is this image new-scan.png. I do not see where it is cited @Adespscientist

@WanjaMIKE, I have deleted the image "new-scan".

Merged #6155 into master

@WanjaMIKE, @Bayler, @hectorkambow thank you for reviewing my PR


Distance culling

What problem does this solve or what need does it fill?
Currently the grass is not culled at a high distance.
I feel like it should be possible to select a radius around the player for culling.
Describe the solution you'd like
Has to researched how other projects implement distance culling
Describe alternatives you've considered
As we already allow users to load multiple chunks, they could also implement their own culling by setting grass which is far away to invisible

We could probably check how this is implemented in the far field of the 3d camera component


Migratable DMA regions

Original issue: https://charm.cs.illinois.edu/redmine/issues/107

Regions of memory attached to a migratable entity like chare array elements that can be used as the target of RDMA operations.

Original date: 2015-02-09 17:35:45

Needs CmiOnesided to happen first.


Validate that smartgraph attribute exists and is not changed

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/20354
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/1434
Previously this check was performed in the KeyGenerator and therefore only performed for inserts, but not for replace or update operations. Therefore replace or update operations could modify or even remove this attribute.
Now we use a separate validator to ensure that this cannot happen. In addition, this PR also changes the returned error code from ERROR_KEY_MUST_BE_PREFIXED_WITH_SMART_GRAPH_ATTRIBUTE to ERROR_NO_SMART_GRAPH_ATTRIBUTE if the attribute is not set.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[x] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.11: https://github.com/arangodb/arangodb/pull/20471
[x] Backport for 3.10: this PR

Related Information

[ ] Docs PR:
[x] Enterprise PR: https://github.com/arangodb/enterprise/pull/1434
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Important: before merging, please apply the suggestion for the CHANGELOG. Thanks!


[SharedCache] Cache type libraries

Type libraries are surprisingly expensive to look up via BinaryView. Caching them can speed up FindSymbolAtAddrAndApplyToAddr significantly.

View-specific state
The first commit refactors how view-specific state is stored to make it easier to work with. This was motivated by wanting to be able to clean up view-specific state when a view goes away, and some data races I noticed in how the existing view-specific state is accessed.
The existing view-specific state was stored in several global unordered maps. Many of these were accessed without locking, including viewSpecificMutexes, which is racy in the face of multiple threads. The view-specific state is never cleaned up and remains in place after the given view is gone.
View-specific state is now stored in a heap-allocated ViewSpecificState struct that is reference counted via std::shared_ptr. A static map holds a std::weak_ptr to each view-specific state, keyed by the session's file id. SharedCache retrieves or creates its view-specific state during its constructor.
Since ViewSpecificState is reference counted it will naturally be deallocated when the last SharedCache instance that references it goes away. Its corresponding entry will remain in the static map, though since it only holds a std::weak_ptr rather than any state it will not use much memory. The next time view-specific state is retrieved any expired entries will be removed from the map.

The caching
The second commit moves lookup of type libraries into a function and has it first consult a cache on the view-specific state. The cache stores both found type libraries and the absence of a type library (nullptr). The type library is only looked up on the view if it's not present in the cache.

This was inspired by investigation done by @WeiN76LQh and solves the same problem as their #6195.

Thanks for the PR! I'll look into getting this merged sometime over the next couple of weeks.


save metadata

can you provide an example in one of the VectorStore notebooks? this looks good in theory but I'm curious to see how the metadata works in practice & I think an example will help


Go Live [Dec 28]

Push to live

Learn Build status updates of commit 89d27f4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/sbs-gs-nodejs.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Update flow to 0.58, lint

0.58 supports giving you errors when you use typed unions in switches (aka our reducers)
I needed this as part of my code gen stuff
I just added the reset store action by hand to a bunch of reducers but those will go away next as i generate it
The last commit updates flow-typed which is mostly noisy and didn't reveal any new flow errors so the last commit can be ignored

@keybase/react-hackers this is ready

lemme evaluate when i get to it with the next code gen passing (currently in progress)


Revert "[Warhammer 4e Character Sheet] Banner rework & fixes"

Reverts Roll20/roll20-character-sheets#5830

Reverting changes as they impacted a different character sheet.


feat: Add Support for Dependency Graph

This starts the work for
https://github.com/safedep/vet/issues/107
https://github.com/safedep/vet/issues/80


Update packages, primarily gulp to 4.x

Other packages that are updated: hugo, yarn, webpack, react
Updating gulp to 4.0 required susbtantial changes to the gulpfile. The other changes to gulpfule.babel.js are there to ensure the sitemap contains the proper urls (instead of paths).

Thanks for this! I commented on an issue regarding hardcoding Netlify specific things. Beyond that, lgtm 👍


QnA Telemetry Support

Adds Telemetry support to QnAMaker
Shares same pattern as Luis and TelemetryMiddleware.

Enables setting properties during GetAnswersAsync
Enables deriving from class and adding properties

https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md#telemetry-qna-recognizer

Pull Request Test Coverage Report for Build 50798

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.2%) to 74.76%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.AI.QnA/QnAMaker.cs
8
96.57%

Totals

Change from base Build 50252:
0.2%

Covered Lines:
4046

Relevant Lines:
5412

💛  - Coveralls

@ryanlengel : Latest should have naming you requested.. Can you approve?


Endgame ideas (Mirrorpocalypse)

Similar to the grandmapacolypse in cookie clicker, RuponyKenshin suggested a "mirror pool pinkie" endgame, where pinkies start overtaking everything and potentially sapping the SPS counter. This could potentially be triggered by buying a "Mirror pool" upgrade, which doubles the value of all friendships or something similar.
This could only be implemented after the late game is better stabilized, but would be nice to have. Also may require more art.

This is a fantastic idea, especially if someone can make an animation of the fake pinkies exploding.

Another idea: a series of challenges from the show against major villains.  For one possible example, villains may cut friendships or create enemyships to replace them, which requires friendship maintenance.
Also, when you said mirroracolypse, I was all but certain you meant the Torrid Equestria (my name for the alt) disaster caused by Celestia from the comics which actually nearly destroyed all of Equestria.

Based on my earlier confusion, I think Pinkocalypse would make much more sense as a name for it.  It's not the mirror pool as much as it is the presence of portentious pronking pink ponies predicting perfectly posterior paucity of ponykind.

My current idea for implementing the Pinkiepocalypse is that, after purchasing the mirror pool upgrade, small desktop pinkies start appearing on the screen at a given rate (which could increase if you keep buying mirror-pool related upgrades). Each onscreen pinkie leeches the SPS counter by 1%, applied one after another (the first pinkie leeches 1% of 100% of the SPS counter, the second pinkie leaches 1% of the remaining 99% of the SPS counter, etc.) which prevents 100 pinkies from leeching 100% of the SPS counter. When clicked, a pinkie will explode and return to the mirror pool, yielding 101% of the smiles it leeched.
A second upgrade called "Fully Automatic Unicorn" summons a desktop Twilight Sparkle that walks around and shoots pinkies for you with her magic, sending them back to the mirror pool. This upgrade could also have multiple levels, so you can deal with increasing numbers of pinkies attempting to flood the screen.

(Pinkmenapocalypse kinda flows better...)  :pinkiecrazy:
On Wed, May 20, 2015 at 4:41 PM, Erik McClure<EMAIL_ADDRESS>wrote:

My current idea for implementing the Pinkiepocalypse is that, after
purchasing the mirror pool upgrade, small desktop pinkies start appearing
on the screen at a given rate (which could increase if you keep buying
mirror-pool related upgrades). Each onscreen pinkie leeches the SPS counter
by 1%, applied one after another (the first pinkie leeches 1% of 100% of
the SPS counter, the second pinkie leaches 1% of the remaining 99% of the
SPS counter, etc.) which prevents 100 pinkies from leeching 100% of the SPS
counter. When clicked, a pinkie will explode and return to the mirror pool,
yielding 101% of the smiles it leeched.
A second upgrade called "Fully Automatic Unicorn" summons a desktop
Twilight Sparkle that walks around and shoots pinkies for you with her
magic, sending them back to the mirror pool. This upgrade could also have
multiple levels, so you can deal with increasing numbers of pinkies
attempting to flood the screen.
--
Reply to this email directly or view it on GitHub
https://github.com/blackhole12/PonyClicker/issues/27#issuecomment-104031999
.

--
Trick Question

Suggestion: There is a 1% chance of all the pinkies being flash sentries instead.


Restructure Dispatcher into dispatcher module

I'm planning on a bigger PR to the dispatch module and I figured if I'd keep this change in a separate PR it would make the review easier.
bors r+


Suppress output when skipping file link or symlink

Removed repetitive "TODO Skipping file link"...  when encountering a file link or Symlink.
Q: Is there a situation where the user would need to know that the symlinks are being skipped? If so, should we document this behavior? or include a "Skipping all file and sym links" in the output when these links are detected in a layer?

Answering your question I believe we should inform the user that we skipped symlinks.
But to decrease the noise maybe it makes sense to do it only once.

Does the imgpkg user need this information to complete their workflow? What reasons would they need to know about symlinks?

For context, we spoke to João and we thought it may come up where a user has symlinks in their manifests in a bundle, but we felt like this was an unusual case. So we are deferring adding any output until it comes up that this is something users want.


Most unit tests look like smoke tests

More unit tests should be written that go beyond just checking if the code explodes.

fixed. Added more tests and left those that are visualization and file management codes.


cgreen: 1.4.1 -> 1.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cgreen-devs/cgreen/releases.
meta.description for cgreen is: "The Modern Unit Test and Mocking Framework for C and C++"
meta.homepage for cgreen is: "https://github.com/cgreen-devs/cgreen"
meta.changelog for cgreen is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.0 with grep in /nix/store/pcsi68i7lsfzcyy039mlh62cak1iv7ck-cgreen-1.6.0
found 1.6.0 in filename of file in /nix/store/pcsi68i7lsfzcyy039mlh62cak1iv7ck-cgreen-1.6.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
alan
cgreen

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pcsi68i7lsfzcyy039mlh62cak1iv7ck-cgreen-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cgreen https://github.com/r-ryantm/nixpkgs/archive/e16e9e91340f3e208d339cb87d595139c72c538f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pcsi68i7lsfzcyy039mlh62cak1iv7ck-cgreen-1.6.0
ls -la /nix/store/pcsi68i7lsfzcyy039mlh62cak1iv7ck-cgreen-1.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

alan
cgreen

Maintainer pings
cc @nichtsfrei for testing.

Result of nixpkgs-review pr 180630 run on x86_64-darwin 1

1 package built:

cgreen


refactor: remove display name

GH card ticket "link": #ADD LINK TO GITHUB TICKET OR ISSUE
Description
Removed displayName property. This is first part, second will be rework of metadata.

Just wondering how will the users recognize who is who? I doubt that they will recognize users by their ids.?

Just wondering how will the users recognize who is who? I doubt that they will recognize users by their ids.?

We will going to implement message metadata. This data will contain user identification, defined by lib consumer. I am going to work on this: https://github.com/torolocos/react-rtc/issues/47


fix for subgrid in case there is empty boundary data

…in the parent grid (or probably also when the subgrid lies completely in the interior)

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fd3587a) 72.00% compared to head (d49f4c1) 71.65%.

Files
Patch %
Lines

src/subgrid.jl
60.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   72.00%   71.65%   -0.35%
==========================================
  Files          26       26
  Lines        4118     4121       +3
==========================================
- Hits         2965     2953      -12
- Misses       1153     1168      +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Can you add a test for this ?

The new commit modifies an existing test which fails without the first commit in this PR.


Can't run project too

Where is the main class?
When I run, mvn spring-boot:run on the folder, it fails as there is no main class to run the project.
In an another way, how can I run the project after running the tests and succeded them all?

This project is setup to run as container deployed spring app. That means you'd need to change the pom type to a WAR and deploy to something like Tomcat.  You could however, add your own main class and setup the Spring context manually (similar to what Spring Boot does) or you could take most of the code and port it to a proper Spring Boot app if you want to run stand alone.


How to create a specific style for {{ }}

Markwon version: 3.0.1

Hey there! First, thanks for the lib. It's awesome.
I have this app where I also need to show underlined words. I'm using this pattern{{}} on iOS. I'm not sure if I didn't do a good job searching, but I couldn't figure out from the documentation if I actually can do that.
Thanks

Hello @danielCarlosCE !
Well, if you just need to underline words, HtmlPlugin can be used. Your text should be enclosed in  or  tags to be underlined. There is also a commonmark-java extension (ext-ins) that allows underlining with ++ delimiter characters:
// gradle: implementation 'com.atlassian.commonmark:commonmark-ext-ins:0.12.1'

final Markwon markwon = Markwon.builder(context)
        .usePlugin(new AbstractMarkwonPlugin() {
            @Override
            public void configureParser(@NonNull Parser.Builder builder) {
                // register extension
                builder.extensions(Collections.singletonList(InsExtension.create()));
            }

            @Override
            public void configureSpansFactory(@NonNull MarkwonSpansFactory.Builder builder) {
                // register span-factory
                builder.setFactory(Ins.class, new SpanFactory() {
                    @Override
                    public Object getSpans(@NonNull MarkwonConfiguration configuration, @NonNull RenderProps props) {
                        return new UnderlineSpan();
                    }
                });
            }
        })
        .build();

But if you wish to be consistent between platforms and use {{}} you will have to create own delimiter processor, it's pretty easy (you can look at ext-ins for a reference). Also, I'm just publishing a snapshot for the next 4.0.0 version that has SimpleExtPlugin that allows doing this:
final Markwon markwon = Markwon.builder(this)
        .usePlugin(SimpleExtPlugin.create(plugin -> plugin
                .addExtension(2, '{', '}', (configuration, props) -> new UnderlineSpan())))
        .build();

SimpleExtPlugin is published with the latest 4.0.0 release.


incorrect peer dependency warnings on yarn install

Description
Executing yarn install produces warnings.
Version
Please provide your Node.js, Yarn and relevant Airnode versions. Are you building from a branch, which commit?
Node.js: 18.14.2
Yarn: 1.22.19
Branch: master
Using an M1 chipset
Present Behaviour
➜  airnode-protocol git:(master) ✗ yarn install
yarn install v1.22.19
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-protocol ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-protocol ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-protocol ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-protocol ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter > ethereum-waffle > @ethereum-waffle/compiler ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter > ethereum-waffle > @ethereum-waffle/compiler ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter > ethereum-waffle > @ethereum-waffle/compiler ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter > ethereum-waffle > @ethereum-waffle/provider ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-b2f2cae4-dc21-4c18-b89b-85ec12468204 > @api3/airnode-adapter > ethereum-waffle > @ethereum-waffle/provider ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
Expected Behaviour
Expected no warnings
Steps to reproduce
yarn install

Thanks for reporting- we're aware and are in the process of upgrading a number of dependencies. I'm not aware of these warnings causing any issues, but if you encounter any please let us know.


Update module.manifest commons-lang version to match build.gradle

The build.gradle commons-lang version was recently updated, but the manifest was missed.
This results in an error during the build process.
This updates the versions to match so the license can be found.
Related change to build.gradle: 3402c18b25a34c7804784ad32997db523b5b36d6
Error message during gradle buildGhidra:
FAILURE: Build failed with an exception.

* Where:
Script '/home/gradle/ghidra/gradle/support/ip.gradle' line: 89

* What went wrong:
Execution failed for task ':Generic:ip'.
> No License specified for external library: lib/commons-lang3-3.9.jar in module /home/gradle/ghidra/Ghidra/Framework/Generic. Expression: map.containsKey(relativePath)

dUP OF #525


Implement Floyd-Steinberg Dithering

This PR implements the floyd-steinberg dithering algorithm for generating maps.
As part of that, it changes the format of the /mapcreate command: instead of
/mapcreate <link>
The command is now formatted
/mapcreate <mode> <link>
where mode is either none or dither.
Example:

(Floyd-Steinberg on the left, non-dithered on the right)

I've got another branch on my fork that's got a fix to Floyd-Steinberg, an Ordered Dithering mode, and multi-map generation (generating a wall of maps in a single command from a single image) -- I'll add the first two changes to this PR once I figure out how to seperate them from the multi-map implementation.

Very nice. To retain compatibility with the old command format, I might rename the existing mapcreate command to just "map", add a few more parameters, and add a new command with the old name that works the old way.
Also, to remove the commits regarding multi-map generation from the branch, you can use this: git revert <id of commit>


Don't rerun flakes when uploading results to BQ

Our master builds are the only ones that upload results and these are the ones that should let flaky tests fail to get a reliable estimate of how flaky tests are.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

FYI @dgquintas, our master builds will be a lot redder after this is merged.
Our master builds are rerunning flaky tests, but that doesn't seem right. With this change, we'll be able to better approximate flakiness % and ensure flaky tests are marked as flakes (which might make PR tests greener :)).

[trickle] No significant performance differences

Thanks for the heads up @matt-kwong . Bracing myself.

[microbenchmarks] No significant performance differences


Sharing code between iOS and Android using Bazel

I have a library with common code which uses android.util.Log:
java_library(
    name = "common",
    srcs = glob(["*.java"]),
)

And I have an j2objc rule for iOS which works just fine:
j2objc_library(
    name = "common_ios",
    deps = ["//common"],
    jre_deps = ["@bazel_j2objc//:android_util_lib"],
)

But when I use common in my Android project:
android_binary(
    name = "app",
    srcs = glob(["*.java"]),
    manifest = "//android:manifest",
    resource_files = ["//android:resources"],
    deps = ["//common"],
)

When I run bazel build //android:app, I get:
common/MyVeryOwnLogger.java:3: error: package android.util does not exist
import android.util.Log;

Which makes sense, as android.* libs should not be available in a java_library rule. Am I missing something? Is this not the recommended way to setup a project?
Thanks!

android.util.Log has been a part of the Android API for years, so if your android_binary rule is failing, it's likely missing a dependency for the library that defines that class. Perhaps you haven't defined an android_sdk_repository like this gist does?
If that isn't the issue, you'll need to ask on StackOverflow with the bazel tag, since it works with j2objc.

Thanks for replying, @tomball.
If I use android.util.Log in code input to the android_binary rule it works fine. The issue is that android.* packages aren't exposed to the java_library rule, even if it is depended on by an android_binary rule (as is the case).
But you're right, the question is more of a "how to setup j2objc in a bazel cross-platform project" so I did ask on SO, here.

Just a guess, but would changing the java_library to an android_library
help? I’d copy rather than change the current rule, since I doubt
j2objc_library accepts android_library dependencies.
On Thu, Jun 7, 2018 at 3:45 AM Vitor Pereira<EMAIL_ADDRESS>wrote:

Thanks for replying, @tomball https://github.com/tomball.
If I use android.util.Log in code input to the android_binary rule it
works fine. The issue is that android.* packages aren't exposed to the
java_library rule, even if it is depended on by an android_binary rule
(as is the case).
But you're right, the question is more of a "how to setup j2objc in a
bazel cross-platform project" so I did ask on SO, here
https://stackoverflow.com/questions/50741921/sharing-code-between-ios-and-android-using-bazel-and-j2objc
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/983#issuecomment-395425632, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC2kr2XwAyH1TxoBGN6aoGSgDQRHmR24ks5t6S6PgaJpZM4UdWdk
.

Yeah, that does seem to be the way to go. To make the type of the rule depend on which target is being built. It would be cool to have a bazel rule that handles this kind of use case (which I figure is the most common).
Thanks, Tom!


'NetMHCpan' object has no attribute '_check_hla_alleles'

/Users/tavi/drive/work/repos/cancer/checkpoint-trials/scripts/mhc_utils.py in df_to_saved_predictions(df, subdir, epitope_lengths, mutation_window_size, priority_effects_only, filter_pred, only_samples)
     55             predicted = predictor.predict(variant_collection=variant_collection,
     56                                           mhc_alleles=hla_alleles,
---> 57                                           raise_on_variant_effect_error=False)
     58             if filter_pred:
     59                 predicted = filter_predictions(predicted)

/Users/tavi/drive/work/repos/cancer/utopia/utopia/__init__.pyc in predict(variant_collection, hla_alleles, predictor_type, epitope_lengths, mutation_window_size, priority_effects_only, raise_on_error)

/Users/tavi/drive/work/repos/cancer/mhctools/mhctools/netmhc_pan.py in __init__(self, alleles, netmhc_command, epitope_lengths)
     20             command=netmhc_command,
     21             alleles=alleles,
---> 22             epitope_lengths=epitope_lengths)
     23
     24     def predict(

/Users/tavi/drive/work/repos/cancer/mhctools/mhctools/base_commandline_predictor.py in __init__(self, name, command, alleles, epitope_lengths, supported_allele_flag)
     39             alleles,
     40             epitope_lengths,
---> 41             valid_alleles=valid_alleles)
     42
     43     @staticmethod

/Users/tavi/drive/work/repos/cancer/mhctools/mhctools/base_predictor.py in __init__(self, alleles, epitope_lengths, valid_alleles)
     35         if isinstance(alleles, str):
     36             alleles = [alleles]
---> 37         self.alleles = self._check_hla_alleles(alleles, valid_alleles)
     38
     39         if isinstance(epitope_lengths, int):

AttributeError: 'NetMHCpan' object has no attribute '_check_hla_alleles'

@tavinathanson What version of mhctools is this with? The

Master / https://github.com/hammerlab/mhctools/tree/7b9ce18223940eb12ea4ffe14b9e417712aa0ae9

(I think; maybe I just did something silly. I'll double check in 10 minutes)

My bad. I think it was an older version!


fix bug

short high-level descr in the PR would be nice also in these cases. :-)

I have changed some types. TBH, we don't gain much from the bool alternative, because we don't pattern match on them. It is only an improvement for the reader of the type.
Similarly, while Offsets and Lengths should absolutely be non-negative, the C functions curiously accept Ints, so I have to convert them inline, which is ugly. I think there it's worth it, because no user should be able to read backwards from an offset pointer, or use negative lengths.
WDYT?


Documentation of sap.m.Panel::onBeforeRendering seems to be wrong

This method has a comment "Sets the accessibleRole property of the control" which also claims that the method takes a parameter, which it doesn't do (and which conflicts with the method definition in its superclass). I guess the JsDoc should be adjusted.

You're right, the documentation is wrong and the method is not meant to be public. The JSDoc is a left-over from the code before d6b5bad08cadee79a570aa7ac727a3e8587e16ae.

Hello @ErikBrendel ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards, Diana

Hello @ErikBrendel,
The documentation was fixed and will be included in the next release - 1.78
Best regards,
Martin


Standalone build of openexr on windows - (with already installed ilmbase)

Howdy. I am working on the conda packaging of openexr and ilmbase.
There are two separate packages for ilmbase and openexr.
ilmbase
We download the release tarball from the GitHub releases and
Unix:
./configure --prefix=${PREFIX} \
            --host="${HOST}" \
            --build="${BUILD}" \
            --enable-cxxstd=11

make -j ${CPU_COUNT}
make install

Windows:
mkdir build
cd build

cmake -DCMAKE_INSTALL_PREFIX=%LIBRARY_PREFIX% ^
      -DCMAKE_FIND_ROOT_PATH="%LIBRARY_PREFIX%" ^
      -DBUILD_ILMBASE_STATIC=ON ^
      -DOPENEXR_BUILD_SHARED=ON ^
      -DCMAKE_BUILD_TYPE=Release ^
      -G "NMake Makefiles" ..

nmake
nmake install

We do build the static libraries on windows because they appear to be required by openexr.
openexr
For linux, we download the release tarball from the github releases, and we do
#!/bin/bash
./configure --prefix=${PREFIX} \
            --host="${HOST}" \
            --build="${BUILD}" \
            --enable-cxxstd=11
 make -j ${CPU_COUNT}
make install

and it works beautifully.
On Windows, the release tarball does not appear to have all the necessary assets for a cmake build. Hence, we build from the tarball corresponding to the github tag. Then:
This works: but it vendors ilmbase instead of linking with the other package.
mkdir build
cd build

 cmake -G "NMake Makefiles" ^
      -DCMAKE_INSTALL_PREFIX:PATH=%LIBRARY_PREFIX% ^
      -DCMAKE_BUILD_TYPE:STRING=Release ^
      -DOPENEXR_NAMESPACE_VERSIONING:BOOL=OFF ^
      -DOPENEXR_BUILD_SHARED:BOOL=ON ^
      -DOPENEXR_BUILD_PYTHON_LIBS:BOOL=OFF ^
      ..
if errorlevel 1 exit 1
 nmake
if errorlevel 1 exit 1
 nmake install
if errorlevel 1 exit 1

This and other variations of it appear to fail.
mkdir build
cd build

 cmake -G "NMake Makefiles" ^
      -DCMAKE_INSTALL_PREFIX:PATH=%LIBRARY_PREFIX% ^
      -DCMAKE_BUILD_TYPE:STRING=Release ^
      -DOPENEXR_NAMESPACE_VERSIONING:BOOL=OFF ^
      -DOPENEXR_BUILD_SHARED:BOOL=ON ^
      -DOPENEXR_BUILD_ILMBASE:BOOL=OFF ^
      -DILMBASE_INCLUDE_DIR:PATH=%_LIBRARY_PREFIX%/include ^
      -DOPENEXR_BUILD_PYTHON_LIBS:BOOL=OFF ^
      ..
if errorlevel 1 exit 1
 nmake
if errorlevel 1 exit 1
 nmake install
if errorlevel 1 exit 1

There seems to be some issues with the cmake build that appears to assume that ilmbase is beeing built with openexr.
The generated makefile include things such as: IlmBase::IlmThread_static-NOTFOUND while the IlmBase::{library}_static targets were all properly generated - so there seems to be some issues.
If you know a solution to not build ilmbase and use the installed package, we would love to know! This would be very useful for people who use the conda package manager.

OK, it turns out that the entire cmake is very brittle and buggy.
One first issue related to this is a problem of visibility of imported libraries in FindIlmBase.cmake (missing GLOBAL), and the fact that the imported library is static:

IlmBase::${ILMBASE_LIB}_static

add_library(IlmBase::${ILMBASE_LIB}_static SHARED IMPORTED)

should be
add_library(IlmBase::${ILMBASE_LIB}_static STATIC IMPORTED GLOBAL)

Similarly

add_library(IlmBase::${ILMBASE_LIB} SHARED IMPORTED)

should be
add_library(IlmBase::${ILMBASE_LIB} SHARED IMPORTED GLOBAL)

*The second issue is that the IlmImf library is linking with both the static and the dynamic libraries for ilmbase on windows!

cmake has been fundamentally re-written to be using a "modern cmake" style of cmake file using config files, etc. please retest with current master, and or the pending release, and let us know if it still doesn't work (well, we know that finding zlib and boost::python if you want those bindings usually involves a bit of fiddling, but hopefully it works better).

cmake has been fundamentally re-written to be using a "modern cmake" style of cmake file using config files, etc. please retest with current master, and or the pending release, and let us know if it still doesn't work (well, we know that finding zlib and boost::python if you want those bindings usually involves a bit of fiddling, but hopefully it works better).

Great news! Thanks for the update.


remove viewer page div id

This removes the page div id from the viewer. The id, and parsing it for the page number, is replaced by the data-page-number attribute.
The mozilla-cental test that depended on the div.id has been updated to use data-page-number (checked-in for Target Milestone: Firefox 53, Bug 1331795).
This resolves #5897

@Snuffleupagus thanks! I've added the removal of the .id and addition of the data-page-number attribute for thumbnail divs.
I checked in the mozilla-central tests and did not find any reference to the thumbnails' ids (the two tests of the thumbnails use nth-child selectors: https://dxr.mozilla.org/mozilla-central/source/browser/extensions/pdfjs/test/browser_pdfjs_navigation.js#49,57), and the tests pass locally for me with the id removed.

Looks good. Could you squash the two commits into one commit (refer to https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for how to do this easily)?

/botio-linux preview

Thank you!

/botio-linux preview

Nice work!


Changed all tests 'context' task to better handle lines.

I made this change because new lines are different between operating systems. I've copied this task to a project of my own and encountered this problem, so now I discard the differences between new lines.
Changing to IO.readLines fixed my problem, maybe it can help others as well.

:(


spell check is not working for the api call as it throws an error to remove spell check from the service

here is the direct error which contradicts the information in this article:
{
"error": {
"code": "BadArgument",
"message": "The application xxxxxx-5e70-48dd-xxxxsxxxxx cannot be packaged for the STAGING slot due to having unsupported features. In order to be able to package the application, please do the following:Remove the spell checker publish setting and republish.\r\n"
}
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc19d2e0-5960-c165-083c-a9dcf9976c91
Version Independent ID: 58d32965-6909-2461-5158-aa66d904bf3c
Content: Docker containers - LUIS - Azure Cognitive Services
Content Source: articles/cognitive-services/LUIS/luis-container-howto.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @IEvangelist
Microsoft Alias: dapine

@xtianus79
Thanks for the feedback! We are currently investigating and will update you shortly.

@xtianus79 Hi, could you please send us an email with your Azure Subscription ID and URL of this thread to<EMAIL_ADDRESS>? We would like to investigate deeply. Thanks.

@xtianus79 Hi, we have not received your email. Please send us an email if you still face this issue. I am going to close this since it's not a document issue. Thank you.
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.

@YutongTie-MSFT I am pretty sure this persists but let me check

i am going to post this here and send the email. However the issues still persist and this is kind of issue for publication. meaning does bing spell check work on a container or not?

@YutongTie-MSFT can you reopen the thread until there is a resolution to the issue?

@IEvangelist Hi David, could you please help us check this issue?
@xtianus79 Thank you for your information, I will reopen it.

Spell check is not supported out of the box in containers

@cahann does that contradict the documentation which says this:
https://docs.microsoft.com/en-us/azure/cognitive-services/luis/luis-container-howto

Supported dependencies for latest container
The latest container, released at 2019 //Build, will support:

Bing spell check: requests to the query prediction endpoint with the &spellCheck=true&bing-spell-check-subscription-key={bingKey} query string parameters. Use the Bing Spell Check v7 tutorial to learn more. If this feature is used, the container sends the utterance to your Bing Spell Check V7 resource.
New prebuilt domains: these enterprise-focused domains include entities, example utterances, and patterns. Extend these domains for your own use.

I'm going to give it a go now and I'll report back my findings.

This is unfortunately not supported and there was a mistake in the docs. #please-close

@IEvangelist this is a major deal here.  Where would be the best place to illustrate a concern about the feature that our team was planning on using may now not be possible?  The need is this, if we have a luis container that has luis cognitive services you're saying using a spellcheck key for the request api is not possible?

@IEvangelist this is a major deal here. Where would be the best place to illustrate a concern about the feature that our team was planning on using may now not be possible? The need is this, if we have a luis container that has luis cognitive services you're saying using a spellcheck key for the request api is not possible?

I'm working with the team to determine what might have happened, I'm not certain what to say right now. I'll report back as soon as I know more.

Apology for the confusion but in both cases LUIS container will be calling external service (aka bing spell check) for spell correct which is a step the can easily happen as preprocessing step before calling LUIS.

Hi @xtianus79,
We are working to get the container updated, and we will hopefully have this fixed in the next release of the container -- in a week or two.

@IEvangelist awesome!!! When you say, "Get the container updated," what do you mean exactly?  Does this mean the repository the container can pull the Luis instance from?  So this would be an updated docker Luis pull?
Also, where can we follow the release of these features and addons?
Lastly, what does this mean in the sense of how the bing service will work from the container.  Meaning, when this update is made will I be able to make a query to the luis / qna services that will have the bing spell check key parameter work for the Luis query?

@cahann Are you saying the bing spell check service won't be in the same cognitive service as the Luis container? This would be very counterproductive to the on-prem solution we trying to achieve. I would like to have clarity on this as much as possible.  In the next update for the container what does that mean exactly.
In general there are vital parts and pieces that when you make the heart and brains on-premise but no other vital services that correlate with it makes the entire solution more difficult to pursue.
Is it possible to have an internal discussion that illustrates this point?  If you make Luis containerizable you have other parts that must be in association with that paradigm.  The spell check is certainly one of those pieces.

@IEvangelist awesome!!! When you say, "Get the container updated," what do you mean exactly? Does this mean the repository the container can pull the Luis instance from? So this would be an updated docker Luis pull?
Also, where can we follow the release of these features and addons?
Lastly, what does this mean in the sense of how the bing service will work from the container. Meaning, when this update is made will I be able to make a query to the luis / qna services that will have the bing spell check key parameter work for the Luis query?

Hi @xtianus79,
The container is periodically updated, and it is not currently announced. The updates are usually minor and typically never include breaking changes. We're working on providing more clarity into this process. I'll try to post here when the container is updated with the fix.

@cahann Are you saying the bing spell check service won't be in the same cognitive service container as the Luis container? This would be very counterproductive to the on-prem solution we trying to achieve. I would like to have clarity on this as much as possible. In the next update for the container what does that mean exactly.
In general there are vital parts and pieces that when you make the heart and brains on-premise but no other vital services that correlate with it makes the entire solution more difficult to pursue.
Is it possible to have an internal discussion that illustrates this point? If you make Luis containerizable you have other parts that must be in association with that paradigm. The spell check is certainly one of those pieces.

Unfortunately, we depend on bing spell check so getting it to run on containers is out of out scope. We are exploring other spell check options but no ETA yet

@cahann thank you


Update registry binary to version 2.2.0.

Signed-off-by: Richard Scothern<EMAIL_ADDRESS>

LGTM


Remove the skip on currently passing Time specs

A couple of small changes:

It looks like localtime and gmtime are imaginary specs I had skipped :thinking:
The other specs have started working due to some updates in spinoso-time (specificaly wday off by one etc)

New output of running just time specs:
Time#asctime: N
Time#ceil: NNNNNNN
Time#ctime: N
Time#day: NNN
Time#dst?: N
Time#floor: NNNNN
Time#friday?:  NN
Time#month: NNN
Time#round: NNNNN
Time#saturday?: NN
Time#sec: .
Time#strftime:
Time#strftime with %L:
Time#strftime with %N:
Time#strftime with %z:
Time#subsec: NSNNSN
Time#sunday?: NN
Time#thursday?: NN
Time#to_a: N
Time#to_f: .
Time#to_i: ..
Time#to_r: SN
Time#to_s: NNNS
Time#tuesday?: NN
Time#tv_nsec: .
Time#tv_sec: ..
Time#tv_usec: .
Time#wday: .
Time#wednesday?: NN
Time#yday: .N
Time#year: NNN

Passed 6, skipped 5, not implemented 77, failed 0 specs.

Heads up, the A-core label is for changes to traits in artichoke-core. A-ruby-core is for changes to spinoso crates and other API bits for stuff in Ruby Core. A similar label A-ruby-stdlib is for the same changes in the standard library (like SecureRandom).

oops sorry for merging. I forgot that we prefer to let PR authors merge their own PRs after approval.


update from upstream

chore(deps): update github/codeql-action action to v3.23.1
chore(deps): update actions/cache action to v4

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updating/work-with this template for Azd Devcontainer feature.

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

We are updating this template to support new features in Azd Devcontainer.
For the Azd Devcontainer feature: We will add  the following code in devcontainer.json file.
"ghcr.io/azure/azure-dev/azd:latest": {}

And remove the relevant code for installing azd in Dockerfile under .devcontainer folder.
RUN curl -fsSL https://aka.ms/install-azd.sh | bash \

@rajeshkamal5050 , @paulyuk for notification.

I agree with this change.  It will be more reliable on each platform.

Fixed by #10 !  thank you for feedback and contribution here.


Update Plan Addon - throw exception

Example from https://dev.recurly.com/docs/update-an-add-on
var plan = Plans.Get("gold");
var addon = plan.GetAddOn("ipaddresses");
addon.UnitAmountInCents["USD"] = 200;
addon.Update();
throws exception beaceuse PlanCode is null, and there is no public method or property that set PlanCode (only internal constructor)

@zjazd This appears to be a bug. I have a longer term fix in mind but for now I have this PR that should fix the problem:
https://github.com/recurly/recurly-client-net/pull/141

Closed with https://github.com/recurly/recurly-client-net/pull/141


[BUG] Imported images has permissions issues

Describe the bug
Once a pot image is imported there is a subtle difference in permissions. A non root user inside the jail has no permission to read the file system. This cause serious issues in system like nomad, that can only use imported images.
To Reproduce
Steps to reproduce the behavior:

Create the pot with nginx in it
Create a snapshot and export the image
Import the image
Run this command in the two pot su -m www -c ls
In the imported image you have a permission denied

Additional context
Tested on CURRENT. It seems it started on FreeBSD 13.1, but not confirmed.
Still have to check potential zfs attributes differences between the two datasets

Couldn't this be a side effect of #218 ?
Originally I wanted to change /opt/pot to be root-readonly, but then we reduced that to /opt/pot/jail/m (so non-root users could read pots/configs).
So now probably /m has 600 which causes issues for non-root users inside the pot. (I didn't test, but it sounds logical to me).

I think if we want to achieve all of these goals (all of which I find reasonable):

Make read-only access work for non-root user on the jailhost
Protect jailed file-system from unprivileged users on the jailhost
Keep reasonable file access permissions of the jailed root

We probably need a different file system structure.
Status quo (path/permissions):
/opt/pot/jails/<jailname> 0644
/opt/pot/jails/<jailname>/conf 0644
/opt/pot/jails/<jailname>/m 0600

Alternative 1 - move /root deeper in /m:
/opt/pot/jails/<jailname> 0644
/opt/pot/jails/<jailname>/conf 0644
/opt/pot/jails/<jailname>/m 0600
/opt/pot/jails/<jailname>/m/r 0644

Pro: Not much change, solves all problems
Contra: Path gets longer
Alternative 2 - split jails and configs:
/opt/pot/jails 0600
/opt/pot/jails/<jailname> 0644
/opt/pot/jails/<jailname>/m 0644
/opt/pot/confs 0644
/opt/pot/confs/<jailname> 0644

Pro: Keeps jail root file system structure unaltered
Contra: ZFS filesystem structure gets complicated, lits of change, upgrade path unclear, image generation unclear
This might still be a good idea, but only as part of reworking images (the way they work right no, a lot of config settings are stored which are actually not necessarily what the consumer of the images wants).
Alternative 3 - do something weird with nullfs mounts and/or symlinks
Pro: Might look smart
Contra: Brittle, weird
@pizzamig Do you have additional ideas?
All things considered, Alternative 1 might be the cleanest option (but still causes pain with images/upgrade paths).
Another alternative would be to go back to allow all users to read all pots (so even nobody on the jailhost can read all files in pots) - or leave securing /opt/pot up to the user (I do like being able to run "pot list" as an unprivileged user, but I prefer to have my pots be more secure in terms of file permissions).
The status quo is bad.

Another pragmatic approach would be to introduce a group "pot" and make /opt/pot readable by that group (so users who should be able to read it could be invite to the group)

Or, even more pragmatically, simply make /opt/pot 640 owned by root:wheel and assume users who use pot read-only commands might get invited into group wheel anyway.

So, I verified that the permission to the mountpoint is causing the issue.
Fun fact is that everything after the root mountpoint is denied by any non-root user inside a jail.
The easy fix, that I'm going to commit soon-ish, is to comment out the _fix_pot_mountpoint_permissions until we agree on a way to move forward.
A 750 permission on /opt/pot with a pot group seems the way to go, imho.
It's clean and compatible with other groups permission in FreeBSD (i.e. video)


Add command line option -ld-preload

As suggested in https://github.com/mull-project/mull/pull/745#issuecomment-694489990
This adds a new CLI option -ld-preload for providing preloaded dynamic libraries. The primary use case is to override libraries for test binaries which fail when recompiled, in particular those using C++ thread_local variables.
Forked off from #745 to make reviewing easier.

Travis's failure is fixed here #753, merging this one despite the red build.


[SPARK-30942] Fix the warning for requiring cores to be limiting resources

…urce

What changes were proposed in this pull request?

fix the warning for limiting resources when we don't know the number of executor cores. The issue is that there are places in the Spark code that use cores/task cpus to calculate slots and until the entire Stage level scheduling feature is in, we have to rely on the cores being the limiting resource.
Change the check to only warn when custom resources are specified.
Why are the changes needed?

fix the check and warn when we should
Does this PR introduce any user-facing change?

A warning is printed
How was this patch tested?

manually tested spark-shell with standalone mode, yarn, local mode.

@HyukjinKwon  @dongjoon-hyun

Thank you, @tgravescs !

Test build #118885 has started for PR 27686 at commit 88789ef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23634/
Test PASSed.

error has nothing to do with this patch.  @dongjoon-hyun  how do I rerun the github action checks?

When you click Details button, you can see rerun button,  @tgravescs . At this time, I clicked~

Test build #118885 has finished for PR 27686 at commit 88789ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118885/
Test PASSed.

@tgravescs, I think we conventionally say who merged it and which branch it was merged to, even when it's obvious :-). Seems merged to master by you.


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit c883d6f:
:clock10: Pending: waiting for processors (35 builds ahead of you)
:warning: Docs Build is busy, currently there are 35 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit c883d6f:
:clock10: Full build: the average full build time is 7 min(s) 9 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit c883d6f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding support for STM32F107

This PR is largely based on @torkeldanielsson's work here and the related upstream forks.
Currently, this still depends on @torkeldanielsson's stm32f1xx-hal patch which I've rebased and fixed a couple of compiler errors here. Specifically, the new ip-f107.rs example uses the rcc.cfgr.freeze_explicit method, though admittedly I'm not familiar enough with how stm32 clocks work to know why this is required. @torkeldanielsson maybe you could share your thoughts on this?
As mentioned, a new ip-f107.rs example has been added that is a copy of
the existing ip.rs example. It is currently working nicely locally, my
aliexpress dev board with a DP83848 connected via messy jumper wires
responds to pings in ~0.5ms. Ideally, the two ip examples would be
consolidated and each of the device-specific parts should be feature
gated.
Also, note that the memory.x has been modified for the STM32f107 as
the existing seemed to be written specifically for an STM32F4 device.
I've also altered the target in .cargo/config. Not sure what the best
approach is for setting this. Perhaps in the readme we should just
ensure that users explicilty specify their --target when building
examples?

I created the rcc.cfgr.freeze_explicit because I needed to set more clocks than the regular freeze did, and the calculations for doing it the way freeze does looked really complex. In the ST Cube IDE there is a configurator that optimizes to arrive at clocks, and for my use case I wanted to use both I2S and Ethernet, so it ran for a while. The way freeze works, it would require to run those same calculations and output the result. I think it seemed more sane to not have that be the only clock config option, so that's the reasoning for the freeze_explicit - just let me set all the clocks the way I know I want them set up...

Thanks for the PR.
I don't think we need rcc.cfgr.freeze_explicit, we pretty much only care for the hclk and the F1 HAL already has a method to choose it.
Also, w.r.t rprintln, I don't think we should use it, since it will force the users to use rtt-target and init rprint before using this implementation. However, we do need logging, but I would like to use the log crate with some macros to add/remove it with a feature at compile time (like smoltcp and rubble), but this should be work for another PR.

@mitchmindtree does this work if you use the regular freeze function?

I don't think we need rcc.cfgr.freeze_explicit, we pretty much only care for the hclk and the F1 HAL already has a method to choose it.

I can't seem to select a value for the hclk that satisfies the freeze method. Each combinantion I've tried appears to hang indefinitely before freeze returns or hits one of the unreachable!() branches.
Here are the resulting clocks determined with @torkeldanielsson's freeze_explicit method that appears to work:
16:10:01.308     hclk: 50000000
16:10:01.308     pclk1: 25000000
16:10:01.308     pclk2: 50000000
16:10:01.308     pclk1_tim: 50000000
16:10:01.308     pclk2_tim: 50000000
16:10:01.308     sysclk: 50000000
16:10:01.308     adcclk: 12500000
16:10:01.308     usbclk_valid: true

When attempting to use freeze on stm32f1xx-hal 0.6.1 with just the hclk set to 50.mhz() like so:
    let clocks = rcc.cfgr.hclk(50.mhz()).freeze(&mut flash.acr);

I get a panic:
16:18:47.866 panicked at 'internal error: entered unreachable code', /home/mindtree/.cargo/registry/src/github.com-1ecc6299db9ec823/stm32f1xx-hal-0.6.1/src/rcc.rs:241:22

I.e. this line which appears to indicate that the sysclk is less than the hclk. This make sense as the default value appears to be the HSI clock value 8_000_000 defined here.
If I also set the sysclk to 50 mhz like so:
    let clocks = rcc.cfgr.sysclk(50.mhz()).hclk(50.mhz()).freeze(&mut flash.acr);

I appear to hit the same panic branch. This seems to imply that the sysclk gets constrained to something much lower as a result of the PLL multiplier calculations above which are a little over my head at the moment - perhaps something is going awry here? Specifying the pclk clocks don't appear to help, but they don't appear to be checked until later on in the function anyway.
Fwiw, I also tried making the changes you suggested here (without the bit-banding) but this doesn't appear to have had any affect on this clock freezing process at least.

Also, w.r.t rprintln, I don't think we should use it

Ah of course, my mistake, I had added it for debugging (I'm yet to try setting up semihosting at all) and I totally forgot to remove it!
Just a heads up - I'm a little busy to dig deeper into this clock stuff myself at the moment, however if either of you have something you'd like me to try I'll do so and report back next time I get the chance!

When attempting to use freeze on stm32f1xx-hal 0.6.1 with just the hclk set to 50.mhz() like so:

You won't be able to use 50MHz only with HSI, for connectivity line devices you can only go up to 36MHz with HSI. It's also good to check if you can achieve such clocks with the divisors and multipliers you have on the cfg.
The connectivity line devices also have a PLL2 and PLL3 clock, but it doesn't seem to be supported by the HAL, but I don't think we need it for ethernet.
What external crystal do you have ? If it's 8MHz this should work:
let clocks = rcc.cfgr.use_hse(8.mhz()).sysclk(72.mhz()).hclk(72.mhz()).freeze(&mut flash.acr);

Thanks for the advice!
I'm using a little aliexpress dev board for the STM32F107, it appears to have an 8MHz crystal on board.
When running this line it gets a bit further but panics at a pclk1 assertion:
18:48:07.809 panicked at 'assertion failed: pclk1 <= 36_000_000', /home/mindtree/.cargo/registry/src/github.com-1ecc6299db9ec823/stm32f1xx-hal-0.6.1/src/rcc.rs:277:9

After setting pclk1 to 36.mhz(), we appear to get through the clock configuration successfully!
That said, once we enter the poll loop, the device does not appear to respond to pings as it does when using freeze_explicit. I can see that the ETH interrupt gets called once per second if I print inside the callback, however ping shows 100% packet loss and I can't see any activity from the device on wireshark. Any ideas on why this might be the case?

That said, once we enter the poll loop, the device does not appear to respond to pings as it does when using freeze_explicit. I can see that the ETH interrupt gets called once per second if I print inside the callback, however ping shows 100% packet loss and I can't see any activity from the device on wireshark. Any ideas on why this might be the case?

Not sure, actually, if you were using the same config as the one in the ip-f107 example it shouldn't even work because that config is for a 25MHz external crystal, with a 8MHz one you would end up with a 16MHz hclk, which isn't even enough for using ethernet.
I would also double check your pin configuration with the one given by the manual at page 969, it seems that some of them don't match. One more thing, are you still using the branch from the HAL for these new tests ?

it shouldn't even work because that config is for a 25MHz external crystal, with a 8MHz one you would end up with a 16MHz hclk, which isn't even enough for using ethernet.

Interesting. Just to clarify, not only does it respond to pings (with this copy-pasted freeze_explicit config), I've actually got the ethernet bootloader working with it and the round-trip through my dodgy jumper wires is pretty consistently around ~0.5ms.
Just to clarify w.r.t. the external crystal, I'm referring to the 8MHz external crystal I can see mounted on this dev board near the stm32f107RC. The DP83848 PHY that I'm using has its own 50MHz crystal. Does this perhaps provide any clarity?

I would also double check your pin configuration with the one given by the manual at page 969, it seems that some of them don't match

Thanks for pointing this out. I originally had them configured as they are in this table, though for a reason I cannot remember now decided I needed some of the floating inputs to be open-drain, and someone mentioned you can read from Output<OpenDrain> so I tried that and it appeared to work so I went with it. After switching them back to the pin configurations described in this table, it appears to work just as well with freeze_explicit, however still no luck having the device respond to pings when using freeze.

One more thing, are you still using the branch from the HAL for these new tests ?

I have been switching back to the latest crates.io version of stm32f1xx-hal each time I test the freeze method.

@mitchmindtree , I've an STM32F107 connected to a LAN8710A PHY. Is there any update I can try?

Is there any update I can try?

I can't speak to the LAN8710A specifically, however we're currently using this for an artwork and all seems to be working fine, though we have another patch on top of this that adds support for multiple PHYs (see my "stm32f1-support-multi-phys" branch) as we're using an Ethernet switch IC rather than a single-port PHY chip.
FWIW we're also using a custom branch of stm32f1xx-hal (see my "morph-patches" branch), however I believe some of those patches have since been merged into master, and I don't remember off the top of my head if any of those were necessary to get our Ethernet working properly.
I'd be happy to see someone finish this PR by addressing thales' comments, otherwise I'm planning to re-visit all my PRs and branches and attempt to land them after we have finished installation mid-Jan.

I'd be happy to see someone finish this PR by addressing thales' comments, otherwise I'm planning to re-visit all my PRs and branches and attempt to land them after we have finished installation mid-Jan.

I'm not in hurry but I'd like to have it before Jan. I'll give it a try.
Thanks!

@mitchmindtree I created pull request into your fork which updates smoltcp crate version and ip-f107 example. Case in example shows situation where Ethernet Physical Layer Transceiver (DP8384I) is clocked from STM32F107 MCO pin. I used it in my project and everything is working well.


Repository issue templates not working

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
There are two templates in .github for bugs. This stops github from showing the template. Only 'feature request' shows.
Describe the solution you'd like
Ability to open anything other than a feature request
Describe alternatives you've considered
Putting bug reports into the feature request template
Additional context
why is this field mandatory?

Thanks for raising the issue. It is now resolved.


bugfixes

seed was incorrectly declaired(fails on new gcc version)
sum should be floating point, otherwise values may be not normalized

I'm having problems with commit b8fd452 when I use the library after a make install. I will revert the merge since most of the commits are unnecessary now. Send a PR only with the change in 0a81baf if you want to. Thanks anyway.


What is the schedule for 10.0.1549.125?

Hi,
what is the schedule for 10.0.1549.125, since it's already in PREPROD?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: efdfc5ac-26fd-e9ff-5d10-995275049b70
Version Independent ID: efdfc5ac-26fd-e9ff-5d10-995275049b70
Content: Release schedule for proactive quality updates - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/fin-ops/get-started/quality-updates-schedule.md
Service: dynamics-365-cross-app
GitHub Login: @rashmansur
Microsoft Alias: rashmim

Bug 835115 has been logged to address this issue.

@Pawel-Kolosza, thank you for your feedback. This article has been updated.


Add NotepadNext at v0.5

Description of changes
Add NotepadNext at v0.5
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Can I do something more to get this merged?

Thanks for your help and feedback - I've updated the PR and changed to the latest version :)

https://github.com/dail8859/NotepadNext/issues/135#issuecomment-1121765043
Maybe @jtojnar or someone else can help me answering Maintainers question about Flatpack-Package provided, and a more comprehensive explanation about our request to make external dependencies possible as for now there are no desires to change it.

Some people prefer native packages over flatpak for various reasons (simplicity of native packaging, (especially space) overhead of Flatpak, current inability to install software declaratively on Flatpak, trivial local patching…).
But if CMake port is planned, it makes sense to wait for it since it is much easier to achieve unbundling – CMake’s find_package function is pretty good.

@jojnar Top :) Thanks for helping out - are we ready to merge this until a new release is out? I will remove the current fixes then 👍🏻

@jojnar Top :) Thanks for helping out - are we ready to merge this until a new release is out? I will remove the current fixes then 👍🏻

@jtojnar sorry, wrong mention :)

Broken on aarch64, consider marking broken or explictly marking supported platforms: https://hydra.nixos.org/build/177847891/nixlog/2

Broken on aarch64, consider marking broken or explictly marking supported platforms: https://hydra.nixos.org/build/177847891/nixlog/2

https://github.com/NixOS/nixpkgs/pull/174062/files - done 👍🏻


Allow disabling colored shapes

Currently if colors and shapes are both enabled some of the shape hats will also have colors. This allows additional tokens to have hats but results in longer selectors (i.e. "take blue bolt bat"). Additionally it is harder to determine the color of some shapes than others. For example the bolt shape has far less area than the default circle. Therefore I suggest adding a setting to disable colored shapes so that when colors and shapes are both enabled only one or the other will be used at time.

The approach  Iwas thinking was to add a maxPenalty setting.
By default, colours and shapes each have a penalty of 1, and any style combination adds penalties of constituents.  So, for example blue has a penalty of 1, and fox has a penalty of 1.  Then we have the following penalties for the following style combinations:

"air" has a penalty of 0
"blue air" has a penalty of 1
"fox air" has a penalty of 1
"blue fox air" has a penalty of 2

Notice that these penalties correspond to the number of syllables need to be said (ignoring "air", which must always be said)
If you don't want coloured shapes, you can set your maxPenalty to something between 1 and 2.  This approach provides more flexibility, because you could use it to disable some specific shape / colour combinations by giving some colours / shapes penalties slightly higher than 1
Does this approach make sense to you?

One concern I have with this approach is that it ties extra logic/meaning to values that already have their own meaning. So if I'm changing the penalty of certain colors/shapes I have to also consider how that interacts with the penalties of my shapes as compared to my max penalty. For example if my current penalties are:

red: 1
blue: 1
yellow: 2
fox: 1
bolt: 2

and I wish to have all colors or shapes, but no colored shapes, while keeping the same relative penalties (yellow has twice the penalty of other colors, bolt twice the penalty of fox), how would I achieve that? I'm not sure of the significance of the relative magnitude of values of the penalties (i.e. setting yellow to 2 vs 3, or 2 vs 1.1) so this may be a non issue.

It is fair that we might be mixing concerns a bit here.  I was mainly hoping to avoid a cross-product of settings to be able to disable any specific pair.  So if you really just want to disable all coloured shapes, without being able to control specific pairs, then one setting to disable coloured shapes is probably fine
Fwiw in your case if we went with max penalty, I'd probably set your 2's to 1.5's, and then set a max penalty of 2.  For ranking, it just adds the penalties of the constituent words (eg your "blue bolt" would become 3), then just sorts, so all that matters is relative rank

It sounds like one setting to disable colored shapes would do the job for what I want (assuming the default circle doesn't count as a 'shape'). That said if the only thing that matters is relative rank then I'm not opposed to your idea either. I'd be interested in trying to make this update myself but I would need some help. Where in the code does it determine which shape and color to use for a certain token?

This is the area you'll want to look at https://github.com/cursorless-dev/cursorless-vscode/blob/16dc10e28096edb0ede3faf7962d3f48a7e6e85c/src/core/Decorations.ts#L202-L220


Scout's Distillation ignoring intervening blocks should be properly documented

As is, it states that it finds "the entity I'm looking at". This is not necessarily true, as it instead finds the entity you're looking towards

To add to this, Archer's distillation should mention ignoring blocks without hitboxes, such as pressure plates or grass.


Document Oauth2 authorization flow for native and web clients

Either Google analytics-data  or AUTHENTICATION.md
Should contain an example of how to authorize this library using Oauth2 for installed console applications as well as Web applications.
Currently i can only find examples for service account authorization.  This will not help applications which are trying to extract data from Google analytics on behalf of their users.
These authorization forms are documented in Google apis php client.  Why not here?
I managed to get this hacky working by combining the Google Apis Php client library auth with the Google analytics data bata api.    There has to be a better way.
  use Google\Analytics\Data\V1beta\BetaAnalyticsDataClient;

  // Installed / native / desktop Client credetinals.
  $credentials =  getenv('GOOGLE_APPLICATION_CREDENTIALS');

  $myfile = file_get_contents($credentials, "r") ;

  $clientObj = json_decode($myfile);

  $service = new BetaAnalyticsDataClient( [
      'credentials' => Google\ApiCore\CredentialsWrapper::build( [
          'scopes'  => [
              'https://www.googleapis.com/auth/analytics',
              'openid',
              'https://www.googleapis.com/auth/analytics.readonly',
          ],
          'keyFile' => [
              'type'          => 'authorized_user',
              'client_id'     => $clientObj->installed->client_id,
              'client_secret' => $clientObj->installed->client_secret,
              'refresh_token' => $tokenResponse["refresh_token"]
          ],
      ] ),
  ] );

  $response = $service->runReport([
      'property' => 'properties/[YOUR_PROPERTY_ID]'
  ]);

  foreach ($response->getRows() as $row) {
      foreach ($row->getDimensionValues() as $dimensionValue) {
          print 'Dimension Value: ' . $dimensionValue->getValue() . PHP_EOL;
      }
  }

Hey @LindaLawton !
So, you're using two different client libraries in your provided example. Google\Client (which is part of google-api-php-client) is a different client library entirely than BetaAnalyticsDataClient (which is part of THIS repo). So you can remove the getClient function and anything referencing Google\Client.
You're correct that we do not outline web applications for THIS repo, because most Cloud APIs do not authenticate with End User credentials. Some other APIs (such as Drive and YouTube) do, and the Analytics Data API does have some endpoints which require user authentication (see the Analytics Data Authentication Guide).

When your application needs access to user data, it asks Google for a particular scope of access. Google displays a consent screen to the user, asking them to authorize your application to request some of their data.

Here is a quick example of how you could accomplish this. I am not an expert in the "Analytics Data" API, so I do not think user credentials are needed for this call. However, this at least can help you accomplish this if you need to.

Using the Cloud Console, create your oauth2 credentials by clicking "Create Credentials" > "OAuth Client ID" and select "Desktop App" as the application type
Save your credentials to oauth2-installed-credentials.json
Save the following file to test.php, and then run the app with php -S localhost:8080 and visit localhost:8080 in your browser:

<?php

require 'vendor/autoload.php';

use Google\Analytics\Data\V1beta\BetaAnalyticsDataClient;
use Google\Auth\CredentialsLoader;
use Google\Auth\OAuth2;

// Start the session (for storing access tokens and things)
if (!headers_sent()) {
    session_start();
}

// add "?logout" to the URL to remove a token from the session
if (isset($_REQUEST['logout'])) {
    unset($_SESSION['upload_token']);
}

/************************************************
 * The redirect URI is to the current page, e.g:
 * http://localhost:8080/test.php
 ************************************************/

$oauth2InstalledCredentials = '/path/to/oauth2-installed-credentials.json';
$jsonCreds = json_decode(file_get_contents($oauth2InstalledCredentials), true);
$redirectUri = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['PHP_SELF'];
$authorizationUri = 'https://accounts.google.com/o/oauth2/v2/auth';
$tokenCredentialUri = CredentialsLoader::TOKEN_CREDENTIAL_URI;

$oauth2 = new OAuth2([
    'redirectUri' => $redirectUri,
    'scope' => BetaAnalyticsDataClient::$serviceScopes,
    'clientId' => $jsonCreds['installed']['client_id'],
    'clientSecret' => $jsonCreds['installed']['client_secret'],
    'authorizationUri' => $authorizationUri,
    'tokenCredentialUri' => $tokenCredentialUri,
]);

/************************************************
 * If we have a code back from the OAuth 2.0 flow,
 * we need to exchange that with the oauth2 token
 * API. We store the resultant access token
 * bundle in the session, and redirect to ourself.
 ************************************************/
if (isset($_GET['code'])) {
    $oauth2->setCode($_GET['code']);
    $token = $oauth2->fetchAuthToken();

    // store in the session also
    $_SESSION['upload_token'] = $token;

    // redirect back to the example
    header('Location: ' . filter_var($redirectUri, FILTER_SANITIZE_URL));
}

// set the access token as part of the client
if (!empty($_SESSION['upload_token'])) {
    $oauth2->updateToken($_SESSION['upload_token']);
} else {
    $authUrl = $oauth2->buildFullAuthorizationUri();
}

if ($_SERVER['REQUEST_METHOD'] == 'POST' && $oauth2->getAccessToken()) {
    $service = new BetaAnalyticsDataClient([
        'credentials' => $oauth2,
    ]);
    $response = $service->runReport([
        'property' => 'properties/[YOUR_PROPERTY_ID]'
    ]);
}
?>

<?php if (isset($authUrl)) : ?>

    <a class='login' href='<?= $authUrl ?>'>Connect Me!

<?php elseif ($_SERVER['REQUEST_METHOD'] == 'POST') : ?>

Your call was successful!

    <?php foreach ($response->getRows() as $row): ?>
        <?php foreach ($row->getDimensionValues() as $dimensionValue): ?>

Dimension Value: <?= $dimensionValue->getValue() ?>

        <?php endforeach ?>
    <?php endforeach ?>

<?php else : ?>
  <form method="POST">
    <input type="submit" value="Click here to call the Analytics Data API" />
  </form>
<?php endif ?>

@bshaffer  you realize that you are using installed app credentials with a web app?
clientId' => $jsonCreds['installed']['client_id'],

Your going to have issues setting the redirect uri if you want to host that.  Installed apps cant configure the redirect uri in google developer console. its defaulted to <IP_ADDRESS> and cant be configured.
@isildrum Thats asome thanks!

@bshaffer  you realize that you are using installed app credentials with a web app code?

My code is meant to be an example app running locally. For a web application you're correct, you'd want to create web application credentials. The issue with creating sample code there is web apps require HTTPS, which is why the provided example uses installed credentials


DTS: ADC: STM32407x: adc2 and adc3 do not contain required fields resolutions and sampling-times

Describe the bug
I am using STM32F407x MCU. I switched to zephyr v3.4.0 and tried to build my project. Compiling failed because of DTS problems with ADC2 and ADC3, which are defined in zephyr/dts/arm/st/f4/stm32f405.dtsi, missing some required fields: resolutions and sampling-times. The error message looks like this:
devicetree error: 'resolutions' is marked as required in 'properties:' in /home/user/zephyrproject/zephyr/dts/bindings/adc/st,stm32-adc.yaml, but does not appear in <Node /soc/adc@40012200 in '/home/user/zephyrproject/zephyr/misc/empty_file.c'>

...

devicetree error: 'sampling-times' is marked as required in 'properties:' in /home/user/zephyrproject/zephyr/dts/bindings/adc/st,stm32-adc.yaml, but does not appear in <Node /soc/adc@40012200 in '/home/user/zephyrproject/zephyr/misc/empty_file.c'>

By adding these parameters in .dtsi file the build is successful.
To Reproduce
Steps to reproduce the behavior:

rm -r build
west build

Expected behavior
The project should build successfully without manually editing zephyr's files.
Environment (please complete the following information):

OS: Fedora 38
Toolchain: Zephyr SDK v0.16.1
Commit SHA or Version used: v3.4.0

Thanks for pointing it out. Seems I forgot this one. Fixed in #60253


implement random polymers based on fractions

Currently the linear string sequence only takes integer monomer numbers per block. But there should be a way to generate a random sequence from fractions. Question is: Should we make a separate grapher tool or still implement this as interpretation of the string. I feel the separate tool would be the clearer option. Should be perhaps offload all the graphing work into a sperate tool and only read json files?

This can be done with the gen_seq tool in combination with gen_itp


Exception when using with Spec

Just thought i'd give Sayid a whirl as it really looks promising, I to want to stop 'sprinkling'.
Configured everything and got this little monster:

kixi.datastore.schema-creator/schema-validator  schema_creator.clj:   18
clojure.spec/valid?                 spec.clj:  744
clojure.spec/map-spec-impl/reify/conform*                 spec.clj:  782
clojure.spec/conform                 spec.clj:  150
clojure.spec/or-spec-impl/reify/conform*                 spec.clj: 1041
clojure.spec/or-spec-impl/fn                 spec.clj: 1006
clojure.spec/map-spec-impl/reify/conform*                 spec.clj:  782
clojure.spec/conform                 spec.clj:  150
clojure.spec/regex-spec-impl/reify/conform*                 spec.clj: 1633
clojure.spec/re-conform                 spec.clj: 1589
clojure.spec/deriv                 spec.clj: 1463 (repeats 3 times)
clojure.spec/deriv                 spec.clj: 1456
clojure.spec/dt                 spec.clj:  727
clojure.spec/dt                 spec.clj:  731
clojure.spec/conform                 spec.clj:  150
clojure.spec/multi-spec-impl/reify/conform*                 spec.clj:  900
clojure.spec/multi-spec-impl/predx                 spec.clj:  886
java.lang.ClassCastException: com.billpiel.sayid.trace$shallow_tracer$tracing_wrapper__22432 cannot be cast to clojure.lang.MultiFn`

Looks like spec doesn't like some of the fn wrapping that's going on. Hopefully will get the chance to dig into this a bit tomorrow, but thought I'd see if this was a common problem.

@mantree  First report of this. I just started using spec today, so maybe I'll run into too.
Were you using spec's instrumentation feature when this happened? Any other details?
thanks

It's coming from here:
https://github.com/MastodonC/kixi.datastore/blob/feature/implement-query/src/kixi/datastore/schema_creator.clj#L18
Which is a direct spec/valid? call. To be sure I disabled my instrumentation and it through the same exception.
The stacktrace says that it's having trouble in a multi-spec. It's expecting to see a multi-method and exploding when the wrapped function isn't one:

predx #(let [^clojure.lang.MultiFn mm @mmvar]
(c/and (.getMethod mm ((.dispatchFn mm) %))
(mm %)))

So, I reckon what's happening is Sayid is wrapping the multi-method defined here:
https://github.com/MastodonC/kixi.datastore/blob/feature/implement-query/src/kixi/datastore/schemastore.clj#L38
in something that isn't a clojure.lang.MultiFn.
I'm having a bit of trouble selectively tracing namespaces at the minute, I'll have a go tomorrow and see if it works better.

@mantree Agreed. s/multi-spec is telling spec to expect a multi-method.
Even before this, I was hoping to improve sayid's handling of multi-methods somehow. Maybe it would be better if it wrapped the defmethod fns but not defmulti fn. Not sure if that's right, or even how to do that, at the moment.
For now, as you said, avoid tracing that ns or function with sayid.
Any suggestions or input appreciated.

Ideally, the dispatch function would get wrapped, a nice source of bugs those! Could be a bit tricky to ensure a new MultiFn wrapper works nicely. Could try mutating the current one, it's marked as final though, so that could cause some interesting problems! Maybe best to just ignore them for abit.
Getting the defmethod's wrapped seems like a must though. Does that not currently work?

@mantree Sayid wraps the resulting MultFn, which covers the calls to the defmethods, but the defmethods aren't wrapped individually -- if that make sense.

After looking over MultiFn.java and playing around a bit, I'm optimistic these improvements are doable.

After a bit of selective tracing I just had a very nice experience with Sayid pointing me to where the real problem was, rather than where I thought it was. No sprinkling required!
Looks like you've made a good start on the multi-fn stuff. I wonder if treating the defmethod's separately would give a better experience, allowing people to decern between the implementations sounds like it would be beneficial. Not seen what it currently looks like yet though :)

@mantree Glad it worked out eventually.
Having sayid wrap the var produced by defmulti plays nicely with the rest of the sayid code, and I believe the approach I started the other night could support a good user experience EXCEPT in the case where a user re-evals a defmethod that attaches to a defmulti that is currently traced. In that scenario, the defmethod would apply its function to sayid's traced version of the multifn, instead of the original multifn. That new defmethod function would never get called because sayid would be looking at the original multifn.
I don't know if that makes sense, but I wanted leave some note about the status of this for you (and anyone else who might be interested).
I've been focused on rewriting the inner trace feature, which seems to be nearing completion. After that, I plan to come back and redo multifn tracing.

Yeah that makes sense.
That is a bit of a tricky one that. Could be pretty frustrating if that
started happening. Maybe it could route method adds through to the
underlying multi fn, proxy object style.
Look forward to seeing what you come up with and a premptive happy new year!
On Sat, 31 Dec 2016, 01:10 Bill Piel<EMAIL_ADDRESS>wrote:

@mantree https://github.com/mantree Glad it worked out eventually.
Having sayid wrap the var produced by defmulti plays nicely with the rest
of the sayid code, and I believe the approach I started the other night
could support a good user experience EXCEPT in the case where a user
re-evals a defmethod that attaches to a defmulti that is currently
traced. In that scenario, the defmethod would apply its function to
sayid's traced version of the multifn, instead of the original multifn.
That new defmethod function would never get called because sayid would be
looking at the original multifn.
I don't know if that makes sense, but I wanted leave some note about the
status of this for you (and anyone else who might be interested).
I've been focused on rewriting the inner trace feature, which seems to be
nearing completion. After that, I plan to come back and redo multifn
tracing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bpiel/sayid/issues/7#issuecomment-269841097, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZw2k8-Sg_Ea-1_zm6uGHm9kLcTkPl2ks5rNauVgaJpZM4LXHzs
.

I just released new multimethod tracing in 0.0.11. Let me know what happens if you try it out.
The "proxy object style" idea had occurred to me, but I was scared of it because it meant new, unknown depths of java interop. But, it turned out to be the simpler solution.

I believe this is fixed -- please re-open if anyone finds otherwise.

Thanks bill, I've been distracted by infrastructure woes. When I get back to code I'll be trying Sayid again for sure!

@mantree Sorry about the woes. Good luck!


cant conect it doesnt seems to register my wallet

What version of Wallet are you using?
beta4
What is happening?
cant conect always going to install
steps to reproduce
it doesnt recognize it and giving me instsall all the time
How it should behave?
it should conect
What os are you seeing the problem on?
Windows Desktop
What browser?
None
What is your browser version?
chrome

Thanks for the issue, closings this one in favor of https://github.com/FuelLabs/fuels-wallet/issues/1019