JSONOutputArchive Loses a closing brace

Howdy! I'm trying to use JSONOutputArchive to serialize a simple 4 element struct. If my code goes:
    std::stringstream buffer;
     cereal::JSONOutputArchive arch(buffer);
     arch(resp);
     std::cout << "Sending " << buffer.str() << std::endl;

Then the JSON will be serialized with a missing closing brace. However if I do this:
      std::stringstream buffer;
      {
	cereal::JSONOutputArchive arch(buffer);
	arch(resp);
      }
      std::cout << "Sending " << buffer.str() << std::endl;

Then it will be serialized correctly. In the second case the only difference I can see is I'm forcing the archive destructor to run prior to printing my buffer, so I suspect a flush isn't happening until then.

See the 'important' tag under Archive Basics here: https://uscilab.github.io/cereal/serialization_archives.html
Basically, the archive doesn't know you are done archiving until it hits its destructor, so it doesn't have the ability to put the closing brace on until you destruct the type.  It is part of the design of the archive types.

Got it, thanks! I missed that bit!


Enchance conditional attributes

Enhancement for HideIf, ShowIf, DisableIf and EnableIf, which allows you to use more than one condition in the above attributes.

Just curious why this wasn't merged in? Is there any other existing way of achieving multiple conditions on ShowIf/HideIf etc, with AND/OR logic? If not, is this planned? Was attempting to move a project from Odin to TriInspector, but lack of this ability is currently looking like a blocker sadly..


Weekly sync 2022-1024

Three failed unit test have been skipped.

svd_op_test
qr_op_test
conv_layout_normalization_test

I also changed some parts on our develop-upstream based on recent merged PRs.

tensorflow/compiler/xla/tests/llvm_irgen_test_base.cc I commented an uncessary CompileAndVerifyIr(), it shall remove.
gpu_kernel_tiling PRs based on our merged PRs

https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/2848


pop-gtk-theme: 2020-06-30 -> 2021-08-19

Motivation for this change
It's been almost a year since the last update and upstream has made several recent updates that make the theme possibly more compatible with the latest versions of Gnome (40+) / GTK (2/3/4).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 148239 run on x86_64-linux 1

1 package built:

pop-gtk-theme


KAFKA-4183 Corrected Kafka Connect's JSON Converter to properly convert from null to logical values

The JsonConverter class has LogicalTypeConverter implementations for Date, Time, Timestamp, and Decimal, but these implementations fail when the input literal value (deserialized from the message) is null.
Test cases were added to check for these cases, and these failed before the LogicalTypeConverter implementations were fixed to consider whether the schema has a default value or is optional, similarly to how the JsonToConnectTypeConverter implementations do this. Once the fixes were made, the new tests pass.

Thanks @rhauch. I cherry-picked into 0.10.0 (along with @shikhar's fixes).

Closing this since it was already merged.


Add more log entries to insight collector

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Student Dashboard for Mission Front end codeMetric

Context
This PR adds the code metrics dashboard on the workspace side-content under the Autograder section.
it adds the length, number of token and runtime of the code in Editor area.
Implementation
added a CodeMetricCard for displaying code metrics.
using js scripts to calculate the number of token and runtime
Before:

After:

Pull Request Test Coverage Report for Build 4538

23 of 41 (56.1%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 36.834%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/workspace/side-content/Autograder.tsx
3
4
75.0%

src/components/workspace/side-content/CodeMetricCard.tsx
8
10
80.0%

src/assets/scripts/evalCode.js
0
4
0.0%

src/assets/scripts/measureRuntime.js
0
4
0.0%

src/assets/scripts/countToken.js
12
19
63.16%

Totals

Change from base Build 4529:
0.09%

Covered Lines:
2829

Relevant Lines:
6867

💛  - Coveralls

I didn't know I was supposed to click the run segment of the code metric to measure the runtime, instead I kept clicking the run button. A bit more clarity might help.

Is there any update with regards to this PR?
It seems that the last time this PR was reviewed was 12 days ago.


Font looks weird

minecraft default font rendered weird

it's one of the quirks of using an unintended gui scale /shrug


Breadcrumbs closes on double click?

Issue Type: Bug
I've never used them, so it might be expected?:
.eslintrc.json
{
	"root": true,
	"parserOptions": {
		"ecmaVersion": 2018,
		"sourceType": "module",
		"project": "./tsconfig.json"
	}
}

Only closes for document symbols, directory tree work as expected.
VS Code version: Code - Insiders 1.56.0-insider (ce791d27dc9889a392f4d29abefe9c53eb0b5129, 2021-04-16T11:25:09.662Z)
OS version: Windows_NT x64 10.0.18363

It should to be create configuration with current default set for enable users personalize.

/needs-more-info

It looks like the tree is emitting a selection/open event when the twisty is double-clicked


Bug Report: The show score screen button doesn't change text when pressed

OS: Windows 10 Pro x64
Version: KE 1.5.3
To reproduce: press the button, no change, exit the entire settings menu and come back, and it is now changed
Pressing enter doesn't change the show score screen button's text to "no score screen" until you exit and re-enter the settings menu, but it does still change the setting

fixed 84c2b06c8bf3b77f4ac0e59078936bb65bc5f87e


Fix for "Not enough space"

In ctcdecode/src/binding.cpp change:
const char* end = str_i + strlen(labels)-1;
to
const char* end = str_i + strlen(labels);
I'd submit a patch, but I'm not 100% sure about the utf-8 stuff and how this is supposed to behave.

Forgot that:
int void utf8_to_utf8_char_vec
needs to be changed to:
void void utf8_to_utf8_char_vec
as there is no return. This causes a segfault.

Thank you, this seems to fix the issue for me!


Fix flake8 E402

And can you please upload new version to pypi?

Thanks WIll try to push new release by tomorrow


Convert Mixer to Abstract Data Type

Converted Mixer to an Abstract Data Type.
It contains data and non-virtual member functions
so calling it an "interface" is a misnomer.
Derived NullMixer from Mixer ADT
Updated Non-compiling usage of plain Mixer to
NullMixer when audio driver fails to load.
Added NullMixer header and implementation to project files.

Tagging Issue #164

Ahh, it seems we were working on this in parallel. I have my solution in PR #167.

@DanRStevens  Yeah that's why I brought up Issue #168 to help alleviate potentially overriding each others work.

Ack, in my confused busy state today, I forgot to post here earlier. I'd meant to do that before attempting some work using this branch's code.
I was looking at the changes here, and trying to decide what to do. There are two PRs, both basically doing the same thing, and I wanted a few parts of both.
As the biggest part I liked here was the split of the .h into .h and .cpp files, which is mostly the addition of the .cpp files, I thought it might be easiest to apply that addition over top of the other branch. This resulted in PR #174.


Highway ramps should be distinct from thru roads

This is around Dulles Airport outside of DC:
http://tangrams.github.io/eraser-map/#13/38.9585/-77.4284

Fixed the casing:

nice!
On Mon, Sep 28, 2015 at 12:14 PM, Geraldine Sarmiento <
<EMAIL_ADDRESS>wrote:

Fixed the casing:
[image: screen shot 2015-09-28 at 12 13 35 pm]
https://cloud.githubusercontent.com/assets/466585/10145846/6cf36676-65da-11e5-929e-1405629c9571.png
—
Reply to this email directly or view it on GitHub
https://github.com/tangrams/eraser-map/issues/21#issuecomment-143847533.


how to enable xla with estimator

cuda:9.0
tensorflow:1.12.0
i want to enable xla, it is my code:
session_config = tf.ConfigProto()
session_config.graph_options.optimizer_options.global_jit_level = tf.OptimizerOptions.ON_1
distribution_strategy = distribution_utils.get_distribution_strategy(flags_core.get_num_gpus(flags_obj), flags_obj.all_reduce_alg)
run_config = tf.estimator.RunConfig(
      train_distribute=distribution_strategy,
      session_config=session_config,
      save_checkpoints_secs=60*60*24)
classifier = tf.estimator.Estimator(
      model_fn=model_function, model_dir=flags_obj.model_dir, config=run_config,
      warm_start_from=warm_start_settings, params={
          'resnet_size': int(flags_obj.resnet_size),
          'data_format': flags_obj.data_format,
          'batch_size': flags_obj.batch_size,
          'resnet_version': int(flags_obj.resnet_version),
          'loss_scale': flags_core.get_loss_scale(flags_obj),
          'dtype': flags_core.get_tf_dtype(flags_obj),
          'fine_tune': flags_obj.fine_tune
      })
......
classifier.train(input_fn=lambda: input_fn_train(num_train_epochs),
                       hooks=train_hooks, max_steps=flags_obj.max_train_steps)

and get_distribution_strategy() is
def get_distribution_strategy(num_gpus,all_reduce_alg=None,turn_off_distribution_strategy=False):
  if num_gpus == 1:
      return tf.contrib.distribute.OneDeviceStrategy("device:GPU:0")
  else:  # num_gpus > 1 and not turn_off_distribution_strategy
      return tf.contrib.distribute.MirroredStrategy(num_gpus=num_gpus,
          cross_tower_ops=tf.contrib.distribute.AllReduceCrossTowerOps(
              all_reduce_alg, num_packs=2))

when i train by one gpu, and the distribute strategy is OneDeviceStrategy("device:GPU:0"), xla is ok,
but when i train by two gpus, and the distribute strategy is MirroredStrategy, xla has error:
 *** WARNING *** You are using ptxas 9.0.176, which is older than 9.2.88. ptxas 9.x before 9.2.88 is known to miscompile XLA code, leading to incorrect results or invalid-address errors.

You do not need to update to CUDA 9.2.88; cherry-picking the ptxas binary is sufficient.
I0130 10:55:37.183267<PHONE_NUMBER>77408 tf_logging.py:115] Running local_init_op.
I0130 10:55:37.853480<PHONE_NUMBER>77408 tf_logging.py:115] Done running local_init_op.
I0130 10:56:25.948692<PHONE_NUMBER>77408 tf_logging.py:115] Saving checkpoints for 20020 into /tmp/model.ckpt.
2019-01-30 10:57:17.807557: E tensorflow/stream_executor/cuda/cuda_dnn.cc:373] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2019-01-30 10:57:17.807765: E tensorflow/compiler/xla/service/gpu/cudnn_convolution_algorithm_picker.cc:338] Internal: All algorithms tried for convolution %custom-call = (f32[64,256,56,56]{3,2,1,0}, u8[0]{0}) custom-call(f32[64,64,56,56]{3,2,1,0} %reduce-window.13518.10568, f32[1,1,64,256]{1,0,2,3} %copy.56), window={size=1x1}, dim_labels=bf01_01io->bf01, custom_call_target="__cudnn$convForward", backend_config="{\"convResultScale\":1}" failed.  Falling back to default algorithm.

or
*** WARNING *** You are using ptxas 9.0.176, which is older than 9.2.88. ptxas 9.x before 9.2.88 is known to miscompile XLA code, leading to incorrect results or invalid-address errors.

You do not need to update to CUDA 9.2.88; cherry-picking the ptxas binary is sufficient.
I0130 11:05:42.691364<PHONE_NUMBER>17376 tf_logging.py:115] Running local_init_op.
I0130 11:05:43.474775<PHONE_NUMBER>17376 tf_logging.py:115] Done running local_init_op.
I0130 11:06:26.442031<PHONE_NUMBER>17376 tf_logging.py:115] Saving checkpoints for 20020 into /tmp/model.ckpt.
I0130 11:07:53.810114<PHONE_NUMBER>17376 tf_logging.py:115] cross_entropy = 2.8381975, learning_rate = 0.02560256, train_accuracy = 0.390625
I0130 11:07:53.812137<PHONE_NUMBER>17376 tf_logging.py:115] loss = 6.150483, step = 20020

E0130 11:09:08.093458<PHONE_NUMBER>17376 tf_logging.py:105] Model diverged with loss = NaN.

@jlebar Hi, can you explain why run benchmark is ok, it also has the warning, but has no error.

If literally anything about the GPU environment changes, then XLA may generate different PTX and trigger the bug, or the memory buffers in question may have different addresses and trigger the bug.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


fix: update certifi to 2022.12.07

:tada: This PR is included in version 4.9.1 :tada:
The release is available on:

v4.9.1
GitHub release

Your semantic-release bot :package::rocket:


[WIP] Implement numba.cross2d

As discussed in #4128, it is not possible to cover all the functionality of np.cross via overload since the implementation depends on both the dim (accessible in the typing scope) and shape (not accessible in the typing scope).
Hence we agreed to manage  the following two cases separately:

the 3D case: already implemented in the np.cross overload in #4128
the 2D case: covered in this PR.

As discussed in the gitter chat with @stuartarchibald, I will proceed to add the cross2d implementation to numba.targets.arraymath and make it available through numba.special.
I am writing the tests in numba.tests.test_np_functions.

@partmor thanks for this, what you describe sounds good and its relatively easy to move about as needed once implemented :) Thanks again!

Hi @stuartarchibald , I have a little problem. Just by doing in special.py:
from .targets.arraymath import cross2d

I get many circular-import-related errors. It seems like it's mainly because many (sub)modules like arraymath and arrayobj have absolute imports of the form from numba import ...  relying on the imports defined in numba/__init__.py.
One thing I thought is creating a wrapper in special.py of the form:
def cross2d(**args):
    from .targets.arraymath import cross2d as _cross2d
    return _cross2d(**args)

but since cross2d is expected to be njitted, the import would break the users' code (right?).
The only thing I can think of now, is either:

put cross2d elsewhere (I don't have a candidate location though)
try to replace the absolute from numba import ... imports in the affected modules with relative imports that point directly to the actual location of the function.

E.g.: in arraymath, replace
from numba import generated_jit

with
from ..decorators import generated_jit

and so on (there are a number of these that would require refactoring - probably this is out of scope for this PR..).
What do you think? Am I missing out on something?
Thanks!

RE: https://github.com/numba/numba/pull/4595#issuecomment-533867091, noted, thanks, I can reproduce. Whilst chatting out of band @sklam pointed out that PEP8 prefers absolute imports, perhaps because Python 3 has better circular import resolution ability.
To resolve this reasonably quickly, how about creating a numba.targets.array_math_ext module for array math extensions, and expose it from there? Do you think that'd work? I think this is quite cheap to try. Thanks.

RE: #4595 (comment), noted, thanks, I can reproduce. Whilst chatting out of band @sklam pointed out that PEP8 prefers absolute imports, perhaps because Python 3 has better circular import resolution ability.
To resolve this reasonably quickly, how about creating a numba.targets.array_math_ext module for array math extensions, and expose it from there? Do you think that'd work? I think this is quite cheap to try. Thanks.

@stuartarchibald  Aha! I didn't know it was actually a PEP8 recommendation. Thanks for the hint.

I have implemented a numba.targets.array_math_ext module that exposes the cross2d function.
I have updated the documentation to reference cross2d.
I have updated the exception message in the np.cross overload to hint the usage of cross2d in the case of interest.

Does this look reasonable?
Also, shall we leave cross2d accessible only via numba.targets.array_math_ext or shall I import it in targets/__init__.py for instance?
Thank you in advance.

Thanks for the above.
Perhaps wire it through a new numba.numpy_extensions.cross2d? @seibert IIRC you took at look at this first time round, how does that sound?

Thanks for the above.
Perhaps wire it through a new numba.numpy_extensions.cross2d? @seibert IIRC you took at look at this first time round, how does that sound?

Or in fact, just move the current numba.targets.array_math_ext to  numba.numpy_extensions.cross2d? I don't envisage there being a large number of these cases.

Thanks for the above.
Perhaps wire it through a new numba.numpy_extensions.cross2d? @seibert IIRC you took at look at this first time round, how does that sound?

Or in fact, perhaps just move the current numba.targets.array_math_ext to numba.numpy_extensions.cross2d? I don't envisage there being a large number of these cases.

Yep, this is a lot better also IMO. I've proceeded to do this and updated documentation/references.
@stuartarchibald  Do you think it will be worth adding a line with import .numpy_extensions to numba/__init__.py?
Do yo usee anything else missing?

https://github.com/numba/numba/pull/4641 is a conflict free version, will merge that if CI passes before conflicts are fixed here.


[Bug] Switch Widget Does not work

Description
The isSwitchedOnProperty of the SwitchWidget does not work
Steps to reproduce the behaviour:

Drag a switch
Drag a text box
Bind the text to Switch1.isSwitchedOn
Toggle the switch
There is no change to the text widget

Important Details

Version: [Cloud / Self-Hosted vx.x]
OS: [e.g.MacOSX]
Browser [e.g. chrome, safari]
Environment [production, release, deploy preview]

@vivekverma2312 @somangshu @yatinappsmith  how did an obvious case like this get missed for this widget? What does regression testing really mean for us today? How are there no automated test cases for obvious cases like these?

@Nikhil-Nandagopal Tested on both prod and release and it's working fine.
https://www.loom.com/share/9716661f5a824e68b48c9164e1176bd2

@vivekverma2312 I'm not able to repro now. Let me find the scenario and get back


pull request for e2e test at 01/24/2017 06:26:15

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: port ModelTheory.Definability

[x] depends on: #3196

This PR/issue depends on:

leanprover-community/mathlib4#3196
By Dependent Issues (🤖). Happy coding!

bors merge

This PR/issue depends on:

leanprover-community/mathlib4#3196
By Dependent Issues (🤖). Happy coding!


Fix custom classes parents in Tests

CustomParticipant and CustomThread models in tests extended wrong models. This wouldn't affect on tests but better to fix this misuse.

good find!


Module not found: Error: Package path ./dist is not exported from package

Hello ! Hope you're fine. I need some help on this issue I have when I try to use mui-tiptap :
Module not found: Error: Package path ./dist is not exported from package /home/philippe/stylotendu/node_modules/mui-tiptap (see exports field in /home/philippe/stylotendu/node_modules/mui-tiptap/package.json)
Here is a copy of my package.json :
{
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "@emotion/react": "^11.11.3",
    "@emotion/styled": "^11.11.0",
    "@mui/icons-material": "^5.15.1",
    "@mui/material": "^5.15.1",
    "@mui/x-data-grid": "^6.18.5",
    "@testing-library/jest-dom": "^5.17.0",
    "@testing-library/react": "^13.4.0",
    "@testing-library/user-event": "^13.5.0",
    "@tiptap/core": "^2.1.13",
    "@tiptap/extension-heading": "^2.1.13",
    "@tiptap/extension-image": "^2.1.13",
    "@tiptap/extension-table": "^2.1.13",
    "@tiptap/pm": "^2.1.13",
    "@tiptap/react": "^2.1.13",
    "@tiptap/starter-kit": "^2.1.13",
    "mui-tiptap": "^1.8.6",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-router": "^6.20.1",
    "react-router-dom": "^6.21.0",
    "react-scripts": "5.0.1",
    "web-vitals": "^2.1.4"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

Thank you!

Hello, thanks for sharing your package.json. Would you also be able to share the code where you are using/importing mui-tiptap (which components, what are the import paths, etc.)? Can you reproduce the issue from a CodeSandbox? I don't believe I've seen an error like this myself and haven't heard it reported before.

Closing this out since stale and no followup. Feel free to chime in with more details about how to reproduce this, if this needs to be reopened


Indexing latitude and longitude as geo_point

Hi,
Is it possible to index latitude and longitude (from a csv file) as geo_point such as defined here
https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-point.html ?
If you point me some high level instructions, I could try to modify the code.
Thanks.

Hey @alexlopespereira
from the docs I see that you can index geo points as "lat,lon" string as follows:
{
  "text": "Geo-point as a string",
  "location": "41.12,-71.34"
}

So basically you can do it natively with esl without any code change.


Adding INFO logs for when API server validations fail

@vaikas-google, @MHBauer and I met earlier today (3/14/2017) to investigate https://github.com/kubernetes-incubator/service-catalog/issues/541, and found the following:

The ups-broker was sending a catalog with UUIDs with upper-case letters in it
The API server disallows upper case letters (it uses NameIsDNS1035Label to validate UUIDs)
The API server received the POST for the new service class, and fails the validation
The API server sends the failure back to the core API machinery, which appears to send error details back to the client
The client’s Create function for service classes returns an error that doesn’t contain any descriptive detail

This PR is a stop-gap measure to increase the amount of descriptive error reporting we have. Ultimately, we’ll have to determine where the error detail is being lost (my money is on the generated client, fwiw) and fix it.
cc/ @vaikas-google @krancour @pmorie @MHBauer

Merged because @arschles is blocked on this for something urgent.

@arschles and I agreed to remove this commit once the underlying issue is addressed


Fixnum is now an Integer Ruby 2.4

#178186921
https://www.pivotaltracker.com/story/show/178186921

This one is sort of large.


Handle commands

How to run console commands from code like Artisan:call(...)?

@enniel do you ever solved it? Just including the command and running its handle method is limitating, 'cause you can't pass arguments. @thetutlage

const ace = require('@adonisjs/ace')

await ace.call('migration:run')

Does it work only with "default" ace commands? It tells me that my command "is not a registered command", but from terminal it works.

I'm having the same problem with @danilopolani "is not registered command"


Relationship arrows not displaying in IE11

In IE11 the link arrows between nodes do not display correctly. If you update the stylesheet in developer tools they appear but remain in place if you move a node.
Also it is possible to drag nodes out of the canvas onto any section of the page.

Hi Greg,
Just wondering if there's any progress/plans on this issue?
If the answer is "go fix it yourself" I would completely understand! haha
Steve

Hi, @StephenThomson . No updates, sorry. If you have time and are able to fix this, it would be much appreciated! I'm not sure when we'll be able to do it ourselves.

The lack of lines connecting the nodes is caused by a known issue for IE 10 and 11 relating to SVG paths not rendering when they have markers.
We have a fork of the code in which both the arrow heads and shafts are drawn using SVG paths, rather than using marker definitions. The only difference is that the whole arrows are the same colour, rather than the arrow heads being black and the arrow shafts being grey.
I can look to create a branch of the current codebase and submit a PR if this fix would be useful.

Hi @gleithall . We would welcome a PR! You'll need to sign the OASIS TC Open Repository Individual CLA before we can merge anything. Let us know if you have any concerns.
I'm not particularly worries about the different colors, but I'm not a UI expert :-)

@gtback I believe we signed one as an organisation for a previous contribution.
@gleithall I think you can fork into the CACI org, make your changes there then do a PR on behalf of CACI.

@StephenThomson you have a signed CLA on this page, but we need one from each person who is making commits that go into the repo. Thanks!

@gtback I have created PR #31 for this issue. I have also signed the CLA.

Thanks, @gleithall. I think there's some background work at OASIS to confirm the CLA, but after that your PR should be good to merge!

@gtback My CLA has now been processed, and appears on the page you referenced earlier.

Fixed by #31


Bug in documentation

I set up npm using sqlite as my db. When following the setup guide (https://nginxproxymanager.com/setup/)  one detail is missing from the config.json file, instead of
{
  "database": {
    "engine": "knex-native",
    "knex": {
      "client": "sqlite3",
      "connection": {
        "filename": "/data/database.sqlite"
      }
    }
  }
}

one should add the "useNullAsDefault" option for knex like this:
{
  "database": {
    "engine": "knex-native",
    "knex": {
      "client": "sqlite3",
      "connection": {
        "filename": "/data/database.sqlite"
      },
      "useNullAsDefault": true
    }
  }
}

Cheers!
Holger

On what environment did you encounter this issue? On most machines it should work like it does in the documentation.

Only for complete information in this ticket.
On my side it was Raspberry Pi4 8GB with the same issue


Added Split() methods for both pkgs with tests included

Added dataframe.DataFrame.Split() method
Added series.Series.Split() method
Added tests for series.Series.Split()
Added tests for dataframe.DataFrame.Split()

the Split() methods takes a percent (value between 0 and 1), calling Series.Split(0.5) would split the series in two equal parts (50%) the Series on which the func was called (let's call it S) will contain the first 50% and the returned Series S' would have the other 50%. by calling Series.Split(0.3) S would have the first 30% and S' the other 70%

I want to be a contributor :)

Thanks @svanharmelen for your review and opinion :+1:

Thank you very much for you contribution @Shixzie, and thank you too @svanharmelen for your review. Before getting into the actual review, I have to say that there are way too many things happening on this PR which make it very difficult to review:

Refactoring of errors
Adding extra nil checks on some instances
Adding a new time.Time type
Adding the DataFrame.Split() and Series.Split() methods

For future contributions I would ask you to keep each major change as a separate PR. Ideally you would branch dev for every feature and then you will target that specific branch to be merged back into dev. This is a good read: http://nvie.com/posts/a-successful-git-branching-model/
Also before performing any PR, make sure you have your code formatted with gofmt, you have test coverage for at least the happy path, pass golint and go vet linters, and check that your code follows the style of the existing codebase.
Now I'm gonna put here my thoughts about each of the changes.
Refactoring of errors
Although I feel that a better error trace would be interesting, as referenced in #7, I don't think that the way it was implemented here was ideal. First of all, I feel that the creation of a helper function for createErr feels a bit out of place, being that all it does is calling errors.Wrap. Before merging something like this, I feel it's better if we would discuss how this is to be done in the #7 thread.
Adding extra nil checks on some instances
In some cases this might be useful, like on the DataFrame.Set method, but I saw a number of times that you check both len(x) == 0 and x == nil. This is not necessary as @svanharmelen  pointed out, since len(x) will already return 0 on a nil slice.
Adding a new time.Time type
This is great, I also have been working on this, so I guess it's my bad for not marking the issue as assigned to me, but wasn't expecting any contributions. In any case, I'm going to share what I had so far, you can put it together with your code and we can review it on a separate PR: https://gist.github.com/kniren/f961e32a811b305b5442bae303f5d8b9
Regarding the time parsing when converting from string, this is a tricky matter, but I feel we should settle for a given format for automatic conversion (I favour const timeformat string = time.RFC3339) and encourage users to either use that or pass an existing time.Time.
Adding the DataFrame.Split() and Series.Split() methods
This is a good idea, although I'm not sure it's the right implementation for the Split method. Essentially for this use case (Splitting by percentage), you can just create a []int index with randomized elements and then make the splitting from there. When talking about splitting on #13, the expected behaviour is to split a DataFrame to N DataFrames by a number of factors. This is consistent with what a user from pandas or R would expect. In any case, I still don't know which should be the best behaviour for #13, so I encourage you to discuss the pros and cons on that issue thread before jumping to code. I do see the need and the benefit of having a percentage split on Gota but I'm just not sure this is the API that I would like to expose, furthermore we can continue the discussion on this matter.
With all that said, I would like to thank you once again for your contribution. I'm going to close this issue, but I encourage you to continue the discussion and to submit individual PRs for the appropriate topics after considering my feedback.


[backport] Fix beta distribution

Backport of #5382

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit f7644f205fa83f9c04580bead5fb93551f3744f6, target branch v5) succeeded!


Chained transitions may interrupt prior ones

Hi,
It seems that when transitions are chained together using transition.transition, a subsequent transition may interrupt the prior one.  This was unexpected to me, since I was expecting them to run sequentially.  (I was experimenting with staged animations and was observing that sometimes only the second part of the animation happened).
I've isolated this to a simple example:
<!DOCTYPE html>
<html>
    <body>
        <script src="https://d3js.org/d3.v4.min.js"></script>
        <script>

            var n = 300, radius = 5, spacing = 2;

            var width = (n * spacing + 2 * radius), height = 600;

            var svg = d3.select('body').append('svg')
                    .attr('width', width).attr('height', height);

            for (var i = 0; i < n; ++i)
                svg.append('circle');

            // create red circles at top:
            var circles = svg.selectAll('circle')
                    .style('opacity', 0.2)
                    .style('fill', 'red')
                    .attr('r', radius)
                    .attr('cx', function (d, i) {
                        return radius + i * spacing;
                    })
                    .attr('cy', radius);

            function getIndex(d, i) {
                return i;
            }

            function logInterrupt() {
                console.log('first transition interrupted!');
            }

            // transition circles to blue over varying durations, then move to bottom:
            circles.transition().duration(getIndex).style('fill', 'blue').on('interrupt', logInterrupt)
                    .transition().duration(2000).attr('cy', height - radius);

        </script>
    </body>
</html>

Also see here:  https://jsfiddle.net/onjtpp4y/2/
In chrome and firefox I see the first part of the row of circles remains red and I see multiple interrupted messages in the console.  Is that expected?

I can imagine why this happens, but would it make more sense to make chained transitions strictly sequential?
Regards,
Dan
p.s. thanks for awesome library

I think this qualifies as a bug, but it appears to be triggered only when the prior transition has an extremely short duration, such as zero. If you increase the duration (say the index plus 50ms), the interrupts go away.

Thanks very much for fast response.
Yep.  Fyi, in my actual app the delay on the first transition is a few
hundred ms, yet this issue occurred with a large number of svg elements.
(A user on a slower computer reported some data not displaying correctly).
On 22 Aug 2016 9:24 PM, "Mike Bostock"<EMAIL_ADDRESS>wrote:

I think this qualifies as a bug, but it appears to be triggered only when
the prior transition has an extremely short duration, such as zero. If you
increase the duration (say the index plus 50ms), the interrupts go away.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/d3/d3-transition/issues/54#issuecomment-241538331,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEl8jNXLv7RyBGdkNgKMkqptvYICVfAoks5qigWMgaJpZM4JqQNO
.

That’s plausible; if the browser stalls temporarily, it could cause a similar situation.
The problem here is the optimization in d3/d3#1576 (see also #16): the first tick is deferred to the end of the current frame, so the following transition starts before the preceding transition can end naturally, triggering the interrupt.

Fantastic - thanks very much!


docs(branding): add branding and favicon and logo

add branding in storybook
add svg collection
add favicon
add new logo in the storybook (mumble)
add an animated logo in the branding

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Auto reset of error segments on segment validation

Auto reset of error segments can be done whenever segment validation flow executes, which eliminates the need for manual resolution.
This feature is gated behind the controller config controller.segment.error.autoReset which is set to false by default.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (841eaf3).
Report is 1177 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (841eaf3). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (841eaf3)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14217       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update index.md

Test message for Friday Live Review

This test request is now closed. Have a good day!


chore(deps): update to esbuild 0.14.14, with patched dist

Description
Implement an idea from @antfu, using esbuild 0.14.14 and adding the commonjs require hack after bundling instead of before it.
Additional context
This allows us to continue using esbuild to bundle plugin-vue and plugin-react, but I think there are new bugs surfacing because of the new esbuild version in plugin-react
esbuild 0.14.4 introduced a breaking change.

here we moved from 0.13 to a fixed 0.14.3: #5861
@Niputi tried to update the plugins build process from esbuild to rollup, but CI is failing for a React test case #6329
@dominikg proposed to fix esbuild only for building the plugins, #6405 (so two esbuild version, but only during build)
Anthony proposed to use latest esbuild and manually add the cjs hack. This PR implements this approach for testing

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

I tested this more, and the patched dist looks good to me. The plugin is properly imported in cjs and esm contexts. The issue is also the same as when compiling with rollup.
The only failing test is playground/react-emotion, see https://github.com/vitejs/vite/runs/4950179776?check_suite_focus=true#step:10:273
[BABEL] /home/runner/work/vite/vite/node_modules/.pnpm/react-switch@6.0.0_react-dom<EMAIL_ADDRESS>.default is not a valid Plugin property

This issue is gone when using jsxRuntime: 'classic' for this playground. When using it, the issue is gone but there is another fail, but it isn't a regression: this playground fails in the same way when using 'classic' in main.
@aleclarson I think this is pointing to an issue on react-emotion side, and not in Vite or plugin-react. I don't understand why it doesn't surface with esbuild 0.14.3 though. Do you have some ideas here?

Updated the react-emotion to use jsxRuntime: 'classic' and skipped the test that is failing also in main for classic. CI is green with these changes.
We could move forward with this PR (or the rollup based one #6329), so we unblock the release of Vite 2.8. If we do so, we shouldn't release @vitejs/plugin-react until the react-emotion test is properly fixed.

I think I found the culprit

https://github.com/vitejs/vite/blob/30db2795bc1e737b12b15abc108a31b0866e51cf/packages/plugin-react/src/jsx-runtime/restore-jsx.ts#L60
This line.
Or this line: https://github.com/vitejs/vite/blob/30db2795bc1e737b12b15abc108a31b0866e51cf/packages/plugin-react/src/jsx-runtime/restore-jsx.ts#L60
Anyway, add a .default to the result of the async import would fix the issue.


Test deploy to netlify

Let try to have a test deploy to Netlify, so we can better test and check all the changes before moving to production

TL;DR:
We're not using Netlify to deploy this. We're going to Vercel. Check #33 PR
What happened here?
We are not going to use Netlify to deploy this repo, so I'm closing this issue.
Why?
Because netlify only allows Nuxt to be deployed in static mode, or in Client Render Only.
As the production deploy is Server Side Rendered, I don't want to have different settings in the preview or test deployments. So, netlify is not an option.
What do we do, so?
There's plenty of options, such as heroku or vercel, to name some. I've done a quick research, and I think vercel might be a cool option, since it has integrated nuxt settings. That means, that we can have (kind of) the same settings in the auto-deploys than in production deployments, so that's amazing.
How do we move to Vercel?
Easy. Check out the #33 PR. Everything is there.


Update TypeScript

One of my other PRs is failing in the build because the older version of TS we are using (5.1.6) is missing the states property from the ElementInternals WebAPI type (the states property and the its type CustomStateSet are sort of new but supported in all the major browsers). TypeScript 5.5+ has this property and type, so I started trying to update our TypeScript version. However I ran into some problems with deprecated TypeScript APIs used for the path transformation stuff in the build. I tried to fix it (based on some input from the TypeScript team!), but I definitely broke it. So I'm creating a draft PR as a starting point for getting TypeScript updated.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Reviewer - this PR has made changes to one or more package.json files.

Snapshot stored with reference name:
refs/pull/15826/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15826/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15826/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15826/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15826/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15826/merge#BCU1XR#0

Is ElementInternals support wide enough considering where the viewer might be used ?

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/testResults/webgpuplaywright/index.html

Wer usually fix these first by adding them manually to the mixins file and then removing them when not needed. Using an API that only exists in a certain typescript version will also force our users to use this version. Otherwise, type check will fail.
I have no problem with updating the version (after making sure everything works as existed), but we have to support older versions as well.

Is ElementInternals support wide enough considering where the viewer might be used ?

Yes I think it is ok.
ElementInternals is baseline 2023: https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals
CustomStateSet is baseline 2024: https://developer.mozilla.org/en-US/docs/Web/API/CustomStateSet
If they are missing in a browser, it will just mean annotation elements don't get a reduced opacity when not facing the camera.

Wer usually fix these first by adding them manually to the mixins file and then removing them when not needed. Using an API that only exists in a certain typescript version will also force our users to use this version. Otherwise, type check will fail. I have no problem with updating the version (after making sure everything works as existed), but we have to support older versions as well.

I remembered this from one of our previous conversations :) In this case, it is only used as an implementation detail, it is not surfaced through the API at all, so it doesn't show up in the d.ts files. I believe that means it cannot impact consumers of the package.

Reviewer - this PR has made changes to one or more package.json files.

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15826/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.


Underwater Mirror Rendering Issue

Mirrors do not render correctly underwater.
Mod version: 0.22
Fabric API version: 0.4.0 build 240

It seems that the position of the mirror is changed. Maybe water flushed it?

The third-person view mirror rendering issue fixed

I can't reproduce the issue you showed


Use CRA, add Redux and linters

In this PR, I did the following changes:

Created React App with CRA.
Added necessary libraries (redux, router, linters).
Setted linters.

Code  Approved 👍
Nothing to add to your work, please merge and go ahead!
Comments

No Linter error
The App ran as expected
Folder structure is clean and well structured

Required Change ♻

[ ] No change required for now

Optional suggestions
-[ ] No optional suggestion for now
Every comment with the [OPTIONAL] prefix won't stop the approval of the PR. However, I strongly recommend you to take them into account as they can make your code better, and addressing them will really improve your application
((I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application))
Cheers and happy coding! 👍 👍 👍
Feel free to leave any question or comment in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-review. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise

As described in the Code review limit policy you have a limited number of reviews per project (Check the exact number in your dashboard). If you think that this code review was not fair, you can request a second opinion using this form.


How to add Migrations?

I've added an 'Issuer' field (nullable string) to the Tenant entity, but when I try to add a migration an exception gets thrown "Invalid column name 'Issuer'", as it's trying to seed the TenantManagement database. Strange that that is happening, as the database should already been seeded. Maybe somewhere the wrong connectionstring is picked up?
This is the command I'm using from the "src\Host" folder:
dotnet ef migrations add TenantAddIssuer --project ..\Migrators\Migrators.MSSQL\ --context TenantManagementDbContext

this the the response
Build started...
Build succeeded.
[22:01:16 INF] Server Booting Up...
[22:01:16 INF] Hangfire: Current Storage Provider : mssql
[22:01:16 INF] For more Hangfire storage, visit https://www.hangfire.io/extensions.html
[22:01:17 INF] Current DB Provider : mssql
[22:01:17 ERR] Failed executing DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT [t].[Id], [t].[AdminEmail], [t].[ConnectionString], [t].[CreatedBy], [t].[CreatedOn], [t].[DeletedBy], [t].[DeletedOn], [t].[IsActive], [t].[Issuer], [t].[Key], [t].[LastModifiedBy], [t].[LastModifiedOn], [t].[Name], [t].[ValidUpto]
FROM [Tenants] AS [t]
[22:01:18 ERR] An exception occurred while iterating over the results of a query for context type 'DN.WebApi.Infrastructure.Persistence.Contexts.TenantManagementDbContext'.
Microsoft.Data.SqlClient.SqlException (0x80131904): Invalid column name 'Issuer'.
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
...

Maybe I'm doing something wrong? So how exactly are we supposed to add migrations? For both the TenantManagementDbContext as the ApplicationContext? And for all the different db providers?

foreach (var tenant in dbContext.Tenants.ToList())
        {
            services.SetupTenantDatabase(dbProvider, rootConnectionString, tenant);
        }

We have this code in DN.WebApi.Infrastructure.Multitenancy.Startup. Probably we have to put Lines 48-51 under a try catch.

foreach (var tenant in dbContext.Tenants.Select(x => new TenantDto
        {
            Name = x.Name,
            Key = x.Key,
            AdminEmail = x.AdminEmail,
            Id = x.Id,
            ConnectionString = x.ConnectionString,
            ValidUpto = x.ValidUpto,
            IsActive = x.IsActive
        }).ToList())
        {
            services.SetupTenantDatabase(dbProvider, rootConnectionString, tenant.Adapt<Tenant>());
        }

This is one possible solution, where you select just a known set of columns.

I think the real solution is to take the database initialization code out of the service configuration, and move it after app.build in program.cs.
I've already implemented it like this and all works fine... It's part of a bigger pr though (azure ad auth) which i'm still working on...

Ok, I got everything working now, will start a PR soon, but how do I add migrations for the other databases (MySql and ProgreSQL)? Do I need to install these? Some guidance is needed ;-)


Feat/implement contract call

Codecov Report

Merging #47 (74d1934) into v1 (9df3935) will decrease coverage by 0.69%.
The diff coverage is 95.10%.

@@            Coverage Diff             @@
##               v1      #47      +/-   ##
==========================================
- Coverage   96.33%   95.63%   -0.70%
==========================================
  Files          34       35       +1
  Lines         628      688      +60
==========================================
+ Hits          605      658      +53
- Misses         23       30       +7

Impacted Files
Coverage Δ

lib/src/common/logger/common_logger.dart
100.00% <ø> (ø)

lib/src/crypto/impl/derivator.dart
100.00% <ø> (ø)

.../src/crypto/impl/encrypted_secret_key_to_seed.dart
100.00% <ø> (ø)

...c/models/operation/impl/transaction_operation.dart
100.00% <ø> (ø)

...common/validators/simulation_result_validator.dart
90.00% <60.00%> (-10.00%)
:arrow_down:

.../operation/impl/operation_fees_setter_visitor.dart
91.30% <81.81%> (-8.70%)
:arrow_down:

lib/src/core/client/impl/tezart_node_error.dart
84.21% <90.00%> (+2.72%)
:arrow_up:

lib/src/models/operation/impl/operation.dart
95.83% <92.85%> (-4.17%)
:arrow_down:

lib/src/common/utils/enum_util.dart
100.00% <100.00%> (ø)

lib/src/common/utils/list_extension.dart
100.00% <100.00%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df3935...74d1934. Read the comment docs.


Support field search terms containing spaces

You can't search for a field value that has spaces in it—nothing is returned. We should support that. In single quotes, unless there's a better way to do it?

regex to support field:'search term'  -- jeff

field:"iouwhefiuwh oijwef"


Added Mit license to the Readme

As requested, a loading motion (indicator) was included.
close #14

LGTM 🚀


fix: add postrgresql 11 support

PostgreSQL 11 changes the structure of the pg_proc table

Fixes #1

Hi @urkle  -- are you waiting for me (or somebody) to merge this PR?  I took a cursory look at it and it seems fine, but I'm not in a position to actually try it out myself.    It seems like you've tested it and it works, so I'm OK for you to merge it yourself.

@ronen just wanting a second pair of eyes on it.  I'm waiting for a review on SchemaPlus/schema_dev#23 which adds in the voodoo to automate generating the  travis.yml before I merge this.


MAVSDK v2.14.0 regression: getParamInt not working correctly anymore (it works on v2.13.0)

Repro steps

Use v2.14.0
Connect an ArduPilot aircraft (can even be the SITL sim)
Use the API param.getParamInt("RTL_ALT") to fetch the Return to Launch Altitude

Expected result
The value is fetched successfully
Actual result
io.mavsdk.param.Param$ParamException: TIMEOUT: Timeout

Notes
Works just fine after reverting to v2.13.0

Oh, dear, I fixed one thing but broke another. Thanks for reporting this.

I can reproduce this.


Update README with rnpm linking info

It's so much much much easier to link with rnpm.

Thanks, may I ask you to add this section not replacing :)

@yorkie I did replace anything, only rename the original 'Link Steps'. rnpm linking and manual linking are different linking methods.

@yorkie Sry for late response.
I think rnpm is still buggy, I have to add the following steps.

Only for iOS 9, add wechat and weixin into LSApplicationQueriesSchemes in Targets > info > Custom iOS Target Properties.

Code the following in AppDelegate.m of your project to enable [LinkingIOS]
- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url
sourceApplication:(NSString *)sourceApplication annotation:(id)annotation
{
  return [RCTLinkingManager application:application openURL:url
                            sourceApplication:sourceApplication annotation:annotation];
}

I would recommend just use the current linking steps.


64-bit compiler and OS requirement

Reading through the docs, one can read:
NOTE: zfp requires 64-bit compiler and operating system support.
Does it also cover runtime or only compile-time? I would like to run the library under Android on 32-bit ARM builds and above is confusing for me.

Really all that's needed is support for 64-bit signed and unsigned integer types by the compiler (even if done through emulation) that produces binaries that can be executed on the target platform.  I think OS support is a bit of a red herring as libzfp itself should not depend on it.  I don't know how 32-bit ARM handles 64-bit integer arithmetic.

@MrSherish Just checking if zfp is working for you and whether we can close this issue.


DocsArchive-1.0.21078.2Auto archive content

Auto archive content from https://github.com/opstestppe2/E2E_DocsArchive.git

Docs Build status updates of commit 904bae6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

e2e_archiveDocs_20210403134508/TOC.yml
:white_check_mark:Succeeded
View

e2e_archiveDocs_20210403134508/breadcrumb/e2e_archiveDocs_20210403134508/toc.yml
:white_check_mark:Succeeded

e2e_archiveDocs_20210403134508/docfx.json
:white_check_mark:Succeeded

e2e_archiveDocs_20210403134508/fallback.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Usage Example

Hi. This is really cool work you are doing getting custom shaders to work . I'm trying to understand how I might use your ShaderEffect support in my own apps. I looked at your BlendShape classes in your samples directory... I'm not 100% sure how I might apply it to my own Nodes.
Could you possibly make a barebones basic demo using your sample?  ie... main() => scene => pane => node => ??? Apply BlendShape effect ??? => success?
I would be grateful and happy to help test it from there on.

Hi. Yes, I'm happy to add a full example.
I will probably use the wiki for this.
More complex shader examples are already in the works, I will hopefully add those soon, with the next release.

Update:
I have added a simple example to the wiki and updated the README to include a small code snippet for using a custom effect shader.

That example is exactly what I was hoping for. Thank you! I can't wait to try this!


Feature Request - Exponential Backoff

When receiving the exception "ProvisionedThroughputExceededException"
There is a recommended way of handling it by AWS using the Exponential Backoff method.
It would be great if the .save() or batchOperations could do this automatically?

Closing as a duplicate of #209. If you'd like to submit a PR to get this implemented that'd be awesome!


Unable to build 1.5.11-SNAPSHOT

IntelliJ version - 2018.3.4
JRE/JDK version - 1.8.0_201
Issue:
I am attempting to follow this guide in setup - https://github.com/runelite/runelite/wiki/Building-with-IntelliJ-IDEA
Confirmed that I have completed all of the above steps several times but the same issue persists.
In the runelite-client workspace, both WorldHopperPlugin.java and HiscorePlugin.java reference & use the library "org.apache.commons.lang3.ArrayUtils".  They both use the function "swap" which is only in version 3.5, see: https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/ArrayUtils.html
...However, the runelite-client POM doesn't even reference & pull this library.  And on the Building with IntelliJ walkthrough, when you are completing the Import Project step, I noticed the version was off (https://imgur.com/CbvxhAp) ... it's 3.4.
Any ideas as to what I can do to remedy this?  Or is this an issue with the latest snapshot?  I attempted to add a later version of the lang3 to the runelite-client POM to no avail:
<dependency>
  <groupId>org.apache.commons</groupId>
  <artifactId>commons-lang3</artifactId>
  <version>3.8.1</version>
</dependency>

Any other thoughts or suggestions are appreciated.

Probably no, it is not possible. If you want to see what is pulling in dependencies, run mvn dependency:tree.

Everyone else can build the project so you should probably just fix your maven config


Test Quarkus and Camel ElasticSearch REST client configuration

We have not seen any port conflicts since quite long, have we?

No, when I get time, I'll try to dig into what happened. Seems AvailablePortFinder allocated 43149 twice :confounded:.


Properly handle takeoff waypoint when not currently at takeoff location

Fixes #3387
Instead of taking off like this:

It will now do this:

This should also fix a bug where the "next" setpoint kept the type takeoff and just never stopped climbing. Although that one occurred randomly for me and I could never really pin it down.
Tested with takeoff WP at current location and away from current location. Fixed-wing should not be affected because the already existing takeoff flag is only set for MC

Applied, thanks!


Help F1 point to our userguide

Uh @Der-Erlkonig are there supposed to be 50 files changed?

closed


fix: 🐛 Update commitlint ignore regex to suppport prereleases

JIRA Link
DA-501
Changelog / Description
Fixes the commitlint regex to work with long prereleases commit names such as chore(release): 2.5.0-alpha.3.15 [skip ci]
Checklist -

[ ] New Feature ?
[ ] Updated swagger annotation (if API structure is changed) ?
[ ] Unit Test (if possible) ?
[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 2.5.0-alpha.3.15 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.7.0-alpha.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Does not work on Android 9

subj

Hello,
Any solution for android 9.
I still facing same issue .
Please update if any have resolve it


Plain text emails

[x] fix broken tests
[x] fix up deprecation warnings

Emails:
access_details_email
Claim number: X7V2-PMCC

You’ve started a claim to an employment tribunal. To return to your claim you’ll
need your claim number (above), and memorable word.

Clicking on the links below will not work. Please copy and paste URLs into your
browser.

Complete claim: http://localhost:3000/apply/session/new

You’ll receive a confirmation email once you’ve submitted your claim.

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply or click any links
  - forward it to<EMAIL_ADDRESS>
group_payment_with_remission
Claim number: T96M-M6XF

Barrington Wrigglesworth

Thank you for submitting your claim to an employment tribunal.

What happens next:
  - You have said you want to apply for fee remission. You must apply within 7 days, or your claim may be rejected.
    Apply for fee remission: https://www.employmenttribunals.service.gov.uk/remissions
  - We’ll review your claim for remission and contact you to explain the next steps.

Submission details:
Claim completed: See attached PDF
Claim submitted: Submitted 20 January 2015
Additional documents: file.rtf
Issue fee paid: £250.00

Your feedback helps us improve this service:
 https://www.surveymonkey.com/s/FH3QFS8

Help us keep track. Please complete our diversity monitoring questionnaire.
 https://www.employmenttribunals.service.gov.uk/forms/form/175/en/diversity_monitoring_questionnaire

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply to it or click any links
  - forward it to<EMAIL_ADDRESS>
group_payment_with_remission_payment_failed
Claim number: SCJ3-6HSX

Barrington Wrigglesworth

Your claim to an employment tribunal has been submitted but unfortunately we weren’t able to process your payment.

What happens next:
  - We’ll contact you within 5 working days to arrange payment.
  - You have said you want to apply for fee remission. You must apply within 7 days, or your claim may be rejected.
    Apply for fee remission: https://www.employmenttribunals.service.gov.uk/remissions
  - We’ll review your claim for remission and contact you to explain the next steps.

Submission details:
Claim completed: See attached PDF
Claim submitted: Submitted 20 January 2015
Additional documents: file.rtf
Issue fee paid: Unable to process payment

Your feedback helps us improve this service:
 https://www.surveymonkey.com/s/FH3QFS8

Help us keep track. Please complete our diversity monitoring questionnaire.
 https://www.employmenttribunals.service.gov.uk/forms/form/175/en/diversity_monitoring_questionnaire

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply to it or click any links
  - forward it to<EMAIL_ADDRESS>
payment_no_remission
Claim number: 9C3C-N0XR

Barrington Wrigglesworth

Thank you for submitting your claim to an employment tribunal.

What happens next:
  - You have said you want to apply for fee remission. You must apply within 7 days, or your claim may be rejected.
  - We’ll contact you when your claim has been sent to the respondent and explain the next steps.

Submission details:
Claim completed: See attached PDF
Claim submitted: Submitted 20 January 2015 to tribunal office Birmingham, Centre City Tower, 57 Hill Street, Birmingham B5 4UU
Additional documents: file.rtf
file.csv
Issue fee paid: £250.00

Your feedback helps us improve this service:
 https://www.surveymonkey.com/s/FH3QFS8

Help us keep track. Please complete our diversity monitoring questionnaire.
 https://www.employmenttribunals.service.gov.uk/forms/form/175/en/diversity_monitoring_questionnaire

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply to it or click any links
  - forward it to<EMAIL_ADDRESS>
payment_no_remission_payment_failed
Claim number: R17K-0B63

Barrington Wrigglesworth

Your claim to an employment tribunal has been submitted but unfortunately we weren’t able to process your payment.

What happens next:
  - We’ll contact you within 5 working days to arrange payment.
  - You have said you want to apply for fee remission. You must apply within 7 days, or your claim may be rejected.
  - We’ll contact you when your claim has been sent to the respondent and explain the next steps.

Submission details:
Claim completed: See attached PDF
Claim submitted: Submitted 20 January 2015 to tribunal office Birmingham, Centre City Tower, 57 Hill Street, Birmingham B5 4UU
Additional documents: file.rtf
file.csv
Issue fee paid: Unable to process payment

Your feedback helps us improve this service:
 https://www.surveymonkey.com/s/FH3QFS8

Help us keep track. Please complete our diversity monitoring questionnaire.
 https://www.employmenttribunals.service.gov.uk/forms/form/175/en/diversity_monitoring_questionnaire

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply to it or click any links
  - forward it to<EMAIL_ADDRESS>
remission_only
Claim number: 4BKK-2CSZ

Barrington Wrigglesworth

Thank you for submitting your claim to an employment tribunal.

What happens next:
  - You have said you want to apply for fee remission. You must apply within 7 days, or your claim may be rejected.
    Apply for fee remission: https://www.employmenttribunals.service.gov.uk/remissions
  - We’ll review your claim for remission and contact you to explain the next steps.

Submission details:
Claim completed: See attached PDF
Claim submitted: Submitted 20 January 2015
Additional documents: file.rtf
file.csv

Your feedback helps us improve this service:
 https://www.surveymonkey.com/s/FH3QFS8

Help us keep track. Please complete our diversity monitoring questionnaire.
 https://www.employmenttribunals.service.gov.uk/forms/form/175/en/diversity_monitoring_questionnaire

Contact us: http://www.justice.gov.uk/contacts/hmcts/tribunals/employment

If you’re not sure whether an email is from the Ministry of Justice then:
  - do not reply to it or click any links
  - forward it to<EMAIL_ADDRESS>

Because I have mad OCD I wrote a method to wrap the mail return value in the previews that removes the attachments and reassembles the correct parts so the content can be viewed for text or html.
class  ConfirmationEmailPreview < ActionMailer::Preview

 ....

 private

  def claim_for(trait)
    claim = FactoryGirl.create(:claim, :with_pdf, trait)
    mail = BaseMailer.confirmation_email(claim)
    multipart_preview_fix(mail)
  end

  def multipart_preview_fix(mail)
    mail.tap do |m|
      true_mail_parts = m.parts.select(&:multipart?).first.body.parts
      m.without_attachments!
      { 'text_part=' => /text\/plain/, 'html_part=' => /text\/html/ }.each do |mutator, content_match|
        m.send(mutator, true_mail_parts.select { |p| p.content_type =~ content_match }.first)
      end
      # text part adds two parts, the head contains junk, lets show it the door!
      m.parts.shift
    end
  end
end

@michaelelwin @tomwm do the above emails look ok?

Additional documents: file.rtf
file.csv

 is a HTML tag is it ok if we do this Additional documents: file.rtf, file.csv in both HTML and plain text emails?

@stevegraham @tomwm have given the plain text emails a check - quite  a few changes needed. See comments and text changes in BLUE in google doc below
<EMAIL_ADDRESS>

@michaelelwin Cheers eagle eyes :bird:. Fixed everything apart from numeric lists it's too fiddly at this point. Happy to revisit in the future if it is sufficiently problematic for users.


Add Topics to the repository

Adding topics makes it easier for other users to find and contribute to your project.
Include topics in your repositories that are related to your project’s intended affinity groups, subject area, purpose, and other essential qualities.
Topics in GitHub allow you to do the following:
Explore repositories in specific subject areas
Find projects to add or contribute to
Uncover new solutions to certain problems

@iangilman @msalsbery

@MohitBansal321 Cool! I wasn't aware of this feature. I've now added some topics. What do you think of the list? Anything I should add or remove?

It is sufficient @iangilman


All files are added

Hello, Microverse it is a personal portfolio site about Portfolio: a finished mobile version made for Education purposes, it is used with Figma design to create a UI, Flexbox to place elements on the page, and CSS Grid to place elements.
1- There are no linter errors:
2- Used correct GitHub Flow:
3- Documented in a professional way:

Thank you very much
On Thu, Jan 19, 2023 at 11:12 PM Abdelmejid Oumer Ali <
@.***> wrote:

@.**** approved this pull request.
Hi @asadmisrani https://github.com/asadmisrani,
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
https://camo.githubusercontent.com/08ea68dbbf1c4d84a3623f5e5d0572822393d07811b755517c9384d57a8a94ec/68747470733a2f2f6d65646961312e67697068792e636f6d2f6d656469612f526c746a4c457a7a42383745724a6478487a2f67697068792e676966
Highlights

Linter checks passing ✔
Correct use of Github flow ✔
Good UI design 💯

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better. Some of them were simply missed by the previous
reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/asadmisrani/portfoliomobileversion.github.io/pull/1#pullrequestreview-1262350080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQGAKAQO6DQ5OCWEYGMXCDWTF7YXANCNFSM6AAAAAAT7RGEDU
.
You are receiving this because you were mentioned.Message ID:
<asadmisrani/portfoliomobileversion.github.io/pull/1/review/1262350080@
github.com>


Ruby 2.6 compatibility

Added Unicode 11.0 definitions.
This is not a perfect solution, owing to the issue outlined in https://github.com/tom-lord/regexp-examples/issues/14
In fact, at the time of writing, even the Onigmo docs haven't been updated for Unicode 11.0 - for example, there is no mention of /\p{Makasar}/, which is now valid in ruby 2.6.0.

Coverage remained the same at 100.0% when pulling 2b5bebf656de15cdaf3c5c1827dc1abd03686c60 on ruby_2.6 into 8a485fe7f974547ceef2b3d5b7d8c8aab04f3993 on master.

Coverage remained the same at 100.0% when pulling 2b5bebf656de15cdaf3c5c1827dc1abd03686c60 on ruby_2.6 into 8a485fe7f974547ceef2b3d5b7d8c8aab04f3993 on master.


🔍 Rationalising GitHub Personal Access Tokens for MOJ-Operations-Engineering-Bot

User Need
As a member of the operations engineering team,
I want to organise and secure the GitHub personal access tokens in the moj-operations-engineering-bot account,
so that we can reduce risks, improve clarity, and align with best practices in token management.
Value
Properly managing these tokens will significantly reduce security risks by limiting their scope and improving their traceability. It will also streamline our processes by creating a clear and efficient method for future token creation and management.
Functional Requirements:

[x] Identify all existing GitHub personal access tokens associated with the moj-operations-engineering-bot account.
[x] Develop a standardised process for creating and managing GitHub personal access tokens.
[ ] Explore the integration with the Cloud Platform's secrets-manager for secure storage and management of these tokens.
[ ] Assess and limit the scope of each existing token to minimise potential security risks as per agreed standard.
[ ] Create new or rename existing tokens to make their purpose and scope clear and understandable as per agreed standard.

Non-Functional Requirements:

[ ] Ensure the token management process is secure, following industry best practices and GitHub recommendations.
[ ] The process should be well-documented, providing clear token creation, naming, and scope definition guidelines.

Acceptance Criteria:

[ ] All existing tokens in the moj-operations-engineering-bot account are identified, scoped appropriately, and renamed for clarity.
[ ] A documented process is established for future token creation, including naming conventions and scope limitations.
[ ] The integration with the Cloud Platform's secrets-manager for storing and managing tokens is successfully demonstrated.
[ ] Stakeholders are informed about the new process and any changes to existing tokens.

Notes:

Review GitHub's best practices and recommendations for creating bot tokens to ensure alignment with industry standards.
Engage with team members who frequently use these tokens to understand their needs and ensure the new process accommodates them.

moj-operations-engineering-bot

https://docs.google.com/document/d/1FT8K88DUmUJ2_coNfUU0aIghbbrdOy__vSFDf8ydCO0/

These tickets are done for this epic
https://github.com/orgs/ministryofjustice/projects/52/views/11?sliceBy[value]=🦠+Automatically+Manage+PATs+&filterQuery=&pane=issue&itemId=68106914


Local CSS not deploying to Shopify

Problem
The CSS from the local environment is not deploying to Shopify upon yarn start and yarn watch.
(yarn deploy works perfectly and yarn zip and directly uploading it to Shopify works as well, so I would assume it is an issue with slate-tools start)
Replication steps

npm i @shopify/slate-tools
yarn create slate-theme my-new-theme
Set up .env file
cd /my-new-theme
Yarn Start or Watch (tried both)
Add classes to theme.liquid
Customize classes in layout.scss which is imported into theme.scss
Save
Reload .myshopify.com

(attempted fix)

Ctrl C
Yarn Start or Watch
(and)
Reinstall slate tools
Recreate slate-theme

More Information
My local environment

Shopify environment

The HTML is updated, however the CSS is not. And it doesn't seem that the theme.scss file is even deployed, as the only SCSS file that is deployed is theme.scss.liquid.

Hey @Derplicity -- styles are included and applied to the page via the main JS file, which is served from localhost, in the development build pipelines (watch and start):

This is to take advantage of Hot Module Reloading. You should not expect to see any new CSS files uploaded for these commands, and these commands will not erase the existing files.
Does that make sense?

Seeing that made me think that perhaps it was the https:localhost, so I created an SSL for localhost and everything is working now! Gotta love it... Thanks @t-kelly

@Derplicity great! Did you follow the guide to create an SSL from the wiki? Everything worked?
Alternatively, you can visit https://localhost:8080 and manual tell your browser to trust it. But the SSL certificate is a much more permanent solution.


Error size button "ADD ANALYSIS"

Context
On an Analysis Screen when you don't have any analysis (empty case) the button shown below "ADD ANALYSIS" has a size of 36px height and we don't use this size. This button should be 32px height.
Production
The button with 36px heights

Mockup
The button with 32px heights

:dancing_men:


Tags should remain sticky when scrolling

The tag buttons in the annotation view should always be visible, also when scrolling down in the document.

While you are working on the annotation component, would you mind having a look at this one, @malteos ?


Always problem with Float32Array.hx

Hello, sorry I argue again....
Always errors like old version! Stop blaming us! I wish I work with game with OpenGLView.
WHy does it always happen like old version. I always upgrade and it shows errors:
openfl create simpleopenglview && cd simpleopenglview
openfl build cpp ( -static )
shows error:

Source/Main.hx:71: characters 34-61 : lime.utils.Float32Array should be Int
Source/Main.hx:71: characters 34-61 : For function argument 'size'
Source/Main.hx:85: characters 34-62 : lime.utils.Float32Array should be Int
Source/Main.hx:85: characters 34-62 : For function argument 'size'
Source/Main.hx:210: characters 48-53 : Bool should be Int
Source/Main.hx:210: characters 48-53 : For function argument 'count'
Source/Main.hx:211: characters 47-52 : Bool should be Int
Source/Main.hx:211: characters 47-52 : For function argument 'count'

Haxe 3,4,2
Openfl 5,1,3
Lime 5,1,0
HXCPP 3,4,69
PS: I retry remove and re install. still has errors..

Try this patch:
https://github.com/openfl/openfl-samples/commit/7689ff240fd23b1f0621eae870f8ec1f5b6dc217
You could also try casting to WebGLContext, similar to how its done here in the Lime samples:
https://github.com/openfl/lime-samples/commit/3f17c657eb8cd2a874611e75b25e07ac997a1028#diff-1d7898114ff073c4958a377cce6e510d

Thanks for resolving problem with Float32Array()
Now closed and PS: please fix to Openfl-Samples/SimpleOpenflView
Thanks much!


Dep remove

Copied in /src/utils.js#L17-L27
Filter processing remains a copy of /src/events.js#L44-69
Removed from package.json

I'll change the copied promisify function to the one used by feathers-hooks-common at the same time we switch the filter processing to what feathers-socket-common surfaces.

:shipit:


jsonProtocol: array shortcut is missing for distinct field

    → 335 const newReleaseArtistIds = await prisma.release.findMany({␊
            distinct: "artistId",␊
                      ~~~~~~~~~~␊
            where: {␊
              id: {␊
                in: [␊
                  "c0cd718c-996a-43d7-9dd6-36e3d07d162f",␊
                  "8b81a20a-9cad-401d-8ce5-7edf0c442b05",␊
                  "50693f3a-0a67-44aa-86fb-db9abb411f1c"␊
                ]␊
              }␊
            },␊
            select: {␊
              artistId: true␊
            }␊
          })␊
    ␊
    Argument \`distinct\`: Invalid value provided. Expected ReleaseScalarFieldEnum[], provided String.`,
  }

  › Argument `distinct`: Invalid value provided. Expected ReleaseScalarFieldEnum[], provided String.
  › <anonymous> (src/graphql/schema/types/activityFeed.spec.ts:1241:3)

When using the distinct parameter for findMany() the generated typescript says string | string[] but the runtime behavior of jsonProtocol says string[]
Can you update the typescript definition to be string[] ?

Hi @Raynos, thank you for this issue. Could you please also share with us the schema.prisma file you're working with and the version of Prisma you're using (prisma --version), so we can try reproducing and fixing this? Thank you.

I could reproduce by tweaking this test ./packages/client/src/__tests__/integration/happy/distinct/test.ts


Initial commit for signal Server

Initial commit for signal server

So great. The quickstart.sh worked on my first try.


Investigate better measurement on dispatch binary sizes

Request description
To count the total size of dispatches in a module, currently we simply add up all dispatch binaries (from plolyglot). As the example in https://github.com/google/iree/pull/9227#discussion_r894579748, the raw size of the dynamic library might not provide enough granularity to the actual code size.
We might have similar issues on other formats of dispatches, such as SPIR-V flatbuffer.
What component(s) does this issue relate to?
Other
Additional context
No response

If you want precise sizes per dispatch region your best bet is to do an --iree-hal-dump-executable-sources-to= and then compile each using iree-compile --compile-mode=hal-executable - that'll spit out each file on its own without any linking/combining that we do in the normal pipelines. The tradeoff here is of course then that we aren't doing any linking/combining so it doesn't give you an accurate representation of the real size of the final output - we'll want to continue to track both.

I think we want to measure the total size of all dispatches (tracking individual size is hard as the number of dispatches is always changing). This issue is the paddings in the ELF section, which reduces the precision on the real code size. The code size might increase but still in the range of padding.

In the past, I have come across situations where ther granularity of file size measurements was much larger than 4k. I seem to remember 64k for Android aarch64 builds of TFLite. I can dig up the ~ 3 year old data as needed (google internal). I never understood why the granularity was so high, but it was an empirical fact. I had a theory that it might be related to how relocations are implemented (and TFLite probably had lots more than we ever do in IREE runtime or module code).
Wanting a fine granularity metric does not imply wanting to act on tiny size changes. It's merely wanting to be able to tell tiny changes from larger changes. When the granularity is 64k, and a change makes us bump by 64k, all we know is the change was anywhere between 1 bytes and 128k minus 1 byte.

The granularity is not 64K - we're generating the ELFs and it's 4K :)

Is there a specific place in the embedded-elf linker code that controls that granularity? really curious!

We don't set it and let the default of 4096 kick in:
https://code.woboq.org/llvm/lld/ELF/Target.h.html#lld::elf::TargetInfo::defaultCommonPageSize
(I'm not saying it's not useful to see the changes - just that we can already do that with readelf/objdump and anything we were to build in addition to what we can already do is not going to make things easier)

i guess i was wondering if something else than "page size" could contribute to the effective final file size granularity - after all, I doubt that page size was 64k when i observed 64k file size granularity across tflite android/aarch64 changes!

I didn't pick those two constants at random :)
https://sourcegraph.com/github.com/llvm/llvm-project/-/blob/lld/ELF/Driver.cpp?L2678-2688
// All important alignment decisions must use this value.

(if you saw 64K it was because someone override that value)

Looks like toolchains do override it, and there's been some discussion about making it the default:
https://reviews.llvm.org/D77330
Our loader can align things in memory at any alignment we need and currently does the padding: https://github.com/google/iree/blob/857e15593718b74c15a104925bad1bab50fa7d9b/runtime/src/iree/hal/local/elf/elf_module.c#L244-L245
If the default does change we can override it (-z max-page-size=4096).

Confirmed an aarch64 ELF is not padded - in fact, not even padded to 4096;

Total size on disk is 3,968B.

oh, that had debug info - stripped is 2,144B on disk:

Counting .text and .rodata is going to get you a pretty accurate code size number, and the rest of the total file size is relatively fixed (we only export a single symbol and we barely use relocations).

Back to the original topic, if the IREE ELF dispatch doesn't have padding between segments and the other non-code segments are fixed and relative small, then directly counting on the dispatch binary size seems not a bad idea to me. I measured the rodata + code vs. the binary size on mobilenetv3 x86 embedded ELF and the difference is only 2%. And as Ben said, small size changes will be buried in the noise. We can confirm the noise level after starting tracking the binary size.
I'm thinking if there is a way to track the bad IREE codegen (IREE generates bad LLVM IR) at the IR level, which suffers from less noise. For #8849, it looks like a histogram to count the vector sizes/types will help. And from my own experience, this can also track bad tiling config. @dcaballe WDYT?

Looks like toolchains do override it, and there's been some discussion about making it the default:
https://reviews.llvm.org/D77330

Ha! OK, that clears it up. Thanks for digging this. Also relieved that "it wasn't just me" and 64k granularity was really a thing, and now I totally buy the rationale why IREE is not concerned :slightly_smiling_face:

Although this probably won't happen soon, I'm thinking if there is a way to track the bad IREE codegen (IREE generates bad LLVM IR) at the IR level, which suffers from less noise. For #8849, it looks like a histogram to count the vector sizes/types might help. And from my experience, this can also track the bad tiling config. @dcaballe WDYT?

It would be hard. For #8849, the LLVM IR looks good until it's lowered to RISC-V machine instructions, which happens at the very end of the pipeline and it's target specific. It would be like inspecting assembly.

From the discussions above and the records in the past few months, it looks like using the size of each dispatch binary is okay at this moment. Close for now.


How to get

In red you will see an observable object that has a property with a collection of objects.

But what I really want is to have access to an object, not an array. For some reason observe creates an array from the object that represents the store values.
Here is the part of the store class that is affected.
class Hosts {

    constructor(props) {
      this.URL = 'TRACER.wsHCAConfigurations.cls';
      this.hosts = observable({
        connections: []
      });
    }
....

How to handle this stuation. I want to avoid having mobserve put everything inside object with enumerated properties.

Hi Rodry, your question is not entirely clear to me as I am unsure which object you are inspecting in the image. But note that you can directly pass an array to observable. Also I recommend using extendObservable in constructors, like
constructor(props) {
   extendObservable(this, {
      hosts: {
         connections: []
      }
   })
)

The advantage of that is that it makes not only the value of hosts observable but also the property itself so that direct property assignments can be picked up in the future automatically.

Guys, I decided to drop Mobservable for a while and implement the app I am building using Redux, which I am more comfortable with. It simply took a long time to solve some of the very particular problems I was facing building it since I am still learning the library.
I plan to publish a repository with the finished app in redux in an effort for the Mobservable community inspect it and perhaps offer ways in which it could have been built using this library.
Refactoring to redux took one afternoon of coding, which tells alot about how good React abstracts from state handlng libs.
Thanks again for responding to all of my issues.

No problem. Thanks for trying! I look forward to the app, and if you are willing to share any details on the scenarios you couldn't figure out we might try to improve our docs based on that.

I will. I am really impresses by Mobservable and still wonder why it has
not been used as often as similar libraries.
Looking forward to give it another try soon.
Thanks again.
El El mar, 2 de feb de 2016 a las 2:12 p.m., Michel Weststrate <
<EMAIL_ADDRESS>escribió:

No problem. Thanks for trying! I look forward to the app, and if you are
willing to share any details on the scenarios you couldn't figure out we
might try to improve our docs based on that.
—
Reply to this email directly or view it on GitHub
https://github.com/mweststrate/mobservable/issues/106#issuecomment-178764972
.


Add temporary redirect notice on Gitbook site

We have SEO plan to add a redirect from docs.cellxgene.cziscience.com to https://cellxgene.cziscience.com/docs, but until the work is done, we need to temporary solution on the Gitbook site to let the current users know where to find the new content!
Gitbook: https://app.gitbook.com/o/-McoHix1O4OcxwAcIqZi/c/-MeSvEjvftHK47ocOlpc
Please ask Ambrose or Nik for Gitbook access to add the redirect notice
Thank you!

Hi @tihuan , is this still relevant? Sorry, I have zero context on the issue!


[AIRFLOW-2899] Hide sensitive data when Exporting Variables

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2899
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Currently, the sensitive variable is hidden from being exposed in the Web UI. However, if the UI is compromised, someone can export variables where all the sensitive variables are exported in plain text format.

This will still allow an admin to export all the variables from the CLI. The main intention here would be incase of an exposed Web UI, the sensitive data should still be inaccessible.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

cc @Fokko @feng-tao @bolkedebruin

Codecov Report

Merging #3748 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3748      +/-   ##
==========================================
- Coverage   77.67%   77.64%   -0.03%
==========================================
  Files         204      204
  Lines       15849    15853       +4
==========================================
- Hits        12310    12309       -1
- Misses       3539     3544       +5

Impacted Files
Coverage Δ

airflow/www/views.py
68.95% <0%> (-0.09%)
:arrow_down:

airflow/www_rbac/views.py
72.61% <0%> (-0.11%)
:arrow_down:

airflow/models.py
88.78% <0%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d68fa3...8a73aa1. Read the comment docs.

@kaxil, it would be good if you could add a test to test the sensitive data export case.

@feng-tao Would you or someone with good Flask experience (e.g. @jgao54 , @Fokko ) be able to help with adding a test for this.

I might even argue that we need to fix this on an API level instead of the view level. In this case the API will just obfuscate the secrets.

@Fokko Fixing this on API level will mean we won't be able to get the variables in plain text through CLI as well.

@ashb Thoughts?

Yes. And No?
Yes, because by default it probably shouldn't be possible to get the secrets back out. But the export including sensitive might be useful for backups/provisioning.
The "fuller" solution that would support exporting while keeping then encrypted. That would involve a change of format of export and is probably a bigger chunk of work.
In short: I don't know, sorry.

@ashb No worries. The aim of this PR was to obfuscate sensitive variables from UI export but it would still allow you to download them through the CLI.

Why not allow the user to decide per Variable if it's sensitive or not (addition of Boolean column)? Then you won't need to consider the question of what to do... there will be a value defined by the user to simply act accordingly.
Sometimes what you might consider as secret isn't considered as such by the user.

@kaxil  No need to get mad it was just a suggestion :)

@ron819 I didn't get mad at all, apologies and sorry if you felt so. I seriously think that it should have been a user's choice to select the sensitive variables.


[CT-910] Tracking works with Click

User story:
As dbtlabs we want to know how/when our software is being used.
Acceptance criteria:

Tracking is enabled and runs as part of the root click group.

To get started on the issue, find the commit that did something similar, and see how to do the same for tracking

Resolved by https://github.com/dbt-labs/dbt-core/pull/5972


Setup initial React application

Summary
We want to get some type of application started in order to unblock a bunch of issues regarding the CI/CD pipeline and unit testing that are going to go along side the application logic. So we can start this by creating a react application. This can be done using some of the react starter functions such as create react app. We can also use something like next as well.
Action
First come to some decision about whether we want to use pure react, or some other implementation like Next.js. There shouldn't be much difference between the two. However looking at some things like how they both support things like testing and deployment. After this we want to set up the project using the scaffolding functions that react has available.
Resources

[React Docs] (https://reactjs.org/)
[Next Docs] (https://nextjs.org/docs/getting-started)
[Next Testing] (https://nextjs.org/docs/testing)
[React Testing] (https://reactjs.org/docs/testing.html)

Tasks

[x] Choose between React, Next or some other framework that uses javascript

Next was chosen for the application. Due to it's documentation and suitability with the testing frameworks.


chore(action): use<EMAIL_ADDRESS>

Applied mkpr on .github/workflows/*.yml
sed s/setup-node<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.715%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2475

Relevant Lines:
2839

💛  - Coveralls


Question on grid container

Hi @lucasgruwez,
just a question on the .grid class on why the need for the display: flex; and flex-direction: column;?
Flex columns rely on height being set to utilise some of the other flex properties like justify-content, etc.
The main properties of the .grid class seem to be acting more like a container then a grid wrapper.
Seems like more of a special case - as your example on the site doesn't require it.
Just curious as a fellow flex framework dev. 😁

Hi @jackmcpickle
I am a bit confused by your question... I do not fully get what you mean in your first paragraph, but let me try and explain my logic behind the properties set on the .grid class:
I am in this grid using the .grid class as both the grid wrapper and a container to center the grid. This removes the need for extra markup that I usually have.

    ...

I will add a .container class that will only center the content without the flex properties, and I will also add the possibility to make the grid full width (it will probably be something like .grid.full-width) in version 1.3.4.
I am now currently traveling, and don't have my computer with me (this here was written from my tablet), so v1.3.4 will probably be released Friday or Saturday.
Thanks for your help and participation in this project! 🙂
Lucas

Thanks for the prompt response. Hopefull this pen should illustrate my point better. http://codepen.io/jackmcpickle/pen/EWEMJe
By commenting out the flex properties on the grid class I achieve the same result.

The reason why it is set to display: flex; and flex-direction: column; is actually for a couple of features I am currently working on. I think it is best that we keep it that way even without the additional features, in case there are some unwanted effects caused by removing those properties (or adding them later).
If you want to use waffle-grid by removing those properties, feel free to do so! And if you ever make a website with it, make sure to send me a link by email<EMAIL_ADDRESS>so that I can check out what you made, and I might add it to an examples section on the website.
Lucas

I added the helper classes even though it wasn't what you meant in the original issue, I think it might come in handy to some other people...
Thanks again for your involvement in this project!
Lucas


Updated React socketio configuration to support OS refactor services

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation, VERSION, and CHANGELOG accordingly.
[ ] I have read the CONTRIBUTING document.

Not to be merged until OS refactor components in place as this will break compatibility with pre-refactor covalent.


fix bug when set APPDIR component

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


map_control.py doc-fix

added https:// to the example link,
removed # pylint: disable=line-too-long

This looks good to me -- shall I pull it out of draft mode?

This looks good to me -- shall I pull it out of draft mode?

Yeah you can do that xeno, just made it draft if I found more fixes, but this is all I got.


Array parameters in Modelica.Blocks

Reported by pharman on 18 Sep 2012 10:45 UTC
A number of classes in Modelica.Blocks have array parameters with no value and no start-value, preventing complete expansion of the model for checking purposes, in particular:
Modelica.Blocks.Continuous.StateSpace
Modelica.Blocks.Discrete.TransferFunction
Modelica.Blocks.Discrete.StateSpace
Modelica.Blocks.Sources.KinematicPTP
Modelica.Blocks.Sources.KinematicPTP2
Modelica.Blocks.Sources.TimeTable
Modelica.Blocks.Sources.BooleanTable
Modelica.Blocks.Sources.RadioButtonSource

Migrated-From: https://trac.modelica.org/Modelica/ticket/826

Comment by pharman on 2 Oct 2012 10:13 UTC
Set in b559129d1c5632c7eb06ee84b053262fb3289d22