Allow inset-text to take a block

What
Can now pass an arbitrary block to the inset-text component to
have content rendered inset. If both 'text' and a block are
provided, 'text' takes precedence (mutually exclusive).
Why
This is a compromise solution, rather than copying the inset-prompt
component from content-publisher (for use in collections-publisher),
for the reason that under current GOV.UK architecture the component
CSS would be added to the stylesheets for our end users (not just
the users using the publishing app). See:
https://github.com/alphagov/govuk_publishing_components/pull/1077
Once merged, we will use this latest inset-text component and
manually recreate what the inset-prompt component looks like by
passing components to the inset-text component as a block.
Trello: https://trello.com/c/TcBpLRuC/48-add-inset-prompt-component-to-govukpublishingcomponents
Visual Changes

View Changes
https://govuk-publishing-compo-pr-1078.herokuapp.com/

We do have other components that accept a block like this, and the guidance around that is that the contents should be styled separately from the component, ie. the component takes no responsibility for what it is passed. We should at least document that in this component.

We do have other components that accept a block like this, and the guidance around that is that the contents should be styled separately from the component, ie. the component takes no responsibility for what it is passed. We should at least document that in this component.

Do you have an example?

There's a few, although they don't seem to document what I was talking about 😞

https://components.publishing.service.gov.uk/component-guide/details
https://components.publishing.service.gov.uk/component-guide/inverse_header
plus a few others, including the layout (although that's a special case in a sense)

We do have other components that accept a block like this, and the guidance around that is that the contents should be styled separately from the component, ie. the component takes no responsibility for what it is passed. We should at least document that in this component.

Happy to add a clarifying note. Where should that be added, @andysellick - the description at the top of the YAML file? Or is there a way of adding a description inside the block example?

@ChrisBAshton https://github.com/alphagov/govuk_publishing_components/blob/master/app/views/govuk_publishing_components/components/docs/step_by_step_nav.yml#L76


[Internal] data type: constructor set

constructor set can have it's context extender when handling data type

stop tracking


Cannot upgrade Symfony project to 5.2.x

composer update "symfony/*" --with-all-dependencies
Loading composer repositories with package information
Updating dependencies (including require-dev)
Restricting packages listed in "symfony/symfony" to "5.2.*"
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - icawebdesign/hibp-php 4.2.3 requires symfony/yaml ^4.4 -> satisfiable by symfony/yaml[v4.4.16] but these conflict with your requirements or minimum-stability.
    - icawebdesign/hibp-php 4.2.3 requires symfony/yaml ^4.4 -> satisfiable by symfony/yaml[v4.4.16] but these conflict with your requirements or minimum-stability.
    - icawebdesign/hibp-php 4.2.3 requires symfony/yaml ^4.4 -> satisfiable by symfony/yaml[v4.4.16] but these conflict with your requirements or minimum-stability.
    - Installation request for icawebdesign/hibp-php (locked at 4.2.3, required as ^4.2) -> satisfiable by icawebdesign/hibp-php[4.2.3].

Thanks for the report.
I'll get this sorted ASAP (hopefully over the weekend) :)

This should now be resolved :🙂


Checklist

It might be worth putting together a checklist/one per event stage - a useful quick reference for people. Could be down the line i.e. after the initial version is published

@JacalynLaird I am going to change the label on this one to 'enhancement' and we can punt it to a future version - what do you think? (as I am taking closing all the comms-edits labelled ones as things we need to close to get the version out)

Agreed

For the record - this is a task now for a future version of EOG (after the one done in Dec 2020).

this is the same as #78 so I am closing it.


Default values for futures constants

After a bit of tinkering, I seem to have a functional Zipline setup for modeling futures. The last piece of the puzzle was the constants.py file.
As it seems, you currently need to hard code every futures root symbol you intend to use in the constants.py file. You can ingest data for other root symbols, but the trading algorithm will fail if it can't find the symbol in FUTURE_EXCHANGE_FEES_BY_SYMBOL and ROOT_SYMBOL_TO_ETA.
It's great that we can set individual slippage and cost per market here, but wouldn't it make sense to have a default value? If a default value would be added, you wouldn't get a key error crash if a new market is added.
Certainly not a high priority issue, but it would probably make sense and could save new developers some time.
ac

A Q&D workaround for this:
Edit finance/slippage.py
Line 27, change from:
from zipline.finance.constants import ROOT_SYMBOL_TO_ETA
to:
from zipline.finance.constants import ROOT_SYMBOL_TO_ETA, DEFAULT_ETA
And Line 510, change from:
       eta = self._eta[order.asset.root_symbol]
to:
        try:
            eta = self._eta[order.asset.root_symbol]
        except:
            eta = DEFAULT_ETA
``


Layout needs to work on iphone 8

My test phone is an iphone 8.
Please verify the layout for iphone 8.

Layout on my phone cuts off the filters.  The best idea might be to make the filters smaller.  they take up about 1/3 of the screen on the iphone 8.

The bug with the layouts:
The layouts don't take into account the screen size.  Everything should be relative to the things around it.  For example
buttons
10 pixels from bottom of screen
otherwise, you don't see the buttons if you rotate the view.
Horizontal layouts don't really work properly.

I tried to set the sizes relative(which worked for my screen size), but it was only based on multipliers which could've been the problem. On Aug 13, 2023, at 12:21 AM, David J. Kordsmeier @.***> wrote:
The bug with the layouts:
The layouts don't take into account the screen size.  Everything should be relative to the things around it.  For example
buttons
10 pixels from bottom of screen
otherwise, you don't see the buttons if you rotate the view.
Horizontal layouts don't really work properly.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.***>

Really take a review of this from Apple: https://developer.apple.com/videos/play/wwdc2022/10056/
You have to test on different screen sizes.  You have the emulator.  Use that.  Anyone developing for iOS has to deal with this.  Layouts are hard on all platforms.

closing


Feature/support custom docker machine dist

Description
Support custom docker machine download url
Migrations required
NO
Verification
default example

Close #215


ci: Run diff-walk on big filesystems

This is slow: the job takes about six minutes due to needing to decompress a giant file. But it adds some good testing of real-world data that is otherwise missing.

If the slowness feels like a problem, https://github.com/actions/cache might help solve it?

Or, it looks like rust-cache can maybe be configured to include these files?


Trouble parsing AWS ALB logs

I found an old post about parsin AWS ALB (not ELB) logs but it refers to an older and not currently used version of the logs. The current one is described here: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-access-logs.html
I'm using this format
%^ %dT%t.%^ %^ %h:%^ %^:%^ %T %^ %^ %s %^ ^% %b "%r" "%u" %^ %^ %^ "%^" "%^" "%^" %^ %^ "%^" "%^"
that I derived from the old one, but it always fails with:
IPv4/6 is required.
I use --date-format='%Y-%m-%d' and --time-format=%T.
Attached are a couple of sanitized line from the real log.
I can't find where the problem is, it seems breaking also parsing a couple of fields...
Thanks
alb.txt

This works for me:
goaccess access.log --log-format='%^ %dT%t.%^ %v %h:%^ %^ %^ %T %^ %s %^ %^ %b "%r" "%u" %^' --date-format=%Y-%m-%d --time-format=%T

Closing this. Feel free to reopen it if needed.


YARN-11000. Replace queue resource calculation logic in updateClusterResource

Description of PR
The new queue resource calculation logic is capable of calculating the queue resources based on mixed resource types. The queues under one parent can also mix their modes (e.g.: root.queue1=percentage root.queue2=weight root.queue3=absolute).
Precedence is:  absolute ->  percentage -> weight.
Note that the calculation is done by a single resource type at once.
Design doc: YARN-10888
Example
yarn.scheduler.capacity.root.default.capacity         = [memory=1w, vcores=4]
yarn.scheduler.capacity.root.test_1.capacity          = [memory=16384, vcores=100%]
yarn.scheduler.capacity.root.test_2.capacity          = [memory=3w, vcores=12]
yarn.scheduler.capacity.root.test_1.test_1_1.capacity = [memory=1w, vcores=1w]
yarn.scheduler.capacity.root.test_1.test_1_2.capacity = [memory=50%, vcores=2]
yarn.scheduler.capacity.root.test_1.test_1_3.capacity = [memory=12288, vcores=86%]

Further examples: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySchedulerMixedMode.java
The feature is behind a feature flag, it is disabled by default.
yarn.scheduler.capacity.legacy-queue-mode.enabled = true/false

Note that the mixed mode is not yet supported for AQCv2 (or v1) templates. YARN-11520
Key changes

The capacity and absoluteCapacity (and maxApplications and other derived properties) of a queue is calculated from the effectiveMinResource (= the current available resource for a given queue based on the queue hierarchy configuration and the available cluster resource).

When there is no cluster resources available yet, the maxApplications are set to the configured values, so applications can be submitted.

Changes in the scheduler-response: the capacity and absoluteCapacity resembles the effective values based on the queue configs and cluster resources. The normalizedWeight is not filled in the scheduler-response when queues are in weight mode.

How was this patch tested?

I'll run all the unit test in both Legacy and the "Uniform" queue calculation mode in this PR.
Follow-up ticket for some additional tests: YARN-11521

Acknowledges
The current state of this PR was a team effort, thanks to:
@9uapaw
@brumi1024
@K0K0V0K
Follow up items

YARN-11514 Extend SchedulerResponse with capacityVector
YARN-11520 Support capacity vector for AQCv2 dynamic templates
YARN-11521 Create a test set that runs with both Legacy/Uniform queue calculation
YARN-11522 Update documentation for the New capacity modes in CS

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'YARN-11000. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 41 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
53m 32s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  9s

trunk passed

+1 :green_heart:
shadedclient
39m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 49s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 779 unchanged - 23 fixed = 787 total (was 802)

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 59s

the patch passed

+1 :green_heart:
shadedclient
39m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
104m 14s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

256m 20s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedLegacyQueueCreation

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySchedDynamicConfig

hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesCapacitySched

hadoop.yarn.server.resourcemanager.reservation.TestReservationSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint

uname
Linux f439441a3326 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da47ec69364c65a5227c22ecbc781657e51a9c70

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/2/testReport/

Max. process+thread count
908 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  0s

jsonlint was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 49 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 18s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  1s

trunk passed

+1 :green_heart:
shadedclient
38m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 49s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 857 unchanged - 23 fixed = 865 total (was 880)

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
shadedclient
39m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 27s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

250m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 7e92986c05c8 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 84d1bb34fcb83fd9708a279216f66275a4cd1098

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/4/testReport/

Max. process+thread count
909 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Green with Legacy mode as well. 👍

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 49 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 56s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
0m 57s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 59s

trunk passed

+1 :green_heart:
shadedclient
39m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 55s

the patch passed

+1 :green_heart:
compile
0m 48s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 51s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 857 unchanged - 23 fixed = 865 total (was 880)

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 59s

the patch passed

+1 :green_heart:
shadedclient
39m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 35s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

250m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 3c436f503ef3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ed55c3e72908da42998f69a13ad10c75b224af43

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/5/testReport/

Max. process+thread count
920 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 49 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 25s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  1s

trunk passed

+1 :green_heart:
shadedclient
39m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 49s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 857 unchanged - 23 fixed = 865 total (was 880)

+1 :green_heart:
mvnsite
0m 52s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  0s

the patch passed

+1 :green_heart:
shadedclient
39m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 24s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

249m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 6aecf7461d50 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 04fca6b89cb3a0ccdf55733691c1e110c5e58862

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/6/testReport/

Max. process+thread count
926 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 49 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
53m 48s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  3s

trunk passed

+1 :green_heart:
shadedclient
39m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 50s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 857 unchanged - 23 fixed = 865 total (was 880)

+1 :green_heart:
mvnsite
0m 50s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 57s

the patch passed

+1 :green_heart:
shadedclient
39m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 52s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

254m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 92f965168a8c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 02b60d30dd8e66e4316374d447375bfa2594091d

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/7/testReport/

Max. process+thread count
927 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
25m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 49 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 28s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
0m 59s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  1s

trunk passed

+1 :green_heart:
shadedclient
41m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 50s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 8 new + 857 unchanged - 23 fixed = 865 total (was 880)

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 57s

the patch passed

+1 :green_heart:
shadedclient
39m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
119m 23s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

292m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 369307a92aee 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 09210de4c49e4f0b0ddc189102d8b0d66fe6458f

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/8/testReport/

Max. process+thread count
920 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
23m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  0s

jsonlint was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 60 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
51m 12s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  2s

trunk passed

+1 :green_heart:
shadedclient
39m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 50s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 992 unchanged - 23 fixed = 1001 total (was 1015)

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
shadedclient
39m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
103m 28s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

274m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux 4a68590b2e5a 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce98e11d83d5afb78607ac0bb3b241b89664d2c1

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/9/testReport/

Max. process+thread count
938 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@szilard-nemeth thanks for the review. I added the fixes, there was no big change, so I don't think we need to run the tests 2x times (legacy/non-legacy).

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
jsonlint
0m  1s

jsonlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 60 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 50s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  0s

trunk passed

+1 :green_heart:
shadedclient
39m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 55s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 50s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 9 new + 993 unchanged - 23 fixed = 1002 total (was 1016)

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
shadedclient
39m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 40s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

249m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5783

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets jsonlint xmllint

uname
Linux e6be65ee3f59 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b48fbfb479b5b21a43a4f3c44f9cdfeb35c17d51

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/10/testReport/

Max. process+thread count
912 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5783/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@tomicooler ,
Thanks for the fixes.
Checked the following commits separately, ofc I haven't checked the whole patch again:
4529eba (#5783)
77fc689 (#5783)
414e043 (#5783)
b33e1bf (#5783)
442e93d (#5783)
ed814e9 (#5783)
c3d0a63 (#5783)
b48fbfb (#5783)
Latest patch LGTM, +1.

Thanks @9uapaw for the original patch, @tomicooler for the updates and test fixes, @K0K0V0K for the help and additional test cases and @szilard-nemeth for the review. Merging this to trunk.


Update index.de-de.md

Some minor changes related to the language.

Maybe use Falls die Version neuer ist als xxx, ...

Codecov Report

Merging #22363 (b2a28d2) into main (d42b52f) will increase coverage by 48.18%.
The diff coverage is n/a.

:exclamation: Current head b2a28d2 differs from pull request most recent head aa5f555. Consider uploading reports for the commit aa5f555 to get more accurate results

@@            Coverage Diff            @@
##           main   #22363       +/-   ##
=========================================
+ Coverage      0   48.18%   +48.18%
=========================================
  Files         0     1046     +1046
  Lines         0   142384   +142384
=========================================
+ Hits          0    68605    +68605
- Misses        0    65606    +65606
- Partials      0     8173     +8173

Impacted Files
Coverage Δ

models/asymkey/gpg_key_commit_verification.go
42.20% <0.00%> (ø)

modules/context/captcha.go
17.77% <0.00%> (ø)

models/issues/issue_lock.go
0.00% <0.00%> (ø)

routers/web/explore/repo.go
68.03% <0.00%> (ø)

modules/git/repo_commit.go
54.07% <0.00%> (ø)

models/git/lfs.go
21.32% <0.00%> (ø)

modules/uri/uri.go
27.77% <0.00%> (ø)

modules/nosql/manager.go
46.42% <0.00%> (ø)

routers/web/repo/issue_content_history.go
0.00% <0.00%> (ø)

routers/web/auth/password.go
2.71% <0.00%> (ø)

... and 1036 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

make L-G-T-M work


pytorch nightly + torchrec nightly not compatible with fbgemm for test_installation.py

Hi, i installed the following version for packages as readme.
cudatoolkit                       11.3.1                       h2bc3f7f_2
fbgemm-gpu-nightly        2022.9.19                pypi_0    pypi
pytorch                             1.13.0.dev20220919     py3.7_cpu_0    pytorch-nightly
torchmetrics                     0.9.3                        pypi_0    pypi
torchrec-nightly               2022.9.19                pypi_0    pypi
torchx-nightly                  2022.9.19                pypi_0    pypi
when i run the pytorch test_installation.py as
torchx run -s local_cwd dist.ddp -j 1x2 --gpu 2 --script test_installation.py
There are the following error happened.
===============
torchx 2022-09-19 22:44:35 INFO     Log directory not set in scheduler cfg. Creating a temporary log dir that will be deleted on exit. To preserve log directory set the log_dir cfg option
torchx 2022-09-19 22:44:35 INFO     Log directory is: /tmp/torchx_32yqu363
local_cwd://torchx/test_installation-jclxjg6pxm1wqc
torchx 2022-09-19 22:44:35 INFO     Waiting for the app to finish...
test_installation/0 WARNING:main:
test_installation/0 *****************************************
test_installation/0 Setting OMP_NUM_THREADS environment variable for each process to be 1 in default, to avoid your system being overloaded, please further tune the variable for optimal performance in your application as needed.
test_installation/0 *****************************************
test_installation/0 [0]:libc10_cuda.so: cannot open shared object file: No such file or directory
test_installation/0 [1]:libc10_cuda.so: cannot open shared object file: No such file or directory
test_installation/0 [0]:Traceback (most recent call last):
test_installation/0 [1]:Traceback (most recent call last):
test_installation/0 [0]:  File "/usr/local/lib/python3.7/site-packages/torch/_ops.py", line 492, in getattr
test_installation/0 [0]:    op, overload_names = torch._C._jit_get_operation(qualified_op_name)
test_installation/0 [0]:RuntimeError: No such operator fbgemm::jagged_2d_to_dense
test_installation/0 [0]:
test_installation/0 [0]:The above exception was the direct cause of the following exception:
test_installation/0 [0]:
test_installation/0 [0]:Traceback (most recent call last):
test_installation/0 [1]:  File "/usr/local/lib/python3.7/site-packages/torch/_ops.py", line 492, in getattr
test_installation/0 [0]:  File "test_installation.py", line 16, in
test_installation/0 [1]:    op, overload_names = torch._C._jit_get_operation(qualified_op_name)
test_installation/0 [0]:    from torchrec import EmbeddingBagCollection, KeyedJaggedTensor
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/init.py", line 8, in
test_installation/0 [0]:    import torchrec.distributed  # noqa
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/init.py", line 36, in
test_installation/0 [0]:    from torchrec.distributed.model_parallel import DistributedModelParallel  # noqa
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/model_parallel.py", line 20, in
test_installation/0 [0]:    from torchrec.distributed.embedding import EmbeddingCollectionSharder
test_installation/0 [1]:RuntimeError: No such operator fbgemm::jagged_2d_to_dense
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/embedding.py", line 30, in
test_installation/0 [1]:
test_installation/0 [0]:    from torchrec.distributed.embedding_sharding import (
test_installation/0 [1]:The above exception was the direct cause of the following exception:
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/embedding_sharding.py", line 15, in
test_installation/0 [1]:
test_installation/0 [0]:    from torchrec.distributed.dist_data import (
test_installation/0 [1]:Traceback (most recent call last):
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/dist_data.py", line 16, in
test_installation/0 [1]:  File "test_installation.py", line 16, in
test_installation/0 [1]:    from torchrec import EmbeddingBagCollection, KeyedJaggedTensor
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/init.py", line 8, in
test_installation/0 [1]:    import torchrec.distributed  # noqa
test_installation/0 [0]:    from torchrec.distributed.comm_ops import (
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/init.py", line 36, in
test_installation/0 [0]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/comm_ops.py", line 27, in
test_installation/0 [0]:    import fbgemm_gpu  # @manual  # noqa
test_installation/0 [0]:  File "/usr/local/lib/python3.7/site-packages/fbgemm_gpu/init.py", line 22, in
test_installation/0 [0]:    from . import _fbgemm_gpu_docs
test_installation/0 [1]:    from torchrec.distributed.model_parallel import DistributedModelParallel  # noqa
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/model_parallel.py", line 20, in
test_installation/0 [1]:    from torchrec.distributed.embedding import EmbeddingCollectionSharder
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/embedding.py", line 30, in
test_installation/0 [0]:  File "/usr/local/lib/python3.7/site-packages/fbgemm_gpu/_fbgemm_gpu_docs.py", line 12, in
test_installation/0 [0]:    torch.ops.fbgemm.jagged_2d_to_dense,
test_installation/0 [0]:  File "/usr/local/lib/python3.7/site-packages/torch/_ops.py", line 498, in getattr
test_installation/0 [0]:    ) from e
test_installation/0 [0]:AttributeError: '_OpNamespace' 'fbgemm' object has no attribute 'jagged_2d_to_dense'
test_installation/0 [1]:    from torchrec.distributed.embedding_sharding import (
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/embedding_sharding.py", line 15, in
test_installation/0 [1]:    from torchrec.distributed.dist_data import (
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/dist_data.py", line 16, in
test_installation/0 [1]:    from torchrec.distributed.comm_ops import (
test_installation/0 [1]:  File "/hongming/new_torchrec/torchrec/torchrec/distributed/comm_ops.py", line 27, in
test_installation/0 [1]:    import fbgemm_gpu  # @manual  # noqa
test_installation/0 [1]:  File "/usr/local/lib/python3.7/site-packages/fbgemm_gpu/init.py", line 22, in
test_installation/0 [1]:    from . import _fbgemm_gpu_docs
test_installation/0 [1]:  File "/usr/local/lib/python3.7/site-packages/fbgemm_gpu/_fbgemm_gpu_docs.py", line 12, in
test_installation/0 [1]:    torch.ops.fbgemm.jagged_2d_to_dense,
test_installation/0 [1]:  File "/usr/local/lib/python3.7/site-packages/torch/_ops.py", line 498, in getattr
test_installation/0 [1]:    ) from e
test_installation/0 [1]:AttributeError: '_OpNamespace' 'fbgemm' object has no attribute 'jagged_2d_to_dense'
test_installation/0 ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 1145) of binary: /usr/local/bin/python
test_installation/0 Traceback (most recent call last):
test_installation/0   File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
test_installation/0     "main", mod_spec)
test_installation/0   File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
test_installation/0     exec(code, run_globals)
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/run.py", line 766, in
test_installation/0     main()
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 345, in wrapper
test_installation/0     return f(*args, **kwargs)
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/run.py", line 762, in main
test_installation/0     run(args)
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/run.py", line 756, in run
test_installation/0     )(*cmd_args)
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 132, in call
test_installation/0     return launch_agent(self._config, self._entrypoint, list(args))
test_installation/0   File "/usr/local/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 248, in launch_agent
test_installation/0     failures=result.failures,
test_installation/0 torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
test_installation/0 ============================================================
test_installation/0 test_installation.py FAILED
test_installation/0 ------------------------------------------------------------
test_installation/0 Failures:
test_installation/0 [1]:
test_installation/0   time      : 2022-09-19_22:44:41
test_installation/0   host      : skyrex
test_installation/0   rank      : 1 (local_rank: 1)
test_installation/0   exitcode  : 1 (pid: 1146)
test_installation/0   error_file: <N/A>
test_installation/0   traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
test_installation/0 ------------------------------------------------------------
test_installation/0 Root Cause (first observed failure):
test_installation/0 [0]:
test_installation/0   time      : 2022-09-19_22:44:41
test_installation/0   host      : skyrex
test_installation/0   rank      : 0 (local_rank: 0)
test_installation/0   exitcode  : 1 (pid: 1145)
test_installation/0   error_file: <N/A>
test_installation/0   traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html
test_installation/0 ============================================================
torchx 2022-09-19 22:44:42 INFO     Job finished: 5
torchx 2022-09-19 22:44:42 ERROR    AppStatus:
msg:
num_restarts: 0
roles: []
state: FAILED (5)
structured_error_msg:
ui_url: file:///tmp/torchx_32yqu363/torchx/test_installation-jclxjg6pxm1wqc

does your PT verison have cuda enabled? the version looks like:
pytorch 1.13.0.dev20220919 py3.7_cpu_0 pytorch-nightly

yes. solved according to your suggestion and cuda not enabled. :-)
It's better to change the readme a little with the gpu enable case. The user normally assume with gpu/cpu in default. thanks.

yes. solved according to your suggestion and cuda not enabled. :-)
It's better to change the readme a little with the gpu enable case. The user normally assume with gpu/cpu in default. thanks.

Closing this issue since issue is resolved,
Thanks for your suggestion, sorry that it was confusing.
Just want to double check:
did you run
conda install pytorch cudatoolkit=11.3 -c pytorch-nightly

and this installed the cpu version?

yes this instruction will give you the cpu version. - conda install pytorch cudatoolkit=11.3 -c pytorch-nightly
Now i am using the official pytorch website instruction as
conda install pytorch pytorch-cuda=11.6 -c pytorch-nightly -c nvidia
which will give the gpu version also.

yes this instruction will give you the cpu version. - conda install pytorch cudatoolkit=11.3 -c pytorch-nightly
Now i am using the official pytorch website instruction as conda install pytorch pytorch-cuda=11.6 -c pytorch-nightly -c nvidia which will give the gpu version also.

I see - that's definitely not expected, I'll check up on that and update the README, thanks!


“Development” isn’t default when loading schema

This is a question rather than an issue.
When I run the task db:schema:load I got
ActiveRecord::EnvironmentMismatchError: You are attempting to modify a database that was last run in `development` environment.
You are running in `default_env` environment.

However, when I print the environment in Rakefile like
namespace :db do
  task :load_config do
    require_relative 'app'
    puts settings.environment
  end
end

It prints “development” as expected. Any hint about how I can debug my application? The database name is correct, but it somehow thinks I’m in default_env. It works when overriding the environment with environment variables, but I would like to understand why.

What happens if you set the RAILS_ENV env var to "development"?

What happens if you set the RAILS_ENV env var to "development"?


Type conversion fixes to make GCC 5.2.0 happy

GCC 5.2.0 seems to be quite finicky about the result of an arithmetic conversion, int/unsigned as the the standard, being assigned (sometimes "indirectly", as in |=) to a shorter type. Moar info at https://gcc.gnu.org/wiki/NewWconversion
@ctiller @nicolasnoble

This is an unusual commit, and definitely seems like it would benefit from some inline comments at the change points to prevent someone from changing these back to save column width.

To followup to my previous reply: I think that all the work done in this pull request is the result of automatic integer promotion of sub-int expressions since C arithmetic operations do not actually accept sub-int types as operands. This is a facet of the language that most people do not immediately remember, so I think that the change from x |= (char) y to x = (char)(x | y) could benefit from a comment like /* avoid type conversion warning caused by integer promotion before operation */

Here's a line that I found from a C89 draft standard, section <IP_ADDRESS>:
A char, a short int, or an int bit-field, or their signed or unsigned varieties, or an object that has enumeration type, may be used in an expression wherever an int or unsigned int may be used. If an int can represent all values of the original type, the value is converted to an int; otherwise it is converted to an unsigned int. These are called the integral promotions.
So just confirming: the issue here is that sub-int types are upconverted to int before being used in any expression, including arithmetic operators.

Yes, the source of the issue was clear: the promotion to an type (int/unsigned) that's larger than the ultimate container of the calculation. Adding the comments now.

Done. PTAL.

PTAL :)

I am now 100% happy with this code. Let's wait for green and merge.

Is the 100 signed or unsigned?

2s complement.
On Tue, Oct 6, 2015 at 11:28 AM David G. Quintas<EMAIL_ADDRESS>wrote:

Is the 100 signed or unsigned?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/3615#issuecomment-145956222.

BCD FTW

All green shortages are either previously reported or newly-filed issues.


Add breaker to grpcx client middleware.

Coverage decreased (-0.06%) to 95.335% when pulling 8c0f04b184079b0b4dbdb2081630ffd9fa466f26 on breaker-client-v4 into 615c1d4df904199786914c95b882e664e7e87e10 on master.


Update README.rst to indicate the proper version of LLVM

RuntimeError: Building llvmlite requires LLVM 4.0.x

Codecov Report

Merging #2388 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   86.22%   86.22%
=======================================
  Files         313      313
  Lines       59301    59301
  Branches     6407     6407
=======================================
  Hits        51132    51132
  Misses       7129     7129
  Partials     1040     1040

Thanks!  Somehow we missed this.


MathJax requires unsafe "Content Security Policy"

The current MathJax implementation uses following features that are not considered safe in modern world and cannot be used with default Content-Security-Policy (http://www.w3.org/TR/CSP/) headers:

JavaScript evaluation of strings (new Function() with a string or eval()) (1)
Inline style attributes inserted via JavaScript (2)

It's debatable if issue (2) should be fixed but at least (1) should be fixed because Content-Security-Policy does not have enough granularity to allow MathJax to execute as a trusted script and in the same time do not interpret every other JavaScript file as specially trusted. Currently, if one wants to use MathJax, he must allow eval() everywhere. The issue (1) also causes bug #130 (MathJax is incompatible with ECMAScript 5 strict mode).
Currently the only way to make MathJax to work, even if one uses locally installed MathJax code, is to use following CSP HTTP headers (the deprecated "options" header is included for Firefox 13.0  and lesser):
X-Content-Security-Policy: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline'; options eval-script
X-WebKit-CSP: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline'
Content-Security-Policy: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline'

These headers will allow some CSP provided protection and still allow MathJax to work, if MathJax is distributed from the same origin as the page content.

I am still seeing this issue. See https://github.com/mathjax/MathJax/issues/1988.

@kaushalmodi, see my comment above about how to avoid the problem, or my comment to the issue you link to.  You have to change how you configure MathJax if you are using a CSP that restricts script execution.

Was (2) in the original issue ever resolved? It seems that mathjax v3 still inserts

For MathJax version 3, the issue still exists.
I am writing Tampermonkey scripts which can't include other script file to load the configuration, also I will get CSP related errors while MathJax loading its fonts.

@scruel,  you say:

For MathJax version 3, the issue still exists.

Your issue is not the same as either (1) or (2) in the original message.  (1) has been resolved in v3 (and could be avoided in v2 by using the MathJax={...} form of configuration).  (2) is not going to be something we are able to avoid easily, but there is code in a comment to another issue that may be able to address that using nonces (but read the full thread for some caveats).
To be able to use MathJax with a CSP, you would need to include the CSN from which you obtain MathJax in the font-src and script-src directives (as well as allowing in-line styles).  If you are trying to insert MathJax into a page that has a CSP that you don't control, and if the CDN is not included there, then you may not be able to do it.
You may have better luck using the SVG output rather than CHTML, since that doesn't load fonts, only javascript, but if you can't load external javascript files, then that may limit what you are able to do.


error 3050003: assertion failure with message: no balance object found

i am facing this error creating new account using system newaccount please help

Apologies but this does not seem to be related to the eosjs library since you are only using cleos.


Virtual scroll does not work in an empty conditional element

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[ X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When using virtualScroll in a element that renders on condition (among others *ngIf) and the element is completely empty (besides the virtual scroll elements) the list will not render. Putting in anything inside the div will make it appear  (even a   will do)
Expected behavior:
It renders always
Steps to reproduce:
http://plnkr.co/edit/zJSEfkUWb2c1GzxTXKDV?p=preview
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
version 3.6.0

hmm, the behaviour is a bit ore weird: it needs a change-detection cycle to kick in it seems

also in more complex situation (like nesting a ngIf inside a  ngSwitchCase which contains a list, i can not get the list to show up

I'm experiencing the same issue. @Remco75 if you found a stable solution, I am very interested.

@Ozzyris  nope, atm I can not use vritualscroll in my usecase. I hope someone has a suggestion ( or better yet, a fix ;-))

I found a fix to make it work in my case, by replacing "*ngIf=" by "[hidden]=" ! Hope that can help.

Cool Will try that. But the whole point of virtual scroll is to be as cheap as possible.... That's why the if, to render less, with the least amount of bindings.. so still I think this needs a fix

Yes you are right, let's just say that's can be a quick fix until we have a proper one.

Hello all! I am going to close this issue as a duplicate of https://github.com/ionic-team/ionic/issues/9655. Thanks!

@jgw96 sorry, missed the double. But that has been open for a long time. Is there any change it will be resolved any time soon?

"[ngClass]='{'hide':!data}'" replace "*ngIf" it works for me


Minizip implementation

We removed minizip early on when we were trying to shed as much as possible of the unrelated code and workarounds for all kinds of old scenarios. The Chromium people have spoken up regarding minizip though, since they depend on minizip for unpacking things such as addons in .zip files. That makes sense since they already use zlib and there is little point in having two nearly identical libraries in the code.
contrib/minizip needs to be fetched from zlib, and all the old ifdef blocks that are related to zip-support needs to be implemented as well. Most can likely be copied over nearly as-is, but some might need a bit more TLC due to unrelated changes in zlib-ng.
I am hoping some volunteer will step up and try their hands on this task, as this is the last big must-have feature that remains on our TODO before releasing a stable version of zlib-ng. This task should not be very difficult, and it does not require an intimate knowledge of zlib internals or the deflate algorithm, so it should be a good task for someone wanting to get their feet wet without requiring a life-west.

I compiled zlib-ng against my minizip fork at https://github.com/nmoinvaz/minizip. In my repository there is a test folder with test.py which failed to create a 50MB zip file and dumped a bunch of "bit length overflow" errors. So it looks like there is some additional work that may needed.

"bit length overflow" isn't actually an error, it's just a trace message for handling a special case. I suspect the real error is elsewhere but no trace messages are printed as the code is missing.

You are right. I had mistaken them for errors and they were only trace messages. All my tests passed.
You mentioned in this issue that there were #defines that needed to be imported from the stock zlib - but I'm not sure which ones you were referring to.
I did notice that the typedef for z_crc32_t is missing which is in zlib 1.2.6+.
typedef unsigned long z_crc_t;
I had difficulties getting the repo working without using ./configure on Windows. I think it was missing zconf.h. I like how in the stock zlib, everything is ready to go and don't need to run ./configure - zconf.h already exists.
Anyways that is my feedback.

Hmm, maybe I was remembering wrong. I might have remembered the PKZIP_BUG_WORKAROUND define, but that is still present in our code. (Dunno whether it actually works in all codepaths though, that would likely be a good candidate for a unit-test).
In that case, if we could get inter-compatibility, as a sub-module or something (with a git sub-module link or manually), that would be great. Your fork looks like it matches our work quite well, and we could recommend using your minizip in combination with our zlib fork.
There would of course be a need for changes, probably on both ends, since our code has evolved quite a lot from stock zlib. We have focused a lot on making the code easier to understand for outsiders, without lots of the "portability" stuff for really really old systems and compilers and using standard types where appropriate.
Regarding ZLIB_COMPAT, we will probably want to focus on the zlib-ng API instead of the old zlib API as default for zlib-ng. After all, dynamically linked zlib-ng in compat mode will not work well in a process that requires another library that pulls in stock zlib as well. If you use the zlib-ng API though, there will be no conflict. For example you can compile nginx with zlib-ng without getting into trouble because openssl loads stock zlib into the process also.
In any case, thanks for testing, this is great news. 👍

Btw, feel free to join us in the irc channel #zlib-ng on freenode. I am always logged in, but not always present. I will reply eventually though :)

@nmoinvaz z_crc_t and few other zlib-specific types were deprecated and removed in zlib-ng... We use now uint32_t for checksum related functions (crc32, adler32)...
On Windows, you should just copy zconf.h.in to zconf.h (or zconf-ng.h.in to zconf-ng.h) like the Visual C++ Makefile in win32 subdirectory does... Otherwise you might get error about missing unistd.h.
zconf.h is used in zlib-compatibility mode (when ZLIB_COMPAT is defined) and zconf-ng.h is used for new code.

Sounds good. Let me know if there are any changes that I can make to make things better to integrate with. The only thing I can see so far is the missing typedef for z_crc32_t.

I have made some changes and removed the need for z_crc_t.

Sounds like we should get this tested, documented and perhaps included as a git submodule.

CMake has external project support if you wanted to use that. Then you wouldn't need a submodule. That of course assumes youd just build it through CMake and not autotools though.
https://cmake.org/cmake/help/v3.12/module/ExternalProject.html

I like that idea. However I am having a bit of difficulty with cmake. I was trying to get minizip to put its output binaries in the same directory as zlib when building, but it seems that with ExternalProject_Add it is not possible to specify where the build gets put - it seems to always want to install the project.
option(WITH_MINIZIP "Build minizip library" ON)
if (WITH_MINIZIP)
    get_target_property(ZLIB_LIBRARY zlibstatic LOCATION_DEBUG)
    message(STATUS "Hello")
    message(STATUS ${CMAKE_INSTALL_PREFIX})
    ExternalProject_Add(minizip
        GIT_REPOSITORY    https://github.com/nmoinvaz/minizip.git
        GIT_TAG           master
        SOURCE_DIR        "${CMAKE_BINARY_DIR}/minizip"
        INSTALL_DIR       "${CMAKE_BINARY_DIR}/minizip-install"
        BINARY_DIR        "${CMAKE_BINARY_DIR}/minizip-build"
        CMAKE_ARGS
            -DZLIB_LIBRARY=${ZLIB_LIBRARY}
            -DZLIB_INCLUDE_DIR=${CMAKE_SOURCE_DIR}
            -DBUILD_TEST=ON
    )
endif()

Can we close this bug now?

That is unfortunate, since that does not allow configuring of zlib-ng parameters. Also, can it use a shared zlib-ng library in non-compat mode?

No, it will only work with ZLIB_COMPAT=ON which it sets by default. I haven't found a way to easily pass in parameters to ExternalProject_Add call from command line.

I think it is better for zlib-ng not to include any contribs - which is one thing that you removed from the old zlib. It is better that projects that utilize zlib-ng reference it, rather than the other way around imo.

I think this can be closed unless there is something else that needs to be done.

My minizip repository has now been moved to zlib-ng organization.

My minizip repository has now been moved to zlib-ng organization.


Desktop App uninstall

Documentation for: https://mattermost.atlassian.net/browse/MM-48999

Thanks, @jupenur! I've incorporated your feedback in another commit.


fix withBearerToken not working

It's worth noting that the check failure is a result of upstream recent commits, not this PR

I fixed dev feel free to pull in

should be good like this
what do you think @wnxd?

thank you for your contribution

Yeah. Your changes are better.


Adding -remove and -help command-line flags

I've been using cshatag for a while and thought I'd tried my hand at providing feature request #5.
Using the flags package gives a '-help' flag which displays usage. This requires some alteration of the code for parsing args.
I've also added a '-remove' flag which calls removeAttr to remove the extended attributes from the file argument(s).
Example use:
Tag a file:
$ cshatag foo.txt
<outdated> foo.txt
 stored:<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000<PHONE_NUMBER>.000000000
 actual: 181210f8f9c779c26da1d9b2075bde0127302ee0e3fca38c9a83f5b1dd8e5d3b<PHONE_NUMBER>.617003539

Remove a tag:
$ cshatag -remove foo.txt
<removed xattr> foo.txt

Subsequent attempts at removal write to stderr:
$ cshatag -remove foo.txt
Error: xattr.FRemove foo.txt user.shatag.ts: no data available  xattr.FRemove foo.txt user.shatag.sha256: no data available

Merged as https://github.com/rfjakob/cshatag/commit/25bc11d02734723ce35cc2a3c7681b006a0b4427 , thanks!


Failing on Nano

VERBOSE: [NANOWINPE001]: LCM:  [ Start  Set      ]  [[xTimeZone]TimeZoneExample]
VERBOSE: [NANOWINPE001]:                            [[xTimeZone]TimeZoneExample]
Performing the operation "Replace the System Time Zone" on target "'Dateline St
andard Time'".
VERBOSE: [NANOWINPE001]:                            [[xTimeZone]TimeZoneExample]
Setting the TimeZone.
(3) : The type or namespace name 'Linq' does not exist in the namespace
'System' (are you missing an assembly reference?)
(2) : using System.Collections.Generic;
(3) : >>> using System.Linq;
(4) : using System.Text;
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
(210) : 'Registry' is inaccessible due to its protection level
(209) :         {
(210) : >>>             var regTimeZones =
Registry.LocalMachine.OpenSubKey("SOFTWARE\Microsoft\Windows
NT\CurrentVersion\Time Zones");
(211) :             // Print out all the possible time-zones.
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
(216) : 'RegistryKey.GetSubKeyNames()' is inaccessible due to its protection
level
(215) :             //}
(216) : >>>             var subKey = regTimeZones.GetSubKeyNames().Where(s =>
s == name).First();
(217) :             string daylightName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Dlt");
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
(217) : 'RegistryKey.OpenSubKey(string, bool)' is inaccessible due to its
protection level
(216) :             var subKey = regTimeZones.GetSubKeyNames().Where(s => s ==
name).First();
(217) : >>>             string daylightName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Dlt");
(218) :             string standardName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Std");
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
(218) : 'RegistryKey.OpenSubKey(string, bool)' is inaccessible due to its
protection level
(217) :             string daylightName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Dlt");
(218) : >>>             string standardName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Std");
(219) :             byte[] tzi =
(byte[])regTimeZones.OpenSubKey(subKey).GetValue("TZI");
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
(219) : 'RegistryKey.OpenSubKey(string, bool)' is inaccessible due to its
protection level
(218) :             string standardName =
(string)regTimeZones.OpenSubKey(subKey).GetValue("Std");
(219) : >>>             byte[] tzi =
(byte[])regTimeZones.OpenSubKey(subKey).GetValue("TZI");
(220) :             var regTzi = new RegistryTimeZoneInformation(tzi);
+ CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:
) [], CimException
+ FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.
AddTypeCommand
+ PSComputerName        : localhost
Cannot add type. Compilation errors occurred.
+ CategoryInfo          : InvalidData: (:) [], CimException
+ FullyQualifiedErrorId : COMPILER_ERRORS,Microsoft.PowerShell.Commands.Ad
dTypeCommand
+ PSComputerName        : localhost
Unable to find type [Microsoft.PowerShell.xTimeZone.TimeZone].
+ CategoryInfo          : InvalidOperation: (Microsoft.PowerShell.xTimeZon
e.TimeZone:) [], CimException
+ FullyQualifiedErrorId : TypeNotFound
+ PSComputerName        : localhost
VERBOSE: [NANOWINPE001]: LCM:  [ End    Set      ]  [[xTimeZone]TimeZoneExample]
in 11.6960 seconds.
The PowerShell DSC resource '[xTimeZone]TimeZoneExample' with SourceInfo
'C:\share\SetTimeZone.ps1::21::9::xTimeZone' threw one or more non-terminating
errors while running the Set-TargetResource functionality. These errors are
logged to the ETW channel called Microsoft-Windows-DSC/Operational. Refer to
this channel for more details.
+ CategoryInfo          : InvalidOperation: (:) [], CimException
+ FullyQualifiedErrorId : NonTerminatingErrorFromProvider
+ PSComputerName        : localhost
The SendConfigurationApply function did not succeed.
+ CategoryInfo          : NotSpecified: (root/Microsoft/...gurationManager
:String) [], CimException
+ FullyQualifiedErrorId : MI RESULT 1
+ PSComputerName        : localhost
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 22.477 seconds

Good catch @uday31in!
@TravisEz13 - I'm thinking we're going to need to check for Nano Server (like is being done in xPSDesiredStateConfiguration/xGroup) and use TZUTIL.EXE or .NET Core specific CS code. I haven't looked closely at .NET Core yet, but I imagine it shouldn't be too difficult to rework a copy of the CS code to work with .NET Core?

@PlagueHO, there are timezone CmdLets on Nano. Set-TimeZone  and Get-TimeZone

@TravisEz13  - excellent. I'll make the change over the next week and submit the PR. Good to know!

@TravisEz13, @kwirkykat - I'm getting started on this one one. Is it also worth converting it over to HQRM naming ensuring it meets the HQRM guidelines at the same time? It should already meet the minimum requirements anyway.

@TravisEz13 - I haven't been able to locate these cmdlets in Nano Server TP5. Are they available in that version or are these cmdlets going to be in the RTM?
If they're in the RTM, are you able to get me documentation on what the parameters for these cmdlets?

@PlagueHO Do you have my email?  Can we take this offline?  If not, message me on twitter and I'll give you my email.

@travisez13  - working on this now. Changing the resource to use these cmdlets whenever they are available - not just in nano.

@TravisEz13 , @uday31in - I've finished the reworking of this resource to use Get-Timezone/Set-Timezone if the cmdlets are available.
So it'll work on WS2016 and Nano Server RTM (when they are released around Sept 26) and the Win10 Anniversary Edition. However, because Nano server in TP5 doesn't include these cmdlets, it won't actually fix the TP5 Nano Server. But to be honest I don't see this is worth addressing (less than 2 months till Nano RTM which will include these cmdlets).

I tend to agree


try microbundle

I should try this one https://www.npmjs.com/package/microbundle

implemented: https://github.com/nfq-eta/react-router4-with-layouts/commit/15cbe9c1d5510f773fef19486d5acc08d33abcb0


Update title, description, query names of thrifty controls. closes #47

Checklist

[ ] Issue(s) linked

Closing this PR since it comprises a lot of breaking changes (renaming the control references). Preserving the branch so that we could use it for future references.

This PR is not currently planned for merge, closing for now.


fix(tests): Updating integration tests

:tada: This PR is included in version 5.8.10 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


add visit method

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.09% :tada:

Comparison is base (e0c731c) 97.87% compared to head (985f238) 97.96%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   97.87%   97.96%   +0.09%
==========================================
  Files           5        5
  Lines         235      246      +11
  Branches       61       64       +3
==========================================
+ Hits          230      241      +11
  Misses          2        2
  Partials        3        3

Files Changed
Coverage Δ

revolt/_substitutor.py
96.96% <100.00%> (+0.19%)
:arrow_up:

revolt/errors/__init__.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Text link style

We discussed this in Design Jam this morning (5/8/24), and seems like there is an actual need for it.
For better functionality and consistent performance of the ghost-hover text buttons, we should have a new style for text links that go to external sites.
Ghost text buttons for internal pages. Text links for external pages.
We looked at an underline style this morning. Good place to start.

Text links are here in Design System

@decentdao/design does this issue still need to be open?

I believe this was updated and is reflected live.
@xraystyle1980 please confirm and close.


bug: temporal join on CTE is lost silently

We need return an error to tell user it is not supported
dev=> create table stream(id1 int, a1 int, b1 int) APPEND ONLY;
create table version(id2 int, a2 int, b2 int, primary key (id2));

NOTICE:  APPEND ONLY TABLE is currently an experimental feature.
CREATE_TABLE
CREATE_TABLE
dev=> explain
create materialized view mv as
select id1, a1, id2, a2 from stream left join version FOR SYSTEM_TIME AS OF PROCTIME() on id1= id2
dev-> ;
                                                                              QUERY PLAN

------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------
 StreamMaterialize { columns: [id1, a1, id2, a2, stream._row_id(hidden)], stream_key: [stream._row_id, id1], pk_columns:
 [stream._row_id, id1], pk_conflict: NoCheck }
 └─StreamExchange { dist: HashShard(stream.id1, stream._row_id) }
   └─StreamTemporalJoin { type: LeftOuter, append_only: true, predicate: stream.id1 = version.id2 }
     ├─StreamExchange { dist: HashShard(stream.id1) }
     │ └─StreamTableScan { table: stream, columns: [id1, a1, _row_id] }
     └─StreamExchange [no_shuffle] { dist: UpstreamHashShard(version.id2) }
       └─StreamTableScan { table: version, columns: [id2, a2] }
(7 rows)

dev=> explain
create materialized view mv as
with version as (select * from version)
select id1, a1, id2, a2 from stream left join version FOR SYSTEM_TIME AS OF PROCTIME() on id1= id2;
                                                                              QUERY PLAN

------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------
 StreamMaterialize { columns: [id1, a1, id2, a2, stream._row_id(hidden)], stream_key: [stream._row_id, id1], pk_columns:
 [stream._row_id, id1], pk_conflict: NoCheck }
 └─StreamExchange { dist: HashShard(stream.id1, stream._row_id) }
   └─StreamHashJoin { type: LeftOuter, predicate: stream.id1 = version.id2 }
     ├─StreamExchange { dist: HashShard(stream.id1) }
     │ └─StreamTableScan { table: stream, columns: [id1, a1, _row_id] }
     └─StreamExchange { dist: HashShard(version.id2) }
       └─StreamTableScan { table: version, columns: [id2, a2] }
(7 rows)

Actually, you should try because FOR SYSTEM_TIME AS OF PROCTIME() is binded to scan. 🥵
explain
create materialized view mv as
with version as (select * from version  FOR SYSTEM_TIME AS OF PROCTIME())
select id1, a1, id2, a2 from stream left join version on id1= id2;

So we should report an error when trying to use any relation we can't scan as the reference table in temporal join?


Allow data-attributes

Normally you are allowed to write attribute directives as either checklist-model or data-checklist-model to be html5 compatible. $attrs normalizes that.
However, using data-checklist-model crashes chrome in your jsfiddle example and on my local I get a recursion problem.
Edit: the problem happens only with checklist-model, not with checklist-value.

+1.  I just wasted an entire day tracking this down and came up with the same solution as @tdakhla

@tdakhla take a look at my suggestion here on how to use Angular's attribute normilization.

@samherrmann Yeah that's a much better approach.  Updated my comment.

Could you please check the current version and how it solves this issue?


NTR: IgG4-related eosinophilic angiocentric fibrosis

see https://github.com/obophenotype/human-phenotype-ontology/issues/3974
We have MONDO_0018676 'eosinophilic angiocentric fibrosis' in MONDO, and it is a child of 'IgG4-related disease', so maybe this should just be a synonym.

looks like 'IgG4-related eosinophilic angiocentric fibrosis' already exists as a synonym, closing this ticket


Add delegates route

Closes #101

Add the endpoint GET delegates
Add some tests

Coverage increased (+1.4%) to 91.774% when pulling ea3f1eb7d383d09c9af8ccd6ae72698488e8bd1c on add_get_delegates_route into 679559d6ea090d0e527f96c6657050920a0d9601 on main.

@fmrsabino  @hectorgomezv  Added validation of query parameters https://github.com/5afe/safe-client-gateway-nest/pull/133/commits/ca373efa3eafadba01813394915ab90945b5d80e


How to set: FI_EFA_FORK_SAFE=1 ?

Hi team, I was recently playing with Llama 2 on inf2.24xlarge instance. The AMI I am currently using is: AWS Deep Learning AMI Neuron PyTorch 1.13 (Amazon Linux 2).
The Llama2 model is getting compiled and running successfully. While running the model, I also observed the instance performance using neuron-top, and the model seems to be utilizing all the neuron-cores from all neuron-core-devices.
But, while compiling the model, I get the following message:
2023-Sep-05 13:08:49.0371 20080:29631 [0] init.cc:97 CCOM WARN Linux kernel 5.10 requires setting FI_EFA_FORK_SAFE=1 environment variable.  Multi-node support will be disabled.
Please restart with FI_EFA_FORK_SAFE=1 set.

Can someone please guide me in understanding if this is something of concern and if yes how to resolve this ?

Hi @yogendra-yatnalkar, you can set FI_EFA_FORK_SAFE the same way you are setting other environment variables that control the compilation and execution.  However, the setting is only applicable to EFA and has no effect if your model runs on a single instance, in which case your can ignore the warning.

Hi @jeffhataws, understood the point, thankyou.


[Enhancement] Add env vars for AWS KMS usage

Description
See response here. When using an AWS KMS server with a verifyImages rule, the Kyverno Deployment should have to specified env vars present where the key is located.
Slack discussion
https://kubernetes.slack.com/archives/CLGR9BJU9/p1663749524439649

This blog post doesn't mention about setting those env vars so I'm confused...

It seems like based on responses in the thread linked in the first post that this isn't necessarily the solution. Closing issue until we understand this situation better.


Support HotReloading

This would be a major change to the core assets, but would potentially be a great help for workflow.  We would have to decide if it is possible or even worth it.  Major changes would include.

Making sure all leap classes could be serialized by unity
No more dictionaries :(
uint enums are not supported
Cyclic references are not supported
Many low level types are not supported like IntPtr
Making sure that we could restart the connection / worker thread upon a hot reload without issue

Gonna close this for now, if we want to ever do the work to support it it will need to become a full milestone


DevEx: Autoconfig does not detect lazily required deps

stylelint uses import-lazy to import a number of things
possible solutions

add a special cased for stylelint
add a heuristic for import-lazy
if imports are missing that are present in dependencies, do something
generate config not by static analysis but runtime accesses

also plugin systems like browserify plugins + transforms are commonly accessed by name instead of an imported reference, making those imports not analyzed statically


Remove last vrf output

Explain your changes:
This PR remove last_vrf_output from preconditions.
Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!ci-build-me

@ghost-not-in-the-shell Just a nit, for future- Do you mind adding commit messages related to the change in the commit?  address deepthi's comment doesn't help at all when someone's looking at commit history.

!ci-build-me

!ci-build-me

!approved-for-mainnet

!ci-build-me

!approved-for-mainnet

!ci-build-me

!approved-for-mainnet

Version linter failures are on V1 types for berkeley


[HELP] ImportError: cannot import name 'JSONDecodeError' from 'requests.exceptions'

I've been using sentinelhub for some of my research projects for the past 2 years. I have been using the SentinelHubRequest function to download images.
I run my code on Google Colab
my python version is Python 3.7.13
requests Version: 2.23.0
sentinelhub Version: 3.6.2
Question
When I run
!pip install sentinelhub
and then when I run the following import statement
from sentinelhub import MimeType, CRS, BBox, SentinelHubRequest, SentinelHubDownloadClient, DataSource, bbox_to_dimensions, DownloadRequest, DataCollection
I get the following error
ImportError: cannot import name 'JSONDecodeError' from 'requests.exceptions' (/usr/local/lib/python3.7/dist-packages/requests/exceptions.py)
this is the complete stack trace
      4
      5 from ._version import __version__
----> 6 from .api import (
      7     BatchCollection,
      8     BatchRequest,

[/usr/local/lib/python3.7/dist-packages/sentinelhub/api/__init__.py](https://localhost:8080/#) in <module>()
      3 """
      4
----> 5 from .batch import (
      6     BatchCollection,
      7     BatchRequest,

[/usr/local/lib/python3.7/dist-packages/sentinelhub/api/batch.py](https://localhost:8080/#) in <module>()
     21 from ..geometry import CRS, BBox, Geometry
     22 from ..type_utils import Json, JsonDict
---> 23 from .base import BaseCollection, SentinelHubFeatureIterator, SentinelHubService
     24 from .process import SentinelHubRequest
     25 from .utils import datetime_config, enum_config, remove_undefined

[/usr/local/lib/python3.7/dist-packages/sentinelhub/api/base.py](https://localhost:8080/#) in <module>()
     14 from dataclasses_json import dataclass_json
     15
---> 16 from ..base import FeatureIterator
     17 from ..config import SHConfig
     18 from ..data_collections import DataCollection

[/usr/local/lib/python3.7/dist-packages/sentinelhub/base.py](https://localhost:8080/#) in <module>()
     10
     11 from .config import SHConfig
---> 12 from .download import DownloadClient, DownloadRequest
     13 from .os_utils import make_folder
     14 from .type_utils import JsonDict

[/usr/local/lib/python3.7/dist-packages/sentinelhub/download/__init__.py](https://localhost:8080/#) in <module>()
      5 from .client import DownloadClient
      6 from .request import DownloadRequest
----> 7 from .sentinelhub_client import SentinelHubDownloadClient
      8 from .sentinelhub_statistical_client import SentinelHubStatisticalDownloadClient
      9 from .session import SentinelHubSession, SessionSharing, SessionSharingThread, collect_shared_session

[/usr/local/lib/python3.7/dist-packages/sentinelhub/download/sentinelhub_client.py](https://localhost:8080/#) in <module>()
     18 from .rate_limit import SentinelHubRateLimit
     19 from .request import DownloadRequest
---> 20 from .session import SentinelHubSession
     21
     22 LOGGER = logging.getLogger(__name__)

[/usr/local/lib/python3.7/dist-packages/sentinelhub/download/session.py](https://localhost:8080/#) in <module>()
     14 from oauthlib.oauth2 import BackendApplicationClient
     15 from requests import Response
---> 16 from requests.exceptions import JSONDecodeError
     17 from requests_oauthlib import OAuth2Session
     18
ImportError: cannot import name 'JSONDecodeError' from 'requests.exceptions' (/usr/local/lib/python3.7/dist-packages/requests/exceptions.py)

Is there anything wrong with the versions that I am working with ?
Would love to hear back as soon as possible!

Hi @pranavsinghal30,
The solution is to upgrade requests dependency package to the latest version.
In the latest release of sentinelhub-py we forgot to put a version restriction for that to requests>=2.27.0. Sorry about that.