State Changes from List to Tensor After Calling Compute()

🐛 Bug
I was logging a custom Metric result using the logger provided by LightningModule. The codes runs on 2 GPUs with ddp. While a list state whose dist_reduce_fx is "cat" was synchronized by calling compute() , I realized the behavior in training_step() and validation_step() were different.
The state in training_step() where on_step=True and on_epoch=False (default setting for training) after calling compute() was always a list. However, in validation_step() where on_step=False and on_epoch=True (default setting for validation), the state became a Tensor. Such behavior is not explained in the doc.
To Reproduce

Metric and Logging Results
Codes
import logging

import torch
from torchmetrics import Metric
from torchmetrics.functional.retrieval import retrieval_normalized_dcg

class MyMetric(Metric):
    def __init__(self, top_k):
        super().__init__()
        self.top_k = top_k
        self.add_state("state_1", default=[], dist_reduce_fx="cat")

    def update(self, preds: Tensor, target: Tensor):
        assert preds.shape == target.shape
        self.state_1 += [self._metric(p, t) for p, t in zip(preds, target)]

    def compute(self):
        if isinstance(self.state_1, list):
            logging.warning(f"self.state_1.size(): {len(self.state_1)}")
            return torch.stack(self.state_1).mean()
        logging.warning(f"self.state_1.size(): {self.state_1.size()}")
        return self.state_1.mean()

    def _metric(self, preds: Tensor, target: Tensor):
        return retrieval_normalized_dcg(preds, target, k=self.top_k).float()

Log Outputs
Training:
WARNING:self.state_1.size(): 40
Validation:
WARNING:self.state_1.size(): torch.Size([80])

Expected behavior
The state is always what it is defined in add_state(), i.e., a list.
Environment

TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source):
0.10.3 (conda-forge)
Python & PyTorch Version (e.g., 1.0):
3.10.12
Any other relevant information such as OS (e.g., Linux):
pytorch: 1.13.1
pytorch-lightning: 1.9.4
Linux: 5.15.0-78-generic

Additional context

@donglihe-hub, thanks for raising this issue.
I definitely see the problem that you have pointed out, the core problem with changing the behaviour being backwards compatibility. This behaviour has been present since the start of torchmetrics and we have internally really not considered it a problem. The solution in our own metrics are just to call the dim_zero_cat function in compute:
from torchmetrics.metric import Metric
from torchmetrics.utilities.data import dim_zero_cat
class MyMetric(Metric):
     ...
     def compute(self):
         state_1 = dim_zero_cat(self.state_1)  # the returned value will always be a tensor

which secures that everything is a tensor before doing any computation.
cc: @justusschock opinions on this issue? is it something we should change?

@donglihe-hub, thanks for raising this issue. I definitely see the problem that you have pointed out, the core problem with changing the behaviour being backwards compatibility. This behaviour has been present since the start of torchmetrics and we have internally really not considered it a problem. The solution in our own metrics are just to call the dim_zero_cat function in compute:
from torchmetrics.metric import Metric
from torchmetrics.utilities.data import dim_zero_cat
class MyMetric(Metric):
     ...
     def compute(self):
         state_1 = dim_zero_cat(self.state_1)  # the returned value will always be a tensor

which secures that everything is a tensor before doing any computation.
cc: @justusschock opinions on this issue? is it something we should change?

Thank you for your answer. I think maybe it should be mentioned in IMPLEMENTING A METRIC? Otherwise users have no way to know that before they actually coming up with the "bug".

@donglihe-hub you are completely right.
That page have not been updated in a long time a definite need an overhaul. Let me try to figure out some more examples and hopefully we can also figure out the issue you have reported in #2022.


Interaction inconsistence: Coupons, shopping cart

Environment Details
Branch: origin/feature/PANDA-3191-apply-coupon-component
Steps to Reproduce
Add items to the shopping cart -> navigate to the shopping cart -> Click "Enter or remove your coupon codes." link.
Observed Results
The page scrolls to the coupon component.
Expected Results
The focus should be set on the "Coupon Code" input line.

Repository Used
main repo, branch: origin/feature/PANDA-3191-apply-coupon-component

fixed
click the anchor, scroll to enter coupon with focus

we ended up moving the coupon entryto right side,clsoing


chore: merge staging/v1 into main

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Blocked on upstream PR merging so we can change the ref

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

267 of 616 (43.34%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.3%) to 79.139%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/ec2nodeclass_defaults.go
0
1
0.0%

pkg/apis/v1/ec2nodeclass_status.go
0
9
0.0%

pkg/apis/v1/ec2nodeclass.go
7
20
35.0%

pkg/apis/v1/ec2nodeclass_validation.go
145
207
70.05%

pkg/apis/v1/zz_generated.deepcopy.go
67
331
20.24%

Totals

Change from base Build<PHONE_NUMBER>:
-3.3%

Covered Lines:
5789

Relevant Lines:
7315

💛  - Coveralls


paper citation

Hello, I am very interested in your research. Do you have a paper? I want to cite your work in my paper

Hello @TQCAI No there is no published paper associatted with this work. There used to be a blog article you could cite but after selling the company, it was taken down by the new owners.

@TQCAI I will not require any citations but might be able to help you if you absolutely need one

email me a<EMAIL_ADDRESS>

I also think i put up a draft copy of the original blog article in a pull request against the hyperopt repository, but it never got merged


Revert "Feature Additions/Fixes"

Reverts MrPotatoBobx/FetchCord#174
Sorry it's removing some of my previous changes, i need to read it again and redo the merge

Do you need me to fix anything?


When default value is set to now , AM/PM isn't picking

The now value for default attribute shows the time(hour and minute) correctly but AM/PM is always on PM.

This issue should be fixed now


Fix the style of timeline cards

The Card over wraps when description of the card is long.
I should consider that situation to fit the width of the mobile timeline.

Fixed.
Just removed flex property


Web: Add Dockerfile

Problem: Currently, the template project doesn't have a Dockerfile image. The actual Dockerfile is rather straightforward and we can probably find an acceptable solution online.
Acceptance criteria:

Web project has a Dockerfile
Dockerfile is able to be built successfully
Docker image runs web UI

Other: I (Reece) should upgrade my next-js template project to also have the docker file.

PR: #10


Use .get() to avoid panic

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/3190 by avoiding panic. Close if not helpful
Rationale for this change
good first issue
What changes are included in this PR?
simple api usage change.
Are there any user-facing changes?
solves error in scalar values less than 2 characters long I believe?

Codecov Report

Merging #3201 (e60f1b0) into master (929eb6d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head e60f1b0 differs from pull request most recent head 6d67ce3. Consider uploading reports for the commit 6d67ce3 to get more accurate results

@@            Coverage Diff             @@
##           master    #3201      +/-   ##
==========================================
- Coverage   85.87%   85.87%   -0.01%
==========================================
  Files         291      291
  Lines       52885    52885
==========================================
- Hits        45415    45414       -1
- Misses       7470     7471       +1

Impacted Files
Coverage Δ

datafusion/physical-expr/src/planner.rs
95.27% <100.00%> (ø)

datafusion/expr/src/logical_plan/plan.rs
77.60% <0.00%> (-0.18%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Same syntax also appears here -> https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/execution/context.rs#L1565
I'm not sure how that gets triggered, but it would make sense to apply the same kind of fix there also.

Can you please add a regression test for this case?
Whoops! misread the issue and thought there was one. Adding now!

@alamb knowing where to test this was not immediately obvious to me + given there was the same issue in another place I refactored the functionality into common and tested it there. Will need to know if the test cases are accurate. Let me know what you think of this approach, I can easily walk it back. I also, cleaned up the other line mentioned in the issue but will also need some guidance where the proper place to test that is.

@jklamer Could you run cargo fmt to fix the lint issue?

@andygrove absolutely. I was scared of too much reformatting before. Didn't have time last night, but will tonight

@alamb ran cargo fmt this time


Workflow Updates

Features

Add a workflow for building and publishing the maven package to the Github Maven repository
Add a workflow for running unit tests

Does this jar end up anywhere other than the github maven repo?

Also, just from a build / JDK support perspective, whats the point of the Nashorn exceptions? If you need some specific exception types that don't exist in the default JDK why not just build them? Cause we end up in a situation where they either don't exist, or we're pulling in a Javascript engine purely to provide some form of Java based exception handling. I'm not sure what the reasoning is there.

@buggtb the nashhorn stuff are not exceptions, they're decorators, and they've been used for a bit to mark deprecated code.
Also, for now, it only goes to the github repository, I spent some time figuring out the whole deploy scheme for deploying to the Maven Central Repo it involves setting up am OSSH account and all. So for the time being I'm just playing around with setting it up here.
Github's Maven repos seem to work fine, the only minor annoyance is that you have to specify the repo url for Maven to resolve it.

The problem with github and maven, is to use the github maven repo, you have to specify a public token for your github account to build it. Which is why I used Gitlab, because you don't. As this lives both in this repo and I've been asked by Matt to ensure I get this sync'd upstream ASAP, we shouldn't be merging in a PR that requires a repo authentication because then upstream users will have a dependency on a working github account in their CI pipelines, and ours.

I'm not sure what you mean by the github-user building it. The token used is auto-generated by github at the time the runner is spawned, and ostensibly is unique for every new runner (every time a workflow runs).
There's no manual generation of any token, the workflow could be transplanted to a wholly new repo here on github and still work.


Text filter that draws text with the given options

Closes: #9238

@bep I'm creating a Text filter that overlays the given text on an image according to the given options. I would like to hear your thoughts on the current approach, and specifically on how you would like to handle fonts.
I was thinking that fonts could be retrieved using the resources.Get function, from local storage or from a remote location such a Google Fonts. While the method below loads the font and passes it on as an option (as resources.resourceAdapter), this doesn't allow me to use it.
{{ $font := resources.Get "https://github.com/google/fonts/raw/main/apache/roboto/static/Roboto-Regular.ttf" }}
{{ $img := resources.Get "/images/open-graph-bg.png"}}
{{ $img = $img.Filter (images.Text "This text is placed over the image" (dict
    "color" "#ffffff"
    "size" 50
    "x" 100
    "y" 200
    "font" $font
))}}

While the method below loads the font and passes it on as an option (as resources.resourceAdapter), this doesn't allow me to use it.

Without discussing if it's a great idea or not, I'm not sure what you mean by "doesn't allow me to use it"? You should be able to cast it to resource.Resource.
That said, I think this issue would be mentally easier to manage if we took it in two steps and just used the default font in the first iteration.

If we drop the font discussion for a minute; I tested this, and it works pretty great.
{{ $img = $img.Filter (images.Text "This text is placed over the image" (dict
    "color" "#ffffff"
    "size" 50
    "x" 100
    "y" 200
))}}

I have initial comments after testing it:

I would expect x=0,y=0 to place the text in the upper corner. Seems like the y is the bottom of the text and not the top.
I would expect images.Text "This text is placed over the image" to work without options with some sensible defaults.

Agreed, addressed your comments


Improve performance while hashing files during tracing

#75 introduced file hashing of opened files by tracees.  This allows us to tell exactly what went into a build, but it comes at a cost.  Calculating hashes is not cheap.  This flame graph of a cpu profile of tracing a linux kernel build shows we're eating up most of our time while calculating digest sets for files opened by tracees.

Attached are two cpuprofiles generated from witness running with and without hashing files during tracing, both witnessing a linux kernel build.  To use these, run go tool pprof -http=":8000" ./witness ./cpuprofile-with-hashing
The witness binary used for cpuprofile-with-hashing was built with commit a28645c.  The witness binary used for cpuprofile-without-hashing was built with commit 76bcdaa.  Both builds had commit b20275c cherry picked onto them for the cpu profiling.
Some ideas we can possibly use to help performance here and still gather the file hashes:

When a tracee opens a file only for read: calculate the hash in a separate go routine and allow the tracee to continue.
For files that are opened multiple times: observe their last modified time to see if we should recalculate the digest
For files created/written by tracees: don't record their digests until close, and do so on a separate go routine.

There may be other areas for increases and not all of these may be feasible.
cpuprofiles.tar.gz

I don't think we should calculate the hashes on a separate goroutine unless we do something fancy like copy the file before hashing.
Where performance is important, we should direct users to the BPF implementation

Do you have a reasoning for why you think we shouldn't?


Fix unit tests

Probably fixes https://github.com/microsoft/vcpkg-tool/pull/1256#issuecomment-1785445189
Target vcpkg-test doesn't declare build dependencies on test executables. As a result, unit tests fail if those executables were missing.

I agree this is a good change but I disagree that it is the cause of #1256, since we build all the things before trying to test any of the things.

Thanks!


Update documentation regarding using Service Catalog on Minishift

@jenmalloy Can you have another look at this and see if its good to be merged?


deprotect key length

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.537%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7454

Relevant Lines:
8923

💛  - Coveralls


[Flutter 3.19.6][iOS] autocorrect highlight stuck on screen

Steps to reproduce

On iOS, run an app with a textfield (the autocorrect has to be true)
Type ss, kk, in the textfield, the iOS autocorrect will highlight text blue
Change app to other app. Then change back to your app. The blue highlight is stuck in the place where textfield was, no matter if you go to other screen etc.

Expected results
Highlight not stuck on the screen.
Actual results
Highlight is stuck.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MaterialApp(home: MyHomePage()));
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Material(
      child: Center(
        child: TextFormField(
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
![image](https://github.com/flutter/flutter/assets/4015817/c626fe59-ac07-4b99-bc36-0e6b4bc9892e)
https://github.com/flutter/flutter/assets/4015817/c65f679d-5620-4767-8798-5b59ac684cc8

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.6, on macOS 13.5.2 22G91 darwin-arm64, locale en-PL)
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.88.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

Closing this as a duplicate of https://github.com/flutter/flutter/issues/137666


[FileLocksmith] Switch IPC between ctx menu dll and UI from writing to file to pipe

Summary of the Pull Request

PR Checklist

[x] Closes: #31393
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Tested local and release CI build

I mean opening file locksmith and then pressing the "restart as administrator" button from inside the app:

Higher priorities at this moment. Changing it to a draft for the time being.

@stefansjfw how is this going? 🙂

@stefansjfw how is this going? 🙂

Still on hold. What Jaime said in the comment above... :)


Add function that Unmount Cloud ISO if not needed

This PR:

Adds a function UnmountCloudInitISO to unattach and delete the cloudinit iso.

Closes #127

@luthermonson can you have a look,
and can we release this?

looks great, one last quick change if you don't mind

https://github.com/luthermonson/go-proxmox/releases/tag/v0.0.0-beta6 here you go @mcbenjemaa


Enable site-wide search

Distill recently added this via fuse.js based on feature requests, and the new RStudio blog (a blogdown site built with a custom Hugo theme) will have it too via lunr.js.
This is very hard to add on your own, and is now a big differentiator for users to make the choice between Distill/bookdown and blogdown (one of the reasons I use the academic theme for teaching).
See:
https://github.com/rstudio/rstudio.com/pull/156/commits/026af8566fc1d3c3b6eee6d1a686f8551bec3b73
https://palant.info/2020/06/04/the-easier-way-to-use-lunr-search-with-hugo/

Here is my two cents: https://github.com/bvaughn/js-search This is a client side light js search library.

That looks interesting- thank you for sharing! I cannot really evaluate relative dependencies, but fuse.js says also "Fuse.js is a powerful, lightweight fuzzy-search library, with zero dependencies" and "Simplicity and performance were the main criteria when developing this library." If we use fuse.js here, the search interface would be same across the new bs4_book bookdown output format and distill's website, which is nice for users to have a common interface and experience 🌟

FYI I had figured out all pieces of information that I need yesterday (thanks to the super helpful notes by @apreshill), but I was interrupted later so didn't manage get it done. This is not technically challenging to me, but I do need some time (and also a good mood these days).

Done. There may be a few rough edges but I think it's mostly working now: https://prose.yihui.org Click "Search" in the menu (it works on any page that has this menu), and type in the box to search. For an average site, it should be fairly fast. I tested with my own posts, too, and there was a delay of one or two seconds after typing, but I guess not many people have thousands of posts on their sites :)

Looks beautiful!


pytest-benchmark is missing from testing Dependency Group

Since the default pytest configuration uses benchmarking options (see pyproject.toml) then the pytest-benchmark should be added as a direct testing dependency to the testing Dependency Group in pyproject.toml.

pytest-speed should be a drop in replacement

pytest-speed should be a drop in replacement

Ah, okay.  I missed this.  I'm sorry.
BTW, isn't pytest-speed dead?  Last commit in March 2023, last release in January 2023.  The pytest-benchmark seems to be far more alive (latest release less than one month ago).

That's a question for @samuelcolvin 😉


Disable pan tool on pipeline subway map

In https://panel.pyviz.org/user_guide/Pipelines.html, you can drag the pipeline object around.
Would it be possible to also drag and resize gridspecs (make the top pane larger and bottom pane smaller by dragging the center point, like how you can move/resize windows in an OS).
import panel as pn
pn.extension()

gs = pn.GridSpec()
gs[0:25, 0:50] = pn.Spacer(background='Red')
gs[25:50, 0:50] = pn.Spacer(background='Blue')
gs

Almost certainly not, the only reason you can drag the pipeline around is that it's a plot and I forgot to disable the pan tool on that plot. The ability to resize plots is a rather large feature request for bokeh. I've repurposed the issue.

I still see this issue on latest Panel and HoloViews master as of today, with the latest Bokeh dev release.


Open-wc skeleton app is not able to publish according to the guidelines

Overview
The guide on publishing mentions a series of Do's and Dont's that developers should follow. When you scaffold a new project with npm init @open-wc the generated project is not able to be published correctly.
Steps to reproduce

Run npm init @open-wc
Select the following:

✔ What would you like to do today? › Scaffold a new project
✔ What would you like to scaffold? › Web Component
✔ What would you like to add? › Linting (eslint & prettier), Testing (karma), Demoing (storybook)
✔ Would you like to use typescript? › Yes
✔ Would you like to scaffold examples files for? › Testing (karma), Demoing (storybook)
✔ What is the tag name of your application/web component? … cat-element
✔ Do you want to write this file structure to disk? › Yes
✔ Do you want to install dependencies? › Yes, with npm

Run npm publish --dry-run

Notice how the dist/ directory is not packaged and instead you get something like:
npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 526B  .editorconfig
npm notice 1.1kB LICENSE
npm notice 516B  demo/index.html
npm notice 632B  .eslintrc.js
npm notice 738B  karma.conf.js
npm notice 359B  .storybook/main.js
npm notice 327B  .storybook/preview.js
npm notice 698B  custom-elements.json
npm notice 2.3kB package.json
npm notice 443B  tsconfig.json
npm notice 653B  stories/index.stories.md
npm notice 1.5kB README.md
npm notice 1.1kB test/cat-element.test.ts
npm notice 108B  cat-element.ts
npm notice 539B  src/CatElement.ts
npm notice 50B   index.ts

You're definitely right, we should make sure you can properly publish the scaffolded typescript project.

Hi,
Looking into this, I think we could solve this adding the lines in the package.json to execute tsc in prepublish and change main and module to point to dist/index.js instead of index.js. So it would like something like this:
{
  "name": "cat-element",
  "version": "0.0.0",
  // ...
  "main": "dist/index.js",
  "module": "dist/index.js",
  "scripts": {
    // ...
    "prepublish": "tsc"
  },
  // ...
}

Then this would be the published package:
$ npm publish --dry-run
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

><EMAIL_ADDRESS>prepublish .
> tsc

npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 526B  .editorconfig
npm notice 1.1kB LICENSE
npm notice 516B  demo/index.html
npm notice 632B  .eslintrc.js
npm notice 146B  dist/cat-element.js
npm notice 1.1kB dist/test/cat-element.test.js
npm notice 830B  dist/src/CatElement.js
npm notice 83B   dist/index.js
npm notice 738B  karma.conf.js
npm notice 359B  .storybook/main.js
npm notice 327B  .storybook/preview.js
npm notice 698B  custom-elements.json
npm notice 2.3kB package.json
npm notice 468B  tsconfig.json
npm notice 345B  dist/cat-element.js.map
npm notice 2.4kB dist/test/cat-element.test.js.map
npm notice 1.2kB dist/src/CatElement.js.map
npm notice 212B  dist/index.js.map
npm notice 653B  stories/index.stories.md
npm notice 1.5kB README.md
npm notice 11B   dist/cat-element.d.ts
npm notice 28B   dist/test/cat-element.test.d.ts
npm notice 1.1kB test/cat-element.test.ts
npm notice 108B  cat-element.ts
npm notice 266B  dist/src/CatElement.d.ts
npm notice 539B  src/CatElement.ts
npm notice 50B   dist/index.d.ts
npm notice 50B   index.ts
npm notice === Tarball Details ===
npm notice name:          cat-element
npm notice version:       0.0.0
npm notice package size:  6.5 kB
npm notice unpacked size: 18.3 kB
npm notice shasum:        6296ec71995208d507adf6bcd1f6639a1a6b23ff
npm notice integrity:     sha512-wdKTM6+sV7jBc[...]cn/xCpPTKBrcw==
npm notice total files:   28
npm notice
+<EMAIL_ADDRESS>
In this example I have also added in tsconfig.json the entry "declaration": true so it also generates the *.d.ts type files. Do you think it would be good to have, or we should keep it to the developer to include it ?
What do you think about this ? If you seem ok I can do the PR.
Please let me know if you have any question/suggestion !
Thanks

@trystan2k those changes seem right to me 👍


Accesses to fields with packed type fail alignment check

The following function fails to execute in miri, raising an alignment error:
fn test_inner_packed() {
    // Even if just the inner struct is packed, accesses to the outer field can get unaligned
    #[repr(packed)]
    #[derive(Clone,Copy)]
    struct Inner(u32);
    struct Outer(u8, Inner);

    let o = Outer(0, Inner(42)); // error: tried to access memory with alignment 1, but alignment 4 is required
    let _x = o.1;
    let _y = (o.1).0;
}

The problem is that the 2nd field of Outer is unaligned because it's type is repr(packed). This came as a surprise to me, I thought repr(packed) would only influence the layout within this type, not the layout of other types that just involve this type.
How far does this go? For example, if I have a local of type Inner, do I even still have alignment guarantees for that local?
(It is amazing how much time I spend thinking about alignment problems in miri, and how many problems there are. Why is this all so complicated?!?)

The problem is that the 2nd field of Outer is unaligned because it's type is repr(packed). This came as a surprise to me, I thought repr(packed) would only influence the layout within this type, not the layout of other types that just involve this type.

In the mean time, I learned that repr(packed) actually has two effects -- it changes the layout inside the struct, and it changes the alignment of the struct to 1. So this somehow makes more sense to me now.


Use default branch for config repo when creating pull request

Closes: #730

What changed?
We now use the default branch for the configuration repository when creating a pull request on "wego app add"

Why?
The default branch is the correct branch to use; also, the branch chosen for the application may not exist in the configuration repository.

How did you test it?

Added unit tests
Performed manual tests

Release notes
No

Documentation Changes
No

LGTM. Just so I understand, this works because we set the configRepo to the appRepo way upstream?

Wow. Good catch. I thought we set the config url to the app url as soon as we knew we were storing the config in the app repo. Nope. Fixing.


update to v2.3.1

The bot stopped sending updates to this a while back. I wonder if a bug was introduced that is causing it to choke when multiple sources are available.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Unable to change text style in customdropdownbutton2

It would be nice to be able to change the text style in customdropdownbutton2

Duplicate of #109


Changing event time should send notification to attendees

Subject: Changing event time should send notification to attendees
Description:
Event organizer changed the time for an event I was attending.
Results:
This is not a technical bug but I think it's really urgent that attendees are notified if the time and/or place for an event changes. Now we have to rely on personally messaging the attendees.
Backend version: develop-b3cee755
Frontend version: develop-b3cee755
User Agent: Mozilla/5.0 (Linux; Android 12; SM-G981U1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.61 Mobile Safari/537.36
Page: https://couchers.org/event/1359/meeting-in-kreuzberg
User: natalia (198)

#2878


Quickly store and open "attachments" associated with notes

Please Select if your Request is Either something new or an Enhancement

[ ] Enhancement of an existing Feature.
[X] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] UI
[ ] Workbench
[ ] Publishing
[ ] Pods
[ ] Markdown
[ ] Hierarchy
[ ] Graph
[X] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
My notes are often a hybrid of plain text (markdown), images, and other documents (PDFs, spreadsheets, etc.). There is a already a pretty quick workflow associated with embedding images that exist on the clipboard (e.g. screenshots), however I would love a similar process where I can attach and quickly link to arbitrary files within Dendron.
Describe the solution you'd like
The ideal solution, for me, would allow me to very quickly associate files with my Dendron notes, have them copied into the Note hierarchy, and be able to reference them quickly (autocomplete?) from within a note.

Same as #575


Add downgrade test

To check for lower bound compats

Thanks Gabriele, this looks super helpful! I think it would be helpful to have this in ClimaLand and ClimaCoupler too, so I may add it there

FYI, it may be painful to set up because you have to find the correct lower bounds for the Project.toml (and the only way I know how to is with trial and error)


Support for axios.default.then?

Hi Is there a way to execute a default function after every axios (get, post)???

The best option for this would be to use an interceptor. This would allow you to execute logic anytime a request is sent, or anytime a response is received. You could also check config in the request to test config.method and only execute your logic for get/post.

ThnQ it worked :)


Moved collect_removals system to Core::PostUpdate stage

Fixes issue with removals not being propagated.
Can be tested by running the joints_despawn2 example before and after this PR.

This same change was done in #72, so this pull request can be closed.


example of jade conditional for image use

For Jade newbies it's helpful to have an example of this. If you try to include an image and you have none, bad things happen. The conditional fixes this of course, and it's nice to have a sample with the documentation.

Coverage remained the same at 96.992% when pulling 36810fdb1b09f1ef7c3047d12da69a5fb6999313 on javaporter:javaporter-patch-1 into 5ec4b944ee0125403f3b1eda20040d6c41858f80 on carrot:master.

👍 thanks!


Recommendation 12: As NASA considers future evolution of the PDS, it should consider the positive aspects of what the PDS has accomplished within the context of the Planetary Data Ecosystem—as well as the context of history...

Recommendation 12
As NASA considers future evolution of the PDS, it should consider the
positive aspects of what the PDS has accomplished within the context of the Planetary
Data Ecosystem—as well as the context of history—and work to preserve the continuing
positive outcomes from the PDS, including: maintaining or increasing funding levels as
appropriate; working with Mission teams to continue to improve communications about and
efficiency of data archival; continuing collaboration with domestic and international
partners; and continuing to improve bundle creation and validation software.

Closing this as while "actionable" in the sense that continuing to consider past successes and weighing those positive successes when looking to the future, there is not much for NASA to do or say in response to the Recommendation.


Batch:Unrecognized option

When running the command line tabula against my batch pdf folder java -jar tabula-0.9.1-jar-with-dependencies.jar --batch /dir/to/pdf/document/, I get Error: Unrecognized option: --batch.
I also noticed that if you run java -jar lib/tabula-0.9.1-jar-with-dependencies.jar --help, -b, --batch is not listed as an option. I can see that it is in the code base though. Does anyone know the reason why that option is missing?

Hi @bglar,
The --batch option hasn't been released yet. You would need to compile the jar yourself from the master branch.


fix: remove external depends-on annotation

This PR addresses the issue described in #422 by removing the depends-on annotation from the project object in project.yaml.
This change helps ensure that this package is not trying to reach across resourceGroups either in kpt or config-sync. In kpt this would be the resources that are captured in the kpt live init command or in config-sync the scope of the root or repo sync objects.

Lgtm


Fix: Added a temporary fix to avoid compaction failures #1001

Overview
Fix for #1001
Discarded any document not available in couchdb but only in main index.  It seems couch db main index is not getting properly updated after purging documents. Compactor fails with error 'not_found' when it ties to get the full document from the couchdb.
Testing recommendations
Compaction fails continuously when a document is actually purged but not cleaned up in main index.  This issue is random.  I tested couple of databases that had the issue and compaction is working fine after the fix.
Checklist

[x] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

Seems CI fails continuously, anyway to get through this?

You want the 1.7.x branch. 1.6 is no longer under development nor is it supported, see https://blog.couchdb.org/2017/11/14/apache-couchdb-cve-2017-12635-and-cve-2017-12636/
Please resubmit.


May I know how I can create a new fetechenv?

Hello there. I'm new to gym and RL. I would like to know how to create a new fetchenv? Since I saw that the code in gym is no longer working anymore, like there is no more gym.make('FetchReach-v0').

If your question is just about making the env, you just need to install gym-robotics:
pip install gym-robotics

and import gym_robotics:
import gym
import gym_robotics

env = gym.make("FetchReach-v1")


Remove remnants of http/1.1 pipeline logic.

There is only one place that enforces on the pipeline_possible flag which is in HttpSM::tunnel_handler_ua.  In the logic that would otherwise close the client connection (i.e. it is Http/1.1 with the connection header set to close), the pipeline_possible flag is checked and the half_open flag is set to delay the client connection close.  Which seems like a bad idea.
Beyond that, the logic that sets the pipeline_possible flag in HttpTransact::initialize_state_variables_from_request would not set it in that case.  So I don't think that half close logic would ever get invoked purely based on the pipeline_possible flag.
I don't think ATS currently supports HTTP/1.1 pipelining as described in the wikipedia article in that we never send out HTTP/1.1 requests from the same connection in parallel.  ATS does process them in series, but it does that just by virtual of the keep-alive logic.  The parallel requests are amply supported by HTTP/2 and moving forward HTTP/3, so no need to go back and fix up HTTP/1.1 pipelining support.
https://en.wikipedia.org/wiki/HTTP_pipelining
I would like to clean up the remnants of the pipelining logic to reduce confusion moving forward.

[approve ci autest]

@shinrich Do we want this for v9.0.x ? If so, please add the 9.0.x Project.

@shinrich Any reason this shouldn't go into 9?


cmux: work in progress.

This is rio with all windowing bits removed.
This is the long hoped-for console mux. We'll see how it goes. I'm just giving it a shot.
For now I've left limited mouse support, because you can have a mouse ina  console on harvey.
It's /dev/mouse and it's text.
This will be amusing.

Better to merge this if all is ok to work together on it.

LGTM


remove unused import

With this make vet should pass
Signed-off-by: Daniel Dao<EMAIL_ADDRESS>

LGTM


vsc code

Does this occur consistently?
Repro steps:

Action: Go To Definition
Error type: ENOENT
Error Message: ENOENT: no such file or directory, open 'c:\new folder\cvdc-infra\deployment\arm_cosmosdb\arm_cosmosdb.parameters.test.json'
Version: 0.15.7
OS: win32
OS Release: 10.0.19042
Product: Visual Studio Code
Product Version: 1.69.2
Language: en

@joha7 Could you please describe the actions you took?  This error could be completely normal, depending.  Were you expecting it to find the file?  Thanks.


make precommit hook utility run on Windows

#16 works fine on Linux, probably on Mac too, probably not on Windows because of hardcoded "/".

I won't implement this.
If you need it, you should do it by yourself.
Why don't you use wsl ?


improve preact

If a user has an element with an ID of c on the page... they get a free game of breakout.

LGTM

@samccone it's too hard to be a contributor, yeah.

😪😪😪


Improve TileSet 3to4 conversion, avoiding some data loss

Closes https://github.com/godotengine/godot/issues/70784.
Does:

Convert the 3.x "<tile_id>/occluder" and "<tile_id>/navigation" properties
Take into account H flip, V flip and transpose flag for recreating occlusions, collision and navigation shapes.
Fix those polygons being offset
Adds a way to find the best tile size to use according to existing 3.x tiles. It does so by building an histogram of all used sizes and uses the most common one.

Thanks!


fix: update json schema

Fix #2894

Just noticed tasks.*.file is missing from schema too. Should I open a new issue?

Created https://github.com/jdx/mise/pull/2911


Guide: Setting up Danger

This could be very similar to danger init but maybe with screenshots per CI service?

in, ish

in


[ENHANCE] Implement new project profile styles

Summary
NB: waiting for all designs to be completed
Motivation
[More detailed explanation of the motivation for the enhancement, including any benefits it would provide]
Description
[Detailed description of the enhancement, including how it would work and any design considerations]
Alternatives
[Discussion of any alternative solutions that were considered and why the proposed solution is preferred]
Risks
[Identification and mitigation of any potential risks associated with the enhancement]
Acceptance Criteria
[List of criteria that must be met for the enhancement to be considered accepted]
Additional Information
[Any other relevant information, such as links to related issues or pull requests]

Closed as completed


Marker position binding is not updated when dragging a marker

Please see below plunker:
http://plnkr.co/edit/MyH7NOhKUCRftQKvGSQu?p=preview
When dragging the marker the position is not updated...

Hi, please take a look at this example:
http://tombatossals.github.io/angular-leaflet-directive/examples/0500-markers-simple-example.html
There's no direct binding between the markers properties and the scope for performance reasons, but you can listen to marker events to be able to get the new marker coordinates, and update its model if needed.

Will it work if I change it the other way around? meaning I'll change the model behind, will it change the position on the map?

Yes, it will work if you change the lat/lng of the marker on the scope.

Thanks, what field of args do I need to use when I want to update my scope while dragging, it seems that "model" is not defined - is it defined only in dragend?

What's the latest on this one ?
Is there any way to get the new marker position after 'dragend' ?
It looks like it is applied on a variable called 'model' however he is local and not part of the scope

I don't think anyone is looking at it yet. This could be due to the model being cloned. But disabling the clone can cause update issues. So just removing cloning is not just the easy solution. Anyway feel free to dig in.

For the record I was able to overcome this by listening to the leafletDirectiveMarker.dragend event which passes the leaflet object as an argument and has a getLatLng() method.

This issue was moved to angular-ui/ui-leaflet#82

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.

Unfortunately, this directive was not adequate to my needs and I'm no longer using it.


Unable to reinstall the operator

If trying to execute kamel install twice, the second installation fails for a issue while trying to update the service:
Service "camel-k-operator" is invalid: [metadata.resourceVersion: Invalid value: "": must be specified for an update, spec.clusterIP: Invalid value: "": field is immutable]

This is because the service gets assigned, after creation, a cluster IP that is not editable. We should either avoid replacing the cluster IP or avoid replacing the service if already present.
@dmvolod can you take a look?

@nicolaferraro , thanks I will take a look.


Attributes to support a read-only derived property

How can you add a read-only property to a form or a grid/list that is not a database field?  I have tried all sorts of combinations of attributes across the xxRow and xxForm classes (after adding the property to xxColumns) but the field is always an empty string in the form and in the grid.
Have tried:
[NotMapped]
[Expression]
[SetFieldFlags(FieldFlags.Reflective)]
[SetFieldFlags(FieldFlags.Foreign)]
[SetFieldFlags(FieldFlags.Calculated)]

and combinations of the above.  All of these were just trying to output a hardcoded string to test (to begin with).  The intention is to transform another property's value.
Details on what was attempted:
Added string property to xxRow with attributes above (hardcoded string on property getter)
Added string property to xxForm with attributes above (hardcoded string on property getter)
Tried with and without extra properties on xxColumns
If you add the properties to the RowFields class, it falls over with a SQL exception as it's looking for the property in the SQL SELECT (have tried this with [NotMapped] but has no affect)
I'm trying to resolve an issue with not being able to format DateTimeOffset columns.
Thanks in advance for any assistance

Have you looked at https://github.com/volkanceylan/Serene/tree/master/Serene/Serene.Web/Modules/BasicSamples/Editors/StaticTextBlock example?

Hi @Estrusco, thank you for your reply.  I hadn't seen that example and it is similar to what I need but as you have to set Text in the attribute then you can only use a constant.  What I need to do is transform another property's value at runtime.
It is linked to my other issue with DateTimeOffset.  I have no way to format this date correctly so was hoping to to something like this:
public DateTimeOffset UpdatedWhen { get; set; }

[ReadOnly(true)]
[DisplayName("Updated When")]
public string UpdatedWhenFormatted => UpdatedWhen.ToString("dd/MM/yyyy HH:mm:ss");

@sfackrell the example show that is also possible to display the property value. See the code in
 /**

         * By implementing ISetEditValue interface, we allow this editor to display its field value.

         * But only do this when our text content is not explicitly set in options

         */

        public setEditValue(source: any, property: Serenity.PropertyItem) {

            if (this.options.text == null) {

                this.value = Q.coalesce(this.options.text, source[property.name]);

                this.updateElementContent();

            }

        }

@sfackrell
as @Estrusco said, it will use the value at runtime, by default
just add [StaticTextBlock] on top of the property in you Form. by itself, it will use the property value.
if you do not wish to use the value (for example, want to use your own instructions) you will add the string to the  Text parameter, like:
[StaticTextBlock(Text="Please do not use numbers"), NotMapped, OneWay]
public String Tips {get;set;}
Optional:
In this case I add NotMapped because Tips is not in the database.
And OneWay because I do not want it to be included as data in the form when it is POSTed back (like when clicking Save button.)

Thank you both for your answers.
@john20xdoe this doesn't help as I need to transform another property's value at runtime, just putting the attribute on it is no different to leaving the default text editor, the DateTimeOffset value is always incorrectly formatted and I have no control over the format as the DisplayFormat attributes have no effect.
@Estrusco I am not sure what you meant but after digging into templates using IGetEditValue and ISetEditValue I have a solution which works for me.  It might be overkill but I can't see a simpler way to do it
//[DisplayName("Created When"), NotNull, ReadOnlyDate]
[DisplayName("Created When"), NotNull, StaticTextBlock]
public DateTimeOffset? CreatedWhen
{
    get { return Fields.CreatedWhen[this]; }
    set { Fields.CreatedWhen[this] = value; }
}

[DisplayName("Updated When"), NotNull, ReadOnlyDate]
public DateTimeOffset? UpdatedWhen
{
    get { return Fields.UpdatedWhen[this]; }
    set { Fields.UpdatedWhen[this] = value; }
}

@Serenity.Decorators.registerEditor([Serenity.IGetEditValue, Serenity.ISetEditValue])
@Serenity.Decorators.element("
")
export class ReadOnlyDate extends Serenity.TemplatedWidget<any>
  implements Serenity.IGetEditValue, Serenity.ISetEditValue {

  constructor(div: JQuery) {
    super(div);
  }

  private formattedDateValueAsString: String;
  private dateValueAsString: String;

  protected getTemplate() {
    return "
-- No data --
";
  }

  protected updateContent() {
    var dateDiv = this.byId('Date');
    dateDiv.text(Q.coalesce(this.formattedDateValueAsString , ''));
  }

  public get value() : String {
    return this.dateValueAsString;
  }

  public set value(value: String) {
    this.dateValueAsString = value;

    try {
      var dt = new Date(value);
      this.formattedDateValueAsString = dt.toLocaleDateString().concat(' ', dt.toLocaleTimeString());
    } catch (e) {
      this.formattedDateValueAsString = '';
    }

    this.updateContent();
  }

  public getEditValue(prop: Serenity.PropertyItem, target) {
    target[prop.name] = this.value;
  }

  public setEditValue(source, prop: Serenity.PropertyItem) {
    this.value = source[prop.name];
  }

  public onChange: () => void;
}

Insertable(false), Updatable(false) could also work.

Insertable(false), Updatable(false) could also work.

This just hides the field completely on insert and makes the text box read-only on edit.  The content remains the same and you have no way to change its format

The one you wrote is too complex for such simple display box. You only need setEditValue method and formatting value there before setting its text.


Use Xcode command line tools instead of Command Line Tools

Is there a specific reason why brew requires the Command Line Tools package (in /Library/Developer/CommandLineTools/usr)? Since Xcode also provides these tools (in /Applications/Xcode.app/Contents/Developer/usr), I was wondering why it is necessary to have both packages installed in case Xcode is installed anyway.

Is there a specific reason why brew requires the Command Line Tools package (in /Library/Developer/CommandLineTools/usr)

There is actually no such requirement. However, there are formulae that will be forced to build from source if you do not have the CLT. They can still be built from source with Xcode only, but because the pre-built bottles are compiled in an environment that has both Xcode and the CLT installed, there are some cases where the bottles end up having a hard dependency on the CLT. A major example is gcc. So installing the CLT may help you avoid some lengthy source builds.
We ensure that all Homebrew formulae can be built with Xcode.app alone. Most formulae can be built with just the CLT, and those that require the full Xcode.app have an explicitdepends_on :xcode => :build. Some users would prefer to use only the CLT because it's a much smaller download and takes less time to install and upgrade than Xcode.
That said, there are files installed in, for example (there are others), /usr/include that you will only have if you've installed the CLT. So outside of Homebrew you may have an easier time building software that doesn't know it can also find those headers in the Xcode SDK folder. We make sure the formulae work around such problems.
Bottom line: install both if you want to be able to use as many pre-built binary bottles as possible, and want to be able to build formula that have a depends_on :xcode => :build.

@ilovezfs thank you for this detailed answer! Regarding the bit about files in /usr/include that are only there if the CLT are installed - doesn't Mac OS X use shims in this folder which redirect to a real implementation if one is installed? That is, I don't quite understand why any application might need to know that some headers are actually living in the Xcode SDK folder. If they're in Xcode, they're also in /usr/include, or is this assumption incorrect?
Anyway, I understand the implications of installing either or both of these packages now.

@cbrnr the file just aren't there in /usr/include if you don't have the CLT. You could probably install a symlink into the Xcode SDK folder but /usr isn't writable when SIP is on so that's not really a viable option.


Add extra namespace in Basic Usage example

Thanks for the great library!
Add the arch namespace needed to get access to avx::batch.
It looks like the README uses batch<double, 4>. If that's preferred I can update the PR to do that instead.

Thanks for this fix. Both usages are possible (either with the size or with through the arch namespace). A huge refactoring is on-going so that users can specify explicitly the architectur instead of the size.


test update some case in p2

Proposed changes

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Remove w,

https://github.com/GoogleCloudPlatform/golang-samples/blob/a9c8603f3a8d007af2f7d0258fa9777254f421b3/storage/objects/download_file.go#L62

Thanks for the issue, but this is actually perfectly correct.
See https://pkg.go.dev/fmt#Fprintf.

Thank you !


IPFS Meetup in Boston // Cambridge

Now that we've had a great first meetup in Cambridge, we should think about more.
+1 here if you would like to have another one, so we can gauge interest. Thanks!

I greatly enjoyed and benefited from everything in this meetup.  I attended from CT because I was already in MA on other business.
The presentation at this meetup that resonated most with my personal ambitions was the part shared by @nicola regarding spreading the good news about how #ipfs will return much to the all types of people, by doing the things we already do as humans - and doing them better than we can with our distorted centralized "siren servers" of today.
@nicola : Is there any chance your slides are available to me so that I can review what you showed?  Better yet, is there a video out there anywhere that would be OK for me to review?
P.S.
To learn more about Siren Servers, read Who Owns the Future by Jaron Lanier.


Remove misleading node files, set node version

If I'm correct we're using truffle just for plasma_framework, so files in root dir are misleading and useless.
Also we're missing default node version, hence I'm setting it safely to 10.14.

hmmm.... the outside layer of truffle is used for deployment actually

☝  That's right - truffle is used to deploy the current RootChain.sol and related contracts

I think we can close this. If I am wrong please re-open this @pnowosie


serverpod generate not generating protocol relative tables data in tables.pgsql

Describe the bug
serverpod generate not generating protocol relative table in tables.pgsql
To Reproduce
Steps to reproduce the behavior:

create new project serverpod create myfirstgame
add player player.yaml
run serverpod generate
Expected behavior
player relative data should generate in tables.pgsql

Screenshots

Serverpod versions

_CLI Version: 1.1.1
_Library version:1.1.1

Platform information
mac
Additional context
I updated serverpod via git

You have to define a table in the protocol or you will not get any SQL code.
Your protocol file should look like this:
class: Player
table: player
fields:
  dx: double
  dy: double
  createdAt: DateTime
  updatedAt: DateTime


Making pts_to a method

By adding a pulse_unfold attribute to the pts_to method (and the instances), it gets automatically unfolded by the Pulse checker whenever needed, and we can just work with the polymorphic pts_to. This PR fixes the class, defines some instances for the pointer-like types in the library, and uses it wherever possible.
There is tension whenever refinements are involved, as usual. See for instance FStarLang/FStar#3534. I think that if that is fixed, this will become quite robust.
The operator |-> is aliased to pts_to (with full permission). However the precedence is wrong: it binds weaker than **, so we would require parenthesis everywhere, and hence I didn't use it. I think we should just add configurable mixfix operators to F* to fix this.
Resugaring and context printing do not know about the typeclasses being unfolded, so context dumps are still in the underlying terms (R.pts_to, A.pts_to, etc). This is sometimes good, sometimes bad. A toggle would be nice, but this is an F* problem.
Note: using typeclasses for Pulse functions, instead of just slprops, also somewhat works.

( testing zulip bot :^) )


BlockDB will not know if tx is failed to be put on chain

need a way to detect that.

BlockDB records the height of chain after put something  on chain
Chain's  response include latest height .


Provisioning

Category

[ ] Question
[x] Bug
[ ] Enhancement

Provisioning solution
Apply-PnPProvisioningTemplate : Object reference not set to an instance of an object.
At E:\DEV\sp-starter-kit-master\provisioning\deploy.ps1:98 char:5

Apply-PnPProvisioningTemplate -Path "$PSScriptRoot\solution.xml"  ...

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : WriteError: (:) [Apply-PnPProvisioningTemplate], NullReferenceException
FullyQualifiedErrorId : EXCEPTION,SharePointPnP.PowerShell.Commands.Provisioning.ApplyProvisioningTemplate

Hi @spurr82 , can you confirm for us that you have followed through the "Getting Started" section of the documentation and completed the pre-requirements? Did you manually upload the .sppkg file to the app catalog?

@spurr82 please also review https://github.com/SharePoint/sp-starter-kit/blob/master/documentation/common-provision-results.md. The null error is one I ran across a long time ago, but I don't remember why, and couldn't duplicate it since.
Please also try turning on debugging logging.
Set-PnPTraceLog -On -Level Debug

Hi yes, followed the getting started, and tried both manually uploading

thanks @eoverfield ill check that out also

Hi, I am working on cleaning up / working on the issues list. I understand this is an old ticket and may not be relevant to you anymore, can you confirm whether this is still a problem for you?


Add type hints, py.typed

It'd be nice to have type hints and a py.typed file to check this repository (and any code using this Python package) can use mypy or the like. This also gives better auto completion and what not.
I believe that #101 blocks this.

Py2 usage dropped below 2% of downloads, so we might do it. PR is welcome, if you prepare it I won't have any objections to include it.

Do you have any preference in terms of python 3.10 style hints (e.g. varname: dict(str, float | int) = ...) or earlier version style (e.g. varname: Dict[str, Union[float, int]] = ...)

I definitely prefer the Python 3.10 syntax for unions, but I think it'd be a bit premature to switch to it. I think 3.7+ would be ideal as they are the only supported versions.

From my side there's no preference as I never used type annotation. However, backward compatibility is important, so please keep to the most popular version (according to PyPi stats, 3.7 dominates the downloads).


[TASK] issues #19

Describe your change:
Answer the questions
closes https://github.com/SENATOROVAI/docs/issues/19

[ ] Add an algorithm?
[ ] Fix a bug or typo in an existing algorithm?
[ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
[ ] Documentation change?

Checklist:

[ ] I have read CONTRIBUTING.md.
[ ] This pull request is all my own work -- I have not plagiarized.
[ ] I know that pull requests will not be merged if they fail the automated tests.
[ ] This PR only changes one algorithm file.  To ease review, please open separate PRs for separate algorithms.
[ ] All new Python files are placed inside an existing directory.
[ ] All filenames are in all lowercase characters with no spaces or dashes.
[ ] All functions and variable names follow Python naming conventions.
[ ] All function parameters and return values are annotated with Python type hints.
[ ] All functions have doctests that pass the automated testing.
[ ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
[ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

done


Not all Hyperlinks appearing on sent template through email

above we see the template showing all of the hyperlinks bolded and highlighted. then below is the email i received:

it seems i cannot reproduce it on my end so i think it is isolated to this user.

Seems the user just had the wrong links.


Retry on resource exhausted.

R: @vkedia

Changes Unknown when pulling d6fbde79bd3cfc5604c9fc02ae1c420e2ba759c4 on mairbek:retry into ** on GoogleCloudPlatform:master**.

I wonder if this should be optional. Resource errors could include situations like having too much storage per node as well as transient overuse of node compute capacity. Most users would want to retry, but there are possibly cases where they would prefer to fail fast.
How is RESOURCE_EXHAUSTED handled in other google-cloud-java APIs?

In DataFlow bulk load case I feel that people might run into "disk exceeded" kind of resource_exhausted pretty often in which case they might want to fail fast. Can we figure out from the error message what resource got exhausted?
@vam-google for the question about what do other APIs do.

@vam-google could you answer the question in this PR so it can either move forward or be closed?

This can be closed. @mairbek has a different PR #2645 to handle this.


Bad lib path in install script

Please fix line
install(TARGETS netconf2-cpp DESTINATION lib)
to
install(TARGETS netconf2-cpp DESTINATION ${CMAKE_INSTALL_LIBDIR})
in CMakeList.txt to install the library to a correct folder.

Thanks! The patch turns out to be even simpler, can you please give it a try?
https://gerrit.cesnet.cz/c/CzechLight/libnetconf2-cpp/+/5912

Now it appears to be OK. Thanks!


Check folder status before checking ignores

Related to:
https://github.com/syncthing/syncthing/issues/2630

So Syncthing will return 500 for /rest/db/ignores if the folder is unhealthy?

yeah, though that could mean other errors, so it's best to check the status, before you check the ignores.

Actually, I do check the invalid field of the folder config before trying to fetch ignores. However, in the case of a missing folder marker this field is never set.
Later on, I get a FolderStatus event, where the invalid field is empty (still) but the State field is set to "error". However this is too late: I've already started fetching the ignores, sync state, started constructing its path, etc.
The FolderStatus event isn't documented, and neither is the structure of the config, so I'm not sure invalid and State=error are supposed to relate.

Actually, I do check the invalid field of the folder config before trying to fetch ignores. However, in the case of a missing folder marker this field is never set.
Later on, I get a FolderStatus event, where the invalid field is empty (still) but the State field is set to "error". However this is too late: I've already started fetching the ignores, sync state, started constructing its path, etc.
The FolderStatus event isn't documented, and neither is the structure of the config, so I'm not sure invalid and State=error are supposed to relate.

I think the error field is set in the config.

I think the error field is set in the config.

If of any use - some info from Windows Event Logs for the crashing SyncTrayzor (v.1.0.32)
Application Error:
Faulting application name: SyncTrayzor.exe, version: <IP_ADDRESS>, time stamp: 0x5659ddb2
Faulting module name: KERNELBASE.dll, version: 6.1.7601.19045, time stamp: 0x56259271
Exception code: 0xe0434352
Fault offset: 0x000000000000b3dd
Faulting process id: 0x242c
Faulting application start time: 0x01d14484713abd0d
Faulting application path: C:\Program Files\SyncTrayzor\SyncTrayzor.exe
Faulting module path: C:\Windows\system32\KERNELBASE.dll
Report Id: 8941d9a1-b07b-11e5-a0d4-da3cd1620030

.NET Runtime:
Application: SyncTrayzor.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: SyncTrayzor.SyncThing.SyncThingDidNotStartCorrectlyException
Stack:
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__5(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

If of any use - some info from Windows Event Logs for the crashing SyncTrayzor (v.1.0.32)
Application Error:
Faulting application name: SyncTrayzor.exe, version: <IP_ADDRESS>, time stamp: 0x5659ddb2
Faulting module name: KERNELBASE.dll, version: 6.1.7601.19045, time stamp: 0x56259271
Exception code: 0xe0434352
Fault offset: 0x000000000000b3dd
Faulting process id: 0x242c
Faulting application start time: 0x01d14484713abd0d
Faulting application path: C:\Program Files\SyncTrayzor\SyncTrayzor.exe
Faulting module path: C:\Windows\system32\KERNELBASE.dll
Report Id: 8941d9a1-b07b-11e5-a0d4-da3cd1620030

.NET Runtime:
Application: SyncTrayzor.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: SyncTrayzor.SyncThing.SyncThingDidNotStartCorrectlyException
Stack:
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__5(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Ah righty, I'll check that when I'm next near a computer. Did the state field replace the invalid field, then? If so, in what version?
@scienmind thanks - I think I know what's happening: syncthing changed some details of the API and I wasn't aware. Just need to figure out how best to resolve it.

Ah righty, I'll check that when I'm next near a computer. Did the state field replace the invalid field, then? If so, in what version?
@scienmind thanks - I think I know what's happening: syncthing changed some details of the API and I wasn't aware. Just need to figure out how best to resolve it.

API change seem reasonable to blame.
I've been running the same setup for a while now, and this mess wasn't present until recently. Up until Syncthing v.0.12.7 it was fine, and now I re-enabled auto-update, updating directly to v.0.12.10. Having this issue since then.

API change seem reasonable to blame.
I've been running the same setup for a while now, and this mess wasn't present until recently. Up until Syncthing v.0.12.7 it was fine, and now I re-enabled auto-update, updating directly to v.0.12.10. Having this issue since then.

I don't think we've changed anything in the API

I don't think we've changed anything in the API

This case used to appear as a value in the config's invalid field and apparently it no longer does (although we might well be talking around the v0.10 era).

This case used to appear as a value in the config's invalid field and apparently it no longer does (although we might well be talking around the v0.10 era).

It should still appear there. If it's not, there is an issue.

It should still appear there. If it's not, there is an issue.

Actually, I do check the invalid field of the folder config before trying to fetch ignores. However, in the case of a missing folder marker this field is never set.

Later on, I get a FolderStatus event, where the invalid field is empty (still) but the State field is set to "error". However this is too late: I've already started fetching the ignores, sync state, started constructing its path, etc.

It no longer appears there.

Actually, I do check the invalid field of the folder config before trying to fetch ignores. However, in the case of a missing folder marker this field is never set.

Later on, I get a FolderStatus event, where the invalid field is empty (still) but the State field is set to "error". However this is too late: I've already started fetching the ignores, sync state, started constructing its path, etc.

It no longer appears there.

I think the error field is set in the config.

I don't see an error field. This is the config that's fetched:
   "folders":[
      {
         "id":"default",
         "path":"C:\\Users\\Antony\\Sync",
         "devices":[
            {
               "deviceID":"XXXXX"
            }
         ],
         "readOnly":false,
         "rescanIntervalS":60,
         "ignorePerms":false,
         "autoNormalize":false,
         "minDiskFreePct":1,
         "versioning":{
            "type":"",
            "params":{

            }
         },
         "copiers":0,
         "pullers":0,
         "hashers":0,
         "order":"random",
         "ignoreDelete":false,
         "scanProgressIntervalS":0,
         "pullerSleepS":0,
         "pullerPauseS":0,
         "maxConflicts":-1,
         "disableSparseFiles":false,
         "invalid":""
      }
   ],

I think the error field is set in the config.

I don't see an error field. This is the config that's fetched:
   "folders":[
      {
         "id":"default",
         "path":"C:\\Users\\Antony\\Sync",
         "devices":[
            {
               "deviceID":"XXXXX"
            }
         ],
         "readOnly":false,
         "rescanIntervalS":60,
         "ignorePerms":false,
         "autoNormalize":false,
         "minDiskFreePct":1,
         "versioning":{
            "type":"",
            "params":{

            }
         },
         "copiers":0,
         "pullers":0,
         "hashers":0,
         "order":"random",
         "ignoreDelete":false,
         "scanProgressIntervalS":0,
         "pullerSleepS":0,
         "pullerPauseS":0,
         "maxConflicts":-1,
         "disableSparseFiles":false,
         "invalid":""
      }
   ],

Well invalid holds the error, hence I call it error field :D

Well invalid holds the error, hence I call it error field :D

Heh, ok then! That clears things up slightly - I wasn't sure whether you were referring to the State field being set to Error...
Even so, it doesn't look like the field is being set, whatever it's called :D

Heh, ok then! That clears things up slightly - I wasn't sure whether you were referring to the State field being set to Error...
Even so, it doesn't look like the field is being set, whatever it's called :D

If you remove the marker, rescan, it should be set.

If you remove the marker, rescan, it should be set.

If I remove the marker and restart - which is the case that causes the reported problem, and a case which used to work - it isn't set.  That is why this issue is open

If I remove the marker and restart - which is the case that causes the reported problem, and a case which used to work - it isn't set.  That is why this issue is open

Ok I guess we can close this, and open up one in syncthing.

Ok I guess we can close this, and open up one in syncthing.

@canton7 are the recent commits meant to work around the syncthing's behavior and fix the issue?
Tried re-adding the external drive's folder today, and when unmounted, the console is still flooded with those:
[XXXXX] 07:10:05 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 07:28:24 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 07:47:01 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 08:05:13 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 08:21:57 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 08:33:27 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 08:48:52 INFO: Skipping folder removable_folder scan due to folder error: folder path missing
[XXXXX] 09:06:21 INFO: Skipping folder removable_folder scan due to folder error: folder path missing

On the plus side, it hasn't crashed yet, but maybe i'm just lucky/haven't waited enough...

The log os expected, it tells you why the folder is not working.

Yeah, that's just what syncthing does when you have a folder missing. SyncTrayzor is working fine, and Syncthing is also working as designed.

OK, then I assume I can resurrect the syncing all unmountable folders. Thanks!


Publish multiple groups/repos at once

Hi, not a bug (yet) just a question:
I have a multi-build project with subprojects using unrelated groups. They should ideally be staged at the same time, using the same Nexus endpoint/credentials, but different staging repos. For instance:

Project Root (no code, just project config)

Project X (group name a.b.c)
Project Y (group name d.e.f, depends on Project X)

I can't figure out how to configure the plugin to handle this scenario. Seems like a single group name must be set at the root project which means one of the subprojects fails to stage (because the staging repo is created for whichever group name the root has).
How can I handle this scenario?

Unfortunately, it is not supported at the moment. Your case is similar to support for the mono repo projects (#84) and the Android projects (#75). While your extra requirement to use different staging repositories at the same time might be problematic in implementation, support for mono repos (once available) should be enough to use this plugin.
We may keep that issue open to see how many people :+1: it, as a sign that they also would be happy seeing it implemented.

Got it, thanks.


CI: np.matrix deprecation warning

np.kron is now (appeared in the NumPy pre-released job) raising a deprecation warning because we are using a matrix in ::TestSparseFunctions::test_scale_rows_and_cols
(np.array(*args, **kwargs).view(np.matrix)). This is from from scipy.sparse._sputils import matrix.
/home/runner/.local/lib/python3.10/site-packages/numpy/matrixlib/defmatrix.py:116: in __new__
[1104](https://github.com/scipy/scipy/runs/5999820014?check_suite_focus=true#step:7:1104)
    warnings.warn('the matrix subclass is not the recommended way to '
[1105](https://github.com/scipy/scipy/runs/5999820014?check_suite_focus=true#step:7:1105)
E   PendingDeprecationWarning: the matrix subclass is not the recommended way to represent matrices or deal with linear algebra (see https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html). Please adjust your code to use regular ndarray.

See for instance: https://github.com/scipy/scipy/runs/5999820014?check_suite_focus=true

Yup that's the culprit - fortunately I think this can be fixed with a few relatively straightforward changes to the affected test. I will push up my suggestion as soon as the tests finish locally.


VCR::Errors due to mismatch in API_BASE_URL in test setup

I just cloned this repository and noticed that the spec/ioki/vcr tests all failed with similar messages:
 VCR::Errors::UnhandledHTTPRequestError:

   ================================================================================
   An HTTP request has been made that VCR does not know how to handle:
     GET https://app.io.ki/api/platform/providers

The reason seems to be, that in the spec/fixtures/vcr_cassettes files the https://demo.io.ki/api/ API_BASE_URL is used, but this is not configured by default in the test setup where https://app.io.ki/api/ is used.
I was able to fix this by exporting the appropriate ENV variables as it is done in the .github/ci_workflow.env file:
export IOKI_PLATFORM_API_BASE_URL="https://demo.io.ki/api/"
export IOKI_PASSENGER_API_BASE_URL="https://demo.io.ki/api/"
export IOKI_DRIVER_API_BASE_URL="https://demo.io.ki/api/"

This should be documented somewhere or maybe simply use the https://app.io.ki/api/ API_BASE_URL in the VCR files as well and remove these ENV vars from the CI setup? Or set the ENV variable in the spec_helper.rb file?

Setting the env variable in the spec helper was the simplest:
ENV['IOKI_PLATFORM_API_BASE_URL']  ||= "https://demo.io.ki/api/"
ENV['IOKI_PASSENGER_API_BASE_URL'] ||= "https://demo.io.ki/api/"
ENV['IOKI_DRIVER_API_BASE_URL']    ||= "https://demo.io.ki/api/"

Sounds good @eikes. Can you prepare a PR for this?

@eikes Could you let me know about any other issue you have/had while setting up?
https://github.com/ioki-mobility/ioki-ruby/issues/20 is still on my list and your perspective would be very helpful here.


Stuck in the object selection

In the 1.124.0 - Standalone Version - Win - Edge (updated today), I am not able to Pull a repository. It creates the popup to select the objects which should be brought from the remote version, but the screen does not execute the pull action when I click  on Continue. Actually, it creates the same popup, again. I cannot close the window or stop the transaction. I am stuck here.

Tech details:

SAP Gui for Windows 800 PL 3 HOTFIX 1
Browser Control: Edge (tested with IE, same issue)

hmm, maybe https://github.com/abapGit/abapGit/pull/6401 is relevant, try commenting those changes in the standalone and try the standalone

E_SALV_FUNCTION = OK
It looks like something in the alv framework...

Yes, SAP changed something. Which sap version? sy-saprl or table covers "sap_aba"?
if it's 756, try SAP note 3146971 (mentioned here https://github.com/abapGit/abapGit/issues/6010)

SAP_ABA = 816
Let me ask the ALV colleagues to check it. The abapgit side looks fine to me.

Fixed internally, thank you.

hi @lucasborin
looks like the issue occurred with another SAP colleague (https://github.com/abapGit/abapGit/issues/6477). Do you have more details or could get in touch with him?
Thx
Marc


Prepare v0.25.1

Google Cloud PHP v0.25.1
Cloud PubSub

Please note that Google Cloud PHP's pubsub support was previously marked
incorrectly as Beta. It should be considered alpha-quality at this time.

Cloud Core v1.0.1

Fixed incorrect namespace reference in Google\Cloud\Core\Upload\StreamableUploader. (#427)

LGTM, thanks!


Move YAML parser back to default settings

Fixes #282
I looked back in history for clues as to why this typ="unsafe" is needed, and apparently it was done for performance reasons.
My suggestion is to disable this setting since it seems to be causing more harm than benefit.

Fixes #282
I looked back in history for clues as to why this typ="unsafe" is needed, and apparently it was done for performance reasons. My suggestion is to disable this setting since it seems to be causing more harm than benefit.

The performance improvement form using 'unsafe' is significant. Since all projects are loaded for any build operation, the cli becomes sluggish if we load the project.yml safely.
The project.yml that are thus loaded are never serialized back to to yaml, so I don't understand how the scenario describe could happen.
Do you have a real life example?

The project.yml that are thus loaded are never serialized back to to yaml, so I don't understand how the scenario describe could happen.

I'm new to MPyL so maybe I'm not explaining the situation in a clear way.
As far as I can tell, the project.yml is loaded from a YAML file into an in-memory representation:
yaml_values = (
    validate_project(file) if strict else YAML(typ="unsafe").load(file)
)
project = Project.from_config(yaml_values, project_path)

During the deployment phase, that same in-memory representation is first converted to a different representation:
chart = to_service_chart(builder)

And chart is then eventually serialized back to YAML and written to disk:
chart_path = write_helm_chart(
    logger, chart, Path(project.target_path), run_properties, release_name
)

This serialization is done using a default (not unsafe) instance of YAML, triggering #282:
yaml = YAML()

The location of the Helm charts on disk (chart_path) is then used to trigger installation of the Helm charts:
return helm.install(
    logger,
    chart_path,
    dry_run,
    release_name,
    namespace,
    rancher_config.context,
    delete_existing,
)

And because the generated YAML files will contain a different string representation than what was present in the original project.yml (as shown in #282), this will sometimes cause the Helm deployment to fail.

I'll try to create a test case to visualize this more explicitly, but I hope this message explains the issue we're seeing.

The project.yml that are thus loaded are never serialized back to to yaml, so I don't understand how the scenario describe could happen.

I'm new to MPyL so maybe I'm not explaining the situation in a clear way. As far as I can tell, the project.yml is loaded from a YAML file into an in-memory representation:
yaml_values = (
    validate_project(file) if strict else YAML(typ="unsafe").load(file)
)
project = Project.from_config(yaml_values, project_path)

During the deployment phase, that same in-memory representation is first converted to a different representation:
chart = to_service_chart(builder)

And chart is then eventually serialized back to YAML and written to disk:
chart_path = write_helm_chart(
    logger, chart, Path(project.target_path), run_properties, release_name
)

This serialization is done using a default (not unsafe) instance of YAML, triggering #282:
yaml = YAML()

The location of the Helm charts on disk (chart_path) is then used to trigger installation of the Helm charts:
return helm.install(
    logger,
    chart_path,
    dry_run,
    release_name,
    namespace,
    rancher_config.context,
    delete_existing,
)

And because the generated YAML files will contain a different string representation than what was present in the original project.yml (as shown in #282), this will sometimes cause the Helm deployment to fail.
I'll try to create a test case to visualize this more explicitly, but I hope this message explains the issue we're seeing.

Do you have een example project.yml where this happens?

Here's the one that is currently triggering this issue:
name: 'application'
stages:
  build: 'Sbt Build'
  test: 'Sbt Test'
  deploy: 'Kubernetes Deploy'
deployment:
  kubernetes:
    metrics:
      alerts:
        - name: "the name of the alert"
          expr: "a prometheus expression"
          forDuration: 0m # Fire instantly
          severity: signup_alerting_once
          description: |-
            **{{ $value }}** new signup failures with reason `{{ $labels.reason }}`.
            You can find more details in: <unrelated link>

Note: I removed all other unrelated fields, hopefully nothing is mandatory.

The previous project.yml will generate a Prometheus rule template like:
spec:
  groups:
  - name: customers-prometheus-rule-group
    rules:
    - alert: "the name of the alert"
      annotations:
        description: "**{{ \"{{\" }} $value }}** new signup failures with reason `{{\
          \ \"{{\" }} $labels.reason }}`.\nYou can find more details in: <redacted link>"

Double-quoted strings are meant to render without newlines, and that will produce \\ characters which Helm rejects.


Improve TruncateTime canonical function performance

Ported from CodePlex

I believe the original CodePlex PR was submitted by @brandondahler, in case he is interested in following up.

Thanks for the tag, answered inline.

@divega This look okay to you?

Changes made in https://github.com/brandondahler/EntityFramework6/tree/truncate_time, unable to actually update this pull request because it migrated from @maumar from CodePlex.
Let me know if you'd like me to open a new PR or if one of the members of the repository will take care of it.  Was able to find a good place to put a net-new test for the updated code.

I think a new PR would be good. That way the commits will be correctly assigned to you.

Superseded by https://github.com/aspnet/EntityFramework6/pull/948.


Set up epochs start time in KeeperTestHelper.App

Background
So the epoch time in KeeperTestHelper.App  is set to be empty. It should not be empty since in modules' test suite we often set values related to time to be Time.Now(). For example, in incentives' test suite,
we set all the gauges start time to be Time.Now(). This in turn causes unexpected behavior in our tests, like BeginNewBlock (with executeNextEpoch equals true) won't trigger gauge distribution in incentives' test suite. Specifically, BeginNewBlock (with executeNextEpoch equals true) will set the suite.Ctx.BlockTime() to be = epoch start time + 5 sec ( = time.Time{} + 5 sec) , because block time (time.Time{} + 5 sec) is way before all the gauges start time (time.Now()) in the tests suite, gauge distribution won't happen
Suggested Design

Set epoch time in  KeeperTestHelper.App  to be time.Now()

Acceptance Criteria

all existing and new tests should pass

@ValarDragon, plz tell me if this is good or not

Oh interesting, this is a good point. Yes lets do this!


How to enable couch DB?

I have used this open source project to implement a blockchain network on Kubernetes. Could you please let me know how to enable couch DB for this network so that I can perform some rich Queries?

Hi @rajBandhakavi , for couch DB - need to create one pod for couch db and associate the same with the peers pod.

yes. I did the same. thank you for letting me know because your reply acts as a conformation.


Remove unused postSuiteHeaders field.

This looks like a remnant from the first verbose printing implementation and is now unused.

@facebook-github-bot import

@facebook-github-bot import


There should be check on onchain wallet Backup

As per discussion  @cakesoft-shashank  ensure that users cannot proceed to Step 2 (Asset Backup) without completing Step 1 (Wallet Backup). A validation check needs to be implemented to enforce this flow.

https://github.com/user-attachments/assets/2c071971-439e-4611-9060-e1b0ec1c7df9

Completed and verified in Version 0.2.5 (65)


Move custom serialization to PlatformExtensionConverters

The gist is that we can utilize generic JsonConverters in order to deserialize portions of client capabilities when interacting with clients. That way sub-systems can try and cast those client capabilities to corresponding types and succeed with minimal code requirements.
This is setting the groundwork for doing a lot more custom extension serialization in our language server.
Updated tests to also accoutn for the changes.

Part of dotnet/aspnetcore#31883
Part of dotnet/aspnetcore#31886
/cc @TanayParikh since I'm undoing a bit of what you did in the past

/cc @ToddGrun @jimmylewis in case you all wanted to adopt a similar platform extension model for client capabilities in your server


Corrected some misspellings and one string that was still in English

A few of the strings were misspelled and "Christmas Day" was still in English.

Pull Request Test Coverage Report for Build 744

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 743:
0.0%

Covered Lines:
8176

Relevant Lines:
8176

💛  - Coveralls

Thank you very much, cheers 👍


add ci.yml

Codecov Report

Merging #30 (977e0c0) into master (51adcae) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            2         2
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51adcae...977e0c0. Read the comment docs.


useStarkProfile() error on custom chains

Calling useStarkProfile({address}) on a custom chain that does not have an id contract results in client error.
The hook should verify if the contract exists before selecting the multicall function.
index.js:1838 Uncaught TypeError: Cannot read properties of undefined (reading 'multicall')
    at useStarkProfile (index.js:1838:48)
    at WalletHeader (WalletHeader.tsx:16:53)
    at renderWithHooks (react-dom.development.js:16305:18)
    at mountIndeterminateComponent (react-dom.development.js:20069:13)
    at beginWork (react-dom.development.js:21582:16)
    at HTMLUnknownElement.callCallback (react-dom.development.js:4164:14)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:16)
    at invokeGuardedCallback (react-dom.development.js:4277:31)
    at beginWork$1 (react-dom.development.js:27446:7)
    at performUnitOfWork (react-dom.development.js:26552:12)
    at workLoopSync (react-dom.development.js:26461:5)
    at renderRootSync (react-dom.development.js:26429:7)
    at performConcurrentWorkOnRoot (react-dom.development.js:25733:74)
    at workLoop (scheduler.development.js:266:34)
    at flushWork (scheduler.development.js:239:14)
    at MessagePort.performWorkUntilDeadline (scheduler.development.js:533:21)

Good catch thank you!

Hi @fracek, can I proceed to fix this bug?

Hi @fracek, can I proceed to fix this bug?

Happy to review a pr that fixes this.


[Subtask] [Netty] Writer support off heap memory to compress data

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the subtask
Writer support off heap memory to compress data. And we use the off heap memory to send data.
Parent issue
#133
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

assgin for me,thx


type check properties

Best idea I've come up with to do this is to have yants export a function that generates a type checking pop. This pop will simply have an extension that does nothing but type check a series of values. If there are any problems, yants check functions will throw errors, otherwise the extension can just return an empty attrset. This could be implemented in yants itself.

yants already has nestable struct validation, is that what we'd be looking at?

Yeah exactly, I don't think pop or yants really has to be changed for this. You can do this manually already by creating a pop that's extension type checks super and just returns back everything as the same. Then that type-checking pop can be a super for another pop where you want attributes type checked.
We can make a convenience function to create such a pop by passing it a yants struct.


IBC Update proposal not found

Background

motivation: we want to update the IBC client with new clinet id.
version: Cosmos SDK 0.47.3.   IBC-go: v7.2.0
proposal json file:

{
  "title": "Governance proposal to recover IBC connection with Osmosis chain",
  "description": "Governance proposal to recover IBC connection with Osmosis chain",
  "messages": [
    {
      "@type": "/ibc.core.client.v1.ClientUpdateProposal",
           "subject_client_id": "07-tendermint-0",
           "substitute_client_id": "07-tendermint-1"
    }
  ],
  "metadata": "",
  "deposit": "100000000000000000000000peaka"
}

when i want to submit this proposal to the chain, it meets this error:
dorad tx gov submit-proposal update-ibc_client.json --from abcd --gas-prices<PHONE_NUMBER>00peaka --gas auto --gas-adjustment 1.5 --chain-id "vota-testnet" --node https://vota-testnet-rpc.dorafactory.org:443

Are there any problems in my chain source code? Or i missed some important config?

This is my rpc and rest api:

https://vota-testnet-rpc.dorafactory.org:443
https://vota-testnet-rest.dorafactory.org:443

Discussed this with @damiannolan and the problem might be with the usage of submit-proposal. This command works only with the gov v1 messages, and these have been released on v8. Therefore they are not available on v7 and you need to use the submit-legacy-proposal command (see here). Please give this a try and let us know if it works!

Just to add more context: the error you are seeing is codec related and as far as I know proposal msg types are registered against the govtypes.Content interface on v7.2.0, see here. From v8.0.0 the proposals are supported through gov v1, using MsgRecoverClient (which has superseded ClientUpdateProposal)

Discussed this with @damiannolan and the problem might be with the usage of submit-proposal. This command works only with the gov v1 messages, and these have been released on v8. Therefore they are not available on v7 and you need to use the submit-legacy-proposal command (see here). Please give this a try and let us know if it works!

thanks for your reponse! @crodriguezvega @damiannolan  , it has submit-legacy-proposal command,  i just run with the following command:
dorad tx gov submit-legacy-proposal update-client 07-tendermint-0 07-tendermint-1 --title "update ibc client id" --description "updateibc client" --deposit "100000000000000000000000peaka"  --from abcd --gas-prices<PHONE_NUMBER>00peaka --gas auto --gas-adjustment 1.5 --chain-id "vota-testnet" --node https://vota-testnet-rpc.dorafactory.org:443

it meets this error:
Error: rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 0: failed to run legacy handler client,
github.com/cosmos/ibc-go/v7/modules/core/02-client/keeper.Keeper.ClientUpdateProposal
        /home/ubuntu/go/pkg/mod/github.com/cosmos/ibc-go/v7@v7.2.0/modules/core/02-client/keeper/proposal.go:29
github.com/cosmos/ibc-go/v7/modules/core/02-client.NewClientProposalHandler.func1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/ibc-go/v7@v7.2.0/modules/core/02-client/proposal_handler.go:17
github.com/cosmos/cosmos-sdk/x/gov/keeper.msgServer.ExecLegacyContent
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/keeper/msg_server.go:106
github.com/cosmos/cosmos-sdk/x/gov/types/v1._Msg_ExecLegacyContent_Handler.func1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/types/v1/tx.pb.go:939
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/msg_service_router.go:118
github.com/cosmos/cosmos-sdk/x/gov/types/v1._Msg_ExecLegacyContent_Handler
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/types/v1/tx.pb.go:941
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/msg_service_router.go:139
github.com/cosmos/cosmos-sdk/x/gov/keeper.Keeper.SubmitProposal
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/keeper/proposal.go:69
github.com/cosmos/cosmos-sdk/x/gov/keeper.msgServer.SubmitProposal
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/keeper/msg_server.go:50
github.com/cosmos/cosmos-sdk/x/gov/keeper.legacyMsgServer.SubmitProposal
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/keeper/msg_server.go:236
github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1._Msg_SubmitProposal_Handler.func1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/types/v1beta1/tx.pb.go:547
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/msg_service_router.go:118
github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1._Msg_SubmitProposal_Handler
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/gov/types/v1beta1/tx.pb.go:549
github.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/msg_service_router.go:139
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/baseapp.go:800
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/baseapp.go:743
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).Simulate
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/test_helpers.go:25
github.com/cosmos/cosmos-sdk/x/auth/tx.txServer.Simulate
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/x/auth/tx/service.go:131
github.com/cosmos/cosmos-sdk/types/tx._Service_Simulate_Handler
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/types/tx/service.pb.go:1416
github.com/cosmos/cosmos-sdk/baseapp.(*GRPCQueryRouter).RegisterService.func1
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/grpcrouter.go:82
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).handleQueryGRPC
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/abci.go:694
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).Query
        /home/ubuntu/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.47.3/baseapp/abci.go:541
github.com/cometbft/cometbft/abci/client.(*localClient).QuerySync
        /home/ubuntu/go/pkg/mod/github.com/cometbft/cometbft@v0.37.2/abci/client/local_client.go:259
github.com/cometbft/cometbft/proxy.(*appConnQuery).QuerySync
        /home/ubuntu/go/pkg/mod/github.com/cometbft/cometbft@v0.37.2/proxy/app_conn.go:193
github.com/cometbft/cometbft/rpc/core.ABCIQuery
        /home/ubuntu/go/pkg/mod/github.com/cometbft/cometbft@v0.37.2/rpc/core/abci.go:20
reflect.Value.call
        /usr/local/go/src/reflect/value.go:586
reflect.Value.Call
        /usr/local/go/src/reflect/value.go:370
github.com/cometbft/cometbft/rpc/jsonrpc/server.makeJSONRPCHandler.func1
        /home/ubuntu/go/pkg/mod/github.com/cometbft/cometbft@v0.37.2/rpc/jsonrpc/server/http_json_handler.go:108
github.com/cometbft/cometbft/rpc/jsonrpc/server.handleInvalidJSONRPCPaths.func1
        /home/ubuntu/go/pkg/mod/github.com/cometbft/cometbft@v0.37.2/rpc/jsonrpc/server/http_json_handler.go:140
net/http.HandlerFunc.ServeHTTP
        /usr/local/go/src/net/http/server.go:2122
net/http.(*ServeMux).ServeHTTP
        /usr/local/go/src/net/http/server.go:2500
cannot update Active subject client: invalid update client proposal: invalid proposal content: invalid proposal content [cosmos/cosmos-sdk@v0.47.3/x/gov/keeper/proposal.go:73] With gas wanted: '18446744073709551615' and gas used: '36917' : unknown request

Thanks for trying our suggestion, @VegeBun-csj. I see at the bottom that the error says cannot update Active subject client which is triggered here. The subject client is the one with ID 07-tendermint-0. Are you sure it is not active?

@crodriguezvega Thanks, it works. Awesome!

Thank you, @VegeBun-csj. So was the client indeed still active or was it inactive and the proposal did work? Just curious. :)
I will close the issue now then.