OllamaStreamingChatLanguageModel should support tools

Currently the OllamaStreamingChatLanguageModel doesn't support tool integration. Let's add it.
I'll take this and work on it.

Tools are not supported in any streaming chat.
It's like that in upstream LangChain4j too as well, and honestly I don't see how they could be supported...

Thats not true. OpenAI supports it as do a bunch of others.

I seriously doubt it, but I'd love to be proven wrong

https://github.com/langchain4j/langchain4j/blob/118b15423c883c56c533cd9d2ee366382d1700e6/langchain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiStreamingChatModel.java#L135-L243

Yeah, I was pretty sure that's what you were looking at.
That is going to buy you nothing when using the AI service - which is what I was referring to

So you can certainly go ahead and add the tool support to the streaming chat model in the Ollama case, but don't expect it to have any effect in your application (which behaves the same way as if you used OpenAI)

That is going to buy you nothing when using the AI service - which is what I was referring to

I guess I don't completely understand. Can you explain a bit more?

is it because of the back and forth thats needed in the case of tools? i.e. client makes call, provider responds with something saying "call this tool". client invokes tool, calls back to provider, etc, until provider comes back with complete response?

Precisely!

So then going back to https://github.com/langchain4j/langchain4j/blob/118b15423c883c56c533cd9d2ee366382d1700e6/langchain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiStreamingChatModel.java#L135-L243, how does that work and solve that use case?

That only works for a specific API call - that's what that abstraction does.
But in order to use tools, you need the entire dance that is done in the AI service implementation

That makes sense. I actually just tried it with OpenAI...
2024-07-30 14:58:14,641 INFO  [io.qua.lan.ope.OpenAiRestApi$OpenAiClientLogger] (vert.x-eventloop-thread-1) Request:
- method: POST
- url: https://parasol-chat-aiworkshop.apps.cluster-wk5tx.sandbox3051.opentlc.com/v1/chat/completions
- headers: [Accept: text/event-stream], [Authorization: Be...my], [Content-Type: application/json], [User-Agent: langchain4j-openai], [content-length: 2538]
- body: {
  "model" : "parasol-chat",
  "messages" : [ {
    "role" : "system",
    "content" : "You are a helpful, respectful and honest assistant named \"Parasol Assistant\".\nYou will be given a claim summary, references to provide you with information, and a question. You must answer the question based as much as possible on this claim with the help of the references.\nAlways answer as helpfully as possible, while being safe. Your answers should not include any harmful, unethical, racist, sexist, toxic, dangerous, or illegal content. Please ensure that your responses are socially unbiased and positive in nature.\n\nIf a question does not make any sense, or is not factually coherent, explain why instead of answering something not correct. If you don't know the answer to a question, please don't share false information.\n"
  }, {
    "role" : "user",
    "content" : "    Claim ID: 1\n\n    Claim Summary:\n    \n    On January 2nd, 1955, at around 3:30 PM, a car accident occurred at the intersection of Colima Road and Azusa Avenue in Hill Vallet. The involved parties were Marty McFly, driving a silver Delorean DMC-12 (OUTA-TIME), and Biff Tanner in a blue Type 2 Volkswagen Bus (BIF-RULZ).\n\n    Marty was heading south on Colima Road when Biff failed to stop at the red traffic signal on Asuza Avenue, causing a collision with Marty's vehicle. Both drivers exchanged information and took photos of the accident scene, which included damages to the front driver and passenger side of Marty's Delorean DMC-12 and the front driver's side of Biff's Volkswagen Bus. No injuries were reported.\n\n    Marty has attached necessary documents, such as photos, a police report, and an estimate for repair costs, to his email. He requests prompt attention to the claim and is available at<PHONE_NUMBER> or<EMAIL_ADDRESS>for any additional information or documentation needed.\n    \n\n    Question: Should I approve this claim?\n"
  } ],
  "temperature" : 0.3,
  "top_p" : 1.0,
  "stream" : true,
  "stop" : [ "DONE", "done", "stop", "STOP" ],
  "presence_penalty" : 0.0,
  "frequency_penalty" : 0.0,
  "tools" : [ {
    "type" : "function",
    "function" : {
      "name" : "updateClaimStatus",
      "description" : "update claim status",
      "parameters" : {
        "type" : "object",
        "properties" : {
          "claimId" : {
            "type" : "integer"
          },
          "status" : {
            "type" : "string"
          }
        },
        "required" : [ "claimId", "status" ]
      }
    }
  } ]
}

2024-07-30 14:58:14,702 ERROR [io.qua.mut.run.MutinyInfrastructure] (vert.x-eventloop-thread-1) Mutiny had to drop the following exception: io.smallrye.mutiny.CompositeException: Multiple exceptions caught:
        [Exception 0] dev.ai4j.openai4j.OpenAiHttpException: {"object":"error","message":"[{'type': 'extra_forbidden', 'loc': ('body', 'tools'), 'msg': 'Extra inputs are not permitted', 'input': [{'type': 'function', 'function': {'name': 'updateClaimStatus', 'description': 'update claim status', 'parameters': {'type': 'object', 'properties': {'claimId': {'type': 'integer'}, 'status': {'type': 'string'}}, 'required': ['claimId', 'status']}}}]}]","type":"BadRequestError","param":null,"code":400}
        [Exception 1] java.lang.NullPointerException: Cannot invoke "dev.langchain4j.model.output.Response.content()" because "response" is null
        at io.smallrye.mutiny.subscription.Subscribers$CallbackBasedSubscriber.onFailure(Subscribers.java:95)
        at io.smallrye.mutiny.operators.multi.builders.BaseMultiEmitter.failed(BaseMultiEmitter.java:89)
        at io.smallrye.mutiny.operators.multi.builders.BufferItemMultiEmitter.drain(BufferItemMultiEmitter.java:108)
        at io.smallrye.mutiny.operators.multi.builders.BufferItemMultiEmitter.failed(BufferItemMultiEmitter.java:62)
        at io.smallrye.mutiny.operators.multi.builders.BaseMultiEmitter.fail(BaseMultiEmitter.java:78)
        at io.smallrye.mutiny.operators.multi.builders.SerializedMultiEmitter.drainLoop(SerializedMultiEmitter.java:110)
        at io.smallrye.mutiny.operators.multi.builders.SerializedMultiEmitter.drain(SerializedMultiEmitter.java:92)
        at io.smallrye.mutiny.operators.multi.builders.SerializedMultiEmitter.onFailure(SerializedMultiEmitter.java:77)
        at io.smallrye.mutiny.operators.multi.builders.SerializedMultiEmitter.fail(SerializedMultiEmitter.java:149)
        at org.jboss.resteasy.reactive.client.impl.MultiInvoker.lambda$method$0(MultiInvoker.java:127)
        at java.base/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:934)
        at java.base/java.util.concurrent.CompletableFuture$UniHandle.tryFire(CompletableFuture.java:911)
        at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
        at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2194)
        at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext.handleUnrecoverableError(RestClientRequestContext.java:368)
        at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.handleException(AbstractResteasyReactiveContext.java:329)
        at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:175)
        at org.jboss.resteasy.reactive.client.impl.RestClientRequestContext$1.lambda$execute$0(RestClientRequestContext.java:314)
        at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:279)
        at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:261)
        at io.vertx.core.impl.ContextInternal.lambda$runOnContext$0(ContextInternal.java:59)
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:566)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1583)
        Suppressed: java.lang.NullPointerException: Cannot invoke "dev.langchain4j.model.output.Response.content()" because "response" is null
                at dev.langchain4j.model.openai.InternalOpenAiHelper.removeTokenUsage(InternalOpenAiHelper.java:283)
                at dev.langchain4j.model.openai.OpenAiStreamingChatModel.createResponse(OpenAiStreamingChatModel.java:251)
                at dev.langchain4j.model.openai.OpenAiStreamingChatModel.lambda$generate$5(OpenAiStreamingChatModel.java:217)
                at io.smallrye.mutiny.subscription.Subscribers$CallbackBasedSubscriber.onFailure(Subscribers.java:93)
                ... 28 more
Caused by: dev.ai4j.openai4j.OpenAiHttpException: {"object":"error","message":"[{'type': 'extra_forbidden', 'loc': ('body', 'tools'), 'msg': 'Extra inputs are not permitted', 'input': [{'type': 'function', 'function': {'name': 'updateClaimStatus', 'description': 'update claim status', 'parameters': {'type': 'object', 'properties': {'claimId': {'type': 'integer'}, 'status': {'type': 'string'}}, 'required': ['claimId', 'status']}}}]}]","type":"BadRequestError","param":null,"code":400}
        at io.quarkiverse.langchain4j.openai.OpenAiRestApi.toException(OpenAiRestApi.java:170)
        at io.quarkiverse.langchain4j.openai.OpenAiRestApi_toException_ResponseExceptionMapper_f35c1c86580504f69920f9de921a22bd696c020f.toThrowable(Unknown Source)
        at io.quarkus.rest.client.reactive.runtime.MicroProfileRestClientResponseFilter.filter(MicroProfileRestClientResponseFilter.java:49)
        at org.jboss.resteasy.reactive.client.handlers.ClientResponseFilterRestHandler.handle(ClientResponseFilterRestHandler.java:21)
        at org.jboss.resteasy.reactive.client.handlers.ClientResponseFilterRestHandler.handle(ClientResponseFilterRestHandler.java:10)
        at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.invokeHandler(AbstractResteasyReactiveContext.java:231)
        at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:147)
        ... 12 more

I need to read/play with it a bit more. I've done some searching and it should be possible. At least thats what I think.
But I've been known to be wrong on occasion.... :D

If you can make it work, that would be nice!
I've never tried to make it work myself, but just the thought of it makes me not even want to try 😜

I've never tried to make it work myself, but just the thought of it makes me not even want to try

I'm definitely there with you as I'm digging through it, just trying to watch things fly by...


Returned array of Array.prototype.map() should have same length as original.

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai<EMAIL_ADDRESS>

lgtm

LGTM

Good to me


Transform requests status when returning them to users or admins rather than using a cron job to scan and update

The ticket is derived from #671


Question: Does Room support multithreaded insert (and is it thread-safe if not)?

Essentially, does Room support multithreaded insert, or is it atleast internally synchronized, so I don't run into some kind of Concurrent Modification exception?
I see that you use a single-thread Executor for IO in the samples, so is it necessary, or Room takes care of it itself?
Thanks!

Database takes care of itself so you should not need to worry. Room creates a transaction for each modification automatically. You need to be careful though not to deadlock yourself with your other threads.

Nice question & Nice ROOM


fix incorrect call to right_hand_split()

The second argument to right_hand_split() is an int (line length), but we were passing supports_trailing_commas as a bool. Mypy didn't catch this because bool is a subclass of int. Found this while working on a fix for #759 because I changed the type of supports_trailing_commas.
This affects one test that is now formatted differently, and it also causes a fair number of changes in our codebase. Now that I look at it, in most cases I actually feel like the old formatting is better, so maybe we need to do something different than just fix the type mismatch.

Pull Request Test Coverage Report for Build 971

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 95.953%

Files with Coverage Reduction
New Missed Lines
%

black.py
1
94.79%

Totals

Change from base Build 966:
0.03%

Covered Lines:
3011

Relevant Lines:
3138

💛  - Coveralls

Pull Request Test Coverage Report for Build 971

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 95.953%

Files with Coverage Reduction
New Missed Lines
%

black.py
1
94.79%

Totals

Change from base Build 966:
0.03%

Covered Lines:
3011

Relevant Lines:
3138

💛  - Coveralls

Oh my, this one's embarrassing! It dates all the way back to 3eea3aad when I was fixing trailers (content with brackets) being unnecessarily exploded into their own lines after a dedented closing bracket.

@JelleZijlstra, please add a tiny description of the change to the change log for 19.4c0, please.

This affects one test that is now formatted differently, and it also causes a fair number of changes in our codebase. Now that I look at it, in most cases I actually feel like the old formatting is better, so maybe we need to do something different than just fix the type mismatch.

I had the same experience in one of our codebases where the old formatting was generally better. Is there an issue or plans to address this?

Filed #781 to follow up on this.


Delete this project immediately; you are at risk and could face legal consequences. There are individuals selling this service for money.

Look This Video

You should report this account to whomever might be competent, however, as I already told you, the code is distributed under MIT license, so I am not facing any legal issues myself. Please don't try to intimidate people or I shall report you to github.
I understand that it is a problem, but I am not the one selling services here.
Furthermore, there is no way to prove that this code was actually used to add time to people paying. I hardly see how giving your creds to someone to do your time can be legally reprehensible considering it might be legitimate time added.

@m1dugh I am just warning you, but you will bear the legal consequences that you will face.


This Context Pollution And Inaccessibility

describe("Context Pollution", function () {
  let someErrorMessage;
  beforeEach(function () {
    console.log("bef", this.expectedErrorMessage); // WILL ALWAYS PRINT UNDEFINED
    delete this.expectedErrorMessage; // CANNOT RESET CONTEXT POLLUTION
    this.expectedErrorMessage = undefined; // CANNOT RESET CONTEXT POLLUTION
  });
  it("should fail when the first parameter in mockThisFunction is not a string.", function () {
    this.expectedErrorMessage = constants.errorMessages.MockThisFunctionMockString;
    someErrorMessage = constants.errorMessages.MockThisFunctionMockString;
    expect(this.expectedErrorMessage).eql(this.expectedErrorMessage);
    expect(someErrorMessage).eql(someErrorMessage);
  });
  it("should have undefined values if they are not defined for this test.", function () {
    expect(this.expectedErrorMessage).eql(undefined); // WILL FAIL BECAUSE OF CONTEXT POLLUTION & INABILITY TO RESET THIS CONTEXT
    expect(someErrorMessage).eql(undefined); // WILL FAIL BECAUSE OF CONTEXT POLLUTION & INABILITY TO RESET THIS CONTEXT
  });
  it("should still have undefined values if they are not defined for this test.", function () {
    expect(this.expectedErrorMessage).eql(undefined); // WILL FAIL BECAUSE OF CONTEXT POLLUTION & INABILITY TO RESET THIS CONTEXT
    expect(someErrorMessage).eql(undefined); // WILL FAIL BECAUSE OF CONTEXT POLLUTION & INABILITY TO RESET THIS CONTEXT
  });
});

I know that the context pollution issue has already been discussed, but I still believe this to be a serious defect.  A defect that will push me back towards Jasmine very quickly.  I should only have the variables in a test, that I have explicitly defined within that test.  Anything else WILL lead to false positives in test suites.  This is a basic building block to sustainable test suites!!!

That being said, an even more important issue that I am seeing, is that the same this context is not available in the afterEach & beforeEach, that is available in the it blocks.  This means that I can never reset the context pollution, unless I manually do it inside of every it block. Is this intended functionality?  Am I doing something wrong?

I would expect to have access to the same this context throughout all describe, afterEach, beforeEach, and it blocks.  Especially since Mocha allows the this context to be polluted between tests.

I am using the most recent version of Mocha as of today which I believe is 2.4.5.  Thanks for any help / direction you can provide.  Thanks.

Closing as a dup of your other issue https://github.com/mochajs/mocha/issues/2140


Unselected tab does not active on click for drag and drop and passes underground.

Firefox: v61.0.1
Chrome: v67

Although it seems a bit odd, that’s actually the behavior of Google Chrome.


Question

First of all thank you very much for this boilerplate, it's great work and has been tremendously helpful for me to gain an understanding of koa2 and async/await.
I'm struggling to understand the purpose of these pieces of code in /modules/index.js:
const lastHandler = handlers.pop();
return await lastHandler(ctx)
From what I can tell this is so you can check if it is the lasthandler by checking if next exists, but why would you need to do this?

No problem at all. That's what OSS is all about :)
The lastHandler was introduced in #5 following a problem that @alansikora pointed out where the ctx was being lost after chaining multiple middleware. I haven't had a chance to test this all too well but I'm thinking of an alternative. Maybe wrapping middleware in a utils function that auto returns next for chaining.
Sorry I took so long to answer. Not gonna lie to you, I marked this as a question then completely forgot.


Replace $timeout with $interval

This commit replaces all instances of $timeout with $interval in the notification directive.
An $interval with a repeat count of 1 behaves in exactly the same way as $timeout, however Angular's
protractor testing framework treats this methods differently.
The full reason for this change is described in https://github.com/jvandemo/angular-growl-notifications/issues/28
Closes https://github.com/jvandemo/angular-growl-notifications/issues/28

@sfount Merged and released as v2.5.0. Thank you for your contribution, much appreciated! 👍


docs-only change

Image building fails because I don't have the right credentials.
Docs GHA should run, but BPF build, smoke tests, and Kind test should be skipped.

test-me-please


Bugfix in undistort_image

This commit fixes a couple of issues in undistort_image. When the distortion model has large inaccuracies at the boundary, or when the user would specify a large crop dimensions for the undistorted images, it would crash. The solution is to do adjustments to keep things within bounds.
A second fix is to nvm_visualize. This has some functionality for deleting images, which only I use (it is useful though), and sometimes due to how getKey() works in OpenCV the tool thinks the 'Del' key is received when in fact another signal was sent.  The reason for that is obscure. This fix allow images to be deleted in nvm_visualize only with the 'x' key, and a comment about that was added.


[X/case] This refines guidance on usage of X and case statements

Based on our internal discussion this week, this PR refines the guidance on the usage of unique case statements and X literals in RTL.
In particular, the guidance on X has been completely revised in order to favor a style that eliminates X literals in RTL as much as possible, and encourages the extensive use of SVAs to check invalid behavior in RTL instead.
Note that this guidance shall not affect DV code that is not meant to be synthesized, and X can still be used if it is safe to do so.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Note that this is a WIP PR. Once the initial draft has been stabilized, I will invite more reviewers to comment on the changes.

Should we mention somewhere in the style guide that X are still ok in DV related code that is not meant to be synthesized? I believe this could also solve some of @GregAC's concerns regarding X assignments used in bus models.

Should we mention somewhere in the style guide that X are still ok in DV related code that is not meant to be synthesized? I believe this could also solve some of @GregAC's concerns regarding X assignments used in bus models.

@sriyerg is considering (probably has already started) a style guide for verification code. We could put a brief mention here and save the rest for that section / document.

Added a revised version of the style guide.
@mwbranstad, I also added an example that shows which operator to use within the context of flip-flop resets if (!rst_ni) as opposed to if (~rst_ni).

Can you do the second commit in a separate PR? That one should be easy to agree on and get merged, and will keep the discussion here focused.

Removed the sentence stating that large LUTs may be an exception to the new guidance on X.

Removed the following recommended example, as it uses an unclocked assertion which may be susceptible to glitches in simulation:
// alternative using inline assertion
always_comb begin
  out0 = '0;
  out1 = '0;
  unique case (sel)
    mode1: out0 = foo;
    mode2: out1 = bar;
    default: `ASSERT_I(Invalid_A, 0);
  endcase
end

See also https://github.com/lowRISC/ibex/pull/528 for context.

I am putting this up for review after this initial round of comments. PTAL.
We are likely going to do a general editing pass in the future to make the style guide more compact - but this will be a separate PR.

Squashed.

Are there any other comments that should be addressed before moving this one in?
@GregAC can you give this another look and unblock the PR if you are happy with the current state?

A few comments, but otherwise this is looking good to me. If there isn't an issue already filed, please file one to create security-related coding style and assertion guidance, CCing the usual suspects.

Thanks for giving it another look, I've filed an issue.

Should we mention somewhere in the style guide that X are still ok in DV related code that is not meant to be synthesized? I believe this could also solve some of @GregAC's concerns regarding X assignments used in bus models.

@sriyerg is considering (probably has already started) a style guide for verification code. We could put a brief mention here and save the rest for that section / document.

@udinator, let's ensure that we address this in the DV style guide.

Ok it looks like we converged on this one - merging.


Chembl pretrained

@michal-pikusa Is there a pre-trained model on CHEMBL you have released or is that for the community to create?

Hi @bmiles,
we don't provide a pre-trained model, however, you should be able to create one fairly easily.
There's a sample ChEMBL dataset in the pQSAR repository for download:
https://github.com/Novartis/pQSAR/tree/main/sample_data
The compounds file contains SMILES that you can encode with MoLeR (which provides a pretrained ChEMBL encoder/decoder - https://github.com/microsoft/molecule-generation). And the assay data file contains the pIC50 values for different ChEMBL assays that can be used to create a profile for each compound. Having both the molecular encodings, and the profiles, you can train pqsar2cpd as shown in the readme.
Hope that helps.


Improve Examples in Docs - Make it easy to use examples

Given that using code examples as is into projects is becoming a fashion, it would be a good idea to add multiple commonly used examples for all components along with the actual code.
An example would be to extend what is present in stepper and data-table docs to all components.

We did a first pass, but the main goal is to have proper demos with code that you can copy + paste and a plnkr demo of the component people can play around with it.
This will probably have to be separated into smaller issues to attack each component separate.

@asaph26 @emoralesb05 - I'm really struggling to use Covalent, every code example I've copied so far from the docs either throws errors or just plain out doesn't load. I've even been trying to copy examples from the very comprehensive demo app and its just not working. I am a pretty switched on programmer, I can't believe I'm just being a numpty, surely I must be missing something? Is there assumed knowledge about how Covalent works that I am missing?
I'm trying to make my app look like this screenshot: http://pasteboard.co/M4Uhxtf5W.png
(Card Over Layout with Fly-In Navigation Drawer)
When I copy the code in the example layout, I end up with this: http://pasteboard.co/M4V2B35Ra.png

I was expecting the example to have Navigation like the other layout examples that come with navigation in the demos.
I figured maybe this one needs a Navigation Drawer, so I look at those docs and add the td-navigation-drawer directive to the page only to find that nothing renderes and no errors are thrown.

I then thought well what if I just copy the example code from the Navigation Drawer page ( https://teradata.github.io/covalent/#/style-guide/navigation-drawer ) and see how it looks, still nothing loads.
Code: http://pasteboard.co/M54bp2Q8y.png
HTML: http://pasteboard.co/M55v4UHcM.png
I'm sorry to keep posting, I am just super keen to use Covalent but am growing increasingly frustrated with my experiences getting it to work "out of the box".  Any help on this one would be greatly appreciated.

In the world of node angular development there is little copy and paste development left with all the thousands of node dependencies, strict version dependencies, proper use of typescript etc. If you need copy and paste start with our quickstart and copy all the functional code from GitHub directly from demos. This applies to any angular, react, etc, repo. Much of the code in our docs does actually work if you have everything setup properly and you're copying and pasting from the demo tabs (don't just copy documentation code that actually list all the code options in the snippets). We follow docs style from angular-material and angular as a best practice. Obviously we can and will get better docs over time as we get more contributors but this isn't like copying and pasting bootstrap CSS code, it's much more complex by the nature and power of the angular
Once you get a better handle of it we'd appreciate PRs showing how you'd documented it to make it easier

@iceman3000, how familiar are you with Angular2 and bootstrapping Angular2 apps? Covalent cannot solve it for you unless you use the quickstart, and modify that code.
You indeed have to understand what you are copy-pasting. And sometimes you have to figure out dependencies when you use the examples in the covalent docs.
But I if you spend a few weeks with Angular, it will be easy. In the beginning it can be hard indeed.

Thanks for your comments guys. After commenting I decided to do exactly that. I took the starter project and ripped everything out of it that I didn't want and copied my routes, services etc from the project I'd been playing with. So far I seem to have it working.
3 Examples of issues I've hit so far that I think should be corrected in the Docs, however not sure where to make those suggestion are as follows:
The use of broadcast in the demo seems to break as seen here:
https://github.com/Teradata/covalent/issues/425
The Data Tables Docs has a syntax error as seen here:
http://pasteboard.co/MuohmvVDe.png
The Data Table Example throws .length undefined (not sure why selectedRows is undefined, no docs on how to use or manipulate the selected rows data):
http://pasteboard.co/Mupkaq2tC.png
@kyleledbetter I absolutely love the project and would be happy to help however possible (although as stated, I'm not anguar2 wiz yet) - just let me know :) - I think the docs are quite nice and well laid out, just examples are proving hard to get working on a clean project. Maybe a step by step tutorial on constructing your own app from scratch explaining how to configure all the dependencies and structures etc. This is something I may even be able to do, but I'll need to get a little more familiar. I find when I'm learning something that reading docs is a struggle, I much prefer to just google "thing tutorial" and then learn from actual implementation. Because Covalent is so new, there is pretty much no mention on Google of anything outside of this Git Site.
@istvanszoboszlai This is my first time using TS and Angular2 - It's really really fresh, like within 2 weeks and I only code after work for a few hours at night.

@iceman3000 I think it is better if you can break your learning into understanding Angular and then focussing on using Covalent. Despite the fact that the documentation is not complete it is written with the assumption that people are comfortable with Angular at a basic level.
Selected Rows
This is a short tip. (Some version of this needs to be updated in the docs)
Looking at your examples, the reason selectedRows is not defined is because you need to define it as an Array_(which has the length property associated with it)_. So in your component you need to do something like this.
import { Component, ChangeDetectionStrategy } from '@angular/core';
import { TdDataTableService, ITdDataTableColumn, ITdDataTableSelectEvent, ITdDataTableSelectAllEvent } from '@covalent/core';

@Component({
   selector: 'some-component',
   templateUrl: './some-component.component.html',
   styleUrls: ['./some-component.component.css'],
   changeDetection: ChangeDetectionStrategy.OnPush
})
export class SomeComponent {

   selectedRows: any[] = [];
   data: any[] = [];
   columns: any[] = [];

   constructor () {}

   //... All your code to generate the columns and data
}

The data table has a value Accessor attached to it (By this I mean it has a value property that can be accessed through ngModel. So you can have a two way data binding using the ngModel on the selectedRows property. Your template would look like this in that case.
<td-data-table [data]="data" [columns]="columns" [(ngModel)]="selectedRows" selectable="true"></td-data-table>

Everytime a row is selected, selectedRows contains the row. If there is a row already present in selectedRows, it is selected in the data table.
There are also other ways to handle the selected rows. You can listen to the onRowSelect and onSelectAll events and populate the selected Rows array

duplicate of #1164


Remove readme's content and fix fake bug

This PR isn't going to be checked-in until the new quickstart goes live.

This PR isn't going to be checked-in until the new quickstart goes live.

Closing the PR as this change is going to be pushed on the new repository.


feat: highlight plugin add support for line start

Summary

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] Briefly describing what this PR does in the title in Angular Commit Message Conventions, e.g. fix: rebuild when a page is added

This PR makes it possible to start a code block from a different line number.
```js {lineNumbers:true,lineStart:5}
const cry = Array(3).fill('ora').join(' ')
```

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Closes #600

Hi can you update the docs as well? https://saber.land/docs/markdown-features.html


does not implement prepareCall

I used the samples to create my own little app and run into this issue:

I was wondering why it works in the samples but not in my own project. I found the mistake, but I'm still wondering about it.
When I add androidTestImplementation Libs.AndroidX.Compose.uiTest it is gone.
Why does adding an androidTestImplementation fixes the issue? Is this a bug in the samples or somewhere in Android or one of the used libraries?

Not related to samples

This also happens in the examples when you remove the androidTestImplementation Libs.AndroidX.Compose.uiTest.


Ability to deploy multiple packages sequentially with awaits between

https://github.com/Cognifide/gradle-aem-multi/blob/develop/build.gradle.kts#L20

implemented, to be released within 6.x


Is there an un-upload hack in geode

Your Question
So here's why I'm wondering
So on July 7th, GD's shitty anti-bot system thought I was a bot and deleted all my levels, including 6 rateworthy levels, 5 of which got into the magic tab.
If I want to reupload the levels in vanilla GD, I will have to create copies of them, which will reset the "time spent in editor" thingy, which will prevent them from getting into the magic tab and cause people to think they are stolen (they are not, all 6 levels were made solely by me)
Is there any Geode hack that lets me reupload them without resetting the time spent in editor, and get the levels into the magic tab?
Sorry if I'm not asking in the right place

try QOLMod or Prism Menu, they might have something like this
side note: this isn't a Geode issue

try QOLMod or Prism Menu, they might have something like this
side note: this isn't a Geode issue

ok


Create 1396-design-underground-system.js

Adding solution for design-underground-system in JS.
File(s) Added: 1396-design-underground-system.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/design-underground-system/submissions/971928886/

Suggestion: Write code as a class

Understood. Will do that.

@aakhtar3, It's done. I updated the submission link in the initial comment.


Add poligran.edu.co domain

@andres-solarte I am sorry, the domain poligran.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


SA1200 code fix does not move usings in a region

I would expect the following test to pass, but currently the code fix for SA1200 is not able to move the block of using directives:
        [Fact]
        public async Task TestInvalidUsingStatementsInCompilationUnitWithRegionAsync()
        {
            var testCode = @"#region Comment
using System;
using System.Threading;
#endregion Comment

namespace TestNamespace
{
}
";

            var fixedTestCode = @"namespace TestNamespace
{
    #region Comment
    using System;
    using System.Threading;
    #endregion Comment
}
";

            DiagnosticResult[] expectedResults =
            {
                this.CSharpDiagnostic(SA1200UsingDirectivesMustBePlacedCorrectly.DescriptorInside).WithLocation(2, 1),
                this.CSharpDiagnostic(SA1200UsingDirectivesMustBePlacedCorrectly.DescriptorInside).WithLocation(3, 1),
            };

            await this.VerifyCSharpDiagnosticAsync(testCode, expectedResults, CancellationToken.None).ConfigureAwait(false);
            await this.VerifyCSharpDiagnosticAsync(fixedTestCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
            await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
        }

Remarked this as needs discussion, as the general philosophy of StyleCop has always been against using regions.
Personally I don't see a need to implement this and I would therefore vote against it.
Besides that, the implementation of this will be quite difficult due to the possible overlaps / nesting of preprocessor directives.


Auto-bottle reset to Off when loading game

Hello !
When I place a hauling point in the map, assign it a ressource & turn On auto-bottle, dupes will deliver to it, but they wont after game reload. I have to manually turn auto-bottle Off, put it back On after save loading and dupes will start to deliver again to it.
I've made you a screen-capture of the bug to make things as clear as possible: https://www.youtube.com/watch?v=O1EwuTf5QNc
Attached Player.log
( I can also provide the output of the mod "Debug Console // by @Ony" if needed)
Thanks !

Thanks for pointing out this issue.
Box did not properly load serialized data due to an obvious error in my code.
Let me know if it occurs again.


Silent Install not creating shortcuts

Describe the bug
Version 2.39 using full .msi Installer.
Running msiexec /i "ScreenToGif 2.19.3 Setup.msi" /quiet /norestart INSTALLDESKTOPSHORTCUT=yes INSTALLSHORTCUT=yes doesn't create any shortcuts. Running without the shortcut parameters doesn't create any in start menu or desktop either. Has something changed?
These are the commands from #549 which were advised to work and the issue was closed.

I am able to reproduce this issue  with the latest version of ScreenToGif (version 2.41.0) when installed as the built-in Windows user 'NT AUTHORITY\SYSTEM'. The logs suggest that the installer is coming up with the wrong values for the ProgramMenuFolder and DesktopFolder properties:
ProgramMenuFolder = C:\WINDOWS\system32\config\systemprofile\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\
DesktopFolder = C:\WINDOWS\system32\config\systemprofile\Desktop\

These values should be:
DesktopFolder = C:\Users\Public\Desktop\
ProgramMenuFolder = C:\ProgramData\Microsoft\Windows\Start Menu\Programs\

My guess is that the MSI installer incorrectly retrieving the 'NT AUTHORITY\SYSTEM' user profile paths instead of the expected public folders, resulting in the shortcuts not being created in the correct locations.
Alternatively, the installer may not be properly handling the ALLUSERS or MSIINSTALLPERUSER properties when installed by the 'NT AUTHORITY\SYSTEM' user. These properties determine whether the application is installed for all users or only the current user, and they affect the locations where shortcuts and other user-specific files are created. If the installer is not setting ALLUSERS=1 correctly, it may be falling back to the 'NT AUTHORITY\SYSTEM' user profile paths instead of the public folders. Similarly, if the MSIINSTALLPERUSER property is not being handled properly, it could lead to the same issue.
In summary, the root cause is likely related to the installer incorrectly retrieving the folder paths or not properly handling the ALLUSERS or MSIINSTALLPERUSER properties when installed by the 'NT AUTHORITY\SYSTEM' user, resulting in the shortcuts not being created in the expected public folders.


use password to access Redis

@Duologic Thanks for the pull request. It looks like the logic to inject the password isn't covered by any unit tests. Can you add one?

Sorry, I'm not a dev (but in operations) and not very familiar with unit tests. Would you mind providing one yourself? Or maybe another Dev can take it on?
I've tested it in a production environment though, so I'm pretty sure it works. :-)


container name case insensitive

The container name is case insensitive so the check must consider this.

case insentivity of service identifiers is deprecated https://github.com/symfony/symfony/pull/21223


Maps with special keys (AnyRefMap and LongMap) cannot map/flatMap etc

The four operations map, flatMap, ++, and collect cannot be used with AnyRefMap or LongMap and still produce a map of the appropriate type.  This is not just a compile-time issue for map, flatMap and collect; the map is actually made as a generic HashMap even if the element types are okay.  With ++, the map type is preserved, but the compiler forgets what it is and calls it a generic mutable.Map.
This should be improved if possible, as these are all really basic operations and having them essentially "not work" significantly limits the usability of the maps with special keys.

IIUC the fix is to add overloads of the map, flatMap, ++ and collect operations.


create configuration file for MaMMUT training

Summary:
Mostly based on original coca and https://github.com/lucidrains/MaMMUT-pytorch
Update the logics of loading checkpoint for MaMMUT text decoder as well.
Differential Revision:
D52891614
Privacy Context Container:<PHONE_NUMBER>74201

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6bf3779) 75.61% compared to head (dd7f97e) 75.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   75.61%   75.59%   -0.03%
==========================================
  Files         234      234
  Lines       16123    16122       -1
==========================================
- Hits        12192    12188       -4
- Misses       3931     3934       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


popover link doesn't work

I have an object with bootstrap popover and the link does not work. Popover shows up, but I can't click on the object and go to other page.
code looks like this:

Can somebody help please?

The popover will disappear when you leave the triggering element. That's unfortunately a known limitation of popover at this time.


[Snyk] Upgrade org.apache.logging.log4j:log4j-core from 2.14.1 to 2.23.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-core from 2.14.1 to 2.23.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 13 versions ahead of your current version.
The recommended version was released 23 days ago, on 2024-02-17.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Remote Code Execution (RCE) SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2314720
929/1000  Why? Mature exploit, Has a fix available, CVSS 10
Mature

Remote Code Execution (RCE) SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2320014
929/1000  Why? Mature exploit, Has a fix available, CVSS 10
Mature

Denial of Service (DoS) SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2321524
929/1000  Why? Mature exploit, Has a fix available, CVSS 10
Proof of Concept

Arbitrary Code Execution SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2327339
929/1000  Why? Mature exploit, Has a fix available, CVSS 10
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Setup an automatic regen token

Needs to deal with the expiration of the previous one which means that the extension would go offline, not being able to get any data from it.

https://twitchtokengenerator.com/

This issue will be resolved by the normalization of the token using a special API (side project)


Fix f. missing chart bar add (+all) icon

This PR fixes the following bug:
When allowing for multiple short URLs for a same long URL (bitly behavior [behaviour]), the chart bar adding symbol linking to YOURLS_SITE/keyword+all does not show up on infos pages.
This issue exists at least since YOURLS 1.7.0.
To reproduce this bug e.g. with a fresh install, first set
define( 'YOURLS_UNIQUE_URLS', false );
in YOURLS/user/config.php. Then, in the admin panel, create two short URLs pointing both to a same long URL, e.g. to http://yourls.org. Let us assume that the short URLs are /1 and /2. Now visit the infos page for one of the short URLs, e.g. by visiting YOURLS_SITE/1+ in your browser (or by clicking the chart icon in the respective row for that short URL in the admin panel's table).
Sadly, no clickable chart bar adding symbol linking to YOURLS_SITE/1+all (depicting chart_bar_add.png) shows up on the infos page.
Fix (in yourls-infos.php):
The canonical way to fix this is to just move the line
$keyword_list = yourls_get_longurl_keywords( $longurl );
out of the if-statement testing $aggregate. That way, the $keyword_list is set correctly regardless of the value of $aggregate. This is needed later on:
if( isset( $keyword_list ) && count( $keyword_list ) > 1 )
    {code echoing the +all-link, depicting chart_bar_add.png}

And since $keyword_list is only needed when duplicate long URLs are allowed, we can avoid the DB access involved with a call to  yourls_get_longurl_keywords() in the case that duplicate long URLs are not allowed:
íf( yourls_allow_duplicate_longurls() )
    $keyword_list = yourls_get_longurl_keywords( $longurl );

OK, thanks! (the Travis error is not introduced by this change)

OK, thanks a lot :+1:


[regression] [VSCode] UnoCSS language server doesen't unload and reload properly

UnoCSS version
0.56.4
Describe the bug

When opening a project or saving the config file (!!!!!!), the unocss language server loads again, without unloading:

it loads progressively more an more instances of itself

It also doesen't reload & put anything into output when files defined in configDeps change, forcing me to trigger reloading by saving config, and causing another instance of the language server
Please, fix this bug soon! it is making it unbearable to work with unocss!! And (as far as i know), you cannot even downgrade the VSCode extension, so i'm stuck with this until it's resolved! Thanks!
EDIT: i found out how to downgrade extension in vscode, but it's still a hassle downgrading all the unocss packages too.
Reproduction
Cannot reproduce in stackblitz, as it doesen't use the VSCode extension.
I am using a custom preset loaded from an external file, if it helps, but i don't think that's the issue.
System Info
Windows 10, Sveltekit, UnoCSS 0.56.4
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It works fine on unocss 0.56.2

It works fine on unocss 0.56.2

This problem has been fixed in the next version
related: #3181

thanks! will re-open if it still is an issue

I am still experiencing somewhat of an issue with this.. I have to manually refresh VS code to see the plugin's data.. Perhaps its because I have a specific unoroot setting VS code such as this (although this may not be related)
"unocss.root": "./web",

I am working on a Nuxt3 project that uses two folders, one studio and another web

Just checking to see if anyone is still experiencing this? If there are further issues perhaps we can reopen this?

I am still experiencing somewhat of an issue with this.. I have to manually refresh VS code to see the plugin's data.. Perhaps its because I have a specific unoroot setting VS code such as this (although this may not be related)我仍然遇到一些问题。.我必须手动刷新VS代码才能查看插件的数据。也许是因为我有一个特定的 unoroot 设置 VS 代码，例如这样（尽管这可能不相关）
"unocss.root": "./web",

I am working on a Nuxt3 project that uses two folders, one studio and another web我正在处理一个Nuxt3项目，该项目使用两个文件夹，一个 studio 文件夹和另一个 web 文件夹

Just checking to see if anyone is still experiencing this? If there are further issues perhaps we can reopen this?只是检查是否有人仍然遇到这种情况？如果还有其他问题，也许我们可以重新打开它？

I think you can remove unocss.root, which should be able to detect changes in uno.config. The new features do not take into account the logic of the original uno.root configuration.

@Simon-He95 I removed the unoroot and it seems to be working now! Thank you for the help on this:)


Update 3d tiles version, use on demand rendering in demo

Updates 3d tiles renderer to the lastest version, which fixes the fade plugin to trigger an r3f rerender on change so we can use on demand render to lessen battery usage.

Looks great! I'm merging it now.


Add dpdkConfig to HostNetworkTemplate for vfio-pci binding and bridge/port creation

ovsConfig changes in HostNetworkTemplate for vfio-pci binding and ovs/dpdk bridge/bond creation.
Allows setting mtuRequest, bondMode, lacp.
Example HostNetworkTemplate,
apiVersion: plumber.k8s.pf9.io/v1
kind: HostNetworkTemplate
metadata:
  name: ovs-dpdk-config
spec:
  ovsConfig:
  - bridgeName: "ovs-br01"
    nodeInterface: "eno2.1000"
  - bridgeName: "dpdk-br01"
    nodeInterface: "eno2"
    dpdk: "true"
  - bridgeName: "ovs-bond01"
    nodeInterface: "eno1,eno2"
    dpdk: "false"
    params:
      mtuRequest: "9192"
  - bridgeName: "dpdk-bond01"
    nodeInterface: "enp1s0f0,enp1s0f1"
    dpdk: "true"
    params:
      mtuRequest: "9000"
      bondMode: "balance-tcp"
      lacp: "active"

Codecov Report
Patch and project coverage have no change.

Comparison is base (b47e669) 0.00% compared to head (1d29f54) 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #57   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files           1       1
  Lines         634     634
======================================
  Misses        634     634

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


refactor(HOC): extract authenticate functions

Manditory Checks

[ ] I added new tests for the issue I fixed or the feature I built
[x] I ran npm test for the package I'm modifying
[ ] I used npm run commit instead of git commit

Extract authenticate functions.
Rename types and interfaces.

Please go through this carefully @TylorS

It’s best to rebase the PR before merging.


Analytics Datas

Hello,
Can I get analytics data via API? If the answer is yes, can you show me a small example of how I can do it?
Thank you

I don't believe it's currently possible, however, I am working on adding just that as it's a needed in a project of mine.

Can the information on this page help us?
Is it not possible to get data with CURL?

@emresaracoglu yes, it is possible to get analytics data by API. The link you provided has a curl example
curl -X GET "https://api.cloudflare.com/client/v4/zones/023e105f4ecef8ad9ca31a8372d0c353/analytics/dashboard?since=2015-01-01T12:23:00Z&until=2015-01-02T12:23:00Z&continuous=true" \
     -H "X-Auth-Email<EMAIL_ADDRESS>\
     -H "X-Auth-Key: c2547eb745079dac9320b638f5e225cf483cc5cfdda41" \
     -H "Content-Type: application/json"

I can get the data but there is a big problem this time :)
I do not know how to read a complicated JSON file.
I plan to use a JSON reader for this. Maybe this; JsonReader - @pcrov
How do I read in the best way for JSON?
for example; bandwidth in JSON
$ch = curl_init();
	curl_setopt($ch, CURLOPT_URL,"https://api.cloudflare.com/client/v4/zones/ZoneID/analytics/dashboard?since=2017-11-06T12:23:00Z&until=2017-11-07T12:23:00Z&continuous=true");
	curl_setopt($ch, CURLOPT_POST, 0);
	curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

	$headers = [
		'X-Auth-Email: Email',
		'X-Auth-Key: Key',
		'Content-Type: application/json'
	];

	curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
	$server_output = curl_exec ($ch);
	curl_close ($ch);

You can pull my fork until they add to a release from - https://github.com/MeekLogic/cloudflare-php
I've added getAnalyticsDashboard() to Zones

@MeekLogic That's great work! Thank you for your time.
I have updated repository with your files
Could this connection be true?
$zones = new \Cloudflare\API\Endpoints\Zones($adapter);
	$analytics = $zones->getAnalyticsDashboard("bbea500d1b4ca10bf242d9af01950fd6");
	foreach ($analytics as $goster) {
		echo $goster['bandwidth'];
               //echo $goster['uncached'];
	}

You probably don't want a foreach unless you are looping through the "timeseries"
If you want to get bandwidth total should be something like this
$zones = new \Cloudflare\API\Endpoints\Zones($adapter);
$analytics = $zones->getAnalyticsDashboard("bbea500d1b4ca31fd42d9af01950fd6");

echo $analytics->totals->bandwidth->all;

Tyler, do you know?
You are great man! 😃  Thank you again
@MeekLogic

Released in 1.0.6


[Feature]: Needs proper validation for CurrencyInput and PhoneInput

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
We need to add proper validation for Currency field of CurrencyInput widget and Default Country Code field of PhoneInput widget.
Why should this be worked on?
This will help the user to write error free code when switching to JS mode.
https://user-images.githubusercontent.com/10436935/163799442-c087951d-7056-4b64-b376-10cd1cd141a9.mov

Stats

Stat
Values

Reach
3

Effort (months)
0.5


pixhawk test runner script

I'm not sure if this is worth contributing, but I find it useful. It's just a simple python script that I run right after a successful upload that shows the console output as the tests are running and returns a failure code if the onboard tests fail. It makes it easy to setup jenkins or equivalent for hardware tests.
make upload px4fmu-v2_test && ./Tools/pixhawk_watch_tests.py /dev/serial/by-id/usb-Keyspan__a_division_of_InnoSys_Inc._Keyspan_USA-19H-if00-port0

Have you seen this?
http://dronetest.io

On Thu, Oct 1, 2015 at 3:53 AM, Lorenz Meier<EMAIL_ADDRESS>wrote:

Have you seen this?
http://dronetest.io
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/pull/2924#issuecomment-144647233.

Yes and it looks quite nice, but I'm already heavily invested in jenkins
for other projects so having another CI system just for pixhawk is overkill
when most of the benefit can be replicated in jenkins with a little script.
As I said, I'm not sure if it's worth committing, but I figured other
people might be in the same position.


API handler should not return a value, received object.

Since few days, i've this new warning message showing up in console when graphql api route is called. All still works fine but should i worry about this message ? Thank you in advance !
 "@apollo/client": "^3.7.15",
 "@apollo/server": "^4.7.3",
 "@as-integrations/next": "^2.0.0",
 "next": "^13.4.5",
 "react": "^18.2.0",

If everything works fine I don't think there is anything to worry about, but I will look into this!

Any updates to this?

I believe it's caused by this line; res.end returns the NextApiResponse.
This should probably be written as:
res.end();
return;


Issue#346 - Allow multiple Langchain prompt template keys

Work in Progress!!
Description
The change allows users to use multiple prompt template keys.
Fixes # https://github.com/run-llama/llama_index/issues/346
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works - Need some help testing this, as this is my first time working with this repo and I am not aware of how to reproduce the issue. I have reached out on the discord chat but haven't got any response about the same. Any help is appreciated.
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

Going to close this one out for now, its quite outdated at this point
If its still an issue, please raise an updated PR
Sorry for letting this one sit for so long!


NLTK download() error

Hi, I'm trying to load a self-made grammar file and there is a consistent resource error showing up:

Resource [93mC:[0m not found.
Please use the NLTK Downloader to obtain the resource:
[31m>>> import nltk

nltk.download('C:')
[0m
For more information see: https://www.nltk.org/data.html

Attempted to load [93m/C:/nltk.data/grammar.cfg[0m
Searched in:
- ''
After this message showed up, I typed 'nltk.download('C:') and yet it presents another error message:
[nltk_data] Error loading C:: Package 'C:' not found in index
False
I already downloaded everything from NLTK, I have no idea why there is a missing resource and how I can download 'C:'.
How can I solve this problem?

It looks like you might be using Windows. May I suggest trying to replicate the issue with a Ubuntu app ( something along the lines of https://apps.microsoft.com/store/detail/ubuntu-2204-lts/9PN20MSR04DW ). Or running any other Linux in WSL 2 on Windows.

Hi, I actually solved the problem. (It was something regarding the file extension.) Thank you for your help!

Hi!
I ran into the exact same issue today: I'm running a linux container on Google Cloud Run, but for some reason when nltk goes looking for those directories, it adds those extra characters you also saw.
How did you solve your issue?


Daily trading

Hello and thanks for great project.
Just wondering if it is possible to run TradzQAI with daily data or just in high frequency setup with minute bars.
Thanks.

Hello,
You can run TradzQAI with all data frequency you want, i've just push 1M data for exemple.
Keep me posted if you have any trouble.

Live session allow only 1M frequency, i'm working to add a support to handle any frequency. I will add a setting for this soon.


You can close trapdoors that you are not on the group for

If you are not on the citadel group for a trap door, and you press a button (maybe levers too) the trapdoor will default to closed. I am wondering if this is part of the check for preventing using trapdoors when not on the group. But in some situations trapdoors are open on purpose (such as with vanity builds) and being able to close them should not be possible.
If you are not on the group, you should not be able to interact with the trapdoor (whether it is opening or closing). This issue does not appear to happen when the button gets pressed, but instead with the button depresses. Do buttons have two separate actions? And is there a check being done on pressing, but not depressing? Or does depress always default to closed for some reason?

PR #52 should fix the problem.

We just ignored "close door" event
On the button/plate depressed (lever turn off) - we lose the track of the player who depressed it

Therefore:

Do not ignore "close door" event
Use redstone distance validation on "close door" instead of checking "player track list" (authorizations)


Xamarin.Essentials: iOS Specific Info About Share Photos

A application will be crushed if the user clicks the "Save image" button in "Share" window.
This action assumes that the following keys will be in the Info.plist":
<key>NSPhotoLibraryAddUsageDescription</key>
<string>This app needs access to the photo gallery for saving photos and videos.</string>
<key>NSPhotoLibraryUsageDescription</key>
<string>This app needs access to photos gallery for saving photos and videos.</string>

______________
With Keys
Without Keys
______________

@jamesmontemagno @mattleibow Hi. Could you check it out?


chore(package): update ava to version 3.8.2

Coverage remained the same at 88.217% when pulling 7c8baf22c885201518fc31bcf5cc237ff2e833db on greenkeeper/ava-3.8.2 into 1a9d17140d3af0c5cbc86cddf5d140af8d692018 on master.


Document new ignored_warnings_from config setting

ref https://github.com/foundry-rs/foundry/pull/7063
https://book.getfoundry.sh/reference/config/solidity-compiler
cc @loocapro

assigned, ty

Hi @mabsattar are you still interested in working on this?

hi @zerosnacks  thank you for reminding me, i just saw this is still pending.
Can I please give it a try now ?
I'll try to get this fix ASAP and will update you.

hi @zerosnacks thank you for reminding me, I just saw that this is still pending.
Can I work on it now and fix it ASAP.
I'll update you once its done or if I face any issues.

Thanks @mabsattar, no worries

Hi @mattsse @zerosnacks , sent the PR for this, please let me know if any changes needed. thanks


Reviewing 5x Testnet EDP FAQ articles

Need to review some older Testnet EDP related articles before adding to the FAQ.
https://www.notion.so/cere/Community-Portal-KB-78c4aecd596641ad86b53ddb0ed75b57?pvs=4#8b3be63ed9764099adef8635e8c2d756


Rename various TileMap methods/properties for clarity and consistency

The YSort renames were tracked in https://github.com/godotengine/godot/issues/16863.
This closes https://github.com/godotengine/godot-proposals/issues/814.
@tylerecouture Does the new description look good to you, or should it be further clarified?

Thanks!


add kafka 2.2.1 to CI

add kafka 2.2.1
update 2.1.0 to 2.1.1

+1

Is there any issue with 2.3?

@Elyahou yes the tests failed for 2.3
https://circleci.com/gh/zendesk/ruby-kafka/3873?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Thanks!


Bluetooth: controller: Add support for setting public address

This allows to provide public address for controller without using
VS HCI command from host. Useful for controller only builds or
combined builds that are not using VS HCI commands
Signed-off-by: Szymon Janc<EMAIL_ADDRESS>

Codecov Report

Merging #10132 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10132   +/-   ##
=======================================
  Coverage    52.5%    52.5%
=======================================
  Files         213      213
  Lines       26140    26140
  Branches     5634     5634
=======================================
  Hits        13726    13726
  Misses      10159    10159
  Partials     2255     2255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a013ce3...ae59233. Read the comment docs.

This looks fine to me, but needs an approval from the controller folks

Needs review from @cvinayak


versions: Update version of qemu to 5.1.0

This update is being done to address some of the 9p
issues seen with a bug introduced in 5.0:
https://bugs.launchpad.net/qemu/+bug/1877688
Depends-on: github.com/kata-containers/packaging#1197
Fixes #2978
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

/test-ubuntu

/AzurePipelines run

/test-vfio

Okay, I have no idea why CI is failing with this PR, neither much time to debug it.
We tried, we did, but it won't make to 1.13.0.


#1665 update webpacker BAM

I rule and have completed some work on Case Manager that's ready for review!
This pull request makes the following changes:
updated webpacker gem and re-added yarn audit 🤞
(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:

Fixes #1665

closing bc needed a fix!


[BEAM-3702] adding fromJvm to create pipelineoptions from the system properties

Adds a factory method in PipelineOptionsFactory to instantiate the PipelineOptions from the "JVM" which means using the environment and system properties (in this order to support overriding).
It also adds a factory from plain properties to let users read it the way they want.
To be flexible enough, and as discussed on the list, the factory can take a prefix to filter the properties
and if not is provided the default is "beam.".

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

removed null checks and env usage, added Map<String, String> support - I'd like to keep Properties bridges since it is how you will get it in practise, and added a fromMap. Hope it fixes issues you point out. We'll see on the list for other points.

Hi, just curious if it makes sense to mark these new methods as @Experimental at least until we are sure the names/contracts are right and they won't change. (Note, you can just ignore me if you are convinced it won't, just telling because these are new sdks/core things so contract is stricter).

@iemejia no strong opinion on that, planning to move to listmultimap later today to finish it so can add @exp at the same time

Yes, good point @iemejia. These should all be @Experimental.

updated code for listmultimap and @Experimental points

LGTM overall and about my comment on Experimental. @rmannibucau please rebase because there are merge issues.

rebased

addressed the changes and merged with master. hope it is fine this time :)

Please fix up the javadoc errors:
2018-03-18T19:18:01.876 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:jar (attach-javadocs) on project beam-sdks-java-core: MavenReportException: Error while generating Javadoc:
2018-03-18T19:18:01.876 [ERROR] Exit code: 1 - /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:1924: error: unexpected end tag:
2018-03-18T19:18:01.876 [ERROR] * key/values.
2018-03-18T19:18:01.876 [ERROR] ^
2018-03-18T19:18:01.876 [ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:276: error: unexpected end tag:
2018-03-18T19:18:01.876 [ERROR] * as a prefix in this case.
2018-03-18T19:18:01.876 [ERROR] ^

fixed

Please fix the javadoc errors:
[ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:273: Redundant <p> tag. [JavadocParagraph]
Audit done.
2018-03-21T21:43:26.135 [INFO] There is 1 error reported by Checkstyle 8.7 with beam/checkstyle.xml ruleset.
2018-03-21T21:43:26.138 [ERROR] src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:[273] (javadoc) JavadocParagraph: Redundant <p> tag.


Add giveaway group to bot

A friend of mine suggested adding as well the tracking capability to another group (giveaway one https://t.me/annetaantavaraa).
Right now I am thinking about letting the user select to which group s/he is willing to track (either one of them or both).
It would be nice to add a keyboard panel (not sure about technical name) so the user can toggle.

Done :)

Still needs to be selectable xd (new issue is gonna be opened for that)


Large patches parse slowly

v 1.1.7 Chrome / Linux
On a issue like https://drupal.org/node/1497374 (200+ comments, many patches), dreditor adds like 7 / 8 seconds processing time after initial page load (that is, before JS behaviors / extensions like mouse gestures become available)

Dreditor is being decommissioned due to the lack of availability of current maintainers and the fact that Drupal.org is becoming more feature rich at a much faster rate than Dreditor itself now.
This decision was also partially made due to the amount of work (complete rewrite) it would take to create an "official" Firefox extension (#256).
If you already have the extension installed, it should continue working for a while until, inevitably,  the markup on Drupal.org changes. It will no longer be updated.
We understand that many of you love this extension, as do we. This isn't the end, in fact, it's a much brighter beginning. All the things we love about Dreditor can, and should, be moved into Drupal.org natively.
For more information, please follow: https://www.drupal.org/node/2779729

This issue was moved to dreditor/dreditor#54


undefined method `filter_map' in RulesCompressor#simplify

I have a bit older Rails project and and i have been using CanCanCan for years without a problem.
Today I updated the bundle and I am getting undefined method `filter_map' in RulesCompressor#simplify
Works fine on 3.5.0
System configuration
Rails version: <IP_ADDRESS>
Ruby version: 2.6.3
CanCanCan version: 3.6.0 +

Yes, indeed this method is available only from ruby 2.7.
I am not planning to keep support for ruby < 2.7, so I'd suggest you to either lock the gem or update the ruby version.
We are not testing the gem anymore for ruby < 2.7, sorry.

@coorasse Then you should raise the required_ruby_version, right?
https://github.com/CanCanCommunity/cancancan/blob/eab3019553dedf0ab2487e1aacd06bb16d89c703/cancancan.gemspec#L22

Agree!


Speedup data reader

Issue #2195, if available:
Description of changes: @emptymalei @julian-sieber and I have implemented a significant speedup of the data reader. @jaheba Please have a look. We significantly simplified the from_schema method in the decoder by using dictionaries directly instead of the need to infer the idx of the ndarray columns (maybe you have further ideas to simplify the code? we did not do this yet in order not to break anything). For the moment, the implementation is only for data frames the rows of which contain 1D- or 2D-arrays.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: other change

@mr-1993 looks like style checks are failing; we use black to enforce coding styles, you can fix the issue by installing it and running
black src test

and committing the changes it applies.

Thanks @lostella! Should be fixed by now

Some tests fail atm, but not related to our implementation (numerical instabilities)

Thanks for the PR.
Do you have any comparison numbers on how much this improves decoding?

Atm, we have just tested it on our internal data which we are not allowed to share (but which contains a lot of 2D arrays). We will run some consecutive experiments on open source data, but for benchmarking, we already provide this screenshot with the results:

Thanks! These are massive improvements. Can you share a bit what the shape of the data is? I assume the larger each row is the bigger the performance difference gets. If I remember correctly, I saw a 2x improvement on some simpler case I tested, but this looks much more impressive!

Thanks! These are massive improvements. Can you share a bit what shape the data has? I assume the larger each row is the bigger the performance difference gets. If I remember correctly, I saw a 2x improvement on some simpler case I tested, but this looks much more impressive!

Our dataset contains 500 rows with: 12 columns that contain strings or integers, and 11 columns that contain arrays. 6 of these arrays are one-dimensional and 5 are two-dimensional. They have varying sizes, the largest of the one-dim arrays contain around 270 elements, the largest two-dim arrays contain around 15x270 entries

@mr-1993 I went ahead and implemented the changes myself. Hope you don't feel overlooked!
Thanks a lot for the PR 🎉

@jaheba @lostella Thank you very much for the cooperation! Hope to contribute other things as well! Also, thank you for implementing the last changes and sorry for our delay in that regard...we were blocked last week.


go-task: 3.37.2 -> 3.38.0

Description of changes

Supercedes #323629

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 326317 run on x86_64-linux 1

3 packages built:

arduino-ci
arduino-cli
go-task

Thanks :)


More than one copy of React in the same app

When I'm using different version of react and react-dom compared to switch-selector,  I'm getting this error.

Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:

You might have mismatching versions of React and the renderer (such as React DOM)
You might be breaking the Rules of Hooks
You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

Please try with https://github.com/GR34SE/react-switch-selector/releases/tag/v2.3.0


Remapping

Add new remapping step (possibility to remap BAMs)
fastqFiles renamed to inputFiles
MapReads for remapping will now convert BAM to FASTQ and feed it to BWA on the fly

PR checklist

[x] PR is made against dev branch
[x] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[x] Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
[ ] Documentation in docs is updated
[x] CHANGELOG.md is updated

The only thing that is really missing is tests for this new feature...
But as this is an edge case, I'm wondering if we should test it or not.
What do you think?

The index is not in the TSV when mapping BAMs.
I figured that if you want to (re)map BAMs, there's little use of the indexes.


changes to install hps-lcio on mac

The hard-coded path the system types in src/cpp/src/UTIL/lXDR.cc is no longer up to date for newer OS versions (starting with macOS Mojave, see here):

old version

#if defined(__APPLE_CC__)
#include "/usr/include/sys/types.h"
#endif

new version; location of these files changed. Here, the path is hard-coded again to the MacOSX12.3 version. Ideally, this would be set dynamically but I don't know how.

#if defined(__APPLE_CC__)
#include "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/sys/types.h"
#endif

I also added a line declaring the new location of the system types to the CMakeLists.txt (more or less for good measure). I don't know if this actually need but installing hps-lcio on my mac works now so it doesn't hurt.
The gitignore file is added to get rid of the build and install directories.
NOTE: The link in the README is no longer up to date. It would be great if someone could update this (or remove it).

Any of the suggestions here work?
https://stackoverflow.com/questions/10165335/can-cmake-specify-the-base-sdk-on-mac-os-x
I do not have access to a Mac for testing.

Bad idea to include the SDK, even if you figure out how to update it dynamically with cmake.
I think "types.h" is not even needed. Have you tried just dropping it?


angular2 2.0.0-beta.11 removes @View - breaks ng-semantic

I received error message:
angular2-polyfills.js:332 Error: TypeError: core_1.View is not a function(…)
Afer a little debugging, I realized 'angulars/core' doesn't have a View() class which is now breaking the ng-semantic components.  I've looked at your code and it looks like all you need to do is move your @View values into the @Component.
Please see:
https://github.com/angular/angular/commit/f9fb72fb0e9bcbda7aeebbf8321ce5d70d78ecee
I'll try rolling back to beta.9 for now.

Updated to Beta.13


Multiple forward slashes in paths may pass-through security with htpasswd

related to https://github.com/mholt/caddy/issues/1859.
With this minimal caddyfile:
http://localhost:8080 {

  log stdout
  root C:\webroot
  ext .html
  header /members Cache-Control "no-cache, no-store, must-revalidate"

  jwt {
    path /members
    redirect /login
  }

  login {
        success_url /members/private
        htpasswd file=passwords
  }
}

multiple forward slashes may pass-through the security.
I did these tests:

http://localhost:8080/members/1.jpg (redirects to login)
http://localhost:8080//members/1.jpg (passes through login and shows the image)
http://localhost:8080//members//1.jpg (passes through login and shows the image)
http://localhost:8080/members//1.jpg (redirects to login)

It's a critical vulnerability.

Hey @magikstm, that looks critical.
But if so, than it would be a bug in jwt-Plugin, not in loginsrv, right?
@BTBurke, please take a look

I think it's a bug in Caddy as reported by @hstaugaard (see https://github.com/mholt/caddy/issues/1859).
Unsure though. Just took the time to read it, test it and confirm it.
It also seems critical to me.

Ok, I'll close it here, because the in loginsrv I can't do anything for that.
It has to be solved in caddy or the jwt plugin.


result

Why is the effect so much worse than yours, and how can pre-training weights for image distortion b

e obtained

Sorry, I can not see the image here and what happened?


Added catalog.install functionalty and related unit tests

Signed-off-by: Bharath Narayan<EMAIL_ADDRESS>

Fixes #16

hi @bharath-m-g.  Thanks for your contribution.  Sorry, today I have added some extra tests with flake and that appears to have stopped the build.  Apart from that, the code looks good - happy to merge!

Hey @snowch I will probably fix the CLI test failure later, its working in remote anyways... I don't have any other changes to add to this PR.


chore(deps): update vitess/vttestserver:mysql80 docker digest to 0fab0bb

For https://github.com/prisma/prisma-engines/pull/4130

Duplicate of https://github.com/prisma/prisma/pull/20639


[Bug] improper alingment of the table rows with there header

Please refer the screenshot for the same
Environment :
Windows 7 > Chrome

Duplicate of #982


Fixes (and updates for newer vscode versions)

I went through and modified everything that vscode was complaining about when generating a theme.
I also adjusted the gray level of the inactive tab text color, because it was super hard to see.

I've left in the deprecated theme items for older VSCode versions and removed commented out items but taken everything else. Thanks for the PR.


Revert "manifest: Use cri-o module from Fedora"

This reverts commit 67025f3d40d34fe171611fb23fad054e049f9cf7.
Reverting #249 as now cri-o module lags behind in F36 and it affects OKD 4.11, as predicted in https://github.com/openshift/okd-machine-os/pull/249#issuecomment-1149794989

/test e2e-aws

F36 has cri-o 1.24.3 (the latest of the 1.24 stream as of toda), is that not sufficient? https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2022-36658a0c2d
Not entirely opposed to this in general though. I don't find modules a joy to work with, although I'd prefer pulling the RPM from a Fedora build.

I just saw https://github.com/okd-project/okd/issues/1310 now, and I think if we are going back to RPMs, we should probably switch that over https://copr.fedorainfracloud.org/coprs/g/OKD/okd/package/cri-o/ (and pin to a specific version here) instead of using the OBS builds.

F36 has cri-o 1.24.3

Right, I rebuilt machine-os-content on Friday and it didn't land there yet

Not blocking this nonetheless, we've had these troubles before.
/lgtm

/test e2e-aws
a lot of CSI tests are failing

/test e2e-aws

/test e2e-aws


Disable default closing paren indentation.

This contradicts our styleguide
https://github.com/alphagov/styleguides/blob/master/ruby.md#general

Disabling for now pending discussion :+1:


[Docs][UI] Style the version component.

Current State
There is not much style on the version of the new docs dropdown component

Desired State
Add styles and make it look similar to the other tabs in the navbar, follow the same color scheme

Contributor Guides and Resources

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I would like to try this issue. @Chadha93

All yours @msaini0r 🎉

@msaini0r can we talk on slack , i have question regarding this .

@msaini0r can we talk on slack , i have question regarding this .

@varunsaral sure

This a good update to make.

@msaini0r how is this coming up? If you are having any issues/blockers you may ask on the #meshery or #meshery-ui channel in slack.

Hi, @Chadha93 please assign me this issue. let me give it a try.

Can I work on this issue @Chadha93

@Akshit42-hue before getting assigning, lets confirm that you are able to build docs locally.

Yes, I can build docs locally

Yes, I can build docs locally

great, lets wait for @AbhishekJamhoriya 's response, if he is not available you can make a pr for this. :)

@Chadha93 I'm working on it .

Should I help in this issue @AbhishekJamhoriya @Chadha93

This issue is still present on latest. Reopening this

Hey @Chadha93
Which techstacks do I need to know about for taking up on this issue?

@rakshitgondwal see the first link in the contributor resources section. Ruby, Jekyll, Bundler. Ideally, macOS or Linux, or WSL2 on Windows.

@leecalcote  can I work on this issue?

@amRohitKumar Sure, are you able to run docs locally? If yes, let's assign you.

Hello @Chadha93, I want to work on this issue. Please assign it to me.

Hello @Chadha93, I want to work on this issue. Please assign it to me.

Sure, are you able to run docs locally? If yes, let's assign you.

Hello @Chadha93, I want to work on this issue. Please assign it to me.

Sure, are you able to run docs locally? If yes, let's assign you.
Yeah! It's perfectly running fine on my local system. Here is a screenshot to support this.
https://ibb.co/KNKmDXZ

Hello @Chadha93, I want to work on this issue. Please assign it to me.

Sure, are you able to run docs locally? If yes, let's assign you.

Yeah! It's perfectly running fine on my local system. Here is a screenshot to support this

@Chadha93
Keppel Color Variant:

Carribean Color Variant:

can you give some feedback on the design or suggestion changes? or looks okay?


The Code Editor starts but appear all black

@elultimocapo421 so you where able to start using code --disable-gpu but the window did not appear?


server responsed with empty location

fyi, I was trying tusc-sh which is a shell implementation of tus to try to upload to rustus but had some problems
I created the following issue https://github.com/adhocore/tusc.sh/issues/21
I wonder if it's because rustus should respond with the location or if the tus protocol has changed.

I guess the protocol changed ever since. But you can use https://github.com/cenkalti/tus.py this project to upload files via cli.

Thanks, I tested this and it works!


Revert "Reduce number of unsafe and insane presents"

Reverts space-wizards/space-station-14#22067
Reasons for:

The whole point is that it was chaos.
It was unjust to reduce the chaos.
Project Managers liked the chaos.

Reasons against:

Too much chaos is problematic.
It's fine how it is right now.
Head admins didn't like the issues that come with so much chaos.

This PR will be either closed or merged, based on maintainer's choice.

Was there some discussion that preceded this PR being made.

Ret in the admin discussion after #22067 was merged.

Also @moonheart08 seemed to be more for keeping the choas as part of the whole point, but for the other PR (#22065):

Basically the nerf was controversial, so I'm offering a chance to unnerf it, depending on maintainer/admin consensus.

The chaos stuff is a lot more subjective. Every round could be extremely chaotic if that's what players wanted and admins could manage, but I doubt most players want an entire month of never ending chaos. I don't know how chaotic things were for the short time the other percentages were being used, I only really have the accounts of other admins to go off of

1/3 rounds being somewhat chaotic because someone got an uplink, debug, admeme thing or whatever is funny; Most of the time it's not a big deal

worth noting however i'm perfectly fine with the nerfed odds.


Dashboard hangs when shutting down

This is what happens when running eshoplite and shutting down.
fail: Grpc.AspNetCore.Server.ServerCallHandler[6]
      Error when executing service method 'WatchResourceConsoleLogs'.
      System.OperationCanceledException: The operation was canceled.
         at System.Threading.CancellationToken.ThrowOperationCanceledException()
         at System.Threading.CancellationToken.ThrowIfCancellationRequested()
         at Grpc.AspNetCore.Server.Internal.HttpContextStreamWriter`1.WriteCoreAsync(TResponse message, CancellationToken cancellationToken)
         at Aspire.Hosting.Dashboard.DashboardService.WatchResourceConsoleLogs(WatchResourceConsoleLogsRequest request, IServerStreamWriter`1 responseStream, ServerCallContext context) in C:\dev\git\aspire\src\Aspire.Hosting\Dashboard\DashboardService.cs:line 110
         at Aspire.Hosting.Dashboard.DashboardService.WatchResourceConsoleLogs(WatchResourceConsoleLogsRequest request, IServerStreamWriter`1 responseStream, ServerCallContext context) in C:\dev\git\aspire\src\Aspire.Hosting\Dashboard\DashboardService.cs:line 101
         at Grpc.Shared.Server.ServerStreamingServerMethodInvoker`3.Invoke(HttpContext httpContext, ServerCallContext serverCallContext, TRequest request, IServerStreamWriter`1 streamWriter)
         at Grpc.Shared.Server.ServerStreamingServerMethodInvoker`3.Invoke(HttpContext httpContext, ServerCallContext serverCallContext, TRequest request, IServerStreamWriter`1 streamWriter)
         at Grpc.AspNetCore.Server.Internal.CallHandlers.ServerStreamingServerCallHandler`3.HandleCallAsyncCore(HttpContext httpContext, HttpContextServerCallContext serverCallContext)
         at Grpc.AspNetCore.Server.Internal.CallHandlers.ServerCallHandlerBase`3.<HandleCallAsync>g__AwaitHandleCall|8_0(HttpContextServerCallContext serverCallContext, Method`2 method, Task handleCall)

This might be fixed by https://github.com/dotnet/aspire/pull/1578.

@davidfowl What is the start of the app when you start shutting down? Do you still have a browser open for the dashboard?

Fixed in #1589.  That timeout exists with #1578 too.
Once the dashboard and app host are separate, the dashboard process shouldn't be keeping the app host alive. I would expect we can avoid that timeout.

The error message in the issue description is unrelated to the hang, but is fixed in #1590.

This isn't fixed, it took 30 seconds to shutdown the dashboard:

Something isn't responding to the shutdown token and unwinding. It's likely the streaming grpc call.

IHostApplicationLifetime. But I want to understand more about what is happening here. And splitting the app host and dashboard might impact what we do.
@davidfowl Please give more details about what is happening and what do you expect to happen.
In the original issue you said the app hangs on shutdown down. I'm presuming you mean that the app would wait for 30 seconds while trying to drain remaining requests, and then give up and do an abortive shutdown. That's what I observed.
The cancellation fixes that we've added means that the streaming gRPC call is canceled when someone closes the dashboard. If the dashboard UI isn't open the shutting down the app is instant.
However, if someone still has the dashboard UI open, there is still a delay while outstanding HTTP requests are completed. That would include any gRPC calls, but I'm guessing the Blazor Server web socket connection that the browser has open is also included.
When someone CTRL+C's the aspire console and the dashboard UI is open, what do you want to happen?

I would expect it to not hang for the 30 seconds before shutting down. I recall there being times when this happened but compare it to preview 2 and you’ll see the difference

The timing does suggest gRPC connections are involved. I'll pick this up and get a fix filed.

Fixed in https://github.com/dotnet/aspire/pull/1633

@davidfowl this should be fixed now. Let me know if you see any more delays.


[SQL] Two DataFrame fixes.

Removed DataFrame.apply for projection & filtering since they are extremely confusing.
Added implicits for RDD[Int], RDD[Long], and RDD[String]

Test build #27308 has started for   PR 4543 at commit 81ec915.

This patch merges cleanly.

Test build #27308 has finished for   PR 4543 at commit 81ec915.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27308/
Test FAILed.

Jenkins, retest this please.

Test build #27312 has started for   PR 4543 at commit 81ec915.

This patch merges cleanly.

Test build #27312 has finished for   PR 4543 at commit 81ec915.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27312/
Test PASSed.


Updates chalk to 1.0.0.

Updates Chalk to latest version, 1.0.0. See the releasenotes for the changes.
This is the first major version, and the API can now be considered stable.
This commit and PR is auto-generated. Please merge with care. My apologies if it's undesirable.
Made with ♥ by Sindre, Joshua, and all our wonderful contributors.

Coverage remained the same at 100.0% when pulling a283e15c2b144d90700f7d62c72c56afb9f3631f on jbnicolai:update-chalk-v1.0.0 into 35285d9cc4d9e311c2781bf6f83b3a810c9752ec on wbyoung:master.

Coverage remained the same at 100.0% when pulling a283e15c2b144d90700f7d62c72c56afb9f3631f on jbnicolai:update-chalk-v1.0.0 into 35285d9cc4d9e311c2781bf6f83b3a810c9752ec on wbyoung:master.


Added Funds Modal - Icon and Formatting Issues

Describe the bug

It seems that there is a problem in our language translation files for Dutch. In the added fund model when funds are added we show,

Notice that the check-mark is not appearing correctly. In fact in the language files this is what we have,
https://github.com/opencollective/opencollective-frontend/blob/2ca840c773042c8ed45d8f8f2ba101397d7c3073/lang/nl.json#L280
which seems to be incorrect as other language files shows the check-mark correctly.

In addition, the amount is not appearing in front of the label but always below the label which makes it look ugly.

To Reproduce
Steps to reproduce the behavior:

Set the language to Dutch
Go to a collective whose host you administer
Add Funds some funds and got to the success page
See issues described above

This is reported at, https://opencollective.freshdesk.com/a/tickets/311206

Fix deployed

Fix deployed

Thanks 👍🏽


added accessibility functionality to quanticFacetValue Implementation B

SVCC-2272
SVCC-2273
SVCC-2274
Implementation A:
https://github.com/coveo/ui-kit/pull/2237

Implementation B
Edited tabindex to change the accessibility of certain elements.
Function onKeyDown added to track keyboard input
Removed <lightning-input(used as checkbox) and added dom element DIV to serve as checkbox(icon);
aria-label added to provide msg for screen readers
!!Further changes to NumericFacetValue might be needed!!

Solution rejected


Consolidate and document approach for externally defined code systems

Namely for EMA code systems, we need an approach that is clear, documented and validated across other WPs. We may choose a temporary solution only for validating the resources and support profiles, without waiting for an EMA FHIR IG.
@gcangioli suggested to look into the different options, this issue captures such a need.
At the closure of this issue we should have the approach documented in the IG, checked with WP1 and applied to the resources that need it.

What we need for the EDQM terminologies is correspondance lists between EDQM coding of PDFs (and ADFs), and language mappings.
All this can be exported from the EDQM website on standard terms, but the question is in what kind of resource we will store it, locally, for use in UNICOM by persons and people that do not have access to SPOR (not belonging to an NCA).
EDQM has a limited but steady updating cycle.  That needs to be taken into acount.
There is an ISO standard for multilingual terminologie (TMF). Should that be an intermediate resource before sending data to FHIR resources ?
The following standard term types need to be considered:
Dose forms, routes of administration, unit of presentation, container.
The question of the coding systems for substance (EU-SRS, via SMS, and SPOR) is best discussed in another issue.
UCUM is not under EMA. We should provide it also a resources.
bob

EMA SPOR lists have been added to the IG.
For SMS, just the PPL substances (and related modified substances), because otherwise we'd need to keep a list of 50 000 concepts in the IG and it makes things slow).


Fixed link in the docs

See: https://docs.zendframework.com/zend-expressive/v3/reference/migration/#new-features

[x] Is this related to documentation?

Thanks, @webimpress


[BUG] future type annotations doesn't work

Describe the bug
using future type annotations fails the test
from __future__ import annotations
from tawazi import xn
@xn(unpack_to=2)
def return_tuple() -> Tuple[int, int]:  # noqa: UP006
     return 1, 2

resolved in #210 and #211


Set custom test server?

💡 Feature description
I would like to system test my own server and wasm client package together. wasm-pack provides a lot of what I need, but I would like to use my own server instead of the internal one.
💻 Basic example
I can imagine something like this:
my-server --bind https://<IP_ADDRESS>:8000 &
wasm-pack test --server https://<IP_ADDRESS>:8000 --headless --firefox

So basically we allow wasm-pack to redirect requests to a specified host that should be started beforehand.

Yeah, seconded.  I'd like to be able to configure the test server, in particular to set CORS headers (and I'm sure more stuff later), and it seems like this would be the general way to do this (and more).


Scroll to specific item on responsive carousel

Hey there! Thanks for such a great tool!
Is it possible to set which item displays first on a responsive carousel? I tried adding scroll with no luck...
(function($) {
    $(function() {
        var jcarousel = $('.jcarousel');
        var lIndex = 5;
        jcarousel
            .on('jcarousel:reload jcarousel:create', function () {
              var carousel = $(this),
                  width = carousel.innerWidth();

              if (width >= 900) {
                  width = width / 3;
              } else if (width >= 600) {
                  width = width / 2;
              } else if (width >= 250) {
                  width = width / 1;
              }

              carousel.jcarousel('items').css('width', Math.ceil(width) + 'px');

              console.log("index: " + lIndex);
            })

            .jcarousel({
	            scroll: lIndex
	          });

        $('.jcarousel-control-prev')
            .jcarouselControl({
                target: '-=1'
            });

        $('.jcarousel-control-next')
	        .jcarouselControl({
	            target: '+=1'
	        });
    });
})(jQuery);

We are displaying sports scores and want to set the first item you see to be based upon the time of day by setting a var of 'lIndex' as noted in my code.
This is the staging site for reference:
http://www.thesportsarena.net/staging/public_html/#skatesafescorescroller
Any help would be greatly appreciated. Thanks again!

Hello. You can call scroll method without animation after jcarousel initialization.
jcarousel
  .on('jcarousel:reload jcarousel:create', function () {
    ...
  })
  .jcarousel() // initialization
  .jcarousel('scroll', lindex, false); // call scroll without animation for setting initalized slide

This is covered here: https://sorgalla.com/jcarousel/docs/cookbook/custom-start-position.html