Changes default encoding from UTF8_GENERAL_CI to UTF8MB4_UNICODE_CI

Does anyone have another opinion on this?
http://stackoverflow.com/a/766996/977422

Travis configuration should be updated:

remove v0.6 and v0.8
add v6
fix/remove mariadb?

As for this change, I definitely think it needs to wait for 3.0, probably going along with actually fixing the way encoding works in this module, which is still fundamentally broken. The reason I think this is a major version change is because it is breaking (it will break against old server versions that do not understand this encoding) and also I noticed it will actually act differently against people using the current encoding and writing to mb4 columns with chars outside the BMP, thus changing their data storage without a major.
As for your trouble testing, not sure why you are having trouble. I literally just ran all these tests at the beginning of this week and everything worked. I am not going to remove 0.6/0.8 testing as long as we support those versions, and removing support is also a major version bump. I agree that we can definitely remove on 3.0, but this should not be because it's not technically possible to test, just less headaches.

Ah, @dresende, I see why the tests are failing: you committed failing commits directly to master. Please revert commits on master that fail CI. Please us branches to test commits before making them to master, or at least revert them on master as soon as you see them fail. Otherwise everyone coming to this project for the past 2 hours will think this is a joke project that cannot even pass it's own tests.

@dresende for now I just moved those commits over to this branch so we can take whatever time is needed figuring out what the test failures are and can get the build badges back to "green" in the meantime (I'm surprised I figured out how to do this from my phone :O while I'm away from the computer).

Apparently even after reverting those changes from master, AppVeyor is not going to pass. The changes in the May 2nd update (http://www.appveyor.com/updates) must have changed something, because mysqladmin no longer seems to be in the PATH. Someone will need to take a look into that and get AppVeyor back working again, which is now an urgent ask since master was touched and we have a failing badge :( I should be on a computer in about 6 hours or so, so if no one has fixed it before then, I can take a look.

About the encoding, I would be happy with change from utf8_general_ci to utf8_unicode_ci. The general one is just wrong.

About committing to master, it's supposed to be unstable. And AppVeyor is to blame on this too.

About the encoding, I would be happy with change from  utf8_general_ci  to  utf8_unicode_ci . The general one is just wrong.

It's still a major version bump in my mind, unless you can explain how it would not change the behavior of people's apps when upgrading? It would seem to me if it doesn't change anything then there is no point and if it does change something... well now we're breaking people and it would need to be a major version bump.

About committing to master, it's supposed to be unstable.

No, not on this repo, which is run with a stable master. If we think it should be unstable, then let me know what needs to be changed so that the badges on our published npm version wont be red and failing, driving users away.

And AppVeyor is to blame on this too.

Sure, but if something is pushed to master and breaks the build, the committer should not be doing anything else but fixing the issue. Yes, CIs can break, but I don't think that after all these hours any effort has been put into trying to fix it?

than a project succeeding with a commit 2 months old :)

The commit may have been old, but I literally just pushed it up this week, it it has been succeeding for just a few days now. Anyone can click on the build and see when it was last run.

I had pushed up this weekend because I wanted to cut a patch with the pending changes. Now that the build is failing, I will not release any patches until it is resolved and passing so we know we are releasing something that functions on Windows.

Actually that commit was just pushed up two days ago, not months ago. You can see on the build page https://travis-ci.org/felixge/node-mysql/builds that "Update bignumber.js to 2.3.0" was only just built 2 days ago, not months ago, so this means the project was building fine just recently.
And the same with AppVeyor: https://ci.appveyor.com/project/dougwilson/node-mysql/history. This project was building just fine only 2 days ago.

So since I got to a computer, I was able to read the AppVeyor upgrade notes and just update the path, it was pretty straight forward.
Back on topic to this pull request, I think changing the charset makes sense, just my point is that it would be a major version bump unless there is some reason it's not that I'm not seeing (http://semver.org/ has the general guidelines for how to determine these things).
If this is agreeable, we can mark this as milestone 3.0. Currently everything in https://github.com/felixge/node-mysql/milestones/3.0 is slated for 3.0, with some ready to go, just waiting for a 3.0 to land on, to other not started, but are really BIG problems, for example the really non-sense charset handling in this module (#804). Since this seems so closely related to #804 to me, I think it would make the most sense to land them together. I know #804 does not have much detail, but it boils down to this module just completely ignores all the charset information coming in the fields packets, creating a bunch of garbage in various cases. In fact, this module literally assumes that the charset sent in the handshake was accepted the server, which is not always the case, and changing this to a mb4 one could make this case more common, and case a lot of issues if #804 is not fixed first. For example, the client starts asking for mb4, the server doesn't link it and just falls back to latin1. Now this module is decoding as UTF-8, not latin1.

Check the response on stack overflow that I mentioned, I added on purpose. utf8_general_ci is bad for non roman languages, specially for sorting. It's not the default for some years now on mysql. There's no rush on pulling this, it's just something I believe is important to set as good defaults. It's there at least since 5.5.3 and no one should use that version anymore.. (I know, legacy, but I prefer security updates)

Right, I read the SO post :) and I agree, this change makes sense, even as-is being MB4-based. I guess my only opinion is just that I think it makes sense to target 3.0, nt that the change itself is bad, if that makes sense.

About supporting v0.6 and v0.8, I was just considering tests. We shouldn't worry about versions that are no longer maintained (v0.10 will be off soon). And to properly update the module to handle encodings I think those versions will be an obstacle.

Indirectly, it can force people to upgrade to more stable and maintained versions (in terms of security).

And to properly update the module to handle encodings I think those versions will be an obstacle.

Since doing that I couldn't figure out how to make supporting it working in a backwards-compatible way, we can drop any versions we want during that change since it's major anyway. I figure no point on even trying to go below 0.10 these days.

I think, changing the default encoding is a good thing.
The question is when.
I usually change the default encoding on my projects anyway.
But changing this before 3.0 might break things for other people.
IMO 3.0 is the right time to make this change.

for some reason the code below forks ok with utf8 encoding and not with utf8mb4
c.query('select "test 💩" ', (err, rows, fields) => {
  console.log(rows, fields);
});

When UTF8MB4_UNICODE_CI is used as charset, all chars outside of BMP are replaced with '?' ( single 0x3f byte ) - in field name only, but not in the value, so the output using this branch is
[ RowDataPacket { 'test ?': 'test 💩' } ] [ FieldPacket {
    catalog: 'def',
    db: '',
    table: '',
    orgTable: '',
    name: 'test ?',
    orgName: '',
    charsetNr: 224,
    length: 24,
    type: 253,
    flags: 1,
    decimals: 31,
    default: undefined,
    zeroFill: false,
    protocol41: true } ]

and with master it's
[ RowDataPacket { 'test 💩': 'test 💩' } ] [ FieldPacket {
    catalog: 'def',
    db: '',
    table: '',
    orgTable: '',
    name: 'test 💩',
    orgName: '',
    charsetNr: 33,
    length: 27,
    type: 253,
    flags: 1,
    decimals: 31,
    default: undefined,
    zeroFill: false,
    protocol41: true } ]

@dougwilson , do you have explanation for this mysql behaviour?


[MS7] Unified memory management #2

This story aims to build on the work delivered in #1969 and continue with following tasks:

[ ] Document recyclers
[ ] Improve queue factory interface (#2075)
[ ] Address leftover recycler reviews (#1401)
[ ] Replace leftover ThreadLocals
Overhaul main (targeting Log4j version 3.0.0) branch

Port changes from 2.x

Bump compiler version to Java 17 (#2021, 77245ddae8e9ffc2b355def5d87ce4d8b61ac819)

Auxiliary support files (9651905cbefbc2a92c6b98ff41bc60e4959b1aff)
[ ] Website & changelog
Modules

[ ] log4j-1.2-api
[ ] log4j-api
[ ] log4j-api-test
[ ] log4j-appserver
[ ] log4j-core
[ ] log4j-core-its
[ ] log4j-core-test
[ ] log4j-csv
[ ] log4j-docker
[ ] log4j-flume-ng
[ ] log4j-gctests
[ ] log4j-iostreams
[ ] log4j-jcl
[ ] log4j-jdbc
[ ] log4j-jdbc-dbcp2
[ ] log4j-jndi
[ ] log4j-jndi-test
[ ] log4j-jpl
[ ] log4j-jul
[ ] log4j-kubernetes
[ ] log4j-layout-jackson
[ ] log4j-layout-jackson-xml
[ ] log4j-layout-template-json
[ ] log4j-layout-template-json-test
[ ] log4j-mongodb4
[ ] log4j-osgi-test
[ ] log4j-parent
[ ] log4j-perf-test
[ ] log4j-plugin-processor
[ ] log4j-plugins
[ ] log4j-plugins-test
[ ] log4j-script
[ ] log4j-slf4j2-impl
[ ] log4j-slf4j-impl
#2018
[ ] log4j-to-jul
#2015

I would also propose to bind #2076 to this task as a cleanup job.
The whole log4j-slf4j-impl should IMHO be removed from 3.x or at least reimplemented in terms of log4j-slf4j2-impl.

I am currently working on:

log4j-script,
log4j-slf4j-impl,
log4j-slf4j2-impl,
log4j-to-jul

so I marked them as done to prevent collisions.

Related to this are PRs that remove additional dependencies from log4j-core:

[ ] #2142
[ ] #2154

completed


Remove legacy api support.

There's one minor update to the parameters in creating and modifying article method: Previously:
curl -X POST http://<IP_ADDRESS>:8086/v0/planets/my/999BB908-B79A-4C89-8DA6-1339BDFCE03E/articles \
  -F<EMAIL_ADDRESS>\
  -F "title=title" \
  -F "content=content"

Now:
curl -X POST http://<IP_ADDRESS>:8086/v0/planets/my/999BB908-B79A-4C89-8DA6-1339BDFCE03E/articles \
  -F<EMAIL_ADDRESS>\
  -F "title=title" \
  -F "content=content"

If possible, I hope the code can support both attachment and attachments, so the existing clients (if any) do not need to update.


Return correct status code for invalid token

as per https://github.com/matrix-org/synapse/issues/2602

401 for invalid token


play kube fails: can't run as root without the -u switch

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Podman behavior is not consistent. I can't get play kube to work as the podman command line does. Play kube fails where command line works.
Steps to reproduce the issue:

do yaml file:

cat >>memcached.yml<<EOF
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: mc
  name: mc
spec:
  containers:
  - command:
    - docker-entrypoint.sh
    - memcached
    env:
    image: docker.io/library/memcached:alpine
    name: memcached
    #resources: {}
    #securityContext:
    #  allowPrivilegeEscalation: true
    #  capabilities: {}
    #  privileged: false
    #  readOnlyRootFilesystem: false
    #  runAsUser: 11211
    #workingDir: /
EOF

run podman play kube and observe failure to start

[vagrant@ikke-fedora ~]$ sudo podman play kube memcached.yml
aab6732e0e3123105eaf34e464f213108000e208a60f5fc0c9c8ee465ef449f2
1a0f753d99e81f4e544351f96fcc066bbfa9aa03544e6bb807198051ead755b0
[vagrant@ikke-fedora ~]$ sudo podman ps -a
CONTAINER ID  IMAGE                               COMMAND               CREATED        STATUS                     PORTS  NAMES
1a0f753d99e8  docker.io/library/memcached:alpine  docker-entrypoint...  2 seconds ago  Exited (64) 2 seconds ago         memcached
ccc4b89b9487  k8s.gcr.io/pause:3.1                                      2 seconds ago  Up 2 seconds ago                  aab6732e0e31-infra
[vagrant@ikke-fedora ~]$ sudo podman logs memcached
can't run as root without the -u switch

run same with command line options, and it works

[vagrant@ikke-fedora ~]$ sudo podman run -d  --name memcached  memcached:alpine
479c8b072fd6940dc232b9c3fb47e6ce41b5fe91c46fef9898d768f579a62c37
[vagrant@ikke-fedora ~]$ sudo podman ps
CONTAINER ID  IMAGE                               COMMAND               CREATED        STATUS            PORTS  NAMES
479c8b072fd6  docker.io/library/memcached:alpine  docker-entrypoint...  4 seconds ago  Up 4 seconds ago         memcached

Describe the results you received:
See steps above. Step 2 fails.
Describe the results you expected:
See steps above. Step 3 works.
Additional information you deem important (e.g. issue happens only occasionally):
Memcached Dockerfile is here so you see what it tries to do:
https://github.com/docker-library/memcached/blob/24ecf1cbeb76244031036eed161bb8bd00c99085/alpine/Dockerfile
Output of podman version:
this last night build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1231747
$ podman version
Version:            1.2.0-dev
RemoteAPI Version:  1
Go Version:         go1.12
OS/Arch:            linux/amd64

Output of podman info --debug:
$ sudo podman info --debug
debug:
  compiler: gc
  git commit: ""
  go version: go1.12
  podman version: 1.2.0-dev
host:
  BuildahVersion: 1.8-dev
  Conmon:
    package: podman-1.2.0-18.dev.git31f11a8.fc31.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: 9d49ac5f9774a9159463e7c3e32fe986b6fd0873'
  Distribution:
    distribution: fedora
    version: "29"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    package: runc-1.0.0-68.dev.git6635b4f.fc29.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: ef9132178ccc3d2775d4fb51f1e431f30cac1398-dirty
      spec: 1.0.1-dev
  SwapFree: 0
  SwapTotal: 0
  arch: amd64
  cpus: 1
  hostname: ikke-fedora
  kernel: 4.18.16-300.fc29.x86_64
  os: linux
  rootless: false
  uptime: 3h 49m 55.46s (Approximately 0.12 days)
insecure registries:
  registries: []
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 1
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mountopt=nodev
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 7
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Additional environment details (AWS, VirtualBox, physical, etc.):
Fedora under KVM on RHEL 7.6

That error has to be coming out of memcached itself - the string appears nowhere in our repo. Mismatch in how play kube sets up containers versus podman run?

I agree, that was my thought too. The dockerfile switches user there, and that is somehow prevented. Could be my user error too, even likely :)

Closed per #2696 @ikke-t PTAL :)

Thanks, I'll try once the build works. Last night's build is broken: https://koji.fedoraproject.org/koji/buildinfo?buildID=1235450

works, thanks!


[1.7] CI: K8sDemosTest Tests Star Wars Demo : kubectl apply: Exitcode: -1

Suite-k8s-1.11.K8sDemosTest Tests Star Wars Demo
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/19251/testReport/junit/Suite-k8s-1/11/K8sDemosTest_Tests_Star_Wars_Demo/
bcbf5220_K8sDemosTest_Tests_Star_Wars_Demo.zip
Failed on backport PR https://github.com/cilium/cilium/pull/11200 , which only avoids a crash so seems like it could not cause this failure.
Stacktrace
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:430
unable to apply https://raw.githubusercontent.com/cilium/star-wars-demo/v1.0.1/01-deathstar.yaml:
Expected command: kubectl apply --force=false -f https://raw.githubusercontent.com/cilium/star-wars-demo/v1.0.1/01-deathstar.yaml
To succeed, but it failed:
Exitcode: -1
Stdout:

Stderr:

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/demos.go:101

Standard Output
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
⚠  Number of "level=warning" in logs: 14
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
Top 3 errors/warnings:
Unable to release endpoint ID
Unable to restore endpoint, ignoring
BPF system config check: NOT OK.
Cilium pods: [cilium-5mg5m cilium-g7d6q]
Netpols loaded:
CiliumNetworkPolicies loaded:
Endpoint Policy Enforcement:
Pod                               Ingress   Egress
productpage-v1-79694464b7-j45lm
ratings-v1-6dff4d7759-dkmk7
reviews-v1-68657f4b8d-bj2nv
reviews-v2-75cb958f4b-gm24n
coredns-687db6485c-bx5w4
details-v1-7d45d7699f-9cgr6
Cilium agent 'cilium-5mg5m': Status: Ok  Health: Ok Nodes "" ContinerRuntime:  Kubernetes: Ok KVstore: Ok Controllers: Total 16 Failed 0
Cilium agent 'cilium-g7d6q': Status: Ok  Health: Ok Nodes "" ContinerRuntime:  Kubernetes: Ok KVstore: Ok Controllers: Total 13 Failed 0

Standard Error
STEP: Installing Cilium
STEP: Installing DNS Deployment
STEP: Performing Cilium preflight check
STEP: Performing Cilium status preflight check
STEP: Performing Cilium controllers preflight check
STEP: Performing Cilium health check
STEP: Performing Cilium service preflight check
STEP: Performing K8s service preflight check
STEP: Waiting for cilium-operator to be ready
STEP: Waiting for kube-dns to be ready
STEP: Running kube-dns preflight check
STEP: Performing K8s service preflight check
STEP: Applying deployments
=== Test Finished at 2020-04-28T21:37:29Z====
===================== TEST FAILED =====================
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE     NAME                               READY   STATUS    RESTARTS   AGE   IP              NODE   NOMINATED NODE
	 kube-system   cilium-5mg5m                       1/1     Running   0          1m    <IP_ADDRESS>   k8s2   <none>
	 kube-system   cilium-g7d6q                       1/1     Running   0          1m    <IP_ADDRESS>   k8s1   <none>
	 kube-system   cilium-operator-6966c4bc6d-pncfc   1/1     Running   0          19m   <IP_ADDRESS>   k8s2   <none>
	 kube-system   coredns-687db6485c-bx5w4           1/1     Running   0          19m   <IP_ADDRESS>     k8s2   <none>
	 kube-system   etcd-k8s1                          1/1     Running   0          51m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   kube-apiserver-k8s1                1/1     Running   0          51m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   kube-controller-manager-k8s1       1/1     Running   0          51m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   kube-scheduler-k8s1                1/1     Running   0          51m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   log-gatherer-nn4np                 1/1     Running   0          43m   <IP_ADDRESS>   k8s3   <none>
	 kube-system   log-gatherer-pn4mj                 1/1     Running   0          43m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   log-gatherer-tsbkf                 1/1     Running   0          43m   <IP_ADDRESS>   k8s2   <none>
	 kube-system   registry-adder-gbmsj               1/1     Running   0          49m   <IP_ADDRESS>   k8s2   <none>
	 kube-system   registry-adder-j9qqg               1/1     Running   0          49m   <IP_ADDRESS>   k8s1   <none>
	 kube-system   registry-adder-nkv7t               1/1     Running   0          49m   <IP_ADDRESS>   k8s3   <none>

Stderr:

Fetching command output from pods [cilium-5mg5m cilium-g7d6q]
cmd: kubectl exec -n kube-system cilium-5mg5m -- cilium endpoint list
Exitcode: 0
Stdout:
 	 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                       IPv6                 IPv4          STATUS
	            ENFORCEMENT        ENFORCEMENT
	 1447       Disabled           Disabled          4          reserved:health                                   f00d::a0c:0:0:e893   <IP_ADDRESS>   ready
	 2245       Disabled           Disabled          38869      k8s:io.cilium.k8s.policy.cluster=default          f00d::a0c:0:0:c414   <IP_ADDRESS>   ready
	                                                            k8s:io.cilium.k8s.policy.serviceaccount=coredns
	                                                            k8s:io.kubernetes.pod.namespace=kube-system
	                                                            k8s:k8s-app=kube-dns

Stderr:

cmd: kubectl exec -n kube-system cilium-5mg5m -- cilium service list
Exitcode: 0
Stdout:
 	 ID   Frontend        Service Type   Backend
	 23   <IP_ADDRESS>:443   ClusterIP      1 => <IP_ADDRESS>:6443
	 24   <IP_ADDRESS>:53   ClusterIP      1 => <IP_ADDRESS>:53

Stderr:

cmd: kubectl exec -n kube-system cilium-g7d6q -- cilium endpoint list
Exitcode: 0
Stdout:
 	 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])   IPv6                IPv4          STATUS
	            ENFORCEMENT        ENFORCEMENT
	 1136       Disabled           Disabled          4          reserved:health               f00d::a0b:0:0:39a   <IP_ADDRESS>   ready

Stderr:

cmd: kubectl exec -n kube-system cilium-g7d6q -- cilium service list
Exitcode: 0
Stdout:
 	 ID   Frontend        Service Type   Backend
	 17   <IP_ADDRESS>:443   ClusterIP      1 => <IP_ADDRESS>:6443
	 18   <IP_ADDRESS>:53   ClusterIP      1 => <IP_ADDRESS>:53

Stderr:

===================== Exiting AfterFailed =====================
STEP: Deleting all resources created during test
STEP: Waiting for all pods to finish terminating

This occurred during a known github incident, likely caused by inability to pull the YAML from github:
https://www.githubstatus.com/incidents/jzzxjt38k0d8


Release 1.5.1

Summary
Releases 1.5.1. I just run OCP CI here https://github.com/quarkus-qe/quarkus-test-framework/pull/1287 and it was green, so not going to trigger it again. Releases:

https://github.com/quarkus-qe/quarkus-test-framework/pull/1287

CLI failures is expected, I have explained them in the #1287, I suggest to look there.
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[x] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

@michalvavrik please don't forget to add the release note

@michalvavrik please don't forget to add the release note

thanks :100:


feat: Product details add reviewer cell

https://motoon-eg.atlassian.net/browse/DK-34

@ahmdmhasn  please solve the conversation


Created factorial calculator

Issue Id you have worked upon -
#108
Briefly explain your program logic -
Added factorial calculator
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @girisha-pawan on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.


misc cleanup

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@20c3b49). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #584   +/-   ##
=========================================
  Coverage          ?   73.26%
  Complexity        ?      774
=========================================
  Files             ?       54
  Lines             ?     3834
  Branches          ?      481
=========================================
  Hits              ?     2809
  Misses            ?      821
  Partials          ?      204

Impacted Files
Coverage Δ
Complexity Δ

...s/sharedtable/impl/HashPartitioningItemMapper.java
90.37% <ø> (ø)
22 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c3b49...285114f. Read the comment docs.


I can't fly when I become a vampire bat

When I became a vampire and used bat skills, I couldn't fly. Why?

The original jump key does not allow conflicts,(That is, the spacebar of the original jump is not allowed to conflict with other mods, and the keys containing the space bar in other mods need to be changed

The original jump key does not allow conflicts,(That is, the spacebar of the original jump is not allowed to conflict with other mods, and the keys containing the space bar in other mods need to be changed
就是原本跳跃的空格按键不能与其他mod产生冲突，需要把其他mod的的空格按键进行更改


Adds stream and event management API hooks

Removing a few comments:

None can be used as nullptr : ctypes documentation mentions it
Usage of python ints instead of ctypes int


Ship goldmark-attributes extension

This goldmark parser extension adds support for block attributes in markdown

https://github.com/mdigger/goldmark-attributes
Would it be OK to ship it or should it be reimplemented in a different way for some reason?

Would it be OK to ship it or should it be reimplemented in a different way for some reason?

There is also a third option, and since CommonMark has spent a decade discussing this and @yuin did not add this to his implementation, maybe that's the most sensible option.

Is there any way to have this working somehow at the moment?

Trying to ping @yuin and get his opinion; I agree that it would be really useful to be able to add CSS classes to blockquotes etc. My take on this is that the CommonMark people will never agree on a spec for this, so if we look pass the "political side" of this issue; is there a technical reason why we would not want to add this?
{.epigraph}
> Why, you may take the most gallant sailor, the most intrepid airman or the
> most audacious soldier, put them at a table together – what do you get? The
> sum of their fears.

If this is added at some point, I hope it is disabled by default. Not because I don't like the idea (I do), but because separation of content and style seems like the right starting point for most projects.
[markup.goldmark.extensions]
      attributes = false

. Additionally, would an attributes extension allow setting element id, CSS classes, and additional attributes, or would it be limited to CSS classes only?

The linked extension above is very low on tests/documentation, so it's hard to tell. But if we want to add this to Hugo, I suspect we would need to re-implement it, so ... up to us. But I also do agree that this would be an option -- default off.

I agree with @bep 's opinion.
Reasons why I wont to add general attributes to the goldmark core:

It can be implemented (mostly) as an extension.

It is hard to implement heading attributes as an extension, so I've implemented it in the core.

There are many interpretations for attributes positions and I do not know which is the best.

Attribute is in one line above an element:
{.class}
> foo
> bar

Attribute is in one line below an element:
> foo
> bar
{.class}

Special case: blockquote can be:

> foo
> bar
> {.class}

(There may be other special cases)

Some elements do not have suitable syntax for attributes:

Lists
Table cells

If all three (element id, CSS classes, and additional attributes) were possible, I would vote to control them separately. Something like:
[markup.goldmark.extensions]
  attributes = true
  [markup.goldmark.extensions.attributes]
     elementIDs = false
     cssClasses = true
     additionalAttributes = false

The additionalAttributes should be limited an "allow list". And at some point someone will ask for an "allow list" for cssClasses as well.

OK, reading the Goldmark code now, I notice the new parser.WithAttribute option that is currently only available for titles (ref. discussion above); that does support any attributes and I assume it is the same parser that is used in the extension above.


Add my son school

The title says itself, sorry for my english.
School website https://www.colegiosantanh.com.br/

If you want a proof, tell me what type of proof

@PixelOFC Pull request merged. Thank you!

@philipto could you revert this pull request, and if possible delete? My younger brother got into my account and created the pr, I believe the school doesnt even teach software development or anything related to software.


Release pipeline updates and package upgrades

Changes include:

Pipelines

Removed default azure-pipelines.yml as it's just a wrapper for build-and-test-template.yml and github actions are currently running for PRs anyway.
Modified build/test and release pipelines to use npm ci to lock down dependency versioning for releases and testing.
Added component governance and SDL checks to release pipeline
Release pipeline overhauled for SDL compliance
Re-added MacOS DMG notarization step
Added suppressions file for credscan and updated tests

Other changes

Package versioning updates for vulnerability updates

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact<EMAIL_ADDRESS>with any additional questions or comments.
Thank you for contributing to the Azure IoT Explorer!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[ ] If introducing new functionality or modified behavior, are they backed by unit tests?
[ ] Have all unit tests passed locally? (by running npm run test command)
[ ] Have you updated the README.md with new screenshots if significant changes have been made?
[ ] Have you update the package version if the current version in package.json is not higher than the version released?

Marking this as ready for review while I do some pipeline test runs to validate the new release pipeline end-to-end.


Fix hamburger on mobile

breakage introduced in te upgrade to bootstrap v5-beta.1.

See also https://github.com/artichoke/playground/pull/287.

See also https://github.com/artichoke/playground/pull/287.


select2tokenizer searches cutom valuelists differently than database valuelists

When backspacing a search in the tokenizer it will only search string start on a valuelist with custom values whereas it will search the entire string on a database generated valuelist. Here is a video example with a custom valuelist on the left and a database valuelist on the right.

Are you running from develop branch or from latest release ? This issue has been already fixed in develop branch.

I was running from the develop branch from a week ago and now after updating to the latest develop version I am still seeing the same issue.

Looking into it, the problem seems to be with the method filterList in valuelist.js and not in any of the component logic. Is this fix in a newer version of Servoy that hasn't been released?

My bad, i fixed this directly in the master branch. See commit: https://github.com/Servoy/servoy-extra-components/commit/3229e78556681996c558a9a81333f9a02a97c70a

After switching to the master branch package the issue is still there, but after further testing it doesn't seem to be a difference between Custom and Database valuelist. I'm not sure what the cause is but it is very sporadic. This video shows what I'm seeing. Valuelists with <100 values search the entire string initially but then backspacing it will only search the start. Valuelists with >100 values search more than just the start but not the entire string when searching initially and when backspacing.


We don't appear to be vulnerable to CPDoS (Cache Poisoned Denial of Service)

The website https://cpdos.org/ discussed the Cache Poisoned Denial of Service (CPDoS) vulnerability of systems that use CDNs.  We use a CDN (Fastly), but on first blush we don't appear vulnerable.  The "Fastly" column has empty rows for "Heroku" and "Rails".  Unfortunately it doesn't list Puma, but Puma is the recommended webserver by Heroku for Rails & is the usual choice.
I have not tested to see if we're actually vulnerable, but the first blush makes me think it's not worth investigating.
Unless I hear otherwise, this discussion probably be added to the doc/security.md page.

Documented in https://github.com/coreinfrastructure/best-practices-badge/pull/1362

Resolved by #1362.


syllabus changes

take off pdf and word docx option b/c we don't want a static version

I think this is done


Indicate annotated slices on the vertical slider

This is a nice-to-have feature request. Indicate annotated slices on the vertical slider for easy navigation (annotations getting lost if there are 100s of slices).

Idea: show slice number per measurement.


Getting Blank Screen from SDK.

We are using your payment gateway but in this we have used your demo but we are facing issue of blank scree.
Please let us know what is the problem with SDK.
We have pass required details from our end.
Please take a look of below video for the same.
Video - https://drive.google.com/file/d/1xTpXoo49OdGtlvxPCdwoa3xT8pYf_Hwr/view?usp=sharing
Also, As per SDK requirement we need to pass widget URL so we are passing this "https://sandbox.postpay.io/" it is correct or not? Or Do we need to do something here like create HTML page or something else here?
Please guide us on this thing.
Thanks in advance.

Related https://github.com/postpayio/react-native-postpay-widget-example/issues/1#issuecomment-1125792683


Blazor tutorial failed to run

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/blazor-tutorial/run
Operating System: windows 10
After entering the command "dotnet watch"
It responds with a syntax help page and nothing else. It's not listening on any port, none reported.
Running with -v verbose option I get...
===============================================================
watch : Evaluating dotnet-watch file set.
watch : Running MSBuild target 'GenerateWatchList' on 'D:\Software\Blazor\FirstBlazorApp\FirstBlazorApp.csproj'
watch : Started ....redacted....
watch : Process id 10532 ran for 610ms
watch : Watching 31 file(s) for changes
watch : Watch command will not use --no-restore. Unsupport dotnet-command ''.
watch : Browser refresh is only supported for run commands.
watch : Started 'C:\Program Files\dotnet\dotnet.exe' '' with process id 11288
watch : Running dotnet with the following arguments:
watch : Started
Usage: dotnet [options]
Usage: dotnet [path-to-application]
Options:
-h|--help         Display help.
--info            Display .NET information.
--list-sdks       Display the installed SDKs.
--list-runtimes   Display the installed runtimes.
path-to-application:
The path to an application .dll file to execute.
watch : Process id 11288 ran for 9ms
watch : Exited with error code -2147450751
watch : Waiting for a file to change before restarting dotnet...
Hangs until I press Ctrl+C.
localhost:5000 shows nothing to connect to.

Can you post the command line output here of dotnet watch? Thanks.


feature: support to run header_filter and body_filter phase for global rules

original comments: https://github.com/apache/incubator-apisix/issues/1202#issuecomment-603600053

Hi @membphis  do we have any plugins we are running currently on the headerfiter phase or body filter phase ?

of course, we have plugin are using header filter phase and body filter phase.
eg: plugin response-rewrite .

I would like to work on this issue @membphis


Wait for controllers to initialize

Loving it so far, good job. Sorry if this is not the right place for this question.

In my navigation controller I'm trying to use this.application.getControllerForElementAndIdentifier during initialize (can't move to click, third party) to obtain controllers that contains behavior I need to attach to my the navigation solution (close stuff, hide stuff, etc), but (I think) because the navigation occurs first in the HTML, during its initialize, other controllers still don't exist, so I can't get an instance of them.
stimulus is in a constant state of connecting and disconnecting (which is very nice), and I think it doesn't emit any kind of everything ready (but this for first load would be very useful I think).
What is the proper way to approach this problem?

Perfect. It solves the problem.
Why not have an API to that? Like application.tick() or something?

This has come up a few times before (#35, #183).

Why not an API to that? Like application.tick() or something?

It's the wrong level of abstraction for Stimulus. You shouldn't have to know about the microtask queue or JavaScript event loop in order to link two controllers together. Nor should you have to call the getControllerForElementAndIdentifier method (which has an intentionally long-winded name to discourage its use).
What we want is a way to declaratively link two controllers together in HTML, plus some sort of callback that's invoked when the link is established and both controllers are initialized.
We would love to hear any proposals for such an API! Otherwise, discussion for how to work with the existing API is best suited for the community forum.
Thank you for opening the issue!


Fix not generating cropped image with namespace

I opened this issue about thumbnail generator yesterday. I went through crop.py and found that when a namespace is used cv2.imwrite would not be able to generate the cropped image because a directory for the namespace needs to be created first, so I made some small changes to crop.py and added a mkdir for the author name

This looks good to me
Unrelated to this are a couple of other fixes pending merges to support namespaced models.
Do look out for them (or forward port the standing PR)
CH3EERS!

@codebot
The other PR is dependent on the models being available on Fuel and new thumbnails being generated for them.
That one might cause issues with  world generation when new namespaced models get used in traffic editor projects due to how the models get processed during world generation.
It's still pending testing after we have all our models on Fuel though. I'll hesitate merging that for now just in case something else breaks for any other current users of traffic_editor. (Lots of moving parts... :( )

For now just the tedium of the process I think.
It seems to be quite the undertaking!


RFC: Typed css vars generation

Currently, we generate files with JS constants which available for import. It's nice because autocompletion and autoimport works well. But in general we don't need this import because inside JS var we have CSS var interpolation.
So, before:
import styled from 'styled-components';

import { gray8, gray9 } from '../design/@generated/themes';

const StyledItem = styled.div`
    color: ${gray9};
    background-color: ${gray8};
`;

After:
mport styled from 'styled-components';

import { cssVar } from '../design/@generated/themes';

const StyledItem = styled.div`
    color: ${cssVar('--gray9')};
    background-color: ${cssVar('--gray8')};
`;

Why we need cssVar wrapper? Two things here. Firstly, we want to have typed completion for the list of available CSS vars. Also, we want to see errors in case when we rename or delete CSS vars. Native CSS can't do that.
First thing can be solved with editor extensions like this one for VS Code.
Second thing much more difficult but in general can be solved with some PostCSS plugin. Problem in this case will be in error at build time only. It means you will see down build instead of lint error in your editor or at lint stage in CI.

One more case for cssVar wrapper: sometime we need to pass color via prop into the Component. It works well with CSS properties, but it crucial to pass string with var(--gray5). Also, here editor extensions don't work 🤷🏼♂

No way, not now, probably never


fix(object_store): Continue operation in delete_objects function when…

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Fix #15651
Continue deleting the remaining content in s3 when some deleting operation failed.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added test labels as necessary. See details.
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[x] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[x] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[x] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx @wcy-fdu Hi, when will this pr be merged?

@MrCroxx @wcy-fdu Hi, when will this pr be merged?

Sorry for our late reply. I have added the PR to the merge queue.


Schema table builder avoid callback

To get a table builder I have to call knex.schema.table(tableName, callback Fn); but the problem is that I get the table builder only inside the standard callback function. The promise returned is a void promise, I would've expected to be able to attach a then handler and receive the table builder this way.
What it means is that I have to use a conventional callback to get the table builder, and a promise catch handler to receive any errors. It seems really backwards?
I also can't seem to promisify this as the standard error, data callback function arguments pattern is not being used.
It would just have been nice to be able to use it like: knex.schema.table(tableName, function(tableBuilder){}).then(function(tableBuilder){}); where the callback function is optional...

This is quite the major API-redesign for the schema scheduler which I don't see likely changing anytime soon unless some strong arguments are put on the table.
Please reopen if this is still an active issue.

Current schema API is so problematic, that it will need completely new version of it (people has already started working on this couple of times) and old one needs to be kept around for a quite long time to provide backwards compatibility.
I will start issue for API design + base principles on which it will be designed for the new migration API at some point during this year.


define new Regions AS923_1B and CD900_1A

AS923_1B defines a Region supporting Malaysia. It is illegal in Malaysia to use any frequency above 924 Mhz, hence the reason for this new Region. The AS923_1B defines Uplink frequencies at [922.0, 922.2, 922.4, 922.6, 922.8, 923.0, 923.2, 923.4]
CD900_1A defines a new testnet Region. This will be used for testing new Region parameters. It is centered in the ocean at the Challenger Deep which is the lowest sea floor depth on Earth - https://en.wikipedia.org/wiki/Challenger_Deep
CN779 is officially deprecated by the LoRa Alliance and should never be used.
PR is pending to update the proto Region enum
https://github.com/helium/proto/pull/132

Yes, Malaysia will need that in making Helium Network legal.

I've added back CN779.
I do believe we should sort out an update method to permanently remove some enum names.  Ideally we are going to rename some of these plan names to be more explanatory and less vague.  For example, US915 will become US915_SB2.  This will allow us to deploy any variant such as US915_SB1, US915_SB7, etc.  So, I'd like to see some method to be able to permanently remove names, otherwise we'll need to leave US915 in place forever which will be confusing.

I've added back CN779.
I do believe we should sort out an update method to permanently remove some enum names. Ideally we are going to rename some of these plan names to be more explanatory and less vague. For example, US915 will become US915_SB2. This will allow us to deploy any variant such as US915_SB1, US915_SB7, etc. So, I'd like to see some method to be able to permanently remove names, otherwise we'll need to leave US915 in place forever which will be confusing.

For backwards compatibility you can't really do that without a synchronized first upgrade where you break every one which is something we'd avoid. The name can be changed however since that won't break the on the wire format, just the source builds.
So we can rename US915 to US915_SB2 in the proto and it wouldn't break running systems with different older and newer versions of the proto


extract type parsing (other branch), add named record types, write pr…

add ability to specify expected data shapes, including named records
now as separate functionality instead of intermingled in Data class
write passing property tests

There are some details unfinished but it satisfices me for now as is.

Hey I appreciate the PR. I think we should leverage the native types and primitives of JavaScript itself to make this really appealing. You PR got me thinking about type casting again and I have a good solution now. There is also an existing library that helps a lot with it: https://github.com/sinclairzx81/typebox
It allows me to create types as a json schema and TypeScript type at the same time. With the schema I can easily convert the plutus data shape.

Beautiful, yet I'm irritated that I forgot about that library! Reinvented a wheel I was aware of.
Comments on your implementation:

You parse Objects as Constr, I have however a very uncertain hunch that at least in Plutarch they are represented as Lists onchain. Might also work differently in Plutus. Relatedly, why only allow Constr(0, *) here? What about sum types? No need to answer this, I need to investigate myself.
You allow parsing Constr(0, *) into Arrays, why? Might make sense to strip away some boilerplate, am asking in case I am missing other reasons.
There is a comment saying smth like "could read data types from onchain contracts"- this is super interesting to me, any idea how to go about this?
I like that you support more types like Enums and Tuples etc.! Also it seems TypeBox solves a lot of the headaches I had trying to work the typesystem with record/object types, nice.
I found myself scrolling up and down a lot to see if the castTo/castFrom are symmetric. Is there an option in TypeBox to add them into the type-classes themselves, similar to my implementation? Is there a reason not to?

I might proceed now

looking into adding more checks, i.e. "sorted" and "nonzero/positive" for the container types. They exist in Plutarch as type-parameters of i.e. AssocMaps. TypeBox seems to have the capacities for that already.
some property-tests
some tests involving some compiled scripts, mostly to help me answer the points above. My thoughts go towards generating simple scripts that run onchain type checks, then use the pre-submission validation checker. Maybe even something dynamic using plutarch-script-export, first things first though.

You parse Objects as Constr, I have however a very uncertain hunch that at least in Plutarch they are represented as Lists onchain. Might also work differently in Plutus. Relatedly, why only allow Constr(0, *) here? What about sum types?

Interesting. While I think it may be possible, I don't think it's correct. PlutusTx and Aiken use Constr for their object data types. Sum types/enums are supported. I make this check for objects just to be extra safe.

You allow parsing Constr(0, *) into Arrays, why? Might make sense to strip away some boilerplate, am asking in case I am missing other reasons.

That's a tuple. In the json schema normal arrays and tuples both are "array" so I need to make this check to separate tuples and real arrays.

I like that you support more types like Enums and Tuples etc.! Also it seems TypeBox solves a lot of the headaches I had trying to work the typesystem with record/object types, nice.

It's all there. Pretty much complete I think. You can check the tests here: https://github.com/spacebudz/lucid/blob/main/tests/data.test.ts

Right, makes sense - I realise it's a matter of opinion; maybe we might need a separate version for different frameworks, if that opinion differs. I.e. if let's say Plutarch discusses Record-types as lists and PlutusTx as Constrs of Lists, and we want the offchain-types to align to onchain, that seems tricky without. But that will turn up from what I'm working on rn.

if let's say Plutarch discusses Record-types as lists and PlutusTx as Constrs of Lists

It's not a List of Constr. Let's say you have a type that looks like that in PlutusTx:
data Listing = Listing {
    owner :: BuiltinByteString,
    amount :: Integer
}

In PlutusData it would look like that:
new Constr(0, [
 "313131", // owner
  1000000 // amount
])

Representing it as:
 ["313131", 1000000]

doesn't really make sense to me. How could Plutarch even parse the ScriptContext if it doesn't make use of Constr for Record-types?

It's not a List of Constr.
Is this a typo? I wrote Constr of a List.

Again, I'm not entirely sure, I just looked at the code and saw that it's a list. Might well be that this is being wrapped in a Constr downstream somewhere. Fixing my Plutarch rn so I can check.
But to address the question - wdym? But in any case Constr(0, [List of the record-values]) does not add much over a direct [List of the record-values], besides the (imo sensical) "hint" that this is not a pure list but supposed to be a record-type.
Iirc the use of of Constrs in PlutusTx was to make sum types, the index determining which constructor is being used. Again, I would agree it's cleaner that way, maybe a bit more bloated by a negligible amount, if I try to steelman the supposed decision. Again, as soon as my Plutarch is fixed I can provide far better input.


WIP Admin UI - pull URLs from config

Issue: closes #291

[ ] Tick here to confirm that you have run RunCodeFormatter.ps1

Description:

Add appsettings entries for AdminWebUI Urls
Inject appsettings entries into AdminWebUI
Update ui URL to /ui/admin

Test:
Build and run Nether.Web. Sign in to Admin Web UI (** NOTE - new URL: /ui/admin**) and check it all works locally
Deploy to Azure Web Apps and check that you can sign in

Hi @stuartleeks, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Input Lag

On a brand new macbook pro, when using the scrollbar on a heavy content site, there is noticeable lag when first scrolling and the response.

Could you please give me a demo code for further investigation?


Shortcuts don't work anymore

macOS 10.12.6
Firefox Quantum 66.0.3 (64-bit)
Even with the default shortcuts, they don't work, even when the Google Play Music tab is in focus.
Clicking on the toolbar button for the extension does the appropriate play/pause, so that part of the code is working at least. Shortcuts don't work at all for me.

Ok, I ran the extension in debug mode which fixed the problem with the default shortcuts (no idea why), but the ones I want to use aren't working. Seems like they aren't translating to the right thing.
I'm now seeing this mapping happen when I close and reload the extension after setting my options.
Space -> MacSpace
Right -> MacRight
Left -> MacLeft
Similar to https://github.com/lidel/google-music-hotkeys/issues/13 ?

Thank you for reporting this. Sadly I don't own a Mac and can't reproduce this.
If anyone sees this and can help a PR or a comment (even if it is "i have a mac and works for me") with  will be appreciated.


[Feature Request] Separate label and value in el-radio-group

Existing Component
Yes
Component Name
el-radio-group
Description
It would be beneficial if we could set custom texts for each radio item. Currently, there is no attribute available for custom texts which is why label == text. What if we want to show a different text in the GUI than the label? Something like this:
<el-radio-group v-model="city">
  <el-radio-button label="NY">New York</el-radio-button>
</el-radio-group>

It's supported: https://jsfiddle.net/46ho8wj5/

It's supported: https://jsfiddle.net/46ho8wj5/

How to use it without using {{ item.alias }} curly brace but binding value ?
for ex:
<el-radio-group v-model="radio1">
  <el-radio-button v-for="item in city"  :label="item.name">{{ item.alias }}</el-radio-button>
</el-radio-group>


upgraded DFX

Closing as those changes are made in https://github.com/research-ag/motoko-lib/pull/71


Incorporate common/decisions

Need to see if by default it causes errors, or there are other reasons to replace files.
We might also want to add some decisions, but that's probably another issue to open, discuss, and consider.

Already fixed in #478 , blanking out all tag-specifics and leaving clean only the "generics" ones.


Introduce dynamic handler

Add dynamic.Handler to the dynamic package
Add adapter.RemoteXXX interfaces that dynamic handler implements
Update spybackend to be usable from outside.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1b39386853605082a3df94ef9ec9fac6c8b4ea04
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1b39386853605082a3df94ef9ec9fac6c8b4ea04
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test istio-presubmit

prow/istio-pilot-e2e.sh
ab7fd32d4262eca0daf369f408c48f8ffef7bca1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@guptasu everything except saving things for session based. That will be done in a separate PR.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [guptasu,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
479e25143e72c7f901d358e07d08bb0471e9ee30
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


chore: contributors

@all-contributors please add @kaname-png for code, bug, doc, infra, maintenance, review


Remove extra line in User Guide

Codecov Report
Base: 35.43% // Head: 35.43% // No change to project coverage :thumbsup:

Coverage data is based on head (fec2515) compared to base (f12c890).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     35.43%   35.43%
  Complexity      455      455
=========================================
  Files           140      140
  Lines          3429     3429
  Branches        354      354
=========================================
  Hits           1215     1215
  Misses         2105     2105
  Partials        109      109

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update design section

Tackles part of https://github.com/AY2122S1-CS2103T-W16-2/tp/issues/206

Codecov Report

Merging #231 (564a625) into master (cb6cbb4) will decrease coverage by 1.22%.
The diff coverage is 1.28%.

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
- Coverage     78.74%   77.52%   -1.23%
  Complexity     1149     1149
============================================
  Files           139      139
  Lines          3289     3341      +52
  Branches        377      373       -4
============================================
  Hits           2590     2590
- Misses          604      656      +52
  Partials         95       95

Impacted Files
Coverage Δ

...22s1_cs2103t_w16_2/btbb/commons/core/Messages.java
0.00% <ø> (ø)

..._cs2103t_w16_2/btbb/model/util/SampleDataUtil.java
0.00% <0.00%> (ø)

...ava/ay2122s1_cs2103t_w16_2/btbb/ui/MainWindow.java
0.00% <0.00%> (ø)

..._w16_2/btbb/logic/descriptors/OrderDescriptor.java
85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2256f1...564a625. Read the comment docs.

You can view the changes using the link


RPC[Error] code_name = InvalidParams, message = "Document for URI could not be found: ..."

Hey @MagicDuck and thanks for this fantastic plugin! 👏 😄
I've always struggled a bit with nvim-spectre in terms of how you have to mix filters and flags, and your UI and keymaps just makes everything so much more intuitive to me. Instant replacement here! ⭐
I am however getting an RPC error for each character I type into the search field. This is me typing in hello into the search field:
08:35:31 msg_show RPC[Error] code_name = InvalidParams, message = "Document for URI could not be found: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201%3A%20he, URIs of the known document are: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201"
08:35:33 msg_show RPC[Error] code_name = InvalidParams, message = "Document for URI could not be found: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201%3A%20hel, URIs of the known document are: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201"
08:35:34 msg_show RPC[Error] code_name = InvalidParams, message = "Document for URI could not be found: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201%3A%20hell, URIs of the known document are: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201"
08:35:36 msg_show RPC[Error] code_name = InvalidParams, message = "Document for URI could not be found: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201%3A%20hello, URIs of the known document are: file:///Users/fredrik/code/dotfiles/Grug%20FAR%20-%201"

My current working directory is /Users/fredrik/code/dotfiles and it feels like grug-far is expecting (or looking for) a file in this location, matching the pattern Grug FAR - 1: <search term>.
This doesn't appear to affect functionality other than being annoying (as I get popups about this).
System:

macOS
Wezterm
Neovim 0.10
Grug-FAR config here
Zsh
rg version❯ rg --version
ripgrep 14.1.0

features:-simd-accel,+pcre2
simd(compile):+NEON
simd(runtime):+NEON

PCRE2 10.42 is available (JIT is available)

HI Frederik, thank you for the kind words and detailed info! 😄
That error message makes me suspicious that a language server is trying to attach to the buffer, but there is no backing file for it naturally.
If you run :LspInfo while in the grug-far.nvim buffer, do you see any language server attached?

could also be copilot / other AI related if you use that...

Ah yes, that was it - thank you!
I have copilot.lua activated for public git repos, and I don't see this error in the non-public ones. 😄
I just noticed this didn't work well in Lua as it doesn't like the dash:
filetypes = {
  grug-far = false,
  grug-far-history = false,
}

I worked around it with opts.filetypes["grug-far"] = false but had to place this outside my opts config. With this, no more rpc errors! 👍
Thanks again so much for the support and your work on the plugin! ⭐

glad that worked! 😄
Btw, small tip, I believe this should work if you want to add the filetypes config inline:
filetypes = {
  ["grug-far"] = false,
  ["grug-far-history"] = false,
}

Awesome, thank you @MagicDuck, I didn't know this! 👍


⚠ dev.minetest.net has degraded performance

In 5b24a03, dev.minetest.net (https://dev.minetest.net/Main_Page) experienced degraded performance:

HTTP code: 200
Response time: 2673 ms

Resolved: dev.minetest.net performance has improved in 40b376b after 28 minutes.


Viewing settings page causes an error

An error of type E_ERROR was caused in line 46 of the file /home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/Helpers.php. Error message: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(/home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/../media): Failed to open directory: No such file or directory in /home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/Helpers.php:46
Stack trace:
#0 /home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/Helpers.php(46): RecursiveDirectoryIterator->__construct()
#1 /home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/Settings.php(184): FTF_Fediverse_Embeds\Helpers::get_directory_size()
#2 /home/shkspr.mobi/blog/wp-admin/includes/template.php(1773): FTF_Fediverse_Embeds\Settings->render_settings_form()
#3 /home/shkspr.mobi/blog/wp-content/plugins/fediverse-embeds-wordpress-plugin-main/includes/Settings.php(50): do_settings_sections()
#4 /home/shkspr.mobi/blog/wp-includes/class-wp-hook.php(308): FTF_Fediverse_Embeds\Settings->render_settings_page()
#5 /home/shkspr.mobi/blog/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters()
#6 /home/shkspr.mobi/blog/wp-includes/plugin.php(517): WP_Hook->do_action()
#7 /home/shkspr.mobi/blog/wp-admin/admin.php(259): do_action()
#8 /home/shkspr.mobi/blog/wp-admin/options-general.php(10): require_once('/home/...')
#9 {main}
  thrown

@edent Thank you for catching this! Fixed with https://github.com/stefanbohacek/fediverse-embeds-wordpress-plugin/commit/3b371d9c888cfed8e6ef3890c3471c94a4d2eea1.

Seems to work. Although it now says:

Number of saved posts: 7
Size of downloaded media files: NAN

Right, this is now fixed. https://github.com/stefanbohacek/fediverse-embeds-wordpress-plugin/commit/bfd66e73f19a3afff0781f201e470d6b145f72a1

That seems to be a regression. It's now throwing an error again.

Ah, sorry, I was rushing too much.
https://github.com/stefanbohacek/fediverse-embeds-wordpress-plugin/commit/44462c046ecbd4930c2f61eb51101b4efebcedd0


Add initial documentation

The goal of this PR is to start the conversation about the documentation.
Idea is to work together to build an initial documentation version including legal information, samples, etc.
Included so far:

Draft of the index page
Draft of the samples documentation

It's a great start for issue #32
We should also document the config settings and what each of them do, what the defaults are etc.

We should also document the config settings and what each of them do, what the defaults are etc.

We should also document the config settings and what each of them do, what the defaults are etc.

I have added the configuration information, please take a look.

I also would like to set the expectation right for people looking at the repository, stating that this is in development and there are no guarantees. No SLAs, not built-in Azure.
How would you phrase that? There might be a common test already used in different projects we can reuse.

Can you remove Draft from this so we can merge what you have so that others can take this task and work on it


New courts index page links to search instead of court homepage

Changes in this PR:
As discussed in sprint review 4/3/24, to ensure users can refine and filter after arriving at court page, until the persistent search work has been advanced.

aha it's not actually visible yet until the homepage changes go live (which
will be feature flagged)
On Tue, 5 Mar 2024 at 14:23, Dragon @.***> wrote:

@.**** approved this pull request.
There's a part of me going "we could feature flag this", but happy as is.
—
Reply to this email directly, view it on GitHub
https://github.com/nationalarchives/ds-caselaw-public-ui/pull/1130#pullrequestreview-1917147974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABBN7BUEE2VMRQU4AOBY3YWXINBAVCNFSM6AAAAABEHAFRO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJXGE2DOOJXGQ
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


<IP_ADDRESS>-148 and python3 on oracle linux 9: nothing provides bigtop-tomcat

Hey.
Trying to install ODP <IP_ADDRESS>-148 with ambari 2.7.9-117 on Oracle linux 9 with Python 3, odp-select can't find httpfs:
resource_management.core.exceptions.Fail: The package hadoop-hdfs-httpfs is not supported by this version of the stack-select tool.

Installing hadoop-httpfs manually:
# yum install hadoop-httpfs
Last metadata expiration check: 0:25:46 ago on Thu 28 Nov 2024 02:02:19 PM CET.
Error:
 Problem: package hadoop-httpfs-<IP_ADDRESS>.2.2.0-148.el9.x86_64 from hadoop-odp-1220-148-el9 requires hadoop_1_2_2_0_148-httpfs, but none of the providers can be installed
  - conflicting requests
  - nothing provides bigtop-tomcat needed by hadoop_1_2_2_0_148-httpfs-<IP_ADDRESS>.2.2.0-148.el9.x86_64 from hadoop-odp-1220-148-el9

Hi @zorel ,
HTTPFS is not supporte on ODP <IP_ADDRESS>, there are some httpfs options because of the WIP started at this time
Could you try the latest nightly build instead ? <IP_ADDRESS>-77 ? with ambari <IP_ADDRESS>.0-76 ?
Regards,
Clemlab Team

Will do, thanks

@zorel
Thank you,However we identified an other issue on Ranger which is fixed in the next nightly build <IP_ADDRESS>.0-78
It is currently being built and will be available in 1hour .
The issue has been identified on Ubuntu 22.04 so you may not be impacted
Regards
Clemlab Team

Hi. https://archive.clemlab.com/centos9/odp-release/<IP_ADDRESS>-77/ODP-VDF.xml is malformed, there is an issues with versions.

Hi @zorel,
You can try it again we fix the issue.
Regards,
Clemlab team


Why is some of my emails showing up as 0 PiB?

Why is some of my emails showing up as 0 PiB? Those emails showing 0 PiB has more text than those emails showing bytes. I believe if it should be 0 it should be showing 0 bytes.

Webmin version 1.940
Authentic theme version 19.44-3

It was a bug and it's gonna be fixed on next Webmin 1.941 release (for all themes).
Although, you can update theme to the latest dev version right now, to have it fixed now.


Added solution for problem 1672

Added the java solution for problem 1672 for Hactoberfest.

Hi, I have submitted the solution, but I don't see any being taken till now, is this repo active?

Hi, I have submitted the solution, but I don't see any action being taken till now, is this repo active?

Hi @Ayan1089. Currently, there is no Github Action is going on. I will create a issue for it. If you are interested please take that too.

Hi @Ayan1089 , I'm okay with the solution. But I need the problem description and the problem description in the file. Please add it. I have attached a sample for it.
https://github.com/SanthoshS20/Leet_Code_Problems_Solution/blob/main/Python Language/ProblemID_1089.py

I have done the changes can you merge it now?

Hi, I have submitted the solution, but I don't see any action being taken till now, is this repo active?

Hi @Ayan1089. Currently, there is no Github Action is going on. I will create a issue for it. If you are interested please take that too.

Yeah sure, you can assign the issue to me, meanwhile, can you merge the existing PR?


Referencing YubiKeyDeviceListener.Instance throws System.TypeInitializationException on all versions after 1.2

Any reference to YubiKeyDeviceListener.Instance throws an exception.
Version 1.2 is the last working version.
.NET Framework 4.8
YubiKeyDeviceListener.Instance.Arrived += YubiKey_Arrived;
System.TypeInitializationException: 'The type initializer for 'PerTypeValues`1' threw an exception.'

FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

Hi @mjfara,
I tried to create a project to reproduce this, but I was not successful.
Here's what I did:

Created a console project based on .NET Framework 4.8
Used PackageReferences to include Yubico.YubiKey, since the SDK does not currently support packages.config
Built as Debug and Release using x64 architecture, as 'Any CPU' will not work since we have native dependencies.
Added event handlers for Arrived and Removed.

The app was able to run and I saw the expected arrive and remove event messages.
Would you be able to package up a minimal repro app for me to investigate further?
I also found this StackOverflow thread that seems like it might be relevant? https://stackoverflow.com/questions/62764744/could-not-load-file-or-assembly-system-runtime-compilerservices-unsafe

When trying to create a minimal repro, I now get the following error when trying to add the 1.4.2 package to an empty class library:
Could not install package 'Yubico.NativeShims 1.3.1'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.8', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

Yes, 1.2 is when we added device event support and refactored a lot of our interop code into a custom library. It's unfortunately cause headaches for our .NET Framework 4.x based users. We have yet to discover a good fix for this.
This error is because your new project is using packages.config which is not supported.  If the project already has NuGet references, there should be a right-click option on the project or the project references item in solution explorer to "migrate to PackageReferences" or something like that.
Otherwise you can unload the project file and open it in the editor and add:
  <ItemGroup>
    <PackageReference Include="Yubico.YubiKey">
      <Version>1.4.2</Version>
    </PackageReference>
  </ItemGroup>

somewhere before the final import of the project targets (usually the second to last line in the file).

Thanks for the info.
I migrated to PackageReferences but still get the same error, here is a repro:
YubiTest.zip

Hi @GregDomzalski , any chance you were able to take a look at that minimal repro?

Yes I did. I was able to compile and run the application. Unfortunately I still was not able to reproduce this.
I suspect that this may be a machine-specific issue. Are you able to try this out on a second machine?
The SO link I provided may be on to something: perhaps the version of this library registered in the GAC is different from what your current runtime requires. I'm much less familiar with .NET Framework and the GAC - is there a way you can confirm or force the installation of the library version is asking for?

I'm also beginning to think it's machine specific issue.
I'll have to circle back to this issue at a later time and will simply avoid using the listener events for now. Thanks for looking into it.

Hi @mjfara - any progress on your side? Were you able to get past this issue?
Let me know if I can close this issue.

Unfortunately had to manually bundle NativeShims.dll in the installer in order to get this to work properly.
Can confirm there are no problems on .NET6, but .NET Framework has provided some headaches.


♻ Improving tasks for architectural liberty

Tasks are kinda bound to either to bot or cogs cause of the tasks.loop decorator.
Currently, to have all the tasks within a tasks directory, you need a cog and something like this within its __init__:

from https://github.com/Pincer-org/Pincer-Bot/blob/main/pincer_bot/cogs/info.py

from pincer_bot.tasks.get_pypi_downloads import get_pypi_stats

# ...

    def __init__(self, client):
        self.client = client

        task = TaskScheduler(self.client)
        self.get_pypi_downloads = task.loop(minutes=10)(get_pypi_stats)
        self.get_pypi_downloads.start()

A rewrite allowing to have tasks seperated more easily would be great

Closed due to depreciation, thank you for your effort ♥


Do not use "agreement" as protocol

For example, $agreement = 'https://'; in Core/Printemps/Controller.pri.php, please use protocol instead.

Thanks. I will fix it.


No Host DNS record found. Add the following to /etc/hosts:<IP_ADDRESS> project.loc

ISSUE TYPE

Bug Report

Checklist

[x ] .env file is attached
[ ] docker-compose.override.yml is attached (if it exists) (not customized)
[ ] Custom configs from cfg/ dir are attached (if customized) (not customized)
[ x] docker-compose logs and log/ output is added (see below)
[x ] I've looked through the docs: https://devilbox.readthedocs.io/en/latest/
[ x] I've looked through existing issues: https://github.com/cytopia/devilbox/issues
[ x] I've read troubleshooting: https://devilbox.readthedocs.io/en/latest/support/troubleshooting.html

OS / ENVIRONMENT

Host operating system and version: Ubuntu 16.04
(Windows) Native Docker or Docker Toolbox:
Docker version: latest as of today
Docker Compose version: latest as of tody
(Linux) Is SELinux enabled?: no
What git commit hash are you on?: ?

SUMMARY

Not able to add new project to a newly installed devilbox while devilbox or ubuntu does not honor hosts file. hosts file bears the <IP_ADDRESS> projects entry, but devilbox still claims, i would have to add this entry.
STEPS TO REPRODUCE

Install current Ubuntu 16.04
create user / group devilbox
install docker ce (following devilbox/docker instructions)
install docker compose (following devilbox/docker instructions)
install git
clone devilbox in /opt
cp example-env .env
edit /opt/devilbox/ .env as enclosed
su devilbox
cd /opt/devilbox/data/www
mkdir project
cd project
mkdir htdocs
exit
cd /etc
nano hosts
add: <IP_ADDRESS> project.loc
save
docker-compose up bind httpd php mysql
browse to intranet scrreen
menue: vhosts:
then i will get this:
No Host DNS record found. Add the following to /etc/hosts:<IP_ADDRESS> project.loc
EXPECTED BEHAVIOUR

it just works as intended and i can add new projects to devilbox and hosts file... :-)
ACTUAL BEHAVIOUR

Whatever i do, and i setup various times and tried different solutions found in world wide web, and all ended up with this error, i couldn't get Ubuntu to do auto dns'ing; i messed up several times and now i am sorta broke :-(
OTHER INFORMATION
Start command

$ docker-compose up bind http php mysql
File and user permissions (Linux & MacOS)

$ id
1001:1001

Hint: when i sudo devilbox and try to start docker-compose up there i will get this:
Couldn'T connect to docker daemon at http+docker://localhost - is it running?
User devilbox IS being in docker group as well.
 Usually i'd use www-data for user/group when placing files in webserverdirectory.

$ docker-compose log
root@devilbox:/opt/devilbox/log# docker-compose logs
WARNING: The LOCAL_LISTEN_ADDR variable is not set. Defaulting to a blank string.
WARNING: The DEBUG_COMPOSE_ENTRYPOINT variable is not set. Defaulting to a blank string.
WARNING: The EXTRA_HOSTS variable is not set. Defaulting to a blank string.
WARNING: The BIND_TTL_TIME variable is not set. Defaulting to a blank string.
WARNING: The BIND_REFRESH_TIME variable is not set. Defaulting to a blank string.
WARNING: The BIND_RETRY_TIME variable is not set. Defaulting to a blank string.
WARNING: The BIND_EXPIRY_TIME variable is not set. Defaulting to a blank string.
WARNING: The BIND_MAX_CACHE_TIME variable is not set. Defaulting to a blank string.
WARNING: The BIND_LOG_DNS_QUERIES variable is not set. Defaulting to a blank string.
WARNING: The PHP_SERVER variable is not set. Defaulting to a blank string.
WARNING: The PHP_MODULES_ENABLE variable is not set. Defaulting to a blank string.
WARNING: The PHP_MODULES_DISABLE variable is not set. Defaulting to a blank string.
WARNING: The MYSQL_ROOT_PASSWORD variable is not set. Defaulting to a blank string.
WARNING: The DEVILBOX_PATH variable is not set. Defaulting to a blank string.
WARNING: The MOUNT_OPTIONS variable is not set. Defaulting to a blank string.
WARNING: The HOST_PATH_HTTPD_DATADIR variable is not set. Defaulting to a blank string.
WARNING: The HTTPD_SERVER variable is not set. Defaulting to a blank string.
WARNING: The DEVILBOX_UI_ENABLE variable is not set. Defaulting to a blank string.
WARNING: The TLD_SUFFIX variable is not set. Defaulting to a blank string.
WARNING: The HTTPD_DOCROOT_DIR variable is not set. Defaulting to a blank string.
WARNING: The HTTPD_TEMPLATE_DIR variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_HTTPD variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_HTTPD_SSL variable is not set. Defaulting to a blank string.
WARNING: The MYSQL_SERVER variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_MYSQL variable is not set. Defaulting to a blank string.
WARNING: The PGSQL_SERVER variable is not set. Defaulting to a blank string.
WARNING: The PGSQL_ROOT_USER variable is not set. Defaulting to a blank string.
WARNING: The PGSQL_ROOT_PASSWORD variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_PGSQL variable is not set. Defaulting to a blank string.
WARNING: The REDIS_SERVER variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_REDIS variable is not set. Defaulting to a blank string.
WARNING: The MEMCD_SERVER variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_MEMCD variable is not set. Defaulting to a blank string.
WARNING: The MONGO_SERVER variable is not set. Defaulting to a blank string.
WARNING: The HOST_PORT_MONGO variable is not set. Defaulting to a blank string.
ERROR: The Compose file './../docker-compose.yml' is invalid because:
services.memcd.ports is invalid: Port ranges don't match in length
services.mongo.ports is invalid: Port ranges don't match in length
services.mysql.ports is invalid: Port ranges don't match in length
services.httpd.ports is invalid: Port ranges don't match in length
services.pgsql.ports is invalid: Port ranges don't match in length
services.redis.ports is invalid: Port ranges don't match in length
services.httpd.ports is invalid: Port ranges don't match in length

So what?
Thanks for pushing me in the right direction ;-)
Best
env.txt
Update: i can ping now project.loc in Ubuntu and get an answer:
root@devilbox:~# ping project..loc
PING localhost (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.036 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=0.046 ms
64 bytes from localhost (<IP_ADDRESS>): icmp_seq=3 ttl=64 time=0.059 ms
^C
--- localhost ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 1998ms
rtt min/avg/max/mdev = 0.036/0.047/0.059/0.009 ms

But still error: No Host DNS record found. Add the following to /etc/hosts/: <IP_ADDRESS> project.loc :-(

$ docker-compose log
root@devilbox:/opt/devilbox/log# docker-compose logs
WARNING: The LOCAL_LISTEN_ADDR variable is not set. Defaulting to a blank string.
WARNING: The DEBUG_COMPOSE_ENTRYPOINT variable is not set. Defaulting to a blank string.
WARNING: The EXTRA_HOSTS variable is not set. Defaulting to a blank string.

None of the variables are set, did you copy env-example to .env?

I have the same issue in Ubuntu.
The project is set up and working, but Virtual Hosts menu show - No Host DNS record found. Add the following to /etc/hosts

$ ls -la
root@devilbox:/opt/devilbox# ls -al
total 240
drwxr-xr-x 16 root     root      4096 Jun 20 06:10 .
drwxr-xr-x  5 root     root      4096 Jun 20 06:08 ..
drwxr-xr-x  2 root     root      4096 Jun 20 06:07 autostart
drwxr-xr-x  3 devilbox devilbox  4096 Jun 20 06:44 backups
drwxr-xr-x  2 root     root      4096 Jun 20 06:07 bash
drwxr-xr-x  2 devilbox devilbox  4096 Jun 20 06:47 ca

Also this is mixed root user and mixed devilbox user.

Queestion: Is it correct to chown the project files & directories to the devilbox user? Usually i'd use www-data for user/group when placing files in webserverdirectory.

You don't have to chown anything.

Well,
i gave it a try with a windows setup, having the same problem here, after i set in the windows host file <IP_ADDRESS> joomla.loc it still keeps telling me i have to add that to my hosts file ...
And yes, i copied the env-example over to .env, whether it was under linux or with windows. I had a problem first with Docker for Windows, because HyperV kept me from adding port 80, so i set port 80 to 8080... BUT i am using the new edge version of docker for windows (experimental), since the previous one would ask me for login / password to share the discdrive with docker. Since i do not have a password, because i us 2FA; i couldn't continue with installation. Found later the new branch, which will work without samba; therefore might be that part of the problem? Docker for Windows, according to your documentation, handles the uid and gid for itself, but will it still, if it does NOT use samba? See here: https://github.com/docker/for-win/issues/616#issuecomment-559762353
Thanks for getting back, i almost gave up hope on this one.
Best

Judging by these errors:
WARNING: The HOST_PORT_MONGO variable is not set. Defaulting to a blank string.
ERROR: The Compose file './../docker-compose.yml' is invalid because:
services.memcd.ports is invalid: Port ranges don't match in length

Something is wrong with your setup. It doesn't even show any logs from any Docker container. So I suggest you troubleshoot this first.

I think this might also relevant:
I found error on browser console:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource

I'm not sure if this is exactly your problem, but here we go.
I've been having this issue for months (intermittent) I'm on windows using 53 as DNS port and setting the primary DNS as <IP_ADDRESS> I was wondering why sometimes it work and then suddenly stops.
tried a lookup for one of the domains and seems like windows is defaulting to IPv6 and the bind container isn't answering.

After disabling IPv6.

Although the message is correct, its a bit misleading in this case.

I'm having the same problem reported.

The problem is active if you use vpn. Disconnect vpn service and all will be work

I'm having the same issue and disabling my VPN connection did not fix it.

You should enter the /etc/hosts of your user not from devilbox container , check if is that is the problem?

@ahmedch1, I cannot image a /etc/hosts in the container as this is the sense of docker: Using the base system. And never heard that a user owns /etc/hosts. So I recommend that you push your IT knowledge a bit before sharing your thoughts here .

This issue already got quite messy.
@creactiv you seem to have several local issues:

Your files and directories have wrong ownership. It should it of your local user/group
docker-compose logs command must be issue from root of project, otherwise it won't yield any useful output
Git commit of Devilbox is missing, so I won't be able to reproduce with your currently checked out version

@dbrw If you have specific issues, please open up a separate bug report

@alexfd7 / @bbeale Please create separate bug reports with your specific details.

@ Everyone:
Also worth to mention: Devilbox is currently at v1.8.1 (https://github.com/cytopia/devilbox/pull/747), which has a lot of bug fixes and additions.
One of them being check-config.sh, which will automatically check against common configuration issues.
Please upgrade to this version and in case this error still persist, open a new bug report with required details and steps to reproduce. This will make it a bit easier to give support on specific cases.


feat: remove lint-style.sh

In detail, this PR

moves the executable bit check into the .yml files, instead of the shell script
adds a --fix flag to lint-style, for fixing style errors (when possible)
moves calling lint-style.py into lake exe lint-style, and
switches the CI workflow to call lake exe lint-style instead, and removes lint-style.sh

Ideally, lint-style.py will be completely rewritten in Lean soon, so this calling of an external process is only temporary.
Helps with #14539.

bors merge

Thank you for the fast review!