🐛 BUG: Wrangler is injecting development code in production builds

Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.14.0
What version of Node are you using?
v18.17.0
What operating system are you using?
Mac
Describe the Bug
Wrangler has started injecting some sort of "modules watch" code into production builds, when it shouldn't be. These functions are getting called for every import that is made in your worker script, which has an increase in both script size of ~5kb, and script startup time.
// wrangler-modules-watch:wrangler:modules-watch
var init_wrangler_modules_watch = __esm({
  "wrangler-modules-watch:wrangler:modules-watch"() {
    init_modules_watch_stub();
  }
});

//<EMAIL_ADDRESS>var init_modules_watch_stub = __esm({
  "node_modules/.pnpm/wrangler@3.14.0/node_modules/wrangler/templates/modules-watch-stub.js"() {
    init_wrangler_modules_watch();
  }
});

This behaviour started occurring in 3.11.0, and didn't occur in 3.10.0, so I'm almost certain it's the result of https://github.com/cloudflare/workers-sdk/pull/3726, cc @petebacondarwin
Please provide a link to a minimal reproduction
Any worker that imports anything -> npx wrangler deploy --outdir dist, look at the outputted code to see these files which shouldn't be present
Please provide any relevant error logs
No response

It appears this code is only added if esbuild is having to deal with a Common JS import. If all the code in a Worker is ESM then this virtual module gets stripped from the output.


svg vs png and their performance

[х] Question
[х] Performance
v. 6.1.2
Hello!
I don’t know if this applies to the bonus pack, but it seems to me that not really.
I have 3 questions.

After parsing kml, I use styler for each element and this greatly increases the loading time of the kml file. Is there any way to optimize this?
On video number 1, I use vector images for icons, but there are a lot of them and they too affect performance. Is there really a reason for the number of objects, or can I somehow optimize it?
I use vector ones for the reason from video number 2, there I use png format icons and they don’t scale up,they just fly away from their positions, can I fix it somehow and optimize them again so that it doesn't lag?

https://youtu.be/MezLPLDZAHU - Video number 1
https://youtu.be/GgqIsSp3c8s - Video number 2

@sobolvb Have you considered using Marker Clustering? Easy and fast solution. It helps performance and UX wise.

@mat8854
Yes, I tried it and productivity really increased. But the fact is that not all my kml files contain only points, basically these are lines with points placed on them, so this is not an option.

@sobolvb Okay, another approach is testing enabled HW-acceleration:
Configuration.getInstance().setMapViewHardwareAccelerated(true);
I have an older codebase with a feature toggle for that. There are still performace issues with polylines I think.

@mat8854
Thank you, this improved the situation, albeit very quietly. Although now I have a version with svg icons installed, I would like to find a solution for flying raster icons and try HardwareAccelerated with them

@sobolvb And it it also worth to look into the Flutter map packages and addons from time to time. They have become quite mature over the last two years. It depends what you want to build. The map rendering behaves different there. It could be an alternative.


Feature/allow dynamic rebuild of css

As discussed by email; I have added the Webpack "write-file-webpack-plugin" to enable dynamic rewrites of the extracted CSS when using the Webpack dev server.

This got abandoned by the contributor


Add service

hello
I used ros2cs for an experiment using ROS2 topic / service on a Windows GUI application.
Since service was not implemented in ros2cs, I first added only client.
service will be added in the future.
The service only tested example_interfaces / srv / add_two_ints. Others have not been verified.
The platform is Ubuntu 22.04 (or Windows) + Galactic.

Since build did not pass in my environment, some modifications that are not related to the addition of services are included in order to force build to pass.

Start of the created client.
ros2 run ros2cs_examples ros2cs_client
service uses Galactic's demo_nodes_cpp.
ros2 run demo_nodes_cpp add_two_ints_server

Now that we have completed the implementation of the service, we have closed this draft PR and created a new PR.


polygon v2 reserve factor update april

ready for review. when ready we can open a pr against the bgd repo

closing because this was already merged into the bgd repo


[Nav] Flyout Responsive Menu

Mobile menu is working. Functionality matches cfpb.gov.
Closes #918.

Heyo @ojbravo! This one is waiting on Natalia's seal of approval right?

Getting this prepped for deployment too.

A build error on this one, maybe due to the pinned design system react dependency? I'll take a look at it after the next meeting.

I too am getting a crash when previewing the build locally.  Trying to determine why.

@billhimmelsbach Build + preview issues seem to have resolved themselved 🤷🏾
PR looks good to go.


Automated cherry pick of #5449: Handle stale LabelIdentities created for empty Pod labels

Cherry pick of #5449 on release-1.12.
#5449: Handle stale LabelIdentities created for empty Pod labels
For details on the cherry pick process, see the cherry pick requests page.

/skip-all


Update SwiftFoundation to include Predicate variadic generics support

The current pinned version does not contain Predicate variadic generics, which is an area we are seeing a lot of the compact issues. Let's update the version to include that (introduced with https://github.com/apple/swift-foundation/pull/178).
This commit has been tested here. It passed both macOS and Linux tests.

@swift-ci test

@shahmishal it seems like swift-foundation passed?


move deploys out of main

moves deployed examples without Secrets out of the main environment

🚀 The docs preview is ready! Check it out here:     https://modal-labs-examples--frontend-preview-935f244.modal.run

🚀 The docs preview is ready! Check it out here:     https://modal-labs-examples--frontend-preview-d6a1f71.modal.run

🚀 The docs preview is ready! Check it out here:     https://modal-labs-examples--frontend-preview-a6efa4f.modal.run

🚀 The docs preview is ready! Check it out here:     https://modal-labs-examples--frontend-preview-3f750a3.modal.run


AMPI broadcasts should be [nokeep]

Original issue: https://charm.cs.illinois.edu/redmine/issues/1116

AMPI_Bcast currently calls ampi::generic with an AmpiMsg. For broadcasts, we should invoke a version of ampi::generic that is tagged [nokeep] so the runtime can avoid making multiple copies of the message on the receiver side. Then we need to distinguish between 'expected' bcasts and 'unexpected' bcasts in AMPI: if a bcast is expected (already blocked on), then we can serialize the message data directly into the user's recvbuf. If it is not expected, then we copy the message and put it in our unexpected message queue to be processed whenever the receiver gets to the bcast.
This is similar to what I've done for (i)(all){reduce,gather(v)} here: ~~https://charm.cs.illinois.edu/gerrit/#/c/1276/~~ https://github.com/UIUC-PPL/charm/commit/8b8b8aaab007023f31c571f035204ad57939d59a

Original date: 2016-08-23 15:06:56

https://charm.cs.illinois.edu/gerrit/#/c/1806/

Original date: 2018-11-09 16:20:36

~~https://charm.cs.illinois.edu/gerrit/#/c/charm/+/4672/~~ https://github.com/UIUC-PPL/charm/commit/7c60d20e24e37907aeef023539be273addd09c38


point cloud object generation

Hi, thank you for your amazing work. I trained your main model with shared shape and layout embedding, the accuracy is the same as the paper, but when I visualize the point cloud object, the quality of point cloud generation is not good. I followed the steps in the readme, am I missing any details?

Hello,I see you close the question,do you fix this problem?
Could you please share the visualize method with me?
Thanks a lot!


modules: [ "" ] doesn't play nice with exports

The following dependencies section results in an error when running the generate command:
  org.apache.httpcomponents:
    httpclient:
      exports:
        - "org.apache.httpcomponents:httpcore"
      lang: java
      version: "4.5.2"
    httpcore:
      lang: java
      modules: [ "", "nio" ]
      version: "4.4.4"

Error:
Could not find explicit exports named by: UnversionedCoordinate(MavenGroup(org.apache.httpcomponents),MavenArtifactId(httpclient))

Breaking up the httpcore single entry into httpcore and httpcore-nio separately resolves the issue.

I hit this today also...
:(


[v2] Sharing a docs page using the phone is not supported in custom domains

🐛 Bug Report
When trying to share a link using the phone (google chrome mobile), the link shared is the wrong one.
Have you read the Contributing Guidelines on issues?
Yes
To Reproduce

Build and deploy your docusaurus website
Set a custom domain in GitHub pages
Open the docs website in your phone (android or ios) and click in share (google chrome)
Select copy the link

Expected behaviour
The link should be the one you are at that moment (with the custom domain). The link copied is an invalid one.
Actual Behavior
The link is the "original" path for the docs instead of the custom domain. It is going to repository.github.io/docs
The issue is caused by a tag that is injected on the <head> of the HTML
<link data-react-helmet="true" rel="canonical" href="https://iQ.design.system.docs.github.io/docs/web-dev-docs/api/contributing-new-features">

When it should be
<link data-react-helmet="true" rel="canonical" href="https://design-system.iqmetrix.net/docs/web-dev-docs/api/contributing-new-features">

I believe that an option to config the custom domain if there is one in the docusaurus.config.js, would solve the issue.
Your Environment

Docusaurus version used: v2 alpha 58
Environment name and version: the lastest version of google chrome
Operating system and version (desktop or mobile): mobile

Reproducible Demo
https://design-system.iqmetrix.net/

Ignore it. It is the URL configuration that needs to be set properly :p
Sorry and thank you, Docusaurus team ;)


Authentication rejected

I have just installed via HACS, however, using the following combinations, I can't get past the authentication screen.
I have seen on the myenergi forum similar threads.  But I 100% have my correct hub id (copy and pasted it from the myenergi website, as well as typing it in directly), and I have tried several generations of API key, but every time I get "Hub serial or API key is wrong."
Happy to try to help debug!

Its your data not the integration, its almost always a typographical error, try copy and paste the API key to reduce errors.

I solved it, it wasn't a typo, I was already copying and pasting data.
The problem is in https://github.com/CJNE/pymyenergi/blob/main/pymyenergi/connection.py - or maybe it's actually on MyEnergi's side.  It was always trying to authenticate me on the s9 server (which I believe is down to their return from the director).  However, whilst the s9 server rejected my credentials, the s18 server accepted them (I guess I've been moved to their "cloud" server, which I understand the s18 is).  Making hacky adjustments in connnection.py to force it to use s18 enabled it to work.
Unfortunately, the attempt to move to the next server in connection.py doesn't appear to work, as it's reset each time one tries to authenticate from HA.

Closing the issue as it's really an underlying myenergi issue / enhancement, although, I believe it will cause an issue for newer myenergi customers who start on the s18 server.

Sorry to jump on a closed issue, but I think I have the same problem. This integration has been working pefectly for months, even through being on a myenergi Project Fusion trial, which moved me onto a different server. They appear to have moved the server I'm on again yesterday / today, which resulted in an error on the integration, I tried to add it again and I'm getting an authetication error (copying and pasting the API key). I dont know where to locate the connection.py file to make "hacky adjustments". Can anyone help me please?


Create django.yml

Summary by Sourcery
Introduce a GitHub Actions workflow for continuous integration of the Django project, ensuring compatibility with multiple Python versions and automating the testing process.
CI:

Add a GitHub Actions workflow for Django CI that triggers on pushes and pull requests to the main branch, runs on Ubuntu, and tests against Python versions 3.7, 3.8, and 3.9.

@codemakerai @sourcery-ai review, generate, and replace code for final production


Google oidc on my https server

I dont understand why, but google oidc work differently on https server, he changed request with POST on GET.
Normal oidc my localhost:
https server:

on my localhost

Why on my server google-callback changes type request?

@Nicialy there is nothing in the BlackSheep OIDC implementation that can cause a different behavior depending on the scheme of the request. I used the OIDC integration with apps over HTTPS and didn´t experience such issue.
I tried with Google integration over HTTPS using ngrok, and it works as expected.

If you don´t provide reproduction steps I cannot help more.

I suspect, if you forget to add the right "Authorized redirect URL" with HTTPS scheme, and you have only one with HTTP, the identity provider can redirect you to the enabled value, with error information (redirect_uri_mismatch). In that case you can experience a redirect to a different scheme (as a collateral effect) when trying to make a user flow.


Java11 parser assertion error: declaringType is null in Java11ParserVisitor#methodType

👋🏻
We have been toying around with rewriting some of our Java codebases, and came across files that don't parse in rewrite-java-11. Trying to reproduce the issue, this seems to be a smaller test file that doesn't parse for me on v7.4.0:
package com.company.pkg;

import java.util.concurrent.CompletableFuture;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import com.company.pkg.UnknownClass;

public class ReproduceParserIssue {

  public static void main(String[] args) {
    CompletableFuture.supplyAsync(
        () -> {
          return Stream.empty()
              .map(UnknownClass::valueOf)  // <-- this appears to be the problematic method reference
              .collect(Collectors.toList());
        });
  }
}

For example in a testcase like this:
final JavaParser javaParser = JavaParser.fromJavaVersion().build();
final String content = loadTestFileFromAbove();

final List<CompilationUnit> compilationUnits = javaParser.parse(content);
assertEquals(1, compilationUnits.size()); // <-- actually there are 0 compilation units because of the assertion

Had a quick look at the code but it's hard for me to say what is happening here without a solid understanding of the internals. Any ideas?

Thanks for the detailed report @mbruggmann. As you suggested in the title, the parser is encountering a type that under normal compilation is probably on the classpath but isn't in this case. d27d489 fixes the situation when there is a null declaringType, but I would expect there can be other consequences of not having the correct classpath.

Parsing times can be considerably slower
Things that you expect to get refactored won't because of missing type attribution.

We've found it sometimes hard to try to write offline parsing that determines the classpath independently of the build tool (Maven or Gradle). Hope this helps!

Makes sense. We should probably have another look at how we construct the classpath. In any case, thanks for following up so quickly 🎉


chore: change boto's minimum version required

Replace exact versions of boto3 and boto-core with "greater than" and setting an older version because it's the latest available for Fedora 32.
It will install latest via pypi, pinned version is not a requirement anymore because production conflicts with linchpin are not a problem anymore.
Signed-off-by: Armando Neto<EMAIL_ADDRESS>

This minimal requirement IMO should not cause any breakage. It will only affect systems that may not install latest and greatest boto. Thus ACK.


Pretty print fixup

Part of #29. Makes it so that subsequent pretty-prints align nicely with eachother. Also now displays the number of runs performed in the pretty-print.

LGTM 🚀


Upgrade stable diffusion OA template to SDXL

Tested manually in notebook. Overall, the quality seems much higher and the speed is pretty similar.
image = generate_image("Anyscale logo, as a valentines day card, professional quality art, surrounded by flowers with white envelope background", 640)

filename = "image.png"
with open(filename, "wb") as f:
    f.write(image)

from IPython.display import Image
Image(filename=filename)

When I tested other products, their examples also use refiners to further improve the image quality (like lepton's example: https://github.com/leptonai/examples/blob/main/advanced/sdxl/sdxl.py)
We can probably add those later

Yea it's a good point. We should revisit for SD3 (I assume it will have a different set of best practices since it's also a new architecture).


"space-between-declarations" and "lines-between-rulesets" not working in npm csscomb

Ok, i do

npm remove csscomb -g
npm remove csscomb
remove package.json from project root
npm i csscomb
npm i csscomb -g
put config in project root
{ "always-semicolon": true, "block-indent": "  ", "color-case": "upper", "color-shorthand": false, "element-case": "lower", "eof-newline": false, "leading-zero": false, "lines-between-declarations": 2, "space-between-declarations": "\n\n", "quotes": "double", "remove-empty-rulesets": true, "sort-order-fallback": "abc", "space-after-colon": " ", "space-after-combinator": " ", "space-after-opening-brace": "\n", "space-after-selector-delimiter": "\n", "space-before-closing-brace": "\n", "space-before-colon": "", "space-before-combinator": " ", "space-before-opening-brace": " ", "space-before-selector-delimiter": "", "space-between-declarations": "\n", "strip-spaces": true, "tab-size": true, "unitless-zero": true, "vendor-prefix-align": true }
run gulp build with pipe(csscomb(require("./.csscomb.json")));
also i try to change something in config - it is been read, and works but these options is not working

See that process on video: http://screencast.com/t/m2RuDWxUE
Please fix or explain me what i doing wrong

Possibly related to #367.


SIGSEGV: segmentation violation

awk is giving me SIGSEGV: segmentation violation when the input is huge.
I use it in https://github.com/suntong/fss. It's OK when the output is small, when running
ls -ld `ls -1d /etc/* | fss dirs`

However, when I try to feed it with huge input, it errors out:
$ mlocate /mnt/huge_volumn | fss dirs
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x66c52f]

goroutine 1 [running]:
github.com/spakin/awk.(*Script).Run.func1(0xc420305cc0)
	/path/to/go/src/github.com/spakin/awk/script.go:860 +0xc3
panic(0x6b23c0, 0x8601a0)
	/usr/lib/go-1.8/src/runtime/panic.go:489 +0x2cf
github.com/spakin/awk.(*Script).Run.func2.1()
	/path/to/go/src/github.com/spakin/awk/script.go:911 +0x5e
panic(0x6b23c0, 0x8601a0)
	/usr/lib/go-1.8/src/runtime/panic.go:489 +0x2cf
main.cmdDirs.func1(0xc4201f6000)
	/home/tong/l/gg/suntong/fss/cmdDirs.go:76 +0xbf
github.com/spakin/awk.(*Script).Run.func2(0xc4201f6000)
	/path/to/go/src/github.com/spakin/awk/script.go:920 +0xda
github.com/spakin/awk.(*Script).Run(0xc4201f6000, 0x83a380, 0xc42000e010, 0x0, 0x0)
	/path/to/go/src/github.com/spakin/awk/script.go:926 +0x29c
main.cmdDirs(0xc420096370, 0x6acce0)
	/home/tong/l/gg/suntong/fss/cmdDirs.go:83 +0x3ad
main.dirsCLI(0xc420096370, 0x0, 0x0)
	/home/tong/l/gg/suntong/fss/cmdDirs.go:59 +0x5b
github.com/mkideal/cli.(*Command).RunWith(0x865e60, 0xc42000c510, 0x1, 0x1, 0x83a3c0, 0xc42000e018, 0x0, 0x0, 0x0, 0x0, ...)
	/path/to/go/src/github.com/mkideal/cli/command.go:205 +0x2ec
github.com/mkideal/cli.(*Command).Run(0x865e60, 0xc42000c510, 0x1, 0x1, 0x865e60, 0x6bff20)
	/path/to/go/src/github.com/mkideal/cli/command.go:162 +0x95
main.main()
	/path/to/git/suntong/fss/fssMain.go:38 +0x13e

Please double-check.
Thanks

You can skip the 	"github.com/suntong/set" dependency and file extension checking if you want. The result would be the same.

Observation:
panic(0x6b23c0, 0x8601a0)
	/usr/lib/go-1.8/src/runtime/panic.go:489 +0x2cf
main.cmdDirs.func1(0xc4201f6000)
	/home/tong/l/gg/suntong/fss/cmdDirs.go:76 +0xbf

Hypothesis:

stt is nil.

Conclusion:

os.Stat is failing, but the error value is being ignored.

Solution:
// or not a dir
stt, err := os.Stat(fn)
if err != nil {
	s.Next()
}
if !stt.IsDir() {
	s.Next()
}

Bang on! My bad. Sorry to bothering you with such low level mistakes. I should have gone to sleep instead of burning my midnight oils. Thanks for helping!


[Communication] - #2bfgaaj - [Centralize Notification] Create Internal Package Provider for Zenziva

Changelog

Adding documentation :memo:
Adding unit tests :white_check_mark:
Add examples :white_check_mark:
Refactor client to use hystrix client :recycle:
Refactor New function to become NewV1 function for differentiating V1 and V2 :recycle:
Add Makefile :hammer:
Add folder to the .gitignore :see_no_evil:

Notes
The package name is changed based on the standard of Golang.
References:

https://go.dev/blog/package-names
https://stackoverflow.com/questions/63446528/package-name-containing-hyphen

Coverage

apakah kita perlu ubah nama github mas?

@asqolani-flip sepertinya, tidak perlu mas, kalau misalkan berkenan, kita bisa ubah nanti di lain waktu


putObjectMultipartNoStream doesn't properly abort upload

Minio client tries to use multipart upload automatically if object is too big.
In putObjectMultipartNoStream function used for such upload, multipart upload is created, and object is uploaded in chunks.
In case of failure, this function is supposed to abort the upload and do the cleanup:
defer func() {
      if err != nil {
	      c.abortMultipartUpload(ctx, bucketName, objectName, uploadID)
      }
}()

But, it's only triggeded if err != nil.  So, if error is happening during actual upload (for any reason), abortMultipartUpload is never invoked:
objPart, uerr := c.uploadPart(ctx, p)
if uerr != nil {
	return UploadInfo{}, uerr
}

In this case err will be nil, so abort will be skipped, leaving already uploaded parts intact.

Did you check this theory?
AFAICT when doing return UploadInfo{}, uerr uerr is assigned to err (which is not shadowed) before the defer call, so abortMultipartUpload should be called appropriately.

uerr is not assigned to err, I've provided the code snipped in the original post.
Here's link to the code: https://github.com/minio/minio-go/blob/master/api-put-object-streaming.go#L392-L395
As you can see there, uerr is instantiated on line 392 and returned on line 394. It's not assigned to err.

@raver119 See this example: https://go.dev/play/p/zOqbaWjqjI-
When the function returns it assigns uerr to err, THEN it calls the deferred function.

Ahh, you're right. My bad.


New version: iFlytek.iFlyRecMeeting version 3.0.0120

This pull request is automatically generated by 🥟 Dumplings in #3158
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


HDDS-2279. Ozone S3 CLI commands not working on HA cluster

What changes were proposed in this pull request?
Make Ozone S3 commands work on OM HA cluster
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2279
How was this patch tested?
Without this patch used to get an error Service ID or host name must not be omitted when ozone.om.service.ids is defined.
With this patch on non-secure OM HA cluster
bash-4.2$ ozone s3 getsecret --om-service-id id1
This command is not supported in unsecure clusters.
From this message, we can confirm the client is able to create.
As we don't have any secure om ha docker-compose cluster, not added any new test in this PR. Opened a new Jira HDDS-2700 to have a secure OM HA cluster where this can be tested end to end.

The changes look fine to me. @xiaoyuyao what do you think?

Thank You @xiaoyuyao and @arp7 for the review.


Error while evaluating the model which is converted from Keras to ONNX

Hello,
I have built a model in Keras and I successfully converted into ONNX. I have to load to converted ONNX model into Windows ML.
The Windows ML by-default accepts Input shape as { batch_size, channels, height, width}
But my onnx model accepts the input shape as { batch_size , height, width, channels }
Because of this while binding the model to input in Windows ML i am getting an error.
So how can i handle this in Windows ML?
Could someone please answer for this?
Thanks,
Rathna

Hi @Rathna21 , thanks for asking this question! Just need some more clarity: do you plan on passing images (videoframe) through your ONNX model? Which tool did you use to convert your Keras model to ONNX?

Thanks for the reply.
I am using onnxmltools to convert my Keras model to ONNX model.
I cannot pass it as a Video frame because windows ML by default accepts the shape { batch_size, channels, height, width }
But my input shape is different?
So, I am not sure how to proceed on this further?
@ryanlai2  It would be great if you help me on this?

I am happy to help you with this! Would you be able to share your source Keras model for repro purposes? :)

@Rathna21 Have you tried passing in the input name in channel_first_inputs { batch_size, channels, height, width } as shown here? https://github.com/onnx/keras-onnx/blob/master/keras2onnx/main.py#L61

@ryanlai2 Ok thanks for such a fast reply:)
Please find my Keras model.
https://drive.google.com/file/d/1y2TP-2mhDkgkCOJKBTvPdAE0hTPJuECd/view?usp=sharing

@youngkim93 . No I did not try this. I just used onnxmltools to convert my Keras model to ONNX.

@youngkim93  I tried using the script you said as follows,
But still my input shape remains as { batch_size, height, width, channels }
Windows ML need input in the shape { batch_size, channels , height, width }

Sorry I might have confused you here. I think for channel_first_inputs you would have to actually pass in the name of the input of a model.

@wenbingl Hi Wenbing, could you help with this issue? it seems like the model is doing unnecessary transpose at the very end. Is there any way to specify the channel_first for outputs as well?

@youngkim93  Did you find some solution for this?

@youngkim93
As u said yesterday I converted my model with keras2onnx script. Now the model has changed its input shape but there are 2 problems:

outshape shape is transposed
If i try to load the converted onnx model into Windows ML and run the model and try printing all the output values, they are all zero.

I am stuck with these 2 problems.
Could you somehow help me on this?

Closing this because issue that was referenced was resolved. @Rathna21 please reopen this issue if assistance still  needed.


docker部署的青龙突然无法启动，白屏报error

Qinglong version
最新版（maybe）
Steps to reproduce
前几天都用的好好的，今天想加个脚本发的进不去了，尝试过check和update 均报错Error: Cannot find module '/root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2'     MODULE_NOT_FOUND
What is expected?
正常进入后台
What is actually happening?
无法进入
日志如下：
root@qinglong:/ql $ ql check
开始执行... 2023-12-11 11:20:33
=====> 开始检测
changed 1 package in 6s
Writing to /root/.config/pip/pip.conf
Lockfile is up to date, resolution step is skipped
Already up to date
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/blessed. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/blessed/bin/tput.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esbuild. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esbuild/bin/esbuild does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/escodegen. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/escodegen/bin/escodegen.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/mkdirp. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/mkdirp/bin/cmd.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/needle. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/needle/bin/needle does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/resolve. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/resolve/bin/resolve does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/semver. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/semver/bin/semver.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/uuid. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/uuid/bin/uuid does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esgenerate. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/escodegen/bin/esgenerate.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esparse. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esprima/bin/esparse.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esvalidate. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esprima/bin/esvalidate.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/yaml2json. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/yamljs/bin/yaml2json does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/json2yaml. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/yamljs/bin/json2yaml does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/node_modules/.bin/pm2. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2 does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/node_modules/.bin/pm2-dev. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-dev does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/node_modules/.bin/pm2-docker. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-docker does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/node_modules/.bin/pm2-runtime. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-runtime does not exist.
Done in 6.6s
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 4, reused 1, downloaded 0, added 0
Progress: resolved 28, reused 6, downloaded 0, added 0
Progress: resolved 47, reused 13, downloaded 0, added 0
Progress: resolved 81, reused 20, downloaded 0, added 0
 WARN  deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
Progress: resolved 109, reused 27, downloaded 1, added 0
Progress: resolved 156, reused 28, downloaded 1, added 0
Progress: resolved 182, reused 36, downloaded 1, added 0
Packages: +1 -4
+----
Progress: resolved 182, reused 70, downloaded 1, added 1, done
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/blessed. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/blessed/bin/tput.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esbuild. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esbuild/bin/esbuild does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/escodegen. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/escodegen/bin/escodegen.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/mkdirp. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/mkdirp/bin/cmd.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/needle. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/needle/bin/needle does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/resolve. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/resolve/bin/resolve does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/semver. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/semver/bin/semver.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/uuid. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/uuid/bin/uuid does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esgenerate. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/escodegen/bin/esgenerate.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esparse. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esprima/bin/esparse.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/esvalidate. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/esprima/bin/esvalidate.js does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/yaml2json. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/yamljs/bin/yaml2json does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/global/5/.pnpm/node_modules/.bin/json2yaml. The source file at /root/.local/share/pnpm/global/5/.pnpm/node_modules/yamljs/bin/json2yaml does not exist.
 WARN  Failed to create bin at<EMAIL_ADDRESS>The source file at<EMAIL_ADDRESS>does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/pm2. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2 does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/pm2-dev. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-dev does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/pm2-docker. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-docker does not exist.
 WARN  Failed to create bin at /root/.local/share/pnpm/pm2-runtime. The source file at /root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2-runtime does not exist.
/root/.local/share/pnpm/global/5:

tsx 3.12.10

tsx 4.6.2

Done in 17.1s
---> 1. 开始检测配置文件
---> 配置文件检测完成
---> 2. 开始安装青龙依赖
安装 /ql 依赖包...
devDependencies: skipped

@ postinstall /ql
max setup 2>/dev/null || true

Done in 9s
---> 青龙依赖安装完成
---> 3. 开始安装脚本依赖
安装 /ql/data/scripts 依赖包...
devDependencies: skipped
Done in 5.2s
---> 脚本依赖安装完成
---> 1. 复制通知文件
---> 复制一份 /ql/sample/notify.py 为 /ql/data/scripts/notify.py
'/ql/sample/notify.py' -> '/ql/data/scripts/notify.py'
---> 复制一份 /ql/sample/notify.js 为 /ql/data/scripts/sendNotify.js
'/ql/sample/notify.js' -> '/ql/data/scripts/sendNotify.js'
---> 通知文件复制完成
---> 2. 复制nginx配置文件
'/ql/docker/nginx.conf' -> '/etc/nginx/nginx.conf'
'/ql/docker/front.conf' -> '/etc/nginx/conf.d/front.conf'
---> 配置文件复制完成
=====> 检测面板

=====> 面板服务启动正常
=====> 检测nginx服务
68 nginx: master process nginx -c /etc/nginx/nginx.conf
69 nginx: worker process
70 nginx: worker process
71 nginx: worker process
72 nginx: worker process
=====> nginx服务正常
---> pm2日志
2023-12-01T20:13:39: ✌ DB loaded
2023-12-01T20:13:39: ✌ Init file down
2023-12-01T20:13:40: ✌ Sentry loaded
2023-12-01T20:13:43: ✌ Dependency Injector loaded
2023-12-01T20:13:44: ✌ Express loaded
2023-12-01T20:13:44: ✌ init data loaded
2023-12-01T20:13:45: ✌ link deps loaded
2023-12-01T20:13:45: ✌ init task loaded
2023-12-01T20:13:45: ✌ 后端服务启动成功！
2023-12-02T06:03:01: ✌ DB loaded
2023-12-02T06:03:01: ✌ Init file down
2023-12-02T06:03:03: ✌ Sentry loaded
2023-12-02T06:03:07: ✌ Dependency Injector loaded
2023-12-02T06:03:08: ✌ Express loaded
2023-12-02T06:03:09: ✌ init data loaded
2023-12-02T06:03:09: ✌ link deps loaded
2023-12-02T06:03:09: ✌ init task loaded
2023-12-02T06:03:10: ✌ 后端服务启动成功！
2023-12-03T06:02:50: ✌ DB loaded
2023-12-03T06:02:50: ✌ Init file down
2023-12-03T06:02:51: ✌ Sentry loaded
2023-12-03T06:02:55: ✌ Dependency Injector loaded
2023-12-03T06:02:56: ✌ Express loaded
2023-12-03T06:02:58: ✌ init data loaded
2023-12-03T06:02:58: ✌ link deps loaded
2023-12-03T06:02:58: ✌ init task loaded
2023-12-03T06:02:59: ✌ 后端服务启动成功！
2023-12-04T06:02:51: ✌ DB loaded
2023-12-04T06:02:51: ✌ Init file down
2023-12-04T06:02:52: ✌ Sentry loaded
2023-12-04T06:02:58: ✌ Dependency Injector loaded
2023-12-04T06:02:58: ✌ Express loaded
2023-12-04T06:03:00: ✌ init data loaded
2023-12-04T06:03:00: ✌ link deps loaded
2023-12-04T06:03:00: ✌ init task loaded
2023-12-04T06:03:01: ✌ 后端服务启动成功！
2023-12-05T06:02:49: ✌ DB loaded
2023-12-05T06:02:49: ✌ Init file down
2023-12-05T06:02:50: ✌ Sentry loaded
2023-12-05T06:02:56: ✌ Dependency Injector loaded
2023-12-05T06:02:57: ✌ Express loaded
2023-12-05T06:02:59: ✌ init data loaded
2023-12-05T06:02:59: ✌ link deps loaded
2023-12-05T06:02:59: ✌ init task loaded
2023-12-05T06:03:00: ✌ 后端服务启动成功！
2023-12-06T06:03:01: ✌ DB loaded
2023-12-06T06:03:01: ✌ Init file down
2023-12-06T06:03:03: ✌ Sentry loaded
2023-12-06T06:03:07: ✌ Dependency Injector loaded
2023-12-06T06:03:08: ✌ Express loaded
2023-12-06T06:03:09: ✌ init data loaded
2023-12-06T06:03:10: ✌ link deps loaded
2023-12-06T06:03:10: ✌ init task loaded
2023-12-06T06:03:10: ✌ 后端服务启动成功！
2023-12-07T06:02:59: ✌ DB loaded
2023-12-07T06:02:59: ✌ Init file down
2023-12-07T06:03:00: ✌ Sentry loaded
2023-12-07T06:03:07: ✌ Dependency Injector loaded
2023-12-07T06:03:07: ✌ Express loaded
2023-12-07T06:03:09: ✌ init data loaded
2023-12-07T06:03:10: ✌ link deps loaded
2023-12-07T06:03:10: ✌ init task loaded
2023-12-07T06:03:11: ✌ 后端服务启动成功！
2023-12-08T01:24:24: ✌ DB loaded
2023-12-08T01:24:24: ✌ Init file down
2023-12-08T01:24:25: ✌ Sentry loaded
2023-12-08T01:24:29: ✌ Dependency Injector loaded
2023-12-08T01:24:29: ✌ Express loaded
2023-12-08T01:24:31: ✌ init data loaded
2023-12-08T01:24:31: ✌ link deps loaded
2023-12-08T01:24:31: ✌ init task loaded
2023-12-08T01:24:32: ✌ 后端服务启动成功！
2023-12-08T06:03:29: ✌ DB loaded
2023-12-08T06:03:29: ✌ Init file down
2023-12-08T06:03:30: ✌ Sentry loaded
2023-12-08T06:03:35: ✌ Dependency Injector loaded
2023-12-08T06:03:36: ✌ Express loaded
2023-12-08T06:03:37: ✌ init data loaded
2023-12-08T06:03:37: ✌ link deps loaded
2023-12-08T06:03:37: ✌ init task loaded
2023-12-08T06:03:38: ✌ 后端服务启动成功！
2023-12-09T06:03:02: ✌ DB loaded
2023-12-09T06:03:02: ✌ Init file down
2023-12-09T06:03:04: ✌ Sentry loaded
2023-12-09T06:03:10: ✌ Dependency Injector loaded
2023-12-09T06:03:10: ✌ Express loaded
2023-12-09T06:03:11: ✌ init data loaded
2023-12-09T06:03:12: ✌ link deps loaded
2023-12-09T06:03:12: ✌ init task loaded
2023-12-09T06:03:12: ✌ 后端服务启动成功！
2023-12-10T06:03:01: ✌ DB loaded
2023-12-10T06:03:01: ✌ Init file down
2023-12-10T06:03:03: ✌ Sentry loaded
2023-12-10T06:03:10: ✌ Dependency Injector loaded
2023-12-10T06:03:10: ✌ Express loaded
2023-12-10T06:03:12: ✌ init data loaded
2023-12-10T06:03:12: ✌ link deps loaded
2023-12-10T06:03:12: ✌ init task loaded
2023-12-10T06:03:13: ✌ 后端服务启动成功！
2023-12-01T20:13:17: Server need close, singal SIGINT
2023-12-01T20:14:38: ValidationError: The Express 'trust proxy' setting is true, which allows anyone to trivially bypass IP-based rate limiting. See https://express-rate-limit.github.io/ERR_ERL_PERMISSIVE_TRUST_PROXY/ for more information.
2023-12-01T20:14:38:     at Object.trustProxy (/ql/node_modules/.pnpm/express-rate-limit@7.0.0_express@4.18.2/node_modules/express-rate-limit/dist/index.cjs:148:13)
2023-12-01T20:14:38:     at Object.wrappedValidations. [as trustProxy] (/ql/node_modules/.pnpm/express-rate-limit@7.0.0_express@4.18.2/node_modules/express-rate-limit/dist/index.cjs:324:22)
2023-12-01T20:14:38:     at Object.keyGenerator (/ql/node_modules/.pnpm/express-rate-limit@7.0.0_express@4.18.2/node_modules/express-rate-limit/dist/index.cjs:582:20)
2023-12-01T20:14:38:     at /ql/node_modules/.pnpm/express-rate-limit@7.0.0_express@4.18.2/node_modules/express-rate-limit/dist/index.cjs:633:32
2023-12-01T20:14:38:     at processTicksAndRejections (node:internal/process/task_queues:95:5)
2023-12-01T20:14:38:     at /ql/node_modules/.pnpm/express-rate-limit@7.0.0_express@4.18.2/node_modules/express-rate-limit/dist/index.cjs:615:5 {
2023-12-01T20:14:38:   code: 'ERR_ERL_PERMISSIVE_TRUST_PROXY',
2023-12-01T20:14:38:   help: 'https://express-rate-limit.github.io/ERR_ERL_PERMISSIVE_TRUST_PROXY/'
2023-12-01T20:14:38: }
=====> 检测后台
node:internal/modules/cjs/loader:1080
throw err;
^
Error: Cannot find module '/root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2'
at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
at Module._load (node:internal/modules/cjs/loader:922:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Node.js v18.17.1
=====> 检测结束
执行结束... 2023-12-11 11:21:31 耗时 58 秒
root@qinglong:/ql $ ^C
root@qinglong:/ql $ ql update
开始执行... 2023-12-11 11:26:24
使用 github 源更新...
更新青龙源文件成功...
更新青龙静态资源成功...
开始检测依赖...
安装 /ql/.tmp/qinglong-master 依赖包...
Packages are hard linked from the content-addressable store to the virtual store.
Content-addressable store is at: /root/.local/share/pnpm/store/v3
Virtual store is at:             node_modules/.pnpm
.../node_modules/protobufjs postinstall$ node scripts/postinstall
.../node_modules/protobufjs postinstall: Done
.../node_modules/@whyour/sqlite3 install$ node-pre-gyp install --fallback-to-build
.../node_modules/@whyour/sqlite3 install: [@whyour/sqlite3] Success: "/ql/.tmp/qinglong-master/node_modules/.pnpm/github.com+whyour+node-sqlite3<EMAIL_ADDRESS>is installed via remote
.../node_modules/@whyour/sqlite3 install: Done
dependencies:

@grpc/grpc-js 1.8.15
@otplib/preset-default 12.0.1
@sentry/node 7.54.0
@sentry/tracing 7.54.0
body-parser 1.20.2
celebrate 15.0.1
chokidar 3.5.3
cors 2.8.5
cron-parser 4.8.1
cross-spawn 7.0.3
dayjs 1.11.8
dotenv 16.1.4
express 4.18.2
express-jwt 6.1.2
express-rate-limit 7.0.0
express-urlrewrite 1.4.0
form-data 4.0.0
got 11.8.6
hpagent 1.2.0
http-proxy-middleware 2.0.6
iconv-lite 0.6.3
js-yaml 4.1.0
jsonwebtoken 8.5.1
lodash 4.17.21
multer 1.4.4
nedb 1.8.0
node-schedule 2.1.1
nodemailer 6.9.3
p-queue-cjs 7.3.4
protobufjs 7.2.3
pstree.remy 1.1.8
reflect-metadata 0.1.13
sequelize 6.32.0
serve-handler 6.1.5
sockjs 0.3.24
sqlite3 <- @whyour/sqlite3 1.0.3
tar 6.1.15
toad-scheduler 1.6.1
typedi 0.10.0
uuid 8.3.2
winston 3.9.0
winston-daily-rotate-file 4.7.1
yargs 17.7.2

devDependencies: skipped

@ postinstall /ql/.tmp/qinglong-master
max setup 2>/dev/null || true

Done in 1m 2.5s
依赖检测安装成功...
更新包下载成功...
node:internal/modules/cjs/loader:1080
throw err;
^
Error: Cannot find module '/root/.local/share/pnpm/global/5/node_modules/pm2/bin/pm2'
at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
at Module._load (node:internal/modules/cjs/loader:922:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Node.js v18.17.1
执行结束... 2023-12-11 11:28:07 耗时 103 秒
/usr/local/bin/ql: line 568: h: command not found
/usr/local/bin/ql: line 569: syntax error near unexpected token fi' /usr/local/bin/ql: line 569:   fi'
root@qinglong:/ql $
System Info
No response
Any additional comments?
No response

差不多报错  重装了

今天又遇到了，上次瞎搞最后只能重装
这次的话，因为我是装在群晖上的所以备份了一下data文件夹。停止容器，重置容器 然后启动又正常了。
出错前的操作

本地电脑运行了clash of windows，不是群晖那台就打开群晖网站的那台，平时这个软件都没有开。然后把群晖设置的代理改成了这台电脑。
群晖的Container Manager 注册表切换来切换去（因为一直不行）

大概就这两步 不知道有没有影响

data放外面，然后把scripts下的文件删完（删个node_modules和pack也许），然后重新docker部署就好拉，之前的部署的一下也不会有问题，nodejs的依赖可能需要重新装下，后面把这个文件一备份，有问题还原就行

我也是，重新部署了

解决方案

#2229 @QYG2297248353
解决方案 【Docker安装】

宿主机执行 docker run --rm -v  /var/run/docker.sock:/var/run/docker.sock  containrrr/watchtower -cR <容器名>
确保有映射 data 目录


allow stream ponyfill as ReadableStream

Codecov Report

Merging #67 into master will increase coverage by 0.99%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   96.89%   97.89%   +0.99%
==========================================
  Files          15       15
  Lines         902      902
  Branches      183      182       -1
==========================================
+ Hits          874      883       +9
+ Misses         28       19       -9

Impacted Files
Coverage Δ

src/utils/stream.ts
100% <100%> (+60%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a76c4...87e13bc. Read the comment docs.


CLI option: nh_poly help string

PULL REQUEST
Purpose and Content
I don't know if this was discussed with the recent changes when we lowered the default value. This can be considered a small nuance by some, but it can be really confusing for other people (like me).
See the polynomial degree.) definition, which we represent by the current nh_poly option. In some contexts, especially finite and spectral elements (and I would say in general, in approximation theory) the word "order" is usually referred to either the degree+1 of the polynomials defining the basis function or the number of knot points used to determine it (see this ref).
Benefits and Risks
Improve the help string of the --nh_poly CLI option
Linked Issues
PR Checklist

[ ] This PR has a corresponding issue OR is linked to an SDI.
[x] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[x] I have followed CliMA's documentation policy.
[x] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[x] I linted my code on my local machine prior to submission OR N/A.
[x] Unit tests are included OR N/A.
[x] Code used in an integration test OR N/A.
[x] All tests ran successfully on my local machine OR N/A.
[x] All classes, modules, and function contain docstrings OR N/A.
[x] Documentation has been added/updated OR N/A.

Along the same lines, we could consider renaming the CLI option nh_poly -> ph_poly, since we use Nq for "number of quadrature points" and it is not clear to me what the "n" in "nh_poly" was meant to represent (but this is really a minor preference)

Works for me. I added Sriharsha as reviewer to make sure he's on the same page.

Along the same lines, we could consider renaming the CLI option nh_poly -> ph_poly, since we use Nq for "number of quadrature points" and it is not clear to me what the "n" in "nh_poly" was meant to represent (but this is really a minor preference)

nh_poly seems reasonable to me. May be Np_horz / Np_horizontal if we would like to be more informative!

bors r+


fix(package): storybook rtl should be in dev deps

Summary

storybook dep is in wrong place

:tada: This PR is included in version 1.33.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.33.2 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Ability to hide/show explorer even terminal is open by keyboard shortcuts

Its not possible to hide and show explorer when terminal is open. First i need to close teminal to do want I want.
All funcionalities I mean by shortcuts on keyboard

I've seen a recent change where sequences are unexpectedly sent to the terminal. We should investigate this.

@meganrogge I think this is by design, it works when you set:
  "terminal.integrated.commandsToSkipShell": [
    "workbench.action.toggleSidebarVisibility"
  ]


UI doesn't invoke URIs with optional path parameters

It looks like the Swagger UI has a problem with hapi-style optional path parameters.  With a route defined as:
      /books/{id}/cover

Swagger UI has no trouble at all.  It documents the route, and enables me to invoke it from the UI.  Great!
But when a parameterized path contains an optional parameter at the end, it has a problem:
    /library/shelves/{shelfId}/book/{id?}

Here it documents the route, including the optional parameter segment.  But when I try to execute the from the UI, leaving the optional parameter blank, the UI never invokes the API.
Did I miss something in the documentation? Or is this an issue?

+1, would like to see this "fixed"

+1 as well

Hi Everyone
Taken another look at this
This use case of a optional path is not supported by swagger 1.2 spec and the current swagger UI code. https://github.com/swagger-api/swagger-ui/issues/380
At the bottom of the comments on the issue Tony Tam says that the issue maybe fix with swagger 2.0 spec and new swagger UI.
I am just about to start the work to move over to  2.0 swagger, so I hope there will be a fix for you somewhere down the line. I am not sure how long it going to take to rebuild the plug-in, but I will post on this issue again when I have something.

Support for Swagger v2.x was added in December 2015 and we now have partial fixes for some of the path template issues
The plug-in now supported for paths like:
/books/{id}/cover
/library/shelves/{shelfId}/book/{id?}

There is no support for paths like
/books/{id*}
/books/{id*3}

You still need to declare the path params in the routes validate object
validate: {
            params: {
                shelfId: Joi.string().required()
                id: Joi.string().optional()
            },
}

Sorry it took so long

Glenn,
I'll try to check it out in the next few days.  I just wanted to say thank you now for all the work you've done on this plugin. It keeps on getting better and you apparently have endless energy.  Great work!
Jeff


Proper handling of @ResponseStatus with default reason().

Javadoc for @ResponseStatus.reason() says that if no value is given, the
default message from HttpStatus will be used.

Thanks!!!


Edit api creation docs to reflect correct CLI usage

Checklist

[X] Add a Changelog entry
[X] Add the ticket number which this PR closes to the comment section (N/A)

Currently, if the docs are followed, we get a typer error:
(2024-2.3-py311-tiled) [jwlodek@xf31id1-ws3 ~]$ tiled api_key create --scopes read:metadata read:data --profile nsls2
Usage: tiled api_key create [OPTIONS]
Try 'tiled api_key create --help' for help.
╭─ Error ───────────────────────────────────────────────────────────────────────────────────────────╮
│ Got unexpected extra argument (read:data)                                                         │
╰───────────────────────────────────────────────────────────────────────────────────────────────────╯

This is because list arguments with typer work by using the same flag multiple times. I.e:
tiled api_key create --scopes read:metadata --scopes read:data --profile nsls2

If you run the above, it works as expected. My guess is that it is possible that this may need to be fixed in the docs in other places as well for other List CLI args.

Thanks @jwlodek. Fortunately this seems to be the only instance of this mistake in the code:
$ git grep -e "--scopes"
docs/source/how-to/api-keys.md:$ tiled api_key create --expires-in 600 --scopes read:metadata
docs/source/how-to/api-keys.md:$ tiled api_key create --note="Data validation pipeline" --scopes read:metadata read:data

...Not to say that there aren't other list parameters...but this was a typo not a conceptual confusion on my part, so I'm hopeful. I'll keep an eye out.


feat(private_endpoint.tf) allow custom location on private-endpoint

Describe your changes
The default location for the private-endpoint is calculated from the resource-group of the VNET.
Since there could be another VNET in another region in the same resource-group, we need the ability to specify the location from the VNET or a custom location

@microsoft-github-policy-service agree

Hello, it seems you did not run the pre-commit and pr-check steps. Please read the readme file at the section contributing:
https://github.com/Azure/terraform-azurerm-openai?tab=readme-ov-file#contributing

Hi @zioproto
I have done everything as described in the instructions. Is there anything left todo from my side?
Thank you

@zioproto Do you know, when this feature be released?


Upgrade to BookKeeper 4.9.2

Motivation
Upgrade to latest stable release of BookKeeper.

run java8 tests


Add helperMaxLines to InputDecoration and InputDecorationTheme

Description
This PR adds a new property called helperMaxLines in InputDecoration and InputDecorationTheme classes.
It simply mirrors the behavior of the errorMaxLines property, but for helperText instead of errorText.
Related Issues
This PR fixes #29603
Tests

Added InputDecoration helperMaxLines test, which verifies that the helperText has the expected height.
Modified InputDecorationTheme.inputDecoration test to take helperMaxLines into account
Modified InputDecorationTheme implements debugFillDescription test to take helperMaxLines into account

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

Example of Usage
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(8),
          child: TextFormField(
            autovalidate: true,
            decoration: InputDecoration(
              helperText: 'line 01\nline 02\nline 03',
              helperMaxLines: 3,
            ),
            validator: (value) => value == 'error' ? 'error' : null,
          ),
        ),
      ),
    );
  }
}

@letsar check the errors in the analyze task.  It looks like you just have a few lines with whitespace at the end.

Thanks @justinmc, I fixed that.

@letsar Can you merge with master again?  A test is failing and I don't know why...  It seems unrelated to your changes.

@justinmc Ok I've just merged it with master, all tests passed.


IntelliSense for Python requires project reload

Reported at https://developercommunity.visualstudio.com/content/problem/49075/intellisense-for-python-requires-project-reload.html
When I first open a project, I see a warning for my open files that some IntelliSense for one of the imported modules is missing. That module is always the one in the directory the original file resides in, so I don't understand why it wouldn't be found. And unloading the Python project and then loading it back resolves the issue.

This might be related to #2727

Looks like the fix for #2727 has resolved this too.


MH-13152, Reduce Workflow Messages

The high amount of messages sent while workflows are processed can
easily cause performance issues and reduce parallel throughput.
Workflow messages contain metadata about the event and they are used to
update information in Opencast's administrative user interface and in
the external API. These information may change within workflow
operations and need to be updated after each operation as well as on
general workflow state changes (e.g. starting a workflow).
Updates are unnecessary, however, when new operations are launched since
they have been updated right before that operation already and noting
has changed since. Not sending those messages will cut the total amount
of workflow messages almost in half.

Is there any issue with the last operation in a workflow here? That is, if the last operation updates mediapackage info, is there a subsequent end-of-workflow operation that will update the index? I'm not seeing any issues with this, just wondering in theory.

The op == null condition should catch the end of workflows. The op.getState() != RUNNING instead of something like state == INSTANTIATED is a deliberate choice to not block special cases like FAILING. Mostly, we probably wouldn't need to send messages then either but there may be special cases and these messages are in any case very rare. So, better safe than sorry ;-P
About the base branch, I have no problem redirecting this to r/6.x and maybe r/5.x. I wouldn't go before that. Any preferences?

r/5.x seems a good choice.

I would be interested in backporting this to r/3.x

+1

Feel free to do that.
I'll leave this at 5.x where it is now.


A hygienic macro system

Refer: The Dylan macro system http://opendylan.org/documentation/publications.html

Not enough motivation to implement this now. Most use-cases can be covered by a combination of first-class functions and literal expressions for powerful built-in data structures.


Fix issue 85 (Useless href in report HTML)

This pull request derives from #534. So needs to be handled after that.

Fixes #85
Workaround in HTML normalizer for end-to-end test is no longer necessary, hence removed.

@cirulls
Merged this bug fix.


Governance - Freeform proposals should not show proposal details field

Description
Freeform proposals should have proposal details removed in the proposal details page if there are no fields within the proposal parameter.

Example proposal from Jon:
{
"rationale": {
"title": "An example freeform proposal",
"description": "I propose that everyone evaluate the following IPFS document and vote Yes if they agree. bafybeigwwctpv37xdcwacqxvekr6e4kaemqsrv34em6glkbiceo3fcy4si"
},
"terms": {
"newFreeform": {},
"closingTimestamp":<PHONE_NUMBER>
}
}


ts7016 error - cannot resolve types between index.d.ts and package.json

I performed an npm install aa-js into my Typescript project and VS Code is giving this linting error on the import statement.
I followed the example in the readme and started by importing julian days.
import { juliandays, Earth } from 'aa-js'

const jd = juliandays.getJulianDay(new Date())

Under the 'aa-js' it provides an error and this is the message:
Could not find a declaration file for module 'aa-js'. '/[appname]/node_modules/aa-js/dist/aa-js.js' implicitly has an 'any' type. There are types at '[appname]/node_modules/aa-js/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'aa-js' library may need to update its package.json or typings. ts(7016)
For example, this code does work:
import {
  Sun,
  coordinates,
  type JulianDay,
  GeographicCoordinates,
  HorizontalCoordinates,
  EquatorialCoordinates,
} from "aa-js";

export const calcSunAltitude = (
  jd: JulianDay,
  coord: GeographicCoordinates
): HorizontalCoordinates => {
  const sunGeoEquCoord: EquatorialCoordinates =
    Sun.getGeocentricEquatorialCoordinates(jd);
  return coordinates.transformEquatorialToHorizontal(jd, sunGeoEquCoord, coord)
    .altitude;
};

Although I am able to compile and run the web application with this error, I am not provided with any Typescript intellisense or typechecking.

I just want to confirm that while I'm getting the error and lack of intellisense, all of this code to calculate the altitude of the sun worked correctly.
import {
  Sun,
  coordinates,
  juliandays,
  type GeographicCoordinates,
  JulianDay,
  Degree,
  EquatorialCoordinates,
} from "aa-js";

  const longitude: Degree = -70;
  const latitude: Degree = 40;
  const coord: GeographicCoordinates = { longitude, latitude };

const calcSunAltitude = (jd: JulianDay, coord: GeographicCoordinates) => {
  const sunGeoEquCoord: EquatorialCoordinates = Sun.getGeocentricEquatorialCoordinates(jd);
  return coordinates.transformEquatorialToHorizontal(jd, sunGeoEquCoord, coord).altitude;
}

Update:
In my tsconfig.json file I manually pointed to the aa-js directory in node_modules and this resolved the error.
{
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "aa-js": ["node_modules/aa-js/dist/index.d.ts"]
    },
// rest of options
   }
}

Thank you very much for your bug report. I must admit I always had a very hard time understanding how to configure TS! Seriously, I read many articles, and the official documentation, but I always got lost.
I totally agree with your conclusion: this should not be necessary. However, I have no idea how to solve it.


feat(train_test_split): Add "shuffle is False" warning

Addresses #684

Closed by https://github.com/probabl-ai/skore/issues/492#issuecomment-2491444726


fix #4087

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：
Fixes #4087
Problem Summary(Required) ：

[FE PR Coverage check]
:heart_eyes: pass : 4 / 4 (100.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/alter/SchemaChangeHandler.java
4
4
100.00%

please give a meaning commit message.

please give a meaning commit message.

updated


AWS installation option

Section added on running an AMI from AWS Marketplace. Similar links are on TensorFlow and Torch docs and the respective communities have been very positive about it.

Thank you for suggestion. We are now planning to make an official AMI, and to update it with every releases. I'm now discussing about it with NVIDIA. Please wait.

The proposal looks great, but I'm wondering if the linked AMI is admitted by NVIDIA. AFAIK, they do not allow users to redistribute their CUDA/cuDNN binaries, and only NVIDIA's official AMIs can include them.


Make O_TRUNC use better

Only use if --force is actually specified

This did reduce the delta (minimally) between tar and non-tar mode. I'm not certain this is worth it. @philandstuff thoughts?

This did reduce the delta (minimally) between tar and non-tar mode. I'm not certain this is worth it. @philandstuff thoughts?

I think if we can tidy up the interface then this is a good idea. I'd also like to see us do the partial file download thing, where we download to a temp file and move to the target once the file is fully written

Superseded by #158


HCAP - 1245 Fixed callback issue with edit participant component

It looks like we were trying to call an undefined submissionCallback function.
I added a check to ensure it exists. I also added a fetch data call to the onClose function for the EditParticipant component in the ParticipantDetailsView to load the updated data after it's submitted.

I am going to merge this, and then put up a separate PR with the related test.


Fix checkCalledFromInit

This function checks if it is called from init() by looking into
callers. By the way, it may fail when init() is inlined.
To fix this, CallersFrames() is used to translate PCs into symbolic
information accounting for inlined functions.
Test: go test ./...
Change-Id: I18b3c3ffdaf71f775e3522c87607aec5df7b09c5

@googlebot I signed it!

Hmm, I wondered if this was a go1.12 vs go1.13 difference (since I wasn't reproducing it), but trying on go1.13rc1 doesn't reproduce either.

I ran into this with "go test" in "/build/soong/apex" and "go version" shows "go version go1.13rc1 linux/amd64" on my local machine.
$ go test
panic: not called from an init func

goroutine 1 [running]:
github.com/google/blueprint.checkCalledFromInit()
	~/work/aosp-master/build/blueprint/package_ctx.go:138 +0x164
github.com/google/blueprint.(*packageContext).StaticVariable(0xc0001ec0f0, 0x9f8696, 0xd, 0xc000024940, 0x3d, 0xc000024940, 0x3d)
	~/work/aosp-master/build/blueprint/package_ctx.go:267 +0x26
android/soong/cc/config.init.0()
	~/work/aosp-master/build/soong/cc/config/arm64_device.go:95 +0x1b3
exit status 2
FAIL	android/soong/apex	0.075s

Ah, in build/soong/apex. Yep, seems like a go 1.12 vs 1.13 issue (I can replicate it on 1.13, but not 1.12)


fix(opendataset): correct wrong _BOOLEAN_ATTRIBUTES in VOC2012Detection

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.921%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5292

Relevant Lines:
6382

💛  - Coveralls


Can't complete connection

Connecting and logging into Fanatical keeps connection window open on account page, but the window never closes and connection doesn't complete. That account page just stays open. Using Windows 10 with latest stable galaxy version according by today's date.

I'm having the same issue. Was hoping to see something about the problem and how to fix it, but this is the only thread I see that even addresses this problem.

Hi @Greyfeld and @oryband , the authentication process (the one that seems to fail in your case)  is the most tricky one of all the plugin. It does not suprise me that the only problem ever reported is on that part.
To be sure that no behavior on Fanatical side changed since I finished debugginig and released the plugin,  I just upgraded to the last GOG version and disconnected and re-connected the plugin: I had no issues, so it should work even now, even if the code starts getting old.
Please - first of all check to have downloaded and installed the LAST version  (second release) of the plugin: I remember some url detection failed in the first version (because some changes in url composition were made by Fanatical).
If your connection still does not succeeed, try to send here your error log (see "issue reporting" in the documentation to find it). Also you should change the log level to DEBUG or INFO in the configuration file. I'll try to have a look as soon as possible but it will take some time because of my current workload, and because the problem is probably on the javascript side (that is not seen and tracked even in logs).

I am still facing the same/similar issue. After installing the plugin's second release and restarting GoG, I go to the settings and click on 'connect,' then confirm by clicking 'connect' once again. After that, the browser window opens but keeps loading without showing the username/password fields. I have tried it on multiple devices, including Win10 and Win11, and the issue persists. It would be great if you could take the time to check it out. Thank you!
Here is my logs:
plugin-fanatical-f72d61b1-f2e2-4e46-98e0-c5f33cca34b8.log

Sadly I confirm that the GOG plugin's first log-in (and perhaps connection in general) was broken by some of the last Fanatical site releases, I'll work on it as soon as possible...


Download Site Broken

Trying to grab this useful tool, but the download site is down. Is there a mirror for the Deb file ?

Hi @dazbeattie, the download site is on GitHub and is working fine (I just tried it): https://github.com/nestybox/sysbox/releases/tag/v0.6.4
Hope that helps.


fixes small typo

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @drewswaycool!

  Generated by :no_entry_sign: dangerJS against dd997f05c1fbf2570b0a0514db26739b7723ae2e


benchdnn and rdpmc

I set out this week to run (and then, of course, port) benchdnn/ timings.
executing the rdpmc instruction was always segfaulting for me on Ubuntu 16.04,
kernel 4.4.0-93-generic.
I worked around by following kernel tools "perf" code. After opening a fd and mmap,
the rdpmc instruction was OK to use, and gave reasonable timing values.
Q1: Is there a reason to avoid usual rdtsc (optionally w/ cpuid to flush pipeline)?
Q2: Is there simpler "magic" to get rdpmc to work? (after all, I do not really even have
to use the mmaped page, because you're using the 'magic number' approach in your
rdpmc routine.)
Note3: If you did want to use the mmap'ed perf page, it seems it gives you the wall-time
conversion algorithm for free.

I'm summoning @emfomenk to this thread.

Well, benchdnn compiling but segfaulting on some linux systems might be a bug. Granted it is not critical, because it is in a tests/benchdnn/ subdirectory and can be fixed in several ways.

Fixed in 8d9fa581366cd29d1e292aa8ba44c8b82f5f1b56


Advice for using cutouts of images

Hi! Not really an issue git the repository, but I'd really appreciate it if I can get some advice on how to approach my objective as I'm not used to dealing with such large amounts of data.
I need to download cutouts of the full Sun images that correspond to SHARPs patches. I have these bounding boxes stored in a database such that each is identifies by a timestamp (corresponding to one of the images) and to one active region (so there's potentially more than one bounding box per timestamp. Each bounding box is defined by x_min, x_max, y_min, y_max, so it can be used directly on the image. My problem is that there's roughly ~millions of cutouts and with 3 components of the magnetograms this scales up very quickly. So far, I'd been trying to process several chunks of each year's data at the same time and then storing each cutout in an individual file but that seems quite unefficient. Any guidance as to how this could be better approached would be greatly appreciated.

I would probably suggest dask or zarr as we use here, I would also check out this notebook from @wtbarnes https://gist.github.com/wtbarnes/8c1e8e8e39414784fa24cca3e697dfff

Thanks! I've given it a try and at the moment it takes ~2-3 min per harpnum to process. Maybe this is as fast as I can get it to go, but it doesn't feel right. For example, for harp 104 the indices span from 9846 to 10684 which is from around 2010-07-31 to 2010-08-07 (about 7 days). I know that the data is stored in chunks, and the way I process it doesn't exploit these chunks. I've put the code that I wrote in a gist, if at any point you have some time to have a look at it, I'd really appreciate any suggestions you can make. Though I understand if you can't help with this and that's perfectly fine!
download_cutouts.py


change JSON to be treatment_var and mutation to it rather than a dict of mutations

JSON front end allows for mutations of values as a treatment. Sometimes, specific treatment values are wanted instead of mutations. Json front end does not currently support this. Implementation of control and treatment values in the test configs would fix this.


Intermittent AWS non-bootable instance failure

The AWS boot test is intermittently failing due to a non-bootable image at AWS.

When this happens, no errors are shown anywhere in osbuild-composer's output. The image imports properly as a snapshot and the AMI gets registered without an issue.
I've proposed #753 to ensure we get the osbuild logs for the compose whether it fails or passes, and this will hopefully help us figure out why this is happening.

So here's an osbuild log from a successful boot:
Output:
[/usr/lib/tmpfiles.d/journal-nocow.conf:26] Failed to resolve specifier: uninitialized /etc detected, skipping
All rules containing unresolvable specifiers will be skipped.
grub2-mkimage: info: the total module size is 0x585c.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/kernel.img.
grub2-mkimage: info: locating the section .text at 0x0.
grub2-mkimage: info: locating the section .rodata at 0x9b6c.
grub2-mkimage: info: locating the section .data at 0xb200.
grub2-mkimage: info: locating the section .module_license at 0xba64.
grub2-mkimage: info: locating the section .bss at 0xba80.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/biosdisk.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/part_msdos.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/fshelp.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/ext2.mod.
grub2-mkimage: info: kernel_img=0x563d1503d770, kernel_size=0xba73.
grub2-mkimage: info: the core size is 0x6917.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/lzma_decompress.img.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/diskboot.img.
grub2-mkimage: info: writing 0x200 bytes.
grub2-mkimage: info: writing 0x7437 bytes.
mke2fs 1.45.5 (07-Jan-2020)
Discarding device blocks:    4096/1572608               done
Creating filesystem with 1572608 4k blocks and 393216 inodes
Filesystem UUID: 76a22bf4-f153-4541-b6c7-0332c0dfaeac
Superblock backups stored on blocks:
	32768, 98304, 163840, 229376, 294912, 819200, 884736

Allocating group tables:  0/48     done
Writing inode tables:  0/48     done
Creating journal (16384 blocks): done
Writing superblocks and filesystem accounting information:  0/48     done

grub2 prefix msdos1

And here's a failure:
Output:
[/usr/lib/tmpfiles.d/journal-nocow.conf:26] Failed to resolve specifier: uninitialized /etc detected, skipping
All rules containing unresolvable specifiers will be skipped.
Failed to create file /sys/fs/selinux/checkreqprot: Read-only file system
grub2-mkimage: info: the total module size is 0x60f0.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/kernel.img.
grub2-mkimage: info: locating the section .text at 0x0.
grub2-mkimage: info: locating the section .rodata at 0x9c5c.
grub2-mkimage: info: locating the section .data at 0xb320.
grub2-mkimage: info: locating the section .module_license at 0xbb9c.
grub2-mkimage: info: locating the section .bss at 0xbbc0.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/biosdisk.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/part_msdos.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/fshelp.mod.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/xfs.mod.
grub2-mkimage: info: kernel_img=0x55c8eed304f0, kernel_size=0xbbab.
grub2-mkimage: info: the core size is 0x6cb8.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/lzma_decompress.img.
grub2-mkimage: info: reading /usr/lib/grub/i386-pc/diskboot.img.
grub2-mkimage: info: writing 0x200 bytes.
grub2-mkimage: info: writing 0x77e8 bytes.
meta-data=/dev/loop1             isize=512    agcount=4, agsize=393152 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=1, rmapbt=0
         =                       reflink=1
data     =                       bsize=4096   blocks=1572608, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=2560, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0
Discarding blocks...Done.
grub2 prefix msdos1

On the failed one, I never see the mke2fs. The artifacts are in this job:
https://osbuildci.cloud.paas.psi.redhat.com/blue/organizations/jenkins/osbuild%2Fosbuild-composer/detail/PR-774/3/artifacts

The only difference I can find between the two logs is:
--- osbuild-rhel-8.3-aws.log	2020-06-16 10:18:22.000000000 -0500
+++ osbuild-rhel-8.3-aws.log.1	2020-06-16 10:12:20.000000000 -0500
@@ -800,9 +800,9 @@
 python3-libs-3.6.8-28.el8.x86_64
 grub2-tools-minimal-1:2.02-83.el8.x86_64
 rdma-core-29.0-3.el8.x86_64
-/var/tmp/rpm-tmp.9DeeUF: line 2: /sbin/udevadm: No such file or directory
-/var/tmp/rpm-tmp.9DeeUF: line 3: /sbin/udevadm: No such file or directory
-/var/tmp/rpm-tmp.9DeeUF: line 4: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.p8eQ5m: line 2: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.p8eQ5m: line 3: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.p8eQ5m: line 4: /sbin/udevadm: No such file or directory
 libibverbs-29.0-3.el8.x86_64
 libpcap-14:1.9.1-2.el8.x86_64
 iptables-libs-1.8.4-13.el8.x86_64
@@ -2306,9 +2306,9 @@
 python3-libs-3.6.8-28.el8.x86_64
 grub2-tools-minimal-1:2.02-83.el8.x86_64
 rdma-core-29.0-3.el8.x86_64
-/var/tmp/rpm-tmp.0Hz4xN: line 2: /sbin/udevadm: No such file or directory
-/var/tmp/rpm-tmp.0Hz4xN: line 3: /sbin/udevadm: No such file or directory
-/var/tmp/rpm-tmp.0Hz4xN: line 4: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.bim52m: line 2: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.bim52m: line 3: /sbin/udevadm: No such file or directory
+/var/tmp/rpm-tmp.bim52m: line 4: /sbin/udevadm: No such file or directory
 libibverbs-29.0-3.el8.x86_64
 libpcap-14:1.9.1-2.el8.x86_64
 iptables-libs-1.8.4-13.el8.x86_64
@@ -2670,7 +2670,7 @@
 grub2-mkimage: info: reading /usr/lib/grub/i386-pc/part_msdos.mod.
 grub2-mkimage: info: reading /usr/lib/grub/i386-pc/fshelp.mod.
 grub2-mkimage: info: reading /usr/lib/grub/i386-pc/xfs.mod.
-grub2-mkimage: info: kernel_img=0x55c8eed304f0, kernel_size=0xbbab.
+grub2-mkimage: info: kernel_img=0x55ed105d64f0, kernel_size=0xbbab.
 grub2-mkimage: info: the core size is 0x6cb8.
 grub2-mkimage: info: reading /usr/lib/grub/i386-pc/lzma_decompress.img.
 grub2-mkimage: info: reading /usr/lib/grub/i386-pc/diskboot.img.

I tried building a few EC2 instances from a snapshot on one of the failures and none of them boot. The problem isn't in the snapshot > AMI > instance process, so it must be something with:

Image is not built correctly
The image in S3 isn't imported into EC2 correctly

There's nothing in the osbuild log that points to the image not being built correctly. We can probably test the S3 > EC2 import by disabling the code that deletes the image from S3 and then doing manual tests on the image.

I've done a lot of digging and here is my data:
Is osbuild building a proper image?

A passing and failing RHEL 8 image are identical for the first 1024 bytes
Partitions and partition sizes/offsets are identical between pass/fail images
Both images fail to boot in virt-manager, but they boot when converted to raw
grub configs are identical
osbuild log output doesn't show any large differences

Is the image being uploaded properly?

The size of the image on the filesystem and in S3 match
There were no errors in the S3 upload

Is the image importing properly?

No errors came out of the import process and the image was identified as a vhdx
I did 6 more snapshot imports of a failed image and those all failed to boot (using multiple instance types)

🤔 What now?
Perhaps we could try using raw images again. I know they're about 6GB versus ~ 1.5GB, but if they import more reliably, that could work.

Switching to raw for AWS extended the upload time, but all three distros reported success during the first run in #810. Running the pipeline a few more times to verify...

In #810, I've run the pipeline 3 times with 3 raw images each -- all 9 booted without issues. Running it once more just to be sure:

https://osbuildci.cloud.paas.psi.redhat.com/blue/organizations/jenkins/osbuild%2Fosbuild-composer/detail/PR-810/15/pipeline

If we end up 12 for 12, I'll submit a PR to use RAW images at AWS until we can find out why the VHDX won't work.


Adjust servo extension values

Adjust servo MIN/MAX extension so it fits through the cut out

@harshil21 I don't really care if ruff fails for a testing script tbh, what do you think?


Use same nodetool API in dse_node and node

@mike-tr-adamson and @jkni to review
I don't see why this method existed in the first place, it has no dse specific logic? Closes #536

+1 from me. It looks like it just got left in there and finally broke.

At the very least, this fixes the immediate pain point. If a more robust solution is needed, we can follow up


Distinguish model/field from plain strings in MiqExpression::Field.valid_field?

Fixes bug where a string value in an expression was incorrectly quoted because it incorrectly identified the string as "model_name-field_name".
We are using only a regular expression to for this validation. However, there are string values that will also match this pattern that are not model and field names and are instead, plain strings. So, as an additional check, we are now validating that the model_name portion of the string is an actual class.
This bug was causing the OOTB report "VMware Tools Versions" to blow up because the conditions include: {"field"=>"Vm.guest_applications-name", "value"=>"VMware"}.
In this case the guest application name is ""NetworkManager-team". This change will not detect this as a model and field.

For reference: [original pr]

@gtanzillo this LGTM....comments were nits so I'm OK with merge to get this issue fixed. @kbrock anything else?


Prevent Premature Thread Exiting

Hi Paul,
Firstly, thank you for the well-written C++ code; thread-pool is an excellent project!
I identified a potential issue where threads in the thread pool might exit prematurely under certain conditions, impacting performance and correctness.
The Scenario:

Tasks are submitted and processed by the thread pool.
When only one task remains, other threads detect an empty queue and join the main thread.
However, the last task might add new tasks.
These newly added tasks get processed by only a single thread (the last thread) since others already exited the thread pool.

See the added test case for a simple example.
Proposed Fix:
This merge request introduces an atomic counter to track the total number of tasks. The main thread sleeps on a binary semaphore, which will get signaled by the last thread if there are no other tasks in the thread pool. This ensures all tasks are completed before the main thread signals that all threads should exit.

Hello! 👋
Thanks for the PR

When only one task remains, other threads detect an empty queue and join the main thread.

This is not true unless the thread pool is being destructed. In normal situations, the threads that don't have work just wait for new work to come into the queue.
Is this the situation you're trying to address? Where the dtor of the thread_pool is being called but there is pending work and the last thread is adding more work? If that's the case, I'm not sure an additional counter would be needed. Can't we just reuse pending_tasks_ in this case?
Additionally, the unit test that was added is tripping address sanitizer:
==1696272==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00a921afe1d0 at pc 0x7ff7b0f8ec6f bp 0x00a921efef60 sp 0x00a921efef68
READ of size 8 at 0x00a921afe1d0 thread T236
    #0 0x7ff7b0f8ec6e in `dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_2> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > >'::`2'::<lambda_1>::<lambda_1> E:\Repositories\thread-pool\include\thread_pool\thread_pool.h:203
    #1 0x7ff7b0fb2172 in dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_2> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > > E:\Repositories\thread-pool\include\thread_pool\thread_pool.h:195
    #2 0x7ff7b0f89cb7 in `DOCTEST_ANON_FUNC_36'::`3'::<lambda_3>::operator() E:\Repositories\thread-pool\test\source\thread_pool.cpp:375
    #3 0x7ff7b0fbaa54 in std::invoke<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_3> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > &> C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\type_traits:1739
    #4 0x7ff7b0f8edce in `dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_3> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > >'::`2'::<lambda_1>::operator() E:\Repositories\thread-pool\include\thread_pool\thread_pool.h:200
    #5 0x7ff7b0fba7c2 in std::invoke<`dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_3> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > >'::`2'::<lambda_1> &> C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\type_traits:1729
    #6 0x7ff7b0fa356a in std::_Function_inv_small<`dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_3> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > >'::`2'::<lambda_1>,`dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread>::enqueue_detach<`DOCTEST_ANON_FUNC_36'::`3'::<lambda_3> &,std::reference_wrapper<dp::thread_pool<std::move_only_function<void __cdecl(void)>,std::jthread> > >'::`2'::<lambda_1> &,void,0> C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\functional:1359
    #7 0x7ff7b0fd2a80 in std::_Move_only_function_call<(void)>::operator()(void) C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\functional:1680
    #8 0x7ff7b0fbaaf2 in std::invoke<class std::move_only_function<(void)>>(class std::move_only_function<(void)> &&) C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\type_traits:1729
    #9 0x7ff7b0fd1495 in `public: __cdecl dp::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>(unsigned int const &)'::`5'::<lambda_1>::operator()(class std::stop_token const &) const E:\Repositories\thread-pool\include\thread_pool\thread_pool.h:54
    #10 0x7ff7b0fbaa9c in std::invoke<class `public: __cdecl dp::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>(unsigned int const &)'::`5'::<lambda_1>, class std::stop_token>(class `public: __cdecl dp::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>(unsigned int const &)'::`5'::<lambda_1> &&, class std::stop_token &&) C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\type_traits:1739
    #11 0x7ff7b0fa6a05 in std::thread::_Invoke<class std::tuple<class `public: __cdecl dp::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>::thread_pool<class std::move_only_function<void __cdecl(void)>, class std::jthread>(unsigned int const &)'::`5'::<lambda_1>, class std::stop_token>, 0, 1>(void *) C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.39.33519\include\thread:60
    #12 0x7ffa203d300f  (C:\Windows\SYSTEM32\ucrtbased.dll+0x1800b300f)
    #13 0x7ff9b7eaebde in __asan::AsanThread::ThreadStart(unsigned __int64) D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_thread.cpp:299
    #14 0x7ffa7c31257c  (C:\Windows\System32\KERNEL32.DLL+0x18001257c)
    #15 0x7ffa7c46aa47  (C:\Windows\SYSTEM32\ntdll.dll+0x18005aa47)

Ok thanks for the clarification and fix for the unit test!

I don't see how we can reuse the pending_tasks_ counter to prevent this scenario. The pending_tasks_ can be 0, but there can be tasks that are still being processed and may generate new tasks.

Maybe I'm missing something, but the main difference between total_tasks_ and pending_tasks_ is where the value is decremented. pending_tasks_ is decremented before task invocation, whereas the total_tasks_ is decremented after the task is done. Couldn't we just use pending_tasks_ and just change where it is decremented to have the same effect?
I'm going to play around with you PR and see if I can make that happen. If so, your PR may also work nicely as the base for #23

Couldn't we just use pending_tasks_ and just change where it is decremented to have the same effect?

You are right; we can use just the pending_tasks_ counter. However, I was concerned about potential performance implications. If I understand the code correctly, the worker threads keep checking the queues to get a task if they are already awake (not sleeping on a binary semaphore), and pending_tasks_ is non-zero. If we decrement the pending_tasks_ after task invocation, it could lead to busy waiting and possible unnecessary CPU drainage.
Consider this scenario: all threads are awake, the queues are empty, but one thread is finishing a long-running task. The pending_tasks_ remains non-zero, causing unnecessary spinning.
That is why I chose two counters, but looking back, it does not seem like an elegant solution.

I'm going to play around with you PR and see if I can make that happen. If so, your PR may also work nicely as the base for #23

Sounds great, thanks!

@GabTux See #62 for my updates to your PR. I will likely close this PR in favor of that one. Maybe we can continue our discussion there.
In fact, if you are able to test that PR, I would really appreciate it.

Welp I accidentally pushed this to my master 🤦♂ But I intended to merge it anyway. I renamed the counter variables and added a new subcase for the unit test you added. Thanks again for the PR!

You are welcome. I agree that the names for the counter variables are more precise now. Thank you for merging my contribution!


Numpy gmres

Adds GMRES to numpy_backend.py and tests of it to numpy_backend_tests.py. Unlike the earlier one, this PR concerns a properly merged checkout.

Comments should now be fixed


Comparison to other Collection libraries

Hello,
I'm interested to see a comparison to other libraries - both hppc and hppc-rt seem to be fairly active nowadays, why should I pick hppc-rt? Is it really RT as it claims? How does it compare to fastutil, Javolution, SmoothieMap, Koloboke?
I see you have quite a lot of JMH benchmarks in there, so would be interested to see the results on a wiki page or something.
Or, which would be much, much better - contribute benchmarks for hppc-rt to other libraries so that they have a direct comparison which they can showcase, too.
Thank you,
Petr

Why HPPC-RT ? Well, the goal has been for me to have Zero garbage at runtime, provided containers are pre-sized to your needs.  On recent JVM I suppose that such generation of small objects is unsignificant, event more so if you have escape analysis working.
Problem is, not everybody is runing modern JVMs, not even everybody is runing Sun/Oracle or its descendants. Some people even run on things that execute Java programs, but not much more can be said about it. Some are embedded, rt-like VM with RT-Gcs, (think like Zing, but with an order of magnitude shorter pauses even) the tradeof being that garbage must still be reduced to a minimum.
So the soft-RT requirement has been, to not geneating garbage at runtime, period.
For the rest, the containers must be resistant to all kind of inputs and exhibit the same kind of speed anytime. That means to be reliable, not necessarily the fastest of the lot.
In the same spirit, I've added Heaps, and LinkedLists, or CustomHash classes, fastutil-style, so maybe
you may want to use it.
Or else, if the garbage-free requirement is not so strong for you Fastutil may be a good choice, with an incredible diversity of containers and services.
So the benchmarks tried to test execution speed consistency with different key distributions.
As for the choice,

Fastutil is the closest in implementations, and big brother of all HPPC descendants,
Koloboke is the king of speed,
GS has also excellent performance,  with a different implementation.

Javolution was considered, but had so abysmal performance on keys other than Random and Linear that I've excluded from the bench (I wanted the benchs to complete during the night...)
As for SmoothieMap it has just came along, I'll study it when I have time.
Benchmarks: https://gist.github.com/vsonnier/518e438b5ee2d7c7ec95

Thank you, that actually answers my question. A last one - I see how this compares to other libraries and the comparison is very exhausting. The thing I'm missing is the comparison to the original HPPC. Is this a small fork, or a complete overhaul? Are you going to try to incorporate your changes back to HPPC? If not, do you have any comparison / intend to do one / accept pull requests for such comparisons - both speed-wise and garbage-creation-wise?

I've never intended to be a "competitor" for the regular HPPC, so I've not been tempted to bench against because our goals are slightly different.
When I have some time, I'll add Map benchmarks against HPPC's Map and ScatterMap, since you are intrested.
Even if for the sake of maintainance I indeed follow HPPC code evolutions (see  https://github.com/vsonnier/hppcrt/issues/40, https://github.com/vsonnier/hppcrt/issues/42 for REALLY big refactorings) the RT fork has diverged enough to have a life of its own, living now in its own namespace com.carrotsearch.hppcrt.
So, I've added Changes but also purposefully do not adopt some of the more recent changes of HPPC (no ScatterMaps, for instance)
As for the backport, the entirely new containers like Heaps or LinkedLists could be contributed back to HPPC without the pooled iterators and such, if I'm asked to.

Note that by https://github.com/vsonnier/hppcrt/issues/51, I'll remove CustomHash classes, in favor to a simpler alternative already present in HPPC.

You're actually one of the nicest and most communicative library developers out there. Thank you!

You are welcome !

Benchmarks:
HPPCRT_v072_vs_World.log


ERROR 1815 (HY000): Failed to execute query: desc system_metrics

What type of bug is this?
Unexpected error
What subsystems are affected?
Standalone mode
What happened?
% mysql -h <IP_ADDRESS> -P 4002
mysql> use public
Database changed
mysql> CREATE TABLE IF NOT EXISTS system_metrics (
->     host STRING,
->     idc STRING,
->     cpu_util DOUBLE,
->     memory_util DOUBLE,
->     disk_util DOUBLE,
->     ts TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
->     PRIMARY KEY(host, idc),
->     TIME INDEX(ts)
-> );
Query OK, 0 rows affected (0.32 sec)
mysql> desc system_metrics;
ERROR 1815 (HY000): Failed to execute query: desc system_metrics, source: Failed to parse SQL, source: SQL statement is not supported: desc system_metrics, keyword: system_metrics
mysql> show create table system_metrics;
What operating system did you use?
Darwin 21.6.0 Darwin Kernel Version 21.6.0
Relevant log output and stack trace
2023-07-11T14:27:55.898833Z  WARN servers::mysql::writer: Failed to execute query 'desc system_metrics' err.msg=Failed to execute query: desc system_metrics, source: Failed to parse SQL, source: SQL statement is not supported: desc system_metrics, keyword: system_metrics err.code=Unsupported err.source=Failed to parse SQL, source: SQL statement is not supported: desc system_metrics, keyword: system_metrics err.source.sources=[SQL statement is not supported: desc system_metrics, keyword: system_metrics]

How can we reproduce the bug?
cargo run -- standalone start

https://docs.greptime.com/reference/sql/describe_table
It should be DESCRIBE TABLE system_metrics.
Looks like we don't support 'desc [table]` yet.

DESC TABLE system_metrics works too.

This command is supported by the MySQL protocol. Since greptimedb supports the SQL protocol, it is recommended to support this command as much as possible to facilitate developers and maintenance personnel to view table information.
------------------ Original ------------------
From: dennis zhuang @.>
Date: Tue,Jul 11,2023 10:37 PM
To: GreptimeTeam/greptimedb @.>
Cc: heige @.>, Author @.>
Subject: Re: [GreptimeTeam/greptimedb] ERROR 1815 (HY000): Failed to executequery: desc system_metrics (Issue #1941)
https://docs.greptime.com/reference/sql/describe_table
It should be DESCRIBE TABLE system_metrics.
Looks like we don't support 'desc [table]` yet.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks for reporting this. I've submitted a patch to support it https://github.com/GreptimeTeam/greptimedb/pull/1944. Please check it out :heart:

ok
------------------ Original ------------------
From: Jim @.>
Date: Wed,Jul 12,2023 11:36 AM
To: GreptimeTeam/greptimedb @.>
Cc: heige @.>, Author @.>
Subject: Re: [GreptimeTeam/greptimedb] ERROR 1815 (HY000): Failed to executequery: desc system_metrics (Issue #1941)
Thanks for reporting this. I've submitted a patch to support it #1944. Please check it out ❤
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


XeTLA INT4 With BF16 Support

Type of Change: Feature
API not changed
Description

Fix int4 compile error for bf16 (initially as part of #297)
Rename quant_mode, including removing "fullrange" which caused misunderstanding.

Expected Behavior & Potential Risk
N/A
How has this PR been tested?
N/A
Dependency Change?
N/A

@xiaowangintel

@xiaowangintel

for fp zero section pls refer to this PR

Ready to merge as internal IPEX PR merged.


add invite_created callbacks

@scambra what do you think of this?
I made it so that the before_invite_created callbacks run before the line that sets invitation_created_at. That way, if there is an expensive operation happening in the calback, it won't make the creation time artificially early. Not sure if that is the right place, but it seemed right to me!
Apologies for the README.rdoc trailing whitespace changes - my editor does it automatically. I can take them out if you'd like!
Resolves #617

Tests are failing, I don't know why, I haven't had time to try it on my computer, but they are weird errors, I don't see how they are related to your changes. Do tests pass on your computer, at least for one Gemfile with activerecord?

I had a look into it and it turned out that devise was swallowing up the true error, which was just a typo in the name of one of my callbacks!
The tests are failing now on one specific job, but on a seemingly unrelated test. Do you recognize this failure?

rbx error I guess, re-running job works

Thanks!