xComputer Resource should not require the computer name to join a domain

xComputer Resource should not require the computer name to join a domain

This would be great. In my situation I have vCloud already sysprepping the machine before DSC is run so the computer name is already set. I would just like the xComputer resource to join the machine to the domain without requiring me to specify the computer name in the MOF.

I agree, however since it's the Key is cannot be null.
So please allow the value of 'LocalHost'. Then if the value is localhost, just use $ENV:ComputerName.
That way we can host configurations on the Pull server that are consumed by many nodes and this setting will allow it to be generic. Also this will be very easy to implement.

I also agree, i'm attempting to use partial configurations to join the machine to the domain and the requirement to specify the machine name is a problem.  I did consider using "`$env:computername" but this falls foul of the ValidationScripts (both the regex and length).
I've created my own resource as a work around but would be nice to get it included in this resource.

I'll try and get onto this change next week unless someone else does it first.

#37 seems to address this issue.

Excellent, thanks to all involved.

The schema is still broken and requires a computer name.  We should fix the schema.  ComputerName should become newComputerName and not be the key.

The idea was that if you use the string 'Localhost' for the ComputerName, then you intend to join the domain with the current name of the computer. So the name will not be blank, you just need to update the documentation to specify the special word 'localhost' and the context that it is used.

The problem is you could still have a configuration that says to rename the machine to 'foo' then later to 'bar' and the configuration would never converge.

Got the same issue. This is a blocker for me when using DSC for a domain join when using Azure Automation (AA). This as AA has a different approach in terms of compiling the MOFs.

@kvaes This may solve your needs until the Microsoft module is sorted

@theonlyway thanks! Will look into that.

Wasn't this sorted in <IP_ADDRESS> - "The Name parameter resolves to $env:COMPUTERNAME when the value is localhost".
Just specify "localhost" as the name and it will use the current name.

@danielgatley Please read https://github.com/PowerShell/xComputerManagement/issues/29#issuecomment-227013512

I vote for this

I also vote for this

I also vote for this

I believe this configuration is already valid:
    Node localhost
    {
        Computer NewNameAndWorkgroup
        {
            Name          = 'localhost'
            WorkGroupName = 'ContosoWorkgroup'
        }

However, as Travis points out, using Name as the 'key' results in the following configuration being valid:
    Node localhost
    {
        Computer NewNameAndWorkgroup
        {
            Name          = 'Server01'
            WorkGroupName = 'ContosoWorkgroup'
        }

        Computer AnotherNewNameAndWorkgroup
        {
            Name          = 'Server02'
            WorkGroupName = 'ContosoWorkgroup'
        }
    }

This will never converge. A principle of DSC is that we need to try and prevent configurations that will not result in convergence.
I believe the schema should become:
[ClassVersion("<IP_ADDRESS>"), FriendlyName("Computer")]
class DSC_Computer : OMI_BaseResource
{
    [Key, Description("Specifies the resource is a single instance, the value must be 'Yes'"), ValueMap{"Yes"}, Values{"Yes"}] String IsSingleInstance;
    [Write, Description("The desired computer name.")] String Name;
    [Write, Description("The name of the domain to join.")] String DomainName;
    [Write, Description("The distinguished name of the organizational unit that the computer account will be created in.")] String JoinOU;
    [Write, Description("Credential to be used to join a domain."), EmbeddedInstance("MSFT_Credential")] String Credential;
    [Write, Description("Credential to be used to leave a domain."), EmbeddedInstance("MSFT_Credential")] String UnjoinCredential;
    [Write, Description("The name of the workgroup.")] String WorkGroupName;
    [Write, Description("The value assigned here will be set as the local computer description.")] String Description;
    [Write, Description("The Active Directory Domain Controller to use to join the domain")] String Server;
    [Read, Description("A read-only property that specifies the organizational unit that the computer account is currently in.")] String CurrentOU;
};

Would gratefully take PRs for this one. I'm not sure when I'll get to it otherwise (5 years and counting :cry: - for that, I apologize).
Sidenote: We should add an Example showing the localhost pattern.

I believe this configuration is already valid:
    Node localhost
    {
        Computer NewNameAndWorkgroup
        {
            Name          = 'localhost'
            WorkGroupName = 'ContosoWorkgroup'
        }

However, as Travis points out, using Name as the 'key' results in the following configuration being valid:
    Node localhost
    {
        Computer NewNameAndWorkgroup
        {
            Name          = 'Server01'
            WorkGroupName = 'ContosoWorkgroup'
        }

        Computer AnotherNewNameAndWorkgroup
        {
            Name          = 'Server02'
            WorkGroupName = 'ContosoWorkgroup'
        }
    }

This will never converge. A principle of DSC is that we need to try and prevent configurations that will not result in convergence.
I believe the schema should become:
[ClassVersion("<IP_ADDRESS>"), FriendlyName("Computer")]
class DSC_Computer : OMI_BaseResource
{
    [Key, Description("Specifies the resource is a single instance, the value must be 'Yes'"), ValueMap{"Yes"}, Values{"Yes"}] String IsSingleInstance;
    [Write, Description("The desired computer name.")] String Name;
    [Write, Description("The name of the domain to join.")] String DomainName;
    [Write, Description("The distinguished name of the organizational unit that the computer account will be created in.")] String JoinOU;
    [Write, Description("Credential to be used to join a domain."), EmbeddedInstance("MSFT_Credential")] String Credential;
    [Write, Description("Credential to be used to leave a domain."), EmbeddedInstance("MSFT_Credential")] String UnjoinCredential;
    [Write, Description("The name of the workgroup.")] String WorkGroupName;
    [Write, Description("The value assigned here will be set as the local computer description.")] String Description;
    [Write, Description("The Active Directory Domain Controller to use to join the domain")] String Server;
    [Read, Description("A read-only property that specifies the organizational unit that the computer account is currently in.")] String CurrentOU;
};

Would gratefully take PRs for this one. I'm not sure when I'll get to it otherwise (5 years and counting :cry: - for that, I apologize).
Sidenote: We should add an Example showing the localhost pattern.


[bug]: cannot install dependency-injector on windows machine

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cpu
VRAM
No response
What happened?
Durring installation, pip raises the exception with encoding. This exception is almost the same as in: https://github.com/ets-labs/python-dependency-injector/issues/643 but I have a problem with cp1250 encoding.  I am using poetry to install dependencies.
Installing dependencies from lock file

Package operations: 1 install, 0 updates, 0 removals

  • Installing dependency-injector (4.40.0)

  CalledProcessError

  Command 'C:\Users\KMowinski\AppData\Local\pypoetry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11\Scripts\
python.exe -m pip install --use-pep517 --disable-pip-version-check --prefix C:\Users\KMowinski\AppData\Local\pypoet
ry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11 --no-deps C:\Users\KMowinski\AppData\Local\pypoetry\Cache\
artifacts\65\38\8b\a357c3dc165ece634599a0a94beadbc26874aadaa5283a0734a2c7109d\dependency-injector-4.40.0.tar.gz' returned non-zero exit status 1.

  at ~\AppData\Local\Programs\Python\Python311\Lib\subprocess.py:569 in run
       565│             # We don't call process.wait() as .__exit__ does that for us.
       566│             raise
       567│         retcode = process.poll()
       568│         if check and retcode:
    →  569│             raise CalledProcessError(retcode, process.args,
       570│                                      output=stdout, stderr=stderr)
       571│     return CompletedProcess(process.args, retcode, stdout, stderr)
       572│
       573│

The following error occurred when trying to handle this error:

  EnvCommandError

  Command C:\Users\KMowinski\AppData\Local\pypoetry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11\Scripts\p
ython.exe -m pip install --use-pep517 --disable-pip-version-check --prefix C:\Users\KMowinski\AppData\Local\pypoetr
y\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11 --no-deps C:\Users\KMowinski\AppData\Local\pypoetry\Cache\a
rtifacts\65\38\8b\a357c3dc165ece634599a0a94beadbc26874aadaa5283a0734a2c7109d\dependency-injector-4.40.0.tar.gz errored with the following return code 1, and output:
  Processing c:\users\kmowinski\appdata\local\pypoetry\cache\artifacts\65\38\8b\a357c3dc165ece634599a0a94beadbc26874aadaa5283a0734a2c7109d\dependency-injector-4.40.0.tar.gz
    Installing build dependencies: started
    Installing build dependencies: finished with status 'done'
    Getting requirements to build wheel: started
    Getting requirements to build wheel: finished with status 'error'
    error: subprocess-exited-with-error

    Getting requirements to build wheel did not run successfully.
    exit code: 1

    [24 lines of output]
    Traceback (most recent call last):
      File "C:\Users\KMowinski\AppData\Local\pypoetry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11\Lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 351, in <module>
        main()
      File "C:\Users\KMowinski\AppData\Local\pypoetry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11\Lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 333, in main
        json_out['return_val'] = hook(**hook_input['kwargs'])
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "C:\Users\KMowinski\AppData\Local\pypoetry\Cache\virtualenvs\cyberbieg-validator-dVobx4py-py3.11\Lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 118, in get_requires_for_build_wheel
        return hook(config_settings)
               ^^^^^^^^^^^^^^^^^^^^^
      File "C:\Users\KMowinski\AppData\Local\Temp\pip-build-env-jneyc5dp\overlay\Lib\site-packages\setuptools\build_meta.py", line 338, in get_requires_for_build_wheel
        return self._get_build_requires(config_settings, requirements=['wheel'])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "C:\Users\KMowinski\AppData\Local\Temp\pip-build-env-jneyc5dp\overlay\Lib\site-packages\setuptools\build_meta.py", line 320, in _get_build_requires
        self.run_setup()
      File "C:\Users\KMowinski\AppData\Local\Temp\pip-build-env-jneyc5dp\overlay\Lib\site-packages\setuptools\build_meta.py", line 485, in run_setup
        self).run_setup(setup_script=setup_script)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "C:\Users\KMowinski\AppData\Local\Temp\pip-build-env-jneyc5dp\overlay\Lib\site-packages\setuptools\build_meta.py", line 335, in run_setup
        exec(code, locals())
      File "<string>", line 15, in <module>
      File "C:\Users\KMowinski\AppData\Local\Programs\Python\Python311\Lib\encodings\cp1250.py", line 23, in decode
        return codecs.charmap_decode(input,self.errors,decoding_table)[0]
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    UnicodeDecodeError: 'charmap' codec can't decode byte 0x98 in position 8667: character maps to <undefined>
    [end of output]

    note: This error originates from a subprocess, and is likely not a problem with pip.
  error: subprocess-exited-with-error

  Getting requirements to build wheel did not run successfully.
  exit code: 1

  See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  PoetryException

  Failed to install C:/Users/KMowinski/AppData/Local/pypoetry/Cache/artifacts/65/38/8b/a357c3dc165ece634599a0a94beadbc26874aadaa5283a0734a2c7109d/dependency-injector-4.40.0.tar.gz

  at ~\AppData\Roaming\pypoetry\venv\Lib\site-packages\poetry\utils\pip.py:51 in pip_install
       47│
       48│     try:
       49│         return environment.run_pip(*args)
       50│     except EnvCommandError as e:
    →  51│         raise PoetryException(f"Failed to install {path.as_posix()}") from e
       52│

Screenshots
No response
Additional context
No response
Contact Details
<EMAIL_ADDRESS>

O my god... I've made mistake... wrong repo :P sorry


Perspective for the animation in switching in/out segment variants is broken in Chrome

Expected: When you change a variant of a segment, the old segment animates away by pivoting "outward" into the z-plane, and the new segment animates into being by pivoting "inward" from the z-plane.
Observed: In Chrome, the segment animation seems to be missing the z-plane perspective.
Still working in Safari and Firefox.

Chrome fixed itself now.


Denish-Ranpariya

I have read the Code Of Conduct.
I have followed all the steps of submission properly.
I have added new riddle in findTheThing section.

Hello contributor👋,
As we all know that Hacktoberfest-2020 is ended. Hope you enjoyed it a lot and made some awesome contributions.
So now it's time for schwags🎁🤩
Send your email (linked with your GitHub account) in the reply of this comment. Mention any one of the maintainers (@yashpaneliya @rudrabarad @harshptl14 @chirayu-joshi @dhruvpatel1706 ) in the reply.
We'll send a form on the email you'll provide. Please reply ASAP.
Join Club Gamma Discord for future updates.

Thank you @yashpaneliya
It was a wonderful experience.
I learned many features of git and github during the fest.
My email id<EMAIL_ADDRESS>

Great @Denish-Ranpariya 👏👏. Keep going 🙌.
You'll receive an email today for the swags form.

Great @Denish-Ranpariya 👏👏. Keep going 🙌.
You'll receive an email today for the swags form.

Haven't received the email.


fixed the nullable widgets list error

This PR is for fixing the error/red screen that comes up because of giving a List<Widget?> to the Stack widget that takes a List<Widget>

@AhmedCodor Thanks bro, I use your forked repo, and work fine on my app 👍


Character shakes when action camera is locked.

When you lock camera on 3rd person (action camera) the character is somehow lagging a tiny bit behind when camera is rotated horizontally and this causes a shake effect on the character. Not sure if this can be fixed ! Thanks !

RemoveVignette only changes a post processing option and wouldn't be able to cause this.
I think this may have been meant for the ModernCamera mod?

Not an issue with this mod


HEAD method doesn't seem to work

Hello,
I have this simple code to handle head requests:
func startServer(port: Int) -> Error? {
        do {
            if server.isRunning {
                return nil
            }

            try server.start(port: port)
            server.webSocketDelegate = self
            server.route(.HEAD, "head", handleHeadRequest(request:))
            return nil
        } catch let error {
            if error.localizedDescription == "Address already in use" {
                return nil
            }
            return error
        }
    }

   func handleHeadRequest(request: HTTPRequest) -> HTTPResponse {
      return HTTPResponse(content: "Hello")
    }

For some reason, I don't receive any requests from the server side.
Can you help me?

I am also having issue with HEAD route... in unit test when I issue HEAD http request towards Telegraph's HEAD route... e.g.
telegraph.route(.HEAD, regex: ".*") { request in             HTTPResponse(.ok)         }
Every HEAD request fails with error: "Network connection was lost" Every other HTTP method I put in that route (PUT, PATCH) works - only HEAD is failing

This should be resolved in the latest commits


create video module

new module with following methods:

formatName
fileExtension
videoCodec
audioCodec
resolution (1920x1080 etc)
aspectRatio
videoUrl (something like we do for images to generate random url to existing video) its optional as I don't know if something like that exists

ref: https://en.wikipedia.org/wiki/Video_file_format

Hey, if you are happy with my pull requests about esport module, i can deal with this module too

Good PR, happy about it, go ahead and take the next one 👍

About the video url thing. Would an array of youtube video be a good solution ?

I think its fine approach


Create Portfolio Item “portfolio-item-1”

Automatically generated by Netlify CMS

👷 Deploy Preview for ninahorne processing.
🔨 Explore the source changes: 2c123afc3a0bfe92199005aaa869b8bb534bbff3
🔍 Inspect the deploy log: https://app.netlify.com/sites/ninahorne/deploys/61ca8ef4d0818a0007ab5234


[BUG] Bearer Token expires and or token is not present at all and a 500 internal server error is returned

Describe the Bug
When bearer token expires or doesn't exist, an unhelpful 500 internal server error is thrown
To Reproduce
Steps to reproduce the behavior:

Get a bearer token for Authorization type Bearer Token via UI or POST auth/login
Let token expire (such as through inactivity)
Make GET /service/<service-id>/callback request
See 500 internal server error

Expected Behavior
It should throw meaningful exception.
Actual Behavior
It throws nebulous 500 internal server error.
Relevant Story
If applicable, link the related story here.
Additional Context

Use Postman.
Bug was discovered while working on #504

@miabecker

The library jwt_flask_extended registers appropriate app error handlers when initialized with flask app.
We do it in __init__.py:L194.
The reason why these error handlers might not be executed is that we define local error hanlders for each blueprint which contain catch all error handling for Exception.
We could try removing:
@blueprint.errorhandler(Exception)
    def internal_server_error(error):
        current_app.logger.exception(error)
        return jsonify(status_code=500,
                       errors=[{"error": error.__class__.__name__, "message": 'Internal server error'}]), 500

from app/errors.py and app/v2/errors.py. The hypothesis is that exception not handled by local blueprint error handlers will be handled by global app error handlers.

This can be closed! Had some difficulties making its way through the pipeline, with twistlock failures and a defect found by the user flow tests, but now all fixed and good to close.


TLS on Ftp-srv

This is a question about setting up a TLS connection when creating a server with ftp-srv. I've read https://github.com/trs/ftp-srv/issues/45 regarding the TLS setup of ftp-srv, but I'm afraid I've got little help from it.
As far as I understand from ftp-srv document, I can configure a boolean variable TLS (true/false) when making ftpServer object (by using new FtpSrv({tls: ${value})}). But where do I configure my certificate and private key files in TLS? It should be configured in somewhere, but I can't find the right point to start.
Also, if I want both ftp and ftps server be available at the same time, should I create two ftpServer objects? One with tls configuration and the other with none?

As noted here: https://github.com/trs/ftp-srv/blob/master/README.md#tls
You provide a TLS secure context object and not true/false.
Unfortunately unless I’m wrong looking at the code the server runs either TLS or not. Even though it would appear most of the code would support running NON TLS then upgrading to TLS. But it seems the isTLS() variable looks for ftps: in the url and the TLS context object to be set.
I’d have to do some testing but based on the code I’d presume if it didn’t look for ftps: in the url you could run a non-TLS server with AUTH TLS support.

In addition to provide cert, key and ca in the tls object, you must also include the protocol ftps://... in the url parameter.

Specifying ftps will make the server use implicit TLS. Meaning all connections have to be through TLS.
Without specifying ftps in the url, but still having a tls object set, will make the server use explicit TLS, meaning connections can be insecure, but can upgrade to a secure connection by sending the AUTH TLS command.


getting use-def information

Hi, I have a question which is not a bug of Flow itself.
I'd like to use flow's type information to do additional analysis work and need to access the use-def chain of a program. I'm wondering if it's readily available in the analyzer.
If so, my next question is what is the best approach to start with and from where if I'm to write a fixed-point style analysis that uses the use-def information.
Thanks very much.

We don't plan to expose it. eslint has better utils.


Added links to Outlook, Project and OneNote sideloading

The YoOffice template generator now creates a script for sideloading in all projects and hosts (including OneNote, Outlook and Project), so the goal of this change is that when the user tries to sideload an Add-in in an unsupported platform (OneNote, Outlook and Project) instead of getting an error we will display a link to sideloading the Add-in, in the future we can change that to actually sideload it in the corresponding host.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: MsCesarBerard sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@adam is added to the review. #Closed

@akrantz is added to the review. #Closed

@TCourtneyOwen is added to the review. #Closed

@MsCesarBerard

@MsCesarBerard When you create a branch for a pull request, instead of using master in your fork, use git checkout -b branchname to create a named branch for it. For example "sideload-more-apps" for this PR. It's better because it gives it a topic name. It will be deleted once the PR is merged. Another tip is to use "git fetch --prune" which will delete local branches which have been deleted from the remote repository.

Sounds good, I will apply that pattern for the next PRs.

In reply to: 401495148 [](ancestors = 401495148)

@MsCesarBerard I noticed a couple of small improvements that could be made.


Create a kustomize function to set the gateway on virtual services.

The gateway on our virtual services is misconfigured as described in
kubeflow/gcp-blueprints#22 and kubeflow/manifests#1169

We should be using the istio gateway in the istio namespace and not
the gateway in the kubeflow namespace

To begin to fix that this pr adds a kustomize function to transform
all the gateways in the virtual services. This makes it possible for
configurations to start transitioning to the gateway in the istio namespace

We need this for GCP blueprints with ACM (kubeflow/gcp-blueprints#22)
because we don't want to duplicate the gateway in that case.

Clean up some comments in the existing kustomize functions.

#388 should be merged first.

/assign @Bobgy

/lgtm
/approve

/approve


Yield key in Hash#transform_values

Hash#transform_values currently only yields the value that is to be transformed. I'm proposing to also yield the key. It can be useful sometimes and there's not much reason to hide it deliberatly.
This is an example where the key would be used for the transformed value:
people = {
  "alice" =><EMAIL_ADDRESS>  "bob" =><EMAIL_ADDRESS>}

record Contact, name : String, email : String

people.transform_values do |email, name|
  Contact.new(name, email)
end # => {"alice" => Contact(@name="alice", @email="alice@example.com"), "bob" => Contact(@name="bob", @email="bob@example.org")}

Implementation should be trivial and cheap. For backwards compatibility, the key would be the second block parameter. This should work with existing code because unused parameters can be omitted in block definitions.
The same applies to #transform_values! and I figure #transform_keys could be adapted similarly to yield the key as well.

Can't people use to_h if they need it? It is rare enough.

Sure, that's a possible alternative. But it's less efficient, more complex code and doesn't communicate the intention as clearly.


[DOC] jupyerlite kernel & notebooks paths

Describe the issue linked to the documentation
Wow, super cool library & docs.
I had not seen sphinx-gallery docs before, they look nice. It looks like the gallery includes a jupyterlite environment where you can run notebooks like this; I haven't seen that before either.
Suggest a potential alternative/fix
Given the docs are hosted on GitHub pages for now, I guess you probably can't install and run a kernel in that environment. It seemed that it couldn't quite find the notebooks, for example, https://skfolio.org/lite/lab/?path=auto_examples/1_mean_risk/plot_1_maximum_sharpe_ratio.ipynb, but maybe that can be fixed in conf.py via these docs - maybe the notebook can still be displayed nicely in jupyterlite, just not run, which would probably still be cool.
Either way, maybe you'd want to temporarily remove allusions to the jupyterlite pages from your docs, e.g. plot_1_maximum_sharpe_ratio.html#L399 & plot_1_maximum_sharpe_ratio.html#L836 with a script or something, or maybe can just be done in sphinx-gallery build.

Thank you very much!
Very good spot, the folder "files" containing the notbooks is missing from https://github.com/skfolio/skfolio/tree/gh-pages/lite
I'll investigate why the GitHub workflow didn't generate it.

The jupyterlite configuration was missing in conf.py under sphinx_gallery_conf. However, after more testing, the first import was too slow as described here: https://sphinx-gallery.github.io/stable/configuration.html#generate-jupyterlite-links-for-gallery-notebooks-experimental
So I replaced jupyterlite by binder.
Fixed in https://github.com/skfolio/skfolio/releases/v0.0.9

Works. Wow, Binder is cool tech. Crazy they build images & run K8s cluster of pods/containers w/ 4GB RAM each & just execute arbitrary code in notebooks from the internet for free! From this white paper, it sounds like the German government pays for it through the GRF. Cool

Indeed, what they offer is quite amazing. They give more details about resources here
Didn't know GRF was a sponsor, very interesting!


poorly done...

this document is for someone that already knows how to perform these steps. Very poorly documented with requirements and assumptions missing. Just not up to snuff sorry. i would take it down, and  redo it from the perspective of a person that DOES NOT know how to write images to storage (azure to be precise) very disappointing and quite frustrating trying to fill in the mostly empty blanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1026434-050e-b1d5-7cac-47cf5d5d2cad
Version Independent ID: bfb4d3c9-af35-f08b-710a-afc3281e3d87
Content
Content Source
Service: storage

after re-reading my thoughts are the same. The entire first half of the document is completely superfluous. A person reading this article is not here to learn how to use power-shell to provision azure resources. That simply is NOT the topic of the article. it is to learn how to write to azure storage specifically images. why would you spend more than half of your article outlining how to create a web app and storage accounts etc. and to simply say "deploy sample app from here" really? that's just plain lazy. you show a small snip of some random class that's not even properly placed into context for the reader. Really MS this is what happens when you require employees to write how  to's just for the sake of creating content. If its not helpful its probably hurting knowledge transfer not helping to improve understanding of your product/technology. Poor content is not better than lack of content i would prefer the later than having to parse through garbage. Just uh! so frustrating.

@d5omino  Thanks for the feedback, I assigned the issue to the author for further investigation.

images make it to the images folder but never the thumbnails folder? any ideas what I did wrong... both containers are there


El Capitan Public Beta: Drill from app to recent documents broken

Hi, normally if I select an app in the first pane then press ➡ I get to select recent documents. This is not working for me at the moment with 10.11 Beta (15A225f) and QS 4011. I think this was default behaviour before.

Not working for me either.
Notice the "right arrow" symbol missing next to Numbers in the results list:
http://cl.ly/image/0u2O4229222S#

It’s because this function isn’t getting any information back.
https://github.com/quicksilver/Quicksilver/blob/master/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m#L294
Hopefully there’s an alternative.

Apple has a super detailed answer at the bottom of the What’s New for El Capitan under “Removed Frameworks”:

SharedFileList. Use ServiceManagement.framework instead.

I’ve looked at that framework and see nothing that helps us.

I suggest asking in the Apple dev forums/mailing list to try and get to the
bottom of it.
On 11 September 2015 at 05:14, Rob McBroom<EMAIL_ADDRESS>wrote:

Apple has a super detailed answer at the bottom of the What’s New for El
Capitan
https://developer.apple.com/library/prerelease/mac/releasenotes/MacOSX/WhatsNewInOSX/Articles/MacOSX10_11.html#//apple_ref/doc/uid/TP40016227-SW1
under “Removed Frameworks”:

SharedFileList. Use ServiceManagement.framework instead.

I’ve looked at that framework and see nothing that helps us.
—
Reply to this email directly or view it on GitHub
https://github.com/quicksilver/Quicksilver/issues/2079#issuecomment-139381094
.

Searching around, I saw that LaunchBar also has had this feature, so I tried it out and it’s also broken there. But there’s hope (for us as well, thanks to the very specific answer):
https://forums.obdev.at/viewtopic.php?f=4&t=9984&p=30133

Awesome, nice detective work. Should be a pretty easy fix then, but I guess we need to look at the format of that file first.

The format of the file is… unusually flat. Rather than try to make sense of it, I just hit it with a stick a few times.

Rob, I really appreciate you file bludgeoning skills!!! :sunglasses: Thanks for this fix!

Glad we figured it out. Someone explained the format, so we’re actually reading it in the right way. Except that it’s private and we’re not supposed to be reading it at all. Other than that… :smiley:


Error while generating conf for CP related swagger

This issues resolve from https://github.com/wso2/apk/pull/1792


Question: Is it possible to feed an sdf file of prepared ligands straight into docking?

I'm trying to work out whether it's possible to put an sdf file of prepared ligands straight into a Glide run? i.e. not specifying an input_pool to the docking_runs list? (especially when using docker.py)

Hi @reskyner,
Yes, you can input prepared ligands in SDF format directly for docking. You can keep everything in the configuration JSON the same except for changing the following (bolded):
"input": {
"input_path": <path to .sdf ligands file>",
"type": "sdf"
}
DockStream will recognize SDF format, skip ligand preparation, and use the coordinates in the .sdf file directly for docking.

Perfect! Thank you so much for the quick reply.
On Wednesday, 19 January 2022, Jeff Guo @.***> wrote:

Hi @reskyner https://github.com/reskyner,
Yes, you can input prepared ligands in SDF format directly for docking.
You can keep everything in the configuration JSON the same except for
changing the following (bolded):
"input": {
"input_path": <path to .sdf ligands file>",
"type": "sdf"
}
DockStream will recognize SDF format, skip ligand preparation, and use the
coordinates in the .sdf file directly for docking.
—
Reply to this email directly, view it on GitHub
https://github.com/MolecularAI/DockStream/issues/8#issuecomment-1016898277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBMODIDONX3GU5NMGXQA73UW4WXXANCNFSM5MKWDBZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


mountTo and then unmount will remove the root element

Suppose I have an html element and I mount tag to it:

var tag = riot.mount('div#abc', 'mytag')[0]

Then if I unmount, the tag's root html element will be removed from DOM tree
tag.unmount()  // use keepParent = true, same

In 2.0.11, the parent element will not be removed, but now in 2.0.14 it will.
To have a container and mount tag to it and unmount to switch another tag, can be a useful pattern to build a multi-view app, now it cannot be used, what's the workaround?
Thanks!

Is this same as #576 ?
I see unmount(keepTheParent) in https://muut.com/riotjs/api/#mount-to  So I am confused, is this already in 2.0.14, or not?

It will be available with the next riot release https://github.com/muut/riotjs/issues/576#issuecomment-91911707


noTraceOrigins is not in skywalking-client-js version 0.4.0

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[x] Requirement
[ ] Feature or performance improvement

Question

skywalking-client-js latest version is 0.4.0, and is publish at 26, Feb. But the feature of noTraceOrigins was added on 16 Mar, when we can use the 0.4.1 or 0.5.0
https://github.com/apache/skywalking-client-js/pull/45

Please read docs. https://github.com/apache/skywalking-client-js/blob/master/CHANGES.md

i cannot find 0.5.0 in npm repository
https://www.npmjs.com/package/skywalking-client-js

It isn't out yet. Subscribe to our twitter or mail list for latest news.


https://identitydivision.visualstudio.com/StackOverflow/_queries/query/76481119-c35b-4799-bc86-09ab4a7942fc/

Lou mentions  the following; "new page states the following but should probably add that PHS/PTA aren’t tested in that scenario either" Recommend this be added to the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a02d8b61-29e8-c0a7-b3b2-79be7212a91c
Version Independent ID: b4346d87-0727-c7fe-7896-7fd79098825c
Content: Configuring Alternate Login ID
Content Source: WindowsServerDocs/identity/ad-fs/operations/Configuring-Alternate-Login-ID.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

Issue being handled internally.
#please-close


Thread safety of geos context and lifetimes

Hi,
I have few questions/suggestions about geos context and lifetimes. (I'm literally couple of days into learning rust so I may not see some obvious things.)
1) GEOS context
I don't understand why each geometry keeps geos context and why is this context cloned over to other derived geometries (even though the cloned rust context is referencing the same instance of geos context).
Geos context is ment to be used as a thread safe mechanism to propagate C++ exceptions through C api and to keep some temporary/helper data AFAIK (like buffer to format error messages or geos Point instance to be re-used as a temporary object). But rust binding does allow non-thread safe usage.
I think it would be good to have thread local instances of geos context and to use those temporarily just to call C geos api. This wayite would also prevent unnecessary allocations of new contexts in many operations (like creating new non-derived geometries, new coordinate sequences, etc.).  In the end the whole context mechanism would be private (and transparent to the users of rust api).
The only thing in geos context which is not primarily related to thread safety is configuration of WKB dims and byte order. But I feel like it does not belong there and also it has been deprecated.
There is draft of what I mean: https://github.com/georust/geos/commit/8c096818dd8b73dfdee93ccad77dcec743c48e0f
links:

c geos context structure: https://github.com/libgeos/geos/blob/3.12/capi/geos_ts_c.cpp#L202-L214
using context to store exceptions: https://github.com/libgeos/geos/blob/3.12/capi/geos_ts_c.cpp#L415-L435
deprecation of wkb setters/getters on context: https://github.com/libgeos/geos/blob/3.12/capi/geos_c.h.in#L5870-L5908
re-use of Point from context: https://github.com/libgeos/geos/blob/3.12/capi/geos_ts_c.cpp#L3500-L3507

2) Lifetimes
I don't understand why Geometry struct (and other structs) has explicit lifetime and why all functions returning new derived geometries also have the same lifetime. Because derived geometries resulting from geometric operations, etc. are just new and owned geometries non-related to the input geometry/geometries.
(It's true that derived geos geometries do pass around non-owned pointer to geometry factory, which is also part of geos context, but which cannot be changed with C api and which is always set to the single global instance.)
It seems to me that all lifetime parameters could be removed and the code would still be correct. And then it would be possible to pass Geometry freely around without any constraints. (But as I wrote, I do not have much experience with rust yet. Maybe I'm missing something.)
There is draft of what I mean: https://github.com/georust/geos/commit/83c32190fd253fb3459f2746d89b1906e671d79c

All the problems you describe come from my (very) limited understanding of GEOS.
Basically it all comes down to this: is it useful to be able to provide your own context to a type? With the suggested changes, we can't set an error handler to a specific type or even a specific context to a type since they all share the same one.


Spec for set terminal initial position

This PR is for the GitHub task: https://github.com/microsoft/terminal/issues/1043
For now, we are going to implement two features:

Users could set the initial position of the terminal window using the json settings file.
Users could choose to maximize the window once the App is launched.

The current PR is only for the spec review. There is no code change yet.

References

PR Checklist

[ ] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

How do these initial position enum values work, with devices in Tablet Mode, or Hololens?

The current PR is only for the spec review. There is no code change yet.
I see changes to the code though...

Oh, sorry for this mistake. Those changes are just for ramp-up and research. I would create a new PR for code changes.

Hey it looks like this was never merged, but the feature was merged - @KaiyuWang16 can you come update this PR to reflect the state of the changes that were merged for this feature? I'd love to get it cleaned out of the PR backlog ☺

Hey it looks like this was never merged, but the feature was merged - @KaiyuWang16 can you come update this PR to reflect the state of the changes that were merged for this feature? I'd love to get it cleaned out of the PR backlog ☺

Updated ! Sorry I missed this.

I do not understand why the PNG in this spec looks so strange.
How are you generating your screenshots?
Also, this looks like a screenshot that should just be a snippet of text...

I updated the image and now it looks more clear.

But does it need to be an image at all? It looks like the perfect candidate for a markdown fenced code block...

But does it need to be an image at all? It looks like the perfect candidate for a markdown fenced code block...

Changed. Thanks for the advice.

@cinnamon-msft, @leonMSFT - we need one more (three) for a spec review. This one's old and the feature has already merged. Mind having a look?


Run one-liner scripts from the command line

We could provide an option to run simple scripts directly from the command line:
To display the cluster name defined in a footloose configuration:
jk run -c "read('footloose.yaml').then(c => log(c.cluster.name)"

To implement this, we would have a small wrapper we execute instead of the command line (needs master to use these imports, see: https://github.com/jkcfg/jk/blob/master/docs/deprecations.md).
import { log, write, read } from '@jkcfg/std';
import { dir, info } from '@jkcfg//std/fs';
import * as param from '@jkcfg/std/param';

%s;

and the content of the -c option is injected in that wrapper.
This needs to have:

An example in the jk run help text
A e2e test

:+1: for both this and running a module jk run -m "@myorg/charts/foobar" :-)


Master reconciler

Isn't this more of a "policy update" than a "reconciler update"? I read over this because I was excited to see some automation for the openshift reconciler, which is a pod that runs on V3. The name "openshift reconciler" here might be confusing.

Just saw this go by in email, and I mostly agree with @dak1n1 about the name.  Perhaps "policy reconciler" or "policy reconciliation" ?  It really is "reconciliation", and the subcommand is "reconcile", so I think it makes sense to have some form of that term in the role name, but without the word "policy" it's not clear what it is that you're reconciling.  (Of course, the reconciler pod in online should also have a descriptor in its name, for the same reason.  :-) )

Closing in favor of renaming and trying to convert an existing playbook into roles.


ocamlPackages.janeStreet_0_15 can't fully evaluate on it's own

Describe the bug
I'm playing with a tool to explore and validate derivations in nixpkgs. I encountered a few sets where some attributes generate unrecoverable exceptions. One of them is ocamlPackages.janeStreet_0_15. AFAIU the set can't be used as is as some packages require dependencies to be satisfied from the outside self.
The reproducer:
nix-instantiate --strict --eval --expr 'with import <nixpkgs> {}; lib.length (lib.attrNames (lib.filterAttrs (n: v: let e = builtins.tryEval (v.drvPath or (throw "not a drv")); in e.success) ocamlPackages.janeStreet_0_15))'
error:
       … while calling the 'length' builtin

         at «string»:1:27:

            1| with import <nixpkgs> {}; lib.length (lib.attrNames (lib.filterAttrs (n: v: let e = builtins.tryEval (v.drvPath or (throw "not a drv")); in e.success) ocamlPackages.janeStreet_0_15))
             |                           ^

       … while calling the 'attrNames' builtin

         at «string»:1:39:

            1| with import <nixpkgs> {}; lib.length (lib.attrNames (lib.filterAttrs (n: v: let e = builtins.tryEval (v.drvPath or (throw "not a drv")); in e.success) ocamlPackages.janeStreet_0_15))
             |                                       ^

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: undefined variable 'inotify'

       at /nix/store/817w4lar0iawdyhv8v4hn2vmmk8s36v7-source/pkgs/development/ocaml-modules/janestreet/0.15.nix:81:42:

           80|     meta.description = "Async wrapper for inotify";
           81|     propagatedBuildInputs = [ async_find inotify ];
             |                                          ^
           82|   };

Note how inotify reference fails to resolve and break the whole evaluation even in presence of tryEval.FOr comparison filanl eval is fine:
nix-instantiate --strict --eval --expr 'with import <nixpkgs> {}; lib.length (lib.attrNames (lib.filterAttrs (n: v: let e = builtins.tryEval (v.drvPath or (throw "not a drv")); in e.success) ocamlPackages))'
940

What would be the best way to fix it? The simplest (but tedious) could be to add unsatisfied dependencies as throw stubs, like:
--- a/pkgs/development/ocaml-modules/janestreet/0.15.nix
+++ b/pkgs/development/ocaml-modules/janestreet/0.15.nix
@@ -6,6 +6,8 @@
 , ocaml
 , openssl
 , zstd
+
+, inotify ? throw "'inotify' should be present in 'self' argument"
 }:

But it will require quite a few entries. I can propose a PR if it's sensible.
WDYT? Is it something worth fixing to ease attribute traversal from within nix?
Fun fact: stanc does use that incomplete set and happens to work as it does not use packages with unsatisfied depends:
pkgs/top-level/all-packages.nix-  stanc = callPackage ../development/compilers/stanc {
pkgs/top-level/all-packages.nix:    ocamlPackages = ocaml-ng.ocamlPackages_4_14_janeStreet_0_15;
pkgs/top-level/all-packages.nix-  };

Expected behavior
Ideally the evaluation of ocamlPackages.janeStreet_0_15 should not produce unrecoverable exceptions to ease attribute discovery.
Notify maintainers
@vbgl
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.8, NixOS, 24.05 (Uakari), 24.05.20231230.9fafaa3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.19.2`
 - channels(root): `""`
 - channels(slyfox): `""`
 - nixpkgs: `/run/current-system/sw/share/nixos-flakes/inputs/nixpkgs`

Add a :+1: reaction to issues you find important.

Full list of missing inputs is 18 packages: angstrom angstrom-async base64 cryptokit faraday gen_js_api inotify js_of_ocaml-compiler js_of_ocaml-ppx js_of_ocaml lambdasoup magic-mime ocaml_pcre pyml sedlex tyxml uri-sexp zarith


Fix FindMKL.cmake

Hmm, this was supposed to be a reproducer for votca/votca#350, but it doesn't fail here either, not even in votca/buildenv:fedora_gmx2020_d

See votca/xtp#493


Traverse module boundaries when type checking is disabled

e.g. this code typeChecker.getSymbolAtLocation(node.moduleSpecifier) returns undefined instead of the exported modules.
how else should we do this if it's turned off? what would be the most resilient way forward.
this affects parcel out of the box. and this affects babel since it's turned off there as well.

we've pivoted to Babel - not a problem now.


Purge unused code

IMPORTANT: Please search among the Pull request before creating one.
Title

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New feature (non-breaking change which adds functionality)

Description

How has this been tested?

Several dead tests were removed.
Closes

closes #359
TODOs:

[ ] add functions for init/terminal states plotting (save meta_states from GPCCA!)
[ ] update tutorials
[x] better static analysis by enabling pre-commit in travis
[ ] investigate bug when identity matrix is being written in high level tutorial

Merging this. Not sure why 3.7 SLEPc is failing, will investigate later.


Add normalization and duplicates support

Summary
This PR adds normalization function to the library. That is, in a json file that mixes multiple separators like _ and ., you can normalize all of them to only _. In addition, if a file mixes a flattened style with an un-flattened style, that can also be normalized. In order to support normalization, duplicate detection was added to the flatten function in the event of a duplicate.
Bug Fixes/New Features

normalize function
added "duplicate detection" in flatten

How to Verify
I added unit tests to test this new functionality, I can add more if you feel that would be helpful. I also used it on our own json dictionaries of ~1500 lines with great results.
Side Effects
For the normalize function, several of the parameters should be required, but this means that I need to put them before the named/optional parameters. I left the ordering of the params in the existing functions unchanged, but that means the ordering of the params isn't consistent between normalize and flatten for the params that they share.
Resolves
No open issue or bug is resolved by this PR.
Tests
All tests are currently passing.
Tests added:

test_normalize_with_one_key
test_normalize_with_mult_keys
test_normalize_with_dupes
test_normalize_expd_with_dupes
Tests changed:
None

Code Reviewer(s)
@amir-ziai-zefr is this a feature you'd be interested in merging?

I guess the CI is failing. I'll try to troubleshoot that. It worked locally...

Ok, the duplicates needed to be sorted before comparing them in the unit test. I wonder if I should sort them before I return from flatten/normalize instead of relying on the caller to sort?

Hey @therealjumbo. The changes looks very interesting. Do you mind updating the README to reference the use case(s) that lead you to these changes and maybe an example? Think it would be really helpful. Thanks!

@amirziai
I'll update the README.
I think I also should:

add a unit test to raise that exception
move the sorting of dupes into flattten

I'll reply to this thread when I think it's ready. Thanks for your time.

hey @therealjumbo are you still working on this?


Driver attempts to download from http://central.maven.org

Steps to reproduce:
Database -> Driver Manager -> Mssql -> SQL Server -> Edit -> Download/Update
I am getting an error Error resolving driver libraries and error resolving dependencies
The request made seems to be going to http://central.maven.org when it seems like it should be made to https://repo1.maven.org
Editing to add: My local proxy configuration seems to be causing dbeavers certificate validation of repo1.maven.org to fail where it downgrades to central.maven.org this request throws a 404. Is there another http:// repository available?

I cannot reproduce. Could you please tell DBeaver version and your OS?

I cannot reproduce. Could you please tell DBeaver version and your OS?

Desktop is Windows 10. The workstation is configured with a web proxy; although the proxy certificate is trusted on the desktop, dbeaver seems to use it's own trust store to validate (this is fine). However it would be nice to inform the user that there is an error with the certificate validation of the maven repo.
It then tries to connect to the plain-text http://central.maven.org repo to fetch the drivers. The pom files no longer exist here. And causes the Error resolving driver libraries error. It would be nice here to show the user there was a 404 to help them debug. This took me a couple hours to figure out what was causing the misleading error message.

By default DBeaver uses https://repo1.maven.org.
http://central.maven.org is a legacy plain http repository. It is left for backward compatibility for those who, by any reason, can't use https protocol to download artifacts from Maven.
DBeaver uses legacy repo only if repo1 is not accessible and it warns user about unsecure driver download.
Recently non-https Maven Central repository was banned (that's great actually).
We need to remove non-secure Central repository config completely. Thanks for noticing this.

verified


Add pagination to /v1/secret-versions API

Coverage increased (+0.2%) to 54.467% when pulling 9ac05cff18f4e6332570bab3ad8137d7311f8e02 on versioning into d033593062e93051deb4fda9cb8e9ceb4627cc01 on master.

Coverage increased (+0.2%) to 54.467% when pulling 9ac05cff18f4e6332570bab3ad8137d7311f8e02 on versioning into d033593062e93051deb4fda9cb8e9ceb4627cc01 on master.


Fixed #6171 -- Always fallback to a configured site language on the page admin

Fixed #6171

Coverage remained the same at 79.105% when pulling 97412bada934f65a1c411f01607d770dba8168af on czpython:fixes/3.5.x/6171 into da37f26fbf2ac3702e62e7ffe3cbd2935e93ff99 on divio:develop.

👍


Format code with clang-format

Also ensure that everything keeps correctly formatted by running clang-format in the CI and failing the build if any file is not formatted correctly.

Coverage increased (+0.06%) to 95.545% when pulling 31e4f2d2a7ac4ae324cc1c0c750c83013748a8e9 on clang-format into 8b022dad76d44ea5ec01fdeffbd8214eeab88c19 on master.

One more thought, since CI will fail upon formatting issues maybe that should just be part of make check instead?  It's not awesome when you take the time to run make && make check, everything passes then CI rejects.

Good observations! I added the AllowShortCaseLabelsOnASingleLine directive because I thought it generated a slightly smaller diff, but I actually didn't like it that much either :) I set the maximum line length to 90 now. make check now also runs the clang-format check, and the test is skipped if the user doesn't have clang-format installed. We should probably have a development section in readme to document this, and any other development practices if there's something worth mentioning.
Merging this will conflict with all the other open PRs. Do you think there's any PR that would be better to get ready before this onet?

Merging this will conflict with all the other open PRs. Do you think there's any PR that would be better to get ready before this onet?

Maybe #441?


How to do custom EarlyStopping?❓ [QUESTION]

I would like to do some custom early stopping (e.g. based on a file existing, or checking if I get close to a walltime on a compute cluster)
Is there some way to specify a custom early stopping class?
I tried using early_stopping and early_stopping_conds arguments of the trainer (or in the config.yaml), but could not make anything happen.
I was able to accomplish what I wanted through an on-end-epoch callback
class FileStopCallback:
    def __init__(self, stop_file: Path):
        self.stop_file = stop_file

    def __call__(self, trainer):
        if self.stop_file.is_file():
            with open(self.stop_file, 'r') as f:
                reason = f.readline()
            trainer.__class__.stop_cond = True
            trainer.stop_arg = f"Early stopping: stop file detected with reason: {reason}"

But it seems rather hackish (you can't set trainer.stop_cond directly because it is a property without a setter).

Hi @ThePauliPrinciple ,
Thanks for your nice question and work with our code!
Re

checking if I get close to a walltime on a compute cluster
we do have support for a fixed walltime bound:  https://github.com/mir-group/nequip/blob/develop/configs/full.yaml#L210-L211.  But if you want to query the job scheduler for example that will have to be custom of course.

I've just added support for custom early stopping conditions on branch: https://github.com/mir-group/nequip/tree/feature-custom-early-stop with an example at https://github.com/mir-group/nequip-example-extension/tree/earlystop.  Please give this a try and let me know if it works for you, and I'll merge it down.
If this doesn't fully solve the issue (or even if it does), it might be a more complicated workflow than I'm anticipating, and maybe we should have a quick call to discuss---please feel free to send me an email at the address listed in my profile.

This looks good to me.
Passing the trainer object to the stopper might be useful to some, although for my use case I am only interested in "external" information.
I'm not exactly certain what the comment about restarting means, in particular, when is a stopper considered "stateful"?

Great!
A stopper is "stateful" when it maintains a state like, say, how many epochs the validation loss hasn't improved (like the patience setting) or what the minimum observed value was (see https://github.com/mir-group/nequip/blob/feature-custom-early-stop/nequip/train/early_stopping.py#L120-L121).  If it only depends on the current arguments to the object, and not any state stored in your custom object, then it's not stateful.   (State of the trainer, if that was passed in, will be correctly preserved across restarts.)

The original early stopper also returned values to immediately debug/print, maybe that's also nice to add.

What do you mean, exactly?

https://github.com/mir-group/nequip/blob/c56f48fcc9b4018a84e1ed28f762fadd5bc763f1/nequip/train/early_stopping.py#L98
Here debug_args is returned, which is printed to the log:
https://github.com/mir-group/nequip/blob/c56f48fcc9b4018a84e1ed28f762fadd5bc763f1/nequip/train/trainer.py#L874-L882


Wayfire starts with XDG_CURRENT_DESKTOP either unset or set to previous session's desktop

XDG_CURRENT_DESKTOP ends up set to either GNOME if I was last using a GNOME session on my desktop before rebooting, or nothing at all. WAYFIRE_LOCAL_CONFIG remains unset by the tweaks function, so the unit that starts Wayfire starts it with a -c switch, but no config path.

Does ${XDG_CONFIG_HOME}/wayfire/wayfire.ini exist after launch attempt?

I've added more conditions on config file search, but that may not address this problem directly.
Could you post journalctl --user -u wayland-session-wayfire.scope (if you launched via shell-intstart) or journalctl --user -u<EMAIL_ADDRESS>(if you launched via sd-start or<EMAIL_ADDRESS>service directly)

I launched it via the .profile snippet. Well, I adapted it for .zprofile.

Here's a log output.
wayland-session-env.txt

Are those vars with %% specific for zsh environment?
looks like systemctl errors out and does nothing, I'll look into this.

Looks like your environment has something that should not exist there.
This case seems relevant: https://access.redhat.com/discussions/4124031.
Can you determine where those illegal vars come from? env or systemctl --user show-environment or both?
For now I've added exit with error on failure to run import-environment. The assumption is that the actual environment can not contain vars with illegal names. Maybe I'll add a filter later.

Apparently, I had env-modules installed, and I forgot that. That's apparently an AUR package, so it's not even official on Arch.

I've added a filter function for all processing of env output, please try running again with illegal vars. Error messages will be logged by<EMAIL_ADDRESS>but everything should work.


New project: Anime Data Analysis and Prediction

Goals
To analyze the Anime Dataset using Exploratory Data Analysis using several parameters and then try to make predictions

@Niketkumardheeryan  can you please assign this to me

The issue has been assigned.

@invigorzz313  can you also please add the level label?


Use dedicated attributes to fill proxy authentication

This PR adds 2 attributes in Settings to keep the proxy authentication.
We then provide the user and password to cUrl using the dedicated options: PROXYUSERNAME and PROXYPASSWORD.
Closes #2512

@develohpanda
I think I should be able to add tests in network.test.js but I'm not sure to understand: is there a real call done or is there a mock/stub somewhere 🤔
I think I should update axios helper to handle the HTTP proxy authentication. However, it seems that proxy authentication is (deliberately?) skipped. Should I make the change?

@develohpanda
Concerning the axios-helper, it is also exported in
https://github.com/Kong/insomnia/blob/8b278987872668665eb016449a5268300f63cbfd/packages/insomnia-app/app/plugins/context/app.js#L117L120
but it seems this is a private "export".
So I think we don't need to make the change here.

Closed as stale.


sqlite.lua locks database after an error

STR

Change uri to yours
Run script for the first time (should be ok)
Run script for the second time. You should receive an error UNIQUE constraint failed as expected
Change indexes:insert("name1") to indexes:insert("name2")

local sqlite = require "sqlite.db" --- for constructing sql databases
local uri = "Here your URI"

local BM = sqlite:extend {
    uri = uri,
    indexes = {
        id = true, -- same as { type = "integer", required = true, primary = true }
        name = { "text", required = true, unique = true }
    },
}

local indexes = BM.indexes

function indexes:insert(name)
    indexes:__insert { name = name }
end

indexes:insert("name1")

Actual behaviour
E5108: Error executing lua ...im/site/pack/packer/start/sqlite.lua/lua/sqlite/stmt.lua:57: sqlite.lua: couldn't finalize statement, ERRMSG: database is locked stmt = (insert into indexes (name) values(:name))
Expected behavior
The new raw has been successfully inserted

P.S sqlite.db:status() returns
{   code = 21,   msg = "bad parameter or other API misuse" }

Workaround
Close connection if the operation was failed
local success, result_or_error = pcall(function()  BM.indexes:__insert { name = "name6" } end)

if not success then
    BM:close()
    error(result_or_error)
end


Remove human-readable values from backend settings

Human-readable values are part of GUI so they should not be defined by backends.
Currently we have the following values:

accelerator_desc
configuration

https://github.com/mlcommons/mobile_app_open/blob/29cb9deb341709cee764325ea8e568ae0f8df892/flutter/cpp/proto/backend_setting.proto#L46-L49
We should create id → description map and only use ids in backend settings.

it seems moving all the mapping and name into a centralized list or map in high-level UI is no flexible. Let's close this for now.


IconButton is not theme-able and the default is off spec

Problem description
IconButton is not fully theme-able.
https://github.com/callemall/material-ui/blob/master/src/IconButton/IconButton.js#L19
The padding, width and height are hardcoded to baseTheme.spacing.iconSize * 2
Assuming a size 24px icon this makes IconButton 48x48 by default.
This is off Google Material Design spec, IconButtons should have a 24px icon with 8px padding, giving an IconButton size of 40x40.
Angular Material and Polymer are correctly set to 40x40. In general Polymer is generally closest to being on spec.
Steps to reproduce
Versions

Material-UI: 0.15.4
React: 15.3.0
Browser: n/a

@oliviertassinari can this be labelled as a Material Design spec issue?


compile source for local maven repository

For our development project, I am required to gather all third party source and build them.  Then host them on an internal maven repository for CM requirements.  I have built the jar file successfully and deployed it to the maven repository.  The issue is the timber dependency of piwik.  My project is crashing at run time due to the dependency.  The project compiles without errors. I have tried to add the timber jar to my project but I have been unable to get around the issue.  compile 'org.piwik.sdk:piwik-sdk:1.0.1' does not work if I deploy the aar to the local repository.  Attached it the crash log. Thanks in advance.
CRASH_2016_12_14_09_18_12.txt

I can see error java.lang.ClassNotFoundException: Didn't find class "timber.log.Timber"
@croniserb could you try to add compile 'com.jakewharton.timber:timber:4.1.2' or similar?

@dotsbb I tried https://github.com/JakeWharton/timber/releases the 4.1.2.  I have tried both the aar and the jar as I have done with piwik.  I have even tried to put them in a local libs directory instead of maven.  I still am getting the error that is attached.  It seems like the piwik dependency is not being picked up when I attempt to use it locally.  Thanks.

@croniserb If this is no longer a current topic, please close it. Preferably add your solutation if you solved it.

Stale.


Update the dynamic test name in the scheduled workflow

Current Behavior

The Scheduled Benchmark Tests workflow creates dynamic test names based on the configuration of the test. Current format is shown below.
https://github.com/layer5io/meshery-smp-action/blob/b999f0aec563c79590a640050e8d691315116582/.github/workflows/scheduled-benchmarks.yml#L59
So, a sample test name now is: istio-fortio-load-test.yaml
Desired Behavior

Remove the .yaml from the test name and only include the rest of the file name.

Contributor Guide

Possible solution: https://stackoverflow.com/questions/4168371/how-can-i-remove-all-text-after-a-character-in-bash

Please assign me this

Sure. Here you go.

Hey @varunsaral checking in if you're still working on this??

yes @piyushsingariya i'm working on it , we can connect on slack if you want to discuss about it.

Sure, I'm excited to see some work on this.

I will implement this in my PR about scheduled benchmark on self-hosted runner.

PR merged, close it.


Registry: add support for versioned ncbi_taxonomy DBs + improve support for versioned metadata DBs

Description
Extend the Registry so that it can detect taxonomy databases whose names contain the release number, with backward compatibility with unversioned databases but preference for versioned ones if both forms are present.
Additionally, add several bits of support for versioned metadata databases which failed to make it into #379.
Use case
Starting with release 100 taxonomy databases in Ensembl will have been renamed from ncbi_taxonomy to ncbi_taxonomy_XY, where XY is the release number.
Our support for versioned metadata databases has been incomplete: on the one hand we did not include them in version checks, on the other they were not filtered out by certain methods which did filter out unversioned DBs.
Benefits
Meet the requirements of ENSINT-312. Fewer bugs in support for versioned metadata DBs.
Possible Drawbacks
A slight increase in computational overhead in the Registry, primarily during initialisation. Note that much of this overhead stems from the fact we retain for the time being backward compatibility with the old naming convention, i.e. will eventually go away.
Testing
Have you added/modified unit tests to test the changes?
No, the affected code is tied with specific database names and as such will not trigger for MultiTestDB databases.
If so, do the tests pass/fail?
N/A
Have you run the entire test suite and no regression was detected?
Yes, no regression detected.

Coverage decreased (-0.02%) to 81.459% when pulling c7cfbe03bb81058ecd96fc29f0bf2c3c4cba17bc on feature/versioned_ncbi_taxonomy into 940e1fba8903dd4d89d9656deb0c090cd5e33ab5 on master.


Add "shares" settings for Proxmox hosts, helps with resource prioritisation

RAM-Ballooning and "shares" need to be applied to more hosts for Proxmox to actually prioritize important VMs properly.
Mainly this is needed as the MooseFS masters are being OOM'd when RAM on Proxmox is running low. They should be prioritised to be the last VMs that are stopped if RAM is running low as they provide an essential service (storage) to everything else we are running!
Here's the particular module/setting we'd need to apply:
https://docs.ansible.com/ansible/latest/collections/community/general/proxmox_kvm_module.html#parameter-shares

ChatGPT:

The 'shares' settings in Proxmox is a relative system that influences the distribution of resources when there is contention. If you have a high priority VM and you've set its shares to a higher number (like 5000), it means that VM should get a larger share of the available resources compared to other VMs with lower shares. But, this doesn't guarantee that the VM won't be stopped if memory gets critically low.
Shares need to be set on all VMs/containers that you want to prioritize. The default share value is 1024, and any VMs/containers that do not have a specific share value set will use this default. The higher the share value of a VM, the higher priority it has when resources are distributed.
However, shares don't prevent a VM from being killed when the system is out of memory (OOM). Shares just affect the distribution of resources, not the absolute amount of memory that a VM can use.
If a high priority host is still getting killed due to OOM conditions despite having higher shares, then this might indicate that there's not enough memory on the host machine to handle the workloads of all the VMs it's running.
In this case, you might need to add more physical memory to the host machine, reduce the memory allocated to other VMs, or move some VMs to another host to reduce the overall memory usage.
You could also look at the swap usage and consider increasing the swap space, but this should be a last resort because swap space is much slower than physical memory.
In addition, if you don't want a particular VM to be killed under any circumstances, you might want to look at the Linux kernel's OOM killer settings. Specifically, you can adjust the 'oom_score_adj' setting for the VM's process to make it less likely to be killed. However, be aware that this could potentially cause other processes to be killed instead.

Would there be any reasonable way to stop the kernel from OOM'ing these processes?

Yes, manually poking proc values is not that way. I'll think about it and
come up with something else. For now please don't do that... even if that
means evacuating nearly all machines off a Proxmox host to keep ram low
enough to avoid an OOM.
On Mon, May 15, 2023, 5:09 PM Michael @.***> wrote:

Would there be any reasonable way to stop the kernel from OOM'ing these
processes?
—
Reply to this email directly, view it on GitHub
https://github.com/application-research/ehi-proxmaas/issues/20#issuecomment-1547475043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKONLEHTDBKNPL4RG7DWPDXGHXDZANCNFSM6AAAAAAYBZTJLY
.
You are receiving this because you commented.Message ID:
@.***>


Appending to URL screws up the vue router

Because selecting a tab appends the element to the route, this screws up my whole routing system. I.e. my page is .../myPage and appending .../myPage#Tab1 doesnt exist so the whole thing breaks. This makes the component useless for my project.

Hello,
would you mind adding a code snippet, perhaps some screenshots of the expected behavior and the current behavior?
I've used the tabs component with Vue3 router on a couple of projects with no issues.

yes, I have the same problem.
One of my vue router's paths is /page1/page2/, where I use this Tabs component and I have two tabs here with "#new-customer" and "#existing customer" as the rendered "href" of each anchor element, so when landing on the first tab, the URL in the browser is https://www.mysite.com/page1/page2/ or https://www.mysite.com/page1/page2/#new-customer, they are all fine initially, but when I clicked on "Existing Customer" tab, it redirects to https://www.mysite.com/#new-customer, i.e, it 'ate' /page1/page2/ segments from the URL, where https://www.mysite.com/#new-customer is just my home page with non existed anchor #new-customer
So the issue is it doesn't pick up the relative URL segments /page1/page2/ when changing the urlFragment (#hash)

Hello,
this is odd behavior, as appending a hash to the URL is not handled by the package, but by the browser, as the href of a link element is targetting the specific tab.
That means it should not and cannot contain a full relative URL, as this is undesired an may have unknown sideffects (especially with vue-router).
Which browser are you using? This might be specific to a browser.

I'm using following workaround
Tabs mixin:
import {Tabs, Tab} from 'vue3-tabs-component';

export default {
    components: {
        Tabs,
        Tab
    },
    data()
    {
        return {
            selectedTab: 'tab-1'
        };
    },
    computed: {
        tabOptions()
        {
            return {
                useUrlFragment: false,
                defaultTabHash: this.selectedTab
            };
        }
    },
    watch: {
        $route: {
            immediate: true,
            handler()
            {
                this.setActiveTabFromRoute();
            }
        }
    },
    methods: {
        setActiveTabFromRoute()
        {
            const {$route} = this;
            if (!$route.query?.tab) { return; }
            this.selectedTab = $route.query.tab;

            if (!this.$refs.tabs) { return; }
            this.$refs.tabs.selectTab(`#${$route.query.tab}`);
        },
        tabChanged(selectedTab)
        {
            const {$route} = this;

            this.$router.replace({
                name: $route.name,
                params: $route.params,
                query: {tab: selectedTab.tab.computedId}
            });

            this.selectedTab = selectedTab.tab.computedId;
        }
    }
};

Template
<tabs
    ref="tabs"
    :cache-lifetime="-1"
    :options="tabOptions"
    @changed="tabChanged"
>
    <tab name="tab-1">
        Tab-1
    </tab>
    <tab name="Tab-2">
        Tab-2
    </tab>
</tabs>

This would be better if vue-tabs would work with v-models

The likely cause is the Vue router being use as hash mode.
The packages then are in conflict when using hashes, so I'd advise turning off using url fragment via the useUrlFragment option.


Refactoring: signing data using LocalKey

While integrating askar to aries-vcx, following pattern has appeared in our sign function implementation:
        if let Some(key) = self
            .session()
            .await?
            .fetch_key(&did_from_key(key.to_owned()), false)
            .await?
        {
            let local_key = key.load_local_key()?;
            let key_alg = SigType::try_from_key_alg(local_key.algorithm())?;
            Ok(local_key.sign_message(msg, Some(key_alg.into()))?)
        }

What happens here is:

We load up a key from database, this is of type LocalKey
Next we want to use it for signing, but for that, we need instance of SigType. We have to fallibly try to get that as key_alg from the local_key
Lastly, we pass in local_key and the key_alg to make magic happen

I find this un-intuitive that I need to use SigType::try_from_key_alg before I can use LocalKey's sign_message, even though the information about key type is in fact contained in local_key variable itself. Therefore I would rather welcome following API:
            let local_key = key.load_local_key()?;
            Ok(local_key.sign_message(msg?)

Such that sign_message would check the key type itself.
Additionally, the current API opens up doors to error where I load up local_key of certain cryptography type, but then pass wrong value of SigType argument to sign_message function.
I am open to make contribution, but before I proceed, is there's some perspective I am missing?

@andrewwhitehead — could you please weigh in here?

Hiya, I believe what you're doing is effectively the same as passing in None for the signature type. In that case the default signature type for that key is chosen.

@andrewwhitehead excuse the lack of my knowledge - you indicate that there might be keys which can be used for variaty of signature types. Is that right?

There are keys for which multiple signature types could be supported, for example EdDSA signatures can be deterministic or randomized: https://www.ietf.org/archive/id/draft-mattsson-cfrg-det-sigs-with-noise-04.html
At the moment none of the implemented key types support multiple signature types, though.


Update ECO1-1-1a.csv

@jyaruel You caught most of them but there is one last space (" complete") that is causing this test failure.


Add example of using doc.raw() without parameters

Feedback is welcome!

Hi, thanks for the PR. I will definitely merge it as we need more examples in docs. However, could you change one word in this commit?

You can use it to get a raw copy of the entire class document, or a copy of

I added a new commit as you said. I'm still new to git etiquette; should I instead start a new commit so that all of the PR's changes are in a single commit? Thanks!

I added a new commit. I'm still new to git etiquette; should I instead start a new commit so that all of the PR's changes are in a single commit? Thanks!

Yes right, it's just better to start a new PR with the final version :) so if it's not a problem for you, then please create a new one, thanks :)

Will do right now, thanks for letting me know!


Rename nEpochs to n_epochs in FineTuneRequest

Fixes #119 and adds its default value to the tests

Thank you!


Cannot build rosserial due to python installer

Steps to repro:
mkdir c:\ws\rosserial_ws\src
cd c:\ws\rosserial_ws\src
catkin_init_workspace
git checkout -b init_windows http://github.com/ms-iot/rosserial.git
cd ..
catkin_make install

Result
install TARGETS givn target "make_libraries.py_executable_install_python"
Cause
make_libraries.py exists in multiple directories.
workaround
echo > rosserial_XXX\CATKIN_IGNORE
Where XXX is what you don't want to build.

this duplicate-macro issue was hit because catkin_make treats all packages in the workspace like a single project
I will check if the macros could be renamed, that seems like the easiest way to resolve this

isn't the suggestion in the ROS Answers question you link to not to use catkin_make, specifically (but not exclusively) for the reported issue?

thanks for pointing this out! We are still considering a fix for this change because catkin_make would work in this case before this Windows-specific change, making this issue seemingly a regression; meantime, I think it could/might be a pretty simple fix.
as suggested in the linked question (thanks a lot for answering that!), we will be looking at catkin_make_isolated and/or colcon for our VS Code integration

I think it was @dirk-thomas who answered that specific question though.

I verified it is no longer repro, so I close it.

I verified it is no longer repro, so I close it.

this is fixed in https://github.com/ros/catkin/commit/3d4fa72a18c7faa061f431d7727c5a87ba1a5b33


azure - create_or_update_by_id VMs with User Assigned Identity throw errors

If you have a subscription that contains VMs with User Assigned Identity (MSI enabled) an error is thrown by the Azure SDK when calling create_or_update_by_id.
Example policy:
`policies:

name: vm-tagging-policy
resource: azure.vm
actions:

type: tag
tag: Test
value: FromCC`

Error:
2018-08-08 11:54:08,555: custodian.commands:ERROR Error while executing policy vm-tagging-policy, continuing Traceback (most recent call last):   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n/commands.py", line 227, in run     policy()   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n/policy.py", line 814, in __call__     resources = mode.run()   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n/policy.py", line 272, in run     results = a.process(resources)   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n_azure/actions.py", line 121, in process     list(w.map(self.process_resource, resources))   File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/concurrent/futures/_base.py", line 586, in result_iterator     yield fs.pop().result()   File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/concurrent/futures/_base.py", line 425, in result     return self.__get_result()   File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/concurrent/futures/_base.py", line 384, in __get_result     raise self._exception   File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/concurrent/futures/thread.py", line 57, in run     result = self.fn(*self.args, **self.kwargs)   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n_azure/actions.py", line 125, in process_resource     TagHelper.add_tags(self, resource, new_tags)   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n_azure/actions.py", line 76, in add_tags     TagHelper.update_resource_tags(tag_action, resource, tags)   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/c7n_azure/actions.py", line 59, in update_resource_tags     client.resources.create_or_update_by_id(resource['id'], api_version, az_resource)   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/azure/mgmt/resource/resources/v2018_05_01/operations/resources_operations.py", line 1094, in create_or_update_by_id     **operation_config   File "/Users/aaronschnieder/OneDrive - Microsoft/Source/custodian/lib/python3.7/site-packages/azure/mgmt/resource/resources/v2018_05_01/operations/resources_operations.py", line 1047, in _create_or_update_by_id_initial     raise exp msrestazure.azure_exceptions.CloudError: Azure Error: MissingIdentityIds Message: The identity ids must not be null or empty for 'UserAssigned' identity type.

Could be related to #2637

Fixed by #2727


[question] error message while finetuning

Dear all,
I ran finetuning and while validating, I encountered this error message:
iter 3198: loss nan, time: 123.08ms
Validating ...
.......
lit-llama/generate.py", line 74, in generate
idx_next = torch.multinomial(probs, num_samples=1).to(dtype=dtype)
RuntimeError: probability tensor contains either inf, nan or element < 0
Could you tell me how I can solve this problem?
Thanks in advance.

It may or may not be related, but are you using --precision 16-true? I noticed that for training some models it results in NaNs during training. If your GPU supports it, can you try brain float precision, i.e. --precision bf16-true?

No I did not use --precision 16-true.


Fix OCP command for 1.4.3

Description
This PR is fixing two problems discovered in version 1.4.3.

Adding indexer option to define if indexer should be used or not (default: false)
Setting correct metrics configuration file

Fixes
1. Local indexer
If we are using a local indexer, the problem is that the indexer instance will not be created, and kube-burner will panic.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x230f9b4]

goroutine 78 [running]:
github.com/cloud-bulldozer/kube-burner/pkg/burner.indexjobSummaryInfo(0x0, {0x7ff7bfeff635, 0x38}, 0x4040ede1d2178f69, {0x14, 0x0, 0x0, {0xc00057ced0, 0xf}, {0xc0003bc000, ...}, ...}, ...)
	/home/runner/work/kube-burner/kube-burner/pkg/burner/metadata.go:51 +0x214
github.com/cloud-bulldozer/kube-burner/pkg/burner.Run.func1()
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:168 +0x1449
created by github.com/cloud-bulldozer/kube-burner/pkg/burner.Run
	/home/runner/work/kube-burner/kube-burner/pkg/burner/job.go:87 +0x3ed

The reason for this problem is that usage of the indexer is determined by the existence of the Elastic endpoint option. And that option does not exist for local indexer.
The proposed solution is an independent command option that allows us to enable/disable the indexer per test execution.
2. Empty metrics profile
With some changes in 1.4.3, information about the default metrics profile is not propagated, and the metrics profile is always empty.
Added changes will propagate the metrics profile provided in a function call.

@rsevilla87 Tnx for taking the fix and merging it.
I have switched to the init command instead of ocp. It's possible to go around the problem for the local indexer by using trivial values --es-index=test --es-server=test - to pass the check for both options, and that indexing is enabled.
Both proposed solutions with new options additionally complicate the command. If we can come up with a generic clean solution, then we should implement it.
One idea I had was to have all options for indexerConfig filled. In example:
indexerConfig:
  enabled: {{.INDEXING}}
  type: {{.INDEXER_TYPE}}
  esServers: ["{{.ES_SERVER}}"]
  insecureSkipVerify: true
  defaultIndex: {{.ES_INDEX}}
  metricsDirectory: collected-metrics
  createTarball: true
  tarballName: collected-metrics.tar.gz

An to create a new option in the ocp command --indexer-type. By default, it will be elastic. Possible options could be:

elastic
local
none

For none - indexing is disabled.
In that case, you can directly run the ocp command with elastic/local/no-indexing without any modification on configuration.
If we are not sure about the solution yet, then we can open an issue in GitHub to keep track and have it documented if someone else encounters a similar issue. And then get to it when we have better ideas.

@mtodor , I just merged #278 that should address the issue you had with local-indexing with the OCP wrapper, let me know if it works for you, thanks!

@rsevilla87 Awesome work! I looked at PR, and it addresses the issue with the local indexer of ocp outlined here and beyond that. Tnx!
I have switched to using the init command. So, I'm not sure when and if I'll test it. But if you want to ensure that option works, you can add one test similar to what I have added in test/run-ocp.sh for this PR.
Thanks once again! I'll close this PR because all problems are addressed in other PRs.

@rsevilla87 Awesome work! I looked at PR, and it addresses the issue with the local indexer of ocp outlined here and beyond that. Tnx!
I have switched to using the init command. So, I'm not sure when and if I'll test it. But if you want to ensure that option works, you can add one test similar to what I have added in test/run-ocp.sh for this PR.
Thanks once again! I'll close this PR because all problems are addressed in other PRs.

Great!, glad it worked. I'm not updating the tests very much lately, the current test framework is not very reliable, it needs a full refactor as I noticed at https://github.com/cloud-bulldozer/kube-burner/issues/252
Anyhow, I'll take into account your test case once I start with this refactor.


quote strings that contain intentional trailing spaces

trailing spaces in unquoted strings are ignored

Thanks! I was wondering about that behavior when I wrote this.


Re-add the security page

It seems to have been accidentally dropped from SUMMARY.md here: https://github.com/feathersjs/feathers-docs/commit/3e1bb1e51cb07e6a8eb865cc73fd5479a6dc4457#diff-b4f3573b2f24d5af026c33acf52ff716L142
I added a summary to README.md as well.

Good catch, thank you!


The Theme editor panel cannot be resized

Godot 3.1.1
When you create a Theme resource from the inspector, the theme editor opens:

But it cannot be resized vertically. The handle doesn't react.
The only way I found so far is to collapse the theme editor by clicking on Theme at the bottom, and reopen it again. Note: when it reopen, it is also taller.
If you use the inspector arrows to go to the previously edited object, that makes the theme editor close, which is normal. But if you go back to the theme, it comes back into its "smaller" size and returns in its non-resizeable state.

That's fixed in the master branch:

Duplicate of #29056, fixed by @YeldhamDev in #29074.
The default height could likely be tweaked so that everything is visible by default though, providing it doesn't take up more than half the viewport height.


Eliminate SniHandler's direct dependency on SslContext.

Eliminate SniHandler's direct dependency on SslContext.
Motivation

See https://github.com/netty/netty/issues/4470

Modifications

Extracted a new SslHandlerFactory interface from SslContext (which implements it for backwards compatibility) and changed SniHandler's ctor to depend on Mapper<String, SslHandlerFactory> rather than DomainNameMapper<SslContext> which assumes that SNI is a non-dynamic lookup.

Result

The SniHandler no longer depends directly on SslContext nor assumes the mapping is a predefined list. It's now possible to load SslContext instances on-demand and also release any associated resources if a custom SslHandlerFactory is being used.

@normanmaurer: Here's some pseudo example code that shows the use-case for SslHandlerFactory that I was trying to describe in #4470.
In hindsight I wonder if a little refactoring of SniHandler wouldn't be more elegant.
class MySslHandlerFactory extends AbstractReferenceCounted implements SslHandlerFactory {

    private final OpenSslContext sslContext;

    public MySslHandlerFactory(OpenSslContext sslContext) {
      this.sslContext = sslContext;
    }

    @Override
    public SslContext sslContext() {
      return sslContext;
    }

    @Override
    public SslHandler newHandler(ByteBufAllocator alloc) {
      return sslContext.newHandler(alloc);
    }

    @Override
    protected void deallocate() {
      // OpenSslContext#destroy()
    }

    @Override
    public ReferenceCounted touch(Object hint) {
      return this;
    }
  }

  class MyMapper implements Mapper<String, SslHandlerFactory> {

    private final Map<String, SslHandlerFactory> cache = new HashMap<>();

    @Override
    public synchronized SslHandlerFactory map(String key) {
      SslHandlerFactory handlerFactory = cache.get(key);
      if (handlerFactory != null) {
        ReferenceCountUtil.retain(handlerFactory);
        return handlerFactory;
      }

      File keyCertChainFile = null;
      File keyFile = null;

      try {
        OpenSslContext sslContext = (OpenSslContext)SslContextBuilder
            .forServer(keyCertChainFile, keyFile)
            .sslProvider(SslProvider.OPENSSL)
            .build();

        MySslHandlerFactory myHandlerFactory
            = new MySslHandlerFactory(sslContext);

        cache.put(key, myHandlerFactory);
        return myHandlerFactory;

      } catch (SSLException err) {
        throw new IllegalStateException(err);
      }
    }
  }

  class MySniHandler extends SniHandler {

    private final Mapper<String, ? extends SslHandlerFactory> mapper;

    public MySniHandler(Mapper<String, ? extends SslHandlerFactory> mapper) {
      super(mapper);
      this.mapper = mapper;
    }

    @Override
    public void channelInactive(ChannelHandlerContext ctx) throws Exception {
      SslHandlerFactory handlerFactory = sslHandlerFactory();

      if (handlerFactory != null) {
        synchronized (mapper) {
          ReferenceCountUtil.release(handlerFactory);
        }
      }

      super.channelInactive(ctx);
    }
  }

@trustin WDYT ?

also @Scottmitch

If what you desire is to create SslContext lazily, you could:

Make SniHandler accept both Mapping<String, ? extends SslContext> instead of DomainMapping
Write ReferenceCountedSslContext which extends SslContext and wraps an existing SslContext implementation to do reference counting.

Please feel free to let me know if my suggestion doesn't work for you.

@trustin That works if extending and wrapping SslContext is an alright thing to do. It just feels a bit wrong (but possibly not any better than a mapper of factories).

@rkapsi Your Mapping implementation serves as a factory of SslContext and theSslContext created by your Mapping is reference-counted for timely destruction. I see no design issue here, in my opinion.
Let me send a PR for this soon.

Superseded by #4580


[docs][material-ui][Autocomplete] Improve filterOptions function

[x] I have followed (at least) the PR section of the contributing guide.

I tried with the new changes. It doesn't work as expected. I'll close the PR.

Sorry I forget the .length on the filtered, can you add this and try please?
I don't know why the previous code filters twice, it results to problems and is more complicated to use.

I fixed the code, which you can verify in the previous commits or by checking the updated PR. However, it's still not functioning as expected. It should still be added at the end.
For example, in Material UI, the autocomplete filterOptions appear like this:

In the deploy preview of this PR, it looks like this:

Hi, but then the logic in the existing code does not work for some reason.
You also only adding the "Add" entry when there is no existing match. But still, it will always be added.
See the existing code:
 const isExisting = options.some((option) => inputValue === option.title);
        if (inputValue !== '' && !isExisting)

I still do the same.
So you could either remove the if statement completely, so it will always be added and then we dont need to check for an existing match or it is now the new behavoir that you can only add new stuff if the input doesnt match anything.

Hi, but then the logic in the existing code does not work for some reason. Reading the could it should only add the "Add" entry when there is no existing match. But still, it will always be added.

The current code adds the "Add" entry whenever there's no exact match between the input value and the filtered option, but it shouldn't always do so.

I still do the same.

In your PR, it only adds "Add" if there's no filtered option, which is slightly different.

So you could either remove the if statement completely, so it will always be added and then we dont need to check for an existing match or it is now the new behavoir that you can only add new stuff if the input doesnt match anything.

We need to clarify the correct behavior, but I prefer not to alter the existing production behavior for now.


Fix #708 - Allow multiple includes of a template that embeds another …

Multiple template includes that embed other template breaks the compilation.
This PR is basically @JamesB797 's fix.
Issue: https://github.com/twigjs/twig.js/issues/708

I can confirm this fixes my issues with the file.includes errors :+1:

Can also confirm this solved the issue on my projects (as a patch).

Any chance we can get this merged? The patch is working for me and is pretty key for us - thanks in advance!

This still needs to be reviewed fully. However, after a cursory review, there is a good chance it will not get merged since it does not include tests and does not seem to address the actual underlying issues. The reported issue #708 is marked as high priority though and I was able to triage the actual issue, so it will most likely be put on the next milestone.
This PR will be left open for now, for reference at the very least, but may be superseded by another PR if the fix in this one proves insufficient.

Tested, and worked, does need test implementation however. Thanks for the thoughts, @willrowe

I took a closer look at this and think I have gotten to the bottom of what is happening. I should have some test cases ready for this soon.

Wooo! Nice work debugging 👍 Some initial insight?

Closing this in favor of #828 since that prevents any conflicts by avoiding storing the template instance in the registry at all.


Refactor Person to Student

@AY2324S2-CS2103T-W12-2/developers This refactor needs you to replace the untracked seed data taken from AB3. Please replace data/addressbook.json with the attached file.
addressbook.json


fix: skip processing after finding 1st legacy COJ

If the legacy Programme Membership data is structured incorrectly, i.e. as two PMs instead of one with multiple curricula, it is possible for a valid COJ to not be copied over to the new UUID PM. This occurs when the first returned PM has a COJ but subsequent matching PMs do not, the later null values overwrite the originally assigned COJ.
Add a null check and a break to ensure that we only set COJ values that are non-null and exit the loop early if we've found a COJ already.
TIS21-2399

Quality gate failed on formatting of a comment... I think I'll merge anyway,