[webview_flutter] WebView widget by default puts scrollbar position to left in Android

Steps to Reproduce

Open page with WebView in Android

Target Platform: Android
Target OS version/browser: 9.0-10.0
Devices: Huawei Honor 9 Lite, any android emulator

This problem hasn't occurred at iOS platform.
I tried to solve this problem by adding a line of code to the FlutterWebView class:
webView.setVerticalScrollbarPosition(View.SCROLLBAR_POSITION_LEFT);

I think something wrong with default scrollbar position value View.SCROLLBAR_POSITION_DEFAULT.
Logs

[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G84, locale ru-RU)
    • Flutter version 1.12.13+hotfix.5 at /Users/iosdev/Desktop/Dev/flutter
    • Framework revision 27321ebbad (8 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/iosdev/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.7.5

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

• No issues found!

Hi @chosti34
I cannot reproduce the behaviour you are describing

code sample
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatelessWidget {

  static Future<String> get _url async {
    await Future.delayed(Duration(seconds: 1));
    return 'https://flutter.dev/';
  }

  @override
  Widget build(BuildContext context) => Scaffold(
    body: Center(
      child:FutureBuilder(
        future: _url,
        builder: (BuildContext context, AsyncSnapshot snapshot) => snapshot.hasData
        ? WebViewWidget(url: snapshot.data,)
        : CircularProgressIndicator()),
  ),);
}

class WebViewWidget extends StatefulWidget {
  final String url;
  WebViewWidget({this.url});

  @override
  _WebViewWidget createState() => _WebViewWidget();
}

class _WebViewWidget extends State<WebViewWidget> {
  WebView _webView;
  @override
  void initState() {
    super.initState();
     _webView = WebView(
      initialUrl: widget.url,
      javascriptMode: JavascriptMode.unrestricted,
    );
  }

  @override
  void dispose() {
    super.dispose();
    _webView = null;
  }

  @override
  Widget build(BuildContext context) => _webView;
}

video
flutter doctor -v
[√] Flutter (Channel beta, v1.12.13+hotfix.6, on Microsoft Windows [Version 10.0.19013.1122], locale en-US)
    • Flutter version 1.12.13+hotfix.6 at C:\src\flutter
    • Framework revision 18cd7a3601 (8 days ago), 2019-12-11 06:35:39 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\iapic\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code, 64-bit edition (version 1.41.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.7.1

[√] Connected device (3 available)
    • Pixel 3a   • 965AY0WP5C • android-arm64  • Android 10 (API 29)
    • Chrome     • chrome     • web-javascript • Google Chrome 79.0.3945.88
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

C:\Users\iapic>

can you please provide a minimal code sample
or the steps to reproduce the problem?
Thank you

Thanks for the reply. I created empty project and pasted your code - scrollbar is at right position. My project just have button, with onPressed property which navigates to stateful widget with WebView by MaterialPageRoute. Can something be wrong with my android project properties?

Hi @chosti34
would you mind  sharing a minimal code sample to reproduce the problem.
Thank you

Page where navigation occurs
...

_privacyPolicyTapRecognizer = TapGestureRecognizer()
      ..onTap = () {
        Navigator.push(
          context,
          MaterialPageRoute(
            builder: (context) => WebViewPage(
              url: appModel.appSettings.pages.privacyPolicy,
            ),
          ),
        );
      };

    _termsOfUseTapRecognizer = TapGestureRecognizer()
      ..onTap = () {
        Navigator.push(
          context,
          MaterialPageRoute(
            builder: (context) => WebViewPage(
              url: appModel.appSettings.pages.termsOfUse,
            ),
          ),
        );
      };

...

web_view_page.dart
import 'package:webview_flutter/webview_flutter.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'dart:async';

class WebViewPage extends StatefulWidget {
  final String url;

  WebViewPage({Key key, this.url})
    : super(key: key);

  @override
  _WebViewPageState createState() => _WebViewPageState();
}

class _WebViewPageState extends State<WebViewPage> {
  final Completer<WebViewController> _controller = Completer<WebViewController>();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: WebView(
        initialUrl: widget.url,
        javascriptMode: JavascriptMode.unrestricted,
        onWebViewCreated: (WebViewController webViewController) {
          _controller.complete(webViewController);
        }
      ),
    );
  }
}

I found that the problem occurs only when I use flutter_facebook_login plugin in my pubspec.yaml

The issue occurs for me as well.

[√] Flutter (Channel beta, v1.14.6, on Microsoft Windows [Version 10.0.17763.1039], locale en-US)
    • Flutter version 1.14.6 at D:\Development\flutter-sdk
    • Framework revision fabeb2a16f (4 weeks ago), 2020-01-28 07:56:51 -0800
    • Engine revision c4229bfbba
    • Dart version 2.8.0 (build 2.8.0-dev.5.0 fc3af737c7)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at D:\Development\android-sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = D:\Development\android-sdk
    • Java binary at: C:\Program Files\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android Studio
    • Flutter plugin version 43.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] Connected device (4 available)
    • ONEPLUS A6013             • 26bd994b      • android-arm64  • Android 10 (API 29)
    • Android SDK built for x86 • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Chrome                    • chrome        • web-javascript • Google Chrome 79.0.3945.130
    • Web Server                • web-server    • web-javascript • Flutter Tools

The behavior happens on the simulator and also the OnePlus test phone.
This happens with just the default Webview.
                WebView(
                  initialUrl: "https://bing.com",
                )

Hi @chosti34, I tried to replicate your issue on latest Flutter dev channel (1.20.0-0.0.pre) and with latest version of webview_flutter plugin, but I was not able to replicate it. I added flutter_facebook_plugin in pubspec.yaml per your comment, but still couldn't replicate the issue.   I tested it on Android emulator.

code sample
import 'package:flutter/material.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
     // showPerformanceOverlay: true,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
        home: BasePage());
   // );
  }
}

class WebViewPage extends StatefulWidget {
  final String url;

  WebViewPage({Key key, this.url})
      : super(key: key);

  @override
  _WebViewPageState createState() => _WebViewPageState();
}

class _WebViewPageState extends State<WebViewPage> {
  final Completer<WebViewController> _controller = Completer<WebViewController>();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: WebView(
          initialUrl: widget.url,
          javascriptMode: JavascriptMode.unrestricted,
          onWebViewCreated: (WebViewController webViewController) {
            _controller.complete(webViewController);
          }
      ),
    );
  }
}

class BasePage extends StatefulWidget {
  BasePage({Key key}) : super(key: key);

  @override
  _BasePageState createState() => _BasePageState();
}

class _BasePageState extends State<BasePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Center(
          child: Column(
            children: [
              RaisedButton(
                child: Text('Tap'),
                onPressed: () {
                  Navigator.push(
                      context,
                      MaterialPageRoute(
                        builder: (context) => WebViewPage(
                          url: 'https://en.wikipedia.org/wiki/Kraken',
                        ),
                      ));
                },
              ),
              RaisedButton(
                child: Text('Tap'),
                onPressed: () {
                  Navigator.push(
                      context,
                      MaterialPageRoute(
                        builder: (context) => WebViewPage(
                          url: 'https://en.wikipedia.org/wiki/Kraken',
                        ),
                      ));
                },
              ),
            ],
          )
        )
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.2 19C57, locale en-US)
    • Flutter version 1.20.0-0.0.pre at /Users/deeptibelsare/Documents/Fluttersdk/flutter
    • Framework revision d9653445f4 (8 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/deeptibelsare/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/deeptibelsare/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/deeptibelsare/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.9.3

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

Can you please confirm if you are still experiencing this issue by upgrading Flutter and webview_flutter plugin ?

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

I found above issue is related to this. https://github.com/flutter/flutter/issues/66208


Jobber.exe makes trouble with virus scanner F-Secure

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
OS Version: Windows_NT ia32 6.3.9600
Extensions:

Extension
Author (truncated)
Version

project-manager
ale
0.18.1

githistory
don
0.2.2

gitlens
eam
4.3.2

rest-client
hum
0.14.6

Steps to Reproduce:

I updated VScode to the current version

I restarted the app for the changes take effect and get the following F-Secure warning:
PotentiallyUnwanted:W32/App.0750e025c8!Online,
<me>.vscode\extensions\eamodio.gitlens-4.3.2\node_modules\spawn-rx\vendor\jobber\Jobber.exe

I disabled scanning for this file (created exception)

Reproduces without extensions: Yes/No
Sorry, didn't check without extensions (gitlens), since I'm  working with git.
I suppose the file properties and/or  the lack of digital signature  might be a source of this trouble.
Try code signing it.

Please file this in the appropriate extension repository: https://github.com/eamodio/vscode-gitlens/issues

This issue was moved to eamodio/vscode-gitlens#123

Done so far.
I couldn't find any built in functionality for moving issues at your
repo . Is there anything available that  I've overlooked?
I used the online mover from:
https://github-issue-mover.appspot.com/
Mit freundlichen Grüßen , with best regards,
Hans-Jürgen Reindt.
Am 27.07.2017 um 21:57 schrieb João Moreno:

Please file this in the appropriate extension repository:
https://github.com/eamodio/vscode-gitlens/issues
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/31539#issuecomment-318469424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdFOQ9qbqzNXZyGmw7aiX3KkGKDdswRLks5sSOvDgaJpZM4OlBZz.


Typo in Top Level Statements tutorial

Under the "Respond with a random answer" section, it says "This array has 12 answers that are affirmative, six that are non-committal, and six that are negative" but the counts are actually 11, 5, and 5, respectively.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af2939b6-ad9e-4116-c805-8f19ed994c31
Version Independent ID: ad23d124-a491-2b4f-3c51-0ed5d38d7eba
Content: Top-level statements - C# tutorial
Content Source: docs/csharp/whats-new/tutorials/top-level-statements.md
Product: dotnet-csharp
Technology: csharp-whats-new
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for noting this @johnradke
I see @pkulikov has already submitted a fix.  I'll review that and merge it shortly.
In the future, if you find these quick fixes, you can click the "edit" button (it looks like a pencil), and submit a PR with the fix. That may be quicker than describing where the typo is.
Thanks again.


Tests should have file_path as TestFiles

SAVE operates with test resources as collections of arbitrary size. We should respect this in save-cloud and also take all files into account when calculating hash

Newer versions of SAVE have TestFiles for this purpose

@nulls pls check this one - probably it is already done

No, it didn't done.
Overview: Save create Test in database and store hash of a file content. We have tests with 2 files (expected as additional file). As I got, we need to add this file to calculation of hash code

we need to add this file to calculation of hash code

Yes, and also we may want to display these additional files on the frontend and so we may need to store them in the database.


Add table of contents to the style guide

Added an index section to the style guide.

I signed it!

@devsoitic08 Could you merge this PR?

This is great, but I'm afraid it will quickly become out-of-sync with the Google internal version, in which the table of contents is automatically generated via the [TOC] markup. Is there no way to auto-generate this in GitHub flavored markdown?

@cgay Agree that this would be fragile and also hard to main. Unfortunately, there appears to be no way that this can be autogenerated as of now. Another alternative is if to add an automated test that checks if TOC is intact with the body of the doc (but I think it is fragile too)?

https://help.github.com/en/github/building-a-strong-community/editing-wiki-content

For security and performance reasons, some syntaxes are unsupported.

Transclusion
Definition lists
Indentation
Table of contents

https://github.com/isaacs/github/issues/215

Thanks for your pull request!
The latest iteration of the style guide has a TOC (albeit manually generated and maintained).


ACC missing TCP Profile values after conversion

Is your feature request related to a problem? Please describe.
When I am converting configuration to AS3 declaration, I noticed that some elements are not supported by ACC Converter, like TCP Profiles inside virtual server configuration (tcp-f5-wan and tcp-f5-lan)
Original app.conf :
ltm virtual /Common/vs_http {
    destination /Common/<IP_ADDRESS>:80
    ip-protocol tcp
    mask <IP_ADDRESS>
    pool /Common/pool_http
    profiles {
        /Common/f5-tcp-lan {
            context serverside
        }
        /Common/f5-tcp-wan {
            context clientside
        }
        /Common/http { }
    }
    source <IP_ADDRESS>/0
    translate-address enabled
    translate-port enabled
    vlans {
        /Common/internal
    }
    vlans-enabled
}

AS3 Converted Declaration :
    "declaration": {
        "class": "ADC",
        "schemaVersion": "3.35.0",
        "id": "urn:uuid:c669cbf9-bcab-402d-8a16-6db7c2778de2",
        "label": "Converted Declaration",
        "remark": "Generated by Automation Config Converter",
        "Common": {
            "class": "Tenant",
            "Shared": {
                "class": "Application",
                "template": "shared",
                "vs_http": {
                    "layer4": "tcp",
                    "pool": "pool_http",
                    "translateServerAddress": true,
                    "translateServerPort": true,
                    "class": "Service_HTTP",
                    "profileHTTP": {
                        "bigip": "/Common/http"
                    },
                    "virtualAddresses": [
                        "<IP_ADDRESS>"
                    ],
                    "virtualPort": 80,
                    "snat": "none",
                    "allowVlans": [
                        {
                            "bigip": "/Common/internal"
                        }
                    ]
                },

Describe the solution you'd like
I would like to obtain the AS3 declaration including all inputs elements like the TCP Profiles

Looks like a bug:
2022-05-03 13:48:07 WARN Invalid reference dropped: /Common/f5-tcp-lan
2022-05-03 13:48:07 WARN Invalid reference dropped: /Common/f5-tcp-wan
Will investigate that.

Fixed in 1.21

Thanks for your help


STM32H7 Zephyr CAN Driver

Hello everyone,
I currently started with the STM32H747I_disco and CAN. The CAN implementation looks like this:
fdcan1: can@4000a000 {
compatible = "st,stm32h7-fdcan";
reg = <0x4000a000 0x400>, <0x4000ac00 0x350>;
reg-names = "m_can", "message_ram";
clocks = <&rcc STM32_CLOCK_BUS_APB1_2 0x00000100>;
interrupts = <19 0>, <21 0>, <63 0>;
interrupt-names = "LINE_0", "LINE_1", "CALIB";
bosch,mram-cfg = <0x0 28 8 3 3 0 3 3>;
sample-point = <875>;
sample-point-data = <875>;
status = "disabled";
};
I added following devicetree overlay file:
/ {
chosen {
zephyr,console = &arduino_serial;
zephyr,canbus = &fdcan1;
};
can_phy2: can-phy2 {
compatible = "can-transceiver-gpio";
enable-gpios = <&gpiob 8 GPIO_ACTIVE_LOW>;
standby-gpios = <&gpiob 9 GPIO_ACTIVE_HIGH>;
max-bitrate = <8000000>;
#phy-cells = <0>;
};
};
&fdcan1 {
compatible = "st,stm32h7-fdcan";
bus-speed = <125000>;
bus-speed-data = <1000000>;
status = "okay";
phys = <&can_phy2>;
};
void CAN_init(void) { 	can_dev = DEVICE_DT_GET(DT_CHOSEN(zephyr_canbus)); 	if (!device_is_ready(can_dev)) { 		printk("CAN: Device driver not ready.\n"); 		return 0; 	} }
The debug terminal sends a error message:
"can_stm32h7: CAN pinctrl setup failed (-2)"
I want to use the onboard CAN drivers but there isn't a native pinctrl configuration available in the YAML file. Some users have used different drivers like SPI to communicate with a external CAN driver this is not what I want. Am I getting something fundamentally wrong? Is it possible to use STM32 native CAN drivers with Zephyr. I could switch back to the STM32 hal drivers, but I'd rather not.
Informations:
STM32H747i_DISCOVERY
Zephyr 3.5.99
Zephyr SDK 0.16.5
commit: 023d4838fbb8513f9d9ff6f26b065591131c347d
I'm compiling and running the project on the M4 chip.
I hope this information is sufficient to get ahead. Its my first post and I'd really like to get in touch with the community.
Best regards

"can_stm32h7: CAN pinctrl setup failed (-2)"

Everything in your DTS snippets above look fine, except that you're missing a pinctrl configuration in &fdcan1 { ... } (and you shouldn't override compatible there). Try something like the following, replacing the pinctrl pins with the actual pins routed to your CAN transceiver:
&fdcan1 {
        pinctrl-0 = <&fdcan1_rx_pb8 &fdcan1_tx_ph13>;
        pinctrl-names = "default";
        bus-speed = <125000>;
        bus-speed-data = <1000000>;
        status = "okay";
        phys = <&can_phy2>;
};

Current main (and the upcoming Zephyr v3.6.0) furthermore supports specifying the domain clock for FDCAN, a feature you may or may not need depending on your board clock configuration. See commit bc69500b0e101087d5c9f7261c2e729882aee88a for further details.

Am I getting something fundamentally wrong? Is it possible to use STM32 native CAN drivers with Zephyr. I could switch back to the STM32 hal drivers, but I'd rather not.

It is definitely possible, yes. I am using the FDCAN drivers for the STM32H7 myself.


HMTL

#HTML
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
##Accepted Criteria
Give a prework study guide website,
when I visit the website in my browser,
Then I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

#CSS
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
##Accepted Criteria
Give a prework study guide website,
when I view the study guide
Then I see a dark blue header and footer, and four boxes with shadow

#JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
##Accepted Criteria
Give a prework study guide website,
when I view the guide,
Then I can see the four topics I earned listed along with a suggestion on what I should study first

#README
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
##Accepted Criteria
Give the work project repository
when I view the read me for the repository,
Then I can see professional README that provides information on the project and how to use it

#Deployment
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
##Accepted Criteria
Give a prework study guide website,
when I visit the website using URL,
Then I can access my website from any browser


Create new accounts for Jitbit

Environment details
Application Name
jitbit

Description of application
Jitbit is a ticketing system that probation staff use to log incidents in frontline operations

GitHub team slug

https://github.com/orgs/ministryofjustice/teams/hmpps-migration
Environments

Environment
Access level

[x] Development
[ ] view-only[ ] developer[x] sandbox

[ ] Test
[ ] view-only[ ] developer

[x] Preproduction
[ ] view-only[x] developer

[x] Production
[ ] view-only[x] developer

Tags

tag
value

application
delius-jitbit

business-unit
HMPPS

owner
<EMAIL_ADDRESS>

HMPPS
Networking options
Subnet sets

[ ] General - this application will use the same subnet as other applications in your business unit
[ ] Isolated - this application has highly sensitive data which must have its own isolated subnet with no network connectivity

How do users connect to the application?

[ ] Over the public internet
[ ] With a purple cabled device (please give details)
[x] With a MoJ Official device

Connectivity to other applications or external parties

Additional features

[ ] Additional VPC Endpoints
[ ] Extended DNS Zones
[ ] Other - please specify

Other information

Definition of done

[ ] account created
[ ] customer informed

General subnet set should apply here
For additional features we will need connectivity to workmail

Original PR: https://github.com/ministryofjustice/modernisation-platform/pull/2745
Auto-generated and updated PRs:
https://github.com/ministryofjustice/modernisation-platform/pull/2746
https://github.com/ministryofjustice/modernisation-platform-environments/pull/1126

Documentation improvements:
https://github.com/ministryofjustice/modernisation-platform/pull/2747

Manually run the RAM share (due to issue we had in the pipeline worfklow):
aws-vault exec mp-admin -- scripts/member-account-ram-association.sh delius-jitbit preproduction
aws-vault exec mp-admin -- scripts/member-account-ram-association.sh delius-jitbit production```

Verified that the accounts have been created and that the subnets exist inside those accounts.

Re-opening, as must inform the customer first.

I informed the Delius Threelius gang, but no news, which I treat as a good news. Closing this ticket.


Adds a green circle as radio-range visualization of the selected node

Contribution description
The green circle around the selected node help placing it at a reachable distance from another device in the simulation.
Code impact
No significant impact.
Testing procedure
Same installation process as the original OTNS.

Codecov Report

Merging #268 (77263db) into main (8b7655f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   49.93%   49.93%
=======================================
  Files          38       38
  Lines        4604     4608    +4
=======================================
+ Hits         2299     2301    +2
- Misses       2123     2125    +2
  Partials      182      182

Impacted Files
Coverage Δ

web/site/bindata.go
99.00% <ø> (+<0.01%)
:arrow_up:

web/web.go
47.61% <0.00%> (-3.18%)
:arrow_down:


Improve ContextMenuItem tag semantics

Fixes #430
This PR updates the HTML structure of ContextMenuItem instances in the following ways:

improves tag semantics and accessibility:

outer item is now a <button> if applicable
icon image is represented by with picture element (with decorative null alt tag)

cleans up CSS selectors:

.disabled class is replaced with disabled attribute
classes are also represented with their semantic element if they have one

Organizes content: icon & text are placed together in enclosing <div>
Fixes #430: menu items now span the full width of the encapsulating menu, and follow a flex layout with justify-content: space-between

Should be all good. Extended tests and took care of styling issues.

Hey, not sure if this is done. But I noticed the font isn't working for me.

But I noticed the font isn't working for me.

Should be all good now. Accidentally referenced font-family var with too many hyphens :/


Switch from toml to tomli for TOML v1 compat

Closes https://github.com/nbQA-dev/nbQA/issues/621

awesome, thanks! there's a docs failure, don't know if it's related, I'll take a look later

:+1: Seems unrelated as master branch was failing too. I fixed it by upper pinning Sphinx

cool, thanks!

@all-contributors add @hukkin  for maintenance


wip: chore(libsinsp): remove unused container manager method

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?
No

What this PR does / why we need it:
Cleanup.
Groundwork for https://github.com/falcosecurity/falco/issues/3279
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

Abandoned in favor of https://github.com/falcosecurity/libs/pull/2141
/close

@leogr: Closed this PR.

In response to this:

Abandoned in favor of https://github.com/falcosecurity/libs/pull/2141
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


add --remove-hashtags option

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
People often add hashtags to their video titles, e.g. on YouTube shorts (but not only there).
I'm usually using this pattern for the output filename:
--output "%(upload_date)s %(title)s %(resolution)s %(id)s.%(ext)s"
I'd like to have an option to remove these redundant words completely from the title. But not in the same way as --restrict-filenames which would only remove the hash character but keep the word after it. My idea is to remove everything from the hash character to the next whitespace.
I'm aware that this would create a problem when the title consists of hashtags only. And so far, I have no idea what to do in this case. Maybe that could be discussed here.
I'm unsure how the output of a verbose  / debug run of the program helps in this case, so I omitted it.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

--replace-in-metadata title "#" ""

Not sure if this is what I need ... I don't want only the # to disappear, but #everything #that #starts #with #a #hash

Oh, that's cool. I just did not get that from that chapter.


potentially infinite async operation check during create_vm

has been going on for ~1hr. using v13 cpi. in create_vm action. since cpi doesnt log to disk we dont have beginning of the log.
D, [2016-07-06T01:08:17.689882 #14330] DEBUG -- : check_completion - InProgress...
D, [2016-07-06T01:08:22.690233 #14330] DEBUG -- : check_completion - trying to get the status of asynchronous operation: https://management.azure.com/subscriptions/xxxxx/providers/Microsoft.Compute/locations/westus/operations/c34f01f8-fbb8-48eb-8b87-95cfbaf8f767?api-version=2015-05-01-preview
D, [2016-07-06T01:08:22.750106 #14330] DEBUG -- : http_get_response - 0: 200, request id: 59732164-2bec-4597-ae7b-fb1afef28111, correlation id: c3b13834-5425-4c61-97cc-81e5d2b1f9b9, routing id: WESTUS:20160706T010822Z:c3b13834-5425-4c61-97cc-81e5d2b1f9b9, responsey.body: {
  "operationId": "c34f01f8-fbb8-48eb-8b87-95cfbaf8f767",
  "startTime": "2016-07-06T00:43:06.5327115+00:00",
  "status": "InProgress"
}
D, [2016-07-06T01:08:22.750413 #14330] DEBUG -- : check_completion - InProgress...
D, [2016-07-06T01:08:27.750725 #14330] DEBUG -- : check_completion - trying to get the status of asynchronous operation: https://management.azure.com/subscriptions/xxxxx/providers/Microsoft.Compute/locations/westus/operations/c34f01f8-fbb8-48eb-8b87-95cfbaf8f767?api-version=2015-05-01-preview
D, [2016-07-06T01:08:27.856842 #14330] DEBUG -- : http_get_response - 0: 200, request id: 3a50695f-c7eb-4930-af2b-69a18b754822, correlation id: 56db0dfa-398f-485c-901e-c43ceba4d3f8, routing id: WESTUS:20160706T010827Z:56db0dfa-398f-485c-901e-c43ceba4d3f8, responsey.body: {
  "operationId": "c34f01f8-fbb8-48eb-8b87-95cfbaf8f767",
  "startTime": "2016-07-06T00:43:06.5327115+00:00",
  "status": "InProgress"
}

cc @cppforlife

@degaurab
Thanks for your report.
Which version of stemcell do you use?

@degaurab Do you try stemcell v3262.2? I think this issue was caused by v3262.

@degaurab Please reactive it if you still have this issue.


How can I configure to upload only separate directory to the server public_html

I have a Nuxt.js project and I want to upload only one directory dist/ files to the server public_html/. Now when I perform upload I receive dist/ folder, but I want to upload files from this folder to the document root.
How can I do that?

content: "dist", remotePath: "/path/to/public_html"
On Sat, May 11, 2019 at 7:24 PM Dmytro Zarezenko<EMAIL_ADDRESS>wrote:

I have a Nuxt.js project and want to upload only one directory dist/
files to the server public_html/. Now when I perform upload I receive
dist/ folder, but I want to upload files from this folder to the document
root.
How can I do that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/liximomo/vscode-sftp/issues/554, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACK4RIK6KEZB5WBEKJ76GIDPU2UIVANCNFSM4HMH5B5A
.

--
、什么样心情

@liximomo Thank you for the answer, but I have tried this way. When I select "upload" on the dist/ folder it perform upload to the dist/ on the server as well, not to the document root.

You want to upload from local __ to remote  __ ?  Fill with paths.

I want upload all files from my project dist/ folder to the remote "remotePath": "/var/www/.../public_html/" folder when I select upload menu item in the context menu.

{
 "context": "dist",
 "remotePath": "/var/www/.../public_html/"
}

@liximomo looks like it uploads dist folder content to the /var/www/.../public_html/dist folder with this configuration


Uiauto2 - Fixes

Can confirm that on my Huawei Mate 9 - Android N device, this has resolved the problem I had being unable to run applaunch before. Thanks!


Remove analyze_branch and BranchInfo

We don't have overlap in behavior for branch instructions anymore, so we can remove analyze_branch and instead match on the InstructionData directly.

I wonder how many of these former uses of analyze_branch could be replaced with calls to visit_block_succs? I'm pretty sure at least the ones in dominator_tree.rs and flowgraph.rs could be.

That would be a nice refactoring!

Just so we're clear: I did push the "approve" button, with or without that hypothetical refactoring. :grin:

Exception handling may introduce a new instruction with semantics identical to br_table with respect to determining successors. analyze_branch would still be useful for that. In addition when a new kind of branch instruction is added, this PR causes there to no longer be a compile error or runtime error when a match is missed. Previously forgetting to add it to analyze_branch would trigger the !is_branch assertion and if a new BranchInfo variant was added you did get a compile error.

Maybe the visit_block_succs refactoring could be done and the remaining cases could get the !is_branch assertion added back?

Exception handling may introduce a new instruction with semantics identical to br_table with respect to determining successors. analyze_branch would still be useful for that.

Would that have turned into a return value of BranchInfo::Table in analyze_branch? If so, you would still have needed to re-match the opcode to apply special behavior for your new instruction.

In addition when a new kind of branch instruction is added, this PR causes there to no longer be a compile error or runtime error when a match is missed. Previously forgetting to add it to analyze_branch would trigger the !is_branch assertion and if a new BranchInfo variant was added you did get a compile error.

This is true, however my hope was that we've now arrived at the necessary set of branch instructions and won't need to add any others. We have unconditional jump, conditional branch, and branch through table instructions, which feel like the right building blocks for more complicated control flow. I think the switch module in cranelift-frontend is a great example of this.

Would that have turned into a return value of BranchInfo::Table in analyze_branch?

Yes

If so, you would still have needed to re-match the opcode to apply special behavior for your new instruction.

Yeah, in some cases that is indeed necessary. In other cases it doesn't actually care about which exact branch instruction is used. Just which successors exist.

This is true, however my hope was that we've now arrived at the necessary set of branch instructions and won't need to add any others. We have unconditional jump, conditional branch, and branch through table instructions, which feel like the right building blocks for more complicated control flow. I think the switch module in cranelift-frontend is a great example of this.

I see. For exceptions I am pretty sure we will need an invoke/invoke_indirect instruction to be able to define the unwinding path that a call will take. From the clif ir perspective this will be a branch instruction which branches when an exception happens. I don't think this is implementable without support from cranelift-codegen.

+1 to invoke-family instructions: fundamentally we can't represent the zero-cost exception model without it, I think, because the unwinder is external and effectively jumps to a different return address.

I see. For exceptions I am pretty sure we will need an invoke/invoke_indirect instruction to be able to define the unwinding path that a call will take. From the clif ir perspective this will be a branch instruction which branches when an exception happens. I don't think this is implementable without support from cranelift-codegen.

I'll make a PR that both implements @jameysharp's earlier refactoring suggestion, and add assert!(!inst.is_branch()) to all the cases that I modified when removing BranchInfo. Does that seem sufficient for not making the addition of invoke/invoke_indirect not too painful?

I think that is sufficient.


Missing slash in top navigation bar

Hello,
I just started using Hugo and found the "console" theme and I really love it. However, I ran into a strange issue where the top navigation menu for the breadcrumb link is missing a "/" between "posts" and the individual post. It also happens with "photos" posts.
What's strange about it is that when I test on my laptop, I don't have this issue. It only happens after I upload to a hosting site. I've tried both Vercel and Netlify and they both have this issue.
You can see the issue on this page:
https://dbre.work/posts/hello-world/
Thanks for the help in advance!
Ryan.

Hi @rpzlcc
Thank you for submitting the issue.
What Huge version do you use?

Hey @mrmierzejewski ,
Thanks for the quick response. I've tested with both 0.71.0 and 0.72.0 and both have this issue.
Ryan.

Tested on 0.73.0 and it works now.


issue-63

This PR contains the following work for https://github.com/ibm-messaging/mq-ansible/issues/63:

Implements mutli-arch support through refactoring the downloadmq role.
Supports MQ Trial installation on S390x architecture, on Ubuntu/RH distrubitions.

SLES will require additional work, due to slight differences in the FS.

General refactoring on the downloadmq role:

Reducing platform-specific variables to a single common file, as there was code duplication.
Windows platform-specific variable file now only references windows-specific variables

Notes:

As I was unable to locate an 'mq for developers' release for s390x/PPC architectures hosted under the DHE repository for MQ. There was a 'non-install' release, but I am unsure as to the differences between these and the standard 'mq for developers' releases. THerefore, I resorted to using the MQ trial 9.3 release from IBM Support. This is the same as how MQ Ansible currently obtains the relevant files for AIX, as this utilises the trial version of MQ Ansible. Ref: https://github.com/ibm-messaging/mq-ansible/blob/47e52625c82c1771c65fe4e6f6b950890aff1de9/ansible_collections/ibm/ibmmq/roles/downloadmq/tasks/Linux_s390x_downloadmq.yml#L1-L6

A future suggestion for this, is to pass the necessary auth required to curl the files directly from IBM Support, rather than requiring the files to be present the control node, and copied to workers.

The AIX download route may need to be tested. I believe the ansible_architecture fact should report ppc64le on the AIX systems (assuming that MQ Ansible only supports PPC on AIX, due to the file referenced in the existing codebase). If this is not the case, then the playbook may need to be renamed to whatever the AIX PPC architecture reports to ansible for this fact.

Okay, great! I've made the changes and rebased/squashed the commits. Cheers!


rate limiting of login attempts

django-ratelimit-backend appears to be useful but I am not sure if it works with my allauth + axes configuration. Has anyone tried to make these three work together? It might also makes sense to add rate limiting to django-axes since axes is already keeping track of login attempts.

Looking at the ratelimiter repo the last commits are from a few years ago from May 2019, is the project supported?
One note on ratelimiting is that there are tools for reverse proxy and load balancer based rate limiting. I would recommend checking out the fail2ban project for references.

Thanks for your comments. fail2ban indeed could be a better option although I would prefer a django solution since it is more straightforward to deploy. I will close this ticket for now.

If you do find a good solution or have any notes we appreciate any insight for e.g. updating the docs regarding good rate limiting solutions for Django :)

Another candidate app along the defense line of my django deployment would be django-admin-honeypot, which I again hesitate to add due to compatibility and duplicate tracking issues.
I am not advocating for axes to steal the idea of these apps but it would be nice for axes to become the swissknife of such apps with an integrated tracking and defense system.

I've also though about the different applications that try and monitor authentication and rate limiting for Django but I think that it would be best to keep the implementation and code for Axes as-simple-as-possible for maintainability and separation of concerns. Note that these are just my personal thoughts and philosophy on the implementation and this package is maintained by Jazzband, so if you think that this is something that would be useful, please feel free to open an issue or pull request for drafting a specification or implementation for the issue.


Llama support

Thanks for making this extension! I'm interested in adding support for local Llama models using llama-node https://github.com/Atome-FE/llama-node

Did you write a llama-node modification? I don't see a pull request.


Add support for Dart Sass quietDeps

Later version of dart-sass 1.x emit warnings for upcoming v2 release. They provide a way to silence those warnings via quietDeps; true option.
Consider enabling support for this.

Do you perhaps have an easy to reproduce configuration snippet that I can use to replicate ?

Hi @megheaiulian,
see https://github.com/kr8n3r/simple-rollup-dart-sass-setup for a simple setup

to add, if you change import to a ~packageName and add
sass: {
   quietDeps: true
}

to the config, dart sass warnign get silenced, but you then get the actual legacy JS api warning
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
Deprecation Warning: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api


Vincent summary

Updated Readme
Updated About us page
Updated tests for CategoryStatistic, CategoryStatisticsList
Corrected some warnings
Added a total row at the end of summary table
Hooked up sort to the summary feature

Pull Request Test Coverage Report for Build 499

65 of 69 (94.2%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 75.836%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/planner/model/summary/CategoryStatisticsList.java
9
11
81.82%

src/main/java/seedu/planner/ui/StatsDisplayPanel.java
2
4
50.0%

Totals

Change from base Build 485:
1.4%

Covered Lines:
2200

Relevant Lines:
2901

💛  - Coveralls


Update tether to 1.5.14

1.3.0 is no longer listed on their servers and returns a 404 from brew cask install tether:
curl: (22) The requested URL returned error: 404 Not Found
Error: Download failed on Cask 'tether' with message: Download failed:
http://hellotether.com/downloads/Tether_v1.3.0.zip

Please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.
In this case, your inclusion of numi, which is already present, is preventing the merge.

I think I fixed it in #11483


Feature: add support for pre-commit

pre-commit allows to easily configure pre-commit hooks. By adding a .pre-commit-config, panvimdoc can be easily integrated, allowing to conversion of the markdown files as a pre-commit hook.
This PR adds the corresponding file and a section in the README to document how to use it. The rev and repo fields can be adapted after the PR is merged, maybe a version tag can be added so it can be referenced using rev.
Thanks for building this tool, if you have any questions or suggestions, please let me know.

Thanks for making a PR! I like pre-commit a lot, I use it on a daily basis in almost every project! So it's a great idea for automating this.
I'm not sure we should add the pre-commit hook in this repo though, since I already use the GitHub Action for updating the panvimdoc.txt file. What do you think about removing that file from this PR?
It would also be nice to have a ./panvimdoc.sh --install or ./panvimdoc.sh --check-dependencies-installed to ensure that we can give users better pre-commit hook error messages. For example, if I want to add a filter that is based on Python, I don't want it to be a hassle for pre-commit hook users to figure that out. I'll work on that feature.

Thanks for the quick response! I'm quite new to this, so maybe you can help me grasp the best workflow to integrate panvimdoc and pre-commit. I will push one more change (a wrapper file to return an error when the file has changed, so that pre-commit will notice), then I think the hook would be useable.
Then the question will be how to integrate it to the repository, so that it doesn't interfere with the GitHub Action.
To clarify, in my view a user would either use pre-commit or GitHub Action, so from this side, there should be no interference. If I understand the pre-commit docs on new hooks correctly, they have to reside in the .pre-commit-hooks.yaml file of the providing repository so that users can reference them. Therefore I think removing that file would break the compatibility with pre-commit. Does having the file pose a problem, as long as pre-commit is not used in this project and pre-commit install is not called? If it does, maybe we would need to establish a wrapper repository that contains panvimdoc as a submodule or something similar.
Regarding the dependencies, the pre-commit hook will use the Dockerfile, so no manual installations would be required for the users.
Looking forward to hear your thoughts.

I misunderstood how this works! I thought this PR was adding a precommit hook for this repo itself and showing that as an example for others to use; but really what you are doing is that adding a precommit hook that others can install, and this provides an easy way to install it. Right?

Regarding the dependencies, the pre-commit hook will use the Dockerfile, so no manual installations would be required for the users.

Users will have to use docker then, right? I think we should document exactly what a user would have to do to use the pre-commit hook locally.

Users will have to use docker then, right? I think we should document exactly what a user would have to do to use the pre-commit hook locally.

Good point, I will change the README accordingly (feel free to make edits as well).
We could also easily add a version where users can manually install the dependencies, circumventing the need to have docker installed. To do so, we only have to add a hook with a new id (maybe naming the other one panvimdoc-docker), replace language: docker with language: skript (see pre-commit docs on skript) and entry: /panvimdoc.pre-commit.sh with entry: panvimdoc.pre-commit.sh. For that, having a dependency check as you suggested above would probably be valuable. Should we do this as well or is having docker enough for now?

I have added the second variant of the hook and updated the documentation accordingly. Do you have any further suggestions?

This looks good to me now! I'll test it locally and merge it soon. Thanks for making the PR!


opencv4:arm-uwp build failure

Host Environment

OS: Windows 10

To Reproduce
Steps to reproduce the behavior:
./vcpkg install opencv4:arm-uwp
Failure logs
`-- Using C:/dev/vcpkg/downloads/opencv-cache/tiny_dnn/adb1c512e09ca2c7a6faef36f9c53e59-v1.0.0a3.tar.gz
-- Found external ninja('1.10.2').
-- Configuring arm-uwp
-- Building arm-uwp-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /m
Working Directory: C:/dev/vcpkg/buildtrees/opencv4/arm-uwp-dbg
See logs for more information:
C:\dev\vcpkg\buildtrees\opencv4\install-arm-uwp-dbg-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_cmake.cmake:104 (vcpkg_execute_build_process)
scripts/cmake/vcpkg_install_cmake.cmake:44 (vcpkg_build_cmake)
ports/opencv4/portfile.cmake:407 (vcpkg_install_cmake)
scripts/ports.cmake:141 (include)
Error: Building package opencv4:arm-uwp failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opencv4:arm-uwp
Vcpkg version: 2021-07-26-9425cf5f512f242c0bcbabac31f08832825aee81
Additionally, attach any relevant sections from the log files above.`
Attached is the output log file listed from above
install-arm-uwp-dbg-out.log

@artificial-jamesirei, thanks for reporting this issue! It should be a port bug, I will take a look.

@artificial-jamesirei PR#19358 may solve this issue, could you test with latest version and report the result?

@artificial-jamesirei, this issue has been fixed, please get latest source and try again.


[feature request] httpRequest with method as expression

I'd be great, if there was the ability to make a httpRequest with signature (method: Expression[String], url: Expression[String]).
I've explained my use case in this StackOverflow question.

You didn't actually describe your use case, but an implementation.
Why do you need to pass a dynamic method exactly?

Sure, let me shed a little light on my situation, so you can decide if that's a useful scenario and a good idea to support HTTP methods in a more dynamic matter.
As you can see in the code sample, I use a collection of a custom data structure. There are several reasons for choosing this over a CSV or Json Feeder. We might get our raw data from several external sources with varying formats (csv, text files, json, etc). The data needs to be processed and enriched (applying different access tokens for example), before we can use it. In the end we'll have a sanitized list with several objects with title (descriptor for results page), method (to use in http request), endpoint (url), requiredParameters (a query map), code (for response code check).
Does this make sense to you?

There's still something that bugs me: usually, requests don't have the same look depending on the method used, eg GETs tend to not have a body while POSTs do. So you can't just use a dynamic method, you need to route on different branches with a doSwitch.

That's a good argument, and I have actually incorporated doSwitch in the meantime. There's some unnecessary code duplication, but this might be the better solution for many cases anyway. Therefore closing this issue and thanking for the open ear and suggestion.


updated: The sidepanel app is not able to be displayed on in-meeting panel.

Without any changes except ngrok endpoint, I have tried to access my SidePanel App in Teams, currently for testing by Devpreview manifest.json.
This is for a feasibility check of displaying the app during the meeting. It was working well till last week. but suddenly it is not able to display anymore. I have not changed any configurations from last which was working well.
I am attaching my manifest.json after removing confidential information. As a mention for referring, I have already set on Teams Admin, Activate Teams app > Setup policies > Upload custom apps. ( https://docs.microsoft.com/en-us/microsoftteams/platform/apps-in-teams-meetings/create-apps-for-teams-meetings?tabs=json )
And Turned on Developer Preview of User Setting.
And Delete Teams cache data in %AppData%Microsoft / Reinstall App after uninstalling. - Not solved
The Same App is visible on ChannelTab, but not visible on the unified bar (u-bar) of in-meeting panel.

This image is the screenshot, succeeded last time.

Does the manifest loader in teams have any mechanism of internal cache? could you tell me how to initialize all cache data related side panel app?
In terms of the settings for activating Development preview, It seems to not have any omitted part. If it is not, Could you tell me any setting should be checked?
Is there any changes to the loading side panel in-meeting app?

manifest.json
{
   "$schema": "https://raw.githubusercontent.com/OfficeDev/microsoft-teams-app-schema/preview/DevPreview/MicrosoftTeams.schema.json",
   "manifestVersion": "devPreview",
   "version": "1.0.0",
   "id": "aa32a7c1-45d5-455b-8752-882c58aa773c",
   "packageName": "demo.contoso.teams.extension",
   "developer": {
      "name": "skeletonKim",
      "websiteUrl": "https://45f3bbb9528c.ngrok.io",
      "privacyUrl": "https://45f3bbb9528c.ngrok.io/privacy",
      "termsOfUseUrl": "https://45f3bbb9528c.ngrok.io/termsofuse"
   },
   "icons": {
      "color": "color.png",
      "outline": "outline.png"
   },
   "name": {
      "short": "Demo App",
      "full": "Demo App"
   },
   "description": {
      "short": "Short description for Demo App.",
      "full": "Full description of Demo App for Microsoft Teams."
   },
   "accentColor": "#FFFFFF",
   "bots": [],
   "composeExtensions": [],
   "configurableTabs": [
      {
        "configurationUrl": "https://45f3bbb9528c.ngrok.io/config",
        "canUpdateConfiguration": true,
        "scopes": [
          "team",
          "groupchat"
        ],
        "context":[
          "channelTab",
          "privateChatTab",
          "meetingChatTab",
          "meetingDetailsTab",
          "meetingSidePanel"
       ]
     }
   ],
   "permissions": [
      "identity",
      "messageTeamMembers"
   ],
   "devicePermissions": [
      "media",
      "geolocation",
      "notifications",
      "midi",
      "openExternal"
   ],
   "validDomains": [
      "*.ngrok.io"
   ]
}

Could you please check if Developer Preview is enabled?

Check if opening Microsoft Teams web client with this URL works: https://teams.microsoft.com/_?ring=ring3_6

Thank you for your comment. As I mentioned earlier, I have already set it as enabled. this comment ->

I have tested this again by the scaffolding demo code which is generated by Teams Toolkit Extension of Visual code, not my code is currently proceeding. It still remains the same.

Could you please check if Developer Preview is enabled?

Check if opening Microsoft Teams web client with this URL works: https://teams.microsoft.com/_?ring=ring3_6

I have looked into what it is a matter. The Teams might not detect the development preview accordingly even after setting the option as enabled. Could you tell me how to activate development preview mode, not by menu, by systematically and forcibly by the setting file or something?

Obviously, This is a teams bug, regardless of the machine and OS, it is not able to activate meetingSidePanel app.
I have tested again using several version of windows 10 OS on Azure by after activating Developer Preview option of client side and Admin setting of developer tenant. But it can not activate in-meeting side panel app. I assumed at the beginning, It is caused by certain environment. But by test, this is not caused by OS and Machine, I can finalize the conclusion that it is caused by Teams Defect.
Your team would need to go through the specific reason of this issue. If you need further, please escalate this issue to development team.

@skeletonKim - I'll get engineering team involved for this.  Meanwhile could you please check if it's working in development demo tenant?

@skeletonKim - I'll get the engineering team involved for this. Meanwhile could you please check if it's working in development demo tenant?

Thank you for your response. I already set all as an activate like belows.

the user custom app policy

the team custom app setting

the org-wide custom app setting

This issue is resolved by myself.


Project status and future

Hello,
I was wondering what is the current project status? The last release is over 1 year ago and I've seen little activity in terms of PR's merging and new code being brought in.
Thanks,

Hi @ieugen we are trying to consolidate all the different projects under gluster which are related Containers into one proper solution. You will soon hear from us.

Check https://lists.gluster.org/pipermail/gluster-devel/2018-July/055042.html for more details.


Prod appears to be down

Describe the bug
Navigate to https://api-hellhub-collective.koyeb.app/api/war, see that you get a 404.
Environment information
N/A
Expected behavior
No 404 is produced.
Which version of the browser are you using?
Safari 17.3.1 (196<IP_ADDRESS>.12)
What areas are affected by the issue

[ ] All areas
[x] Production
[ ] Staging
[ ] Development

Closing as duplicate of #27.

Closing as duplicate of #27.


Remove unused code in game of life shader

Objective

Make game_of_life.wgsl easier to read and understand

Solution

Remove unused code in the shader

location_f32 was unused in init
color was unused in update

bors r+

bors retry

bors retry

bors retry

sigh

bors retry


webmural

h¡ =)
wondering how to~i~let people sponsor @webmural
opencollective seems ignored @github sponsors
beeing sponsored for creative opensource sounds like magic
s9a@s9a ✸ @p9ep9e
have sponges pages width @opencollective as fiscal host
webmural was setup like a user...my bad?
what's the best way to handle this scene?
🦋🦋🦋🦋🦋  thank 🦄 hue  🐠🐠🐠🐠🐠

cc @jrdnrch

@ryanve If you're an open-source project, you can try to apply to opencollective.com/opensource/apply/

Thanks @Betree when I go there it prompts me create a new collective. I already created @webmural on there and would prefer that to be the collective. On Github @webmural is an organism with many repos all opensource. The page to pick a repo in that flow gives a service error perhaps due to the thousands of repos @webmural and anyway would like to pick all of them as a whole open collective. WDYT

@ryanve Maybe try and pick "Request manual verification"

@Betree thanks thru community flow as webmural created collective with capitaL 💦
Should be cool yea? Going to try connecting @github

I recommend joining our Slack > #community-support if you have any more question

huh @github is amour open


Put file error

Put file error, Post http://up-z2.qiniu.com: write tcp <IP_ADDRESS>:58344-><IP_ADDRESS>:80: wsasend: An existing connection was forcibly closed by the remote host.
Last time: 18.94 s, Average Speed: 7.1 KB/s

没遇到过此问题，也没法复现，麻烦多点信息，是否偶现？上传图片文件还是截图？操作步骤？


Startup interactive scripts not working for virtual env REPL

VS 15 Preview 2
I have an importjson.py file in my scripts folder.  All it does is:
import json

If I open a 2.7 virtual env REPL, json has not been imported.  If I open a global 2.7 REPL, it's imported.

Edit: Maybe it doesn't make sense to have a global script for a virtual env...

My fault, I clickd the wrong "explore interactive scripts".  If I click the one for the virtual env, it takes me to a startup folder for that, and it ends up working.


do we have plan to support different k8s vendor

/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
do we have plan to support the different k8s vendor like ICP or some others and the user cases was:

If I already have a ICP cluster, I want to use cluster api to deploy the ICP and use the MCM to manage the provided ICP cluster.
If I already have a ICP cluster, I can use cluster api to deploy other vendor k8s but I want to use ICP MCM to manage those cluster.
If I did not have a ICP cluster, but I want to use ICP to have some IBM application running, so I may use cluster api to deploy an ICP cluster and deploy the IBM application(from ICP catalog) running on ICP k8s.

cc @gyliu513 @xunpan
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

This project has no plan for doing this.
It is traced in cluster-api https://github.com/kubernetes-sigs/cluster-api/issues/853

https://github.com/kubernetes-sigs/cluster-api/pull/997/ is on the way
I think we need defer this to align with v1alpha2


Bump remix and react router deps

I think bumping react router dependencies to v6 will break some things. E.g we can only use useLocation within the context of a BrowserRouter, but this doesn't play well with things on the server

f(fixed in https://github.com/invertase/docs.page/pull/235)


Annotations assigned to a template are not applied to a pod

Checklist:

[x] I've included the version.
[x] I've included reproduction steps.
[x] I've included the workflow YAML.
[ ] I've included the logs.

What happened:
Defining annotations in a workflowTemplate are not applied to a pod, however applying them to a workflow which inherits the template works fine.
What you expected to happen:
Annotation applied at a workflowtemplate level should be applied when using a template
How to reproduce it (as minimally and precisely as possible):
Doesnt work:
`apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
name: my-template
spec:
entrypoint: my-template
templates:

name: my-template
metadata:
annotations:
sidecar.istio.io/inject: "false"`

metadata:   generateName: my-template- spec:   entrypoint: use-template   templates:     - name: use-template       templateRef:         name: my-template         template: my-template
Works:
metadata:
generateName: my-template-
spec:
entrypoint: use-template
templates:
- name: use-template
metadata:
annotations:
sidecar.istio.io/inject: "false"
templateRef:
name: my-template
template: my-template
Anything else we need to know?:
Environment:

Argo version: v2.7.4

$ argo version

Kubernetes version :

$ kubectl version -o yaml

Other debugging information (if applicable):

workflow result:

argo --loglevel DEBUG get <workflowname>

executor logs:

kubectl logs <failedpodname> -c init
kubectl logs <failedpodname> -c wait

workflow-controller logs:

kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name)

Logs
argo get <workflowname>
kubectl logs <failedpodname> -c init
kubectl logs <failedpodname> -c wait
kubectl logs -n argo $(kubectl get pods -l app=workflow-controller -n argo -o name)

Message from the maintainers:
If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

I couldn't reproduce this issue on my env with the below example.  can you try it with the latest release?
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: workflow-template-whalesay-template
spec:
  entrypoint: whalesay-template
  templates:
  - name: whalesay-template
    metadata:
      annotations:
        sidecar.istio.io/inject: "false"
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay
      command: [cowsay]
      args: ["{{inputs.parameters.message}}"]

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: workflow-template-hello-world-
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    steps:
      - - name: call-whalesay-template
          templateRef:
            name: workflow-template-whalesay-template
            template: whalesay-template
          arguments:
            parameters:
            - name: message
              value: "hello world"

Hi sarabala1979, the issue is when you have a template that has an annotation which is then used by another workflow that references the template. If I use the template directly the annotation is applied, if i reference the template from another workflow, the annotation is not applied

@samirmajen sorry this has been dropped - we're pretty busy at the moment - could I please ask you to attach manifests which exhibit this behaivour?

@samirmajen If you put the label in metadata in WorkflowTemplate, but if you put it in spec.template.metadata then it will.
metadata:
  name: foobar
  labels:
    abc: def
spec:
  templates:
      metadata:
        labels:
          hij: klm

Then
$ kubectl -describe pod foo-bar-xxxxx
Name:               foo-bar-xxxxx
...
Labels:             hij=klm
                    workflows.argoproj.io/completed=true
                    workflows.argoproj.io/workflow=foo-bar-xxxxx
Annotations:        kubernetes.io/psp: eks.privileged
                    workflows.argoproj.io/node-name: foo-bar-xxxxx
                    workflows.argoproj.io/outputs: {"exitCode":"0"}
                    workflows.argoproj.io/template:
                      {"name":"foo-bar","arguments":{},"inputs":{},"outputs":{},"metadata":{"labels":{"hij":"klm"}},"container":{"name":"","image":"busybox:...


Real Time Character Counter

Describe the project you want to add with tech stack
Website that counts the number of characters in your message
Expected behavior
Tells you the number of characters you have typed
Screenshots (optional)

@MohitGupta121 @pranjay-poddar


Uncaught TypeError: Cannot read property 'innerText' of undefined

I'm experiencing this issue in Bittrex Wallet section:
Uncaught TypeError: Cannot read property 'innerText' of undefined
    at Object.balanceTable [as enhanceBalanceTable] (enhancer.js:245)
    at enhancer.js:381

Do you know what could be happening?

Thanks for creating this issue. Just addressed this in https://github.com/nirvanatikku/bittrex-enhanced/commit/539af5bcadb9c279a3af17672c7379eeeb5e5a15. Will be in the next release (1.10).


feat(firestore-bigquery-export): fix cloud task path

Fixes incomplete cloud task path references to include function location.
Fixes #1955.

@pr-Mais What is the schedule for releasing 0.1.46? You seem very active now, so I'm wondering if I disable the backsync now, or wait a couple hours/days until the next release.

@pietermarsman will try to get it out by today

@pr-Mais Any update on this?
(I appreciate your time and effort!)


add missing #include <unistd.h>

This is required to build on RHEL7, and harmless for other Linuxes.

It looks like nobody pays attention to this anymore, so never mind.


291 pagination

Issue 291: Added pagination to the ShowList. Resolves #291

Thanks - I think we're gonna keep the huge list and re-think how to do the design with the large amount of shows


[BUG]

Agent Environment

Describe what happened:
Describe what you expected:
Steps to reproduce the issue:
Additional environment details (Operating System, Cloud provider, etc):

@worm1271 Closing since this issue has no content.


Fix bad parsing of query params for AioHttp

Fixes #696 .
Changes proposed in this pull request:

do not join query parameters values with , for AioHttpApi. connexion.decorators.uri_parsing.AbstractURIParser requires those to be an array, given the code (i.e. {'queryParam': ['aValue']}). However the dictionary that reaches the parses always have single string as value for each key.

For reviewing people. I am not sure about it, but shouldn't the minimal version of aiohttp and other aio-ish libraries be bumped in requirements-aiohttp.txt. Frankly speaking the latest available aiohttp is 3.4.4. Even if the requirements file says >=, sounds to me like this might be a good idea.

@kornicameister can you add a test please? So we can avoid introducing a similar regression in the future.

@hjacobs pushed the tests. Hopefully, I wrote them correctly (i.e. consistently with the rest).

I'd recommend making the test fixture just echo, so the test contains all the logic. reading the test it's difficult to know why a 204 response is good.

otherwise, looking good. thanks for adding tests!

@dtkav I hope that this is what you wanted me to do

Hey @hjacobs , this is looking good from my perspective. Can you have a look?

:+1:


Tweak networking thread names

Makes the "kernel stacks" command look nicer.

Updated according to comments.

ping @galak, can you recheck

ping @galak

ping @galak, could you re-check so we get this merged

ping @galak


Fix embedding name so that it can be set with azd

Purpose
Discovered in debugging session yesterday that we weren't properly allowing embedding deployment name to be overridden. This fixes that and clarifies some things in readme.
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow steps in readme for using existing instance, try name other than embedding
Run azd up

Merged from main, so tests now pass.


Schedule pipeline based on cron

Summary
We want to run our automation suite using Devtron pipeline. For that we need pipeline to get triggered based on cron.
Proposal

Create schedules based on cron.
Add pipeline variables so that we can run job based on pipeline variable.

Hi Aman,
Thanks for showing interest in using Devtron for any questions please reach out to us at https://discord.com/invite/jsRG5qx2gp
Can you please elaborate the use case. So that we can prioritize the same.
Also, please check if below points help you solve your current use case

Devtron continuously monitors the code change and build the images based on image or tag, this allows developers  to iterate faster.
CI nodes are in autoscaling so that cost is incurred only when CI pipeline is running else cost is zero.
Deployment can be made automatic and manual, in case of manual images created will not be deployed unless triggered manually.

Regards

Hi Prashant,
We are having a repo where we have written script to automate manual test cases. We want these scripts to run every day at a particular time. We have created a pipeline for this. Now we want the pipeline to execute on a particular time everyday so that we will get to know the test report and evaluate builds which are breaking the application.
We are having different applications. The script to execute test for all these application is present in one repo. We have created different jobs to test different applications in yaml file. Let say we want to run application X at 10 AM everyday. So we have to create a schedule with cron and pass one pipeline variable to run tests on application X. Based on the pipeline variable the particular job to test application X will execute. So this is the reason we need pipeline variable.
Regards

Thanks Aman, this looks like a valid use case. Let me come back with prioritization.

@aman9922 This should be achieveable using the CronJob chart now, please feel free to re-open this issue if that doesn't solves your use case


GlaDOS gets interrupted by itself when on speaker

If I run GlaDOS with speaker and microphone, it hears itself speaking and assume that's the answer (e.g. the first few word of the response become the input) getting stuck in a forever loop.
The issue is not there if using headset+mic, where it can't hear its own answers.
I don't know if it's a system issue (I'm currently on Windows) or if it can be managed within the GlaDOS libraries...

This needs a noise cancelling microphone. A room speaker system is needed.

I have created a new branch that makes interruption optional in #39. That should stop the loop problem, but prevents you from interrupting GLaDOS.
Could you test it out, and see if if solves your issue?

Also, may be a good idea to note need for noise canceling setup or headphones / headset for interruption to work, in the README.

I added that to the 'Help Section' on the new branch.

I've cheked the new version and with interruptible = false it does work. However the "user experience" is a bit different, as you can't interrupt the model if it starts rambling about stuffs :D

Yes, thats how is works.
If you find the answers too long, go ahead and modify the system prompt and ask for shorter responses.


Break datafusion-catalog code into its own crate

Is your feature request related to a problem or challenge?
As we start thinking of adding new  catalog support in  DataFusion for example, @goldmedal  tried to do this for DynamicFileCatalog in  #11035  , the current code structure requires that any such implementation be in datafusion/core which is already quite large and monolithic
Also, I think long term it would be a more sustainable structure if we can move ListingTable out of the core as well
However, this move is not likely possible until we move table provider and related catalog traits out of the core.
Also, if we could split up datafusion core more, it would be easier for people to use DataFusion as a smaller embedded library (aka not bring in file format support if they didn't need it)
Describe the solution you'd like
Ideally I would like the following traits / code moved into a datafusion-catalog crate:

TableProvider
CatalogProvider
SchemaProvider
MemoryCatalogProvider
InformationSchemaProvider

Describe alternatives you've considered
No response
Additional context
No response

I looked into this --
One of the major challenges is that SessionState's constructor basically installs the "pre-provided" functionality (like data sources, etc
https://github.com/apache/datafusion/blob/78055fe13b64cdfb4accd131e9a462770c21a934/datafusion/core/src/execution/session_state.rs#L190-L295
One way to handle this would be to allow constructing SessionState with the minimal built in features, and have a function in SessionContext like SessionContext::register_built_ins that would register things like listing table, information schema, etc.
That way it would still be easy to use DataFusion with a minimal SessionState but also easily register all the built in extensions 🤔

I made https://github.com/apache/datafusion/pull/11183 to start breaking apart the API and implementation -- there is still a ways to go

@alamb I took a stab at moving parquet functionality into a datafusion-parquet crate (#11188) , and I ran into similar challenges you highlight here. I think to accomplish these goals core will need to be refactored into a number of different crates to avoid circular dependencies and allow core to still offer a batteries included experience.

I think to accomplish these goals core will need to be refactored into a number of different crates to avoid circular dependencies and allow core to still offer a batteries included experience.

I agree with this entirely
The center of the knot is SessionState I think -- figuring out how to get that out of the core is likely key to breaking things up reasonably

The more I think about this the more I think trying to make SessionState a container that doesn't have all the optional features (like parquet support) by default makes sense
So like
let session_state = SessionState::new();
// no table providers, etc
// install standard built in table providers
SessionContex::install_built_in(&mut session_state);
// now session_state has them here

The more I think about this the more I think trying to make SessionState a container that doesn't have all the optional features (like parquet support) by default makes sense
So like
let session_state = SessionState::new();
// no table providers, etc
// install standard built in table providers
SessionContex::install_built_in(&mut session_state);
// now session_state has them here

I filed https://github.com/apache/datafusion/issues/11320 to track this idea


Model instances aren't rendering correctly

Issue details
I am currently learning the basics of LibGDX and I am experimenting with basic models. I have gotten a simple cube mesh to show but it isn't rendering correctly - see image:

Here is the code that I am using to get the model:
 package com.lukegdx.game;
 import com.badlogic.gdx.ApplicationAdapter;
 import com.badlogic.gdx.Gdx;
 import com.badlogic.gdx.graphics.*;
 import com.badlogic.gdx.graphics.g2d.SpriteBatch;
 import com.badlogic.gdx.graphics.g3d.Material;
 import com.badlogic.gdx.graphics.g3d.Model;
import com.badlogic.gdx.graphics.g3d.ModelBatch;
import com.badlogic.gdx.graphics.g3d.ModelInstance;
import com.badlogic.gdx.graphics.g3d.attributes.ColorAttribute;
import com.badlogic.gdx.graphics.g3d.utils.CameraInputController;
import com.badlogic.gdx.graphics.g3d.utils.ModelBuilder;
import com.badlogic.gdx.math.Vector3;
 public class LukeDDX extends ApplicationAdapter {
	SpriteBatch batch;
	Texture img;
ModelBatch modelBatch;
ModelBuilder modelBuilder;
ModelInstance modelInstance;
Model model;

PerspectiveCamera cam;
int counter = 0;
public CameraInputController camController;

@Override
public void create () {
	img = new Texture("badlogic.jpg");
	modelBatch = new ModelBatch();
	modelBuilder = new ModelBuilder();

	this.setCam();

	model = modelBuilder.createBox(10f,10f,10f,
			new Material(ColorAttribute.createDiffuse(Color.GREEN)),
			VertexAttributes.Usage.Position | VertexAttributes.Usage.Normal);

	modelInstance = new ModelInstance(model);
}

public void setCam() {
	cam = new PerspectiveCamera(67, Gdx.graphics.getWidth(), Gdx.graphics.getHeight());
	cam.position.set(10f, 10f, 10f);
	cam.lookAt(0,0,0);
	cam.near = 1f;
	cam.far = 300f;
	cam.update();

	camController = new CameraInputController(cam);
}

@Override
public void render () {
	Gdx.gl.glClearColor(1, 0, 1, 1);
	Gdx.gl.glClear(GL20.GL_COLOR_BUFFER_BIT);

	camController.update();
	modelBatch.begin(cam);
	modelBatch.render(modelInstance);
	modelBatch.end();

}

@Override
public void dispose () {
    modelBatch.dispose();
    model.dispose();
	img.dispose();

}

}`
Im wondering if I have just written something in the wrong order? Id really appreciate some guidance on this.
Version of LibGDX
1.9.8
Affected platforms

[ ] MacOS

https://github.com/libgdx/libgdx/wiki/Issue-Tracker


Gist link that immediately runs the code

I would like to put "Run" links next to all of my code samples. The user shouldn't have to click my "Run" link followed by the playground's "Run" button.
Would it be possible to have a query parameter that means immediately run the gist when you land on the page?

Yes, it should certainly be possible. It's "just" a matter of chaining together some futures. I should be able to take a poke at this on Wednesday evening.
Any bikeshedding on a potential query parameter name?

?gist=a58fc361e02c4c0a08fd99cacd9567d1&run


Shuffle

Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

521 of 961 (54.21%)  changed or added relevant lines in 27 files are covered.
18385 unchanged lines in 232 files lost coverage.
Overall coverage decreased (-1.0%) to 57.395%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config.go
6
7
85.71%

log.go
0
1
0.0%

feature/manager.go
2
4
50.0%

routing/blinding.go
10
12
83.33%

lncfg/log.go
6
9
66.67%

cmd/lncli/cmd_payments.go
0
4
0.0%

invoices/update.go
19
23
82.61%

zpay32/decode.go
20
24
83.33%

zpay32/invoice.go
6
10
60.0%

cmd/lncli/cmd_invoice.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

watchtower/wtclient/queue.go
1
85.56%

labels/labels.go
1
73.33%

channeldb/invoices.go
2
84.03%

routing/blinding.go
2
95.35%

watchtower/wtclient/session_negotiator.go
2
80.32%

channeldb/witness_cache.go
2
77.78%

funding/batch.go
2
81.48%

invoices/invoice_expiry_watcher.go
2
86.26%

chanacceptor/chainedacceptor.go
2
81.48%

channeldb/forwarding_package.go
2
74.95%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
92960

Relevant Lines:
161966

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

521 of 961 (54.21%)  changed or added relevant lines in 27 files are covered.
18369 unchanged lines in 232 files lost coverage.
Overall coverage decreased (-1.0%) to 57.39%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config.go
6
7
85.71%

log.go
0
1
0.0%

feature/manager.go
2
4
50.0%

routing/blinding.go
10
12
83.33%

lncfg/log.go
6
9
66.67%

cmd/lncli/cmd_payments.go
0
4
0.0%

invoices/update.go
19
23
82.61%

zpay32/decode.go
20
24
83.33%

zpay32/invoice.go
6
10
60.0%

cmd/lncli/cmd_invoice.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

labels/labels.go
1
73.33%

channeldb/invoices.go
2
84.03%

queue/gc_queue.go
2
96.51%

routing/blinding.go
2
95.35%

watchtower/wtclient/session_negotiator.go
2
80.32%

channeldb/witness_cache.go
2
77.78%

funding/batch.go
2
81.48%

invoices/invoice_expiry_watcher.go
2
86.26%

chanacceptor/chainedacceptor.go
2
81.48%

channeldb/forwarding_package.go
2
74.95%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
92953

Relevant Lines:
161966

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1205 of 1550 (77.74%)  changed or added relevant lines in 32 files are covered.
424 unchanged lines in 33 files lost coverage.
Overall coverage decreased (-0.04%) to 58.364%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lnrpc/routerrpc/router_server.go
0
1
0.0%

record/blinded_data.go
92
94
97.87%

routing/blinding.go
10
12
83.33%

lncfg/log.go
6
9
66.67%

cmd/lncli/cmd_payments.go
0
4
0.0%

zpay32/decode.go
20
24
83.33%

zpay32/invoice.go
6
10
60.0%

cmd/lncli/cmd_invoice.go
0
5
0.0%

lnrpc/routerrpc/router_backend.go
35
40
87.5%

lntest/harness_assertion.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

watchtower/wtclient/queue.go
1
85.56%

config.go
1
55.55%

zpay32/invoice.go
1
80.87%

htlcswitch/linkfailure.go
2
51.72%

routing/blinding.go
2
95.35%

watchtower/wtclient/session_negotiator.go
2
80.32%

invoices/invoiceregistry.go
2
85.7%

lnwallet/chancloser/chancloser.go
2
83.11%

channeldb/forwarding_package.go
2
74.95%

lnrpc/websocket_proxy.go
2
76.87%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
124075

Relevant Lines:
212590

💛  - Coveralls


No option for input change

Need a text area instead of Text Input. Also I am not find a example to set false search button.

Sorry....I will not be giving an option of having text area instead of Text Input.
You can hide the search button my setting showSearchButton:false in the configuration. See the Demo


Enhancement request: Some kind of powered home defense system

Mekanism is my favorite mod of all time. Will be cool if some kind of home defense system can be added ?
With all the cool RF generation, it will be great to have more cool stuff to spend the extra energy on.

Laser turrets (tiered upgrades using installer for increased damage/fire rate)
Laser fences (electrocute things and set on fire when passing through)
Ion Cannon - radius blast, stun/freeze creatures

Thanks and keep up the great work

See https://github.com/aidancbrady/Mekanism/issues/3496#issuecomment-233405885 & #3108 I guess

@LordHellscream Don't we already have laser fences via lasers and laser amplifiers? No fire or electrocution, just rapid or instant death depending on charge levels. Enough charge will even insta-kill players in Draconic armor.


undefined method `add_unpersisted_outgoing_rel'

When saving a model:
undefined method `add_unpersisted_outgoing_rel' for nil:NilClass
org/jruby/RubyBasicObject.java:1677:in `method_missing'
activesupport (3.1.3) lib/active_support/whiny_nil.rb:48:in `method_missing'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/relationships/relationships.rb:110:in `add_unpersisted_outgoing_rel'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/rel_persistence.rb:154:in `create'
org/jruby/RubyBasicObject.java:1688:in `__send__'
org/jruby/RubyKernel.java:2114:in `send'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/tx_methods.rb:9:in `create'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/transaction.rb:49:in `run'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/tx_methods.rb:9:in `create'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/callbacks.rb:39:in `create_with_callbacks'
activesupport (3.1.3) lib/active_support/callbacks.rb:414:in `_run_create_callbacks'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/callbacks.rb:39:in `create_with_callbacks'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/rel_persistence.rb:136:in `create_or_update'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/callbacks.rb:35:in `create_or_update_with_callbacks'
activesupport (3.1.3) lib/active_support/callbacks.rb:416:in `_run_save_callbacks'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/callbacks.rb:35:in `create_or_update_with_callbacks'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/rel_persistence.rb:16:in `save'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/validations.rb:13:in `save'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/relationships/storage.rb:208:in `persist'
org/jruby/RubyArray.java:1612:in `each'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/relationships/storage.rb:207:in `persist'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/relationships/relationships.rb:7:in `write_changed_relationships'
org/jruby/RubyHash.java:1218:in `each_value'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/relationships/relationships.rb:6:in `write_changed_relationships'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/persistence.rb:168:in `init_on_create'
/Users/dnagir/proj/neo4j/lib/neo4j/rails/persistence.rb:158:in `create'

The commit 3095a46d33a8cbc9c87d69894cb57cadab54efcb definitely fixes the issue.
I will try to come up with a spec to reproduce it.


questionable patterns

While working on the refactor, these were the only patterns where Bash 4.3 disagreed with the results from this library. (minimatch fails 37 of the these tests).
I believe extglob is correct on most of these - this is only a few patterns with multiple examples for clarity (for example, IMHO !(foo)* should not match foo). I'd like some feedback on what the "verdict" should be.

Fixture
Pattern
Bash
Extglob
Verdict

foo
!(foo)*
true
false
?

bar
!(foo)*
true
true
agreed

baz
!(foo)*
true
true
agreed

foobar
!(foo)*
true
false
?

foo
*(!(foo))
true
false
?

moo.cow
!(*.*).!(*.*)
true
false
?

mad.moo.cow
!(*.*).!(*.*)
false
false
agreed

foo.js.js
*.!(js)
true
false
?

foo.js.js
*.!(js)*
true
false
?

foo.js.js
*.!(js)+
false
false
agreed

foo.js.js
*.!(js)*.!(js)
false
false
agreed

Notes
One thing to consider is that whereas in bash, the extglob pattern might be the complete pattern, with this library the pattern is more likely to be a part of a larger glob pattern for testing file paths, etc.
cc @phated @doowb @tunnckoCore

and preliminary benchmarks
Benchmarking: (4 of 4)
 · negation-simple
 · range-false
 · range-true
 · star-simple

# benchmark/fixtures/isMatch/negation-simple.js (43 bytes)
  extglob x 6,986,439 ops/sec ±0.67% (88 runs sampled)
  minimatch x 259,035 ops/sec ±1.12% (86 runs sampled)

  fastest is extglob

# benchmark/fixtures/isMatch/range-false.js (56 bytes)
  extglob x 5,736,659 ops/sec ±0.89% (86 runs sampled)
  minimatch x 254,250 ops/sec ±1.07% (85 runs sampled)

  fastest is extglob

# benchmark/fixtures/isMatch/range-true.js (56 bytes)
  extglob x 6,220,181 ops/sec ±0.89% (87 runs sampled)
  minimatch x 249,175 ops/sec ±1.03% (90 runs sampled)

  fastest is extglob

# benchmark/fixtures/isMatch/star-simple.js (45 bytes)
  extglob x 6,285,213 ops/sec ±0.89% (90 runs sampled)
  minimatch x 237,600 ops/sec ±1.00% (86 runs sampled)

  fastest is extglob

and source maps:
{ version: 3,
     sources: [ 'string' ],
     names: [],
     mappings: 'AAAA,CAAE,CAAE,EAAE,CAAE,CAAC,GAAE,GAAE,EAAC' }

moo.cow	!(*.*).!(*.*)

I'm agree with Bash to be true, it make sense.

foo.js.js 	*.!(js)

and

foo.js.js  	*.!(js)*

I'm agree with Bash and seeing his the point to return true, but I'm curious what Bash says for *.!(js.)?

hm... what about opposite

I'm running all of the Bash tests I was able to find - the table above lists the only patterns that extglob disagrees with bash on. Unfortunately the nuances of bash extglob don't seem to be consistent with regex - unless we can find a real specification, with sufficient detail to determine correct matching behavior, we'll just have to go with our best guess on some of these.

The patterns themselves are pretty bizarre and basically contradict themselves. Based on the chart I'd think extglob's behavior is more in line with what users would expect if they actually used these sorts of combinations, and I also think that when the pattern is odd/ambiguous it's better to "fail closed" and lean toward false when in doubt - so extglob still wins.
I suppose I could understand Bash's reasoning on some of these - particularly those with a trailing * (but at that point should a trailing * just trump absolutely anything else specified in the pattern?) - but a few I'm really struggling to understand how a match could be considered correct behavior.
Stellar work here @jonschlinkert

thanks for the feedback @es128!

I also think that when the pattern is odd/ambiguous it's better to "fail closed" and lean toward false when in doubt

yeah that's pretty similar to what I was thinking

I think I am pretty much agreement with everyone.  extglob's behavior seems to be less surprising.  Make sure to note the differences in the readme, of course.

Make sure to note the differences in the readme, of course

good call. I might have forgotten to do that thx

Yea, why not? Let's go with that agreement and if there so many users that are surprised in future, things can be done more strict and to stick more to Bash.

extglob's behavior is more in line with what users would expect if they actually used these sorts of combinations

Absolutely.

meaning you agree?

Yep, I don't have problems with most of them.

closing, I think this is resolved


Remove azure-communication-phonenumbers

Docs Build status updates of commit ec66dc4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch djurek/remove-azure-communication-phonenumbers has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update cmd_apply.go

Update the log.Errorf to log.Errorf
Related Issues
close #537

Hi @shubham-cmyk , are you in our WeChat group? Or do you have my WeChat?

Hi @shubham-cmyk , are you in our WeChat group? Or do you have my WeChat?

I am not in wechat group, also I can't join because I am not from China but I have already join the DevStream Slack channel.

@shubham-cmyk would you please also change line 21 in the same file? Thanks!


Issue 280

Currently if there is more than one interface (openstack port) on a single network only the first interfaces's IP address is available to the scripts as $network_name. If there is more than one subnet associated with a particular network (i.e. IPv4 and IPv6) openstack assigns IP addresses from both but the value of $network_name in the scripts is randomly assigned between the two.
Update the VNFCInstance to have not only a single ip address per network but now have all ip addresses including their subnets and interface id's if specified in the vnfd.json file.
This references issue #280 .  Changes were also made to other repos that need to be merged.  Relevant pull requests are:
openbaton/openstack4j-plugin#64
openbaton/generic-vnfm#72
openbaton/plugin-vimdriver-amazon#2
openbaton/network-slicing-engine#14

@marcellom @mpauls this feature should probably be added in branch 6.0.

closed due to inactivity


openstack: specify port id on floating ip creation

What this PR does / why we need it:
Specify port id on FloatingIP creation.
Follow up on https://github.com/kubermatic/machine-controller/pull/316#discussion_r217648949

cc @bashofmann


hide project base path of file path in error overlay

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
For now, the error overlay shows a diagnostic with an absolute file path. I think it's better to hide the project path prefix for better reading.
We can trim the prefix or replace it with a string token.

Describe alternatives you've considered
No response
Additional context
No response
Validations

[X] Read the docs.
[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.

not stale


abstract def Spider#spiderInit() must be implemented by Spider:Module

Compiler says module should implement abstract method if it extends self
module Spider
   extend self
   @client = nil

   def request(action,type="text",method="GET")
        response = HTTP::Client.get action
        puts response.body()
   end

   abstract def spiderInit()
end

Well, yes, you do extend self and there's no Spider.spiderInit defined. Why do you extend self?

So i can create also use namespace

No, that's not necessary in order to use a module as a namespace for other modules, classes, structs, enums, constants or aliases.

Ok. So it is not a bug

Perhaps it's a documentation bug, what make you think extend self was necessary?

No.