Draft: LSPS1 Version 2

This is a proposal to update the LSPS1 channel request spec to fix the issues we discussed in the 2023-02-1 meeting and the discussion in the Telegram group after.
The goal of this proposal is to

Improve modularity of the spec so interested parties can choose what part of the spec they like to implement.
Make request/response values more clear so implementing parties end up with the same api.
Generally add more descriptions so external parties have a chance to understand the spec.

Content
The proposed api consists of a base_api that is required to be implemented by all parties and optional extensions. Extensions are additional fields / endpoints that support a certain functionality.

base_api Channel purchase and open.
lnurl_lud2 LNURL channel open.
jit_channels Just-In-Time channels.
refunds Automatic refunds (newly proposed by me).

I am happy to split this PR up if demanded but I think it's worth having this full PR so everybody gets an initial impression of my proposal.
OpenApi
The proposal leans heavily on the OpenApi format to describe request / response values. Use any OpenApi editor like the Swagger Editor to parse the content. All OpenApi docs in this pull request include descriptions for every field. So please have a look at them.
Thanks for your feedback.

Is there a way to get a formatted openapi doc? Its pretty hard to review the openapi doc itself.

Use https://editor.swagger.io/ (see my initial PR description).

I updated the PR. Some highlights:

Change naming of remote/local to user/lsp. For example, user_balance and lsp_balance.
Removed sync flow for websites.
Simplified peer connection. Only let user open the connection.
Added node connection string definition.
Remove all extensions (jit, lnurl, refund). JIT is still an open question though.
Added onchain refund flow.
Added more open questions at the bottom of the doc.

For JIT channels, I would suggest making a separate spec.  Basically, this LSPS1 is for pre-buying inbound liquidity, then specify a different spec for JIT channels.

Changed channel_expiry_weeks to channel_expiry_blocks as discussed in the meeting.
Use the same version array as proposed on LSPS3. This allows for one api to support multiple versions.
Changed onchain_fee_rate to confirms_within_blocks. This makes it more clear on how fast the channel should confirm onchain. It limits the amount of time an LSP can wait to batch channel opens and gives the user clear expectations on when the channel should be open. See transcription of our last meeting for more information.
Added minimum_depth option that indicates how many block confirmations the LSP requires. 0 means the LSP supports 0conf.
Added supports_zero_channel_reserve option to indicate if the LSP allows 0reserve.

minimum_depth and supports_zero_channel_reserve options are my proposal following the discussion around 0conf and 0reserve support. It clearly indicates if these non-standard methods are supported.

Summary of the changes:

Removed everything that had to do with connection_strings. They are not needed already.
Removed the peer connection section. With JSON RPC, we assume we have a peer connection anyway.
Renamed user to client to make it similar to LSPS0.
Turned all HTTP requests (aka POST /lsp/channel) into jsonrpc method names like lsps1.create_order.
Added Error section to all defined methods. Heavily inspired by Zmn's proposal in #3.
Removed the OpenAPI doc as it is incompatible with jsonrpc. I moved all the field descriptions to the readme.

This increased the size of the doc significantly but made it more readable IMO.

Added more options to better define what the LSP is willing to sell:

min_client_balance_satoshi
max_client_balance_satoshi
min_lsp_balance_satoshi
max_lsp_balance_satoshi
min_channel_balance_satoshi
max_channel_balance_satoshi

Added api_version to the order object.
Make it explicit that if a coupon_code is invalid, a error will be returned.
Added Idempotent Yes/No to every request to indicate it shouldn't have side effects.
Described the Channel object in further detail.

Summary of changes
Added sections and requirements for 0conf risk management. As described in this article, if we are sure of the onchain fee+client_balance payment, the LSP has zero risks opening a 0conf channel. Therefore the spec focuses fully on securing the onchain payment and NOT on the 0conf channel open.
Onchain payment
I introduced 2 new fields:

onchain_block_confirmations_required Number of block confirmations required for the LSP to accept the onchain payment as confirmed. 0 would indicate 0conf payments.
minimum_fee_for_0conf Minimum fee that the LSP requires to accept the onchain payment as 0conf. This is only necessary in case onchain_block_confirmations_required is 0 of course.

These are the two tools the LSP can work with to mitigate the onchain payment risk. Important to note here: Both fields are "best-guesses". If the LSP doesn't feel comfortable in these values anymore when the client actually pays, the LSP MAY wait longer for confirmation. The whole approach to risk management can be described as: The LSP tries to estimate the risk-mitigating values as good as possible but may always back off in case it is not confident in them anymore (for example during a fee spike).
Other changes

Renamed coupon_code to token.
Referenced LSPS0 common schema data types.

At this point, I think the spec is basically complete. Please review it so we can potentially merge it in some weeks.

I fixed basically all comments from @tnull. See commit messages.
Some highlights:

Renamed state to order_state to distinguish them better from payment.state and channel.state.
Found some invalid order_state changes and fixed them.
Added SHOULD limit changes in lsps1.info` to once/day. See rationale in the spec for more info.
Changed how types are shown

From: property type Description
To: property <type> Description

Fixed lots of typos.

I left some comments open above that still need inputs.

Some minor changes:

Added trust model
Changed API version from 2 to 1
Put null into null.
Removed token max_length.

I hope I now caught up on all comments from @tnull that I missed.

Added Anchor links. It's a bit of a mess though as the <> characters outside of "`" ticks hide content in some cases. If anybody has a better idea on how to display the types visually, let me know.
@tnull

Oh, could you give an example where this is the case? Looked alright from a quick scroll-through for me. Also, might be nice to rebase this PR for now on https://github.com/BitcoinAndLightningLayerSpecs/lsp/pull/42 so that the links actually work.

Github markdown rendering:

Array<uint16> will render to simple Array.

Screenshot of what I typed:

So content between <> just disappears. If I put the types in `` then the links don't render anymore.
Github markdown rendering:

Link will be [Link](www.example.com).

Screenshot of what I typed:

So I had to put the types into `` sometimes and outside of `` the other time. It's a mess.

And yes, I will rebase.

Github markdown rendering:

Array<uint16> will render to simple Array.

Screenshot of what I typed:
So content between <> just disappears. If I put the types in `` then the links don't render anymore.
Github markdown rendering:

Link will be [Link](www.example.com).

Screenshot of what I typed:
So I had to put the types into sometimes and outside of the other time. It's a mess.

And yes, I will rebase.

Mh, but usually Array<uint16> should work? That is
[`Array<uint16>`](https://www.example.com)

Yes, but what link do you want to put behind the array? We have LSPS0 data types and we have regular data types like the array.


Not executing after_deploy, nor releases_to_keep

I have an after_deploy command that is not being triggered correctly.
Output says it is
--------------- RUNNING PRE-DEPLOY COMMANDS

--- kill -KILL `ps o pid= -C main`

--------------- CREATING NEW RELEASE

--- cd /var/www && mkdir -p releases/20150320151525912

--------------- UPLOADING NEW BUILD

--- DONE UPLOADING

--------------- UPDATING SYM LINK

--- rm -rf /var/www/current && cd /var/www && ln -s releases/20150320151525912 current

--------------- RUNNING POST-DEPLOY COMMANDS

--- cd /var/www/current && go build main.go && nohup ./main &

But I am not getting anything on the directory.
And releases_to_keep is not removing any releases.
The Gruntfile
enviroments: {
  options: {
    privateKey: key,
    username: username,
    host: host,
    deploy_path: '/var/www',
    local_path: 'dist',
    releases_to_keep: 2
  },
  production: {
    options: {
      before_deploy: 'kill -KILL `ps o pid= -C main`',
      after_deploy: 'cd /var/www/current && go build main.go && nohup ./main &',
    }
  }
}

You can see more information if you run the grunt task with the --debug option.
grunt ssh_deploy:production --debug

Thanks @hurricane766
Output with --debug flag
Running "ssh_deploy:production" (ssh_deploy) task
[D] Task source: /path/to/node_modules/grunt-ssh-deploy/tasks/ssh_deploy.js

Connecting :: ###.###.###.##

Connected :: ###.###.###.##

 In other words, is /var/www/current pointing to the proper release directory?
Does the program exit after the RUNNING POST-DEPLOY COMMANDS section? Or does it just hang there?
It doesn't look like it's getting to the keep releases part at all.
What happens if after it fails, you manually ssh onto that machine and try running those post deploy commands?

Similar issue, we are getting to the REMOVING OLD BUILDS section, but no release directories are being deleted.  Tested the command from the command line under the same user as grunt is using, and the line of code performs as expected.  any clues?  There is no other output under the remote command when running grunt -v -d.
Thanks.
--------------- REMOVING OLD BUILDS
--- rm -rf ls -r /var/www/html/my_site/releases/ | awk 'NR>5'
[D] REMOTE: rm -rf ls -r /var/www/html/mysite/releases/ | awk 'NR>5'

@athinktank I've been having the same experience lately. I tried changing rm -rf to rm -rfv and got no more information, so clearly it's not running at all.
I can get the ls section to return display results but the rm will not execute.

I think I've got it. The issue was the working directory is not the releases directory, so rm was just getting the name (not the full path) of the release directories but they don't exist in the current working directory so rm was doing nothing.
I can't do a pull request right now but the command in remoteCleanup should change to:
var command = "cd " + options.deploy_path + "/releases/ && rm -rfv `ls -r " + options.deploy_path + "/releases/ | awk 'NR>" + options.releases_to_keep + "'`";
I added a -v to the rm so you can see the delete happening now.

Thanks @hurricane766 .  I've tried it and it does the trick for me as well!   Thanks again.


Setup

Hello,
Can you please explain how this component must be configured?
thanks

See the documentation on GitHub for instructions about ShellyForHass.
https://github.com/StyraHem/ShellyForHASS


Fixing ambiguous method call

name: Pull Request
about: While setting up the project in IntelliJ got this error:
Ambiguous method call. Both
newFileSystem(Path, ClassLoader) in FileSystems and
newFileSystem(Path, Map<String, ?>) in FileSystems match
title: 'Fixing ambiguous method call'
labels: Status:Discovery:hacktoberfest
assignees: 'Joachim92'

Environment
Liquibase Version: 4.1.2
Liquibase Integration & Version: maven 3
Liquibase Extension(s) & Version: N/A
Database Vendor & Version: N/A
Operating System Type & Version: Mac OS X
Pull Request Type

[x] Bug fix (non-breaking change which fixes an issue.)
[ ] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
There are two constructors in FileSystems.java that require two arguments, the one that requires a Map, is marked with "since 13" so when this goes live it will cause an error when the second attribute is 'null' as the compiler will not know which of these functions to pick.
newFileSystem(Path, ClassLoader)
newFileSystem(Path, Map<String, ?>)
Steps To Reproduce
Pull master branch
Import project on IntelliJ
Go to FileSystemResourceAccessor.java and the error will show up
Actual Behavior
Error thrown:
Ambiguous method call. Both
newFileSystem(Path, ClassLoader) in FileSystems and
newFileSystem(Path, Map<String, ?>) in FileSystems match
Expected/Desired Behavior
No error is thrown.
Screenshots (if appropriate)

Additional Context
N/A
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel
┆Issue is synchronized with this Jira Story by Unito

This is a change from the previous build, which passed.


fix breaker status

Codecov Report

Merging #92 (c2902aa) into main (2110235) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   19.64%   19.64%
=======================================
  Files          12       12
  Lines         835      835
=======================================
  Hits          164      164
  Misses        654      654
  Partials       17       17

Flag
Coverage Δ

macos-latest
19.64% <ø> (ø)

ubuntu-latest
19.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2110235...c2902aa. Read the comment docs.


tophat2 doesn't work with bowtie2 large indexes??

Even though bowtie2 indexes wheat genome tophat2 will not find the indexes. Someone at TGAC has fixed the code for this in a day and I have requested if he will share but have you guys got a fix that could put in? I'll ask him to share it with you if I can reproduce it working.

I'll second this. I have the same problem. I've got .bt2l indexes from Bowtie2.
++ tophat -G genes.gtf --transcriptome-index=transcriptome/genes genome/B73v3.W22v3.genome
[2016-02-13 01:14:39] Building transcriptome files with TopHat v2.1.0
-----------------------------------------------
[2016-02-13 01:14:39] Checking for Bowtie
Bowtie version: <IP_ADDRESS>
[2016-02-13 01:14:40] Checking for Bowtie index files (genome)..
Error: Could not find Bowtie 2 index files (genome/B73v3.W22v3.genome.*.bt2)

+1 I'm encountering this as well.  Large bowtie2 index files are not recognized by TopHat2.

This has been the case forever. There is a patch that TGAC have but have
not submitted it yet. We have been using the patched version and seems to
work fine with Wheat. Maybe they haven't fully tested yet or got round to
it. But the the guy to contact is Luca Venturini (TGAC) <
<EMAIL_ADDRESS>who is like most people at TGAC very impressive
and has a patch to fix this.
On Mon, Mar 21, 2016 at 7:53 PM, Ryan<EMAIL_ADDRESS>wrote:

+1 I'm encountering this as well. Large bowtie2 index files are not
recognized by TopHat2.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/infphilo/tophat/issues/14#issuecomment-199447902

The developers have not fixed it because I'm guessing it doesn't affect
human work so not a priority?? Can use Star instead though which doesn't
suffer from this bug of unable to use on large genomes.
On Tue, Mar 22, 2016 at 10:35 AM, Robert King<EMAIL_ADDRESS>wrote:

This has been the case forever. There is a patch that TGAC have but have
not submitted it yet. We have been using the patched version and seems to
work fine with Wheat. Maybe they haven't fully tested yet or got round to
it. But the the guy to contact is Luca Venturini (TGAC) <
<EMAIL_ADDRESS>who is like most people at TGAC very
impressive and has a patch to fix this.
On Mon, Mar 21, 2016 at 7:53 PM, Ryan<EMAIL_ADDRESS>wrote:

+1 I'm encountering this as well. Large bowtie2 index files are not
recognized by TopHat2.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/infphilo/tophat/issues/14#issuecomment-199447902

The latest version of TopHat2 incorporated Luca's solution, but we haven't tested it much.
As the main developer of TopHat2, I'd like to recommend you to use HISAT2, which is officially a successor to TopHat2.  HISAT2 supports large indexes.  HISAT2 is very fast with low memory requirements, and works well with downstream analysis such as StringTie and Ballgown.

This appears to be fixed in Tophat 2.1.1.   I was seeing the error with 2.1.0.   I was using hg19 and just added patch references and unplaced contigs and all is okay now.
Hisat2 is probably the better approach, but unfortunately, we have to use Tophat2.

Hisat2 looks interesting. May take time because tophat2 is so established.
Curious if could map to population of genomes means could map to different
varieties of a plant species but will have to do some more reading into it.
On Tue, Mar 22, 2016 at 2:41 PM, Ryan<EMAIL_ADDRESS>wrote:

This appears to be fixed in Tophat 2.1.1. I was seeing the error with
2.1.0. I was using hg19 and just added patch references and unplaced
contigs and all is okay now.
Hisat2 is probably the better approach, but unfortunately, we have to use
Tophat2.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/infphilo/tophat/issues/14#issuecomment-199844590


Error with heroku login on window 8.1

I installed heroku toolbelt in my D drive. On running "heroku login" from cmd first time, gave me below error. When I run it again, it shows "Installing Heroku Toolbelt v4... Done", however it hung on installing nodejs. On running it third time, I got everything ok and I was able to login through my heroku credentials. But when I restarted my machine and try to login again using "heroku login" it displayed below error again. Why it always trying to install heroku on heroku login command. Is it because I have installed it on D drive and not on C.
C:\Users\admin>heroku login
Installing Heroku Toolbelt v4... !    Heroku client internal error.
!    Search for help at: https://help.heroku.com
!    Or report a bug at: https://github.com/heroku/heroku/issues/new
Error:       read timeout reached (Excon::Errors::Timeout)
Command:     heroku --version
Version:     heroku/toolbelt/3.42.3 (i386-mingw32) ruby/1.9.3
Error ID:    17b0f8b5e1cc4346a615b75602d4b894

More information in C:/Users/admin/.heroku/error.log

More Errors on another attempt:
C:\Users\admin>heroku --version
Installing Heroku Toolbelt v4... done.
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
Setting up node-v4.1.1... ?    read tcp <IP_ADDRESS>:52542-><IP_ADDRESS>:443:
wsarecv: An existing connection was forcibly closed by the remote host.
error loading plugin commands
error loading plugin topics
error loading plugin commands
heroku/toolbelt/3.42.3 (i386-mingw32) ruby/1.9.3
!    Heroku client internal error.
!    Search for help at: https://help.heroku.com
!    Or report a bug at: https://github.com/heroku/heroku/issues/new
Error:       No such file or directory - "C:/Users/admin/.heroku/heroku-cli.

exe" version (Errno::ENOENT)
Command:     heroku --version
Version:     heroku/toolbelt/3.42.3 (i386-mingw32) ruby/1.9.3
Error ID:    060c570c73d84ee9897471a71436247b
More information in C:/Users/admin/.heroku/error.log

More Updates: I have installed it in C drive and there too having same issue. After few attempts I managed to get logged in through command prompt, cloned Java sample from git and when I executed heroku create, it again started to install Toolbelt. It's driving me crazy. Please note that its a same command prompt in which i have executed heroku login and got successfully authenticated.
D:\Projects\R&D\Heroku\java-getting-started>heroku create
Installing Heroku Toolbelt v4... done.
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
Setting up node-v4.1.1...

can you update and try again?

Working fine now. May I know the root cause please.

your home drive is on a network drive, this prevents windows from allowing a connection with the executable I place there. I resolved it by using $LOCALAPPDATA instead of the home directory


Add referred_to_by data to events pages (from 2057)

Problem Description:
Describe the problem to solve or enhancement being requested.
Expected Behavior/Solution:
Describe the solution to the problem or the expected behavior.
Requirements:
List of details required for the completion of the issue or requirements for the feature/bug. This can also include requirements that lie outside of the teams such as new design docs or clarification from an outside source.
Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[ ] Wireframe/Mockup - Mike
[ ] Committee discussions - Sarah
[ ] Feasibility/Team discussion - Sarah
[ ] Backend requirements - TBD
[ ] Frontend requirements- TBD
[ ] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:

Example endpoints from LUX to use for development and testing, if applicable.

Dependencies/Blocks:

Blocked By: Issues that are blocking the completion of the current issue.
Blocking: Issues being blocked by the completion of the current issue.

Related Github Issues:

Issues that contain similar work but are not blocking or being blocked by the current issue.

Related links:

Bugherd: https://www.bugherd.com/projects/284041/tasks/2023

Wireframe/Mockup:
Place wireframe/mockup for the proposed solution at end of ticket.

Per UAT, I am closing this issue.


DOC-39: Address feedback, refactoring for 403.

@JuroUhlar , @TheUnderScorer - The PR is now ready for review. But, Lint fails for reasons beyond my knowledge 😢
Can one of you please help me? Thanks!

@JuroUhlar - Even after accepting your suggestion, I could not merge as Github still thinks that there are changes still to be addressed. That's why I re-requested a review.


created richnav yml tasks

Adding a separate yml file to automate indexing the vscode repo with rich navigation

@joaomoreno pls connect with @dbaeumer for details.

Let's go with https://github.com/microsoft/vscode/pull/99036


update dependencies, the second

I merged from my non-updated fork, so #21 got pretty messy. This is a clean one.

Updating dependencies is great, as long as it's done carefully. I know off the top of my head, for example, that ESLint v3 is incompatible with v0.10. I'll welcome PRs to update dependencies as long as they address incompatibilities. (In the case of ESLint specifically, the easiest way will be to extend @btmills/eslint-config-btmills@beta, which will avoid having to create a whole new config.)

– https://github.com/btmills/geopattern/pull/18#issuecomment-265827575
I just tested using npm test and it still seems to work. Don't you think that's sufficient. Am I missing something?
Part of #18

I just tested using npm test and it still seems to work. Don't you think that's sufficient.

Passing tests don't prove that everything is working as expected, especially when upgrading dependencies across major versions.
Here's an example:
// lib/test.js

debugger; if( foo =  bar ){
console .
   log
  ({bar: asdf
	  , bar
 :bar}  )
 baz = 013

 ;;;
}

With the changes in this PR, this code passes linting with no errors. On current master, it has 16 errors. In ESLint's v1.0.0 release, it stopped enabling rules by default, so unless I had overridden a rule's options, it's no longer enabled at all - hence all the missed errors.
Based on Mocha's v3.0.0 breaking changes, it looks like we don't need to make any changes for that.
Since upgrading ESLint from v0.10. all the way to v3 is a lot of breaking changes and configuration to deal with, I'll handle that when I get a chance. In the meantime, I can merge this PR if it includes just the Mocha upgrade.

@derhuerst I'm closing this for now, but if you decide to pick it back up again, let me know!


Fix RTL and LTR encoding with Arabic

This solves #275, where the first two choices in the language selection are not displayed correctly:
Please choose your language ['1. العربية', '2. ελληνικά', '3. English', '4. Français', '5. Bahasa melayu', '6. Italiano', '7. 日本語', '8. 한국어', '9. Português do Brasil', '10. român', '11. 简体中文']:  [English]:

As per https://stackoverflow.com/questions/65318857/how-to-embed-english-in-right-to-left-languages I am using right-to-left embedding for Arabic, and left-to-right embedding with the separating commas.
I first tried this with return lambda: '%s %s: ' % (prompt_func(), '['+'\u202a, \u202c'.join(choices)+']') but this creates non-printing characters when the text is already LTR. Instead, I am now using a more elaborate for loop.
Output with this change is correct in my terminal, though I have a hard time copy/pasting that into github 😅
Trying it as an embedded image

Please choose your language [1. العربية,2. ελληνικά, 3. English, 4. Français, 5. Bahasa melayu, 6. Italiano, 7. 日本語, 8. 한국어, 9. Português do Brasil, 10. român, 11. Türkçe, 12. 简体中文]:  [English]:

@wackerow Can I ping you for review? Would be nice to have this in with withdrawals release. It's a QoL change that fixes the mangling of the UI language selection choices.

I agree that additional QoL would be great. I don't speak even a little Arabic, so I'm afraid I'd mess things up if I tried. I'd be happy to collab with an Arabic speaker on it, for a separate PR.

Ohhh your Terminal is better than mine. One more change, I'll add an additional space after the embedded-style comma. Also, the for loop is only necessary to deal with wonky Terminals like mine that print an empty char for these embedding characters. I'd still like to keep that for better UX, as not all users have sane Terminals.

I had already started some work locally to update the Staking Launchpad website as well for better RTL support, and this inspired me to complete it.
Just posted a PR over there https://github.com/ethereum/staking-launchpad/pull/594 that updates the website to fully support a right-to-left layout. Thanks for the nudge @yorickdowne! =)

Right this is where it gets weird. Let me run this again in my terminal, be back in a jiffy.

This translates as "Arabic" as per Google translate. It also visually looks like it's flowing.
So there may be Terminal-specific things about how this displays once RTL embedding is there.
I'd like to be cautious and get this right. We can assume that Arabic speakers have their Terminal set up correctly for Arabic, though a few notes in the README would also be good.
Do you have a connection to the gentleperson that did the Arabic translation? I could connect with them, verify how to set up a Terminal "the right way" so it supports RTL, and verify that this code is displaying RTL correctly.

We outsourced the translations and unfortunately don't have a direct connection to the person who did this translation.


React version is long out of date.

The react version for the template project is very old & there are numerous warnings when building on that version.
Workaround: It is possible to replace the package.json & packages-lock.json files with files from a current (React 18.1.0).
Please update the project template to use the newer version of React - package.json.
UPDATE
I have confirmed that I cannot get the basic template project to successfully npm run build
Many failures occur, many deprecated & even using npm audit fix --force doesn't seem to get me to a working build.
However, I am able to update the entire package.json to React 18.1.0 and npm run build works with no problems.

I created a working fix to this problem (which will upgrade you to React 18.1.0).
All you have to do is copy the new files (package.json & package-lock.json) into your (old) template based project.
I have included readme instructions at the github I created with the files:
https://github.com/raddevus/PhotinoReactTemplateUpgrade
I also included a make.bat which contains the long command which will npm build & dotnet build & run the project for you.

Thank you,
yes for this sample the version is outdated.
If you'd like you could provide the updated json files as a PR and we will integrate them as soon as we can.

Updated versions are now incorporated into the samples.


Add xhs symlink to the xh package

xh maintainer here. Thank you very much for making xh available as a chocolatey package 😊.
I would very much appreciate it if the installation script for xh also installed xhs. This would enable users to issue HTTPS requests by default e.g xhs httpbin.org/get.
Also, see the following:

https://github.com/ducaale/xh#making-https-requests-by-default
https://github.com/ducaale/xh/blob/master/install.ps1#L46

Thanks for pointing that out, I totally missed it.
I've pushed a commit https://github.com/jakublevy/chocopkgs/commit/1998b7af3463964feebc40650a599ab94a8200d8 that copies xh.exe into xhs.exe as your script does.

I have pushed a fix release for version 0.15.0 to Chocolatey, see https://community.chocolatey.org/packages/xh/<IP_ADDRESS>20317


OCPBUGS-37625: DedicatedRequestServing scheduler: make taken labels list consistent

What this PR does / why we need it:
The list of fleet manager labels to use in building the node selector for placeholder pods was not consistent across calls. This resulted in potentially different variations of a given placeholder deployment in every reconcile, resulting in churn of placeholders that would prevent certain hosted clusters from getting scheduled. This commit makes the list of taken labels consistent across calls to get them by putting them in a set and sorting them.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-37625
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[x] This change includes unit tests.

/area hypershift-operator

/lgtm


AvField type=select, have an option selected by default?

Hi, is it possible to pre-select an option in a select drop-down box? I've tried different things but none of them produced the desired result. Thanks!

Sorry, I've figured it out. Just had to provide a value on AVField.


Implement screenshot testing using Happo

This PR integrates screenshot testing remotely using Happo.io. Testing locally
requires comparing a served web page to a baseline screenshot. However, due to
slight differences in machines, when running the image comparison using a CI
(CircleCI, TravisCI, and Github Actions) results in an error in the test because
the images are slightly shifted.
Testing remotely using Happo circumvents this issue by taking a screenshot of
the page when deployed and comparing it to a previously deployed version.
Because the screenshots happen on the same machine (remotely using Happo), the
screenshots are able to align when they are the same. Another advantage of Happo
is its ability to visit the site on multiple browsers and display the
differences. One disadvantage is that it only compares static websites after it
is running on App Engine. Local testing is possible with Happo but requires more
set up.
A proposed pipeline is as follows (assuming we will be comparing a pull request
to main)

We take the latest commit on main to be the site that we want to compare
against. Using Happo, we can set this commit hash to be the baseline images.

When we are ready to perform the screenshot testing, we can open a PR. Using
Github Actions, it will automatically deploy the app to a static url. Then,
Happo will automatically take screenshots of this deployed site and compare it
against the baseline images from the commit that we specified.

Happo will tell us if there are differences. If there are no differences,
then a check will appear on the pull request checks. If there are differences,
there will be a "X" on the Happo check, and clicking on the "details" link will
lead us to a site where we can compare the screenshots side by side and either
"accept" or "reject" the differences. After the differences are accepted or
rejected, the check on the pull request will be updated to say "Accepted by
NAME" or "Rejected by NAME".

[...]
4.
Should we set the golden hash as part of the merged PR to one of the commits in the PR?


Where are all my headers?

I see no headers in my docs at all! I'm using traits, resource types, and security schemes - and none of them appear in the raml2html generated docs.

I'm very surprised to hear that. Do you have an example RAML file for me? Which version of raml2html are you using? Are you using custom templates?

No custom templates, latest raml2html (whatever comes from a current npm install). My RAML is broken into files, here's a zip: https://www.dropbox.com/s/5rx0o2u2r9iu1ug/Inmar_CDM-v1-2.zip?dl=0
Once you build it, you should see, for example, the global API key header defined in the unauthenticated security scheme. It works fine on Mulesoft Anypoint with the real time docs panel, I wonder what version of R2H they're using?

They are not using raml2html :)
I'll take a look at your example.

Oh, I thought I saw it mentioned that they were, but I can't find that mention now.

That zip file seems empty to me. Can you just create a very basic example showing the problem, post it inline here?

Sure.
I have a security scheme.
type: x-{other}
description: API Key only
describedBy:
  headers:
    X-Inmar-REST-API-Key:
      type: string
      description: Application API Key
  responses:
    471:
      body:
        application/json:
          schema: Error
          example: |
            {
              "code": "471",
              "message": "invalid api key"
            }

Used here...
securitySchemes:
  - Unauthenticated: !include securitySchemes/unauthenticated.raml
securedBy: [ Unauthenticated ]

THAT securedBy is global, but I'm using another one that's method scoped and it doesn't appear either. Neither do headers specified in my traits.

Thanks. So yeah, I'm afraid that the security schemes are not fully rendered, this is a known issue: #10. It's mainly because I have not needed any of the things you mentioned myself, so a pull request would be greatly appreciated :)
I am working on the develop branch to add more info to the rendering of the security schemes, for example the description. Help is very welcome.

In my testing I found that headers for traits are rendered. I have never used resourceTypes, so I'll need to find an example first.

Looking at the github example file I can see that they use resourceTypes and that those headers are also rendered correctly. So I'm closing this ticket as #10 should take care of the security schemes. If I missed anything feel free to reopen with an example raml file!

Thanks Kevin. Here: https://www.dropbox.com/s/cybhy3l7ghyfexz/Inmar_CDM-v1-3.zip?dl=0
That file actually works!


Fix color context manager

A contextmanager created with contextlib can only be used one time. If we simply implement a context manager in the normal way, this is not a problem.

:+1:

I added a a docstring


Partial Static Sync

Today Hugo synchronizes the entire static directory each time a file change is detected. While it only copies the changed file(s), it still goes through the process of evaluating all files on both sides to determine which file needs to be synced. This isn't necessary as we already know what file changed. We should just sync that file.

Hello @ffrizzo,
Thank you for your contribution, @ffrizzo!  But I think I encountered a bug in your current implementation in #1671: the static directory in the theme is not synchronized.  It detects that I changed the style.css (which is inside the theme's static/ directory), but it is probably trying to copy it from the wrong place.

Hello @anthonyfok ,
I'll take a look on that and I'll submit a new pull request with the fix.

On my box, it actually copies a bit more than just the changed file. Every single file is written to the output directory for every single run of hugo, with the exception of those in the static files directory.

@Skrylar can you provide more information about that? Can you paste the output running with --verbose?

@spf13
INFO: 2016/02/21 00:08:56 hugo.go:439: Using config file: c:\Dev\Hugotest\config.toml
WARN: 2016/02/21 00:08:56 hugo.go:522: Unable to find Theme Static Directory:
INFO: 2016/02/21 00:08:56 hugo.go:542: c:\Dev\Hugotest\static\ is the only static directory available to sync from
INFO: 2016/02/21 00:08:56 hugo.go:580: syncing static files to c:\Dev\Hugotest\public\
INFO: 2016/02/21 00:08:56 site.go:1275: found taxonomies: map[string]string{"tag":"tags", "category":"categories"}
WARN: 2016/02/21 00:08:56 site.go:1995: Unable to locate layout for 404 page: [404.html]
WARN: 2016/02/21 00:08:56 site.go:1971: "404.html" is rendered empty
0 draft content
0 future content
10 pages created
0 non-page files copied
0 paginator pages created
0 tags created
0 categories created
in 31 ms

If I force the cache directory to be somewhere (ex. in the "cache" folder of the same directory), no files are left behind there. I'm not sure if that's intended or a symptom.

I just wanted to contribute an issue with the static folder not showing the contributed files from the theme on a Windows machine. My post on the forum here.
When I create the css and img folders manually, the content is correctly added. I thought I would mention this under partial static sync.

This issue has been automatically marked as stale because it has not been commented on for at least six months.
The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@jdevoo this issue isn't really about your problem.

But then again, I'm pretty sure that this "syncing issue" described in the first post also should be fixed now, by what I can read in the code and by testing; we only sync the path matching the change event(s). Can you confirm, @spf13 ?


Redundant variable capture for _

The following Warning: Redundant variable capture is correct:
Found
_ <- sequence_ [primTrue, primFalse]
Perhaps
sequence_ [primTrue, primFalse]

but following it triggers a compiler warning, suggesting the you should revert to the original.
This is getting into matters of taste, but the original version suggests that you know what you are doing and the redundancy should not be warned about.  If the _ was a variable x, the warning should stand.

What sequence_ are you using? What is the compiler warning?

I was confusing this with a different compiler warning.  A small example:
f :: [String]
f = do
  _ <- sequence_ ["xyz", "def"]
  x <- sequence_ ["xyz", "def"]
  sequence_ ["xyz", "def"]
  return "uvy"

results in
% ghci -Wall Frag.hs
GHCi, version 8.8.3: https://www.haskell.org/ghc/  :? for help
[1 of 1] Compiling Main             ( Frag.hs, interpreted )

Frag.hs:5:3: warning: [-Wunused-matches] Defined but not used: ‘x’
  |
5 |   x <- sequence_ ["xyz", "def"]
  |   ^

% hlint Frag.hs
Frag.hs:4:3-31: Warning: Redundant variable capture
Found:
  _ <- sequence_ ["xyz", "def"]
Perhaps:
  sequence_ ["xyz", "def"]

1 hint

I think that it is still debatable that this should be warned as a "redundant variable capture".   At least it could be a suggestion.

Doing _ <- sequence_ ... is super odd, because you've bound a variable of type () to _. That's a very unusual thing to do. You could legitimately say that everything that HLint says is a suggestion rather than a warning, but this seems a perfectly sensible thing to recommend changing to me.

Thinking about this further, I can see that.  Let's leave things be.  Thanks.


Typo in Proxy-Authenticate known headers

Missing the "n" in authenticate. https://github.com/aspnet/KestrelHttpServer/blob/dev/tools/Microsoft.AspNetCore.Server.Kestrel.GeneratedCode/KnownHeaders.cs#L225

Nice catch. Thanks.


Implement $first accumulator

What should be done?
https://www.mongodb.com/docs/manual/reference/operator/aggregation/first/#mongodb-group-grp.-first
$firstN was separated to issue https://github.com/FerretDB/FerretDB/issues/3196
DOD:

[ ] implement first accumulator
[ ] add integration tests for expression { $first: "$v" }, { $first: "$v.foo" }, { $first: "$missing" }
[ ] add integration tests for composite types { $first: ["$v"] }, { $first: {"v": "$v"} }
[ ] add integration tests for scalar types { $first: "v" }, { $first: 42}

Hi @AlekSi @chilagrow Can i pickup this issue ?

@princejha95 Hey, sorry, I've already been spending some time on it, and I'm close to proposing a PR 😅

@teivah any news? Anything we could help you with?

Hey, sorry I lost the momentum, I had some issues in understanding what to do next. Let's close it, perhaps it can be a starting point for others.

@AlekSi can I pick up this issue?

@adetunjii but what about MySQL backend support?

I’ll work on it. This one seems urgent. That’s why I want to quickly get it out of the way before continuing the MySQL backend
Get Outlook for iOShttps://aka.ms/o0ukef

From: Alexey Palazhchenko @.>
Sent: Wednesday, November 29, 2023 7:31:09 AM
To: FerretDB/FerretDB @.>
Cc: Teej4y @.>; Mention @.>
Subject: Re: [FerretDB/FerretDB] Implement $first accumulator (Issue #2128)
@adetunjiihttps://github.com/adetunjii but what about MySQL backend support?
—
Reply to this email directly, view it on GitHubhttps://github.com/FerretDB/FerretDB/issues/2128#issuecomment-1831297737, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKXTHW7IVM6JNWKEZFEJ2H3YG3JC3AVCNFSM6AAAAAAVQXVJPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRGI4TONZTG4.
You are receiving this because you were mentioned.Message ID: @.***>

Ok, let's do it! 💪


Add Support for Bulk Actions

Is your feature request related to a problem? Please describe.
Add support for bulk actions on multiple lines
Describe the solution you'd like
    hostsFile.BulkCommentByIP
    hostsFile.BulkCommentByAddress
    hostsFile.BulkCommentByHostname

    hostsFile.BulkUncommentByIP
    hostsFile.BulkUncommentByAddress
    hostsFile.BulkUncommentByHostname

    hostsFile.BulkRemoveByIP
    hostsFile.BulkRemoveByAddress
    hostsFile.BulkRemoveByHostname

Also take care of Get actions as mentioned here: https://github.com/areYouLazy/libhosty/issues/15

This should also be used to normalize naming.
We have GetHostsFileLineBy... and we have CommentBy...
Choose one and refactor others

This commit refactors names, now take care of bulk actions.
About that, I like more GetHostsFileLinesBy..., maybe BulkGetHostsFileLinesBy... can be used to query for more elements, line BulkGetHostsFileLinesByIP(ip1, ip2, ip3)

So "bulk" actions as described in the issue has been implemented, however I like the idea of bulk as in the comments, like BulkGetHostsFileLinesByIP(ip1, ip2, ip3) so I will open another issue with this


*: separate Dockerfile for quay build trigger

Fix https://quay.io/repository/coreos/etcd-git/build/d75d80b1-7d8d-42bd-af07-645b7da3a118.

/cc @xiang90 @heyitsanthony
Thanks.

lgtm

Ok merging, and will see if it's fixed.

great. now fixed https://quay.io/repository/coreos/etcd-git/build/13e67fc1-020e-4f2d-a90b-70cb22ccc4cb.


Rendering imcompletely when page contains urls without protocol

When I do the below task, the result is not as that in the browser.
curl 'http://localhost:8050/render.png?url=https://www.taobao.com&timeout=10&wait=10&render_all=1' > taobao.png
The problem may be caused by the urls contained as this:
<img src="//img.alicdn.com/tfs/TB1ILwrQFXXXXXtXFXXXXXXXXXX-520-280.jpg_q90_.webp" alt="">
How to tackle with such situations?

I don't think // URLs are a problem; the following script seems to render everything on taobao for me:
function main(splash)
  assert(splash:go(splash.args.url))
  splash:set_viewport_full()
  assert(splash:wait(10))
  return {
    html = splash:html(),
    png = splash:png(),
    har = splash:har(),
  }
end


[Feature Request] Add thread and/or address sanitizers

Heyho, I am currently working my way through threading and making it as safe as can be to build my "microservice-multithreading" runtime on top of.
That includes adding tsan at the moment and in a future step asan.
I am considering sneaking balls in the test-suite in order to get that sanitizer-coverage given how it is used a fair bit to ensure correctness and getting grinds checks essentially for free would be pretty sweet.
My question becomes: Is Asan/Tsan supported and can be used?
I see it is already part of the Analyzer enum but couldn't find any further usage of it and no mention on if that means that it is automatically part of the analysis pipeline or not.
If being part of the Analyzer enum means it is part of the pipeline, then I'd suggest adding a doc comment that specifies that, potentially with links to the individual tools in the enum itself.
I'll happily make a PR to add those doc comments if desired.

We fallback to asan/tsan when valgrind isn't available.  You can either --define:ballsUseValgrind=no when compiling the runner, or define BALLS_VALGRIND=false in your environment before invoking balls in order to force the fallback.  If these don't work, it's a bug.


Discrepancy between results

Hi and thank you for a great algorithm!
Why is there discrepancy between results in tables 1 and 2?
Eg. FS L&F:
AP 43 vs 55
FPR95 15 vs 40
All the best in future developments!

Hi Tamme,
The difference is that Table 1 is the test sets for Fishyscapes while Table 2 is just the validation sets. We were only allowed one submission for Fishyscapes so we sent our best model. We couldn't do that for the ablation study.
The drop in performance is related to the difference between the two sets and also some overfitting the model had with the validation set. The test sets are significantly larger than the validation sets and cover more objects in different scenarios.

Hello,
I could not find seperate  dataset for validation and testing. As even the validation dataset is same as test_dataset3 (fs lost and found). And as far as I have understood with the datasets provided in the repo we can reproduce only table2.
I would be grateful if you provide the dataset which you used to find metric in table1.
Thank You


New version: evilmartians.lefthook version 1.6.5

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Hi @mrexox,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 857.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-03-04 04:49:50.211 [FAIL] Installer failed security check. Url: https://github.com/evilmartians/lefthook/releases/download/v1.6.5/lefthook_1.6.5_Windows_i386.exe Result: 0x80004005

(Automated response - build 857.)

@wingetbot run

@wingetbot run


Eliah Kagan: Watch CFTManager.com

Eliah Kagan requests the watch of the watch_keyword CFTManager\.com. See the MS search here and the Stack Exchange search here.

CFTManager\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ

This domain doesn't appear in any posts that have been reported so far, but it appeared in two spam posts on Stack Overflow that have since been deleted:
https://chat.stackexchange.com/transcript/message/53026505#53026505
(Attempts to report the posts to SmokeDetector was not successful, possibly due to a bug: https://chat.stackexchange.com/transcript/message/53026589#53026589)


Support for H6099 - RGBIC TV Backlight 3 Lite

Which model is this? Need the Hxxxx number.
H6099

Which type of device is this? Light, heater, leak sensor, etc.
TV Lights

Which connection methods does this device have? Wifi? Bluetooth? LAN mode? All?
WiFi & Bluetooth

Anything else?
I created this GitHub account just to submit this request! So far very impressed with homebridge. Thanks

Me too
[Govee TV] is not currently supported, do create a Github issue with the following info:
{"device":"7A:75:CD:39:32:35:76:47","deviceName":"Govee TV","model":"H6099","httpInfo":{"groupId":0,"device":"7A:75:CD:39:32:35:76:47","sku":"H6099","spec":"","versionHard":"3.05.01","versionSoft":"1.00.05","deviceName":"Govee TV","deviceExt":{"deviceSettings":"{"wifiName":"NSFW","address":"CD:39:32:35:76:47","bleName":"Govee_H6099_7647","topic":"GD/95f5e35bb72f5e07751301ac7bc32a7c","wifiMac":"60:74:F4:8F:D7:EB","pactType":1,"pactCode":1,"wifiSoftVersion":"1.00.12","wifiHardVersion":"1.06.00","ic":36,"secretCode":"kJjNOTI1dkc=","boilWaterCompletedNotiOnOff":1,"completionNotiOnOff":1,"autoShutDownOnOff":1,"sku":"H6099","device":"7A:75:CD:39:32:35:76:47","deviceName":"Govee TV","versionHard":"3.05.01","versionSoft":"1.00.05","playState":false}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/784ef9170ab66ccdaf137d29963f5476-add_list_type_device_6099.png\",\"headOnImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/42d0585f82d3c6c93b50534f9e9b3804-new_light_title_h6104_alexa_on.png\",\"headOffImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/5098709790bf157447ed1f8e0b65c2ad-new_light_title_6104_alexa_off.png\",\"ext\":\"\",\"ic\":50}"},"pactType":1,"pactCode":1,"share":0,"goodsType":191,"attributesId":1,"supportScene":1}}

It would be great to get a working plugin for my new Govee T3 Backlite:
{"device":"18:C3:CF:38:32:34:14:48","deviceName":"RGBIC TV Backlight 3 Lite","model":"H6099","httpInfo":{"groupId":0,"device":"18:C3:CF:38:32:34:14:48","sku":"H6099","spec":"","versionHard":"3.05.01","versionSoft":"1.00.05","deviceName":"RGBIC TV Backlight 3 Lite","deviceExt":{"deviceSettings":"{"wifiName":"FRITZ!Box 7490","address":"CF:38:32:34:14:48","bleName":"Govee_H6099_1448","topic":"GD/c95d709814fc6c3c28ed213021dfa3a7","wifiMac":"D4:AD:FC:DF:A1:74","pactType":1,"pactCode":1,"wifiSoftVersion":"1.00.13","wifiHardVersion":"1.06.00","ic":36,"secretCode":"B4DPODI0FEg=","boilWaterCompletedNotiOnOff":1,"completionNotiOnOff":1,"autoShutDownOnOff":1,"sku":"H6099","device":"18:C3:CF:38:32:34:14:48","deviceName":"RGBIC TV Backlight 3 Lite","versionHard":"3.05.01","versionSoft":"1.00.05","playState":false}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/784ef9170ab66ccdaf137d29963f5476-add_list_type_device_6099.png\",\"headOnImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/42d0585f82d3c6c93b50534f9e9b3804-new_light_title_h6104_alexa_on.png\",\"headOffImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/5098709790bf157447ed1f8e0b65c2ad-new_light_title_6104_alexa_off.png\",\"ext\":\"\",\"ic\":50}"},"pactType":1,"pactCode":1,"share":0,"goodsType":191,"attributesId":1,"supportScene":1}}

+1 for plugin support!
[RGBIC TV Backlight 3 Lite] is not currently supported, do create a Github issue with the following info:
{"device":"1E:80:CC:38:32:34:55:73","deviceName":"RGBIC TV Backlight 3 Lite","model":"H6099","httpInfo":{"groupId":8635317,"device":"1E:80:CC:38:32:34:55:73","sku":"H6099","spec":"","versionHard":"3.05.01","versionSoft":"1.00.05","deviceName":"RGBIC TV Backlight 3 Lite","deviceExt":{"deviceSettings":"{"wifiName":"DIGI-PDE-N","address":"CC:38:32:34:55:73","bleName":"Govee_H6099_5573","topic":"GD/feb9b2df499195ed517106561ba92259","wifiMac":"D4:AD:FC:B4:6B:94","pactType":1,"pactCode":1,"wifiSoftVersion":"1.00.13","wifiHardVersion":"1.06.00","ic":36,"secretCode":"96XMODI0VXM=","boilWaterCompletedNotiOnOff":1,"completionNotiOnOff":1,"autoShutDownOnOff":1,"sku":"H6099","device":"1E:80:CC:38:32:34:55:73","deviceName":"RGBIC TV Backlight 3 Lite","versionHard":"3.05.01","versionSoft":"1.00.05","playState":false}","lastDeviceData":"{"online":false}","extResources":"{"skuUrl":"https://d1f2504ijhdyjw.cloudfront.net/sku-img/784ef9170ab66ccdaf137d29963f5476-add_list_type_device_6099.png\",\"headOnImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/42d0585f82d3c6c93b50534f9e9b3804-new_light_title_h6104_alexa_on.png\",\"headOffImg\":\"https://d1f2504ijhdyjw.cloudfront.net/sku-img/5098709790bf157447ed1f8e0b65c2ad-new_light_title_6104_alexa_off.png\",\"ext\":\"\",\"ic\":50}"},"pactType":1,"pactCode":1,"share":0,"goodsType":191,"attributesId":1,"supportScene":1}}

Would really appreciate support for this light!

Hey guys, sorry for delay on this, please check the beta version of the plugin :)

Hey guys, sorry for delay on this, please check the beta version of the plugin :) @bwp91

Thank you for your work!
I've setted up.
-Settings fine (AWS not tested)
-Homekit shown perfectly
-Colour mode/adaptive mode work perfectly.
-Turn on/off work perfectly.
*One note only, i notice a little bit of lag when change anything. Used with BLE.

Thank you! Beta is working well for me too, using AWS. Seems quite responsive.


Adds rate_limit_per_user to ChannelEdit

This PR adds a new field of the Channel object called rate_limit_per_user. It can be used to implement a slowmode in a channel.
(I tested the functionality of the field, it works.)
Documentation: https://github.com/discordapp/discord-api-docs/pull/691

CI error seems to be unrelated to my change.


Fix a bug causing reachable servers to be marked as 'Unavailable'

I've had a lot of trouble getting the test suite to work on my local machine. It seems to me like the root cause is the disconnect! method prematurely marking a server as down. If the retry logic is supposed to make any sense, and we were ever able to (and still able to) connect to the server, it shouldn't be marked as down. The request should be retried. If we still run into errors past our retry count BUT we're able to connect to the server then we should raise whatever exception it is that we're actually getting.
I also cleaned up the next_live_server method a bit.

Closing out all old PRs to this repo. Please reopen if you'd like further consideration!


Remaining structural changes to support new osb version

Changes in this PR:

Adding support for maintainance_info , instance_usable, and update_repeatable features of new version in OSB Spec
Adding config for supporting metadata field in binding response
Adding support for specifying list of parameters returned for get instance endpoint

Feature: HCPCFS-2938

Pull Request Test Coverage Report for Build 5284

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 89.216%

Totals

Change from base Build 5277:
0.009%

Covered Lines:
9559

Relevant Lines:
10344

💛  - Coveralls

Validation on k8s cluster: n-2 is succeeded.

Validation on k8s cluster: n is succeeded.

Validation on k8s cluster: n-1 is succeeded.


feat:added plugins chips filter in microsite

Hey, I just made a Pull Request!
New chips filter by category for Plugins page in the microsite to make easier to find out the plugnins you are looking for

:heavy_check_mark: Checklist

[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Closes #13014

Hi! still interested on have some feedback on this 🤗

Hi @antoniobergas, sorry for the slow follow up. I really appreciate the work you've done I just feel like this design/implementation puts a lot in front of the user at once where as a proper drop down would be much cleaner. I also think the list could get very long which means this could get so big that we don't even see the actual content till we scroll.
Sorry, not trying to diminish the work you've done

Hi @awanlin, yes that make totally sense I didn't think in that. So I will back to the multi dropdown. Any suggestions for show which categories you have selected?
What I can do maybe it's combine it, so the dropdown at the right side and when you select any category the chip shown at the left?
Does that make sense from a user perspective?

Sorry @antoniobergas, I should have shared what I was thinking about this. My thought was to have something a lot like what we already see in Backstage itself. So like the way the OwnerPicker looks and works:

But this is much easier said then done seeing as you have to figure out how to do that with Infima

No problem 😄 thanks for the sharing, now that the base is more or less done I will see what I can get to show properly to the user 👌

I changed the chips with a multi dropdown. I think the result is good 😄

Unfortunately I have a weird issue with the styles. First time I load the page with yarn start the label styles are overrited and after refresh they have the custom properties I used

Does anyone have an idea why is this happening?

After some tests removing infima dropdown classes and my custom scss still having the issue.
I will continue debugging, any suggestions will be apreciatted, have not much experience with docosaurus 😅

At the end was the label tag for some reason, after change it to a div everything works fine 😄

Hey is there a way I can re-run the build? I tested locally with node 16 and works fine

Hey is there a way I can re-run the build? I tested locally with node 16 and works fine

I'll trigger it to see but I think it might be due to this: https://github.com/backstage/backstage/pull/17549

Thanks for pointing me in the right direction! 🤗


Improve ease of using about and settings menu items

I'm submitting an ease of use suggestion

[ ] Bug report
[ x] Feature request
[ ] Documentation issue or request

Current behavior
The menu items active states are independent from about and settings menu items. Now I have to use a state machine to manage the states of the nav bar items to avoid two or more items are active at same time. Now the about and settings menu items only have the close event for the up right corner button,  however click the about or settings icon can also toggle the content. It is hard to get the expanding and collapse events of them.

Expected behavior
Add expandChange event support for about and settings content

As described the home and settings nav items are active at the same time
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Improve ease of use

Hi @chencc1988,
thanks for your input.
The current behavior of the About and Settings is a conscious UX decision. The motivation behind is to keep the actual working content in place. Changing some settings or having a look at the about info will not navigate you away from your main working content. It will just overlay it temporarily – like a fullscreen modal. And therefore the underlaying content keeps its selected state to indicate it is still open in the background.
Unfortuately, there was a bug that prevents the overlays from getting automatically closed after another navigation item is clicked. And this might have confused a bit in understanding the concept behind. But this has been fixed with the latest release.
That means the About/Settings overlay will close on three ways:

clicking the close button
clicking the same icon again
clicking another nav item

So we see currently no further necessary changes.


udev can't find hokuyo_node

When I run udevadm test $(udevadm info -q path -n /dev/ttyACM0) to check if everything is working correctly, I received this
PROGRAM '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q' /etc/udev/rules.d/99-hokuyo.rules:1
starting '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q'
'/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q'(err) '[rospack] Error: package 'hokuyo_node' not found'
Process '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q' failed with exit code 2.

Next, I change line /home/user/ros_workspace/devel/setup.sh in the /etc/ros/ros_run.sh to
#!/bin/sh
. /opt/ros/kinetic/setup.sh
. /home/user/ros_workspace/devel/.private/hokuyo_node/setup.sh
rosrun $@

and then everything worked well:
PROGRAM '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q' /etc/udev/rules.d/99-hokuyo.rules:1
starting '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q'
'/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q'(out) 'H1520031'
Process '/etc/ros/ros_run.sh hokuyo_node getID /dev/ttyACM0 q' succeeded.

I forgot about it and again spent half my life to do it... AAAAAAAAAAAAAaaaaaaaaa


VC/Clock: Added external inputs for controlling countdown/stopwatch

As requested here I added external input support for the clock widget in countdown and stopwatch mode.
I was not yet able to test feedback, but will this weekend.
I'm not completely sure about the order in the properties dialog but think as it is now is sufficient.

Tested and it's working pretty well. Feedbacks seems to be OK too.
Well done !
I just took the liberty of changing the config page layout a bit cause when external input was enabled, the page got too crowdy. A tab solution is cleaner (e.g. see audio triggers widget)

Tabs are much better, but I think it is a bit confusing that the Input tab is empty when selecting clock. Maybe the input widgets can be grayed out in this case?

I agree, and I already tried to hide the input tab when selecting the clock mode.
Unfortunately Qt doesn't provide a way to just hide a tab. You need to destroy it and recreate it later.
I think the easier solution for now is to just display a text saying "No input controls available in clock mode"

Done a135b63a3c50924aeb2bbce9c390a2fab4460ebc


PR: Update installer workflows to run as release on push of release candidate tag

Description of Changes
The installer workflows will now run the same way for both a release event or a push of a release candidate tag.

Pushing a tag of the form v*rc* (e.g. v5.4.2rc1) will run these workflows in the same manner as a release
Artifacts are uploaded, but not uploaded to a release.

Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

One additional question: I think we should include this for 5.4.2, right? Or do you prefer to leave it for 5.4.3?

One additional question: I think we should include this for 5.4.2, right? Or do you prefer to leave it for 5.4.3?

I think we can include it for 5.4.2. I'll adopt your recommendations and push it up.

Thanks @mrclary ! Maybe could be worthy to add some documentation regarding the way to trigger this in the RELEASE.md file (maybe some instructions to do a pre-release tag after the PR updating the core dependencies is merged?).

That's a good idea. Can you or @ccordoba12 help out with that? I'm not sure exactly how you guys want to re-arrange the procedure there. Carlos and I discussed before publishing and before uploading to PyPi and conda-forge

change version to vX.X.XpreX in __init__.py
create tag vX.X.XpreX and push to upstream
If all is well, proceed with release, otherwise make correction PRs and repeat

Should we incorporate doing the pre-release as an extra step to do as part of the release process, right?

I think that is correct.

Okay, @dalthviz @ccordoba12, I took a stab at updating the RELEASE.md file. I just put the release candidate instructions after the core dependencies and before doing the release.

That's a good idea. Can you or @ccordoba12 help out with that?

Yep, I'll additional steps for that (along the lines you described above) to our release guide.


CAMEL-15270: camel-main can configure route templates from properties files.

The example is here
https://github.com/apache/camel-examples/commit/838500392cc5fe9333ba9ed38fc78f360ef74152

@lburgazzoli mind taking a look as its for route templates / kamelets


Funimation unable to download subtitles

Program version
2.0.14
Service
Funimation US
Command used
node index.js --service funi -s 73113 -e 01-02 --dubLang jpn --dlsubs all --allSubs --noaudio --novids --simul
Show ID
73113
Episode
01-02
Console Output
=== Multi Downloader NX 2.0.14 ===

[#73113] Burst Angel (2004)
[INFO] Episodes not selected!

In some series the listing of episodes does not display correctly, I was just doing a test, seeing if it was possible to download the subtitles of this series, but as you can see it does not find the episodes. I also tested with yt-dlp and it also showed error in this series.
I tested with another series, I managed to download the audio, video and subtitles, but only the subtitle presents this error, I would like to know if I am the wrong command in this case.

=== Multi Downloader NX 2.0.14 ===

[#23715] Claymore (2007)
[0001] Claymore - #01 Great Sword (22:54) [HD1080, English, Japanese, Spanish, Portuguese] (selected)
[0002] Claymore - #02 The Black Card (22:54) [HD1080, Japanese, English, Spanish, Portuguese]
[0003] Claymore - #03 The Darkness in Paradise (22:54) [HD1080, English, Japanese, Portuguese, Spanish]
[0004] Claymore - #04 Clare's Awakening (22:54) [HD1080, Japanese, English, Portuguese, Spanish]
[0005] Claymore - #05 Teresa of the Faint Smile (22:54) [HD1080, Japanese, English, Portuguese, Spanish]
[0006] Claymore - #06 Teresa and Clare (22:54) [HD1080, English, Japanese, Portuguese, Spanish]
[0007] Claymore - #07 Marked for Death (22:54) [HD1080, English, Japanese, Portuguese, Spanish]
[0008] Claymore - #08 Awakening (22:54) [HD1080, English, Japanese, Spanish, Portuguese]
[0009] Claymore - #09 Those Who Rend Asunder I (22:54) [HD1080, Japanese, English, Spanish, Portuguese]
[0010] Claymore - #10 Those Who Rend Asunder II (22:54) [HD1080, Japanese, English, Portuguese, Spanish]
[0011] Claymore - #11 Those Who Rend Asunder III (22:54) [HD1080, English, Japanese, Portuguese, Spanish]
[0012] Claymore - #12 The Endless Gravestones I (22:56) [HD1080, English, Japanese, Portuguese, Spanish]
[0013] Claymore - #13 The Endless Gravestones II (22:56) [HD1080, Japanese, English, Portuguese, Spanish]
[0014] Claymore - #14 To Be Qualified to Fight (22:56) [HD1080, English, Japanese, Portuguese, Spanish]
[0015] Claymore - #15 The Witch's Maw I (22:56) [HD1080, Japanese, English, Portuguese, Spanish]
[0016] Claymore - #16 The Witch's Maw II (22:56) [HD1080, Japanese, English, Spanish, Portuguese]
[0017] Claymore - #17 The Witch's Maw III (22:56) [HD1080, Japanese, English, Portuguese, Spanish]
[0018] Claymore - #18 The Carnage in the North I (22:56) [HD1080, English, Japanese, Spanish, Portuguese]
[0019] Claymore - #19 The Carnage in the North II (22:56) [HD1080, English, Japanese, Spanish, Portuguese]
[0020] Claymore - #20 The Carnage in the North III (22:56) [HD1080, English, Japanese, Portuguese, Spanish]
[0021] Claymore - #21 Invasion of Pieta I (22:56) [HD1080, Japanese, English, Portuguese, Spanish]
[0022] Claymore - #22 Invasion of Pieta II (22:56) [HD1080, English, Japanese, Spanish, Portuguese]
[0023] Claymore - #23 Critical Point I (22:56) [HD1080, English, Japanese, Spanish, Portuguese]
[0024] Claymore - #24 Critical Point II (22:56) [HD1080, Japanese, English, Portuguese, Spanish]
[0025] Claymore - #25 For Whose Sake (22:56) [HD1080, English, Japanese, Spanish, Portuguese]
[0026] Claymore - #26 To the Successors (22:56) [HD1080, Japanese, English, Portuguese, Spanish]

[INFO] Selected Episodes: 0001

[INFO] Claymore - S1E1 - Great Sword
[INFO] Available streams (Non-Encrypted):
[#24003] English [Uncut]
[#24070] Japanese [Uncut] (selected)
[#1957508] Portuguese (Brazil) [Uncut]
[#1957361] Spanish (Latin Am) [Uncut]
[INFO] Servers available:
        vmfst-api.prd.funimationsvc.com
[INFO] Available qualities:
         1: 416x234 (464KiB/s)
         2: 640x360 (713KiB/s)
         3: 768x432 (1125KiB/s)
         4: 768x432 (1542KiB/s)
         5: 960x540 (2499KiB/s)
         6: 1280x720 (3730KiB/s)
         7: 1280x720 (5384KiB/s)
         8: 1920x1080 (6883KiB/s)
         9: 1920x1080 (9118KiB/s)
[INFO] Selected layer: 7 (1280x720) @ vmfst-api.prd.funimationsvc.com
[INFO] Stream URL: https://vmfst-api.prd.funimationsvc.com/FunimationStoreFront/V1703451/f751528f-9dfc-4c7f-b08f-b2296b4b930bstrnv-hl152_streaming_video_1280_720_4500000_index.m3u8?Key-Pair-Id=APKAIHNXECY27H4O6NIA&Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly9kMzNldDc3ZXZkOWJnZy5jbG91ZGZyb250Lm5ldC9GdW5pbWF0aW9uU3RvcmVGcm9udC9WMTcwMzQ1MS8qIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNjQwOTAxMzE1fX19XX0_&Signature=fPpgqPruvGG38Ydy8DK0mrPz5JNsBVLzQuAqNQZy8Jni1832osIqJXXePS6dAaagsxM5KXrNv8r4bDesnk5-74c-0sprS2aT4ngcjkMPa0drVJ5EY5IefYZ32V7o4nJhOyDZwMVmk~XI6X9eJqWUtgPsQcGFl1Srdya08UIED0NvYkXrJiy8qv4W8-ZHzOxJR-8yFba~HIScxaSF7KRjSYtQyOOCg7WcxTI5AZbWGT98TXvniUH2Ljb98UhDG5k-NQlqPO2UqgSRoGmMfvLH9jvCHUK37OcJP3mFJ3pMLqnYr6vj1nq4NvJtjh71dl-j0Zh3UrvPycPaem9dj2YZIA__&rt=1368701
[INFO] Output filename: [Funimation] Claymore - S01E01 [720p].ts
[INFO] Skip video downloading...

[INFO] Unable to locate a video AND audio file

I don't know what's the problem with the first series, but regarding the second one, only using --service "funi" -s 23715 -e 1 --noaudio --novids has worked for me.

I don't know what's the problem with the first series, but about the second one, using only --noaudio and --novids has worked for me.

I used this option, and it was this option that presented this error on my computer.


react-devtools -> redux-devtools

lol thanks

I also lol'd at this, but dammit if I haven't mistyped it about seven times since then. It's a shame that both libraries start with the same two characters.


Cannot upload to online Arduino editor

In order to upload this library to the online arduino editor, there must be a file called library.properties in the root folder.
https://github.com/neu-rah/Arduino-VirtualPins/wiki/Arduino-IDE-1.5:-Library-specification
I am trying to create this file, but it would be great if it could be part of the distribution to make it easier for everyone.

Thanks for the suggestion, it has been added, you can download it via Arduino IDE


Wsl from Microsoft Store not yet compatible with release of custom kernel versione 6.X (6.0,6.1,6.2-rc)

Version
Microsoft Windows [Versione 10.0.19044.2364]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
6.0.19
Distro Version
Ubuntu 22.04.1
Other Software
my custom kernel for WSL 2 from my github
https://github.com/WinSSitaly/WSL-Linux-Kernel
Repro Steps
after doing all update
sudo apt update && sudo apt upgrade && sudo apt autoremove && sudo apt dist-upgrade && sudo do-release-upgrade
Windows Subsystem for Linux Update - <IP_ADDRESS> (black penguin)
and then update wsl to version microsoft store
wsl -update
(blue penguin)
custom version of kernel 6.X cannot start more
Expected Behavior
before update, using version CAB installer all was ok
after version from Microsoft Store error not start more
Actual Behavior
after update to version from Microsoft Store error not start more
Diagnostic Logs
not yet a way to log it

Error code: Wsl/Service/CreateInstance/0x80072746

@WinSSitaly not using your kernel configs, linux-6.1.6 boot okay on WSL <IP_ADDRESS>. The config file from WSL2-Linux-Kernel/Microsoft/config-wsl was used and sanitized to build the new kernel. After wsl --shutdown the new kernel loads w/out errors:
toor@XPS:~$ uname -a
Linux XPS 6.1.6-microsoft-standard-WSL2 #1 SMP Mon Jan 16 09:20:37 PST 2023 x86_64 x86_64 x86_64 GNU/Linux


informational overlay:Redesign UI of hotkeys info modal to modern one

Improve UI of the keyboard shortcuts info modal.
Mainly, reducing using borders.
Before

After

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! I like overall direction, but a few thoughts on how to iterate:

The actual keys looks quite small to me within their box. Can we align the design for the keys with #22746?
I don't think it makes sense to add the background blurring behind the modal effect just here, as it makes it inconsistent with other overlays (e.g, settings). Let's drop it from the PR; we can have a separate discussion about it #design if you like.
The bottom button design doesn't match other buttons in the app. I'd be inclined to just keep it as a link for now, unless @terpimost has a better suggestion.

@alya
Here is the fixed commit!

I suggest to:

make color of the hot key in the light theme as #466ae8
decrease padding inside a hot key (.informational-overlays kbd) to padding: 1px 0.5em;
decrease padding inside a table row to padding: 0.5rem 0;
decrease gap inside the row (.hotkeys__table-row) to gap: 0 0.4rem;
change grit template in a row to grid-template-columns: 1fr 1.1fr;
.hotkeys__title to margin: 0
.hotkeys__table to  margin-bottom: 2rem;
In search filters make left column narrower

style of tabs is new... I suggest to stick to the old style unless we want to redesign them, which I guess should be a separate PR?

Thanks for your feedback @terpimost.
I updated this PR. How about this one?

Now we should polish the dark theme

Fixed to apply dark theme correctly.
Could you review this?
@terpimost

Thanks! A few comments from manually testing the PR.
Keyboard shortcuts tab

The "or" between keys looks too faint / hard to read to me in light mode. Can we make it a bit darker?
It looks like there's a missing space before "then":

Message formatting tab

The text in the right column should be the same color as the text on the left, not greyed out.
Can we get the keyboard shortcuts left-aligned with the text above? I think that would look better than having them slightly shifted to the right, as the currently are.

Hm, I wonder if the dark theme changes didn't get pushed properly? It still looks broken when I test it:

Thanks for your feedback @alya !
I updated the commit so please check this one.

Text colors were made darker to improve readability.
Added margin after "then".
Removed the margin of some keyboard shortcuts in the Message Formatting tab to make them left-aligned.
The dark theme bug is fixed, at least on my environment.

Thanks! There still seems to be something of with the font in the right-side column on the message formatting tab. Is the weight of it really light in some rows?
I think this looks good:

But this looks odd; the font weight should be the same as on the left:

Looks good to me otherwise!

@alya
Now I fixed font-weight issue.

Cool, thanks! The screenshot looks good, so I think this PR will be ready for a code review from @amanagr once it passes tests.

@amanagr
Now I have fixed the errors and split the commit for review.

I think we can move some rows to be single line like italics and bold,

Seems simple enough to do too.

Based on the discussion here, @Taiki-Choda I think this PR might be ready for @timabbott 's review once the merge conflicts have been resolved.

@Taiki-Choda Would you be up for resolving the conflicts?

discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/keyboard.20shortcuts.20reference

@Ddharmani3 should we close this in favour of  #25979 ?


Hiding JEI categories in CT does not work as expected

Issue Description:
JEI hiding through CT does not work as expected
What happens:
issue still persists:

What you expected to happen:
for the tank, generators, and charging JEI support categories to be hidden
Steps to reproduce:

code for hiding desired categories in JEI: here
run with CT, EiO, and JEI
see the issue

Affected Versions (Do not use "latest"):

EnderIO: 5.0.40
EnderCore: 0.5.45
JEI: <IP_ADDRESS>9
Minecraft: 1.12.2
Forge: 2823
SpongeForge? no
Optifine? no
Single Player, client

Your most recent log file where the issue was present:
N/A
Note: It might be a possibility that another mod could be causing this, but I'm not sure. I did recently update EiO to latest and the issue came out of nowhere, so it might have to do with just that.

What do we have to do with CraftTweaker's features?
Use our config flags to disable those categories, If they don't work, we're the right people to fix it.

sorry, just looked at the CT repo, i see the issue there.
https://github.com/CraftTweaker/CraftTweaker/issues/755


ROX-18482: Implement notification converter

Description
This PR implements the notification converter.
The event converter's main responsibility is to convert a structured log entry to a storage.Notification.
For our current logging library we use zap. The main thing for the converter is that it has to convert the "context", i.e. the zap.Fields to a map[string]string, which will later on be used to present to the user within the API / UI.
To correctly encode the fields to their appropriate type, a ObjectEncoder had to be implemented. The object encoder's main responsiblity is to encode a field value to a string value (opposed to the existing encoders within zap, which either encode
these to JSON values or interface{} values).
As an alternative, one could have also implemented the Core interface, as this also has direct access to the field. However, that would have increased the scope of the implementation hence decided not to pursue this (at the very least, for the time being).
Few caveats:
The converter currently does the following:

Map the zapcore.Fields to labes, i.e. a map[string]string.
For each field, only send "resource relevant" fields as notification.
Introduce hints / domains based on resources and module paths.

Not all fields that can be set via zap.Field are currently converted. The reason is that the benefit of exposing those isn't necessarily clear to me at this current time(e.g. why would we want to expose an array of objects / a complete struct).
If we want to support those, we simply have to implement the interface accordingly.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

see unit tests.

Current dependencies on/for this PR:

master

PR #7257

PR #7423

PR #7424   👈

This comment was auto-generated by Graphite.

/retest

/retest

/retest


Reg : Realsense Support in MRS simulation

Hi,
I was attempting to use the realsense binaries such as rs-pointcloud, rs-depth etc.
The primary aim was to use the launch files from https://github.com/ctu-mrs/realsense and  https://github.com/IntelRealSense/realsense-ros to convert and use the depth clouds created by the realsense.
The realsense within the mrs-simulation is not detected by the system and thus I was not able to figure out the port configurations of the same (port is needed by the launch files in https://github.com/IntelRealSense/realsense-ros).
Is it possible to use the realsense binaries in the simulation? If so, would it please be possible to share the steps required for the same?
Thanks

There's no need to use the realsense-ros package in our simulation. If you spawn a UAV with a realsense sensor (e.g., using --enable-realsense-front in the drone spawner command), the simulation will publish the topics characteristic for the topics published by realsense-ros.
For example, running the above option gives me topics /*/front_rgbd/* topics, including the depth on /*/front_rgbd/aligned_depth_to_color/image_raw. If you need to convert depth to point cloud, you have to convert it yourself or you may use depth_image_proc.

Thank you for the helpful and insightful inputs. This was really helpful.