Is this library intended to be used in a browser with webpack?

The library is called: "Node.js module that detects bots/crawlers/spiders via the user agent". Does it imply that it's suited to node.js environment only?
We were able to successfully use it the browser with Webpack. Was it intended to be used this way too? Do you know some potential pitfalls? Is it safe to use it way on production?

It should work fine in a browser, don't see a problem with that


UX/UI: Wallet Mobile Nano Contract Integration

The Wallet Mobile Nano Contract Integration has 4 flows until now.
Here are only depict the happy path of all them.
To see interactions and instructions, please access the Figma File here.

Flow 1: Nano Contract Transactions

~ Address edition selector ~

Flow 2: Nano Contract Registration

Flow 3: Modal

Flow 4: Tokens Screen

Reviewer: @pedroferreira1

I have some considerations regarding the screens:

Screen 2.1.1: the button name should be something else, what do you think about  "Confirm new address"?
Flow 3 screen 1: dApp details message: where did the text on top come from? I think we could re-write it.
Flow 3 screen 3.1: The message could be "Transaction successfully sent." and the button "Close". We agreed that on close we wouldn't go to any other screen, we would go back to the screen the user was seeing before.

Changed!
This message came from other examples of connecting a dapp, like uniswap does. They have a security message, and talking to Abadesso, he recommended to have one here as well. We could talk further to adapt  it if does not make sense for that modal.
Yes, thats right. Changed.

It is approved.

Hello everyone,
I would like to provide some feedback regarding the UX/UI: Wallet Mobile Nano Contract Integration. Perhaps we should aim for a more modern and engaging approach. Some have stated that it looked like a design from years ago, that shows that the aesthetic of the wallet caused many of community members to wonder if these screenshots were from 2019.
We are part of the community and we would love to participate and help however we can to support the team and make this project grow!

Hello! :)
Thank you for your suggestion. We have indeed started working on UI/UX redesigns of both the mobile and desktop wallets. However, we are not expecting to have the new design ready before the launch of Nano Contracts and we didn't want to implement a new design only in the new screens for nanos... So, when we launch it, it will be implemented across all pages at the same time.


run image embedding for each fold

Fix pipeline to run image embedding twice (one for each fold name them)
2.image_embedding_1
2.image_embedding_2. (_# is the fold)
Then have 3.coembedding_1, and 3.co_embedding_2 take the _1 and _2 image embeddings
respectively
Then have generate hierarchy take multiple coembeddings directories as input

Fixed in 0.1.0a8


Remove the screenshots from your Git index

That is more non-needed bandwidth taken when people will install your plugins in Neovim!

Where to store them then?

You can open an issue in any github repository and drag and drop the image there. It will generate a link for you.

Fixed in https://github.com/gorbit99/codewindow.nvim/commit/dad18164f8c53dbc59670187cdd4f250f4f1c4af


fix sub function return check

Our phpcs standards fail for sub function return checking.
This should fix it.
expected: nothing
old: failure, new: nothing
function first()
{
    /**
     * @return bool
     */
    function second()
    {
        return true;
    }

    second();
}

expected: failure
old: failure, new: failure
function first()
{
    /**
     * @return bool
     */
    function second()
    {
        return true;
    }

    return second();
}

TIL: PHP does subfunctions.
I'm confused by the description. Which example is supposed to be incorrect? The one with the return or the one without? Without any other context, the one without the return appears in incorrect but it has been added to the examples file as an example of correct code.

The one without is correct is there is no doc comment above it with @return.
updated the description, make more sense?

Oh, I see. The point of it is whether or not a doc block is present. I was focusing too much on the validity (or not) of the absent return statement. It makes sense now.


Swap Gravatar for Github

@darkboywonder - ideas for how we should do this? I'm assuming we don't want to switch out auth to do this via Socialite? Github's Search User API is also a good option but it doesn't seem like the best way to be able to retrieve our user since we don't have the ability to search by the email domain name and I don't think we can combine the in qualifiers.


Feature: Icon themes (+bundling the Seti UI theme)

While investigating the file explorer, I wanted to include file icons - so I split this out as a separate change. The package format is very similiar to VSCode (such that, ideally, we could also load VSCode's icon themes).
The icon theme is controllable via the ui.iconTheme property (and can be sent to null if you do not wish to have icons). The default theme right now is the popular seti-ui theme.

File icons are only shown when tabs.mode is set to buffer (the default) - if you are using tab, we do not set a file icon.

@bryphe Chiming in a little bit late, but shouldn't this be unrelated to whether tabs mode is buffer or tabs (e.g. introducing a ui.showTabIcons = true|false option)?

@badosu - I wasn't sure if I could reliably get the file type for tabs, since it's possible to rename tabs AFAIK (and the icons are based off the filenames). If it's something that is desired, we could look at putting the file icon for the last active buffer in that tab, perhaps?

I also considered just putting a vim/neovim logo for tabs

Did not know about the tab renaming issue, thanks for the clarification 👍


Bump crossplane-runtime for updated ReclaimPolicy semantics

Description of your changes

Fixes #99
This PR migrates stack-gcp to a build of crossplane-runtime that:

Does not make resource claims the controller reference (or any kind of owner reference) of managed resources.
Uses the managed resource's reclaim policy to determine whether it is deleted when its resource claim is deleted, with the exact same semantics as the upstream persistent volume reclaim policy.

I'm leaving this in draft until https://github.com/crossplaneio/crossplane-runtime/pull/87 is merged and there's a new crossplane-runtime release this PR can depend on, instead of my branch. I'm going to test this by dynamically provisioning a CloudSQLInstance, then restarting the Crossplane and Kubernetes control planes a bunch to ensure nothing is unexpectedly deleted.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the dependencies in app.yaml to include any new role permissions.

I'm going to test this by dynamically provisioning a CloudSQLInstance, then restarting the Crossplane and Kubernetes control planes a bunch to ensure nothing is unexpectedly deleted.

I did that - it's still there. I'm going to leave stack-gcp running on my laptop overnight just in case.

Confirming that my CloudSQLInstance is still up and running. The various control plane processes (stack-gcp, crossplane, kube-controller-manager, etc) have all been running overnight and I see a reconcile attempt logged every minute by stack-gcp as expected.


Wrong case on filename if outputBy is "NamespacePath"

bridge.json
{
    output: "Bridge\\output",
    outputBy:  "NamespacePath"
}

Demo.cs
using Bridge;

namespace Demo.Utils
{
    public class App
    {
        public string Test { get; set; }
    }
}

demo > utils.js is expected, but demo > Utils.js is created.

Fixing this will ultimately lead to an inconsistency when absolute paths are used (as explicitly required by issue #57).
When an absolute path is provided, it is not possible to identify what is a FS directory (thus casing should be preserved) and what pertains to the project naming scheme.
Said that, I think the best approach here is to develop a solution that does not perform camel casing conversion when the path is absolute, starting with a drive letter.

At this point I don't see a problem treating absolute paths as a special scenario. Everything but the final fileName could ignore the casing config. Maybe absolute paths should be removed, and only available to set on the output config within bridge.json. I'd be fine with that approach.

I'd love to reopen that issue and make absolute paths not an option anymore! (all constrained inside bridge's output directory that's always set on bridge.json)

Agreed. Let's get ride of that absolute path functionality. It will only exist on the output global config.

Misreferenced commit #e41ec5 which applies fix here.


Add task to restart lsync after repo-build

(cherry picked from commit 5bd4eee9f8e6d018182ee391acec77e3cea6a347)

This is already taken care of in #415 :-1:

ok, closing this one


Updates Application ELB dashboard

Checked to validate that we can upload the dashboard to Lightstep and
get back the same.

This works with terraform apply but terraform apply has no guarantees


It breaks when using options for {{create-tracked-ref}}

When I try to use:
<div {{create-tracked-ref "foo" attributes=true}}>Polars</div>

Throw error:

5.0.2 published

It was fast, thanks @lifeart !


update gisce/react-formiga-table to v1.0.0-alpha.7

Automated changes by create-pull-request GitHub action

:tada: This PR is included in version 2.0.0-alpha.47 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add release pipeline

When new tag matching a filter is pushed, a release pipeline should be triggered. Pipeline should:

push docker images with appropriate tags
push charts with appropriate versions to dispatch charts repo, and update the index
push CLIs to the S3 bucket
update README to point to the latest release
post to slack with the announcement

Fixed cbd8624992d913113843fa21d4f791a3bc16ac78


Change wz_location_method to location_method

Issue name: “Change wz_location_method to location_method”
Summary
If the field road_events.type is added via issue #82 the field name wz_location_method should be changed to reflect the models accommodation of multiple road event types.
Proposed changes
In the case of a proposed change, provide one or a few options for moving forward.
Replace wz_location_method with location_method

This field naming is part of the metadata and is already discussed in #10. This naming should be changed with the implementation of #10 even if #82 is not approved.

Awesome.  Thanks @j-d-b


Need to bring versions up to draft-32

Should be fine now per testing (although more testing would be beneficial)


Add message to Jar Details View if operations are disabled

When a maker or taker operation is running, the freeze/unfreeze buttons do not appear in the Jar Details View.
Currently, a user might be confused that the buttons are not displayed.
Add a message that explains why freezing/unfreezing is currently not possible.

hey @theborakompanioni would love to work on this, what should the message be and how/where should it be displayed? @editwentyone

Hey @nischal-shetty2! Great to her! :pray:
I think displaying a text that just says "A maker/taker operation is in progress. Some operations are disabled." is okay.  It can be shown right where the buttons would have been. What do you think? Optionally add an info icon that the user can click/hover to get more information.
Also, what about still displaying the buttons but disable them? They do not really look pretty at the moment.. a visual update is highly welcome.

What do you think about displaying A maker/taker operation is in progress. Some operations are disabled. right next to the info icon by default? This way, users get the context without needing extra effort.

Perfect :ok_hand:


Is it possible to do error handling when the user inputs a wrong number of parameters?

lets say I've got a function "foo"  in C++ that I want to call in lua
my script does this :
function update()
--this is supposedly wrong
    foo()
end

and this is the C++ code:
struct myClass
{
  int haha;
    myClass()
      :haha{0}{};
}
void foo(myClass mClass)
{
  std::cout<<mClass.haha<<std::endl;
}
int main()
{
    sol::state mLua;
    mLua.open_libraries(sol::lib::base, sol::lib::package,
					 sol::lib::string, sol::lib::os,
					 sol::lib::math, sol::lib::table,
					 sol::lib::io);

    mLua.new_usertype<myClass>("myClass",sol::constructors< myClass()>());

    mLua["foo"] = &foo;
    sol::environment& env =sol::environment{ mLua, sol::create, mLua.globals() };
    mLua.script_file("someLua.lua",env);
    mLua["foo"] = &foo;
    env["update"]();
}

technically this is supposed to be wrong as "foo" takes in a "myClass" and when i tested this out I got a segmentation fault.
however upon further experimenting if i change my "foo" function to take in primitive type
(e.g.foo(int haha)).
the function runs properly without crashing.
TLDR; is there a way for me to show debugging errors or handle them in runtime if the user were to input the wrong number/type of parameters?

https://sol2.readthedocs.io/en/latest/safety.html#config
https://github.com/ThePhD/sol2/blob/develop/examples/source/tutorials/quick_n_dirty/running_lua_code_safely.cpp#L36
https://sol2.readthedocs.io/en/latest/api/protected_function.html

I am in this same boat as well. If my C++ function is called from Lua and Lua does not pass in enough parameters the function isn't actually called on the C++ side but there are no errors that I can report back to the script writer. I've looked at all those links above. I cannot figure out how to get Sol3 to actually report an error to the console. I've Googled but there is basically nothing out there except the docs mentioned above. I'll open a new issue.


Host mdbook docs on github pages

so that documentation is always available, without an instance being publicly hosted.

Versioning could be a bit of an issue. Assume some deployment is a few releases behind and out-of-sync with the latest documentation. It might make sense to not have that documentation on github pages at all, to avoid confusion. Or split the documentation up somehow. E.g. the user manual would only be available from a deployed instance. Things like migration guides would obviously be available centrally.


Update revolt to 0.2

See amphp/sync#20
Depends on amphp/cache#19 to successfully install.

Forgot there was an open PR, already committed this in https://github.com/amphp/dns/commit/b771133214759ce05311a443330046087f089bb1. Thanks anyway!

Forgot there was an open PR, already committed this in b771133. Thanks anyway!

No worries, just doing this to be helpful where I can :)


Use the generators from devfile/library

With #4134 merged, https://github.com/devfile/api/issues/184 is in progress where the PR is going to merge the generators code to devfile/library.
Once the code is merged to devfile/library, odo  need to start using the generators from the devfile/library module.

The PR https://github.com/devfile/library/pull/44 has been merged, odo now needs to use it from devfile/library


Add a link to cget

Cget provides package management for C++, see here.

Its also listed here in the awesome-cmake list.

First of all, I want to say sorry since your patch is more eariler but a later patch(#410) was merged. I should have searched in the PRs before created a new one. Sometimes, we made mistakes.
So to be fair, I partially reverted #410 and merged this patch.
Thanks for the PR and sorry for the long delay.
@fffaraz Hope you don't mind.


esm.sh is also unstable

error: Integrity check failed for remote specifier. The source code is invalid, as it does not match the expected hash in the lock file.

  Specifier<EMAIL_ADDRESS>  Actual: 309faa58fa4e914707daffa1a9514bef4593c952f930640cf93bb871aab7ceb6
  Expected: 54d8a51c6ca025380abd2d5302e4a9b38ff835d9759c4657e52314f587eaf6bf

This could be caused by:
  * the lock file may be corrupt
  * the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.

https://github.com/kachick/depop/pull/43
=>
https://github.com/kachick/depop/pull/142
https://github.com/kachick/depop/actions/runs/10691797035/job/29644832809

How about replacing it with JSR?
Or I might wrongly understand something about them...? 🤔

https://github.com/esm-dev/esm.sh/issues/519
https://github.com/esm-dev/esm.sh/issues/614

https://esm.sh/#docs

Pinning Build Version

At least I wish to try this first...

https://github.com/esm-dev/esm.sh/releases 🤔 However they didn't update the esm.sh version v135 since 2023...

No react in JSR https://github.com/facebook/react/issues/28971

https://docs.deno.com/runtime/fundamentals/modules/

When using newewr deno
Warning "--lock-write" flag is deprecated and will be removed in Deno 2

https://zenn.dev/hashrock/scraps/9e9eb8620553f7#comment-c3aa6188e61995

i think the lock file break caz https://github.com/esm-dev/esm.sh/issues/874, fyi the next version v136, which i still working on it, as removed the /v135 and /stable prefix, that means we do not build modules everytime we deploy the new version that breaks deno.lock

Thank you for sharing it with me! :pray:


Add Conf package

[-] Run swift ./validate.swift diff before submitting this PR

 swift ./validate.swift diff                                                                                Checking all urls are valid. Checking for duplicate packages. Checking packages are sorted. Checking each url for valid package dump. Checking 1 Packages... Checking 0111b/Conf.git ... https://github.com/0111b/Conf.git passed Validation Succeeded.

First in the list! 👍
Thanks


⚠ AGEG website (prod) has degraded performance

In 875600e, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 16977 ms

Resolved: AGEG website (prod) performance has improved in 87aea44.


Use config specific intermediate folders with make

Splitting this off from Issue #867:

To support switching between configurations without doing a full rebuild, we should have config specific intermediate folders. This could be done by setting appropriate variables, such as BUILDDIR=".build/debug/", though in a config specific manner.

Looks like we already have config specific intermediate folders. At least, in terms of debug or release builds. What we're really missing is compiler specific intermediate folders.


No

No

Are there plans to support this feature
Originally posted by @Sallery-X in https://github.com/Altinity/clickhouse-operator/issues/633#issuecomment-768835299

@Sallery-X could you describe what you exactly need?

@Sallery-X could you describe what you exactly need?

define custom remote_servers section

I mean to define custom remote_servers section

define custom remote_servers section

I mean to define custom remote_servers section


Different dynamic route loading with "*" not possible (loader output is cached)

Describe the bug
Sometimes it may be desired/required to have routes defined outside of react-router or the javascript app or they are just not all known to the app. For example asking the backend if it has something to serve for this route.
One of my usecases is content served from an API with thousands of routes, some of which are only available to certain users and deciding which user can access what route is done on-the-fly by the backend.
This use-case can be served by adding a route like this (where fetchRoute performs a request to the backend):
{
	path: "*",
	loader: ({pathname}) => (
		queryClient.getQueryData(["route", pathname]) ?? queryClient.fetchQuery(["route", pathname], () => fetchRoute(pathname))
	),
	element: <RouteComponent />,
}

Unfortunately, a "*" route currently has the same cache key regardless of the pathname, and therefore will fetch the correct content the first route and then return the same content for all following routes.
(Using a route parameter ":foobar" will work for top-level routes, but does not cover n levels of nested routes.)
To Reproduce
I don't think an example is necessary right now, but I'd be happy to create one if needed.
Expected behavior
I think we should consider both the route path "*" aswell as the matched pathname for the cache key and re-run the loader for every pathname.
Workaround
My currently working workaround:
	const loader = React.useCallback(({pathname}) => (
		queryClient.getQueryData(["route", pathname]) ?? queryClient.fetchQuery(["route", pathname], () => fetchRoute(pathname))
	), [])
	const routes = React.useMemo(() => {
		const _routes = []
		const routePaths = ["/"]
		let lastPath = ""
		Array(26).fill().map((element, index) => String.fromCharCode("a".charCodeAt(0) + index)).map(char => {
			lastPath = `${lastPath}/:${char}`
			routePaths.push(`${lastPath}/`)
		})
		routePaths.reverse().forEach((path) => {
			_routes.push({
				loader,
				element: <RouteComponent />,
				path,
			})
		})
		return _routes
	}, [])

This will produce the following 27 routes, all with the same loader and element:

/
/:a/
/:a/:b/
/:a/:b/:c/
...
/:a/:b/:c/:d/:e/:f/:g/:h/:i/:j/:k/:l/:m/:n/:o/:p/:q/:r/:s/:t/:u/:v/:w/:x/:y/:z/

There might be an API that you can use to just watch the route match wildcard in an effect and re-trigger the loader when it changes. Would that work?

Yeah, I think that could work too. As long as we have some method to invalidate the cache.
I also did some more thinking, so I see 3 possible solutions:

your idea

per route cacheKey callback
Another idea is (I think I saw that on some other react-routing lib or something): Adding a callback to calculate the cache key.
Right now a route with path: "*" probably has the cache key "*". What if we make a callback like this:
{
	path: "*",
	loader: ({pathname}) => (
		queryClient.getQueryData(["route", pathname]) ?? queryClient.fetchQuery(["route", pathname], () => fetchRoute(pathname))
	),
	//cacheKey: (path, match) => path, // DEFAULT behavior, so it returns `*`
	cacheKey: (path, match) => `${path}|${match.pathname}`, // my desired behavior, so it returns `*|/foo/bar/baz` or whatever
	element: <RouteComponent />,
}

allow a callback for path (like search works?)
And a variation of that idea: how about making path a callback that can do it's own matching and return route parameters (like :a/:b would). This way people could also do regex stuff (which would address #77 ). Kind of like how I think search works. Here's an example that would cover the usecase from #77:
{
	path: (locationMatch) => {
		const regexMatch = locationMatch.pathname.match(/\/(a|b|c)/(\d+)/?/)
		if (!regexMatch) return false;
		return {
			segment: regexMatch[1], // a, b, or c
			id: regexMatch[2], // number
		}
	},
	loader: ({pathname}) => (
		queryClient.getQueryData(["route", pathname]) ?? queryClient.fetchQuery(["route", pathname], () => fetchRoute(pathname))
	),
	element: <RouteComponent />,
}

Right now, I think I like (3) the best. But any would be fine for me.

This could be a cool addition. Would you like to explore adding it?

Facing same problem here.
Having a catch-all route is a very common pattern.
Would be great having some control over the cache key for path '*', or allowing  providing a regex for the route param, à la express:
{
    path: ':slug(.*)',
}

@tannerlinsley I'm currently facing a similar use case. In which of the above methods is this solved/can this be implemented?  I didn't find something that explicitly addresses it in the documentation.


There is no choice of a specific hdim source

The integration works well.
my tv samsung UE55mu6100
But the problem is that I can't select a specific hdim port.

Unfortunately this seems to keep occurring every few months. The TV will disconnect from the Smart Things API and seemingly can't be fixed without removing and re-adding.


qemu: Tweak configuration script for qemu 5.1

Certain config options have been deprecated with 5.1.
Remove these.
Depends-on: github.com/kata-containers/runtime#2993
Fixes #1150
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>Original PR: https://github.com/kata-containers/packaging/pull/1151

/test-ubuntu
/test-obs

/AzurePipelines run

As https://github.com/kata-containers/runtime/pull/3168 is not passing CI, we're closing this one as well.


typo: Beacuse -> Because

@nschonni : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.


use full coin pair name

Helper.CreateDashedPair uses substring of 3's, except not all coins have a length of 3
I haven't run the program nor tests, but I don't think this is correct.
e.g. TOMO-BTC
would make https://api.kucoin.com/v1/open/chart/history?symbol=TOM-BTC
and throw SYMBOL NOT FOUND
instead of https://api.kucoin.com/v1/open/chart/history?symbol=TOMO-BTC
Suggest you lazy load coins in some dictionary to map them symbol <-> kuPair

I'll take a look at it later today.

Ok just fixed and updated the nuget package too.
Thanks for the feedback. Happy trading!


The program only accept the 'N'

The program will always only accept the character 'N' but not the 'Y'
I already tried with on-screen keyboard or changing the keyboard layout.

How do I fix it? I have the same problem.

How do I fix it? I have the same problem.

I found out wheres the problem; its used a "build-in" windows function where instead of accepting the N or the Y, is based on your windows language.
In my case in Italian the "yes" its "si" so I had to press the S key instead of the Y.

Thanks, it worked!

Problem should be fixed now.


feat: rework installation page

Get started

[ ] Introduction
[ ] Installation
[ ] Visual testing
[ ] Continuous integration

Screenshot stability

[ ] About flaky tests
[ ] Data Stabilization
[ ] Style injection

CLI & Integrations

[ ] CLI
[ ] Gatsby
[ ] Node.js

Account & External links

[ ] Account
[ ] Pricing plans
[ ] Security
[ ] Privacy
[ ] Terms
[ ] Contact us


Allow NFT deposits

For some reason, depositing still only works with fungibles, it seems. At least I got that error when testing my deposit dialog.

Never mind. I had used the 0x0 address!


Unexpected output from Z3 after duplicating a definition

An example like the following
val x: a: int -> b: int -> Lemma (a + b = 0 ==> a = -b)

let x a b = admit ()

let x a b = admit ()

let z = assert (2 + 3 = 5)

when run in interactive mode, will generate this warning from Z3 when verifying the last assert:
Test: Unexpected output from Z3: (error "line 40452 column 3: Wrong number of arguments (5) passed to function (declare-fun Test.x (Term Term) Term)")

The function x is encoded correctly and the warning goes away when annotating the result type in the second definition:
let x a b : Lemma (a + b = 0 ==> a = -b) = admit ()
Add this to the list of quirks in #965.

Could this be the same as #1150?

This bug still remains after fixing 1150.

This is really weird. For the second let x, its SMT declaration says that x is a function with arity 2 (perhaps from the val). And then, the actual let binding has 5 arguments, where the additional three arguments are generalized types for a, b, and admit. So, the duplication causes let x to be typed and generalized independently of the val.
My guess is with @s-zanella annotations, the type variables are instantiated properly, and hence the arity matches after that.
I think it should be fixed by not allowing duplicates, rather than in the smtencoding.

This might be a non-issue now since we reject duplicate definitions? Though I'm not sure if #965 is fully fixed or not.

We are now rejecting duplicate top-level definitions. Things work fine in the absence of the duplicate definition. Closing this bug.


[Event Request] Codeunit 57 Document Totals - OnAfterCalculateTotalPurchaseLineAndVATAmountOnPurchaseCalculateTotalsWithInvoiceRounding

Please add a new publisher event to the function PurchaseCalculateTotalsWithInvoiceRounding as follows:
[External] PurchaseCalculateTotalsWithInvoiceRounding(VAR TempCurrentPurchaseLine : TEMPORARY Record "Purchase Line";VAR VATAmount : Decimal;VAR TempTotalPurchaseLine : TEMPORARY Record "Purchase Line")
CLEAR(TempTotalPurchaseLine);

IF PurchaseHeader.GET(TempCurrentPurchaseLine."Document Type",TempCurrentPurchaseLine."Document No.") THEN BEGIN
  CalculateTotalPurchaseLineAndVATAmount(PurchaseHeader,VATAmount,TempTotalPurchaseLine,TempPurchaseLine);

//>> Start New Publisher Call
  OnAfterCalculateTotalPurchaseLineAndVATAmountOnPurchaseCalculateTotalsWithInvoiceRounding(TempPurchaseLine, TempTotalPurchaseLine, VATAmount);
//<< End New Publisher Call

  IF PreviousTotalPurchaseHeader."No." <> TempCurrentPurchaseLine."Document No." THEN
    PreviousTotalPurchaseHeader.GET(TempCurrentPurchaseLine."Document Type",TempCurrentPurchaseLine."Document No.");
.
.

New Publisher Event:
LOCAL [IntegrationEvent] OnAfterCalculateTotalPurchaseLineAndVATAmountOnPurchaseCalculateTotalsWithInvoiceRounding(VAR TempPurchaseLine : TEMPORARY Record "Purchase Line";VAR TempTotalPurchaseLine : TEMPORARY Record "Purchase Line";VAR VATAmount : Decimal)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Dear Microsoft,
Is this request available in CU4? And what is the IntegrationEvent in the Document Totals Codeunit for this request?
Thanks in advanced for your answer.


The first 10k goose collection on Fractal Ordinals

The first 10k goose collection on Fractal Ordinals

add to main,pls and push to mrket
the okx had add the collection,and trading volume is NO1

Hi, we've merged the prebvoius 10k PR from your community. @weplaynft


Fix bugs of Slice/ReduceSum/TopK nodes and Graph's member function in corner cases

Hi, I found some bugs and fixed them when processing a complicated case. The description of this pull requrest is:

Fix bugs of Slice/ReduceSum/TopK nodes in corner cases and optimize the member function (__find_shape_tensor__) of the Graph class

You could learn the details from the four commits history.

Hi, thanks for your contribution! Can you provide onnx models or pytorch(tf) scripts to test your fix?

Hi, subjected to the license, sorry that I could not send the model to you.
But I could provide snapshots of the nodes related for your verification. I think the bug-fix is clear and easy to understand with these snapshots, you may test the code with your self-defined model if possible, or you could communicate with me if there is any question.

Thanks again! I will use your fork repo to test all archived models. Then I will find a way to test these corner cases.
BTW, if it is convenient for you, you can use the 'extract subgraph' function to get the subgraph with these corner cases from your private models.  I think there is no secret in these subgraphs. Of course, it's all up to you.

Sorry for the inconvenience of uploading any subgraph to the internet~
I could explain the modification of each commit.
(1) Slice: like the snapshot of Slice node I provided, starts=[0,0,0,6], ends=[2147483647,<PHONE_NUMBER>,<PHONE_NUMBER>, 7], the order of both starts & ends are correspondent with the order of axes=[0,2,3,1]. So for axis=1, start=6, end=7; but the original code visit axes with the order of [0,1,2,3] instead of [0,2,3,1], then causes error.
(2) ReduceSum: like the snapshot of ReduceSum node I provided, if the node has two inputs, the second one is the list of axes. I notice that in node.py you have consider this situation, but in node_profiles.py you only consider the case of one input.
(3) TopK: like the snapshot of TopK node I provided, this node doesn't have the axis attribute, then self.axis=None. Since the input tensor has only one dimension, and the input shape of this node is (4000,), so TopK is conduced along axis=0 although    there is no axis attribute here.
(4) On the 4th commit 00d9a48, refer to the commit message and the part of my modification should be recovered to your original version according to our discussion on the issue.

Good work!


fix bug: reverse lat & lng in NavigationUIActivity sample

Fix bug: lat & lng is reversed in NavigationUIActivity sample

Oh, thank you for the quick fix!
Can you clean up the whitespaces, for a more consistent look?! 😄

I see that I can do by myself. Already done!
Thanks again! :-)

@Fabi755 @boldtrn  Thanks for review.
Would like to know how this PR can be merged?


fix: #10232 Improved italian translations

I've tried to fill in as much tokens as I could while resolving #10232

Thanks for your contribution.
Looks nice.
Waiting for one more review and QA Team.

Hi guys, Can this be merged by any case?

This PR awaits our QA team.

verified


create coreos ignition guestfs upload directory for s390 platform

Fix #629
It didn't create the directory /ignition before uploading the ignition file.
Currently verified on the s390 platform, this PR can successfully inject files and create virtual machines regardless of whether the /ignition directory exists.

@zeenix CC

@xkwangcn  a part of that, you will need to squash your commits

@xkwangcn a part of that, you will need to squash your commits

ok, I just  squashed my commits~

thx @xkwangcn a priori looks good to me, waiting for Coreos experts for this

ok, thanks

Please add some description to the commit log as well (just C&P the description of the PR).

yes, please add some commit log
it's my bad which I got fedroa coreos image has the folder so originally my PR didn't include that create dir action while it turns out the folder is not created by default so we have to add this create dir action in the code. sorry ...

yes, please add some commit log

And while you're at it, some nitpicks:

Fix #629

This has s special canotion on github and gitlab, where you specify the issue being fixed by the PR. This is redundant anyway, since you describe it below so just remove this line.

#629 could support for s390x on coreos ignition

You meant to write "#629 added support for s390x on coreos ignition".

it's my bad which I got fedroa coreos image has the folder so originally my PR didn't include that create dir action while it turns out the folder is not created by default so we have to add this create dir action in the code. sorry ...

I was actually about to ask you since you said you tested those patches but then I figured what must have happened. :) It happens to all of us. :)

it's my bad which I got fedroa coreos image has the folder so originally my PR didn't include that create dir action while it turns out the folder is not created by default so we have to add this create dir action in the code. sorry ...

I was actually about to ask you since you said you tested those patches but then I figured what must have happened. :) It happens to all of us. :)

:), sorry, the original coreos image I got with the PR #629 did works fine and coreos deployed successfully
but when the image got changed to some image that is brand new it breaks ...
hopefully I can test on more env before I say it's tested next time.. thanks

let me know when for you is this OK and I will merge it.

yes, please add some commit log

And while you're at it, some nitpicks:

Fix #629

This has s special canotion on github and gitlab, where you specify the issue being fixed by the PR. This is redundant anyway, since you describe it below so just remove this line.

#629 could support for s390x on coreos ignition

You meant to write "#629 added support for s390x on coreos ignition".

It's not me :), anyway, I will let @xkwangcn know ~

It's not me :), anyway, I will let @xkwangcn know ~

I didn't say it was. :) I was only adding to what you said.

It's not me :), anyway, I will let @xkwangcn know ~

I didn't say it was. :) I was only adding to what you said.

thank you :), I agree all your comments, we will update it soon

Please add some description to the commit log as well (just C&P the description of the PR).
the main.tf file:
`[root@wxkocp59 coreos]# cat main.tf

provider "libvirt" {
uri = "qemu:///system"
}
variable "hostname_format" {
type    = "string"
default = "coreos%02d"
}
resource "libvirt_volume" "coreos-disk" {
name = "coreos02.qcow2"
source = "/home/qemu/rhcos-42.80.20190910.4-qemu.qcow2"
source = "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"
pool             = "qemu"
format           = "qcow2"
}
resource "libvirt_ignition" "ignition" {
name    = "${format(var.hostname_format, count.index + 1)}-ignition"
pool    = "qemu"
content = "/home/qemu/config.ign"
}
resource "libvirt_network" "neti"{
name = "fcoreosneti"
mode = "nat"
bridge = "brf2"
domain = "domainf"
addresses = ["<IP_ADDRESS>/24"]
}
Create the virtual machines
resource "libvirt_domain" "coreos-machine" {
name   = "coreos830"
vcpu   = "1"
memory = "2048"
coreos_ignition = "${libvirt_ignition.ignition.id}"
disk {
volume_id = "${libvirt_volume.coreos-disk.id}"
}
graphics {
listen_type = "address"
}
console {
type = "pty"
target_port = "0"
}
network_interface {
network_name = "default"
network_id = "${libvirt_network.neti.id}"
}
}
output "ipv4" {
value = "${libvirt_domain.coreos-machine.*.network_interface.0.addresses}"
}
Now the coreos image don't has the /ignition directory[root@wxkocp59 coreos]# guestfish -a /home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2
Welcome to guestfish, the guest filesystem shell for
editing virtual machine filesystems and disk images.
Type: ‘help’ for help on commands
‘man’ to read the manual
‘quit’ to quit the shell

 run
100% ⟦▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒⟧ 00:00
 mount /dev/sda1 /
 ls /
boot
bootmap
efi
ignition.firstboot
loader
loader.1
lost+found
ostree
 umount /
 exit

[root@wxkocp59 coreos]# terraform apply
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

create

Terraform will perform the following actions:

libvirt_domain.coreos-machine
id:
arch:
console.#:                        "1"
console.0.source_host:            "<IP_ADDRESS>"
console.0.source_service:         "0"
console.0.target_port:            "0"
console.0.type:                   "pty"
coreos_ignition:                  "${libvirt_ignition.ignition.id}"
disk.#:                           "1"
disk.0.scsi:                      "false"
disk.0.volume_id:                 "${libvirt_volume.coreos-disk.id}"
emulator:
fw_cfg_name:                      "opt/com.coreos/config"
graphics.#:                       "1"
graphics.0.autoport:              "true"
graphics.0.listen_address:        "<IP_ADDRESS>"
graphics.0.listen_type:           "address"
graphics.0.type:                  "spice"
machine:
memory:                           "2048"
name:                             "coreos830"
network_interface.#:              "1"
network_interface.0.addresses.#:
network_interface.0.hostname:
network_interface.0.network_id:   "${libvirt_network.neti.id}"
network_interface.0.network_name: "default"
qemu_agent:                       "false"
running:                          "true"
vcpu:                             "1"

libvirt_ignition.ignition
id:
content:                          "/home/qemu/config.ign"
name:                             "coreos01-ignition"
pool:                             "qemu"

libvirt_network.neti
id:
addresses.#:                      "1"
addresses.0:                      "<IP_ADDRESS>/24"
bridge:                           "brf2"
domain:                           "domainf"
mode:                             "nat"
name:                             "fcoreosneti"

libvirt_volume.coreos-disk
id:
format:                           "qcow2"
name:                             "coreos02.qcow2"
pool:                             "qemu"
size:
source:                           "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"

Plan: 4 to add, 0 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
 Resources: 4 added, 0 changed, 0 destroyed.
Outputs:
ipv4 = [
[
]
]
[root@wxkocp59 coreos]# virsh domifaddr coreos830
 name     MAC address           Protocol     Address
vnet0      52:54:00:c6:5d:8c    ipv4         <IP_ADDRESS>/24
[root@wxkocp59 coreos]# ssh<EMAIL_ADDRESS>The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:SXhJJ4F7NmuEWZARZFPi6gfaE3WKRJxfDnSlR8uIHPw.
ECDSA key fingerprint is MD5:a7:fe:78:cf:70:99:a9:62:7e:cf:23:11:3e:87:13:d3.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Fedora 30.20190828.dev.2 (CoreOS preview)
Tracker: https://github.com/coreos/fedora-coreos-tracker
Preview release: breaking changes may occur
[core@localhost ~]$ `
Now the coreos image has the /ignition directory
`[root@wxkocp59 coreos]# guestfish -a /home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2
Welcome to guestfish, the guest filesystem shell for
editing virtual machine filesystems and disk images.
Type: ‘help’ for help on commands
‘man’ to read the manual
‘quit’ to quit the shell

 run
100% ⟦▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒⟧ 00:00
 mount /dev/sda1 /
 ls /
boot
bootmap
efi
ignition.firstboot
loader
loader.1
lost+found
ostree
 mkdir /ignition
 ls /
boot
bootmap
efi
ignition
ignition.firstboot
loader
loader.1
lost+found
ostree
 umount /
 exit

[root@wxkocp59 coreos]# terraform destroy
libvirt_network.neti: Refreshing state... (ID: cde26f43-12d3-48b2-87f5-4a22d0861fb8)
libvirt_volume.coreos-disk: Refreshing state... (ID: /home/qemu/coreos02.qcow2)
libvirt_ignition.ignition: Refreshing state... (ID: /home/qemu/coreos01-ignition;5d8ac24f-2981-585b-83ba-f2a798a25672)
libvirt_domain.coreos-machine: Refreshing state... (ID: e5bf7a21-6307-4a9d-922e-8946d11b9981)
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

destroy

Terraform will perform the following actions:

libvirt_domain.coreos-machine

libvirt_ignition.ignition

libvirt_network.neti

libvirt_volume.coreos-disk

Plan: 0 to add, 0 to change, 4 to destroy.

Terraform will destroy all your managed infrastructure, as shown above.
There is no undo. Only 'yes' will be accepted to confirm.
Enter a value: yes
libvirt_domain.coreos-machine: Destroying... (ID: e5bf7a21-6307-4a9d-922e-8946d11b9981)
libvirt_domain.coreos-machine: Destruction complete after 1s
libvirt_ignition.ignition: Destroying... (ID: /home/qemu/coreos01-ignition;5d8ac24f-2981-585b-83ba-f2a798a25672)
libvirt_volume.coreos-disk: Destroying... (ID: /home/qemu/coreos02.qcow2)
libvirt_network.neti: Destroying...  (ID: /home/qemu/coreos02.qcow2, 10s elapsed)
libvirt_volume.coreos-disk: Destruction complete after 10s
Destroy complete! Resources: 4 destroyed.
[root@wxkocp59 coreos]# terraform apply
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

create

Terraform will perform the following actions:

libvirt_domain.coreos-machine
id:
arch:
console.#:                        "1"
console.0.source_host:            "<IP_ADDRESS>"
console.0.source_service:         "0"
console.0.target_port:            "0"
console.0.type:                   "pty"
coreos_ignition:                  "${libvirt_ignition.ignition.id}"
disk.#:                           "1"
disk.0.scsi:                      "false"
disk.0.volume_id:                 "${libvirt_volume.coreos-disk.id}"
emulator:
fw_cfg_name:                      "opt/com.coreos/config"
graphics.#:                       "1"
graphics.0.autoport:              "true"
graphics.0.listen_address:        "<IP_ADDRESS>"
graphics.0.listen_type:           "address"
graphics.0.type:                  "spice"
machine:
memory:                           "2048"
name:                             "coreos830"
network_interface.#:              "1"
network_interface.0.addresses.#:
network_interface.0.hostname:
network_interface.0.network_id:   "${libvirt_network.neti.id}"
network_interface.0.network_name: "default"
qemu_agent:                       "false"
running:                          "true"
vcpu:                             "1"

libvirt_ignition.ignition
id:
content:                          "/home/qemu/config.ign"
name:                             "coreos01-ignition"
pool:                             "qemu"

libvirt_network.neti
id:
addresses.#:                      "1"
addresses.0:                      "<IP_ADDRESS>/24"
bridge:                           "brf2"
domain:                           "domainf"
mode:                             "nat"
name:                             "fcoreosneti"

libvirt_volume.coreos-disk
id:
format:                           "qcow2"
name:                             "coreos02.qcow2"
pool:                             "qemu"
size:
source:                           "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"

Plan: 4 to add, 0 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
 Resources: 4 added, 0 changed, 0 destroyed.
Outputs:
ipv4 = [
[
]
]
[root@wxkocp59 coreos]# virsh domifaddr coreos830
name     MAC address           Protocol     Address
vnet0      52:54:00:e2:be:84    ipv4         <IP_ADDRESS>/24
[root@wxkocp59 coreos]# ssh<EMAIL_ADDRESS>The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:eg2Zy7o6qaLHhiwjxTxxuHP2NUM1xysR0DMHS1g0zJ8.
ECDSA key fingerprint is MD5:5f:e5:e4:ef:b2:e7:2a:2b:eb:ae:e3:4d:2e:6f:f8:f8.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Fedora 30.20190828.dev.2 (CoreOS preview)
Tracker: https://github.com/coreos/fedora-coreos-tracker
Preview release: breaking changes may occur
[core@localhost ~]$
`

Please add some description to the commit log as well (just C&P the description of the PR).

`[root@wxkocp59 coreos]# cat main.tf
provider "libvirt" {
uri = "qemu:///system"
}
variable "hostname_format" {
type = "string"
default = "coreos%02d"
}
resource "libvirt_volume" "coreos-disk" {
name = "coreos02.qcow2"
source = "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"
pool = "qemu"
format = "qcow2"
}
resource "libvirt_ignition" "ignition" {
name = "${format(var.hostname_format, count.index + 1)}-ignition"
pool = "qemu"
content = "/home/qemu/config.ign"
}
resource "libvirt_network" "neti"{
name = "fcoreosneti"
mode = "nat"
bridge = "brf2"
domain = "domainf"
addresses = ["<IP_ADDRESS>/24"]
}
Create the virtual machines
resource "libvirt_domain" "coreos-machine" {
name = "coreos830"
vcpu = "1"
memory = "2048"
coreos_ignition = "${libvirt_ignition.ignition.id}"
disk {
volume_id = "${libvirt_volume.coreos-disk.id}"
}
graphics {
listen_type = "address"
}
console {
type = "pty"
target_port = "0"
}
network_interface {
network_name = "default"
network_id = "${libvirt_network.neti.id}"
}
}
output "ipv4" {
value = "${libvirt_domain.coreos-machine.*.network_interface.0.addresses}"
}
Now the coreos image don't has the /ignition directory[root@wxkocp59 coreos]# guestfish -a /home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2
Welcome to guestfish, the guest filesystem shell for
editing virtual machine filesystems and disk images.
Type: ‘help’ for help on commands
‘man’ to read the manual
‘quit’ to quit the shell
run
100% ⟦▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒⟧ 00:00
mount /dev/sda1 /
ls /
boot
bootmap
efi
ignition.firstboot
loader
loader.1
lost+found
ostree
umount /
exit
[root@wxkocp59 coreos]# terraform apply
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
create
Terraform will perform the following actions:
libvirt_domain.coreos-machine
id:
arch:
console.#: "1"
console.0.source_host: "<IP_ADDRESS>"
console.0.source_service: "0"
console.0.target_port: "0"
console.0.type: "pty"
coreos_ignition: "${libvirt_ignition.ignition.id}"
disk.#: "1"
disk.0.scsi: "false"
disk.0.volume_id: "${libvirt_volume.coreos-disk.id}"
emulator:
fw_cfg_name: "opt/com.coreos/config"
graphics.#: "1"
graphics.0.autoport: "true"
graphics.0.listen_address: "<IP_ADDRESS>"
graphics.0.listen_type: "address"
graphics.0.type: "spice"
machine:
memory: "2048"
name: "coreos830"
network_interface.#: "1"
network_interface.0.addresses.#:
network_interface.0.hostname:
network_interface.0.network_id: "${libvirt_network.neti.id}"
network_interface.0.network_name: "default"
qemu_agent: "false"
running: "true"
vcpu: "1"
libvirt_ignition.ignition
id:
content: "/home/qemu/config.ign"
name: "coreos01-ignition"
pool: "qemu"
libvirt_network.neti
id:
addresses.#: "1"
addresses.0: "<IP_ADDRESS>/24"
bridge: "brf2"
domain: "domainf"
mode: "nat"
name: "fcoreosneti"
libvirt_volume.coreos-disk
id:
format: "qcow2"
name: "coreos02.qcow2"
pool: "qemu"
size:
source: "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"
Plan: 4 to add, 0 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
 Resources: 4 added, 0 changed, 0 destroyed.
Outputs:
ipv4 = [
[
]
]
[root@wxkocp59 coreos]# virsh domifaddr coreos830
name     MAC address           Protocol     Address
vnet0      52:54:00:c6:5d:8c    ipv4         <IP_ADDRESS>/24
[root@wxkocp59 coreos]# ssh<EMAIL_ADDRESS>The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:SXhJJ4F7NmuEWZARZFPi6gfaE3WKRJxfDnSlR8uIHPw.
ECDSA key fingerprint is MD5:a7:fe:78:cf:70:99:a9:62:7e:cf:23:11:3e:87:13:d3.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Fedora 30.20190828.dev.2 (CoreOS preview)
Tracker: https://github.com/coreos/fedora-coreos-tracker
Preview release: breaking changes may occur
[core@localhost ~]$ `
Now the coreos image has the /ignition directory
`[root@wxkocp59 coreos]# guestfish -a /home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2
Welcome to guestfish, the guest filesystem shell for
editing virtual machine filesystems and disk images.
Type: ‘help’ for help on commands
‘man’ to read the manual
‘quit’ to quit the shell
run
100% ⟦▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒⟧ 00:00
mount /dev/sda1 /
ls /
boot
bootmap
efi
ignition.firstboot
loader
loader.1
lost+found
ostree
mkdir /ignition
ls /
boot
bootmap
efi
ignition
ignition.firstboot
loader
loader.1
lost+found
ostree
umount /
exit
[root@wxkocp59 coreos]# terraform destroy
libvirt_network.neti: Refreshing state... (ID: cde26f43-12d3-48b2-87f5-4a22d0861fb8)
libvirt_volume.coreos-disk: Refreshing state... (ID: /home/qemu/coreos02.qcow2)
libvirt_ignition.ignition: Refreshing state... (ID: /home/qemu/coreos01-ignition;5d8ac24f-2981-585b-83ba-f2a798a25672)
libvirt_domain.coreos-machine: Refreshing state... (ID: e5bf7a21-6307-4a9d-922e-8946d11b9981)
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
destroy
Terraform will perform the following actions:
libvirt_domain.coreos-machine
libvirt_ignition.ignition
libvirt_network.neti
libvirt_volume.coreos-disk
Plan: 0 to add, 0 to change, 4 to destroy.

Terraform will destroy all your managed infrastructure, as shown above.
There is no undo. Only 'yes' will be accepted to confirm.
Enter a value: yes
libvirt_domain.coreos-machine: Destroying... (ID: e5bf7a21-6307-4a9d-922e-8946d11b9981)
libvirt_domain.coreos-machine: Destruction complete after 1s
libvirt_ignition.ignition: Destroying... (ID: /home/qemu/coreos01-ignition;5d8ac24f-2981-585b-83ba-f2a798a25672)
libvirt_volume.coreos-disk: Destroying... (ID: /home/qemu/coreos02.qcow2)
libvirt_network.neti: Destroying...  (ID: /home/qemu/coreos02.qcow2, 10s elapsed)
libvirt_volume.coreos-disk: Destruction complete after 10s
Destroy complete! Resources: 4 destroyed.
[root@wxkocp59 coreos]# terraform apply
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
create
Terraform will perform the following actions:
libvirt_domain.coreos-machine
id:
arch:
console.#: "1"
console.0.source_host: "<IP_ADDRESS>"
console.0.source_service: "0"
console.0.target_port: "0"
console.0.type: "pty"
coreos_ignition: "${libvirt_ignition.ignition.id}"
disk.#: "1"
disk.0.scsi: "false"
disk.0.volume_id: "${libvirt_volume.coreos-disk.id}"
emulator:
fw_cfg_name: "opt/com.coreos/config"
graphics.#: "1"
graphics.0.autoport: "true"
graphics.0.listen_address: "<IP_ADDRESS>"
graphics.0.listen_type: "address"
graphics.0.type: "spice"
machine:
memory: "2048"
name: "coreos830"
network_interface.#: "1"
network_interface.0.addresses.#:
network_interface.0.hostname:
network_interface.0.network_id: "${libvirt_network.neti.id}"
network_interface.0.network_name: "default"
qemu_agent: "false"
running: "true"
vcpu: "1"
libvirt_ignition.ignition
id:
content: "/home/qemu/config.ign"
name: "coreos01-ignition"
pool: "qemu"
libvirt_network.neti
id:
addresses.#: "1"
addresses.0: "<IP_ADDRESS>/24"
bridge: "brf2"
domain: "domainf"
mode: "nat"
name: "fcoreosneti"
libvirt_volume.coreos-disk
id:
format: "qcow2"
name: "coreos02.qcow2"
pool: "qemu"
size:
source: "/home/qemu/fedora-coreos-30.20190828.dev.2-qemu.qcow2"
Plan: 4 to add, 0 to change, 0 to destroy.
Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.
 Resources: 4 added, 0 changed, 0 destroyed.
Outputs:
ipv4 = [
[
]
]
[root@wxkocp59 coreos]# virsh domifaddr coreos830
name MAC address Protocol Address
vnet0 52:54:00:e2:be:84 ipv4 <IP_ADDRESS>/24
[root@wxkocp59 coreos]# ssh<EMAIL_ADDRESS>The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:eg2Zy7o6qaLHhiwjxTxxuHP2NUM1xysR0DMHS1g0zJ8.
ECDSA key fingerprint is MD5:5f:e5:e4:ef:b2:e7:2a:2b:eb:ae:e3:4d:2e:6f:f8:f8.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
Fedora 30.20190828.dev.2 (CoreOS preview)
Tracker: https://github.com/coreos/fedora-coreos-tracker
Preview release: breaking changes may occur
[core@localhost ~]$
`

Please add some description to the commit log as well (just C&P the description of the PR).

I have modified the commit log, please check if it is compliant, and let me know if any questions.

yes, please add some commit log

And while you're at it, some nitpicks:

Fix #629

This has s special canotion on github and gitlab, where you specify the issue being fixed by the PR. This is redundant anyway, since you describe it below so just remove this line.

#629 could support for s390x on coreos ignition

You meant to write "#629 added support for s390x on coreos ignition".

thank you, I am very sorry that I did write an ambiguous statement. I deleted the sentence. is it okay now? Do I need to add or modify more descriptions?

thank you, I am very sorry that I did write an ambiguous statement.

That's ok. Everyone makes mistakes. :)

I deleted the sentence. is it okay now? Do I need to add or modify more descriptions?

Why? It's good to have in the log the reference to the commit/PR that you are fixing here. I even suggested how to improve the sentence. :)

thank you, I am very sorry that I did write an ambiguous statement.

That's ok. Everyone makes mistakes. :)

I deleted the sentence. is it okay now? Do I need to add or modify more descriptions?

Why? It's good to have in the log the reference to the commit/PR that you are fixing here. I even suggested how to improve the sentence. :)

thank you, could you pls check again~

thank you, could you pls check again~

Thanks for updating but the shortlog is much worse now. Could you please just use the original commit log, except for the changes I suggested? That'll save us both a lot of time. :)

thank you, could you pls check again~

Thanks for updating but the shortlog is much worse now. Could you please just use the original commit log, except for the changes I suggested? That'll save us both a lot of time. :)

And since this project currently lacks any commit log guidelines, I'd suggest following GNOME's that I helped create from a lot of experience: https://wiki.gnome.org/Git/CommitMessages

https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/CONTRIBUTING.md#conventions

for me both are ok!
https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/CONTRIBUTING.md#conventions

thanks for you and zeenix @zeenix 's help, I learned a lot in your links. I did submit PR for the first time and lack the knowledge of commit log guidelines. I will study further. Thank you.

@xkwangcn yw for any question feel free to ask. I still learning and that's the way, we are all newbies in lot of stuff! :sake:

https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/CONTRIBUTING.md#conventions

Oh forgot they exist but seems like the very minimal version copy&pasted from git manpage. :) Might be a good idea to embrace the more thorough ones like the one I linked to and if needed, modify it to our needs.

@xkwangcn No worries, we all new to things at some point. :) Thanks for your patience. Please let me know when you've fixed the commit log and we can merge this then.

https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/CONTRIBUTING.md#conventions

Oh forgot they exist but seems like the very minimal version copy&pasted from git manpage. :) Might be a good idea to embrace the more thorough ones like the one I linked to and if needed, modify it to our needs.

The two links(https://commit.style/&https://wiki.gnome.org/Git/CommitMessages) seem to be different about "fix", "fixes", "fixed", now I use "fixes" in my commit log according to https://wiki.gnome.org/Git/CommitMessages example. Other descriptions I think have met the guidelines of both. . . But if you find inappropriate descriptions pls tell me, I will continue to modify it~

@xkwangcn No worries, we all new to things at some point. :) Thanks for your patience. Please let me know when you've fixed the commit log and we can merge this then.

ok, thanks for your understanding. I have fixed the commit log yesterday, could you pls check it ~

The two links(https://commit.style/&https://wiki.gnome.org/Git/CommitMessages) seem to be different about "fix", "fixes", "fixed", now I use "fixes" in my commit log according to https://wiki.gnome.org/Git/CommitMessages example. I think other descriptions have met the guidelines of both. . . But if you find inappropriate descriptions pls tell me, I will continue to modify it~

That's no big deal, you can use either of them. :)

I have fixed the commit log yesterday, could you pls check it ~

I checked yesterday but they still don't address my original review comments. Please go through them and chance accordingly. While you're at it, please finish your sentences with .. :)

I checked yesterday but they still don't address my original review comments. Please go through them and chance accordingly. While you're at it, please finish your sentences with .. :)

Actually I think the only one left is you still using "Fixes" annotation for a non-issue. Just remove that line and add . to end of your sentences and we can merge this already. :)

I checked yesterday but they still don't address my original review comments. Please go through them and chance accordingly. While you're at it, please finish your sentences with .. :)

Actually I think the only one left is you still using "Fixes" annotation for a non-issue. Just remove that line and add . to end of your sentences and we can merge this already. :)

Done, and the first line is title, it doesn't need . , right?

Done, and the first line is title, it doesn't need . , right?

Cool. Correct. :)
Ok to merge from my side.

Done, and the first line is title, it doesn't need . , right?

Cool. Correct. :)
Ok to merge from my side.

nice, thank you

let me know when for you is this OK and I will merge it. 🌞

It is ok now, could you pls check and merge it? @MalloZup


fix for NUTCH-2217 contributed by dawid.wolski

hi @merito any reason this was closed?

I need to investigate it better. I hope I'll reopen it this week with working code.

got it thanks @merito


how to authicate dropbox without using access token

hi i don't want to let user authenticate dropbox as i am working on a app by using this app all user are able to upload files on same folder and i have a access token but now how to authenticate it?? i found i should use
var client = new Dropbox.Client({
key: "is59umadz8fodk8" ,
secret:"xxxxxxxxxxxxxxxxx" ,
sandbox: false,
token: "xxxxxxxxxxxxxx"
});
but due to security reason we cant share our token now how to do it??

+1 on this question. @maqboolkhan How did you get the token to work? It doesn't work at all on my side. I want my app to use my account always, however, when I generate an access token and add it here, it freezes. Anyone?

See marxo's issue here: https://github.com/dropbox/dropbox-js/issues/214 and on Stack Overflow here: http://stackoverflow.com/questions/28068505/dropbox-api-always-access-my-account-dropbox-js


Add alwaysShowIndicator attr support

With alwaysShowIndicator="true" floating marker should stay on screen and don't dismiss until unset programatically.
Possible solution by @AnderWeb as discussed here:

The "proper" solution would be making DiscreteSeekBar extend from ViewGroup.
Then, if the alwaysShowIndicator flag is enabled, it would create and add the Floater to itself taking care of measuring/layout/positioning.
Else, it would behave as usual, creating the Popup with the Floater inside.

+1

Hi almozavr, have you got a build with alwaysShowIndicator="true"?

That would be great!

Hey guys, is there any progress being made?
This would be an awesome feature.

that is great.

 I need this feature.

Hi my only problem with this solutions is that the indicator stays above the keyboard

A workaround I used was forcing the pressed state. This causes the ripple circle to show but I can live with that:
public class PressedDiscreteSeekBar extends DiscreteSeekBar {

  public PressedDiscreteSeekBar(Context context) {
    super(context);
    drawableStateChanged();
  }

  public PressedDiscreteSeekBar(Context context, AttributeSet attrs) {
    super(context, attrs);
    drawableStateChanged();
  }

  public PressedDiscreteSeekBar(Context context, AttributeSet attrs, int defStyleAttr) {
    super(context, attrs, defStyleAttr);
    drawableStateChanged();
  }

  protected void drawableStateChanged() {
    super.setPressed(true);
    super.drawableStateChanged();
  }
}


[BUG] Broken EntryCompletion when using builder

Bug description
Setting the text_column of an EntryCompletion using its builder causes weird rendering / behavior of popup completion:
EntryCompletion::builder()
    .text_column(0)
    .build();

Changing the entry_completion example accordingly produces this:

Additional Information

GTK: 4.4
OS: Arch Linux

It seems like gtk_entry_completion_set_text_column does a bit more than simply setting the text-column property.
Apparently my assumption that the builder methods are equivalent to their set_* counterparts is wrong.
Is this intentional design of gtk-rs?

Normally properties that expect more than a change of the property value should use their setter on the value at https://github.com/GNOME/gtk/blob/50e4ca8593d12b2de76e4d092d34ec7a1655ede8/gtk/gtkentrycompletion.c#L563 but it doesn't seems to be the case for text-column property. So far we have no way to fix this easily other than:

Manually write the builder pattern and call the corresponding method if text-column property is set
Completely ignore the text-column property, it is blocked by https://github.com/gtk-rs/gir/issues/1302 unless we manually implement the builder pattern
Report this upstream and see if it makes sense to call gtk_entry_completion_set_text_column when setting the value of text-column property

It seems like gtk_entry_completion_set_text_column does a bit more than simply setting the text-column property (like the builder method does).
Apparently my assumption that the builder methods are equivalent to their set_* counterparts is wrong.
Is this an intentional design of gtk-rs?

Builders are basically wrappers around calling glib::Object::new and passing the various properties to it with a bit of type safety at compile time. It definitely doesn't call the set_ functions

Closing this as it is an upstream issue, setting the property should ideally call the setter instead of modifying the property value.


Adding C# support

This issue was originally created at: 2008-02-13 08:12:21.
This issue was reported by: nate_snapp.
nate_snapp said at 2008-02-13 08:12:22

Added tool to allow builds with Microsoft's C# compiler.  This was tested with .NET 2.0 and 3.0 SDKs.
Patches submitted for man page, source and associated xml file, as well as test cases.  Test cases add a new directory under test and a patch couldn't be created so they are zipped up.  The rest (doc, src) are in .patch form and can be applied from the base scons directory.
To set the environment up to compile with C#, you must be on a windows machine with the .NET SDK downloaded.  You can easily download the .NET 2.0 SDK from https://www.microsoft.com/downloads/details.aspx?FamilyID=fe6f2099-b7b4-4f47-a244-c96d69c35dec&displaylang=en
Once installed, be sure to add it to your environment PATH.  For creation of publisher policies to work (part of the unit test), you need to have the sn.exe tool which comes as part of Visual Studio (including express editions).  Be sure this is also in your PATH.

nate_snapp said at 2008-02-13 08:14:03

Created an attachment (id=304)
Documentation, test cases, and source code for csharp compiler support

gregnoel said at 2008-03-16 19:42:48

*** Issue 1917 has been marked as a duplicate of this issue. ***

gregnoel said at 2008-03-16 19:44:22

Duplicate issue #1917 has a test case that fails with this patch; look there for details.

garyo said at 2008-03-17 20:28:04

Milestone: 2.x.

gregnoel said at 2008-12-26 13:20:28

Adjust triage of issues.

stevenknight said at 2009-11-10 18:00:20

stevenknight => issues@scons

Votes for this issue: 5.
nate_snapp attached csharp.zip at 2008-02-13 08:14:03.

Documentation, test cases, and source code for csharp compiler support

gregnoel said this issue is duplicated by #1917 at 2008-03-16 19:42:51.

See also #2490


Optional columns in the dataframe

Hello! I'm doing some testing to this library (looks promising) but I found out that If i want an optional column in the dataframe the validation fails.
Imagine a define an schema with two columns: A and B but I want to validate a dataset that contains both columns but another one that contains only column A.
Right now, even if I set the column as optional, pandantic expects the column to exist in the dataframe, if the column is missing it raises an error.
Do you plan to implement something like this in the near future? And what about the opposite, complain if there are columns that are not defined in the schema?
Thanks!

Hi @josedaniel-escribano-clarity ,
Thank you for your interest. Did you seen this in the README? That should work, only a different import is needed to specify the Optional type.
Cheers,
Wessel

I wrote some working tests which you can find here around using the pandantic.Optional type in your schema. Do you have an example of the pandantic.Optional type not behaving as expected?

I think it only works for numeric types.  I modified to
if isinstance(x, float) and math.isnan(x):
return None
and got the expected results for my Optional[str]

@josedaniel-escribano-clarity we are working on a major refactor and set of improvements!
@wesselhuising seems like this has been fixed, I am going to close for now, but if it is still an issue feel free to re-open and tackle in your refactor of the core library.