What do i have to do to see metrics from Flownative.Prometheus.FlowMetrics

Steps to reproduce:
Packages
neos/flow                               5.3.21             Flow Application Framework
flownative/prometheus                   0.7.0              Prometheus metrics for Neos Flow applications
flownative/prometheus-flow-metrics      0.2.2              Prometheus metrics for Neos Flow applications
...

If i get it right, the prometheus-flow-metrics should provide 2 metrics:

Number of requests - makes no sense for me
Number of sessions - makes total sense

Is:

The HttpMetricsCollector is called - no output.
The SessionMetricsCollectorService is not called.

Expectation:

Both metrics are exposed

Output
# Flownative Prometheus Metrics Exporter: There are currently no metrics with data to  export.

It seems to me, that the samples are empty:
Packages/Application/Flownative.Prometheus/Classes/Renderer.php:36

\Flownative\Prometheus\Renderer::render

Any idea?

PS: I just installed the 2 packages and applied the patch from #2 (but the output was the same before).
Esp. for the sessions i would also expect an output of 0 instead of nothing.

You should actually see something like this, even if there are no active sessions:
# HELP neos_flow_http_requests_total Number of HTTP requests processed by Flow's HTTP stack
# TYPE neos_flow_http_requests_total counter
neos_flow_http_requests_total{status="200"} 23
neos_flow_http_requests_total{status="201"} 1
neos_flow_http_requests_total{status="303"} 88
neos_flow_http_requests_total{status="403"} 3

# HELP neos_flow_sessions Number of Flow sessions
# TYPE neos_flow_sessions gauge
neos_flow_sessions{state="active"} 0

I just pushed a little change which gives you a hint in the metrics comment if there are actually no collectors registered or if there are collectors, but without data.
If that doesn't help, I guess you need to add some var_dumps here and there to see where things go wrong.

Mhmm ok - i think i get the point.
I tried to use the InMemoryCollector.
The Problem is that the collector is not executed when the /metrics endpoint is called - just parts of the framework are loaded.
class Package extends BasePackage
{
    /**
     * @param Bootstrap $bootstrap
     */
    public function boot(Bootstrap $bootstrap): void
    {
        $dispatcher = $bootstrap->getSignalSlotDispatcher();
        $dispatcher->connect(Bootstrap::class, 'finishedRuntimeRun', SessionMetricsCollectorService::class, 'collect');
    }
}

The above code gets executed all the time during a normal run - therefore it works for redis.
It's never executed during a call to  /metrics so that it can not display the number of active sessions at this point in time.
IMHO the example is misleading.
Steps to reproduce:
neos/flow 5.3.21
flownative/prometheus                   dev-master ba468c8 Prometheus metrics for Neos Flow applications
flownative/prometheus-flow-metrics      dev-master 0a3badc Prometheus metrics for Neos Flow applications

Output:
# Flownative Prometheus Metrics Exporter: There are currently no metrics with data to export.

The question is, if it's not better to emit a signal from the handle function of the MetricsExporterComponent?
Packages/Application/Flownative.Prometheus/Classes/Http/MetricsExporterComponent.php:76
That point in the code is always reached and also executed - only possible problem might be, that it's to early in the process flow for some metrics like response time ... mhmm.

Without touching the code i would do the following:
Settings.yaml
Neos:
  Flow:
    http:
      chain:
        'process':
          chain:
            'Flownative.Prometheus:metricsProvider':
              'position': 'before Flownative.Prometheus:metricsExporter'
              component: 'Flownative\Prometheus\FlowMetrics\Http\MetricsProviderComponent'

and the class just looks like that:
<?php

namespace Flownative\Prometheus\FlowMetrics\Http;

use Flownative\Prometheus\FlowMetrics\SessionMetricsCollectorService;
use Neos\Flow\Http\Component\ComponentContext;
use Neos\Flow\Http\Component\ComponentInterface;

/**
 * HTTP component which renders Prometheus metrics
 */
class MetricsProviderComponent implements ComponentInterface
{
    /**
     * @param ComponentContext $componentContext
     */
    public function handle(ComponentContext $componentContext): void
    {
        $smcs = new SessionMetricsCollectorService();
        $smcs->collect();
    }
}

Maybe it makes sense to switch to this approach to ensure metrics get always collected properly? - What's you opinion?

If I understand you correctly, I think you're approaching it contrary to the Prometheus best practices. The README of this package states:

The metrics endpoint (by default http(s)://your-host/metrics) collects
all current metric values from the storage and renders it in a format
which can be read by Prometheus. Therefore, metrics are not collected
or generated during a request to the metrics endpoint.

That's important. Metrics must be collected separately and not be triggered by some service fetching them via the telemetry endpoint. So, calling https://example.com/metrics and by that triggering a collection of the session metrics would be wrong.
The actual implementation depends on the metric you are trying to support. But most certainly, very few metrics will work with the InMemoryStorage.

But for what reason do we have the in memory storage then?
i thought i can simply poll the DB / redis during the metrics run (as it’s mostly counting)
this would also lower the impact for as the metrics are not updated during each and every request but once they are needed - which is only the metrics endpoint.

But for what reason do we have the in memory storage then?

For testing and development. As the README states:

By default, this plugin uses the InMemoryStorage for testing purposes. You will want to use the RedisStorage instead, so you don't loose all metrics values between requests.

Ok - will do a PR then, which makes it clear in the inMemory storage.


CLOUD_63513 Shell securitygroup select returns UndeclaredThrowableExc…

@doktoric pls review

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/448/


Middleware with parameters?

Is it possible to write middleware that accepts parameters like my example below?
 router.post('/ping', parseRequest('id123'), async (request, env) => {}

Yes it is!
You can check how I use middleware here
https://github.com/g45t345rt/cf-ssr-template/blob/9c4d9027fbe53e0cfbc2ce30899fd5b5f1e29538/src/server/post/index.ts#L9
https://github.com/g45t345rt/cf-ssr-template/blob/9c4d9027fbe53e0cfbc2ce30899fd5b5f1e29538/src/server/index.ts#L28

Thanks for answering @g45t345rt!  And yeah @socketopp, definitely possible :)
Middleware is literally any function that either:

responds with anything (breaks the response chain)... usually a Response unless you have something to catch the lack of Response downstream
doesn't response (continues to handle other middleware/handlers until one does).  This is how you would handle auth for instance... perhaps embedding the user into the request for future handlers, or conversely responding early with a 401 Response.

Hope this helps!


Extract Jest config from package.json to config file

Issue: https://github.com/storybooks/storybook/issues/2407
What I did

Extract Jest config of cra-kitchen-sink example  from package.json to an external config file so that CRA is happy and let us run the test via yarn run test.
The idea is to have both test & generate-addon-jest-testresults scripts to work with no interactions/limitations.

How to test

Checkout all-the-things
Go to cra-kitchen-sink example project
run yarn run test - it should run smoothly with some "expected" failure.
then run yarn run generate-addon-jest-testresults it should generate the JSON results.

Is this testable with jest or storyshots?
Nope
Does this need a new example in the kitchen sink apps?
Nope
Does this need an update to the documentation?
Nope
If your answer is yes to any of these, please make sure to include it in your PR.

ping @renaudtertrais can you PTAL and tell me what you think :thinking:


web_client always times out

web_client example always times out:
Connected to localhost:25565 (de8fdb9498a81150bd0149c6fcc7b24cecdd157be43dfcfc4b9014314652f3cc)
Forwarding socket with token de8fdb9498a81150bd0149c6fcc7b24cecdd157be43dfcfc4b9014314652f3cc
Connected to localhost:25565 (5b274b4949ff83f606d6b5ca70c59a2d5a66ea323b47f99ead3ceca08cb1e63b)
Forwarding socket with token 5b274b4949ff83f606d6b5ca70c59a2d5a66ea323b47f99ead3ceca08cb1e63b
TCP connection closed by remote (de8fdb9498a81150bd0149c6fcc7b24cecdd157be43dfcfc4b9014314652f3cc)
Websocket connection closed (de8fdb9498a81150bd0149c6fcc7b24cecdd157be43dfcfc4b9014314652f3cc)
TCP connection closed by remote (5b274b4949ff83f606d6b5ca70c59a2d5a66ea323b47f99ead3ceca08cb1e63b)
Websocket connection closed (5b274b4949ff83f606d6b5ca70c59a2d5a66ea323b47f99ead3ceca08cb1e63b)
Connected to localhost:25565 (b0d1b137f45d2976dff9f846bbe0aaf31969205b4485ff25d6257524abb3fe28)
Forwarding socket with token b0d1b137f45d2976dff9f846bbe0aaf31969205b4485ff25d6257524abb3fe28
Connected to localhost:25565 (24a6b2d8b679140361ceb90539470cc6105bd91a549dc8fea0b1ab745c6861a4)
TCP connection closed by remote (b0d1b137f45d2976dff9f846bbe0aaf31969205b4485ff25d6257524abb3fe28)
Websocket connection closed (b0d1b137f45d2976dff9f846bbe0aaf31969205b4485ff25d6257524abb3fe28)
Forwarding socket with token 24a6b2d8b679140361ceb90539470cc6105bd91a549dc8fea0b1ab745c6861a4
TCP connection closed by remote (24a6b2d8b679140361ceb90539470cc6105bd91a549dc8fea0b1ab745c6861a4)
Websocket connection closed (24a6b2d8b679140361ceb90539470cc6105bd91a549dc8fea0b1ab745c6861a4)

[14:31:33 INFO]: UUID of player pviewer_person is b5ccc8ad-2c12-3b62-8f45-77cd3f4061a3
[14:31:33 INFO]: pviewer_person joined the game
[14:31:33 INFO]: pviewer_person[/<IP_ADDRESS>:54835] logged in with entity id 1 at ([world]8.5, 56.0, 8.5)
[14:31:48 INFO]: pviewer_person lost connection: Timed out
[14:31:48 INFO]: pviewer_person left the game
[14:32:47 INFO]: UUID of player pviewer_person is b5ccc8ad-2c12-3b62-8f45-77cd3f4061a3
[14:32:47 INFO]: pviewer_person joined the game
[14:32:47 INFO]: pviewer_person[/<IP_ADDRESS>:54852] logged in with entity id 3 at ([world]8.5, 56.0, 8.5)
[14:33:02 INFO]: pviewer_person lost connection: Timed out
[14:33:02 INFO]: pviewer_person left the game

(There are so many errors because I refresh localhost:8080 to try and reconnect, but then it just times out again)
I have tried starting server with different -Dfml.readTimeout values, and always get the same problem

what error do you get exactly ? how did you run it ?


[OAP-1995][oap-native-sql] add NaN support in comparison

What changes were proposed in this pull request?
This pr aims to fix NaN and Infinity result mismatch in TPC-DS q17, q39a, q39b, by adding NaN comparison support.
fixes: https://github.com/Intel-bigdata/OAP/issues/1995
depends on: https://github.com/Intel-bigdata/arrow/pull/101
How was this patch tested?
Under performance testing still

spark.sql.columnar.sort.NaNCheck should be set true to get correct result for q17, q39a, q39b

@zhouyuan verified TPC-DS/H with correct results


Feature/payment allocations  pmt to opp sync  pgt unit tests

Creates three additional unit tests to verify features needed of the two-way payment allocation sync, in addition to necessary changes to the allocations service class for these tests to pass.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-031837

Tracking W-031837


Add tests for vscode-bicep

I meant to send out this earlier but I was blocked by a weird vscode import issue...anyway I spent another weekend finally figured it out.
The PR doesn't contain all the necessary tests, but the main goal is to set up the basic structure and configs so that we can easily add more unit and e2e tests in the future.

Codecov Report

Merging #686 into main will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   95.25%   94.98%   -0.27%
==========================================
  Files         263      264       +1
  Lines       10854    10932      +78
==========================================
+ Hits        10339    10384      +45
- Misses        515      548      +33

Flag
Coverage Δ

#dotnet
94.98% <ø> (-0.27%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cep.Core.UnitTests/FileSystem/FileResolverTests.cs
67.92% <0.00%> (-32.08%)
:arrow_down:

src/Bicep.Core/Syntax/SyntaxBase.cs
52.00% <0.00%> (-24.00%)
:arrow_down:

...p.LangServer/Completions/BicepCompletionContext.cs
94.56% <0.00%> (-3.69%)
:arrow_down:

src/Bicep.Core/Syntax/SyntaxVisitor.cs
94.65% <0.00%> (-2.34%)
:arrow_down:

src/Bicep.Core/Parser/Parser.cs
93.41% <0.00%> (-1.43%)
:arrow_down:

....LangServer/Completions/BicepCompletionProvider.cs
96.77% <0.00%> (-0.47%)
:arrow_down:

src/Bicep.Core/Parser/Lexer.cs
97.71% <0.00%> (-0.06%)
:arrow_down:

src/Bicep.Core/LanguageConstants.cs
100.00% <0.00%> (ø)

src/Bicep.Core/Syntax/ArraySyntax.cs
100.00% <0.00%> (ø)

src/Bicep.Core/Syntax/ArrayItemSyntax.cs
100.00% <0.00%> (ø)

... and 12 more

This partially addresses https://github.com/Azure/bicep/issues/381.

  default:

This is unrelated to your PR, but I never got the default project to work right. (It's supposed to generate a status check on PRs.) I wonder if we'll need to disable the default project and create one for dotnet (I never tried it)

Refers to: codecov.yml:10 in 5122427. [](commit_id = 512242712e4b94924808dc8760db760bfa25761d, deletion_comment = False)

Thanks for the approvals!


feat: allow augmentation of payload object with generated types

This PR allows you to type additional properties that you may want to add to payload.
Example usage:
payload.config.ts:
  typescript: {
    outputFile: path.resolve(dirname, 'payload-types.ts'),
    payloadSchema: [
      ({ jsonSchema }) => {
        return {
          ...jsonSchema,
          additionalProperties: false,
          properties: {
            hello: {
              type: 'object',
              additionalProperties: false,
              properties: {
                someFn: {
                  description: 'Hello there',
                  tsType: '(a: number, b: number) => number',
                },
              },
            },
          },
        }
      },
    ],
  },

This generates:
declare module 'payload' {
  // @ts-ignore
  export interface GeneratedTypes extends Config {}

export interface BasePayload {
  hello?: {
    /**
     * Hello there
     */
    someFn?: (a: number, b: number) => number;
  };
}
}

And now this is fully-typed:

Closing in favor of using declare module in the plugin directly


Separate physics force and impulse into their own components

Currently we the force and impulse on a particle through the PhysicsVelocity component, which is not an optimal design. Aditionally we are modifying these values directly, which is error prone and in the future it will be useful to have an interface so we can have calculations that are transparent to the user.
We should have PhysicsForce, PhysicsImpulse and PhysicsVelocity as separate components.
PhysicsForce will hold the force, and it will have a method to apply force to the particle.
PhysicsImpulse will hold the impulse, and it will also have a method to apply an impulse to the particle.
Both of these will be cleared every frame.
PhysicsVelocity will only hold the velocity of the node, which you can change by modifying it's value directly.

LGTM! What do you think about removing the Physics prefixes from those names? I think we don't have to worry about naming conflicts with Force, Impulse and Velocity on the engine.

LGTM! What do you think about removing the Physics prefixes from those names? I think we don't have to worry about naming conflicts with Force, Impulse and Velocity on the engine.

I think it would look much cleaner so I'm all in for removing it.


[benchmark] Add conditional to each ansible playbook that require SSH into the Helix Core instance | 69522

Ticket
69522 : Add conditional to each ansible playbook that require SSH into the Helix Core instance
Changes

Add a condition to the utils/run_bench.sh script to avoid executing the ansible-playbook which requires the connection via SSH with the Helix Core instance.
Add a condition to the utils/analyse.sh script to avoid executing the ansible-playbook which requires the connection via SSH with the Helix Core instance.

Sure @aboutte I will create a task to work on this improvement.


[ckworker/cklib] Optimize usage of deferred connections

Deferred connections are graph edges that could not be resolved at collect time.
This PR:

adds an arg --ignore-deferred-connections which turns off the resolving of such during the graph sanitise.
tries to resolve deferred connections early

Background:
Cloudkeeper collects accounts and regions in parallel, building a subgraph per region. This allows it to scale well with many CPU cores. However some edges go across regions (e.g. IAM instance profile to an instance in another region). For those deferred_connections were added to the graph. When a connection between two resources can not be made in the local subgraph, that connection is stored and later searched when all subgraphs have been merged into the global graph.
However this also means that worst case the final search happens single threaded on the global graph with O(n^2) complexity. In praxis this isn't the case since very few resources create deferred connections, but even a few thousand can slow down collect performance considerably.

This PR does this actually. The ignore is just in addition to the optimization.
The self.resolve_deferred_connections() in the graph merge() method does exactly that. It tries to find deferred connections early in the account collection thread, before handing the cloud graph to the worker thread. So best case all the connections could already be resolved on the account level.


frontend check that an update has a reference selected

I just can't find a way around the ts error

@kaarleol I think the ts error is due to the path alias ('@/backendTypes') in import.
Notice how it is backends tsc that fails? That is because backend code uses some files from frontend, but it doesn't know about frontend path aliases. That's why you can't use path aliases in those files, you must use relative paths. For the same reason you shouldn't import other frontend files into these shared files. I think I wrote a comment about these limitations into the backendTypes file, but the file/folder structure is now a bit different so it's less obvious to see it.
I'll try to make a fix to the entire shared directory / filenames later, and I'll make it a PR so your group can approve and merge it. There's a couple very confusing things that I left there.


Json Repl API

Write some macros that take inline json and serialise it to JsonValue at compile time. For most cases, there would be 2 steps:

Compile-time serialisation of json

Runtime serialisation and replacement of replacement tokens

The macro design could look something like this:
json!(a, b, c, {
    'a': $a,
    'b': {
        'ba': $b
    },
    $c: 'value'
});

Where a, b and c are Serialize. The json! macro could be backed by two macros; one which does the actual parsing and serialisation, and the other that splices in replacement values:
let json = json_ser!({
    'a': $a,
    'b': {
        'ba': $b
    },
    $c: 'value'
});

This would result in:
JsonPartialResult {
    json: JsonValue,
    replacements: BTreeMap<String, ReplacementPath>
}

impl JsonPartialResult {
    pub fn replace(&self, repls: BTreeMap<String, JsonValue>) -> JsonValue;
}

enum ReplacementPath {
    Key(String),
    Value(String)
}

The replacements value would look like:
"a": Value("a"),
"b": Value("b.ba"),
"c": Key("")

We then use a macro to splice the replacements in. This would be done at runtime:
let mut repls = BTreeMap::with_capacity(3);
repls.insert("a", a);
repls.insert("b", b);
repls.insert("c", c);

let result = json.replace(repls);

If the json macro doesn't contain replacement chars, then we just return the result, otherwise, we return the expression calling json.replace, so values can be spliced in at runtime.

Playing around with some json parsing. With a lot of polishing up this could actually be pretty good.
https://gist.github.com/anonymous/38e898fa5e2e47258627

I might look at moving this to 0.2, since it's a demonstration of the direction for the high-level API.
Originally, I wanted to follow the design of the C# client with its fluent API, but I quite like the idea of sticking to the JSON syntax fairly closely. Type info will be available where important; on docs and doc types.
The replacement params will have the requirement that they implement Serialize so we could do:
let doc = MyDoc {
    ...
};

json!(
    params: doc,
    body: {
        "doc" : $doc,
        "doc_as_upsert" : true
    }
);

So in this case, we return a partial result of the JsonValue, with the replacement tokens and an expression to replace $doc with doc

New playground: https://gist.github.com/99d8cb837c03546d5f08

Got something simple working. It needs a lot of cleanup though.

Going to work on making it possible to supply JSON without quoting keys:
body!(
    mykey: "myvalue",
    myobj: {
        mykey: [],
        mynum: 15
    }
);

Which would be the same as:
body!(
    "mykey": "myvalue",
    "myob"j: {
        "mykey": [],
        "mynum": 15
    }
);

There should be a sanitising step that strips out whitespace and quotes unquoted keys

Json replacement is implemented. It looks like it covers things nicely. Will clean up and add before splitting up for replacements.
https://gist.github.com/b98dee7a60a5e364ddf1

Bench results for the json macro are looking pretty good to start with. For simple scenarios, where you don't need any replacements, it packs the json up as a string for you for super performance:
The replacement macros also seem to scale linearly with the amount of work they need to do, which is nice:
test parse_plain_json_lrg ... bench:           0 ns/iter (+/- 0)
test parse_plain_json_med ... bench:           0 ns/iter (+/- 0)
test parse_plain_json_sml ... bench:           0 ns/iter (+/- 0)
test parse_repl_json_lrg  ... bench:       2,740 ns/iter (+/- 6)
test parse_repl_json_med  ... bench:       1,698 ns/iter (+/- 48)
test parse_repl_json_sml  ... bench:         893 ns/iter (+/- 48)

Last todo here is to rename json! to body! and to add another macro that's almost exactly the same, but instead of returning a string, return serde_json::Value of the result.

Docs are all up. I'm going to close this for now. The json! impl is in a pretty good place, so will open separate issues for enhancements.


HTML pages below maxDepth fetched

Issue #77 says that "If the HTML page depth is greater than max depth, we will not fetch it and not discover resources on it" and while the latter is true, the former is not.
Running with a simple crawler:
var Crawler = require('simplecrawler');
var crawler = new Crawler("en.wikipedia.org", "/wiki/Fuel_economy_in_automobiles");
crawler.maxDepth = 1;
crawler.maxConcurrency = 5;
crawler.downloadUnsupported = false;
crawler.start();

Every page linked from the first one is downloaded

same here

Same here. Seems like version 0.3.10 is published on npmjs, but the version in master is 0.3.11.
A simple console.log confirms the missing feature:
var crawler = new Crawler('localhost', '/', 3000);
console.log(crawler.filterByDomain);
console.log(crawler.proxyHostname);
console.log(crawler.maxDepth);
crawler.maxDepth = 1;
console.log(crawler.maxDepth);

@AndriusA is correct, resources one level above maxDepth are fetched, but are not "discovered", even on v0.3.11.
simplecrawler fetches every url one level above maxDepth to determine the MIME type of that url, so that things like css/js/img/whatever can be "discovered".
I forked a change that never fetches above maxDepth (see c83ab74fa42b3b3e35f4bd8ca82d33e64e580158).  This does have the consequence of not fetching a page's css/js/img/whatever if the page's depth +1 === maxDepth.
I think the best fix would be to examine the context of links on a page (ie. is the href in a <link>, is the src in a <script>, etc) when determining if they should be fetched, instead of just fetching everything.

Hi All — I've changed the behaviour of this feature in v0.5.0 as I agreed it was confusing. There's now an incredibly verbose switch called crawler.fetchWhitelistedMimeTypesBelowMaxDepth — set this to true to return to the old behaviour. Otherwise, the default behaviour should now match your expectations!


Segmentation Fault when using Typhoeus Gem in a Chef Environment

Good morning, I would like to ask for help in a problem that I am having with the interaction between the chef-client environment and Typhoeus library. My goal in this specific cookbook is to install InfluxDB2 by the chef and the connection to the host has to be done by https. For this reason, a self-signed certificate was created by my company. To interact with the InfluxDB service, there is an API, which uses this Typhoeus library. I got a "[BUG] Segmentation fault" error and after much research I found that the problem is the interaction of this library with the chef-client, since my script to test this library works locally without any problem. Attached I send a test script for this library as well as the logs with two tests, one with my host and the other with "https://ww.google.com".  I don't know if they can help me but I ask you to try, since it is an important part of the project where I am.  If you need all file logs let me know. Cheers.
Log 1:

Log 2:

Code:

@Galactic21 Did you find any solution for this?


colorful log after concurrently

It becomes normal.

This is duplicate to #8. Let's continue there.

Fixed in new release: https://github.com/kimmobrunfeldt/concurrently/releases/tag/2.0.0
See issue #8 for the explanation.


Clickhouse complains on too many partitions for single INSERT block

I get following clickhouse error while loading data to gwas_chr_* table with the backend script:
Code: 252. DB::Exception: Received from otg-clickhouse:9000, <IP_ADDRESS>. DB::Exception: Too many partitions for single INSERT block (more than 100). The limit is controlled by 'max_partitions_per_insert_block' setting. Large number of partitions is a common misconception. It will lead to severe negative performance impact, including slow server startup, slow INSERT queries and slow SELECT queries. Recommended total number of partitions for a table is under 1000..10000. Please note, that partitioning is not intended to speed up SELECT queries (ORDER BY key is sufficient to make range queries fast). Partitions are intended for data manipulation (DROP PARTITION, etc).

Here is a snippet of the table declaration:
create table if not exists sumstats.gwas_chr_$chrom
engine MergeTree partition by segment order by pos_b37

it looks like segment column by having more than 100 distinct values casing the error.

It seems like clickhouse have gotten this check since <IP_ADDRESS> version.  See https://clickhouse.yandex/docs/en/changelog/

The error message looks pretty informative and gives some options on how to fix the issue:

Stop partitioning by segment. Change declaration of the table to smth like ... engine MergeTree order by (segment, pos_b37) ...
Set max_partitions_per_insert_block to higher number or (as the docs says) to 0.

More investigation is needed to say what impact it would have on querying performance.

I've added a clichouse configuration here https://github.com/opentargets/genetics-backend/pull/9


vendoring: update openshift/api

Update CPMS with a new openshift/api, which includes changes in the FailureDomains.

/retest-required

/test e2e-azure-operator

/assign damdo


Touchforms access fix

noice.

@orangejenny Hey, can you double check real quick when you get a change whether there are any negative consequences to making this method public/whether that was intended?


Allow capturing diagnostic data from Python hosts

Is your feature request related to a problem? Please describe.
Often, it's useful to be able to capture diagnostic information such as the states returned by DumpMachine and DumpRegister. This information is sent as JSON encoded into 'display_data' messages across Jupyter sessions, such that wavevectors can be extracted by overriding display hooks. For example, the sample at https://github.com/microsoft/quantum/blob/2a541167f844ce03b898bccc784013514e9f6fb0/samples/simulation/gaussian-initial-state/host.py uses this technique to plot initial Gaussian states:
# Add a new message handler to the IQ# client that listens for the output
# of DumpMachine and DumpRegister. This will let us make nicer plots
# in matplotlib.
old_handler = qsharp.client._handle_message
def handle_state_dump(message, **kwargs):
    if message['msg_type'] == 'display_data':
        data = (
            # Check both the old and new MIME types used by the IQ#
            # kernel.
            json.loads(message['content']['data'].get('application/json', "null")) or
            json.loads(message['content']['data'].get('application/x-qsharp-data', "null"))
        )
        if data is not None and 'amplitudes' in data:
            states.append(data['amplitudes'])
            return

    old_handler(message, **kwargs)
qsharp.client._handle_message = handle_state_dump

Describe the solution you'd like
It would be nice if the qsharp package offered a hook to add such listeners directly without needing to dynamically replace the definition of the internal qsharp.client._handle_message method. This could be done in a variety of different approaches:
# As a context manager:
with qsharp.capture_display_data() as diagnostics:
     operation.simulate()
states = [data['amplitudes'] for data in diagnostics if 'amplitudes' in data]

# As a new special keyword argument to .simulate, .simulate_noise, etc.
# NB: need __ to prevent collision with Q# input names.
result, diagnostics = operation.simulate(__capture=True)

# As a function that sets a callback listener.
diagnostics = []
qsharp.add_display_data_callback(lambda display_data: diagnostics.append(display_data))
operation.simulate()
[data['amplitudes'] for data in diagnostics if 'amplitudes' in data]

As a quick follow-up, it may also be nice to allow users to work with representations of display data using familiar quantum information libraries. For example, I threw together a quick proof-of-concept for allowing capturing as QuTiP Qobj instances:


Add workaround in docs for git bash usage issue

When using boot2docker through git bash, there is a nasty issue when trying to share a folder, due to how git bash parses the URIs. The issue is explained in issue #12751 but needs more visibility in the docs.
Signed-off-by: Matthieu Larcher<EMAIL_ADDRESS>

Thanks! LGTM
ping @fredlf @jamtur01 @moxiegirl @SvenDowideit

ping @tianon Who suggested use of the quotes.

LGTM and makes sense from the bug report.

Technically LGTM as well, however I'm not sure if we should show an example or link to a gh issue from the docs in this case.

@ahmetalpbalkan You make a good point. The contributor includes the link...so covered there. As for the example...
There are lots of "notes" on this page with gotchas.  That's an indication of a structural issue on the page.  I think we should add a Known Issues or Troubleshooting section and consolidating all the applicable notes under that.  Then, we could have more examples for each problem while simplifying the page instructions.
LGTM then as is.  I'll carry the fix to the page structure. @thaJeztah Your call on the merge if you want to wait for Tianon or not.

@moxiegirl agreed on cleaning up the notes. Given that I've seen quite some people running into this (or similar), I don't think it "hurts" to give the problem a bit more visibility.
I'll merge this, but yeah, it needs a cleanup.
Thanks for your contribution, @mlarcher please don't let the above discussion "put you off"; it's a general problem that the docs need a cleanup once in a while, this PR just "triggered" the discussion on that topic :smile:

@mlarcher Thank you for the contribution. And for drawing attention to a larger issue on the page.
@thaJeztah Issue created for a maker.

cherry-picked

@moxiegirl No worries, I'm glad to participate and help others avoid this issue that took me some time to figure out. I agree those notes should be gathered in a troubleshooting section. Keep up the good work.


fix: use average date instead of max date for icicle date sorting

Download Artifacts :

win-ia32
win-x64
linux-x64


text for labeling

From the instruction in the page it is unclear if each text must be in seperate file. Can it be in format of a table like for OpenAI?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40022a84-e1da-2ea9-293b-5666ea8f5828
Version Independent ID: ca1f88a9-0ce6-e728-9447-12569819d215
Content: How to label your data for custom classification - Azure Cognitive Services
Content Source: articles/cognitive-services/language-service/custom-text-classification/how-to/tag-data.md
Service: cognitive-services
Sub-service: language-service
GitHub Login: @aahill
Microsoft Alias: aahi

@kubasiak
Thanks for your feedback! We will investigate and update as appropriate.

@aahill
Could you please review and add your comments on this, update as appropriate.

@kubasiak
Thank you for bringing this to our attention. I've assigned this issue to the author who will investigate and update as appropriate.

Thanks for reaching out,
Text data has to be uploaded as separate .txt files to your storage account.
https://learn.microsoft.com/azure/cognitive-services/language-service/custom-text-classification/how-to/design-schema#data-preparation
I'll update the documentation to make this more clear.
#please-close


Add new section: Magazine, with a phparch link

I suggest to add a new section called Magazines, with the most popular: php[architect]

Thanks, this looks great.


are there TTL for application descriptors which fetched from (custom) channels?

I was playing with the channels and I couldn’t figure out the time after which CS refreshes the cached channel file (application descriptors).
More specifically,
I have added a channel using the —add-channel option, the channel is a file from a  Github repo.
So whenever I do some changes in channel file (like add new app), and try to consume it,
sometimes it picks up the changes right away, sometimes it takes minutes to get the changes.
So my question was, Is there a timeout after which the descriptors will be fetched?

The default TTL is 24 hours. You can adjust it by passing --ttl … on the command-line, or setting COURSIER_TTL in the environment.

The TTL is for changing things is what the documentation says.
So Just for my clarification,
are application descriptors considered one of those changing files?


Error when running Baysor downloaded binary

Hi Viktor,
I'm attempting to run Baysor using the most recent release binary (v0.5.2) on bayes. Running into the below issue:
(base) tenggao@bayes:~/Baysor/bin$ ./Baysor
fatal: error thrown and no exception handler available.
InitError(mod=:MKL_jll, error=ErrorException("Cannot locate artifact 'MKL' in '/home/runner/.julia/packages/MKL_jll/kG4RZ/Artifacts.toml'"))
error at ./error.jl:33
#ensure_artifact_installed#22 at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/Pkg/src/Artifacts.jl:401
unknown function (ip: 0x7f65fbe9117a)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
ensure_artifact_installed##kw at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/Pkg/src/Artifacts.jl:399
unknown function (ip: 0x7f65fbe90e68)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
_artifact_str at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/Artifacts/src/Artifacts.jl:547
jfptr__artifact_str_55136.clone_1 at /home/tenggao/Baysor/lib/julia/sys.so (unknown line)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
jl_f__call_latest at /buildworker/worker/package_linux64/build/src/builtins.c:757
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
do_apply at /buildworker/worker/package_linux64/build/src/builtins.c:713
#invokelatest#2 at ./essentials.jl:716
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
do_apply at /buildworker/worker/package_linux64/build/src/builtins.c:713
invokelatest at ./essentials.jl:714
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:126
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:215
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:166 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:587
jl_fptr_interpret_call at /buildworker/worker/package_linux64/build/src/interpreter.c:675
macro expansion at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/Artifacts/src/Artifacts.jl:680 [inlined]
find_artifact_dir at /home/runner/.julia/packages/JLLWrappers/QpMQW/src/wrapper_generators.jl:17
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
__init__ at /home/runner/.julia/packages/MKL_jll/kG4RZ/src/wrappers/x86_64-linux-gnu.jl:9
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
jl_module_run_initializer at /buildworker/worker/package_linux64/build/src/toplevel.c:73
_finish_julia_init at /buildworker/worker/package_linux64/build/src/init.c:796
julia_init at /buildworker/worker/package_linux64/build/src/init.c:730
jl_init_with_image at /buildworker/worker/package_linux64/build/src/jlapi.c:74
jl_init at /buildworker/worker/package_linux64/build/src/jlapi.c:90
main at ./Baysor (unknown line)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_start at ./Baysor (unknown line)

The Julia binary also throws a similar error. Do you have suggestions on how to fix this?

Hi Tang, that also should be fixed in v0.6.0


[Chat Participant API] [Regression] token limit has been exceeded

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Insider of 2024-02-19
OS Version: Windows

Steps to Reproduce:

Create a VS Code extension using Chat Participant API
Call access.makeChatRequest(messages, {}, token) using messages with more characters (e.g. characters of 30k length).

Actual:
Meet with Message exceeds token limit error like below:

Expected:
In VS Code 1.86 stable version, install Azure API Center extension, with the same length of messages, the LLM respond without error.
So I think it is a regression of token limit.

This is enforced by the extension implementing/providing LM access (copilot-chat). The current ruling is that LM access only gets a 4k token window


Automated Package Upgrade

:tada: This PR is included in version 6.0.64 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fails to build

I get this error when I build the model. Batch size is usually set to None, so I'm not sure why it expects a number here.
--> 110         batch_size = int(inputs.get_shape()[0])
    111         channel_in = int(inputs.get_shape()[-1])
    112         in_h, in_w = [int(i) for i in inputs.get_shape()[1: 3]]  # input feature map size

TypeError: __int__ returned non-int (type NoneType)

Sorry, the code can only run in tf eager execution.

How difficult is it to make it available not in eager execution? I'd be willing to spend some time on this, but kind of need some guidance.

Are deformable convolutions still popularly used or are there better layers out there that perform similarly?

I think it's not difficult to convert the code in graph execution. However, my re-implementation is not efficient, because I use high level TensorFlow API in my code. You can use c++ implementation in your project.

TensorFlow: https://github.com/Zardinality/TF-deformable-conv
PyTorch: https://github.com/chengdazhi/Deformable-Convolution-V2-PyTorch

Deformable conv is still useful in object detection, since it can adjust the receptive field and sample location dynamically according to the feature.
For more detail, you can refer to the following papers:

Deformable Convolutional Networks
Deformable ConvNets v2: More Deformable, Better Results

@tom-bu Did you get success in converting it to non-eager executable code?
@DHZS can you help in this?


task: review hello world tutorials

Problem

lack of hello world tutorials

Solution

several hello world tutorials will be added, pls review them!
discussion

Alternatives
No response

@bguiz can this issue be closed or are there more tutorials incoming?

Resolves #394


[feat] - dojot acl service

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Is there any issue related to this PR? (Link to an issue, e.g. #99999)

Other information:

Please, associate this PR with a issue.


Fixes  #48 by having can_parse_alternatives actually check for only parsing of alternatives.json file

Description:
Fixes #48 by having can_parse_alternatives actually check for the only parsing of alternatives.json file at the root of the repository, no network access needed.
Related Issues: (optional)
#48

Oops, messed up on the branch that I'm merging from, and also forgot to run cargo fmt, closing this pull req, and opening a new one.


GPU integration with ManjaroWSL2

Requirements

[X] Yes
[ ] No

WSL Version

[X] WSL 2
[ ] WSL 1

Version
Microsoft Windows [Version 10.0.22631.2861]
Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Repro Steps
I came into this while using hashcat:
hashcat -I
hashcat (v6.2.6) starting in backend information mode
clGetPlatformIDs(): CL_PLATFORM_NOT_FOUND_KHR

ATTENTION! No OpenCL, HIP or CUDA compatible platform found.

You are probably missing the OpenCL, CUDA or HIP runtime installation.

* AMD GPUs on Linux require this driver:
  "AMDGPU" (21.50 or later) and "ROCm" (5.0 or later)
* Intel CPUs require this runtime:
  "OpenCL Runtime for Intel Core and Intel Xeon Processors" (16.1.1 or later)
* NVIDIA GPUs require this runtime and/or driver (both):
  "NVIDIA Driver" (440.64 or later)
  "CUDA Toolkit" (9.0 or later)

Despite nvidia-smi finding my 4070 gpu.
Is there a way to apply computation via my host GPU?
Seems Nvidia supports easy installation for Ubuntu, and hints on installing nvidia-toolkit-12-x alone to handle this on other distros.
https://docs.nvidia.com/cuda/wsl-user-guide/index.html#getting-started-with-cuda-on-wsl
Expected Behavior
It would be nice to be able to run GPU processes on the WSL side, might be beneficial for machine learning or hash cracks...
Actual Behavior
I can detect the GPU with nvidia-smi, but cant using clinfo, hashcat, or johntheripper.

https://gist.github.com/slavistan/53c8e2627bf9ca202ab6c56ef4d5c497


Enhance observer response methods

There now exists a pre and post request callback but we need to document it

From what I can tell, this looks documented now. Closing.


Unable to write GPCCA estimator to file

Hey guys!
I'm interested in saving my GPCCA kernel to a file with the code below:
from cellrank.tl.estimators import GPCCA
g = GPCCA(combined_kernel)
g.compute_schur(n_components=20)
g.compute_metastable_states(n_states=7, cluster_key='cell_type')
g.set_final_states_from_metastable_states()
g.compute_absorption_probabilities()
g.write(out_dir + 'cellrank.dynamical.dc_corr.%s.GPCCA' % (thr))

but I get the following error:
WARNING: Unable to compute metastable states with `n_states=7` because it will split the conjugate eigenvalues. Increasing `n_states` to `8`
Traceback (most recent call last):
  File "/home/chanj3/scripts/HTA.RU263.RNA_velocity/run_cellrank.select_genes.dc_corr.py", line 98, in <module>
    g.write(out_dir + 'cellrank.dynamical.dc_corr.%s.GPCCA' % (thr))
  File "/home/chanj3/anaconda3/envs/py3.7/lib/python3.7/site-packages/cellrank/tl/estimators/_base_estimator.py", line 928, in write
    pickle.dump(self, fout)
  File "/home/chanj3/anaconda3/envs/py3.7/lib/python3.7/enum.py", line 44, in _break_on_call_reduce
    raise TypeError('%r cannot be pickled' % self)
TypeError: stochastic cannot be pickled

Any help is as always super appreciated!
Joe

Hi @jmchan88 ,
this is an issue with Python3.6 - it can't pickle enums. I am in the process of fixing this.

Please let me knot if #390 fixed this for you.

Hello,
If I save the GPCCA kernel using g.write('g.GPCCA' ), how can I open it afterwards?
Thanks

Hi @aterceros, the documentation for the write method tell you: Serialize self to a file using [pickle](https://docs.python.org/3/library/pickle.html#module-pickle) (see https://cellrank.readthedocs.io/en/latest/api/_autosummary/estimators/cellrank.estimators.GPCCA.html#cellrank.estimators.GPCCA.write). Asking chatGPT how to read in pickled objects tell me:
import pickle

with open('your_file.pkl', 'rb') as file:
    loaded_object = pickle.load(file)

In this case, the loaded_object should be your GPCCA estimator object again.

Thank you so much!


Support several backends

Allow setting

port
domain
path

differently for each site
the default site is special and doesn't take any customisation.


I am facing the following issue while installing mongo extension in any php 7 & above versions

Output
===> Running make all: /usr/bin/make -C '/Users/tony/.phpbrew/build/php-7.1.4/ext/mongo//' 'all'  >> '/Users/tony/.phpbrew/build/php-7.1.4/ext/mongo///build.log' 2>&1
Error: Command failed: /usr/bin/make -C '/Users/tony/.phpbrew/build/php-7.1.4/ext/mongo//' 'all'  >> '/Users/tony/.phpbrew/build/php-7.1.4/ext/mongo///build.log' 2>&1 returns:
The last 5 lines in the log file:
#define add_assoc_string(__arg, __key, __str) add_assoc_string_ex(__arg, __key, strlen(__key), __str)

        ^

fatal error: too many errors emitted, stopping now [-ferror-limit=]

9 warnings and 20 errors generated.

make: *** [php_mongo.lo] Error 1

Please checkout the build log file for more details:
	 tail /Users/tony/.phpbrew/build/php-7.1.4/ext/mongo///build.log

Expected Result
Mongo extension installed

Command
phpbrew ext install mongo

Build Log
tail /Users/tony/.phpbrew/build/php-7.1.4/ext/mongo///build.log
^
/Users/tony/.phpbrew/build/php-7.1.4/ext/mongo/php_mongo.c:553:46: error: too many arguments provided to function-like macro invocation
add_assoc_string(tagset, name, colon + 1, 1);
^
/Users/tony/.phpbrew/php/php-7.1.4/include/php/Zend/zend_API.h:411:9: note: macro 'add_assoc_string' defined here
#define add_assoc_string(__arg, __key, __str) add_assoc_string_ex(__arg, __key, strlen(__key), __str)
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
9 warnings and 20 errors generated.
make: *** [php_mongo.lo] Error 1
Platform
OS: OS X 10.13.2
Running PHP:
PHP 7.1.7 (cli) (built: Jul 15 2017 18:08:09) ( NTS )
Installing PHP:
PHP 7.1.4 (cli) (built: Jul 15 2017 18:08:09) ( NTS )

Anybody for rescue ?

I install the mongodb extension and it's worked successfully in the installing PHP 7.3 version.
$ phpbrew --debug ext install mongodb
......
===> Installing...
Installing shared extensions:     /root/.phpbrew/php/php-7.3.33/lib/php/extensions/no-debug-non-zts-20180731/
Installed extension library: /root/.phpbrew/php/php-7.3.33/lib/php/extensions/no-debug-non-zts-20180731/mongodb.so
===> Extension is installed.
===> Creating config file /root/.phpbrew/php/php-7.3.33/var/db/mongodb.ini.disabled
/root/.phpbrew/php/php-7.3.33/var/db/mongodb.ini.disabled is created.
===> Enabling extension mongodb
[*] mongodb extension is enabled.
Done.

I also notice that the Mongo extension is not maintained anymore.
It should use the mongodb extension instead.


fixed a bug in rotevo.py that broke AgesOut

Was trying to run Mors.Star for specific ages using AgesOut. The code broke on a line calling _getIndexGT from stellarevo.py rather than miscellaneous.py. This change fixed the code for me.

Thanks for the fix.


Update docs links for workbench

Signed-off-by: Joshua Li<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
fixes https://github.com/opensearch-project/sql/issues/350
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #352 (06debad) into main (013d402) will decrease coverage by 33.60%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##               main     #352       +/-   ##
=============================================
- Coverage     96.52%   62.91%   -33.61%
=============================================
  Files           266       10      -256
  Lines          7191      658     -6533
  Branches        540      118      -422
=============================================
- Hits           6941      414     -6527
+ Misses          196      191        -5
+ Partials         54       53        -1

Flag
Coverage Δ

query-workbench
62.91% <50.00%> (ø)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

workbench/public/components/Main/main.tsx
53.00% <50.00%> (ø)

...rg/opensearch/sql/planner/logical/LogicalEval.java

...g/opensearch/sql/expression/LiteralExpression.java

...search/response/agg/NoBucketAggregationParser.java

...ava/org/opensearch/sql/utils/SystemIndexUtils.java

...l/expression/window/ranking/RowNumberFunction.java

...org/opensearch/sql/analysis/QualifierAnalyzer.java

...g/opensearch/sql/data/model/ExprIntervalValue.java

...pensearch/sql/ppl/parser/AstExpressionBuilder.java

...rg/opensearch/sql/ppl/domain/PPLQueryResponse.java

... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013d402...06debad. Read the comment docs.


[release-0.56] tests, console: Prevent NewExpecter negative timeout scenario

What this PR does / why we need it:
This is a manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/9497 and the proposed change in https://github.com/kubevirt/kubevirt/pull/9515.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/uncc @kbidarkar @vasiliy-ul
/cc @ormergi @AlonaKaplan

Why did you have to run make generate for this backport?

Why did you have to run make generate for this backport?

So the pull-kubevirt-generate lane will pass.

Why did you have to run make generate for this backport?

So the pull-kubevirt-generate lane will pass.

This lane fail every new year, because it runs make generate and then sees a git diff because the year in the license comment has been updated to the current year.

/retest-required

/lgtm

Change: Added the commit from PR #8987 in order to pass the pull-kubevirt-e2e-windows2016 lane.


Runtime error from boost::bad_get

Hello,
I have to apologize in advance since this will probably turns out to be an error of mine and not an issue of Pinocchio, but I don't know where else to ask. I am looking around for an alternative to our current humanoid computation library (translation: I am very new to Pinocchio!). I tried to do a very simple test to get familiar with the way of pinocchio which is like this:
se3::Model model;
se3::Data  data(model);
se3::urdf::buildModel("path/to/model.urdf",model);
Eigen::VectorXd q = Eigen::VectorXd::Random(model.nq);
Eigen::Vector3d com = se3::centerOfMass(model,data,q);

This compiles, however, there is a runtime error:
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::bad_get> >'
  what():  boost::bad_get: failed value get using boost::get

Debugger traces it back to these calls. In another attempt I tried another functionality (se3::crba(model,data,q); to do a se3::getComFromCrba(model,data);) but same error with this gist.
Any idea about what am I doing wrong here? Thanks!

Built from source.Built with -DBUILD_PYTHON_INTERFACE=OFFTested with both master and devel branch

Hi Pouya,
Before investigating your issue, can you tell me which version of Boost, Eigen and urdfdom are you using?
Justin

Ok, your first need to create your model and then to build your data structure.
se3::Model model;
se3::urdf::buildModel("path/to/model.urdf",model); // first load your model ...
se3::Data data(model); // ... and then build data from model
Eigen::VectorXd q = Eigen::VectorXd::Random(model.nq);
Eigen::Vector3d com = se3::centerOfMass(model,data,q);

Best,

Hi jcarpent,
You are indeed right. Thank you very much.
Best.


fix clippy lints from the future

Motivation and Context

Because the build pipeline is checking for these.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I keep running into "aws-smithy-mocks-experimental changed since release-2024-02-22 and requires a version bump". I'm surprised that it's triggering that because all I did was add a clippy allow.


🐛 [Bug] Some Suggestions

Before feedback (在反馈之前)

[X] I've searched the existing Issues, Discussions and Google (我已经搜索了现有的 Issues, Discussions 和 Google)
[X] The problem can be stably reproduced (这个问题可以被稳定复现)
[X] The problem is generated after upgrading (问题是在升级之后产生的)

Operating System (操作系统)
Linux
Golang Version (Go 版本)
1.18.x
Goravel Version (Goravel 版本)
1.12.6
Describe The Problem (描述问题)

Optimize README

1.1 cloudinaryFacades "github.com/goravel/cloudinary" -> cloudinaryfacades "github.com/goravel/cloudinary/facades"
1.2 Optimize configuration like other storage packages;

The config/cloudinary.go and contracts/cloudinary.go files seem unnecessary;
Please add the LICENSE file;
Order import for the cloudinary.go file;
I think AllDirectories and getAllDirectoriesRecursively can be merged, AllDirectories is very simple, it's unnecessary to separate them;
This line is so strange, I suggest optimize it;
Does AssetType must be set in this line?  Are there other AssetType?
Could you please reset the repository and create a PR for the current files? I found there are many places that need to be optimized, it's hard to record them here.

Reproduction Code (复现代码或截图)
No

Does AssetType must be set in [this line](https://github.com/goravel/cloudinary
/blob/b7c0c09cfd137a1d1230e5748723766350bf1ab1/cloudinary.go#L83C2-L83C63)? Are there other AssetType?

I couldn't find other method for it and Assets by default only get image assetType.


Port to Create 0.5.1.a

Disabled Progwml6 Maven due to it being unreachable
Some TODOs left where I'm unsure on how it should be handled

Thank you for your efforts. Sorry we can't merge this PR for now, because we still have some bugs to fix and some enhancements to finish.
Please read: https://discord.com/channels/1084792082599772212/1084793867129339957/1110158710149496872


Added a how to play section

Added a how to play section at the beginning of the game. This explains how to begin and continue the playing game to the users.
PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #26
Added a how to play section that helps players to navigate the game. A how to play button is added on the main page clicking which the how to play page opens. A back to home button takes the player to the main page to begin their game.

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for review.

## Add your screenshots(Optional) 📸
![image](https://github.com/GameSphere-MultiPlayer/Physi-c-Tech/assets/106909868/63501967-9f97-497a-9638-8604d777bca5)
![image](https://github.com/GameSphere-MultiPlayer/Physi-c-Tech/assets/106909868/f1c81afd-7e1e-42a2-b619-f5979f6fe7f1)
---

Thank you soo much for contributing to our repository 💗

@BagchiShreya Resolve the conflict

Reclone the repo and send a demo vedio


Feature: primary window selection, last exit event

One thing that would be nice to see as an additional set of features would be window/tab detection as a primary selection.
.track("primary", () => {
  //
  // create persistent message connection to server ...
})
.track("primaryClose", (last /* boolean, true if this is the last connected window/tab */) => {
  // window close event
  if (last) {
   // let server know user is going offline - no more connection(s) in this session.
  }
  // cleanup connection
})

I think this type of code can be written on top of sysend, with a few events passing around. But I'm not sure if you can detect closing the browser tab/window.
If there will be way too many code to make this work, I will consider putting this into the library, but I don't think it should be included.

You can see basic implementation on Codepen: https://codepen.io/jcubic/pen/OpROKx?editors=1010
It add methods track and untrack and events "open", "close", "primary" and "secondary"

New Tracking API was released.


Button with custom background

It doesn't work with it.

Try setting app:mrl_rippleOverlay="true" when using custom backgrounds


Add libsdl to build ffplay binary

This adds libsdl to build the ffplay static, too
Also:
Fixes #103
Fixes #104

thanks!


Fix link for swagger online editor

Type of change

Bug fix

Description
Previous hyperlink to swagger online editor was invalid.

Updated link works for me. Thanks, Tiffany!


Test not working for quickstart

Hi, I've cloned angular-examples/quickstart and run pub get && pub serve.
When I try to get http://localhost:8081/ I see:
[test] GET  → Could not find asset angular_app|test.
Dart VM version: 1.24.3 (Wed Dec 13 23:26:59 2017) on "macos_x64"
angular:
description:
name: angular
url: "https://pub.dartlang.org"
source: hosted
version: "4.0.0+2"

Hi @fffilimonov
Unfortunately we're not able to offer any support for 4.0.0, as we're closing to our next release (5.0.0) which has a much different build infrastructure.  You may want to ask on Stack Overflow.


get Web3Error.dataError when send transaction

I get Web3Error.dataError when send transaction with web3.browserFunctionsFunctions.sendTransaction function.
I've debugged it, it fails due to data parsing. In fact, the transaction is completed.

Hello @runryan
I suggest you to update to 0.9.0. Function sendTransaction() now returns a custom structure with hash and the final fully formed transaction and removes ambiguity of [String:String] dictionary.
Sincerely, Alex

Hello @shamatar
Would you please make "sendTransaction()" throw an error?  In most cases, it's necessary to deal with errors.
Thanks!

The returned type Result<Any, Web3Error> is enum with .success and .failure that correspondingly give you either a positive result, or an error that happened during the transaction.

No, it's not. In BrowserFunction,  sendTransaction()  returns [String:Any]? . The source code is
 public func sendTransaction(_ transaction: EthereumTransaction, options: Web3Options, password: String = "BANKEXFOUNDATION") -> [String:Any]? {
        let result = self.web3.eth.sendTransaction(transaction, options: options, password: password)
        switch result {
        case .failure(_):
            return nil
        case .success(let res):
            return ["txhash": res.hash]
        }
    }

Yes, I forgot to change a signature. Nevertheless it shouldn’t return .dataError, I’lll test it later today

Thanks.

What was a problem inside?

@shamatar
The transaction was sent successfully. The result returned is a string, however web3swift treat it as a [String: String]. that's the problem.
I used version 0.8.0. Version 0.9.0 has solved this.


Bugs

Environment (please complete the following information):

OS (e.g., Windows 10):
Extension version (e.g., 1.2.3):

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

These reports are not helpful, please add more information as we can't act on this.


Automate updating CSV annotations

Some annotations need to be manually adjusted in the CSV. I can think of two at the moment:

containerImage
createdAt

The former should always be in sync with the operator image used, and the latter can be updated whenever the bundle is regenerated.
We could add a Makefile target to install yq into our local bin, and use this tool to make the necessary modifications to the CSV inside the make bundle target.

createdAt is now updated automatically by the Operator SDK


Duplication of all items in the document (unable to determine cause)

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Frequently in my draw.io documents I delete an item only to realize there is a duplicate item below it. I then check other items and virtually all other items on my page are duplicated. I cannot drag-select and delete them as that will delete all copies not just the top copy. I have no idea how they got duplicated and it happens on virtually every drawing I create so it's not a "one time, oops, select all and duplicate" user-error.
To fix I have to select EVERY item in my document one by one and delete them to determine if they are duplicated or not.
To Reproduce
Steps to reproduce the behavior:
I am unable to determine how to reproduce this. It's something I notice after the fact when I go to delete an item an realize it has happened.
Expected behavior
There should not be a duplication of all items in the document without identification to the user this has happened
Screenshots
If applicable, add screenshots to help explain your problem.
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version: 16.2.6

Desktop (please complete the following information):

OS: Windows 10 & 11
Browser: Edge, Chrome
Version: Currently my Chrome build is 97.0.4692.71 but it's not a new issue, has been happening for the year+ I have been using draw.io

Is this a shared diagram with other people?

It's on Google Drive so technically but it's extremely rare that anyone other than I am editing my docs. It's also uncommon for them to view them at the same time I am in the docs as typically I export to PDF to attach to Jira or Slack messages.
It definitely happens when it's only my doc that no one else has or is accessing at the same time.

Does this happen for diagrams created within, say, the last year? Or is it for diagrams created originally some time ago?

Happens on most documents I create - and I create new ones probably once a week or so.

If the next one I find with this issue doesn't have sensitive content I will attach it - but the only way I know it happens is when I move or delete something and the copy shows up below and then I realize it's a bunch of objects duplicated

No draw.io plugins installed.
Different browsers I use have different combinations of extensions installed, but my most minimal Chrome browser that I have experienced the issue on contains only a couple of extensions:

Application Launcher for Drive (by Google)
Google Docs Offline
LastPass
Sheets (Chrome App)
Slides 9Chrome App)

Could this be happening because you're using ctrl + click to select multiple items, and accidentally move the cursor while clicking? I've found that Draw.io is incredibly sensitive to this, and will duplicate loads of items pretty much every time I try to use ctrl to select multiple items, unless I make absolutely sure that the cursor stays in the exact same place when clicking. This is makes selecting multiple items very tedious.

The bug still occurs: Windows 11, Chromium, Diagrams.net v. 23.1.5
It was reported already in 2018: https://webcache.googleusercontent.com/search?q=cache%3Agroups.google.com%2Fg%2Fdrawio%2Fc%2Fjdth0k8GI6k&sca_esv=a03cc0aa586dcb1e&ei=RvjYZbW5I9GswPAPhJS6wAg&ved=0ahUKEwi19IuTn8KEAxVRFhAIHQSKDogQ4dUDCBE&uact=5&oq=cache%3Agroups.google.com%2Fg%2Fdrawio%2Fc%2Fjdth0k8GI6k&gs_lp=Egxnd3Mtd2l6LXNlcnAiLmNhY2hlOmdyb3Vwcy5nb29nbGUuY29tL2cvZHJhd2lvL2MvamR0aDBrOEdJNmtIuQdQvQVYvQVwAXgAkAEAmAFvoAFvqgEDMC4xuAEDyAEA-AEBiAYB&sclient=gws-wiz-serp

Given the time difference it's very unlikely to be the same underlying cause. Re-opening isn't correct for different cause, but same result, please open a new issue.

Ok, I've opened the new issue: Diagram elements should not be duplicated after opening file .drawio #4217.


Unit tests for boundary conditions of full tiers in TCT

The current random testing of the TCT is unlikely to explore the cases when a block, epoch, or eternity is full. We should write unit tests to ensure that these boundary conditions are handled correctly.

We should wait to do this until we have a plan on whether and how we want to integrate the existing TCT code, or go for an alternate path forward in the near term.


add info for by/without

Signed-off-by: Augustin Husson<EMAIL_ADDRESS>

will be nice to add a description for on / ignoring / group_left / group_right. But so far I didn't find a short and understable description

ah yeah it's simple.
Thanks a lot ! I was definitely searching a much more complicated description hahaha.

:+1: Nice, thanks! Another nice thing to add descriptions for would be our snippets (at some point) :)

ah yeah that's true ! and also maybe for and / or / unless


NetBeans 13 / JDK 17 support.

WIP - needs a better solution for the --add-opens, since it would require to sync them on all archetypes, CI configs, nb.configs etc.
assumes https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/19 is integrated

@mbien I think it would be better to add all the add-opens stuff in a properties like the encoding one.
and use ${myaddopensproperties}.
it's possible for users to add additionArguments to nbm plugin configuration that need the add-openstuffs and copy pasting this long list may lead to desync.

@ebarboni agreed. But as I wrote in the PR description (and dev mail), we would need that list in all three archetypes, the NB config and also in the CI config for NB once JDK 17 testing starts.
I was thinking about adding it directly to the main netbeans repo to have it in a central place. The archetype projects would download it somehow during build? What do you think?

overheating :) . Sorry a bit long
I see several patch to the list of add-opens over the months, so maybe we can add an entry to https://github.com/apache/netbeans-jenkins-lib/blob/master/meta/netbeansrelease.json to get the add-opens stuff there for now in the master section patch the nbbuild to rewrite using this info so on NetBeans14 we can copy the list to lock the list to the build.
Thats cover the release process and also the CI I guess as it maybe read from json, having the nb.conf up todate.
We could just add a property in https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/blob/master/src/main/resources/META-INF/maven/archetype-metadata.xml to add a addopenslist properties defaulting to blank with some  info  around it
could land to

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<addopens.list></addopens.list>

1)I use this archetype within maven only I will have <addopens.list></addopens.list>
2) I use this archetype withing NetBeans and we can pass the addopenlist of the current NetBeans we use ( if we put the branding somewhere if the maven.apisupport module  for https://github.com/apache/netbeans/blob/master/apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java to use )

closing in favor of https://github.com/apache/netbeans-mavenutils-archetype-nbm-archetype/pull/23


Valkyrie Crashing when trying to Download in 1.3a

Was trying to check functions in 1.3a, went to Download only to have the interface crash out with no message.

Development branch for the quest store was broken, fixed now. (not a build problem, try again).


[FLINK-21214][kafka/IT] Add retry rule for FlinkKafkaProducerITCase

What is the purpose of the change
Unfortunately, the Kafka version bump did not fully resolve the flakiness of the FlinkKafkaProducerITCase so we apply the fix of https://issues.apache.org/jira/browse/FLINK-21214 to retry the failed cases because we highly suspect the non-dockerized test setup.
Once we have fully removed the FlinkKafkaProducer and all APIs are migrated to the KafkaSink we can also remove the test old test infrastructure.
We do not see any of the failures with regard to the dockerized test environments.
Brief change log

Add two retries on failure for all tests in FlinkKafkaProducerITCase

Verifying this change
Change only affects test code.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LGTM


Feature/add favicon

Coverage decreased (-0.8%) to 97.897% when pulling bb3bd5856ec976489d29906c1fb9372d2ca3f41b on feature/add-favicon into b1f9fa63369a8292b3d3de9e8a17d6b1ab71a36a on master.


skeema init: Remove extra newlines in logging

Before:
$ skeema init --host <IP_ADDRESS> -P 4000
2023-08-21 11:01:37 [INFO]  Using host dir /tmp/s/<IP_ADDRESS>:4000 for <IP_ADDRESS>:4000

2023-08-21 11:01:37 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/blog
2023-08-21 11:01:37 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/authors.sql (251 bytes)
2023-08-21 11:01:37 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/comments.sql (516 bytes)
2023-08-21 11:01:37 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/posts.sql (632 bytes)

2023-08-21 11:01:37 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/INFORMATION_SCHEMA

2023-08-21 11:01:37 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/METRICS_SCHEMA

2023-08-21 11:01:37 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/PERFORMANCE_SCHEMA

With this PR:
[dvaneeden@dve-carbon s]$ skeema init --host <IP_ADDRESS> -P 4000
2023-08-21 11:08:20 [INFO]  Using host dir /tmp/s/<IP_ADDRESS>:4000 for <IP_ADDRESS>:4000
2023-08-21 11:08:20 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/blog
2023-08-21 11:08:20 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/posts.sql (632 bytes)
2023-08-21 11:08:20 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/authors.sql (251 bytes)
2023-08-21 11:08:20 [INFO]  Created /tmp/s/<IP_ADDRESS>:4000/blog/comments.sql (516 bytes)
2023-08-21 11:08:20 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/INFORMATION_SCHEMA
2023-08-21 11:08:20 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/METRICS_SCHEMA
2023-08-21 11:08:20 [INFO]  Populating /tmp/s/<IP_ADDRESS>:4000/PERFORMANCE_SCHEMA

Thank you for the pull request, but the newlines are intentional, to visually separate the output of the operation on each directory / database schema.
Also please note, normally the system schemas are omitted entirely, so that entire chunk of the output normally isn't present. The problem here seems to be that the system schema names are getting returned by the database server in all caps. Skeema doesn't handle that situation because it doesn't happen on any database version currently supported by Skeema.


Added: Rotation of Array under 1D array

Issue Resolved

Closes #1552

Algorithm Added
Rotation of Array
Description
The Rotation of Array algorithm is used to shift the elements of an array to the left or right by a specified number of positions. When elements are shifted beyond the array bounds, they wrap around to the other end. This algorithm is commonly applied in circular queues, data shuffling, and simulations where cyclic movement of elements is required.
Example:

Input: arr = [1, 2, 3, 4, 5]
Let positions = 2, direction = 'R'

Output: arr = [4, 5, 1, 2, 3]

Thanks for reviewing the PR


edk2 unable to boot on vayu

after building, i tried to boot the image and im met with loads of texts and then a prompt reboot into android, i have tried to change dtb and the CustomizedBinaries folder with up to date ones, but still no avail
heres the only picture of what was happening before crash / reboot (sadly not the clearest image)

last driver to load was haliommu

last driver to load was haliommu

It's not the last driver loaded but it's PilDxe .
You can comment it from DXE.inc

oops my bad, alright ill comment it out

oops my bad, alright ill comment it out

However if you plan to use winpe , than USB will not work on pe even with a powered hub
I didn't tested surface duo guide but I guess you could try the guide if you plan to test the full windows

we are using another method for winpe, making a pe partition then installing pe to there

we are using another method for winpe, making a pe partition then installing pe to there

Even if you boot to winpe you can't use mouse or keyboard over USB to deploy the full windows installation .
However as I told you . you can try surface duo installation guide if you want full windows installation

thanks for the warning atleast

tysm the efi now boots


adding WWT to adopters

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

Hi! Thanks for using Thanos. Please add the DCO and the logo key to adopters.yml so that it would know where to find your logo.

@GiedriusS Sorry about that, opened the pull request then got side tracked.  All requested changes have been made.


Default image seems to be private

When I try to deploy v0.1.0 of this chart with default values, I get this error from kubelet:
Failed to pull image "ghcr.io/loft-sh/vcluster-hpm:0.1.0": rpc error: code = Unknown desc = failed to pull and unpack image "ghcr.io/loft-sh/vcluster-hpm:0.1.0": failed to resolve reference "ghcr.io/loft-sh/vcluster-hpm:0.1.0": failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Aloft-sh%2Fvcluster-hpm%3Apull&service=ghcr.io: 403 Forbidden

It seems that the image is not publicly accessible.

Hey @lorenzo-w 👋
A bug slipped into the helm chart.
The correct image name should be ghcr.io/loft-sh/vcluster-hostpath-mapper.
Please try setting hostpathMapper.image in your helm values to ghcr.io/loft-sh/vcluster-hostpath-mapper.

@ThomasK33 I used the suggested image and could get the daemonset to deploy error-free, thanks!
I'm still not getting any logs in Loki, but that might also be due to missing configuration in vcluster...


Suggestion - Automatic Copyright Year

I was going to add PHP code to print the current year in the copyright text automatically, but the file (_templates/footer.html) is .html, and I'm not sure where the file is referenced to change it to .php.
Just a suggestion :)

@Klikini any of the top-level pages in the root of the project will have a line to include the footer HTML.


[Settings] Design a mechanism to propagate specific system settings to the Settings app

Some modules may need to check system settings to decide when turn on/off some module's feature.
FancyZones needs to check animation settings, PT Run needs to check the enhanced search mode and so on.
Those settings can be retrieved by the modules, but may also also effect the Settings UI.
Since those values should not be persisted in the module's settings, we need a general design to avoid code duplication and to keep the Settings' code as clean as possible.

For some stuff we have things done as separate functions, like https://github.com/microsoft/PowerToys/blob/master/src/common/monitors.h or https://github.com/microsoft/PowerToys/blob/master/src/common/windows_colors.h.

Run needs to check if the scrollbar should go back to minimized mode or stays expanded at all times (like UWP scrollbars have).


Correct exception raise for unknown TLD, .nl domain update, PEP8

PR includes:

added abuse_contact and reseller optional attributes (.nl TLD)
extended DNSSEC check for .nl TLD ('yes')
corrected mistake in Windows process starter (missing '.exe')
now raises UnknownTld exception instead of terminating at unknown TLD
various PEP8/code format improvements

TODO:

version number?
add abuse contact to more TLDs

excellent many thanks


plugin: incorrect symbol lookup

What version of Go are you using (go version)?
go version go1.8.1 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build326475474=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
main.go
    package main

    import "plugin"
    import "fmt"

    func main() {
    	aPlug, _ := plugin.Open("a.so")
    	aSymPlug, _ := aPlug.Lookup("Rule")
    	fmt.Printf("Plugin: %v loaded\n", aSymPlug)

    	bPlug, _ := plugin.Open("b.so")
    	bSymPlug, _ := bPlug.Lookup("Rule")
    	fmt.Printf("Plugin: %v loaded\n", bSymPlug)
    }

a.go plugin
    package main

    type plugin string

    func init() {
    	Rule = "a"
    }

    func (p plugin) String() string {
    	return "a"
    }

    var Rule plugin

b.go plugin
    package main

    type plugin string

    func init() {
    	Rule = "b"
    }

    func (p plugin) String() string {
            return "b"
    }

    var Rule plugin

What did you expect to see?
Output:
    Plugin: a loaded
    Plugin: b loaded

What did you see instead?
Output:
    Plugin: a loaded
    Plugin: a loaded

Note if I change the return value for String() method to string(p) then everything works as expected.

/cc @crawshaw

This is a variant of #21386, and I believe is fixed by https://golang.org/cl/60910 (605331f).


News Scraping Project

Project Description 📄
We are looking for contributors who can help us build a News Scraping project using Python and web scraping libraries like BeautifulSoup or Scrapy. The goal of this project is to create a system that can scrape news articles from various sources.
Getting Started 🚀

Fork this repository
Clone the forked repository
Set up your environment
Start contributing!

Hi could you assign me this issue under hacktober fest tag?

Hi @Mrinank-Bhowmick! I would love to take be assigned this issue. I'll probably make my contribution as part of Hacktoberfest, so I'll make my pull request after the October 1st.

Hi, I would like to work on this project. Could you assign me this issue under hacktoberfest tag?

@Mrinank-Bhowmick I would like to work upon this issue. Can you please assign it to me.

Keen to contribute and learn, feel free to assign to me. Thanks!

Hi @Mrinank-Bhowmick  could you please assign me this issue under hacktober fest tag?

Hey @barkhaaroraa  as I assigned you with other issues, I am assigning this issue to @hairez

I have completed the code for this, so @Mrinank-Bhowmick can you please assign me this, so that I can create a PR

@hairez any progress? Mention this issue in your pr

I have completed the code for this, so @Mrinank-Bhowmick can you please assign me this, so that I can create a PR

Make the pr and mention this issue in your pr

I have experience in web scrapping and created project for this as well, assign this to me please. And also I have some new ideas as well

I have done web scraping a couple of times and would be so happy to work if you assign me with this task..

I have to choose one of python open source projects and do a contributing task, can you assign me a suitable project?

How can I contribute to this project?

Hi there!
I’m excited about the opportunity to contribute to this project and would love to take on the implementation of the "Rock, Paper, Scissors" game. I believe it’s a great beginner project, and I’m confident I can deliver a well-structured and user-friendly solution. I’ll ensure the code is thoroughly tested and aligned with the project’s standards.
Please let me know if I can proceed with this, and I’ll get started right away!
Thank you!


Pass /LIBPATH to linker

Package Microsoft.DotNet.ILCompiler v1.0.0-alpha-26207-01
was failing to compile WebAPI app when using non-developer command
prompt on Windows, because Kernel32.lib and friends weren't get located.
Capturing those from vsvarsall environment in findvsvarsall.bat script
and passing it to link.exe fixes the error and compiles WebAPI app
successfully.

Nit: The PR title does not reflect the change (LIBTOOL vs. LIB)

(LIBTOOL vs. LIB)

Yup, it's supposed to be LIBPATH.

Otherwise looks great! Thanks for finishing it up.


Logging fixes, pass through execution context.

Essentially a draft and prerequisite for setting up the slf4j MDC for inheriting key-value pairs for all spawned tasks.

Nope no other way if you don't want to touch those files

Depends, I attempted to do it and then quickly realised there's no automatic way, it's tedious, will annoy readers and doesn't actually get us much except this one problem, which we'd hopefully rule out as a problem by testing instead.


TopSQL: Improve the integration test of ScanRow

Development Task
This PR (https://github.com/tikv/tikv/pull/11085) introduces the ScanRow and provides some integration tests. But the test does not work well on different machines. The reason is that the fixed sleep wait may not get results on slower machines. This issue is used to track the optimization of the integration test for this PR.

/assign


Added initiallySelectedNamspaces

Hey, I just made a Pull Request!
Added support for providing an initiallySelectedNamspaces which accepts an array of Namespaces to have selected by default. This can be helpful if you are using Namespaces but don't want some of them to show automatically as they might cause noise.
In this screenshot you can see in the bottom left we had set "Default" for initiallySelectedNamspaces:

This may be impacted by https://github.com/backstage/backstage/pull/22858. If this PR gets in before this one then this will get refactored and be included in that documentation.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@vinzscam any chance you can give this one another look, please?

Hi @Edje-C, any chance you can give this a look, please?

Thanks for the review @vinzscam! 👍
Thanks for the review and merge @Edje-C! 🚀


StreamingDataset: make remote optional, attempt to prettify docstrings.

Will do

@ravi-mosaicml https://mosaicml-composer--1220.com.readthedocs.build/en/1220/api_reference/composer.datasets.streaming.dataset.html#module-composer.datasets.streaming.dataset fixed


execute "archive log list" statment , ORA-00900: invalid SQL statement

when I execute "archive log list", it report "ORA-00900: invalid SQL statement". not support?

It looks like it is a SQL Plus command, which would mean it can not be run outside of SQL Plus
https://docs.oracle.com/cd/B19306_01/server.102/b14357/ch12007.htm


Extract each specific functionality into a function

Make lily_parse_file function more concise. If do many small things in a function, make each small thing a function and call those functions from the long function.

@jesserayadkins


Allow for the usage of an existing aws_db_subnet_group

Currently the main.tf logic allows for

The creation of a new aws_db_subnet_group
The creation of generic aws_db_subnet_group if create_subnet_group is false

It currently does not allow for the usage of an existing  aws_db_subnet_group

https://github.com/intel/terraform-intel-aws-mysql/pull/21


Unit test for device TCTI to test successful transmit / receive path

These are test cases for the common, successful execution of the transmit / receive paths. Will require wrapping read and write syscalls but should be simple.

resolved in tcti-device/socket unit tests


Make CI Green Again

Here's a PR that makes the CI green again. The patch includes the following 3 big changes along with some more minor tweaks:

Solved a problem that currently bundled Contracts 0.16 doesn't pass with the current codebase

Updated Aruba gem to version 1.0.x that supports Ruby 3.2

Updated Liquid gem to version 4.x that supports Ruby 3.2

Note that this patch consists of minimal set of commits that make the existing tests pass, and does not contain anything else. I'm ready to push more patches (e.g. Ruby 3.3 support, newer libraries supports, RuboCop warnings fix) once this patch is merged.

Thanks @amatsuda! Really appreciated 🤝
@tdreyno Please could you please approve CI runs? Would be really amazing to merge these changes.

This is fantastically helpful. thank you @amatsuda


provide a way to use zemu with release binary

In order to support CI ledger integration and E2E efforts at CLI, it would be desirable to find a way to use use zemu directly with a release artifact. Currently zemu expects a .elf file, wich is not included (only installer shell scripts and source code eg https://github.com/ava-labs/ledger-avalanche/releases/tag/v0.7.2-hotfix).
So if posible either you can include .elf files in the release (and maybe generate the .hex to be loaded just from it). Or provide a way to generate an .elf (as expected from qemu) from the .hex in the installer scripts. If including .elf files, would be useful to have it retroactive to current ledger live release 0.7.0.

This is now present from the newest release, but as far as older release are concerned we wouldn't be able to retrieve the exact artifacts as they have expired already.
As a note, the app release done by ledger may slightly differ from our releases since they don't just take our release directly but instead recompile everything.


CUS-356: CI: use released engflow_auth to authenticate, upload BES

Added login.sh, which downloads a released engflow_auth binary,
uses it to import a credential, then configures Bazel to use it.
Added logout.sh, which removes the imported credential.
The presubmit and postsubmit jobs all run login.sh before and
logout.sh after running bazel.
.bazelrc now has some common remote execution flags, but currently
only uploads BES. No remote execution or caching yet.

Test run https://github.com/EngFlow/auth/actions/runs/10532625501


Fix use-after-close bug in DynamicRateLimiter

Explanation of bug
DynamicRateLimiter was using volatile variable to hold the currently active RateLimiter and replacing it with new one with new limit when it gets notified for the property update.
This was supposed to work well because users (calls #acquire()) might keep using old value read from volatile current which might have already rewritten by property listener.
However since property listener not just replaces reference but closes the limiter, this can cause race between property listener and hence user access already closed limiter consequently.
This could be reproduced by the unit test I added at c712cd6.
Solution
The resulting solution became bit complex than I initially thought.
The patched version of DynamicRateLimiter makes use of both volatile var and RW lock to protect limiters against close while its being used.
In this solution,

readers throughput won't be affected because all they require is read lock which isn't exclusive with others. even when prop listener is updating the current limiter, it won't be block and can grab an active limiter just after 1 retry.
writer can replace active limiter w/o lock. It has to wait on old limiter until all its users disappears to close the old limiter, but the time should be less and definite because all new entry of acquire() are routed to the new limiter.
See source comment for the detail.

Besides that, I have considered below (probably simpler) solutions but rejected them by individual reasons.
Depecate RateLimiter#close  with RateLimiter#shutdown and make it call optional
The idea of this solution is, by making RateLimiter's shutdown function call to be optional, when it got switched by property listener the user threads which grabbed the old value from current can just keep using the old one. This should be fine because currently all RateLimiter implementations implements #close just for immediately terminating all waiters on it.
However I turned out that by leaving (forgetting) the old RateLimiter in prop listener, it would causes extra long shutdown time of subscription by following scenario:

thread 1..N grabs old limiter
prop listener replaces current with new one
subscription.close()
only the current limiter closed (so its waiters abort immediately)

RW lock at DynamicRateLimiter
We might introduce RW lock at DynamicRateLimiter and acquire read for #acquire() calls while holding write for replacing current and close it.
This guarantees all users to grab a RateLimiter that is not already/going to be closed by prop listener.
However, the biggest concern is unexpected long lock either at users or at prop listener.

If we make the lock's fair-policy "unfair", then while prop listener is awaiting on write lock, continuous calls of acquire() from users threads keeps interrupting and prevents prop listener to hold write lock indefinitely.
If we make the lock's fair-policy "fair", then the above problem disappears, but instead some user threads will wait certainly and unnecessarily long while the write lock is waiting for other readers to release. In this case throughput might drops temporarily.

The main concern of this patch has already been fixed by #32 as in RateLimiter no longer throws even for access after it closed.
I'll consider about this race once again and may submit a different PR to approach the remaining problem - acquire() returns too early and all at once at switch which is less critical than the original issue.


[1.9] fix some race conditions with short lived pods

Backport of #1957

LGTM

/test e2e_fedora
/test e2e_rhel

/restart

/retest

I folded this into #2142


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

This is my pull request for fixing validations.py


Reduced 10xdev.cc to 374B

optimized everything (once again:)
thank you for the awesome 1kb.club project!
bloat is our enemy :)

I am consistently getting 403  -> https://gtmetrix.com/reports/10xdev.cc/chPnpmiR/

Well, it shows "Total Page Size - 403B" @ Page Details, yes 🤷♂
Not sure where it comes from...
But the actual page size is 374B.
$ curl --head https://10xdev.cc/
HTTP/2 200
server: nginx
date: Sat, 10 Sep 2022 16:30:44 GMT
content-type: text/html; charset=utf-8
content-length: 374
accept-ranges: bytes

gtmetrix also shows 374B in Waterfall tab:

So, should I use 403 or 374?

403 since we use GTMetrix as the main source (keep things consistent)

FYI, I removed <link rel=icon href=data:,> and just dropping /favicon.ico request on the server-side :)

BTW, according to gtmetrix, 1kb.lingdocs.com is 710B, not 500B

updated nginx gzip config, now gtmetrix consistently shows 387B


Doesn't play, update, download from aniwave extension.

Steps to reproduce
Open AniWave source
Select any anime
Error toast
Expected behavior
AniWave should load all episodes as normal.
Actual behavior
Json error toast

Crash logs
No response
Aniyomi version
App version: <IP_ADDRESS>
Android version
Android 14
Device
Google Pixel 6a
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extension's repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Please contact the extension maintainers for such issues.

I don't know what extensions repository you're using so I can't really guide you here.

I don't know what extensions repository you're using so I can't really guide you here.

Thanks that comment itself helped me understand what i had to do, i checked with the repository maintener's git and saw there was already a open case? Issue? over there, i will delete this one here. Thanks for helping.


Stage 2 zero grad fix

Issue: The zero grad function of stage 2 misses the set_to_none argument. Without this argument, training breaks.
Description of changes: Added the argument similar to stage 3. Either argument can be used to set gradients to None.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I believe this is a deepspeed version-related issue. Can you specify which deepspeed/transformers version you are using?

Yeah, that might be the case. These are my tested versions:

deepspeed==0.8.3
transformers==4.30.0
torch==2.1.0
torchvision==0.16.0

Yeah, that might be the case. These are my tested versions:

deepspeed==0.8.3
transformers==4.30.0
torch==2.1.0
torchvision==0.16.0


AppLovin plugin needs to be updated so we can set the age restricted user flag

The AppLovin plugin needs to be updated so we can set the age restricted user flag to ensure Google Play policy compliance. Below are links I was sent by AppLovin on implementing flag.
Android: https://dash.applovin.com/documentation/mediation/android/getting-started/privacy#children-data 2
iOS: https://dash.applovin.com/documentation/mediation/ios/getting-started/privacy#children-data

Thank you for opening up a defect. Fixing it now and will check it in.

Created pull request here:
https://github.com/coronalabs/com.coronalabs-plugin.applovin/pull/1

Added https://docs.coronalabs.com/plugin/applovin/setIsAgeRestrictedUser.html


feat: add harvester_cloudinit_secret

Issue: https://github.com/harvester/harvester/issues/2958
Test plan
Setup
Follow PR Test Env Setup
Case 1: Apply same terraform doesn't trigger change

Create a file main.tf.

resource "harvester_cloudinit_secret" "ex1" {
  name             = "ex1"
  namespace        = "default"
  user_data_base64 = "I2Nsb3VkLWNvbmZpZwpwYWNrYWdlX3VwZGF0ZTogdHJ1ZQpwYWNrYWdlczoKICAtIHFlbXUtZ3Vlc3QtYWdlbnQKcnVuY21kOgogIC0gLSBzeXN0ZW1jdGwKICAgIC0gZW5hYmxlCiAgICAtIC0tbm93CiAgICAtIHFlbXUtZ3Vlc3QtYWdlbnQuc2VydmljZQpwYXNzd29yZDogdGVzdApjaHBhc3N3ZDoKICBleHBpcmU6IGZhbHNlCnNzaF9wd2F1dGg6IHRydWUK"
}

resource "harvester_cloudinit_secret" "ex2" {
    name = "ex2"
    namespace = "default"

    user_data    = <<-EOF
    #cloud-config
    password: test
    chpasswd:
      expire: false
    ssh_pwauth: true
    package_update: true
    packages:
      - qemu-guest-agent
    runcmd:
      - - systemctl
        - enable
        - '--now'
        - qemu-guest-agent
    EOF
    network_data = ""
}

Run terraform apply. Terraform should add ex1 and ex2 secrets to the cluster.
Run terraform apply again. Nothing change.

Case 2: Change content to empty will update the secret

Follow case 1.
Update the file main.tf.

resource "harvester_cloudinit_secret" "ex1" {
  name             = "ex1"
  namespace        = "default"
  user_data_base64 = ""
}

resource "harvester_cloudinit_secret" "ex2" {
    name = "ex2"
    namespace = "default"

    user_data    = ""
    network_data = ""
}

Run terraform apply. The content of ex1 and ex2 secrets will be empty.
Run terraform apply again. Nothing change.

Also need to consider another test case：

apply with user_data not empty
change user_data to empty
apply again

Added test case 2. Thanks.

Any idea when this PR will be merged?

@bk201 please take a look when u are back only; merge the PR to process the validation first, thanks.