Added an IO for IGOR Pro.

Replaces #225 (pull-request against master, instead of apibreak branch).
Awaiting upload of test files to G-Node.

Coverage decreased (-0.06%) to 55.656% when pulling c173003b17c67fa0ab0279a1a8ab8991d8a63b88 on apdavison:igorpro into f97c7f5a2481f3d09530e9976d8e6e4a0a30384c on NeuralEnsemble:master.

This will make some people happy!!
OK for me.

Test files are now on G-Node portal


Dammit

OPS Build status updates of commit f7d7b9e:
:clock10: Preparing: average preparing time is 38 sec(s)

OPS Build status updates of commit f7d7b9e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/enterprise-graph-docs-pr, working directory: W:\1cp4-s, target branch: master, target branch commit: 6cf9bcd889ddf1f75025e7356de16a0fea5931fb, source branch: 3638ce60ebef810876cd6fbb8bd88ec9/master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 5b6cb61:
:clock10: Preparing: average preparing time is 38 sec(s)

OPS Build status updates of commit 5b6cb61:
:clock10: Incremental building: average incremental building time is 17 sec(s)

OPS Build status updates of commit 5b6cb61:
:warning: Validation status: warnings

File
Status
Preview URL
Details

enterprise-graph/concepts-entities.md
:warning:Warning

Details

enterprise-graph/enterprise-graph-use-cases.md
:warning:Warning

Details

enterprise-graph/knowledge-graph-concepts.md
:warning:Warning

Details

enterprise-graph/toc.yml
:warning:Warning

Details

enterprise-graph/concepts-entities.md

[Warning] Author stflanag cannot be recognized in GitHub.

enterprise-graph/enterprise-graph-use-cases.md

[Warning] Author stflanag cannot be recognized in GitHub.

enterprise-graph/knowledge-graph-concepts.md

[Warning] Author stflanag cannot be recognized in GitHub.

enterprise-graph/toc.yml

Line 0: [Warning] Invalid file link:(~/service-fabric-versions.md).
Line 0: [Warning] Invalid file link:(~/project-planning.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix movement locking bug

There's a bug with limited autorun in which the blocks becoming permanently immovable if your code is saved while block movement was locked. That's because block.isMovable() is used to determine the 'movable' attribute for the block's xml, and that method returns false if movement is locked in the block space. The next time you load the puzzle, the blocks will be initialized with movable="false" and you won't be able to move any of your blocks again without restarting.
This PR moves the isMovementLocked() check outside of block.isMovable() to the mousedown handler.

Codecov Report

Merging #146 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #146      +/-   ##
=========================================
+ Coverage   55.14%   55.4%   +0.25%
=========================================
  Files          96      96
  Lines       11464   11452      -12
=========================================
+ Hits         6322    6345      +23
+ Misses       5142    5107      -35

Impacted Files
Coverage Δ

core/ui/block.js
63.61% <100%> (ø)
:arrow_up:

core/ui/block_space/block_space_editor.js
68.91% <0%> (+0.25%)
:arrow_up:

core/utils/procedures.js
46.72% <0%> (+0.68%)
:arrow_up:

core/ui/block_space/flyout.js
63.11% <0%> (+1.14%)
:arrow_up:

core/utils/xml.js
85.15% <0%> (+9.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff639b...9faed5a. Read the comment docs.


scm/github: filter issues that belongs to PR diff

This should fix the issue https://github.com/herlon214/sonarqube-pr-issues/issues/8

Thank you for following up on this so quickly!

@adenisonafifi no problem, i was adding tests to be sure it won't break. Worth a star ⭐  haha
I'm gonna release a new version

@adenisonafifi v0.5.0 released https://github.com/herlon214/sonarqube-pr-issues/releases/tag/v0.5.0


Update str_limit() helper for better validation and typography

Three dots "..." can be replaced with "…".
This is better for:
— HTML validation.
— JSON and plain text formats (if one dot goes to another line of UI or document)
— Typography

As I said before, if you want this behaviour, then pass the 3rd param.

Okey, I am currently using my own typography helper.
However, why do not make all laravel projects better?


Using isset() to check if bucket props exist to avoid PHP notice

If "props" is not set, you'll get the notice "Undefined index: props" otherwise.
Example: Adding an index returns with {"search_index":"schema does not exist"} if a schema does not exist. Actually, the client library should return an error in this case, if the HTTP status code was properly set by Riak. Maybe that's another bug?

Thanks for catching that @lastzero


New commands: !link|!wiki

Add support for !link <searchString> - Command to search for a known, FAF-related URL.
Fallback to fuzzy search (levenshtein-distance) if exact match isn't found.
(maybe should move the url storage to sqlite in the future to make it possible for admins to register new URLs without restart)

!wiki  is also supported now

!hug added


adds test to cover deleting unsplittable col in split code

The new test in this commit covers the following code
https://github.com/apache/accumulo/blob/d1456fcaa440f94b03e2a7e7f557fb77f8ef2426/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/split/FindSplits.java#L142-L148

As a result of running this test and looking at the coverage data #4792 and #4793 were opened.

I went back and took a look and there is an existing IT that covers this case but I forgot to add one to the ManagerRepoIT after TestAmple was created.

That was a good find.  I added links in the javadoc for each test pointing to the other.  Since the test are somewhat similar it may be useful to know about the other test when making changes in the future.


Explorer windows flicker when clicking cairo menu bar and then the desktop

Not set as shell, taskbar disabled

Not able to reproduce, any shell extensions you have installed that could be causing this?

I have lots of shell extensions... here is a dump:

I think this is resolved in the latest release after the desktop changes. Could you please verify? Thanks!

it looks solved. but I got a flicker of the desktop on some occasions on current version by doing random clicks on desktop, top bar and then minimize/restore of a window. looks like a desktop refresh idk if it's related

Interesting, would you be able to provide a screen recording showing the flicker? I am not able to reproduce that one.

I originally intended to, but the gif recording had a too slow frame rate :\
I will figure something...

Closing due to no further reproductions.


[Enhancement] sort result by BackendId when show backends like show backends

Proposed changes
before:
+-----------+
| BackendId |
+-----------+
| 99412 |
| 11003 |
| 11002 |
| 60616 |
| 60673 |
+----------+
after:
+-----------+
| BackendId |
+-----------+
| 11002 |
| 11003 |
| 60616 |
| 60673 |
| 99412 |
+----------+
Issue Number: open #17935
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

before: +-----------+ | BackendId | +-----------+ | 99412 | | 11003 | | 11002 | | 60616 | | 60673 | +----------+
after:
+-----------+ | BackendId | +-----------+ | 11002 | | 11003 | | 60616 | | 60673 | | 99412 | +----------+
Issue Number: open #17935

@bin41215 could you please check the FE Code style and also the regression failed. Maybe you should rebase master and submit the PR again.

hi, @yiguolei , I have resubmitted the PR #18112 and would appreciate it if you could review when you have the time. Thank you!


purge mentions of the starter kit

purge or ... tidy to just mention this is a continuation of it, non?

yeah the wording of the issue is a bit aggressive but we agree on the idea I think

changing the title.  :)


@pierrefdz I think this is an issue that will be become bigger as more people test Audioseal.

@pierrefdz
Hello, I encountered the same issue. I tried five watermarked audio generated from acoustic models (FreeVC, KNN-VC, and my own model), and 4 out of 5 did not meet the watermark with threshold ranging from 0.1 to 0.9, except for the audio from my own model (although the quality of this audio is quite poor). Here's a reproduction:
link audio: https://drive.google.com/drive/folders/18u6WO-F__uo7a7fS6bFFNXtli5LN6V-L?usp=sharing
link colab: https://colab.research.google.com/drive/1CLtUtYiVGgkCCrbB4Ejkx6hoTSyWacnQ?usp=sharing
Originally posted by @huutuongtu in https://github.com/facebookresearch/audioseal/issues/14#issuecomment-1989863765

Hi @KabaTubare,
Again, watermarking methods are "active". The detector will only detect the watermark in audios where you embed the watermark. Have you embedded the watermark on audios you tested?
PS: If you're interested in synthetic voice detection (without watermarking), you can look at "passive" methods like https://github.com/ghua-ac/end-to-end-synthetic-speech-detection which are agnostic (but have lower performance).


fix: nil pointer deref sendFalcoEvents func

IMPORTANT: Please do not create a PR without creating an issue first!
(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).
Summary

The previous code in the sendFalcoEvents() function attempted to defer the closing of the response body w/o checking if the HTTP request had resulted in an error. This could lead to a "nil pointer dereference" error when an error occurred during the request.
This commit fixes the issue by checking if an error occurred and deferring the response body close only if there was no error.
Proposed of changes
This PR fixes/implements the following bugs/features:

Bug 1
Bug 2
Feature 1
Feature 2
Breaking changes

How has this been tested?
Fill the FalcoSidekickURL option field with an unreachable host.
Proof:

Closing issues
Fixes #
Checklist:

[x] My code follows the code style of this project.
[x] My changes successfully ran and pass linters locally (run make lint).
[x] I have written new tests for my changes.

[x] My changes successfully ran and pass tests locally.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (209249e) 75.67% compared to head (ec176de) 76.81%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   75.67%   76.81%   +1.14%
==========================================
  Files           6        6
  Lines        1106     1113       +7
==========================================
+ Hits          837      855      +18
+ Misses        217      206      -11
  Partials       52       52

Files
Coverage Δ

teler.go
80.14% <100.00%> (+3.20%)
:arrow_up:

falcosidekick.go
16.36% <0.00%> (-0.31%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


enh(Python): add input command for n-th Fibonacci

To find the fibonacci number for any n input by user.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] New algorithm
[ ] Optimization in previous algorithms
[x] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

Hi @RudraGayu,
This is closed due to you being offline, please re-open this when you are online.


Build with TM2 not working android

I am trying to use the T265 with android and when I enable BUILD_WITH_TM2 and IMPORT_DEPTH_CAM_FW in the android_config.cmake in the cmake folder, the build for the android wrapper fails. If I disable those two, then the build works. I have attached the build output. I am on Kubuntu 23.04.
Build command failed.
Error while executing process /home/cheeseboy/Android/Sdk/cmake/<IP_ADDRESS>88404/bin/ninja with arguments {-C /home/cheeseboy/StudioProjects/librealsense/wrappers/android/librealsense/.cxx/cmake/debug/armeabi-v7a realsense2}
ninja: Entering directory `/home/cheeseboy/StudioProjects/librealsense/wrappers/android/librealsense/.cxx/cmake/debug/armeabi-v7a'
[1/168] Performing update step for 'libusb'
[2/168] Performing configure step for 'libusb'
FAILED: /home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/libusb-prefix/src/libusb-stamp/libusb-configure
cd /home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/libusb-prefix/src/libusb-build && /home/cheeseboy/Android/Sdk/cmake/<IP_ADDRESS>88404/bin/cmake "-DCMAKE_CXX_STANDARD_LIBRARIES=-latomic -lm" -DCMAKE_TOOLCHAIN_FILE=/home/cheeseboy/Android/Sdk/ndk/21.1.6352462/build/cmake/android.toolchain.cmake -DCMAKE_BUILD_TYPE=Debug -DANDROID_ABI=armeabi-v7a -DANDROID_STL=c++_static -DCMAKE_INSTALL_PREFIX=/home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/libusb_install -GNinja /home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/third-party/libusb && /home/cheeseboy/Android/Sdk/cmake/<IP_ADDRESS>88404/bin/cmake -E touch /home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/libusb-prefix/src/libusb-stamp/libusb-configure
-- ANDROID_PLATFORM not set. Defaulting to minimum supported version
16.
CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
-- Configuring incomplete, errors occurred!
See also "/home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/libusb-prefix/src/libusb-build/CMakeFiles/CMakeOutput.log".
[3/168] Linking CXX static library /home/cheeseboy/StudioProjects/librealsense/wrappers/android/build/third-party/realsense-file/librealsense-file.a
ninja: build stopped: subcommand failed.

I got it working by using this.


Auto generate from swagger

Updated blob swagger spec, now can auto generate interfaces from swagger spec, no manual change needed anymore.

/azp run


fix go-lint, go-vet errors

Signed-off-by: Sally O'Malley<EMAIL_ADDRESS>

@rhatdan please check the comments added to satisfy go-lint errors, they might need re-wording, thanks.

Sally, I need these done on individual patches rather then all in one patch.  IE I need a patch to fix the audit code and one to fix the gen_dockerfile code ...

@rhatdan, ok, i'll do that

closing this, opened separate PRs #134, #135, #136, #137


azure-cosmos hotfix release 4.63.3 - avoiding possible CF hang

Description
This PR is fixing a possible hang in CosmosAsyncContainer.queryChangeFeed under certain conditions. To cause a hang the following conditions need to be met

The continuation token used has an even number of sub-ranges
For all sub-ranges a 304/NotModified is returned
One of the second or later sub-ranges is getting split

When any of the conditions above is not met (for example not for all sub-ranges a 304 is received or there is no sub-range being split, the hang would not have happened.
A test CosmosContainerChangeFeedTest.split_only_notModified has been added that describes and simulates the triggering conditions above to function as validation of the fix as well as regression test in the future.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - cosmos - tests

/azp run java - cosmos – spark

/azp run java - cosmos - spark

Run the following tests locally and passed:
readFeedDocumentsAfterSplit
readFeedDocumentsAfterSplit_maxScaleCount
tryGetAddresses_SuboptimalMasterPartition_Stale_DoRefresh

/azp run java - cosmos - tests

/azp run java - cosmos - spark

/azp run java - cosmos - spark

/azp run java - cosmos - tests

/check-enforcer override

Manual test failures when executed locally run successfully. We have looked at the failures and are investigating especially the invalid first JSON character 0xab that is seen in several of the pipelines - but given the tests pass manually we will proceed with merging the PR.

/check-enforcer override


How to get the experiment result on Occlusion LineMOD (LM-O) dataset ?

@CavendyHsu Hi, zelin
Cloud youd mind sharing the details to get  experiment result on Occlusion LineMOD (LM-O) dataset ? I want to reproduce the experiment result from your paper while cannot find the details in your released code.

@ZJU-PLP Thank you for your interest in our work. We have updated the code and pre-trained models for the LMO dataset.

@CavendyHsu Ok, Thanks for your reply.
I meet the problem when I want to download the Pred mask of HybridPose on LineMOD Occlusion dataset.

Access is turned on.

@CavendyHsu Hi, Thanks for sharing the code to train and eval lmo dataset. However, I cannot reproduce your paper's results. Could you mind offering some advice?

I run the script and pretrained model is provided by your download link.
python eval_lmo.py --dataset_root ./datasets/linemod/Linemod_preprocessed --pred_mask ./mask_hybridpose --model ./pretrained_models/lmo/pose_model_27_0.02377143515188488.pth

However, I get the ADD(S) Result: 65.91 instead of 69.5 in your paper.

I run the lmo dataset train script offered by your method. However, I cannot reproduce the good experiment results.(ADD(S) Result is only 25.15 and the loss cannot be refined)

python train.py --dataset lmo --dataset_root path_to_lm_dataset --bg_img path_to_voc2012_dataset

@ZJU-PLP Hi.
When I was running the LMO dataset, I encountered the following problem. Do you have a solution? I am looking forward to your reply.

@ZJU-PLP Hi. When I was running the LMO dataset, I encountered the following problem. Do you have a solution? I am looking forward to your reply.

No, I did not meet the problem. Maybe your torchvision version is not supported (from your debug error infromation)?

Hi, I tested the official weights of LMO and it is exactly 69.52, I am using torch1.8.0. Please check whether is the testing data problem or torch version

@aragakiyui611 I have tested again (pytorch version changed to 1.8) and the result is still 65.62.

Please refer to these.

@aragakiyui611 I have tested the code by "python eval_lmo.py --dataset_root ./datasets/linemod/Linemod_preprocessed --pred_mask ./mask_hybridpose --model ./pretrained_models/lmo/pose_model_27_0.02377143515188488.pth" and results is 65.78.
I think your analysis is very right about system IO instead of GPU. However, I cannot understand the same model produce different results. Because system IO only influence running time while not the precision results. I want to know whether you test the code in Linemod_preprocessed?

I want to know whether you test the code in Linemod_preprocessed dataset.

Not quite understand, the 02 of Linemod_preprocessed is exactly Occluded LineMOD.

However, I cannot understand why the same model produce different results.
This is very normal and there are so many factors affecting. You cloud probably search zhihu or others for detailed explanation.

As far as the result you run 65.78 and my 69.52, I can't find the exact where the problem is. Pray check whether you modified you test data.

@aragakiyui611
Hi, I have checked again LineMod dataset and found some error. Lately, I have fixed it and  tested again your provided trained model and the results is ok (dataset moved to SSD).

Today, I have trained lmo dataset again in my local computer. However, I find that the loss cannot be refined after epoch=25. And the test ADD(S) results is only 31.89(model epoch=25).Could you mins sharing your training curve displayed with tensorboard?
Training details:
script command "python train.py --dataset lmo --dataset_root ./datasets/linemod/Linemod_preprocessed --bg_img ./datasets/lmo/VOCdevkit"

Testing details:

@aragakiyui611 Could you mind helping me to solve this problem when you are leisure?

exp.zip
These are training logs. If you need weights I may share it with other methods since they are too large.
I am afraid you have to figure out problem yourself first, I have not time in the recent month.

@aragakiyui611 Thanks for your nice sharing. I find that my TEST FINISH Avg dis is different from yours to a great extent. I'll keep on debug the results.

@aragakiyui611 I maybe find the key of this problem.
In your provided trained logs, the test result is different by bgaug=True-front_num=3-num_pts=1000-box_aug=False and bgaug=True-front_num=3-num_pts=1000-box_aug=True. From your provided trained model, the model of pose_model_27_0.02377143515188488.pth is trained by box_aug=True.
Could you mind helping me to understand the parameter of box_aug? In your lmo dataset training script from README, I cannot find the related parameter.
epoch_27_test_log.txt:
(1) box_aug=False
Avg dis: 0.03193115701012664

(2) box_aug=True
Avg dis: 0.02377143515188488

it makes augmentation on detection bbox. please refer to these lines:
https://github.com/Gorilla-Lab-SCUT/BiCo-Net/blob/68bc075673f6696c0e4f18a67c5cd9be06900312/datasets/lmo/dataset.py#L129

Ok, I see.
While the parameters of  bgaug=True-front_num=3-num_pts=1000 stand for (bgaug, front_num and num_pts)?

I made a mistake, please refer to the edited comment.

I made a mistake, please refer to the edited comment. bgaug=True-front_num=3-num_pts=1000 is default.

In your meanings, I can ignore the parameters(bgaug, front_num and num_pts) when to train lmo dataset?

@aragakiyui611 I trained several times in lmo dataset by your code. However, my train results cannot achieve your provided model. Could you mind helping me to train your published code again in lmo dataset by script python train.py --dataset lmo --dataset_root path_to_lm_dataset --bg_img path_to_voc2012_dataset?
In other words, I can make sure that the problem location if you train the published code (not your initial code)and can achieve the result pose_model_27_0.02377143515188488.pth.
My training results:

https://github.com/Gorilla-Lab-SCUT/BiCo-Net/blob/68bc075673f6696c0e4f18a67c5cd9be06900312/datasets/lmo/dataset.py#L37
I found that it may be this bug, change train.txt into train_all.txt

I trained the model as well and there're still some bug.

I trained the model as well and there're still some bug.

I also trained again. It still exists some bugs.

@TerenceHsu666 Could you mind helping me to solve this problem in lmo dataset when you are leisure?

https://github.com/Gorilla-Lab-SCUT/BiCo-Net/blob/581671b554d5b33a17d69c45bd13d841cb0790e8/datasets/lmo/dataset.py#L130
Hi, please try change this line into img_masked = np.transpose(img_masked, (2, 0, 1)).
I am training the model again.

https://github.com/Gorilla-Lab-SCUT/BiCo-Net/blob/581671b554d5b33a17d69c45bd13d841cb0790e8/datasets/lmo/dataset.py#L130
Hi, please try change this line into img_masked = np.transpose(img_masked, (2, 0, 1)). I am training the model again. It seems that this is the bug.

Okkk, thanks a lot.

@aragakiyui611
I find the bug is fixed by your proposed method. The testing results is ok. Thanks for your patient response.


MF-687 - Add event sourcing to Bootstrap service

What does this do?
This pull request adds events for CRUD and bootstrap action to the Bootstrap service.
Which issue(s) does this PR fix/relate to?
This pull request resolves #687.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
No.

Codecov Report

Merging #695 into master will increase coverage by 0.08%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage    86.3%   86.38%   +0.08%
==========================================
  Files          62       64       +2
  Lines        3723     3848     +125
==========================================
+ Hits         3213     3324     +111
- Misses        353      367      +14
  Partials      157      157

Impacted Files
Coverage Δ

bootstrap/postgres/configs.go
73.07% <ø> (ø)
:arrow_up:

bootstrap/redis/producer/events.go
100% <100%> (ø)

bootstrap/service.go
84.42% <66.66%> (ø)
:arrow_up:

bootstrap/redis/producer/streams.go
84.78% <84.78%> (ø)

writers/influxdb/messages.go
85.71% <0%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fcf0aa...b6dedf5. Read the comment docs.


Objective-C support

Please add Objective-C support.

Unfortunately, we currently don't have plan for Objective-C support


Edited "Expansion Cards" section

Added missing period after "ex" in 'Expansion Cards' section in order to maintain established syntax.
Capitalized full form version of "GPU" to reflect the association to each other in 'Expansion Cards' section.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.


Correct filter used to support type ahead address search

Type of change

Bugfix

Description

The filter was assuming the addresses have spec.addressSpace populated. this is not the case.
Changed address creation not to set the spec.addressSpace field when creating new addresses

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests testcase=*ConsoleTest

:x: Test Summary :x:
TEST_PROFILE: pr
TEST_CASE: *ConsoleTest
TOTAL: 62
PASS: 53
FAIL: 3
SKIP: 6
BUILD_NUMBER: 86
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testSortConnectionsByContainerId in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testViewAddressSpaceCreatedByApi in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest
testFilterAddressSpace in io.enmasse.systemtest.isolated.web.FirefoxConsoleTest


Added Flexbox Froggy - CSS Game

What does this PR do?
Add a CSS Game - Flexbox Froggy
Description
Flexbox Froggy is a game for learning CSS flexbox.
Why is this valuable (or not)?
It is Beginner Friendly and helps in Basic Understanding of Flexbox
How do we know it's really free?
It is Open source project and is maintained by Thomas Park

The Changes has been done. Thanks for the Suggestion.

love it.
Thanks, and welcome to free-programming-books!


Attachments with incorrect base64 contentUrl in sendActivity fails silently

Versions
What package version of the SDK are you using: 4.0.8 (botbuilder, botbuilder-dialogs)
What nodejs version are you using:  v.8.12.0
What browser version are you using: Chrome v69
What os are you using: Windows 10
Describe the bug
When trying to create an attachment that is intentionally corrupt (via an incorrect base64 url), the bot fails silently without throwing an error.
To Reproduce

Create bot with command to trigger send activity with an attachment with the following code:

  try {
    console.log('Start');

    await context.sendActivity({
      type: 'message',
      attachments: [{
        contentType: 'text/plain',
        contentUrl: 'data:image/png;base64,abc\nabc',
        name: 'dot.png'
      }]
    });

    console.log('Succeeded');
  } catch (err) {
    console.log(err);
    throw err;
  }

And on the BotFrameworkAdapter instance, register an onTurnError handler like so:
adapter.onTurnError = async (context, error) => {
  console.log(error);
  await context.sendActivity(`Sorry, ran into an error!\n  ${ error.message }`);
}

Run bot, send command utterance to send activity
Sending the command failed
Note that there is no error in the console, and the line console.log("Succeeded"); is never reached. Similarly, onTurnError is never triggered.

The message fails silently, and after timing out, the Web Chat instance logs a 502 Bad Gateway error.
Sending other messages pass through successfully.
Expected behavior
Since the contentUrl is invalid, the bot should try and catch an error when this command is initiated.
[bug]

Update: Currently not reproing with botbuilder 4.1.7 and the emulator 4.1.0

Was able to repro with the full-bundle sample from WebChat, spoke with @compulim in person and he agreed it is a WebChat issue. @daveta can you transfer this to WebChat please?


Left rotate source table for the quickwit source describe command

The quickwit source describe command  outputs three tables:

source table
params table
checkpoint table

The source table should be left-rotated for a slicker display. However, when I tried to do so, I did not manage to get the content of the table properly left-aligned.

Hi, I have experimented with different alignments and formats but the output seems to be very off. For example, without PSQL
       +------+------------------+
       | Type |       file       |
+------+------+------------------+
 Source|  ID  | wikipedia-source |
+------+------+------------------+

           +-------+--------------------------------------+
           | Value | "/quickwit/wiki-articles-10000.json" |
+----------+-------+--------------------------------------+
 Parameters|  Key  |               filepath               |
+----------+-------+--------------------------------------+

           +--------------+
           |    Offset    |
+----------+--------------+
 Checkpoint| Partition ID |
+----------+--------------+

I would assume in this case we need dynamic tables as mentioned in the docs of the builder module https://docs.rs/tabled/latest/tabled/builder/struct.Builder.html
I think if I experiment a bit more, I might be able to figure out the correct way to display the data. However, I am new to rust and I can't seem to figure out the reason behind this unresolved import when I try to import the builder::Builder module.
error[E0432]: unresolved import `tabled::builder`
  --> quickwit-cli/src/lib.rs:32:90
   |
32 | use tabled::{Alignment, Rotate, Header, Modify, Row, Full, Style, Table, Tabled, Indent, builder::Builder};
   |                                                                                ^^^^^^^ could not find `builder` in `tabled`

Would appreciate any help! Thank you!

Hi infiniteregrets, thanks for having a look at this.
Try to update tabled by setting tabled = "0.5" in Cargo.toml
Then it should match the docs you are looking at.

Thanks, that fixed the issue. I should have paid more attention.
I have tried quite a few times now with different settings and it looks like the left rotation doesn't just come through, it is missing the headers.
I think the default ASCII view is much better than the psql view:
ASCII:
 Source
+-------------------------+
|        ID        | Type |
+------------------+------+
| wikipedia-source | file |
+------------------+------+

 Parameters
+-------------------------------------------------+
|   Key    |                Value                 |
+----------+--------------------------------------+
| filepath | "/quickwit/wiki-articles-10000.json" |
+----------+--------------------------------------+

 Checkpoint
+-----------------------+
| Partition ID | Offset |
+--------------+--------+

PSQL:
Source                   |
-------------------------+
        ID        | Type
 wikipedia-source | file

Parameters                                       |
-------------------------------------------------+
   Key    |                Value
 filepath | "/quickwit/wiki-articles-10000.json"

Checkpoint             |
-----------------------+
 Partition ID | Offset

Left rotation always gives incorrect output in all modes:
╔╦══════╦══════════════════╗
║║ Type ║       file       ║
╠╬══════╬══════════════════╣
║Source ║ wikipedia-source ║
╚═══════╩══════════════════╩

╔═╦════════╦══════════════════════════════════════╗
║ ║ Value  ║ "/quickwit/wiki-articles-10000.json" ║
╠═╬════════╬══════════════════════════════════════╣
║Parameters║               filepath               ║
╚══════════╩══════════════════════════════════════╩

╔═╦════════╗
║ ║ Offset ║
╠═╬════════╣
║Checkpoint║
╚══════════╩

I think, left rotation even from the examples would make the results a bit hard to read for a user. I think sticking the simple ASCII mode is much sleek and nice making the results more separated and readabale.
I can't really pin what is the issue, but I would believe it could be a bug in Tabled? Otherwise the examples in the manpage seem okay?
If you like the ASCII mode, I can open a PR to change that. Sorry I couldn't really figure that left rotation, but if you have any suggestions for me to work on, please let me know! Thanks!

@infiniteregrets thanks for your work.
Yes ASCII mode seems the best, you can open a PR for using it.


[Bug] PopUp looks different on iOS

Description
Simple popup looks different on Android and iOS devices. The background shadow is on the inside on iOS not on the outside. See images to compare results.
Basic Information
IDE: Visual Studio 2019 v.16.11.7
Xamarin.Forms: <IP_ADDRESS>4
Xamarin.CommunityToolkit: 1.3.1
Android TestDevice: Android 11.0
iPhone TestDevice: iOS 15.0.2
XML Code

Android

iOS

@alex3326 are you using Dark mode on the iOS device?

bijington

Yes but the dark background is still missing on the light mode. Or is there never a dark background like on Android?
Thanks for the hint ^^.

@bijington
Yes but the dark background is still missing on the light mode. Or is there never a dark background like on Android?
Thanks for the hint ^^.

Sorry I don't know too much around Popups by my initial thoughts are that it is down to the appearance set on the phone.
The below shows the same popup being rendered on the same device with just changing the appearance setting on iOS.
There should be a similar setting on Android, have you got that set to light or dark?
Light mode

Dark mode

Anyway if you want to override the colours you see here you can set the BackgroundColor or Color of the popup or inner controls to what you would like.

Exactly the same thing happens to me in iOS, the dark background does not appear, is it a bug? or is it the expected behavior in iOS? On Android, however, it works correctly and shows the background darkened. I have prepared a repository on GitHub to be able to reproduce it :
https://github.com/nacompllo/PopupBackgroundTransparent
If anyone can shed any information on this I would appreciate it.

As normal system popups have a darkened background I would assume this is a bug or at least a missing feature. @VladislavAntonyuk is the behaviour the same for the MAUI version?

I did a small workaround by showing a full-screen contentview of BackgroundColor="#CC000000"


Added possibility to define a custom size of snapshot

In our project we need a bit more precise quantiles (like p9999) but this is not possible without increasing size of snaphot.
This PR introduces a possibility to create MetricRegistry object with custom size of created metrics.

I intend to include support for customization of metrics, but it's going to be a bigger change than this. As far as specifying size on the reservoir, that's already possible with the public ExponentiallyDecayingReservoir(int size, double alpha) constructor.

Is it possible to specify size of reservoir when creating MetricRegistry?
I think the problem here is that the only constructor used by MetricRegistry is the default one, and it doesn't really matter that there is ExponentiallyDecayingReservoir(int size, double alpha) constructor.

Only if you create the timer manually: new Timer(new EzponentiallyDecayingReservoir(...)) and then register it with the metric registry.
V4 will permit you to set a default metric factory which allow you to customize the default behavior.

Ok, should be enough for  now. Thanks.


Unable to launch on Catalina

macOS version: 10.15.1
Kap version: 3.0.0
Steps to reproduce
Downloaded Kap from https://getkap.co/ and then tried to launch after installing macOS Catalina
Current behavior
When trying to launch I get a popup saying it needs to be updated by the developer:

Expected behavior
It would let me open it and try it out :)

Hey @berlinjohnson, as a workaround while we try to resolve this, you can Control + right click the app, and then click open. It should open the same window but with an extra "open" button. You should only need to do that once.


Issues related to first task

Need to confirm this is the official website (https://chingari.io/) and that the website content should be the same and have to focus on the designing part.

Yes This is the official site https://chingari.io/ & https://nft.chingari.io the content should be a combination of both, this task is to get more understanding on your UI & UX too, & see your skills in creating product flow.
It's a open ended task to create a chingari lite web app screens created & proposed by the open source community.
We would suggest you to go through chingari mobile app to know more about chingari's offering & user base.

I am a Web Developer and I am not a UI UX Designer. Therefore can I make this using React Js.

We are looking for Design intern, Web development is good but the candidate should have the skill set to create basic UI UX & prototypes. Not expecting advanced Visual designs but this much is must. & just figma of screens would be sufficient for the task no need for creating react components.

Accidentally, I selected Os Contributor Assignment For Gari Repo Mantainance.
I want to participate in this and I completed 75%. Can I make pr of assignment in that one?
Please resolve my problem

Raise another Pr for the design task with your submission & make a commit to the submission you made in OS contributor mentioning the same issue as a note on top of readme or just discard that

I willing to tell you that I made the pr in Os Contributor Assignment For Gari Repo Mantainance.
So please 🥺 review my assignment.


UIApplication method setStatusBarHidden:withAnimation: deprecated.

The method setStatusBarHidden:withAnimation: has been deprecated for iOS9 and up, how would you like to handle this within the library?
Thanks!

Fixed with latest pr


Add ZSH_TMUX_UTF8 option to tmux plugin

@jmatth

oops. looks like it is quite popular PR. It is partial duplication of: #5776, #5166, #2023

@samogot Can you please rebase this PR onto our latest master branch. Then update this PR with a Commit please? Thank You!


Typo reported by El Reg

Hi,
As reported here https://www.theregister.com/2023/10/24/freebsd_14_rc2/ you may want to fix this :-)
--- desktop-installer/FreeBSD/desktop-installer.orig	2023-10-24 14:40:50.665812246 +0200
+++ desktop-installer/FreeBSD/desktop-installer	2023-10-24 14:41:05.581825750 +0200
@@ -2934,7 +2934,7 @@

 NOTE:

-Some software may ave been installed by building from source to avert
+Some software may have been installed by building from source to avert
 potential compatibility issues or to respect software license restrictions.

 You MUST use auto-admin or auto-update-system to ensure that packages

Thanks,
Simon

Thanks for the 'eads up, mate.  The fix will be in the next commit.


Quick-menu shows maximum 50 suggestions

Hi,
When programming in HTML the auto-suggest menu for adding attributes to an HTML-element shows only a maximum of 50 possible attribute-names in alphabetically order.
For example: if you enter
<input
the auto-suggest menu ends at oncanplay, even there are many more possibilities like onfocus, onsubmit, placeholder, required, etc. which aren't possible to select.

Clean installation of Brackets 1.10 on Windows 10 64bit didn't help. Even with all extensions disabled. Problem also shows up in Brackets Portable 1.10.

I've noticed that this error does not only happen in html, is commun to all code hints.
I also traced it back to CodeHintList, on directory src/editor/CodeHintList, line 68
"this.maxResults = ValidationUtils.isIntegerInRange(maxResults, 1, 1000) ? maxResults : 50;"
This sent me to the function isIntegerInRange() on ValidationUtils
"  function isIntegerInRange(value, lowerLimit, upperLimit) {
// Validate value is an integer
if (!isInteger(value)) {
return false;
}
    // Validate integer is in range
    var hasLowerLimt = (typeof (lowerLimit) === "number"),
        hasUpperLimt = (typeof (upperLimit) === "number");

        return ((!hasLowerLimt || value >= lowerLimit) && (!hasUpperLimt || value <= upperLimit));
}

"
This must be returning false and therefore 50 is the value that goes into maxResults

Is this hint list getting updated or not on typing ? I mean if you type "o" there, then hints are getting updated right ?

I think it would be a better idea to enable configuration of the limit by drawing maxResults from brackets.json. The limit is there for a reqson after all.

Yes Performance is one reason behind this.
This is already there you can change maxhints from preference. (i.e. "maxCodeHints": 100)
We are taking this value from preference only check CodeHintManager.js
"maxCodeHints = PreferencesManager.get("maxCodeHints");"

I hope this solves your problem. Closing this issue. Feel free to open again if this doesn't help you.


example: awscli bucketAccessRequest does not grant access

i was trying to test ceph-cosi onKinD cluster, when create examples/awscliapppod.yaml pod stuck into creating status and show info:
Events:
  Type     Reason       Age               From                  Message
  ----     ------       ----              ----                  -------
  Normal   Scheduled    18s               default-scheduler     Successfully assigned default/awscli to kind-worker
  Warning  BARNotReady  2s (x6 over 18s)  objectstorage.k8s.io  Bucket Access Request has not been granted access yet
  Warning  FailedMount  2s (x6 over 18s)  kubelet               MountVolume.SetUp failed for volume "cosi-secrets" : rpc error: code = FailedPrecondition desc = bucketAccessRequest does not grant access

way to reproduce:

setup a kind cluster with one worker

# necessary for conformance
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
networking:
  ipFamily: ipv4
nodes:
# the control plane node
- role: control-plane
- role: worker

$ kind create cluster --config kind.yaml

Installing CRDs, COSI controller, Node adapter
install cosi driver

$ make build
$ docker tag ceph-cosi-driver:latest ceph/ceph-cosi-driver:latest
$ kind load docker-image ceph/ceph-cosi-driver:latest
$ kubectl apply -k .

create examples resource

$ kubectl create -f examples

some logs of ceph-cosi-driver
-----------------------------------------------------
2021/11/12 10:13:00 DEBUG: Request s3/CreateBucket Details:
---[ REQUEST POST-SIGN ]-----------------------------
PUT /test-3a089556-038d-4950-b304-ff53326b6e5a HTTP/1.1
Host: rgw:8080
User-Agent: aws-sdk-go/1.38.24 (go1.17.1; linux; amd64)
Content-Length: 0
Authorization: AWS4-HMAC-SHA256 Credential=ceph/20211112/us-east-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=8a5c3f09ae800464929e7f9a93e1f2a2175b0afe103e2c65cbf6e551fe81ccf3
X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20211112T101300Z
Accept-Encoding: gzip

-----------------------------------------------------
I1112 10:13:00.663341       1 s3-handlers.go:90] DEBUG: after s3 call, ok=true, aerr=RequestError: send request failed
caused by: Put "http://rgw:8080/test-3a089556-038d-4950-b304-ff53326b6e5a": dial tcp: lookup rgw on <IP_ADDRESS>:53: no such host
E1112 10:13:00.663847       1 provisioner.go:68] "failed to create bucket %q" err="failed to create bucket \"test-3a089556-038d-4950-b304-ff53326b6e5a\" error RequestError: send request failed\ncaused by: Put \"http://rgw:8080/test-3a089556-038d-4950-b304-ff53326b6e5a\": dial tcp: lookup rgw on <IP_ADDRESS>:53: no such host" test-3a089556-038d-4950-b304-ff53326b6e5a="(MISSING)"

My bad, forget to setup rgw server first


Fixes #1363 - remove console.log on library init and use the Logger

Summary
This PR fixes #1363 - the console.log during initialization of the library was removed - I believe that the user of html2canvas should be able to switch off logging completely.
Fixes #1363

Fixed with https://github.com/niklasvh/html2canvas/commit/da2794f7f773e9f4a18f6b00ba5129988610e81a


Add CI for the webhook

The webhook is a component that can be tested in isolation. You will only required a working Kubernetes cluster (which can be setup with Kind) and the tools to build the webhook itself. So this pull request contain an CI for the webhook which is triggered only and only if the webhook files changed.
The CI is built on a github action, runner script and bats tests. Developers will be able to run the same workflow locally by issuing make test-e2e.
Refer to the https://github.com/wainersm/cc-cloud-api-adaptor/actions/runs/3268928340 for a successful execution of the github action.
Note: there is a test case not passing which was marked to skip.
Fixes #291

Updated this to remove the handling of an unnecessary local registry. Thanks @bpradipt for the review!
Added a new commit (https://github.com/confidential-containers/cloud-api-adaptor/pull/310/commits/38f137b511146d6d2e2570ab219b0572a541f812) to pin the k8s version used on the e2e tests.


Onboarding Request

Your Twitch username
darbdarbdarb

Added you, thanks. Let me know if you have any issues


[release-v1.15] Add Konflux configurations

Add Konflux components and pipelines

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-v1.15@97cfdf5). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.15     #107   +/-   ##
================================================
  Coverage                 ?   82.26%
================================================
  Files                    ?       25
  Lines                    ?     1607
  Branches                 ?        0
================================================
  Hits                     ?     1322
  Misses                   ?      189
  Partials                 ?       96

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm
/approve

Failed to create PVC for PipelineRun ocp-serverless-tenant/net-istio-webhook-115-on-pull-request-9vff9 correctly: PVC creation error: failed to create PVC pvc-6fe5819aa4: persistentvolumeclaims "pvc-6fe5819aa4" is forbidden: exceeded quota: storage, requested: count/persistentvolumeclaims=1, used: count/persistentvolumeclaims=360, limited: count/persistentvolumeclaims=360

/retest

/retest

Still
Failed to create PVC for PipelineRun ocp-serverless-tenant/net-istio-controller-115-on-pull-request-6tnm6 correctly: PVC creation error: failed to create PVC pvc-b3fc5ebf55: persistentvolumeclaims "pvc-b3fc5ebf55" is forbidden: exceeded quota: storage, requested: count/persistentvolumeclaims=1, used: count/persistentvolumeclaims=360, limited: count/persistentvolumeclaims=360

/override "Red Hat Konflux / net-istio-controller-115-on-pull-request"
/override "Red Hat Konflux / net-istio-webhook-115-on-pull-request"
/override "Code Style / style / suggester / yaml"

/override "style / suggester / yaml"

/lgtm
/approve


add complete documentation

Hey.
It would be nice if there was something like a write_to_stdout() function, or if write_to_textfile() would somehow allow writing to stdout.
For debugging that would seem to be much more helpful. Also, distros may have their own unified means of collecting the .prom files and thus even in production it may make sense to let a program simply write the metrics to stdout.
Cheers,
Chris.
PS: Using /dev/stdout doesn't work, as it tries to write it's tmpfile there.

After reading the code I found generate_latest() which seems to do what I want.
So the actual problem seems rather that the whole Python module is basically not documented at all.
https://prometheus.github.io/client_python/ can at best count as a quick how-to, but even that doesn't seem to cover the most simplest and probably regularly used stuff (like clearing time series with labels that no longer exist), not to talk about general concepts like the registries or proper documentation of all classes, methods and their params. :-(

Re-dedicating this issue, asking for some more complete documentation ;-)

Another area that seems completely undocumented is CustomCollectors - not only the class itself, but also the concepts, when/for what they're used and how they work.
The example given at https://prometheus.github.io/client_python/collector/custom/ doesn't even work, as prometheus_client.core no longer exits (guess it was renamed to metrics_core at some point.
There's no telling that CustomCollectors are automatically called (and do their thing in collect()) whenever the exporter is scraped.
In contrast to direct instrumentation, where the metrics are updated "on the fly" in the code, regardless of whether the exporter is even scraped at all.
No word about what "direct instrumentation" even means.
No word about what describe() is used for, which would be handy, if one e.g. writes an exporter that shall support both modes:

running continuously and being queryable via http
one-shot mode, and e.g. being usable with something like node-exporter-collector

I one wants to do both, then it seems generate_latest() also calls the custom collectors, but with the default registry it does so twice (probably because of auto describe), which is of course rather undesired in one-shot mode.
(I had to gather all that information from blogs and 3rd party websites... all doing things a bit different... some making collect() a generator with yield others not.
Having basically no proper documentation is really a pity, as the Python client seems actually to be quite neat, but if people have to read the whole sources or try their luck on google with questionable outcome, they probably simply won't use all the nice features in a proper way.

https://github.com/prometheus/client_python/issues/1021 is another issue focusing on API documentation that would hopefully make things like generate_latest more discoverable, that said the custom collector documentation would be more than just API documentation and would be nice to have in addition. Perhaps this issue could focus on that?
I hesitate to have an issue for just "complete documentation" since that is a moving target as more features are added.

It's at least difficult IMO to have many small issues for just single points that seem to be missing from the documentation, because if I add another issue for every thing I find presumably missing, I'd spam the issue tracker ;-)
Like there was the point of yield (as used by the example - though I actually don't understand why that would work if collect() is called only once per scrape) vs. return (as used in the default collectors shipped in the package) I've already mentioned above.
It would further e.g. be nice to document that:

With direct instrumentation - I presume - only single metrics are set atomically. In the sense that if one has:gauge_a.set(34)
gauge_b.set(66)

and these - via labels (used like primary keys) - somehow relate to each other, a scrape in-between may see of course gauge_a set but guage_b not yet.
Perhaps also mentioning that it's guaranteed that every single metric is either fully set or not - i.e. it cannot happen that e.g. one label is already set, the value, too, but a 2nd label is still empty.
With a custom collector OTOH, it seem that one can set multiple different metrics in an atomic way, i.e. any scrapes wait until the collect() has run through.

Another thing, which lacks documentation is IMO, what describe() shall actually return. As mentioned above, I have a use-case where I want to prevent collect() being run just for auto describe.
It's also not really clear what happens if there is simply no describe() function and not auto describe... I mean will it just fail? Will some functionallty be missing, which?
And there are many little bits and pieces:

What's mentioned here https://prometheus.github.io/client_python/instrumenting/ .. these _created metrics, do not seem to be generated with custom collectors either, not sure why not.

And at least I'm kinda lacking some more concrete best-practises on how do design metrics. I know there are a few documents on that, but they're rather very abstract IMO.
I've had written a post with some more concrete questions here and another one in the same place, though that got caught by the spam filter and so far not moderator was willing to approve it.

What's IMO also confusing is:
For the custom collector metric classes (CounterMetricFamily, etc.).
My understanding was that each object of e.g. CounterMetricFamily is one metric (at last if gone goes by the terminology used in the Prometheus documentation), which can have multiple samples for different values of the possible labels.
Here however, MetricFamily seems to be what Prometheus calls metric and add_metric seems to set the most recent sample of timeseries for a metric+labelset combination.
Also, it's unclear why/when one would use __init__()’s value= and when .add_metric(…, value=). I haven't followed the code to the end, but would guess that .add_metric(…, value=) needs to be used whenever one has different labelsets per metric, and the constructor’s value= may be used when there are no lables (and perhaps also when one simply uses the empty value for all labels?)?

Yet another ;-) ... part that should IMO be documented is the following:
With direct instrumentation the typical usage seems to be:

first create once the metric object at some place
then, modify that object with .set(), .inc(), etc.

With custom collectors, one could, too do something like above e.g. as in:
import prometheus_client
import sys
import os
import time

r=prometheus_client.CollectorRegistry()

class MyCollector(prometheus_client.registry.Collector):
    def __init__(self, registry):
        self.foo = 0
        registry.register(self)
        self.tm = prometheus_client.metrics_core.CounterMetricFamily('my_time','Current time',labels=['host', 'foo'])

    def collect(self):
        print("collect called", file=sys.stderr)
        self.foo +=1
        tm = self.tm

        tm.add_metric([ os.uname()[1] ], value=self.foo)
        if self.foo % 2 == 0:
            tm.add_metric([ "foo" ], value=666)

        return [tm]

MYCOLLECTOR = MyCollector(r)

prometheus_client.start_http_server(8000, registry=r)
time.sleep(100000000)

where I create one CounterMetricFamily in __init__() and always call .add_metric() on that.
But the outcome of that is at best unexpected:
First scrape:
# HELP my_time_total Current time
# TYPE my_time_total counter
my_time_total{host="heisenberg"} 1.0

Second scrape:
# HELP my_time_total Current time
# TYPE my_time_total counter
my_time_total{host="heisenberg"} 1.0
my_time_total{host="heisenberg"} 2.0
my_time_total{host="foo"} 666.0

Third scrape:
# HELP my_time_total Current time
# TYPE my_time_total counter
my_time_total{host="heisenberg"} 1.0
my_time_total{host="heisenberg"} 2.0
my_time_total{host="foo"} 666.0
my_time_total{host="heisenberg"} 3.0

Seems like it would just store all the samples and print all... even for the same metric+labelset combinations.
I wasn't even aware that such "re-definitions" are allowed.
Instead, it seems, that – unlike with the direct instrumentation usage – one has to always re-create the metric objects like in:
import prometheus_client
import sys
import os
import time

r=prometheus_client.CollectorRegistry()

class MyCollector(prometheus_client.registry.Collector):
    def __init__(self, registry):
        self.foo = 0
        registry.register(self)

    def collect(self):
        print("collect called", file=sys.stderr)
        self.foo +=1
        tm = prometheus_client.metrics_core.CounterMetricFamily(
            'my_time',
            'Current time',
            labels=['host', 'foo'],
        )

        tm.add_metric([ os.uname()[1] ], value=self.foo)
        if self.foo % 2 == 0:
            tm.add_metric([ "foo" ], value=666)

        return [tm]

MYCOLLECTOR = MyCollector(r)

prometheus_client.start_http_server(8000, registry=r)
time.sleep(100000000)

in order to get reasonable results.


router-active.ts is not necessary anymore

Angular2 beta 9 has a new feature that adds "router-link-active" class to the activated menu item without configuration.

Feature: angular1_router: Add ng-link-active class to active ng-link (11e8aa2), closes #6882

you may want to deprecate the file.

that's for angular1

@gdi2290  no it's for angular2, and I've tried it
https://github.com/angular/angular/blob/master/CHANGELOG.md

@MurhafSousli You are correct.

router: router-link-active CSS class support (36eb9d3), closes #3209

We have "router-link-active" available in Angular 2 from 2.0.0-alpha.37 (2015-09-09)
I tried on my local machine and its working fine without router-active directive.

router link is fine. when you want the active class on the parent that's a problem

@gdi2290 Ok.
Then we need router-active.ts

@gdi2290 why it is removed? how can I set class on parent now?


Policykit strips out newlines from messages

I was trying to format an overly wordy Slack message so it used multiple paragraphs, but adding \n to the message didn't work as expected. Instead, the PolicyKit ux grabbed the newlines and interpreted them itself, such that this code:

Became this code:

Ugh I've been hitting this too. I believe its an issue with how we're loading existing policies into the editor, which happens here https://github.com/amyxzhang/policykit/blob/d2884b6b70d6e21e894cc0f2e8774e729be148b0/policykit/templates/policyadmin/dashboard/editor.html#L439

Re-upping this, since we have a user community that is frustrated by not being able to put newlines in their messages.


Facing issue with running hydro_simple, stellar_simple.py

When I am running the code for hydri_simple.py or even stellar_simple.py, I am facing same issue of opening file is false
python3 hydro_simple.py
Invalid MIT-MAGIC-COOKIE-1 keyTraceback (most recent call last):
File "hydro_simple.py", line 55, in
main(**o.dict)
File "hydro_simple.py", line 17, in main
write_set_to_file(bodies.savepoint(0.0 | t_end.unit), "hydro.hdf5", "hdf5",append_to_file=False)
File "/home/ritik_shah/.local/lib/python3.8/site-packages/amuse/io/base.py", line 72, in write_set_to_file
processor.store()
File "/home/ritik_shah/.local/lib/python3.8/site-packages/amuse/io/store.py", line 96, in store
processor = store_v2.StoreHDF(
File "/home/ritik_shah/.local/lib/python3.8/site-packages/amuse/io/store_v2.py", line 642, in init
raise Exception("Opening file for write with overwrite_file is False but file {0} exists".format(filename))
Exception: Opening file for write with overwrite_file is False but file hydro.hdf5 exists
Cannot figure out how to resolve this issue, can you help?

either set overwrite_file=True in write_set_to_file, or delete the hydro.hdf5 file manually.


Redact credentials in create_vm response message

When cpi methods (e.g., create_vm) fail, the cpi returns an error which wraps the full context including certificates and passwords. The cpi must not reveal any credentials in the error response.
We found that the whole context is also written into logs, these must also redacted.
/cc @s4heid @friegger

HI @videlov The latest release v29.0.0 has removed the credentials from error message. Please check it.

The Issue can be closed from our side. We validated that no secrets are leaked anymore. We provoked an error by referencing an invalid vm_type with the old and the new version.
Thanks for following up so quickly!
Best regards,
@FlorianNachtigall , @beckermax


Player list: Change the background color for online player

Query online status from "account" table, and change the background color to
"#FFFFAA"(light yellow) if the player is currently online.
Signed-off-by: AceLan Kao<EMAIL_ADDRESS>

Sorry for the very late response. Will create a new version during the weekend including this 😉


fix: CommonNavigator isCurrent was always returning false

Description of the changes

There was a problem with the isCurrent method of the CommonNavigator which was causing the result to not be correct on nested routes. I changed the check to use namedLocation instead which returns the full path for a route with the necessary parameters.
Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

Technical highlight/advice

There is no description in this PR...
You should add unit tests to prevent regression. See this article that explains how to handle GoRouter unit tests: https://guillaume.bernos.dev/testing-go-router/

We'll see later to create the GoRouter Unit tests


Use babel-eslint as parser ?

because this cool project generates ES2015 stuff, and soon ES2016 we hope.
And:

Given the recent developments in the world of parsers, I think that using babel-eslint is the best way to play with cutting edge features like this. https://github.com/babel/babel-eslint

That means you don't have to wait for us, and we don't need to worry about constantly updating experimental features.

from https://github.com/eslint/eslint/issues/1657#issuecomment-77500655
Default parser couldn't handle http://babeljs.io/docs/plugins/transform-object-rest-spread/ plugin I my case.

@mr-wildcard: Sounds like a good idea. I will play around with and check if it can be easily integrated (as stated on the project page, that should be the case).

:+1:
In case it's ok for you @weblogixx,
These change needs two simple steps:

adding babel-eslint as devDependency
adding "parser": "babel-eslint", in .eslintrc file

@mr-wildcard: Just added it to the underlying template. It should be available after updating your installed generator.

:100:  thx @weblogixx


[Bug FE] [UI Next] [V1.0.0-Alpha] The interface for adding DingTalk alert instance  is not fully internationalized

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

What you expected to happen
Fields in red boxes are displayed in chinese
How to reproduce
above
Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Someone is doing this problem, please look for the problem carefully next time when submitting an issue and handling PR.


[Studio] Measure AsyncAPI adoption

Related to https://github.com/asyncapi/community/issues/879
Scope

[ ] Define metrics to collect
[ ] Collect metrics in code

Something I find challenging is imagining the metrics we want to collect in Studio. CLI is easy; counting each command execution (validate, generate, etc), extract data from documents, etc.
However, the Studio is basically a live editor, where things happen in background, like re-parsing and validating, on every time you update the document.
We might want to set some kind of limitation on those in order to get metrics that make sense to us. Deeply thought... what metrics do we need to ensure we know how users use the Studio?
cc @fmvilas @Amzani

Not stale please
cc @Samridhi-98 @peter-rr

@smoya We can keep the metrics like  number of document edits and Compexity of document

still relevant


add Text and Editor type (close #1074)

Let me know if you have any uncertainty on my changes, as they modified quite a few things !
I can add more tests for type = "text" if you guide me where I should put them.

btw the GitHub CI generate a lot of warnings, including ancient versions and deprecation warning

btw the GitHub CI generate a lot of warnings, including ancient versions and deprecation warning

yeah, really strange. But it should be fixed now.


Tcpvcon missing from ZIP file

This page: https://docs.microsoft.com/en-us/sysinternals/downloads/tcpview#using-tcpvcon mentions Tcpvcon but the linked ZIP file and the Sysinternals Live link only have Tcpview

Thanks for the heads-up!
Did you have success getting it? We added the file back with the latest release, closing the issues for now.


Quota exceeded

Hi,
i use more flexdatalist inputs in my ASP.Net web application and on some computers i get errors in Debug window of Chrome browser: Failed to execute 'setItem' on 'Storage': Setting the value of exceeded the quota. No list of items aren't shown of course. Is there a way to automatically clear cache after selecting item?

I also have seen this and saw that it was recommended just to wrap it in a try catch. Is that really the way forward?

Hi,
Flexdatalist uses localStorage as cache storage. It tries to do garbage collecting as much as possible, if the problem persists even in the latest releases, I would recommend disabling cache.
Cheers!


[rest] Add optional swagger API endpoints #102

Closes #102

Coverage decreased (-2.7%) to 96.667% when pulling d910bf1d2840afeb22e643c69e8fe198dbb0d458 on PabloCastellano:issue/102 into 6107fcd4fc552971fe3e363e64d70b48b2892db2 on openwisp:master.


Unity 5.2 Windows bug when adding Clojure Component

I used tutorial and when I add Clojure Component - > error in the status bar of Unity:
Invalid generated unique path "{input path 'Assets/Clojure/Scripts/new-component.clj")
I used unstable branch.

Solved: folder must be named as Assets/Clojure

Oh that's a bug. new-component hasn't been updated to the new folder structure.

Fixed on develop! Thanks!


Hint text not visible

issue: Input box of adding other user's id have very low visibility of hint text

It can be corrected by using different and more brighter color

Hii @PradyumnaKrishna @ydv-ankit ,
I'll handle this issue.. please assign me the same

Yes, can you assign to me?


No negative diffuse shading

The clamping on the lambert factor from the previous exercise (https://github.com/stackgl/shader-school/blob/master/exercises/light-2/shaders/fragment.glsl) wasn't done in this one.
(as a side effect, there's no way I could have passed without cheating - both outputs look pretty similar)

Seems this applies to the subsequent shaders too

Thanks, if you patch the other shaders I'll merge that in too.


Cow: Watch AngelinaChristopherson1738(?:gmail.com)?

Cow requests the watch of the watch_keyword AngelinaChristopherson1738(?:gmail\.com)?. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

AngelinaChristopherson1738(?:gmail\.com)? has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Spevacus in Charcoal HQ. Reason: 'By request'


ERR_CONNECTION_REFUSED.

I get this
Creating Minecraft server
Please open https://login.microsoftonline.com/consumers/oauth2/v2.0/authorize?client_id=(removed)&response_type=code&redirect_uri=https%3A%2F%2F<IP_ADDRESS>%2Fauth-response&response_mode=query&scope=XboxLive.signin+offline_access&state=tRhwbidsvxBh7YfKKpBlBg&code_challenge=S0y5aMT54UHd34jK3HTFoPeEyJs8xxLvVJua-OoldnI&code_challenge_method=S256 in your browser and copy the url you are redirected into the prompt below.
(removed is the client_id I created)
but I just get a connection refusal each time, not sure what I've done wrong

Do you have any error message?
Depending on the error message, It could be you didn't add the redirect url to the white list in the app.

Hi, thanks for your interest in this project! For connection refused, you can check this section in FAQ.md

Okay so I see the code it mentions per the faq, what do I do with it?

You just need to copy that link in your browser and paste it to your terminal, then hit the Enter key.

its still the same result. I used one like the one involved and I got this in the address box after the connection is refused https://<IP_ADDRESS>/auth-response?code=M.C107_SN1.2.90b3454c-5679-c35b-2da3-53efbc37de87&state=NLWLahsjPtvQMxrhdEGRXQ
putting this in again still gives me connection refused

oh, I'm stupid and unable to follow instructions

Hi, to protect your personal information, I edit your response. The link you just paste is the correct one. You just need to paste that one to your terminal but not your browser.

Traceback (most recent call last):
File "H:\AI MC\Voyager\run.py", line 13, in
voyager = Voyager(
File "H:\AI MC\Voyager\voyager\voyager.py", line 102, in init
self.env = VoyagerEnv(
File "H:\AI MC\Voyager\voyager\env\bridge.py", line 42, in init
self.mc_instance = self.get_mc_instance()
File "H:\AI MC\Voyager\voyager\env\bridge.py", line 67, in get_mc_instance
return MinecraftInstance(
File "H:\AI MC\Voyager\voyager\env\minecraft_launcher.py", line 36, in init
self.mc_command = self.get_mc_command()
File "H:\AI MC\Voyager\voyager\env\minecraft_launcher.py", line 89, in get_mc_command
login_data = minecraft_launcher_lib.microsoft_account.complete_login(
File "C:\Users\Admin\AppData\Local\Programs\Python\Python310\lib\site-packages\minecraft_launcher_lib\microsoft_account.py", line 261, in complete_login
token = token_request["access_token"]
KeyError: 'access_token'

Traceback (most recent call last): File "H:\AI MC\Voyager\run.py", line 13, in voyager = Voyager( File "H:\AI MC\Voyager\voyager\voyager.py", line 102, in init self.env = VoyagerEnv( File "H:\AI MC\Voyager\voyager\env\bridge.py", line 42, in init self.mc_instance = self.get_mc_instance() File "H:\AI MC\Voyager\voyager\env\bridge.py", line 67, in get_mc_instance return MinecraftInstance( File "H:\AI MC\Voyager\voyager\env\minecraft_launcher.py", line 36, in init self.mc_command = self.get_mc_command() File "H:\AI MC\Voyager\voyager\env\minecraft_launcher.py", line 89, in get_mc_command login_data = minecraft_launcher_lib.microsoft_account.complete_login( File "C:\Users\Admin\AppData\Local\Programs\Python\Python310\lib\site-packages\minecraft_launcher_lib\microsoft_account.py", line 261, in complete_login token = token_request["access_token"] KeyError: 'access_token'

I'm also getting thi serror.

Hi, all. Make sure you log in to the correct Microsoft Account and set everything correctly in App Registration. You can see #18 for further information.

May be a proxy issue?

Works for me if you set the secret_value to "" in the azure_login options:
azure_login = {     "client_id": "...",     "redirect_url": "https://<IP_ADDRESS>/auth-response",     "secret_value": "",     "version": "fabric-loader-0.14.21-1.19.4", # the version Voyager is tested on }


Add Error Message Combiner Function

Developers should not have to manually or the messages together.  Create a combiner function that can take many validators as arguments and or them together automatically.

Closed via d59a3bcfd87f5c328125c03a1f3495c2d17b65ff


Progress indicator for binary download

Right now it is very hard to determine the progress of binary download as the CLI is just printing a bare message. It will be useful for people on slow networks to determine the progress of the download.

We have this now.


[Inquiry] International Market mechanics usability (AAT DLC)

I'm sorry to ask this here, but the Steam Workshop page has no comment section available - if not though, I would be happy to contribute to get them working for this mod.

Pretty sure comments are available on the workshop page
You currently can't sell ammo on the market; ammo exists only has a bunch of numbers in memory and the game otherwise has no concept of it.
AFAIK you can only put equipment on the market so I'm not exactly sure if it'd even be possible to implement the ability to sell ammo?


Updates github org name

Updates links from LabForComputationalVision/plenoptic to plenoptic-org/plenoptic

As part of this, also corrected lots of http links to https


[BUG] v1.2.1 has no binaries attached

ya not sure how to update to this version, im on 1.2.0 and won't sync as of last night.

There is also something wrong with the archive. Please fix it.

Already added binaried and fixed the windows archive.


ENG-12558: add AuthType to the repo conf auth payload

Description of the change
The conf/auth payload got a new field, AuthType, so this PR adds it so that it is configurable via TF.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] Jira issue referenced in commit message and/or PR title

Testing
Tested in a k8s deployment + unit tests

@VictorGFM thanks for the approval! Can you merge it, please? I don't have merge privileges for this repo :stuck_out_tongue:


edac-utils: unstable-2015-01-07 -> unstable-2023-01-30

Description of changes
This change updates edac-utils package to the latest commit (see changes).
It also

adds perl to buildInputs so that shebang is fixed in edac-ctl command,
adds a patch to avoid using wrapProgram for PATH,
removes sysv init script from $out/etc.

Things done

Built on platform(s)

[x] x86_64-linux (pkgsCross.gnu64)
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Force-pushed rebase to the latest master branch.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1380

adds perl to buildInputs so that shebang is fixed in edac-ctl command,

Please add this info as a comment next to perl so that people know why it's there and won't remove it thinking it unnecessary (the upstream project does not seem to explicitly explain the dependency in README or otherwise).

@nh2 done.

@nh2, gentle ping.


add zenodo doi to readme, add preferred citation(s) to readme and docs

@Calama-Consulting and I discussed creating DOIs for pvlib releases. I just hooked up our repo to Zenodo so that it will automatically create DOIs for each release. I'll add the badge to the Readme after we release 0.2.
To test the system, I rereleased the PVSC 2015 repo to trigger the DOI creation and then I added the new badge. It takes a little bit of time for DOIs to propagate, but hopefully the link on that readme will work soon.
We should also discuss how we would want people to cite pvlib in academic papers. See e.g.
http://ipython.org/citing.html
http://matplotlib.org/citing.html
http://deeplearning.net/software/theano/citation.html#citation
My only recommendation for now is to just use the papers in the PVSC 2014 and 2015 proceedings. I don't know how to specifically cite github contributors.

Added the v0.2.0 DOI. I will leave this open for a citation discussion.


[ISSUE #1199] Implement the 1.0.0 openmessaging new consumer API for rocketmq oms module

What is the purpose of the change
#1199 Implement the 1.0.0 openmessaging new consumer API for rocketmq oms module
Brief changelog
1、Adapt to the new consumer api
2、Adjust consumer example
3、Optimize consumer code implementation
4、Fix bug
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Hi @odbozhou do you verify this pr in your local enviroment?

Hi @odbozhou do you verify this pr in your local enviroment?

Yes，Sending and consuming messages have been validated

Just quickly look through, it needs more tests to make the code reliable in addition to what I have pointed in code review. But if you could do more followup, I would like to help to review again and again... I think it is a good polish for integration with OpenMessaging.

Just quickly look through, it needs more tests to make the code reliable in addition to what I have pointed in code review. But if you could do more followup, I would like to help to review again and again... I think it is a good polish for integration with OpenMessaging.

I will add more unit tests and look forward to contributing more to the community

@vongosling @duhenglucky @ShannonDing  Please help to review this pr again.Thanks very much.

LGTM


Current setup of gpgcheck in redhat package is insecure

in manifests/package/redhat.pp there is a gpg key( http://nginx.org/keys/nginx_signing.key ) that:

is downloaded from same server that is hosting the packages. So if attacker get access to it they can just replace that key with their own
is downloaded over http which makes MITM attacks trivial

Hi @XANi. Agreed, this isn't ideal. Unfortunately I don't know of any way to specify the actual key that should be used if we use the yumrepo provider. It only provides the gpgkey parameter which is "The URL for the GPG key", but you can't set the key itself like with the puppetlabs-apt provider.
Any suggestions on how to improve this? The nginx key is not available via HTTPS when using nginx.org, is there another source we can use?

I think a good compromise would be adding an option for user to specify path to nginx key and let them do key management if they want to.

It only provides the gpgkey parameter which is "The URL for the GPG key",

It can also specify file on disk
In our internal puppet repo we just include key with our repo like that
this works well for private repo (as we control what goes in) but of course for public module is suboptimal (but imo a bit better than serving key over http).

FYI we're looking into solving this problem in a similar Ansible role using some extra tasks to do the rpm checks: https://github.com/geerlingguy/ansible-role-nginx/pull/26

Since the signing key is unlikely to change often, maybe this could just be hard-coded as a file in the module itself? This may be somewhat less important with #914, since this will no longer be the default setting, but I agree that this doesn't seem like a great practice.

I'd set is as variable that defaults to key file inside the nginx module. That way in unlikely event that key changes it would be trivial to change it without touching nginx module code.

I understand the reasons why the current setup is not ideal (for Apt, FWIW, it is possible to pull from MIT keyserver; not sure if that option is better), but spoke with @hunner at the community modules team today, and does sound like pulling the key from a site, even if it's the same site, is pretty standard practice currently w/ modules.
As far as the key expiration thing, it seems like Apt already has something to handle this, but maybe not Yum; this is something that maybe we should file as a bug against the Yum provider if it's not already (I'll try and search). Given all that, I'm going to close this one for now, though we can still have more discussion about it if wanted.


Enhance Test Coverage for @yamada-ui/transitions

package: @yamada-ui/transitions
Description
@yamada-ui/transitions has a test coverage of less than 95%. We will enhance it to above 95%.
Target files

packages/components/transitions/src/flip.tsx

L156

Problem Statement/Justification
Testing is essential to ensure quality when operating a package.
Additional Information
While it's ideal to cover all tests, if there are too many lines to work on, please create a PR within your capacity.
Any deficiencies not covered by the PR will be automatically created as issues.

Hello @hirotomoyamada, can I work on this next?

Hi, thanks for the comment!
Yes, pls!


Roll Flutter Engine from 3aa112c75ccb to f0e5c08f7cdf (2 revisions)

https://github.com/flutter/engine/compare/3aa112c75ccb...f0e5c08f7cdf
2023-02-21<EMAIL_ADDRESS>[platform_view] fix overlapping platform view not touchable (flutter/engine#39527)
2023-02-21<EMAIL_ADDRESS>Started using bgr10_xr for opaque surfaces. (flutter/engine#39727)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Cannot find module 'solidity-docgen'

Hi, I'm facing an issue when I try to execute solidity-docgen v0.5.16 with hardhat.
$ npx hardhat docgen
You are using a version of Node.js that is not supported by Hardhat, and it may work incorrectly, or not work at all.

Please, make sure you are using a supported version of Node.js.

To learn more about which versions of Node.js are supported go to https://hardhat.org/nodejs-versions
An unexpected error occurred:

Error: Cannot find module 'solidity-docgen'
Require stack:
- /home/foo/hardhat.config.ts
- /home/foo/node_modules/hardhat/internal/core/config/config-loading.js
- /home/foo/node_modules/hardhat/internal/cli/cli.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:939:15)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/home/foo/node_modules/@cspotcode/source-map-support/source-map-support.js:811:30)
    at Function.Module._load (node:internal/modules/cjs/loader:780:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/foo/hardhat.config.ts:9:1)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module.m._compile (/home/foo/node_modules/ts-node/src/index.ts:1597:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Object.require.extensions.<computed> [as .ts] (/home/foo/node_modules/ts-node/src/index.ts:1600:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/foo/hardhat.config.ts',
    '/home/foo/node_modules/hardhat/internal/core/config/config-loading.js',
    '/home/foo/node_modules/hardhat/internal/cli/cli.js'
  ]
}

I also see the same error in hardhat.config.ts

solidity-docgen 0.5.16 is not a Hardhat plugin. Please use 0.6.


Added "open editors" sorting option by recently saved

A partly implementation of request from https://github.com/Microsoft/vscode/issues/12453
While having many files opened and using most of them as readonly reference, i like to see the files i  actually modified recently at the very top of "opened editors" list. Especially helpful when there are file with similar names. SublimeText has similar feature which i miss a lot.
Settings key:
Editor.recentlySavedFirst, true/false

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: sashaGee sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

My 2 cents: I don't like to see "Opened Editors" sorted differently from the sorting of the workbench tabs in the editor space. Both have to be in sync imho.

The tabs are being updated accordingly.
Before save:

After Save:

As you can see "readme.md" tab changed position to 1st.

Example of multiple groups interaction.
before save:

After save:

I find it very ugly to put the code to sort opened editors in the "Open Editors" view domain. If any, this has to live in the editorStacksModel.ts which is the foundation of all tabs and opened editors.

You can put it whenever you want, free country


supportedAlarmList to get DefaultValue and *

The current concept of supportedAlarmList:

Defining a couple of alarms, which are mandatory to be supported in the comment,
defining the minimum multiplicity according to the number of mandatory alarms
(because not possible to have default, when minimum multiplicity > 0) having no default value.

This concept doesn't work, because it is not assured that devices support the mandatory alarms.
As a consequence they could not be listed in the Capability attribute.
In worst case (happened at least for HybridMwStructure and PureEthernetStructure) the device does not support any alarm at all at this interface.
Because it is a list attribute, but does not have a  default value, the attribute doesn't show up in the implementation in this case.
Proposal:
All supportedAlarmList attributes shall have multiplicity * and default value "Supported Alarms Not Yet Defined."
supportedAlarmList : String [*] = "Supported Alarms Not Yet Defined."

Proposal to the 5G-xhaul call on 28th of July 2021:
The supportedAlarmList attribute shall have multiplicity * and default value "Supported alarms not yet defined."
(supportedAlarmList : String [*] = "Supported alarms not yet defined.")
UML and YANG have already been corrected.
Existing implementations are basing on the corrected YANG.
Further on, the comment shall be corrected from "Available alarms to be listed. Mandatory:'framingIsFaulty' and 'containerIsDown'. Further alarms might be added by the vendor." towards "Available alarms to be listed by the vendor.".

This is issue got obsoleted by #18.


How To Links Needed

This page would benefit from linking from this bulleted high level list of "what" needs to be done, to a set of lower level instructions to explain "how" to do these things.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9afcb5f6-8b55-f088-5cf6-c2b8e2365701
Version Independent ID: 7936e07d-fdb9-a548-04b1-d0e18272882a
Content: Set up online stores - Retail | Dynamics 365
Content Source: articles/retail/online-stores.md
Service: dynamics-365-retail
GitHub Login: @kfend
Microsoft Alias: meeram

@jblucher, could you please update this article as suggested.

Bug 289989 has been logged to track this issue.


Pasted title paragraph style does not pull in from google docs

https://user-images.githubusercontent.com/1952520/150233151-3a3c41df-c0a9-4ad6-a887-1c215533994c.mov

This has been fixed in #2729


update tsconfig in order to not keep unused imports

to restricted, because it blocks compilation if a variable is not use too.


BUG: high gas fee estimate with wallet-connect for doing transactions

Description
The estimated (gas required/gas used) is not right which makes doing transactions on goodswap too expensive
It is potentially something in the gdwallet as doing transactions with metamask are provided with proper estimates so it seems goodswap sends the correct transaction props initially
Steps to reproduce

Go to goodswap
Click connect wallet & then wallet connect
copy to clipboard
go to gd wallet
paste wc link
try a swap or stake some gooddollar on fuse network
(see screens for result)

Which network did you use?
Fuse
Supporting data

@L03TJ3 @patpedrosa this has been hotfixed to production, please verify it works

It seems to work, but the displayed values don't make sense compared to the transaction done

to me it looks like you didnt update to the latest wallet version, it should not show 8000000 gas.
in case it is unable to estimate the gas or transaction might fail it should show 300k gas.

@L03TJ3 redeployed try now

Yes! works


cmds: usage string based on binary name

Renaming binaries is sometimes preferrable or even necessary when
creating distribution packages. In order to reduce confusion for the
users, it's nice when the built in help text of the applications refers
to the actually used name of the binary.
By adapting the Use string, cobra also generates correct completion
scripts when using a changed name for the binary.

This change is

/rebase


Rails 5 Deprecation: alias_method_chain

alias_method_chain has been deprecated.
As far as I can tell it is only used in one place and should be easily replaceable.

Indeed, feel free to submit a PR ;)

done :)

Thanks!


editor.selectionHighlight set to false not respected in .scss files

VSCode Version: Version 1.10.2 (1.10.2)
OS Version: Mac OS 10.12.3

Steps to Reproduce:

Set editor.selectionHighlight to false
Confirm setting in HTML document
Create and .scss document
With multiple lines containing same word/selector etc., place cursor inside one iteration. Others highlight.

I have editor.selectionHighlight set to false, and in a PHP file it seems to be off. However, in a .scss document, putting my cursor in a selector will highlight all other similar selectors. See attached.

What you see is the highlight from the document symbols that scss provides. It is not configurable at this time. The request for this is #5351.


[Complete/Needs Review] updating in_shp parameter in spaghetti.Network

initializing as per issue #68

Pull Request Test Coverage Report for Build 584

19 of 19 (100.0%)  changed or added relevant lines in 5 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 85.689%

Files with Coverage Reduction
New Missed Lines
%

spaghetti/network.py
2
89.38%

Totals

Change from base Build 575:
0.0%

Covered Lines:
970

Relevant Lines:
1132

💛  - Coveralls

This is fine to change, but I think it's also ok to read in_shp as "in shapes", not just a shapefile :smile:


"Buttons"

To run the majority of existing M5stack code, we need fake buttons that have the same API as the Arduino buttons but use the touch area below the screen. I'm interested to know if someone else is planning to do this, or whether I should do this and supply a PR.

Turned out to be fixed already in https://github.com/m5stack/M5Core2/pull/3