Template Details: RTL arrows inverted

Bug Description
Found by @spacedmonkey during bug bash.
Arrows are inverted in RTL.
Expected Behaviour
The next button should be be in with use template button.
Tab order should go to 'next' and then 'prev'.
Steps to Reproduce

Screenshots

Additional Context
Make sure paging order is proper too

Plugin Version:
WordPress Version:
Operating System:
Browser:

Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin, using PR #10181.

Clicked on Switch to RTL
Clicked on Stories > Explore Templates
Clicked on See details on any template
Used the < and > arrows to switch templates
a. First template displays the "< previous" arrow disabled
b. Last template displays the "next >" arrow disabled

https://user-images.githubusercontent.com/96055551/149503478-e71838a8-e779-48f9-a763-228c6ff8ff14.mp4


VM implementation

Depends on: https://github.com/libp2p/go-smart-record/pull/9
Goal
Base VM implementation. Basic implementation of Machine interface.
//cc @barath

Comments addressed. Now get Disassembles before return, and we use RecordValue instead of Record.


takes up too much RAM. Not usable on RP2. Latest version around 115MB

Seems like latest update has gone from 100MB->115MB. and thats just the coprocess. I'm not sure how much its adding via python in kodi itself. It's possible that 1GB RP2 is not your target but if so its a shame.
This is without playing anything. And using file system for downloads, even if I did.
Can't get to playing anything as the system gets too slow.
Expected Behavior

I'm not entirely sure what the expected memory size is for the average plugin. I do expect plugins to be conservative with caching. and I would have thought Golang would do better with memory than this.
Current Behavior

100MB+ RAM in golang alone.
Possible Solution

Steps to Reproduce (for bugs)

Context

Just using the plugin causing my system to run out of ram.
Your Environment

Version used: 0.0.55

Environment name and version:

kodi 18 nightly.

Operating System and version:

osmc

Link to Kodi debug log:

RPi should be using OpenELEC

There were some optimizations in the latest version, to lower memory usage. But do not expect it to not use memory. More functionality = more memory.
You can use python based plugins, they should use less memory, probably.


Use aria2c the "ultra fast" downloader if available

aria2 is the "ultra fast" downloader and it supports parallel download with Range header, resuming failed download attempts, and so on. I received a feature request for this as yyuu/pyenv#534 from @luzfcb who is living in Brazil. I think this feature could be useful for all users who suffered by unstable internet connection.

Thanks for the addition! I'll have to look into this aria2 thing. I definitely want to support resumed downloads, but I thought wget already has a feature for that. We are probably not using it, though.
Is the feature of resumed downloads going to get used with the addition of aria2c support? Won't the build process be aborted on download failed and temporary files removed immediately?

The aria2c command have retry feature (default: 5) and enabled by default. It also persists downloading content and the state in '*.aria2' file on the disk.
As you mentioned, the resuming only works if there is RUBY_BUILD_CACHE_PATH. aria2c will persists downloading content and its state in '*.aria2' file on disk.

Any updates on this?

@yyuu Sorry, our late response. I'm ok to support aria2c and merge it.
@mislav If you still have some concern, Please create another issue.

Thank you!

I'm not opposed to the change, I just wish it didn't have to change literally all occurences of curl in tests. I'd rather that it added new tests that verify that aria2c downloads also work.


lua errors

so when i spawn in acf and right click it like you would with a prop instead of a box showing up it gives me this error
[ERROR] addons/wire/lua/weapons/gmod_tool/stools/wire_debugger.lua:62: attempt to call field 'dummytrace' (a nil value)

Filter - addons/wire/lua/weapons/gmod_tool/stools/wire_debugger.lua:62
OpenEntityMenu - lua/includes/modules/properties.lua:81
3. OnScreenClick - lua/includes/modules/properties.lua:125
4. fn - lua/includes/modules/properties.lua:179
5. Run - addons/ulib/lua/ulib/shared/hook.lua:109
6. unknown - gamemodes/sandbox/gamemode/spawnmenu/contextmenu.lua:151

i need to fix it i run a gmod server but cant figure out how to fix it any help?

WireLib.dummytrace should probably be made shared.

This was my fault! I broke things again. Cause is #1565, I think I only tested in singleplayer (where many hooks aren't called clientside) and not in multiplayer. I'll fix this right now.

ok thx so much X3


cannot upgade to 0.16.0 of octant in Jenkins X plugin

I tried to upgrade to 0.16.0 of octant for the Jenkins X plugin and all requests for data fail. I see this in the log...
2020-10-06T08:50:01.874+0100	ERROR	api/content_manager.go:154	generate content	{"client-id": "7ebc357a-07a8-11eb-8f98-acde48001122", "err": "generate content: grpc client content: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (10784 vs. 0)", "content-path": "jx/repositories"}

Doesn't matter what request I try; they all think that 0 is the maximum payload.
I guess somewhere there's a way to set this to a non-zero value? Tried the octant CLI arguments to set it large and it makes no difference.
Anyone any idea how to get things to work again on 0.16?

Fixed by https://github.com/vmware-tanzu/octant/pull/1441/files
If you grab a nightly and test it out, that should verify the fix for the JX plugin.
We are cutting 0.16.1 tomorrow which will include that fix.

https://console.cloud.google.com/storage/browser/octant-nightlies

@wwitzel3 many thanks - thats awesome & super fast!


Spelling corrections only to md files

A New PR
THANK YOU - We love to get PR's and really appreciate your time and help to improve this module
Accepting a PR
Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki
https://github.com/sqlcollaborative/dbachecks/wiki
Please confirm you have 0 failing Pester Tests
[x] There are 0 failing Pester tests
Changes this PR brings
This corrects minor spelling issues on readme.md and release.md only.

Thanks for catching these Chris.

No problem, happy to help!


monaco editor.main.js failing to load in beta

I've removed the monaco files from the manifest https://github.com/Microsoft/pxt/commit/f5cc2d5affc815a3cfa17ac5e9afcf9f8d3f2987
Could you update it?

Fixed in this commit: 8e75b947d82ca1b621d511f01cda1d8d9d8a400f


Add Functions guidance regarding consistency of VNET content routing settings

Some customers have reported issues with accessing Functions content storage when they have multiple apps accessing the same Azure Files account with different values for the WEBSITE_CONTENTOVERVNET and vnetContentShareEnabled settings.
This PR adds guidance in the relevant documentation pages indicating that apps in the same plan using the same storage credentials should use the same values for these settings.

@ggailey777
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jjk2673 I've moved your commits to my PR in the private repo: https://github.com/MicrosoftDocs/azure-docs-pr/pull/280031
#please-close


Adds a MustSetenv method for tests.

Please use MustSetenv in all tests or have a good reason for not using
it.  But for manipulating environment variables, it is by far the
preferred choice. By using MustSetenv and defer you can help ensure that
your tests are hermetic.

This change is

Pull Request Test Coverage Report for Build 222

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.8%) to 48.515%

Totals

Change from base Build 203:
1.8%

Covered Lines:
147

Relevant Lines:
303

💛  - Coveralls

Conversation with Greg:
G: I like it, but osx is a bad name.
P: You are right. env? testx? It's a really handy function, and it would save lines and increase clarity in index2ip, pusher, etl, and flagx. Pretty much only useful in _test.go files.


Dashboard  Audio Out Core Node

What are the steps to reproduce?
Add the node to a flow. Select a voice to be used. Click done button.
What happens?
Depending on which voice is chosen, sometimes the choice is saved. Sometime it is not.
What do you expect to happen?
I would expect the chosen voice to be saved (and used when triggered).
Bart Butenaers gave a very good explanation of what seems to be happening in the code in the forum at https://discourse.nodered.org/t/dashboard-audio-out-voice-options/31919/5
Please tell us about your environment:

[ ] Node-RED version: 1.1.3
[ ] node-red-dashboard version: 2.23.2
[ ] Node.js version: Not sure how to determine
[ ] npm version: Not sure how to determine
[ ] Platform/OS: docker inside synology
[ ] Browser: Primarily Chrome on Windows 10, but consistently wrong across all place tried.

This should be raised against the dashboard nodes, not the core of Node-RED.
I'll transfer it over.


237/add crawler for bundesfreiwilligendienst.de

Crawler implementation for bundesfreiwilligendienst.de
Can be tested with the following commands:
$ cd etl
$ python (or python3)
>>> from data_extraction.scraper.bundesfreiwilligendienst import BundesFreiwilligendienst as scr
>>> i = scr('test')
>>> i.add_urls()
>>> i.crawl(i.urls[0], 1)
>>> i.data

Can you run it again on your end, because on my end add_urls() runs without any problems.

Can you run it again on your end, because on my end add_urls() runs without any problems.

I could not reproduce the problem either.


Whisper error text tells you the person is offline, even if it's not a real username

/whisper asdf asdf gives back asdf is not online and will not receive your message. when, in fact, asdf is not a username that's registered.
I wonder if some of the reports of "Can't whisper X" are due to this?

Closed by #255!


Upgrade to Elasticsearch 1.5.1

WHY
Current Elasticsearch version (1.0.1) in this box is too old to test the latest application.
WHAT

Upgrade to Elasticsearch 1.5.1
Drop Chef provisioning, use Docker

@koudaiii Please review this :bow:
I wrote some tests for normal Docker container. However, in fact, I haven't test yet how it goes as wercker box. We have to release this and test in the real wercker build process...

LGTM!!!! :shipit:

Failed to deploy...
Removing working directories.
Creating tar.
Package failed: Error: Command failed: tar: /var/lib/lxc/build9b3a9289-9ecf-474c-9a3a-f7223772b447: Cannot chdir: No such file or directory
tar: Error is not recoverable: exiting now

https://github.com/wercker/support/issues/22

Unfortunately, the wercker-labs/docker environment can't be inherited from. It is not the same type of container as we're using in the classic environment, this means it can't be extended in the same way.


FAILURE: Build failed with an exception

Hi, I'm trying to use the package dargon2_flutter. But when I tried to build my project it failed to build. Here's the log when i run the flutter using "flutter run -v".

@Meap316 do you have ndk installed on your device? Since dargon2_flutter uses the C library of argon2, ndk is required for the build

Thank you, the problem is fixed now.
The problem was the corrupted NDK, I deleted all folder inside my ndk folder which is located on my android SDK folder. Then I try to rebuild the app and it went smoothly.


Bump OpenTelemetry

API change check
API changes are not detected in this pull request.

The Spring compatibility tests fail with this error that does not seem related to the PR changes:
[ERROR] Failed to execute goal on project azure-messaging-eventhubs-stress: Could not resolve dependencies for project com.azure:azure-messaging-eventhubs-stress:jar:1.0.0-beta.1: Failed to collect dependencies at org.springframework.boot:spring-boot-starter:jar:2.7.18 -> org.springframework.boot:spring-boot-starter-logging:jar:2.7.18 -> org.apache.logging.log4j:log4j-to-slf4j:jar:2.17.2 -> org.slf4j:slf4j-api:jar:1.7.35: Failed to read artifact descriptor for org.slf4j:slf4j-api:jar:1.7.35: Could not transfer artifact org.slf4j:slf4j-parent:pom:1.7.35 from/to central (https://repo.maven.apache.org/maven2): /home/vsts/work/1/.m2/repository/org/slf4j/slf4j-parent/1.7.35/slf4j-parent-1.7.35.pom.part (No such file or directory) -> [Help 1]


number of problems solved on current day can also be added

Please review previous closed issues before filling out a new one! Duplicate issues will be closed without comment.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

number of problems solved on current day can also be added


feat: tokenlists resolver

In order to prepare the implementation of the resolver logic, I added everything but that.

files, some placeholder code for new resolver: tokenlists
test that basically ensures the resolver passed in the URL is the resolver being used
allow additional headers in response for better test-ability and other use cases

Next step is to write the actual resolver logic, which mainly means fetching the lists when the server boots (as agreed upon), parsing them into some helpful, usable object, so that the resolver can access that statically. It will use the same cache mechanic but the source is "localized" so to speak.
We could warmup the cache too, but I'm not convinced this would make any real difference.
Closes: https://github.com/stamp-labs/stamp/issues/24

Idea: We can maintain a static version of tokenlists.org's data within our repository. The resolver would simply read from a static JSON file to retrieve token logo URLs. This static version could be updated by a script, which can be run manually or automatically through a daily workflow. When updates are available, the workflow would open a pull request, similar to how Dependabot operates.

Shouldn't the change on cache be in another PR? I don't see how it's related to tokenlists

There should be a way to change the URL like:
https://assets.coingecko.com/coins/images/35810/thumb/enjoy_tech.jpeg?1709871790
To the large version of the image like this:
https://assets.coingecko.com/coins/images/35810/large/enjoy_tech.jpeg?1709871790

@mktcode Thank you, code looks good, I've tried the PR locally, for some reason I can't resolve image for some token that are in the tokenlists, here is what I've tried:
http://localhost:3008/token/oeth:0xe0BB0D3DE8c10976511e5030cA403dBf4c25165B?s=100
This token is available on the Optimism list with an image here (2nd position): https://static.optimism.io/optimism.tokenlist.json
Any idea what's wrong?
Also I've disabled CodeRabbit

What do you mean by missing prefix? The URLs looks the same to me

@mktcode We should add a test case with a token and network prefix, we could have network prefix with both chain id and network short name like eip155:1:0x123 and arb1:1:0x123. Token URL with network prefix should already work with others resolvers.


mopidy-iris: 3.14.2 -> 3.16.3

Motivation for this change
Upstream update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build mopidy-iris

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: mopidy-iris
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Failure on aarch64-linux (full log)
Attempted: mopidy-iris
Partial log (click to expand)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_ext)
building of '/nix/store/87v62806vy0ahlhfqn6ypn8iq1h65qzl-rustc-1.25.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/dhs5f4ayxpzx0v4jj7cq94dvk5zxhn4p-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/px6a9pslsp9fzv3d05r2f16cf4qyk3ix-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x01k2qh4dvr6d8nlcyalmxb7a73lpmhb-gst-plugins-bad-1.14.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mmjqmfwhd0bz9p9m2rfj6cjlcd8cs223-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wvy2jkil6q8xbvfcrpkigw3zvm2b7qw2-mopidy-2.1.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hc3ny9spflhnfr9jlvglkcjigza0p1ih-mopidy-local-images-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yix58kdyyv5gc86fq00jix355m6hcp0l-Mopidy-Iris-3.16.3.drv': 2 dependencies couldn't be built
error: build of '/nix/store/yix58kdyyv5gc86fq00jix355m6hcp0l-Mopidy-Iris-3.16.3.drv' failed

mopidy-iris now depends on Tornado, I've added it to build inputs along with a small patch that makes it build properly.

Thanks :-)

Success on x86_64-linux (full log)
Attempted: mopidy-iris
Partial log (click to expand)
copying path '/nix/store/6lp6sf01jcw4cm5bprzmqdxf88zb1isx-gst-python-1.14.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/2rr9y4dr7x00s8i247pnayi512qr3dmn-stoken-v0.90' from 'https://cache.nixos.org'...
copying path '/nix/store/b724ys808bzbl28ygpln1855pff0p6gk-openconnect-7.08' from 'https://cache.nixos.org'...
copying path '/nix/store/f2qxbvbry58cx7gc5fsfmkj5kw118msb-network-manager-1.10.6' from 'https://cache.nixos.org'...
copying path '/nix/store/19ymizh5aigmv3gs1rh1d2mg8z7cm532-libproxy-0.4.15' from 'https://cache.nixos.org'...
copying path '/nix/store/9k09xbngbkakb7lb0v552mla822ld9rb-glib-networking-2.56.0' from 'https://cache.nixos.org'...
copying path '/nix/store/xg1n1w5ssi36imnb265ylm792b812h8c-mopidy-2.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/yjxljp3fmyxdwqf648dyhl5l1lmp9kv3-mopidy-local-images-1.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/nahjs1k2mri8s2p8cfpas7lljb9fh3v9-Mopidy-Iris-3.16.3' from 'https://cache.nixos.org'...
/nix/store/nahjs1k2mri8s2p8cfpas7lljb9fh3v9-Mopidy-Iris-3.16.3

https://github.com/NixOS/nixpkgs/pull/39011#issuecomment-381749252
It built and worked perfectly fine for me without the dependency, what did I miss?

Hm, strange. It didn't build for me without Tornado, and upstream now lists it in setup.py: https://github.com/jaedb/Iris/blob/master/setup.py#L30


Check plugins made pre-CK

A number of plugins (files that end in .esm, .esp or .esl) has been made available by mod authors, before the official Creation Kit has been released. As of opening this issue, xEdit by @elminsterAU with support for Starfield has not been released either, which means that any mod plugins that are listed below should be considered highly experimental, if not outright suspicious.
We therefore should check these mods once the CK with Starfield support gets released (or xEdit for that matter), and assign warnings to these plugins, if we come to the conclusion that they are harmful to the users game.

[ ] Player Placed Infinite Storage

OutpostStorage.esp

[ ] Unlimited Sprint

UnlimitedSprint.esp

[ ] FasterXP

fasterxp_2.esp
fasterxp_5.esp
fasterxp_10.esp

[ ] Burden Me Not - Clutter Begone

xatmosNoClutter.esp

[ ] Craftable Ammo and Utilities

crafting.esp

[ ] Infinite Ship Storage

ShipStorage.esp

[ ] Ship Storage Multiplied

ShipCargoStorage.esp

[ ] Increased Contraband Prices - x2 x5 x10

IncreasedContrabandPrices.esp

[ ] Equipment Tier Prefixes

EquipmentTierPrefix.esp

[ ] Richer Merchants

RicherMerchants.esp

[ ] Perk Up - Easier Leveling

xatmosPerkUpChallenges.esp
xatmosPerkUpXP.esp

[ ] Weightless Resources and Other Items

Weightless.esp

[ ] Legendary Modifications

legendaries.esp

[ ] Simple Faster Walk

FastWalk.esp

[ ] Perk Up - Richer Vendors

xatmosPerkUpVendors.esp

[ ] Hide Spacesuit in Breathable Areas

HSIBA.esp

Food Buff and basic overhaul patch - Alpha

[ ] Food Buff and basic overhaul patch - Alpha

BumoutAlphaPatch.esp

[ ] Linked Companion Spacesuit

LinkedCompanionSuit.esp

[ ] Purchasable Starborn (NG Plus) Suits

PurchasableStarbornSuits.esp

[ ] Increased Crew Capacity

ICC.esp

[ ] Configurable Ammo Rarity

CAR.esp

[ ] CargoPlus

cargo2x.esp

[ ] Hailey Follower and Friends Mod It just works edition.

Hailey.esp

[ ] Samantha Lang Starfield Edition

Hailey.esp

[ ] Samantha Lang Starfield Edition

Hailey.esp

[ ]  Food Buff and basic overhaul patch - Alpha
* `BumoutAlphaPatch.esp`
  ( made with a self compiled, unfinished, version of xEdit, against my express request not to... ¯\_(ツ)_/¯ )

I have delete this from Nexus, i didn't see your warning until after you removed me from the discord. I though my patch was safe but i should probably have more faith in someone that creates tools like xEdit, i hope you'll let me come back.

Thanks for mentioning more plugins that I didn't know about before. @ElminsterAU @CansecoDev I've integrated them into the initial post, so that they are all in one place. I've also sorted the list alphabetically by their mod names, so that it's easier to go through the list.
Besides the above, I've updated the following mod names:

Perk Up - Easier Leveling has been renamed to Perk Up - Better Experience (it also includes xatmosPerkUp.esp)
Perk Up - Richer Vendors has been renamed to Perk Up - Richer Galaxy

Thanks for the update @AtillaTheBum.

I've downloaded and placed the following mod plugins in the Data folder:

List of plugins
BumoutAlphaPatch.esp
CaptLockerUnlimited.esp
CAR.esp
cargo2x.esp
crafting.esp
EquipmentTierPrefix.esp
fasterxp_10.esp
fasterxp_2.esp
fasterxp_5.esp
FastWalk.esp
Hailey.esp
HSIBA.esp
ICC.esp
IncreasedContrabandPrices.esp
legendaries.esp
LinkedCompanionSuit.esp
MoreDramaticGravJumps.esp
OutpostStorage.esp
PurchasableStarbornSuits.esp
RealisticDamageMultipliers.esm
RicherMerchants.esp
Samantha.esp
ShipCargoStorage.esp
ShipStorage.esp
StellarAscendancy.esp
UnlimitedSprint.esp
Weightless.esp
xatmosNoClutter.esp
xatmosPerkUp.esp
xatmosPerkUpChallenges.esp
xatmosPerkUpVendors.esp
xatmosPerkUpXP.esp

I'm using the GitHub Actions artifact loot_0.20.0-99-gb743ba8_starfield-win64.7z right now and LOOT displays all of these plugins upon launching LOOT. That being said, LOOT found that multiple plugins have a plugin header version that is lower than the game's minimum supported header version of 0.96.
These plugins have a plugin header version of 0.94:
cargo2x.esp
crafting.esp
EquipmentTierPrefix.esp
fasterxp_2.esp
fasterxp_5.esp
fasterxp_10.esp
ICC.esp
OutpostStorage.esp
ShipCargoStorage.esp
ShipStorage.esp
StellarAscendancy.esp
UnlimitedSprint.esp
Weightless.esp

These plugins have a plugin header version of 0.95:
Hailey.esp
Samantha.esp

In addition to the above, upon sorting the load order LOOT detects
cargo2x.esp
FastWalk.esp

as invalid and therefore ignores these plugins going forward.

Four additional mods have been added:
Hide Spacesuit Anywhere
Lewd Outfits - With Working Skin
More Immersive Landings And Takeoffs
Starborn Science ( New Game Plus Alternative )

HideSpaceSuits.esp from Hide Spacesuit Anywhere is also recognized as being invalid by LOOT.

Five additional mods have been added:
Better Outpost Generators
Show Spacesuit When Taking Environmental Damage
NPCs Take Environmental Damage
More Visualized Docking
Adhesive Vacuum Tape

Information from the mod description of Adhesive Vacuum Tape:

This was created using my own homebrew plugin generation program and checked using a custom-compiled version of SF1View and in-game testing. Given the limited scope, it shouldn't cause any issues, but these are early days.

Through https://github.com/loot/prelude/pull/69 and https://github.com/loot/starfield/pull/39 we now warn people to not use .esp and .esl plugins in Starfield. As such, I've ticked the checkboxes of the remaining mods from the initial post of this issue, which exclusively provided their mods as .esp plugins.
There are still some mods left with .esp plugins, but they also include .esm variants of their mods, so we can't tick those checkboxes just yet. It's better to look at those .esm files individually and then determine, if any additional actions are needed.
And then there are still of course all the other mods to be checked, which only uploaded their plugins as .esm masters (but still before the CK came out).

The next official version of LOOT will feature the following message for Starfield plugins:

I've checked a first batch of plugins listed in this issue, and the following mods/plugins will show the above warning:

Show list
Better Outpost Generators
BetterOutpostGenerators.esm
Configurable Ammo Rarity
ConfigurableAmmoRarity.esm
Craftable Ammo and Utilities
crafting.esm
Hide Spacesuit in Breathable Areas
HSIBA.esm
Increased Crew Capacity
IncreasedCrewCapacity.esm
Linked Companion Spacesuit
LinkedCompanionSuit.esm
MJOLNIR Mark V
MJOLNIR.esm
More Immersive Landings And Takeoffs
MoreImmersiveLandingsTakeOffs.esm
More Visualized Docking
MoreVisualizedDocking.esm
NPCs Take Environmental Damage
NPCsTakeEnvDamage.esm
Purchasable Starborn (NG Plus) Suits
PurchasableStarbornSuits.esm
Richer Merchants
Richer Merchants.esm
Show Spacesuit When Taking Environmental Damage
SSWTED.esm
Simple Faster Walk
FastWalk.esm
Simple Immersive Helmets
SimpleImmersiveHelmets.esm
Ultimate Shipyards Unlocked
USU.esm

I've ticked the checkboxes of those plugins accordingly.

The 2nd batch of mods/plugins with BlueprintShips-Starfield.esm as a master.

Show list
Adoring Fan renamed Mike Hunt
Mike Hunt.esm
All ship parts unlevelled at all vendors (ESM)
SKKShipPartsNoLevelAllVendors.esm
Another Space Adept
BetterSpaceAdept.esm
Automatic Semi Auto Receiver Damage Equality
NoMoreNerfAutoguns.esm
Badmagic - EXP Buffs
Badmagic - EXP Buffs.esm
Better Asteroid Loot
MoreAsteroidDrops.esm
Better Crowd Citizens
Better Crowd Citizens.esm
Better Serpent's Embrace
xoxBetterSerpentsEmbrace.esm
Better Trade Authority Kiosks
xoxBetterTradeKiosks.esm
Better Traits
xoxBetterTraits.esm
Build On Restricted Surfaces
BuildOnRestrictedSurfaces.esm
Coffee Has Some Kick
Coffee Has Some Kick.esm
Conner's Ordinary Conversations - Sale of Substances
COCSOS - Sale of Substances.esm
Conner's Ordinary Conversations - Seek Out Stores
COCSOS - Seek Out Stores.esm
Decorate Starborn
Decorate-Starborn.esm
Doorway placeholder
DoorwayPlaceholder.esm
Doubled Enemy Numbers
2XEnemies.esm
Drinks on the House-Fix
DrinksontheHouseFix.esm

The 3rd batch of mods/plugins with BlueprintShips-Starfield.esm as a master.

Show list
Drug Manufacturing Extended
DrugManufacturingExtended.esm
Early Game Weapons Empowered
LesserWeaponEmpowered.esm
Earth Restored
Earth Restored.esm
Earth Villa Home
Earth Villa.esm
Easy Tweak Collections(ESM)
EasyPickPocket.esm
ECS Constant kids named and remodeled
ECS_Consistency.esm
Einstein Genetics - NEW Trait
Inquisitor_Starfield_Mods_Einstein Genetics.esm
Engines Reactors and Gravdrives
Engines.esm
Gravdrives.esm
Reactors.esm
Explorer Spacesuit Replacer - Starborn (esm version)
Explorer Replacer - Avitus.esm
EZ's Crime Pays a Pirate's Life
EZ_CrimePays_PirateLife.esm
EZ's Discount and Commerce Mod
EZ_Discount_Commerce.esm
Flight Camera - larger FOV and more responsive ship camera
FlightCamera.esm
FMR - Fire Mode Rebalance
Fire_Mode_Rebalance.esm
Following Asteroids Fix - Stalking Objects Solution
Following Asteroid Fix.esm
Further Looting - Loot up to 5000m away
FurtherLooting.esm
Game Tweaks
GameTweaks-Misc.esm
GameTweaks-Traits.esm
GameTweaks-Vendors.esm
GameTweaks-XP.esm
Gunsling Boostpack Standalone
GunSlingBoostPack.esm
Helpful Activity Objectives
Helpful Activity Objectives.esm
Hugin's KOTOR Neo Crusader
NeoCrusader-CrimsonReplacer.esm

The final batch of mods/plugins with BlueprintShips-Starfield.esm as a master.

Show list
Larger Captain's Lockers
Larger Captain's Lockers.esm
Legendary Legendaries
LegendaryLegendaries.esm
_vTZvCore.esm
Lexingtons Turret Targetting Radius
Lexingtons_TurretTargetingRadius.esm
Lively's Enhanced Skills
Livelys Enhanced Skills.esm
Lively's Leveled Mannequins Bug Fix
LivelyMannequinFix.esm
M Class Ships and Ship Builder unrestricted
MClassShips.esm
More Ownable Starships - Higher Starship Limit
MoreShips.esm
More Wanted Encounters
xoxMoreWantedEncounters15.esm
Neuralink
Neuralink.esm
NEW Background - Space Assassin
Inquisitor_Starfield_Mods_Space_Assasin.esm
NEW Commercialist Trait
Inquisitor_Starfield_Mods_Commercialist_Trait.esm
NEW Traits NEW Backgrounds - By Inquisitor
Inquisitor_Starfield_Mods_New_Backgrounds&Traits.esm
No Empty Star System
Planets.esm
No Contraband Scans
No Contraband Scans.esm
No Lung Damage While Wearing Space Suit
SuitProtectsAgainstLungDamage.esm
No Self Heal Effect (fog begone)
NoSelfHealEffect.esm
No Weapon Mod Research
No Weapon Mod Research.esm
Outpost Redux - various outpost tweaks to make outposts useable
OutpostTweaks.esm
Outpost Shipyard-Wholesale
Outpost-Shipyard-Wholesale-Atlantis.esm
Outpost-Shipyard-Wholesale-Cydonia.esm
Outpost-Shipyard-Wholesale-Neon.esm
Resurrect Humans (xEdit)
Reanimation.esm
Seeking out Stores - Navigate Using City Info Kiosks
Navigate Using City Terminals.esm
Ship Command Perk Redux - have effectively unlimited crew assignments
ShipCommandRedux.esm
Space Farer - NEW Trait
Inquisitor_Starfield_Mods_SpaceFarer.esm
Space Hauler - NEW Trait
Inquisitor_Starfield_Mods_Space_Hauler.esm
Spacestations for Outposts
StarstationTest.esm
Freedom of Storage
UniversalContainer.esm
Starfield Extended - Craftable Color Swaps
Starfield Extended - Craftable Color Swaps.esm
Starfield Extended - More Engines Rebalanced
Starfield Extended - More Engines Rebalanced.esm
Starfield Extended - New Outfits
Starfield Extended - New Outfits.esm
Starfield Extended - Plainclothes Rangers
Starfield Extended - Plainclothes Rangers.esm
Starfield Extended - Rolling Deep (Ship Command Rebalance)
Starfield Extended - Rolling Deep.esm
Summoning of Ship - Ship Remote Control - Land - Take off - Set gravity
Ship Remote Control.esm
Survivability
SML_Survivability.esm
Take More Traits - ESM version
TakeMoreTraits.esm
TN's Expanded Cargo Holds
TNExpandedCargoHolds.esm
TN's Modular Starborn Suits
TNModularStarbornSuits.esm
TN's Supplemental Cockpits
TNSupplementalCockpits.esm
TN's Supplemental Reactors
TNSupplementalReactors.esm
TN's Weapon To Module Snapping
TNWeaponToModuleSnapping.esm
Tougher Enemies
Tougher Enemies.esm
Ultimate Ship Boosting - Nearly unlimited ship boost
UltimateShipBoost.esm
Weight Lifting Plus (Experimental)
WeightLiftingPlus.esm


2.1.3 is a breaking change on android

🏗 Enhancement Proposal
When a breaking change is done please make a bigger change to the version.
The upgrade to androidX breaks builds with the old android support library.
Pitch
If 2.1.3 was 3.0.0 my gradle build would not have failed and alot of gradle version hell could have been avoided.
Platforms affected (mark all that apply)

[ ] :iphone: iOS
[X] :robot: Android

And by the way: Thank you for a nice plugin.

@Henge9, thank you very much for the feedback. You are absolutely right, I completely missed it and will keep it in mind for future updates (version 2.2.0 is coming today with a new feature).

Thank you for the fast reply. Not even google managed to do it correctly as the link below shows.
https://github.com/flutter/flutter/wiki/Postmortem:-AndroidX-plugin-migration


Publication page - feedback from testing

[ ] Export button does not work - deprioritised as needs back end work
[ ] Add filter for status
[ ] Add filter for submitter
[x] Submitter sort does not work but can be removed if filter for submitter is added
[ ] Sorting sometimes doesn't work after expanding the number of rows to 50
[ ] Sort by First author should be on surname not first intial
[x] Sort by Title does not work but also is not required, so can be removed.
[ ] Curators would prefer to have an explicit "save" action after changing curator and status

Main feedback doc is here: https://docs.google.com/document/d/1hlihpeERA0beyRoMJT5OvzIHWaJNRGjamxCdOvTSUy4/edit

Crate a ticket for optimizing codebase of backend search filter @ala-ebi


Unnecessary empty values in yaml

In the queried values; lots are empty and should be ignored. Is there a simple way to ignore them in the serialization?
E.g.
"fieldsV1": {
            "f:count": {},
            "f:firstTimestamp": {},
            "f:involvedObject": {
              "f:apiVersion": {},
              "f:kind": {},
              "f:name": {},
              "f:namespace": {},
              "f:resourceVersion": {},
              "f:uid": {}
            },
            "f:lastTimestamp": {},
            "f:message": {},
            "f:reason": {},
            "f:source": {
              "f:component": {}

They all stem from the managedFields field; trying to understand that and see if we can chunk it out. Kubectl doesnt return all that when doing -o json so thats my first lead

I'm seeing some code in k8s that do things like just explicitly remove it when it doesnt matter:
https://github.com/kubernetes/kubernetes/blame/176c07dfddbd20994a438a0ce35a68766990cd81/pkg/apis/core/v1/defaults_test.go#L328
In addition, the comment on the field itself says that users do not need to even understand that field or know what it is. For the purposes of sonobuoy and debugging then it is meaningless IMO.
I'm going to put up a PR to remove the field (not that hard) and see how it looks. We can always easily gate that behavior for the 1% who may want to see that field.


Refine PDS Web Modernization working group plan

Develop detailed plan for new PDS Web Modernization working group activities, milestones, and deliverables

https://app.zenhub.com/files/267908922/3a2ed65f-79c3-4ca5-8e34-bf897216ddfd/download

@edwardbarraza provided the task schedule.
He's now going to work on the organization of the Working group by looking at how the Blink / Nasa web activity.

https://docs.google.com/document/d/1I3lrWRkA8xBPWLcBI4cNVdifLSibAS1hLPAkrxlZHQY/edit#heading=h.34jn563gr1vv

initial plans complete


Feature request: #[ts(bound)] attribute

Is your feature request related to a problem? Please describe.
#264 introduces the #[ts(concrete)] attribute, but it can generate unnecessary bounds on the type parameter when it's used "directly" in a type:
use ts_rs::TS;

trait Driver {
    type Info: TS;
}

struct TsDriver;

#[derive(TS)]
struct TsInfo;

impl Driver for TsDriver {
    type Info = TsInfo;
}

#[derive(TS)]
#[ts(export, concrete(D = TsDriver))]
struct Inner<D: Driver> {
    info: D::Info,
}

#[derive(TS)]
#[ts(export, concrete(D = TsDriver))]
struct Outer<D: Driver> {
    inner: Inner<D>,
}

error[E0277]: the trait bound `TsDriver: ts_rs::TS` is not satisfied
   --> src/lib.rs:22:10
    |
22  | #[derive(TS)]
    |          ^^ the trait `ts_rs::TS` is not implemented for `TsDriver`
    |
    = help: the following other types implement trait `ts_rs::TS`:
              bool
              char
              isize
              i8
              i16
              i32
              i64
              i128
            and 66 others
note: required for `Outer<TsDriver>` to implement `ts_rs::TS`
   --> src/lib.rs:22:10
    |
22  | #[derive(TS)]
    |          ^^ unsatisfied trait bound introduced in this `derive` macro
note: required by a bound in `ts_rs::TS::WithoutGenerics`
   --> /Users/wilson/.cargo/git/checkouts/ts-rs-092fe627e6f08b9c/95e6dac/ts-rs/src/lib.rs:332:27
    |
332 |     type WithoutGenerics: TS + ?Sized;
    |                           ^^ required by this bound in `TS::WithoutGenerics`
    = note: this error originates in the derive macro `TS` (in Nightly builds, run with -Z macro-backtrace for more info)

ts-rs thinks that a value of type D is used in Outer because it's passed as a parameter to Inner, when in reality Inner only uses D::Info. The generated code looks like this:
impl<D: Driver> ts_rs::TS for Outer<D>
where
    D: ts_rs::TS, // <- unnecessary bound
{
    ...
}

Describe the solution you'd like
Add a #[ts(bound)] attribute to let people specify the bounds on the TS impl manually:
#[derive(TS)]
#[ts(export, concrete(D = TsDriver), bound = "D::Info: TS")]
struct Outer<D: Driver> {
    inner: Inner<D>,
}

Which would replace the auto-generated bounds with the provided string:
impl<D: Driver> ts_rs::TS for Outer<D>
where D::Info: TS,
{
    ...
}

Describe alternatives you've considered
See #261 and #264.

@NyxCode You're right, I meant to write this:
impl ts_rs::TS for Outer<TsDriver>
where /* no bounds */
{
    ...
}

...because D is substituted for TsDriver with #[ts(concrete(D = TsDriver), bound = "/* no bounds */"]. You're right that without concrete, the bound would be needed. I might be missing something though.

Ah, alright, now I see where the confusion came from.
So the original concrete branch started out with impl<D: Driver> TS for MyStruct<D>.
That worked, but required this annoying type Info: TS bound in the definition of Driver.
Then, we tried actually generating impl TS for MyStruct<TsDriver>. However, we hit a hard wall going down that road. If you're interested in the details, see #264. The gist of it is that we generated <TsDriver::Info as TS>::name() inside the impl, which the trait solver refuses to accept. We'd have to generate <<TsDriver as Driver>::Info as TS>::name() instead, but that's not possible inside the proc macro (as soon as there's more than one trait bound on D).
Therefore, we settled on generating impl<D: Driver> TS for MyStruct<D> where D::Info: TS. That gives us all the benifits we'd have gotten with the other approach (namely, get rid of the type Info: TS bound).
Everything works like it was an impl TS for MyStruct<TsDriver>. However, MyStruct<OtherDriver> still implements TS if OtherDriver::Info: TS. If you'd call MyStruct<OtherDriver>::decl() though, it'll behave as-if it was an MyStruct<TsDriver>.

Absolutely, that'd have worked! With the codegen as-is, which does <{field_type} as TS>::name(), that'd have generated <<D as Driver>::Info as TS>::name() - exactly what we tried to do "by hand".
We didn't see any downside with generating impl<D: Driver> TS for MyStruct<D> where D::Info, and it doesn't require that you touch the type definition at all.

Well, there is one downside, which is that you don't get a compiler error if you do MyStruct::<OtherDriver>::export() if it's #[ts(concrete(D = TsDriver))]. Instead, you just get the definition of MyStruct<TsDriver> according to the #[ts(concrete(..)].
Since (we hope) most users just use #[ts(export)], this seemed like a minor issue.

@NyxCode Got it! I just tested the latest changes on main, but I'm still getting the extra bound when I #[derive(TS)] on Outer:
use ts_rs::TS;

trait Driver {
    type Info: TS;
}

struct MyDriver;

#[derive(TS)]
struct MyInfo;

impl Driver for MyDriver {
    type Info = MyInfo;
}

#[derive(TS)]
#[ts(export, concrete(D = MyDriver))]
struct Inner<D: Driver> {
    info: D::Info,
}

#[derive(TS)]
#[ts(export, concrete(D = MyDriver))]
struct Outer<D: Driver> {
    inner: Inner<D>,
}

  impl<D: Driver> ::ts_rs::TS for Outer<D>
  where
+     D: ::ts_rs::TS,
  {
      ...
  }

Basically, the current implementation requires MyDriver itself implements TS, not just its associated types, since it sees that D is used "directly" in Outer — the goal with #[ts(bound = "")] is to remove this bound (since it's not actually necessary that D itself implements TS, only its associated types).

Yup, we're on the same page here!
The tradeoff between the two solutions of generating trait bounds we explored turned out to be:

Generate perfect bounds, but fail on self-referential types
Overestimate bounds, but allow self-referential types

So you're absolutely right here - The generated bound D: TS is wrong, and it needs to be D::Info: TS instead.
And I agree, #[ts(bound = "...")] seems perfect for that.

OK great! I am putting together a bound attribute now and will open a PR soon.

I just implemented the attribute here: https://github.com/Aleph-Alpha/ts-rs/compare/main...WilsonGramer:ts-rs:bound-attribute
Let me know what you think!


Add AWS Foundational Security Best Practices Elasticsearch benchmark

Is your feature request related to a problem? Please describe.
I'd like to be able to run the Elasticsearch (ES) benchmark for the AWS Foundational Security Best Practices framework.
Describe the solution you'd like
Implement ES benchmark.
Describe alternatives you've considered
N/A
Additional context
Add any other context or screenshots about the feature request here.

PR merged: https://github.com/turbot/steampipe-mod-aws-compliance/pull/31

This benchmark is not in main yet, re-opening until it's merged back into main.


BUG: Don't use calendar from daily bars in USEquityPricingLoader

This calendar only has up to the last trading day, use default_nyse_schedule instead.

Coverage decreased (-0.05%) to 82.929% when pulling 22638f1a9289533c6bbd6e56d021df97bb664cb4 on fix-pipeline-calendar into 43f4c3a2d32f19c41595eb55385f05592b992469 on master.

Coverage decreased (-0.05%) to 82.929% when pulling 5ac66aa19e892a0e532044664460aa7d1538d063 on fix-pipeline-calendar into 43f4c3a2d32f19c41595eb55385f05592b992469 on master.

Coverage decreased (-0.05%) to 82.929% when pulling 5ac66aa19e892a0e532044664460aa7d1538d063 on fix-pipeline-calendar into 43f4c3a2d32f19c41595eb55385f05592b992469 on master.

Coverage decreased (-0.05%) to 82.929% when pulling 5ac66aa19e892a0e532044664460aa7d1538d063 on fix-pipeline-calendar into 43f4c3a2d32f19c41595eb55385f05592b992469 on master.


APP mode hanging - incomplete data chunks?

Hello, I have a bit of an issue where once booted into APP mode and connected to the Spark, the display shows HW 1 and the preset switches become unresponsive. The serial is repeatedly printing the below, any idea what could be causing this?
Getting current preset from Spark
Sending block:
01FE000053FE3C000000000000000000F0010101020100010000000000000000000000000000000000000000000000000000000000000000000000F7
Done with this command!
 It might be related to a recent change in the code to support the Spark GO. I will need to look into it in the next days when Infond some time.
In the meantime you could try to check out an earlier version of the main branch, e.g., commit 9a1849e444f5a26598279f65e57f3f6877c9b53f.

@Rorzaborg  I have now applied a fix which should make operations with the Spark 40 more stable. Spark GO is still a different challenge as it does not send messages as reliable and in the standard format as the 40 does. Please try to check out the current main branch and rebuild.

@stangreg Champion! The issue is completely resolved.


You can get items out

You can get items out if you shiftclick on them and then quickly press escape, and then if you go into your inventory then you can chuck it out and then its a valid item.

All it's doing is creating phantom items, they're not real.


[[Bug Report]] TypeError with libWrapper

Noticed a new error has sprung up and prevents tokens from moving once it happens (which is usually when a token is clicked and dragged).

The bug should be fixed with v3.0.5


[cli] Add #[serde(skip_serializing)] and #[serde(skip_deserializing)] to hidden collumns

Motivation

Since we don't generate entity for hidden table (which has name starts with underscore) by default so it'd be good to add #[serde(skip_serializing)] and #[serde(skip_deserializing)] to hidden columns, too.
Proposed Solutions

N/A
Additional Information

N/A

Hey @HigherOrderLogic, thanks for proposing this on Discord!
I'll open this for contributions! I second this as long as it's opt-in, i.e. feature is disabled by default and can be choose to enabled by will.

You don't need to add both, adding #[serde(skip)] does the same.


Linking data from one mobie project s3 to another requires redundant xml file

I was linking one MoBIE project (currently still local) to the Platynereis raw data.
In the dataset json:
  "sources": {
    "sbem-6dpf-1-whole-raw": {
      "image": {
        "imageData": {
          "bdv.n5.s3": {
            "relativePath": "images/bdv-n5-s3/sbem-6dpf-1-whole-raw.xml"
          }
        }
      }
    },
    ...

And this I put into the xml:
    <ImageLoader format="bdv.n5.s3">
      <Key>rawdata/sbem-6dpf-1-whole-raw.n5</Key>
      <ServiceEndpoint>https://s3.embl.de</ServiceEndpoint>
      <BucketName>platybrowser</BucketName>
      <SigningRegion>us-west-2</SigningRegion>
    </ImageLoader>

The above works, however it would be nice to avoid the xml and directly be able to put this into the dataset.json, e.g. like so:
    "sbem-6dpf-1-whole-raw": {
      "image": {
        "imageData": {
          "bdv.n5.s3": {
            "absolutePath": "https://s3.embl.de/platybrowser/rawdata/sbem-6dpf-1-whole-raw.xml"
          }
        }
      }
    }

This is a similar issue: https://github.com/mobie/mobie-viewer-fiji/issues/1048


[BUG] I have given the album read/write permission on iOS 13.x and still cannot access the album

Describe the bug
When using on iOS 13.x devices, images cannot be selected.
How to reproduce
PermissionState result = await PhotoManager.requestPermissionExtend();

if (result.isAuth || (Platform.isIOS && result == PermissionState.limited)) {
    List<AssetEntity>? result = await AssetPicker.pickAssets(
      context,
    );
}

Steps to reproduce the behavior:

You need to prepare an iOS 13.4.1 device, (and users have reported problems with 13.6 devices)
Just execute the above simple code.

Expected behavior
Works fine like other iOS versions。
Screenshots (If contains)
https://user-images.githubusercontent.com/8766034/189784596-e5bf2c41-e921-47ef-9297-332f8b2fab7b.mov
Version information

Device: iPhone SE 2
OS: iOS 13.4.1
Package Version: 8.0.2
Flutter Version: 3.3.1

Additional context
Previously using version 7.3.2 it worked fine on all iOS devices. Later, because I upgraded the Flutter version, I just saw a new version of wechat_assets_picker, so I also upgraded.

When will this issue be fixed?

I have the same issue on iOS13+ including iOS16. When a user gives permission to access only one album then album.getAssetListPaged returns empty list.

我遇到相同的问题,在iOS13.3.1版本的手机上.
他在iOS14 15 16上都是好的
但是iOS13,3,1默认会选择延时摄影并且无法切换相册


chore: amam ignore environment file to ensure keys are not committed

All of FE repositories are public, and during testing, .env files are prone to be pushed or committed accidentally and leak some credentials to the public
Add/update .gitignore files with the following

.env
.env.*
*.env

this will cover most of the use cases to not accidentally add credentials to the commit repository

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.586%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
5641

Relevant Lines:
6131

💛  - Coveralls


Update design for "how government works"

What
https://trello.com/c/vgUN7cPF/631-update-how-government-works-template

Page needs to be updated to use modern layout classes

Why

Consistent look with other pages
Use design system styles and component guide components
Fix document outline issues

Visual changes

Before
After

I think this is looking ok now - if you can kill the temporary commit and rebase against master I'll re-review.

I think this is looking ok now - if you can kill the temporary commit and rebase against master I'll re-review.

Sorry one final unexpected thing following the rebase is that one of the tests failed.
expected not to find visible css ".feature-ministers", found 1 match: "0   Ministerial departments\n0   Non-ministerial departments\n300+   Agencies other public bodies" (RSpec::Expectations::ExpectationNotMetError)
./features/step_definitions/sitewide_settings_steps.rb:24:in `/^I should not see the minister counts$/'
./features/support/admin_taxonomy_helper.rb:31:in `block in <top (required)>'
features/sitewide_settings.feature:6:in `I should not see the minister counts'

This is because I deleted the .featured-ministers selector (it's no longer used for any style purpose but is used by the test). I've now added this back in to the reshuffle / ministers section which has fixed the issue... but just wanted to mention it.


workflow retry 'parent_task.child_task'

https://github.com/StackStorm/st2/blob/d61b563c418f0f82f339a67053df421c8bbbc6c1/st2common/st2common/services/workflows.py#L505
1.tasks =  split task on dot
2. find tasks[0] task in workflow
3. if tasks[1] exists then set this task as running and recurse back into this function using tasks[1] and workflow from tasks[0] if it is a workflow

@guzzijones Is it possible to adjust the issue to be less cryptic in front of StackStorm Community?
Please provide clear title, describe what's the problem is and more details in the Issue description.

Closing due to no response or details provided.


Automatically fork into multiple processes when running in --slave mode

I've implemented this in the "forking" branch. Seems to work fine under UNIX, but needs to be tested on Windows.

Did this ever go anywhere? Have run into an issue where my slaves are CPU bound and wondering if it's possible to get locust to fork itself rather then getting my orchestration stuff to run multiple slaves on each host...

+1

Was this implemented, or is this a WONTFIX?

Even though I implemented a proof of concept, I would say that it's a WONTFIX, in the spirit of keeping the codebase simple. I believe the costs of maintaining that feature would be too high compared to the gains.


Fix dead links

Debian has decomissioned alioth, replacing it by salsa.debian.org, a gitlab instance. As a result, all the CCID and PC/SC-Lite URLs are now dead.
Replace them by their apdu.fr counterparts (or the git repository in one case).

ping. Is this waiting for something from me? If so, please tell me what. If not, just ignore ;-)

yoe - please see my comment above about README.rst.

oh, sorry, missed that -- this should be better.

Thanks!


Rename trainer._launch to trainer._run

What does this PR do?
launch might be associated w/ distributed launch or process launch which isn't the case here
cc @carmocca
Fixes https://github.com/PyTorchLightning/pytorch-lightning/pull/7232#discussion_r622322393
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

@Borda @tchaton mind taking a look?


Calling SDK streaming support

In this section there's the following limitation is listed:

Maximum # of incoming remote streams that can be rendered simultaneously

With 4 videos + 1 screen sharing for Web, and 6 videos + 1 screen sharing for Windows/Android/iOS, along the following footnote:

While the Calling SDK won't enforce these limits, your users may experience performance degradation if they're exceeded.

Testing with the tutorial app from https://github.com/Azure-Samples/communication-services-web-calling-tutorial, I've experienced a cap of maximum 6 active incoming video streams from remote participants. The sample app uses 1.4.1-beta.1 of the @azure/communication-calling SDK, but I've experienced the same thing in our own in-house application built on v1.3.2.
It would appear that these limits are now somehow enforced. Whether it be in the SDK or in Azure is unknown, but it would make sense if the docs could elaborate on this. Additionally it seems 4+1 isn't accurate for Web as listed.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8b46d15-96f3-5d40-d9a8-fac16521c953
Version Independent ID: 6e0f2a01-e407-b005-bd72-4d689380806b
Content: Azure Communication Services Calling SDK overview - An Azure Communication Services concept document
Content Source: articles/communication-services/concepts/voice-video-calling/calling-sdk-features.md
Service: azure-communication-services
Sub-service: calling
GitHub Login: @ProbablePrime
Microsoft Alias: rifox

@garchiro7
Can you please check and add your comments on this doc update request as applicable.

@AjayBathini-MSFT: @akania will review this

Hi, we've updated documentation with following
| **Maximum # of incoming remote streams that can be rendered simultaneously** | 9 videos + 1 screen sharing on desktop browsers*, 4 videos + 1 screen sharing on web mobile browsers | 9 videos + 1 screen sharing |

\* Starting from ACS Web Calling SDK version [1.16.3](https://github.com/Azure/Communication/blob/master/releasenotes/acs-javascript-calling-library-release-notes.md#1163-stable-2023-08-24)

Web supports rendering 9 videos  + 1 screen share on desktop and 4+1 on mobile web
A "support" means that this is the maximum number of streams that platform can render with proper quality in place, actual hard limits are slightly higher to allow for seamless switching from one renderer to another without a significant delay but that doesn't change the 9+1/4+1 of renderers that app should maintain
let me know if that helps, i'll resolve this issue, documentation will be merged and available publicly this week,
if there are other questions or issues please reopen it

#please-close


fix: --p2p-secret-key silently reverts to default location if file is not found (#2498)

Resolves #2498

Codecov Report

Merging #2508 (cc1f240) into main (6a55f70) will decrease coverage by 53.69%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2508       +/-   ##
===========================================
- Coverage   71.68%   18.00%   -53.69%
===========================================
  Files         489      489
  Lines       61020    61042       +22
===========================================
- Hits        43744    10992    -32752
- Misses      17276    50050    +32774

Flag
Coverage Δ

integration-tests
18.00% <0.00%> (+<0.01%)
:arrow_up:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bin/reth/src/args/secret_key.rs
0.00% <0.00%> (ø)

bin/reth/src/node/mod.rs
0.00% <0.00%> (-11.43%)
:arrow_down:

... and 338 files with indirect coverage changes

Not sure if we want to make changes to other places that use secret_key.rs?
src/stage/mod.rs
src/p2p/mod.rs

would like to see some tests for this, unclear how this fixes it because it looks like the function still behaves exactly as before.

I believe the reported issue is OBE now.
A new issue needs to be created addressing that the p2p-secret-key flag is no longer respected.
And then this fix should apply for that issue.


UI for pagination

Infinite scrolling is great but it was few drawback as well. For slow connection you want to load fewer items per page, and sometime you accidentally scroll down and app triggered the call to load more items. Loader cover the whole screen, impossible to do anything until the more items are not loaded and rendered. How about this is ? let user decide the app behaviour! just mockup, we can have better messaging. @sabeurthabti @mmahalwy @ahmedre

i like Apple's approach of "pick the right ui behavior for the user and provide as few options as possible" - i think auto load on scroll is good, but we can be much more restrictive about it. on mobile, we have something that gives us an estimate of how good or bad the connection is - is there something similar for web that we can use and then we can limit or gate accordingly?

I would like auto scroll still there, but just remove that big loading circle that covers the entire page. It's very very annoying.

@AskYous
Agreed!
It breaks the reading flow unnecessarily. The loader should be set back to the bottom as per PR #750
+1 Ahmed

Agreed. I don't like the loading on the whole page.

Going to close this. Seems like no progress. Feel free to reopen


Module Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.

I've added the the package as documented. When I add the module to my module's import, I get the following error.
node_modules/@asymmetrik/ngx-leaflet-markercluster/dist/leaflet-markercluster/leaflet-markercluster.module.d.ts:2:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.

This likely means that the library (@asymmetrik/ngx-leaflet-markercluster) which declares LeafletMarkerClusterModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

2 export declare class LeafletMarkerClusterModule {

Here's the output of my ng v
Angular CLI: 9.0.4
Node: 12.14.0
OS: win32 x64

Angular: 9.0.4
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.4
@angular-devkit/build-angular     0.900.4
@angular-devkit/build-optimizer   0.900.4
@angular-devkit/build-webpack     0.900.4
@angular-devkit/core              9.0.4
@angular-devkit/schematics        9.0.4
@angular/cdk                      9.1.2
@angular/fire                     6.0.0
@angular/google-maps              9.1.0
@ngtools/webpack                  9.0.4
@schematics/angular               9.0.4
@schematics/update                0.900.4
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Thanks

You may want to try the newer versions of the library that are ng9 and ng10 compatible. This issue was introduced when they upgraded to ng9 if libraries were not published with ivy disabled.


Prompt to re-read file after SudaWrite

This can be done by simply calling :checktime after SudaWrite.
I don't know if we should add this call elsewhere, because I only use this one command. So I created an issue instead of a pull request.

I'm sorry for late reply and I didn't know checktime. It seems quite useful thanks 👍

this was fixed by #59 and can now be closed 😃


Update projects list and enable TSC to create workgroups

Per our discussion last week, some updates to the readme that enable the TSC to create anticipatory workgroups by majority vote instead of waiting for a graduated project.
Also, this adds links to the Sandbox projects.
Finally, this enumerates some of the collaboration tools that projects can expect when they join.
Signed-off-by: Brian Warner<EMAIL_ADDRESS>

Fast track and two approvals, I'm going to land this.


docs(v2): clarify that front matter 'description' is used as a meta tag

Also re-arranges the order the example so it matches the list with variables above it

Changed as requested, rebased as well.


Syntax Highlighting

Hello,
First of all, thanks for the library. It's exactly what I was looking for!
However, I miss syntax highlighting on code blocks. Is there any way of doing it?

I think we can integrate this Rust crate to add this functionality https://crates.io/crates/highlight-pulldown. Will take a look when I have free time.

I think we can integrate this Rust crate to add this functionality crates.io/crates/highlight-pulldown. Will take a look when I have free time.

Ok, it will be more difficult than I thought, as this crate depends on old pulldown-cmark version. I think I'll fork it in future.


dewdropper, fleurettee

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,f]

/trunk merge


Ensure SessionContext isn't modified when iterating over it

When routing debugging is enabled, Zuul will record changes in the session context after each filter is run.  If the context already has a "routingDebug" property on it, all will be fine.  If not, the comparison code will (as a side effect) add that property.  However, it's added while there is an active iterator over the context.  Once the code tries to fetch the next element from the iterator, a
ConcurrentModificationException is thrown.
This fix is simple, though the ideal fix would probably be to refactor the code to be safer.

Added a test as well.  Note that if you comment out the fix for the bug, that test fails.

Added a test as well.  Note that if you comment out the fix for the bug, that test fails.

@kelnos merged, thanks!


DOC: ndimage convolve origin documentation (#14745)

gh-14745
Reference issue

What does this implement/fix?
Fixes incorrect assignment of left and right in current documentation.
Additional information

Thanks @alexandschaefer. This fixes the obvious bug in the description. Did you consider adopting the proposed more extensive description from gh-14745? The ascii visualization used there seems nice. It'll render fine in html if you use reST markup like this I expect (double colon plus blank lines around the content to be typeset):
    Visualizations with an input of length 5 and a filter of length 3::

         origin of 0     origin of -1     origin of 1
         -----           -----            -----
        ---            ---                ---

Hi @rgommers. I do not like visualization: I do not think it is very obvious what input and output is (to someone who needs to read it). Also it seems that the output is shifted by ~3 whitespaces.

Okay, thanks for considering it. In it goes then.


How to use a custom partitioner ?

Hello all,
Thank you for your work.
I need to use a partitioner but I couldn't find any way to set it.
In the advanced producer sample, there is a comment line 42 where @mhowlett use an older way to create a partitioner (with TopicConfig class) but it doesn't exist anymore ?
Thank you very much

unfortunately this is not implemented yet @mgrail. it's commonly requested, but I don't have a timeframe yet. do you want this so you can provide a murmur2 partitioner compatible with the java client? or a custom strategy?

Hi,
It was only to round robin on all partitions based on a message key (int).
I'll use ProduceAsync to give a partition instead.
Thank you

We're looking to provide the builtin partitioners as a simple configuration property in a future release.

Hi @mhowlett \ @edenhill ,
I have run into an issue which seems to be related to this.
We are using confluent-kafka-dotnet 0.9.5. The topic has 50 partitions but when I produce a message with the key as NULL, all the messages are going into the same partition.
I looked at Apache's documentation for Kafka and it seems that  org.apache.kafka.clients.producer.Partitioner is used to set the Random or Default partitioner. But I am not able to find anything related to that in confluent-kafka-dotnet.
Can you please help me with this as to how I could set up Random or Round Robin partitioning here?
Thanks.

Can you post a snippet of your producer code? You should use a null key and not use the Produce overrides which take partition.
By default, a consistent random partitioner is used (you may find more about this in librdkafka - basically, it's juste a random between 0 and partitionCount)
Also be sure your topic has more than one insync partition

Hello @treziac,
I am not using any overrides for the partitioner. Still here's the code:
var Config = new Dictionary<string, object> {
    { "group.id", "topic1_group" },
    { "bootstrap.servers", "localhost:9092" },
    { "default.topic.config",new Dictionary<string, object> {
                               { "acks", 1}
                            }
    }
};

var producer = new Producer<string, string>(Config, new StringSerializer(Encoding.UTF8), new StringSerializer(Encoding.UTF8));
var producerResult = producer.ProduceAsync("topic1", null, "Message1");

Thanks for helping.

I'd love to know when this work is scheduled for - we are evaluating this as a possible production client, but obviously cannot mix this with the Java client when the partitioning is different.  Are you looking for any help on it?  I did not see that you are when looking in the 'help wanted' section...

I notice that librdkafka recently added a murmur2 partitioner (same as java) https://github.com/edenhill/librdkafka/pull/1468
it should be possible to make use of this via dotnet but it would require modifications to the dotnet library. i was hoping this functionality would be made available via a new librdkafka config property (which would make it available in the language bindings without any modification). any plans for this @edenhill ?

Yes, the plan is to initially expose the builtin partitioners as string config properties.
Going forward we might want to make it possible to register new custom partitioners with the configuration interface so they too can be configured this way.

@mhowlett We've been getting along fine without this, but would like to switch using this, once available.  Any update?

iirc this made it in the 0.11.4 release, but there was a bug (didn't completely match java). there is now a fix for that in librdkfaka master and the next release (0.11.5 and 1.0 pre-release) will have a partitioner exactly matching the default java one. I think the timeline for that is about a month.
Also, custom partitioners are likely to make it into the 1.0-experimental branch soon.

that's good to know - is there a roadmap or some such other that shows when 0.11.5 will be available in nuget?

We have already worked around this, for what's it worth, but yes - all we're currently interested in is a partitioner that matches the default java murmur2 partitioner.  At this point, the benefit to us is being able to remove a background task whose job it is to occasionally refresh metadata/topic-partition-counts (so we can mod the murmur2 hash appropriately).  Maybe we've outthought ourselves and that's not necessary - dunno.  But if it's implemented "natively" then we can definitely strip that code out.
Last I recall 0.11.5 was scheduled for 6/26 (do I have that right?) - is that still the target?
Thanks!

0.11.5 shouldn't be far - a librdkafka rc has or is about to happen. Version experimental-4 already links against librdkafka 0.11.5-pre5, which contains this fix.

Just checking in on this and any possible date for 0.11.5?

I don't have an exact date, though note that librdkafka is up to RC2 and the dotnet release will coincide.

0.11.5 is out. also, we've worked out what the API will look like for user-defined partitioners (harder than implementing the feature!). that's coming too, promise!

custom partitioner enhancement is being tracked in #587


Update Spell Change

Update spell in doc :
Previous : suscribe
Now : subscribe

Approved & Merged! 👍
Thanks @punit5658


Feature - REST API to list remote searches

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included

Description of change

Just another simple endpoint, this time to get a list of Remote Searches.
This is very similar to #2512 , and as a result includes a degree of refactoring to keep things DRY and pave the way for any future BaseEntity work we do. To some degree there is a whole framework on the Java side for this, however on this side we're attempting to keep it more concrete and explicit.
Also snuck in a minor refactor to sort the list of properties in LegacyGuice. (One day we probably want to sit down and consider if this approach is really what we want to be doing - one big bag for all the DI.)

Thanks @PenghaiZhang . Merging! :+1:


cmd/compile: unexpected behavior difference between global and in-function variable definition

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.5 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/dcarbone/code/golang"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.5/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.5/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2c/s7sg4r5s1td507l7sglm2pzw9l4z5w/T/go-build267410383=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
Works:
package main

import "fmt"

type mytype struct {
	_ string
}

var foo = mytype{"foo"}

func main() {
	fmt.Printf("%#v\n", foo)
}

Fails:
package main

import "fmt"

type mytype struct {
	_ string
}

func main() {
	var foo = mytype{"foo"}
	fmt.Printf("%#v\n", foo)
}

What did you expect to see?
Either both fail or both succeed
What did you see instead?
When defining the variable in global space, the script executes.  When attempting to define the variable within the main function, the script fails to compile.
Apologies if this is expected behavior, but I was unable to locate any documentation indicating as much.

Reproduced with tip. The error message is:
x.go:10: cannot refer to blank field or method
This seems odd to me too.

I don't see anything in https://golang.org/ref/spec#Composite_literals that forbids this.

cc @mdempsky

Is there any intended use of a blank identifier for the field name other than padding in structs?

Just to add, we found structs with underscore entries in some source code and had no idea what it was intended to do.   Someone in the Gophers Slack group said that the underscore entry would make it so you were forced to use named field constructors and not lazy construction.  While playing with this, @dcarbone found that the behavior changed depending on if you tried to create the var in global or in local scope

Both versions compile with gccgo.

Not necessarily related to, but it reminds me of https://github.com/golang/go/issues/15481#issuecomment-262472312 in which
the bug report was spurious "cannot use _ as value" error and I noticed that https://play.golang.org/p/hz5ePuCDlF
package main

type m map[string]string

var _ = map[string]string{}       // ok
var _ = map[string]string{"": ""} // ok

func main() {
	var _ = map[string]string{}           // ok
	var _ = map[string]bool{}             // ok
	var _ = map[string]string{"a": "A"}   // error: cannot use _ as value
	var _ = map[string]bool{"true": true} // error: cannot use _ as value
}

had different results in the global vs function, somewhat similar to the _ check when in a function but successful compilation in the global scope.

cc @griesemer

This is just a bug in the compiler.
It's clearly correct code (and gccgo and gotype accept this). May or may not be related to #15481 (see @odeke-em 's comment above).

Unrelated to #15481, as far as I can tell.


Team 9

Task 1 Prediction - Density
Mean Absolute Error: 0.058
R2: 0.918
Normalised Mean Absolute Error (Assessed): 0.039
Points: 22
Task 2 Prediction - Centrosymmetric
Accuracy: 0.797
Macro F1-score (Assessed): 0.677
Weighted F1-score: 0.792
Points: 6
Task 3 Prediction - Mean Distances
No results submitted for task 3
Task 4 Prediction - Van der Waals Contacts
No results submitted for task 4
Bonus Task 1 Prediction - Packing Coefficient
No results submitted for bonus task 1
Bonus Task 2 Prediction - Cell Volume
No results submitted for bonus task 2
Bonus Task 3 Prediction - Space Group Symbol
No results submitted for bonus task 3
Total Points
28/130

Task 1 Prediction - Density
Mean Absolute Error: 0.058
R2: 0.918
Normalised Mean Absolute Error (Assessed): 0.039
Points: 22
Task 2 Prediction - Centrosymmetric
Accuracy: 0.797
Macro F1-score (Assessed): 0.677
Weighted F1-score: 0.792
Points: 6
Task 3 Prediction - Mean Distances
No results submitted for task 3
Task 4 Prediction - Van der Waals Contacts
No results submitted for task 4
Bonus Task 1 Prediction - Packing Coefficient
Mean Absolute Error: 0.031
R2: -0.171
Normalised Mean Absolute Error (Assessed): 0.044
Points: 9
Bonus Task 2 Prediction - Cell Volume
No results submitted for bonus task 2
Bonus Task 3 Prediction - Space Group Symbol
No results submitted for bonus task 3
Total Points
37/130

Task 1 Prediction - Density
Mean Absolute Error: 0.058
R2: 0.918
Normalised Mean Absolute Error (Assessed): 0.039
Points: 22
Task 2 Prediction - Centrosymmetric
Accuracy: 0.797
Macro F1-score (Assessed): 0.677
Weighted F1-score: 0.792
Points: 6
Task 3 Prediction - Mean Distances
Mean Absolute Error: 0.269
R2: 0.819
Normalised Mean Absolute Error (Assessed): 0.037
Points: 22
Task 4 Prediction - Van der Waals Contacts
Mean Absolute Error: 6.641
R2: -0.287
Normalised Mean Absolute Error (Assessed): 0.544
Points: 2
Bonus Task 1 Prediction - Packing Coefficient
Mean Absolute Error: 0.031
R2: -0.171
Normalised Mean Absolute Error (Assessed): 0.044
Points: 9
Bonus Task 2 Prediction - Cell Volume
No results submitted for bonus task 2
Bonus Task 3 Prediction - Space Group Symbol
No results submitted for bonus task 3
Total Points
61/130

Task 1 Prediction - Density
Mean Absolute Error: 0.058
R2: 0.918
Normalised Mean Absolute Error (Assessed): 0.039
Points: 22
Task 2 Prediction - Centrosymmetric
Accuracy: 0.797
Macro F1-score (Assessed): 0.677
Weighted F1-score: 0.792
Points: 6
Task 3 Prediction - Mean Distances
Mean Absolute Error: 0.269
R2: 0.819
Normalised Mean Absolute Error (Assessed): 0.037
Points: 22
Task 4 Prediction - Van der Waals Contacts
Mean Absolute Error: 6.641
R2: -0.287
Normalised Mean Absolute Error (Assessed): 0.544
Points: 2
Bonus Task 1 Prediction - Packing Coefficient
Mean Absolute Error: 0.031
R2: -0.171
Normalised Mean Absolute Error (Assessed): 0.044
Points: 9
Bonus Task 2 Prediction - Cell Volume
No results submitted for bonus task 2
Bonus Task 3 Prediction - Space Group Symbol
No results submitted for bonus task 3
Total Points
61/130


Arduino Utils

This PR adds (and reorganizes) Arduino-based utils with firmware, software and examples.
The SiLab relay board HL was renamed from Arduino.py to arduino_relay_board.py.
The following Arduino-based utils are added:

SerialToI2C (basil/HL/arduino_serial_to_i2c.py): A HL allowing to interface an I2C bus using the Arduino over serial
NTCReadout (basil/HL/arduino_ntc_readout.py): A HL allowing to read out up to 8 NTCs in a voltage divider configuration

The corresponding firmware is found in basil/firmware/arduino

For me is fine. If you remove the draft it can go I guess.

Is still need to write some docs and push some changes, when I am done, I mark as ready

Go time


SLF4J-335: jcl104-over-slf4j warning on release() should print to standard error

This patch modifies the println calls in SLF4JLogFactory.release() to use System.err instead of System.out.

When is this feature planned to be merged?


Beta fixes

fix execute command map names being off by one
fix login command error about missing modal
fix error when message folder can't be found on startup

also added changes to StartAdmin-bot.cmd  to run npm i on startup, and auto restart the bot if it closes unexpectedly.


Adding the new version of the mC4

Dear authors of Unimax,
Thanks a lot for your huge work with Unimax and for pushing for a model and dataset release.
In the paper (https://openreview.net/forum?id=kXwdL1cWOAi), you mentioned that the cleaned version of mC4 is going to be released. I was wondering if you have any updates on this side. Is the cleaned mC4 available?
Thanks a lot,
Pierre

Here you go:
https://huggingface.co/datasets/allenai/c4/tree/mC4_3.1.0/multilingual


Support for Less root functions, lookups, anonymous mixins

This fixes a number of errors in the language service parser for CSS/Less (that are not covered in https://github.com/Microsoft/vscode/issues/43087).

In Less, functions can be called anywhere to create a node, including any stylesheet or ruleset root. Fixed.
Custom functions can accept mixin-like arguments (such as accepting rulesets), and arguments can be separated with a semi-colon. Fixed.
Adds support for map lookups @ruleset[@lookup] or #ns.mixin(@arg)[prop]
Adds support for property references ($prop and interpolated ${prop})
Less is more forgiving of property and variable names than the CSS parser. This is particularly important after Less 3.5 which allowed the use of rulesets as maps, so declarations may be values like 100: 100 or even 10px: true if someone wanted to get crazy*. The CSS parser parses them as any number of token types (number or dimension), so there's a regex parsing function added in the Less parser to be more forgiving of property names.
Adds support for anonymous mixins, introduced with the each() function
Added if(), boolean, range(), and each() functions to Less completions
Fixes nested at-rule children of nested at-rules not being marked as nested... (Note: in Less, there are more at-rules than @supports and @media that bubble, but I notice the core CSS parser only supports those two types as being nested. Not sure if that's worth addressing or not.)
Fixes spelling for nestedProperties
Fixes detached ruleset declarations (assignment to a variable) no longer needing to terminate in a semi-colon (can end in } like any other block)
Fixes the disparity between mixin body and detached ruleset body. They support the same node types. Not sure why that was originally parsed differently here.
Fixes @supports ( as being parsed as a VariableCall. Checks for whitespace.

_* The declaration of 100 as a property name is not crazy; it's actually a real-world use case of a conversion of Bootstrap 4 maps to Less maps. See: https://github.com/seanCodes/bootstrap-less-port/blob/35390325fad4e23e037396dd19081a57d4189579/less/variables.less#L24

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: matthew-dean sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Just to note: I tested this through just the regular (and updated) tests on this repo. I haven't tried this in a local development build of VSCode.

One thing that's still kind of outstanding is that because rulesets can be maps in Less, the warning and squiggly lines about "unknown property"s is somewhat useless. Is there a way for those unknown property flags to not be set in a Less document? I think just coloring the keyword differently would be enough, but the squiggly line is quite obnoxious. (That would be true for CSS in general IMO. It's okay to visually distinguish known and unknown, but I wouldn't hit the user over the head.)

...Ping?

@octref Ok no worries, just wanted to make sure it didn't get lost!

Sorry, will try to get back to this soon and the requested changes when I can find some time.

I would love to see this moved further through the pipeline. Broken map lookups cause every proceeding colon, bracket, and curly brace to be presented as an error. It's really frustrating.

@radium-v Would you have time to fix conflicts and address the few changes requested? I've just got a full schedule at work + parenting.

@matthew-dean sure, I'll dive in this week.

Sooo, is anyone still on this? As it has missed its milestones and I would love to see this implemented but do not have the skills to finish this.

@kevinramharak I apologize. As someone who coordinates open source work, I know it's frustrating when a PR seems so close but languishes in changes. I just haven't had the extra cycles for any development on the side. Hopefully @radium-v can get to it? On a long enough timeline, I should be able to return to a pile of Less maintenance stuff, which includes this, but I don't yet have a slot in my schedule.

@kevinramharak @matthew-dean I also apologize, I overpromised when I volunteered to pick this up. I do still intend to pick it up and run it to the finish line, This is a blocker for radium-v/better-less#14 and I'm finally able to get back to it.

@octref @aeschli
I've merged master and moved methods according to feedback. However, I found that with even the base-level merge I was getting unrelated errors on SCSS (which was logging console errors but not reporting as errors to the test runner?) and an error with a property in the CSS actions test.
Can you take a look?

It's too late in our development week, but I'll try to review and make sure this goes in for August. Thanks again for your work!

@octref No problem!


Add /isLeader call to overlord and coordinator.

This is useful for putting them behind load balancers or proxies, as it lets
the load balancer know which server is currently active through an http health
check.
Also makes the method naming a little more consistent between coordinator and
overlord code.

👍
There's a /leader endpoint that will return the addr of the leader as well

That's true, although it's not useful for the case I mentioned.


fix(untracked-workspaces): Migrate untracked workspaces and display them in the UI

Handle untracked workspaces in the app.

[ ] Automatically migrate workspaces that belong to a project that the user has access to.
[x] Show the list of untracked workspaces that we can't automatically migrate in the Settings > Data tab like the untracked projects. We need to duplicate the workspace to avoid any document Id and backendProject conflicts
[ ] Show a warning to the user (toast notification) if there are any untracked workspaces/projects in the app. The warning has a link to open the Settings > Data panel so that users can view their data.

Closes INS-3373

The API should be good to go in the feature branch. Currently in review. @gatzjames

@gatzjames also please keep in mind that insomniaFetch does not throw error when the request fails, including 400s, so we need to do something like
if ('error' in response) {
  // handle the error
}


Revert "Updates for v3.10.3"

Reverts projectcalico/calico#3106

Deploy preview for calico ready!
Built with commit 70232fc85585b8ce4b66c5d46b4f6c47964e4139
https://deploy-preview-3110--calico.netlify.com


feat: add field25 support packages (PROOF-776)

Rationale for this change
In order to support MSM with elements on the bn254 curve we need to implement the base field Fq. This work introduces the constant, property, and random packages and components to support the bn254 base field, field25. The components are copied from the the field12 package, which supports the bls12-381 curve. The components are updated to support the bn254 base field, which is four limbs, compared to the six limbs of the bls12-381 base field.
The non-trivial changes, which include updating from six to four limbs and updating the tests, are isolated to this commit.
What changes are included in this PR?

constant, property, and random packages and components are copied from the field12 to the field25 package.
Each component is updated to support four limbs.

Are these changes tested?
Yes

:tada: This PR is included in version 1.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TMP Issue

Hello guys,
i'm quite new using Boxstarter but I want a little help or maybe a bug, idk. I'm trying to run my script https://gist.githubusercontent.com/Skolzack/fddce56392c094d790d9ebeadabfefb2/raw/56a08ee56c67d96c0a13ede3e4cd4f17d837ac30/Boxstarter.Testing.ps1 and it give me error on TMP.
Boxstarter log:

ERROR: The term 'cinstm' is not recognized as the name of a cmdlet, function,  file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
Built-in PowerShell host called with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1';& Import-Module 'C:\Users\rafae\AppData\Local\Apps\2.0\LT3Y0ERV.4A9\PJ7K626Q.LCW\boxs..tion_6b092740f7261cd0_0002.0009_8212bec7b6369c95\Boxstarter.chocolatey\Boxstarter.chocolatey.psd1' -DisableNameChecking -ArgumentList $true; & 'C:\ProgramData\chocolatey\helpers\chocolateyRunner.ps1' -package 'C:\ProgramData\chocolatey\lib\tmp80F3.tmp\tools\ChocolateyInstall.ps1' -installArguments '' -packageParameters '''] exited with '-1'.

CMD log:

ERROR: The term 'cinstm' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
The install of tmp9f08.tmp was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\tmp9F08.tmp\tools\ChocolateyInstall.ps1'.
See log for details.
Chocolatey installed 0/1 packages. 1 packages failed.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Failures

tmp9f08.tmp (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\tmp9F08.tmp\tools\ChocolateyInstall.ps1'.
See log for details.

Enjoy using Chocolatey? Explore more amazing features to take your
experience to the next level at
https://chocolatey.org/compare
Chocolatey : Chocolatey reported an unsuccessful exit code of -1. See
C:\Users\rafae\AppData\Local\Boxstarter\boxstarter.log for details.
No C:\Users\rafae\AppData\Local\Apps\2.0\LT3Y0ERV.4A9\PJ7K626Q.LCW\boxs..tion_6b092740f7261cd0_0002.0009_8212bec7b6369c
95\Boxstarter.Chocolatey\Invoke-ChocolateyBoxstarter.ps1:201 caractere:5
Chocolatey install $bootstrapPackage -source $source -force:$forc ...
  CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
 FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,chocolatey

Can anyone help me to figure it out? Thanks in advance.

Use one of the following options:

choco install
cinst

cinstm was deprecated and removed in 0.9.9 (after long term deprecation warnings to give you plenty of time to respond to deprecations before removal) - see https://github.com/chocolatey/choco/blob/master/CHANGELOG.md#099-march-3-2015 (breaking changes):

Deprecated/Removed Commands:

installmissing has been removed. It was deprecated awhile ago, so this should not be a surprise.

choco install behaves similar to the functionality of what cinstm did. If you want the latest of something, even if installed, use choco upgrade.

@ferventcoder I removed the 'cinstm' commands but the error persisted. I was like 'wtf?' Then I figured out that everytime when you change the code on gist the raw link changes too lol. So I need to generate a new bit.ly and I was using always the same link (i'm dumb, ikr).
Everything worked fine now. Thanks for the fast support!

@mwrock you can close this.


Disabled cookies in Firefox cause issues with LocalStorage

Seems localStorage is inaccessible with cookies disabled:
http://stackoverflow.com/questions/12805487/solution-for-firefox-user-disabling-cookies-and-thus-localstorage-polyfill-not
c.f. https://sentry.io/matt-godbolt/compiler-explorer/issues/165860738/
SecurityError: The operation is insecure.
  at this (main.js:107)
  at this (ext/golden-layout/dist/goldenlayout.js:250)
  at fn (ext/golden-layout/dist/goldenlayout.js:3343)
  at func (ext/golden-layout/dist/goldenlayout.js:75)
  at func (ext/raven-js/dist/raven.js:379)

Opera mini doesn't even have localStorage

Also seems to be related to seeing "QuotaExceededError"s : https://sentry.io/matt-godbolt/compiler-explorer/issues/165623562/

This is still apparently happening :(

I think we're now clear on this...


updated dependencies

Just updated the dependencies. Right now there is a problem to use latest version of date_calc with latest version of datetime_picker_formfield.

@makicamel i am new to dart/flutter, but maybe this PR helps? Would be great, if the https://pub.dev/packages/date_calc will be updated soon :)


Early stopping is implemented incorrectly in XGBoost.java:203 (jvm-packages)

Environment info
xgboost version used: 0.8
The commit hash (git rev-parse HEAD):
11bfa8584d8ddba2060ae2731f8599184e65f3b9
The description of the problem
In the file: https://github.com/dmlc/xgboost/blob/master/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/XGBoost.java line 203:
seems like the "&=" is not the correct operator to use, and instead it should be "|=" with decreasing initialized to false, in order to make sure consecutive "increases" in the loss function during evaluation rounds have been observed. With the current implementation the code stops after first increase, which is wrong. Probably it is a hard bug to catch in practice, I was just inspecting the implementation of early stopping and found this issue.
The intended usage of earlyStoppingRound parameter is described in line 121 (comment).

Feel free to submit a PR fixing this. There is also #2982.

@superbobry Thanks for connecting to the other issue. Somewhat related question: currently there is no way to know which is the optimal treeLimit to use in predictions, correct? Presumably it would be the tree which performed the best on evaluation during training.

Closing this for now. Feel free to re-open for any updates.


chore(package): update nyc to version 10.3.2

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #40   +/-   ##
====================================
  Coverage      92%   92%
====================================
  Files           1     1
  Lines          25    25
====================================
  Hits           23    23
  Misses          2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c92dc1...b9ce37e. Read the comment docs.


Change cell template of a grid onclick of button or on any other event.

Is there a possibility that i can change the celltemplate on click of a button outside the grid or any other event such as row click or anything.

You could do this inside a cellTemplate with ng-show or ng-if. You cannot swap out cellTemplates on demand.

Hi, The problem am facing is i have 2 grids where on click of a row in Grid 1, all the values are populated in Grid 2. Now i change the value in editable textbox in Grid 2, the background color of the textbox changes to red. Now i click on save button on top will make the textbox back to normal. Now instead of save button if i click on the next row in Grid 1, the values are populated in the Grid 2, but the textbox color is retained. How to make the color back to normal even on click of next row in Grid 1?
Here is the Plunker: http://embed.plnkr.co/WUg173JQYXceTrsTu7kD/preview

Is this not a duplicate of #2990?


Doesn't work on Linux, but works fine on OS X

Sorry in advance if this is just a user type question, but after a couple of hours of digging around...
On OS X, I installed git-lfs, tracked some binaries on some branch, checked them in, pushed, all is good.  If I do a fresh clone of the repo, then checkout the branch that has the binaries, git-lfs automatically downloads them and all is good.
Great, time to deploy to a Linux host.  It doesn't work.  Fresh clone of the repo, checkout the branch with the binaries, git-lfs does not download them.  Fine, I'll do git lfs pull manually.  That works, but now git considers them "modified":  http://d.pr/i/AOfa  and that breaks my deployment process.
That's my story.  Here's some technical info:
$ git lfs env
git-lfs/1.1.1 (GitHub; linux amd64; go 1.5.3; git 7de0397)
git version 2.7.1

Endpoint=https://github.com/AcademicWorks/user_app.git/info/lfs (auth=none)
  SSH=git@github.com:AcademicWorks/user_app.git
LocalWorkingDir=/home/rails/user_app2
LocalGitDir=/home/rails/user_app2/.git
LocalGitStorageDir=/home/rails/user_app2/.git
LocalMediaDir=/home/rails/user_app2/.git/lfs/objects
TempDir=/home/rails/user_app2/.git/lfs/tmp
ConcurrentTransfers=3
BatchTransfer=true
git config filter.lfs.smudge = "git-lfs smudge %f"
git config filter.lfs.clean = "git-lfs clean %f"

$ git lfs env
git-lfs/1.1.1 (GitHub; darwin amd64; go 1.5.3)
git version 2.7.0

Endpoint=https://github.com/AcademicWorks/user_app.git/info/lfs (auth=none)
  SSH=git@github.com:AcademicWorks/user_app.git
LocalWorkingDir=/Users/cjbottaro/Work/overlord/user_app
LocalGitDir=/Users/cjbottaro/Work/overlord/user_app/.git
LocalGitStorageDir=/Users/cjbottaro/Work/overlord/user_app/.git
LocalMediaDir=/Users/cjbottaro/Work/overlord/user_app/.git/lfs/objects
TempDir=/Users/cjbottaro/Work/overlord/user_app/.git/lfs/tmp
ConcurrentTransfers=3
BatchTransfer=true
git config filter.lfs.smudge = "git-lfs smudge %f"
git config filter.lfs.clean = "git-lfs clean %f"

:+1:  Exact same issue here.

Gah, sorry for the missed reply. It sounds like your repo isn't tracking the files properly. I need more info to help though.

What does .gitattributes look like? LFS will only automatically download files if Git matches the file path to a pattern in .gitattributes.
If files show up modified with no visible changes in git diff, it's likely that the change is simply going from a normal git blob with binary data, to a git blob with an LFS text pointer.

Can you replicate this in a dummy repository so I can take a look?

Shoot, I figured out my issue and forgot to post here.
I think it's due to some change in git and/or git lfs version.  Previously, having vendor/cache in .gitattributes was working, but now I have to say something like vendor/cache/* or vendor/cache/*.gem.

Some more info, updating git/git-lfs on my Mac caused the same issue to happen as was happening in Linux.  Thus I don't think this is a Linux vs OS X issue at all, but rather a version compatibility issue with git.

Well, LFS has nothing to do with how .gitattributes is parsed. But we can sure do better about helping people use lfs track better :) Thanks for replying!

for me the .gitattributes file is correct and I can't reproduce it with new repos (exact same .gitattributes). On the repo in question, there's no pre-push hook so maybe there's something else going on or other items are missing. Like the above post, it pulls automatically just fine on the mac but not on Linux. However, a brand new repo works fine.

@jekriske-lilly What's in your .gitattributes? What file paths are not downloading stuff properly? What are the errors? Have you confirmed that the server is storing the files properly?
Git hooks (like pre-push) have to be installed per local repository. Git LFS will automatically check for and add it when commands like git lfs track are run. If it's not there, you can run git lfs update to add it.  A pre-push hook ensures that LFS files have been successfully uploaded before any Git commits have been pushed.

gitattributes contains:
*.Rdata filter=lfs diff=lfs merge=lfs -text
I've confirmed the file uploaded correctly because a git lfs pull results in downloading a file with identical sha256sum
the gitattributes is in the project root directory and the file not downloading is in ./data/filename.Rdata
There are no errors on git clone. It simply thinks that it's complete and doesn't pull the lfs file until I manually type git lfs pull.

Is it possible that the filesystems on your mac and linux systems treat mixed-case filenames differently? Maybe this is an issue with how Git uses .gitattributes to filter filenames. I'd recommend using the skip-smudge option of git lfs install, which disables the smudge hook. It does mean you'll have to run git lfs pull manually, though. You will see a noticeable speed boost for large download operations.

I'll try this out, thanks!

Ahh, you were absolutely correct about the mixed case. The file extension is actually RData not Rdata. Making that change in the gitattributes file fixed everything.


Refactor/#1309 notification service

Refactor notification service to be event based
Closes #1309

I could not figure out a good way to use a notificationType Enum

I could not figure out a good way to use a notificationType Enum

dropped for now


(question) what is this use of PsGetCurrentProcessId

I'm new to driver development and I'm trying to learn more about process hacker
I saw PsGetCurrentProcessId is used inside KphDispatchCreate to get the connecting client pid but on microsoft IoGetRequestorProcessId  is the function that gets a handle to requestor client . Or the dispatch is running on the calling client thread behalf ?

You would use IoGetRequestorProcessId with minifilter callbacks:
https://docs.microsoft.com/en-us/windows-hardware/drivers/ifs/file-system-minifilter-drivers

I mean does PsGetCurrentProcessId returns the requestor id or the kernel driver process id ?

http://www.osronline.com/showThread.cfm?link=83346 https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/ntddk/nf-ntddk-psgetcurrentprocessid