dryRun and --dry-run does not seem to work as expected

We are testing the image swapper and have deployed it to our eks cluster, and the dryRun flag does not seem to be working (the actions are still taken; repo is created, image is uploaded, image ref is updated).
When we set the helm chart with
config:
  dryRun: true
  logLevel: debug
  logFormat: console

and/or set --dry-run=true as arg in deployment spec the actions are still executed.

@haghabozorgi Are you still having this issue? Can you export the k8s-image-swapper configmap and add it?

Yes, I can confirm: --dry-run is ineffective


v 4+ TreeBot returns 'Unknown' and DOES NOT select 'Unknown' from the Species list

ToDO:
TreeBot in the case of NOT being able to identify a species of tree should offer the user the option to enter 'Unknown' as a Species (AND force the user to choose a Tree Type).
Currently as of 4.0.6 Build 73 - the Species is being entered as 'Abelia (Abelia spp.)' (*which is the first on the list under 'Unknown'.
Video repo of the error:
https://user-images.githubusercontent.com/62637055/216436107-8a0a9459-db9b-4c0c-a350-4f575aa87725.mp4
For testing (A close up on this tree usually triggers an 'Unknown'). Especially if you get close to the branches.

@rajsavaliya081
Still seeing this in testflight https://testflight.apple.com/join/3awRDPvD build 7.0.4(74)
I am using an ios 15.6.1 device
https://user-images.githubusercontent.com/62637055/217988809-ee0540c5-3038-470a-b149-8fb15b254aa7.MOV


Propagate links crate attribute if any

Resolves https://github.com/nix-community/crate2nix/issues/300
It also requires https://github.com/NixOS/nixpkgs/pull/266787 to work.

Thanks!


Run Notebooks in the Browser

We need to explore services such as Binder and Google Colab to enable people to try out the tutorials in the browser itself without having to download anything.

What about juliaBox?
Maybe a step by step of how to load them in juliaBox is good enough.

JuliaBox currently uses JuMP 0.18.5 thus the notebooks do not work with it. Binder seems to be our best option.


jaccard time out; max out on CPUS

Running jaccard on recent mmul dataset has lead to time out of samples. Current resource allocation should be adjusted
Current resources
        "jaccard": {
                "mem": "48g",
                "threads": "2",
                "time": "01-00:00:00"
        },

Proposed changes
        "jaccard": {
                "mem": "40g",
                "threads": "32",
                "time": "02-00:00:00"
        },

Memory and time can probably be dropped with the increase in threads; will follow up after re-running current samples through with these changes.

Jobs completed with a run time of 1-16:34:45. Will leave the 2 day walltime for future projects. commit 6ddd749fbd9e3c09c83f2dbd12e97478adb24c89


Pageobjectpackages should not be a required field

Pageobjectpackages has a default values of "pages", but if it is not set in the config file, an error is thrown. Two things should be fixed:
1.) The value should be searched in the conf file as an optional property.
2.) If a page is not found, the error message should list all the page object packages it searched, preferably as a newline delimited list, and the error should indicate how to pass in additional page object package folder names.
This needs to be fixed in preparation for being able to run sentinel on the command line without needing to install eclipse.

Looking at updating this to just search the project.

This is made obsolete by migrating page objects to yaml files compoletely, which is currently in development.

Fixed by #23


Adding wildcard support for CsOnlineLisWirelessAccessPoint

Adding wildcard support for CsOnlineLisWirelessAccessPoint

Docs Build status updates of commit 1aeb4f9:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1aeb4f9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3418d82:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 3418d82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 28768f6:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

@dariomws In Get- command example 4, when we already have a record "CB-FF-8D-44-3C-4*", this means the wildcard BSSID is covering all the records in its range. When the user types in "CB-FF-8D-44-3C-44", apparently we don't have "CB-FF-8D-44-3C-44" but we have "CB-FF-8D-44-3C-4*" instead. So the user will see "CB-FF-8D-44-3C-4*" instead of the original BSSID they typed in.

Docs Build status updates of commit 28768f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@dariomws In Get- command example 4, when we already have a record "CB-FF-8D-44-3C-4*", this means the wildcard BSSID is covering all the records in its range. When the user types in "CB-FF-8D-44-3C-44", apparently we don't have "CB-FF-8D-44-3C-44" but we have "CB-FF-8D-44-3C-4*" instead. So the user will see "CB-FF-8D-44-3C-4*" instead of the original BSSID they typed in.

Thanks @kaishuipinggai! It´s clear now. Is this not the same as example 2?

@dariomws It's not the same as example 2. I will update the doc to make it more clear.

@kaishuipinggai I think I understand that it's not the same, but it could be confusing.
In Example 2, you'll get 0B-23-CD-16-BB-CC.
In Example 4, you'll get CB-FF-8D-44-3C-4*. But it´s the same if you run "Get-CsOnlineLisWirelessAccessPoint -BSSID CB-FF-8D-44-3C-48" or "Get-CsOnlineLisWirelessAccessPoint -BSSID CB-FF-8D-44-3C-4*", right?

@dariomws

In Example 2, you'll get 0B-23-CD-16-BB-CC.

In Example 4, you'll get CB-FF-8D-44-3C-4*. But it´s the same if you run "Get-CsOnlineLisWirelessAccessPoint -BSSID CB-FF-8D-44-3C-48" or "Get-CsOnlineLisWirelessAccessPoint -BSSID CB-FF-8D-44-3C-4*", right?

That is correct.
Also do you know how to add our PM as a reviewer? He created some review comments but they are in "Pending" state.

Ok, it's clear for me now. I'm not sure how you can provide a better explanation so I think you have done a good job. Thanks!
I don't know who the PM is, you can tag him if you know her/his username or maybe @yogkumgit can help us to add him as a reviewer.

@roykuntz is our team's PM.

@roykuntz Please review this PR and help us to resolve it. Thanks.

Docs Build status updates of commit 01d0b4b:
:clock10: Full build: the average full build time is 17 min(s) 42 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 01d0b4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0453ef1:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 0453ef1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsOnlineLisWirelessAccessPoint.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Can I get this change merged into master? Thanks! @get-itips @dariomws

Can I get this change merged into master? Thanks! @get-itips @dariomws
We will need @chrisda to kindly to that.

@chrisda Can I have this review merged into master? Thanks a lot!


Update config.ini

Lists that did not receive updates were deleted .

Hi! Thank you. I've updated the list of sources a bit. I don't want to remove sources that haven't been updated in a while, because they still have working proxies in them. I will completely revise the list in the near future.


Test failures in new dev orgs with duplicate rules enabled by default

*********** DEPLOYMENT FAILED ***********
Request ID: 0Af3600000AJcQ2CAL
All Test Failures:

HH_ManageHHAccount_TEST.testRemoveContactActiveAddress -- System.DmlException: Insert failed. First exception on row 0; first error: DUPLICATES_DETECTED, Duplicate Alert: []
Stack trace: Class.HH_ManageHHAccount_TEST.testRemoveContactActiveAddress: line 207, column 1

HH_ManageHousehold_TEST.testRemoveContactActiveAddress -- System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, TDTM_Contact: execution of BeforeInsert
caused by: System.AssertException: Assertion Failed: Class.ACCT_IndividualAccounts_TDTM.insertContactAccount: line 568, column 1
Class.ACCT_IndividualAccounts_TDTM.run: line 288, column 1
Class.TDTM_TriggerHandler.runClass: line 169, column 1
Class.TDTM_TriggerHandler.run: line 101, column 1
Trigger.TDTM_Contact: line 34, column 1: Expected: null, Actual: Insert failed. First exception on row 0; first error: DUPLICATES_DETECTED, Duplicate Alert: []
Class.TDTM_TriggerHandler.run: line 139, column 1
Trigger.TDTM_Contact: line 34, column 1: []
Stack trace: Class.HH_ManageHousehold_TEST.testRemoveContactActiveAddress: line 201, column 1
*********** DEPLOYMENT FAILED ***********

**lurch: add

Tracking W-009434

Included in beta release version 3.71 (Beta 1) and higher

Included in production release version 3.71


feat(wallet): Implemented react-native-v8

This PR:

Implements react-native-v8 for Android.
Updates several dependencies.

Notes:

This PR swaps out hermes for v8 on Android. This switch makes the app much more performant on physical devices and significantly improves the UX on older, less capable Android devices.
I had to remove any hardcoded integer with an underscore throughout the app. v8 does not seem to enjoy it.

Damn, this really does feel a lot more snappy. Got it to build and run everywhere (Intel & M1 emulators, device). Will test a bit more though because I had the occasional black screen for a few seconds on initial launch.

I see some open issues there regarding react-native-reanimated library. I wonder if using v8 might block us from upgrading RN version in future?


As a user I would like a multi-file collection or work to be downloadable with one click as a zip file so that I don't have to spend so much time downloading them file by file.

As collections and works get bigger downloading the files is going to get cumbersome. Give a one click download where they all zipped and then downloaded.

This is a duplicate of #635 which I actually wrote myself so...closing.


Added api-common-protos submodule and test to ensure it works

Added api-common-protos as a submodule under the testutil dir (this should be the only time we need it AFAIK). This is a solution to issue #84.
Also added a test that uses it.
FWIW I also had to follow @lukesneeringer's update to the installation instructions (#88), because there were deps on them. I think I'd rather include them as a submodule if there's an easy way of doing it.

FWIW I also had to follow @lukesneeringer's update to the installation instructions (#88), because there were deps on them. I think I'd rather include them as a submodule if there's an easy way of doing it.

There is not really -- those protos are part of protocol buffers, not part of their own repo.
However, what I am doing in #88 is the canonical protoc installation instructions. (protoc is not installed properly if it is not done.)


docs: add support for getters (and setters) on class

On our package https://jsr.io/@dunno/jsr-registry-bindings (specifically on the main file https://github.com/teamdunno/jsr-registry-bindings/blob/main/mod.ts#L155), the getters that I coded here

doesn't get displayed on the docs, only shows the private variables that I used for the getters

But on vscode (or any other ide), the getters showed up

I can see the getter as an readonly property here: https://jsr.io/@dunno/jsr-registry-bindings/doc/~/Package#accessor_firstfetch
This page however lists the getter as a method<EMAIL_ADDRESS>This is a bug, and is tracked here: https://github.com/denoland/deno_doc/issues/666

Alright thanks! Im going to close this issue for now

(For future readers) The bug is being tracked here => https://github.com/denoland/deno_doc/issues/666


Change Automatic to white, for recoloring in code

Changed to white as discussed in #281.

No worries on the break.  I went ahead and synced my branch accordingly.  Just to be safe, I'd prefer someone else take a look and merge this pull request for me.  When using GitHub, I always feel like I "fake it until I make it."


Undefined utility mixins in component SCSS

Describe the bug
The CSS in @faststore/ui contains Sass mixins that are not correctly imported/defined in certain files.
The focus-ring, focus-ring-visible, input-focus-ring, and truncate-title mixins are all defined in @faststore/ui/src/styles/base/utilities; when we try to use the mixins in the components, they are undefined.
For example, the focus-ring mixin is used in many places – like @faststore/ui/src/components/atoms/Button/styles.scss. Since the focus-ring mixin is defined in a different file, you need to either @import or @use that mixin in the file where you want to use it -- otherwise the mixin will be undefined.
Expected behavior
A component CSS file should include either an @import or @use for all mixins defined in other files but used in the component file.
Current behavior
Component CSS files are currently missing the @import or @use for some mixins, resulting in those mixins being undefined.
Possible Solution
Adding  @import "./../../../styles/base/utilities"; at the top of the @faststore/ui/src/components/atoms/Button/styles.scss file will ensure that the focus-ring mixin is defined.
Another option is to add @import "./../../../styles/base"; at the top of the @faststore/ui/src/components/atoms/Button/styles.scss – this works because the focus-ring mixin is defined in base/utilities, and is then imported into the base file.
To solve all of the undefined issues for focus-ring, you will need to add add @import "./../../../styles/base"; at the top of the following files:

packages/ui/src/components/molecules/Breadcrumb/styles.scss
packages/ui/src/components/molecules/SkuSelector/styles.scss
packages/ui/src/components/molecules/ProductCard/styles.scss
packages/ui/src/components/atoms/Button/styles.scss
packages/ui/src/components/atoms/Input/styles.scss
packages/ui/src/components/molecules/SearchInputField/styles.scss
packages/ui/src/components/atoms/Checkbox/styles.scss

You will need to follow the same process for the focus-ring-visible, input-focus-ring, and truncate-title mixins. If a component file uses more than one of the above mixins, you will only need to import the base file once.
Additional context
Longer term, you may want to move towards using @use instead of @import, but I followed the existing pattern in your repo for now. Here is more info from the Sass docs on the difference between the two: https://sass-lang.com/documentation/at-rules/use/#differences-from-import. We could also consider using Sass partial files (https://sass-lang.com/guide/#partials) for mixins.

I think this should be the complete list of files where mixins were undefined, but it probably makes sense to double-check.

components/atoms/Checkbox/styles.scss
components/atoms/Input/styles.scss
components/atoms/Link/styles.scss
components/atoms/Radio/styles.scss
components/atoms/Select/styles.scss
components/molecules/Accordion/styles.scss
components/molecules/Breadcrumb/styles.scss
components/molecules/BuyButton/styles.scss
components/molecules/Carousel/styles.scss
components/molecules/CartItem/styles.scss
components/molecules/Gift/styles.scss
components/molecules/InputField/styles.scss
components/molecules/Modal/styles.scss
components/molecules/NavbarLinks/styles.scss
components/molecules/ProductCard/styles.scss
components/molecules/ProductTile/styles.scss
components/molecules/ProductTitle/styles.scss
components/molecules/SearchDropdown/styles.scss
components/molecules/SearchInputField/styles.scss
components/molecules/SearchProducts/styles.scss
components/molecules/SkuSelector/styles.scss
components/molecules/Toast/styles.scss
components/molecules/Toggle/styles.scss
components/organisms/BannerNewsletter/styles.scss
components/organisms/BannerText/styles.scss
components/organisms/EmptyState/styles.scss
components/organisms/Filter/styles.scss
components/organisms/FilterSkeleton/styles.scss
components/organisms/Footer/styles.scss
components/organisms/Hero/styles.scss
components/organisms/ImageGallery/styles.scss
components/organisms/Incentives/styles.scss
components/organisms/Navbar/styles.scss
components/organisms/Newsletter/styles.scss
components/organisms/PaymentMethods/styles.scss
components/organisms/ProductDetails/styles.scss
components/organisms/ProductGallery/styles.scss
components/organisms/ProductGrid/styles.scss
components/organisms/ProductShelf/styles.scss
components/organisms/SearchInput/styles.scss
components/organisms/SlideOver/styles.scss
components/organisms/Tiles/styles.scss

I removed the part about media(">=notebook") and media(">=tablet") from this ticket since the solution is going to be different than the other mixins; I moved that to a new issue: https://github.com/vtex/faststore/issues/1905

Hie @hahnwhitney thank you so much for the detailed description and suggestions! 🤩🤩🤩
We really appreciate your inputs! We will discuss these approaches and test what works better in our current situation. I hope to get back to you with some news soon~

Hi @hahnwhitney , following an assessment from the FS team, this is not related to the actual functionality of the store, so it is not prioritized right now. This will remain a task and the team will update when solved.


[Power Run] App Search Toggle

Haven't tested Power Run ever since 'cause its not working on me. Anyway I found this feature from Ubuntu where you can toggle which apps will show in search. Either you can disable calculator in results if those aren't useful for example. Should work with selecting drives too.

20H1/0.18.1
Same as https://github.com/microsoft/PowerToys/issues/4035
Alt+Space does not working.

hi @gczark, sorry about the reply tardiness. can you confirm if the new version isn't working for you

I need to replace the shortcut key with alt+R, alt+space seems to be already used in window menu (minimize, maximize, ...) as shown in other issues.
' finding replicates
I can confirmed it works in the latest, even from previous versions. Power Run does not appear when pressing alt+R for the first time. It takes it multiple presses.


Enhacement in FAQ page

Deliverables:

[ ] Make the image and card containing FAQs one below another rather than side by side
[ ] Give hover effect to the Faq card (#016795)

@Kajol-Kumari Can I take this issue? Also, please give your review for https://github.com/HITK-TECH-Community/Community-Website/pull/188
Thanks & Regards
Urvashi Anand

@Kajol-Kumari Can I take this issue? Also, please give your review for https://github.com/HITK-TECH-Community/Community-Website/pull/188
Thanks & Regards
Urvashi Anand

Hey @urvashi-code1255 I request you to please get atleast one of your PRs merged before claiming any further issue

Hey @urvashi-code1255 I request you to please get atleast one of your PRs merged before claiming any further issue

Sure @Kajol-Kumari

Sure @Kajol-Kumari

can i work on this issue

can i work on this issue

i am done with my task and I had made the pr

i am done with my task and I had made the pr

and please u review my pr

and please u review my pr

Hey @kenkirito your PRs have conflicts and we can't review/test or merge any PR having conflicts! Also please try to keep the comments short and precise,like here you can have conveyed your word in a single line :)
Also I request you to please get atleast one of your PRs merged as they are getting piled up!

Hey @kenkirito your PRs have conflicts and we can't review/test or merge any PR having conflicts! Also please try to keep the comments short and precise,like here you can have conveyed your word in a single line :)
Also I request you to please get atleast one of your PRs merged as they are getting piled up!

my one pr got merged 2 days ago

my one pr got merged 2 days ago

can i work on this .. everytime someone gets assinged on the issue i like

can i work on this .. everytime someone gets assinged on the issue i like

i have solved the conflicts

i have solved the conflicts

Hey @kenkirito you are still assigned 3 issues, please fix them first as we can only assign 2 issues at max to anyone!

Hey @kenkirito you are still assigned 3 issues, please fix them first as we can only assign 2 issues at max to anyone!

hey @Kajol-Kumari can i work on this issue

hey @Kajol-Kumari can i work on this issue

ok

ok

@Kajol-Kumari i would like to work on this issue, please assign me!

@Kajol-Kumari i would like to work on this issue, please assign me!

Hey @chait04 please go ahead with this issue.
@shraddha-1402 please look for some other issue. We would be opening more very soon :)

Hey @chait04 please go ahead with this issue.
@shraddha-1402 please look for some other issue. We would be opening more very soon :)

@Kajol-Kumari I would like to work on this.

@Kajol-Kumari I would like to work on this.

Hey @vedikaag99 we can't assign this to more than one person. Please checkout other issues

Hey @vedikaag99 we can't assign this to more than one person. Please checkout other issues

First it look like this

which hover effect i have to add ...

First it look like this

which hover effect i have to add ...

Hey @chait04 please increase the width of the main card containing the faq cards and also provide a bit more margin/padding to left and right of the card containing faq-content

Hey @chait04 please increase the width of the main card containing the faq cards and also provide a bit more margin/padding to left and right of the card containing faq-content

ok

ok


Typo "Azure Storage emulator"→"Azure Storage Emulator"

https://docs.microsoft.com/en-us/visualstudio/azure/overview-connected-services?view=vs-2019
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

In this case, the word "emulator" is referring to the Azurite emulator, and not to the Azure Storage Emulator executable that was included in earlier versions of the SDK. Lowercase as-is seems correct, so we'll close the pull request.
@hyoshioka0128 Thanks for contributing.


Type Error thrown in ZF3

I get the following error each time I brake something in my code.

Fatal Error: Uncaught TypeError: Argument 1 passed to ZendDeveloperTools\Exception\SerializableException::__construct() must be an instance of Exception, instance of Error given called in .../vendor/zendframework/zend-developer-tools/src/Collector/ExceptionCollector.php on line 45 and defined in .../vendor/zendframework/zend-developer-tools/src/Exception/SerializableException.php on line 26

The culprit appears to be a request for "\Exception" type, i worked around this by changing to "\Throwable" on .../vendor/zendframework/zend-developer-tools/src/Exception/SerializableException.php

Dupe of https://github.com/zendframework/ZendDeveloperTools/pull/217


docs: add environment variable cheatcodes

Closes https://github.com/foundry-rs/book/issues/344.

@all-contributors add @0xYYY for docs


Activation of capabilities Cloud Int. & API management failing in EU

Hello,
Scenario URL: https://developers.sap.com/tutorials/cp-starter-isuite-onboard-subscribe.html
Step 4: Provision the capabilities.
Issue: The provisioning of capabilities - Cloud Integration & API Management is failing in EU region with error message:
"Error T001: Activation of Cloud Integration capability has failed. Please try again later. If the issue persists, please send your application URL and details of the error message to<EMAIL_ADDRESS>&
"Error C002: Activation of API Management capability has failed. Please try again later. If the issue persists, please send your application URL and details of the error message to<EMAIL_ADDRESS>Screenshot attached for reference:

Labels to be added:
Landscape Labels: trial1 (EU)
Sprint Label: SCPTest-2102
Scenario Label: SCPTest-cloudin
prio: HIGH-prio
Thanks,
Shubham Agarwal

@i353590 - As discussed, unable to duplicate the issue in EU subaccounts. Tried this morning and noon too. Able to activate the capabilities.

Hello @Karunaharan ,
Yes, the issue is not reproducible now. now working in EU region.
Thanks,
Shuhbam

This issue currently occurs again with region US East (VA)


Remove HMC?

With NUTS now implemented in TFP, I think we can remove the entire pymc4/hmc subdirectory.
Are there objections to this?

+1. Plus in light of the refactoring out pymc3 hmc/nuts, we can design wrapper to interface with that later on.


[VS Code] Error: Running the contributed command:'extension.git-file-history' failed.

Hi folks, I just installed the extension and when trying to see the history of a file I get the following error:
notificationsAlerts.ts:38 Error: Running the contributed command:'extension.git-file-history' failed.
    at e._executeContributedCommand (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:486:51)
    at e.$executeContributedCommand (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:486:443)
    at t._doInvokeHandler (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:644:118)
    at t._invokeHandler (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:643:744)
    at t._receiveRequest (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:642:322)
    at t._receiveOneMessage (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:641:155)
    at c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:638:960
    at c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:38:994
    at e.fire (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:44:113)
    at a (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:170:213)
    at Socket.f._socketDataListener (c:\Users\MyUser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:170:434)
    at Socket.emit (events.js:182:13)
    at Socket.EventEmitter.emit (domain.js:442:20)
    at addChunk (_stream_readable.js:279:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onread (net.js:636:20)
t.onDidNotificationChange @ notificationsAlerts.ts:38
(anonymous) @ notificationsAlerts.ts:26
e.fire @ event.ts:567
t.notify @ notifications.ts:113
t.error @ notificationService.ts:48
t.onError @ commandsHandler.ts:325
(anonymous) @ commandsHandler.ts:310
_tickCallback @ internal/process/next_tick.js:68
Promise.then (async)
(anonymous) @ commandsHandler.ts:306
setTimeout (async)
t.runAction @ commandsHandler.ts:296
t.run @ commandsHandler.ts:280
e.run @ quickOpenModel.ts:583
t.elementSelected @ quickOpenWidget.ts:556
(anonymous) @ quickOpenWidget.ts:235

Hey Matias, try with the new version (v0.1.0)

@pomber I tried with the new version but still doesn't work.
It shows the message:
Loading c:pathtoclientsrcApp.vue history ...
The path should be c:\path\to\client\src\App.vue

Sorry about that, and thanks for reporting it again. Just published 0.1.1 and tested it on windows. It should work now.

It is working now. Thank you! 🎉


Unable to inference on the V100 GPU (Driver Version: 470.182.03 / CUDA version 11.1 and 11.4)

Describe the issue
Issue:
I find the code below cannot work under the CUDA Version of 11.1 and 11.4, where the torch version is torch=2.1.0.
Command:
python -m llava.serve.cli  --model-path /zecheng/svg_model_hub/llava-v1.5-13b --image-file /workspace/zecheng/ns/svg_dataset/output.png

Log:
Traceback (most recent call last):
  File "/home/chewu/.conda/envs/llava/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/chewu/.conda/envs/llava/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/workspace/LLaVA/llava/serve/cli.py", line 119, in <module>
    main(args)
  File "/workspace/LLaVA/llava/serve/cli.py", line 32, in main
    tokenizer, model, image_processor, context_len = load_pretrained_model(args.model_path, args.model_base, model_name, args.load_8bit, args.load_4bit)
  File "/workspace/LLaVA/llava/model/builder.py", line 140, in load_pretrained_model
    vision_tower.to(device=device, dtype=torch.float16)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1160, in to
    return self._apply(convert)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 810, in _apply
    module._apply(fn)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 810, in _apply
    module._apply(fn)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 810, in _apply
    module._apply(fn)
  [Previous line repeated 1 more time]
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 833, in _apply
    param_applied = fn(param)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1158, in convert
    return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
  File "/home/chewu/.conda/envs/llava/lib/python3.9/site-packages/torch/cuda/__init__.py", line 298, in _lazy_init
    torch._C._cuda_init()
RuntimeError: The NVIDIA driver on your system is too old (found version 11040). Please update your GPU driver by downloading and installing a new version from the URL: http://www.nvidia.com/Download/index.aspx Alternatively, go to: https://pytorch.org to install a PyTorch version that has been compiled with your version of the CUDA driver.

I hope the author can fix this problem or provide some alternative approaches to run this code on this machine (CUDA version==11.1 or 11.4)

This may be due to the recent release of PyTorch 2.1, which requires CUDA 12.1 by default. I temporarily set the torch version to 2.0.1 in https://github.com/haotian-liu/LLaVA/commit/fda0665106c5b13bbb5b1ffb167ce5e32cd7c8d7. Can you pull the latest code and try a fresh install?

This may be due to the recent release of PyTorch 2.1, which requires CUDA 12.1 by default. I temporarily set the torch version to 2.0.1 in fda0665. Can you pull the latest code and try a fresh install?

Thank you very much. This modification works! Now, this code can be run on my machine!

Could you please tell me the versions of your libraries, including torch, torchvision, and flash-attn? I encountered the following error while installing flash-attn.


Exploit Weakness no longer working as of new update

Foundry 11, Build 315
Pathfinder 5.9.1
This was working for me prior to the update. Now clicking the "roll" button after clicking the Macro just does nothing.

Please disregard. It looks like I forgot to update the module before the game.


confirm that a package name is available on npm

@travi commented on Fri Jun 30 2017
https://github.com/sindresorhus/npm-name

@travi commented on Fri Jul 28 2017
https://github.com/sholladay/squatter

also validate against the naming rules: https://github.com/npm/validate-npm-package-name

name format is now validated, but it would still be useful to check to see that it is still available (at least for packages)


offboard failsafe to loiter, but the yaw is not stable

i set my failsafe mode to hold, and with no RC, it did turn to hold, but i.m guessing the yaw setpoint is unstable so the drone can't hold its heading, just turning at random.
i searched the problem and it's said that bad gps can cause the problem, but when i tried HITL simulation with accurate GPS information it still appeared, so is there any better way to hold the heading in loiter mode?

@KeyneZzz which version of PX4 exactly?
@Stifael @MaEtUgR

https://logs.px4.io/plot_app?log=fcc6faa6-eea3-48c2-afad-b8b958824258
here's the log

https://logs.px4.io/plot_app?log=0e13fde7-88d6-4395-ba0d-649b474abb5a
this is another trial with more recent version on master, and it is acting like it used to be: when turn to falisafe hold, yaw turn to 0. but this is still not what i want. i want it to keep the heading, not turning north.
i have succeeded to modify it in v1.6.x  but now since the pos controller is refactored, i can't find the exact lines to modify it.

https://logs.px4.io/plot_app?log=58f3d121-cc66-4b11-9436-3ec3136b23c3
tried the change in the PR above(manually changed), but the problem remains.
it seems like when turn to offboard-loss failsafe, the navigator should turn to loiter rather than to rcloss.

well i find the problem, in mission_block.cpp MissionBlock::set_loiter_item, when initialize the loiter item, the yaw is set to NAN

If this NAN yaw setpoint gets through the flight task and to the position control it just means you don't care about the yaw and it will stay uncontrolled e.g. drifting to wherever the drone wants. Does this only happen in failsafe or also when you manually switch to loiter in flight?
Do you want to create a pr for your fix if that solves the upstream bug?

I see it's here: https://github.com/PX4/Firmware/pull/10291

Still not solved, ongoing here: https://github.com/PX4/Firmware/pull/10297


Data discrepancy found

Invalid release year 3000 for Lost in Translation. it should be 2003 :-)

Thanks for feedback. Well spotted !
It has been fixed in release #v<IP_ADDRESS>


cpool: don't reuse connection if we sent close

Motivation:
Previously, we'd only use the server's connection header to determine if
we should close the connection or not. That's wrong because if we set
connection: close ourselves, we must not reuse again.
Modification:
Set TaskHandler.closing = false if we send a close header.
Result:
More HTTP correctness.

hit #226 , retrying

@swift-server-bot test this please

swiftpm bug. Not filing because it's the 5.0 one, if we see this on 5.2 we should file
[437/448] Compiling Swift Module 'NIO' (66 sources)
<unknown>:0: error: missing submodule 'CNIOLinux'
/code/.build/checkouts/swift-nio/Sources/NIO/GetaddrinfoResolver.swift:24:8: error: no such module 'CNIOLinux'
import CNIOLinux
       ^

@swift-server-bot test this please


pythonPackages.psutil: 4.3.0 -> 4.4.2

This is the last 4.x release before 5.x
Motivation for this change
Upgrade for #31975
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

nox-review is failing with:
warning: no previously-included files matching '*.py[co]' found anywhere in distribution
no previously-included directories found matching 'docs/_build'
builder for ‘/nix/store/q5pqx45v5l4c8v752l5c44pl14a0njxf-python2.7-oslo.reports-0.6.0.drv’ failed with exit code 1
killing process 27667

oslo-reports is also broken without this update.

I've pushed 5.4.1 to staging. 6a3b92626e43b5ae432eb7f81f76af92b59a2e13
Oslo is indeed failing: https://hydra.nixos.org/eval/1413023?filter=oslo&compare=1413022


'pip install pyjs' doesn't work

It would be nice if I could just do 'pip install' and have a working environment, but there appear to be several idiosyncratic intermediary build steps that prevent this.

I have used user command: pip install git+https://github.com/pyjs/pyjs.git#egg=pyjs to install pyjs but it is not working. The error is as following:

@hidewyb The error message says that git cannot be found. Make sure you have Git installed and it's in your path.


Arabic letters doesn't appear connected when using whole Arabic words

Arabic letters doesn't appear connected when using whole words (for example sin and cos should be جب and تجب in arabic but they're appearing like this ج ب and ت ج ب).

This is a duplicate of https://github.com/mathjax/MathJax/issues/474

Maybe I closed too soon? #474 started out as a duplicate but focused more on the TeX input recently. I'd be ok if you prefer to reopen this.


Generator

Hey! This is super awesome! I just came across your repo and I already love your small profiles! Just out of curiosity: Is the code to produce the profiles also opensource?

Howdy!  Thanks for the kind words!
I'm afraid the software never made it out of the prototype stage, so I haven't published the source code anywhere.  As of now, I have 3 separate utilities, in various states of refinement:

A curve-fitting and evaluation utility.  This process involves a judgement call on the optimal balance of size/accuracy, so the process is highly manual and the utility is very rough.
A utility to calculate and nudge/balance color matrices.  This one is much more straightforward and could probably be automated, but I haven't done so because of the need to tweak matrices with negative profile-adjusted XYZ values.
A utility to calculate and write the profile ID.  This just calculates and writes an MD5 hash without touching the data since other profile editors that do this would destroy the custom packing.

All of the profiles in the collection were hand assembled in a hex editor because the optimal packing was different depending on profile contents.  I then verified them using ICC tools.  V4 profiles would be easy to automate, but V2 would take a bit of work.
Coincidentally, I just this week found myself in need of a couple of new profiles for video colorspaces, so I'll probably take a look at automating more of the process.  I'll update here if I get anywhere with that.


Permissions required to connect site to hub site

Steps 5 & 6 talk about "site owners". Does this mean "members of the [site name] owners group" or "site collection administrators"? In our experience it seems only site admins can associate their sites to a hub?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc4df1d8-955c-63d2-628e-8359391b8710
Version Independent ID: 01326ab6-1270-d096-64e8-eb7d63ea9863
Content: Create a hub site in SharePoint Online
Content Source: SharePoint/SharePointOnline/create-hub-site.md
Service: sharepoint-online
GitHub Login: @kaarins
Microsoft Alias: kaarins

@repton-infinity Thank you for this feedback
I am not sure about the site owners. Let me get this over to the SharePoint team for answers. If you need an immediate answer Support can also handle this to resolution.
Here is a quick video on opening a ticket: https://www.youtube.com/watch?v=puuOy0sEg1Y
I was able to get this into the backlog for the SharePoint team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@tseward is investigating this issue.

@repton-infinity I updated step 5 only. Other references in this article to 'site owners' appears to be more of a generic reference rather than permission-related.


Automatically switch to newest created Live-stream

Hello,
We are using a stream-deck with companion to run a YouTube live-stream each Sunday morning.
We would like to use the button on the YT Module for companion to toggle Go Live on YouTube remotely from the stream deck.
Was wondering if there was any way to make that button automatically Refer to the newest made live-stream instead of changing the settings each time we want to go live with a different stream.
Thanks very much,
-GitHub User :)

Hi, yes, its already implemented https://github.com/bitfocus/companion-module-youtube-live/pull/63
There is special action "Go live" where you can set "Unfinished #0" as its param and it will be mapped to the nearest upcomming pending stream, so you dont need to reconfigure buttons every week.
You can also use various variables to see upcoming stream state: $(YT:unfinished_0), $(YT:unfinished_health_0), $(YT:unfinished_state_0)

Thanks so much!


Custom color for farmyards.

A change that turns everything red - well actually only farmyards - and those orange.
Right now, farmyards are not defined in iD CSS, which result in them being colored forest-green while editing. Green is not an intuitive color for a human-centric area. And farmyards are fairly common when mapping, so it seems important that they should have a distinct color.
I used a modified copy of the CSS code for residential areas, and changed the color to the same orange used for farmyards on the standard openstreetmap layer on osm.org.

Thanks I like it!


Support for QoS

Isn't this supported using the OnStarted hook already? Although, this is way nicer way of setting it.
One important thing to support with QoS is that it can be dynamic. Meaning that you can set it dynamically using metrics from your application.

Yeah that's true, maybe this shouldn’t be a separate implementation but rather something to add from a custom function. That way you can do it on whichever channel and also on the client if you would like to.
I’ll close this PR!


Add swerve

Ratelimiting constants need to be tested

Should probably wait until navx lib is out of beta for 2024

This is ready as soon as the vendor deps are stable


Unity 5.4

although Unity 5.4 is still in beta there are already some stuff that uses it, as such would you be able to update Unity Studio to 5.4? at the moment it doesn't  extract textures (iv only had luck with 1 texture) and does a very small number meshes. if you want i can send over some files to help

No, the owner of this repository is awol. Use a different tool: Google


customize http options for case without http client config

https://github.com/stolostron/backlog/issues/20667
Signed-off-by: Marco<EMAIL_ADDRESS>

/lgtm


Expose ClientSecurity type as main export

Currently, in order to use ClientSecurity as part of the v1.NewClient constructor, I am having to import the type directly from the /dist package of the module. Can we elevate this type as a main export since its used in the public constructor?
import { v1 } from '@authzed/authzed-node'
import { ClientSecurity } from '@authzed/authzed-node/dist/src/util'

const client = v1.NewClient('test', 'localhost:50051', ClientSecurity.INSECURE_LOCALHOST_ALLOWED)

Thanks!

@cgcoss I see that you already resolved this - can we get a new release out to match the README?

hey @mgagliardo91, yes I did run into this issue. I committed a fix, but ended up pursuing an alternate route. I am not actively involved with project, but it should be straightforward for you to get a new release out.

@cgcoss thanks, I'll do that. If you don't mind me asking - did pursuing another route mean another client or away from authzed? I'm currently POC'ing the service for our use case.


Improve documentation as to how to deploy to preview without production from GitHub Actions

Which Cloudflare product(s) does this pertain to?
Pages
Subject Matter
Explain how to deploy to preview without production
Content Location
On this page https://developers.cloudflare.com/pages/how-to/use-direct-upload-with-continuous-integration/ it appears that it would explain, how I can use GitHub Actions to control deployment to CF Pages.
While the explanation is sufficient to do a direct deployment to production, I cannot figure out how to indicate in my GitHub workflow, how to deploy only to the preview host but not production.
Additional information
Here is the workflow I built, which works great aside from its insistence on always deploying directly to production:
https://github.com/simonheimlicher/claris-gh-actions/blob/main/.github/workflows/deploy-cloudflare-pages.yml

Howdy @simonheimlicher, updating the docs in the tagged PR to explicitly call out that the action happens w/in the context of the current git branch.
So, you'd get preview deployments for free, so long as the action is triggered by a branch (and not production).


"Push to" in source control now in a sub menu - annoying

Issue Type: Bug
In the new iteration of VS Code, the "..." menu in source contral has changed such that I now have to access a submenu to choose "Push to..". So now to achieve the same action, I have to click twice instead of once. It's not that big of a deal I suppose, but it is more annoying, and less conveneint.
VS Code version: Code 1.49.1 (58bb7b2331731bf72587010e943852e13e6fd3cf, 2020-09-16T23:27:51.792Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v4 @ 3.50GHz (8 x 3492)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.90GB (16.28GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

vscode-sidebar
Acr
1.1.2

LinkCheckMD
bla
0.3.1

vscode-markdownlint
Dav
0.35.1

docs-article-templates
doc
0.2.9

docs-authoring-pack
doc
0.1.8

docs-images
doc
0.0.8

docs-linting
doc
0.0.3

docs-markdown
doc
0.2.71

docs-metadata
doc
1.0.4

docs-preview
doc
0.3.49

docs-yaml
doc
0.2.5

powershell
ms-
2020.4.0

vscode-yaml
red
0.8.0

code-spell-checker
str
1.9.0

In the new iteration of VS Code, the "..." menu in source contral has changed such that I now have to access a submenu to choose "Push to..". So now to achieve the same action, I have to click twice instead of once. It's not that big of a deal I suppose, but it is more annoying, and less conveneint.

You can also reach that action via the F1 command palette and by assigning a custom keybinding.
Closing this as designed.

sure, i could work around this issue, but it doesn't change the fact that this change is annoying, making ppl do extra things to accomplish the same task is annoying, whenever i push to origin now, i sigh in annoyance. no, it's not a big deal, yes there is a workaround, but i think it should at least be noted that it's having this impact to ppl, and if a lot of ppl say the same thing, at least there'll be a record if it :)


Dependency resolving error when using docExtensions

When trying to include a custom extension the gradle build fails because org.asciidoctor:asciidoctorj-groovy-dsl:2.0.0 cannot be found. The actual version of asciidoctorj-groovy-dsl is 2.0.2 on mavenCentral - the missing version 2.0.0 was on jCenter which was shutdown in february.
Is it possible to update the dependency?
build.gradle
plugins {
  id 'org.asciidoctor.jvm.convert' version '3.3.2'
}

repositories {
  mavenCentral()
}

asciidoctorj {
  docExtensions file('big.groovy')
}

asciidoctor {
  sources {
    include 'master.adoc'
  }
}

Output with gradle 7.2
> Task :asciidoctor FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':asciidoctor'.
> Could not resolve all files for configuration ':detachedConfiguration2'.
   > Could not find org.asciidoctor:asciidoctorj-groovy-dsl:2.0.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/asciidoctor/asciidoctorj-groovy-dsl/2.0.0/asciidoctorj-groovy-dsl-2.0.0.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 904ms
1 actionable task: 1 executed

Please open this ticket in https://github.com/asciidoctor/asciidoctor-gradle-plugin.
I could imagine that there is already a solution for using a different version of the dsl.


Update auth-code.md

Thanks for your pull request but this package should now be considered deprecated.


Bug fixes and small aesthetic amendments

Many thanks to contributing to nf-core/chipseq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist

[x] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repo
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[x] README.md is updated

Learn more about contributing: https://github.com/nf-core/chipseq/tree/master/.github/CONTRIBUTING.md
Trying to unify processes and logic with atacseq pipeline. Fixed bugs reported here and with atacseq pipeline too. See CHANGELOG.md.

Something fishy going on with Travis CI here. Been on orange now for a few hours and I cant seem to click through to the online tests...Our local storage is broken at the moment too so I cant push a commit either to give it a bump :arrrrrrrrrrghhhh: . Im going to close this and open a fresh PR and see if it resolves the problem.


Update mfi.py

Setting "+mf" and "-mf" to 0.0 forces float typing and avoids a pandas typing error.

Hello @Rydo111
MFI has be revamped not too long ago on the development branch. Please check that the development version works as expected also.
Kind Regards,
KJ

No worries, thanks @twopirllc. I'm a GitHub noob, so still trying to work out how this process happens. I'll poke about and see if I can find the Dev branch.

@Rydo111
All good. I'm no expert either. 👍🏼
Essentially, you checkout the development branch. Edit and submit a PR. I use Github Desktop for the majority of my github management but there are tutorials out there with more details on how/what to do.
Also, no rush


Use SPIRE Controller Manager for quickstart demo

Please provide a description of this PR:
Updates the SPIRE integration demo files to use the SPIRE Controller Manager for workload registration. The k8s workload registrar for SPIRE has been deprecated. The final version will be shipped with the v1.5.4 SPIRE release.
Change Highlights:
README.md

References the Controller Manager instead of the workload registrar
Adds steps to create a ClusterSPIFFEID and label the ingress gateway so it can be registered

clusterspiffeid.yaml

Defines the ClusterSPIFFEID to automatically register workloads with the specified label

istio-spire-config.yaml

Updates the IstioOperator to include an init container and match the Istio/SPIRE integration documentation on master

spire-quickstart.yaml

Removes resources related to the k8s workload registrar
Adds SPIRE Controller Manager resources
Changes are based on the SPIRE Controller Manager demo and the k8s workload registrar -> controller manager migration guide
Updates the spire-server from a StatefulSet to a Deployment for simplification

Resolves #43265

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
6a69f0617898016bbdae1154e334888532619972
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0c9ab65df0a6206194c87eaae75d061f20957181
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint

/test all

This will also need a doc update in istio/istio.io, AFAICT, to update this page: https://istio.io/latest/docs/ops/integrations/spire/

These changes look fine to me but need to be merged with https://github.com/istio/istio.io/pull/12680 and should probably be held until that is ready to merge as well.

@jaellio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
75ffe6aa8fc5e8f6707643eedcfbce91b38f4b7c
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Account settings button

The way of navigating to account settings isn't particularly clear especially if you have a gravatar set up and there is no sense of what you can expect when you do click.
This came up during a client training session a while ago and it just caught me out as well when looking for notification settings.
The issue the client had was that the proximity to 'log out' makes it look like it's related to that action.

Thanks, @tmsndrs - can you mock up a better alternative?

Hi @tomdyson,
As a fairly quick change you could have something along these lines. I'm not a massive fan of having things at the bottom of the viewport like this but didn't want to disrupt any of the other UI elements.

It's not a millions miles away from patterns Twitter and Spotify use. It does introduce an extra click from the current UI but I think it adds clarity that will reduces cognitive load overall.

Thanks, @tmsndrs, looks good to me.

Soooo good: thank you.

What's about this?

Fixed in #2805


Bugfix fix show snapshot issue

Proposed changes
fix show snapshot issue.
when there is no snapshot,  should no result shows.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Fluttertoast.cancel() throwing error on web

I am getting this error Uncaught PlatformException(Unimplemented, null, The fluttertoast plugin for web doesn't implement the method 'cancel', null)  running Fluttertoast.cancel on the web.
What should I do to cancel a toast on the web to avoid having multiple one reloading the page.
My flutter doctor:
[✓] Flutter (Channel unknown, 2.0.6, on Linux, locale en_US.UTF-8)
    • Flutter version 2.0.6 at /home/mde/fvm/versions/2.0.6
    • Framework revision 1d9032c7e1 (3 months ago), 2021-04-29 17:37:58 -0700
    • Engine revision 05e680e202
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /home/mde/Android/Sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /opt/android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio
    • Android Studio at /opt/android/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /opt/android/android-studio
    • Java version OpenJDK Runtime Environment (build 11.0.8+0-b944-P17168821)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /opt/android/idea-IC-203.7717.56
    • Flutter plugin version 53.1.5
    • Dart plugin version 203.7759

[✓] VS Code (version 1.58.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.24.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 91.0.4472.164

Web doesn't have the cancel functionality


396 and 373 denom task and unit rework

Reworks the way we handle and process Denoms and DenomUnits:

Add a new application command update-denoms to update the denoms and denom-units found in the database
Remove the 6 hour scheduled cron task in the main indexer workflow to update the denoms
Remove the code for hitting the denom_metadata endpoint to focus on using vetted assetlists for denom storage
Cleanup and remove unused code

Warning
We will need to run some commands on the production database to make this PR work with the current database.
This PR makes incompatible changes to the models in the following manner:

Remove unique constraint on Name column in DenomUnit
Remove the DenomUnitAlias table entirely since its unused
Rework the uniqueness of the DenomUnit table to make a unique composite index of DenomID and Name

This will fix our current issues in #396.
In order to prepare the DB for this PR, we should do the following:

Drop the DenomUnitAliases table
Drop the DenomUnit table

Closes #396

nice work, lets sync next time your free to drop the db tables


Error in CI Due to Invalid Path

This path needs to be updated to match with the file's new location.
https://github.com/jellyfin/jellyfin-server-windows/blob/eb08e536d84497d1a99aa5cdcb77d5852fbe4ec3/.ci/azure-pipelines.yml#L57

Fixed by #16.


Ark Commander updates the core but does not update the plugins.js

Describe the bug
Ark Commander offers to update the core but it does not update the ~/.ark/plugins.js. As a result, if modules are removed in the core then relay/forger fail to start because they cannot find modules
To Reproduce
Steps to reproduce the behavior:
Launch Ark Commande
Select options to update core
Restart relay and observe logs
I saw things like
1|ark-core-relay | Error: Cannot find module '@arkecosystem/core-transaction-pool-redis'
1|ark-core | Error: Cannot find module '@arkecosystem/core-storage'
Expected behavior
Ark Commander must update the plugins.js, otherwise there is no point in updating the core

Comment from @faustbrian:
The plugins.js doesn't get updated because it can be touchy to do so, both because of people running modified configurations and having 3rd party plugins installed.
You as a node maintainer should know what runs on your server and what configuration is getting modified, it is also your responsibility as the maintainer to make sure your config is up to date with the latest changes as you shouldn't blindly update.
Also this issue should go to https://github.com/ArkEcosystem/core-commander

I do agree that any custom configuration will be overwritten.
But, you have to consider the main use case for "regular" node maintainers:

they do not have custom configs
they want to do periodic updates of the core
they do not know what new dependencies come with core updates and what dependencies get dropped

I would suggest that the Commander has to update the plugins.js but before the update ask user to backup plugins.js in case they have any custom changes there

Is there a way to somehow detected if the plug-in has been touched? Some sha256 of the file when there is a need for migration?
And then warn in the console if the config has been touched and should be updated with detailed info?

Hm one option could be:
Compare SHA256 of previous default plugins.js file in core repo (eg. https://github.com/ArkEcosystem/core/blob/develop/packages/core/lib/config/mainnet/plugins.js )  with new one (once update is avail) and if SHA256 match don't do anything, if there was an update to default plugins.js file see the SHA256 of users local plugins.js.
If SHA256 is same as the one from before update means he is using default config so can be replaced?
If SHA256 differs from before the update means its either modified or running even older version (at least 2 versions back) in that case notify that user's plugin.js file is either a lot older or its been modified by the user. If he wants to update needs to confirm and take the risks (makes a backup of old one as backup)?
I don't see other options here, in any case this is user file and shouldn't just be replaced without some kind of information to the user.


Add option to output to specified file or stdout

plz

I will add the option as argument  -o on relative path

Thanks.
Personally, I would prefer if it defaulted to stdout (optionally disabled with -q quiet mode) with -o as an optional argument for output to file.
This would also allow removing the dodgy system call to cat.

yep, makes sense. I will re-code some parts, it's really a bit sloppy tho ;-)

how to save JSON Format?


Quantify and categorize bad data in FERC 714 demand time series

Using the outlier / bad data identification tools from Tyler Ruggles, as improved by Greg Schivley, categorize and quantify any outlier / zero values that are showing up in the FERC 714 time series, so we can understand how important they are, and devise a strategy for imputing reasonable values.

@ezwelty I cut-and-pasted the time series anomaly categorization routines that @truggles and @gschivley had pulled together into the pudl.analysis.demand_anomalies module which currently only exists on the demand-anomalies branch. You can find more details about what all they've been used to do in the EIA-930 use case at:

https://zenodo.org/record/4116342
https://www.nature.com/articles/s41597-020-0483-x
https://github.com/truggles/EIA_Cleaned_Hourly_Electricity_Demand_Data
https://github.com/truggles/EIA_Cleaned_Hourly_Electricity_Demand_Code

I have restructured Tyler Ruggles' anomalies detection code (here: 5d41da5d5a8b179ca1e97f6062f9f7d4f5d259a2) and checked it against their published EIA results (https://zenodo.org/record/4116342).
For imputation, after some poking around, I decided to try Xinyu Chen's LATC-TNN method (Python code: https://github.com/xinychen/tensor-learning/tree/master/mats, description: https://arxiv.org/abs/2006.10436). The imputations compare very well to the published results, with percent deviations (abs(ruggles_imputed - imputed) / ruggles_imputed) of 3.6% +- 5.3%. Here are some screenshots (light grey is cleaned Ruggles timeseries, dark grey is mine, orange dots mark the imputed values):

Shall we run with this? It would take me a lot longer to figure out how to replicate their MICE method in Python (using say, https://github.com/AnotherSamWilson/miceforest). If there is time, however, I could follow the same validation procedure  (https://www.nature.com/articles/s41597-020-0483-x#Sec10) by nulling good values and comparing them to the imputed values.

Wow, that's awesome! Do you really understand the autoregressive tensor regression method? Or was it just clearly solving the same general type of problem? I looked at the preprint and feel like I only have a very vague feeling of what it's doing... Like it's folding together the different periodicities (days, weeks, years -- do you have to specify these, or does it identify them based on autocorrelations?) on top of each other, within a given time series, which in this dataset would correspond to a particular balancing authority, and estimating what the values should be based on where within each of those periodicities the missing values fall, and what the observed values in each of those periodicities is? But there's no information being communicated between the different time series based on their adjacency in the overall electricity grid / geographic proximity (which I believe is part of the MICE method).
Does it take long to run? How much work do you think it would be to validate the method on some artificially nulled values? Is this only implemented in the notebooks from their repo? It seems like it should get integrated into a Python package. I suspect this is plenty good for our purposes at least initially, and much better than the simplistic stuff I was thinking of doing.
Also nice job organizing the anomaly detection and flagging code! It's so much more uniform now. Not sure I understand all the median-of-medians-of-diffs... but I hadn't dug into the codes before.

This is really exciting to see! Nice work @ezwelty
A few thoughts immediately coming to mind:

@ezwelty, we found that looking at the biases by time of day, day of week, and month of year was very helpful. Making some tables or figures like these would help you spot if the method is having issues capturing any specific time of X features: https://www.nature.com/articles/s41597-020-0483-x/figures/5 (if running on artificially null values takes longer, can just do abs(ruggles_imputed - imputed) / ruggles_imputed) for a quick comparison)
@ezwelty, can this method be run on a single BA in isolation? (sorry didn't read your reference yet)
@zaneselvans, the MICE code does not include any knowledge of geographic proximity. A version of this is essentially calculated as regression coefficients of BA_1 with all other BAs.

@zaneselvans I haven't studied the method deeply, but it is designed for problems like ours: imputing multiple strongly-cyclical, correlated timeseries simultaneously. The implementation (if not also the theory) is limited to 3-dimensions, so in our case balancing authority (BA) x day of year x hour of day. I believe placing the principal, diurnal, cycle on its own dimension offers computational advantage, but the method also captures autoregressive (seasonal) processes along the day axis. Just like with MICE, other balancing authorities are used for imputation by leveraging their correlation (which are likely a function of spatial proximity, but need not be). Yes, the method only exists in Jupyter Notebooks, so I would paste it into PUDL.
The full four years of EIA data (54 BA x 1461 days x 24 hours) takes 472 seconds to run single-threaded and closely matches the MICE results (percent error: 3.4% +- 5.3%). Running each year separately takes only 35 seconds each and gives very similar results.
@truggles Thanks for jumping in! How do those timings compare to your MICE routine? Like MICE, the method does not work on a single BA in isolation, since it relies on the (very valuable) correlation between them. For a single BA, perhaps a Kalman Filter could be used?
As for validation, here is what I've now done:

Extract the length and number of null runs from each cleaned (but not imputed) series.
Insert the same number and length of null runs randomly into the timeseries such that they do not touch existing null values or each other. (The final timeseries has the same run-length distribution of null values, except twice as many). This worked for all but HST, NSB, and WAUW, which have runs that are too long to fit elsewhere, so I did not include them. How does this differ from you insertion logic?
Impute!
Compare imputed values to actual values.

Results are for a single run.
mean percent error: -1.04%
mean absolute percent error: 4.80%

BA
MPE
MAPE

AEC
-0.05%
5.41%

AECI
0.14%
1.06%

AVA
0.54%
2.42%

AZPS
-0.1%
1.74%

BANC
-1.95%
3.68%

BPAT
-0.53%
1.28%

CHPD
1.13%
4.52%

CISO
-0.51%
2.05%

CPLE
-1.24%
2.47%

CPLW
-0.78%
3.48%

DOPD
-0.35%
3.36%

DUK
-0.34%
2.12%

EPE
-0.78%
3.13%

ERCO
0.52%
2.57%

FMPP
0.25%
1.61%

FPC
0.79%
1.66%

FPL
-0.92%
1.87%

GCPD
-0.17%
2.25%

GVL
0.4%
3.89%

IID
-2.59%
6.99%

IPCO
-1.09%
3.41%

ISNE
-0.29%
0.86%

JEA
-0.26%
2.76%

LDWP
-0.47%
2.44%

LGEE
2.3%
3.48%

MISO
-0.01%
0.45%

NEVP
-0.46%
2.33%

NWMT
0.43%
1.94%

NYIS
-0.74%
0.83%

PACE
-0.42%
3.11%

PACW
-0.29%
3.38%

PGE
-1.33%
2.8%

PJM
-0.82%
1.63%

PNM
-0.8%
1.53%

PSCO
-0.55%
2.64%

PSEI
0.51%
2.28%

SC
-1.94%
4.08%

SCEG
1.74%
2.21%

SCL
-2.35%
3.02%

SOCO
0.27%
3.19%

SPA
0.24%
8.09%

SRP
-0.17%
2.26%

SWPP
-0.93%
3.73%

TAL
-0.65%
3.43%

TEC
0.26%
0.85%

TEPC
-6.24%
19.0%

TIDC
-0.12%
2.03%

TPWR
-0.18%
2.72%

TVA
0.72%
2.87%

WACM
-0.49%
2.34%

WALC
-0.97%
6.17%

I was usually running 2hr+ on two cores while my colleagues with 4 cores was closer to 1hr for the full 54 BA x 1461 days x 24 hours. Is your 472s time for a single run?
Your imputation comparison method sounds exactly like ours.
For the performance of MICE:
avg of all MAPE values = 3.5%, with min 1.3% max 11%
avg of all MPE values = 0.33%, with min -0.38% max 4.0%
The results from updating to 5 years of data have a nice csv format if you want to compare: https://github.com/truggles/EIA_Cleaned_Hourly_Electricity_Demand_Data/blob/master/data/release_2020_Oct/imputation_results_and_biases.csv
For the 4 year results you will have to look at table 3 in the paper.
We had trouble imputing TEPC as well, but did not see quite as large of deviations as in your numbers.
MAPE 19% (you) 11.6% (us)
MPE -6.24% (your) 0.76% (us)
Maybe worth a visual inspection, we did not spot any clear "problems" with the imputations in ours.
These results are for a single run? We used an average of 16 "runs" as our final result (each imputed value was averaged across 16 chains (runs) to calculate final imputed result). In this case, the time I gave above is for all 16 chains. You might want to see if results are improving with averaging over a few runs.
The figures you are sharing are for all BAs combined, correct?  Fig 5 is for CISO here: https://www.nature.com/articles/s41597-020-0483-x/figures/5

@truggles

Is your 472s time for a single run? These results are for a single run?

The method is iterative, but it is deterministic as it solves all BA timeseries simultaneously, so it is only run once. It took 472 s for one 4-year block, and 128 s if run as four 1-year blocks. The validation results I am reporting are for the latter, since they are both faster and just as good as the 4-year block results.
My previous report was for one randomly-nulled and imputed dataset. To better match your paper (I think), here are results averaged over 16 randomly-nulled datasets.

BA mean percent error (MPE), averaged across 16 runs, averaged across all BA: -0.32%
BA mean absolute percent error (MAPE), averaged across 16 runs, averaged across all BA: 3.17%

BA
MPE (%)
MAPE (%)

AEC
-0.27
4.16

AECI
0.16
1.87

AVA
-0.04
2.7

AZPS
-0.05
2.88

BANC
-0.26
4.11

BPAT
0.14
1.19

CHPD
-0.95
5.17

CISO
-0.24
1.99

CPLE
-0.39
2.92

CPLW
-0.53
3.46

DOPD
-0.48
3.57

DUK
0.18
2.36

EPE
-0.15
2.88

ERCO
0.08
3.28

FMPP
0.16
1.52

FPC
-0.04
1.94

FPL
0.03
2.18

GCPD
0.01
2.46

GVL
0.11
3.8

IID
-1.77
7.35

IPCO
-0.97
3.5

ISNE
0.03
0.9

JEA
0.24
3.24

LDWP
-0.54
2.58

LGEE
-0.5
2.62

MISO
-0.05
0.46

NEVP
-0.26
2.17

NWMT
0.09
2.31

NYIS
-0.52
1.25

PACE
-0.15
2.88

PACW
-0.1
3.29

PGE
-0.44
2.82

PJM
0.08
2.01

PNM
0.13
1.71

PSCO
0.11
3.34

PSEI
0.18
3.31

SC
-1.82
4.81

SCEG
0.67
2.35

SCL
-0.44
2.38

SOCO
-0.02
2.8

SPA
-1.16
8.49

SRP
-0.44
2.73

SWPP
0.36
2.48

TAL
-0.59
3.48

TEC
-0.79
2.24

TEPC
-2.73
11.8

TIDC
-0.43
2.62

TPWR
-0.23
2.61

TVA
0.12
2.91

WACM
-0.25
2.96

WALC
-1.54
6.59

Boxplots of PME (across 16 runs) for CISO only:

The TEPC results are so bad because the 4-month true gap is often (but not always) followed only a few days later by an additional synthetic 4-month gap. The placement of that second 4-month gap has a huge influence on the validation result.

Your imputation comparison method sounds exactly like ours.

Except how did you squeeze in runs of null values that were too long to fit elsewhere in the series? For example, HST has 648 null values, but no run of good values of that length. In that case, did you split it into two shorter runs?

Oh @ezwelty as you move into applying these methods to the FERC 714, @truggles also wrote up a comparison of our FERC 714 and his EIA 930 hourly demand time series that might be useful: http://thruggles.com/archives/2020/06/2162/comparing-ferc-and-eia-electricity-demand-data/

@ezwelty

Your imputation comparison method sounds exactly like ours.

Except how did you squeeze in runs of null values that were too long to fit elsewhere in the series? For example, HST has 648 null values, but no run of good values of that length. In that case, did you split it into two shorter runs?

Good question. So, not exactly the same. The nulled values were randomly positioned. This could lead to an attempted insertion of null values in a region that is already nulled (therefore not quite doubling the quantity of imputed values), and could also lead to extending the length of already nulled or flagged segments (longer nulled segments that are harder to impute).

The method is iterative, but it is deterministic

Thanks, I did not catch that earlier. The MICE method is non-deterministic. Thus, we run it multiple times  with different random seed values and take the average of the imputed value for each hour as the final imputed value.
For the nulled value comparison, we used a single set of nulled values and ran the MICE code 16 times and took the averages. This is just like we did for the main results.

@ezwelty Maybe you already thought of this, and maybe it doesn't matter, but I was wondering how having the times stored in UTC in the FERC 714 demand data will impact the imputation process. I would expect that the the load curves for different balancing authorities would have a higher correlation with each other if they were being aligned based on local rather than universal time.

@zaneselvans and @ezwelty, we thought about this when we were setting up the MICE process.  Our thinking was that the geographically similar entities are either in the same timezone or +/-1 hour. And, these geographically similar entities are the ones which you want to have correlated to rely on their local info and when imputing.  You do not want entities in Florida correlated with those in California just because they have a similar load shape in general, which could possibly happen if imputing in local time.
I wish we could say we had a conclusive test to point to, but we decided to not go down this route.
Something that would be similar to imputing in local time would be allowing the imputation to use the lag 1, 2, ... and leading 1, 2, ... values from all BAs to determine the best correlation between each BA and all others. Again, we did not test this.

@truggles In the latest versions of the code, the Series class is a multivariate timeseries (rather than a single timeseries) and the anomaly detection is much faster. In particular, the anomalous region flag was taking 3m 44s for your 4-year EIA data. I vectorized it: 115d22d5d9915aabc4aa387e9ea4b671095bc600. It now takes 225 ms. In the process, I believe I fixed a bug in the original code (or, perhaps, in my initial version of the original code), which spuriously flagged values at the very start or end of the series that did not meet the criteria. For example:
WACM

PSCO

SPA

For the nulled value comparison, we used a single set of nulled values and ran the MICE code 16 times and took the averages. This is just like we did for the main results.

In the future, given how sensitive the quality of the imputation is to which values are randomly nulled when long null runs are present (and thus additional ones are being inserted), the imputation validation process should probably be repeated for multiple sets of nulled values.
@zaneselvans The imputer I am using (https://github.com/xinychen/tensor-learning/blob/master/mats/LATC-TNN-imputer.ipynb) provides support for this in the time_lags argument. I did not see any real improvement by extending time_lags=[1] (used for the results I shared above) to something like time_lags=[1, 2, 3]. So I expect the improvement from using local time would be negligible.

@truggles

The nulled values were randomly positioned. This could lead to an attempted insertion of null values in a region that is already nulled (therefore not quite doubling the quantity of imputed values), and could also lead to extending the length of already nulled or flagged segments (longer nulled segments that are harder to impute).

Your null-insertion method results in easier validation  tests, as it allows inserted null runs to overlap each other and existing null runs. Using your null-insertion method, and all 51 balancing authorities, I believe we now have an apple-to-apple comparison. Here are the overall results – mean of the mean for each balancing authority – for 8 runs (each with different simulated null values):

MPE (%)
MAPE (%)

-0.03
2.76

0.01
2.86

-0.24
3.1

-0.37
2.96

0.18
2.84

-0.64
3.4

-0.18
3.06

-0.01
3.14

The mean of these 8 runs is -0.16%,  3.02%. Which actually outperforms the published MICE results!

@ezwelty Not that we should tackle this now since the current setup is already great and we really need to get results back to LBL, but I wonder if there's not a more general way to identify the bad values which should be nulled and imputed, based on their distances from their predicted values using this or another autoregression? Like which kinds of anomalies are we flagging that are statistically identifiable as bad in a generic way (e.g. zeroes and deltas), and which if any are domain specific and need to be handled by us specially (e.g. maybe identical runs)? It seemed like there were a lot of parameters involved in the bad data identification, and I wonder if they're really optimal.  Especially with the 1000x speedup, it seems like many more combinations could be tried to optimize their selection now.
Also, I wonder how much work it would be to get the imputation method to conform to the scikit-learn API so it can be integrated there and used by others more generally. Would the method benefit from the more generalized parameter grid search that's available in scikit-learn?

@ezwelty, nice work improving the speed with the anomaly detection portion of the code! I do not think the bug you were pointing to was in the original code (I see two BAs with anomalous values at the start in our old results, PSCO and GCPD, both cases make sense to me), but I'm glad you fixed it either way.

In the future, given how sensitive the quality of the imputation is to which values are randomly nulled when long null runs are present (and thus additional ones are being inserted), the imputation validation process should probably be repeated for multiple sets of nulled values.

You are pushing me to remember all the details, thank you! Looking back at our paper, we actually created 16 new nulled data sets and ran each of those 16 data sets through the MICE process.  Thus, the MPE and MAPE results I stated before are averaged over the results of 16 data sets. It is still correct that the MICE process for each data sets uses 16 instances of MICE to calculate the results for that single data set.
Your imputation results look good to me. I am excited to hear how the next steps in the process go and learn more about the LBL project when you all are done.


ci: Avoid null pointer exception in non-pr builds

test-only --focus="K8sDatapath"

Merging, since this fixes master


Install to /usr/local/, not /usr/

The app is not managed by the host package manager. It should thus be installed to /usr/local/ and not /usr/.
Also doesn't run on Silverblue and other immutable distriutions as a result.
refs: https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard#Directory_structure

Hello @Aman9das
Thank you for taking your time and contributing to App Fleet.

Also doesn't run on Silverblue and other immutable distriutions as a result.

I was on Fedora Workstation so this didn't hit me that time.
I'll review your pr as soon as possible.


Doxygen Not Updating

The Doxygen documentation seems not to be updating.

Bump

Bump @AaronPerl

Fixed. Thanks, Aaron!


Fake Gopher violates Gopher design rules

Do you want to request a feature or report a bug?
Report a problem arguably more serious than a bug.
What did you do?
Looked at the Gopher image in the README at https://github.com/containous/traefik, more specifically this one.
What did you expect to see?
A real Gopher.
What did you see instead?
A fake Gopher.
Output of traefik version: (What version of Traefik are you using?)
N/A
What is your environment & configuration (arguments, toml, provider, platform, ...)?
N/A
If applicable, please paste the log output at DEBUG level (--logLevel=DEBUG switch)
N/A
The problem
The purported gopher in the referenced image is in violation of the de facto official Go Gopher model sheet included in this presentation by Renee French.

The particular "gopher" in the referenced image is clearly holding his two sticks using not nubs, but hands or something similar thereof. It's quite clear that there's some kind of "thumbs" involved, alongside two "fingers" on each "hand". I suspect these are badly designed gloves, in an attempt to cover up what are not real Gopher nubs.
In the presentation by Renee French, she explains that there are two ways the gopher can hold things/objects; "under the arm nub, and by touch". I think this is an established fact by now, and it also holds true with any other Gopher image by Renee that I've seen. Please see the page 26-27 in the PDF for the model sheet, and page 32-36 for specifics.
I argue that in addition to the aforementioned pictorial evidence of this not being a true Gopher, the fact that if it was a true Gopher he would have decided to hold the sticks either under his arm nubs or, more likely, using the adhesive touch technique, clearly shows that this is an imposter.
In conclusion, the fake Gopher should be replaced with a real Gopher, using real nubs and proper holding techniques (which only real Gophers can perform).

The whole legal team is on this ⚖


fix: improve forkchoice

Motivation
Improve forkchoice
Description
Some different small optimizations for forkchoice:

updateTime() is designed to called once per slot and we do that per clock slot, so no need to do that again when producing block. No need to process queued attestations again in the same slot because:

current slot attestations keeps staying in the queue
old attestations should be applied to the votes already

improve processAttestationQueue():

right now we delete queued attestations one by one in a Set, as metrics show there could be more than 30k of them per slot on the test mainnet node
instead of that just partition queued attestations by slot then root, then we can delete them way more efficiently. This also helps save us a little memory

improve metrics: right now we label get_head() metric by entry point and we have no idea for the time to recompute head for prepare_next_slot vs import_block, we should label by "caller" instead
improve computeDeltas():

reuse deltas array over time
handle newBalances === oldBalances to speed up the computation a little bit

Metric look like (will add in a separate PR):

:tada: This PR is included in v1.23.0 :tada:


Introduce concept of Preview Features as a feature stabilization period

Currently Scala 3 has a concept of Experimental Feature - a feature that is introduced to standard library / language syntax but is prone to changes, might be unstable, break binary compatibility or be even removed in the future.
Currently our process does not describe well the stabilization period of currently experimental features. Both instability and lack of proper information might discourage users from trying out the new features which might reduce amount of feedback and can lead to lead maintaining flowed designs.
During the last Scala Core team meeting it was proposed to introduce a Preview Features as a interim stage between experimental and stable features. These might be treated as an early access to fully implemented, but not yet fully stabilized features that might introduce minor changes.

Stage
Name
Description
Usage

Stage 0
Early experimental / PoC
Feature is implemented behind a flag, awaits approval from SIP committee  Highly prone to changes.  Might be removed or redesigned at any moment
Requires explicit -experimental + -experimental.feature flags.  Might requiring building compiler from a separate branch before usage.

Stage 1
Experimental
Feature has been accepted by the SIP committee but is still under active development. No source/binary guarantees. Might change, be removed or redesigned based on feedback from users. Not recommended to be used on daily usage by users, but encouraged to try out
Requires explicit -experimental + -experimental.feature flags

Stage 2
Preview
Feature has been fully implemented and would become stable after evaluation period. It is not going to be removed at any later point. Does not guarantee binary compatibility, but it is unlikely to introduce breaking changes. It can be adopted (in limited scope) to the needs of the users based on feedback gathered during evaluation period.  It can be used by users that don't require binary compatibility e.g. applications but not libraries.
Enabled using --preview flag (optionally also --preview.feature flag)

Stage 3
Stable
Feature has been proven to not change during evaluation period. It becomes a stable feature and does guarantee source/binary compatibity in all the future versions
Enabled by default

All of the implemented features should follow the staging through experimental -> preview -> stable staging.  Advancement between the 2 stages should happen in the first release of next minor release of Scala.
The compiler should track usage of preview features using mechanism similar to the one used by experimental features. It might be considered to either enable preview features selectively or to allow usage of all preview features when compiling under --preview mode.

https://github.com/scala/scala3/pull/22037#discussion_r1860411436

I am not sure what to do here. Java has previews, would that help?

Java previews probably don't apply to Scala development process well. The Java previews (and incubator and experimental features) are controlled not only on compile time, but also on run time. All preview features are enabled using single switch --enable-preview, both on compile time and run time. Incubator features are enabled individually on run-time using switches like --add-modules jdk.incubator.vector or --add-modules jdk.incubator.concurrent. Preview features are allowed to be somewhat tighly integrated with rest of codebase, since preview features are expected to be near final state. Incubator features reside in their own incubator module under parent package for all incubating features (jdk.incubator) and when exiting incubation they change their module name and package names. Incubator features are designed to be loosely coupled to rest of codebase, so they can be easily removed and they don't slow down regular development of non-incubator features.
Scala doesn't control the run time class loading, so it can't produce same errors as Java preview or incubator features. Scala could emulate some of the controlling functionality, by checking for flags enablement in static class initializers and conditionally throwing an exception.
P.S. I'm writing from memory and haven't spent a lot of time for fact-checking myself, but there shouldn't be significant inaccuracies.

This would be a very welcome change!
I hope it can be accompanied by a living documentation page with a table like this:

Implementation
Experimental
Preview
Stable

CanThrow capabilities
3.0.0
3.1.0
N/A
N/A

Erased definitions

Named Type Arguments

Numeric literals

Capture Checking

Tupled Function

Main Annotation

Safe initialization

3.3.4

Named tuples
3.5.2
3.6.1
3.6.2
3.7.0?

for all the experimental features to provide minimal versions where it's available/stabilised. Not necessarily a commitment, but a good view of where the language is at.
I struggle to fill the rest of the table as I have no idea where to get information on any of the cells in it.
I also added safe initialisation as it is not exposed as experimental feature, but the documentation marks it as experimental.

This would be a very welcome change!
I hope it can be accompanied by a living documentation page with a table like this:

Implementation
Experimental
Preview
Stable

CanThrow capabilities
3.0.0
3.1.0
N/A
N/A

Erased definitions

Named Type Arguments

Numeric literals

Capture Checking

Tupled Function

Main Annotation

Safe initialization

3.3.4

Named tuples
3.5.2
3.6.1
3.6.2
3.7.0?

for all the experimental features to provide minimal versions where it's available/stabilised. Not necessarily a commitment, but a good view of where the language is at.
I struggle to fill the rest of the table as I have no idea where to get information on any of the cells in it.
I also added safe initialisation as it is not exposed as experimental feature, but the documentation marks it as experimental.


Fix cache permissions

After moving to running under a composer user the cache directory permissions got messed up:

Removing the volumes in the image is the fix, as they otherwise get mounted as root.
I also took the time to remove some layers and give the user a group too.

There are still permission problems when trying to use the container as the composer user does not have  permission to modify files on the host file system using the volume mapping ~/.composer:/home/composer/.composer

So I'm not sure how you were testing, but I've added some tests, that fail on master due to the volume statments, but pass on this branch.
Any steps I could follow to reproduce it?

#23 needs to be merged btw too, some changes to composer mean the image is currently missing a PHP extension.

I've merged #23 so this i now conflicted. Once that's sorted out I'll test it again and we can talk about any failures.

:boom: finally got tests to pass. I've had to revert back to the root user though, volumes and non-root really don't seem compatiable.

make test now prompts for a password for sudo. Giving root access to a test make me uncomfortable. Is there an alternative way to deal with cleanup?

Doesn't actually seem to be required locally, but does on Travis, odd differences in the volume mounting setup I suppose. I've removed it and added sudo before the make test in travis.yml.
Of note, this also fixes the wget ssl errors that started recently.


[vcpkg] Revise the file lists script

What does your PR fix?

Modifies the output to print :<triplet> after each filename.
This is relevant for cross builds. Before this change, DLL might be listed even for x64-windows-static due to the x64-windows host triplet. This problem includes vcpkg CI. Not to mention mingw on linux...
Modifies the output to not blur the location of headers.

VCPKGHeadersDatabase.txt now only list contents in the top-level /include subtree.
This is the only path directly available with build system integration. Other subtrees are still in VCPKGDatabase.txt.
But the actual problem was that files in include dirs in other subtrees of a port were listed in VCPKGDatabase.txt as if they were in the top-level include dir. This is a source of confusion, example:
lib/glib-2.0/include/glibconfig.h appearing as glib:/include/glibconfig.h in VCPKGDatabase.txt, cf. https://github.com/microsoft/vcpkg/issues/20483#issuecomment-947503700 :boom:

Which triplets are supported/not supported? Have you updated the CI baseline?
all / not needed

Does your PR follow the maintainer guide?
yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
not needed

Example output

$ python3 scripts/file_script.py ./installed/vcpkg/info/

$ grep zlib: scripts/list_files/VCPKGDatabase.txt
zlib:x64-mingw-dynamic:/bin/libzlib1.dll
zlib:x64-mingw-dynamic:/debug/bin/libzlibd1.dll
zlib:x64-mingw-dynamic:/debug/lib/libzlibd.dll.a
zlib:x64-mingw-dynamic:/debug/lib/pkgconfig/zlib.pc
zlib:x64-mingw-dynamic:/include/zconf.h
zlib:x64-mingw-dynamic:/include/zlib.h
zlib:x64-mingw-dynamic:/lib/libzlib.dll.a
zlib:x64-mingw-dynamic:/lib/pkgconfig/zlib.pc
zlib:x64-mingw-dynamic:/share/zlib/copyright
zlib:x64-mingw-dynamic:/share/zlib/usage
zlib:x64-mingw-dynamic:/share/zlib/vcpkg-cmake-wrapper.cmake
zlib:x64-mingw-dynamic:/share/zlib/vcpkg_abi_info.txt
zlib:x64-linux:/debug/lib/libz.a
zlib:x64-linux:/debug/lib/pkgconfig/zlib.pc
zlib:x64-linux:/include/zconf.h
zlib:x64-linux:/include/zlib.h
zlib:x64-linux:/lib/libz.a
zlib:x64-linux:/lib/pkgconfig/zlib.pc
zlib:x64-linux:/share/zlib/copyright
zlib:x64-linux:/share/zlib/usage
zlib:x64-linux:/share/zlib/vcpkg-cmake-wrapper.cmake
zlib:x64-linux:/share/zlib/vcpkg_abi_info.txt

$ grep zlib: scripts/list_files/VCPKGHeadersDatabase.txt
zlib:x64-mingw-dynamic:zconf.h
zlib:x64-mingw-dynamic:zlib.h
zlib:x64-linux:zconf.h
zlib:x64-linux:zlib.h

I hope my colleague will review this further.

Ping @BillyONeal

@ras0219 @ras0219-msft @vicroms @dan-shaw Does this have impact on the website?

Thanks for the updates!

We will likely need to change the website to account for this, but it's still a needed change.

@ras0219-msft Daniel said there would be no effect in Teams chat.


Fix a few low-hanging findbugs issues

Coverage remained the same at 27.444% when pulling 32aca989ef56dbfa982073a955524bab0f12e1fc on mars-lan:findbugs into e3a87e02d3764d96aa9c586f719618b42a8aa128 on linkedin:master.

Coverage remained the same at 27.444% when pulling 07e052d91db687b79f783a8d2a6911ed7e3a0ba0 on mars-lan:findbugs into<PHONE_NUMBER>5c7b89f2f78d9bfa70f5fa669cbb0e on linkedin:master.


Sort spaces on the sidebar by number of followers

On the left sidebar, the list of the space you following should be sorted by number of followers.

I think it would be better to let the user decide the order by integrating draggable. I also don't see any benefit for the user ordering these spaces by followers.

Ok agree