Show instance for Json

Was it a deliberate decision to remove the Show instance for Json in https://github.com/purescript-contrib/purescript-argonaut-core/commit/83dd71ff982a68176c42b0cae06932c3cd79a6a1? I stumbled upon this due to some broken tests that were using (===) from purescript-strongcheck, which relies on Show.

It was deliberate, yeah. It breaks the idea of Show printing something equivalent to the PureScript code that constructs it.

That's what I feared ;-) Do you have an example of where the Show instance might pose a problem?

@menelaos I don't believe it's necessarily that Show causes a problem in the code produced, but rather than the point of the Show type class is for debugging and printing out a PureScript representation of data and types rather than for formatting strings.
If you want to 'print' JSON values use the stringify function, which is further described in the MDN documentation (if you need it :))

Let me try to make an argument for bringing back the Show instance for Json.
I (and I imagine most people?) mainly use Show for debugging.  In order to show a Json, you have to call stringify.  While this isn't a huge problem, it is a small papercut that I get again and again when working with PureScript.  Adding a Show Json instance would remove this small papercut for me.
@garyb and @thomashoneyman say above:

It breaks the idea of Show printing something equivalent to the PureScript code that constructs it.

the point of the Show type class is for debugging and printing out a PureScript representation of data and types rather than for formatting strings.

However, the docs on Show say the following

While not required, it is recommended that for any expression x, the String show x be executable PureScript code which evaluates to the same value as the expression x.

I think the "while not required" is important.  While it would be great if Show Json could produce valid PureScript code, Show Json is still pretty helpful for debugging if it doesn't produce valid PureScript code.
Having Show produce valid code is pretty important in the Haskell ecosystem because of the prevalence of Read.  And non-conforming instances are one of the reasons for libraries like pretty-simple.  However, there is no Read in PureScript, so I don't know how strong of a reason this is for PureScript.
I imagine some people like to Show data types, and then copy and paste them back to the repl to play around with them.  It is unfortunate that you can't do this with Show Json, but removing the instance isn't helping the situation.  It wouldn't be possible to copy-and-paste the output JSON whether you use Show Json, or just stringify.
Given this, I think having the Show Json instance slightly reduces the small repeated mental overhead of having to import stringify.

@cdepillabout i agree with you. It's more than this though, it's not just about importing stringify but when you have a type like
data MyType = MyType String Json

You have to write a custom Show implementation for it because the generic one doesn't work. And show for record breaks all together once you put a json type in.
data MyRecord=
  { name :: String
  , my_json :: Json
  }

There are always ways around it, like newtyping and wrapping/unwrapping the new type everywhere in your code.
I prefer the minimal amount of friction when debugging and i'm not particularly concerned how the output looks like. Any output is better than having no Show instance.
One maintainer said he had no problem adding a proposed implementation https://github.com/purescript-contrib/purescript-argonaut-core/issues/37#issuecomment-543862069 Let us re-open the relevant issues until other maintainers respond and after that a PR can be made.


fix: fix lookup speed on nlog debugger

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix
What is the current behavior? (You can also link to an open issue here)
To use delegate capture when looking up splat 2 nlog log levels. This addresses part of #260
Also at the moment the Nlog logger level is independent of the Splat logging.
What is the new behavior (if this is a feature change)?
Now use a list of mapping items and also a immutable dictionary.
Now iterate to determine the current log level.
What might this PR break?
Hopefully nothing.

This should have 1.44 Log C (where C is the count) efficiency.


Failure to init Observable Framework

I get the following error during npm init @observablehq:
Console output (same as in the picture)

node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for<EMAIL_ADDRESS>    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)
    at new NodeError (node:internal/errors:405:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
    at defaultLoad (node:internal/modules/esm/load:101:20)
    at ModuleLoader.load (node:internal/modules/esm/loader:416:13)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:287:22)
    at new ModuleJob (node:internal/modules/esm/module_job:63:26)
    at #createModuleJob (node:internal/modules/esm/loader:311:17)
    at ModuleLoader.getJobFromResolveResult (node:internal/modules/esm/loader:264:34)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:250:17)
    at async ModuleLoader.import (node:internal/modules/esm/loader:335:23) {
  code: 'ERR_UNKNOWN_FILE_EXTENSION'
}

Node: v18.19.0
npm: 10.4.0
OS: Mac 14.1.1
Device: M1 Pro

Hi @abstractalgo. I see you're using Node version 18. Framework only supports Node 20.6 or later, as explained in our getting started guide. Can you try this again in an updated Node? If you need to maintain multiple versions of node, I can recommend fnm.

Works on Node 20.11.1 👍  Thanks.


Timer task is not working when passing the onTriggerFunction within an object

Description:
When instantiating the timer, we need to pass the onTrigger and onError function pointers. In case, if the timer is used within an object, and the timer function pointers are for those callbacks are defined within an object, then onTrigger function is not getting called and there are no errors logged.
Steps to reproduce:
Sample ballerina code to test this bug. As you can see the onPushSummaryTrigger function is defined within the function and when you run this sample code, you can notice that the function is not invoked. But if we pass nonObjectTrigger function for the timer which is defined outside the object, then  the function will be getting invoked.
import ballerina/task;
import ballerina/io;
import ballerina/runtime;

public type MyObject object {
    private{
        task:Timer? timer;
    }

    public new(){
        timer = new task:Timer(onPushSummaryTrigger, onPushSummaryError, 3000, delay = 0);
        timer.start();
    }

    public function onPushSummaryTrigger () returns error?{
        io:println("Push Summary Triggered....");
        return ();
    }

    public function onPushSummaryError(error e){
        io:println(e);
    }
};

function nonObjectTrigger () returns error?{
        io:println("Push Summary Triggered....");
        return ();
}

function main(string... args) {
    MyObject test = new;
    runtime:sleep(10000);
}

@sinthuja
To instantiating the timer, you can pass the onTrigger and onError function pointers as follows in case if the timer is used within an object, and the timer function pointers are for those callbacks are defined within an object.
Approach 01
import ballerina/task;
import ballerina/io;
import ballerina/runtime;

public type MyObject object {

    private task:Timer? timer = ();

    public function __init() {
        self.timer = new task:Timer(() => self.onPushSummaryTrigger(), (), 3000, delay = 0);
        self.timer.start();
    }

    public function onPushSummaryTrigger() returns error? {
        io:println("Push Summary Triggered....");
        return ();
    }

    public function onPushSummaryError(error e) {
        io:println(e);
    }
};

function nonObjectTrigger () returns error?{
    io:println("Push Summary Triggered....");
    return ();
}

public function main() {
    MyObject test = new;
    runtime:sleep(10000);
}

Approach 02
import ballerina/task;
import ballerina/io;
import ballerina/runtime;

public type MyObject object {

    private task:Timer? timer = ();
    function () returns error? onPushSummaryTrigger = function () returns error? {
        io:println("Push Summary Triggered....");
        return ();
    };

    public function __init() {
        self.timer = new task:Timer(self.onPushSummaryTrigger, (), 3000, delay = 0);
        self.timer.start();
    }

    public function onPushSummaryError(error e) {
        io:println(e);
    }
};

function nonObjectTrigger () returns error?{
    io:println("Push Summary Triggered....");
    return ();
}

public function main() {
    MyObject test = new;
    runtime:sleep(10000);
}

However, it is bit inconsitent that functions defined outside the object can refer as pointer but the functions defined within the objects. I've created issue[1] to fix that inconsitency.
[1]. https://github.com/ballerina-platform/ballerina-lang/issues/12768


Add rule to remove assert calls

Closes #2
Add a new rule remove_assertions that remove calls to the assert global functions

[x] add entry to the changelog

If removing the assert() results in an empty block, will that block be removed? If there's a simple boolean expression gating the block, will that also be removed?


there is no SftpAdapter class

Class 'League\Flysystem\Sftp\SftpAdapter' not found
I have this error message when I try to visit my homepage

Please note that you have to install the dependencies via composer install first:
curl -sS https://getcomposer.org/installer | php
php composer.phar install

thank's


✨ optimistically regenerate form initial values on successful submit

fixes #216
what this
When a submit handler is successful we always want the form to be marked clean and have it's initial values updated as soon as possible. In some cases this might not be able to happen implicitly if the submit function does not also update
worries
Weird stuff could happen if you do the update and then somehow the parent component is re-rendered and gives us new initialValues that don't match (as we would reinitialize the form again). I can't think of a state where that's wrong though.
how 2 test

checkout repo and branch
yarn build && yarn link
go to your consuming project
yarn link @shopify/react-form-state

I'm going to close this for now after a chat with @lemonmade about not exposing ways to do this that aren't updating the props.


[ci skip] adding user @suzannejin

Hi! This is the friendly automated conda-forge-webservice.
I've added user @suzannejin as instructed in #9.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.

User is already proposed to be added in #8. It is preferred that first time contributors be added based on a PR contribution, rather than through the bot command. Closing.


Revert "Separate Jenkins Parameters into Categories "

Reverts AdoptOpenJDK/openjdk-tests#2375

Temporarily revert while we wait for openj9 Jenkins to get a plugin installed.


Little typos in README.md code example

import { simulte } from 'sm2-plus'
simulate(0.3, 0.1);

Trying to import named export simulate as simulte.

const testWord = {
  word: 'test',
  update: TODAY - 17,
  difficulty: 0.2,
  interval: 100,
};

Last property in the object should not end with a ','.

import { simulte } from 'sm2-plus' should be changed to import { simulate } from 'sm2-plus'
I don't get the point of the ending a thing, please elaborate it?

@lo-tp
const testWord = {   word: 'test',   update: TODAY - 17,       difficulty: 0.2,   interval: 100, };
interval: 100, should be interval: 100
Thanks 👍


A couple of sample app ideas

A useful addition to the document is a couple of ideas of using simplechain. Some skeletal code would be even better.

https://medium.com/yope-chain/30-things-you-can-do-with-a-blockchain-b23b2ab39664

https://cointelegraph.com/news/6-unconventional-uses-of-the-blockchain


Announcement! new web server released GAPI! Thank you voyager! :)

Hello there guys i am in love with Voyager and i decided to integrate it with my framework it is called @Gapi and you can find more information about the whole namespace here:
https://github.com/Stradivario/gapi
Gapi-Voyager module is part of this namespace and it can be found at this repository:
https://github.com/Stradivario/gapi-voyager
The main idea behind this Framework is to provide Angular 2+ environment where you can write singleton typescript classes with Dependency Injection and many more features you can read about inside repo readme.It is using GraphQL this is where the name come from GraphQL API aka. GAPI :))
To import graphql voyager inside @Gapi server you need to do the following:
import { GapiModule } from '@gapi/core';
import { GapiVoyagerModule } from '@gapi/voyager';

@GapiModule({
    imports: [GapiVoyagerModule]
})
export class CoreModule { }

Then you can open http://localhost:9000/voyager it will introspect http://localhost:9000/graphql by default.If you want to specify configuration following example will help you:
import { GapiModule } from '@gapi/core';
import { GapiVoyagerModule } from '@gapi/voyager';

@GapiModule({
    imports: [
        GapiVoyagerModule.forRoot({
            path: '/voyager';
            endpointUrl: '/graphql';
        })
    ]
})
export class CoreModule { }

You are done! :)
This framework is based on HAPI and you can write Hapi Webserver with Gapi and use Plugins provided by Hapi framework.
Following example will help you to understand how to integrate Hapi plugin inside Gapi.
https://github.com/Stradivario/gapi-voyager/blob/master/development/gapi-voyager-plugin.ts
import { GapiVoyagerConfig } from "./gapi-voyager-config";
import { GapiModule, GapiHapiPlugin, GapiHapiPluginInterface } from '@gapi/core';
import renderVoyagerPage from 'graphql-voyager/middleware/render-voyager-page';

@GapiHapiPlugin()
export class VoyagerGapiHapiPlugin implements GapiHapiPluginInterface {
    name = 'VoyagerGapiHapiPlugin';
    version = '1.0.0';

    constructor(
        private config: GapiVoyagerConfig
    ) {}

    async register(server, options) {
        server.route({
            method: 'GET',
            path: this.config.path,
            handler: this.handler.bind(this)
        });
    }

    async handler(_request, reply) {
        return await renderVoyagerPage({ endpointUrl: this.config.endpointUrl });
    }

}

Regards,
Kristiyan Tachev

@Stradivario nice job here 👍
We're glad you like Voyager and integrated it into your framework!
Thanks so much!


Tests: Confirm EOA

Perform manual tests for the "Confirm EOA" feature

should comment help correctly with new information for the wallet command

/help

should skip setting wallet when there is no signature

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2

should skip setting wallet because the signature is invalid

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2 0x2e33629bd9480b92e5ebe2665f5ffbb9a57c303337d0ced56eb18b91f077812623fc9dc1c44f62366c140f57352fd2cfd0808919a59537d766ec615ce4e595451a

should skip setting wallet when signature is correct but message signed is not ubiquity/ubiquibot

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2 0x76ff636cca236e5a7805132a8272e7711f10748f6bee0252de4052eaf525a5e3207b4dadabe677ed94a638e1cb996a1d72c08d2d22d2409bb0fcdd93f802a4331b

should set the wallet when wallet and signature are correct

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2 0x2e33629bd9480b92e5ebe2665f5ffbb9a57c303337d0ced56eb18b91f077812623fc9dc1c44f62366c140f57352fd2cfd0808919a59537d766ec615ce4e595451c

should set the wallet when the wallet is correct, but the wallet is not a checksum address

/wallet 0x1f9fcc0e84dc2094499b848ae37cd6a51db03ff2 0x2e33629bd9480b92e5ebe2665f5ffbb9a57c303337d0ced56eb18b91f077812623fc9dc1c44f62366c140f57352fd2cfd0808919a59537d766ec615ce4e595451c

should skip setting wallet when the signature is not created by the given wallet

/wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 0x2e33629bd9480b92e5ebe2665f5ffbb9a57c303337d0ced56eb18b91f077812623fc9dc1c44f62366c140f57352fd2cfd0808919a59537d766ec615ce4e595451c

/wallet vitalik.eth 0x2e33629bd9480b92e5ebe2665f5ffbb9a57c303337d0ced56eb18b91f077812623fc9dc1c44f62366c140f57352fd2cfd0808919a59537d766ec615ce4e595451c


What is gold label Yi?

Read the paper and the gold label Yi trouble me . I hope you can explain it.Thanks

what do you mean? Yi is the gold labels that indicate that some sentences are annotated to be summary sentences for training.


Fixed non working admin download

Motivation and Context
Admins should be able to download VODs from the admin panel.
Description
Now every VOD that is displayed on the admin panel is already signed with a corresponding jwt token which allows downloading of the vods.

Some more changes than expected because worker was also reverted to last working version of worker so the latest version of the worker is also functional. Everything in the worker/ directory is just reverting changes.

Sorry for that, now it should be cleaned up


chore: BlockSite Extension added #1307

#1307
Closes #1307

Description
BlockSite Extension added to DB Successfully.
Screenshots

Checklist

[x] My code adheres to the established style guidelines of the project.
[x] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.

@TusharMinche The title can have at max 2 words

@TusharMinche The title can have at max 2 words

Okey I will change that.


_DAY_NAMES definition seems not correct

It starts with a "" and end with "sunday"
But according to comments and the weekday logic, the first one should be "sunday"

I think this is due to the built in OS.get_datetime_from_unix_time returning weekday as an int ranging from 1-7, so it's easier to simply set the index 0 to empty - I do the same thing for _MONTH_NAMES and _DAYS_IN_MONTH - have you been seeing an issue in your project? If so what version of Godot are you using?

According to the code, I think Time.get_unix_time_from_datetime_dict is used here and there
and according to
https://docs.godotengine.org/en/stable/classes/class_time.html#methods
The Weekday enum is 0-6
Easy to reproduce: just keep add_days(1) and check the weekday_name field

Ah - maybe this changed from Godot 3 to Godot 4. I'll take a look and push a patch for the 4.0 version later today. Thanks @YinHu1985

@YinHu1985 This is now fixed in 1.0.2 (Godot 4)


[protobuf][grpc] Build error

Host Environment

OS: Windows 10 Pro for Workstations
Compiler: MS Visual Studio Pro 2022 17.2.3

To Reproduce

Apply manifest file.
./vcpkg install

Manifest File: vcpkg.json
    "name": "projectFoo",
    "version":  "0.2",
    "dependencies": [
        {
            "name": "protobuf",
            "default-features": true,
            "features": [ "zlib" ]
        },
        {
            "name": "grpc",
            "default-features": true,
            "features": [ "codegen" ]
        }
    ],
    "builtin-baseline": "4ffe8b020f04c3acbd5883566672c19a022c4394",
    "overrides": [
        {
            "name": "protobuf",
            "version": "3.18.0"
        },
                {
            "name": "grpc",
            "version-string": "1.41.0"
        }
    ]
}

Failure logs
-- Building x64-windows-static-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: C:/source/workspace/src/ProjectFOO/ExternalDependencies/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j45
    Working Directory: C:/source/workspace/src/ProjectFOO/ExternalDependencies/vcpkg/buildtrees/protobuf/x64-windows-static-dbg
    See logs for more information:
      C:\source\workspace\src\ProjectFOO\ExternalDependencies\vcpkg\buildtrees\protobuf\install-x64-windows-static-dbg-out.log
      C:\source\workspace\src\ProjectFOO\ExternalDependencies\vcpkg\buildtrees\protobuf\install-x64-windows-static-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:106 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:44 (vcpkg_build_cmake)
  buildtrees/versioning_/versions/protobuf/19c2bf45c235e6126161bae36aa7ff7e1fcda479/portfile.cmake:47 (vcpkg_install_cmake)
  scripts/ports.cmake:145 (include)

Error: Building package protobuf:x64-windows-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+protobuf
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[protobuf]+Build+error
including:
  package: protobuf[core,zlib]:x64-windows-static -> 3.18.0
    vcpkg-tool version: 2022-03-09-1affd32f93b299d5a907816c328ca3ededb73a7e
    vcpkg-scripts version: fad0644ad 2022-03-14 (3 months ago)

install-x64-windows-static-dbg-out.log
ninja: build stopped: .

install-x64-windows-static-dbg-err.log
ninja: error: mkdir(CMakeFiles/libprotobuf-lite.dir/C_/source/workspace/src/ProjectFOO/ExternalDependencies): No such file or directory

Additional context
VCPKG Manifest project that relies on pinned-versions of protobuf and grpc. The build has been working for weeks without issue. Unexpectedly started getting 'unresolved external symbol' linking errors related to protobuf yesterday, after hitting 'build' or 'rebuild' in VS. Shelved/Reverted my recent changes but the error persisted. Then tried re-running cmake and vcpkg fails.

VS linking errors started a few hours after upgrading VS2022 from 17.1.x to 17.2.3. (but it worked for a few hours).
However I re-opened the project in "VS2022 Preview" that was previously working and hasn't been used in a few months and got the same error.
Then deleted my project's cmake generated ./build/ folder and ran our invoke-cmake powershell script (basically it ensures vcpkg is available and then runs cmake).

Invoke-Cmake was using cmake 3.15.5, and was reporting the Visual Studio 16 (2019) generator
I tried re-pointing the script to cmake 3.22.0, and noticed the generator changed to Visual Studio 17, errors messages were the same.

Next deleted the vcpkg install in a .\ExternalDependencies\ sub-folder of my project. Re-ran invoke-cmake, which would install vcpkg from git, then run cmake for the project.
Finally tried running vcpkg install --debug and got a very long output.

Two log files attached, one has output from several runs, one has the long debug output.
The 'debug' log is the only one I've seen that reported the error being in GRPC instead of Protobuf.
vcpkg_install_logs.log
vcpkg_installdebug-grpc-fail.log

After looking at this issue: https://github.com/microsoft/vcpkg/issues/15399 , and comparing the pathname from @JackBoosY response to my pathnames, I got the same 261 characters; it's possible the real pathnames are too long. (Unfortunately, I had to redact the project name from the logs). However it's been working in the current location for over 3 months. There has been no notable change in my directory structure for some time.
I copied the project to a top-level folder c:\src_test\ and after almost an hour, it succeeded, and then the project then built successfully in Visual Studio. This exists as part of a larger enterprise project though and I can't just change the real path significantly. If it was working, why did it break and how do we fix it the way it was?
It seems I encountered the same error in the same place on March 9, and it mysteriously resolved itself after a few days. We can't just have this transient build-break coming and going though. This is a problem I need to resolve. https://github.com/microsoft/vcpkg/issues/23462
Suggestions? How can I fix or investigate further?

Error occurs if the total path exceeds 260 characters, which can be resolved in one of two ways:

https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later
Add install option --x-buildtrees-root=<SHORTER_PATH>

Thanks for the solution, adding the following to the top of my CMake (before the first project() statement) seems to have worked. I'm going to test this as a long-term fix.
# Prevent VCPKG "paths too long"
set (VCPKG_INSTALL_OPTIONS "--x-buildtrees-root=../../vcpkg_buildtrees/")

As I said, when I tested running cmake/vcpkg in c:\src_test\ it took nearly an hour, I think it was fully updating my AppData\Local\vcpkg\archives\. When I came in today, and went back to my original project directory and ran .\Invoke-Cmake it decided to restore packages from there (which it wasn't trying yesterday) and everything magically worked again.
What I surmise is once the AppData\Local\vcpkg\archives\ is updated somehow, I might be safe for months and only when vcpkg decides to update that archive again and actually builds the ports does it encounter the path-to-long error. Would you agree?

@Sand2Silicon Any update involving this port may cause cmake to create several more levels in the binary dir, causing the path length to exceed the limit.
Feel free to close this issue if it's resolved.

Feature Request: What I wish the error message said:

Attempted to create a generated path resolving to:
c:\Too\long\path\  ((as you describe here: https://github.com/microsoft/vcpkg/issues/15399#issuecomment-752822241))
Path to long error occurs if the total path exceeds 260 characters, which can be resolved in one of two ways:
https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later
Add install option --x-buildtrees-root=<SHORTER_PATH> or in CMakeLists.txt before the project statement:
set (VCPKG_INSTALL_OPTIONS "--x-buildtrees-root=<SHORTER_PATH> ")

None of the logs actually print the full path it is trying to create, so there is no reason a user would suspect a "path to long" error is the problem. I'm not sure if vcpkg has an opportunity to catch this and print a better error than the Ninja log, but it would be nice if it did.
Thank you for the help!!!

@Sand2Silicon Not likely now. Sorry.


Flag Colors Incorrect

First of all, absolutely incredible work! This project is incredible!
Just wanted to share that the a few of the flags look off (particularly the red colour)
See screenshots below for Poland and Denmark

Also tried viewing it in a terminal without a background image (see example below for US flag)

For optimal results, it's recommended to use a terminal with True Color (24-bit) support.
My guess is that you're using a 256 colors profile - which the dashboard is not optimized for.
Try setting COLORTERM to truecolor, yes, true or 24bit?
E.g.
COLORTERM="truecolor" world-cup-2022-cli-dashboard


Remove task future from executor once completed

Description
Changes HTEX to remove references to a task after it completes. Could otherwise lead to memory issue if task outputs are large.
Fixes # (issue) [Would you like me to open one?]
Type of change

Bug fix (non-breaking change that fixes an issue)

For reference, I do observe this to be a problem when I have task sizes on the order of a few 100MB.


[BugBash] Password reset sent page title misleading

Scenario 1, per @loic-sharma
Also, if I go to "Account Settings">"Password Login">"Enable Password Login", the title of the page...

I think it is a valid issue, however, not related to AAD changes. Will add this to the backlog.

"Enable password login" section is gone. Closing.


[Draft] Add $enable-host to generate a different bootstrap.css for web components

Warning
Heavily draft

Another possibility to tackle https://github.com/twbs/bootstrap/issues/36688 (Closes #36688)
The principle here is to offer a $enable-host Scss var (false by default). This var is associated with a root mixin allowing to switch between :root and :host:

:root when $enable-host is false (default)
:host when $enable-host is true

I've added some unit tests to check this behavior.
It differs from https://github.com/twbs/bootstrap/pull/37162 which suggests to use :root, :host that is not really useful for all folks and projects.
The disadvantage here is that it's only available via Sass compilation. But maybe we can consider that this usage with web components is an "expert mode".
We also talked about a bootstrap.*.host.*.css with @vprothais but I'm a bit afraid of what it could imply in combination with the regular bootstrap.*.css* files

[ ] Handle site/content/docs/5.3/customize/css-variables.md modifications (if any needed)
[ ] Test this new file (with $enable-host set to true) in different use cases amongst https://github.com/twbs/bootstrap/issues/36688#issuecomment-1422236483
[ ] Add $enable-host in the documentation and explain the impacts for web components

Thoughts??

This would be super useful for my use-case. I am trying to figure out the best way to tackle this right now. Ideally I have a way to hoist all the variables out to :host.


⚠ Samsung has degraded performance

In 76782b0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2600 ms

Resolved: Samsung performance has improved in 38570f2.


Clarify license

Since there is no license in the repository, this project is technically proprietary. However, given that it is hosted publicly on GitHub, and is meant for a Linux-based operating system, I assume this is not the intended licensing strategy. Please clarify the license as I would like to fork this primarily for personal use (specifically from the code as of November 1st), but I also want to respect the creator's wishes.

Hey, thank you for mention the license issue, I think the two-clause BSD license is good for the code, and as for all the resources from internet(those icons), I think should respect the original author.
Also I've merged the PR you created two days ago, didn't notice those bug, thank you and well done!

Thank you!


"Reload Current Project" - don't silently discard unsaved editor changes

Godot version
3.4.4-stable
System information
Linux Ubuntu 20.04
Issue description
I always thought of "Reload Current Project" as  a harmless kind of "oh dear, the editor's gotten itself in a twist, so let's restart to clear away the cobwebs" thing.  But now I think it's a little dangerous.

Edit the scene tree
Project > Reload Current Project

Godot immediately reloads the project from disk.  The unsaved changes from Step 1 are lost.
This may well be the intended purpose of "Reload Current Project", i.e. it is intended to be a "Revert to Saved Version".  But that is not what it is doing.  "Reload Current Project" is ambiguous.  Does "current" mean the project in its current state in the editor, or the project in its state on disk?  If the former, it should offer to SAVE or DISCARD the changes prior to reloading from disk -- i.e. behave the same as "Quit to Project List".
If this menu item is meant to act as a "Revert to Saved Version" then call it that: "Revert Project From Disk" or similar.  Then it will be clear what this function does.
For example, just now I added to my project a new node definition and its icon.  Godot does not recognise icons for newly added node definitions until the editor is restarted.  So this is a good use case for menu item "Reload Current Project".  But if you do not manually save your editor changes before hitting "Reload..." then your changes are discarded immediately and without notice.
There are many other use cases, like when the Editor gets itself into a tangle and prints weird error messages that only go away after an Editor restart, which is easily and quickly accomplished by doing a "Reload Current Project" -- but again you will lose any unsaved changes if you've forgotten to save first.
TLDNR: If "Reload Current Project" is intended to be a "revert to project saved state" then rename it accordingly.  If it is intended to do precisely what it is called then check for unsaved editor changes and give the user the option to save or discard the changes prior to exiting the editor, same as how "Quit to Project List" behaves.
Thanks!
Steps to reproduce
Simple, as described above.
Minimal reproduction project
N/A

Duplicate of #52287, this is fixed in 3.5.

Apologies. I searched Issues but had the default is:open tag.

No worry. GitHub should have better tooling for this, it's not your fault (and it's also not a problem - we prefer duplicates than not knowing about bugs).


HDDS-10228. Intermittent failure downloading bzip2 from sourceware.org

What changes were proposed in this pull request?
Fix intermittent failure downloading bzip2 due to Network is unreachable.
The fix is similar to HDDS-10157: download from GitHub in CI.  The tarballs from these two sources are a bit different: contents are in bzip2-bzip2-1.0.8/ in the one from GitHub, bzip2-1.0.8/ in the original one.  So an additional move Ant task renames the GitHub-specific dir to the original one.  failonerror=false ensures it passes with the original tarball, too.
https://issues.apache.org/jira/browse/HDDS-10228
How was this patch tested?
Tested locally for the original URL:
# install dependencies
$ mvn -DskipTests -am -pl :hdds-rocks-native clean install
...

# test
$ mvn -Drocks_tools_native -pl :hdds-rocks-native clean generate-sources
...
[INFO] BUILD SUCCESS

$ ls -1 hadoop-hdds/rocks-native/target/bzip2
bzip2-1.0.8
bzip2-v1.0.8.tar.gz

CI (with the CI-specific URL):
https://github.com/adoroszlai/ozone/actions/runs/7681371921/job/20934591236

Thanks @hemantk-12 for the review.


Support dataset sharding

This line https://github.com/MadryLab/trak/blob/main/trak/traker.py#L268 should not zero out what is already in the target store. Change from 'w+' to 'r+'.
Also should add naming system so that you can score different targets

The simplest solution would be to require users to specify experiment name (exp_name) in both start_scoring_checkpoint and finalize_scores. This way, target (gradient) arrays will be tied to an experiment name, and we don't need to rely on w+ for cleaning up between scoring different targets.
Unfortunately, this introduces a (minor) backward incompatibility --- running start_scoring_checkpoint without exp_name will error out.

To fully support dataset sharding, my guess is that we'll need to make minor changes to the train gradient stores as well. Can you provide a minimal test with the desired functionality (computing TRAK scores over different parts of the dataset in parallel). Thanks!

honestly for now I think just swapping w+ to r+ is enough. It is weird/unexpected that the behavior is different between featurize (where we do not overwrite) and score (where we do).
More to the point, the inds argument is useless if you are going to overwrite on every call.
(I will create a test, but this seems like a pretty simple fix just for the basics)

https://github.com/MadryLab/trak/commit/f0e12f2d4ee4aec6bc16cdea97d70fba4db5b182

Resolved by https://github.com/MadryLab/trak/commit/03bc0eccefec4b47b3e323d1c0c330dc4c54e5de


Several Tidy Checks are missing from the list

I've compared the list of available checks from LLVM 15.0.4 with the list in CPT and found the following are missing from CPT.
abseil-cleanup-ctad
altera-id-dependent-backward-branch
altera-unroll-loops
bugprone-assignment-in-if-condition
bugprone-easily-swappable-parameters
bugprone-implicit-widening-of-multiplication-result
bugprone-shared-ptr-array-mismatch
bugprone-stringview-nullptr
bugprone-suspicious-memory-comparison
bugprone-unchecked-optional-access
bugprone-unhandled-exception-at-new
cert-err33-c
cert-exp42-c
cert-flp37-c
cert-pos47-c
clang-analyzer-apiModeling.Errno
clang-analyzer-apiModeling.TrustReturnsNonnull
clang-analyzer-cplusplus.StringChecker
concurrency-thread-canceltype-asynchronous
cppcoreguidelines-prefer-member-initializer
cppcoreguidelines-virtual-class-destructor
misc-confusable-identifiers
misc-const-correctness
misc-misleading-bidirectional
misc-misleading-identifier
modernize-macro-to-enum
objc-assert-equals
portability-std-allocator-const
readability-container-contains
readability-container-data-pointer
readability-duplicate-include
readability-identifier-length
readability-suspicious-call-argument

Hi @netx123,
Thank you for this remark, it helps us a lot to make Clang Power Tools a better product
I will introduce these checks in the next release
Have a nice day,
Marina


error when go build

I've got this error when build the agent into executable file.
# github.com/gen2brain/x264-go/x264c
In file included from ../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/x264c_cgo.go:31:0:
<EMAIL_ADDRESS>In function ‘x264_encoder_open_152’:
../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/encoder/encoder.c:1724:37: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
     snprintf( level, sizeof(level), "%d.%d", h->sps->i_level_idc/10, h->sps->i_level_idc%10 );
                                     ^~~~~~~
../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/encoder/encoder.c:1724:37: note: directive argument in the range [-214748364, 214748364]
../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/encoder/encoder.c:1724:37: note: directive argument in the range [-9, 9]
In file included from /usr/include/stdio.h:862:0,
                 from ../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/common/osdep.h:33,
                 from ../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/common/common.h:117,
                 from ../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/external/x264/common/mc.c:27,
                 from ../go/pkg/mod/github.com/gen2brain/x264-go@v0.0.0-20180306035800-58f586137654/x264c/x264c_cgo.go:6:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 4 and 14 bytes into a destination of size 4
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());

I'm running on linux ubuntu 18.04 and using go 1.12.7. Any idea why i got this error?
Thanks :))

Hey @dzakaammar, that's not an error, it's just a warning.
I get the same in Ubuntu 18.04, does it fail produce the agent binary for you?

Update:

Update: yeah, that's not an error and the executable file has worked properly.
I think i can close this issue.


Add documentation for Dijkstra Algorithm

Dijkstra's Algorithm is used for finding the path between two nodes in a graph. Do enhance the repo by adding documentation for it!
The changes should be in /Graph Theory/Dijkstra Algorithm/README.md

Hi @ekdnam,
I would like to take this issue.

Hey , I would like work on it. Could you assign this to me.

We are not assigning anyone here right now! Go ahead and make a PR!

Sure @ekdnam

Docs have been added. Closing this issue now


#2974: Add overrideGroupsFromCliInParentChildXml test

#2974: Add a test method for "Regression in -groups CLA"

@dr29bart - are you also planning to add changes to fix this issue? I ask because if this PR is containing a test that will reproduce the problem then it cannot be merged since it sill start breaking the build.

@krmahadevan unfortunately, I don't have a solution. The PR is a just sample of test case for the bug.
I am ok closing this PR without merging it.

@dr29bart The fix should be easy. Do you want to try a fix?
You think it is a regression. Could you tell us when the behavior changed?
The documentation is not precise enough about the expected behavior: addition instead of overriding could be a valid behavior too. In such cases, we prefer to choose the historical behavior.
The fix should include a documentation update too.

The 'groups' parameter overrides any defined groups in parent and child xml files in 7.3.0
Starting with 7.4.0 the parameter does not affect scope defined in xml files.
@juherr the behavior has changed in 7.4.0 with this commit:
https://github.com/testng-team/testng/commit/9c6cb875005429cb5a9b66b49160f3e0ac91dc0e#diff-c9ad087b236ef4e9750660f8daa935b53c2356a437d3bf5d069ba370e8994cf6R499
It initializes m_currentRun
m_currentRun = new XmlRun();

which then affects condition in XmlSuite#getIncludedGroups:
    if (m_xmlGroups != null && (m_xmlGroups.getRun() != null)) {
      return m_xmlGroups.getRun().getIncludes();
    }

There is XmlTest#setIncludedGroups which works with xmlGroups,I tried to use the same approach for XmlSuite#setIncludedGroups. Please let me know if there is a better way to address the issue.


Convert to TypeScript?

First of all thanks for this lib! That's really awesome we have alternative to, probably abandoned, https://github.com/aholstenson/miio.
I played with node-mihome lib for a while and it looks really promising. I achieved what was not possible with @aholstenson/miio in several lines of code. Cool :-)
What do you think about moving to TypeScript for development? I can help with this. Do you accept PRs?

Thankyou and welcome for all PRs

Hello, is it possible to use miio library in TypeScript development ?
A working js code didn't work in TypeScript with this error : (node:8212) UnhandledPromiseRejectionWarning: TypeError: fetch is not a function at MiCloudProtocol._loginStep1
An idea ? Tks a lot for your help


Proposal for new design of bottleneck internals

In the current design we do this to add the function bn.nanmean to bottleneck (I'll only show the float version, you'd also need to add the integer version):

@cython.cdivision(True)
cdef object nanmean_all_DTYPE0(np.flatiter ita, Py_ssize_t stride,
                               Py_ssize_t length, int int_input):
    # bn.dtypes = [['float64'], ['float32']]
    cdef Py_ssize_t i, count = 0
    cdef DTYPE0_t asum = 0, ai
    with nogil:
        while PyArray_ITER_NOTDONE(ita):
            for i in range(length):
                ai = (<DTYPE0_t*>((<char*>pid(ita)) + i * stride))[0]
                if ai == ai:
                    asum += ai
                    count += 1
            PyArray_ITER_NEXT(ita)
    if count > 0:
        return asum / count
    else:
        return NAN

@cython.cdivision(True)
cdef ndarray nanmean_one_DTYPE0(np.flatiter ita,
                                Py_ssize_t stride, Py_ssize_t length,
                                int a_ndim, np.npy_intp* y_dims,
                                int int_input):
    # bn.dtypes = [['float64'], ['float32']]
    cdef Py_ssize_t i, count
    cdef DTYPE0_t asum = 0, ai
    cdef ndarray y = PyArray_EMPTY(a_ndim - 1, y_dims, NPY_DTYPE0, 0)
    cdef np.flatiter ity = PyArray_IterNew(y)
    with nogil:
        if length == 0:
            while PyArray_ITER_NOTDONE(ity):
                (<DTYPE0_t*>((<char*>pid(ity))))[0] = NAN
                PyArray_ITER_NEXT(ity)
        else:
            while PyArray_ITER_NOTDONE(ita):
                asum = 0
                count = 0
                for i in range(length):
                    ai = (<DTYPE0_t*>((<char*>pid(ita)) + i*stride))[0]
                    if ai == ai:
                        asum += ai
                        count += 1
                if count > 0:
                    asum = asum / count
                else:
                    asum = NAN
                (<DTYPE0_t*>((<char*>pid(ity))))[0] = asum
                PyArray_ITER_NEXT(ita)
                PyArray_ITER_NEXT(ity)
    return y

Under the new proposal here's the code you'd write instead:
@cython.cdivision(True)
cdef inline DTYPE0_t nanmean_DTYPE0(char *p,
                                    Py_ssize_t stride,
                                    Py_ssize_t length,
                                    int int_input) nogil:
    # bn.dtypes = [['float64'], ['float32']]
    cdef Py_ssize_t i, count = 0
    cdef DTYPE0_t ai, asum = 0
    for i in range(length):
        ai = (<DTYPE0_t*>(p + i * stride))[0]
        if ai == ai:
            asum += ai
            count += 1
    if count > 0:
        return asum / count
    else:
        return NAN

The code is in the minty_fresh branch. I only ported nansum and nanmean (called nansum2 and nanmean2 in the branch).
When the length of each dimension of the array is large, performance is the same as before:
In [1]: a=np.random.rand(1000, 10000)
In [2]: timeit bn.nanmean(a)
100 loops, best of 3: 7.89 ms per loop
In [3]: timeit bn.nanmean2(a)
100 loops, best of 3: 7.86 ms per loop

For 1d arrays the overhead has been reduced:
In [4]: a=np.random.rand(10)
In [5]: timeit bn.nanmean(a)
1000000 loops, best of 3: 226 ns per loop
In [6]: timeit bn.nanmean2(a)
10000000 loops, best of 3: 184 ns per loop

For reduction of 2d (or higher) arrays with axis=None, overhead has increased because the rewrite uses PyArray_Ravel:
In [7]: a=np.random.rand(10,10)
In [8]: timeit bn.nanmean(a)
1000000 loops, best of 3: 325 ns per loop
In [9]: timeit bn.nanmean2(a)
1000000 loops, best of 3: 382 ns per loop

For repeated calls to the new inline function where each call does hardly any work, performance has decreased (not sure why; I don't even know if the inlining is taking place):
In [10]: a=np.random.rand(1000000,2)
In [11]: timeit bn.nanmean(a, 1)
100 loops, best of 3: 5.28 ms per loop
In [12]: timeit bn.nanmean2(a, 1)
100 loops, best of 3: 5.96 ms per loop

Adding a new reduction function to bottleneck is rare. So I'd only want to use the new design if we can improve the performance of the last two cases. On the other hand maybe the new design would make it easier to do things like optimize for reduction along a non-fast axis.

I've asked the compiler to inline a function that is impossible to inline. At compile time the function I want to inline into doesn't know what the function to inline is until runtime (it is passed in as a function pointer).
To fix that I could have the bottleneck templating system insert the code and automate the process of wrapping the inline functions with all the while PyArray_ITER_NOTDONE(ita) stuff.
The function that needs the code inserted into it is one_DTYPE0. We'd need a unique version of that function for every function (nansum, nanmean, etc) crossed with every dtype (int32, int64, float32, float64). It would bloat the binary size of this proposal to be the same as current master is my guess.
I guess the proposal just got a bit more complicated but would automate the boilerplate code. Not sure it is worth it.

Regarding function pointers and inlining, I remember Bjarne Stroustrup saying that C++'s sort() was faster than qsort because it didn't use function pointers.  Someone did a benchmark here:
http://www.martin-ueding.de/en/programming/qsort/index.html

I think I'll abandon this proposal for now.
It did occur to me, however, that it could be adapted to allow user defined functions with something like this:
@bottleneck.reduce(dtypes = [['float64'], ['float32']])
cdef DTYPE0_t nanmean_DTYPE0(char *p,
                             Py_ssize_t stride,
                             Py_ssize_t length,
                             int int_input) nogil:
    cdef Py_ssize_t i, count = 0
    cdef DTYPE0_t ai, asum = 0
    for i in range(length):
        ai = (<DTYPE0_t*>(p + i * stride))[0]
        if ai == ai:
            asum += ai
            count += 1
    if count > 0:
        return asum / count
    else:
        return NAN


eslint-plugin-bfcomposer not-found when build on the composer image on ACR

Describe the bug
i use the master branch for build.
on the Composer path : "az acr build --registry xxxxx --image xxxxxxx ."
result:
2020/08/31 09:12:44 Downloading source code...
2020/08/31 09:12:46 Finished downloading source code
2020/08/31 09:12:46 Using acb_vol_7e9ea94670692 as the home volume
2020/08/31 09:12:46 Setting up Docker configuration...
2020/08/31 09:12:47 Successfully set up Docker configuration
2020/08/31 09:12:47 Logging in to registry: xxxx
2020/08/31 09:12:48 Successfully logged into xxxxxxx
2020/08/31 09:12:48 Executing step ID: build. Timeout(sec): 28800, Working directory: '', Network: ''
2020/08/31 09:12:48 Scanning for dependencies...
2020/08/31 09:12:49 Successfully scanned dependencies
2020/08/31 09:12:49 Launching container with name: build
Sending build context to Docker daemon  1.307MB
Step 1/29 : FROM node:12-alpine as build
12-alpine: Pulling from library/node
cbdbe7a5bc2a: Pulling fs layer
091983d60f65: Pulling fs layer
7bacc183740f: Pulling fs layer
c4a5a5d270d4: Pulling fs layer
c4a5a5d270d4: Waiting
cbdbe7a5bc2a: Verifying Checksum
cbdbe7a5bc2a: Download complete
7bacc183740f: Verifying Checksum
7bacc183740f: Download complete
091983d60f65: Download complete
cbdbe7a5bc2a: Pull complete
c4a5a5d270d4: Verifying Checksum
c4a5a5d270d4: Download complete
091983d60f65: Pull complete
7bacc183740f: Pull complete
c4a5a5d270d4: Pull complete
Digest: sha256:9623cd396644f9b2e595d833dc0188a880333674488d939338ab5fde10ef7c43
Status: Downloaded newer image for node:12-alpine
---> 18f4bc975732
Step 2/29 : WORKDIR /src/Composer
---> Running in fcaecf99f14f
Removing intermediate container fcaecf99f14f
---> c7c18e20bb9b
Step 3/29 : COPY . .
---> de9c4acfc7cc
Step 4/29 : RUN yarn install --frozen-lock-file
---> Running in 2ca866bf7ce4
yarn install v1.22.4
[1/5] Validating package.json...
[2/5] Resolving packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/@bfc%2Feslint-plugin-bfcomposer: Not found".
info If you think this is a bug, please open a bug report with the information provided in "/src/Composer/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/sh -c yarn install --frozen-lock-file' returned a non-zero code: 1
2020/08/31 09:12:59 Container failed during run: build. No retries remaining.
failed to run step ID: build: exit status 1
Run ID: cbxx failed after 15s. Error: failed during run, err: exit status 1
Run failed
Version
Master branch
Releases 7
1.0.2
Latest
on Jul 9
OS
Develop on Winndow 10 pro: WSL
To Reproduce
Steps to reproduce the behavior:
i use the master branch for build.
on the Composer path : "az acr build --registry xxxxx --image xxxxxxx ."
Screenshots

@kunigagon please use the main branch and try again?

Hi @cwhitten  @a-b-r-o-w-n  i have tried. it change error but still not work.

@kunigagon please use the main branch and try again

Hi @cwhitten @a-b-r-o-w-n i have tried. it change error but still not work.

I found that the issue was with our .dockerignore file. I have pushed a fix on #3986 for you to test.

@a-b-r-o-w-n  @cwhitten  Thank you. solved.


Resizer doesn't work with Google Analytics Experiment

Hello, first of all a very useful piece of kit.
Unfortunately though, it doesn't work with Google Analytics Experiments.
The original page resizes, but none of the experiment variants work although they have the code in there.
The page is hosted in a wordpress system.

That is more of a question for StackOverflow.
If you want to raise a bug please see https://github.com/davidjbradshaw/iframe-resizer/blob/master/CONTRIBUTING.md


Docs

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #18 (e15dd15) into main (2ced83c) will not change coverage.
The diff coverage is n/a.


drivers: tee: optee: Introducing OPTEE_RPC_CMD function handles

This includes the implementation of the basic RPC_CMD which are received from OP-TEE TA service. Memory allocation requests, gettime and suspend were implemented in this commit.

It is safe to free this list only after you get another SHM op (e,g. another alloc or free)
@oleksiimoisieiev pls, revert changes that have been made for this comment

I believe that you should revert the next changes and delete all the newly added code related to the deletion:

First of all, there are a few issues with the current implementation. One problem is that the memory for the page list isn't freed in the following cases:

when you allocate mem using RPC and it was the last RPC in optee_call, you lose the pointer because you leave optee_call without storing it anywhere;
and also lose the pointer to the page list if, after an RPC for memory allocation, you receive a non-memory management RPC and leave optee_call.

Regarding the safety concern, it should be noted that OP-TEE OS copies all pages to its own OS structures. You can observe this in the following call chain:
thread_rpc_alloc --> get_rpc_alloc_res --> rpc_shm_mobj_alloc --> mobj_mapped_shm_alloc --> mobj_reg_shm_alloc:
memcpy(mobj_reg_shm->pages, pages, sizeof(*pages) * num_pages);

Furthermore, both U-Boot and Linux kernel drivers free the page list inside an analogous function to our Zephyr function optee_call.

Regarding the safety concern, it should be noted that OP-TEE OS copies all pages to its own OS structures. You can observe this in the following call chain:

Yes, but you must understand that this is asynchronous process. OP-TEE may return with another RPC due to an interrupt before it have chance to copy from the list. This is why Linux drivers calls free_pages_list during another OPTEE_MSG_RPC_CMD_SHM_ALLOC:
	case OPTEE_MSG_RPC_CMD_SHM_ALLOC:
		free_pages_list(call_ctx);
		handle_rpc_func_cmd_shm_alloc(ctx, arg, call_ctx);
		break;

Because only in this case we can be sure that it already finished handling the previous alloc call and read from the list.
And of course the list needs to be freed if we leave optee_call.

The IRQ triggers an allocation memory RPC in the Linux kernel.

This is not possible. IRQ always comes from a device and is handled by a device driver. There is no chance it can cause RPC call inside the same STD call context.

so, some of comments aren't addressed and you have already a new one pull request https://github.com/xen-troops/zephyr/pull/60/files

so, some of comments aren't addressed and you have already a new one pull request xen-troops#60

I did. to the wip branch

Updated PR. Considering that optee_upstr was already merged to zephyr-v3.3.0-xt branch, this PR should be recreated to xen-troops/zephyr-v3.3.0-xt. But I'm leaving it as is to save comments history. Once I get Acks and RB, I'll close this mr and push already reviewed code to xen-troops

Thank you for the review. I'm closing this PR to recreate it in xen-troops repo


Use Scala-Native for Mill Client (1000USD Bounty)

From the maintainer Li Haoyi: I'm putting a 1000USD bounty on this issue, payable by bank transfer on a merged PR implementing this.

Sister ticket to https://github.com/com-lihaoyi/mill/issues/4007.
The Mill client contains ~24 Java files with zero third party dependencies:

https://github.com/com-lihaoyi/mill/tree/main/main/client/src/mill/main/client
https://github.com/com-lihaoyi/mill/tree/main/runner/client/src/mill/runner/client

We should try to see if we can port it all to Scala-Native for improved startup performance and to allow us to use Scala libraries in the client. e.g. using MainArgs in the Mill client would alleviate the -i must be passed as the first argument restriction which is very annoying
The success criteria for this ticket is a PR which (a) translates all Mill client code from Java to Scala (b) cross-compiles the Mill client code using Scala-Native and (c) bundles the Scala native launcher together with the Mill server jar so the client is able to launch the server.

I'd be tempted to dot take a tilt at this, but I'll probably be slow.

i'm also interested in working on this, but pointers how to incrementally migrate would be welcome: https://discord.com/channels/632150470000902164/1295786923410984981/1310137269801320498

@scarf005 I'll leave it to you for the time being - if you're willing to publish your PR, we can try and work through it together, but it sounds to me as though you're doing the same things I would have been trying to do.
My knowledge is not more detailed than what Haoyi set out above right now.

(b) cross-compiles the Mill client code using Scala-Native and (c) bundles the Scala native launcher together with the Mill server jar so the client is able to launch the

@lihaoyi sorry, but could this be explained in more detail? still quite new to mill, i've rewritten runner.client at https://github.com/scarf005/mill/tree/refactor/scala-native-mill-client but unsure which command to run to ensure (b) and (c) works correctly.

@scarf005 If you try running this command;
mill show runner.client.compile
and check the compile.dest target dir. I guess, that it will be empty. Did you make the client module a ScalaModule? Otherwise, it will ignore *.scala.

@scarf005 Just want to check - are you still looking at this?

yes, i think i could work more on weekends...
tho it might not work well as planned since i'm new on this!

@scarf Cool - if you want to collaborate on it and split the bounty, it could be fun - otherwise I'll leave you to it ... no pressure from me either way.

tho it might not work well as planned since i'm new on this!

it's open source so hopefully it's fun :-).
If you decide to drop it at some point, just please let me know?

alright, will share how it goes here. btw - my handle is scarf005 not scarf

Just for some additional context, the long-term plan for this issue and https://github.com/com-lihaoyi/mill/issues/4007 is we will likely want both: initially to do a comparative analysis of Scala-Native vs Graal-Native approaches to the problem, and then either picking the Scala-Native version OR using Scala re-implementation on the JVM with Graal-Native. In either case we would need both tickets to be completed

I'd like to take a stab at this.

Here's my work so far.
#4057 . Currently, I think this looks like it might be very hard. I'm going to head over the Scala Native, and ask about how battle hardened they think their file interactions are to see if it's a "me" thing...

@lihaoyi
Although it's possible that I've mucked up something simple, I had the tests passing before switching mill to native modules, and my (limited test) ports appear to pass if I run them on the JVM rather than native. I'm asking around in the Scala Native discord, but, if I'm right, a native client could entail a quite low level re-write that changes the client locking mechanisms and the streaming between log -> terminal mechanisms.
I guess my question is how far would you want to push this and what the burden of proof in either direction would be? It could get quite high risk?

The bounty is for full compatibility, including the logging and locking mechanisms. If you can't get that working that's fine, perhaps others will make more progress in future.
Burden of proof is same as any other PR, code review and testing. In this case, all existing tests should pass with the new launcher, both unit tests for the launcher and integration tests for Mill

Good, agreed. I think I should drop this for the time being. From what I can tell, to get this over the line is a far larger undertaking than I am in a position to credibly work through. Apologies for that.
I do think the PR that I put up could provide a good starting point for someone and I'm happy to answer question on it. Much of the infrastructure is in place.

This repository painstakingly rebuilt the client in a cleanroom with all but two unit tests passing.
https://github.com/Quafadas/mill_client
I believe it to be a SN bug (tests pass on the JVM platform) and have asked for help.

Sounds great @Quafadas !


using guava Preconditions in UpdateTopologyManager

As #1612 mentioned, this PR is trying to use guava Preconditions in UpdateTopologyManager class for checking conditions and replace the assertTrue method.
The key changes are following:

add com.google.common.base.Preconditions
remove assertTrue method
use Preconditions.checkArgument or Preconditions.checkState

cc: @billonahill

Changes look good, but can we not prefix "ERROR:" to every message string? These messages are going to be used as the message to a RuntimeException, which should be ultimately logged as SEVERE, so no need to also put ERROR in the message.

@billonahill Thanks for your suggestion and the PR was updated. BTW, any comment if we do the same change on ByteAmount class, is it necessary?

👍 thanks!
Doing the same in ByteAmount would be great thanks.

@billonahill - I'll send another PR for ByteAmount

👍


Give an error message with a description of the fix if a generator yi…

…elds a tensor of unexpected shape.
Addresses https://github.com/keras-team/keras/issues/19748

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 56.37%. Comparing base (b476304) to head (0425f85).

Files
Patch %
Lines

...c/trainers/data_adapters/generator_data_adapter.py
0.00%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19758       +/-   ##
===========================================
- Coverage   78.56%   56.37%   -22.19%
===========================================
  Files         498      498
  Lines       45710    45712        +2
  Branches     8438     8439        +1
===========================================
- Hits        35911    25772    -10139
- Misses       8075    18358    +10283
+ Partials     1724     1582      -142

Flag
Coverage Δ

keras
56.37% <0.00%> (-22.04%)
:arrow_down:

keras-jax
?

keras-numpy
56.37% <0.00%> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


@conda-forge-admin please add bot automerge

@conda-forge-admin please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/grpc-stubs-feedstock#2.


Use pyproject.toml

@dstansby it seems unrelated, but do you know why a (seemingly random) subset of test runners are failing?

I've approved, but held off merging if you have an idea of how to fix the tests. If not, feel free to merge and it can be sorted in another PR.

I've approved, but held off merging if you have an idea of how to fix the tests. If not, feel free to merge and it can be sorted in another PR.

Yeah, I haven't had a chance to work out what's going on here, and I think it's happening in some other repos on linux too (maybe brainreg??). I'll merge this, and we can tackle this in a separate PR/issue.


how to test on a movie? mp4 or avi

hi, dear,
have tested the test_models.py a liittle difficult to read,
if I just want to test on some movies ,then how should I modify the codes,
thx
any advice or suggsetion will be appreciated.
if have a key argument 'video_path' will be more convenient
do not want test on the txt file below
Traceback (most recent call last):
  File "test_models.py", line 182, in <module>
    ]), dense_sample=args.dense_sample, twice_sample=args.twice_sample),
  File ".\temporal-shift-module\ops\dataset.py", line 58, in __init__
    self._parse_list()
  File ".\temporal-shift-module\ops\dataset.py", line 96, in _parse_list
    tmp = [x.strip().split(' ') for x in open(self.list_file)]
FileNotFoundError: [Errno 2] No such file or directory: '/ssd/video/kinetics/labels/val_videofolder.txt'

could u pls supply the txt file ?
'/ssd/video/kinetics/labels/val_videofolder.txt'

Duplicated issue to #42


input data

Dear authors, thanks for your great works.
I have some questions about the data. I try to visualize the input protein sequence by call the to_sequence() during each batch. Here is the figure showing the sequence.

I wonder why there are some many .Gs, since . is a separator for multiple sequences (https://github.com/DeepGraphLearning/torchdrug/issues/151). Also, after deleting all the ., the length of remaining sequence is the same as the number of the graph's nodes. Could you help to explain why there are some many .Gs? Many thanks!

Hi, thanks for raising this question! I guess this can be explained as follows.
First, when loading a protein from a pdb file with TorchProtein, the unknown residue types will be recognized as glycines (see this). Then, when using the data.Protein.to_sequence() to output the sequence (see this), different connected components are seperated by dots.
The pdb file shown in your figure may contain many HETATM in the end, which cannot be recognized and thus are treated as GLY without links to other residues. These atoms will be discarded when you run residue-level model with the graph construction model (see this).


Change cmder url to correct url.

change cmder url to cmder.app instead of cmder.net.

Thanks for taking the time to submit a fix for this @unkn0wn-root! We'll merge it shortly.

Merged manually, thanks 👏

If you want I can reference you in the attribution posts on Linked IN and X. Please give us your handles if you like that.

If you want I can reference you in the attribution posts on Linked IN and X. Please give us your handles if you like that.

Yeah! Sounds good to me :)


[PE-D] Undo command not working

Undo command not working after deleting a package

Labels: type.FeatureFlaw severity.High
original: putaojuice/ped#10

Fixed documentation to explain that undo only works for commands that alter AddressBook


update saxon dep to last 9.9.0-2

Ok it's used in ascii doctor core
Upgrade it then

Thanks!
It's just test dependency, but still good to update them.


scala-cli should look for project.settings.scala in parent directories as a fallback

It would be great if scala-cli could look for the project.settings.scala by searching all parent directories, similar to how git searches for the .git directory. This would allow users of scala-cli to place the project.settings.scala file at the root of their source folder. Scala scripts would then be able to be placed in nested subdirectory paths but still be able to find the project.settings.scala at the root of the source folder, even if the script being run is nested within multiple subdirectories.

Searching in parent directories could be done right before searching the current working directory.

Hey, for now we decided against doing this, to avoid ambiguities.
The way we currently look for project.settings.scala (and the project root, as an extension of that) is complex enough as is (just take a look at the relevant doc). Adding more smart detection in the inputs' parent directories (not to mention .git root) might introduce behaviours which would be unexpected to our users, so it probably shouldn't be on as default, if it's to be added at all. (which I'm not so sure about)
For example, for a structure like this:
.
├── .git
├── project.settings.scala
│
├──  src
│   └─── ...
│
└─── scripts
    └─── script.sc

While running the script independently
$ scala-cli scripts/script.sc

The user might be unaware ./project.settings.cala is included on the classpath. It's not unlikely the script uses conflicting dependencies and including it might even break some of the logic.
And that's just one of potential ambiguities this would introduce (regardless if we're talking just about the input parent directory or all the way to the git root).
TL;DR
I'm setting this as low priority. We might revisit this if there's demand, but probably not soon.
And even then, it would probably have to be hidden behind a flag (or some setting to be set with scala-cli config), and not to be enabled by default.


Implement CSV opener/reader

Description
This issue describes the basic need for a standalone reader for tabular data. We do want to support a few common formats that such data is often published in, and provide a consistent interface for reading data out of those sources.
As a first step, we should implement this interface for CSV, with a view to that fact that we are designing for other formats like Excel as well.
I've done some initial work in this direction, so here is a mini-spec based on that:
Spec
Example usage
# row would either be an array of values utf-8 encoded strings, or, an object of values keyed by column name
from tabulator import Tabulator

datasource = 'file.csv'
dataformat = 'csv'
options = {
    datasource,  # a filepath or a stream. Some formats, like Excel, could only be a filepath.
    dataformat='csv',  # 'csv', 'json', 'ndjson', 'excel', 'ods'
    schema=None,  # a dict of a valid JSON Table Schema, None, or 'infer'
    headers=None,  # None or integer or iterable . None means none, integer means the row where headers are, iterable means those are the headers, and don't look for them in the file
    encoding=None,  # encoding of the data source. prevents guessing, which can be wrong often
    decode_strategy='replace'  # decode strategy
    keyed=False # whether to return plain tuples or named tuples for each row
}
datable = Tabulator(datasource, dataformat, **options)

for index, row, in enumerate(datatable.values):
    yield (index, row)

Consistency over Py2/3

Whatever the stream input, turn into a utf-8 encoded text stream (likewise on opening file), so that components of a data processing pipeline do not have to handle this

Data flow

When the data source is ingested, it is put into a pipeline that will produce a utf-8 encoded text stream as the data is iterated over.
When .values is iterated over, each row goes through an extended pipeline of generators
if schema passed, check row against schema, or, infer schema - in each case, cast values based on schema and raise if casting errors (https://github.com/okfn/jsontableschema-py)
lastly, a generator that produces the row output for the consumer as

a tuple
a named tuple if keyed is True, and if we have headers

we'd want to be able to add generators into this pipeline. Two useful generators are ones that would do the following, but we can add those after the basics are in place

detect and act on blank rows
detect and act on rows with invalid dimensions

Consumers need to be able to do the following (there are example APIs for all this in GoodTables and MessyTables):

See the headers .headers
Take a sample .get_sample()
Reset the stream .replay
Catch errors when stream is not what it claims to be (e.g.: is HTML and not CSV)

Tasks

[x] First implementation of reader
[x] Reasonable suite of tests (many example tests can be taken/adapted from https://github.com/okfn/goodtables/blob/master/tests/test_datatable.py and https://github.com/okfn/messytables/tree/master/test)

@pudo comments/additions? I'm hoping we collaborate to turn this into the basis of MessyTables 2 and even going forward to merge what are now GoodTables and MessyTables. Let's get some working code pushed here to talk on :0. One of our developers @roll will be working on this over the next days.

DONE


Add validation errors to get draft response

https://www.pivotaltracker.com/story/show/108748808
Add a flag to the response when getting a single draft service showing whether the entire service is valid or not. This is useful for knowing when to show the 'mark as complete' button on the supplier frontend.

:+1:


after type 'run' in tensorflow debugger, the terminal reappears and stucks

My program can run and show some traing results, but for a classification question, the accuracies of training set and validation set both keep at around 0.5 for 40 epoches.
So I want to use tensorflow debugger to watch what the variables are.
When I type 'run' and push enter, it jump out of the debugger and the terminal reshows, then the terminal screen stuck at below.
name: GeForce GTX 1080
major: 6 minor: 1 memoryClockRate (GHz) 1.835
pciBusID 0000:01:00.0
Total memory: 7.92GiB
Free memory: 7.28GiB
I tensorflow/core/common_runtime/gpu/gpu_device.cc:906] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_device.cc:916] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:975] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1080, pci bus id: 0000:01:00.0)
the nvidia-smi results is below:
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 375.39                 Driver Version: 375.39                    |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX 1080    Off  | 0000:01:00.0      On |                  N/A |
|  0%   43C    P2    53W / 200W |   1857MiB /  8105MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID  Type  Process name                               Usage      |
|=============================================================================|
|    0      1011    G   /usr/lib/xorg/Xorg                             300MiB |
|    0      1802    G   compiz                                         133MiB |
|    0      3362    G   .../Enabled/MarkNonSecureAs/show-non-secure-    99MiB |
|    0     14422    C   python                                        1321MiB |
+-----------------------------------------------------------------------------+

any suggestion for solve the problem?

@jetW Does your graph contain any tf.while loops? If so, it may get stuck because of a bug in tfdbg in version 1.0.0 that causes the debugger to freeze on certain while loops. This bug has been fixed in master/HEAD.

The graph does not have tf.while. I may wait for the next release. Thank you!

Has the tf.while loop freeze in tfdbg been fixed in any new builds?

@caisq Has this problem been resolved?
I'm having a similar problem when using tfdbg. My network is returning nan after 1 optimization step, so I'm trying to resolve what's going on. My problem is same as above: "when I type 'run' and push enter, it jump out of the debugger and the terminal reshows, then the terminal screen stuck at below." There are no errors or warnings of any kind. Also, if I use the invoke_stepper, it freezes during some while steps indefinitely (or at least several hours until I cut it off). In particular, it freezes on steps that look like bilstm1/bilstm1/bidirectional_rnn_1/fw/fw/while/layer_norm_basic_lstm_cell/state_1/batchnorm/sub/Enter
I definitely have while loops from tf.nn.bidirectional_dynamic_rnn and tf.map_fn, but I set parallel_iterations=1 for all of those calls. I read as well that there are some bugs with while loops on gpu's, so I have tried running all ops with tf.device("/cpu:0"): as well with the same results.
Any ideas I can try to get tfdbg to work in this situation?
I am using the nightly build of tensorflow_gpu-1.1.0rc2-cp35-cp35m-win_amd64.whl (Build #149 (Apr 19, 2017 2:25:00 AM) which is the last stable build)

There have been a few bug fixes for tfdbg related to while loops in the past several weeks. @fredtony , can you please let me know what version of TensorFlow you are using?

@caisq I a using 1.1.0-rc2. I have the nightly build (Build #149 (Apr 19, 2017 2:25:00 AM) which is the last stable build). Revision ed6bb758dabc612234e9afd38bdaeb1b84e09955

@fredtony Thanks for the info. I was under the impression that this PR (https://github.com/tensorflow/tensorflow/commit/99559a3455d7c3b3663968a55bf56801743201d0) should have resolve a previous problem related to tf.while_loop. This commit is in both the master and r1.1 branches. But there might be other corner cases not covered here.
Can you provide some sample code (and some fake data) to reproduce the issue?


Customize Template But No Change

Microsoft Visual Studio Community 2022 (64-bit) - Current
Version 17.7.6
Even if I customize the template, the change is not reflected when I create new unit tests.

No Change;
The default test template comes

Does the Test Framework and Mock Framework you chose when you created the test match the one on this page?


Client-sdk support for TLS connection to the member services

Description
This PR allows the client-sdk to connect to the member services using TLS.
Motivation and Context

The communication channel between the client-sdk and the member services must be protected to avoid eavesdropping of confidential information.
How Has This Been Tested?

The PR has been tested by setting up the fabric in dev mode as described in https://github.com/hyperledger/fabric/blob/master/docs/API/SandboxSetup.md, activating TLS on the
the member services by setting the following properties in membersrvc.yaml as follows:
server:
        tls:
              certfile: "/var/hyperledger/production/.membersrvc/tlsca.cert"
              keyfile: "/var/hyperledger/production/.membersrvc/tlsca.priv"

And by setting the following properties in core.yaml as follows:
    pki:
        eca:
            paddr: localhost:50051
        tca:
            paddr: localhost:50051
        tlsca:
            paddr: localhost:50051
        tls:
            enabled: true
            rootcert:
                file: "/var/hyperledger/production/.membersrvc/tlsca.cert"
            # The server name use to verify the hostname returned by TLS handshake
            serverhostoverride:

The test chain-tests.js shows how to setup TLS.
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Angelo De Caro<EMAIL_ADDRESS>This is a joint effort with: Thorsten Kramp, Thomas Eirich and Elli Androulaki.

Is this covered by the unit-tests?  If so, is there a way I can run it locally to verify since CI doesn't currently trigger sdk tests?

Hi @ghaskins, please, find in the README the instructions on how to test TLS connection in dev mode.  Please, let me know if they are clear enough.

@ghaskins currently unit test requires manual set up per readme until deploy is implemented.


Titrator (water quality) data have some missing values

We need to go through the summary PDFs from the instrument and check on the following Kits:
K014 - no run date recorded, only need conductivity
K046 - only need ml HCL added (see picture below for run info)
K057 - no run date recorded, only need conductivity

Found K046 waiting on others

Update from PR: we can't locate notes on K014 and K057 to be confident on the data, so we will be using average conductivity from the other samples at each locations (mid-atlantic and great lakes) for those kits


fix Enlightning typo

What this PR does / why we need it
Fix typo on Resources page. YouTube series is spelled Enlightning without the "e".
Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

Special notes for your reviewer

@jpmcb @stmcginnis @jkotzen I do not have the permissions to reopen this pull request, someone from your side will have to do it. The name of the YouTube series referred to on the Resources page is indeed spelled "Enlightning" without the additional "e".

Please update the title and description to actually reflect what is being done and why. Thanks!

@stmcginnis @jpmcb title and description have been updated


Not working

Hi,
After running this command on ES1.5.2:
./bin/plugin -i org.codelibs/elasticsearch-reindexing/2.1.0
the XGET command is returning:
curl -XGET localhost:9200/_reindex
{"error":"ElasticsearchIllegalArgumentException[No feature for name [_reindex]]","status":400}

but it is installed:
./bin/plugin -l
Installed plugins:
    - reindexing

Could you try 1.4.4 or 1.7.1?
2.1.0 does not work on ES 1.x.

I think it was a permissions bug


502 bad getaway when try to download file

services:
  selenoid:
    network_mode: bridge
    image: aerokube/selenoid:1.10.12
    volumes:
      - "./config:/etc/selenoid"
      - "/var/run/docker.sock:/var/run/docker.sock"
    command: ["-conf", "/etc/selenoid/browsers.json"]
    ports:
      - "4444:4444"

  "chrome": {
    "default": "113.0",
    "versions": {
      "113.0": {
        "image": "selenoid/chrome:113.0",
        "port": "4444"
      }
    }
  }
}

I'am trying to download file using Selenoid API
https://aerokube.com/selenoid/latest/#_accessing_files_downloaded_with_browser
Get session id
2023-06-30 21:36:00 INFO  DriverManager:26 - Method: userCanSuccessfullyGenerateInvoiceReportTest;Session Id: 13d0de35031964a70fa65c9a87d5f53d
Request method:	GET
Request URI:	http://<IP_ADDRESS>:4444/download/13d0de35031964a70fa65c9a87d5f53d/Rakhunki_za_05-2023.zip
Proxy:
Request params:
Query params:
Form params:
Path params:
Headers:		Accept=/
Cookies:
Multiparts:
Body:
HTTP/1.1 502 Bad Gateway
I can see this file inside chrome container

2023-06-30 21:35:58 2023/06/30 18:35:58 [1047] [SESSION_ATTEMPTED] [http://<IP_ADDRESS>:4444] [1]
2023-06-30 21:36:00 2023/06/30 18:36:00 [1047] [SESSION_CREATED] [13d0de35031964a70fa65c9a87d5f53d] [1] [3.44s]
2023-06-30 21:36:20 2023/06/30 18:36:20 [1473] [DOWNLOADING_FILE] [13d0de35031964a70fa65c9a87d5f53d] [/Rakhunki_za_05-2023.zip]
2023-06-30 21:36:20 2023/06/30 18:36:20 [1473] [CLIENT_DISCONNECTED] [unknown] [<IP_ADDRESS>] [Error: dial tcp <IP_ADDRESS>:8080: connect: connection refused]

@oleh-datsiuk make sure there is a fileserver process listening on port 8080 inside browser container.


Get current dataset matches

Feature request:
It would be useful to provide a method to get the set of current options based on the current input.
This would allow accepting matches without the user explicitly selecting an option from the dropdown.
My current workaround for this involves scanning the dropdown in the dom, but I only have the text of the option available. Each option in the dataset also has an id that's not available. I could use a template to insert a data-attribute, but this seems like more overhead than necessary.
Something like
$('.typeahead').typeahead('matches');

would return a subset of the original dataset that's currently shown to the user, or currently matches the input.
Questions to answer about this:

How many values should be returned? Just visible ones? All from remote?
What happens when the user hasn't entered anything? Return nothing, return everything? (my preference would be nothing)

By listening for the typeahead:rendered custom event, you should be able to track which suggestions are being shown.

hi @jharding, I use typeahead:rendered event and the suggestions argument always return 1 object not the array of suggestion. Is there anything I miss ?


Add ^WT binding to close/tab the current-buffer

This mimicks Vim's behaviour to open the current-buffer on its own tab
(and close it) with ^WT. If there's only one window on the current tab,
nothing happens (as in Vim). This closes #3.

That's a really nice addition. Thanks!


Remove unrelated to default theme styles for error-message

Partly revert https://github.com/vaadin/vaadin-text-field/pull/104 according to the CR conversation

This change is

Will it be changed in the default theme?

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable


Recursive copy from GCS bucket to Azure container fails when using exclude-path with cannot start job due to error: FileIgnored error

Which version of the AzCopy was used?
AzCopy 10.13.0
Which platform are you using? (ex: Windows, Mac, Linux)
Mac
What command did you run?
azcopy copy 'https://storage.cloud.google.com/bucket/test' "https://account.blob.core.windows.net/container/test" --recursive --exclude-pattern bucket-index.json.gz

What problem was encountered?
failed to perform copy command due to error: cannot start job due to error: FileIgnored.

How can we reproduce the problem in the simplest way?
Whenever I try to do recursive copy from Google Storage bucket and use --exclude-* flags (tried --exclude-path, --exclude-regex and --exclude-pattern) to skip some files, I get the error failed to perform copy command due to error: cannot start job due to error: FileIgnored..
Have you found a mitigation/solution?
Removing exclusion works fine, but of course also copies objects that I would prefer not to copy.

This is an error that was supposed to be caught and tracked elsewhere; it should not have made it here. I've fixed this in #1654 and it should hopefully make it through next release.

Thank you! I will test it and report back.

I confirm that with #1654 the exclude options work fine. Thank you very much!

Fix released in AzCopy 10.14.0


Scripts directory appears on the website

https://the-algorithms.com/language/nim
The directory.nim script should not appear here, nor any future scripts.

Renaming to .scripts should suffice.
Let's push #21 and I can change it everywhere.

Sorry it still appears. We forgot to regenerate the Directory.md file.

I think this is just a caching issue. The link for the "Directory" solution is to the moved file.

Here's the script that populates the site. I'm not sure if it ignores dotted directories.
https://github.com/TheAlgorithms/website/blob/main/scripts/fetch-algorithms.ts

This issue depends on the following website's issue: https://github.com/TheAlgorithms/website/issues/237

Closing as this is related to the website and not this repository itself.


Fix capitalization of OnBackPressureBuffer filename

Fix for #32. Because the filename for OnBackPressureBuffer has the wrong capitalization it breaks PSR-4 auto-loading on case sensitive filesystems.

Hi @Vinceveve , do you think this PR can be merged? If not that's fine too but I'm doing some clean up and would like to delete my fork ;).


add_frame does not accept scale kwarg

The scale= kwarg seems to set the length of the unit vectors attached to a reference frame. I tried doing Scene.add_frame(frame, scale=1.5) but got an error message (I forgot what exactly). First, a question, is the function of the scale kwarg to only set the length of the triad of unit vectors? If it is, should add_frame() accept it?

Yes, the scale kwarg is the length of the unit vectors of the reference frame. The following works fine for me.
import numpy as np
from symmeplot.matplotlib import Scene3D
from sympy.physics.mechanics import Point, ReferenceFrame, dynamicsymbols

# Create the system in sympy
N = ReferenceFrame("N")
A = ReferenceFrame("A")
q = dynamicsymbols("q")
A.orient_axis(N, N.z, q)
N0 = Point("N_0")
v = 0.2 * N.x + 0.2 * N.y + 0.7 * N.z
A0 = N0.locatenew("A_0", v)
# Create the instance of the scene specifying the inertial frame and origin
scene = Scene3D(N, N0, scale=0.5)
# Add the objects to the system
scene.add_vector(v)
scene.add_frame(A, A0, ls="--", scale=0.3)
scene.add_point(A0, color="g")
# Evaluate the system.
scene.lambdify_system(q)
scene.evaluate_system(0.5)
# Plot the system
scene.plot()

Sorry, I misremembered this. The is is with add_body() which also seems to attach a triad of unit vectors to the reference frame associated with the body.
Traceback (most recent call last):
  File "/home/moorepants/src/bicycle-kickplate-model/mplviz.py", line 40, in <module>
    rear_wheel_plot = scene.add_body(rear_wheel, scale=2.0)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/symmeplot/core/scene.py", line 221, in add_body
    obj = self._PlotBody(self.inertial_frame, self.zero_point, body, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/symmeplot/matplotlib/plot_objects.py", line 395, in __init__
    PlotPoint(inertial_frame, zero_point, masscenter, **properties[0]))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/symmeplot/matplotlib/plot_objects.py", line 73, in __init__
    Line3D([0], [0], [0], **{**self._get_style_properties(style), **kwargs}),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/symmeplot/matplotlib/artists.py", line 40, in __init__
    super().__init__(np.array(x, dtype=np.float64),
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/mpl_toolkits/mplot3d/art3d.py", line 208, in __init__
    super().__init__([], [], *args, **kwargs)
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/matplotlib/lines.py", line 407, in __init__
    self._internal_update(kwargs)
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/matplotlib/artist.py", line 1216, in _internal_update
    return self._update_props(
           ^^^^^^^^^^^^^^^^^^^
  File "/home/moorepants/miniconda/envs/bicycle-kickplate-model/lib/python3.12/site-packages/matplotlib/artist.py", line 1190, in _update_props
    raise AttributeError(
AttributeError: Line3D.set() got an unexpected keyword argument 'scale'

I was trying to figure out how to increase the length of the unit vectors associated with a body.

add_body passes the kwargs to PlotBody. It is mentioned in the [documentation of `PlotBody](https://tjstienstra.github.io/symmeplot/api/matplotlib/plot_objects.html#symmeplot.matplotlib.plot_objects.PlotBody) that `kwargs` in general are applied to both the internal `PlotPoint` and `PlotFrame`. In case of `color="red"`, this would mean that all vectors and the center of mass becomes red. However, in this case the `scale` argument is not supported by `PlotPoint`. To scale the reference frame you should use `scene.add_body(rear_wheel, plot_frame_properties={"scale": 2.0})`.
Maybe I should investigate generating parts of the documentation, such that this becomes easier to find.

There are definitely lots of **kwargs in the docs, but it isn't so easy to trace what it does.

There are definitely lots of **kwargs in the docs, but it isn't so easy to trace what it does.

Yeah, symmeplot highly leverages passing down expecting someone down the line to understand the keyword argument.

Closing in favour of #33.


Pre-release merge for 0.2.2

Pull Request Test Coverage Report for Build 83

51 of 51 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.3%) to 95.951%

Totals

Change from base Build 81:
3.3%

Covered Lines:
237

Relevant Lines:
247

💛  - Coveralls


fix: add buffer and update deps

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #71 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   82.75%   82.79%   +0.03%
==========================================
  Files           8        8
  Lines         493      494       +1
==========================================
+ Hits          408      409       +1
  Misses         85       85

Impacted Files
Coverage Δ

src/pubsub.js
86.16% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b67a2...d8e9d1b. Read the comment docs.


VLAZ: Watch readymatrimonial.in

VLAZ requests the watch of the watch_keyword readymatrimonial\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

readymatrimonial\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


NuGet for EasyHook

Moved from CodePlex
Originally submitted by Cel654321
Would it be possible to ease deployment by creating a NuGet - and this would potentially increase uptake manyfold, in general ..

:+1

:+1:

:+1:


Adding support for multiple processes

This fixes #103

Hi @wardhus Thanks for fixing this
@ajcrowe can you have a look at this?

This looks good @wardhus, can you fix the build and I will merge this

Do the tests just need re-run? Looks like the build failure is unrelated to the changes in this PR.

Looks like it would be an easy enough fix to get this build to work.  Realizing it's not a file you touched but was probably present when you forked the module.  Want to just try it so that @ajcrowe  can merge this in.  I'd love to have puppet stop trying to restart my supervisor programs on every run.

Hi. Has anybody applied this fix successfully. I hit similar issue and can't make it run properly even with the proposed fix. Any advice is appreciated.

We've been running my fork in production ever since I made this pull request. You can do the same until this gets merged. :)

Hi @wardhus, thank you for the clarification. On second try, I made it works.
Hey, @ajcrowe, I think this is important fix and would be nice to be in master.

Sorry it took so long to get this merged!


Intellisense takes lot of time to load on larger projects

What language?
If you disable all extensions, do you still see the problem?
How long are you talking about? It it only during the first load?
Approximately how large is the project?


Add EBI, adjust Neubias into past tense and add resources

Adding the latest course as event.
Putting Resources under the Neubias item, putting the Neubias item into past tense

@jburel

fixes pushed

Ran locally using the docker_startup script.
Looks fine.
We can merge when the build is green
Overall I think we need to think of a better place on our website for people to find the training material


Support custom colors for more code elements

I really like printing data and code in color at the REPL. But being greedy, I wanted color options for a number of additional elements: the constants true, and false, character literals, symbols, and regular expressions. I also wanted colors for syntax quote, unquote, and unquote splicing. Finally, since zprint lets you format with commas, I wanted to color those as well.
This request builds on #140 Ansi Codes (the commits from June 9th). Only the last three commits (on June 20th) are new.
If you're open to coloring commas, I think it may be best for commas and spaces to each be in their own whitespace element. Otherwise, the space after the comma will be colored the same way which can sometimes look funny (for example, if you set a background color or style with :underline or :reverse).

Thanks, this is now in 1.0.1.


Update OWNERS_ALIASES

What this PR does / why we need it:
Add Pan from the documentation team as a reviewer for the runbooks.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

@machadovilaca can you please review?


[MM-11912] Add (revert) Set zero delay before calling emitClearSuggestions

Summary
Fix JS error when opening keyboard shortcuts modal via CTRL+/ by adding (reverting) delay before calling emitClearSuggestions.
Ticket Link
Jira ticket: MM-11912
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Thanks @hmhealey @jwilander.  PR updated.