Custom scaling of items?

Is there currently a way to change the minimum scale of the items. To match the designs I was given I need the middle item to either be larger or the outer items to be smaller. I noticed that the scaleMinimum is set to 0.9 by default but I don't see any way of changing it. Is there something I'm not seeing to do this or Should I try and open a PR to add that functionality. Other than this one small issue the library has been working great for what I've needed. Cheers!

Forgot to mention I have to consume via cocoa pods so I can't just include the three classes and change the scale minimum just for this project :(

Tried subclassing and overriding scale() with a smaller value and realized it affected all the items in the collection view. I believe ScaleDivisor may be the value that I need to find a way to change?

Hi @JulianHunt, glad you like the library. The best way to do this would be to subclass ScalingCarouselCell, and override the scale function, changing the default parameter which is currently defined for this function to whatever value you want, e.g
override open func scale(withCarouselInset carouselInset: CGFloat,
                    scaleMinimum: CGFloat = YOUR_VALUE) {
// HERE, JUST CALL SUPER, PASSING IN YOUR SCALE VALUE
...
}

Right I had actually tried this however that just shrank all the items in the carousel, is there a way to change the size difference/scale between the selected item and the non selected items? Cheers!

Apologies, I didn't correctly read your previous comment, never realised you tried it already! I don't have time to look at this today, but I think you will need to override the scale function and add your own custom calculations. Maybe just grab the code from the original scaling function, and play around with them in your overriding method.

Hi @JulianHunt. I just published version 2.2 of ScalingCarousel, which exposes the properties you wish to alter. When overriding ScalingCarouselCell, you will be able to override the properties and alter the values.


error: failed to push some refs to {url}

I've been going through all the steps on how to make a free host. Everything went fine, until the last step gave me an error: error: failed to push some refs to. I typed git push heroku master
Any fixes?

dont use heroku

dont use heroku

What should I use then?

Long delay but I've seen people using a service called Glitch to host their projects.


E2E tests: Flaky Preview with development mode screenshot

Bug Description
Seeing lots of different from the "Preview with development mode" preview in percy.
Example
Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Looks like we need to await some more selectors or wait for networkidle or something.
ALternatively, we can also remove the screenshot and just check for the presence of some string(s) to verify that the debug mode has loaded successfully.


Feat: add more performance optimization and prometheus metrics for controller

Description of your changes

This PR proposed several optimization techniques to enhance the performance of KubeVela controller and improve the exposure of metrics to monitor system running state.

Use customized ControllerClient as the underlying client instead of the default controller-runtime client. The benefits includes:

Enable detailed metrics for client. The default controller-runtime metrics are unable to get the latency while calling cache, only requests from client-go can be accounted.
Enable customized cache options for unstructured resources (and disable it for child clusters which will lead to chaos). By default, controller-runtime client does not provide a configurable to do this.
For ResourceTracker List by label operation (which will be done almost every time in application_controller reconcile), add customized index to improve the cache read performance. This can prevent the List operation latency linearly increases when application number goes up.

Add configurations and more metrics for system observability. Metrics includes:

Times for each reconcile stage such as executing workflow and garbage collecting.
Times for each reconcile loop grouping by phase transition. This can help us identify high latency reconcile loop reason.  Various transition requires highly different execute time. For example, running workflow can be much more slower than simply patching finalizer. So average reconcile time or p99 metrics cannot accurately reflect the details of reconcile time.
Times for each ControllerClient call. This can distinguish function calls by client-go and cache reader.

Add performance optimization methods as options to use. By default, the methods listed below are not enabled since there are side effects and should be considered depending on the use cases.

optimize-cached-gvks: Optimize controller client cache with specified gvks. If this option is set, target resources with specified gvk will be cached even if they are unstructured types.
optimize-resource-tracker-list-op: Optimize ResourceTracker List Op by adding index. This will increase the use of memory and accelerate the list operation of ResourceTracker.
optimize-controller-reconcile-loop-reduction: Optimize ApplicationController reconcile by reducing the number loops to reconcile application. With this option enabled, application reconcile can reduce the number of reconcile loops by half approximately. It fuses several application phase transitions into one. The side effect is that if errors occurs during the phase transition, the restart process might be time-consuming. It is encouraged to be enabled if all application workflow steps are guaranteed to be idempotent.
optimize-mark-with-prob: Optimize ResourceTracker GC by only run mark stage with probability. When using keep-legacy-resource during gc, by default, the mark stage will loop over all versions of legacy resources and identify which ones are outdated. However, this can be time-consuming if too much (like 20+) versions are kept. Set this option to a float number like 0.1 will only do this check with probability. It is encouraged to be enabled when a lot of versions of applications are expected to be kept.
optimize-disable-component-revision: Optimize ComponentRevision by disabling the creation and gc. If all applications do not use rollout, this option can be enabled to reduce time and space.
optimize-disable-application-revision: Optimize ApplicationRevision by disabling the creation and gc. If application rollback is not needed, this option can be enabled to reduce time and space.
optimize-disable-workflow-recorder: Optimize workflow recorder by disabling the creation and gc. VelaUX relies on this to get workflow running history.
optimize-enable-in-memory-workflow-context: Optimize workflow by use in-memory context. By default, workflow state are kept in ConfigMaps for persistency. Enabling this option can accelerate the retrieval and storing of workflow state. However, if KubeVela Controller is shutdown or restarted, all application workflow running states will be lost. Therefore, application will restart workflow. Ensure workflow steps are idempotent while enabling this.
optimize-disable-resource-apply-double-check: Optimize workflow by ignoring resource double check after apply. While enabling this optimization, the ApplyComponent operation will skip the check the result of resource creation.
optimize-enable-delete-only-trigger: Optimize ResourceTracker by only trigger reconcile when ResourceTracker is deleted. While enabling this optimization, manual edit to ResourceTrackers will not be handled immediately.

I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

How has this code been tested

Special notes for your reviewer

The PR description should be one of the document in kubevela.io \cc @yangsoon @Somefive

The PR description should be one of the document in kubevela.io \cc @yangsoon @Somefive

Right.


Add support for PolicyUrl subpackets

Needs support in BC.

Related upstream PR:  https://github.com/bcgit/bc-java/pull/1115

Upstream PR was merged into BC. Will be usable with BC 1.71


Excluding the encoding option when fs.readFileSync is called causes type error Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.

"bun": "1.1.36"
"typescript": "^5.7.2"
"sst": "3.3.28",
Running tsc --pretty results in the following type error.

.sst/platform/src/components/aws/function.ts:1946:23 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

1946           hash.update(await fs.promises.readFile(zipPath));

.sst/platform/src/components/aws/ssr-site.ts:542:31 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

542                       .update(content)
                                  ~~~~~~~

.sst/platform/src/components/aws/ssr-site.ts:1030:21 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

1030                     fs.readFileSync(
                         ~~~~~~~~~~~~~~~~
1031                       path.resolve(outputPath, item.from, filePath),
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1032                     ),
     ~~~~~~~~~~~~~~~~~~~~~

.sst/platform/src/components/aws/static-site.ts:766:27 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

766                   .update(content)
                              ~~~~~~~

.sst/platform/src/components/aws/static-site.ts:945:25 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

945             hash.update(fs.readFileSync(path.resolve(outputPath, filePath))),
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.sst/platform/src/components/cloudflare/ssr-site.ts:138:29 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

138                     .update(content)
                                ~~~~~~~

.sst/platform/src/components/cloudflare/static-site.ts:336:29 - error TS2345: Argument of type 'Buffer<ArrayBufferLike>' is not assignable to parameter of type 'BinaryLike'.
  Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike> | DataView<ArrayBufferLike>'.
    Type 'Buffer<ArrayBufferLike>' is not assignable to type 'Uint8Array<ArrayBufferLike>'.
      The types returned by 'slice(...).entries()' are incompatible between these types.
        Type 'IterableIterator<[number, number]>' is missing the following properties from type 'ArrayIterator<[number, number]>': map, filter, take, drop, and 9 more.

336                     .update(content)
                                ~~~~~~~

Found 7 errors in 5 files.

Errors  Files
     1  .sst/platform/src/components/aws/function.ts:1946
     2  .sst/platform/src/components/aws/ssr-site.ts:542
     2  .sst/platform/src/components/aws/static-site.ts:766
     1  .sst/platform/src/components/cloudflare/ssr-site.ts:138
     1  .sst/platform/src/components/cloudflare/static-site.ts:336

This can be traced to usages of fs.promises.readFile not including the encoding.
changing
hash.update(await fs.promises.readFile(zipPath));
to
hash.update(await fs.promises.readFile(zipPath, 'utf-8')); makes the error go away

before
after

fixed by https://github.com/sst/sst/pull/5131


tox 3 vs tox 4

Tox 4.0.0 was released. We need to decide what to do about that. Since this docker image uses stable Fedora, it will contain tox3 for a while. Should we document that and let it be? Should we package a conflicting version of tox4 into Fedora? etc.

I'd keep a stable fedora with tox 3 until somebody asks for tox 4 explicitly.


We Value Your Feedback: Share Your Experience Here!

We’re always looking to improve fastmonitor, and your feedback plays a vital role! Let us know what you love, what could be better, or any ideas you have. Your insights help shape the future of this project. Feel free to share your thoughts in this issue. Thank you for being part of our journey!

FastMonitor as a NuGet package is ideal for securing our gaming backend services. It’s easy to configure with our API gateways, allowing us to protect player data with minimal overhead. The granular access controls and logging capabilities are well-suited for monitoring potential breaches during peak loads.

Integrating FastMonitor as a NuGet package into our e-commerce microservices was straightforward. Its modular design fits perfectly with our system architecture, enabling fine-grained control over user permissions. The logging feature has also made it easy to trace suspicious activities during audits


Feature Request: ignored hostnames annotation

If you want to use different load balancer from ingress for existing endpoint. You should disable or change hostname of previous ingress resource and associate the hostname with desired ingress or loadbalancer resource(otherwise external-dns will switch old and new hostnames' dns records continously). In this process, even if dns record has changed, clients may not be able to connect to new dns records because of their local dns cache and they won't be able to connect new loadbalancer until ttl, also previous ingress will return 404 response.
So I hope new annotation for external-dns to ignore previous ingress hostname, so that clients can keep connection before ttl.
I suggest annotation key external-dns.alpha.kubernetes.io/ignored-hostnames and comma separated hostnames for values so that it can ignore only specified hosts in single ingress.

If I understand correctly, you want to keep the old hostname in the Ingress rule (for Ingress proxy host matching (e.g. with Skipper) until DNS caches are refreshed,) and only make External DNS ignore the old hostname in order to not collide with the new Ingress (which might be in a different cluster). Your use case is some form of Ingress migration (same cluster or to new cluster). Correct?

Yes, correct 👍

I was also interested in a more general 'ignore this resource' annotation (e.g. external-dns.alpha.kubernetes.io/ignore: "true").
The use-case in this scenario was for a certain subset of hosts where I don't want the DNS to be published based on the Ingress resource, and instead would like to manage it with a DNSEndpoint resource instead (for programmatic reasons).
In the first instance of DNS creation, it's not clear to me which one is considered 'less' here: https://github.com/kubernetes-incubator/external-dns/blob/master/endpoint/endpoint.go#L93, so I'm not sure it's reliable enough to just create both resources and hope the DNSEndpoint  wins


Split FutureUtils in to dedicated mvn package?

https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/util/FutureUtil.java
The source code is a very good Future library , i never found any other library like it.
I also want to use it for our projects.
I wonder to know, may your please release it under a dedicated mvn package?
We only need the Future, Not the whole pulsar-common

Thanks for reporting your use case @cnmade!
There is no plan for such releasing. But since it's no more than one source file which is accessible under the Apache License 2.0 which allows you to freely use, modify and distribute, you can simply copy the code for your usage - remember to keep the license header.


ICurrentSearch Store development

This is a subtask of #4
Development of the store from geocoding input.
The State: ICurrentSearch {   name: string;   lat: number;   long: number; }

Bear in mind Angular Style Guide (https://angular.io/styleguide#!#03-03) :wink:

One user case:
The search returns no result. How we have to deal with it?
I can imagine two posible responses:

We simply store the no results search as a state. So, in the view the previous search list and map locators dissapear and a warning with 'NO_RESULTS' is displayed.
We does not change the state, so the previous search is maintained and the view for the list and map locators remains unchanged. A warning with 'NO_RESULTS' is displayed.

My personal preference: Option 2.
What do you think @zuzust @sgimeno @laklau ?

I agree with you @plastikaweb. In this scenario no geosearch is triggered, so the front shouldn't react as no change to the list of places is performed. No change to the centre of the previous search should be performed neither. The only decision to make is where in the UI should appear the message. Let's see what @sgimeno has to say.


Bidbot failed to import deals to lotus-miner

Installed bidbot this morning and saw some deals coming in. It's great!!!
However, Bidbot reported the following errors:
2021-08-14T17:02:24.706-0700    INFO    bidbot/store    store/store.go:589      importing /media/data/bidbot/bafybeig2ohx5vgy3zkjtbfzmuc6frlt6f7j27wel2xaduxun4y7pf5prmy_01fd3az5ef5s8w8jta7fk147nn to lotus with proposal cid bafyreiemvqoyyfzxnooafx62cqa736frakosc3wzxn4pudv2caegnosc6i
2021-08-14T17:02:24.709-0700    INFO    bidbot/store    store/store.go:602      finished fetching data cid 01fd3az5ef5s8w8jta7fk147nn (status=queued_data error=calling storage miner deals import data: failed to open file: open /media/data/bidbot/bafybeig2ohx5vgy3zkjtbfzmuc6frlt6f7j27wel2xaduxun4y7pf5prmy_01fd3az5ef5s8w8jta7fk147nn: no such file or directory)
2021-08-14T17:02:24.709-0700    INFO    bidbot/store    store/store.go:574      fetching sources {url: https://cargo.web3.storage/deal-cars/bafybeibh4odehtgqkebzql57vavtofdx4mzecnfrzbtabnftlkpzecowte_baga6ea4seaqhkrbvrnybfv45tb47ow6exo7bggmk3nyufhquwsscsq3ajzc6wha.car,}

I went to the directory and checked, the file doesn't exist.
Searching the file in miner logs, found that miner also reported the file doesn't exist:
2021-08-14T17:02:06.109-0700    INFO    miner   miner/miner.go:478      completed mineOne       {"tookMilliseconds": 17, "forRound": 1022645, "baseEpoch": 1022644, "baseDeltaSeconds": 6, "nullRounds": 0, "lateStart": false, "beaconEpoch": 1118489, "lookbackEpochs": 900, "networkPowerAtLookback": "10460691787091902464", "minerPowerAtLookback": "296846329282560", "isEligible": true, "isWinner": false, "error": null}
2021-08-14T17:02:17.157-0700    INFO    net/identify    identify/id.go:376      failed negotiate identify protocol with peer    {"peer": "12D3KooWPXd8KSfgy5s6qR6RvMPoXm5gErHFGAuNmgVBqPR61ZZA", "error": "stream reset"}
2021-08-14T17:02:24.706-0700    WARN    rpc     go-jsonrpc@v0.1.4-0.20210217175800-45ea43ac2bec/handler.go:279  error in RPC call to 'Filecoin.MarketImportDealData': failed to open file:
    github.com/filecoin-project/lotus/node/impl.(*StorageMinerAPI).MarketImportDealData
        /home/filecoin/filecoin/lotus/node/impl/storminer.go:399
  - open /media/data/bidbot/bafybeig2ohx5vgy3zkjtbfzmuc6frlt6f7j27wel2xaduxun4y7pf5prmy_01fd3az5ef5s8w8jta7fk147nn: no such file or directory

Lotus-miner version:
Daemon:  1.11.1-rc2+mainnet+git.40449f1cc+api1.2.0
Local: lotus-miner version 1.11.1-rc2+mainnet+git.40449f1cc

Bidbot setup:
lotus fullnode, lotus-miner, bidbot are all running separate machines.
both bidbot and lotus-miner have access to a shared nfs path:
/media/data/bidbot
in the bidbot machine, this env is set:  BIDBOT_DEAL_DATA_DIRECTORY=/media/data/bidbot

Can you post the full bidbot logs here?

bidbot.log
here you go @merlinran

I have additional information to update: initially I didn't set up the NFS shared folder properly for bidbot machine and lotus-miner machine to access the same /media/data/bidbot data folder. This might have caused some data import error on the lotus-miner side.
When I saw that happened, I connected with @jsign and he advised me to make the shared folder.
Could the above error (file missing) the results of the lotus-miner failed to import, and got the GC to deleted the downloaded files on bidbot side?

This is interesting... bidbot uses exact the file path downloaded to import data https://github.com/textileio/bidbot/blob/main/service/store/store.go#L591 so I can not think of a situation that the file can not be found, unless it's removed somehow.
Can you run something like this to get a sense how the directory changes? Then we can match that with bidbot logs.
while true; do date; ls -la /media/data/bidbot; sleep 60; done | tee deals_data_dir

$ while true; do date; ls -la /media/data/bidbot; sleep 60; done | tee deals_data_dir
Sun 15 Aug 2021 09:45:25 AM PDT
total 8
drwxrwxrwx 2 filecoin filecoin 4096 Aug 15 09:43 .
drwxr-xr-x 8 root     root     4096 Aug 14 20:32 ..

I ran the bidbot under user name filecoin using the following command:
nohup /media/lotus/deals/bidbot/bidbot daemon >> /media/lotus/logs/bidbot.log 2>&1 &

I have two good news:
a. A few new deals came in and they were successfully imported and sealed yesterday. I haven't seen deals today yet. Hopefully deals from now can be downloaded and imported without issues.
b. I talked to @jsign yesterday to manually recover those failed files. So I went ahead and download the web3 storage files myself into separate folders, and completed the import data command to lotus-miner. Those deals that failed yesterday are now successfully imported through manual steps. Although the bidbot were still printing error logs like this for those manually imported deals - I'm not sure how to help refresh but just ignoring them for now:
2021-08-15T09:43:06.265-0700    INFO    bidbot/store    store/store.go:358      bid 01fd3az8c3h3cfe3nc2hyzp9kp already in 'errored', duplicated message?
2021-08-15T09:43:06.265-0700    INFO    bidbot/service  service/service.go:363  bid 01fd3az8c3h3cfe3nc2hyzp9kp received proposal cid bafyreiemh5onnjwj562gykdfuoli6zvbpr75afdeszjqtb6cl6vyn4wvf4 in auction
```01fd3az4wnjqgy98pxwvzb5qff

Oh sorry my suggestion was to keep running the script alongside with bidbot to track the changes of the directory. Now that you have new deals passed that stage so things should be good, but I'd keep running that for a couple of days just in case when it happens again.
bidbot GC by default deletes the files 24 hours after completion or errors, which doesn't sound like a cause of this.
you can ignore the "duplicated message" lines for now - they are INFO anyway.


Assess and improve security

https://themeteorchef.com/blog/securing-meteor-applications/

If anyone has suggestions please mention them here or make a PR.

Closing this general issue for now, since I've made a few updates to security in development. See #33.
Will reopen more specific tickets for remaining issues.


Adding support for "Live Kernel Memory" dump type (0x6)

Description
This PR adds support for "Live Kernel Memory" dump type (0x6), including Python API, and tests.
As indicated here such dump can be generated as such:

But is actually processed the same way as regular bmp dump:

As a result, this PR only implements the type itself, and binds it to the "normal" BMP routine (i.e. BuildPhysmemBMPDump).
Fixes #26

Hell yeah! I am guessing at least some of the tests are failing because the new dump isn't part of the testdatas? Send it my way and I'll add it up 🙏🏽
Thanks again man!

All right, I added the file to the testdatas, re-running the tests to see what is left to address..

Okay, most parsers get built properly now - just OSX to figure out. Not sure what's going on with the binding targets yet though 🤔

Lol, while compiling with latest compiler 😅
(249c.599c): Access violation - code c0000005 (!!! second chance !!!)
c1xx!GetQualifiedIdForMember+0x1e:
00007fff`7623d4de f7421000000400  test    dword ptr [rdx+10h],40000h ds:00000000`00000010=????????

All right, making progress - we just need to figure out what's the deal with OSX and how do we work around the MSVC bug on Windows 😅

Okay so the osx-large is actually only usable for paying customers 🤦🏽♂

Okay - have a look whenever you have some time @hugsy and let me know what you think.
The OSX part is annoying as I don't know how easy it'd be to port / have all the bindings etc work properly on ARM64 🤷🏽♂
For Windows, maybe you have a better idea; I can also file a bug to make sure to update the CI back to windows-latest when the frontend doesn't crash anymore 😔
Cheers

Regarding windows-2022, the bug is reported on both sides (vs & nb) and known:

https://github.com/wjakob/nanobind/issues/613
https://developercommunity.visualstudio.com/t/Internal-compiler-error-w-nanobind-v19/10662883?sort=newest

I've also pinned the rest of runner images so that everything should keep working for future updates and we can introduce newer runner as they become more stable.

Okay I think we're good to go, merging - thank you again @hugsy!

All right - this took a while but I finally fixed the way I was generating wheels for Linux so that it doesn't break anymore.
What happens for the 0.7.3 release is that we were generating them 'manually' and it turns out their names has meaning to pypi. I tried to upload them and the Linux ones were rejected. I decided to rename the package to make it happy and they did get uploaded, but the package were actually broken. Once downloaded a checksum wouldn't match and installation would fail. Note that this whole thing only affected Linux packages (as far as I know; at least Windows ones were fine).
To fix this, you are apparently to build wheels using the cibuildwheels project which I now use (see #32).
v.0.7.4 should now work on both Windows & Linux:
(base) c:\Users\over\Downloads>pip install --upgrade kdmp_parser
...
Installing collected packages: kdmp_parser
  Attempting uninstall: kdmp_parser
    Found existing installation: kdmp-parser 0.7.3
    Uninstalling kdmp-parser-0.7.3:
      Successfully uninstalled kdmp-parser-0.7.3
Successfully installed kdmp_parser-0.7.4

(base) c:\Users\over\Downloads>ipython3
...
In [1]: import kdmp_parser

In [2]: kdmp_parser.KernelDumpParser("fulllivekernelmemory.dmp")
Out[2]: KernelDumpParser(fulllivekernelmemory.dmp, 6)

over@panther:/mnt/c/Users/over/Downloads$ pip install --upgrade kdmp_parser
...
Installing collected packages: kdmp_parser
Successfully installed kdmp_parser-0.7.4

over@panther:/mnt/c/Users/over/Downloads$ ipython3
...
In [1]: import kdmp_parser

In [2]: kdmp_parser.KernelDumpParser("fulllivekernelmemory.dmp")
Out[2]: KernelDumpParser(fulllivekernelmemory.dmp, 6)

Sorry for the lag on this, and thank you again!


Spotify - temporary web token seems not to be available anymore

It looks like you can't just get a token from the website anymore.
You can get a token using OAuth2, but that token doesn't allow access to https://api.spotify.com/v1/views/desktop-home, so no more homepage but users and their playlists seem to work OK.

Nup, it is still there.


chore: 4.8

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade assessment condition incorrect

_SMSTSOSUpgradeActionReturnCode should be continue if condition "equals"<PHONE_NUMBER> because that means there was no issues found.
(admin edit: adding metadata to link with assumed article)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cfe3442-b59d-0d77-d9af-f18e787ec99d
Version Independent ID: 60cb54a2-d1fd-92b5-b027-de8a85c7af64
Content: Create an OS upgrade task sequence - Configuration Manager
Content Source: sccm/osd/deploy-use/create-a-task-sequence-to-upgrade-an-operating-system.md
Product: configuration-manager
Technology: configmgr-osd
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Hi @Xavantsa, I'm assuming you're referring to this section to Perform an inline compatibility assessment. The condition applies to the Run Command Line step, which fails the task sequence with that return code. So you only want it to happen when the result of the assessment is anything other than success.
I'll keep this issue open, as given your question, I think we should clarify it a bit to explain the use of the Run Command Line step. Thanks for the feedback.

I made a change for this to help clarify, it should publish live later today. Thanks again for the feedback! 😄


_Float16 is not present on g++

the _Float16 type is not present on arm g++
Environment
g++ 7.4 7.5 and others
C++ standard mode (e.g. 17, 20, 'latest'):
not applicable
Target arch (e.g. x64):
arm64, arm
Library configuration overrides:
not applicable
Relevant compilation flags:
see steps to reproduce link
Describe the bug
_Float16 is not available desptite gcc documentation saying one should use it
It's only available for C not C++
Steps to reproduce (or a small repro code sample)
https://godbolt.org/z/5e6rdP
The last one shows it's visible for C
Additional information

Is this causing a compiler error for you? I've been able to compile with float16 support on arm64.

Is this causing a compiler error for you?

Never mind, I've just tried compiling again on my arm64 tester and see the issue. Thanks, I'll look into this.

Should this be included in CI? I mean multiple compiler and compiler versions etc.

Yeah, probably. The main reason it's not currently testing lots of compilers was to keep the Docker image small-ish.
I test lots of different compilers and configs on my own machine before committing, as well as testing on ARM64 using an rpi4:

clang 6 - 11
GCC 7 - 10
vs 2019
with/without exceptions
C++17 and C++20

I'd like to migrate the CI to use GitHub actions and at that point I'd automate more platforms, but don't really have the time at the moment.


fix(operator, upgrade): handle CRD upgrade from operator

This PR handles the upgrade scenarios of CRDs (disk, bd and bdc). When a new change is seen in the CRD object, operator will create a json patch and update the CRD object with the patch.

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   52.73%   52.73%
=======================================
  Files          51       51
  Lines        2395     2395
=======================================
  Hits         1263     1263
  Misses       1036     1036
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0314b...01c28a5. Read the comment docs.


feat(design-system): deprecate old DS styles and update icons to make them compatible with the new XDS

I have removed the icons indicated below because they are not present in the Figma library.
We where not using the nq icons, the checkbox-card icons are being used in the archetype, we can ask @cris-crash if we should keep them or If the should be replaced with the new ones.
BREAKING CHANGES

design-system: old DS icon styles are now deprecated. To continue using them, import the deprecated-full-theme.css file.
icons: remove checkbox-card, nq1, nq2, nq3, and nq4 icons.

EX-7783

Hi @ajperezbau, just delete Nq1 icon from next-queries.vue file (in docs part)


🛢 [MetaCI] Adding rough draft of release cohort

This ligtm; seems like it's covering all AC mentioned in: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07AH000000UdnYYAS/view
The third AC does mention:

A Release has its own Merge Freeze Start and Merge Freeze End fields which are optional overrides for the Release's Cohort dates.

Is anything needed to make these fields "override" release cohorts merge freeze values? Or is the precense of the field on the Release object all we're looking for here? cc @davisagli

@Br4nd0R I assumed the cci task we create to cover merge freeze will pass in these fields depending on their presence i.e. follow the following logic, if product specific merge freeze start and stop dates are used we will use those otherwise we will pass in the Cohort values as the default when no values are defined. @davisagli
@Br4nd0R something similar to https://github.com/SFDO-Tooling/MetaCI/blob/main/metaci/build/models.py#L698

@Br4nd0R @jofsky when we discussed on Monday we decided that we don't actually need the ability to override the merge freeze start and stop for a particular Release. That came up while discussing the release cohort view, and I think we just neglected to come back to this story and remove that AC.


#1 Init project

Init project with Maven artifact

Detailed summary

Added a Maven build workflow in  . github/workflows/maven-build.yml.

Updated the .pom.xml.  file with project information, licenses, developers, issue management, CI management, SCM details, and properties.

Set the Java version to 17 in the pom.xml file.

close #1


Add RevocationBitmap2022 documentation

Description of change
Adds the specification and documentation for RevocationBitmap2022.
TODO

Decide what to do with the validate_university_degree tutorial.

Links to any relevant issues
part of #853
Type of change
Add an x to the boxes that are relevant to your changes.

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] Enhancement (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Fix

How the change has been tested
Test vectors were added in #861.
Change checklist
Add an x to the boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Since there is a separate issue now, I would reduce the scope of this PR to just the specification and handle #907 separately.


Revert #3135 "fix(engine): apply output substitutions for all sources"

This reverts commit 4ef7c9553aaea2bfe75aa867650c7e9745c2909f.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix(engine): enable output substitution only for syscall rules, prevent engine from crashing when a plugin is loaded and -pc/pk is specified

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

da2553f Revert "fix(engine): apply output substitutions for all sources"

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.38.1

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, LucaGuerra, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LucaGuerra side note: we should also officially document that -pk (and other presets) works with syscalls source only

Side note: engine is not crashing but is triggering a validation exception :)

https://github.com/falcosecurity/falco/pull/3238

/unhold


WIP(iox-10578): patched df upgrade 202-04-23

⚠ This will not be merged. ⚠

Bringing us up to datafusion to 2024-04-23 https://github.com/apache/datafusion/commit/65ecfda84f7a105412bbf4040885a1b1774668d1 / https://github.com/apache/datafusion/pull/10204

This PR is based on April 20, 2024 https://github.com/apache/datafusion/commit/600b815097b2b1ebbde3f48d071852bd6364a30a

git co -b chunchun/update-df-apr-week-4 600b815097b2b1ebbde3f48d071852bd6364a30a

Applied the following patch(es):

Cherry picked https://github.com/apache/datafusion/pull/10224 /
https://github.com/apache/datafusion/commit/9c8873af12826e47f5743991859790df7a3b6400
commit 9c8873af12826e47f5743991859790df7a3b6400
Author: wiedld<EMAIL_ADDRESS>Date:   Fri Apr 26 03:42:16 2024 -0700

    Allow adding user defined metadata to `ParquetSink` (#10224)

cherry picked https://github.com/apache/datafusion/pull/10242 / https://github.com/influxdata/arrow-datafusion/commit/f8c623fe045d70a87eac8dc8620b74ff73be56d5
commit f8c623fe045d70a87eac8dc8620b74ff73be56d5
Author: Jonah Gao<EMAIL_ADDRESS>Date:   Sat Apr 27 02:30:09 2024 +0800

The upgrade is done. Closing


Replace println macro with log crate

https://crates.io/crates/log

Log crate is not suitable for executables, which is the case of cmvm.


Fixed memory leaks in AKSequencer and AKMusicTrack

Found a couple of memory leaks in AKSequencer and AKMusicTrack, so thought I'd do a PR for it. Never done anything for open source before so sorry if this is the wrong way to go about it! Thanks.

Thank you very much!


Calendar/Date Input - Refs #445.

This is a js date entry widget built expressly for bootstrap. It's fairly thin, at 2.1K min/gz, but still somewhat extensible. It supports keyboard navigation, reverts to iOS native date entry, and a few other little features. It's pretty thoroughly tested in all the browsers that Bootstrap lists support for, although the visual design could probably be improved.
Demo here:
http://dl.dropbox.com/u/143355/datepicker/datepicker.html

Nice one, I like it

+1

Great work! I'll keep this in mind when we start working our datepicker for 2.0. In the meantime you should release this as a plugin and I'll add it to our wiki!

Ah ok, so I should re-submit this as a patch against 2.0-wip?

I ran into an issue using the datepicker inside a modal box. Since it is inside the modal which is position: fixed; the position: absolute; of the datepicker causes the top/left to be from the modal box instead of the viewport. I'm not actually sure of a fix for this.

Hi, inside a modal box a quick fix is to comment out the positioning on line 208 and add show method. Dirty, but temporarily worked.
    var offset = this.$el.offset();

    /*this.$picker.css({
      top: offset.top + this.$el.outerHeight() + 2,
      left: offset.left
    }).

    this.$picker.show();

Very nice.... it would be nice to add the time to it as well ... but it is very nice the way it is ;)

Cool man, keep it up ! The missing twitter bootstrap widget :)

Sweet! had managed to mix your datepicker with formtastic-bootstrap.

Nice work!
One issue: as .offset() returns position relative to the doc, and the datepicker is inserted directly after the input, the positioning didn't work correctly for me. My wrapping  was relatively positioned meaning the datepicker was positioned relative to it, and not the document (where the offset came from).
Easy fix was to change where the datepicker is inserted to just before the closing body tag on line 95:
      .appendTo($('body'));

Thanks again for your work :)


Y dose not move the title

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version.
it's just only the Y not the X
this bug has been in JS engine it's whole entire time I wanted to move the logo but the rotate prevents it from putting it to that position can you please fix it

Command Prompt/Terminal logs (if existing)
o

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
o

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I only added scripts
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here.
Yes

its endY that moves it
titleY = start position of animation
endY = end position of animation
which means that its not a bug

ill give a step by step vid, hold on

https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/assets/145304742/34a02d27-b287-4180-87f7-33a4e9cffb51

fullscreen the vid
i forgot to size up the txt

fullscreen the vid i forgot to size up the txt

ok good thanks for help

np

np

can you join my mod Community, you're actually probably pretty good at doing Sprites and other cool stuff

what is it about exactly?
im tryin to make sure

well it's for something like code and other stuff

no like, what is the mod about. not the work

well I would have to explain a lot and that would take too long

i think the logo will explain it

i would close this if i were you

since the thing is solved


Update panel.js

for easy to read
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Applicable Issues

Thank you for the pull request.  However, the Atom team prefers using line comments rather than block comments for documentation purposes.
Again, thanks for your interest in Atom!


Stop pretrained embeddings from loading during inference

In interactive.py and generate.py , if we try to load a model which was trained pre trained embeddings, it will try to load the files, eventhough the model checkpoints files we give have the embedding weights.

We have a big update coming soon, where we've reworked pretrained embeddings (among many other changes), so I'll incorporate a fix there but it'll need to be slightly more general, since not all models may support pretrained embeddings.
I'll keep this open for now and will close it once the update lands.

Just following up on this. You can now accomplish this with --model-overrides, for example:
--model-overrides "{'encoder_embed_path':None}"


Integrate pdfjs viewer

Motivation
Most pdf viewer extensions are outdated, or are part of large extensions (Quarto, LaTeX Workshop), or are a bit sketchy.
I've some experience in integrating pdfjs to VSCode. If you agree I could add it to tinymist (right now I'm extremely busy, but in a few weeks I could do it).

What's the purpose of having an integrated pdfjs viewer? LaTeX Workshop needs one for previewing but we don't need for the same reason. I guess Quarto is same. It seems like the external pdf viewers are often playing better on pdf features, like adobe pdf and samutrapdf.

I tend to agree since in tinymist most of the previewing is done through typst.ts, but I'm not sure that there is a way to open an external pdf viewer from VSCode. Currently if you don't have additional extensions installed the preview pdf button opens the source code of the pdf. If an external viewer could be configured I'm all for it

we can have something like tinymist.pdfViewer which specify some program for opening pdf files. Before this, perhaps there is also some builtin way to configure a program for opening PDFs in VSCode. It is worth to have an investigation.

If we agree on this, we can change the issue to need the capability to configure the way of opening PDFs.

Yes, I agree. IIRC there is an extension to open external viewers, but it would be nice to avoid that dependency if that's not too hard to implement.

Is this issue limited to vscode plugin all the whole language server?

I don't see any gain in adding this as a, say, subcommand of the language server. At the command line it's trivial to open your favourite viewer. In most other editors, as neovim, it's also trivial to hack up a couple of lines to do it. The problem is VSCode that for all its configurability it's not actually extensible (other than by installing an existing extension) if you're not willing to pull your own extension with all the required tooling and scaffolding alongside.


DATE_LABEL not always decreasing

Describe the bug
DATE_LABEL not always decreasing. Sometimes a higher date is below a lower date and sometimes dates are repeated.
To Reproduce
Steps to reproduce the behavior:

Open tx list in poc for safe: 0x1230B3d59858296A31053C1b8562Ecf89A2f888b

Expected behavior
DATE_LABELS should be continuously decreasing. See screenshots.
Desktop (please complete the following information):

OS: Android

Additional context

1
2

This is caused because of the out of order timestamps from non-executed transactions. It was agreed beforehand that these should be filtered anyways. This should be best probided by the core services endpoint as a filter option. This should solve the issue

This depends on https://github.com/gnosis/safe-transaction-service/issues/198


Add OpenCL variants on MacOS

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Checks

[ ] If unspecified, default package should be opencl_impl == apple
[ ] When installing another package that uses OpenCL on the same env, Conda should install the variant opencl_impl == khronos (for new and existing environments)
[ ] User can select variants using the build string openmm=*=*apple* or openmm=*=*khronos*

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

As far as I understand it (which is not very far!), it looks ok to me.

Ok! I am going to merge to the test label and run some checks whether the behavior is the one we expect. I'll post the instructions here so MacOS users can help out!

Check https://github.com/conda-forge/openmm-feedstock/issues/21#issuecomment-735855671 for instructions!


[FLINK-35241][table]Support SQL FLOOR and CEIL functions with SECOND and MINUTE for TIMESTAMP_TLZ

What is the purpose of the change
We need a fix for both SECOND and MINUTE.
The following query doesn't work:
SELECT
  FLOOR(
      CAST(TIMESTAMP '2024-04-25 17:19:42.654' AS TIMESTAMP_LTZ(3))
  TO MINUTE)

These two queries work:
SELECT
  FLOOR(
      CAST(TIMESTAMP '2024-04-25 17:19:42.654' AS TIMESTAMP_LTZ(3))
  TO HOUR)

SELECT
  FLOOR(
      TIMESTAMP '2024-04-25 17:19:42.654'
  TO MINUTE)

Stack trace for the first not working query from above:
Caused by: io.confluent.flink.table.utils.CleanedException: org.codehaus.commons.compiler.CompileException: Line 41, Column 69: No applicable constructor/method found for actual parameters "org.apache.flink.table.data.TimestampData, org.apache.flink.table.data.TimestampData"; candidates are: "public static long org.apache.flink.table.runtime.functions.SqlFunctionUtils.floor(long, long)", "public static float org.apache.flink.table.runtime.functions.SqlFunctionUtils.floor(float)", "public static org.apache.flink.table.data.DecimalData org.apache.flink.table.runtime.functions.SqlFunctionUtils.floor(org.apache.flink.table.data.DecimalData)", "public static int org.apache.flink.table.runtime.functions.SqlFunctionUtils.floor(int, int)", "public static double org.apache.flink.table.runtime.functions.SqlFunctionUtils.floor(double)"
at org.codehaus.janino.UnitCompiler.compileError(UnitCompiler.java:13080)
at org.codehaus.janino.UnitCompiler.findMostSpecificIInvocable(UnitCompiler.java:9646)
at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:9506)
at org.codehaus.janino.UnitCompiler.findIMethod(UnitCompiler.java:9422)
at org.codehaus.janino.UnitCompiler.compileGet2(UnitCompiler.java:5263)
...

Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Added unit tests in TimeFunctionsITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

Is there any documentation for this function?  If it mentions details, we may need to update them.

@flinkbot run azure

I will have a look at this tomorrow
meanwhile can you create a separate jira issue for the rest?

I will open an jira ticket for it

I will have a look at this tomorrow meanwhile can you create a separate jira issue for the rest?

I will open an jira ticket for it

Create an apache flink jira ticket to handle rest issue: https://issues.apache.org/jira/browse/FLINK-36898

Reviewed by Chi on 12/12/24. appears that this PR is healthily progressing

Reviewed by Chi on 12/12/24. appears that this PR is healthily progressing

@flinkbot run azure

@snuyanzin can I get an another code review, thank you.


Connect Transgender website to its specific files on Gdrive

Transgender website needs its own JSONs

Connected
JSON need to updated based on the latest version of the content


[Feature Request] Wishlist functionality

Hey, when is the wishlist functionality coming? It's a core feature in my opinion

Hi @BogdanChayka, this feature is definitely on our to-do list. Sadly I can't just yet tell you when this will be implemented.

@pantrtxp alright, will it be at least in 6.1 ? because my customer expects it in his relaunch

Sorry to tell you but it is not planned yet. Maybe there will be a plugin from the community for it.
The SW6 wish list will presumably be slightly different as well. More like a persistent shopping cart AFAIK, so maybe a plugin would fit your needs better.

@pantrtxp I would do a plugin, but so far only extending backend works, I can't override Storefront Classes in plugin for some reason and there is no real documentation on that, for example I would like to override the ProductLoader, instead I have to work with the API

@BogdanChayka what are you trying to achieve?
We throw events for most use cases in the Storefront part, so there shouldn't be a need for overriding.
Did you check the ProductLoaderCriteriaEvent? What are you missing there?

@BogdanChayka
Can I close this or do you still ne our support?

Closed due to inactivity.

Why the documentation shows you how to use the wishlist, when the settings don't exist ?


Decide about osx-arm64; fix it if supported

If osx-arm64 is a supported platform (and going forward, that basically asks whether osx is a supported platform, as arm architecture takes over), then the builds should be green.
There have been many merges here with broken CI for osx-arm64, which leads to resolution errors downstream (e.g. https://github.com/conda-forge/stir-feedstock/pull/116).
IMO osx-arm64 needs to be either fixed (preferable) or dropped.

CC @chrisburr @vepadulano

IIRC the original problem is ROOT can't be cross-compiled, so @chrisburr was manually building ARM packages locally. I would assume we might have native support in conda-forge's CI now?

Thanks for the context. Should we re-attempt cross-compilation? I don't remember many cases where that wasn't ultimately solvable (even if we need to compile some extra stuff for the build agent architecture during building).

I would assume we might have native support in conda-forge's CI now?

No we don't yet. The macos-14 images are still running on amd64 agents at last check

IIRC the original problem is ROOT can't be cross-compiled, so @chrisburr was manually building ARM packages locally

Is there someplace where there's a summary of the issues on why ROOT can't be cross-compiled?
@chrisburr, were you doing something beyond just running python build-locally.py? If not, then some of us who have Apple silicon machines could help out with this.

Can someone (yep, that might include myself, if instructed properly :wink: ) with an Apple Silicon be of any help to try to solve this or is there a fundamental technical problem preventing it ? (I have no idea how conda builds work, sorry, I'm just an end user currently)
(I'd love to be able to work again with a Conda Root package on my M1 Mac...)


[WIP]refactor transformer

This PR  is related to the basic operations of Vision Transformer.

Design a unified data-flow for the transformer.

Design a BaseTransformerLayer as base-class of TransformerEncoderlayer  and TransformerDecoderlayer  in the vision transformer.  It contains several basic operations such as attention, layer norm, and FFN.  It can be built from ConfigDict and supports customization, for example, you can specify any number of FFN or LN  and use different kinds of attention by specifying a list of ConfigDict named attn_cfgs. It is worth mentioning that it supports prenorm.

Design a  BaseTransformerCoder as base-class of tranformer_coder(Encoder and Decoder)   in the vision transformer. Support customization such as specifying different kinds of transformer_layer in tranformercoder

All base classes related to transformers have been migrated to the mmcv.
Details
1 More unified data flow
Design a  unified data flow for vision transformer and add **kwargs to adapt to other transformers (e.g., deformable-detr) .
query (Tensor): Input query with the shape
    `(num_query, bs, embed_dims)`.
key (Tensor): The key tensor with shape
    `(num_key, bs, embed_dims)`.
value (Tensor): The value tensor with shape
    `(num_key, bs, embed_dims)`.
query_pos (Tensor): The positional encoding for `query`.
    Default: None.
key_pos (Tensor): The positional encoding for `key`. Default
    None.
attn_masks (list[Tensor], optional):  2D Tensor used in the calculation of corresponding attention.
    Defaults: None.
query_key_padding_mask (Tensor): ByteTensor for `query`, with
    shape [bs, num_query]. Only used in self-attention
key_padding_mask (Tensor): ByteTensor for `query`, with
    shape [bs, num_key].

2 BaseTransformerLayer
It uses the unified data flow and can be initialized by basic arguments of all TransformerLayer  such  as
        attn_cfgs (list[`mmcv.ConfigDict`] | list[dict] | dict )):
            Configs for self_attention or cross_attention, the order
            should be consistent with it in `operation_order`. If it is
            a dict, it would be expanded to the number of attention in
            `operation_order`.
        feedforward_channels (int): The hidden dimension for FFNs.
        ffn_dropout (float): Probability of an element to be zeroed
            in ffn. Default 0.0.
        operation_order (tuple[str]): The execution order of operation
            in transformer. Such as ('selfattn', 'norm', 'ffn', 'norm').
            Support prenorm when you specifying first element as `norm`.
            Default：None
        act_cfg (dict): The activation config for FFNs.
        norm_cfg (dict): Config dict for normalization layer.
        ffn_num_fcs (int): The number of fully-connected layers in FFNs.
            Default：2.

The  forward function can be used in both TransformerEncodeLayer and TransformerDecodeLayer by specifying different operation_order.  It supports pre_norm  when you specifying the first operation as norm in operation_order.
3 BaseTransformerCoder
It uses the unified data flow and can be initialized by basic arguments of all BaseTransformerCoder  such  as
        transformerlayer (list[obj:`mmcv.ConfigDict`] |
            obj:`mmcv.ConfigDict`): Config of transformerlayer
            in TransformerCoder. If it is obj:`mmcv.ConfigDict`,
             it would be repeated `num_layer` times to a
             list[`mmcv.ConfigDict`]. Default: None.
        num_layers (int): The number of `TransformerLayer`. Default: None.

Usages

TransformerLayer

you can build the TransformerEncoderLayer  by giving a ConfigDict which looks like

         codelayers=dict(
                type='BaseTransformerLayer',
                attn_cfgs=dict(
                    type='MultiheadAttention',
                    embed_dims=256,
                    num_heads=8,
                    dropout=0.1),
                feedforward_channels=2048,
                ffn_dropout=0.1,
                operation_order=('selfattn', 'norm', 'ffn', 'norm'),
            )
    # or more general,  you can specify different attentions in `TransformerLayer`.
            codelayers=dict(
                type='BaseTransformerLayer',
                attn_cfgs=[
                    dict(
                    	type='Attention_1',
                    	embed_dims=256,
                    	num_heads=8,
                    	dropout=0.1,
                    	other_args = xxx,
                        ...
                    ),
                    dict(
                    	type='Attention_2',
					    args=xxx,
                        ......
                    )
                ],
                feedforward_channels=2048,
                ffn_dropout=0.1,
                operation_order=('selfattn', 'norm','selfattn', 'ffn', 'norm'),
            )

   # you can build the layer by
    from mmcv.cnn.bricks.transformer import build_transformerlayer
	build_transformerlayer(codelayers)

For BaseTransformerCoder， you can build it by

            encoder=dict(
                type='DetrTransformerEncoder',
                num_layers=6,
                    transformerlayers=dict(
                        type='BaseTransformerLayer',
                        attn_cfgs=[dict(
                            type='MultiheadAttention',
                            embed_dims=256,
                            num_heads=8,
                            dropout=0.1)],
                        feedforward_channels=2048,
                        ffn_dropout=0.1,
                        operation_order=('self_attn', 'norm', 'ffn', 'norm'),
                    )
            ),

# or more general, you can specify different layers in the coder.
            encoder=dict(
                type='DetrTransformerEncoder',
                num_layers=2,
                    transformerlayers=dict(
                        type='BaseTransformerLayer',
                        attn_cfgs=[dict(
                            type='MultiheadAttention',
                            embed_dims=256,
                            num_heads=8,
                            dropout=0.1),
						dict(
                        	type='BaseTransformerLayer',
                        	attn_cfgs=[dict(
                            	type='xxx;ayer',
                            	args=xxx)
                         ],
                        feedforward_channels=2048,
                        ffn_dropout=0.1,
                        operation_order=('self_attn', 'norm', 'ffn', 'norm'),
                    )
            )
# you can build it by
from mmcv.cnn.bricks.transformer import build_transformercoder
build_transformerlayer(encoder)

BC-breaking
None

Overall, the design of refactoring looks good to me.

Resolve conflicts.


typo in master and release

@mathomp4 There is typo in the master and some releases. The string on compiler and the base lib should be <IP_ADDRESS>,  not <IP_ADDRESS>

@weiyuan-jiang There was indeed a bug in yours, but master is okay:
https://github.com/GEOS-ESM/ESMA_env/blob/feb19e6cb89e1fce72311cab6aea27952d684665/g5_modules#L138-L142
I pushed the tag I gave you since, well, no one could use it.

Why not put the sles 11 into the tag you give to GEOSldas? I think it is helpful

Why not put the sles 11 into the tag you give to GEOSldas? I think it is helpful

Because then you would have two different compilers one of which you have already said could have issues.
As I said to Rolf, Intel 19 will not and cannot be installed on SLES 11. Period. Intel's installer will not work on SLES 11. The OS is too old. If you want to use Intel 19, you can only be on SLES 12. Period.
If you want a mixed Intel 18 on SLES 11/Intel 19 on SLES 12, I can do that, but I will accept no responsibility if a binary output is incorrect because of an issue you already know about with Intel 18. I will automatically close any ticket that might have to do with binary output as "Will not fix" if it involves Intel 18.

The other thing I could do is provide GCC 9 on SLES 11 if that is okay. But then the answers would be quite different I imagine on each system. But as far as I know, you have not found any binary-output issues with GCC in regards to GEOSldas/LDASsa.
But the users would need to know that they were running a different compiler (and MPI stack) when on the other system.

This does bring up a good point. I think I need to make a "validate g5_modules" script. As in every time I make one up, I should run the script on it and have it give "PASS/FAIL" output. So many numbers in those files, and typos are hard to spot.
I might ask you to be a tester of it once I get something working...

Unfortunately, you could only test it in the current environment, right?    It would be nice to somehow validate at NAS and locally on SLES 11 & 12 simultaneously.

@tclune Yeah. It's not perfect. But, I could maybe use ssh pfe validate.csh? There must be a way...

Of course, that means a script to call the validation script! :)

The issue with Intel 18 is on SLES12. For SLES 11, Intel 18 is fine. So I would like the g5_module with both Intel 18 ( sles 11) and Intel 19 (sles12) @mathomp4

@weiyuan-jiang Okay. Can you try out the version on the branch release/2.0.4+intel19.1. If you say it works on SLES 11 and SLES 12, I'll tag it with something like:
v2.0.4+intel19.1.0+intel18.0.5_sles11

or something...ugly.

@mathomp4 . Thanks. I will test it.

problem solved.


Regression in AbstractMapAssert#containsOnlyKeys with Spring's MultiValueMapAdapter

Summary
We saw this when updating from AssertJ 3.19.0 to 3.20.0. It appears that AbstractMapAssert#containsOnlyKeys is mutating the map that we're asserting on, which leads to test failures in our case. This is happening on an instance of org.springframework.util.MultiValueMapAdapter
Example
var underlyingMap = new HashMap<String, List<String>>();
underlyingMap.put("Hello", List.of("World"));

var multiValueMap = CollectionUtils.toMultiValueMap(underlyingMap);
// This assertion passes
assertThat(multiValueMap).containsOnlyKeys("Hello");
// This assertion fails, as `multiValueMap` and `underlyingMap` are now empty
assertThat(multiValueMap).containsOnlyKeys("Hello");

The issue seems to have been introduced in #2167, and is caused by this use of Map#remove on a "clone" of the Map being asserted on. In our case that Map is a Spring MultiValueMapAdapter, which delegates operations to the underlying Map that it was constructed from. The remove call on the clone delegates to multiValueMap#remove which in turn delegates to underlyingMap#remove.

With a quick look, the only option seems to be performing a check of the fully-qualified class name: if it's org.springframework.util.MultiValueMapAdapter, we don't try to clone the map but copy it directly.

Thanks for fixing this so quickly @scordio !
FWIW: I wondered if you might see similar issues in the future with other collection types, I think that approach of wrapping/adapting a collection is quite common (That said, I did try using some of the Apache and Guava collection types and wasn't able to reproduce this with those). I'm not sure what the motivation was for copying/cloning the original collection and then mutating that copy, but I wonder if just taking a set difference of the key set and the set of expected/unexpected keys might be a safer approach?

@ljrmorgan the problem started with case insensitive implementations (#2159) and we introduced quite extensive parameterized tests using all implementations we were aware of:
https://github.com/assertj/assertj-core/blob/a124477b203f1816c746c1fb400c60e5079f1209/src/test/java/org/assertj/core/internal/MapsBaseTest.java#L54-L78
It might be we will encounter some other implementations and additional special handling needs to be introduced.

I wonder if just taking a set difference of the key set and the set of expected/unexpected keys might be a safer approach?

AFAIR using the key set was not good enough with some case insensitive implementations because only containsKey has the case insensitive behavior and this is lost once you call keySet or entrySet.


Supplementaries Stick cannot be broken once placed.

Due to your mod, Supplementaries placeable stick cannot be broken once placed, which by default is a no tool break. I found a workaround by adding axes to their mod permissions, but mod compatibility would be nice for sticks and anything else that could be considered hand breakable and wouldn't cause damage.
To Reproduce
place a stick, try to break it.
Expected behavior
I expected to be able to remove it without harm. But I cannot remove it at all by hand or with any tool by default, as I had to go into the Supplementaries mod jar and add axe tool breaking.
Which other mods caused the bug .
This is an interaction with the Supplementaries mod.

The bug is caused because of the missing mineable/axe tag. The stick is made out of wood material, and this means that you need  a proper tool to break it, as every other wooden block in the game. So supplementaries should add the tag on their end and the bug will be fixed. Mojang intruduced a new tag system in 1.17+. Probably they forgot to add the tag to the block.


[rubysrc2cpg] add --useDeprecatedFrontend flag

Moves the current support into a deprecated sub-package
Disables the current support by placing it behind a disabled-by-default feature flag named --useDeprecatedFrontend

TODO:

I observed that in RubyCpgGenerator we were passing in the default Config. In this patch I'm merely checking if it contains the --useDeprecatedFrontend flag, but it seems that this would never be the case given how it's invoked. What would the appropriate thing to do here be? Create another SourceBasedFrontend for the deprecated ruby variant?

@DavidBakerEffendi Went that route. Named it rubyDeprecated so it should be as discoverable as when typing in ruby.

One thing we have to ensure here is that it is indeed possible to enable this flag. What would the code look like to do that?

One thing we have to ensure here is that it is indeed possible to enable this flag. What would the code look like to do that?

From Joern's prompt, we'd replace usages of ruby for rubyDeprecated, e.g. importCode.rubyDeprecated("...path...").

Using Ruby frontend scripts (rubysrc2cpg.sh, etc.), we need to pass in --useDeprecatedFrontend as an extra flag.

Using Joern as if it were a library, we need to set RubySrc2Cpg's configuration with an extra parameter (which is false, by default), like so: Config(..., ..., useDeprecatedFrontend = true)


ApiPopup Error Message is not visible due to color contrast

The error message in the API popup is not visible due to a color contrast problem.

It can be fixed by making the text color to white.

good catch. theres probably a couple edge cases where I missed the color refactoring. just fixed it, I'm going to put it in a release with a few more color refactors


Adding overpowering z-index for Split Action for when branch banner is active

This will fix the issue where the branch banner covers the split action CTAs. Need to test on live as the branch banner is something that only loads live (unless someone knows how to trigger it in dev environment, of course.)
Resolves: MWPW-137189
Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/feature/image/remove-background?lighthouse=on
After: https://mwpw-137189--express--adobecom.hlx.page/feature/image/remove-background?lighthouse=on

Codecov Report

Merging #315 (d26854f) into stage (b8996b9) will increase coverage by 0.12%.
The diff coverage is n/a.

:exclamation: Current head d26854f differs from pull request most recent head ec4ca20. Consider uploading reports for the commit ec4ca20 to get more accurate results

@@            Coverage Diff             @@
##            stage     #315      +/-   ##
==========================================
+ Coverage   50.82%   50.95%   +0.12%
==========================================
  Files          33       33
  Lines       10005    10005
==========================================
+ Hits         5085     5098      +13
+ Misses       4920     4907      -13

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Rewrite core README

📋 Description

This PR includes the complete rewrite of our repository's core README. It was done because of multiple grammar mistakes, inconsistencies, and not clear enough descriptions. The new version improves it a lot.

📦 PR Includes

[ ] Feature added 🆕
[ ] Bug fix 🐛
[ ] Code refactor 🔄
[X] Documentation update 📚
[ ] Tests added/updated 🧪
[ ] Other: (describe)

💡 Additional Notes
No additional notes

Great PR! I'm impressed by how smooth the text is, and the images look even better with transparency. A valuable addition to the repo!


Change napari's rotation convention so positive rotation angles cause an anti-clockwise rotation

🚀 Feature

We would like to change napari's rotation convention so that positive rotation angles cause an anti-clockwise (sometimes known as counter-clockwise) rotation.
Motivation
This convention is the most widely used in mathematics and also other python libraries like scikit-image. Having different conventions makes things unintuitive and very easily leads people to make mistakes.
Pitch
Nick suggests this change here https://github.com/napari/napari/pull/1616#issuecomment-700146465

A positive angle rotates an image in napari in the clockwise direction, whereas most mathematics (and apparently skimage) would have a positive angle rotate in a counter-clockwise direction by convention.
Unfortunately I think the reason we have that our convention is wrong is not because we construct the transform matrices wrong but because we "right apply" them instead of "left apply" them. See this line
return np.atleast_1d(np.squeeze(coords @ linear_matrix + translate))

and note that linear_matrix is on the "right" instead of the "left" of the coords. This was done because of the broadcasting rules of numpy make it simpler, and I thought it would be ok, with the necessary precautions, but it actually makes lots of things strange and counter-intuitive, leading to mistakes like this one. I think I should go back and fix that, and my guess is we won't need the extra - sign anymore.

This convention is now followed in the latest version of #1616 and will not change, so I will close. Thanks for making the issue!!


Floating Item Bug

Sometimes, when a pilot picks up a tech/cashbox/powerup, the item will still be there after pickup.
Original post by Cortex:
I often experience the following bug, but can't reproduce it reliably yet:
I pick up a floating tech or a cash box. I hear the 'picked up' sound and the tech is in my cargo. But I can still see it in space and on the map.
I asked a pilot from the other team (thanks Ly!) to come to me. He had a distance of about 50-100m from the object, but couldn't see it. I also tried to make him fly over it, but it seemed like he couldn't pick it up. I can't pick it up a second time either.
I'm 50% sure that it doesn't disappear from leaving the sector and re-entering it.
This happens in about 1-5% of my tech/cash pickups.
------- Additional Comment #1 From Henrik Heimbuerger 2006-03-19 21:05 -------
Addendum: I'm pretty sure I had one of these unpickable techs today after it was picked up by an opponent. I.e. he picked it up, I still saw it but couldn't grab it anymore (fly over it three times).
The server was generally very laggy, that might be related.
Imported from trac ticket #23,  created by SilentRogue on 01-05-2010 at 10:53, last modified: 01-08-2010 at 20:31

test
Trac comment by Imago on 01-08-2010 at 20:29

again
Trac comment by Imago on 01-08-2010 at 20:31


Duration formatting rounds up to 1 ms

Average request time seems unaffected, but minimum request time, (probably) maximum request time, and all response time metrics appear to round up to 1 ms.

Correct, Goose is tracking requests in milliseconds:
https://github.com/tag1consulting/goose/blob/main/src/metrics.rs#L359
https://docs.rs/goose/latest/goose/metrics/struct.GooseRequestMetric.html#structfield.response_time

Would you consider using a smaller unit? I think microseconds would still allow Goose to track requests for any reasonable amount of time.

I'd welcome a PR to make goose more granular! We'd need to do some testing to confirm it doesn't cause any regressions in functionality or performance, and update all the documentation. But it seems an excellent step forward.

Did you consider using HdrHistogram? Looks like it should improve both the accuracy and performance, and take care of the coordinated omission code as well.


Add extend T::Generic to every fake Opus::Enum class

Motivation

This will help us upgrade Opus::Enum in pay-server incrementally, so that we
don't have to upgrade Sorbet and pay-server in lock step.
Test plan

See included automated tests.

Actually I can codemod pay-server without this PR.


iOS Haptics randomly crashing on some devices

Issue details
We recently enabled iOS Haptics vibration in our game. We started seeing an increased number of crashes because of it.
Please see the details below and let me know if you need more information.
Reproduction steps/code
Although I cannot reproduce this, we are seeing the crashes in our reports (see stack trace below). Players reported that the game app will crash randomly. We vibrate the devices using Gdx.input.vibrate(30).

Version of libGDX and/or relevant dependencies
We are using libGDX 1.12.0 and RoboVM 2.3.19.
Stacktrace
It looks the crash comes from the internals of ptr.get()at IOSHaptics.java:86.
0   libsystem_kernel.dylib        	0x00000001c85213c4 __abort_with_payload + 8
1   libsystem_kernel.dylib        	0x00000001c8543c04 abort_with_payload_wrapper_internal + 104 (terminate_with_reason.c:102)
2   libsystem_kernel.dylib        	0x00000001c8543b9c abort_with_reason + 32 (terminate_with_reason.c:116)
3   libobjc.A.dylib               	0x0000000182617b74 _objc_fatalv(unsigned long long, unsigned long long, char const*, char*) + 116 (objc-errors.mm:216)
4   libobjc.A.dylib               	0x0000000182617b00 _objc_fatal(char const*, ...) + 32 (objc-errors.mm:232)
5   libobjc.A.dylib               	0x00000001825ec730 lookUpImpOrForward + 860 (objc-runtime-new.mm:6907)
6   libobjc.A.dylib               	0x00000001825e6cc4 _objc_msgSend_uncached + 68
7   IOSLauncher                   	0x0000000105f70b28 [J]org.robovm.objc.ObjCRuntime.ptr_objc_msgSend(JJ)J + 128
8   IOSLauncher                   	0x0000000105f6c818 [j]org.robovm.objc.ObjCRuntime.ptr_objc_msgSend(JJ)J[clinit] + 76
9   IOSLauncher                   	0x0000000105911550 [J]org.robovm.apple.foundation.NSError.domain(J)Ljava/lang/String; + 72 (NSError.java:113)
10  IOSLauncher                   	0x0000000105911390 [j]org.robovm.apple.foundation.NSError.domain(J)Ljava/lang/String;[clinit] + 64
11  IOSLauncher                   	0x0000000105914970 [J]org.robovm.apple.foundation.NSError$Marshaler.toObject(Ljava/lang/Class;JJ)Lorg/robovm/apple/foundation/NSError; + 72 (NSError$Marshaler.java:57)
12  IOSLauncher                   	0x0000000106018750 _call0 + 84
13  IOSLauncher                   	0x000000010600eb6c callObjectMethod + 116
14  IOSLauncher                   	0x00000001060111bc rvmCallObjectClassMethodA + 272
15  IOSLauncher                   	0x0000000104263f1c Java_java_lang_reflect_Method_internalInvoke + 732
16  IOSLauncher                   	0x0000000104a0d6f4 [J]java.lang.reflect.Method.internalInvoke(J[Ljava/lang/Class;Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object; + 124
17  IOSLauncher                   	0x0000000104a0d2e8 [J]java.lang.reflect.Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object; + 336 (Method.java:591)
18  IOSLauncher                   	0x0000000105fbe9ac [J]org.robovm.rt.bro.MarshalerLookup.toObject(Ljava/lang/Class;J)Lorg/robovm/rt/bro/NativeObject; + 312 (MarshalerLookup.java:45)
19  IOSLauncher                   	0x0000000105fbe848 [j]org.robovm.rt.bro.MarshalerLookup.toObject(Ljava/lang/Class;J)Lorg/robovm/rt/bro/NativeObject;[clinit] + 76
20  IOSLauncher                   	0x0000000105fcd664 [J]org.robovm.rt.bro.ptr.Ptr.toObject(J)Lorg/robovm/rt/bro/NativeObject; + 236 (Ptr.java:112)
21  IOSLauncher                   	0x0000000105fcd318 [J]org.robovm.rt.bro.ptr.Ptr.get()Lorg/robovm/rt/bro/NativeObject; + 80 (Ptr.java:58)
22  IOSLauncher                   	0x0000000104632a98 [J]com.badlogic.gdx.backends.iosrobovm.IOSHaptics.vibrate(IZ)V + 480 (IOSHaptics.java:86)
23  IOSLauncher                   	0x000000010460cbc0 [J]com.badlogic.gdx.backends.iosrobovm.DefaultIOSInput.vibrate(I)V + 32 (DefaultIOSInput.java:552)
24  IOSLauncher                   	0x000000010569e784 [J]mmorpg.utils.Vibrator.doVibrate()V + 140 (Vibrator.java:35)
...

Please select the affected platforms

[ ] Android
[x] iOS
[ ] HTML/GWT
[ ] Windows
[ ] Linux
[ ] macOS

I've just checked the Core Haptics binding on RoboVM (https://github.com/MobiVM/robovm/blob/master/compiler/cocoatouch/src/main/java/org/robovm/apple/corehaptic/CHHapticEngine.java) and there's something that doesn't look quite right:
public CHHapticPatternPlayer createPlayer(CHHapticPattern pattern) throws NSErrorException {
       NSError.NSErrorPtr ptr = new NSError.NSErrorPtr();
       CHHapticPatternPlayer result = createPlayer(pattern, ptr);
       if (ptr.get() != null) { throw new NSErrorException(ptr.get()); }
       return result;
    }

If I understand correctly, the player could fail to be created but should fail silently. I'll ask Dkmitsa on MobiVM Gitter and follow up here.

Has this occurred on all devices regardless of whether they have a vibration motor or not? E.g. iPad and iPod don't. At one point I played Falling Lightblocks on my iPod without issue, but not for very long and that doesn't really prove anything.

We call Gdx.input.vibrate only if Gdx.input.isPeripheralAvailable(Peripheral.HapticFeedback) returns true.
The report shows it is happening in iPhones only, but I can't say for sure it wouldn't happen on other device types:

Have you been able to reproduce this on a device you have? It would be good to see a log as there should be some additional info to get

Unfortunately, the iPhone I use for testing doesn't have haptics support. I will try to find a friend to lend me their phone to try to reproduce this. What kind of information are you looking for in the logs?

Should just see some logs as to why this specific case failed.

Sure! Here it is:
crash.txt
Update on trying to reproduce: I will have a friend bring their phone this weekend so I can try to reproduce the crash.

Managed to reproduce it with a crazy sample that isn't very realistic. But looking into it. Can you give a quick exampple of how you are using it? What scenarios are you using haptics with? How often can a user trigger them? are you calling the vibrate always from the main libgdx thread, I noticed you have some threading and networking going on, so if you respond to any async requests with haptics are you using post runnables?

Hi Tom.
We use vibration as a feedback to players that they pressed one of the key game controls:

1- the game vibrates when you press the touchpad directions
2- it vibrates when you press the attack button
3- it also vibrates when you use hotkeys (cast a spell, use an item)
They are triggered pretty often.
Vibrate is always called from the main libGDX thread through scene2d actor listeners (in the crash log provided, a ChangeListener; we also use ClickListener).
Let me know if you need more information.

Thanks @lucas-kakele. Narrowed it down a bit, will continue looking this weekend probably

@obigu hi, this should fix it
https://github.com/MobiVM/robovm/pull/743

@obigu hi, this should fix it MobiVM/robovm#743

Thanks @dkimitsa.
@lucas-kakele When next MobiVM version is released, it'd be great if you could report back if the fix works in your game.

@obigu @lucas-kakele
its available in 2.3.20-SNAPSHOT already

Thanks for working on the fix folks!
Our game next release cycle will be in December. We will let you know the results.
Regards.

Fixed in https://github.com/libgdx/libgdx/pull/7249


Support polyphonic sequences

I guess this would be a lot of work but supporting polyphonic sequences would actually be huge.
Supporting polyphonic sequences in live record mode would be good to start with. For the actually sequencer it might be a little bit challenging for the users. But devices like Ableton Push support polyphonic sequencing as well and people tend to generally like it.

This has been something I've thought about a lot. My current plan for a simple, low-overhead solution is to alter the live recording code to scan for any sequence that is configured to send on the same channel as the current active sequence, and record one voice from the Voices array into each one. This would keep all the rest of the program logic the same, and you can technically do something similar already if you record one part at a time.
The difficulty with supporting it another way is just ram. There are currently two note banks (the live one and one for storage) so there would be at least enough room for duophonic sequences, but when I first implemented the storage bank, the program crashed almost immediately after running it and I had to make a major memory optimization pass through the code just to fit it in, so I don't think there's room for three or more notes per step.

Hm, okay I really did not think about the RAM issue. I think there are mainly two use cases for a polyphonic sequencer:
Sequencing Drums
Many drum machines use notes instead of channels per step, so here with the current implementation you would need multiple tracks for multiple drums
Chords
This could be as easy as generate a Maj/Min/7 chord based on the current root note in the sequencer step.
Thinking about these use cases in terms of memory is interesting. The chord mode could actually be implemented without consuming much ram. And then for the drum machine mode one thing became clear to me: actually not many people would need the ability to zoom into a finer grid for drums. Meaning, maybe you could save some ram by having a true 8 step sequencer without the ability for a finer grid. To be honest I don't think many people actually expect this zoom functionality at all in a 8x8 grid sequencer. I personally would prefer a true 8 step sequencer based on 16th notes. By using pages this could then make the sequencer 8, 16, 24, 32... in step lengths. This would be similar to the way Elektron does it's sequencer.

There are a lot of ideas for this. I think there are probably multiple things that are worth doing and the problem will be deciding which ones can be implemented in an intuitive way that works well with the rest of the program.
The first thing is the currently available option of setting multiple tracks to the same channel and creating polyphonic sequences by entering one part at a time. This is nice because it doesn't need any special implementation or new interface elements to be learned. It also fits with one of my assumptions about how people would use Subsequencely, which is that you wouldn't necessarily want to actually use all 8 sequences at once, but instead you'd do things like link together multiple sequences to make longer ones, put the kick drum in a separate sequence from the rest of the drums so you could mute it as necessary, etc.
It makes it easy to reason about the behavior of the program, and makes it flexible to use. The thing that could be improved would be nicer workflows for the polyphonic use case, which would include the live recording feature I mentioned in my previous comment, and the ability for multiple tracks' notes to be displayed  in sequencer mode so that you wouldn't have to constantly switch between tracks.
The automatic chords is a good idea that wouldn't be too hard to implement at a basic level, although it could create some tricky edge cases. Would this be a per-sequence toggle where all notes would be played as chords, or a performance modifier that would be stored per-note?
For drums, I think you can do more or less what you're describing by turning off pattern steps in session mode with quantise+pad (leaving only 2 pads on if you want 8 steps), then go into sequencer mode and zoom in all the way, at which point you will see 8 16th notes, which is the entire pattern. Of course, this isn't a very quick workflow, and it leaves most of the rest of the sequence unused.
One idea is to have the unused steps be overlaid on the enabled ones to create more polyphony. So if you only needed 8 steps, you could fit four parts in one 32 step sequence.


Add mapstructure support to syslog_input operator configuration

Dependent on #13.
This will allow explicit embedding in the collector's syslogreceiver. (See #2231)

Should not affect functionality of configuration
Ideally would not remove support for yaml unmarshaling
This change should perhaps be preceded by enhanced test cases on the syslog_input configuration

I'm filebeat Syslog input contribute. If no one is currently working on this issue, I can do it :)

Do you mind using ragel to parse syslog
which syslog format support, RFC3164? RFC5424? or both


Implementation of the mutex algorithm - Ricart-Agrawala

There are a lot of changes, so please take your time and review them. I only did some simple bench tests, we still need thorough tests, preferably automated if possible. Hence I'm proposing for this to be merged first so that we're on the same page.

Code reviewed, nothing to add


Refactor BuilderInvocationHandler to a separate class

https://github.com/Singleton06/dynamic-builder/blob/master/src/main/java/com/singleton/dynamic/builder/DynamicBuilderFactory.java#L25


Data availability

Hi Could yo share any of the 5 data that is listed for running the code.
Thanks in advance.

Hello!
Thank you for noticing, it was a problem with provided links in README. We have fixed it, now all the data is availible.
Please do not hesitate to contact us if any problems with our code occurs

Hi Could yo share any of the 5 data that is listed for running the code. Thanks in advance.

Thanks, the link works now.
I will get back in case of queries.
Have a nice day!

Thanks, the link works now.
I will get back in case of queries.
Have a nice day!


sapmachine: init at 13.0.1

Motivation for this change
Homepage: https://sapmachine.io
This project contains a downstream version of the OpenJDK project. It is used to build and maintain a SAP supported version of OpenJDK for SAP customers and partners who wish to use OpenJDK to run their applications.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers

I was able to build this successfully build sapmachine on NixOS, but when I tried to run javac I noticed it has an interpreter set to /lib64/ld-linux-x86-64.so.2 so something needs to be fixed with the interpreter:
$ file ./result/bin/javac
./result/bin/javac: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.4, not stripped

Closing due to inactivity. Please reopen the discussion if this is still important to you.

Closing due to inactivity. Please reopen the discussion if this is still important to you.


[Update Request]: SoftwareOK.Q-Dir Yaml metadata contains duplicate key 'ReleaseNotes:'

What type of update are you requesting?
A change to the package metadata
Current Package Identifier
SoftwareOK.Q-Dir
Package Version
11.84
Please describe the changes you would like to see
manifests/s/SoftwareOK/Q-Dir/11.84/SoftwareOK.Q-Dir.yaml
The file contains the key ReleaseNotes: twice, which is invalid.
Is
ReleaseNotes: Blurred display at higher DPI value with some Windows configurations
ReleaseNotes: https://www.softwareok.de/?seite=Freeware/Q-Dir/History

Should be
ReleaseNotes: |-
  Blurred display at higher DPI value with some Windows configurations
  https://www.softwareok.de/?seite=Freeware/Q-Dir/History

—or— (more likely)
ReleaseNotes: Blurred display at higher DPI value with some Windows configurations
ReleaseNotesUrl: https://www.softwareok.de/?seite=Freeware/Q-Dir/History

See https://github.com/microsoft/winget-pkgs/pull/185369


Update strings.xml

Translated a newly added string and fixed some string positions

@RocketChat/android

Changes: [Add here what changes were made in this issue and if possible provide links.]
The translation aims to also fix the position/sentence building syntaxes.
Let me know if anything is missing
Screenshots or GIF for the change:

From what I could see it has been translated to European Portuguese from you - Am I right? If so we should definitely add a European Portuguese file to the app, because there are many differences to both language (pt_BR x pt_PT). Could you add that file?
Thank you 🇧🇷 🇵🇹


Dart 2 Incompatible issue with orderable_stack 0.1.3

pubspec.yaml
name: orderable_stack_example
description: An orderable container widget example
dependencies:
flutter:
sdk: flutter
orderable_stack: ^0.1.3
flutter:
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:
- assets/girafe1.png
- assets/girafe2.png
- assets/girafe3.png
environment:
sdk: ">=2.0.0-dev.68.0 <3.0.0"
error
/Users/Documents/Flutter/flutter/bin/flutter --no-color packages get
Running "flutter packages get" in orderable_stack_example...
The current Dart SDK version is 2.1.0-dev.9.4.flutter-f9ebf21297.
Because orderable_stack_example depends on orderable_stack >=0.1.0+1 which requires SDK version >=1.20.1 <2.0.0, version solving failed.
pub get failed (1)
Process finished with exit code 1

I am trying to add orderable stack lib into my flutter application but it is giving an error of the version.

I would recommend you to file a issue under: https://github.com/rxlabz/orderable_stack
According to: https://pub.dartlang.org/packages/orderable_stack
orderable_stack 0.1.3(latest version) is not compatible with Dart2(The dart sdk used in your flutter environment).
@Laxman007


error when client.run()

Summary
even when there is no code only client.run() and client = selfcord.Client() there is an error
Reproduction Steps
i just tried to make a selfbot with the most basic code possible
Code
import selfcord
client = selfcord.Client()
client.run(token here)

Expected Results
bot should run without any problems
Actual Results
TypeError: fromisoformat: argument must be str
System Information

Python v3.11.0-final
discord.py v2.2.2-final
aiohttp v3.8.3
system info: Windows 10 10.0.19045

Checklist

[X] I have searched the open issues for duplicates.
[X] I have shared the entire traceback.
[X] I am using a user token (and it isn't visible in the code).

Additional Information
No response

i temporarily solved it by commenting out line 110 in site-packages\selfcord\read_state.py it probably breaks smth but its fine for now

Happens to me as well.

Sorry, should be fixed now!


Speedup filter maximum

Coverage decreased (-0.01%) to 87.209% when pulling 537d82ab10020bd9f4a99cb8561c7ac747e9e252 on speedup-filter-maximum into 61c8869d1a8834c1664ada4f09602f265067fd77 on master.

Coverage decreased (-0.01%) to 87.209% when pulling 570b329c5f1219359b50d01cdd3589e7f2b85302 on speedup-filter-maximum into 61c8869d1a8834c1664ada4f09602f265067fd77 on master.

Coverage increased (+0.02%) to 87.242% when pulling 1ce138fec8cb4fbcac5cdc0f54674f487f010078 on speedup-filter-maximum into 61c8869d1a8834c1664ada4f09602f265067fd77 on master.