Issue with not_in operation for Gate: dockerfile and Trigger Instruction

Is this a request for help?: Yes
Is this a BUG REPORT or a FEATURE REQUEST? (choose one): BUG REPORT

Version of Anchore Engine and Anchore CLI if applicable:
anchore-cli --version  version 0.3.0
docker exec <engine_container> pip show anchore-engine v0.3.0
What happened:
This part of the policy should fail the scan if the docker image doesn't have a base image in scratch or gcr.io/distroless/base:latest. But the docker images with base image as ubuntu and alpine passed the scan.
{
                    "action": "STOP",
                    "gate": "dockerfile",
                    "id": "rule_1FtTBBCcvRdKLCCIllxvrYG2sf8",
                    "params": [
                        {
                            "name": "instruction",
                            "value": "FROM"
                        },
                        {
                            "name": "check",
                            "value": "not_in"
                        },
                        {
                            "name": "value",
                            "value": "scratch,gcr.io/distroless/base:latest"
                        }
                    ],
                    "trigger": "instruction"
                }

What did you expect to happen:
Fail any docker image scan not FROM scratch or gcr.io/distroless/base:latest

Any relevant log output from /var/log/anchore:
What docker images are you using:
alpine, ubuntu
How to reproduce the issue:

Created a policy with

{
                    "action": "STOP",
                    "gate": "dockerfile",
                    "id": "rule_1FtTBBCcvRdKLCCIllxvrYG2sf8",
                    "params": [
                        {
                            "name": "instruction",
                            "value": "FROM"
                        },
                        {
                            "name": "check",
                            "value": "not_in"
                        },
                        {
                            "name": "value",
                            "value": "scratch,gcr.io/distroless/base:latest"
                        }
                    ],
                    "trigger": "instruction"
                }

Scan an image with base image not in "scratch,gcr.io/distroless/base:latest"

Scan passes instead of failing.

Anything else we need to know:
I was following the not_in as the lambda function splits the comma separated string into a list.
https://github.com/anchore/anchore-engine/blob/f1b69b820384ec62336e094c62c3ac37a373e7db/anchore_engine/services/policy_engine/engine/policy/gates/dockerfile.py#L134

hi @munai-das - I wanted to follow up on this topic to ask if the issue can be closed, or if there are further discussion points to dive into on this topic - let us  know!

We can close this


feat: Add Save button to annotations panel

Closes #1427
This PR adds a "Save" button to the annotations panel. As we save the changes dynamically anyway, it acts as a "close panel" button.

@KerstinFaye I see that in the current design file we also have a Cancel button, contrary to what's inside the #1427 issue 😱
As we have a "live mode editing" across the whole application, where changes are visible on a chart as soon as we make them (except for some data loading related actions, like updating multi-filters where we need to confirm the selection to avoid constant data changes and loading), I wonder if we should change this paradigm for annotations – because if I understand correctly, in the current design, user should be able to update title and description without immediate feedback on a chart, but only applied after clicking "Save", and discarded when clicking "Cancel")?
This is a personal preference, but I find it more user-friendly to have this live feedback as we do currently, just wanted to check with you if we should change this (and if so, should we also apply it in other parts of the application)? If you think it's a good idea to change this, maybe then we could also have a small tag above, like "Pending changes", so we know if we actually made a change? I think it might be a bit confusing now, as we can save the changes immediately after entering the panel, without actually updating the title or description yet 👀
Let me know what you think about this :)

Code looks good but I am wondering about the behavior here. Here I wonder, there was no modification to how changing a field changes the chart, so Bartosz if I am not mistaken, here in this PR, even if the user does not click "Save", it will have been saved already right ?
I completely agree with Bartosz, the addition of a Save button feels like a change of paradigm. What is exactly the intention there ?

@ptbrowne yes, it's a "fake" Save button now, as I didn't want to completely change the behavior before discussing this 👍

@bprusinowski Thanks a lot for the feedback. I agree, it's definitely better to have the live feedback. I reviewed the implemented version and I think the solution to have the save button but still the live feedback is best.

@ptbrowne I think this ideas is even based on your feedback that you gave ones in a document that you did for UI improvements. I thought it was a good idea to give the user the opportunity to confirm their action to approve the title input. But if you are all agreeing that it's a change of paradigm then we can also leave it like we had.

Thanks for the review @KerstinFaye! From my side it would be fine to leave the current implementation from this PR, let me know what you think @ptbrowne 👍

I think this ideas is even based on your feedback that you gave ones in a document that you did for UI

Maybe, I have tried to think more about it, and I think my feedback was  to answer to the need of the user "after inputting a title, what do I do now ". I think we want to

respect the current paradigm of auto saving (1)
have an action at the bottom so that the user knows what to do, and does not look around until seeing the close button (2)

I think this PR solution with the "save" button solves (2) but could be confusing to the user, and somehow does not respect (1). So maybe a good solution would be to have the text of the button only "OK".

I think this PR solution with the "save" button solves (2) but could be confusing to the user, and somehow does not respect (1). So maybe a good solution would be to have the text of the button only "OK".

That works. Let's use "ok".

Thanks 👍


[WIP][CHAT-3121]Create an SCA Github Action for our public packages

We decided offline not to implement this functionality.


Follow does not work correctly

When you issue a unit to follow your hero. The unit will just walk to you hero then stop following it. Example: Use helm of the dominator to gain control of a jungle creep. Now try to have the jungle creep follow you.

That's usually because of right click deny activated.
You need to use the Space+A I think, for the follow command. Normal right click doesn't work.

yes that is correct


configure source_daimon table data to trigger a cache warming job when WebAPI starts

update the source_daimon table data so that a cache warming job will run when the Atlas WebAPI starts

Fixed by commit d4fee32.


Add prometheus push on valid run

Add ability to push successful run information to Prometheus PushGateway, so that a freshness alert can be added (which will then set off alarms/pagerduty calls, etc).
https://trello.com/c/d0yJFWgK/2146-update-email-alert-monitoring-so-that-it-can-be-tested-on-integration-and-push-alerts-to-prometheus

Obsolete change.


support at lock query

What would you like to be added:
Implement this function

Why is this needed:

我可以试试


[CLEANUP] Move away from setup.py + requirements.txt to pyproject.tom…

…l #60
What does this PR do?
Fixes #60
Before submitting

[x] This PR changes the dependency installation steps making it easier.
[x] Was this discussed/approved via a Github issue? Please add a link to it if that's the case. https://github.com/Storia-AI/sage/issues/60
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

Changes:

Moved project metadata, dependencies, and entry points from setup.py and requirements.txt to pyproject.toml.
Removed setup.py and requirements.txt.

How to install dependencies:

Using pip:pip install .

Who can review?
@iuliaturc Please review the PR and let me know if further changes are needed.

Great work, thanks @Shashwat3012!


normal search do not respect agignore but -g option do.

Hi,
Have found that the usual search like,
ag pattern dir
searches all including files/dirs in agignore. However, ag -g option with the same condition respects agignore file.
Also found that
ag --ignore pattern pattern dir
did ignore as expected. So some options see agignore file and some don't? Please advise.
Many thanks

Feel free to correct me if any of this information is false.

The -g flag just limits the search to file names. What is the contents of your .agignore? It seems to have the behavior I expect when trying to replicate.

Where is your .agignore file located at? When running:

ag pattern dir
It looks like it is searching for an .agignore file in the user's directory and one in the defined directory within the command. Are you expecting it to search within the current directory you are in? Is this the expected behavior @ggreer ? Maybe it should also look within the current operating directory.

When using the --ignore flag, you are explicitly telling it where your file is. Without, it will look for the ones mentioned above.

@mattscamp thanks for clarification. I was expecting it to read .agignore from the current directory. I will try ~/.agignore and go from there


Hi! It looks like you may have committed more files than you meant to. Would you like to try adding another commit that removes the files, or open a new PR that changes only the Readme? I see 6 files changed. Thanks for participating! Let me know if you have any questions about how to make these changes.


KUZ-664: rejects connections if no kuzzle instance is available

:warning:
Must be merged after https://github.com/kuzzleio/kuzzle-plugin-websocket/pull/4
:warning:

Reject HTTP requests with a 503 HTTP error code if no Kuzzle instance is registered
Reject protocol plugins requests with a 503 HTTP error code if no Kuzzle instance is registered
Remove requests caching from the broker as it is now useless, since requests are rejected
Reject protocol plugins new connections with a 503 HTTP error code if no Kuzzle instance is registered
Add/update unit tests

Unrelated changes

the broker now responds with a BadRequestError if a request is badly formatted, instead of a plain Error instance
rename the obsolete .eslintrc to .eslintrc.json
remove grunt
remove jshint
eslint is now applied to the unit tests directory
fix eslint errors in unit tests

To be discussed
If a client opens a connection to the proxy, and then the last Kuzzle instance is dropped, the client keeps his connection. The only effect is that all subsequent requests are rejected.
It may be better to force a connection close with the appropriate error code when the last Kuzzle instance dies. But to do that, we need to update the protocol plugins specifications to add a disconnect(connectionId) method, allowing the proxy to ask plugins to close client connections.
This may be a good idea to add such a method anyway, as we may have other uses for this method in the future. For instance, to force a connection close to clients with harmful behavior.

Current coverage is 100% (diff: 100%)

Merging #19 into develop will not change coverage

@@           develop   #19   diff @@
====================================
  Files           10    10
  Lines          333   329     -4
  Methods          0     0
  Messages         0     0
  Branches         0     0
====================================
- Hits           333   329     -4
  Misses           0     0
  Partials         0     0

Powered by Codecov. Last update 7cd5b68...91707a3

+1
and also +1 for your proposal to add a disconnect method.


Making light table play nicely with clojure.test

Hi
I'm trying to write code using light table and use tests but I'm only getting a terse summary report from (run-tests).  Looks like I'm not getting the stdout reporting, only the result of calling (run-tests).
I can fix this by rebinding test-out to out.
(binding [*test-out* *out*]
  (run-tests))

Is is possible that *out* is bound to something odd when clojure.test loads?
cheers, Oliver
PS. Just an idle related thought.  I'd like to have a set of tests run (instarepl style) as I'm coding in Table mode.  If a test fails I want to see what values where passing through functions (instarepl style).

For anyone trying this with the new flat format, the (:eval.custom "code" {:result-type :statusbar}) should not be in an array. The above key binding entry would therefore look like this:
 [:editor.clj "pmeta-r" (:eval-custom
                         "(clojure.test/run-all-tests
                            (re-pattern
                              (str \"^\" *ns* \".*\")))"
                         {:result-type :statusbar})]


Session 07: WIP and backlog of other items

Apparently I've been forgetting to PR my work week to week. :/

Whoa! yup, that's a lot :-)
-- I wont' review any of the old stuff -- but let me know if you have any questions about any of it.

I'm going to merge so we can see what's new at the next PR.


Update to account for DDP changes (transition to Map/Set) in Meteor 1.8.1.

This fixes the package in Meteor 1.8.1 by accounting for the places where ddp-server is now using Map/Set instead of objects.

@mitar I've updated the PR with backwards-compatibility.

Thanks.

Released as<EMAIL_ADDRESS>Please test.


A05: Front end integration of backend components

Linked to https://github.com/bitcoin-sv/bsv-ai-agent/issues/4 and https://github.com/bitcoin-sv/bsv-ai-agent/issues/5
Description:
Front end integration of the backend components for the users to interact with the platform (UX/UI development)

Create an interface for users to input prompts and confirm transactions.
Show transaction details before execution.
show tx history record on the blockchain after it has been executed

Deliverables:

[ ] A front-end input box for user prompts.
[ ] Backend logic to convert prompts into BSV transactions.
[ ] Transaction confirmation and ID display to the user.

Acceptance Criteria:

Users can send BSV using natural language commands.
Transaction details (amount, recipient, etc.) are accurately parsed and executed.
Success and failure messages are displayed appropriately

I would like to work on this! I have a good experience of building onchain AI agents and this goes hand in hand with that


[BUG] Img embedding not working

Description:
Img does not work. I have a test.jpg in the root folder of my project.
Passing this path to an Img object does not display the image. I'm getting the 'image-not-found' icon.
This is how the images are displayed in the Img Generator tutorial.
Here is the python code:
def home():
    return Main(Img(src="test.jpg"))

I get a 404 Not found error in the logs. (ignore the strange formatting, dunno why that is)
INFO:     <IP_ADDRESS>:56914 - GET /test.jpg HTTP/1.1 404 Not Found
The html in the inspector is the following:
<img src="test.jpg">
It seems to be correct, but the image is clearly not being fetched.
I've tried variations such as /test.jpg or ...localhost:5002/test.jpg but nothing works.
I've tried clearing the browser cache, no changes there either.
Expected behavior
An image should appear.
Environment Information
Please provide the following version information:

fastlite version: 0.0.10
fastcore version: 1.7.2
fasthtml version: 0.5.0

Try it with a leading slash /:
def home():
    return Main(Img(src="/test.jpg"))

Let me know if that resolves your issue. If not, I'll reopen the ticket.

Try it with a leading slash /:
def home():
    return Main(Img(src="/test.jpg"))

Let me know if that resolves your issue. If not, I'll reopen the ticket.

Hi, thanks for the quick reply.
As I mentioned, I've tried all the variations of the path, including "/test.jpg" and even the absolute path.
Neither worked.
@pydanny

Do you have a repo or a minimal code example I can try?

@pydanny
https://github.com/Incblob/fastHTML_minimal_bug
Here is a minimal repo, Or you can just use the code directly.

You need a static route to serve files (like the image file) - either use fast_app (which adds this automatically) or add a route like:
@rt("/{fname:path}.{ext:static}")
def get(fname:str, ext:str): return FileResponse(f'{fname}.{ext}')

@pydanny thank you for your help
@johnowhitaker Thanks, that works.
However @rt is used with the fast_app, which wouldn't need the explicit route declaration.
Here's the variant for FastHTML for anyone looking:
@app.get("/{fname:path}.{ext:static}")
def get(fname: str, ext: str):
    return FileResponse(f"{fname}.{ext}")

This is not documented, should I open an issue for the documentation, or is that unnecessary?


Enhancement for set defaults

What does this PR do?

Updates the setting of user defaults by including locations field in the request body.

How to test?

cd AirQo-api/src/auth-service
npm install

for MAC

npm run dev-mac
npm run stage-mac
npm run prod-mac

for Windows

npm run dev-pc
npm run stage-pc
npm run prod-pc

Alternatively,

You can run using Docker.

Endpoints to test out?

BASE URL: /api/v1/users

[PUT] [SET DEFAULTS] with partial url as: /defaults?user={USER ID}&chartTitle={TITLE}
The query parameters are both mandatory in your request

{
  "locations": [
    "Bwaise",
    "Kamwokya",
    "Bukoto"
  ],
  "pollutant": "N02",
  "Frequency": "daily",
  "chartType": "bar",
  "range": "last 30 days"
}

[GET] [GET DEFAULTS] with partial url as: /defaults?user={USER ID}&chartTitle={TITLE}
You can either use one or both query parameters here.

More Details: api documentation

Any other considerations? Under what environment?

Used node version v12.18.1

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

Have you run npm install ?

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

Have you run npm install ?

Yes

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

Have you run npm install ?

Yes

This error is now resolved. I had something to do with the NODE version. I had to delete and rebuild the node_modules folder.  Thanks

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

Have you run npm install ?

Yes

This error is now resolved. I had something to do with the NODE version. I had to delete and rebuild the node_modules folder. Thanks

Awesome....

I'm getting the error below when I try to run npm run prod-mac, npm run dev-mac or npm run stage-mac. I might be doing some wrong.

Have you run npm install ?

Yes

This error is now resolved. I had something to do with the NODE version. I had to delete and rebuild the node_modules folder. Thanks

Please remember to approve/reject when DONE with the review. :)


lots of resolver errors in build logs (maven.twttr.com)

lukas [2:47 PM]
seth, it's a detail, but do you know why this line keeps appearing in the community build log?
[...] [error] SERVER ERROR: Service Temporarily Unavailable url=https://maven.twttr.com/<some>/<maven>/<artifact>/<path>
sethtisue [2:49 PM]
it started when I added a resolver needed by twitter-util
I’ve asked Toni if it’s possible to add a resolver just to a single project, Toni says no
lukas [2:49 PM]
is there an order in the resolvers list? then it could just come last?
sethtisue [2:50 PM]
it is already last or very close. it’s mysterious to me
this falls under the general heading of https://github.com/scala/community-builds/issues/152
it could be that we need to mirror more of the resolvers in the Artifactory config on scala-ci, but the idea of having to mess with that depresses me

Following up on chat on https://gitter.im/typelevel/general?at=57136f222c9711166432a27e
I'm seeing constant local build time of around 2h 30 min, mainly achieved by using artifactory with virtual  repositories, as per https://github.com/scala/community-builds/issues/152#issuecomment-151970075
The setup is really rather easy:
Just add the extra repositories listed in common.conf to artifactory as Maven/Ivy/sbt remote repositories (Make sure "Suppress POM Consistency Checks" is ticked). At this point, you have just proxied some extra repos.
Then create three virtual repositories, such as (CB-Ivy, CB-Maven, CB-Sbt) and add the current repositories listed in common.conf to the appropriate Virtual repo, in the same order. The idea here is that all the drop down through the repos is "pre-calculated"
Your repositories in common.conf is then something like:
 local
  cb-ivy:   YOUR-URL/artifactory/CB-Ivy, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]
  cb-maven: YOUR-URL/artifactory/CB-Maven
  cb-sbt:   YOUR-URL/artifactory/CB-Sbt, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]

If needed, you could always create the Virtual repos per config - eg "CB-Ivy_2.12.x" and so on.
I already had Artifactory setup, but not used by default and it did help adding it to dbuild, but the dbuilds were still really slow. ( as in Ctrl-C slow...).
Adding the Virtual repos was the cure :)

Should be resolved by #243 and #244 (via https://github.com/scala/scala-jenkins-infra/pull/171)

Note that this moves all the resolver config into artifactory, whose config isn't under source control...

ugh, well, it looks like now the slowness turned into resolver issues

Looking into this, it seems the maven.twttr.com repo is returning jars using the text/html mimetype? E.g., https://maven.twttr.com/com/twitter/common/objectsize/0.0.10/objectsize-0.0.10.jar is showing up as text in my browser, and artifactory refuses to cache it. (https://scala-ci.typesafe.com/artifactory/twitter-maven/com/twitter/common/objectsize/0.0.10/objectsize-0.0.10.jar says:
{
  "errors" : [ {
    "status" : 409,
    "message" : "Error fetching https://maven.twttr.com/com/twitter/common/objectsize/0.0.10/objectsize-0.0.10.jar: Mismatching mime types found in request: [application/java-archive] and response: text/html, and this repo blocks text/html on mismatch (remote response: 409: null)"
  } ]
}

)

@stuhood is this something someone at Twitter could address? serving up artifacts with the wrong MIME type seems like something that could affect a variety of downstream tools, not just the Scala community build in particular

the problem on the Twitter end still exists afaik (I didn't check again just now), but we don't care so much at our end now since #243, so I'm closing this

fyi @mosesn @kevinoliver

@SethTisue thanks, we're aware of the problem but don't have an excellent solution yet.

recently: a team at Twitter "took it upon themselves to migrate their dependencies to maven central. The need to use maven.twttr.com should go away entirely soon"
Adriaan: "We'll drop the maven.twttr.com repo from our artifactory cache once the move is complete"


Add AllowHostsUsernamePasswordCredentialProvider class to fix ssh url issues.

When cloning a git repo using an ssh url, often it fails because
the host is not in the ssh known-hosts list.
This fix essentially lets Spring Config answer yes to the question:
Do you trust this host.
It works by providing a new jgit CredentialsProvider class that supports the YesNoType of credential as well as Username and Password.
Issue: SCC-101

@damaru-inc Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Current coverage is 67.62% (diff: 0.00%)

Merging #521 into master will decrease coverage by 1.18%

@@             master       #521   diff @@
==========================================
  Files            60         61     +1
  Lines          2046       2082    +36
  Methods           0          0
  Messages          0          0
  Branches        341        352    +11
==========================================
  Hits           1408       1408
- Misses          499        535    +36
  Partials        139        139

Powered by Codecov. Last update 1cd7372...922dcff

Thanks Ryan,
This is my first time contributing to Spring, so please understand if I miss some stuff the first time around.
I thought I'd followed all the coding standards - tabs not spaces; license at top, etc. Please be specific if I missed a rule.
As far as unit tests go, my code does pass the existing tests. It would be difficult to create a unit test for "ssh://" git urls on a remote system. How have you Spring folk created tests for this kind of thing before?
Best regards,
Michael Davis
Ottawa

@damaru-inc ping on signing CLA

Thanks for the hints, I'll probably be able to get back to work on this in a couple of days.

@damaru-inc Thank you for signing the Contributor License Agreement!

Hi, I'm back, and have a couple of days to finish this. I've imported the Eclipse code formatter and I've written a unit test class for the new class I wrote.
Shakuzen said "I believe we would want to make the strict host key checking configurable". I'm trying to add a system property "spring.cloud.config.server.git.allow-ssh" that would need to be set to true to enable this new feature. I added a boolean property named "allowSsh" to JGitEnvironmentRepository, and my understanding is that this will get set because its subclass MultipleJGitEnvironmentRepository has the ConfigurationProperties annotation. The latter class will use that new property. But I'm not sure how to write a test for this - it requires Spring to be running, and I'll have to test it with a remote ssh repository.
Of course I could test it manually by just running it, but I want to make sure I do the right thing and use whatever test scaffolding you have - any hints you can give me would be greatly appreciated!

I added a boolean property named "allowSsh" to JGitEnvironmentRepository. Its subclass MultipleJGitEnvironmentRepository has the ConfigurationProperties annotation with the value "spring.cloud.config.server.git", so Spring will call any setters on that class for properties that start with that string, right? So the property spring.cloud.config.server.git.allow-ssh will cause the setter JGitEnvironmentRepository.allowSsh to get called. I tested this in our environment and it works.

@damaru-inc sorry for the delay. I'm hoping to clear the queue this week. There are conflicts that need to be resolved after rebase.

@damaru-inc This PR might be resolved by #535 as it adds support to turn off struct host key checking.
Do you agree, or you trying to solve a different use case?

I agree. What's the procedure for closing this pull request? Do I do that myself?

I will close it.


Stuck on pressing Register

When I enter name, email and password and press Register button the loading circle appear and nothing happens.

I was having the same issue. I reached out to Haik Aslanyan the maker of the app. He said he would work on the issues that are happening now.
Hopefully he will soon....

@StephenCBecker Thank you! Please let me know if you were somehow able to resolve this issue by yourself.

By the way, I found another project with Auth, it's not so cute, but it's working. https://github.com/firebase/friendlychat-ios

when ever i am trying to register or login it is showing Wrong Input parameters please try again. have you guys solve this problem? please help.

Make sure you have activated -> Database and Storage, in Firebase.

I am also having the same issue...I have activated the real time database also.

guys I've updated the project, this issues is fixed


Ensure workspace clean after undoing dropped node

fixes #3701
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Describe the nature of this change. What problem does it address?
Ensures undo after dropping a debug/function/link onto workspace results in a clean (!dirty) workspace
Proposed changes

When creating a new node (createNode()), get workspace dirty state BEFORE generating the node
ensure generateHistory is false for onadd() calls in debug, link and function nodes
ensure generateNodeNames options are merged (not overwritten)
correct JSDoc for generateNodeNames

Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 68.235% when pulling 78327716a4ed027582723fdc8094645513eed0d1 on Steve-Mcl:fix-undo-drop-still-dirty into 1f5588b803c7e2f216f2bfa31df7ac2cfa874480 on node-red:master.


java.lang.OutOfMemoryError: Java heap space in GCE

Hello,
We've faced an issue running elassandra of <IP_ADDRESS> version in docker container in google cloud. We got 5 nodes with elassandra. Each node has request for 3.5 CPU and 21GB of RAM. For now each node has about 1TB of data. Java version 1.8.0_162
One node constantly going into OutOfMemoryError. Full log attached.
logs-from-elassandra-in-elassandra-2.txt

Please restart your node and post the beginning of your logs to get information about memory settings and JNA initialization.
Thanks.

Here they are:
logs-from-elassandra-in-elassandra.txt
Thanks.

Here are messages indicating that your node is node properly configured for cassandra.
Please see this for example.
2018-07-02 12:42:44,233 INFO  [main] org.apache.cassandra.locator.GossipingPropertyFileSnitch.(GossipingPropertyFileSnitch.java:64) Loaded cassandra-topology.properties for compatibility
2018-07-02 12:42:44,601 WARN  [main] org.apache.cassandra.utils.NativeLibrary.tryMlockall(NativeLibrary.java:187) Unable to lock JVM memory (ENOMEM). This can result in part of the JVM being swapped out, especially with mmapped I/O enabled. Increase RLIMIT_MEMLOCK or run Cassandra as root.
2018-07-02 12:42:44,618 WARN  [main] org.elasticsearch.bootstrap.JNANatives.tryMlockall(JNANatives.java:90) Unable to lock JVM Memory: error=12, reason=Cannot allocate memory
2018-07-02 12:42:44,619 WARN  [main] org.elasticsearch.bootstrap.JNANatives.tryMlockall(JNANatives.java:91) This can result in part of the JVM being swapped out.
2018-07-02 12:42:44,619 WARN  [main] org.elasticsearch.bootstrap.JNANatives.tryMlockall(JNANatives.java:94) Increase RLIMIT_MEMLOCK, soft limit: 65536, hard limit: 65536
2018-07-02 12:42:44,620 WARN  [main] org.elasticsearch.bootstrap.JNANatives.tryMlockall(JNANatives.java:98) These can be adjusted by modifying /etc/security/limits.conf, for example:
# allow user 'cassandra' mlockall
cassandra soft memlock unlimited
cassandra hard memlock unlimited
2018-07-02 12:42:44,620 WARN  [main] org.elasticsearch.bootstrap.JNANatives.tryMlockall(JNANatives.java:104) If you are logged in interactively, you will have to re-login for the new limits to take effect.
2018-07-02 12:42:46,601 INFO  [main] org.apache.c

OK, I see
We are using docker-elassandra image and I thought it might be preconfigured.
Guide you've linked tells that I need to change /etc/security/limits.conf file. Is there any way to change memlock parameter with env variable passed to docker container or I need to do it manually by linking file to docker container?
Thanks.

For security reasons, you should set that in your docker.conf.
See https://stackoverflow.com/questions/24318543/how-to-set-ulimit-file-descriptor-on-docker-container-the-image-tag-is-phusion


[SMALLFIX] Add a util function to get the root cause of a throwable

@ifcharming

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12432/
Test PASSed.


CC63820: Changed method and variable names.

Hello, @mairaw ,
This proposed file change comes from https://github.com/dotnet/docs.ru-ru/pull/116.
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

Thanks @rpetrusha  and @mairaw


FR: Autofocus cursor in search box

Nice looking plugin so far. I’m using an iPad Pro 2020 with external keyboard so this plugin looks like it will be really helpful for adding emoji with less fuss.
It would be really helpful for the cursor to autofocus in the plugin’s search box after bringing it up with a hotkey. Currently I have to tap in manually.

I am using the autofocus html attr to accomplish this here.
Must be something related to iOS. Confirming that it ignores autofocus... confirmed. Looks like something they make difficult on purpose, though it can probably be worked around.


Why can't I use the 'brew install infer' command to install infer v1.0.0

How to solve this problem?

See here: https://github.com/facebook/infer/issues/1354

Also, you could just download a binary release straight from GitHub rather than using brew: https://github.com/facebook/infer/issues/1354#issuecomment-737163890

So far there are issues with updating the Homebrew formula to 1.0.0. Let's keep the discussion there: https://github.com/Homebrew/homebrew-core/pull/62862


routes.js...

My webapp is located:
/Users/username/developer/projects/jimbeam/
with the following files:
/Users/username/developer/projects/jimbeam/index.html
/Users/username/developer/projects/jimbeam/css/style.css
DevTools Autosave -> Options:
Resource: ^http://jimbeam.dev/
Post To: http://<IP_ADDRESS>:9104/save
Routes are ~/chrome-devtools-autosave/jimbeam-routes.js:
exports.routes = [{
from: /^http://jimbeam.dev//,
to: '/Users/username/developer/projects/jimbeam/'
}];
I run the following from the terminal: autosave --config ~/chrome-devtools-autosave/jimbeam-routes.js
The response in the terminal is: DevTools Autosave 0.3.1 is running on http://<IP_ADDRESS>:9104
When I navigate to: http://<IP_ADDRESS>:9104/
The browser responds with: DevTools Autosave 0.3.1 is running well.
I update some styling in chrome. I refresh the page, none of the styles are saved. No errors in the open terminal window where the server is running. It still just reads: DevTools Autosave 0.3.1 is running on http://<IP_ADDRESS>:9104
I am running chrome 19.0.1049.3 dev, node v0.6.10
Any ideas?

Do you see any errors in the following?

Background page’s console (how to open)
DevTools (how to open)

I've been having some similar issues. some interesting points of note:

Modifying styles always works, never an issue there, so routes must be fine.
Creating new styles results in no error in the notification windows but upon inspecting in the console returns with:

2/27/12 9:42:43.303 AM [0x0-0x74074].com.google.Chrome: [997:1547:3846280138661:ERROR:CONSOLE(21)] "[[foo url]] does not correspond to any backend.", source: chrome-extension://fdebcbmmihnbmkkadfbgapegofoagajd/devtools.html (21)

I've mentioned this previously but grab your asses on this one. IF you have a style sheet in the BODY of the document (yes I know ick). Everything works perfectly.

It looks like it has something to do with newly created styles for some reason.
As a disclosure: I'm still on the latest public release (17.0.9...)

more details:

upon further review I think its somehow related to the Reset method.

Upon initial navigation to a page, there are no problems UNTIL you refresh the page. (so everything works as expected)
If you refresh the page then navigate around and come back the messaging changes to the following:

Updating existing styles always work.  Should be noted that the nodejs output switches between "Saved a (document || stylesheet )

Okay this is definitely perplexing, but everything is working fine now after I updated my Github repository with the latest from   NV.
Is it possible that having an extension disabled still means it can impact other extensions (the official release)?
Sorry for hijacking this thread, I was convinced my issue was related to this one.
Thanks NV for sharing how to inspect the devtools, ive been wondering how you debug that magic.

Creating new styles results in no error in the notification windows but upon inspecting in the console returns with:
2/27/12 9:42:43.303 AM [0x0-0x74074].com.google.Chrome: [997:1547:3846280138661:ERROR:CONSOLE(21)]
"[[foo url]] does not correspond to any backend.", source:
chrome-extension://fdebcbmmihnbmkkadfbgapegofoagajd/devtools.html (21)

Do you have "newly added CSS rules" checkbox turned on in the extension’s options?
(I should make the error message more informative)

upon further review I think its somehow related to the Reset method.

Upon initial navigation to a page, there are no problems UNTIL you refresh the page. (so everything works as expected)
If you refresh the page then navigate around and come back the messaging changes to the following:

That’s new. Does it happen on DevTools Autosave version 1.1.3? Would you mind posting to gist.github.com (or sending me personally, if you wish) HTML page you are working on?

Is it possible that having an extension disabled still means it can impact other extensions (the official release)?

No.
P.S. I’m on vacation till March 3, so my replies are delayed.

I definitely have that option checked, and it does work when the page is first visited.... it only doesnt work when re-visited.

i unfortunately can't send the page im working on but ill try to sort out a testcase

also it turns out that the issue isnt actually resolved, somehow i thought it was working because the stylesheet link made its way back into my body tag (which is my current work around and always works).


4:1: Error: A library can't opt out of null safety by default, when using sound null safety. // @dart=2.0

Give me the below error while building the app:-
package/influxdb-client/lib/model/write_precision.dart:4:1: Error: A library can't opt out of null safety by default, when using sound null safety. // @dart=2.0 ^^^^^^^^^^^^
this error comes in many files on the package... Kindly guide me
@pauldix  @brettbuddin @mkmik @stuartcarnie @rockstar

Hi @ADLsourceCode,
thanks for using our client.
Which version of Dart do you use?
Regards

@ADLsourceCode thanks for quick response.
How do you build your project? Do you use configured web compilers (https://github.com/dart-lang/build/blob/master/build_web_compilers/README.md#configuring-the-sound-null-safety-mode)?


Changing shot button icon does not change.

I'm trying to change the camera shot button from green to black. I've edited the button color, however when I try changing the icon image it stays the same ( green) every time.
 shotButton.setImage(YPConfig.icons.capturePhotoImage, for: .normal)
public var capturePhotoImage: UIImage = imageFromBundle("Capture")
I changed the name from yp_iconCapture to "Capture" so I could use my own custom image. No luck..

This way seemed to work for me
`var config = YPImagePickerConfiguration()
    // get capture icon from system icon
    let newCapturePhotoImage = UIImage(systemName: "largecircle.fill.circle")?
        .imageWith(newSize: CGSize(width: 168, height: 168))
        .withTintColor(UIColor.label)
    ?? config.icons.capturePhotoImage

    config.icons.capturePhotoImage = newCapturePhotoImage`

@mlm249  Thank you.

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


[BUG]: AWS params ignored when endpoint is set

Describe the bug
onetable-cli ignores other AWS config if endpoint is set
To Reproduce
Steps to reproduce the behavior:

Set up a migrate.json like this

  "schema": "src/data/db/schema.ts",
  "name": "mytable",
  "profiles": {
    "local": {
      "aws": {
        "endpoint": "http://localhost:4567",
        "region": "local",
        "accessKeyId": "test",
        "secretAccessKey": "test"
      }
    }
  }
}

Create the table in dynamodb-local with the same creds above
Run any onetable-cli commands

Cannot communicate with DynamoDB "mytable" at "localhost"
Cannot do operations on a non-existent table

Expected behavior
Onetable-cli should honor the other aws properties when using a local endpoint.
Additional context
When running dynamodb-local without -sharedDb it creates a separate table for each region/accesskey, so if we don't pass the params through then it can't find the db table.

Is it the keys or the region too?  We typically just set the local region to 'localhost'.

Sorry this got overlooked.
Actually, looks like it is fixed now. I'll close. Let me know if it doesn't work for you, but works here now.


API - Plugins

Stub.
Feel free to comment here if you have ideas on what this guide should cover. Link to potential resources too.

Closing in favor of #37.


chore(internals): 🔧 choose the wanted component folder while generating

This MR add folder selection for the component generator so we can create components also in containers/components folders

Pull Request Test Coverage Report for Build 298280829

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.673%

Totals

Change from base Build 270590616:
0.0%

Covered Lines:
245

Relevant Lines:
245

💛  - Coveralls

This is cool but tests are failing. You have to fix bit of things. I can take a look afterwards
https://github.com/react-boilerplate/react-boilerplate-cra-template/runs/1233538912?check_suite_focus=true

I ll try this before the next release. Sorry for the delay. I moved to another country and pretty busy :)

Oh wait I forgot about this pr, I ended up changing a few things that were not complete yet for my own usage, I will do an update this weekend.


Move tools/generate-custom-webfont-icon to run as part of update-prod-static

I've determined that tools/generate-custom-webfont-icon never produces the same output twice (probably there's a timestamp in there). Given that it only takes 300ms to run, I think we want to move this to the update-prod-static / static/generated system. I'll open a follow-up issue.
We should move it to work more like tools/setup/build_pygments_data where it gets run in provision and update-prod-static, outputs to static/generated/icons, etc.
Tagging this as medium since this sort of technical debt is good to clean up quickly.

I have had a first attempt: https://github.com/rht/zulip/commit/db11a594b1770fc022a4bb227b4272243e12a6a9. Blocked by getting it to work at update-prod-static (see the build error at https://travis-ci.org/rht/zulip/jobs/300885264). I think a better strategy at update-prod-static is to copy the css file already generated when provision has been run, similar to tools/setup/generate_zulip_bots_static_files?
Note that this (just copy-ing files over) can be generalized to other "generate" scripts to remove redundancy between provision and update-prod-static, since a provision is always run before update-prod-static anyway.

@rht no, we should do the same thing we do with katex for copying the file.
The problem is your assumption is wrong.  update-prod-static is used for production servers, including upgrade-zulip-from-git and build-release-tarball, and in neither case is provision run before on that copy of zulip.git.

@rht can you prioritize fixing your implementation?

OK

Requesting advice from @pweaver: I can't run the ./tools/generate-custom-icon-webfont inside of update-prod-static because the node_modules directory is removed during the setup_node_modules step. To make the approach similar to katex, should ./tools/generate-custom-icon-webfont be moved into a step in package.json instead?

Are you sure you are not getting the error because the     "webfonts-generator" package is in devDependencies rather than dependencies?

Also, the references in settings.py need to be updated.

Oh, actually the fix is to just add webfonts-generator to prod dependencies list in package.json.

@pweaver just saw your comments, right, thanks a lot !


Unpaid value does not update

Steps to reproduce

mark job
assign job to new person
new person's $unpaid does not update

Elliots suggested fix:

make it such that you can't assign a marked job

Closed by #135
See also #137


Add link to scheduled pipeline

CATEGORY
Choose one

[ ] Bug Fix
[X] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

This PR makes it possible to add a link from the scheduled query to the pipeline running it. The user can provide a URL template, that gets formatted with the query to produce a link that takes to the corresponding pipeline (see example in updated docs).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

I also added some CSS to remove the disabled + button in the form, so it looks better.
TEST PLAN

Tested locally, and added unit tests for the helper functions.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@khtruong @DiggidyDave @datability-io

Codecov Report

Merging #7536 into lyft-develop will decrease coverage by <.01%.
The diff coverage is 45%.

@@               Coverage Diff                @@
##           lyft-develop    #7536      +/-   ##
================================================
- Coverage         65.19%   65.18%   -0.01%
================================================
  Files               433      434       +1
  Lines             21431    21446      +15
  Branches           2362     2368       +6
================================================
+ Hits              13971    13980       +9
- Misses             7340     7346       +6
  Partials            120      120

Impacted Files
Coverage Δ

superset/views/sql_lab.py
85.71% <0%> (-1.25%)
:arrow_down:

superset/assets/src/showSavedQuery/index.jsx
0% <0%> (ø)
:arrow_up:

superset/assets/src/showSavedQuery/utils.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acbb04...0702068. Read the comment docs.

@DiggidyDave is this good to go then?

👍

Closing since I merged to master in https://github.com/apache/incubator-superset/pull/7584.


SKCanvasView default colorspace

It looks like SKCanvasView always get created using an SKImageInfo that lacks colorspace specification. Wouldn't there be a way to specify the color space we want our canvases to be created with? Converting images allows us to specify color space at both ends but drawing onto the canvas does not, so Skia's color corrected behavior doesn't kick in at all.

Just for illustration, in SkiaSharp.Views.Android\SKCanvasView.cs, line 50:
info = new SKImageInfo(0, 0, SKColorType.Rgba8888, SKAlphaType.Premul);

There is no colorspace definition at the end.

This is a good point. Will a property (and maybe a constructor overload) that provides a place to set the desired colorspace be useful?
How would you want to set/specify a colorspace in your current usage? Also, if you were to specify a colorsapce, what other options will you need for the view to create a correct surface with that colorspace?

A constructor could be OK with UI created in code but doesn't help much with XAML. Isn't a property too late for the initialization? If it can be solved, that would be just fine. You could have an enum with Default and all the ready made spaces but I don't know how you would supply an ICC file if need be.
Perhaps if we knew if the passed SKImageInfo could be replaced later on or had to be absolutely ready and final when the surface is created.

A property might work because I technically only guarantee the surface during the draw method. If you change the colorspace, all we have to do is nuke the surface and invalidate. Then the draw method will re-create the surface with the new colorspace.
I probably will have to create a system like with the Brush of UWP/WPF because some of the colorspaces have additional parameters:
class abstract SKBaseColorSpace {
    public SKColorSpace ColorSpace { get; }
}
class SKSrgbColorSpace : SKBaseColorSpace {
    public bool IsLinear { get; set; }
}
class SKIccColorSpace : SKBaseColorSpace {
    public ImageSource Icc  { get; set; } // to byte[]
}
class SKRgbColorSpace : SKBaseColorSpace {
    // one of these
    public SKNamedGamma Gamma { get; set; } // enum
    public SKColorSpaceTransferFn Gamma { get; set; } // struct

    // with one of these
    public SKColorSpaceGamut Gamut { get; set; } // enum
    public SKMatrix44 Gamut { get; set; } // struct
}

<SKCanvasView>
        <!-- sRGB -->
        <SKSrgbColorSpace IsLinear="true" />

        <!-- ICC -->
        <SKIccColorSpace Icc="my_colors.icc" />

        <!-- RGB -->
        <SKRgbColorSpace Gamma="TwoDotTwoCurve" Gamut="AdobeRgb" />
        <SKRgbColorSpace Gamma="1.0, 1.0, 0.0, 0.0, 0.0, 0.0, 0.0" Gamut="0.4360747, 0.3850649, 0.1430804, 0.2225045, 0.7168786, 0.0606169, 0.0139322, 0.0971045, 0.7141733" />
    <SKCanvasView.ColorSpace>
</SKCanvasView>

This may be harder to do because not everything is great in XAML. Also, this is drawing logic, so there can be no delays.
With the ICC, this file may take a second to load, and we can't have the drawing freezing. So, do we just go with nothing and have bad colors for a few frames? Do we force this to be loaded synchronously and then set - basically this is a byte[] property?
With the RGB, there is a a combo of two properties, each of which can either be an enum value or a matrix-like format.

This might be more complicated than really necessary, although elegant. I could totally accept that spaces that need construction (full CreateRgb and CreateIcc) are only available through a constructor. Even if you use XAML, it's not that big a deal to instantiate the view yourself in specific cases. Then you'd only need to provide an enum for the simple cases:
Default, Srgb, SrgbLinear, AdobeRgb, etc

But you could include specific CreateRgb cases as well, this might be where AdobeRgb comes from.
If you only allow the CreateRgb(SKColorSpaceRenderTargetGamma.Linear, SKColorSpaceGamut, SKColorSpaceFlags) form, then you have a still affordable solution like:
<SKCanvasView ColorSpace="Default" />
<SKCanvasView ColorSpace="Srgb" />
<SKCanvasView ColorSpace="AdobeRgb" />

Or, an alternative solution for the more complicated cases could be a static property that you need to fill in with the space before the canvas view gets created, practically in the constructor before InitializeComponent(). Then either coefficients or color profiles could be read whenever the user sees fit, during app startup, and simply provided as a ready SKColorSpace when necessary. And it also can be reused across the application, if necessary (eg. I have a list view where each cell has a canvas, it would be logical to use a single color space instance for them all).


:bug: Fix compile step

Fixes #393
Remove "compile" goal from maven invocations, as some applications may not be compilable with the JDK version we bundle.
Related to https://github.com/konveyor/analyzer-lsp/issues/393 and https://github.com/konveyor/analyzer-lsp/issues/393

Do we have a multi-module test case yet? I would love to see that added with/ this change to make sure we don't break that in the future (I am worried about me breaking it :) )

Do we have a multi-module test case yet? I would love to see that added with/ this change to make sure we don't break that in the future (I am worried about me breaking it :) )

Captured in issue here, will add sometime this week https://github.com/konveyor/analyzer-lsp/issues/399

Do we have a multi-module test case yet? I would love to see that added with/ this change to make sure we don't break that in the future (I am worried about me breaking it :) )

If it helps: The problem came up in my (company project) multi project build. Tested the patch with that project already.

Thanks!


Improve descent map typing

Improves the typing around DescentMap. This was meant to be a PoC, it could be improved quite a bit, esp. around type conversions.
Issue Number: N/A
Type

[ ] feature
[ ] bugfix
[ ] dev (no functional changes, no API changes)
[ ] fmt (formatting, renaming)
[ ] build
[ ] docs
[ ] testing

Description
Breaking changes?

[ ] yes
[ ] no

Merged in msl repo: https://github.com/Moonsong-Labs/snos/pull/14


bugfix(utils): merge boolean values

Bugfix (utils)
Description
Allow to use boolean values in the .febuild config file
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

I guess we would need to update the version and the changelog? @easingthemes

I guess we would need to update the version and the changelog? @easingthemes

No need, if correct rules are used in commits, which is the case here.
Check: https://github.com/Netcentric/fe-build/blob/main/docs/CONTRIBUTING.md#automated-release


fixed: issues/15

页面跳转 bug https://github.com/beezen/echarts4taro3/issues/15

@zhangyuanliang 感谢贡献


Avoid some unnecessary allocations in exec().

@bors-servo r+

:pushpin: Commit ec08fca has been approved by frewsxcv

:hourglass: Testing commit ec08fca with merge 491dba1...

:sunny: Test successful - travis


Update docs with how to start and create a station

I am attempting to set this up and it appears the docs and man pages may be a bit out of date.
1. Quick start (draft)
wspace init
space tle celestrak fetch

That sets up a space and loads some satellites.
2. How to add planets?
3. How to create a first station?
I can't get space station create to work.  Silently fails.  space log shows:
2023-06-08T11:17:12.006 :: space :: DEBUG :: === command 'station' failed with return code  2 ===

Example attempt
space station create FWS FortWorth 32 -97 207

Hello !
To add planets, you have to follow the explanations provided by space planet --help. I noticed some minor problems that prevented the automated process (i.e. the fetch sub command) to work correctly in the current version. If you want a specific planet or moon to be handled, I would like to point you to the aa_summaries.txt file presents here or here. They will tell you which file to download in order to make it available in space-command.
As for station creation, I noticed a while ago that negative coordinate were not handled properly, but got around it by directly setting the station in the config file. This is obviously not optimal.
I just pushed two commits correcting both issues in the 'dev' branch.
On a general note, I agree that the documentation is lacking examples. I will try to take some time to correct this in the coming weeks.
Thanks !


bug fix in nbextensions/config/hotkey_editor.js…

… provide missing humanize_key method for use in quickhelp patch methods. This should have been included from the beginning, I just didn't do enough testing :(

addresses #388

there we go! That should work (touch wood!)


Make resources a slash command.

Currently, the resources command allows to fetch certain resources with a specific topic.
The catch is: You need to know the different topics that we have.
This can be made easier by switching to a Slash command that allows auto completion whenever we input text.
Requirements
We'll need to expose an api that allows to fetch the resources and cache them, as they're not that prone to change.
If indeed we introduce a new resource to site, we can have a  reload subcommand to reload the resources from the api (which we'll restrict to particular roles/users)

If you look through the uses of the !resources command, it's very often used as a reply to someone, which is useful, especially in busy channels like #python-discussion where it wouldn't be obvious otherwise. Switching to a slash command would make this not work any more.
Using the topic arguments is less common and useful in less cases, since it's usually good enough to link someone to the overall page and let them decide what specifically they want to look for, so I don't think it's worth the worse user experience in other cases.
I also personally think slash commands are more clunky in general, for example if someone just wanted a message after the resources command like !resources Take a look at these resources then the UX with slash commands would be worse.

Now that I've read what you've said, I agree with you.
I'll close this then, thanks!


[10.0.x] NO-ISSUE: Fix release deploy job running commands in a wrong directory

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2091 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2091/1/display/redirect
Test results:

PASSED: 1660
FAILED: 5

Those are the test failures:

org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents
1 expectation failed.JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.Expected: managers  Actual: null

org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBKafkaIT.testProcessInstanceEvents
1 expectation failed.JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.Expected: managers  Actual: null

org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents
1 expectation failed.JSON path errors doesn't match.Expected: null  Actual: <[{message=Exception while fetching data (/UserTaskInstances[0]/schema) : Runtime service URL not defined, please review the kogito.service.url system property to point the public URL for this runtime., locations=[{line=1, column=85}], path=[UserTaskInstances, 0, schema], extensions={classification=DataFetchingException}}]>

org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents
1 expectation failed.JSON path data.UserTaskInstances[0].potentialGroups[0] doesn't match.Expected: managers  Actual: null

org.kie.kogito.jobs.service.scheduler.impl.VertxTimerServiceSchedulerTest.testScheduleJob
Unnecessary stubbings detected.Clean & maintainable test code requires zero unnecessary code.Following stubbings are unnecessary (click to navigate to relevant line of code):  1. -> at org.kie.kogito.jobs.service.scheduler.impl.VertxTimerServiceSchedulerTest.testScheduleJob(VertxTimerServiceSchedulerTest.java:98)Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.


Zipsprout

Danielle Darkangelo

They are Durham based startup. They got us the Homeadvisor donation. Panelists/speakers? I haven't mentioned anything to to them about this.


Fix wrong function call to grab_images

The old function calls went to grab_images instead of _grab_images.
This caused a TypeError (grab_images takes 3 arguments, 4 were given).
It appears that the function call should instead go to the similarily
named function _grab_images.

Okay I had time to check that this actually does what I assumed and it looks fine to me:
>>> cams = pypylon.factory.find_devices()
>>> cam = pypylon.factory.create_device(cams[0])
>>> cam.open()
>>> type(cam.grab_image())
<class 'numpy.ndarray'>
>>> cam.grab_image()
array([[ 4,  5,  5, ...,  6,  6,  6],
       [ 5,  5,  5, ...,  6,  7,  6],
       [ 4,  5,  5, ...,  7,  6,  6],
       ...,
       [12, 13, 12, ...,  9,  8,  9],
       [13, 14, 13, ...,  8,  7,  9],
       [13, 14, 12, ...,  8, 10,  8]], dtype=uint8)

Anything else I can do?

Sorry for the extreme delay, somehow I just noticed this.
I've always used the grab_images() interface, even when grabbing only one so I hadn't noticed this.


Can't show right slider, native browser, Samsung Grand Prime (0.10.3)

Hi, thanks for this great work,
it saved our project. <3
Problem
Samsung grand prime, Android 4.4.1, native browser
When I click the .sb-toggle-right button, only show white and nothing
Codepen
The usage template
jquery 1.10.2
slidebars 0.10.3
http://codepen.io/sidk/pen/ojJjjZ
Before & after

Update
slidebars 0.8  works fine, can toggle the right slider

Glad you got it working :)


Ceedling 0.15.6 Fails When Path Contains Space(s)

I updated from version 0.13.0, which was working fine, to 0.15.6. I am using Mingw32 under Windows. I did the following in a path containing a space (c:/Project Xtreme/):
> ceedling new PcControl
> cd PcControl
> rake module:create[Dummy]
> rake test:all

The last command dumped the following error:
Test 'test_Dummy.c'
-------------------
gcc.exe: error: Xtreme/PcControl/vendor/ceedling/vendor/unity/src: No such file
or directory
gcc.exe: error: Xtreme/PcControl/vendor/ceedling/vendor/cmock/src: No such file
or directory
ERROR: Shell command failed.
> Shell executed command:
'gcc.exe -E -MM -MG -Itest -Itest/support -Isrc -Ic:/Project Xtreme/PcControl/ve
ndor/ceedling/vendor/unity/src -Ic:/Project Xtreme/PcControl/vendor/ceedling/ven
dor/cmock/src -Ibuild/test/mocks -DTEST -DTEST -DGNU_COMPILER -w "build/temp/_te
st_Dummy.c"'
> And exited with status: [1].

rake aborted!
ShellExecutionException
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/tool_executor.rb:74:in
`exec'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator_includ
es_handler.rb:39:in `form_shallow_dependencies_rule'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator.rb:31:
in `preprocess_shallow_includes'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator.rb:11:
in `block in setup'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator_helper
.rb:11:in `call'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator_helper
.rb:11:in `preprocess_includes'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/preprocessinator.rb:17:
in `preprocess_test_and_invoke_test_mocks'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/test_invoker.rb:42:in `
block in setup_and_invoke'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/test_invoker.rb:32:in `
setup_and_invoke'
c:/Project Xtreme/PcControl/vendor/ceedling/lib/ceedling/tasks_tests.rake:8:in `
block (2 levels) in <top (required)>'
Tasks: TOP => test:all
(See full trace by running task with --trace)

--------------------
OVERALL TEST SUMMARY
--------------------

No tests executed.

I works fine with path without space, though.

+1 on this issue. I am showing my paths below and if any of them have a space (like CAN Library does currently), it complains.
:paths:
:include:
- "C:/microchip/xc16/v1.21/support/DSPIC33E/h/"
- "C:/microchip/xc16/v1.21/support/generic/h/"
- "../../../../USB_Library/"
- "../../../../Shared/Software/Firmware/"
- "../../../../CAN Library/"
- vendor/ceedling/vendor/unity/src
:test:
- +:test/**
- -:test/support
:source:
- "../../../../Shared/Software/Firmware/"
:support:
- test/support
I upgraded to 0.18.0 and it seems to have the same problem.
Thanks,
Jim

Same exact problem as jimmanz

Could not reproduce on master. Is anyone still having this issue?

I am not

I did not succeeded fixing this yet. Any hint is welcome =)

Can you try to execute xc16-gcc command from the windows terminal?
When I was trying to run the xc16-gcc from the command line on Windows 10, I've got this message:
Program: Files: No such file or directory
Program: (x86)\Microchip\xc16\v1.35\bin\bin/elf-gcc.exe: No such file or directory
Program: no input files

So I think it doesn't have to be particularly related to the Ceedling, but maybe something is wrong with xc16-gcc installation when install path contains spaces or parenthesis.


DROOLS-5197,5744 - DMN Enumeration constraint editor small enhancements

As part of this PR we:

prevent user from defining same enumeration item multiple times: https://issues.redhat.com/browse/DROOLS-5197
commit all enumeration items in edit mode by click on single checkbox: https://issues.redhat.com/browse/DROOLS-5744

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

The (build) kogito-tooling-editors-java check has failed. Please check the logs.

@yesamer a Jira created https://issues.redhat.com/browse/KOGITO-6328

@yesamer please merge when you have a moment.


Moved abstract jct compiler out of the impl package

#178
Moved  abstract jct compiler out of the impl package

You'll need to move the class file to the parent directory for this to compile. There will be one or two classes that'll reference this class too.
Which IDE/editor are you using? IntelliJ should be able to refactor this automatically if that helps! :-)
Will assign the issue over to you


Serialize Widget Variable parameters

Ensures that all non-default Widget Variable parameters are correctly serialized.

Codecov Report

Merging #382 (98d7d7a) into master (9c68ae3) will increase coverage by 0.05%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   67.22%   67.27%   +0.05%
==========================================
  Files          72       72
  Lines        7947     7967      +20
==========================================
+ Hits         5342     5360      +18
- Misses       2605     2607       +2

Impacted Files
Coverage Δ

lumen/variables/base.py
80.30% <85.71%> (+0.41%)
:arrow_up:

lumen/tests/test_variables.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Does it work with npm or not?

Can you provide some clarification regarding the npm transition (or not) and eagerly loaded languages?
I saw that in 2.0.0 you introduced an npm package, and then removed examples related to it in 2.0.1?
I tried installing the npm package with npm install meteor-accounts-t9n, but the app crashes because it tries to import meteor/tracker (which is why you went back?).
Can you make it clear what works and what does not? And specify whether issue #161 is truly solved or not, the README is a bit confusing?
Thanks for your work! :)

Yes, I ran into the same thing. I need to find some free time to look into and document it well, with a little luck I get to it on the weekend.

The reason why examples/meteorNpm works for me is that I used a symbolic link to meteor-accounts-t9n in node_modules. When I create a new Meteor and just npm install meteor-accounts-t9n I see the same error as you. I would regard this feature as broken for the moment. There is some hope that MDG will release a npm package of Tracker, then this should work as expected.
If you want to use it as an npm package today the workaournd is to clone meteor-accounts-t9n to a different directory and put a symbolic link in node_modules of your Meteor project.


[Html] Introduce HTML component

changelog
features

added Psl\Html\encode function
added Psl\Html\encode_special_characters function
added Psl\Html\decode function
added Psl\Html\decode_special_characters function

Pull Request Test Coverage Report for Build 624563696

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0001%) to 99.961%

Totals

Change from base Build 624303563:
0.0001%

Covered Lines:
2538

Relevant Lines:
2539

💛  - Coveralls


MF-665 - Document subtopic usage

What does this do?
Updates subtopics section in documentation.
Which issue(s) does this PR fix/relate to?
Resolves #665.

Codecov Report

Merging #670 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   86.29%   86.24%   -0.06%
==========================================
  Files          62       62
  Lines        3722     3722
==========================================
- Hits         3212     3210       -2
- Misses        353      355       +2
  Partials      157      157

Impacted Files
Coverage Δ

things/service.go
92.85% <0%> (-1.3%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea79f22...3d8c343. Read the comment docs.


Issues about data preparation

EEND-master/egs/mini_librispeech/v1/utils/validate_data_dir.sh: no such directory data/simu/data/train_clean_5_ns2_beta2_10
run.pl: job failed, log is in data/simu/.work/random_mixture_train_clean_5_ns2_beta2_10.log
utils/split_scp.pl: error: empty input scp file data/simu/.work/mixture_train_clean_5_ns2_beta2_10.scp
utils/split_scp.pl: You are splitting into too many pieces! [reduce $nj (10) to be smaller than the number of lines (0) in data/simu/.work/mixture_train_clean_5_ns2_beta2_10.scp]
I don't know how to solve this problem. Thanks a lot for ur help!

I have the same problem, do u know how to solve it? Thanks!


feat: add pr template

add pull request template file.

@ArangoGutierrez will be able to comment on where we stand w.r.t. PR templates.

I like the idea of ISSUE templates, but I think once we have it here, we should agree on having it on all team repos.
WDYT @klueska @elezar ?

@yyzxw thanks for the contribution.
As @ArangoGutierrez points out, templates is something that we would like to address at a group-level so as to remain somewhat consistent across projects.
Closing this for now.


Custom options to chromium

Hi again!
We need to pass a custom option to chromium on startup, in this case we need "--font-render-hinting=none". I don't see an immediate way to do this.
See https://github.com/puppeteer/puppeteer/issues/2410 for why we need font-render-hinting=none. In any case, it would be useful to be able to pass custom options.

Hi @norpan,
I think at the moment there is no config option built in to do this, but I think we can add one.
I guess the part in question is to be found here:
https://github.com/bitcrowd/chromic_pdf/blob/main/lib/chromic_pdf/pdf/chrome_impl.ex#L22-L30
We can have a look next time we are working on the project. In the meantime feel free to drop a PR for adding a config option yourself.
Cheers
Andi

Hi @norpan,
I think at the moment there is no config option built in to do this, but I think we can add one.
I guess the part in question is to be found here:
https://github.com/bitcrowd/chromic_pdf/blob/main/lib/chromic_pdf/pdf/chrome_impl.ex#L22-L30
We can have a look next time we are working on the project. In the meantime feel free to drop a PR for adding a config option yourself.
Cheers
Andi

Thanks, I'll add it and make a PR. Would you prefer a specific option just for font-render-hinting (which maybe a niche case, I'm not sure) or a generic way to add any option to chromium on start?
Also, with regards to #92, I will do the same. I guess it's a matter of adding that command to print_to_pdf.ex.

Thanks, I'll add it and make a PR. Would you prefer a specific option just for font-render-hinting (which maybe a niche case, I'm not sure) or a generic way to add any option to chromium on start?
Also, with regards to #92, I will do the same. I guess it's a matter of adding that command to print_to_pdf.ex.

@norpan according to this comment in the puppeteer issue, puppeteer sets the font-render-hinting to medium by default? Is that a sane default to adopt for ChromicPDF as well?

@norpan according to this comment in the puppeteer issue, puppeteer sets the font-render-hinting to medium by default? Is that a sane default to adopt for ChromicPDF as well?

I don't know what a sane default is. I would assume that Chrome's default would be the sane one but in our setting we've found that only "none" gives the correct result.

I don't know what a sane default is. I would assume that Chrome's default would be the sane one but in our setting we've found that only "none" gives the correct result.

🤔  the information in the puppeteer ticket and the Chromium commit is odd and contradictory. My gutfeel is to make it a specific option and let it default to none. I'll check later tonight whether this has any (negative) effect on our templates.

🤔  the information in the puppeteer ticket and the Chromium commit is odd and contradictory. My gutfeel is to make it a specific option and let it default to none. I'll check later tonight whether this has any (negative) effect on our templates.

I tried a few PDF templates and they all looked exactly the same to me, no matter whether I used none, medium or high. Maybe Skia's subpixel glyph rendering is hard to notice though, unless it bites you. So from my perspective we could let it default to none, which seems to be the consensus on the issue you linked. However, puppeteer itself does not set any default value for it, plus it might still break font rendering for other ChromicPDF users (which I don't think there are too many, but nonetheless), so let's just add the option and not set it by default, please.

I tried a few PDF templates and they all looked exactly the same to me, no matter whether I used none, medium or high. Maybe Skia's subpixel glyph rendering is hard to notice though, unless it bites you. So from my perspective we could let it default to none, which seems to be the consensus on the issue you linked. However, puppeteer itself does not set any default value for it, plus it might still break font rendering for other ChromicPDF users (which I don't think there are too many, but nonetheless), so let's just add the option and not set it by default, please.

Yes, I think it matters what kind of fonts you use. The issue we had was that the spacing between characters was wrong when using a specific font. It only affects character spacing as far as I can see. The actual pixel rendering of the characters is not done by chrome, the font is embedded in the pdf as vectors.

Yes, I think it matters what kind of fonts you use. The issue we had was that the spacing between characters was wrong when using a specific font. It only affects character spacing as far as I can see. The actual pixel rendering of the characters is not done by chrome, the font is embedded in the pdf as vectors.


JS: Handle versions specified as GitHub URLs

From @DeepDiver1975 on January 9, 2018 13:32
see https://github.com/owncloud/dep-graph-issue/blob/db6098e260f7d5c6413fca808b060df3c99baba1/package.json#L13-L15
"dependencies": {
    "@bower_components/Jcrop": "tapmodo/Jcrop#^2.0.3",
<EMAIL_ADDRESS>"jakiestfu/Snap.js#~1.9.3",
"@bower_components/backbone": "jashkenas/backbone#semver:^1.3.1",

tapmodo/Jcrop and jashkenas/backbone have higher versions available but none of them are updated.
THX a lot
Copied from original issue: dependabot/feedback#71

Thanks for the feedback. I'll take a look into it.

This is all working now - the repo you linked to doesn't have a package-json.lock, and the new versions for tapmodo/Jcrop and jashkenas/backbone are within the permitted range in your package.json, so Dependabot hasn't generated PRs for you, but the update logic is running fine.
Thanks for the feature request!

FYI, I've started work on this over at https://github.com/dependabot/dependabot-core/pull/221.

From @DeepDiver1975 on January 15, 2018 9:57

This is all working now - the repo you linked to doesn't have a package-json.lock

is package-lock required or should this work with yarn.lock as well?
I just added yarn.lock with one dep being outdated and I see no PR being created.
But maybe I'm just doing it wrong ;-)

From @DeepDiver1975 on January 15, 2018 7:32
Thanks a lot @greysteil

From @DeepDiver1975 on January 15, 2018 10:31

A yarn.lock won't work with dependencies that specify a semver commit-ish

the yarn guys are working on this - the next version should support semver on the git url
https://github.com/yarnpkg/yarn/pull/5140


[BUG] Canvas module returning a 404 download

I'm trying to use the Yarn install command within the directory where the project is at. However, the node-canvas module that the project requires is randomly returning a 404 GET request to it's release file on GitHub. The URL it was requesting also returns a 404 message in my web browser. Not sure why this is occurring considering that it was available and working last time I was using DaedalOS on my local machine. Can someone assist me on this?
Log
warning Error running install script for optional dependency: "/home/shaun/daedalOS/node_modules/canvas: Command failed.
Exit code: 1
Command: node-pre-gyp install --fallback-to-build --update-binary
Arguments:
Directory: /home/shaun/daedalOS/node_modules/canvas
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>
node-pre-gyp info using<EMAIL_ADDRESS>| linux | arm64
(node:2034835) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v127-linux-glibc-arm64.tar.gz
node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v127
-linux-glibc-arm64.tar.gz
node-pre-gyp WARN Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v127 ABI, glibc) (falling back to source compile with node
-gyp)
node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.11.2/canvas-v2.11.2-node-v1
27-linux-glibc-arm64.tar.gz
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>
gyp info using<EMAIL_ADDRESS>| linux | arm64
gyp info ok
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>
gyp info using<EMAIL_ADDRESS>| linux | arm64
gyp info find Python using Python version 3.12.3 found at \"/usr/bin/python3\"

see https://github.com/Automattic/node-canvas/issues/1662

I guess this is because you are running on a Apple ARM CPU? I am not sure if there is a way around this currently if that is the case.
I wonder if that linked issue is indeed related, I don't see a fix coming in yet.
Any suggestions what I could change as I don't have a machine to reproduce this issue?

As I correct understand, node-canvas comes from some dependency(ies). Closer to issue, I think needed to try build this package itself on that ARM64: https://github.com/Automattic/node-canvas/wiki#installation-guides and npm_config_build_from_source=true yarn install node-canvas --force (from https://stackoverflow.com/a/55368337)

as I don't have a machine to reproduce this issue?

Here are the guides for running ARM64 Linux on QEMU:

https://gist.github.com/billti/d904fd6124bf6f10ba2c1e3736f0f0f7 (Ubuntu)
https://gist.github.com/cGandom/23764ad5517c8ec1d7cd904b923ad863 (Raspbian)

or via Docker:

https://www.docker.com/blog/multi-arch-images/
https://www.stereolabs.com/docs/docker/building-arm-container-on-x86#setting-up-arm-emulation-on-x86

...if that would be helpful

Perhaps the steps in the bug report can be followed to make sure node-canvas can be built?

https://github.com/Automattic/node-canvas/issues/1662#issuecomment-762566018

https://github.com/Automattic/node-canvas/wiki/Installation%3A-Ubuntu-and-other-Debian-based-systems

https://github.com/Automattic/node-canvas/issues/1662#issuecomment-1465269869

https://github.com/Automattic/node-canvas/issues/1733#issuecomment-761703018

If that doesn't work, you could consider removing the deps that require node-canvas / canvas, it seems like both are not critical and just involving typing (pdfjs-dist) or testing (jest-environment-jsdom).
C:\x>npm ls canvas
<EMAIL_ADDRESS>C:\x
├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>deduped
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>deduped

it seems like both are not critical and just involving typing (pdfjs-dist)

From pdfjs sources, it like a optional dependency: https://github.com/mozilla/pdfjs-dist/blob/5f07d5a4159bb99eee2f6143d1297f03b45bba58/package.json#L16.

Perhaps the steps in the bug report can be followed to make sure node-canvas can be built?

IIRC node-gyp can automatically rebuild a package if libs for your arch/os are not available.
I can check later running daedalOS on Debian if you want.


validation of created data feeds

The data feeds should be written into a temporary file. Then it will be possible to make some validity checks.

file not empty
file header set
amount of fields in first and last record identical
amount of records according to database is identical to amount of rows

If the newly created product, stock and price feeds pass these checks, only then, the following steps should be triggered:

replacing the existing files
if FTP upload is enabled

creation of a new zip file which bundles the three files of a store
upload of the zip file

triggering data import with sub-sequent import calls

@xpoback: Any news regarding this issue? I am looking forward to your answer.

@tuegeb What should be done if any of the validity checks fails, except for writing this into logs?

The resulting temporary CSV and/or ZIP file should be moved to a backup directory and each error message - which will additionally be logged - would show up in the Magento administration area. The following steps in this export/import process would be skipped.
For instance if the CSV file is broken, no new ZIP file will be created and no import trigger will be sent.
Or if the ZIP file creation or upload fails, no import triggers will be sent.

@DennisU
@xpoback
The temp file - tested on Windows - is never renamed, even if it is valid. If the delimiter, enclosure and escape characters are part of a field value, a row is not recognized as valid.

@tuegeb Do we really have customers who run Magento on Windows? I'm just wondering.

@tuegeb Regarding the other issue, in my tests escape characters couldn't make row validation to fail, as well as enclosure character. Delimiter breaks validation when it's not enclosed, but this is correct.
Could you please provide me a specific example, so I would reproduce and fix this problem?

@xpoback:
At least one of my QA environments is using xampp on Windows. Therefore I would like to see a plattform independent implementation. If it isn't possible, the mentioned workaround for Windows would be sufficient.
Regarding the invalid feed: Simply copy and paste the contents of an existing product.csv into the field "Description" of a product inside Magento in order to simulate bad data. The record of the corresponding product will be detected as invalid.

@tuegeb The problem was that the enclosure symbol (") was escaped every time it was written to the file by the default function fputscv so \" became \\". But then the function fgetcsv interpreted it as an escaped slash and a "free" double quote, which broke the field into pieces.
An example, where data written to the file and read from there by basic native functions can be different.
I added a simple replace for that and it appeared to have helped.
Also, the Windows fix has been added, so please, test it.

@xpoback: Thanks, both issues have been solved. However in the following a suggestion:
Maybe the string replacements in https://github.com/Flagbit/Magento-FACTFinder/blob/9a8c75c58bf0bdf18fb2acff23d828ca128aba86/src/app/code/community/FACTFinder/Core/Model/Export/Type/Product.php#L126 should be moved to https://github.com/Flagbit/Magento-FACTFinder/blob/9a8c75c58bf0bdf18fb2acff23d828ca128aba86/src/app/code/community/FACTFinder/Core/Model/File.php#L175.

@tuegeb Yes, you're right. Done.

@tuegeb Would it make sense to make validation optional (in case there are unexpected troubles)?

@xpoback: That's a good idea. However the validation should be enabled per default.
A related export/import issue:
If the module is enabled only for some of the stores (= disabled in the default configuration), the exports (stock, price and product) are made for all stores when using the shell script. When using https://github.com/Flagbit/Magento-FACTFinder/blob/master/src/shell/factfinder.php#L8 the export with validation and the import triggers should only be made for the stores which have FACT-Finder enabled. Could you fix that, please? Many thanks.


npm install fails on fresh git clone

something's conflicting w/ the mv ./lib/* ./ and/or the prepublish script running after you git clone && cd && npm install

fixed w/ c0316042fc02c14bdd228815200ef9b55c38b040


QuickFeed sends invite links

This should not be necessary now that we accept invitations on the user's behalf. Figure out if we can avoid sending these emails/notifications.

It appears there is nothing we can do on our end to disable this. The AddCollaborator endpoint triggers notifications, as mentioned here.
Only users themselves can modify which notifications they wish to receive.


FEAT: Make commands for better user experience

@arnavs . Do not merge this PR at the moment, @mmcky and I will test it and let you know
Make command structure in this PR :-
make setup - installs the dependencies
make jupyter - converts rst to ipynb (unexecuted)
make website - converts rst to website (along with execution and conversion to html)
make website parallel=True - parallel version of make website
make preview - opens the unexecuted notebook folder (_build/jupyter)
make preview lecture=code_blocks - opens the unexecuted lecture (code_blocks.ipynb in this case)
make preview target=website -creates a python server and serves the _build/jupyter_html folder
There is an extra make local command here, which has not been tampered with at present. Should I change it to something like make website env=local or something?
This PR will rework the default settings in the conf.py file to enable make jupyter to focus on building local notebooks. The settings required for build the website will be enabled using override flags from the cmd line built into the make website command.
We have also added separate build pathways. Local editing notebooks will remain in _build. The files used for constructing the website including ipynb, executed, html, _static are all now contained in _build_website. The files used for coverage ipynb, executed-ipynb are in _build_coverage.

Hi guys.
Regarding make local, I like your suggestion @AakashGfude.  In any case, make local should be dropped.
Second, I'm not sure that the structure of the _build directories is logical.  It would be confusing for a user to see _build and _build_website at the same level.  Let's avoid any structure where an intelligent new user would look at it and say "huh??".
I suggest instead one _build folder with directories inside such as jupyter, website, etc.

@jstac indeed - there is no make local on the Julia side as we never set one up so it won't be in this Makefile. @AakashGfude I'll amend your description above to remove confusion.
The main reason we have the separate build folders for now is that the default make clean wipes everything in the _build directory. This is not ideal as the cache is wiped for every different workflow jupyter, website, coverageetc. In this setup we can keep the different channels logically separate (cache preserved). It is also solely determined by settings in theMakefileas our extension will use theBUILDDIR` settings that have been setup in the Makefile to write the folders, so none of these folder structures are hardcoded into the extension.
For those that will just be editing and writing lectures using make jupyter (and don't need to build the website) then they will just have a _build folder.

@mmcky I understand --- but it's confusing for the user and illogical at the same time.
I know I'm driving you guys crazy but I want the tools we build to be beautiful and logical.  So please adopt the convention I requested and adjust the behaviour of make clean to match.
As far as I'm concerned, it's fine for make clean to wipe everything in _build and then for you to add options to further refine it's behaviour (according to what you guys need).

Sounds good, I will wait for your OK before reviewing/merging/etc. And thanks again for all the hard work on this toolchain.
Only request from my side is to keep the docs up to date on common use cases after all changes and tweaks.
I think these are:

Looking at Jupyter output (currently make jupyter and make jupyter-tests.) For unexecuted output, I just hit Ctrl+C when Dask fires up, but maybe there is a better way.

Looking at HTML output.

Looking at coverage statistics/reports.

@arnavs the Ctrl+C will no longer be needed as juypyter will only focus on producing notebooks and not executing them. make website will build the full pipeline ipynb -> exectution -> html. I am working on updated docs now: https://github.com/QuantEcon/sphinxcontrib-jupyter/pull/200.
I would like to go ahead and merge this as I have merged these changes in the quantecon.build.lectures after last nights testing over here. You will need to update the Docker to use make website or make website parallel=True and make coverage or make coverage parallel=True.

Sounds good to me. Merging now.


broken post-via-gmane link

The "post via gmane" link on https://git-scm.com/community points to an unexistent server 'post.gmane.org':   http://post.gmane.org/post.php?group=gmane.comp.version-control.git

Related to https://github.com/git/git-scm.com/pull/827. I think nntp-posting still works after the gmane outage and ownership transfer a few months ago, but it looks like web-posting is dead (the "Posting" link in the navbar of gmane.org is no longer an actual link).
I think we need to figure out the best set of instructions at #827 and get that merged. It looks like there probably isn't a way to post via the web anymore.

this seems not to be applicable since #827 was merged. closing


remove future

we will only keep instances, providers and lazies as injectable kinds.

👍

Coverage decreased (-0.5%) to 77.886% when pulling b8621a5a0a5bdbfa090fa0fcbea5712e5477d410 on sni/remove-future into a8cf869bf2c6c817505130b181b409d0879b9a86 on master.


Upgrade maven dependency dropping versions

Problem
Why were some versions deleted?
Example diff
        <dependency>
           <groupId>org.mockito</groupId>
           <artifactId>mockito-core</artifactId>
-            <version>3.7.7</version>
           <scope>test</scope>
       </dependency>

         <dependency>
           <groupId>org.powermock</groupId>
           <artifactId>powermock-module-junit4</artifactId>
-            <version>2.0.9</version>
           <scope>test</scope>
       </dependency>

         <dependency>
           <groupId>io.jenkins.plugins</groupId>
           <artifactId>plugin-util-api</artifactId>
-            <version>2.0.0</version>
       </dependency>

       <!-- https://mvnrepository.com/artifact/javax.servlet/javax.servlet-api -->

         <dependency>
           <groupId>com.fasterxml.jackson.core</groupId>
           <artifactId>jackson-annotations</artifactId>
-            <version>2.12.0</version>
+            <version>2.12.7</version>
       </dependency>
       <dependency>
           <groupId>com.fasterxml.jackson.core</groupId>
           <artifactId>jackson-databind</artifactId>
-            <version>2.12.0</version>
+            <version>2.12.7</version>
       </dependency>
       <dependency>
           <groupId>io.jenkins.configuration-as-code</groupId>

Recipes in example diff:

org.openrewrite.maven.UpgradeDependencyVersion

References:

Recipe ID: undefined
Recipe Name: "Upgrade Maven dependency version"
Repository: jenkinsci/cloudevents-plugin/main
Created at Wed Sep 14 2022 07:48:49 GMT-0400 (Eastern Daylight Time)

Is this because of RemoveRedundantDependencyVersions? If so, please close.

Yep, those dependencies have managed versions (from the parent).


Wrong interface in Centos72 box gets the vagrant dhcp configuration

This may be a configuration problem on my end, but whenever I try to vagrant up a boxcutter/centos72 box with more than one interface, I get this output:
==> server01: Importing base box 'boxcutter/centos72'...
==> server01: Matching MAC address for NAT networking...
==> server01: Checking if box 'boxcutter/centos72' is up to date...
==> server01: Setting the name of the VM: 1_server01
==> server01: Fixed port collision for 22 => 2222. Now on port 2201.
==> server01: Clearing any previously set network interfaces...
==> server01: Preparing network interfaces based on configuration...
    server01: Adapter 1: nat
    server01: Adapter 2: intnet
    server01: Adapter 3: intnet
    server01: Adapter 4: intnet
==> server01: Forwarding ports...
    server01: 22 (guest) => 2201 (host) (adapter 1)
==> server01: Running 'pre-boot' VM customizations...
==> server01: Booting VM...
==> server01: Waiting for machine to boot. This may take a few minutes...
    server01: SSH address: <IP_ADDRESS>:2201
    server01: SSH username: vagrant
    server01: SSH auth method: private key
    server01: Warning: Remote connection disconnect. Retrying...
    server01: Warning: Remote connection disconnect. Retrying...
    server01: Warning: Remote connection disconnect. Retrying...
Timed out while waiting for the machine to boot. This means that
Vagrant was unable to communicate with the guest machine within
the configured ("config.vm.boot_timeout" value) time period.

If you look above, you should be able to see the error(s) that
Vagrant had when attempting to connect to the machine. These errors
are usually good hints as to what may be wrong.

If you're using a custom box, make sure that networking is properly
working and you're able to connect to the machine. It is a common
problem that networking isn't setup properly in these boxes.
Verify that authentication configurations are also setup properly,
as well.

If the box appears to be booting properly, you may want to increase
the timeout ("config.vm.boot_timeout") value.

My vagrant config is as below:
config.vm.define "server01" do |device|
    device.vm.hostname = "server01"
    device.vm.box = "boxcutter/centos72"

    device.vm.provider "virtualbox" do |v|
      v.name = "#{wbid}_server01"
      v.customize ["modifyvm", :id, '--audiocontroller', 'AC97', '--audio', 'Null']
      v.memory = 512
    end
    device.vm.synced_folder ".", "/vagrant", disabled: true

      # NETWORK INTERFACES
      device.vm.network "private_network", virtualbox__intnet: "#{wbid}_net42", auto_config: false , :mac => "a00000000031"

      device.vm.network "private_network", virtualbox__intnet: "#{wbid}_net2", auto_config: false , :mac => "443839000003"

      device.vm.network "private_network", virtualbox__intnet: "#{wbid}_net13", auto_config: false , :mac => "443839000017"

    device.vm.provider "virtualbox" do |vbox|
      vbox.customize ['modifyvm', :id, '--nicpromisc2', 'allow-all']
      vbox.customize ['modifyvm', :id, '--nicpromisc3', 'allow-all']
      vbox.customize ['modifyvm', :id, '--nicpromisc4', 'allow-all']
   end
  end

When I go in through the console to investigate what's going on, it looks like DHCP is configured by default on the LAST interface Adapter 4 instead of the first Adapter 1 (the default Vagrant NAT interface). The only script in /etc/sysconfig/network-scripts is the device of Adapter 4, even though you can see it's explicitly set as auto-config=False. If I manually activate DHCP on Adapter 1 through the console, everything (such as Vagrant ssh) starts working as would expect.
Does anyone here have any insight?

Found the culprit. It's this line: https://github.com/boxcutter/centos/blob/master/script/cleanup.sh#L43
gwdev=\`nmcli dev | grep ethernet | egrep -v 'unmanaged' | head -n 1 | awk '{print \$1}'\
nmcli dev lists the devices in alphabetical order. These are my adapters and their names:

Adapter 1 (nat): enp0s3
Adapter 2: enp0s8
Adapter 3: enp0s9
Adapter 4: enp0s10

enp0s10 comes before enp0s3 alphabetically, and the script assumes that the correct interface will be listed first. In our scripts, we usually use the output of ip link show and assume that the interface numbered 2: is the correct interface to use for dhcp (interface 1 is the loopback).
ip link show | grep '2: ' | awk '{print substr($2, 1, length($2)-1)}'
Would that be appropriate?

Should be sorted in the new boxes.


Dragging a block sometimes offsets the whole workspace

I can't reproduce this very reliably, but I noticed that sometimes the whole workspace gets offset while you're dragging a block. I've only ever seen this on scratch.mit.edu. I noticed that whenever I open a project, I can almost always repro the whole workspace appearing to be positioned above the backpack, with the flyout extending all the way to the bottom of the entire browser window, i.e. above the backpack.
Operating System and Browser
Firefox 65.0b7, Linux (Debian).
I think this is Firefox-specific, since I can't repro it on Chromium.

@towerofnix can you describe what you mean by "offset?"  A screenshot or gif of the workspace would be helpful.  I can't reproduce, or if I am reproducing I'm not sure what you mean.

@BryceLTaylor I couldn't repro the "offset" behavior per se - it was likely an instance of overflow issue of and related to LLK/scratch-gui#953. Here's a repro video: https://streamable.com/1sqke. I've already made a PR - #1895 - which almost certainly resolves this (it resolves 953).