[cattle-cli] - create-registrationToken

Playing around with ways to get a host registrationToken on demand.
Option 1 - Mimic UI (works)
curl -s -X POST -H x-api-project-id:1a5 http://${api_host}/v1/registrationtoken
Option 2 - Use cattle-cli, but there appears to be no create-registrationToken?

While this isn't a bad idea, you don't need to generate a registration token every time you want to add a host.  They can currently be reused and are good for a year.
If you have access control off or are copying the way the UI does things, the root level of the api (/v1) is scoped to a user, and users do not have registration tokens.  They can pretty much just manage projects.  and a few other things.  When you use an API key for a project it is automatically scoped to that project.  So if access control is off, give cattle-cli the URL to a specific project, as found in the API & Keys screen in the UI. e.g.  http://${api_host}/v1/projects/1a5.
cattle --format=json --url http://a.b.c.d:8080/v1/projects/1a5 create-registrationToken
Note that almost everything is created asynchronously, including registrationTokens.  So what you get back will be in state "registering" and not actually have the string you want yet.  You'll have to get the id out of it and request it again a second later.

@vincent99 Thanks for the explanation, it's insightful.
 Maybe I need to config something or there is an auth issue.
Been using the snippet below to register hosts from bash land. Sounds like for this to work more consistently I'd need to sleep or handle an event?
curl -s -X POST -H x-api-project-id:1a5 http://${api_host}/v1/registrationtoken | \         jq .links.self | \             xargs curl -s | \                 jq -r .command
Also curious from a CLI perspective, is the intended usage?
cattle --format=json --url http://<IP_ADDRESS>:8080/v1/projects/1a5 create-registrationToken
cattle --url http://<IP_ADDRESS>:8080/v1/projects/1a5 registrationToken-create --id {id} BLOCKS UNTIL CREATED
cattle --format=json --url http://<IP_ADDRESS>:8080/v1/projects/1a5 list-registrationToken --id {id}

Yes, the timing is working out that the state is active and the command is there by the time the 2nd curl runs but this is not guaranteed.
Frankly we use this primarily as a python client for validation tests, I don't think any of us really use it as a CLI ourselves.  It could obviously use some attention in that regard.
There is no "block until create" There exists a wait_success method in the client but there is not a flag to trigger that in the CLI.  It should probably be on by default even.
create-registrationToken vs registrationToken-create are interchangeable; the format doesn't matter either, other than the default is easier to read and JSON easier to parse.  I'm not sure why it doesn't think registrationToken is valid, are you sure you have the current version?
Today you should be able to do:
id=$(cattle --format json --url http://${host}/v1/projects/${projectId} create-registrationToken | jq -r .id)
command=$(cattle --format json --url http://${host}/v1/projects/${projectId} list-registrationToken --id $id | jq -r .command)

If we added a e.g. --wait-for-it flag then it would be just:
cattle --wait-for-it --format json --url http://${host}/v1/projects/${projectId} create-registrationToken | jq -r .command

because it would return the newest version of the resource.

Maybe, thought I had the latest. Running rancher/server:latest and cattle-cli from pip.
Rancher v0.25.0
Cattle	v0.58.0
User Interface	v0.29.0
Rancher Compose	latest
Ya default/optional --wait-for-it would be

Definitely a useful way to wrangle.

Closing given no activity.


Typing Examples

Proposal
Hey there, do we want to use type hints in rows for types?
Example:
from upstash_qstash import Client
from qstash_tokens import QSTASH_TOKEN
from upstash_qstash.schedules import CreateScheduleRequest

client = Client(QSTASH_TOKEN)
schedules = client.schedules()

params: CreateScheduleRequest = {
            "cron": "* * * * *",
            "destination": "https://py-qstash-testing.requestcatcher.com",
            "body": {"hello": "world"},
            "headers": {
                "content-type": "application/json",  # This is the default, but you can override it
            },
        }
res = schedules.create(params)

So, by doing that params: CreateScheduleRequest we can give a really good experience to the user and he can make sure is passing the right params to the method.
Also, he can have a quick check with the VSCode autocomplete feature.

And see if some key is optional or required as well.

If we want to do it, I can work on that 😄

What would this change from the existing request dictionary?
https://github.com/upstash/qstash-python/blob/80a1f2ff2ddea7f421fd1870f36c683de94ae1ee/upstash_qstash/schedules.py#L25

mypy
it would be nice to have all sorts of checkers in mypy
mypy.ini
[mypy]
; Ensure full coverage
disallow_untyped_calls = True
disallow_untyped_defs = True
disallow_incomplete_defs = True
disallow_untyped_decorators = True
check_untyped_defs = True

; Restrict dynamic typing
disallow_any_generics = True
disallow_subclassing_any = True
warn_return_any = True

; Know exactly what you're doing
warn_redundant_casts = True
warn_unused_ignores = True
warn_unused_configs = True
warn_unreachable = True
show_error_codes = True

; Explicit is better than implicit
no_implicit_optional = True

with that, we are going to have ~168 issues.
but definitely, it can be done progressively, incrementing each checker at a time

adding:
fixing all these types of issues we can mark the package as "typed" using the py. typed file to follow PEP-561 to allow MyPy to check the package as a third part in other projects.


Is this library still maintained?

I'd really love to be able to do more in-depth monitoring and debugging of some redux-saga stuff for work, and I want to use this plugin & system to do it.
But when I try to import {ReduxSagaEmitter} from 'kuker-emitters';
I get an error

and this error on the emitter.setStore(store)

And this console error when I try to have the application running:

Hey @BrianD91, I'll try finding some time this weekend to fix this.


permission to show in project catalogue

As a contributor, I need to indicate that I agree to the project level metadata being made public in the project catalogue prior to data release in the archives/DCP.
Tasks:

[ ] Show this in the UI

@gabsie do we have a logical point where we would put this? At the save point on the project metadata?

Hi, Claire - yes, just today was thinking about this, I would put it on the final screen at this point for project info

something like -

Is there a plan to make this default yes? a default no will be frequently missed

good plan

set default flag as yes if spreadsheet is uploaded

closing as this is a duplicate of 284


Added next and back buttons on questions view in quiz

https://github.com/ita-social-projects/SpaceToStudy-Client/assets/121502737/0ca4e35a-ecd3-4233-bcc6-70b329d04184
Tests:

Issue: #1312

Is it ok that there is no "Back" button on the first question at all, and on the last question "Next" is disabled? It seems a bit inconsistent to me.
Maybe we should either disable both cases or just not render at all?

Is it ok that there is no "Back" button on the first question at all, and on the last question "Next" is disabled? It seems a bit inconsistent to me.
Maybe we should either disable both cases or just not render at all?
UPD: Not relevant, question decided with the designer

I agree, we should discuss it


Can inducer be deleted?

Do this file do anything? If not, can we remove it?
https://github.com/fortytw0/needfinder/blob/main/src/inducer.py

Yes it can be deleted. I will push the changes!


Update hololens2-enterprise-troubleshooting.md

Minor text edits.

These edits are still useful, and will improve this file in the public repo.

Changes made, all checks passed, attempting to merge.

Last commit 9/13/21, "Improved Windows 10 note", made on line 163. "Note that these articles are based on Windows 10 Desktop, and not all information may apply to HoloLens."


[ASCII-1078] Remove redundant scrubbing in log package

What does this PR do?

Remove superfluous scrubbing in log package.
Motivation

Reduce memory allocations and CPU use when logging.
Additional Notes

Remove scrubbing in Log, logWithError, logContext, and logContextWithError, as these function each call a method of loggerPointer, which all scrub already.
Also took the chance to unexport the Log function (which is not used outside of the package) to align with other similar functions (logWithError, logContext, etc).
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Only functional change is removing scrubbing, and the unit tests added check that we still scrub (exactly) once both in exported functions of the package, and methods of loggerPointer.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


US25: After clicking accept, the invited friend is redirected to the hosts lobby.

See user story for explanation.


Attached the Color Sensor Plugin

UPDATE 1

Attached the previously created Color Sensor plugin to the Create model

HOW IT WORKS
It responds by sending an Bool message to the topic related to the specified camera, for example, the left sensor publishes in the topic "left_yellow_sensor".
ISSUES

Only works when a there is a subscription in the "image_raw" topic of every camera.

@eborghi10 @ernestmc @serraramiro1 @LucasJSch

Some things @stevendes:

Was the issue with alwaysOn fixed?
try2 is your target branch? Consider using better names.
You have conflicts.

Some things @stevendes:
1. Was the issue with `alwaysOn` fixed?

2. `try2` is your target branch? Consider using better names.

3. You have conflicts.

Hello Emi
1- The issue wasn't fixed yet, all the things that I tried didn't work out
2- Yes haha, you already pointed me that out when I used that branch for the PR, but because this is that same branch, has the same name since I didn't closed that PR and opened a new one, and I used better name to my branches since then
3- I would check it and then tag everyone again

Was the issue with alwaysOn fixed?

1- The issue wasn't fixed yet, all the things that I tried didn't work out

@serraramiro1 (Tag Lucas too because I can't), could you check if you find out what's going on?

I have an error when I try to compile your branch:
In file included from /opt/ros/kinetic/include/ros/serialization.h:37:0,
                 from /opt/ros/kinetic/include/ros/publisher.h:34,
                 from /opt/ros/kinetic/include/ros/node_handle.h:32,
                 from /opt/ros/kinetic/include/ros/ros.h:45,
                 from /create_ws/src/create_autonomy/ca_gazebo/src/color_sensor_plugin.cpp:2:
/opt/ros/kinetic/include/ros/message_traits.h: In instantiation of ‘static const char* ros::message_traits::MD5Sum<M>::value(const M&) [with M = bool]’:
/opt/ros/kinetic/include/ros/message_traits.h:255:102:   required from ‘const char* ros::message_traits::md5sum(const M&) [with M = bool]’
/opt/ros/kinetic/include/ros/publisher.h:112:7:   required from ‘void ros::Publisher::publish(const M&) const [with M = bool]’
/create_ws/src/create_autonomy/ca_gazebo/src/color_sensor_plugin.cpp:123:41:   required from here
/opt/ros/kinetic/include/ros/message_traits.h:126:34: error: request for member ‘__getMD5Sum’ in ‘m’, which is of non-class type ‘const bool’
     return m.__getMD5Sum().c_str();
                                  ^
/opt/ros/kinetic/include/ros/message_traits.h: In instantiation of ‘static const char* ros::message_traits::DataType<M>::value(const M&) [with M = bool]’:
/opt/ros/kinetic/include/ros/message_traits.h:264:104:   required from ‘const char* ros::message_traits::datatype(const M&) [with M = bool]’
/opt/ros/kinetic/include/ros/publisher.h:112:7:   required from ‘void ros::Publisher::publish(const M&) const [with M = bool]’
/create_ws/src/create_autonomy/ca_gazebo/src/color_sensor_plugin.cpp:123:41:   required from here
/opt/ros/kinetic/include/ros/message_traits.h:143:36: error: request for member ‘__getDataType’ in ‘m’, which is of non-class type ‘const bool’
     return m.__getDataType().c_str();
                                    ^
create_autonomy/ca_gazebo/CMakeFiles/color_sensor_plugin.dir/build.make:62: recipe for target 'create_autonomy/ca_gazebo/CMakeFiles/color_sensor_plugin.dir/src/color_sensor_plugin.cpp.o' failed
make[2]: *** [create_autonomy/ca_gazebo/CMakeFiles/color_sensor_plugin.dir/src/color_sensor_plugin.cpp.o] Error 1
CMakeFiles/Makefile2:5478: recipe for target 'create_autonomy/ca_gazebo/CMakeFiles/color_sensor_plugin.dir/all' failed
make[1]: *** [create_autonomy/ca_gazebo/CMakeFiles/color_sensor_plugin.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
Invoking "make -j8 -l8" failed

Some things to improve here:

You didn't address most of my comments.
You have to improve a lot the tabulations and empty lines.

Param xml is <param command="$(find xacro)/xacro --inorder $(arg model) $(arg xacro_args)" name="robot_description"/>
The traceback for the exception was written to the log file

@eborghi10 I still didn't push the file with the addressed commits, the ones that are open hasn't been addressed yet, I don't have errors locally so maybe they are because the last commit is only to resolve the conflicts that were present, I would push it now and please let me know if the error is still present.

I wasn't able to test your code. What should I do? Which topics should I look at?

You have conflicts with the base branch.

@eborghi10 addressed most of the comments, the issue with the activation is still present but I'm moving forward with the actionlib task, then I would return to this and try to solve it again

Addressed all the comments


[VS Code] [Audio] cannot stop call in Disconnected state

%0A%0A%23%23 Error:%0Acannot stop call in Disconnected state%0A%0A%23%23 Steps to Reproduce:%0A1.%0A2.%0A%0A||Version Data|%0A|-:|:-|%0A|**extensionName**|VSLS-Audio|%0A|**extensionVersion**|0.1.50|%0A|**applicationName**|VSCode|%0A|**applicationVersion**|1.34.0|%0A|**platformName**|MacOS|%0A|**platformVersion**|10.0.17763|

@LeandroHaraoka Can you upload the liveshare logs, you can get them by running "Liveshare: Export logs" from vscode command palette.

@LeandroHaraoka: Thanks for reporting this issue!  We have made some significant updates to our audio extension with the latest release (0.1.60). I'm going to close this issue but if you're still experiencing problems with the latest extension,  can you tell me more about what you were doing when you encounter the issue? It would also be helpful for our investigation if you uploaded your logs here. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.


Adding ngrok Gateway API Implementation to Implementations page

What type of PR is this?

/kind documentation
What this PR does / why we need it:
ngrok has created a Gateway API implementation. This is an entry for the implementations page listing it and providing additional information.
Which issue(s) this PR fixes:

Fixes #2842
Does this PR introduce a user-facing change?:

NONE

Hi @salilsub, having ngrok grow Gateway API support sounds awesome, but we'll need you to do the CNCF CLA to accept the PR, sorry.
Also, in the links, the quickstart link for Gateway API currently points to an overview page for the Ngrok Ingress Controller, and I couldn't see any examples or instructions for Gateway API. Any chance those could be added?
I'd also encourage you to look into running the conformance test suite against your implementation and telling us if there's anything amiss.

Hi @youngnick, I'm working through the CLA stuff right now (just filed with easyCLA)
With respect to the links, we're in the middle of re-working some of our docs and the link provided is instead going to be for a more general "Using ngrok and k8s" page. The repo will still be the same (our ingress controller and Gateway API implementation are in the same repo). I decided to open this PR since we are close to Kubecon Europe and I didn't know what kind of turnaround there would be on PR reviews
We are also working on the conformance testing/reports. I don't have the results on that right now but once I get them, I can add it in.

@shaneutt based on your above comments, there are two open questions, naming and docs/links
Naming of the repo
We originally supported only an ingress controller, but we have built our Gateway API implementation within the existing repo since there is a lot of overlap in the code. We're going to rename the repo, but we want to make sure we don't break anything anywhere before we do that rename. We know links from docs to the repo should redirect but we're not sure about some other things and want to verify before renaming. My plan was to submit a second PR to update the link to the repo once we did that.
Docs/Links
We also have a docs PR (https://github.com/ngrok/ngrok-docs/pull/639) that I am currently updating. The plan is to merge tomorrow in advance of Kubecon. This has information about Gateway API and the page in the links for this PR should be the same because we are providing a single page describing both the existing ingress controller and Gateway API implementation with options to select which one they want to use.

Gotcha, so should we wait for some of this other work to complete? Or what are your hopes/expectations here?

@shaneutt I would prefer if we merge the changes in this PR now since the only open item is the repo rename, the docs changes were merged yesterday. Once we rename the repo, all the links should redirect until I can submit another PR in the future.

@youngnick wanted to follow up on this.

Thanks for the ping, @salilsub, this LGTM now.
/lgtm


Update s3, sdk-core, sqs to 2.17.127

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.121 to 2.17.127.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #423.


Graphsage demo in StellarML Library

Description
Currently StellarML Library has some base classes. We have working Graphsage code from Kevin. We should implement a demo using the classes from StellarML, moving code to this style as required.
Done Checklist (Development)

[ ] Assumptions of the user story met
[ ] Produced code for required functionality
[ ] Branch and Pull Request build on CI
[ ] Branch and Pull Request pass unit tests on CI
[ ] Branch and Pull Request pass integration tests on CI
[ ] Version number reflects new status
[ ] Peer Code Review Performed
[ ] Code well commented
[ ] Documentation on Google Docs
[ ] Documentation in repo
[ ] Team demo
[ ] Mini-meetup talk
[ ] Stakeholder sign-off

Done Checklist (Research)

[ ] Code Review
[ ] Documentation on Google Docs
[ ] Documentation in repo
[ ] Team talk
[ ] Mini-meetup talk

Done Checklist (Bug)

[ ] Bug fixed
[ ] Branch and Pull Request build on CI
[ ] Branch and Pull Request pass unit tests on CI
[ ] Branch and Pull Request pass integration tests on CI
[ ] Version number reflects new status
[ ] Peer Code Review Performed
[ ] Code well commented

This has been completed with a node classification example (CORA) and a link prediction example (also CORA).


Nothing shown (white page) if JS is disabled

Nothing shown (white page) if JS is disabled
Issue Type

[ ] Feature: Display a simple message in the demo telling that If you're seeing this message, that means JavaScript has been disabled on your browser, please enable JS to make this app work.

Description
I ran into this issue because I use the options "disable javascript" when the console is opened. So, everything went fine at the start, because my console wasn't opened, but later then I got a white page and couldn't figure out why; that's because I had opened the console since.
I don't really know where is the best place to add such a message, but no doubt it may come handy for other developers. And maybe for users as well.

As react-boilerplate is a Javascript heavy app (it even has React in the name) it should be obvious that JS must be enabled. What may not be obvious, especially to the end user, is that JS is disabled in a particular browser, as in your case above.
I have not tried this, but I expect that adding a <noscript> tag to index.html and its template would be the place to notify end users that JS is disabled and must be enabled to run the app.
If you are able to make this work with a clean and simple <noscript> tag, please consider opening a PR for that. It's a nice touch that could save a support call or two in production.

@gihrig It works indeed using .   I should make it to the dev branch, right?
https://github.com/Vadorequest/react-boilerplate/commit/3fef0d5240f52636ff708e0be79c00c591c6de5b
I also fixed some indentation on the template, I don't know if that's something that should be part of the PR but it makes sense to me.

I should make it to the dev branch, right?

You got that right.

I also fixed some indentation on the template

Yes, that's fine.
More at #1075

Closing, handled in #1075


Add support for reneging

This includes adding docs for it in the Wiki

This should be enforced in single player, and a configurable option in multiplayer - i.e. there's no point in disabling it when playing against the AI, because they won't renege anyway due to card selection logic

As of https://github.com/worhello/TwentyFiveWeb/commit/d1638f1a9610b597da9127ff7a993fc239a03ff8 - reneging has been disabled in single player games. It can be allowed implicitly in multiplayer games with a little extra work to disable checking. However, this would also require a "call out" mechanism, which would be a lower priority multiplayer only feature

Documentation has been added in the wiki for reneging


Cron error: file not found

I made a cron like the example in the docs, but then for the birthdays, like this:
10 0 * * * "GET https://domain.com/asset/cron/24h/Birthday/?secret_word=xxxxxxxxxxxx"
So it should run every night at 00.10 hours.
But now I got an e-mail stating:
/bin/sh: GET https://domain.com/asset/cron/24h/Birthday/?secret_word=xxxxxxxxx: No such file or directory
I do meet the requirements as far as I could see and curl is present on the server, but the GET command is not. I guess. When I use GET in SSH it says:

-bash: get: command not found

Am I missing something or doing something wrong here?

FYI: I tried it like this too:
curl --request GET "https://domain.com/asset/cron/24h/Birthday/?secret_word=xxxxxxxxx"
This looks like the cronjob will work, but then I get another email:
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   352  100   352    0     0   9263      0 --:--:-- --:--:-- --:--:--  9263
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>403 Forbidden</title>

Forbidden

You don't have permission to access /asset/cron/24h/Birthday/
on this server.

Additionally, a 403 Forbidden
error was encountered while trying to use an ErrorDocument to handle the request.

So something is going wrong there.

@BlackTiger63
Hi,
I'm not sure what system the examples are made for but cron job are called like any other command so you use "/usr/bin/curl" or wherever the command is on your host.

@BlackTiger63
Also remove the ending / after birthday for 24h/birthday?secret=xxx
And the problem is gone.
Please make a nice comment on sourceforge and star our repo.
Thanks

I'm not sure what system the examples are
??? Why not? They are from the pH7 docs like I stated.
https://ph7cms.com/doc/en/cron
You can also see that just GET is called in the cron example and not /usr/bin/curl GET or something like that. I already wondered about this.

But where do the apostrophe come then?
Will it be /usr/bin/curl --request GET "domain.com etc." or "/usr/bin/curl --request GET domain.com etc" or without the --request?
I know a trailing / requests a directory but the trailing slash was stated in the example here:
https://ph7cms.com/doc/en/cron-list
So I did not make a typo according to the doc, if the trailing slash should not be there, both the doc's contain several (same) typo's.:)
I would like to leave stars and a nice comment, but I suggest the docs are fixed decently first, because otherwise users will keep making these mistakes.
Ok tried again without the trailing slash as you suggested like this:
/usr/bin/curl GET "https://domain.com/asset/cron/24h/Birthday?secret_word=xxxxxxxxxx"
and got the same error as I did before:
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: GET

100   351  100   351    0     0  13000      0 --:--:-- --:--:-- --:--:-- 13000
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>403 Forbidden</title>

Forbidden

You don't have permission to access /asset/cron/24h/Birthday
on this server.

Additionally, a 403 Forbidden
error was encountered while trying to use an ErrorDocument to handle the request.

I'm using Centos 6.10 and curl and everything is present.
So I'm still wondering what's wrong as I have done it correctly now.

@BlackTiger63
First thing, I'm not the one who wrote the docs.
I help out concerning the CMS but I don't train people in the use of Unix system.
Ever tried "man crontab" or "man cronjob" ?
Because as far as I'm concerned the docs are ok  because we had many user install our software and none complained. Maybe you need to do a little work on your side too.
Do a "man 5 crontab" and you'll see how to format a cron file.
We state that the cronjob should request the following and we believe that system administrator know the use of vixie cron, curl and other infrastructure.
Have you tried "man curl"?
If you did, you would have had your answer. Remove the word "GET" as it's not needed. We write "GET" in the docs because you need to do a get request.
so /usr/bin/curl -g https://lonely.com/asset/cron/24h/birthday?secret=yoursecret  .
And because you don't want to get shell expansion on your string, you put address between " http://......?secret=yoursecret".
Am I wrong or you're the same dude who was saying there's a error because in the way we wrote /asset/24h... But you didn't understand the difference between the file - folder and URL ?
Anyway you got enough to get going with that.
 Didn't that gave you the idea to remove GET ? You already got your solution.

@polynamaude I'm sorry.
Since you wrote "our repo" I though you were writer or co-writer.

Didn't that gave you the idea to remove GET ? You already got your solution.

No I did not look at my output, I went for an icecream. OMG!
Try reading my reply's. Didn't I try /usr/bin/curl --request GET instead? Which worked but gave also an error output? Right! So it wasn't my solution as you think.
Your line is by the way faulty. It should not be /usr/bin/curl -g but should be /usr/bin/curl -G with capital, so you might try man curl yourself because -g is globoff and -G is get. :)
Beside that, what I used before /usr/bin/curl --request GET "ht...." is also a correct way. Which gives exactly the same error as your "correct" line.

We write "GET" in the docs because you need to do a get request.

We? You just told you did not write anything.
Sorry but that's no way to write an example. Most users do have 0 knowledge and copy/paste these examples. One can't expect them to know about crons, and curl etc.
Same for putting things between " signs which is also not done in a real example if it should not be used. And I don't think the writer really intended it as you say/think.
It would be like expecting windows users to know their way around the command prompt.
So I really wonder with how many users the cron won't even work. I doubt that almost nobody would use copy and paste commands to put the examples in to cron, that would be a first.
Yes I was the same dude that wrote that about /assets/24h. And I was correct, that was a doc mistake too.  But I can also overlook some things, like you did with your curl command (see below).
I really like this is free, but please don't piss me off by blaming me for making DOC stated faulty statements and wrong examples. I'm just pointing them out.
Unless you are on of those who don't see a benefit in improving docs and examples.
I'm not even doing this for myself but to help a friend which got stuck on a too old version.
So let's start a decent way again I hope... I tried like you said in the cron:
/usr/bin/curl -G https://domain.com/asset/cron/24h/Birthday?secret_word=xxxxxxxx
even tried your exact example with -g.
Without any " or GET statement.
And the same error occurs both times, so who's wondering now?
So no solution!
Now you got yourself something to think about.
If you want to be of help, please stop the irritating comments, you make mistakes too.
And my reply's will be a lot shorter! :)

Just to be sure everybody's on the right track... this is still the error output:
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   351  100   351    0     0  11322      0 --:--:-- --:--:-- --:--:-- 11322
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>403 Forbidden</title>

Forbidden

You don't have permission to access /asset/cron/24h/Birthday
on this server.

Additionally, a 403 Forbidden
error was encountered while trying to use an ErrorDocument to handle the request.

So nothing about wrong curl or get or whatever commands. Same error as in my "curl --request GET" command I tried before.

@BlackTiger63
I'm the kind of person who think that it's not because you install a software that you got what it take to use it.
By the way, if there was an error in the doc then it was only a "core" missing.
Have you used the supplied htaccess file ?
Also, what did you try other than ask for help ?
Anyway ! Good luck... I'm not here to get into arguments. You seem lot more to enjoy the "I get free your work" than to respect people who try to help you or did put hours of work for stuff you enjoy.
If you'd take a deep breath you'd understand that I only said take time to review yourself.
Sorry but I'm into opensource development for the last 15 years and saw too many newbie that just like the "free" but don't understand more than that. As such that you'll be needing to do some diagnostic on your own and learn. Maybe you should complain to Linus Torvalds about some incomplete man page.

@BlackTiger63
For your info, if I ask what you tried it's to get a picture of what's possibly wrong and not ask you to do the same.
Also it's not a support forum and if we do help out. It's because we're kind to do so. As the name imply "issue" it's for problem in the system. One person in a hundred who get a specific bug that we can't reproduce ain't something we can fix.
So either give us all the information needed so we can get a virtual machine or better provide it to us. And show we got a bug.
Or do like I would.... Learn about Apache configuration. And other stuff too !
Have you checked your logs? What do they say ?
You don't seem to get it that it's not a out of the box solution. Let me bet that you used Unix only since you started playing around with hosting.
If you don't like my answer then don't worry you'll get worst if you do such or developer mailing list.
RTFM

@BlackTiger63 Reading back what you wrote... I'm sorry but if you're a Windows user expecting plain "copy paste" - "point click" then you won't get much from this software.
Also when you make a software to be used by system administrator then you can presume that they know what vixie from, crontab, Apache configuration, some CSS/HTML/php and more. If we didn't use "" in the docs it's probably because as I already said. It's a example and there's many cron system, vixie like on CentOS is just one of them.
I'm not going to pass hours teaching you about administration. If you have a precise question and can take that you're not entitled to getting answered but may get help by kind person then you may try to ask. But try stuff before and not just "why does click click click click copy paste click click" don't work.

Yes free software has incomplete documentation and is a bit more complex. That's why you can pay to get help or get a chance to learn by trying stuff.

@BlackTiger63 Like you said if you can't get your way with command prompt then wake up, you're using Unix/Linux now.

Hi @BlackTiger63
You second cron config is correct (https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/233#issuecomment-404339835).
Your problem looks similar to https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/182
.htaccess might block the user-agent "curl".
Try to remove https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/master/.htaccess#L176 in the root .htaccess
Or, if this still doesn't work, please check if mod_security/mod_security2 is enable (if so, please disable it; you can ask your web host for this).
Finally, @BlackTiger63 please let us know if this work. Thanks in advance!

@BlackTiger63 You can add a useragent option to curl and choose one of the "allowed" user agent per .htaccess file. This should give you a hint if your getting blocked because of User-Agent.
Like pH said, look for modsecurity that is often a standard on shared hosting. It cause lot of problems when we need to do debugging. Your logs should give you hints.

@pH-7 Thanks for diving in. I kind of loose a bit of myself when I'm in front of this type of situation. I totally forgot about the 403 sent when called too often.
I don't remember if modsecurity mark it's blocking in the log or if they are just like the rest of 403?
Hope you're getting a good Sumner time. I'm getting out to the countryside tonight and until Sunday, much needed !

That's great @polynamaude Have a great time then, and enjoy the sunshines! Mine is good too ;) Thanks!

@BlackTiger63 Yes, it seems working well now. To make sure, you can even run again the cron in your Web browser. Go to https://domain.com/asset/cron/24h/Birthday/?secret_word=xxxxxxxxx URL and you should see an error message saying that the cron has already been ran within the last 24 hours...
This means it has been ran successfully :smiley:
Thanks for the suggestion! I will take a look. Don't forget to Star the Github repo if you don't mind ;)

Thank you pH-7.
In the browser I tried that already yesterday and that was working fine, hence me wondering why the cron did not. But that's logic if only curl is blocked.
Due to your help I'm going to have a look how I can star the repo!
Thanks for your help!

You're very welcome @BlackTiger63 Have a great day!

@pH-7 Doesn't a message get sent beside the 403? Like "already gunned"? I was looking for such.
@BlackTiger63 you can add -A TigerAgent or something alike to bypass the curl blockade.
 Happy you got a laughter, maybe the only one in your life of complaints !

@polynamaude I was looking for errors too but strangely enough, it only said cron changed and executed:
Jul 11 16:52:16 server18 /usr/bin/crontab[32036]: (root) REPLACE (user)
Jul 11 16:53:01 server18 crond[4474]: (tend21) RELOAD (/var/spool/cron/user

Thank you for the user-agent tip, but I just leave curl out there.
About the Windows user knowing command prompt, read again, it was an example that you can't expect Windows users to know command prompt. Which is the same as expecting users using your script (which also a lot of windows users with hosting accounts will do) knowing curl, cron and httpd get commands. That was what I was referring too.
And I don't have a life of complaints. I think that if you think these were all complaints, it says more over you then over me. My life is mostly fun.
Have a nice day at the beach! (or are you already back again?).

@BlackTiger63  For your information, the world ain't a unique timezone so maybe I'm not in yours ;-)

@polynamaude LoL. FYI, you said yourself 3 ours ago you would now leave for the countryside (indeed not the beach) until Sunday.
So it's quite logic that I was amazed you're still here. And that has nothing to do with timezones. :-)

Ah it's not tonight at your place yet... oke. :-)


ToInt filter doesn't transform NULL to 0

Using zend input filter I find a bug in a case when I don't send data key to the filter,
but still want to transform/filter data value.
So, it should be filtered from NULL to 0
I suppose this part of the code should skip: array, object and resource
// is_scalar() does not consider NULL to be scalar
if (! is_scalar($value)) {
    return $value;
}

But unfortunately it skiped NULL value also.
Source: https://github.com/zendframework/zend-filter/blob/master/src/ToInt.php#L26

@tasmaniski

So, it should be filtered from NULL to 0

Sorry, this is wrong, because:

0 is concrete value
null represents no value

So it works like described:

Zend\Filter\ToInt allows you to transform a scalar value into an integer.

https://docs.zendframework.com/zend-filter/standard-filters/#toint


Used Library g2o installation

Needed some guidance on the used libraries. It mentions g2o, how do i install it? I have Ubuntu 22 and ros2 humble installed.

You can install g2o using the rosdep install command mentioned in the readme.md

Due to inactivity, I'm closing this issue. If there are still concerns, please open a new issue. Thank you.


Maya: Define preffered Qt bindings for Qt.py and qtpy

Brief description
Added preffered qt bindings in maya envs for Qt.py and qtpy python modules.
Testing notes:

Install of Maya host should not shout about invalid qt binding

there is still something wrong happening with Qt

Should be fixed now.


search breaks when you search just the letter "d"??

It no longer breaks.   There are certain weird course codes, like MECE 451 that don't work with the toString builder. For these, I'm just sending with with the term (the normal course code)


Disable implicit Sendable diagnostics via -strict-concurrency=off.

When -strict-concurrency=off is provided, disable the diagnostics about missing Sendable conformances for implicitly-non-Sendable and non-nominal types. This emulates the behavior of Swift 5.5 and Swift 5.6, albeit under control of a compiler flag.

@swift-ci please smoke test

@swift-ci please smoke test


Publish fix for "Callback fired 6 times" to npm

Hello,
We have an issue related to #2. Version 1.0.3 seems to fix this issue but it's not available on npm. Any chance you can publish the release to npm? Thanks in advance :)

Hi @natlus thanks for pointing that out, apparently the release that fixed it, did not have the proper version in the package.json file so it was not pushed to npm, and the next commit updated the version, but did not have a release here in github ... the npm release process is such a mess...
Anyway @ginovski I don't have write access to the repo any longer, but this can be mitigated by simply doing a "bump" commit for version 1.0.4 and a corresponding github release.

@ivank @ginovski Did this ever make its way to NPM?

Still not fixed!


Setup feature

Description:
This pull request sets up the initial environment and tools required for developing the Math Magicians application. The focus of this pull request is on configuring the development environment and ensuring a smooth setup process for future development.

Hi @axcell-0
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a descriptive & professional  readme  and linters properly  setup 👍🏿
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


[Bug Report] Can’t queue by song name

Describe the bug
I can’t queue a song by name. Using a URL works fine.
To Reproduce
Steps to reproduce the behavior:

Host the bot.
Run !play [song name]

Expected behavior
The bot will attempt to load the song and return “not found”
Screenshots

Debug Info
System Properties:
java.version = 14.0.1
java.vm.name = Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.version = 14
java.runtime.name = Java(TM) SE Runtime Environment
java.runtime.version = 14.0.1+7
java.specification.version = 14
os.arch = amd64
os.name = Windows 10
JMusicBot Information:
Version = 0.2.9
Owner =<PHONE_NUMBER>36287755
Prefix = !
AltPrefix = @mention
MaxSeconds = 0
NPImages = false
SongInStatus = true
StayInChannel = false
UseEval = true
UpdateAlerts = true
Dependency Information:
JDA Version = 3.8.3_464
JDA-Utilities Version = 2.1.5
Lavaplayer Version = 1.3.49
Runtime Information:
Total Memory = 49
Used Memory = 23
Discord Information:
ID =<PHONE_NUMBER>03915806
Guilds = 1
Users = 12
Additional context
Running multiple JDA bots on this machine.

Duplicate of #443


yara-python rule save like functionality

Hi, I was using the rule save functionality in order to merge multiple yara rules in a single file.
Something like:
def merge_rule(rules, outputfile):
    rules_file = {
        rule['name']: rule['path']
        for rule in rules
        if Path(rule['path']).exists()
    }
    rules = yara.compile(filepaths=rules_file)
    rules.save(outputfile)

I was looking for something similar in yara-x but the only save related functionality is the rule serialize_info function but the generated file is different for the old save one.
Will the save option be added to rule? There is another way to obtain same functionality?

serialize_into is the way for saving compiled rules to a file, the file format is different from the one used in yara. You can't load a file generated by yara with yara-x or viceversa.

Ok, that's what I thought.
My workflow is to generate a single yara rule to be used in volatility3 for some plugins (eg. yarascan).
So for now I cannot replace rule generation because it's not compatible, but I'll try to add support for serialized yara-x rule there.

Sorry to add other question to this closed topic but not sure if this requires a dedicated ones.
In yara-python the matched object had also a matched_data attribute with the string value that matched in addition to the identifier. Now that seems to be not available anymore so I'm obtaining it slicing data using offset and length. It's this correct?


[ENG-6011] Link My Preprints on nav bar to new page

Ticket:[ ENG-6011](https://openscience.atlassian.net/browse/ENG-6011)
Feature flag: n/a

Purpose
Link 'My Preprints' on navbar to new page
Summary of Changes
Change the link of the My Preprints button on the preprints navbar to link to the new My Preprints page.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.701%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
6474

Relevant Lines:
9795

💛  - Coveralls


Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code.

Check that this is really a bug

[X] I confirm

Reproduction link
undefined
Bug description

Move data fetching code or side effects to componentDidUpdate.
If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://reactjs.org/link/derived-state

Please update the following components: DayColumn
This error appears in console when using Next.js 12 with  reactStrictMode: true.
Expected Behavior
No response
Actual Behavior
No response
react-big-calendar version
1.5.0
React version
17.0.2
Platform/Target and Browser Versions
Chrome, Safari
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

@marakos Any thoughts on this

@bostonmacosx The Documentation explains exactly how Big Calendar deals with Dates

@cutterbl yes however....if the month view loads fine then the weeks and or day view crash that is a bug not a data issue. There should be consistency in the way that the app handles dates....not one way for the inital load then another way just because you went from month to day view.

No, it is a data issue, dealing with internal data conversions once you switch from the view. Big Calendar currently uses true JS Date objects for all dates. This is something we are possibly changing in the next major release, but this is the way it was originally built and how it currently works.

@cutterbl  well We'll have agree to disagree....
If the initial view can handle the data there is the reasonable expectation that other views can handle it as well. i find it odd that the process to interpret the date in the initial view differs than the changing of the view....as a coder myself I would consider that an inconsistency....if it was a data issue then 0 of the views would be able to handle the data.. if I put
{ "end":"123"} all of the views would not be able to handle it because that is consistent...

@bostonmacosx You're frustrated. I understand. But, as the guy who spent months writing in the timezone support for Big Calendar, I promise you that this is the issue. You must use true JS Date objects for all date props. Using a UTC string for a date will give you an initial 'false positive', but fall apart as you begin to interact. It is the single most common mistake a dev makes implementing Big Calendar the first time (happened with me too, first time out).
As I brought up before, we are discussing changing this in the next major release. If you're part of our new Slack community you should join the #next channel to provide feedback.

I get the same issue, except it's asking to update 'DayColumn2' instead of 'DayColumn'. The project was created (copy/pasted) from provided examples in Typescript.
Would appreciate any help.

FWIW I am getting the error regarding UNSAFE_componentWillReceiveProps (and it seems to be preventing me from switching between weeks) despite having JS dates on all my events.


libc/minimal: Add rand and srand

rand() and srand() are pseudo-random number generator functions
defined in ISO C.  This implementation uses the Linear congruential
generator algorithm with the following parameters, which are the same
as GNU Libc.
Modulus 0x7fffffff
Multiplier<PHONE_NUMBER>
Increment 12345
ISO C / POSIX.1-2001 uses bits high 15 bits for Modulus, thus RAND_MAX
32767.  ref rand(3).

Hi @yashi ,  OK, please give me some time to take look at this, I'll feedback to you later. thanks!

Hi @yashi , I have no problem with this implementation, it looks good, and I think we need this. I would so appreciate it if some basic test cases for this can also be added to tests/lib/c_lib/src/. How do you think? thank you!

I also find the current commit message to be confusing:
            initstate(0, state, sizeof(state));
            printf("%d\n", rand());

            return 0;
    }

See initstate(3p) for more detail.

You don't implement initstate(), so why people should see its man? I however followed the advice and what I see is:
       long int random(void);

       void srandom(unsigned int seed);

       char *initstate(unsigned int seed, char *state, size_t n);

       char *setstate(char *state);

In other words, rand/srand vs random/initstate seems to be two parallel, independent pseudo-random number generation function sets. You here don't implement the latter, so references to initstate() should rather be removed. Likewise, please double-check that rand/srand implementation matches that of glibc. If it is, please update the sample in the commit message to use rand/srand. And if it's not, I'd suggest to just use the sample implementation from POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/functions/rand.html and remove references to glibc.
(And if there's some confusion on my side, please let me know what I'm missing.)

In order to test the Linear congruential generator algorithm, which is refered as TYPE_0 in GLIBC, you have to call initstate() with a state array of size 8 bytes or smaller than 32 byte.  Please note that the man page you referred is 3 not 3p, or 3posix, from Linux man-pages project.
I've updated my commit log as below for more clarity.

See initstate(3p) for more detail about how to use LCG in GLIBC.

@yashi

In order to test the Linear congruential generator algorithm, which is refered as TYPE_0 in GLIBC, you have to call initstate() with a state array of size 8 bytes or smaller than 32 byte.

That's an interesting implementation detail of GLIBC, but I don't see how that relates to the functions srand()/rand() which are being implemented here. Nothing in https://pubs.opengroup.org/onlinepubs/9699919799/functions/rand.html mentions initstate(). Nor you implement initstate(). So, why do you mention it at all?
Let's start from the beginning. Do you want Zephyr's implementation of srand()/rand() to have the same behavior/produce the same values as Glibc's srand()/rand()? If so, I'm generally +1 for that, as Glibc is a well known library and I'm for being consistent with well-know de-facto standard. But then please sure that you exactly follow behavior of srand()/rand() and don't involve unrelated implementation details, like the fact that in Glibc, srand() is implemented in terms of initstats().
And well, if you don't have that specific requirement to follow Glibc behavior, just use the simple algorithm from "Generating the Same Sequence on Different Machines" subheading of https://pubs.opengroup.org/onlinepubs/9699919799/functions/rand.html .

Please note that the man page you referred is 3 not 3p, or 3posix, from Linux man-pages project.

That page still described the functions:
       char *initstate(unsigned seed, char *state, size_t size);
       long random(void);
       char *setstate(char *state);
       void srandom(unsigned seed);

And not srand()/rand().

@pfalcon, thanks for your feedback.  The reason why I've chosen GLIBC LCG is that I assumed most of the developers in the Zephyr community prefer to have the same algorithm as their development environment, which is, I also assume, Linux with GLIBC.  I don't have any preferences at all.  And the reason I put the reference in the commit log is that when someone wants to verify my implementation, it'd be nice to give a point or two for them.  I thought it'd be helpful for future references.  Nothing else.
I followed GLIBC LCG's behavior in the Zephyr implementation.  No detail, nor TYPE_0 thing is in Zephyr implementation.  The reference is just for a hint who wants verification in behavior.  If the default algorithm in GLIBC is LCG, I didn't put the reference in the commit log, but it's not.  If you just run rand() and srand() on your Linux, you are using a different algorithm and you get different values.  I'm not sure why the reference/doc in the commit log is such a big issue.
Again, I don't have any preferences in the algorithms.  I just want rand() and srand() for compatibility.  I can either remove the reference from the commit log or implement the C standard.  Please let me know which way you want.

@yashi

The reason why I've chosen GLIBC LCG is that I assumed most of the developers in the Zephyr community prefer to have the same algorithm as their development environment, which is, I also assume, Linux with GLIBC.

I see, understand and appreciate such an approach. My concern is to make sure that if this approach is taken, then it actually works consistently, and described in a way to avoid confusion.
I now played with the sources myself, and took a closer look at glibc source (ref: https://code.woboq.org/userspace/glibc/stdlib/random.c.html#unsafe_state), and understood the situation: the default algorithm in glibc is "TYPE_3", while you implement "TYPE_0" here. Thus, to get compatible output from glibc, we need to switch it to TYPE using that initstate() call, after which both srand() and rand() will work in a way compatible with the implementation here.
I thus would recommend to update the commit message to explain that, e.g.:

This implementation uses the Linear Congruential
Generator (LCG) algorithm with the following parameters, which are the
same as used in GNU Libc "TYPE_0" algorithm. Note that the default
algorithm used by GNU Libc is not TYPE_0, and TYPE_0 should be selected
first by an initstate() call as shown below.

...

#include <stdio.h>
#include <stdlib.h>

int main()
{
        static char state[8];

        /* Switch GLIBC to use LCG/TYPE_0 generator type. */
        initstate(0, state, sizeof(state));

        srand(1);  /* Or any other value. */
        printf("%d\n", rand());
        printf("%d\n", rand());

        return 0;
}

@yashi, Thanks for looking further into this. The situation reminds me my experience with hacking POSIX and/or libc subsystems, when seemingly simple changes leed to cascade of issues and follow-up changes. So, you're not alone ;-).
I looked into the situation myself. mps2_an385 supports 8 MPU regions, and one after another protection features enabled, that trickles into 3 "free" partition slots available for application code. Having additional libc partition indeed gets this down to 2 free partition slots, which causes the mem_protect/userspace test to fail.
I was able to get it pass with CONFIG_TEST_HW_STACK_PROTECTION=n. So, we could potentially make another test config for mps2_an385 with that option and exclude it from normal tests. I don't think that would scale, because 8 MPU regions is standard for Cortex-M0/Cortex-M3 devices, so the same problem would happen to many other (real) devices, the only special thing about mps2_an385 is that it's emulated via qemu, and we run this emulation during CI. Try to filter all affected devices would be too adhoc and cumbersome, and I guess we'd really like to run the rest with stack protection anyway.
So, I'd suggest to do partition plucking on where we add it now - on minimal libc size. It shouldn't be too bread-crumb configuration either, so instead of e.g. CONFIG_MINIMAL_LIBC_RAND, I'd suggest to add something like CONFIG_MINIMAL_LIBC_GLOBALS with a description like "Support C library functions which implicitly access global/static data, e.g. rand(). Such data must be put into a memory partition, and disabling this option may save an entry for application defining many custom partitions. ..."
Then disable this option for the affected test(s).

@pfalcon, Thank you for your suggestion.  I've implemented what you suggested (in a way I understand, at least).   Please take a look the commit "libc: minimal: Use a memory partition iff globals are required".
Any feedback is as always welcome. :smiley:

Please take a look the commit "libc: minimal: Use a memory partition iff globals are required".
Any feedback is as always welcome.

Yes, that looks pretty much how I pictured it in my mind, but I'd suggest to not change  tests/kernel/mem_protect/userspace/testcase.yaml to add another test variant, bit instead just add "CONFIG_MINIMAL_LIBC_GLOBALS=n" to its prj.conf. After all, the whole idea of introducing CONFIG_MINIMAL_LIBC_GLOBALS was to avoid adding yet another test variant for mem_protect/userspace (which already has a few of them).
So, my suggestion would be to add to tests/kernel/mem_protect/userspace/prj.conf following:
# Disable libc globals partition to make the test runnable on devices
# with 8 MPU regions.
CONFIG_MINIMAL_LIBC_GLOBALS=n

And another suggestion is to squash related commits together, e.g.:

libc: minimal: Add rand() and srand()
libc: minimal: Make srand_seed memory partition aware
libc: minimal: Use a memory partition iff globals are required

should be one; 2 of "tests: c_lib:" commits can also be squashed together.

Just noticed that in #26545, it's using LIBC_PARTITION instead of LIBC_PART as in this PR.

I guess LIBC_PART is fine. And that PR shows that it may be not easy to get bigger changes thru, as they may "pull strings" for even more changes, and some PRs get stale. So again, thanks, thanks for looking into related issues here, hopefully, it will make it easier to add other libc's/functions later.

@pfalcon, I've updated the patchset.  Fixed the prj.conf instead of the testcase, merged "libc: minimal:" commits in one (merged all 4 because "libc: minimal: Place globals in z_libc_partition" causes a regression if you test it alone), merged two tests in one.
I'd like to merge "tests: crypto: mbedtls: Remove local implementation of rand()" into "libc: minimal: Add rand() and srand()" because without the fix, test for mbedtls failed to build.  WDYT?

@yashi

I'd also like to sqiash "tests: crypto: mbedtls: Remove local implementation of rand()" into "libc: minimal: Add rand() and srand()" because without the fix, tests for mbedtls failed to build. WDYT?

Well, I'd personally err on the side of having clearly delinated commits rather than on having perfect bisectability (IMHO it's better to have clean commits and 98% bisectability rather than unwieldy commits and 100% bisectability). But you can see if there will be other review comments before it's merged.
Thanks for all the updates. As it stands, this PR has substantial changes and apparently doesn't fit with codefreeze of the 2.6 release in progress, so it'll be merged when the merge window opens.
Then, we'll need to remind mergers that build error of
Error: lib/libc/minimal/include/stdlib.h:45:WARNING: Violation to rule 21.2 (Should not used a reserved identifier) - srand

is false positive here - this patch does implement that function, as part of libc.

@pfalcon, OK, let's see what the others have to say.  Meanwhile, I've updated a commit log by adding the false positive.

this PR has substantial changes and apparently doesn't fit with codefreeze of the 2.6 release in progress, so it'll be merged when the merge window opens.

Make sense.  :+1:
Thank you, @pfalcon, for all your help and advice.  I really appreciate it. :pray:

can we merge this?

@stephanosio, I saw the MAINTAINERS.yml change and you are now the maintainer of libcs.  Would you mind reviewing this PR? I just rebased to the main. Thanks.

@yashi - can you please address any remaining comments?

Yes. Will do it in this weekend.

fixes #6493


Question: Skip first CSV line

My current Scramjet code look something like this
  StringStream.from(
    fs.createReadStream(
      ies.csv'
    )
  )
.lines()
.parse()
.setOptions()
.each()
.run()
.then()

How can I skip the first line in the CSV?
I've been reading for 30 minutes but I didn't find anything.
Thanks!

Have you taken a look at the shift method? If you put it after lines it should do what you want. There's also a csv parsing method on StringStream called CSVParse - that may be useful.
As to the docs, we're working on a new website and, subsequently, on better documentation. Would you be so kind to review and give us some tips where we should start improvements?

I will! I'm glad you are working on a new documentation website! :smile:

Interesting... and what did you think it did? Maybe I'd reword the description somehow?

I read it "wrong". I read the shift function from the StringStream object.
stringStream.shift(bytes, func)
I was unsure on how to calculate the number of bytes I wanted remove.
Since I started with StringStream as you can see on my other issue, I thought id would override the shift function from DataStream and I wouldn't be able to remove the entire line. I got confused.

You're right, that doesn't make much sense if you look from this perspective. DataStream..shift operates on whole chunks (objects) - so that's how the line is removed when used after parse.
Ok. I see the point - this needs a major rethink - perhaps shiftBytes should be other than shift for compatibility with DataStream.
We need to consider changing that in v5 - of course a backwards compatible version will be provided for the current v4 line.

Oh shiftBytes would be a great idea!
Hmm may I ask, in my logic if I do the following, no lines are added to the database, in fact the console.log doesn't even trigger. But if I remove the .shift function it works and all lines are added including the header and...an invisible last line that doesn't appear in the file (may be something I'll look later)
Same code:
async function insert_countries(that) {
  const { StringStream } = require('scramjet')
  const fs = require('fs')
  const path = require('path')

  const client = await that.pg.connect()

  const INSERT_ENTRY =
    'INSERT INTO countries (iso3, iso2, name, dialing_code, dialing_exit, population, area_km2) VALUES ($1, $2, $3, $4, $5, $6, $7);'

  StringStream.from(
    fs.createReadStream(
      '/media/DarkHawk/srv/NodesProjects/___Ackanet/database/table-countries.csv'
    )
  )
    .lines()
    .shift(x => console.log('Skipped', x))
    .parse(line => {
      // Each line need to be properly formated
      const entry = line.split(';') //comma split

      let reconstruction = []

      // The following fields need formating
      reconstruction.push(entry[4])
      reconstruction.push(entry[3])
      reconstruction.push(entry[0])
      reconstruction.push(entry[1])
      reconstruction.push(entry[2])
      reconstruction.push(entry[5] != '' ? parseInt(entry[5]) : null)
      reconstruction.push(entry[6] != '' ? parseInt(entry[6]) : null)
      return reconstruction
    })
    .setOptions({ maxParallel: 1 })
    .each(async reconstruction => {
      console.log('arg:', reconstruction)

      try {
        await client.query(INSERT_ENTRY, reconstruction)
      } catch (err) {
        console.log('Error while adding line...', err)
        // some more logic could be here?
      } finally {
        // client.release()
      }
    })
    .run()
    .then(
      () => {
        console.log('Read entire file.')
        // return resolve(true)
      },
      e => console.log('Error while handling file.', err)
    )
}

Total output: Read entire file.
I'll let this issue closed for now as it may be my code and not an actuel bug since I'm not very familiar yet with the package.
And I wanted to thank you for the time you take answering my questions. Most of the time we get better help in the repo than on Q&A websites.

Duh, thanks

Hmmm seems that after some tests this only skip the first character of the file.. :confused:


CL-Optional Chaining in Swift

📋 PR Description
Optional chaining allows us to perform operations without receiving an error in case the value of an optional is "nil" when accessing it. If an optional value is present,the operations continue; if not, the transaction chain is enterrupted and nil is returned.While forced unwrapping(!) throws an error, optional chaining(?) returns nil.

✅ Checklist

[x] Code follows the project standards and guidelines.
[ ] Relevant unit tests are written and all tests are passing.
[ ] Test coverage is adequate for the changes.
[x] Any unnecessary files or debug statements have been removed.
[x] Documentation is updated where necessary.
[ ] The PR has been reviewed by at least one team member before merging.

🛠 Steps to Test

1-Setup Your Environment
2-Add the Code
3-Run the Code
4-Check the Output
5-Modify and Re-test
6-Verify New Output
🔗 Related Links

Issue: Optional chaining is a process for calling methods, properties, and subscripts
Documentation: https://docs.swift.org/swift-book/documentation/the-swift-programming-language/optionalchaining

📷 Screenshots (Optional)

the relevant work will be carried out again in accordance with the rules


Merge release-1.0 into master

Changes:
ecffa8d87 (Shriram Rajagopalan, 35 hours ago)
Allow multiple destination rules with different subsets for the same host
(#8031)
493159d0d (Pengyuan Bian, 3 days ago)
Update Mixer dictionary to match proxy (#8010)
ad49847b0 (Isaiah Snell-Feikema, 3 days ago)
de-dup clusters by name (#7983)
37558c532 (Kuat, 4 days ago)
fixes (#7996)
520b3f807 (Martin Ostrowski, 4 days ago)
Log error for bad values of autoInject (#7572) (#7956)
041ce5eb9 (gargnupur, 4 days ago)
Add support for specifying sinkoptions when creating stackdriver sink
(#7944)
173ea20e8 (Guang Ya Liu, 4 days ago)
Added build-in annotation for cert manager. (#7473)
b4f3f0b10 (Morven Cao, 4 days ago)
remove unused post install hook for remote chart. (#7772)
c07d2a839 (Lin Sun, 5 days ago)
allow pilot to run by itself (#7951)
d3fb10a6c (Jason Young, 6 days ago)
Improve config validation health checks (#7605)
36a8ea552 (Lin Sun, 7 days ago)
Correct pilot autoscalemax to 5 (#7825)

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-unit-tests

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test e2e-simple

prow/istio-unit-tests.sh
1b44c09b0dfafb95c27cfb07635db147c565ac60
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
0d469e92feb718ad03eebf5032d29a5bc1d02a53
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
e44ba4e6fb76f459322d61c8a04c2a14fc9d4c34
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e44ba4e6fb76f459322d61c8a04c2a14fc9d4c34
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
1b44c09b0dfafb95c27cfb07635db147c565ac60
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
789084f2fc8816424ca167febc86bda46ab6da6f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
789084f2fc8816424ca167febc86bda46ab6da6f
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
789084f2fc8816424ca167febc86bda46ab6da6f
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
789084f2fc8816424ca167febc86bda46ab6da6f
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
57fa616cc1d7e760c0349716612d5134747db8af
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


DOC: Remove the destination paths in container documentation

Remove the destination paths for the input and output binding input arguments in the Docker and Singularity container usage instructions.
Avoids, for example, errors that mean that no (BIDS) data was effectively found, e.g.:
Process Process-2:
Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/local/miniconda/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/miniconda/lib/python3.8/site-packages/qsiprep/cli/run.py", line 833, in build_qsiprep_workflow
    layout = BIDSLayout(
  File "/usr/local/miniconda/lib/python3.8/site-packages/bids/layout/layout.py", line 135, in __init__
    root, description = validate_root(root, validate)
  File "/usr/local/miniconda/lib/python3.8/site-packages/bids/layout/validation.py", line 70, in validate_root
    raise ValueError("BIDS root does not exist: %s" % root)
ValueError: BIDS root does not exist: /mnt/data/my/path/

Related to issue #612.

@mattcieslak I found other appearances of the destination paths in:
https://github.com/PennLINC/qsiprep/blob/master/docs/contributors.rst#contributing-to-qsiprep
They also point to very specific destinations paths (and Python 3.6, which reached its EOL on 2021-12-23). Not sure whether I am missing something about such specific destination paths, or whether they should be removed. Let me know what you think.

3.6 is too old, I believe at least 3.8 is required not. So that is incorrect in the current documentation

3.6 is too old, I believe at least 3.8 is required not. So that is incorrect in the current documentation

I know Matt. I do not have the bandwidth to check whether a simple change from 3.6 to 3.8 would make things work as they are written; if somebody in your lab has the time, I would be happy to submit a separate PR to fix the documentation.
Otherwise, would removing the destination paths altogether be OK?
What about the read only flags? Can you test them or do you want them to stay?

Added a few edits, wdyt?

They look good Matt, but I do not have that much experience with docker so as to spot inaccurate instructions. Also, I have not tested them.
There are still some references to Python 3.6 in https://github.com/PennLINC/qsiprep/blob/master/docs/contributors.rst#contributing-to-qsiprep, as highlighted in https://github.com/PennLINC/qsiprep/pull/621#issuecomment-1688898659.
Thanks.

I will edit the other outdated info in a new PR. Thanks again!


Make tests pass, close #127.

build_radio_group() started returning results not wrapped
in a list in 8103314, change the test to reflect that.

:+1: Thanks!


MI - REFERENCE section (HTTP Inbound)

Complete the reference content on HTTP inbound endpoints.
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/inbound_endpoints/listening_inbound_endpoint/http-inbound-protocol.md

The original page is removed. Content is separated into 'Concepts'[1] and 'Properties'[2].
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/concepts/concepts.md
[2] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/synapse-properties/inbound-endpoint-properties.md

Done with the reference section [1].
[2] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/synapse-properties/inbound-endpoint-properties.md


Initial UI tests for filesharing in chat composite

What

Add tests for file upload button and file cards in sendbox
Fix file shraing UI styling based on Figma https://www.figma.com/file/72qJ03EOQExf12g5JTdWjQ/Web-UI-Library?node-id=4022%3A24730

Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Two high-level comments:

Could you split this PR into two (1) add ui tests; (2) change the styling etc. Then we can see the change caused by (2) in snapshot updates!
The snapshots currently don't look right - (1) No file attach icon is visible when there should be one; (2) the snapshots with the attached files are blank. Perhaps you need to update the waitForChatCompositeToLoad function now?

Two high-level comments:

Could you split this PR into two (1) add ui tests; (2) change the styling etc. Then we can see the change caused by (2) in snapshot updates!
The snapshots currently don't look right - (1) No file attach icon is visible when there should be one; (2) the snapshots with the attached files are blank. Perhaps you need to update the waitForChatCompositeToLoad function now?

Feeling too lazy for the 1st one. :P
Fixed the incorrect snapshots

Need to stub out timestamps:

Also, is the increased height of SendBox in the ComponentExamples snapshots intentional?

Need to stub out timestamps:
Also, is the increased height of SendBox in the ComponentExamples snapshots intentional?

Good catch. Fixed :)

Is the icon change intentional?

Not caused by this PR

Noticed that there are a lot of snapshots with a vertical scroll bar, is this intended? Desktop View:  Mobile view:

You are looking at the old snapshots. New snapshots don't have vertical scroll bar ;)


Improved exit cleanup and new Wooting RGB SDK functions for Windows

You can merge this if you're done :+1:


⚠ Bofrost.lu has degraded performance

In 0072533, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1416 ms

Resolved: Bofrost.lu performance has improved in 95ca039 after 8 minutes.


Bugfix: Don't mutate fragments that are attached to query documents

This fixes an issue that arises when you perform the same query multiple times, and that query has fragments.
Because addFragmentsToDocument appends fragments to queryDoc.definitions, each time the query is performed, the query document gains a new copy of each fragment.  This is particularly egregious, since graphql-tag maintains an identity map for queries.
For example, the following currently results in a server error (duplicate fragment authorDetails) on the second query:
const fragments = createFragment(gql`
  fragment authorDetails on Author {
    author {
      firstName
      lastName
    }
}`);
const query = gql`{ author { ...authorDetails } }`;

client.query({query, fragments}); // Success
client.query({query, fragments}); // BOOM: Duplicate fragment authorDetails

Looks good to me other than the question I commented. Once this is rebased and @stubailo can review, we can probably merge.

rebased

We either need to add a comment about the clone, or replace it with a more explicit clone of definitions specifically, then we can merge!

updated to use assign instead of clone

Thanks!


Convert client authorities to a set of strings.

4ab43f06317a2ac2f93877dbfe2189d479fb840c added client authorities to the response of /check_token, but unfortunately using another type as user authorities: Client tokens are a collection of GrantedAuthority while user tokens are a set of strings. This results in differing JSON represantations:
{
"authorities": [
    {
      "authority": "ROLE_CLIENT"
    }
  ]
}

vs.
{
"authorities": [
    "ROLE_USER"
  ]
}

This pull requests changes the client authorities to be also a set of strings.

Hi,
I tried to use the “client_credential” grant and had the same issue. After some debugging I found exactly the same solution to fix the the wrong authority list. Right before I was going to commit the fix on my own, I fortunately found your pull request. I hope this fix will be included in the next release.

Thanks. Did you fill in the contributor's agreement (link in README)?

I signed the form a few minutes ago.


could add a title button?

I want to add two button in the place of title.

Okay, you're free to do it: use customTitle for that. If you want an example for using custom elements in navbar component, you can take a look here.

oh, understand~ it is every cool about your code!

Thanks for the warm words! Let me know if you'll need any other help!

I have a question
in this code
var NavigatorNavigationBarStyles = require('NavigatorNavigationBarStyles');
var StaticContainer = require('StaticContainer.react');
var cssVar = require('cssVar');

where is this component?

My component depends on react-native. So, those components are implemented in the react-native core.


Error 522 from Cloudflare Milan (MXP)

Today loading images from Italy, it returns a 522 error from cloudflare Milan CDN location.
I tried with a vpn and it works from other locations I tested.
Test image: https://images.weserv.nl/?url=images.weserv.nl/lichtenstein.jpg&w=300&h=300

There are issues reported with the Milan, Italy (MXP) DC on https://www.cloudflarestatus.com/
Cloudflare is re-routing this DC currently.

Closing this issue, because this was due to Cloudflare, and therw is nothing we can do to further prevent this.


kpt update resource-merge should also overwrite non-resources files

Files such as starlark scripts should be updated when updating the package and merging resources

@pwittrock https://github.com/GoogleContainerTools/kpt/pull/500 Isn't this already done ?

I did a quick check here, and as far as I can see the starlark script is being updated. I set up an example at https://github.com/mortent/starlarkfn which has version v0.0.1 and v0.0.2 where the name of the annotation in the starlark file is changed from the first to the second version.
kpt pkg get<EMAIL_ADDRESS>starlarkfn
kpt pkg update<EMAIL_ADDRESS>[--strategy=resource-merge]

With or without setting the the merging strategy, I end up with the expected starlark file.
@pwittrock Do you have an example where this doesn't work as expected?

I think this works as expected, so closing this issue.


no-qualify-elements - potential bug?

I'm seeing a strange linting error when using a top level magic pretzel to expand classes. Heres what our component looks like:
 // cs-text-field/styles.scss
&__field.is-disabled {
  opacity: .25;
}

the component css precompiler wraps the whole file with the component class so it becomes
.cs-text-field {
  // contents of cs-text-field/styles.scss
}

Which is firing no-qualify-elements I'm not sure if this is a bug or just a side effect of sass-lint not knowing that the module is going to be wrapped. Is there any way around this?

I don't have an answer to your question right now, but I must say, I've been in the Sass community for a while now, have taught it talked about it all over the place, and not once have I ever heard anyone call the & "a magic pretzel".
I love it.

On Mar 8, 2016, at 6:00 AM, onlymejosh<EMAIL_ADDRESS>wrote:
I'm seeing a strange linting error when using a magic pretzel to expand classes. Heres what our component looks like:
// cs-text-field/styles.scss
&__field.is-disabled {
opacity: .25;
}
the component css precompiler wraps the whole file with the component class so it becomes
.cs-text-field {
// contents of cs-text-field/styles.scss
}
Which is firing no-qualify-elements I'm not sure if this is a bug or just a side effect of sass-lint not knowing that the module is going to be wrapped. Is there any way around this?
—
Reply to this email directly or view it on GitHub.

@Snugug -- All credit goes to @jgwhite for coining the name ;)


Add FolderIconSO to create list of folder names

Add Scriptable Object FolderIconSO with

icon to assign
list of folder names to use assigned icon

If you want to use one image for multiple folders, you may copy Assets/SimpleFolderIcon/Icons/Default/FolderIconSO.asset into Assets/SimpleFolderIcon/Icons/, then in the Inspector: assign an icon & add as many folder names to the list as you want.
It is prevents from copying one .png many times, when it needs to be used for many folders.

Thank you!!


Obsolete head usage in some scripts

It looks like rbenv uses head(1) in an obsolete manner in multiple files. The use of head -[number] was deprecated in POSIX issue 6 according to what I could find.
I think you can get the same functionality out of either head -n 1 or sed 1q (that is, printing the first line of a file). I don't see any uses of head -[number] besides head -1 so it's a seemingly easy fix but I'm not familiar with rbenv.

On review it looks like head -1 might output the first line of the input?

Thanks!


joblib? error during align prep

Hey Guys,
I'm getting the following error at the start of a WGS run.  I'm running the most recent development version as of this morning and the error persists.
[2018-08-20T17:44Z] System YAML configuration: /usr/local/share/bcbio/galaxy/bcbio_system.yaml
[2018-08-20T17:44Z] Resource requests: bwa, sambamba, samtools; memory: 3.00, 3.00, 3.00; cores: 16, 16, 16
[2018-08-20T17:44Z] Configuring 2 jobs to run, using 16 cores each with 48.1g of memory reserved for each job
[2018-08-20T17:44Z] Timing: organize samples
[2018-08-20T17:44Z] multiprocessing: organize_samples
[2018-08-20T17:44Z] Timing: alignment preparation
[2018-08-20T17:44Z] multiprocessing: prep_align_inputs
Process LokyProcess-2:
Traceback (most recent call last):
File "/usr/local/share/bcbio/anaconda/lib/python2.7/multiprocessing/process.py", line 267, in _bootstrap
self.run()
File "/usr/local/share/bcbio/anaconda/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/home/ubuntu/.local/lib/python2.7/site-packages/joblib/externals/loky/process_executor.py", line 428, in _process_worker
result_queue.put(_ResultItem(call_item.work_id, exception=exc))
File "/home/ubuntu/.local/lib/python2.7/site-packages/joblib/externals/loky/backend/queues.py", line 233, in put
obj = CustomizableLokyPickler.dumps(obj, reducers=self._reducers)
File "/home/ubuntu/.local/lib/python2.7/site-packages/joblib/externals/loky/backend/reduction.py", line 145, in dumps
p.dump(obj)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 224, in dump
self.save(obj)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 331, in save
self.save_reduce(obj=obj, *rv)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 425, in save_reduce
save(state)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 286, in save
f(self, obj) # Call unbound method with explicit self
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 655, in save_dict
self._batch_setitems(obj.iteritems())
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 669, in _batch_setitems
save(v)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 331, in save
self.save_reduce(obj=obj, *rv)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 401, in save_reduce
save(args)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 286, in save
f(self, obj) # Call unbound method with explicit self
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 568, in save_tuple
save(element)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 331, in save
self.save_reduce(obj=obj, *rv)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 401, in save_reduce
save(args)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 286, in save
f(self, obj) # Call unbound method with explicit self
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 568, in save_tuple
save(element)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 286, in save
f(self, obj) # Call unbound method with explicit self
File "/usr/local/share/bcbio/anaconda/lib/python2.7/pickle.py", line 754, in save_global
(obj, module, name))
PicklingError: Can't pickle <class 'joblib.my_exceptions.JoblibCalledProcessError'>: it's not found as joblib.my_exceptions.JoblibCalledProcessError
Traceback (most recent call last):
File "/usr/local/bin/bcbio_nextgen.py", line 242, in
main(**kwargs)
File "/usr/local/bin/bcbio_nextgen.py", line 47, in main
run_main(**kwargs)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 45, in run_main
fc_dir, run_info_yaml)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 89, in _run_toplevel
for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 128, in variant2pipeline
samples = run_parallel("prep_align_inputs", samples)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
return run_multicore(fn, items, config, parallel=parallel)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
for data in joblib.Parallel(parallel["num_jobs"], batch_size=1)(joblib.delayed(fn)(x) for x in items):
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 994, in call
self.retrieve()
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 897, in retrieve
self._output.extend(job.get(timeout=self.timeout))
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/_parallel_backends.py", line 515, in wrap_future_result
return future.result(timeout=timeout)
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/externals/loky/_base.py", line 431, in result
return self.__get_result()
File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/joblib/externals/loky/_base.py", line 382, in __get_result
raise self._exception
joblib.externals.loky.process_executor.BrokenProcessPool: A process in the executor was terminated abruptly while the future was running or pending.

FYI, Im running bcbio on an amazon EC2 ubuntu instance.  bcbio is installed on the boot drive with an EFS mounted to process the run.

It looks like you have another PYTHON site-libs that is getting injected into your path from .local:
/home/ubuntu/.local/lib/python2.7/site-packages/joblib/externals/loky/backend/queues.py

Is there some way you could nuke that in your instance?

Thanks Rory, did the trick.

Awesome, glad that worked! Thanks so much for following up.


Add sRGB texture support

Add sRGB texture support, which is available in WebGL2 or in WebGL1 via EXT_sRGB: https://developer.mozilla.org/en-US/docs/Web/API/EXT_sRGB

Added in v0.1