Consider a processing stage between origin and destination network

About you
Name: Luke Riley
Organization/Company: Quant
About your review
Document: EEA DLT Interoperability Specification
Section: https://entethalliance.github.io/crosschain-interoperability/draft_dlt-interop_techspec.html#crosschain-message-definition
Comments/Suggestions/Feedback
This is an editorial suggestion - with the potential to have a feature change impact.
When reading through this section, I believe that this specification does not allow for a processing stage between data being picked up from the origin blockchain, and placed on the destination blockchain. I could see this being a requirement for some use cases. E.g. prices are read from multiple DEXs and then averaged out before being placed on the destination blockchain.
At the moment I am looking for a comment around the appropriateness of your specification for this type of use case.

Yes, the specification accommodates this use case. Data interpretation and processing should be done at the application layer.  We will add this consideration to section 5. Crosschain Application Layer.

Draft specification updated to address this issue.


Support DB username and password in GKE

As a user of Forseti on-GKE, I would like to be able to access the SQL DB with a user name and password in order to assert authentication to the database.

[x] Update Docker Entrypoint script to support

Probably env vars

@kevensen Can this issue be closed?


"Attrs" constructor

Ok, so this is my proposal for #291 and #184 (and probably others). I think it does what we need in a really nice way:
const X = styled.div.attrs({
  /* add extra props here */
})`
  /* css here as normal */
`

So, @ticky's original code becomes:
const Title = styled.h1.attrs({
  className: 'meow nya'
})`
  font-size: 1.5em;
  text-align: center;
  color: palevioletred;
`

And @ForbesLindesay's becomes:
const activeClassName = btoa(Math.random())
const StyledLink = styled(Link).attrs({
  activeClassName
})`
  color: palevioletred;
  display: block;
  margin: 0.5em 0;
  font-family: Helvetica, Arial, sans-serif;

  &:hover {
    text-decoration: underline;
  }
  &.${activeClassName} {
    color: red;
  }
`

I've added a bit of smarts to make it more similar to how interpolations work:
const Button = styled.button.attrs({
  type: props => props.submit ? 'submit' : 'button'
})`
  /* ... */
`

<Button> //#> <button type="button" class="...">
<Button submit> //#> <button type="submit" class="...">

It gets passed the same { ...this.props, theme } object that interpolations do, and recalculates whenever the CSS snippet gets reevaluated. I.e. it works exactly the same, as much possible.
If you have a prop and an attr with the same key, the prop wins (in that sense they're like defaultProps). That is except for className which just adds everything together. I decided against trying to generalise it—adding extra classes is kind of a special case so I'm happy to keep it that way. If you want any other kind of weird manipulation of properties just make a stateless functional component.
I've also called it attrs because, well, I think props is too overloaded. And, at the end of the day you're rendering HTML elements most of the time. They have attributes, not props. And I see this sort of API most useful when working with these elements—if you have more complex objects you should define a real component. I'm not trying to reinvent React here, but being able to define attributes in the same way you generate and attach CSS turns out to work quite nicely.
The big exception to the previous paragraph is, of course, react-router's Link. It masquerades as a HTML element, but it's a component, so having a single syntax that preserved that facade was important to this. Still, I didn't think it was worth changing the name.
Oh also anything in attrs gets turned into a prop later. That's not very useful, except for some cases like this:
const Image = styled.img.attrs({
  'alt': 'My Beautiful Face'
})`
  &::after {
    content: '${props => props.alt}';
  }
`

Happy to hear feedback, in particular if you can see this breaking down in certain circumstances (that don't just warrant adding an extra component). And everyone's reaction to the name, as well. Don't submit alternate syntaxes here though. That discussion is over at #291, and I'm pretty sure we've considered every possible syntax already. If not, continue the conversation there.

This is beautiful. Solves all of the concerns with one concise, lovely API! Let's see what everybody else has to say.

I've added a bit of smarts to make it more similar to how interpolations work...

Hey,
Do you have any solution how to solve https://github.com/styled-components/styled-components/issues/305 with attrs? Maybe don't pass attrs to the element which are false?
import FontAwesome from 'react-fontawesome';

export const Icon = styled(FontAwesome).attrs({
  active: false,
  color: false,
})`
  font-size: 25px;
  margin-bottom: 3px;
  ${props => props.active && `color: ${props.colors.brand}`}
`;

This won't work because of:

Oh also anything in attrs gets turned into a prop later. That's not very useful, except for some cases like this:

Interesting, I like it.
If it's not already, I suggest being able to pass string literals in the attributes like this:
const ScrollView = styled.ScrollView.attrs({
  contentContainerStyle: `
    background-color: red;
  `,
  style: `
    background-color: green;
  `
})

^ Also, I passed the style attribute, not sure if you handled this case.
I suggest merging the styles from the style attr with the styles from the default way to do it.

This is great.  The one thought I have is that:
const activeClassName = btoa(Math.random())
const StyledLink = styled(Link).attrs({
  activeClassName
})`
  color: palevioletred;
  display: block;
  margin: 0.5em 0;
  font-family: Helvetica, Arial, sans-serif;

  &:hover {
    text-decoration: underline;
  }
  &.${activeClassName} {
    color: red;
  }
`;

still requires me to think a lot about how the internals work in order to cover this use case.  What I'd ideally like to get working is:
const StyledLink = styled(Link).attrs({
  activeClassName: css`
    color: red;
  `
})`
  color: palevioletred;
  display: block;
  margin: 0.5em 0;
  font-family: Helvetica, Arial, sans-serif;

  &:hover {
    text-decoration: underline;
  }
`;

This gives me no need to think about how an active class name gets generated.  The only problem I see at the moment is that the return type of css is, I think, the actual string of css, so this would need to somehow know to convert that css into a className.
On an unrelated note, i wonder about calling it withDefaultProps rather than attrs.  I think overall we should prioritise clarity over succinctness.  A more descriptive name might make it more obvious what it does.

@ForbesLindesay For this specific case, I don't think we need that complexity.
const StyledLink = styled(Link).attrs({
  activeClassName: 'active'
})`
  color: palevioletred;
  display: block;
  margin: 0.5em 0;
  font-family: Helvetica, Arial, sans-serif;

  &:hover {
    text-decoration: underline;
  }
  &.active {
    color: red;
  }
`;

It would work perfectly (or am I missing something?)

On an unrelated note, i wonder about calling it withDefaultProps rather than attrs. I think overall we should prioritise clarity over succinctness. A more descriptive name might make it more obvious what it does.

Yeah, it seems too much like React's defaultProps. I didn't read everything yet, but the only difference I see is we are passing in actual props here (so you can set a prop based on actual props).
I'm afraid it stimulates people to use this instead of defaultProps, which should be used for most cases. The image alt case, for example, should use defaultProps instead of attrs, from my point of view.

For this specific case, I don't think we need that complexity.

The advantage of my proposal is that it doesn't require me to know the internal structure of the Link component.  If I use &.active { color: red; }, I need to know that the activeClassName gets applied to the same element as the normal className.
If I can somehow tell styled-components to generate another, totally separate style, it doesn't matter what the internal structure is.
I'm not currently sure if this is worth trying to change/extend the API for though.  I may need to keep thinking about it/try out the existing API.

I'm afraid it stimulates people to use this instead of defaultProps

I'm not sure if this is actually a problem.  Is there anything wrong with doing:
const Image = styled.img.withDefaultProps({
  alt: 'My Beautiful Face',
})`
  &::after {
    content: '${props => props.alt}';
  }
`

Nice!!! Just had a play, this feels much, much cleaner!

The advantage of my proposal is that it doesn't require me to know the internal structure of the Link component. If I use &.active { color: red; }, I need to know that the activeClassName gets applied to the same element as the normal className.

If this is a problem, it's Link's responsibility, not ours. This is how react-router works.

I'm not sure if this is actually a problem.

What's the benefit of using a different API from another library (styled-components) if it does exactly the same as React's defaultProps? There're also some libraries that counts on that, such as react-docgen. I think we should not encourage it.
Actually, besides className (which I would prefer to have a separated .className constructor) and cases when you want to set the attribute based on props (like the submit example), I don't think .attrs should be used. Even the Link example should use React's defaultProps.
Just my 2c.

Thanks for the discussion and the feedback. withDefaultProps is not a bad name, but it doesn't actually work the way defaultProps works—these are reevaluated every time props changes, and they can take functions. It's also kind of a react-specific name. Styled Components is wholly tied to React at the moment but only by implementation, not by design.
As for the Link discussion, I tend to agree with @diegohaz that it's part of Link's API that it applies activeClassName in certain cases. I don't think it makes much sense to add css-generation-and-injection behaviour into the attrs API, they just feel like totally separate concerns.
However, I could consider treating css blocks specially:
/* React Native example */
const ScrollView = styled.ScrollView.attrs({
  contentContainerStyle: css`
    background-color: red;
  `
})`
    background-color: green;
`

/* inline style example */
const Box = styled.div.attrs({
  style: css`
    background: hsl(
      ${props => props.hue},
      ${props => 50 + props.luminosity / 2}%,
      ${props => props.luminosity}%
    );
  `
})`
  margin: 2rem auto;
  width: 360px;
  height: 360px;
`

This would basically convert CSS snippets to objects, so no nesting or anything would be permitted, but it might be useful for these cases. Feels like this would be useful for #149 too.

Ok so that previous comment isn't going to work just yet. It ends up needing to do something really similar to css-to-react-native which at the moment depends on PostCSS, and we're just about to replace PostCSS with Stylis (#286).
I've opened #371 to track it. But otherwise I think we should merge this.

Anything I could contribute / work on to help this along?
I'm getting buried in repetitive class names.  :)

will this feature be in v2?

@kidwm yes.

This should be available in<EMAIL_ADDRESS>right? I'm getting _styledComponents2.default(...).attr is not a function

That's because @geelen forgot to export it 😉 PR?

Oh, yes. 😀

Wait sorry that's not right, this is working as intended. What's the code you're running?

@mxstbr  that's weird, tried it in webpackbin now and it works. It was webpack using the old cache in my build, works now. Thanks.

@mxstbr sorry to bug you, but it happened again, replicated it here http://www.webpackbin.com/V1_gYxlKf

It's working for me at your link ;)

@k15a that's weird, Firefox and Edge show the same thing. http://imgur.com/a/SIRFa

Yeah I've noticed that I looked wrong that's why I've removed my comment :p

Not sure what the problem is here but attrs shouldn't be being attached to the styled component itself—it's part of the constructor, not the component, so being attached here is correct.

@geelen Can it be done like this?
const Button = styled(({className, type}) =>
  <input className={className} type={type ? 'submit' : 'button'} />
)`
  /* ... */
`

@streamich this certainly works, but please don't comment on stale PRs and issues. Especially since this is a PR and you have a rather unrelated question. I don't mean to be rude, so my suggestion is to go to Spectrum, or Twitter, or at the last create an issue for your questions :wink:


Question: files from  .folder are completely ignored

This is probably more generic eslint question,  but since I was debugging it for this plugin and you folks seems to be nice,  so I decided to ask here.
So if I change code_file example  so schema graphql is stored under any .anyDotNameFolder I  will get no validation from this plugin.

Original Structure -> Validation works

--query.js
--.eslintrc.json
--schema.graphql

Schema in aFolder -> Validation works

--query.js
--.eslintrc.json
--aFolder
----schema.graphql

Schema in .aDotFolder -> Validation does not work

--query.js
--.eslintrc.json
--.aDotFolder
----schema.graphql
Nothing that I can change in eslint config file seems to have any effect. All the files from '.anyDotFolderName' seems to be ignored.
Any suggestions/clues/pointers?
Thank you 🙌

Yes,  this is generic eslint behaviour discussion.
The best solution seems to be adding .eslintignore with !.aDotFolder which is so suboptimal...   Ignoring by default something is confusing.
Alright will close the issue... thanks for listening 😊


feat: use Entry<String, Object> to capture path.

The pull request changes the type of path from list of objects to a list of entries String -> Object. This makes it possible to also track the exact route of visited nodes prior to the current.

@manusa: I'd like that to be part of 6.0 if possible.

I think that this shouldn't be breaking, so there should be no problem including the version bump.
This one wasn't merged because it didn't compile
https://github.com/fabric8io/kubernetes-client/pull/4212 (there seems to be an issue with the CRD Generator test expectations)

@manusa: pushed a fix that will take care of these issues. Releasing soon.

@manusa: pushed a fix that will take care of these issues. Releasing soon.

Great thx!


Credentials Incorrect

the credentials are Incorrect to login I try with
/----------superadmin login-------/
superadmin
testsuperadmin

I can't login with username: superadmin and password: testpassword123

Finally I findout the login credentails here in file: /lib/configs/application.config.js
Username: superadmin
Password: superadmin@123

I tried with the password mentioned in application.config.js file... bt still not able to login.. it shows invalid credentials..

I tried with the password mentioned in application.config.js file... bt still not able to login.. it shows invalid credentials..

Make sure you are integrating correct DB... I hope that will be on your localhost.
There is a collection "user" in mongodb databse with a admin user entry as shown below
{
"_id" : ObjectId("58497c16072f6c20f4fac319"),
"addedBy" : "system",
"userRole" : "superadmin",
"securityAnswerSalt" : "$2a$12$2d3OMt1DY6KUifrKG4dMAO",
"securityAnswer" : "$2a$12$2d3OMt1DY6KUifrKG4dMAOirFKT3mlKT3p0YhVZQFKNOp6QDjcxdi",
"securityQuestion" : "Who was your childhood hero ?",
"passwordSalt" : "$2a$12$8VyM4927V0pg3d4/qfxNGe",
"password" : "$2a$12$8VyM4927V0pg3d4/qfxNGeUqMi10uZEuj6KCB/5qUtvjZpwcLjp1.",
"username" : "superadmin",
"blockedOn" : ISODate("2018-07-27T16:35:21.726Z")
}
update your admin data in DB with these data so may be you can login successfully. Update password and salt strings.

I tried with the password mentioned in application.config.js file... bt still not able to login.. it shows invalid credentials..

Make sure you are integrating correct DB... I hope that will be on your localhost.
There is a collection "user" in mongodb databse with a admin user entry as shown below
{
"_id" : ObjectId("58497c16072f6c20f4fac319"),
"addedBy" : "system",
"userRole" : "superadmin",
"securityAnswerSalt" : "$2a$12$2d3OMt1DY6KUifrKG4dMAO",
"securityAnswer" : "$2a$12$2d3OMt1DY6KUifrKG4dMAOirFKT3mlKT3p0YhVZQFKNOp6QDjcxdi",
"securityQuestion" : "Who was your childhood hero ?",
"passwordSalt" : "$2a$12$8VyM4927V0pg3d4/qfxNGe",
"password" : "$2a$12$8VyM4927V0pg3d4/qfxNGeUqMi10uZEuj6KCB/5qUtvjZpwcLjp1.",
"username" : "superadmin",
"blockedOn" : ISODate("2018-07-27T16:35:21.726Z")
}

update your admin data in DB with these data so may be you can login successfully. Update password and salt strings.


Improve and re-organize Logging doc page

Reorg the docs to have basic logging (very frequently used for both server and client side) and remote logging (less frequently used)
Add a bunch more info in basic logging page

The intention is to consolidate the most commonly used functions into basic logging page, easier fur us to keep it better maintained.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9153/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9154/
Test FAILed.

ooh my new doc check caught an error in jenkins:
2020/04/15 22:24:35 Errors found in documentation markdown
  /tmp/docsCheck095493299/docs/en/operation/Troubleshooting.md:
    34: relative link pointed to unknown file /en/operation/Client-Logging.html
exit status 1

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9155/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9156/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9158/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9159/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.2 please


Add chimad-phase-field to list

Add chimad-phase-field website to list of websites using the Staticman app

Thanks for this! There are some merge conflicts now, due to an earlier submission. Would you mind rebasing your fork and updating the PR?


can we open a wish list thread? :)

(Salvaged from a closed issue thread I posted to as it closed)
but... if I do have this thread as a bit of a wish list:
In the filters is min/max duration for total flight time for the whole route or per leg, and would it be possible to have a total flight time min/max for the whole trip and a max leg distance filter for the whole trip?
I've been making a ton of money with the CJ4 and Citation Longitude in MSFS, mostly because of this tool you have created!
I will usually select a number of middle eastern countries, eastern and northern europe, and russia as my regions to job search, select the CJ4 as the rentable airplane, and see what comes up. The reason I ask is if I filter by best pay per flight time or per mile almost always ends up with a 48nm trip for ~$4k which is not what I'm trying to do.  So far, I have been filtering by total pay and checking total flight times. In the example today, the suggested routes are between 10.5 and 14 hours (~3000nm). If I could filter so the total leg distance didn't exceed the range of the plane (which I believe I can set now in the filter) AND the total overall flight distance could be limited to my choice (say 12 hours, or no more than 3000nm for the entire trip) I could fine tune my selections better. What I am currently doing is sorting by Total Pay, and finding the shortest timed trip within a few thousand dollars of best pay. The best trip today for total pay is $77205 and 12h11. There is another trip at $73647 but its only 10h58. If I could filter for best pay per mile but only on trips over 10 hours for the total flight for example I think I could better choose the route to fly. I could also find the best 5 hour routes that way.
Another thing I'm up to is, I'm trying to get a DA62 from europe to north america, and this route planner has been excellent for that. It would be useful to have in the free search not just the airport you are starting and ending from, but if it was possible to force an intermediate stop. I wanted very much to go through Vagar in the Faroe Islands on my way to Iceland (I've made it to Keflavik already and because of your planner I did it +$24k instead of paying to ferry or trying to find my own routes). There were trips to and from it along the route, but I couldn't get the route finder to include it. That said, the flight planner is EXCELLENT for manually choosing your legs as well, it just takes some observation and clicking.
One other area I still find myself looking for alternative resources away from your flight planner is finding alternative airports when FSE and MSFS databases are not the same. Currently I am using this: https://fse-aardvark-planner.co.uk/msfs-icaos/ to find the best alternative airport when it doesn't exist in MSFS. Your planner will let me know an FSE airport doesn't exist, and lists multiple alternatives, but the link I sent you shows a green box of the region in which to land for it to count as the FSE listed airport AND all the airports (if there are any) which would be acceptable as alternative landing airports. Your planner is already good in this respect, but it could be a little better. This is a fairly rare circumstance, but flying in the middle east and russia (that's where the big bucks are in FSE) its a bit more common.
Please note, these are not bugs or complaints, I am using your tool almost every day now (if you see a lot of hits on your site from Texas thats me!). It is very quickly coming to the point where I don't do a flight without using your planner first.
Thank you!
btw If you had a flight sim that has a citation mustang in it, and you'd like one for FSE, I bought one by accident and would be happy to sell it to you for what I paid for it :)

The min/max distance/$/duration filters are for the whole trip: i will think about adding the same kind of filters for a single leg
Intermediate stop: I have to think more about it, not sure how complex it would be to implement
You can already show the FSE airport landing areas: in the overlay list, select "FSE airport landing areas" + "MSFS airports" so you can visualize which airports are in the zone

And thanks for the offer on the citation mustang, but I am using MSFS...

Every time I've had a question or an issue, you've been able to show me in 2 seconds that your tool can already do that!
I hope I'm not getting annoying yet :)
Thanks again for this great tool

Ahah no worries :) I do know it is not always easy to find a feature, the tool is more and more complex

By the time I understand all the useful features I haven't even touched yet, I'll be able to write the manual for you :)

I was going to ask if there was a way to turn on and off the distance bonus accounting as it is currently suspended in FSE and not calculated.
I was also going to see if you could account for booking fees in the calculations when taking 6 or more green contracts, or if this is already done.
And if you wanted to go all out, you could take into account the ground handling fees at different airports 🥇 or if that was done as well.

New release:

bookings fees, ground handling fees, plane rental, bonus and fuel cost can now be taken into account.
legs now cannot exceed the plane maximum range

I believe there only remains one of your suggestion that I have not implemented yet: intermediate stops

Thanks to icykoneko, the new release now offer you the possibility to filter the Route Finder results, to only keep the route containing a given ICAO.
I am closing this thread, because I believe all your suggestions have been implemented, but fill free to open a new one if needed!


Android apps blurred on high DPI displays

After I changed Display size in settings, all Android apps are scaled and blurred. Most text in Android apps is large enough, so is there a way to stop this scaling behavior?

Thanks for your comment. It is still the same with another account.

Thanks for your comment. It is still the same with another account.

can you make a video and post it here: https://streamable.com/
I havent actually tried to place the ROCK 5B on my LG TV but I'm curious if it happens to me too.
So far I'm good but this is a low DPI display that I am currently using.

@DarkevilPT You can also try that on a low DPI display, just adjust the Display size setting.

@DarkevilPT You can also try that on a low DPI display, just adjust the Display size setting.

I did and ... I dont have blurr at all.

@DarkevilPT This is what I got under display size 200%:

https://i.ibb.co/FJF4KBK/Screenshot-2023-03-17-08-12-24.png
I don't think I have that issue tbh... and even your image doesn't look too blurry but yes could be sharper.

https://i.ibb.co/FJF4KBK/Screenshot-2023-03-17-08-12-24.png
I don't think I have that issue tbh... and even your image doesn't look too blurry but yes could be sharper.

@DarkevilPT It seems that what you are using are all web apps, not Android apps?

Yes. Android apps have DPI scale problems. We are solving those issues.

Did a wee test and yes its somewhat noticeable probably worst on bigger screens which is not my case.
https://streamable.com/klbj83
https://streamable.com/no8dyp
The video recording really puts some bad stuttering to its performance.

How do you install APK’s?  I can’t find any reference to Android in the settings.

How do you install APK’s? I can’t find any reference to Android in the settings.

Just download the apk from a web page and install it.

How do you install APK’s? I can’t find any reference to Android in the settings.

I tried double clicking or right clicking the APK in Openfyde 108 on a Pi 4. It’s not recognised

How do you install APK’s? I can’t find any reference to Android in the settings.

I tried double clicking or right clicking the APK in Openfyde 108 on a Pi 4. It’s not recognised

On pi 4? This is the github for the Rock 5B.
Maybe pi 4 hasnt got Arc Hero yet. Check on the pi 4 overlay if it mentions anything about Android or Arch Hero.

Thank you
I don’t see it mentioned. I had assumed it was a feature in 108. I have now downloaded 108 for Orange Pi 5 but it’s an upgrade not a clean install and the instructions don’t work for me. I filed an issue in the Orange Pi 5 github. 👍🏼

Thank you
I don’t see it mentioned. I had assumed it was a feature in 108. I have now downloaded 108 for Orange Pi 5 but it’s an upgrade not a clean install and the instructions don’t work for me. I filed an issue in the Orange Pi 5 github. 👍🏼

But do u have an orange pi 5 ?

Thank you
I don’t see it mentioned. I had assumed it was a feature in 108. I have now downloaded 108 for Orange Pi 5 but it’s an upgrade not a clean install and the instructions don’t work for me. I filed an issue in the Orange Pi 5 github. 👍🏼

But do u have an orange pi 5 ?

Yes, I listed an issue. a new release in a few days
https://github.com/openFyde/overlay-orangepi5-openfyde/issues/15#issuecomment-1522633114


Fixed Proposal Details Page, Create CDP Button and CDP List

Description

Fixes #438
Checklist

[x] Targeted PR against correct branch.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Run meteor npm run lint
[x] Added an entry to the CHANGELOG.md file.
[x] Re-reviewed Files changed in the Github PR explorer.

 CDP list display and Ledger button fix

 CDP list display and Ledger button fix

I have just done a query kvcli q cdp cdps --collateral-type hard-a and there are a lot of CDPs.

I have just done a query kvcli q cdp cdps --collateral-type hard-a and there are a lot of CDPs.

I have just done a query kvcli q cdp cdps --collateral-type hard-a and there are a lot of CDPs.

Ok I see! Looks like the cdp/cdps query tracks only CDPs created with BNB. I've changed that and added Tab selection for each collateral type to allow users explore the collateral they're interested in.

I have just done a query kvcli q cdp cdps --collateral-type hard-a and there are a lot of CDPs.

Ok I see! Looks like the cdp/cdps query tracks only CDPs created with BNB. I've changed that and added Tab selection for each collateral type to allow users explore the collateral they're interested in.

2 issues.

I think the CDP calculations with HARD is wrong. The usd value is not correct.

When switching different denom in CDP, it's better to clear the list and show a loading indicator then wait for new data to feed in. Currently, when you switch the denom in different tabs, it keeps waiting but the existing data keeps there and it's strange. For example, when you are reading the CDP list of Kava and then you switch BNB, the list wouldn't be refreshed until the new data have arrived. In that case the tab has been switched to BNB but the CDP list is still showing the CDP of Kava.

2 issues.

I think the CDP calculations with HARD is wrong. The usd value is not correct.

When switching different denom in CDP, it's better to clear the list and show a loading indicator then wait for new data to feed in. Currently, when you switch the denom in different tabs, it keeps waiting but the existing data keeps there and it's strange. For example, when you are reading the CDP list of Kava and then you switch BNB, the list wouldn't be refreshed until the new data have arrived. In that case the tab has been switched to BNB but the CDP list is still showing the CDP of Kava.


cannot type in interactive chat

I have seen this a few times over the last several days. I run Start Code Chat and am unable to type in the input box.
https://github.com/microsoft/vscode/assets/29464607/86cebb13-3fd8-4e0c-ba31-14516109f2df
Output:
ERR Canceled: Canceled
    at new L (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1519:67484)
    at p.O (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1535:15383)
    at P.<computed>.F.charCodeAt.P.<computed> (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1535:12673)
    at Object.getOriginalResource (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1528:19261)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1067:9422
    at Array.map (<anonymous>)
    at e.QuickDiffService.getQuickDiffs (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1067:9294)
    at Ne (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1882:6972)
    at h (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1900:1935)
    at u.invokeFunction (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:619:360)
    at I.participate (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1900:5762)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders%2013.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1851:11149

at the time, editMode: preview and here are the context keys


obs-packaging/gen_versions: add --head option

Add --head option to use the head of the branch instead of the kata
version to generated the hashes for the packages. With this new option
kata packages can be generated using the latest commit on master.
fixes #566
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

/test

Launched a release pipeline with this changes, https://dev.azure.com/kata-containers/release-process/_releaseProgress?_a=release-environment-logs&releaseId=20&environmentId=20

Repository: https://build.opensuse.org/project/show/home:katacontainers:releases:x86_64:head

/retest

/test

Running again release pipeline.
https://dev.azure.com/kata-containers/release-process/_release?definitionId=1

Added dnm to wait for job

Failed without the --head flag,
2019-06-10T18:44:44.6992071Z +++ /home/vsts/go/bin/yq read versions-1.8.0-alpha0.yaml assets.hypervisor.qemu.tag
2019-06-10T18:44:44.7039117Z ++ result=null
2019-06-10T18:44:44.7040107Z ++ '[' null = null ']'
2019-06-10T18:44:44.7040767Z ++ result=
2019-06-10T18:44:44.7041766Z ++ echo ''
2019-06-10T18:44:44.7044853Z + qemu_vanilla_tag=
2019-06-10T18:44:44.7050608Z ++ curl -s -L https://raw.githubusercontent.com/qemu/qemu//VERSION
2019-06-10T18:44:44.9787515Z + qemu_vanilla_version='404: Not Found'
2019-06-10T18:44:44.9792398Z ++ git ls-remote https://github.com/qemu/qemu.git
2019-06-10T18:44:44.9795359Z ++ grep 'refs/tags/^{}'
2019-06-10T18:44:44.9806711Z ++ awk '{print $1}'
2019-06-10T18:44:45.3712584Z + qemu_vanilla_hash=
2019-06-10T18:44:45.3714354Z + ./gen_versions_txt.sh master

It is because the tag value does not exisit in old repos, to keep compatible the code with old branches do you have any problems to use assets.hypervisor.qemu.tag as in master this is the same as the tag and it could be used in old branches?

@jcvenegas done, I have added backward compatibility

/test

/test

/test

/test

/test


Add the table of affected clusters: continuation

Fixes https://issues.redhat.com/browse/CCXDEV-5496.

Codecov Report

Merging #32 (107cafa) into master (bf9f31e) will decrease coverage by 3.68%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   18.73%   15.04%   -3.69%
==========================================
  Files          25       27       +2
  Lines         347      432      +85
  Branches       95      107      +12
==========================================
  Hits           65       65
- Misses        253      333      +80
- Partials       29       34       +5

Impacted Files
Coverage Δ

...nts/AffectedClustersTable/AffectedClustersTable.js
0.00% <0.00%> (ø)

src/Components/AffectedClustersTable/index.js
0.00% <0.00%> (ø)

src/Components/Recommendation/Recommendation.js
0.00% <0.00%> (ø)

src/Services/SmartProxy.js
0.00% <0.00%> (ø)

src/Services/SmartProxyMocked.js
0.00% <0.00%> (ø)

src/Store/index.js
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9f31e...107cafa. Read the comment docs.

(there was a problem with fetching font assets in the local deployment, so don't worry about incorrect fonts in the screenshots below)
Error state

Normal state with items

Filter criteria doesn't match any item

@AllenBW, @Fewwy, @mdorusko, please take a looook 🙏🏻

@gkarat Hey Georgii! Can you expand the use-case behind the first error screen? Does it mean that something happened during a loading state or we don't have data for it?
The second screen looks fine, just wanted to ask you, do we have data about the "Last seen" column and OS?
The last screen should have this text:
[title] No matching clusters found
[content] To continue, edit your filter settings and search again.

@doruskova, the error state means the request to the server has failed. It can be that server is down, is lagging, or doesn't know about affected clusters for this recommendation name (which should not happen by the arch design).
I have added the fourth screenshot for that case when the server responds with 0 affected clusters.

@gkarat I have to discuss error states with other UXers.

@gkarat error state https://marvelapp.com/prototype/g70a1he/screen/82026376

@doruskova, thank you, Marie!


Clarification of kubectl involvement in deploy command and potential error reason

I have added a small clarification right under the deploy command which can be useful for those who want to try tye and already have kubectl installed and that kubectl points to invalid context.

Thanks!


Question on lift test calibration

Hello!
This is more a question than an issue, relating to lift test calibration. I really like this feature and this doc is great, but it wasn't so clear to me what my pre-test channel spend should be.
Suppose I am modelling at a weekly level and I have the results of a 6 week test in which a certain channel spend was reduced to 0. What should my pre-test spend, x, be? Is it the spend in the 6 weeks before the test or is it an averaged weekly value? Similarly, should my delta_y be a total or a weekly average?
Thanks!

I have in my mind that they are averages. They are being evaluated on the saturation curve itself so total (or sum(x)) would be in a different scale and wouldn't make sense.
I suspect the noise would just need to be adjusted accordingly. 6 week test = less variation
WDYT?

Yes, great, that makes sense to me - thanks! I guess my weekly sigma here would be total sigma divided by sqrt(6). Thanks again @wd60622 🙂

Closing this after confirming with @wd60622


Plans to support pip.conf file?

It appears (juding by strace output) that uv doesn't currently support reading pip's config files (e.g. /etc/xdg/pip/pip.conf). The feature I'm after specifically is already described in #1474 (support for the cert entry in the config file/via a cmdline flag) but I'm curious about the general stance the uv takes with reading pip's config files, and other potential users might be interested too.
Thanks a lot in advance!

I'd prefer not to read configuration files designed for other tools. Like, we should support a configuration file and configuration format, but (similar to in Ruff), I'd prefer if it's our own format, etc. Otherwise, we have to figure out how to support reading those files across multiple versions of the target tool, and support any changes they make to the format in the future.

Makes a lot of sense, and thank you for the rapid response! Looking forward to trying uv!
Happy for this issue to be closed as far as I'm concerned, though it might be worth mentioning this stance in the readme/documentation. PRs welcome?

Duplicate of #1404
I'm not sure if it makes sense to document this yet as we're still establishing our formal stance around configuration files. I appreciate the offer though!


Vendor loggregator_consumer and noaa

adapted README, as CLI doesn't use godeps anymore
explicitly vendor loggregator_consumer and noaa with gvt

fixes https://github.com/cloudfoundry/v3-cli-plugin/issues/5

@luan Thanks for merging this. My original PR contained a change to the README, which now isn't merged, was this by intention? I suppose the part in Contributing about using Godep for the CLI is outdated. Afaik, the CLI stopped using Godep some time ago.

@voelzmo As we started merging this we noticed that there were more missing dependencies and ended up dropping the ball on actually merging the PR. Sorry about that. So because of it your README changes ended up getting lost.
I've applied those here.
Thanks,
Luan

Billing


[BUG/AC-Link] - Search Functionality doesn't work properly

Issue: https://github.com/azerothcore/wiki/issues/1019

Describe the bug
Go to any page in the wiki.
Example: game_tele
And try searching majority of wiki content as example Item Template or even more precise item_template
You will get all the results but none that matches to your search.

To reproduce

Go to any page in the wiki.

Example: game_tele

And try searching majority of wiki content as example Item Template or even more precise item_template

You will get all the results but none that matches to your search.

Expected behavior
To partially get my result.
Screenshots

Desktop
Windows 10 64bit, Chrome 130 64bit
Smartphone
N/A
Additional context
No response

This issue has been Linked to https://github.com/Drassil/git-wiki-theme/issues

This wiki offers 3 different kinds of search mechanisms:

GitHub (just the normal GitHub search that looks for the MD files)
google ((the google search console that uses google, but it's not real-time)
pre-compiled javascript (this is the current one)

This is a static wiki hence we can't use a server to search.
That said, I tried this query (game_tele):

As you can see the page is in the list but down the list. In your case it's probably also part of the results but since the list is limited, it doesn't show up.
We can do 2 things:

having a list that can be scrolled
trying to order by page title first and then the content

WDYT?

I think it would be a good change yea

The chat below refering to page loadings decently slowly (on my case pc and mobile) and others (mobile).
js_rss causes this above (and whats talked in the chat below) we reverted back to js and is working fine again.
https://discord.com/channels/217589275766685707/800670768840441876/1317749928293826622


Added nullability

Added soft type generics
Reduced  header imports
Early opt out in long init method to reduce indentation

Hi Saren,
Thanks for the PR.
Just to let you know, I just proposed a new version to the team heavily based on your work, it should be approved quickly which will allow me to close this.

Thank you for the update. Looking forward to it.

1.4.0 is the new deployer version taking into account your suggestions.
Thanks again.


support for new colors

New color assets and update to playerColors file

Some systems can substitute 🍌 :banana: emoji for the banana color. May need to namespace the emoji in order to get consistent results.


pip-audit: 2.4.10 -> 2.4.11

Diff: https://github.com/trailofbits/pip-audit/compare/refs/tags/v2.4.10...v2.4.11
Changelog: https://github.com/pypa/pip-audit/releases/tag/v2.4.11
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 208240 run on x86_64-linux 1

1 package built:

pip-audit


Global settings for access mixins

In a project, we usually have a global way of handling accesses in views.
The problem with access current access mixins, we need to configure raise_exception, redirect_unanthenticated_users and other mixins settings in the view class.
If I'm not wrong, their is two way of having the same settings on all views:

create our own AccessMixins with those attribute set to our required values.
set those settings in each views.

In one of my project, I had a huge number of views I needed to re-configure access for.
I think we need to have some globals settings that should be set to configure access mixins default attribute values. For exemple:
# file: settings.py

BRACES = {
    'access_raise_exception': True,
    'redirect_unauthenticated_users': True,
}

This issue seems misplaced in this project. Shouldn't you post this to https://github.com/brack3t/django-braces/ ?


Custom Task Pane is instantiated but never visible.

The instructions on this page will instantiate an instance of a custom task pane.  However, it is never visible.  The code on this page does not work for Excel 2016.  I am currently working through some of the articles on Stack Overflow. This seems to indicate that the parent window for a custom task pane should be the ribbon.  The examples that seem to produce visible task panes are not instantiated in the ThisAddIn class.
This page on the Microsoft website has generated a number of "Custom task pane not visible" posts across multiple sites.  It would be helpful if this page were corrected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac3dc600-a693-5c35-e800-80c4b2f28595
Version Independent ID: 443b8496-77a2-1b0d-b4fa-c9a5b6897728
Content: How to: Add a custom task pane to an application - Visual Studio
Content Source: docs/vsto/how-to-add-a-custom-task-pane-to-an-application.md
Product: visual-studio-windows
Technology: office-development
GitHub Login: @John-Hart
Microsoft Alias: johnhart

@CLIRResearch Thank you for bringint this to our attention.
Assigning this to the author for further review.

The code to instantiate a custom task pane should be instantiated in an OnWindowActivate handler.  The Workbook associated with the custom task pane is still null in the ThisAddIn_Startup event handler.  The Custom Task Pane will be instantiated but not visible.

VSTOTaskPane.zip
Can you build this project and  see if it can open a custom task pane in Excel?

Hi Yaqi - I will give this a try. However, this looks like the same code that is in the on-line documentation.  This instantiates a task pane but the task pane is not visible.  The Workbook window that the task pane is associated with is null in the ThisAddIn_Startup event.  The task pane will be instantiated but not visible.  You can programmatically set the task pane visible property from the ribbon bar and watch this in the debugger.  However, this has no effect on the visibility of the task pane.

Yes, the code is the same as in the documentation, and it works for me. See attached image. If it does not work, in Excel, press ALT+F10, does it display a Task Pane with a title "Selection"?

If that project does not work, try this one,
VSTOTaskPaneMultiDoc.zip
I modifed it from the first project to make the task pane work for all instances of Excel files. The first project will only show the task pane for the first Excel file.

@CLIRResearch if the suggestion @yaqiyang made does not solve your problem I recommend sending us feedback via the Help->Send Feedback->Report a Problem menu in Visual Studio.  Just mention VSTO in the title and it will be routed to us.  It will be much easier to help you that way so I'm going to go ahead and close this issue.

Thank you, I will take a look at the VSTOTaskPanelMultiDoc solution.

Thank you, I will take a look at the VSTOTaskPanelMultiDoc solution.

Thank you, I will take a look at the VSTOTaskPanelMultiDoc solution.

Thank you, I will take a look at the VSTOTaskPanelMultiDoc solution.

Thank you, I will take a look at the VSTOTaskPanelMultiDoc solution.


make SEI single layer only

Description
Remove the double-layer SEI and make it single layer only
This PR falls in the category of "breaking changes to the parameter names" so let's discuss how to handle this in the developer meeting - draft only for now
Fixes #2333
Replaces #3920
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

We should probably merge this one before #4394 (tagging @kawaMANMI so he is aware of this PR).

Hi @DrSOKane! Thanks for the comments, I hadn't realised that U_outer was actually never used and I also didn't realised that your parameter sets were used with models that only use U_sei. I thought they used the inner and outer models, hence my confusion.
I have also noticed that diffusivity is defined to 2.5000000000000002e-22, which probably resulted from copy pasting from some other code. I will chop them to 2 significant digits.

I made this a draft to keep it from being merged accidentally

@valentinsulzer Removing the skip-release tag now


Users get wrong creator id

For some reason users are created with wrong creator id. Means users do not have own id as creatorId. For now i don't know where the wrong creatorId comes from.
The most strange thing is that these creatorId's are not know to the system. There are no entities with these id's

https://github.com/FraunhoferISST/diva/blob/d5edd4e1f0f07494d37621b22c008dd803d99cf8/core/services/entity-management/services/UsersService.js#L10
maybe we send an x-actorid even if we shouldn't ?

@DaTebe we actually always send an x-actorid. The question is rather where the wrong id comes from. On the first login (register) we are making a PUT request and the x-actorid should be taken from the Keycloak user. It seems that on this path something goes wrong.

we actually always send an x-actorid

That sounds odd. We don't have an id when a user can register by himself. Seems our code does support omitting an x-actorid.

the bug comes from this line:
https://github.com/FraunhoferISST/diva/blob/6c67ef483b6bf54502b12442919ca05234ffe852/core/services/entity-management/services/UsersService.js#L8
Just remove the creatorId field as we do not use it anymore!


Analysis server sends Analyzing=true frequently during flutter builds

In Dart Code we show "Analyzing..." in the status bar whenever the analysis server says it's analyzing. I noticed it flickers a lot during Flutter builds, even though (at least as far as the user is concerned) nothing is changing.
Would it simple/reasonable to avoid sending these when modifications on disk are unrelated?
Here's an example snippet from the instrumentation log:
1512584383484:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/Flutter.framework/Info.plist:modify
1512584383484:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/App.framework/_CodeSignature/CodeResources:modify
1512584383485:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/App.framework/App:modify
1512584383485:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/App.framework/Info.plist:modify
1512584383485:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/url_launcher.framework/_CodeSignature/CodeResources:modify
1512584383485:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/url_launcher.framework/url_launcher:modify
1512584383485:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Frameworks/url_launcher.framework/Info.plist:modify
1512584383489:Noti:{"event"::"server.status","params"::{"analysis"::{"isAnalyzing"::false}}}
1512584383581:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/AppIcon20x20~ipad.png:modify
1512584383581:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/AppIcon20x20@2x~ipad.png:modify
1512584383582:Noti:{"event"::"server.status","params"::{"analysis"::{"isAnalyzing"::true}}}
1512584383582:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/Info.plist:modify
1512584383582:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/PkgInfo:modify
1512584383582:Watch:/Users/danny/Dev/Testing/flutter_gallery:/Users/danny/Dev/Testing/flutter_gallery/build/ios/iphonesimulator/Runner.app/AppIcon76x76~ipad.png:modify
1512584383584:Noti:{"event"::"server.status","params"::{"analysis"::{"isAnalyzing"::false}}}

I don't know if the files listed here are what triggered it, or whether it was before this (the log is quite long) but lmk if you need more info I can dig further.
(cc @bwilkerson)

I believe we de-bouncing the notifications a bit in IntelliJ - which is why we don't see this - but it seems reasonable to not send notifications until we hit a file which might need analysis.

Now you mention it, Dart Code does the same so not sure why I'm seeing this. I'll do some digging.
I think it'll still be good to filter these out (stuff improved in the analyzer avoids work by all clients) but if there's just something wrong with our debounce code it should be easily fixable in Dart Code.

Ok, here's why I still see it:
[20:07:35.350]: <== {"event":"server.status","params":{"analysis":{"isAnalyzing":false}}}
[20:07:41.857]: <== {"event":"analysis.flushResults","params":{"files":["/Users/danny/Dev/Google/flutter/examples/stocks/build/flx/LICENSE"]}}
[20:07:41.857]: <== {"event":"analysis.flushResults","params":{"files":["/Users/danny/Dev/Google/flutter/examples/stocks/build/flx/AssetManifest.json"]}}
[20:07:41.858]: <== {"event":"server.status","params":{"analysis":{"isAnalyzing":true}}}
[20:07:42.409]: <== {"event":"analysis.flushResults","params":{"files":["/Users/danny/Dev/Google/flutter/examples/stocks/build/flx/FontManifest.json"]}}
[20:07:42.409]: <== {"event":"analysis.flushResults","params":{"files":["/Users/danny/Dev/Google/flutter/examples/stocks/build/flx/fonts/MaterialIcons-Regular.ttf"]}}
[20:07:43.531]: <== {"event":"server.status","params":{"analysis":{"isAnalyzing":false}}}

The timestamps on the last true/false are [20:07:41.858] and [20:07:43.531]. We're only debouncing at 250ms so this (almost two seconds) still causes the flicker.
I'm running this on my MacBook. It might not be the most powerful dev machine but this probably also isn't the biggest Flutter app I'm building (Stocks example). I might increase the timeout to 500ms-1s (I don't think below that it's particularly useful to the user) but obviously it'll still occur a little (for me on this machine, at least).
Still, I don't consider this hugely important; it's just a minor annoyance (mainly because when we're building Flutter apps there is other text in the status bar, and the two labels together look wonky!). If it bugs me enough, I'll see if I can easily suppress the analyzing ones while the other is visible (or, if this change isn't difficult and you can point me in the right direction, I can take a stab).

Yeah, likely some work on our side. I think we shouldn't be sending analysis.flushResults notifications for files we haven't previously sent notifications for, and we likely should send notifications for files we're never going to analyze (like ttf files).

Is this something I could easily do? It bugs me that our status bar shows two things during build (Analyzing... and the build progress) but fixing on my side will be a kludge!

Sorry for the delay in responding.
The instrumentation log doesn't explain why server is switching state to analyzing and back. It should be ignoring watch events for anything other than .dart or .yaml files, and I don't see those in the log.
Not knowing what's causing this, I don't know how easy it will be for anyone to fix. I suppose I would probably start by writing a test to try to reproduce the behavior. Without a way to reproduce it it will probably be fairly difficult to fix.

I think I found two causes!
In Driver there's a driver.hasFilesToAnalyze that checks _fileTracker.hasChangedFiles which checks a hashset it's keeping of files. That hashset contains files we don't want to analyze. Here's a stack of where they're added:
Adding file m:\Coding\Applications\flutter\examples\flutter_gallery\ios\Runner\GeneratedPluginRegistrant.m to changed files
#0      FileTracker.changeFile (package:analyzer/src/dart/analysis/file_tracker.dart:169:39)
#1      AnalysisDriver._changeFile (package:analyzer/src/dart/analysis/driver.dart:1119:18)
#2      AnalysisDriver.changeFile (package:analyzer/src/dart/analysis/driver.dart:567:5)
#3      ContextManagerImpl._handleWatchEventImpl (package:analysis_server/src/context_manager.dart:1479:18)
#4      ContextManagerImpl._handleWatchEvent (package:analysis_server/src/context_manager.dart:1356:5)
#5      _rootRunUnary (dart:async/zone.dart:1134)

Looking inside _handleWatchEventImpl in context_manager.dart there is some code handling adds that looks like:
if (resource is File) {
  File file = resource;
  if (_shouldFileBeAnalyzed(file)) {
    info.analysisDriver.addFile(path);
  }
}

Note the call to _shouldFileBeAnalyzed. However the code for modify is just:
case ChangeType.MODIFY:
  for (AnalysisDriver driver in driverMap.values) {
    driver.changeFile(path);
  }
  break;

So, I think cause 1 is that we're not checking files should be analyzed if they're modified. I think a fix would be wrapped the loop with:
Resource resource = resourceProvider.getResource(path);
if (resource is File) {
  File file = resource;
  if (_shouldFileBeAnalyzed(file)) {

(Note: as well as adding _shouldFileBeAnalyzed here, this is also adding a file check which doesn't exist before - I don't know if that's correct).
So, I changed that locally anyway and I still saw the issue (though on a smaller scale). So, I added some more logging and found:
+++ Analyzing.
	Adding file m:\Coding\Applications\flutter\examples\flutter_gallery\build\app\intermediates\assets\debug\flutter_assets\lib\gallery\example_code.dart to changed files
--- Analyzing in 740 ms.

So in this case, it is a dart file which is deployed as part of the build (it's the flutter gallery app which ships example code in a dart file into the app to show the user how things were achieved):
flutter:
  assets:
    - lib/gallery/example_code.dart

So, I'm not sure how that one can be fixed without some sort of assumption about the build folder.
@bwilkerson If the above to the file modification watching looks good, lmk and I'll submit a review for it. The second issue I'm not sure what you want to do - it's a complete fluke I happened to test with a project that has .dart files in its output. The impact here is much less (this is very unlikely), though I don't know if it's a waste of resources (or may result in sending errors to the editor) that we don't want.

The file modification looks good to me. Please add scheglov@ to the review; he's more familiar with this code than I am.
As for the other, I don't want to have an assumption about the build directory, but if it's a standard output location for Flutter apps, then it seems like we ought to handle it automatically. Is it always named build, or is it configurable?
(A short term work around would be for users to explicitly ignore the directory in the analysis options file.)

It is the standard output location for flutter; it's not configurable. I'm not sure how I feel about hardcoding knowledge about build/ either, but will note that it's also the output location that pub build uses.

I suppose for Flutter, we could add an "excludes" list that contains build (to the analysis options file) when generating a new project, but that will only help people that use flutter to create new projects. It won't help other Flutter uses, nor pub build users.
But if we hardcode the handling of build and have users that have non-generated code in build, then we'd stop analyzing it, with no way for them to work around it. And a unlikely as those conditions seem, we thought the same thing about users having a directory named packages and we saw that happen.

The file modification looks good to me

Cool; I'll try and put a failing test in first so this is covered. I can see a somewhat related test test_watch_modifyFile which is marked TODO without an assert so I'll see if I can make that work and then copy/adapt for this.

And a unlikely as those conditions seem, we thought the same thing about users having a directory named packages and we saw that happen.

Yeah, let's at least fix that one before we replace it with another :D
I have no strong opinion on this; I'm not concerned about it for the original issue (few people will have Dart files in their Flutter build output) but I don't know of other implications of it analysing build output, you two are much better positioned to decide than I. (Though I reserve the right to become upset about it if/when we one day have pub build in Dart Code ;-))

But if we hardcode the handling of build and have users that have non-generated code in build

Flutter does manage the build/ dir, and will delete content out of it (and, flutter clean will delete it completely). So, the problem of non-generated code in build will self-correct periodically :)

Minor edit:
So, the problem of non-generated code in {the build directory of a flutter package} will self-correct periodically.
If we can identify which packages are Flutter packages (such as by looking for a dependency on flutter), then we could use that to solve one part of the issue.
Is there a similar technique we can use to identify a package that is using pub build?

Not sure re: auto-detection, however, some options I can think of to address reacting to changes in the build/ folder:

just categorically ignore them for dart projects (hard-code awareness in the analysis server)
add an analysis_options file to the flutter create template (https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/create) which ignores build/ by default. This will address the issue for new projects going forward (but does not speak to existing projects).

I've fixed the issue with non-Dart files trigger this in https://dart-review.googlesource.com/c/sdk/+/44421/
Do you want this case keeping open (or perhaps another creating?) for the build output folders?


[IOTDB-68] New shared-nothing cluster

RaftMember.java
Now we have to send request to all nodes and wait for quorum nodes responses. then we can commit the log.
How about:

guarantee there is only one connection between two nodes.
The leader can send the second req to a node after the first req is sent to the node.
However, the leader can commit log index i until i-1 is committed.

PartitionGroup  extends ArrayList is a little heavy..
an array is enough.

The remaining code smells are duplicated code blocks caused by single inheritence in Java, and there are currently no elegant way to fix them.

Though there are many works left to do for this issue, I have to say you have reached a good milestone. So, I will merge this PR tonight.
Nice work, guys!


How to access DeviceInformation Properties

Referencing this documentation:
https://docs.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation
Trying to get as much info about USB devices as possible.
  onUpdated = (unknown, devUpdate) => {
    const { id, name, kind, properties } = devUpdate;
    const displayName = properties['System.ItemNameDisplay'];
    const gguid = properties['System.Devices.InterfaceClassGuid'];
...

both displayName and gguid are undefined. I've tried everything I can think of... :) How do I access a the properties on a DeviceInformation properties (IReadOnlyDictionary)?
This doesn't have much information:
https://github.com/MicrosoftDocs/winrt-api/blob/9f0afc2b220dde46cd2cf6f117135f3b4c7d1cf5/windows.devices.enumeration/deviceinformation_properties.md
A few other questions:

What is the type of "unknown" in above code snippet?
When I JSON.stringify or console.log a winrt object I always get "winRtInstance". Is there a better way to inspect an object for the class so I can lookup proper documentation?

Thanks!

Hi @semireg. The DeviceInformation.Properties property contains a dictionary of key/value pairs, where the key for a given property can be one of many types of strings as described in Device information properties.
It doesn't look like the code example you provided is coming directly from our docs. I tried the C# example in the DeviceInformation article and confirmed I can successfully retrieve the "System.ItemNameDisplay" property with the following additional code (for example, "Intel(R) Display Audio Mixer 6.1").
 object name = null;
 deviceInterface.Properties.TryGetValue("System.ItemNameDisplay", out name);
if (name != null)
{
     string nameValue = name as string;
}

In your code example, it appears that you are defining a handler for the DeviceWatcher.Updated event. Therefore, the "unknown" parameter is a DeviceWatcher object, as per the event handler definition.
Because it appears you are asking for technical assistance rather than providing direct feedback against the existing docs, I'm closing this issue for now because this docs repo is not a support channel. If you require further technical assistance, you might ask on our forums or StackOverflow. See this page for your support options.

@mcleanbyron, thank you for replying. I am providing feedback. The docs are missing equivalent code in JavaScript.
How do I access a the properties on a DeviceInformation properties (IReadOnlyDictionary) in JavaScript?
When I try using this code I get "tryGetValue is not a function"
properties.tryGetValue('System.ItemNameDisplay')

So it seems to be different than C#, but I'm unsure how, because I don't know how to inspect the JavaScript API.
How does one use tryGetValue in JavaScript?

Sorry about that - At a glance I didn't realize you had a JavaScript example. I'm not very experienced with JavaScript, but it's possible that TryGetValue is a .NET method and isn't available for this dictionary collection from JavaScript. That said, I was using it as a convenience only. You should still be able to access the property directly from the collection by the key, assuming the property you're querying for exists.
I just tried out the Device enumeration and pairing example and add the following line of code to the onAdded function in scenario2_devicewatcher.js:
var name = deviceInfo.properties['System.ItemNameDisplay'];

When I run the code I can successfully retrieve the display name for devices on my computer.

It's all good. I should have disclosed JS from the start. I just assumed. 😄
My properties dict is still not responding to any keys, but again, I don't know how to tell that object to show me all of its keys.
I'm creating the watcher with this.watcher = WindowsDevicesEnumeration.DeviceInformation.createWatcher(); ... maybe the results from this don't have the same (any?) property keys?
I wish there were an easy way to ask the properties object to give me all the known keys. Does that kind of method exist?

I'm sorry the code isn't working for you. Have you tried the JavaScript sample I referred to in my previous reply?
In a .NET language such as C#, you can loop through the Keys property of the DeviceInformation.Properties object to see what property keys are in the collection that you retrieve. I'm not sure if or how this can be done from JavaScript, which I'm unfortunately not very familiar with.
As documented in Device information properties, these keys correspond to underlying IDs defined by the Windows OS (such as "System.Devices.ContainerId"). These IDs are listed in articles under this node in the Windows docs.

Oh, it's working, it's just that properties object that's being a bit unclear. In JavaScript the way keys are accessed is using something like const keys = Object.keys(properties); However, like I've mentioned above, this only results in ["__winRtInstance__"] which his a bit useless. That's why I assumed there was an accessor hidden somewhere in the API, but nothing I've tried seems to work the way I'd expect.


[Table]: Export example tableState Reducers to reuse by external teams that might want to link to Redux

export tableState Reducers

:tada: This issue has been resolved in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.16.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Localization/spelling fix

Addresses issue #106. "Harbour" appears to be appropriate Canadian usage. (nb: I'm not Canadian.) I only found one instance of "harbor" to change.

Thank-you!


division by zero when menu's size equal 1

Sorry for that. I fixed it.
https://github.com/pixyzehn/PathMenu/commit/6094d78dfd154bcb092374a7b3fced717d7d90e3


Allow service principals with double-quote (") and backslash ()

This fixes an issue when passwords contain JSON special chars like " and \
Fixes #3038

/lgtm pending E2E

@CecileRobertMichon Fixed :)

/lgtm
oops

/lgtm


feat: add automation support for pairwise memory separation

This is stacked on top of #123 , since we want to state this, for a given ms : List MemoryRegion, ms.pairwise MemoryRegion.Separate. This, of course, needs us to have the MemoryRegion abstraction in the first place.

@bollu  Conflicts here.

@shigoel conflicts addressed!

Left some comments, looks good in general.
We need more tests for the new pairwise construct (in a PR in the very near future is okay!) -- let's start with changing theorems in the SHA512 example to use pairwise, and then we'll go from there?

@shigoel all comments addressed.

@bollu I see that a couple comments weren't addressed. Tagged you there.

@shigoel All comments (hopefully) addressed.

@shigoel happy to have this merged, as I prefer keeping the current around to build the SimpContext around.


Queue Deadlock error

Laravel Version: 5.6
PHP Version: 7.2
Database Driver & Version: MySQL & 5.6

Description:
Queue deadlock error when using database and 8 processes.
Error: SQLSTATE[40001]: Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction (SQL: delete from jobs where id = 34)
Steps To Reproduce:
Executing queues with 8 processes sometimes raises an error for deadlock.

Can you show us the table structure of the jobs table?

Taylor has consistency said that Database Queue driver is not suited to large queue processes, for this exact reason.
You'll need to switch to Redis or Beanstalkd etc for a proper queue system.

I believe this issue is there for the jobs which take long time to process i.e. 10 hours, 11 hours etc.
Is this something we can handle?
I have tried setting the TTR to 172800 i.e. 48 hours.

@xyrintech I asked for the table structure of your jobs table, can you provide it?
Can you also tell us if you've setup a separate connection in config/database.php for the queue, or using the default one?

PFA

Its a default database connection.
I tried with beanstalkd and same issue with this well.

Are you sure you get the same error when using beanstalkd? It doesn't make sense to get a sql error when using beanstalkd...
Can you export the structure as a CREATE TABLE statement? I'm not sure how to read the existing index information from phpmyadmin.

php artisan queue:table - use this command and this is gonna give you the same structure :)

I tried https://github.com/ph4r05/laravel-queue-database-ph4 and getting one issue with this. This is the one -
https://github.com/ph4r05/laravel-queue-database-ph4/issues/5

Please share the bugsnag details, it sounds really wonky to get this sql error from beanstalkd.
I asked about a CREATE TABLE statement. There is a purpose behind that. If I run the job without a custom string-length setup, then I would get another column length (and not 191). You have also not given us the exact Laravel version you're using.
An obvious attempt at a fix would be to move the queue system to a separate connection so that any transactions caused by the job or your application code does not affect the queue.
Next time you get the deadlock, get back to us with 1) a CREATE TABLE jobs ... statement to reproduce the structure, 2) the output of SHOW ENGINE innodb STATUS, and the exact Laravel version you're on.
I cannot help you further without these three pieces of information.

I'm going to close this issue. It's outside the scope of what Taylor has previously said is supported.
Although I can see in this thread some potential to solve the problem, but then it's more suited to the Laravel/Ideas area.


Basic README needed

Need to create basic README file to describe OxyEngine.

If somebody wants to help with this - please comment here or contact me

Basic README done


Delete margin for HBox and VBox

The margin causes a lot of extra padding as these boxes are nested deeply.

In 5.x, these values were set so that alignment of naturally sized widgets would be preserved. Is it the case here?

In 5.x, these values were set so that alignment of naturally sized widgets would be preserved. Is it the case here?

Do you have a code sample to test this?
The problem I noticed is that, for example, if you have an HBox that has both a VBox containing a widget and another widget, the widget inside the vbox is not aligned with the widget outside the vbox, since there is an extra margin. I remember us discussing having padding on boxes and deciding to eliminate it precisely because boxes are often deeply nested for building complicated UIs, and every level of nesting adds some padding.

The problem I noticed is that, for example, if you have an HBox that has both a VBox containing a widget and another widget, the widget inside the vbox is not aligned with the widget outside the vbox, since there is an extra margin. I remember us discussing having padding on boxes and deciding to eliminate it precisely because boxes are often deeply nested for building complicated UIs, and every level of nesting adds some padding.

It is not the case in 5.x. Maybe it broke since.


Please clarify that this is for Linux containers

File: engine/reference/commandline/checkpoint.md
on my Windows environment, i get this error message when using Windows containers
Tested with both CE and EE versions
C:\Users\DockerJ>docker checkpoint create Tester checkpoint1 Error response from daemon: Cannot checkpoint container Tester: Windows: Containers do not support checkpoints

@jasonbivins , two questions:

Are you using API version 1.25 or higher? Run docker version.
Do you have experimental set to true? See https://docs.docker.com/docker-for-windows/#daemon

My guess is that you have experimental set to off. See the top of the checkpoint page for caveats.

@gbarr01    I checked that before I posted :)
`C:\Users\Administrator>docker version
Client:
Version:       17.06.2-ee-11
API version:   1.30
Go version:    go1.8.7
Git commit:    06fc007
Built: Thu May 17 06:14:39 2018
OS/Arch:       windows/amd64
Server:
Engine:
Version:      17.06.2-ee-11
API version:  1.30 (minimum version 1.24)
Go version:   go1.8.7
Git commit:   06fc007
Built:        Thu May 17 06:17:26 2018
OS/Arch:      windows/amd64
Experimental: true
`

Oh hang on, I see. You are using Windows containers. Sorry about that. I need to think about how best to handle the docs. Editing the CLI reference docs is probably not the best solution.

Is there a better place to send requests like this?

Not necessarily. We need to clarify CLI limitations (if they exist) for Windows containers. But if you need help now, you could ask on the Docker forums or Stackoverflow, of course.

@thaJeztah , @gtardif , do you know about CLI limitations for Windows containers?

In this case, it's an experimental feature that uses CRIU, which is a Linux only feature.
Not related to the Windows side of things, but checkpoint/restore currently has some issues due to the migration to containerd, and will get a major overhaul in future.
What should be done though, is that the CLI hides these commands if the daemon is running on Windows; I think we do so for some other commands (likely we didn't do that yet when this feature was implemented)

Opened https://github.com/docker/cli/pull/1094 to address this

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Unstable merge: asset library with transparent compression, plus a stream of small changes

This PR imports the asset library from the unstable branch. This is the subject of the first half of commits.
The asset library allows to load binary files from any filesystem with transparent compression, and is the basis of all data files management in the unstable branch, which is in fact compressed.
Compression works by wrapping a data file (think gzip), so asset_load() will transparently decompress it while loading it into RDRAM. Moreover, asset_fopen() uses some libc magic to create a FILE* that transparently decompresses while reading, to allow compressing data files that need to be parsed at runtime.
There are two compression levels at the moment:

Level 1 is based on LZ4, which features incredible fast decompression speed with decent compression ratios. It is so fast that it's actually faster to load and decompress a compressed file, rather than loading it uncompressed (!). On the unstable branch, we compress all assets by default with level 1 because of this.
Level 2 is based on LZH5, part of the LHA family. It offers better-than-gzip ratios on small files, with a slower decompression. The decompressor is based on open source code that has been optimized for N64, but it's still not as fast as it could. Specifically, the Huffman decompression is still made bitwise rather than bytewise and could use some speed up.

To compress a binary file, the user can use the new tool mkasset. In the future, asset-generating tools (like the new version of mksprite) will transparently offer compression capabilities.
See this table for more data (c0 = uncompress, c1 = lz4, c2 = lzh5)
File                        : KiB  | Ratio   | Load+Dec (ms)
--------------------------------------------------------------
fc_200-fs8.sprite.c0        :   31 |  100.0% |     11.4
fc_200-fs8.sprite.c1        :   31 |   32.9% |      5.9
fc_200-fs8.sprite.c2        :   31 |   25.7% |     19.6
font.sprite.c0              :   22 |  100.0% |      7.8
font.sprite.c1              :   22 |   19.8% |      4.1
font.sprite.c2              :   22 |   14.4% |      9.4
hoi-fs8.sprite.c0           :  125 |  100.0% |     41.1
hoi-fs8.sprite.c1           :  125 |   11.5% |     14.3
hoi-fs8.sprite.c2           :  125 |    8.9% |     29.3
lens_64-fs8.sprite.c0       :   16 |  100.0% |      7.1
lens_64-fs8.sprite.c1       :   16 |   26.7% |      4.4
lens_64-fs8.sprite.c2       :   16 |   23.8% |      9.4
lenspic_256-fs8.sprite.c0   :   64 |  100.0% |     22.0
lenspic_256-fs8.sprite.c1   :   64 |   50.5% |     10.5
lenspic_256-fs8.sprite.c2   :   64 |   44.2% |     58.2
prax4.fli.c0                :  327 |  100.0% |    104.5
prax4.fli.c1                :  327 |   63.2% |     85.7
prax4.fli.c2                :  327 |   51.2% |    316.9
room_normal.ci8.sprite.c0   :  125 |  100.0% |     41.6
room_normal.ci8.sprite.c1   :  125 |   31.7% |     19.2
room_normal.ci8.sprite.c2   :  125 |   26.5% |     67.2
srtitle400-fs8.sprite.c0    :  125 |  100.0% |     40.9
srtitle400-fs8.sprite.c1    :  125 |   28.6% |     18.4
srtitle400-fs8.sprite.c2    :  125 |   22.9% |     60.8
troll-fs8.sprite.c0         :  125 |  100.0% |     41.9
troll-fs8.sprite.c1         :  125 |   32.6% |     25.1
troll-fs8.sprite.c2         :  125 |   24.7% |     61.5

The rest of the PR is a stream of small semi-obvious commits that just minimizes the differences with unstable.

Added also the new API asset_init_compression() as discussed on Discord, to avoid linking all compression levels unless really necessary.


python buildEnv does not work for python packages outside of nixpkgs

Issue description
According to the manual

You can also use env attribute to create local environments with needed packages installed (somewhat comparable to virtualenv).

The example given works (if you change requests to requests2)
with import <nixpkgs> {};

(python3.buildEnv.override {
  extraLibs = with python3Packages;
    [ numpy
      requests2
    ];
}).env

However using a package that you have built yourself using buildPythonPackage does not work. nix-shell finishes successufully but you cannot run python and import the package.
Steps to reproduce
I have made a very simple python package to test this with. All it does is serve up "hello world" via http on port 8000. I probably could have done something even simpler. So to reproduce:

Create a working directory, cd into it.
Execute mkdir sources -- we want to avoid cloning the source directory into our working directory otherwise we will get a false positive during the python import test (since import trivial will work if there is a directory named "trivial" here)
Execute git clone https://code.vitrostudios.com/phil/trivial.git sources/trivial
Create a file default.nix here with the contents given below
Execute nix-shell --arg trivial_src ./sources/trivial default.nix
Execute python3.5 -c "import trivial" inside the shell environment.

default.nix contents:
{ trivial_src }:

let
  pkgs = import <nixpkgs> {};
  trivial =
    pkgs.python35Packages.buildPythonPackage {
      name = "trivial";
      src = trivial_src;
      meta = {
        homepage = "https://code.vitrostudios.com/phil/trivial";
        description = "Test python package";
      };
    };
in
(pkgs.python35.buildEnv.override {
  extraLibs =
    [
      trivial
    ];
}).env

The expected output is the command returns without failure or output.
What actually happens is this:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named 'trivial'

Technical details

System: NixOS: 16.03.1199.3234a4a (Emu)
Nix version: nix-env (Nix) 1.11.2
Nixpkgs version: 16.03.1199.3234a4a

thanks for the report @Zer0- .
I've never actually used a __main__.py file myself, so there's a good chance I am wrong here, however, I think you're confusing __main__.py and __init__.py.
You're using __main__.py in which case you want to execute a module, and thus you need to use the -m flag when calling python.
Second, in your __main__.py you want to import from trivial.application. If there is no __main__.py inside your package that contains import trivial.application there is no way it can find that module.
If you make those changes, and also set doCheck = false; in the build expression of your package (unrelated issue) it will work.

If there is no init.py inside your package that contains import trivial.application there is no way it can find that module

Crap you're right!

@Zer0- I guess you accidentally reopened it so I am closing it now again.

@FRidh You're totally correct about needing a init.py file and that worked for me. I have edited the trivial repo to include it. There is still something weird going on though, I hope it's just an error on my part.
If you split the build process into two steps, first a step using nix-build and a second step to launch the nix-shell with a python environment, then the import fails.
So modifying my opening post's steps, changing default.nix contents to be:
{ trivial_src }:

let
  pkgs = import <nixpkgs> {};
  jobs = {
    trivial =
      pkgs.python35Packages.buildPythonPackage {
        name = "trivial";
        src = trivial_src;
        doCheck = false;
        meta = {
          homepage = "https://code.vitrostudios.com/phil/trivial";
          description = "Test python package";
        };
      };
  };
in jobs

and also creating a shell.nix file with the contents:
{ trivial }:

let
  pkgs = import <nixpkgs> {};
in
(pkgs.python35.buildEnv.override {
  extraLibs =
    [
      trivial
    ];
}).env

If I execute nix-build --arg trivial_src ./sources/trivial default.nix I get path to the store as an output.
Then I launch the shell with nix-shell --arg trivial <store path from earlier step> shell.nix
and execute python3.5 -m trivial as you said, the command still fails. Same with launching python and importing trivial, which as far as I know would work if I was using virtualenv.
Of course the difference here is I am passing the value for extraLibs through the nix-shell command line versus it being defined in the same nix expression. So that must be the root of the problem.
Sorry to bother you and reopen this, but I cannot figure it out.

You're totally correct about needing a init.py file

its a init.py , not init.py. I did see you updated the repo correctly.

Then I launch the shell with nix-shell --arg trivial  shell.nix
and execute python3.5 -m trivial as you said, the command still fails.

nix-shell -p /nix/store/qjznavzsh5c6gg1p22lb1a2ihky7xyk0-python3.5-trivial gives you a working shell with the package, not the env. So building the trivial package is at least working correctly.
But, you want the environment in a nix-shell, and by passing the store path. Well, that doesn't seem to be working as you've shown so let's try to find out why.
I put the expressions and source path together into one shell.nix file.
$ cat shell.nix

let
  pkgs = import <nixpkgs> {};
  trivial =
      pkgs.python35Packages.buildPythonPackage {
        name = "trivial";
        src = ./sources/trivial;
        doCheck = false;
        meta = {
          homepage = "https://code.vitrostudios.com/phil/trivial";
          description = "Test python package";
        };
      };
in
(pkgs.python35.buildEnv.override {
  extraLibs =
    [
      trivial
    ];
}).env

Running nix-shell --run "python3 -m trivial" gives you the application. So that works.
I have no idea why this isn't working actually. It seems as trivial is passed, since otherwise there should have been an error, but then again, it doesn't actually do anything with it.

actually, I think trivial is considered a string here, and in buildEnv it filters on derivations, so it is ignored.

Furthermore, why would that work. Its just a path that happens to be a store path. But Nix doesn't know that right, to Nix it can be any path. Also, it likely would need the .drv because it cannot determine from just a hash what was needed to build it. But, it can at least check for the .drv in the store. @copumpkin , do you have an idea? Can you pass a store path with --arg and use it as a derivation?

You can pass a store path to at least build things. For example if I were to make a package that depends on trivial (needs trivial in its propagatedBuildInputs list) then I can pass the store path to trivial as an --arg to nix-build and it works. So I assumed this was a valid workflow.

I think the questions have been answered. Feel free to reopen, though.


Syntax highlighting is lost on buffers that haven't yet been viewed when starting server

If you open Neovim with multiple Lisp files (whether from a bunch of arguments, loading a saved session, whatever), then if you launch a server or connect to an existing server, syntax highlighting is lost on all files that haven't been viewed yet.  Other filetype-specific functions like autocompletion and Vlime's hotkeys still work.  Things relating to color but not necessarily syntax highlighting like rainbow parentheses are also affected.
The only way to restore syntax highlighting is to manually run set filetype=lisp in all the affected buffers, even though the filetype was already correctly displayed as lisp.  :bufdo set filetype=lisp either before or after starting the server does not fix it either, each buffer must be individually visited and have the command run manually.  syntax sync fromstart does not help.
The files must have been actually displayed on the screen for a non-negligible period of time to not be affected, not even something like :bufdo e prior to connecting prevents it.
Reproducible using a stock Neovim v0.10.2 install (and empirically previous versions), minimally with this vimrc:
source ~/.local/share/nvim/site/autoload/plug.vim

call plug#begin()
Plug 'vlime/vlime', {'rtp': 'vim/'}
call plug#end()

And then invoked like this:
nvim --clean -u /tmp/init.vim <multiple source files>
Do not switch away from the first file, then start a new server or connect to an already running server using the hotkeys.  The first file will be highlighted like normal, but then toggling through the other files with :n, none will have syntax highlighting.  If you partially go through the opened files, the ones that were viewed prior to starting the server will be unaffected.
Demonstration

Yeah, right.
Any ideas? Would you try with nvim --cmd "set verbose=255 verbosefile=/tmp/trace.log <source files>" and see what's different for the others?

I've trawled through the logs but still haven't been able to find the root cause.  I've observed it in a few other situations unrelated to Lisp though so it's unlikely it's caused by anything vlime is doing


No module named_crop_and_resize

Hi~
I very much appreciate you made this repository publicly available to use. Before getting my hands dirtier, I tried to run ./experiments/scripts/train_faster-rcnn.sh; however, got the following error....
Traceback (most recent call last):
File "./tools/trainval_net.py", line 20, in
from nets.vgg16 import vgg16
File "/home/handsome/pycode/pytorch-faster-rcnn/tools/../lib/nets/vgg16.py", line 10, in
from nets.network import Network
File "/home/handsome/pycode/pytorch-faster-rcnn/tools/../lib/nets/network.py", line 28, in
from layer_utils.roi_align.crop_and_resize import CropAndResizeFunction
File "/home/handsome/pycode/pytorch-faster-rcnn/tools/../lib/layer_utils/roi_align/crop_and_resize.py", line 7, in
from ._ext import crop_and_resize as _backend
File "/home/handsome/pycode/pytorch-faster-rcnn/tools/../lib/layer_utils/roi_align/_ext/crop_and_resize/init.py", line 3, in
from ._crop_and_resize import lib as _lib, ffi as _ffi
ImportError: No module named _crop_and_resize
Command exited with non-zero status 1
0.82user 0.58system 0:00.95elapsed 147%CPU (0avgtext+0avgdata 201868maxresident)k
0inputs+32outputs (0major+30395minor)pagefaults 0swaps
Thank you very much !
Could you send me pre_trained model from google drive ? I could not interview that links

I guess the reason is you didn't compile the module correctly? Did you do step two without error?
The google drive link should work.

thank you very very very much


Always add proptypes import for files with mixed imports & requires

If you have a file that uses both import and require you can end up with a broken file.
Example
import React from 'react';
require('foo');

class MyClass extends React.Component {}

MyClass.propTypes = {
    foo: React.PropTypes.string
};

Before - Error: PropTypes is not defined.
import React from 'react';
require('foo');

class MyClass extends React.Component {}

MyClass.propTypes = {
    foo: PropTypes.string
};

After
import React from 'react';
import PropTypes from 'prop-types';
require('foo');

class MyClass extends React.Component {}

MyClass.propTypes = {
    foo: PropTypes.string
};

This will add a PropTypes import if there is a React import or a PropTypes require if there is a React require

Our styleguide uses sass, causing most of the repo to fall foul of this issue.
import React from 'react';
require('./my.scss');

Hey @robrichard! Nice catch (and fix!)
Unfortunately it conflicts with (ad breaks) another recent fix for alpha-sorting. I've added the code you provided above as a new test though and fixed it with PR #128!