hirak/prestissimo issue with composer v2

Please remove hirak/prestissimo dependency, composer v2 does not support it and it's not more really necessary.

Duplicate of # https://github.com/docusign/docusign-php-client/issues/123


PHP Notice not defaultValue

Test
    class User {}
    ----------------------------

    $user = new User();
    $array = [
        'foo' => [
            'bar' => $user,
        ],
        'user' => $user,
    ];
    $value = ArrayHelper::getValue($array, 'foo.bar.name');
    $username = ArrayHelper::getValue($array, 'user.username', 'Unknown');
    var_dump($username);

This change has been proposed before and has been rejected, see https://github.com/yiisoft/yii2/issues/7193#issuecomment-73287156 for reasons. Also next time please send PR against https://github.com/yiisoft/yii2 instead. This repository is a read-only subsplit.


resolves #41 - add a content script that 'hijacks' steemconnect links

Analyses the page, finds steemconnect transfer links and upon click on the links popups Steem Keychain instead.
Currently supports only transfer links until https://github.com/MattyIce/steem-keychain/issues/101 is solves for delegations
Test URL: http://steemsql.com/daily-subscription/

Added a feature toggle in the popup:

@quochuy This is amazing!!!


Add Module 1

Add Module 1
Once Module 1 has been added, mark issue as closed.

Module 1 lessons and challenge files have been pushed into main.


Scripting issues during make

Hi all, after I managed to get cmake working, make ran into some scripting issues - I guess it's because I'm working on a RedHat system which sometimes needs a special treatment. The output of make is like below. Would be great if that could be adjusted so that make succeeds. Thank you!
[  1%] Building CXX object deps/googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[  1%] Building CXX object src/smartpeak/CMakeFiles/SmartPeak.dir/source/core/CastValue.cpp.o
[  2%] Building CXX object src/smartpeak/CMakeFiles/SmartPeak.dir/source/core/ApplicationProcessor.cpp.o
[  3%] Building CXX object src/smartpeak/CMakeFiles/SmartPeak.dir/source/core/ConsoleHandler.cpp.o
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp: In member function ‘bool SmartPeak::CastValue::is_less_than(const SmartPeak::CastValue&, bool) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:217:16: error: ‘transform’ is not a member of ‘std’
std::transform(s.begin(), s_.end(), a_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:218:16: error: ‘transform’ is not a member of ‘std’
std::transform(other.s_.begin(), other.s_.end(), b_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp: In member function ‘bool SmartPeak::CastValue::is_greater_than(const SmartPeak::CastValue&, bool) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:252:14: error: ‘transform’ is not a member of ‘std’
std::transform(s_.begin(), s_.end(), a_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:253:14: error: ‘transform’ is not a member of ‘std’
std::transform(other.s_.begin(), other.s_.end(), b_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp: In member function ‘bool SmartPeak::CastValue::is_equal_to(const SmartPeak::CastValue&, bool) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:287:14: error: ‘transform’ is not a member of ‘std’
std::transform(s_.begin(), s_.end(), a_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:288:14: error: ‘transform’ is not a member of ‘std’
std::transform(other.s_.begin(), other.s_.end(), b_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp: In lambda function:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:314:16: error: ‘transform’ is not a member of ‘std’
std::transform(l.begin(), l.end(), a_lowercase.begin(), ::tolower);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/CastValue.cpp:315:16: error: ‘transform’ is not a member of ‘std’
std::transform(r.begin(), r.end(), b_lowercase.begin(), ::tolower);
^~~~~~~~~
make[2]: *** [src/smartpeak/CMakeFiles/SmartPeak.dir/build.make:90: src/smartpeak/CMakeFiles/SmartPeak.dir/source/core/CastValue.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:23:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:176:27: error: ‘RollingFileAppender’ is not a member of ‘plog’
std::shared_ptr<plog::RollingFileAppenderplog::CsvFormatter> m_file_appender;
^~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:176:27: note: suggested alternative: ‘ConsoleAppender’
std::shared_ptr<plog::RollingFileAppenderplog::CsvFormatter> m_file_appender;
^~~~~~~~~~~~~~~~~~~
ConsoleAppender
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:176:53: error: ‘CsvFormatter’ is not a member of ‘plog’
std::shared_ptr<plog::RollingFileAppenderplog::CsvFormatter> m_file_appender;
^~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:176:53: error: template argument 1 is invalid
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:176:65: error: expected unqualified-id before ‘>’ token
std::shared_ptr<plog::RollingFileAppenderplog::CsvFormatter> m_file_appender;
^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:177:49: error: ‘TxtFormatter’ is not a member of ‘plog’
std::shared_ptr<plog::ConsoleAppenderplog::TxtFormatter> m_console_appender;
^~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:177:49: error: template argument 1 is invalid
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:177:61: error: template argument 1 is invalid
std::shared_ptr<plog::ConsoleAppenderplog::TxtFormatter> m_console_appender;
^~
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationHandler.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationProcessor.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:24:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/Filenames.h:89:18: warning: class ‘SmartPeak::Filenames’ is implicitly friends with itself
friend class Filenames;
^~~~~~~~~
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/RawDataProcessor.h:27,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationHandler.h:27,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationProcessor.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:24:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/MetaDataHandler.h:125:69: warning: missing initializer for member ‘tm::tm_gmtoff’ [-Wmissing-field-initializers]
std::tm acquisition_date_and_time = { 0, 0, 0, 1, 0, 0, 0, 0, 0 }; // Need to start at Day 1 of the month
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/MetaDataHandler.h:125:69: warning: missing initializer for member ‘tm::tm_zone’ [-Wmissing-field-initializers]
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/Utilities.h:45,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:25:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::OwningStdIOByteSourceBase::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:152:50: warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion]
return std::fread(buffer, 1, size, file);
^~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::NonOwningIStreamByteSource::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:169:49: warning: conversion from ‘std::streamsize’ {aka ‘long int’} to ‘int’ may change value [-Wconversion]
return in.gcount();
~^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::NonOwningStringByteSource::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:185:62: warning: conversion from ‘long long int’ to ‘int’ may change value [-Wconversion]
to_copy_byte_count = remaining_byte_count;
^~~~~~~~~~~~
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/Utilities.h:45,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:25:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: At global scope:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:1099:22: warning: unnecessary parentheses in declaration of ‘row’ [-Wparentheses]
char*(row[column_count]);
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp: In member function ‘virtual void SmartPeak::ConsoleHandler::initialize(const string&)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:47:12: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
if (m_logdir_created) LOG_DEBUG << "Log directory created: " << m_log_filepath;
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp: In member function ‘virtual void SmartPeak::ConsoleHandler::_initialize_log_console(bool)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:111:20: error: ‘m_file_appender’ was not declared in this scope
if (nullptr == m_file_appender && init_file_appender)
^~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:111:20: note: suggested alternative: ‘init_file_appender’
if (nullptr == m_file_appender && init_file_appender)
^~~~~~~~~~~~~~~
init_file_appender
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:115:19: error: ‘RollingFileAppender’ is not a member of ‘plog’
plog::RollingFileAppenderplog::CsvFormatter>(
^~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:115:19: note: suggested alternative: ‘ConsoleAppender’
plog::RollingFileAppenderplog::CsvFormatter>(
^~~~~~~~~~~~~~~~~~~
ConsoleAppender
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:115:45: error: ‘CsvFormatter’ is not a member of ‘plog’
plog::RollingFileAppenderplog::CsvFormatter>(
^~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:116:53: warning: right operand of comma operator has no effect [-Wunused-value]
m_log_filepath.c_str(), 1024 * 1024 * 32, 100);
^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:115:57: error: invalid operands of types ‘’ and ‘int’ to binary ‘operator>’
m_file_appender = std::make_shared<
~~~~~~~~~~~~~~~~~
plog::RollingFileAppenderplog::CsvFormatter>(
^
m_log_filepath.c_str(), 1024 * 1024 * 32, 100);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:118:17: error: invalid operands of types ‘std::nullptr_t’ and ‘int’ to binary ‘operator==’
if (nullptr == m_console_appender)
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:123:50: error: ‘TxtFormatter’ is not a member of ‘plog’
plog::ColorConsoleAppenderplog::TxtFormatter>();
^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:123:50: error: template argument 1 is invalid
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:123:65: error: no matching function for call to ‘make_shared< >()’
plog::ColorConsoleAppenderplog::TxtFormatter>();
^
In file included from /usr/include/c++/8/memory:81,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:27,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:23:
/usr/include/c++/8/bits/shared_ptr.h:718:5: note: candidate: ‘template<class _Tp, class ... _Args> std::shared_ptr<_Tp> std::make_shared(_Args&& ...)’
make_shared(_Args&&... __args)
^
/usr/include/c++/8/bits/shared_ptr.h:718:5: note:   template argument deduction/substitution failed:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:123:65: error: template argument 1 is invalid
plog::ColorConsoleAppenderplog::TxtFormatter>();
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:128:45: error: ‘TxtFormatter’ is not a member of ‘plog’
plog::ConsoleAppenderplog::TxtFormatter>();
^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:128:45: error: template argument 1 is invalid
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:128:60: error: no matching function for call to ‘make_shared< >()’
plog::ConsoleAppenderplog::TxtFormatter>();
^
In file included from /usr/include/c++/8/memory:81,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ConsoleHandler.h:27,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:23:
/usr/include/c++/8/bits/shared_ptr.h:718:5: note: candidate: ‘template<class _Tp, class ... _Args> std::shared_ptr<_Tp> std::make_shared(_Args&& ...)’
make_shared(_Args&&... __args)
^
/usr/include/c++/8/bits/shared_ptr.h:718:5: note:   template argument deduction/substitution failed:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:128:60: error: template argument 1 is invalid
plog::ConsoleAppenderplog::TxtFormatter>();
^
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:131:20: error: ‘m_file_appender’ was not declared in this scope
if (nullptr == m_file_appender)
^~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:131:20: note: suggested alternative: ‘init_file_appender’
if (nullptr == m_file_appender)
^~~~~~~~~~~~~~~
init_file_appender
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:133:15: error: ‘init’ is not a member of ‘plog’
plog::init(plog::debug, m_console_appender.get());
^~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:133:15: note: suggested alternative: ‘info’
plog::init(plog::debug, m_console_appender.get());
^~~~
info
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:133:52: error: request for member ‘get’ in ‘((SmartPeak::ConsoleHandler*)this)->SmartPeak::ConsoleHandler::m_console_appender’, which is of non-class type ‘int’
plog::init(plog::debug, m_console_appender.get());
^~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:137:15: error: ‘init’ is not a member of ‘plog’
plog::init(plog::debug, m_file_appender.get()).addAppender(m_console_appender.get());
^~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:137:15: note: suggested alternative: ‘info’
plog::init(plog::debug, m_file_appender.get()).addAppender(m_console_appender.get());
^~~~
info
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ConsoleHandler.cpp:137:87: error: request for member ‘get’ in ‘((SmartPeak::ConsoleHandler*)this)->SmartPeak::ConsoleHandler::m_console_appender’, which is of non-class type ‘int’
plog::init(plog::debug, m_file_appender.get()).addAppender(m_console_appender.get());
^~~
make[2]: *** [src/smartpeak/CMakeFiles/SmartPeak.dir/build.make:104: src/smartpeak/CMakeFiles/SmartPeak.dir/source/core/ConsoleHandler.cpp.o] Error 1
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationHandler.h:27,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationProcessor.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:24:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/RawDataProcessor.h: In member function ‘virtual void SmartPeak::RawDataProcessor::getFilenames(SmartPeak::Filenames&) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/RawDataProcessor.h:65:42: warning: unused parameter ‘filenames’ [-Wunused-parameter]
virtual void getFilenames(Filenames& filenames) const override { };
~^
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationHandler.h:29,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationProcessor.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:24:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceSegmentProcessor.h: In member function ‘virtual void SmartPeak::SequenceSegmentProcessor::getFilenames(SmartPeak::Filenames&) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceSegmentProcessor.h:77:42: warning: unused parameter ‘filenames’ [-Wunused-parameter]
virtual void getFilenames(Filenames& filenames) const override { };
~^
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationHandler.h:30,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/ApplicationProcessor.h:26,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:24:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SampleGroupProcessor.h: In member function ‘virtual void SmartPeak::SampleGroupProcessor::getFilenames(SmartPeak::Filenames&) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SampleGroupProcessor.h:44:42: warning: unused parameter ‘filenames’ [-Wunused-parameter]
virtual void getFilenames(Filenames& filenames) const override { };
~^
[  3%] Linking CXX static library ../../../lib/libgtestd.a
[  3%] Built target gtest
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:27:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h: In constructor ‘SmartPeak::SequenceSegmentProcessorMultithread::SequenceSegmentProcessorMultithread(std::vectorSmartPeak::SequenceSegmentHandler&, SmartPeak::SequenceHandler&, std::vector<std::shared_ptrSmartPeak::SequenceSegmentProcessor >&, std::map<std::cxx11::basic_string, SmartPeak::Filenames>&, SmartPeak::SequenceSegmentProcessorObservable*)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:149:61: warning: ‘SmartPeak::SequenceSegmentProcessorMultithread::sequence_segment_processing_methods’ will be initialized after [-Wreorder]
std::vector<std::shared_ptr>& sequence_segment_processing_methods;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:146:39: warning:   ‘std::map<std::cxx11::basic_string, SmartPeak::Filenames>& SmartPeak::SequenceSegmentProcessorMultithread::filenames’ [-Wreorder]
std::map<std::string, Filenames>& filenames; ///< mapping from injections names to the associated filenames
^~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:111:5: warning:   when initialized here [-Wreorder]
SequenceSegmentProcessorMultithread(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h: In constructor ‘SmartPeak::SampleGroupProcessorMultithread::SampleGroupProcessorMultithread(std::vectorSmartPeak::SampleGroupHandler&, SmartPeak::SequenceHandler&, std::vector<std::shared_ptrSmartPeak::SampleGroupProcessor >&, std::map<std::cxx11::basic_string, SmartPeak::Filenames>&, SmartPeak::SampleGroupProcessorObservable*)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:196:57: warning: ‘SmartPeak::SampleGroupProcessorMultithread::sample_group_processing_methods’ will be initialized after [-Wreorder]
std::vector<std::shared_ptr>& sample_group_processing_methods;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:193:39: warning:   ‘std::map<std::cxx11::basic_string, SmartPeak::Filenames>& SmartPeak::SampleGroupProcessorMultithread::filenames’ [-Wreorder]
std::map<std::string, Filenames>& filenames; ///< mapping from injections names to the associated filenames
^~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:158:5: warning:   when initialized here [-Wreorder]
SampleGroupProcessorMultithread(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h: In member function ‘virtual void SmartPeak::SequenceProcessor::getFilenames(SmartPeak::Filenames&) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:249:42: warning: unused parameter ‘filenames’ [-Wunused-parameter]
virtual void getFilenames(Filenames& filenames) const override {};
~^
[  4%] Building CXX object _deps/googletest-build/googlemock/CMakeFiles/gmock.dir/src/gmock-all.cc.o
[  5%] Building CXX object _deps/googletest-build/googletest/CMakeFiles/gtest_main.dir/src/gtest_main.cc.o
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:27:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h: In member function ‘virtual void SmartPeak::ProcessSequence::getFilenames(SmartPeak::Filenames&) const’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/SequenceProcessor.h:309:42: warning: unused parameter ‘filenames’ [-Wunused-parameter]
virtual void getFilenames(Filenames& filenames) const override {};
~^
[  6%] Linking CXX static library ../../../lib/libgtest_maind.a
[  6%] Built target gtest_main
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/Utilities.h:45,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/SequenceParser.h:29,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:29:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::OwningStdIOByteSourceBase::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:152:50: warning: conversion from ‘size_t’ {aka ‘long unsigned int’} to ‘int’ may change value [-Wconversion]
return std::fread(buffer, 1, size, file);
^~~~~~~~~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::NonOwningIStreamByteSource::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:169:49: warning: conversion from ‘std::streamsize’ {aka ‘long int’} to ‘int’ may change value [-Wconversion]
return in.gcount();
~^~
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: In member function ‘virtual int io::detail::NonOwningStringByteSource::read(char*, int)’:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:185:62: warning: conversion from ‘long long int’ to ‘int’ may change value [-Wconversion]
to_copy_byte_count = remaining_byte_count;
^~~~~~~~~~~~
In file included from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/core/Utilities.h:45,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/SequenceParser.h:29,
from /home/USER/Metabolomics/software/SmartPeak/src/smartpeak/source/core/ApplicationProcessor.cpp:29:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h: At global scope:
/home/USER/Metabolomics/software/SmartPeak/src/smartpeak/include/SmartPeak/io/csv.h:1099:22: warning: unnecessary parentheses in declaration of ‘row’ [-Wparentheses]
char*(row[column_count]);
^
[  6%] Linking CXX static library ../../../lib/libgmockd.a
[  6%] Built target gmock
[  7%] Building CXX object _deps/googletest-build/googlemock/CMakeFiles/gmock_main.dir/src/gmock_main.cc.o
[  7%] Linking CXX static library ../../../lib/libgmock_maind.a
[  7%] Built target gmock_main
make[1]: *** [CMakeFiles/Makefile2:1097: src/smartpeak/CMakeFiles/SmartPeak.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

Alright, there you go:
gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5)

Thanks for the information.  I am thinking that it is not using the C++17 library.  Can you try compiling using the flag -std=c++17?


github-cli: init at 0.5.5

Motivation for this change
There's a new Github cli.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Already packaged as: gitAndTools.gh

Hm, I looked, but evidently not on a new enough version!


add expressionToString to getColumnClauses #441

Please review this . . .
Thanks

@mikebronner can you merge this?

Thank you @mikebronner


feat: add support for processing schedules

xref: https://github.com/go-vela/community/issues/538
Part of https://github.com/go-vela/community/pull/772
Dependent on https://github.com/go-vela/server/pull/836
This adds support for Vela to interact with schedules created in the database and spawn builds accordingly.

NOTE: In order to run a pipeline with support for schedules, you'll need https://github.com/go-vela/worker/pull/479.

couple of comments for now, but looks good overall - thanks for the work!
and a note for @ecrupper to make sure it plays nicely with #859

Apologies as I missed that PR 😅 I've updated this PR to also use compiler.WithCommit().
Please let me know if you have any additional feedback or there is anything else I'm missing 👍


run test discovery with higher priority than test execution

to make sure that test discovery does not take longer than it needs to.
maybe we need two coroutine contexts.

related: https://github.com/Kotlin/kotlinx.coroutines/issues/1617#issuecomment-543057254

I think this is no longer needed with the new junit engine


Define and implement reload route sematics

Post to actuator /gateway/refresh publishes a RefreshRoutesEvent application event, any route caches should listen and act accordingly.


Feat: Improving Footer

Describe the feature
Footer is not in the proper way!!! The social media icons should be given proper spacing. And the title in the footer not bold and visible. Improving it looks more attractive.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Plz assign this task to me under GSSOC.

Hey @Anushkabh
Can this issue be assigned to me for gssoc '24
Regards,
V Meenakshi Iyer


Resign command doesn't filter builds by profile

Build/Submit details page URL
No response
Summary
When running eas build --platform ios --profile testing the interactive list of builds includes builds from all profiles, not just from testing
Managed or bare?
managed
Environment
  expo-env-info 1.2.0 environment info:
    System:
      OS: macOS 14.4
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 16.15.0 - ~/.asdf/installs/nodejs/16.15.0/bin/node
      Yarn: 1.22.15 - ~/.asdf/installs/nodejs/16.15.0/bin/yarn
      npm: 8.5.5 - ~/.asdf/plugins/nodejs/shims/npm
      Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: DriverKit 23.5, iOS 17.5, macOS 14.5, tvOS 17.5, visionOS 1.2, watchOS 10.5
      Android SDK:
        API Levels: 33, 33, 34
        Build Tools: 30.0.3, 33.0.0, 33.0.2, 34.0.0, 34.0.0
        System Images: android-33 | Google APIs ARM 64 v8a, android-34 | Google APIs ARM 64 v8a
    IDEs:
      Xcode: 15.4/15F31d - /usr/bin/xcodebuild
    npmPackages:
      @expo/webpack-config: ^18.0.1 => 18.0.2
      babel-preset-expo: ^9.3.0 => 9.3.1
      expo: ^48.0.0 => 48.0.9
      react: 18.2.0 => 18.2.0
      react-dom: 18.2.0 => 18.2.0
      react-native: 0.71.4 => 0.71.4
      react-native-web: ~0.18.11 => 0.18.12
    npmGlobalPackages:
      eas-cli: 9.1.0
    Expo Workflow: managed

Error output
No response
Reproducible demo or steps to reproduce from a blank project

Create a project with profileA and profileB in eas.json
Build iOS apps for both profiles
Run eas build --platform ios --profile profileA

@szdziedzic I mean build:resign, my bad. There's no --buildProfile flag according to the documentation
(sorry for closing the ticket, butterfingers 😅)

Oh, sorry, now I get it. Yeah, you are right, thanks for report!

@d4rky-pl Oh, actually, I believe the name of the --profile flag is quite unfortunate and this might be an unwanted behavior.
What I mean is that --profile is actually a target profile, so it defines a profile for which you want to use credentials and env vars to resign some other eligible build.  I believe that a use case for some people can be resigning build originally created using profile A using credentials and env vars from profile B that may differ. So this new filtering by the --profile flag might be unwanted in their use case.

What I think we can do here is to create 2 new flags:

target-profile which will do what profile does
source-profile for filtering

What do you think?

@szdziedzic after hearing your explanation I think it makes a lot of sense, I didn't realize there could be a use-case like these as we use the build profiles for specific environments (staging, production etc) so we would never want to mix ENV vars or credentials this way

--target-profile and source-profile flags will be released in 9.2.0


Couldn't find cache key error

I'm trying to update a test in MyST-NB that requires re-running one of the notebooks. However, the test keeps failing with this error, which I think is independent of MyST-NB:
E       AssertionError: assert '\x1b[31mWARN...x1b[39;49;00m' == ''
E         - WARNING: Execution Failed: /tmp/pytest-of-choldgraf/pytest-304/test_complex_outputs_unrun0/source/complex_outputs_unrun.ipynb
E         - WARNING: Couldn't find cache key for notebook file source/complex_outputs_unrun.ipynb. Outputs will not be inserted.

I can't figure out how to get rid of this error, and it doesn't make sense to me why it'd show up because I think everything in those tests is generated at test-time (at least, the cache etc). Am I doing something wrong? Or is this a bug?

Well, as the warnings suggest 😉; it can't find the cache key, because the notebook failed to execute, and so wasn't added to the cache.
So either (a) you haven't got all the dependencies installed to run that notebook (my guess), or (b) whatever you have changed is causing the notebook to fail.
You can get the test to print out the full stdout/stderr (can't remember exactly how off-hand), or you can try physically opening the notebook and running it through.

Ah interesting - OK it makes sense that the execution was failing. I think it was the warnings that threw me off. Because they are printed right after one another, I thought that the execution failed because the cache key couldn't be found. Perhaps there's a more intuitive way of structuring those warnings?

Yeh open for any improvements in wording, but

I thought that the execution failed because the cache key couldn't be found

What are you benjamin button lol; the cache key warning follows the execution warning, which surely implies that the execution failure subsequently caused the cache key failure? (i.e. cause precedes effect)

I don't think most users are going to analyze their warning messages with the kinds of logical connections that you're showing here lol, most people just look up at the last error message and then assume that's their problem.


Mocked UiBinder type is erased

I think is is distinct from #50.
In the following example the type of the UiBinder is erased when it is mocked, causing a ClassCastException.
I think there's type information available at runtime that could be used to fixed this. For example, see mockito's handling of RETURNS_DEEP_STUBS with generic types:

https://code.google.com/p/mockito/issues/detail?id=230
https://github.com/mockito/mockito/blob/master/src/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java

Here's the example:
@RunWith(GwtMockitoTestRunner.class)
public class MyWidgetTest {

  interface Appearance {
    // Mocked type will be erased to `UIBinder`
    UiBinder<? extends Widget, ?> uiBinder();
  }

  static class Widget {
    public Widget() {
      Appearance appearance = GWT.create(Appearance.class);
      // Assignment fails with CCE
      Widget widget = appearance.uiBinder().createAndBindUi(null);
    }
  }

  @Before
  public void setUp() {
    new Widget();
  }

  @Test
  public void simpleTest() {
    System.err.println("Hello world");
  }
}

Full repro:
mkdir -p src/test/java/mockitobug/
curl https://gist.githubusercontent.com/cushon/8c231f89708dadcf0075/raw/d9e50510499132037cac47dbd8ad67854fe8b429/MyWidgetTest.java > src/test/java/mockitobug/MyWidgetTest.java
curl https://gist.githubusercontent.com/cushon/50a9cbe451e7d6607a65/raw/94d77af02627d2b7b1756ff14e7a396514d7aeaa/pom.xml > pom.xml
mvn test

Running mockitobug.MyWidgetTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.514 sec <<< FAILURE!
simpleTest(mockitobug.MyWidgetTest)  Time elapsed: 0.216 sec  <<< ERROR!
java.lang.ClassCastException: org.mockito.internal.creation.jmock.ClassImposterizer$ClassWithSuperclassToWorkAroundCglibBug$$EnhancerByMockitoWithCGLIB$$99e9e895 cannot be cast to mockitobug.MyWidgetTest$Widget
	at mockitobug.MyWidgetTest$Widget.<init>(MyWidgetTest.java:22)
	at mockitobug.MyWidgetTest.setUp(MyWidgetTest.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        ...

Thanks for the detailed report. I agree we should have the type information available somewhere at runtime, but it looks quite tricky to get it. I'll take a look at this when I get a chance (which might be a while), or feel free to give it a try yourself.
To some extent this is an issue with the underlying Mockito implementation. We construct mocks using Mockito's ReturnsMocks setting, so presumably it would display the same behavior if used directly. It would be nice if there were a solution that worked by changing how we used mockito rather than adding additional logic on top of that. One thing to explore would be making ReturnsCustomMocks extend ReturnsDeepStubs rather than ReturnsMocks. I experimented with this briefly and it solved the issue you reported, but seemed to create others.


refactor slot mechanism

Now xcodis use redis/ledisdb db index as slot, ledisdb can only support 256 dbs, this is too small can increase the probability of busy keys in same slot.
I don't want to change ledisdb code and upgrade all data, this is a very huge work and has some risks.
Maybe we can do this, codis saves all data in db 0, and in the inner modified redis, codis uses a slot hash to store slot and its associated keys, this is convenient when migrating a slot from one redis to another, we will not scan all redis keys but only keys in the slot hash.
LedisDB can not use this feature which may cause many code changed. So when migrating slot, we have to scan all keys, find the actual key in the slot, then migrate it. This may be not efficient but acceptable:

Migration does not happen frequently.
When a slot is migrating, e.g, from group1 to group2 for slot0, if xcodis want to operate a key in slot0, xcodis will force trying to migrate this key whether it is in group1 or already in group2. Migrating a key is very fast.

So migrating a slot does not block whole service, but only a little slow.
@kouhate, how do you think so?

Hi @siddontang, sorry for my late, and those solution may be acceptable.
It depends on his key design how keys will become so busy. Migration is not so often, so full scan will not affect the whole system.
It is true, but not efficient because it needs unnecessary scan for a small slot.
I wonder you could take the same way as codis or redis-cluster. e.g. updating slot hash while logging write operations in binlog.

Hi @kouhate,
I don't know what you mean here:

I wonder you could take the same way as codis or redis-cluster. e.g. updating slot hash while logging write operations in binlog.

Btw, I have found a way to let ledisdb support large index, so we can use a large slot number, like 1024 or more.
Codis save 1024 slots in zookeeper, but I don't know the performance if we save more slots. Maybe we can save huge routing table in another ledisdb and use zookeeper to coordinate xcodis proxy server.

@siddontang, well, what I mean is not so same as codis and redis-cluster, but this means ledis can have a map which relates slot to key.
Since you said ledis had a binlog to log all write-operation, so I guess wrapping or hooking those event would not be so difficult, but I did't read your code deeply, so maybe I'm saying something strange.
Btw, that's a good news to hear!
Then, I also think keeping over 1024 routing table may decrease its performance, but using "another" ledisdb to support it needs additional ledisdb instance.
So, It is better to spend one of the db space to save those routing meta data if possible.
I don't know but redis-cluster may have something efficient way because they have tons of slots.


Expected start of object '{', but had 'EOF' instead...

Source information and language
9anime 13.20 English
Steps to reproduce

Browse 9anime in app
try to load any anime

Expected behavior
anime loads, downloads, and plays without issue
Actual behavior
the same error message "Expected start of object '{', but had 'EOF' instead..." always appears either in a toast or notification if you try to download an episode
Aniyomi version
<IP_ADDRESS>
Android version
Android 12.1
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.13.5.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

The weird thing is that sometimes the extension works fine for an hour or so but then it gets messed up agn.


Test failure in TestBlockMaxConjunction.testRandom.

Description
Test failure in TestBlockMaxConjunction.testRandom.
Gradle command to reproduce
gradlew test --tests TestBlockMaxConjunction.testRandom -Dtests.seed=991AA33DE6046153 -Dtests.locale=fr-LU -Dtests.timezone=America/Porto_Velho -Dtests.asserts=true -Dtests.file.encoding=UTF-8

Thanks, I had started looking into #13371 but this one was easier to debug and I could figure out the problem. I'll open a PR shortly.


Mobile wallet, retire  bridge::FileTransaction.  Add tx description for receive

Original ticket with changes  https://github.com/mwcproject/mwc-qt-wallet/issues/704
We had wnd::FileTransaction and  bridge::FileTransaction  that serve both Receive and Finalize pages.
Functionality of Receive and Finalize becoming more different. The original ticket introduce another complexity with  descriptions.
Because of that I separate that into
wnd::FileTransactionReceive  + bridge::FileTransaction
wnd::FileTransactionFinalize  + bridge::FileTransactionFinalize
bridge::FileTransaction exist only for mobile and it doesn't support adding message on receiver side.
Also please check the naming, it is slightly different on those pages.

I see that it is fixed, I can add description on my side.

Closing this ticket.


fix(deps): update dependency @actions/core to v1.10.1

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@actions/core (source)
1.10.0 -> 1.10.1

Release Notes

actions/toolkit (@actions/core)
v1.10.1

Fix error message reference in oidc utils #1511

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 5pm every weekday" in timezone CET.
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: actions/pnpm-lock.yaml
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your pnpm version is incompatible with "/tmp/renovate/base/repos/github/pleo-io/spa-tools/actions".

Expected version: 9.x
Got: 8.15.8

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".
To check your pnpm version, run "pnpm -v".


Application Form - Organization Profile

User Story
As an Applicant
I want to create my organization profile
So that I can report who I am
Description & Research
Wireframe
https://www.figma.com/file/nhOquOVmWD1P3BxEY0KIh5/CCBC-Intake?node-id=1002%3A7003
Source of Truth for Questions
Full information for input fields such as max length for text fields and the contents of drop-downs can be found in the Research channel Files/DataMapping.xlsx
Acceptance Criteria

[ ] Scenario: Visualize the field "Please specify the band number"
Given I'm filling the "organization type" field
When I select the "band council" option
Then the field "Please specify the band number" appears

[ ] Scenario: Visualize field "Operating name"
Given I'm filling the "Is operating name same as legal name?" field
When I select the "No" option
Then the field "Operating name" appears

[ ] Scenario: Visualize the field "Please enter the name of the parent organization"
Given I'm filling the "Is this Applicant organization a subsidiary of a parent organization?" field
When I select the "Yes" option
Then the field "Please enter the name of the parent organization" appears

[ ] Scenario: Visualize field "Please provide a short description of the Indigenous entity (maximum 75 characters)"
Given I'm filling the "Is this Applicant organization an Indigenous entity?" field
When I select the "Yes" option
Then the field "Please provide a short description of the Indigenous entity (maximum 75 characters)" appears

@eazeredo is this a duplicate of #30?

It looks like.
Let's copy and add this description to there.

@zoeyli-46 and @elliottSlee , wondering if you evaluate the possibility of instead of having the dynamic toggle on the conditional questions, the page just shows all questions and the validation is made at the "Complete" action?

@eazeredo I'm not sure I understand what you mean. We designed the conditional logic so the UX would be smoother, where applicants would only see questions pertaining to them.

An option is to replace this single date field for three dropdown fields: Year, Month, and Date.
I believe the date type field/component also allows to type the date, not only selecting from the datepicker. @marcellmueller @BryanGK

@marcellmueller cc: @MarsRomer
Manual typing of a date is possible currently, though I do find choosing a month a bit hard. It seems there is only a drop down for year but not month. Is something like this from MUI X possible where it has both year and month picker options?

Yeah we could use a different custom datepicker package I'm sure. I was under the impression that we were using a styled standard html date picker but we are actually already using a custom package react-datepicker.

I think the requirement involves a date picker that is easy to choose a day, month, year that happened 50 years ago. That being a way to:

Manually type a date, formatted. can it have a placeholder or default value to show the format of YYYY/MM/DD
Quickly find a month
Quickly find a year that is old (right now the date picker only lets me scroll down to 2017)

@BryanGK what was the reasoning for using react-datepicker over a styled standard html date picker like the one in the toolkit?
I think the standard one that is used in the toolkit should be enough tbh.

@zoeyli-46 the standard html datepicker used in the toolkit shows the date in the format of the language of the browser but it saves in the format YYYY/MM/DD.

Yes that toolkit one is great for the requirements, but the one on the https://ccbc-dev.apps.silver.devops.gov.bc.ca/ is not this one.
Aware that you already flagged this in the above comment!

@marcellmueller @BryanGK there's also this resource: https://reactdatepicker.com/#example-year-select-dropdown
@zoeyli-46 Do you think it's better to have year & month as drop downs or just year?

@elliottSlee having both year and month as drop-downs make it faster to find when they're looking for. In this use case, since organizations are likely to be old and won't be choosing a date in the near past or future, it may be easier for the user to find their year if there is a year picker with multi-columns. Is it possible to apply the year picker instead of the drop down when users click to change the year?

Additionally, on the current date picker its not visible that you can change the month as there is no down arrow next to the month. Could we use this one instead where it is more clear that it is an input field?

@marcellmueller update: organization profile, location, authorized and alternate contact moved to the end of the form before declaration page.

@marcellmueller @BryanGK would it be helpful to create another issue on Github for the re-ordering of pages?


Enable users to update personal information

Description
Users should be able to access a view for editing their profile and personal information.
Tests
Unit tests for the interaction between the form and the model
Integration test for accessing and submitting the form

May need to wait until Phase 2 as this would require an additional API endpoint being created to update a users details in OpenLDAP.

I was only thinking of the information we ask the user for and keep in the CustomUser table, like the first and last name. Are we planning to keep them in the database?
When we add email preferences, it should be possible to update those as well.

Yes, basic user information is stored in the CustomUser table and the OpenLDAP service. I think any changes to the user's information in the CustomUser table needs to be propagated to the OpenLDAP service, which manages a user's access to the cluster.  Phase 1 has to be complete by Thursday (18 Jun 2018), I will try to get this pull request in for Phase 1.

Do you mean Thursday 28th?
If this is not straightforward, would it make sense to merge this and create a separate issue about reflecting the changes in the OpenLDAP database?

Oops, I meant the 28th (updated comment). Well, if I merge the pull request, then the functionality has to be supported in phase 1 and I'm not sure if I will have time to implement the OpenLDAP logic. I should have a better idea by the end of tomorrow if this pull request will make it into phase 1.


Getting 404 error for azureopenai integration with k8s gpt.

Hi Team,
I am getting "Error: failed while calling AI provider azureopenai: error, status code: 401, message: %!s()" while trying to integrate azureopenai with k8sgpt. How to debug the issue, I have checked some documentation, but I have given correct information as per my knowledge, Is there any steps to debug this issue. ?

Could you please transfer this issue to the k8sgpt repository? It belongs to the community repository.


Mobile layout Fix

Added media queries for smooth mobile layout, no overlapping sections - responsive font size and images.
Put carousel into a container.
Carousel seems to be a bit bugged when the arrow - navigator control - is clicked. The scrolled cards get shifted to the sides and then they disappear all at once. Have no idea on how to fix that

Menu still has to be fixed, the entries' font-size is too big and the bg picture doesn't scale well on mobile


style - 05/17 chat design

Changes

Adjust styles of the chat text input, message bubbles, and a bit the selector to match better the styles here.
The user avatar png is deleted as it is no longer used.

Notes

Making the text bubble fit the its label while not overflowing it's parent is currently not trivial so for now chat bubbles are full width with different margins on the left to give them different idents (instead of having one fit bubble on the left and another fit bubble on the right).

Screenshots

There is a bit of difference in the bubble's background color between this PR and Figma. One is white and the other gray:
Figma:


discord-ptb: 0.0.105 -> 0.0.107

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for discord-ptb is: All-in-one cross-platform voice and text chat for gamers
meta.homepage for discord-ptb is: https://discordapp.com/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.0.107 with grep in /nix/store/7iw6ldfb23lc23k3ynwf01nzhyjcpd3i-discord-ptb-0.0.107
found 0.0.107 in filename of file in /nix/store/7iw6ldfb23lc23k3ynwf01nzhyjcpd3i-discord-ptb-0.0.107

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

discord-ptb

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7iw6ldfb23lc23k3ynwf01nzhyjcpd3i-discord-ptb-0.0.107 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A discord-ptb https://github.com/r-ryantm/nixpkgs/archive/a4d34a9bd901da5dbbcde43fa71d8ca5e5b0ea41.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a4d34a9bd901da5dbbcde43fa71d8ca5e5b0ea41#discord-ptb

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7iw6ldfb23lc23k3ynwf01nzhyjcpd3i-discord-ptb-0.0.107
ls -la /nix/store/7iw6ldfb23lc23k3ynwf01nzhyjcpd3i-discord-ptb-0.0.107/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

discord-ptb

Maintainer pings
cc @Scrumplex @Artturin @Infinidoge @jopejoe1 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Superseded by https://github.com/NixOS/nixpkgs/pull/347886


Fix some bad/slangy English in std.getopt.

I don't think that it makes sense to use slang like "dunno" in a
standard library.

Guilty as charged. Thanks folks.


My app use four InappwebView in the NavigationBar and each use 'Hybrid Composition=true',I use Navigator.push function and back to NavigationBar,then BottomNavigationBar missing

step 1 :  bottom navigation bar well

step 2: navigate to second page

step 3: bottom navigation bar disappeared

I reproduce it on every flutter Widgets

when I don't using the hybrid composition , the problem will not appear

the problem only reproduce on Android, not on IOS

I upgrade the flutter to newest version ，then It's ok

@godfeather
Can you give me some information about "flutter doctor"?


Update codebase to support latest AMS version.

There were a number of changes in the current ActiveModelSerializers versions that broke the functionality of this library. These changes should fix them.
This addresses @dblock's comment raised here https://github.com/ruby-grape/grape-active_model_serializers/pull/53 and should solve this outstanding issue https://github.com/ruby-grape/grape-active_model_serializers/issues/52
Specs were failing for ruby v2.1 because the latest rack requires >= ruby v2.2.2. Gem::InstallError: rack requires Ruby version >= 2.2.2. I pushed up a commit to make this pull green, but I'm not sure what the best approach is: dropping ruby 2.1 support or locking rack. Let me know if you'd like me to swap this.

Ok this is great. If I understand correct this is backward compatible with AMS 4.x? I'd like some mention of what version(s) of AMS we support in README, please. If not we should do a 1.4.0 release with all the changes before merging this, first.
You can just remove ruby 2.1 builds altogether, unless we want to make extra effort to support that. I am fine with not.

Whoops, I should've updated the gemspec to reflect this, but these changes are not backwards compatible with ASM v0.9.x. These changes work only with the 0.10.x releases. Being backwards compatible with v0.9.x we could potentially do, but it'd require a significant amount of work. Are you okay with dropping support for v0.9.x?
I'll make the changes you suggested and update this pull today.
I was also considering having travis explicitly test ASM versions. I was thinking of including the 0.10.0, 0.10.1, 0.10.2, and HEAD ASM versions in the travis build matrix permutations, but if we do that against ruby 2.3.1 and each of the 9 grape versions that already there, it would add 24 additional builds. Thoughts?

If the work to support ASM 0.9.x is too big, I say we don't do it.
I think your plan is good. Do a release of 1.4.0 with the changes on master, then feel free to merge this and do a 1.5.0 when that's all ready at will.

Great, I will do a release of v1.4.0 today and handle v1.5.0


Create chatpyprog

created the chatprogram

validated the code, looks good, let me merge to master - manikandan


FYI: Wrong EOL (End of Line) for Unix

Between version v3.0.9 and v3.0.11 the EOL changed from LF to CRLF. When I ran the 'syno_enable_m2_card.sh' (v3.0.11) script on my Syno DS1621+ I got the following error:
/usr/bin/env: ‘bash\r’: No such file or directory

where the \r is a result of the CR from the Windows EOL encoding instead of the UNIX EOL encoding. Swapping it back to LF, the script works perfectly.
v3.0.11:

v3.0.9:

Similar thing happened with "Synology M2 volume" and "Synology HDD db" when I followed the post here
Thank you for the scripts :)

How did you download the scripts?

Did you download the script's release zip file or tar.gz file?
Or did you click on syno_enable_m2_card.sh  then copy and paste the code into a text file?

Or did you view the script in Windows Notepad and click save?

By the way, which M.2 card do you have?
I assume the syn_enable_m2_card script worked to enable the M.2 card and the syno_enable_hdd_db script allowed you to use storage manager to create a volume on the NVMe drive(s) in the M.2 card?

Ah, my apologies. After digging further, I realized it was my GitHub Desktop application when I cloned the repo and checked out the v3.0.11 tag. I never opened and viewed the file until I tried running it on my syno via ssh, but the git core.autocrlf was set to true on my Windows computer. Wiping out the file and git cloning it directly using git on Linux was fine.
I have the DS1621+ with an E10M20-T1 with two Samsung SSD 970 EVO Plus 2TB drives in the expansion card and another two in the built-in M.2 slots. They all work, thanks to your scripts. It appears the NIC also works. Cheers


feat: support relative app icons in appDetails, closes #348

Hank still needs to get deployment working then Tim can QA this.

@timstackblock it appears deployment is now working with https://deploy-preview-459--authenticator-demo.netlify.app/

[Uploading... Screen Shot 2020-07-08 at 7.53.08 AM.png ]

I think this error only appears when you use the chrome extension.

Yes - if you use the latest extension build for this PR, it should work. But it doesn't work with the current production extension.


Fix load balancer deletion hang

If the number of load balancers to delete is zero, lbToAWSObjects throws an
error which is swallowed by the caller, causing an infinite retry loop in the
exponential backoff wait.
Make the LB deletion function idempotent by correctly handling empty LB lists.

The underlying error which is thrown when the LB list is empty:
ERRO[2018-09-28T15:21:42-04:00] Error processing load balancers: Error fetching tags for load balancers: InvalidParameter: 1 validation error(s) found.
- missing required field, DescribeTagsInput.LoadBalancerNames.

So, it can't self resolve.

Just FYI, the current code still assumes that all errors returned by DescribeTags are transient (in the case this PR fixes, a request validation error, the error is actually permanent).

/lgtm


Make generate create two files without yaml extension in json format

steps

git clone current project
make generate

Result:

two additional files without .yaml extension are created in json format:
prometheus-operator-0servicemonitorCustomResourceDefinition
prometheus-operator-0prometheusruleCustomResourceDefinition

Attach these two files
manifests.zip

cc @kakkoyun @lilic I think you had some fix in other repos for this right?

The easiest fix is using find to delete interim files.
-jsonnet -J vendor -m manifests "${1-example.jsonnet}" | xargs -I{} sh -c 'cat {} | gojsontoyaml > {}.yaml; rm -f {}' -- {}
+jsonnet -J vendor -m manifests "${1-example.jsonnet}" | xargs -I{} sh -c 'cat {} | gojsontoyaml > {}.yaml' -- {}
+find manifests -type f ! -name '*.yaml' -delete

that works for me, would you mind adding it? :)

I believe this is the same issue as the one reported here: #498. I tried something in that PR #501 if anyone is willing to check if this is working. Otherwise, I can update it to use @kakkoyun solution.

happy with that solution as well, someone with OSX should verify though :)

@dgrisonnet Thanks for the PR, I've tested on my mac and I got errors like below and the files without extension are not deleted:
lute import still works
./build.sh examples/kustomize.jsonnet
+ set -o pipefail
++ pwd
+ PATH=/Users/ben/src/qingcloud/kubesphere/kube-prometheus/tmp/bin:/Users/ben/go/bin:/Users/ben/go/bin:/Users/ben/go/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/usr/local/MacGPG2/bin:/usr/local/kubebuilder/bin:/usr/local/kubebuilder/bin
+ rm -rf manifests
+ mkdir -p manifests/setup
+ jsonnet -J vendor -m manifests examples/kustomize.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml; find {} -delete' -- '{}'
find: -delete: manifests/../kustomization: relative path potentially not safe
find: -delete: manifests/alertmanager-alertmanager: relative path potentially not safe
find: -delete: manifests/alertmanager-secret: relative path potentially not safe
find: -delete: manifests/alertmanager-service: relative path potentially not safe
find: -delete: manifests/alertmanager-serviceAccount: relative path potentially not safe
find: -delete: manifests/alertmanager-serviceMonitor: relative path potentially not safe
find: -delete: manifests/grafana-dashboardDatasources: relative path potentially not safe
find: -delete: manifests/grafana-dashboardDefinitions: relative path potentially not safe
find: -delete: manifests/grafana-dashboardSources: relative path potentially not safe
find: -delete: manifests/grafana-deployment: relative path potentially not safe
find: -delete: manifests/grafana-service: relative path potentially not safe
find: -delete: manifests/grafana-serviceAccount: relative path potentially not safe
find: -delete: manifests/grafana-serviceMonitor: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-clusterRole: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-clusterRoleBinding: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-deployment: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-service: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-serviceAccount: relative path potentially not safe
find: -delete: manifests/kube-state-metrics-serviceMonitor: relative path potentially not safe
find: -delete: manifests/node-exporter-clusterRole: relative path potentially not safe
find: -delete: manifests/node-exporter-clusterRoleBinding: relative path potentially not safe
find: -delete: manifests/node-exporter-daemonset: relative path potentially not safe
find: -delete: manifests/node-exporter-service: relative path potentially not safe
find: -delete: manifests/node-exporter-serviceAccount: relative path potentially not safe
find: -delete: manifests/node-exporter-serviceMonitor: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-apiService: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-clusterRole: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-clusterRoleAggregatedMetricsReader: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-clusterRoleBinding: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-clusterRoleBindingDelegator: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-clusterRoleServerResources: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-configMap: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-customMetricsApiService: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-customMetricsClusterRoleBindingHPA: relative path potentially not safe
find: {}: No such file or directory
find: -delete: manifests/prometheus-adapter-customMetricsClusterRoleServerResources: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-deployment: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-roleBindingAuthReader: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-service: relative path potentially not safe
find: -delete: manifests/prometheus-adapter-serviceAccount: relative path potentially not safe
find: -delete: manifests/prometheus-clusterRole: relative path potentially not safe
find: -delete: manifests/prometheus-clusterRoleBinding: relative path potentially not safe
find: -delete: manifests/prometheus-endpointsEtcd: relative path potentially not safe
find: -delete: manifests/prometheus-operator-serviceMonitor: relative path potentially not safe
find: -delete: manifests/prometheus-prometheus: relative path potentially not safe
find: -delete: manifests/prometheus-roleBindingConfig: relative path potentially not safe
find: -delete: manifests/prometheus-roleBindingSpecificNamespaces: relative path potentially not safe
find: -delete: manifests/prometheus-roleConfig: relative path potentially not safe
find: -delete: manifests/prometheus-roleSpecificNamespaces: relative path potentially not safe
find: -delete: manifests/prometheus-rules: relative path potentially not safe
find: -delete: manifests/prometheus-rulesEtcd: relative path potentially not safe
find: -delete: manifests/prometheus-secretEtcdCerts: relative path potentially not safe
find: -delete: manifests/prometheus-service: relative path potentially not safe
find: -delete: manifests/prometheus-serviceAccount: relative path potentially not safe
find: -delete: manifests/prometheus-serviceEtcd: relative path potentially not safe
find: -delete: manifests/prometheus-serviceKubeControllerManager: relative path potentially not safe
find: -delete: manifests/prometheus-serviceKubeScheduler: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitor: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorApiserver: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorCoreDNS: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorEtcd: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorKubeControllerManager: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorKubeScheduler: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorKubelet: relative path potentially not safe
find: -delete: manifests/prometheus-serviceMonitorS2IOperator: relative path potentially not safe
find: -delete: manifests/setup/0namespace-namespace: relative path potentially not safe
find: {}: No such file or directory
find: {}: No such file or directory
find: {}: No such file or directory
find: {}: No such file or directory
find: {}: No such file or directory
find: {}: No such file or directory
find: -delete: manifests/setup/prometheus-operator-clusterRole: relative path potentially not safe
find: -delete: manifests/setup/prometheus-operator-clusterRoleBinding: relative path potentially not safe
find: -delete: manifests/setup/prometheus-operator-deployment: relative path potentially not safe
find: -delete: manifests/setup/prometheus-operator-service: relative path potentially not safe
find: -delete: manifests/setup/prometheus-operator-serviceAccount: relative path potentially not safe
make: *** [manifests] Error 1

@kakkoyun Your fix works for me ! thanks

@dgrisonnet Let’s fix this in your already open PR; would you consider updating your PR?

Yes I am on it :) thanks for testing

Sorry, an update to my test on @kakkoyun 's fix: I noticed that a file name kustomization was left behind ...
./build.sh examples/kustomize.jsonnet
+ set -o pipefail
++ pwd
+ PATH=/Users/ben/src/qingcloud/kubesphere/kube-prometheus/tmp/bin:/Users/ben/go/bin:/Users/ben/go/bin:/Users/ben/go/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/usr/local/MacGPG2/bin:/usr/local/kubebuilder/bin:/usr/local/kubebuilder/bin
+ rm -rf manifests
+ mkdir -p manifests/setup
+ jsonnet -J vendor -m manifests examples/kustomize.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml' -- '{}'
+ find manifests -type f '!' -name '*.yaml' -delete
cp ./additional-scrape-configs.yaml ./manifests/
rm -rf manifests/prometheus-role*Namespaces.yaml
rm -rf manifests/grafana-serviceMonitor.yaml
huobingjiedeMacBook-Pro:kube-prometheus ben$ git status
On branch ks-v3.0
Your branch is ahead of 'origin/ks-v3.0' by 113 commits.
  (use "git push" to publish your local commits)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   README.md
	modified:   build.sh
	modified:   jsonnetfile.lock.json
	modified:   kustomization.yaml
	modified:   manifests/prometheus-rules.yaml

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	kustomization

@benjaminhuo can you verify as in the PR that Damien submitted, thanks! Worked for me.

@lilic Thanks , @dgrisonnet's new PR works!


Cast FlashCommand to ICommand instead of Command

https://github.com/Redth/ZXing.Net.Mobile/blob/3c0aae501e723f195c599a1eb9cf4cc1839929c9/Source/ZXing.Net.Mobile.Forms/ZXingDefaultOverlay.cs#L122
I think this is just a typo, but breaks my custom implementation of ICommand that i use for FlashCommand

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


user-error: Company not enabled

On a non-customized radian setup, I am getting the error user-error: Company not enabled when I press
M-: (or M-x eval-expression) and press tab after typing anything.
I tried setting debug-on-error, debug-on-message and debug-on-entry so I can capture a call stack without luck.

It seems company does not enable itself when the buffer name starts with a space like the minibuffer (see company-mode-on). But then Radian's remapping of completion-at-point to company-manual-begin is questionable IMO.
I resolved this issue with the following re-mapping instead
(use-package company
  :bind
  ([remap completion-at-point] . #'my/company-completion-at-point)
  :config
  (defun my/company-completion-at-point ()
    (interactive)
    (if company-mode
        (call-interactively 'company-manual-begin)
      ;; if company mode is not enabled call the standard completion-at-point
      (call-interactively 'completion-at-point))))

Hey, thanks for tracking this down! I've had this error for a few years but never bothered to do anything about it. In https://github.com/raxod502/radian/commit/87c1ba2e17e7be0a736368b03f8682e87abb231f, I put the company-manual-begin bindings behind a :filter clause that will activate them only when company-mode is non-nil, which seems to fix the problem.

Yep, that's a much better solution. Thanks!


WIP: Pids limit

This adds a crio daemon level setting for container pids limit. We will add container level support once CRI supports it.

:+1:

travis seems to be having issues.

:+1:

Why did centos fail though?

Looks like centos doesn't have the pids cgroup setup :/

Rebased and added a test.

@mrunalp is there any way to check pids cgroup in test and skip in centos for instance?

Code LGTM except the Centos test fun.  Just curious why you picked a default max of 1,000 instead of 1,024.  Powers of 2 seems more the norm for this kind of stuff.

Googling around, I also see powers of 2 (1024)

I can change that to 1024.

@runcom I think we should switch Centos image to 7.3 (It is 7.2 lIRC) and that should hopefully fix more test issues on Centos.

@runcom I think we should switch Centos image to 7.3 (It is 7.2 lIRC) and that should hopefully fix more test issues on Centos.

Yes, there was an issue with that ~3 weeks ago though - basically, the OS images which go into the RH CI are controlled and at that time no CentOS 7.3 was in CI image list. I'll ask Jhonny where we are on that.

Updated the default limit to 1024 and added code to skip setting this when the pids cgroup controller is not mounted.

retest

Awesome.


Fix recursive trashcan purge

Bugfix: Fix recursive trashcan purge
We have fixed a bug in the trashcan purge process that did not delete folder structures recursively.
https://github.com/owncloud/ocis/issues/8473

Thanks for the patch, but unit tests??
There was no coverage, which made this bug possible.


STORM-2526: Revert changes mistakenly made to generated files

I regenerated all of the generated thrift files to be sure I hadn't mistakenly changed anything else.  Then I updated the one call to those APIs in the java code.

+1, opened Storm UI and clicked around a bit. It seems to work now.

+1


Trouble using preview-generator Py 3.6, GNU/Linux Ubuntu 18

I tried this simple import of preview_generator and got the PIL/pillow import problem.
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-11-1152239c0070> in <module>
----> 1 from preview_generator.manager import PreviewManager

/usr/local/lib/python3.6/dist-packages/preview_generator/manager.py in <module>
      7 import typing
      8
----> 9 from preview_generator.preview.builder.office__libreoffice import OfficePreviewBuilderLibreoffice  # nopep8
     10 from preview_generator.preview.builder.document__scribus import DocumentPreviewBuilderScribus  # nopep8
     11 from preview_generator.preview.builder_factory import PreviewBuilderFactory

/usr/local/lib/python3.6/dist-packages/preview_generator/preview/builder/office__libreoffice.py in <module>
     14 from preview_generator.exception import ExecutableNotFound
     15 from preview_generator.utils import check_executable_is_available
---> 16 from preview_generator.preview.builder.document_generic import DocumentPreviewBuilder
     17 from preview_generator.preview.builder.document_generic import create_flag_file
     18 from preview_generator.preview.builder.document_generic import write_file_content

/usr/local/lib/python3.6/dist-packages/preview_generator/preview/builder/document_generic.py in <module>
     11 from preview_generator.preview.generic_preview import PreviewBuilder
     12 from preview_generator import utils
---> 13 from preview_generator.preview.builder.image__wand import convert_pdf_to_jpeg
     14 from preview_generator.exception import PreviewAbortedMaxAttempsExceeded
     15

/usr/local/lib/python3.6/dist-packages/preview_generator/preview/builder/image__wand.py in <module>
     14 from preview_generator.utils import compute_resize_dims
     15
---> 16 from pdf2image import convert_from_bytes
     17
     18

/usr/local/lib/python3.6/dist-packages/pdf2image/__init__.py in <module>
      3 """
      4
----> 5 from .pdf2image import convert_from_bytes, convert_from_path

/usr/local/lib/python3.6/dist-packages/pdf2image/pdf2image.py in <module>
     11 from io import BytesIO
     12 from subprocess import Popen, PIPE
---> 13 from PIL import Image
     14
     15 from .exceptions import (

/usr/lib/python3/dist-packages/PIL/Image.py in <module>
     64     # Also note that Image.core is not a publicly documented interface,
     65     # and should be considered private and subject to change.
---> 66     from PIL import _imaging as core
     67     if PILLOW_VERSION != getattr(core, 'PILLOW_VERSION', None):
     68         raise ImportError("The _imaging extension was built for another "

ImportError: cannot import name '_imaging'

It looks like you might be using a private module, _imaging, which may have been removed.
I am working on Mint GNU/Linux 18 and the system is up to date. I installed Python 3.6 separate from the system install. I have a separate pip3.6 command. Here is the transcript from the install of preview_generator.
Collecting preview-generator
  Downloading https://files.pythonhosted.org/packages/ce/17/9eeb6bc3a7cc1dc8ba7db35a2038c61bef49336ec21057258801e9aef2a5/preview_generator-0.9.tar.gz (50kB)
    100% |████████████████████████████████| 51kB 1.7MB/s
Requirement already satisfied: python-magic in /usr/local/lib/python3.6/dist-packages (from preview-generator) (0.4.15)
Collecting Wand (from preview-generator)
  Downloading https://files.pythonhosted.org/packages/40/17/b61494b6dc5b8b472aa3a96a44a9ff5e05da9dc4dc3b6f9b0348e0666261/Wand-0.4.5-py3-none-any.whl (71kB)
    100% |████████████████████████████████| 71kB 4.6MB/s
Collecting PyPDF2 (from preview-generator)
  Downloading https://files.pythonhosted.org/packages/b4/01/68fcc0d43daf4c6bdbc6b33cc3f77bda531c86b174cac56ef0ffdb96faab/PyPDF2-1.26.0.tar.gz (77kB)
    100% |████████████████████████████████| 81kB 5.4MB/s
Requirement already satisfied: Pillow in /usr/lib/python3/dist-packages (from preview-generator) (3.1.2)
Requirement already satisfied: pyexifinfo in /usr/local/lib/python3.6/dist-packages (from preview-generator) (0.4.0)
Requirement already satisfied: packaging in /usr/local/lib/python3.6/dist-packages (from preview-generator) (18.0)
Requirement already satisfied: xvfbwrapper in /usr/local/lib/python3.6/dist-packages (from preview-generator) (0.2.9)
Requirement already satisfied: pathlib in /usr/local/lib/python3.6/dist-packages (from preview-generator) (1.0.1)
Requirement already satisfied: pdf2image in /usr/local/lib/python3.6/dist-packages (from preview-generator) (1.2.1)
Requirement already satisfied: six in /usr/lib/python3/dist-packages (from packaging->preview-generator) (1.10.0)
Requirement already satisfied: pyparsing>=2.0.2 in /usr/local/lib/python3.6/dist-packages (from packaging->preview-generator) (2.3.0)
Building wheels for collected packages: preview-generator, PyPDF2
  Running setup.py bdist_wheel for preview-generator ... done
  Stored in directory: /root/.cache/pip/wheels/06/0f/1e/3659ec17d8a05800bd5d4c23138d732597acb29a6a91dc9add
  Running setup.py bdist_wheel for PyPDF2 ... done
  Stored in directory: /root/.cache/pip/wheels/53/84/19/35bc977c8bf5f0c23a8a011aa958acd4da4bbd7a229315c1b7
Successfully built preview-generator PyPDF2
Installing collected packages: Wand, PyPDF2, preview-generator
Successfully installed PyPDF2-1.26.0 Wand-0.4.5 preview-generator-0.9```

This is definitely a problem with pillow and not with preview_generator. When I try to import from PIL import Image I see the same traceback. I"ll try to send something to pillow team.

Hello, happy you solved your problem ! Come back here if needed.

Sorry, i missreading your last response: can you give to use an example code to reproduce (and a pip freeze result). We will take a look.

Well, something must have been broken with my install of pillow. I uninstalled it and installed it again and then it was fine.
The code that triggered the traceback I included in my original message was:
from preview_generator.manager import PreviewManager
As my second message indicated, the problem was with pillow and even just this failed:
from PIL import Image


Parent method suggestions in subclasses

VSCode Version: 1.17.0
OS Version: windows7

Steps to Reproduce:

however,  if you define a constructor(){} , all the suggestions are gone

Thanks. This is tracked upstream by https://github.com/Microsoft/TypeScript/issues/17977
Closing as upstream


[webpack-4.0] - I found the lazy-loading of chunk in chunkId is different between init-running and hot-updated

The first time，the project is compiled and generated the id for async chunks(thorugh the function of import) are customed names，and it is OK ，as follows:
function jsonpScriptSrc(chunkId) {
        return __webpack_require__.p + "" + ({
              "reconciliationCenter-1": "reconciliationCenter-1",
              "toNet-1": "toNet-1",
              "pointAccount-3": "pointAccount-3",
              "views": "views",
              "pipeNet-1": "pipeNet-1",
              "pointAccount-4": "pointAccount-4",
              "pointAccount-2": "pointAccount-2",
              "pointAccount-1": "pointAccount-1",
              "page": "page"
          }[chunkId] || chunkId) + ".js"
      }

When I change the content of an async module，localCode will be hotUpdated，and the chunks will be re-generated， then the async chunkId become a random integer，as follows:["12"]
function jsonpScriptSrc(chunkId) {
        return __webpack_require__.p + "" + ({
            "10": "pointAccount-1",
            "12": "pointAccount-4",
            "14": "pointAccount-2",
            "16": "page",
            "18": "pointAccount-3",
            "19": "pipeNet-1",
            "reconciliationCenter-1": "reconciliationCenter-1",
            "toNet-1": "toNet-1",
            "views": "views"
        }[chunkId] || chunkId) + ".js"
        /******/
    }

the key to the question，sometimes the random of chunkId is  inconsistent between the jsonpCallback in chunks[8] and the mapping-name in app.js[12]，and that cause load the async chunk appear missing error，as follows:
1. pointAccount-4.js chunks : ((typeof self !== 'undefined' ? self : this)["webpackJsonp"] = (typeof self !== 'undefined' ? self : this)["webpackJsonp"] || []).push([[8],{
2. app.js chunks : "12": "pointAccount-4"

VM3816 app.js:957 ChunkLoadError: Loading chunk 12 failed.
(missing: http://localhost:1894/pointAccount-4.js)
    at Function.requireEnsure [as e] (http://localhost:1894/a`

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.
Many bugs was fixed in v5, please consider to migrate


fix echowindow

Current implementation of :echowindow,
func Foo()
  echo 123
  return 'foo'
endfunc

echowindow Foo()

This code shows 123 and foo both on echowindow. I think 123 should be displayed on message area, and foo should be displayed on echowindow.

Also
:echowindow undefined_variable

This error message should be displayed on message area.

Thanks.  Please add a regression test.


Documentation for commands common test

Description
Documentation for commands/common_test.go
Fixes #245
Type of change

Documentation update

Testing steps
N/A

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   70.95%   70.95%
=======================================
  Files          12       12
  Lines         730      730
=======================================
  Hits          518      518
  Misses        208      208
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ba174...844e3b0. Read the comment docs.


Review Street Address Data Cleaning Manually

[x] Brett provide spreadsheet of verified street addresses closer to MVP
[x] Have a discussion about best approach prior to modifying spreadsheet
[x] E and K to Review spreadsheet of street addresses run through bc gov API verification
[x] E and K Make note of problematic ones
[x] Update process to upload spreadsheet with exceptions and manual corrections
[x] Update loads to use manual corrections in validation spreadsheet
[ ] E and K to note and correct remaining / outlier problems in Arches

Need to wait for resource model updates being made directly in DLVR (Help text and required fields)

@bferguso I will add this to manual clean up ticket


Move date to build string in conda recipe

This PR moves the date string from the version to the build string for conda recipes in this repository.
This is necessary to ensure that the conda packages resulting from PR builds can be installed in the same environment as nightly conda packages. This is useful for testing purposes.
Additionally, this PR adds the PKG_HASH value to our build string. This value is a hash computed from the dependency names and versions used to build our packages.
Typically the PKG_HASH value is included in packages when the build string is omitted, as seen on most conda-forge packages.
Including it in our build string will help ensure that new packages are published whenever our dependencies change (which is important in the case of shared library updates).
xref: https://github.com/rapidsai/rmm/pull/1195

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-23.04@2e19ab8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04     #497   +/-   ##
===============================================
  Coverage                ?   92.95%
===============================================
  Files                   ?      130
  Lines                   ?     9775
  Branches                ?        0
===============================================
  Hits                    ?     9086
  Misses                  ?      689
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/merge


[Snyk] Security upgrade @docusaurus/preset-classic from 2.4.0 to 3.5.0

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):

guide/package.json

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Cross-site Scripting SNYK-JS-SEND-7926862
  391

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting

Checkmarx One – Scan Summary & Details – a6da878b-7874-4b1d-b6d7-c0a31a4d9348
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2024-38513
Go-github.com/gofiber/fiber/v2-v2.32.0
Vulnerable Package

CVE-2020-26160
Go-github.com/dgrijalva/jwt-go-v3.2.0
Vulnerable Package

CVE-2020-28851
Go-golang.org/x/text-v0.3.3
Vulnerable Package

CVE-2020-28852
Go-golang.org/x/text-v0.3.3
Vulnerable Package

CVE-2020-29652
Go-golang.org/x/crypto-v0.0.0-20200622213623-75b288015ac9
Vulnerable Package

CVE-2021-3121
Go-github.com/gogo/protobuf-v1.2.1
Vulnerable Package

CVE-2021-33194
Go-golang.org/x/net-v0.0.0-20201016165138-7b1cca2348c0
Vulnerable Package

CVE-2021-38561
Go-golang.org/x/text-v0.3.3
Vulnerable Package

CVE-2021-43565
Go-golang.org/x/crypto-v0.0.0-20200622213623-75b288015ac9
Vulnerable Package

CVE-2021-44716
Go-golang.org/x/net-v0.0.0-20201016165138-7b1cca2348c0
Vulnerable Package

CVE-2022-21221
Go-github.com/valyala/fasthttp-v1.17.0
Vulnerable Package

CVE-2023-45288
Go-golang.org/x/net-v0.0.0-20220225172249-27dd8689420f
Vulnerable Package

CVE-2023-45288
Go-golang.org/x/net-v0.0.0-20201016165138-7b1cca2348c0
Vulnerable Package

CVE-2024-24786
Go-google.golang.org/protobuf-v1.27.1
Vulnerable Package

CVE-2024-24792
Go-golang.org/x/image-v0.0.0-20190802002840-cff245a6509b
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-2.2.1
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-1.8.0
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-0.1.7
Vulnerable Package

CVE-2024-45590
Npm-body-parser-1.19.2
Vulnerable Package

CVE-2024-45590
Npm-body-parser-1.20.1
Vulnerable Package

Apt Get Install Pin Version Not Defined
/Dockerfile: 4
When installing a package, its pin version should be defined

CVE-2019-19794
Go-github.com/miekg/dns-v1.0.14
Vulnerable Package

CVE-2022-41727
Go-golang.org/x/image-v0.0.0-20190802002840-cff245a6509b
Vulnerable Package

CVE-2023-29407
Go-golang.org/x/image-v0.0.0-20190802002840-cff245a6509b
Vulnerable Package

CVE-2023-29408
Go-golang.org/x/image-v0.0.0-20190802002840-cff245a6509b
Vulnerable Package

CVE-2024-29041
Npm-express-4.17.3
Vulnerable Package

CVE-2024-6104
Go-github.com/hashicorp/go-retryablehttp-v0.5.3
Vulnerable Package

Cxbf7a0b43-6fec
Go-github.com/denis-tingajkin/go-header-v0.3.1
Vulnerable Package

Image Version Not Explicit
/Dockerfile: 1
Always tag the version of an image explicitly

CVE-2022-30636
Go-golang.org/x/crypto-v0.0.0-20200622213623-75b288015ac9
Vulnerable Package

CVE-2022-30636
Go-golang.org/x/crypto-v0.0.0-20220214200702-86341886e292
Vulnerable Package

Fixed Issues

Severity
Issue
Source File / Package

CVE-2023-42818
Go-golang.org/x/crypto-v0.0.0-20220214200702-86341886e292

Cxab55612e-3a56
Npm-braces-3.0.2

Cxca84a1c2-1f12
Npm-micromatch-4.0.5

NPM Install Command Without Pinned Version
/Dockerfile: 8

Update Instruction Alone
/Dockerfile: 1

Container Requests Not Equal To It's Limits
/deployment.yaml: 19

Container Requests Not Equal To It's Limits
/deployment.yaml: 37

Container Requests Not Equal To It's Limits
/deployment.yaml: 19

Container Requests Not Equal To It's Limits
/deployment.yaml: 30

Container Requests Not Equal To It's Limits
/deployment.yaml: 37


LCVR Compatibility check is overly strict

The LCVR_Patcher.Enabled property only checks for the existence of the VR mod, but not actually whether the game was launched in VR or not. This causes the combination of LCVR + TooManyEmotes to completely disable TooManyEmotes, even though flatscreen players with the VR mod should be able to perform emotes.
The way that BetterEmotes tackled this was checking the flags set by LCVR, though this requires an assembly reference to LCVR, which then gives you the ability to check if the game is in VR by checking LCVR.Plugin.Flags.HasFlag(Flags.VR).

Thanks for letting me know! That was a whoopsie on my part. I forgot to check that, but it has been fixed, and will be pushed out in the update later today.


Make User Guide more reader friendly

Update the sections on edit and summarise so that the explanation is more layman and easy to read.

Codecov Report

Merging #128 (a206ceb) into master (cb06dc1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #128   +/-   ##
=========================================
  Coverage     69.56%   69.56%
  Complexity      518      518
=========================================
  Files            82       82
  Lines          1784     1784
  Branches        191      191
=========================================
  Hits           1241     1241
  Misses          494      494
  Partials         49       49

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Backport: Allow user assignment override

Problem:
If the current user assigned to an issue is not in the k3s-io org, the backport tool will error 422 when attempting to make a new issue.
Changes:

Allow a -u user to override an original assignee for backports
Remove the -c commit flag, it has never done anything.
Signed-off-by: Derek Nola<EMAIL_ADDRESS>

Just seeing this PR now. The -c flag is now in use as a string slice holding commits. The -u in this PR is great though. Would love to get that bit merged.


fixes some code style and class name

Changes proposed in this pull request:

fix some code style

Refactor some class name.

Refactor assembly module

Codecov Report

Merging #667 into dev will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##              dev     #667   +/-   ##
=======================================
  Coverage   66.92%   66.92%
=======================================
  Files         439      439
  Lines        8254     8254
  Branches     1308     1308
=======================================
  Hits         5524     5524
  Misses       2427     2427
  Partials      303      303

Impacted Files
Coverage Δ

...ansaction/job/BASETransactionJobConfiguration.java
0% <ø> (ø)

...n/config/AsyncSoftTransactionJobConfiguration.java
0% <ø> (ø)
:arrow_up:

...ardingjdbc/transaction/job/BASETransactionJob.java
0% <0%> (ø)

...c/transaction/job/BASETransactionJobBootStrap.java
0% <0%> (ø)

...dbc/transaction/job/BASETransactionJobFactory.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883996f...d47a936. Read the comment docs.


Refactoring/Cleanup

This doesn't add new functionality, but restructures the old code.

Many global variables are just duplicates of preferences, so they have been removed
Code reuse was improved by extracting small functions that work for multiple situations
Consistent use of constants for strings, so typos can't happen as easily
Separate and split methods to improve readability. Many methods were really long and complicated, and smaller functions solve this problem
Preferences are now versioned so they can potentially be migrated
Add logging to the main functions, for easier debugging.

This should also help to write unit tests. I hope :)

Thanks for the great contribution! :+1: I'll merge as soon as I get home because I'm traveling at the moment.

Thank you :)

Hey, I updated the contributors page.
Please give thumbs up or down.
Maybe for some reason you want it spelled differently or don't want it mentioned at all :)
Commit: https://github.com/adrcotfas/Goodtime/commit/d5036f1da8443e205246a3d9ec27c4e3339175a9


docs: explain URL paths used by "pmtiles serve"

This PR lists the URL routes used by pmtiles serve.
It also corrects an extension listed in a comment - the extension in the URL needs to be mvt, not pbf

Thanks for the fixes!


pkg/tar moved here from plutonium and extended a bit to help with OSS restore

reviewing separate from OSS restore since it stands alone.
Required for all non-trivial PRs

[X] Rebased/mergable
[X] Tests pass

aa_8880_liverestore includes some bugfixes, we can merge it there.