Added support to ZipBuilder for adding watchOS and watchOS Simulator slices

This was first mentioned in #8731. @paulb777 said that ZipBuilder needed to be updated to add watchOS and watchOS Simulator slices. I believe that this Pull Request implements these changes.
Unfortunately I've been unable to test - running swift run zip-builder on my machine, even with a fresh clone, causes a crash somewhere deep in Ruby. I've searched for every mention of tvOS and re-implemented for watchOS. If this doesn't 100% work, then perhaps it will get you most of the way there.
I implemented this because my app requires iOS 10 support, which means I cannot use SPM distribution. However, watchOS support appears to only be distributed in the SPM version of the frameworks.

The CI is failing after two and a half hours - likely after building all the other platforms and failing when it starts to try watchos. Likely there are problems related to trying to build products not supported for watchOS. https://github.com/firebase/firebase-ios-sdk/blob/master/ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift#L26 probably needs updates to turn watchos off in several places.
Either way, a good next step would be to locally edit https://github.com/firebase/firebase-ios-sdk/blob/master/ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift and try to get a watchos build working for a single pod.

I've already followed that pattern for Analytics, but adding "Firebase" appears to require "Analytics". Not sure where to go now.

I looked a bit more. We don't currently support the Firebase pod for watchOS.   A workaround to the ZipBuilder/ZipBuilder.swift:344: Fatal error: fatal error could be to save the Firebase pod version from one of the other platforms as a class variable, since there is nothing currently platform specific in it.

Closing in favor of #12624


German Italian Speech Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : German Italian Speech Analysis
:red_circle: Aim : Analyse and visualize different aspects of the German and Italian language.
:red_circle: Dataset : https://www.kaggle.com/datasets/mitishaagarwal/german-italian-speech-analysis
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID (If not, then put NA) :
Approach for this Project :
What is your participant role? (Mention the Open Source Program name. Eg. HRSoC, GSSoC, GSOC etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hello I would like to work on this project. Please assign it to me
Full name : Gunesh Mahajan
GitHub Profile Link : https://github.com/guneshm11
Participant ID (If not, then put NA) : NA
Approach for this Project : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
What is your participant role? - Contributor

Work on one issue at a time.

Full name: Niharika Khanna
GitHub Profile Link: nkhanna94
Participant ID (If not, then put NA): NA
Approach for this Project:
Exploratory Data Analysis (EDA):
Data Inspection + Data Cleaning + Data Visualization
Feature Engineering:
Feature Selection: Identify the most relevant features that contribute to the prediction tasks.
Feature Transformation: Apply necessary transformations to optimize model performance.
Model Implementation:
Algorithm Selection: Implement and compare 3-4 algorithms, such as Logistic Regression, Random Forest, Gradient Boosting, and Support Vector Machine.
Model Training: Train each model using the training dataset and validate using cross-validation techniques.
Model Evaluation:
Evaluate models based on accuracy, precision, recall, F1-score, AUC-ROC, etc. and compare the performance of all models to identify the best-fit algorithm for this dataset.
Participant Role: SSOC S3

Implement 5-6 models for this project.
Assigned @nkhanna94


[Spotify Player] says "bad gateway" when play/pausing

Extension
https://raycast.com/mattisssa/spotify-player
Raycast Version
1.83.1
macOS Version
Sequoia 15.0
Description
I'm using the spotify extension and raycast shortcut to play/pause. It says "bad gateway" upon first using the shortcut to toggle play, but if I use it a second time it plays. However, it is unable to toggle pause.
Gets this:
Error: Bad gateway.
Jd:pause.ts:19:10

16:       return;
17:     }
18:     console.log("pause.ts Error: ", error);
19:     throw new Error(error);
20:   }
21: }
22:
async onAction:nowPlaying.js:60:4591
Steps To Reproduce
Using option + space as a shortcut to toggle play/pause. option+space once = 'bad gateway'. option+space again = toggles play. option+space a third time to toggle pause = 'bad gateway' and does not pause. Further option+space leads to the same result (i.e., unable to pause).
Current Behaviour
Unable to toggle pause; able to toggle play but after 2 commands and with 'bad gateway' popping up.
Expected Behaviour
Able to toggle play/pause.

Could you share a recording? It'll make it easier to see what's happening.

Not sure if appropriate to add to this or open my own?  Similar behavior but when utilizing the menu bar GUI. Play/Pause results in "Bad Gateway" . Next/Previous results in " Payer Command Failed: No Active Device Found"

I also started been getting this from time to time lately. I've tried to sign out and sign in the extension without success. I restarted my Spotify app and it started working again.

It seems like both play/pause toggles correctly for me now. However, on the 'now playing' interface (which I also use to toggle play/pause), it doesn't update upon toggling. I.e., upon toggling pause, the music does pause, but the command prompt still reads 'pause' rather than 'play'. Subsequent command to 'pause' causes an 'error, please reload' screen. Upon reloading, the toggle resets and shows the correct command prompt 'play'.


non-fork 'hunterization' with patchfile

Im a little uncomfortable with 'forking' packages just to add 'hunterization'
Might it be more reasonable to maintain patchfiles in the hunter tree, and use PATCH_COMMAND to apply them instead of maintaining a fork?
an example of what im describing:
https://github.com/digego/extempore/blob/master/CMakeLists.txt#L316
I believe
https://github.com/hunter-packages/clang/commit/24c45ce2b557b18715456c9b8aae5742d12d2dc5
is a simple change, that would be encapsulated by using PATCH_COMMAND inside the hunter_add_version(...) declaration alongside the patch file in the main hunter/$PROJECT source tree
--- a/tools/CMakeLists.txt
+++ b/tools/CMakeLists.txt
@@ -20,4 +20,15 @@ endif()
 # on top of the Clang tooling platform. We keep them in a separate repository
 # to keep the primary Clang repository small and focused.
 # It also may be included by LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR.
+if(HUNTER_ENABLED)
+  hunter_add_package(ClangToolsExtra) # CLANGTOOLSEXTRA_ROOT
+  set(
+      LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR
+      "${CLANGTOOLSEXTRA_ROOT}"
+      CACHE
+      PATH
+      "Path to Clang tools extra"
+      FORCE
+  )
+endif()
 add_llvm_external_project(clang-tools-extra extra)
--

Makes it easy to track the changes, apply changes to future versions and also do pull requests upstream.
The patches would still need to be versioned (such as myproject v0.5-p1) as they would likely differ between commits.

The logic is next: if the patch is trivial then maintaining a fork is a trivial effort, also you can just send the patch upstream reducing maintenance to zero. If the patch is not trivial then supporting set of *.patch files is not practical - fork is more clear solution: https://docs.hunter.sh/en/latest/faq/why-do-we-need-forks.html#set-of-patch-files

an example of what im describing:
https://github.com/digego/extempore/blob/master/CMakeLists.txt#L316

Currently cache functionality relies on fact that sources = SHA1 of archive, if you add patches you have to design the system of applying SHA1 of patches.

It looks pretty much like a bottleneck here. Maybe caching and hunterization logics should be more isolated and play more like the other package managers with an ability to pick a version and to use a custom repository address.

Maybe caching and hunterization logics should be more isolated and play more like the other package managers with an ability to pick a version and to use a custom repository address.

How it is related to keeping tons of patches in Hunter repository instead of keeping them separately in place where they logically belongs to?
About "ability to pick a version":

https://docs.hunter.sh/en/latest/overview/customization/config-id.html
https://docs.hunter.sh/en/latest/reference/user-modules/hunter_config.html

About "custom repository address":

https://docs.hunter.sh/en/latest/reference/user-variables.html#hunter-download-server

@ruslo I have a good use-case for supporting patches:  PlayStation®4 - SCE DevNet
Sony has a strict non-disclosure agreement that doesn't allow us to to expose anything from their SDK publicly. We have encountered a few third party libraries that had to be modified for PS4 use, and we had no choice but to make private forks of these third party libraries.
If we were able to provide private patch files through the hunter_config command in our cmake/Hunter/config.cmake, it would remove the need of doing private forks.
Personally, I prefer private forks as they are easier to maintain than maintaining patch files when merge conflicts occur, as long as my employer pays for those private forks 😅

Closing inactive discussion.


Fix IndexError when calling "workon" with no argument, #137.

Eventually, I think it would be better for parse_envname() to just raise KeyError or similar, in which case we could lsvirtualenv() or err out appropriately.  Passing the no_arg_callback seems strange.
However, this at least fixes the immediate issue.  Includes basic unit test.

Thank you!
Sorry for not merging this earlier


Script ends after it finds the object it is looking for

I would like to use this as a security camera.  It is not useful if the script ends after it sees something.  Can a loop be added to restart the process?

If I use the caller.py file, the loop works.  Had to update the paths to the models and labels.


bug: Failing to install dependecies at setup

Describe the bug
I tried setting up repository locally by docker compose watch and it shows and at 4th step it fails to install dependencies where required.
Error:  => => # info There appears to be trouble with your network connection. Retrying...
I increased the network timeout
yarn install --network-timeout=300000
Still faced the same issue

To Reproduce
Steps to reproduce the behavior:

Clone repo
docker compose watch

This is your internet problem. I have got it running on my end

Internet is fine for  me
Tried switching to different networks

Removing config settings worked for me
yarn config delete https-proxy
yarn config delete proxy
Thanks Sir
Btw why is new UI disabled? or is it just not reflecting for me?


create posters, flyers, ... (for marketing activities, showing your personal interests, ...)

 Issue by Erkan-Yilmaz
Wednesday Jan 25, 2017 at 11:36 GMT
Originally opened as https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues/63

e.g. for distributing on universities
but can be also everywhere else, thus different posters/flyers/stickers/... need to be created for different target groups
we can include some of the existing pics from the ads already
for various target groups: slogan/motto search, is in other task: #64

mentioned in hangout 5: 0:55:07

 Comment by grctest
Wednesday Jan 25, 2017 at 13:27 GMT

A4 sized posters - I could place these in Computer Science areas of my Uni, likewise so could many other Gridcoin users.

 Comment by phdGuru
Monday Jan 30, 2017 at 02:32 GMT

Hi ,..
( We all like Google translator. It is sometime funny  : )
Well, we are just 2 guys Started web-design studio in 2006. And i'm a big fan of Gridcoin.
Not only does it reward you for doing REAL helpful research, It's reward system is designed to pay you in the same way as a pay per share pool so you are rewarded fairly based on the work you do. I know many people already run Gridcoin node, but just think how many people invested resources in ephemeral coins that disappear in next month. Just look for 1 Satoshi coins at exchanges, to see what I mean. We must say thanks God for Gridcoin and bless his developers. Okey) Now more about a topic.
Let me introduce art/poster promotion campaign for Gridcoin
I see a lack of good attractive art in Gridcoin crypto-space. To spread the world and promote Gridcoin we run crowdfunding campaign to create a series of posters. This will be a big A3 poster, flyers for different audience, and stickers. Anyone can check current state of balance at block explorer. When our goal minimum 0.8BTC will be reached we notify members. Art will be send to members after 8-10 days by email. Send your email, by the way. Art illustrations will be available at Creative Common license.  Print, share at soical media,, use in your articles, twitter, etc. Every member who will send 4$ will receive a sticker, 14$ or more: 1 poster + 1 sticker + 1 flyer. And 40$ all stickers and posters that we will create for Gridcoin project.
Official campaign address GRC S7jau7YsU8TH2iqYruJVA1Sxb939BJJe8B
Why our poster campaign will be successful?
Risk exist in any project. But I will do my best to make nice and attractive art. And a big chance that it will going viral. This will lead to growth of Gridcoin currency user base and as a result GRC value at the end.
Links to samples of art will be attached bellow in this thread.
About the author.
I`m ordinary BOINC user, started to mine and trade GRC in 2014, like many other peoples here. I am creative thinking man.
Nominated of award in design at "Exhibition advertising and printing 2015" [1] Remadays
Old member of reddit Gridcoin community, somebody already know me. Who not know, i am moderator of [2] /r/gridcoinjobs on reddit.
Active evangelist of citizen science and cryptocurrencies.
Thanks for you attention !
phpguru

 Comment by Peppernrino
Monday Jan 30, 2017 at 03:47 GMT

only $700? where do i sign!??!

 Comment by Mxmlln1
Friday Feb 10, 2017 at 13:08 GMT

I would distribute something that was A4/A5 in size if someone just created a design I could print off myself.
I think I would start with pinning them up on local University and College notice boards, especially in Computer buildings etc just as grctest said! I would hand some out as well.

 Comment by Erkan-Yilmaz
Saturday Feb 11, 2017 at 18:10 GMT

see also: https://cryptocointalk.com/topic/50138-gridcoin-ads-images-and-banners/

 Comment by Erkan-Yilmaz
Saturday Feb 18, 2017 at 13:35 GMT

also in smaller form, so people can show their contributions:
"something to keep at my desk at work, a poster or similar, that is unobtrusive and fairly small to express that I am interested in these things. "
(from: Something to express my interest in Gridcoin and BOINC in general)

 Comment by Erkan-Yilmaz
Thursday Aug 10, 2017 at 14:27 GMT

see also:

1million block event with prize: slogan + meme contest

Hey all, I designed some posters and they're currently in the marketing section of our GitHub.
https://github.com/gridcoin-community/Gridcoin-Marketing/tree/master/Gridcoin_Posters


Issue loading /demo.html and /

After the initial run, index.html works but loading demo.html gives the following error
Traceback (most recent call last):   File "/Users/andrewtran/Documents/Neon.js/app_env/lib/python2.7/site-packages/tornado/web.py", line 1509, in _execute     result = method(*self.path_args, **self.path_kwargs)   File "/Users/andrewtran/Documents/Neon.js/neonsrv/interface.py", line 48, in get     squarenotefiles=self.get_files('squarenote'),   File "/Users/andrewtran/Documents/Neon.js/neonsrv/interface.py", line 19, in get_files     for f in os.listdir(mei_dir): OSError: [Errno 2] No such file or directory: '/Users/andrewtran/Documents/Neon.js/squarenote'

Same error happens on the root url as well

Fixed with commit #1bf5a13e071dfd9c28dfff7bbd2df0b68636e2f4


Error "linking object 'macCatalyst'" when building for iOS Simulator

Unity Version: 2021.3.17f1
Bytebre Version: 0.1.5
Issue:
Building for 'iOS-simulator', but linking in object file (~/Builds/PROD/iOS/iOS/IL2CPP/APPSTORE_DEBUG/1.6.0-build.330/Libraries/ByteBrewSDK/Plugins/iOS/libByteBrewiOSPlugin.a[x86_64]2) built for 'macCatalyst'

I have already tried to add macCatalyst as an excluded architecture, but it still doesn't work.
I have other plugins, including Facebook, AdMob, Firebase, and some others. In my last attempt, I temporarily removed Bytebrew, and the build was successful.
This was only a debug build. When I build for release, it does build successfully, but I still hope it gets fixed.

Hello magicjar,
ByteBrew cannot be tested on iOS Simulators and must be tested on a real iOS devices for Unity. For any additional questions, please email our support at<EMAIL_ADDRESS>


Added proper Spring Boot 2.x support (including breaking changes)

Fixes #77

Hey @whiskeysierra I will take a look soon. Thanks for your contribution. What do you think, maybe we should take the opportunity to file the PR against master to make spring boot the new default?

Fine with me. Should we keep a backport/0.x branch, or something like that?

Probably makes sense since this PR contains breaking changes and should be the new standard.

Probably makes sense since this PR contains breaking changes and should be the new standard.

Based on the Spring docs you linked to, we should most probably do this:

Merge this pull request to feature/spring-boot-2 for now
Create new branch from current master named 0.6.x
Rename feature/spring-boot-2 to master (alternatively, since that will most likely require a force push, we may propose a pull request instead)
Document that there will only be critical bug fixes to 0.6.x.

:+1:

:+1:


Some questions about the resulting FPGA-Verilog

Hello Mr Tang! Hello, after I used python3 openfpga_flow/scripts/run_fpga_task.py benchmark_sweep/mac_units to successfully generate a 25X30 FPGA soft core, and successfully mapped the relevant circuit into the FPGA soft core, the relevant bitstream was generated, but during the simulation There are many problems, for example: when using the generated TOP_autocheck_top_tb.v to perform the related simulation, the warning of the zero delay loop appears (as shown in Figure 1), and after modifying the testbench (as shown in code1), it still appears The warning of the zero delay loop, I have been modifying and adjusting the testbench for the past few days and found that this problem cannot be solved. It feels like a problem with the generated FPGA module, but I have no way to locate it. Is there a problem with the soft core of the generated FPGA? , how can I solve this problem, I hope you can give some suggestions, thank you very much! !
By the way, I found that the configuration process of the code stream may be very long. How can I solve this problem? Is it only necessary to add --fast_configuration after write_full_testbench? Where else do I need to make changes or other operations?
fig1:

code1:

@kangliyu1 Can you tell which commit you are using?
If you see zero-delay, try to ensure that you turn on the UNIT_DELAY in your standard cell library.
Just like the --include_timing option:
https://openfpga.readthedocs.io/en/master/manual/openfpga_shell/openfpga_commands/fpga_verilog_commands/#cmdoption-include_timing
Also, try the options when generating testbenches

https://openfpga.readthedocs.io/en/master/manual/openfpga_shell/openfpga_commands/fpga_verilog_commands/#cmdoption-include_signal_init
https://openfpga.readthedocs.io/en/master/manual/openfpga_shell/openfpga_commands/fpga_verilog_commands/#cmdoption-include_signal_init

Ok thank you for your reply, I added it, but there is still a problem, but I adjusted the emulation tcl script of VCS to solve this problem


Fix permission issue

To fix this issue:
2020/02/13 11:13:52 [emerg] 1#1: mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)
nginx: [emerg] mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)

Hopefully this works out.


Adding query to some URLs creates incorrect paths

transitionTo/makePath('/foo/?bar=1', null, {anything: 'here'})

incorrectly produces
/foo/bar=1?anything=here

whereas
transitionTo/makePath('/foo/baz?bar=1', null, {anything: 'here'})

will create the correct URL
/foo/baz?bar=1&anything=here

note the incorrect URL path ends with /?, whereas the other has a final object: /baz?

Additionally, even
transitionTo('/foo/?bar')

with no extra params seems to remove the ?

You're not supposed to add query in to parameter, just the pathname (or route name). Use the third parameter as you've already shown.
transitionTo/makePath('/foo/', null, {bar: 1, anything: 'here'})

Then the behavior shouldn't change so drastically based on the URL fragments. It mangles the URL only when it ends with a trailing slash.
but either way, the latter issue still remains https://github.com/rackt/react-router/issues/1148#issuecomment-98020466

#1192 was a variant of this, but has been merged into this issue.
In that issue, I deduced that the problem appears to be this line:
.replace(paramInjectTrailingSlashMatcher, '/');

the new history lib that router is built on fixes this, as seen in rackt/history@d6380e5d


bug: Python tries to index dictionaries with unresolved Tokens

Summary
Sometimes python indexes a dictionary with an unresolved Token.
See #615 for reproduction steps and details.

superseded by #620


Why we call "the sequence-to-sequence framework for Neural Machine Translation based on Mxnet" Sockeye?

Sockeye is a type of Salmon found in the Northern Pacific Ocean, see http://sockeye.readthedocs.io/en/latest/faq.html#what-does-sockeye-mean

thank u


Update conda docs after move to conda-forge

As was considered in #247, we ended up moving to conda-forge.  This PR updates documentation to use the new install command and removes the old conda-build recipe.

Looks good to merge once tests all pass


Unreadble output in one special case

The content of this post is in reference to xo, but I believe that chalk is the source of the problem/issue. This was spotted as an xo issue (sindresorhus/xo#145). I traced that back to sindresorhus/eslint-formatter-pretty and now chalk.
Copy and pasted below
I'm not sure what's special about the output from xo, but it's the only thing that seems to be affected. I cannot read the output without copying and pasting it somewhere. Here are a few screenshots:
Normal Output

Highlighted Output

I've been copying the highlighted output my editor to read it. Any idea what xo is doing that's unique in this way? I've used hundreds of other cli tools including the underlying ESLint without any problems. I've used dozens of other programs that use chalk to print colorized output. I've even tried changing my local color profiles to no avail. Any help would be greatly appreciated.
For Reference
xo | tee makes the output visible although not colorized.
This is the content of the hidden output in both screenshots:
➜  ava git:(add-test-run-duration) xo

  api.js:183:2
  ⚠  183:2  Unexpected todo comment.                                          no-warning-comments

  lib/assert.js:15:1
  ⚠   15:1  This function has too many parameters (5). Maximum allowed is 4.  max-params

  lib/logger.js:94:2
  ⚠   94:2  Unexpected todo comment.                                          no-warning-comments

  lib/reporters/mini.js:178:4
  ⚠  178:4  Unexpected todo comment.                                          no-warning-comments
  ⚠  305:1  Unexpected todo comment.                                          no-warning-comments

  lib/test.js:42:2
  ⚠   42:2  Unexpected todo comment.                                          no-warning-comments

  test/cli.js:96:3
  ⚠   96:3  Unexpected todo comment.                                          no-warning-comments
  ⚠  141:3  Unexpected todo comment.                                          no-warning-comments

  test/promise.js:129:1
  ⚠  129:1  Unexpected todo comment.                                          no-warning-comments

  9 warnings

System Information
OS: Ubuntu 16.04 x64
Terminal: Byobu terminal
$TERM: screen-256color
$SHELL: /usr/bin/zsh
[ -t 1 ] && echo yes || echo no: yes

This is most definitely a bug in your terminal emulator (Byobu). Please file a bug with them.

Yeah, looks like your terminal can not handle chalk.hidden.dim.gray(), probably the hidden part: https://github.com/sindresorhus/eslint-formatter-pretty/blob/d5961796a238c463fd5d2b3b1ac8d5208d34e44e/index.js#L99

Thanks for the input!
Do you know if this works in other 256 color environments?

Yes, it definitely does.

Excellent! Thanks again.

@fearphage did you get this fixed? I'm having the same problem on zsh + termite +  tmux.

In case anyone else finds this post, first test your terminal emulator.
echo -e "Normal \e[8mHidden \e[28mNormal"

should print

source

In case anyone else finds this post, first test your terminal emulator.
echo -e "Normal \e[8mHidden \e[28mNormal"

For anyone who's made it this far down the rabbit hole and is seeing only the first Normal in the test listed above, see this Q/A for fixes.
It took some playing for me to get this working, and in the end I aliased tmux to TERM=screen-256color-bce tmux. I already had set -g default-terminal "screen-256color" in my .tmux.conf file.


Introduce AeadKey interface to make it easy to add new AEAD algorithms.

Codecov Report

Merging #24 (6027c2d) into main (03d3b11) will decrease coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.02%
==========================================
  Files          16       17       +1
  Lines         560      574      +14
  Branches       63       66       +3
==========================================
+ Hits          483      495      +12
- Misses         71       72       +1
- Partials        6        7       +1

Flag
Coverage Δ

unittests
86.23% <96.55%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/encryptionContext.ts
77.14% <80.00%> (-1.43%)
:arrow_down:

src/aeads/AesGcmKey.ts
100.00% <100.00%> (ø)

src/exporterContext.ts
78.94% <100.00%> (ø)

src/kdfCommon.ts
92.15% <100.00%> (ø)

src/kdfContext.ts
80.32% <100.00%> (-0.63%)
:arrow_down:

src/kemContext.ts
83.33% <100.00%> (ø)

src/recipientContext.ts
77.77% <100.00%> (-2.23%)
:arrow_down:

src/senderContext.ts
80.95% <100.00%> (-1.66%)
:arrow_down:

src/webCrypto.ts
50.00% <100.00%> (ø)

test/conformanceTester.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d3b11...6027c2d. Read the comment docs.


Improve tag label positioning and try to fix issues with some browsers

Attempt at fixing gh-443

Coverage remained the same at 57.748% when pulling 5c2e8287987751cf7f6318d30d96e851331faf7d on pv:tag-visibility into 0190965c971de4002d3e9ee1b991779b3af6989e on spacetelescope:master.

This fixed  the issue at least on my phone, so merging.


Make links open in browser window instead of WebView

This short change makes the clients primary browser handle opening links. I think this is a saner default, what do you all think?

Fixes #48

That used to be the default behavior, I think (might be wrong).  The Ux when operating in full-screen mode was unacceptable.  Can some cross-platform Ux specialist community member using Electron apps please comment?

@Sing-Li Sorry if I seem dumb but I don't really follow how this affects the full-screen UX.
To clarify, this does not change how you interact with the slide-out menus or clicking on a user portrait or anything like that, it merely opens external links posted by users in the clients primary browser (and the link to the rocket chat main repo).

@Pranz  If I'm a noob user.  And Electron app is running full screen.  Clicking on an external link may open the browser app in full screen on some platforms - obscuring Electron app.  My Ux in this case is that all menus and controls  have disappeared/changed and I'm totally lost as to why it happened.    Just thinking-out-loud :smile:

Oh, yeah that kinda makes sense. If having it as the default is rejected, I could try to make a switch for it in the preferences, if there's demand.

@Sing-Li The discontent all users feel having to open links in the electron browser far outweighs the bad experience an exceptionally small amount of inexperienced users might experience due to that, IMO.
That's not to say that a better solution cannot be found, but I believe this PR should be implemented until such a solution is found.

@ywecur Thanks for your input.  It is exactly what we need to hear to make these sort of decisions.
Also hoping that a 'better' solution can be found - hence the call out to Ux experienced community member -- as I'm sure it is a common 'classic problem' (not restricted to Electron Rocket.Chat app)  in that domain  :smile:

I also can't remember the reason.... so I vote for accepting the PR and reverting it in case we find a good reason for it.

To clarify on #48, the embed shouldn't open up any window. In Slack and other places it is used, the embed plays directly.


Remove erroneous prefix check when generating pattern string. (#62)

This addresses another issue from WICG/urlpattern#161.  It
corresponds to this implementation CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3405148

@kenchris sorry to do this, but another issue to review.  I wouldn't worry about rushing another release out for this, though.

Will make a new release tomorrow

@kenchris sorry to do this, but another issue to review. I wouldn't worry about rushing another release out for this, though.

OK! I will hold it off a bit then!


ADBDEV-1873 Order tables for backup by relpages value

Currently the output of RetrieveAndProcessTables function is ordered by
oid, which is not always optimal. This commit orders the list of tables for
backup by their size (by replages value from pg_class actually). It is
necessary to remember, that it only makes sence, when relpages value is
updated by either vacuum, analyze or a few ddl commands (such as create
index).
There is also a wrapper integration test (RetrieveAndProcessTables) fixed: it
used empty flag set and didn't properly test tables inclusion

I wonder if we specify -leaf-partition-data flag and store data for partitions on each own backup file then will partitioned table's file be empty? If so, is it right to assign to partitioned table summary size over partitions?
Also if -leaf-partition-data is specified and -include-table-file contains partitioned table and some (not all) partitions, will file for partitioned table store duplicated data with partition's ones or will it be empty?

@maksm90 with --leaf-partition-data we don't create (the parent) partition table's file at all, we only backup the metadata (ddl definition) for it + backup data = create data file for the leaf partitions. There are separate lists of Table structures for this purpose: metadataTables and dataTables

@maksm90 with --leaf-partition-data we don't create (the parent) partition table's file at all, we only backup the metadata (ddl definition) for it + backup data = create data file for the leaf partitions. There are separate lists of Table structures for this purpose: metadataTables and dataTables

Then my second question about assigning to partitioned table the sum of partitions' sizes is more appropriate: is it right to do this anyway (even with --leaf-partition-data) or we have to consider zero value for partitioned tables?

@maksm90 with --leaf-partition-data we don't create (the parent) partition table's file at all, we only backup the metadata (ddl definition) for it + backup data = create data file for the leaf partitions. There are separate lists of Table structures for this purpose: metadataTables and dataTables

Then my second question about assigning to partitioned table the sum of partitions' sizes is more appropriate: is it right to do this anyway (even with --leaf-partition-data) or we have to consider zero value for partitioned tables?

The situation is as follows:

without --leaf-partition-data we operate only with the parent table, child partitions are excluded from the dataTables and metadataTables. We backup its metadata and perform the COPY <parent_table> operation (backup data = data actually stored in all the leaf partitions). Consequently, we have to treat its size as the sum of the leaf partitions.
How we make sure child partitions aren't included into dataTables and metadataTables:

with --exclude-table(-file) , --include-schema(-file) and--exclude-schema(-file) or when there is no filtering using childPartitionFilter clause
with --include-table(-file) using simple 'in' clause in case leaf-partitions' names aren't provided by user in an include filter along with the parent table. Otherwise parent and the included leaf partition tables' data will be backed up successfully, no error will occur during restore HOWEVER data will be duplicated. This is not the regression of this PR, it is upstream's feature bug (@darthunix NB!)

 adb=# select * from rank25;
 id | rank | year | gender | count
----+------+------+--------+-------
  1 |    1 | 2006 | M      |     1
(1 row)

adb=# select * from public.rank25_1_prt_2;
 id | rank | year | gender | count
----+------+------+--------+-------
  1 |    1 | 2006 | M      |     1
(1 row)

$ gpbackup --dbname adb --include-table public.rank25 --include-table public.rank25_1_prt_2
$ gprestore --timestamp<PHONE_NUMBER>5539 --redirect-db kek

kek=# select * from rank25;
 id | rank | year | gender | count
----+------+------+--------+-------
  1 |    1 | 2006 | M      |     1
  1 |    1 | 2006 | M      |     1
(2 rows)

kek=# select * from public.rank25_1_prt_2;
 id | rank | year | gender | count
----+------+------+--------+-------
  1 |    1 | 2006 | M      |     1
  1 |    1 | 2006 | M      |     1
(2 rows)

with --leaf-partition-data we only operate with parent table for metadata's backup (to create the table afterwards). After that we perform COPY operation with each leaf partition we need (depending on what we have in the filtering options and wether we have a filter at all)
Parent table along with intermediate partitions are excluded from dataTables here

P.S. The leaf partitions are not excluded (they are ignored in the exclude filters)

with --leaf-partition-data we only operate with parent table for metadata's backup (to create the table afterwards). After that we perform COPY operation with each leaf partition we need (depending on what we have in the filtering options and wether we have a filter at all)
Parent table along with intermediate partitions are excluded from dataTables here

Do you mean that calculating full size for partitioned table (and as a consequence, uprising this table in ordered result of getUserTableRelations()/getUserTableRelationsWithIncludeFiltering() call) doesn't matter when option --leaf-partition-data was set because later all partitioned tables (top and intermediate) will be filtered anyway?

Do you mean that calculating full size for partitioned table (and as a consequence, uprising this table in ordered result of getUserTableRelations()/getUserTableRelationsWithIncludeFiltering() call) doesn't matter when option --leaf-partition-data was set because later all partitioned tables (top and intermediate) will be filtered anyway?

Strictly saying, yes. The reason is: getUserTableRelations()/getUserTableRelationsWithIncludeFiltering() is called for both situations (with and without --leaf-partition-data)

@maksm90
The way relpages value is calculated for AO/CO tables:

(The function) Has the same meaning as RelationGetNumberOfBlocks for heap relations however uses an estimation since AO relations use variable len blocks which are meaningless to the optimizer. This function, in other words, answers the following question - "If I were a heap relation, about how many blocks would I have had?"


Backup for cassandra -- include forcedphot

Add the forcedphot table to the backup of cassandra that Ken runs every week
Bring the dump dox into PoO

I've discovered a new tool called dsbulk which also "unloads" (i.e. dumps) data. It's blisteringly fast (at least on my hardware in Belfast).  I'll test it on cassandranode-0 and if it works as expected, I'll add it to my gkservercollection as a separate install. (It's just a matter of downloading some Java code, making sure a JRE is installed, updating the PATH to the dsbulk binary, and adding a CRON job to run it once a week. Depending on how fast it is, it might be useful to run it more frequently.)


Bazel Clean hangs

Hi ,
I am trying to build TensorFlow example for Android using Bazel but it hanged. So I tried to find the reason
and after a while tried to clean the previous build with "bazel clean" and it hangs again the same way as it happened while building TensorFlow examples:
$ bazel clean
.................................................................................................................................................................................{hangs here}
It doesn't move beyond that and we get no other info. Is there any other way to debug this or log the "bazel clean" output which we can later use to debug the issue?
We are using:
tensorflow: 1.1.0
Python: 2.7.6
We tried to find bazel version using "bazel version" now this is also hanging:
$ bazel version
. {hangs here}
Looks like its an issue with bazel. may be the installation is not correct. Can someone help?

Tried for bazel version after rebooting machine and following is the output:
Build label: 0.4.5
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Mar 16 12:19:38 2017<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

That looks like a bazel issue, could you report it there?
Please also report OS.
CC @jart

Yes please report to Bazel. Also be sure to provide them with information about your OS, computer, etc.


k8s.stop

Please run microk8s inspect and attach the generated tarball to this issue.
We appreciate your feedback. Thank you for using microk8s.

Not sure what this is about.


database/sql: Support for changing the username and password of an existing connection

Opening as per the suggestion in https://groups.google.com/forum/#!topic/golang-nuts/_OakZP-dLZw
My use case for this feature it to support rotating username and passwords using Vault. Vault leases database usernames and passwords and forces clients to rotate them before expiry. Be able to update the username and password of an existing connection pool would be extremely useful.
All drivers currently use the DSN to pass in the username and password, so perhaps this could be generalized to updating the DSN of an existing database connection pool.

Sorry, I don't think we want to do this. Just re-open the database and with the new password.
/cc @kardianos


Syntax example / error?

Hi, excuse my gaps in syntax knowledge but I've tried several variations and can't seem to get the authcode to be taken.
I've run audible-activator successfully and received the following output [changed to protect sensitive info]...
MbProR15T:audible-activator-master USERNAME$ ./audible-activator.py --username=EMAIL --password=HIDDEN
[*] Player ID is ALONGSTRING=
activation_bytes: EIGHTCHARACTERS
Then I try to run AAXtoMP3...and get this...
./AAXtoMP3 [-a][-c][-e:m4b][--authcode EIGHTCHARACTERS] theland.aax
ERROR Missing authcode
Usage: AAXtoMP3 [--flac] [--aac] [--opus ] [--single] [--chaptered]
[-e:mp3] [-e:m4a] [-e:m4b] [--authcode ]
[--target_dir ] [--complete_dir ] [--validate]
{FILES}
Where have I gone wrong? Thank you!

You are looking for the following:
./AAXtoMP3 -a -c --authcode EIGHTCHARACTERS theland.aax

-a/-c and -e:m4b are in conflict here. Square brackets "[ ]" generally indicate optional arguments.

Thank you! That got me output, I'd like one file as an .m4b but I think I can use other tools for that or keep playing. Much appreciated.

Got it! Thanks

In that case you should use
'''bash
./AAXtoMP3 -e:m4b --authcode AUTHCODE file.aax
'''


refactor(cdc source): simplify CDC transaction and heartbeat messages handling

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR:

Simplifies the CDC transaction control message handling.
Simplifies the heartbeat message handling by merge SourceStreamChunkBuilder and HeartbeatChunkBuilder.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#16440
#16505  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on  Graphite


Updated README.md to direct users to get stormcollector pyz file from releases

As a first-time user, possibly not drinking enough coffee, I initially thought the sscollector.pyz file would be found in the GitHub repo clone that is the preferred method of installation for StormSpotter.  I've added a phrase and a link to direct people to the releases page to get this file.

Sounds good.


⚠ Bofrost.lu has degraded performance

In 047c873, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1028 ms

Resolved: Bofrost.lu performance has improved in d3905d6 after 13 minutes.


Add Haralick features

Iva mentioned that texture features are very handy in some screens and might do better in the current screen anyway. These can be implemented with skimage.feature.greycoprops.

Should the Haralick features be computed on: the entire image, or small patches within the image?

The whole image. Just like with the current features, small patches could be pulled out, optionally, to speed up computation.


reserved keywords error messages

A similar issue was raised in https://github.com/crystal-lang/crystal/issues/4121
It would be good to produce proper error messages for using reserved keywords in the language.
The below example shows I am using the out keyword.
def foo(up : String, down : String, out : String)
  bar = JSON.build do |json|
    json.object do
      json.field "up", up
      json.field "down", down
      json.field "out", out
    end
  end

  bar
end

The compiler throw the following error at compile time. Same with crystal tool format.
Syntax Error: can't use variable name 'bar' inside assignment to variable 'bar'

The above message gives no idea about out been a reserved keyword and suggests bar is.
Displaying proper errors for builtin types would be good.

Crystal compiler version Crystal 0.24.2 (2018-03-10) LLVM: 5.0.1
OS x86_64-apple-macosx

Reduced example:
def foo(out : String)
  bar = begin
    puts out
  end
  bar
end

I initially expected this to be resolved by #5930, but out was not considered to be in the list of disallowed argument names.
Still, there seems to be some issue with it. It would be easy to simply restrict the use of out´ as argument name, but it is usually not an issue because it doesn't have any special meaning outside of argument definitions and there it's usage should be unambiguous. This seems really odd, as if local var outwas confused withbar` when used as a method argument.

https://github.com/crystal-lang/crystal/pull/5930 was merged 18 days ago which means it will be available on next release correct?

@stern0 it's correct (unless core team decides to release half-baked version like 0.24.2 was).

@stern0 #5930 doesn't fix this.


VMware Tanzu support

Feature Request
Short Description
Support for VMware Tanzu needs to be validated. Validation has to be done for:

[ ] enforcement supported? What is the LSM used?
[ ] Audit/Observability supported
[ ] Paste the output of karmor probe

As an FYI, the tasks involved would be:

Setup a k8s cluster using free tier vmware tanzu program
Install KubeArmor
Check sample workloads and verify if following things are working:

Policy Enforcement
Alerts/Telemetry

Get karmor probe output reference and attach in this issue
Update Kubearmor support matrix

edit: added comments suggestions

As an FYI, the tasks involved would be:

Setup a k8s cluster using free tier vmware tanzu program
Install KubeArmor
Check sample workloads and verify if following things are working:

Policy Enforcement
Alerts/Telemetry

Get karmor probe output reference and attach in this issue
Update Kubearmor support matrix

@nyrahul  I want to work on this, please assign it to me

@nyrahul I want to work on this, please assign it to me

@nyrahul I want to work on this, please assign it to me

When you say tanzu, there are actually 3 tanzu distributions, so it is important to be exact on which distro this is being tested. There is tkgi (foremerly pks), tkgm (multi cloud tkg on aws azure and vsphere), and tkgs (vsphere with tanzu). Also they support ubuntu and photonOS3 as well as amazon linux 2 when running on aws so important again to be explicit about what is tested and validated

@saurabh3460 Were you able to setup the environment? And can you please mention which one are you testing first?

@Ankurk99 I struggled with cli installation but did that so far and I am going with amazon and ubuntu setup first

@saurabh3460 Can I pick this up ?

sorry @jatinagwal for late reply sure take it, @nyrahul can you please assign it to him?

@jatinagwal are you working on this? If not, I want to take this up.

@jatinagwal are you working on this? If not, I want to take this up.

Hey, sorry I mentioned progress on slack. Actually, to deploy TKG i don't have enough resources. You can pick this

Hey @HariVamsiK, were you able to setup the Tanzu instance?

No not yet, I'm still figuring out the instances to use to setup the cluster. I'll update you the progress once I'm done setting up. I'll be using AWS for this.

Hey @HariVamsiK, Do you require any help in setting up the Tanzu instance?

No worries, let's discuss about that in the community call then. If you need any help till then, please feel free to ask here.

hey, If no one is working ?
I would love to work on this.
Please assign it to me


Public constants (especially for errors)

Are the constants intended to be private? I would like to handle the errors that LiveSDK create, but I can't work with the constants, because they're not publicly available.

Hi @MuscleRumble
This does seem like a bug.  I will investigate the issue, in the meantime feel free to submit a pull request.
Thanks for your feedback!


Updated README.md to align with test plan

Updated test step for ATE port-2 and DUT port-2 config as in test plan

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

CLA error. Will open new PR.


Update azure-virtual-network-limits.md

@stegag,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@stegag : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@rothja Please review these proposed changes. Thanks.

#sign-off

#sign-off


Virtual Machines covered by PIA

Describe the issue
We have a new team pathfinding with us using Virtual Machines (VMs) and we need to modify the PIA to include this service.
Which Sprint Goal is this issue related to?
Sprint: Aug 23 - Sept 10
Additional context

Technology explainer meeting with PO and Holly to get started (Security & Privacy to collab)
We are aiming to use a Private Marketplace and create a funnel around VM images that are available to teams from that private marketplace
The first offering in that Private Marketplace is intended to be ResourceSpace by Bitnami
VMs are currently scoped out of the corporate PIA.

Definition of done

Meetings with security and/or PO to go over technical questions privacy might have
Appropriate format to capture the change confirmed with PCT Director (Initiative Update, capturing change in an Excel sheet)
Draft, Review and Submit the updated PIA (if that's the decision from the Director)

This ticket is not fully refined, we're guessing a lot of the details.  We need to review further with Holly

PCT Director reviewing proposed format for capturing change - to be confirmed.

Changes to existing PIA with PCT Director for review.

PIA is sign off stage. Holly to close the file when it comes back fully signed.


feat: Add dx to catch ConfigureAwait(false)

This PR

Enable dotnet anaylzers
Ignore rule in benchmarks/tests

Related Issues
Stop https://github.com/open-feature/dotnet-sdk/issues/149 happening again in the future
Notes
N/A
Follow-up Tasks
N/A
How to test
N/A

@benjiro Thanks!


content

I am interested in the alignment and voting part of this project. Could you maybe push that part to the repo?
Cheers,
V.

Hi, I am really sorry for the late replay as I somehow missed your question. The code is now online but, as explained in the readme, I highly recommend to have a look at my colleagues Calamari project. The alignment and voting functionality can be found here and has been considerably refined.


how to use yaml format

Hi,
Instead of using annotations i'd like to use as a configuration file. I've spotted the configuration here https://github.com/willdurand/Hateoas#yaml
Also i've placed a file called hateoas.yml in my bundles config directory but it seems that the bundle isn't autoloading it.
Would you please give me a hint. thanks

You have to tell jms serializer bundle where your yaml files are. see http://jmsyst.com/bundles/JMSSerializerBundle/master/configuration

excellent! many thanks!


SpringBoot3 support

spring.factories not allowed in SpringBoot3
can create new artifactId, eg: jasypt-spring-boot3-starter, keep version same too
spring.factories = META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
please support it, thank you

I'm find this code in 3.0.6-SNAPSHOT version . why not upload to maven repo. I just now compile it in local

+1

spring.factories not allowed in SpringBoot3 can create new artifactId, eg: jasypt-spring-boot3-starter, keep version same too
spring.factories = META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
please support it, thank you

What's your issue? 3.0.5 works just fine at least with spring boot 3.3.3 and 3.3.4.

spring.factories not allowed in SpringBoot3 can create new artifactId, eg: jasypt-spring-boot3-starter, keep version same too
spring.factories = META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
please support it, thank you

What's your issue? 3.0.5 works just fine at least with spring boot 3.3.3 and 3.3.4.

you are right. I check my code, find it maybe 2.X level up 3.X IDEA Cache question。3.0.5 can used in spring boot 3.3.3


gtid mode is unusable

There are many inconsistencies in gtid support.
For example, when gset is nil, it is unclear whether it means:

the client wants to use gtid or not
or
the client intends to use gtid, but an empty position is given so canal will start mysqldump.

As a result, there are many places where gset nullity is not checked, and causes panics.
Proposal:

when gtid is nil, it does not use gtid.
otherwise, if gtid.String() is "", it means that the client wants to use gtid but it should start mysqldump.

I want to use this issue to clarify how to represent those cases, so that I can provide a PR.
#214

Hi @taylorchu

otherwise, if gtid.String() is "", it means that the client wants to use gtid but it should start mysqldump.

I find that https://github.com/siddontang/go-mysql/pull/261/files#diff-29b871543616f2c27c50edc9f54c566fR25 still use position even the string is empty. different from here?

I agree that part deserves more documentation because it is a special case.
After we use non-nil gtid to finish mysqldump as I described in the proposal, only the file-based position is available (from either dump output, or with a query before dump) but gtid is not. So here we continue to use file-based position to continue binlog syncer after dump.

yes, that makes sense.


python3Packages.gradio: 3.20.1 -> 3.43.1

Description of changes
Cyclic dependencies are fun, and the gradio devs sure can't tag their releases nor provide all needed test artifacts. But thankfully they've reduced the size of their testing closure tremendously.
Superseeds #254011
This does not build in its current state, but sure am i getting close!
I was hit by this issue. TIL about overridePythonAttrs.
Tests for gradio-clients:

Tests for gradio:

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build python310Packages.gradio python311Packages.gradio python310Packages.gradio-client python311Packages.gradio-client

we have got 12 test failures on darwin https://logs.ofborg.org/?key=nixos/nixpkgs.254041&attempt_id=59d85d89-6d74-4eeb-87b6-21434480c6b6
should we just conditionally disable those ?

I've left a couple of comments, this is great work!

Seems like the build failure is watchfiles, not gradio

This is ready to merge then. Do you want to fix the type mabye ?

(I just tested on master on a darwin machine and watchfile tests pass. So I'm going to let go of the watchfile error).

I'm planning to merge this tomorrow morning , just to give a bit of time in case anyone else wants to have a look at this.


fix: get resourceVersion before edit cluster

Signed-off-by: cmycoups<EMAIL_ADDRESS>
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

Codecov Report

Merging #559 (f4c127c) into release-1.3 (d83c7dd) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##           release-1.3     #559   +/-   ##
============================================
  Coverage        12.16%   12.16%
============================================
  Files              111      111
  Lines            16993    16993
============================================
  Hits              2067     2067
  Misses           14679    14679
  Partials           247      247


Fix input and ouput type checking

This is a regression from fixing ticket #56. There were 2 bugs:

The input and output type validation only checked that GraphQL
objects and inputs were used recursively, but didn't account for other
types like enums, interfaces, and unions. This wasn't captured in the
test suite due to #2 below, but this resulted in a SchemaError if you
used optional enums in input types, or used an optional enum, interface,
or union as an output type.

The determine(Input/Output)Type logic asserts against the wrapped
GraphQLType, meaning if you had a list (GraphQLList) or required field
(GraphQLNonNull), it didn't perform the new check since the
GraphQLTypeReference was nested. This is why the existing EndToEnd test
suite continued to pass since it marks almost all parameters that have
enums as required and such.

Cool, I ran into this problem where my enums stopped working this Friday. I already got started on the patch, but you beat me to it! I just tried out this patch, and it works as you'd expect it to work. Is there anything I can do to help to push this change out in a new release, @apottere ?

Thanks for the fix!

This is released in 4.1.1


[tensor] Added axis dimension to average

Current implementation of average() is confusing when compared with sum().
Both sum() and average() do not take axis, and perform similar operations.
However, the semantics of their output is different -

sum() acts over the dimensions other than batch size
average() acts over the batch size

To avoid this confusion, average is provided with axis argument with 0 as default.
This is now analogous to sum(axis) than sum()
Further, sum() is renamed to sum_by_batch() as thats what it does and is different from sum(axis)
Minor updates to TensorDim are also made
Resolves #99
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #146. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

:octocat: cibot: @kparichay, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/146-202006111434590.3438880443573-5bcdc2a633a996cefa0f6c9bef2b031fc3bc0fcc/.

:octocat: cibot: @kparichay, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/146-202006111738550.57832288742065-3e1c463e6fe23976365b0dba4bd676662e5a889c/.


Question: Usage with AppCenter CI

OS:

[ ]  Windows
[x]  MacOS
[ ]  Linux

Platform:

[x]  iOS
[ ]  Android

When CI tries to build with Xcode Sentry Run Scripts, it fails. On AppCenter there is post-build scripts support, so I tried to move run scripts to post-build scripts like below;
export SENTRY_PROPERTIES=sentry.properties

./node_modules/@sentry/cli/bin/sentry-cli react-native xcode \
./node_modules/@sentry/cli/bin/sentry-cli upload-dsym

Then I'm getting the following error ;
2018-03-01T10:06:50.3861460Z [command]/bin/bash /Users/vsts/agent/2.129.1/work/1/s/appcenter-post-build.sh
2018-03-01T10:06:50.5917230Z error: Need to run this from Xcode
2018-03-01T10:06:50.7343910Z Warning: No paths were provided.
Any suggestions how to upload dsym and sourcemaps to Sentry after CI build ?
Thanks!

@sercanov did you find a solution for this?

@gcesarmza  I ended up sending artifacts manually with sentry-cli. Here's an example;
export SENTRY_ORG=XXX
export SENTRY_PROJECT=XXX
export SENTRY_AUTH_TOKEN=XXXXX
export SENTRY_PROPERTIES=./ios/sentry.properties

if [ $AGENT_JOBSTATUS != "Succeeded" ]; then
  echo "Build failed, exiting script"
  exit
fi

echo "Build success"

brew install jq

APP_VERSION=$(cat package.json | jq -r .version)
SENTRY_VERSION=""
BUNDLE_ID_ANDROID="com.package.android"
BUNDLE_ID_IOS="com.package.ios"
echo "App version parsed: $APP_VERSION"

  SENTRY_VERSION="$BUNDLE_ID_IOS-$APP_VERSION"

  # Create dist folder & copy bundle files
  cp "$APPCENTER_SOURCE_DIRECTORY/index.ios.map" "$APPCENTER_SOURCE_DIRECTORY/dist/index.ios.map"
  cp "$APPCENTER_SOURCE_DIRECTORY/dummy-sourcemap-main.jsbundle" "$APPCENTER_SOURCE_DIRECTORY/dist/main.jsbundle"

  ./node_modules/@sentry/cli/bin/sentry-cli --log-level=DEBUG releases \
  files $SENTRY_VERSION \
  upload-sourcemaps \
  --dist $APPCENTER_BUILD_ID \
  --strip-prefix "$APPCENTER_SOURCE_DIRECTORY/src" \
  --rewrite "$APPCENTER_SOURCE_DIRECTORY/dist"


Seti Icons are displaced.

In the latest update seti-icons update icons everywhere are shifted either up or down. I've tried all possible settings for pristine. Still no luck.

I'll look into this @rednithin, thanks for sharing

@rednithin This has to do with the seti-icons package making modifications for specific ui themes (https://github.com/wyze/atom-seti-icons/blob/master/styles/theme-overrides.less).
To keep things consistent, I would suggest submitting a PR there.


RBAC manifest creation for Hosted Cluster admin personas

What this PR does / why we need it:
introduce RBAC artifact generation for hypershift admin personas / services
those artifacts are generated when the --enable-admin-rbac-generation flag
is provided during hypershift install
persona: hypershift-client
used by a client leveraging hypershift as a service to create hosted clusters

hypershift-client ClusterRole
full permissions on the hostedcluster and nodepool CRs
hypershift-client ServiceAccount
hypershift-client ClusterRoleBinding
binds the hypershift-client ClusterRole to hypershift-client SA and Group Ref
the groups itself must be provided by other means

persona: hypershift-readers
used by admins to investigate hosted clusters and the hypershift operator.

hypershift-readers ClusterRole
same permission subjects as the hypershift-operator ClusterRole but restricted
to get, list, watch. access to secrets is not granted
hypershift-readers ClusterRoleBinding
binds the hypershift-readers ClusterRole to a Group called hypershift-readers
the group itself must be provided by other means

fixes HOSTEDCP-306
fixes APPSRE-4335
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

Signed-off-by: Gerd Oberlechner<EMAIL_ADDRESS>

/lgtm
/approve

/retest

/retest


Thread Dump and Heap Info Shutdown Logs Support

Fixes #114

@aslo @cassand Can you guys take another look? I added support for JVM running under a different user. I also add a local integration test.


Populate tt.extern_elementwise conversion with math functions

Add fabs, sin, cos, tan, log, log10, log1p, exp, exp2, erf, sqrt, rsqrt, ceil, floor, floor, trunc math dialect functions conversion

@aobolensk Thank you! We're in the middle of a rewrite to split the pass into several modular passes. This code got moved to include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp. Would appreciate if you could update your branch to latest and move the patterns over to that file.

@aobolensk Thank you! We're in the middle of a rewrite to split the pass into several modular passes. This code got moved to include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp. Would appreciate if you could update your branch to latest and move the patterns over to that file.

Done


Verify proofs in examples/ directory as part of PR workflow

The prover's build checks a set of tests, and the PR verifies proofs from tlaplus/examples.  However, the proofs in examples/ are not verified.
Related: https://github.com/tlaplus/tlapm/pull/135

I thought we would move these examples to the https://github.com/tlaplus/Examples/ repo. If not, I can add them to the test cases.

I don't have an opinion, except that some examples are perhaps too basic for the example repo?!

I suggest we do this on a case-by-case basis. In particular, I think that Allocator, Euclid, Peterson, and perhaps GraphTheorem could go to the GitHub Examples repo. Bakery, Byzantine and standard Paxos, EWD 840, and LamportMutex are in there already, but we should check if there is anything in tlapm/examples that is worth merging into the existing modules. The other examples look too basic to me, but should probably be added to the tests if they aren't there already.
If you agree, I can take care of that reshuffle.

Sounds like a good way to go.

GraphTheorem could be aligned with a moved next to https://github.com/tlaplus/CommunityModules/blob/master/modules/Graphs.tla, like FiniteSetExtTheorem is next to FiniteSetExt in the CommunityModules?


northd: Allow DHCP request from the lport if enabled DHCPv4

Like the solution  of DHCP reply from ovn-controller[1].
Add 34000 priority flow to allow DHCP request from the lport if the CMS has enabled native DHCPv4 for this lport.
[1]https://github.com/ovn-org/ovn/blob/b92ad9e0b408a202273d69ba573f2538e53c6e48/northd/northd.c#L8441

@dceara @numansiddique Hi, please feel free to review this patch :)

@dceara Hi! I have post a patch:
<EMAIL_ADDRESS>

Ah, great, I missed that somehow, sorry.  I'll close this PR in favor of the patch then.


Fix require() bundling, fixes #315

Creates a new index.js file, which is the main entry as seen from package.json.
I think this suffices, what do you think?

Also, would you mind making a npm release when you have time?

Thanks @bryanph. I'll make a new NPM release with the next release of the library.


Issue #234: Prep tbdex-kt for 1.0.0 release

Satisfies #234

Codecov Report

Merging #235 (7acbb6f) into main (145bfc5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   84.28%   84.28%
=======================================
  Files          38       38
  Lines        1107     1107
  Branches      115      115
=======================================
  Hits          933      933
  Misses        122      122
  Partials       52       52

Components
Coverage Δ

protocol
85.80% <ø> (ø)

httpclient
78.31% <ø> (ø)


Unscope detect-port

This unscopes detect-port because the ecosystem is not yet ready for scoped packages.

the ecosystem is not yet ready for scoped packages
@Timer Just out of curiosity, what do you mean by that?

Scoped packages are an npm (the CLI) feature but it seems every custom registry in existence doesn't support them yet.


Add metadata cache and propagation strategy on s3

To quickly answer which files changed we need to have an mtime and etag for directories.
for s3 we cannot store matadata for keys that represent directories, because they get lost when adding a key to the prefix ... at least with minio that is the case.
for local storage that supports extended attributes we can store the etag as an extended attribute.  for local and s3 we need to do directory size accounting.
to enable stateless sync mtime, etag and size need to be propagated up the tree. The data needs to be stored in the storage for persistence. A cache on top can then be used to improve query speed.
This is related to being able to set arbitrary properties: https://github.com/owncloud/nexus/issues/28 not all s3 implementations allow metadata (minio does not)
So a storage needs a metadata persistence strategy / implementation? Hm, what is the cs3 api for this? AFAICT it is implicit. When executing PROPFINDS sync with the desktop clients will work if the etag changes ...
What about a propagation strategy? sync? async?

sync only for litmus?
async only for owncloud clients?
what should the default be?

when switching to cs3 directly, any clients MUST default to async!

Tagging is modeled as a different service in cs3: https://github.com/cernbox/cs3apis/blob/master/cs3/tag/v0alpha/tag.proto AFAICT it needs an update to use CS3 References instead of filename strings.
As a cache a k/v store like https://github.com/dgraph-io/badger makes sense. Can we split the actual storage metadata from blob storage? That is kind of what is necessary for s3 if we were to use it exclusively, anyway. For now implement in local and s3, then extract common pieces?

@butonic can this be closed? or should be moved elsewhere? Is it still relevant?

@butonic can this be closed? or should be moved elsewhere? Is it still relevant?

I think it can be closed as it is implemented by @butonic and @aduffeck. Please reopen if I am wrong.


Update extension for Gnome 45

Hi,
I made some changes to the extension to make it compatible with Gnome 45.
I mainly followed the gjs guide https://gjs.guide/extensions/upgrading/gnome-shell-45.html to do it:

I had to change to imports to use ESM (https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm)
extension.js now has to export a default class too, so I adapted the code to that as well (https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extension)

I don't usually code in JS so this might not be perfect, but at least the extension now works for me on Gnome Shell 45.5.

Thanks ArDrift for this support


Actually quit the app

This PR just removes a function that prevented the app from ever actually closing when you quit! 👎
I think it was added to allow cmd+q to process, but this is already in the keycode handling, and it doesn't seem to be required here anymore! 😄

Thank you for keeping vigilant and cleaning up old code 👀
I'll have to build the app to test this code change. Might take a week or so (just need to find some time) - thank you ahead of time for your patience.
Cheers 🙌

I see this was part of #79 -- hope the problem of not saving the settings doesn't resurface 😅


Add SQLALCHEMY_POOL_PRE_PING option for using SQLAlchemy 1.2 pre-ping…

I added this, as i am trying to prevent 'connection gone away' errors with MariaDB.

Thanks for your contribution.  https://github.com/pallets/flask-sqlalchemy/pull/684 should give you what you need to take care of this.

Thanks @rsyring


created basic 404 page

i also want to add an image

@jodymlin we should close this one since Alex has his: #76


obd driver error crashes

Hi, i don't know if are you interested, but here are two crashes from hockey app
`
Incident Identifier: a1ba8fa1-2ce5-4d1a-a4cf-4cf7ad3646ef
CrashReporter Key:   X02+I1MNFw5O3qj7zPSPwRi7CycAXsRhgYse7emqUEI=
Hardware Model:      RM-1116_15169
Process:         N/A [0]
Path:            N/A
Identifier:      MyDriving.UWP
Version:         <IP_ADDRESS>
Parent Process:  N/A [0]
Date/Time:       2016-04-21T07:38:44.9600715Z
OS Version:      Windows 10.0.14327.1000
Report Version:  104
Exception Type:  System.InvalidOperationException
Exception Codes: N/A at N/A
Crashed Thread:  7
Application Specific Information:
A method was called at an unexpected time. (Exception from HRESULT: 0x8000000E)
Exception Stack:
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
ObdLibUWP.ObdWrapper.d__13.MoveNext()
`
and
`
ncident Identifier: 6dea4e89-2e79-495e-9416-815307b9d6e6
CrashReporter Key:   X02+I1MNFw5O3qj7zPSPwRi7CycAXsRhgYse7emqUEI=
Hardware Model:      RM-1116_15169
Process:         N/A [0]
Path:            N/A
Identifier:      MyDriving.UWP
Version:         <IP_ADDRESS>
Parent Process:  N/A [0]
Date/Time:       2016-04-21T08:22:07.2331960Z
OS Version:      Windows 10.0.14327.1000
Report Version:  104
Exception Type:  System.InvalidOperationException
Exception Codes: N/A at N/A
Crashed Thread:  30
Application Specific Information:
A method was called at an unexpected time. (Exception from HRESULT: 0x8000000E)
Exception Stack:
Windows.Networking.Sockets.StreamSocket.CancelIOAsync()
ObdLibUWP.ObdWrapper.d__13.MoveNext()
`

Hi PiDiBi
Do you have a repro on these issues? We saw some issues with similar call stacks and we are working on them. We are not sure if yours are same as those or not.

no, but after next crash I will try to remember what I did before

Thank you. I checked in a fix for such crash and will close this issue. Please update to the latest version and open new issues if you see it again.


Could we set unlimited time expiration for key which generating by openssl ( x509)

I wonder if we could unset expiration time for key which generating by openssl. For instance, we have a command like this one.
openssl req -newkey rsa:2048 -nodes -keyout PrivateKey.key -x509 -days 3650 -out certFile.crt
It will set expiration time is 10 years, could we set it forever. Thank you in advance for any answer on this issue

I wonder if we could unset expiration time for key which generating by openssl. For instance, we have a command like this one.
openssl req -newkey rsa:2048 -nodes -keyout PrivateKey.key -x509 -days 3650 -out certFile.crt
It will set expiration time is 10 years, could we set it forever. Thank you in advance for any answer on this issue

No, the certificate must have an expiration field, the "notAfter" field in the X509v3 certificate definition.

No, the certificate must have an expiration field, the "notAfter" field in the X509v3 certificate definition.

What @richsalz said is right. I also noticed there is a paragraph in RFC 5280, saying:
   To indicate that a certificate has no well-defined expiration date,
   the notAfter SHOULD be assigned the GeneralizedTime value of
<PHONE_NUMBER>5959Z.

@kvu-luong , maybe you can consider this time value as the de facto "forever" :-)

Thank you so much for response on my issue


Does not show all tasks

Describe the bug
Show all tasks does not list al tasks, but the calling users can see/start  the tasks in the standard windows tool.
To Reproduce
Task are run as another account
The calling user is in administrators group .
(So the calling user can start,stop, change process. But not with this library)

There are three things that can cause this:

The user permissions and UAC of the account running the app
The user permissions of the account passed to the TaskService constructor
Permissions on the tasks themselves

Given what I could understand of your post, I would check UAC when the person in the Administrators group is running the app.

I've just been struggling with too since am running through IIS.
Had to change the Application Pool from ApplicationPoolIdentity to LocalSystem to get all the tasks to show.


wip v2 network

based on v2-examples, will move to main once #648 is merged

closing this since it's out of date


APIs for Provider

[x] Create Account
[x] Login
[x] Update profile information
[x] View profile information
[x] Add course
[x] Edit course
[x] Remove course
[x] View Courses offered by self
[x] View course feedback, ratings and Number of Purchases
[x] Get All course transactions, user wise
[x] Mark course as complete

Dev done, dev tested. PR to be raised EOD today as well.

Will be marked done by EOD


Eva Weekly Notes -- 2024-03-04

RA Projects
AwardFindR / award-pynder

5/16 data sources ported to Python
handed off to Nic + Isaac

Research Software
EAGER / Software Sustainability

[ ] Create dataset and basic EDA for "follow up sample" -- specifically:

Select only CISE and BIO from 2013 - 2023 (ask Nic if he wants to 2023 because need grants that have concluded)
Remove no code and survey responses from the set
Remove EAGER, Workshop, REU, and coop grants

[ ] Build on top of this dataset by:

Retrieve project reports
Identify Publications and Software from those reports
Put these in a dataset linked by award (award-software and award-publication)
Find multiple publications under the same award using WoS

[ ] Come up with clear questions to answer using the existing survey data
[x] Timeline plot / think through other ways to visualize "typical development patterns as they relate to grant funding timelines"

RS-Graph / Database for RS Research

[ ] Review and talk through planning doc with Nic
[x] Put together a plan for Akhil and Terra to work on the CRediT work
[ ] Ask Isaac for help writing a Llama/Mistral/etc. fine-tuning script for the Dev - Author annotation data
[x] ICSSI: minor plan for abstract proposal
[ ] Write WoS script for getting papers who mention software, tool, pipeline, or package in title from set of journals

Civic
Public Comment Segmentation

[ ] Write evaluation script for application of model for determining the segmentation quality (i.e. are we missing parts before, after, etc.)
[ ] Train and eval models for Seattle and Oakland
[ ] Choose next city council for data annotation and prep data

ML for PIT

No progress.

PhD Activities
Writing

[ ] Review and contribute to the Gig Driver Deactivation paper
[ ] Review and contribute to the CZI Software Dependency Graph paper

Reading

Read this week:

https://doi.org/10.1007/s11192-023-04806-2

Plan to read this week:

https://www.semanticscholar.org/paper/Ecosystem-level-determinants-of-sustained-activity-Valiev-Vasilescu/e8eb4dc83c7f74848c331005aa7c124dc13cf6a9?utm_source=direct_link
https://www.semanticscholar.org/paper/Beyond-the-Repository-Casari-Ferraioli/21dd9f046fc807a498840e19f6c81e69ffad8651?utm_source=direct_link
https://www.semanticscholar.org/paper/Fairness-and-Abstraction-in-Sociotechnical-Systems-Selbst-Boyd/9dae5041ed97ab21f637fb282d758fd9cb771476?utm_source=direct_link
https://doi.org/10.1162/qss_a_00275
https://doi.org/10.1162/qss_a_00277
https://doi.org/10.1162/qss_a_00264
https://doi.org/10.1162/qss_a_00266

Specific tasks 2024-03-07:

finish constructing dataset for ankil and terra
put together script for evaluating whole public comment segmentation model
choose next city council and prep data for annotation
keep working on icssi

Specific tasks 2024-03-08

put together script for evaluating whole public comment segmentation model (train fine-tune-mpnet-three-sentences for real and then apply)
read two papers from above list
start JOSS review
choose next city council and prep data
check in on nic for new email dump
check in on akhil and terra for practice annotations


Update env_logger.

This dependency doesn't really matter and the CI is still failing, so closing.


vikmeup/SCLAlertView-Swift #158

@craigpearce5:  Took your 2 lines idea but expanded to check whether text fits.  Now allows for auto-shrinkage from 14pt to 12pt to 10pt and 1 to 2 to 3 lines.  After that, you're writing a paragraph and that probably doesn't belong in a button so it will still truncate.

Added detection function based on input from Stack Overflow.  Adding it directly to this class doesn't feel right but the other option seemed to be to make yet another dependency.

@sdbarron it looks very dirty way of implementing this. make it more generic and auto adjustable. Thanks

Thanks @sdbarron works for me.


Memory Improvements - Adopt RecyclableMemoryStream.

Description
RecyclableMemoryStream is a MemoryStream replacement that offers superior behavior for performance-critical systems.
The motivation for start using it is:

Eliminate Large Object Heap allocations by using pooled buffers.
Avoid memory leaks by having a bounded pool size.
Avoid memory fragmentation.

Type of change
Please delete options that are not relevant.

[x] Performance improvement.
[x] This change requires a documentation update

Closing in-active PR's


Maintenance status

Could you kindly provide an update on the maintenance status of this library? Thank you!

Duplicate of https://github.com/glideapps/glide-data-grid/issues/712


Adding oceanic next dark theme

Added oceanic next dark theme from the official base16-textmate repo: https://github.com/chriskempson/base16-textmate/blob/master/Themes/base16-oceanicnext.tmTheme
It would be great to get this added as this is my favourite syntax theme :)

Looks good. I will go ahead and merge. Thanks!


Add Dockerfile for running molecule

This is based on https://github.com/robertdebock/docker-github-action-molecule/blob/fc79ec2e0e68500e366f30291056eb68d32e67b8/Dockerfile used in https://github.com/robertdebock/molecule-action/tree/2.6.3

Replaced by https://github.com/ome/action-ome-ansible-molecule


add socket timeouts

Note: This is PR isn't 100% ready to merge, but has been functional in my (manual) testing. I just wanted to get this up a bit early to see if anyone more familiar with the code base is available to give it a once over before I go back and refine things.
Also, I actually wrote this almost a year ago doing some proof of concept hacking, so I might not have answers to "why did you do this this way" kinds of questions.
Mostly, my question is: I'm tracking user timeouts in a completely new set of tables _usersockettimeouts and _usertimedoutsockets (and the _usertimeouts interface). Is this the right way to go about this. Is there something that already exists that I've overlooked that I should be leveraging instead?
I don't remember if I actually tested UDP (or exactly which TCP APIs I tested for that matter). Any other things I should add timeouts to/make sure work?

dang... that was to quick.
I tried to help out by decoupling the timer implementation from the actual socket timeouts. I added generic timeouts, see https://github.com/keplerproject/copas/pull/89 to alleviate your work on this. It would allow to postpone the timerwheel thing to later, so you could only do the socket based timeouts.
Anyway, looking at the code, it seems that your implementation is more complex and less generic. It sets the timeouts on the sockets, where I think the timeouts should be on the coroutine that tries to read/write the socket. Because sockets can be passed around and used in multiple places at once, where coroutines cannot, they can only be yielded at one point at any given time. Does that make sense?
Apologies regarding the timerwheel not being on LuaRocks, I'll upload it shortly.

I tried to help out by decoupling the timer implementation from the actual socket timeouts. I added generic timeouts, see #89 to alleviate your work on this. It would allow to postpone the timerwheel thing to later, so you could only do the socket based timeouts.

Oh, nice. That would really clean this up.

Anyway, looking at the code, it seems that your implementation is more complex and less generic. It sets the timeouts on the sockets, where I think the timeouts should be on the coroutine that tries to read/write the socket. Because sockets can be passed around and used in multiple places at once, where coroutines cannot, they can only be yielded at one point at any given time. Does that make sense?

Yeah, I kept going back and forth on that. Although I had a realization last night that I think means you're right. I had been thinking that you'd want to specifically disallow use from multiple threads at a time since that could cause all kinds of havoc, mostly interleaved messages in TCP send or splitting of messages on receive. But there's no reason you couldn't have send blocked in one thread and receive blocked in another safely. And UDP is even more loose, there's no reason you couldn't be sending from multiple threads at a time (although it's not clear to me if send even can block on UDP).

Apologies regarding the timerwheel not being on LuaRocks, I'll upload it shortly.

No worries, that was trivial to work around.
Does the overall logic I'm using in send, receiver`, and friends seem like the best way to go about this to you? Basically, "set a timeout just before yield & clear a timeout just before return".

Basically, "set a timeout just before yield & clear a timeout just before return".

Yes, that's right imo
reading and writing should be possible on the same socket. And the interleaving is why I added the lock class, see #90

I'll go ahead and merge the timeout stuff, and then I'll try to copy-paste your timerwheel implementation as a replacement for the timers used.
After that, all that's left is wrapping the yielding operations in a timeout.

:+1:
Looking at #89, since calling settimeout replaces any existing timeout I think I'm going to have to move setting the socket timeouts to be outside the repeat look in each wrapped socket call. I had originally avoided this to not have to even touch timers if the socket was already ready the first time we tried. You know more about the timerwheel implementation, do you think it's efficient enough for this to be a non-issue? (I think I need to do this because IIRC posix select doesn't strictly guarantee that sockets returned as ready are actually ready.)

I'm being dumb, I can just track that locally. But, I'm still curious on your thoughts if it's worth the slight hit in clarity, or if I should just always setup a timer before the first call to the inner socket.

imo always set up a timer, and always cancel after it returns. The only way for it to be safe.
The timerwheel essentially does an array lookup, and little bookkeeping. Was designed to be efficient at scale at this.

I was assuming that with copas.settimeout I'd be able to set a flag in the callback & then the coroutine would be resumed, but that doesn't seem to be the case. What's the right way to cause the coroutine to be resumed after the timeout hits with the new timeout api?

It cannot resume the coroutine, because it doesn't know where the coroutine is currently stored.
See this one for example; https://github.com/keplerproject/copas/pull/90/files#diff-1591a625b58b6dd6c4bb81d565acffa0R11 , in this case it even lives in a table that is inaccessible from Copas itself since it lives in a different module. In the sockets case they live in the sets for wanting to read/write, and they should be moved to some list indicating they need to be resumed.
So essentially the callback has the following responsibilities:

update the coroutine bookkeeping
set a flag that the timeout happened somewhere
make sure that in the next step of the scheduler the coroutine will be resumed

See this code: https://github.com/keplerproject/copas/pull/90/files#diff-1591a625b58b6dd6c4bb81d565acffa0R81-R84
NOTE: the callback runs on the main Copas thread and hence should not run any user code (nor ever yield)

Ah, okay, I definitely assumed things I shouldn't have.
Thoughts on handling it like this: https://github.com/keplerproject/copas/compare/keplerproject:8d7d966...azdle:be0b87e
That only implements timeout for receivefrom, but I wanted to get  your thoughts before I go through and do all of them. It's ending up rather verbose, but I'm struggling to think of ways to shorten it without resorting to tricks that mess with the clarity of it.

It cannot resume the coroutine, because it doesn't know where the coroutine is currently stored.
[...]
NOTE: the callback runs on the main Copas thread and hence should not run any user code (nor ever yield)

Just for my understanding, why is it part of the public API then? Is it of any use to users of the library?

Just for my understanding, why is it part of the public API then? Is it of any use to users of the library?

Yes, if you want to implement a primitive like a lock, in an external module (otherwise the lock code had to have been inside the copas module itself)
But maybe I should take the documentation out to prevent user errors?

What if we add some helpers to reduce verbosity;
(completely untested, just wrote it without checking)
local set_read_timeout, set_write_timeout, timeout_hit
do
  local coro_timedout = setmetatable({}, {__mode = "k"})

  do
    local read_timeout_cb = function(co)
      coro_timedout[co] = true
      table.insert(_timedout, co)
      _reading:remove(client)
    end

    set_read_timeout = function(client)
      local co = coroutine.running()
      local to = _usertimeouts[client]

      coro_timedout[co] = nil

      if to > 0 then
        copas.settimeout(to, read_timeout_cb)
      end
    end
  end

  do
    local write_timeout_cb = function(co)
      coro_timedout[co] = true
      table.insert(_timedout, co)
      _writing:remove(client)
    end

    set_write_timeout = function(client)
      local co = coroutine.running()
      local to = _usertimeouts[client]

      coro_timedout[co] = nil

      if to > 0 then
        copas.settimeout(to, write_timeout_cb)
      end
    end
  end

  local timeout_hit = function(client)
    local co = coroutine.running()
    local to = _usertimeouts[client]
    local hit
    if to == 0 then
      hit = true

    elseif to > 0 then
      hit = coro_timedout[co]

    else -- nil or <0; block indefinitely
      hit = false
    end

    return hit
  end
end

Then the main read function becomes something like this:
  set_read_timeout(client)
  repeat
    s, err, port = client:receivefrom(size) -- upon success err holds ip address
    if s or err ~= "timeout" then
      copas.canceltimeout()
      _reading_log[client] = nil
      return s, err, port
    elseif timeout_hit(client) then
      return nil, "timeout"
    end

    _reading_log[client] = gettime()
    coroutine.yield(client, _reading)
  until false

The behavior in your suggested code is basically what I had in this branch when I was doing the timer stuff manually, but with a less cohesive interface, so I just updated that. The timer start logic needed to happen just before the yield, though, because some operations can timeout on either a "wantread" or a "wantwrite" and we don't know which until after we try.
I left it all just in a table like sleep was before #91, I didn't notice you had made those changes when I started working, but I can go update that to use the scope style in your suggestion now that it's not matching the style of the rest of the codebase. (Not sure if I'll get to that before you see this or not.)
Also I removed a bunch of lines that forced the error to be "timeout", which I can't figure out why I added & would cause issues porting libraries from luasocket to copas sockets.

Okay, force pushed a rebase on master & a commit that changes things to match the refactor done in #91.

I noticed a naming conflict, so just added this: https://github.com/keplerproject/copas/commit/57a34f72976dbb35879d31c9471da78b37b842c4
I am still wondering though whether this PR needs all this complexity?

so I've taken your work and modified it (multiple times actually) until it came to something that I find logical and readable.
The result is in PR #97
Would you mind having a look? One thing I couldn't figure out is the test for tcp.connect, I had to comment it out. I have yet to try this on your original branch.

On your branch I'm also getting a false positive:
Thijss-MacBook:tests thijs$ lua tcptimeout.lua
testing: just_exit
testing: connect_timeout
connect somehow succeeded
stack traceback:
	tcptimeout.lua:82: in function <tcptimeout.lua:74>
Thijss-MacBook:tests thijs$

This is on a Mac, what OS did you run the tests on @azdle ?


Enhance shenyu-plugin-grpc module unit test

issues: #1460
Enhance shenyu-plugin-grpc module unit test
include：
cache
handler
loadbalance
GrpcPluginTest.java

Codecov Report

Merging #1523 (a19b0f5) into master (7a89e76) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1523      +/-   ##
============================================
- Coverage     64.94%   64.87%   -0.07%
- Complexity     2224     2255      +31
============================================
  Files           447      447
  Lines          9382     9382
  Branches        937      937
============================================
- Hits           6093     6087       -6
  Misses         2827     2827
- Partials        462      468       +6

Impacted Files
Coverage Δ
Complexity Δ

...enyu/client/tars/TarsServiceBeanPostProcessor.java
28.00% <0.00%> (-62.67%)
5.00% <0.00%> (-9.00%)

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
9.09% <0.00%> (-59.10%)
2.00% <0.00%> (-4.00%)

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
52.63% <0.00%> (-22.11%)
8.00% <0.00%> (ø%)

...yu/plugin/grpc/loadbalance/picker/EmptyPicker.java
66.66% <0.00%> (-16.67%)
4.00% <0.00%> (-3.00%)

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-11.66%)
12.00% <0.00%> (ø%)

.../plugin/grpc/loadbalance/AbstractLoadBalancer.java
69.56% <0.00%> (-6.53%)
20.00% <0.00%> (-6.00%)

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
66.66% <0.00%> (-5.56%)
6.00% <0.00%> (+1.00%)
:arrow_down:

...in/alibaba/dubbo/cache/ApplicationConfigCache.java
75.86% <0.00%> (-4.60%)
20.00% <0.00%> (ø%)

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
57.14% <0.00%> (-2.05%)
10.00% <0.00%> (ø%)

...enyu/plugin/grpc/cache/ApplicationConfigCache.java
78.04% <0.00%> (+12.19%)
8.00% <0.00%> (+1.00%)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a89e76...a19b0f5. Read the comment docs.


Update Gravatar.swift

In the Gravatar example, once sending the f (force) Query String parameter the gravatar always force the the default image no matter the value of the parameter.
Goals :soccer:

Fix Gravatar example

Implementation Details :construction:

Add or not the parameter instead of defining a different value that in fact is not currently working

Testing Details :mag:
As a simple test I've tried the following 4 URLs and only the last one returns my gravatar, the other 3 returns the default image:

https://s.gravatar.com/avatar/3fe96e96013875d792fdf56fdc9da50d?d=mm&r=pg&f=n&s=640
https://s.gravatar.com/avatar/3fe96e96013875d792fdf56fdc9da50d?d=mm&r=pg&f=y&s=640
https://s.gravatar.com/avatar/3fe96e96013875d792fdf56fdc9da50d?d=mm&r=pg&f=&s=640
https://s.gravatar.com/avatar/3fe96e96013875d792fdf56fdc9da50d?d=mm&r=pg&s=640

Sorry it's been so long, but thanks for the PR!


Release version 0.2.0

Switch urls to pypi.io, hash to sha256, add myself and Thomas as
maintainers.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Fix CID 1369398: Null pointer dereferences

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1391/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1285/ for details.