Udemy Timeout Error

I used this command to download a course which i have enrolled in udemy
youtube-dl https://www.udemy.com/aftereffects-beginners-complete -o 'videos_downloads/%(playlist_index)s-%(title)s.%(ext)s' -u myemail -p mypass
but i am getting this error after downloading some lectures
ERROR: Unable to download JSON metadata: HTTP Error 503: Connection timed out (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
I am using the latest youtube-dl version. Please Help

Post the full output of youtube-dl when run with --verbose option.

@dstftw here is the output when i run this command with -v
Code I used
youtube-dl -v https://www.udemy.com/aftereffects-beginners-complete -o 'videos_downloads/%(playlist_index)s-%(title)s.%(ext)s' -u myemail -p mypass
Output
ERROR: Unable to download JSON metadata: HTTP Error 503: Connection timed out (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you
are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Python34\lib\site-packages\youtube_dl\extractor\common.py", line 351, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "C:\Python34\lib\site-packages\youtube_dl\YoutubeDL.py", line 1890, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "C:\Python34\lib\urllib\request.py", line 469, in open
response = meth(req, response)
File "C:\Python34\lib\urllib\request.py", line 579, in http_response
'http', request, response, code, msg, hdrs)
File "C:\Python34\lib\urllib\request.py", line 507, in error
return self._call_chain(*args)
File "C:\Python34\lib\urllib\request.py", line 441, in _call_chain
result = func(*args)
File "C:\Python34\lib\urllib\request.py", line 587, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)

This is not a full output. Nevertheless most likely you have an issue with your internet connection.

Oh let me check on it then. Thanks for taking your precious time for commenting @dstftw


-C=O and -C-N groups in /frag_pdbs/N_capped0.pdb not always capped

Describe the bug
Files N_capped0.pdb stored in /frag_pdbs/  happen to miss (sometimes) capping on of -C=O group and on -C-N
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

run 1yjp_complete_P1.pdb mode=gtest g_scan="10" restraints=qm  > qr_1yjp_P1_gtest.log 2>&1
compare /frag_pdbs/1_capped0.pdb with /ase/1_capping.pdb (easiest in PyMol)
difference are atoms missing in  /frag_pdbs/1_capped0.pdb
ATOM         HC  ASN A   2      27.425  22.710  25.810  1.00 13.13           H
ATOM         H2  GLN A   4      30.434  22.688  24.990  1.00 10.29           H

Expected behavior
Files N_capped0.pdb stored in /frag_pdbs/  should be the same as /ase/N_capping.pdb used to create QM input
log file
gtest_1yjp_P1_10_Cluster1_30sec.zip
Desktop (please complete the following information):

OS: [Linux]
Phenix Version [1.19rc5-4045]
qrefine Version [v1.0-203-gc0bd92-dirty]

Fixed by commit https://github.com/qrefine/qrefine/commit/31c685956029eba3a0d300e130faa75fea9c673a
Now diff ase/0/0_capping.pdb 1-5/0_capped0.pdb = Null

Fixed from commit #31c6859 effective for 2ona, but not for some other pdbs

Fixed by @hokru commit https://github.com/qrefine/qrefine/commit/f32fe81ecc876b8ec693db43eceb1676cc426e1e


Why are these compendiums being automatically being add?

Describe the bug
I noticed these compendiums added:

I have my own and don't want these cluttering up my compendiums. I can't delete them either.
To Reproduce
Steps to reproduce the behavior:

Open compendium see folders.

Expected behavior
Allow us to hide, delete or remove them completely.
Desktop (please complete the following information):

Foundry Version: v12.331
System Version: v1.903
Hosted on Forge: No

Please do not use issues to ask a question - discord is around for that.
They are system compendiums (as defined within Foundry), which means they get automatically created and cannot be deleted. The change to using system compendiums was the result of retiring the previous dynamic compendium creation functional we used previously.


More geofence types need to be supported

Hi,@tidwall
I found that ArcGIS's geoevent is much like tile38's geofence, and it provides 12 spatial filters:

INSIDE, OUTSIDE, ENTER, EXIT,CONTAINS, CROSSES, DISJOINT, EQUALS, INTERSECTS,OVERLAPS, TOUCHES, WITHIN

It seems that it not only supports the judgment of points, but also supports the judgment of lines and polygons.
Tile38 provides 6 spatial filters, it would be great if it supports the rest of 6  spatial filters  :)

Hi @icewukong,
Some of these events may make sense, though I would need to study up on the ArcGIS geoevent service. Is there a link online to a technical document describing these event?

ArcGIS Geoevent server product Brief:
http://www.esri.com/arcgis/products/geoevent-server
Space filter instructions:
http://server.arcgis.com/en/geoevent/latest/process-event-data/filters.htm#ESRI_SECTION1_BFCDDF87620C41FF955E8AA9B24E7E0D
I hope it helps  :)

Thanks for the links. I'll look it this further.


az ad app create and az ad sp create-for-rbac should not be idempotent

Related command
az ad app create
az ad sp create-for-rbac
Is your feature request related to a problem? Please describe.
Derived from IcM 568027592
#9108 made az ad app create and az ad sp create-for-rbac use displayName to uniquely identify an application. If an application with the specified displayName already exists, Azure CLI will PATCH it with the newly provided properties by calling Update application API. This API requires microsoft.directory/applications/basic/update permission that a user may not possess. The user may only have microsoft.directory/applications/createAsOwner and expect these commands to work.
This behavior is not aligned with the underlying Create application API where displayName is not used as a primary key and multiple applications can have the same displayName. Creating applications with the same displayName will create multiple applications.
Describe the solution you'd like
Change this behavior to align with the underlying Create application API, PowerShell and Entra portal to eliminate possible confusions. In other words, the change will make calling az ad app create or az ad sp create-for-rbac multiple times create multiple applications with the same displayName.
Describe alternatives you've considered
Explicitly document this behavior and define it as by-design.
Additional context

Thank you for opening this issue, we will look into it.


Add a display_data way of displaying widgets.

This provides an experimental way to display widgets that should be backwards compatible with the current notebook implementation.

@SylvainCorlay, @jfreder - I rebased #436 on to the 6.x branch.

@jdfreder - this should be good to go now...

Fireworks and cake! :fireworks: :cake:


Change default download filename to include PEGR ID

Currently, the default download filename is something like "Galaxy15-[Filter_SAM_or_BAM_on_data_14__bam].bam", which does not include the PEGR ID. The default download filename should include the PEGR ID.

This needs to be done on the galaxy side


Homepage background image - should communicate ml5 more clearly

The current design of the main landing page view is a highlighted project. I would opt for something more specifically communicating to our audience that people have arrived at the ml5 website. At the moment, it feels too much like people are landing on the project page of the featured project since there is no reference to ml5 in the text and the background image is so dominant.
Current design

Interim solution / Proposed change towards something like...
see: https://github.com/ml5js/ml5-website-2/tree/homepage-updates

ideal solution:
We can have a ML5 sketch running in the background.. maybe something like sketchRnn?

Yes, I love the idea of featuring a project made with ml5 on the homepage but I agree right now it's too much and it feels more like I've arrived at the "Let's Read a Story" page.
I love "neighborly" so much! Hah.

Another thought on this would be to add a video montage to run in the background for large/med screens and then an image for small screens, similar to the setup here:
http://selfdriving.moovellab.com/
This might help us to:

showcase the various functions and projects made with ml5
avoid issues with running unnessary heavy computation on page load
give the landing page a bit more dynamism

We could collect a few screen recordings and videos of ml5 projects as well as people interacting with things like posenet or some snippets of coding train an other events?

I like this idea! However, I worry about the work involved with producing/creating a video. I really love the "Discover the creative possiblities of machine learning!" section and I wonder if this could be featured more up top in this area?

I think we landed on a solid, clear statis here! Further improvements could be considered through the website redesign project (#118). Closing for now!


Refactor calculate-agricultural-holiday-entitlement to new-style flow

Description
This moves the flow towards the style described in the refactoring documentation. I've concentrated on moving logic out of the flow and into the calculator. I have not spent any time trying to improve the code in the calculator (e.g. by extracting domain concepts).
I've added some unit tests for the validation that I've extracted, because this behaviour is not covered in the regression tests. However, otherwise I have not moved the tests closer to how it's described in the new-style testing documentation.
So, although there is more work that could be done on this flow and its associated classes, I think the changes in this PR are useful in their own right and if we can do just this much for all the flows, I think we'll be able to dramatically simplify the DSL.
Note that in doing this work I came across some suspect looking code, but rather than get sucked into sorting that out, I've captured the possible problems in a couple of Trello cards:

https://trello.com/c/0WNxygY4
https://trello.com/c/HXgHxbpp

External changes
None. This is just an internal refactoring.

Rebased against master to resolve conflicts and force-pushed. Ready for review.

Commit "Move first holiday_entitlement_days to be a calculator method" (27e040f96fa25afc8448c33c37da34f81bfb223d):
It looks as though if response == 'same-employer' has been removed as part of moving holiday_entitlement_days from a calculate block to the calculator. I presume this doesn't cause any problems?

Aside from my question about if response == 'same-employer', this looks good to me.

Re-writing commits to address feedback, rebasing against master, and force-pushing in preparation for merging.

Commit "Move first holiday_entitlement_days to be a calculator method" (27e040f96fa25afc8448c33c37da34f81bfb223d):
It looks as though if response == 'same-employer' has been removed as part of moving holiday_entitlement_days from a calculate block to the calculator. I presume this doesn't cause any problems?

I've re-written the commit mentioned above so that it no longer removes the if statement: 2d017b8257fda7569ec8ffccc094b08b12e836f5.
I've then added a new commit which removes the if statement and explains why it is redundant: 99240c6cc0e9151fed32c8c89f6000b29e152b67.

Once #2565 was merged, I found that I needed to make some changes to MethodMissingHelper and MethodMissingObject in order to keep IndexableContentTest passing. Since I was doing quite a bit of re-writing the git history, I've created a new PR (#2570). The relevant commits are:

"Ensure MethodMissingObject#description is always a string" (c5c43494586b1dbcc1fb4431cb8889aac3030086)
"Change MethodMissingObject overrides to return actual object" (d4af6921061e3941909494c07cf920b63b0cce83)

These changes allowed me add an "override" for "holiday_entitlement_days" and "calculator.holiday_entitlement_days" in the following two commits respectively:

"Move formatting of holiday_entitlement_days into templates" (721ee3b78f92ee00a95ea30826c8f2efcec445ca)
"Inline holiday_entitlement_days calculate blocks into templates" (65b72982f246875fe6acf436119a064589b76e04)

@chrisroos: Please could you review those new/edited commits for me?

Superseded by #2570. Closing.

I've looked at the commits you've asked me to review, @floehopper. They look good to me. I'll add a comment to PR #2570 too.


Optional user-definable adapter for DEFAULT_FLAG

Currently, DEFAULT_FLAG is a global default for new flags during WAFFLE_CREATE_MISSING_FLAGS, but that breaks down as soon as 2 flags should have different defaults, or any other late/contextual programmatic determination
One solution is somehow tying this to SETTINGs, as in https://github.com/django-waffle/django-waffle/issues/50
A more general and Django-y approach would be allowing the specification of a user-defined handler like an Adapter. Ex:
DEFAULT_FLAG_ADAPTER='my.waffle.my_flag_adapter'
...
class my_flag_adapter(waffle_core_flag_adapter):
    def resolve_flag_default(flag: str) -> bool:
      try:
          return config[f'FLAG_{flag};]
      except:
          1
      if flag == 'special_flag_1':
         return True
      return config['DEFAULT_FLAG']

A more static and closed approach would be constance-style precomputed settings:
WAFFLE_FLAG_DEFAULTS = OrderedDict([
  ('flag_x', (env.bool('FLAG_X', default=False))),
  ...
])

@lmeyerov The way that it can be mitigated right now is to invert the condition of the flag so that the desired default is always False. Instead  of IS_SOMETHING_ACTIVE, flip it to IS_SOMETHING_INACTIVE. But this is annoying. Having an option to set different defaults would be nice.


Consider migrating the .netcore projects to .Net7

It would appear that PowerShell 7.3 is now on net7, so it seems logical to move forward.

So it seems logical to move to .NET 8 😀

@ronascentes - I can't do that until after Azure Automation moves away from PS 7.2.0...
For v22.3, I'm bumping up things a little:

Moved to net6.0 (which is what PS 7.2.0 is on)
Moved to the PS7.2 SDK

I do not know exactly when Azure Automation is going to move forward, but hopefully in a few months they will... after that, I can move to something newer without breaking people.


test(SPV-1086): mock external dependencies in endpoint tests

Pull Request Checklist

[ ] 📖 I created my PR using provided  : CODE_STANDARDS
[ ] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
[ ] 🏠 I tested my changes locally.
[ ] ✅ I have provided tests for my changes.
[ ] 📝 I have used conventional commits.
[ ] 📗 I have updated any related documentation.
[ ] 💾 PR was issued based on the Github or Jira issue.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Project coverage is 45.82%. Comparing base (5d40daf) to head (207a3ea).

Files with missing lines
Patch %
Lines

...ons/testabilities/fixture_spvwallet_application.go
0.00%
16 Missing :warning:

config/config_to_options.go
0.00%
8 Missing :warning:

engine/chain/chain_service.go
0.00%
1 Missing and 1 partial :warning:

engine/client_options.go
50.00%
1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   45.93%   45.82%   -0.12%
==========================================
  Files         322      322
  Lines       13259    13276      +17
==========================================
- Hits         6091     6084       -7
- Misses       6605     6628      +23
- Partials      563      564       +1

Flag
Coverage Δ

unittests
45.82% <12.90%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

engine/client.go
55.00% <ø> (-0.74%)
:arrow_down:

engine/client_internal.go
65.35% <100.00%> (+0.22%)
:arrow_up:

engine/client_options.go
68.81% <50.00%> (-1.65%)
:arrow_down:

engine/chain/chain_service.go
60.00% <0.00%> (-40.00%)
:arrow_down:

config/config_to_options.go
0.00% <0.00%> (ø)

...ons/testabilities/fixture_spvwallet_application.go
0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d40daf...207a3ea. Read the comment docs.


[FLINK-14241][test] Add aarch64 support for container e2e test

What is the purpose of the change
Flink e2e container test runs under docker, docker-compose and kubernets. But the way Flink using to install the package doesn't work on ARM. This PR add the ARM way to install the required tools.
Brief change log

Add the ARM step to install Docker and Docker-compose
Add the ARM step to install kubernetes.

Verifying this change
This change is already covered by existing tests, such as flink-end-to-end container test.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Looks good from my side.
@zentol or @rmetzger do you have any concerns with the script updates?

I'm okay with merging this as proposed (the commit message is not correct yet). I would still feel more comfortable if we had @zentol's +1 as well.

Thanks for your review. Just fixed the merge conflic. @zentol can you take a look? Thank you.

any chance that this PR can be reviewed again? Thanks


[REFACTOR] Build a method to differentiate process type instead of port number

Is your improvement request related to a feature? Please describe
We currently use port number to differentiate the process type, we should use another more reliable method for it
https://github.com/longhorn/longhorn-manager/blob/master/engineapi/instance_manager.go#L290
cc @innobead

Verified passed on master-head (longhorn-manager a4ebed9). No issues were found in daily regression, and the instance manager custom resource correctly reflect the status of the replica and engine:
instanceEngines:
    test-1-e-0:
      spec:
        backendStoreDriver: ""
        dataEngine: v1
        name: test-1-e-0
      status:
        conditions: null
        endpoint: ""
        errorMsg: ""
        listen: ""
        portEnd: 10000
        portStart: 10000
        resourceVersion: 0
        state: running
        type: engine
  instanceReplicas:
    test-2-r-499b71c3:
      spec:
        backendStoreDriver: ""
        dataEngine: v1
        name: test-2-r-499b71c3
      status:
        conditions: null
        endpoint: ""
        errorMsg: ""
        listen: ""
        portEnd: 10010
        portStart: 10001
        resourceVersion: 0
        state: running
        type: replica
  ip: <IP_ADDRESS>
  ownerID: ip-10-0-1-190
  proxyApiMinVersion: 1
  proxyApiVersion: 5


fix for NUTCH-2473 Remove broken slf4j dependecy from indexer-elastic-rest

When trying to index into Elasticsearch using indexer-elastic-rest the following error is being thrown:
Exception in thread "main" java.lang.LinkageError: loader constraint violation: when resolving method "org.slf4j.impl.StaticLoggerBinder.getLoggerFactory()Lorg/slf4j/ILoggerFactory;" the class loader (instance of org/apache/nutch/plugin/PluginClassLoader) of the current class, org/slf4j/LoggerFactory, and the class loader (instance of sun/misc/Launcher$AppClassLoader) for the method's defining class, org/slf4j/impl/StaticLoggerBinder, have different Class objects for the type org/slf4j/ILoggerFactory used in the signature
    at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:418)
    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:357)
    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383)
    at org.apache.nutch.indexwriter.elasticrest.ElasticRestIndexWriter.<clinit>(ElasticRestIndexWriter.java:71)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
    at java.lang.Class.newInstance(Class.java:442)
    at org.apache.nutch.plugin.Extension.getExtensionInstance(Extension.java:161)
    at org.apache.nutch.indexer.IndexWriters.<init>(IndexWriters.java:57)
    at org.apache.nutch.indexer.IndexingJob.index(IndexingJob.java:123)
    at org.apache.nutch.indexer.IndexingJob.run(IndexingJob.java:230)
    at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
    at org.apache.nutch.indexer.IndexingJob.main(IndexingJob.java:239)

e66d44d removed the runtime dependency on slf4j-api-1.7.21.jar everywhere but in indexer-elastic-rest.

Thanks, @dwirz! Would you mind to open also an issue on Jira and add a short problem description there? That's required to make the change appear in the release notes.

Hey @sebastian-nagel, thx for your response. my colleague @mfeltscher opened a corresponding issue in your jira.

=> https://issues.apache.org/jira/browse/NUTCH-2473

@sebastian-nagel Any news on this? This is a blocking issue for us.

Hi @dwirz the PR does not cover or fix the issue here... do you have a patch?

Apologies @mfeltscher I missed the critical part of the patch. Just ran locally and resolved issue. Thank you and sorry for my oversight.

@lewismc No worries, thanks for merging!


Possibility to get the current address of a socket.

This PR proposes getAddress, a wrapper around the getsockname syscall. It can be useful for e.g. querying a socket's port number after binding it to port 0 (any available port).
WARNING: I have not tested the Win32 implementation.

I would absolutely love to get this merged


Update docs about resources watched by the Controller

Description of the change:
Adds explanation and example about how to correctly use Owns in the Controller to watch a secondary dependent resource.
Motivation for the change:
https://github.com/operator-framework/operator-sdk/issues/5949
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

@camilamacedo86 I think you need to remove the tagdo-not-merge/hold in order to be able to merge this.

/hold cancel
Let's see what the others think about

@rashmigottipati could you please check if this could be merged?

Hi @dacamposol ! Thanks for the contribution!
I think this is a valuable addition to the tutorial, I just have a couple minor nits that I think need to be addressed before it can be merged.

I have consumed your PR comments.
Please check :)

@dacamposol also if you could sign your commits that would fix the DCO error. git rebase HEAD~3 --signoff or however many commits were not signed.

@dacamposol also if you could sign your commits that would fix the DCO error. git rebase HEAD~3 --signoff or however many commits were not signed.

You cannot rebase a merge commit.
The DCO bot is incorrectly configured, otherwise nobody can interact with the branch directly from the web interface (like accepting proposals) or to merge main in the current branch when it's outdated.

@everettraven can this be merged, or?

@dacamposol Yep, apologies for the delay!


Comparison To Counterpart

I've noticed that there are 2 bridges here on github, the other being https://github.com/finnp/gitter-irc-bot . What are the differences? Is one more feature rich or bug free than the other? I'm sure you've probably tested it. I realize this isn't an issue with yours but it's a good thread to have here.
Thanks.

@Zensin finnp/gitter-irc-bot is not a bridge, it's a client (a bot actually) that connects to the bridge. The code in this repo powers irc.gitter.im which is the official IRC bridge for Gitter. Hope that clarifies it.


Localized file check-in by OneLocBuild Task: Build definition ID 21368: Build ID 101230599

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

closing old PR superseded by newer merged one


368 introduce IContentItem

Motivation
Which issue does this fix? Fixes #368
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

YES! Finally that test is paying of.
@Sevitas - please fix the namespace of the new class as stated in README.


Add Intel LAM/AMD UAI feature detection in X86_64

This PR enables Intel LAM and AMD UAI (similar to Armv8-a AArch64's Top Byte Ignore) feature detection. Linux kernel has supported for Intel LAM, but not AMD UAI for now.
Test is only added for AMD K19 ZEN4 RAPHAEL, Intel has no hardware with LAM for now.
References:

Intel LAM Chapter 14
AMD UAI Chapter 5.10
Linux Support

@Tomahawkd can you rebase to pick 804eaa075a64c08a953c7bb44f92bd979ef8d35e ?

Ahh, I use "Sync Fork" instead, can it be accepted? Or I have to re-create one pr?

Thx for the PR @Tomahawkd !


♻ move stuff into their own packages

What this PR does / why we need it:
It seems like the bulk of work needed for https://github.com/caikit/caikit/issues/585 and the separation of the http_server and the grpc_server dependency overlap was in tests - and in order to maintain consistency, changes had to be done in code as well. So this PR:
in code:

introduces 2 new packages, grpc_server and http_server and puts specific modules within those packages.

in tests:

introduces 2 new conftests within http_server and grpc_server packages to add specific information.
refactors the tests/runtime/conftest.py to only contain pieces of information that's needed by both.

Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

I wonder what the limits on usage of github actions are? Will we find them?

Hmm, for some reason, a test case keeps failing on 3.11 only on GH. Using 3.11 locally works fine :/

For some inexplicable reason, the changes in this PR make one test in test_abortable_action.py fail only with linux’s python 3.11 version! It works if we run our GH actions on darwin instead of linux 😭

Things that make this PR build successfully as of now:

Use darwin instead of linux for the GH code runners
Not raise errors for UserWarning
Explicitly ignore PytestUnraisableExceptionWarning

@prashantgupta24 I know this one got pretty out of control with moving things around. Let's discuss how we want to handle this going forward since this would potentially cause some serious rearrangements and breaking changes to semi-public APIs (usage of modules within caikit.runtime such as how the guardrails server operates).

Closing as Stale. @prashantgupta24 we can revisit this later if it bubbles back up


Clang messages can not close.

I have a c file with some mistakes

When i put a cursor on putchar() it appear a message like above. But when a change a cursor to another place it not disappear
and still there.

Or when i change to other files it still there:

I don't know this is a bug or i forgot some config
Thanks for your help !!!

That looks like an issue with your client (I can't tell from the screenshot which one it is).

Definitely a client bug.
Looks like vim, :call popup_clear() will fix it. (But not prevent it happening again)

Definitely a client bug.
Looks like vim, :call popup_clear() will fix it. (But not prevent it happening again)

So how to solve this problem permanently?

by filing a bug to your LSP client maintainer.

by filing a bug to your LSP client maintainer.

What do you mean?

The problem you are facing is not related to clangd. You must've installed a vim plugin to enable clangd. I am telling that you should contact maintainer of that plugin about this issue.


fix: upgrade deps

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository jenkins-x/jx-gitops for ref 1121e34797d4c268f09562ee0a02776dd17b0bea
failed to load file .lighthouse/jenkins-x/triggers.yaml in jenkins-x/jx-gitops with sha 1121e34797d4c268f09562ee0a02776dd17b0bea
failed to load source for postsubmit release
failed to unmarshal YAML file .lighthouse/jenkins-x/release.yaml in repo jenkins-x/jx-gitops with sha 1121e34797d4c268f09562ee0a02776dd17b0bea
failed to unmarshal PipelineRun YAML in repo jenkins-x/jx-gitops with sha 1121e34797d4c268f09562ee0a02776dd17b0bea
error converting YAML to JSON
yaml
line 45
could not find expected ':'

/approve

/retest

/test pr

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest


Added Khan's algorithm in C

Description
Added Khan's algorithm in C.
Fixes #682
Type of change

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

@Ayush7614 @Amit366 plz review this PR


Position series in data analysis

The position series plots in the data analysis show an option for plotting both directions on one axis, but it is not actually implemented.

Is actually implemented, was just looking in the wrong place.


Reproduce the result of symbolic regression

can't reproduce all of the result of symbolic regression, even including the hellokan.py

results are even quite different when different devices are used

also just had a major update: the line specifying determinsiticity is now included in the initialization file. Also updated hellokan.ipynb, please try and see if the problem persists. Thanks!


Allow import * as TypeName from 'option-t/<TypeName>/namespace';

Fix #1644

This should includes https://github.com/option-t/option-t/pull/1655

This should include #1655

I think we should postpone to merge it after releasing this once.


TEST contribution

This is a practice contribution for a training module. I added a new sentence, as well as the word 'to' in an existing one for better readability.
Contributor guide pull request
Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.
Quality control

[ ] 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

[ ] 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

All PRs to this repository are manually reviewed and merged.
Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

If you have an open PR, tag the PR reviewers in comment with your question: @carlyrevier, @jehchow
Open an issue in this repo and tag the PR reviewers.

@Tu-Code - This looks great! If this were a real PR, someone at Microsoft would start the review process now. Because this is just a practice one, I'm going to close it. :) Thanks for being a contributor!


[Bug] [Pytorch] There is no security check for GitProjectManager.getGitUrl, which could cause command injection

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
https://github.com/apache/dolphinscheduler/blob/8fc204940f7be5cf356f63dd223bc599f857fe69/dolphinscheduler-task-plugin/dolphinscheduler-task-pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/GitProjectManager.java#L47-L50
There is no input validation for getGitUrl and users could put shell commands here.
What you expected to happen
ensure the  getGitUrl is a valid url
How to reproduce

Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will to solve this problem


Build Partially Succeeded

CI builds are giving a new result as of version 2.0.0. BCContainerHelper is now checking for compile warnings, and if any exist, issuing this as the pipeline result. The build completes, and you get your artifact and test results, but it still shows as Failed.
BCContainerHelper needs to pay attention to .vscode/project.ruleset.json when doing the compile.

does it happen all the time? Yes
did it used to work? Yesterday (1.0.19)

I was able to get a partial workaround accomplished using the -rulesetFile parameter. But I still get partially succeeded during the tests. I think Run-AlPipeline is respecting the rulesetFile parameter for the main alc compile, but not the test app compile.

I was able to get a partial workaround accomplished using the -rulesetFile parameter. But I still get partially succeeded during the tests. I think Run-AlPipeline is respecting the rulesetFile parameter for the main alc compile, but not the test app compile.

You can try to download a new Run-AlPipeline from here: https://raw.githubusercontent.com/microsoft/navcontainerhelper/dev/AppHandling/Run-AlPipeline.ps1
and overwrite the current file here:
C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.0\AppHandling\Run-AlPipeline.ps1
That should fix the test issue.

You can try to download a new Run-AlPipeline from here: https://raw.githubusercontent.com/microsoft/navcontainerhelper/dev/AppHandling/Run-AlPipeline.ps1
and overwrite the current file here:
C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\2.0.0\AppHandling\Run-AlPipeline.ps1
That should fix the test issue.

2.0.1 will be released in a bit, where the behavior of Run-AlPipeline is reverted.
Now you need to specify -failOn 'warning' to fail the build on warnings and -failOn 'error' to fail on errors and partially succeed with warnings.

2.0.1 will be released in a bit, where the behavior of Run-AlPipeline is reverted.
Now you need to specify -failOn 'warning' to fail the build on warnings and -failOn 'error' to fail on errors and partially succeed with warnings.

failOn now works as advertised. Builds are back to succeeding even with warnings.
However, the test app compile still does not respect the rulesetFile parameter. The main app does, but not the test app.

failOn now works as advertised. Builds are back to succeeding even with warnings.
However, the test app compile still does not respect the rulesetFile parameter. The main app does, but not the test app.

Not trying to stir in your soup, but it looks like none of the code in the if $app { section of Compiling Test Apps is being executed.

Not trying to stir in your soup, but it looks like none of the code in the if $app { section of Compiling Test Apps is being executed.

Correct - things are either an $app or a $testapp.
Will have a look.

Correct - things are either an $app or a $testapp.
Will have a look.

Test apps are not build with cops and thus no ruleset applied.


Fix #7759

Note, this was introduced in https://github.com/concrete5/concrete5/pull/5640 to fix other upgrade related problems. I'm not sure the original fix is a good idea; it seems like packages might need to run their on_start() methods to define things that upgrade is going to need, like permission keys and attributes, but at the very least we should always be booting the autoloaders.


[TextanAlytics] SingleLabelClassifyBatchTest failing in nightly runs

TextanAlytics nightly test runs are failing with:

Error message
Azure.RequestFailedException : Internal server error
Status: 500 (Internal Server Error)
ErrorCode: InternalServerError
Content:
{"error":{"code":"InternalServerError","innerError":{"requestId":"7a52849f-c578-474b-83a1-5c9004dcada8"},"message":"Internal server error"}}
Headers:
Transfer-Encoding: chunked
x-envoy-upstream-service-time: 130
apim-request-id: 7a52849f-c578-474b-83a1-5c9004dcada8
Strict-Transport-Security: max-age=31536000; includeSubDomains; preload
X-Content-Type-Options: nosniff
Date: Fri, 09 Sep 2022 02:21:27 GMT
Content-Type: application/json; charset=utf-8
Stack trace
at Azure.AI.TextAnalytics.MicrosoftCognitiveLanguageServiceTextAnalysisRestClient.AnalyzeBatchJobStatusAsync(Guid jobId, Nullable1 showStats, Nullable1 top, Nullable1 skip, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/MicrosoftCognitiveLanguageServiceTextAnalysisRestClient.cs:line 239    at Azure.AI.TextAnalytics.ServiceClients.LanguageServiceClient.AnalyzeStatusAsync(String jobId, Nullable1 showStats, Nullable1 top, Nullable1 skip, IDictionary2 idToIndexMap, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/src/ServiceClients/LanguageServiceClient.cs:line 1646    at Azure.AI.TextAnalytics.AnalyzeActionsOperation.Azure.Core.IOperation<Azure.AsyncPageable<Azure.AI.TextAnalytics.AnalyzeActionsResult>>.UpdateStateAsync(Boolean async, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOperation.cs:line 287    at Azure.Core.OperationInternal1.UpdateStatusAsync(Boolean async, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationInternalOfT.cs:line 260
at Azure.Core.OperationInternalBase.UpdateStatusAsync(CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationInternalBase.cs:line 87
at Azure.Core.OperationPoller.WaitForCompletionAsync(Boolean async, OperationInternalBase operation, Nullable1 suggestedInterval, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationPoller.cs:line 79    at Azure.Core.OperationInternalBase.WaitForCompletionResponseAsync(Boolean async, Nullable1 pollingInterval, String scopeName, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationInternalBase.cs:line 202
at Azure.Core.OperationInternal1.WaitForCompletionAsync(Boolean async, Nullable1 pollingInterval, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationInternalOfT.cs:line 242
at Azure.Core.OperationInternal1.WaitForCompletionAsync(TimeSpan pollingInterval, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/core/Azure.Core/src/Shared/OperationInternalOfT.cs:line 198    at Azure.AI.TextAnalytics.AnalyzeActionsOperation.WaitForCompletionAsync(TimeSpan pollingInterval, CancellationToken cancellationToken) in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOperation.cs:line 226    at Azure.AI.TextAnalytics.Tests.TextAnalyticsClientLiveTestBase.PollUntilTimeout[T](Operation1 operation, Int32 timeoutInMinutes) in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/tests/Infrastructure/TextAnalyticsClientLiveTestBase.cs:line 72
at Azure.AI.TextAnalytics.Tests.SingleLabelClassifyTests.SingleLabelClassifyBatchTest() in /Users/runner/work/1/s/sdk/textanalytics/Azure.AI.TextAnalytics/tests/SingleLabelClassifyTests.cs:line 177
at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter1.BlockUntilCompleted()    at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)    at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func1 invoke)
at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.b__0()
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1840014&view=results

@jsquire for notification.

This problem was reported back to the service team. They said it was something that they were aware of, and they resolved it earlier last month. It hasn't repro since then, so I'm now closing this issue.


Feature/2781 add link to client

Targets #2781

Description

Added link to client detail page on the client name in project details page using route() function

Checklist:

[x] I have performed a self-review of my own code.

Closing this branch.


Is there method to close connection?

Is there a method of terminating the database connection/deleting the database from memory?

I am getting
ResourceWarning: unclosed <socket.socket fd=4, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('<IP_ADDRESS>', 33516), raddr=('<IP_ADDRESS>', 6333)>
is there any method for this

There is no method to terminate connection in user interface, we close grpc connections during object deletion stage
In other cases, we relied on the underlying cleaners.
We probably can expose method to close http connections explicitly or will add it into the __del__ as well
@Fluder-Paradyne could you provide more information about your setup please? Including python version, qdrant-client version, os? Code sample to reproduce the issue is appreciated.

It is hard to replicate with a simple script
I tried writing one but It was not getting this warning
basically there could be multiple client objects at the same time
I know it is not the best way, but in the use case I am working on it is hard to pass around single client.
so far in my testing I am only getting warnings, so I am not too concerned
It would be great if there is a close or __del__  method so, we can just close the client once work is done
instead of waiting for gc to take care of this
thanks :smile:

I just ran into this issue in a Jupyter notebook.
Using a local client, if a second copy instantiation is attempted, if fails. There does not appear to be a way to cleanly close the client. I recommend adding a .close() as well as auto close via context manager if possible.

#227

@michael-newsrx I will look into the possible options with local mode a bit later

@michael-newsrx local mode close method will be delivered with #227 as well

supported as of 1.4.0, feel free to re-open the issue in case of troubles


Error when triggering some action while drawing

Describe the bug
You can raise errors when triggering some action while drawing.
To reproduce:
1.go to https://drauu.netlify.app/
2. open the console
3. draw something
4. while drawing hit the "c" key
5. on the console you should have TypeError: Cannot read properties of undefined (reading 'dataset')
On android it does not seem possible to hit some button while drawing but it is possible on ios so you may also trigger some errors (for example click on the eraser tool while drawing).
We might let the lib user handle this with something like:
const isDrawing = ref(false);
drauu.on("start", () =>  isDrawing.value = true);
drauu.on("end", () =>  isDrawing.value = false);

and use isDrawing to disable the buttons :disabled="isDrawing".
This is the current workaround to avoid the issue, but this require extra work, especially with vanilla JS.
Maybe it can be handled inside the lib, to avoid the problematic cases.
Reproduction
https://drauu.netlify.app/
System Info
System:
    OS: Linux 6.8 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz
    Memory: 22.63 GB / 30.75 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.15.1 - ~/.nvm/versions/node/v20.15.1/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.15.1/bin/npm
    pnpm: 8.15.3 - ~/.nvm/versions/node/v20.15.1/bin/pnpm
    bun: 1.0.22 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.182

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Contributions

[X] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

After some testing I added the code part to disable the buttons while drawing and I still see this issue appearing in the log.
The problem is I don't really know how to reproduce it...
Here is the stack trace I have:
TypeError: Cannot read property 'dataset' of undefined
at Yo._appendNode (/client.js:26:27830)
at Yo.eventEnd (/client.js:26:26597)

It is clearly happing in that file: https://github.com/antfu/drauu/blob/main/packages/core/src/drauu.ts#L256
So maybe we should not pretend that currentNode can't be null (const el = this._currentNode! on line 177) and avoid the blocking by adding a simple if (el) ?

I also have other errors that I am not able to reproduce:
Failed to execute 'getTotalLength' on 'SVGGeometryElement': This element is non-rendered element.

It comes from the onEnd function for rect, line and ellipse models.
Or:
undefined is not an object (evaluating 'this.svgPointPrevious.x')

From the checkAndEraseElement function of the eraser.
I'll try to propose a fix.


Name or path begins with "admin" block page

Page files or images that start with "admin" are blocked as soon as the login system is set up. Only administrators can access this data.

You can change the path to admin via the admin plugin configuration. Just choose something else that doesn't clash.


Do I register different license key?

Hi,
I am using your plugin. It is very useful. Except this vungle plugin,  I also use another admob plugin.
So my question is:

should I register two different license key?
After  getting license key, should I monetize new ad units to replace old one?

Thanks

@cranberrygame


Update to tfx tooling

The readme still mentiones the deprecated vset utility. It should be updated to use the current tfx tool.
And Visual Studio Online should be Visual Studio Team Services :)

lol


Problem Flutter

Steps to Reproduce

...
...
...

Logs

Please feel free to open a new issue (or reopen this one) if you're able to provide some more context - this looks like it got submitted by mistake :)


Added support for custom buildpacks

Hi Joe,
I tried this changes, it works :)
But just want to add some comment:
in order to use this in Heroku:

we need to add "heroku-buildpack-multi" to the app
"heroku config:set BUILDPACK_URL=https://github.com/ddollar/heroku-buildpack-multi"
then need to specify the based buildpack:
herokuBuildpacks in Compile := Seq(
"https://github.com/mcollina/heroku-buildpack-graphicsmagick",
"https://github.com/heroku/heroku-buildpack-scala"
)
In my case, im using scala buildpack, but it can be applied for all buildpack

Thank you very much for the helps! hope i can contribute something for this git! very useful :)
Regards
Lucius

@dragoninfrontofme when using sbt-heroku, you will not need the heroku-buildpack-scala, only the jvm-common entry like this: https://github.com/heroku/sbt-heroku/blob/master/src/sbt-test/settings/buildpacks/build.sbt#L21-L24
Also, you should not need to use heroku-buildpack-multi anymore. This tool just uses the herokuBuildpacks list instead.
I'm glad it worked

Hi Joe,
Oh ok, well noted, i will do necessary changes on my end
Thank you

HI Joe
Just quick question, i am quite new with scala and heroku, would the buildpack under herokuBuildpacks setting be executed? because i am facing problem that graphicmagick "https://github.com/mcollina/heroku-buildpack-graphicsmagick" was not executed, not really sure how buildpack works. but i still looking around the solution to make it work. Currently when i run my app "gm" (command for graphicsmagick) was not found.
appreciate if you have any idea, if not then just ignore my question :)
Thank you

@dragoninfrontofme can you open a support ticket (or maybe another one, haha) and share the name of your app? That way I can take a closer look at things.


Implement Rocket.Chat attachments handling

I have implemented working version of rocket.chat attachments and tested it with Rocket.chat -> Slack.
TODO:

[ ] Generify DownloadFileAuth
[ ] Remove unnecessary dependencies from handlers
[x] do we actually need "rocket_attachments"?
[x] More caching options ?
[x] More checks if file is ok ?
[ ] Even more checks if file is ok and better handling if not
[x] Actually use cache ? is it even  necessary ?
[ ] Think more about texts of attachment

If anyone has any worthy opinion please share, thanks.

Thanks for contributing 👍
If you need any help feel free to ask here or on the chat
Some answers on your questions:

do we actually need "rocket_attachments"?

Too bad it's incompatible with slack attachments.. mattermost/slack use the same structure.
So I'm afraid we'll need to have a separate until a better idea pops up. Maybe call it "rocketchat_attachments" (it's longer, but more consistent with the naming)

More checks if file is ok ?

I think you're referring to that check in the slack code ? That's because the slack servers are too slow (or matterbridge too fast) in downloading the file, the URL is already there, but the file wasn't on the server yet. I'm not sure if that's the case with rocketchat, so maybe you can drop that check.

Actually use cache ? is it even necessary ?

With slack the cache is there because of the way slack announces file events, iirc it does it multiple times, so too avoid downloading the same file also multiple times the cache is there. If rocketchat does it only once, you could drop the cache.
Travis/build errors
Before we can merge this, the errors on travis should be fixed.
Don't hesitate to ask questions if it isn't clear on how to fix this.

more TODO:

What to do when rocket.chat restarts, it seems that the matterbridge needs restart after that
When sending ZIP files over the bridge it seems that either some HTML page is sent or the bridge hangs and fails
Also it would be great if we could resend all the messages that didn't get relayed after hang

Testing it on production like a boss :). I found some bugs and will need to implement some kind of monitoring because the process doesn't get killed but the messages are not getting relayed in some conditions.

I've noticed the "What to do when rocket.chat restarts, it seems that the matterbridge needs restart after that" issue myself, and am running a patch on my own bot. https://github.com/42wim/matterbridge/commit/1539185bd47dba573c7bf7c6de2470336940bdf4
Not sure if you're seeing the same messages about invalid and expired login or if you have another issue.

Let me know if you need any help. :)

implemented in another PR


Fix casMustChangePassView missing state.

If password management is disabled and pwdReset is true,
a java.lang.IllegalArgumentException is thrown with message:
Cannot find state with id 'casMustChangePassView' in flow 'login'.

Thank you very much for the contribution. Outstanding work. Keep 'em coming!


Syncing local to remote ignores deletes

The folders and files are still present in remote server.

I've the same problem

the same issue, rename also


Remove disused config for Signon secrets sync job.

As of https://github.com/alphagov/signon/pull/2855 we just import all non-retired Doorkeeper application secrets and all non-suspended API user keys, so that we don't have to maintain a separate config file.

Great thanks for this. Looks good to me but I'll leave approving to someone with better codebase knowledge than myself


Error due to deleted windows defender folders

I have "send and quit" this error a couple of times. It happens because I have deleted the window's defender folders and files and I have disabled windows update features.

So the software might as well change so that, it wont report this error, if it cant find the windows defender or some updates.

This shouldn't be related to defender unless something else is wrong with your system. I would guess that windows update is currently installing something, or some other application is causing problems. Try again after restarting your PC.

I deleted Defender files right before coming here to read this thread and am now feeling honored to report back any errors

After formatting windows and deleting win defender folders again, I cant reproduce the error as well.


The logic for overriding time zones of t_begin and t_end is quite a mess. Consider another approach.

Perhaps the DateTimeField type can be subclassed and extended with input of time zone and then we can read the time zone provided to the subclassed DateTimeField and put that in the tz_begin and tz_end fields respectively?

Relevant Django documentation:

https://docs.djangoproject.com/en/1.7/ref/forms/fields/#datetimefield

https://docs.djangoproject.com/en/1.7/ref/forms/widgets/#django.forms.DateTimeInput

https://docs.djangoproject.com/en/1.7/ref/models/fields/#datetimefield

Also, this, which I think I saw posted to HN recently though I can't seem to find it using algolia HN search.
Anyway, link: http://momentjs.com/timezone/

If it works, it works.


Change linting from flake8 to ruff

Failing because meilisearch-python-async got updated in the lock file and this package hasn't been updated for the newest version of Meilisearch. Could either pin meilisearch-python-async to an older version, or better closing #318 will fix the issue.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (83f0eed) compared to base (fe8b2a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #336   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          428       428
=========================================
  Hits           428       428

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Cosmos] add doc on client retry configs

This PR adds one more document for our users to leverage when using our SDK. This document specifies the different options that can be used to change the default configurations our client uses for timeouts and retrying connections. With these, users should have additional visibility into the use they can get from the SDK. Other small changes include the removal of some of the logic in our 408/503 policy and the refactoring of how some of our connection policy pieces get built.
For the timeout retry policy, we no longer mark the endpoint as unavailable, as a 408/503 doesn't necessarily point to the endpoint being unavailable and can happen by several other reasons. Changes have been made to ensure we do not do this. The document we had talking about these retries has also been changed to reflect these changes.
The one bit of the refactoring that stands out is the fact we no longer consider the connection_timeout variable when initially building the connection policy. This is due to the fact that this same variable is used in the code further down the line, in the _asynchronous_request and _synchronized_request files accordingly. This way we make sure the variable can be used separately, and is not directly overwritten when creating the connection policy if the request_timeout option is utilized as well.

Before:
408

503

After:
408

503

API change check
API changes are not detected in this pull request.

/azp run python - cosmos - tests


Add additional datasets to staging env

Please add the schema 2.0.0 version of the following datasets to the staging environment:

azimuth
human heart
human cell landscape

fyi @ambrosejcarr @brianraymor @MaximilianLombardo if there are additional datasets that would be helpful to have in staging please add here

I'm sorry - what is the purpose of this issue? And we would need to add 2.0.0 versions of the datasets?

@brianraymor its helpful for me to test explorer features on larger datasets in staging so I asked Madison to add a few. I think we do need the 2.0.0 versions (ill edit the description of the issue). I think these are already migrated to 2.0 or on the list to be migrated but please correct me if im wrong, no intention to add extra curation work.
fyi @MDunitz

I see. I'd wait until 2.0.0 re-curation is complete. It's just started.

#1735 might deprecate this story

Closing this issue since #1735 will address adding these 3 collections to the staging environment.


resolves #17 - new rule: check that conflicting attributes aren't use…

…d on the same element

did you say you wanted to add something to this or is it good?

It is good to merge, i can add the rarely used cornercases later (I'm away from the computer for couple of days and the improvement is oneliner)

cool, thanks for the input. Looking after a baby at moment so when I get a chance I'll whiz through everything and get 0.5 published. Thanks again. .


Could we get a search function

I have more than 200 mods, and it is really too difficult for me to find a certain mod. (English is not my native language).
Maybe we can have functions such as grouping/tag filtering or even divider lines to solve the management problem brought by too many mods.
It would be great if we could set remarks by ourselves.
This big update of the fifth season is a catastrophic one for me. Because all the more than 200 mods need to be updated, and when Mint updates, it will encounter a request error. I can't know which one has an error, nor can I automatically skip the wrong one to try to update the remaining ones. I have already tried to delete the cache, but still have this problem.
I see that the project has not progressed for a year. If you are still willing to update this manager, thank you very much.

A search function already exists on master. You can just start typing to search. https://github.com/trumank/mint/wiki/Usage#search

On master the search bar is modified to be always shown.


Update docs

Removes deprecated DOCS.md file and updates the link to the docs on the website.
Updates the browser table to the new upstream style
Fixes spelling
Removes assets from repository files
Since images are removed, it uses a code example for now - like e.g. the pascal wrapper does. I chose an example that shows how simple it is to call a V function from a JS UI. For me personally a real code example gives a nice insight and the most familiar way to directly interact with a library at first glance.

Rendered version: https://github.com/ttytm/v-webui/tree/update-docs

Tested if something about at least 1 approving review is required. changes with the reset. Sorry for the noise :v:

Updated webui_fn to webui.call in the example before merging


Download for SportBukkit 1.8?, Cant iniciate server.

You can find the latest build of Sportbukkit 1.8 on https://repo.oc.tc/.

it doesnt appear

https://repo.oc.tc/content/repositories/snapshots/tc/oc/sportbukkit/1.8-R0.1-SNAPSHOT/sportbukkit-1.8-R0.1-20150222.073527-11.jar

Here's the latest
https://repo.oc.tc/content/repositories/snapshots/tc/oc/sportbukkit/1.8-R0.1-SNAPSHOT/sportbukkit-1.8-R0.1-20150228.112444-12.jar

Link Sportbukkit 1.8.7? repo.oc.tc link broken

You will have to compile it yourself, there is no public download for sportbukkit 1.8 right now, as the old repo is down and the new one doesn't contain the old builds


Support convention from Pull Request

Hi,
I am wondering if server-action could support similar convention for pull request as well. I know this is more based on Conventional Commit but I see a lot of use case for something similar for pull request. After all, pull request will become merge commit : )
Maybe something like this
const target = core.getInput('target').trim();
...
 // PARSE COMMITS
  const majorChanges = []
  const minorChanges = []
  const patchChanges = []

  if (target === "commit") {
    for (const commit of commits) {
      ...
    }
  } else if (target === "pull_request"){
    const { eventName } = github.context;
    if (eventName !== "pull_request") {
      return core.setFailed(`Expected pull_request type but current event is ${eventName}`);
    }
    const pullRequest = context?.payload?.pull_request;
    if (!pullRequest){
      return core.setFailed(`Cannot find pull request title.`)
    }
    try {
      const cAst = cc.toConventionalChangelogFormat(cc.parser(pullRequest.title))
      if (bumpTypes.major.includes(cAst.type)) {
        majorChanges.push(pullRequest.title)
        core.info(`[MAJOR] Pull Request: ${pullRequest.title} of type ${cAst.type} will cause a major version bump.`)
      } else if (bumpTypes.minor.includes(cAst.type)) {
        minorChanges.push(pullRequest.title)
        core.info(`[MINOR] Pull Request: ${pullRequest.title} of type ${cAst.type} will cause a minor version bump.`)
      } else if (bumpTypes.patchAll || bumpTypes.patch.includes(cAst.type)) {
        patchChanges.push(pullRequest.title)
        core.info(`[PATCH] Pull Request: ${pullRequest.title} of type ${cAst.type} will cause a patch version bump.`)
      } else {
        core.info(`[SKIP] Pull Request ${pullRequest.title} of type ${cAst.type} will not cause any version bump.`)
      }
      for (const note of cAst.notes) {
        if (note.title === 'BREAKING CHANGE') {
          majorChanges.push(pullRequest.title)
          core.info(`[MAJOR] Pull Request ${pullRequest.title} has a BREAKING CHANGE mention, causing a major version bump.`)
        }
      }
    } catch (err) {
      core.info(`[INVALID] Skipping Pull Request: ${pullRequest.title} as it doesn't follow conventional commit format.`)
    }
  } else {
    return core.setFailed(`${target} is not know target.`)
  }

You really shouldn't bump versions during a pull request workflow...
When merging pull requests, you can either use merge, which will create an extra commit that isn't valid conventional commit, but that's fine as it will be ignored and keep parsing the other commits from the PR. Otherwise you can use squash merge which lets you define the commit message and make it conventional commit compliant.
In either cases, the bump would occur once merged in the target branch, not during any PR workflows...
Closing as no plan to support the behavior you're proposing.


Distribution Error: Failed to authenticate to Apple. Please check your credentials or try again after sometime.

I got this error when trying to distribute to Test Flight a new version of my App:
Failed to authenticate to Apple. Please check your credentials or try again after sometime.
I do have all the valid credentials configured and also the Apple Store connected as you can see below.

I just don't understand what can be happening once I've just reconnected with my Apple Account.
Is there any other particular reason for this error?
Any thoughts?
Thank you very much.

PROBLEM SOLVED after updating my Apple app-specific password. I've generated a new one in https://appleid.apple.com/ and updated my Apple connected account in App Center. I hope that helps.


Added compatibility check against PowerShell 4.

Again, sorry for the dirty commit history.

Thanks for all this. It's going to take me time to go through it. I feel much more comfortable that these functions are separated out. Unfortunately I don't have unit tests, so manually testing could take a bunch of time.
It looks like there are only a couple of changes to the core though. The check for v4 so the classes are not loaded and the the -StrictTyping switch.
I don't see tests for the code for that switch. That's the challenge with this, needing to create actual xlsx files and then opening to inspect the data to see if the results are correct.

The "restored branch to a state before I made changes commit" undoes all that other stuff. This pull request only has the version checking. The other pull request only has the test functionality. I pulled my hair out with git. If you Google for "cleaning up dirty pull request" you can get rid of my confusing commits and rollback strategy.
You can rest in peace, the StrictTyping functionality is not included in this PR. I'm playing around with that idea, writing unit tests along the way.

I'll close this request and try cleaning things up some more.


Don't allow a scene object to be added twice

GVRSceneObject.addChildObject now throws an exception if you try to add
a scene object that already has a parent.
Replaced GVRScene children array with single root node. Added
GVRScene.getRoot().

Very nice change.

This needs rebase&merge now

I did rebase and merge

Github says this still needs a rebase.

I rebased your change here: https://github.com/liaxim/GearVRf/tree/addtwice_2 and also squashed the commits.
The conflicts are in GVRScene, scene.h and scene.cpp; my branch doesn't compile since I didn't update the collider-related code. You can diff. It is pretty annoying to rebase a change that contains a long list of commits.
There are some articles about doing rebase with tortoise:
http://stackoverflow.com/questions/12528854/how-to-perform-rebase-squash-using-tortoisegit
https://tortoisegit.org/docs/tortoisegit/tgit-dug-rebase.html
We need to figure out a workflow for you that works. I am no tortoise user but we should sit down together and come up with something.

I am using GitHub desktop. Tortoise stopped working on my machine. To make that branch I did “git merge –squash”. Is that the wrong thing?
Nola
From: Mihail<EMAIL_ADDRESS>Sent: Tuesday, June 28, 2016 12:50 PM
To: Samsung/GearVRf<EMAIL_ADDRESS>Cc: Nola Donato<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Samsung/GearVRf] Don't allow a scene object to be added twice (#629)
I rebased your change here: https://github.com/liaxim/GearVRf/tree/addtwice_2 and also squashed the commits.
The conflicts are in GVRScene, scene.h and scene.cpp; my branch doesn't compile since I didn't update the collider-related code. You can diff. It is pretty annoying to rebase a change that contains a long list of commits.
There are some articles about doing rebase with tortoise:
http://stackoverflow.com/questions/12528854/how-to-perform-rebase-squash-using-tortoisegit
https://tortoisegit.org/docs/tortoisegit/tgit-dug-rebase.html
We need to figure out a workflow for you that works. I am no tortoise user but we should sit down together and come up with something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/pull/629#issuecomment-229161795, or mute the threadhttps://github.com/notifications/unsubscribe/AQw1S7mO1g0m1EBZnNLnhQUR3kWPWHNMks5qQXrTgaJpZM4I7LuD.

This is what works for me:

Configure "upstream" remote
https://help.github.com/articles/configuring-a-remote-for-a-fork/
Fetch "upstream"; this will give you the most up-to-date master of "upstream"

git fetch upstream

Rebase your branch on top of upstream/master

git checkout <your_branch>
git rebase upstream/master

Generally using "git merge" is undesirable.

Replaced by PR #663 which rebases, resolves conflicts and squashes commits


Add support for .clang_complete

Maybe this should be done in CoffeeScript instead? But I don't know CoffeeScript

thanks. but you can have .clang_complete files in subdirectories, this only handles the root and does not handle the situation when .clang_complete files are changed/updated without reloading Atom.
i have a private branch that supports all of this, as well as compile_commands.json support which i will release soon.

OK 👍


server.clj errors when port is given from environment

When the port is given to server.clj from the environment, e.g. as an environment variable or from a config file:
PORT=3001 lein run -m my-app.server
The following error results:
Syntax error (ClassCastException) compiling at (/private/var/folders/b0/m9d16cp90mg44bxkmd5mh_x80000gn/T/form-init14644285568750398614.clj:1:126).
class java.lang.Long cannot be cast to class java.lang.String (java.lang.Long and java.lang.String are in module java.base of loader 'bootstrap')

This happens because:

server.clj delegates to yogthos/config for finding the port first
yogthos/config converts to port string to a long
The signature of Integer/parseInt takes a String, forcing a class cast from the port, and causing the error

Recommended fix:

Just remove Integer/parseInt as in reagent-template, because config will ensure it is a number

It's also possible to replace with a call to Integer. as ring-server does, but I think the reagent-template has it best here (the config library already ensures it's a number, any further casting is spurious). I'm happy to create a PR with the fix if needed.

Thanks @maxov 👍  Good find and fix. Will release momentarily.


Centos6 is failing to download Ant-Contrib.jar due to Certificate error

04:05:02 TASK [Ant-Contrib : Download ant-contrib] **************************************
04:05:04 FAILED - RETRYING: Download ant-contrib (3 retries left).
04:05:10 FAILED - RETRYING: Download ant-contrib (2 retries left).
04:05:16 FAILED - RETRYING: Download ant-contrib (1 retries left).
04:05:22 fatal: [<IP_ADDRESS>]: FAILED! => {"attempts": 3, "changed": false, "dest": "/tmp/", "elapsed": 0, "gid": 0, "group": "root", "mode": "01777", "msg": "Request failed: <urlopen error [Errno 1] _ssl.c:492: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>", "owner": "root", "secontext": "system_u:object_r:tmp_t:s0", "size": 4096, "state": "directory", "uid": 0, "url": "https://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ant-contrib-1.0b2-bin.tar.gz"}

In a CentOS6 ssh environment
[root@build-digitalocean-centos69-x64-2 ~]# wget https://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ant-contrib-1.0b2-bin.tar.gz
...
--2022-02-23 13:43:18-- https://downloads.sourceforge.net/project/ant-contrib/ant-contrib/ant-contrib-1.0b2/ant-contrib-1.0b2-bin.tar.gz?ts=gAAAAABiFjn2Z4yVUpbYRIo3hCJh1MWY0zNoeX0WaaMQtlfLJARNY4GCBiwltFeSNgPIkhZzt4MrBvI-4EVRrW9Pv0xd9iSgVw%3D%3D&use_mirror=netix&r=
Resolving downloads.sourceforge.net... <IP_ADDRESS>
Connecting to downloads.sourceforge.net|<IP_ADDRESS>|:443... connected.
ERROR: cannot verify downloads.sourceforge.net's certificate, issued by `/C=US/O=Let\'s Encrypt/CN=R3':
 Issued certificate has expired.
To connect to downloads.sourceforge.net insecurely, use `--no-check-certificate'.

Can be seen in VPC and CentOS6 PR check job
VPC failure began 18th Feb
https://ci.adoptopenjdk.net/job/VagrantPlaybookCheck/1394/OS=CentOS6,label=vagrant/console
CentOS6 PR check job
https://github.com/adoptium/infrastructure/runs/5303764995?check_suite_focus=true
The latest ca-certificates on centos6 (yum) offers only version 2020.2.41, while working machines have 2021.2.50.
https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/CentOS6-Cent7SSL/tasks/main.yml may need to be updated

Closing since https://github.com/adoptium/infrastructure/pull/2488 is merged


import jwt from 'jsonwebtoken' throwing an error

when I try to import jwt from jsonwebtoken in my react app, I am getting below error:
ERROR in ./node_modules/jsonwebtoken/sign.js 18:4-21
Module not found: Error: Can't resolve 'crypto' in 'C:\Users\swami\OneDrive\Desktop\VScode\web developement\mern-apps\basic_mern_app\front-end\client\node_modules\jsonwebtoken'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
        - install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "crypto": false }

ERROR in ./node_modules/jsonwebtoken/verify.js 13:4-21
Module not found: Error: Can't resolve 'crypto' in 'C:\Users\swami\OneDrive\Desktop\VScode\web developement\mern-apps\basic_mern_app\front-end\client\node_modules\jsonwebtoken'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
        - install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "crypto": false }

ERROR in ./node_modules/jwa/index.js 3:13-30
Module not found: Error: Can't resolve 'crypto' in 'C:\Users\swami\OneDrive\Desktop\VScode\web developement\mern-apps\basic_mern_app\front-end\client\node_modules\jwa'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
        - install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "crypto": false }

ERROR in ./node_modules/jws/lib/data-stream.js 3:13-30
Module not found: Error: Can't resolve 'stream' in 'C:\Users\swami\OneDrive\Desktop\VScode\web developement\mern-apps\basic_mern_app\front-end\client\node_modules\jws\lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
        - install 'stream-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "stream": false }

ERROR in ./node_modules/jws/lib/sign-stream.js 5:13-30
Module not found: Error: Can't resolve 'stream' in 'C:\Users\swami\OneDrive\Desktop\VScode\web developement\mern-apps\basic_mern_app\front-end\client\node_modules\jws\lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "stream": require.resolve("stream-browserify") }'
        - install 'stream-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "stream": false }

ERROR in ./node_modules/jws/lib/verify-stream.js 5:13-30
Module not found: Error: Can't resolve 'stream' in 'C:\Us

I am not able to understand this error though I have installed jsonwebtoken properly using npm i jsonwebtoken .
Now, I want to use jwt for the purpose of authentication without any errors.

It looks like you are trying to use jsonwebtoken within the frontend, is that correct? The node crypto library wont be available for you in this case so you will need to polyfil it, which is what this error is saying.
If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
        - install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "crypto": false }

Yes @jakelacey2012 I am trying to use jwt in front-end, but how to include poyfills

Did you ever get this resolved?


Remove FireBase dependency

If we are only using Firebase a hosting, you dont need it as a dep.

Do you mean it only has to be a dev dependency?  @kmilo9999

We dont need it all.

It gives me errors when I remove firebase and firebase-tools, @mcmcgrath13 can you confirm? Can I make firebase a dev dependency or should I just leave it?

What's the error?
We shouldn't need firebase at all - we still might need firebase-tools


Selected figure thumbnail in Plots not highlighted in dark mode

In the dark mode when scrolling through the figures it is not very clear which is the currently shown figure, Whereas in the light mode there is a blue boundary surrounding the selected figure.
Drak Mode

Light Mode

Is it possible to make a similar boundary with probably a different color than blue for Dark theme to clarify what is the currently displayed figure? and possibly also make the thickness of the boundary line higher

Spyder version: Spyder 4.0.0.dev0 a2d0dbcbd
Python 3.7.3 64-bit | Qt 5.9.7 | PyQt5 5.9.2 | Windows 10

Dependencies

cloudpickle >=0.5.0          :  1.2.2 (OK)
pygments >=2.0               :  2.4.2 (OK)
qtconsole >=4.5.5            :  4.5.5 (OK)
nbconvert >=4.0              :  5.6.0 (OK)
sphinx >=0.6.6               :  2.2.0 (OK)
pylint >=0.25                :  2.3.1 (OK)
psutil >=0.3                 :  5.6.3 (OK)
qtawesome >=0.5.7            :  0.6.0 (OK)
qtpy >=1.5.0                 :  1.9.0 (OK)
pickleshare >=0.4            :  0.7.5 (OK)
zmq >=17                     :  18.1.0 (OK)
chardet >=2.0.0              :  3.0.4 (OK)
numpydoc >=0.6.0             :  0.9.1 (OK)
spyder_kernels >=1.5.0;<2.0.0:  1.5.0 (OK)
qdarkstyle >=2.7             :  2.7 (OK)
atomicwrites >=1.2.0         :  1.3.0 (OK)
diff_match_patch >=20181111  :  20181111 (OK)
watchdog                     :  None (OK)
keyring                      :  None (OK)
pexpect >=4.4.0              :  4.7.0 (OK)
pympler                      :  None (OK)
sympy >=0.7.3                :  None (NOK)
cython >=0.21                :  None (NOK)
IPython >=4.0                :  7.8.0 (OK)
matplotlib >=2.0.0           :  3.1.1 (OK)
pandas >=0.13.1              :  None (NOK)
numpy >=1.7                  :  1.15.4 (OK)
scipy >=0.17.0               :  None (NOK)
pyls >=0.28.2;<0.29.0        :  0.28.3 (OK)
rtree >=0.8.3                :  0.8.3 (OK)

Thoughts @jnsebgosselin ?

Not sure wither you agree on these changes.

But maybe there is a better way to get a different color (e.g. red) rather than hard coding it.

Not sure wither you agree on these changes.

Thanks a lot @Khalilsqu for taking a look at this one! I think they are fine, so please create a PR for them.

I think we should try to use a color and thickness defined by the theme, if it is possible, instead of using hard coded values specific for the plots plugin.

I have no idea how to use the theme to get different colors.
There are only two colors returned from colorname = self.canvas.palette().highlight().color().name()  when I tried some different syntax themes.
Dark Mode
automatic spyder/dark #1464a0
automatic emacs #1464a0
automatic inkpot #1464a0
automatic monokai #1464a0
automatic nightlion #1464a0
automatic oblivion #1464a0
automatic oblivion #1464a0
automatic obsidian #1464a0
automatic pastel #1464a0
automatic zenburn #1464a0
Light Mode
automatic spyder #0078d7
automatic idle #0078d7
automatic minimal #0078d7
automatic notepad++ #0078d7
automatic pydev #0078d7
automatic roboticket #0078d7
automatic scintilla #0078d7

As you can see the color #1464a0 is quite close to the spyder dark mode background color and thus not clearly visible on highlighted thumbnails.

Ah yeah you are right... it won't be easy to get the value used by the dark theme because those are hard coded in the theme and I'm not sure they are available... Ok then, let's go with the if darkstyle route.
@goanpeca do you want the color used saved somewhere else, because I think you are trying to gather them in a same place?

I think you are trying to gather them in a same place?

I think that's not possible right now, but in the link below you can find the colors used for selections in QDarkstyle:
https://github.com/ColinDuquesnoy/QDarkStyleSheet/blob/master/qdarkstyle/palette.py

Indeed until we release a newer version of QDarkStyle, we have to "hardcode" them


MySQLClientException: Can not connect: status is not fresh

hello, you did a great job on this lib, thank you
From time to time I got this exception:
MySQLClientException: Can not connect: status is not fresh
package:mysql_client/src/mysql_client/connection.dart 116  MySQLConnection.connect

may you please suggest a good way to manage the connection?
and is there any getter method to check _state of the connection ?

Hi booper. You can use connected property to check connection status.
Seems like connection is closed and you are trying to use the same connection object to initiate new connection.
FIrst thing to note, you can not reuse connection object after it is closed. Second point, we need to understand why connection is closed..

Can you recreate fresh connection instance?

You can wrap it in some function which creates connection for you, and then reuse it.

I am not sure about what to do if connection is closed due to some timeout or other database specific things

Maybe we need to implement some kind of ping to keep connection alive

Mysql docs is not super informative)

I am trying to keep the library as slim as possible, meaning that if something can be implemented by user easily it should not be part of this library. I think someone can implement ping by periodically executing some dummy quey like SELECT 1 or similar

I just need to add this into README


Show Sub-Subsections in Subroutine Hover Documentation

Something I have noticed while writing docstrings with POD is that sub-subsections are cut from the result of textDocument/hover. It's probably best if I demonstrate this with an example.
Let's say we have the following subroutine and docstring:
=pod

=head3 foobar

    $result = foobar(%params)

The C<foobar> subroutine does the I<foo bar> in a very particular manner.

You may supply additional flags in C<%params>; see below.

=over

=item C<first>

If you pass C<first =E<gt> 1>, the I<foo bar> is done in I<baz> mode.

=item C<second>

If C<second =E<gt> 1>, you get additional output depending on the I<foo bar> performed.
Mostly useful for debugging purposes.

=back

=cut

sub foobar {
    my (%params) = @_;
    # [...]
}

Everything from =over onward gets cut off (or isn't included) in the hover documentation:

The same also goes for subsections after =head3, as in =head4, =head5 and =head6. I would expect everything that's within the section for the foobar subroutine be included in its docstring.
Maybe I'm holding it wrong, so please correct me if I messed up somewhere here.
If this is something that PerlNavigator does indeed want to support / fix, I can offer a helping hand, though my TypeScript is a little rusty these days.

Hi @Aequitosh. Sure, contributions would certainly be welcome in this area. POD parsing can be challenging in general, and I wrote this POD parser from scratch (with the assistance ChatGPT), so it isn't as full featured as the ones written in Perl. I took a look and confirmed this specific issue occurs in WWW::Mechanize as an example. This ->new() section references following parameters, but they aren't displayed:

For this problem in particular, it's tricky one. The parser does keep track of which elements are in lists, but only uses this information for converting POD to Markdown, not for detecting which sections are nested or relevant. See the state.inList boolean variable which tracks this. Example:

Open to ideas and contributions on how to improve this, or any other POD related issue. Thanks!

Thanks for your detailed response! I'll have a more closer look at the code soon, perhaps I can help. This is definitely something I'd find handy, so I wanna get my hands dirty for it.

@bscan I'm currently polishing the last remaining few bits of the PR I'm going to submit, so I wanted to ask: Could you please elaborate on this here? What kind of leading comments are those? I haven't been writing Perl for that long, so I haven't encountered those yet. Would be great if you could provide an example, too! Thanks a bunch.

Thanks @Aequitosh! Here's an example of the comment format. I'm not sure how common it is in the wild, but my $work has a number of examples. It's a very specific format, so I tried to keep the parsing code for it separate from the remainder of the doc parsing code. The regex to find it is fairly complex, but it allows us to use the fairly fast regex engine instead of iterating line by line.

Ah, I see! Thanks a bunch, I'll make sure this remains supported. I'll probably keep it separate from the POD parser as well. Expect a PR this week. :)


Unreliable NetworkPingMessage Kicks Non-Authenticated Client

If a Network Authenticator is implemented, authentication can take several frames, or even seconds, or even minutes depending on complexity (e.g. account creation, character selection, etc.).
Kcp Transport invokes NetworkClient.OnConnected immediately, which calls NetworkTime.UpdateClient:
NetworkTime.cs
internal static void UpdateClient()
{
    if (Time.time - lastPingTime >= PingFrequency)
    {
        NetworkPingMessage pingMessage = new NetworkPingMessage(LocalTime());
        NetworkClient.Send(pingMessage, Channels.DefaultUnreliable);
        lastPingTime = Time.time;
    }
}

Server kicks the connection because NetworkPingMessage gets to server before Authentication has completed and server still has that connection in KcpState.Connected, logging this on server:
KCP: received unreliable message in state Connected. Disconnecting the connection.
UnityEngine.Debug:LogWarning(Object)
kcp2k.KcpConnection:RawInput(Byte[], Int32) (at Assets/Mirror/Runtime/Transport/KCP/kcp2k/highlevel/KcpConnection.cs:447)
kcp2k.KcpServer:Tick() (at Assets/Mirror/Runtime/Transport/KCP/kcp2k/highlevel/KcpServer.cs:206)
kcp2k.KcpTransport:LateUpdate() (at Assets/Mirror/Runtime/Transport/KCP/MirrorTransport/KcpTransport.cs:125)

Bottom Line
It's not Kcp's role to be draconian here.  Mirror will deal with inappropriate messages.  Kcp needs to just pass the message through and not worry about it.

for future reference: kcp authentication happens way before mirror even knows about the connection.
the unreliable message probably comes from elsewhere.


Added selector to CircleImageView

@SimoneBellotti I just realized that after applying your changes any OnClickListener set on the view is no longer working.
Replacing return true; with return super.onTouchEvent(event); in onTouchEvent(MotionEvent event) should solve the issue. :wink:

Yes, you're right! I've forgot it

Closing in favor of #35. Please have a look!

I don't like that it disables the default color filter in pressed state. Needs work.


Add query security document validation rules

Add accessors to ease rules management
Replace self by static on public methods to help extending DocumentValidator class
Use PSR-4 Autoloader
Add Complexity and Depth Query Security

see #26

Hey, thanks for your work! Just wanted to let you know that I am looking forward into merging it, just need to find time to review and digest it.


Update Go version in kapp-controller to 1.22.5 and align with Kubernetes 1.31.0

The current version of Go used in kapp-controller is golang:1.21.11, which is outdated and no longer aligned with the latest Kubernetes release. This issue is to track the effort to update the Go version in kapp-controller to the latest available version, golang:1.22.5, and align with the latest Kubernetes release, kubernetes:1.31.0.

blocked on controller-runtime bump


Can't download file seeded by libtorrent

Hi,
Thanks for great project.
I am using libtorrent-nodewrap to seed file (see libtorrent and libtorrent-nodewrap ). And I can download the file seeded by libtorrent (see download-file-libtorrent.js in my sample). But i can't download with webtorrent-hybrid (see download-file-webtorrent-hybrid.js in my sample).
Is there any way to download file from libtorrent via webtorrent-hybrid or i make mistake somewhere when config for webtorrent-hybrid?
Here is the sample code
https://github.com/kimtn-bitmark/demo-webtorrent-hybrid-libtorrent

Are you running that webtorrent-hybrid script in the browser or in node?
I believe it only works with non WebRTC torrent if run from node:
from: https://github.com/feross/webtorrent

To seed files to web peers, use a client that supports WebTorrent, e.g. webtorrent-hybrid or instant.io.

@jdoig is correct. In the browser, you can only download from clients that support WebRTC. So, if you're seeding from libtorrent, you'll need to download from webtorrent in node.js.


Refactor Tile Download Worker to Download Pending Tiles in DB

This PR updates the Tile Download worker to check the DB for pending tiles -- rather than take a list of tiles to download from the context.
This simplifies the worker--in the future, it should take an area as an argument, and only check for pending tiles that intersect the given area bounds. (It will currently check all pending tiles).

Awesome refactor, thanks a lot! A few comments/suggestions.
Also, question - are you sure we'd want to trigger one worker per Area in the future? What would be the advantage of doing that instead of having one sync the entire queue?

There's no real technical advantage, but I do think it would better fit user expectations. By tackling everything at once, there's potential for us to do more than matches the user's perception of what's going on based on the actions they took in the UI. For example if we tackle all pending tiles at once and someone attempts to download area A then quits, leaving it partially downloaded, then attempts to download area B, that will result in area A continuing (worker picks up pending tiles), and eventually being downloaded, even though they really only issued actions in the UI that explicitly communicate "download area B"--I'd rather give the user more control to determine if they want to try to download area A again, or just leave it be, or delete it.
I'm not married to such an approach though. I'm fine with chugging through everything that's still Pending—but I do think it could lead to weird interactions or "hidden features" like the case above (e.g. did you know triggering a new area download will resume your previous downloads?).
I guess the downside to triggering a worker on each area though is that if someone goes download crazy and triggers a bunch of different areas at once, or potentially the same area twice, it could result in a lot of extra work—but since we'll probably just lock the Area selection UI for now until a download fails, completes, or takes too long, I think we can ignore that case.

Also, question - are you sure we'd want to trigger one worker per Area in the future? What would be the advantage of doing that instead of having one sync the entire queue?

There's no real technical advantage, but I do think it would better fit user expectations. By tackling everything at once, there's potential for us to do more than matches the user's perception of what's going on based on the actions they took in the UI. For example if we tackle all pending tiles at once and someone attempts to download area A then quits, leaving it partially downloaded, then attempts to download area B, that will result in area A continuing (worker picks up pending tiles), and eventually being downloaded, even though they really only issued actions in the UI that explicitly communicate "download area B"--I'd rather give the user more control to determine if they want to try to download area A again, or just leave it be, or delete it.

Workers continue to run even when the user quits. If the user adds area B to the database and there's already a worker running, if the worker polls the database on each iteration until empty, it will find the new area and process it.
Also, what needs to be downloaded is currently represented by the state of the local db. If we leverage the Worker framework to represent this as well, the download queue will essentially be represented in two places (the Worker queue, and the db). Ideally we'd only have to manage one or the other.

I'm not married to such an approach though. I'm fine with chugging through everything that's still Pending—but I do think it could lead to weird interactions or "hidden features" like the case above (e.g. did you know triggering a new area download will resume your previous downloads?).

There's more room for weird edge cases if we have have essentially two ways of representing the download queue (see previous comment). It shouldn't happen that downloading a new area will resume previous downloads - if the previous downloads failed we won't retry them unless the user asks to.

I guess the downside to triggering a worker on each area though is that if someone goes download crazy and triggers a bunch of different areas at once, or potentially the same area twice, it could result in a lot of extra work—but since we'll probably just lock the Area selection UI for now until a download fails, completes, or takes too long, I think we can ignore that case.

Workers run in the background completely asynchronous, regardless of whether the app is open or not, so it wouldn't make sense to block the Area selection UI on the download queue.
I think there may be some confusion about how Workers work (could be my confusion as well). Please let me know if this makes sense!

Also, question - are you sure we'd want to trigger one worker per Area in the future? What would be the advantage of doing that instead of having one sync the entire queue?

There's no real technical advantage, but I do think it would better fit user expectations. By tackling everything at once, there's potential for us to do more than matches the user's perception of what's going on based on the actions they took in the UI. For example if we tackle all pending tiles at once and someone attempts to download area A then quits, leaving it partially downloaded, then attempts to download area B, that will result in area A continuing (worker picks up pending tiles), and eventually being downloaded, even though they really only issued actions in the UI that explicitly communicate "download area B"--I'd rather give the user more control to determine if they want to try to download area A again, or just leave it be, or delete it.

Workers continue to run even when the user quits. If the user adds area B to the database and there's already a worker running, if the worker polls the database on each iteration until empty, it will find the new area and process it.
Also, what needs to be downloaded is currently represented by the state of the local db. If we leverage the Worker framework to represent this as well, the download queue will essentially be represented in two places (the Worker queue, and the db). Ideally we'd only have to manage one or the other.

I'm not married to such an approach though. I'm fine with chugging through everything that's still Pending—but I do think it could lead to weird interactions or "hidden features" like the case above (e.g. did you know triggering a new area download will resume your previous downloads?).

There's more room for weird edge cases if we have have essentially two ways of representing the download queue (see previous comment). It shouldn't happen that downloading a new area will resume previous downloads - if the previous downloads failed we won't retry them unless the user asks to.

I guess the downside to triggering a worker on each area though is that if someone goes download crazy and triggers a bunch of different areas at once, or potentially the same area twice, it could result in a lot of extra work—but since we'll probably just lock the Area selection UI for now until a download fails, completes, or takes too long, I think we can ignore that case.

Workers run in the background completely asynchronous, regardless of whether the app is open or not, so it wouldn't make sense to block the Area selection UI on the download queue.
I think there may be some confusion about how Workers work (could be my confusion as well). Please let me know if this makes sense!

Thanks for the clarification! That makes sense—I wasn't accounting for the fact that the workers continue even after app exit. I'll remove the TODO

Also, question - are you sure we'd want to trigger one worker per Area in the future? What would be the advantage of doing that instead of having one sync the entire queue?
...lots of text
Thanks for the clarification! That makes sense—I wasn't accounting for the fact that the workers continue even after app exit. I'll remove the TODO

Removed the TODO 096707a

Think it's ready for another look, @gino-m!

Amazing work, Scott, this is going to be a very important feature for Ground. Thanks for your perserverance!