APK at v3.2.1 broken

Can you please check what went wrong with the last release? The packages contain no versionCode:
package: name='com.thehcj.quacker' versionCode='' versionName='3.2.1'

(this is from the arm64 APK, but the armeabi has the same issue). I had to disable updates for now until this is fixed, as that invalid APK would be pulled over and again.
Thanks in advance for checking and fixing!

I did not realise there was no version code on the packages, I suspect it is down to the new build process I am using and I will update it with a fix ASAP

I think I have found the root cause and I will be able to fix it by 18:00 UTC+0

This means you should be able to re-enable updates for Quacker

Sorry to disappoint you – but the APKs you've attached a few minutes ago have the same problem still:
package: name='com.thehcj.quacker' versionCode='' versionName='3.2.1'

(I just had manually triggered an update to check and make sure) Like last time, only the "fat build" is unaffected.

Yh, I think it'll be best to disable updates for now as it seems I may have screwed something up with the build scripts, I'll keep you updated!

Err… I just got a hint from someone who's interest was sparked. Could it be you've pokered a bit too high, and
300200100 * 10 + abiCode > max possible version code

?

That would be this line. You didn't seem to do that before: the arm64-v8a I have here from a previous release simply has 300003090 as versionCode – so no "x10+ABI" there. So maybe just skipping the output.versionCodeOverride for now?

I just learned:

max version code is<PHONE_NUMBER> (it's a signed 32-bit int).

So yeah, this must be the culprit – as 300200100 * 10 ><PHONE_NUMBER> (even 300003090 * 10 ><PHONE_NUMBER> which confirms that this "factor 10" must have been introduced only lately). So the "quick way out" is dropping that change again, going back to how it was before. And remember you've got not much room for increments anymore, so be careful with larger numbers :wink:

Done, I have removed the factor 10

@IzzySoft the version code issue is now fixed

Thanks! That worked out (goes live with the next sync around 7 pm UTC) – and left only…
! repo/com.thehcj.quacker_300200103.apk declares sensitive permission(s):
  android.permission.READ_EXTERNAL_STORAGE
! repo/com.thehcj.quacker_300200103.apk contains signature block blobs: 0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

The former just needs an explanation (what is read from local storage there needing that permission? The description of the app is rather short and gives no clue to that). The latter one is solved easily:
android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains.

READ_EXTERNAL_STORAGE is used for importing data from a file

Thanks! Added to the app's "green list" (which includes the reason given being shown along the permission, effective immediately).
Will you take care for the DEPENDENCY_INFO_BLOCK with one of the next releases?

I had added this code to the build file:
android {     dependenciesInfo {         // Disables dependency metadata when building APKs.         includeInApk = false         // Disables dependency metadata when building Android App Bundles.         includeInBundle = false     } }
Is that enough to take care of it?


reformet and inline codes  for TypeReference.class

Codecov Report

Merging #154 (c78237f) into main (58eac84) will increase coverage by 0.56%.
The diff coverage is 25.64%.

@@             Coverage Diff              @@
##               main     #154      +/-   ##
============================================
+ Coverage     67.81%   68.37%   +0.56%
+ Complexity     8549     8548       -1
============================================
  Files           416      416
  Lines         45553    45137     -416
  Branches       9118     8990     -128
============================================
- Hits          30891    30863      -28
+ Misses        10998    10637     -361
+ Partials       3664     3637      -27

Impacted Files
Coverage Δ

...main/java/com/alibaba/fastjson2/TypeReference.java
41.93% <25.64%> (-8.07%)
:arrow_down:

...rc/main/java/com/alibaba/fastjson2/JSONReader.java
73.77% <0.00%> (-0.10%)
:arrow_down:

core/src/main/java/com/alibaba/fastjson2/JSON.java
71.46% <0.00%> (ø)

...ain/java/com/alibaba/fastjson2/JSONWriterUTF8.java
73.63% <0.00%> (ø)

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
58.08% <0.00%> (ø)

...src/main/java/com/alibaba/fastjson/JSONObject.java
30.68% <0.00%> (ø)

...main/java/com/alibaba/fastjson/util/TypeUtils.java
15.23% <0.00%> (+3.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eac84...c78237f. Read the comment docs.


Encryption question

Hi,
as soon as i enable the encryption every single request works, but takes ~500ms on my real android device.
(without encryption it is ~30ms).
After a look at your plugin this may be due to connection open & close with every request.
The question is:
Is 500ms a normal/expected value because it seems very high to me? (Samsung A50, so the phone is not that old)
Thanks & have a good day!

@jtheiss thanks for using the plugin, Are you comparing the same request with and without encryption. the connection open and close is done the same way for with and without encryption and it give access security to the database for each request. I have notice that the android plugin is slower compare to the iOS plugin. In android i use the net.sqlcipher.database.SQLiteDatabase, net.sqlcipher.database.SQLiteOpenHelper and net.sqlcipher.database.SQLiteStatement where with iOS i worked directly with the sqlite3 api. How have you done the the time test as i might have a look at this. For the time being i am developing the sqlcipher encryption for the Electron plugin which requires all my attention.

@jepiqueau Thank you for your response!
At first i noticed this with the app i am currently working on.
To be sure there is no other influcence i created a plain ionic/angular app with the cli, added the sqlite plugin and the following simple code for testing:
import { Injectable } from '@angular/core';
import { Plugins } from '@capacitor/core';
const { CapacitorSQLite } = Plugins;

@Injectable()
export class DatabaseService {

    constructor() {
        this.createTable();
    }

    async createTable() {
        await CapacitorSQLite.requestPermissions();
        await CapacitorSQLite.open({ database: 'testing.db', encrypted: true, mode: 'secret' });
        await CapacitorSQLite.run({ statement: 'CREATE TABLE IF NOT EXISTS test (id INTEGER PRIMARY KEY, name TEXT, timestamp INTEGER);' });
    }

    public async test() {
        console.log('starting test');
        let startTime = 0;

        for (let i = 1; i <= 10; i++) {
            startTime = Date.now();
            await CapacitorSQLite.executeSet({
                set: [{
                    statement: `REPLACE INTO test (name, timestamp) VALUES (?, ?)`,
                    values: [i, Date.now()]
                }]
            });
            console.log(Date.now() - startTime);
        }

        const statements = [];
        for (let i = 1; i <= 10; i++) {
            statements.push({
                statement: `REPLACE INTO test (name, timestamp) VALUES (?, ?)`,
                values: [i, Date.now()]
            });
        }
        startTime = Date.now();
        await CapacitorSQLite.executeSet({ set: statements });
        console.log(Date.now() - startTime);

        startTime = Date.now();
        await CapacitorSQLite.query({ statement: `SELECT * FROM test`, values: [] });
        console.log(Date.now() - startTime);
    }
}

No matter if i execute 1 statement in the executeSet or all 10 together in one set it shows >500 ms with encryption.
It does not happen on the executeSet only, also the query takes the same amount of time.
Even the open & run  commands show this behaviour when i check the timestamps in adblog.
When i switch to no encryption by changing the open command { database: 'testing.db', encrypted: false, mode: null }
every command takes only 30 to 40ms.
So the commands are the same and very simple.
For me it looks like there is something expensive like key derivation performed with every request but thats only a vague guess.
It is absolutely clear that it takes longer when encryption is enabled but x10 is quiet much.

@jtheiss I have published a first alpha release of the refactor npm i @capacitor-community/sqlite@refactor and provide an Ionic/angular app to demonstrate the use https://github.com/jepiqueau/angular-sqlite-app-refactor.I have remove the open/close for each sqlite query, that should normally give a better response time. the interface of the plugin has changed allowing for connection to multiple databases and simpler interfacing like db.open(), db.close() If you could have a look and comment

@jepiqueau Thank you for your effort!
I quickly did the needed changes to my testapp and it seems to work good on android now.
There is no noticeable difference between unencrypted & encrypted anymore for this simple case.
One thing i noticed:
When i query a table wich does not exist (yes, this is my fault - meant only as feedback ;-)
the app crashes and gets closed immediately.
 FATAL EXCEPTION: CapacitorPlugins  Caused by: net.sqlcipher.database.SQLiteException: no such table: nonexistingtable: , while compiling: SELECT * FROM nonexistingtable;         at net.sqlcipher.database.SQLiteCompiledSql.native_compile(Native Method)         at net.sqlcipher.database.SQLiteCompiledSql.compile(SQLiteCompiledSql.java:89)
I would expect something like message: "Query command failed" as it was before.

@jtheis Do you mean that you have tested with the plugin refactor? You have to understand that it is not finalize yet but it good that you test it and report issues. that will help to debug and get a better and stable release when publish.
Thanks for your help.

@jtheiss I didn't succeed to crash the app when inserting in a non existing table. Did you test the result.changes.changes === -1 before continuing the rest of the code ?
    ...
    // Test on wrong table ; the table test does not exist
    const sql = "INSERT INTO test (name) VALUES (?)";
    const vals  = ["test wrong table "];
    result = await db.run(sql, vals);
    console.log('$$$ wrong table ret.changes.changes in db' + result.changes.changes)
    if (ret.changes.changes === -1 ) {
      return false;
    }
    ...

@jepiqueauy Yes, i did test the plugin refactor, sorry if that was unclear.
It is absolutely clear to me that this is an early not finished version and i will not really use it until a published version arrives.
I just tested it with my "sandbox" app only to provide you some hopefully useful feedback.
The crashing-problem does appear on a real android device with a simple query (SELECT * FROM nonexistingtable;) and it immediately crashes on native side (SQLiteCompiledSql.java:89) with the adb entry i previously provided. No javascript callback arrived at all to work with.
It is perfectly reproducable here. So let me know if you need any more information.

@jtheiss thanks for the clarification, your feedback are important to me, so thanks for taking the time.
Can you share the code, on github, where the crash happen. What do you mean by with the adb entry i previously provided ? So please give me more info

@jtheiss What is the Android device are you doing the test and what is the Android (API level) on this device

@jtheiss i test it on my physical device which is quite old Samsung Note3 running lollipop and the app failed. It cannot open the database.
E/Capacitor: Serious error executing plugin
    java.lang.reflect.InvocationTargetException
        at java.lang.reflect.Method.invoke(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:372)
        at com.getcapacitor.PluginHandle.invoke(PluginHandle.java:99)
        at com.getcapacitor.Bridge$1.run(Bridge.java:526)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:145)
        at android.os.HandlerThread.run(HandlerThread.java:61)
     Caused by: net.sqlcipher.database.SQLiteException: error code 14: Could not open database

@jtheiss i finally got it working on my samsung and it work without crashing when i ask to insert in a wrong table without changing the code. the problem above come from the deleteDatabase i still have to figure out this

@jepiqueau I tested on Samsung A50 (Android 10), but have several testing devices if you want me to test some specific android version. Just let me know.
As i said the crash does not happen on INSERT or REPLACE. Just on SELECT.

@jepiqueau ADB log means the following lines taken from the native log of the phone:
FATAL EXCEPTION: CapacitorPlugins Caused by: net.sqlcipher.database.SQLiteException: no such table: nonexistingtable: , while compiling: SELECT * FROM nonexistingtable; at net.sqlcipher.database.SQLiteCompiledSql.native_compile(Native Method) at net.sqlcipher.database.SQLiteCompiledSql.compile(SQLiteCompiledSql.java:89)
So its clear what exact statement caused the problem in which file at which line.

@jtheiss i just published a new release i changed the select the try was not at the right position. Can you test and tell me if it is working now

@jtheiss the new release is 2.9.0-alpha.3

@jepiqueau confirmed working with 2.9.0-alpha.3

@jtheiss Thanks for the confirmation 👍

@jtheiss the refactor is now on release 2.9.0-beta.1 and got all the features available for the 3 platforms. I think you can start planning to use it


make which branch to use in ansible-pull a parameter

make the ansible-pull command in ansible-pull-script.sh use a configurable branch.

done in d32d7a90f739b9b37c54a5eed1bb450e4e416b1b
One can also use a tag instead of branch name


Use const instead of let when applicable

Just a small update to use const instead of let in appropriate places, just to make the code a teeny bit more readable :)

Thanks @sebastianekstrom ;)


Cross module issue - const class fields missing default values

I have observed missing default values for fields of const constructors under a very specific conditions.

The const class must extend another class with a mixin application.
The const constructor must explicitly call super and not pass all of the arguments.
The const value must be created in a different module
This is only observed in DDC so I believe it is specific to the modular kernel compilation.

In this example, the const instance of B is missing the default value for the s field that should come from the super() call. You can see the const table in the .dill file is missing the default value.
a.dart
abstract class A {
  const A({
    this.d = 3.14,
    this.s = 'default',
  });

  final double d;
  final String s;
}

class B extends A with M {
  const B({double d = 2.71}) : super(d: d);
}

mixin M on A {
  m1() {}
}

.dill for a.dart
library from "package:example/a.dart" as a {

  abstract class A extends core::Object /*hasConstConstructor*/  {
    final field core::double* d;
    final field core::String* s;
    const constructor •({core::double* d = 3.14, core::String* s = "default"}) → a::A*
      : a::A::d = d, a::A::s = s, super core::Object::•()
      ;
    abstract member-signature operator ==(dynamic other) → core::bool*; -> core::Object::==
    abstract member-signature get hashCode() → core::int*; -> core::Object::hashCode
    abstract member-signature method toString() → core::String*; -> core::Object::toString
    abstract member-signature method noSuchMethod(core::Invocation* invocation) → dynamic; -> core::Object::noSuchMethod
    abstract member-signature get runtimeType() → core::Type*; -> core::Object::runtimeType
  }
  abstract class _B&A&M = a::A with a::M /*isAnonymousMixin,hasConstConstructor*/  {
    const synthetic constructor •({core::double* d, core::String* s}) → a::_B&A&M*
      : super a::A::•(d: d, s: s)
      ;
  }
  class B extends a::_B&A&M /*hasConstConstructor*/  {
    const constructor •({core::double* d = 2.71}) → a::B*
      : super a::_B&A&M::•(d: d)
      ;
  }
  abstract class M extends a::A /*isMixinDeclaration*/  {
    method m1() → dynamic
      ;
  }
}

main.dart
import 'package:example/a.dart';

const crossModule = B();

main() {
  print(crossModule.d);
  print(crossModule.s);
}

.dill for main.dart
library from "org-dartlang-app:///web/main.dart" as main {

  import "package:example/a.dart";

  static const field a::B* crossModule = #C3;
  static method main() → dynamic {
    core::print(main::crossModule.{a::A::d});
    core::print(main::crossModule.{a::A::s});
  }
}
constants  {
  #C1 = 2.71
  #C2 = null
  #C3 = a::B {d:#C1, s:#C2}
}

If I move the class definitions into the same file where the const is created then the default values appear to be correct.
combined.dart
abstract class A {
  const A({
    this.d = 3.14,
    this.s = 'default',
  });

  final double d;
  final String s;
}

class B extends A with M {
  const B({double d = 2.71}) : super(d: d);
}

mixin M on A {
  m1() {}
}

const sameModule = B();
main() {
  print(sameModule.d);
  print(sameModule.s);
}

.dill for combined.dart
library from "org-dartlang-app:///web/main.dart" as main {

  abstract class A extends core::Object /*hasConstConstructor*/  {
    final field core::double* d;
    final field core::String* s;
    const constructor •({core::double* d = #C1, core::String* s = #C2}) → main::A*
      : main::A::d = d, main::A::s = s, super core::Object::•()
      ;
    abstract member-signature operator ==(dynamic other) → core::bool*; -> core::Object::==
    abstract member-signature get hashCode() → core::int*; -> core::Object::hashCode
    abstract member-signature method toString() → core::String*; -> core::Object::toString
    abstract member-signature method noSuchMethod(core::Invocation* invocation) → dynamic; -> core::Object::noSuchMethod
    abstract member-signature get runtimeType() → core::Type*; -> core::Object::runtimeType
  }
  abstract class _B&A&M = main::A with main::M /*isAnonymousMixin,hasConstConstructor*/  {
    const synthetic constructor •({core::double* d = #C1, core::String* s = #C2}) → main::_B&A&M*
      : super main::A::•(d: d, s: s)
      ;
  }
  class B extends main::_B&A&M /*hasConstConstructor*/  {
    const constructor •({core::double* d = #C3}) → main::B*
      : super main::_B&A&M::•(d: d)
      ;
  }
  abstract class M extends main::A /*isMixinDeclaration*/  {
    method m1() → dynamic {}
  }
  static const field main::B* sameModule = #C4;
  static method main() → dynamic {
    core::print(main::sameModule.{main::A::d});
    core::print(main::sameModule.{main::A::s});
  }
}
constants  {
  #C1 = 3.14
  #C2 = "default"
  #C3 = 2.71
  #C4 = main::B {d:#C3, s:#C2}
}

@johnniwinther This issue is blocking a refactor change from landing in flutter. https://github.com/flutter/flutter/pull/63813

I'm going to mark this as a null safety issue since it allows null values to appear in fields marked as non-nullable and breaks soundness when running with --sound-null-safety

Here is a test in the modular test framework that shows the issue https://dart-review.googlesource.com/c/sdk/+/164251.
To run it locally:
$dart pkg/dev_compiler/test/modular_suite.dart --verbose --filter=constant_with_mixin

A CL is in the pipeline: https://dart-review.googlesource.com/c/sdk/+/164787
I've included the modular test in the CL.


Revert "Read project demographics options from dropdowns sheet"

Reverts usdigitalresponse/arpa-reporter#439
This merge has caused errors on staging. I was able to repro the bug locally, and then fix it by reverting this change. Here's the error message from the logs on staging:

Ooph, thanks for responding to the issue quickly.  Let me see if I can find my mistake.


Global Market Cap chart shows in USD regardless of currency conversion

Made worse by #207 (currency not shown on screen)

We appear to be using non-API call
https://www.coingecko.com/market_cap/total_charts_data?duration=7&locale=en&vs_currency=usd
Which doesn't obey vs_currency

Fixed

Sent email to coingecko about how to access this data via an API, not web-url.


feat(Analysis): add ProdLp and ProdL2

The file NormedSpace.ProdLp is copied from NormedSpace.PiLp with a two changes

For p = 0 we define the distance (and norm) to be equal to zero
We omit the sections about basis and constant maps

The file InnerProductSpace.ProdL2 will contain more things later on, this is also why I imported InnerProductSpace.Projection since for the adjoint I need the properties of the orthogonal complement on products.

I think it would be good to wait until #6409 is merged (or else thrown out), but I'll have an in-depth look after that.

One thing I forgot: please add a CompleteSpace instance after you define the uniform space structure.

One thing I forgot: please add a CompleteSpace instance after you define the uniform space structure.

done

Please update the PR description with the correct statement about p = 0.

Sorry for the delay. I have been very busy the previous weeks, but now I am on vacation and I can do mathlib-stuff again.

@j-loreaux, I'm not sure how to rectify that comment with your comment above. Do you want to see the L2 lemmas moved back first, or are you happy to merge it either way?

Sorry, that was unclear. I'm ready to merge it modulo moving the lemmas back.

bors merge


fix the issue of network is not known to be merged

close https://github.com/paradigmxyz/reth/issues/6453

@Rjected PTAL

yeah, as I mentioned in the issue, we should be using paris_block_and_total_difficulty

@Rjected Sorry, I missed the previous comments. I would like to confirm if I truly understand what you mean, is that correct? We can pass paris_block_and_total_difficulty to DisplayHardforks::new, something like below:
impl DisplayHardforks {
    /// Creates a new [`DisplayHardforks`] from an iterator of hardforks.
    pub fn new(hardforks: &BTreeMap<Hardfork, ForkCondition>, ttd: U256) -> Self {
        Self::from_iter(hardforks.iter().map(|(fork, condition)| (fork, condition, ttd)))
    }
}

impl<'a, 'b> FromIterator<(&'a Hardfork, &'b ForkCondition)> for DisplayHardforks {
    fn from_iter<T: IntoIterator<Item = (&'a Hardfork, &'b ForkCondition, U256)>>(iter: T) -> Self {
        let mut pre_merge = Vec::new();
        let mut with_merge = Vec::new();
        let mut post_merge = Vec::new();

        for (fork, condition, ttd) in iter {
            let display_fork =
                DisplayFork { name: fork.to_string(), activated_at: *condition, eip: None, ttd };

            match condition {
                ForkCondition::Block(_) => {
                    pre_merge.push(display_fork);
                }
                ForkCondition::TTD { .. } => {
                    with_merge.push(display_fork);
                }
                ForkCondition::Timestamp(_) => {
                    post_merge.push(display_fork);
                }
                ForkCondition::Never => continue,
            }
        }

        Self { pre_merge, with_merge, post_merge }
    }
}

yeah, we can remove the from iter impl, and add known_paris_block: Option<u64> to that
and we can add displayforks(&self) function to the chainspec type

@mattsse thanks for the advice, adjusted, and PTAL


docs: kick-off 1.12.7 release.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

/azp run

/azp run

/azp run

/assign lizan

/azp run

Can you cherry-pick #9140 #10496 #10818 to fix clang_tidy and macOS CI?

Can you cherry-pick #9140 #10496 #10818 to fix clang_tidy and macOS CI?

@lambdai is now maintaining the stable releases... You could also cherry-pick them yourself ;)
But both clang_tidy and macOS are working fine (although, a bit flaky), since they passed in #12167.


Fix Scala.js tests not running plus update SBT/Scala Version

Problem
The Scala.js tests were not running when using docker-compose run --rm sbt sbt test likely due to node changing the binary path of the installation which Scala.js couldn't detect
Solution
Update the SBT docker image to the latest version gets the Scala tests running again. It seems like the upgrade of SBT has also fixed historical memory issues with SBT, i.e.
[warn] In the last 9 seconds, 5.127 (60.2%) were spent in GC. [Heap: 0.37GB free of 1.45GB, max 1.45GB] Consider increasing the JVM heap using `-Xmx` or try a different collector, e.g. `-XX:+UseG1GC`, for better performance.
java.lang.OutOfMemoryError: Java heap space
[error] [launcher] error during sbt launcher: java.lang.OutOfMemoryError: Java heap space

No longer seems to occur on my local machine
Notes
Since the SBT docker image was updated to the latest version, I also updated the corresponding Scala versions. I have also added the coursier directory to be cached so that every test invocation doesn't need to re-download dependencies.
Note that the PR will fail to build until https://github.com/getquill/quill/pull/2183 is merged (and I rebase this PR)
Checklist

[X] Unit test all changes
[X] Update README.md if applicable
[X] Add [WIP] to the pull request title if it's work in progress
[X] Squash commits that aren't meaningful changes
[X] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@deusaquilus I have just rebased off master which includes https://github.com/getquill/quill/pull/2183 so the PR should be good to merge (the tests also passed earlier when you yourself pushed master into the branch)

@deusaquilus All tests are passing

@deusaquilus I have bumped the SBT version again (a new version just came out yesterday) and rebased it again so its ready to merge.


GDUnit Console Output difficult to read

The output on the Console is not aligned because it is not using a monospaced font.
Change the console to use a monospaced font.
Looked for option in Godot but did not see any.
Thanks for your consideration.

Hi you mean the GdUnitConsole?

Yes, it is a very small request. I admit. But if the "passed" text could all be aligned on the right side, it would really help me identify the ones not passing. Too much eye movement right now. I assumed that it might be the font, but maybe all that is needed it to align it better? Again, not a high priority. The tools is awesome, and I have tried all the other ones. This one is fast, integrated well, easy to setup/use and provides great feedback. And the assert library is spot on.
Thanks for your consideration of my small request.

Hi thanks for your feedback, that's good to hear ;)
The GdUnit console is more of a relic ;) and I left it in for completeness.
The GdUnit inspector should give you the better feedback, it also has the advantage of jumping directly to an error.
But yes the font should be monospaced, the prints are already formatted to bring in the right shape.
Best Regards


[Unit test] delete_test in filter package

Notes for Reviewers
This PR fixes for  #8087
Unit test for Mesheryctl's delete.go in the filter package
Signed commits

[ ] Yes, I signed my commits.

@suhail34, outputs are generated perfectly , you can still look through it .


Parsing CSV files of certain arbitrary lengths suddenly stops

Hi, me again, sorry. I'm seeing a problem where CSVParse seems to fail on some CSV files. I've been trying different things to try and work out what the common theme is -- and it appears to be something to do with the length (or size?) of the file.
I've written some example code which replicates the issue:
const FS = require('fs')
const FSP = require('fs/promises')
const Scramjet = require('scramjet')

async function run(n) {
    console.log(`Try: ${n}`)

    const rows = Array.from(new Array(n).keys()).map(i => `x,${i}`).join('\n')
    await FSP.writeFile('example.csv', rows)

    const x = await Scramjet.StringStream.from(FS.createReadStream('example.csv'))
        .CSVParse()
        .reduce(a => a + 1, 0)

    console.log(`Got: ${x}\n`)
}

async function loop() {
    let n = 1
    while (true) await run(n++)
}

loop()

I would expect this to just run forever, but actually it stops when n reaches 17. If I set n to 18 it stops again at 55. After that, 78. It's really odd.
If I replace .CSVParse() with .lines(), it works as expected, so it does seem to be something to do with CSV parsing.
I'm using Scramjet v4.35.10 and Node v15.6.0.

Just to add -- when this happens there's no end event

Just to add -- when this happens there's no end event

Ok, this seems a bit odd - seems that CSVParse doesn't work in this scenario, which is very strange.
Initial tests show that this is not caused by reduce. I'll keep digging.

Ok, this seems a bit odd - seems that CSVParse doesn't work in this scenario, which is very strange.
Initial tests show that this is not caused by reduce. I'll keep digging.

@maxharlow I'm still looking at this, but I think it may be connected the previous issue you reported...

@MichalCz Excellent, thanks for taking a look!

Ok, so it seems that anything over 16 items in a single return value to flatten which is used by CSVParse is actually halting.
I found the issue and a fix, but I need to take a look at the async version of flatten as this doesn't seem to keep order.

Ok, seems to work in the latest version, please confirm.

Yes, it seems to work -- thanks for the fix!


Bug: margin removed from the titles!

Describe the bug
If you open insight page on small screens the titles will not be shown:

On large screens the titles will be close to the header:

Steps to reproduce
N/A
Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

.take

.take


Adding support for other languages

Is your feature request related to a problem? Please describe.
I want to add Japanese description for sagemaker, but I don't get how to make folder like cources.
Describe the solution you'd like
Change a folder architecture like hub-docs/docs/sagemaker/en/_toctree.yaml and can add other languages under hub-docs/docs/sagemaker/{language-code}/.
Additional context
Just I want to add Japanese section.

This would be cool!
maybe tagging @mishig25

@mishig25
How about that?


Fix slow query in Payments for Account endpoint

history_operation_participants has a composite index hist_op_p_id on (history_account_id, history_operation_id) fields. When running "payments for account" query:
SELECT hop.id, hop.transaction_id, hop.application_order, hop.type, hop.details, hop.source_account, ht.transaction_hash FROM history_operations hop LEFT JOIN history_transactions ht ON ht.id = hop.transaction_id JOIN history_operation_participants hopp ON hopp.history_operation_id = hop.id WHERE hop.type IN ($1,$2,$3,$4) AND hopp.history_account_id = $5 AND hop.id > $6 ORDER BY hop.id asc LIMIT 10

Postgres query planner opt to use history_account_id part of the index and because  history_operation_id was not used in a query the execution was slow. The change in this PR is to use hopp.history_operation_id instead of hop.id when filtering and ordering results. The query is equivalent to the previous one but is using all fields of history_operation_participants.hist_op_p_id index.

 This makes we wonder if we should separate this query to a different query builder, as it operates on a different data set (ops joined with txs and participants, rather than just ops joined with txs).
Adding a special flag in the query builder for this usecase feels wrong.

Adding a special flag in the query builder for this usecase feels wrong.

Yeah, agreed, wanted to have to fixed asap. However, it wasn't a root issue. Investigating more tomorrow.

OK, let's spend more time improving the code here and we can merge it later as it's not the root cause of the issues.

@bartekn can we close this PR?

ping @bartekn, what do you plan to do with this PR?

@nikhilsaraf closing this and opening #515.


Document how you are using axe

How is what you are building compare with:

https://github.com/alphagov/accessibility-monitoring
https://github.com/GovTechSG/purple-hats or https://github.com/CivicActions/purple-hats
https://github.com/MSU-NatSci/DomainAccessibilityAudit
https://github.com/benbalter/Site-Inspector

Does it crawl the site or just review the home page?

Hi @mgifford sorry for the delay in getting back to you! We're currently using scrapy to crawl each page and then we're running axe-core against all the results and then pulling them into our reporting dashboard. Example below.
The main different between this product and the ones listed above is that we're also performing security scans against websites to help identify vulnerabilities as new features are developed.
An architecture diagram is on the list of things we need to do!


kcgi: 0.10.8 -> 0.13.0

Description of changes
Update kcgi to 0.13.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Coud you please add this url as a changelog site to the meta section? https://kristaps.bsd.lv/kcgi/archive.html

done

@MaxHearnden could you update to 0.13.3?


Allow changing image's tag when building with kaniko

Allow the user to configure which image's tag
from kaniko want to use for the building process.
MGMT-11383

/ok-to-test

/lgtm
/approve


memory leak

now，i use your code success by write kotlin support in gradle file , but ,when i test my code , i found oom in androidstudio monitor, and i write some destroy code in onstop funciton, but it still oom,do you have some ways to solve it?thanks!

hi,
I'm not aware of a memory leak.
Can you check what reference is leaking? Or I need a sample project in which this can be reproduced.
be aware that an oom does not always imply a memory leak. The Epub can be quite large and could itself need a lot of memory.


ClearingOperations.tbx needs unit tests written.

ClearingOperations.tbx currently has no unit tests written.
Minimum Requirements:
Confidence that after unit tests are run that the toolbox works as expected.
Tests Will need to be written to both run against ArcMap and ArcGIS Pro.
Max Requirements:
Ask yourself, "Am I writing tests for the sake of writing tests?".  If they provided little to no value, please don't write one.
Main Focus:
Focus tests on workflows customers would use.  If additional instructions on workflows are needed please refer to the solutions pages:
http://solutions.arcgis.com/defense/help/clearing-operations/
Tests needed:

[ ] CanvasAreaGRG
[ ] NumberFeatures
[ ] PointTargetGRG

Note: issue depends on / related to #531 (add toolbox to repo)

Number Features tool also exists in Compound Map Tools toolbox as a separate tool. See if the test can be shared between toolboxes:
https://github.com/Esri/solutions-geoprocessing-toolbox/issues/539

This has been completed.


add Ignore option

See #360

Thanks for considering this feature!
As my comment on #360 says, I don't mind at all!


(*repo.CurrencyValue).ConvertTo accepts a *repo.CurrencyConverter

Isolated the conversion behavior within ConvertTo to live within
repo.CurrencyConverter. It will be provided with a rater interface with
a single method requirement that is satisfied by a subset of today's
wallet-interface.ExchangeRates interface. This change eventually leads
to a wallet-independent exchange rate service which can be separated
later.
Supercedes https://github.com/OpenBazaar/openbazaar-go/pull/1949

Coverage increased (+0.2%) to 41.636% when pulling f98aac8fefd79d542b7c1d571961f44c0e2c9e48 on refactor-price-conversion into<PHONE_NUMBER>186c51118ff6b38d1885d9c10bda8b on ethereum-master.

LGTM. Nothing stands out. Very helpful refactor.


Add support for "global" path object parameters

Hi,
As specified in the spec, the paths object can contain parameters property as well and not only http method names.
As I see in the code, it expects only http methods.
I use this when using path templating so instead of declaring the path parameter in every operation, I declare it once to be "global" of some specific path.

Just noticed that there is no support for path templating at all :)
The request must contain a path param 'userId' which defined under the path and not under the http verb. While invoking all operations inside this path (get and delete), the 'userId' parameter has to be replaced with the real 'userId':
swagger: '2.0'

info:
  version: "0.0.0"
  title: <enter your title>

paths:
  /users/{userId}:
    parameters:
      -
        name: userId
        in: path
        description: User's id
        required: true
        type: string
    get:
      description: Get user
      operationId: findById
      responses:
        200:
          description: User returned
          schema:
            type: object
            properties:
              name:
                type: string
        404:
          description: User not found
    delete:
      description: Delete user
      operationId: delete
      responses:
        200:
          description: User deleted

In JSON:
{
    "swagger": "2.0",
    "info": {
        "version": "0.0.0",
        "title": "<enter your title>"
    },
    "paths": {
        "/users/{userId}": {
            "parameters": [
                {
                    "name": "userId",
                    "in": "path",
                    "description": "User's id",
                    "required": true,
                    "type": "string"
                }
            ],
            "get": {
                "description": "Get user",
                "operationId": "findById",
                "responses": {
                    "200": {
                        "description": "User returned",
                        "schema": {
                            "type": "object",
                            "properties": {
                                "name": {
                                    "type": "string"
                                }
                            }
                        }
                    },
                    "404": {
                        "description": "User not found"
                    }
                }
            },
            "delete": {
                "description": "Delete user",
                "operationId": "delete",
                "responses": {
                    "200": {
                        "description": "User deleted"
                    }
                }
            }
        }
    }
}


Added issue badge in readme file

Pull Request Test Coverage Report for Build 277

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 98.997%

Files with Coverage Reduction
New Missed Lines
%

nexmo/init.py
2
99.0%

Totals

Change from base Build 273:
0.0%

Covered Lines:
296

Relevant Lines:
299

💛  - Coveralls

Pull Request Test Coverage Report for Build 277

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 98.997%

Files with Coverage Reduction
New Missed Lines
%

nexmo/init.py
2
99.0%

Totals

Change from base Build 273:
0.0%

Covered Lines:
296

Relevant Lines:
299

💛  - Coveralls

I'm not that keen on "Issues Open" as a metric. I open issues to keep track of ideas and improvements, whereas bugs get fixed quickly.


Add RouteTarget and VRF factories. Add TenancyFilterTestCaseMixin and refactor

Towards: #2283
What's Changed

Added factories for RouteTarget, VRF, Role, VLANGroup, and VLAN models and add these factories to the test runner.
Added OrganizationalModelFactory and PrimaryModelFactory base classes - currently these are mostly empty but I've left TODO comments regarding potential areas for extension of these. I moved the Tag mapping logic out of the individual factories and into PrimaryModelFactory so that it doesn't need to be repeated everywhere.

Also added BaseModelFactory as a common parent of these two classes, and overrode the _create API (which despite the leading underscore is a documented extension point) to call our .validated_save() method when creating model instances to ensure they are valid.

Added get_random_instances factory helper function, and used it for Tag mapping as well as import_target/export_target mapping on the VRF factory.
As a result of the factory updates, I discovered a bug in the filtering test updates for tenant_group filters that I made in #2479, specifically that the tests weren't accounting for the fact that tenant_group is a TreeNodeMultipleChoice filter and so matches not only against the specific tenant group(s) provided, but also any of their descendants. As a result many of the test_tenant_group tests began failing after I modified the factories (and hence the specific set of random data being generated) because they weren't accounting for the possibility of sub-groups.

Testing for tenant and tenant_group filters is basically boilerplate, and I got tired of making the same change in a dozen different places, so I went ahead and created a TenancyFilterTestCaseMixin class and made use of it throughout our tests. This results in a decent amount of test code reduction, yay!

TODO

[x] Explanation of Change(s)
[x] Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
n/a Example Plugin Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

This is looking pretty good. I'd like to understand a little bit more the need for two separate random instance getters.

One is for getting a single random instance (e.g., ForeignKey), the other is for getting 0-to-n random instances (e.g., ManyToManyField). The latter is "new" in this PR but only inasmuch as it's a generalization of the get_random_tags_for_model function that was introduced in #2479. (Which I just realized is still left in the code at the moment, even though it's no longer used - will get that fixed in the next commit.)

One change I want to draw attention to is the change in the various test_filter cases from:
self.assertEqual(self.filterset(params, self.queryset).qs.count(), HARDCODED_NUMBER)

to:
self.assertQuerysetEqual(self.filterset(params, self.queryset), self.queryset.filter(...))

First, it accounts for the fact that due to factories we don't necessarily have a specific number of filtered instances known in advance. But secondly, using assertQuerysetEqual instead of just assertEqual(count, count) makes for a stronger test IMHO.
In some cases, the queryset ordering may not necessarily be guaranteed, such as in the VRF case where we might have two VRFs with the same name and a null rd value, the relative ordering of which would not be guaranteed. In these cases (only) we need to pass ordered=False to the assertQuerysetEqual() call.


make unit for startup timeout more obvious

there is no documentation in what unit the parameter for withStartupTimeout is. Thats why i made it more obvious buy:

adding a comment in the readme example
adding "Ms" to the Param-Name (so you see it in your IDE directly)

Thanks for raising @mdunisch, would you mind also updating the variable name in the interface?
https://github.com/testcontainers/testcontainers-node/blob/08454582aee7efd74312236040dc76d6c907d3a5/src/test-container.ts#L41

Thanks for raising @mdunisch, would you mind also updating the variable name in the interface?
https://github.com/testcontainers/testcontainers-node/blob/08454582aee7efd74312236040dc76d6c907d3a5/src/test-container.ts#L41

@cristianrgreco fixed!


[WIP] Build website with Jekyll

it almost works, see the current diff of the HTML here for now.
The only think which is missing is having the current page being highlighted and not clickable in the navbar. Advantage is that Header and Footer (and a few other things) are in only 1 place for the all website, which will be much nicer for update.
Wi a bit of word we can also just drop a markdown file somewhere to create a new page.
(I'll rebase and remove _site once this is ready)

Very happy about templating if it remains consistent here. :+1:

Builds on my GitHub pages: http://carreau.github.io/jupyter.github.io/.
Already happy about templating and having fixes in 1 place.

Great, but there are some visual style differences:

Current page is not highlighted in orange in nav bar.
Vertical position of main logo on home page is different.

Can you add a README.md with instructions on how to install the needed dependencies and rebuild the site - focused on designers who don't code?

I am +1 on this though.

Although I would probably prefer to do this type of thing in with node.js - but not a big deal

The point of using Jekyll is the build step is done by github. There is no step needed to recompile the website. It is what powers github pages. I'm working on Fixing the toolbar/orangy thing.
Regarding node by curiosity, what would you use ?
Envoyé de mon iPhone

Le 20 oct. 2015 à 19:01, "Brian E. Granger"<EMAIL_ADDRESS>a écrit :
Although I would probably prefer to do this type of thing in with node.js - but not a big deal
—
Reply to this email directly or view it on GitHub.

@ellisonbg can you give a look at http://carreau.github.io/jupyter.github.io/ again ? All should be fixed.
Differences are :
Footer  About->Project (to match NavBar) + Build date.
Rest should be identical.
Note do not merge yet will not build if merged, there is a custom option in order for it to build on my fork.

Looks good, I would go ahead with things.
On Wed, Oct 21, 2015 at 12:55 AM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

@ellisonbg https://github.com/ellisonbg can you give a look at
http://carreau.github.io/jupyter.github.io/ again ? All should be fixed.
Differences are :
Footer About->Project (to match NavBar) + Build date.
Rest should be identical.
Note do not merge yet will not build if merged, there is a custom
option in order for it to build on my fork.
—
Reply to this email directly or view it on GitHub
https://github.com/jupyter/jupyter.github.io/pull/50#issuecomment-149783001
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

rebased; cleaned; squashed; updated.
Should be ready for merge.


Need ability to set context path.

As it stands right now there is no way to set the Context path with this module, as the template file does not support it.
Thanks,
Stephen

@stephenshubin do you think you could provide a patch?


Pydantic error field required (type=value_error.missing) in LLMChainExtractor or ContextualCompressionRetriever

System Info
langchain          0.0.343
langchain-core     0.0.7
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[X] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
retriever = AzureCognitiveSearchRetriever(content_key="content", top_k=5)

llm = AzureChatOpenAI(
    openai_api_version="2023-05-15",
    azure_deployment="larger-chat-35",
)

template = """
I want you to act as a research assistant. you will answer questions about the context.

Context: {context}
Question: {question}?
"""

prompt = PromptTemplate(
    input_variables=["question", "context"],
    template=template,
)

compressor = LLMChainExtractor.from_llm(llm)
compression_retriever = ContextualCompressionRetriever(base_compressors=compressor,
                                                         base_retriever=retriever)

Expected behavior
I'd expect the compression_retriever to be instantiated. But instead I receive the following error:
pydantic.v1.error_wrappers.ValidationError: 1 validation error for ContextualCompressionRetriever
base_compressor
  field required (type=value_error.missing)

Ah very simple solution. I had "base_compressors" in the kwargs rather than "base_compressor" no s. Maybe this will be useful for someone else!


[BUG] Immediate Crash

Describe the bug
To Reproduce

Install on UNRAID
Start Container
Container stops, no error message shown

Expected behavior
Container Runs or shows crash notification
Screenshots

Configuration

Additional context
Has been running without problems for months. Have not touched the config file. App crashes hard starting a week ago.

Hello, you have to remove the UID and the UMASK in the unraid template :)
Have a good day.

The way I implemented PUID and PGID is causing problem in UNRAID. Try removing it.

yup, that seems to have worked. thank you


Add Config Sections

Closes #11602
Certain configs have always been begging for some form of section system. When merging multiple plugins together, being able to separate their options would be very useful.
Sections can be toggled by clicking anywhere on them, and are persisted through the config. It is possible to nest configs inside one another. Each level of nesting adds a small but noticeable margin on the left side.
I have added sections to Chat Color (which desperately needed it) to show users that there are 2 sets of options, and to Ground Items to hide potentially gigantic item lists.
Feedback on the design of the sections is very much appreciated

(Above gif is outdated, as the text is now RL orange. See comments below)

Updated the visuals from feedback in the Discord

this will probably close #6707

Updated with @Nightfirecat's suggestions. The icon is now slightly smaller, but it looks better in my opinion.

Alright, I've added sections for all the plugins currently in the client, and also split up the hardwood grove swap since it fell into two headings.

04cbc88 and a3e3aed can be merged imo. Adding config sections support and adding a saving mechanism for it should be one change.

In some config sections, expanding a config section can cause the section header underline to narrow, and the arrow to move left with it. For example, in the MES config panel, collapse all sections then toggle the "Item Swaps" section to see the following behavior:

Fixed this weird issue, added a log message if the reflection fails, and updated to work with the new Ignored Events configitem


Babebiosis

Label
Babebiosis
Synonyms
No response
Synonym type
None
Definition
Babesiosis is a disease caused by microscopic parasites that infect red blood cells. Many different species (types) of Babesia parasites have been found in animals, only a few of which have been found in people. Babesia microti—which usually infects white-footed mice and other small mammals—is the main species that has been found in people in the United States. Occasional cases caused by other Babesia species have been detected. The main way to acquire an infection is through a tick bite. Many people who are infected with Babesia microti feel fine and do not have any symptoms. Some people develop nonspecific flu-like symptoms, such as fever, chills, sweats, headache, body aches, loss of appetite, nausea, or fatigue. Babesiosis can cause a special type of anemia called hemolytic anemia. Symptoms can be severe in people who have a weaker immune system, those who do not have a spleen, are elderly or have serious health conditions. Effective treatments are available. People who do not have any symptoms or signs of babesiosis usually do not need to be treated.
Parent term
Rare parasitic diseases
Children term(s)
No response
ORCID Identifier
No response
Website URL
https://www.cdc.gov/parasites/babesiosis/treatment.html https://www.orpha.net/consor/cgi-bin/OC_Exp.php?lng=EN&Expert=108
Additional comments
NORD report.

Hi Nicole!  I was able to find this one: MONDO:0005661 so I believe this can be closed. Thank you!


Working with a csv.file directly

Hi, I am currently trying to implement your model using my own dataset, which is in a .csv format containing SMILES codes for molecules along with their corresponding HomoLumo values. My goal is to apply your model as it is, following the procedures outlined in the OGB utility scripts. However, I am having difficulty integrating my .csv file into the pipeline, particularly when it comes to data preprocessing, such as splitting the data and performing the necessary conversions and embeddings to train the model. I am a beginner in machine learning, I would greatly appreciate any guidance or suggestions you could provide to help me successfully process my data and implement the model.Thank you very much.

You basically need to implement a class similar to this and use that dataset
https://github.com/shamim-hussain/egt_pytorch/blob/9e66956a5fdc6f6e8a865863d029468380bb63e5/lib/data/pcqm4mv2/data.py#L8C1-L49C21
Notice that in record_tokens function we create a unique identifier for each molecule, and in read_data we specify how to get the graph data (nodes, edges, target). Notice how we use the smiles2graph function to convert smiles into graphs.

Its working now. Thank you so much.

You are welcome


"rfbrowser init" fails due to "UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 1022-1023: unexpected end of data" after latest 19.1.0 release

Describe the bug
Our CI pipeline started failng few days ago due to problems with rfbrowser init command. We have discovered that it is due to the latest 19.1.0 version of robotframework-browser. After downgrading it to 19.0.1 initialization works fine. The issue does not seem to occur on Windows, but in our Docker image built on Ubuntu 22.04 (Jammy) it keeps failing (the Dockerfile for reproducing the bug is attached in the reproduction section). Below is the error stack trace when using the newest release:
    sys.exit(cli())
  File "/root/.local/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/root/.local/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/root/.local/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/root/.local/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/root/.local/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/root/.local/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/root/.local/lib/python3.10/site-packages/Browser/entry/__main__.py", line 488, in init
    raise err
  File "/root/.local/lib/python3.10/site-packages/Browser/entry/__main__.py", line 480, in init
    _rfbrowser_init(skip_browsers, silent_mode, with_deps, browser)
  File "/root/.local/lib/python3.10/site-packages/Browser/entry/__main__.py", line 280, in _rfbrowser_init
    _unix_process_executor_with_bar(
  File "/root/.local/lib/python3.10/site-packages/Browser/entry/__main__.py", line 187, in _unix_process_executor_with_bar
    message = output.decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 1022-1023: unexpected end of data
The command '/bin/bash --login -i -c ~/.local/bin/rfbrowser init' returned a non-zero code: 1

To Reproduce
Steps to reproduce the behavior:

Create requirements.txt with following dependencies:

robotframework == 7.1.1
robotframework-browser == 19.1.0
robotframework-requests == 0.9.7

Build a docker image from the given Dockerfile (should be place in the same directory as requirements.txt):

FROM mcr.microsoft.com/playwright/python:v1.41.0-jammy

RUN pip install virtualenv

RUN apt-get update \
    && apt-get install -y ca-certificates curl gnupg \
    && curl -fsSL https://deb.nodesource.com/setup_20.x | bash - \
    && apt-get update \
    && apt-get install -y \
        nodejs \
        npm \
    && apt-get install -f -y \
    && apt-get clean

SHELL ["/bin/bash", "--login", "-i", "-c"]

# Install NVM in order to install NodeJS 20
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
RUN nvm install 20.9.0 && nvm use 20.9.0

# Install robotframework-browser
COPY requirements.txt /tmp/requirements.txt
RUN pip install --user -r /tmp/requirements.txt
RUN ~/.local/bin/rfbrowser init

You will receive the error and the image will not be successfully built:

In the requirements.txt change the version of robotframework-browser to 19.0.1 and save:

robotframework-browser == 19.0.1

Build again the docker image. It should be ok now:

Expected behavior
The rfbrowser init work and should not cause the docker build process failure when using the newest robotframework-browser version (otherwise we need to stick to an exact version, 19.0.1 in this case).

+1

same error on my side for the exact same reasons
I upated the base image to mcr.microsoft.com/playwright:v1.49.0-jammy
And it seems to have solved the problem

@spicard999 your solution works, thx 👍 I wonder if it is then an issue regarding the base image from MS or the issue is within the 19.1.0 release of the lib. Anyway, changing to mcr.microsoft.com/playwright:v1.49.0-jammy works as expected.

Not sure if this relates directly to this topic but since version 19.1.0 poetry is no longer able to install the robotframework-browser package too.
I'm using the following configuration in my pyproject.toml.
[tool.poetry]
name = "test"
package-mode = false

[tool.poetry.dependencies]
python = "^3.10"
robotframework-browser = "19.1.0"

Which results in a Index Error - list index out of range error message from poetry during the version resolving.
Updating dependencies
Resolving dependencies... (1.8s)

  IndexError

  list index out of range

  at ~\AppData\Local\Programs\Python\Python312\Lib\site-packages\poetry\repositories\http_repository.py:328 in _get_info_from_links
      324│                 return self._get_info_from_metadata(
      325│                     first_wheel
      326│                 ) or self._get_info_from_wheel(first_wheel)
      327│
    → 328│         return self._get_info_from_metadata(sdists[0]) or self._get_info_from_sdist(
      329│             sdists[0]
      330│         )
      331│
      332│     def _links_to_data(self, links: list[Link], data: PackageInfo) -> dict[str, Any]:

When I pin the version of robotframework-browser to 19.0.1 everything works fine again.

Yes, some code from rfbrowser logging side was removed to make this bug resurface. We will try to get this fixed in the next hotfix release.

Fixed in #3951


ROX-19277: Fix Jira Cloud support in the Jira notifier

The response to the "createmeta" Jira endpoint is slightly different between Jira Cloud and Jira Server (the key to the list of items is different, values vs issueTypes).  This change takes that into account.
The fake jira server now runs its tests twice: once for Jira Server and another for Jira Cloud.
NOTE: When this PR was opened, the code in the fake Jira server that would respond as Jira Cloud is commented out, so I expect a few tests to fail.

After further testing, there were a number of other issues to fix.

The response to the "createmeta" Jira endpoint is slightly different between Jira Cloud and Jira Server.  This change takes that into account.
The fake jira server now runs its tests twice: once for Jira Server and another for Jira Cloud.
Fix: priority was never being set because issue type fields were not being pulled correctly
Fix: Make default priority mappings match default Jira priorities
Feat: Add check to ensure client has permission to create issues in specified project
Feat: Add check to ensure all priority mappings exist in Jira
Feat: Add check to ensure priority is a field on the issue type unless disabled

Quick design doc:
https://docs.google.com/document/d/1yy4ASYGYMRX6t7lK9Y3GpoI8x7o56_grrstv2lwV8ZM/edit#heading=h.bfo71o5p936r
Testing:

[x] ROX jira cloud - successful integration creation
[x] ROX jira server - successful integration creation
[x] RHINSIGHTS jira server - validates create access check
[x] ROX jira cloud with > 50 fields - validates pagination
[x] ROX jira cloud with no priority field - validates priority field check
[x] ROX jira server with invalid priority mapping
[x] ROX jira cloud with invalid priority mapping
[x] ROX jira cloud - configure secured cluster to generate violations
[x] ROX jira server - priority disabled
[x] ROX jira cloud - priority disabled
[x] validate "annotation key for project" works as expected

Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
I created a Jira Cloud instance at klape.atlassian.net and tried out the Jira integration against that instance.  I also tried it out against issues.redhat.com to test Jira Server (essentially to check for regressions).
It would be great to test integrations in a more automated fashion, but that is a larger discussion around maintaining accounts and credentials for these other services for use in CI.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Kyle, thank you for frontend changes. I will let backend reviewers approve.

/retest


How do I get the hacks to work?

I'm new to GitHub, so can someone tell me how to get the hacks to work?

You press F12 and head over to the console in the top menu and copy and paste the code. If it doesn't work (which this is fake and it doesn't so look for a another one), try javascript: (paste code here) and then you should be good to go

idk


Update National Parks list

Get updated list from ProtectedPlanet.net

https://github.com/openshift-roadshow/nationalparks/issues/26

Updated on Java backend, will propagate that on other programming languages backends


No parentheses should enclose a reference if it is at the beginning of a sentence

From #781

There should not be a parenthesis when a sentence begins a reference.

AC

[ ] No parentheses should enclose a reference if it is at the beginning of a sentence

@kamicut, if this is difficult, could you scope out the LoE earlier in the sprint?

@wrynearson We identified three types of potential cases of adding reference(s).

At the beginning of a sentence, which has a different format. Note there may or may not be a comma following the reference. Examples:
According to the American Psychological Association (2000), .....
Doe (2009) states that .....

Somewhere in the middle of the sentence. Note there is no punctuation following the reference and the reference gets parenthesis. Multiple citations would get one set of parenthesis. Example:
However, a parallel study (Berndt, 1981; Doe, 2002) resulted in ......

At the end of a sentence, which is followed by a period. Example:
This is a test sentence (Berndt, 1981; Doe, 2002; Johnson et al., 2001).

There are multiple ways we can tackle this ticket as well as #784:
In order of difficulty (in my opinion, but I differ to @frozenhelium on frontend difficulty)

Remove parentheses by default, and have them be written in manually in the editor around the citation by the user
Create a fixed ruleset for citations so that formatting & merging of the citations could follow the ruleset (example, no parentheses when starting a line, two citations next to each other should merge, etc.)
Create a "citation display editor" component upon inserting a reference, that will allow the editor to display how a citation will look like before it's inserted into the text box.

These have varying degrees of complexity and flexibility. (1) and (3) require some manual work on the side of the user, but are a little bit more flexible. (2) would be less flexible.

Thanks @kamicut for the summary! I think historically (before any of the DS members current working on the project joined), the idea was to value flexibility and to give the responsibility of sorting the specific details and edge cases to the user. It's a very deep rabbit hole to try to account for all of the different use cases required by users, and citations/references seem to be a pain point for users.

@bwbaker1 we're going to meet next week and deep-dive into the AGU citation rules to help us decide how to move forward with this, because this is more than just a question about parentheses

@wrynearson I discussed the issues related to in-text citations with Aaron.

We agree that the best solution is to do nothing for this use case. Hopefully, this will encourage user(s) to rephrase their sentences and place the citations at the end. Citations at the beginning of a sentence are less common anyways.

We can reassess this after the one-year maintenance period based on user feedback.


[Bug] unwanted *.ogv files

Describe the bug
I'm unsure if I misconfigured my action or it this is actually an error.
I get pcbnew_run_drc_screencast.ogv and similar *.ogv files in every directory of my export, but I would like to skip them.
Skipping their upload as artifact should probably be possible, but not generating them in the first place seems even better.
To Reproduce
Steps to reproduce the behavior:

used slightly modified docs.schema.kibot.yaml file
https://github.com/ModischFabrications/turn_indicator_pcb/

Expected behavior
I expected to get only the files that I ordered. check*.txt are fine, even if not actually requested, but *.ogv seem useless to me.
Additional context
Add any other context about the problem here.

Hi @ModischFabrications
*.ogv files are only created in verbose mode. So setting ´verbose:0´ should solve this.
might be a good idea to set this default in my readme... I will check

Oh alright, I thought that was just for logging purposes, didn't realize the pictures were a result of that. Are there any other consequences of this option? Thanks for looking into it!

I didn't check now but I guess there are a few logfiles not created / created with different depth of information according to verbosity level.

Removing verbosity from files worked as well, which is even easier to explain. Issue can be closed from my side.
Nice side-effect: My generated /docs zip is now 0.7Mb instead of 2.


DNS entries not picking the DNS server

When a test net node starts first time (no address.dat file) the node doesnt connect to the dns seed node
This might be related to the AddressBehaviour/AddressManager in NStratis

 [Connection] DNS Seed Discovery Bug

unable to reproduce, seems to me like the node does resolve the DNS seed address and attempts to connect to it and that operation succeeds, so not sure what the problem is about

Great thanks.


Forbid Select-options that contain the disabled class

A lot Select elements contain an item that has the disabled and selected attributes set by default. Most of the time this item behaves like a placeholder for the select form. The validation should return false if an item is selected that contains the disabled attribute because it can't be selected anyway. See:
<select data-error="Please chose at least on option">
    <option value="abc" disabled selected>Placeholder (this is the default value and can not be selected)</option>
    <option value="xyz">First option</option>
</select>

You probably shouldn't be giving the placeholder option a value attribute.


Missing Repository URL in manifest.json

Issue Description:
I noticed that the manifest.json file is missing the URL for the repository.
Steps to Reproduce:

Open the manifest.json file.
Notice that the URL is missing.

Thank you
Please let me know if you require any further information or clarification.

Hey there @brunocalado, and thank you for the voluntary QA help!
I'm not sure what you mean though... I am not aware of a manifest.json file, but there is already a URL on the manifest property in the module.json file.


Increase the default mysql init timeout to 60 seconds for slower comp…

…uters. Also paramterize it so that users can pass a custom value via 'mvn clean install -Dmysql.init.timeout=80000' for example

build should be fixed by https://github.com/debezium/debezium/pull/192

I just merged #192 and restarted this PR's Travis build.

Actually, #191 would need to be debased for it to pass. I'm just going to merge it since it got past the MySQL connector portion of the build.


⚒[FEATURE] Helius Integration

Describe the feature you'd like
Helius Integration
Docs: https://docs.helius.xyz/introduction/quick-start
✅Tasks

[ ] Add Helius action node.

🎯Acceptance Criteria

[ ] Helius action node should have some most of the APIs like NFT, Name, Balance implemented.

👨💻How to contribute
Follow this guide for step by step on how to fork, commit, and submit PR.
🧱 How to create node

Action node guide
Trigger node guide
Webhook node guide

More info
Like to work on this issue? Let us know, and we will assign it to you 🚀
If you need any help or just want to hangout, reach out to us on our Discord server👾

This seems interesting! Can you assign this to me?

definitely! reach out to me if you have any question, happy to help!

#118 closing as pr merged


Added promotion section

Explained why users should tell people about Zeus. This will help us get more users, for A/B tests and things like that 😀

This change is

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

README.md, line 25 at r1 (raw file):
Previously, typot[bot] wrote…
"##" at 25 is typo?

No it's not

README.md, line 27 at r1 (raw file):
Previously, typot[bot] wrote…
"Micathon" at 27 is typo?

[ ] Marathon
[ ] Catholic
[ ] Cathodic
[ ] McCarthy
[ ] Macarthur

Not

README.md, line 29 at r1 (raw file):
Previously, typot[bot] wrote…
"###" at 29 is typo?

Not

Comments from Reviewable


Added Multi-GPU support

Same as https://github.com/cmusatyalab/openface/pull/154, where I have a mess with submodules. I hope it will work now.
The last think we need to talk is:
'nn.SpatialConvolution' vs 'nn.SpatialConvolutionMM'
Use both for initialization or stay with 'nn.SpatialConvolution', as they are the same algorithm but different name.

@bamos
What I should do to go through this check?
"The command "luacheck . --no-global --no-self --exclude-files '*/torch-TripletEmbedding'" exited with 1."

Also on 'nn.SpatialConvolution' vs 'nn.SpatialConvolutionMM', I'd be fine changing the model definitions to SpatialConvolution, but I think the initialization should be used on both just in case a larger module opaquely uses the MM version. This currently isn't the case, but this could be easy to forget in the future.

Maybe I should remove this initialization now. There are too much stuff in this single Pull Request.
I think that we should use nninit for initialization of networks. Here it should be easier to change method of initializating.
And I think it should be global, not per model. Per model initialization will produce a lot of redundant code and I do not think that people will change parameters in initialization like in ResNet. Most of them would like to have more options for initializing the weight of networks than the option to project own initialization.
What do you think about that?

Yeah, nninit looks great. I'm also ok with having the init global rather than in each model.

I removed init functions. We will add "nninit" in a future.
Do you have multiple GPU to test this code?

If everything is ok, I can squash it to single commit.

Hi Bartosz, sorry for the delays, testing on my multi-GPU machine now.

Thanks again for this PR, multi-GPU support is great! For some resnet experiments, I'm getting the following speedups, indicating that using 2 GPUs at a time is the best and installing nccl for the DataParallelTable doesn't really matter. I'll merge this in once you squash the commits.
-Brandon.
1 GPU
Epoch: [1][1/1500]      Time 1.075      tripErr 2.03e-01
Epoch: [1][2/1500]      Time 0.941      tripErr 1.98e-01
Epoch: [1][3/1500]      Time 0.879      tripErr 1.97e-01
Epoch: [1][4/1500]      Time 0.878      tripErr 1.96e-01
Epoch: [1][5/1500]      Time 0.877      tripErr 1.98e-01
Epoch: [1][6/1500]      Time 0.932      tripErr 2.01e-01
Epoch: [1][7/1500]      Time 0.884      tripErr 2.28e-01
Epoch: [1][8/1500]      Time 0.877      tripErr 1.90e-01
Epoch: [1][9/1500]      Time 0.882      tripErr 1.86e-01
Epoch: [1][10/1500]     Time 0.880      tripErr 1.89e-01

2 GPUs, with nccl
Epoch: [1][1/1500]      Time 3.469      tripErr 2.05e-01
Epoch: [1][2/1500]      Time 0.716      tripErr 1.99e-01
Epoch: [1][3/1500]      Time 0.642      tripErr 1.99e-01
Epoch: [1][4/1500]      Time 0.619      tripErr 1.98e-01
Epoch: [1][5/1500]      Time 0.617      tripErr 1.98e-01
Epoch: [1][6/1500]      Time 0.668      tripErr 1.97e-01
Epoch: [1][7/1500]      Time 0.629      tripErr 1.99e-01
Epoch: [1][8/1500]      Time 0.620      tripErr 1.93e-01
Epoch: [1][9/1500]      Time 0.618      tripErr 1.89e-01
Epoch: [1][10/1500]     Time 0.615      tripErr 2.41e-01

4 GPUs, no nccl
Epoch: [1][1/1500]      Time 4.979      tripErr 2.01e-01
Epoch: [1][2/1500]      Time 0.665      tripErr 2.01e-01
Epoch: [1][3/1500]      Time 0.611      tripErr 2.00e-01
Epoch: [1][4/1500]      Time 0.554      tripErr 2.00e-01
Epoch: [1][5/1500]      Time 0.552      tripErr 1.98e-01
Epoch: [1][6/1500]      Time 0.603      tripErr 1.98e-01
Epoch: [1][7/1500]      Time 0.593      tripErr 2.01e-01
Epoch: [1][8/1500]      Time 0.559      tripErr 1.95e-01
Epoch: [1][9/1500]      Time 0.553      tripErr 1.96e-01
Epoch: [1][10/1500]     Time 0.554      tripErr 1.93e-01

4 GPUs, with nccl
  Epoch: [1][1/1500]      Time 5.310      tripErr 2.05e-01
  Epoch: [1][2/1500]      Time 0.724      tripErr 1.99e-01
  Epoch: [1][3/1500]      Time 0.629      tripErr 2.00e-01
  Epoch: [1][4/1500]      Time 0.540      tripErr 2.00e-01
  Epoch: [1][5/1500]      Time 0.538      tripErr 1.99e-01
  Epoch: [1][6/1500]      Time 0.601      tripErr 1.99e-01
  Epoch: [1][7/1500]      Time 0.562      tripErr 2.00e-01
  Epoch: [1][8/1500]      Time 0.548      tripErr 1.97e-01
  Epoch: [1][9/1500]      Time 0.542      tripErr 1.97e-01
  Epoch: [1][10/1500]     Time 0.541      tripErr 1.97e-01

About speedup: I think that more GPU process the data faster (exactly forward and backward pass), but other parts of code (like triplet selection or criterion) take too much time to see the difference.
About NCCL: it is ~4% of speedup, so there is not as much change.
Second thing is than MultiGPU is rather useful for bigger batch-size. But theoretically, in resnet repo, they achive 3.85x speedup using 4 GPU.
FYI, I am testing the code which is ~2x faster on single GPU than current one. I have just made a couple of measurement and optimize the bottleneck.
One of most crucial part is Forward-Pass in TripletEmbeding criterion. I have speedup it by more than 10x
[PR send] (https://github.com/Atcold/torch-TripletEmbedding/pull/3). When it will be merged, I will create PR in OpenFace to use the faster version.
After that I have a optimization of choosing triplets and updating gradient (but I am not sure you will be happy about that:)

Sound great! Looking forward to more improvements. :-)


Linux Apps won't sign in, won't play content ant won't submit feedback

Tried the Flatpak on Clear linux and the .deb package on Ubuntu 19.10 both had the same behavior. When trying to Sign In or Add Email  after clicking on the 'Continue' button nothing happens, it never signs in nor does it display any change. When clicking on the content on the front page or using the search bar the app screen just goes blank and the only way to recover the front page is with ctrl+r. And finally using the feedback form in the app might not work, when clicking on 'Submit' the button change state to 'Submitting' but no feedback is given to whether the submit process was successful or not.

Sorry to hear, this should be fixed in the next release. We mentioned this on our releases page and on a faq, but it's not super clear.
Try this build, it should work: https://build.lbry.io/app/build-10125_commit-5d7a123/electron/


transboundary stocks

How should I deal with stocks that them -- I only have the U.S. removals in my model.

Hmmm...we can discuss next week. We can create an allocation model that codes in US/CAN allocations. There is information on the % across years. These are also based on distribution of species, but I don't think the percentage has changed that much over time.

This presentation has information relevant to this issue: https://s3.us-east-1.amazonaws.com/nefmc.org/1a_TMGC_Presentation.pdf

https://www.nefmc.org/calendar/sep-12-13-transboundary-management-guidance-committee-tmgc-meeting

323c90a236215ecdbcdde2a017e18798b0d7b2a1
I've pulled the Canada Quotas and catches for the 3 transboundary stocks. I added the US and Canadian quota to get the total quota. And I've included canadian catch as another "non-sector, non-rec" fleet.   The data changes will carry over to the next model run.
I should also update the catch and ACL data past 2017.


add several optional exercises to Test design episode

The idea is to have one main unit testing exercise with multiple functions/classes/code snippets that tests should be written for. This main exercise could also be split into multiple main exercises.
But it would be good to have additional exercises on other topics and we can collect ideas (and external resources) in this issue.
Some ideas:

testing randomness
integration test
testing IO (should probably be one of the main exercises)

we should try to have these optional exercises in as many different languages as possible but each type of exercise probably doesn't need to be replicated in each language

randomness is there
I/O is there but needs to be clearer
I will add end-to-end

Followed-up in #150.


Use xkbcommon's function to convert a keysym to a unicode point

Removed key_mapping.rs => less code.

Im unsure if the code_point range check is neccessary or not. Ill take a look if it is.

Thanks!

@emoon Can you apply the change in my x11 branch too? (forgot to add the deps for x11)

@emoon this change could really be important.

Can you open a new PR for the fix?


improve to calculate norm

I improved to calculate norm.
I measured the clock to calculate norm.
Please observe the following.

FunctionAverage ClocksFaster Rate (compared with existing code)
existing code width 895.0-
new code width 889.06.7%
existing code width 16114.8-
new code width 1698.816.2%
existing code width 32160.6-
new code width 32133.620.2%
existing code width 64273.6-
new code width 64244.212.0%

Measurement Conditions
OS : Ubuntu 16.04
Compiler : g++ (Ubuntu 5.3.1-13ubuntu3) 5.3.1 20160330
CPU : Intel(R) Core(TM)2 Duo CPU E8500 @ 3.16GHz
Compiler Option : -msse2 -O3
Measurement Function: rdtsc()

@vpisarev
@sushruta
@Dikay900
I'm sorry the place busy.
What kind of test is "OCL_MeanStdDevFixture_MeanStdDevWithMask.MeanStdDevWithMask/13 [1920x1080, 32FC1] "?
Is this test to check the calculation result?
Is this test to check the performance?
If you know about that, please let me know.

This is an opencl performance test checking the function cv::meanStdDev but it seems it has nothing to do with your commit.

@Dikay900
Thanks for your comment.

@Dikay900
Thanks for your comment.

this PR will be reopened because of CI issues


Can't build the container, cannot import name 'HTMLString' from 'wtforms.widgets'

Can't build a container any more; however, I was able to build yesterday. Now getting this error
ImportError: cannot import name 'HTMLString' from 'wtforms.widgets'

Same error here. I have been trying to make this work all day long.

Seems an issue related to a change in wtforms.

Got the same issue. They are bringing back HTMLString and giving a warning that this module will be deprecated.
https://github.com/wtforms/wtforms/pull/583

According to the official Airflow document you can specify a constraint when you are installing airflow. Therefore, you can just do something like this in the Dockerfile:
&& pip install apache-airflow[crypto,celery,postgres,hive,jdbc,mysql,ssh${AIRFLOW_DEPS:+,}${AIRFLOW_DEPS}]==${AIRFLOW_VERSION} \     --constraint https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt \
Noted, my airflow version is 1.10.10

Managed to build today, I guess they revert the changes for wtforms


Fix math.pow with int64 argument for CUDA

This pull request addresses an issue on the CUDA target where a [u]int64 argument to math.pow can produce incorrect results. The issue is detailed in this bug report.

gpuci run tests

Noting also this will cause the CUDA target to be affected by #7012, which might be a regression in itself.

gpuci run tests

gpuci run tests

@gmarkall I incorporated your suggestions on not copying the integer pow implementation and using assert_allclose. Waiting on feedback on the float64 vs int64 question.

Noting also we should consider whether the issue described in #8169 could have an effect here,

Closing as per discussion in the dev meeting on 2023-07-04: https://github.com/numba/numba/wiki/Minutes_2023_07_04
Summary: this still requires more work on the tests and doesn't address other issues that may be introduced by the fix, so it'd be better to close this rather than attempt to pick it up from here.


Run prettier

✨ Codu Pull Request 💻

Pull Request details:

Run prettier for the first time.

Any Breaking changes:

None

Thanks @xiaoniuniu89 everything worked a charm!!! 🥳


Tweak Gitlab Org Data docs

Hey, I just made a Pull Request!
Just tidying up the docs a little, to help make this feature more discoverable
:heavy_check_mark: Checklist

[x] ~A changeset describing the change and affected packages. (more info)~ docs only
[x] Added or updated documentation
[x] ~Tests for new functionality and regression tests for bug fixes~ docs only
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@jamieklassen Do you happen to know what is meant with Admin PAT? Does that mean the token needs the admin_mode-scope or need the token be created by a user with Admin permissions?


Add text to CONTRIBUTING

This PR adds some text to the CONTRIBUTING.md file.

PR merged manually.


Revert "[SPARK-30642][SPARK-30659][SPARK-30660][SPARK-30662]"

What changes were proposed in this pull request?
Revert
#27360
#27396
#27374
#27389
Why are the changes needed?
BLAS need more performace tests, specially on sparse datasets.
Perfermance test of LogisticRegression (https://github.com/apache/spark/pull/27374) on sparse dataset shows that blockify vectors to matrices and use BLAS will cause performance regression.
LinearSVC and LinearRegression were also updated in the same way as LogisticRegression, so we need to revert them to make sure no regression.
Does this PR introduce any user-facing change?
remove newly added param blockSize
How was this patch tested?
reverted testsuites

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22779/
Test PASSed.

Test build #118014 has started for PR 27487 at commit 3407dc1.

Wow. It's a massive revert. If you have a discussion on the other PRs, could you add some pointers into the description? What is the performance regression?

BLAS need more performace tests, specially on sparse datasets

@dongjoon-hyun There is some test and discussion in https://github.com/apache/spark/pull/27374, I also update the description.

Thank you, @zhengruifeng .

Also, cc @huaxingao since she is also the author of the last PR.

Test build #118014 has finished for PR 27487 at commit 3407dc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118014/
Test PASSed.

Test build #118016 has started for PR 27487 at commit 255ca22.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22781/
Test PASSed.

Test build #118016 has finished for PR 27487 at commit 255ca22.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class _ALSModelParams(HasPredictionCol):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118016/
Test PASSed.

Test build #118020 has started for PR 27487 at commit 0dafab5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22785/
Test PASSed.

Test build #118020 has finished for PR 27487 at commit 0dafab5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118020/
Test FAILed.

retest this please

Test build #118022 has started for PR 27487 at commit 0dafab5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22787/
Test PASSed.

Test build #118022 has finished for PR 27487 at commit 0dafab5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118022/
Test PASSed.

Test build #118029 has started for PR 27487 at commit 7b09306.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22794/
Test PASSed.

Test build #118029 has finished for PR 27487 at commit 7b09306.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118029/
Test PASSed.

cc @mengxr @WeichenXu123 @srowen

Merged to master

Thank you. I should have realized that sparse vectors could be an issue in the first place. That's my bad.

@srowen Never mind, I should have maken more perfermance tests. Maybe we should do such refactors only when we have enough time for testing. When working on these PRs, it maybe too close to the code freeze.

Is this to revert the PRs on branch-3.0 too? I cannot find it in branch-3.0 commits.

@viirya Yes, this is to revert on branch-3.0 too. I am go to revert it on 3.0. Thanks for pointing it out!


Setup-Lab script ignores system pending reboot

This creates a VM switch creation error because hyper-V isn't fully installed.  Will adjust code to remove the -IgnorePendingReboot parameter
Error:

Issue is fixed and will be released in v2.1.0


Add a landing page

Codecov Report

Merging #59 (0db0d00) into dev (0b9aec7) will decrease coverage by 0.99%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##               dev      #59      +/-   ##
===========================================
- Coverage   100.00%   99.00%   -1.00%
===========================================
  Files            8        8
  Lines          100      101       +1
===========================================
  Hits           100      100
- Misses           0        1       +1

Impacted Files
Coverage Δ

apps/publishing/lib/publishing/manage.ex
98.24% <0.00%> (-1.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9aec7...0db0d00. Read the comment docs.


Fix travis badge url

Hi. It moved to organization repository.
Thank you.

Thanks pine!

Thanks!


Can't log in "module" object is not callable

How do I solve this problem?
Apparently, every time I try to log in it won't work for any reason whatsoever.
I could actually turn this around by just launching the code normally and then the API will ask me to log in.
When I logged in to my virtual machine it worked just fine (no type error), the only difference is that in my PC I'm using anaconda prompt as terminal.
But I need to fix this in my cpu because my sweeps will not work if I don't (I get the same error when I run a sweep).
wandb login (my id hidden)
Traceback (most recent call last):
  File "C:\Users\lucas\anaconda3\envs\tcc\Scripts\wandb-script.py", line 9, in <module>
    sys.exit(cli())
TypeError: 'module' object is not callable

After uninstalling conda wandb and installing only pip install --upgrade wandb I get:
Traceback (most recent call last):
  File "c:\users\lucas\anaconda3\envs\tcc\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\lucas\anaconda3\envs\tcc\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\lucas\anaconda3\envs\tcc\Scripts\wandb.exe\__main__.py", line 4, in <module>
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\__init__.py", line 38, in <module>
    from wandb import sdk as wandb_sdk
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\sdk\__init__.py", line 12, in <module>
    from .wandb_init import init  # noqa: F401
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\sdk\wandb_init.py", line 30, in <module>
    from .backend.backend import Backend
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\sdk\backend\backend.py", line 15, in <module>
    from ..interface import interface
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\sdk\interface\interface.py", line 18, in <module>
    from wandb.proto import wandb_internal_pb2  # type: ignore
  File "c:\users\lucas\anaconda3\envs\tcc\lib\site-packages\wandb\proto\wandb_internal_pb2.py", line 5, in <module>
    from google.protobuf import descriptor as _descriptor
ModuleNotFoundError: No module named 'google.protobuf'

After installing protobuf from conda it worked, although I can conclude that conda install won't work for wandb?

@lucastononrodrigues we don't publish our library in conda currently.  We're working with conda to get the current wandb package that's in conda removed, it's not something we authored.  Is everything working for you now?

@lucastononrodrigues we don't publish our library in conda currently.  We're working with conda to get the current wandb package that's in conda removed, it's not something we authored.  Is everything working for you now?

@lucastononrodrigues we don't publish our library in conda currently. We're working with conda to get the current wandb package that's in conda removed, it's not something we authored. Is everything working for you now?

Yes. Thank you.

@lucastononrodrigues we don't publish our library in conda currently. We're working with conda to get the current wandb package that's in conda removed, it's not something we authored. Is everything working for you now?

Yes. Thank you.


Ability to set Language using native spellings.

Is your feature request related to a problem? Please describe.
If a potential user of the QnA bot wants to select their own language using the handlebar syntax this can only be done if the spelling of the language is typed in English (for example French, Spanish...)
If the user tries to type their native spelling of that language (for example Français, Español) then this fails with the empty response being returned.
Describe the feature you'd like
A user can type in a supported language using the English and native spelling of that language.
Additional context
Also to allow a user to type in a phrase to also set the language (for example, 'me gustaria hablar en español')

For additional context the code looks like its looking up the language in the supportedLanguages.js file and if there isn't a match its failing to set the language.
You can include the native spellings of those languages (I've tested this) and it does work but there are some exceptions. It has issues matching the 'ç' in Français.
Also, it doesn't detect a variation when setting the language such as 'me gustaria hablar en español' or I want to speak in Spanish

Hey Feelec1 - we're working on a feature to enable multi-language support within QnABot that may be able to address your request. More to follow.

Hi @feelec1 , we just launched v5.5.0 today for QnABot. This supports a new Parameter in the CloudFormation Stack that will support Opensearch Language analyzer for the index. With this new feature, it will allow a more accurate Native Language use.

Closing this issue now.


Mv tests

Fixes # (issue)
Goals :soccer:

Implementation Details :construction:

Testing Details :mag:

rerun tests

rerun tests


Simplified file picker says \c:\ instead of c:\

Maybe it should use caps as well for the drive?

Fixed by https://github.com/Microsoft/vscode/commit/07e498f887c32cbb621233c3d40aa69ed30aeeae


Bgp extension

I have a strong interest in Ipvlan-docker-plugin.
Developed Routing support extension in l3 mode inspired by https://github.com/nerdalert/bgp-ipvlan-docker ( Thank you for using we osrg product ).
To provide routing manager interface

StartMonitoring()
AdvertizeNewRoute(localPrefix *net.IPNet)
WithdrawRoute(localPrefix *net.IPNet)

add l3routing mode and select route manager with --routemng option(go run main.go --host-interface=eth0 -d --mode=l3routing --ipvlan-subnet=<IP_ADDRESS>/24 --routemng=gobgp)
I use your code for reference and develop Gobgp routing manager.
main difference is using grpc for communicate with gobgp ( we are increasing grpc api functions ).
Signed-off-by: Yuji Oshima<EMAIL_ADDRESS>

Hey YujiOshima you are awesome! I was totally going to ping you guys this week! Im a fan of osrg and what you guys have been doing. We are also in the process of getting IPVlan (L2|L3) and Macvlan shaped up to push into docker/libnetwork/drivers/ natively that I will be sending you updates on this week if cool with you.
Also wanted to collaborate on getting the decoupled datastore integrated with your guys work.  I wasn't brave enough to use gRPC as you probably saw and was screen scraping stdout like a lamer :)
Integration opportunities that would be cool:

The APIs for IPAM are changing in the next few days in experimental. With those changes we can do some super cool stuff with addressing and simple stuff like /32 host routing.
EVPN integration with the docker/libnetwork. I think this will be pretty much out of the box with just a bit of glue like you have done here. Currently its the included options are etcd, consol, etc. Be neat to add GoBGP.
@araveendrann had a per pod summarization use case we have been talking about also. Bumping him.

Thanks and look forward to collaborating!


Create and update documentation for Axel-GME

I have been told I need better documentation for this repo. I have stopped development on this because I am occupied with other projects.
Create a CONTRIBUTING.md edited for this program from https://github.com/seanshin2647/BUBC-Universal-Bookmark-Converter. After that, write a description of the program and how the major parts of it work together in a paragraph or so.

I can do it.

Got it, then please do so.

Closed with PR #14.


Add Lise to Contributors list

This is an amazing tutorial! :smile:
Thank you so much for creating and working for this project! I am currently organizing a Hacktoberfest meetup, and I plan to forward this fantastic tutorial to first-time open source contributers! (I hope you do not mind.)
Thank you once again! 😃

@koprty, I'm quite elated about your PR. I'll be very happy if you introduce this in your hacktoberfest event. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

The tutorial was definitely super thorough! (I've made PRs before, but I think this would be perfect for any beginner to open source.)

@koprty, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com