Summons | EPost SBI E Pay Integration

Module: Summons
Details:

Epost channel of summons shall have 2 payments - Court Fee and Channel Fee
Court Fee shall be redirected to the E Treasury Payment GW (Already Implemented)
Channel Fee shall be redirected to SBi e Pay GW
The pending task created for payment should be marked complete only after both payments are done.
This ticket is applicable only to EPost (R PAD, SMS, Email, ICops shall have only Court Fee Payment)

API Details:
Merchant Integration Guide
Test URL
Transaction Sample Code

Integrations in progress. The testing can be carried on only after deploying to dev env. That is paused for a while. Will resume after UAT deployment.

The dev environment being unstable is a blocker. Testing in process

@Ramu-kandimalla
Pushed the need changes from front end to dev env . The sbi portal giving access denied.
Informed @Ajith-beehyv  for the same . can start retesting after some further info on the same.

Unable to access sbi url . No changes From frontend needed yet. @Ajith-beehyv  will update after making some backend changes. . Till then blocked further.
cc :- @Ramu-kandimalla

verified in QA[sol] env., Not working as expected.
https://jam.dev/c/cd9a2101-a903-4703-8601-48af5064c1ec

Please confirm if it is an internal issue or SBI related issue @Ramu-kandimalla @kashish384

*EPost SBI E Pay, its working fine in QA[sol] env.
https://jam.dev/c/9dbaa86c-249f-4704-8d05-5b5948a76366

its working fine in QA[sol] env.
https://jam.dev/c/c02235a8-46e4-4ab1-a2ac-ae3d2bda325d

Its working fine in UAT env.
https://jam.dev/c/aaec1850-b3a3-426c-9efd-37dc1fd9f9a5


Enhance the list widget

Enhance the behaviour of selected value change on the scheduler

Thanks Abir. I was able to test it.


Feature Request: Config File and Watch

Feature Request: Config File and Watch for generate command
I prefer to use the typia generate feature over patching typescript especially now the ts-patch does not support typescript v5. Could typia support a config file and watch functionality for generate?

I am looking to have one place to configure multiple input and output directories for a mono repo setup and to have the output regenerated when files in the input directories change.

Example Use:
NestJS Project:
In a nest mono repo project, multiple libraries may exist, and a project would want separate input and output directories for each library and the ability to regenerate the generated files when files in the input directories change.
nest project/
├─ apps/
│  ├─ app-1/
│  ├─ app-2/
├─ libs/
│  ├─ lib-1/
│  │  ├─ src/
│  │  │  ├─ types/
│  │  │  │  ├─ generated-typia/
│  │  │  │  │  ├─ <generated files>
│  │  │  │  ├─ src-typia/
│  │  │  │  │  ├─ type-2.ts
│  │  │  │  ├─ index.ts
│  ├─ lib-2/
│  │  ├─ src/
│  │  │  ├─ dtos/
│  │  │  │  ├─ generated-typia/
│  │  │  │  │  ├─ <generated files>
│  │  │  │  ├─ src-typia/
│  │  │  │  │  ├─ type-1.ts
│  │  │  │  ├─ index.ts

Not possible to providing watch mode, but configuration file is possible.
Can you design an interface type of the configuration file what you want?

By the way, ts-patch seems to support to v5 in near time:
https://github.com/nonara/ts-patch/issues/93#issuecomment-1488595872

Close due to ts-patch started supporting TS 5


bug: manifest shasum error

Describe the bug
An error happened: Failed to fetch Snap "local:http://localhost:8080": Invalid Snap manifest: manifest shasum does not match computed shasum.
To Reproduce
No response
Expected behavior
No response

This will be fixed with updating the snaps-cli to 0.30.0.
After updating our snap doesn't work because of another bug in a dependency we use. We are working on it and will release a fix as soon as possible.


[BUG] ios13 and 2.3.3+

Describe the bug
Scrolling always resets to the position where the user tapped/started the scroll
To Reproduce
Install the example project and run it. I replaced my custom page scroll with example one, just to be sure it is a swiftuipager issue.
Expected behavior
Scroll should work as in ios14, and ios15 devices and in 2.3.3 and 2.4.0 versions. It should not be stuck on one page.
Screenshots / Videos
https://user-images.githubusercontent.com/74199206/170687011-b3385dc5-72f1-4f07-8e6b-f67a6139cbdd.mp4
Environment:

IOS: 13.1, 13.2
iphone 11 pro max, simulators
SwiftUIPager version: 2.3.3 and 2.4.0

@kristohear can you share this code or some pseudo-code with me? Where is your @ObservedObject var page living? It looks as if your whole screen is being recreated when this property updates which is not what you want. It works in iOS 14+ because of StateObject but state management is somewhat more delicate in iOS 13.
This coups be easily solved I think if you had something like this:
@ObservedObject var page: Page = .first

// inside `MyPagerContainer`
var body: some View {
  ...
  MyView(page: page)
  ...
}

And then:
var body: some View {
  VStack {
    MyPagerContainer()
    MyPagerContainer()
  }
}

This way, Pager changes the page but MyPagerContainer doesn't get recreated (and page doesn't reset) because its a different view that doesn't depend on page


ch9 project 0.2 *** Program received signal SIGSEGV (Segmentation fault) *** not working with #27

gdb output：
Starting program: /home/nvidia/DISK/CODEing/SLAM/slambook/project/projectV2/bin/run_vo
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/aarch64-linux-gnu/libthread_db.so.1".
Program received signal SIGSEGV, Segmentation fault.
0x0000007fb32267b0 in ?? () from /usr/lib/aarch64-linux-gnu/libQtGui.so.4

it seems that this error is caused by libQtGui but how can i fix it?

computer platform is TX2 with Ubuntu16.4 LTS

$ man 7 signal |grep SIGSEGV
signals, such as SIGSEGV and SIGFPE, generated as a consequence of exe‐
SIGSEGV      11       Core    Invalid memory reference

绝望，有大侠出手相救的吗

我没有在tx2平台上测试过，这可能是个平台特定的问题（关键是我没tx2啊……）


service name error

The Zipkin service name displays the URL address, which should be the application name

@limx198918 OpenTracing  Span converted to Zipkin Span and think that   Zipkin service name  display application name which isn't graceful .In MVC , URL address more suitable for service name. And if show  application name can have more advantage？we can discuss it 😀

If I have 10 projects and there are 20 services in each project, where do you show where 200 service addresses are, how can I quickly locate my service?

In the way，we can only use like this.

But we can better show in Zipkin like your suggestion. Can you contribute it 😀😀


The endpoint of the job in the complete state is not recycled

Spiderpool Version
v0.9.4
Bug Type
IPAM
Main CNI
any
What happened?
[root@controller-node-1 ~]# kubectl get po -owide | grep job
job-test-bzxhz              0/1     Completed          0          26s     <IP_ADDRESS>    controller-node-1   <none>           <none>
[root@controller-node-1 ~]# kubectl get se | grep <IP_ADDRESS>
job-test-bzxhz              eth0        rip        <IP_ADDRESS>/16                     controller-node-1
[root@controller-node-1 ~]# kubectl get sp rip -oyaml | grep <IP_ADDRESS>

What did you expect to happen?
Resources are released correctly
How to reproduce it (as minimally and precisely as possible)
apiVersion: batch/v1
kind: Job
metadata:
  name: network-annotated-job
spec:
  template:
    metadata:
      annotations:
        v1.multus-cni.io/default-network: kube-system/macvlan
        ipam.spidernet.io/ippools: '[{"interface":"eth0","ipv4":["ippool"]}]'
    spec:
      containers:
      - name: network-job
        image: daocloud.io/daocloud/dao-2048
        command: ["sh", "-c", "ip a"]
      restartPolicy: Never
  backoffLimit: 4

Additional Context
No response

fix #3778


AsyncDataTree.expand() with recursive=true not working

Fixes #230422

Thinking about this a bit more- this probably isn't the solution - seems that, in this case, it's not expanding because I haven't expanded those nodes before.


Function tests cleanup (part-2)

This has the following changes:

Making UrlHelperWebSite to a sample
Deleting ResponseCacheWebSite and converting functional tests to unit tests
Moving TryValidateModel and buddy type functional tests to integration tests.

I will send a separate PR to handle RemoteAttribute test changes.
@rynowak @dougbu

Links shown in UrlHelperSample don't work anyway. So don't check in the UrlHelperSample/Content/bootstrap.min.css file or use StaticFiles.

:up: :date:

:up: :date: @dougbu

ping

:watch:

:up: :date:

Late realization: PR is missing removal of at least CustomUrlHelper, CustomUrlHelperFactory and Startupfrom the oldUrlHelperWebSite. The new UrlHelperSample.Webproject also needs areadme.md` file.

:watch: just to see diffs to the remaining files that actually have been renamed, not added.

:shipit: once the commits here can be squashed together w/ those in #3699.
(Manually compared the missing files and found no unexpected changes.)

57b88baad0372d3fe3f4bc8b9534d2643ddbf2dd


style: 💄 widget filter icons

https://metakeen.atlassian.net/browse/FEE-661

Codecov Report

Merging #189 (71bc3a5) into develop (08616c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #189   +/-   ##
========================================
  Coverage    86.55%   86.55%
========================================
  Files          408      408
  Lines         5416     5416
  Branches       525      525
========================================
  Hits          4688     4688
  Misses         664      664
  Partials        64       64

Impacted Files
Coverage Δ

...getFilter/components/WidgetFilter/WidgetFilter.tsx
68.96% <ø> (ø)

...c/components/DatePickerWidget/DatePickerWidget.tsx
63.21% <ø> (ø)

src/components/FilterWidget/FilterWidget.tsx
81.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08616c5...71bc3a5. Read the comment docs.


ajax filter still needed?

Hey @williamsbdev do we still need this ? I thought we had moved away from this recently and if so ... why not kill the dead code ?
https://github.com/toranb/ember-cli-thymeleaf-csrf/blob/master/app/initializers/ajax-prefilter.js#L4

@toranb I believe this is still needed. Otherwise, how do we ensure that we are passing back the csrf token on every request?

Fair point - just wanted to verify as I thought this was removed recently :)


Let's switch to 000: http://play.google.com/store/apps/details?id=com.ww000_15714192

**Describe the bug** A clear and concise description of what the bug is.
To Reproduce Information to reproduce the behavior, including:

Git commit id
IEEE 802.15.4 hardware platform
Build steps
Network topology

Expected behavior A clear and concise description of what you expected to happen.
Console/log output If applicable, add console/log output to help explain your problem.
Additional context Add any other context about the problem here.

I my Shamim


❓ [Question] function torch._ops.aten.aten::_to_copy not currently supported with dynamic input shape

❓ Question
I'm trying to compile a model with dynamic input shape but told that the function torch._ops.aten.aten::_to_copy is not currently supported:
  File "/home/wh/generative_action/SynHSI/test_module.py", line 325, in <module>
    model = torch_tensorrt.compile(model, ir="dynamo", inputs=trt_inputs)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/_compile.py", line 249, in compile
    trt_graph_module = dynamo_compile(
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/_compiler.py", line 243, in compile
    trt_gm = compile_module(gm, inputs, settings)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/_compiler.py", line 431, in compile_module
    trt_module = convert_module(
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_conversion.py", line 107, in convert_module
    interpreter_result = interpret_module_to_result(module, inputs, settings)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_conversion.py", line 88, in interpret_module_to_result
    interpreter_result = interpreter.run()
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py", line 336, in run
    self._construct_trt_network_def()
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py", line 317, in _construct_trt_network_def
    super().run()
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch/fx/interpreter.py", line 147, in run
    self.env[node] = self.run_node(node)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py", line 378, in run_node
    trt_node: torch.fx.Node = super().run_node(n)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch/fx/interpreter.py", line 204, in run_node
    return getattr(self, n.op)(n.target, args, kwargs)
  File "/home/wh/miniconda3/envs/hsi-torch-dev/lib/python3.10/site-packages/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py", line 480, in call_function
    raise UnsupportedOperatorException(
torch_tensorrt.dynamo.conversion._TRTInterpreter.UnsupportedOperatorException: Conversion of function torch._ops.aten.aten::_to_copy not currently supported!

the code caused this error is as follow:
pi = self.positional_encoder.pos_encoding[pi.long()]
where the self.positional_encoder is an instance of a customized implementation of the transformer position encoder:
class PositionalEncoding(nn.Module):
    def __init__(self, dim_model, dropout_p, max_len):
        super().__init__()
        # Modified version from: https://pytorch.org/tutorials/beginner/transformer_tutorial.html
        # max_len determines how far the position can have an effect on a token (window)

        # Info
        self.dropout = nn.Dropout(dropout_p)

        # Encoding - From formula
        pos_encoding = torch.zeros(max_len, dim_model)
        positions_list = torch.arange(0, max_len, dtype=torch.float).reshape(-1, 1)  # 0, 1, 2, 3, 4, 5
        division_term = torch.exp(
            torch.arange(0, dim_model, 2).float() * (-math.log(10000.0)) / dim_model)  # 1000^(2i/dim_model)

        # PE(pos, 2i) = sin(pos/1000^(2i/dim_model))
        pos_encoding[:, 0::2] = torch.sin(positions_list * division_term)

        # PE(pos, 2i + 1) = cos(pos/1000^(2i/dim_model))
        pos_encoding[:, 1::2] = torch.cos(positions_list * division_term)

        # Saving buffer (same as parameter without gradients needed)
        pos_encoding = pos_encoding.unsqueeze(0).transpose(0, 1)
        self.register_buffer("pos_encoding", pos_encoding)

    def forward(self, token_embedding: torch.tensor) -> torch.tensor:
        # Residual connection + pos encoding
        return self.dropout(token_embedding + self.pos_encoding[:token_embedding.size(0), :])

What you have already tried
The complete model is complicated so I have tried to implement a minimal reproducible example, but the compilation of a single PositionalEncoding model succeed. I also tried adding more context code but it still succeed. I'm unable to get a minimal reproducible example now.
I found this error only occurs with dynamic input shape. Compiling model with fixed input shape works well.
Besides, I noticed that  #2161 had added the _to_copy converter, so I'm confused why it told me _to_copy is not supported, or maybe I misunderstand something?
Environment

Build information about Torch-TensorRT can be found by turning on debug messages

PyTorch Version (e.g., 1.0): 2.5.0.dev20240804+cu118
CPU Architecture: x86_64
OS (e.g., Linux): ubuntu 20.04
How you installed PyTorch (conda, pip, libtorch, source): pip
Python version: 3.10
CUDA version: 11.8
torch_tensorrt: 2.5.0.dev20240804+cu124

The to_copy converter now supports dynamic shapes https://github.com/pytorch/TensorRT/blob/main/py/torch_tensorrt/dynamo/conversion/aten_ops_converters.py#L1109-L1112. Please try with our main branch. If the issue exists, please provide the input shapes to pass to your reproducer for us to investigate. Thanks


Fix av_* API usage for deprecations

🦟 Bug fix
Fixes #203
Summary
After this macOS and other platforms with newer ffmpeg/libav version (Fedora 34) should build without deprecation warnings.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

did you want to cherry-pick d6b78444ea852e73aa418c1507e58f9dd3f4acae?

did you want to cherry-pick d6b7844?

Ah! Didn't even see that.


Fix confusing LICENSE issue in fatjar release

The fatjar release for 1.0.0 automatically merged commons-cli's
LICENSE.txt file into the base META-INF directory, appearing to replace
our own LICENSE with the Apache 2.0 license.  Very bad :)
This corrects the situation by somewhat manually organizing the
dependencies into the following structure:
META-INF/
META-INF/commons-cli-LICENSE.txt
META-INF/commons-cli-NOTICE.txt
META-INF/LICENSE
META-INF/MANIFEST.MF
META-INF/maven/
META-INF/maven/commons-cli/
META-INF/maven/commons-cli/commons-cli/
META-INF/maven/commons-cli/commons-cli/pom.properties
META-INF/maven/commons-cli/commons-cli/pom.xml

Why arent these put in META-INF/maven/commons-cli ?


Yarn plugin does not install completions

Yarn plugin does not install completions

To Reproduce
Added yarn to the plugins list in .zshrc and restarted zsh
Expected: Typing yarn <TAB> should list available yarn commands
Actual: files are being completed
System:
Ubuntu, zsh 5.4.2, Gnome terminal
Probable cause the plugin.zsh file only contains a bunch of aliases - no mention of the _yarn completion file. Probably the install command is missing?

apparently you need to delete the .zcompdump* files after installing a plugin. Did not know that. After that it works as expected


Don't allow translation of our example Doge address

Changes sample address to address with no held private key.
Removed unused strings

I tested this on English, de_AT, and Arabic (RTL language). All three look fine. Since it has my commits, waiting for someone else to look over it :)

Could we get some squashing please? :)


A KerasTensor cannot be used as input to a TensorFlow function

I'm taking a batch of 8 images directly off the "KSampler SDXL Efficient" node and trying to extract the number of faces and count them.  It's throwing this error:
!!! Exception during processing !!! A KerasTensor cannot be used as input to a TensorFlow function. A KerasTensor is a symbolic placeholder for a shape and dtype, used when constructing Keras Functional models or Keras Functions. You can only use it as input to a Keras layer or a Keras operation (from the namespaces `keras.layers` and `keras.operations`). You are likely doing something like:

x = Input(...)
tf_fn(x)  # Invalid.
What you should do instead is wrap `tf_fn` in a layer:
class MyLayer(Layer):
    def call(self, x):
        return tf_fn(x)

x = MyLayer()(x)
Traceback (most recent call last):
  File "/ai/ComfyUI/execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ComfyUI/execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ComfyUI/execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)
  File "/ai/ComfyUI/execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ComfyUI/custom_nodes/ComfyUI-Deepface/nodes.py", line 72, in run
    detected_faces = DeepFace.extract_faces(
                     ^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/deepface/DeepFace.py", line 484, in extract_faces
    return detection.extract_faces(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/deepface/modules/detection.py", line 89, in extract_faces
    face_objs = DetectorWrapper.detect_faces(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/deepface/detectors/DetectorWrapper.py", line 83, in detect_faces
    face_detector: Detector = build_model(detector_backend)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/deepface/detectors/DetectorWrapper.py", line 51, in build_model
    face_detector = face_detector()
                    ^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/deepface/detectors/RetinaFace.py", line 9, in __init__
    self.model = rf.build_model()
                 ^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/retinaface/RetinaFace.py", line 54, in build_model
    retinaface_model.build_model(),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/retinaface/model/retinaface_model.py", line 1027, in build_model
    x1_shape = tf.shape(ssh_c3_up)
               ^^^^^^^^^^^^^^^^^^^
  File "/ai/ve/comfy/lib/python3.12/site-packages/tensorflow/python/util/traceback_utils.py", line 153, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/ai/ve/comfy/lib/python3.12/site-packages/keras/src/backend/common/keras_tensor.py", line 138, in __tf_tensor__
    raise ValueError(
ValueError: A KerasTensor cannot be used as input to a TensorFlow function. A KerasTensor is a symbolic placeholder for a shape and dtype, used when constructing Keras Functional models or Keras Functions. You can only use it as input to a Keras layer or a Keras operation (from the namespaces `keras.layers` and `keras.operations`). You are likely doing something like:

x = Input(...)
tf_fn(x)  # Invalid.

What you should do instead is wrap `tf_fn` in a layer:
class MyLayer(Layer):
    def call(self, x):
        return tf_fn(x)

x = MyLayer()(x)
Prompt executed in 101.88 seconds

I think this is related to the version of tensorflow - deepface had an issue here previously: https://github.com/serengil/deepface/issues/1121 - and this repo is locked to an older version of deepface due to some incompatibilities with the newer interface.
Can you let me know which version of tensorflow you have installed?


Disable all manual __mocks__ at once with jest.unmockAll().

🚀 Feature Proposal
Disable all manual __mocks__ at once with jest.unmockAll(), including the manual mocks for node_modules.
Motivation
Historically, the main pattern for testing UI was to focus on unit tests that tested UI components in isolation. With this pattern, it is common to mock modules so the internal details of nested components would not leak into the tests of the component under test. One canonical example was to provide manual mocks for common shared component (via __mocks__) so the dom elements of the nested components would not show up in snapshots.
With the advent of new testing libraries such as testing-library, there has been a trend to write tests that closely resemble how components are used. In practice, that usually means mocking as little as possible. In this context, we generally do not want third-party node_modules to be mocked and we have to call unmock for all the manual node modules __mocks__ that the component under test indirectly relies on.
This is very cumbersome for a couple of reasons:

There might be many of those manual __mocks__ in codebases that either want to support both testing patterns at the same time, or that are slowly migrating toward one or the other pattern.
There is no way to know what __mocks__ modules were used by jest during a test. You currently need to check manually the code of every single indirect dependency of a module.

This is completely impractical for large codebases.
The same way we can disable all auto-mocked modules with jest.disableAutomock(), there should be a way to disable all manually mocked modules with jest.unmockAll(). Ideally, we would also expose a manualMock boolean parameter in jest config so it can be disabled across multiple tests at once.
Example
jest.unmockAll()
Pitch
Since manual __mocks__ are a jest concept, the only way to change is to update jest itself.
I'm happy to send a PR if the maintainers of jest are fine with this feature. Let me know and I'll work on it asap.
Cheers
EDIT: Made it clearer that the problem is for __mocks__ of node_modules

Thanks for the suggestion. I didn't quite understand why this is needed for manual mocks. Given that, unlike automocks, you have a jest.mock somewhere that activates them, why not just remove that line?

That's not the behavior I'm seeing with 24.8.0. jest will automatically mocked modules for which there are manual __mocks__. If I remember correctly, it's been like that since the very early days of jest. Would you like me to send a repro?

From the documentation:

If the module you are mocking is a Node module (e.g.: lodash), the mock should be placed in the mocks directory adjacent to node_modules (unless you configured roots to point to a folder other than the project root) and will be automatically mocked. There's no need to explicitly call jest.mock('module_name').

Actually:

When a manual mock exists for a given module, Jest's module system will use that module when explicitly calling jest.mock('moduleName'). However, when automock is set to true, the manual mock implementation will be used instead of the automatically created mock, even if jest.mock('moduleName') is not called. To opt out of this behavior you will need to explicitly call jest.unmock('moduleName') in tests that should use the actual module implementation.

It looks like I need to disable automock in the config file. Calling jest.disableAutomock() is not enough.
Then maybe the feature request should be to also disable __manual__ mocks when we call jest.disableAutomock(). It was confusing to me there was no way to disable this behavior even though automocking was disable in my test file. What do you think?
Apologies for the confusion

@jeysal Updated my last comment ^

Yeah I do agree that it would be more intuitive if node_modules were treated the same, but it's very breaking. @SimenB maybe you have some more historical context on this?
Especially given that its use limited to node_modules, I'm not sure the proposed API would be useful to many people, and also I'm worried it might encourage bad practices. Automocking is no longer the default even at FB, most people consider being explicit about mocks and using them sparingly to be the better way. So if a mock is used in some tests but not in others, it might be better to not include it by default, but explicitly include it in some tests.
For normal files, this is just the standard jest.mock('./something'), for node_modules this can still be achieved via jest.mock('something', () => require('../global-mocks/something')).

I fully agree with you that it's much better to be explicit. That's exactly why I want a way to disable all jest mocking / magic with one command. I don't want any mocking happening in my test file unless I specifically call mock(). The current pattern of being to define global __mocks__ completely breaks this because you cannot easily disable that in a given test file.
I'm not sure I follow why it would encourage bad practices. To the contrary, it would allow people to slowly migrate away from having their tests depending on node modules __mocks__.

Oh so you want to unmockAll then explicitly mock some immediately afterwards?

Yeah I potentially might mock some modules afterwards. Essentially, I just want to tell jest don't mock anything unless I told you to.

Okay. Of course I'd very much prefer to just make that the default, hopefully @SimenB knows more about how it came to be like this (node_modules still effectively having automock: true).
For now, would the last sentence of my comment help you? (It's essentially avoiding the special mocking behavior for node_modules and using regular mocking mechanics for them instead)

Yes I'm aware we can manually mock a module in a test using jest.mock if that's what you are asking. But that does not help me disable manual __mocks__ for node_modules. For that, I have to repeatedly call jest.unmock() for each node_modules that have been globally mocked. I tried to automate this with a util function but that does not work because I think the jest.unmock calls have to be statically analyzable and / or in the top-level scope of the test module.

Of course you'd have to remove the node_modules __mocks__ in favor of the global-mocks, hence

avoiding the special mocking behavior for node_modules and using regular mocking mechanics for them instead

Are you saying that manual mocks (ie __mocks__) should be avoided? I knew that automocking was now somehow deprecated but it's the first time I hear that __mocks__ are bad because they cannot be disabled in tests. If that's case, I think we should make that very clear in the guide for manual mocks and let people know about it. Without this, people are going to keep running into that issue where they want to disable one global mock for a node_module but have to refactor all their test to accomplish this. It seems to me that exposing a jest.unmockAll() is more pragmatic and more consistent with the approach we took in the past with automocking.

No, it's great in general. It's just that the special behavior for node_modules does not work well for you (and I can see why) and I am trying to help you find a quick solution for that particular aspect.

I see - thanks for trying to help me out. I can workaround this for now by calling unmock() repeatedly.
That said, I think it would be helpful to other people to have a simple way to disable all jest magic in a given test if need be and I'm happy to send a PR if you are onboard with this change.

Yes, why is this not a thing?? Pretty wild that its not!
This is a huge necessity for me

I would also love to be able to configure our jest setup to not auto-import node modules mocks so we can cho0se to mock at the file level. In a large codebase, the auto-mocking has a large blast radius.

This feature would be nice in my case as I have some unit tests mock all of the underlying npm & node modules. In the integration tests though I need all of those underlying packages to function as normal! It would be cleaner to just write jest.unmockAll() rather than turn them off one by one.

I also agree that we need a way to disable manual mocks in case we have different types of tests. e.g integration or e2e. In the mean time I found a work around for this that avoids having to call jest.unmock everywhere.
I make jest ignore path patterns for mocks made for special cases in my code when I don't use automock, as well as ignore the root mocks meant to manual mock node_modules on special cases where automocks couldn't do the job.
modulePathIgnorePatterns: ['<rootDir>/src/.*/__mocks__', '<rootDir>/__mocks__'],

If by any reason, you still need to mock certain libs in your integration tests then you can pass jest a node script in setupFilesAfterEnv that calls your jest.mock on whatever module you need and provide it the manual mock there. It's a bit of a wrapper while we get this feature accepted and into jest.

And here I thought that disableAutomock did just this, until I actually started having problems in my tests.
I'd say the most "correct" way would be to make disableAutomock actually disable all auto mocks. But that would probably start breaking a lot of tests for everyone. So I'm happy with the OP proposal 👍
Maybe for the future, disableAutomock could be deprecated and replaced with disableFirstPartyAutomocks or partialDisableAutomock or something like that, for clarity.

+1

+1

I had an issue with this as well.
I have unit tests that require all the mocking from jest, but also have integration tests which don't need mocks at all and run as a separate jest project.
I found a workaround by looping though mocks directory and calling jest.dontmock(...) on each of the files

How about introducing an additional config parameter automockNodeModules defaulting to a non-breaking true?

+1

Manual mocks for scoped modules seem to be especially troublesome. I have found no way to override such a mock, via unmock, mock with requireActual, etc. We need a better way to work with manual mocks.

Not stale


After adding attribute to ignore in styles I got an Error

After adding this attribute to ignoreStyles:
ignoredStyles={[               "display",               "width",               "height",               "font-family",               "padding",               "font-weight"             ]}

Environment
Environment:
React: 16.8.3
React native: 0.58.0
react-native-render-html: ^4.2.0
Actual Behavior

I'm closing because this issue does not follow our contribution guidelines. We would need a minimum working example and steps to reproduce to help you out here. Feel free to post a new compliant issue.


Unify the SSO config for both GitHub and GitHub Enterprise

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Unify the SSO config for both GitHub and GitHub Enterprise. GITHUB_ENTERPRISE provider name was deprecated.

/approve

/approve


Allow an empty defaultValue option for enhanceSelectElement

The check for a default value option matches false-y values, but that also catches the case where the default value is explicitly set to an empty string.
Add an extra condition for the case where the default value is '' so that it is not overwritten with the content of the first <option>.

Very happy. Tests were on their way, but hit a slight blocker in that I was struggling to get them to run locally, and I was planning a separate PR to resolve my test issues. I'll get on the case though.

Turns out most of my test blockers were my own out-of-date installs (my local firefox was 23 major versions behind current!).
I've added a test above, but it seems to be failing, and I'm not 100% sure why. I'll go into it a bit further, but I haven't used karma in a long time, or any react testing tools, so it might be a while. Any insight you might be able to provide would be much appreciated.

@lennym well done! CI didn't succeed for one reason or another, I've ordered a rebuild. Will merge after.

I saw. Thanks 💯 for your super fast help on this.

@lennym sorry about this, CI seems to be having trouble connecting to Sauce Labs for the end to end tests. It will take a bit longer to merge this while I investigate.
I suspect it may be related to the fact that this PR is coming from an external fork, in which case I'd really like to fix this issue.

No problem. I know there are issues in travis with secure environment variables not being available for PR builds to avoid them being vulnerable to malicious PRs.
There's no urgency on our side at all. I just took on the spike to implement this as a "Friday afternoon job" - we're not necessarily planning on putting into production any time soon.

No problem. I know there are issues in travis with secure environment variables not being available for PR builds to avoid them being vulnerable to malicious PRs.

That's the issue.  Now that it's ticked, it doesn't work because the env vars are not being exposed.
Do you know of a good solution other than not providing this functionality and instead pulling remote code + opening separate PR + closing the one submitted by contributor?

My only thought is possibly to build PRs with tests run "locally" against a phantomjs instance, and reserve a full saucelabs test for master builds.
If it's any use, I made a little script helper for running conditional travis builds a while ago, which we found to help with doing things like this - https://www.npmjs.com/package/travis-conditions

@lennym I thought about that, however, I had to move away from phantomjs because I found our tests to not produce relevant results on that browser. (using webdriverio, selenium, the respective drivers so it could be an issue from a number of parts not just phantomjs itself)
I'll open an issue to discuss this further but until then I will deactivate Build pull request updates.
I'll merge this, and publish a new version after master builds.
Thanks again!

I'd strongly recommend trying a conditional build so you can still run your linter and unit tests on PRs. At least that way you can automate most of the testing.

Published in v1.0.2!
@lennym happy to chat more in https://github.com/alphagov/accessible-autocomplete/issues/129, might have to get back to this at a later point.

I've been doing a bit more looking at this this morning and I'm now unsure that what I've done is correct.
Our desired behaviour (and IMO, what should probably be default behaviour) is something like this:

If user hits the page for the first time and no value has previously been selected (technically that means the <option value="">Select</option> is selected) then they see a blank text box.
If the user has previously entered a value, and another option is selected then they see the innerHTML of the selected <option>.

The problem with this is that it's quite tricky to "nicely"configure with the options as they are - you end up needing to add a condition to check if the value of the select exists, and then either set the defaultValue to be '' or the innerHTML accordingly.
I think a better approach is to incorporate this into the enhanceSelectElement function so that it only uses the defaultValue option if the "default" option is selected (i.e. selectElement.value == false) and uses the label of the selected element otherwise.
tl;dr - more PRs coming

@lennym yes, that does sound like a more sensible default. 👌

Super. I'm just finishing off #130 and then I'll implement roughly what I've described above.


⚠ GitHub has degraded performance

In 393c693, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 152 ms

Resolved: GitHub performance has improved in 354cd27.


Enhancement - Download DwC selected predicates should default to project preferences

Feature or enhancement
When I download a DwC archive through the Filter CO task, I'm prompted with the "Filter by predicates" modal. Instead of defaulting to all predicates unselected, it should default to the predicates selected in the project's settings.

Location
Filter CO
Screenshot, napkin sketch of interface, or conceptual description
No response
Your role
No response

Nevermind, It looks like it already does this and I hadn't noticed. Closing.


Vert.x 4 RC1 HttpContext null clientRequest bug

Hello!
I'm upgrading a working project from vert.x3 to vert.x4 to use your new tracing capabilities and I found a bug in web client.
We have a handler to store cache responses during DISPATCH_RESPONSE Phase. We get some info from HttpContext.clientRequest in vert.x3 without problem, but now in vert.x4 our HttpContext.clientResponse is null in DISPATCH_RESPONSE. Doc says it should be non null: only available during ClientPhase#SEND_REQUEST and after

Is there a condition that could set this object as null?

Also in SEND_REQUEST phase is null.

could you provide a reproducer project ?

please provide a reproducer

no reproducer provided

no reproducer provided


social.msdn and social.technet localization redirects don't work

EX: if you remove the locale from https://social.msdn.microsoft.com/Forums/en-US/home?forum=vsmantest it drops the query string while redirecting back to en-us.
Not sure if the checks actually flag those links right now, but just one issue i've noticed if people try and remove it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b1f3e76-a163-54ee-a2d4-fe4095285e54
Version Independent ID: a60814e1-6b5f-5b13-584b-26c73384caec
Content: Locale-specific links - Contributor Guide
Content Source: Contribute/validation-reference/locale-specific-links.md
Product: non-product-specific
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

ping @dend
This scenario does work for docs.microsoft.com (for example, remove the locale info from https://docs.microsoft.com/en-us/dotnet/api/system.string?view=netcore-2.1 to test).
Should this move to MicrosoftDocs/feedback?

@nschonni I've had this conversation with the forums owners before, but it was decided not to fix. For now keep en-us in links to the MSDN forums. It's a lot of work to fix and the workaround is fairly easy for most folks. Thanks, Jason


Add element to parse string using alphabet

I had to resort to having tuples containing the index of the item.

Dammit! I forgot the ctx!

wonder why branches get auto-deleted...


When building C++ extensions, replace all of linker command

instead of just one word of the linker command.
This is to support use case of CXX=g++ and CC=ccache gcc

Tests pass now. Ready for review

Thanks for your patience on this, @isuruf. I learned a lot and I believe the compiler code is in a better shape now. Please have a look at 829009b, where I took a slightly different approach to keep the body of the code a little tighter.


Do not block drawer animation on narrow

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


set myself depending on participantId

Hay Guys
I try to make the component work automatically without add extra code from the user
newMessage: (state, message) => {
    message.timestamp = moment(message.timestamp);
    message.myself = message.participantId === state.myself.id;
    state.messages = [...state.messages, message];
}

setMessages: (state, messages) => {
    messages.map(message => {
        message.timestamp = moment(message.timestamp);
        message.myself = message.participantId === state.myself.id;
    });
    state.messages = messages;
}

Hi, @Qanah! I agree with your changes.
Please, fix the PR as I commented. After the fixes, I'll merge your PR.

Hi, @MatheusrdSantos Please check now.

@Qanah, thanks for your contribution.


Empty or missing scope not allowed with GOOGLE_APPLICATION_CREDENTIALS

I'm using a service account and setting the environment variable GOOGLE_APPLICATION_CREDENTIALS and getting an error complaining about missing scope.
Here's some simple code to reproduce it.
import google.auth
import google.auth.transport
import google.auth.transport.requests
import os
print(os.getenv("GOOGLE_APPLICATION_CREDENTIALS", ""))
credentials, project_id = google.auth.default()
request = google.auth.transport.requests.Request()
credentials.refresh(request)

This throws an exception
Traceback (most recent call last):
  File "credentials_repo.py", line 9, in <module>
    credentials.refresh(request)
  File "/usr/local/lib/python2.7/dist-packages/google/oauth2/service_account.py", line 322, in refresh
    request, self._token_uri, assertion)
  File "/usr/local/lib/python2.7/dist-packages/google/oauth2/_client.py", line 144, in jwt_grant
    response_data = _token_endpoint_request(request, token_uri, body)
  File "/usr/local/lib/python2.7/dist-packages/google/oauth2/_client.py", line 110, in _token_endpoint_request
    _handle_error_response(response_body)
  File "/usr/local/lib/python2.7/dist-packages/google/oauth2/_client.py", line 60, in _handle_error_response
    error_details, response_body)
google.auth.exceptions.RefreshError: ('invalid_scope: Empty or missing scope not allowed.', u'{\n  "error" : "invalid_scope",\n  "error_description" : "Empty or missing scope not allowed."\n}')

Do scopes need to be explicitly set when using service accounts?
I'm using google-auth 1.2.1
pip freeze | grep google-auth
google-auth==1.2.1
google-auth-httplib2==0.0.2

@jlewi Yes. That error message is directly from the server.
@jonparrott WDYT about failing the request locally rather than relying on the backend?

Thanks @dhermes . I'll leave this issue open since there's a question pending for @jonparrott but my question has been addressed.

WDYT about failing the request locally rather than relying on the backend?

I would rather not have that logic on the client side, as it's not strictly required. It's possible for an authorization server to grant a token without scopes.


fix: Calendar UI modified and test cases updated

fix: Calendar UI modified and test cases updated

Coverage remained the same at 25.645% when pulling 5cd6486fb2bbd51a150ef9378168438b0c10ad3d on lduoduo:dev into 3a8514ea8f92e47d31fceb4b3107da649124680d on ZhonganTechENG:dev.


[SectionFilterHeader] Debounce search/namespace inputs

When there is a decent amount of rows with data, search/namespace filters immediately change filter state which just blocks page and causes bad user experience.
I think onChange logic of such components should be debounced.
Also thoughts: If headlamp used newer version of react this thing could be also fixed with useDeferredValue.

We have new search filters with the new Table component, and I recall a debounce was added in there. But need to confirm this is still a problem...
@sniok do you recall if the search/namespace filters are ok with lots of data now? If not I will try and reproduce.

Also thoughts: If headlamp used newer version of react this thing could be also fixed with useDeferredValue.

We did some work a while ago preparing for react 18 (changing from withStyles to sx attributes mostly, but also switching away from Create React App), and I'm currently going through updating other dependencies. The issue is here: https://github.com/headlamp-k8s/headlamp/issues/1554


Parse Promise Then Handler Doesn't Crash With Error

When I experience a javascript error in my promise then handler my requests just hang.  No error shows up in the console and the code doesn't return.
In a promise.then() handler just add this line.
notarealvar.notarealthing();
The request just hangs.  If you wrap it in a try catch you can see an error.

cc @andrewimm

This is part of the Promises/A+ spec. Thrown exceptions within the execution of a promise are caught by the promise, and passed to the next error callback.
If you want to catch the exceptions that have occurred up until a point, just provide an error callback to any .then() call. Or, if you want to avoid Promises/A+ compatibility, you can always disable it with Parse.Promise.disableAPlusCompliant()

There is an error callback that just calls response.error(error).  But it was never called so the cloud code method never responded.

Code sample?
Keep in mind, if you do
someTask().then( onSuccess, onError )

the error handler will catch exceptions from someTask, but will not catch exceptions from onSuccess

Gotcha.  Yeah it's code in the onSuccess that's failing silently.

I tend to tack on a final .fail((e) => ... ) callback to the entire chain to handle the errors in there (fail(x) is an alias for then(null, x))


Syntax error in provided Connect-SPFarmToAAD function

This syntax error seems to present since 2013: https://social.msdn.microsoft.com/Forums/en-US/00ba9320-4942-4c5b-9a14-fa1132d2248e/use-an-office-365-sharepoint-site-to-authorize-providerhosted-apps-on-an-onpremises-sharepoint?forum=sharepointdevelopment
The error:
Set-MsolServicePrincipal : Invalid syntax.  Parameter Name: ServicePrincipalNames.
At C:\Windows\system32\WindowsPowerShell\v1.0\Modules\MySharePointFunctions\MySharePointFunctions.psm1:103 char:9
+         Set-MsolServicePrincipal -AppPrincipalId $SPAppPrincipal.AppP ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (:) [Set-MsolServicePrincipal], MicrosoftOnlineException
    + FullyQualifiedErrorId : Microsoft.Online.Administration.Automation.StringSyntaxValidationException,Microsoft.Online.Administration.Auto
   mation.SetServicePrincipal

The value to -ServicePrincipalNames, $SPAppPrincipal.ServicePrincipalNames, must be in double-quotes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58462e32-ad55-2351-ee7d-67c047fa4157
Version Independent ID: 0cba1f85-d95c-6b4e-583d-608a6743e15f
Content: Use ACS to authorize low-trust provider-hosted add-ins on an on-premises SharePoint site
Content Source: docs/sp-add-ins/use-an-office-365-sharepoint-site-to-authorize-provider-hosted-add-ins-on-an-on.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Not clear what you mean... are you saying the values within the property should be in quotes or the property reference should be in quotes? Can you provide a sample that does work to see how it differs from the docs?


153 canvas

What type of PR is this? (check all applicable)

[X] Feature
[ ] Refactor
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other (please specify here: )

Description of what this Pull Request does
Ability to use canvas, draw lines and rectangles and save screenshot as png to computer
Related Tickets & Documents

Closes #123
Related Issues: (enter ticket numbers here)

QA Instructions, Screenshots, Recordings
(In this section, describe how to QA/review your PR. Feel free to use screenshots and/or short videos)
Added/updated tests?

[ ] Yes
[X] Not Yet, and here is why: Test needs to be created for this page
[ ] I need help with tests
[ ] No, and here is why: explain here

Please be aware, main still needs to be pulled in before merging!


hide_when_no_warning broken?

Describe the bug
After upgrading to 2.5.0 it seems hide_when_no_warning is broken. I have it enabled, yet it still shows the card even when there are no warnings.
Screenshots

Card version
v2.5.0
Installation type
Home Assistant Community Store (HACS)
Card Configuration
type: custom:meteoalarm-card
entities: binary_sensor.meteoalarm
integration: meteoalarm
override_headline: false
hide_when_no_warning: true
tap_action:
  action: url
  url_path: https://www.meteo.be/nl/weer/waarschuwingen/overzichtskaart-belgie

Integration type
Meteoalarm

Reverting to 2.4.3 fixes it:

Yeah seams like it, will patch

Not related, but: is it possible to patch out the s.entries is not a function warning as well? ;)

Not related, but: is it possible to patch out the s.entries is not a function warning as well? ;)

possibly, I need screenshot from browser developer console

Not related, but: is it possible to patch out the s.entries is not a function warning as well? ;)

possibly, I need screenshot from browser developer console

No errors there:

This will be fixed in the next version, thank you for your contribution!
For that editor bug, no idea honestly, can't reproduce it. You can try to remove the card and configure it via the visual editor and see if it breaks.


[Feature#1270][Connectors] add plugin: seatunnel-connector-spark-http

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@tmljob Please fix unit tests errors, thanks.

This ut has nothing to do with the code submitted by my pr. This is a problem that existed when fork from the dev branch. Do you need me to modify it here?

@tmljob Please fix unit tests errors, thanks.

This ut has nothing to do with the code submitted by my pr. This is a problem that existed when fork from the dev branch. Do you need me to modify it here?

@tmljob The ut case should be fixed by upstream, could you please rebase the upstream/dev?

@tmljob Please fix unit tests errors, thanks.

This ut has nothing to do with the code submitted by my pr. This is a problem that existed when fork from the dev branch. Do you need me to modify it here?

@tmljob The ut case should be fixed by upstream, could you please rebase the upstream/dev?

I've synced the latest code from the dev branch, and this ut use case runs fine in my local environment alone.


refactor: don't wrap empty fin data in Option

It's treated the same as non-empty data, so get rid of all the branch handling.

Verbal 👍🏻 from Jacob :)


Fix for #16: Unable to use different Locale without querying locales

Similair fix to issues #9 and #10: static method on the class which constructs the instance and sets the private members

@tamasvajk - is this one going to be merged in?

Yes, it will. (I hope I'll have some time in the weekend to do this.) Thanks for the checking the other two PRs.


Move Azure dependency into root POM and use BOM

Avoid managing each library individually

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (916a913).
Report is 843 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (916a913). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (916a913)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
0

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13765       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2482       +46
  Lines        133233   137378     +4145
  Branches      20636    21380      +744
=============================================
- Hits          82274        0    -82274
- Misses        44911   137378    +92467
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[UX+bug] UI for non-activated organizations in clickable where it shouldn't be: disabled [Activate Billing] can lead to HTTP 500

Describe the bug

This is similar to https://github.com/pypi/warehouse/issues/10773. A disabled button is clickable for a non-reviewed/non-approved org and it allows navigating to a "forbidden" page that possibly tracebacks internally.
Expected behavior

The button shouldn't be clickable.
The activation page shouldn't render HTTP 500 but rather HTTP 401/403.

To Reproduce

Create an organization at https://pypi.org/manage/organizations/
Click on a "disabled" [Activate Billing] button.
Get surprised it's clickable.
Click on the [Activate Subscription] button.
See an HTTP 500 page implying that PyPI is down.

My Platform
Chrome on Android, probably unrelated.
Additional context

Thanks! We changed the visibility to disable, but didn't actually disable the button.

Yeah, but I suppose there's two bugs, the second one being the ability to navigate to the nested URLs behind that button.

Agreed - but I think disabling the button AND href will be enough for now until we re-instate billing.


Docker run requires additional flag "--security-opt seccomp:unconfined" starting v1.10

Security Updated for Docker requires new launch flag
Errors:
gdbserver fails w/ "Cannot PTRACE_TRACEME: Operation not permitted"
VS2015 will error w/ "Cannot start gdbserver"
docker run -d -p 12345:22 visual-studio-linux-build-box
Should be updated to:
docker run -d -p 12345:22  --security-opt seccomp:unconfined visual-studio-linux-build-box
References:
https://github.com/docker/docker/issues/20064
https://blog.docker.com/2016/02/docker-engine-1-10-security/

Hi @vimgodfrey ,
I will add this in the readme.
But I have no error with the docker 1.11.
Which version did you use to generate this error ?

Docker version 1.12.0, build 8eab29e

OK, thanks.


⚠ ClamAV has degraded performance

In 041462b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 578 ms

Resolved: ClamAV performance has improved in 63b7201 after 23 minutes.


Support for resizing the shared drive snapshot

Updating CloudFormation templates to support resizing the shared drive when created from a snapshot. Previously the volume_size parameter was ignored when creating from a snapshot. With this change, the user can specify volume size that is larger than the original snapshot. If the user specifies a volume size that is smaller than the snapshot, the snapshot size is used instead. It does not cause an error. NOTE: There is a side effect to take into account when reviewing this PR.  If the user has created a snapshot that is smaller than 20GB and does not specify a VolumeSize, the default value of 20GB will be used.
Why is this important? I am working a WRF cluster that is run for different size simulations. We are running pIOPS and storage is a significant cost driver. During a normal day, we run many small (4 node) clusters every few hours. These simulations are low resolution and only need a small volume. Occasionally (e.g. when a storm is coming) we run a much larger simulation and need lots more storage. Managing multiple snapshots for various simulation sizes is a hassle and this would make life better.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This patch is a silent change in user behavior for many of the use cases, including the case called out in the commit log.  If we take this patch as is, the next release should have a major version number bump.  Given the likely ability to avoid those behavior changes (say, but using the snapshot size if an explicit size isn't given), it seems like doing more work on the patch is the right path forward.
Regardless, the docs need to be updated to reflect the final change in behavior.


Feature: re-usable component bundles

I'd like to efficiently re-use component bundles that aren't known statically.
Implementing DynamicBundle myself seems painful and not intended.
Re-using can only happen if all of the components are Clone.
Ideally, we'd have impl DynamicBundle for &'a EntityBuilder if we know that all of the components are cloneable. This would allow me to just keep an EntityBuilder around and use it as a bundle.

I think this is widely useful, so I'm interested in having it. In particular, it makes it easy to repeatedly spawn individual entities based on a dynamically-loaded prototype with minimal boilerplate. However, it represents a significant API design challenge.
As a baseline, this could be accomplished by duplicating most of EntityBuilder, with the addition of requiring Clone for each component type and storing a function pointer that clones into supplied memory, to be invoked from the DynamicBundle::put implementation. Of course, we'd rather not duplicate that logic, or even duplicate the interface in a newtype around a shared structure.
What we need is some way to abstract EntityBuilder over the presence/absence of Clone, and carry around additional metadata necessary to satisfy those bounds dynamically. My first idea is a marker type parameter indicating whether the Clone requirement is present, with available methods differing based on which marker type is supplied. I'll try to evaluate whether this approach is viable tonight.

As an aside, a somewhat inefficient but easy, stable, and safe workaround for this issue could look something like Vec<Box<dyn Fn(&mut EntityBuilder)>>, populated with closures that insert a component into a builder.

The EntityBuilderClone is extremely useful.
Although it is not published on crates.io. Is it possible to include it in a non breaking minor release?

Glad to hear it's helpful! Is there some specific breakage you're concerned about? I was planning on cutting 0.7 very soon; I can backport to 0.6 if necessary, but I'd be surprised if the upgrade presented a problem.

I've now published 0.7.0. Sounds like you might be interested in the new CommandBuffer helper as well! #19 wouldn't be great for multithreading, since it requires an &mut World.

Absolutely zero breakages in https://github.com/ten3roberts/ivy, and one compile time breakage in https://github.com/ten3roberts/hecs-hierarchy relating to Entity::from_bits returning Option, which is fixed and published.
Splendid work :+1:

Great!


Refactor; update api gem dep version; remove global state; bump version

This is all pretty lazy coding.. it works, and I move on.. since that's sufficient for now


Deprecate DeepSpeedPrecisionPlugin

Proposed refactor
Motivation
After #10596, the optimizer step and backward methods reside in the TTP (previously in Accelerator). Since DeepSpeed handles optimizer step, backward and precision internally, we can encapsulate all logic directly in the TTP. The DeepSpeedPrecisionPlugin is no longer required. It should not be possible to use custom precision plugins with DeepSpeed, an error handling should be added to prevent that.
Pitch

Move DeepSpeedPrecisionPlugin.backward to DeepSpeedPlugin.backward
Move DeepSpeedPrecisionPlugin.optimizer_step to DeepSpeedPlugin.optimizer_step
Raise a MisconfigurationException when a precision plugin gets passed to the DeepSpeed plugin

It will also simplify an awkward pattern in the code for accessing the model via model.trainer.model.
Additional context
This will also unblock #10657

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @justusschock @awaelchli @akihironitta @tchaton @SeanNaren

@awaelchli We wouldn't be able to remove the class because we still need to override clip_gradients and _track_grad_norm.


Error rendering partials with a lot of images

Hi @owen2345!
I've discovered that this are not efficient with a lot of images. ;)

@raulanatol
I can see a conflict with other PR, could you please merge and create again?

Already @cmckni3 has resolved the issue in https://github.com/owen2345/camaleon-cms/pull/349

Serendipitous


ListView scrolling with PageDown results in System.ArgumentOutOfRangeException

Scrolling down a ListView by holding the Page Down key in a large list eventually results in System.ArgumentOutOfRangeException.
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
   at System.Collections.Generic.List`1.System.Collections.IList.get_Item(Int32 index)
   at Terminal.Gui.ListView.OnSelectedChanged() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Views\ListView.cs:line 636
   at Terminal.Gui.ListView.MovePageDown() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Views\ListView.cs:line 479
   at Terminal.Gui.ListView.ProcessKey(KeyEvent kb) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Views\ListView.cs:line 384
   at Terminal.Gui.View.ProcessKey(KeyEvent keyEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\View.cs:line 1486
   at Terminal.Gui.View.ProcessKey(KeyEvent keyEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\View.cs:line 1486
   at Terminal.Gui.View.ProcessHotKey(KeyEvent keyEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\View.cs:line 1502
   at Terminal.Gui.Application.ProcessKeyEvent(KeyEvent ke) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 307
   at Terminal.Gui.WindowsDriver.ProcessInput(InputRecord inputEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 762
   at Terminal.Gui.WindowsDriver.<PrepareToRun>b__31_0(InputRecord e) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 661
   at Terminal.Gui.WindowsMainLoop.Terminal.Gui.IMainLoopDriver.MainIteration() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 1634
   at Terminal.Gui.MainLoop.MainIteration() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\MainLoop.cs:line 238
   at Terminal.Gui.Application.RunLoop(RunState state, Boolean wait) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 645
   at Terminal.Gui.Application.Run(Toplevel view, Func`2 errorHandler) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 737
   at Terminal.Gui.Application.Run(Func`2 errorHandler) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 687
   at Cashbox.Screen.Activate() in E:\cashbox_cs\common\UiScreen.cs:line 55
   at Cashbox.UI.ShowScreen[T](Object[] args) in E:\cashbox_cs\common\UiTools.cs:line 98
   at config.ViewMenu.<>c.<OnActivate>b__6_3() in E:\cashbox_cs\config\ViewMenu.cs:line 39
   at config.ViewMenu.OnOpenSelectedItem(ListViewItemEventArgs args) in E:\cashbox_cs\config\ViewMenu.cs:line 64
   at Terminal.Gui.ListView.OnOpenSelectedItem() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Views\ListView.cs:line 659
   at Terminal.Gui.ListView.MouseEvent(MouseEvent me) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Views\ListView.cs:line 751
   at Terminal.Gui.View.OnMouseEvent(MouseEvent mouseEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\View.cs:line 2186
   at Terminal.Gui.Application.ProcessMouseEvent(MouseEvent me) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 472
   at Terminal.Gui.WindowsDriver.ProcessInput(InputRecord inputEvent) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 773
   at Terminal.Gui.WindowsDriver.<PrepareToRun>b__31_0(InputRecord e) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 661
   at Terminal.Gui.WindowsMainLoop.Terminal.Gui.IMainLoopDriver.MainIteration() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\ConsoleDrivers\WindowsDriver.cs:line 1634
   at Terminal.Gui.MainLoop.MainIteration() in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\MainLoop.cs:line 238
   at Terminal.Gui.Application.RunLoop(RunState state, Boolean wait) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 645
   at Terminal.Gui.Application.Run(Toplevel view, Func`2 errorHandler) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 737
   at Terminal.Gui.Application.Run(Func`2 errorHandler) in E:\cashbox_cs\Terminal.Gui\Terminal.Gui\Core\Application.cs:line 687
   at Cashbox.Screen.Activate() in E:\cashbox_cs\common\UiScreen.cs:line 55
   at Cashbox.UI.ShowScreen[T](Object[] args) in E:\cashbox_cs\common\UiTools.cs:line 98
   at config.Program.Main(String[] args) in E:\cashbox_cs\config\Program.cs:line 19

A minor change to ListView.cs line 636 would appear to resolve the issue:
var value = source?.Count > 0 && selected < source?.Count ? source.ToList () [selected] : null;

Hmn so the change you are proposing would not solve the underlying issue of the int selected being outside the bounds of the underlying list.
https://github.com/migueldeicaza/gui.cs/blob/26cb2007372670aaf6b0acf97985893c694f44f7/Terminal.Gui/Views/ListView.cs#L635-L640
The code in MovePageDown already has a conditional n > source.Count to prevent the index going outside of bounds.
https://github.com/migueldeicaza/gui.cs/blob/26cb2007372670aaf6b0acf97985893c694f44f7/Terminal.Gui/Views/ListView.cs#L468-L481
Are you using a custom IListDataSource or making changes to the list content in real time that might result in the bounds changing during scrolling?
Are you able to create a minimal reproduction of this issue? The UICatalog.exe Scenario ListView & ComboBox has a large list in it and I cannot replicate the behaviour you are seeing.

Simplified test case that raises the issue for me:
var list = new ListView() {
	Y = 10,
	X = 0,
	Height = Dim.Sized(10),
	Width = Dim.Fill(),
};
var items = new List<string>(new string[] {
	"AED: United Arab Emirates dirham",
	"AFN: Afghan afghani",
	"ALL: Albanian lek",
	"AMD: Armenian dram",
	"ANG: Netherlands Antillean guilder",
	"AOA: Angolan kwanza",
	"ARS: Argentine peso",
	"AUD: Australian dollar",
	"AWG: Aruban florin",
	"AZN: Azerbaijani manat",
	"BAM: Bosnia and Herzegovina convertible mark",
	"BBD: Barbados dollar",
	"BDT: Bangladeshi taka",
	"BGN: Bulgarian lev",
	"BHD: Bahraini dinar",
	"BMD: Bermudian dollar",
	"BND: Brunei dollar",
	"BOB: Boliviano",
	"BOV: Bolivian Mvdol",
	"BRL: Brazilian real",
	"BSD: Bahamian dollar",
	"BTN: Bhutanese ngultrum",
	"BWP: Botswana pula",
	"BYN: Belarusian ruble",
	"BZD: Belize dollar",
	"CAD: Canadian dollar",
	"CDF: Congolese franc",
	"CHE: WIR Euro",
	"CHF: Swiss franc",
	"CHW: WIR Franc",
	"CLF: Unidad de Fomento",
	"CNY: Renminbi",
	"COP: Colombian peso",
	"COU: Unidad de Valor Real",
	"CRC: Costa Rican colon",
	"CUC: Cuban convertible peso",
	"CUP: Cuban peso",
	"CZK: Czech koruna",
	"DKK: Danish krone",
	"DOP: Dominican peso",
	"DZD: Algerian dinar",
	"EGP: Egyptian pound",
	"ERN: Eritrean nakfa",
	"ETB: Ethiopian birr",
	"EUR: Euro",
	"FJD: Fiji dollar",
	"FKP: Falkland Islands pound",
	"GBP: Pound sterling",
	"GEL: Georgian lari",
	"GHS: Ghanaian cedi",
	"GIP: Gibraltar pound",
	"GMD: Gambian dalasi",
	"GTQ: Guatemalan quetzal",
	"GYD: Guyanese dollar",
	"HKD: Hong Kong dollar",
	"HNL: Honduran lempira",
	"HRK: Croatian kuna",
	"HTG: Haitian gourde",
	"HUF: Hungarian forint",
	"IDR: Indonesian rupiah",
	"ILS: Israeli new shekel",
	"INR: Indian rupee",
	"IQD: Iraqi dinar",
	"IRR: Iranian rial",
	"ISK: Icelandic krona",
	"JMD: Jamaican dollar",
	"JOD: Jordanian dinar",
	"KES: Kenyan shilling",
	"KGS: Kyrgyzstani som",
	"KHR: Cambodian riel",
	"KPW: North Korean won",
	"KWD: Kuwaiti dinar",
	"KYD: Cayman Islands dollar",
	"KZT: Kazakhstani tenge",
	"LAK: Lao kip",
	"LBP: Lebanese pound",
	"LKR: Sri Lankan rupee",
	"LRD: Liberian dollar",
	"LSL: Lesotho loti",
	"LYD: Libyan dinar",
	"MAD: Moroccan dirham",
	"MDL: Moldovan leu",
	"MGA: Malagasy ariary",
	"MKD: Macedonian denar",
	"MMK: Myanmar kyat",
	"MNT: Mongolian tögrög",
	"MOP: Macanese pataca",
	"MRU: Mauritanian ouguiya",
	"MUR: Mauritian rupee",
	"MVR: Maldivian rufiyaa",
	"MWK: Malawian kwacha",
	"MXN: Mexican peso",
	"MXV: Mexican Unidad de Inversion",
	"MYR: Malaysian ringgit",
	"MZN: Mozambican metical",
	"NAD: Namibian dollar",
	"NGN: Nigerian naira",
	"NIO: Nicaraguan cordoba",
	"NOK: Norwegian krone",
	"NPR: Nepalese rupee",
	"NZD: New Zealand dollar",
	"OMR: Omani rial",
	"PAB: Panamanian balboa",
	"PEN: Peruvian sol",
	"PGK: Papua New Guinean kina",
	"PHP: Philippine peso",
	"PKR: Pakistani rupee",
	"PLN: Polish zloty",
	"QAR: Qatari riyal",
	"RON: Romanian leu",
	"RSD: Serbian dinar",
	"RUB: Russian ruble",
	"SAR: Saudi riyal",
	"SBD: Solomon Islands dollar",
	"SCR: Seychelles rupee",
	"SDG: Sudanese pound",
	"SEK: Swedish krona",
	"SGD: Singapore dollar",
	"SHP: Saint Helena pound",
	"SLL: Sierra Leonean leone",
	"SOS: Somali shilling",
	"SRD: Surinamese dollar",
	"SSP: South Sudanese pound",
	"STN: Sao Tome and Principe dobra",
	"SVC: Salvadoran colon",
	"SYP: Syrian pound",
	"SZL: Swazi lilangeni",
	"THB: Thai baht",
	"TJS: Tajikistani somoni",
	"TMT: Turkmenistan manat",
	"TND: Tunisian dinar",
	"TOP: Tongan pa'anga",
	"TRY: Turkish lira",
	"TTD: Trinidad and Tobago dollar",
	"TWD: New Taiwan dollar",
	"TZS: Tanzanian shilling",
	"UAH: Ukrainian hryvnia",
	"UGX: Ugandan shilling",
	"USD: United States dollar",
	"USN: United States dollar (next day) ",
	"UYU: Uruguayan peso",
	"UYW: Unidad previsional",
	"UZS: Uzbekistan som",
	"VES: Venezuelan bolívar soberano",
	"WST: Samoan tala",
	"XCD: East Caribbean dollar",
	"YER: Yemeni rial",
	"ZAR: South African rand",
	"ZMW: Zambian kwacha",
	"ZWL: Zimbabwean dollar",
});
list.SetSource(items);
Application.Top.Add(list);
Application.Run();

Ah I see the issue, it is when the number of items is a multiple of the frame height
Fix is to change MovePageDown from:
if (n > source.Count)
     n = source.Count - 1;

To:
if (n >= source.Count)
     n = source.Count - 1;

Edit: ah looks like you already got there @BDisp :)

Yes :-) It only happen if it's a multiple of the frame height (selected + Frame.Height == source.Count). Do you think I should change for what you suggested?


[MAINTENANCE] issue-28: Support latest(3.12) version of Python

Description
Currently, ingen is failing to run on latest python 3.12.
Changes Made
Updated dependencies.
Updated docs.
Definition of Done
Before submitting this pull request, please ensure that the following criteria have been met:

[x] All automated tests have passed successfully.
[x] All manual tests have passed successfully.
[x] Code has been reviewed by at least one other team member.
[x] Code has been properly documented and commented as needed.
[x] All new and existing code adheres to our project's coding standards.
[x] All dependencies have been added or removed from the project's README or other documentation as needed.
[x] Any relevant documentation or help files have been updated to reflect the changes made in this pull request.
[x] Any necessary database migrations have been run.
[x] Any relevant UI changes have been reviewed and approved by the UI/UX team.

Thanks for contributing @ChillarAnand . Can you also update the language in the classifiers section of setup.py in the same PR? https://github.com/blackrock/ingen/blob/b7929e1e59125246aa3b668fd7a95fd1da17817d/setup.py#L30

Thanks for contributing @ChillarAnand . Can you also update the language in the classifiers section of setup.py in the same PR?
https://github.com/blackrock/ingen/blob/b7929e1e59125246aa3b668fd7a95fd1da17817d/setup.py#L30

Updated it. Thanks, @shpiyu


see trello card

hi @PhilipTB @ldodds is this one ok to merge?
And could you confirm which trello card so we can update the pull request title too please :)

I've updated the title and merged. The issue is due to missing data at 23:30 in some data feeds. This needs investigation in the application and data feeds to decide where and how best to resolve it. This test script just highlights that issue.


Relationship not working after latest update 1.1.8

Hi,
Have just updated from 1.1.7 to 1.1.8 and i am having now issues on all the model views in the admin.
Any model like user or the custom one i made give the following error:
json_decode() expects parameter 1 to be string, object given (View: /resources/views/vendor/voyager/bread/browse.blade.php)
the error line is below, apparently $row->details should be a string but an object get passed:
<?php                                     $options = json_decode($row->details);                                     $display_options = isset($options->display) ? $options->display : NULL;                                 ?>
I have tried to save again the bread associated to one table, and the error disappear in admin for that, but all the relationship in that table doesnt work anymore and gives empty result. I can only browser it as once i try to add or edit i get the error above again.

I noticed that this may be a duplicate of #3653

Looks like you override that view.
You need to update the view to match our current version:
https://github.com/the-control-group/voyager/blob/1.1/resources/views/bread/browse.blade.php

No it happens anyway also if i revert to the original blade.
I have just tried to install the previous version 1.1.7 and everything works again as expected except the BREADS that gives error while trying to edit:
Trying to get property 'details' of non-object (View: /vendor/tcg/voyager/resources/views/tools/bread/edit-add.blade.php)
Error is referred to this part of the code:
<textarea id="json-input-<?php echo e(json_encode($data['field'])); ?>" class="resizable-editor" data-editor="json" name="field_details_<?php echo e($data['field']); ?>"><?php echo e(json_encode($dataRow->details)); ?></textarea>

Yep, this one is now related to #3653 and will be fixed ASAP.

Ok so to exclude any issue related to my blades i have disabled all of them.
I dont see anymore that error on my views but i do see it on User view for example.
See screenshot attached
On top, on my models i cant see anymore relationships, in browse page are empty, same for new or edit.

Is this still part of #3653 ?
Thanks

This is a problem with pvtl/voyager-frontend
I filed an issue https://github.com/pvtl/voyager-frontend/issues/35

Thanks,
I am trying to revert to 1.1.7 then as i am in production here, everything seems to work except for the bread editor, if i try to edit a bread gives the following error.
Any way i can solve that? Is due to update to 1.1.8 then downgrade to 1.1.7?
Should i just wait for 1.1.9 and new laravel frontend and dont use the breads meanwhile?

Which error?
The second (Trying to get property 'details' of non-object) is fixed in 1.1.9 which is live.
But you have to wait for voyager-frontend to update.
Stick with 1.1.7 for now.

Sorry, forgot to attach the screenshot.
This error happens in 1.1.7 after i reverted back:

I noticed this error happens only while i try to edit breads that have a relationship set.

@emptynick i have fixed the above replacing 1.1.7 blade files , that one and another. Just not sure why that happened, if i reverted with composer back to 1.1.7 shouldnt have changed that files as well?

I'm honestly not sure how to properly downgrade.
When you have the correct version-constraint in your composer.json just rename the voyager folder vendor/tcg/voyager and run composer update

i have also face some problem

plse give the solution

@rajanish93 Thats unrelated to this issue.
Also it looks like you override the user/edit-add view with the generic bread/edit-add view.
We changed that view and you have to apply those changes as well.
As a side note: never change something in the vendor folder. Those files will just be overriden when the file was changed here.


use-cases: add "Ways to organize global storage"

E.g. first and second are different git projects, that share the same dvc remote
# first
dvc add data
dvc push

# second
cp path/to/first/data.dvc .
dvc pull

Also, as a submodule:
# project1
dvc add model.pkl
dvc remote add mygs gs://bucket/prefix -d
dvc push model.pkl.dvc
git add model.pkl.dvc .gitignore .dvc/config
git commit -s "add model"
git push

#project2
git submodule add https://github.com/user/project1 # note that it doesn't have to be github
cd project1
dvc pull model.pkl.dvc
cd ..
# Now you can access your model.pkl at ./project1/model.pkl

It seems that dvc import has made obsolete this way of data sharing between projects.
I am closing this issue. Please feel free to reopen in case I have missed something.

Not the first example, which doesn't require a Git repo. The question is where to include this example in the docs...

Maybe as an Example: Simulating import without Git  in the dvc import cmd ref?

It seems this is indeed obsolete now, since we have dvc get even for non DVC and non Git projects.

If I'm wrong please add it as a checkbox in this epic: #820


Refactor async_set_up_integrations to improve code readability

Breaking change
Proposed change
SonarCloud flagged this method as having a very high cognitive complexity and since it is located in one of the core files of the system we decided that it was important to improve it. The method is very long and it has both complicated logic and duplications. This PR will improve the issue by extracting the setup stage functionality to its own function, reducing both the LOC of the method and the number of duplications.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Tests were run by following the documentation and executing : Tasks: Run Task -> Pytest
Source: https://developers.home-assistant.io/docs/development_environment/


Add softlayer HQ_PRIVATE_KEY

http://manage.dimagi.com/default.asp?234436#1198429
@gcapalbo should we wait for @ctsims on this one?
cc @czue

(probably fine to wait for confirmation in the ticket)


Modern Page fails to load caused by invalid coordinate.

Modern Page will fail to load if an invalid coordinate is sent by a device. Legacy page is tolerant to the fault and will still load.
Modern Page Error Below caused by a device sending
Latitude | 1144.018740°
Longitude | -255.971002°
Error: Invalid LngLat latitude value: must be between -90 and 90
    at new Hc (lng_lat.ts:42:19)
    at Hc.convert (lng_lat.ts:140:20)
    at Uc.extend (lng_lat_bounds.ts:89:47)
    at MapDefaultCamera.js:30:70
    at Array.reduce (<anonymous>)
    at MapDefaultCamera.js:30:38
    at zl (react-dom.production.min.js:262:359)
    at t.unstable_runWithPriority (scheduler.production.min.js:18:343)
    at Zn (react-dom.production.min.js:122:325)
    at Rl (react-dom.production.min.js:261:308)

Can we make modern version tolerant to this type or error or a method to filter this type of msg.
Attached offending msg in the log. Observation usually Atrack devices ID is their imei this device id is longer than usual.
Atrack_720857707413766144.txt

Update . Legacy can also fail to load.

Implemented a fix here https://github.com/traccar/traccar/commit/35070c85e26fe75e73315506b8cae3360f79d12e.


"unknown (use) is currently not supported" when PublicKeyUse is not part of JWK

According to the JWK Spec https://tools.ietf.org/html/rfc7517#section-4.2, PublicKeyUse is optional, but currently spring-security-oauth2 code throws exception when PublicKeyUse is not specified in the JWK

I am running into this issue as well. @senkum have you found a workaround until this get's fixed?

Closing based on comment


Is there any way this can used in a simple React app?

You can, though this version requires jQuery as a (rather unnecessary) global dependency.
You should be able to run midnight on componentDidMount using a ref for the nav object without any significant issues, as long as the navigation doesn't have any complex behavior.

Sorry to reopen this issue but is there anyway to use this with React the "react" way, without jQuery ?
I figured out how to make it work on React but I don't like jQuery.
Here's the code:
import React, {useRef, useEffect} from "react";
// some styling
import "./styles.sass";
// without jQuery it dosen't work
window.jQuery = require("jquery")
const midnight = require("midnight.js")

export default function App() {
  const ref = useRef(null);

  useEffect(() => {
    // Not working with ref
    // ref.current.midnight()
    jQuery("#js-title").midnight()
  }, [])

  return (

Fixed title

  );
}

I checked the source code, I think it's developed specifically for jQuery. Is there a known alternative for React ?

There's no alternative that I know of, but in the codebase jQuery is mostly being used for querying the DOM, so you should be able to strip it out of the codebase by replacing $() with document.querySelector() and making a few tweaks here and there.
I'd be happy to accept a PR that makes Midnight work without jQuery.


Fixing NPE when Extractor.getSchema returns null

Also made some formatting changes to the State class.
@liyinan926 could you review this?

Updated

LGTM.


Make startup tier slightly bigger

What this PR does / why we need it
As requested by Bussiness school, we are doing startup tier slightly bigger in size.
Related Issues/PR

Replaces #55
Some questions

[x] I have read the contributing guidelines
[x] I abide by this repository Code of Conduct


add --cxxstl= flag to configure clang/llvm c++ stl library

introduce --cxxstl flag (named after ndk_cxxstl to retain consistency) to choose which stl library to use for clang
msstl is a no-op and is only here to differentiate package builded with libc++ / libstdc++ and microsoft stl

We shouldn't add it as an option because there are already too many options and it's only used for clang/llvm, but cxxstl is a generic name.
At least ndk_cxxstl has a prefix that identifies it as only being used in the ndk toolchain.
Also, --cxxstl= and get_config are only valid for global platform toolchains, and there is no way to individually control the toolchain for each target binding(target1 using llvm, target2 using gcc). It has significant limitations.
I would recommend policy to configure it, which not only converges the command line options, but also supports targets at the same time.
for example:
set_policy("build.c++.libcxx", "libc++")
set_policy("build.c++.libcxx", "libstdc++")

we can also only set it for clang/gcc
set_policy("build.c++.clang.libcxx", "libc++")
set_policy("build.c++.gcc.libcxx", "libstdc++")

or
$ xmake f --policies=build.c++.clang.libcxx:libc++

Also, if you plan to add new interfaces and options, you should open an issue first , and we need to discuss how to design the new interface. Instead of opening a pr directly, this can effectively avoid some unnecessary work and improve development efficiency.

It's also possible to change the standard library with GCC.
whether it's a config or a policy, this setting should be passed as a config key (like asan/toolchain/etc.) because C++ libraries using different libcxx are not compatible.
I also feel that if someone decides to use libc++ on Linux, package fetching from system should be disabled (as on Linux, all packages will use libstdc++)

It's also possible to change the standard library with GCC.
whether it's a config or a policy, this setting should be passed as a config key (like asan/toolchain/etc.) because C++ libraries using different libcxx are not compatible.
I also feel that if someone decides to use libc++ on Linux, package fetching from system should be disabled (as on Linux, all packages will use libstdc++)

However, the default libcxx used by gcc and clang may be different, e.g. gcc uses libstdc++ by default and clang uses libc++ by default.
Users may also need to choose different libcxx for different compilers.
If we use the -cxxstl= global option, we can't configure it flexibly.
There are also some compilers that may not support libc++.
Therefore, it is better to use set_policy("build.c++.clang.libcxx", "libc++") to configure libcxx for a specific compiler.
Furthermore, policies can be passed to packages, which can be configured globally for targets and packages, or individually for a target.

However, the default libcxx used by gcc and clang may be different, e.g. gcc uses libstdc++ by default and clang uses libc++ by default.

Clang uses libstdc++ by default on Linux for compatibility.
Making it a per-compiler policy seems not very accessible to me. A set_cxxstl("libc++") target-config seems more interesting (with maybe the same support as flags: set_cxxstl("clang:libc++") and set_cxxstl("gcc:libstdc++")?) as an API.
It's a somewhat popular configuration for devs using Clang to set libc++ as their standard library.


Field of type ExtensionType? cannot be assigned null during const evaluation

dartpad
extension type Id(int id) {}

class MaybeId {
  final Id? value;
  const MaybeId.none() : value = null;
}

const MaybeId no = MaybeId.none(); // line 8

On the latest master with --enable-experiment=inline-class, this code gives the following error:
line 8 • Evaluation of this constant expression throws an exception.
The exception is 'In a const constructor, a value of type 'Null' can't be assigned to the field 'value', which has type 'Id?'.' and occurs here.

It will, however, run successfully (at least in the javascript runtime).

That's right, Null is assignable to T? for any type T, including extension types.

/cc @kallentu

cc @scheglov
I think this has to do with type erasure with the constant evaluator.

Concrete example code that fails with this. (Written independently, not to hit this issue, abbreviated.)
typedef Opt<T> = Some<T>?;
extension type const Some<T>._(({T value}) _) {
  const Some(T value) : this._((value: value));
  T get value => _.value;
}
const Opt<Never> none = null;
void main() {
  var rnd = DateTime.now().millisecondsSinceEpoch.isEven;
  var maybeValue = rnd ? none : Some(42);
  print(switch (maybeValue) {
    Some(: var value) => "Value: $value",
    none => "No value",
  });
}

Gives error on the none = null; initialization
(And, in current DartPad, a warning that a Some<int> pattern can't match a Some<int>? value.)

https://dart-review.googlesource.com/c/sdk/+/343580


Fix HmIP-STHD and HmIP-STH

This PR fixes the issue decribed in #338. The implementation of HmIP-STHD and HmIP-STH is switched over to the one used by HmIP-WTH-2. I do not have HmIP-STH devices to test, but I see no reason why those should work differently than the ones with a display.
I gathered information from HmIP-WTH-2 and HmIP-STHD via get_device_data.py and compared them with Meld. They only differ in two configuration parameters: the WTH-2 also exposes a setting to lock the rotary encoder and one to set the display backlight timeout after using the rotary encoder. These are not available on the STHD as it is missing the rotary encoder (they use the same PCB, the encoder is just not populated).
I tested this with my STHD devices and they now behave like WTH-2 devices in Home Assistant.
Further, I removed the old implementation as it is not used anymore and somewhat broken anyway.
It would be nice if someone with STH devices could confirm that this also works for them.

I gathered information from HmIP-WTH-2 and HmIP-STHD via get_device_data.py and compared them with Meld. They only differ in two configuration parameters: the WTH-2 also exposes a setting to lock the rotary encoder and one to set the display backlight timeout after using the rotary encoder. These are not available on the STHD as it is missing the rotary encoder (they use the same PCB, the encoder is just not populated).

Could you please post the generated files via gist?
Apart from that I think the change is ok. Thanks! 👍

Here are the files:
https://gist.github.com/yschroeder/461e430d6e6a59b8c4167d12f45ac253

Ok, I can confirm and I don't think it will cause problems. Thanks for you contribution.


feat(cli): try to get author info from git config

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Also, the commit message should be feat(core): use git config to determine author before username (note that it's core instead of cli).

@malept , Thanks for the suggestion. Issues resolved and pushed.
The only thing I'm not sure is whether to use name <email> or object pattern. Seems npm init and yarn init both use name <email>. Could you confirm it again?

I did some refactors on the code, but I think the last thing it needs are some tests.

@MarshallOfSound could you take a look at this before it gets merged? The tests could probably be written better.


Question: how to debug hang in node-fetch? (likely environmental issue)

On my Windows 10 dev box, Node 12.17.0, I'm seeing the following code hang:
let result = await fetch("https://sadchonks.com/kitteh-512.png"); // success, 200
let buffer = await result.buffer(); // This hangs, never finishes. No errors, no result. Just hang.

I'm trying to figure out why this hangs. Stepping into the debugger, I reach into consumeBody function, but neither body.on('error', ...) nor body.on('data', ...) never fires:

I've also tried de-asyncing my code by using .then(...) chains without async. Still no dice; it hangs on the same call to .buffer().
Any suggestions for debugging this hang?

@JudahGabriel I am unable to reproduce the issue.

Could you provide us with your NodeJS and node-fetch version?

Yep, suspect it's an environment issue. Just hoping for some way to debug/fix it. :-)
Node 12.17.0
node-fetch 2.6.0

Definitely is an environment-specific issue; I tried on my laptop and it works fine. Same code on my desktop hangs.
Maybe a node reinstall is in order. Closing this.

able to reproduce by fetching images in loop, buffer is hitting maximum size and just hanging.

It still happens and happen accidently. It's so hard to reproduce and try catch is not work to handle this.
t's bugged in long run system and became unpredicted. anybody have solution?


Running donut only brings up help menu

Hey there. I'm running Kali Linux
Linux kali 6.3.0-kali1-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.3.7-1kali1 (2023-06-29) x86_64 GNU/Linux
Not sure what info is preferred, but I'm finding that whenever I run ./donut under any circumstances it just shows the help menu.
Ran this and nothing
./donut -a 1 -f Test.exe -c Test.Program -m Main
Just the help menu. I've rm -rf'ed the folder and redownloaded. Typed "make" again to reinstall but nothing.

 The -f flag is for the shellcode format, not the input file.

Try sudo ./donut -f 6 -i sh.exe. I think they changed the way you provide the input file in 1.0.0. However, the help menu hasn't been adjusted yet.

Try sudo ./donut -f 6 -i sh.exe. I think they changed the way you provide the input file in 1.0.0. However, the help menu hasn't been adjusted yet.

this was it, thank you friend!


switching display_name and description

Goal
Mathijs noticed  the display_name field in the slate config json file was being largely switched with the description field.  display_name should have text that can be displayed by clients to describe the slate, while the description is generally for internal consumption.  I tried to get these sorted out.
Implementation Decisions
reading a long JSON file.

Per slack, approved and @lfishhead will follow up with names from carolyn when she is back from PTO. https://pocket.slack.com/archives/C01CKCB9746/p1624486510046100?thread_ts=1624485875.045300&cid=C01CKCB9746


Need link to YAML documentation

This is really a quick start guide for YAML. There doesn't seem to be any link to the actual YAML documentation that people are going to need to do anything beyond the most simplistic hello world app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 483dcb1c-1a89-2b20-4cf2-abd3ae88d9ed
Version Independent ID: dc4722ed-5a4b-26ec-e7d5-a149bf6e79a7
Content: Building .NET Core projects with Azure Pipelines and TFS - Azure Pipelines & TFS
Content Source: docs/pipelines/languages/dotnet-core.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

I do see the reference material under References on the side bar now and it does list the available tasks so I guess this is the official replacement. We need a link to this within this topic though.

There is YAML schema under Reference on the left sidebar. This is the link: https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts

Yes but no place in the quickstart does it even mention the reference.  Hence people have to go find it themselves.

@CoolDadTx
I understand. Thank you for your suggestions! It makes sense.
Ok, I will try to submit PR to update this page to add link to YAML schema reference.


added user model

Added the user model. The resume2 link is set to be optional.
Closes #1

Updated the timezone and increased the max length for batch field.

Made all the requested changes.