cs double chart amended

Pull request overview
Give a general description of why a change is being made, include issue number(s) being fixed if relevant
Pull request checklist
Please check if your PR fulfils the following:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Tests have been run locally and are passing (run_tests_locally())
[ ] Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?
Please describe the current behaviour that you are modifying, or link to a relevant issue. Include screenshots for UI changes where possible.
What is the new behaviour?
Please describe the behaviour or changes that are being added by this PR. Include screenshots for UI changes where possible.
Anything else
Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

updated server to include new download_Combined_Science_data file for chart to work when selected on dropdown.

@tabdulla123 You need to run tidy_code() and run_tests_locally(), and commit and push those changes to get those checks/tests passing. Let me know if you wanna call for the run_tests_locally one!

@chfoster actioned


FYI Description gets populated with 'Brief description of what you observed' explained

This is happening when users use http://www.inaturalist.org/observations/upload on IE and leave the description blank, see conversation here: http://www.inaturalist.org/observations/1020933
Not labeling this as a bug since http://www.inaturalist.org/observations/upload doesn't support iE - but thought I'd record it as a FYI - please remove if this is not the place to note this

issue remains, but prob not worth dealing with - IE :(


remove breeze-natives

netlib speeds up breeze for big md and mm operations only.

@danielkorzekwa time for an other release?

If you can't live without it I will do it.

well, not that I would die without it, just would be nice to have a bit more frequent releases.

I should create it within a month or so, first planning to update docs and make some refactoring changes to factor graph impl.

ok, great


Historical PDF layout: 1979 to 1986 layout

During this period ISO used a "prettier" layout that has a wide header.
These are PDF samples from iTeh that provide a good demonstration of the layout.
ISO-7716-1985.pdf
ISO-5580-1985.pdf
ISO-1765-1986.pdf
Additional samples:
ISO-6600-1980.pdf
ISO-4219-1979.pdf
ISO-18-1981.pdf

Here's a full document found on the Internet so we can see how the pages end.
https://www.tianxing.com.cn/uploadfile/202101/1da640b93e.pdf

ISO XSLT updated for the layout.
To enable layout add the document attribute:
:document-scheme: 1972.

Oh wow I realized that the fonts used in this layout were different in different years.
The layout change occurred in 1972 to 1978 vs 1979 to 1986. So maybe we should add one "1979" layout.
1972 to 1978 cover heading

1979 to 1986 cover heading

Cover title
1972 to 1978

(The closest free font I found was Boricua Regular.)
Proper font Univers:

The bottom tiny text in English/French doesn't change, it is Univers Pro 55 Roman. At one point the Russian/Cyrillic font changes from serif to sans-serif, but we don't care right now.

1979 to 1986

Font is also Univers:

Title text
ISO 4605-1978
I really can't figure out what the English text is...
The French is unmistakably Univers.

Notice the condensed form of "e" and "ss" (glass, mass). I can't find it in any Univers style...
Still, Univers 65 Bold and Zurich Bold are the closest. The "W" is too wide, and the "ss" and "e" are too wide...

ISO 4219-1979

I think it's closest to Univers Pro 65 Bold but preferably a bit less weight...

Body text
1972 to 1978
The body text is exactly the style of the title text... And I can't figure out what it is.

1978 to 1986

Probably the Univers 55 Roman style.

To enable layout add the document attribute:
:document-scheme: 1979.

ISO XSLT updated to using the font Univers as main font for layout version 1979.
(for testing purposes I used the fonts from https://font.download/font/univers
https://fontsgeek.com/fonts/univers-italic).
We can't add the Univers into metanorma-iso like this:
      def fonts_manifest
        {
          "Cambria" => nil,
          "Cambria Math" => nil,
          "Times New Roman" => nil,
          "Source Han Sans" => nil,
          "Source Han Sans Normal" => nil,
          "Courier New" => nil,
          "Inter" => nil,
          "Univers" => nil,
        }
      end

because the Univers font isn't free and not supported by fontist:
[fontist] 'Univers' font is not supported. Please report this issue at github.com/metanorma/metanorma/issues to report this issue.

So, the end-user is responsible for the purchase and font installation.
The fontist should find the installed font and pass it into the PDF generation via manifest file into mn2pdf. Therefore, we have to set the document attribute for each document with layout 1979:
:fonts: Univers

(https://www.metanorma.org/author/ref/document-attributes/#visual-appearance)
I'll add this info into blog post about ISO historical layouts.


Suggested fixes by iCR, OpenRefactory, Inc.

OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on your code. We are reporting a few sample fixes that were generated.
The goal of the this fix is to resolve  Zero Division Check, Unexpected Control Flow and Weak Library Usage problem.
Zero Division Check Fixes:
In file: Duration.java, class: Duration, method: append , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: CommitLog.java, class: CommitLog, method: getActiveSegmentCompressionRatios ,  there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: SizeTieredCompactionStrategy.java, class: SizeTieredCompactionStrategy, method: getEstimatedCompactionsByTasks , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: Upgrader.java, class: Upgrader, method: Upgrader,  there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: MajorLeveledCompactionWriter.java, class: MajorLeveledCompactionWriter, method: MajorLeveledCompactionWriter, there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: MaxSSTableSizeWriter.java, class: MaxSSTableSizeWriter, method: MaxSSTableSizeWriter , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
In file: StorageProxy.java, class: StorageProxy, method: estimateResultsPerRange , there is a potential Division By Zero error while running. iCR suggested changes in 1 files to resolve the problem.
The fix addresses CWE 369
Unexpected Control Flow Fixes:
In file: AbstractTypeVersionComparator.java, class: AbstractTypeVersionComparator, method: compareCompositeTypes  has a semicolon at an unusual place . iCR suggested changes in 1 files to resolve the problem.
Weak Library Usage Fixes:
In file: UUIDGen.java, class: UUIDGen, method:hash uses Random object but it may not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1 files to resolve the problem.

Please file a JIRA ticket in Apache JIRA if you want to make this happen first. Thank you.


Figure out how to model topics for agencies

To enable filtering of what kind of agency it is like we need in #18 we need a way to model it in Wikidata. There are a number of possible solutions.

Use P101 (field of work) (like this)
Use P921 (main subject)
Create a new property based on the UN Classification of the Functions of Government

The last option is probably the best one, and the first one feels like the second best choice.

A fourth option might be to map UN classification to various P101 targets.

For many it might be doable, but I guess there is nothing to map 04.7 - Other industries towards and there are a few others that would be hard to find something for. I' rather create these 69 items to use on a new property, and they in turn could have P921 main subject if we can find suitable items to map them to.

Yeah makes sense!

Made #29 as a possible solution. If the property proposal fails, this issue needs to be reopened.


remove update when persist_handle

@MrCreosote can you take a look?

@MrCreosote Do you mind taking another look?

LGTM


Add Ashish to Contributors list

@ashish061291, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Create a Contributing.md

The repository need a contributing.md markdown file which will help the contributors to understand the contribution process better and will help people who are new to the open source understand the code base and contribution steps better.

Hey @Pin4sf Sorry, actually I was super busy for some 4-5 days.
Thanks for pointing out the thing.
I will add the contributing guidelines.

Okay