Add Array.last()

Currently, to get the last element of an array we have to write array[array.size()-1], which is a bit tedious given how many times this case happens.
Could we have an array.last() method like STL does with back()?

Hey, I'm able to do that, it's really simple.
But I have a doubt about the array files at /godot/core/array.h \ cpp;
Just by changing the files and modifying the /doc/base/classes.xml to match, the new "version" of my array will work?
--
I saw this is different from Custom modules that we 'bind' the methods, that's the why of my doubt.

@felaugmar no it won't be exposed to gdscript automatically, you still have to bind it.
The binding for array methods happens in core/variant_call.cpp specifically here and there.

Just for record, it should return null on an empty array right?
And while we are at it, please let's also consider a array.first() function.

@Hinsbart, thx, I'll see if I can figure out how the binding works (it seems a little complex) and if I can understand, I'll contribute with both functions.
@Zylann array.last()
@supaiku-o array.first()

Note that we support array[-1] syntax just fine, so this might be useless nowdays.

@bojidar-bg oh! Brilliant, I didn't know that :)

Actually, I wonder if it's really coherent with the C++ side. I don't see access by negative index in Array and Vector, only error.

Well, I did the functions, it's working, but faulty and is not so simple as I thought.
I can't figure out how to bind with the Variant returning value directly and how to break in editor in case of _p->array.size() == 0.
--
Well, temporarily, I give up of editing the core, it's missing some knowledge for me to do this.
😢

@felaugmar usually I think error checking is done with something like
ERR_FAIL_COND(size() == 0, "The array is empty");

Should this be closed, or you prefer it staying open?

I don't mind if nobody else wants this, I use [-1] now in GDScript. I would eventually like to have it in C++ because I saw it's not there, but I don't really need it now.

Retagging for core then...

I would like to try implementing this. From what I gather from @felaugmar's attempt, I have to:

Implement methods Array::front and Array::back in core/array.{h,cpp}
Raise an error if the array is empty
Update the bindings in core/variant_call.cpp
Update the documentation in doc/base/classes.xml
Write tests?

Is that correct?

@Kazuo256 yes :)

Alright. I'll probably come back to ask some things when I get to the tests.

I just noticed I actually wrote front/back, but the original proposal was first/last. Is there a preferred one? Or should make aliases?
Besides this point, I've finished steps 1 through 4. Time for tests. Is there a guide or quick reference I can follow for this?

Godot has no automated tests.

OK. Then I only need to know which name to use.

When I first wrote the issue I was not really bothering about the names, as long as they are meaningful. Front and back sound fine, it's like STL :)

Solved by #7149.

This method gives the last value
listPoint [listPoint.size () - 1]
But I cannot use it in conditional sentences
If there are repeating items in the list
Is there another solution?

Either repeat it or use a temporary var
var last = listPoint[listPoint.size() - 1]
if last and last or last:
    # ...


Map appears blank (white screen) when using with Tailwindcss

I found out that Tailwind Preflight css applies styles mentioned below to img and video
img,
video {
  max-width: 100%;
  height: auto;
}

I am not quite sure why this affects map but in order to make it work I just override tailwind's Preflight max-width: 100% to initial and it works.
.smap {
  img {
    max-width: initial!important;
  }
}

Maybe someone who faced same problem will clarify this for me 😄

Hey,
thank you for your comment, i'll try to investigate if it's possible to apply some css resets to prevent this.

@danforejtek I've released version 1.1.2 with your css reset applied. Let me know if that problem occurs even in the new version.


Remove '\r' in commit message when constructing build description

Signed-off-by: Gong Su<EMAIL_ADDRESS>

Jenkins Linux ppc64le Build #2857 [push] Remove
in commit mess... started at 01:28

Jenkins Linux s390x Build #3741 [push] Remove
in commit mess... started at 01:21

Jenkins Linux amd64 Build #3750 [push] Remove
in commit mess... started at 00:21

Jenkins Linux s390x Build #3741 [push] Remove
in commit mess... passed after 44 min

Jenkins Linux ppc64le Build #2857 [push] Remove
in commit mess... passed after 53 min

Jenkins Linux amd64 Build #3750 [push] Remove
in commit mess... passed after 59 min


Debugger does not notify debug completion/exit to client

When the debugger is completed or exited, client should be notified about it. But currently the notification does not send from the server (both notifyComplete and notifyExit in the DebugSessionObserver class does not have any usage).

fixed with pull https://github.com/ballerinalang/ballerina/pull/2883


post and pressure plate behavior.  1.16.4

1.16.4 on the ATM6 1.3.0  pack
post behaviour with pressure plate is odd.  I am trying to get a double door to open as one with pressure plates. I have the wires and post under the blocks holding the doors.  It's like the RS signal is not releasing with the obsidian plates. With the vanilla stone plates, the signal doesn't travel to all doors.

Might not be your mod .. the same thing happens with other mods.


Switch over to the new debugger

Fixes #2063
@brettcannon @d3r3kk @MikhailArkhipov
Please review if possible, I'd like to get this out sooner than later.
This way the users of the insiders extension will have this and it'll get tested by them too (not just us).
This pull request:

[x] Has a title summarizes what is changing
[x] Includes a news entry file (remember to thank yourself!)
[x] Has unit tests & code coverage is not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
[x] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

run CI once again

What's the ETA on merging this? I'd like to see the updates in the dev build in order to complete the docs on it.

@kraigb it won't be in our next release so no time pressure ATM 😄

Ah, I had understood that it was going out for EuroPython, but if that's not the case then I'll hold off.


Use vanilla postgres - Prepare 0.5 release

Summary of the changes / Why this is an improvement

With https://github.com/apache/flink-connector-jdbc/pull/29/commits/6011f6d5a1bcb331ace195a41002a76a63ddbd99, we can use PostgreSQL vanilla JDBC driver!

Prepare for 0.5 release

Checklist

[x] CLA is signed

Closing it, apologies, the trick doesn't work 100% and still needs some core changes in the flink-jdbc-connector.


Use setdefault for the default logging level

Coverage remained the same at 81.949% when pulling 7fec886fb9a48647fc073d40fc8d9e5f04dd96f0 on tweak-logging into 4df19e4a271c88584ecd0b8888aeba570a8f234a on master.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


[question] README?

It seems like some apps' README file from the repo is displayed while it isn't for some. I also couldn't find a flag in the .yml file for this. Could someone explain what is happening here?

and it is not the right repo for this issue, the logs for the CI job is already having an answer:
2021-07-20T12:07:04.4056579Z ten-hands: Non 404 error
2021-07-20T12:07:04.4058966Z RequestError [HttpError]: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.
2021-07-20T12:07:04.4062503Z     at /home/runner/work/apps/apps/app/node_modules/@octokit/request/dist-node/index.js:68:23
2021-07-20T12:07:04.4064571Z     at runMicrotasks (<anonymous>)
2021-07-20T12:07:04.4066827Z     at processTicksAndRejections (internal/process/task_queues.js:95:5) {
2021-07-20T12:07:04.4068754Z   status: 403,
2021-07-20T12:07:04.4069764Z   headers: {
2021-07-20T12:07:04.4071758Z     'access-control-allow-origin': '*',
2021-07-20T12:07:04.4079131Z     'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
2021-07-20T12:07:04.4085531Z     connection: 'close',
2021-07-20T12:07:04.4087331Z     'content-encoding': 'gzip',
2021-07-20T12:07:04.4114529Z     'content-security-policy': "default-src 'none'; base-uri 'self'; block-all-mixed-content; connect-src 'self' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com cdn.optimizely.com logx.optimizely.com/v1/events translator.github.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; frame-src render.githubusercontent.com render-temp.githubusercontent.com viewscreen.githubusercontent.com; img-src 'self' data: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com collector.githubapp.com avatars.githubusercontent.com github-cloud.s3.amazonaws.com secured-user-images.githubusercontent.com/; manifest-src 'self'; media-src 'none'; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com",
2021-07-20T12:07:04.4139985Z     'content-type': 'application/json; charset=utf-8',
2021-07-20T12:07:04.4142226Z     date: 'Tue, 20 Jul 2021 12:07:02 GMT',
2021-07-20T12:07:04.4145045Z     'expect-ct': 'max-age=2592000, report-uri="https://api.github.com/_private/browser/errors"',
2021-07-20T12:07:04.4149219Z     'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
2021-07-20T12:07:04.4152274Z     'retry-after': '60',
2021-07-20T12:07:04.4153884Z     server: 'GitHub.com',
2021-07-20T12:07:04.4156592Z     'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
2021-07-20T12:07:04.4159348Z     'transfer-encoding': 'chunked',
2021-07-20T12:07:04.4161757Z     vary: 'Accept-Encoding, Accept, X-Requested-With',
2021-07-20T12:07:04.4164273Z     'x-content-type-options': 'nosniff',
2021-07-20T12:07:04.4166313Z     'x-frame-options': 'deny',
2021-07-20T12:07:04.4168482Z     'x-github-media-type': 'github.v3; format=json',
2021-07-20T12:07:04.4170976Z     'x-github-request-id': '0788:3EB2:53CB5E:D3A335:60F6BC66',
2021-07-20T12:07:04.4172997Z     'x-xss-protection': '0'
2021-07-20T12:07:04.4174126Z   },
2021-07-20T12:07:04.4175057Z   request: {
2021-07-20T12:07:04.4176630Z     method: 'GET',
2021-07-20T12:07:04.4179027Z     url: 'https://api.github.com/repos/saisandeepvaddi/ten-hands',
2021-07-20T12:07:04.4180926Z     headers: {
2021-07-20T12:07:04.4182822Z       accept: 'application/vnd.github.v3.html',
2021-07-20T12:07:04.4185670Z       'user-agent': 'octokit-rest.js/18.5.5 octokit-core.js/3.4.0 Node.js/14.17.3 (linux; x64)',
2021-07-20T12:07:04.4188302Z       authorization: 'token [REDACTED]'
2021-07-20T12:07:04.4189763Z     },
2021-07-20T12:07:04.4191115Z     request: { hook: [Function: bound bound register] }
2021-07-20T12:07:04.4192425Z   },
2021-07-20T12:07:04.4195990Z   documentation_url: 'https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits'
2021-07-20T12:07:04.4198904Z }

Is the readme loaded on the server? Why not load it on the client-side to prevent ratelimits?

you already answered for own questions, the website never loads any remote content (except youtube). These errors come from the processor to give your that static readme property.

Umm, I didn't understand what you mean :sweat_smile:


Micha-kun/issue77

Working on #77 -> AsyncOption basic operations

Awesome! Looks good so far.  Lemme know when you want more reviews.

I'm doing the basic operations :) At least the minimal useful things.

Seems like these are all of them: AsyncOption, TaskOption, JobOption.


Error with installing Java: wrong number of arguments

$ brew cask install java
Error: wrong number of arguments (1 for 0) while loading '/usr/local/Library/Taps/caskroom/homebrew-cask/Casks/java.rb'
Please report this bug:
    https://github.com/caskroom/homebrew-cask/issues
<main>:8:in `name'
<main>:8:in `<class:Java>'
<main>:in `<main>'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/source/path_base.rb:55:in `eval'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/source/path_base.rb:55:in `rescue in load'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/source/path_base.rb:52:in `load'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/source/tapped.rb:28:in `load'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask.rb:127:in `load'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli/install.rb:19:in `block in install_casks'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli/install.rb:17:in `each'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli/install.rb:17:in `install_casks'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli/install.rb:6:in `run'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli.rb:80:in `run_command'
/usr/local/Cellar/brew-cask/0.39.3/rubylib/cask/cli.rb:120:in `process'
/usr/local/bin/brew-cask.rb:42:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Library/brew.rb:58:in `require?'
/usr/local/Library/brew.rb:142:in `<main>'

You’re using an old version of homebrew-cask. Please brew update && brew upgrade brew-cask && brew cleanup && brew cask cleanup and try again.
Please always do this before opening new issues.

Actually I did update everything and tested multiple times before asking. I now noticed that doing brew upgrade brew-cask does not actually work for me. I use OS 10.9.5. and this is what I get:
Error: No available formula for brew-cask

Your version is very old, though, so the best way to fix it would likely be to uninstall, untap, and retap. brew update ; brew uninstall brew-cask ; brew untap caskroom/cask ; brew tap caskroom/cask ; brew install brew-cask.

Thanks. Now I still get an error with this cask. THe new error is:
brew cask install java
$HOME/.rvm/scripts/functions/rvmrc_project: line 283: rvm_saved_env: unbound variable
cannot resolve: '/usr/local/bin'

Let me know if I should open a new issue for this or not. Thanks!

That’s not a homebrew-cask error, that’s RVM. We don’t touch that; so it’s something on your ruby setup.

This happens on both of my machines. I have Ruby 2.1.0 from RVM. There's nothing unusual. It must be the interaction between RVM and brew cask since brew works fine for me and brew cask used to work. Do you have any suggestion of what this may be?

No, but since this is a new issue, yes, please open a new one, and be sure to post the output of brew doctor and brew cask doctor.


Fix duplicate variable initialization

b/37535740

This change is

No worries! I thought about that too, I think it's because by the end of the initialization's try block it's definitely initialized since it couldn't fail on that line. So whether or not it gets to that catch, it's still in scope? Don't know enough about JS much less its compiler, but seems feasible.


query_as! does not recognize Option<T> in some left join queries

Bug Description
If you run a query with a left join and a where condition outside the left join, sqlx yells at you during runtime (not compile time) with the following error:
error occurred while decoding column <col_number>: unexpected null; try decoding as an `Option`

even if you read the column into an Option<T>. However, if you put that condition inside the left join, it works fine.
Minimal Reproduction
Here's a contrived example with two tables, employee and department:
schema.sql:
create table department (
    id serial primary key,
    name text not null
);

create table employee (
    name text primary key,
    department_id integer references department
);

main.rs:
struct QueryResult {
    employee_name: String,
    department_name: Option<String>,
}

#[tokio::main]
async fn main() {
    let pool = sqlx::postgres::PgPool::connect("postgres://localhost/sqlx-mre")
        .await
        .unwrap();

    sqlx::query!("insert into employee (name) values ('ahmed')")
        .execute(&pool)
        .await
        .unwrap();

    // This works!
    let good_query_result = sqlx::query_as!(
        QueryResult,

        "
        select
            employee.name as employee_name,
            department.name as department_name
        from employee
        left join
            department
            on
                employee.department_id = department.id
                and employee.name = $1
        ",

        "ahmed"
    )
    .fetch_one(&pool)
    .await
    .unwrap();

    // This doesn't
    let bad_query_result = sqlx::query_as!(
        QueryResult,

        "select
            employee.name as employee_name,
            department.name as department_name
        from employee
        left join
            department
            on employee.department_id = department.id
        where employee.name = $1",

        "ahmed"
    )
    .fetch_one(&pool)
    .await
    .unwrap();
}
    /*
    thread 'main' panicked at src/main.rs:57:6:
    called `Result::unwrap()` on an `Err` value: ColumnDecode { index: "1", source: UnexpectedNullError }
    */

I believe this is a bug with sqlx because each query returns the expected (and same) result when run in a psql shell.
PS: I know issue https://github.com/launchbadge/sqlx/issues/3336 exists, but I don't think it's quite the same.
Info

SQLx version: 0.8.0
SQLx features enabled: ["postgres", "macros", "uuid", "runtime-tokio"]
Database server and version: Postgres 16.3
Operating system: macos Sonoma 14.5
rustc --version: 1.80

Work around is to add as "col_name!" to the problematic fields.

Work around is to add as "col_name!" to the problematic fields.

The thing is, that tells the compiler that the thing you're referencing is not null, which is not what you want on a left join. In the example I made, doing select employee.name as employee_name, department.name as "department_name!" implies that there will always be a department_name, which is not true in my case.

I'm also having the same issue and it's driving me nuts. For some reason having a where condition transforms all left-joined columns from Option<T> -> T. Is there a reason behind this behavior?


Windows 11 Context Menus

Issue Type: Feature Request
Add the "Open with Visual Studio Code" legacy context menu entry to the modern Windows 11 context menu in order to reduce clicks required to open something in VSC.
VS Code version: Code 1.61.2 (6cba118ac49a1b88332f312a8f67186f7f3c1643, 2021-10-19T14:57:20.575Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: Yes

#127365

/duplicate - thanks @yume-chan


Where i will add a chart type?

I want to add a chart type on this panel , where add in source code ?

What kind of chart type are you wanting to add? At the moment we have added all of the supported trace-types in plotly.js...

If you mean this kind of thing https://en.wikipedia.org/wiki/Sequence_diagram then you will have a very hard time, as it's not natively supported by plotly.js ... The architecture of this editor is designed to support plotly.js chart types.

NO, not is like this  https://en.wikipedia.org/wiki/Sequence_diagram.
It is like this , chart data is realtime changed and time .


chore: fix ipv6 nginx startup error

Fixes: 24013
The issue started with the introduction of adding of startup-events.
Because of the ipv6 header

server {
	listen 80 default_server;
        listen [::]:80 default_server;
}

present in the
/etc/nginx/sites-enabled/default and calling nginx
here.
With this change we are removing listen [::]:80 default_server;
from the file before starting nginx.

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

/ok-to-test


⚠ ClamAV has degraded performance

In f15389a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 36 ms

Resolved: ClamAV performance has improved in e27d00c.


其实我是个写后台的，好多warn，甚至还有提示ERR

我就是clone下来，然后npm install报一堆：
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
WARN tar ENOENT: no such file or directory, open '/Users/wakaryredou/GitHub/vue-element-admin/node_modules/.staging/codepage-0d6ff06b/cputils.js'
WARN tar ENOENT: no such file or directory, open '/Users/wakaryredou/GitHub/vue-element-admin/node_modules/.staging/core-js-026cdf7b/client/library.min.js.map'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm ERR! Unexpected end of JSON input while parsing near '..."html-minifier":"./cl'
WARN tar ENOENT: no such file or directory, open '/Users/wakaryredou/GitHub/vue-element-admin/node_modules/.staging/font-awesome-027182e6/fonts/fontawesome-webfont.woff'
WARN tarball tarball data for<EMAIL_ADDRESS>(sha1-VAMEJhwzDoDQ1e3OJTpoyzlkIYw=) seems to be corrupted. Trying one more time.
WARN tar ENOENT: no such file or directory, open '/Users/wakaryredou/GitHub/vue-element-admin/node_modules/.staging/xlsx-948e527c/dist/xlsx.core.min.map'
WARN tar ENOENT: no such file or directory, open '/Users/wakaryredou/GitHub/vue-element-admin/node_modules/.staging/element-ui-511e54e6/lib/dialog.js'
WARN tarball tarball data for<EMAIL_ADDRESS>(sha1-LUEe92uFabbQyEBo2r6FsKpeXBc=) seems to be corrupted. Trying one more time.
WARN tarball tarball data for<EMAIL_ADDRESS>(sha1-caVp0Yns9PTzISJP7LFm8HHdkPk=) seems to be corrupted. Trying one more time.
npm WARN deprecated<EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.

看起来你需要  npm install  或者 yarn

网络不好。挂一下淘宝代理可能会好。

应该是吧。
老报错：
npm ERR! Unexpected end of JSON input while parsing near '..."html-minifier":"./cl'
cache clean了一下：
npm cache clean --force
接着就install下来了。
感谢。


Hover Effect and Color Improvement for "Post Comment" Button in "Join the Conversation" Section

@ANSHIKA-26
Hello,
I was reviewing the "Join the Conversation" section and noticed that the "Post Comment" button’s hover effect could be improved. The current hover changes the button color to "light pink", which doesn’t contrast well with the "blue background", making it hard to read. Additionally, the hover effect lacks animation, and a subtle transition effect would enhance the user experience.
I would suggest changing the hover color to a more contrasting shade and adding a smooth animation. I’ve attached a screenshot below for reference.
I’d love to contribute by working on this improvement. Could you please assign this issue to me?
Thank you!
-> Screenshot of the current page.

no hovers are needed for this section


Image Segmentation Multiple Lables

I am not able to label the image using the brush with multiple labels. When I switch to the second label, it changes the label of the painted region.

You need to unselect the current path first. Press 'u' to do it or button on "Results" panel.

Thank you so much! My fault.


Installation issues for the front-end

Tried the yarn command, got this
$ yarn install
ERROR: [Errno 2] No such file or directory: 'install'

Using npm install instead. Rerunning the yarn command after the npm install still gives the same error. The readme should be improved to give better directions on this.
What does open config/development.js do? This command also does not work.
$ yarn run start
ERROR: [Errno 2] No such file or directory: 'run'

I am guessing that there are a lot of unstated assumptions in the readme about the environment on the machine.

This is a bug in Yarn, not in pathways-frontend. Please check what version of Yarn you are running using yarn --version. It should be 1.3.2. There was an issue with their packaging in Ubuntu 17.04 that you may be seeing here.
Note that NPM and Yarn are mutually exclusive. If npm install works, that's fine. Just bear in mind that our lock file is (currently) for Yarn so you might not have exactly the same version of each dependency.

Ensure that the readme correctly specifies the required yarn version and contains installation instructions.

Got the API server running and the webpack server, when I hit the website to load the locations, the API server has this error
"OPTIONS /locations HTTP/1.1" 200 0
Not Found: /locations
"GET /locations HTTP/1.1" 404 2286

the get response ought to go to /v1/locations

That is happening because we haven't merged PR #14 into master. It still thinks it is talking to the old (NodeJS) API.

There is no required Yarn version here. As I explained, the issue you had is that Yarn is packed incorrectly in Ubuntu 17.04. That isn't our problem, and will likely be fixed at some point. With that said, it's probably okay to switch to an NPM lock file and use NPM for the readme at this point. It is slightly less of a problem now that there are fewer old versions of NPM floating around.

I'd be happy see one less tool in the tool chain, if npm can do everything yarn does.


Added to my github details in developer community

Issue

Description

Checklist

[x] Added contributor object in ascending order in contributors.json
[x] Github action build passing
[x] No merge conflicts

Closing this as there is no response. Re-open when the issues are fixed


Korean / Japanise Text

Typing Korean or Japanise text a special popup is showing on top/right. Look this screenshot.
In this case typing 'wk' results in a single language character.

This behavior is different in the standard JavaFx components, like TextArea. Here no pop-up is shown, the character is edited directly in the TextArea.

Do you know, can be this changed in RichText area (that typing asian characters is done directly in the editor, not in the pop-up ) _
Also looking in Java, this behavior seems to be related to KeyTyped vs KeyPressed. Do you know how Java handle this ?

Hi, I am working with CJK input methods as well.
See the related issues: https://github.com/FXMisc/RichTextFX/issues/980

I hope on the latest version this works now fine. We had some fixes. Thank you for closing the issue and for your feedback.


Added RichMarker

Forgive me if I'm not following protocol in some way as this is all new to me. Any guidance would be appreciated!
This PR shows the change I have in mind to add the ability to use the Google Maps JS util library RichMarker found here. RichMarker allows any HTML/DOM elements to be used as markers.
The RichMarker library must be included separately. If the RM lib is included, the marker directive will use RichMarker methods and events (instead of the default Google Maps JS marker).
Please advise as to next steps here. Many thanks.

I have to refuse this pull request because I believe that RichMarker must be a separate directive from Marker directive.
The approach suggested is that user uses 'marker' directive, then internally It decides to use marker or rich marker based on environment. This approach works for small and private project, but not big and open project like this.

I understand. I started to make it its own directive but realized that it would effectively require duplicating so much of the marker directive. Didn't seem too DRY to me.
Perhaps there's a more elegant solution, say by adding a "rich-marker' attribute to the marker directive, to be used something like this:
<marker rich-marker="true" .../>

The reason for making a separate directive is very simple.

RickMarker is not a Google supported code. So when it goes wrong, it does not affect the other code.
Thus, I want it to have a separate code.

As you see in this example, view-source:https://googlemaps.github.io/js-rich-marker/examples/richmarker.html?, Rich marker uses 'content' as you see in line 75, which is different from Marker. We cannot pass that content as an attribute.

It must be angular compiled with scope respected. I see this has some similarity to InfoWindow.

As you see in their source code, view-source:https://googlemaps.github.io/js-rich-marker/src/richmarker.js, RichMarker does not use Marker for their base, but OverlayView class, which has very different attributes and events than Marker.

There are reasons that why ngMap does not support 3rd party or community codes, and the biggest one is that sometimes it does not works as Google maps design.
If ngMap module accept RichMarker as a directive, it will be the community code, which won't be maintained by the core developer by keeping it as a separate module. e.g., angular-resource.js, ng-map.rick-marker.js.

Makes sense. Thanks for your thoughtful response!


pythonPackages.smart_open: fix build, 1.5.6 -> 1.5.7

Motivation for this change
ZHF #36453
Previous version didn't build (according to available Hydra logs, 1.5.6 never built - last successful build was 1.5.3). Had to disable tests because they are incompatible with nixpkgs version of moto, causing some of the tests to fail.
/cc maintainer @jyp
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@grahamcofborg build python27Packages.smart_open python36Packages.smart_open

Success on aarch64-linux (full log)
Attempted: python27Packages.smart_open, python36Packages.smart_open
Partial log (click to expand)
Successfully installed smart-open-1.5.7
/build/smart_open-1.5.7
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7/lib
patching script interpreter paths in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7
checking for references to /build in /nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7...
/nix/store/9387fr4wrkvmhi0c80n5588932lh2nis-python2.7-smart_open-1.5.7
/nix/store/8iq1hg8m1lc6azrarc344pqa74axlf0y-python3.6-smart_open-1.5.7

Success on x86_64-linux (full log)
Attempted: python27Packages.smart_open, python36Packages.smart_open
Partial log (click to expand)
Successfully installed smart-open-1.5.7
/tmp/nix-build-python3.6-smart_open-1.5.7.drv-0/smart_open-1.5.7
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7/lib
patching script interpreter paths in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7
checking for references to /tmp/nix-build-python3.6-smart_open-1.5.7.drv-0 in /nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7...
/nix/store/5wz8wj6kaidw9iyxm2c66xriaz8cm6nl-python2.7-smart_open-1.5.7
/nix/store/mygxx8fz0ialbna001ffv3gxg3g0wlk5-python3.6-smart_open-1.5.7

:+1:


Please add the section "License and role requirements"

[Enter feedback here]
Please add the section "License and role requirements" on this page, especially to clarify if the Customer Engagement Professional license can be used for the integration with Teams and, if yes, for which features.
Reason for this request:

Dynamics 365 Sales pages have the section "License and role requirements". Example: https://learn.microsoft.com/en-us/dynamics365/sales/teams-integration/using-teams-chat-in-dynamics or https://learn.microsoft.com/en-us/dynamics365/sales/teams-integration/teams-collaboration. This is a great help.
"Swarming" requires an Enterprise license -> documented here: https://learn.microsoft.com/en-us/dynamics365/customer-service/use-customer-support-swarming

Thank you!
Michael

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c7692556-db0b-a411-7f87-8fdda45019f1
Version Independent ID: c7692556-db0b-a411-7f87-8fdda45019f1
Content: Overview of collaboration in Dynamics 365 Customer Service
Content Source: ce/customer-service/collaboration.md
Service: dynamics-365-customerservice
GitHub Login: @lalexms
Microsoft Alias: laalexan

Thanks for your comment, @MichaelWeberMSFT. This issue has been assigned to the doc author for review.


Provide more details

Seems like a great use case. Would love to see solution accelerator or at least code examples

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 041da9ff-57a4-916d-ae12-8b1e4fe77d44
Version Independent ID: a56ac57e-3796-559f-261f-76061e0e4810
Content: Blockchain Workflow Application - Azure Solution Ideas
Content Source: docs/solution-ideas/articles/blockchain-workflow-application.md
Service: architecture-center
GitHub Login: @adamboeglin
Microsoft Alias: pnp

Hi @panjevic Thanks for your feedback. We will review and update as appropriate.

Thanks for the suggestion. As this was a solution idea and not an example workload or reference architecture, we didn't create any implementation for it. We'd love to review one if you have one you could share via a pull request. Closing for now!


Fixed #35073 -- Avoided unnecessary calling of callables used by SET/SET_DEFAULT in Collector.collect().

@charettes I'm not sure how to update SET_DEFAULT to fix the unit test... any suggestions?

Solving for SET_DEFAULT is a bit more complex.
To solve entirely while supporting the optimization we'd have to change the on_delete handler interface so that when it's assigned to a Field.on_delete the field is passed immediately so the handler logic can see if the field has a callable default and set lazy_sub_objs accordingly.
I don't see that happening anytime soon so our best bet is likely to disable the optimization entirely for SET_DEFAULT by removing the .lazy_sub_objs = True assignment. ticket-33928 was about fixing SET_NULL in the first place so keeping it supported as well SET(value: !Callable) is likely good enough for this patch.

@charettes thanks! I updated this PR to remove the lazy_sub_objs optimization for SET_DEFAULT.

@bcail Thanks :+1:

Thanks for the patch folks! The one for SET_DEFAULT is a nice addition as it will ensure that if someone ever works on enabling the optimization for non-callable default in the future we'll have a safety harness.


Add auto_reducer and update some imports

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (d143637) 100.00% compared to head (2f3c3e0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           26        27    +1
  Lines          736       746   +10
  Branches        89        91    +2
=========================================
+ Hits           736       746   +10

Impacted Files
Coverage Δ

src/arctix/formatters/numpy_.py
100.00% <100.00%> (ø)

src/arctix/formatters/torch_.py
100.00% <100.00%> (ø)

src/arctix/reducers/__init__.py
100.00% <100.00%> (ø)

src/arctix/reducers/numpy_.py
100.00% <100.00%> (ø)

src/arctix/reducers/torch_.py
100.00% <100.00%> (ø)

src/arctix/reducers/utils.py
100.00% <100.00%> (ø)

src/arctix/reduction.py
100.00% <100.00%> (ø)

src/arctix/stats/continuous.py
100.00% <100.00%> (ø)

src/arctix/summarizers/summarizer.py
100.00% <100.00%> (ø)

src/arctix/testing.py
100.00% <100.00%> (ø)

... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Can't close side nav on home page with new banner at small breakpoints

Description

Tell us more about the problem that you're running into. What did you see? What did you expect to
see?

I'm seeing two issues, maybe related.

At small and medium breakpoints, the new home page banner bar is covering the top of the side nav so you can't get to the X button.
Outside click to close the side nav doesn't work if you try clicking the black UI header bar.

Steps to reproduce

How do we reproduce the error? Please be as specific as you can.

At small and medium breakpoints
Go here: https://next.carbondesignsystem.com
Open the side nav
Try to close the side nav

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


soroban-rpc: optimize passing ledger entries down to Rust in simulateTransaction

Right now when passing ledger entries from Go to Rust when running simulateTransaction the following stages happen:

The ledger entry is obtained from the DB in binary-serialized XDR
The DB interface transforms the ledger entry to a Go LedgerEntry data structure
The LedgerEntry structure is serialized again to binary and base64 before being passed to Rust
Rust deserializes the base64 to binary XDR and then to a Rust data structure

This could be simplified to:

The ledger entry is obtained from the DB in binary-serialized XDR
The binary-serialized XDR is passed to Rust
Rust deserializes the XDR binary to a Rust data structure

This requires:

changing the DB interface to return ledger keys in serialized form
Passing a byte array (slice) between Go<->C<->Rust

this can be done with the help of C.CBytes() and C.GoBytes() but it requires passing lengths around (Which is a pain since C can only return one parameter, but there are solutions).
We can still use a *char to delimit the end of the byte array.

We can still use a *char to delimit the end of the byte array.

except we can’t since *chars are delimited by zeros and the binary-compressed XDRs may contain zeros


SUNRISE: new indicators

heatwave_frequency
heatwave_max_length
heatwave_total_length
dry_spell_frequency
dry_spell_max_length
dry_spell_total_length
prep for SPEI
(ERA + CORDEX)

Regaring SPEI there are some things that have to be fixed/reworked in xclim:
https://github.com/Ouranosinc/xclim/pull/1311

The following indices are now implemented in index_calculator:
heatwave_frequency: HWf
heatwave_max_length: HWx
heatwave_total_length: HWn
dry_spell_frequency: DSf
dry_spell_max_length: DSx
dry_spell_total_length: DSn
Waiting for new release v0.8.0.


Strange HLIL with a messed up stack and use of undefined variables

Version and Platform (required):

Binary Ninja Version: 4.1.5272-dev, 3a057a87
OS: macos
OS Version: 14.4
CPU Architecture: arm64

IDA Pro
MD5_CTX *__fastcall DjiMd5_Transform(MD5_CTX *ctx_1, MD5_CTX *ctx_2)
{
  unsigned __int64 v2; // t2
  int data[20]; // [xsp+18h] [xbp-58h]
  int j; // [xsp+68h] [xbp-8h]
  unsigned int i; // [xsp+6Ch] [xbp-4h]

  i = 0;
  j = 0;
  while ( i <= 0xF )
  {
    data[i++] = ctx_2->data[j] + (ctx_2->data[j + 1] << 8) + (ctx_2->data[j + 2] << 16) + (ctx_2->data[j + 3] << 24);
    j += 4;
  }
  data[19] = ctx_1->state[0];
  data[18] = ctx_1->state[1];
  data[17] = ctx_1->state[2];
  data[16] = ctx_1->state[3];

But what is arg_0 in the HLIL below and why does it want to refer to __elf_program_headers all of a sudden?
Also, where's the assignment to data[16] and how do I create uint32_t data[20] on the stack here?
I can rename arg_0 to data and type it as int[20] but that doesn't change the assignments to x0_34, etc. at the end and doesn't add the missing one.
0008575c  struct MD5_CTX* DjiMd5_Transform(struct MD5_CTX* ctx_1, struct MD5_CTX* ctx_2)

00085768      int32_t i = 0
0008576c      int32_t j = 0
00085824      while (i u<= 0xf)
000857e4          uint32_t x0_21 = zx.d(ctx_2->data[zx.q(j)]) + (zx.d(ctx_2->data[zx.q(j + 1)]) << 8) + (zx.d(ctx_2->data[zx.q(j + 2)]) << 0x10) + (zx.d(ctx_2->data[zx.q(j + 3)]) << 0x18)
00085800          *(&arg_0 + (zx.q(i) << 2) - &__elf_program_headers[0].physical_address) = x0_21
0008580c          i += 1
00085818          j += 4
00085838      unsigned int x0_34 = ctx_1->state[1]
00085844      unsigned int x0_36 = ctx_1->state[2]
00085850      unsigned int x0_38 = ctx_1->state[3]
000858a4      int32_t var_58
000858a4      int32_t x0_48 = ror.d(((x0_34 & x0_36) | (not.d(x0_34) & x0_38)) + var_58 + ctx_1->state[0] - 0x28955b88, 0x19) + x0_34

The stack according to IDA Pro
.text:000000000008575C var_70          = -0x70
.text:000000000008575C var_68          = -0x68
.text:000000000008575C data            = -0x58
.text:000000000008575C j               = -8
.text:000000000008575C i               = -4
.text:000000000008575C arg_0           =  0

Also, where's the assignment to data[16] and how do I create uint32_t data[20] on the stack here?

Right now this has to be done manually (see https://github.com/Vector35/binaryninja-api/issues/2570). To do so you really should utilize the stack view, it makes validation easier. First you want to go to the stack view, identify the place you want to create it, in your case it is -0x58 (or var_58) and retype it as an array, you will get the following output:
00085830      int32_t var_58[0x14]
00085830      var_58[0x13] = *(arg1 + 0x50)
0008583c      var_58[0x12] = *(arg1 + 0x54)
00085848      var_58[0x11] = *(arg1 + 0x58)
00085854      var_58[0x10] = *(arg1 + 0x5c)
00085894      var_58[0x13] = ((var_58[0x12] & var_58[0x11]) | (not.d(var_58[0x12]) & var_58[0x10])) + var_58[0] + var_58[0x13] - 0x28955b88

I don't have a stack view for some reason so I assumed that BN didn't have this functionality.
Will go figure out how to enable it...

I don't have a stack view for some reason so I assumed that BN didn't have this functionality.

https://docs.binary.ninja/guide/index.html#stack

It's doing the right thing now, thanks!
How do I get rid of - &__elf_program_headers[0].physical_address) in the assignment?
Also, note that data is defined after the loop that uses it. I think it ought to be before, just like i and j.
0008575c  struct MD5_CTX* DjiMd5_Transform(struct MD5_CTX* ctx_1, struct MD5_CTX* ctx_2)
00085768      int32_t i = 0
0008576c      int32_t j = 0
00085824      while (i u<= 0xf)
000857e4          uint32_t x0_21 = zx.d(ctx_2->data[zx.q(j)]) + (zx.d(ctx_2->data[zx.q(j + 1)]) << 8) + (zx.d(ctx_2->data[zx.q(j + 2)]) << 0x10) + (zx.d(ctx_2->data[zx.q(j + 3)]) << 0x18)
00085800          *(&data[zx.q(i)] - &__elf_program_headers[0].physical_address) = x0_21
0008580c          i += 1
00085818          j += 4
00085830      int32_t data[0x14]

either mark it as not a pointer or rebase your binary.

I may be missing something but ...
This is a proper ELF binary so I do have ELF
00000040  struct Elf64_ProgramHeader __elf_program_headers[0x9] =
00000040  {
00000040      [0x0] =
00000040      {
00000040          enum p_type type = PT_PHDR
00000044          enum p_flags flags = PF_R
00000048          uint64_t offset = 0x40
00000050          uint64_t virtual_address = 0x40
00000058          uint64_t physical_address = 0x40
00000060          uint64_t file_size = 0x1f8
00000068          uint64_t memory_size = 0x1f8
00000070          uint64_t align = 0x8
00000078      }

data is just an array of ints so no pointers.
&__elf_program_headers[0].physical_address resolves to 0x58.
IDA shows
    data[i++] = ctx_2->data[j] + (ctx_2->data[j + 1] << 8) + (ctx_2->data[j + 2] << 16) + (ctx_2->data[j + 3] << 24);

but BN shows
*(&data[zx.q(i)] - 0x58) =  ...

What am I missing?

This is a duplicate of this:  https://github.com/Vector35/binaryninja-api/issues/5406
If we fix 5406 we'd not have this issue.


post is not defined, when calling postAfterEditMethodCallbacks

collections/posts.js#L499
on server's error log:
Exception in defer callback: ReferenceError: post is not defined
I20150410-16:16:21.646(9)?     at app/collections/posts.js:499:37
I20150410-16:16:21.647(9)?     at Array.forEach (native)
I20150410-16:16:21.647(9)?     at app/collections/posts.js:498:38
I20150410-16:16:21.647(9)?     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
I20150410-16:16:21.647(9)?     at packages/meteor/timers.js:6:1
I20150410-16:16:21.647(9)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)

Maybe we should pass updated post to callback?

Oh, I think we modified it here: https://github.com/TelescopeJS/Telescope/pull/875/files
What if we just pass postId instead of post?

Okay. postId works too.

https://github.com/TelescopeJS/Telescope/pull/905
I'm the one responsible for introducing this issue, here is the fix on a new PR.
The thing is, we need to pass the callback both the modifier and the post before it was updated so we can compare the two and optionally perform tasks depending on the result. (like not fetching embedly data once again if the post URL did not change).
When performing the PR I forgot about adding a line to fetch the post before it is updated, sorry about that.

Oh good point. Thanks!


Maroom - Interior Design Landing Page

Issue Type:

[ ] Bug Report
[x] Feature Request
[ ] Documentaion

Possible solution

This is a Landing Page for an Interior Design Product name Maroom. This was inspired by a random dribble mockup design.

Screenshots

@arpit456jain @ankitapuri I would like to work on this as a part of DCP'21

ok @kiruba-r11 just make sure that you make it by your self dont download from anywhere
we noticed these kinds of issue


Python logging examples needs asap

Hello,
It would be of great benefit to include python logging examples as soon as possible.
Thank you very much

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13672b67-22ea-3dda-8b6b-3332c24e6030
Version Independent ID: fdc60aeb-9971-1d9f-a6ba-b3ad818cf0d5
Content: Monitor Azure Functions
Content Source: articles/azure-functions/functions-monitoring.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@SeaDude Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.


feat: Add is_root method to Tag struct

Description

Notes to the reviewers

Checklist

[x] I followed the contribution guidelines
[ ] I ran just precommit or just check before committing
[ ] I updated the CHANGELOG (if applicable)

Cherry-picked at 89c13841d960cece049aa864ca9d3a8e9e750359


Suggestion - Snippets => CASE

Hi there.
Sorry for not forking your project and making changes for you to absorb later. [blush] I do not know how to yet / have not tried yet.
I hope to show you something:
./snippets/language-scl.cson
'.source.scl':
  # other code excluded
  'Case statement':
    'prefix': 'case'
    'body': """// CASE STATMENT
    case ${1:#numberTag} of
      ${2:0}: // First step
        ;
      ${3:1}: // Last step
        ;
      else
        ${1:#numberTag} := 0; //..restart
      end_case;"""

Note how the """ is used - no need for \n or \t. The "origin line" is inline with the ' of 'body'. The tabs are now replaced by spaces. Two spaces for each tab.
Note also the place-holder entries like ${1:#numberTag} (also 0 and 1). After placing the CASE you can cycle through the place-holders pressing Tab. When filling in #numberTag, both instances will be changed.
Helpful?
Best regards.
- Dan Padric

Hi.
Yes I'm awear of the numbering and that you can cycle through it (it is being used in the other snippets). I just thought that I'd try to omit the explanatory text or any suggestions for the case-snippet, and see how that feels for a while.  You can still cycle throug the correct posistions, even though the placeholders are not there.
However, I see your point in defaulting with ${2:0} through ${2:n} for the cases. It just so happens that we mostly use constants as cases where I work.
Regarding \n \t and the """:
This is a personal preference. Old habits die hard, and so I'm used to reading \n \t for string operations. I feel more in control, if you know what I mean.

I can't decide if I like that the snippet produces semi-colons for each case. Like so:
case siInt of    0:     ;   1:     ;   end_case;
I know TIA does this, but I tend to write them anyway (it's in my hands). So I often end up with having to delete one of them. You could argue that "at least it will compile if you forget to do something for a case", but when would that be a good thing. I mean, useless code is more of a nuisance than having to type the semi-colon.

Hi. Thanks for sharing your thoughts.
Much of what you mention boils down to personal choice. What I proposed is what I would do. (smile) I know SCL from TIA.
The """ makes it easier that you do not need to use the escape key when // comment. It also makes it easier for others to understand what goes on and follow the example to expand the snippets.
Consider:

did you publish this for only you or for others too?
what do other people (not you and me only) want?

The siInt is clear that an INT is needed. That is okay.
Having an active place-holder in place feels like a 'must'.
But having 0 or variable FIRST does not really matter.. a number is short and clean IMO.
As for the ; - there does need something, Special reminder of indentation as well as "code needed". I like the ; there, but '// codeas marker is okay too. As far as I know;and#` is put into place when you export. Would you please test this on Step7 V5.x (Classic).
When it comes to the # - it would make it easier to identify and syntax colourize the variables. There is still much syntax colouring that can occur - if you want to. I am currently busy with STL.. still in alpha stage. I can send you a picture if you want to know. I also have a rough idea on how to export-alter from TIA to Classic.
You do know that custom snippets can also be included in Atom's main keymap file?.. So even if we do not agree, (wink) I can go and create my own versions without changing your project. So I'll give opinions, but you go with what you think is good.
Your thoughts?
- Dan

Variable names starting with # does not compile in Step 7 V5.x.
Highlighting variables also seems kind of exsessive. I have yet to see that being used in other IDEs for a variaty of languages. However, identifying variables can of course be useful if you are going for a language parser.

# is handled in STL code.. though not in the variable declaration section
FUNCTION "Messages" : VOID
TITLE =Display fault messages on OP.

VAR_IN_OUT
  sms : INT ;	// Message number
END_VAR
BEGIN
NETWORK
TITLE =Default message.

      L     0;
      T     #sms;
      NOP   0;
END_FUNCTION

I rather like having syntax colouring to distinguish global variables (") vs local variables (#) vs numerical constants. THAT is however how I like it - you do as you see fit.
- Dan


Secret key is not working

Hello,
I have complete the amazon-config.php file with the following amazon mws account settings :

merchantId
marketplaceId
keyId
secretKey

Unfortunately, the order_examples.php file show me the following error : There was a problem with the Amazon library. Error: Secret Key is missing!
The secret key is well completed in the amazon-config.php file.
I have look at the log.txt file and I have the following error :
[Warning][2017/06/28 18:10:23<EMAIL_ADDRESS>AmazonCore.php:133 setStore] Store MyStore_Well_ Completed does not exist!
[Urgent][2017/06/28 18:10:23<EMAIL_ADDRESS>AmazonOrderList.php:50 resetMarketplaceFilter] Marketplace ID is missing
How can I fix the issue ?

Did you make sure that the store name you provided to the object matches the array key in the store array? Be sure to read all of the comments in the example files and the readme for more information.

Thank you very much !
My mistake was ridiculous, i didn't replace 'YourAmazonStore' by 'MyStoreName' in the file amazon-config.php for the following variables :
$store['YourAmazonStore']['merchantId']
$store['YourAmazonStore']['marketplaceId']
$store['YourAmazonStore']['keyId']
$store['YourAmazonStore']['secretKey']
$store['YourAmazonStore']['serviceUrl']
$store['YourAmazonStore']['MWSAuthToken']
Thank you very much for your help.


Standardize test framework and "through" lib in core dependencies

Since browserify uses tap and through2, that's what the standard will be.

cc: @terinjokes @jmm

also https://github.com/substack/node-detective/pull/50 because it's such an easy win.

done!


CHESTMNIST Dataset Shape

Hi,
The labels are in the format (# number of samples, 1) in all datasets (except CHESTMNIST), where a single number represents each label. However, in the CHESTMNIST dataset, the labels are in the format (# number of samples, 14), with each label being a one-hot vector. Could you explain the reason for this difference?

The chest one is multi-label dataset, it means that each 0/1 as one of the 14 columns are for an existence of a disease.
Jiancheng


Documentation shows setAuth() returning user and error in the return object.  This is causing confusion.

Improve documentation
Documentation shows setAuth() returning user and error in the return object.  This is causing confusion.
const { user, error } = supabase.auth.setAuth(access_token)
## Link
EDIT: This might be better in the supabase (document) forum, but figured a dev familiar the function should decide the right answer for what to say.
Describe the problem
setAuth returns a session object with the user null and no error property.  By showing those in the return this is causing confusion for users as observed in Discord and Github.  Some think it will return a valid user object.
Examples: https://github.com/supabase/gotrue-js/issues/243 and https://discord.com/channels/839993398554656828/952306750369959957
Describe the improvement
Consider changing the return to session.
let session = supabase.auth.setAuth(access_token)
Or have no return.
Also comment that the function does not make a server call, sets the token in the session and clears the user object.  If you need the user object then suggest calling getUser AFTER you do setAuth.

This has been addressed in v2.


Support bounded front dropping mailboxes

User actor needs to skip repeating messages on reaching mailbox size limit

This feature was implemented long ago, missed closing the issue since


Remove option-ext dependency

I found a way to replace the use of this dependency with a trivial compare.

Sorry, but I like it the way it is.

Why?

Why?

A dependency for such a trivial operation is rather on the bloatful side, but most importantly, extends the virality of its copyleft MPL license to this MIT/Apache-licensed crate, which does not make much sense:

Can this decision be reconsidered, please?

I noticed this PR is an exact duplicate of #24.

@AlexTMjugador extends the virality of its copyleft MPL license

?

@AlexTMjugador extends the virality of its copyleft MPL license

?

I wrote that comment before properly researching the situation with this dependency. At the moment, I have no new arguments to add to the discussion about why the dependency on option-ext is, in my opinion, uncomfortable. Other people have already thoroughly explained reasons I can think of in several other issues.

I'd like to join the request - my org forbids the usage of crates using a copyleft license even as an indirect dependency.
@soc I understand that you prefer the code as is, I just hope that you understand that this makes dirs-sys and crates dependent on dirs-sys unusable by some organizations.


Updates

Codecov Report
Base: 89.40% // Head: 87.86% // Decreases project coverage by -1.54% :warning:

Coverage data is based on head (14ae2e3) compared to base (92f2b21).
Patch coverage: 75.00% of modified lines in pull request are covered.

:exclamation: Current head 14ae2e3 differs from pull request most recent head 684d475. Consider uploading reports for the commit 684d475 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   89.40%   87.86%   -1.54%
==========================================
  Files           7        6       -1
  Lines         302      272      -30
==========================================
- Hits          270      239      -31
- Misses         32       33       +1

Impacted Files
Coverage Δ

src/system/system.jl
80.00% <33.33%> (-4.15%)
:arrow_down:

src/solvers/ldu.jl
100.00% <100.00%> (ø)

src/solvers/lu.jl
100.00% <100.00%> (ø)

src/GraphBasedSystems.jl

src/system/setup_functions.jl
97.67% <0.00%> (+1.92%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


GSSOC 23

What is the issue in this project for whom I can contribute in the reference of GSSOC 2023 ?

I didn't found any issue, you can add a feature like login functionality using firebase or you can improve UI designing.

Do I just need to change UI of the Project ?

Yes , if you can do then do it .

can I work on changing card's design ?

I am working on this part !!

please commit your code here if you are done with your changes .


fix: Fix error with ambiguous or invalid time on leaps between DST and zone time

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:


Live Reload is not possible without body or head tag

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Other:

Current behavior
The web browser shows something when I just run the extension and connect to a port No. but when I make changes to my html files the error message ("Live Reload is not possible without body or head tag") pops up and the web browser shows nothing (blank). I have to close the server and reconnect it every time for web browser to show the new web contents. When I added an extra    or  the Live Server works fine for some reason.

I installed Live Server 8 months ago and it worked fine until recently when I tried to use it again after 4 months of inactivity and updated to the new version of it. I tried to open my old html documents that used to work fine with Live Server and don't work fine with it now. I thought I might have changed my codes and copied some codes from https://www.w3schools.com/html/default.asp but the Live Server behaved the same way.
The codes I copied from the link and with issue
<!DOCTYPE html>

<title>Page Title</title>

This is a Heading

This is a paragraph.

The codes that work fine with extra   or
<!DOCTYPE html>

<title>Page Title</title>

My First Heading

My first paragraph.

<!DOCTYPE html>

<title>Page Title</title>

My First Heading

My first paragraph.

Expected behavior
It should reload and work without the extra  or , like last time, without problem.

Environment
Browser:

- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
- [ x ] Edge version 42.17134.1.0

For Tooling issues:

- Live Server: 5.3.0
- Platform:  Windows
- Visual Studio Code: 1.30.2

Others

Just click to turn off when it prompts

Just click to turn off when it prompts

This is not the solution. The problem is not the annoying notification, but the fact that auto-reload doesn't work.
In my case is even worse - instead of the mentioned notification, Live Server shows a blank page, doesn't matter what I type as a code.

Yep, got this problem now. Not bothered by the notice, it's the reloading that's the problem. Is there a fix yet?

I got the same problem. In my case, the problem was a wrong file encoding in index.html. When I changed the encoding to ASCII or UTF-8, the Live Reload started working again.

I've been having this issue as well for my index.html
My solution was to delete the original file, then create a new file and copy over the code.
I created a separate test.html and live-reload was working again. Thought it was an encoding error so I copied my working test.html code into index.html. Still no luck. Deleted and then created a new index.html -- things are back to normal now.

I used to have it when I had a link to an .svg file that was not saved. Saving all files in the project could probably work.

After reading other posts decided to make a small change in th index.html page from :
to  and it started to work again.

Actually,you just need add the code like this:.I think this is a bug for compiler or some other thing else.Anyway ,i soloved it

Actually,you just need add the code like this:

I think this is a bug for compiler or some other thing else.Anyway ,i solved it

Actually,you just need add the code like this:
  in your head part
I think this is a bug for compiler or some other thing else.Anyway ,i solved it

The problem can also arise when working on a project saved on an external hard drive, this is the case for me. The extension may fail to detect changes from the external hard drive.


Boheh stone

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
Information about the Boheh Stone, a rock outcrop sporting Neolithic art carvings that is located outside of Westport in County Mayo, Ireland, and the natural phenomena observable from it.
Input given at the prompt

Response from the original model

Response from the fine-tuned model

  ...

Contribution checklist

[ ] The contribution was tested with ilab generate
[ ] No errors or warnings were produced by ilab generate
[ ] All commits are signed off (DCO)
[ ] The qna.yaml file contains at least 5 seed_examples
[ ] The qna.yaml file was linted and prettified (yaml-validator can do both)
[ ] An attribution.txt file in the same folder as the qna.yaml file
[ ] Content does not include PII or otherwise sensitive or confidential information
[ ] Content does not include anything documented in the project's Avoid these Topics guidelines

Taxonomy tree recommendation:
knowledge/geography/europe/ireland/Boheh_Stone

I was wondering why this was closed?


[Tool] Doctor should warn on non-ideal git configuration of the Flutter repo

The Flutter tool does not support the upgrade operation on the following configurations of the user's local Flutter repository:

The current checkout is on a "Detached HEAD" state.
The current checkout does not have an upstream.
The checkout is not tracking an official upstream(aka "standard remote").

However, the doctor output still shows a ✓ for such cases in the Flutter section.

An example

$ ./bin/flutter doctor
Building flutter tool...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 2.13.0-0.0.pre.601, on Artix Linux 5.17.3-artix1-1, locale en_IN.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[!] Android Studio (not installed)
[✓] Connected device (2 available)
[✓] HTTP Host Availability
! Doctor found issues in 1 category.
$ git checkout HEAD^1
Note: switching to 'HEAD^1'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
...
$ ./bin/flutter doctor
Building flutter tool...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel unknown, 2.13.0-0.0.pre.600, on Artix Linux 5.17.3-artix1-1, locale en_IN.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[!] Android Studio (not installed)
[✓] Connected device (2 available)
[✓] HTTP Host Availability
! Doctor found issues in 1 category.
$ ./bin/flutter upgrade
Unable to upgrade Flutter: Your Flutter checkout is currently not on a release branch.
Use "flutter channel" to switch to an official channel, and retry. Alternatively, re-install Flutter by going to https://flutter.dev/docs/get-started/install.

Proposal
Highlight that the current install has issues with the git configuration by showing a ! in those cases.

This change would mainly affect these lines:
[✓] Flutter (Channel master, 2.13.0-0.0.pre.808,...
    • Flutter version 2.13.0-0.0.pre.808 at ...
    • Upstream repository https://github.com/flutter/flutter.git

The first line would show an issue if FlutterVersion.channel is null(the channel
name should also be added in this line). Ideally, it should also show if the
tool couldn't calculate FlutterVersion.frameworkVersion.
    ! Flutter version 0.0.0-unknown on channel unknown at ...

0.0.0-unknown is set inside FlutterVersion itself by a private member
_unknownFrameworkVersion. To check whether FlutterVersion.frameworkVersion is
0.0.0-unknown in FlutterValidator, _unknownFrameworkVersion needs to be made
accessible.
The second line would show an issue when VersionUpstreamValidator.run() returns
an error.
    ! Upstream repository https://githubmirror.com/flutter/flutter.git

However, since the result of VersionUpstreamValidator.run() also depends on the
value of FLUTTER_GIT_URL environment variable, the above message needs to change
a bit to accurately describe to the user the reason of this failure. This would
have the following diffrent forms:
    ! Upstream repository https://githubmirror.com/flutter/flutter.git is not the same as FLUTTER_GIT_URL
    ! Upstream repository https://githubmirror.com/flutter/flutter.git is not a standard remote
    ! Upstream repository unknown


Unknown error message on incorrect logging field

Describe the bug
If e.g. a logging fiels is incorrect the error message is not user friendly. The UI shows: update workflow: undefined
To Reproduce
Add logging like this:
  log: "machine mark jq(.return."3".output.hardening_index | tonumber < 75)"

I don't think this error is reproducible with the latest release.


Zephyr log backend

~Depends on #140~

Just minor comments.
One thing that I wanted to emphasize is that this implementation differs from the one in Zephyr SDK:

CP SDK: just sends logs strings with formatted metadata (like function name, module name, timestamps, etc.) as part of string
Zephyr SDK: it is more like "dictionary-style" logging, where metadata is separate from log string

We can look at adding more metadata back later if we find that there is customer demand for it. For now, this keeps the implementation common among the different ports, and avoids a lot of string processing that was happening in the Zephyr port. I'm not convinced that we want all that happening by default for all customer applications - I prefer to keep it light weight.


Refine"by AI"

I started JabRef
I opted in to AI (refs https://github.com/InAnYan/jabref/issues/92)
I am waiting for the summarization

The text "AI" is not clear. The privcacy policy stated, one can choose between Misral, OpenAI, and others. The status output should say with which provider JabRef is interacting.

Implemented


Merge app and api code under a common utils

Right now, api views.py code is not updated with the changes in app views.py. There are some API which doesn't use anything from app source code. Not sure why, but it was a bad design decision to separate API and App code. We should have a common utility handling both API and app calls.

@rtgdk Can you explain this issue in detail?

If you look at the api code for validate/convert/compare, you will see that it is quite outdated as compared to similar app code. We need to have API also go through the same functions as app calls (Maybe have a common utility that both of them of calls, or redirect API calls to app in some way or any other idea you can think of). Maintaining and testing will become a lot easier once these are merged. I assume it will be a big project (~ 2 weeks).
Please discuss any other approach you have before you start this.
API request and response - https://github.com/spdx/spdx-online-tools/wiki/REST-API-Fields-Request-and-Response

@rtgdk I would like to work on this. I'll take a look at both the app and api codebase and will discuss it here.
Thanks!

Fixed with #316


Implement two new dependence functions, logistics4 and alpha3

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] code improvement request

Expected behavior
How should it work (with the bug fixed or the feature implemented)?
In a paper currently under review, we proposed two new dependence functions for the bivariate wind-wave distribution.
The dependence functions are a logistics function with 4 parameter:

and a dependence function with 3 parameters, but that also uses the logistics function:

These dependence function were implemented in Matlab Code (https://github.com/ahaselsteiner/2020-paper-omae-hierarchical-models/tree/master/matlab) and should be implemented in viroconcom. The architecture of viroconcom is currently not intended for the second kind of dependence function such that some bigger changes are required.

Implemented.


Introduce ruff::rules module

Resolves #1547.

Huh, that's interesting apparently GitHub's file move detection is worse than git's file move detection ... if you git show the second commit git reports:

1247 insertions(+), 1247 deletions(-)

whereas the GitHub UI apparently just gives up and claims

+39,491 −39,492

Cool.
Is it at all strange that we have (e.g.):

rules::flake8_quotes::rules (rules twice)
rules::flake8_quotes::settings (rules module includes settings)

Do you see this changing further in future commits?

Yes I think the duplicate "rules" could be changed to rules::{origin}::{specific_rule}.
I don't really mind the settings under rules since the settings are for the rules ... potentially the settings could be moved to mod.rs and the tests out of  mod.rs.

Ok cool. Do you mind rebasing, and I'll merge this next? Apologies.

Of course, no worries :) Rebased.

Thanks!

(btw I sent you an email yesterday)


Add pre-built binary for node 14

Hi, could you add a pre-built binary for node 14? We just upgraded to 14.15.1 (LTS). Thanks :)

Hey, Bill! We're also in the process of upgrading to Node 14, so we'll publish this very soon! 🌚

Hey, Bill! We're also in the process of upgrading to Node 14, so we'll publish this very soon! 🌚

We've published this for 64-bit OSX (darwin) + Linux. Feel free to re-open if you'd like other platforms.

We've published this for 64-bit OSX (darwin) + Linux. Feel free to re-open if you'd like other platforms.


Guide fails at "Load your workspace"

Update the project. Run as it stands fails at the "Load your workspace" step - can't load the environment. I found a solution in this link: https://github.com/Azure/azureml-sdk-for-r/issues/232#issuecomment-580943754
> azuremlsdk::install_azureml(envname = "r-reticulate")

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f89940a-4eac-f1ff-99a7-8fcc47b70482
Version Independent ID: 52be38c9-5450-42fc-b44f-1189b45b7838
Content: Tutorial: Use R to create a machine learning model - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-1st-r-experiment.md
Service: machine-learning
Sub-service: core
GitHub Login: @revodavid
Microsoft Alias: davidsmi

#assign:@sdgilley can you look into this?

@DavidDataOrbis - are you saying this code fails on a compute instance running RStudio, or that it fails on your own installation of azuremlsdk?

@sdgilley - this was using a compute instance running RStudio in the browser. Azuremlsdk comes pre-installed with the compute instance, but I could not get the workspace to load until I re-installed it using the feedback from that link above. Neither "get_workspace()" nor "ws <- load_workspace_from_config()" worked

Thanks, we're looking into it now.

Thanks for bringing this to our attention.  We have a task to update the compute instance with the correct packages, but in the meantime I've also updated the article to do an install of the package.
#please-close

You are welcome. Great to see such an efficient follow up and update


Modify UI in Lobby page

Modify user profile popup UI

Enhance game rule button

Change guide position and automatic popup when first enter lobby

Add notify for user to allow using microphone

Modified number input in room creation

Change room empty place remaining display and cursor on the "plus" icon


Safari - DASH with multiple audio tracks doesn't play

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Not sure
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
iOS doesn't support MSE, so not sure
iPad OS 15
Safari on OSX 15.6
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-GB;textlang=en-GB;uilang=en-GB;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;panel=ALL_CONTENT;panelData=drm:CLEAR,DASH,MP4;build=compiled
What configuration are you using?  What is the output of player.getConfiguration()?
Default
What did you do?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-GB;textlang=en-GB;uilang=en-GB;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;panel=ALL_CONTENT;panelData=drm:CLEAR,DASH,MP4;build=compiled
On my custom application, if I don't call selectAudioLanguage it works fine.
What did you expect to happen?
The video should play.
What actually happened?
The video never plays, and a lot of fetch calls are made.

I have tested with Safari 17 and it works correctly. The problem with Angel One is that it chooses WebM by default which does not work correctly, if you choose the MP4 version it works correctly.


Open Source Contributions page

What we want: A way to display contributions our students have made
Potential features:

'Levels' of achievement, ie. Gold, Silver, Bronze users, etc.
Links to relevant PRs? (Could be an issue if some users submit dozens of PRs)
Option to post to social media

What we don't want:

For this to be associated with 'users'
For it to be difficult to maintain

In thinking more about this, I'm not sure that it's the best way to motivate students to contribute to open source. That said, I'm not sure I have any better ideas either.  @ElijahCaine @borcean any other thoughts?


Unable to output two dots ..

In a tech wiki i need to write .. which means "parent directory". Markdown seems very opinionated about this and it transforms it to ...
I believe it is correct to keep the two dots

Just read docs and configure parser as you need. Nobody forces you to use default typographer.

Ok but why the default typographer needs to transform this ?


Custom Error Page added

Closes #312

Changes proposed

Added a custom 404 error page for non-existing/undefined routes.
When a user will visit such route unknowingly, he will be shown this error page with a redirect to home page button.
Matches correctly with the theme of the website.
Responsive on multiple sizes.

Screenshots
screen-capture (20).webm

Note to reviewers

@Susmita-Dey Changed the color to white as the standard color.
Also renamed the required


Support multi-tenancy in Zeebe 8.3

Description

Support multi-tenancy in Zeebe 8.3.x

Updated Zeebe version to 8.3.5
Added the attribute tenantId to schema and transformer
Updated the tests accordingly

BEWARE: in order to fully support Zeebe 8.3.x, e.g. new ValueTypes PROCESS_INSTANCE_BATCH, MESSAGE_BATCH and FORM there is more to do. But supporting multi-tenancy might be good start.
Related issues

closes #313

@VonDerBeck thank you for contributing. :tada: I'll have a look soon. :eyes:


[Question] Animation while sliding the keyboard out

I have a common messaging screen layout.
This package works expected. (Thanks!)
And I tried to enhance the behaviour with flutter_interactive_keyboard

The result is not bad. But obviously what I need here is snapping the footer widget to the bottom while keyboard position updates rather than animated between two values when focus changed.
Is there any idea?

Hi furkansarihan,
Thanks a lot for using the package! I am very happy to see that it inspired others to build more complex behaviour, very nice work!
Regarding the footer snapping animation, I have not had the time to take a deep dive into your package's code, but one idea comes to mind. I would suggest you to check the transition_builder example from the example folder in the keyboard_attachable package. That example uses a transitionBuilder parameter to animate a button and a text field in sync with the keyboard hiding and showing.
What I did to achieve that behaviour was to include a callback function to the KeyboardAttachable builder, in which I passed the animation for the keyboard, so that consumers could access the animation and use it to run whatever animation they needed to sync with the keyboard.
If you take a look at the src from keyboard_attachable, you will find the implementation details in keyboard_attachable.dart. Basically I declared the callback like this:
/// Signature for builders used in custom transitions for KeyboardAttachable.
///
/// The function should return a widget which wraps the given [child].
/// It may also use the animation to inform its transition.
typedef KeyboardTransitionBuilder = Widget Function(
  Widget child,
  Animation<double> animation,
  double keyboardHeight,
);

and then I called the callback in the build method of KeyboardAttachable like this, passing the animation that KeyboardAttachable uses:
@override
  Widget build(BuildContext context) {
    // ...
    return Column(
      mainAxisSize: MainAxisSize.min,
      children: <Widget>[
        if (child != null)
          widget.transitionBuilder(child, animation, _bottomInset),
        SizeTransition(...),
        ),
      ],
    );
  }

And that is how I would do it. I am not sure if this animation callback approach suits your implementation case, but I hope it points you towards the right direction. Anyways, if you have any further questions, don't hesitate to ask me!

Unfortunate, I am not the author of the flutter_interactive_keyboard
I will look into transition_builder.  Thanks for the explanation!

Oh, my bad! I thought you were a contributor to that project. I guess you can still propose a new feature for it. Either way, you will need some way to access the animation controller value that is driving the keyboard animation, and the way that is usually done in Flutter is through an animation callback like the one I showed to you. You can find several more examples of such an approach in the framework itself. For example, if I remember correctly, AnimatedSwitcher has a very similar callback to let the consumer control what happens during the animation.
Good luck, and glad to help!


[Playstation 2 Arch]: Markdown link misspell

In the The Leader sub-section of the CPU section, a Markdown link to the N64 article's CPU section was misspelled, therefore showing up as plain text.
Current:

MIPS III ISA: A 64-bit RISC instruction set. Wait, is it me or this is the same ISA found on a [competitor’s console](https://www.copetti.org/projects/consoles/nintendo-64/#cpu?. (...)

Fix:

MIPS III ISA: A 64-bit RISC instruction set. Wait, is it me or this is the same ISA found on a competitor’s console? (...)

Cheers


Consider allowing params on /listings

(Based on my limited understanding of React server/client rendering)
At build time, React creates the static page for <public_site>/listings.
At run time, when a client requests /listings, React serves the static HTML it generates. If you typed /listings?page=1&limit=5 into the browser, React discards the query params and just returns the HTML page it generated at build time.
Assuming it's possible, we could augment our getStaticProps() in /listings to respect the params and make new requests to the backend such that a client could go directly to /listings?page=5&limit=10 and get the page they want. We could still pre-generate something like /listings/page/[number] based on defaults we have.

Some info about how to make that work: https://spin.atomicobject.com/2019/10/01/a-quick-start-guide-to-query-strings-with-react-router/

I think we're already doing this with Abbie's changes to pagination.


[badger] Make default dirs work in Windows

Which problem is this PR solving?
Resolves #1652 (Windows default directories do not work), but also ensures that the directories are created successfully since badger only creates the last directory - not the missing parent directories. This is why default directory does not work unless data is created first.
Short description of the changes
Use os.pathSeparator instead of hardcoded / and create directories if possible.

I don't think travis test failures are because of changes in this PR

restarting


Stack Overflow Error When Calling GetViewAysnc Without Cancellation Token

https://github.com/Bassman2/JenkinsWebApi/blob/c22c44cf42bd8e21342e6cd33c14c2a07c5437f9/JenkinsWebApiShared/Jenkins.Info.cs#L173
I ran into this issue when trying to use GetViewAsync, it looks like the call to the other version of the function is missing the CancellationToken.None value.

Fixed


Migrate fix for PumpManager: Use pump limit from pumpManager instead of UI

Migrating this important fix over to Trio.
Quoting @bastiaanv, the original author:

What is the problem
I will start by saying: This is mainly a Dana pump problem, but the problem is the following:
The LoopKit syncDeliveryLimits allows the PumpManager to return DeliveryLimits which are also provided by the parameters. When using Loop (v3.3.0, but this behaviour is since v1.1.0), a dev could return a different then provided and the returned will be stored instead of the provided one. [Trio] doesn't do that currently.
Code proof of this behaviour: https://github.com/LoopKit/LoopKit/blob/dev/LoopKitUI/Views/Settings Editors/DeliveryLimitsEditor.swift#L348
Why do we need it
We need this, because Dana pumps don't allow delivery limits to be set, only to be retrieved. This means that the DanaKit should either:

Reject every syncDeliveryLimits command (which leads to an invalid maxBolus and maxBasal since there are never stored)
Or ignore the provided parameters and just fetch the actual limits from the pump and return those

The last one gives the user the best UX :)
What is the impact
Nothing (or at least the behaviour is the same as with Loop). The code has been tested on the Dana branch
When looking at the code from OmniBLE and OmniKit (link), the parameter is directly returned.
When looking at the code from MinimedKit (link), the actual values stored on the pump is (set first and then) returned.

Relates to #263

Does this PR also solve the issue with Medtronic pumps which are limited to 25 U max, unlike pods that can deliver 30 U max? (ref issue 247,  but I won't link that issue until I understand if this PR is relevant there)

On Medtronic it would, since the settings are fetched after setting. See: https://github.com/LoopKit/MinimedKit/blob/main/MinimedKit/PumpManager/MinimedPumpManager.swift#L1418
On Omnipods it wouldnt, since the parameter is returned and not fetched from the pump. See: https://github.com/LoopKit/OmniBLE/blob/dev/OmniBLE/PumpManager/OmniBLEPumpManager.swift#L2106

Thanks, then I think we can say that https://github.com/nightscout/Trio/issues/247 will be closed with the merging of this PR!

Test Results:
I got a build failure - see Configuration 2 details.
The behavior with the PR (modified so it would build) was different - no error message but the Pump Settings screen showed the pump maxBolus after silent failure instead of showing the attempted value.
Configuration 1:

MDT 515 pump (initial maxBolus 7, maxBasal 0.9)
Trio, commit 14c76432

Trio settings: maxBolus 10, maxBasal 2
attach pump
(just as an aside) unlike loop, the pump can be attached even though the maxBolus and maxBasal on pump are less than Trio settings
Following connection, pump settings match Trio pump settings
Modify Trio settings: maxBolus 5, maxBasal 0.9 and save on Pump - done successfully
Modify Trio settings: maxBolus 30 and save on Pump - fails silently; the Pump Settings screen continues to show 30 U until leaving and returning to the screen

The Xcode debug log reports:
Save delivery limit settings failed: command(MinimedKit.PumpOpsError.pumpError(Max setting exceeded))
Type: Error | Timestamp: 2024-06-03 11:53:24.222964-07:00 | Process: FreeAPS | Library: MinimedKit | Subsystem: com.randallknutson.OmniBLE | Category: MinimedPumpManager | TID: 0x18acfa

Configuration 2:

MDT 515 pump (initial maxBolus 5, maxBasal 0.9) from prior Trio setting
Trio, commit 14c76432 with PR 266 patch applied - fails to build (see below for error and work-around).
Now when attempting to set maxBolus to 30 and save on pump, it still fails silently but it does not show 30 U on pump settings screen - leaves it at 5 U.

The Xcode debug log reports:
Save delivery limit settings failed: command(MinimedKit.PumpOpsError.pumpError(Max setting exceeded))
Type: Error | Timestamp: 2024-06-03 13:16:25.633035-07:00 | Process: FreeAPS | Library: MinimedKit | Subsystem: com.randallknutson.OmniBLE | Category: MinimedPumpManager | TID: 0x191915

Build Failure

commit: a06cd43c (HEAD -> migrate-pump-limit, dnzxy/migrate-pump-limit) Add missing parameter for save function

screenshot of build failure:

work-around - not sure what this does - added a dummy print statement after the case statement with the error.

That's what you get when doing this via the GH GUI in the morning before leaving for a work trip. Apologies. Should build fine now. Please check again @marionbarker .

Please - it should be a rule that no PR is created if you haven't built the change.

I spent a lot of time assuming it was me

Configuration 2: repeated

dbeb61fc (HEAD -> migrate-pump-limit, dnzxy/migrate-pump-limit) Address build failure by removing duplicate case
same results

In my opinion - if Save on Pump fails - it should give an error message to the user, not just restore the Pump Settings screen to what was there before you made the request.

Apologies, again.
I simply wanted to migrate this sooner rather than later and not have it sit around. Typical copy-paste issue.

In my opinion - if Save on Pump fails - it should give an error message to the user, not just restore the Pump Settings screen to what was there before you made the request.

This is a 1:1 migration of the initial PR, I haven't changed or touched any error handling.

Test with Dana
This needs more work - see Configuration 4 - need to see an error message, not a spinning icon.
Configuration 3:

switch to feat/dana with latest dev from DanaKit:

updates to DanaKit:
* DanaKit 489c310...3642042 (5):
  > fix: Fix typo
  > i18n: Fix translations with appEnv
  > Merge remote-tracking branch 'loopandlearn/enable_appName' into HEAD
  > fix: fix minor errors
  > fix: Several fixes & features (see iAPS for more details)

Test: Attach the dana-simulator to this build of Trio:

Attempt to modify Pump Setting by changing maxBolus from 4 to 5
Silent failure - have to leave and return to pump settings screen to see it is still at 4

Xcode debug log:
DanaKitPumpManager.swift - syncDeliveryLimits(limits:completion:)#1064: Skipping sync delivery limits (not supported by dana). Fetching current settings
Type: Info | Timestamp: 2024-06-03 13:46:49.187844-07:00 | Process: FreeAPS | Library: DanaKit | Subsystem: com.randallknutson.DanaKit | Category: DanaKitPumpManager | TID: 0x1940f9

Configuration 3:

Created a patch from git diff alpha migrate-pump-limit
Apply patch to current feat/dev (with updated DanaKit)
same error as before - but Trio displays the spinning saving icon until you leave and resume.

I'm sorry, I really cannot follow what you are applying on top of what and updating where. There is no Configuration 4 in your last comment. I'm assuming it's the 2nd "Configuration 3"?
According to @bastiaanv , this PR should work on top of latest feat/dana (which should be based on latest dev) + PR #263 applied too.
The compile error you had listed earlier was due to me not removing a line that should have been removed and be solved. Building fine on my end here now.

The silent error might be related to the simulator instead of the PR @marionbarker
Could you check the output of the simulator, there is a big chance that it gave the Unsupported error there.
The xcode log is to be correct. I want to let the dev know we cannot set the setting, only fetch

@bastiaanv could you clarify the flow of data here real quick for me.
User sets setting -> sent to pump -> tries to set it -> in either case it returns to pump manager, i.e. the app, with set settings (on pump) -> if nil (unsuccessful), it sets the entered settings again (?) in UI.
Is this correct and intended like so?

@bjornoleh Reading over this and how I think it functions (and mega reservation there: I'm not sure I understand :P), how does this fix 247 for Medtronic pumps that allow values higher than 25U (when manually set on the pump)? Is that because it'll try to set, fail, but then read from pumpManager, sees its set to 50U (or whatever ;)) anyway and thus sets that as the maxBolus value?
If that is how it works, I do think one thing may be important (unless I misunderstood how this works): if it fails to set the value the user asks, it shouldn't automatically assume that what's in the pump is what the user wants; rather it should error out if the desired value (entered in app) does not match the value obtained from the pump. This prevents the app from being set to a value the user did not intend it to be set to.
Scenario: let's say a user wants to set a 10U MaxBolus (as guardrail), but this cannot be set because the Dana pump doesn't allow remote updating the value. The Dana itself is set to 25U. If Trio then automagically updates the value from 10U to 25U because that's what's in the pump: the user may inadvertently end up with a value that is more than twice higher than what they intended to set. The same with Medtronic: user tries to set a value higher than 25U, let's say 40U. This cannot be set remotely, so it'll fail. The Medtronic pump has the value of 40U manually set in it by the user. In this scenario, if the pump is polled: the 40U entered by the user and the 40U on the pump will match so it's fine. But if the pump is set to 35U: it should error out as its not the value the user desired to be set and it cannot be set remotely.
If that makes sense. Sorry if I misunderstood what this PR is supposed to do, this is what I made of it.

Kinda. The function doesnt return nil, but should always return .success (with the applied values) or .failed (or something like that).
The silent fail is a danakit bug, where the simulator doesnt return anything and the write command doesnt have a timeout to make sure the cycle is completed. A situation which is only possible by a poor simulator implementation 😅

The silent error might be related to the simulator instead of the PR @marionbarker
Could you check the output of the simulator, there is a big chance that it gave the Unsupported error there.
The xcode log is to be correct. I want to let the dev know we cannot set the setting, only fetch

The simulator says:
2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ENCRYPTION__PUMP_CHECK - Data: paUO8RDluF2jowOcxSaSxSYgXlpa
2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ENCRYPTION__TIME_INFORMATION - Data: paUD8RGq2TlaWg==
Doing second lvl decryption
2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ETC__KEEP_CONNECTION - Data: AA==
Doing second lvl decryption
2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_REVIEW__INITIAL_SCREEN_INFORMATION - Data: AAAAAPpddAAAZGQAAAAAAA==
2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ENCRYPTION__PUMP_CHECK - Data: paUO8RDluF2jowOcxSaSxSYgXlpa
2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ENCRYPTION__TIME_INFORMATION - Data: paUD8RGq2TlaWg==
Doing second lvl decryption
2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ETC__KEEP_CONNECTION - Data: AA==
Doing second lvl decryption
2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_REVIEW__INITIAL_SCREEN_INFORMATION - Data: AAAAAPpddAAAZGQAAAAAAA==
Doing second lvl decryption
2024-06-03T14:32:08-07:00 ERROR: UNIMPLEMENTED COMMAND: 103

Kinda. The function doesnt return nil, but always return .success (with the applied values) or .failure (for when something goes wrong).
The silent fail is a danakit bug, where the simulator doesnt return anything and the write command doesnt have a timeout to make sure the cycle is completed. A situation which is only possible by a poor simulator implementation 😅
If something goes wrong (aka .failure is hit), I think trio reads the settings again and restores those values, but I didnt check that flow

Thanks for clarifying. I had assumed nil because of the nullish coalesce that's being used within that closure.

The silent error might be related to the simulator instead of the PR @marionbarker

Could you check the output of the simulator, there is a big chance that it gave the Unsupported error there.

The xcode log is to be correct. I want to let the dev know we cannot set the setting, only fetch

The simulator says:

2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ENCRYPTION__PUMP_CHECK - Data: paUO8RDluF2jowOcxSaSxSYgXlpa

2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ENCRYPTION__TIME_INFORMATION - Data: paUD8RGq2TlaWg==

Doing second lvl decryption

2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_ETC__KEEP_CONNECTION - Data: AA==

Doing second lvl decryption

2024-06-03T14:31:48-07:00 INFO: Sending OPCODE_REVIEW__INITIAL_SCREEN_INFORMATION - Data: AAAAAPpddAAAZGQAAAAAAA==

2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ENCRYPTION__PUMP_CHECK - Data: paUO8RDluF2jowOcxSaSxSYgXlpa

2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ENCRYPTION__TIME_INFORMATION - Data: paUD8RGq2TlaWg==

Doing second lvl decryption

2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_ETC__KEEP_CONNECTION - Data: AA==

Doing second lvl decryption

2024-06-03T14:32:08-07:00 INFO: Sending OPCODE_REVIEW__INITIAL_SCREEN_INFORMATION - Data: AAAAAPpddAAAZGQAAAAAAA==

Doing second lvl decryption

2024-06-03T14:32:08-07:00 ERROR: UNIMPLEMENTED COMMAND: 103

Ah yes, so that is a mistake on my part. To fetch the max basal and max bolus from the pump, I need to issue two commands which arent implemented on the simulator. So testing on the dana simulator is useless and doesnt reflect how the fix/feature works

So testing on the dana simulator is useless and doesnt reflect how the fix/feature works

How can we verify this works then to merge it?

@LiroyvH This PR makes Trio behave the same way as Loop does now. When the command was succesful, use the value from the pumpManager instead of the user input. DanaKit will always return something else than the user input, so that is why this is important for the Dana project. But the pumpManager itself should return a error if the input isnt supported (or return the current limits). This last part is besides this PR. This PR only makes Trio behave the same way Loop does now

I understand adding an alert may be out of scope of this PR. But should be added to future work.
Trio is silent with a real Medtronic pump. By silent, I mean the Pump Settings screen returns to prior value but doesn't say it cannot save.
Loop doesn't report an error for too large a value because the guardrails will not allow you to send anything greater than what is allowed (by Loop). For my MDT 515, the max is 25 U (same as the guardrails).

If the rileylink is powered off, the modal alert that RL can't be found is prompt.
If the pump is out of range of the RL, takes longer but an Unable to Save alert is displayed.

Loop doesn't report an error for too large a value because the guardrails will not allow you to send anything greater than what is allowed (by Loop). For my MDT 515, the max is 25 U (same as the guardrails).

I think this is exactly what should not be hard-set by the app but through the pump looking at #247 and at @LiroyvH 's comment.
Thanks for your rigid testing :)

@Sjoerd-Bo3 , I think you already approved this PR before some later commit. Would you take another look? Thanks!


indicator

if user want to change the indicator from center to left or right

You can check this: https://github.com/denzcoskun/ImageSlideshow/issues/34


Problem with Windows Line Endings

Windows line endings \r\n currently make pfasta give up and create an unexpected error message. It should probably just be agnostic to line endings.
(Might be fixed in pfasta14, already. Have to run further tests.)

Fixed in v14.


Prepare for Loud Release

After the silent release, I want to continue developing the software so that I can make a public post and direct people toward it, probably through Chief Delphi.
List of items that need to be completed for the loud release:

[ ] Update Backend to cross-compile binaries for multiple platforms and provide those binaries here
[ ] Provide most of the same functionality as current Phoenix Tuner

[ ] Install temporary diag server
[x] Every option under CAN Devices tab (Minus update all devices)
[ ] Configs
[x] Self Test
[x] Server Version
[x] Server Status
[x] Factory Default

[ ] Cross-Compile and "Release" binaries for easy installation

[x] Tarball/packages for linux
[ ] Zip for windows

Gonna break these issues up into separate issue-trackers.


update .gitignore

Signed-off-by: Kyle Zhang<EMAIL_ADDRESS>

What is the benefit of this CL?
Asking because the build process documented in the README will place all output in a directory, and we already have the most popular directory names covered.

@pwnall You are right. Because the upstream has switched to CMake, so for most of the case, all these files would be put in the build directory. So there is no benefit.
I met this problem because I always switched between upstream and old versions which are using Makefile. In this case, ignoring these files would be helpful. But this should not be a common case.