Implement "Useful Ranges"

Originally reported by: lisa ballard (Bitbucket: basilleaf, GitHub: basilleaf)

Useful Ranges were never ported to OPUS 2 but they appear in OPUS 1

Bitbucket: https://bitbucket.org/ringsnode/opus2/issue/162

Implementation ideas:

The details of "useful ranges" should be maintained in Python and served to the JavaScript along with a numerical input widget. The useful ranges can be encoded as a list containing a series of descriptions and value ranges.
The useful ranges will be available as a popup box or as a selectable dropdown menu. When a range is chosen, the numerical fields will be filled in.

Also, to support the example given in the original bug report, the JSON should allow the encoding of categories, with each category containing its own set of descriptions and value ranges.

Another good thing for ranges would be wavelength - for example, have selections for each useful color along with its wavelength range.

From Matt:
I wonder whether some ring features might be ill-suited to this type of treatment.  The Methone ring, for example, not only has very fuzzy boundaries but is very faint.  It is not going to be visible in the vast majority of images turned up by any search governed simply by an inner and outer boundary.

From Mark:
True. Of course, the user can also constrain the search to high phase angles, which would make sense in the case of the Methone ring.
Beyond that, we have wanted to add the ability to constrain an image search based on sensitivity, e.g., minimum detectable I/F. I think Rob has figured out a rough mapping from ISS filter names and exposure time to I/F per DN, which is basically what we would need to implement that.

From Matt:
I think my suggestion is that maybe certain rings should not be in OPUS in this way.  My reasoning is that we shouldn’t advertise that we do something unless we are confident we can do it well, and I think current searches we can enable for these structures will mostly yield data that don’t show those structures.
Just limiting to those that have been mentioned here, I’d suggest this for the Methone ring, Anthe ring, Pallene ring, and the Unnamed ring of Neptune (which is the Galatea co-orbital, no?).
The same may be true of the Arago ring, which is a faint and fuzzy appendage that extends outward from the Le Verrier ring.
Colwell et al. (2009, Saturn book) pointed out that the Dawes Ringlet is actually not a true ringlet, as it is not separated from the main disk on the inward side.  They called it an “embedded ringlet,” which is the same category as the plateaux in the C ring.  They do fix the outer boundary at 90200, which is what Danny answered.


mercury.pc contains MERCURY_LIBRARY-NOTFOUND

Describe the bug
Since 550423af6a76e2b87bccd8909cefef7de461b090, the mercury.pc file has been generated with Libs: -L${libdir}  -lmercury_hl -lmercury -lMERCURY_LIBRARY-NOTFOUND -lmercury_util -lna.
To Reproduce
Steps to reproduce the behavior:

git checkout 550423af6a76e2b87bccd8909cefef7de461b090 or git checkout master && git pull
mkdir -p build && cd build && rm -rf *
cmake .. -DCMAKE_INSTALL_PREFIX=$SWHOME/mercury && make && make install
cat $SWHOME/mercury/lib/pkgconfig/mercury.pc or pkg-config --libs mercury

Expected behavior
The mercury.pc file should contain Libs: -L${libdir}  -lmercury_hl -lmercury -lmchecksum -lmercury_util -lna.
Platform (please complete the following information):

CentOS 7
gcc-8, gcc-9
No/Any plugin
CMake 3.17

hmm I was pretty sure that I had that sorted out. Could you please make sure that you've done a git submodule update?

That fixed it.


Can't build.

https://cdn.discordapp.com/attachments/555462289851940864/773569195417141268/unknown.png
The package manager times out when trying to reach slimefun. Please fix.

@KoxSosen This should be fixed in the latest update.

If you have issues with any repo, you can always provide your own source.


enable serial terminal interaction

PR to enable executeCommandInHostOs() in tests to use serial terminal as an option, instead of ssh
The main use cases were:

in cases where we have a connectivity issue, we have no way into the DUT, this would allow for that. Currently we jsut get "could not reoslve xyz.local" and we can't determine if the DUT didn't boot or there was a connection issue
we will actually be able to do the dev/prod serial tests (we're not at the moment)
will allow us to do tests where we disrupt the network connectivity - e.g to test the NM recovery mechanism alex and zahari were discussing

Notes on implementation:

the "execute this command on serial terminal at device /dev/* and collect the exit code and response" is implemented here<EMAIL_ADDRESS>It deals with the login prompts, retries, and managing the shell. This was generic functionality that's potentially useful elsewhere, so its a package
on the qemu worker, I had to enable the -serial pty option to make qemu output the devices serial port to a pseudo terminal. The resulting /dev/pts/* device is allocated at runtime, so I had to also check and parse the stdout from qemu-system to extract it
for autokit, env vars are used at the moment to denote the serial device name, baudrate etc.
the serial device that is used is only visible in the worker container. So to run commands over it from the tests in the core container, the only solution I could come up with was to use a new endpoint - which I don't love. But using socat to forward the serial port over the network is another option, but requires more socat hopping and further mess - I'm open to trying it if people think its worth the effort. Ultimately I think worker and core will be merged at some point, so might not be worth jumping through those hoops
right now it only works with root user in the DUT serial terminal.
There is a PR that needs to be made to core, to the executeCommandInHostOS function to allow for it to use serial instead of ssh as the communication channel, will update this when its made

Change-type: patch

No objections from me. What is the main use case or benefit of adding this?

sorry @alexgg @klutchell I had opened this PR the other week just to test flowzone out (it was during that point where alexes PR got caught in the required checks deadlock) it wasn't ready for a review
I hadn't looked at it since then, but will come back to it now. The main use cases were:

in cases where we have a connectivity issue, we have no way into the DUT, this would allow for that. Currently we jsut get "could not reoslve xyz.local" and we can't determine if the DUT didn't boot or there was a connection issue
we will actually be able to do the dev/prod serial tests (we're not at the moment)
will allow us to do tests where we disrupt the network connectivity - e.g to test the NM recovery mechanism alex and zahari were discussing

@balena-ci I self-certify!


LSP client performing an invalid cast

Folks, I'm from the Visual Studio reliability team at @ Microsoft. Our telemetry has caught an issue where Porting Assistant extension is performing an invalid cast here:
https://github.com/aws/porting-assistant-dotnet-visual-studio-ide-extension/blob/1edd8fd4bb0f2308451822704ffd630f82153ca5/src/PortingAssistantExtensionClientShared/PortingAssistantLanguageClient.cs#L275
This issue has been hit almost 200,000 times over the past 21 days, sometimes hundreds a times a Visual Studio session.
Unable to cast object of type 'System.Threading.Tasks.Task' to type 'System.Threading.Tasks.Task`1[Microsoft.VisualStudio.LanguageServer.Client.InitializationFailureContext]'

Please change this code to something like:
InitializationFailureContext initializationFailureContext = new()
{
    FailureMessage = ...
};

return Task.FromResult<InitializationFailureContext?>(initializationFailureContext);

Thanks David for identifying above issue. We are looking into fixing it.


previous url in session and logins

not really a bug but wanted to figure out how to get round it.
i have:
/login
/logout
if a logged in user visits logout, it logs them out, then redirects them to the login page with a logged out message (pretty standard).
now IF a user then logs back in right away the /login route logs them in and does a:
return redirect()->intended('/dashboard');

problem is there "intended" url seems to be picked up as /logout so it enters a loop and when you login it then redirects you to /logout.
sometimes i can see in the session url.intended but sometimes its not there. is this the only session variable i need to forget to prevent this from happening on the logout action?

Please ask questions on the forums.

Just saying, if OP figured this out, or found an article, or something.. it woulda been cool if he posted a link to it here :( was so excited to finally find someone with my issue, lol


to_lower() method bug in Russian (cyrillic)

Godot version:
3.1 beta 11
OS/device including version:
Windows 10 x64 intel i5 10gb RAM GF 660 GTX
Issue description:
to_lower() doesn't work for russian as it expected. It left almost half of letters in upper case.
Steps to reproduce:
	var caps  = "АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ" 	print(caps.to_lower())
the result will be:
абвгдеЁжзийклмнопрстуФХЦЧШЩЪЫЬЭЮЯ
as you can see the letter "Ё" and from "Ф" to "Я" are yet capitalized.

The relevant code is in https://github.com/godotengine/godot/blob/master/core/ucaps.h
Might need extra entries for the Cyrillic letters which don't match a Latin letter.


Update flagged words for vietnamese

Updated flagged words for Vietnamese that only associated with pornographic documents,
removed all words that can be used in medical, scientific, colloquial, insults, race, sexual orientation.

Thank you @Luvata for your help!


Deletes items if inventory is full.

If I have a full inventory, and choose an item I have of in my inventory while ghost mode is active, it deletes the stack held. Also the case if I choose the item first, and then enables ghost mode with the item in cursor.

Hi, thanks for finding this! I just fixed it and published an update.

I was really surprised when I saw the update for it and how quick you were
at fixing it. Hahaha.
On Sat, Nov 9, 2024 at 7:39 PM Mike Brady @.***> wrote:

Hi, thanks for finding this! I just fixed it and published an update.
—
Reply to this email directly, view it on GitHub
https://github.com/mike-brady/factorio-ghost-mode/issues/1#issuecomment-2466406089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOZZKMQMPDVSOBGXLQPGKDZ7ZJELAVCNFSM6AAAAABRO6DIHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGQYDMMBYHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Various fonts don't support extended characters, or don't have support enabled.

On the beta site there are several inspirational quotes which are being displayed in the Satisfy font. That font face includes only Latin characters, which means non-latin languages are being displayed with a fall-back font, which in turn usually ends up being plain upright serif or sans-serif default font.
The font face should instead be change to one that supports as many scripts as possible, in the spirit of the openness of eOS.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8657375-quotes-font-doesn-t-support-extended-characters?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F10548672&utm_medium=issues&utm_source=github).

If you can find a more suitable cryllic fallback, I'd be happy to add it after Satisfy. I don't think we want to change the design for everyone, but I understand that fall back straight to the default sans is not desirable.

It's fairly easy to find a similar font with just Latin and Cyrillic ranges, but I think it would be a better idea to have at least a few more scripts supported, like Arabic, Greek and Hebrew. I'll look around and get back to you.

And Raleway also has some problems in that regard. For example in Polish it looks like this:

I also noticed that. This occurs in almost all languages except English, since unfortunately out of 3 fonts in use on the new beta site, two only support ANSI characters . This makes translated versions quite inconsistent and looking drastically different from the original idea.
In addition, I only remembered after my previous reply, that the CSS fallback font option will not resolve this problem, since the site uses CSS @font-face feature to locate the needed fonts. A CSS fallback font will be used only in case when the previous (main) font can not be located. Since the specified font is found on line, it will always be available, and thus will always be used, no matter what the fallback options are. On the other hand, since the main font lacks most of the non-english characters, this will make major visual an UX issues on localized versions.
Now that said, it is probably not easy to find fonts which will at the same time a) match the designers' original idea, and b) have all the fonts easy. Especially if we're talking only about open licence fonts.
I would love to see ideas for an elegant sans-serif Raleway and Satisfy lookalikes, or alternatives, that at the same time have good unicode support, at least for Eurasian alphabets group.

https://developers.google.com/fonts/docs/getting_started#Subsets might fix some of these issues, but not all.

Open Sans is also affected.

Bumped from Wishlist to Confirmed, this is getting reported a lot.

You should replace Google Fonts with local fonts to fix the problem. In the Google Fonts missing Raleway 3.0 with сyrillic support. Also, there is not a worthy replacement for the Satisfy, but I offer as a fallback Kobzar KS, this is beautiful and free font from Ukraine. Your thoughts?

"Express your love for Ukraine" what is that, some kind of a joke? Please leave your nationalism out of eOS.
Raleway 3.0 still only supports Latin in its italic styles. I can only see normal style Raleway on eOS site, but it's still worht mentioning.

@tomicakorac, it's nationalism? It's just a nice font, repeating writing of Taras Shevchenko. Do not complicate things. And if you're wondering, I'm Russian, but Ukrainian.

@tomicakorac Since when is annotation on the website is a sign of nationalism font? Are you kidding?

It has been said the Google Fonts will update to Raleway 3 soon, and the other fonts just need flags setting mostly. The exception is Satisfy, which we may need to find an alternative for.

Couldn't we drop Google fonts off et upload aa complete .ttf, then use @font-face ?

We could, but Google provide fonts in far more than just one format, and with specialised stylesheets to match the browser. All in all, proper font delivery is a pain. Besides, a "complete" TTF of most fonts doesn't exist, you'd need all the languages and glyphs, which would result in megabytes of data.

I think we're far better off agreeing to just add latin-extand let the font service handle all the complicated stuff.

https://fonts.googleapis.com/css?family=Open+Sans:400,300,600|Raleway:100|Droid+Sans+Mono&subset=latin,latin-ext

We could also look to add cyrillic and others when necessary, this is the full list.

https://fonts.googleapis.com/css?family=Raleway:100|Open+Sans:400,300,600|Droid+Sans+Mono|Satisfy&subset=latin,latin-ext,cyrillic,cyrillic-ext,vietnamese,greek,greek-ext

Well, when I say ".ttf", I mean with the .eot, .svg and all that stuff.
If we have the user langage, we could update the <link> asynchronously to get the correct font version.

That's a lot of management and maintenance. If we can group languages into one of these four groups, we could load that.
Latin

https://fonts.googleapis.com/css?family=Raleway:100|Open+Sans:400,300,600|Droid+Sans+Mono|Satisfy&subset=latin,latin-ext

Greek

https://fonts.googleapis.com/css?family=Raleway:100|Open+Sans:400,300,600|Droid+Sans+Mono|Satisfy&subset=latin,latin-ext,greek,greek-ext

Vietnamese

https://fonts.googleapis.com/css?family=Raleway:100|Open+Sans:400,300,600|Droid+Sans+Mono|Satisfy&subset=latin,latin-ext,vietnamese

Cyrillic

https://fonts.googleapis.com/css?family=Raleway:100|Open+Sans:400,300,600|Droid+Sans+Mono|Satisfy&subset=latin,latin-ext,cyrillic,cyrillic-ext

And what would be wrong with a link including all subsets ?

The problem is bandwidth->page load time. But I believe it's possible to load different subsets depending on locale, isn't it?

Yes of course it is, but we should do it in PHP using something like $_SERVER['HTTP_ACCEPT_LANGUAGE'], otherwise in JavaScript it won't be as reactive.

We already have a PHP variable for language, it's !empty($page['lang']) ? $page['lang'] : 'en'. Available languages are in _templates/l10n.php, we just need to categorize them into Latin, Greek, Vietnamese, Cyrillic.

@lewisgoddard why do it, if Raleway and Satisfy from Google Fonts support only Latin? Issue can not be solved without replace GF on independent storage.

Also, currently all modern browsers is supported .woff.
https://en.wikipedia.org/wiki/Web_Open_Font_Format

WOFF is incompatible with Opera Mini and older Android browsers, as well as IE before 9. This potentially breaks the site for over 1% of our users, or several thousand people a month.

@lewisgoddard well, how many users with different languages (with Cyrillic, Greek alphabets etc) we have? I bet there are many more.

@lewisgoddard But it just falls back to some default fonts, right? When I use Opera Mini on my old Symbian phone I don't expect the web to be pretty, just usable.

@png2378 I don't know which languages are affected, some letters outside of latin are included, and as I said, we can include more. With the exception of russian, I don't see any languages more than a fraction of a percent. My point is self-delivery is actively discouraged by most communities because it's a minefield, and there is not any one solution, although WOFF is probably the closest to it.

We've had 10 reports of this now, so I'm going to mark it as critical.

@tengwar It does, and that might actually be preferable, seeing as that would at least force some consistency.

Raleway
We know that Raleway has problems, and that these can be fixed with an upgrade to v3. We also know that Google has not updated this, although we could do that for them.
Raleway on Google Fonts - https://www.google.com/fonts/specimen/Raleway#charset
Raleway v3 - http://www.impallari.com/projects/update/100
Open Sans & Droid Sans Mono
Open Sans & Droid Sans Mono seem to be well supported.
Satisfy
I know that @danrabbit likes Satisfy, but most modern fonts have international support, while this one doesn't. If we include this with a fallback, then just those characters will be replaced by the fallback. Better then to simple find a replacement with more glyphs.

I'd upgrade to v3 and switch back to Gfont when available.

I agree, but I think we should file a pull request with their repository, they are tracking it at google/fonts#119
And we still need an alternative font for quotes.

"Marck Script" and "Bad Script" have Cyrillic and published under SIL Open Font License (OFL). I like it more "Marck Script".

Even though I am personally most interested to see support for Cyrillic range, I would still appreciate if we show dedication for true internationalization by choosing fonts that support at least several (more than 2) script ranges, like Greek, Arabic, Hebrew.
I am fully aware that it isn't an easy task, but I also do know that it's not impossible.

Cyrillic affects around 5-7% of our users. Greek and arabic don't even register as 1% together, and unfortunately hand-written scripts become more difficult in those ranges.

Open Sans & Droid Sans Mono
Actually, the currently developed version of that typeface design is Noto Sans, for which there is no monospaced version (for now), although it is planned.
The most recent Noto fonts have much more glyph coverage tan Droid and Open ever had, so it would make switching to Noto great for desktop as well (I know that is another bug).

As far as I am aware, Noto is the font by Google as a supplement to Roboto with better internationalisation but fewer weights and types. Neither of them replace Open Sans or Droid Sans, both of which were developed separately by Steve Matteson totally independent of Google. I do agree that Noto has better glyph coverage, however Open Sans and Droid Sans are inherited from the OS.

@lewisgoddard Noto is the successor of Droid; see http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/attachments/20151031/011f4334/attachment.mht
Open was just the commissioned brand version of the same design, not intended for UIs (lighter weights that are suited for display typography only, not body copy).
All three were developed at Monotype by Google's commission; Noto is the one in active development. Also, the Noto project is independent from the Roboto project, although both are used in AOSP.

Roboto is the default typeface, and carries a monospaced version. As I said, Noto is only used in Android when there are international requirements, something that doesn't usually carry through to monospaced.

This is the source repository for Roboto: Google’s signature family of fonts, the default font on Android and ChromeOS, and the recommended font for Google’s visual language, Material Design.

_https://github.com/google/roboto_

Noto's goal is to provide a beautiful reading experience for everyone and for all languages. With visual harmony when multiple languages share a page. With multiple styles and weights. And Freely available to all.
_https://github.com/googlei18n/noto-fonts_

Didn't get how does your last comment relate with what I said earlier (and to this issue, for that matter) Let's drop the off-topic.

Noto was suggested as a replacement for Open Sans and Droid fonts, but that's an OS decision. I was trying to point out that Noto isn't the successor of Droid. Open Sans, Roboto, and Noto are all based on Droid, but they aren't replacing it.
I can't see us dropping Open Sans or Droid anytime soon, maybe something to talk about for Loki with the UX Team.

Shift to Noto doesn't solve critical problem with Cyrillic alphabet, we need to find a substitute of Satisfy, right? I already offered Marck Script and Bad Script and I can continue search, if necessary.

Marck Script looks good to me. Let's replace satisfy with that

Great, thank you for quick answer.

@danrabbit what you think about Raleway 3.0? It is not in Google Fonts, but it supports the Cyrillic alphabet.

I'll write up a nice, big merge for getting those included from our site, and post another to the Google Fonts repository in the next couple of days.

We have now updated Raleway to include support for the following languages: Balkar, Belarusian, Bosnian, Chukchi, Crimean_Tartar, Erzya, Karachay, Kumyk, Lak, Macedonian, Moksha, Montenegrin, Nanai, Nogai, Rusyn, Serbian, and Ukranian.

Shouldn't this issue remain opened until there's a fallback font for Satisfy?
This Raleway upgrade is great, but this issue seems to be only partially fixed.

@aleksandar-todorovic Satisfy was replaced on Marck Script #948

Unfortunately, it is almost impossible to find fonts that will emulate the existing style for every language. So long as there is always a fallback font so there are no missing glyphs, I think this should remain closed.
This bug was a super-bug, designed to track the status of lots of similar bugs. Those bugs should now be reported separately against specific fonts for specific languages if a glyph is missing, usually represented by a rectangle.

The same issue affects Open Sans Light (perhaps regular one too, but the local version is used here, so IDK). There's no need to find alternatives. The version with more glyphs is already in Google Fonts, it just needs to be used.

@tengwar Could you file a separate issue with the affected pages and languages please? Right now I haven't seen any problems with Open Sans.

Okay, we'll just continue tracking it at #544


Change background colours of the button

Changing the background colours of the alert and buttons would be a nice to have feature.

no way to do it in UIAlertController


Add Thomas Montgomery to Contributors list

@TomMont Can you please rebase and resolve conflicts.

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Thanks for the information learning how to use Git's command line to do all
this.  I'm still not 100 percent on it as to "rebasing" and what conflicts
I had.  It seems you may have made the adjustments for me on your end.  If
you could fill me in?  And as I'm used to committing and pushing to my own
repositories through my IDE, this was different for me.  Is it better to
use Git's command line, GitHubs GUI, or your IDE to branch, merge, commit,
push project changes?  Thanks again for the first time attempt to commit to
an Open Source project!
On Mon, Apr 23, 2018 at 4:58 AM, Roshan Jossey<EMAIL_ADDRESS>wrote:

I'm quite elated about your pull request. I wanna evolve this project to
addresses various problems faced by first-time contributors. I'd love to
learn about your journey in open source community, the problems, pain
points you had etc.
Could you explain how you felt when you went through the tutorial, made a
pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app.
Could you please go to https://roshanjossey.github.
io/first-contributions/#social-share and share your first contribution to
open source? Also, check out projects with easy issues while you’re there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/3956#issuecomment-383521261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdxpXViqFzgotNt84fvZON2H_0yDW6W5ks5traXFgaJpZM4TVrlE
.

--
Tom Montgomery
KARK 4 - Production
Little Rock, AR
<EMAIL_ADDRESS>

@TomMont, take a look at these docs. https://github.com/Roshanjossey/first-contributions/blob/master/additional-material/git_workflow_senarios/keeping-your-fork-synced-with-this-repository.md and https://github.com/Roshanjossey/first-contributions/blob/master/additional-material/git_workflow_senarios/resolving-merge-conflicts.md
I wouldn't say one way of using git is better than the other. I use command line. Some of my colleagues are comfortable doing everything from IDE. I guess the important thing is to get very good at using one tool irrespective of what it is


Add a new parameter to the command "odo push --mode"

There is something that I don't like with the existing approach as we pass the name of the binary file to uploaded with the command odo create.
 odo create openjdk18 sb1 --binary ./target/ocp-fmp-build-install-1.0-exec.jar

As the developer will most probably change/rename the artifactId or version for java/vertc/spring boot projects, then the binary executable crated using the command mvn package will change.
By consequence, it is more logic that we pass such info to the odo push command
Example :

For source upload

odo push --mode source

For binary upload

odo push --mode binary <./path/binary/file>
odo push --mode binary ./target/cool-demo-1.0.0-SNAPSHOT-exec.jar

Hey @cmoulliard do you believe this is still an issue / we can close this, considering we've drastically have changed our style of workflow?

I will do a new test and then update the ticket @cdrage

@cmoulliard did you tested new workflow ?
AFAIK, we now store mode in local config file, hence no need to add --mode flag
Closing this issue, feel free to reopen for further discussion


Increase number of FP8 tensors per GEMM

@vasunvidia Please sign your commits (see CONTRIBUTING.rst)

/blossom-ci

@vasunvidia Please sign your commits (see CONTRIBUTING.rst)

@vasunvidia Please sign your commits (see CONTRIBUTING.rst)

Signed the commit. Thanks.

@ksivaman Could you review this? Thanks :-)!

/te-ci

/te-ci

/te-ci


Edit covid page with education changes

This adds a new "School closures, education, and childcare" section and
removes the "Education" subsection from "Check how coronavirus is
affecting public services".
Co-authored-by: Christopher Baines<EMAIL_ADDRESS>

Closed in favour of https://github.com/alphagov/collections/pull/1575


Amplify mock UnknownEndpoint: Inaccessible host: localhost' at port 62224'. This service may not be available in the `us-fake-1' region. | Failed to start API Mock endpoint Error: start has timed out!

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v17.0.1
Amplify CLI Version
6.3.1
What operating system are you using?
Mac 11.4 Big Sur
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
When i run amplify mock I am able to run queries/mutations from the explorer locally. However as soon as a I run my next js app yarn dev. Amplify mock stops working. I get the following error in the console.
Error while executing Local DynamoDB
{
    "version": "2018-05-29",
    "limit": 100,
    "operation": "Scan"
}
UnknownEndpoint: Inaccessible host: `localhost' at port `62224'. This service may not be available in the `us-fake-1' region.
    at Request.ENOTFOUND_ERROR (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/event_listeners.js:529:46)
    at Request.callListeners (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
    at Request.emit (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
    at Request.emit (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/request.js:686:14)
    at error (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/event_listeners.js:361:22)
    at ClientRequest.<anonymous> (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/aws-sdk/lib/http/node.js:99:9)
    at ClientRequest.emit (node:events:390:28)
    at ClientRequest.emit (node:domain:475:12)
    at Socket.socketErrorListener (node:_http_client:447:9)
    at Socket.emit (node:events:390:28)
    at Socket.emit (node:domain:475:12)
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  code: 'UnknownEndpoint',
  region: 'us-fake-1',
  hostname: 'localhost',
  retryable: true,
  originalError: Error: connect ECONNREFUSED ::1:62224
      at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1161:16) {
    errno: -61,
    code: 'NetworkingError',
    syscall: 'connect',
    address: '::1',
    port: 62224,
    region: 'us-fake-1',
    hostname: 'localhost',
    retryable: true,
    time: 2021-11-04T13:21:47.981Z
  },
  time: 2021-11-04T13:21:47.981Z
}

Then I kill the process and try run amplify mock again but this time I get the following error
Failed to start API Mock endpoint Error: start has timed out!
I have reinstalled all packages and still running into the same issue. I even tried creating a new project just to test it out but ran into the same issue. This also seems to only happen with my next js projects. Seems like as soon as the app gets compiled, amplify mocking stops working.
Expected behavior
This behavior is completely unexpected, I am not sure what happened as everything was working fine just a week ago. I have no idea what's going on. Any help would be greatly appreciated. Running a next js app shouldn't break the cli mocking capabilities. I am still learning this stuff and not even sure how to pinpoint to the root cause.
Reproduction steps

Run amplify mock
Run yarn dev on next js app
Run query

GraphQL schema(s)

type Blog @model {
  id: ID!
  name: String!
  posts: [Post] @connection(keyName: "byBlog", fields: ["id"])
}

type Post @model @key(name: "byBlog", fields: ["blogID"]) {
  id: ID!
  title: String!
  blogID: ID!
  blog: Blog @connection(fields: ["blogID"])
  comments: [Comment] @connection(keyName: "byPost", fields: ["id"])
}

type Comment @model @key(name: "byPost", fields: ["postID", "content"]) {
  id: ID!
  postID: ID!
  post: Post @connection(fields: ["postID"])
  content: String!
}

@akinwol can you check if the port 62224 is in use by running lsof -i -P?

I ended up resolving this
To solve I did the following

Ran sudo nano /etc/hosts

Doing that you get something like this

Deleted the ip6 ::1 localhost
Then ran sudo killall -HUP mDNSResponde  to flush dns cache

I was trying different things but that seemed to do the trick

I've been hitting this error lately as well. I tried the above command and that get's it running, but everything runs extremely slow.


Filament and Spatie Laraver custom getRouteKeyName fail

Package
filament/filament
Package Version
latest
Laravel Version
latest
Livewire Version
No response
PHP Version
8.2
Problem description
I'm using mcamara/laravel-localization and spatie/laravel-translatable and filamentphp/spatie-laravel-translatable-plugin
To make the models viewing and get the others languages correct slug I need to set the model getRouteKeyName as this:
    public function getRouteKeyName()
    {
        $currentLocale = App()->getLocale();
        return "slug->{$currentLocale}";
    }

but with this trick filament fail: [Missing required parameter for [Route: filament.admin.resources.categorie.edit] [URI: admin/categorie/{record}/edit] [Missing parameter: record].](http://<IP_ADDRESS>:8000/admin/categorie#top)
If I change the getRouteKeyName as this:
    public function getRouteKeyName()
    {
        return 'slug';
    }

Filament work, but the entry site not.
I tried to add protected static ?string $recordRouteKeyName = 'id'; (I don't care about slug in filament) but nothing change.
Expected behavior
Filament don't goes in error
Steps to reproduce
Make the same getRouteKeyName like me and tadan
Reproduction repository
https://github.com/icantdoit/
Relevant log output
No response

    public static function getPages(): array
    {
        return [
            'index' => Pages\ListCategories::route('/'),
            'create' => Pages\CreateCategories::route('/create'),
            'edit' => Pages\EditCategories::route('/{record:id}/edit'),
        ];
    }

If I my resource I do this, work!

No reproduction repository. Let me know when you have one and I'll reopen it.


Entity field cannot be private, jdk 9 with modules

Hello,
I've recently migrated my project to a module.
Everything was working fine before but since the change to modules I was getting:
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by lombok.javac.apt.LombokProcessor to field com.sun.tools.javac.processing.JavacProcessingEnvironment.discoveredProcs
WARNING: Please consider reporting this to the maintainers of lombok.javac.apt.LombokProcessor
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

I read here https://github.com/rzwitserloot/lombok/issues/1644#issuecomment-385882150 that is was fixed in edge. I installed the edge release, the warning is not showing anymore, but the error is still there.
Entity field cannot be private

I'm using jdk 9.
Did I miss something?
Thanks!

Turns out this was an issue with internal dependencies.
Sorry for the trouble 👍


Improve CLI Tools support on solution level

Now that we have dotnet cli tool support, we could improve that.
This is one possible root to enable CLI Tools on the solution level, possibly conflicting with https://github.com/fsprojects/Paket/issues/2249

[ ] Paket should be able to generate *.deps.json https://github.com/dotnet/cli/blob/master/Documentation/specs/runtime-configuration-file.md
[ ] Paket restore could generate "wrapper" scripts with the correct dotnet invocation, for example
paket-files/.bin/compile-fsc#!/bin/bash
"dotnet" \
    exec \
    --depsfile ~\.nuget\packages\.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json \
    --additionalprobingpath ~\.nuget\packages \
    ~\.nuget\packages\dotnet-compile-fsc\1.0.0-preview2-020000\lib\netcoreapp1.0\dotnet-compile-fsc.dll \
        $@

paket-files/.bin/compile-fsc.cmddotnet exec --depsfile C:\Users\<user>\.nuget\packages\.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json --additionalprobingpath C:\Users\<user>\.nuget\packages  C:\Users\<user>\.nuget\packages\dotnet-compile-fsc\1.0.0-preview2-020000\lib\netcoreapp1.0\dotnet-compile-fsc.dll  %*

[ ] Tell people to add "./paket-files/.bin" to PATH via
PATH="./paket-files/.bin:$PATH"
or SET PATH=paket-files\.bin;%PATH%
-> People can use dotnet tools directly on solution level for example
compile-fcs --help

Why is this conflicting with https://github.com/fsprojects/Paket/issues/2249? Because we could probably get away with generating project.assets.json as well instead of *.deps.json. But imho we should skip assets.json if possible. That file is owned by nuget while deps.json is owned by the runtime alone.
This would be a first step to simplify dotnet fable yarn-run start into fable yarn-run start.
Question is can we improve that even further to make it work on any folder within the solution folder?
Is this a way forward? What do you think?
/cc @enricosada @forki

Ok I think I have another idea (maybe a bit crazy).
Assume that for every cli tool we generate wrapper scripts in .nugetcache/.clitools
These scripts are version independent and call ".nugetcache/.paket/latest/paket.exe  $@"
paket will now invoke* the correct tool in the correct version by finding the current lockfile. We could even have "global" cli tools with this.
the only requirement would be to have ".nugetcache/.clitools" in path. Do you think this could work?
In case of a dotnet core paket version we would have a paket wrapper script in .clitools.
*note we could have another indirection to call the correct paket verion before calling the tool

CLI tools are already obsolete.


Needs a method to restore a signature

If you want to persist a signature across application launches, you need to save it first, using signatureImage. But you also need to restore a previously saved image back to the PPSSignatureView. Any idea how to do that?

Have you done anything to implement this functionality? It's something that I really need to use in my current project


How to change selected date background color and Stop dismissing view on click of dates

Hey @DevYeom, Thank you for this amazing library but I am facing some issues I want to change background color of selected date with Circle I had tried to change using following code but I won't be able to change it and I had comment every dismiss view method but then also view is getting dismissed I want to dismiss the view on specific button not on selected date. Please help!

Thanks for this issue 😃
I got you. So I will add some public properties to set background color of selected date and a dismissing option.
p.s. Please click a star for me and come again soon😎

Thanks for instant reply, I will Appreciate you work and please ping me once you made changes.

@CearsKhush
Hello!! Sorry for late!
I updated 1.2.1 to customize dayButtonStyle, selectedDayColor for you.
you just code as below.
calendar.dayButtonStyle = .circle
calendar.selectedDayColor = UIColor

But I didn't add the way you said the calendar disappeared. Because I have a plan to add a new calendar component in the next version, as you said.

@DevYeom Thank you soo Much :) <3


Fixed error printing function, was not properly formatting messages.

I suppose that fixing this should be around sprinln in LogFatal. Not arounf adding fmt to flow.go

Approved


merge package from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(scripts): posttest@markdown-doctest

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   74.36%   74.36%
=======================================
  Files           2        2
  Lines         476      476
=======================================
  Hits          354      354
  Misses        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f8166...fa22df4. Read the comment docs.

Coverage remained the same at 71.972% when pulling fa22df4503860136726f6d7ad5d5f0197ec02f19 on template-sync-1 into c8f8166f1ce2132390ed74570e6b3072a65663db on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update Composer dependencies (2022-01-05-00-11)

Visual regression test passed!
View the visual regression test report


Polygon ROI

Along the lines of the rectangle ROI but with the ability to specify multiple knot points.
Something like this: http://ttic.uchicago.edu/~smaji/projects/mturk/interfaces/segmentation/person.html?category-image=person,2011_000745_10.jpg which has some cool features for detecting a closed polygon and indicating such (floating dot gets larger when near initial point).
Also see OsiriX which has the feature albeit with some smoothing offered:
https://osirixpluginbasics.wordpress.com/2010/11/27/polygon-roi-tcpolygon-topolygon-tpencil/

The polygon tool is basically a specific version of: https://github.com/chafey/cornerstoneTools/issues/35.
Perhaps the freehand tool just needs an option to always force the "straight line mode".

this would be something nice to have, looking forward to this.

@JamesAPetts, I believe the freehand tool more closely resembles what this issue wanted to accomplish. Is that correct?
This issue has seen little activity in 2-years, so I'll close it for now. Feel free to comment if my assumptions are off, or if there are relevant action items for our freehand tool.


fix(select-field): spacing constants

Description

Fixes spacing.large constants to spacing.lg to reflect current Ignite styling better

b8e7836#diff-2cfc2bcb77c9036757ea29f2f5c67a870df99f0b4cbb6bf9cb3cc1397e6b5394R691

@yulolimum technically Josh Hart is a Trail Blazer so we good

b8e7836#diff-2cfc2bcb77c9036757ea29f2f5c67a870df99f0b4cbb6bf9cb3cc1397e6b5394R691

@yulolimum technically Josh Hart is a Trail Blazer so we good

also technically technically, Knicks are in the playoffs 😁


App shows "Your test result cannot be loaded. The response has no content"

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: iPhone 6s
iOS version: 14.5.1
App version: 2.2.1

Describe the bug
My app showed this message to me today, after I registered a Rapid Test yesterday:

After clicking on "OK", I was able to continue to use the app as normal, my test result was also still registered.
Steps to reproduce the issue

Open the Corona-Warn-App
Register a Test via the "Register your Test" box
Wait for some time - if you don't get a result the app shows this message after some time

Expected behaviour
This message should either
a) be suppressed - it does not have any useful information and only concerns the user or
b) has a link to an FAQ entry with further details.
Possible Fix
See above, either
a) surpress
b) Add "More Information" button which links to more information
Additional context

I registered a test which will be performed on the 15.05.2021.
This message is also shown for PCR-Test results, I saw this in earlier versions.

Internal Tracking-ID: EXPOSUREAPP-7265

It should be easy to reproduce this issue, if not, I can try to reproduce it and upload an error log.

@Ein-Tim
We have created a Jira ticket for your bug (EXPOSUREAPP-7265). Creating an error report could be useful, so why not? We can also test the new reporting feature this way :)

Corona-Warn-App Open Source Team

@heinezen
I'll try to create an error report but this could be difficult here because the error pops up instantly when opening the app, but not if I'm already in the app.
Thanks for mirroring to Jira!

I have the same error (in German). I registered my test with QR code on Friday. On Saturday morning I saw the message the first time. On Sunday morning the second time. I removed the test registration and tried to scan the QR code again, but now even registration fails with the same message.
Btw: Gesundheitsamt called me yesterday to tell me the result, so the old fashioned way works...

@calle2010
And I think exactly that is the problem with the message, the user thinks that the transfer does not work or so and will maybe remove the test (not knowing that he/she can't scan the Code again).
I did not remove the test and just ignored the message. The test result of my quick test was shown to me as expected, although I saw the error message at least 4 times before.
So, to summarise, the error message does not mean that the test result is broken, but only that it isn't there yet. This message does not contain any information useful for a normal user and will only lead to confusion, that's why it should be removed ASAP.

@calle2010 Thanks for letting us know. @Ein-Tim  Thanks for analysing.

Corona-Warn-App Open Source Team

If that makes a difference: in my case it was a PCR test.

I've sent an error report today at 15:09h. It's very long but it contains the pop up.
The pop up showed at:
14:06h & 14:58h
Error Report ID: B43D8B36747DC526D64E

Hi @Ein-Tim Thank you very much! Forwarded to internal ticket!

We cannot reproduce this anymore, so I would suggest closing this issue.
In general the error message is correct, so there might be an issue wth the RAT provider. We'll have to check if it happens again.

Corona-Warn-App Open Source Team

@heinezen I have no way to confirm this, but since the error seems to be fixed, I'll close this now.

Just experienced this yesterday with a PCR test again, I'd suggest to log this message but not show it to the user, as it has 0 information value for them. I'll open a new issue for this.

Reopened because the error happened again (https://github.com/corona-warn-app/cwa-app-ios/issues/2694#issuecomment-887373613).

Corona-Warn-App Open Source Team

This is still an issue under version 2.8. @heinezen is this intended? If not, I wonder why the pop-up was not removed?

@dsarkar
What exactly is the status here? The problem persists, even in 2.15.1.

@Ein-Tim In the previous reports, did the user eventually receive the result?

@dsarkar
Yes, the result was always received, the only unexpected thing is this pop-up.

@Ein-Tim ok, thanks for the info.

@dsarkar
For sure! I'm still voting for just removing this pop up, as it does not help the user in any way. The message should be logged if error logging is active, though.

@Ein-Tim ok, I forward this the ticket.

@Ein-Tim @calle2010 FYI: PR #4050

I will try to reproduce the error on version 2.17, when I'm not able to, I'll close the issue.

I wasn't able to reproduce this issue anymore, but a new issue appeared: https://github.com/corona-warn-app/cwa-app-ios/issues/4180
Closing this issue as fixed.


splitting matrices

i.e test/train data
maybe a function like:
matrix_t split_matrix(matrix_t &input_matrix, unsigned float size_percentage)


Getting AccessDenied: Access Denied when pushing to Deis (v2.7.0)

Used deis config:set DEIS_DEBUG=true
This is what I am seeing on v2.7.0
mbr-26367:infra-build-dashboard-capsm jwalters$ git push deis master
Counting objects: 53, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (21/21), done.
Writing objects: 100% (53/53), 9.40 KiB | 0 bytes/s, done.
Total 53 (delta 30), reused 53 (delta 30)
Starting build... but first, coffee!
+ unset DEIS_DEBUG
+ app_dir=/app
+ build_root=/tmp/build
+ cache_root=/tmp/cache
+ cache_file=/tmp/cache.tgz
+ env_root=/tmp/env
+ buildpack_root=/tmp/buildpacks
+ mkdir -p /app
+ mkdir -p /tmp/cache
+ mkdir -p /tmp/env
+ mkdir -p /tmp/buildpacks
+ mkdir -p /tmp/build/.profile.d
+ [[ -z home/dashboard-capsm:git-db49317c/tar ]]
+ get_object
2016/11/16 18:39:28 AccessDenied: Access Denied
remote: status code: 403, request id: 5BBF97B8E22E8D10
+ sleep_before_exit
+ sleep 3
remote: 2016/11/16 18:39:32 Error running git receive hook [Build pod exited with code 1, stopping build.]
To ssh://git@deis-builder.deis.k8.xxx.com:2222/dashboard-capsm.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@deis-builder.deis.k8.xxx.com:2222/dashboard-capsm.git'

This 403 Access Denied means that the object storage credentials shared with the builder (which passes it to slugbuilder in this case) does not have access rights to fetch said tarball.
The script in question is here: https://github.com/deis/slugbuilder/blob/master/rootfs/bin/get_object
What is your backing object store, and can you confirm that your credentials to S3/GCS/Azure are correct?

Looking at that now...

Its an S3 bucket which was previously working fine. Investigating

Pilot error. Setting AWS creds which are interfering with build.


docs: updated manual for bigquery

SUMMARY
I added information about required dependencies for running BigQuery with docker + info about required permissions for this.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12596 (597308f) into master (52ba82f) will decrease coverage by 9.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12596      +/-   ##
==========================================
- Coverage   66.83%   57.31%   -9.52%
==========================================
  Files        1015      959      -56
  Lines       49594    46863    -2731
  Branches     5081     4353     -728
==========================================
- Hits        33144    26859    -6285
- Misses      16320    20004    +3684
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
47.07% <ø> (-3.88%)
:arrow_down:

javascript
?

python
63.09% <ø> (-1.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ba82f...597308f. Read the comment docs.

Codecov Report

Merging #12596 (597308f) into master (52ba82f) will decrease coverage by 9.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12596      +/-   ##
==========================================
- Coverage   66.83%   57.31%   -9.52%
==========================================
  Files        1015      959      -56
  Lines       49594    46863    -2731
  Branches     5081     4353     -728
==========================================
- Hits        33144    26859    -6285
- Misses      16320    20004    +3684
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
47.07% <ø> (-3.88%)
:arrow_down:

javascript
?

python
63.09% <ø> (-1.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ba82f...597308f. Read the comment docs.

closing due to inactivity


java.lang.IllegalStateException: Session has been closed; further changes are illegal.

When calling cameraView.start(); I get the following exception:

java.lang.IllegalStateException: Session has been closed; further changes are illegal.
at android.hardware.camera2.impl.CameraCaptureSessionImpl.checkNotClosed(CameraCaptureSessionImpl.java:606)
at android.hardware.camera2.impl.CameraCaptureSessionImpl.setRepeatingRequest(CameraCaptureSessionImpl.java:227)
at com.google.android.cameraview.Camera2$3.onConfigured(Camera2.java:132)
at java.lang.reflect.Method.invoke(Native Method)
at android.hardware.camera2.dispatch.InvokeDispatcher.dispatch(InvokeDispatcher.java:39)
at android.hardware.camera2.dispatch.HandlerDispatcher$1.run(HandlerDispatcher.java:65)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6077)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

Note: I'm not calling it in onResume. Rather after the Camera permisison has been granted.

Seems like this is happening when the views visibility is initially set to GONE

I am facing the same issue when trying the sample: on first start after granting permission the app crashes. Subsequent starts are successful and the app is working as expected. I added a longer logcat output from my device - Sony Xperia Z3 / running on Android 6.0.1

9-17 17:11:19.133 31706-31783/com.google.android.cameraview.demo I/OpenGLRenderer: Initialized EGL, version 1.4
09-17 17:11:19.258 31706-31706/com.google.android.cameraview.demo I/Timeline: Timeline: Activity_idle id: android.os.BinderProxy@8d59087 time:634371044
09-17 17:11:22.079 31706-31706/com.google.android.cameraview.demo I/CameraManagerGlobal: Connecting to camera service
09-17 17:11:22.143 31706-31712/com.google.android.cameraview.demo W/art: Suspending all threads took: 16.824ms
09-17 17:11:22.161 31706-31706/com.google.android.cameraview.demo I/CameraManager: Using legacy camera HAL.
09-17 17:11:22.669 31706-31706/com.google.android.cameraview.demo D/MainActivity: onCameraOpened
09-17 17:11:22.675 31706-31706/com.google.android.cameraview.demo I/CameraDeviceState: Legacy camera service transitioning to state CONFIGURING
09-17 17:11:22.675 31706-32161/com.google.android.cameraview.demo I/RequestThread-0: Configure outputs: 2 surfaces configured.
09-17 17:11:22.675 31706-32161/com.google.android.cameraview.demo D/Camera: app passed NULL surface
09-17 17:11:22.680 31706-32161/com.google.android.cameraview.demo I/RequestThread-0: configureOutputs - set take picture size to 5248x3936
09-17 17:11:22.746 31706-31706/com.google.android.cameraview.demo I/CameraDeviceState: Legacy camera service transitioning to state IDLE
09-17 17:11:22.757 31706-31706/com.google.android.cameraview.demo I/CameraDeviceState: Legacy camera service transitioning to state CONFIGURING
09-17 17:11:22.758 31706-32161/com.google.android.cameraview.demo I/RequestThread-0: Configure outputs: 2 surfaces configured.
09-17 17:11:22.758 31706-32161/com.google.android.cameraview.demo D/Camera: app passed NULL surface
09-17 17:11:22.760 31706-32161/com.google.android.cameraview.demo W/RequestThread-0: configureOutputs - Will need to crop picture 2048x1536 into smallest bound size 1600x1200
09-17 17:11:22.761 31706-32161/com.google.android.cameraview.demo I/RequestThread-0: configureOutputs - set take picture size to 2048x1536
09-17 17:11:22.780 31706-31706/com.google.android.cameraview.demo I/CameraDeviceState: Legacy camera service transitioning to state IDLE
09-17 17:11:22.783 31706-31706/com.google.android.cameraview.demo W/PathParser: Points are too far apart 4.000000596046461
09-17 17:11:22.786 31706-31706/com.google.android.cameraview.demo D/AndroidRuntime: Shutting down VM
09-17 17:11:22.787 31706-31706/com.google.android.cameraview.demo E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.google.android.cameraview.demo, PID: 31706
java.lang.IllegalStateException: Session has been closed; further changes are illegal.
at android.hardware.camera2.impl.CameraCaptureSessionImpl.checkNotClosed(CameraCaptureSessionImpl.java:606)
at android.hardware.camera2.impl.CameraCaptureSessionImpl.setRepeatingRequest(CameraCaptureSessionImpl.java:227)
at com.google.android.cameraview.Camera2$3.onConfigured(Camera2.java:132)
at java.lang.reflect.Method.invoke(Native Method)
at android.hardware.camera2.dispatch.InvokeDispatcher.dispatch(InvokeDispatcher.java:39)
at android.hardware.camera2.dispatch.HandlerDispatcher$1.run(HandlerDispatcher.java:65)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:234)
at android.app.ActivityThread.main(ActivityThread.java:5526)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Note that this also seems to happen when you put your .stop call AFTER the super call in your onPause, instead of before. Could be the issue here as well.

Same problem happen to me on nexus 5x 7.0

Here is a temp workaround:
in camera2.java -> add this in line 134
 } catch (IllegalStateException e) {                 if (e.getMessage().contains("Session has been closed")) {                     start();                 }

Happens to me if you lock/unlock the screen. Same code added to a different empty Activity works just fine. Yet didn't find what so special about the first one.

Seeing this as well.

When I remove the callback in mPreview I no longer get this exception (i.e. remove https://github.com/google/cameraview/blob/master/library/src/main/api21/com/google/android/cameraview/Camera2.java#L191...L196). Is this safe to remove or would that have unintended consequences?

try to update to compile "com.android.support:support-v4:25.2.0"
finally it worked with me

Is this still being looked into? I'm getting this same error.

I can see the pull request, but is it going to be merged? The bug still exists

It seems like this was occurring for me when I setVisibility(VISIBLE) and then immediately attempted to start() the CameraView. My workaround: do the visibility change and post the start() to allow it time for the view to be ready. Seems to work!
view_main_camera.setVisibility(VISIBLE);
view_main_camera.post(new Runnable() {
  @Override
  public void run() {
    view_main_camera.start();
  }
});

Well, after try many ways, I got a kind of solution.
I just wanted when I stop the camera, I also want to hide the CameraView.
My first trying was like that, and I got the issue Session has been closed; further changes are illegal.
mCameraView.setVisibility(View.VISIBLE);
mCameraView.start();

mCameraView.stop();
mCameraView.setVisibility(View.GONE);

Then, I just had a look at the callback CameraView.Callback and I realised that it has two methods onCameraOpened() and onCameraClosed(). I just put the setVisibles in those methods and I didn't get more issues anymore.
private CameraView.Callback mCallback = new CameraView.Callback() {

        @Override public void onCameraOpened(CameraView cameraView) {
            Timber.v("onCameraOpened");
            mCameraView.setVisibility(View.VISIBLE);
        }

        @Override public void onCameraClosed(CameraView cameraView) {
            Timber.v("onCameraClosed");
            mCameraView.setVisibility(View.GONE);
        }

        @Override public void onPictureTaken(CameraView cameraView, final byte[] data) {}
}

Sorry for my english.

I guess some devices don't support some aspect ratios. The default aspect ratio is 4:3 and I was getting this error on LG G4. I tried changing the aspect ratio in onCameraOpened callback to 16:9 and it worked fine.
The code:
        @Override         public void onCameraOpened(CameraView cameraView) {             mCameraView.setAspectRatio(AspectRatio.of(16, 9));         }

Ended up switching to Fotoapparat.

No success here, what I had to do (no time as always) is that I implemented a onCrash() callback
so if it happens, I restart the camera activity and now all works well.
Yes yes, I know.


bench/bin: Add some common utils

Added some common utils. They were only used in my not-finished bench-mvcctxn before, but now someone else may need it.

LGTM


Fengtingtang

added content:

part1 diagram in media folder

added features:

showing current doc name on spreadsheet
create new doc on doc selection page

good diagram


Ability to configure embeddings dimension size

Moving from OllamaEmbeddings(model="llama2:13b") to OllamaEmbeddings(model="llama2:7b"), I am now getting a shape mismatch in my embeddings:
ValueError: shapes (4096,) and (5120,) not aligned: 4096 (dim 0) != 5120 (dim 0)

So the 7b embeddings is slightly smaller (4096) than 13b embeddings (5120).  Is there an argument or parameter I can use to control the embedding size?
I would like to artificially switch 7b to use 5120, so I can not rebuild my vector store.

This functionality from Nomic is nice. I am using TinyLlama / Llama2 for embeddings but would like the option to change dimensionality like Nomic has:   from nomic import embed response = embed.text(
texts=[prompt],
model='nomic-embed-text-v1.5',
task_type='search_document',
dimensionality=768
)   Is this enhancement possible?

I second this.

This functionality from Nomic is nice. I am using TinyLlama / Llama2 for embeddings but would like the option to change dimensionality like Nomic has: from nomic import embed response = embed.text( texts=[prompt], model='nomic-embed-text-v1.5', task_type='search_document', dimensionality=768 ) Is this enhancement possible?

In their latest v1.5 HuggingFace page, the user should be able to configure both the task_type and dimensionality. However, I have not been able to set these arguments with Ollama.

Agree, this type of functionality is critical for optimizing the embedding process and database size when storing embeddings.

FYI if the model has Matryoshka capabilities, cutting the vector to the desired size is straightforward. You just keep the most significant portion:

take the [0:length] part
normalize the result vector


Indicate if no builds exist

If the query type is build:

If there are builds print them.
In other case print there are no builds for that job

Just tested and works perfect. Great for UX, so +1 from me. I would advise to hold on and wait until we have working CI before merging, though

Thank you, Joan. You're right, I'll wait.


Restricted max line length 100 characters

Pull Request Test Coverage Report for Build 39

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 36:
0.0%

Covered Lines:
251

Relevant Lines:
251

💛  - Coveralls

Pull Request Test Coverage Report for Build 39

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 36:
0.0%

Covered Lines:
251

Relevant Lines:
251

💛  - Coveralls


no-raw-text should allow providing own custom text components

We have a Text-based wrapper component called ProjectText. There is currently no way of providing that to the rule.

I was also searching the same thing but for now, I solved like this "react-native/no-raw-text": [2, { skip: "ProjectText" }]

How did I miss that option? 🤦♂ Thanks mate


add section for performance and scalability

Do we want a dedicated page that shows things like https://github.com/istio/istio/wiki/Istio-Performance-oriented-setup-FAQ#automatic-proxy-injection and fortio.istio.io ?

yes it would present in a operator consumable way the perf related setup and tweaks,
inline (maybe iframe!) the key results from https://fortio.istio.io as well as IBM's setup
with explanations on how to interpret the results as well as key take aways from the Perf&Scale WG

will have a link to http://ibmcloud-perf.istio.io/regpatrol/ as well


Capybara-webkit not compiling on 1.9.3p0

I am having some issues installing Capybara-webkit when using Ruby 1.9.3p0
I didn't had any problem installing it on ruby-1.9.2-p290 or ruby-1.9.3-rc1
Output: http://pastebin.com/MjczXedx

I haven't gotten to try out capybara-webkit on 1.9.3 yet. I don't see an error in the above paste - is there anything interesting in the log file it mentioned?

Hi,
I reinstalled RVM and Homebrew and tried again to install capybara-webkit with 1.9.3p0. No problems at all. I guess there was some conflict somewhere.
Thanks!


Add artifact ui

This adds the page to associate a prep template and files with the study. It creates the prep template object and initial artifact to attach files to that object.
This is still waiting on the PR for programmatically getting the file_types associated with each of the artifact types.

Few comments added

A few comments.

Removed the WIP since it does all work now. Couple things still need to be discussed however.

@squirrelo can you pull from upstream/artifact-study-pages and fix the merge conflicts? I will review afterwards. Let me know when it is done.

Done, ready for review.

Why is the file qiita_db/support_files/test_data/uploads/1/uploaded_file.txt being removed from the repo? I think there are tests that depend on it, so add it back.
Done with the current review.

Comments addressed

More comments.

All addressed


Support Hot Swap on Remote Debug

Currently Hot Swap ('Run -> Reload Changed Classes') only works on 'Bazel Command' configurations. It would be great if I could connect to an already running JVM (IntelliJ 'Remote' configuration) and still be able to hot swap changes into it

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


Laravel 10

Issue Reference
#7444
Description
Hi, In this PR, I upgraded Laravel to 10.

Hi @AmooAti,
Please five me sometime, I will provide feedback.

@AmooAti,
Please add Vite support also.

I will provide you with more feedback when I start package testing and technical qa.

@devansh-webkul
Changing to vite was in my mind but in another PR :D
But it's ok I'll do it.

@devansh-webkul
Just to be sure, is there any plan for vue3?

Not at this stage. But for Vue 3, we will do it internally. Currently, just check the existing one.

Hi @AmooAti
We are working on brand new admin and front end design which will come in combination with Tailwind CSS and Vue3

Just for an update on this PR:
I migrated from mix to vite for the project's root (maybe lossless, but anyway :smile: ).
I'm having some issues with Admin and UI packages (jQuery is not working well), but I'm working on them also.

In that case, we can just leave it as it is. We can do it later on.

If PR is ready you can mark it ready for review. Just check the final version.

Hi @AmooAti ,
We are looking to make a new minor release v1.5.0 by next Monday and would be very happy to include your PR for Laravel 10 in that. Could you update us on when your PR will be ready for review again?

@devansh-webkul @saurav-webkul
Hi
I'm still working on those packages, but Laravel 10 is ok.

@devansh-webkul
I changed migrations for the expires_at column in the new migration.
Since old users don't have this column, 2023_04_11_192047_add_expires_at_to_personal_access_tokens_table.php will add it to the existing database, but it needs to add it to the default migration cause vendor: publish command, and some users may use it, and it will corrupt migrate command if a user tries to migrate a new database, So I'll check in 2023_04_11_192047_add_expires_at_to_personal_access_tokens_table to see if the column exists and do nothing

No need we already added bagisto:publish command specifically for our project. So we are not using vendor:publish because this will give all the vendor-specific data. If the developer does that means he knows what he is doing.

Just revert the last commit no need. We are not publishing in our bagisto:publish command.

In latest versions of laravel, now laravel is hiding all its provider classes, can you please check that,
https://github.com/laravel/laravel/blob/v10.1.1/config/app.php#L158

@jitendra-webkul sir,

Testcases are working fine.
The admin and Velocity theme is working fine.
Compilations are working in all the packages.

This pull request looks good to me.

@AmooAti thanks for the contribution, really appreciated.


Specifying id doesnt work for sub-menu data

Both menu-data and sub-menu-data have separate index count as normal, but for example if i have 2 icons in menu-data with id 0 and 1, then again 2 in sub-menu-data. The id for sub-menu-data seems to also start from 0. Manually setting up id as 2 or 3 doesnt work. When using debug(index) inside change callback it still outputs 0 and 1 for the items in submenu data whose value has been manually set to 2 and 3.

can you show me your slint code about that?

sorry my bad, i somehow thought item id was supposed to work as index. i was using if condition where if the index matched the menu it would open specific popover. though it seems like for menu data and sub menu data index are totally different i.e. the index for first item in menu-data is 0 and for sub-menu data first item index is also 0.
i later fixed it by using item.id instead of index though. Please correct me if I am wrong though.
here is the part of code that was problematic which has been fixed now.
menu2 := SMenu {
        menu-data: [
          {
            icon: @image-url("../assets/file.svg"),
            name: "open",
            id: 0
          },
          {
            icon: @image-url("../assets/search.svg"),
            name: "open",
            id: 1
          }
        ];

    sub-menu-data: [
      {
        icon: @image-url("../assets/avatar.svg"),
        name: "profile",
        id: 2
      },
      {
        icon: @image-url("../assets/setting-two.svg"),
        name: "setting",
        id: 3
      }
    ];

        change(index, item) => {
          if item.id == 0 {
            draw.close();
            menu1.active = 0;
          }
          if item.id == 1 {
            self.active = 1;
          }
          if item.id == 2 {
            self.active =2;
          }
          if item.id == 3 {
            self.active =3;
          }
        }
      }
      ```
     this is the code that i used which worked, in the previous one for which i raised issue was using index instead of item.id due to which setting id did nothing.


Fix: Ec2 : Add create_managed_prefix_list function

Fix: Ec2 : Add create_managed_prefix_list function
https://github.com/localstack/localstack/issues/4229

This functionality has been implemented by #4169 and #4181, so I'll close this one.


fix exists should not return null

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run buildall

run pipelinex_p0


Successful logon from IP and failure from a different IP query raises alerts which contain the same IP address instead of a different IP

Describe the bug
This query should raise an alert whenever someone logs in from a DIFFERENT IP while using the same application. The problem now is however that sometimes an incident gets raised that contains the same IP-address instead of a different one.
To Reproduce
Include the query inside your sentinel workspace. Try to trigger the alert.
Expected behavior
What I would expect to happen is that an alert only gets triggered when a different IP is being used instead of the same one.
Screenshots
https://imgur.com/gallery/ouoh4dc
Additional context
This could be fixed by filtering the query to not trigger when the SuccesIPAddress and FailedIPAddress are the same.

I see that this issue is already fixed in the newer version. We still run the outdated version. I will close this issue because of this. Sorry for the incovenience.


Fixed WordPress Version

The official download link does not properly identify the app version in the URL. As such,as soon as a new version is available, the URL will point to it, causing a validation error when attempting to validate the checksum.
I changed the version to 'latest' and removed the sha256 check to correct this issue and prevent future breakage.

@cedwardsmedia But it has an appcast, so we can take advantage of having a version, which is the whole point.
This will mitigates when we have automatic checks in place.


Docs updates for Applied Source Metadata

Contributions

[x] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
I'll find this, but it would probably be a page about docs generate that lists what adapters support what features.
What part(s) of the page would you like to see updated?
Add that dbt-redshift supports filtered get_catalog and metadata-based source freshness.
Additional information
No response

hey @mikealfare : if basically we just want a table that lists what's supported with what, i'm thinking that info can live on this page:
https://docs.getdbt.com/docs/dbt-cloud-apis/project-state
since it's the place where "Applied State" is talked about. thoughts?
for the table, do we want the rows to be adapter names and the columns to be the metadata?

Discovery API sounds right to me. I think that's where we ultimately surface this information anyway. @graciegoheen / @dbeatty10, does that sound right to you too? I think we would want the rows to be adapters as you mention, and then maybe a column for catalog information and a column for source freshness, each indicating the "level" of support for the information. So something like:
| Adapter       | Catalog     | Source Freshness      |
|===============|=============|=======================|
| dbt-snowflake | incremental | metadata-based        |
| dbt-spark     | manual run  | loaded_at field-based |

And then we should have something that explains the "level"s:
Source Freshness can be measured via metadata when the platform and adapter support it. This allows for calculating source freshness without a loaded_at field and without querying the table directly. This is much faster and more flexible. This can also be overridden if desired by providing a loaded_at field in the model config. If the platform/adapter do not support this, then using a loaded_at field is still an option.
The catalog can be built incrementally for adapters that support it. This allows for the catalog to be built along with the model, which eliminates the need to run a lengthy dbt docs generate at the end of a dbt run. For adapters that do not support incremental catalog generation, you will need to run dbt docs generate to build the catalog.
I would want someone else, either @nghi-ly, @graciegoheen, or @dbeatty10 to review the verbiage terms I use for this (e.g. loaded_at, "manual" vs. "incremental", "metadata-based" vs "field-based", etc.).


Calling airnode fixes

I have not been deleting anyone's branches after a merge. I have been leaving that up to the individual who created them.

I have not been deleting anyone's branches after a merge. I have been leaving that up to the individual who created them.

You can safely delete them, the author has the branch locally just in case.


Ledger lines

Ledger lines do not disappear when neumes are moved back onto the staff line. The also dont disappear when we use the "H" hotkey to hide the rendered MEI data.

They now disappear when moved, but they still do not disappear with the h hotkey or the opacity slider

fixed in a80f20d


Wakatime import fails with status 400

Describe the bug
Wakatime import fails with status 400, reproduce rate 5/5.

System information
Please provide information on:

Wakapi version: 2.8.1
Operating system: Ubuntu 22.10 x86_64
Database: SQLite

What's interesting is that the same API key works fine on wakapi.dev, the offical instance.

Interesting :thinking:. Could you do me a favor and post the result of running the following command shortly after you attempted an import?
curl https://wakatime.com/api/v1/users/current/data_dumps -H "Authorization: Basic $(echo '<your_api_key_here>' | base64)"

(you may want to redact parts of the actual download URLs returned, if there are any)

Sure, here you are:
root@Momoi:~# curl https://wakatime.com/api/v1/users/current/data_dumps -H "Authorization: Basic $(echo '<API-KEY>' | base64)"
{"data": [], "total": 0, "total_pages": 1}

More Information on the environment
I'm using a pre-built binary release, and have set up a systemd service for autostart and keep-alive:
root@Momoi:~# cat /etc/systemd/system/wakapi.service
[Unit]
Description=Wakapi
StartLimitIntervalSec=400
StartLimitBurst=3

[Service]
Type=simple

# Assuming Wakapi executable is under /opt/wakapi and config file at /etc
# Feel free to change this
WorkingDirectory=/opt/wakapi
ExecStart=/opt/wakapi/wakapi -config /etc/wakapi.yml

# sudo groupadd wakapi
# sudo useradd -g wakapi wakapi
User=wakapi
Group=wakapi
RuntimeDirectory=wakapi  # creates /run/wakapi, useful to place your socket file there

Restart=on-failure
RestartSec=90

# Security hardening
PrivateTmp=true
PrivateUsers=true
NoNewPrivileges=true
ProtectSystem=full
ProtectHome=true
ProtectKernelTunables=true
ProtectKernelModules=true
ProtectKernelLogs=true
ProtectControlGroups=true
PrivateDevices=true
CapabilityBoundingSet=CAP_NET_BIND_SERVICE
ProtectClock=true
RestrictSUIDSGID=true
ProtectHostname=true
ProtectProc=invisible

[Install]
WantedBy=multi-user.target

The instance is hosted on a DigitalOcean Droplet located in SGP1.

Glad to hear! I'll add some more detailed logging, to better debug issues like this next time.


Dashboard not running, w3m: Can't load http://localhost:8088.

The following error was seen in two systems:
1- docker on wsl2 on a windows system
2- docker desktop with linux debian

Following the README file, after deploying the experiment
# Deploy experiment
docker stack deploy -c topology.yaml kollaps_example

I tried to run the dashboard by different means, namely by running the commands:
w3m http://localhost:8088
or
w3m http://<IP_ADDRESS>:8088
or
sensible-browser http://localhost:8088
in wsl2 commandline
Entering the URL in a Firefox browser of my Ubuntu dual boot system does not work either.
The prior commands had successfully been run on both systems.

Hi, @Zahpak can you run docker logs god_### where is ### is the rest of the name of the god container and put the output here.

Yes, it is. It was only based on the tutorial I followed for installing docker on wsl2. But I also had the same issue with my dual-boot.
This is the specification for my dual-boot Ubuntu:
lsb_release -a

No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.4 LTS
Release:	20.04
Codename:	focal

Bootstrapper does not show up when I run docker container ls or docker ps, but only when I run docker service ls
Also the log for the kollaps_example_bootstrapper service returns nothing.
I can show the results in the attached picture:

I just did a fresh install of ubuntu 20.04 and followed the instructions there was indeed a file missing in the repo and the Kollaps image could not build properly if you pull and rebuild the Kollaps image it should work.

Yes! It's working for me as well. Thank you for your help and timely responses.


Tooltip for conducting equipment selection in substation section

When clicked on a conducting equipment, the icons does not have a tooltip when hovered.
Please add related tooltips that I don't have to write the meanings down somewhere until I memorized them.

I think this can be closed for now as we can see all LNode elements with show functions. Is that true @BurTah00

yes that is absolutely true @JakobVogelsang


WIP: Add shell script diagnostics to testnets build script.

Closes #1126
Description:

❤ Thank you!

I pushed a solution proposal. Can you verify this works? And maybe explain to me, why it works this way? ^^

That is SUPER mysterious!  We're running in Docker so shouldn't be getting a "works on my machine" error like this.  I can't think of any hypothesis that explains the problem.  Your workaround is not a good one and should be unnecessary.
Please try collaborating with someone local (Billy or Fede) and see if they notice anything, otherwise we can schedule a meeting to debug it together.

Your workaround is not a good one and should be unnecessary.

Can you elaborate why this is a bad solution?

Closed in favor of https://github.com/cosmos/voyager/pull/1176.


Fix credit, copyright and License

This project is a fork of Bivac, a Camptocamp project, under Apache 2.0 license. Can you please fix the copyright, add license back to Apache 2.0, and credit Camptocamp for its work?

Also, @cryptobioz and I mostly drink tea, not coffee :wink:

If you could explain what needs fixed that would be great. I went through the license carefully and everything seems compliant. Absolutely great work btw!

Please read carefully also https://en.wikipedia.org/wiki/Software_relicensing. Especially this part : "For successful relicensing the agreement of all involved copyright holders, typically the developers, to a changed license is required. While in the free and open-source domain achieving 100% coverage of all authors is often impossible due to the many contributors involved, often it is assumed that a great majority is sufficient.".

@codejamninja
I understand that under the Apache 2.0 license, you are technically allowed to copy the libraries from the Bivac project, add a copyright/license notice as a header to each of the files, and relicense the whole project under MIT.
However, I hope you understand that while it could be seen as somewhat flattering that our code would be worth such a process, it came as rather shocking to us to realize that the whole project was simply cloned and force-pushed into another project name, without a clear historical link (since you didn't fork), and that the README makes no mention whatsoever of our work. In fact, it claims you are the sole author, and even the list of commits to the project would seem to indicate you wrote most of it, since it counts commits to your archived branch, which has nothing do with Bivac.
As I was researching the project, I saw you have a volback-api repository, which seems quite interesting.
Besides legal issues, we would have thought it fair and constructive (although not legally mandatory) to share your intentions with us, as we believe the additions you are making are quite interesting.
This kind of events, which I believe is not intentional, is what makes some people say Open-Source is flawed as an intellectual property model. Again, it could be that we are at fault for choosing a very permissive license without measuring the possible repercussion (and in that case, it might just encourage us to switch our projects back to GPLv3 to avoid such situations in the future). I guess we just hoped open-source contributors had the habit of communicating their intent before forking projects entirely.
I hope you understand, and that we can have a fruitful collaboration.

You thought your response was long 😂
There is a tricky balance between contributing to a project versus forking a project and taking it in a new direction. I have contributed to hundreds of open source projects and almost always contribute with a pull request. The reasons are pretty straightforward.
#1 A community is already using the project
#2 It’s a burden to take on the responsibility of maintaining a project
#3 It’s more valuable to share work as opposed to taking projects in two different directions (there’s just more bandwidth)
#4 It’s just plain ole polite
However those advantages come at a cost (assuming it’s not your own project)
#1 you’re dependent on others accepting your work
#2 the development lifecycle is slower (for your own features)
#3 you have less control in the direction of the project
In most cases the advantages of pull requests far outweigh the alternative for obvious reasons, such as not having to maintain the project and having the advantage of getting awesome new features from future contributions.
However, there are a few cases where I choose to fully fork and maintain a project instead of contributing back. They are for one or many of the following reasons.
#1 I need the feature really bad and don’t have time to wait and wonder if my pull requests will get accepted
#2 The original project development is not active (aka the team is dead)
#3 My pull requests are ghosted
#4 I have different plans than the original teams plans
A good example of this is recommonmark, a markdown parser for sphinx. The project did not support markdown tables. I wrote a pull request to support tables which required using a different markdown engine. My pull requests were originally ghosted, but the for understandable reasons they were rejected (aka they didn’t want to switch markdown engines).
I ended up forking their project and created sphinx-markdown-parser
https://github.com/rtfd/recommonmark
https://github.com/codejamninja/sphinx-markdown-parser
In the case of bivac, the reason for forking the project is a combination of #1 and #4. I’ve been working on volback for several years (granted I got busy with other things and the project became stagnated). However when I finally got back to it, I discovered your codebase and found several things about it that were superior to my original approach. I thought about contributing, but after discovering that you were not interested in restore logic (plus a ton of features I am planning on), I decided to fork it so I could iterate quickly and take it in the direction I want. The reason I merged my old python code in was because I never delete code.
Ok, with that out of the way, I’m actually really pleased that you are reaching out, because I would be more than willing (in fact would be thrilled) to move my development back to bivac. However, the motivations for forking the project in the first place would need to be solved to a reasonable extent. I do believe that it would be mutually beneficial.
So, again #1 and #4 were the primary reasons for forking he project. #1 would be solved to a satisfactory level if you let me join the project (obviously standard procedures will be followed . . . I’m not going to just blow away your code or start dumping new features in without consensus. However I would like more flexibility than just forking and making pull requests in the dark. I have read through every line of code dozens of times and understand the architecture. (It would have been impossible to write he restore logic without understanding the pipeline end to end).
#4 would be solved if you let me go over my original plans for volback. Obviously it doesn’t need to perfectly match them, but I would like the freedom to move the project in that direction to some extent. So basically end game for volback is the following . . .
#1 backup and restore volumes
#2 support database dumps and restores
#3 compatible with kubernetes
#4 detailed user friendly high level api (with authentication) for managing backups
#5 slick web UI for managing backups
#6 ability to upload and move around snapshots (this will make it easy to migrate projects)
#7 high level functionality for migrating projects across platforms
So, thanks for taking your time to read this. My goal is not to rip off someone else’s work, but I’m not going to reinvent the wheel when I don’t have to. Oh, and one more thing, (this is super insignificant), I like the name volback better than the name bivac. Volback is a self explainable name.

Hopefully this comment won’t matter but I just feel like mentioning it. Based on your license, the developer is called camptocamp. If you want individual (human) developers to be required to be mentioned, then you need to add them to your license as developers. I would actually be breaking your license conditions if I mentioned them in the license because I’m not allowed to modify it.
However, that said, out of courtesy I have no problem referencing the developers.
Again, this may be a mute point if we join forces.

Thanks for your answer.
I'm pleased to hear your approach and your reasons for forking. While we have not been interested in implementing restore ourselves, I don't think we pushed it out of the scope of what we would be willing to accept in Bivac. Besides that, I don't really see anything that shocks me in your goals. Just wondering if maybe the UI could be developed as a separate repository, but that's a detail in a way.
Names… that's always the hardest part of software projects, isn't it? Bivac was actually initially named "Conplicity" because it was based on duplicity. There's been a whole issue over this: https://github.com/camptocamp/bivac/issues/88
As far as I'm concerned, I wouldn't see a problem in welcoming external contributors to this project. There's a gitter room where we can discuss and collaborate (until we move it to Slack, maybe…).

Ok, sounds good. I’ll turn this into a pull request. And yes, I’m going to build the high level api as a separate project as well. Loopback 4 has a very nice abstraction called repositories that will make it easy to wrap around the bivac cli.


Cannot find module ./cypress/commands/cypress/commands/

I am getting the following error:
Cannot find module './cypress/commands/cypress/commands/auth-commands.ts'

I have traced the error from the following line in src/plugin/index.ts:
  on('task', {
    importCustomCommands: () => {
      return {
        filePaths: globSync(`${COMMANDS_DIRECTORY}/**/*`, { nodir: true }),
        commandsDirectory: `cypress${sep}commands${sep}`
      };
    }
  });

to another line in src/index.ts:
 const customCommandObject = require(`../../../${projectName}cypress/commands/${filePath.replace(
        commandsDirectory,
        ''
      )}`);

Notice that sep depends on operating system in node context, but somehow I think that is different with the globing that happens, because I am on Windows and running the whole thing in bash. I think there should be a mix-up of paths somewhere between bash and the OS. To resolve this, I suggest that the commands path be configurable when one configs the plugin itself to make it less opinionated and prone to breaking in different envs.
For now doing the following should be fine.
  on('task', {
    importCustomCommands: () => {
      return {
        filePaths: globSync(`${COMMANDS_DIRECTORY}/**/*`, { nodir: true }),
        commandsDirectory:  new RegExp(`cypress[\\\\\\/]commands[\\\\\\/]`, 'g')
      };
    }
  });

This allows the replace statement used in beforeAll to replace the path regardless of the operating system's sep, hence the import statement can also be safely removed.

@emahuni Thanks for pointing this out! I do realize this plugin does not currently work with pnpm because of the require() statement, and also doesn't work with esbuild. I would like to refactor this to add support for both of these, since webpack is basically obsolete these days. However, I could see we would still get some value from simply importing a function that just calls Cypress.Commands.add() on everything in a module.
We can release a v2.0.0 that implements your addModuleCommands() idea. If you would like to contribute this I would encourage you to do so!

@emahuni Check out version 2.0.0, which contains substantial improvements!

I didn't see any scooped examples, are they still supported?

We can maybe add support later, but for now I'd recommend adding those commands separately with the desired prevSubject option. It would be difficult to support all use cases since there are many options Cypress offers for adding custom commands.


Using in QtCreator

Hello,
I am having troubles using this in QtCreator.
I have tried compiling it in VS2015, it works.
But I also get Linking Errors in QtCreator.
Can't I just include the headers and compile it into my application?
I have no idea at the moment where to start.

Ill post in about 7-8 hours

In general you can include headers and source files to build this project.
If you are using just regular VS, then you can generate a project using cmake,then add that as a reference to your current project.
You can review the https://github.com/smasherprog/Screen_Capture/blob/master/src/CMakeLists.txt  file for the platform specific files included.
Generally, you would just add the file above to your own cmake build process. But, it sounds like you arent using cmake.
Do you use vcpkg  at all? I am considering adding this project there . .

You can't just include headers and compile. It's not a single-header library. As an easy workaround, you can compile this lib separately and then use it in QtCreator just like any other lib. How to add libs

Thanks for the input SMemsky.
I am closing this issue. If you need more help post a comment and I'll try and help.

Hello, i compiled the lib and included it - now i got the follow error:

liblibScreen_Capture.a(GetMonitors.cpp.o): undefined reference to symbol 'XOpenDisplay'


Describe in documenration what is .errors

If can't parse input data plugin throws FNFE saying "... grammar.errors :  (The system cannot find the file specified)". What is expected to be in this file? Is it possible to note that in the documentation?

Yes, documentation can be added and potentially a bug fix. It will have to wait until the next release of the maven plugin, corresponding with the next release of Antlr4.


docs: Update docs regarding jest

Following current docs gives error 'TypeError: Cannot read property 'then' of undefined'

👋 Thank you for the suggestion. I have merged this now.


cache rc support

Hi @ncw
I've added support for the RC module in cache and updated documentation. I'm opening as a PR to discuss if I can add something more in the RC. To me, it looks final as it has all the support I initially wanted to add too.
I've also updated the docs of rc with the params.
PS: This is on a new branch cause I wanted to rebase master.

Let's link the issue too: https://github.com/ncw/rclone/issues/2111

I think that looks good..
Do you think rc has enough features for your use?
Thanks for updating the docs :-)
Do you want to merge this for v1.40 which I'm planning for next weekend 18th March?  I'll need to tidy rc up a bit before then if so!

@ncw 1.4 sounds great. It's enough for what I wanted to do so yep. Let me know if I can help contribute more to the rc code.
I'll have to fix the SetIndent support in cmd rc, will push again this evening

@ncw this looks done. wanna have a final look on it or can I merge it?

Can you split out the go1.6 compatibility  fixes for rc out of the cache fixes in fc47c5999bdea553e3af792a77f83fb503388842
Also can you fixup the title of f2d0d15a1a28109bdbf1c639ffd0895ff66a8fca so it doesn't say FIXME WIP in it before you merge :-)
After that merge away!

@ncw ok, done. I'm waiting for the tests to finish and will merge


Add Go 1.19 compatibility and test against 1.19 and 1.21

I believe our CI issues are a result of local linting against 1.21, while CI was linting against 1.20. This also adds 1.19 compatibility, matching some of our other foundational libraries in supporting the previous three versions of Go.

The actual issue involved the testing types, and names not being updated in the testdata files. This PR is replaced with https://github.com/bufbuild/protoyaml-go/pull/2.


Unique String ?

In your description, you talk about a unique string ID.
But I cannot find any code which guarantees that the string is unique.
Am I misunderstanding the description or am I missing the relevant code?
If there is no guarantee that the string is unique, maybe the word unique in the description should be removed.

Hey.
The point is that with the alphabet and default length (21 char), it will take ~ 149 billion years to have a 1% probability of at least one collision. This can be considered a unique string.
More about:

Birthday problem
Collisions

Thank you very much. I only want to be sure if I missed something in the code. I need to be sure that the strings are unique. Because that I wrapped nanoid to checks if any string already appeared before.
/close


feat: update overlord version

What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm