[YUNIKORN-2167] check webapp is ready in mockScheduler.Init

What is this PR for?
We start webservice in a goroutine. https://github.com/apache/yunikorn-core/blob/db70ca6e0ed46eb93362fc1bf48545781146f534/pkg/webservice/webservice.go#L71-L77
Sometime, client sends request before webservice is running (client.GetEvents faster than webservice in ms.Init). https://github.com/apache/yunikorn-core/blob/db70ca6e0ed46eb93362fc1bf48545781146f534/pkg/scheduler/tests/application_tracking_test.go#L45-L50
In this case, we will get application_tracking_test.go:51: assertion failed: error is not nil: Get "http://localhost:9080/ws/v1/events/batch": dial tcp [::1]:9080: connect: connection refused.
CI reference: https://github.com/apache/yunikorn-core/actions/runs/6920928414/job/18825954111
What type of PR is it?

[X] - Bug Fix

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2167

Just a minor thing @FrankYang0529 could you make sure that the commit message matches the PR/JIRA name? The person who merges the change might forget to rename it and we use this convention all the time.

Hi @pbacsko, I updated my code. Thanks for the review. One question, I'm not sure which part of my commit message doesn't match the Jira? It follows the rule in merge_pr.sh.

@FrankYang0529 the JIRA is called "Flaky test TestApplicationHistoryTracking".

@FrankYang0529 the JIRA is called "Flaky test TestApplicationHistoryTracking".

Got it. Thank you. I will take care of it next time.


Newtonsoft Calls Getter on Deserializing a Property

I created a simple class model (AnchorMetaData), shown below, in which there are two items. One is a list field (Vector3) that cannot be serialized due to how it's made so I created a property for class (SerializableVector3) that could serialize and deserialize. I hoped to use this property with Newtonsoft for saving/loading the model.
The class saves just fine however, when I try to deserialize the model from JSON it calls the AttachedTaskLocations property's getter rather than setter. That makes the field to be initialized to be empty.
I only noticed this by using logs message and making some breakpoints. It never calls the setter when deserializing. Which is very odd as it should function.
Another odd behaviour is that it does pause on setter of x, y, z of SerializableVector3 with the correct values from the file. This is super odd.
I'm working with Unity 2019.1.14 but this should work without it too, just change vector list to something you have.
When I load the shown JSON file, which was created by serializing AnchorMetaData it has zero items in attachedTaskLocations. Why is this happening? Why does the setter not get called?

Class I created to save/load Vector3 is called SerializableVector3.
Class I wish to save/load:
[Serializable]
public class AnchorMetaData
{
    // Cannot serialize this.
    [JsonIgnore]
    public List<Vector3> attachedTaskLocations = new List<Vector3>();

    /// <summary>
    /// This property servers as an interface for JSON de-/serialization.
    /// It uses a class that can be serialized by Newtonsoft.
    /// Should not be used in code except for serialization purposes.
    /// </summary>
    [JsonProperty("AttachedTaskLocations")]
    public List<SerializableVector3> AttachedTaskLocations
    {
        get
        {
            Debug.Log("Writing serialized vector.");
            return attachedTaskLocations
                .Select(vector3 => new SerializableVector3(vector3))
                .ToList();
        }
        set
        {
            Debug.Log("Loading serialized vector.");
            attachedTaskLocations = value
                .Select(sVector3 => new Vector3(sVector3.x, sVector3.y, sVector3.z))
                .ToList();
        }
    }

}

Serialized JSON:
{
  "AttachedTaskLocations": [
      {
        "x": 1.0,
        "y": 1.0,
        "z": 1.0
      },
      {
        "x": 1E+12,
        "y": 2.0,
        "z": 3.0
      },
      {
        "x": 0.0,
        "y": 0.0,
        "z": 0.0
      }
    ]
  }

Stack when breakpoint hits the getter on deserialize.

After some investigation I found that if the getter returns a non-null value it doesn't call setter ever with ObjectCreationHandling.Replace setting.
So I can get around this with a flag but it's ugly. I don't want it to return null value even if it's backing field is null; for safety reasons, would much rather return an empty list.
Is this the intended behavior?

See https://stackoverflow.com/a/58741804/3657151


TypeScript type only imports

Starting with TS 2.9.x we can do side-effect free imports. Not only does this reduce bundle sizes without the need for tree-shaking, but also guards from unwanted side-effects.
Such an example would be the vscode import in vscode-api.ts

I don't understand how vscode can be bundled and cause side-effects. It is just a declaration file which gets completely erased during compilation.

Yep, sorry my bad I dunno how I thought I'd have seen a transpiled import for vscode in the resulting lib folder.


Tapping a ScrollView during overscroll got it stuck.

Fixes https://github.com/flutter/flutter/issues/8476
More detailed list of changes in this patch:

Replaced the didTouch special logic with more generic logic that
uses Activities instead. Now instead when you tap down the
Scrollable calls hold() which begins a HoldScrollActivity which is
a hybrid of DragScrollActivity and IdleScrollActivity and can be
canceled. When you let go, it gets canceled and that goes ballistic.

Make DragGestureRecognizer more aggressive about grabbing pointers,
otherwise a second pointer in a situation with competing horizontal
and vertical recognizers always gets taken by the other one.

Fixed the _GestureSemantics widget to call the "down" callbacks so
that it follows the same pattern as "real" interactions.

Added tests for the above.

Added a hashCode to ScrollActivity.toString (and subclasses).

Added a toString to ScrollDragController, and include it in
DragScrollActivity's toString.

s/coorindator/coordinator/

Add a comment in DragStartDetails to distinguish it from the
otherwise identical DragDownDetails, so we're not tempted to merge
them.

"a hybrid of DragStartDetails and IdleScrollActivity" ?

DragScrollActivity and IdleScrollActivity, sorry

(fixed message)


feature: add BasePath so you can tune the API's basepath

<EMAIL_ADDRESS>on 21 Nov 2013 at 8:29:
feature: add BasePath so you can tune the API's basepath

Useful if you are using something like https://github.com/rwl/endpoints

https://code.google.com/r/brandon-tunable-basepath/source/detail?r=1706a3e83ed9f
5a25a221605965fad5167315feb

Successfully auto-migrated from code.google.com:
https://code.google.com/p/google-api-go-client/issues/detail?id=48

Fixed by https://github.com/google/google-api-go-client/commit/3a988841aa2aadf4284c63e87d84d644d509cf68
Closing.

Thanks!


Refactor eslint

Following #138 with only eslint related changes.

Thanks for the review, indeed some changes are cosmetic, and a matter of state, I don't really mind about any of them, a few side-notes:

regarding forEach instead of for of, I'm not encountering for of in most of the code I'm looking into so I'm not "used to it", forEach is shorter of both 1 LOC and 1 variable definition so it looks like a little bit more simple/elegant to me but I'll gladly revert it if you want.

regarding balanced spacing in params, I tried to go for the rule that enforced the least changes. But usually the related eslint-rules are object-curly-spacing and array-bracket-spacing, so one issue with the code was that import statements did not respect curly-spacing ever, and it was mixed for inline objects.

Replaced by #138.


PrimateLabs.Geekbench.6 version 6.0.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Validation is failing because the installer launches the application, which is a non-interactive benchmark test. Running the installer in interactive mode shows a clicked-by-default checkbox to autorun the application:

It appears that running the installer in silent mode installs with the checkbox checked - is there an installer switch to uncheck it and prevent the application from automatically launching after install?

@stephengillie /S seems to install it without launching the application

I just checked, it is installing without launching automatically. I don't know why it's failing.
https://user-images.githubusercontent.com/44692189/218866473-3c4ed3c5-0344-41f6-8957-8fe3ec5df593.mp4


[travis-ci] Add PHP 7 to build matrix

Any failure is allowed until PHP 7 become stable

+1

:-1:

Should be 7.0, not 7.


#153 Add application summary

I tweaked /applications/{address} route to display the application summary information with 4 cards for inputs, notices, vouchers and reports. Below the cards, I added the 6 latest inputs table.

Good one. Just need to rebase the branch.


Switch to ansible-runner

Switch to ansible-runner instead of directly interfacing with ansible
Based on @jctanner gist at
https://gist.github.com/jctanner/512ec07171d95e61a5b7fd5f9103a301
I hope we can collaborate around something like this.  I'm making a common pull request but please update ... our infra can test pull requests from the main repo
Not ready to merge, obviously, but this reliably works for the backend tests (and my local tests) with both local and remote ansible that go via the shell module.
The two tests that fail are not using shell output.  As mentioned inline; I can't seem to get the json response from ansible-runner reliably.  I get the feeling ansible-runner is sometimes dropping some of the output of the ansible process in it's stdout descriptor it returns.  This is a problem for the things not calling the shell module.

Hi, thanks for trying this. I'm glad to see ansible starting writting some "user-friendly" python API because maintaining this in testinfra is very costly (however I don't understand why ansible-runner is not included in ansible...)
Looking forward to see this PR ready to merge.

per https://github.com/ansible/ansible-runner/issues/200 it appears that molecule's usage of colorama is causing issues for runner.

Molecule now provides a PY_COLORS toggle (see https://github.com/ansible/molecule/pull/1533) :+1:

What does this mean for the runner integration?

This change is based on https://github.com/philpep/testinfra/pull/428 and now passes the test-suite locally for me.  I think we should squash most of this into a single, understandable change, but I'm not sure how other people like to work ... I'm happy to do that.  A couple of the changes are separate pull requests because they are things I found that stand alone.

There seems to be something up with pip/virtualenv installing in travisci right now
I have tested this in https://review.opendev.org/#/c/656877/
The interesting bit is http://logs.openstack.org/77/656877/5/check/system-config-run-base-ansible-devel/a50c4ad/job-output.txt.gz#_2019-05-03_12_02_45_978799
For reference, here is a run using the status quo http://logs.openstack.org/90/651390/4/check/system-config-run-base/7375ffb/job-output.txt.gz#_2019-05-02_17_19_48_306100
I think we know this is slower.  Looking at the runtimes for the same 58 tests we seem to have a base line:
2019-05-02 17:19:49.422402
2019-05-02 17:20:41.476163
(~1 minute)

2019-05-03 12:02:45.984555
2019-05-03 12:09:41.150059
(~7 minute)

@ianw thanks for the tests !
Yes it's indeed very slower than before, that's why I propose to use testinfra backend instead (except for the "ansible" module) in #431
Can you consider making changes to use ansible-runner on top of my series in #432 ?
I see you implemented https://github.com/philpep/testinfra/pull/410/commits/4f00901ea3f115f05cc14caf2a1b0a861f89836a that I also have in my series https://github.com/philpep/testinfra/pull/432/commits/6ff3c409e6d3145afe576fa1c169647dabd32460#diff-2c2050402fbd38935790464dc2668909R109 I wonder how do they compare ?
In particular I added some useful tests on my series, so it might be worth using it as a base, ansible-runner has just to be implemented in run_module() instead of ansible --tree call.
But I'm still not convinced we need to write this envvars file and handle the private_data_dir here.

Well to be honest, I'm still not conviced by ansible-runner at all for now. This add a dependency/wrapper that doesn't provide any additionnal feature to us over calling ansible --tree which just "works". Hopefully ansible-runner will provide a performant ansible connection tunnel through the target host, then I'll have another opinion about this.

I see you implemented 4f00901 that I also have in my series 6ff3c40#diff-2c2050402fbd38935790464dc2668909R109 I wonder how do they compare ?

Yes, after I did that, I realised you must have done the same because it was using ansible-inventory!  But i'm glad we came out with something that looks similar :)
I think that children: can be nested indefinitely, so it needs to be recursive?
I also got a bit confused as to what "pattern" is -- is it a string or a list?  You can see at https://opendev.org/opendev/system-config/src/branch/master/testinfra/test_adns.py#L16 an example of how we use it in our CI, we are pretty much tagging each test_* file with testinfra_hosts = [list-of-hosts].  I see it come in as both?
What is interesting though, and I think it might be a bug, is that if there are no hosts matching, we get a test parameterized as "_testinfra_host0" in the list, which just gets skipped.  We split our jobs up, so for example we're only running all the testing on DNS servers if someone actually changes the ansible roles that affect DNS servers.  For example, in our base test (the roles that happen on every host) get_hosts() will return an empty list for the DNS test I referenced above (testinfra_hosts = ['adns1.opendev.org']) because we don't have adns1.opendev.org in the inventory.
2019-05-03 12:02:45.978799 | bridge.openstack.org | collecting ... collected 58 items
2019-05-03 12:02:45.981093 | bridge.openstack.org |
2019-05-03 12:02:45.984555 | bridge.openstack.org | testinfra/test_adns.py::test_bind[_testinfra_host0] SKIPPED              [  1%]
2019-05-03 12:02:45.986828 | bridge.openstack.org | testinfra/test_adns.py::test_zone_files[_testinfra_host0] SKIPPED        [  3%]

It seems it would be better for the test just to not be there.  Anyway, that is something we can look at separately.

Can you consider making changes to use ansible-runner on top of my series in #432 ?

Yes this seems reasonable way forward; I can look into this next week.  We can also do similar testing of #432 (feel free to use opendev infra testing at any time, based on https://review.opendev.org/#/c/656877/ ... all needs to happen is switch the Depends-On: line to test different pull requests.  You'll just need a gerrit account and can either start a separate review or feel free to edit that one ... anyone in #openstack-infra freenode will by more than happy to help :)
I agree the performance is probably a blocker ATM.  I hope that having this so close can get people interested enough to overcome this and the we have a nice standardisation across some big bits of the ecosystem.

Superseeded by  #432


Limit scope of CI runs

All CI jobs run for all changes, including simple updates to documentation. This is probably overkill.
Could consider limiting which jobs are run for certain types of changes, e.g. exclude documentation changes (README etc) from code linting/tests.

@quantumjot we discussed it yesterday with @ots22 and @miquelmassot. Indeed all-contributors config file allow skipping CI, see below:
https://github.com/alan-turing-institute/scivision/blob/77139ef9bd03b9011969914170ff254d2bb111f9/.all-contributorsrc#L110
Hope @ots22 can provide his views in how to optimise CI jobs run.

Cool. I've done this before using the GH workflow and paths-ignore to include the README etc..

I guess this came out of all the updates to the contributor list.
One issue is that we have a branch protection rule for main requiring the build checks to pass - but skipping them means they never do!  A rule that results in them passing but not doing anything in some cases seems dangerous to me.
We also tried something like this: https://github.com/alan-turing-institute/scivision/pull/292 but it didn't seem all that convincing.
We could alternatively consider another branch without the protection (either develop, or convince all-contributors to open its PRs somewhere else and merge them all together).

Going to close this one for now, feel free to reopen


update logical axiom for 'lymphocytic choriomeningitis'

The current logical axiom is:
'infectious meningitis'
and ('disease has primary infectious agent' some NCBITaxon_11623)
but NCBITaxon_11623 is obsolete. The NCBITaxon imports need to be refreshed.
The logical def should be updated to:
'viral meningitis'
and ('disease has primary infectious agent' some NCBITaxon_3052303)
https://www.ncbi.nlm.nih.gov/taxonomy/3052303

@twhetzel can you import the new NCBI term that is needed?

id: NCBITaxon:3052303
name: Mammarenavirus choriomeningitidis
xref: GC_ID:1
synonym: "LCMV" BROAD []
synonym: "Lymphocytic choriomeningitis mammarenavirus" EXACT []
synonym: "Lymphocytic choriomeningitis virus" EXACT []
synonym: "lymphocytic choriomeningitis virus LCMV" EXACT []

I'll try those instructions @nicolevasilevsky

I added http://purl.obolibrary.org/obo/NCBITaxon_3052303 into "imports/ncbitaxon_terms.txt" and then ran sh run.sh make refresh-merged and included the updated files in https://github.com/monarch-initiative/mondo/pull/7370

In Slack, @matentzn mentioned this are part of the correct steps but that this taxon needs to be added to another file. I submitted an issue for this: https://github.com/obophenotype/ncbitaxon/issues/100
I don't know if it's ok to merge this PR as-is.


Fix memory bloat?

Very likely to be image array buffers: possibly not getting cleared

Doesn't look like it after staring at some heap snapshots? Not sure what's going on.


Typo Changes

This basically fixes a whole bunch of typos and things like that I found.

Nice one, thx. I will study the changes in a few hours.

Are you done with the corrections? You named last commit "part 1".
Also there is the question for the changelog. Do you want to update the readme.md of each plugin or should i do that? Like adding text corrections crediting you.
I can let this PR open for some time.
And thanks again. I just learned that that thausand seperator in english is a "," :) and some other things.

Sorry for the hindred, that was definitely not right! I’m not quite done with the fluffymissions, but all I have left to do is the parentheses. I’ll do those now.

Sorry if this feels a bit too much like nitpicking. I think this is merge-ready now though.

If you would be willing to update the changelog, that would be nice.
Your choice about crediting me.

Thanks for correcting so many mistakes. I even asked for someone who correct and rework my texts in one of the prior readmes, never found someone willing to do it. Until now :) Don't  worry about nitpicking, you did me a great favour.
Thanks for the work you invested here!

You’re welcome!


Failed to log in when self-host

Thank you for publishing such a powerful tool!!
But after downloading this repo and trying to host it on my Mac, I can't log in to the localhost:8000 (within the real email and token info, which is available at https://x-agent.net/). The whole deployment seems fine.

Does that mean even if I host XAgent locally, I still need to register my info to openBMB?
Is there any virtual(or test) account that I can use?

Default user: admin, token: xagent-admin, you can use it to login.

Thanks for the fast reply!
Pity, I am still not able to log in. I guess there are some CROS problems but I don't know how to handle them.

I reviewed the README.md. The XAgentServer log is a little different.

and the npm run dev port is different also. (http://localhost:5173/)


as end-user, i want jslint to display "early_stop" warnings first - issue #276

this quality-of-life pr help new-users trying to onboard jslint into their projects but are overwhelmed by initial large number of warnings (https://github.com/douglascrockford/JSLint/issues/276#issuecomment-718505062).  they understandably, would want to prioritize resolving "early_stop" warnings first, given perception they are more likely to cause program incorrectness.
note
this pr is similar in function to rejected pr #240.  the difference this time, is additional user-feedback regarding qol.
demo of patch available @ https://kaizhu256.github.io/JSLint/branch.sort_warnings_early_stop/

fixed by #293


new <CodeBlock /> react component

it's curretly way too hard to add a code snippet into your website. choosing the syntax highlighter is the worse.
I suggest: an Async Server Component which uses shikiji to highlight code, well integrated with BaseHub's API for code snippet blocks, and which exposes primitives (potentially ala radix, or ala our RichText) to:

have line numbers
have file names
have "copy code" button
highlight specific lines

RichText style is more fit for syntax highlighting because the code follows a strict order.
An initial api design could be something like this:
<CodeSnippet.Root language="" theme="" code={code}>

filename.tsx

     <CodeSnippet.CopyButton>Copy to clipboard</CodeSnippet.CopyButton>

    <CodeSnippet.Highlighter components={{
      line: ({ children, number, isHighlighted }) => {},
      token: ({ type, children, style }) => {
        // type can be "keyword", "string", "comment", etc... see how they do it in https://prismjs.com/
        return {children}
      }
    }} />

</CodeSnippet.Root>

<CodeSnippet.Highlighter>'s components are optional. If you set theme, they'll come with styles, and you're always free to add your own if you want.
you can do <CodeSnippet.Root language="" theme="" code={code} highlightedLines={[1, 4]} /> alone and it should work i guess. Meaning, if no children sent, will render default Highlighter.

done


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 09:45:29 on 2023.08.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 35304
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=35304

Problem has been resolved in 9m 0s at 09:54:29 on 2023.08.12
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 35304


Crashes on Linux (Ubuntu-based)

This may be caused by Wayland because using GDK_BACKEND=x11 walkarounds the issue

[x] I think my problem is NOT with youtube-dl
[x] I've verified and i assure that I'm running yt-dlg 1.X.Y
[x] I assure that i am using the latest version of youtube-dl
[x] Searched bugtracker
[x] I've read the FAQs file

What is the purpose of your issue?

[x] Crash report

% ./yt-dlg

(yt-dlg:44966): GLib-GIO-ERROR **: 17:46:23.870: Settings schema 'org.gnome.settings-daemon.plugins.xsettings' does not contain a key named 'antialiasing'
zsh: trace trap (core dumped)  ./yt-dlg

Feature request (request for a new functionality)
Please make sure that the requested feature is NOT already in the TODO list

[x] I've verified and i assure that my requested feature is NOT in the TODO list

What operating system do you use ?
Pop os 22.04

Can test the version 1.8.6 from the repository and share the steps you follow?


Mention where to put android arm64 builds

Description
Renderdoc seems to automatically pick up android builds from 'build-android-arm32/64', but this isn't in the docs. This has bit me a few times when trying to get renderdoc to find its arm64 apks-- it specifically seems to only look for the arm32 builds in 'build-android'.
Make a quick table to tell what folder name should be used for each arch in Compiling.md.
A quick look through the issues show Android-x86/64 is not officially supported, but I wanted to put the folder names here for completeness since there is code to handle those.

Closing this due to lack of activity from the reporter responding to review feedback.
If you'd like to consider this further please open a new PR.


feat/auth

Authenticate the REST API calls using JWT provided by Amazon Cognito.
When the calls are authenticated, the server-side (Spring-boot) should identify the profile of the client.

For the profile, could I just add a custom attribute in User Pool, eg : profile, and just use this attribute in Spring after I get the token ?

Please can you confirm if Sonar uses the Google Java style (https://google.github.io/styleguide/javaguide.html)
instead of checkstyle (https://checkstyle.sourceforge.io/) ?
Actually, Sonar sees more 4 consecutive capital letters for a variable name as violation, eg : USER_POOL_ID.
But when i check in the Google Java style above, it's even recommended.

I've just found that the User Model should be renamed when I have configured the authority where the spring User and the User saved in database mismatch.
But the feat actually works.


space replaced in housenumber

If house number contains a space the remote call hung.
Space has been replaced to %20.
Other special characters tested. No errors.

:rocket: deployment of register-with-a-gp-beta-web succeeded (http://register-with-a-gp-beta-web-pr-167.dev.beta.nhschoices.net)


Fix for NPE in Twilight Forest caused by missing call to WorldServer#init()

As described by @Tamaized at https://github.com/TeamTwilight/twilightforest/issues/334#issuecomment-344767981 there is an issue with the advancementManager variable not being populated due to a missing call to WorldServer#init.
This commit adds this call and therefore fixes these issues;
https://github.com/TeamTwilight/twilightforest/issues/334
https://github.com/lumien231/Simple-Dimensions/issues/12
For those interested, here is a link to a jar with this fix implemented: SimpleDimensions-MC1.12-1.3.1-patched.jar

You would not believe how long I was screwing around all the different dimension mods trying to just get a simple dual world system going. None of them worked for various reason until I looked in the GitHub for Simple Dimensions.  Thank you again.


Revamped concepts doc for ReplicaSet

This PR updated the concept doc for ReplicaSet. A few new sections were added, similarly to what the concepts docs for other workloads controllers have. This is a part of broader efforts to enhance the workloads controller docs. The corresponding example ReplicaSet YAML file was also updated to reflect the removal of selector defaulting for apps/v1beta2 in https://github.com/kubernetes/kubernetes/pull/50164.

This change is

/assign @kow3ns

/lgtm

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

Replaced by #5463. Closing.


Update native maps SDK doc

Cherry pick 37f19932 Ashley Song 10/25/2019 5:49:23 PM Update index.md from live
Added title attributes to native maps SDK doc to fix warnings
Minor format fix

Docs Build status updates of commit 3debf73:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/sdk-native/getting-started-android/index.md
:bulb:Suggestion
View
Details

BingMaps/sdk-native/getting-started-ios/index.md
:bulb:Suggestion
View
Details

BingMaps/sdk-native/index.md
:bulb:Suggestion
View
Details

BingMaps/sdk-native/map-control-api/uritilemaplayer-class.md
:bulb:Suggestion
View
Details

BingMaps/rest-services/routes/index.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/altitudereferencesystem-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/capturescreenshotlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapcamerachangedeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapcamerachangingeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapdoubletappedeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapelementtappedeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/mapholdingeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/maptappedeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/maptilebitmaprequest-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/maptilebitmaprequestedeventargs-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onbitmaprequestedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapcamerachangedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapcamerachanginglistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapdoubletappedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapelementtappedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapholdinglistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmaploadingstatuschangedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmapscenecompletedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/android/onmaptappedlistener-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/copyrightdisplay-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/customtilemaplayer-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geoboundingbox-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geopath-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geopoint-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geoposition-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geoshape-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/geoshapetype-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/groundoverlaymaplayer-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/index.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapcameradidchangehandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapcamerawillchangehandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapcustomtilemaplayerdelegate-protocol.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapdidcaptureimagecallback-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapdidchangescenecallback-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapelementlayeruserdidtaphandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmaploadingstatusdidchangehandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapuserdiddoubletaphandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapuserdidtaphandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/ios/msmapuserisholdinghandler-interface.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapanimationkind-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapcamera-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapcamerachangereason-enumeration.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapelement-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapelementcollection-class.md
:white_check_mark:Succeeded
View

BingMaps/sdk-native/map-control-api/mapelementcollisionbehavior-enumeration.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

BingMaps/sdk-native/getting-started-android/index.md

Line 12: [Suggestion] Link 'https://docs.microsoft.com/en-us/bingmaps/getting-started/bing-maps-dev-center-help/getting-a-bing-maps-key' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

BingMaps/sdk-native/getting-started-ios/index.md

Line 12: [Suggestion] Link 'https://docs.microsoft.com/en-us/bingmaps/getting-started/bing-maps-dev-center-help/getting-a-bing-maps-key' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

BingMaps/sdk-native/index.md

Line 25: [Suggestion] Link 'https://docs.microsoft.com/en-us/bingmaps/getting-started/bing-maps-dev-center-help/getting-a-bing-maps-key' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

BingMaps/sdk-native/map-control-api/uritilemaplayer-class.md

Line 26: [Suggestion] Link 'http://msdn.microsoft.com/en-us/library/windowsphone/develop/windows.ui.xaml.controls.maps.httpmaptiledatasource.uriformatstring.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 26: [Suggestion] Link 'http://msdn.microsoft.com/en-us/library/windowsphone/develop/windows.ui.xaml.controls.maps.httpmaptiledatasource.uriformatstring.aspx' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Allow passing custom HTTP headers to DAVClient

See #285

The style test can be easily fixed by running "tox -e style"

Oh, nevermind that, the style breakage is mine (the github merge queue system seems to merge things even if the style check breaks)


Recursive info field serialization

Created a more generic serialization for numpy arrays. This allows us to serialize the info field.
Slightly alters the serialization introduced in #511

Codecov Report

Merging #512 into master will decrease coverage by 0.02%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   93.62%   93.59%   -0.03%
==========================================
  Files          49       49
  Lines        3417     3437      +20
==========================================
+ Hits         3199     3217      +18
- Misses        218      220       +2

Impacted Files
Coverage Δ

dimod/binary_quadratic_model.py
95.61% <100%> (ø)
:arrow_up:

dimod/sampleset.py
94.84% <100%> (-0.18%)
:arrow_down:

dimod/serialization/utils.py
95.91% <93.93%> (-4.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368c888...32231d0. Read the comment docs.


Fix crash when int64 axis is passed to tf.reduce_sum

This fix tries to fix the crash triggered by int64 axis passed to tf.reduce_sum:
ubuntu@ubuntu:~/tensorflow2$ (cd && python)
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
>>> v = tf.reduce_sum([1,2,3], tf.constant(0, tf.int64))
2017-10-20 15:55:06.993430: F tensorflow/core/framework/tensor.cc:601] Check failed: dtype() == expected_dtype (9 vs. 3)
ubuntu@ubuntu:~/tensorflow2$

The issue is caused by the fact that shape inference in common_shape_fns.cc only assumes int32 without proper handling of diffent types. In math_ops.cc both int32 and int64 are mentioned.
NOTE that this fix does not address the issue that int64 is not supported. To allow int64 axis it is more than adding a template in ReductionOp as the type of the axis seems to be decided by some other ways in Eigen. Will investigate that later.
This fix merely fixed the crash so that an error message will return without exit from the python program "No OpKernel was registered to support Op 'Sum' with these attrs".
Still, its worth to at least allow the program not to exit in case an error happens.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@tensorflow-jenkins test this please
(Surprised this never came up before! thanks for the fix :)


Possibility to add certs for https

As a user i would like to make it possible to add and change the location for ssl certificates for a more secure connection.
Configure HTTPS, it is required if you use "https" protocol above.
https:
  key: path/to/server.key
  cert: path/to/server.crt

https://github.com/verdaccio/verdaccio/blob/master/conf/full.yaml#L104

can be done using a rproxy


feat: wrapper for low-level call opcode

closes #2144
related opcode

Hey Matt, great work! Before continuing on this, though, do see my comment here: https://github.com/FuelLabs/sway/issues/2144#issuecomment-1186920584


Please add key description for @ConfigurationProperties

Spring Boot ships an annotation processor that generates metadata for custom configuration keys. It extracts javadoc of fields to generate a description.
Please consider updating @ConfigurationProperties and add spring-boot-configuration-processor. More information in the documentation

Thanks @snicoll  for taking the time to review the code and provide good feedback!
I'm not sure how much maintenance I will do on this library, as I've replaced with a new framework that's much more powerful - https://github.com/savantly-net/sprout-platform
Although I do appreciate your insights!


Circular imports everywhere

Basically ImportError: cannot import name CustomerAction-type exceptions thrown. (Added bonus is that each dependency is also importing itself).
The entire lib is pretty much unusable without a dependency refactor (at least on python 2.7. It's weird that it works on python 3 as it's considered bad design for python).

Fixed with https://github.com/ProcessOut/processout-python/commit/120fa92ad0132d818dcf312c8365dee5385a39ae


Naive pluralization

I know that pluralization can be disabled, but instead of doing naive pluralization, I found an interesting module which can help you to less naively pluralize :
https://github.com/pksunkara/inflect

Yeah, well, it may have been three years :') but thanks for the info, alas it's quite a big dependency for the client. I may extract the pluralization parts from this module, as he does it well, but won't include it as-is.


Test error in test-generated

Timo,
We have discussed that earlier if I remember correctly.
I am creating an issue because I always get an error when running make in the root directory (Linux, node 14.4) of the master branch without any local change.
The error is:
@protobuf-ts/test-generated: make clean generate-speed-bigint test-spec-bigint test-conformance-bigint
@protobuf-ts/test-generated: 'clean' done
@protobuf-ts/test-generated: 'generate-speed-bigint' done
@protobuf-ts/test-generated: Jasmine started
@protobuf-ts/test-generated:   generated client style promise
@protobuf-ts/test-generated:     duplex-streaming
@protobuf-ts/test-generated:       ✗ duplex-streaming
@protobuf-ts/test-generated:         - Unhandled promise rejection: RpcError: user cancel
@protobuf-ts/test-generated:         Code: CANCELLED
@protobuf-ts/test-generated:         /Users/berchet/Code/protobuf-ts/packages/test-generated/ts-out/service-style-promise.ts:134:27
@protobuf-ts/test-generated:                 if (opt.abort) {
@protobuf-ts/test-generated:                     opt.abort.addEventListener("abort", () => {
@protobuf-ts/test-generated:                         const e = new RpcError("user cancel", "CANCELLED");
@protobuf-ts/test-generated:                                   ~
@protobuf-ts/test-generated:                         outputs.notifyError(e);
@protobuf-ts/test-generated:                         if (inputs.throw)
@protobuf-ts/test-generated:         /Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/event-target-shim/src/event-target.mjs:337:35
@protobuf-ts/test-generated:         jasmine-spec-reporter: unable to open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/event-target-shim/src/event-target.mjs'
@protobuf-ts/test-generated:         Error: ENOENT: no such file or directory, open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/event-target-shim/src/event-target.mjs'
@protobuf-ts/test-generated:         /Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-signal.ts:68:12
@protobuf-ts/test-generated:         jasmine-spec-reporter: unable to open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-signal.ts'
@protobuf-ts/test-generated:         Error: ENOENT: no such file or directory, open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-signal.ts'
@protobuf-ts/test-generated:         /Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-controller.ts:26:9
@protobuf-ts/test-generated:         jasmine-spec-reporter: unable to open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-controller.ts'
@protobuf-ts/test-generated:         Error: ENOENT: no such file or directory, open '/Users/berchet/Code/protobuf-ts/packages/test-generated/node_modules/abort-controller/src/abort-controller.ts'
@protobuf-ts/test-generated:         /Users/berchet/Code/protobuf-ts/packages/test-generated/spec/generated-client-style-promise.spec.ts:295:23
@protobuf-ts/test-generated:                     const abort = new AbortController();
@protobuf-ts/test-generated:                     setTimeout(() => {
@protobuf-ts/test-generated:                         abort.abort();
@protobuf-ts/test-generated:                               ~
@protobuf-ts/test-generated:                     }, 5)
@protobuf-ts/test-generated:                     let inputError: any = undefined;
@protobuf-ts/test-generated:         internal/timers.js:549:17
@protobuf-ts/test-generated:         jasmine-spec-reporter: unable to open 'internal/timers.js'
@protobuf-ts/test-generated:         Error: ENOENT: no such file or directory, open 'internal/timers.js'
@protobuf-ts/test-generated:         internal/timers.js:492:7
@protobuf-ts/test-generated:         jasmine-spec-reporter: unable to open 'internal/timers.js'
@protobuf-ts/test-generated:         Error: ENOENT: no such file or directory, open 'internal/timers.js'

It is not clear to me what is the root cause of the error.
I can see that this error is not triggered on the CI.
I'll try to investigate more later.
For now we could keep that issue opened to gather more feedback ?

Yes, let's keep this open until resolved.

Hi @vicb,
I have dropped support for client styles (rx and promise) to keep the plugin simple.
This means that the error message you saw in the build should be gone, because the corresponding spec is also gone.
Cheers,
Timo

Thanks !


workaround(lsp-signature)!: fix input delay of nvim-cmp

on_attach is deprecated;
Now lsp_signature won't adjust its position relative to the completion popup to avoid problematic functions (cmp.visible) being called.

Does this fix work for you? Because I'm still experiencing input delay on my end. If I disable lsp_signature, input delay disappears.

@YuCao16 This PR only reduces calls to cmp.visible(), but as a matter of fact, u can completely eliminate related calls (since we disabled check_completion_visible) via this patch:
diff --git a/lua/lsp_signature/helper.lua b/lua/lsp_signature/helper.lua
index 8d09a22..c3e32d6 100644
--- a/lua/lsp_signature/helper.lua
+++ b/lua/lsp_signature/helper.lua
@@ -697,7 +697,7 @@ end
 helper.completion_visible = function()
   local hascmp, cmp = pcall(require, 'cmp')
   if hascmp then
-    return cmp.visible()
+    return true
   end

   return fn.pumvisible() ~= 0

The issue upstream is not every call to cmp.visible() gets checked.

Will #890 fix that?

Will #890 fix that?

Yes, it works, thanks!


Issue: Floodgate Local Linking Database

Issue on: _docs/floodgate/linking.md
The link that should lead to the linking database extensions under Local Linking is invalid

https://github.com/GeyserMC/GeyserWiki/pull/246

Should be now resolved. Thanks for creating an issue!


MWPW-153810 media image is seen loaded twice in product page urls in desktop

Media image is seen loaded twice in product page urls in desktop
This fixes the replacing of whole innerHTML if there is any placeholder on the page.  It only the specific placeholder text.
Resolves: MWPW-153810
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/suhjain/performance/marquee-light
After: https://placeholderreplacement--milo--suhjainadobe.hlx.page/drafts/suhjain/performance/marquee-light

Code looking good, there are still some nala tests failing https://github.com/adobecom/milo/actions/runs/10192039682/job/28194263694?pr=2647

Validation done on the pr , details are updated in
https://jira.corp.adobe.com/browse/MWPW-153810
https://main--cc--adobecom.hlx.page/products/premiere?milolibs=placeholderreplacement--milo--suhjainadobe&mep=off


fix(): added  functionality

using  $parse instead of object[key]  This is for issue 527

Hi! Thanks for working on this. What you have is great. The reason the build is failing is because your code doesn't pass our linting rules. Could you please run npm run eslint and fix all the issues mentioned, then please amend your commit with this changes and force push (so the PR has only one commit). Let me know if you need help with this. Thanks again!

Current coverage is 95.93%

Merging #531 into master will increase coverage by +0.05% as of f4b0afe

@@            master    #531   diff @@
======================================
  Files           16      16
  Stmts         1093    1107    +14
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1048    1062    +14
  Partial          0       0
  Missed          45      45

Review entire Coverage Diff as of f4b0afe

Uncovered Suggestions

+0.36% via ...alidationMessages.js#25...28
+0.27% via ...s/formlyUsability.js#18...20
+0.27% via src/test.utils.js#38...40
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Hey Kent, I could have sword I fixed everything, can you check again?

Looks pretty good. If you could address my comment that would be great. Also, I prefer to not have multiple commits for a single pull request. If you could make your change (to remove the if if necessary), then do this:
git checkout -b reset-with-parse
git reset --soft HEAD^^
npm run commit
git push -u --force origin reset-with-head

Thanks!

Alright, what I would recommend is create a new branch based on the formly-js master. Then copy your changes over to that new branch. Do a single commit, and push that branch up. Then create a new pull request for that branch.

Honestly, I'm still having issues after re-forking and copying over my changes.  I can't spend any more time on this for a while (have to get back to work!) I'll try updating at a later date.

I'm sorry you're having trouble with this @MCKRUZ :-( Let me know if you need more help!


project unmaintained?

@lapp0 are you there?
master branch has been broken for some months

Why does the NixOS project don't take over and maintain this lovely project as part of their distro as the default way to manage it?
A nice graphical util is way easier for people, and since NixOS is all about configuration, it should make it as easy as possible

this lovely project

rather a failed experiment
the nix language is too complex to build a simple gui config editor
see also NixOS configuration editors

I don't want to use the damn command line for everything

everything?
just use a graphical IDE to edit your nix files
a language server like nixd enables auto-completion
... wont get better than that

Try https://github.com/snowfallorg/nix-software-center and https://github.com/snowfallorg/nixos-conf-editor
They are included in https://snowflakeos.org/


Regression: invisible window, wrong fullscreen size

On my system (Linux/Sway/XWayland), 77664ff0575c8f51e1ba5cd3604a57808fbf95f4 causes a regression:

Before the commit, Ebiten windows get created on the correct screen and get centered correctly.
After the commit, I don't get any visible window, and in fullscreen it displays too small in the bottom left corner.

Commenting out the initializeWindowAfterCreation(window) in createWindow() fixes it, although I do not yet know why. What the function does looks reasonable to me (other than the window being way too small, 16x16).
Checking with xwininfo reveals that the window actually gets created but outside the visible area of my dual screen setup. Fullscreen oddly uses the wrong size.
I suggest backing out the commit for now, unless it fixes similar issues on other systems. Or maybe have it temporarily controlled by an environment variable until fixed for good?

Monitor setup:
$ xrandr
Screen 0: minimum 16 x 16, current 3840 x 1440, maximum 32767 x 32767
XWAYLAND0 connected 1280x720+0+720 (normal left inverted right x axis y axis) 310mm x 170mm
   1280x720      59.86*+
XWAYLAND7 connected 2560x1440+1280+0 (normal left inverted right x axis y axis) 700mm x 400mm
   2560x1440     59.96*+

dpi: 96 (i.e. 1:1 mapping, device scale is 1 and should be)

examples/fullscreen/main.go reproduces the fullscreen issue (creates window on my right monitor, while using size of my left monitor).

Does NOT repro with examples/windowsize/main.go.
DOES repro once I add ebiten.SetRunnableOnUnfocused(false) right above the "minw, minh, ..." line.
Don't yet know why.

If I defer ebiten.SetRunnableOnUnfocused(false) to the first frame in my game, window size is fixed; fullscreen remains broken.

Thank you for reporting! The commit 77664ff0575c8f51e1ba5cd3604a57808fbf95f4 is needed to put the initial window on a correct monitor instead of the primary monitor. I'll take a look but probably I cannot reproduce this issue.

Well, for me the initial window ends up on the correct monitor (the one with focus) without that commit; but of course this is likely due to a difference in window management.
Will later test using i3, but for now I am on XWayland/Sway.

Also, don't yet know why the window would be entirely invisible with the bug. It does seem mapped, yet I can't find or switch to it.

With Cinnamon, the primary monitor was always used without the fix.

     0x100001e "Window Size (Ebiten Demo)": ("glfw-application" "GLFW-Application")  480x360+400+840  +400+840

So the range is 400..880 for x and 840..1200 for y.
My left monitor spans 0..1280 for x and 720..1440 for y. My right monitor spans 1280..3840 for x and 0..1440 for y.
So I do not understand yet - the window should be intersecting with the left monitor, yet I don't see it.

Anyway, as observed before, the fullscreen issue is probably rather easy to explain - we don't get the monitor we expect. A fix would thus be explicitly requesting the "expected" monitor from GLFW when fullscreening, i.e. query the monitor of the window then set it explicitly before going fullscreen.
The window mode issue is more peculiar.

In any case, if we can't fully fix this, can we at least have an environment variable to toggle behavior?
Anyway, have an idea why SetRunnableOnUnfocused would even change anything here?

SetRunnableOnUnfocused doesn't invoke any GLFW functions so that's very odd...

func initializeWindowAfterCreation(w *glfw.Window) {
        // Show the window once before getting the position of the window.
        // On Linux/Unix, the window position is not reliable before showing.
        w.Show()
        w.Hide()
}

So, how is the window position changed before Show, before Hide and after Hide?

Not sure yet how to find that.
I did notice that commenting out the w.Hide() call already fixes everything for me.
Hm.

w.GetPos() should return the position.

It's 0, 0 after each.
What if Show()/Hide() simply don't wait till the window manager actually applies the change (you then get a ConfigureNotify)?

I don't know how these function works asyncly or not.
So would removing Hide() fix your issue? I think that's fine.

Or if time matters, I want to know a proper way to sync the state. time.Sleep would be too hacky.

I am currently looking at xtrace output.
Yes, it appears that removing the Hide() is at least a temporary workaround that works for me. Don't know why yet, though.
In the trace, I see the first difference after the UnmapWindow call from the Hide() as follows:
Without hiding:
000:<:007d: 16: Request(40): TranslateCoordinates src-window=0x00c00007 dst-window=0x00000525 src-x=0 src-y=0
000:>:007d:32: Reply to TranslateCoordinates: same-screen=true(0x01) child=0x00c00007 dst-x=0 dst-y=0

With hiding:
000:<:007d:  8: Request(10): UnmapWindow window=0x00c00007
000:<:007e: 16: Request(40): TranslateCoordinates src-window=0x00c00007 dst-window=0x00000525 src-x=0 src-y=0
000:>:007e: Event UnmapNotify(18) event=0x00c00007 window=0x00c00007 from-configure=false(0x00)
000:>:007e:32: Reply to TranslateCoordinates: same-screen=true(0x01) child=None(0x00000000) dst-x=0 dst-y=0

However, this difference seems harmless to me - both returned 0, 0.

My guess is that the window position might be broken a while after this function is called and the window is hidden. That's interesting.
What's the value of w.GetPos() at currentMonitor?

First of all, it seems like TranslateCoordinates starts "working" as soon as we receive a ConfigureNotify event. In the "good" path, the window starts out as 16x16, gets reconfigured to 75x50 and finally becomes 480x360. In the "bad" path, it only gets notified once for 480x360.

When broken, w.GetPos() returns 0 0 in the first 8 calls to currentMonitor().
When good, w.GetPos() returns 0 0  in the first 5 calls, then 2320 528 every time.

What is 'good' and 'broken' here? Is the behavior flaky?

With and without the Hide call.

Or, maybe, is this a better solution in addition to remove Hide?
func initializeWindowAfterCreation(w *glfw.Window) {
        // Show the window once before getting the position of the window.
        // On Linux/Unix, the window position is not reliable before showing.
        w.Show()

        // Hiding the window makes the position unreliable again. Do not call w.Hide() here (#1829)

        // Wait until the position is reliable.
        for i := 0; i < 10; i++ {
          x, y := w.GetPos()
          if x != 0 || y != 0 {
            break
          }
          time.Sleep(time.Millisecond)
        }
}

Lifecycle differences of the window 0x00c001e (the one that matters):
"Good" (not hiding): mapped in request 0x0109, unmapped only at exit.
"Bad" (hiding): mapped in request 0x010a, unmapped in request 0x010e, mapped in request 0x0146.
First TranslateCoordinates that in the good case gets the proper position is 0x0131 - specifically during the phase where the window would be hidden.
So I think I figured this out. While unmapped, a window manager does not position a window. XMapWindow doesn't actually "do" much, but it requests the window manager to actually place the window (and the client, if it cares about the position, then has to wait for that to happen, which will be confirmed by a sequence of MapNotify and ConfigureNotify events).
Now TBH I do not know how a client should wait for a Map request to "finish", i.e. when it is safe to query its position - but so much is for sure:

MapRequest is what ultimately directs the window manager to position the window. Client receives MapNotify eventually, BUT the mapping may not be done yet as it's not the WM sending this but the X server!
Window managers tend to not assign unmapped windows to screens. As observed here.
ConfigureNotify is how you know you've been positioned, BUT a window manager may never do that.
Window managers however do usually intercept XConfigureWindow requests so they can influence window placement, and that will reliably give you a ConfigureNotify back. WMs tend to just forward ConfigureRequests to the X server while a window is not mapped (as seen here).

Sadly this means there's no "perfect" sequence, however given Ebiten already starts out with a "wrong" size and then resizes, Ebiten can just wait for the ConfigureNotify indicating the window has been placed.
As for waiting till GetPos returns nonzero, this actually seems wrong - if the window isn't mapped, there's no guarantee, and it also may just spawn at the origin.
I'll look in GLFW source what is there to wait for a proper position.

Okay, this is... sad. GLFW is entirely async there and nowhere _waits- for a ConfigureNotify directly.
However, ConfigureNotify calls _glfwInputWindowSize and/or _glfwInputWindowPos (in THAT order), but ONLY if anything changed.
In other words, it's kinda sad, so polling GetPos() may actually be right, due to GLFW not providing a better mechanism.
GLFW however does wait for the VisibilityNotify event when showing a window; for setting window position or size, there is NOTHING it waits for.

BTW with the waiting added, I still get 5 times 0, 0 and then the correct window pos.

Of course the GetPos() calls actually spam XTranslateCoordinates requests. Should be rather harmless though, if it's just 16 times.

Aha, that's a good information. So probably
func initializeWindowAfterCreation(w *glfw.Window) {
        // Show the window once before getting the position of the window.
        // On Linux/Unix, the window position is not reliable before showing.
        w.Show()

        // Hiding the window makes the position unreliable again. Do not call w.Hide() here (#1829)

        // Call GetPos until the position is reliable.
        // GLFW doesn't provide any mechanism to sync the X client and server states.
        // By spamming XTranslateCoordinates requests, we can get the correct position (#1829).
        for i := 0; i < 10; i++ {
                if x, y := w.GetPos(); x != 0 || y != 0 {
                        break
                }
        }
}

Yeah. I still am trying to figure out why we get 0, 0 the first few calls. This seems wrong.

OK I'll wait for your investigation. Thank you for the investigation every time!

The second one:

Created as 16x16.
Translating fails.
Then it changes properties WM_NORMAL_HINTS of type WM_SIZE_HINTS with PWinGravity, PMinSize, PMaxSize set.
Then calls ConfigureWindow.
Then sets WM_NAME, WM_ICON_NAME, WM_CLIENT_MACHINE, WM_LOCALE_NAME, _NET_WM_NAME, _NET_WM_ICON_NAME.
Then TranslateCoordinates starts working.

In comparison, the "bad" window never calls ConfigureWindow, but does set WM_SIZE_HINTS with PWinGravity set.
This makes no sense.

Explicitly doing w.SetSize(400, 300) before or after showing does NOT change the result. We still don't get positioned. Why?!?

So...
it appears like calling SetPos() right after Show() makes sure I always get sensible coordinates. If I don't call SetPos(), I only get sensible coordinates much later.
However this makes no sense, as according to my trace we also get the WM to place the window properly before that.
Hm... what if our problem is actually a lack of flushing?

Nah, then SetSize() would have worked too, but it doesn't.
One difference between SetPos() and SetSize() is that SetPos() may also call XSetWMNormalHints() - except that it actually does not as the trigger code path for that is not run. So the delta is really the XMoveWIndow call and what Sway does with it.
Sorry, I cannot investigate further today - will see tomorrow if I find anything.

Tried on i3 now - issue does NOT happen on i3.
So I'd say, for now let's just remove the Hide() call and document it as a workaround for XWayland and/or Sway - but right now it doesn't really make any sense. Nevertheless removing the Hide() call seems appropriate given the two use cases of this:

The window created by init() gets destroyed soon after anyway, so this doesn't change much.
The window created by createWindow() gets resized and shown anyway. Main behavioral difference is that there may be different "glitchy" effects during window creation, but this affects both the create/show/hide/resize/show way (if we leave things as is) and the create/show/resize way (if we remove the Hide).

Given it works for me fine without the loop despite getting 0, 0 the first few times - I guess you can leave that out.


[ci:component:github.com/gardener/logging:v0.49.0->v0.50.0]

Release Notes:
Build an image containing the bare minimum of libs for `tunef2s` to work alongside `lsblk` and `awk`.

/close in favor of #7645


Check Script References for the included scripts.

Issue
When a scripts is included that has a reference to another compiled script, the compiled one is not included in the package.

This should be fixed by this commit d0d371e, and will be included in the next release

From version <IP_ADDRESS> onwards the compiled scripts that are referenced are included too. Do not that if there are required script that are triggered from any of the included script without a direct reference these will not be included.


TURN server cleanup and refactor

A few things...call this a preview of how I'd like the SOCKS server to turn out:

Move all TURN code to a new top-level package, turn (this code predates our use of require).
Remove the frontend and backend freedomjs modules (we used to give essentially every class its own module, which is way excessive).
Rather than an ArrayBuffer for frontend to backend communication, use a pair of StunMessage and Endpoint.

I'm actually most excited by the last point. It's going to allow us consolidate serialisation code - e.g. for a distributed WebRTC implementation - in one place, rather than duplicating it in both frontend and backend as we do today. For now, this makes for a way more efficient Simple TURN sample app.
I strongly considered having the Frontend and Backend inherit from a superclass but now the amount of shared code would so low I don't think it's worth it.

:+1: and thanks for taking on the next wave of architecture planning discussions.


Updating props does not re-render map

Updating the props (eg. backgroundColor) does not re-render the map. How can we get this to work?
          <VectorMap
            map={'world_mill'}
            backgroundColor={ colors[0] }
            containerStyle={{
              width: "99%",
              height: "100%",
              paddingLeft: "0.5%",
              paddingRight: "0.5%",
            }}
            series={{
              regions: [
                {
                  values: myData,
                  scale: colors,
                  legend: {vertical: false},
                }
              ]
            }}
          />

If you don't want to work on forked stuff, here is a work around.
First create a boolean state to how/hide the map:
const [isShowMap, setIsShowMap] = useState(true);

Attached this state to show/hide the map html:
{ isShowMap && <VectorMap... }

On any change in props or any data, just turn this flag off and on again with setTimeout:
useEffect(()=>{
  setIsShowMap(false);
  setTimeout(()=>{
    setIsShowMap(true);
  })
}, [prop1, prop2]);

As it is just a work around, you will experience a tittle flicker.


Are we allowed to change the logos and names?

Case the answer is affirmative, then I want to know how to change the sidebar logo and title. How?

Solved


chore: introduce RSPACK_LOG_COLOR

Fixes #5149
This PR introduces the RSPACK_LOG_COLOR environment variable, which can have one of three values: always, never, or auto:

always: Always displays colors, both in the terminal and when writing to files.
never: Never displays colors.
auto (default): Displays colors in the terminal but not when writing to files.

Here's a comparison before and after applying the RSPACK_PROFILE=TRACE=layer=logger npx rspack build > log.log command:

Can this RSPACK_LOG_COLOR configuration be converged to RSPACK_PROFILE, since this only control the color of tracing logs?

Can this RSPACK_LOG_COLOR configuration be converged to RSPACK_PROFILE,

It's not worthwhile.


fix: use the new Flutter 3.7.0 maybeOf to avoid a possible crash

Flutter 3.7.0 introduced a breaking change where the .of( now returns a non null values or an exception. If you want to keep the previous behavior, we need to use .maybeOf(.
This PR use that new maybeOf to avoid a possible crash in this lib.

Thanks that is a good catch. I fixed the CI and linting in the main branch now. Could you please rebase, then the tests should be green and it will get merged. I will make a new release after that as well.

nevermind could do it myself :) thanks again, will merge now


is there a resource where I can find more demo record files

Apologies if this is not the right place to post a question like this. I'm a final year AI student and my dissertation will involve Apollo. I'm new to Apollo and I have been unable to find a community where I can ask beginner questions (please let me know if one exists). I could use a more extensive demo file than than (demo_3.5.record) one provided, I need one with a few lane changes. Is there a resource where I can find different demo files of the Sunnyvale loop? Thanks

Here is one
wget https://apollo-system.bj.bcebos.com/dataset/6.0_edu/sensor_rgb.tar.xz

There is currently a developer community, but it may not be friendly to English developers. https://apollo.baidu.com/
We have WeChat group and some online sharing.
I think the mailing group or Q&A community may be more suitable for global developers. We're building the community, until then please feel free to ask questions here, we'll try to help, you know the open source community needs everyone's participation

Thanks for the response and the file, but there aren't any lane changes in that file is it possible to get one with a few lane changes? 2 or 3 would be perfect.

@barrykidney I can generate some demo record files for you.

Which version of Apollo do you use?
Do you just want the ego car (Apollo) move forward while changing lanes?

@YuqiHuai That would be great thank you, The lane changes are the main thing I need, but if there was a few other vehicles and one or two turns that would be perfect. I'm using Apollo 8. Thanks again

@barrykidney I am traveling at the moment but I should be able to get you some records within 24 hrs.

@barrykidney I got 2 scenarios for you here. Here are the steps to create scenarios like this:

Launch Dreamview via bash scripts/bootstrap.sh
Make sure you fixed the manual traffic light following instructions here
In Dreamview (http://localhost:8888), select Sunnyvale Loop on the top right, and turn on SimControl (Tasks > Other > SimControl)
Start controlling traffic lights via bash scripts/manual_light.sh, make sure the signal is green when the ego car reaches the junction.
Now in Dreamview, turn on Planning and Routing from Module Controller
Again in Dreamview, select 2 points on the map, SimControl will move the ego car from the first point (initial location) to the second point (final location) following the output of the planning module.

Adding a few other vehicles isn't that easier so it will take me a bit longer, but I'll share some with you later today as well.

@YuqiHuai Thanks for those files, I'm really only starting out so I can switch to Apollo 7 no problem.


Upload to PyPI on release tag

Modify .travis.yml to automatically upload package to PyPI on tagging a release. See http://docs.travis-ci.com/user/deployment/pypi/ for details.

This has been fixed in commits 0fa62b51eec53a2243c0a3d7862a1f1556c97ea3 and 00eec4639d68a0870ad1f0adc44b6d65b31a5174.


iplot('ratio') shoud sync X axis by default

in a ratio diagram, when zoom in the lower 'ratio' part , the main diagram is not zoomed together, and vice versa.  No param in iplot() can control this so far.
I think it's better synchronized by default.

Found a makeshift:    iplot('ratio',   xrange=[minX, maxX] , ... )


Added Upstash Redis Memory support

Feature: #372

@HenryHengZJ
I have tried adding support for upstash redis. Could see it coming in the workflow running locally but could not actually test it as i am unable to create a sample workflow because i do not have the paid subscription of GPT or any other language models. Can you help me test it?

Tested on Upstash:


When to update the code for object detection？

Object detection code will be released within 10 days. Thanks for your interests in ConvMAE.

@lqz72 We have updated codes and models for object detection.


Great stuff, how about CSS styling

I just wonder, the self contained styling, is it not overrridable?
If we were to add more information it has to come around the selfcontained box?
Or do you have any thoughts on how to do this

agreed.. did you find a way to do this? the css is not great to say the least....

@GodAlmighty990 no we ended up making our own handler for this

Hey everyone, the built-in CSS is intentionally basic and one should be able to override it by adding stylesheets that reference the same CSS classes. Inherited font family and font size do affect the styling in the widget, though, as well.
I am planning a more extensive customization approach, to allow changing individual UI elements too, but it has been a busy end of 2021 for me unfortunately. Either way, thanks for checking out this library! Will close the issue for now.


Remove symbols from functions.js

I was working on a parser.js refactor to simplify the logic and reduce how deeply nested the call stack is for various things like calling functions.  I realized that one of the complications which arises is that there is somewhat of a conflict between functions.js and symbols.js which therefore requires every 'isSymbol' check to be also consulted with an 'isFunction' and is essentially the reason ParseFuncOrArgument is required.
The conflicts are found in symbol: true operators defined in functions.js and accents defined in functions.js.  Perhaps it may be worth while defining:

defineNewAccent(...) so that accents in functions.js can map to symbols (but they are not symbols themselves), and
declareMathOperator(...) to define operator symbols which included the required limits: Bool.  This would require a change in the ParseNodes API as far as I can tell.

I'm going to ignore this for now, and continue with the refactor with no ParseNode changes, with the additional logic to handle this.  I'm just leaving this here for future reference.

Closing as we now have typed ParseNodes. Please reopen the issue if it still needs refactoring.


Have Standalone fail fast when no Accumulo instance

Some ITs that run in standalone mode will still run if they can't connect to the Accumulo instance.  It would be nice if a check was added to AccumuloClusterHarness during setup that did a sanity check to make sure Accumulo is running and fail quickly if the connection can't be made.

I took a look at this and have some follow up questions. Is the main intent of this to fail fast when the entire standalone suite is run? Since each individual test has it's own timeout anyways it would just crash when that is reached.
I also wonder if you have any ideas on the best way to implement this? From what I can tell, there are multiple reasons as to why it can't connect to an accumulo instance and for an IT to hang. Whether it is just the Manager service (I think that is the new name), zookeeper, or if a tserver is down (assuming . I can check for these cases and more individually, but I couldn't find an already implemented way to check if an accumulo instance is active and running or imaybe we don't want to check for every possible instance. Thats where I am stuck at for this ticket at the moment.

I was thinking have the test to fail similar to what we did with checking the properties file: https://github.com/apache/accumulo/blob/3fd5cad92f9b63ac19e4466f3f2d5237b905262c/test/src/main/java/org/apache/accumulo/harness/conf/AccumuloClusterPropertyConfiguration.java#L68
Except this would be to just test a connection to AccumuloClient based on the properties in that file.   I think the quickest we would be able to fail would be the default ZK connection timeout.

Is there a way to limit the 2x zookeeper timeout period? As it stands, most of the tests will timeout before the zookeeper timeout is reached.

Is there a way to limit the 2x zookeeper timeout period? As it stands, most of the tests will timeout before the zookeeper timeout is reached.

@Manno15 Not a good way for an existing (standalone) cluster, no. Even if there was an easy way to time out before that, we would probably end up with false negatives (we conclude that ZK is not running when it really is, but we didn't give it enough time to connect). If tests are set to time out before 2x ZK timeout, I'm surprised we don't have more flaky tests. I would consider 2x ZK timeout to be the minimum time we should wait for a test to finish (but it's not worth changing it if they are working today).

It's possible there's not a good way to fail fast, and there's nothing to be done for this ticket.

You should be able to set the .zkTimeout() here on the ClientInfo.  I am not sure if that will get overridden by the framework though.  If that works, we could add the timeout as another property in the standalone config file.

You should be able to set the .zkTimeout() here on the ClientInfo. I am not sure if that will get overridden by the framework though. If that works, we could add the timeout as another property in the standalone config file.

Based on the docs, the minimum session timeout that the client is able to negotiate is determined by a server-side setting, and defaults to 2x the tickTime. So, setting something in our client lower than that would be limited by the minimum. This is what I thought @Manno15  was referring to. However, reading back, I'm not sure if he was referring to that when he said "2x zookeeper timeout period" or something else.

I am not quite sure on the terminology but from what I noticed and based on the error message, it runs through our default zookeeper timeout twice before failing. The default instance.zookeeper.timeout is 30s and will throw my exception 2x that time. I had difficulties trying to lower the default timeout client side but I will look at what Mike mentioned tomorrow.

This is the specific thing I am talking about:
Failed to connect to zookeeper (localhost:2181) within 2x zookeeper timeout period 30000
That 2x timeout period.

No practical solution within the current build system and test framework.


Slow and incorrect exploration of embedding files with fs.glob()

When looking for the list of files having the requested file_format, this code is not optimal because fsspec will explore all the files in the parent folder. It can even explore other unwanted files.
glob_pattern = path.rstrip("/") + f"**/*.{file_format}"
ex:
if we want to find all the files ending with .npy in /tmp/tmpeejv3hoh
fs.glob("/tmp/tmpeejv3hoh**/*.npy") will explore all the files in /tmp and could even match wrong files like /tmp/tmpeejv3hoh_2/toto.npy
https://github.com/rom1504/embedding-reader/blob/11d237d2b0ac95423b0477dac438e17d3e05b689/embedding_reader/get_file_list.py#L45

thanks


Catch test failures not caused by Xunit assertions

Not all tests fail as a result of Xunit assertions. An example of this
is AboutNull.AWayNotToCheckThatAnObjectIsNull() which throws a
NullReferenceException before the assertion can be checked. The test
failure is squelched and silently ignored as a result of the
unsuccessful soft cast to the expected XunitException. By removing
the cast we can catch any test failure while preserving relevant
reporting details.

Thank you for the PR. You are the best!

GitHub Selfies

Cheers! I noticed that this was an issue because I was working through the Koans one at a time and it appeared to be passing -- or really just skipping -- some that I hadn't yet worked on. There's nothing more confusing than something that shouldn't work, but does. :)

Yeah I appreciate it. I did a direct port of Cory's koans but have not run through them yet so I am thankful you did it.

@all-contributors please add @jhoerr for code


num_stages in max_pool

https://github.com/kakaobrain/trident/blob/ce17900e0ed53d27c8d7b99f467b1f5c649c33a7/trident/operation/max_pool2d.py#L42
It actually doesn't have any effect in this kernel. IIUC, you intended to unroll the loop and overlap load/compute? It needs to be done manually for now.

@Jokeren Yes exactly and thanks for your comment. Currently the performance of MaxPool2d is very slow when the kernel size is very small. Now I'm trying to batch.

This issue is resolved by changes.


Update Google Play Services Version to Fix Breaking Change

This library needs to be recompiled to be compatible with Google Play Services 8.1.
8.1 introduced some breaking changes to the API (some interfaces are now abstract classes instead, see release notes). The actual java code that uses the API mostly remains the same, but not the compiled bytecode (since it differs for abstract vs interface methods). Hence all that is required is to update the Google Play Services dependency version to the latest.
The following dependency combination causes a crash (see below), as a result of this breaking change.
compile 'fr.nicolaspomepuy.androidwearcrashreport:crashreport-mobile:0.4@aar'
compile 'com.google.android.gms:play-services-wearable:8.1.0'

java.lang.IncompatibleClassChangeError: The method 'void com.google.android.gms.common.api.GoogleApiClient.connect()' was expected to be of type interface but instead was found to be of type virtual (declaration of 'java.lang.reflect.ArtMethod' appears in /system/framework/core-libart.jar)
            at fr.nicolaspomepuy.androidwearcrashreport.mobile.CrashReport.<init>(CrashReport.java:48)
            at fr.nicolaspomepuy.androidwearcrashreport.mobile.CrashReport.getInstance(CrashReport.java:35)

By the same reasoning, this change will cause incompatibility with any other libraries that target a lower version. Though the only solution in the long run is for every library to bump its dependency version up to 8.1.

Thanks for the PR and the long explanation.
It has been merged and published (should be available in maven in a few hours).


Add Tickets submitter_id as primary key for authenticated users

Is your feature request related to a problem? Please describe.
e-mail addresses can change for users.
Create a field 'submitter_id' on Tickets could be auto-populated with user.id when an authenticated user submits a ticket and that information could be used for email address changes and tracking.
Describe the solution you'd like
Add 'submitter_id' field to Tickets table and populate with the user.id if a user is authenticated. Use this information to allow authenticated users to view and add to their own tickets and track any changes to email addresses.
Potential Issues
User removed from Django and recreated with new user.id and same email address. Would need to decide how to handle this corner case.

Update the id on the old tickets based on the email match. Security flaw if someone is trying to get access to someone else's tickets.
Leave old tickets alone and allow staff/superusers to update the user id on Tickets, listing username, first, last, and email for drop down selection.

No comments received, appears this is not an item of interest at present.

You don't have to close it, it's a good idea, I just haven't had time to really look at major changes yet (trying to bugfix to get 0.3.0 released).


[1.12-rc4] libcontainerd data race

Jul 13 11:30:19 localhost.localdomain docker[20494]: ==================
Jul 13 11:30:19 localhost.localdomain docker[20494]: WARNING: DATA RACE
Jul 13 11:30:19 localhost.localdomain docker[20494]: Write by goroutine 19:
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.(*remote).runContainerdDaemon()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.(*remote).handleConnectionChange()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]: Previous read by goroutine 17:
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.(*remote).runContainerdDaemon.func1()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]: Goroutine 19 (running) created at:
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.New()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]:   main.(*DaemonCli).start()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/cmd/dockerd/daemon.go:275 +0x2caf
Jul 13 11:30:19 localhost.localdomain docker[20494]:   main.main()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/cmd/dockerd/docker.go:68 +0x6ad
Jul 13 11:30:19 localhost.localdomain docker[20494]: Goroutine 17 (finished) created at:
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.(*remote).runContainerdDaemon()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]:   github.com/docker/docker/libcontainerd.New()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/.gopath/src/github.com/docker/docker/libcontainer
Jul 13 11:30:19 localhost.localdomain docker[20494]:   main.(*DaemonCli).start()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/cmd/dockerd/daemon.go:275 +0x2caf
Jul 13 11:30:19 localhost.localdomain docker[20494]:   main.main()
Jul 13 11:30:19 localhost.localdomain docker[20494]:       /home/amurdaca/src/github.com/docker/docker/cmd/dockerd/docker.go:68 +0x6ad
Jul 13 11:30:19 localhost.localdomain docker[20494]: ==================

/cc @mlaventure @tonistiigi @crosbymichael
I can hardly reproduce this, testing with 1.12-rc4 on Fedora 24

This look like a false positive to me. There can't be 2 parallels calls to runContainerdDaemon.
The first call is done when the libcontainerd instance is first created. Further calls will only be made after the connection is down and the previous process has been reaped.
wdyt @tonistiigi @crosbymichael

That's happening during a make integration-test so maybe a very fast start and stop could cause that

Looks like the log is clipped from the right and I can't see the line numbers for libcontainerd.
@mlaventure What if utils.IsProcessAlive(r.daemonPid) returns false before the cmd.Wait() returns.

Looks like the log is clipped from the right and I can't see the line numbers for libcontainerd.

awww, my bad :( (terminals..)

@tonistiigi was spot on, incoming PR to fix it.


Update RunONNXModel.py

This patch updates the script RunONNXModel.py by:

adding option save_onnx to save the input model
adding option verify_all_ops to enable/disable verifying all operations when using onnxruntime
fixing a bug when verifying all ops where FloatType was used as default.

Jenkins Linux s390x Build #3687 [push] Update RunONNXModel.py (... started at 13:56

Jenkins Linux ppc64le Build #2803 [push] Update RunONNXModel.py (... started at 14:03

Jenkins Linux amd64 Build #3696 [push] Update RunONNXModel.py (... started at 12:56

Jenkins Linux amd64 Build #3696 [push] Update RunONNXModel.py (... aborted after 47 min

Jenkins Linux s390x Build #3687 [push] Update RunONNXModel.py (... aborted after 47 min


expect: clarify errors with .not and equal Expected and Received

Summary
Currently, errors generated using matchers with .not mostly only show the fact that not is being used in the expect(received).not.toEqual(expected) pseudocode. This leads to (IMO) confusing errors like:
Expected: 42
Received: 42

My idea is to replace the Expected: 42 with what the matcher really expects in this case: Anything other than 42.
Expected and Received are swapped so that "anything else" comes after "42"

The concrete phrasing may be subject to debate ofc, not sure about the "length" and "thrown substring" ones.
Would love to hear what @pedrottimark in particular thinks about this way of handling .not matchers.
Note: There are matchers that can cause Expected and Received to be the same without using .not, e.g. toBeGreaterThan. I also find errors from those somewhat weird, but did not touch them for this PR.
Test plan
Updated snapshots

Thank you for moving forward when I was stuck :)
Here are some questions that have been in my mind:

Can report omit Expected because it is redundant? Maybe for .not.toHaveLength but not as a general pattern.
How to balance information that looks weird when correctly written test fails (especially during first phase of TDD) with information that might be useful to debug incorrectly written test? For example, if tester includes .not by mistake or computes incorrect expected value.
How to repeat that assertion is negative without forcing testers to stop and read? To say it another way, in a way that allows testers to selectively ignore information that is not relevant to them.
How to make sure that improvements for redundant literal expected values are not regressions for more subtle regexp, substring, or asymmetric matcher?
What to do for number matchers because .not means opposite direction of interval?

I am working on some pictures of an alternative pattern that we can compare and contrast.

Here are pictures of a pattern for y’all to discuss:

include explicit not in label for expected value
inverse highlight occurrence of expected value in received value when possible

Current or near future baseline is at left and improved is at right.
.not.toContain when expected is string:

.not.toEqual when expected is asymmetric matcher:

.not.toEqual when expected is literal array:

.not.toHaveLength seems clear enough (to me :) without Received length:

.not.toMatch when expected is regular expression:

Here are pictures of a pattern for numeric matchers to include in label for expected value either:

not
comparison operator

Current or near future baseline is at left and improved is at right.
.toBeCloseTo

.toBeGreaterThanOrEqual

.toBeLessThan

Although I didn’t (yet) provide picture of equal expected and received, this pattern might make it look less weird.

I had the same idea about showing >, <= etc. for number comparisons - after experimenting a bit I chose to focus on the not parts first.
Note that, unfortunately, not on number comparisons is not as simple as you made it on the right side.
"Not >" is not the same as "<=" because of NaN.
I love the not.toContain / toMatch!
For the ones where Expected and Received are the same (toEqual, toHaveLength) I think I still prefer my solution of not printing the value twice, but instead using any other value etc.
To answer your question

Can report omit Expected

Omitting it completely would make it worse IMO, I think avoiding duplication with Received (as was the goal with my implementation) is a good intermediate route
With almost all of them, getting the phrasing right is hard - trade-offs between being concise vs. fluent/correct English.
On your question

How to balance information

I'm not sure, what information would you consider useful in the two cases respectively?

Good point about NaN for number matchers. To be correct is also to be more consistent:

Thank you for patience with my mind going outside scope of this pull request :)

You should definitely make some PRs with your number, match/pattern and asymmetric matcher improvements.
About to{Be{,InstanceOf},{,Strict}Equal,HaveLength,Throw} (except toThrow string because that is covered by your pattern improvements): Do you prefer putting not after them (I think it sounds awkward) - I'd close this PR then in favor of your upcoming implementation - or would you like to use the any other x style of this PR in some form for those matchers?

Good question, what did I mean? When a test fails, we need useful information to decide:

is the assertion incorrect, especially the expected value?
why is the received value computed by code incorrect?
are both incorrect?

I agree with your first comment that .not in matcher hint is not enough (pardon pun :)
With an Expected … not: pattern for labels:

it seems like enough-but-not-too-much of visual difference compared to positive matcher
it is still possible to align the values

It seems like any other … to display expected relative to received:

can be misunderstood: if expected value is incorrect, then received is correct (see 3 above)
can seem like double negative: when test fails in first phase of TDD, received is often incorrect

Can we prototype some potential solutions which display:

Expected … not:
some non-redundant description of received value that is counterpart to any other …

My gut feeling is when a report provides additional useful information about received value, to omit the directly redundant received value is an alternative to consider.
For example, if .not.toHaveLength displays Expected length not: and Received array: or Received string: then you have useful information to decide:

is the expected (not) value incorrect?
why is the received value incorrect?

For a test like .not.toBe referential equality, I think only Expected not: is worth considering.
Thanks for your patience with my slow cooker brain. If I sound stubborn, please forgive me.

For .not.toEqual do you think we can use equality of serialized values as heuristic to distinguish:

expected which has some abstraction like asymmetric matcher, therefore you might need both expected and received to decide why the test failed
ordinary deep equality and as I suggest in previous comment, can we think of a short descriptive phrase to say received is same as expected?

So the pattern you're suggesting would be:
expect(received).not.toEqual(expected);

Expected not: ["asdf"]
Received a value equal to the one that was not expected

And you're looking for a concise phrasing for the Received line?

Yes, can we follow that path of prototyping for a while and then weigh the pros and cons?

I am thankful that you saw problem with reports for .not matchers. They remind me of relevance question that the best reviewer of my technical writing often asked: “why are you telling me this?”

Can you proposed some phrasing patterns about received value for matchers:

.not.toBe
.not.toBeEqual if serializations of expected and received are equal
.not.toBeStrictEqual if … are equal
.not.toHave{BeenCalled|Returned}Times
.not.toHave{BeenCalled|Returned}With if … are equal
.not.toHaveLength
.not.toHaveProperty(keyPath) related to key path
.not.toHaveProperty(keyPath, value) related to value if … are equal
.not.toMatchObject if … are equal
.not.toThrow(object) related to message
.not.toThrow(class/constructor) related to class/constructor

In preceding negative matchers, when serializations of expected and received are not equal, then report can display expected and received values.
When we have a pattern that scales to the variety of Jest matchers (and community matchers, for bonus points :) then we can move forward with several small and independent pull requests.
Current report seems okay:

with Received: only for positive and negative matchers: .toBeDefined, .toBeFalsy, .toBeNaN, .toBeNull, .toBeTruthy, .toBeUndefined

Proposed improvement seems okay:

with comparison operator and not if negative for number matchers: .toBeCloseTo, .toBeGreaterThan, .toBeGreaterThanOrEqual, .toBeLessThan, .toBeLessThanOrEqual
with inverse highlight for not expected item or substring for matchers: .not.toContain, .not.ToContainEqual, .not.toMatch, not.toThrow(string), .not.toThrow(regexp)

I'll list a few options with their downsides. Not sure we'll find something that does not allow for any complaints, but maybe something with only downsides we can live with.

Expected: ["Alice", "Bob", "Eve"]
Received: ["Alice", "Bob", "Eve"]

Expected length: 3
Received array:  ["Alice", "Bob", "Eve"]

(Current message)
Confusing because it looks like the matcher got what it expected, so why did it throw...

Received: ["Alice", "Bob", "Eve"]
Expected: any different value

Received array: ["Alice", "Bob", "Eve"]
Expected:       any other length

(My initial proposal)
Swaps Received and Expected

Expected not: ["Alice", "Bob", "Eve"]
Received:     ["Alice", "Bob", "Eve"]

Expected length not: 3
Received array:      ["Alice", "Bob", "Eve"]

(Your initial proposal)
Broken English

Expected: not ["Alice", "Bob", "Eve"]
Received:     ["Alice", "Bob", "Eve"]

Expected length: not 3
Received array:      ["Alice", "Bob", "Eve"]

Something after the colon that is not the printed value, might not be a problem because the color highlighting still distinguishes the printed value?

Expected: value !== ["Alice", "Bob", "Eve"]
Received: 			["Alice", "Bob", "Eve"]

Expected: length !== 3
Received array:      ["Alice", "Bob", "Eve"]

Messy (+problem of the one above), but on the other hand more in line with the proposed number matchers

Unexpected: ["Alice", "Bob", "Eve"]
Received:   ["Alice", "Bob", "Eve"]

Unexpected length: 3
Received array:    ["Alice", "Bob", "Eve"]

Sounds like "unexpected token", not clear what was expected instead.

Not expected: ["Alice", "Bob", "Eve"]
Received:     ["Alice", "Bob", "Eve"]

Not expected length: 3
Received array:      ["Alice", "Bob", "Eve"]

Does not work well with "Not expected value", "Not expected length", ...

Expected value different from: ["Alice", "Bob", "Eve"]
Received: 				       ["Alice", "Bob", "Eve"]

Expected length other than: 3
Received array:             ["Alice", "Bob", "Eve"]

Long

Expected: Not<["Alice", "Bob", "Eve"]>
Received: ["Alice", "Bob", "Eve"]

Expected length: Not<3>
Received array:  ["Alice", "Bob", "Eve"]

Hard to read depending on value, conflates .not with actual asymmetric matchers

Bravo! Expected: not … is small change that makes big difference to my eyes.
Do you also have any ideas for phrasing pattern when received value is referential or deep equal to (not) expected value?

Here are updated pictures for two number matchers:

Closing in favor of Mark's PRs


Add installation instruction for Fedora (#7107)

I am not sure why it is necessary to add the include for openblas manually, the path https://github.com/dmlc/mxnet/blob/9efb2d93f77043fab1765e1a4969ecf9f0fb4e65/cmake/Modules/FindOpenBLAS.cmake#L9 here is correct. Is that not used by default?

what version of Fedora is this tested on? We have CI tests for validating installation instructions. Not sure if Fedora is popular enough to warrant being tested in CI.
@sandeep-krishnamurthy what do you think?

@madjam I tested this with Fedora 26, and let me test it as well with Fedora 25. Older versions are not supported anymore.

@kottmann - Thank you for the contribution. However, I see below issues to accept this contribution.

We do not have CI setup for Fedora distribution.
Due to very few customer/developer base, I do not see it as the higher priority task that will be planned soon.
Without tests, I see a greater risk in having the installation guide on the docs site. As it can lead to broken installation guide and we will never notice.
Following the Ubuntu installation guide, I am hopeful that users will be able to find equivalent installation command for Fedora.

@sandeep-krishnamurthy I think it would also add value without CI, because it will make it easier for people to figure it out them self and if it is broken they could also send a PR to fix it again.
About point 4, today you still need to add this include /usr/include/openblas manually, maybe we can somehow fix that in the build and people would get away transforming the Ubuntu steps to Fedora.
Do you think it would be worth fixing that?

@kottmann that is a good suggestion - Can you please open a different PR for that?

The proposed steps also work with Fedora 25.

The instruction for ubuntu and fedora is mixed together. Would be better to add a selection button.
Close for now. Let's revisit in the future to list instructions for different distributions.


[SMALLFIX] Fixed a bug in lineage client, and added more logging to lineage master

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5676/
Test FAILed.

Already fixed at https://github.com/amplab/tachyon/pull/1718