Error when computing light curve

Hey everyone!
I'm trying to make a light curve for a gamma ray binary but no matter how I set up my bins I always get a type error saying "Object of type int64 is not JSON serializable." It's strange because I only get this error massage at the very end after the analysis has been performed for all bins already and relevant lightcurve folders have been generated in the working directory. I know the analysis is in fact occurring, as I do get bin-by-bin test statistic values for my sources (as well as the code taking a while to run), it's really just the end that messes it up. Does anyone know how to fix this?

What are you using to do this analysis? I think you might be using Fermipy which is a community driven project and not supported by the FSSC.  Looking at their issue tracker, this seems to report a similar error to what you see: https://github.com/fermiPy/fermipy/issues/496

@donhorner Oh yeah I am using Fermipy. Sorry, I'm fairly new to LAT data analysis and assumed it was the standard so didn't mention it. I will definitely try the solition from the issue you linked and see if it works, thanks!


Move wasm-gc into a library crate

It would be really nice to have this as a library crate.
I started using wasm-gc in my cargo-web, and for now I've just copy and pasted it into my own repository. I'd love to get rid of it and just grab a crate off crates.io (:

Sounds plausible to me! I'd be more than willing to have a PR to separate and could then publish.

Created a PR here: https://github.com/alexcrichton/wasm-gc/pull/13 (:


Post processing with ImageDataGenerator

ImageDataGenerator offers argument of 'preprocessing_function' which is run BEFORE any modification  is made to input. I want to perform CLAHE on image input AFTER modifications like random shifts, rotations etc have been made to it. Please suggest a suitable way out.

I think this in a mistake in the documentation, I also stumbled upon this.
When you look at the code, the preprocess_function is executed at first in the "standardize" function. However, in the Generator, the "standardize" function is executed after the "random_transform" function, which is responsible for the shifts, rotations etc.
So actually, it behaves exactly as you want now, the documentation is just wrong,


Ember 2.16 new MODULES API IMPORT.

Any hint for the transition to the new import module system described here? https://emberjs.com/blog/2017/09/01/ember-2-15-released.html
The 2.16 stable is approaching...
I have this:
Uncaught Error: Could not find module emberimported fromember-simple-auth-token/authenticators/token``

Might have to propose a PR for this tbh


is MKL now open?

It appears like you have open sourced MKL library for sgemm. Thanks

Hi @cheers00 ,
MKL sgemm implementation is not open sourced. This project provides wrappers that can be used with sgemm implementation of your choice, MKL sgemm or some other, to run on a hardware of your choice, CPU or GPU. Check the README.md for details about supported backends and hardware platforms. You can check the below comment to understand the difference between different oneMKL products: https://github.com/oneapi-src/oneMKL/issues/22#issuecomment-635029135
Hope that helps.


refactor #133

@LiquidTheDangerous Did a little bit of refactor on your PR please check

@xvzc done :)


Unable to install using yarn

MacOS 10.12.6
Yarn v0.27.5
» sudo yarn global add https://github.com/reasonml/reason-cli/archive/beta-v-1.13.6-bin-darwin.tar.gz
yarn global v0.27.5
warning package.json: No license field
warning No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
⠁
⠁
⠁
⠁
error /Users/srg/.config/yarn/global/node_modules/reason-cli: Command failed.
Exit code: 1
Command: sh
Arguments: -c ./postinstall.sh
Directory: /Users/srg/.config/yarn/global/node_modules/reason-cli
Output:
ERROR:
  /Volumes/Terra/Archive/sync/appdata/.config/yarn/global/node_modules/reason-cli/rel/3.x.x
Could not perform binary build or installation because the location you are installing to
is too 'deep' in the file system. That sounds like a strange limitation, but
the scripts contain shebangs that encode this path to executable, and posix
systems limit the length of those shebang lines to 127.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

On another machine I've got infinite resolving packages (stops on pend package)
yarn global add https://github.com/reasonml/reason-cli/archive/beta-v-1.13.6-bin-darwin.tar.gz            ~/dev 130 ↵
yarn global v0.27.5
warning package.json: No license field
warning No license field
[1/4] Resolving packages...
⠈<EMAIL_ADDRESS>

I second this issue.  What motivated such a limiting design decision?  This makes it near impossible to incorporate use in many scenarios...  Not good.

The recent esy release should work with yarn:
yarn global add https://github.com/reasonml/reason-cli/archive/3.0.0-bin-darwin.tar.gz

Yes but the postinstall.sh still fails.
In my case, /home/pcj/.cache/bazel/_bazel_pcj/b5f39829d3fb6b9c31bb0d097d1fa7b3/external/reason/node_modules/reason-cli/rel is too deep inside filesystem, Esy 'won'\''t' be able to relocate binaries

@pcj is that really a global location? It looks pretty deep.

No, not global.  That's the problem (I don't want a global install).

Can I learn a little more about your use case? Technically reason-cli does support local installs of a project (but not if it's too deep because ocaml itself doesn't support being installed at very deep locations in the file system).
However, there are other options for local dependencies on Reason but I'd have to hear more about your use case. What kind of app are you building?

The original issue has been resolved in the latest 3.0.0 release, but I'll keep this open to discuss the "deep paths" use case.

Hi
I'm also having this problem using a nvm node installation.
I also use pnpm and the install folder gets way too deep.
Is there any workaround or should I just stop using nvm?
Thanks


feat(i18n): enhanced i18n support

Context
Even more i18n support
Previous PR

Changes & Results
Reworked components from ui/src/components (most of)
Only TEST-lng and en-us locales affected

Testing
Switch to test-LNG

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] OS: Windows 11
[x] Node version: v18.18.0
[x] Browser: Chrome 118.0.5993.120

is this ready for review or still in draft?

not ready yet

@jbocce Thanks for the review, I really appreciate it. The branch has been updated according to the requested changes
I've, never worked with a fork before. Did I update the branch correctly?


[ISSUE] 405 Method Not Allowed - AskNavidrome -> Navidrome

Describe the issue
I have managed to create the Alexa skill, set up the asknavidrome service and expose it via Tailscale Funnel + nginx, but I get this log when I look at my systemctl status for the asknavidrome podman service.
Operating System
NixOS
To Reproduce
Using the Test Skill interface in Alexa Skills. It connects to the skill service okay, but when I request a specific song I get these logs:
Logs
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,784 - asknavidrome.subsonic_api - DEBUG - In function search_artist()
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - DEBUG - In GeneralExceptionHandler
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - General Exception: HTTP Error 405: Method Not Allowed
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - Request Type Was: IntentRequest
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - Intent Name Was: NaviSonicPlaySongByArtist
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,805 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:16] "POST / HTTP/1.0" 200 -
aug 15 14:24:19 nixos asknavidrome[202111]: 2024-08-15 12:24:19,717 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:19] "GET /queue HTTP/1.0" 200 -
aug 15 14:24:23 nixos asknavidrome[202111]: 2024-08-15 12:24:23,911 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:23] "GET /buffer HTTP/1.0" 200 -
aug 15 14:24:27 nixos asknavidrome[202111]: 2024-08-15 12:24:27,482 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:27] "GET /history HTTP/1.0" 200 -

Hi Jack,
Can you confirm that the skill is connecting to navidrome, it would have
been included earlier and if it is can you confirm which version of
Navidrome you are using?
On Thu, 15 Aug 2024, 13:27 Jack Oliver, @.***> wrote:

Describe the issue
I have managed to create the Alexa skill, set up the asknavidrome service
and expose it via Tailscale Funnel + nginx, but I get this log when I look
at my systemctl status for the asknavidrome podman service.
Operating System
NixOS
To Reproduce
Using the Test Skill interface in Alexa Skills. It connects to the skill
service okay, but when I request a specific song I get these logs:
Logs
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,784 - asknavidrome.subsonic_api - DEBUG - In function search_artist()
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - DEBUG - In GeneralExceptionHandler
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - General Exception: HTTP Error 405: Method Not Allowed
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - Request Type Was: IntentRequest
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,803 - root - ERROR - Intent Name Was: NaviSonicPlaySongByArtist
aug 15 14:24:16 nixos asknavidrome[202111]: 2024-08-15 12:24:16,805 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:16] "POST / HTTP/1.0" 200 -
aug 15 14:24:19 nixos asknavidrome[202111]: 2024-08-15 12:24:19,717 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:19] "GET /queue HTTP/1.0" 200 -
aug 15 14:24:23 nixos asknavidrome[202111]: 2024-08-15 12:24:23,911 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:23] "GET /buffer HTTP/1.0" 200 -
aug 15 14:24:27 nixos asknavidrome[202111]: 2024-08-15 12:24:27,482 - werkzeug - INFO - <IP_ADDRESS> - - [15/Aug/2024 12:24:27] "GET /history HTTP/1.0" 200 -
—
Reply to this email directly, view it on GitHub
https://github.com/rosskouk/asknavidrome/issues/47, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALZJF3TMQODS6YZAWYMMMMTZRSNBNAVCNFSM6AAAAABMSDR6MWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DOOJVGM3TQMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hey! I'm having a hard time accessing those logs. I'm using systemctl status podman-asknavidrome at the moment to get a log of what's happening.
Navidrome version is [0.49.3](https://github.com/navidrome/navidrome/releases/tag/v0.49.3)

Here is my NixOS configuration also:
{ config, pkgs, ... }:

{
        config.virtualisation.oci-containers.containers."asknavidrome" = {
                autoStart = true;
                image = "ghcr.io/rosskouk/asknavidrome";
                ports = [ "5000:5000" ];
                environment = {
                        NAVI_SKILL_ID = "REDACTED";
                        NAVI_SONG_COUNT = "50";
                        NAVI_URL = "https://REDACTED.ts.net/navidrome";
                        NAVI_USER = "REDACTED";
                        NAVI_PASS = "REDACTED";
                        NAVI_PORT = "443";
                        NAVI_API_PATH = "/rest";
                        NAVI_API_VER = "1.16.1";
                        NAVI_DEBUG = "3";
                };
        };
}

Ah, I found it through journalctl.
I am getting a 'Failed to connect to Navidrome'. All the details are correct, and I can /rest/ping it no problem from Postman.

Ok, that's definitely the problem.  I'd recommend you triple check the
config.  And if possible see if you can perform the ping API call from
within the container
On Thu, 15 Aug 2024, 13:57 Jack Oliver, @.***> wrote:

Ah, I found it through journalctl.
I am getting a 'Failed to connect to Navidrome'. All the details are
correct, and I can /rest/ping it no problem from Postman.
—
Reply to this email directly, view it on GitHub
https://github.com/rosskouk/asknavidrome/issues/47#issuecomment-2291219330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALZJF3VUPA3FXYPA4WCSXBDZRSQTZAVCNFSM6AAAAABMSDR6MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGIYTSMZTGA
.
You are receiving this because you commented.Message ID:
@.***>

I've taken it out of systemctl for now and just doing docker run instead. It's very confusing because it says connected, and then not.
2024-08-15 13:41:29,088 - asknavidrome.subsonic_api - DEBUG - Connected to Navidrome
2024-08-15 13:41:29,088 - asknavidrome.subsonic_api - DEBUG - In function ping()
2024-08-15 13:41:29,112 - asknavidrome.subsonic_api - ERROR - Failed to connect to Navidrome

If I ping the URL from Postman, with the credentials I have in the Docker run env variables, i get a <subsonic-response> back, but it still says failed to connect when i boot the container. Very odd.

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   155    0   155    0     0   8403      0 --:--:-- --:--:-- --:--:--  8611
<subsonic-response xmlns="http://subsonic.org/restapi" status="ok" version="1.16.1" type="navidrome" serverVersion="0.49.3 (8b93962f)"></subsonic-response>

Looks like I can ping it from inside the container, so I'm not sure what's up at this point lol.

Got it working. Couple things I noticed / tried;

Works well with the demo navidrome instance, so I don't think it's anything wrong with the code.
Didn't like it being on a /navidrome proxy pass on nginx - for some reason.
Set it to the root /, and had to add /navidrome/rest in the API path, and then it worked.

Thanks for being a great rubber duck! 😆 🦆


V3 getBody()->getContents() no longer returns full stream on second call

BC Break Report

Q
A

Version
3.0.0

Summary
In v2, the default the default behaviour of the ServerRequestyFActory was to return a request object, where you could get the contents of the body multiple times. in v3, every new read of getContents() will result in an empty string. (Casting the body to a string still works as before).
Since the way it currently works is correct according to PSR implementation, it should probably be updated in the migration guide. And it should not be changed back to the v2 implementation
Previous behavior
getBody->getContents would return the full stream every time
Current behavior
getBody->getContents will return the full stream the first time, and then an empty string on consecutive calls.
How to reproduce
Send a post request and call request->getBody()->getContents() multiple times.

This is expected behavior as per PSR interface getContent() is stream pointer aware:

Returns the remaining contents in a string

Previous implementation was bugged. See #150

Reopening as documentation issue. Mention of behavior fix can be added to migration guide.

Thanks, ill try snd update the docs tomorrow


XML report wasn't generated

Hello guys.
Is there some issue on v5 beta 7 regarding to the reports XML?
I ran here and the report wasn't generated. Is there a new option?
My config:
spotbugs {
	toolVersion = spotbugsVersion
	effort = 'max'
	reportLevel = 'low'
	ignoreFailures = false
	showStackTraces = true
	showProgress = true
	//noinspection GroovyAssignabilityCheck
	excludeFilter = file("${appResourceDir}/security/spotbugs-security-exclude.xml")
}

It is an intentional breaking change from the beta1 release. To generate an XML report, configure it explicitly:
spotbugsMain {
    reports {
        xml {
            enabled = true
        }
    }
}

It is an intentional breaking change from the beta1 release. To generate an XML report, configure it explicitly:
spotbugsMain {
    reports {
        xml {
            enabled = true
        }
    }
}

/** @deprecated */
@Deprecated
public void setEnabled(boolean b) {
    this.isEnabled.set(b);
}

/** @deprecated */
@Deprecated
public void setEnabled(Provider<Boolean> provider) {
    this.isEnabled.set(provider);
}

This is marked with @Deprecated. What is the right way?

Try beta 8, it can use the required parameter instead.


you dead?

Mainly!

sad noises

What did you want to do / do you need?
It's a pretty simple library if you want to dig in!

https://github.com/davestewart/vee-element/blob/master/src/main.js
https://github.com/davestewart/vee-element/blob/master/src/drivers/vee.js

Yes.. I don‘t know if that makes much sense. It depends on an old vee-validate version. On the one hand it would possibly takel less time to dig into this lib and fix the issue, on the other hand if I refactor all the existing forms to use vee-validate v3 its future proof. I‘ll see…
My problem is, that here and there async serverside validation does not work propery. The strange thing is, that in other constellations the same validators are working flawlessly.

I'm a contractor, so usually the case is that the client I'm working with will use Technology X and I'll developer OSS around that, then when I move on, I just don't use it any more.
I think that was the case here, which is a shame, as I really liked this project! I thought it was a creative way to solve an "unsolvable" problem.
Nothing to do with the code / approach though; I think that is solid-enough.

I see

PRs are open. Happy to set up a proper versioned set of releases for Vue / Vee Validate versions...

Then you want to invest some time in this project? So not dead?
If so, I'll try to find some time and get a PR together to use the new vee-validate version.

Well, it's still useful! I just don't use it these days 😺

Its useful indeed. I‘m using it for a huge project with many forms until now.
I have a similar situation with one of my OS projects (l5modular) which i have written some years ago but stopped using. Now I‘m just maintaining it as a sidequest.
No idea if you‘re up to date, but it is considerable to know that Vee-Validate can be used with Element UI without the need of extra packages like this one. But its not that nice. Much more markup and no centralized rules.
See https://vee-validate.logaretm.com/v2/examples/validation-providers.html

@Artem-Schander If you're looking for some specific improvements on the library, do let us know!
I just couldn't think of many improvements other that moving to a newer version of vee-validate 😅


Is there a good way to not add nodes if graph is being dragged?

Using sigma, I have implemented an ability to add a node on left click. The problem is that the functionality of dragging a graph is enabled by left click + hold with mouse.
What that results in is when the graph is going to get dragged it will also add a node when the intention is just to drag the graph.
What I would preferably like is a solution were I can differentiate between a drag (click + hold) and just a click. Thanks

any ideas @Yomguithereal

Sigma's click events include an isDragging flag which may be of use to you here, for example:
s.bind('clickNode', function(e) {
  console.log(e.data.captor.isDragging);
});

This then allows you to differentiate between a graph drag and a 'regular' node click.

@AVermeij Is this not only the case if the cursor is on a node? In many cases, the graph will be dragged from outside the a node. Thanks for the reply.

I'm guessing you've implemented your node add functionality by binding an event to clickStage?
If so, you can also use the flag as follows:
s.bind('clickStage', function(e) {
  if (!e.data.captor.isDragging) {
    // Add node add logic here
  }
});

@AVermeij I am actually using this implementation currently:
dom.addEventListener("click", function (e) {
//node addition logic here
  }
});

What is the difference between the two?

The main difference would be that sigma's clickStage event emits a few extra useful properties relating to the graph instance, including the isDragging flag, a reference to the underlying sigma renderer, as well as clientX, clientY, x and y properties for getting the coordinates related to a click. My recommendation would be to use clickStage to benefit from this :-)

@AVermeij Cool, thank you André! You have improved my night. I will reply if I have any more questions when I implement this.


Enhancement: ArrayBuffer.transfer

It'd be nice to have ArrayBuffer.transfer support.
(Sorry for lack of a PR but currently just documenting issues we could use in IndexedDBShim in Node environments.)

Unfortunately that's not something we can implement, as it's not a web API, it's a nonstandard Firefox API.
I have vague hopes that we can add this to the JS language; /cc @samuelgoto. If you could write up a brief paragraph on why this would be useful to you, that'd help us justify it to the committee :)

A postMessage polyfill could leverage it to ensure the original array buffer was consumed.

(Came across this in running https://github.com/w3c/web-platform-tests/blob/master/IndexedDB/idb-binary-key-detached.htm with IndexedDBShim, our polyfill of IndexedDB for Node and the browser.)

We could also use access to the [[Detached]] slot and to IsDetachedBuffer.

Also, I might add my general feeling that the Structured Cloning Algorithm is something that ought to be well-supported in ES beyond HTML. As it is employed by the one mechanism for databases on the browser, it would be ideal to have full parity (including optionally reusing the same IndexedDB API as we attempt to do in our polyfill) in other environments like Node.
The algorithm's uses would I think particularly become more expansive if https://github.com/w3c/IndexedDB/issues/64#issuecomment-298591208 could be implemented, a means for serializing structured clones to JSON.

This is not in jsdom’s power to implement, but rather Node.js or V8’s.


[vmss]: user new api-version 2018-10-01 for Automatic OS Upgrade GA

Spec PR: https://github.com/Azure/azure-rest-api-specs/pull/3896
@adewaleo, if you are interested, let me know. This needs to get done for the current release

#7461 handles it


Support stopping container gracefully

Docker can't stop the container gracefully and will use SIGKILL (exit code 137).
I believe this is due to not handling the signal SIGTERM in the shell script.

Fixed!


Use 'em' to size TextField elements relatively to fontSize

Currently TextField is using fixed pixel values to size the different
elements composing the component. However, if one wants to change the
size of the component to fit a given design, it's hard to achieve as
there is many sizings to manually set.
This commit is a proposal to size the inner parts of the component
relatively to the fontSize property of its root element, so it's the
only property the user needs to touch.

@thomasguillory Interesting approach, could you add an example of this in the documentation?
Another way to do it would be to compute values using the fontSize property. I'm wondering what's best.
Also what about styles.floatingLabel.transform = 'perspective(1px) scale(0.75) translate3d(2px, -28px, 0)';?

@oliviertassinari
I missed the transform statement, I'll update that + the documentation.
The advantage of computed values over em might be less inconsistent rounding across browsers.
Also, don't you think that such a modification should be done for every material-ui components and not only TextField ?

IMO the TextField should be using flexbox. By using absolute and relative values, we have to set a lot of imperative position.
I also think that px is better that em for the same reason that avoiding nested class declaration is considered as a good practice. However in this case (because we are using relative / absolute position) I'm up for this change :+1:.

Also, don't you think that such a modification should be done for every material-ui components and not only TextField?

I would say no. Do you have a specific component in mind?

@oliviertassinari I did the missing changes.
There is however one gotcha: _handleTextAreaHeightChange method needs px to em conversion. I did it relying on fontSize. However, if the user pass anything else than a pixel value in this.props.style.fontSize, it won't compute the value correctly.
We would have the same problem if we decided to compute everything using this.props.style.fontSize. Do you have a solution to that?

However, if the user pass anything else than a pixel value in this.props.style.fontSize, it won't compute the value correctly.

I would say that right now, people are not using the fontSize style property since this TextField is not supporting it correctly.
I think that we should warn them if they do so.
@shaurya947 Are you ok to use em instead of px here?

@thomasguillory @oliviertassinari if I understand correctly, what we're proposing is that the user would need to pass in a px value to the style.fontSize prop, and all underlying computation would be done using em (so that things can be scaled relative to the font size)?
If that is the case, I'm good with that. I think most people are already using px for such props so it shouldn't bother them. Yes, we can display a warning if they use another unit.

I have just tried your PR. It seems that the height of the HintText changed and that the Floating Label is too high on the example you added. I feel like using px will be simpler to follow really  closely the spec (that use dp).

An interesting approach. But given the subsequent and planned changes around styling, I'm closing for now. We can reopen if there's still merit.


Consider using opencollective-bot

See https://github.com/apps/opencollective-bot
When an issue is closed, it posts a comment suggesting a donation.

When an issue is closed

When I first saw the title of this issue, I liked the idea but was wondering how "noisy" it may be. The fact that the message is only added on issue closing helps reduce that noise (at least IMO) although presumably that comes with the drawback of that comment being overlooked (at least overlooked more often than if the comment were added on issue open)

Yea it's true. Though every issue gets pinged on close anyway.
A sort of midrange option would be to add it to the PR close message, that we already post.

I do like the idea of adding it on issues. Donations are commonly framed in terms of time or money (whichever is easier/more practical for one to give), and by definition, a PR would be someone who has already contributed their time (and code!).
Adding the message on PR close would be good, but I think it would also be good to include it on issues to hit the broader audience of members of the Shields community that are requesting features, reporting bugs, etc.

This is mostly off topic but, I think it'd be cool if we could have bots post messages based on conditions. For example if we tag an issue as good first issue, have a bot auto-comment links to our tutorial with a corresponding message, etc. Similarly, maybe we could only add the open collective message if an issue/PR is opened by a first timer (and not post that message when a contributor/member opens an issue or PR)


bug: Unable to (de)normalize an array of values

Hi there,
Love the project, always a fan of using decorators to avoid extra schema definitions everywhere!
Ran into an issue though, I can't work out how to (de)normalize to and from an array of values. In normalizr you just wrap the schema in [], however I've dug through your source and cannot find a way to do it.
Are you able to please advise? Thanks!

Ended up making a PR to address the issue raised, let me know your thoughts 😄

Sweet! Thanks @edcarroll! Let me review the PR. I'll add the necessary documentation changes.
What are you ideas regarding implementing the missing schema types? I'll add some issues for these as well.
Cheers,
Michael
PS. sorry for the late reply!

Hey @mchlbrnd, no worries, thank you for getting back to me 😄
So I ended up adding a few things forgetting there was a PR on my fork, so let me know if there's anything in there you don't like.
Hadn't yet thought about adding the other types yet, was basically adding functionality as I ran into it. Will be able to come back to this in a few days though (I hope) with some ideas 😄

I just added some more issues. No worries about the additional stuff in the PR. It is very welcome!


Installation instructions

for people not willing to fetch the GH repository
preventing version conflicts with --locked

Other than the spelling issues I am a fan of this change. If you can correct those, I will merge this. Thanks!

Fixed the typo I found. Can you point the other one(s) ?

Just the 'intent' vs 'intend' issue. Everything else looks good.

Thanks for your contribution


fix: allow images (including stills) for an episode to be fetched

It seems like TmdbEpisodeDetail has images wrapped inside a TmdbResult which breaks the response so I've taken it out, not sure if this was intentional or not?
I've also added stills to TmdbImages as episodes can return them, example:
https://developer.themoviedb.org/reference/tv-episode-details
series_id: 96677
season_number:1
episode_number:1
I've also added tests for episode images

@ChrisKruegerDev is it possible to get this reviewed? I want to raise quite a few PRs to add functionality

@ScottCooper92 Thank you a lot. This was copy paste by accident (from shows).


Create Player Bio “brandi”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
9275c389a6c467947589a8ff72b8313fe752b2df

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62d8920c70d00d00086b9788


Research ETOR Processes and Challenges for Healthcare Providers

As a healthcare provider,
In order for the Trusted Intermediary MVP to provide value,
I need the team to better understand the processes and challenges of electronic testing and orders.

Replaced by #49


Use of Kafka Server in the toolkit

Hi again,
Since there is very little documentation about the testkit, I'm really struggling with the use of KafkaServer.
First of all, I don't really know if I'm supposed to create a new KafkaServer for every test or if I can reuse the same server for all the tests in my suite ?
Second, I would prefer to re-use the same instance in all my tests in the Suite. But the problem is that the consume function reads every message from the log and not just those I have produced in the current test but also messages already consumed in previous tests. Is there a way, other than having a new instance of KafkaServer for every test, to remove the existing messages at the end of each test or to only consume the messages I'm interested in in the current test ?

Hi,
Probably best to use the same KafkaServer within a suite as it does take a while to startup.  Indeed there are some tricky issues with Kafka around starting consumption at the right point in a test setup.  I remember having the same type of issues when we first created the Testkit.  I would suggest you check out some of our unit tests for examples: https://github.com/cakesolutions/scala-kafka-client/tree/master/akka/src/test/scala/cakesolutions/kafka/akka.
We usually create a random topic for each test in a suite for isolation to avoid the issue you mention and also use OffsetResetStrategy.EARLIEST on the consumer to make sure we pick up all messages a test producer delivered.
Hope that helps.

Thanks I hadn't thought about a random topic for each test.
I wonder however how that suite can pass https://github.com/cakesolutions/scala-kafka-client/blob/master/akka/src/test/scala/cakesolutions/kafka/akka/KafkaProducerActorSpec.scala since the topic is the same in both tests and the kafka server is the same also ? How come the second consume call doesn't fail because of the 3 previous messages ?

Good catch! Both tests write the same data and read all the way from the beginning, which is why they both pass.

Even if it will surely work, having to use random topics in an app with fixed topic titles seems to be a pain to implement in a test environment.
I'm wondering if the best solution wouldn't be just to implement a publicly accessible function to delete the log file after each test as it's done here : https://github.com/cakesolutions/scala-kafka-client/blob/master/testkit/src/main/scala/cakesolutions.kafka/testkit/KafkaServer.scala#L121. That way we can re-use the same server throughout the suite and juste delete the log file after each test. What do you think ?

I would not expect you to be able to use the same KafkaServer after deleting the log file.
I updated the test you referenced to use random topics: https://github.com/cakesolutions/scala-kafka-client/pull/86
BTW in the future Kafka will provide an admin api which would allow us to programatically delete topics:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations

Ok so when this feature is complete, the best way will be to delete the fixed topic after each test ?


Is there a term appropriate for HGNC's notion of "virus integration site"?

HGNC marks the following genes' locus types as "virus integration site". Their definition on https://www.genenames.org/help/symbol-report/ reads:

virus integration site: target sequence for the integration of viral DNA into the genome

It's not very specific, I'm not sure if this is more related to SO's notion of retrotransposons, viral sequence (SO:0001041), or something else. Perhaps it's something that would warrant a new term.
The provenance column links to the articles about the given gene
virus integration site (8)

hgnc_id
name
obsolete
link
provenance

12696
VIS1
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/12696
https://www.ncbi.nlm.nih.gov/pubmed/1682866

22
AAVS1
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/22
https://www.ncbi.nlm.nih.gov/pubmed/1334463

3143
EBVS1
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/3143
https://www.ncbi.nlm.nih.gov/pubmed/6095452

5166
HPV18I1
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/5166
https://www.ncbi.nlm.nih.gov/pubmed/3028716

5167
HPV18I2
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/5167
https://www.ncbi.nlm.nih.gov/pubmed/3033295, https://www.ncbi.nlm.nih.gov/pubmed/7592643

5168
HPV6AI1
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/5168
https://www.ncbi.nlm.nih.gov/pubmed/8118820

5314
HVBS7
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/5314
https://www.ncbi.nlm.nih.gov/pubmed/2830013

5315
HVBS8
False
https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/5315
https://www.ncbi.nlm.nih.gov/pubmed/2845134

@egchristensen I can make a NTR if you can tell me where to put it in the hierarchy


use const instead the string

I think const is better than a string

Thanks for your pr. And by the way, it seems that you open a new pr for the squash commit or for some other reason.  It is recommended to use the git rebase  to squash the commits, and to use git push -f to update the pr code. This will keep the records discussed in pr.

/lgtm

Thanks for your pr. And by the way, it seems that you open a new pr for the squash commit or for some other reason. It is recommended to use the git rebase to squash the commits, and to use git push -f to update the pr code. This will keep the records discussed in pr.

Thanks for your suggestion, i will try it next time

/approve


AP Documentation Sync

Tasks

Implement updated Accord Project documentation.

I'm not sure I understand what this issue is about, could you explain?

Closed with #63


Merge dataset detail branch into master

The current implementation satisfies the needs for this sprint, but any dead links should be removed from the display.

Merge was performed earlier. And now links in the page are checked.


Google custom search API

Possible to include the Google custom search api for searching the image and then send it with photo?

yes it is possible, like t.me/duckpicsbot
but this is not the responsibility of this library you need to make your own code for this and use the lib just to receive and send messages

Closing issue


(PUP-4123) MASTER (caution) Add infrastructure for migration support

MERGE AFTER #3738 has been merged to 3.8 to merge those changes and a revert of the functionality that should not be present on master.

CLA signed by all contributors.

@hlindberg as far as when to merge to master, is this something we actually don't want until 4.1?

@kylog Does not matter actually (this merge only cleans up what will be in 3.8). If we however merge stable -> 3.8 -> master before 4.0 is released, and the PR #3738 has gone into 3.8, then this should be merged. If it is not merged (but 3.8 merged to master before 4.0) performance is slightly worse.

Hold off on merging this until master is for 4.x

@hlindberg or @thallgren: puppet#master is now for 4.1 so we don't need to hold off on merging this any longer. I haven't reviewed this so can't really thumbs-up it but just wanted to confirm that puppet#master is available for 4.1 changes.

This PR should help in merging 3.x to master. Do this merge first, then merge 3x on top. (There has been additional changes on 3.x. causing conflicts after this PR was made). @thallgren feel free to merge this and rest of 3.x to master


Allow to use rados for ganesha exports

@leseb, this is a new feature (not even yet in released luminous version), I think it would be safer to hold on with making this default option.

@jprovaznik fair enough

You're hardcoding the ceph's conf file as '/etc/ceph/ceph.conf'. I'm not sure if that's OK in the ceph-ansible world. Otherwise looks OK to me. Thanks, Jan.


OSMNX 2.0 migration

OSMNX 2.0.0 is released and has a migration guide.

For what it's worth, all of my latest local development has been with osmnx 2.0.0 and so we might just get this for free. Perhaps definition of done would be to pin the dependency to osmnx>=2?

hmm, yes, i guess! that's great, i thought we might get hit with a big API change. i still think we should review the migration guide to make sure all of our assumptions are the same. here's a short list:

does it still build us a directed graph
have the arguments to graph simplification or consolidation changed
are we still requesting the correct highway key filters and other filters (network_type argument behavior matches 1.*)


Bug: encode_wav_header_bytes cannot set nframes

Setting nframes with encode_wav_header_bytes does not work.
A valid wav file cannot be made by joining the generated header with pcm bytes because nframes stays 0 in the header.

Duplicate of https://github.com/otosense/recode/issues/3


fix(@angular/cli): remove modules only on prod

See https://github.com/webpack/webpack/issues/6248#issuecomment-368160223

Closing for now, could not see improvement in benchmarks (see https://github.com/webpack/webpack/issues/6248#issuecomment-368489543).


ACM-12999 - remove velero crds from being reconciled by mch

Description
Removing Velero CRDs from being reconciled by MCH
Related Issue
https://issues.redhat.com/browse/ACM-12999
Changes Made
We are currently on OADP 1.3 with ACM 2.9 but OADP 1.4 is already available
For users of ACM 2.9 who are on a OADP 1.4 supported OCP version , we should enable them to be able to install OADP 1.4 instead
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[x] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[x] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/lgtm


Feature: more types of enum generation

The tsEnum option could have another option to generate enum types with string values
Currently with tsEnum=true generates:
enum  Count {  ONE, TWO, THREE }
i would like to keep my values as strings, but still generating enum types instead of union types like this:
type Count = 'ONE' | 'TWO' | 'THREE'
Support for enum types with value strings like this would be nice :+1: :
enum Count {
   ONE = 'ONE',
   TWO = 'TWO',
   THREE = 'THREE'
}

I ended up adding this to the code, https://github.com/babyfish-ct/graphql-ts-client/pull/32

Generating ts-only enun type is the design of older version, the current version is generating union type.
That's because union type is used by js ecosystem before ts was created. it is too popular.


State/session

Hello.
For chain chat with user we need sometimes to read session data, for example in test, when we have answer buttons (not inline, just buttons) and we need to go for second question, we have to get previous message from database, but it's not practical.
Should I write my own table to store user session or it has something like that? I see only commands.
Regards.

Check SurveyCommand.php which utilizes Conversation class, that implements Finite State Machine, the thing you're talking about.

@CashCode All clear then?

Yes, but I had an issue when I tried to redefine route for command, I mean that there is default command to proceed for example query request (button click), I'd like to store state and proceed request with the same command.


MDN page cause Taffy panic

Link that causes panic: https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements

thread 'main' panicked at taffy-0.5.1/src/style/grid.rs:183:18:
resolve_definite_grid_tracks should only be called on definite grid tracks

Fixed in Taffy 0.5.2


[Identity] Simplest possible exponential retry for IMDS's 404

As issue #12318 states, we're missing one case in which we should retry: when using IMDS MSI, if we get a 404, we should retry with exponential back-off.
Since this retry feature is only going to be used in a specific case within a specific credential, instead of going with policy retries or re-using code from another library, I've added the simplest possible retry mechanism I could thing of.
Keep in mind that I can only work with things configurable during getToken, and we’re trying to avoid changing core code for this.
Feedback appreciated!
Fixes #12318

Feedback from Vinay:

For Java Retry policies, the default base delay is 0f 800 millis and with exponential increment is maxed out at 8s by default. Default number of retries are 3. At exponential rate with base power of 2.

So I'll update the default values based on this.


async hashtags example

Adds an async hashtags example which pulls from a json file. The example data is popular instagram hashtags. I had to filter and sort them for it to work well since there's no string, but there's a comment explaining that this might not be needed in more realistic situations.
https://brigand.github.io/react-mentions/
For some reason, the styles are messed up on my gh-pages, but it works locally (npm start).

Thank you for this example. Really well done!


Remapped CapsLock not acting like a modifier

I just installed Karabiner/Seil on a new machine running 10.11.1.  I imported my settings from an old Mountain Lion machine.
I'm trying to map Caps to Cmd+Opt+Shift+Ctrl.  In the Keyboard Viewer (accessible from the Keyboard menu), I can see that it's registering as an instant press/release of those buttons, even though I'm holding them down.  Did something change to cause this?  What's the workaround?
You can see my settings at the bottom of this gist.

If you did not do "No Action" configuration, this issue might happen.
Please confirm "No Action" configuration.
https://pqrs.org/osx/karabiner/seil.html.en#noaction

D'oh!  Forgot to do that.
Thanks @tekezo!


Code quality: Move Git operations to a different thread

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Related #12737

Changes

Branches are enumerated and filtered on a different thread
Head branch name is now "cached"
Fetch, Pull, Push, Sync, Checkout are now executed on a different thread.

Note
You may need to log-in github from Files Preview or Stable to use some functionalities
Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[x] Did you implement any design changes to an existing feature?

[x] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Check that Files doesn't freeze when opening large git repos
Check that git actions (fetch, pull, push, checkout, sync) still work

Fyi @hishitetsu @hez2010

Should we increase the number of branches that we display?

Should we increase the number of branches that we display?

I think we can do it now that it runs on a separate thread. However, I think we should not display ALL the branches, I guess we may keep it below 50. We may double the threshold (from 15 to 30) and see if it causes any issues (I can't test by myself since I don't have any repo with that many branches)

Let's go with 30 👍

When I return to a folder displaying Git columns with the back button, the Git columns are empty.

When I return to a folder displaying Git columns with the back button, the Git columns are empty.

@hishitetsu there's a PR (#13533) which may interfere with one of yours (#13211)
Because BaseLayout.OnNavigatedTo() is now async, this line of code may reset git columns:
    // Git properties are not loaded by default
    ParentShellPageInstance.FilesystemViewModel.EnabledGitProperties = GitProperties.None;

How should we proceed?

(edit. it seems to work)

I'm not quite sure why this is okay, but it certainly solved the issue.

Are there any good ways to stress test these changes?

I'm not quite sure why this is okay, but it certainly solved the issue.

Making BaseLayout.OnNavigatedTo() async caused this line
https://github.com/files-community/Files/blob/main/src/Files.App/Views/LayoutModes/BaseLayout.cs#L480C11-L480C11
to be executed after this one
https://github.com/files-community/Files/blob/main/src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs#L126
causing EnabledGitProperties to reset to None

When browsing any folder in a large git repo, the UI was still unresponsive, froze everywhere, the app was unusable. This happened with or without VS or debugger attached.

I did some tests, here are the conclusions:

Changing the priority of GitOperations-Thread does not consistently reduce CPU spikes (I tried with both BelowNormal and Lowest.
The source of the freeze seems to be GitHelpers.GetGitInformationForItem, which used the CPU for 10-15% of the total time. That's a lot considering I opened many non-git folders.
LibGit2Sharp.DiffCompare<T> run for about 4-8% of total CPU time

I'll see if I can find a fix

@soleon can you try with the latest commit?

@soleon can you try with the latest commit?

Sorry for the late response @yaira2, I can confirm this problem is fixed in the latest 'main' branch 🎉.

Thank you for testing


Allow ES6 single line import Statements

I wanted to ask if there is an option to keep single line imports for ES6:
import { Router, Route } from 'react-router';

is always being reformatted to:
import {
  Router, Route
}
from 'react-router';

This behaviour would also be valid for normal object assignments e.g.
const { increment, incrementIfOdd, incrementAsync, decrement, counter } = this.props;

I do agree that line splits for objects is the prettier way, but for these kind of assignments, I think an option would be good to keep them in a single line

I recommend opening an issue with https://github.com/beautify-web/js-beautify/
I am already supporting this in Pretty Diff, which you can demo at: http://prettydiff.com/?m=beautify Just bear in mind that these code samples are not enough for the tool to automatically detect the language so just add var a = 0; before or after.

How can I select using this setting in atom-beautify as for now? I don't find a setting for it in the settings pane.

All currently supported Pretty Diff options: https://github.com/Glavin001/atom-beautify/blob/master/docs/options.md#pretty-diff
Issue about pending Pretty Diff options: https://github.com/Glavin001/atom-beautify/issues/524
I am accepting Pull Requests.

This convention is now supported by both Pretty Diff and JS Beautify.  The JS Beautify update is very fresh so you can wait for the next Atom Beautify version or uninstall/reinstall Atom Beautify to get the latest JS Beautify support.

@KeKs0r @prettydiff @Glavin001
How to config??

@willin It should just work automatically without any configuration.  Are you experiencing problems?

@willin Make sure you are using prettydiff as default beautifier, its not working with JS Beautify.

@Glavin001 @prettydiff can we have a toggleable setting for single/multiline imports?

@jgog I opened an issue to examine this further.  I am away at a military school right now, but I will resume work on enhancements once I return home this weekend.

@prettydiff alright no issues!

@jgog I just reviewed the application and this feature is already in Pretty Diff.  You are looking for Pretty Diff's neverflatten option.  http://prettydiff.com/documentation.xhtml#neverflatten
I just tested this option against your code sample and it appears to do what you need.  http://prettydiff.com/?m=beautify
The limitation to using this option is that it applies to all blocks.

I do not think the neverflatten option is supported in Atom-Beautify yet. I would review and merge a Pull Request implementing it. Thanks.


Field access fails after unboxing with a local binding

On both the website and my local installation (Effekt v0.8.0), the following code returns what seems like a compiler panic:
Minimised repro:
record Container(eqz: (Int) => Bool at {})

def ap(c: Container, k: Int): Bool = {
  def eqz = unbox c.eqz // You can delete the explicit `unbox`, it's just here for clarity
  c.eqz(k)
// ~^^^ Error: Not a valid method or function: eqz4041
}

Of course, you can fix this by calling eqz (the local binding) instead. Otherwise this is very reminiscent of #635.
Funnily enough, it's somewhat random where exactly the error appears in the editor.
As a note, I haven't yet tried it on the current master with #671 merged.
A similar issue happens even if we try to bind the same thing twice:
record Container(eqz: (Int) => Bool at {})

def ap2(c: Container, k: Int): Bool = {
  def eqz = unbox c.eqz
  def second = unbox c.eqz // both `unbox`es are just for clarity
  second(42) // Same error as above: "Not a valid method or function: eqz4256"
}

Relevant code:
https://github.com/effekt-lang/effekt/blob/dc9149737c9d713ce04a26591d77d8cdfccf50e7/effekt/shared/src/main/scala/effekt/typer/BoxUnboxInference.scala#L86-L100

Did you try it with current master? Maybe this is already fixed?

I'll close this for now, since I don't know a better solution and box/unbox might need to be redesigned anyway.
Feel free to open again if you disagree.

I can confirm that even the ap2 function works on current master, which resolves the issue. :)


Performance Issues

Dear all,
I am currently experimenting with crawler4j to download pages from the web (I would like to download if possible billions of pages). But at least in some of my early experiments it seems that this is not feasible. For example, if I start with 300 seeds then after one day of crawling, which means about 200.000 downloaded pages, things slow down a lot and the system's cpu usage is 100% in all of my cores, downloading a page every minute or so.
So basically, is this an expected behavior or maybe something is wrong in my setup? Are there any guidelines about how I can improve things? What are the current bottlenecks in crawler4j that inhibit scale-up?
Best regards
Panagiotis

I would like to help speed-up (if possible) crawler4j a bit. But since I am new to its codebase it would be nice if someone could point to relevant information/posts or any kind of documentation or comment about possible bottlenecks or where should I start looking at.
P.S.
My insight is that probably the bottleneck for scaling things up is the usage of BerkeleyDB.

Currently, BerklyDB is integrated into the code
The right way will be to create an interface for the DB where several
implementations could be suggested, one would be berklyDB, then another
internal inmemoryDB could replace it.
I think someone had tried to do just that, I am not sure what was the
conclusion
On Sun, Apr 26, 2020 at 10:10 PM Papadakos Panagiotis <
<EMAIL_ADDRESS>wrote:

I would like to help speed-up (if possible) crawler4j a bit. But since I
am new to its codebase it would be nice if someone could point to relevant
information/posts or any kind of documentation or comment about possible
bottlenecks or where should I start looking at.
P.S.
My insight is that probably the bottleneck for scaling things up is the
usage of BerkeleyDB.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yasserg/crawler4j/issues/442#issuecomment-619607999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANNWWZ3HQY7GTARHO3AS7LROSBLZANCNFSM4MQBGDSQ
.

Yep, that would be nice. But I guess, initially we have to find which are the bottlenecks in the current implementation. It might be the db, it might be the way crawler4j uses it or it might be something else.

If you want to fetch billions of Web pages, you might look into other (distributed) Web crawler frameworks written in Java, i.e. Nutch or Stormcrawler.
Did you enable resumable crawling? On which OS does your crawler4j is running on?
100% CPU usage sounds like IO wait. Did you check this?
Before I switched to Stormcrawler (for scalabilty reasons), I used crawler4j quite heavily for the purpose of focused crawling: I did never experience such issues.

Thanks for the reply rzo1. I will try to do some kind of profiling to see what is going on.


Thread list view is not presented in chat view because of chat window occupying  the entire space due to long line responses.

Electron build - bf86f18e1
Steps to reproduce the problem:

Chat with Tildy
Go to "Manage workspace" and add this file myjson.json
In chat message ask to read this file.

Wait for the message to be streamed completely.
Notice that the thread list view is not presented anymore.
Chat window occupying  the entire space of chat view with no space left for showing the thread list.

Tested with electron build - 4884a2ba
This issue is not seen anymore.


Avoid redundant git switch in Dockerfile for cleaner and more effic…

…ient git checkout
The original Dockerfile included a git switch command after cloning the repository, which was redundant since the commit hash could be checked out directly after the clone. This update removes the unnecessary git switch and performs the commit checkout directly with git checkout $COMMIT. This reduces the complexity of the build process and improves clarity.
Summary of Update:

Removed the redundant git switch in the op-node build stage.
Directly checked out the commit using git checkout $COMMIT after cloning.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

@mdehoog WDYT?

@mdehoog WDYT?

We do it intentionally this way because it keeps the branch tag information, which the geth build process uses to version the resulting binary.
However I don't believe this is applicable to the nethermind build so could go either way on this. Personally I think I prefer the consistency of doing it all the same way.


Support for lifecycle

Hi,
I would like to be able to specify if i want something to be ignored.
ie. it would be useful for me not to recreate all the instances when new ami is specified, but just create new ones with it:
lifecycle {
ignore_changes = ["ami"]
}
Thanks

This is a rather repetitive issue in this repository.
Many users want this functionality, but it isn't possible to use variables in the lifecycle block in Terraform so we can't do much in this module.
Closing this issue.


[Miner] feat: add block client

Summary
Adds BlockClient interface and implementation.
---
title: Clients Dependency Tree
---
flowchart

sup[SupplierClient]
tx[TxClient]
bl[BlockClient]
evt[EventsQueryClient]

sup --"#SignAndBroadcast()"--> tx
tx --"#CommittedBlocksSequence()"--> bl
tx --"#EventsBytes()"--> evt
bl --"#EventsBytes()"--> evt

Issue
Relates to:

#13
#94

BlockClient is a nested dependency of Miner.
Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[x] Run all unit tests: make go_test_integration
[x] Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

[x] I have tested my changes using the available tooling
[ ] I have performed a self-review of my own code
[ ] I have commented my code, updated documentation and left TODOs throughout the codebase

Waiting to merge until CI is working and green:

#116

Closing this as ignite.com now works. Will add a comment linking to this PR in case a similar issue arises.

@okdas SHouldn't we close #116 but keep this one open?

@okdas Shouldn't we close #116 but keep this one open?

LOL, sorry. I pushed the comment on the wrong tab. :)

@bryanchriswhite Try to merge with main to see if CI passes and please take not of #121 as well

There's a test failure unfortunately: https://github.com/pokt-network/poktroll/actions/runs/6712974558/job/18243662555?pr=65


Child cleaning

Notes:

I left some testing code at the end of the file so we can review everything, but can remove these - or move it into a separate testing file at the end
Still need to do E/F data cleaning in version 3 - but will be easier now that everything is documented

Not needed as merged in manually outside github.

Not needed as merged in manually outside github.


Drop 3.6 & switch to 100% static packaging configuration

Let's try to move into the ✨future✨.

Looks like the hatch parts will have to wait until we drop 3.6 (currently at almost 8% downloads).

https://github.com/python-attrs/attrs/pull/993/commits/b7e241d9ec0736c2a74afdc5e533698d2198a214 will probably mean some extra work for @pganssle – sorry!

oh god, can Python 3.6 do anything!?!?!

To preserve my work, I've made it a draft and will try to keep it around until its time has come…

until we drop 3.6 (currently at almost 8% downloads)

What's the threshold to drop EOL versions generally?

There really isn’t a threshold, but 3.6 is special because it’s the last version without dataclasses. It’s probably just in my head and the result of constant bullying by DC fans, but I have a hard time letting go. I’m thinking to add a deprecation warning for 3.6 and see how many people complain to see how much are active users and how much is just old CIs.

Okay cool, was just wondering because I saw Black decided to expedite dropping 3.6 by 4 months (in ~10 days) https://github.com/psf/black/issues/3169#issuecomment-1221624251

yeah, someone may or may not have talked to one of them :) i'm happy to drop 3.6 everywhere – attrs is just special. i've deprecated 3.6 in #1017 – let's see how it goes.

Needs a rebase btw

yeah it's annoying…i've screwed up in the beginning I think and have to keep merging main into the branch.
If there's a magic incantation for Git that will take the current diff between main and a branch and make it a single, rebased commit – i'm all ears.

Merging after the new year?

This DeprecationWarning broke my CI: https://github.com/ycm-core/YouCompleteMe/actions/runs/3751229771/
Is that intentional?

I don't think dropping support for 3.6 is not drastic as it is EOL already long ago.

I don't think dropping support for 3.6 is not drastic as it is EOL already long ago.

but being forced to because I can no longer make changes because my CI broke, as opposed to a "business" decision? that's the drastic part.

It's not forcing anything, it's just a depreciation warning following the best practices. It's probably turned into an error according to the settings on your side (which is normally considered a best practice too). Handling such cases is your responsibility, it's just an early alert but how you integrated it is on you. If you want more CI stability, pin your test env with pip-tools-generated constraints or something.

If there's a magic incantation for Git that will take the current diff between main and a branch and make it a single, rebased commit – i'm all ears.

Do you want a single commit or keep individual ones? It shouldn't be hard to do with an interactive rebase.

This DeprecationWarning broke my CI: https://github.com/ycm-core/YouCompleteMe/actions/runs/3751229771/
Is that intentional?
In terms of Why, well, I guess we could just drop supper for python 3.6 too, but that seems kind of drastic.

I'm sorry for the breakage, but as @webknjaz pointed out it seems like the system is working as intended? Especially given that a warning breaking your CI seems like a conscious decision on your side?
What exactly would you have preferred to happen instead?

If there's a magic incantation for Git that will take the current diff between main and a branch and make it a single, rebased commit – i'm all ears.

Do you want a single commit or keep individual ones? It shouldn't be hard to do with an interactive rebase.

i just want one big patch, but i don't think that's possible to get there using rebases because there's been force-pushes so there's commits that don't exist.

i just want one big patch, but i don't think that's possible to get there using rebases

Add .diff to the PR URL for this: https://github.com/python-attrs/attrs/pull/993. There's also .patch but it shows multiple commits as opposed to that huge diff.
This could be saved into a .patch file, branch force-reset to origin/main locally and applied with git am ...
Another way would be git rebase --interactive origin/main locally. It won't list the merge commits by default. You can save the rebase plan as is and see how it goes, or change pick to s or f. It'll probably give you a series of merge conflicts to solve, though, but rerere would make it easier.
Oh, and you could (being on the PR branch) just git reset --soft origin/main (would reset your branch to that point, keeping the files on disk as is) locally followed by git add . && git commit -v (this would create a commit with all the changes that remain on disk after the soft reset).

because there's been force-pushes so there's commits that don't exist.

I don't know how you drew this connection, but it hugely misinterprets the nature of Git. Git history is a blockchain — each commit has a parent, and it's sha is directly dependent on that parent and the commit contents. Yes, force-pushing replaced a bunch of commits on remote (GH) but they do exist. Also, the old commits may still in your local repo if they weren't garbage-collected. But you don't really need them for this rebase anyway.
Having merges in your feature-branch complicates the rebase, of course, but nothing's impossible. One thing that could've helped you with repeating conflict resolutions would be rerere. If you don't have it enabled, do this as soon as possible — you'll thank yourself later: https://git-scm.com/book/en/v2/Git-Tools-Rerere.
TL;DR it memorizes your manual conflict resolution results (usually the last 50, by default) and re-applies them automatically if they are faced again — this tends to happen a lot when you do rebase-driven topic branch updates.

@ofek I think I've mostly got it, just two issues / qs:

I'm a bit surprised that coverage is working despite coverage-enable-subprocess being for setuptools and despite complaining about "CoverageWarning: Module attrs was never imported. (module-not-imported)" – I believe you've created something similar for Hatch? How would I use it?
Is it on purpose that the metadata has no Author field and just Author-email that (unlike with setuptools) doesn't contain the email address but the name + email and I have to split the string to get it out? This looks very clunky.

I believe you've created something similar for Hatch? How would I use it?

https://github.com/ofek/hatch-autorun

Is it on purpose that the metadata has no Author field and just Author-email

Yes https://github.com/pypa/packaging.python.org/issues/1134#issuecomment-1231564237

I believe you've created something similar for Hatch? How would I use it?

https://github.com/ofek/hatch-autorun

Cool, does https://github.com/python-attrs/attrs/pull/993/commits/68ab2e0bbbeca9efa38a92c2646429f781a349ea make sense?

LGTM!

Awesome! I'll wait a little bit more if I need to make a bugfix release for 22.2.0 (between the years it's unlikely someone would notice) and merge then.

and I have to split the string to get it out?

I'm pretty sure that any email parsing library would be able to retrieve that — it's one of the standardized email representations. Stdlib should do too.

Sure it's an email format (still hilarious that packaging metadata is just an email envelope), but I don't think it's gonna be faster? And since I control the input, that's all that counts.

Just want to know will the CI breaking change in 22.2.0 have any bug fix release? or we have to pin an older version?

I'm waiting for bug reports to arrive, so far there haven't been any except for a missing .. module in docs.
This change also shouldn't be breaking unless you have a pip from 2018 or something.

OK. Just FWIW https://github.com/encode/django-rest-framework/pull/8828


rust : recalculate method : optionals_args should default to empty set

so has to go with defauts when you don't  pass a dict, better usability ;)

I don't know how to implement optional arguments in rust that godot would recognize.

I don't know how to implement optional arguments in rust that godot would recognize.

ah yes! I'll call my rust friends tomorrow maybe they know something, I'll get back to you here on that

Okay so here's what my rust friend (its singular today) found out :
gdnative = "0.8" does'nt support optional argument
gdnative = { git = https://github.com/GodotNativeTools/godot-rust }
does, (but Im unsure of the stability of this, it always points to their master branch so, each time they merge a commit it might break something, but they seem pretty serious and we'll have unit test so it might be worth to do that)
and then by replacing
pub fn recalculate(&mut self, mut _owner: gdnative::Node, target: gdnative::Variant, optional_params: gdnative::Dictionary)
by
pub fn recalculate(&mut self, mut _owner: gdnative::Node, target: gdnative::Variant, #[opt] optional_params: gdnative::Dictionary)
it should work, I have work this afternoon so I'll test that tomorrow, what do you think about using : gdnative = { git = https://github.com/GodotNativeTools/godot-rust }  ? :)

Hi, you can also specify a specific commit, like so :
gdnative = { git = https://github.com/GodotNativeTools/godot-rust, rev = 4195027a74fc46f20c33d74a92e15494217a2d1c

Great, thanks for the info. I knew I read somewhere about the #[opt] thing and was confused when it didn't work. This explains why. Yes, I think we should move to more recent version of godot-rust. The optional argument is a big thing.


Add documentation and unittests regarding multisets

Resubmission of https://github.com/dlang/phobos/pull/5627 due to GH's annoying hook issue (they send the wrong sha after a rebase).

Close this


When specifying NISE_DOMAIN, CF still recreates a self-signed Cert associated with XIP.IO

Attempting to build out an internal dev box with no internet access.  I specify a NISE_DOMAIN so I can control the DNS.   Which works just fine, but when I attempt to deploy an app using the CF Java Client with trust self-signed = true option.  I get
PaaS unavailable while deploying [revision=1,ex=org.springframework.web.client.ResourceAccessException: I/O error on GET request for "https://api.cf-dev.redacted.com/info":hostname in certificate didn't match: <api.cf-dev.redacted.com> != <*.10.xxx.xxx.xxx.xip.io>; nested exception is javax.net.ssl.SSLException: hostname in certificate didn't match: <api.cf-dev.redacted.com> != <*.10.xxx.xxx.xxx.xip.io>]
Jun 29 19:06:30.616 WARN   ///06d888d9-2e09-43d4-8b80-2579afd6b755/1/[] [http-<IP_ADDRESS>-8080-exec-11] #HTTP#@T: java.lang.IllegalStateException: Response.getWriter.ise
	 at com.redacted.server.http.message.HttpResponseImpl.getWriter(HttpResponseImpl.java:244)}}

Any chance to get the NISE_DOMAIN variable to pass on to the self-signed cert?

Ok, I redid my environment with an xip.io address and it appears that it is specifically with *.<IP_ADDRESS>.xip.io.  I had redacted this above thinking it was my local IP but my local is actually different.  It also appears we only see this with the Java Client and no the GO CLI.  So not sure if this is something in your install, or something your install has control over.

Looks like this is the same as issue #112

Closing as it looks an outdated ticket. Please recreate another ticket when still you have the issue.


Upgrade Safe-Core-SDK to support new safe-deployment version(v1.33.0)

Context / issue
I was following up on the comment in GitHub issue(https://github.com/safe-global/safe-infrastructure/issues/124#issuecomment-1877097932) regarding upgrading safe-core-sdk to work with safe-deployment v1.33.0.
Proposed solution
With the release of safe-deployment v1.33.0, it is now necessary to upgrade safe-core-sdk to ensure compatibility.
Upgrading safe-core-sdk(composed of several packages including protocol-kit) will enable me to operate safe infrastructure on my local machine effectively.

@dasanra Thank you for your PR. Could you also please publish the new SDK release version?


Build error

After encountering #16 I used g++-6.4.0 by changing the CMake variable CMAKE_CXX_COMPILER to
/usr/bin/c++-6.4.0 using ccmake ., re-configuring and generating the makefile.
then make gives me the following output:
cube@gecko /tmp/curv (master) $ make
Scanning dependencies of target libcurv
[  2%] Building CXX object CMakeFiles/libcurv.dir/curv/analyser.cc.o
[  4%] Building CXX object CMakeFiles/libcurv.dir/curv/arg.cc.o
[  6%] Building CXX object CMakeFiles/libcurv.dir/curv/builtin.cc.o
[  8%] Building CXX object CMakeFiles/libcurv.dir/curv/context.cc.o
[ 10%] Building CXX object CMakeFiles/libcurv.dir/curv/definition.cc.o
[ 12%] Building CXX object CMakeFiles/libcurv.dir/curv/die.cc.o
[ 14%] Building CXX object CMakeFiles/libcurv.dir/curv/dtostr.cc.o
[ 16%] Building CXX object CMakeFiles/libcurv.dir/curv/evaluator.cc.o
[ 18%] Building CXX object CMakeFiles/libcurv.dir/curv/exception.cc.o
[ 20%] Building CXX object CMakeFiles/libcurv.dir/curv/file.cc.o
[ 22%] Building CXX object CMakeFiles/libcurv.dir/curv/function.cc.o
[ 24%] Building CXX object CMakeFiles/libcurv.dir/curv/gl_compiler.cc.o
[ 26%] Building CXX object CMakeFiles/libcurv.dir/curv/gl_context.cc.o
[ 28%] Building CXX object CMakeFiles/libcurv.dir/curv/list.cc.o
[ 30%] Building CXX object CMakeFiles/libcurv.dir/curv/location.cc.o
[ 32%] Building CXX object CMakeFiles/libcurv.dir/curv/math.cc.o
[ 34%] Building CXX object CMakeFiles/libcurv.dir/curv/module.cc.o
[ 36%] Building CXX object CMakeFiles/libcurv.dir/curv/parser.cc.o
[ 38%] Building CXX object CMakeFiles/libcurv.dir/curv/pattern.cc.o
[ 40%] Building CXX object CMakeFiles/libcurv.dir/curv/program.cc.o
[ 42%] Building CXX object CMakeFiles/libcurv.dir/curv/range.cc.o
[ 44%] Building CXX object CMakeFiles/libcurv.dir/curv/record.cc.o
[ 46%] Building CXX object CMakeFiles/libcurv.dir/curv/scanner.cc.o
[ 48%] Building CXX object CMakeFiles/libcurv.dir/curv/shape.cc.o
[ 50%] Building CXX object CMakeFiles/libcurv.dir/curv/string.cc.o
[ 52%] Building CXX object CMakeFiles/libcurv.dir/curv/structure.cc.o
[ 54%] Building CXX object CMakeFiles/libcurv.dir/curv/system.cc.o
[ 56%] Building CXX object CMakeFiles/libcurv.dir/curv/value.cc.o
[ 58%] Building CXX object CMakeFiles/libcurv.dir/curv/version.cc.o
[ 60%] Linking CXX static library libcurv.a
[ 60%] Built target libcurv
Scanning dependencies of target curv
[ 62%] Building C object CMakeFiles/curv.dir/cmd/readlinex.c.o
[ 64%] Building CXX object CMakeFiles/curv.dir/cmd/curv.cc.o
[ 66%] Building CXX object CMakeFiles/curv.dir/cmd/export.cc.o
[ 68%] Building CXX object CMakeFiles/curv.dir/cmd/export_mesh.cc.o
[ 70%] Building CXX object CMakeFiles/curv.dir/cmd/progdir.cc.o
[ 72%] Linking CXX executable curv
/usr/lib/gcc/x86_64-pc-linux-gnu/6.4.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot open output file curv: Is a directory
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/curv.dir/build.make:200: curv] Error 1
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/curv.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

I'm probably doing something wrong here :-)

Ah, well I don't expect you to type cmake .. You are just supposed to type make.
There is a Makefile, and typing make issues some commands:
mkdir release
cd release
cmake ..
make

This puts all of the cmake output into a separate release directory, separate from the source code.
I suppose I could rename the curv directory, in order to avoid this name clash in the future.

So when you type cmake ., it overwrites the Makefile that is provided as part of the Curv project.

You can type git checkout Makefile to restore the original Makefile, then type make to build curv.


MOTR-141 Internal data release

Key Changes: ✨

Created a new page 📄 for the upcoming internal data release, which is accessible via the Releases link button in the sidebar.
Added a Releases link button 🔗 in the sidebar.
Implemented new styling 💅 for the newly created data release page.
Removed the Weight vs. Fat button UI for phenotypic data plot due to missing fat data in official data release.
Suppressed links of vial labels in search results.
Suppressed links of vial labels and biospecimen ids in tissue sample tables.
Suppressed links of received metabolomics and proteomics samples in the data summary matrix.
Removed sex and gene search options in the advanced search form due to unavailable data at the moment.
Enabled the example searches (e.g. rna-seq, liver) on the advanced search form to return search results.
Enabled quick search box to return search results.
Updated the subset of phenotypic data from the official release.
Updated the RNA-seq and RRBS metadata from the latest revisions and merged the batches.

@jimmyzhen Let's separate any elasticsearch implementation into a separate branch/PR.

@kilodalton, I will omit the elasticsearch implementation and update this PR.

Merged MOTR-141


apktool says "built apk" but no file is created...

Hello
apktool was still working yesterday, then for some reason today it does not work anymore.
I still use the very same commands and the very same folders.
Moreover, it does not show any error, it says "built apk", but the apk file is not created anymore...
D:\sites\dom83\games\qui_mange_qui\app>apktool b source_apk
I: Using Apktool 2.6.0
I: Checking whether sources has changed...
I: Checking whether resources has changed...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...
D:\sites\dom83\games\qui_mange_qui\app>
I also looked in "C:\Users<my user name>\AppData\Local\Temp" but there is nothing related to it there.
Any idea ? Or is this a bug ?

Have you looked at "D:\sites\dom83\games\qui_mange_qui\app\dist"? Built Apks located at "dist" folder under your decompile folder.

Yes, there is nothing else in \app\ than my "source_apk" folder.
No "dist" folder is created. I created one and tried again, but it stayed empty.

Not sure what to say. If that output appears, the file would be in /dist relative to the app directory. I don't see any other error that would say otherwise.

Why did you close ? My problem is not resolved.

Why did you close ? My problem is not resolved.

Because I do not replicate the issue. There is not enough details here to prove an issue occurred and this is a bug tracker, not support.


fix: octal rule triggers on time format

Time values such as this:
some_calendar_entry:
  file.managed:
    - name: /tmp/my_unit_file
    - contents: |
        OnCalendar=Sun 18:00

should not trigger this rule.
Changed the regex to accommodate this case while still catching/ignoring previous identified test cases

@roaldnefs


CB-12243: DES delete flow exceptions are swallowed and do not result in flow failure

CB-12243: DES delete flow exceptions are swallowed and do not result in flow failure
Fix the issue of swallowing of exceptions - by re-throwing the exception after logging.

@juhi-09 Since this needs to be fixed in 2.42, please rebase to CB-2.42.0 & force-push, and also change the target branch in the PR.

The target branch is still not alright.


spi-device: set CS gpio flags for all devices that had none

The generic SPI GPIO chip select support now respects devicetree flags for signal active level.  Update all cs-gpios properties to specify active low.
Automated by:
git grep -wl cs-gpios -- '*/*.dts*' \
  | xargs sed -i -r -e '/cs-gpios/s@ 0>@ GPIO_ACTIVE_LOW>@g'
git grep -wl cs-gpios -- '*/*.overlay' \
  | xargs sed -i -r -e '/cs-gpios/s@ 0>@ GPIO_ACTIVE_LOW>@g'

excluding changes pending in #26670.
Separate commits update various drivers and one test where struct spi_cs_control gpio_dt_flags was not being set.
These two drivers need attention but are not being touched:

sensor/iis2mdc assigns a label to the flags field so hasn't been tested
sensor/iis3dhhc stores the pin configuration but initializes the spi_cs_control from other data

Looking into that is outside the scope of cleaning up to fix problems introduced by #26269

@pabigot Looks good to me. I would like to do some testing of the EEPROM and ADC drivers touched by this before approving.

These also look wrong, particularly the ones that have a pull-up to the active level.  Not changing them.
boards/arm/b_l4s5i_iot01a/b_l4s5i_iot01a.dts:	cs-gpios = <&gpiod 13 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>,
boards/arm/disco_l475_iot1/disco_l475_iot1.dts:	cs-gpios = <&gpiod 13 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>,
boards/arm/olimexino_stm32/olimexino_stm32.dts:	cs-gpios = <&gpiod 2 GPIO_ACTIVE_HIGH>;
boards/shields/x_nucleo_idb05a1/x_nucleo_idb05a1.overlay:	cs-gpios = <&arduino_header 16 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>;	      /* D10 */
samples/subsys/fs/fat_fs/boards/nrf52840_blip.overlay:        cs-gpios = <&gpio0 17 GPIO_ACTIVE_HIGH>;

@pabigot Do you want to take https://github.com/zephyrproject-rtos/zephyr/commit/5963ebaf33bb542de1a7b2e1cf03b0af476e8dab and https://github.com/zephyrproject-rtos/zephyr/commit/5963ebaf33bb542de1a7b2e1cf03b0af476e8dab from #26670 over?

Do you want to take 5963eba and 5963eba from #26670 over?

I don't think those commit links are right but AFAICT #26670 is ready to merge so I'd rather have it go in first.

Going to merge as this will always timeout on CI.


add a file of the testing variety

Summary:
this is a summary
Issue ID(s): N/A
Testing:

[ ] Unit Tests
[ ] Integration Tests
Test Command: make test

Documentation:

No updates

Is this a test commit, or what is the need?


angular.js:13708 TypeError: insights.startTrackPage is not a function

I am getting the above error when i try to execute the app isnights js file

@ankireddy-pradeep m getting the same error. Did you find a solution for this bug?

I'm also getting the same error


MGDOBR-1206: Update deploy-bot.yml

Insert JIRA Issue number and update link
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ for the correct usage
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

/deploy dev


Issue Deploying to Netlify

I was able to run and set up a development environment to get started. However, when I run the commands to deploy to Netlify I get a 404-page error.

This is the deploy log:
5:37:21 PM: Creating deploy upload records
5:37:22 PM: Starting post processing
5:37:22 PM: Post processing - HTML
5:37:22 PM: Post processing - header rules
5:37:22 PM: Post processing - redirect rules
5:37:22 PM: Post processing done
5:37:22 PM: Site is live ✨
I am wondering if I missed something, or if there is anything I am missing.
Thanks

This is resolved.


Lay groundwork for build/dyndep alignment

Add ProjectReunionBuildPipeline=1 when pipeline build is run (ProjectReunionBuildPipeline=0 for local development)
Add build step to generate overrides for DynamicDependencies (e.g. unique CLSID for each pipeline build of the DDLM)
Update DynamicDependencies to support overrides during pipeline builds (and use local constants for local development)
Deleted unused file buildall.props
Remaining work:

Update DynamicDependency*.msix projects to modify appxmanifest.xml to match generated overrides (needed for tests)
Update aggregator pipeline to match (needed for releases :P)

/azp run

/azp run


Convert pytorch_model.bin to model.pt

Hi, I want to convert whisper pytorch_model.bin file to model.pt. Is that possible?

faster whisper doesnt use pytorch so no


Dusty live artifacts

Alternatively the need for it may go away as we align more with Image Mode.

Yes, I think the debate to have here is whether it really continues to make sense to have "dd raw image" installations versus having coreos-installer grow small bits to dynamically make the desired filesystems and then call bootc install to-filesystem. (And actually nowadays, bootc install to-disk acts as such a reference; I consider it more of a "demo" and testing tool but it's basically that same code)
If we don't do the raw image for installs but leverage bootc install, then the center of gravity shifts much more decisively to containers (and bootc), and about half of the magic in the ISO drops out.

I addressed code review comments and also fixed lints that would run in upstream CI.


[BUG]: Dialog control doesn't re-evaluate the Button property

Description
The dialog control doesn't support dynamic buttons. The Button property is only evaluated once and cannot set some logic (i.e. condition).
To Reproduce
Example steps to reproduce the behavior:

Assuming there's a canvas app with containing dialog control

Set the Buttons property to:
If(IsConfirmationDialog, Table({    Label: "Cancel",     ButtonType:'Microsoft.CoreControls.Button.ButtonType'.Standard  } , {    Label: "Confirm",     ButtonType:'Microsoft.CoreControls.Button.ButtonType'.Primary }) , Table({    Label: "Ok",     ButtonType:'Microsoft.CoreControls.Button.ButtonType'.Primary }) )

Have a dummy button that toggles the IsConfirmationDialog variable to true/false:
UpdateContext({IsConfirmationDialog: true})

Runt he app, toggle the dummy button and open the dialog

Expected behavior
Confirm and Cancel buttons appear only when IsConfirmationDialog is true and Ok button when IsConfirmationDialog is false.
Actual behavior
It seems like the Buttons property is only evaluated once at runtime, and never again. Using the repro steps example,
If IsConfirmationDialog was false at runtime then only the Ok button will be visible and will never show Confirm/Cancel even when 'IsConfirmationDialog' was updated to true. And vice-versa, if IsConfirmationDialog was true at runtime, Confirm/Cancel buttons will also show.
AB#3514

No, I didn't install the "20240529.1" version as recommended in the announcement. I still have the 20230727.2 version. Are you suggesting my exact issue is fixed in the latest versions?
Is the June 24 version release yet?

@denise-msft just upgraded and tried. Still doesn't work, the buttons are not re-evaluated


IR chapter references

To which document do the IR references in the ats-metadata tests point to?
Example: the test A.02.IR221.title has the reference to Chapter 2.2.1 of the "Implementing Directive 2007/2/EC of the European Parliament and of the Council as regards metadata", but when I open the linked document (http://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:32008R1205&from=EN) there is no Chapter 2.2.1. Instead the title requirement is discussed in Part B, "1. Identification",  "1.1 Resource title".
Similar IR references are in almost every ats-metadata test, which is also reflected in the test naming.
Can you shed any light on this @pvgenuchten?

@ilkkarinne the numbering seems indeed inconsistent with the IR document. I noticed it does align with the paragraphs of the Technical Guidelines. So I guess I made an error when setting up the numbering and didn't realise the error in the approach while creating the issues. I would suggest to improve the numbering to follow IR naming conventions

changed the numbering


NPS report: "When I deploy my functions. 2-3 times the machine freeze up"

Feedback from customer in NPS interview:

Azure Functions.

When I deploy my functions. 2-3 times the machine freeze up
When using the output panel feature, it makes thing freeze/hangout.
Sometimes my VS Code instance doesn’t respond at all. I have to kill via > > > Activity Manager.
Running Windows 10 with about 25 VS Code extensions

I have contact details on the reporter if you want to debug this.

@auchenberg yeah we need more detailed repro steps before we can do anything with this

@fiveisprime Let me know what you want to do here.

Did you contact them to get repro steps? I'm happy to reach out to them as well if you want to send me the details.

Send email.

Closing this issue due to lack of activity and since it sounds like @fiveisprime and/or @auchenberg are following up offline anyways.


Cannot read property 'split' of undefined

I'm using iziModal in one of my project (I have used it in the past as well). I'm constantly getting the below error in the console:
Uncaught TypeError: Cannot read property 'split' of undefined     at r.fn.init.t.fn.(anonymous function) [as iziModal] (https://cdnjs.cloudflare.com/ajax/libs/izimodal/1.5.1/js/iziModal.min.js:6:23583)     at Object.success (http://localhost/MT/main.js:57:30)     at i (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28017)     at Object.fireWith [as resolveWith] (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:2:28783)     at A (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:4:14035)     at XMLHttpRequest.<anonymous> (https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js:4:16323)
Any help would be appreciated :)

We're updating a project that used iziModal as well, and the only thing I can see that's different is that we're using a newer version of jQuery (3.2.1) instead of 1.9.1.
I'm getting a near identical error and can't find out why.
@Buzzertech did you ever find a solution?

I have same error , I don't know what's the problem ... I hope someone fix it

you may have initialized iziModal and the element that you are targeting doesn't exist on the current page.


How do I update?

I know you've made some changes recently but I don't know anything about python. I pulled the repo to get the updates and then just followed installation instructions again: I got
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! path /home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/.bin/dsv2json
npm ERR! code EEXIST
npm ERR! Refusing to delete /home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/.bin/dsv2json: is outside /home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/d3-dsv and not a link
npm ERR! File exists: /home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/.bin/dsv2json
npm ERR! Move it away, and try again.

So I just cloned the repo again and followed the installation instructions, and this time I got
$ npm install .
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! path /home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/d3-dsv/bin/json2dsv
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall chmod
npm ERR! enoent ENOENT: no such file or directory, chmod '/home/buzzard/Encfs/Computer_languages/Lean/lean-projects/Lean-game-maker/src/interactive_interface/node_modules/d3-dsv/bin/json2dsv'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

I've installed the game maker fine in the past.

I'm not completely sure, but it might be because of corruption or other issues in npm cache. Let me know if this solves the problem.
npm cache clean --force
rm -rf node_modules
npm install .

That does indeed seem to have fixed it!

Perfect!


Color issue or theme override needed?

Since WindowConfig seems not to allow selecting the true rgb color with color:, and instead gives some variation of theme colors.  Maybe something can be done.  Possibly an explicit theme: false, to allow user defined background color for window.
mut app := m.create(m.WindowConfig{title: "Test", color: [255,250,250], scrollbar: false, width: 200, height: 200, ask_quit: true})

I am using the rgb color to create color palette. So, you are seeing variants of the main color. If you're wanting to set background color. You can modify color palette or create a rect with your color. But supporting a background color is good idea.

Yes, some way that allows setting the background color, and maybe turning the theme off, as an option in WindowConfig would appear to be more obvious and better for users.
Had already noticed that rect could be used as a workaround.  However, (on Windows) there is an intermittent redraw/resize issue that shows up at the top and right border, as a kind of dark line.  I'm thinking it has something to do with conflicting colors involving near white, as doesn't appear to show up in themes or when the window is alone.  I have been playing around if there was an easy way to completely overcome it.  Maybe making rect bigger than the visible window, or something.  This does not appear to be an issue with your code, but rather the gx/gg implementation, so if a fix is needed then it will likely come from over there.
mut app := m.create(m.WindowConfig{title: "Test", color: [255,250,250], scrollbar: false, width: 200, height: 200, ask_quit: true})
app.rect(m.Widget{id: "rect", x: 0, y: 0, width: "100%x" height: "100%y", background: gx.Color{255, 250, 250, 255}})
app.run()

Still needed to add color option to create color palette (for widgets) but you can also use background option.

I recommend to set color; if you don't, mui will creates custom color palette according to users system theme. That can make your application with bad looking (like white text onto light yellow background etc.)

Example usage: https://github.com/malisipi/mui/blob/main/examples/custom_background.v


Can't flash ttgo-s3 via web installer

Pretty sure this is our issue, need to track down the right s3 bootloader to flash. Platformio has to have them somewhere just need to track down path.

fixed, needed s3 bootloader and offset


cannot find components with bundle packaging

Describe the bug
components that have a "bundle" packaging cannot be evaluated
this is a regression introduced when solving "aar" packaging case in #85 / #87
To Reproduce
look at https://central.sonatype.com/artifact/org.scalatestplus/scalacheck-1-17_sjs1_3/<IP_ADDRESS>
this component is not recognized, because it is transformed to purl pkg:maven/org.scalatestplus/scalacheck-1-17_sjs1_3@<IP_ADDRESS>?type=bundle
Expected behavior
it should be recognized, because it should be transformed into purl pkg:maven/org.scalatestplus/scalacheck-1-17_sjs1_3@<IP_ADDRESS>?type=jar
Additional context
packaging in POM is not always the extension of the main file that will be published.
bundle packaging generates jar, and is widely used: https://central.sonatype.com/search?q=p%3Abundle
I'm sure there are others, but given the list of packagings that exist is open (anybody can create his own), it's not easy to list which packagings do which extension...
For example, Maven core ones are maven-archetype, maven-plugin. I just tested and these packaging cause the same issue
I don't know if using no type in the generated purl would work?
or type=pom? (any compoennt in Maven Central has a file with .pom extension

thank you @madpah for the quick fix, it works now for bundle because the transformation from bundle to jar in purl is hardcoded
but it does not work for maven-plugin: https://central.sonatype.com/artifact/net.sf.czsem/custom-properties-maven-plugin/4.0.3 nor maven-archetype: https://central.sonatype.com/artifact/io.kalix/kalix-maven-archetype-event-sourced-entity/1.3.3 nor probably every other case where a packaging produces a jar
and given I see the purl with ?type=maven-archetype but not ?type=pom, I'm not clear if the default pom switch has been tested

@hboutemy - are you able to provide some concrete rules that we can work to for this?
At present the rules essentially are:
Default to type=jar UNLESS

We find a POM on the current page and it contains <packaging> element
And the packaging value is NOT one of: bundle, pom, we use type=[packaging-value]

We can update cater for any requirement here, just need to get a clear steer from a Java Expert such as yourself @hboutemy

let's take an example:
https://central.sonatype.com/artifact/net.sf.czsem/custom-properties-maven-plugin/4.0.3 is not recognized
but https://central.sonatype.com/artifact/net.sf.czsem/custom-properties-maven-plugin/4.0.3/versions is
and https://repo1.maven.org/maven2/net/sf/czsem/custom-properties-maven-plugin/4.0.3/ also (and opening the .pom from there and evaluating freezes the browser: I suppose there is bug, but that's another story, and not a normal usage one)
is really type in purl necessary?

Understood @hboutemy - perhaps we can reverse the current change which was intended to provide a fix for #85 (where the packaged format was aar and not jar).
Seems like the default is safe as jar unless we know it should positively be changed.

:tada: This issue has been resolved in version 2.10.7 :tada:
The release is available on:

Chrome Web Store
v2.10.7
GitHub release

Your semantic-release bot :package::rocket:


Convert line endings from CRLF to LF ...

for consistency with other sources and to avoid compiler warnings.

Already done in current sources, anyway thanks for reporting