Prune constants

Reviewing tip: you can use this link to see the changes except the first move refactoring commit.
Changes

Add the ability for Boogie to prune constants, in addition to the existing ability to prune axioms and functions.
Change the complexity of the code that creates the reachability graph for pruning, to be linear instead of quadratic in program size
Slightly simplify the pruning code so it uses one incoming field instead of two.

Testing

Add a test that verifies constants, functions, axioms and types are isolated when they're part of independent proofs.

Oddly enough, I didn't see where the new processing for constants was done. In all places where I saw branching for constants in this PR, the previous code already had the same case. Where did I miss the new pruning itself?

Previously, the reachability graph computed only contained axioms and functions, so the traversal could not detect which constants were traversed. If you look a the old edge computation:
    public static Dictionary<DependencyEvaluator, List<DependencyEvaluator>> InitializeEdges(Program p)
    {
      if (!CommandLineOptions.Clo.PruneFunctionsAndAxioms)
      {
        return null;
      }
      var nodes = p.Axioms.Select(ax => (DependencyEvaluator)new AxiomVisitor(ax)).ToList();
      nodes.ForEach(axv => ((AxiomVisitor)axv).Visit(axv.node));
      var functionNodes = p.Functions.Select(f => (DependencyEvaluator)new FunctionVisitor(f)).ToList();
      functionNodes.ForEach(fv => ((FunctionVisitor)fv).Visit(fv.node));
      nodes.AddRange(functionNodes);
      nodes.ForEach(u => u.incoming = u.incoming.Where(i => u.node == i || !ExcludeDep(i)).ToHashSet());
      nodes.ForEach(u => u.outgoing = u.outgoing.Where(i => !ExcludeDep(i)).ToHashSet());
      var edges = new Dictionary<DependencyEvaluator, List<DependencyEvaluator>>();
      nodes.ForEach(u => edges[u] = nodes.Where(v => DependencyEvaluator.depends(u, v)).ToList());
      return edges;
    }

You can see that it computes edges only from and to nodes, which contains only axioms and function. It assumes that there's only a single hidden node between an axiom or function. The call to DependencyEvaluator.depends(u, v) sees if two axioms/functions are connected by such a hidden node.
There was also a quadratic complexity issue arising from the double iteration over nodes.


Fix Black compatible snapshot deletion

Summary
This PR fixes the deletion of black compatibility test snapshots when Ruff and Black produce the same output.
The functionality broke after my refactor to use insta's glob feature.

Test Plan
I changed the FormatString implementation to emit a hardcoded string. This created a few new snapshot files.
I then reverted the change and re-ran the tests. The created snapshots were automatically deleted

Current dependencies on/for this PR:

main

PR #5646   👈

This comment was auto-generated by Graphite.


Help with srelu-resnet-18 model file

Hi there
I am trying to use the TrailNet model for benchmarking and I am facing this problem:
As I work on Matlab, Matlab Can import  Caffe, ONNX and Keras model of network architecture I had tried using .prototxt file provided here but it has some problem so I have been recommended by Matlab support team to use ONNX or Keras mode file to import the network into Matlab.
Please, does anyone know if there is any way I can get those model files for Trailnet?
thank you for your time in advanced

find a work around


Skyrim not recognised

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[X? ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[X] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
When I made new profile linked to the program "TESV.exe" I expect it to activate when TESV.exe is started, or at least the active window.
Actual behavior:
The profile never activates
How often does this problem occur?
All the time. But as far as I can tell only with TESV
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Make a profile, assigned to skyrim
Give it any layer
Test and fail

What is the version of Aurora you are experiencing this issue with?
V0.6.0b
Does the previous version of Aurora have this issue?
I have no previous version, nor ever had.
Also, sidenote, is it possible to copy layers or day/night? Haven't found it...
Tried running TESV with and without SKSE and with and without the help of Mod Organizer.

I added SKSE to Aurora, but there was no change. When I used TESV.exe it worked. Are you using Logitech Gaming Software? My old LGS profile was fighting with it, but after disabling the LGS profile for Skyrim the profile I used on Aurora worked fine.

It's possible that you are running Aurora as a regular user and Skyrim as administrator. Processes running as non-admin do not have permissions to look at details of admin running processes. Try running Aurora as admin.

Running Aurora as Admin works. Haven't thought about that. Thanks!


Error while manually executing -MSSQL DB script

Affected IS version: wso2is-5.10.0-alpha3-SNAPSHOT
DB script location: /wso2is-5.10.0-alpha3-SNAPSHOT/dbscripts/mssql.sql
MSSQL version: Microsoft SQL Server 2017 (RTM) - 14.0.1000.169 (X64)
Error log:
Msg 1776, Level 16, State 0, Line<PHONE_NUMBER>854775807
There are no primary or candidate keys in the referenced table 'UM_DOMAIN' that match the referencing column list in the foreign key 'FK__UM_UUID_D__UM_DO__55F4C372'.
Msg 1750, Level 16, State 1, Line<PHONE_NUMBER>854775807
Could not create constraint or index.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


[Question] I am unable to predict using my model

When I try to run my model I get this:
 _         _        _
| |_  _ __| |_ __ _(_)__ _
| | || / _` \ V  V / / _` |
|_|\_,_\__,_|\_/\_/|_\__, |
                     |___/
ludwig v0.1.0 - Predict

Dataset type: generic
Dataset path: testdata.csv
Model path: /content/gdrive/My Drive/Colab Files/Ludwig Siraj Chatbot/model/experiment_run_2/model
Output path: results

Loading metadata from: /content/gdrive/My Drive/Colab Files/Ludwig Siraj Chatbot/model/experiment_run_2/model/train_set_metadata.json
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/pandas/core/indexes/base.py", line 2656, in get_loc
    return self._engine.get_loc(key)
  File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 132, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1601, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1608, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'user1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/ludwig", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.6/dist-packages/ludwig/cli.py", line 86, in main
    CLI()
  File "/usr/local/lib/python3.6/dist-packages/ludwig/cli.py", line 64, in __init__
    getattr(self, args.command)()
  File "/usr/local/lib/python3.6/dist-packages/ludwig/cli.py", line 73, in predict
    predict.cli(sys.argv[2:])
  File "/usr/local/lib/python3.6/dist-packages/ludwig/predict.py", line 379, in cli
    full_predict(**vars(args))
  File "/usr/local/lib/python3.6/dist-packages/ludwig/predict.py", line 86, in full_predict
    only_predictions
  File "/usr/local/lib/python3.6/dist-packages/ludwig/data/preprocessing.py", line 684, in preprocess_for_prediction
    train_set_metadata=train_set_metadata
  File "/usr/local/lib/python3.6/dist-packages/ludwig/data/preprocessing.py", line 61, in build_dataset
    **kwargs
  File "/usr/local/lib/python3.6/dist-packages/ludwig/data/preprocessing.py", line 89, in build_dataset_df
    global_preprocessing_parameters
  File "/usr/local/lib/python3.6/dist-packages/ludwig/data/preprocessing.py", line 152, in build_data
    preprocessing_parameters
  File "/usr/local/lib/python3.6/dist-packages/ludwig/data/preprocessing.py", line 173, in handle_missing_values
    dataset_df[feature['name']] = dataset_df[feature['name']].fillna(
  File "/usr/local/lib/python3.6/dist-packages/pandas/core/frame.py", line 2927, in __getitem__
    indexer = self.columns.get_loc(key)
  File "/usr/local/lib/python3.6/dist-packages/pandas/core/indexes/base.py", line 2658, in get_loc
    return self._engine.get_loc(self._maybe_cast_indexer(key))
  File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 132, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1601, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1608, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'user1'

What does KeyError mean?

Also let me know what info you want me to attach for debugging.

I'm having the same issue, I'm on a Windows machine. It doesn't seem to seem to matter what type of input features I use, I've tried time series and text encoders and both give the same error.

Did you find a solution?

Yeah, it seems like the inputs and outputs must have the same name in both your csv data file and your yaml definition file.

Example please?

Model file:
input_features:
    -
        name: "TextIn"
        type: text

output_features:
    -
        name: "NumOut"
        type: numerical

training:
        epochs: 100

training data csv:
TextIn,NumOut
"input text data",0.1643
...

You don't need quotes in the feature names. Try:
input_features:
    -
        name: TextIn
        type: text

output_features:
    -
        name: NumOut
        type: numerical

training:
        epochs: 100

Yes the fact that the model definition names are the same names of the columns in your data (both when training and when predicting) is basically the only assumption that Ludwig makes. If you respect that, it should work right away.
So in the case of @Riz-waan , if your model definition was copied from the examples, with user1 and user2 as names of input and output feature respectively, both your training data csv and your test data csv must contain columns with those names (or you can change the name entries in your model definition with the names of the columns in your data).
In the case of @JacobBruce , if you trained with a text column named test, the same column needs to be present in your test data too.
Closing this, let me know if you have further questions.

So in my prediction set I need to have user1 and user2? Instead of just user1?
On Mar 11, 2019 2:04 AM, Piero Molino<EMAIL_ADDRESS>wrote:
Yes the fact that the model definition names are the same names of the columns in your data (both when training and when predicting) is basically the only assumption that Ludwig makes. If you respect that, it should work right away.
So in the case of @Riz-waanhttps://github.com/Riz-waan , if your model definition was copied from the examples, with user1 and user2 as names of input and output feature respectively, both your training data csv and your test data csv must contain columns with those names (or you can change the name entries in your model definition with the names of the columns in your data).
In the case of @JacobBrucehttps://github.com/JacobBruce , if you trained with a text column named test, the same column needs to be present in your test data too.
Closing this, let me know if you have further questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/uber/ludwig/issues/192#issuecomment-471414791, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXsm8pr6iAx5N7a14JNfjIwI6XrL-VEoks5vVfHkgaJpZM4bmp2o.

If you use --only_predictions and only want the predictions, you only need user1, if you also want to compute the quality of your predictions you need something to compare the predictions agaings, so you would need user2 too in this case.


chef-fan-control: Remove unnecessary circular callback checks

With the recent circular callback bugfixes implemented in the cluster code in 36515 and 36489, we can now safely remove unnecessary checks that prevented the circular callbacks on the app side.

Waiting for https://github.com/project-chip/connectedhomeip/pull/36515 to land first


[New API] : Bing Search API

Brief Description 🤓
Web search, image search, and news search.
How will you develop it?🤩
react,js
Deployment
None
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

/gssoc24


Fix/update acm asm

Updating documentation and fixing formatting issues.

Hi @dkassab Thanks for the PR
there are two lint errors:

A missing newline

Step #1 - "lint-tests": Checking for missing newline at end of file
Step #1 - "lint-tests": Error: No newline at end of file ./6-anthos-install/README.md

A missing required argument

Step #1 - "lint-tests": terraform_validate ./app-foundation/4-projects/shared
Step #1 - "lint-tests":
Step #1 - "lint-tests": Error: Missing required argument
Step #1 - "lint-tests":
Step #1 - "lint-tests":   on infra_pipeline.tf line 44, in module "infra_pipelines":
Step #1 - "lint-tests":   44: module "infra_pipelines" {
Step #1 - "lint-tests":
Step #1 - "lint-tests": The argument "impersonate_service_account" is required, but no definition was
Step #1 - "lint-tests": found

The missing required argument was fixed in PR https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/pull/40
It should be fixed if you rebase with the current version of main

@googlebot I consent.

Fixes in c599738f5cdeaa8ff6f3c5f8a09acb3b16233e89

Changes requested in @daniel-cit 's comment
Remove --cluster-labels not needed
Add missing instruction for frontend-sa.yaml

@dkassab and @daniel-cit
Noticed missing instructions for

acm root-sync yaml in ReadME, line should also have GKE_PROJECT_ID instead of PROJECT_ID
cloud-sql-admin-secret yaml instruction to update this in ReadME
app-secret-front yaml instruction to update this in ReadME as well as the correct project env variable GKE most likely

@dkassab and @daniel-cit
Noticed missing instructions for

acm root-sync yaml in ReadME, line should also have GKE_PROJECT_ID instead of PROJECT_ID
cloud-sql-admin-secret yaml instruction to update this in ReadME
app-secret-front yaml instruction to update this in ReadME as well as the correct project env variable GKE most likely

P.S Also a lot of files in the 6-anthos-install/acm-repos/root-config-repo/namespaces/boa/ repo folders are entirely commented out, maybe some instructions in the README are required to inform user what role the files play and at what stage

I fixed acm root-sync.yaml file.
cloud-sql-admin-secret is not needed anymore, I removed it.
This secret is not needed for this phase, but will need it once we implement secret manager and CSI secret driver.

Fixes #51

Exposed bastion_members in 5-infra/env/main.tf and added supporting instruction in 6-README
Added missing Readme instruction for acm-repo-sync
Commented out app-secret-front

LGTM
@daniel-cit and @bharathkkb please review when you get a chance


feat(scheduler): add waitAsyncEventsFinished() to wait for async event execution

Closes #251
Description
Added a method to wait for the execution of async events. This is the second PR as #259 got messy with my rebasing.
Checklist
The following items should be checked before the pull request can be merged.

[x] Version number updated in settings.gradle.
[X] Unit tests added.
[X] Code follows existing code format.

Is there anything I can do or change that will allow merging this PR?


Incorrect JSX name for ArrowUpRightFromSquareIcon

Browser

[ ] Chrome/Chromium
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] iOS Safari
[ ] Opera
[X] Other/not relevant

Operating system

[ ] Windows
[ ] Linux
[ ] macOS
[X] Other/not relevant

Description
The defined JSX for square-arrow-out-up-right is wrong.
The website copies it as <SquareArrowOutUpRight />, but it is exported in lucide-react as <ArrowUpRightFromSquare />.

Steps to reproduce

Search for square-arrow-out-up-right
Select the icon and click "Copy JSX"
The import will not resolve using lucide-react.

Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)

Update the package, and let me know if that fixes it.

I am already on the latest version - I have already checked this, and it does not work with it (lucide-react@0.363.0).

Is there an ongoing update? This is also the same version reported by GitHub.

Weird, it's there for me.

https://www.npmjs.com/package/lucide-react?activeTab=code

Huh, installing the package again on another project does export it. No idea what happened here, I swear it wasn't there - maybe some module caching issue.. My apologies!


KubernetesDiscoveryClient  cause OutOfMemoryError

version
spring-cloud-kubernetes version:1.1.6.RELEASE
kubernetes on aliyun  1.18.8-aliyun.1
program arguments
-Xms1024m -Xmx2048m -XX:MaxDirectMemorySize=32m -Xss512k -Xtune:virtualized -XX:+HeapDumpOnOutOfMemoryError
heapDumpAnalyse

Can you please try and reproduce this with Spring Cloud 2021.0.2?

This problem occured in our production environment.It is not allowed to switch versions at will. Figure show the spring version

We no longer support Hoxton that is why I am asking to try and reproduce with a version we do support
https://spring.io/projects/spring-cloud-kubernetes#support

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


delay initilaisation of the mgmt-net bridge name

you can merge it and I will check it as part of the main PR


Create a companion library with default implementations

We have a lot of reports to add functionality to the default snackbar and dialog implementations that we don't really want to mix with Dexter itself. Maybe it's a good idea to create a companion library called something like dexter-addons, dexter-widgets or dexter-extra to move those implementations there.
Does it sound ok? @pedrovgs @flipper83

I'd not go for a dexter-addons artifact. This code is being used by our users as part of the production code when it's just an example. I'd keep it as is or just move the code to the example application.

What do you think @flipper83 @fjfdeztoro ?

We will keep those classes in Dexter and improve them if people send us PRs to better configure them. As you said, they are in the main project and people is using them as part of Dexter in their code so.
Thanks for your help!


anchor scrolling doesn't work properly.

Hello, I am using slidebars for my onepager website. Its a great framework but I'm struggling with animating a smooth scroll anchor to anchor on my page. The scroll on the website of sliderbars (advanced usage) doesn't work properly so but I understand the principles so I made my own. The problem is it doesn't scroll to the anchor if you have already navigated on the website, like you can see on www.dart-development.be/woodsolutions.
This is how I code my smoothscroll
$('a[href^="#"]').click(function() {
    if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'')
        || location.hostname == this.hostname) {

        var target = $(this.hash);
        target = target.length ? target : $('[name=' + this.hash.slice(1) +']');
           if (target.length) {
             $('[canvas="container"]').animate({
                 scrollTop: target.offset().top
            }, 1000);
            return false;
        }
    }
  });

Hope someone can help me!

I'm experiencing the same issue. Anyone found a solution to this?

@VincentVanDenBossche
It seems you've got this working now?
@Walkeezy
Can you share a link? There is no general solution in the current version of Slidebars. This is entirely related to your website since every site can have a different structure.
I've modified the Slidebars code in a WordPress plugin to remove the need of scrolling the canvas container and return to the default browser (body) scroll. This might be a better solution for you as well.
See my PR: https://github.com/adchsm/Slidebars/pull/257


⚠ ClamAV has degraded performance

In 3c28c2a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in d493e7d.


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests

https://github.com/Senzing/github-action-identify-customer/pull/16


As a user I would like to choose between driver/rider mode after login

Front-end page created to select user-mode.


Use flask-security for logins

I saw that you completely rolled your own login system - it would be much easier and more consistent to use Flask-Security, which takes care of everything (session management, data models, and templates) for you.
Let's pair program this?

Not an urgent task, because no user management used in the moment. Will we solved later with more fancy user interface.


Get wrong json type from response of /plugins/{ip-restriction plugin id}

Summary
I had add a ip-restriction plugin to a route, and the blacklist array set [], then I use retrieve plugin api to get the config, the blacklist array became to {}
Steps To Reproduce
the types of whitelist and blacklist all are array, when one of them set to empty array [], kong server will set it to a empty map {}
Additional Details & Logs

curl -i -X POST http://kong_ip:8001/routes/4f24b416-3b82-4eda-8924-96fe28113a4e/plugins -H 'Content-Type: application/json' -d '{"name":"ip-restriction","config":{"blacklist":[],"whitelist":["<IP_ADDRESS>"]}}'

response:
{"created_at":1525076648000,"config":{"whitelist":["<IP_ADDRESS>"],"blacklist":{}},"id":"438c36bb-a235-47bb-8141-6c029c92c327","enabled":true,"route_id":"4f24b416-3b82-4eda-8924-96fe28113a4e","name":"ip-restriction"}

curl -i -X GET http://kong_ip:8001/plugins/438c36bb-a235-47bb-8141-6c029c92c327

response:
{"created_at":1525076648000,"config":{"whitelist":["<IP_ADDRESS>"],"blacklist":{}},"id":"438c36bb-a235-47bb-8141-6c029c92c327","name":"ip-restriction","enabled":true,"route_id":"4f24b416-3b82-4eda-8924-96fe28113a4e"}

Kong version (0.13)

Thanks for reporting this, we'll give it a look.


Let the battle begin

https://github.com/jimmcnulty41/wikitree.website

Tree wars! Good luck in there, seeing bower and angular ~1.3.x

Nevermind the battle is off I need ur help

I thought I couldn't log issues in the master repo, but I was wrong

Hi GitHub Notifications are the worst I am just now seeing this
What's the issue??


ERROR with parallel installation of VS2017 and 2019 (Properly support Visual Studio code 2019)

Currently, I get the following error message when trying to build this project:
> Task :compileNative FAILED
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 07/07/2019 17:27:33.
Project "C:\Users\miho\Documents\GitHub\NativeFX\build\native\nativefx.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|x64".
ValidateProjects:
  The project "ALL_BUILD" is not selected for building in solution configuration "Release|x64".
Project "C:\Users\miho\Documents\GitHub\NativeFX\build\native\nativefx.sln" (1) is building "C:\Users\miho\Documents\GitHub\NativeFX\build\native\ZERO_CHECK.vcxproj" (2) on node 1 (default targets).
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v142 (Platform Toolset = 'v142') cannot be found. To build using the v142 build tools, please install v142 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\Users\miho\Documents\GitHub\NativeFX\build\native\ZERO_CHECK.vcxproj]
Done Building Project "C:\Users\miho\Documents\GitHub\NativeFX\build\native\ZERO_CHECK.vcxproj" (default targets) -- FAILED.
Done Building Project "C:\Users\miho\Documents\GitHub\NativeFX\build\native\nativefx.sln" (default targets) -- FAILED.

Build FAILED.

"C:\Users\miho\Documents\GitHub\NativeFX\build\native\nativefx.sln" (default target) (1) ->
"C:\Users\miho\Documents\GitHub\NativeFX\build\native\ZERO_CHECK.vcxproj" (default target) (2) ->
(PlatformPrepareForBuild target) ->
  C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v142 (Platform Toolset = 'v142') cannot be found. To build using the v142 build tools, please install v142 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution". [C:\Users\miho\Documents\GitHub\NativeFX\build\native\ZERO_CHECK.vcxproj]

We should adjust the search locations for visual studio 2019 (BuildTools vs. Community vs. Enterprise etc.)


Move pinMode initialization (outside of constructor)

previously, the pinMode was being set in the constructor, which wouldn't take effect (e.g. on MKR1000), and communication with the HX711 would fail (when the Q2HX711 object was declared as a global, as in the simple_scale example).

See https://github.com/arduino/ArduinoCore-samd/issues/169 for discussion related to this (problem I discovered when using Q2HX711 and switching from v1.6.6 to v1.6.7 of the SAMD tools used with the Arduino MKR1000.  My first direction of investigation was off-track; it turned out it was because the pinMode wasn't set properly (the clock wasn't being taken as OUTPUT) when using the Q2HX711, since these calls were made in the Q2HX711 constructor.  The solution could be:

something like I've done in this PR to minimize changes for existing code (being sure to call pinMode() once, but outside of the constructor)
or, simply to insist that people not use global objects, but rather allocate the Q2HX711 object in setup(), and reference it by pointer
or...add a setPinMode() method that must be explicitly called by the user in their setup(), which would configure the pins.

(It's not related to the fix, but I also made setGain() into a public method, because there's no point having it if you can't use it.)

Turns out the reason this fixes the problem is that "global constructors on SAMD are called before hardware initialization [...] this issue reveals a different behaviour of the SAMD core compared to SAM or AVR, where global constructors are called after hardware is initialized." (quoted from https://github.com/arduino/ArduinoCore-samd/issues/169)
Looks like they may fix it there, but it wouldn't hurt to take this PR anyhow, to be safe.  Or, if you prefer, I can add a begin() method, or something like that, that needs to be called by clients of the library, in setup() (to setup the ports).


Add TRIAGING.md for triage agenda and processes

Description
Documents the repository wide triaging processes for OpenSearch

Meeting format and agenda
Public meeting schedule - Weekly Wed - 10a CT
Commonly used labels
Triaging outcomes and canned responses

Related Issues

Related https://github.com/opensearch-project/OpenSearch/pull/11617

Check List

[ ] ~New functionality includes testing.~

[ ] ~All tests pass~

[ ] ~New functionality has been documented.~

[ ] ~New functionality has javadoc added~

[ ] ~Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)~
[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[X] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @peternied , love this initiative !

@anasalkouz Thanks for taking the time to read and provide feedback.

It's not clear to me what is the triage process that the group will follow in the meeting. I think we need clear definition of the triaging process

I'm not sure if you are asking about the mechanics, or the criteria used for triage.  I'll speak to them both, but please let me know if I am mistaken.
Mechanically, the triage facilitator will open the query, open an issue, scan the issue's title and body.  There will be a brief discussion to accept or why to reject, criteria could be; is it clear what the issue is, is it clear that it should be fixed, is it clear that this repository to fix it?  Labels will be added/removed, then a small blurb will be written with a tag indicating it came from triage and it will be commented on or closed.  Then the triage facilitator moves on to the next issue...
For the criteria, the extremes of accept and reject are easy - ✅ Filled in the whole template ❌ Spam.  There will be be variance for what gets approved / rejected.  Since the issues will have the reason for rejection is included in the issue we can tweak these over time to update the template, document criteria, or update the TRIAGING.md with changes.

Note my previous comment ^ might be a candidate for a follow up PR if there is a strong desire

❌ Gradle check result for 20841f4: FAILURE

https://github.com/opensearch-project/OpenSearch/issues/6090
https://github.com/opensearch-project/OpenSearch/issues/10006
New issue https://github.com/opensearch-project/OpenSearch/issues/11849

❕ Gradle check result for 20841f4: UNSTABLE

https://github.com/opensearch-project/OpenSearch/issues/9191


Create a teacher entity.

Create a teacher entity with teacher, teacher controller, teacher service and teacher repo.

Irrelevant


NFC sample: fix "hande" typo

Fix the word "handle" mistyped as "hande" in code comments

Thanks. Pulled into the next refresh.


evelynn shadow form bugged

idk if my pc or r3nzskin but look at prestiege kda
and prestiege kda new
and like other skins in shadow form
they look rly grey and not shiny

#1


error in C# function IoTHubtoTwins.cs

I believe there are at least 2 errors in the C# function IoTHubtoTwins.cs:

public async void Run([EventGridTrigger] EventGridEvent eventGridEvent, ILogger log) should be changed to:
public async Task Run([EventGridTrigger] EventGridEvent eventGridEvent, ILogger log) should be changed to:

var cred = new ManagedIdentityCredential("https://digitaltwins.azure.net");
This site is no longer active and Digital Twins are not accessible through this site. Instead, I think it should be: "https://explorer.digitaltwins.azure.net";

Even after making these changes, I still can't get the code to run. I keep getting a "ManagedIdentityCredential authentication failed" error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5daeee2-2c36-aafc-4828-5666a9d92637
Version Independent ID: 772fc5ea-1ea9-dd6e-9146-874c1c074fea
Content: Ingest telemetry from IoT Hub - Azure Digital Twins
Content Source: articles/digital-twins/how-to-ingest-iot-hub-data.md
Service: digital-twins
GitHub Login: @baanders
Microsoft Alias: baanders

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Hi @cristiandatum, thank you for your comments!

The function signature in the code sample (with void) matches the EventGridTrigger samples from Azure Functions documentation (see Azure Event Grid trigger for Azure Functions), so we follow their lead when using their packages. Our dev team notes that while async void is generally a pattern to be careful with, it's acceptable for callbacks (or methods like this) where the caller (Event Grid, here) does not await the method. We've also re-tested the method to verify that the void return does not break the sample. For these reasons, we are planning to leave the method signature as-is.

Thanks for sharing your issue with ManagedIdentityCredential. I've confirmed that https://digitaltwins.azure.net remains the correct resource URI to specify (it's not a website that can be browsed--it's the friendly identity of the Azure Digital Twins app ID in the public cloud).
However, noting your issue and taking a suggestion from the Azure.Identity team, I’m actually going to update this example to use DefaultAzureCredential instead. Azure.Identity has suggested that for sample code we encourage the use of DefaultAzureCredential, which wraps ManagedIdentityCredential and other credential methods in a chained fashion (so adjusting to this credential method shouldn't be a functional change when deployed to a cloud service--but it should unblock you). I'm making the update in this pull request to the sample code. You can look at the pull request to see the new code immediately; it should also go live to the original document later today.

I'm going to close this issue when the pull request with the DefaultAzureCredential update is merged. However, feel free to comment back in this thread, where we can continue the conversation and reopen if necessary.
Thank you!

#please-close

Thank you - please close.


Customize the title

I'm not a big fan of lower-case titles. It'd be nice if you could customize the start-page title from the config file.

@mohkale You can directly change the titles of the squares from the config itself.
Just open settings and change it according to your needs. Does that not suit your needs?

@deepjyoti30
Sorry, not the squares, the HTML page. So the contents of the ~~ element.

@mohkale I know it's late but I finally added this feature. If you're still interested you can take a look at the latest commits of the dev branch. I will make a release soon!

Fantastic, thanks :-).

@mohkale The feature is now available in the latest release!


Add stylelint-declaration-block-no-ignored-properties

Add stylelint-declaration-block-no-ignored-properties and fix discovered issue. There is no visual difference in these markup code blocks.

@silverwind please fix the merge conflicts. :tea:

silverwind please fix the merge conflicts. 🍵

@GiteaBot already done


LARDX 1.0

clean logs using rich console, caching bard instance to pickle, and error handling responses and sessions

yey


Update AGENT_CHANGELOG.md

What does this PR do?
Update AGENT_CHANGELOG.md
Motivation
Additional Notes
Review checklist (to be filled by reviewers)

[x] PR title must be written as a CHANGELOG entry (see why)
[x] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[x] PR must have changelog/ and integration/ labels attached
[x] Feature or bugfix must have tests
[x] Git history must be clean
[x] If PR adds a configuration option, it must be added to the configuration file.

With agent 6.12.0:
dd-agent@973c2bfc5dce:/$ agent integration freeze | grep 'go-expvar' datadog-go-expvar==1.3.0
This change should be reverted.
Also I think we can keep Kubernetes Scheduler, nicer to read


Remove output.path from dev webpack config

According to this parameter's comment, it's unused but webpack-dev-server crashes without it. However, webpack-dev-server is running fine for me without this parameter.

Hello! I'm a bot that helps facilitate testing pull requests.
Your pull request (commit 612b17170d83dfebc707c3df87bfadfe5c91e523) has been released on npm for testing purposes.
npm i<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS># or
create-react-app<EMAIL_ADDRESS>folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!
Thanks for your contribution!

This probably got fixed in WDS at some point. Nice catch!


Improvement for DOM selects with options that start with value 0

hi everyone,
i was having trouble when creating virtual-selects from already populated selects. for my cms it is a lot easier in the data handling if the values start with 0. this was creating problems though, since when no value was selected and my values started with 0, the first element was always getting set. for this i suggest this modification in the code. i just check if the selected attribute of the option is indeed set, since $option.selected was unreliable when starting the values with 0.
i hope this helps someone else!
line 3580:
if ($option.getAttribute('selected') =='') {
   selectedValue.push(value);
}

@squareclouds Could you please share a sample code to reproduce this issue?

@sa-si-dev its been a few weeks, so not right away. but what i mean is if my options look like this in html. since the first value value is 0, the value was always getting set even though in HTML it was not set as shown here in the example.

New
1 year
2 years
3 years

@sa-si-dev its been a few weeks, so not right away. but what i mean is if my options look like this in html. since the first value value is 0, the value was always getting set even though in HTML it was not set as shown here in the example.

New
1 year
2 years
3 years

Are you saying first option is auto selected when initialising from native select element?
If so, that is expected behaviour only. Because in native select, first value would auto selected. So I doing the same.

ah ok, then it works as intended i think. i changed my code a bit to solve my specific problem


Add custom-mathquill-config option to reduce spacing around "f"

The default spacing felt a bit excessive, this PR adds an option to reduce that

I ended up doing 0em left, 0.05em right, seemed right to me


Not working in Xamarin.Forms version 2.3

In Xamarin.Forms version 2.3 toasts has a top offset and a twitch motion.
Did you plan to make it be compatible with v 2.3?
PS: Not sure I used the correct english words to explain

The toasts plugin has now been completely rewritten (3.0.0-beta1) to use the native platform notification systems, which means it removes all of these types of issues. Any feedback welcome: https://xamarinhelp.com/toast-notifications-xamarin-forms/

Hi @adamped , but this updates will break previous versions?
I'm using the current stable version, and works on iOS but on Android nothing do when i call Notify even   no errros, could you help me to solve this problem?
Thanks

Hi @adamped  I did solve the problem with this code:
Sorry, by annoying
MainActivity.instance.RunOnUiThread(() => {
 var notificator = DependencyService.Get<IToastNotificator>();
if (notificator != null)
{
notificator.Notify(ToastNotificationType.Info, title, desc, TimeSpan.FromSeconds(5));
}
});


Do not escape tildes in safe constructs that are nested in unsafe constructs

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Fix for the issue described in https://github.com/remarkjs/remark-gfm/issues/42
I've first added tests to prove that tildes are in fact being escaped in some safe constructs like link URLs (among others). See the results here: https://github.com/bertramakers/mdast-util-gfm-strikethrough/actions/runs/3394305801
Results with the code fix: https://github.com/bertramakers/mdast-util-gfm-strikethrough/actions/runs/3394322969
Tests & code are heavily based on https://github.com/syntax-tree/mdast-util-to-markdown/commit/7b381da5bceee3c36be079e27a2bad7b3cc412c2 so credits go to @wooorm for doing the heavy lifting before and sharing how to fix this.

Thanks, released! https://github.com/syntax-tree/mdast-util-gfm-strikethrough/releases/tag/1.0.2


Unify version pattern, allow local dandiset URLs

When doing work in the API, I noticed that the regex pattern for the published dandiset URL was hardcoded to https://dandiarchive.org. I thought this should be prod/dev agnostic, as the other URL patterns are.
Also, I noticed there was some duplication regarding version patterns, so I unified them.

@jwodder - can you please confirm that the CLI test failures are known issues at this point in time ?

@satra They are not.  I see messages like 'https://dandiarchive.org/dandiset/000002/0.220304.1811' does not match '^http://localhost(:\\\\d+)?/dandiset/\\\\d{6}/\\\\d+\\\\.\\\\d+\\\\.\\\\d+$', which are clearly caused by this PR.
@AlmightyYakob If DANDI_ALLOW_LOCALHOST_URLS is set, then DANDI_ARCHIVE_PATTERN should allow localhost in addition to https://dandiarchive.org.

@jwodder are these failing codecov tests a problem?

@AlmightyYakob No.


prepare for v0.2.3

Codecov Report

Merging #21 (df720dc) into master (6c90f92) will decrease coverage by 0.72%.
The diff coverage is 89.08%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   89.83%   89.11%   -0.72%
==========================================
  Files          70       73       +3
  Lines        8629     8776     +147
==========================================
+ Hits         7751     7820      +69
- Misses        878      956      +78

Flag
Coverage Δ

uitests
89.11% <89.08%> (-0.72%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

InsurAutoML/_balancing/__init__.py
100.00% <ø> (ø)

InsurAutoML/_base.py
74.40% <ø> (ø)

InsurAutoML/_datasets/__init__.py
66.67% <ø> (ø)

InsurAutoML/_encoding/__init__.py
100.00% <ø> (ø)

InsurAutoML/_hpo/_DL.py
44.44% <ø> (ø)

InsurAutoML/_hpo/__init__.py
100.00% <ø> (ø)

InsurAutoML/_imputation/__init__.py
77.78% <ø> (ø)

InsurAutoML/_scaling/__init__.py
100.00% <ø> (ø)

InsurAutoML/_utils/_optimize.py
88.48% <ø> (-0.02%)
:arrow_down:

InsurAutoML/_utils/_stat.py
87.94% <ø> (+0.06%)
:arrow_up:

... and 83 more

dev_test failed due to high-usage on local machine and tests got crashed.
Windows_test failed due to conflict of test file usage.

NO actual problems on code side.


SamplyGame: Lambda Expression is not valid

These two lines are not correct:
public override int MaxHealth => 50;
protected override Vector3 CollisionShapeSize => base.CollisionShapeSize * 4;
I am using VS2013. Any ideas?
James

@jamesdang that is a C#6 feature https://docs.microsoft.com/en-us/dotnet/articles/csharp/whats-new/csharp-6#expression-bodied-function-members
you need at least VS2015 to compile samples.


Remove backend-based features.

Backends should be configured using ODRA_BACKEND env instead of features.

Closed by #243


PowerShell DSC script fails to create MOF file

Hi,
I tried running the helloworldconfig.ps1 file on both my Win 7 system and Win 10 virtual system using PowerShell 5.1 as Administrator, but it waits a long time and fails with the following error:
The script failed due to call depth overflow.
+ CategoryInfo          : InvalidOperation: (0:Int32) [], ParentContainsErrorRe
cordException
+ FullyQualifiedErrorId : CallDepthOverflow

Can anyone please help me out?
Regards
Ramesh

Please share the Powershell code..

Configuration helloworldconfig {
Import-DscResource -ModuleName PsDesiredStateConfiguration

Node localhost {
    File hellofile {
        DestinationPath = "D:\temp\test.txt"
        Ensure = 'Present'
        Contents = "Test"
    }
}

}
.\helloworldconfig

And I can see the problem.
I removed the .\ and it worked.


Only mix each ancestor style once

This prevents shader blocks that have already been mixed in from an ancestor style from being mixed a second time.
This supports a 'diamond'-like mixin hierarchy where:
      A
     / \
    /   \
   B     C
    \   /
     \ /
      D

In this case (or more complex ones like it where a style is mixed into multiple ancestors), style D should end up with only one copy of style A.
Note: one thing I am not entirely pleased with in this solution is that it only applies explicitly to shader blocks. Because mixing the same style multiple times does not cause breakage for any properties other than shader blocks, this may be an acceptable approach for now. It could raise some potential issues with order of mixin application, since shader blocks will be mixed in the order of the first parent found, while later mix occurrences of a style could affect other properties through overwrite or flag behavior.

@blair1618 @tallytalwar this is something you might want to take a look at. Basically, there is only special handling for preventing shader blocks from being mixed in multiple times. For all other style properties, we let them be mixed multiple times, which does not cause compile errors (and with current implementation would be much harder to prevent :). I'm a little unsure about what that means for order of application, e.g. shader blocks for style A are added the first time they are encountered, so will execute in that order relative to other shader blocks, but the if style A is later mixed again, its other properties may overwrite those from earlier styles.
Then I realized we probably have a similar situation with the ES implementation. Also, I don't think we can rely on filtering shader blocks by duplicates in ES. It is valid in many cases to have the same shader block source repeated (as long as they originate in different styles).


update links in the documentation

In the guide on How to Publish Context Information as (Open) Data in CKAN link, the link to the instructions on how to configure CKAN and Cygnus is not up-to-date: the page does not still exist.
The broken link is https://github.com/telefonicaid/fiware-connectors/blob/master/flume/README.md.
In addition, the guide is lack of information about how to do what you are explaining ... it seems to be almost an advertisement of what you would like to provide!!!

The documentation version you are referring to is a stale build 4/10/2016 of an obsolete branch (develop) - the latest CKAN documentation can be found here  and the link and the text has already been amended since then.
@jmcanterafonseca , as you have the admin rights, could you update the project in Readthedocs and delete the builds and set-up from develop branch. Since the branch has not been merged back into master for nearly two years and no-one has complained, I assume there is nothing worthwhile to re-add into the current docs.

Ok, thank you for your answer and the link to the updated version of the docu.
However, I would suggest to insert any highlighted message saying that the doc is not up-to-date (in addition, the link to the latest version is not working)

The stale branch should be deleted IMHO - unfortunately it can't be styled as out-of-date as such functionality isn't available under readthedocs, however latest should always point to the latest version.
http://fiwaretourguide.rtfd.io/ is a short cut for  https://fiwaretourguide.readthedocs.io/en/latest/ but whether this  works will also depend on the Project's Readthedocs configuration. Any further action will need to be done by the RTD project administrator.


Add fn key to MASPickCocoaModifiers

I uncovered a very strange bug in an app I'm working on, which allows single-key shortcuts by using a custom validator; however, my validator still calls -[MASShortcutValidator isShortcutAlreadyTakenBySystem:explanation:].
It turns out that if you open the "View" (or "Window"?) menu and close it, from that point on MASShortcut will start recognizing the "Enter Full Screen" menu item, which has a shortcut of fn-F (stylized as globe-F). Then, when calling -[MASShortcutValidator isShortcutAlreadyTakenBySystem:explanation:], MASPickCocoaModifiers drops the NSEventModifierFlagFunction mask, which makes it appear the same as the bare "F" key, and the user is prohibited from selecting "F" as a shortcut.
I imagine this would also be an issue if the user assigned any custom shortcuts to a menu item (from System Preferences > Keyboard) that include the fn key, e.g. fn-cmd-shift-A would conflict with cmd-shift-A.
This PR fixes the issue by including NSEventModifierFlagFunction in the flags returned by MASPickCocoaModifiers.

I think a deeper issue is that Carbon just doesn't support the fn key as a modifier at all (there's cmdKeyBit, shiftKeyBit, etc. but there's nothing that supports the function key as a modifier in <HIToolbox/Events.h>). I think it's a Cocoa addition, so there may not actually be a way to register a hotkey involving the fn key using the Carbon API.
Perhaps this change could just be applied to the body of -[MASShortcutValidator isShortcutAlreadyTakenBySystem:explanation:] so that it will properly handle menu shortcuts containing the fn key? That way it would solve the issue I was facing without deciding to fully support fn or causing any unexpected consequences.

I updated the PR with one possible way of doing this.


Update First Chain Tutorial

Updates tutorial to the same commit as the node-template.

Fair point @kaichaosun. I was not aware of that repo. I'll do a PR to update it.


Import @angular in *.ts file - red underline in path.

VSCode Version: 2.5.3-insiders.20170919
OS Version: Win 7, 64-bit

Steps to Reproduce:

Install angular via npm
Import it in ts module (eg. import { NgModule } from '@angular/core';)
You can see that VS Code underlines path (may it be issue with at sign in @angular?)

Reproduces without extensions: Yes
Error does not occur if I import for example rxjs/Rx.
If I do instead import { NgModule } from '@angular/core/core'; from example above,  it works, however it is not valid path, and app does not build.
It worked properly in previous build.
Warning: VS Code underlines import path after few seconds

Duplicate of #34681
As Andy suggests, try installing npm install -g<EMAIL_ADDRESS>then set up vscode to use it


Agents in chat ui

This breaks the demo that depend on #246 so I opened a separate PR. These are the changes required for chat-ui agents. still WIP

Will merge this if you think the agents stuff is good enough @gary149

Are you still working on Agents?  Something like this would be really useful for attaching a VectorDB to Chat-UI to perform RAG.


Better Account for Feature Correlations

Many features are highly correlated and/or measure similar underlying behaviors. In other issues, e.g., https://github.com/Watts-Lab/team-process-map/issues/116, we previously explored "bagging" together correlated features, but these did not lead to significant improvements in our models.
We may need to explore other ways to account for the fact that we have several features measuring similar or related ideas --- and very strong correlations between certain columns.

Closing as this is about a previous version of the project and no longer related to the toolkit


Add Owner FK Trait to Database Fields

Raster Foundry needs to disambiguate the creator and owner of objects in the API. This task is to add a trait that can be used across almost all database fields that adds an owner field that is a foreign key to users.

Also update swagger specification with new field (UserTrackingMixin (?))


bug: Adding *ngIf to the button breaks Thumbnail List

Type: bug
Ionic Version: 2.x
Platform: all
I took the example for Thumbnail List form the Ionic web site (http://ionicframework.com/docs/v2/components/#thumbnail-list) and added an *ngIf attribute on the  element inside the list. As soon, as the condition attribute is added, the list is not displayed correctly anymore.
Here is a picture showing the bug: https://dl.dropboxusercontent.com/u/14863975/ngIf-on-button-in-thumbnail-list.png
Here is the source code: http://codepen.io/anon/pen/WrgYYy

This is a duplicate of #5060 but thank you for the issue!


Add Swift

Please consider adding this language or platform.
I might possibly send a PR with a starter kit (and can try to make Dockerfile - but have no experience).

Sure. Would you like to help?
We'll need to add dockerfiles to this repository (see https://github.com/icfpcontest2020/dockerfiles/tree/master/dockerfiles/java for example).
We'll also need to create a starter kit that does a HTTP POST request to the provided URL.
I've created a repo for Swift starterkit here: https://github.com/icfpcontest2020/starterkit-swift
You can use the Java starterkit as an example of the desired behavior: https://github.com/icfpcontest2020/starterkit-java


Issue on Android 29

It appears that the implementation doesn't work properly when I set edge-to-edge on an Activity. The bottom navigation bar is still fully transparent. For example:

What I want is to have the bottom navigation bar semi-transparent:

My fix is to have the Edge-to-Edge use the "android.R.id.content" view as the root view instead of the decor view.
I have created a project that shows the issue and the fix. See https://github.com/thierryd/EdgeToEdgeActivityIssue

Fixed in 1.0-rc1, which is on the way.

@beworker Good job on fixing it and doing a fast release! I confirm that it work well for me. And also good job on adding a FullscreenActivity to the sample.  I didn't want to point that it was needed (didn't want to look like an old grumpy user ;) ), but it is certainly a good idea! :)

Thanks man for your effort of creating a demo project, showing the bug, and the solution. It was extremely helpful and speeded up the fix. Having the screen in the demo app appeared to be a good long-term time "investment", that's why I decided to add it :)


fix: typo in jsdoc examples

bundle has been renamed to nodejs. Not sure if there are more things renamed.

On second glance, it looks like this applies to JavaProps and CopyFiles as well...

Thanks @estyrke. Merged the fixes.
^ top part of the Function doc is still outdated. We will be fixing it in the next day or two.


Prisma Client for python is not generating.

Bug description
Whenever I try to generate the client using prisma generate, I get the following output:
Environment variables loaded from .env
Prisma schema loaded from schema.prisma

But when I try to run my code (which obviously uses the prisma client, I get the following error:
Traceback (most recent call last):
  File "C:\Users\HP\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\HP\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "D:\Heavy Programming\Projects\The YPS Central\the-yps-central\server\__main__.py", line 2, in <module>
    from prisma import Prisma, register, get_client
  File "<frozen importlib._bootstrap>", line 1055, in _handle_fromlist
  File "D:\Heavy Programming\Projects\The YPS Central\the-yps-central\server\venv\lib\site-packages\prisma\__init__.py", line 42, in __getattr__
    raise RuntimeError(
RuntimeError: The Client hasn't been generated yet, you must run `prisma generate` before you can use the client.
See https://prisma-client-py.readthedocs.io/en/stable/reference/troubleshooting/#client-has-not-been-generated-yet

How to reproduce

Run prisma generate
Run your code

Expected behavior
I expected my python flask server to start successfully.
Prisma information

generator client {
  provider = "prisma-client-py"
  interface = "async"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

enum Role {
  USER
  ADMIN
}

model User {
  id Int @id @default(autoincrement())
  createdAt DateTime @default(now())
  email String @unique
  username String
  firstName String
  lastName String
  role Role @default(USER)
  password String
}

Environment & setup

OS: Windows
Database: PostgreSQL
Python version: 3.9.10
Prisma version: 3.13.0

Hi @MK272008, the issue you're experiencing is due to https://github.com/prisma/prisma/issues/10270. That issue leads to the Prisma CLI not printing the Python client's error message.
Please try running prisma generate again after setting the following environment variables:

DEBUG to *
PRISMA_PY_DEBUG to 1

Let me know what the error message is and I'll investigate further.

Its still not working. Just getting the same error message while running the server.

@MK272008 what happens when you run prisma generate after setting those environment variables?

I only get these two lines in the terminal.

@MK272008 I'm not sure why you're still not getting error logs, sorry about that.
The error you're encountering is because of a typo in the interface option, you need to use asyncio instead of async. For example:
generator client {
  provider  = "prisma-client-py"
  interface = "asyncio"
}

Please re-open if you need any more guidance :)

@RobertCraigie This is still happening with my environment. I am not getting any error messages when running prisma migrate with the debug options on.
(plutus) C:\Users\jared\Documents\Github\Personal\plutus>prisma migrate
[DEBUG  ] prisma.binaries.binaries: query-engine cached at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-query-engine-windows.exe
[DEBUG  ] prisma.binaries.binaries: migration-engine cached at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-migration-engine-windows.exe
[DEBUG  ] prisma.binaries.binaries: introspection-engine cached at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-introspection-engine-windows.exe
[DEBUG  ] prisma.binaries.binaries: prisma-fmt cached at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-prisma-fmt-windows.exe
[DEBUG  ] prisma.binaries.binaries: prisma-cli-windows.exe cached at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-cli-windows.exe
[DEBUG  ] prisma.binaries.binaries: All binaries are cached
[DEBUG  ] prisma.cli.prisma: Using Prisma CLI at C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-cli-windows.exe
[DEBUG  ] prisma.cli.prisma: Running prisma command with args: ['migrate']
  prisma:engines binaries to download query-engine, migration-engine, introspection-engine, prisma-fmt +0ms
  prisma:download Using env var PRISMA_QUERY_ENGINE_BINARY for binary query-engine, which points to C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-query-engine-windows.exe +0ms
  prisma:download Using env var PRISMA_MIGRATION_ENGINE_BINARY for binary migration-engine, which points to C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-migration-engine-windows.exe +0ms
  prisma:download Using env var PRISMA_INTROSPECTION_ENGINE_BINARY for binary introspection-engine, which points to C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-introspection-engine-windows.exe +1ms
  prisma:download Using env var PRISMA_FMT_BINARY for binary prisma-fmt, which points to C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-prisma-fmt-windows.exe +0ms

Update the database schema with migrations

Usage

  $ prisma migrate [command] [options]

Commands for development

         dev   Create a migration from changes in Prisma schema, apply it to the database
               trigger generators (e.g. Prisma Client)
       reset   Reset your database and apply all migrations, all data will be lost

Commands for production/staging

      deploy   Apply pending migrations to the database
      status   Check the status of your database migrations
     resolve   Resolve issues with database migrations, i.e. baseline, failed migration, hotfix

Command for any stage

        diff   Compare the database schema from two arbitrary sources

Options

  -h, --help   Display this help message
    --schema   Custom path to your Prisma schema

Examples

  Create a migration from changes in Prisma schema, apply it to the database, trigger generators (e.g. Prisma Client)
  $ prisma migrate dev

  Reset your database and apply all migrations
  $ prisma migrate reset

  Apply pending migrations to the database in production/staging
  $ prisma migrate deploy

  Check the status of migrations in the production/staging database
  $ prisma migrate status

  Specify a schema
  $ prisma migrate status --schema=./schema.prisma

  Compare the database schema from two databases and render the diff as a SQL script
  $ prisma migrate diff \
    --from-url "$DATABASE_URL" \
    --to-url "postgresql://login:password@localhost:5432/db" \
    --script

  prisma:getConfig Using CLI Query Engine (Binary) at: C:\Users\jared\AppData\Local\Temp\prisma\binaries\engines\efdf9b1183dddfd4258cd181a72125755215ab7b\prisma-query-engine-windows.exe +0ms

@RobertCraigie This is still happening to me. I get no error messages when running prisma generate with this as my schema.prisma file:
datasource db {
  url      = env("DATABASE_URL")
  provider = "postgresql"
}

generator client {
  provider = "prisma-client-py"
  generator = "asyncio"
  recursive_type_depth = 5
}

model User {
  id        Int      @id @default(autoincrement())
  createdAt DateTime @default(now())
  email     String   @unique
  name      String?
  role      Role     @default(USER)
}

enum Role {
  USER
  ADMIN
}

When running prisma db push I get success message:
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db": PostgreSQL database "plutus", schema "public" at "localhost:5432"

The database is already in sync with the Prisma schema.

Running generate... - Prisma Client Python (v0.7.0)

But the main.py file gives the error The Client hasn't been generated yet, you must run prisma generate before you can use the client.
import asyncio
from prisma import Prisma

async def main() -> None:
    db = Prisma()
    await db.connect()

    post = await db.user.create(
        {
            'email': 'test@email.com!',
            'name': 'Prisma test, databases made easy.',
        }
    )
    print(f'created post: {post.json(indent=2, sort_keys=True)}')

    found = await db.post.find_unique(where={'id': post.id})
    assert found is not None
    print(f'found post: {found.json(indent=2, sort_keys=True)}')

    await db.disconnect()

if __name__ == '__main__':
    asyncio.run(main())

@jareducherek It looks like you have generator = "asyncio" when you need to use interface = "asyncio" instead, that might be what is causing the issue.
In regards to no error message being shown, that issue will be fixed in the next release, if you want to try it out now you can install from GitHub using this command :)
pip install -U git+https://github.com/RobertCraigie/prisma-client-py

Thanks for the quick reply, such a simple fix! Really looking forward to digging in here, this is my first time making a database, and planning for it to be quite extensive.

Glad I could help!
Exciting stuff! I'm happy you chose to use Prisma for your first time working with a database and please let me know if you need any assistance :)

Hi, I've got a similar issue.
When running my code I get the following error:
Traceback (most recent call last):   File "D:\Users\badet\Desktop\cloudbot\main.py", line 9, in <module>     from prisma import Prisma   File "<frozen importlib._bootstrap>", line 1075, in _handle_fromlist   File "D:\Users\badet\PycharmProjects\1\venv\lib\site-packages\prisma\__init__.py", line 50, in __getattr__     raise RuntimeError( RuntimeError: The Client hasn't been generated yet, you must run prisma generate` before you can use the client.
See https://prisma-client-py.readthedocs.io/en/stable/reference/troubleshooting/#client-has-not-been-generated-yet
Process finished with exit code 1`
My schema.prisma:
`datasource db {
provider          = "postgresql"
url               = env("DATABASE_URL")
}
generator client {
provider = "prisma-client-py"
recursive_type_depth = 5
interface  = "asyncio"
}
model users {
id            Int     @id @default(autoincrement())
uid           String
createdAt     DateTime @default(now())
nickname      String
trustfactor   Int
}
`
My main.py:
`import datetime
import os
from termcolor import colored
import ts3
import mariadb
import sys
import asyncio
from prisma import Prisma
from prisma import Client
Initialize Prisma client
prisma = Client()
Authenticate your bot with Prisma
bot_email =<EMAIL_ADDRESS># Replace with your bot's email address
bot_password = "GnbacoapJQ5MQ43#"   # Replace with your bot's password
Assuming you have a User model in your Prisma schema
authenticated_bot = prisma.user.find_first(where={"email": bot_email, "password": bot_password})
if authenticated_bot:
bot_id = authenticated_bot.id
print(f"Bot authenticated with ID: {bot_id}")`
However, when running 'prisma generate' I get 0 errors:
`Environment variables loaded from .env
Prisma schema loaded from schema.prisma
✔ Generated Prisma Client Python (v0.11.0) to .\venv\lib\site-packages\prisma in 134ms
`


resetOptionsStates() throws an error

Describe the bug
As a developer, I want to allow our users to clear all options in an auro-menu. Per the doc, there is a method called resetOptionsStates(), but I couldn't get it to work.
To Reproduce
Steps to reproduce the behavior:

Create an auro-menu with a few options
Via javascript, call resetOptionsStates()
A error is thrown

Expected behavior
Should clear all options
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
I'm basically looking for guidance on how to clear all options.

@jordanjones243 can you take a look at this?

@jordanchang I have investigated this issue within the code of auro-menu. I tested the resetOptionsStates() function and it seems to be working as expected.
The this.items is undefined error being thrown is due to the fact that this.items is initialized with all existing auro-menuoption elements, which makes me believe it could have something to do with your implementation.

After further investigation, this error was being thrown because the resetOptionsStates() was being called on this.items when there was no menu options in an auro-menu.
This issue will be closed and a new issue will be opened to reference the root bug:

https://github.com/AlaskaAirlines/auro-select/issues/129


Enhancements to Govulncheck parser

Description
This Pull Request introduces several key enhancements to the govulncheck parser, aiming to provide more detailed and actionable vulnerability data within DefectDojo. The updates focus on enriching the parsed information with additional contextual details and traceability, making it easier for users to understand and act upon the findings.
Note :

Changes have been made to the parsing of the new govulncheck format. The old format is of course still supported.
Feel free to provide any suggestions or feedback for further improvements; If any part of the code is unclear, I can add explanatory comments or even rewrite sections for better clarity and understanding.

Key Changes :

Richer finding title.

The parser now constructs the title using a combination of the Go vulnerability ID, the affected package name and the path within the package.
Example : GO-2023-2382 - Stdlib - Net/HTTP/Internal

Detailed vulnerability description.

The parser now adds more descriptive details about each vulnerability, including summary, vulnerable functions and affected versions into the description.

Inclusion of Trace information in the description of the finding.

The component version is now set to the first version available in the trace.
Previously, it was loaded from "schema_version", which is not related to the vulnerability.

Inclusion of details about the impact of the finding.

The parser is now adding details about the impact of the vulnerability in the 'impact' field.

Introduction of and optional custom severity field.

govulncheck is not providing severity information in its output. The parser has been updated to include an optional severity field which can be populated to set severity. This enhancement flexibility of the parser.

Screenshot:
Before :

After :

Test results
Tests have been updated with new tests to cover changes :

System check identified no issues (0 silenced).
test_parse_empty (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_empty) ... ok
test_parse_many_findings (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_many_findings) ... ok
test_parse_new_version_many_findings (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_new_version_many_findings) ... ok
test_parse_new_version_many_findings_custom_severity (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_new_version_many_findings_custom_severity) ... ok
test_parse_new_version_no_findings (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_new_version_no_findings) ... ok
test_parse_no_findings (unittests.tools.test_govulncheck_parser.TestGovulncheckParser.test_parse_no_findings) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.039s

OK
Destroying test database for alias 'default' ('test_defectdojo')...

Documentation
Do I need to update any documentation ?
Checklist
This checklist is for your information.

[x] Make sure to rebase your PR against the very latest dev.
[x] Features/Changes should be submitted against the dev.
[x] Bugfixes should be submitted against the bugfix branch.
[x] Give a meaningful name to your PR, as it may end up being used in the release notes.
[x] Your code is flake8 compliant.
[x] Your code is python 3.11 compliant.
[x] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[x] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[x] Add applicable tests to the unit tests.
[x] Add the proper label to categorize your PR.

The check "Detect Merge Conflicts" was failing. Following rebase instructions resolved the issue.


busybox: 1.29.2 -> 1.29.3

Release includes possibly important change,
reverting a commit causing a regression.
https://git.busybox.net/busybox/commit/?h=1_29_stable&id=2993551efcb09ace35b40db608ab08159834692b

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: busybox
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

backported to 18.09 in 93e78c721c2


Add codecov badge

Continuation of #224. This PR adds codecov badge.

Adding codecov badge is a good suggestion, it helps us know the current coverage ratio of the repository. Some contributors may help to improve the coverage ratio by adding more tests to increase the number of lines covered by tests. Why is this PR still under review and not merged?

Why is this PR still under review and not merged?

Perhaps @raklaptudirm missed it due to being busy.


[ASTPrinter] Simplify archetype printing by visiting the interface type.

This simplifies the archetype printing code, and fixes an issue where <<anonymous>> was printed in diagnostics for opaque parameter types.
Resolves: rdar://91959195

@swift-ci please smoke test


Refresh kernels when a new conda env is created

Fixes #8508

Codecov Report

Merging #9091 (952cd11) into main (69e7bf7) will decrease coverage by 0%.
The diff coverage is 88%.

:exclamation: Current head 952cd11 differs from pull request most recent head a0223b8. Consider uploading reports for the commit a0223b8 to get more accurate results

@@          Coverage Diff          @@
##            main   #9091   +/-   ##
=====================================
- Coverage     71%     70%   -1%
=====================================
  Files        382     382
  Lines      24681   24744   +63
  Branches    4001    4005    +4
=====================================
- Hits       17574   17554   -20
- Misses      5517    5589   +72
- Partials    1590    1601   +11

Impacted Files
Coverage Δ

src/client/api/types.ts
100% <ø> (ø)

src/client/interpreter/contracts.ts
100% <ø> (ø)

.../datascience/notebook/notebookControllerManager.ts
80% <77%> (+2%)
:arrow_up:

src/client/api/pythonApi.ts
66% <92%> (+1%)
:arrow_up:

src/client/common/process/condaService.ts
83% <93%> (+4%)
:arrow_up:

...ience/variablesView/variableViewMessageListener.ts
77% <0%> (-23%)
:arrow_down:

...ent/datascience/notebook/notebookDisposeService.ts
85% <0%> (-15%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
67% <0%> (-11%)
:arrow_down:

src/client/datascience/commands/serverSelector.ts
90% <0%> (-10%)
:arrow_down:

...ient/datascience/jupyter/kernels/kernelProvider.ts
85% <0%> (-9%)
:arrow_down:

... and 40 more


Animated WebP

The latest version of FFMPEG supports animated WebP (WebP (encoders: libwebp_anim libwebp ), but it doesn't look like it's made it into this project yet (only: WebP (encoders: libwebp )).
I'm not sure what version of FFMPEG this project is based on, but are there plans to add the libwebp_anim codec? Thanks!

Note this issue in https://github.com/ffmpegwasm/ffmpeg.wasm/issues/61

Thanks, I'll leave my comment there.


seccomp: bugfixes

Signed-off-by: Christian Brauner<EMAIL_ADDRESS>

Re: prevents us from printing help or version: yes, that was my bad. Thanks for catching this!


Address comments in https://github.com/google/cpu_features/pull/94

Addressing comments in https://github.com/google/cpu_features/pull/94.
@digit-google can you take a look?

Nice :) Hurray for C struct literals btw, they rock ;)

Thx for the review and thx for the great comments. The code is much better now :)


WheelCollider.GetWorldPose(out position, out rotation) not working correctly

It seems to return both values as null.
Here is a code example:
using UdonSharp;
using UnityEngine;

public class Example : UdonSharpBehaviour
{
    public WheelCollider Wheel;
    public GameObject VisualWheel;

    void Update()
    {
        Wheel.motorTorque = 1000;

        Vector3 position;
        Quaternion rotation;

        Wheel.GetWorldPose(out position, out rotation);

        VisualWheel.transform.position = position;
        VisualWheel.transform.rotation = rotation;
    }
}

I've ran a test that shows this isn't a Udonsharp issue. It seems to be related to the Quaternion.toAxis issue depicted in the readme, because both functions seem to use output parameters. I've added this test to the Canny.io issue.
Maybe it's helpful to change the readme to change the Quaternion.toAxis, but add a warning/disclaimer on functions with out parameters?

Thanks, the readme already has a warning about other functions with multiple out parameters potentially not functioning due to the Udon bug. I haven't run into any issues with functions that have a single out parameter.

I don't know why I've read over that, but thank you for your time!


Add both GA and WUM Updated support for Vagrantfile

Description:
Vagratfile should support both GA and WUM updated Enterprise Integrator Servers.
Suggested Labels:
Type/Improvement
Suggested Assignees:
@VimukthiPerera
OS, DB, other environment details and versions:
Vagrant 2.1.5

Closing this since this has been fixed in https://github.com/wso2/vagrant-ei/pull/33


fix: remove extra notification delegate handling

The type of this PR is: fix
Description
Fixes an issue with our push notifications not deeplinking correctly, this was due to us implementing some new notification center delegate methods as part of the braze integration and as a result our old delegate methods were not getting called. Tested both braze push and a local push and both seem to be working now.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Fix push notification deeplinking - Brian

Android user-facing changes

Dev changes

This PR contains the following changes:

iOS user-facing changes (Fix push notification deeplinking - Brian)

  Generated by :no_entry_sign: dangerJS against 5e211ea4e1cd320c14fa9afce5f325a1c49d7cde


HSEARCH-3179 Merge the Search 6 Proof-of-concept into the main repository

https://hibernate.atlassian.net//browse/HSEARCH-3179
This is to continue the work on the original repository, since we are now confident enough that this code will become Search 6 eventually. It does not mean the code is ready for release, far from it. We will have to solve at least these tickets before we can release an Alpha1, and there are many more before we can release a Beta, and even more before we can release a CR
Obviously this is a huge pull request, and most of the commits have already been reviewed at https://github.com/hibernate/hibernate-search-6-poc, so reviewing the diff would be a complete waste of time.
I'm submitting this PR mainly so that we can have a look at the result of the merging script before we actually merge into master.
How did I get this
I used the merging script that I developed just for this merge: https://gist.github.com/yrodiere/01075d72fb3c23963cd473055e287198
And executed this:
mkdir /tmp/test
~/workspaces/main/search6-merge/search6-merge -5 ~/workspaces/main/hibernate-search-parent -6 ~/workspaces/main/hibernate-search-6-poc -t git@github.com:yrodiere/hibernate-search.git -b HSEARCH-3179 -r -a "search5/HSEARCH-3179^{/HSEARCH-3179 Set directory 'legacy' as a legacy submodule}..search5/HSEARCH-3179" /tmp/test

You can have a look at the script if you like, but it's not really production-grade code... Let's just say most of what it does was discussed over the last few months.
What to check
Below is a list of things I know we have to check. Feel free to come up with others!
Commits to review
The very last commits should probably be reviewed, since they were added specifically for this merge.
See all the commits from "HSEARCH-3179 Set directory 'legacy' as a legacy submodule" to HEAD.
EDIT: As usual GitHub shows the wrong order for commits, and here it's really making review impossible. Here are links to the commits, and the command used to generate this list if necessary:
git rev-list --oneline --reverse "HSEARCH-3179^{/HSEARCH-3179 Set directory 'legacy' as a legacy submodule}..HSEARCH-3179" -- | sed -E 's,^(\S+) (.*),[\1 \2](https://github.com/hibernate/hibernate-search/pull/1723/commits/\1),'

58e18c439c HSEARCH-3179 Fix the legacy distribution module following the file moves
25390e977c HSEARCH-3179 Merge Search 5 Travis configuration into Search 6
32b3cd4de9 HSEARCH-3179 Merge Search 5 Jenkins configuration into Search 6
b1f102dcfc HSEARCH-3179 Merge Search 5 build configuration into Search 6
fe81a78408 HSEARCH-3179 Generate source artifacts for published Search 6 Maven modules
5ef2217468 HSEARCH-3179 Generate manifest files for published Search 6 Maven modules
56e14d9d42 HSEARCH-3179 Package the Infinispan relocation artifact as POM
4bbce684be HSEARCH-3179 Merge Search 5 reports module into Search 6
291497e273 HSEARCH-3179 Skip plugin executions that are not relevant for legacy code
8c98e633b1 HSEARCH-3179 Disable the ES2 job in the Travis build
0b984c8b37 HSEARCH-3179 Merge Search 5 Elasticsearch test configuration into Search 6
202bffc9dc HSEARCH-3179 Merge Search 5 IDE profiles into Search 6
76e94aad35 HSEARCH-3179 Merge Search 5 testing configuration into Search 6
80405dbe94 HSEARCH-3179 Merge Search 5 POM metadata into Search 6
d6431264dd HSEARCH-3179 Merge Search 5 version properties into Search 6
31359b829f HSEARCH-3179 Remove the mapper-protobuf module for now
26e7205133 HSEARCH-3179 Avoid uses of ${project.groupId}, use literals instead
3ade5739f0 HSEARCH-3179 Add a dependency from the engine module to the new common internal utils module
da1c22a5bf HSEARCH-3179 Use the Contracts util even in legacy modules
10c16bdc7a HSEARCH-3179 Merge the Closer from Search 5 into Search 6
8606646051 HSEARCH-3179 Merge the Executors util from Search 5 into Search 6
b87a496c68 HSEARCH-3179 Merge the Futures util from Search 5 into Search 6
a328400e55 HSEARCH-3179 Merge the Throwables util from Search 5 into Search 6
cdccc0e8c2 HSEARCH-3179 Merge the CollectionHelper util from Search 5 into Search 6
ccf9b9096f HSEARCH-3179 Move the SearchThreadFactory helper from Search 5 into Search 6
dbbcb51a53 HSEARCH-3179 Remove an unnecessary dependency to hibernate-commons-annotations in the engine
a5939dbd67 HSEARCH-3179 Set the JQAssistant store lifecycle to MODULE
b7c84e6a84 HSEARCH-3179 Merge hibernate-search-sharedtestresources from Search 5 into Search 6
d43889b8e4 HSEARCH-3179 Skip tests by default for the legacy module
0aeab5a2e4 HSEARCH-3179 Enable legacy ITs in the Jenkinsfile when building master or maintenance branches
a627c829de HSEARCH-3179 Add badges to README.md
388daf8c68 HSEARCH-3179 Update Sonar exclusions to exclude legacy code
END OF EDIT
Jenkins build
See http://ci.hibernate.org/view/Search/job/hibernate-search/
Travis build
See https://travis-ci.org/yrodiere/hibernate-search
IDE
Try to import the project into Intellij IDEA and into Eclipse. Try to run tests, both from the legacy code and from the new code.
Code structure
The merging script applied a bunch of rewrites to the git history, most notably to change the packages from org.hibernate.search.v6poc to org.hibernate.search.
We should check that the code structure still makes sense: each module has its own root package, everything compiles correctly.
Pick one or two older commits and check the code structure makes sense as well.
Git history
We should check how the history of copied files looks like.
For example git log --follow -- mapper/orm/src/main/java/org/hibernate/search/mapper/orm/bootstrap/impl/ExtendedBeanManagerSynchronizerContributor.java should show the whole history of this file, including changes from Search 5.
I know, however, that IDEA has a custom implementation of git history that is supposed to be better and handle merges more nicely, but fails at detecting the file copies (due to the missing --follow parameter when it calls git show, I think). I still have to get to the bottom of this and report the bug if relevant.
Maybe @gsmet could check what happens when looking at the git history from Eclipse?
Note that due to limitations of git, some files may not be displayed as copied when reviewing the commit where the copy happens (essentially for performance reasons). This is configurable, but I don't think it matters: we should review the history as a new user without any specific configuration would see it.

LGTM, let's squash it to one commit and add on top of master 🤣

LGTM, let's squash it to one commit and add on top of master rofl

@emmanuelbernard Why bother, let's squash master too :)

@gsmet It should be good now. I applied most of your suggestions, rebased, and added a few commits.
I updated the list of commits with the new hashes. Here are the added commits:
9dd88be08a HSEARCH-3179 Update Sonar exclusions to exclude legacy code
ba93487150 HSEARCH-3179 Use the correct module reference for non-default ITs in Jenkinsfile
72fc4cce77 HSEARCH-3179 Update previous.stable
9f20196a0f HSEARCH-3179 Disable javadoc generation in legacy modules
0729d1c40f HSEARCH-3179 Update the version of the Lucene javadoc to match our dependencies
9e70e9a8d8 HSEARCH-3179 Move version tags used in javadoc links near the corresponding version properties
79c5f9cdcd HSEARCH-3179 Update legacy http://search.hibernate.org URL to http://hibernate.org/search/
01c678e32b HSEARCH-3179 Add a missing plugin execution filter for m2e
80eccc8686 HSEARCH-3179 Add a warning about the master branch being work in progress

@yrodiere looks good to me now.

@gsmet Thanks! Merging.


eth_to_bech32 is returning the eth address all in lower case

Returning the address in lower case makes the eth_to_evmos method to fail:
evmoswallet.converter.eth_to_evmos('0x8211e9935bb5a3ea22edf98f1f5edb2a9a342b4')
None

With correct capitalization:
evmoswallet.converter.eth_to_evmos('0x8211E9935Bb5a3EA22EdF98f1F5eDB2A9A0342B4')
'evmos1sgg7ny6mkk375ghdlx837hkm92dqxs450fxwwz'

The actual error was some missing 0s, fixed on this commit and release 1.0.4


Derive variable names from getter functions

Is your feature request related to a problem? Please describe.
When decompiling x86:LE:32:default:windows Portable Executables, like this one, Ghidra appears to assign variable names based on the variable type.
HPALETTE hPal;
HDC hdc;
HPALETTE hPal_00;
UINT UVar1;
bool bVar2;

bVar2 = false;
hPal = (HPALETTE)GetWindowLongA(param_1,4);

Using dogbolt.org, Hex-Rays appears to guess the variable name from the getter function name:
HPALETTE WindowLongA; // edi
HPALETTE v4; // eax
HDC DC; // eax
HDC v6; // esi
UINT v7; // eax
HPALETTE hWnda; // [esp+14h] [ebp+4h]

v2 = 0;
WindowLongA = (HPALETTE)GetWindowLongA(hWnd, 4);

Describe the solution you'd like
I'd like for Ghidra to derive variable names from the first call to a getter library function like KERNEL32.DLL::GetCommandLineA or KERNEL32.DLL::GetWindowLongA, if possible.
Describe alternatives you've considered
None
Additional context
None

Also, it might make sense to offer an option to derive variable names from the parameter names of library functions, in the example above hWnd


ConnectorSink 2PC overhaul

Re-implements the ConnectorSink + 2-Phase Commit protocol via two new FSMs, the "external connection operations" FSM and the "checkpoint/rollback operations" FSM.

_ExtConnOps: aka, "external connection operations".  This trait
describes the FSM used to manage mid-level details of this sink's
TCP connection, e.g., disconnected, connected but not yet ready to
send application data to the external sink, connection is fully
operational.  See the FSM state diagram on the righthand side of
connector-sink-2pc-management.png.

_CpRbOps: aka, "checkpoint/rollback operations".  This trait
describes the FSM used to manage high-level operation of this sink
and Wallaroo's overall status (e.g., starting, rolling back, running)
together with _ExtConnOps's mid-level management of the TCP
connection.  See the FSM state diagram on the lefthand side of
connector-sink-2pc-management.png.

Partial fix for bug #3097
Fixes #3086
Fixes #3031
Perhaps addresses #2878
Fixes #2814

The reconstruct_input_producer_barrier_events() method in BarrierSinkPhase is bogus: it can reorder app msgs wrt barrier tokens ... and I've now witnessed that exact re-ordering happening, derp.  I definitely need to rip it out, first thing tomorrow morning.

@jtfmumm This branch is near ready: I'm looking at an intermittent failure right now, but it has had a big overhaul of how the phase buffering is done.  This PR replaces a lot of bad code that (alas for me) worked most of the time, so even if it isn't 100% perfect, it's far better than today's master branch.  Unless there's something terrible lurking in here, I think I can work on the intermittent failures in separate bugs & PRs.


Block debug during npm install

When starting debug during npm install. Visual studio display the message:
Attribute 'program' does not exists (<JavaScript_file>).
This PR aborts starting debug during the initial npm install and display an error message to the user. Note that it doesn't block any subsequent installs.

This is how the error message looks like:

I checked how .net core projects handle this scenario (for having a uniform experience) but they don't handle it. Instead you cannot compile the project as it wont find the necessary libraries. So I decided on displaying a pop up  message as NTVS normally does.
Also, we can improve this scenario by reporting the background task on the lower left corner. We discuss more about this.

Yes, I'm looking at that right now I'll send another PR as soon as is ready.


Use null Instead of false When No Default Value is Provided

Code for parseBoolean:
   public static boolean parseBoolean(String s) {
        return ((s != null) && s.equalsIgnoreCase("true"));
    }

So when the BooleanProperty has no default value (e.g. s == null), we are setting the default value as false.
One of the problems caused by this issue:
https://github.com/kongchen/swagger-maven-plugin/issues/284

@frantuma is this good to merge?

I could really use this as well. Any update on the merge?

@thebeeber unfortunately this didn't make the cut for 1.5.10, but we'll try to push it to 1.5.11 (no ETA yet).


Refactor on SignRequest

Background
In the PR, we introduced VerificationPlugin and VerificationPluginMinVersion to the SignRequest to support validate  them in the notation-core-go.
Problem

As specified in specs: Extended attributes for Notation Plugins and Extended Protected Headers for Notation Plugins, VerificationPlugin and VerificationPluginMinVersion should be placed inside the ExtendedSignedAttrs of SignRequest.
For the validation, according to Verification workflow using plugin, we can see that it's reasonable to group version validation and capability validation together once we retrieve the plugin metadata. However, current implementation puts version validation in notation-core-go and capability validation in notation-go. Besides it, part of version validation is placed in notation-go which made reviewers confused on the validation workflow.

Proposed refactoring

Move VerificationPlugin and VerificationPluginMinVersion to ExtendedSignedAttrs of SignRequest.
Move all version validation logics to notation-go, specifically version validation

The first refactoring is not valid now. And the second one is done. Closing the issue.


Remove unused discovery argument group

Summary
Not sure why this is here, but AFAICT it's unused.

Oh sorry, this is used for break_system_packages.


Provisioning for PXE boot

Is your feature request related to a problem? Please describe.
Provisioning changes for PXE.
Describe the solution you'd like
Monitor tftp service, change host name, perform cobbler sync after management node reboot.
Describe alternatives you've considered
These changes are add on to existing feature.
Additional context
Add any other context or screenshots about the feature request here.

We will use issue #153 for this.

We will use issue #153 for this.


No crotmp Syntax Highlighting

When opening a .crotmp file there is no syntax highlighting.
Under CMD+, (open setting) > Editor > File Types there is no entry under Cro::HTTP::WebApp template
This is a regression vs. final Comma Complete and maybe a regression against recent comma-plugin iterations.
All the raku file types are working fine.
Expected:

Got:

This is expected in comma-plugin as I have avoided everything related to Cro.
Please see #21 and add any remaining missing Cro-related functionalities to the checklist in this ticket.

@librasteve This should be addressed in beta 31

oh - I see that explains it - I'll close this issue for now
I'm hoping to add Fragment highlighting (a new Cro::WebApp::Template feature)


Icon submission: OnlyFans

[x] I have read and followed CONTRIBUTING document.
URL of the site or app (required, unless it's generic icon): https://onlyfans.com/
Where did you took the BG color(s) (required, unless it's generic icon): https://onlyfans.com/theme/onlyfans/spa/brand/OnlyFans_Social_Icons.zip

Uploaded files:
OnlyFans.zip

Well, that's weird. They still use old branding on the main site even when they have published this one.
I let this pass, because it mostly will be updated to this near future.
Anyways, logo was too big, so I had to change that.

I have been following if OF does rebrand with this logo, but seems like their brand page is back with old logo: https://onlyfans.com/brand
And homepage is still using old logo also.
Unsure if this rebrand happens or not, I will change it to "old" logo for now (or current logo, how knows anymore). Your name will stay on credits.
If change happens, obviously I will update it back to that logo.


Added option to disable Scriptable Singleton Asset Creator

This update adds functionality and gives the user the option to disable the newly added Scriptable Singleton Asset Creator from the library if the user adds the define DISABLE_SCRIPTABLE_SINGLETON_CREATOR to Unity.
It neatly integrates with one of our other packages called Define Manager. Please install Define Manager to install/remove defines across different packages with ease.

Requires documentation changes + changes to README file

The docs have been updated and this feature is now ready to be pushed


Support Node 20

Initial release: 2023-04-18
Active LTS start: 2023-10-24
https://github.com/nodejs/release#release-schedule
We announced public preview in September 2023 🎉
Please see our roadmap for the latest estimates on the GA timeline: https://github.com/Azure/azure-functions-nodejs-library/wiki/Roadmap

In the portal (https://portal.azure.com/), I have no way of choosing Node 20 in my Web App's configuration.

What is the timeframe for the portal to be updated to support Node 20 for Web Apps?

Hi @nathanchase this repo and my team only focuses on function apps. Unfortunately I don't know when the Web Apps team will update that

Hi @nathanchase this repo and my team only focuses on function apps. Unfortunately I don't know when the Web Apps team will update that

Thanks for the reply. Is there a public repo or any other method of feedback with the Web Apps team that you're aware of?

I pinged some folks offline, but I'm not getting much of a response. Unfortunately I don't think they have any public place for feedback. Last year web apps announced Node 18 on Nov 30th, so that's probably the best indicator of approximately when it might happen this year as well

https://azure.microsoft.com/en-us/updates/generally-available-azure-functions-support-for-nodejs-20/


 I imagine it's because those are keywords in C#? C# keywords should only highlighted if in a code block surrounded by <% %>

I have since switched to a different machine and haven't been able to reproduce it. You're probably right in that it was likely another extension interfering.
Great plugin btw! Really useful for those of use who still need to use Web Forms on a regular basis.


JUnit rule for testing database interactions

In several projects, I wrote a test code which allows testing of database interactions independently of @UnitOfWork annotations only present on resource methods. So I thought this might be useful to others as well. I rewrote it to be similar to other existing JUnit rule that are part of the dropwizard-testing module. I hope I followed all the coding conventions.
I added Hibernate and H2 to the dependencies of the testing module using scopes which hopefully don't pollute the classpath of users who are not interested in database testing (provided and test, respectively).
I also added a small section to the "Testing Dropwizard" part of the manual explaining how to use this rule.
Let me know if you have questions are if anything is missing.

Coverage decreased (-0.07%) to 81.373% when pulling 25824bb358651c3f50e59826cd13c89dc0cd4541 on rbarbey:daotestrule into e58bd868cad05ac246b254a100553e3152b0beb7 on dropwizard:master.

Coverage increased (+0.2%) to 81.6% when pulling 6d25d00fbe5b6491b5fe8989a25ee08f395eff80 on rbarbey:daotestrule into e58bd868cad05ac246b254a100553e3152b0beb7 on dropwizard:master.

Looks like a useful addition. I would consider it for the 1.1.0 version.

Closing this PR since it is superseded by #1669.


Allow caching the downloaded file.

The download from mariadb sometimes fails and takes about 6 seconds.
The downloaded file could be cached (by using actions/cache inside the setup-mariadb action).
2024-03-10T14:19:47.1780788Z curl -Ls -o mariadb.msi https://downloads.mariadb.com/MariaDB/mariadb-10.11.6/winx64-packages/mariadb-10.11.6-winx64.msi
2024-03-10T14:19:53.8303235Z msiexec /i mariadb.msi SERVICENAME=MariaDB /qn
2024-03-10T14:20:29.1565456Z

Added cachability and mirroring possibility to fork.


How to use OpenGL ES shader files and color mapping files to do custom filter?

How to use OpenGL ES shader files and color mapping files to do custom filter? Hope to give me some guidance,I really do not know how to handle it.

This is way too broad to answer. It's like asking how to write a program, without specifying what you want that program to do.
It is also not a bug or issue with the framework. Sorry, but you're going to need to refine this question to ask something more targeted and ask it elsewhere.