being able to insert time manually without specifying minutes or seconds. So only the hours (the other values default to 00)

This function solves the problem (这个功能解决的问题)
speed up manual inserts
Expected API (期望的 API)
no api changes

Time Picker?

yes

See https://github.com/TuSimple/naive-ui/pull/498.

this request is different. I'll give an example:
let's say we have a time-picker with HH:mm. I want to input 10 with the keyboard and have the value recognized by the time-picker. At the moment it doesn't work.

Corresponding to the implementation I think it will be not easy to implement a robust input like that.

yeah, maybe not worth it if it's a lot of work

yeah, maybe not worth it if it's a lot of work

The main concerning is that it may conflict with formatting.

I noticed that when you use the time-picker ui, just by clicking on the first type of value (in my case hours) it auto-selects 00 as minutes. Maybe it could be done using the same logic

t when you use the time-picker ui, just by clicking on the first type of value (in my case hours) it auto-selects 00 as minutes.

Controlling input is much harder than just controlling normal DOM.


Enable key repeat for non text keys

I'm currently developing a terminal application using egui. I use a fragment shader to display the content and use it inside a ViewPort scroll area:
           let output = ScrollArea::vertical()
           .auto_shrink([false; 2])
           .stick_to_bottom(true)
           .show_viewport(ui, |ui, viewport| { …

            let events = ui.input().events.clone();
            for e in &events { …
            }

I need to handle the key events myself and it works quite well - however key repeats for the command keys Arrow/Backspace are not working - only the Text event does. I can't figure out how to detect key repeats the egui::Event::Key { key, pressed: true, modifiers }  event is only once in the list.
Another issue is - can I disable the scroll drag in the ScrollArea somehow? It's interfering with my mouse selection in the control.

Starting in https://github.com/emilk/egui/pull/2334 (recently), key repeates are ignored. Perhaps this was a bad idea.

Another issue is - can I disable the scroll drag in the ScrollArea somehow? It's interfering with my mouse selection in the control.

See https://github.com/emilk/egui/pull/2163

It's not a bad idea per se having events for key press and release without repeat does make sense.
But I would vote for maybe a KeyReceived event for the key repeats.
The agree that the frame based event system is a bit tricky. But I really, really need key repeats here :/ (however now I know where to patch that - thanks.)

@emilk: Something like that would work https://github.com/emilk/egui/pull/2389
However I can't test that locally - my application crashes

thread 'main' panicked at 'failed to create glutin window surface: Error { raw_code: Some(12297), raw_os_message: None, kind: BadMatch }', /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:408:18
stack backtrace:
   0: rust_begin_unwind
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/panicking.rs:142:14
   2: core::result::unwrap_failed
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/result.rs:1785:5
   3: core::result::Result<T,E>::expect
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/result.rs:1064:23
   4: eframe::native::run::glow_integration::GlutinWindowContext::new
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:406:30
   5: eframe::native::run::glow_integration::GlowWinitApp::create_glutin_windowed_context
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:504:26
   6: eframe::native::run::glow_integration::GlowWinitApp::init_run_state
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:520:35
   7: <eframe::native::run::glow_integration::GlowWinitApp as eframe::native::run::WinitApp>::on_event
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:732:25
   8: eframe::native::run::run_and_return::{{closure}}
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:140:22
   9: winit::platform_impl::platform::sticky_exit_callback
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/mod.rs:849:9
  10: winit::platform_impl::platform::x11::EventLoop<T>::run_return::single_iteration
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/x11/mod.rs:339:17
  11: winit::platform_impl::platform::x11::EventLoop<T>::run_return
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/x11/mod.rs:448:31
  12: winit::platform_impl::platform::EventLoop<T>::run_return
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform_impl/linux/mod.rs:748:56
  13: <winit::event_loop::EventLoop<T> as winit::platform::run_return::EventLoopExtRunReturn>::run_return
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.5/src/platform/run_return.rs:62:9
  14: eframe::native::run::run_and_return
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:107:5
  15: eframe::native::run::glow_integration::run_glow::{{closure}}
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:851:17
  16: eframe::native::run::with_event_loop::{{closure}}
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:96:9
  17: std::thread::local::LocalKey<T>::try_with
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/thread/local.rs:445:16
  18: std::thread::local::LocalKey<T>::with
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/thread/local.rs:421:9
  19: eframe::native::run::with_event_loop
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:89:5
  20: eframe::native::run::glow_integration::run_glow
             at /home/mkrueger/work/egui/crates/eframe/src/native/run.rs:844:13
  21: eframe::run_native
             at /home/mkrueger/work/egui/crates/eframe/src/lib.rs:181:13
  22: icy_term::main::{{closure}}
             at ./src/main.rs:33:5
  23: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/future/mod.rs:91:19
  24: tokio::park::thread::CachedParkThread::block_on::{{closure}}
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/park/thread.rs:267:54
  25: tokio::coop::with_budget::{{closure}}
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:102:9
  26: std::thread::local::LocalKey<T>::try_with
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/thread/local.rs:445:16
  27: std::thread::local::LocalKey<T>::with
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/thread/local.rs:421:9
  28: tokio::coop::with_budget
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:95:5
  29: tokio::coop::budget
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/coop.rs:72:5
  30: tokio::park::thread::CachedParkThread::block_on
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/park/thread.rs:267:31
  31: tokio::runtime::enter::Enter::block_on
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/enter.rs:152:13
  32: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/scheduler/multi_thread/mod.rs:79:9
  33: tokio::runtime::Runtime::block_on
             at /home/mkrueger/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.2/src/runtime/mod.rs:492:44
  34: icy_term::main
             at ./src/main.rs:33:5
  35: core::ops::function::FnOnce::call_once
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/ops/function.rs:248:5


Placeholder at uri first level

Hi! Thank you for this awesome tool :)
I'm trying to build a mock server where the first part of the uri path (what would be the "group" directory in the folder structure) is a dynamic path param. Something like:
localhost:3001/{apiVersion}/somethingElse.
I changed the default urlPath to '' and then placed a directory named #apiVersion under rest. But that didn't work. I also tried using a group directory called # and in it the #apiVersion one, and finally tried putting the dynamic path param in the default urlPath, but that didn't work either.
Is it possible to do this? Can you help me out see what I'm missing?
Thank you again!

+1

Hi @anabella-spinelli-olx,
thanks for reporting this issue.
It's fixed with a7ab599.
Run npm install<EMAIL_ADDRESS>


fix: rename types.d.ts to types.ts

.d.ts files designed to be backed by .js files, using them just for type declaration can lead to type errors after the compilation

thanks @ttypic great catch


add fibonacci sequence using recursion

Description
add explanation and code for Fibonacci sequence generation using recursion method
Fixes #1574
Type of change

[X] Documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] New and existing unit tests pass locally with my changes
[X Any dependent changes have been merged and published in downstream modules

@ajay-dhangar

@ajay-dhangar please merge


[SPARK-17355] Workaround for HIVE-14684 / HiveResultSetMetaData.isSigned exception

What changes were proposed in this pull request?
Attempting to use Spark SQL's JDBC data source against the Hive ThriftServer results in a java.sql.SQLException: Method not supported exception from org.apache.hive.jdbc.HiveResultSetMetaData.isSigned. Here are two user reports of this issue:

https://stackoverflow.com/questions/34067686/spark-1-5-1-not-working-with-hive-jdbc-1-2-0
https://stackoverflow.com/questions/32195946/method-not-supported-in-spark

I have filed HIVE-14684 to attempt to fix this in Hive by implementing the isSigned method, but in the meantime / for compatibility with older JDBC drivers I think we should add special-case error handling to work around this bug.
This patch updates JDBCRDD's ResultSetMetadata to schema conversion to catch the "Method not supported" exception from Hive and return isSigned = true. I believe that this is safe because, as far as I know, Hive does not support unsigned numeric types.
How was this patch tested?
Tested manually against a Spark Thrift Server.

Test build #64761 has started for PR 14911 at commit 6b56880.

Test build #64761 has finished for PR 14911 at commit 6b56880.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64761/
Test PASSed.

LGTM

Alright, I'm going to merge this into master and branch-2.0.


Allow the gateways controller to be changed

Please provide a description of this PR:
This change makes the controller changeable.
Default is Deployment, but can be changed to DaemonSet.

Hi @nalbam. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalbam feel free to close this PR if you are going to work on it for the master branch.

Closing, feel free to reopen or discuss the issue I raised.

I'm very sorry.
I just read the previous message.
I re-created the PR.
https://github.com/istio/istio/pull/36638


Finetuning feature added for setting vision_lr and resampler_lr

feat: added fuction for creating each other optimizers to set vision_lr and resampler_lr
fix: resolve issue where saving was not functioning correctly
chore: update args with hyperparameters for improved fine-tuning performance

Setting different learning rates about vision_model and Language model shows a better performance.


You have issues...

1.) In the "play" case, you're setting the recipients' list of senders to an empty array after adding.
Chess.ts Line 97
2.) In the "revoke" case, you're using splice without providing the delete count.
Chess.ts Line 109

you did not need to name it like this 😭😭


next & graphql: Pass variable into graphql queries

Say you want your posts list page to link to an individual post? How would you render that on the server? How would you make the graphql call or would you use apolloClient? How? How can you get a server side variable into the option of the graphql()? Would you do it on a Page or a component?
// @flow
import { graphql } from 'react-apollo';

import Loading from './loading';
import nodeFull from './node-full.graphql';

const NodeFull = (props) => {
  return <pre>
    {JSON.stringify(props.data.route, null, 2)}
  </pre>;
}

export default graphql(nodeFull, (...fooo) => {
  return {
    options: {
      variables: {
        path: process.browser ? window.location.pathname : '/',// ???????????????????????
      },
    },
  }
})(NodeFull);

I have less then zero time to answer question. Sorry.


Cannot git check v0.10.0

Hi, the v0.10.0 seems have been deleted. So, I git check v0.10.0-support, but I cannot run the demo. Could you help me to solve it, please?

Ok, I have solved it. Just checkout the master branch. The master version has include the PSROIpooling. Another thing is that the line 1083 in resnet_v1_flownet_rfcn.py in wrong. You cannot use += for symbol variable. Just change into aggregated_conv_feat + tiled_weight * warp_list[i]. Then, it works.
Seems the new version MXNET change the rules for programing!

git checkout v0.10.0 worked here on ubuntu 16.04 without any issues


Is the trained model released for test?

Wonderful job! Is the model released ? Hope to see what does it lead to.

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

@Flash-321 Hi, thank you so much for this wonderful work! I wonder if you would be able provide a rough estimate of when the review process is likely to finish? I am really looking forward to the trained checkpoint and the huggingface space. Knowing roughly when they will be released will be very helpful for scheduling my work.
Many thanks.

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

@Flash-321 Hi, thank you so much for this wonderful work! I wonder if you would be able provide a rough estimate of when the review process is likely to finish? I am really looking forward to the trained checkpoint and the huggingface space. Knowing roughly when they will be released will be very helpful for scheduling my work. Many thanks.

Hi, thanks a lot for your attention. My sincere apologies for the late ckpt release. Last few weeks, Alibaba is undergoing a covid pandemic, and most of my colleges in charge of this thread caught a fever. Now it is quite close to Chinese new year, and I am regret that I cannot expect the time for ckpt release. btw, I also checked out from Alibaba, but I would inform my mentor about this situation and ask him to push forward the disclosure review process.

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

@Flash-321 Hi, thank you so much for this wonderful work! I wonder if you would be able provide a rough estimate of when the review process is likely to finish? I am really looking forward to the trained checkpoint and the huggingface space. Knowing roughly when they will be released will be very helpful for scheduling my work. Many thanks.

Hi, thanks a lot for your attention. My sincere apologies for the late ckpt release. Last few weeks, Alibaba is undergoing a covid pandemic, and most of my colleges in charge of this thread caught a fever. Now it is quite close to Chinese new year, and I am regret that I cannot expect the time for ckpt release. btw, I also checked out from Alibaba, but I would inform my mentor about this situation and ask him to push forward the disclosure review process.

btw, the gradio code prepared for demo is ready, I will host a space in huggingface for the demo asap after the review finished

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

@Flash-321 Hi, thank you so much for this wonderful work! I wonder if you would be able provide a rough estimate of when the review process is likely to finish? I am really looking forward to the trained checkpoint and the huggingface space. Knowing roughly when they will be released will be very helpful for scheduling my work. Many thanks.

Hi, thanks a lot for your attention. My sincere apologies for the late ckpt release. Last few weeks, Alibaba is undergoing a covid pandemic, and most of my colleges in charge of this thread caught a fever. Now it is quite close to Chinese new year, and I am regret that I cannot expect the time for ckpt release. btw, I also checked out from Alibaba, but I would inform my mentor about this situation and ask him to push forward the disclosure review process.

btw, the gradio code prepared for demo is ready, I will host a space in huggingface for the demo asap after the review finished

@Flash-321 Many thanks for your reply! Wish your colleges get well soon, and Happy Chinese New Year!

Yes, we have this plan, and we will prepare a huggingface space to host the checkpoint. The release is currently under internal review of Alibaba Group. After that, we will host it in huggingface ASAP.

@Flash-321 Hi, thank you so much for this wonderful work! I wonder if you would be able provide a rough estimate of when the review process is likely to finish? I am really looking forward to the trained checkpoint and the huggingface space. Knowing roughly when they will be released will be very helpful for scheduling my work. Many thanks.

Hi, thanks a lot for your attention. My sincere apologies for the late ckpt release. Last few weeks, Alibaba is undergoing a covid pandemic, and most of my colleges in charge of this thread caught a fever. Now it is quite close to Chinese new year, and I am regret that I cannot expect the time for ckpt release. btw, I also checked out from Alibaba, but I would inform my mentor about this situation and ask him to push forward the disclosure review process.

btw, the gradio code prepared for demo is ready, I will host a space in huggingface for the demo asap after the review finished

@Flash-321 Many thanks for your reply! Wish your colleges get well soon, and Happy Chinese New Year!

@MeixiChenTracy Thanks for your understanding. Happy Chinese New Year!

Hi,sorry for bothering. I am wondering the same question. : )

Sorry for bothering. I am looking forward to seeing your fantastic this model

你好！我对这个项目很感谢趣，请问现在已经在huggingface发布了相关demo吗？

Hi @xichenpan , I was wondering the same thing, Is the pre-trained model ready or huggingFace demo ready?

wonder too, is there any ckpt could use?


Field picker doesn't scroll to newly moved field

When I move a field from the full list to the selected list when the selected list has a scroll bar, the new field always shows up below the viewport and I have to scroll to display it so I can confirm it appeared or move it up in the list. It would be nice if the selected list automatically scrolled to display the newly-added item.

I think I can do this pretty easily. Might be a bit before I have some time to devote to all these improvements.

Initial version of this is implemented in v2.0.3. I'm not super happy with some of the behavior but I'm a perfectionist. It should be fine for most users.


Closing bank interface to fast

Tracker registers the items as new if the items show up in inventory after the bank interfaces closes.

+1 Same issue, if you are skilling it will count items pulled out of the bank as profit.

I don't know if there's a better solution, but delaying the profit tracker by 1 game tick after the bank interface is closed should completely fix this issue.


[torchlib] Implement aten::prelu

Is there a reason we don't use ONNX PRelu? https://github.com/onnx/onnx/blob/main/docs/Operators.md#PRelu

I didn't know it existed. I will update.


Update gitignore

I updated the gitignore to be based on other Godot gitignores. The existing file was missing a few things and also *.import should not be ignored because those files store import things.

i thought godot would generate the import files for you


Add .pyi files for CP-SAT to enable autocompletion

So I generated some stub files using https://github.com/dropbox/mypy-protobuf.
This allows some IDEs such as PyCharm to autocomplete and infere types:

Want this added to the protoc flow?

Actually, the right thing to do instead of adding these files would be:

pip install mypy-protobuf
use protoc with --mypy_out= option

Thanks, I will have a look.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mar. 3 sept. 2019 à 22:54, Xiang Chen<EMAIL_ADDRESS>a
écrit :

Actually, the right thing to do instead of adding these files would be:

pip install mypy-protobuf
use protoc with --mypy_out= option

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/1544?email_source=notifications&email_token=ACUPL3IMG37I5SRWV4C7ZMTQH3FHXA5CNFSM4ITKWPN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZRJHA#issuecomment-527635612,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3MFY3QPN6T5HNHVKILQH3FHXANCNFSM4ITKWPNQ
.

Should be doable in CMake

Actually, the right thing to do instead of adding these files would be:

pip install mypy-protobuf
should be done like this:
https://github.com/google/or-tools/blob/84c35244c9bdd635609af703bbf3053c16c487c0/cmake/python.cmake#L133
replacing wheel by mypy-protobuf
use protoc with --mypy_out= option
add it there:
https://github.com/google/or-tools/blob/84c35244c9bdd635609af703bbf3053c16c487c0/cmake/python.cmake#L50-L54


[html] base not respected

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

auto-close-tag
formulahendry
0.4.2

html-tag-wrapper
hwencc
0.1.5

vscode-JS-CSS-HTML-formatter
lonefy
0.2.3

font-awesome-codes-html
medzhidov
0.0.7

theme-oceandeep
pierrenel
0.0.1

view-in-browser
qinjia
0.0.5

I created an HTML file.  In the head element I put a  element (as per https://developer.mozilla.org/en/docs/Web/HTML/Element/base ), much like this:
<base href="..">
(This is a relative link on purpose)
Elsewhere, in the body, I put a hyperlink like this:
other doc
When I hold down control and click on the 'other doc' link VS code it attempts to open the OtherDoc.html in the same directory that my HTML page is in (i.e., it attempt to open it like any other file).
It would be awesome if VSCode instead tried to open ../OtherDoc.html (i.e., it opened the file the same way the web browser will open the file).

Reproduced with
<base href="..">
other doc

Note, it works with


Investigate OnChargeTransactionPayment

In order for users to self-relay, they'll need to be able to pay fees in the destination chain. We should design an implementation of OnChargeTransactionPayment that charges transaction fees after ismp requests have been executed (and the user's balance successfully updated).
This way, users can self relay requests that will fund their account with the destination chain's fee token.

Not critical to our current roadmap.


add travis badge

you're also going to need to enable travis for this repo, but that should be easy because there's already a .travis.yml

This should really be on the Readme.md. I had to fork the repo and run the tests manually to see which tests were failing.

Closing - don't believe we use any type of CI too. Merge Conflicts.


NSDate+SAMAdditions __stack_chk_fail in strptime

Hi,
I'm using this library and I have same problems, that i could not see what could it be.
The problem is when using
NSDate+SAMAdditions to parse iso8601 using the function
+(NSDate *)sam_dateFromISO8601String:(NSString *)iso8601;
I have a __stack_chk_fail when it try to use strptime at line 81.
I used this date to parse "2015-03-26T18:08:22.388461"
Regards
Juan

Use ISO8601 instead

Ok, I thought that could parse any similar type!
thanks


Local checksums strategy

follows from #407. Decided to open a separate discussion because the topic is controversial.
To summarize:

I added per-file checksums to local DB cache.
So abapGit can compare checksum to remote sha1 and local sha1 independently and see what was changed and where.
Now checksums contain both per-file sha1 and whole object sha1
push/pull can be partial ! so checksumming all local files on update does not work. Only actually pushed/pulled files must be updated

Questions ( @larshp ):

Do we need whole object checksums at all ? What value do they bring ? This is tricky to update them in case of partial push (actually no possible). I'd suggest dropping them
How this change should be delivered to current users? What I mean. Let's say a user have a repo in a dirty state. Force calculating checksums will save actual current state so the local changes will be ignored in status display and can lead to confusion. I'm a bit out of ideas here. Somehow the checksum update must happen first just for clean repo.

1: no, I do not think so, just drop it :smile:
2: hmm, I think we should avoid making a lot of code to handle this upgrade, and just take the risk that some users might run into some issues. I'd say we prioritize moving ahead to a better solution, over fixing every scenario for all users.

1: 👍
2: Generally agree. I'll think how to mitigate the issues in minimem of code ... maybe some warning message ...
BTW: I think i could be a good idea to publish some release notes/ changelog ... maybe to announce issues like this, definitely to announce new features, another option is to actually open this change log on the first run of abapGit. E.g. store "last shown announcement" version and if current abapGit is higher the download change log and show it to user. Just thoughts ...

release notes: probably a good idea, but it is just more work, which means less code :wink: it should be first run after upgrade, per user?

But more clear for users ! Which is good ! :) UX is important :P
Well, I'll write some release notes just as MD file then. Automatic display of changes ... maybe ... somewhen later (for sure after external assets idea).
For the local check some refresh I've put the warning below. And maybe some autorun if no file checksums found for repo. I guess the logic (read below) should be OK - unsynced repo with remote and local updates at the same time should be rare enough.
'This will rebuild and overwrite local file checksums.'
' The logic: if local and remote file differs then:'
' if remote branch is ahead then assume changes are remote,'
' else (branches are equal) assume changes are local.'
' This will lead to incorrect state for files changed on both sides.'
' Please make sure you don't have ones like that.'

Closing. changes wil be commited as a part of 407


zenfs: better collaborative GC & better metrics

This MR contains FOUR major changes, most of the changes are not related to the ext4 code path:

Commit 1: enhancement ZNS GC
Authored by @levisonchen and @yapple, directed by @mm304321141

Add weighted hints for TerarkDB to pick compaction files smarter
TerarkDB could get zenfs's snapshot to understand which files are placed in the zone with the most garbage

Commit 2: Add Support for Official ZenFS
Authored by<EMAIL_ADDRESS>directed by @royguo

Switch zenfs from bytedance/bzbd to wdc/zenfs
Add decoupled metrics tracking metrics

Commit 3: fixed a bug in GetStat

Minor changes

Commit 4: zenfs: optimize collaborative GC & metrics API
Authored by @royguo

Update ZenFS to the latest version
Refine metrics framework
Add better collaborative GC implement (with zenfs extent migration support)

Could you please update the MR description with a brief summary of the objective, high-level design and implementation strategy? This would greatly help readers understand and evaluate this MR. Thanks!

Could you please update the MR description with a brief summary of the objective, high-level design and implementation strategy? This would greatly help readers understand and evaluate this MR. Thanks!

I just saw that each individual commit actually has a nice description, so maybe just summarize the list of changes here in the MR description.
Also, is it possible to merge the commits one-by-one?

LGTM


Fix up .NET method invocation with Optional arg

PR Summary
Fix .NET method invocation with an argument that has an [Optional] attribute but no default value.
Fixes: https://github.com/PowerShell/PowerShell/issues/21372
PR Context
While not common .NET has the ability to set an optional argument but no explicit value https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments#optional-arguments

You can also declare optional parameters by using the .NET OptionalAttribute class. OptionalAttribute parameters do not require a default value. However, if a default value is desired, take a look at DefaultParameterValueAttribute class.

The docs for F# even recommend this attribute when it comes to F# assemblies that could be used in C# and other .NET languages https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/parameters-and-arguments#optional-parameters

For the purposes of C# and Visual Basic interop you can use the attributes [<Optional; DefaultParameterValue<(...)>] in F#, so that callers will see an argument as optional. This is equivalent to defining the argument as optional in C# as in MyMethod(int i = 3).

When it comes to the compiled assembly the ParameterInfo.DefaultValue for an argument with only [Optional] is System.Reflection.Missing but this value cannot be passed as an argument unless the type is object because it cannot be casted to the argument type. Instead using null or the default value for that type should be used.
This is a good candidate to backport.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Thanks for the review @iSazonov

The Engine WG discussed this and agree with the change and it is ready to be reviewed

This is a new feature and hence does not meet the bar for backport. It is also in a fairly risky area.


Problem when using accent with puffader running.

Problem when using accent with puffader running.
When I initialize the puffader, the graphical accent no longer works correctly in any text editor, microsoft-word, notepad, etc ...
When I try to use the "ã" or "á" accent, any accent on the letters does not work. It is displayed only in the "~~" or "´´" or "^^" format.
This problem occurs both in the puffader and in the keylogger module of the python-backdoor project.

In the log file, the word is stored correctly, however in the text editor it does not.
In countries that use accentuation in writing, the puffader would not do well, since the system administrator would realize this problem that the user would report, and would certainly do a reinstallation of the operating system in order to solve this problem, eliminating the puffader.

This is probably because of the PyHook module that I use and there is really nothing I can do about it.


Simply dont work

Try execute the RemotePlayWhatever.exe as administrator, the steam, move in diferences directories, but not work in non-steam games. Steam detect the game but the remote invite dont show in steam
What should I do?

Are you in steam client beta?

Are you in steam client beta?

Ohhh yes, its true, I've disable beta, and reinstall normal steam.
Now it works!!! Thank you very much
Problem Solved!


weird issue with dep optimisation

I came across this while migrating a project from Astro,
I imagine that it comes from Vite trying to optimise deps, but I'm not sure
https://github.com/Typeform/embed/tree/main/packages/embed-react
only works in dev mode
import { SliderButton } from "@typeform/embed-react";

only works at build time
import typeform from "@typeform/embed-react";
const { SliderButton } = typeform

works at build time and dev mod
import * as typeFrom from "@typeform/embed-react";
const { SliderButton } = typeFrom.default ?? typeFrom

error sample:
[vite-plugin-capri-main] Named export 'SliderButton' not found. The requested module '@typeform/embed-react' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@typeform/embed-react';
const { SliderButton } = pkg;

error during build:
file:///home/lordie/Projects/nano/mono/my-capri-site/dist/ssr.js:10
import { SliderButton } from "@typeform/embed-react";
         ^^^^^^^^^^^^
SyntaxError: Named export 'SliderButton' not found. The requested module '@typeform/embed-react' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@typeform/embed-react';
const { SliderButton } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
 ELIFECYCLE  Command failed with exit code 1.

One way to fix this is by adding the following to your vite.config.ts:
ssr: {
  noExternal: "@typeform/embed-react",
}

Another possible solution could be to play with build.rollupOptions.defaultIsModuleExports but I haven't tried this yet.


View grades

First Commit:
- Initial implementation of view grades feature - Fixes #1
Second Commit:
- Bug fix and improvement for view grades feature - Fixes #1

Looks good! I would add more student examples


Am 335 Fully-validate connection parameters on save

Validation happens whenever the the object is instantiated. There is is a method that allows an object to be constructed without any validation, but it's all or nothing. If we turn off validation when marshalling objects from JSON I think we run the risk of hiding errors in the code the might have been exposed if an error was raised when handling data that is actually valid.

Validation happens whenever the the object is instantiated. There is is a method that allows an object to be constructed without any validation, but it's all or nothing. If we turn off validation when marshalling objects from JSON I think we run the risk of hiding errors in the code the might have been exposed if an error was raised when handling data that is actually valid.

Yeah, I don't want to switch of validation entirely. I'm more thinking there are levels of validation:

Is the JSON well-formed (always on)
Is the minimal information in the JSON for us to parse it, e.g. sufficient info to tell us whether it's an asset vs some other object (always on)

Contrasted with:

Is the information in the JSON correct (only for requests a user creates and wants to POST, not used for anything we GET back)

This is akin to the idea of an attribute being "required" or not — answering this question really depends on the context:

Very few attributes are required in a response (for assets, only a typeName and guid)
Other attributes are required for update requests (i.e. qualifiedName and name)
Still more attributes are required for requests to create an asset (i.e. qualifiedName, name, and qualifiedName or guid (+ typeName) of the asset in which the asset-to-create will be contained)

^^ Just like there isn't a simple all-or-nothing "required" for attributes, I don't think we should have a simple all-or-nothing "validated" for payloads — we need to vary the validation based on the context (in particular request vs response).
If Pydantic can't handle the contextual validation, then we should only implement the minimal "always-on" validation via Pydantic, and move the contextual validation out into other methods (e.g. just before invoking _call_api, in the worst case).


JBIDE-18692: Create ripple artifact

@mickaelistria  thanks! rebased and pushed into 'cordovasim' branch


Issue in running installed global package's cli

Facing an issue with installing gitcommitshow/open-community-kit globally. The install command runs successfully but its cli cannot be accessed from the terminal
Operating system and version:
nvm debug output:

nvm --version: v0.35.3
$TERM_PROGRAM: Apple_Terminal
$SHELL: /bin/bash
$SHLVL: 1
${NVM_DIR}: '${HOME}/.nvm'
${PATH}<EMAIL_ADDRESS>$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)'
uname -a: 'Darwin 19.6.0 Darwin Kernel Version 19.6.0: Mon Apr 18 21:50:40 PDT 2022; root:xnu-6153.141.62~1/RELEASE_X86_64 x86_64'
OS version: Mac 10.15.7 19H1922
curl: /usr/bin/curl, curl 7.64.1 (x86_64-apple-darwin19.0) libcurl/7.64.1 (SecureTransport) LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.39.2
sed: /usr/bin/sed
cut: /usr/bin/cut
basename: /usr/bin/basename
rm: /bin/rm
mkdir: /bin/mkdir
xargs: /usr/bin/xargs
git: /usr/local/bin/git, git version 2.30.1
grep: /usr/bin/grep, grep (BSD grep) 2.5.1-FreeBSD
awk: /usr/bin/awk, awk version 20070501
nvm current: v14.20.0
which node: ${NVM_DIR}/versions/node/v14.20.0/bin/node
which iojs:
which npm: ${NVM_DIR}/versions/node/v14.20.0/bin/npm
npm config get prefix: ${NVM_DIR}/versions/node/v12.18.3
npm root -g: ${NVM_DIR}/versions/node/v12.18.3/lib/node_modules

nvm ls output:

         v4.9.1
        v8.17.0
       v12.18.0
       v12.18.3
      v12.22.12
->     v14.20.0
       v16.17.0
         system
default -> v14 (-> v14.20.0)
node -> stable (-> v16.17.0) (default)
stable -> 16.17 (-> v16.17.0) (default)
iojs -> N/A (default)
unstable -> N/A (default)
lts/* -> lts/gallium (-> v16.17.0)
lts/argon -> v4.9.1
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.12
lts/fermium -> v14.20.0
lts/gallium -> v16.17.0

How did you install nvm?
Install script in readme
What steps did you perform?

npm install -g open-community-kit
open-community-kit mozilla

What happened?

-bash: open-community-kit: command not found

What did you expect to happen?
The command should have run
Is there anything in any of your profile files that modifies the PATH?
Didn't make any changes in path explicitely except for what was suggested in nvm readme.

The issue is that you're using node 14, but npm root -g points to a node 12. Have you perhaps defined prefix in ~/.npmrc or your project's .npmrc?

I see. It's weird. I do see some entries in ~/.npmrc
prefix=${NVM_DIR}/versions/node/v12.18.3
@OWNER:registry=https://npm.pkg.github.com/
//npm.pkg.github.com/:_authToken=secret
@gitcommitshow:registry=https://npm.pkg.github.com/
//registry.npmjs.org/:_authToken=secret

This seems to be probably done during npm package publishing.
Is it expected? What is the cleanest way to fix this?

That prefix entry must be removed and shouldn't ever have been there in the first place. Remove that, and you'll be fine.

thanks. this works. will figure out how to work with npm packages now.


[e2e]: container tag main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v28.0.221
Run: https://github.com/slsa-framework/example-package/actions/runs/6885856965
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.tag.main.default.slsa3.yml
Trigger: push
Branch: v28.0.221
Date: Thu Nov 16 03:15:17 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v28.0.222
Run: https://github.com/slsa-framework/example-package/actions/runs/6899412178
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.tag.main.default.slsa3.yml
Trigger: push
Branch: v28.0.222
Date: Fri Nov 17 03:17:54 UTC 2023
Tests are passing now. Closing this issue.


fix(ts): allow followerQuery & followeeQuery to support subclass of AV.User

Please test, thanks.

Codecov Report

Merging #565 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   68.86%   68.86%
=======================================
  Files          37       37
  Lines        3202     3202
=======================================
  Hits         2205     2205
  Misses        997      997

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b47007...ef57bb8. Read the comment docs.

似乎目前实现上，followerQuery 与 followeeQuery 始终会返回 Query<AV.User>。


Network Manager

Network Manager is not started by default, but has an applet in the Cinnamon tray. This causes Cinnamon to think it does not have a network connection. A purely cosmetic issue. Should either remove the nm applet or start Network Manager by default.

Starting networkmanager is not an option as this would lead to two daemons that manage DHCP.  I recommend tolerating this as a cosmetic bug until upstream can fix the issue.


use schema version 2 as the default way to Manifest and remove Manife…

[…st2]func,fix issue     #24

tag layer size

I second this request - I figured out today that digests have different properties in v1 and v2 - in v1, digests are unique per tag, while in v2 several tags can share the same digest. At the moment, it's simply impossible to retrieve the v2 digest through this client.


DRILL-8071: upgrade log4j to 2.17.1

DRILL-8071: upgrade log4j to 2.17.1
Description
Drill's format-excel has only gained log4j dependencies recently (and this is not in any Drill release yet).
Log4J have released 2.17.1 with another CVE fix. These CVEs don't affect Drill because it does not yet use log4j-core but for optics, it is better to update all log4j jars.
https://logging.apache.org/log4j/2.x/security.html
Documentation
No changes
Testing
Unit tests

Before that, there was an issue that the Travis CI was frozen :
We are unable to start your build at this time.
You exceeded the number of users allowed for your plan. Please review your plan details and follow the steps to resolution.

I have contacted their tech support today and they seem to have solved the issue for us.


Add PrintHelp function which outputs help with an OptCfg array

Add .Desc field to OptCfg to specify a description of an option.
Add PrintHelp function which takes  a command name and a OptCfg array as arguments and prints a help document with them to stdin.

Adjust terminal's column size with GetSize in golang.org/x/term.
A rune width can presume with LookupRune and Properties#Kind in golang.org/x/text/width.

PrintHelp is implemented in https://github.com/sttk-go/cliargs/pull/9.
Closed.


[BUG]  Compute Sanitizer reports errors for the TableTest#testORCReadAndWriteForDecimal128 test

This test is excluded temporarily in PR https://github.com/rapidsai/cudf/pull/13872.
Error stack from the Compute Sanitizer.
========= COMPUTE-SANITIZER
========= Program hit cudaErrorInvalidConfiguration (error 9) due to "invalid configuration argument" on CUDA API call to cudaLaunchKernel_ptsz.
=========     Saved host backtrace up to driver entry point at error
=========     Host Frame: [0x4545f6]
=========                in /usr/lib64/libcuda.so.1
=========     Host Frame: [0x3199c48]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:__device_stub__ZN4cudf2io3orc3gpu27rowgroup_char_counts_kernelENS_6detail11base_2dspanIiNS_11device_spanEEENS5_IKNS1_22orc_column_device_viewELm18446744073709551615EEENS4_IKNS1_13rowgroup_rowsES5_EENS5_IKjLm18446744073709551615EEE(cudf::detail::base_2dspan<int, cudf::device_span>&, cudf::device_span<cudf::io::orc::orc_column_device_view const,<PHONE_NUMBER>3709551615ul>&, cudf::detail::base_2dspan<cudf::io::orc::rowgroup_rows const, cudf::device_span>&, cudf::device_span<unsigned int const,<PHONE_NUMBER>3709551615ul>&) [0x1a94474]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::orc::gpu::rowgroup_char_counts_kernel(cudf::detail::base_2dspan<int, cudf::device_span>, cudf::device_span<cudf::io::orc::orc_column_device_view const,<PHONE_NUMBER>3709551615ul>, cudf::detail::base_2dspan<cudf::io::orc::rowgroup_rows const, cudf::device_span>, cudf::device_span<unsigned int const,<PHONE_NUMBER>3709551615ul>) [0x1a944ae]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::(anonymous namespace)::set_rowgroup_char_counts(cudf::io::detail::orc::orc_table_view&, cudf::detail::base_2dspan<cudf::io::orc::rowgroup_rows const, cudf::device_span>, rmm::cuda_stream_view) [0x1ac2c21]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::(anonymous namespace)::convert_table_to_orc_data(cudf::table_view const&, cudf::io::table_input_metadata const&, cudf::io::detail::orc::stripe_size_limits, int, bool, cudf::io::orc::CompressionKind, unsigned long, cudf::io::statistics_freq, bool, cudf::io::detail::single_write_mode, cudf::io::data_sink const&, rmm::cuda_stream_view) [0x1ad1657]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::writer::impl::write(cudf::table_view const&) [0x1ad2b30]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::orc_chunked_writer::write(cudf::table_view const&) [0x1a0adc9]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:Java_ai_rapids_cudf_Table_writeORCChunk [0x120e73e]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame: [0xffffffffe6e20b26]
=========                in
=========
========= Program hit cudaErrorInvalidConfiguration (error 9) due to "invalid configuration argument" on CUDA API call to cudaGetLastError.
=========     Saved host backtrace up to driver entry point at error
=========     Host Frame: [0x4545f6]
=========                in /usr/lib64/libcuda.so.1
=========     Host Frame: [0x3193c14]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cub::CUB_101702_600_700_750_800_860_900_NS::PtxVersion(int&) [0x112da6d]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::(anonymous namespace)::decimal_chunk_sizes(cudf::io::detail::orc::orc_table_view&, cudf::io::detail::orc::file_segmentation const&, rmm::cuda_stream_view) [0x1ac601a]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::(anonymous namespace)::convert_table_to_orc_data(cudf::table_view const&, cudf::io::table_input_metadata const&, cudf::io::detail::orc::stripe_size_limits, int, bool, cudf::io::orc::CompressionKind, unsigned long, cudf::io::statistics_freq, bool, cudf::io::detail::single_write_mode, cudf::io::data_sink const&, rmm::cuda_stream_view) [0x1ad16d7]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::detail::orc::writer::impl::write(cudf::table_view const&) [0x1ad2b30]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:cudf::io::orc_chunked_writer::write(cudf::table_view const&) [0x1a0adc9]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame:Java_ai_rapids_cudf_Table_writeORCChunk [0x120e73e]
=========                in /tmp/cudf1642589926955139763.so
=========     Host Frame: [0xffffffffe6e20b26]
=========                in
=========
========= ERROR SUMMARY: 2 errors

Repro steps:
1 Apply the two PRs, https://github.com/rapidsai/cudf/pull/13872 and https://github.com/NVIDIA/spark-rapids-jni/pull/1321
2 Remove the noSanitizer tag from this test. And run ./build/build-in-docker test -Dtest=TableTest -DUSE_SANITIZER=ON.

I will double confirm this after the quite long time cudf build finishes.

I reproduced the issue.
From the stack, it shows the cudaErrorInvalidConfiguration is from cuDF side.
I found the y dimension of dim3 is zero, details:
https://github.com/rapidsai/cudf/blob/v23.08.00/cpp/src/io/orc/dict_enc.cu#L68-L70
  auto const grid_size =
    dim3(cudf::util::div_rounding_up_unsafe<unsigned int>(num_rowgroups, block_size),
         static_cast<unsigned int>(num_str_cols));

grid_size.y is 0 when I print it out. This means the num_str_cols is zero.
From ChatGPT: Each dimension (x, y, and z) in dim3 must have a value greater than zero.
@jlowe  Help confirm. It's a cuDF bug, I'll post an issue.

Yes, I believe the dimensions are supposed to be greater than zero.  If this is an illegal launch configuration, why do we only see a CUDA error when running under the sanitizer?  I would expect the driver to return an error when trying to launch a kernel with an invalid launch config.  Or does it treat it as a no-op instead?

Depends on cuDF issue: https://github.com/rapidsai/cudf/issues/13887

Seem cuDf has fixed the issue, @res-life can you verify again.

cuDF PR: https://github.com/rapidsai/cudf/pull/14897

Retarget this issue to 24.04, because the cuDF branch 24.02 is locked.


Suggestions box's first choice is sometimes selected, sometimes NOT

Type: Bug
Since last update, auto-completion is completely broken.
As I type a few characters, the suggestions box appears, but more ofter than not (and contrary to expectation), none of the box's proposals is selected : I have to press the down arrow to select the 1st line!
Consequence:
if I don't pay attention to whether the first choice is pre-selected, I hit ENTER if the first result looks like it's what I want to insert, but since nothing was actually selected, this creates a new line instead... This is probably a bug because this is a terrible UX.
Aside from that, thank you so much for your hard work, VS Code is such a outstanding product!

Before 1.75.0 it autofocuses on the suggestions we just need to use Arrow keys for the desired one but now it is not auto focusing and if we press any Arrow key the cursor just shifts to the above or below line hiding the dropdown suggestions.

Check this new setting:
Editor > Suggest: Selection Mode

Is that set to always?

Yes it is set to always

Related #173343.
I've also checked that option and it is also always, but the first choice is still not always selected.

Does this occur when invoking a completion when just having accepted one, esp. a snippet completion? Do you have the editor.suggest.snippetsPreventQuickSuggestions setting configured?

Does this occur when invoking a completion when just having accepted one, esp. a snippet completion? Do you have the editor.suggest.snippetsPreventQuickSuggestions setting configured?

Yes it is set to true but still same problem sometimes working sometimes not!

I think the real problem here is that the suggestion box is showing up when using snippets with editor.suggest.snippetsPreventQuickSuggestions set to true (which is the default). It should only show up when it is set to false.
I've done some testing using Windows Sandbox with versions 1.74.3 and 1.75.0. With "editor.suggest.snippetsPreventQuickSuggestions": false, the first option is selected in both versions. With "editor.suggest.snippetsPreventQuickSuggestions": true (or unset), in 1.74.3 the box doesn't show while in 1.75.0 it shows up with the first option not selected.
You can see both behaviors in the following videos:

1.74.3
https://user-images.githubusercontent.com/7624090/217130517-fd54477f-f72a-40fc-9ac9-9a86ccecdd08.mp4

1.75.0
https://user-images.githubusercontent.com/7624090/217130552-e16884d4-3cf8-4de0-8786-0bc3ea4b2fb8.mp4

in 1.74.3 the box doesn't show while in 1.75.0 it shows up with the first option not selected.

That change was done on purpose but it wasn't clearly communicated. In the past we would truly suppress Intellisense when in snippet mode. Over the last years this has caused much confusion and heated debates because people believe IntelliSense is broken. The underlying conflict is that both (snippets and suggest) use Tab to either advance to next placeholder or accept a completion. They are mutually exclusive and one is given precedence making folks believe things are broken.
Since IntelliSense has the new "no select" mode I figured it is a good compromise to use that instead of suppressing suggest. Wrt muscle memory nothing should have changed, pressing Tab still goes to the next snippet placeholder but wrt the UI are now seeing the suggest widget (as ambient offering)

/cc @waynebloss

I am not sure what the correct workaround should be, but I think that things started working again when I set snippetsPreventQuickSuggestions to false.
I searched around for a "no select" Intellisense setting but I couldn't find one. (Is this a reference to editor.suggest.selectionMode and setting it to never?)
Basically, I guess I just want it to work the way that it always had worked: Whether I'm using a snippet or not, when I see the autocomplete/intellisense popup list the first item should always be highlighted and when I press Tab, it completes the selected item and moves to the next snippet placeholder if in snippet mode...
Thanks!

Is there any way to revert to the previous mode since it was done "on purpose"?
Personally, I find the new way extremely annoying (and given that it always was this way, I think it should default to the way it always was and an option could turn on the new option which doesn't select completions even though they're being shown).

As a note, it seems that setting "editor.suggest.snippetsPreventQuickSuggestions": false does improve it for me (at least when a completion is shown it can be applied).
But now I'm confused... when "editor.suggest.snippetsPreventQuickSuggestions": true, the completions are actually being shown but without marking a completion item as the selected item (so, it doesn't prevent quick suggestions, it makes it so that it shows it but requires the user to use Ctrl+Space again to focus it, which is not good IMHO -- definitely not good as a default, and that seems to be the bug here... in 1.74.3 the completions wouldn't be shown in that case, so, there was no confusion, the new way of handling  "editor.suggest.snippetsPreventQuickSuggestions": true to show completions but not select it is very confusing).
Maybe it'd be better if it'd be controlled by something as:
"editor.suggest.onSnippetMode": "showCompletionsButDontSelect" (current behavior -- seems strange to me... maybe it could be there but not default)
"editor.suggest.onSnippetMode": "dontShowCompletions" (old behavior -- maybe not ideal, as users think completions don't work but is reasonable for those preferring placeholders over completions?)
"editor.suggest.onSnippetMode": "showCompletionsAndApplyOnTabAndEnter" (old behavior when "editor.suggest.snippetsPreventQuickSuggestions": false was active -- it can backfire because pressing tab wouldn't go to the next snippet and would apply the completion, but maybe that'd be a better default as there wouldn't be a confusion that code-completion isn't working).
"editor.suggest.onSnippetMode": "showCompletionsAndApplyOnEnter" (I guess that'd be the ideal setting for me -- as I use enter to apply completions and not tab, but for users using tab to apply completions I don't really see a way out anyways as the conflict is there by design).
I understand there's a conflict that needs to be solved where tab can be used both to apply a completion and go to the next placeholder and that maybe a setting can help there, but showing a completion and not letting it be applied makes it confusing IMHO and shouldn't be the default.

I updated the vscode and I think it is fixed now!! in v.1.75.1

@jrieken note that there is no conflict when a user uses tab to go to the next placeholder and enter to apply a completion (so, if the completions are there I'd definitely expect enter to apply it and tab to go to the next placeholder...).

editor.suggest.snippetsPreventQuickSuggestions : false

This setting fixed the issue for me, big thanks.
At this point I think is pretty hard to not press Enter when the suggestion widget shows up. That Enter almost press itself.

I was OOF and this slipped a little bit. For February I will push a new command focusAndAcceptSuggestion that focuses and accepts a suggestion (https://github.com/microsoft/vscode/pull/174856). By default it will not have a keybinding but you can add one like this (keybindings.json)
// Place your key bindings in this file to override the defaults
[
    {
        "command": "focusAndAcceptSuggestion",
        "when": "editorTextFocus && suggestWidgetVisible && !suggestWidgetHasFocusedSuggestion",
        "key": "Enter"
    }
]

@jrieken Thank you for updating this. Could you please provide some additional info on what this new command will do? How did the suggestion system work before this command? The issue described here has only been happening for the last few weeks.

@michaeldaw See https://github.com/microsoft/vscode/issues/173387#issuecomment-1420405130

Just curious if there's any ETA on this - the best thing about VS Code (great intellisense experience) has been broken for me. Here's what I'm experiencing now whenever I try to import a package.
As you can see, when I press TAB to try and complete the package name and jump to the next snippet spot - it doesn't complete the package name.
https://user-images.githubusercontent.com/623736/224780749-a9d4acbb-65ef-4cc7-9bca-2b4f7e07d92d.mp4

OK, setting "editor.suggest.snippetsPreventQuickSuggestions": false, fixed it for me. I thought I had already had that set but it was actually only being applied to the "[Dart]" section.

This change really broke the user experience, I love VSCode but every few minutes I face that bug as I'm trying to use autocomplete instinctively and an empty line appear or no completion happen (I honestly don't know if I should use the down arrow, tab or enter). It made the whole autocomplete very unpredictable and therefore a impossible to use without having to think about it. I find myself more and more often resorting to typing the whole word as it's faster than undoing the result of autocomplete. I don't want to romanticize coding too much but typing code is an action that happens in a state of flow, and this simply breaks it

I haven't had any issues ever since I set editor.suggest.snippetsPreventQuickSuggestions to false. But I'm not sure why this isn't the default.

I haven't had any issues ever since I set editor.suggest.snippetsPreventQuickSuggestions to false. But I'm not sure why this isn't the default.

The problem with setting that to false is that you cannot use tab anymore.
The idea is that in the snippet mode, you would be able to select the suggestions with enter AND jump to the next placeholder by pressing enter. The Golang extension provides this correct behavior. But when I switch to TS or Rust or python (python has actually getting really bad), the illogical behavior really bothers me and haven't been able to get used to it.
I believe it was the behavior until it was changed in 1.74 or 1.75.

I am not sure the answers in here sufficiently capture the problem that the original author describes.
Replies seem to suggest that editor.suggest.snippetsPreventQuickSuggestions is the culprit. But what I am seeing, and I would guess from reading the original post, is that it is intermittent.
E.g. I just tried typing this:

Notice how parsedModels is not selected.
I then press backspace to remove the p. Then the first option gets selected:

Is this not a bug?

Next 1.79-insiders will contain a fix/change for this.
I have removed the editor.suggest.snippetsPreventQuickSuggestions  setting and I have removed the "open suggest but not focus it" behaviour. Instead keybindings are contextual, e.g Tab will NOT accept a completion when in snippet mode but Enter needs to be used.
Again, this will be 1.79-insiders first (http://code.visualstudio.com/insiders/), not in next 1.78-stable that we are shipping today

When you make stable release?

When you make stable release?

This will ship early June

In 1.79-insiders, this problem still occurs.
If 'snippet mode' means being in the middle of filling out a snippet, then this still happens when not in snippet mode.
Occasionally (frustratingly, not always), the completion window is not focused when it pops up and so pressing tab inserts an indent instead of selecting the first item in the completion list. If I then delete a few characters and try again, then this second time the first item in the completion list will then be selected and pressing tab inserts the completion as expected.

This is what is happening for me in 1.79-insiders:
https://github.com/microsoft/vscode/assets/8949148/005a0738-c255-4ca0-a5a5-6c759856a33d

I just read this comment in #183411

Frankly, I find that remark inflammatory.
I've been using various IDE's for nearly 20 years. You can always use TAB to confirm a completion suggestion. Always. Whatever the original intent of this change was, it is an unmitigated failure. Restore the original functionality.

As someone from the "Team Tab" I second @michaeldaw's comment.
As a matter of fact, editor.suggest.snippetsPreventQuickSuggestions being true by default has already caused confusion for people like me and I have been using VSCode with this value set to false since I'm aware of this option exactly in order to use Tab completions in snippets.
Personally I don't mind jumping to another completion point using other shortcuts.
Better yet, maybe the hot key for jumping to the next completion point should be customizable... I wonder if this will be difficult to change.

To verify

ensure the snippetsPreventQuickSuggestions setting is back and its default is false
ensure typing inside a placeholder of a snippet shows suggestions, ensure TAB accepts it
ensure ESC dismisses suggestion and that snippet mode stays on (until hitting ESC again)

turn snippetsPreventQuickSuggestions to true and ensure typing in a snippet placeholder doesn't trigger quick suggestions

Does not work for me:


Unable to connect to bitcoind RPC on port 8332 from LAN

Trying to achieve to be able to communicate with my bitcoind with RPC, but not able.
Anyone succeded to do this on a RaspiBlitz? I have tried two nodes running 1.3RC2 and 1.3RC5 so far.
bitcoin.conf was modified to:
sudo cat /mnt/hdd/bitcoin/bitcoin.conf
# bitcoind configuration

# mainnet/testnet
testnet=0

# Bitcoind options
server=1
daemon=1
txindex=1
# disablewallet=1
listen=1

# Connection settings
rpcuser=raspibolt
rpcpassword=xxxxxxx
rpcport=8332

rpcallowip=<IP_ADDRESS>/0
rpcallowip=<IP_ADDRESS>
# rpcallowip=<IP_ADDRESS>
# rpcbind=<IP_ADDRESS>:8332
zmqpubrawblock=tcp://<IP_ADDRESS>:28332
zmqpubrawtx=tcp://<IP_ADDRESS>:28333

# Raspberry Pi optimizations
dbcache=600
maxorphantx=10
maxmempool=300
maxconnections=40
maxuploadtarget=5000

datadir=/mnt/hdd/bitcoin
# onlynet=onion
addnode=fno4aakpl6sg6y47.onion
addnode=toguvy5upyuctudx.onion
addnode=ndndword5lpb7eex.onion
addnode=6m2iqgnqjxh7ulyk.onion
addnode=5tuxetn7tar3q5kp.onion

ufw configured:
ufw allow from <IP_ADDRESS>/24 to any port 8332 comment 'allow RPC from local LAN'
ufw allow from <IP_ADDRESS>/24 to any port 28333 comment 'allow RPC from local LAN'

then disabled.
Restarted bitcoind and the whole node too.
Trying to make BTCpayserver connect to the RaspiBlitz, but the using with others too

Samourai -> Settings -> Transactions -> Set trusted node too, but no cummunication happening (Trusted node not responding, Please check installation)
telnet from an other machine on the LAN:

$ telnet <IP_ADDRESS> 8332
Trying <IP_ADDRESS>...
telnet: Unable to connect to remote host: Connection timed out

or
$ telnet <IP_ADDRESS> 8332
Trying <IP_ADDRESS>...
telnet: Unable to connect to remote host: Connection timed out

Tried calling with python-bitcoinrpc and came to the same errors.
on the RaspiBlitz:
$ sudo lsof -i:8332
COMMAND    PID    USER   FD   TYPE   DEVICE SIZE/OFF NODE NAME
bitcoind 21334 bitcoin    9u  IPv6 43194284      0t0  TCP localhost:8332 (LISTEN)
bitcoind 21334 bitcoin   10u  IPv4 43194286      0t0  TCP localhost:8332 (LISTEN)

Any ideas why the port 8332 cannot be accessed?

Got this now:
it works with rpcbind=<IP_ADDRESS>
https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.18.0.md#configuration-option-changes

The rpcallowip option can no longer be used to automatically listen on all network interfaces. Instead, the rpcbind parameter must be used to specify the IP addresses to listen on. Listening for RPC commands over a public network connection is insecure and should be disabled, so a warning is now printed if a user selects such a configuration

how can I change that for me it is <IP_ADDRESS> would also replace it with <IP_ADDRESS>

@Lupus-Pluvia what are you trying to achieve?
The rpcallowip= and rpcbind= needs to be the same to allow external RPC calls.
You would be best to use the LAN address of your external machine neeeding RPC access.
You can edit your bitcoin conf with
sudo nano /mnt/hdd/bitcoin/bitcoin.conf
save and restart bitcoind afterwards.

Goal: connect a LND running on my computer to bitcoind running on my raspiblitz pi4. Both are in the same ipv4 subnet (<IP_ADDRESS>/24).
This is the only way I could make it work:
rpcport=8332
rpcallowip=<IP_ADDRESS>/24
rpcbind=<IP_ADDRESS>
zmqpubrawblock=tcp://<IP_ADDRESS>:28332
zmqpubrawtx=tcp://<IP_ADDRESS>:28333

and configured UFW to allow local LAN connections for 8332, 28332, 28333.
Question: is there any chance that this could expose 8332, 28332 or 28333 to the public somehow, e.g. via TOR? Is there a more restrictive (not <IP_ADDRESS>) way to get this done?

So... does anyone got to run their asics with bggminer and btc core?? need help !


sanitize sentry_dsn

I wonder if we should just sanitize 'dsn' in general

@dcramer likely though I'll merge this meanwhile.

Thanks for the pull request @graingert


Shut Down, Restart, Factory Reset commands not supported in Chip-Tool - Requesting support

To check few test cases like TC-DM-1.2 steps 1, 2 and 3 via chip-tool and to further automate this test case, we need to know the chip-tool commands for Shut Down, Restart and Factory Reset. Requesting support for these commands in chip-tool.

https://github.com/project-chip/connectedhomeip/pull/14240


Getting rid of the false emojis.

 There are too many emojis in this file from the original I made and it is getting out of hand. It was suppose to be a simple emoji but false emojis have corrupted it. This is why Linus has fixed this.

Ignore the wrong profile picture on the commit author, it is Linus, github is having issues.

please follow the proper pattern for commit messages (💡TIP: you can use yarn commit or yarn commit:signed and answer the questions asked to generate a properly formatted one for you!)
to fix your most recent commit you can run the command git commit --amend -m "properly formatted commit message here"
to fix your older/multiple commits please take a look at this article

Wait is that linus torvalds??!??!

@willdoescode it's not a signed commit, so probably not

He probably use git-blame-someone-else

Sorry for destroying the fun lol

@TheOtterlord he doesn't sign his commits for non lunix related things.

Linux Torbvald?!?!?!?!?!?!!!!!!!!1


Determine immutability for const type parameters

Suggestion
Example:
(<const T>(f: () => T) => f)(() => ({ foo: 1 }));

Currently this results in: Return type should have an immutability of at least "Immutable" (actual: "Mutable"). However, the type parameter uses the const keyword so the code is equivalent to the following, which is correctly treated as immutable.
(<T>(f: () => T) => f)(() => ({ foo: 1 } as const));

(Not sure if this is a suggestion for this repo or for is-immutable-type so I made it here.)

It seems to be an upstream issue in ts-api-utils. I've created an issue over there, I'll close this one.


Adds ElasticsearchClusterNotHealthy messages

Adds ElasticsearchClusterNotHealthy notifications for warning- and
error-level events.
Signed-off-by: Christopher Collins<EMAIL_ADDRESS>

/lgtm


Removes ActiveRecord dependency for #model_hint

Class.name is the same as Class.to_s
I don't see a particular reason to have the AR dependency here. Missing something?

@gottfrois Thanks!


Multi Target Example

It would be great if you could deliver at least one of the actual examples, e.g. the calculator, to deliver building also for mobile (react-native) and web

This isn't meant to be multi target. If you take the code around <Window> and `' and paste it into React Native, it should work, but that is not the primary focus.

I understand your point but consider this: what is the point of having a support for desktop deployment that is closed to React Native if you are not developing multi-platform in smart (time saving) ways?


Rename Catching rules to Routing and add more info

For #193

There is one change in the requirements, see: https://github.com/StarcounterApps/Website/issues/193. Sorry for confusion.

About an exception, Ya I think if You do the /resetdata it should be fine.
By mistake I've pushed my latest changes to https://github.com/StarcounterApps/Website/pull/197 so please go there for update. Since #197 was based on this branch, I think we can close this PR and just proceed all changes by #197

Closing this PR as it is now merged to PR #197.
All comments from this PR are addressed.


(doc) add pcp to transport options list

CLA signed by all contributors.

This has been moved to docs.


On MacOS, widget.js MessageBox doesn't work (no input)

I use: TERM=xterm node node-ncurses/examples/widget.js MessageBox
The MessageBox is visible, but it seems like the keyboard inputs are not operational (I have to use ctrl-c to close the script).

I'm getting this problem for absolutely all the examples on master branch.

This should be fixed in 367fd5fe79, please test.

This seems to work now!


Remove the experimental LifetimeDependenceDiagnoseTrivial feature.

This was never used to generate a .swiftinterface, so can be safely removed. It
was used to guard compiler fixes that might break older .swiftinterface
files. Now, we guard the same fixes by checking the source file type.
This depends on fixing Span initialization from CxxSpan.

@Xazax-hun please take a look at the Span initializer fix

@swift-ci test

@swift-ci benchmark

@Xazax-hun this appears to fix: rdar://136668965 (Borrow diagnostics not triggered for foreign types)

this appears to fix: rdar://136668965 (Borrow diagnostics not triggered for foreign types)

This is wonderful news, thanks a lot for looking into it!