Script in step 3 failed

[Enter feedback here]
Hi team,
Trying forced tunneling on VPN GW referring to the following official document link , but script failed at step 3. 'Create the Route Table'
https://learn.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-forced-tunneling-rm#configure-forced-tunneling-1

And in my test <IP_ADDRESS>/0 changed to VPN GW without UDR, is UDR still necessary for forced tunneling?
Before applying the script

<IP_ADDRESS>/0 next-hop is Internet

After applying the script

<IP_ADDRESS>/0 next-hop is VPN GW

The following script was used in my test
$LocalGateway = Get-AzLocalNetworkGateway -Name "localgw1-rg3" -ResourceGroupName "03.resource-group"
$VirtualGateway = Get-AzVirtualNetworkGateway -Name "vpngw-rg3" -ResourceGroupName "03.resource-group"
Set-AzVirtualNetworkGatewayDefaultSite -GatewayDefaultSite $LocalGateway -VirtualNetworkGateway $VirtualGateway
Regards,
MC

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e199bebd-d994-ec96-4716-c995559adc21
Version Independent ID: 1b856aa3-2779-2600-152d-19a70c37edb9
Content: Configure forced tunneling for Site-to-Site connections - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-forced-tunneling-rm.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@mcshin92
Thanks for your feedback! We will investigate and update as appropriate.

@mcshin92 , the script failed in step 3 due to an invalid parameter.
"Label" is not a valid parameter for New-AzRouteTable cmdlet.  ---> Commands in step 3 & 4 needs to be updated.
Refer: https://learn.microsoft.com/en-us/powershell/module/az.network/new-azroutetable?view=azps-0.10.0
To answer your below question:
And in my test <IP_ADDRESS>/0 changed to VPN GW without UDR, is UDR still necessary for forced tunneling?
Without UDR, the route for <IP_ADDRESS>/0 shouldn't change to VPN GW. It is by default Internet. ---> This behavior needs further validation.
Refer: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-networks-udr-overview#default
And yes, UDR is necessary for forced tunneling because like I mentioned the <IP_ADDRESS>/0 route by default points to Internet and if you want to "force" all Internet-bound traffic back to your on-premises location via a Site-to-Site VPN tunnel for inspection and auditing, then you need to override the Azure's default route by a UDR where the destination <IP_ADDRESS>/0 should have next hop as the VPN gateway.
Refer: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-networks-udr-overview#user-defined
It is also mentioned in this doc as below:
The procedure steps set the 'DefaultSiteHQ' as the default site connection for forced tunneling, and configure the 'Midtier' and 'Backend' subnets to use forced tunneling. If forced tunneling is to be adopted, all the subnet must have the default route table overwritten.
However, I'm assigning this issue to the author for a doc update along with the correction of commands in step 3 & 4.
@cherylmc , please update the commands in step 3 & 4 as "-Label" parameter is not valid and also validate why the route for <IP_ADDRESS>/0 changed to VPN GW on running the "Set-AzVirtualNetworkGatewayDefaultSite" command?

Hi Gitarani,
Thank you a lot for the update.
For 2nd forced tunneling part, I know the following link is the official way to apply forced tunneling, but after I create connection on VPN gateway, and if I apply step 8 without any UDR, which is typical way in customer site, <IP_ADDRESS>/0 next hop changed from Internet to VPN Gateway, I mean again, without any UDR!!.
Configure forced tunneling for Site-to-Site connections - Azure VPN Gateway | Microsoft Learnhttps://learn.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-forced-tunneling-rm#split-tunneling-configuration-overview
It always happen, so easy to reproduce.
Actually customer also got the same test result, so he skipped to create UDR for now, and has no problem.

Before I apply script in step 8

<IP_ADDRESS> next hop is Internet
@.***

After I apply script in step 8

<IP_ADDRESS>/0 next hop is VPN gateway
@.***

Step 8 <<< apply this only
@.***
Step 3, 4, and 5 <<< Without this, <IP_ADDRESS>/0 next hop changed from Internet to VPN Gateway.
@.***
Regards,
MC
From: Gitarani Sharma @.>
Sent: Monday, January 23, 2023 11:03 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Myoung chul Shin @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Script in step 3 failed (Issue #103997)
@mcshin92https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmcshin92&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919175634|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=8AMbUVCPCzo9qPJX5tz%2BE9GtcA9gBFCttT1kCzsyxlo%3D&reserved=0 , the script failed in step 3 due to an invalid parameter.
"Label" is not a valid parameter for New-AzRouteTable cmdlet. ---> Commands in step 3 & 4 needs to be updated.
Refer: https://learn.microsoft.com/en-us/powershell/module/az.network/new-azroutetable?view=azps-0.10.0https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fpowershell%2Fmodule%2Faz.network%2Fnew-azroutetable%3Fview%3Dazps-0.10.0&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919175634|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=E53s1okMVwKqQUXKbduN%2BMXip9pHfIigCDYs7frBu9Y%3D&reserved=0
To answer your below question:
And in my test <IP_ADDRESS>/0 changed to VPN GW without UDR, is UDR still necessary for forced tunneling?
Without UDR, the route for <IP_ADDRESS>/0 shouldn't change to VPN GW. It is by default Internet. ---> This behavior needs further validation.
Refer: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-networks-udr-overview#defaulthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fazure%2Fvirtual-network%2Fvirtual-networks-udr-overview%23default&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919175634|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=uiQXxTTyJBguxpcSlz4xhiAj2gOGw1rMwNyrmDbWwAg%3D&reserved=0
And yes, UDR is necessary for forced tunneling because like I mentioned the <IP_ADDRESS>/0 route by default points to Internet and if you want to "force" all Internet-bound traffic back to your on-premises location via a Site-to-Site VPN tunnel for inspection and auditing, then you need to override the Azure's default route by a UDR where the destination <IP_ADDRESS>/0 should have next hop as the VPN gateway.
Refer: https://learn.microsoft.com/en-us/azure/virtual-network/virtual-networks-udr-overview#user-definedhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fazure%2Fvirtual-network%2Fvirtual-networks-udr-overview%23user-defined&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919175634|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ive7piYcpSob3vjobyhOapEmgm%2Fgr5iRKAdgfIMjQPs%3D&reserved=0
It is also mentioned in this dochttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fazure%2Fvpn-gateway%2Fvpn-gateway-forced-tunneling-rm%23split-tunneling-configuration-overview&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919175634|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zMlKMCsYAKu0VyQbwF9LdOESDSI0mAW0K%2Fc1tQlMres%3D&reserved=0 as below:
The procedure steps set the 'DefaultSiteHQ' as the default site connection for forced tunneling, and configure the 'Midtier' and 'Backend' subnets to use forced tunneling. If forced tunneling is to be adopted, all the subnet must have the default route table overwritten.
However, I'm assigning this issue to the author for a doc update along with the correction of commands in step 3 & 4.
@cherylmchttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcherylmc&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919330776|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PnmRZ2UA3yJ%2FgBaVfv3MN2mPNj53mZA0XiteLSH4CIw%3D&reserved=0 , please update the commands in step 3 & 4 as "-Label" parameter is not valid and also validate why the route for <IP_ADDRESS>/0 changed to VPN GW on running the "Set-AzVirtualNetworkGatewayDefaultSite" command?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F103997%23issuecomment-1400401260&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919330776|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=SS8WmC5sQL%2BXIswvNm3pet8VnlpgSHbcAJbILZFlfH4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA5KKP52U32IPKFQTHWGROVTWT2FRTANCNFSM6AAAAAAT7VBRTU&data=05|01|myoungchul.shin%40microsoft.com|b7ea8ab68584448b2e5a08dafd4a8d42|72f988bf86f141af91ab2d7cd011db47|1|0|638100793919330776|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=m0I3F6%2BKbCgtQ4JJyxC2wY%2BhFuvLxYEir7HM3520iS4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Thanks! We'll take a doc bug on this! #please-close


Checking completeness of documentation using coverage

Hi guys,
I have no idea if this is the correct section to ask this I have a couple of questions, feel free to close this if this is not appropriate to do so here.
I am very interested in the "coverage" part of the tool. I would like to check that all documentation is up to date and complete. Now when I create a test class with some methods and play around with the method signatures but keep the old documentation (this either doesn't have the correct parameters anymore or names have changed/new ones are added) the coverage still tells me that it's 100% as long as there is anything documented.
I would like to ask if there is a possibility to check that the documentation is present and all parameters are documented (and no "old" parameters are documented).
It would also be really nice if there would be an option to also include non public methods/classes in the coverage report, maybe with a separate flag?
Many thanks for all the effort that has been put into this project!

I would like to ask if there is a possibility to check that the documentation is present and all parameters are documented (and no "old" parameters are documented).

The current implementation of the coverage subcommand simply checks if any documentation is present. It does not check if the documentation is coherent with the code, e.g. if all parameters are documented or if there are parameters in the documentation which do not appear in code. @mattt is this a feature we might want to support in the future? Then we could open a new issue to track this.

It would also be really nice if there would be an option to also include non public methods/classes in the coverage report, maybe with a separate flag?

This feature was implemented recently, but there hasn't been a new release in which this is included yet. There's a new flag --minimum-access-level which makes this possible. If you want to use it today, you can compile swift-doc from source using the instructions in the README.

The current implementation of the coverage subcommand simply checks if any documentation is present. It does not check if the documentation is coherent with the code, e.g. if all parameters are documented or if there are parameters in the documentation which do not appear in code. @mattt is this a feature we might want to support in the future? Then we could open a new issue to track this.

I think this would be a great feature to support in the future. I just filed https://github.com/SwiftDocOrg/swift-doc/issues/246 to track this.
In the meantime, check out DrString, which might provide the kind of functionality you're looking for.


Quarto-cli

Project description
Quarto: an open-source scientific and technical publishing system
Metadata

homepage URL: https://quarto.org/
source URL: https://github.com/quarto-dev/quarto-cli
license: gpl2+
platforms: unix, linux, darwin, win?

Sorry, just saw it's a duplicate

duplicate of #160911
@Kupac please close this issue


Removed parameter and settings

Description

Removed first_only parameter
Removed max_concurrency and batch_size setting

first_only parameter was added as current geoip processor has it. However, the parameter have no benefit for ip2geo processor as we don't do a sequantial search for array data but use multi search.
max_concurrency and batch_size setting is removed as these are only reveal internal implementation and could be a future blocker to improve performance later.
Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CI is failing for some tests. Pls take a look

CI is failing for some tests. Pls take a look

Yes. There is a breaking change in OpenSearch core.


Razor page errors cause projects to not load

Make the following changes to the BasicRazorApp2_1 test in the o#-vscode repo:

Change the TFM to netcoreapp3.1
Remove the packagereference to Microsft.AspNetCore.App (not strictly necessary, but removes an extraneous warning with the 3.1 SDK).

O# will fail to load this project because the call to MSBuild to run Compile and CoreCompile here fails: https://github.com/OmniSharp/omnisharp-roslyn/blob/master/src/OmniSharp.MSBuild/ProjectLoader.cs#L99-L107. The specific error in this case is: Error: The 'page' directive expects a string surrounded by double quotes. Removing the invalid page from the project causes the project to be successfully loaded. Presumably, this part of the project loader is trying to validate that a design-time build can occur? Not really sure what other purpose it would have in calling those targets, but we need to do something to address the possibility of invalid razor pages on startup of the server. /cc @NTaylorMullen if you have any ideas.

I'm surprised that this results in the project failing to load for O#. That project loader piece tries to do a separate design time build on the project which I wouldn't imagine would influence the core build scenario?
I wonder if it has to do with MSBuild's caching logic writing goodies to disk


Add step to manually create the 'www' folder

Before, when running ionic serve, the following error is shown: "There was an error serving your Ionic application: "www" directory cannot be found. Please make sure the working directory is an Ionic project." The 'www' folder was in the .gitignore file, and therefore was not being checked into Git. The simple fix is for the user to manually create an empty 'www' folder.

Thanks for the PR! I decided to add an empty www/ directory for the user to solve this. We appreciate it though! :)


Add JSONB support for libsqlite3-sys?

I am currently working on adding SQLite jsonb support for diesel. It appears that libsqlite3-sys version 0.30.1 does not yet support JSONB functions. I tested rusqlite version 0.32.1, and it works well. However, using it introduces an additional dependency that feels somewhat redundant. Will libsqlite3-sys include JSONB-related support in its next release?
More information: https://github.com/diesel-rs/diesel/pull/4388

As far as I know, JSONB is available with SQLite >= 3.45.0 !
So I guess, you linked libsqlite3-sys with an older version !
Maybe the bundled feature is missing ?

Problem solved by changing bundled-bindings to bundled. You are right. Thanks very much.


Error with certain polygon data

🐛 Bug
I recently provided the Shapes layer with some funky data (result of an algorithm converging incorrectly), and got a rather mysterious error. It might well be VisPy's fault, but I don't have time to investigate now so I'll note it here for followup.

Geometry error traceback

Traceback (most recent call last):
  File "/Users/jni/projects/napari/napari/_qt/event_loop.py", line 79, in gui_qt
    yield app
  File "shapes-bug.py", line 69, in <module>
    _ = viewer.add_shapes([polygon], shape_type=['polygon'])
  File "/Users/jni/projects/napari/napari/components/add_layers_mixin.py", line 587, in add_shapes
    layer = layers.Shapes(
  File "/Users/jni/projects/napari/napari/layers/shapes/shapes.py", line 421, in __init__
    self._init_shapes(
  File "/Users/jni/projects/napari/napari/layers/shapes/shapes.py", line 1562, in _init_shapes
    self._add_shapes(
  File "/Users/jni/projects/napari/napari/layers/shapes/shapes.py", line 1680, in _add_shapes
    shape = shape_cls(
  File "/Users/jni/projects/napari/napari/layers/shapes/_shapes_models/polygon.py", line 34, in __init__
    self.data = data
  File "/Users/jni/projects/napari/napari/layers/shapes/_shapes_models/polygon.py", line 58, in data
    self._update_displayed_data()
  File "/Users/jni/projects/napari/napari/layers/shapes/_shapes_models/polygon.py", line 62, in _update_displayed_data
    self._set_meshes(self.data_displayed)
  File "/Users/jni/projects/napari/napari/layers/shapes/_shapes_models/shape.py", line 227, in _set_meshes
    vertices, triangles = triangulate_face(clean_data)
  File "/Users/jni/projects/napari/napari/layers/shapes/_shapes_utils.py", line 556, in triangulate_face
    vertices, triangles = PolygonData(vertices=data).triangulate()
  File "/Users/jni/conda/envs/all/lib/python3.8/site-packages/vispy/geometry/polygon.py", line 130, in triangulate
    tri.triangulate()
  File "/Users/jni/conda/envs/all/lib/python3.8/site-packages/vispy/geometry/triangulation.py", line 187, in triangulate
    self._edge_event(i, j)
  File "/Users/jni/conda/envs/all/lib/python3.8/site-packages/vispy/geometry/triangulation.py", line 295, in _edge_event
    assert next_tri is not None
AssertionError

To Reproduce
Run the following script (gist):

Failing script
import numpy as np
import napari

image = np.random.random((2019, 1826))

polygon = np.array(
      [[1029.4772481 ,<PHONE_NUMBER>7],
       [1029.47376005,<PHONE_NUMBER>9],
       [1029.46661985,<PHONE_NUMBER>7],
       [1029.45362593,<PHONE_NUMBER>3],
       [1029.43194205,<PHONE_NUMBER> ],
       [1029.39813338,<PHONE_NUMBER>9],
       [1029.3483479 ,<PHONE_NUMBER>3],
       [1029.27873604,<PHONE_NUMBER>2],
       [1029.18620352,<PHONE_NUMBER>6],
       [1029.06953907,<PHONE_NUMBER>4],
       [1028.93079474,<PHONE_NUMBER>6],
       [1028.77645299,<PHONE_NUMBER>3],
       [1028.61738263,<PHONE_NUMBER>1],
       [1028.46587633,<PHONE_NUMBER>5],
       [1028.33215388,<PHONE_NUMBER>9],
       [1028.22230446,<PHONE_NUMBER>8],
       [1028.13802554,<PHONE_NUMBER>6],
       [1028.07749293,<PHONE_NUMBER>6],
       [1028.0367732 ,<PHONE_NUMBER>3],
       [1028.01118779,<PHONE_NUMBER>4],
       [1027.99628852,<PHONE_NUMBER>4],
       [1027.98837781,<PHONE_NUMBER>5],
       [1027.98466953,<PHONE_NUMBER>5],
       [1027.98323318,<PHONE_NUMBER>9],
       [1027.9828447 ,<PHONE_NUMBER>1],
       [1027.98282925,<PHONE_NUMBER>6],
       [1027.98294609,<PHONE_NUMBER>1],
       [1027.98334123,<PHONE_NUMBER> ],
       [1027.98457615,<PHONE_NUMBER>3],
       [1027.98772772,<PHONE_NUMBER>9],
       [1027.99453842,<PHONE_NUMBER>7],
       [1028.00757362,<PHONE_NUMBER>4],
       [1028.03030978,<PHONE_NUMBER>4],
       [1028.06703902,<PHONE_NUMBER>2],
       [1028.12244859,<PHONE_NUMBER>3],
       [1028.20075946,<PHONE_NUMBER>5],
       [1028.30443902,  896.796077  ],
       [1028.43275425,<PHONE_NUMBER> ],
       [1028.5807052 ,<PHONE_NUMBER>6],
       [1028.73896101,<PHONE_NUMBER>6],
       [1028.89543067,<PHONE_NUMBER>2],
       [1029.03852709,<PHONE_NUMBER>2],
       [1029.16067553,<PHONE_NUMBER>2],
       [1029.25886404,<PHONE_NUMBER>6],
       [1029.33365718,<PHONE_NUMBER>5],
       [1029.38781126,<PHONE_NUMBER>5],
       [1029.42506957,<PHONE_NUMBER>1],
       [1029.44932344,<PHONE_NUMBER> ],
       [1029.4641231 ,<PHONE_NUMBER>3],
       [1029.47244944,<PHONE_NUMBER>3],
       [1029.47665082,<PHONE_NUMBER> ],
       [1029.47846788,<PHONE_NUMBER>2],
       [1029.4790933 ,<PHONE_NUMBER>1],
       [1029.47923321,<PHONE_NUMBER> ],
       [1029.47915162,<PHONE_NUMBER>4],
       [1029.47868846,<PHONE_NUMBER>6]],
)

with napari.gui_qt():
    viewer = napari.Viewer()
    _ = viewer.add_image(image)
    _ = viewer.add_shapes([polygon], shape_type=['polygon'])

Expected behavior
Either a clear error message or a tiny shape.
Environment
napari: 0.3.7rc3.dev132+g48b8f383
Platform: macOS-10.15.6-x86_64-i386-64bit
Python: 3.8.2 (default, Mar 26 2020, 10:43:30)  [Clang 4.0.1 (tags/RELEASE_401/final)]
Qt: 5.14.2
PyQt5: 5.14.2
NumPy: 1.18.4
SciPy: 1.5.1
Dask: 2.15.0
VisPy: 0.6.4

GL version:  2.1 ATI-3.10.16
MAX_TEXTURE_SIZE: 16384

Possible duplicate of #1058


Turn off awkward "feedback" when click

When I click on any link(button, tab...) on mobile, it shows some awkward blue feedback on a second, do you know how to turn that off?

On this picture is screenshot how that looks in dev tools, but it's same thing on mobile
Thanks!

Hello @johnylaravel. I do not see what link or button your are talking about. Could you provide a codepen with the link on it ?
See: https://codepen.io/IamManchanda/pen/EXbGKJ

I know you're still waiting for a reply @ncoden, but in case this helps: @johnylaravel maybe you can directly manipulate the active state of your button with :active CSS selector? I would test that first, and if no dice, then I know Android and iOS both have their own native element selection style that could be worth testing against: https://css-tricks.com/snippets/css/remove-gray-highlight-when-tapping-links-in-mobile-safari/


Possibility of manipulating modules by python scripts

Hello all,
In addition to web based UI and cyber_launch, is that possible to manipulate modules by python scripts?

Of course. In fact, cyber_launch is done through a python script.

Of course. In fact, cyber_launch is done through a python script.

@changsh726  Hello, it's nice to know this. Could you maybe give a simple example about how to use this Python script to turn on and off a single module? It will be of great help. Thx in advance!

@changsh726  Hello, it's nice to know this. Could you maybe give a simple example about how to use this Python script to turn on and off a single module? It will be of great help. Thx in advance!

There is no examples, this is basically executing a shell command mainboard -d xxx.dag or cyber_launch start xxx.launch in python, which can be done through os.system() etc.

There is no examples, this is basically executing a shell command mainboard -d xxx.dag or cyber_launch start xxx.launch in python, which can be done through os.system() etc.

Thx! It helps a lot!

Thx! It helps a lot!


Update apptestctl to v0.18.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.64%. Comparing base (2415fe2) to head (0b87a84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   62.64%   62.64%
=======================================
  Files          16       16
  Lines         945      945
  Branches       95       95
=======================================
  Hits          592      592
  Misses        322      322
  Partials       31       31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(antibot): add automatic recovery from antibot failure

Automatic recovery from antibot system block

Codecov Report
Patch coverage: 57.69% and project coverage change: -10.00 :warning:

Comparison is base (f20f4fc) 90.21% compared to head (91d5a0b) 80.22%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   90.21%   80.22%   -10.00%
===========================================
  Files          46       48        +2
  Lines         746     1082      +336
  Branches      106      161       +55
===========================================
+ Hits          673      868      +195
- Misses         64      197      +133
- Partials        9       17        +8

Impacted Files
Coverage Δ

src/lib/antibot/fetch-antibot-session.ts
12.50% <12.50%> (ø)

src/background-page/background-page.ts
36.84% <26.31%> (-6.02%)
:arrow_down:

src/lib/antibot/challenge-resolver.ts
63.13% <63.13%> (ø)

src/lib/internal-types.ts
100.00% <100.00%> (ø)

src/platform-message.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Including ready-made assets

Would it be possible to ship a minified CSS and JS version right with the darkroomjs project? This would allow to test quickly and hence to accelerate the usage of the lib!

+1

Fixed via #38 (and sorry for the delay)


Find ssm parameters recursively

Issue
It seems that when you have more than 10 ssm parameters, then ssm.get_parameters_by_path(Path=path, Recursive=True) will only fetch the first ten, then return a NextToken. This means that if you have more than 10 resources, then some won't be included in arc.reflect()
Solution
I've tried writing code that will recursively retrieve all the parameters. As long as the result includes a NextToken, then it will try to recursively retrieve more parameters.
Disclaimer: I'm very new to Python, so there might be better ways to do this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update message schemas to make the "messages" field context aware

for a command message the field is commands
for a command response message the field is responses
for a notification message the field is notifications

Reviewed on the call on the 31st January 2023.


Websocket Error 1006

Myrtille was working great and now I get an error when I connect saying that the websocket connection failed with error code 1006.

I'm sure that it is not my firewall. The service is running and everything so I'm not sure where the error is coming from.
It falls back to long polling at works.

Hi, did you changed or updated your browser? error 1006 means the connection was closed abnormally (locally) by the browser implementation (see https://stackoverflow.com/a/19305172)

Myrtille version 1.5.0 is out! :) it uses the same ports for http and ws protocols, so you should no longer have such issue.


Added lazy sync functionality

Implementation for: https://github.com/carvel-dev/carvel/tree/develop/proposals/vendir/001-lazy-synching-on-stable-config
Closes #278

@fritzduchardt
I have gone through the functionality and looks good but flag --lazy somehow creating confusion for me. As we say in flag description it will override "lazy" value in directory content configuration.
But if we have vendir.yml:
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: sponnet
  contents:
  - path: .
    lazy: false
    http:
      url: https://github.com/spinnaker/sponnet/archive/refs/tags/v1.26.0.tar.gz

And we run just vendir sync on this it will not override this value.  Also it does not make much sense to use such config but if will just look into flag --lazy it sounds the same.
Here --lazy will only update  "lazy" value false  not vice versa and description does not tell that.
I am not able to think better description as of now.
@joaopapereira  any suggestion on this?

I think that @Zebradil answer make sense

LGTM


Fixes #1527 - MedplumClient doc bugs in readme

Coverage: 93.694%. Remained the same when pulling e5355791aa71542e110cfff0afb000dc53ae259f on cody-client-doc-fixes into fe5e88ee4c937c3398b9a619867b32dafbc09988 on main.


When I run kpt fn render in a nested project, variables aren't expanded correctly

Expected behavior
should generate values such as:
name: artifactreader-gke-projectname-clustername-001 # kpt-set: artifactreader-gke-${project-id}-${cluster-name}

Actual behavior
actually generating:
name: artifactreader-gke-projectname-001 # kpt-set: artifactreader-gke-${project-id}-${cluster-name}

Information

1.0.0-beta.24
Steps to reproduce the behavior
project structure:
config-controllers-test/

configs/

project-name/

clusters/

clustername-001/

running at the project-name/ level generates the issue above.
running at the clustername-001/ level the ${cluster-name} correctly populates but ${project-id} is not populated unless it was previously filled by a higher level kpt fn render.
Work around is kpt fn render at the project-name level followed by a run at the lowest level of the tree.

Thanks for filing the issue @moorea7 . We are aware of this issue but do not have the capacity to fix the root cause. One temporary solution I can suggest is to avoid using the same character (in your case it's the dash "-")  in both the setter values and and the concatenating syntax.
I'll close this issue since it is a duplication of #3330. We will update and track the fix there


mptcp: uapi: fix SPDX License comment

The license is written just below and clearly mention:
GNU General Public License (...) either version 2 of the License,
*or (at your option) any later version*.

This is the GPL-2.0+, not GPL-2.0.
This is sync with upstream (mptcp.org), see:
commit d8f3b283b485 ("mptcp: uapi: fix SPDX License comment")

Reported-by: Thorsten Alteholz<EMAIL_ADDRESS>Signed-off-by: Matthieu Baerts<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.758%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1073

Relevant Lines:
1996

💛  - Coveralls


API status shows error but everything is up

It’s all in the title ...
Greets from Italy :)

Bug Report Dump (Auto-generated)

Version 1.27.2<PHONE_NUMBER>)
Device: iPhone X (iOS 12.3)
TestFlight: false

Hi @DanielOberlechner, thanks for letting us know! This has been fixed and will be available in the next update.
You should be able to use the app regardless of the reported error.
See #2546


this confirm can't block the function?

like the following code: "the second msg" first alert
$.confirm({
icon: 'fa fa-warning',
title: 'title',
content: 'test',
confirmButton: 'sure',
cancelButton: 'cancel',
confirm: function () {
alert("the first msg");
},
cancel:function() {
flag= false;
}
});
alert("the second msg");

Only the browser native alert & confirm can block the execution.
have a look at these issues. https://github.com/craftpip/jquery-confirm/issues/47 & https://github.com/craftpip/jquery-confirm/issues/36


Change UI to correctly represent Steam ID3 and not Steam ID

TF2's "status" command uses Steam ID3, not Steam ID.
"Steam ID" is in the format STEAM_X:X:XXXXXXXX. TF2BD utilizes TF2's built in "status" command which is in the format of "Steam ID3" [U:X:XXXXXXXXX]. Both of these ID types contain completely different strings of numbers and are formatted differently. This pull request is a simple, small UI change to differentiate between ID and ID3 within the main UI windows.
I can understand, for simplicity sake, why it would be easier to just say "ID" rather than "ID3", but I figured it might be worth bringing up anyway...

I realize that it is more technically correct, however I am slightly concerned about user confusion as far as input fields go:

"ID3? Which one is that?"
"Is my account somehow versioned? Do I need to update it somehow?"

I feel like it might be better to just update my steam id parsing so that it can handle the other formats (i think it currently handles id3 and id64 only).
With the labels, I don't think any of these questions apply. I feel like it's probably all right to be specific about saying "Steam ID3" in that case.


Bump gilrs version to 0.10

Objective
Fix #6555.
Solution
Bump gilrs version to 0.10.

girls 0.10 is breaking support for controllers on macOS. it has been fixed but not yet released

Duplicate dependencies are annoying, but I have a hard time arguing they're more important than supporting major controllers.

Opened a PR with Cpal to update their windows crate https://github.com/RustAudio/cpal/pull/726, I think that should solve the duplicate dependency. Will take a while to get downstream to us and I agree that it would be worth merging before then. (Once gilrs has the macOS fix out.)

Gilrs 0.10.1 just dropped! Should have the MacOS fix.
https://crates.io/crates/gilrs/0.10.1
Also includes my fix to make wasm binary smaller and a fix for north and west buttons being flipped on Wasm too.

bors try

could you update to 0.10.1 to ensure the 0.10.0 won't be used?

bors r+


FindMany filter arg type MongoID need to be coverted to string type

I found that findMany resolver's filter arg that has MongoID type doesn't work with mongoID input.
This is what it should be?, I think it will be better if it can work without toString().
Example

....
    addRelation({
      name: 'episodesRelation',
      args: {
        filter: source => ({
          seasonId: source._id.toString(),  // this one need to be converted to String
        }),
      },
      resolver: EpisodeTC.getResolver('findMany'),
      projection: { _id: 1 },
    })

.....
    addFields({
      episodesFields: {
        type: EpisodeTC.getTypePlural(),
        args: {
          offset: { type: 'Int', defaultValue: 0 },
          limit: { type: 'Int', defaultValue: 10 },
        },
        // this directly one doesn't
        resolve: (source, { offset, limit }, { Episode }) =>
          Episode.find({ seasonId: source._id })
          .skip(offset)
          .limit(limit),
      },
    })

....
  addRelation({
      name: 'episodesRelation',
      argsMapper: {
        filter: source => ({
          seasonId: source._id, // this deprecated one doesn't too 😆
        }),
      },
      resolver: EpisodeTC.getResolver('findByIds'),
      projection: { _id: 1 },
    })

I didn't understand why mongoose does not accept seasonId as BSON.
But we can not convert all args toString() by default because may be passed complex object.
Internally I'm using the same pattern toString in several places in my schema.
So for now, let keep it as is. Need to discover the source of the problem more deeply.

Okay, I will take a look on helpers/filter.js for further more !

Any help really appreciated!
helpers/filter.js is a right place for finding bug in graphql-compose-mongoose or mongoose itself.

This problem was fixed several months ago
https://github.com/graphql-compose/graphql-compose-mongoose/blob/9a90b82fddb93704341b3900e07a3fd351a409d1/src/utils/toMongoDottedObject.js#L35
Via checking ObjectId type and not "dotting" it.


Installer requires master: in any config file

If "master: " not in any config file, no master is set
"#master: " is no good

Implemented in https://github.com/markuskramerIgitt/salt-windows-msi/blob/d567b63e7dd0aa801ffc1306741e4d2b049eac95/wix.d/MinionConfigurationExtension/MinionConfiguration.cs#L586


Cannot iterate over a Hash without allocating an array?

I currently use mrb_hash_keys to iterate over a hash like this
mrb_value keys = mrb_hash_keys(mrb, value);
for (mrb_int i = 0, f = mrb_ary_len(mrb, keys); i < f; ++i) {
  mrb_value key = mrb_ary_ref(mrb, keys, i);
  mrb_value value = mrb_hash_get(self->state, value, key);
  my_function(key, value);
}

This has the downside of allocating an array and copying the keys, just to discard it it right after.
The fact that mrb_hash_tbl is exposed as a public API suggests that it is fine to access directly the kh_ht. This would allow to iterate without copying by using kh_begin and kh_end. The problem is that they do not work because these macros rely on the declaration of struct kh_ht which is private in hash.c. In that case, I wonder if the kh_ht is really mean to be public?

If yes, can I move KHASH_DECLARE to khash.h so it is usable from outside?
If no, I guess mrb_hash_tbl should not be public at all. In that case, what do you think of adding functions similar to these to the Hash API?

typedef size_t mrb_hash_iter_t;
mrb_hash_iter_t mrb_hash_begin(struct mrb_state *mrb, mrb_value hash);
mrb_hash_iter_t mrb_hash_end(struct mrb_state *mrb, mrb_value hash);
mrb_hash_iter_t mrb_hash_next(struct mrb_state *mrb, mrb_value hash, mrb_hash_iter_t iter);

Thank you.

One another suggestion to use callback.
/* callback can break loop with return FALSE */
void mrb_hash_each(
    struct mrb_state *mrb,
    mrb_value hash,
    int (*callback)(mrb_value key, mrb_value value));

It may cause serious problems if the hash is modified during the iteration. So I am not positive about providing public API to iterate over hashes. Instead I'd rather move KHASH_DECLARE to mruby/hash.h.


Optimize reading RPC responses

In #13 it seems ChannelFinderByPopularity takes a lot of CPU processing, which causes issues with responsiveness, since CLBOSS also hooks on rpc_command.
#15 would help reduce reduce processing load after the listnodes command returns, but the time from listnodes out to listnodes in is also pretty big, and is probably an even tighter processing load (ChannelFinderByPopularity performs Ev::yield after listnodes returns, but Boss::Mod::Rpc does not explicitly yield while processing the listnodes command).
2020-11-05T05:26:49.503Z DEBUG   plugin-clboss: Rpc out: listnodes {}
...
2020-11-05T05:45:48.127Z DEBUG   plugin-clboss: Rpc in: listnodes {} => {\n\t\"nodes\" : [\n\t\t{\n\t\t\t\"nodeid\" : \"0326efa5d368844e2c9cf1e46891a5d40cc5dc9d2371cfa23968d1fdf61b64814d\",\n\t\t\t\"alias\" : \"0326efa5d368844e2c9c\",\n\t\t\t\"color\" : \"3399ff...

That is ~19 minutes.  True, this is on a lightningd running under valgrind but nonetheless, we should probably optimize it better.
Currently we feed 256-byte chunks of data to the parser.  We can increase the chunk size (4096 seems better overall, at least for Linux).
Or, we could do what C-Lightning builtin plugins already do, which is to keep putting bytes in a buffer until it reaches a \n\n (two newline chars) and only then sending it to the parser.  C-Lightning has  a quirk where it emits two newline chars in succession at the end of each entire JSON datum.  The JSMN parser is fast if and only if you give it an entire JSON datum, giving it a partial datum means it has to keep restarting the whole parse sequence from the start of the datum.
Unfortunately this ties us to a particular quirk of C-Lightning, meaning that if people use wrappers and so on (e.g. run clboss on one system while running C-Lightning on another) the quirk also has to be replicated.
Perhaps an alternative that does not tie us to this quirk of C-Lightning would be to keep putting bytes in a buffer until the socket would block on read, and then send to the parser, and explicitly yield at that point.
Yet another possibility: http://pod.tst.eu/http://cvs.schmorp.de/libev/ev.pod#WATCHER_PRIORITY_MODELS

In addition to moving parsing of RPC responses into an idle watcher, I also had rpc_command specially handled by the stdin processor, which should help responsiveness when CLBOSS is busy.


Bar Chart Bottom Axis Label values Overlapping

Label over x-axis overlapping.
How can I get rid off it? can set minimum width of column or bar. as these labels do not overlap each other.

Try to change text size for xAxis (XAxis.setTextSize(int textSize))


Icon request: events icon

Very similar to calendar icon.
An example from material-icon:
https://design.google.com/icons/#ic_event

We are open to include any new icon request. However, I don't see much difference between our calendar icon and your suggested "event" icon. Can you add some reason why should add "event" icon?
@mruz what do you think?

I think we don't need a large sets of icons like fontawsome, just basic, simple icons. @Marchrius do you need both icons (calendar, event) or event would be better for you?

@thesabbir You are right, they are very similar but is the only example I found. A calendar icon is an icon that rapresents all the calendar so the art is like a grid. An event icon is a blank calendar (w/o grid) with a specific spot selected.
@mruz Both of the icons. I'm not looking for a collection that has a lot of icons but a collection with icons used in web apps. I have a web app with both calendar and events with different functionalities and I need different icon. If I can help feel free to ask me for help.

OK, thanks. I'll try to add it.


Version 2.6.1

Codecov Report
Patch coverage has no change and project coverage change: +1.22% :tada:

Comparison is base (b639099) 88.73% compared to head (402cd18) 89.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   88.73%   89.95%   +1.22%
==========================================
  Files         113       82      -31
  Lines       16207    14708    -1499
  Branches      597        0     -597
==========================================
- Hits        14381    13231    -1150
+ Misses       1796     1477     -319
+ Partials       30        0      -30

Flag
Coverage Δ

unittests
89.95% <ø> (+1.22%)
:arrow_up:

unittests-ios
?

unittests-rust
89.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 31 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is there training yaml on real denoising task?

Hello, CAT is a nice work.
There seems to be the training yaml on real denoising task missing from the code.
Could you share it?

Hi.
Thanks for your interest in our work. For real world denoising, the training code is built on Restormer. The training yaml is in restormer/options/. The training detail is inTraining.
If you have any other problem, please let us know. Thanks.

OK! Thank you!


[FR.] always send caller application name

Which module is your feature request related to?
Plugin
Is your feature request related to a problem?
If the call path is A -> B -> C, B calls C in a different thread(without changing code). The C will have a new transaction trace and will never know who called. On the web side, the calling side is always a virtual node user.  If we know which app made the call, we could change the application code to use pinpoint-sdk to wrap the existing code.
Describe the solution you'd like
In the http client plugins, insert a caller application name header to request.
Add a config to enable/disable this feature and a configure for header name.
A new PR would be made.
PR #8561 is made to resolve this issue.

It seems that the data you are adding is the same type as Pinpoint-pAppName
public enum Header {
    // ~~
    HTTP_PARENT_APPLICATION_NAME("Pinpoint-pAppName"),
    HTTP_PARENT_APPLICATION_TYPE("Pinpoint-pAppType"),

What's the difference with Pinpoint-pAppName?
Works regardless of sampling?

This header will always be sent regardless of sampling rate and async running in a different thread. The Pinpoint-pAppName header is only sent when the transaction is sampled and is hidden from application(profiler.tomcat/jetty.hidepinpointheader=true) to get. In most of the use cases, the caller application name is the most valuable, esp. for API statistics (api upgrading/deprecation/removal).

This header will always be sent regardless of sampling rate and async running in a different thread. The Pinpoint-pAppName header is only sent when the transaction is sampled and is hidden from application (profiler.tomcat/jetty.hidepinpointheader =true) to get.

It is a bug that AsyncContext works in DisableTrace state.

This feature has not been implemented yet.

The intended behavior is that AsyncContext should not work in DisableTrace.

In most of the use cases, the caller application name is the most valuable, esp. for API statistics (api upgrading/deprecation/ removal). The header name can be configured and the header can be fetched by callee app programmatically.

How about adding header api to Agent SDK?
Optional<Headers> headers = AgentContext.getHeaders();
if (headers.isPresent()) {
    Header header = headers.getParentApplicationName(); // getHeader("Pinpoint-pAppName"")
    header.getName();
    header.getValue();
}

@emeroad if the transaction is not traced, you could not know who's calling?


Update README.md

Added a new open source Telegram bot to the list.
By submitting this pull request I confirm I've read and complied with the below requirements 🙌

[x] I only updated data/*.json.
[x] The updated JSON file doesn't have any errors and has the correct indention style (2 space tab). (Recommended online validator: JSON Formatter)
[x] I placed the suggested item at the end of the related list.
[x] This suggested item is not a duplicate.
[x] This pull request contains one item.
[x] Item descriptions are short and simple, but descriptive.
[x] Item spelling and grammar are correct.

@ravindraten
Read the contribution guidelines please.


Trained checkpoint?

Hi,
Thanks for the great repo. I'm wondering if you can provide a checkpoint file for text summarization that has been trained on gigaword according to your settings? I'm trying to train according to the provided settings for train.py, and at this rate on 4 GPUs it will take me 2 weeks. (I had to set limits on max-tokens and max-sentences, because otherwise I get memory problems and the job hangs.)

I uploaded pre-trained LRPE + PE model in English dataset.
Please get from here: https://drive.google.com/file/d/15Sy8rv6Snw6Nso7T5MxYHSAZDdieXpE7/view?usp=sharing

Thanks!


Katib ROCKs

Description
Katib ROCKs are part of main epic for building secure images using ROCKs.
This issue is created to summarize details on ROCK design and track progress on ROCK creation for Katib.
Dockerfiles for Katib images:
https://github.com/kubeflow/katib/tree/master/cmd
Some sample work has been completed:
Python sample ROCK
Go sample ROCK
Remaining ROCKs:
Python based:
katib/cmd/suggestion/hyperband/v1beta1
katib/cmd/suggestion/pbt/v1beta1
katib/cmd/suggestion/skopt/v1beta1
katib/cmd/suggestion/optuna/v1beta1
katib/cmd/suggestion/nas/darts/v1beta1
katib/cmd/suggestion/nas/enas/v1beta1
Go based:
katib/cmd/suggestion/goptuna/v1beta1
katib/cmd/cert-generator/v1beta1 (https://github.com/canonical/katib-rocks/issues/19)
When building ROCKs best practices should be followed.
Progress: Katib ROCKs
Completed ROCKs should be checked and corresponding PR should be indicated.

[x] kubeflowkatib/katib-controller https://github.com/canonical/katib-rocks/pull/11
[x] kubeflowkatib/katib-db-manager https://github.com/canonical/katib-rocks/pull/15
[x] kubeflowkatib/katib-ui https://github.com/canonical/katib-rocks/pull/18
[x] katib/cmd/earlystopping/medianstop/v1beta1 https://github.com/canonical/katib-rocks/pull/12
[x] katib/cmd/metricscollector/v1beta1/tfevent-metricscollector https://github.com/canonical/katib-rocks/pull/13
[x] katib/cmd/metricscollector/v1beta1/file-metricscollector https://github.com/canonical/katib-rocks/pull/14
[x] katib/cmd/suggestion/hyperopt/v1beta1 https://github.com/canonical/katib-rocks/pull/16
[x] katib/cmd/suggestion/hyperband/v1beta1 https://github.com/canonical/katib-rocks/pull/22
[x] katib/cmd/suggestion/pbt/v1beta1 https://github.com/canonical/katib-rocks/pull/24
[ ] katib/cmd/suggestion/goptuna/v1beta1
[x] katib/cmd/suggestion/skopt/v1beta1 https://github.com/canonical/katib-rocks/pull/21
[x] katib/cmd/suggestion/optuna/v1beta1 https://github.com/canonical/katib-rocks/pull/20
[ ] katib/cmd/suggestion/chocolate/v1beta1 NOT SUPPORTED in v0.15.0
[ ] katib/cmd/suggestion/nas/darts/v1beta1
[ ] katib/cmd/suggestion/nas/enas/v1beta1
[x] katib/cmd/cert-generator/v1beta1 https://github.com/canonical/katib-rocks/pull/23 (Needs update https://github.com/canonical/katib-rocks/tree/main/cert-generator)

The following images will not be converted to ROCKs, because those are used as simple examples and will not be used by end-users in production:

kubeflowkatib/darts-cnn-cifar10-cpu
kubeflowkatib/enas-cnn-cifar10-cpu
kubeflowkatib/mxnet-mnist
kubeflowkatib/pytorch-mnist-cpu
kubeflowkatib/simple-pbt

Updated description with this comment.

@i-chvets To create issue to track not used Katib images elimnationm work.


Fix warnings in deps

This PR fixes warnings produced by 3rd party libs (sml/spdlog/...)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ab9e04b). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage          ?   85.57%
=========================================
  Files             ?      168
  Lines             ?     4694
  Branches          ?        0
=========================================
  Hits              ?     4017
  Misses            ?      677
  Partials          ?        0

Impacted Files
Coverage Δ

...core/libp2p/muxer/yamux/yamux_integration_test.cpp
100% <ø> (ø)

core/libp2p/muxer/yamux/yamux.cpp
63.15% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9e04b...eed7762. Read the comment docs.


react-native-fbsdk makes my build fail

Is this a bug report?
YES

Have you read the Contributing Guidelines?
YES
Environment
OS:  macOS Sierra 10.12.6
Node:  8.9.3
Yarn:  1.3.2
npm:  5.6.0
Watchman:  4.9.0
Xcode: 9.1 (9B55)
Android Studio:  3.0 AI-171.4443003

Packages: (wanted => installed)
"react": "^16.0.0-beta.5"
"react-native": "^0.49.5"
Steps to Reproduce

create-react-native-app my-test-app
cd my-test-app
npm run eject
3.1. option1: React Native: I'd like a regular React Native project
3.2 option2: give a name
3.3 option3: confirm
yarn add react-native-fbsdk
react-native link react-native-fbsdk
configure native project as described here
react-native run-android

Expected Behavior
The app is built and runs on android without any problem
Actual Behavior
I have this error during the build of the project:
➜  my-test-app react-native run-android
Scanning folders for symlinks in /Users/sunrising/Documents/work/sitrap/my-test-app/node_modules (7ms)
JS server already running.
Building and installing the app on the device (cd android && ./gradlew installDebug)...

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-fbsdk'.
      > Could not resolve all dependencies for configuration ':react-native-fbsdk:_debugPublishCopy'.
         > Could not find com.android.support:appcompat-v7:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified
         > Could not find com.android.support:appcompat-v7:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.react:react-native:0.50.3
         > Could not find com.android.support:support-annotations:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-annotations/27.0.1/support-annotations-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-annotations/27.0.1/support-annotations-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/support-annotations/27.0.1/support-annotations-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-core:4.29.0
         > Could not find com.android.support:support-core-utils:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-core-utils/27.0.1/support-core-utils-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-core-utils/27.0.1/support-core-utils-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/support-core-utils/27.0.1/support-core-utils-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-core:4.29.0
         > Could not find com.android.support:appcompat-v7:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/appcompat-v7/27.0.1/appcompat-v7-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-common:4.29.0
         > Could not find com.android.support:cardview-v7:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/cardview-v7/27.0.1/cardview-v7-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/cardview-v7/27.0.1/cardview-v7-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/cardview-v7/27.0.1/cardview-v7-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-common:4.29.0
         > Could not find com.android.support:customtabs:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/customtabs/27.0.1/customtabs-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/customtabs/27.0.1/customtabs-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/customtabs/27.0.1/customtabs-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-common:4.29.0
         > Could not find com.android.support:support-v4:27.0.1.
           Searched in the following locations:
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-v4/27.0.1/support-v4-27.0.1.pom
               file:/Users/sunrising/Library/Android/sdk/extras/android/m2repository/com/android/support/support-v4/27.0.1/support-v4-27.0.1.jar
               file:/Users/sunrising/Documents/work/sitrap/my-test-app/android/sdk-manager/com/android/support/support-v4/27.0.1/support-v4-27.0.1.jar
           Required by:
               mytestapp:react-native-fbsdk:unspecified > com.facebook.android:facebook-android-sdk:4.29.0 > com.facebook.android:facebook-common:4.29.0

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 11.653 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

Reproducible Demo
Take a look at Steps to Reproduce

I have the same issue.

I have the same issue.

now i have
compileSdkVersion 26 and buildToolsVersion "26.0.1"
and
dependencies {
...
   compile "com.android.support:appcompat-v7:26+"
    compile "com.android.support:design:26+"
    compile "com.android.support:recyclerview-v7:26+"
    compile "com.android.support:cardview-v7:26+"
...
}

but i always get
<mypath> .../node_modules/react-native-fbsdk/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:15:21-54: AAPT: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.

<mypath> .../node_modules/react-native-fbsdk/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:15: error: Error: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.

:react-native-fbsdk:processReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-fbsdk:processReleaseResources'.
> com.android.ide.common.process.ProcessException: Failed to execute aapt

This might be a problem in react-native-fbsdk or your app setup. I suggest asking this on the react-native-fbsdk or stackoverflow.

@facebook-github-bot stack-overflow

@chirag04 it seems that react-native-fbsdk has the issue section disabled, I will try in stackoverflow anyway... have you ever seen something like this?

1 ) Goto android/build.gradle add maven { url 'https://maven.google.com/' name 'Google' }
allprojects {
    repositories {
        ...
        // Add
        maven {
            url 'https://maven.google.com/'
            name 'Google'
        }
    }
}

2) Goto android/app/build.gradle
android {
    // change to
    compileSdkVersion 26
    buildToolsVersion "26.0.2"
    defaultConfig {
        ...
        // change to
        targetSdkVersion 26
    }
}
dependencies {
    ...
    // change all com.android.support to version 26.1.0
    com.android.support:appcompat-v7:26.1.0
}

3 ) When you has error AAPT: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.
Example:
/node_modules/react-native-fbsdk/android/build/intermediates/res/merged/release/values-v26/values-v26.xml:15: error: Error: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.
You can go to react-native-fbsdk/android/app/build.gradle and edit same  2 )

For me this was the simplest solution.
Way better than fiddling with node_modules. But be aware of updating the SDK dependency manually from time to time.. :)

I had to define the facebook sdk version on android/build.gradle:
allprojects {
    repositories {
        ...
        configurations.all {
            resolutionStrategy {
                force 'com.facebook.android:facebook-android-sdk:4.28.0'
            }
        }
    }
}

It works @yannickschuchmann @crysfel
Thanks!

@rafaesc You might be using a lower compileSdkVersion and buildToolsVersion under android/app/build.gradle. I had used 23 and 23.0.1 respectively, and had the same problem as you. When I used 26 and 26.0.1, I could use the solution by @yannickschuchmann
    compileSdkVersion 26
    buildToolsVersion "26.0.1"

@heralight
As you mentioned the error in facebook docs
use
compile 'com.facebook.android:facebook-android-sdk:[4,5)'
<-- this is the same as facebook doc?

Have you any log on crash, rn or android ?

@heralight
Thanks for reply.
I was following this: so I used "compile".
Finally I got it to work
** What I did**
Versions - blank app with only
react-native 0.54.2 (I tried from 0.52, 54.0, 54.1, 54.2)
react-native-fbsdk 0.7.0
after following the tutorial the errors were

Could not find com.android.support:appcompat-v7:27.0.2.
...

then I added this to build.gradle
allprojects {
repositories {
...
configurations.all {
resolutionStrategy {
force 'com.facebook.android:facebook-android-sdk:4.28.0'
}
}
maven {
url "https://maven.google.com"
}
configurations.all {
resolutionStrategy {
force 'com.facebook.android:facebook-android-sdk:4.28.0'
}
}
}
}
then the error became this:
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v24/values-v24.xml:3: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v24/values-v24.xml:4: AAPT: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v26/values-v26.xml:15:21-54: AAPT: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v24/values-v24.xml:3: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Borderless.Colored'.
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v24/values-v24.xml:4: error: Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Colored'.
/Users/chuck/Code/fblogin/android/app/build/intermediates/res/merged/debug/values-v26/values-v26.xml:15: error: Error: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.
then in app/build.gradle I changed to
compileSdkVersion 26
buildToolsVersion "26.0.1"
defaultConfig {
...
targetSdkVersion 26
}
And then It works on android now :)

@chuckcwh if you upgrade compileSdkVersion and buildToolsVersion, you don't need to
force 'com.facebook.android:facebook-android-sdk:4.28.0' ...

Just changing compileSdkVersion, buildToolsVersion and targetSdkVersion to 26, "26.0.1" and 26 respectively in app/build.gradle solved it for me. Thanks @heralight and @chuckcwh !

Just a comment. Using API 26 is breaking the Dev Menu in Android 8, because of a change in permissions with the overlay. Just blindily putting a greater compileVersion is not that good idea.

I followed all the steps by @chuckcwh but still my app is crashing in debug

So to get FB-login working in react-native you have to up target and compile sdk to 26? Which isnt supported by react native?
So not to risk breaking anything i have to use a old version of fbsdk targeting sdk 23?


support overload for complex function signature

Search Terms

overload
Suggestion

Hello, I've googled and searched here for what I want, but it seems not working for my case
according to what i found so far, typescript support overloading in some way
https://mariusschulz.com/blog/function-overloads-in-typescript
https://github.com/Microsoft/TypeScript/issues/5658
pls refer below snapshot, i'm trying to use overload for my project
the functions/constructors i'm trying to overload have very different parameters, according to example in 5658 and blog i shared, the actual implementation function signature must be compatible with all overload signatures, which is difficult for my case
i tried using ...args:any[] as implementation function signature, but there's error saying 'An Argument for underlying was not provided'
is there any way to make overload working for my case? thank you!

Use Cases

Examples

pls refer to uploaded snapshot above
Checklist
My suggestion meets these guidelines:
sorry i'm not sure if what i sugguest would break guidelines...

[ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals.

i found the problem, sorry for the trouble, closing


Build Tulsi with -quiet

This xcodebuild is very noisy. How do you feel about making -quiet the default?

:cool: thanks


relax faraday dependency

Allow updating the Faraday gem to current (0.11.0 at the time of writing).

(-0)+1! :shipit:

+1, thanks!


Schema doesn't serialize PnP:Provider elemenets

Played with the extensibility providers but can't get this working via declarative XML.

Added the PnP:Providers elements in the template.xml. After loading the template.Providers is null
Added the template.Providers via object model. This works just fine - extensibility provider is loaded and the ProcessRequest method is invoked. When I save the template object to XML i can see the correct PnP:Providers elements. However, after loading the saved xml template, the template.Providers object is again null. So,this works just fine if the provider is added via the object model, but doesn't work if the provider is added via in the template.xml file.

Hi Donald,
Thanks for your feedback. Actually, the formatter should support custom providers. Can you share with me the XML template that you are using? Just to double-check ...
Thanks.

Hi Paolo,
Sure - It contains some customer information but trust that is not an issue.
Attached files:

CanonProvisioningTemplate.xml -> this xml file is first extracted from an existing site. I then added the PnP:Providers element based on the blog from Erwin
PnPProviderDemo.xml -> this is a saved xml file from the template object (provider.SaveAs()) in which I added the provider objects via code. This works as expected, but it only works by adding the objects in code. If I load the saved xml template the template object doesn't have a collection for providers.

Many thanks,
Donald
Date: Tue, 1 Dec 2015 03:36:18 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [PnP-Provisioning-Schema] Schema doesn't serialize PnP:Provider elemenets (#51)
Hi Donald,
Thanks for your feedback. Actually, the formatter should support custom providers. Can you share with me the XML template that you are using? Just to double-check ...
Thanks.
—
Reply to this email directly or view it on GitHub.

Donald, please continue the thread by email. I will keep this one open and I will update it with the final outcome. Thanks again for your contribution.

Hi Donald, as we shared by email, the issue was related to the context of deserialization (missing the provider's assembly). Thus, I will close this one. Thanks.


[android] Fix some parts of Bundle in Android.

While Android does not follow FHS, and it doesn't seem to have something
similar published, it follows some conventions of Unix. One of them
is that libraries are normally named prefixed with "lib" and suffixed
with ".so" like Linux. Executables are also normally named without any
prefix nor suffix.
The changes in this commit lift up restrictions that were in place for
Android, and allow some of the Bundle tests to pass on Android (and lift
another restriction in TestObjCRuntime).
While bundles might never be a common construct in Android, these
changes at least allow to test some of the scenarios, in case someone
needs this behaviour.
This allows TestBundle, TestNSError, TestPropertyListSerialization, TestObjCRuntime, and TestNSKeyedUnarchiver to pass on Android devices.

The library/executable naming is not part of the FHS, its part of the Unix heritage.

@swift-ci please test

Incorporated the feedback from Lily and reworded the commit/PR message to not imply that libraries or executable naming are related to FHS (from the comments in the code I thought they were).

@swift-ci test

@swift-ci please test macOS platform


When downloading the project there is no project.godot file

I downloaded the project from the Godot Asset Library and had this issue so i couldn't import it.
Decided to download as zip from github, same issue, so i had to manually download the project.godot file.
The project is also not showing up in the Godot Engine Asset Library when searching for it.

The project is setup as an addon on the asset library, so you have to import it into an existing project. This is also the reason the download as zip feature only grabs the addons folder.

I see, would be nice to make a version that is a template project, because it is a very good starting off point. Better than any on the asset library at the moment imo.


Undocumented capacity limit for HeaderMap

HeaderMap has a capacity limit of 24576 headers. Adding any more headers triggers a panic when reserving more capacity.
I can't see any way to prevent the panic when handling incoming headers, except to hard-wire a check for this value into calling code.
It would be useful to expose this value as a public constant.
At the very least it should be documented. Currently HeaderMap::reserve says "Panics if the new allocation size overflows usize." This should be "Panics if the new allocation size is greater than 24576."

Good catch, thanks for reporting this! I'd propose a few improvements:

Add a section to the struct docs about the max capacity. Since there are a few methods that would allocate more space, seems better to have a single place to refer to the limit.
Update reserve to say "if the new size is larger than the internal max. See struct docs for more."
Optional: Add a try_reserve method. This changes the task from a docs fix to a feature request, so perhaps that should be a separate ticket if anyone wants this method.

I believe the correct way to fix that is to introduce fallible try_append method.
It's clearly vulnerability right now, because all usages like this one will cause a panic
cc @seanmonstar


lenovo/thinkpad/x1/7th-gen: init

Not sure how this fits with the "opinionated" bit in CONTRIBUTING.md, but I see similar stuff in lenovo/thinkpad/t490 so maybe it's OK?
This only works with unstable for now, until SOF is in stable (https://github.com/NixOS/nixpkgs/pull/87988).

Please add your profile to the table so it is picked up by CI: https://github.com/NixOS/nixos-hardware#how-to-contribute-a-new-device-profile


Renaming in the src/config.js file?

I wonder if we shouldn't rename the collection naming within that specific file to use a more explicit service, such as registerService or getService. This is rather confusing with the Collection class (and file) we provide for aurelia resolving mechanic.
Or did I miss something ?

ok that sound good to me.


Feature request: parse argv[0] and do the same with it as -X arg

I'd like to ln -s tea wget and have tea notice that argv[0] is "wget" and not "tea" and use argv[0] as the parameter of -X.
I'd also like to be able to version this so that I can have a 3.10 and a 3.11 python symlink. I've been trying to think of how to easily do this and here's what I came up with. Create something like "$TEA_PREFIX/python.org/v3.11.0/bin/tea-helper" and then I can link to that and it will notice what folder it is in and set up the environment and run the correct binary. I'm not sure that will work because it kind of breaks the package's sandbox. This doesn't break the sandbox but isn't as nice IMO "$TEA_PREFIX/tea.xyz/secretsauce/python.org/v3.11.0/tea-helper".
Everything else I think of requires passing arguments, which makes the symlink not work. I don't want to use the command_not_found handlers because then which doesn't work. I'd really rather not use shell aliases because then you have to configure each shell. A symlink works for every shell.
I don't want stub files. I think this is better than lots of launcher scripts (edit to add, that script of mine breaks tea updates, I'm not sure why yet, but it shouldn't really matter because I need to get rid of it). But I really would like to symlink directly to tea or to a tea-helper for version control.
Also, if one goes the symlink route, it would be beneficial to have a tool that looks for symlinks to tea and allow the user to quickly remove or archive them. And it would be cool to have a way to automatically create the symlinks too.

I am willing to work on this feature request if you're patient with me.

This mirrors npm's idea of a -g|--global install, and would be a useful feature to an install command.

Yeah, I always use the global install options. I guess that's why I'm so focused on this.

oh interesting. I already coded it so tea_foo runs foo (recent addition), but yeah, we could do what you suggest. This is a very neat idea. Also the version idea is splendid.
Yeah, let’s do it. Let us know if you need help! Here or discord.
And yes as @jhheider says, tea/cmd will make it possible to do global installs. But quite possibly this is a way better way to do that.

FYI: I noticed that this line is checking to see if arg0 is "deno". If you are already linking deno to tea, then if I make this change then the behavior will change, and whatever you are doing will break.

So… arg0 is deno when we are running from source, which notably includes all the times are running tests.

Ok, so the solution is to check arg0 and see if it's actually a symlink. After following the symlink, if it's another symlink with either a version in the path or name or something, that can enable that stuff. I'm not sure what the best thing is.
curl -> curl@version
curl@version -> /path/to/tea
or
curl@version -> curl
curl -> /path/to/tea
When I'm off work later today I'll start reading the Deno docs about stat'ing files and work on this again.

I think it’s as simple as:

if foo is a symlink to tea then become tea -X foo
if foo is a symlink to tea_foo then become tea -X foo
if foo is not a symlink, ignore

Possibly we should drop tea_foo but I don’t see any harm, it's a very small test matrix addition with no UI/UX overhead.

I don't see why we should drop tea_foo. Seems like a good idea to me.

I've been trying to think of how to do the symlink versioning and this is what I've come up with. If a file is a symlink, then read the link to see what it links to. If it links to the same name followed by a version string, then it can add that version string to the pkg dictionary. This is what the symlinks would look like. They don't have to be in the same directory.
python -> python=3.10
python=3.10 -> /path/to/tea
The symlink with the version could be any pattern supported by tea, like python^3.0.
The main code change has to be in app.X.ts line 37. The constraint would need to be changed to be something besides *. My question is do you want to try to parse the version in another file like utils/pkg.ts, hooks/useFlags.ts, or do you want put it in app.X.ts?
If I were to decide what to do, if I were going to do it quick I'd just copy the logic from pkg.ts to app.X.ts. If I were going to do it "right", I'd probably import pkg.ts in app.X.ts and I'd move the version parsing out of the parse function in pkg.ts into a function that I could call inside of app.X.ts.
I'm not a software developer and I've never worked on someone else's project like this. Well, ok, I did once and my pull requests were ignored because I changed too much. So I'm trying to be timid about my suggestions and everything. And I'll wait until I get some word on what you guys would want, and even if you want this feature at all.

The way to make a smallest change set is encapsulation. So, as you suggested, collecting all the parsing in one place makes it easiest to review, and will result in the most consistency throughout the code base. Whether that's in a util, a hook, or somewhere else, it should be easy to relocate if it seems natural somewhere else, so I wouldn't worry about that quite as much. Just from a first think, I'd probably start with it close to where parsePackageRequirements lives.

This is live. Reopen if I'm mistaken.


Metrics SWIG inclusion.

Include metrics.i in our main interface.
Return value from conf matrix method.

@mdymczyk do we need to put the numpy.i. (https://github.com/h2oai/h2o4gpu/blob/master/src/interface_py/h2o4gpu/util/numpy.i elsewhere 2)?

@Far0n no we don't need that one at all, I just forgot to put metrics.i into our (now) main interface file during cmake/swig remake - my miss sorry.

@mdymczyk my code uses numpy.i

@mdymczyk Why has metrics.i been changed? I think its broken now. Someone removed the numpi.i inclusion.

@Far0n we're using now SWIG for everything, its all in here now https://github.com/h2oai/h2o4gpu/tree/master/src/swig (together with numpy.i).

@mdymczyk I created metrics.i initially and it uses numpy makros:
%apply (double* IN_ARRAY1, int DIM1) {(double *y, int n),
                                      (double *yhat, int m),
                                      (double *w, int l)};
%apply (double* INPLACE_ARRAY2, int DIM1, int DIM2) {(double *cm, int k, int j)};

but numpi.i is no longer included. Don't think DAICX-code compiles any longer or how does that work?

@Far0n we have now 1 main interface file per CPU and GPU lib (e.g. https://github.com/h2oai/h2o4gpu/blob/bugfix/include-metrics-swig/src/swig/ch2o4gpu_cpu.i), inside which we include:

numpy.i
all of our own interfaces, including your metrics.i

We don't need to include numpy.i in metrics.i as it's already included in the main interface.
When refactoring I forgot to include metrics.i, hence the DAI error. Should be fine now.

@mdymczyk that's cool. sorry for confusion, missed that one. Nice to see more SWIG used. :)


Add Network inspector to inspects the HTTP(S) requests/responses

Why
Inspired by what we did in Android Templates, having a built-in Chucker tool that helps to inspect the HTTP(S) requests/responses is really helpful & efficient for the team, PM, and testers to determine and resolve the networking issues in the app build. We have the same tool in Flutter called Alice (more powerful than Chucker Flutter), so it's time to add it to our template.
Who Benefits?
Developers

not sure what we used in Varun but we definitely need this

yep I just found that it was alice as well.

@sleepylee yeah, to be honest, we did not have any network inspector tool in the Varun project. Maybe in your working project @doannimble. After researching, Alice has more powerful features than Chucker Flutter with higher rating, so it would be more stable 😄

https://nimble-co.slack.com/archives/C01NKCFNE6R/p1636107577006200?thread_ts=1636107577.006200&cid=C01NKCFNE6R

@luongvo We're using https://pub.dev/packages/inspector in easy Hotel Flutter project. I'm not sure if Alice supports GraphQL 🤔
cc @sleepylee

@doannimble it needs to be detachable i.e on the Firebase/Testflight build without connecting to dev tool.
I think we still use dio under the hood of our graphql calls? I'm not sure but we can check it out. Remember that we don't always have graphql project, and this is supporting Dio as the first case

@luongvo We're using pub.dev/packages/inspector in easy Hotel Flutter project. I'm not sure if Alice supports GraphQL 🤔 cc @sleepylee

it seems you sent a wrong tool @doannimble 😄

@luongvo @sleepylee Inspector supports both dio and graphQL. In easy Hotel Flutter project, we are using both RESTful and GraphQL.
For GraphQL calls, we use gql_link to execute the request, not dio

@doannimble do you mean this tool https://pub.dev/packages/requests_inspector?

@doannimble do you mean this tool https://pub.dev/packages/requests_inspector?

@luongvo  The similar one https://pub.dev/packages/inspector, not sure why there are two repo that have the same function/UI 😄

Confirmed by @doannimble here to use https://pub.dev/packages/requests_inspector for both HTTP with Dio and GraphQL with gql_link.

in case we are still discussing with tool to use, it is open for discussion, thus I updated the title

@luongvo I think we can create the voting so the members can choose the preferred tool. IMO, both request_inspector and Alice are easy to use, but I would choose Alice because it has more ratings on the Github page (more users use it so probably it's more stable 💡 )  😄


RFE: please list the subsets for Real

Request for Enhancement:
On https://docs.perl6.org/type/Real, you have to wade all the way down to find the subsets of what classes "Real" includes.
https://docs.perl6.org/type/Real#Type_Graph
Which is blurry and difficult to read.
It is not readily apparent what you are looking at.
Would you consider adding to the top of the page:
"Real" is a "Role" that includes the following classes:  FatRat, Rat, Rational, Duration, Instant, Int, PromizeStatus, Bool, Automicint, Sinval, Order, InStr, NumStr, Num
I may have misspelled some of them, as the graph is blurry

You can click on stand-alone image to get it full size. Still, Real says:

Common role for non-Complex numbers.

All those numbers you mention are non-Complex, so they are included. It's a more precise and compact description. They are not "subsets". All those classes mix in or do that particular role.
Type graphs are always on the bottom of the page, so that they don't get in the way of the actual documentation. As indicated, they can be accessed in full size just by clicking on the link. It's rendered in vector graphics, so I can't really see how it can be blurry; it does not get more crisp than vector graphics.
So I'm afraid I'm also closing this one.

@JJ If you open javadoc for Number, you're immediately presented with:

Direct Known Subclasses:
AtomicInteger, AtomicLong, BigDecimal, BigInteger, Byte, Double, Float, Integer, Long, Short

So the idea of wanting to see subclasses without having to scroll is not that unusual. I don't know if we want to do the same in perl6 docs, but the ticket by itself is a valid request that should be considered.

I don't know who does javadoc for Number. I don't know what principles they follow, or if they have a quite clear type graph, which not only lists known subclasses, but known siblings and known superclasses and all kinds of things. I wasn't here when it was decided, but someone Who Knows decided that, instead of listing every single known subclass, by hand, we were going to do something which is infinitely better, automatically maintained and not prone to error: generate a Type Graph. The Type Graph has all that information and, as said above, then some.
So no, we don't want to do the same in Perl 6 docs which is why I closed the ticket. And this is what I'm doing again.
If you want to open another different ticket saying "Repeat in every Role all the known classes that mix it in, or include in every class all known classes that subclass it" please do so by all means. That's another reason why this ticket is closed. If we are going to do that, we should do it, for simple coherency, for all classes and roles, and of course do it automatically.

On 9/17/18 5:11 AM, Juan Julián Merelo Guervós wrote:

I don't know who does javadoc for Number. I don't know what principles
they follow, or if they have a quite clear type graph, which not only
lists known subclasses, but known siblings and known superclasses and
all kinds of things. I wasn't here when it was decided, but someone Who
Knows decided that, instead of listing every single known subclass, by
hand, we were going to do something which is infinitely better,
automatically maintained and not prone to error: generate a Type Graph.
The Type Graph has all that information and, as said above, then some.
So no, we don't want to do the same in Perl 6 docs which is why I closed
the ticket. And this is what I'm doing again.
If you want to open another different ticket saying "Repeat in every
Role all the known classes that mix it in, or include in every class all
known classes that subclass it" please do so by all means. That's
another reason why this ticket is closed. If we are going to do that, we
should do it, for simple coherency, for all classes and roles, and of
course do it automatically.

Hi Juan,
Then how about moving that graph to the top of the page?
There is no reason why you should have to trudge through
developer lever documentation just to find out a simple
relationship.
Start simple, then build up to the complex.
-T

I really think that there is still something to discuss in this ticket.

If you want to open another different ticket saying "Repeat in every Role all the known classes that mix it in, or include in every class all known classes that subclass it" please do so by all means

I agree with JJ. There's no point having this as a stand alone issue for this page. It would have to change across all the pages and I'd welcome you writing that up as an issue.
For my part, I wouldn't like to see graphs at the top of pages.
As JJ says, you can see the graph clearly by clicking on the link that says 'vector' (perhaps that needs to be more obvious in some way?)
Ideally you wouldn't "go down several pages" but click on the link to Type Graph (Perhaps this needs to be more obvious in some way?)
I think the language pages are more beginner orientated and once you're banging around in types, you're in something more of a reference section and there needs to be some expectation of understanding what you're looking at and why (I think that it would be really useful to have a document perhaps explaining what you're looking at though!)
I'm not going to close this issue myself, otherwise it's just a tennis match, but if either @AlexDaniel or @ToddAndMargo want to, that would be good. It's definitely not a change that should be made in isolation.

On 9/18/18 11:45 AM, MorayJ wrote:

As JJ says, you can see the graph clearly by clicking on the link that
says 'vector' (perhaps that needs to be more obvious in some way?)

That was my mistake.  I was clicking on the picture itself.
What I want is the beginner's, common user's stuff
at the top and the advanced, developer's level stuff
underneath.
I think moving the graph to the top would accomplish that.
A quick link to it should also accomplish that as long
as your say "more obvious in some way".

On 9/18/18 11:45 AM, MorayJ wrote:

If you want to open another different ticket saying "Repeat in every
Role all the known classes that mix it in, or include in every class all
known classes that subclass it" please do so by all means

I did not see this.  Would someone mind forwarding it to me?

@ToddAndMargo as participant in this issue, you should have received it. In the same email, there is a link in the bottom of the page which will direct you to all this conversation.

Closed: superseded by #2315

Closed: superseded by #2315

But that's the same ticket?


Form refactor #4

Refactored Form component to use props.children API. Forms are now composed through nested JSX:
<Form>

Form Title!

  <Field />
  <Field />
</Form>

Coverage decreased (-0.8%) to 95.988% when pulling a474b64fa658e24b3593a4e450f6d796e5c7be12 on Form-refactor-#4 into 1bcfbc5a1f19f58a944dba0c5ff337c4095e4574 on epic-api-refactor-children-props.

Coverage increased (+0.1%) to 96.842% when pulling 67e8c6126787bf6219fda4ba844aeb846467138a on Form-refactor-#4 into 1bcfbc5a1f19f58a944dba0c5ff337c4095e4574 on epic-api-refactor-children-props.

Coverage increased (+0.1%) to 96.842% when pulling 4023bd3027d03a7333e35d39a59612e4a1345e95 on Form-refactor-#4 into 1bcfbc5a1f19f58a944dba0c5ff337c4095e4574 on epic-api-refactor-children-props.


SMTP Authentication unsuccessful when using auth_password_file

What did you do?
I want to send out Emails and specifying the SMTP Password in a separate file
What did you expect to see?
Email should be send to the configured receivers
What did you see instead? Under which circumstances?
If an alert fires i got the following error:
alertmanager[2143392]: ts=2024-02-06T08:58:50.982Z caller=notify.go:745 level=warn component=dispatcher receiver=email integration=email[0] aggrGroup={}/{}:{} msg="Notify attempt failed, will retry later" attempts=1 err="*email.loginAuth auth: 535 5.7.3 Authentication unsuccessful"

If i directly configure the auth_password it works.
Environment

System information:
Linux 5.14.0-362.8.1.el9_3.x86_64 x86_64

Alertmanager version:
alertmanager, version 0.26.0 (branch: HEAD, revision: d7b4f0c7322e7151d6e3b1e31cbc15361e295d8d)
build user:       root@df8d7debeef4
build date:       20230824-11:11:58
go version:       go1.20.7
platform:         linux/amd64
tags:             netgo

Prometheus version:
prometheus, version 2.45.2 (branch: HEAD, revision: 3d6b7e665928a78c4a18675802436fe92f3f4e04)
build user:       root@3b1b6808f1b0
build date:       20231219-14:07:38
go version:       go1.21.5
platform:         linux/amd64
tags:             netgo,builtinassets,stringlabels

Alertmanager configuration file:

global:
  resolve_timeout: 5m
  smtp_auth_password_file: '/etc/alertmanager/smtp-password'
route:
  receiver: "email"
  routes:
    - receiver: 'msteams'
      group_wait: 30s
      continue: true
    - receiver: 'email'
      group_wait: 30s
  group_wait: 30s
  group_interval: 5m
  repeat_interval: 4h
receivers:
  - name: "email"
    email_configs:
      - to: 'to address'
        from: 'from address'
        smarthost: 'smtpserver:25'
        auth_username: 'user'
        tls_config:
          insecure_skip_verify: true
  - name: "msteams"
    msteams_configs:
      - webhook_url: webhook
        send_resolved: true

This is basicly the content of the smtp-password file:
password

Logs:

alertmanager[2143392]: ts=2024-02-06T08:58:50.982Z caller=notify.go:745 level=warn component=dispatcher receiver=email integration=email[0] aggrGroup={}/{}:{} msg="Notify attempt failed, will retry later" attempts=1 err="*email.loginAuth auth: 535 5.7.3 Authentication unsuccessful"

I was able to reproduce and solve the issue. It seems to be the problem with the missing trim of the password. I did not had any whitespace in the password file but it seems there were some whitespaces added during reading of the file. This PR solves this problem but it is not part of the latest release. #3680


feat: ✨ UV Tools

Wow, I love you. Slowly turning Comfy more and more into TouchDesigner (great source of inspiration if you've never heard of it), making my dreams come true.
It would be really amazing if there was a "Image to UV" node as well, so we could import our own displacement maps.
Eventually the ability to set borders as "mirror" or "extend" to the "Distort Image with UV" node would really great, to avoid black bits to appear/bleed into the image.

This is all done in private extensions now, might open source some of it at some point

at some point

Tada!


Controller runtime metrics not exposed before first reconciliation/error

Bug Report
What did you do?
Launch an operator built on top of the operator-sdk to my cluster then curl the metrics endpoint from within the pod.
What did you expect to see?
Expected to see all relevant controller metrics, most importantly controller_runtime_reconcile_total and controller_runtime_reconcile_errors_total set to 0.
What did you see instead? Under which circumstances?
Only the workqueue_* metrics were present. After I ran a reconciliation, most of the controller_runtime* metrics appeared but still not controller_runtime_reconcile_errors_total. This last metric only appeared after there was an error.
This is an issue because we set up alerts around these metrics which usually work as expected, but whenever we deploy a new version of the operator there is a period with no metrics reporting until the next reconciliation / error so our alerts start firing thinking we can't scrape any metrics from the pod when in reality these metrics just aren't exported with value 0 like they should be.
Environment
Operator type:
/language go
Kubernetes cluster type:
vanilla
$ operator-sdk version
operator-sdk version: "v0.18.2", commit: "f059b5e17447b0bbcef50846859519340c17ffad", kubernetes version: "v1.18.2", go version: "go1.13.10 linux/amd64"
$ go version (if language is Go)
go version go1.13.15 linux/amd64
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.10", GitCommit:"575467a0eaf3ca1f20eb86215b3bde40a5ae617a", GitTreeState:"clean", BuildDate:"2019-12-11T12:41:00Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.10", GitCommit:"575467a0eaf3ca1f20eb86215b3bde40a5ae617a", GitTreeState:"clean", BuildDate:"2019-12-11T12:32:32Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Additional context
It's possible this is an issue with the underlying controller-runtime library but I figured I would start here.
Relevant controller-runtime code for reference:
https://github.com/kubernetes-sigs/controller-runtime/blob/3645df01769a3f131a6d9adfe4dfd6f76206ff82/pkg/internal/controller/metrics/metrics.go#L29-L39
https://github.com/kubernetes-sigs/controller-runtime/blob/2b423ec0a6646ad7fec022f76aa7c94358dc1135/pkg/internal/controller/controller.go#L263-L282

Relevant controller-runtime code for reference:
https://github.com/kubernetes-sigs/controller-runtime/blob/3645df01769a3f131a6d9adfe4dfd6f76206ff82/pkg/internal/controller/metrics/metrics.go#L29-L39
https://github.com/kubernetes-sigs/controller-runtime/blob/2b423ec0a6646ad7fec022f76aa7c94358dc1135/pkg/internal/controller/controller.go#L263-L282

Relevant controller-runtime code for reference:
https://github.com/kubernetes-sigs/controller-runtime/blob/3645df01769a3f131a6d9adfe4dfd6f76206ff82/pkg/internal/controller/metrics/metrics.go#L29-L39
https://github.com/kubernetes-sigs/controller-runtime/blob/2b423ec0a6646ad7fec022f76aa7c94358dc1135/pkg/internal/controller/controller.go#L263-L282

Submitted a PR to fix this here: https://github.com/kubernetes-sigs/controller-runtime/pull/1324

Submitted a PR to fix this here: https://github.com/kubernetes-sigs/controller-runtime/pull/1324

Upstream PR has been merged. This will be released in controller-runtime v0.8.0.

Upstream PR has been merged. This will be released in controller-runtime v0.8.0.


F distribution

split from #1177

jenkins, test this please.

I'll review this after #1414 is merged (and the conflicts are resolved).

Jenkins CI test (for commit 46982d7fc6a1d191a0bc7a8f72134816059bfbb8, target branch master) succeeded!

Codecov Report

Merging #1421 into master will increase coverage by <.01%.
The diff coverage is 94.11%.

@@            Coverage Diff            @@
##           master   #1421      +/-   ##
=========================================
+ Coverage    93.1%   93.1%   +<.01%
=========================================
  Files         134     134
  Lines        6908    6923      +15
=========================================
+ Hits         6432    6446      +14
- Misses        476     477       +1

Impacted Files
Coverage Δ

cupy/random/distributions.py
100% <100%> (ø)
:arrow_up:

cupy/random/_kernels.py
100% <100%> (ø)
:arrow_up:

cupy/random/__init__.py
97.43% <100%> (+0.06%)
:arrow_up:

cupy/random/generator.py
93.09% <87.5%> (-0.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028556c...668c1bb. Read the comment docs.

jenkins, test this please.

Jenkins CI test (for commit 33c74fa4ce2a57a423296e3816f531d6b3052cd1, target branch master) succeeded!


[Backport 2.11] Backport #1240 and #1276 to 2.11

Backport #1240 and #1276 to 2.11
Issue #, if available:
Description of changes:
CheckList:

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Multi-node test failing in past PR, but still merged in: https://github.com/opensearch-project/alerting/actions/runs/6537110867/job/17750237560#step:5:317


Avoid getting many alerts of the same leak

I wanted to know if it is possible to add a flag so we don't get tons of alerts of the same "leak"
Right now if somebody pushes a secret and keeps modifying that file, gitleaks will match that same secret the number of times the user modified the file. So we might get 1 or 50 jsons of the same "leak" in the same file but in different lines.
Wanted to know if there is a way to do this before I try to add my own script to do it

Hello @marcelo321 !
I understand that the user modified the file refers to each commit and all those json refer to each finding in each commit.
Have you tried the --no-git option?

Likely fixed in v8.0.0 although gitleaks should only report leaks when they are introduced