Setting doom local leader key to "," conflicts with evil-snipe

What did you expect to happen?
local leader taking priority over other keymaps.
I found this issue but the symptom here isn't exactly the same.
What actually happened?
When I press , in normal mode, I got "nothing to repeat". I tried SPC h k and it is still bound to evil-snipe-repeat-reverse
Additional details:

Include a link to your private config:

here I commented out the line setting the loca lleader.

Include screenshots/casts of your issue
If you mention key sequences, include what commands they're bound to (use SPC h k KEY or C-h h k KEY to inspect keys).
Include any warnings or errors logged to *Messages* (use M-x view-echo-area-messages to see it):

It says "nothing to repeat".

If an error message is involved include a backtrace of it.
How to acquire a backtrace:
https://github.com/hlissner/doom-emacs/blob/develop/docs/getting_started.org#how-to-extract-a-backtrace-from-an-error

Steps to reproduce:
Do (setq doom-localleader-key ",").
Press , in normal mode.j
System information:

```
SYSTEM  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /bin/bash
        uname      Linux 4.19.154-1-MANJARO #1 SMP Fri Oct 30 10:25:08 UTC 2020 x86_64
        path       (~/.emacs.d/bin/ ~/.emacs.d/bin/ ~/.emacs.d/bin/ ~/.emacs.d/bin/ /home/$USERpencil/perl5/bin ~/.local/bin /home/$USERpencil/perl5/bin ~/.local/bin ~/.local/bin /usr/local/bin /usr/bin /bin /usr/local/sbin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /bin /opt/google/chrome/ ~/go/bin ~/matlab/bin ~/.gem/ruby/2.7.0/bin ~/bin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /bin /opt/google/chrome/ ~/go/bin ~/matlab/bin ~/.gem/ruby/2.7.0/bin ~/bin /usr/lib/emacs/27.1/x86_64-pc-linux-gnu/)
EMACS   dir        ~/.emacs.d/
        version    27.1
        build      Aug 28, 2020
        buildopts  --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-wide-int --with-modules --with-cairo --with-harfbuzz 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP
        traits     (server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        build      grafted, HEAD -> develop, origin/develop, origin/HEAD 7205b72 2020-11-06 21:16:04 -0500
        elc-files  0
        modules    (:completion (company +childframe) (ivy +fuzzy +icons) :ui doom doom-dashboard doom-quit fill-column hl-todo (ligatures +extra +hasklig) modeline nav-flash ophints (popup +defaults) vc-gutter vi-tilde-fringe (window-select +numbers) workspaces :editor (evil +everywhere) file-templates fold (format +onsave) multiple-cursors snippets word-wrap :emacs dired electric undo vc :term vterm :checkers syntax :tools (eval +overlay) lookup magit :lang emacs-lisp markdown org sh :config literate (default +bindings +smartparens))
        packages   ((keyfreq) (org-bullets))
        unpin      (n/a)
        elpa       (n/a)
```

Btw, I also tried unbinding , from evil-snipe keymaps and evil-motion-state-keymaps but then , doesn't seem to be bound to anything.

Add (setq evil-snipe-override-evil-repeat-keys nil) to ~/.doom.d/config.el (not in an after! block, it needs to be set before the package loads).
Hope that helps!

Hi, thanks for helping! I tried that and now "," is bound to the normal evil search reverse instead of the local leader.
Here are the relevant config:
(setq evil-snipe-override-evil-repeat-keys nil)
(setq doom-localleader-key ",")
(setq doom-localleader-alt-key "M-,")

Also, I managed to reproduce this in vanilla doom, + modules, - private config and just entering above 3 lines.

Oh, just to add on to this:
I was testing in my config.org which is in org mode, which surprisingly does not have any local keybindings. I tried in elisp mode and settings local leader works as expected. Thanks!

@pspencil this is a bug. Org mode does have local keybinds, which used to work with local leader, and indeed are still available under SPC m. This should be reopened.

Edit: (add-hook! 'org-mode-hook #'+org-init-keybinds-h) fixes this, but this should really work out of the box.

@betaprior I cannot reproduce the issue in vanilla Doom. +org-init-keybinds-h is already on org-load-hook and appears to work as intended. Please provide what code you're using to reproduce this.

Note that I observed the behaviour in above comment 10 days ago and it somehow fixes itself. So maybe it got fixed in one of the commits committed recently.
@betaprior perhaps you can try upgrading the doom?

Related issue: https://github.com/hlissner/doom-emacs/issues/4247

In my system, this appears to be triggered by org-roam.  In particular, having the following code in my config reliably triggers leader-on-comma breakage.  Adding (add-hook! 'org-mode-hook #'+org-init-keybinds-h)   at some point after that code block restores correct behavior.
(after! org-roam
  (require 'org-roam-protocol)
  (setq org-roam-directory "~/Dropbox/org/roam")
  ;;https://github.com/zaeph/.emacs.d/blob/0f4bf9a500ef6397b93c41cb51602bea9ab9a4c3/init.el#L3804
  ;; [[https://copingmechanism.com/2020/keeping-org-roam-daily-notes-in-a-separate-folder/][Keeping Org-roam Daily Notes in a separate folder – Coping Mechanism]]
  (setq org-roam-dailies-capture-templates '(("d" "daily" plain (function org-roam-capture--get-point) ""
                                              :immediate-finish t
                                              :file-name "dailies/%<%Y-%m-%d>-${slug}"
                                              :head "#+TITLE: %<%Y-%m-%d>-${slug}\n#+created: %u\n#+last_modified: %U\n\n")))
)

(use-package! org-roam-server
  :config
  (setq org-roam-server-port 8091
        org-roam-server-export-inline-images t
        org-roam-server-authenticate nil
        org-roam-server-network-poll t
        org-roam-server-network-arrows nil
        org-roam-server-network-label-truncate t
        org-roam-server-network-label-truncate-length 60
        org-roam-server-network-label-wrap-length 20))

I am running a very recent Doom (110d70bdff12c6).

I have the same issue, I've tried this in my config:
(add-hook! 'org-mode-hook #'+org-init-keybinds-h)
(setq evil-snipe-override-evil-repeat-keys nil)
(setq doom-localleader-key ",")
(setq doom-localleader-alt-key "M-,")


[Experimental] aaa_no_blacklist and Modern Weapons Pack Expanded

A big update for aaa_no_blacklist and Modern Weapons Pack Expanded that fixes all the possible bugs and errors, crashes included, addition of pocket_data updates as well for aaa_no_blacklist, temporarily changed override_gun.json to override_gun.txt in Modern Weapons Pack Expanded since these vanilla guns overriding file causes a crash, so now both mods can be move from broken mods to working mods, everything is linted

should of made a new pr for each mod

should of made a new pr for each mod


owr: Drop references to ercolorspace

We're not actually using it any more.

It was only meant as an immediate fix, we still have to decide how to move forward with the colorspace conversion.

Cerbero doesn't build ercolorspace anymore, so we should include this in Cerbero at least. People who are just rebuilding openwebrtc-gst-plugins.recipe won't see the problem because Cerbero doesn't remove old files when the recipe stops installing them.

@nirbheek - can you throw a patch into cerbero so that the cerbero build works?

@superdump Should be fixed now. I've also included Arun's patch.


rename --ticket-ttl  argument to --expires-in

Observed behavior
The project ticket  command accepts a  ticket-ttl argument that is the time-to-live of the generated ticket,  in seconds.
Rename that argument for expires-in
Steps to reproduce
$ ockam project ticket -h
Expected behavior
an --expires-in argument replace the existing --ticket-ttl
Ockam Version
develop

👋 I'd like to take this one


[8.0][DOCS] Adds Connecting section to docs (#6183)

This PR backports the following changes to the 8.0 branch:
[DOCS] Adds Connecting section to docs #6183

CI failure is unrelated.


404 response downloading node 8.1.1 headers

I've started seeing this given a recent upgrade to node 8.1.1:
21:45:26 Output:
21:45:26 gyp info it worked if it ends with ok
21:45:26 gyp info using<EMAIL_ADDRESS>21:45:26 gyp info using<EMAIL_ADDRESS>| linux | x64
21:45:26 gyp http GET https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz
21:45:26 gyp http 404 https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz
21:45:26 gyp WARN install got an error, rolling back install
21:45:26 gyp ERR! configure error
21:45:26 gyp ERR! stack Error: 404 response downloading https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz

The download// makes me concerned, as that url is almost certainly not correct. Question is - what is causing the URL to be formed that way?

Yep, this is a duplicate of https://github.com/nodejs/node/issues/13667, https://github.com/nodejs/node-gyp/issues/1231 and https://github.com/nodejs/node-gyp/issues/1230.
I'll close this as a duplicate, it'll be fixed in the next Node 8 release. In the meantime you can use the workaround in https://github.com/nodejs/node/issues/13667.


Don't mangle new Component helper props

Fix mangling of new Componen properties introduced in #171.

I don't think so. Currently we don't have a test for this.
The reasoning for the naming is that I didn't want the mangling to accidentally rename _updater and _updateFlags to names that are already being used by Preact itself. Is this even something that I should worry about? 😄

Fair point! Haven't thought about potential name clashes with Preact itself. That makes sense.


Error with 2.1.1 - ConvertError: ErrorCode = -4

When I save the plugin configuration it's giving error:
ConvertError: ErrorCode = -4
Even if I connect with onlyoffice demo server it is still giving the same error:
ConvertError: ErrorCode = -4
Please help!

Error -4 could mean that Redmine is only reachable via a local address (localhost, for example) and the Document Server is unable to download the file using the local URL.

Please check if the issue persists with the recently released version 3.0 of the plugin.


3DS2 Simulator buttons barely visible under iOS mobile devices

Describe the bug
We noticed that the buttons in 3DS2 Simulator page under iOS mobile devices are not visible. There is a scroll usually which we are not able to see under iOS mobile devices.
To Reproduce
Steps to reproduce the behavior:

Go to an Adyen test environment payment page
Select 'Credit Card' with 3DS (for example 3714 4963 5398 431, Expiry Date: 03/30, CVC: 7373)
Fill in all the details fields with valid information
Click on the 'Continue' CTA

Expected behavior
Both buttons should be fully visible or able to scroll to.
Screenshots
Safari:

Chrome:

Desktop:
Not reproducible
Smartphone:

Device: iPhone 13 Pro
OS: 15.6
Browser: Safari and Chrome
Version: v15.6 and v104.0.5112.99

Hi @kdimitrovosf ,
Thanks for reaching out. What version of the SDK are you on?

Hi guys.
Please raise this issue on the sales force project if it still relevant. Cheers


Bug | Blogs page | Janky UI for larger content on mobile screens

Where ?
/blogs
What?
On Mobile viewport, when the content height increases, the 'x mins read' text overrides the blog content, making the UI janky.
Screenshot

Expected behaviour:
The content and "x mins read" should not override in any case.

@aadeshkulkarni Could you assign this to me?

Sure

Opened a PR for this. Please review.

closed via #48


PDFTextStripper.getText misses some characters from a PDF file

When attempting to extract text from the attached simple PDF file there are some characters missing within the text.
To reproduce the problem simply call pdfStripper.getText() on the attached pdf file (Problematic.pdf)
The text is mostly returned ok, however the following issues are present in the returned text:
making time to reflect and review your -> making time to reect and review your
If you find it easier -> If you nd it easier
PdfBox-Android version: [e.g. <IP_ADDRESS>]
It happens on all versions of Android SDK (I have tried several)
Problematic.pdf

This is an unsolved problem
https://issues.apache.org/jira/browse/PDFBOX-3248
In this file, the /ToUnicode file maps ligatures to 0 and uses the /ActualText feature in the content stream which PDFBox doesn't support.

Possible solution, that works with the linked file:
https://issues.apache.org/jira/browse/PDFBOX-5868?focusedCommentId=17874189&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17874189


[Basic Roleplaying]Fixes to the Perform Skill and Damage

Changes / Comments
Fixed an issue found in the Perform skill
Negative Damage Bonus was not appropriately included into the final output.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[X] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Global flags no longer shown

I'm opening this issue to make sure this get properly tracked and fixed before the next release.
With #7917, global flags are no longer being shown in the main help text (running helm or helm -h).  This was first reported here https://github.com/helm/helm/pull/7917#issuecomment-626189561
This may be a good thing, as long as there is a way to see the global flags, which there isn't right now.
Furthermore, the help text of each sub-command refers to a non-existant helm <sub-command> options.
For example:
$ helm status -h
[...]
Usage:
  helm status RELEASE_NAME [flags] [options]

Use "helm status options" for a list of global command-line options (applies to all commands).

but helm status options does not exist.
PR #8095 aims to fix that.
Output of helm version:
version.BuildInfo{Version:"v3.2+unreleased", GitCommit:"3779d959667095e03308a2e49480748f7911b228", GitTreeState:"dirty", GoVersion:"go1.13.7"}

@marckhouzam I see the global commands now. I've not looked but I wonder if merging #8153 fixed it.

Yes. Sorry for not closing this. #8153 did indeed fix this and we confirmed yesterday on the dev call. Closing!

I should have followed-up on closing to issues.  Sorry.


Fix some leaks here and there

This PR fixes some leaks around the codebase.

Coverage decreased (-0.1%) to 77.004% when pulling 8323af99a40538e544f7a30f8cd289d11190eadc on kobolog/leak-fixes into dc278d0f7100b0da02df31a3d28d867b048e95ad on master.

Coverage decreased (-0.01%) to 77.135% when pulling 5314165f3c71fef0ca6ec0832ac2a71c7383d409 on kobolog/leak-fixes into dc278d0f7100b0da02df31a3d28d867b048e95ad on master.

Coverage decreased (-0.1%) to 77.027% when pulling 515c27f28ade5351488f071d6140618d4daf2f14 on kobolog/leak-fixes into dc278d0f7100b0da02df31a3d28d867b048e95ad on master.

Coverage decreased (-0.1%) to 77.02% when pulling f7f85ded9336ec4ffc17d4f97919596591d75620 on kobolog/leak-fixes into dc278d0f7100b0da02df31a3d28d867b048e95ad on master.


Add a Splash Screen

@Buddhad I would like to work on this issue...Kindly assign me this

@Buddhad  Can you please elaborate a bit

So you need to add a splash screen when the website going to open the first thing that is visible is the splash screen(like a logo).

Use a Gif for Splash screen.


[spark] Support Spark MergeInto with DeletionVector

Purpose
to support Spark MergeInto DML with DeletionVector

Tests

API and Format

Documentation

@Zouxxyy please take a look.


Include referenced text in metadata description

Bug/issue #, if applicable: 129801569, #856
Summary
Fixes a bug where the logic that populates <meta name="description"> content doesn't include the text for any referenced items.
Testing
Steps:

Use a link to a symbol in first paragraph abstract for a documentation page.
Verify that the text for the referenced symbol is now included in the <meta name="description"> tag in the resulting HTML

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[X] Added tests
[X] Ran npm test, and it succeeded
[X] Updated documentation if necessary

@swift-ci test

@swift-ci test


Expose UserState and the node id to value_widget

This changes the signature for value_widget to provide additional information:
    fn value_widget(
        &mut self,
        param_name: &str,
        node_id: NodeId, // NEW
        ui: &mut egui::Ui,
        user_state: &mut Self::UserState, // NEW
    ) -> Vec<Self::Response>;

This allows more flexible implementations for inline widgets, where the behavior of the widget depends not only on the ValueType but additional data that might be stored in the UserState.

Also exposed UserState to the three methods in NodeTemplateTrait. This is useful for when the NodeTemplate struct does not contain the data, but some key to that data. Users can then store the actual table inside UserState and query it when needed.

Finally, this also adds the NodeData parameter when drawing the value widget. This required an extra Default trait bound, which hopefully shouldn't cause too much trouble on user crates. An unsafe solution exists that didn't require the trait bound, but I don't consider it worth it.


I-2 Added refresh starter

Added refresh starter with mock implementation

Closing due to the unification of the local and refresh providers in 0.9.0


Deck openapi2kong regex_priority forcing unsigned int

When using deck v1.35 and looking to convert an openapi file with the command deck openapi2kong file-name.yaml
The regex_priority when set to a negative number, will become a very large integer on a path given that that path has regex within it. For example if I have a path of /test/{tester} and it has a regex_priority of -10, the converted file output will look like the following: regex_priority:<PHONE_NUMBER>3709551605
This seems to be the max size of unsigned int minus 10.
The code snippet I believe is this here: https://github.com/Kong/go-apiops/blob/05ef8ef2321deaf33684e7bd9b2881c3047a9ece/openapi2kong/openapi2kong.go#L1104-L1106
This can be replicated with the file attached and using the command deck file openapi2kong -s openapi.yml
openapi.txt

I think the problem is here: https://github.com/Kong/go-apiops/blob/05ef8ef2321deaf33684e7bd9b2881c3047a9ece/openapi2kong/openapi2kong.go#L1099
That's where the result is cast to a UINT

fix released in decK 1.36.2


Unable to start Dotnet

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/microservice-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
Windows 10
installation was successfull but after restarting the CMD it said that "dotnet" was not recognized as an internal or external command.

Seems like dotnet is not added to your PATH. If the installation was successful, you can add it to the PATH yourself.
Gotten these steps from stackoverflow.
Steps:

Open Control Panel > System and Security > System
Click on Advanced system settings
In advanced section, click in Environment Variables
In System variables, select path and edit
After semicolon, write "C:\Program Files\dotnet" (if you've installed the SDK in a different directory, use that one instead of the default location).
Click on Ok button till end.


Overall style changes

Some minor style changes to the css can make a significant difference.

See pull #309.

SHADOW on edges


Automated cherry pick of #8009

Cherry pick of #8009 on release-5.35.
/cc  @hanzei

/release-note-none

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 2e7721a74a4584a107f8a7aa6ca1c55b35b1caf0


Zsh/Bash autocompletion generator

It would be really handy to build script which will automatically generate autocompletion files.

This gem https://github.com/labocho/thor-zsh_completion works well. But it doesn't support options and subcommand arguments.

As an alternative to an "autocompletion generator", could Thor respond with completions when called with COMP_LINE and COMP_POINT?
An example implemented and documented in a downstream project is Autocomplete Design

I'm not even going to create a PR (because my code is so bad) but here's a bit of it working.... hacky auto-complete branch


Stop API process when Ledger process crashes

Fixed here https://github.com/CounterpartyXCP/counterparty-core/pull/2808


test account history in jellyfish-api-core extensively

What would you like to be added:
Account history RPCs should be tested extensively.
Why is this needed:
Currently, the test within Account History is very limited. It only checks the soundness of the RPC does not test it end to end with different setups. We need complete/full e2e testing on account history to prevent regression.

@aikchun you need to work on this soon before moving to working on explorer related work

@fuxingloh What are some of the various setups and scenarios that should be tested?
And this is for listAccountHistory and accountHistoryCount rpcs?

Pool Rewards
Pool Swap
AccountToAccount
UTXO To Account
Account to UTXO
Pool Enter
Pool Exit

1. Pool Rewards

2. Pool Swap

3. AccountToAccount

4. UTXO To Account

5. Account to UTXO

6. Pool Enter

7. Pool Exit

If I infer the code correctly, for Pool Enter, this happens when user calls addpoolliquidity rpc right?
Pool Exit -> removepoolliquidity rpc
Pool Swap -> poolswap rpc
I'm not too sure when Pool Rewards happen.

1. Pool Rewards

2. Pool Swap

3. AccountToAccount

4. UTXO To Account

5. Account to UTXO

6. Pool Enter

7. Pool Exit

If I infer the code correctly, for Pool Enter, this happens when user calls addpoolliquidity rpc right?
Pool Exit -> removepoolliquidity rpc
Pool Swap -> poolswap rpc
I'm not too sure when Pool Rewards happen.

Pool Reward happens at every block gen, you need to allocate pool reward to a pool via set governance.


Bug: Custom oss.fyi/reponame does not work

Describe the bug
At one point, when clicking the share button on a repo page it would use the repo name and org in the URL. That is no longer the case.
Steps to reproduce

Visit https://beta.app.opensauced.pizza/s/swiftlang/swift
Click the share button
Note the link is not oss.fyi/swiftlang/swift

cc @brandonroberts - I believe you had the most context on the Dub.co short linking functionality


delete mutation doesn't work properly

i have a merge tree table with big data.
when i execute delete query, it says "0 rows affected".  but records are not deleted.
my table has datetime and id columns and partition by date.
when i try on little size table, it works.
is it related with size of table or type of data? should i make any change in config.xml or settings?
thanks in advance..

it works in background and eventually will finish.
check
select * from system.mutations where parts_to_do>0;

hi!
my query's filter is "where toDate(DateTime_value) < today()-5" and it has suspended for 5 days.
but when i writer filter as "where toDate(DateTime_value) = '2018-11-12' " it executed in 10 seconds.
in system.mutations table command column of my filter is shown like "delete where  toDate(DateTime_value) < '((2018 - 11) -  7 )' "
what does it mean?
but i execute "where toDate(DateTime_value) = '2018-11-12'" filter, it is shown in system.mutations table like "where toDate(DateTime_value) = '2018-11-12'"
what is the difference between these two queries?
thanks.

@ztlpn seems a bug in alter delete
today()-5 --->  '((2018 - 11) - 7 )'

i found out why this was occurred. i forgot quote with date.
when date is written like 2018-11-7, db transforms ((2018 - 11 ) - 7)
thanks.


Add Bootstrap 4 compatibility

Added function to convert px units to em (divide by 16). Modified any styles that fail to precompile with Bootstrap 4 due to mixing px and em units - These now call the px_to_em function to convert the px units to em.
Note: I have not converted every px unit to em, only those that caused a rake assets:precompile failure. Also note there are no specs for this change - I kept running rake assets:precompile until it succeeded, changing one px unit at a time.

I'm closing this, because I am now finding that it doesn't work. I'm now seeing smaller text than I'd expect. I'd appreciate any comments anyone else might have about integrating Bootstrap 4 with Rail Admin. It seems it's harder than I imagined


[#2444] Exact class type matcher

Fixes https://github.com/AxonFramework/AxonFramework/issues/2444

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

And, lastly, if you want this to be part of 4.6.2, you will have to adjust where this PR will merge in.

I tried to change the base branch to axon-4.6.x (edit button next to title of the PR) but then I get some extra commits on this PR.
I have one issue, in my fork, I do not have the option base commit on that branch and fork cannot be synced (already up-to-date)

PR moved to https://github.com/AxonFramework/AxonFramework/pull/2446


Http endpoint in pageserver for basebackup

Basebackup psql command has quite a few parameters without well defined schema and parsing is quite messy, so we can use http here instead. (Do not forget to update swagger schema)

After a series of discussions, had decided against implementing it.
The main motivation for a change stays the parameter parsing and clarity, yet to move basebackup on http entirely (removing it from psql) we would need to:

adjust zenith_ctl: currently, it is a wrapper around psql and does not use http client capabilities at all.
adjust cluster_spec.json so that zenith_ctl gets a proper connection string to pageserver, apply it cluster-wide
deal with HTTP byte streaming without accumulating entire basebackup tarball in memory
Currently it's done with psql-specific CopyDataSink wrapper that would not work for http.
Also, we use synchronous API everywhere, so both archive creation and http response writing should be rewritten to async for that

All this combined already feels like a big task to do and there should be better reason to pull that of than the sake of parameter refactoring.
Also to note, current basebackup has tenant id, timeline id and lsn as parameters, which is not that dire.


SW-1845 Revamp accession and batch number generation

Previously, accession numbers were globally unique, which was fine because we were
generating them on the server side. But now we allow users to upload CSV files
with their own arbitrary accession numbers, and we don't want one organization to
be able to make an accession number unavailable to another one.
Change the database constraint so that accession numbers are only required to be
unique per facility.
In addition, the fact that we encoded dates into accession numbers sometimes
causes user confusion: those dates usually match up with several other accession
dates such as the collection date, but not always. Although the date selection was
consistent on the server side, users didn't have a good way of learning how it
worked and made assumptions which then broke some of the time.
To address that, we now allocate these identifiers as simple incrementing numbers,
tracked separately per organization, starting with 100000 so they'll stay a
consistent width on screen for all but the very largest of organizations.
Seed accession and seedling batch numbers are allocated from the same place; we
will never generate an accession number that we've generated as a batch number for
the same organization or vice versa. However, if the user generates their own
accession numbers and uploads them in a CSV file, we don't enforce that the
numbers have to be unique across the organization, just unique within a particular
seed bank.

Current dependencies on/for this PR:

main

PR #696

PR #698

PR #700

PR #701

PR #702   👈

This comment was auto-generated by Graphite.

Apparently we still want date-based accession numbers after all. Closing this.


[DO NOT MERGE] Reduce robots.txt crawl-delay to 0.1s

#7620 went out yesterday morning and nothing is on fire, so let's reduce it again.

Trello card

Going to ask Tim Blair how long we want to monitor.

We've left it at 0.3 seconds over the weekend which didn't seem to cause any problems, so this is now fine to merge.


Fix Room::find panics on the live environment

Hey!
I encountered an issue where Room::find would panic when playing on the live environment.
it works fine in simulation, but on the live world I always encounter a panic.
Here's an example stack trace
[8:18:11 PM][shard3]Encountered a panic!
[8:18:11 PM][shard3]Panic error message: js_unwrap_ref at 97 in C:\Dev\screeps-in-rust-via-wasm\screeps-game-api\src\objects\impls\room.rs: Custom("reference is of a different type")
[8:18:11 PM][shard3]Panic location: src/libcore/result.rs:1009
[8:18:11 PM][shard3]caught exception: RuntimeError: unreachable
[8:18:11 PM][shard3]stack trace: RuntimeError: unreachable
    at rust_panic (wasm-function[613]:1)
    at _ZN3std9panicking20rust_panic_with_hook17h869ce4541d4e3554E (wasm-function[451]:295)
    at _ZN3std9panicking18continue_panic_fmt17h0ad726c0b188da91E (wasm-function[629]:75)
    at rust_begin_unwind (wasm-function[662]:3)
    at _ZN4core9panicking9panic_fmt17h4d67173bc68f6d5aE (wasm-function[438]:70)
    at _ZN4core6result13unwrap_failed17hfc6bc97b52ed5f63E (wasm-function[288]:130)
    at _ZN5xenos6creeps9harvester15attempt_harvest17h865640d46b5bd9d4E (wasm-function[119]:4503)
    at _ZN5xenos6creeps9harvester3run28_$u7b$$u7b$closure$u7d$$u7d$17h300928efa798c577E (wasm-function[321]:10)
    at _ZN70_$LT$xenos..bt..Control$LT$$u27$a$GT$$u20$as$u20$xenos..bt..BtNode$GT$4tick17h631da085a125a2dbE (wasm-function[115]:1096)
    at _ZN5xenos6creeps9harvester3run28_$u7b$$u7b$closure$u7d$$u7d$17h80e90cff34d67169E (wasm-function[280]:7)

Calling Object.values on the JavaScript results before returning seems to fix this problem.

Given https://docs.screeps.com/api/#Room.find the find method should return an Array. Your workaround seems to indicate that this is not the case, that it returns an object.
Calling Objects.values would mean we are discarding the keys of the values, wouldn't it? In that case, what is it that we are discarding?

I whipped up a small test:
    js!{
        const room = @{room};
        const sources = room.find(FIND_SOURCES);
        console.log("|", sources, "|", Object.keys(sources), "|", Object.values(sources));
    }

And got the following result:
[8:52:59 PM][shard3]| [source #5bbcaaf29099fc012e6327cd],[source #5bbcaaf29099fc012e6327cf] | 0,1 | [source #5bbcaaf29099fc012e6327cd],[source #5bbcaaf29099fc012e6327cf]

It seems like we're discarding the indices of the list. On the JavaScript side it works as an Array, but stdweb can not parse it as such.
I believe that this behaviour is a bug in the Screeps implementation.

@snorrwe Do you perhaps have the IVM runtime disabled on screeps? We currently only support IVM (though I'm not sure if that's documented anywhere...)
In the non-IVM runtime, the javascript virtual machine creates new types for use inside the VM which are identical to the ones outside, but are technically different. In particular, player code has access to different "Object" and "Array" types than code outside. It usually works alright, but this means that instanceof Array doesn't work for things returned from game calls, and prototype modifications on Array don't exist. We used to have a workaround for this, but it was removed in https://github.com/daboross/screeps-in-rust-via-wasm/commit/ae11e89b8ecb90c570c0d415d2a582c78f1e102a shortly after the IVM runtime was officially released.

Could you check and confirm which runtime you're using and whether this still occurs with the IVM?

@daboross You're right, I was using the legacy VM. The panic does not occur with IVM enabled. I'm a returning player, I had no idea this setting existed. I think this might be worth a mention in the documentation, but since it's deprecated I don't think this workaround should be included in this repo. I'll close the PR.

Definitely should be referenced in docs! I've opened https://github.com/daboross/screeps-in-rust-via-wasm/issues/136 so this isn't forgotten.


prototype ability for dialects to override prefix and infix parsing

Closes https://github.com/sqlparser-rs/sqlparser-rs/issues/580

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 13 (53.85%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 85.396%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
3
9
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
9514

Relevant Lines:
11141

💛  - Coveralls


Pseudo roadmap for yo

Please feel free to add items to this checklist as appropriate, we'll use it to track the current toplevel priorities.

[ ] Immediate priority: fully working notifications in condenser
[ ] Medium term priority: email transport
[ ] Immediately post-steemfest: multiple instance support
[ ] Post-steemfest: SMS, VAPID, APNS, Firebase et al

Some commentary on the above and current status:
I've been working myself almost exclusively on the polled API for condenser and this is where progress is most advanced, but there are lots of little things going on and too many to list here.
Email transport: the transport code exists, it needs templates imported and some logic to choose the right template based on notification type. This is being tracked in issue #52 currently assigned to @jnordberg
Multiple instance support: theoretically, if we run 2 or more instances right now, the API server will do fine, but there's no support for multiple blockchain followers keeping in sync with each other to avoid duplicate notifications. Earlier today I actually dropped the DB table used for this, but basically the approach is the one outlined here: https://github.com/steemit/yo/issues/64
After the scaling issues are sorted or at least more reliable we can start adding more transports - naturally reliability comes first.
Longer term we have stuff like localisation, please add such items to this issue so we can keep track of general overall vision.

Who set these priorities?

Arised out of discussions on slack with @john-g-g and others.
Of course the above can easily be changed, please advise.
Sneak has said multiple instance support is needed for MVP, so more attention needs to be paid to that now and i'd like to know if we can start with multiple API servers to begin with

Closing to keep stuff clean based on new methodology


No option to remove single product from wishlist.

Hi @jyoti-webkul,
For removing the product from the wishlist just click the wishlist icon.

@devansh-webkul  currently in bagisto wishlist API, there is not mention how to remove a specific item from wishlists.  Am I missing something or the documentations need to be updated ?

Hi @Ezaldeen99,
Yes, documentation is missing. I just checked the code resource is available for destroying the wishlist.
Route::delete('wishlist/{id}', 'ResourceController@destroy')->defaults('_config', [
    'repository' => 'Webkul\Customer\Repositories\WishlistRepository',
    'resource' => 'Webkul\API\Http\Resources\Customer\Wishlist',
    'authorization_required' => true
]);

Hope this will help you.

@devansh-webkul yes I noticed that too, however delete endpoint is not the one which delete item from the wishlists.
After I tried it yesterday, it seems that sending get request to add endpoint with the product I'd remove the item if it exists and add it otherwise.
Also I noticed that the configurable products is not being added to the wishlists even after I received that they are successfully added

I will check that and will update when I am working on the docs.


Feat: ng add angularfire2

If not already in pipeline it would be great to be able to add the angularfire 2 package by a simple ng add angularfire2.

I've been working with schematics for AF2 and have the following proposals. Please post ideas and feedback so we can get the ball rolling:

ng add angularfire2/schematics

Updates the NgModule with imports, initializeApp, and credentials
Installs anglarfire2 & firebase

ng generate component --firestore --auth

Generates a component with Firestore and AfAuth injected + some starter code
Mocks firebase in the component spec

ng generate module --template <crud|login|forms>

Generates a fully fleshed-out feature module based on a goal like CRUD, user auth, forms, etc. The idea is here is to provide a best practices example to be used as a starting point or just solve common problems. (This will be the most difficult schemtic to build and maintain)

Hey, I think it would be great to start even (or: especially) with having ng add angularfire2 command available that would

install the module
prepare configuration object to be filled
and setup the module

If you're opened to it, I would gladly help with this one (I've already prepared analogous part on other projects)

@sulco That would be amazing. I've not had the time recently to move this forward. Just having ng add would be a valuable addition.

Great, I'm on it then - should have a PR within the next couple of days.

Heya, @sulco any updates on this? I can help if you have any problems :)

@sulco I'm also willing to help out with this if needed.


feature: update integration test with supernode from java to go

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #556 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage      52%   52.01%   +0.01%
==========================================
  Files          83       83
  Lines        4490     4489       -1
==========================================
  Hits         2335     2335
+ Misses       2001     2000       -1
  Partials      154      154

Impacted Files
Coverage Δ

supernode/plugins/plugins.go
100% <100%> (ø)
:arrow_up:

supernode/daemon/mgr/scheduler/manager.go
24.8% <0%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a815ce0...378958f. Read the comment docs.

I think that it's better to remain the java version of supernode until the golang version is completely ready.

It's not an interesting thing. And I will close it firstly and open it again when the golang version is ready. 😄


AMP doc bug

https://github.com/snowplow/snowplow/wiki/Google-AMP-Tracker
unstructEvent for structured event tracking
should be:
structEvent for structured event tracking

Ouch, thanks, @ihortom can you fix please!

Done.


Fix auto-assign

Resolves #131.
Actions that require write permissions to the repo (e.g. creating an issue, assigning reviewers, etc.) does not work on forks if pull_request is the trigger as the GITHUB_TOKEN only has read-access. By switching this to pull_request_target, the token has read/write access. Functionally, the same as pull_request with the added ability to run on forks.
Note: Would avoid using pull_request_target unless necessary. Here's a long video that goes into a bit of detail about github actions and pull requests.

Tried to quickly fix it by replacing pull_request with pull_request_target, but it seems to just skip the reviewer assignment now. When this PR is ready, I'll mark it ready for review

Should be ready for review now.
Tested it by creating a PR from @tkkuehn's fork to my own fork here. Note that the reviewer can't actually get assigned in this test as none of the other listed users are collaborators on my fork. Workflow was still able to run and assign an author however.


feat: 🎸 Update default to use chain v5.0.3

Description
Removes support for 4.x versions, as they were broken due to the images being removed from docker hub. Also updates the default REST API to v0.1.0
Breaking Changes

chain version 4 is no longer supported

JIRA Link
DA-428
Checklist

[ ] Updated the Readme.md (if required) ?

Not directly related to this PR, but https://github.com/PolymeshAssociation/polymesh-local/blob/master/scripts/build-uis.ts#L21 can be updated to the PolymeshAssociation repo https://github.com/PolymeshAssociation/governance-web.

Thanks @adamdossa . I updated that reference, removed the deprecated upload script, and added a blurb in the README to document the process a bit better.

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v5.0.0
v5.0.0

Your semantic-release bot :package::rocket:


Fix typos and trailing whitespace

I adapted this from the one in the .github repo

Workflows in .github don't seem to have these issues.


Train with one's own dataset

Hi, I wonder how I can get the corresponding .yaml file (like ljspeech.yaml) when I'm working on my own dataset. In addition, have you tested the performance of Matcha-TTS for other languages like Chinese and is a relatively small dataset (like a 20-min dataset) okay? Thank you very much!

Hello! Thank you for your interest in 🍵 Matcha-TTS.

I wonder how I can get the corresponding .yaml file (like ljspeech.yaml) when I'm working on my own dataset.

For training with a different dataset, most parameters would be the same as ljspeech.yaml.  So you can essentially just copy that.Generally, I prefer resampling all my audio files to 22050 sampling rate instead of changing the audio parameters, as this solves the problem of finding a different vocoder.
Then, You can generate mean and standard deviation for your dataset (for better standardisation) using these steps I have added in README.md.
The major changes you would require:
In YOUR_DATASET.yaml
name: NAME_YOUR_DATASET_ANYTHING_ARBITRARY
train_filelist_path: NEW_FILEPATHS
valid_filelist_path: NEW_FILEPATHS
data_statistics:
  mel_mean: <generate (better) or use lj_speech's value>
  mel_std: <generate (better) or use lj_speech's value>
cleaners: [?chinese_cleaner? ] # you will need to setup text normalisation rules as stated below

You can take a look at vctk.yaml and do something similar, use the defaults from ljspeech.yaml and override what you need for your specific dataset.
For phonemisation: (again, I have no experience in training with Chinese dataset but you can change the phonemizer language here, I think for mandarin it is zh with espeak backend and cmn with espeak-ng backend.
https://github.com/shivammehta25/Matcha-TTS/blob/2cd057187b8002afd1916ee8499474be05b55104/matcha/text/cleaners.py#L28

Have you tested the performance of Matcha-TTS for other languages like Chinese

I haven't tried it. However, I do not see any reason for it to perform poorly as long as the alignment problem is monotonic.

Is a relatively small dataset (like a 20-min dataset) okay?

Again, I haven't tested it but the Monotonic alignment is very useful for jointly learning to speak and train. Even with a small dataset (especially if it is a studio-recorded dataset of read speech). I feel It depends largely on the dataset quality and the possibility of aligning it monotonically.  However, fine-tuning should mostly work better than training from scratch in such scenarios, so, you can first train on a larger Chinese dataset and then fine-tune it for your specific one.
Something similar to what we did for OverFlow and it worked very well.
Hope this answers your questions :)

Closing this issue for now. Feel free to reopen it incase of any further questions.


The license file is missing in the distribution

$ ls node_modules/ipaddr.js/
README.md	ipaddr.min.js	lib		package.json

I'm not sure how this is possible as all recent versions of npm publish force including the license file automatically. However, this results in the package distribution on npm to be a proprietary, unlicensed code, which nobody who cares about licensing can use as it would be theft against copyright.
@whitequark Could you please make sure the license gets published as well and make a patch version to get this change virally to all projects depending on ipaddr.js? Thanks!

@whitequark It might just be enough to do npm publish with npm version >3.7.4 (IIRC) which should take the LICENSE file and bundle it along the rest of the contents appropriately. You can check the result by specting the tarball you get from running the npm pack command.

This worked, thanks.
v1.9.0 released.


Gift Entry: Move Data Import Telemetry to SObject Batch

Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch: attach W-040424

Tracking W-040424


Add COSMOS (ATOM)

Currency name: COSMOS
Symbol: ATOM
Website: https://cosmos.network
Theme color: #2e3148
Logo (SVG): atom-logo-svg.zip

Please follow the issue template instructions.

Updated

The attached SVG is not valid. It's just an SVG that links to a bitmap image.

Updated, think its good now.

Yup


Bluetooth: Host: bt_conn_process_tx() does not release TX buffers when connection state is BT_CONN_DISCONNECT_COMPLETE

Describe the bug
We have a peripheral BLE device based on Zephyr RTOS and another central one is based on iOS (iPhone mobile app).
The central sends a write request command (), and without waiting for the response drops the connection. This is the trace:
2122	14.507	Master_0xaf9a84ad	LE 2M	ATT	9	29763µs	0	0	False	51	Sent Write Request, Handle: 0x0013 (Unknown: Unknown: Client Characteristic Configuration)
2123	14.507	Slave_0xaf9a84ad	LE 2M	LE LL	0	149µs	0	1	False	51	Empty PDU
2124	14.537	Master_0xaf9a84ad	LE 2M	LE LL	2	29727µs	1	1	False	52	Control Opcode: LL_TERMINATE_IND
2125	14.537	Slave_0xaf9a84ad	LE 2M	LE LL	0	149µs	1	0	False	52	Empty PDU
On the peripheral side (Zephyr), the BLE host processes the write request command, creates a write response frame, and stores it in the TX queue. It looks like there is a timing or connection state machine issue, resulting in not releasing the net buffer (write response).
In the function bt_conn_process_tx() a connection is cleaned up only when the state is BT_CONN_DISCONNECTED. In our case sometimes this function is called when the state is BT_CONN_DISCONNECT_COMPLETE. In such a scenario the connection is not cleaned up, the function tries to process buffer from the TX queue, and send_buf() returns -128 (disconnected). With this error code, the function simply returns, leaving the buffer in the TX queue.  In such a situation buffer with 'write response' is not released, and finally, acl_tx_pool can be left empty making new connections unusable.
To investigate the problem I added an additional log to bt_conn_process_tx() function:
void bt_conn_process_tx(struct bt_conn *conn)
{
	struct net_buf *buf;
	int err;

	LOG_DBG("conn %p", conn);

	if (conn->state == BT_CONN_DISCONNECTED &&
	    atomic_test_and_clear_bit(conn->flags, BT_CONN_CLEANUP)) {
		LOG_DBG("handle %u disconnected - cleaning up", conn->handle);
		conn_cleanup(conn);
		return;
	}

	/* Get next ACL packet for connection. The buffer will only get dequeued
	 * if there is a free controller buffer to put it in.
	 *
	 * Important: no operations should be done on `buf` until it is properly
	 * dequeued from the FIFO, using the `net_buf_get()` API.
	 */
	buf = k_fifo_peek_head(&conn->tx_queue);
	BT_ASSERT(buf);

	/* Since we used `peek`, the queue still owns the reference to the
	 * buffer, so we need to take an explicit additional reference here.
	 */
	buf = net_buf_ref(buf);
	err = send_buf(conn, buf);
	net_buf_unref(buf);

	LOG_INF("bt_conn_process_tx(): send_buf() -> %d, conn->state -> %d", err, conn->state);
	if (err  == -EIO) {
		struct bt_conn_tx *tx = tx_data(buf)->tx;

And from time to time I can see this is the trace:
I: bt_conn_process_tx(): send_buf() -> -128, conn->state -> 1
To Reproduce
The problem was discovered on STM32WB55RG Nucleo. It is hard to reproduce it as this is a kind of timing issue. To reproduce it is required to simulate a call of bt_conn_process_tx() when the connection state is BT_CONN_DISCONNECT_COMPLETE.
Expected behavior
Buffers from conn->tx_queue should always be properly released.
Impact
When all buffers from acl_tx_pool have been used but not freed, even if the BLE connection can be opened it cannot be used to communicate over GATT.
Logs and console output
I: bt_l2cap_create_pdu_timeout():644: pool 0x20012824 size 526
I: allocated buf 0x2000af58
I: bt_ipm_send():393: buf 0x2000af58 ref 2 pool_id 0 frags (nil)
I: bt_conn_process_tx():941: buf 0x2000af58 ref 1 pool_id 0 frags (nil)
I: bt_conn_process_tx(): send_buf() -> 0, conn->state -> 7
I: bt_l2cap_create_pdu_timeout():644: pool 0x20012824 size 526
I: allocated buf 0x2000af58
D: CCC is being written from connection 0x20002378, attribute 0x200002dc, value 0
I: GATT unsubscribed so the connection is being closed.
D: CCC notify - attribute 0x200002dc, value 0
I: bt_conn_process_tx():941: buf 0x2000af58 ref 2 pool_id 0 frags (nil)
I: bt_conn_process_tx(): send_buf() -> -128, conn->state -> 1
D: Disconnected (reason 19)
Environment (please complete the following information):

OS: Linux, mobile application acting as a central on iPhone 12 mini, iOS 16.6.1
Zephyr SDK 0.15.1
Zephyr 3.4

Additional context

Another idea is that the issue might be because of a non-atomic transition in conn_destroy() from BT_CONN_DISCONNECTING to BT_CONN_DISCONNECTED. See this:
static void conn_destroy(struct bt_conn *conn, void *data)
{
if (conn->state == BT_CONN_CONNECTED ||
conn->state == BT_CONN_DISCONNECTING) {
bt_conn_set_state(conn, BT_CONN_DISCONNECT_COMPLETE);
}
bt_conn_set_state(conn, BT_CONN_DISCONNECTED);

}

An additional trace:
I: bt_l2cap_create_pdu_timeout():644: pool 0x20012824 size 526
I: allocated buf 0x2000af58
I: bt_conn_set_state(): 0x20002378, disconnect-complete, 0x20002848
I: bt_conn_process_tx(): conn 0x20002378, conn state: disconnect-complete, 0x20001fd0
I: bt_conn_process_tx():953: buf 0x2000af58 ref 2 pool_id 0 frags (nil)
I: send_buf(): result -128
I: bt_conn_set_state(): 0x20002378, disconnected, 0x200020a0
I: bt_conn_set_state(): 0x20002378, connecting-adv, 0x20001dd8
I: [0x20001800] BLE connection closed - 0x20002378

And the list of threads:

In this line:
bt_conn_set_state(): 0x20002378, disconnect-complete, 0x20002848

the last value is k_tid_t, so this means this is bt_ipm_rx_thread.
Same for this line:
I: bt_conn_process_tx(): conn 0x20002378, conn state: disconnect-complete, 0x20001fd0

the last value is k_tid_t, so this means this is hci_tx_thread.

@watsug thanks for the thorough analysis. Based on your understanding of the issue, can you please open a Pull Request with a suggested fix so that @jhedberg but also others can have a chance to review it?

@carlescufi
Sure, I will prepare a PR right of the beginning of the next week.

@carlescufi Sure, I will prepare a PR right of the beginning of the next week.

Thank you!

@watsug are you still planning on posting a PR for this?

@theob-pro I had something urgent in the meantime, but I am going to create PR today.

So here's my analysis:
Starting from when the host receives the DISCONNECT_COMPLETE event.

driver calls bt_recv
bt_recv processes the disconnect event immediately and puts it in the event RX queue
hci_disconn_complete_prio sets the state to BT_CONN_DISCONNECT_COMPLETE
bt_conn_process_tx runs, tries and fails to send the buffer. As you said, the buf is not popped from the queue. This can end up leaking the buffers/metadata because we don't check for disconnected before popping the buf from the queue
send_buf returns, buf still has one ref. Maybe it's still in the queue, maybe not (e.g. if it's a fragment)
hci_disconn_complete runs, puts the conn into BT_CONN_DISCONNECTED
this transition sets the BT_CONN_CLEANUP bit
bt_conn_process_tx runs again, this time the stars are aligned (right bit and conn state) and conn_cleanup is called

So I think this is correct, you did find a leak, thanks! I'll approve the PR.

Regarding

Is the transition from BT_CONN_CONNECTED to BT_CONN_DISCONNECT_COMPLETE proper

I don't have anymore insight than you on this, but it points to a commit addressing priority in handling the disconnected event.


Improve CI - test on more versions, install final package for validation, test on more linux distros

The ideal state of CI would be the following:

Install the package on Windows, Linux and macOS
Target supported Unreal versions

Run CI on the oldest, supported version: https://github.com/getsentry/sentry-unreal/issues/661 (we might want to check with Data whether this is an issue in the first place but based on the inquiries we're getting it does not seem we can skip 4.27)
Prevent dependency related regressions. I.e. run on Amazon Linux https://github.com/getsentry/sentry-unreal/issues/635

Run
Build a sample project on those platforms for all supported target platforms: Android, iOS, Windows, Linux, and macOS
Run those artifacts as integration/smoke test https://github.com/getsentry/sentry-unreal/issues/77

This can be broken down, prioritizing Windows/Linux setup and builds.

Prevent dependency related regressions. I.e. run on Amazon Linux https://github.com/getsentry/sentry-unreal/issues/635

Can this be done by creating docker images using different distros as the base OS?

Can this be done by creating docker images using different distros as the base OS?

I've followed this approach when testing Amazon Linux thing locally so there shouldn't be any blockers for doing that in CI.


Xamarin.Forms element wrapper state

List of Xamarin.Forms elements that are available in Experimental Forms binding for Blazor.
Note: Some elements have been wrapped, but not all of their properties have been implemented.

[ ] BindableObject

[x] Element

[x] Application
[ ] Cell

[ ] EntryCell
[ ] SwitchCell
[ ] TextCell

[ ] ImageCell

[ ] ViewCell

[x] GestureElement

[x] Span

[x] FormattedString
[x] BaseMenuItem

[x] MenuItem

[x] NavigableElement

[x] BaseShellItem

[x] ShellContent
[x] ShellGroupItem

[x] ShellItem

[x] FlyoutItem
[x] TabBar

[x] ShellSection

[x] Tab

[x] VisualElement

[x] View

[x] ActivityIndicator
[x] BoxView
[x] Button
[x] CheckBox
[x] DatePicker
[x] Image (https://github.com/xamarin/Emblazon/issues/10)
[x] ImageButton
[x] InputView

[ ] Editor
[x] Entry
[ ] SearchBar

[ ] ItemsView

[ ] CarouselView
[ ] StructuredItemsView

[ ] SelectableItemsView

[ ] GroupableItemsView

Hi @Eilon
I see CollectionView is on your list... how high is it on your list of priorities?
Performant lists are essential for most mobile applications and CollectionView is the recommended approach these days in XF.
I see you have used a StackLayout in a ScrollView in some of the samples - I guess this maps most easily to the HTML list concept and the data loading pattern in Blazor. But I wonder will this scale to large lists of items or even infinite scrolling lists?
I have also been wondering how the usual XF pattern of having an ObservableCollection of items databound as the ItemsSource of a layout would translate to the web paradigm that Blazor comes from?
For example, in the Xaminals sample, lists are populated like so:
 <ScrollView>
        <StackLayout>
            @foreach (var animal in MobileBlazorBindingsXaminals.Data.MonkeyData.Monkeys)
            {
                <AnimalTemplate Animal="animal" />
            }
        </StackLayout>
    </ScrollView>

and Monkeys is an IList. Now if Monkeys were an ObservableCollection, and I added a Monkey, what would happen? Would all the list items be recreated, or none of them, or only the new one?
I totally love the Blazor approach and I really hope it can become a first class way of building XF apps.

Hi @freever thank you for the question. CollectionView is high on my list in terms of interest, but also high on my list in terms of complexity, so unfortunately this means it's not clear when it will happen. It is complex because it uses Xamarin.Form's templates, which I've had a difficult time trying to map to the Blazor world. I've made a few attempts but kept getting stuck.
As to the other parts of your question:
Blazor binding can be very efficient. If you have a list with 10 items in it and then add an 11th item, only the new controls needed for the new 11th item will be created. All the first 10 controls will be untouched. Currently in Mobile Blazor Bindings there are some more advanced internals that are not yet implemented that make it more efficient when you insert into the middle of a list. It'll work fine as things are, but not at maximum efficiency. As to ObservableCollection, there is generally no need for that in the Blazor world because Blazor works based on diffing, not reactive observations.
And for infinite scrolling, there are some neat approaches people have used with Blazor for the Web ("regular Blazor") that I'm hoping I can map to the world of Mobile Blazor Bindings. Haven't looked too deeply into it yet though.

That is really interesting. I did some hasty reading up on Blazor collections and apparently if you apply the @key attribute to each  that contains a component and map it to the backing model then Blazor will compare the existing  with the new  generated on state changes and only apply changes if there is a diff. That resolves a question I had about how Blazor knows whether to change, remove or add an item in a collection without re-rendering the whole thing each time.
It's an interesting challenge, applying Blazor to mobile, because the paradigms are so different. If you take away the INotifyPropertyChanged MVVM paradigm (which Blazor does) then Xamarin Forms becomes a completely different animal - probably a much easier one to code and reason about, and possibly more performant too.
Anyway, thanks for your response and well done on the work so far, I really like it!

Yup, in Blazor @key is the trick to high-performing collection updates, but I don't think it works in Mobile Blazor Bindings yet. (Maybe it does work, but I haven't tried, and I think I left out the part that would make it work.)
Indeed, the INotifyXyz and MVVM patterns are a negative for some people - particularly those who like Blazor's patterns. That's why we have this project!

+1 for carousel and collectionview

I think this project is awesome!! Did a lot with normal blazor, now this was exactly what I was looking for to do mobile development


Need custom fields in Company Export.

Describe the bug
We should give option to user to choose which custom fields he/she wants to export with company, contact and Project data.

Added "PAN" in Company Export with PAN Custom Field Name

Now exporting All Custom Field with Company as Sub Type, Company-Service type is added to Simple Export


[Enhancement] active mv automatically

Fixes #issue
Introduce a daemon thread MVActiveChecker:

Try to activate MV, if it's not set to inactive manually
The default check interval is 1 minute, user could modify it through admin set frontend config('mv_active_checker_interval_seconds'='300')

Use case:

The base table of MV could be dropped and created everyday, for Hive external table
Without this mechanism, user need to activate it in the workflow, which is tedious

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 40 / 48 (83.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/alter/AlterJobMgr.java
0
1
00.00%
[299]

:large_blue_circle:
com/starrocks/scheduler/MVActiveChecker.java
36
43
83.72%
[53, 54, 87, 88, 104, 105, 106]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
3
3
100.00%
[]

@Mergifyio rebase

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 41 / 48 (85.42%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/MVActiveChecker.java
36
43
83.72%
[53, 54, 87, 88, 104, 105, 106]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/AlterJobMgr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
3
3
100.00%
[]

can we add a logic to active mv during mv refresh?

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 44 / 51 (86.27%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/scheduler/MVActiveChecker.java
36
43
83.72%
[53, 54, 87, 88, 104, 105, 106]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/common/Config.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/AlterJobMgr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
3
3
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


v0.2.12

Deploy preview for affectionate-nobel-f3a8ec processing.
Built with commit f1cb62eb1e90a7d0f5ff52d0a1077b647a98af09
https://app.netlify.com/sites/affectionate-nobel-f3a8ec/deploys/5baa54ede39e7c3b7564e2b4


[SPARK-13926] Automatically use Kryo serializer when shuffling RDDs with simple types

Because ClassTags are available when constructing ShuffledRDD we can use them to automatically use Kryo for shuffle serialization when the RDD's types are known to be compatible with Kryo.
This patch introduces SerializerManager, a component which picks the "best" serializer for a shuffle given the elements' ClassTags. It will automatically pick a Kryo serializer for ShuffledRDDs whose key, value, and/or combiner types are primitives, arrays of primitives, or strings. In the future we can use this class as a narrow extension point to integrate specialized serializers for other types, such as ByteBuffers.
In a planned followup patch, I will extend the BlockManager APIs so that we're able to use similar automatic serializer selection when caching RDDs (this is a little trickier because the ClassTags need to be threaded through many more places).

Test build #53283 has started for PR 11755 at commit 876f038.

Test build #53287 has started for PR 11755 at commit ca923b5.

Test build #53283 has finished for PR 11755 at commit 876f038.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53283/
Test FAILed.

Test build #53287 has finished for PR 11755 at commit ca923b5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53287/
Test FAILed.

Test build #53302 has started for PR 11755 at commit 51205ee.

Test build #53302 has finished for PR 11755 at commit 51205ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53302/
Test PASSed.

LGTM

Test build #53353 has started for PR 11755 at commit 45b0c0b.

Test build #53353 has finished for PR 11755 at commit 45b0c0b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  class DecisionTreeClassificationModelWriter(instance: DecisionTreeClassificationModel)
  class DecisionTreeRegressionModelWriter(instance: DecisionTreeRegressionModel)
  case class SplitData(
  case class NodeData(
class Estimator(Params):
class Transformer(Params):
class Model(Transformer):
class LogisticRegressionModel(JavaModel, MLWritable, MLReadable):
class NaiveBayesModel(JavaModel, MLWritable, MLReadable):
class PipelineMLWriter(JavaMLWriter, JavaWrapper):
class PipelineMLReader(JavaMLReader):
class PipelineModelMLWriter(JavaMLWriter, JavaWrapper):
class PipelineModelMLReader(JavaMLReader):
  case class SQLTable(

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53353/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #53362 has started for PR 11755 at commit 45b0c0b.

Test build #53362 has finished for PR 11755 at commit 45b0c0b.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  class DecisionTreeClassificationModelWriter(instance: DecisionTreeClassificationModel)
  class DecisionTreeRegressionModelWriter(instance: DecisionTreeRegressionModel)
  case class SplitData(
  case class NodeData(
class Estimator(Params):
class Transformer(Params):
class Model(Transformer):
class LogisticRegressionModel(JavaModel, MLWritable, MLReadable):
class NaiveBayesModel(JavaModel, MLWritable, MLReadable):
class PipelineMLWriter(JavaMLWriter, JavaWrapper):
class PipelineMLReader(JavaMLReader):
class PipelineModelMLWriter(JavaMLWriter, JavaWrapper):
class PipelineModelMLReader(JavaMLReader):
  case class SQLTable(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53362/
Test FAILed.

Jenkins, retest this please.

Test build #53365 has started for PR 11755 at commit 45b0c0b.

Test build #53365 has finished for PR 11755 at commit 45b0c0b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  class DecisionTreeClassificationModelWriter(instance: DecisionTreeClassificationModel)
  class DecisionTreeRegressionModelWriter(instance: DecisionTreeRegressionModel)
  case class SplitData(
  case class NodeData(
class Estimator(Params):
class Transformer(Params):
class Model(Transformer):
class LogisticRegressionModel(JavaModel, MLWritable, MLReadable):
class NaiveBayesModel(JavaModel, MLWritable, MLReadable):
class PipelineMLWriter(JavaMLWriter, JavaWrapper):
class PipelineMLReader(JavaMLReader):
class PipelineModelMLWriter(JavaMLWriter, JavaWrapper):
class PipelineModelMLReader(JavaMLReader):
  case class SQLTable(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53365/
Test PASSed.

Merging in master!


[Feat] #21 - advanced mission donation

Change Log
Add Mission Donation Event

Add on_mission_pending event
Add on_mission_rejected/approved event
Add on_mission_complete event
Divide data class struction donation.py from message.py
Fix wrong literial type (MissionDontationExtra)

Issue Number

closed #21

Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)

(PATL) Test required. (until '24.11.10.)

Test Completed. All event handler worked.
@client.event
async def on_mission_complete(mission: MissionDonation):
    print("mission_completed", mission.mission_text)
    return

@client.event
async def on_mission_pending(mission: MissionDonation):
    print("mission_pending", mission.mission_text)
    return

@client.event
async def on_mission_approved(mission: MissionDonation):
    print("mission_approved", mission.mission_text)
    return

@client.event
async def on_mission_rejected(mission: MissionDonation):
    print("mission_rejected", mission.mission_text)
    return


Update README.md - fix one grammatical error.

I have noticed one grammatical mistake in README inside section "Hiring"
"classification, clustering and semantic search."  should be "classification, clustering, and semantic search."
Screenshot-

Please review my PR.

Thank you.


Fix for 464: include zero in ct:value

Changes

ct:value attribute of line.ct-point in Line charts no longer omits 0 values
ct:value attribute of line.ct-bar in Bar charts no longer omits 0 values

I'm not completely sure if this change is appropriate for Bar chart but it seemed like it. I can remove that from PR if it should not be in there.
Fixes #464

Awesome piece of work! Cheers Paul!


elmPackages.*: add meta

Motivation for this change
elmPackages were missing meta attributes. This PR adds all missing meta information for rest of the tooling to consume. This will be handy especially as nixos-search will soon be able to filter packages by license, maintainer etc https://github.com/NixOS/nixos-search/pull/261.
In the future we should also add platform information.
Things done
Added meta.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @domenkozar (I've added you as a maintainer of elm compiler)

@SuperSandro2000 I went through meta again and shorten the description. I think it would be still fair to wait for @domenkozar and @avh4 before we merge this since I'm declaring them as maintainers without consulting them first. Thanks for the review!

@SuperSandro2000 I went through meta again and shorten the description. I think it would be still fair to wait for @domenkozar and @avh4 before we merge this since I'm declaring them as maintainers without consulting them first. Thanks for the review!

It turned out Aaron is not in maintainers list - removing.

It turned out Aaron is not in maintainers list - removing.

:+1: I'm fine either way.  (For the record, I still plan to submit a nixpkg PR each time there's a new elm-format version, as I've been doing for a while now.)

:+1: I'm fine either way.  (For the record, I still plan to submit a nixpkg PR each time there's a new elm-format version, as I've been doing for a while now.)


[Request] 1.16.x support

The mod crashes the server when I start with the 1.15 version (expected), will there be an update? Several players on my server rely on this.

Try the 1.16 build.

https://www.curseforge.com/minecraft/mc-mods/simpleharvest/files/2989916
Not really sure what would have caused it to crash as nothing seemed out of place in dev, but there we go.


Need to change FSCalendarHeaderCell titlelabel text

Anyway to do this without a hack?

Why would you do that?


GitHub Class - Add docstring to each method of all the classes

+Reference line of the issue - https://github.com/Clueless-Community/scrape-up/blob/c7ac4c8a842b9e2fb43f25257cd3902a0a8625f8/src/scrape_up/github/issue.py#L11

Add docstring to the class and each of its methods(except the private ones)
A perfect docstring looks like

can I work on this?

Already assigned you two issues, make a PR for them at first :))

@nikhil25803 plz assign this issue

@nikhil25803 kindly assign this issue to me

Sure @Shreya111111 go ahead, make sure you add docstring to all the classes :))


Support Xiaomi Smart Door Lock with Face Unlock(without X)

Add the BLE Spec lock data parse and 6017 converter to support the Xiaomi Smart Door Lock with Face Unlock(without X)
BLE code:6017, device model: XMZNMS09LM
miot-spec

Oh. I can see examples in #874
They will be enought.


Particular audio stream not working on Android

Question
I am creating a simple radio streaming app with only a play and pause button to play a streaming url. React-native-video seemed the best way to go, and it is working for most streams I can find, but of course the particular stream I use doesn't work. On Android that is. On iOS it is working like it should.
I have 4 urls for this one stream, but none of them are working.
http://www.goedkoopstreamen.nl/luister/klmopen/mp3/
http://www.goedkoopstreamen.nl/luister/klmopen/pls/
http://www.goedkoopstreamen.nl/luister/klmopen/wm/
http://www.goedkoopstreamen.nl/luister/klmopen/real/
http://www.goedkoopstreamen.nl/luister/klmopen/ipad/
This is just about all of my code. The commented uri-s are the ones that are working, but the uncommented doesn't. Is it just a falty stream or are there any other things I could try?
<Video source={{
uri: "http://klmopen.gkstreamen.nl/listen.pls",
//uri: "http://icecast.omroep.nl/radio1-bb-mp3",
}}
ref={component => (this._video = component)}
paused={this.state.paused}
playInBackground={true}
onBuffer={this.onBuffer}                // Callback when remote video is buffering
onError={this.videoError}               // Callback when video cannot be loaded
style={styles.backgroundVideo} />

hello @Nikooos ,
sometimes it helps (when no extension present) to provide explicitly a mimetype, specially for android.
Can you try setting source object like this?
source0{{uri: "http://www.goedkoopstreamen.nl/luister/klmopen/mp3/", type: "m3u8"}}

Sounded pretty good.. Unfortunately didn't get my stream up and going.
I'm getting the following error:
2019-07-05 09:15:16.916 29643-29855/com.klmopenradio E/ExoPlayerImplInternal: Source error.
com.google.android.exoplayer2.source.hls.playlist.HlsPlaylistTracker$PlaylistStuckException
at com.google.android.exoplayer2.source.hls.playlist.DefaultHlsPlaylistTracker$MediaPlaylistBundle.processLoadedPlaylist(DefaultHlsPlaylistTracker.java:619)
at com.google.android.exoplayer2.source.hls.playlist.DefaultHlsPlaylistTracker$MediaPlaylistBundle.onLoadCompleted(DefaultHlsPlaylistTracker.java:500)
at com.google.android.exoplayer2.source.hls.playlist.DefaultHlsPlaylistTracker$MediaPlaylistBundle.onLoadCompleted(DefaultHlsPlaylistTracker.java:425)
at com.google.android.exoplayer2.upstream.Loader$LoadTask.handleMessage(Loader.java:450)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.os.HandlerThread.run(HandlerThread.java:65)
Seems to be troubles with the exoplayer?

I dunno if I should have access to the resource, or it is private, but...
http://www.goedkoopstreamen.nl/luister/klmopen/mp3/
return a m3u8 playlist
#EXTM3U
#EXTINF:0, klmopen
http://klmopen.gkstreamen.nl:80

That points to http://klmopen.gkstreamen.nl:80 which seems it is not responding.

It's not private, so no problem.
I've been complaining about the resource but they don't seem to be able to change anything to make my life easier about this.
However it does work when I just tap the link and open it in my browser. So that's their argument that there's nothing wrong with the stream. So I'm about to give up on this.

Yep, they seem to handle redirects in a kinda tricky way.
They allow you to change the streaming port? I think 80 is maybe interfering

I'm getting like

This device does not provide audio/ac3 codec


Add the tutorials in the doc

Add the tutorial and the link to the docker images in the doc.

Link was added in the README


sts: NotImplementedError: The assume_role_with_web_identity action has not been implemented

Description
The current master does not implement the assume_role_with_web_identity endpoint of STS.

Closed with https://github.com/spulec/moto/pull/2313


Qs: Linking to notes

Is there any way to link the nodes to notes? Loving how easy this is to use but being able to make the nodes clickable would really make this the perfect solution.

No not at the moment and I'm quite busy so no plans for the future. But feel free to try to make it!


convert test tool to new diagnostics apis

motivation: adapt new diagnostics apis
changes:

refactor SwiftTestTool to use new diagnostics api, including relevant scopes and timer measuring duration of tests
de-dupe the test function

requires #3751

superseded by #3779


If downstream has "Connection: close" in header, upstream connection will be closed too

Your question
"Connection: xxx" header will be removed in:
        // clear 'Connection:close' header for keepalive connection with upstream
	if headers.ConnectionClose() {
		headers.Del("Connection")
	}

And in the same time, we set
+               // save the connection state, because clientStream AppendHeaders will modify it.
+               if s.header.ConnectionClose() {
+                       s.connection.close = true
+               }

So I am wondering out purpose is to keep-alive with upstream or not

func (s *serverStream) endStream() {
	resetConn := false

	// Response.Write() skips writing body if set to true.
	// Use it for writing HEAD responses.
	if s.request.Header.IsHead() {
		s.response.SkipBody = true
	}

	// check if we need close connection
	if s.connection.close || s.request.Header.ConnectionClose() {
		// should delete 'Connection:keepalive' header
		if !s.response.ConnectionClose() {
			s.response.Header.Del("Connection")
			s.response.SetConnectionClose()

The purpose of setting close to true is to close downstream， not to close upstream.

func (s *serverStream) endStream() {
	resetConn := false

	// Response.Write() skips writing body if set to true.
	// Use it for writing HEAD responses.
	if s.request.Header.IsHead() {
		s.response.SkipBody = true
	}

	// check if we need close connection
	if s.connection.close || s.request.Header.ConnectionClose() {
		// should delete 'Connection:keepalive' header
		if !s.response.ConnectionClose() {
			s.response.Header.Del("Connection")
			s.response.SetConnectionClose()

The purpose of setting close to true is to close downstream， not to close upstream.

Yes, I misunderstood. In my case, the actual cause of the upstream connection being closed is that the upstream request is still http1.0 protocol while in older version of MOSN it will be changed to http1.1 protocol

In older version of fasthttp,  the protocol str is default set to HTTP/1.1
func (h *RequestHeader) AppendBytes(dst []byte) []byte {
	dst = append(dst, h.Method()...)
	dst = append(dst, ' ')
	dst = append(dst, h.RequestURI()...)
	dst = append(dst, ' ')
	dst = append(dst, strHTTP11...)
	dst = append(dst, strCRLF...)

In new version of fasthttp changed to:
dst = append(dst, h.Protocol()...)
...
// Protocol returns HTTP protocol.
func (h *RequestHeader) Protocol() []byte {
	if len(h.proto) == 0 {
		return strHTTP11
	}
	return h.proto
}

I think we should force rewrite protocol to 1.1 if we want keep-alive with upstream

@dengqian  I approve of you,  welcome~


Adding sleep flag to pod-template

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

What this PR does / why we need it:
Adding the --sleep flag to the pod-template as its specified in the values.yaml
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] CHANGELOG.md updated

Welcome @mikescholl-sysdig! It looks like this is your first PR to falcosecurity/charts 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mikescholl-sysdig
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

HI @mikescholl-sysdig, thanks for your contribution!

LGTM label has been added.  Git tree hash: 6f98fc59fe2d7307203a9ca19fa49332ef24c8dc

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, mikescholl-sysdig
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


getIn (prop keypaths)

Facebook's immutable has a nifty getIn method for grabbing a value at a key path:
myMap.getIn(["a", "b", "c"], defaultValue)

I find myself piping together lots of prop calls to accomplish something similar:
R.map(R.pipe(R.prop("id"), R.prop("name")), vars)

I made for myself something like getIn:
R.map(R.getIn(["id", "name"]), vars)

If this is something others could want I could make a pull request.

@tolmasky Do you want to create a PR for this?

Hi yeah sorry, I need to split this out from my stuff and submit it. I'll
attempt do it this weekend
On Thursday, January 8, 2015, Scott Sauyet<EMAIL_ADDRESS>wrote:

@tolmasky https://github.com/tolmasky Do you want to create a PR for
this?
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/issues/637#issuecomment-69286299.

--
Francisco Tolmasky
www.tolmasky.com
<EMAIL_ADDRESS>

Just providing an update, this touched a couple other functions so I'm just updating all the tests.

Thanks for the update.
I look forward to seeing it (even if a little sad about losing the old API.)

Moving this to 0.10.0.  I don't think anyone is desperately waiting on it, and I think we really want to publish 0.9.0.

I like the string sugar. I can see both approaches having their use though.
I suppose if you implement the array then the string version can just be dotPath = compose(path, split('.'))

Sorry, know this is taking me forever. But another thing that comes to mind
is that there seems to be no reason to not just support both:
getin(path)
{
if (typeof path === string) return getin(split(“.”))
else …
}
Seems then it works the way everyone expects.
On Fri, Feb 6, 2015 at 3:46 PM, Jethro Larson<EMAIL_ADDRESS>wrote:

I like the string sugar. I can see both approaches having their use though.
I suppose if you implement the array then the string version can just be dotPath
= compose(path, split('.'))
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/issues/637#issuecomment-73334325.

--
Francisco Tolmasky
www.tolmasky.com
<EMAIL_ADDRESS>

:-1: on type-checking the arguments in the function. no reason the user can't path(split('.', str), obj).

I like the string sugar too.  I actually prefer it, even though I know it's not as general.  But I definitely wouldn't want the type-checking version.  We're trying to avoid that as much as we can in Ramda.  As @jethrolarson said, it's easy enough to compose, or add your own gloss atop the list version.

p = path.split ? path.split('.') : path;
It's not exactly type-checking.

I think the point is not about implementation but api. Ramda functions
don't take variable type inputs. Except for R.add, but that's probably an
oversight.
On Feb 6, 2015 7:51 PM, "Paul Grenier"<EMAIL_ADDRESS>wrote:

p = path.split ? path.split('.') : path;
It's not exactly type-checking.
—
Reply to this email directly or view it on GitHub
https://github.com/ramda/ramda/issues/637#issuecomment-73348356.

I think the point is not about implementation but api.

Exactly.  It's about what's simple as opposed to what's easy.  (And add just happens to fall out of the implementation; we don't advertise that it works on strings as well.)

@tolmasky ping


Add Coverage Profile To Reactor Pom

Using a coverage profile in the build action to ensure coveralls plugin runs with provided jaxb-api

:+1:


Check for service worker update on game start

Just in case user still has app open

Let's do this on visibility change to visible


feat: parallelizing VID polynomial evaluation

Description

closes: #494
On my local laptop (M1 pro), with payload size 1 << 25, payload_chunk_size = 256 and num_storage_nodes = 512.
Running with RAYON_NUM_THREADS=8.
Previous result for polynomial evaluation:
··Start:   encode payload bytes into polynomials
··End:     encode payload bytes into polynomials ...................................899.311ms
··Start:   compute all storage node evals for 4229 polynomials with 256 coefficients
··End:     compute all storage node evals for 4229 polynomials with 256 coefficients 1.026s

Now we have:
··Start:   encode payload bytes into polynomials
··End:     encode payload bytes into polynomials ...................................168.235ms
··Start:   compute all storage node evals for 4229 polynomials with 256 coefficients
··End:     compute all storage node evals for 4229 polynomials with 256 coefficients 80.797ms

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (main)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

Further improves bytes_to_polys, right now
··Start:   encode payload bytes into polynomials
··End:     encode payload bytes into polynomials ...................................44.674ms
··Start:   compute all storage node evals for 4229 polynomials with 256 coefficients
··End:     compute all storage node evals for 4229 polynomials with 256 coefficients 82.175ms


Request help in installing wazicloud

Dear Sir/Madam,
my name is Jean Louis NIRAGIRE, an IoT consultant in Rwanda,
I have full knowledge of Cloud dockers and images
Hereby requesting your guide to install Waziup Platform, as i repeatedly tried but the whole instance of the platform could not be up
https://drive.google.com/file/d/1dKldNhbLLMAMZSOt4k1D2E2a7kdGmwHt/view
https://drive.google.com/file/d/1GHiGoZIZNHEqTVeAWvOYvK_-C8AAATmE/view
PLEASE HELP ME
Whatsapp & Mobile: +(250)788248339

Are you shure this request is vue-storefront related? Please try to use our https://forum.vuestorefront.io to get help on that