Invalid 'expires' attribute?

ResponseProcessCookies:129 - Invalid cookie header: "Set-Cookie: ncbi_sid=73BE402676BBFF01_0927SID; domain=.nih.gov; path=/; expires=Fri, 23 Jun 2017 10:54:40 GMT". Invalid 'expires' attribute: Fri, 23 Jun 2017 10:54:40 GMT
When executing a GET I get this message, is it simply a server misconfiguration or something else going on?

Do you have the full stack trace for this error?

Just shows up as a warning here, no stack trace
2016-06-29 15:33:31 WARN  ResponseProcessCookies:129 - Invalid cookie header: "Set-Cookie: ncbi_sid=9DFD5C99773CE2B1_0917SID; domain=.nih.gov; path=/; expires=Thu, 29 Jun 2017 13:33:31 GMT". Invalid 'expires' attribute: Thu, 29 Jun 2017 13:33:31 GMT

Okay, since this is marked as fixed in 4.5, it should be fixed in the latest clj-http which uses a 4.5 version of the client.
What version of clj-http are you using? Does upgrading fix this?

Same problem here
using 3.1.0 of clj-http

Has anyone had a chance to try this with clj-http 3.3.0?

Confirm it still fails with 3.3.0:
Nov 06, 2016 9:19:57 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: fr=0ZcB4dEGC2q4MqVrd..BYH_Ld.Am.AAA.0.0.BYH_Ld.AWXCoUKJ; Expires=Sun, 5 Feb 2017 02:49:38 GMT; Path=/; Version=0". Invalid 'expires' attribute: Sun, 5 Feb 2017 02:49:38 GMT

Also still failing with the 3.5.0 version:
Apr 26, 2017 3:00:42 PM org.apache.http.client.protocol.ResponseProcessCookies processCookies
WARNING: Invalid cookie header: "Set-Cookie: user_id="2|1:0|10:1493211642|7:user_id|44:ZDQ0NmIxYmRjOTE0NDgxZjljNzFhZTMxNzBiYjkyZmU=|87307f9664bd33350c039cd1d5ecc3bb8782c68ec890ba4fde5150b57168cc12"; expires=Fri, 26 May 2017 13:00:42 GMT; Path=/". Invalid 'expires' attribute: Fri, 26 May 2017 13:00:42 GMT

Overriding the cookie-policy on the request to "standard" fixed the problem for me - in case anyone else has the same problem:
  (client/post login-url
    {:body (ch/generate-string {"email" "..." "password" "..."})
     :content-type :json
     :cookie-policy :standard
     :cookie-store cs
     :headers {"x-xsrftoken" (get-token)}})

As suggested in this thread on stackoverflow.

Confirmed, :cookie-policy :standard solves this.

You guys saved me a lot of wasted time. I've been all afternoon after this answer.
Thanks very much

I think I'm going to close this since there's a workaround for it (setting :cookie-policy :standard). Let me know if anyone disagrees and I'll re-open.

@dakrone Might be adding a note in the README around the part where it explains how to set up the cookie store?  Anyways, thanks for the workaround.

I'm experiencing this issue, maybe needs another HttpClient bump? Looks like 5.1.3 is compliant (current version is 4.5.13)
https://stackoverflow.com/questions/36473478/fixing-httpclient-warning-invalid-expires-attribute-using-fluent-api/73764182#73764182

I'd love to bump to 5.x, however, it's a very large change due to breaking changes between 4.x and 5.x, and I haven't had the time to be able to devote to it.


sdn-199: OVN CNI Network configuration should come from configmap

@cathy-zhou
Why do we need the changes to config.go?
The WriteCNIConfig() should read from the ConfigMap directly
you will need add new methods to Interface interface in pkg/kube/kube.go to get the CNI JSON configuration from configmap and use that method in WriteCNIConfig(). Thanks.

it is different approach to solve the same problem. I am actually referring to what calico is doing, to define the variable environment from the configMap (which is common, and it is used throughout ovn-kubenetes code).


OPENAI Alternative

Is it possible to add open-source llm models like mistral, falcon.

Is it possible to use hugging face embeddings instead of openai embeddings

Is it possible to add multiple csv files which in size sums upto 25GB

I'm creating a chatbot similar to yours. I want to create an FAQ chatbot which uses open-source models. I'm using "Wikipedia dump" dataset from kaggle
The dataset has 29 files, each having size around 1GB
I tried to load the files in chunks but vscode is getting crashed and tells me to reopen it
It would be a great help if this problem get's solved, have been sitting on this around 1 week

Yes I think it's possible I am trying to make my own Chatbot with mistral
Yes
Do you make a try with decorator @st.cache ?

How are you guys creating your own chatbot? I need some help regarding a similar work.
I am looking for a chatbot that when a file is uploaded it can tell me insights from the data on its own and with user prompts as well. The chatbot output can contain graphs also. So can anyone guide me with that or any open source model that does this?

trying to do the same, I would like to use a small model like Phi3 locally

Is it possible to add open-source llm models like mistral, falcon.
Is it possible to use hugging face embeddings instead of openai embeddings
Is it possible to add multiple csv files which in size sums upto 25GB

I'm creating a chatbot similar to yours. I want to create an FAQ chatbot which uses open-source models. I'm using "Wikipedia dump" dataset from kaggle
The dataset has 29 files, each having size around 1GB
I tried to load the files in chunks but vscode is getting crashed and tells me to reopen it
It would be a great help if this problem get's solved, have been sitting on this around 1 week

You can use Ollama for Embeddings model and LLM which are open source.

You can use Ollama for Embeddings model and LLM which are open source.

No, thanks for the opinion. I will check it out.

How are you guys creating your own chatbot? I need some help regarding a similar work. I am looking for a chatbot that when a file is uploaded it can tell me insights from the data on its own and with user prompts as well.

ah, so your plan is to build a RAG chatbot. You can use Langchain for building simple RAG bot.
There are also blogs out there regarding it.
What I understood is that you want to build a RAG chatbot, where the LLM uses your pdfs information to answer your query.

The chatbot output can contain graphs also.

I don't know if there are graphs tools or not, as I have not to check about it. If you find any tool then do let me know

So can anyone guide me with that or any open source model that does this?

You can check 🤗 where models for different tasks are available.
LMStudio is a software where you can download the entire model, you can also run and test the models in it

My opinion on what models to use while building RAG chatbot is:

embedding model: there are embedding models in 🤗 which can be loaded using Sentence Transformers library
text generation model: there are 2 options: 1) to use open-source models. 2) to use api key of proprietary model which has a free plan (e.g: mistral models, gemini models)

Do you make a try with decorator @st.cache ?

I am assuming that this is a streamlit function. If yes, then no i have not done it. if no, then explain you meant by it

Update on this issue
So, I opened this issue on Feb 28th, I later found out that the problem was happening because I ran out of RAM ( I only 8 GB, where 4GB is used by the system
So my issue itself was wrong, but thank you all for responding.
After finding the problem, I did number of things:

reduced the dataset
shifted my IDE from VS Code to google colab.

I also used propriety models with free plan.


project name?

Unfortunately there is a previous project named csvhub:
https://github.com/theodi/csvhub

Anyone have ideas for another name?

I'm thinking csvwww unless someone has a better name :-)

sharecvs?

csvshare might work too - thanks @raffazizzi

ended up going with csvwww because I wanted to recall the webbiness of the idea.


KIF 3.2 should be used

KIF 3.2 adds some nice gesture methods. KIF-Kiwi should update its KIF dependency to use this latest version.

sounds good, thank you @jshier

added 3.2 on master, so you can try to use in your Podfile:
    pod 'KIF-Kiwi',                 # write KIF tests Kiwi style
        :git => 'https://github.com/IndieGoGo/KIF-Kiwi.git'

fixed in https://github.com/IndieGoGo/KIF-Kiwi/releases/tag/0.2.4


Math functions MIN and MAX in conflict with aggregators MIN and MAX

Hi,
I was trying to use the MIN and MAX functions defined in the 55functions.js file but it seems the names are in conflict with the aggregation functions MIN and MAX defined directly in the jison parser.
Can't get these example to work :
var a = [ { a: 1, b:5 }, {a: 2, b: 0}, {a:0, b: -5}, {a: 5, b:5} ];
alasql('SELECT MIN(`a`, `b`) AS c FROM ?', [a]);
alasql('SELECT * FROM ? WHERE MIN(`a`, `b`) > 1', [a])

Perhaps the MIN and MAX math function should be renamed so we can use them...

... yes. What should name we use? Do you know what standards say about these functions and aggregators?

I know for sure that the aggregation function MIN and MAX are totally right and shouldn't be renamed as they are standard.
But I don't know much about the standards for the math functions. I think it doesn't exists in standard SQL. But I know that in Oracle there is the GREATEST and LEAST functions that do the same job.
So you could eventually rename them like that...

As far as I found:

There is no such function in T-SQL (see this StackOverflow question or this)

Standard functions for this are MySQL and Oracte are GREATEST and LEAST

I renamed these MAX() and MIN() functions (not aggregators) to GREATEST() and LEASTS(). Master branch is updated.
Thank you!

I found this distinguishing definition of MIN()/LEAST() and MAX/GREATES

    min()
Returns the minimum value. If invoked with more than one parameters, the function doesn't aggregate,   but returns the minimum value between all the arguments.

Probably, I can change parser to check what type of MIN/MAX was used.

Fixed. Now AlaSQL supports constructions like this:
    SELECT MAX(MAX(a),MIN(a)), MIN(MAX(a),MIN(a)) FROM ?

Will be available in release 0.0.50, now in develop branch.

:+1:

:+1: Nice!
And seeing your fix GREATEST/LEAST should still be supported!

Yes, but only as functions, when MIN/MAX are aggregators/functions depending on the number of arguments.


[IOTDB-2987] Optimize ConfigNodeGroup startup process

At present, both ConfigNode and DataNode should set all of the ConfigNode's ip:port in order to get connection to any ConfigNode, which is not user-friendly.
For a better startup mode, ConfigNode and DataNode need only configure the location of an active ConfigNode(target_ConfigNode) to start.
Therefore, I optimize the startup process of ConfigNodeGroup, you can see these docs for more details:

User's manual for deploying Cluster-IoTDB(If you just want to learn about the new startup process)
ConfigNode startup process(If you also want to learn  about the ConfigNodeGroup startup process)

Successfully start ConfigNode on Windows system.


Add script to cleanup old sitemaps

Currently we are keeping all sitemaps ever created. It would be good to
clean then up after a couple of days so that we don't have hundreds of
them saved on disk.
This lets you set a number of days to clean up and then deletes all
sitemaps which aren't the number of days most recent. If the sitemaps
are not created on a particular day this will still maintain at least
the right number of days worth of sitemaps not just the last number of
calendar days worth.
https://www.pivotaltracker.com/story/show/90087288

This code looks fine, and I like that it's well tested.
Did you consider instead using something external like logrotate, or just a shell script to delete the oldest files in the directory?  This is a fair chunk of code, that I'd rather avoid having to maintain if we could use something already written.
As an example of the kind of shell script I'm thinking of
ls -1tr *.xml | head -n -4 | xargs -d '\n' rm -f`

will delete all but the newest 4 files matching *.xml.  I'm not sure if the sitemap files are organised into directories - if so, this command could be pointed at the directories instead of directly at the *.xml files

Due the the fact that we split the sitemap into chunks of 50,000 urls the number of files per day is not a constant, and could grow in the future (and has grown in the past). For example in the past there were 4 files (one index and 3 files full of URLs). Now that we have more than 150,000 urls there are 5 files (one index and 4 files full or urls). This will probably grown in the future to be more files once we have more than 200,000 unique pages on the site. So something naive like just deleting all but the n most recent files won't scale with the site.
I have no experience using anything which would be able to do it based on creation dates of the files, something might exist but I just have no knowledge. This just seemed like an easy way of achieving it reliably.

Ah, so the files are all in a single directory, but there are varying numbers of them per day.  That does make things more awkward - not intractable, but the shell scripting required would get impenetrable quickly.
In the interests of this being robust, tested, and in a language that all our developers understand, this is probably the best approach then.  Thanks for the explanation.

The main reason we didn't want to use logrotate was that the files are produced by the app, so it's in a better position to know what's still useful to it or not. The best we could do with logrotate was probably delete any files older than 30 days.


Progress bar in Day 1: 4_Chinese_document_classification

Progress bar for the training counts nicely for the first epoch, but then spills over 100 into the next epoch.
It doesn't look like there's a nice way of resetting the bar - you could create a new one each epoch, but that would be a lot of bars.
I recommend the following code in defining it. Include the epochs in setting it up, so that the user can see total progress.
bar = tqdm_notebook(total=len(dataloader)*num_epochs)

Brian 👇
On Fri, Apr 27, 2018 at 12:51 PM ArtOfStew<EMAIL_ADDRESS>wrote:

Progress bar for the training counts nicely for the first epoch, but then
spills over 100 into the next epoch.
It doesn't look like there's a nice way of resetting the bar - you could
create a new one each epoch, but that would be a lot of bars.
I recommend the following code in defining it. Include the epochs in
setting it up, so that the user can see total progress.
bar = tqdm_notebook(total=len(dataloader)*num_epochs)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/joosthub/pytorch-nlp-tutorial-ny2018/issues/2, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJFXDp0RR2jZuniwlKPskuySe9rkOS8fks5ts3bHgaJpZM4Tq7Sb
.


Create styles.css

Create a styles.css file in the root directory and insert styles into it and upload it.

Created and merged into develop branch


Use logging module

Why not to use standard logging module?
Also i think that kicost should produce some progress info like when -d1 passed.
Perhaps another good idea is to use python-progressbar for data retrieving step.

I changed to using the logging module. Thanks!


[WIP][Windows] NoEncap support

Add routes to peer Pod CIDRs.
Add flow for reply packages received from uplink.

	if c.encapMode.SupportsNoEncap() {
		flows = append(flows, c.pipeline[conntrackStateTable].BuildFlow(priorityNormal).MatchProtocol(binding.ProtocolIP).
			MatchRegRange(int(marksReg), markTrafficFromUplink, binding.Range{0, 15}).
			MatchDstIPNet(localSubnet).
			Action().LoadRegRange(int(marksReg), macRewriteMark, macRewriteMarkRange).
			Action().ResubmitToTable(EgressRuleTable).
			Cookie(c.cookieAllocator.Request(category).Raw()).
			Done())
	}

Signed-off-by: Rui Cao<EMAIL_ADDRESS>

Is it due to some known issues we send return traffic from uplink to Pods directly, without going through host stack?
Do we know this asymmetric path will cause any issue on the host (regarding to connection state, like Windows firewall)?
Is hybride mode supported too?

Is it due to some known issues we send return traffic from uplink to Pods directly, without going through host stack?

(1) We see the reply packtes forwarded by host stack is marked as invaid after enter OVS as issue : https://github.com/openvswitch/ovs-issues/issues/197
But it's weird I tried  through host stack today and the issue disappear. I will reproduce the https://github.com/openvswitch/ovs-issues/issues/197 to double confirm issue.
(2) We need to enable forwarding on interface br-int to make forward through host stack  works. But I remember we see dup packets when both enable  forwarding on br-int and antrea-gw0.

Do we know this asymmetric path will cause any issue on the host (regarding to connection state, like Windows firewall)?

Actually we are not sure about the effect on Windows firewall.

Is hybride mode supported too?

Yes, hybride mode is suposed to be covered.
@jianjuns , I will check the above issues to see which patch we need to choose.

/test-windows-conformance

Codecov Report

Merging #1901 (d7c1969) into main (f4599c0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
+ Coverage   41.67%   41.69%   +0.01%
==========================================
  Files         124      124
  Lines       15408    15408
==========================================
+ Hits         6422     6424       +2
+ Misses       8455     8454       -1
+ Partials      531      530       -1

Flag
Coverage Δ

unit-tests
41.69% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apiserver/storage/ram/store.go
78.94% <0.00%> (+1.50%)
:arrow_up:

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance
/test-windows-networkpolicy

/test-windows-conformance
/test-windows-networkpolicy

/test-windows-conformance
/test-windows-networkpolicy

/test-windows-networkpolicy

/test-windows-networkpolicy

/test-windows-networkpolicy

Hello @jianjuns and @tnqn . As for the asymmetric paths issue, I have 2 proposals.

Based on the current design
Path between uplink and br-int. Add a flow table to redirect packet to LOCAL at table 31. Add a matching condition "ct_state=+new+trk" in newly added flow.
e.g.

ovs-ofctl add-flow br-int "table=31,cookie=$Cookie,priority=210,ip,reg0=0x4/0xffff,nw_dst=<IP_ADDRESS>/24 actions=LOCAL"
ovs-ofctl add-flow br-int "table=31, cookie=$Cookie,priority=210,ct_state=+new+trk,ct_mark=0x21,ip,reg0=0x4/0xffff actions=load:0x1->NXM_NX_REG0[19],resubmit(,50)"

Path between antrea-gw0 and Pod should be ok now.
There's an issue of traffic from br-int to antrea-gw0. The packet is dropped although host route is ready. This needs investigation.

New design, packet doesn't go to host
We need to learn MAC of remote node uplink in some way. And then add 2 flow tables:
e.g.

ovs-ofctl add-flow br-int "table=70,cookie=$Cookie,priority=210,ip,nw_dst=<IP_ADDRESS>/24 actions=mod_dl_src=00:50:56:a7:e0:20,mod_dl_dst=00:50:56:a7:e2:d0,resubmit(,80)"
ovs-ofctl add-flow br-int "table=80,cookie=$Cookie,priority=200,ip,dl_dst=00:50:56:a7:e2:d0 actions=load:0x3->NXM_NX_REG1[],load:0x1->NXM_NX_REG0[16],resubmit(,105)"

@lzhecheng : proposal 1 sounds ok to me. For proposal 2, do we have other use cases we want to resolve MAC in OVS? If not (and proposal 1 works), probably let us consider the change later.

Codecov Report

Merging #1901 (c500d48) into main (bb6cd10) will increase coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
+ Coverage   59.34%   60.80%   +1.46%
==========================================
  Files         197      270      +73
  Lines       17507    20385    +2878
==========================================
+ Hits        10389    12396    +2007
- Misses       6009     6708     +699
- Partials     1109     1281     +172

Flag
Coverage Δ

kind-e2e-tests
51.53% <ø> (+7.03%)
:arrow_up:

unit-tests
41.52% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/monitor/agent.go
33.33% <0.00%> (-31.38%)
:arrow_down:

pkg/agent/flowexporter/utils.go
83.33% <0.00%> (-16.67%)
:arrow_down:

pkg/monitor/controller.go
35.07% <0.00%> (-16.45%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
61.22% <0.00%> (-12.53%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
69.46% <0.00%> (-5.64%)
:arrow_down:

pkg/apiserver/storage/ram/watch.go
90.38% <0.00%> (-3.85%)
:arrow_down:

pkg/agent/openflow/packetin.go
59.25% <0.00%> (-3.54%)
:arrow_down:

pkg/agent/flowexporter/connections/connections.go
76.05% <0.00%> (-3.34%)
:arrow_down:

pkg/controller/traceflow/controller.go
67.27% <0.00%> (-2.21%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/npl_controller.go
59.21% <0.00%> (-1.92%)
:arrow_down:

... and 152 more

/test-windows-conformance
/test-windows-networkpolicy

Added support for symmetric reply packet. Traffic between Pod and remote Pod is fine.

/test-all

/test-e2e
/test-networkpolicy

/test-all

/test-windows-networkpolicy

Closing it as it's superseded by #1901.
@ruicao93 Thanks for your great contribution on this item!


Added color function and updated bayer_data function

Changing things up a little because we made some mistakes the first time around. cdesc doesn't actually reflect color order, and in fact can't for sensors with non-standard pattern sizes. Instead you're supposed to use the libraw_COLOR to get the color of a specific pixel. I have added the Raw.color method to address this, and removed cdesc from the bayer_data function because it wasn't used for what we thought it was. Now you would use the code something like this:
from rawkit.raw import Raw

with Raw(filename='some_file.CR2') as raw:

    bayer_data = raw.bayer_data()

    row = 100
    col = 100

    print('pixel value is %s.' % bayer_data[row][col])
    print('pixel color is %s.' % raw.color(row, col))

This would give you output like:
pixel value is 5725.
pixel color is R.

Fixes #113

I haven't tried the code yet but having to pass the pixel coordinates to get the CFA mask smells like huge performance hit. I guess that for periodic Bayer CFA one could access the 2 first rows 2 first pixels and from there assume the mask is tiling.

I've been operating under the assumption that the libraw COLOR function (which is the recommended way to get the color of a pixel) handled all the special cases like X-Trans sensors. This is not the case, and that function only seems to operate correctly for traditional 2x2 bayer sensors. I'm going to do more research tomorrow to verify, but if I'm right about the COLOR function I'll switch to generating a 2x2 array (or 1x4 if people prefer that) and returning it with the get_bayer_data function.

Second attempt. Now the bayer_data function returns the bayer data and color filter array. This currently only works for traditional bayer sensors, but will be expanded to handle other sensors as I get around to reading all the special cases in libraw. Code looks something like this:
from rawkit.raw import Raw

with Raw(filename='somefile.CR2') as raw:
    bayer_data, cfa = raw.bayer_data()

    # cfa is a 2x2 array
    cfa[0][0] = 'R'
    cfa[0][1] = 'G'
    cfa[1][0] = 'G'
    cfa[1][1] = 'B'

@KelSolaar what are your thoughts on this approach?

Looks good to me, although I'm biased because I exclusively work with Bayer CFA cameras (Canon & Nikon) :)

As I expand this function it will benefit everyone. For example if you have an X-Trans sensor you will get back a 6x6 array instead. What I really want to know is if returning an MxN array is what is most useful. I personally like it because it makes it consistent with the format of the bayer data array.


Docker compose arm64

When set up installation over docker yaml file. Pulls amd64 image, and can't up container because system is arm64. Raspberry Pi OS.

Hello! I've not bumped into this one yet, and I'm not too familiar but happy to work it out with you.
Could you share your yaml file please?


Custom date format causes navbar to not show

I've tested in a separate vault and verified the navbar is working with default date format YYYY-MM-DD
Default format passing:
✅ YYYY-MM-DD
My date format is this: YYYY/MM. MMMM/YYYY.MM.DD
Since this introduces a path and a custom date format, I tested each in isolation and both failed:
Tested formats failing:
❌ YYYY.MM.DD
❌ YYYY/YYYY-MM-DD
NOTE: I noticed the plugin requires a copy of the Daily note date format, so I've been syncing this in each test.

I really like this extension, and if I can debug this properly later I will PR a fix.
It's likely not working for many users as a result of this bug.
A previous issue related to the Navbar not displaying was closed without a real solution. The user deleted their .obsidian directory, effectively reverting to the default format which does indeed work.

Thanks a lot for the issue :)
I didn't think about adding dots in the date name, so I split the filenames on dots to remove the file extension. I have now changed it to not do this. I have tested it and could now use YYYY/MM. MMMM/YYYY.MM.DD and set the date format in the daily note bar to YYYY.MM.DD. You might have to reload Obsidian after updating the plugin to make it work.
Feel free to create more issues or suggestions, if you have any.


CMake Error: FVAD_LIB

While running compile_libwebrtcvadwrapper.sh, I get the following error on line cmake ../:
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found JNI: /usr/java/jdk1.8.0_191/jre/lib/amd64/libjawt.so
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
FVAD_LIB
    linked by target "webrtcvadwrapper" in directory /home/absin/git/jitsi-webrtc-vad-wrapper

-- Configuring incomplete, errors occurred!
See also "/home/absin/git/jitsi-webrtc-vad-wrapper/cmake-build/CMakeFiles/CMakeOutput.log".

I have followed compile_libfvad.sh and then generate_jni_header.sh

Quick suggestion: I am successfully compiling with:
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
and:
cmake version 3.10.2
Otherwise, could you share the CmakeOutput.log (either here or via email)?

Hi I just updated my gcc, g++ and cmake.
g++ --version gives g++ (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0
gcc --version gives gcc (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0
cmake --version gives cmake version 3.10.0
But I am still getting this error.
I am attaching the error file here

@absin1 Were you able to compile it correctly?

I too have the same issue.

What's the output of compile_libfvad.sh?

The pre-compiled binaries are already present: https://github.com/jitsi/jitsi-webrtc-vad-wrapper/tree/master/lib/native/linux-64
If you're simply interested in using the library, you can install it locally by running mvn install. If you don't trust the binaries I uploaded, you should run the scripts in this order to create the binaries (if I recall correctly):

compile_libfvad.sh
generate_jni_header.sh
compile_libwebrtcvadwrapper.sh

Hey Nik, Thank you very much for your response.
I've managed to install and run the package locally after making a few minor changes to build scripts that were specific to my system. I am trying to build arm-linux-androideabi shared object files for the libfvad to add it to an android app.

success to build on centos7.3，below is my change to CMakeLists.txt:
cmake_minimum_required(VERSION 3.10)
project(webrtcvadwrapper)

set(CMAKE_CXX_STANDARD 14)

find_package(JNI REQUIRED)

include_directories(${JNI_INCLUDE_DIRS})
include_directories(libfvad/include)

set(SOURCE_FILES
    src/native/org_jitsi_webrtcvadwrapper_WebRTCVad.cpp
    src/native/org_jitsi_webrtcvadwrapper_WebRTCVad.h)

add_library(webrtcvadwrapper SHARED ${SOURCE_FILES})

find_library(FVAD_LIB fvad lib/native/linux-64)
target_link_libraries(webrtcvadwrapper ${FVAD_LIB})

I was able to build on Debian 10 with the fixes in this PR: https://github.com/jitsi/jitsi-webrtc-vad-wrapper/pull/8


FileUpload / UploadType error -> Invalid number, expected digit but got: - (45).

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When uploading a file, I get the following error:
Invalid number, expected digit but got: - (45).

Steps to reproduce

Here is a minimal sample repository: https://github.com/AmbroiseCouissin/HotChocolate-FileUpload-Sample

Run the program and go to /ui/altair

Input the following mutation:

mutation($someFile: Upload!) {
  uploadFile(input: {
    bucketName: ""
    key: "someKey"
    content: $someFile
  })
}

Input the file variable of Altair

Relevant log output
https://github.com/AmbroiseCouissin/HotChocolate-FileUpload-Sample

Additional Context?
No response
Product
Hot Chocolate
Version
<IP_ADDRESS>-rc1

I can't access the linked repository - it needs to be public.

Me to ... get a 404 :)

@tobias-tengler @michaelstaib Terribly sorry... It was private.
It is now public.

@michaelstaib I see you added this to the Backlog :)
Any idea what was the issue?

Not yet ... I would guess some error in Altair but have not verified it. Underneath we use the Microsoft implementation for the mime stream. Backlog just means that someone can pull this item to analyze it.  The flow is backlog -> 12.x.x -> specific version.

I have this problem also ... don't get it why.
locations: [{line: 1, column: 1}] 0: {line: 1, column: 1} message: "Invalid number, expected digit but got: - (45)."


Cannot generate GATK_Resilist.grp

Hi, so we're experiencing a problem trying to run the "BaseRecalibrator" step in your pipeline.
self.__CallCommand('BaseRecalibrator', ['java', '-Xmx4g', '-jar', self.__gatk, '-T', 'BaseRecalibrator',
     '-I', GATKdir +'/GATK_sdrc.bam', '-R', self.reference, '--knownSites',
     self.snplist, '-o', GATKdir +'/GATK_Resilist.grp','-nct', '8'])

We tried typing the equivalent command in the terminal, and we get the following:
INFO  10:52:11,406 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:11,408 HelpFormatter - The Genome Analysis Toolkit (GATK) v3.4-0-g7e26428, Compiled 2015/05/15 03:25:41
INFO  10:52:11,408 HelpFormatter - Copyright (c) 2010 The Broad Institute
INFO  10:52:11,408 HelpFormatter - For support and documentation go to http://www.broadinstitute.org/gatk
INFO  10:52:11,411 HelpFormatter - Program Args: -T BaseRecalibrator -I Results/Test/tmp/GATK/GATK_sdrc.bam -R Results/Test/tmp/bwa/index/ref.fa --knownSites /uvp/bin/snps.vcf -o Results/Test/tmp/GATK/GATK_Resilist.grp -nct 8
INFO  10:52:11,413 HelpFormatter - Executing as hwl9@cs-compbio-22 on Linux 4.4.0-127-generic amd64; OpenJDK 64-Bit Server VM 1.8.0_171-8u171-b11-0ubuntu<IP_ADDRESS>-b11.
INFO  10:52:11,413 HelpFormatter - Date/Time: 2018/06/19 10:52:11
INFO  10:52:11,413 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:11,413 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:12,302 GATKRunReport - Uploaded run statistics report to AWS S3
##### ERROR ------------------------------------------------------------------------------------------
##### ERROR A USER ERROR has occurred (version 3.4-0-g7e26428):
##### ERROR
##### ERROR This means that one or more arguments or inputs in your command are incorrect.
##### ERROR The error message below tells you what is the problem.
##### ERROR
##### ERROR If the problem is an invalid argument, please check the online documentation guide
##### ERROR (or rerun your command with --help) to view allowable command-line arguments for this tool.
##### ERROR
##### ERROR Visit our website and forum for extensive documentation and answers to
##### ERROR commonly asked questions http://www.broadinstitute.org/gatk
##### ERROR
##### ERROR Please do NOT post this error to the GATK forum unless you have really tried to fix it yourself.
##### ERROR
##### ERROR MESSAGE: Couldn't read file /uvp/bin/snps.vcf because file '/uvp/bin/snps.vcf' does not exist
##### ERROR ------------------------------------------------------------------------------------------

I believe the issue is with self.snplist, because in the configuration file, it mentions snplist: /uvp/bin/snps.vcf. But snps.vcf is nowhere to be found in the bin directory! How could we go about generating/finding this file? Thank you

You can use an M. tuberculosis VCF file for that purpose.
On Tue, Jun 19, 2018 at 2:24 PM Brian Lee<EMAIL_ADDRESS>wrote:

Hi, so we're experiencing a problem trying to run the "BaseRecalibrator"
step in your pipeline.
self.__CallCommand('BaseRecalibrator', ['java', '-Xmx4g', '-jar', self.__gatk, '-T', 'BaseRecalibrator',
'-I', GATKdir +'/GATK_sdrc.bam', '-R', self.reference, '--knownSites',
self.snplist, '-o', GATKdir +'/GATK_Resilist.grp','-nct', '8'])
We tried typing the equivalent command in the terminal, and we get the
following:
INFO  10:52:11,406 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:11,408 HelpFormatter - The Genome Analysis Toolkit (GATK) v3.4-0-g7e26428, Compiled 2015/05/15 03:25:41
INFO  10:52:11,408 HelpFormatter - Copyright (c) 2010 The Broad Institute
INFO  10:52:11,408 HelpFormatter - For support and documentation go to http://www.broadinstitute.org/gatk
INFO  10:52:11,411 HelpFormatter - Program Args: -T BaseRecalibrator -I Results/Test/tmp/GATK/GATK_sdrc.bam -R Results/Test/tmp/bwa/index/ref.fa --knownSites /uvp/bin/snps.vcf -o Results/Test/tmp/GATK/GATK_Resilist.grp -nct 8
INFO  10:52:11,413 HelpFormatter - Executing as hwl9@cs-compbio-22 on Linux 4.4.0-127-generic amd64; OpenJDK 64-Bit Server VM 1.8.0_171-8u171-b11-0ubuntu<IP_ADDRESS>-b11.
INFO  10:52:11,413 HelpFormatter - Date/Time: 2018/06/19 10:52:11
INFO  10:52:11,413 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:11,413 HelpFormatter - --------------------------------------------------------------------------------
INFO  10:52:12,302 GATKRunReport - Uploaded run statistics report to AWS S3
ERROR ------------------------------------------------------------------------------------------
ERROR A USER ERROR has occurred (version 3.4-0-g7e26428):
ERROR
ERROR This means that one or more arguments or inputs in your command are incorrect.
ERROR The error message below tells you what is the problem.
ERROR
ERROR If the problem is an invalid argument, please check the online documentation guide
ERROR (or rerun your command with --help) to view allowable command-line arguments for this tool.
ERROR
ERROR Visit our website and forum for extensive documentation and answers to
ERROR commonly asked questions http://www.broadinstitute.org/gatk
ERROR
ERROR Please do NOT post this error to the GATK forum unless you have really tried to fix it yourself.
ERROR
ERROR MESSAGE: Couldn't read file /uvp/bin/snps.vcf because file '/uvp/bin/snps.vcf' does not exist
ERROR ------------------------------------------------------------------------------------------
I believe the issue is with self.snplist, because in the configuration
file, it mentions snplist: /uvp/bin/snps.vcf. But snps.vcf is nowhere to
be found in the bin directory! How could we go about generating/finding
this file? Thank you
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CPTR-ReSeqTB/UVP/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFLYb2_mq7fjzFnySiSZGBS416Eev8tEks5t-UHhgaJpZM4UuAoK
.

We're using TB data from the PATRIC database ( example link: ftp://ftp.patricbrc.org/genomes_by_species/Mycobacterium_tuberculosis/1010834.3 )
I found an H37Rv reference genome from NCBI, but PATRIC does not appear to provide VCF files for their WGS data. Could you please provide some help on how we can find/create a MTB VCF file?

Sure, you can use a variant caller like a Samtools or GATK to create VCFs
from your sample files. You will need to follow the manuals for either of
those tools. Once you have the VCF, you can then use as the snplist.
Else we will find a way to get you a sample VCF file to get through the
step.
On Tue, Jun 19, 2018 at 6:37 PM Brian Lee<EMAIL_ADDRESS>wrote:

We're using TB data from the PATRIC database ( example link:
ftp://ftp.patricbrc.org/genomes_by_species/Mycobacterium_tuberculosis/1010834.3
)
I found an H37Rv reference genome from NCBI, but PATRIC does not appear to
provide VCF files for their WGS data. Could you please provide some help on
how we can find/create a MTB VCF file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CPTR-ReSeqTB/UVP/issues/3#issuecomment-398568080, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFLYb_VlxMw2ARcueapaLrzFTxGk0-SQks5t-X0TgaJpZM4UuAoK
.

Does it mean we have to call the SNPs for each sample and generate the corresponding snp.vcf before running UVP? So it would run bwa twice for each sample, one before UVP and one during the UVP pipeline. @mezewudo

@brianlee99 Were you able to build a snps.vcf file for this analysis?


Adaptive learning-rate optimization

Thank you for that implementation!
There was an older optimizer[0] that would update the learning-rate according to the following rule (basically increasing the learning-rate when things are going in the same direction and decreasing it when they are not):
epsilon = 0.01
same_sign = sign(update[weight]) == sign(previous_update[weight])
lr[weight] = torch.where(same_sign, lr[weight]*(1+epsilon), lr[weight]/(1+epsilon))

It requires:

keeping track of the previous sign of the update vector,
storing one learning rate per weight,
adding an epsilon parameter.

However, at that price, you can find an epsilon and starting learning rate that work well for a large range of problems and not have to think about learning rate scheduling nor optimal learning-rate for your given problem.
Given the regularity of the update step of lion, it might be worth playing with.
[0]: I just searched for an exact reference but could not find it anymore, it was before Adam's domination over the ML world.

@nestordemeure hey Nestor, thanks for the suggestion
i feel like adding anything more is just a slippery slope into the demise of so many optimizers of the past. i think we should just collect more feedback on people's experience with Lion. if it is not uniformly good, probably best to just stick with Adam and look forward to learned approaches. kind of an indictment on all these neural architecture search papers too, if it surfaces that Lion does not work as advertised

@nestordemeure that said, are you seeing a signal when training with Lion?


rtx 3060 not supported

2024-02-14 18:10:21 | INFO | configs.config | No supported Nvidia GPU found
overwrite preprocess and configs.json
2024-02-14 18:10:21 | INFO | configs.config | Use cpu instead
rtx 3060 not supported, i use official release "updated1006v2"

I have no problem running on mobile RTX3060


Instance default by @VaclavObornik , merged to Master

Credit to @VaclavObornik, I just merged this and updated the tests to match the other existing tests (in terms of which languages are used, other than the default), and I included the lib changes from prepublish.
Original PR #20.
Fixes #27
Fixes #26
@jed @florrain

Thanks @rhagigi for jumping onto this!!
I'm a bit preoccupied by the merge commit here, not sure how hard it would be to rebase instead of merge but I'd rather see the work rebased on top of master + squashed into one commit before it's actually merged as you suggested on the other thread. Otherwise 👍


Initial HyperSPI support for RPi Pico (rp2040)

Adds new option in HyperHDR for incoming HyperSPI support for Raspberry Pi Pico

Included in #691


Salesforce Contact Merge Conflict with CON_CannotDelete_TDTM

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
In EDA 1.92, with the custom setting - Prevent Contact Deletion - set to TRUE and the Trigger Handler Record for CON_CannotDelete_TDTM active, customers are not able to complete a contact merge using the Salesforce Standard Contact Merge functionality (available in Classic).

To Reproduce:

Set the Prevent Contact Deletion custom setting to TRUE
Ensure the CON_CannotDelete_TDTM trigger handler is active
Create a HH Account
Create a Contact within that HH Account
Create a Contact Language for that Contact
Repeat Steps 4 & 5
Switch to Classic
Navigate to the HH account
Scroll to the Contact related List and click Merge Contacts
Select and necessary fields to retain between the 2 contacts
Click Merge & OK
You will get an error message stating: "This record can't be deleted because it has one or more related records associated with it. Delete the associated records first, then delete this record. To determine which records should be deleted first, click the Related tab. If you don't see related records, or if you're unable to delete them, contact your System Administrator for assistance."

What is the expected behavior?
Since the Salesforce Standard Contact Merge reparents the children of the non-master record, the contact should be allowed to be deleted.

Workaround
Disable the CON_CannotDelete_TDTM feature by going into Setup --> Custom Settings --> Manage: Hierarchy Settings and unchecking the "Prevent Contact Deletion" checkbox.

This Hub post includes a message for the workaround.

**lurch: add

Tracking W-039706

This issue has been delivered and documented - see Migrate Data in EDA.


fix: add "" case for user.name

add "" case for user.name

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 1fdf66c7db98eebdccdc401f0f47b3d8090f882f

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


introduce disable-time-limiter property

Provide and use the new configuration property spring.cloud.circuitbreaker.resilience4j.disable-time-timiter as intended by https://github.com/spring-cloud/spring-cloud-circuitbreaker/issues/174.
Setting the property to true disables the time limiting feature for both (default and reactive) implementations.

While intergrating the requested changes i noticed..

It seems like the spring-cloud-build parent is defining jdk17. The referenced/used resilience4j-timelimiter-2.0.2 contains an implementation (io.github.resilience4j.timelimiter.TimeLimiter#createdTimeoutExceptionWithName) which refers to the old javax annotation javax.annotation.Nullable. This annotation is currently not within the scope of the project and thus needs to be provided by some third party who wishes to use it.
I did not investigate any further if this is some issue within my local setup, the resilience4j project, if maybe some dependecy is missing or if this is "built/works as designed".

It is a bit of a pity that the resilience4j implementation is not providing a "disabled-timelimiter" functionality. Therefore it is currently only possible to deactivate the time limiter globally. I tried to describe this within the documentation. As soon as you make use of the io.github.resilience4j.timelimiter.internal.InMemoryTimeLimiterRegistry you'll stuck with the need of a defined timelimit.

It seems like the spring-cloud-build parent is defining jdk17. The referenced/used resilience4j-timelimiter-2.0.2 contains an implementation (io.github.resilience4j.timelimiter.TimeLimiter#createdTimeoutExceptionWithName) which refers to the old javax annotation javax.annotation.Nullable. This annotation is currently not within the scope of the project and thus needs to be provided by some third party who wishes to use it. I did not investigate any further if this is some issue within my local setup, the resilience4j project, if maybe some dependecy is missing or if this is "built/works as designed".

I took a look and it seems that this is the current state of resilience4j. Here is an issue, including search link for obsolete javax-package usage: https://github.com/resilience4j/resilience4j/issues/1978.
I guess then this can be considered as works as designed and anybody who wants to use it would probably be in need of providing the mandatory javax-dependency.
On the other hand, one could consider providing it within the spring-cloud-circuitbreaker-project since it seems to be mandatory for certain resilience4j-functionalities. Nobody really likes runtime-class-not-found-errors which could be prevented because of some prior knowledge of a transitive library flaw like this. ;)

Hey @ryanjbaxter,
Sorry for jumping in here, but we recently updated to Spring Boot 3.2 and Spring Cloud 2023.0.0, and suddenly had a test starting to fail. I was tracking down what might have caused, and came across this Pull Request.
Very shortly we have a SpringBootTest loading some configuration classes that setup the Customizer and we also ImportAutoConfiguration of ReactiveResilience4JAutoConfiguration.
Before this change, everything worked but now the test fails since  no bean of Resilience4JConfigurationProperties is available.
Of course we fixed the tests by simply importing it, but my question is, shouldn't the ReactiveResilience4JAutoConfiguration, similar to some other autoconfiguration classes (like RedisAutoConfiguration or ActiveMQAutoConfiguration) then be responsible for importing the Properties?
Or if Autoconfiguration here should also be conditional on the Resilience4JConfigurationProperties?
Let me know if I was clear and if my questions are pertinent.
Thanks in advance.

@gonmmarques thanks!  Yes I agree we should have EnableConfigurationProperties on ReactiveResilience4JAutoConfiguration. This should be fixed with my latest commit 27a9a4ec2e8b434980ab4589c30f544dfafe669f.  A new snapshot build should be available within 24 hours if you would like to try 2023.0.1-SNAPSHOT.

Thanks @ryanjbaxter!

No problem, there should be a snapshot build available now if you want to try it


fix: update version condition for installation task block

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Ros install fixes

installation worked like this so far, will now try to run it ;)

:( tried empty and outdoor, both crashed
Also, for outdoor it mentioned it could not find some models, maybe there is still something missing in the setup.

Ok thanks a lot for your effort. I will test the install again tomorrow using my ubuntu vm to check if it's a setup or vm issue.

:+1:
what I don't know if the log would give any useful input. the problem is, the log it's referring to does not exist (also no variant of that name). haven't closely looking into the other logs but "gzserver" doesn't appear too often..

ahm, I tried vmware but got this now (catkin_make after cloning everything):
[ 54%] Built target mav_joy_interface
Scanning dependencies of target px4
[ 55%] Building CXX object Firmware/CMakeFiles/px4.dir/src/platforms/ros/px4_ros_impl.cpp.o
In file included from /home/ada/catkin_ws/src/Firmware/src/include/px4.h:42:0,
                 from /home/ada/catkin_ws/src/Firmware/src/platforms/ros/px4_ros_impl.cpp:40:
/home/ada/catkin_ws/src/Firmware/src/include/../platforms/px4_includes.h:51:29: fatal error: px4/rc_channels.h: No such file or directory
 #include "px4/rc_channels.h"
                             ^
compilation terminated.
make[2]: *** [Firmware/CMakeFiles/px4.dir/src/platforms/ros/px4_ros_impl.cpp.o] Error 1
make[1]: *** [Firmware/CMakeFiles/px4.dir/all] Error 2
make: *** [all] Error 2
Invoking "make -j1 -l1" failed

Did anything change in the meantime? Can't find any difference..

@AndreasAntener I updated the HW test system, now this check passes.

@LorenzMeier Thanks! I thought you must be testing something.. Looking forward to see the hardware test system over a webcam ;)
I'm also trying to get a Docker image working for this ROS setup. But I think I have VM-technology unrelated issues with the build.. as soon as the setup is running somehow, we can make the most portable working solution available (e.g. vagrant > vmware ubuntu > docker SITL could be awesome if you want vagrant)

@AndreasAntener:
there seems to be a problem with the dependency on our messages, catkin invokes the build before the message headers are finished generating. Just rerun catkin_make. I am trying to find whats wrong in our cmakelists.

@AndreasAntener fixed in the ros branch

@AndreasAntener I rebased this and merged to the ros branch, I am going to test in the ubuntu vm next, closing


when uploading hash that has been uploaded, check for known epoch and update if possible

When processing ledger file and hash is already present, but epoch is null, check for blocks to determin epoch, and update epoch accordingly.
Need to wait for epoch transition to validate that this works - merging but need to check after Feb 21, 2024 to confirm whether epoch 72 updated as expected.

Closes #13 pending confirmation


Linux Folder showing my Mac network location when WSL is not using

Please fill out the below information:

Your Windows build number:  19603

What you're doing and what's happening:

Using a Windows 10 Insider virtual machine on Mac via Parallels Desktop with Mac side folders mounted as a network location. Right now, if I don't use any WSL distro, it will show my Mac network location instead of the WSL file location. When any WSL distro is active, it will be back to normal.

What's wrong / what should be happening instead:

It should just display WSL folders.

@patrick330602 did you still see this issue?

Yep, I am still seeing this bug @licanhua

@patrick330602 Thanks to confirm that. But I can't find repro on our side, and I think it's minor impact to user, so I will not fix it.


Implement database schema versioning

Maintain the current schema revision in the database
Expose a HTTP route for reading the current schema revision
Create a directory with schema migration scripts
Perform automatic schema upgrades?

This is resolved by introducing goose


Question: Test output with JUnit5 DisplayName and DisplayNameGeneration

I saw the test output on this tutorial and it left me wondering where (or how) could I generate the same output style.

Source: Baeldung
I tried digging some stuff on VSCode and wasn't successful.
Maybe a different IDE (IntelliJ/Eclipse/Netbeans) or a maven plugin?
Thank you.

Hey, @brunotacca
For VSCode you can try this extension to get similar tree-style test results: https://code.visualstudio.com/docs/java/java-testing
Hope it helps.


Is it possible to have this persist to a file?

So we don't lose data on every start

Why do you need it? It is better to start from a clean database for test purposes.

My plan was to have a prepopulated database that everything could load.

I'd propose to prepare SQL-scripts for this and run them before tests. You could use database migration tools (here is an example - https://github.com/honourednihilist/gradle-postgresql-embedded-example/blob/master/src/main/liquibase/db/changelog/db.changelog-0.1.0.xml). It will be a reusable piece of work. For example, if you migrate from this gradle plugin to something else.


luci-base: fix ipkg.info and ipkg.status

Currently this 2 function doesn't return a table but just the name of the package. From the documentation, this is wrong so let's return the right table filled with the value from opkg.
@jow- can you help me with this? i can't understand why use the c variable... think this function is pretty broke and not used by any package... Is it good this way? I tested with luci package that contain all possible value and works good (by creating a for loop and return a string of the content scanned).
Signed-off-by: Ansuel Smith<EMAIL_ADDRESS>

The change looks wrong to me, it changes the return format from an array of package dictionaries to a single dictionary with all package values merged together. It also changes the casing of the field names, likely breaking any code relying on these functions.
How did you test the change?

@jow- i'm stupid, function works but to actually get the data you need to call the package name 2 times. This should be better, don't you think ?

The info and status functions accept glob patterns which causes opkg to return multiple entries, example:
lua -lluci.model.ipkg -lluci.util -e 'luci.util.dumptable(luci.model.ipkg.info("luci-app-*"))'
Due to this we cannot change the return value type.


Added Lucky Number

Adding the new pr as told

Kindly check my pr if it is now in the correct folder


Update sync-submodules.yml

Old branch replaced
Overview
Fixes failing submodule-sync.
Changes

Replaced old branch in pipeline

Testing
Referring to #274 merge

Codecov Report

Merging #281 (8e9ae8a) into develop (bffbb93) will increase coverage by 30.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #281       +/-   ##
============================================
+ Coverage    47.22%   77.71%   +30.49%
============================================
  Files           99       39       -60
  Lines         3867     1324     -2543
  Branches       762      202      -560
============================================
- Hits          1826     1029      -797
+ Misses        2041      295     -1746

Flag
Coverage Δ

boba-contracts
?

contracts
77.71% <ø> (ø)

core-utils
?

data-transport-layer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/boba/contracts/contracts/ERC2470.sol

packages/data-transport-layer/src/utils/common.ts

...ntracts/contracts/standards/xL2GovernanceERC20.sol

.../src/services/l2-ingestion/handlers/transaction.ts

packages/core-utils/src/optimism/fees.ts

...ontracts/contracts/oracle/payment/Subscription.sol

...contracts/contracts/standards/L2StandardERC721.sol

...boba/contracts/contracts/DiscretionaryExitBurn.sol

packages/core-utils/src/external/ethers/index.ts

packages/core-utils/src/common/test-utils.ts

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffbb93...8e9ae8a. Read the comment docs.


Package.StoreAssociation.xml can't be generated

Hi,
When I tried to build the project using build.bat, I got the error:
Could not find file ... DistroLauncher-Appx\Package.StoreAssociation.xml.
I tried to create one by selecting Store > Associate App with the Store .. but then it gave me this error:
"Unable to associate your App with the Window Store because the app manifest is invalid. Correct the errors in the app manifest.".
I am running Window 10, Visual Studio P. 2017 - 15.9.3
Please help . Thank you

Have you checked the errors in the app manifest?

@benhillis : Yes, it says this line not valid: https://github.com/Microsoft/WSL-DistroLauncher/blob/master/DistroLauncher-Appx/MyDistro.appxmanifest#L14
because no Capability element in rescap namespace. I tried to change it to something valid like ` as in https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/how-to-specify-capabilities-in-a-package-manifest . After that the editor doesn't complaint anymore but it still gives me the same error when associating store

Interesting, I did not see that locally. I will give this a try.

@benhillis it turns out that the error was because Visual Studio's C++ plugin for window universal app weren't installed for me. After installing it, I can see the wizard for associate the store but I encounter another unhelpful error: "An unexpected error occurred when attempting to reserve the app name". I have tried many different names including random names . I can't tell much from the error. You have any suggestion?

I think it was because of the way I generated the cert. I tried generating the test cert manually instead of using Visual Studio utility. Will close this now. I only wish that the error message had been more informative.


Add build-from-source docs for development

Follow-up for https://github.com/knative-sandbox/eventing-kafka-broker/pull/1704#discussion_r782167854
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>

/assign @matzew


Improve error logging for InvalidResponseError from crewjam/saml (SAML-nuo0vphhh9)

Preflight Checklist

[x] I could not find a solution in the existing issues, docs, nor discussions
[x] I have joined the ZITADEL chat

Describe your problem
SAML response validation can fail with error SAML-nuo0vphhh9, which indicates the underlying SAML library (crewjam/saml) has failed to parse the response. This can occur for a number of different reasons, e.g. invalid signature, mismatched entity ID etc etc.
When Zitadel throws the SAML-nuo0vphhh9 error, the parent error is set to the error returned from crewjam/saml. However, crewjam/saml sets the Error() string to a generic "Authentication failed" message, regardless of the underlying cause.
This makes it extremely difficult to debug issues validating the SAML response.
Describe your ideal solution
The error object returned from crewjam/saml contains a string field PrivateErr which contains the specific validation error that occurred. It is undesirable for this error to be returned to the client, however it would be very helpful if it was logged by Zitadel to stdout.
This can be accomplished by a type check on the err we receive from crewjam/saml, and if it is a InvalidResponseError, log the value of PrivateErr field to stdout, but still return the generic "Authentication Failed" message to the client.
Links:

Call-site of SAML response validation error

https://github.com/zitadel/zitadel/blob/main/internal/idp/providers/saml/session.go#L70

InvalidResponseError definition in crewjam/saml

https://github.com/crewjam/saml/blob/bbccb7933d5f60512ebc6caec7120c604581983d/service_provider.go#L576-L588

Version
2.61.0
Environment
Self-hosted
Additional Context
No response

Thank you for sharing your idea.
If there is a significant demand from customers/community, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog to collect feedback.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

I'm happy to create a PR -- I'll do that. Thanks!

Hei @studouglas
Thanks a lot, I assigned you to the issue

Apologies for the basic question, but the contribution guideline stats that I should add a maintainer as a reviewer -- it doesn't look like I have permission to do so, is that something handled by you guys?

Yes we will do that, we usually go through all the contributions in our daily and directly assign them.
Thanks a lot 🙌🏻


Update dockerlinks.md

Not much: There was a missing command to rerun the web container.
Signed-off-by: Bruno Gazzera<EMAIL_ADDRESS>

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
git commit --amend -s --no-edit && git push -f

Not much: There was a missing command to rerun the web container.
Signed-off-by: Bruno Gazzera<EMAIL_ADDRESS>

Not much: There was a missing command to rerun the web container.
Signed-off-by: Bruno Gazzera<EMAIL_ADDRESS>

@bgazzera the sign-off must be part of the commit-message itself, not the comment here on GitHub.
Going by the name of your branch (patch-1), you've made this PR via the GitHub web-interface. Unfortunately, (afaik) the web-interface doesn't allow you to amend your commit-message. To follow the instructions (https://github.com/docker/docker/pull/10156#issuecomment-70365802), you need a local checkout on  your computer.
(If you're unable to do this, one of the maintainer may be able to take over your PR)

@thaJeztah thank you for your help,
I forked, cloned in my desktop, commited using the disclaimer and started a new PR #10167
I hope I got it right this time. Is there anything else I should do to clean-up the previous PR?

Thanks for making the effort to fix the PR! If you can close this one (you should be able tom because you created it), it should be fine. Optionally, mention something like "closing, replaced by #10167"

closing, replaced by #10167"


[extension types] extension types slower than classes on AOT.

Consider how an extension type is slower than a plain old class on AOT (7ms vs 9ms) in the micro benchmark at the bottom of this issue description.
I expected extension types to be at least as fast as classes, but not slower.
Note: the build that this ran on includes the following fix https://github.com/dart-lang/sdk/issues/53542#event-10402503466, however, extension types appear to still be slower than a plain old class.

Dart SDK version: 3.2.0-edge.88b07ba64e07fb0eef9c777769917c65fdf1832e (be) (Tue Sep 19 21:57:39 2023 +0000) on "macos_arm64"

AOT

dart compile exe --enable-experiment=inline-class dispatch_bench.dart

./dispatch_bench.exe

via class • on class with instantiated mixin: 7ms
via extension type • on class with instantiated mixin: 9ms

JIT

dart --enable-experiment=inline-class dispatch_bench.dart

via class • on class with instantiated mixin: 25ms
via extension type • on class with instantiated mixin: 23ms

void main() {
  const size = 10000000;
  final datasetClass = List.generate(size, (final a) => SomeClass(foo: a));
  final datasetExtensionType = List.generate(size, (final a) => SomeExtensionType(a));
  final sw = Stopwatch();
  void measure(
    final String name,
    final void Function() fn,
  ) {
    sw.reset();
    sw.start();
    fn();
    sw.stop();
    print("$name: ${sw.elapsedMilliseconds}ms");

  }
  final viaClass = RunClass();
  final viaExtensionType = RunExtensionType();
  measure(
    "via class • on class with instantiated mixin",
    () => viaClass.execute(datasetClass),
  );
  measure(
    "via extension type • on class with instantiated mixin",
    () => viaExtensionType.execute(datasetExtensionType),
  );
}

class RunExtensionType with Run<SomeExtensionType> {
  @override
  int sum(final SomeExtensionType v) => v.foo;
}

class RunClass with Run<SomeClass> {
  @override
  int sum(final SomeClass v) => v.foo;
}

extension type SomeExtensionType(int foo) {
  static int fooSelector(
    final SomeExtensionType a,
  ) => a.foo;
}

class SomeClass {
  static int fooSelector(
    final SomeClass a,
  ) => a.foo;

  final int foo;

  const SomeClass({
    required this.foo,
  });
}

mixin Run<T> {
  int sum(
    final T v,
  );

  int execute(
    final List<T> tree,
  ) {
    int total = 0;
    for (final a in tree) {
      total += sum(a);
    }
    return total;
  }
}

This is not a fair comparison: extension type is erased to an int, while class holds int in a field.
The following improved example shows that performance of extension type matches the performance of bare int:
void main() {
  const size = 10000000;
  final datasetClass = List.generate(size, (final a) => SomeClass(foo: a));
  final datasetExtensionType = List.generate(size, (final a) => SomeExtensionType(a));
  final datasetInt = List.generate(size, (final a) => a);
  final sw = Stopwatch();
  void measure(
    final String name,
    final void Function() fn,
  ) {
    sw.reset();
    sw.start();
    fn();
    sw.stop();
    print("$name: ${sw.elapsedMilliseconds}ms");

  }
  final viaClass = RunClass();
  final viaExtensionType = RunExtensionType();
  final viaInt = RunInt();
  measure(
    "via class • on class with instantiated mixin",
    () => viaClass.execute(datasetClass),
  );
  measure(
    "via extension type • on class with instantiated mixin",
    () => viaExtensionType.execute(datasetExtensionType),
  );
  measure(
    "via int • on class with instantiated mixin",
    () => viaInt.execute(datasetInt),
  );
}

class RunExtensionType with Run<SomeExtensionType> {
  @override
  int sum(final SomeExtensionType v) => v.foo;
}

class RunInt with Run<int> {
  @override
  int sum(int v) => v;
}

class RunClass with Run<SomeClass> {
  @override
  int sum(final SomeClass v) => v.foo;
}

extension type SomeExtensionType(int foo) {
  static int fooSelector(
    final SomeExtensionType a,
  ) => a.foo;
}

class SomeClass {
  static int fooSelector(
    final SomeClass a,
  ) => a.foo;

  final int foo;

  const SomeClass({
    required this.foo,
  });
}

mixin Run<T> {
  int sum(
    final T v,
  );

  int execute(
    final List<T> tree,
  ) {
    int total = 0;
    for (final a in tree) {
      total += sum(a);
    }
    return total;
  }
}

After inlining, this micro-benchmark effectively reduces to a calculation a sum of elements of a list. int elements of a list are represented as boxed instances (because List can contain arbitrary objects), and each element is conditionally unboxed before addition. This conditional unboxing happens both for extension type and bare int. In case of a class, field SomeClass.foo is always unboxed which saves one bit test and a branch. As it is a very small micro-benchmark which doesn't do anything useful, the extra test and branch (while being pretty cheap) still affects benchmark result.
So this benchmark shows that holding int values in fields of classes could be more efficient than holding them in general-purpose lists, and doesn't show anything about extension types. I can also recommend using typed lists (such as Int64List from dart:typed_data) to store elements in the unboxed form instead of using general-purpose List if you need to handle a lot of int data.
As far as I can see this example works as expected, so closing the issue.

@alexmarkov thank you for looking into this. The point of this benchmark was to validate the following hypothesis:
Values wrapped in an extension type are always "faster" than values wrapped in a class.
This doesn't seem to be the case, but it has nothing to do with extension types as I can confirm that extension types are as fast an plain integers on my machine. I apologize for the false alarm!


BFS level order traversal Algorithm in Python

I can work on BFS level order traversal Algorithm of Binary Tree in Python. I will follow the proper contributing guidelines, can you  please assign it to me?

Sure, please add well documented code with sample test cases.


iOS Modal blocks UI after app enters background then returns to foreground

🐛 Bug Report
(only iOS) When displaying a modal to the user and pressing the home button the application enters background when re-opening the application the modal is not visible but any button press which should cause the modal to be displayed does not function and no modal can be displayed without the parent view being unmounted an mounted again. (Present in RN 0.57.4 also)
Expected Behavior
Either modal should remain visible on reopen or buttons to display modal should function
Environment
info
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (4) x64 Intel(R) Core(TM) i7-4578U CPU @ 3.00GHz
Memory: 70.09 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.15.0 - /usr/local/opt/node@8/bin/node
npm: 6.4.1 - /usr/local/opt/node@8/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 26, 27, 28
Build Tools: 23.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
System Images: android-26 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.3 AI-182.5<IP_ADDRESS>64788
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.1 => 0.59.1
npmGlobalPackages:
create-react-native-app: 2.0.2
react-native-git-upgrade: 0.2.7

Worked around by listening for AppState change and hiding modals before app is entering background

@thomasarogers can you provide a small code example, i'd like to work on this issue

Sorry I only have production code

I can confirm the same issue on Android with the latest version of RN. same issue during live reload or normal reload when modal is visible


prop assertion methods should be safe

So to my mind, propEq and propSatisfies should be safe methods, like prop. But if you call either of these with null/undefined it throws.
Essentially I would expect to get the same result for all three of these examples:
R.pipe(
  R.prop('foo'),
  R.equals('bah'),
)(null); // false

R.propEq('foo', 'bah', null); // Cannot read property 'foo' of null

R.propSatisfies(r.equals('bah'), 'foo', null);  // Cannot read property 'foo' of null

If I were to write the same examples using path, pathEq, and pathSatisfies I would get false each time.
Potentially breaking but it would be a lot more consistent. This catches me out on a regular basis. If I wanted strict type assertions I'd be using sanctuary :stuck_out_tongue_closed_eyes:

I agree and would love to see a PR for this.  I

Hello @CrossEye,
PR was created almost a year ago but still not merged yet. Do you have any updates on this?
Thank you in advance.

The update is simple: I missed the PR.  Somehow I don't think I ever saw it.  Merged now.

@CrossEye thank you! 👍


Transfer Stellar to new organisation

Transfer Stellar dependencies to new org

Thanks for reminding me.
@ustiugov I created new credentials for vhive-serverless yes.
Though I defined only one key pair. AWS_ACCESS_KEY and AWS_SECRET_KEY. I found it confusing several names for the same value.
But good that you reminded me that I needed to change it here.


Migrate Azure MSI & Metadata Service token sources to httpclient and add 100% test coverage

This PR improves the stability for Azure MSI authentication by adopting the httpclient transport.
Needs two PRs merged first:

https://github.com/databricks/databricks-sdk-go/pull/708
https://github.com/databricks/databricks-sdk-go/pull/700

Codecov Report
Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (f7a5e46) 16.86% compared to head (c874577) 17.50%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

config/azure.go
55.00%
16 Missing and 2 partials :warning:

httpclient/fixtures/fixture.go
20.00%
8 Missing :warning:

httpclient/fixtures/map_transport.go
40.00%
2 Missing and 1 partial :warning:

config/config.go
90.00%
1 Missing and 1 partial :warning:

httpclient/errors.go
75.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   16.86%   17.50%   +0.63%
==========================================
  Files         103      103
  Lines       14089    14169      +80
==========================================
+ Hits         2376     2480     +104
+ Misses      11507    11487      -20
+ Partials      206      202       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

go 1.19 doesn't support multiple errors unwrapping

tested as github.com/databricks/databricks-sdk-go v0.26.2-0.20231201114025-d7a8895217fe and confirm that this PR is working as expected


Cupra Born odometer is not available

Hi,
in the charging session the odometer value is 0.
Is it just not implemented for this car or should it work?
with evcc vehicle:
[main  ] INFO 2023/04/20 13:33:00 evcc 0.116.2
[main  ] INFO 2023/04/20 13:33:00 using config file: /etc/evcc.yaml
[db    ] INFO 2023/04/20 13:33:00 using sqlite database: /root/.evcc/evcc.db
[db    ] TRACE 2023/04/20 13:33:00 SELECT count(*) FROM sqlite_master WHERE type='table' AND name="settings" -1
[db    ] TRACE 2023/04/20 13:33:00 SELECT sql FROM sqlite_master WHERE type IN ("table","index") AND tbl_name = "settings" AND sql IS NOT NULL order by type = "table" desc 1
[db    ] TRACE 2023/04/20 13:33:00 SELECT * FROM settings LIMIT 1 -1
[db    ] TRACE 2023/04/20 13:33:00 SELECT * FROM settings 6
[mqtt  ] INFO 2023/04/20 13:33:00 connecting evcc-1278863501 at tcp://<IP_ADDRESS>:1883
Soc:            62%
Capacity:       58.0kWh
Charge status:  A
Range:          210km
Finish time:    not available
Climate active: false
Target Soc:     80%
Features:       []

Cupra doesn't have odometer as as evcc vehicle shows.

Thank you for the reply.
Do you have an idea why e.g. TRONITY  can access this value?


Attach Producer/Consumer property tags so its easier to identify topics being produced/consumed by functions

Motivation
Explain here the context, and why you're making that change.
What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.


Add a base class for all inventory nodes

Add a base class for all inventory nodes with the information which database it is using.

This will organize common code across nodes and present all possible inventory nodes in one place in the node hierarchy.

This is class abstract

Make resource too ? 🤔

Is it not possible to create abstract classes in gdscript?

No, it's not. Not having abstract classes/interfaces is one of my gripes.

I have plans to port some bases to C++ without changing this plugin, abstract classes are possible there

https://github.com/expressobits/inventory-system-cpp


Clarify usage of matches with PathPrefixRewrite

Update PathPrefixRewrite spec to include compatible match types.

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the httproute spec to clarify that PathPrefixRewrite can only be used with a match of type PathPrefix.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?:

NONE

Thanks @spencerhance! Deferring to @shaneutt or someone else for final LGTM.
/approve

/ok-to-test


is userTrackingMode a number or a string?

In MapView.js#L50, is userTrackingMode really supposed to be a number? The modes are defined as strings in Camera.js#L332.
This makes the "User Location Updates" example show a warning.

@alexiri i think userTrackingMode is removed from MapView and replaced with Camera#followUserMode. We need to update examples and docs.

The camera doc still needs a refurb. PRs are more than welcome.
Renaming ticket.


Issue with commit message generation for new files

Description
I’ve observed that the Commit AI plugin works well for generating commit messages for existing tracked files but does not seem to generate messages for newly added files. I am unsure if this behavior is expected or if there might be an issue with the configuration.
Steps to Reproduce

Create a new file in your project.
Select the new file for commit.
Invoke Commit AI to generate a commit message.

Expected Behavior
The plugin should generate a commit message for the newly added file, similar to how JetBrains AI handles both new and modified files.
Actual Behavior
The plugin does not generate a commit message for new files. When attempting to generate a message for a new file, an error message appears: “Git diff is empty.”
Additional Information
•	Commit AI Version: 2.3.1
•	PHPStorm Version: 2024.2.1
Could you please advise if there’s a specific setup required for handling new files, or if this is a known limitation of the plugin? Any guidance would be greatly appreciated.
Thank you!

Huh, you are correct. This is not intended and will be fixed.

There were some wierd shenanigans going on, hopefully this will fix it. Please report back if this is not resolved :pray: .

Hi, thank you for the quick fix!
I downloaded and installed the new build manually, but unfortunately, the issue still persists. When I attempt to generate a commit message for a new file, I continue to see the message: “Git diff is empty.”
Here’s what I did:

Downloaded the artifact from the latest workflow.
Installed the plugin manually in PHPStorm (version 2024.2.1).
Tested with a new file, and the “Git diff is empty” message still appears.

Please let me know if there’s anything else I can try or if further information is needed to help debug this.
Thanks again

Can you please check if the prompt preview, in the prompt edit dialog, shows the new file or not? Thanks :+1: .

In the message editing dialog I see that I am selecting 1 file. I have attached a screenshot showing what I see when I try to generate a confirmation message for a new file.

Aha, the problem might be that the file is not added to the VCS. Try to right click on the file click Add to VCS.

Great news, that fixed the issue! It turns out the file needed to be added to VCS first. I was accustomed to JetBrains AI, where this step wasn’t necessary. I apologize for any inconvenience caused and appreciate your assistance. Thank you for your help!


goveralls fixes to get meaninful stats out of coveralls.io

Ignore main.go, as it's untestable. Only take other files into account to be able to enforce 100% coverage.

Changes Unknown when pulling 5270d401e12fb12c9fe5fba87cb956df2e5305c9 on coverfix into ** on master**.

Changes Unknown when pulling 370a98d31b05023487629b441cca4b7a33b0ab07 on coverfix into ** on master**.


[BUG] Not working on TF AWS Provider 4.x

Describe the bug
Current state of module does not work with TF AWS provider 4.X
Terraform version: What Terraform version do you use?
TF - 1.0.11
TF AWS provider - 4.2.0
Module version: What module version do you use?
4.0.1
Error message:
 Could not retrieve the list of available versions for provider hashicorp/aws:

Terraform code that produces the error:
https://github.com/grem11n/terraform-aws-vpc-peering/blob/master/provider.tf#L5
Additional context
Add any other context about the problem here.

Hello, @ivanmartos , I will be able to take a look at it after the war.
Thank you for understanding!

oh crap
sorry man, good luck and everything
I will create a PR in the meantime so you can focus on important stuff

Hello, @ivanmartos ,
Linked PR fixed this issue. I also updated the tests and I can see in the output that AWS Provider version > 4.x.x was used.
Closing this issue now


Can't position controls on canvas using binding

Problem
I am trying to position controls on canvas. I used the code given in
https://github.com/AvaloniaUI/Avalonia/discussions/10636
To Reproduce
Steps to reproduce the behavior:

Clone project https://github.com/arnirichard/digital_filters_dotnet
Run project AvaloniaFilters
On the left, there is a canvas with zeros (small circle) and poles (cross)

Expected behavior
Zeros and poles should be positioned correctly on the unit circle canvas
Actualy behavior
The zeros and poles are positioned in the left top corner
Screenshots

Desktop (please complete the following information):

OS: Windows
Version Avalonia 11.0.0-preview5"

If I try to upgrade to preview6 I can't build the project anymore.
Code
This code is in module/folder FilterResponse, view FilterResponseView.axaml,
The viewmodel is FilterResponseViewModel.cs
<ItemsControl Items="{Binding Zeros}" Grid.Row="1">
  <ItemsControl.ItemsPanel>
	  <ItemsPanelTemplate>
		  <Canvas Width="300" Height="300"/>
	  </ItemsPanelTemplate>
  </ItemsControl.ItemsPanel>
  <ItemsControl.Styles>
	  <Style Selector="ItemsControl.items > ContentControl">
		  <Setter Property="Canvas.Bottom" Value="{Binding Bottom}" />
		  <Setter Property="Canvas.Left" Value="{Binding Left}" />
	  </Style>
  </ItemsControl.Styles>
  <ItemsControl.ItemTemplate>
	  <DataTemplate>
		  <Grid Height="10" Width="10" Canvas.Left="{Binding Left}" Canvas.Bottom="{Binding Bottom}">
			  <Ellipse StrokeThickness="2" Stroke="Blue" Width="10" Height="10" />
		  </Grid>
	  </DataTemplate>
  </ItemsControl.ItemTemplate>
  </ItemsControl>

public class CanvasItem
{
    public double Bottom { get; init; }
    public double Left { get; init; }
    public object Item { get; init; }

    public CanvasItem(double left, double bottom, object item)
    {
        Bottom = bottom;
        Left = left;
        Item = item;
    }
}

Try ItemsControl > ContentPresenter selector

@kekekeks Thanks, that solves the problem.

@arnirichard just fyi: DevTools are really handy when you want to inspect the visual or logical tree. Call them via [F12]

I'm converting this issue into a Q&A b'cause I feel this is not an actual bug.


Broken pdf in Firefox only - works in Chrome using pdf.js (completely blank rendering - putBinaryImageData?)

See attached file: pdfjsissue.pdf
I don't think this ever worked on Firefox. It works (without warnings) at least on:

pdf.js under Chrome
Chrome native built-in viewer
Acrobat (9, X, XI, newer)
Evince (Poppler)

Guess: native image decode error
The file was re-saved using Acrobat but the original exhibits exactly the same issue.
Console error messages (two different versions):
An error occurred while rendering the page.
PDF.js v2.1.153 (build: 5a2bd9fc)
Message:
Stack: putBinaryImageData@https://mozilla.github.io/pdf.js/build/pdf.js:13996:9
CanvasGraphics_paintInlineImageXObject@https://mozilla.github.io/pdf.js/build/pdf.js:15442:9
CanvasGraphics_paintImageXObject@https://mozilla.github.io/pdf.js/build/pdf.js:15396:7
CanvasGraphics_executeOperatorList@https://mozilla.github.io/pdf.js/build/pdf.js:14269:11
_callee$@https://mozilla.github.io/pdf.js/build/pdf.js:11833:42
tryCatch@https://mozilla.github.io/pdf.js/build/pdf.js:11959:14
invoke@https://mozilla.github.io/pdf.js/build/pdf.js:12134:22
defineIteratorMethods/</prototype[method]@https://mozilla.github.io/pdf.js/build/pdf.js:12002:16
asyncGeneratorStep@https://mozilla.github.io/pdf.js/build/pdf.js:9549:103
_next@https://mozilla.github.io/pdf.js/build/pdf.js:9551:194
_asyncToGenerator/</<@https://mozilla.github.io/pdf.js/build/pdf.js:9551:364
_asyncToGenerator/<@https://mozilla.github.io/pdf.js/build/pdf.js:9551:97
_next@https://mozilla.github.io/pdf.js/build/pdf.js:11858:18
_scheduleNext/<@https://mozilla.github.io/pdf.js/build/pdf.js:11809:13
An error occurred while rendering the page.
PDF.js v2.1.97 (build: 45c01974)
Message:
Stack: putBinaryImageData@resource://pdf.js/build/pdf.js:8029:9
CanvasGraphics_paintInlineImageXObject@resource://pdf.js/build/pdf.js:9475:9
CanvasGraphics_paintImageXObject@resource://pdf.js/build/pdf.js:9429:7
CanvasGraphics_executeOperatorList@resource://pdf.js/build/pdf.js:8302:11
_next@resource://pdf.js/build/pdf.js:6841:30
_scheduleNext/<@resource://pdf.js/build/pdf.js:6829:11

Duplicate of #6741.


feat: measures getters

LGTM, can you please add the new methods to the README for public user documentation? Thanks


Adds scrutinizer-badge

Coverage remained the same at 50.0% when pulling 0f58073eb8fd608e8cf6ab0adcd46e5c0b9af623 on addScrutinizer into b840f68b6a33f3cda9e8cf3d1507fdaa1af53828 on master.


White border left, right, top and bottom

Running Firefox 70. Would like to remove it.

I'm not sure what exactly you mean.
If you are talking about html elements' border on the page then you can change it color as you wish.
There are Borders tab in the settings specifically for that.
If you want it to be darker just decrease Brightness limit. Decreasing Contrast can also do the trick.
Midnight Lizard does not add or remove elements to/from the page. So all the borders you see were there originally. But setting border color to be similar with background color can look like its removal.


[xy-chart] bump all vx deps

🏆 Enhancements
[xy-chart]

expose tickComponent prop in XAxis and YAxis components for fully-custom tick rendering
bump all vx packages, which adds much better default support for tick labels (Fixes #109)

[demo]

added tick label props playground example to demo new functionality

Coverage increased (+0.7%) to 85.321% when pulling a82f910a96b32a1e5332ad5e62d213698611537a on chris--xy-chart-deps into be2dbc2c4cc84e0b56cd82143fdc31399f28b3b7 on master.


Add write::MultiGzDecoder for multi-member gzip data

Add a MultiGzDecoder with a Write interface to match the MultiGzEncoder available in read and bufread.

@alexcrichton @joshtriplett - This repo has been quiet recently so I hope you don't mind a ping, and that you are the right people to ping.
This PR adds a standalone feature without changing existing code, so is hopefully as simple as a yes or no decision. Note that if you intend to approve both this PR and #324 then the docs for this new MultiGzDecoder will be inconsistent with the existing MultiGzDecoders. So perhaps merge one and ask the other to make them consistent again.
I'm also looking to get #323 merged, as it fixes a bug. But that required some more complicated rewriting, essentially continuing the changes from #278. So likely requires more effort to review.

Sorry but I've handed off maintainership here to the Rust libs crate maintainers team. I'd recommend reaching out on Zulip to them.


test: add CI workflow for starknet-foundry compatiblity

We want starknet-foundry to work 100% with madara, ideally just by specifying the correct rpc url
Add a workflow to the CI.
It should use a custom starknet-foundry project and run it against madara, making sure the tool is compatible

@tdelabro can I take this one?

@justinfrevert do you think it should live in the madara repository? Or exist in another repo and just be used in the madara repo CI?

@justinfrevert we don't want to overcharge the madara repo with the compatibility test. Do you think you could work on this on a repo of your own, that you will transfer to the @keep-starknet-strange organization when ready?
Then we will use it in Madara CI. Given the repo define a gh action
Does that sound ok to you?

Sure, it works for me. It seems like a fine approach. Will start on a separate repo focused on its own gh action.

@tdelabro how extensive do you think the testing of the initial github action should be?

I think, declare, deploy, and invoke would be a good start.
I think that is what 95% of foundry time is spent doing. But I may be missing something. What do you think?

Hey, all good?

Hey @tdelabro I am looking into the incompatibilities themselves in https://github.com/keep-starknet-strange/madara/issues/1168 before I create the github action

@justinfrevert sure! Thanks a lot!!

@justinfrevert What is the state here?

Hi @tdelabro this was blocked because of https://github.com/keep-starknet-strange/madara/issues/1168. I just found the fix for that yesterday, so I will create the PR today and also begin working on this issue.

@justinfrevert okay perfect. That's great to hear!


proposal: x/sys/unix: support for all fields of Kevent_t, EpollEvent

unix.SetKevent only takes mode(eg. Filter field) and flags parameter.
Other fields also have different types depending on the ach/platform, say Udata which is either a *byte or a int32.
Since Go1 compat promise prevent us from changing the SetKevent function, perhaps it could be feasible to add new methods to the Kevent_t type to set the others fields, similar to *Iovec.SetLen for example.
Fflags and Data methods looks straightforward to implement, on the model of SetKevent, since types are integers on all platforms/archs.
However, so far, I am unsure about the type of the Udata parameter for the eponym method. I typically would do kev.Udata = (*byte)(unsafe.Pointer(&foobar)) on my own currently for darwin/amd64, but I guess that exposing unsafe.Pointer as a parameter type is not a good solution.

CC @tklauser @bradfitz @ianlancetaylor

unsafe.Pointer seems to me to be the only reasonable choice for the Udata field.  The C type is void * and unsafe.Pointer is the Go equivalent.

*byte

darwin_386
darwin_amd64
darwin_arm
darwin_arm64
dragonfly_amd64
openbsd_386
openbsd_amd64
freebsd_amd64
freebsd_386
freebsd_arm

int32

netbsd_386
netbds_arm

int64

netbsd_amd64

Using int32 and int64 is not OK if people store pointers in the field.  Conversely, using *byte is not OK if people store non-pointers in the field.  Unfortunately, Go does not permit a union of pointer and non-pointer types.

@ianlancetaylor Any idea why *byte isn't used as type for netbsd ?

@wI2L It's an intptr_t on netbsd by definition (see NetBSD/src@537e2d7d60c00738172845f6064331d2c6cdce7f) which cgo then translates to the respective int{32,64} Go type.

@tklauser Understood. Can we override this to use a uintptr type instead (assuming that making that change is acceptable) ?

There is no perfect choice here, but it seems better for the field to consistently be *byte or unsafe.Pointer on all systems.

Merged #32192 into this one, so we can have one discussion instead of two.

Aren't these structures held inside the kernel and passed back to user space?  If so, it seems like an int type would be preferable.
It's unclear how much we can change at all right now, of course.

This is x/sys/unix, so we don't have strict backward compatibility.

We should probably unify the different architectures and OS's to the greatest extent possible. If it's an opaque word then it should probably be uintptr; else uint64. Using unsafe.Pointer would technically be OK but would certainly encourage bad behavior (you could only safely put non-Go pointers there).
It looks like we got it wrong everywhere, and Kevent udata should be uintptr.
For EpollEvent, I am a little worried about the union having both a uint64 and an int fd. It sounds like we should use uint64 consistently, but if any kernel API requires the use of the fd field in that struct, it will be unclear on 32-bit systems which half of the uint64 matters. We could do a uintptr + pad-on-32-bit instead too. That would be consistent with Kevent.

It looks like we should definitely eliminate any unsafe.Pointer in Kevent and change to uintptr.
For epoll, does anyone know of any kernel APIs that require the use of one field or another? If there is only one field (in particular, we suspect fd) then we should keep that field being the one that's exposed.

Following up on https://github.com/golang/go/issues/32153#issuecomment-498834824, I'm going to split the two seeming outcomes by system. First Kevent.
Our Kevent_t definitions disagree about the type of the Udata field:
ztypes_darwin_386.go:	Udata  *byte
ztypes_darwin_amd64.go:	Udata  *byte
ztypes_darwin_arm.go:	Udata  *byte
ztypes_darwin_arm64.go:	Udata  *byte
ztypes_dragonfly_amd64.go:	Udata  *byte
ztypes_freebsd_386.go:	Udata  *byte
ztypes_freebsd_amd64.go:	Udata  *byte
ztypes_freebsd_arm.go:	Udata  *byte
ztypes_freebsd_arm64.go:	Udata  *byte
ztypes_netbsd_386.go:	Udata  int32
ztypes_netbsd_amd64.go:	Udata     int64
ztypes_netbsd_arm.go:	Udata     int32
ztypes_netbsd_arm64.go:	Udata     int64
ztypes_openbsd_386.go:	Udata  *byte
ztypes_openbsd_amd64.go:	Udata  *byte
ztypes_openbsd_arm.go:	Udata  *byte

Based on the discussion above, it sounds like we should standardize on Udata int32/int64 (depending on architecture). Clearly the kernel can't be given Go pointers.

Next EpollEvent. All our Linux structs say:
type EpollEvent struct {
	Events uint32
	PadFd  int32
	Fd     int32
	Pad    int32
}

On 32-bit systems the PadFd field is missing, but otherwise they're consistent. In the absence of any evidence that this is causing harm to anyone (and since we're not sending any pointers to the kernel), it seems like the best course of action for EpollEvent is to do nothing at all.

Based on the previous two comments, it sounds like the right outcome here is to fix up Kevent_t to not use pointers and leave EpollEvent alone. I will retitle this and would like to hear feedback from people who agree or disagree, especially @wI2L.

@rsc Thanks for the follow-up on this issue.
When I originally filled the issue, I was trying to achieve sketchy stuff, by storing a pointer to a net.Conn inside the Kevent_t.Udata field without clearly realizing the issue you pointed out in https://github.com/golang/go/issues/32153#issuecomment-496671440.
However, could you explain what made you change your view about the udata field type ? Unless I misunderstood something, you mentionned int https://github.com/golang/go/issues/32153#issuecomment-505620354 that we should use an uintptr.
Regarding EpollEvent, I fully agree, of the fields of the epoll_data union, fd is the one to have.
Finally, I'd like to bubble up one the subjects of the original issue I filled that has been ignored so far, regarding the SetKeventmethod. I haven't looked back to the definitions of Kevent_t for all archs/platforms, but it seems important that this method accept all the fields for which we have type discrepancies. Ident, Filters and Flags are already accepted, remains Fflags and Data. About Udata, since you are proposing to use int64 or int32, depending on the architecture, the method could accept it aswell to simplify the usage of the type (as it already does for the Ident field).

Marked this last week as likely accept w/ call for last comments (https://github.com/golang/go/issues/32153#issuecomment-525475699).
No comments, so accepting.


[WB-4366]: Stop moviepy from outputting when making videos or gifs

https://wandb.atlassian.net/browse/WB-4366
Description
Adds logger=None to creation of videos and gifs through moviepy.
Testing
Tested on the most recent release of moviepy and release 1.0.0. Previous releases are not found during import and trigger an earlier error.

I couldn't grab the version without importing all of moviepy. Instead I added an extra try.
The newest versions of moviepy >1.0, support the logger argument and this hides progress bar and outputs.
There's a range of older versions that support verbose and progress_bar arguments.
Then the oldest don't support progress_bar, so it will print that no matter what.

I couldn't grab the version without importing all of moviepy. Instead I added an extra try.
The newest versions of moviepy >1.0, support the logger argument and this hides progress bar and outputs.
There's a range of older versions that support verbose and progress_bar arguments.
Then the oldest don't support progress_bar, so it will print that no matter what.