399 - Report a Problem mailto link

Chore: replace /problem page with mailto link
Card: https://github.com/bcgov/cas-registration/issues/399

Nice work! Approved though I have two thoughts:
I wonder if we should have a tech debt card to refactor these into .ts files that return json so we can avoid repeating the same shared tiles 4 times?
Also one other thing that would be a nice to have is a default subject ie: href": "mailto:GHGRegulator@gov.bc.ca?subject=HELP ME"

I can definitely see the value in setting a default subject title once we have multiple apps in our OBPS system. Right now, I can't think of a default subject that would add any value to users. Do you have any suggestions?

Nice work! Approved though I have two thoughts:
I wonder if we should have a tech debt card to refactor these into .ts files that return json so we can avoid repeating the same shared tiles 4 times?
Also one other thing that would be a nice to have is a default subject ie: href": "mailto:GHGRegulator@gov.bc.ca?subject=HELP ME"

I can definitely see the value in setting a default subject title once we have multiple apps in our OBPS system. Right now, I can't think of a default subject that would add any value to users. Do you have any suggestions?

No not really, it was just a nice to have. I was thinking something like Report a problem with B.C. Industrial Emissions Reporting System. Anyways feel free to merge this in!


Recfield gui

Added helper functions to plot PSTH and recfield results.
Generalized graph_PSTH and receptive_field_analysis.
Generalized variable names.
Change the scale of regional subplot to a global one.

General Style tips

Leave more comments
Make sure indenting is consistent
Whitespace is okay, put spaces on lines
break up excessively long lines
Remove unnecessary whitespace (multiple lines between random portions of code)

Code quality

If you have multiple occurrences of the same code, it should probably be generalized to a function
Check to make sure that you aren't taking extra steps to get access to data that you pass into the function. (See plot_PSTH where you pass in the psth, plot it, then access the data to find the min and max when you could have done that on the psth passed into the function)
When creating new functions, make sure you make it a function (see csv_comparison)

Don't hard code in values into your functions, such as the path to the csvs

csv_comparrison needs to be rewritten to be more generalized.


Refactor the FHIR Engine demo app to showcase the APIs

Is your feature request related to a problem? Please describe.
At the moment the demo app is not organised by fhir engine APIs - to make it easier for developers to find api usage examples, we should make fhir engine demo app more modularised towards showcasing individual apis.
Describe the solution you'd like
Proposing the following changes:

[ ] combine patient list and search pages - at the moment they are linked to the same screen
[ ] remove register a new patient page - this should be in the sdc catalog app
[ ] enhance search api demo - showcasing filters, reverse includes etc. to make this easier, we may want to use hardcoded patient data
[ ] add demo for data access apis - create, read, update, delete

Describe alternatives you've considered
na
Additional context
na
Would you like to work on the issue?
@santosh-pingle

@fredhersch


bug in Hello World documentation

URL to the relevant documentation
https://docs.quantum.ibm.com/guides/hello-world
Select all that apply

[ ] typo
[X] code bug
[ ] out-of-date content
[ ] broken link
[ ] other

Describe the fix.
in Step 3, change
`estimator = Estimator(mode=backend)'
to
'estimator = Estimator(backend=backend)'

Hello
@hromadka , thank you for opening this issue.  The correct usage is now mode=backend.  If this code is not working for you, please make sure you've upgraded to Qiskit Runtime .24 or later.


Standard branch mirroring

Make "master" branch standard mirroring, not to switch later.

Hmm,, duplicated to https://github.com/gogits/gogs/issues/2225


Support more controller manager params for helm charts

Because of this pr, we should support more controller manager params for helm charts.

@freeznet I found that we can just use the default value, no need to add it to helm charts. What do you think?

@hantmac thanks, from my understanding, when user using function-mesh, they usally uses helm charts or OLM to install the operator into the k8s cluster. When using helm charts, user needs to change the values.yaml to make some customizations, and the manager's configs should be configurable from values. So I suggest we add the configurable fields to the values, and generate the args based on the values.

@hantmac thanks, from my understanding, when user using function-mesh, they usally uses helm charts or OLM to install the operator into the k8s cluster. When using helm charts, user needs to change the values.yaml to make some customizations, and the manager's configs should be configurable from values. So I suggest we add the configurable fields to the values, and generate the args based on the values.

Make sense. I will add the configurable fields to the values.


Can I add a button to the navbar?

Hi,
is there a way to add a button to the left side of the nav bar?
I need this to show a pop-up modal with the app info :)

You can pass your own navbar into the scene through the navBar prop.


Dataplane manager is not handling exceptions thrown by DataSource/Sink factories during instance creation

Bug Report
Describe the Bug
DataSource/Sink factories might throw exceptions in case the createSink() or createSource() fail (i.e. secrets not present in vault). These exceptions should be properly handled by the DataplaneManager.
Expected Behavior
Exception is handled and the retry mechanism in DataPlaneManagerImpl works, eventually leading the dataflow to a FAILED state without breaking the DataplaneManager state machine.
Observed Behavior
Exception is raised and thread fails, leaving the dataflow in an indefinite STARTED state without ever being retried and transitioned to a failed state.
Steps to Reproduce
Steps to reproduce the behavior:
Create a transfer process with a data destination of type AzureStorage that refers to keyName that doesn't exist in the Vault.
Detailed Description
Part of the stack trace.
SEVERE 2024-09-09T10:52:23.581195262 StateMachineManager [DataPlaneManagerImpl] error caught 2024-09-09T10:52:23.581515928Z java.lang.IllegalArgumentException: argument "content" is null 2024-09-09T10:52:23.581750928Z at com.fasterxml.jackson.databind.ObjectMapper._assertNotNull(ObjectMapper.java:5054) 2024-09-09T10:52:23.581761720Z at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3813) 2024-09-09T10:52:23.581769553Z at org.eclipse.edc.json.JacksonTypeManager.readValue(JacksonTypeManager.java:116) 2024-09-09T10:52:23.581771762Z at org.eclipse.edc.connector.dataplane.azure.storage.pipeline.AzureStorageDataSinkFactory.createSink(AzureStorageDataSinkFactory.java:86) 2024-09-09T10:52:23.581774012Z at org.eclipse.edc.connector.dataplane.framework.pipeline.PipelineServiceImpl.transfer(PipelineServiceImpl.java:102) 2024-09-09T10:52:23.581776428Z at org.eclipse.edc.connector.dataplane.framework.manager.DataPlaneManagerImpl.lambda$processReceived$3(DataPlaneManagerImpl.java:212) 2024-09-09T10:52:23.581778553Z at org.eclipse.edc.statemachine.retry.CompletableFutureRetryProcess.process(CompletableFutureRetryProcess.java:50) 2024-09-09T10:52:23.581780678Z at org.eclipse.edc.statemachine.retry.RetryProcess.execute(RetryProcess.java:71)

already fixed (on an higher level) by https://github.com/eclipse-edc/Connector/pull/4458

wait, was this thrown by CompletableFutureRetryProcess? looks like a different issue so, sorry.


High level API wrapping most common actions with Channels

In reference to issue #1
Rational
A high level API, or set of wrapper function, would drastically increase the usability and lower the barrier of entry of IOTA-Streams and more specifically IOTA Channels.
An additional level of abstraction would allow developers to more safely and quickly develop IOTA-Streams based use-cases. Without requiring deep knowledge of the underlying processes.
This is similar to the IOTA client API which has the option to use send_transfers() as  a single method instead of using prepare_transfer() + GTTA() + attach_to_tangle() + broadcast_transaction()
By giving both options, it is up to the developer to choose how much fine-tuning he is comfortable with.
Description
The API should have methods for the most common actions used in IOTA channels, these methods should also do most of the error handling to avoid confronting new developer with lower level errors.
for example:
For the Author

opening a channel
writing data to a channel
removing a subscriber from a channel

For the Subscriber

subscribe to a channel
read from a channel
unsubscribes from channel

These methods could be bundled inside a channel.
Examples
These are possible wrappings, which are not meant to be final by anyway, but should act more as a way to show how the complexity is decreased by condensing multiple steps :
open_channel(): creates the Author object, creates the announcement message and converts it to Trytes, generates the bundle and sends it to the node. It returns the message identifier.
write_to_channel(): converts a string or object to a public or masked payload, signs the payload and sends it.
remove_subscribers(): changes the author key, finds the subscribers that receive the new keys, published the new keys to those subscribers
subscribe_to_channel(): already good like its now, not much to condense
read_from_channel(): receives message, parses header to packet, checks content type, unwraps packet an returns it
unsubscribe_from_channel(): already good like its now, not much to condense
References
MAM Lite by stkubr: A high level API for python MAM with only 4 methods: open, write, read and split_channel
Pay-per-data by AleBuser: A high level API for python to buy/sell data over MAML with 5 methods: open, send_package, check_payment, listen_for_packages, make_payment

Example of high level API implementation for Using IOTA-Streams with Tangle as transfer medium to enable Channel Application.
This code is based on the channels-example repo by @JakeSCahill
https://github.com/AleBuser/channels-examples
The goal was to remove as much configuration details as possible from the API, making it very easy to create and write to a channel.
Progress:

[x] open channel
[x]  write to channel
[ ]  remove subscriber from channel
[ ] subscribe to channel (bundle bug to be fixed first)
[ ] read from channel (bundle bug to be fixed first)

First version of the implementation with full functionality (channel_author.change_key is missing):


Request to update "dishtv.in.channels.xml" with all latest channels

Guide
https://github.com/iptv-org/epg/blob/master/sites/dishtv.in/dishtv.in.channels.xml
Channels
E.g
MTV Beats
Times Now Navbharat
etc.
Notes
.

Take a look at the How do I add a program guide for the channel? guide, if would like to try adding the missing channels yourself.

sorry, but I am really not sure how I an get the latest full list of channels,
its really help, if you can update.

can someone assist please

Thank you

thanks


implement .infinite and .hinge classes

Could you please include these classes in scss?
In this way one could use for example: @extend .infinite; to implement this functionality in scss.
Currently the only way to make animations infinited is to copy/paste class from original animate.css.

That would be awesome to have.

+1


[Concurrency] Improve data-race detection for locals and globals

Improve data-race detection for local variables and global/static variables

Only diagnose these cases at all, not (e.g.) class instance members
For local functions, they run concurrently if they were referenced somewhere
that runs concurrently

The latter required moving checking of both actor isolation and effects
for local functions to the point at which their enclosing (non-local)
functions are checked, because we need to reason about the
type-checked bodies of local functions.

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please smoke test Linux


PyTorch compatibility with sct

I noticed that all sct functions that imply deep learning (deepseg_gm or  deepseg_sc for instance) use keras, should I switch from PyTorch to keras to implement the modality classifier ? Is it to reduce the list of dependencies or are there compatibility issues at stake ?

@bsauty if your current implementation uses Pytorch, I would suggest to create a branch in SCT repos with your implementation so it can be tested via Travis across several OSs. If it passes, then you're good to go with Pytorch. If not, we can look at where it breaks.
In the long term, it is likely that Pytorch will become our main framework.

Pytorch is now part of SCT's python package 😊


Update Schema Image

Sorry for the timing... between sequencing group updates and spicy 🌶  cohorts this is a bit of a transitional period, but can someone with a running local version of the metamist DB create an updated schema diagram for the sample-metadata repository Readme?

Updated version: https://dbdiagram.io/d/Metamist-Schema-v6-6-2-65a48ac7ac844320aee60d16


[R] Update NEWS for 18.0.0

Issue resolved by pull request 44520
https://github.com/apache/arrow/pull/44520


Add missing Azure products to availability-zones-migration-overview.md

Hi @anaharris-ms , I'm Penny Ko in MSFT.
I noticed there are a few Azure Services that wasn't being listed in the table even though there's docs in the TOC.  I've tried my best to add them here.
Please kindly check and review whether the reference links I've added are in the right format. Thank you!

@pinyuko - You have opened this PR in the public repo. Microsoft FTEs should generally work in the private repo.
@anaharris-ms - It's okay if you want to sign off on the minimal changes here rather than move the commits to the private repo.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Decrease batch size for seeds

Thanks for your work on this adapter, it's great.
The batch size to use when loading seeds is specified here as 100000.
I'm not sure how the 100k value was determined, but I ran into the following SQLite error when trying to load a seed file of 70k rows, 5 cols, 2.37MB (a dictionary of common words in 14 languages):
17:46:24  7 of 7 ERROR loading seed file main.synth_words ................................ [ERROR in 2.54s]
...
17:46:24  Database Error in seed synth_words (seeds/synth_words.csv)
17:46:24    too many SQL variables

I resolved the error by manually changing the batch size in macros/materializations/seed/seed.sql from 100k down to 10k.
SQLite's limits include SQLITE_MAX_VARIABLE_NUMBER

which defaults to 999 for SQLite versions prior to 3.32.0 (2020-05-22) or 32766 for SQLite versions after 3.32.0.

(I'm running SQLite 3.31.1.) It seems that the number of variables used in the seed query scales with batch size.
Sidebar: dbt itself specifies a maximum file size for seeds but this is only used to determine whether or not to hash the file. dbt discourages using very large seed files, but does not impose a limit as far as I can tell.
Would it be possible to decrease the batch size from 100k to say 10k or so? and/or use a configurable seed_batch_size parameter?
My guess is that the optimal value probably depends on both the number of rows and columns in the seed file, so it may be difficult to hard-code and justify any specific batch size. But something smaller, while resulting in more queries against the database, should still be fairly performant.

Bumping down to 10k sounds good, thanks for reporting this. I'll cut a new release containing this fix.


round to an even height and width to fix MC errors

Could you add a description to the ticket about why odd numbers are a problem for Mediaconvert please?


Schema + data migration for supplier categories enum

Remap: "carriage" -> "moving", everything else -> "other"

Proposed solution

Tradeoffs

Testing Done

Fixes #938 and possibly #937


Add ALLDBS-ALLTABLES extract

ALLDBS extracts one file per database.
ALLTABLES extracts one file per table.
Can you add ALLDBS-ALLTABLES which extracts one file per database and table?
(We can run the script twice to do this but an option would be welcome to save time... ^^)

duplicate #9


Fixing and improving error messages for the new regex engine.

@dwightguth please review.
I have no idea how tests passed when you merged the changes to the parser.

Hmm... I think with the new changes, the --parser newprogram option is broken. I will have a look at it tomorrow, so wait before merging this PR.

I don't think we're gonna fix the newparser option, but at least I fixed SDF to not fail anymore.
This is ready to be merged, so @dwightguth please review.


No module named 'retrieval'

Thank you for your excellent work, I meet a bug, as follows:
File "/data1/sjm/ZS_CIR/SPN4CIR/zscir/data_process.py", line 11, in
from retrieval import ImageDataset, extract_image_features
ModuleNotFoundError: No module named 'retrieval'
Can you help me?

Sorry for missing this file, I have uploaded it. You can try to pull the latest code.


Manually setting session ID

Is there a way to manually set the session ID during or after the client sdk gets initialized?
In our app, the session id is generated on the server side and passed into the client via a javascript variable e.g. window.myAiSessionId. We have multiple isolated client apps that share the same session so being able to share the same session id will allow us to track user flow across the apps. Thanks!

Try appInsights.context.session.id = "<some random id>"

Thanks! A manually set context.session.id works for me!


(maint) Update the README to reflect the name change of update

The update function has been renamed to transform. This commit
updates the README to reflect the name change.

Thanks. I actually had already done this but in the cljs branch. I cherry-picked that commit and everything's good now.


Answer text sometimes fails to load, and sometimes unloads after loading

Initially reported by Plex in Discord: https://discord.com/channels/677546901339504640/758062805810282526/1076611649487786085
Steps to reproduce:

Clear cache at https://ui.stampy.ai/questions/cache
Load https://aisafety.info/?state=2222_
If the question loaded correctly and the whole answer text appears, return to step 1

Expected behaviour:

The answer text loads reliably

Actual behaviour:

Occasionally the answer text fails to load at all (insufficient testing to provide a %age rate)
(Very?) rarely, the answer text loads, but then "unloads" and is replaced with the placeholder "Loading..." string

Tests performed and other notes:

API response from https://aisafety.info/questions/2222 seems to be correct even when the answer text doesn't render
Tested on at least three devices (Chris' iPhone and desktop, running Safari and Firefox respectively) plus whatever Plex uses

I suspect the steps to reproduce above are incomplete, as the failure rate seemed to slowly go to zero as I repeated the process. In my last ten or so attempt to clear my question cache and reload the page, the answer has loaded correctly every time, after failing quite reliably earlier on. I think the error smells a bit like a race condition, so if there's some network or application level caching happening that might have affected the timing of the network request I can imagine that might be responsible for the increase in my perceived reliability. Just a guess though!

It could be the way how infinite scroll de-duplicates answers, since the responses have text: null e.g.:
e.g. https://aisafety.info/questions/allOnSite?nextPage=https://coda.io/apis/v1/docs/fau7sl2hmG/tables/table-1Q8_MjxUes/rows?pageToken=eyJsaW1pdCI6MTAsIm9mZnNldCI6MTAsIm9wVmVyc2lvbiI6MzMxMjIsInNjaGVtYVZlcnNpb24iOjE3MSwic29ydEJ5IjoibmF0dXJhbCIsInVzZUNvbHVtbk5hbWVzIjp0cnVlLCJ2YWx1ZUZvcm1hdCI6InJpY2gifQ

@mruwnik can you please investigate?

Hopefully fixed by the above merge - if this bug doesn't reappear over the next week or so, this can be closed

Can this be closed?


wrong scopes

Wrong scopes after run the curl script:
curl -X POST
--url http://<IP_ADDRESS>:8001/services/mock-service/plugins/
--data "name=oauth2"
--data "config.scopes=email, phone, address"
--data "config.mandatory_scope=true"
--data "config.enable_authorization_code=true"
Following is the output:
{"created_at":1545989589,"config":{"refresh_token_ttl":1209600,"enable_client_credentials":false,"mandatory_scope":true,"provision_key":"TcHMQJvT7Iyk2tPlFYuqbJkUlHEYVW1a","accept_http_if_already_terminated":false,"hide_credentials":false,"enable_implicit_grant":false,"global_credentials":false,"enable_authorization_code":true,"enable_password_grant":false,"scopes":["email, phone, address"],"anonymous":null,"token_expiration":7200,"auth_header_name":"authorization"},"id":"a66aba0d-070c-4256-ae09-f2988b61ae9f","service":{"id":"9e6c0e17-70c8-4f9b-9604-7bbce191cb22"},"enabled":true,"run_on":"first","consumer":null,"route":null,"name":"oauth2"}
The correct "scopes" should be "scopes": [
"email",
"phone",
"address"
], not ["email, phone, address"].
It seems something wrong with the OAuth 2.0 plugins.
The version of kong is 1.0.0

Yes, I got the same error. At least, the scopes format below
--data "config.scopes=email, phone, address"
is not compatible with kong 1.2.1.
And based on the the doc of kong 1.2.1 "https://docs.konghq.com/hub/kong-inc/oauth2/"
the scopes can be also initiated as
--data "config.scopes=email"
--data "config.scopes=phone"
--data "config.scopes=address" \


No settings autocomplete after update to 1.76.0

Type: Bug
Vscode settings autocomplete stopped working after update to 1.76. I noticed that this is caused by the following setting:
"http.systemCertificates": false,

When it is enabled, vscode cannot load json schema and reports the following warning:
Unable to load schema from 'vscode://schemas/settings/user': cannot open vscode://schemas/settings/user. Detail: Unable to resolve text model content for resource vscode://schemas/settings/user.(768)

UPD. I completely removed this setting and there still no autocomplete. Looks like this issue is caused by something else
VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:25:16.105Z)
OS version: Linux x64 6.2.1-arch1-1
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 4700)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
0, 1, 1

Memory (System)
15.55GB (10.51GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions: none

My guess is that this is related to JSON schema validation not working in general with 1.76.0 (see #176591)

I can't make a 100% reproduce because it from time to time for unknown reasons: sometimes it is loaded correctly, sometimes not

Still happens in 1.77.0

duplicate of #177142


🛠 Code Cleanup and Organized Chaos 🧹

Ah, the excitement of creating something amazing like GamePulse! 🚀 As the project evolves, it's only natural for the code to get a bit wild and unorganized in the heat of development. We've all been there! 😄 But fear not, it's time for a code cleanup and some organized chaos!
In this issue, we'll tackle the task of cleaning up the codebase and organizing it into separate files and includes. Let's strive for that elusive perfect code, or at least get it a bit tidier! 🧹
Here's what we have in mind:
Module Magic: We'll identify reusable components and give them their own cozy homes in separate PHP files. Modularization FTW! 🏠
Separation of Zen: Each file will be aligned with its purpose, adhering to the Zen of separation. 🧘
Function Refactoring Party: Let's optimize and refactor functions for smoother, more efficient code. 🎉
Docs and Comments: We'll add comments and docs to guide future travelers exploring this code. 🗺
Coding Style Fun: Consistency is the name of the game! We'll keep it stylish and consistent for all to enjoy. 💅
And hey, if you've got some programming experience, this is a great way to make your first contribution to the project.
Let's make GamePulse's codebase shine and impress future developers! 🌟

Hello, I am Roog. Perhaps we should consider using some mature PHP web frameworks to organize the code, such as the very popular Laravel. Or, are you guys trying to build your own web framework? In that case, you might want to refer to the PSR and PER standards from PHP-FIG. I believe they can make collaboration smoother.

Hello @Guxinpei, Hello Roog,
Thank you for your suggestion.
We're actively exploring ways to enhance our code structure, and your idea of using mature PHP web frameworks like Laravel is very interesting. We understand the importance of well-organized code and common standards to facilitate collaboration. We appreciate your contribution and are open to any additional advice you may have for this project. Feel free to share any further ideas.
Thanks again for your involvement 👍


v3.14.5: stream usages

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #163 (3e4c722) into master (97e90c6) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   26.07%   25.84%   -0.24%
==========================================
  Files          64       62       -2
  Lines       10591    10617      +26
==========================================
- Hits         2762     2744      -18
- Misses       7650     7695      +45
+ Partials      179      178       -1

Flag
Coverage Δ

1.14.x
?

1.15.x
25.84% <0.00%> (-0.24%)
:arrow_down:

1.16.x
25.84% <0.00%> (-0.13%)
:arrow_down:

1.17.x
?

macOS-latest
?

ubuntu-latest
25.84% <0.00%> (-0.28%)
:arrow_down:

unit
25.84% <0.00%> (-0.24%)
:arrow_down:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

trace/driver.go
0.00% <ø> (ø)

trace/driver_gtrace.go
0.00% <0.00%> (ø)

internal/table/client.go
84.16% <0.00%> (-1.89%)
:arrow_down:

cmd/gtrace/internal/test/test_gtrace_windows.go

...d/gtrace/internal/test/test_gtrace_darwin_amd64.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e90c6...3e4c722. Read the comment docs.


[Dribbbish Theme] Playlist icon goes crazy

If you double click on a playlist it goes like this:

After this you can't open the playlist.

I just fixed it, please pull the repo to update.


PytestAutomation Integration

Enables pytest action workflow
Adds PytestAutomation plugin integration (https://github.com/asfadmin/Discovery-PytestAutomation)
Adds various tests for different asf_search modules

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@03d2167). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage          ?   78.73%
=========================================
  Files             ?       23
  Lines             ?      442
  Branches          ?        0
=========================================
  Hits              ?      348
  Misses            ?       94
  Partials          ?        0

Flag
Coverage Δ

unittests
78.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d2167...b3dfc36. Read the comment docs.


Moved position params to top

Learn Build status updates of commit 79ffac0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-Contact.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DetailsTemplate.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ExchangeServer.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ExchangeSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-LinkedUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailboxDatabase.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailboxDatabaseCopyStatus.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailContact.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailPublicFolder.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationBatch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationEndpoint.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-OabVirtualDirectory.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-OfflineAddressBook.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PolicyTipConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolder.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMailboxMigrationRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMigrationRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMoveRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Recipient.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-SecurityPrincipal.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-SystemMessage.md
:white_check_mark:Succeeded
View (exchange-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 16876dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-Contact.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-DetailsTemplate.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-EventLogLevel.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ExchangeServer.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ExchangeSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-LinkedUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailboxDatabase.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailboxDatabaseCopyStatus.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailContact.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailPublicFolder.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MailUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationBatch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationEndpoint.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-MigrationUser.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-OabVirtualDirectory.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-OfflineAddressBook.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PolicyTipConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolder.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMailboxMigrationRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMigrationRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-PublicFolderMoveRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-Recipient.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-SecurityPrincipal.md
:white_check_mark:Succeeded
View (exchange-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Grammar: use a different color for flow control

Readability of contracts can be increased by using a different colors for flow control oriented keywords:

if
match
unwrap*
try
assert

We investigated this and concluded that this might not be doable at the grammar level, but could be completed at the LSP level.
We can reconsider this in the future.


Netlify.tomly example incorrect

In the following example of netlify.toml
[[plugins]]
package = "netlify-plugin-jest"

  [plugins.inputs]
  # all inputs for this plugin are required, but have default values

netlify-plugin-jest is not the correct package name currently.
I had to do the following, after that everything worked:
[[plugins]]
package = "@uwhealth-public/netlify-plugin-jest"

  [plugins.inputs]
  # all inputs for this plugin are required, but have default values

To other devs, I am not sure this package works anymore, it seems to run netlify tests twice.


Add prefix wwf.ecoregion

Prefix
wwf.ecoregion
Name
World Wildlife Fund Ecoregion
Homepage
https://www.worldwildlife.org/biomes
Description
WWF ecoregions are large unit of land or water containing a geographically distinct assemblage of species, natural communities, and environmental conditions.
We include xrefs to them from ENVO https://github.com/EnvironmentOntology/envo/issues/658
Wikidata also links to them
https://www.wikidata.org/wiki/Q929975
https://www.wikidata.org/wiki/Property:P1294
Example Identifier
AT1402
Regular Expression Pattern
AT\d+
Redundant Prefix in Regular Expression Pattern
wwf.ecoregion:AT\d+
Provider Format URL
https://www.worldwildlife.org/ecoregions/$1
Additional Comments
No response

Thanks for the submission. I've made the following updates:

Moved parts of the description to the "comments" section
Manually added the wikidata fields into the structured fields (I made a new issue #155 for adding further fields to the form)
The redundant prefix that you added wasn't necessary - this is only for situations like GO, CHEBI, and other OBO nomenclatures where people sometimes double it up. I removed it


[No QA]Use ubuntu-latest-xl and macos-12-xl large runners to speed up deploys

Details

This change configures compute intensive portions of the deploy process to use GitHub large runners. We've seen a speed up of 15 minutes by using a large runner for iOS builds and would like to continue to speed up the deploy process with these runners.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/287645
Tests

Enabled a large runner for lint.yml for a test
Verified the run passed and worked as expected: https://github.com/Expensify/App/actions/runs/5337076898/jobs/9672624927

Offline tests

N/A
QA Steps

N/A

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
N/A - Workflow code only

Mobile Web - Chrome
N/A - Workflow code only

Mobile Web - Safari
N/A - Workflow code only

Desktop
N/A - Workflow code only

iOS
N/A - Workflow code only

Android
N/A - Workflow code only

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:shipit:

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.30-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.32-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Hello @AndrewGable , I don't know if I am supposed to say it here but I am experiencing problems with lint with this change.
My PR is:
https://github.com/Expensify/App/pull/21918
As you can see since I merged this change my lint check throws the error
"FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory"
The last commit I revert your change and Lint works as expected, do you know what could be the issue ?

And I have seen that someone else had the issue yesterday here
https://github.com/Expensify/App/actions/runs/5417748106/jobs/9849053576

Hey @ShogunFire, usually we use the #expensify-open-source room in Slack to discuss these types of issues. It looks like on your latest commit lint passed without an error.
If you are still having issues can you ping me in that slack room? I'm @andrew on Slack. Thanks!


fix: 3606 - much faster "confirm image upload" action

Impacted files:

background_task_image.dart: added cropped file, rotation and crop parameters; now we upload the full image and then send the rotation/crop parameters to apply
new_crop_page.dart: now we create two files - the full image, to be sent to the server with rotation/crop parameters, and a small cropped file, for the transient image
rotated_crop_controller.dart: now we can crop into max-sized files
rotation.dart: added helper methods for off-dart rotation/crop tool.

What

When we are on the "crop page", the "confirm" action could be slow (several seconds), especially on "canary" devices.
When we clicked on "confirm", we computed the full cropped image and stored it into a file. That took time.
And off-dart/server have an API to rotate/crop an image.
The idea of this PR is to let the server rotate/crop the image - doing so we just have to send the full file and the rotation/crop parameters, and we get rid of the lengthy operations locally.
Still, we needed a transient version of the cropped file, to be displayed to the user before the file is finally uploaded.
Therefore, we create a cropped image file - yes, like the one that took time to create. But smaller, as here we limit the size of the cropped image to the max size of the screen. Which is smaller than those crazy 15Mb+ pictures, and which is good enough for the user on a smartphone.

Fixes bug(s)

Fixes: #3606

Codecov Report

Merging #3611 (61b5324) into develop (380294f) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3611      +/-   ##
===========================================
- Coverage    10.92%   10.86%   -0.07%
===========================================
  Files          266      266
  Lines        13136    13209      +73
===========================================
  Hits          1435     1435
- Misses       11701    11774      +73

Impacted Files
Coverage Δ

...ooth_app/lib/background/background_task_image.dart
0.00% <0.00%> (ø)

...s/smooth_app/lib/tmp_crop_image/new_crop_page.dart
0.00% <0.00%> (ø)

...pp/lib/tmp_crop_image/rotated_crop_controller.dart
0.00% <0.00%> (ø)

...ckages/smooth_app/lib/tmp_crop_image/rotation.dart
1.78% <0.00%> (-0.72%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cropping and server side selection will eventually allow us to handle things like that as well

Thank you @teolemon for the review!
Of course I understand the added-value of server cropping theoretically, but I cannot visualize the UX for that, especially on smartphones. We'll see!

The UX from the old Android app worked.
This issue is not very explicit on how you enter the mode or doesn't show the list of images present on the server (basically a grid)
https://github.com/openfoodfacts/smooth-app/issues/766
I have made a small video that I will post as a complément
https://user-images.githubusercontent.com/1689815/213939259-57e41db2-433f-4b70-861c-43e30335e8fb.mp4


CNV-39286: Fix NetworkPolicy SyncedEditor

The SyncedEditor was not working properly. It had no sidebar. Here the sidebar is important as it shows samples and schema info for the creation.
Other than that, I had to change something in the form to make the sync work. This means that when you change something in the yaml editor, you can see the change if you switch to form

Hei @hstastna i updated the description but in general there were small fixed to make the syncededitor work


Update README.md

Added a gif,to make it look interesting.

Yeah. The Organization(and the repository) has been made real quick in a span of a few hours.
Already thinking of adding emojis and gifs.
Though thanks for your PR. The gif is apt :smile:
Will merge it soon.

sure. would it be alright if i add another PR for resources?

For resources, it will be better if you consider sending them in the slack first. If all the admins approve you can create a PR here too. Otherwise, there will be just too many unnecessary PRs here.

Sure. Thanks!


Update fork-a-repo.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

fork this repo

gygu

@akanshabaishwade
This seems to be opened accidentally, I am going to close it now :yellow_heart: Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions :sparkles:


PT#140440299 - Refactor notificaitons

https://www.pivotaltracker.com/story/show/140440299

Refactor EventNotification to support info, warn, error, success types as per https://github.com/ManageIQ/manageiq/blob/master/app/models/notification_type.rb#L9
EventNotifications.bach now accepts results of batch operation, for all actions executed over 6 items, rather than spamming the user with toasts, the correct notification tray dropdown is indicated with the action results
Refactoring for cleanliness/clarity event notifications service and navigation controller

as with https://github.com/ManageIQ/manageiq-ui-service/pull/665, only those operations that support batch feedback will be benefit from these efforts
rather than being spammed with 9 toasts, a single toast indicating the results of the batch operation is shown

aftermath of batch operation

we still show individual toasts up to 6

Different warning types show up in different notification dropdowns

@chriskacerguis soooooo we probably want fine/no for this right?

Yeah, fine/no I wouldn't get consider this a blocker.


v1.4.9

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: host: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6
requirements: run: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: host: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6
requirements: run: python>=3.6 must contain a space between the name and the pin, i.e. python >=3.6
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi @alejoe91; I think this is ready to merge making the latest MEAutility release available also via conda-forge :)


Problems accessing SPLines FitPoints

Hello, I am a beginner in China. I found this problem when using this netdxf library:
When some graphics are spline curves generated by other software, no fitting points are generated in the dxf file, you need to open it with the higher version of AutoCAD software, change the display mode of the spline curve from control points to fitting points, and then save It is a DXF file. At this time, there will be fitting point data in the dxf file, but the netdxf library cannot read these fitting points.
I don't know if it is a problem with my program, or a problem with nextdxf. This passage was translated through Google translation software, I don’t know if it is correct. Thanks!

I do not see any problems reading the fit points, just make sure they are actually present in the DXF.

I may be mistaken, there is no fitting point of the spline curve in the DXF file generated by the higher version of autoCAD


Make auto_dereference optional

Automatic dereferencing is needed for complex objects that may contain embedded documents (or dbrefs), but is a huge performance hit for large and frequently-accessed data structures. Make it possible to disable it for specific fields.

Looks good


Convert  tags in  into actual elements

This is the same general issue as with the newspaper articleText elements, which contain escaped angle brackets where they are used for markup, but don't escape other angle brackets, or ampersands.

fixed in 3802f60
over to you @mraadgev


Can you add a requirements.txt?

Hi @yanchaoz,
I am very interested in your paper MICCAI 2024, it is an outstanding piece of work, thank you for sharing the code and data.
Now I want to reproduce the code of your paper, but the version of the experimental environment and package is not certain. Could you please add the requirements.txt or docker of the experimental environment？

Hi  @Mariosz2,
Thank you for your interest! I’ve added the requirements.txt to the repository.
Best regards,
Yanchao

Thank you very much!

Hello @yanchaoz,
I tried the requirements.txt you added for environment configuration, but the process didn't go very well. On the one hand, some libraries in the code such as em_segLib are not described in requirements, and on the other hand, there are conflicting library versions in requirements.
Is it convenient to make a docker environment? I am very grateful if it is possible, and your method can be reproduced more conveniently and simply.
Best regards,
Shushen


hyperlinks in jupyter notebook are missing when converted to html with nbsphinx+sphinx

I use sphinx with nbsphinx to generate HTML files from Jupyter Notebook files. But hyperlinks in the notebook doesn't show up in the converted html file. More precisely

I have an index.ipynb which contains an cell with html-style hyperlink Google to the Google website.
I use the sphinx command make html with nbsphinx as an extension to generate the documentation
In the output index.html, the hyperlink turns into un-formated text, namely only the plain text Google appear in the source code of index.html, the hyperlink  part just disappears.

Does nbsphinx keep the hyperlinks in the notebook when used in sphinx as an extension?

Why is this the case, when regular Markdown supports html tags like ?
This can be useful when for example wanting to use a hyperlink with a class.
I noticed many other tags are stripped as well, e.g.  and .
And writing
test
 results in

test

 which is unexpected.
Is there a workaround for this other than using raw NBConvert html cells?
From the documentation

Maybe these parts of the documentation should be clarified if certain html tags are stripped.

Why is this the case, when regular Markdown supports html tags like ?

Simply because nobody has implemented it yet.
And until this very issue, nobody has requested it either.
This is quite easy to implement if you just want to simply convert Markdown to HTML and nothing else.
In the case of nbsphinx it is a bit more complicated, though.
The Markdown content is first converted (by pandoc plus some AST manipulations) to reStructuredText which is then converted to the internal representation of Sphinx/docutils.
From this internal representation, Sphinx can generate HTML and LaTeX (and EPUB, and ...) output files (involving some further custom manipulations).
Raw HTML snippets which are just passed through will be missing in the LaTeX output.
There are already two special cases implemented which also work with LaTeX output:  and
.
Theoretically, a third special case for  could be added.

This can be useful when for example wanting to use a hyperlink with a class.

I guess this could be implemented. Do you want to make a PR?

I noticed many other tags are stripped as well, e.g. , ,
...

I guess they get lost in the conversion from Markdown to reStructuredText.
I think they are swallowed by pandoc. I don't know if it's possible to avoid that.
In the long term, I'd like to avoid the intermediate reStructuredText representation (and the use of pandoc), see #36 (but this might still take quite a while). But then it might be easier to fix this.

And writing
test
 results in

test

 which is unexpected.

OK, that's strange, that's probably an artifact caused by the use of the various tools mentioned above.

Is there a workaround for this other than using raw NBConvert html cells?

You can write something like this in your Markdown cell:

[Google](https://google.com)

The
 tags will survive the conversion and then you should be able to use a CSS selector like .my-class a to select the link.
Alternatively, you could try if MyST-NB handles this situation more to your liking.
You can also try RunNotebook (which uses a more direct Markdown-to-HTML conversion) or any of the alternatives mentioned in https://nbsphinx.readthedocs.io/en/0.7.0/links.html.

Maybe these parts of the documentation should be clarified if certain html tags are stripped.

Yes, definitely, the documentation is missing some important information here!
Would you like to make a PR to fix this?

I will look into pandoc and see if there are options for converting html tags, that might be the cleanest solution.
Regarding the documentation: not just div seems to be supported, but audio and some others as well. If you know by any chance where these special html tags are converted to rst that would be a great help. Happy to make a PR for the docs, not sure if making an exception for just a tags would be worth it though.

Not sure if that might be out-of-scope for this issue, but my original use-case for  tags was that I wanted to replicate automatically linking to classes generated with autodoc as is possible in rst, e.g.:
:class:`.SomeClass`

And my specific problem was that I could not replicate the html the above line would generate in markdown. Long story short, pandoc actually extends markdown and accommodates this case with
`.SomeClass`{.interpreted-text role="class"}

This won't be nicely displayed in a notebook, but that would have been a long shot either way.
I think the documentation should more clearly say that Markdown cells are treated as pandoc markdown, I will submit a PR for that later.
Interestingly enough, any pandoc markdown that involves div, does not seem be supported by nbsphinx (maybe there is custom code for div in place?)
If I'm not mistaken, one could even add autodoc using the following:

some_module.submodule

Regarding the documentation: not just div seems to be supported, but audio and some others as well.

Yes, I think <audio> and <video> are the most relevant, that's why I'm showing them in https://nbsphinx.readthedocs.io/en/0.7.0/markdown-cells.html#HTML-Elements-(HTML-only).

If you know by any chance where these special html tags are converted to rst that would be a great help.

The pandoc options are here:
https://github.com/spatialaudio/nbsphinx/blob/992d55504d8cf52de62a47c9fef4fdc157434314/src/nbsphinx.py#L1362-L1366
The +raw_html setting passes some HTML tags (but apparently not all?) through.
Then there is some special handling for citations ans  tags, but <audio> and <video> don't need special handling.
You can check pandocs behavior like this:
$ pandoc -f markdown-native_divs -t rst

bla

^D
.. raw:: html

bla

.. raw:: html

Note that for (future) CommonMark compatibility, blank lines should be used inside the
 tags:
$ pandoc -f commonmark -t rst

bla

.. raw:: html

bla

vs.
$ pandoc -f commonmark -t rst

bla

^D
.. raw:: html

bla

.. raw:: html

Happy to make a PR for the docs,

That would be great!

not sure if making an exception for just a tags would be worth it though.

I don't know, probably not.

Not sure if that might be out-of-scope for this issue, but my original use-case for  tags was that I wanted to replicate automatically linking to classes generated with autodoc as is possible in rst, e.g.:
:class:`.SomeClass`

My work-around for autodoc links is https://nbsphinx.readthedocs.io/en/0.7.0/markdown-cells.html#Links-to-Domain-Objects.
This is of course not as simple as :class:`SomeClass` , but the advantage is that the links also look somewhat reasonable in JupyterLab/nbviewer/Github.

I think the documentation should more clearly say that Markdown cells are treated as pandoc markdown, I will submit a PR for that later.

I would prefer not mentioning pandoc, because it is just an implementation detail which will be removed in the (rather far) future.
I think it would be better to mention a few tags that work (e.g.
, <audio>) and vaguely mention that not all tags work.
This way we are open for future changes in behavior.

Interestingly enough, any pandoc markdown that involves div, does not seem be supported by nbsphinx (maybe there is custom code for div in place?)

nbsphinx uses the -native_divs option, maybe that's the culprit?
The raw
 tags are parsed in the ReplaceAlertDivs transform, in order to find "alert" divs which are turned into "notes"/"warnings".
But all other
 elements should be passed through?

If I'm not mistaken, one could even add autodoc using the following [...]

You mean instead of using the automodule directive?
Why not just use a raw reST cell (or a separate reST source file) for that?

Regarding the documentation: not just div seems to be supported, but audio and some others as well.

Yes, I think <audio> and <video> are the most relevant, that's why I'm showing them in https://nbsphinx.readthedocs.io/en/0.7.0/markdown-cells.html#HTML-Elements-(HTML-only).

If you know by any chance where these special html tags are converted to rst that would be a great help.

The pandoc options are here:
https://github.com/spatialaudio/nbsphinx/blob/992d55504d8cf52de62a47c9fef4fdc157434314/src/nbsphinx.py#L1362-L1366
The +raw_html setting passes some HTML tags (but apparently not all?) through.

My use of a markdown cell is usually just a mixture of plain text, HTML tags, images and Latex code, nbsphinx + sphinx handle everything smoothly except those tiny HTML tags,  so is it possible to handle more HTML tags like  by just modifying the +raw_html settings a little bit?

I don't know. Probably. How would you modify them?

My work-around for autodoc links is https://nbsphinx.readthedocs.io/en/0.7.0/markdown-cells.html#Links-to-Domain-Objects.

I saw that workaround, unfortunately it does not fully replicate the styling that is applied when linking to domain objects in sphinx. Functionally it does the same though, so it is a solution.

I saw that workaround, unfortunately it does not replicate the styling that is applied when linking to domain objects in sphinx.

Yeah, I know, the problem is that reST doesn't allow nested markup, see #301.
This will hopefully become possible when #36 is solved, but this might take some more time ...


Invalid shape error during prefix tuning ByT5

Environment info

adapter-transformers version: 3.2.1
Platform: Linux
Python version: 3.10.10
PyTorch version (GPU?): 2.0.0+cpu
Tensorflow version (GPU?): N/A
Using GPU in script?: no
Using distributed or parallel set-up in script?: no

Information
Model I am using (Bert, XLNet ...): ByT5
Adapter setup I am using (if any): Prefix Tuning
The problem arises when using:

[ ] the official example scripts: (give details below)
[x] my own modified scripts: (give details below)

To reproduce
Steps to reproduce the behavior:
import transformers

model = transformers.AutoModelForSeq2SeqLM.from_pretrained("google/byt5-small")
tok = transformers.AutoTokenizer.from_pretrained("google/byt5-small")

model.add_adapter("my_adapter", "prefix_tuning", set_active=True)

model(**tok(["input text", "input text 2"], text_target=["output", "output 2"], return_tensors="pt", padding=True))

throws the following exception
Traceback (most recent call last):
  File "/home/matthias/phd/artificial_tasks/preft.py", line 8, in <module>
    model(**tok(["input text", "input text 2"], text_target=["output", "output 2"], return_tensors="pt", padding=True))
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/context.py", line 104, in wrapper_func
    with cls(self, *args, **kwargs) as ctx:
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/context.py", line 86, in __init__
    model.forward_context(self, *args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/model_mixin.py", line 871, in forward_context
    context.prefix_states = self.base_model.prefix_tuning(*args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/prefix_tuning.py", line 220, in forward
    prefix_states[name] = self.prefix_tunings[name](batch_size)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/prefix_tuning.py", line 117, in forward
    return {k: v(batch_size) for k, v in self.items()}
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/prefix_tuning.py", line 117, in <dictcomp>
    return {k: v(batch_size) for k, v in self.items()}
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/matthias/miniconda3/envs/meta_adapters/lib/python3.10/site-packages/transformers/adapters/prefix_tuning.py", line 54, in forward
    key_values = key_values.view(
RuntimeError: shape '[2, 30, 24, 6, 245]' is invalid for input of size 2119680

I suspect this happens because the number of layers in the encoder and the decoder are not the same for ByT5 unlike most transformer models.

This should be fixed since the release of the new adapters package, succeesind adapter-transformers. Please re-open if the issue still persists.


(FACT-1645) update os_processors_and_kernel.rb to support Linux on Power

CLA signed by all contributors.


ts3client is missing a library?

Issue description
Recently ts3client broke. Maybe related to my moving from 17.09 to unstable.
Is there anything I can to work around this?
Steps to reproduce
 % ts3client
QCoreApplication::applicationDirPath: Please instantiate the QApplication object first
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: xcb.

Reinstalling the application may fix this problem.
[1]    9294 abort      ts3client

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.8, NixOS, 18.03pre123588.ade98dc442e (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 1.11.16`
 - channels(root): `"nixos-18.03pre123588.ade98dc442e"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

To add some info, the very same version of teamspeak_client runs on another PC with nixos, and the only difference seems to be:
$ find /nix/store -name libqxcb.so
/nix/store/phscfzkf1h0p3p325rn22m4avv82yxgs-qtbase-5.6.3-bin/lib/qt-5.6/plugins/platforms/libqxcb.so
/nix/store/0ixf7xg759kfr3pbamcpbn438rzi6vqz-qtbase-5.9.3-bin/lib/qt-5.9/plugins/platforms/libqxcb.so
/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so

qtbase versions are more recent on the current machine where it doesn't work (on my other machine there are on version 5.9.1 and 5.6.2). Maybe ts3client is using a libqxcb.so from qtbase and breaks when they are not compatible anymore?

Ok, seems that my previous hypothesis is wrong:
 % QT_DEBUG_PLUGINS=1 ts3client
QCoreApplication::applicationDirPath: Please instantiate the QApplication object first
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/ql93xakdkxr4yf65pxbdir2bzy9rq1hg-kitty-0.5.0/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/p0ljc7gk9l0phd13war9l4wd458bv2gx-imagemagick-6.9.9-26/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/21jkxacqk7raayg9w932qsjbdmlc4h56-xsel-unstable-2016-09-02/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/home/eeva/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/run/wrappers/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/etc/profiles/per-user/eeva/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/home/eeva/.nix-profile/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/var/nix/profiles/default/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/run/current-system/sw/lib/qt-5.6/plugins/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/platforms" ...
QFactoryLoader::QFactoryLoader() checking directory path "/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms" ...
QFactoryLoader::QFactoryLoader() looking at "/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so"
Found metadata in lib /nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so, metadata=
{
    "IID": "org.qt-project.Qt.QPA.QPlatformIntegrationFactoryInterface.5.3",
    "MetaData": {
        "Keys": [
            "xcb"
        ]
    },
    "className": "QXcbIntegrationPlugin",
    "debug": false,
    "version": 329217
}

Got keys from plugin meta data ("xcb")
loaded library "/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so"
QLibraryPrivate::loadPlugin failed on "/nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so" : "Cannot load library /nix/store/xcl0243lnpix1sdg0adbf69x963akrmp-teamspeak-client-3.1.6/lib/teamspeak/platforms/libqxcb.so: "
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: xcb.

Reinstalling the application may fix this problem.
[1]    13921 abort      QT_DEBUG_PLUGINS=1 ts3client

https://github.com/Studio3T/robomongo/issues/1384
If we're in the same case, looks like it could be linked to an incompatible libc? Problem is, there are no details in the error message…

@dtzWill will you be proposing a PR for this?

I have just opened a PR https://github.com/NixOS/nixpkgs/pull/41137 hopefully fixing this.
For future reference:
LD_DEBUG=libs QT_DEBUG_PLUGINS=1 result/bin/ts3client gives reasonably useful debugginf information.


Improvement - Move examples from $content to templates

Describe current situation
Describe what the current situation and what problem it is causing for this improvement
Right now we are using $content control inside some of the stories (headline as an example) to show code example. This might be causing problems in the future, when showing multiple examples in storybook. We should utilize the controls/templates the correct way https://storybook.js.org/docs/react/essentials/controls
export const Headlines = Template.bind({});
Headlines.args = {
  content: `

Headline

Headline

A headline for page layouts

A headline for page layouts

A sub headline, which is most commonly paired with body-01

A sub headline, which is most commonly paired with body-02

  <h7>A sub headline, which is most commonly paired with detail-02 </h7>
  `
}

Describe the improvement
A clear and concise description of what kind of improvement you have in mind.
Instead we should use the templates more to solve multiple examples,
export const Headlines = coolHeadlineTemplate.bind({});

If applicable, please provide steps to reproduce
Steps to reproduce the behavior:

Go to headline story code
Look at the $content

AB#170

Done


Add manage_repo

Fixes #93

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @cdenneen I've updated the description and I am currently in the process of testing the changes.

I see the test failure. I had this issue with public pdk docker image. I ended up having to build my own or you can force your Gemfile to keep the version of ffi that ships with current pdk you are using.

@cdenneen The PR has been merged, I will try to have a release ready as soon as possible


Add validate_dataset and regenerate_dataset methods

Closes #447
This PR adds two methods to the Dataset API: validate_dataset and regenerate_dataset.  For both methods, the actual logic is located within the underlying engine (within methods of the same name).
validate_dataset
The purpose of the validate_dataset method is to validate that a Dataset object meets the minimal requirements for efficient NVTabular processing.  The return value for the method is a bool, but warnings will also be raised to provide the user with feedback/suggestions.  For now, the dataset must be backed by parquet files to pass the validation.  If the user tries to "validate" a non-parquet dataset, they will just get a return value of False (and a warning message explaining that Parquet is the recommended format).
If the user asks to validate a parquet-backed dataset, the ParquetDatasetEngine will check the following:

The raw dataset directory should contain a global "_metadata" file.  If this file is missing, add_metadata_file=True can be passed to generate a new one automatically within validate_dataset.
If there is no _metadata file, the parquet schema must be consistent for all row-groups/files in the raw dataset. Otherwise, a new _metadata file must be generated to avoid errors at IO time.
The row-groups should be no larger than the maximum size limit (row_group_max_size).
For multi-file datasets, the files should be no smaller than the minimum size limit (file_min_size).

The ParquetDatasetEngine.validate_dataset method will suggest the user try using regenerate_dataset if/when any of the above checks do not pass. For example:
ds = nvt.Dataset(path, engine="parquet", part_size="1GB")
ds.validate_dataset()

/.../NVTabular/nvtabular/io/parquet.py:305: UserWarning: File part.0.parquet is smaller than the desired dataset partition size<PHONE_NUMBER>). Consider using the regenerate_dataset utility to rewrite your dataset with a smaller number of (larger) files.
...
False

regenerate_dataset
If the user does not have a "valid" (optimal) dataset for NVTabular, regenerate_dataset can be used to produce a proper parquet dataset with appropriate/desired properties.  Although the user may specify a desired output_format, only "parquet" (the default) is supported.  The ParquetDatasetEngine backend will handle the following args/kwargs:
output_path : string
    Root directory path to use for the new (regenerated) dataset.
columns : list[string], optional
    Subset of columns to include in the regenerated dataset.
file_size : int or string, optional
    Desired size of each output file.
part_size : int or string, optional
    Desired partition size to use within regeneration algorithm.
    Note that this is effectively the size of each contiguous write
    operation in cudf.
cats : list[string], optional
    Categorical column list.
conts : list[string], optional
    Continuous column list.
labels : list[string], optional
    Label column list.
storage_options : dict, optional
    Storage-option kwargs to pass through to the `fsspec` file-system
    interface.

For example, an existing datset at path can be regenerated in the new_path directory with code like:
ds = nvt.Dataset(path, engine="parquet", part_size="1GB")
ds.regenerate_dataset(
    new_path, file_size="10GB", cats=["id", "name"], conts=["x", "y"], labels=["label"]
)

Note that the regenerate_dataset call will write the _metadata, _file_list.txt, and _metadata.json files in the new_path directory.  Therfore, to ensure that _metadata.json is written "correctly," the user must specify the cats, conts, and labels.
TODO:

[x] Add validate_dataset

[x] Add API
[x] Add test(s)

[x] Add regenerate_dataset

[x] Add API
[x] Add test(s)

[ ] Update Dataset docs

[ ] validate_dataset
[ ] regenerate_dataset

@benfred @EvenOldridge - This PR is now "up to date."  Please let me know if there are any realistic use cases I can/should test with.

@benfred @EvenOldridge - This PR is now "up to date."  Please let me know if there are any realistic use cases I can/should test with.


(No. 17 B) Export/Print Filters/Parameters [ Hard ]

from #93 :
I suggest including “optimization parameters” as a potential export along with the results. If users print and export their results they may need to understand the parameters they used for each result.

Dupe of #106


shell option does not work for node installed via nvm

I have installed node js via nvm on Debian server.
I try to use rocketeer for deployment, but when I try to run a task in after deploy hook, it does not recognize npm, though in normal login session everything works well.
With rocketeer I get the following output:
$ cd admin/frontend
$ bash --login -c 'npm install'
(production) bash: npm: command not found

I should note, that running bash --login -c 'npm install' gives pretty much the same ouput, but if I log in via ssh under that user and run npm install or if I run bash --login and then run the command it works perfectly fine.
So, I suppose that running bash --login -c does not load .bashrc or .profile for the commands which are specified for -c option and it should be something else rather than bash --login -c for shelled mode.

Hm I don't think that's related, I use NVM successfully with shell mode, are you sure you don't have anything else interfering?

I don't think so, that was a clean Debian 7 setup made just a day ago, nothing special is installed there, just nvm, php, mysql.

And, by the way, if I run bash --login -c 'nvm list'on my local Ubuntu desktop, I also get command not found error, but if I run simple nvm list everything is fine. So, I suppose there is an issue with commands running via bash --login -c

Did a test with both NVM and RVM on a different server, here is the result:
user@123:~$ rvm list

rvm rubies

   ruby-2.0.0-p594 [ x86_64 ]
   ruby-2.1.3 [ x86_64 ]
=* ruby-2.1.5 [ x86_64 ]

# => - current
# =* - current && default
#  * - default

user@123:~$ nvm list
->  v0.10.33
      system
default -> stable (-> v0.10.33)
stable -> 0.10 (-> v0.10.33) (default)

user@123:~$ bash --login -c 'nvm list'
bash: nvm: command not found

user@123:~$ bash --login -c 'rvm list'

rvm rubies

   ruby-2.0.0-p594 [ x86_64 ]
   ruby-2.1.3 [ x86_64 ]
=* ruby-2.1.5 [ x86_64 ]

# => - current
# =* - current && default
#  * - default

NVM was installed with the following commands:
curl https://raw.githubusercontent.com/creationix/nvm/v0.18.0/install.sh | bash

source ~/.nvm/nvm.sh

nvm install stable

nvm use stable

nvm alias default stable

Looks like there is something with .bashrc of nvm, but don't know what (

For anyone interested, I was able to resolve my issue by adding the following to the end of .profile instead of .bashrc:
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm

Still, not sure if that's an issue of nvm or rocketeer, so leaving this issue opened.

Issue is not with Rocketeer indeed, worked everywhere I've used it, this is more of a configuration issue indeed. NVM and RVM are always tricky to work like that since they're booted at login instead of being a functioning globally available binary

OK, I agree, totally true.
@Anahkiasen thanks for quick replies.


Validate Java package names

In new app engine wizard, show some sort of error when user has typed an illegal package name such as one that contains spaces.

From the Developers Console when using a period
Project name has invalid characters. Enter letters, numbers, quotes, hyphens, spaces or exclamation points.


Iterate on new test icons experiments

These experiments enable icons for "run all failed tests" and "refresh tests"  in the test explorer. We have a hypothesis that these are useful actions to have in the test explorer, so with the experiments we will be able see if it holds true with all kinds of users.

[x] Turn "run all failed tests" to 100% of insider and 10% of stable users
[x] Turn "run all failed tests" to 50% of stable users (provided we see good results)
[x] Turn "run all failed tests" to 100% of stable users (provided we see good results)
[x] Turn "refresh tests" to 100% of insiders and 50% of stable users
[x]  Turn "refresh tests" to 100% of stable users (provided we see good results)

To verify just clone https://github.com/luabud/sample_project, open a Python file and open the test explorer:

I verified that I see the two actions in the tests view. Please reopen if there's more to verify.
Python v2021.9.1246542782, with insiders (daily)


Fix a codeblock in the "understanding jaxpr" doc.

This fixes an issue where the codeblock didn't render properly on the website.

Oh, I thought it was automatic. Done!


fix: remove unused branch

Background
I was discussing https://github.com/panther-labs/panther-analysis/pull/835 with a coworker when we noticed there was some dead code in it.
There is no need to set a string value for user when user == None, as this value doesn't leave the scope of the function, and the subsequent condition evaluates to false either way.
Changes

Remove unneeded code

Testing
$ python3
Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> user = None
>>> if user == "foo": print(user)
...
>>>

cc @edyesed since you initially wrote this code in https://github.com/panther-labs/panther-analysis/pull/835

cc @edyesed since you initially wrote this code in #835

Hey, thanks for this PR! We'll get this merged in, and I would also like to share with you that you are likely to find other examples of this type of behavior where we provide a string value in some places where None might be functionally equivalent.
We have adopted this practice for the sake of stylistic consistency, due to the None type raising a TypeError in non-equivalence types of comparison ( i.e. substring matching / other iteration based comps ).
user@computer:~/Sources/PAN/panther-analysis-dogfood $ python3
Python 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> thing = None
>>> "what" in thing
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: argument of type 'NoneType' is not iterable

We have adopted this practice for the sake of stylistic consistency, due to the None type raising a TypeError in non-equivalence types of comparison ( i.e. substring matching / other iteration based comps ).

Thanks for the context.  If you hadn't already merged it, I'd say its fine to drop the change if this is the convention for other rules. 🙂


Add a Pipfile for easier pipenv support

Because pipenv is the bomb! Also because we need a specific version of
WikidataIntegrator, before they changed the wdi_property_store structure.
Signed-off-by: Dan Scott<EMAIL_ADDRESS>

The main motivation for this is to pin the WikidataIntegrator version; current versions of the library no longer work with this (very useful for educational purposes!) script. And taking a quick look at the updated library, it's not immediately apparent to me how one would add their own properties.
But I do love pipenv...


 It could also be introduced by the PR https://github.com/cilium/cilium/pull/24914, but the contributor reports that they cannot reproduce it locally.

Possible duplicate of https://github.com/cilium/cilium/issues/22373

@joestringer Pretty sure its a duplicate of: #25182
Both of them get stuck at the same place: node_linux_test.go:1224 which is stalled on a call to get neighbors via netlink.NeighList() - it appears stalled on unix.recvfromso I guess it's not getting the response back from netlink?

Hi, I've looked into the previous issue https://github.com/cilium/cilium/issues/22373, and it seems the test gets stuck because sometimes the desired neigh entry is stuck in the NUD_FAILED state so it tries to refetch and check the neigh entry indefinitely.
https://github.com/cilium/cilium/blob/030bb1abbdb0a3bf6de7eae2f53af6ea6939c1d9/pkg/datapath/linux/node_linux_test.go#L1222-L1235
I have no idea why the neigh entry gets stuck in the NUD_FAILED state.

I have no idea why the neigh entry gets stuck in the NUD_FAILED state.

I'm not too familiar with this code path, but it sounds like this could potentially be a real failure. From documentation the entry will enter the NUD_PROBE -> NUD_FAILED state following a failure to establish reach-ability.
@borkmann do you have any ideas here?

Is this only happening occasionally? From PROBE -> FAILED could be when ARP reply did not come back in time, for example.


Update peer dependency for react-relay.

This currently causes shrinkwrap to fail when used with the latest react-relay in the host repository.

Would you be so kind to also consider tagging a new release on npm? :)

Whoops, duplicate of https://github.com/acdlite/recompose/pull/234


Missing std::move

e.g. in implementation of Aws::S3::Model::PutObjectRequest
inline void SetContentMD5(Aws::String&& value) { m_contentMD5HasBeenSet = true; m_contentMD5 = value; }
inline PutObjectRequest& WithContentMD5(Aws::String&& value) { SetContentMD5(value); return *this;}

These rvalue references are used incorrectly. Without std::move, value will be not be moved from, and will generate an extra copy. These should be changed to
inline void SetContentMD5(Aws::String&& value) { m_contentMD5HasBeenSet = true; m_contentMD5 = std::move(value); }
inline PutObjectRequest& WithContentMD5(Aws::String&& value) { SetContentMD5(std::move(value)); return *this;}

Thanks for pointing this out. We'll get a fix out for this.

should use std::forward() -- same effect, but semantically more correct.

@crusader-mike std::forward is for forwarding values, i.e. it returns a lvalue when passed a lvalue, or an rvalue when passed an rvalue. Inside these method bodys, std::forward will always return a lvalue and cause a copy because the value category of a named variable is always lvalue.
A better ways to do this will be like this
inline void SetContentMD5(const Aws::String& value) { m_contentMD5HasBeenSet = true; m_contentMD5 = value }
inline void SetContentMD5(Aws::String&& value) { m_contentMD5HasBeenSet = true; m_contentMD5 = std::move(value); }
inline PutObjectRequest& WithContentMD5(const Aws::String& value) { SetContentMD5(value); return *this;}
inline PutObjectRequest& WithContentMD5(Aws::String&& value) { SetContentMD5(std::move(value)); return *this;}

@0x1997 what std::forward returns depends only on T (which is normally deduced depending on context as described here). In the function above T isn't deduced -- you'll have to specify it.
In any case, effect will be the same and std::move is less typing. I retract my suggestion.


Paper and lidar

Hello, your code is really interesting
Would you give me the paper that you referenced?
And the lidar in this code is 2D or 3D?
Thank you so much,
Best regards,
Nam Dinh

@NamDinhRobotics : Thanks for your interest.
This work was not based on any paper specifically.
The code supports both 2D and 3D pointclouds from LIDAR or other pointcloud data generators.

Thank you so much for your response.
Closing this issue. Feel free to open a new one if you have any other issue/question.


Add displayName to Loadable and WithChunkExtractor based components

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
Basically, I added displayNames to the generated loadable components, so that they are identifiable in react-devtools. If this change would be acceptable, i'll convert this into a PR
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 7f43596..80f589d 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -59,13 +59,17 @@ function resolveConstructor(ctor) {
 }

 var withChunkExtractor = function withChunkExtractor(Component) {
-  return function (props) {
+  function LoadableWithChunkExtractor(props) {
     return React.createElement(Context.Consumer, null, function (extractor) {
       return React.createElement(Component, Object.assign({
         __chunkExtractor: extractor
       }, props));
     });
   };
+  if (Component.displayName) {
+    LoadableWithChunkExtractor.displayName = Component.displayName + 'WithChunkExtractor';
+  }
+  return LoadableWithChunkExtractor;
 };

 var identity = function identity(v) {
@@ -395,6 +399,8 @@ function createLoadable(_ref) {
       }, props));
     }); // In future, preload could use `<link rel="preload">`

+    Loadable.displayName = 'Loadable';
+
     Loadable.preload = function (props) {
       ctor.requireAsync(props);
     };

This issue body was partially generated by patch-package.
obvi, the patch is to the esm build, so my PR would be editing the source.

❤ patch-package :)
The change is more than acceptable, feel free to open a PR


Can I also download some images with prompts from the gallery shown below the model?

I think more image examples maybe useful.

remade the download logic, have not implemented image downloads yet