bug: High Processor Usage with SVG Spinners on Android

Type: bug
Platform: android 5.0 webview
We've had batteries draining, phones overheating and unable to charge fast enough. Finally identified as SVG Spinner on loader and pull to refresh making processor usage stick around 25-30%
We were hopeful that 1.0.1 had fixed it but seems not.
Currently removing SVG from dom after $ionicLoading.hide() seems to solve it.
Can anyone suggest how to override ionRefresher directive to remove spinner?

Greetings @cannycookie!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

I suggest fixing this like I did in pull request https://github.com/driftyco/ionic/pull/4093

Great, thank you Eric :-)

On 16 Jul 2015, at 14:49, Eric Svensson<EMAIL_ADDRESS>wrote:
I suggest fixing this like I did in pull request #4093 https://github.com/driftyco/ionic/pull/4093
—
Reply to this email directly or view it on GitHub https://github.com/driftyco/ionic/issues/4045#issuecomment-121962227.

Greetings @cannycookie!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.

Not resolved.
I have tried this fix from Sionarch but the high processor usage continues.
It appears that an ion-refresher with a spinner is present when the app loads and is running in the background regardless.  My HTC-M8 android has continuous processor usage around 20% with the above fix and with this code:-
<ion-refresher
            pulling-text="Pull down to reload"
            on-refresh="vm.doRefresh()"
            spinner="dots">
         </ion-refresher>

If I change that to spinner="none" the processor usage drops down to <5% once the pages have completed loading.
I have created a workaround for ionicLoading directives by removing the element after the hide fn but that doesn't resolve the ion-refresher case.

I think you should open a new issue if you want your issue to be visible again, like ionitron said ("if you are still experiencing this issue, please feel free to reopen this issue by creating a new one")

yeah, i read that after posting :-(  This is way down the priority list, we have to launch and it's better to go without a spinner than waste more time on something trivial.  I just hope other people don't waste time trying to workout why their phones are burning up and eating batteries.


More flexibility with multitouch gesture events (Advances, Optimization, ConconJS)

Add the global position on all changedTouches object
Best way to gesture the double tap event on touchstart and getting each position.
add optimisation and speed up the code
add compatibility support for CocoonJS
add more optimization

@englercj Now in the v2.x :+1:

Nice! I'll review this weekend!

Cool man, how do you feel about doing a similar PR for v3? To the dev branch?

I'm on it ;)


Change table crossjoin algorytm

In my opinion, Table.ExpandTableColumn (which is actually used in referenced Table.ExpandTables function) is a very resources cvonsuming, specially when we try to make crossjoin.
Using of Table.Join with necessary column renaming could improve performance significantly.

Hey, thanks for this! :)
That List.Accumulate looks pretty cool. I don't think that'd been around when I made this, and it looks way better than the iteration I'd been doing.
I just tried updating that to use it too, which perhaps helps improve that a little bit as well.
On actual performance, it sounds like you've got more experience here than I do though.
On another note, I'd just been trying to figure out how to use this to self-join a table, which gave the extra complication of having to deal with column name clashes.
For that I was trying this:
(
  Tables as list,
  optional TableNames as list, // names to append as prefixes, if desired, defaults to {1, 2, 3, ...}
  optional AppendParentNames as logical    //whether to use append parent column names
) as table =>
let
  AppendParentNames = if (AppendParentNames=null) then false else AppendParentNames,
  Cols = if (TableNames=null) then TableNames else List.Transform(List.Numbers(1, List.Count(Tables)), each Number.ToText(_))
in
  ExpandTables(#table(Cols, {Tables}), null, AppendParentNames)

If your approach is more performant, might it perhaps be possible to incorporate something similar there so we could somehow get the best of both worlds? Otherwise perhaps I could include the clash-proof version separately or something.

On actual performance, it sounds like you've got more experience here than I do though.
don't think so :) this is a special case where I tested a lot of ways.

As far as I can see there is a special parameter AppendParentNames which adds a table name prefix, based on table count/number.
Actually I added this too, but only for the same column names:
NewNames = List.Transform(OldNames, each if List.Contains(CurrentNames, _) then Text.From(current+1) & "_" & _ else _)
and then rename columns in the table before join. As current is a zero-based index, my code do what you proposed as well, except it didn't adds an index to the first (leftmost) table.
Test it, I think we can make a good solution together

Okay, sounds like we're just about there then!
Attempt to add customization to yours:
(
  tables as list,
  optional TableNames as list, // names to append as prefixes on clash or if desired, default {1, 2, 3, ...}
  optional AlwaysPrefix as logical    //whether to use append table names if without column name clashes
) as table =>
    let
        CrossJoin = List.Accumulate(
            List.Positions(tables),
            #table({},{}),
            (state, current) =>
                let
                    CurrentTable = tables{current}, // need check for table type?
                    CurrentNames = Table.ColumnNames(state),
                    OldNames = Table.ColumnNames(CurrentTable),
                    Prefix = if TableNames <> null then TableNames{current} else Text.From(current+1),
                    NewNames = List.Transform(OldNames, each if List.Contains(CurrentNames, _) then Prefix & "_" & _ else _),
                    Renamed = Table.RenameColumns(CurrentTable, List.Zip({OldNames, NewNames}))
                in
                    Table.Join(state, {}, Renamed, {}, JoinKind.FullOuter)
            )
    in
        if List.IsEmpty(tables)
            then #table({},{})
            else CrossJoin

Minor bikeshed, I sorta liked . to bind the prefixes as that was what it seemed to use by default if you expand stuff, but yeah, whichever.

I'd prefer to replace this:
Prefix = if TableNames <> null then TableNames{current} else Text.From(current+1),
with that:
Prefix = if TableNames <> null then try TableNames{current} otherwise Text.From(current+1) else Text.From(current+1)
to prevent errors when TableNames list is somewhy shorter than tables list. Just to be sure.

I sorta liked . to bind the prefixes
Do as you like. I have no preferences there

Looks good, yeah. Added that in now. :)


Removed ownerref from openshift routes and add condition to delete routes based on Finalizer

JIRA: https://jira.coreos.com/browse/SRVKS-345

@savitaashture sorry this hasn't made it into the last release. Can you open the PR again against master so we can throw it into the next one?

Obsoleted by repo move. See https://github.com/openshift-knative/serverless-operator/pull/42


Content Search with Sensitive Information Types in Exchange and Teams

Hey there.
In this article, it is described that we can:

Search "for sensitive data types and custom sensitive data types in SharePoint and OneDrive for Business".
Return "documents on SharePoint and OneDrive for Business sites that contain a" given Sensitive Data Type.

But it does not specify clearly that you CAN'T search sensitive data types in Exchange Online or Teams 1:1 messages.
In fact, I remember that this text was in the documentation somewhere:
You can't use sensitive information types and the SensitiveType search property to search for sensitive data at-rest in Exchange Online mailboxes. This includes 1:1 chat messages, 1:N group chat messages, and team channel conversations in Microsoft teams because all of this content is stored in mailboxes. However, you can use data loss prevention (DLP) policies to protect sensitive email data in transit.
I don't manage to find this text again... Maybe it is not enough present in the documentation. Maybe it has been removed ? If it has been removed, is it possible today to search this in Teams and Exchange ? Then, could this be present in the documentation explicitely ?
So I think it would be nice to place this as a note in multiple places, to be sure the user will catch this important piece of information.
Thanks and have a good day !

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e83b77e5-e3ec-6a5f-1f09-e232e2dda483
Version Independent ID: 0b263c72-95a2-d111-20a7-68857f288369
Content: Keyword queries and search conditions for eDiscovery - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/keyword-queries-and-search-conditions.md
Service: o365-seccomp
GitHub Login: @robmazz
Microsoft Alias: robmazz

@msbemba Thank you very much for the contribution and sharing this explanation. @Yarkane Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Hi, I would like to add a remark there,
I just tried to use Content Search in Exchange, using Sensitive Information Types, and I don't see any change : the results are the same compared to when the warning we discussed was here.
I don't feel that there are no such limitations anymore. Are there resources about how Content Search in Exchange have evolved, in the MS community for example, explaining why the documentation has changed ? I have not found any.
Thanks a lot for your help.


Bug: 无法启动

Version
Vben Admin V5
Describe the bug?
vite-plugin-lib-inject-css这个插件存在兼容性问题导致项目无法启动

当我进行如下注释操作后可以使得项目正常运行

原因大致与该vite插件中使用的@ast-grep/napi版本有关系
Reproduction
no
System Info
no

Relevant log output
No response
Validations

[X] Read the docs
[X] Ensure the code is up to date. (Some issues have been fixed in the latest version)
[X] I have searched the existing issues and checked that my issue does not duplicate any existing issues.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

vite-plugin-lib-inject-css这个vite插件是否是必须的呢？是否有临时替代方案之类的


Allow specifying payload params for proxy handler

hapi doesn't allow specifying payload validation for proxy handler as payloads are not parsed for these.
@hueniverse suggest this should be plugin specific config in this case (like response schemas).
With my change we try to read payload params from plugin specific config when it's not found under validate config.

Hi Thanks for PR
I read through the discussion, but still not clear on what you are trying to achieve here. Would it be possible for you to create an example of the route code and explain what the Swagger interface for this route would do.
We will at some time need to create a test for this and work out why its currently breaking the prefix tests.

Hi,
Weirdly enough those tests fail for me on master, too. Either way I fixed them now. :)
The use-case for this is proxy handlers:
{
  method: 'POST',
  path: '/basket',
  config: {
    tags: ['api'],
    validate: {
      query: {
        fixture: Joi.string(),
      },
    },
    plugins: {
      'hapi-swagger': {
        validate: {
          payload: Joi.object().required(),
        },
      },
    },
  },
  handler: {
    proxy: {
      // ... proxy config here
      },
    },
  },

These can't have payload validation as hapi is not even parsing the request payload but would still be nice to show the request body as a required parameter on the swagger UI.

The latest version of hapi-swagger v2.2.0 should now give you what you need. The whole proxy area was new to me, but very interesting part of hapi.  I have updated the code a little from your PR and added a test to the plug-in.
Have a look at the examples a I was playing with https://github.com/glennjones/be-more-hapi/blob/master/bin/proxy.js the two routes at bottom of file will be of most interest.
Get back to me if you have any issues. Cheers Glenn

@csabapalfi  thanks for your clean answer. It saved my day.


Integration Account naming prefix missing

There doesn't seem to be naming convention for Integration Accounts (resource: Microsoft.Logic integrationAccounts).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6dff4c3-d2d7-3825-d753-fc7338004f43
Version Independent ID: b2c190ac-1d2e-93fc-caee-d59c278f549a
Content: Recommended naming and tagging conventions - Cloud Adoption Framework
Content Source: docs/ready/azure-best-practices/naming-and-tagging.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#227895

This issue has been resolved. Thanks!


Hau Giang Province Ministry of Education and Training

haugiang.txt
file.zip
@haugiang.edu.vn

@haiho12 I am sorry, I have to close the request without merging, because you made a mistake in a request and requested to merge too many files, most of them do not relate to the organization which you would like to add to this repository. Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


fix(compass): fix command args for server and migration

Switch to latest goto chart and v0.5.0 Compass docker image.

@mabdh is the release step expected to run for pull requests?

This commit got added by the release step - https://github.com/goto/charts/commit/a8b38ba098b390a76d74c8b3c1fcfbc4e007ea51

@mabdh is the release step expected to run for pull requests?

It should not, should only for tag


QnA site issue unexpected hyperlinks

Describe the bug
If I put in the body of post sometext.net or sometext.com it automatically gets hyperlinked
To Reproduce
Steps to reproduce the behavior:
Type in anytext.net or anytext.com and it will automatically gets hyperlinked
Expected behavior
should not be linked unless user uses Hyperlink tool from toolbar
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS] Windows 10 x64
Browser [e.g. chrome, safari] Edge
Version [e.g. 22] Microsoft Edge 44.18362.449.0

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This is pretty standard. We will not fix this. Thanks for the feedback!

So you expect "vb.net" to always be hyperlinked?

Yes, I tried that in our documentation section and the result is the same. We are consistent across the platform.


Sort out confluentcloud credentials

What happened?
We had issues with our previous account, which were resolved but the account was closed.
We should make a new one and sort out the credentials where they need to go - GH actions, 1password, ESC
Example
.
Output of pulumi about
.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I've created a new account and have added the API keys to 1password and ESC but am still unable to run pulumi up on a basic example.

Ok, the issue was with the ESC config, not the credentials.


Work around cocoapods issue with GoogleMaps 2.0.0

Fix for https://github.com/googlemaps/google-maps-ios-utils/issues/19

LGTM


POST registration and Sync_all implementation

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

BTW, suggest define Task class for each resources which maybe easy to maintain. Such as

for task rpc api, we just define like this:

def sync_storage_resource(self, storage_id, resource_task):
    pass
def remove_storage_resource(self, storage_id, resource_task):
    pass

Then, in then task manager:
def sync_storage_resource(self, context, storage_id, resource_task):
    resource_task(storage_id).sync()

def remove_storage_resource(self, context, storage_id, resource_task):
    resource_task(storage_id).remove()

for each resource, we can define like this:
class StoragePoolTask(BaseTask):
    def __init__(self, storage_id):
        self.storage_id = storage_id
    def sync(self):
        pass
    def remove(self):
        passs


fake prime code request

Is there a fake prime source code to add to this source code?

Check out NEPS

Check out NEPS

The memory.cpp in the Osiris source and the memory.cpp in this source are very different, I think, because of this, I add everything without error, when I open it in the game, the feature does not work. Can you help me?

Check out NEPS

Is neps still working? Is it really more improved than orisiris based on its post?


Add a note that this only works in Online Mode

Our Escalation Engineers asked me to submit this change because it was causing confusion for customers.  This is the note I am suggesting:
Note: This article applies only when using Outlook in online mode. Search folders do not sync, therefore search folders created in online mode will not appear in cached mode.

OPS Build status updates of commit 1bd3345:
:clock10: Preparing: average preparing time is 1 min(s) 24 sec(s)

OPS Build status updates of commit 1bd3345:
:clock10: Incremental building: average incremental building time is 39 sec(s)

OPS Build status updates of commit 1bd3345:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/how-to-work-with-search-folders-by-using-ews-in-exchange.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit d78ca20:
:clock10: Preparing: average preparing time is 1 min(s) 25 sec(s)

OPS Build status updates of commit d78ca20:
:clock10: Pending: waiting for processors (21 builds ahead of you)
:warning: OPS Build is busy, click here to report any potential performance downgrade issues, or you could view OPS Portal for trend of build queue length.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: gbratton sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

OPS Build status updates of commit d78ca20:
:clock10: Incremental building: average incremental building time is 39 sec(s)

OPS Build status updates of commit d78ca20:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/how-to-work-with-search-folders-by-using-ews-in-exchange.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@gbratton Please sign the CLA and then I'll merge this request.

@Linda-Editor, just want to check if my signing CLA worked ok or if there is anything else I need to do?

@gbratton Yes, thanks. I'll merge it now. Changes will be live in about 30 minutes or so.


MPC-BE Support

I'm currently using MPC-BE (from the KCP-black set) and I can't get livestreamer to run at all, regardless of what i do when i laod the command it just returns "Failed to render the file"

I'm quite sure that the problem is with MPC-BE, not Livestreamer.

Several of my friends has had this same problem when using players shipped with codec packs, I recommend not using codec packs.


[WIP] v2x module tests

This package contains the initial implementation of tests for vlog_to_pbtype and vlog_to_model functions. The tests are implemented with use of pytest module. This pull request also adds more test files from https://github.com/SymbiFlow/symbiflow-arch-defs/tree/master/utils/vlog/tests in such a way that the history of those files is preserved.
The tests are in WIP stage due to the lack of XML postprocessing implementation in Python (currently the canonicalizing of XML files was performed with CMake and xsltproc).

I also believe we already have the full history of the tests in the repo?

I believe we could split the XML post processing into it's own module and import it both here and into the architecture definitions repository?

sure, I created repo for that https://github.com/SymbiFlow/python-symbiflow-xml-utils
@glatosinski please push the code there


Create a new resource oidc issuer

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
It would be great to allow  customers to programmatically manage OIDC Issuers using this provider, including the associated policies.
I see this resource is already documented but I'm unsure how that would work for the associated policies.
Affected area/feature

oidc issuer

Related to and likely should be implemented at the same time as https://github.com/pulumi/pulumi-pulumiservice/issues/349

@IaroslavTitov this is #349, you may have meant another issue?

@IaroslavTitov this is #349, you may have meant another issue?

Oh I think I meant https://github.com/pulumi/pulumi-pulumiservice/issues/204


Tests for error pages

Description
Test that error situations trigger corresponding error pages.
Related issues
Closes #120
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

Intercept 403 and 500 errors
Check that error pages render

Testing

[x] Integration Tests

Cypress tests didn't pass on my local machine.  First of them  was an error in parseFormSchema in WizardAjvResolver.js. Probably we can try to rebase it on the latest develop branch ?

Cypress tests didn't pass on my local machine. First of them was an error in parseFormSchema in WizardAjvResolver.js. Probably we can try to rebase it on the latest develop branch ?
At least my tests all passed in current develop

@hannyle you might need to clear browser cache, also check AJV version that it matches the one in package.json. AJV package update had some breaking changes and on my local the browser cache had to be cleared after npm install.

Cypress tests didn't pass on my local machine. First of them was an error in parseFormSchema in WizardAjvResolver.js. Probably we can try to rebase it on the latest develop branch ?
At least my tests all passed in current develop

@hannyle you might need to clear browser cache, also check AJV version that it matches the one in package.json. AJV package update had some breaking changes and on my local the browser cache had to be cleared after npm install.

okay, I think I have the correct Ajv version. I also did try reinstall and clear cache, sadly the tests still failed. However when I locally rebased the branch all the tests passed. :-/

Cypress tests didn't pass on my local machine. First of them was an error in parseFormSchema in WizardAjvResolver.js. Probably we can try to rebase it on the latest develop branch ?
At least my tests all passed in current develop

@hannyle you might need to clear browser cache, also check AJV version that it matches the one in package.json. AJV package update had some breaking changes and on my local the browser cache had to be cleared after npm install.

okay, I think I have the correct Ajv version. I also did try reinstall and clear cache, sadly the tests still failed. However when I locally rebased the branch, all the tests passed. :-/

I think I've found a solution for this. On this branch we have AJV v8 but parseErrorSchema has incorrect propery name dataPath from earlier version. On your local dataPath doesn't correspond to anything and it should be instancePath as stated in AJV changelog.
I'll rebase and push into this branch.

@hannyle you might need to clear browser cache, also check AJV version that it matches the one in package.json. AJV package update had some breaking changes and on my local the browser cache had to be cleared after npm install.

okay, I think I have the correct Ajv version. I also did try reinstall and clear cache, sadly the tests still failed. However when I locally rebased the branch, all the tests passed. :-/

I think I've found a solution for this. On this branch we have AJV v8 but parseErrorSchema has incorrect propery name dataPath from earlier version. On your local dataPath doesn't correspond to anything and it should be instancePath as stated in AJV changelog.
I'll rebase and push into this branch.

Right, the error was at dataPath in parseErrorSchema function. The rebase did help and my tests smoothly passed. Thanks!


MM-55036 - Calls: Fix: Receiving in-app notifications for calls notifications while active

Summary

Fix for receiving in-app notifications for calls notifications while active -- we no longer see the overlay when the app is active
NOTE: we are testing on the exact message sent by the calls plugin.

This is not elegant, I agree. We could add a new NOTIFICATION_TYPE.CALLS (which would require changes across the products). That would certainly be more "correct." But on the other hand:  the current solution won't break because there's no other way for the existing products to accidentally send those exact messages. The only way would be for the product or a plugin to explicitly send them, and if they do that then they could just as easily send a NOTIFICATION_TYPE.CALLS too.

For iOS we keep the notification's buzz and alert sound. Android doesn't have this ability, so added a ticket to track: https://mattermost.atlassian.net/browse/MM-55059 (/cc @matthewbirtch)

Ticket Link

https://mattermost.atlassian.net/browse/MM-55036

Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information

Android: 13, Pixel 6
Android: 13, Galaxy Tab s7+
iOS: 16.5.1, iPhone 14

Release Note
Calls: Fixed an issue where the in-app "push" notification overlay would appear when the user already received the incoming call notification banner.

@enahum Yes, great point - we have a ticket for i18n to be completed for 1.0, so I've added ticket for typing the calls push notification: https://mattermost.atlassian.net/browse/MM-55060

Building app in separate branch.

which would require changes across the products

Could you help me understand what it would take to do this cleanly?

@streamer45 An update: I'm working on it, but I'm hitting snags. We can chat in our 1:1.

Ok, fixed. With the following PRs, calls notifications will either be sent as message (pre push proxy v5.27.0) or as calls (push proxy v5.27.0 + ).

https://github.com/mattermost/mattermost/pull/25405
https://github.com/mattermost/mattermost-push-proxy/pull/110
https://github.com/mattermost/mattermost-plugin-calls/pull/561

Please see: https://github.com/mattermost/mattermost/pull/25405#issuecomment-1810989581
Changes here are from https://github.com/mattermost/mattermost-mobile/pull/7623/commits/2203aaeec2004fce13221cd9bbbef86f131f361c
Thanks everyone.


Remember last date viewed

Might be good to remember the last date someone viewed when they visit and go there instead of the default?
Mainly an issue on mobile, because when I switch to another app and back the page reloads to the default event on me.

Hi, this is Bongo from the discord. I would like to work on this ticket


Mac20 has been failing tests frequently

This has caused tree red intermittently and raised flakes.
https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-20
Example failed builds:
Task failed: Executable "/opt/s/w/ir/x/w/recipe_cleanup/tmpGkXmML/flutter sdk/bin/flutter" failed with exit code 1
Test execution timeout
Task failed: Bad state: Did not find vmservice out file after 400 seconds
Sounds like bot/device related issue (errors seemed to happen only on this testbed)

I've quarantined the bot (will take effect after its current task).
What would be the next steps for this @keyonghan?

Is there another way to quarantine files? I did touch $HOME/.manual_quarantine_file which is from go/flutter-luci-playbook

Did you add it to swarming home?

Where is swarming home? The documentation says to put it in $HOME

Did you add it to swarming home?

Where is swarming home? The documentation says to put it in $HOME

We need to switch to swarming user, and then add the quarantine file under swarming home (/users/swarming)

We need to switch to swarming user, and then add the quarantine file under swarming home (/users/swarming)

Thanks! I've now applied it in the swarming user's $HOME

Tests are passing consistently. Closing.

For context, this is the fix for the android semantics failure: https://github.com/flutter/flutter/pull/92602


Closed shapes lead to a TypeError

When trying to validate a closed shape (i.e. with sh:closed true), the following error is thrown:
(node:6649) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'equals' of undefined
    at RDFLibGraph.rdfListToArray (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/rdflib-graph.js:74:22)
    at validateClosed (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/validators.js:35:36)
    at ValidationFunction.execute (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/validation-function.js:11:22)
    at ValidationEngine.validateNodeAgainstConstraint (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/validation-engine.js:213:42)
    at ValidationEngine.validateNodeAgainstShape (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/validation-engine.js:171:16)
    at ValidationEngine.validateAll (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/src/validation-engine.js:144:20)
    at SHACLValidator.validate (/home/nseydoux/dev/sandbox/shapes-hal/node_modules/rdf-validate-shacl/index.js:35:27)
    at main (/home/nseydoux/dev/sandbox/shapes-hal/index.js:51:36)
    at Object.<anonymous> (/home/nseydoux/dev/sandbox/shapes-hal/index.js:68:1)
    at Module._compile (internal/modules/cjs/loader.js:1147:30)

To reproduce
Run the following code snippet:
const SHACLValidator = require("rdf-validate-shacl")
const {Parser} = require("n3")

const ttlData = `
@prefix ex: <http://example.org#>.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>.

ex:Alice
a ex:Person ;
ex:ssn "987-65-432A" .

ex:Bob
a ex:Person ;
ex:ssn "123-45-6789" ;
ex:ssn "124-35-6789" .

ex:Calvin
a ex:Person ;
ex:birthDate "1971-07-07"^^xsd:date ;
ex:worksFor ex:UntypedCompany .`

const ttlShape = `
@prefix ex: <http://example.org#>.
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>.
@prefix sh: <http://www.w3.org/ns/shacl#>.
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>.

ex:PersonShape
a sh:NodeShape ;
sh:targetClass ex:Person ;    # Applies to all persons
sh:property [                 # _:b1
    sh:path ex:ssn ;           # constrains the values of ex:ssn
    sh:maxCount 1 ;
    sh:datatype xsd:string ;
] ;
sh:property [                 # _:b2
    sh:path ex:worksFor ;
    sh:class ex:Company ;
    sh:nodeKind sh:IRI ;
] ;
#sh:closed true ;
sh:ignoredProperties ( rdf:type ) .`

async function main() {
    const parser = new Parser();
    const data = parser.parse(ttlData);
    const shapes = parser.parse(ttlShape);

    const validator = new SHACLValidator(shapes)
    console.log("coucou1")
    const report = await validator.validate(data)
     console.log("coucou2")
    // Check conformance: `true` or `false`
    console.log(report.conforms)

    for (const result of report.results) {
      // See https://www.w3.org/TR/shacl/#results-validation-result for details
      // about each method
      console.log(result.message)
      console.log(result.path)
      console.log(result.focusNode)
      console.log(result.severity)
      console.log(result.sourceConstraintComponent)
      console.log(result.sourceShape)
    }
}

main()

The rdf-validate-shacl version is 0.1.1.

This error is caused by a conflict between blank node IDs. The proper way to solve this would be to use the same data factory throughout the whole process:
const { DataFactory } = require('n3');

const parser = new Parser({ factory: DataFactory }); // <- factory option
const data = parser.parse(ttlData);
const shapes = parser.parse(ttlShape);

const validator = new SHACLValidator(shapes, { factory: DataFactory }) // <- factory option
const report = await validator.validate(data)

But because of an issue in N3.js, it won't solve your problem just yet. I'm working on it ⏳

Thanks ! Does this mean that the issue would disappear altogether if the shape did not include blank nodes at all ?

It should, yes :)

Upgrading N3.js to 1.3.6 should fix your issue :)


[DTLS/WebRTC] update dep rustls to v0.20.0

Trying to use the webrtc-dtls crate and this is currently a blocker. Has any progress been made on this? I made an attempt but I really don't understand the breaking changes in rustls well enough to get it working.

rustls being stuck on 0.19 means webrtc-rs is now vulnerable to https://rustsec.org/advisories/RUSTSEC-2023-0052.
See:
❯ cargo tree -i -p<EMAIL_ADDRESS>webpki v0.21.4
├── rustls v0.19.1
│   ├── webrtc v0.8.0
│   └── webrtc-dtls v0.7.1
│       └── webrtc v0.8.0 (*)
└── webrtc-dtls v0.7.1 (*)


Terms links on create account page

What
Once show a page with links to Terms and Privacy documents before showing the page with Import Private Key and Accept Invite Code.

We should not show an extra screen but we need to show terms and conditions link on one of the first screens in the app
Since we now already have the screen I would suggest to only open it when the user clicks on a link and wants to see it
Nobody does that but it's an app store rule I believe
On the other hand, I have never had to click away T&Cs on any wallet I've ever used so I am pretty sure that that is not a legal requirement, only a nuisance to users, so let's not do that. I will accept arguments only from people who have read the T&Cs of the last piece of software they have used ;)

This is now changed to add links to terms with a small leading text.


Uffizzi is failing

Hello @waveywaves
Uffizzi is failing today on every PR: https://github.com/meilisearch/meilisearch/actions/workflows/uffizzi-preview-deploy.yml

Let me know if I can give you any information 😊

Hello @waveywaves
It looks like now it does not fail for each PR, however, Uffizzi seems to run on our commits on main, and then fails, see
https://github.com/meilisearch/meilisearch/actions/runs/4184332120

And this same commit (91ce8a5) has triggered 3 times Uffizzi deployed for different people

https://github.com/meilisearch/meilisearch/actions/runs/4184043852
https://github.com/meilisearch/meilisearch/actions/runs/4184332120
https://github.com/meilisearch/meilisearch/actions/runs/4185248753

This leads us to receive a lot of useless notifications on our side. Can we prevent the Uffizzi CIs to run on main?


typo: lable -> label

@nschonni : Thanks for your contribution! The author, @jasonwhowell, has been notified to review your proposed change.

@ktoliver I just tested the HDInsight Hive query language and Python code to make sure the misspelled column name wasn't dependent on something in the sample data. Looks good.
Thanks, Jason


Add engine timeout seconds setting

https://github.com/sunfish-shogi/electron-shogi/issues/248

Codecov Report
Base: 72.43% // Head: 72.44% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (64f6a87) compared to base (9e97ac3).
Patch coverage: 72.00% of modified lines in pull request are covered.

:exclamation: Current head 64f6a87 differs from pull request most recent head 484c227. Consider uploading reports for the commit 484c227 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   72.43%   72.44%   +0.01%
==========================================
  Files          60       60
  Lines        3461     3470       +9
  Branches      199      199
==========================================
+ Hits         2507     2514       +7
- Misses        795      797       +2
  Partials      159      159

Impacted Files
Coverage Δ

src/ipc/api.ts
24.00% <0.00%> (ø)

src/settings/app.ts
53.12% <0.00%> (-3.55%)
:arrow_down:

src/store/analysis.ts
7.35% <0.00%> (ø)

src/store/index.ts
59.02% <83.33%> (+0.31%)
:arrow_up:

src/players/builder.ts
90.00% <85.71%> (+1.11%)
:arrow_up:

src/players/usi.ts
66.26% <100.00%> (+0.41%)
:arrow_up:

src/store/csa.ts
71.53% <100.00%> (+0.20%)
:arrow_up:

src/store/game.ts
64.70% <100.00%> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Redefine Method

For the same reasons as StatusCode: #122

Blocked on Rust 1.20, as we want to use associated constants instead of enum variants.

@seanmonstar  is this what you were talking about when you said associated constants? https://github.com/carllerche/http/blob/master/src/method.rs#L114

@steverob no, associated constants are a feature that is stabilizing in Rust 1.20. It allows this:
impl Method {
    pub const GET: Method = Method(Inner::Get);
}

which differs from the current way of having constants as part of the module. The difference for users is:
// constants in http::method module
fn check_method(method: &Method) {
    match *method {
        http::method::GET => (),
        // etc
    }
}

// methods as constants associated with the `Method` type
fn check_method(method: &Method) {
    match *method {
        Method::GET => (),
        // etc
    }
}

There is now the http crate, and 0.9 will depend on it directly, so this isn't needed.


Profile Image - responsive bugs

Medium image isn't circular:

Small image isn't centered:

.profile .profile-sidebar img {
border-radius: 200px;
}
Change to 999px would work?

This issue has been resolved in observatory-client - closing this ticket.


Missing dataset

Hello,
In the notebook, 0_prepare_your_data_from_Seurat.ipynb, the example seurat object, with the file name being endometrium_example_counts_seurat.rds, is not available anywhere on the CellphoneDB repository. How do I retrieve this as I want to practice with the dataset?
Many thanks,
Nas Basma

Same request here. It would be nice having the example dataset.
Thanks for your work,
Juanlu.


FZF keybindings for git question

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[x] Etc.

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

I just have a question and I don't know a better place where I can ask it, so putting it here. I have a snippet that I guess belongs to you:
# Browse git commits
fzf-show() {
    is_in_git_repo || return
    git log --color=always \
        --format="%Cred%h%Creset %Cgreen(%cr)%Creset %C(bold blue)<%an>%Creset %s" "$@" |
    fzf-down --height 100% --ansi --no-sort --reverse --tiebreak=index --bind=ctrl-s:toggle-sort \
        --bind "ctrl-m:execute:
    (grep -o '[a-f0-9]\{7\}' | head -1 |
    xargs -I % sh -c 'git show --color=always % | diff-so-fancy | less --tabs=4 -RX') << 'FZF-EOF'
    {}
    FZF-EOF"
}
bindkey -s '^g^l' 'fzf-show\n'

Can you please explain how the execute part works here and why do we need head -1 (I can see that FZF-EOF gets through to less and we want to strip it, but I don't understand why).

A line may contain multiple matches, so we use head -1.
echo foo hello foo | grep -o foo

@junegunn thanks!


Pause Screen formatting and a way to access the options

When the player pauses in a level, they should be able change these settings on the go

also need to make it look more clean.

@shoc71 I have an idea on how we could incorporate the pause screen dynamically in levels. It's not the most efficient method, but we can just render and blit the screen and associated options directly on top of the level while the game is paused.
It's similar to the editor where adding text or selecting levels doesn't change scene but puts the game loop in an alternative state (text mode or select levels mode).
Anyways, the general gist is to just overlay options on top of the level. Additionally since we have pause checks for the controls, the player can't control the square with A/D/SPACE, so it's ok to use those keys again for the settings (no conflict).


[proposal] make the CLI available without cloning the repo

hey 👋
This repo and the job you did is amazing! I wanted to contribute with this PR with something I'd value when it comes to some of my personal projects. I'm not sure this is something you want to upstream as well, so I marked it as a "proposal".
With all these changes, I actually just moved the bin/train/main.py script inside the package to make it available to users installing the nam PyPi package without having to clone the whole repo.
Since there's no "bin" inside the bin folder anymore, I moved the bin/train one at the root level.
Finally, I aligned the README with these changes (+ I removed some old, I guess, paragraphs)
I hope it can be of any help 💪

Additional note, I’m honestly unsure whether running the CLI script outside of conda changes anything

I like this idea. However, your PR does unfortunately introduce a lot of issues that need to get addressed before I can merge it.
I'll need to find some time to review this.

Oh, I’m sorry I haven’t noticed them! If you give me some pointers I can try to address the issues 💪
One thing I just noticed is that pytorch-cuda is missing if you don’t run the CLI inside the conda environment. I can think about a solution, if needed.

I rewrote the PR from scratch as I thought it'd have been simpler - and indeed I came up with way fewer and leaner changes IMHO 🚀
Sorry for the first round of review, it must have been tough as the PR was a bit messy and changed a lot of things I didn't quite check you agreed with before 🙏
What mainly changes from the "previous version of the PR" is:

I kept files at their place
I didn't remove any documentation, just added a tiny paragraph about pip and the new nam-cli command

I kept files at their place

I guess this is what you were referring to when you mentioned the broken test - indeed nam-cli was working perfectly fine, but if you meant the python bin/train/main.py ... command, then yes, it broke because I intentionally replaced it with nam-cli, but indeed I should have checked it with you first! 🙏
Thanks!! 😊

Great!! LMK if you want me to help somehow 🚀 Thank you!

@Eraz1997 on second thought, if you can grab those changes before Thursday you'll probably get to it before me :)

@sdatkinson unfortunately I don't have band this week, LMK if it can be of any help next week as well!

Got the nits and did a bit of cleanup on the documentation in Eraz1997/main.
Closing this PR and we'll merge there 👍🏻

Perfect!! 🚀


🪲[Bug]: Adding Fav icon

Will add a favicon icon

Hello @Anishkagupta04 ....My name is Priyanka Ray Choudhury, Can you please assign this task to me?


[Test] Unable to use events as a return type

Current Behavior
I am not able to use an event signature as a return type in the cadence testing framework:

Expected Behavior
It would be great to allow these kinds of return signatures so I can cut down on copy/paste code. Usually I need the same type of event over and over when writing tests and was hoping I could write a helper to achieve this more easily
Steps To Reproduce
import Test
import "Foo"

// some tests here
...

// this method is invalid
pub fun getLatestEvent(): Foo.SomeEvent {
    return Test.eventsOfType(Type<Foo.SomeEvent>()).removeLast() as! Foo.SomeEvent
}

Environment
- Cadence version: v1.9.2
- Network: Testing

Unfortunately this comes from Cadence itself. Events are currently not "first-class" citizens, in that they cannot be used as argument types / return types or be constructed and assigned to variables. However, we can use their type for type-casting, as you have done here:
let events = Test.eventsOfType(Type<Foo.SomeEvent>()).removeLast() as! Foo.SomeEvent

IsExportable
IsExportable

The above methods contain the business logic for which CompositeTypes can be used as argument types & return types.


clean up security lathe recipes

About the PR
title and also standardized some things:

laser carbine takes 5 seconds instead of 8 like every other laser, its the worst one why should it take longer to make?
empty mags/speedloaders take 1 second instead of 5 since you have to manually load it

requires #31515
Why / Balance
above
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
no cl no fun

Looks good


Natsu Dragneel

Issue #4
Added a new anime character - Natsu Dragneel

@iamartyaa can you please merge this with label of hacktoberfest-accepted tag.?


Use nested CSS

Chrome 112 and Safari 16.5 are both out with CSS nesting. I’m opening this issue to keep track of it.
No release in sight for Firefox

https://caniuse.com/css-nesting
https://bugzilla.mozilla.org/show_bug.cgi?id=1648037

Maybe in July: https://twitter.com/bramus/status/1666010954776076289?s=20 🎈

It's already supported everywhere 😱

Chrome: Always latest
Safari: The next version on Refined GitHub will require the latest Safari version already.
Firefox ESR will be on 115 until July 9th, 2024. We're not going to wait that long, also because we will definitely release a breaking Firefox version as soon as they ship the :has() selector (#5797 and caniuse), we have a million TODOs regarding that.

https://whattrainisitnow.com/calendar/

First nested-CSS feature shipped!

https://github.com/refined-github/refined-github/pull/6941

The feature already used :has() so it wasn't available in Firefox anyway.

Moved to #6000

Still blocked by Safari.

https://github.com/refined-github/refined-github/pull/7252#pullrequestreview-2191276378

Done


AzCopy OAuth login fails

After running azcopy login and signing in with my Azure account, I see the following response on the sign in page:
“User account <redacted> from identity provider <redacted> does not exist in tenant ‘Microsoft’ and cannot access the application <redacted> in that tenant. This account needs to be added as an external user in the tenant first. Sign out and sign back in again with a different Azure Active Directory user account.”
Am I missing something like an App Registration?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1141c265-4aea-c6be-4d61-3566fe8474b8
Version Independent ID: 3cb0f2ba-cf8b-7fdd-414b-b8d95dca004c
Content: Copy or move data to Azure Storage with AzCopy on Windows
Content Source: articles/storage/common/storage-use-azcopy.md
Service: storage
GitHub Login: @seguler
Microsoft Alias: seguler

@kyleloyka thanks for posting here, I'd recommend posting this issue in either StackOverflow or here https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=windowsazuredata if it's a storage related issues.
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Redirect and Link are not working with mobx-react observer

I have a route which redirects after checking a condition like this
<Route exact path="/" render={()=>(
Store.isFirstTime ? <Redirect to="/intro" /> : <Home state={Store}/>)}/>

The url changes when the condition is true but the component is not mounted. The rest of the component code is as below.
render() {
    return (

        ...
        <Route exact path="/" render={()=>(
          Store.isFirstTime ? <Redirect to="intro" /> : <Home state={Store} />
        )} />
        <Route path="/intro" render={()=>(<IntroWizard state={Store.userInfo}/>)} />
        <Route path="/home" render={()=>(<Home state={Store}/>)} />
        <Route render={()=>(
404 Not Found
)} />

    );
  }

My App Component is contained with in the BrowserRouter like thi
ReactDOM.render(<BrowserRouter>
    <App/>
</BrowserRouter>,
  document.getElementById('root')
);

My App component is a observer from mobx-react and it is exported as shown below
let App = observer(class App { ... })
export default App

To verify the issue I created another project and tried to reproduce the issue, I have committed that code to this repository  mobxtest
What should be done to use redirects and links with mobx observers?

It seems your problem is that react-mobx implements shouldComponentUpdate (sCU), thus blocking any re-renders after the URL changed. There's a (WIP?) guide about this here.
Since the sCU implementation of react-mobx compares the props, you can fix it by passing location as a prop using withRouter or a pathless Route:
const App = withRouter(observer(class App extends Component { ... } ));
// or
ReactDOM.render(
  <BrowserRouter>
    <Route component={App} />
  </BrowserRouter>,
  document.getElementById('root')
);

I've been banging my head against this for most of the day! I hope that guide makes it into the docs soon - it is essential for anyone using Redux or MobX. It solved my problem. Thank you.

I've had the same problem:
  <Provider store={store}>
    <ConnectedRouter history={history}>
      <Layout>
        <Switch>
          <Route path="/login" component={Login} />
          <PrivateRoute exact path="/" component={Home} />
        </Switch>
        {DevTools.enabled && <DevTools />}
      </Layout>
    </ConnectedRouter>
  </Provider>

PrivateRoute / was redirecting to Route /login, the URL has changed however the Login component did not render.
I needed to decorate Layout with withRouter in order to get it working:
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(Layout));

Thanks, @taurose !
P.S.: This should be more properly documented.


[RAINCATCH-603] Mitigate QS Vulnerability

Mitigate QS vulnerability (6.4.0)  https://issues.jboss.org/browse/RAINCATCH-603
Verified manually that the vulnerability is mitigated using snyk test
3rd Party Module Fix Status

Express  -  4.15.2

Update Express is not used by this module, removing the dependency instead.

Cool, removed the dependency.


Cover Elasticsearch

AWS' own Elasticsearch service is growing in popularity. Discuss basics, when to manage yourself vs with AWS' managed service, etc.

@nitingithub want to take this one?

This would probably need some comment on how AWS is lacking behind quite a bit regarding the available ES versions and the implications to get a system running securely in a VPC

@zoellner yeah, what I've heard too. That's exactly the sort of tip we should put in!

PR welcome, or if you'd like to put that tip here (any links/details to add?) we can incorporate it.

In addition to version lagging (which right now is not actually too bad, they bumped up to 2.3 I believe in July), they have scripts disabled. And there are some relatively straightforward uses that require scripts in elasticsearch, e.g. sorting an aggregation by query score is one I just ran into.

I can help here. I think Elasticsearch Service is one of the most powerful yet unknown service...as long as I ramp up my GitHub game lol ;-)

dorrin [8:22 AM]
I'd like to hear stories from people who switched from managed ElasticSearch to building and maintaining their own cluster
bgdnlp [8:56 AM]
for what is worth, I think the "pets vs cattle" thing is a broad generalisation that ignores too many issues. in fact, I also think that it is dangerous from a security perspective.
rjhintz [10:01 AM]
@dorrin Regarding: Elasticsearch. This was a recent topic on Reddit/aws. It seemed to draw some informed opinion (as opposed to "normal" Reddit.) https://www.reddit.com/r/aws/comments/55dpn6/elasticsearch_on_aws_managed_or_roll_your_own/

Price can also be a factor. ElasticSearch service's instances are more expensive than regular EC2 instances.

Piping in from the field here. AWS ES does not allow use of the /_cluster/state/metadata endpoint. This causes problems with supporting tools, like Elasticsearch Curator.
See https://github.com/elastic/curator/issues/717

Troubleshooting the ES service is also a problem. You can't see the instances behind the ES cluster so if you can't fix an issue by adding more memory or storage then you should contact support.

AWS has a list of ES service limits as well : http://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/aes-limits.html Mainly no scripting, plugins, heap size limit, max instance count.

Another major security gotcha to list:
http://www.zdnet.com/article/first-came-mass-mongodb-ransacking-now-copycat-ransoms-hit-elasticsearch/


Update change-the-phone-numbers-on-your-audio-conferencing-bridge.md

Removed "Want to know how to manage PowerShell Section" as that is unnecessary on this page.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Add historyWireOffer to jsonrpc spec

I am trying to write a Hive test for https://github.com/ethereum/trin/issues/1484, and I am sending offer values of 64 items. The current issue I am facing is all Portal clients don't implement a JSON-RPC command that can send more than 1 piece of content per offer.
Trin already does, though, and we call it portal_historyWireOffer. I believe Nick made it for internal testing, but I think it would be useful for all clients to implement it for hive.
I am not adding this command to State or Beacon due to the way it works. If we want it to work for the State Network, we should include the content value in the parameters. I think Nick didn't do this because the message would could be very big, which might be a bad idea? I'm unsure if that is an issue, though, if the limit is only 64 items.
Recap
It is currently not possible to test whether Portal clients follow the spec in being able to send 64 pieces of content in one offer. I am open to discussing making this an RPC call in the debug namespace.

The goal is to have a JSON-RPC command that can create an offer with multiple content keys https://github.com/ethereum/portal-network-specs/blame/35085002701e4ffad7fb95085c1211157bd32a49/portal-wire-protocol.md#L214-L223

Seems reasonable to me, though I'd opt for a name more like portal_historyOfferMultiple or something that is more indicative of what the message does.  I don't see any reason to move it to debug since all of our RPC endpoints are basically debug endpoints anyway.

I think that this is how portal_historyOffer itself ought to work, rather than a separate endpoint

I general I have no issue with adding a call like this to Fluffy, but it's definition is currently not clear to me.
Regarding debug prefix, I am mostly in favor:
If the call is only supposed to do the offer/accept (without utp part) then I think this should get a debug_portal prefix (we probably should revise if more should then go in the debug prefix, but that's another issue).
If the call is supposed to do offer/accept/utp, then I'm not 100% sure, but it still feels like a debug call because of the fact that you already need to have stored the content locally.

Maybe we should just do scotty's suggestion and make it so portal_*offer can be used to send multiple pieces of content. I think this makes the most sense as currently portal_*offer returns a bitlist as you said so I think it would make sense for it to be able to take multiple pieces of content

Maybe we should just do scotty's suggestion and make it so portal_*offer can be used to send multiple pieces of content.

Yeah, I'm fine with that too (in fact I've needed it in the past also for local tests). But there is a difference that in that call the content gets passed within the json-rpc method parameters, and this new call expects it to be there already.

Maybe we should just do scotty's suggestion and make it so portal_*offer can be used to send multiple pieces of content.

Yeah, I'm fine with that too (in fact I've needed it in the past also for local tests). But there is a difference that in that call the content gets passed within the json-rpc method parameters, and this new call expects it to be there already.

I am fine with content gets passed within the json-rpc method parameters. I open this PR mostly to start a discussion for how we should move forward. We already had this call in Trin so I used it as a starting place. I think Scotty's idea just makes sense. So I am happy to go with it

I think Scotty's idea just makes sense. So I am happy to go with it

Sure, I'm fine with adjusting that existing call. It can also stay under the regular portal_ prefix then.

I think Scotty's idea just makes sense. So I am happy to go with it

Sure, I'm fine with adjusting that existing call. It can also stay under the regular portal_ prefix then.

Sounds like a win. I will update the PR when I wake up

+1 for modifying portal_*Offer.

Currently, portal_*Offer accepts a single content key/value pair, which is beneficial because you don't have to store the data locally to send an offer (very helpful for testing & bridge stuff)
I think we want to retain both the ability to send an offer jsonrpc request with & without the accompanying value. So I'm not sure it's as simple as updating portal_*Offer to take multiple content keys.
I'm not sure I'd be in favor of updating portal_*Offer to accept multiple content keys with optional values (that's messy).
IIUC, this thread is leaning towards updating portal_*Offer to accept multiple content keys? Imo, we still want to retain some kind of ability to offer a single content key/value over jsonrpc. So, I'd be in favor of adding a new endpoint for multiple content keys.
Tbh, i don't have strong feelings about which kind ends up as portal_*Offer or portal_*OfferMultiple or portal_*OfferSingle ... but I do think we want two different jsonrpc endpoints...

supports multiple content keys
supports a single content key/value pair

I'd also suggest adding portal_*TraceOffer to the specs (already implemented in trin) which does wait for utp tx and returns the result (for both of the cases listed above)

I think the difference here is between sending multiple content keys and multiple content key/value pairs

we want to support sending multiple keys (in the case where the content is stored locally)
we want to support sending multiple key/value pairs (where the content doesn't need to be stored locally)
It seems messy to me to have a single endpoint that'll support both of these use cases.

I think the difference here is between sending multiple content keys and multiple content key/value pairs

we want to support offering multiple keys (in the case where the content is stored locally)

^ This doesn't work for the state network. It doesn't make sense for the beacon network. Personally I don't see a need for it

we want to support offering multiple key/value pairs (where the content doesn't need to be stored locally)

It seems messy to me to have a single endpoint that'll support both of these use cases.

^ We won't be supporting both usecases, we will only be supporting we want to support offering multiple key/value pairs (where the content doesn't need to be stored locally

This doesn't work for the state network. It doesn't make sense for the beacon network. Personally I don't see a need for it

fair enough, it's not useful in beacon/state
is it useful in history?

we use it in our tests (though, after a quick skim it seems that these could be updated to use the new endpoint)
are there user stories where this is useful...

ummm i can't think of any right now, but i haven't thought about it too much
it's maybe not a great ux to have an endpoint where the user is expected to maintain knowledge of what content is stored locally

Ok I guess I can't think of any good reason to keep that functionality around just for the history network. Maybe simply the reason that this represents the actual wire protocol message, but there's no reason we need to expose jsonrpc endpoints for the raw protocol messages.
:+1:

@acolytec3 @kdeme @njgheorghita @ScottyPoi ready for another look. I updated the PR to follow Scotty's suggestion

@kdeme @njgheorghita @ScottyPoi ready for another look if nobody sees an issue we can merge it


Permit to install with win32-service 2.2.0 on Windows

We recommend to use win32-service v2.2.0 or later due to fluent-ctl
singal functionalities.
But, currently, Fluentd still stay to use win32-service v2.1.5:
gem.add_runtime_dependency("win32-service", ["~> 2.1.5"])

This dependency blocks to use the latest version of win32-service on td-agent-builder on
Windows.
Signed-off-by: Hiroshi Hatake<EMAIL_ADDRESS>
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
see: https://github.com/fluent-plugins-nursery/td-agent-builder/pull/288/checks?check_run_id=2387368140#step:3:62002
Docs Changes:
No needed
Release Note:
Same as title.

I guess that this should be needed for td-agent v4.1.4 due to correct Windows signal handlings.

win32-service v2.2.0 doesn't include the feature we want.
v2.3.0 (or later) is the one we want, but it's not released yet.

https://github.com/chef/win32-service/commit/bde5569a9512f2f7ae07a754ea29f4c7b7b1abd0
https://rubygems.org/gems/win32-service

win32-service v2.2.0 doesn't include the feature we want.
v2.3.0 (or later) is the one we want, but it's not released yet.
* [chef/win32-service@bde5569](https://github.com/chef/win32-service/commit/bde5569a9512f2f7ae07a754ea29f4c7b7b1abd0)

* https://rubygems.org/gems/win32-service

Oops! I'll rewrite commit message and PR descriptions....

I updated PR description and commit message.
Without this change, td-agent-builder still bundles win32-service v2.1.6 not v2.2.0.

Changes between 2.1.5 to 2.2.0:
win32-service-2.2.0 (2020-11-20)
Merged Pull Requests

Refactor ::status with new methods #64 (jasonwbarnett)

win32-service-2.1.6 (2020-08-17)
Merged Pull Requests

Optimize requires for non-omnibus installs #72 (tas50)

I'll merge after Cis are finished.


Improves unused-vars usage, removes inline exceptions

Adds a better linting rule for unused-vars to avoid false-positives. This enforce a TypeScript convention with ESLint.

Codecov Report

Merging #6697 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #6697   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          671       671
=========================================
  Hits           671       671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded2aeb...d3d5170. Read the comment docs.


investigate -- mac first auth fails sometimes during install

Possibly related, a windows surface was noticed to sometimes fail DHCP

question, is it possible that device route is not established correctly and it gets cached to sprloop until the 2nd dhcp?


Oct 2022 "integration test"

Branch with all outstanding client fixes merged in. I guess it's... a release candidate?
git checkout main
git checkout -b oct-2022-integration-test

git merge pingfix-playerlist             # PR 28
git merge upstream/ghost-fixes           # PR 29

# include suggestions brought up in PR 29
nano CelesteNet.Client/Components/CelesteNetMainComponent.cs
nano CelesteNet.Client/Components/CelesteNetMainComponent.cs
git commit -a -m "PR #29 suggested fixes"

git merge misc-rendering-fixes           # PR 30
git merge grab-release-fix               # PR 31
git merge ui-keyboard-entry-chat-bugfix  # PR 35
git merge emote-timeskip-fixes           # PR 39
git merge chat-component-client-null     # PR 41
git merge hair-length-fix                # PR 43

Edit: As of 2022-10-08 jade has merged all of these except for #29 upstream. 👍

Almost all in main branch now, except #29 + https://github.com/RedFlames/CelesteNet/commit/3eda670950b2945ea39ee8663e7a75f2683a0ded


Entries with contradictory entries

Probably something wrong when re-inserting the default values?
      kernel task_id     rid   setup      cost      gamma    degree      auc
   1: radial       3 2127568  250842 0.7321917 0.15358042 0.3333333 0.994463
   2: radial       3 2127569  250843 0.5073054 0.39436659 0.3333333 0.999205
   3: radial       3 2127570  250844 0.7116752 0.23582906 0.3333333 0.998405
   4: radial       3 2127576  250850 0.9388593 0.39222426 0.3333333 0.999863
   5: radial       3 2127577  250851 0.5985232 0.31658448 0.3333333 0.999218

Look at degree.  It is always 1/3 and originates from degree = 3 which is the default. Maybe we can fix this when we fill the NAs.

+---------+---------+--------+--------+---------+------------+--------+----------+----------+----------+---------+---------+
| task_id | rid     | setup  | kernel | cost    | gamma      | degree | auc      | accuracy | rmse     | scimark | runtime |
+---------+---------+--------+--------+---------+------------+--------+----------+----------+----------+---------+---------+
|       3 | 2127568 | 250842 | radial | 24.9996 | 0.00821006 |      3 | 0.994463 | 0.963079 | 0.160892 | 1752.16 |  17.644 |
|       3 | 2127569 | 250843 | radial | 1.10658 |   0.231219 |      3 | 0.999205 | 0.988423 | 0.091725 | 1841.55 |  25.713 |
|       3 | 2127570 | 250844 | radial |  18.811 |  0.0256763 |      3 | 0.998405 | 0.987797 | 0.098757 | 1873.41 |  13.517 |
|       3 | 2127576 | 250850 | radial | 438.729 |   0.224453 |      3 | 0.999863 | 0.994994 | 0.058762 | 1840.51 |  20.135 |
|       3 | 2127577 | 250851 | radial | 3.91894 |  0.0786554 |      3 | 0.999218 | 0.991239 | 0.088817 | 1869.63 |  16.132 |
+---------+---------+--------+--------+---------+------------+--------+----------+----------+----------+---------+---------+

for me the degree is correctly 3, as it's the default. Can you clarify what the problem is and how you get the table in your post.

I just discovered that his is indeed an issue when looking for the nearest neighbors.
The safest way is to set degree to NA in the preparation script if the kernel is not "polynomial".

The safest way is to set degree to NA in the preparation script if the kernel is not "polynomial".

This is now done. We should test if this yields valid values, if the user sets degree anyway (this is a reminder for me)


There is no registration flow on https://forum.taikozuerich.ch/

Hi Marco
Looks like I havn't managed to find registration for the new user on https://forum.taikozuerich.ch/

The forum is working invitation based.
When you register on https://taikobot.taikozuerich.ch you will receive a confirmation email to access the forum.
Please inform me, or reopen the  issue if the procedure described in this slack message is not working.
The reason is that I plan to put both applications under a common login, but this needs a bit more work.

Just saw that you don't are on our Slack channel.
So if you have troubles registering, please write me here or contact Micah, so that we can resolve it. Thank you ;-)


Refactor: Update loader crate (bindle get) to use AnyAuth

The loader crate currently uses a No Auth/in-house 'BindleTokenManager' approach when getting bindles.  This should be updated to use AnyAuth per https://github.com/fermyon/spin/pull/407#discussion_r860385119.
Follow-up from https://github.com/fermyon/spin/pull/407

Fixed via #456.


Using native CalyxOS gms core?

I have CalyxOS and it seems to have gms core by default why do I have to install this?

Because GMS core by default rejects the signature of modified apps


Update bower.json

flexselect.css was added into the "main" of the bower.json . It will allow the webpack (powered by BowerWebpackPlugin) to apply styles of flexselect automatically

Thanks! :beers:


Implement support for custom menus inside the new home page

As requested by the customer, they want to take advantage of the option, currently available in GeoNode, to configure custom menus through the Django admin.
We can adopt the same approach as in GeoNode, where a set of placeholders are available to inject menus and menu items dynamically.

This can be clsoed since static settings for menus is already in place. The enxt step is the integration with the Menu system (django admin)


bug(mat-menu): Nested menus incorrectly placed when custom element above trigger

Is this a regression?

[x] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13.3.9
Description
When using a mat-menu, which contains an element with an other size than 48px, following nested menus open on wrong positions:

If the nested menu is too small it looks completly unrelated to the trigger.
This happens from v14 ongoing to v17.
It worked correctly in v13.3.9:

Reproduction
StackBlitz link: https://stackblitz.com/edit/1j8wme?file=src%2Fapp%2Fmenu-nested-example.html
Steps to reproduce:
Simply put a

 before the trigger of a nested menu
Expected Behavior
It should open the nested menu at the correct position like in v13.
Actual Behavior
The nested menu opens in a wrong place.
Environment

Angular: v14.0.0 to latest
CDK/Material: v14.0.0 to latest
Browser(s): Chrome v119
Operating System: WIndows 11 Pro

Seems like only mat-menu-items where counted to the offset. For now I'm using a workaround by adding invisible mat-menu-items with the same height

Hi, this seems to be entering into a gray area of what's supported by the mat-menu because it looks like you're feeding unexpected content into the mat-menu. If you want to do some heavy customization, I'd recommend using the cdk-menu. If it's just something small, I'd recommend either wrapping it in a <button mat-menu-item or adding the mat-menu-item directive to the div directly
CDK Menu:
https://material.angular.io/cdk/menu/overview
Example:
https://stackblitz.com/edit/1j8wme-d4pawu?file=src%2Fapp%2Fmenu-nested-example.html


Window out of screen when resolution changes

I played with larger and smaller screen resolutions, now I have ModTools' SceneExplorer rect out of screen and can't drag it back.
The solution was to delete the config. But would be nice to at least have it snapping back to 0,0 if it goes into the negative.

Wrong repository. Closing.


Error: In dependency

I have no idea about this error output.
Error: In dependency "derive_more"

Caused by:
    Only one of `registry`, `registry-index`, `path`, `git` can be specified: Detailed(DependencyDetail { version: Some("
0.99"), registry: None, registry_index: None, path: None, git: None, branch: None, tag: None, rev: None, features: ["disp
lay", "from", "into"], optional: false, default_features: Some(false), package: None })

Just a simple test with resource : https://github.com/Stupremee/spear

Seems generated nix still have evaluating issue. Reopen now.


Updated validations.py python script

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

updated validations.py python script please review my changes and merge them. Thank you

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

Already done


Doc++

Pull Request Test Coverage Report for Build 495

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.713%

Totals

Change from base Build 488:
0.0%

Covered Lines:
5219

Relevant Lines:
5234

💛  - Coveralls


[Windows] Player Stuttering

App Version: 0.0.45
Windows: 10
The App itself is smooth and I didn't have any issue, but when I tried to play a video and the video starts to get stutter at every frame.
Steps:

Search any Anime title in any Source
Play a episode (in my case, Kage no Jitsuryokusha ni Naritakute! Season 2 Episode 1)
see the Bug (Video starts to play and then it gets stutter at every frame).

Fixed, you can check in the latest release


Use "omnisharp.json" from solution path as config file automatically

First commit just adds available formatting options (yay to 29fdb7df890337777a5cce62bcf7bf49a60a3ca5 commit).
Second commit allows user to add omnisharp.json file to solution directory that will be loaded automatically instead of default config.json in executable directory. Should be harmless for all people that will not use this feature and pretty useful for those who has different configurations across different solutions. Not critical, but anyway.

Looks good to me. Thanks! I was planning on doing this at some point.

You are welcome :)
Was much simpler to implement then I thought.


[Breadcrumb] Update Breadcrumb API, design and interaction tests

Some properties have not been fully defined as the spacing between text and chevron elements or the high contrast colors

Updates the breadcrumb styles to match the design, including code to fix the ellipsis button rendering
Description
Updates the Breadcrumb_themeresources.xaml file and the Breadcrumb.xaml visual states to match the proposed design. This also includes the definition of a custom Button style to override the appearance of the border and background brushes for pointer over and pressed states, as well as an internal function to calculate the size of all elements to be rendered in the Breadcrumb to better render the ellipsis item.
From #4110: Adds AddRoutedEventHandler calls as an alternative for OnPreviewKeyDown for RS2 and previous versions of windows.
From #4038: This PR includes the first interaction tests for the Breadcrumb control, the tests currently verify the following scenarios:

Test
Result

Default control rendering
No interaction is performed on the control, verifies control initial state

Adding elements to the ItemsSource
Verifies the number of breadcrumb items increase

Invoking one of the breadcrumb items
Verifies the list of breadcrumb items change once an item has been invoked

Adding elements to the ItemsSource and limiting the rendering space
Verifies that the ellipsis items repeater gets populated

Invoking one of the ellipsis items
Verifies the breadcrumb ItemsSource gets updated

Motivation and Context
Fixes #3981
Fixes #3997
Fixes #3979
Screenshots (if appropriate):
Light Theme

Dark Theme

High Contrast

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run


add jenkins to keycloaks accepted client redirect URLs so we can log into Jenkins on Kubernetes

[merge]


Improve Readme.md

Improve Readme.md overall message conveying paragraphs and fix grammar mistake.

Please do not make PR unless the issue is assigned to you.


trim whitespace from title

Closes #6. My XML had tons of tabs and 1 newline in it for every post title, for whatever reason, so this would be useful.

Thanks!


Changing misleading text for reset button in Automate Import/Export

Purpose or Intent
When you navigate to Automate, Import/Export you can click on "Reset all Datastore custom classes and instances to default" - although it says so, it only resets the ManageIQ and Red Hat domain and doesn't touch any custom domains. So I created a new method domain_names for getting domain names for reset and I also changed the text to "Reset all components in the following domains: XXX, YYY".
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1363774

@miq-bot add_label automate


File not found random occurences for ricebowl.txt

It's very rare but sometimes there's a file not found error for ricebowl.txt

Added a permanent fix: d2c7b44f7e4c5ba17edea6408be772ab88158ae5

Added a permanent fix: d2c7b44f7e4c5ba17edea6408be772ab88158ae5


Request: footystats.org

Please, add https://footystats.org/predictions/ 2 the project

it requires account to see every predict, can do without account if u want (i think)

uchenna2k2:61003

Hi! If I throw in new resources that don't require authorization, can you add them?
If you can, what are the formatting and naming requirements for the resources?


First download

Hello,  I from UGATU Racing Team, we previously contacted by e-mail. We  want to have access to the whole data set. So, we marked up the data that you sent.
We made a pull request, please check.
Your dataset photo link: https://photos.google.com/share/AF1QipPTGhRfC3VA1APoHO-WeVrySv695v3y_ej-IxoYu4niNENS7V9bJS3pW4fTaLGkhQ?key=cEk0Vk5CSUlWNHZIWDZGbVhJbUIzOXF0ckJ1MlNn
Our link: https://drive.google.com/drive/folders/1HaVa_4q0NoT9O_3fyyKcNNxXhyeS732b?usp=sharing

Ok, we'd love to participate in a new dataset) But could we access the
first one?
пт, 21 авг. 2020 г. в 15:12, Niclas<EMAIL_ADDRESS>
Hi,
please read the deprecation notice on the repo's readme page
Deprecation Notice 06.08.'20
This project will not be actively maintained anymore.
The second iteration of the FSOCO dataset is already in beta testing.
This second iteration does not contain the data from the first one from
the start, but migration of your datasets is possible, if you fulfill the
new requirements - for most only small changes will be needed to achieve
this. You can read into the reasoning behind this break between the first
and second iteration.
If you're interested in either joining the waiting list for the beta
testing or being notified when the official start happens, drop us a line:
<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddavid/fsoco/pull/74#issuecomment-678177645, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOTQBXF2VR4GXQULY6PH32LSBZCBDANCNFSM4QG7D57Q
.


Extension issue

Issue Type: Bug
Extension Name: vscode-devskim
Extension Version: 0.2.2
OS Version: Windows_NT x64 10.0.17763
VSCode version: 1.31.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

Dupe of #67.


Document some code snippets to make use of the grid

Overview
When I look at the Grid overview page, I understand the concepts, but I don't know how to put it into practice. How do I implement a grid in my UI?
Feature: Grid
  As a developer
  I want to know how to implement grids
  So that I can make use of them

Hi Andrew! I am going to add some guidelines around this on our website by the end of this week. I'll keep you updated here, thanks!

Hello, any updates on this?

Hi @azinod , a grid example is currently in a PR https://github.com/carbon-design-system/carbon-components/pull/45. I just need to add a few more examples before merging but feel free to take a look at the code there in the mean time. Thanks!


Initial test enablement for LLM Compressor

Still needs to be significantly tested, but starting point to play around with for LLM Compressor. This enables the session mixin for control of the training graph, loading of a teacher, and passing through everything within the axolotl training config.
Example config addition on top of the base config here https://github.com/axolotl-ai-cloud/axolotl/tree/main/examples/llama-3/fft-8b.yaml:
....

compressor:
  recipe:
    finetuning_stage:
      run_type: train
      pruning_modifiers:
        ConstantPruningModifier:
          targets: '__ALL__'
          start: 0
  recipe_args: {}
  teacher:
    base_model: NousResearch/Meta-Llama-3.1-8B
    load_in_8bit: false
    load_in_4bit: false
    strict: false
    flash_attention: true

after setting up the config file, use the following command:
axolotl train CONFIG.yaml

Accidentally opened against the main rather than our downstream fork. Will push up a proper PR once tested and ready!


bump librarymanagement

Thanks @jtjeferreira but it seems we have too many forks of sbt-coursier. I'll see if I can create an official 2.x branch in https://github.com/coursier/sbt-coursier

Moved to https://github.com/coursier/sbt-coursier/pull/521


go/types, types2: scope is unset on receivers of instantiated methods

While prototyping #51682, I observed that while substituting in method receivers we do not set the parent scope.
This is unintended, and should probably be fixed for 1.18.1.
CC @griesemer

@gopherbot please consider this for backport to 1.18, it is an oversight.


List releases in GitHub repo

Feature Suggestion
Currently, releases are published to npm: https://www.npmjs.com/package/@roadiehq/backstage-plugin-jira . It would be nice to have them listed at https://github.com/RoadieHQ/backstage-plugin-jira/releases too, with a changelog if possible.
Possible Implementation
Not sure how this is done with GitHub actions.
Context
To view the changes between the releases, and also to use GitHub to notify me of any releases for this repo.

@rodtan Sorry for delay for the response. This is now enabled for the plugins inside this repo. You can find the releases here :)


Integrate MiMa

https://github.com/lightbend/migration-manager
FGE JSON Schema and Jackson databind as well as few other ancient dependencies are most common source of runtime failures in our code base. MiMa should make upgrades a lot easier.

Duplicate of #118 which is merged


REGR: fix eq to compare for identical geometries (not ignoring z dimension)

Closes #1732
This might be a bit overkill for just implementing __eq__, but this should also allow to actually expose "equals_identical" as a ufunc for all GEOS versions (and not only for GEOS>=3.12). And it is also faster than the easier python alternative (but not sure how significant this will be in real-world cases):
geom = shapely.LineString(np.random.randn(1000, 2))

In [19]: %timeit geom == geom
10.8 µs ± 198 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

In [20]: %timeit np.allclose(shapely.get_coordinates(geom), shapely.get_coordinates(geom), rtol=0, equal_nan=True)
76.5 µs ± 599 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

Additional complication: I forgot that GEOSCoordSeq_copyToBuffer_r is only available for more recent GEOS versions (>= 3.10), so if we want to go this way, we need a fallback for older versions (we actually do already have a similar fallback implemented for the equivalent GEOSCoordSeq_copyFromBuffer_r).
The other reason that some tests are failing is because this PR actually changes behaviour regarding NaNs. On main, we don't regard such geometries as equal:
In [2]: import shapely

In [3]: line_string_nan = shapely.LineString([(np.nan, np.nan), (np.nan, np.nan)])

In [4]: line_string_nan
Out[4]: <LINESTRING (NaN NaN, NaN NaN)>

In [5]: line_string_nan == line_string_nan
Out[5]: False

while with this PR, I made NaNs in the same location as equal (following what was done for GEOSEqualsIdentical upstream in  https://github.com/libgeos/geos/pull/810).
With shapely 1.x, this also resulted in False, because we implemented __eq__ as tuple(self.coords) == tuple(other.coords), which ends up comparing the scalar coordinate values, and then nan != nan.

@jorisvandenbossche Thanks for fixing this issue!

@brendan-ward thanks a lot for the detailed review.
Higher level question: does that mean you would be OK with the behaviour change to consider NaNs in the same location in the coordinate sequence as equal? Because that's a deviation from what __eq__ does now, so something we should decide consciously.

@brendan-ward thanks a lot for the detailed review. Higher level question: does that mean you would be OK with the behaviour change to consider NaNs in the same location in the coordinate sequence as equal? Because that's a deviation from what __eq__ does now, so something we should decide consciously.

For me the proposed behavior makes much more sense, that NaNs would be considered equal.
Say for instance we can compare safely 3D points that happen to have Z=NaN assert Point(1,2,NaN) == Point(1,2,NaN)

does that mean you would be OK with the behaviour change to consider NaNs in the same location in the coordinate sequence as equal?

Good to call me on it; I intentionally sidestepped answering that question.  😄
(was only suggesting comments to better indicate this direction)
I personally haven't relied on this behavior and thus would not be impacted either way (so take my perspective with a grain of salt), and find NaNs to be challenging in coordinate sequences throughout the codebase (I always go back to the comment in pygeos #306 of NaNs make everything bad, don't let them in).  I think what you have done here is reasonable in that they are functionally equivalent if they occur at exactly the same position even though NaNs are not themselves comparable.
So long as this is clearly noted in the changelog, that hopefully avoids surprises for users, and I really hope very few if any are relying on specific comparisons where NaNs suddenly switch from incomparable (equals is false) to equivalent if functionally equal.

Yes, fully agreed on that ideally you never have NaNs in coordinate sequences to start with, and we can improve APIs to prevent users from getting that.
However, if (for whatever reason) you have NaNs, one should be able to test if two geometries are identical (including their NaNs) in some way. The question then of course is whether __eq__ needs to be this way. If we add an equals_identical() function, people can also use that.
I also don't have real-world experience to base an opinion on, but I have the feeling it makes sense to let __eq__ be this "identical" check, since you have equals() for spatial equality and equals_exact() if you want to be able to specify some tolerance.
Whatever we choose, it's always somewhat ambiguous what __eq__ exactly does, because of it being an operator and not a function (also right now, users don't necessarily know whether it calls equals() or equals_exact())

if (for whatever reason) you have NaNs, one should be able to test if two geometries are identical (including their NaNs) in some way. The question then of course is whether __eq__ needs to be this way.

(Hope I understood correctly) I strongly agree that __eq__ needs to return True on two geometries that are equal and have NaNs in the same locations, like Point(1,2,NaN) == Point(1,2,NaN)

OK, updated this PR for the review comments. This is now "generally" passing, i.e. for most GEOS versions except for some corner cases where GEOS 3.8 seems to behave differently (for empty geometries, have to further diagnose this). The tests for GEOS main are failing, but those are failing on main as well (and related to https://github.com/libgeos/geos/issues/832).
I also opened a dedicated issue for the API question regarding how NaNs are treated for visibility: https://github.com/shapely/shapely/issues/1775

Thanks for the updates here @jorisvandenbossche .  Can you please add a CHANGELOG entry?
The only part I'm still struggling with is the equality tests with Z nan values that are dependent on the GEOS version, where it returns False for GEOS <= 3.9 and GEOS >= 3.12, but True for GEOS 3.10-3.11.  The tests document this behavior, which if I'm following correctly, is existing behavior independent of this PR.  But since this doesn't have an obvious docstring where we could note this behavior, I wonder if maybe adding an Equality section to docs/geometry.rst might be the place to add such a note?  (and also a place to clarify the 3 different types of equality tests: __eq__, equals (predicate), equals_exact).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 87.955%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2563

Relevant Lines:
2914

💛  - Coveralls

This is ready for another review.

@mwtoews I added some minimal tests for (in)equality with M coordinates

@mwtoews thanks for the review!


Having a host without FQDN added to a Kubernetes environment makes cloudprovider fail to lookup hosts with FQDN added after

Rancher versions:
rancher/server:v1.6.10 and v2.0.0-alpha10
rancher/agent:v1.2.6 and v2.0.0-alpha4
Infrastructure Stack versions:
kubernetes (if applicable): v1.7.7-rancher1
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:

Create Kubernetes environment
Add a host with hostname and hostname -f returning hostname only, i.e. host1
Add a host with hostname -f returning FQDN, i.e. host2.local

Results:
kubelet container on host2.local will log:
E1012 12:52:08.805135   12170 kubelet_node_status.go:357] Error updating node status, will retry: error getting node "host2.local": nodes "host2.local" not found

Solution:
This statement in the else (which is only triggered when a hostname is found) overwrites hostname while it should be using rancherHostname. It should also not use fqdnParts[0] but rancherFQDNParts[0].
Code:
https://github.com/rancher/kubernetes/blob/v1.7.7-rancher/pkg/cloudprovider/providers/rancher/rancher.go#L818
I copied the cloudprovider code to Golang playground to test, see the // Bugged and // Fix
https://play.golang.org/p/XGaPbjvXBk

We are also facing this issue with Rancher 1.16.12, Kubernetes 1.8.3 with plane isolation, Docker 17.03.2-ce, and a Cloud provider that is different from AWS/Azure/GCP etc...
Here all information about what we are facing: https://github.com/rancher/rancher/issues/10616

did anyone find a solution to this?


Filter and pagination do not work well together

Open admin interface with > 20 events
Select to display 10 events per page
Go to page 3
Search for existing event

Opencast should show one page with one event.
Opencast shows no events, claims to be on page 1, but actually still seems to use the offset from page 3.
Changing the filter, we should always just jump to page 1.

See #211
And specially: https://github.com/opencast/opencast-admin-interface/issues/211#issuecomment-1788798999


Add basic incoming webhook documentation

You can see the page at http://mattermost-developer-documentation.s3-website-us-east-1.amazonaws.com/branches/incoming-webhooks/integrate/incoming-webhooks/
I removed the draft setting meaning this page will get built but there's no way to find it without knowing the URL. That way we can still see it on the site but no one will be able to find the integrate section until it's fully ready to go

I'm gonna review it in detail later. Should we redirect the docs.mattermost.com to the one at devs site?

It might be good to have a link but we're still going to need documentation
on webhooks directed at admins since this is focused on developers
On Mar 4, 2018 17:52, "Jason Blais"<EMAIL_ADDRESS>wrote:

I'm gonna review it in detail later. Should we redirect the
docs.mattermost.com to the one at devs site?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mattermost/mattermost-developer-documentation/pull/89#issuecomment-370272001,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACjF4krLCiNCiqA7bG-R6wPuCyX5oN0cks5tbHArgaJpZM4Sbbok
.

Let's chat about it more during our 1-1 but the vision I have is that we have the admin integration guide on docs.mattermost.com that has a lot of the configuration and testing information for each integration type. Essentially it should have all the information an admin needs for using, setting up and maintaining an existing integration. It should then link to the developer docs for anyone looking to build an integration, and that's where all the development related integration information is

@lieut-data updates made

Overall well done. No major feedback other than +1 :)

More of a general question for dev site, but do we want to offer an easy way for community to share their integrations? E.g. having a text like https://docs.mattermost.com/developer/webhooks-incoming.html#share-your-integration
Would troubleshooting steps be helpful for devs? https://docs.mattermost.com/developer/webhooks-incoming.html#troubleshooting
Do we need to make the __Treat this endpoint as a secret.__ Anyone who has it will be able to post messages to your Mattermost instance. text more visible? I missed when I first scanned it.
In the parameters table, are rows ordered roughly by how likely it is for someone to use the parameter?

I guess 1) might be covered by http://mattermost-developer-documentation.s3-website-us-east-1.amazonaws.com/branches/integrate/integrate/getting-started/

Yeah it's at least partially covered by my other PR but maybe we can more links to it throughout, maybe as part of a page footer or something?
To an extent yes, though I think the cases covered in your link wouldn't need mentioning if we just provided better error messages in the first place (and we don't need the windows curl one since we shouldn't be teaching devs how to use curl, way beyond our scope)
Yeah, maybe. Not sure how to do that in a nice way though, maybe a good question for Mike or Asaad
Roughly, yeah. 'text', 'channel', 'username' and 'icon_url' are definitely the most likely to be used


[Bug]: Theme feature broken in exported data

What happened?
I exported a note that uses the embed styling feature of the Everforest Enchanted Theme, specifically the "clean" and "no-title" options. The embed is not rendered on the exported site.
Reproduction

Use the Everforest Enchanted theme
Create the two note described below.
Export the site and view the "Parent Page"

Parent

![Child#Header|clean no-title]

Child

## Header

Content content content

Last Working Version
No response
Version
1.8.01
Operating System
Windows
Obsidian Version
1.6.3
Which browsers can you reproduce this in?
No response
Relevant log output
N/A

Additional Info
No response

Can you show what it's supposed to look like vs what it actually looks like? Also the styles in the latest obsidian version are broken, so I would recommend downgrading obsidian and exporting.

Sorry for the delayed response, and for the typo in my reproduction steps. The Parent file should have been:
Parent

![[Child#Header|clean no-title]]

After embed

(two "[" characters for a proper embed, and I added some content after to help show the issue).
Here it is in reading view:

Here it is after HTML export:

That screenshot is from a Webserver Export, but it happens in the other modes too.
Here is the HTML from the export (everything in the Reading Pane)

Parent

                        <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="svg-icon right-triangle">
                          <path d="M3 8L12 17L21 8"></path>
                        </svg>

                      Header

Content content content

              <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="svg-icon lucide-link">
                <path d="M10 13a5 5 0 0 0 7.54.54l3-3a5 5 0 0 0-7.07-7.07l-1.72 1.71"></path>
                <path d="M14 11a5 5 0 0 0-7.54-.54l-3 3a5 5 0 0 0 7.07 7.07l1.71-1.71"></path>
              </svg>

After embed

Looks to me like the
 is being caught by this bit of CSS from the theme:
.markdown-embed[alt~="no-title"] .markdown-preview-section > :is(.mod-header, .mod-header + div:has(.frontmatter)) + div:has(h1, h2, h3, h4, h5, h6) {
  display: none;
}

Maybe you don't want to try and support every random theme feature (which would be fair), or maybe this is an actual exporter bug.

I'll look into it and if it's something that is being caused by a bug I'll fix it, but if it's something I would have to support explicitly I probably won't fix it. However themes should always work so it's likely a bug


Removing package lock files

Hi @v-regandowner! We leave the package lock files as part of the project to ensure all apps run with a certain combination of package versions, regardless of the user or environment. If you hit any specific issues due to the package lock files, please open an issue or reach out. Thanks!


Create RC script creates email with wrong commit

I just used the create-release-candidate.sh script to generate the email for 1.1.0 RC1.  The script generated an email with wrong commit.  It used the 1st commit on the RC branch, when it should have used the second commit.

Actually I think I created the RC branch incorrectly

In case anyone looks at this in the future, the RC branch should be the first commit made by release:prepare. The second commit is the bump to the next snapshot version, which will be the version in the resulting maintenance branch (if there is one) after the release.


Add tnt_space panels

Customer suggest adding tnt_space_index_bsize, tnt_space_len, tnt_space_bsize, tnt_space_total_bsize panels. This information may be useful for troubleshooting so it won't be needed to poke into each instance manually with tarantoolctl or metrics handle.

InfluxDB version is blocked by tarantool/metrics#321