Implementation of sqlx::Decode is not general enough

The error is generated when i'm using a struct with sqlx::Type and some field is an Option. i tried to decode manually my struct but the error is still there.
Sample sql, structs and query
`sql
create table demo_seller
(
id int not null constraint demo_seller_pk primary key
username varchar(30) not null,
first_name varchar(30) not null,
last_name varchar(30) not null,
photo varchar(150)
);
create table demo_shop
(
shop_id int not null
constraint demo_shop_pk
primary key,
created_at timestamptz default now() not null,
price numeric(15,3) not null,
seller_id int not null
);
`
`rust
#[derive(Serialize, Deserialize, FromRow, sqlx::Type)]
pub struct Seller {
id: i32,
username: String,
first_name: String,
last_name: String,
photo: Option< String >,
}
#[derive(Serialize, Deserialize, FromRow)]
pub struct Shop{
shop_id: i32,
price: Decimal,
seller: Seller
}
let shops: Vec = sqlx::query_as!(Shop, r#"
SELECT
s.shop_id,
s.price,
(sl.id, sl.username, sl.first_name, sl.last_name, sl.photo) as "seller!:Seller"
FROM demo_shop s inner join demo_seller sl on s.seller_id = sl.id
"#).fetch_all(&*pool).await?;
`
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Implementation of sqlx::Decode is not general enough
0  |
/ pub trait Decode<'r, DB: Database>: Sized {
61  | |     /// Decode a new value of this type using a raw value from the database.
62  | |     fn decode(value: <DB as HasValueRef<'r>>::ValueRef) -> Result<Self, BoxDynError>;
63  | | }
| |_- trait sqlx::Decode defined here
|
= note: std::option::Option<std::string::String> must implement sqlx::Decode<'0, Postgres>, for any lifetime '0...
= note: ...but std::option::Option<std::string::String> actually implements sqlx::Decode<'1, Postgres>, for some specific lifetime '1

struct with options fields cant use #[derive(sqlx::Type)]
Implementation of sqlx::Decode is not general enough

This might be fixed on master and/or a newer version of Rust (which one are you using?) as I can't reproduce it, though there's another problem relating to the sqlx::Type on master, I'll create a PR for that shortly..

This might be fixed on master and/or a newer version of Rust (which one are you using?) as I can't reproduce it, though there's another problem relating to the sqlx::Type on master, I'll create a PR for that shortly..

rustc 1.49.0 (e1884a8e3 2020-12-29)

Can you try whether this still happens with a git dependency? If not, it's fixed with 0.5 (though the crates.io version currently only works with some runtimes: #1033).

I have the same issue with Option on 0.5.1

For some really weird reason, this happens with a String field and an Option<String> field, but not with an i32 field and an Option<String> field. Minimal repro:
#[derive(sqlx::Type)]
pub struct Seller {
    username: String,
    photo: Option<String>,
}

Cleaned up the macro output to reduce this to
use std::error::Error;

use sqlx::{decode::Decode, postgres::PgValueRef, types::Type, Postgres};

pub struct Seller {
    //username: String,
    photo: Option<String>,
}

impl<'r> Decode<'r, Postgres> for Seller
where
    String: Decode<'r, Postgres>,
    String: Type<Postgres>,
    Option<String>: Decode<'r, Postgres>,
    Option<String>: Type<Postgres>,
{
    fn decode(value: PgValueRef<'r>) -> Result<Self, Box<dyn Error + 'static + Send + Sync>> {
        let mut decoder = sqlx::postgres::types::PgRecordDecoder::new(value)?;
        //let username = decoder.try_decode::<String>()?;
        let photo = decoder.try_decode::<Option<String>>()?;
        Ok(Seller {
            // username
            photo,
        })
    }
}

Removing the String: Decode<'r, Postgres> bound fixed the issue.

It also doesn't make sense to me that SQLx would emit these bounds though. Generally, these should be emitted for generic parameters, not for all field types. That theoretically limits use cases but also works around this issue and is what other derives do (to avoid making internal field types part of possibly public API) and should not be an issue in practice.

should I as a workaround write my own Decode impl based on what you have here above (removing the String: Decode stuff) or is there some easier workaround ?

@Kruptein You would have to write your own Decode, Encode and Type implementations. You can use cargo-expand to obtain the output of the macro invocation on your type and customize that. For now yes, that's the only workaround. I'll probably also create a PR working aroudn this in the coming days (and also create an issue on rustc).

Ok cool, I'll see if I can figure it out and otherwise I'll have to be patient :)

cargo-expand is really a great help indeed, the first two structs I implemented manually indeed work after removing the String: Decode<'r, Postgres> line.
I do also have a struct with an Option that has a similar issue, where removing the Decode for the i32 fixes it.

In general you shouldn't need any of these bounds on concrete types. That's only going to be necessary for generic parameters (when deriving / implementing Decode for a generic type).

Yeah I just wanted to let you know because you couldn't reproduce it with i32's (https://github.com/launchbadge/sqlx/issues/1031#issuecomment-773997308)

Okay, actually I don't think I'm gonna write the PR for this. My suggested fix is making these two loops: [encode, decode] work over the type's generic type parameter rather than the field types. That's at least theoretically a breaking change, but only for generic structs that derive sqlx::Type, of which there are probably very few, if any, out there. A similar change should probably be done for the other cases where split_for_impl is used, simply because currently the derives leak the types of potentially private fields into the public API (this is why derive(Clone) for a generic type bounds on Clone for all generic type params which results in overly strict bounds sometimes, e.g. when a T is only used as Arc<T>).

Finally was able to reduce this further and posted a rust issue: https://github.com/rust-lang/rust/issues/82219

Hi,
With decimal feature included, I get this
the trait `sqlx::Decode<'_, sqlx::Any>` is not implemented for `rust_decimal::Decimal`

Is there a workaround?

In my case I need a generic trait to use with sea-query, and I get this error:
error[E0277]: the trait bound `u64: sqlx::Decode<'_, sqlx::Any>` is not satisfied
  --> src\models\oauth2.rs:9:16
   |
9  | impl Model for OAuth2Client {
   |                ^^^^^^^^^^^^ the trait `sqlx::Decode<'_, sqlx::Any>` is not implemented for `u64`
   |
   = help: the trait `sqlx::Decode<'_, sqlx::MySql>` is implemented for `u64`
note: required for `OAuth2Client` to implement `for<'r> FromRow<'r, AnyRow>`
  --> src\models\oauth2.rs:13:48
   |
13 | #[derive(Clone, Debug, Serialize, Deserialize, FromRow)]
   |                                                ^^^^^^^ unsatisfied trait bound introduced in this `derive` macro
14 | pub struct OAuth2Client {
   |            ^^^^^^^^^^^^
note: required by a bound in `Model`
  --> C:\Projects\Services\src\core\model.rs:11:5
   |
10 | pub trait Model:
   |           ----- required by a bound in this trait
11 |     for<'r> FromRow<'r, AnyRow> + Send + Sync + Unpin + Serialize + DeserializeOwned
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Model`
   = note: this error originates in the derive macro `FromRow` (in Nightly builds, run with -Z macro-backtrace for more info)

pub trait Model:
    for<'r> FromRow<'r, AnyRow> + Send + Sync + Unpin + Serialize + DeserializeOwned
{
    const TABLE: &'static str;

    fn table_ref() -> TableRef {
        TableRef::Table(StaticIden(Self::TABLE).into_iden())
    }
}

impl Model for OAuth2Client {
    const TABLE: &'static str = "oauth_client";
}

#[derive(Clone, Debug, Serialize, Deserialize, FromRow)]
pub struct OAuth2Client {
    pub id: u64,
    pub name: String,
    #[serde(rename = "type")]
    #[sqlx(rename = "type")]
    pub kind: OAuth2ClientType,
    pub organization_id: u32,
    pub trusted: bool,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub package_id: Option<u32>,
    pub website_url: String,
    pub photo_url: String,
    pub background_url: Option<String>,
    #[serde(skip)]
    pub secret: String,
    pub custom_schema: Option<String>,
    pub redirects: Option<Value>,
    pub scopes: Option<String>,
    pub created: NaiveDateTime,
    pub updated: Option<NaiveDateTime>,
}

#[repr(u8)]
#[derive(Debug, Copy, Clone, PartialEq, Eq, Serialize, Deserialize, Type)]
#[serde(rename_all = "snake_case")]
pub enum OAuth2ClientType {
    Web = 0,
    Native = 1,
}

Hi @frantisek-heca, finally we don't use sqlx anyway. Have a look at Teo. This web framework has builtin ORM support. Write CRUD and aggregates are very fast with it. The framework handles the encoding and decoding for you.

When I used the stable version, I ran into this problem with the Option type, but it worked fine once I workaround it.
However when testing with the nightly version of CI, I found this error on all #[derive(sqlx::Type)].

When I used the stable version, I ran into this problem with the Option type, but it worked fine once I workaround it.
However when testing with the nightly version of CI, I found this error on all #[derive(sqlx::Type)].

What was your workaround for it?

When I used the stable version, I ran into this problem with the Option type, but it worked fine once I workaround it.
However when testing with the nightly version of CI, I found this error on all #[derive(sqlx::Type)].

What was your workaround for it?

@henningcullin
Just macro expansion and delete the where clause.

@uonr I got my query_as! implementation working with nested structs that use the derived Type macro. It said the error was on an Option enum which was the same error as the op had. But when I used the query! macro to view the resulting record it became clear that issue was not the Type macro and the Option enum. The issue was that I didn't use Option on everything that could be nullable in the query.

Closed by #2940


"unable to get local issuer certificate"

I'm encountering some URLs where I get the following error:
https://www.mysuezwater.com/ (error sending request for url (https://www.mysuezwater.com/): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1915: (unable to get local issuer certificate))
A quick check seems to show a valid cert when visiting that site in Chrome. Is this caused by the root certs that are available on the ubuntu-latest image?

It appears to be a GoDaddy parent cert causing the problem?

Yeah that seems to be the case. Don't think we can do much here at this point so I'm closing the issue. 😞 Please correct me if I'm mistaken, though.


ETH and ERC20 dont reflect to user account

Hello,
ETH deposit and ERC20 deposit dont reflect to users balance. I try to use following code but it gies error.

code=eth bundle exec rake coin:sync_deposit

rake aborted!
CoinRPC::JSONRPCError: {"code"=>-32601, "message"=>"The method listtransactions_ does not exist/is not available"}
/home/deploy/peatio/current/app/services/coin_rpc.rb:34:in `handle'
/home/deploy/peatio/current/app/services/coin_rpc.rb:23:in `method_missing'
/home/deploy/peatio/current/lib/tasks/coin.rake:15:in `block (2 levels) in <top (required)>'
/home/deploy/.rbenv/versions/2.2.2/bin/bundle:23:in `load'
/home/deploy/.rbenv/versions/2.2.2/bin/bundle:23:in `<main>'
Tasks: TOP => coin:sync_deposit
(See full trace by running task with --trace)

@greo2017 which version did you use ?
We don't have this task now


JDK1.8 Support

The 0.8.9 build in maven central does not work with my project which has a dependency on roaring.
I found this because 0.8.9 appears to have been compiled with jdk > 1.8 (which my project uses).  In 1.9 they changed Buffer slightly. for more details: https://stackoverflow.com/questions/48693695/java-nio-buffer-not-loading-clear-method-on-runtime
I see this error at runtime:
java.lang.NoSuchMethodError: java.nio.ShortBuffer.rewind()Ljava/nio/ShortBuffer;
  at org.roaringbitmap.buffer.MappeableArrayContainer.increaseCapacity(MappeableArrayContainer.java:714)
  at org.roaringbitmap.buffer.MappeableArrayContainer.increaseCapacity(MappeableArrayContainer.java:694)
  at org.roaringbitmap.buffer.MappeableArrayContainer.add(MappeableArrayContainer.java:171)
  at org.roaringbitmap.buffer.MutableRoaringBitmap.add(MutableRoaringBitmap.java:774)

Scanning open/closed issues I see why it was recently changed.
So options as I see it:

Perhaps this could be fixed by compiling roaring on newer JDKs, but targeting 1.8 bytecode?
Declare roaring JDK1.9+. If so we should update the prerequisites in README.md with JDK1.9 starting with 0.8.9 (or cut over to 0.9?)
cross-build or maintain separate 0.8 and 0.9 branches/releases.  Probably not worth the effort (not to mention amplifying maven central issues)

Thanks for reporting this issue. I definitively consider this as a bug.

Perhaps this could be fixed by compiling roaring on newer JDKs, but targeting 1.8 bytecode?

Why do you expect that this is a bytecode issue? It looks to me more like an issue with the standard library.
Regarding bytecode, our gradle build is configured in this manner...
        sourceCompatibility = JavaVersion.VERSION_1_8
        targetCompatibility = JavaVersion.VERSION_1_8

Ahh I see, you are correct. As a sanity check I confirmed that the 0.8.9 artifact in maven was indeed targeted to 1.8.
javap -v ./org/roaringbitmap/buffer/BitmapBatchIterator.class | grep "version:"
  minor version: 0
  major version: 52

I agree this is an issue with the standard library.
Doing some digging this is the path that I see-

Cast to Buffer in all appropriate places
It looks like they added --release for this very issue. http://openjdk.java.net/jeps/247   so --release 8 would need to be specified in addition to sourceCompatibility and targetCompatibility in gradle.  This will cause a compiler error for all places where the cast is needed (making it detectable at compile time instead of at runtime)

I would be happy to look into this further and submit a PR if you think this is the correct path to go down.

@subprotocol
Please do.

I have marked this as a bug. It is bad.
This should never happen in the future.

This was previously addressed in the maven build in #288.

@richardstartin You are correct Richard... which is why I am surprised it is an issue... I thought we solved this...

Looking at #288, the pom.xml does specify <javac.release>8</javac.release>, so this makes sense that it works there and not here.
It appears the only challenge then is to find a way to get gradle to accept a --release argument.  I am finding this exceedingly difficult to do!
https://github.com/gradle/gradle/issues/2510
Specifying it on the compilerArgs is easy, but I then run into the same issue linked above:
> error: option -source cannot be used together with --release
It is mentioned that source and target compatibility need to be set to null for this to work.  However, I've been unable to find a way to do this as source/target compatibility are JavaVersion enums.

@subprotocol

Looking at #288, the pom.xml does specify <javac.release>8</javac.release>, so this makes sense that it works there and not here.

It makes sense that we lose the checks, but it does not follow that we would lose backward compatibility. There has been few changes since we moved to gradle.

Adding the release flag is easy...
https://github.com/RoaringBitmap/RoaringBitmap/pull/354
Why won't it pick up any issue?
@subprotocol  Can you explain why our code is not valid Java 8? I wrote this code... It is many years old... written back in Java 8 time...

I can confirm your change in #354 resolves my build issue in my 1.8 project (yay!)

Can you explain why our code is not valid Java 8? I wrote this code... It is many years old... written back in Java 8 time...

The code is valid.  The issue is only with the bytecode.  For example, this changed between JDKs-
JDK1.8-
Buffer position(int)
After JDK1.8 the sub-classes of Buffer now have methods overriden with different return types. so now ShortBuffer has this on it-
ShortBuffer position(int)
The bytecode from a newer JDK (even with source=8 and target=8, but not release=8) will generate 1.8 byecode that reference the newer method signature that does not exist in 1.8.
So a 1.8JVM will see ShortBuffer position(int) and not know what that is.
Here is a diff showing this using the old build, and #354:

Ok. Issuing a release. Thanks for reporting the issue.
Meanwhile, I found out that we can build our project with Java 8! (This hasn't been possible in quite some time.)

Thank you!


Adding stream support to Dynalite

@mhart - I need stream support for some tests I'm writing. Is this something you are interested in adding to dynalite? I see its mentioned in the TODOs.
Todos for this PR:

only allow streams for tables with stream configs
send old and new items per the stream config
support batch sizes
valid event schema (right now it's just the subsections I need)

/cc @rclark @scothis

@mcwhittemore thanks for the PR! I gather you haven't seen #67 😸

Oh man. Sorry. I looked for a PR a few weeks ago. Nice to see this is moving.

No worries – now that the holidays are over I should have some time to look at how best to achieve this – so perhaps things can be pulled together from both your work and that of @kiril-pirozenko-home24

@kiril-pirozenko-home24's is much closer to be done it looks like. Though, mine was designed around hooking up triggers and I'm not 100% sure how to do that with what's in #67 right now. I'll close this and make some comments over there.


required option being ignored

I am trying to create a file input field that is required, but simple_form simply ignores/removes the option specified in the code. However, it works well for other types of fields.
So, for example this code:
f.input :video_file, as: :file, input_html: { required: true }
Produces the following:
<input class="file optional" type="file" name="video[video_file]" id="video_video_file">
Is there any actual reason for this specificity towards file or is this a bug?

Can you please provide a sample application that reproduces the error?

Dumb question... Why name="video[video_file]" has square brackets? Sometimes it only takes to reformulate a naming syntax for things to work correctly... My 2 cents, hope it helps.

@nashby While I was putting a simple example together to show you, it worked well.
For clarification, I re-tested the two main ways I tried to get it working before I posted the issue, and now it worked (with the other one I had tried but didn't work either):
<%= f.input :file, as: :file, required: true %>
So I guess I might have had some other thing interfering with it. In any case, thank you for your availability.

@gdgp cool, feel free to post your findings here when you fix it!


Modifying Picture Dates in the Photo Library

Main question:  Is it possible use OSXPhotos to modify dates of existing pictures in the main photos library, especially in batches?
Here's my situation - I am now trying to curate my roughly 14,000 photos library, ensuring people are correctly tagged, chronological order, etc.  I have a several thousand photos that I've scanned/imported into the library (all our old picture albums), and have done a good bit of work on tagging people, even if Photos hasn't recognized a face (yet).  I made the mistake, though, of not editing EXIF dates in the photos prior to importing them into the library.
Photoanalysisd has basically run its course over the last few weeks, and I'm still left with thousands of photos that would need to be manually tagged, even though faces are detected.  My gut is telling me that because I've tagged all sorts of different people (from baby pictures through mature adult phase), photoanalysisd is seriously confused because of the differences between someone's infant pictures vs. current day.
The Photos app itself only allows for changing the date of a photo one at a time, rather than in bulk.  This would turn into hundreds of hours of work going through each individual photo to change those dates.
I've read through the OSXPhotos documentation, and I see (and have verified) that it can make changes to the database by creating a new album and then tagging photos into those albums.  My thought has been trying to exporting batches of photos at a time from Photos, getting the photo name and/or UUID, and coming up with a file of name/UUID/corrected dates, and trying to then modify the Photos database itself.  What I'm trying to avoid is a process of exporting photos, deleting them from the Photos database, fixing the dates, and then reimporting the photos as that would erase the work I've done with all the manual face tagging I've done.  My hope is to do this in batches based on those newly identified dates, but I could also just generate bash scripts to call OSXPhotos to do this one-at-a-time if necessary.
So...is that a possibility with OSXPhotos?  Or maybe there's a different approach I could use?  I'm running on Venture 13.0.1, Photos 8.0.
Thanks!  This has been an awesome tool to learn and use, especially from a programming standpoint.  And apologies if I've not tagged this correctly; I don't think it's a bug or a feature request.

See osxphotos help timewarp for help on the timewarp command which is designed to batch adjust photo dates.  Online help for timewarp here
To do this programmatically, you can use photoscript which I've also written (and is used by osxphotos).  Photoscript is a python wrapper around Photo's AppleScript interface.  It can set the date but not the timezone. To set the timezone, the timewarp command does some SQL black magic to directly modify the Photos database...something that took a fair amount of reverse engineering to get right. You can look a the timewarp code for reference.
Doing this from memory but using photoscript should be something like this:
import datetime
import photoscript # already installed by osxphotos as a dependency

# assuming photo is a osxphotos.PhotoInfo object:

photoscript.Photo(photo.uuid).date = datetime.datetime(2022,11,16,8,43,0)

The Photo() class in photoscript is analogous to the PhotoInfo class in osxphotos and is instantiated with a UUID which is same UUID used in osxphotos.

Thanks! This has been an awesome tool to learn and use, especially from a programming standpoint.

 I'm glad you've found it useful.  Don't hesitate to ask questions. The discussions page is good for non-bug/feature discussion.


Swift 4.2 Support

Looks like you guys are yet to release a version to support Swift 4.2?
When I updated my project to Swift 4.2 with Presentr 1.3.2 Things are breaking, Any plans around releasing new version to support 4.2?

bump

done! let me know if there's any issue.
sorry for the wait, been really busy.


@field_serializer("*") is not compatible with @computed_field when expecting FieldSerializationInfo

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
PR #9001 added support for wildcard field_serializer functions, similar to how they exist for field_validators.
For wildcard field serializers, it generally makes sense to include the pydantic.FieldSerializationInfo parameter, so you can access the field_name or serialization mode.
However, when a @computed_field is present on the same model class, this generates an error:
pydantic.errors.PydanticUserError: field_serializer on computed_field does not use info signature (see source)
Please make those two features compatible. We have a "generic serialization handler" declared in a base class, and this limitation means that no child classes can ever make use of computed fields.
Accessing the field name and serialization mode makes sense even for computed fields, could this be supported?
Example Code
import pydantic
from typing import Any

class MyModel(pydantic.BaseModel):

    other_field: int = 42

    @pydantic.computed_field
    @property
    def my_field(self) -> str:
        return "foo"

    @pydantic.field_serializer("*")
    def my_field_serializer(self, value: Any, info: pydantic.FieldSerializationInfo) -> Any:
        print(f"{info.field_name} = {value}")
        return value

Python, Pydantic & OS Version
pydantic version: 2.7.3
        pydantic-core version: 2.18.4
          pydantic-core build: profile=release pgo=true
               python version: 3.10.12 (main, Apr 22 2024, 22:00:51) [GCC 11.4.0]
                     platform: Linux-6.5.0-10040-tuxedo-x86_64-with-glibc2.35
             related packages: fastapi-0.103.1 typing_extensions-4.12.1
                       commit: unknown

@bonauer-pf,
Thanks for reporting this bug. We'll work to get this fixed!

@ornariece,
Any interest in having a go with this one?

I can take this one.

@sydney-runkle @nix010 🙏

@nix010,
Go for it. My thought was, we can try to add support for serialization info to computed fields. If that doesn't work, we'll have to find another approach!

Marking as resolved, given the merged PR in pydantic-core. This should be fixed in v2.9!

Hi! Any timeline for that release?

Yep - next week! You can use pydantic-core v2.23.0 with pydantic's main branch if you want the changes now :).

Awesome thanks!

Hey @sydney-runkle, unfortunately this isn't fixed with Pydantic 2.9.0.
I can still totally reproduce the issue described in the first post.
Used a minimalistic pyproject.toml.
name = "pydtest"
requires-python = ">=3.12"

[tool.poetry]
authors = ["Me"]
description = ""
name = "pydtest"
readme = "README.md"
version = "0.1.0"

[tool.poetry.dependencies]
pydantic = "^2.9.0"
python = "^3.12"

[build-system]
build-backend = "poetry.core.masonry.api"
requires = ["poetry-core>=1.0.0"]

Error I get:
cperrotminot@CharlesPM-M1Pro-HCHB pydtest % poetry run python pydtest/test.py
Traceback (most recent call last):
  File "/Users/cperrotminot/Workspace/promo_applications/platform/aggregator/pydtest/pydtest/test.py", line 6, in <module>
    class MyModel(pydantic.BaseModel):
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_model_construction.py", line 223, in __new__
    complete_model_class(
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_model_construction.py", line 568, in complete_model_class
    schema = cls.__get_pydantic_core_schema__(cls, handler)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/main.py", line 670, in __get_pydantic_core_schema__
    return handler(source)
           ^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_schema_generation_shared.py", line 83, in __call__
    schema = self._handler(source_type)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py", line 655, in generate_schema
    schema = self._generate_schema_inner(obj)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py", line 924, in _generate_schema_inner
    return self._model_schema(obj)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py", line 741, in _model_schema
    self._computed_field_schema(d, decorators.field_serializers)
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py", line 1973, in _computed_field_schema
    return_type_schema = self._apply_field_serializers(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py", line 2218, in _apply_field_serializers
    is_field_serializer, info_arg = inspect_field_serializer(
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cperrotminot/Library/Caches/pypoetry/virtualenvs/pydtest-KNE1Tm0Q-py3.12/lib/python3.12/site-packages/pydantic/_internal/_decorators.py", line 591, in inspect_field_serializer
    raise PydanticUserError(
pydantic.errors.PydanticUserError: field_serializer on computed_field does not use info signature

For further information visit https://errors.pydantic.dev/2.9/u/field-serializer-signature

@sydney-runkle Just got some air after a busy while. I just checked it again. There's a check that raise the error, the problem will go away if that block removed.
What do you think ? Don't remmeber there was a check when I was working on it.
https://github.com/pydantic/pydantic/blob/204e109691c69583e656c6e16a62ad79da2f59b9/pydantic/_internal/_decorators.py#L590-L593

What do you think ? Don't remmeber there was a check when I was working on it.

I'd say let's remove the check + add full support! Thanks! Welcome back 🥳

Fixed by https://github.com/pydantic/pydantic/pull/10390

Any chance of when this could be released @sydney-runkle ?

@CharlesPerrotMinotHCHB,
Will probably have to wait for v2.10, which we're planning to release in late October. You can install from main in the meantime, if you'd like this change ASAP.
If there's high demand, we could do another patch with this fix, but probably not for another week or two, as we'd want to bundle in any remaining 2.9 fixes.

Totally makes sense, thank you @sydney-runkle!
There is a workaround using field_validator, so I'd say it's not that urgent.


Metaworld

add metaworld and sokoban

Thanks for the PR but this is a massive change with 24,000 lines changed.
Could you explain why you made these changes?
What the changes actually are?
Is this backward compatible?
Does this fix any bugs?
Could this PR be split into 4/5 smaller PRs each with individual goals

I mistakenly made this pull request. Could you please help me contact GitHub support and delete this pull request?


Error making pack

i suppose this is a bug.
I have the .exe file, the vanilla resource folder, and lookup folder in the same directory. But whenever i tried to make a pack after exporting the structure, it failed with error messages as below:
no rotation for chest found
no rotation for chest found
no rotation for chest found
no rotation for chest found
no rotation for barrel found
Exception in Tkinter callback
Traceback (most recent call last):
  File "structura.py", line 96, in generate_pack
  File "armor_stand_class.py", line 74, in make_block
  File "armor_stand_class.py", line 337, in block_name_to_uv
  File "armor_stand_class.py", line 312, in extend_uv_image
IndexError: tuple index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tkinter\__init__.py", line 1883, in __call__
  File "structura.py", line 161, in runFromGui
  File "structura.py", line 99, in generate_pack
  File "armor_stand_class.py", line 74, in make_block
  File "armor_stand_class.py", line 337, in block_name_to_uv
  File "armor_stand_class.py", line 312, in extend_uv_image
IndexError: tuple index out of range

Can you post the structure file somewhere. i would like to see this one, this is an error i am not handling properly and i didnt put enough info in the log.

Can you post the structure file somewhere. i would like to see this one, this is an error i am not handling properly and i didnt put enough info in the log.

Here is the link for the structure file for your reference.
https://we.tl/t-sLtkARd1p2

Here is the link for the structure file for your reference.
https://we.tl/t-sLtkARd1p2

Some things mojang does are weird. If you change to any shulker other than the "undyed" this would work.  if you want to "fix it" in your current download, open the shulker shulker_top_undyed.png change Image>mode> to RGB. Export as png. the drop down should be RGBA.
This breaks because my program expects RGBA files because they allow me to set transparency
I will fix it in the next update...   you can download the file below and put it in Vanilla_Resource_Pack\textures\blocks replacing shulker_top_undyed.png on your local install.. that will fix it.

Some things mojang does are weird. If you change to any shulker other than the "undyed" this would work.  if you want to "fix it" in your current download, open the shulker shulker_top_undyed.png change Image>mode> to RGB. Export as png. the drop down should be RGBA.
This breaks because my program expects RGBA files because they allow me to set transparency
I will fix it in the next update...   you can download the file below and put it in Vanilla_Resource_Pack\textures\blocks replacing shulker_top_undyed.png on your local install.. that will fix it.

Fixed in the next update

Fixed in the next update


add containerSecurityContext to Values file

Set the securityContext at the container level in values file. To install the operator on openshift with the 'restricted' scc, you need to choose a user and an fsgroup allowed by the namespace. User 10001 will give an error.

Hi @itmwiw, thanks for your contribution! Could you enable maintainers' editing on this PR, see here, or generate documentation and schema by running make docs schema yourself?

Hello,
You're welcome. By the way, keep up the good work, this operator is amazing!
I did not found the checkbox to enable maintainer's editing but I did run make docs schema.

Awesome, thanks! We'll cut a release of the helm chart as soon as possible!

Somehow this is not working in OCP 4.14.
I get this error when installing the Helm chart:
  - lastTransitionTime: "2024-01-12T12:28:45Z"
    lastUpdateTime: "2024-01-12T12:28:45Z"
    message: 'pods "cnpg-cloudnative-pg-7b4546c987-" is forbidden: unable to validate
      against any security context constraint: [provider "anyuid": Forbidden: not
      usable by user or serviceaccount, provider restricted-v2: .containers[0].runAsUser:
      Invalid value: 10001: must be in the ranges: [1000850000,<PHONE_NUMBER>], provider
      "restricted": Forbidden: not usable by user or serviceaccount, provider "nonroot-v2":
      Forbidden: not usable by user or serviceaccount, provider "nonroot": Forbidden:
      not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden:
      not usable by user or serviceaccount, provider "machine-api-termination-handler":
      Forbidden: not usable by user or serviceaccount, provider "hostnetwork-v2":
      Forbidden: not usable by user or serviceaccount, provider "hostnetwork": Forbidden:
      not usable by user or serviceaccount, provider "cassandra-scc": Forbidden: not
      usable by user or serviceaccount, provider "hostaccess": Forbidden: not usable
      by user or serviceaccount, provider "node-exporter": Forbidden: not usable by
      user or serviceaccount, provider "privileged": Forbidden: not usable by user
      or serviceaccount]'

I tried creating an SCC as well for the serviceaccount but still not working.


don't sort the input array in ISI

The approach taken in #104 is not clear:

firstly, the author didn't describe scenarios where the spike times are not sorted. We're relying on times being sorted in neo.SpikeTrains throughout many other functions in elephant: kernels.median_index, instantaneous_rate, ... Why should we make an exception for 0.01 % of use cases, if any?
secondly, sorting an array is O(N logN) in time and it's a slam to optimizations in Elephant.
thirdly, the merged solution does an extra copy by accessing .times attribute of a spiketrain, which creates a copy under the hood, compared to .magnitude.
finally, sorting is not the only solution to the original problem stated in the pull request. If we do want to deal with unsorted arrays, which is argued upon, a simple check with a warning will do the job in linear time.

Not to mention the absence of a regression test.

Coverage increased (+0.02%) to 89.929% when pulling ae81a9f91429890c6d290d4f3e42853e59f82b6b on INM-6:fix/faster_isi into bb83045bf0831644aa8f096b7f297eeb9255c460 on NeuralEnsemble:master.


NetworkInstrumentation without KVO

NetworkInstrumentation without KVO

Going with https://github.com/signalfx/splunk-otel-ios/pull/124 at the moment


Tree Split

closes: https://github.com/centrifuge/go-centrifuge/issues/1280

@vedhavyas I didnt change anything on the submodule. Not sure why the commits have changed there, but the gitmodule branch is still the one that you specified and there are no diffs.
As I mentioned to you offline, I will add more tests to the PR soon.


How long is a timeout?

Docs just say : Double Request timeout. and the default is 15.0, so I'll guess it's 15 minutes ...
Units matter.

Good question. A review of the JavaScript and platform implementation do not mention whether it's seconds or minutes.
When someone has a moment, please update the docs and reference this issue.


changes for chromium.ico fail to take effect

I have modified all possible PNG, SVG, ICO and more files containing the chromium logo and it refuses to change the application icon, does anyone know why, or the direct file path causing this? basically I've modified all chromium.ico files (works in chromium) and they fail to take effect.

You can take a look at my python rebrand script to see how I do it
https://github.com/0xGingi/0xgingi-browser/tree/main/rebrand

ok thanks

What script do I run? I see tons of icons and logos.

script.py is the main rebrand script, config.py has all the icon/logo locations

so run both?

yeah, modify the script.py to your src location/rebrand name, replace the icons with yours, then run config.py then run script.py

it just modifying all the Icons? I already did that all these are modified it just won't show the logo.
The dock/app icon is chrome but everything else is mine

Exactly which application icon isn't changing for you?

everyone but the applciation icon being when you search for Undone (my browser) it's renamed and everything just won't change the icon every every icon is changed but the dock icon, the app icon all possible chromium.ico files are changed.

Do you mean like this? It could either be some windows caching issue then maybe?

yes

the only icon error

Dumb question, but have you rebooted since changing the icon?

I have many times and you can search my code all chromium.ico files are modified

Hmm interesting, you can take a look at how I do my replacements on my repo and see if that works better for you. I split the build.py into 2 scripts. The first part downloads chromium and runs the patch files, then the 2nd script does the building, I run the rebrand script and other file replacements in between the 2.

This issue tracker is for reporting issues for ungoogled-chromium-windows.


Can't build it on a Raspberry Pi

Apparently there's no python3-venv for arm. How can I successfully build this locally?
~/services/jam$ docker-compose up --force-recreate --build
[+] Building 2295.3s (15/32)
[+] Building 2295.6s (15/32)
[+] Building 2295.7s (15/32)
[+] Building 2295.9s (15/32)
[+] Building 3313.8s (22/32)
 => [internal] load .dockerignore                                                                                1.6s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load build definition from Dockerfile                                                                1.8s
 => => transferring dockerfile: 4.76kB                                                                              0.1s
 => [internal] load metadata for docker.io/library/debian:bullseye-20221004-slim                                    3.6s
 => [internal] load metadata for docker.io/library/alpine:3.16.2                                                    3.8s
 => [internal] load build context                                                                                1.0s
 => => transferring context: 28.09kB                                                                                0.1s
 => [dinit-builder 1/4] FROM docker.io/library/debian:bullseye-20221004-slim@sha256:b46fc4e6813f6cbd9f3f6322c72ab9  4.9s
 => => resolve docker.io/library/debian:bullseye-20221004-slim@sha256:b46fc4e6813f6cbd9f3f6322c72ab974cc0e75a72ca0  0.8s
 => => sha256:b46fc4e6813f6cbd9f3f6322c72ab974cc0e75a72ca02730a8861e98999875c7 1.85kB / 1.85kB                      0.0s
 => => sha256:714808e7c76753860e1d033b165bba0299d900311053ee68cbdba9c80dba8dff 529B / 529B                          0.0s
 => => sha256:b63b039d052ad1e65ab2246b282981f462ec9b5b3706dab3efc6261e413081a0 1.48kB / 1.48kB                      0.0s
 => [builder-base 1/2] FROM docker.io/library/alpine:3.16.2@sha256:65a2763f593ae85fab3b5406dc9e80f744ec5b449f269b6  2.5s
 => => resolve docker.io/library/alpine:3.16.2@sha256:65a2763f593ae85fab3b5406dc9e80f744ec5b449f269b699b5efd37a07a  0.8s
 => => sha256:65a2763f593ae85fab3b5406dc9e80f744ec5b449f269b699b5efd37a07ad32e 1.64kB / 1.64kB                      0.0s
 => => sha256:922df7f9352943c7447dbc07c53563e6971fce3100d2ef2b8368b1ba9aac605d 528B / 528B                          0.0s
 => => sha256:16d65c69c39d32f07bf75fdecca40ed6486e0cd37890fc9e5ac37f316b4f78c4 1.49kB / 1.49kB                      0.0s
 => [builder-base 2/2] RUN apk add --no-cache --update git                                                         12.3s
 => [stage-4  2/17] RUN addgroup --system tor     && adduser --system --disabled-login --ingroup tor --gecos 't  1682.5s
 => [dinit-builder 2/4] RUN apt-get update     && apt-get install -qq --no-install-recommends --no-install-sugge  397.2s
 => [server-builder 1/2] WORKDIR /usr/src/joinmarket-clientserver                                                   2.0s
 => [ui-builder 1/3] RUN apk add --no-cache --update nodejs npm                                                     9.9s
 => [server-builder 2/2] RUN git clone "https://github.com/JoinMarket-Org/joinmarket-clientserver" . --depth=1 --  12.9s
 => [ui-builder 2/3] WORKDIR /usr/src/jam                                                                           1.6s
 => [ui-builder 3/3] RUN git clone "https://github.com/joinmarket-webui/jam" . --depth=1 --branch "master"       2699.2s
 => [dinit-builder 3/4] WORKDIR /usr/src/dinit                                                                      5.8s
 => [dinit-builder 4/4] RUN git clone "https://github.com/davmac314/dinit" . --depth=1 --branch "v0.16.0"     &  2300.4s
 => [stage-4  3/17] COPY --from=dinit-builder /usr/src/dinit/dinit-bin/sbin /sbin                                   8.1s
 => [stage-4  4/17] COPY --from=ui-builder /usr/src/jam/build /app                                                  8.7s
 => [stage-4  5/17] COPY --from=server-builder /usr/src/joinmarket-clientserver /src                               12.1s
 => [stage-4  6/17] WORKDIR /src                                                                                3.4s
 => ERROR [stage-4  7/17] RUN ./install.sh --docker-install --without-qt     && rm --recursive --force install.sh  22.9s
------
 > [stage-4  7/17] RUN ./install.sh --docker-install --without-qt     && rm --recursive --force install.sh deps/cache/ test/ .git/ .gitignore .github/ .coveragerc joinmarket-qt.desktop:
#0 12.74 ./install.sh: line 10: python: command not found
#0 20.63   Installed: (none)
#0 20.99 TERM environment variable not set.
#0 21.49 Reading package lists...
#0 21.58 Building dependency tree...
#0 21.58 Reading state information...
#0 21.63 Package python3-venv is not available, but is referred to by another package.
#0 21.63 This may mean that the package is missing, has been obsoleted, or
#0 21.63 is only available from another source
#0 21.63
#0 21.64 E: Package 'python3-venv' has no installation candidate
#0 21.64 Dependecies could not be installed. Exiting.
------
failed to solve: executor failed running [/bin/bash -o pipefail -c ./install.sh --docker-install --without-qt     && rm --recursive --force install.sh deps/cache/ test/ .git/ .gitignore .github/ .coveragerc joinmarket-qt.desktop]: exit code: 1

Hey @johnnyasantoss, thank you so much for the report!
After studying it, this seems to have been introduced to JM with https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1396. It means you are building from the current master branch, right? If you want, try building with backend version v0.9.8 (the current version at the time of writing). According to a comment by @kristapsk, it might be fixed in an upcoming PR. To be sure, please always use the latest official release of JM.
See also:

https://github.com/joinmarket-webui/jam/issues/581
https://github.com/joinmarket-webui/jam/pull/585

I've tried again the past Sunday, and it builds (!), but then it's just like the image ghcr.io/joinmarket-webui/jam-standalone:latest, the backend processes get killed/crash instantly and keep restarting. I think it might be related to the architecture (I'm trying to run it on a Pi4).

I've tried again the past Sunday, and it builds (!), but then it's just like the image ghcr.io/joinmarket-webui/jam-standalone:latest, the backend processes get killed/crash instantly and keep restarting. I think it might be related to the architecture (I'm trying to run it on a Pi4).

"How" does it crash? Do you connect to a mainnet node? How are you starting the container?

Is there an env var to make all binaries print out a verbose log? Right now the logs are meaningless, it just says that the application exited.

Is there an env var to make all binaries print out a verbose log?
No. They are written to files in /var/log/jam dir inside the container (if not mapped to the host file system).

Right now the logs are meaningless, it just says that the application exited.
Please see https://jamdocs.org/FAQ/#how-do-i-view-the-log-file

This should provide more insights into what is the actual problem here.


Unknown layer:layers

keras.models.load_model('vgg19_cifar10.h5')
but have an error:
D:\Users\Python\python3.exe D:/pythonwork/Adversarial/Cifar10_keras_Adversarial/MisClassification.py
Using TensorFlow backend.
Traceback (most recent call last):
File "D:/pythonwork/Adversarial/Cifar10_keras_Adversarial/MisClassification.py", line 100, in
main()
File "D:/pythonwork/Adversarial/Cifar10_keras_Adversarial/MisClassification.py", line 21, in main
kmodel = load_model(weight_path)
File "D:\Users\Python\lib\site-packages\keras\engine\saving.py", line 261, in load_model
model = model_from_config(model_config, custom_objects=custom_objects)
File "D:\Users\Python\lib\site-packages\keras\engine\saving.py", line 335, in model_from_config
return deserialize(config, custom_objects=custom_objects)
File "D:\Users\Python\lib\site-packages\keras\layers_init_.py", line 55, in deserialize
printable_module_name='layer')
File "D:\Users\Python\lib\site-packages\keras\utils\generic_utils.py", line 145, in deserialize_keras_object
list(custom_objects.items())))
File "D:\Users\Python\lib\site-packages\keras\engine\sequential.py", line 292, in from_config
custom_objects=custom_objects)
File "D:\Users\Python\lib\site-packages\keras\layers_init_.py", line 55, in deserialize
printable_module_name='layer')
File "D:\Users\Python\lib\site-packages\keras\utils\generic_utils.py", line 165, in deserialize_keras_object
':' + function_name)
ValueError: Unknown layer:layers

Hi, @gmt710
Please check your keras version.
It works fine in my machine when I use the load_model().
maybe check these issues, 394
7585
10377

@BIGBALLON   what's your keras version？

@gmt710  keras 2.1.5 with tensorflow 1.4.1

@BIGBALLON   Thanks a lot. I solved this problem by updating the keras version to 2.2.4.The previous version was 2.2.0.

@gmt710  very glad to hear this news. 😄


Fixed parameter order of InnerJoin interface

Fix for #477
I went with the non-breaking change way to fix this, but the parameter order seems odd now.

I think we need to change the implementation not the interface

I agree, I just wasn't sure if that was a good idea since anybody using this will have queries failing after updating. There wouldn't be any indication as to what changed and that they need to flip the parameters. However, if somebody else is using this, you would expect they would have ran into the same problem I did and have reported it. So it is probably a non issue.

There wouldn't be any indication as to what changed and that they need to flip the parameters.

You are right, but may be we could log it into the release notes

Please fix the implementation, users should be using the interface anyway.

It looks like I did fix the implementation with the commits from 7 months ago


git One push, but always multi pipeline run, why???

link to been closed. #2360
but the issue is with gogs version control, not gitlab.
and i have question, pipeline start can get git version hash code, why not remove duplication by the hash code??

@sunvooker per our github issue template we as that you use our discourse forum for end user support.


allow symbolic links to be followed during autoimport

What type of PR is this? (check all applicable)

[X] Feature
[X] Bug Fix

Have you discussed this change with the InvokeAI team?

[X] Yes

Description
Follow symbolic links when auto importing from a directory. Previously links to files worked, but links to directories weren’t entered during the scanning/import process.

I wonder if we need this in other places?

I looked and found several other instances where os.walk() was being called without followlinks=True. I’ve updated them.


feat: Login & Register

Closes #32

Ready to merge, kindly check
@jeeehaan @dmaharika @pardi123

Will merge soon, thanks
@jeeehaan @dmaharika


[RFC] directive to vizualize change detection

Would it make them to provide a directive to test change detection inside your application ? To test or debug CD issues.
import { Directive, DoCheck, ElementRef, NgZone } from '@angular/core';

@Directive({
  selector: '[cd-flash]',
  standalone: true,
})
export class CDFlashingDirective implements DoCheck {
  constructor(private elementRef: ElementRef, private zone: NgZone) {}

  ngDoCheck(): void {
    this.cdRan();
  }

  public cdRan(): void {
    this.zone.runOutsideAngular(() => {
      this.elementRef.nativeElement.classList.add('!bg-orange-500');
      setTimeout(() => {
        this.elementRef.nativeElement.classList.remove('!bg-orange-500');
      }, 1000);
    });
  }
}

You just need to add it on a element to vizualise when CD is made inside that element.
What do you think ?

Maybe this is the case to check if isDevMode(), to not have "surprises" in production 😉

IMO it sounds cool and useful for debugging/educational purposes.
Is it decided to be done, or do you need any help with that guys? @tomalaforge @nartc ?

@ducin Yes I need to take the time to do it. It's already done on my angular challenge project, just need to copy paste it and write some documentation.

When multiple CDs run in a short period you would miss that, cause it is either on or off during 1s.
i am thinking of the component flashing up and then slowly fading away during this 1 second. just like space-sniffer is doing: eg: https://www.youtube.com/watch?v=lUnsyAIZO2Q


feat: remainder notification for inactivity

Closes Issue
My PR closes #475
👨💻 Changes proposed(What did you do ?)
added the notification for user when Inactivity found
✔ Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] This PR does not contain plagiarised content.
[X] The title and description of the PR is clear and explains the approach.

📷 Screenshots

this doesn't work

this doesn't work

Notification are coming on safari but not on the chrome
I checked with the existing feature when partner isn't responding  i.e  "your partner isn't responding, want to leave?"
It also wasn't coming , I implemented Accordingly
could you please give me some suggestion on this

this doesn't work

Notification are coming on safari but not on the chrome
I checked with the existing feature when partner isn't responding  i.e  "your partner isn't responding, want to leave?"
It also wasn't coming , I implemented Accordingly
could you please give me some suggestion on this

No one said to implement accordingly, you can do it your own way. If the first one doesn't work create your own
Notice in the issue I only gave two things:

the amount of time in milliseconds
the function to use.

I gave that for a reason.


Enable IAP for frontend by default

Fix svc missing annotation cause the IAP disabled. Fix missing value passed to IAP
Tested-by: zlq

/gcbrun


Clean up test suite and add .gitattributes to exclude dev files from

Builds on top of #16

@SimonFrings Thanks for the clean up! 🧹


Moved reset of speed slider to correct teardown function, so that it …

…resets between each test.

@URJala could you please rebase that and revert the re-formatting that is throwing the error? Apart from that this looks fine, thank you!

Yes, sorry, it should be good now :)


[ISSUE#1899][MAS2.4.6] [Headings and Labels - Open Bot Dialog] Heading should be defined for the pop-up or dialog

Solves #1899
Description
Fixes how voiceover announces the heading for the pop-up or dialogs, by updating this component all the dialog titles will be announced.
Changes made
We updated the dialog component to use an <h1> HTML tag for heading.
Test
Now, the voiceover is reading the title of the dialog before announcing the content.

Coverage decreased (-50.6%) to 16.339% when pulling a84ef21bdeeb38fb5d9a6cd990c5ecbbca06dc78 on fix/define-header-in-dialogs into ffa96e83f58b8d87970448b62d1e8471c630ea25 on master.


TST: spatial: skip failing test to make CI green again

Reference issue
gh-18108
What does this implement/fix?
Skips a test that has been failing in main for about two weeks. Something may still need to be fixed, so gh-18108 can remain open, but in the meantime, it is preferable for CI failures in a PR to indicate a failures caused by that PR.

I pushed in a commit to add a skip for the second problematic Windows Azure test--if all of Azure starts passing after that I'd say we can merge this, but let's wait and see...
I'll continue pursuing the more careful solution, but agree we should get the CI green.

Oops, thanks @tylerjereddy; I just came back to do that.

heh, another failure that expects the pybind11 ValueError path I think; well, we could try skipping that too I suppose, I'll keep at it on the code "fix..."

I'll do that.

Looks like CircleCI is ignoring both [skip circle] and [skip circleci]


Detail page Loops for a 60 seconds if no data is found - v0.28 - nuisance

RuuviSensor F7:B7:74:47:22:AB shows "Nodata" on main page.
Either clicking on it or
clicking on adjacent sensor then clicking > displays  sliding "loading" bar for 60 seconds.
no message is displayed.

I believe this is already fixed. Please reopen if not.


Build tags for optional features?

What is the problem you're trying to solve
Optional / experimental features (IPFS, stargz, nydus, overlaybd, etc) do introduce a fair amount of code and a number of tests that implementors may not be interested in (wether with straight nerdctl builds, or custom cli based on the codebase).
This is especially impactful as IPFS/stargz testing for example is very flimsy and failing builds a lot.
Suggestion here would be to introduce build tags for these to make it either to not compile support in / not test it.
WDYT?
Tagging @AkihiroSuda
Describe the solution you'd like
na
Additional context
No response

NERDCTL_EXPERIMENTAL=0 isn't enough?

NERDCTL_EXPERIMENTAL=0 (run-time env var) isn't enough?

That works only for the nerdctl binary right?
Custom cli using the repo as a library will not benefit from it.
The concern outlined in this ticket is not for end-users using the vanilla nerdctl, but for embedders / developers of custom clis.
Anyhow, this is somewhat low-priority.
If you don't like it, we can close - otherwise I may look into it later.


NaN % in Virtual memory pie chart

I'm using Webmin 1.780 with Authentic theme 17.71 on an embedded system with no virtual memory. The very first time the interface is loaded after a succesfull login the 'virtual memory' pie chart is shown with NaN % (like it calculates div by 0).
Any refresh of the status page is correct with no virtual memory pie chart shown.
The line Virtual memory correctly indicates '0 bytes total/0 bytes used' in both cases.

I'll take a look.

Hello,
i temporarily created an swap file via fstab and it works.
Without the swapfile it shows NaN%
But if you could fix this, i could remove the swap dummy. Or you create a query that proofs the existense of swap etc. an if not disable the chart or so.

I can't even remotely imagine why when you get NaN on output, it's not hidden, when it should.
What happens if you go to line
( ( $disk_percent || $disk_percent eq "0" ) ? $disk_percent : 'NaN' )
and lets say replace it with
( ( $disk_percent || $disk_percent eq "0" ) ? -sin(9**9**9) : 'NaN' )
Will you have Local Disk Space chart hidden?
What browser are you using?

I could reproduce your bug. I will fix it in 17.72

Thanks a lot Ilia!
Your job is really beautiful and your commitment deserve an applause....and a little donation too!!!
9M072990289196125

Thank you!

Please upgrade to 17.72.


Clang format (warning: huge diff)

clang-format configuration file has been added
clang-format has been ran on all .c and .h files

fyi: you are merging in a way that breaks my PGP signature, just letting you know

Hi, Please let me know how I could avoid this - I'm on learning curve.
2016-10-19 22:00 GMT-02:00 uyjulian<EMAIL_ADDRESS>
fyi: you are merging in a way that breaks my PGP signature, just letting
you know
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ifcaro/Open-PS2-Loader/pull/7#issuecomment-254974463,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOSWigcfwLxLRmSZu94EpSjSlx62CsPVks5q1q8wgaJpZM4KbdjW
.

I'm not sure... are you using github desktop or the web interface?

I approved your pull request via GitHub web interface.
2016-10-20 10:23 GMT-02:00 uyjulian<EMAIL_ADDRESS>
I'm not sure... are you using github desktop or the web interface?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ifcaro/Open-PS2-Loader/pull/7#issuecomment-255090776,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOSWihE0GDRzetNnCaKb20my35ko30Gkks5q1108gaJpZM4KbdjW
.

Sorry for resurrecting a very old PR, but I have a question about this... please bear with me:
I believe this was the time when we stopped using TAB to indent in .c and .h files, and instead we started to use 4 spaces to indent.
I was wondering why it's not a good thing to use the TAB method anymore?
And also how can we run the clang-format again in the files?  Is there a command?  Thanks in advance.

the command is clang-format, install it using your favourite package manager

Enforcing code style is good. It's easy to configure most editors for tabs or spaces.
To run clang-format on the files, just pipe it into clang-format.

Still unsure how to go about installing it on my MinGW Windows compiling platform -- see this guide: http://www.ps2-home.com/forum/viewtopic.php?f=50&t=169
So if you can tell me how I can install ClangFormat in that platform (if possible?).  Thanks in advance.

Use a virtual machine


Display HTML content rather than just text content

Currently the timeline view only displays text content from a post, not html content. This is because a label is used to display the text. (this could also potentially help fix parts of #89)
There are a couple directions we could go with this.
My first attempt was to try embedding WKWebView in each post view, and pass the Content HTML in as an HTML string, however that seems to take awhile to load and it's ugly and has issues with it being a scroll view, etc. There may be some better approaches while still using that but I think I've decided to sideline that for awhile.
Another approach is to implement #89 to get images out of the html content, and then convert the HTML content into Attributed Text.
Some links to think through:
https://stackoverflow.com/questions/28124119/convert-html-to-plain-text-in-swift
https://medium.com/theappspace/swift-how-to-convert-html-using-nsattributedstring-8c6ffeb7046f
Besides those, I'm thinking the other option is to only show text content on the timeline view and show HTML on the Full Article view when you swipe right to left.

Currently, I have gone with the Text content in Timeline View and HTML in Full Post View. I'd like to improve this in the future, but there are higher priority issues right now


Install testing framework on cloudflare

Done it. Builds can be prewiewed by clickig the view prewiew link in cloudflare's comment.


Add usage mode to support not resolving dependencies

I am conceptually trying to use liccheck in a CI job as follows:
pipenv lock -r > requirements.txt
liccheck -r requirements.txt

However this fails due to #42 because liccheck tries to resolve all dependencies but they have not actually been installed in any virtualenv. It isn't necessary to resolve dependencies here because the requirements file was generated from the lockfile and has pinned dependencies that have already been resolved.
Is it possible to add a usage mode to support this, or does liccheck require all the dependencies to be installed?

Hey @micahjsmith,
I've added --no-deps in #48. Any feedback/test/review is welcomed.


Spinner$TextFieldEventPolicy is package private and cannot be used outside of a lib

Since 1.1.6 Spinner has Spinner#textFieldEventPolicy and public getter & setter, but Spinner$TextFieldEventPolicy is package private and thus noone can use it outside of a library.

Oops, fixed in https://github.com/kotcrab/vis-editor/commit/95976508f29db6f624f69d6b41b205a6cbb85db3. Thanks for reporting.


Fix v3 compatibilities

Changes to fix v3 compatibilities. 'override' is renamed to 'overrideExisting' since override is a function in v3.

Actual lifesaver. This PR works great.

When this PR will be merged? It would be awesome to have it in the npm package

@nagix Any chance you can take a look at this one, merge, and release it? I'd like to mention it as a Chart.js v3-compatible, working one in Chart.js docs on colors: https://github.com/chartjs/Chart.js/pull/10764#discussion_r995178312

@zsu excellent work with the fixes for V3!
@m08pvv, I appreciate you pushing up your NPM package!  I mentioned it in the Issues area here to help others find it:
https://github.com/nagix/chartjs-plugin-colorschemes/issues/38
FYI, I'm sure you both already know, but the fixes for V3 don't work with V4 for some reason.  I tried to take a stab at it, but I can't figure out why the plugin won't register globally.  I don't see any breaking changes that would cause it to cease working.

Compatibility chart.js v3-v4
https://github.com/nagix/chartjs-plugin-colorschemes/issues/43


Add the ability to define a custom runner label

Currently the runner has a predefined set of labels which makes it harder to manage or observe. It would be nice if the user can define a custom key:value label on the runner. This can help when we run multiple experiments or when we need to differentiate between simultaneously running runners.

Closed in favour of https://github.com/litmuschaos/litmus/issues/1622


Cuda out of memory about calc_cs_loss.py

Thanks for your sharing your code. It's wonderful work I think~~
I have one question about the  calc_cs_loss.py. when I would like to calculate the StyleLoss or ContenLoss by using the calc_cs_loss.py, the code mentioned that cuda out of memory.  My device is an NVIDIA RTX 3090 GPU (24G). May I know how can I calculate the style loss and content loss? In your paper, you just use one NVIDIA RTX 2080 GPU.
Thx for your sharing again!

The issue has been addressed by the new code, please check it.


Forge doc  --watch implementation

Motivation
Solve #8484

Solution
Watch src file changes and regenerate doc

@DaniPopes, @Evalir, @mattsse
What do you think of this approach? Can I go deeper with this implementation or do you think we should consider something different

Please re use the existing watch machinery which is already present for forge test and others.
Also I believe mdbook already has some sort of watch config itself, so i would prefer that if doable

@DaniPopes did you mean something like the current implementation?

Thanks!
FYI I've edited the description to use GitHub keywords when referencing issues.


Merge Request Changes API does not return changes

Description
When we call \Gitlab\Model\MergeRequest::changes the $data will contain the response of
https://gitlab.com/api/v4/projects/xxxxx/merge_requests/yyyy/changes

but as it will be injected in a \Gitlab\Model\MergeRequest object all data will be lost.
Actual result
No changes data is return from \Gitlab\Model\MergeRequest::changes
Expected result
Changes data to be returned in a \Gitlab\Model\MergeRequest object or in a new \Gitlab\Model\MergeRequest\Changes object to reflect API response

PRs welcome


Add help message for applying version override

Turns out that functionality was there. We just have to press Enter to apply config change. Added corresponding help message.
Please review.
Fixes: #184

Thanks, merging.


Define django template backend

django.template.backends.django.DjangoTemplates must be defined with the APP_DIRS set to True for the unit tests to work with Django 1.10.

Hi @thomasgoirand, just to make sure, you are trying to run the tests right? Right now the tox.ini doesn't run the tests on Django 1.9 or 1.10 maybe it would be good to add those to the tox.ini as well.
There is a problem though, the tests are broken for an unrelated reason. I think it's due to a new version of django-compressor. See #44 for more details.


All notes has been removed after the app restart

Sometimes after the app restart, I can get an emty app:

It looks like all the data has been deleted or something. If I look at the db folder, then I will find that the FB file is empty:

I don't know why and what the reason is.

hmmm, looks like this one may be related to this issue: https://github.com/PoloDB/PoloDB/discussions/137
but I still don't know why it happens very rarely... 🤔

Now I cannot create any new spaces or notes... It weird...
Only if I delete db files manually, I'll be able to create new spaces successfully...
Now I cannot reproduce it again...
hm. The polodb version has not been changed. Cargo.lock file hasn't been touched since October 16:

I assumed that maybe it was caused by force quit or process kill. I tried to kill the app with Task Manager, tried to restart/shut down my laptop, and so on. I didn't manage to reproduce this issue. It is weird... 🤔

During the migration to Tauri 2, I added the following line of code:
https://github.com/TheBestTvarynka/Dataans/pull/52/files#diff-e2609b8ec57c998ad48a8e195cd213daf83bfc838ed2ef2687dc79e8aad70952R120
I hope it will fix this issue. I'll close this issue if I do not face it in the next few months.

Looks scary, to be honest. Maybe it's worth considering pivoting to something else, or at least keeping some sort of a backup copy of the DB?

Looks scary, to be honest. Maybe it's worth considering pivoting to something else, or at least keeping some sort of a backup copy of the DB?

I agree with you. I have big plans for the next major version. I plan to migrate storage to something else and add backup support.


Missing assert_isa symbol

When I try to compile and run in an Alpine Linux Docker image, I get the following error:
Can't load '/usr/src/app/local/lib/perl5/x86_64-linux-thread-multi/auto/JSON/JQ/JQ.so' for module JSON::JQ: Error relocating /usr/src/app/local/lib/perl5/x86_64-linux-thread-multi/auto/JSON/JQ/JQ.so: assert_isa: symbol not found at /usr/share/perl5/core_perl/XSLoader.pm line 93.
 at /usr/src/app/local/lib/perl5/x86_64-linux-thread-multi/JSON/JQ.pm line 23.
Compilation failed in require.
BEGIN failed--compilation aborted.

I've searched, but I cannot find where assert_isa should be defined.  It's not in libperl.so:
# LD_PRELOAD=/usr/lib/perl5/core_perl/CORE/libperl.so ldd /usr/src/app/local/lib/perl5/x86_64-linux-thread-multi/auto/JSON/JQ/JQ.so
        /lib/ld-musl-x86_64.so.1 (0x7fe36870b000)
        /usr/lib/perl5/core_perl/CORE/libperl.so => /usr/lib/perl5/core_perl/CORE/libperl.so (0x7fe368310000)
        libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7fe36870b000)
Error relocating /usr/src/app/local/lib/perl5/x86_64-linux-thread-multi/auto/JSON/JQ/JQ.so: assert_isa: symbol not found

And some Googling hasn't been helpful.  I'm hoping you will be!

Hi, it is defined within the code https://github.com/dxma/perl5-json-jq/blob/master/lib/JSON/JQ.xs#L191
Kind of strange it compiled but raised this runtime error.
Could you recompile it and show me the full output ?

My exact environment is a little more complicated, so to try to make in simpler for you to reproduce, I boiled it down to this Dockerfile (so far), which reproduces the issue:
FROM alpine:3.13
RUN apk add bash wget unzip perl perl-dev perl-app-cpanminus build-base cmake openssl openssl-dev zlib-dev
RUN env PERL_MM_USE_DEFAULT=1 cpanm Carton
RUN cd /root && echo "requires 'JSON::JQ';" > cpanfile && carton install
RUN perl -I/root/local/lib/perl5 -MJSON::JQ -le 'It works'

This isn't exactly my setup, but if you could see what's wrong with the above Dockerfile (put into an empty directory, run docker build ., look for an It works output, etc.), then I would be grateful, and would take it from there.

FYI, I also tried using cpanm, rather than carton.  Here's the build log in that case: https://gist.github.com/c7b2e6ddc58c933649af63ad5db6f54e
The output to screen ended as follow:
Building and testing JSON-JQ-0.05
Building JSON-JQ
cc -I. -I/usr/lib/perl5/core_perl/CORE -DVERSION="0.05" -DXS_VERSION="0.05" -fPIC -I/usr/local/lib/perl5/site_perl/auto/share/dist/Alien-LibJQ/include -c -D_REENTRANT -D_GNU_SOURCE -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fomit-frame-pointer -o lib/JSON/JQ.o lib/JSON/JQ.c
ExtUtils::Mkbootstrap::Mkbootstrap('blib/arch/auto/JSON/JQ/JQ.bs')
cc -L/usr/local/lib/perl5/site_perl/auto/share/dist/Alien-LibJQ/lib -shared -Os -fomit-frame-pointer -L/usr/local/lib -fstack-protector-strong -o blib/arch/auto/JSON/JQ/JQ.so lib/JSON/JQ.o -ljq -lonig -lm

#   Failed test 'use JSON::JQ;'
#   at t/001_load.t line 9.
#     Tried to use 'JSON::JQ'.
#     Error:  Can't load '/root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so' for module JSON::JQ: Error relocating /root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so: assert_isa: symbol not found at /usr/lib/perl5/core_perl/DynaLoader.pm line 193.
#  at t/001_load.t line 9.
# Compilation failed in require at t/001_load.t line 9.
# BEGIN failed--compilation aborted at t/001_load.t line 9.

#   Failed test 'JSON::JQ->can(...)'
#   at t/001_load.t line 10.
#     JSON::JQ->can('JV_PRINT_INDENT_FLAGS') failed
#     JSON::JQ->can('_init') failed
#     JSON::JQ->can('_process') failed
#     JSON::JQ->can('DESTROY') failed
Undefined subroutine &JSON::JQ::JV_PRINT_INDENT_FLAGS called at /root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/lib/JSON/JQ.pm line 43.
# Looks like your test exited with 255 just after 2.
t/001_load.t ...........
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 6/6 subtests
Can't load '/root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so' for module JSON::JQ: Error relocating /root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so: assert_isa: symbol not found at /usr/lib/perl5/core_perl/DynaLoader.pm line 193.
 at t/002_basis.t line 7.
Compilation failed in require at t/002_basis.t line 7.
BEGIN failed--compilation aborted at t/002_basis.t line 7.
# Looks like your test exited with 2 before it could output anything.
t/002_basis.t ..........
Dubious, test returned 2 (wstat 512, 0x200)
Failed 14/14 subtests
Can't load '/root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so' for module JSON::JQ: Error relocating /root/.cpanm/work/1621022484.6/JSON-JQ-0.05/blib/arch/auto/JSON/JQ/JQ.so: assert_isa: symbol not found at /usr/lib/perl5/core_perl/DynaLoader.pm line 193.
 at t/003_basic_filters.t line 7.
Compilation failed in require at t/003_basic_filters.t line 7.
BEGIN failed--compilation aborted at t/003_basic_filters.t line 7.
# Looks like your test exited with 2 before it could output anything.
t/003_basic_filters.t ..
Dubious, test returned 2 (wstat 512, 0x200)
Failed 27/27 subtests

Test Summary Report
-------------------
t/001_load.t         (Wstat: 65280 Tests: 2 Failed: 2)
  Failed tests:  1-2
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 6 tests but ran 2.
t/002_basis.t        (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 14 tests but ran 0.
t/003_basic_filters.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 27 tests but ran 0.
Files=3, Tests=2,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.37 cusr  0.07 csys =  0.48 CPU)
Result: FAIL
Failed 3/3 test programs. 2/2 subtests failed.
-> FAIL Installing JSON::JQ failed. See /root/.cpanm/work/1621022484.6/build.log for details. Retry with --force to force install it.
25 distributions installed

I looked at the code.  I noticed that assert_isa() is declared as inline, but not static, like all the other functions around it.  I have verified that if I add static (either in place of inline or in addition to it), then JQ.so loads successfully.


Issue using chunk with limit

I am trying to design an endpoint that has a streamed response for returning large JSON results. I am wanting to add a limit query paramater. But it appears to have no effect when used with chunk()
For example this doesn't work. The limit simply has no effect:
$users = Users::select();
$users->skip(0);
$users->take(1);

$users->chunk(1, function($u) {
    print_r($u);
});

But this does:
$users = Users::select();
$users->skip(0);
$users->take(1);
print_r($users->get())

Please any help would be massively appreciated.

@smaxwellstewart chunk() suggests that it will be overwriting the limit and skip parameters inside the query. If you want to skip a number of parameters using a chunk this is not the right way to go about it.
A better way would be to sort by a field (such as the id) and then in your query, select the rows where the last id was $x.
eg:
$last_seen_id = Input::get('last_id');

$query = Users::where('id', '>', (int)$last_seen_id);
$query->chunk(1, function($u) {
    print_r($u);
});

Ok first off thanks for the response, really appreciated, but I don't view this as a valid solution because:

This relies on sequential id's which is often a bad idea for a variety of reasons, and even if you are using sequential id's does not mean they are garuanteed to be sequentially in order. I could use another field but all of these rely on the fact i know the value of the 'last' row I want to skip over. The advantage of skip is i just need to know how many results I want to skip over, rather than having knowledge of values of those results.
Why should using chunk 'suggests' that it will be overwriting limit and skip parameters? Chunk is purely a method to allow for instatiating large data sets in a controlled manner, right? Surely it is completely acceptable to want to skip and have limits and then chunk the results.

My use case is by default I want to stream a large response but I also want to be able to specify a limit on that endpoint so I can easily grab the first and last item in a dataset. I could have different responses based off of the presence of a limit field but was trying to minimise complexity.
In the end this feature meant we had to change the endpoint to not use streaming anyway, but I still stand by the fact that this is a strange and presumptuous feature of chunking.

@smaxwellstewart Have you checked my PR #9681?
I pretty much agree with you that this is just a pointless limitation due to internal implementation of chunk method.
But it looks like Taylor has different opinion on this topic.

@arrilot Great work. Your commit are exactly what I want, really unsure as to why this is soooo intentional.


Call function feature request

For {}, have beginFlow. But for (), may should add an easier way to generate code?
fun save(tag: String, vararg data: Any) {}

Generated:
save("foo", a, b, c, d)

I may need to do this sometimes:
append("save(")
append("%S, ", "foo")
append("a, ")
append("b, ")
append("c, ")
append("d")
append(")")

So is there a way to simplify these steps?
appendCall("save") {
  appendLine("%S, ", "foo")
  appendLine("a")
  appendLine("a")
  appendLine("b")
  appendLine("c")
  appendLine("d")
}
// or simply...
appendCall("save") {
  +"%S".format("foo")
  +"a"
  +"b"
  +"c"
  +"d"
}

I don't quite understand this one. What's wrong with appendLine("save(%S, a, b, c, d)", "foo")?

I don't quite understand this one. What's wrong with appendLine("save(%S, a, b, c, d)", "foo")?
You can even do:
appendLine {
    append("save(%S, a, b, c, d)", "foo")
    ...
}

This is not wrong, because it is hard-coded, but if the parameters I need to pass in may be from other arrays, or in some special cases I need to enter later, then this may be a bit tricky
Like:
val parameters = ...
append {
  append("save(")
  append("%S, ", "foo")
  parameters.forEachIndexed { index, any ->
    if (index != parameters.lastIndex) {
      append("$any, ")
    } else {
      append("$any")
    }
  }
  append(")")
}

val parameters = ...
append {
  append("save(")
  append("%S, ", "foo")
  parameters.forEachIndexed { index, any ->
    if (index != parameters.lastIndex) {
      append("$any, ")
    } else {
      append("$any")
    }
  }
  append(")")
}

This is similar to how I'm currently using this library. It's not pretty, but the API is made to follow StringBuilder. The question is, how would appendCall be of any help here?

The question is, how would appendCall be of any help here?

I think it can improve the conciseness of the code, such as commas and parentheses, can be simplified by this method, without manual process.

Here is my workaround where parameterNames is a list of parameter names (in your case val parameterNames = listOf( "a", "b", "c", "d")
      .addStatement(
          parameterNames.joinToString(", ","save(", ")") { "%L" },
          *parameterNames.toTypedArray()
      )

will generate
    save(a, b, c, d)


Python Bindings: CP add CMD_STATUS support

I ran into an incompatibility when trying to use some new functionality in the Python bindings: https://github.com/goToMain/libosdp/issues/105
Currently osdp.CMD_STATUS is not exposed to the user of the Python bindings.
Additionally, the evaluated enum value is discarded by pyosdp_make_struct_cmd_dummy.

@Stuckya You can fix this if you are up for it. If not, I will close this PR and fix it myself in a couple of days.


Disable web tracing

At the moment there is no way to disable web tracing. It includes server side but also rest templates.
Created from https://github.com/opentracing-contrib/java-spring-web/issues/38#issuecomment-371468367

@pavolloffay I can do it with pleasure.


Remove PIN information

This all worked well for a PIN Reset, could you add what's required to light up the "Remove Pin" button on Windows 10 Clients when you've got Windows 10 Hello for Business all setup?  (Hybrid Cloud Trust, Reset Service and Client in Azure setup, Change PIN all works but Remove PIN is still greyed out)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d9dae9da-eaf0-c209-7c65-be8d2c1ada12
Version Independent ID: 28b6788d-7982-23c2-5f19-f80690ebc0ce
Content: Pin Reset
Content Source: windows/security/identity-protection/hello-for-business/hello-feature-pin-reset.md
Product: windows-client
Technology: itpro-security
GitHub Login: @paolomatarazzo
Microsoft Alias: paoloma

Hello @mattsmacblog you cannot remove a PIN, why would you want to do that?

I want to "Make Available" the use of Windows Hello for Business for Staff that wish to set it up.  Optional rather than Required.  There seems to be no middle ground with the provided settings, it's either Off or On and required.

this is by design. Check the documentation here: https://learn.microsoft.com/en-us/windows/client-management/mdm/passportforwork-csp "TenantId/Policies/UsePassportForWork Boolean value that sets Windows Hello for Business as a method for signing into Windows.
Default value is true. If you set this policy to false, the user can't provision Windows Hello for Business."


Transformer/Pub Build 404 Not Found error

This issue was originally filed by @rbishop-bah

I've run into a build error when pub attempts to retrieve generator from smoke.  I'm aware that a corrupted pub cache can cause problems like this, but that doesn't seem to be the case here.  I repaired the cache and/or completely deleted the cache multiple times.   Moreover the file that pub was trying to get was actually there, so cache corruption does not appear to be the culprit.  The code had been building without issue; the error started appearing without any connection to any specific configuration change.
Other members of our team have seen a similar error (but the package that it could not find was different).
WORKAROUND:  We discovered that dropping down to SDK 1.6 and building made the problem disappear.  Then, going back up to 1.7.2, the problem did not recur.  So cycling the SDK version made the issue go away somehow.
[INFO] Run pub for package root: C:\Projects\XXX...

Precompiling dependencies...
Loading source assets...
Loading polymer, polymer/src/build/mirrors_remover, polymer/src/build/delete_file, polymer/src/build/remove_sourcemap_comment and observe transformers...
'Unhandled exception:
Uncaught Error: Failure getting http://localhost:53874/packages/smoke/codegen/generator.dart: 404 Not Found
Stack Trace:
#0      _asyncLoadError (dart:_builtin:285)
#1      _httpGet.<anonymous closure>.<anonymous closure> (dart:_builtin:228)
#2      _RootZone.runGuarded (dart:async/zone.dart:1078)
#3      _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)
#4      _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)
#5      _BufferingStreamSubscription._close (dart:async/stream_impl.dart:290)
#6      _ForwardingStream._handleDone (dart:async/stream_pipe.dart:110)
#7      _handleDone (dart:async/stream_pipe.dart:178)
#8      _RootZone.runGuarded (dart:async/zone.dart:1078)
#9      _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)
#10     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)
#11     _DelayedDone.perform (dart:async/stream_impl.dart:614)
#12     _StreamImplEvents.handleNext (dart:async/stream_impl.dart:711)
#13     _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:671)
#14     _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)
#15     _asyncRunCallback (dart:async/schedule_microtask.dart:48)
#16     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)
#17     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)
#0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:883)
#1      _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)
#2      _asyncRunCallback (dart:async/schedule_microtask.dart:48)
#3      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)'
dart:isolate-patch/isolate_patch.dart 286                                                                                Isolate.spawnUri
e:%5Cb%5Cbuild%5Cslave%5Cdart-editor-win-stable%5Cbuild%5Cdart%5Csdk%5Clib%5C_internal%5Cpub_generated%5Clib%5Csrc%5Cdart.dart 234  _isolateBuffer
dart:isolate-patch/isolate_patch.dart 242                                                                                _startIsolate
What version of the product are you using?
1.7.2
On what operating system?
Win 7 x64

This issue has been moved to dart-lang/pub#1180.


Add affected, inserted, updated, deleted row to DatabricksAdapterResponse

Resolves #351
Description
Try to parse the result of the databricks query to extract the following variables and add them to the DatabricksAdapterResponse:

num_affected_rows
num_inserted_rows
num_deleted_rows
num_updated_rows

I have only quickly tested it and have been able to retrieve results like this in run_results.json:
      "adapter_response": {
        "_message": "OK",
        "rows_affected": 358,
        "query_id": "2128ebeb-d6e8-4033-8849-dfa2a5279d65",
        "rows_updated": 358,
        "rows_deleted": 0,
        "rows_inserted": 0
      },

I have not yet written any test for it as I would first like to get your feedback on the approach used. It also certainly requires some more testing to make sure that it returns these metrics consistently and did not have a side effect on other methods like fetchone, fetchmany and fetchall (the last 2 in particular are likely to have been impacted).
Checklist

[x] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

By the way, a much cleaner (and potentially more efficient) approach than the caching of fetchone result would be to make sure that this is executed only for some request types (MERGE, INSERT, UPDATE and DELETE), or even better based on the materialization type. This way, we would now that there would be no reason to use a fetch method on the cursor and could get rid of the caching issue.
Likewise, I don't believe this would work if the table is not Delta. It would not fail either, but it would be nice to avoid trying.
I found no way in DatabricksConnectionManager.execute to find any information about the query type, materialization or table type, and parsing the SQL query would be even more hacky. Maybe there could be a way to feed this information to it? It could for example take an additional optional boolean parameter (defaulting to False) to define whether the query impact metadata should be return, just like I did for get_response.

Another great issue to tackle, thanks.

@ghjklw I'll be on vacation next two weeks.  Just wanted to give you heads up that I still want your two PRs, even though you won't see any activity for me until the new year.

@ghjklw I'll be on vacation next two weeks. Just wanted to give you heads up that I still want your two PRs, even though you won't see any activity for me until the new year.

Thanks for the heads up and no worries! That will give me some time to polish these 😊
If you have a couple of minutes, just to circle back to my message above, do you know if there's any chance within DatabricksConnectionManager.execute to get information about either the type of operation/materialisation or the type of query to avoid trying to collect the statistics when unnecessary... Or is that a dead-end?

If you have a couple of minutes, just to circle back to my message above, do you know if there's any chance within DatabricksConnectionManager.execute to get information about either the type of operation/materialisation or the type of query to avoid trying to collect the statistics when unnecessary... Or is that a dead-end?

I don't think there is any metadata that conveys this client-side, short of inspecting the SQL.  Do you have any idea of the overhead of performing this for every operation?  If it's small enough, we can ignore; if it's large, we probably want to give a config hook to opt into the behavior, since I don't think most users care about the data, though for some scenarios it is very nice to have.  It might be possible to get the information from the cursor, but the type information in the databricks python sql connector (https://github.com/databricks/databricks-sql-python) is a little sparse.


Update all instances of mevn-cli within docs

Minor Documentation Fix
Replace all occurrences of mevn-cli with mevn
Here is the file to work with:  README.md

I can work on this issue.

Sure, go ahead! 😀😀

Fixed #83

@ajomadlabs This issue is not fixed. README.md needs to be updated.
I'm on it

@ajomadlabs Fixed!


⚠ Bofrost.at has degraded performance

In 7d675f0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1795 ms

Resolved: Bofrost.at performance has improved in 7483907 after 34 minutes.


REMOTE CODE EXCEUTION BY FILE UPLOAD IN bludit version 3.12.0

Describe your problem
REMOTE CODE EXCEUTION BY FILE UPLOAD IN bludit version 3.12.0
Steps to reproduce the problem

LOGIN TO ADMIN PANEL
GO TO NEW CONTENT AND UPLOAD IMAGE AND CAPTURE THE REQUEST WITH ANY PROXY TOOL.
AFTER THAT CHANGE IMAGE CONTENT TO <?php phpinfo(); ?> . image uploaded
NOW GO TO http://<IP_ADDRESS>/testing/bludit-3.12.0/bl-content/uploads/pages/XXXXXXX/file.jpg
5 . php code executed.

Bludit version
3.12.0

Hellow,
this issue is a duplicate of #1218 and has already been fixed in the latest master branch (see Pull Request #1219).
~ Sam.