Error: Access Violation in RideOnSample

Is this a bug report? Yes
(Yes/no)
Can you also reproduce the problem with the latest version?
Yes
Environment

Dotnet version: 2019
Operating system: Win10
IDE (Rider, VS Code, Visual Studio): VS
Connecting to Kafka bootstrapped in AWS, but using local RabbitMQ

Steps to Reproduce
Using a modified version of the RideOn sample. No functionality has been added. The events have ben renamed, some new states have been defined, and an appsettings.json file is used to connect to a Kafka host.
(Write your steps here:)

Run the app in VS debugger - Enter 1 at the prompt asking how many loops.
Wait a while, eg 10 mins
Enter blank to get out of loop
App starts to shut down and then crashes with AccessViolationException
Doesn't seem to do it if there is no extended wait before attempting to exit.

Expected Behavior
App closes gracefully.
Actual Behavior
Crash. Full console output (original RideOn):
Enter # of patrons to visit, or empty to quit: [09:07:28 DBG] SAGA:RideOn.Components.PatronState:c0a00000-8af1-00ff-b398-08d94d657769 Used RideOn.Contracts.PatronLeft
Visited: c0a00000-8af1-00ff-b398-08d94d657769
[09:07:28 DBG] Declare exchange: name: RideOn.Contracts:PatronVisited, type: fanout, durable
[09:07:29 DBG] SEND rabbitmq://localhost/RideOn.Contracts:PatronVisited c0a00000-8af1-00ff-66e4-08d94d657a86 RideOn.Contracts.PatronVisited
[09:07:29 DBG] SAGA:RideOn.Components.PatronState:c0a00000-8af1-00ff-b398-08d94d657769 Removed RideOn.Contracts.PatronLeft
[09:07:29 DBG] RECEIVE rabbitmq://localhost/kafka/PatronLeft c0a00000-8af1-00ff-05bb-08d94d6578e5 RideOn.Contracts.PatronLeft RideOn.Components.PatronState(00:00:01.4742382)
[09:07:29 INF] Patron Visited: c0a00000-8af1-00ff-b398-08d94d657769 07/22/2021 23:07:24 07/22/2021 23:39:26 00:32:02.4285908
[09:07:29 DBG] RECEIVE rabbitmq://localhost/PatronVisited c0a00000-8af1-00ff-66e4-08d94d657a86 RideOn.Contracts.PatronVisited RideOn.Components.PatronVisitedConsumer(00:00:00.0349452)
[09:23:18 DBG] Stopping bus: rabbitmq://localhost/
[09:23:18 DBG] Endpoint Stopping: rabbitmq://localhost/kafka/PatronEntered
[09:23:19 DBG] Stopping receive transport: rabbitmq://localhost/kafka/PatronEntered
[09:23:19 INF] Partition: PatronEntered [[0]] was closed
[09:23:19 DBG] Endpoint Completed: rabbitmq://localhost/kafka/PatronEntered
[09:23:19 DBG] Stopping consumer: rabbitmq://localhost/kafka/PatronEntered
[09:23:19 DBG] Consumer completed rabbitmq://localhost/kafka/PatronEntered: 1 received, 1 concurrent
[09:23:19 DBG] Endpoint Stopping: rabbitmq://localhost/kafka/PatronLeft
[09:23:20 DBG] Stopping receive transport: rabbitmq://localhost/kafka/PatronLeft
[09:23:20 INF] Partition: PatronLeft [[0]] was closed
[09:23:20 DBG] Stopping consumer: rabbitmq://localhost/kafka/PatronLeft
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at Confluent.Kafka.Impl.NativeMethods.NativeMethods.rd_kafka_consumer_poll(IntPtr, IntPtr)
at Confluent.Kafka.Impl.NativeMethods.NativeMethods.rd_kafka_consumer_poll(IntPtr, IntPtr)
[   at Confluent.Kafka.Consumer2[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Consume(Int32)    at Confluent.Kafka.Consumer2[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyTok
Reproducible Demo
Use the current RideOn sample. I just tested for this issue with that and ran into the same problem. Entered 1, waited 10 minutes, entered a space character and pressed enter.

It's an issue with the Confluent NuGet package and your OS. It isn't MassTransit.

May be related to https://github.com/MassTransit/MassTransit/discussions/2387


Load nft url dynamically

Do you want to request a feature or report a bug?

What is the current behavior?
I want to load the image descriptor url dynamically.
If the current behavior is a bug, please provide the steps to reproduce.
We have created multiple image descriptors using the node js. All of them are available in AWS S3 bucket. I pass the name of the descriptor in a query param and it should load the url dynamically.

Please mention other relevant information such as the browser version, Operating System and Device Name
What is the expected behavior?
Url does not load dynamically.
If this is a feature request, what is motivation or use case for changing the behavior?

You can try to call the parameter using tick handler in A-Frame. more about this in https://aframe.io/docs/master/introduction/writing-a-component.html#defining-a-behavior-with-the-tick-handler
or you might want to create your own component to manage the query (https://aframe.io/docs/master/core/component.html#aframe-registercomponent-name-definition) and attach it to a-scene.


Increase integration order for segments

They are cheap to integrate, use at least 2 point rule always.

Coverage remained the same at 100.0% when pulling 45dc7d0aecc50922e6d871e0b7fcf65e49bcd0d3 on feature/integrate into 781a388265c11b1cd9790ea972974191da814811 on master.


Failing to install package from package_url

Version 5.3.0
Puppet version 3.8.5
I've been trying to run this module by downloading the deb package from my own host but I'm getting this error:
Puppet (err): Execution of '/usr/bin/dpkg --force-confold -i /tmp/logstash-5.6.8.deb' returned 1: dpkg: error processing archive /tmp/logstash-5.6.8.deb (--install):
cannot access archive: No such file or directory
Errors were encountered while processing:
/tmp/logstash-5.6.8.deb
However the file DOES exist in /tmp after the scripts have failed (meaning that it managed to download it from the url provided). I can even run the command above and it runs fine.
If it is run with the deb file already in /tmp then it runs fine. Im guessing that it doesnt try to download again if the correct package is already there.
My guess is that the scripts are trying to install the deb file before it has finished downloading

It certainly could be an ordering bug. They were quite common in Puppet 3.
Please be aware that Puppet 3 is end-of-life and is not supported by this module. In fact, Puppet 3 was dropped by Puppet (the company) over a year ago. If this problem can be reproduced with Puppet 4 or 5, that would be pretty interesting. We do have acceptance tests proving that install from URL works, so I'm leaning towards this being a bug in that obsolete version of Puppet.

Just revisiting to confirm that it does work with puppet 5.5.1 and it works fine, it was just an issue with puppet 3. Closing issue.

Thanks for checking in. Much appreciated.


bats-action: generates warnings trying to untar the cache

Describe the bug
The bats-core/bats-action GitHub Action generates a number of tar extraction warnings while unpacking the cache.
Note: This is reported here because the bats-core/bats-action repository doesn't have issues enabled, I hope I haven't misunderstood!
To Reproduce
Steps to reproduce the behavior:

Run GHA workflow that populates the cache
Run workflow again

Expected behavior
Cache extraction should succeed and not generate warnings.
Environment (please complete the following information):

<EMAIL_ADDRESS>Ubuntu 22.04
GHA Runner: 2.316.1
Install method: GHA

Additional context
Self-hosted runner.
First run:
Run actions/cache@v4
Cache not found for input keys: Linux-bats-
Run # In $HOME to avoid sudo requirements
Installed Bats to /home/runner/.local/share/bats/bin/bats
Bats v1.11.0 installed in /home/runner/.local/share/bats
Run actions/cache@v4
Cache not found for input keys: Linux-bats-support-0.3.0
Run VERSION=0.3.0
Bats Support v0.3.0 installed in /usr/lib/bats-support

Subsequent runs:
Run actions/cache@v4
Cache Size: ~0 MB (3640 B)
/usr/bin/tar -xf /home/runner/work/_temp/8b89cf35-d286-498e-9531-00378454e3da/cache.tzst -P -C /home/runner/work/expert-happiness/expert-happiness --use-compress-program unzstd
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support/load.bash: Cannot open: No such file or directory
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support/src: Cannot mkdir: No such file or directory
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support/src/output.bash: Cannot open: No such file or directory
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support/src/error.bash: Cannot open: No such file or directory
/usr/bin/tar: ../../../../../usr/lib/bats-support: Cannot mkdir: Permission denied
/usr/bin/tar: ../../../../../usr/lib/bats-support/src/lang.bash: Cannot open: No such file or directory
/usr/bin/tar: Exiting with failure status due to previous errors
Warning: Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
Cache not found for input keys: Linux-bats-support-0.3.0

Attached are more detailed logs of both.

bats-action.first-run.log
bats-action.cache-load.log

Is there any reason I might want to use a custom path into my workspace instead of the automatically imported user lib path? ~/.bats/libs/

Nope, the important part is use a path that is inside the runner user home so the cache will work :)


[epic] Airgap deployments

An epic as it can be seen from three different angles:

[ ] From customers PoV (set an airgap rancher runtime including elemental images, explore airgapped provisioning)
[ ] From QA PoV (testing IBS builds before release, aka use a given registry inside a VPN)
[ ] From Developers PoV (testing pure local builds in a local env)

Looked at how airgap is managed in Rancher Marketplace, guess we can do (almost) the same.
Sharing here for evaluation.
how airgap is managed in Rancher Marketplace
the container images are defined with a image.repository value that just points to the container image path, like:
repository: rancher/backup-restore-operator (sample reference)
the value.yaml file also contains:
global.cattle.systemDefaultRegistry: "" (sample reference)
The systemDefaultRegistry contains the private registry to support the airgap story in Rancher.
Using Helm templating, it is then rendered properly. So, the reference in the templated resources will be something like:
image: {{ template "system_default_registry" . }}{{ .Values.image.repository }}:{{ .Values.image.tag }} (sample reference)
The template is defined here.
we can do (almost) the same
We can do something similar, moving the  image.repository value in our chart from:
"registry.opensuse.org/isv/rancher/elemental/stable/teal53/15.4/rancher/elemental-operator/5.3"
to:
"rancher/elemental-operator/5.3"
then using in the resource template the same as rancher:
image: {{ template "system_default_registry" . }}{{ .Values.image.repository }}:{{ .Values.image.tag }}
but of course, we will define our template. Thinking to something like:
{{- define "system_default_registry" -}}
{{- if .Values.global.cattle.systemDefaultRegistry -}}
{{- printf "%s/" .Values.global.cattle.systemDefaultRegistry -}}
{{- else -}}
{{- "registry.opensuse.org/isv/rancher/elemental/stable/teal53/15.4/" -}}
{{- end -}}
{{- end -}}

Sub-issues:

[ ] Airgap PoC https://github.com/rancher/elemental/issues/937
[ ] ...


Obsoleted RFC

The following ciphersuites should reference RFC 8422 as RFC 4492 has been obsoleted by the IETF
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA as defined in RFC 4492
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA as defined in RFC 4492
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA as defined in RFC 4492
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA as defined in RFC 4492

Resolved in https://github.com/ND-iTC/Documents/pull/66

Resolved in https://github.com/ND-iTC/Documents/pull/66


Plan

High-Level Diagram

Relevant modules

tonyganch/gonzales-pe - CSS parser with support of preprocessors
eventualbuddha/ast-util - Utilities for AST transformers.
dfcreative/ast-replace - Replace nodes in AST by rules

Info

Abstract syntax tree


work-for-faction.js: Working for corpo even with --crime-focus

Running autopilot.js on BN1, I have SF2 so it is trying to get enough karma, but every once in a while (after it meets an invite requirement usually) I catch it working for a corpo for some reason.
At the time of this screenshot, I have -14k karma.
Is this intentional behavior?

work-for-factions doesn't technically have a mode that just does crime just for the sake of doing crime - it is only doing it to meet the minimum combat requirements to get into a faction of interest. --crime-focus merely changes the priority faction order to first try to get into all crime factions before going back to all other factions.
If the next faction it wants to join requires 100 of each stat, and it thinks it can train to that in a sensible amount of time, then it will train all the way to 100. If the faction after that requires 200 of each stat, and it thinks that will take too long, it won't spend a second training and will move on to some other faction.
Hope that makes sense.
So all that said, there is a setting training-stat-per-multi-threshold which defaults to a value of 100. This basically says, with default str/str_exp multis of 1, it will only attempt to train you up to 100 str, anything else will probably take too much time. Once you get some augs boosting your stats (e.g. 2.0 str * 2.0 exp = 4.0) then it'll be willing to try and train up to 400, etc... I've tried to ameliorate the above situation by having autopilot.js call it with a --training-stat-per-multi-threshold of 200, which should at least have it doing crime until it's got 200 of each stat to meet "The Syndicate" combat stat requirements.
If this still isn't sufficient, then perhaps I can add logic to kill work-for-factions.js and call crime.js instead, but in my experiements, it's been sufficient (with the help of sleeves also grinding for Karma).


[Suggestion] Add support for multiple release channels

like an extra configuration

good idea. I could do it like this:
default would be stable release (release). So you dont have to add anything to the config
for anything else (like alpha or beta) add it to the third row
Will be added in the next version


Crud/Edit form is not loading

problem

clear

console

twill:update

public_html->assets->admin

laravel->public->assets->admin

PHP: 8.0.1
Laravel Framework 8.61.0
Twill version:  2.5.2
MEDIA_LIBRARY_ENDPOINT_TYPE=local
MEDIA_LIBRARY_IMAGE_SERVICE=A17\Twill\Services\MediaLibrary\Glide
Shared Hosting:
twill is genertae public folder inside laravel folder. assets are not working
Root:
    -Domain:
            -Laravel Folder
                      -public:
                             -assets:
                                      -admin
            -Public_html:
                      -assets:
                             -admin
                      -index.php

Hi @Heqma, I've never tried this myself but it seems possible to reconfigure Laravel's public folder. Maybe this tutorial can help you:
https://developerhowto.com/2018/11/12/how-to-change-the-laravel-public-folder/

Closing as this is not explicitly supported by Laravel itself. If there is something in Twill that cannot be configured to do what you need, feel free to let us know, but I'm afraid we can't support you with challenges of hosting Laravel on shared hosting.


[ThreadGuard] hook _restart and execute CL_Disconnect_f first.

Just in case server not shutting down properly. (Fuck Valve)

Fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v20240125a


Having undo buffer outside of window session.

Sometimes I'll command-R the editor, then I realize I loose all my command-Z powers. It would be excellent if we serialized the undo buffer so that when the editor is reloaded, I don't loose my undo.

This has been 'implemented' for a long time, but it doesn't actually work; because the undo-stack is accidentally cleared when the buffer is reloaded from disk. I'm sorry this has stayed open for so long; I'm prioritizing it.


White page flashes on screen if the user has previously logged in via Twitter

I think in our current multi-auth implementation, we will always pop up a browser control when the login method is called. In some cases, the user has already logged in and checked the "remember me" box, so the browser control immediately disappears and the user is logged in correctly.
Is there a way to prevent the browser from popping up in that case while maintaining the current (correct) behavior?

Flash is caused most likely due to the cookie being picked up and finishing the login process with the need for the UI to show.


New Assignments not shown properly

Under the assignments tab, it is supposed to show the assignments that a student hasn't submitted. Currently if a student has yet to submit an assignment but another student already submitted that same assignment, at the bottom of this card, it is shown as 'Assignment Submitted!'. Although the user hasn't submitted, it is showing otherwise because some other user submitted this assignment.
@RRK1000 Please look into this.

Issue fixed.


[jvm-packages] non-trivial bug of XGBoostModel.transformInternal

ZipPartitions action at XGBoostModel.transformInternal will cause a mismatch between originalColumns and resultColumns.
val resultRDD = inputRDD.zipPartitions(predictionRDD, preservesPartitioning = true) {
In here, inputRDD and predictionRDD will be evaluated separated. Co-dependencies of these two RDDs will be computed twice, which may produce different row orders inside each partition if previous actions are not strictly keeping the same order (like ShuffleRead).
There is a tiny test below, which will fail because of column mismatching :

val source = ss.sparkContext.parallelize((1 to 20).toList)
val rnd = source.mapPartitions { iter =>
  iter.map(x => x -> Random.nextDouble())
    .toList
    .sortBy(_._2)
    .iterator
}
val negative = rnd.map { case (i, x) => i -> -x }
val zipped = rnd.zip(negative)
zipped.collect().foreach { case (x, y) =>
  x._1 shouldEqual y._1
}

I have provided a fix solution at #4388
@CodingCat


“strng.replace” is not a function

Describe the bug
ETA attempts to use “strng.replace”, which does not exist of course.
To Reproduce
Steps to reproduce the behavior:

Use eta.Render function as intended.

Expected behavior
ETA should use string.replace, not strng.replace. This would avoid the error(?)
Screenshots
If applicable, add screenshots to help explain your problem.
Package & Environment Details

Environment: NodeJS
Version: 16.13.2

This problem doesn't come out of string.replace being used instead, strng is an internal variable used inside of the parsing function, and is used for whitespace trimming. Could you share what exactly your template is, because it doesn't seem this problem is showing up at all for me.

@shadowtime2000 I see the same when trying to evaluate something like; <%= it.name.toUpperCase().replaceAll("foo", "bar"); %> - seems the first string method returns strng and therefore can't be chained?

Closing this as stale.

Still having the problem.

@ScolderCreations could you send me a reproducible example of the error?

I was able to reproduce this by mistakenly passing a Buffer to Eta.renderString instead of a String. I got the buffer from calling fs.readFile without an encoding argument.


optional call method cannot be supported

I use a optional call. It throw error.
TypeError: Illegal invocation

       95 |   // Remove the old try catch block since there will be no error to be thrown
       96 |   // console.log(element.focus)
    >  97 |   element.focus?.()
          | ^
       98 |   // let _a
       99 |   // (_a = element.focus) === null || _a === void 0 ? void 0 : _a.call(element)
      100 |   Utils.IgnoreUtilFocusChanges = false

      at Function.focus (node_modules/jsdom/lib/jsdom/living/generated/HTMLElement.js:114:15)
      at attemptFocus (packages/utils/aria.ts:97:1)
      at Object.focusFirstDescendant (packages/utils/aria.ts:159:1)
      at Object.focusFirstDescendant (packages/utils/aria.ts:159:1)
      at packages/drawer/src/index.vue:147:1

It looks like the focus method  missed right context. The transformed code may be different with the below 'es5' statement which is transformed by tsc.
var _a
(_a = element.focus) === null || _a === void 0 ? void 0 : _a.call(element)
`

Seems the output code is the same with babel, note: the swc was implemented followed the babel.
https://babeljs.io/en/repl#?browsers=defaults%2C not ie 11%2C not ie_mob 11&build=&builtIns=false&spec=false&loose=false&code_lz=KYG2FtgOwFwOgGYHsDGBXAzgfjgCgJRA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=env%2Ctypescript&prettier=false&targets=&version=7.11.1&externalPlugins=

BTW, I have tested in local with codes:
import test from 'ava'

test('optional function call', (t) => {
  const obj: { method?: () => void } = {}
  t.notThrows(() => obj.method?.())
})

Seems to be no problem.

I run transformSync('a.focus?.()', 'test2.js'), the transformed code is
"use strict";
var ref;
(ref = a.focus) === null || ref === void 0 ? void 0 : ref.call(ref);

ref.call(ref) was not right. The expected code is ref.all(a)

@kdy1

Thanks for the report!
I'll fix it soon.

Close via https://github.com/Brooooooklyn/swc-node/commit/5d9966f9eb4b1026356a3f824568f9804faa05ff


AWS IAM login proposal

So, I've hastily put together a proof-of-concept. this isn't the prettiest code, but it works :)
Design goal: I'd like to use the VAULT AWS IAM Auth backend with node-vault. Specifically, so that I can use vault with aws lambda.
This would be so that I can setup an AWS IAM role tied to the lambda function, and then give that role access to vault policies.
because getting a aws4 signature is a bit more complex than something simple like github_login, there is a header construction, aws4 signature phase, and then a base64 encoding.
In lambda, I have this working code:
const vault = require('node-vault')({ endpoint: 'https://vault.example.io:8200' })
const role = process.env.IAM_ROLE_NAME || "vault-lambda-test-role"

exports.handle = (event, context, callback) => {
  vault.awsIamLogin(role)
  .then(result => {
    vault.token = result.auth.client_token
    return vault.read('secret/dev/parse')
  }).then(result => {
    callback(null, result)
  }).catch(error => {
    callback(error)
  })
}

and I added this to src/index.js:
var aws4 = require('aws4');
...

...
client.awsIamLogin = function (role, id) {
    debug('aws IAM login ' + role);
    var awsLoginBody = getSignedAWSLoginConfig(role, id)
    var options = Object.assign({}, config.requestOptions);
    options.path = '/auth/aws/login';
    options.method = 'POST';
    options.body = awsLoginBody;
    return client.request(options)
  }

  function getSignedAWSLoginConfig(role, id) {
    var body = 'Action=GetCallerIdentity&Version=2011-06-15';
    var url = 'https://sts.amazonaws.com/';
    var signedRequest;
    if (id) {
      signedRequest = aws4.sign({
        service: 'sts',
        headers: {'X-Vault-AWS-IAM-Server-ID': id},
        body: body
      });
    } else {
      signedRequest = aws4.sign({service: 'sts', body: body});
    }
    var headers = signedRequest.headers;
    var header;
    for (header in headers) {
      if (typeof headers[header] === 'number') {
        headers[header] = headers[header].toString()
      }
      headers[header] = [headers[header]]
    }
    return {
      role: role,
      iam_http_request_method: 'POST',
      iam_request_url: new Buffer(url).toString('base64'),
      iam_request_body: new Buffer(body).toString('base64'),
      iam_request_headers: new Buffer(JSON.stringify(headers)).toString('base64')
    }
  }

So - I guess my question is: where is the best place to put the specific aws boilerplate coded needed for IAM auth, any input or advice before I start prepping for a refactor and PR?

@kr1sp1n,  @rjrbt
Does it mean the current node-vault package has no way to auth against the Vault using the EC2 appRole and its pkcs#7? I did find auth function but not sure what are valid values in requestOptions.
This is what I do on CLI that needs to be done using the `node-vault:
vault write auth/aws-ec2/login role='reader' nonce='086ec704-311a-4111-8190-418bc6e0ab57' pkcs7=$(curl --noproxy <IP_ADDRESS> --silent --fail http://<IP_ADDRESS>/latest/dynamic/instance-identity/pkcs7 | tr --delete "\n")

With the help of @rjrbt 's code, I was able to use his getSignedAWSLoginConfig and the built in node-vault function node-vault.generateFunction to come up with the following.
const nv = require('node-vault');

const vault = nv({
  apiVersion: 'v1',
  endpoint: process.env.VAULT_ENDPOINT,
  //debug: (...args) => console.log('[NodeVault]', args),
});

vault.generateFunction('awsIamLogin', {
  method: 'POST',
  path: '/auth/aws/login',
});

export const vaultLogin = async () => {
  // check if already logged in
  const postBody = getSignedAwsLoginBody();

  //NOTE: I'm using async/await
  const authResult = await vault.awsIamLogin(postBody);

  vault.token = authResult.auth.client_token;
  //Success, now you can call vault.read or .write
}

This would be a good thing to add to the readme. I additionally added some logic that uses STS to assume roles inside getSignedAwsLoginBody and signs the request with those credentials.

Any progress on this? I'm really interested in having this feature incorporated into node-vault. I've seen @DaniGuardiola has made some headway in his own branch. What's left to be done to merge @DaniGuardiola 's branch in? I'm happy to lend a hand.

@DaniGuardiola yeah, I'd be happy to help, what's the best place for me to start? If there's an IRC channel or similar I can get on to to discuss this, I can do that too.

so is this proposal dead, since the refactoring wasn't merged and DaniGuardiola hasn't the time anymore?

I am sorry I couldn't merge this back then. I keep convincing myself that I will be able to do it sometime soon but things keep getting complicated and my life keeps getting busier and busier so I can't really promise anything.
Would be happy to give some guidance to someone who can get it done.
Sorry @dvejmz I didn't see your message in time.
Hmu if you still can lend a hand and I'll guide you so we can finally get this merged. @kr1sp1n made me a maintainer a while ago so I would be able to merge it and publish it on NPM when it's done.
Keep in mind that all new changes added to the old version should be ported to the refactor fork too.
Thanks for your interest and sorry for my lack of replies. Life's complicated!

Would be great to have this feature available.
What needs to be done, I could try to help.

@dublx great! Here's a list:

I have a branch here which is a complete refactor of node-vault (see this pull request). It needs to be updated with all the changes, features, tests and bugfixes added in the previous version since I last worked on it. Also some tests and documentation must be added as I couldn't finish it.
The branch I created for this feature (aws-auth) needs to be updated with the changes in the refactor branch.
Tests and documentation must be created for this feature.
Once all of this is done, it must be tagged and published onto NPM (v1.0).
Would be nice to leave comments in open PRs to let authors know that the refactor has happened so that they can send the changes based on the new version instead of the outdated one.

Hope this is useful :)

A re-write is cool, but it should be done in stages so people aren't blocked from contributing. The above PR was opened in 2018 and probably isn't happening (going from comments in the PR). So, maybe a requirement to port any changes to the new branch is too strict and the work of porting new changes should fall on the side of the branch that does the refactor?
@DaniGuardiola

Totally agree, it felt overwhelming & I didn't have time to go do it.

I have released a package that extends node-vault and adds AWS IAM authentication working on ECS, EC2 and lambda https://github.com/Kamahl19/node-vault-aws-iam-auth . All attempts mentioned above only work on EC2.

Is this code taking care of assumeRole ?

any progress with this?


Add Unblock-File tests

I believe that using Testcases adds unnecessary complexity in these tests.

LGTM

@adityapatwardhan Thanks for code review!


Swagger uses {param} path params instead of :param

+1
There is a fork from @theomega, which includes a solution for this issue. I would like to see this merged into this repo and released on npm. I opened a PR for this purpose, please have a look.

@philip1986 I'll take a look, sorry the project is not actively maintained but I'm happy to merge some stuff. If you are interested in taking the project, I can add you has a contributor as well at some point.

Fixed by #5

@rricard thx for the quick reaction. I would be glad to become a collaborator of this project.


Fix blank docs

Solves #14
There is also the warning of:
WARNING: html_static_path entry '_static' does not exist
To resolve the warning we would change:
html_static_path = ['_static']
to:
html_static_path = []
But not sure if we want to do that. I'll let the maintainers decide.

Thanks for the contribution - this PR got a bit out-of-sync because of the changes in #76, so I applied the relevant parts in 9388d77ecc96dee39a1af9e3dbb94a46c18eebf7
Feel free to make a separate PR to add yourself to the AUTHORS file!


Symlink happening after service refresh

It appears that the symlink from sites-available to sites-enabled is happening after the service gets refreshed.  This is problematic as we need to bounce nginx manually (unless we make another subsequent change to the configs and re-run puppet)

@gwagner Try
sed -i -e "s/Service\['nginx'\]/Class\['::nginx::service'\]/" manifests/resource/vhost.pp

Should i update to the latest master first?

Could give that a go.  If you're using librarian, just add a git option to the end of the dependency.
—
Sent from Mailbox
On Wed, Jan 28, 2015 at 12:31 PM, Geoffrey Wagner
<EMAIL_ADDRESS>wrote:

Should i update to the latest master first?
Reply to this email directly or view it on GitHub:
https://github.com/jfryman/puppet-nginx/issues/541#issuecomment-71909964

Could give that a go.  If you're using librarian, just add a git option to the end of the dependency and run librarian-puppet update.
(Email gateway comments are always plaintext.)


[WIP] Remove deprecated ProcessBuilder

Also raised minimum PHP version to 5.6 - A new major version release of this package would be best approach to resolve BC issues, I guess?

PR for #3


PageController to write out Last-Modified response header

When a CDN is used in front of DXA, it would be helpful if the PageController could write out the Last-Modified response header with the last published timestamp as value to support content invalidation. For background see Akamai CCU API Concepts.

TSI-1943 (internal issue ID for tracking purposes)

We have been looking into this Enhancement further (we were considering implementing it in DXA 1.7), but found it to be rather tricky:
Obtaining the Page's last publish date from Broker/DD4T and returning it as Last-Modified header is quite easy, but if the Page Model is dynamically modified (e.g. by XO Model Builder, by CX Dynamic Entity Evaluator or by ListController) or contains DCPs, using the underlying Page's last publish date may not be appropriate.
Closely related to the Last-Modified response header is processing of the If-Modified-Since request header. For this, we have to be especially careful with dynamic Pages:  how do we reliably determine whether a rendered Page is modified if it contains dynamic data (which may be obtained from other systems) and even the Views may include dynamic data?
Suggestions how to deal with this?

This functionality would be used (in our case at least) in combination with a deployer extension that flushes the URL on page publish. In this use case using the publish date as Last-Modified header would be perfectly acceptable. Also pages with dynamic content should probably not be cached by the CDN to begin with :).
IMHO I think trying to determine a Last-Modified date depending on when dynamic content on a page changes would be sort of a theoretical discussion and sounds to me like over-engineering the solution. I would compare it to the lastmod time stamp of a page in the sitemap.xml; I don't think anyone generates those real time based on dynamic content on a page.

The question is whether it is useful to put a (potentially wrong) Last-Modified response header in, without processing If-Modified-Since request headers?
Typically, the Last-Modified response header is used to trigger a If-Modified-Since header on subsequent requests and the server can then send an HTTP 304 Not Modified response if the page wasn't modified since that date/time.
However, accurately determining whether a (potentially dynamic) Page is modified is not easy.
I agree that "pages with dynamic content should probably not be cached (by the CDN) to begin with". But how do we distinguish between "pages with dynamic content" and "pages with static content"? Isn't the whole idea behind Dynamic Delivery architectures like DXA that the majority of pages have (more or less) dynamic content?


Performance issue using zcl_excel_writer_2007

Hi.
I'm starting to use ABAP2XLSX and my first was great, but I'm trying to generate a new XLSX file with 300.000,00 lines and the process is going really slow.
I'm using the code from ZDEMO_EXCEL_OUTPUTOPT_INCL.
This is a summary that I'm using in my code.
CREATE OBJECT go_excel.
gs_table_settings-table_style       = zcl_excel_table=>builtinstyle_medium2.
gs_table_settings-show_row_stripes  = abap_true.
gs_table_settings-nofilters         = abap_true.
"After fisrt declarations I fill the internal table  and use bind method
go_worksheet = go_excel->get_active_worksheet( ).
go_worksheet->set_title( "TABLE1" ).
go_worksheet->bind_table( ip_table          = it_001_saida10_exc
is_table_settings = gs_table_settings ).
"After that I basically use the code below.
lcl_output=>output( go_excel ).
"I'm doing a test right now using the ZCL_EXCEL_WRITER_HUGE_FILE class with the code below instead of code above
lcl_output=>output( cl_excel            = go_excel
iv_writerclass_name = 'ZCL_EXCEL_WRITER_HUGE_FILE' ).
My question is, there is a better way to work with huge files? What is the right way to export big files with many tabs?
@ivanfemia @larshp  could you help me?

Hi,
big files can have performances issue, I usually consider a batch process
for those.
Btw the class ZCL_EXCEL_WRITER_HUGE_FILE is the one

that I

use

at the moment

in case of big files.
If anyone has a better idea to improve this process, I'm available to
discuss.
Ivan
On Fri, Mar 16, 2018 at 12:49 PM, Mateus Oliveira<EMAIL_ADDRESS>wrote:

Hi.
I'm starting to use ABAP2XLSX and my first was great, but I'm trying to
generate a new XLSX file with 300.000,00 lines and the process is going
really slow.
I'm using the code from ZDEMO_EXCEL_OUTPUTOPT_INCL.
This is a summary that I'm using in my code.
CREATE OBJECT go_excel.
gs_table_settings-table_style = zcl_excel_table=>builtinstyle_medium2.
gs_table_settings-show_row_stripes = abap_true.
gs_table_settings-nofilters = abap_true.
"After fisrt declarations I fill the internal table and use bind method
go_worksheet = go_excel->get_active_worksheet( ).
go_worksheet->set_title( "TABLE1" ).
go_worksheet->bind_table( ip_table = it_001_saida10_exc
is_table_settings = gs_table_settings ).
"After that I basically use the code below.
lcl_output=>output( go_excel ).
"I'm doing a test right now using the ZCL_EXCEL_WRITER_HUGE_FILE class
with the code below instead of code above
lcl_output=>output( cl_excel = go_excel
iv_writerclass_name = 'ZCL_EXCEL_WRITER_HUGE_FILE' ).
My question is, there is a better way to work with huge files? What is the
right way to export big files with many tabs?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ivanfemia/abap2xlsx/issues/528, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC72WC_qZymzOrypinqOwHjQ1sPd6C_ks5te_tCgaJpZM4SuMb5
.

@ivanfemia do you have an example of using the class ZCL_EXCEL_WRITER_HUGE_FILE?
I'm trying to use it but I'm not moving forward

Just use that class instead of the classical writer.
It has some limitation on the features available
On Fri, Mar 16, 2018 at 3:27 PM, Mateus Oliveira<EMAIL_ADDRESS>wrote:

@ivanfemia https://github.com/ivanfemia do you have an example of using
the class ZCL_EXCEL_WRITER_HUGE_FILE?
I'm trying to use it but I'm not moving forward
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ivanfemia/abap2xlsx/issues/528#issuecomment-373835484,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC72WwIuL7SwSGoHMSrfbMARfcDmck3ks5tfCBBgaJpZM4SuMb5
.

@ivanfemia the problem is when I use the code below

@ivanfemia the problem is when I use the code below I get a erro message saing that "the method CREATE_XL_SHEET is protected"
CREATE OBJECT cl_writer_huge TYPE zcl_excel_writer_huge_file.
cl_output->xdata = cl_writer_huge->create_xl_sheet( cl_excel ).

Huge file writer doesn’t support multi sheets; there are some limitations for using that.

On Mar 19, 2018, at 6:18 AM, Mateus Oliveira<EMAIL_ADDRESS>wrote:
@ivanfemia the problem is when I use the code below I get a erro message saing that "the method CREATE_XL_SHEET is protected"
CREATE OBJECT cl_writer_huge TYPE zcl_excel_writer_huge_file.
cl_output->xdata = cl_writer_huge->create_xl_sheet( cl_excel ).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hallo Ivan,
i am facing the same problem.
The main performance issue comes from the getter methods (e.g. ZCL_EXCEL_WORKSHEET->GET_ROW) searching for the right object using an object collection (while/has_next, get_next, if statement).
One quick approach would be to use the object collection and a Hash Table simultaneously. If an object is added to the collection, we add it to the hash table (e.g. key row_id and a reference to the row object). If we need to iterate over all rows, we can still use the object collection. But if we know which object we need, we get it from the hash table with a simple read.
In MLDOliveira´s case, this saves up to 299.999 iterations while calling ZCL_EXCEL_WORKSHEET ->get_row( 300000 ) once. The performance gain while working with big tables should be huge.
I try to find some time to contribute in this great project.
Patrick

Hi there was a previous commit that solved that issue, but it was reverted for a syntax error. You can start from that commitment, it would be really great!
Ivan

On Jun 28, 2018, at 9:11 AM, Pacojka<EMAIL_ADDRESS>wrote:
Hallo Ivan,
i am facing the same problem.
The main performance issue comes from the getter methods (e.g. ZCL_EXCEL_WORKSHEET->GET_ROW) searching for the right object using an object collection (while/has_next, get_next, if statement).
One quick approach would be to use the object collection and a Hash Table simultaneously. If an object is added to the collection, we add it to the hash table (e.g. key row_id and a reference to the row object). If we need to iterate over all rows, we can still use the object collection. But if we know which object we need, we get it from the hash table with a simple read.
In MLDOliveira´s case, this saves up to 299.999 iterations while calling ZCL_EXCEL_WORKSHEET ->get_row( 300000 ) once. The performance gain while working with big tables should be huge.
I try to find some time to contribute in this great project.
Patrick
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Guess the PR is https://github.com/ivanfemia/abap2xlsx/pull/532

Correct...
I was on my iPhone and couldn't check.
Thank Lars
On Thu, Jun 28, 2018 at 8:44 AM Lars Hvam<EMAIL_ADDRESS>wrote:

Guess the PR is #532 https://github.com/ivanfemia/abap2xlsx/pull/532
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ivanfemia/abap2xlsx/issues/528#issuecomment-401039596,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC72TVf_DiYXxepOEDy3lVeCcW4Rzayks5uBN25gaJpZM4SuMb5
.

Let's close the issue then.


feat: Speed up container image build. Enable ARM64 image building.

Proposed Change

By pulling go build out of the docker build process, github actions can build amd64 and arm64 images in < 2 minutes.
Checklist

[x] Changes are tested
[x] CI has passed

Ive updated Goreleaser to build the image, this way we build binaries once and use them everywhere. You can view the test run here: https://github.com/observIQ/observiq-otel-collector/runs/6041681014?check_suite_focus=true

Once thing to mention, the image tagging scheme will create the following
observiq/observiq-otel-collector   0                 46317cc5d2f3   2 days ago      462MB
observiq/observiq-otel-collector   0.5               46317cc5d2f3   2 days ago      462MB
observiq/observiq-otel-collector   0.5.0             46317cc5d2f3   2 days ago      462MB
observiq/observiq-otel-collector   latest            46317cc5d2f3   2 days ago      462MB

Major and minor version tags will always be updated with the latest major / minor release. I think this is okay as it is an addition to how we do tagging. Historically we just tag once with major.minor.patch.


Don't call super in Danger::RequestSources::GitLab#validates_as_ci?

We don't call super because in some cases the Git remote doesn't match the GitLab instance host.
In Danger::EnvironmentManager#initialize we still check that the request source is #validates_as_api_source?
so that should be sufficient to validate GitLab as request source.
See https://github.com/danger/danger/issues/1231 and https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/10069.
Fixes https://github.com/danger/danger/issues/1231.

          1 Warning

:warning:
Tests were not updated

  Generated by :no_entry_sign: Danger

Tests were not updated

Test cases for hosts with and without a port number already exist, there's nothing more to test, I believe.

Cool, great - yeah this looks good and I agree on the lack of need to test.
Thanks, merging and making a release

Shipped as 8.0.1

Thanks! ❤


fix: error with Upload Excel form

SUMMARY
Fix error with Upload Excel form
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Create database connection with upload support
Create user with Gamma role + permission for Excel uploading + permission for database
Try to open the Upload Excel form from the menu
If you see the form, the correction fixed error

ADDITIONAL INFORMATION

[X] Has associated issue: https://github.com/apache/superset/issues/15866
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Pinging @betodealmeida for review/feedback

Closing, as this was fixed by #16756


Move "On this Page" feature to right nav

Signed-off-by: bermudezmt<EMAIL_ADDRESS>
Proposed changes

Disabled for home but will need to be disabled for other content types
Needs additional styling, plus consider making the navigation fixed

Unreleased product version (optional)

Related issues (optional)
Addresses #927

@cnunciato This is what it looks like at the moment. May need your help with the following: Applying indentation to H3 elements, and sticky positioning for the right TOC. I wanted to see if this is a good general direction.
@justinvp I experimented with Hugo's TableofContents feature, but this seems like the cleanest quickest way to implement this change for now.

I'm seeing the menu appear on the right-hand side of pages that don't have the content to support it. Can we suppress it in these situations? Happy to help here if you like.

Yes, happy to take the help as I'm back to content focus for the rest of the week. Thanks, @cnunciato

@bermudezmt, I've made some changes to get this into shape and address @cnunciato's feedback. I'll push a commit or two soon.

I pushed a commit with various improvements. I believe this is in a good enough state to merge (modulo any feedback), and we can iterate further subsequently (e.g. making it sticky as you scroll). @bermudezmt, @cnunciato, please take a look.

Thank you for the improvements, @justinvp . I noted some follow-up work we have to do on https://github.com/pulumi/docs/issues/1325 but I agree, this is good to merge and will be a helpful addition. :)


New changelog to highlight changes each version.

@claudiofullscreen last change before gem goes public. I don't own this repo, so I can't publish it right?


wili basline

Looks like the wili baseline csv file has a small error. Does Region3 have an extra ","?

It does, this should be fixed by my recent pull request


Cannot handle correctly attachments with the same name in different subfolders

I have a test framework that writes detailed diagnostics out for every test. It does this in a subfolder for each test and, by design, some of the files, like the event log and the screenshots tend to have the same name in each folder. I used the "write out the filename" method to identify these attachments for this plugin to attach to the report.
I have found that the attachment links that appear in the report frequently do not link to the correct files. I believe I have also confirmed by the source code that this bug is due to using only the filename portion of a FilePath to identify the attachment, rather than the entire path.
I plan to develop a patch for this...so if anyone listening on the project has an opinion or advice on this, I welcome the input.

Hey @ChrisLMerrill
For sure - thanks for being awesome! Any and all patches very welcome to this plugin.
Can you please include a reproducible example of the bug that your work fixes? Preferably in the form of a test.


fix(model-server): restore WebSocket endpoint /json/{repositoryId}/ws

The WebSocket was accidentally moved to /{repositoryId}/ws while refactoring in 672d329.

:tada: This PR is included in version 4.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Crawl through nested Value tree without knowing key names?

I have some json incoming from a 3rd party api that looks like this:
 {
    "data":
    {
         "threaded_conversation_with_injections_v2":
         {
             "instructions":
             [
                 {
                     "type": "TimelineAddEntries",
                     "entries":

which may change.  For example that v2 might become v3, while still being nested in the same location.  All I care about is accessing "entries" items so is there a way I could do that by traversing the tree perhaps using pointers?  Or some other method of traversing, such that I could say "select first item, select next nested item, select next nested item" without using the key name directly?
So for example I'd have the above Value stored in json_res and I'd want to call something like json_res.child(1).child(1).child(1).
Or better yet is there some traversing function that I could call such as json_res.get_first("entries") which traverses the tree until it finds the first instance of that key value.

try this one https://crates.io/crates/json_dotpath

Or some other method of traversing, such that I could say "select first item, select next nested item, select next nested item" without using the key name directly?

If a Value stores a JSON object, you can get the ith value with value.as_object()?.values().nth(i)?. See the this Playground example for how it can be applied to your data.

Or better yet is there some traversing function that I could call such as json_res.get_first("entries") which traverses the tree until it finds the first instance of that key value.

This can be done with a find_map() over the values(), which will return the first matching value. See this Playground example for how it can be applied to your data.


Failed to obtain HOSTUUID from XE CLI

[root@x ~]# ./patcher.py -l
Error: Failed to obtain HOSTUUID from XE CLI
This may be related to having more than one IP on the host.

I found with the newest version I'm still getting this error

me too

A new issue was raised relating to this, #64


Building dependencies within a PR

It would be nice to avoid the PR -> test -> merge -> test cycle when building dependencies, and instead submit all dependencies simultaneously and have the new toposort stuff in #93 sort out the build order.
I think it would work -- but only when testing on the master branch on travis-ci -- if we move the uploading block in build-packages.py to within the build_recipe() function. That is, each dependency recipe will be immediately uploaded to the bioconda channel, ready for use in subsequent recipes.
But of course this doesn't work when testing locally or while testing a PR since nothing gets uploaded. While conda install has a --use-local option, there's no such option for conda build.  The closest is I can find is indexing a local channel, documented here.
Maybe when testing locally or in a PR we can just install each package immediately after building? Any other ideas?

Yes, actually that was my intention, and I thought that conda build will use locally built packages.
Are you sure that it does not work like that?

Finally got this working in #149.
Some notes for future reference:

linux recipes are built in a docker container specified in Dockerfile; osx recipes are built in the travis-ci environment built by travis-setup.sh
build-packages.py is used in both environments, so the path to anaconda has to be the same in both environments
Installing from locally-built package works by default, but building does not use locally-built packages by default. The local channel had to be explicitly added.
In order for this to work, conda index needs to be run on the channel after every build, on each platform's subdirectory

So:

Dockerfile and travis-setup.sh both use /anaconda as the installation path
build-packages.py calls conda index right before every build
Johannes added dependency sorting to set the build order
As a demo, #150 was a single pull request with multiple dependencies. These were built in the right order, and the PR passed.


add base_path support to sonarr_list plugin

If Sonarr is behind a reverse proxy with a custom URL Base setting, the sonarr_list plugin wouldn't work because it doesn't support a custom base path. This should fix that.
Motivation for changes:

Can't use sonarr_list with my Sonarr setup (custom base path with reverse proxy)

Detailed changes:

Added base_path config schema option to sonarr_list with default value of '' (should be backwards compatible)

Config usage if relevant (new plugin or updated schema):
tasks:
  task-name:
    sonarr_list:
      base_url: https://server.example.com
      port: 8443
      base_path: /sonarr
      api_key: ...

This example config will use https://server.example.com:8443/sonarr/api/ as the base API path.

thanks!


BGE: Remove "Update this Opportunity" link in BGE Donation Selector component when Opportunity has existing Payments

This update removes the "Update this Opportunity" link within the Review Donations component if the Opportunity has any related Payments.  Previously the "Update this Opportunity" link was exposed and could lead to an out-of-sync state between an Opportunity and its related paid Payments.

Critical Changes
Changes

In Batch Gift Entry, when users click Review Donations, they'll be able to update an Opportunity only if the Opportunity has no related Payments—paid or unpaid. Previously, a user could click Update this Opportunity for Opportunities with related Payments, and this could lead to an Opportunity's amount or stage out of sync with its related paid Payments.

Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-033025

Tracking W-033025


Issue 59 two card slider

Fix #59
🔗 Test URLs:

Before: https://main--caesars-careers--hlxsites.hlx.page/drafts/swbarman/slider-two-card
After: https://issue-10-slider-twocard--caesars-careers--hlxsites.hlx.page/drafts/swbarman/slider-two-card

📝 Description:

The sliding doesn't work for me on 2 cards, it keeps bouncing back to the first one and won't display the second one.


Cookies.enabled is not working

Hi, thank you for this great library,
Can you please fix the issue with Cookies.enabled, it is not working neither in chrome nor IE11.
Console on Chrome and IE11 return undefined for Cookies.enabled

Sorry wrong Library :/


Cannot support vertical scroll

Which OS ?
Android
Version
Which versions are you using:

react-native-swiper v 1.5.6
react-native v0.48

Expected behaviour
cann't support vertical scroll on android platform.
Actual behaviour
using horizontal == false props, can not take effect.

This repo dead: https://github.com/leecade/react-native-swiper/issues/713

1

Same issue!


Create examples for ESP-IDF

This pull request aims to solve the missing ESP-IDF examples mentioned in #175 .
Completed examples:

[x] Send data. Done previously by other contributor.
[x] Process OTA MQTT. Done previously by other contributor.
[x] Server-side RPC command f42a7cb
[x] Process shared attribute update dc87645

@imbeacon Would be nice if this could be merged, because it does not require any additional changes, even a version bump is not required and it would close #175.


Could you release a inference.py for quick inference through CMD??

Hello, First of all, thank you for your hard work on the DAT-2 project. I am very interested in using DAT-2 in one of my projects. However, I noticed that there isn't an inference.py script available for quick inference via the command line, similar to what other projects provide (for example, DRCT's inference.py).
Would it be possible to release such a script? Having an inference.py would greatly enhance DAT-2's accessibility for many more developers.
Thank you very much for considering my request.

Thank you for your suggestion. We will complete the updates soon and let you know.

wow, thank you so much!!!


ENH: adds parse_type and singleton PluginManager

Pair programmed with @jairideout and @jakereps

@ebolyen this is really useful! Had a few comments/questions

Beautiful!!!


python dependences

I miss python dependences in this installation guide:
oauthlib-1.0.3
oauth2

Added it in https://github.com/ging/keystone-oauth2-extension/commit/c671c345d1dad63912addf7fa0bf9c6a15ae63f7.
Thanks for the report!


iOS - Fatal error: Unexpectedly found nil while unwrapping an Optional value

Describe the bug
I am getting the above error when I try to preload mp3 files.
To Reproduce

Add the plugin.
Preload an mp3 from eg assets/sounds/music.mp3
Build and launch app on iOS
Observe fatal error

Expected behavior
The file preloads properly and the application doesn't crash. NB. The issue does not occur in v5.1.3
Smartphone (please complete the following information):
iPhone running latest iOS 16
Additional context
This is the line which throws the error
https://github.com/Cap-go/native-audio/blob/ca819f42fbcfc6e9fd3769f7160c13fc0e948afd/ios/Plugin/AudioAsset.swift#L31

I did have some success in mitigating the error by replacing the line with:
let pathUrl: URL = URL(string: path)
guard let pathUrl = pathUrl else { return }

but I am unsure if this is actually fixing the issue

By doing this it mean preload will not preload.
do you play the sound like that ?

Did a little more digging, and it turned out to be one of my paths has a space in it. PR submitted with a fix


Text is cut off on Samsung Galaxy A71 device

Bug description:
Text added to the webview takes on the correct height except on a Samsung Galaxy A71 device, where the height be too small and some text will be cut off.
Changing the system font size larger or smaller does not fix the issue.
Text looks fine on all other devices, this seems to be an interaction with Samsung's "One UI" setup.
To Reproduce:

Create a project with a webview and some text
Open the project on a Samsung Galaxy A71 device
Observe that the text is cut off.

Expected behavior:
That all of the contents of the webview are shown to the user.
Environment:

OS: Android
OS version: One UI - 4.1, Android 12
react-native version:  0.67.3
react-native-webview version:11.17.2

This is still an issue.

+1

Facing same issue the on my Samsung A 71 the ending of some texts keeps getting chiped out


RNN data iterator for the general inputs

The current design of bucketing iterator could only handle the case of input vector size 1. Of course, this is a general use case for the seq-2-seq or language modeling. But, it could not be used for more general input shape.
In summary, it would be good if we could have a new iterator that can handle input vector of size n.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Add checksum parameter to Document

As suggested in #790, this pull request allows a Document to specify a pre-calculated checksum. This gives data sources the ability to determine a checksum for the items and layouts they create.
This pull request:

adds a checksum parameter to the initializer of Document (as well as new_item and new_layout)
modifies Checksummer to use the checksum on Item and Layout if present
modifies the filesystem datasource to set the size/modification time as checksum

This realizes a major compilation speed gain for my website (from 11s to 3s if nothing is changed), and paves the way for lazy loading of items, which could bring down compilation time even further.

Note that abebd781db309d0c26c3517af50a1de738ac63bd is redundant after 871cd9a6e25d2241345eea956940f24aa7ec9288; however, I left it in for comparison (especially with regard to the tests).

Note that abebd781db309d0c26c3517af50a1de738ac63bd is redundant after 871cd9a6e25d2241345eea956940f24aa7ec9288; however, I left it in for comparison (especially with regard to the tests).

Flagged for style issues. Let me fix that :smile:

Flagged for style issues. Let me fix that :smile:

Also, the code to generate a checksum from a path is kind of a duplicate of the code of the checksummer for pathnames. I did not want to create a dependency between a datasource and the checksummer; while this might be okay for the default filesystem datasource, external datasources would not want to depend on the internal checksummer. (Would also be an argument to have pathnames calculate their own checksum, but we've discussed that already :wink:)

Also, the code to generate a checksum from a path is kind of a duplicate of the code of the checksummer for pathnames. I did not want to create a dependency between a datasource and the checksummer; while this might be okay for the default filesystem datasource, external datasources would not want to depend on the internal checksummer. (Would also be an argument to have pathnames calculate their own checksum, but we've discussed that already :wink:)

This looks good! Some remarks:

I’m not in favour of using the file size and mtime to detect modifications. It’s not accurate enough—it’s trivial to generate two different files with the same checksum. The content and attributes (as strings) are already loaded, and generating a checksum from a string is quite fast (SHA-1 is intended to be fast). For binary items, this isn’t as straightforward, and file size + mtime will have to do.
I’m not saying no to using mtime at all, but for a checksum, I don’t think it suffices. (Idea: only calculate a full checksum when the mtime appears to indicate that the item is outdated—but I believe such a change is out of scope for this PR and would require quite a bit more (architectural) rework.)

The checksummer is part of a private API, but I have no issues with the filesystem data source using that API. It is part of the private API because I don’t want to expose it outside of Nanoc (and have to maintain it as part of the public API).

I wasn't too sure either, hence I left 289f6f38c5bac50e66abdcd42710bfa657c35b72 in. I'll adjust the range of this pull request to not include 8c72d5159151a8f980d7ddd103fa5e5277fe397a anymore.

Alright, but it's not necessary anymore then if the mtime is not used.

Content only needs to be loaded when the checksum is different.

Not entirely correct: the checksum being different is a necessary but not sufficient condition for content to be loaded. For instance, an item (whose checksum is identical) that includes content from another item (whose checksum is different) will need to be recompiled even though its checksum hasn’t changed.
The idea of only loading data when necessary is nonetheless quite interesting and is something I plan to tackle in Nanoc at some point in the future.

:+1: apart from comments

Content only needs to be loaded when the checksum is different.
Not entirely correct: the checksum being different is a necessary but not sufficient condition for content to be loaded.

Yeah, I cut a corner in writing that down. What I meant is: content only needs to be loaded when a reason is found to recompile, since determining that reason no longer requires the item contents.

The idea of only loading data when necessary is nonetheless quite interesting and is something I plan to tackle in Nanoc at some point in the future.

I think it could be as simple as allowing new_item to accept a block and a checksum, but I might be oversimplifying. Can I make an issue to discuss that?

Yeah, I cut a corner in writing that down. What I meant is: content only needs to be loaded when a reason is found to recompile, since determining that reason no longer requires the item contents.

Yup.

I think it could be as simple as allowing new_item to accept a block and a checksum, but I might be oversimplifying. Can I make an issue to discuss that?

I have a few ideas regarding optimisations like these, and I’d rather write down these thoughts in a proper RFC first. (Can’t seem to find the time, though.)

Okay, keep me updated when that RFC goes out :smile:
Finishing this PR now.

All done.

Looks good, thanks!

Some follow-up discussion:

Using mtime+file size as an initial checksum, and only calculating the full checksum if necessary (and only then loading content) is pointless, because when the mtime/file size checksum is different, the item will need to be recompiled and that means loading the content anyway. Additionally, the full checksum will need to be calculated for this item anyway, because it needs to be stored so that it can be used in future compilations. (The previous checksum could be reused rather than recalculated, but I’m unsure whether the speedup would be large enough to make it worth optimise this.)

Not loading content, or lazy-loading content, made much more sense in previous versions of Ruby, but since Ruby as of recently has a generational GC, the performance gains of keeping memory usage low are not nearly as big anymore.

Lazy loading still makes sense, not for memory reasons, but to avoid the overhead of parsing the file and its metadata. The checksum can be made without parsing – only when the checksum is different, the file actually needs to be parsed.

I’d argue that in most cases, parsing the metadata doesn’t impose enough of an overhead to try to avoid doing it—but I haven’t profiled this extensively to be certain of that.

I can give you a quick number: a site with a BibTeX datasource (± 150 items in my use case), compilation  time was 12s before #790 and #793. Now it is down to 3s. Skipping field loading for the 150 items brings compilation time further down to 2s.

This is the “nothing changed” case, correct?

Yes.


Fuel

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

269 of 273 (98.53%)  changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 99.149%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/SpaceShip.class.st
46
50
92.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.9%

Covered Lines:
466

Relevant Lines:
470

💛  - Coveralls


[Question]: startDownload of video (.dat) with cipher_id=1

Ask your question
Goal:
I am trying to download and decrypt encrypted videos with p2p API by using
station.startDownload(device, path, cipherId)
But the history reveals, that the cipherId is "1", which is not a cipher from the admin user (see attachment).
When using (non-existent) cipherId "1":
Unable to start driver TypeError: Cannot convert undefined or null to object     at Station.startDownload (/eufy-security-client/src/http/station.ts:3979:24)
and using the cipher from the admin user does not work either as the key can not be decrypted, because of the wrong cipher. I guess it is a cypher only available internally by eufy.
Question:
Is "station.startDownload" intended to download and decrypt stored local videos, or is it for streaming only?
Is there any other way to download and decrypt stored videos using the p2p API?
I can download these files with "station.downloadImage", but having the encrypted video (.dat) file in the end and still no cipher.
response.json

Is currently no longer supported (since the new encryption was implemented by Eufy).


catching errors inside hooks for logging to papertrail

How do I catch exceptions? This code does not print out an error, where it should throw an exception as b is undefined.
Projects.after.insert(function (userId, doc) {
    try {
        a = b.c
    } catch (err) {
        console.log(err);
    }
});

The best way - to realize catching into the package itself.
Ive done so behavior in the fork and it saves my mind is case of chains of hooks. I dont know, why authors don`t implement it in package, m.b. because of optimization...
Or, do you call that code on server or client?

Wrap Projects.insert calls with try/catch and I believe that would catch errors throw inside its hooks.


st.experimental_rerun was deprecated in version 1.27.0.

We should use st.rerun instead. As decribed on the docs: https://docs.streamlit.io/library/api-reference/control-flow/st.experimental_rerun
and discussed at https://github.com/tylerjrichards/st-paywall/issues/39

Ok I went through and added them to the package, and to the requirements in the repo


Dispatch 'Monitor' flag render function

This is instead of dispatching the flag from the constructor which was called only once, hence neutralizing updates.

thanks @fbarl PTAL


Merge Dev ke UAT 27 April 2017 - Validasi tanggal di SC Weaving

Coverage decreased (-0.007%) to 64.422% when pulling 9a777ea91d990a5111bf7ca3f9c47627eb14490e on dev into 9cbeb7813fa709533067e9a17968ebd06f3a3d58 on uat.


Unable to calculate methylation with new multi-fast5

Hello,
I am having trouble calculating the methylation of my samples using Nanopolish  v 0.11.0, which it has worked perfectly fine until I upgraded Nanopolish and I upgraded to guppy base caller when Nanopore outputs changed to multi-fast5.
I usually first basecall and demultiplex the new multi-fast5 files using guppy v 2.3.1+9514fbc. I then filter the fastq files using NanoFilt v 2.2.0.
At this point I follow the instructions I found on (https://nanopolish.readthedocs.io/en/latest/quickstart_call_methylation.html):
nanopolish index -d <path_to_multifast5_dir> <path_to_filtered_fastq> -s <path_to_guppy_summary_file>

minimap2 -a -x map-int <reference_genome> <path_to_filtered_fastq> | samtools sort -T tmp -o <path_to_output_bam_file>

samtools index <path_to_output_bam_file>

nanopolish call-methylation -t 8 -r <path_to_filtered_fastq> -b <path_to_output_bam_file> -g <reference_genome> > _methylation_calls.tsv

/nanopolish/nanopolish-0.11.0/scripts/calculate_methylation_frequency.py -i _methylation_calls.tsv > _methylation_frequency.tsv

However, this returns an incomplete output. A representative example of my Nanopolish log is the following:
Nanopolish indexing (here you see that I get indexes only for 7 reads out of 24175):
[readdb] indexing ./fast5
[readdb] num reads: 24175, num reads with path to fast5: 7

Minimap2 alignment:
[M::mm_idx_gen::83.829*1.70] collected minimizers
[M::mm_idx_gen::104.091*1.94] sorted minimizers
[M::main::104.092*1.94] loaded/built the index for 194 target sequence(s)
[M::mm_mapopt_update::108.162*1.90] mid_occ = 705
[M::mm_idx_stat] kmer size: 15; skip: 10; is_hpc: 0; #seq: 194
[M::mm_idx_stat::109.917*1.89] distinct minimizers: 100159079 (38.79% are singletons); average occurrences: 5.540; average spacing: 5.586
[M::worker_pipeline::188.219*2.29] mapped 24175 sequences
[M::main] Version: 2.10-r761
[M::main] CMD: minimap2 -a -x map-ont /data/genomics_f/ib361/nanopore_data/genomes/Homo_sapiens.GRCh38.dna.primary_assembly.fasta ./guppy_test_multifastresults/filtering_results/barcode06_filtered.fastq.gz
[M::main] Real time: 188.718 sec; CPU: 431.319 sec

Nanopolish call-methylation (all fast5 classified as bad):
[post-run summary] total reads: 26033, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 26499

This usually outputs incomplete methylation_calls/methylation_frequency files, where only few chromosomes are calculated.
Any idea on how to solve this?
Many thanks
Iacopo

Hi,
There was a problem with the -s option for multi-fast5s. See the discussion here: https://github.com/jts/nanopolish/issues/542
The latest commit (one hour ago) fixes this, can you try it? You'll need to re-run index.
Jared

Hi Jared,
Thanks for your reply. I now ran again the analysis after updating Nanopolish and everything works fine!
Best
Iacopo

Hi ib361 and Jared,
now I got the same problem, how did you fix or solve it?
use the Nanopolish version v0.11.0 and remove the -s paras while nanopolish index?
And the consuming time is proper , nearly few hours?
I have process the summary with proper head, and each fast5 has 4000 reads(multi-fast5).
BEST
Sue

Hi Sue,
Jared solved this issue after an update of the v0.11.0 of Nanopolish. After that I was able to run the commands I wrote above without problems (including keeping the -s option), using multi-fast5 files.
Best
Iacopo

Hi lacopo,
nanopoish v0.11.0 's release version was on Jan 18.
So, in your experience, I can use the vesrion 0.11.1, which will not casue the above problem?
v0.11.1 released on Mar 27.
Best
Sue

I am using v0.11.0, updated after Feb 22. If you check Jared's comment above and the commits it was on that date that the problem with the parsing of the summary file was fixed.
I am assuming that if you use v0.11.1 will work as well since it was released after that problem was solved.
Best
Iacopo

Fine, thanks a lot.
Best
Sue

Hi,
v0.11.0 and v.0.11.1, there are some changes , would these changes can influence the methylation's results?
OR, the changes are just meant to use the input data, like multi-fast5 or summary?
Best
Sue

The changes between those versions should not change methylation calling
results.
Jared
On Tue, Jul 16, 2019 at 3:30 AM Sophia Sue<EMAIL_ADDRESS>wrote:

Hi,
v0.11.0 and v.0.11.1, there are some changes , would these changes can
influence the methylation's results?
OR, the changes are just meant to use the input data, like multi-fast5 or
summary?
Best
Sue
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/issues/547?email_source=notifications&email_token=AAC7DHZXHJEON37YWBZRFPTP7V2IRA5CNFSM4GZHODBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ765BY#issuecomment-511700615,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC7DH2QYE6NFGY3U4FXIBLP7V2IRANCNFSM4GZHODBA
.


My Bootstrap v4 wishlist

I was told in another thread to open an issue with my suggestions for v4, so here they are.

(A) The behaviour of xs is inconsistent with the rest of breakpoints. col-xs-* gets kicked starting from 0px not from $screen-xs-min. It’s sometimes useful to have columns even below $screen-xs-min (although not that much without changing the gutter size), but the difference in behaviour with the rest of tiers make it confusing, IMO. Maybe it would be better to have default col-* styles between 0px and $screen-xs-min and make xs work like the rest.

(B) Add an least an additional breakpoint for small devices. Even with the previous fix, the distance between xs and sm is too big, anyways.

(C) Allow easily setting a different grid at a custom breakpoint using a make-column mixin. Right now, I workaround it using:

  @media (min-width: $bp-bigger-than-xs) {
    @include make-xs-column(4);
  }

(D) Allow different font-sizes for different breakpoints. Using rem instead of px is not enough, the proportion between body and headings is not usually kept constant between desktop and mobile screen sizes.

(E) Keep specificity to a minimum and avoid deep selectors, using specialized classes instead. It would make overriding styles easier (no need to replicate bootstrap selectors) and would decouple from the predefined html structure that some components require. The worst offender is the navbar, but there are others (carousel, pager, panel).

(F) Decouple the javascript from the html and CSS and use custom attributes or specific js-* classes. (e.g. accordion effect only works with .panel)

Improve mobile experience. (G) Animations should be fluid (e.g. navbar toggle), (H) switching between dropdowns should require just clicks.

(I took the liberty of adding identifying letters to each of your points so that they're easier to reference.)

(B) Add an least an additional breakpoint for small devices.

In fact, this has already been implemented in our v4 repo, to address #10203 and friends.

(E) Keep specificity to a minimum and avoid deep selectors, using specialized classes instead.

This is already part of the plan.

(F) Decouple the javascript from the html and CSS and use [...] specific .js-* classes.

This is already under consideration for v4; see https://github.com/twbs/bootstrap/issues/14431#issuecomment-53163098

(G) Improve mobile experience. Animations should be fluid (e.g. navbar toggle)

Unless you have a specific suggestion about how to achieve that, there's nothing more we can really do about the performance of the animations, at least until the browsers themselves fix their translateZ bugs; see #15723 and https://github.com/twbs/bootstrap/pull/13649#issuecomment-57767763

(H) Improve mobile experience. [...] switching between dropdowns should require just clicks.

Now that iOS's clickability bug is more well-understood, it might be possible to address this.

(A) The behaviour of xs is inconsistent with the rest of breakpoints. col-xs-* gets kicked starting from 0px not from $screen-xs-min. It’s sometimes useful to have columns even below $screen-xs-min [...], but the difference in behaviour with the rest of tiers make it confusing, IMO.

I am happy to report that in Bootstrap v4 we've made it much easier to add additional grid breakpoints, and that there's no longer any special-casing based on the names of the grid sizes themselves. But we do still special-case the smallest and largest grid sizes in some places, so that all the grid sizes collectively will always cover all possible viewport sizes.
So if you want to add a new breakpoint below XS, it's a one-line change, and your new smaller grid size will then start at 0px, and XS will then start from the non-zero point at which your new smaller grid size ends.
I think this should remedy your concern.

@cvrebert has addressed the bulk of this, so closing out.

@mdo Could you weigh in on (D) at least?

We'll be using rem units in v4 and won't be resetting individual sizes by breakpoint. That's a bit too much overhead and seems rather specific to the project.

That's great news!

Unless you have a specific suggestion about how to achieve that, there's nothing more we can really do about the performance of the animations, at least until the browsers themselves fix their translateZ bugs; see #15723 and #13649 (comment)

Thanks, I wasn't aware of those translateZ issues.

Now that iOS's clickability bug is more well-understood, it might be possible to address this.

Is that the reason for the current behaviour on android too? For reference, Foundation's dropdowns work with one click on android.

We'll be using rem units in v4 and won't be resetting individual sizes by breakpoint. That's a bit too much overhead and seems rather specific to the project.

I raised it because it's something that repeats quite often in projects at our agency, I'm not sure how frequent that need is for other people.

Now that iOS's clickability bug is more well-understood, it might be possible to address this.

Is that the reason for the current behaviour on android too? For reference, Foundation's dropdowns work with one click on android.

The relevant code just does touch event detection, not iOS UA sniffing, so it ends up being applied on Android too. It's possible that there might also have also been some Android Browser bug that necessitated its use; I'm not intimately familiar with the history of that code.


Amend functions name to be consistent

Please amend to redusize, imgfilter for functions with underscores.

I'll amend function names in test_pyimager

Done #47, #50


Fixes for uses of noescape functions.

Disallow noescape functions from being captured in collections or
passed as arguments in generic positions.
Fixes rdar://problem/24097075.

@atrick @DougGregor @xedin I've tried to plug as many holes related to noescape functions here.
The diagnostics are really bad at the moment, but we can look to improve them.

Oh interesting, one of my later changes for the issues in function.swift results in rejecting the array cases in attr_noescape.swift.
I'll have to take another look at this tomorrow.

Thanks Mark! Will this also reject the cases of assigning into an array or assigning into a varargs?
func bar(a : ()->()) -> () -> () {
  let t = [a]
  return { t[0]() }
}
Another example:
func foo(a:()->()...) -> ()->() {
  return { a[0]() }
}

@atrick Yes it catches capturing a noescape function in an array, and I added a test for that.
For variadics - these functions are considered escaping (just like the elements of an array-of-functions are considered escaping).
I'll add these two test cases to make that clear.
func doesEscape(_ fn : @escaping () -> Int) {}

func takesArray(_ fns: [() -> Int]) {
  doesEscape(fns[0]) // Okay - array-of-function parameters are escaping
}

func takesVariadic(_ fns: () -> Int...) {
  doesEscape(fns[0]) // Okay - variadic-of-function parameters are escaping
}

@swift-ci Please smoke test

@rudkx Do you want to merge your changes and address the problem @aschwaighofer mentioned separately?

@xedin I will take a look at the test case @aschwaighofer mentioned. Then the question is, merge now and fix diagnostics later, or wait until we have better diagnostics. WDYT?

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@rudkx I will take a closer look at these changes and see maybe we could do something differently to help diagnostics, otherwise I think it would be fine to merge and fix diagnostics separately.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@xedin Okay, this takes care of the issue @aschwaighofer raised. It looks like there is a legit source compatibility issue where vapor is stashing away noescape functions.

@swift-ci Please smoke test Linux

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@rudkx It looks like the alternative might be to let such expressions type-check and then diagnose in performSyntacticExprDiagnostics which runs as part of the type-check call unless it's explicitly disabled.

Another way might be to just record this cases as fixes and let the system succeed and then diagnose while trying to apply solution, which I think might be the best way going forward with currently way we do diagnostics.

@xedin and I discussed offline and he's going to take a look at improving the diagnostics after I merge. I'll XFAIL the compatibility test that is broken with this correctness fix.

Just to clarify my previous point I think we should let constraint system form solutions with fixes for escaping functions (to make sure that's the only reason why it failed and mark exactly where it did), emit errors based on that to make them adequate for some time.


[WIP] Swift 4 only changes

Changes only compatible with swift 4.
Depends on:
~~https://github.com/apple/swift-corelibs-foundation/pull/995~~ (but requires SE-110 to be reverted)
~~https://github.com/apple/swift-corelibs-foundation/pull/1023~~
~~https://github.com/apple/swift-corelibs-foundation/pull/1024~~

No there are still a few closure issues that popped up. I saw that some of SE-110 was reverted but I dont think it has been fully done. I will do a quick test and see what is still broken

There were some changes still needed but mostly it was listing the exact number of arguments before in. Ive added a 2nd commit with the changes and it tested ok on Linux.
The PR for the rollback of SE110 is https://github.com/apple/swift/pull/10414

@parkera If you are happy with the closure changes I think this is good to go

One small question but otherwise looks good

@swift-ci test and merge


When not using Publish Command, It doesn't replaces docker build context

Sail Version: 1.4.12
Laravel Version: 8.37.0
PHP Version: 8.0.3
Database Driver & Version: MySql v8.0

Description:
When we don't use publish command specifically, then docker files gets exported but it doesn't replace the build context in the docker-compose.yml file
Steps To Reproduce:
Install sail as normal instructions and instead of using sail:publish command,
run sail artisan vendor:publish --tag=sail
now docker files are exported but you see docker-compose.yml file still refers to docker files in sail package.

More of a feature request. Let's see how your PR goes.

@driesvints let me know if anything still needs to be done in PR. :)

Taylor will review it


sap.m.MessageToast is not accessible

OpenUI5 version: 1.26
Browser/version (+device/version): iOS 8/Safari on an iPad
URL (minimal example if possible): https://openui5.hana.ondemand.com/explored.html#/entity/sap.m.MessageToast/samples
Steps to reproduce the problem:

Launch the sample while using a screen reader
Press the button to display a slice of toast

What is the expected result? The screen reader should let the user know that something has just appeared on the screen and begin reading the contents. (For example, see http://www.w3.org/TR/wai-aria/states_and_properties#aria-live)
What happens instead? The toast is completely ignored by the screen reader
Any other information? (attach screenshot if possible)

Hi Ralph,
i will ask the colleagues if this control is accessible with release 1.28, it certainly is not with 1.26 but we improved a lot of accesibility features in 1.28 for sap.m
Cheers,
Michael

Hello Ralph, aria support for the sap.m.MessageToast is built with release 1.28 of UI5.
You can the unstable release available as a download on openui5.org/download.html to test it.
For Release 1.26 there will be no fix because this is a feature enhancement that is only avalable in newer releases.
Kind Regards,
Michael

Side-Note: Screenreader functionality was tested with JAWS 15 with IE10


:bug: Don't assume KubeadmControlPlane for nodeReuse

It's valid to use other controlplane.cluster.x-k8s.io controlplane provider resources, so remove the explicit check for Kind
We already check the Group  e.g controlplane.cluster.x-k8s.io which should be sufficient to ensure we're retrieving a controlplane resource name.
What this PR does / why we need it:
Fixes: #1310

@hardys 👋🏼 Thanks for the PR.
Some context on why only KCP was assumed: that is simply, we only used KCP everywhere as the ControlPlane provider (in all integration tests and other environments) since it is a de-facto control plane implementation used by CAPI and no other cp provider options were taken into the account by then. However, looking into the current proposed changes, I don't see any problems with it (not a breaking change, also probably not a bug 🐛 but rather 🌱 ) and it should give us more freedom of choice.
There are few other places we need to make changes (replacing KCP/KubeadmControlPlane mentions with something generic, i.e ControlPlane) to align the docs + e2e tests with the current change:

notes in the current repo: https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/docs/api.md#node-reuse-flow
the original proposal in the metal3-docs repo: https://github.com/metal3-io/metal3-docs/blob/main/design/cluster-api-provider-metal3/node_reuse.md
e2e tests we currently have, checks the feature logic with KCP which should be fine since we had to choose any CP provider to test it and that was KCP in the current e2e tests. I think it should be enough if we clarify that with something along the lines: "any other CP providers should also work in e2e, however, we are using KCP for testing node reuse feature in e2e" somewhere at the the top of node reuse e2e test description in https://github.com/metal3-io/cluster-api-provider-metal3/blob/73e3789d3a2c58b5ce16aeb1598ded4839ef6dea/test/e2e/pivoting_based_feature_test.go#L58

Additionally, let's run e2e tests on the PR to make sure we are not breaking the tests (@mboukhalfa or someone else can you please remind me what test trigger we are using to test the node reuse feature?)

Thanks for the review @furkatgofurov7 - I think I addressed all your comments 👍

Done - perhaps in future we can consider if there's any way to extend this coverage, but for now we know there will be downstream testing that covers this scenario (such as in the CI run by the Sylva community mentioned above)

+1 on extending the coverage and adding upstream tests with other CP provider(s).

Thank you very much for bringing this fix @hardys :+1:
As far as I can tell with my limited knowledge of Metal3, it looks good.

/test-centos-e2e-integration-main

test-centos-e2e-integration-main

looks like it was not triggered at all, I vaguely remember seeing CI problems in the provider channel recently which might be related. Let's try again:
/test-centos-e2e-integration-main

Additionally, let's run e2e tests on the PR to make sure we are not breaking them (@mboukhalfa or someone else can you please remind me what test trigger we are using to test the node reuse feature?)

Additionally, it should be:
/test-ubuntu-e2e-feature-main

Additionally, it should be:
test-ubuntu-e2e-feature-main

Looks like it did not trigger the tests at all, let's try again:
/test-ubuntu-e2e-feature-main

Unrelated to these changes package update error https://jenkins.nordix.org/job/metal3_capm3_main_e2e_feature_test_ubuntu/58/execution/node/70/log/
/test-ubuntu-e2e-feature-main

Alright, it is not a flake actually, but a wider issue discussed upstream, xref: https://github.com/containers/podman/issues/20690

Alright, it is not a flake actually, but a wider issue discussed upstream, xref: containers/podman#20690

This issue looks to be closed now so trying again
/test-ubuntu-e2e-feature-main

/test-ubuntu-e2e-feature-main

/test-ubuntu-e2e-feature-main

broken pipe issue
/test-ubuntu-e2e-feature-main

Mostly:
client_loop: send disconnect: Broken pipe failures and it is not reaching the node reuse tests to be run

/test-ubuntu-e2e-feature-main

We have a issue on our CI for long running tests. We are currently working on it.
Good job @hardys. LGTM

We have a issue on our CI for long running tests. We are currently working on the fix.
Good job @hardys. LGTM

How about parallel tests, I assume they should be shorter than normal e2e feature tests?
/parallel-test-ubuntu-e2e-feature-main

/parallel-test-ubuntu-e2e-feature-main

/test-ubuntu-e2e-feature-main

/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

Its a pity that the CI is still struggling with this broken pipe issue for so long. Lets try the luck one more time:

I'm not familiar with the details of that issue, is there somewhere I can track it and help collaborate on a fix?

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

Could I ask you @hardys to please sign off  the commits, we plan to enable DCO enforcement. (https://github.com/apps/dco)

Could I ask you @hardys to please sign off the commits, we plan to enable DCO enforcement. (https://github.com/apps/dco)

Sure, rebased and amended 👍

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

The ubuntu based feature test was very close to pass https://jenkins.nordix.org/job/metal3_capm3_main_e2e_feature_test_ubuntu/83/ , It received a broken pipe after the node reuse was performed and repivot was done and the cluster was in deleting state. That is the closest it has went, so I think this should be good to go. We can try one last time, but I will anyhow override centos test
/override test-centos-e2e-feature-main
/test-ubuntu-e2e-feature-main

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

In the last run node-reuse passed https://jenkins.nordix.org/job/metal3_capm3_main_e2e_feature_test_ubuntu/84/, so if we combine the last two runs, we can safely say feature test is passing.
I am not sure if I would call it a bug though, when it was implemented as a feature we assumed we would use KCP only for this feature. So, IMO we can also consider it as an extension to that feature.
/lgtm
/hold
cc @furkatgofurov7 @hardys
cc @

/override test-ubuntu-e2e-feature-main

Thanks a lot @kashifest 👍🏼

I am not sure if I would call it a bug though, when it was implemented as a feature we assumed we would use KCP only for this feature. So, IMO we can also consider it as an extension to that feature.

+1, @hardys what do you think?

Thanks a lot @kashifest 👍🏼

I am not sure if I would call it a bug though, when it was implemented as a feature we assumed we would use KCP only for this feature. So, IMO we can also consider it as an extension to that feature.

+1, @hardys what do you think?

From my perspective an infrastructure provider shouldn't really be coupled to a specific controlplane provider, but I'm certainly fine to retitle this if the consensus is to descibe it as an enhancement 👍

/retitle ✨ Don't assume KubeadmControlPlane for nodeReuse

/hold cancel


[5.5] Add Tests Demonstrating and Fixes for Error on Retrieving a User By Token With a Bad Identifier

This addresses the issue that @SebastianS90 pointed out and adds tests to demonstrate it.

Looks good to me, thanks!

How many more PRs do we need on this?

Always at least one more. 😱

It's just getting really wearisome. We've gone through about 4-5 Laravel patch releases with this simple fix.

I know. It's ridiculous. This one should end it. I've been throwing on tests with these last two pulls to block regressions from happening.


Expose ByteBufAllocator in ClientResources

To have more control over buffer allocation configuration, it would be
nice to include the option to choose what allocator to use.

Coverage decreased (-0.2%) to 92.658% when pulling 59d7add5f087d0ff3c3973940522882c32e6ac79 on jwils:expose-allocator into c8c59ba03a9289b0926fd164c66c2a3e003bd4ce on mp911de:master.

Coverage decreased (-0.2%) to 92.622% when pulling acbfc8120d255b42f6404c869123188ad6259778 on jwils:expose-allocator into c8c59ba03a9289b0926fd164c66c2a3e003bd4ce on mp911de:master.

Hi @jwils thanks for the PR. The code looks pretty decent. Could you help me understand your motivation for the change? Could this issue be solved by switching to ByteBufAllocator.DEFAULT?

If including netty from lettuce as a shaded jar it'll have to use a different PooledAllocator than other netty instance. The default allocator is configured to use up to 50% of memory so two or more instances can cause problem.
I can use the system properties to set each size if you want to minimize the parameters for ClientResources.

Having a solution outside ClientResources would be my preferred solution. Using the shaded jar comes with several drawbacks and imposes constraints on applications. Reuse of netty resources (allocators, event loops) is no longer possible.

Closing this PR for now.


pull request for e2e test at 11/14/2016 20:26:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Composant : 'Plateforme d'ordinateur virtuel' Error: 0x800f0819

Hello
I have this error when I use wsl --install after 70%

Open PowerShell as Administrator and run:
dism.exe /online /enable-feature /featurename:VirtualMachinePlatform /all /norestart

which may provide more information.
Although it's not the same error code, you may still need to check: Please enable the Virtual Machine Platform Windows feature and ensure virtualization is enabled in the BIOS

not work


Fix available clusters in cloudtest for interdomain

Signed-off-by: Artem Belov<EMAIL_ADDRESS>Description
Check that test has at least one available cluster in each required cluster group
Motivation and Context
https://circleci.com/gh/networkservicemesh/networkservicemesh/94351
There were not any available packet cluster but test was not skipped because available gke cluster
How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Merged, test failure are known in in progress.


Documentation

Coverage remained the same at 81.455% when pulling 70e2c9244a3c385a865befdcc39d4927570008e6 on develop into 1a9dc48ec4eb0d6912693aedfeecab45a9430e5f on master.


Preprocess Metadata Step Not Getting Data

The extract_metadata_sbs and extract_metadata_phenotype steps do not correctly extract metadata. When running these steps, my console has the following errors for all ND2 files:
Error processing data/input/sbs/P001_SBS_10x_C4_Wells-A1_Points-001__Channel_Cy7,Cy5,AF594,Cy3_SBS,DAPI_SBS.nd2: list index out of range
Error processing data/input/sbs/P001_SBS_10x_C4_Wells-A1_Points-100__Channel_Cy7,Cy5,AF594,Cy3_SBS,DAPI_SBS.nd2: list index out of range
No valid ND2 files found in the provided list.
Error processing data/input/sbs/P001_SBS_10x_C10_Wells-A1_Points-001__Channel_Cy7,Cy5,AF594,Cy3_SBS,DAPI_SBS.nd2: list index out of range
Error processing data/input/sbs/P001_SBS_10x_C10_Wells-A1_Points-100__Channel_Cy7,Cy5,AF594,Cy3_SBS,DAPI_SBS.nd2: list index out of range
No valid ND2 files found in the provided list.

The metadata tsvs that result from these rules (ex example_analysis/analysis_root/preprocess/metadata/sbs/WA1_C1__metadata.tsv) are completely empty.
This seems to be a result of #9 as reverting these changes solves the issue.
@mat10d are you able to reproduce this issue on your machine? Maybe this is a problem specific to my setup.

Check if this resolves this, and close if it does. Sorry for the headache.

Fixed in #15 !


Please tell me how to use fastgltf/0.5.0 with FASTGLTF_DOWNLOAD_SIMDJSON=ON.

I met a compilation error on fastgltf/0.5.0 with FASTGLTF_DOWNLOAD_SIMDJSON=ON.
It works well on fastgltf/0.4.0.
I think this error is due to following commit:
https://github.com/spnda/fastgltf/commit/41f1793d848297fa6aa480402a9ec7e68a96a712
How to use fastgltf/0.5.0 with FASTGLTF_DOWNLOAD_SIMDJSON=ON?
Is it needed to prepare CMakeLists.txt wrapper?

FASTGLTF_DOWNLOAD_SIMDJSON is ON by default, and therefore should work. The relevant change doesn't change anything about the download functionality.
Are you perhaps referring to setting it to OFF, so that you can supply a custom version of simdjson? If so, you'll just need to make a simdjson::simdjson target available before including fastgltf.

@spnda
Sorry, it's my mistake.
I met a compilation error on fastgltf/0.5.0 with FASTGLTF_DOWNLOAD_SIMDJSON=OFF.
Error messages is followings:
src/base64.cpp:46:10: fatal error: simdjson.h: No such file or directory
   46 | #include "simdjson.h"
      |          ^~~~~~~~~~~~

Is that all? Then your simdjson::simdjson target is missing the include directory. Can you show how that target is configured?

Even though there was no response, this issue has long been fixed in your case with conan (see conan-io/conan-center-index#18301). Furthermore, with the recent commit https://github.com/spnda/fastgltf/commit/3dd326efb089f66ca393a9cc68d07df42ba82fbd the code to link to simdjson has been refactored and now also covers the case you were having an issue with. The patch used with conan is now unnecessary.


bring back age property of RtSampleContainer like in v1.1.x

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the changelog accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

no changelog entry needed in my opinion.


Update PostgreSql.php

use posgresql > 9.5 connection string

As someone who doesn't use PostgreSQL: Is this the preferred way to connect with a Postgres database?