Small code refactoring

@afdw please take a look at this.

Taking advantage that PR is for refactoring, can we change the error message in NullArchive? For something like: The file structure is null, fail to create or something similar to the NullEntry.
I think the current message is a little confusing.


No such file or directory @ dir_chdir - /usr/local/Cellar

What?

I don't know what you're having problems with, but it's not rbenv.


Add CI and vendor deps

Why vendor the reps; I think this is only a library repository, and not producing binaries, correct?

(still a bit on the fence on https://github.com/docker/go-metrics/pull/24, as it now makes any dependency REQUIRE to update to the latest version, even though this library may work fine on older versions - minimum requirement selection in go mod were basically designed about the reverse (pick the minimum version you need; consumers may pick a more current version if desired)

Why vendor the deps; I think this is only a library repository, and not producing binaries, correct?

I think it's just a habit. I see no harm in doing that plus the number of deps is low. Can revert, but imo, no harm

It'll definitely make things slower when using GOPROXY=direct

(still a bit on the fence on https://github.com/docker/go-metrics/pull/24, as it now makes any dependency REQUIRE to update to the latest version, even though this library may work fine on older versions - minimum requirement selection in go mod were basically designed about the reverse (pick the minimum version you need; consumers may pick a more current version if desired)

we have to move on from this. If people scream, we can do something about it., but we can't maintain b/w comp to go 1.11. Onwards we go.

but can you explain why this library itself needs an updated version?

plus the number of deps is low.

I don't consider this "low" btw

but can you explain why this library itself needs an updated version?

you mean why we are doing this? yeah, distribution depends on this and it's using half-broken prometheus package causing all kinds of shenanigans

I don't consider this "low" btw

yeah as I said I'm not hell-bent on vendoring here :D

Distribution can use a more current version? (just update go.mod and it picks a newer version)

Distribution can use a more current version? (just update go.mod and it picks a newer version)

prometheus is a transtitive dependency via this module. distirbution depends on go-metrics

But there's no local changes, only go.mod update; updating the go mod in distribution does exactly the same? https://github.com/distribution/distribution/compare/main...thaJeztah:update_deps?expand=1

But there's no local changes, only go.mod update; updating the go mod in distribution does exactly the same? https://github.com/distribution/distribution/compare/main...thaJeztah:update_deps?expand=1

But there's no local changes, only go.mod update; updating the go mod in distribution does exactly the same?

Hmm, interesting! Given I've no way of force-push perms I shall close this PR either way, but when I tried this my go.mod-fu failed me. I've tried this now again and everything seems ok!


feature: We should support deploying curve client on baremetal host without docker

Few users may be unlike to deploy curve client with docker, we should handle this problem.
And if we deploy client for openstack or k8s csi, the client deployment with docker cannot be used by them.

This tool may be a good choice: https://github.com/megastep/makeself

Another way, may be we can build some docker images, which can be used for building deb, rpm package.


Edge case bug in VXCao_empty_blocks_cider

I think that there is an edge case bug in the empty block screening routine for numerical integration of the XC kernel, but I am having trouble finding an edge case where it causes numerically significant issues.
Starting on line 43 of nr_numint.c (https://github.com/pyscf/pyscf/blob/50c6918f77d10692fcd1aa8e95f9eb89fb4236aa/pyscf/lib/dft/nr_numint.c#L43), the following changes should be made:
for (bas_id = sh0; bas_id < sh1; bas_id++) {
        empty[box_id] &= !non0table[bas_id];
        if (ao_loc[bas_id] == bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = 1;
        } else if (ao_loc[bas_id] > bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = !non0table[bas_id];
        }
}

should be
for (bas_id = sh0; bas_id < sh1; bas_id++) {
        if (ao_loc[bas_id] == bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = 1;
        }
        empty[box_id] &= !non0table[bas_id];
        if (ao_loc[bas_id+1] > bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = !non0table[bas_id];
        }
}

The reason for these changes is that if ao_loc[bas_id] is equal to bound, its orbitals contribute to empty[box_id+1], not empty[box_id], so the box_id should be incremented before handling bas_id. If ao_loc[bas_id+1] is greater than bound, then the orbitals at ao_loc[bas_id] contribute to both empty[box_id] and empty[box_id+1], so it is necessary to check ao_loc[bas_id+1] > bound rather than ao_loc[bas_id] > bound in the second if statement.
Unfortunately, I found this bug while writing some custom code that uses PySCF's VXCao_empty_blocks function, and I have not found an example using just PySCF that runs into the edge cases where this bug causes significant problems. Does anyone have suggestions for reproducing this issue using the main code? If so, I can draw up some tests and make a PR for the changes.

For small systems,  dgemm between the matrices are called. The bug never be noticed in these small tests.
The check for boundary of ao_loc and bound should be carried out between next basis and bound. IMO, the fix as below is more clear
for (bas_id = sh0; bas_id < sh1; bas_id++) {
        empty[box_id] &= !non0table[bas_id];
        if (ao_loc[bas_id+1] == bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = 1;
        } else if (ao_loc[bas_id+1] > bound) {
                has0 |= empty[box_id];
                box_id++;
                bound += BOXSIZE;
                empty[box_id] = !non0table[bas_id];
        }
}

I don't think that version will work. If nao % BOXSIZE == 0, then for the last iteration of the for loop,
bas_id = sh1-1
box_id = nbox - 1
bound = nao = ao_loc[bas_id+1] = ao_loc[sh1]

Therefore, the first conditional will be true, resulting in box_id being incremented to nbox and the invalid write empty[nbox] = 1 being performed. If the check is performed for ao_loc[bas_id] before calling empty[box_id] &= !non0table[bas_id];, then this issue will not occur.

Fixed by #1274


Impl service upon moka

@ClSlaid Oh, I didn't see your self-assgined...

It's ok, I just began on this.
Now I should try to continue porting it as a cache layer I think.

Now I should try to continue porting it as a cache layer I think.

Does it mean that we only need
let _ = Operator::from_env(Scheme::Fs)
    .expect("must init")
    .layer(ContentCacheLayer::new(
        moka::Builder::default().build().expect("must init"),
    ));


Term code delete button is not inline

Private Zenhub Image

Button is in line. Other items just don't have a title.


[webview_flutter] Gestures stop working

Steps to Reproduce

clone 'https://github.com/ponytony/flutter-webview-demo', switch to demo branch.
run the project
open an flutter application on ios simulator(ios version is 13.4.1), the flutter page have an webview component which url is 'localhost:8080'
touch the 'test' button
select a time
click cancel
Repeat the above actions about ten times

Actual results: No click or touch event be triggered,but dom's click method can be call.
why I submit the issue:

the bug is occur on ios 13.4.1
another component also occur the bug
no console log;
run the page on safari is correct

flutter doctor
[✓] Flutter (Channel unknown, v1.12.13+hotfix.5, on Mac OS X 10.15.4 19E287, locale zh-Hans-CN)
    • Flutter version 1.12.13+hotfix.5 at /Users/wengu/Desktop/flutter
    • Framework revision 27321ebbad (5 months ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/wengu/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/wengu/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 39.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] Connected device (1 available)
    • iPhone SE (2nd generation) • 0BC83A31-1F55-4E79-8E9F-860C78FCD113 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

• No issues found!

flutter analyze:
no issue found

Hi @ponytony
I can't see any logs on clicks in the console where I run npm run serve.
Does your issue persist with current dev channel 1.19.0-0.0.pre or current stable 1.17.0, what webview_flutter are you using?

Hi @ponytony
I can't see any logs in the console where I run npm run serve, when I click in browser as well.
Does your issue persist with current dev channel 1.19.0-0.0.pre or current stable 1.17.0, what webview_flutter are you using?

I also dont see any log in the console.the channel is stable chennel v1.12.13+hotfix.5, and the webview flutter is official plugin.

Hi @ponytony
I can't see any logs in the console where I run npm run serve, when I click in browser as well.
Does your issue persist with current dev channel 1.19.0-0.0.pre or current stable 1.17.0, what webview_flutter are you using?

you can see the 'Steps to Reproduce', step 4,5,6 is important

@ponytony

webview flutter is official plugin.

Oops, I missed the word version in my question.

No click or touch event be triggered

what events are you expecting to have triggered?

run the page on safari is correct

what is the difference with running in flutter app in webview?

@ponytony

webview flutter is official plugin.

Oops, I missed the word version in my question.

No click or touch event be triggered

what events are you expecting to have triggered?

run the page on safari is correct

what is the difference with running in flutter app in webview?

version of webview_flutter is 0.3.13.ummm, i want to trigger any event, but the page looks like be locked when the bug happen, i cannot do anything；

@ponytony
try with the last version of webview_flutter 0.3.21.
It's still not clear to me what is the difference between running in browser and in flutter app with webview

@ponytony
try with the last version of webview_flutter 0.3.21.
It's still not clear to me what is the difference between running in browser and in flutter app with webview

I've upload video to github, repo is https://github.com/ponytony/flutter-webview-demo', branch is demo

The freeze reproduces with webview on iOS (not with Android), but doesn't reproduce when opening the site in mobile browser. Tried the last version webview_flutter: ^0.3.22+1.
@ponytony For future, to avoid downloading your repository and running it locally by other people to reproduce would be better if you deploy your site and provide a code sample containing WebView with the link on the site

flutter doctor -v
[✓] Flutter (Channel dev, 1.19.0-1.0.pre, on Mac OS X 10.15.4 19E287, locale en-GB)
    • Flutter version 1.19.0-1.0.pre at /Users/nevercode/dev/flutter_dev
    • Framework revision 456d80b9dd (11 days ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (6 available)
    • Redmi Note 7       • 6345c469                                 • android-arm64  • Android 9 (API 28)
    • Nevercode’s iPhone • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.5
    • iPhone 11 Pro Max  • 9F9AFD9B-7F22-468E-8096-B47E993E0619     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS              • macOS                                    • darwin-x64     • Mac OS X 10.15.4 19E287
    • Web Server         • web-server                               • web-javascript • Flutter Tools
    • Chrome             • chrome                                   • web-javascript • Google Chrome 83.0.4103.61

• No issues found!

Related to https://github.com/flutter/flutter/issues/53490. Follow up on it and check your issue once the mentioned is fixed

Hi! I might have some details here. It's related to video i my case but I suspect the cause might be the same.
TL;DR: I think the mechanism flutter uses to track touches in platform views does not receive all touch events causing its state to lose sync with reality and ends up blocking further touches.
We have modified webiew_flutter to add WKWebViewConfiguration.allowsInlineMediaPlayback = true for inline video support and get this issue frequently.
I created a sample flutter project that just opens a youtube video in the modified WebView and can there reproduce this issue very easily by, after starting the video, simply tapping the time slider thumb once, then tapping anywhere else on the inlined video. After this no further taps are registered for the WebView.
I have so far seen the following effects which I suspect may be related:
Creating a normal xcode ios sample project and attaching a gesture recogniser to the WKWebView one can see that tapping the video time slider thumb results in a call to touchesBegan but not touchesEnded.
After reaching the faulty state while debugging the flutter project in xcode, one can find the reference to the FlutterTouchInterceptingView that flutter uses to intercept touches via gesture recognisers; DelayingGestureRecognizer and ForwardingGestureRecognizer. Inspecting the ForwardingGestureRecognizer._currentTouchPointersCount value reveals that it is stuck at 1 while it should be 0, and thus the recogniser is in an unexpected state.
Calling [ForwardingGestureRecognizer touchesCancelled:nil withEvent:nil] from the debugger restores the ForwardingGestureRecognizer to the proper state and the webview receives touches again.
For details on how flutter handles (and blocks) touches see
https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm#L892
I haven't been able to run @ponytony's example but if you would like to confirm the state of the gesture recogniser you can stop the debugger and run this little line in gdb (mine was stuck in objc mode at the time. Probably only works reliably in a simple project)
po [[[[UIApplication.sharedApplication.keyWindow.rootViewController.view.subviews valueForKeyPath<EMAIL_ADDRESS>filteredArrayUsingPredicate: [NSPredicate predicateWithBlock: ^BOOL(id item, id b){ return (BOOL)[item isKindOfClass: [ForwardingGestureRecognizer class]];}]] firstObject] valueForKey:@"_currentTouchPointersCount"]

Here's a hack workaround that works for us. Hope this helps
https://gist.github.com/Voxar/5dbef0b76cc8cb55d2fe74a492d41c54

Hi @ponytony  @Voxar
The project provided no longer works, can you a new reproducible code or simpler way of reproducing this which doesn't require nodejs.
Thank you

Hi @ponytony  @Voxar
The project provided no longer works, can you a new reproducible code or simpler way of reproducing this which doesn't require nodejs.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


How to get De-Duplicated OpenIE (Clause Extraction) Results?

I've exhausted all the configuration options I'm aware of:
from openie import StanfordOpenIE

# https://stanfordnlp.github.io/CoreNLP/openie.html#api
# Default value of openie.affinity_probability_cap was 1/3.
properties = {
    "annotators":"tokenize,ssplit,pos,depparse,natlog,openie",
    'openie.affinity_probability_cap': 2 / 3,
    "openie.triple.strict":"true",
    'openie.max_entailments_per_clause': 1,
    'splitter.disable': True
}

with StanfordOpenIE(properties=properties) as client:
    text = 'Barack Obama was born in Hawaii. Richard Manning wrote this sentence.'
    print('Text: %s.' % text)
    for triple in client.annotate(text): #, max_entailments_per_clause=True):
        print('|-', triple)

But the results still contain non-merged duplicating variations:
|- {'subject': 'Barack Obama', 'relation': 'was', 'object': 'born'}
|- {'subject': 'Barack Obama', 'relation': 'was born in', 'object': 'Hawaii'}

Whereas I'm only looking for the maximal clause extraction results:
|- {'subject': 'Barack Obama', 'relation': 'was born in', 'object': 'Hawaii'}
Can someone help me out on this please?

Hey,
I had the same problem and this is what I did:

https://philipperemy.github.io/information-extract/
https://github.com/philipperemy/information-extraction-with-dominating-rules

It's not perfect but it can lay groundwork for you.

Interesting, thanks for sharing!


CleanRL example bug?

Hi all,
Getting started with the rlexplore_with_cleanrl.py example and I think there's an important typo, introduced here (line 254).
The first block, which overwrites next_obs as returned by the environment, shouldn't be there. It's throwing a shape error because line 256 is trying to put an array of shape (128, 8, 4, 84, 84) into a slot of shape (8, 4, 84, 84).
"real_next_obs" is the one that's used, and that one looks right, except that the next_obs referenced there should be the environment's next_obs, not the one modified above.
Thanks!
Sam

Hi Sam, I just updated the code and marked u as a co-author; see if it works now. Thanks!

Sorry for the late response -- success! Works now, thanks.


@JsonIdentityInfo doesn't work

Referencing: https://github.com/swagger-api/swagger-core/issues/1447
Hi I have a many to many relation between to entities (Actors & Movies). To make sure I don't get infinite JSON's I used some jackson annotations.
The actor class:
@Entity
@JsonIdentityInfo(generator = ObjectIdGenerators.PropertyGenerator.class, resolver= ActorIdResolver.class, property = "id")
public class Actor extends Identifiable{
    private String firstname;
    private String lastname;
    private Integer yearOfBirth;
    private String imageLink;
    @ManyToMany(mappedBy = "actors")
    @JsonIdentityReference(alwaysAsId = true)
    private Set<Movie> movies;`
}

The Movie class:
@Entity
@JsonIdentityInfo(generator = ObjectIdGenerators.PropertyGenerator.class, resolver=MovieIdResolver.class,property = "id")
public class Movie extends Identifiable{
    private String title;
    private int releaseYear;
    private String imageLink;
    @ManyToMany
      @JoinTable(
      name="MOVIE_ACTOR",
      joinColumns=@JoinColumn(name="MOV_ID", referencedColumnName="ID"),
      inverseJoinColumns=@JoinColumn(name="ACT_ID", referencedColumnName="ID"))
    @JsonIdentityReference(alwaysAsId = true)
    private Set<Actor> actors;

But still i get in Swagger for the actor object (same for the movie):
    {
        "firstname": "string",
        "id": 0,
        "imageLink": "string",
        "lastname": "string",
        "movies": [
          {
            "actors": [
              {}
            ],
            "averageAgeActors": 0,
            "id": 0,
            "imageLink": "string",
            "releaseYear": 0,
            "title": "string"
          }
        ],
        "yearOfBirth": 0
    }

Should I use some other annotations or is it a bug/enhancement?

Well if you look at it, your model is infinite :) @JsonIdentityReference isn't supported explicitly, but it really is o/w your model wouldn't have rendered without causing a stack overflow.
Not sure what the right way to address this as it seems to have intimate knowledge about serialization, resolution and generators.
@JsonIdentityInfo(generator = ObjectIdGenerators.PropertyGenerator.class, resolver= ActorIdResolver.class, property = "id")
Going to mark this as a someday feature as its really too much of a one-off for me to invest time in. Would definitely love it if you could perhaps try your hand at a PR.


exif will disappear after editing

Hello, I used the intervention to edit the image, such as clipping, adding watermark, etc., but after doing these operations, I found that the gps information in the exif will disappear. Is there any way to support the retention of gps information after editing? In addition, currently only the function of reading exif is provided, is it considered to support writing exif?
Thanks.

I am also interesting in this issue. After picture resize exif data disappears. I need to keep at least exif('ImageDescription')


Uploading Bootloader Image Breaks Image Tab UI

I uploaded a bootloader image for my new sub architecture grub-efi-upstream-2.02.
Since doing this the "Only show my images" switch breaks the MrP UI and the images tab no longer displays anything other than spinning icon.
Once entered into this state no other tab works.
I have also see the archtectures tab appear/dissapear but cannot currently find a reproducer for that.

Also because UI is broken now I cannot logout and need to use new browser (or I guess clear cookies).


Internal file system kept getting corrupted

Everytime I try to use the internal file system, it seems to get corrupted. It briefly work after using the "format" command, but then, it stopped working properly. Here what the ls command output when the FS is corrupted:

@TwistedSim - could you provide some of the following information to help triage?

Hardware Version (8 / 10) ?
Software Version or git tag?
Host operating system and version?
Steps to reproduce?

Thanks!

Hello!

Bus Pirate 5 REV10
Firmware main branch (2024-06-09T09:54:04Z) [929d4c5…967019d]
Ubuntu 20.04 LTS
It keeps happening randomly, so it's hard to pin point precise steps. I was mostly using the SPI module (flash init, read, write) and sending manual command (e.g. [0x03 ... ]).

might be related:


Update etcdadm-controller to v1.0.6-rc3

Issue #, if available:
Description of changes:
Upgrading the etcdadm-controller to fix a security issue https://github.com/aws/etcdadm-controller/pull/29
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Implement constructor type guard

Fixes #23274
tl;dr: Implements constructor check type guards in the form of x.constructor === T.

This PR adds a new constructor equality check type guard. It specifically works on a set of binary expressions in the following syntactic forms:

x.constructor === T
x.constructor == T
x["constructor"] === T
x["constructor"] == T

Narrowing is done via the added narrowTypeByConstructor function. This type  guard only operates on == and === so if it finds the expression is using a  not-equals operator then it returns the type without any narrowing done.
After that it uses isMatchingReference to presumably check that we are still referring to the x part of the x.constructor === T expression. I'm not certain on how this works exactly, but the use case is to ensure only x has the narrowed type in the if body as opposed to x.y having the narrowed type.
Once that check is complete it moves on to getting the type referred to by T. This type eventually turns into our candidate type if it is not a direct reference to the globalObjectType or globalFunctionType. This does introduce a shortcoming of the narrowing as it prevents narrowing using a T of Object  or Function.
If the type that is being narrowed is any, then it can assume the candidate type is a subtype of any and so we just narrow directly to candidate. I  think this is a safe assumption but maybe not? Also there is no need to check for unknown as you would receive an error attempting to access x.constructor if x's type is unknown.
Finally it returns the result of the filterType function which uses a function isConstructedBy to do the filtering. If none of the types match we end up with never as the flow type.
isConstructedBy
This function checks if either the source or target type are Object types with the Class ObjectFlag. If this is the case then we return if the symbols of source and target type are ===. This is needed because you may have two classes with the same structure and TypeScript will see them as the same type. There was no way I could find that would check this. I think this also introduces the side effect of having pseudo nominal typing in the language.
For all other cases it just checks that the source type is a subtype of target type.
Caveats and questions

Does not narrow when using a T of Object or Function.
Is comparing the symbols of source and target types a good way to check that they are referring to the exact same class?

@weswigham this LGTM - please merge if you agree

Addressed @weswigham's comments.

Looks like some tests are failing - you may need to run --skipPercent=0 to prevent the test from being skipped in a test run locally.

Ah ok, I forgot to rebase onto master. Looks like some symbol positions changed.

So, showerthought here, but.... What do we do when
const x = { constructor: String };
if (x.constructor === String) {
    x.trim(); // runtime error
}

Or any other instance where the constructor property isn't inherited from Object or Function? I think we need to validate that the constructor property accessed comes from one of the built-in apparent types for this narrowing to be safe to do.

@weswigham, just tried it out with my local build and it looks like that
specific case won't be an issue. x will have a type of never inside the
if so you will get a compile time error. This is because we aren't
comparing against the type of x's constructor, but rather against the
type of x, and the prototype type of the identifier right of the
triple-equals directly.
I haven't thought of a case yet where this will break but I'll definitely
keep thinking about it.
On August 19, 2019 3:11:36 AM Wesley Wigham<EMAIL_ADDRESS>wrote:

So, showerthought here, but.... What do we do when
const x = { constructor: String };
if (x.constructor === String) { x.trim(); // runtime error
}
Or any other instance where the constructor property isn't inherited from
Object or Function? I think we need to validate that the constructor
property accessed comes from one of the built-in apparent types for this
narrowing to be safe to do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I came here to request this feature, as I'm doing .constructor types extensively in my project, so this is great! Can't wait for this to make it in!

I came here to request this feature, as I'm doing .constructor type checks extensively in my project (but TypeScript still needs type assertions), so this is great! Can't wait for this to make it in!

Same here, this is really an awesome feature and glad the author and the Typescript team going to support it :cake:

Is this slated to be released soon?

@darsain

I worked once in a weird environment (I think an nw.js app) where my element objects were defined in a different context than globally available constructors, so stuff like
actualInputElement instanceof HTMLInputElement
would always return false.

I had a similar situation inside an HTMLObjectElement. I think
actualInputElement instanceof actualInputElement.ownerDocument.defaultView.HTMLInputElement
is a saver runtime check, but no TS check either.


Configurable options in deploy.sh for verify-maas playbook

This change introduces two new environment variables that control the
behavior of the verify-maas playbook: VERIFY_MAAS, and VERIFY_MAAS_DELAY.
VERIFY_MAAS (default 'yes') will control if the verify-maas playbook should
be run, and VERIFY_MAAS_DELAY (default '30') controls the sleep value before
the verify-maas playbook is run.
Fixes #621

VERIFY_MAAS seems like a reasonable addition but I'm not sure what benefit VERIFY_MAAS_DELAY provides. VERIFY_MAAS_DELAY can only be set before the deploy script runs so, under what circumstances would that variable be changed on a one-off basis? How does one determine, ahead of time, that VERIFY_MAAS_DELAY should be increased?

To be honest, adding VERIFY_MAAS_DELAY was for my own needs, where I can set it to something that works for my automated testing, because I know that 30 seconds is not enough time.
We already agree that 30 seconds is arbitrary. We could just set it to an absurdly large arbitrary value, knowing we're probably wasting time, but also knowing that it will work most if not all of the time. But the mere fact that a sleep exists between those two playbooks signifies a much deeper problem. This was just a quick fix, with the least amount of churn. Maybe this is a case where successerator might make a return.
Either way, having VERIFY_MAAS_DELAY default to the same value as the non-configurable value has no discernible difference if you don't care to fiddle with these bits.

I don't mind that VERIFY_MAAS_DELAY is configurable, but perhaps a comment indicating what it does or a link to the issue number would be beneficial.

@d34dh0r53 Inline comment, or something somewhere else, like rpcdocs? I could add something to README.md about all the environment variables that deploy.sh uses. What that be beneficial, and suffice?

@byronmccollum I was just thinking an inline comment, but a section in the readme would be awesome!

Added docs in README.md

I hope #719 will make verify-maas reliable enough that these switches are not needed. The sleep has been removed so at least one isn't needed.

Yup...Opening a new PR for the updated README.md document deploy.sh env vars.


Update github actions to jdk17

@ricardozanini could you take a look?

@hbelmiro could you take a look?

@hbelmiro we had a problem with Quarkus 3 integration branch. It seems fixed, but Quarkus is moving on, we should also. wdyt?

@hbelmiro my intention was just to fix the build, but maybe we need to change <maven.compiler.target> in pom.xml too. I think the Quarkus 3 integration also needs this jdk update to 17. Wdyt?

That's totally fine for me to upgrade to 17. Just the intention of the PR that was not clear to me.

@hbelmiro my intention was just to fix the build, but maybe we need to change <maven.compiler.target> in pom.xml too. I think the Quarkus 3 integration also needs this jdk update to 17. Wdyt?
And about "we should also update other GH Actions".. which ones? (I only find the ref in this two workflows)

Yeah, you're right @nmirasch. I thought there were more GH Actions to update, but there aren't. Just pom.xml.

@ricardozanini will we drop support to quarkus 2 here and in https://github.com/quarkiverse/quarkus-reactive-messaging-http too?

@ricardozanini will we drop support for quarkus 2 here and in https://github.com/quarkiverse/quarkus-reactive-messaging-http too?

Let's do it!


src-mpi/yamlOutput.c no error checking or read-only functionality

When attempting to run mpirun -np 1 bin/CoMD-mpi in a read-only (container) environment, the program segfaults.
After debugging in GDB I was able to trace the segfault to yamlOutput.c where I read your comment and learned that this behavior is intended.
It is rather disappointing to learn that I will not be able to run CoMD in its current state. If I get the time during the school year this fall, I will fork it and get creative. In the meantime, I'd like to suggest adding some form of error checking to the file I/O in yamlOutput.c, specifically at line 60:
yamlFile = fopen(filename, "w");
This will save others (with read-only container environments) some time when debugging a seemingly random segfault from mpirun.

The purpose of the code in yamlOutput.c is to write information about the system on which the code was built and how it was built and run for provenance purposes as CoMD is a proxy app and is expected to have regular changes to compilation configuration and even the code.
I definitely agree we probably should have wrapped that, but CoMD is more of a workhorse proxy app intended for experimentation and less a demonstration of proper software engineering. And this is data that we want saved and easily referenced anyway, so the wrapper will still exit with an  error if the file open failed (but a more intuitive error).
I am not sure what you expect to get out of running CoMD in a readonly container, but a quick google yields this resource which may be of use to you http://www.projectatomic.io/blog/2015/12/making-docker-images-write-only-in-production/
I would recommend getting into the habit of doing that anyway as readonly containers are good from a security perspective, but not so much for scientific computing (or approximations thereof) that actually write outputs.
But yes, the point of CoMD is for people to fork it and "get creative" whether that creativity is in studying new approaches on a manageable code or finding ways to improve performance of MD applications. So we strongly encourage that and you definitely have the right idea. Here is hoping you can find time in your schedule to do some research.

Closing for personal active issue tab tidiness.


Updated skipHide property to multiple

Dear Joseph,
thank you for creating this awesome date time picker. I am suggesting a change on the mdDialog. I suggest to replace the skipHide option with multiple which is the new option name on AngularJs material 1.1.12 that allows to show multiple dialogs at the same time..
Thank you!

Duplicate of #103


Verify using IPv4 addresess when IPv6 isn't available logic for Armeria's DNS resolvers work

I had a report that after upgrading Armeria, requests started to fail with for example com.linecorp.armeria.client.UnprocessedRequestException: io.netty.channel.AbstractChannel$AnnotatedNoRouteToHostException: null: cloudtrace.googleapis.com/2404:6800:4004:80a:0:0:0:200a:443, scheme=gproto+https, headers=[:method=UNKNOWN, :path=?, :scheme=https, :authority=?], content=DefaultRpcRequest{serviceType=GrpcLogUtil, method=google.devtools.cloudtrace.v2.TraceService/BatchWriteSpans
https://github.com/netty/netty/pull/9048 was added to Netty to fix things like this but there may be a regression after Armeria forked the DNS resolver. Haven't investigated anything though.
/cc @danada

RefreshingAddressResolverGroup follows this logic: https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/client/RefreshingAddressResolverGroup.java#L66-L81

Thanks for this.
To add some background, the server is running on Google Cloud and the problems go away after adding -Djava.net.preferIPv4Stack=true to jvm args.

Can we get the ip link and ip addr output (with some values masked)?

Oops, we don't have that condition here. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/client/endpoint/dns/DnsAddressEndpointGroup.java#L108

@danada What are the before and after versions of Armeria where you see the issue?

Ah, So This is happened after upgrading Armeria, right?

We went from 0.95.0 to 0.97.0. I will try to get ip link and ip addr outputs tomorrow morning!

Sorry for the delay, here's the output (don't mind the busybox aliases):
$ iplink
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
3: eth0@if18692: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1460 qdisc noqueue
    link/ether 1a:5e:1f:bf:26:6f brd ff:ff:ff:ff:ff:ff

$ ipaddr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
3: eth0@if18692: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1460 qdisc noqueue
    link/ether 1a:5e:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
    inet 10.xxx.xxx.xxx/24 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::xxxx:xxxx:xxxx:xxxx/64 scope link
       valid_lft forever preferred_lft forever

The IPv6 starts with fe80 so it's link local and not a real address (similar to 169.blah on IPv4). Didn't look at the code yet but I suspect both our check in Netty and here are only checking if address is loopback, but not checking for link local / site local which aren't routable to the web

The IPv6 starts with fe80 so it's link local and not a real address (similar to 169.blah on IPv4).

Perhaps netty takes care of that but RefreshingDnsResolver doesn't? 😅
Let me take a look at the code if there's something I missed.

Also for reference, the client being referenced in that stack trace, cloudtrace.googleapis.com does not use an endpoint group, just a normal endpoint.
https://github.com/curioswitch/curiostack/blob/master/common/google-cloud/core/src/main/java/org/curioswitch/curiostack/gcloud/core/grpc/GrpcApiClientBuilder.java#L52

@danada Is this always happening? or It differs every time the application started? (e.g It keeps throwing exceptions and it does not throw an exception at all after reboot so on.)

It throws exceptions when trying to write spans to cloudtrace when processing a request. If no requests are processed no errors are thrown. The application has been restarted several times and produced the exception every time.

Thanks for the information. 😉

Hopefully fixed via #2464. Please reopen if the problem shows up again.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44002

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44798


Getting error while using the library

ERROR in ./node_modules/technical-indicators/src/core/indicators.ts 10:46
Module parse failed: Unexpected token (10:46)
File was processed with these loaders:

./node_modules/source-map-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
| 	 * @returns
| 	 */

async normalize(originalLength: number, source: Array | string, empty = NaN): Promise<Array> {
| 	const diff = originalLength - source.length
|
Getting this error when i used your library in my react.js project.
Already tried every solution mentioned here
https://stackoverflow.com/questions/63423384/you-may-need-an-additional-loader-to-handle-the-result-of-these-loaders.
could not get out of the issue.
It could be very helpful for me if you solve this error.
If i comment the errored code. i will get error at other code lines

@Nishanth-Besseggen Hey,
i've just installed React and here is my code
App.js
import { IndicatorsNormalized } from "../node_modules/@ixjb94/indicators/dist/indicators-browser"

const closes = [1, 2, 3, 4, 5]
const ta = new IndicatorsNormalized()
ta.ema(closes, 2).then(d => console.log(d))

function App() {
  return (
Hello World
)
}

export default App

Result in browser:
[1, 1.6666666666666665, 2.5555555555555554, 3.518518518518518, 4.506172839506172]


Invitation

This is an optional feature I may use it for hackathon registration.
Summary
The problem of the current blockparty is that it only knows the twitter account of each participant, and capturing more info (full name, email, skill sets of participants, etc) through dapp is either hard or not necessary. The workaround is to ask these questions prior to the event via external service (eg: google form) then issue invitation code specific to a user. When the user register with the invitation, it will update the user's public address to InvitationRepository  so that you can later join participants info on the smart contract with off chain data without storing additional information into the main contract Conference.sol.
Added features.

Add babel-preset-latest to enable async/await
Add InvitationRepository
Add RegisterWithInvitation
Show invitation field when register with invitation
Add invitation.js to be able to add invitation codes into the repository

Feedback welcome @jefflau @adamdossa @hacktar

Sounds interesting - a somewhat related project I've been working on is being able to tie a persons reddit username to their blockchain address using Oraclize:
https://github.com/RedditRegistereth/RedditRegistry
BTW - I was at your talk at last weeks Ethereum meetup - very interesting - I am going to try and come to one of your code based meetups soon!


Add expand_nested_docs Parameter support to NMSLIB engine

Description
Add support for the expand_nested_docs parameter in the nmslib engine. As nmslib does not support multi-vector functionality, this feature may have limited usefulness but poses no downside to including it.
Related Issues
N/A
Check List

[X] New functionality includes testing.
[] New functionality has been documented.
[ ] API changes companion pull request created.
[X] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

As nmslib does not support multi-vector functionality, this feature may have limited usefulness but poses no downside to including it.

Can you explain a bit more on this?

As nmslib does not support multi-vector functionality, this feature may have limited usefulness but poses no downside to including it.

Can you explain a bit more on this?

For nmslib, searches are performed at the nested document level without deduplicating per parent documents As a result, multiple inner hits can occur as long as the nested documents belong to the top-K results. In this context, the demand for this functionality may be lower compared to other engines.
For instance, consider an extreme scenario where there are two documents, each containing 10 nested documents. If a query is executed with k=5, it is possible that all five closest vectors come from just one of the two documents. In this case, expanding nested documents would include five additional nested documents with scores lower than the minimum score of the already retrieved nested documents.

Please add/update the IT of expand nested docs variable for nmslib engine too.

Added.


Use HTTPS for rubygems.org

Hi.
Is there any reason not to use HTTPS for RubyGems? Apologies if you have a specific reason.
All the best,
O-I

No good reason, thanks.


math/cmplx: TestAtan and friends failing on several platforms

These tests started failing on several platforms as of https://go-review.googlesource.com/c/go/+/169501.
The following platforms are definitely failing:

linux-s390x: https://build.golang.org/log/17bb5d8c71826a7bc7b7b2589ac5dc34049949ac
linux-mips: https://build.golang.org/log/12e67c4d1626dac693c081fb1f6db31d27453e64
linux-mips64: https://build.golang.org/log/1d150a2765bbf07b67cb3d922fa1fc9c7b01afa0 (trybot run)

There may be more, but these are the most visible to me.
@griesemer @bmkessler

/cc @billotosyr for the s390x failures.
I'll try disabling the s390x vector implementations of math.Atan, math.Log and math.Log10 tomorrow. I suspect there could be subtle differences in there that are affecting these new tests (Atan looks like a ~1 ulp difference while the Log/Log10 tests look like zero sign differences).

for s390x
--- FAIL: TestAtan (0.00s)
    cmath_test.go:1018: Atan((1+0i)) = (0.7853981633974484+0i), want (0.7853981633974483+0i)
    cmath_test.go:1026: Atan((1-0i)) = (0.7853981633974484-0i), want (0.7853981633974483-0i)
    cmath_test.go:1030: Atan((-1-0i)) = (-0.7853981633974484-0i), want (-0.7853981633974483-0i)
--- FAIL: TestLog (0.00s)
    cmath_test.go:1163: Log((+Inf-1i)) = (+Inf+0i), want (+Inf-0i)
--- FAIL: TestLog10 (0.00s)
    cmath_test.go:1184: Log10((+Inf-1i)) = (+Inf+0i), want (+Inf-0i)

The first failures are due to the test being too strict for checking the value of math.Atan(re) it should be converted to use cVeryClose instead of cAlike
The failures on Log are actually a discrepancy in s390x handling of math.Atan2(imag(x), real(x))
Log(x)  == complex(math.Log(Abs(x)), Phase(x)) == complex(math.Log(Abs(x)), math.Atan2(imag(x), real(x))
so the issue is that math.Atan2(-1, +Inf) should equal -0, but does not on s390x.
Note C99 Annex F. 9.1.4 specifies:
atan2(±y,+∞) returns ± 0 for finite y>0.
But the go documentation for math.Atan2 doesn't actually specify the sign.
//	Atan2(y, +Inf) = 0
However, the pure go implementation matches the C99 handling of the sign of zero.
The mips failures
--- FAIL: TestAtan (0.00s)
    cmath_test.go:1030: Atan((-Inf+NaNi)) = (-1.5707963267948966+0i), want (-1.5707963267948966-0i)
--- FAIL: TestCosh (0.00s)
    cmath_test.go:1124: Cosh((-0+NaNi)) = (NaN-0i), want (NaN+0i)
--- FAIL: TestTanh (0.00s)
    cmath_test.go:1357: Tanh((-Inf+NaNi)) = (-1+0i), want (-1-0i)

are due to errors in the test code with respect to NaN sign handling.  The tests have cases that check f(x) == f(-x) for appropriate functions, but -x does not necessarily change the sign bit of NaN and math.Copysign should be used instead.
The two issues with the test code are easy fixes, but a decision should be made about the Atan2 special case that disagrees between the Go documentation (s390x implementation) and the C99 standard (pure go implementation).


How to read and write of TcpStream simultaneously in 2 task?

is there any examples?  like split in tokio:
fn split(self) -> (ReadHalf<Self>, WriteHalf<Self>)   where Self: AsyncWrite { ... }
then i can read or write in two future simultaneously.

@mineralres Good question! -- we've written about this in our book:
use async_std::{io, net::TcpStream};
async fn echo(stream: TcpStream) {
    let (reader, writer) = &mut (&stream, &stream);
    io::copy(reader, writer).await;
}

Hope this helps!


Add label 'Cancelling' when interrupting install manually.

Nice to have but low priority for now.


Autorest Regen Preview to 3.0.0-alpha.20240213.2 by Dapeng Zhang from refs/pull/4219/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/4219

API change check
API changes are not detected in this pull request.


Implement direct and indirect updates of markers

[x] Direct marker updates (e.g. Marker::setHeadPosition, ::setProperties)
[x] Indirect marker updates (movements due to text changes)
[x] Different movements for markers w/ an invalidation strategy of inside
[x] Different movements for tail-less markers
[x] Handle markers created w/ no tail
[x] Snapshot markers before redo
[x] Investigate disabled test about marker positions during document.onDidChange events

@nathansobo I'm going to merge this so that we can start testing text-document in Atom with both marker support and our new work on the Patch. I figure that despite the one issue I mentioned above, the vast majority is working and we can revise later.

:+1:


Private templates are public by default

Reproduce

Log in to a paid account in Gorgias
Create a private template

--> The template shows up in public templates, and not private.
You have to manually change the sharing to private in order to stop sharing it with everyone.

This is caused by the Share templates by default with all your team. setting in Settings > My Account.
This is set to True for all new accounts. Do we want to set it to 'False' for new accounts?

If we remove it, when users create templates from the "all" tab, they will be private by default, which is not the default behavior users expect.
I think we need to change the scope of this option, to only apply to templates that are created from the all tab. Templates created from the private tab should be private by default all the time, and those created in the shared tab should be shared by default all the time too.


Adding Login and Sign In Page

I want to work on this issue can you assign me this issue

The Login and Sign UP/ Sign IN page has not been add yet.

I kindly request to be assigned this issue to enhance the functionality, usability, and visual appeal of the login and sign-in page.
Thank you!
Hactoberfest !!!

Please Assign this issue to me under hactoberfest label

assign this to me


NFT transfers

PR brings the ability to send and receive a Statemine NFTs:

button Send on the screen of an NFT
dialog forms to send NFT: a screen to fill the address of recipient, confirmation screen
buttons Send / Receive on the screen with the list of NFTs and corresponding screens
internal business logic to perform transfers and receive blockchain updates on successful transfer

A bug was also fixed with the display of RMRK NFTs released as Statemine NFTs on Kusama Assets Hub.
Previously, the application crashed when displaying such NFTs

Hey! Thanks for such big and valuable contribution!
Can you please attach a set of screenshots so we will be able to check with design team whether it fits current app style or not and maybe ask for some improvements in case it is not?
Regarding code review - I've quickly checked the code and it looks OK in general, thanks for trying to presever overall app code style and architecture. I will not be to conduct detailed review during next 2 weeks due to my load however I expect initial review to be done pretty quickly after mentioned 2 week timeframe

@stepanLav seems like we have issues with CI when trying to run it on forks

Sure, we will be waiting for the review. Looking forward.

Thank you! I've forwarded this to our design team to take a look and work together on applying any potential improvements

@valentunn @antonkhvorov hey guys, how are things are going? do we need to make any changes to the PR?
we made another PR with with further NFT improvements: https://github.com/novasamatech/nova-wallet-android/pull/1072
Would be great to see all this in the next release

Hey! General comment regarding branches:
Now you submitted 3 PRs, lets call them A, B and C.
I've just created a new branch from develop, called nft_base. Please target all PRs to this branch instead of develop. Once we are sure whole feature you are interested in is implemented and ready, we can merge it do develop, thus adding it to next release scope
Moreover, consider using the following strategy for PRs B and C to avoid waiting for A to be merged for them to be ready to review:
A targets nft_base
B targets A
C targets B
This way, diff for pr B and C will only include changes from commints specifically made in B or C. When A will be merged to nft_base, github will automatically change target branch of B to nft_base. Same will happen with C after B is merged

Can you also attach screenshots of all screens you've changed after last screenshots were sent?

Can you also attach screenshots of all screens you've changed (in terms of UI) after last screenshots were sent?

Hi. I've just posted the screenshots of fixed app in the PR dedicated to NFT UI
https://github.com/novasamatech/nova-wallet-android/pull/1072

Closed in favour of #1178


Move getting_start_windows GitLab CI job tests under Pytest

Where practical, we should consolidate our tests under Pytest - it's good for more than just unit tests. This GitLab CI job was failing, but since all of the Pytest runs on GitHub and GitLab were passing it was mistakenly ignored.
Relates to #6311
@visch

Closing in favor of #6218


won't launch after update windows build 22631.2338 to 22631.2428

Hi,
I just updated my W11 to 23h2 (build 22631.2428) and no longer have a way to run MicaForEveryone
Everything worked before without problem. I was in 22631.2338 before the update and everything worked fine
Solution please ? thx 👍🏻

[ ✅ ] This is not about other apps being displayed weird or etc.
[ ✅ ] This is not about rendering issues that caused by a bug in the Windows.
[ ✅ ] I've read FAQ.
[ ✅ ] I've checked other issues and this is not a duplicate.
Describe the bug
MicaForEveryone won't launch after update and reboot of windows
To Reproduce
Steps to reproduce the behavior:
Use Mica (portable or installer) and just update w11 23h2 to the last build (22631.2428)
Expected behavior
MicaForEveryone lancement
Screenshots
No screenchots
Windows Version
Windows 11 Pro (build 22631.2428)
Additional context
I was in build 22631.2338 before the update, and everything worked fine

Same here ):

Same here

same for me right now... how to fix??

Are you using Installer/Portable or MSIX?

@dongle-the-gadget I updated the first post, it's more readeable, 💯
And it doesn't matter whether I use the portable version or the installable version the problem is the same (I haven't tested the msix package but in my opinion it will be the same with it ?)

The MSIX packages are somewhat different. Usually whenever I hear people saying they have launch issues with the EXE Installer/Portable versions I just tell them to use MSIX and it would work for some reason.

@dongle-the-gadget I tried with msix but an error occurred :
Unable to verify the publisher certificate for this application package. Contact your system administrator or application developer to obtain a new application package with verified certificates. The root certificate and all immediate certificates of the signature in the application package must be verified (0x800B010A)

reminder, but before switching to the latest build 23h2 everything worked perfectly

The MSIX file had its certificate changed around 1.3 IIRC https://github.com/MicaForEveryone/MicaForEveryone/wiki/Installation#msix-file

@dongle-the-gadget I installed the msix certificate and it works with the msix installation. Why does this problem occur like this on the portable and installable versions after this build update?

The MSIX packages are somewhat different. Usually whenever I hear people saying they have launch issues with the EXE Installer/Portable versions I just tell them to use MSIX and it would work for some reason.

I tried with the msix package, but the software still does not launch. I created a virtual machine with my old build (the author's before the problem) and now it works perfectly, so there is something wrong with the latest w11 insider build (22631.2428)...


Notes as template in themes?

Should we have a template for the notes screen in the themes folder?
Today i thought a bit about the notes screen, and i like the keynote notes screen, i can manage the elements that i want to see, time elapsed etc. so i though this would be nice for frontal as well.
And i don't really want to build the full settings functionality required to have something similar to keynote's note screen. So why not make it a template.
We could provide a couple of variabels

comment
time_elapsed
time_current
slide_current
slide_count
...

Then people could create their own templates for the note screen.

Sounds good. Let's do it


bugfix in pbc.grad

pbc.grad broke by commit -b2824f0d21663dbeabd103388dbfaff090a6394d, this pull request fixes this

tests pass locally but fail on travis-ci.

merged changes in 94de3a5


AMLS905X4-1094  - Verify Containers on latest cmf stack with Thunder4 distro enabled

Reason for change: YouTube instances are not launching in container mode.
Test Procedure: Build and verify
Risks: Low
Signed-off-by: Hridhya Narayanan<EMAIL_ADDRESS>

Closing the commit as issue was fixed with https://github.com/rdkcentral/rdkservices/pull/4312


Timeout on Deploy web applications and SQL Azure database using Powershell (Azure Cloud Shell)

Describe the bug
The time out for the cloud shell is fixed to 20 minutes. An initial install worked but I had to delete it because I used test names. When trying to install again (after deleting all related resources, resource groups and app registrations), I always receive a timeout. Some resources are created but the installation is incomplete.
To Reproduce
Steps to reproduce the behavior:
Try to install multiple times with different names.
Expected behavior
No timeout should occur.
Screenshots
Environment (please complete the following information):
I am using the CloudShell
Additional context
Add any other context about the problem here.

The time outs only seem to occur when targeting Germany West Central. With East US, it worked.


CNV-28827: Remove upload option from template add/edit disk modal

📝 Description
Since upload is occurring instantly to a PVC, we can't save an upload to a template to be created.
Removing the upload option from the add disk / edit disk flow for Templates view
🎥 Demo
Before:

After:

/lgtm


Can I replicate Single Node training time using two 4GPUs Node?

In this paper, "Scaling Neural Machine Translation", it is stated that "we match the accuracy of Vaswani
et al. (2017)(i.e. 26.5) in under 5 hours when training on 8 GPUs".
Is it possible that get the same result with 2 Nodes where each node have 4 NVIDIA-V100 GPUs using the following distributed commands run on two nodes?
 But you have a typo, --nproc_per_node should be 4.

@myleott , Thanks for the correction.
Will it still take approx 5 hours? Or it might take more time?

A few things:

The command you listed is for the baseline result, which is Row 3 of Table 1: http://aclweb.org/anthology/W18-6301. The listed time for that result is 495 minutes ~= 8.25 hours.
You can improve the speed by setting --max-tokens=5120 --update-freq=10 --lr=0.001. This will match Row 6 from the same paper (294 minutes).
Note that the estimates for minutes are based on the time it takes to reach 2.11 valid_nll_loss. Training won't automatically stop at that loss, you either have to manually kill it when it reaches that loss or you can continue training (eventually the loss will reach ~2.06 or 2.07).

@myleott , Thanks for the clarity.
In Table 1, there is bsz and cumul column for each experiment.
Do we need to also specify bsz and cumul as argument? If yes, bsz is --batch-size. what about cumul ?
Thanks.

bsz is --max-tokens actually,  and cumul is --update-freq.
--max-tokens corresponds to the number of tokens per GPU.
--update-freq will accumulate gradients from multiple batches before each update.
So the effective batch size in tokens is: max_tokens * update_freq * # gpus.
The actual value is logged in the training log under wpb (words-per-batch).
In the case of 32GB cards, you can probably increase --max-tokens and decrease --update-freq to speed up training. Just try to keep wpb between 350-400k.

@myleott, once again thanks for the clarity.

@myleott, one more question.
What is 'NLL' in valid_nll_loss? and Table -1 data is based on "opt. steps" or "Epochs"?

NLL is negative log likelihood: https://pytorch.org/docs/stable/nn.html#torch.nn.NLLLoss
“updates” in Table 1 is number of optimization steps

From: Asis Patra<EMAIL_ADDRESS>Sent: Thursday, February 7, 2019 10:36 AM
To: pytorch/fairseq
Cc: Myle Ott; Mention
Subject: Re: [pytorch/fairseq] Can I replicate Single Node training time using two 4GPUs Node? (#491)
@myleotthttps://github.com/myleott, one more question.
What is 'NLL' in valid_nll_loss? and Table -1 data is based on "opt. steps" or "Epochs"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/pytorch/fairseq/issues/491#issuecomment-461473269, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOJdg9ptJPyd7Ge2cKpWMG8Rl0diEX_ks5vLEfsgaJpZM4ak2Bs.


python3Packages.thrift: Fix python 3.12 support

Description of changes
This give python package thrift python 3.12 support.
Is a better and simpler solutions than first attempt that modify setuptools: https://github.com/NixOS/nixpkgs/pull/328182

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Just leaving a comment to keep me in the loop, as this PR and #326321 are essentially targeting the same issue.

How about using a distutils package from PyPI on Python 3.12? https://github.com/NixOS/nixpkgs/pull/328379

We can also consider to fix setuptools to behave as expected by adding the following lines to setuptools:
postInstall = ''
  ln -s $out/${python.sitePackages}/setuptools/_distutils  $out/${python.sitePackages}/distutils
 '';

But will give mass rebuild, but solve build problems for other python packages and avoid problems/confusion.
Will make a PR, that can be evaluated.

See #328415 for proposal to fix setuptools to behave as expected.


UNDERTOW-853 SpdyClientConnection.sendRequest should not be syncronized

I borrowed the same concept applied to http2. In my tests it worked fine.


fix(#1681): footer documentation changes (UI comp part)

Required for https://github.com/GovAlta/ui-components-docs/pull/144

For bug#1681, we do not need these properties in the ui-component project, closing this PR.


feat: fix error of mixing of joi schemas

BREAKING CHANGE: requires docusaurus ^2.0.0-alpha.73
fixes #31

Coverage remained the same at 78.692% when pulling a4ed874fe2b0fd3c421b9e72c584b7613ef103fb on steve/fix-joi into d7c9a46c5322aafdbf7bbc42242c113e4fd7361f on master.


nerdfonts: update.sh: parse HTML to generate shas

Motivation for this change
Fix #84947 and make sure issues like these won't arise again. /cc @worldofpeace @albakham .
Things done

[x] Improved update.sh to parse the HTML in order to fetch the list of fonts.
[x] Updated shas.nix.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I think you could write update.sh as:
#!/usr/bin/env nix-shell
#! nix-shell -i bash -p nix-prefetch jq

latest_release=$(curl https://api.github.com/repos/ryanoasis/nerd-fonts/releases/latest)
version=$(jq -r '.tag_name' <<<"$latest_release")

dirname="$(dirname "$0")"
echo \""${version#v}"\" >"$dirname/version.nix"

echo Using version "$version"

printf '{\n' > "$dirname/shas.nix"

while
  read -r name
  read -r url
do
    printf '\t"%s" = "%s";\n' "${name%.*}" "$(nix-prefetch-url "$url")" >>"$dirname/shas.nix"
done < <(jq -r '.assets[] | .name, .browser_download_url' <<<"$latest_release")

printf '}\n' >> "$dirname/shas.nix"

Thanks for the suggestion! That's much more reliable I suppose - using the API and not the website's CSS...


Max TxBuffers count

Hello, Pierre! I' ve been studying STM32 documentation (besides GIGA implementation).
According to AN5348 Introduction to FDCAN peripherals for STM32, depending on how RAM is configured, the maximum TxBuffers count is 32.
I would like to know why you why you limited it to 8.
Thank's again for this great lib!
Eduaedo

On the other hand, I've just saw mHardwareDedicacedTxBufferCount bounded to 0 to 32 ...

Yes, I agree there are 32 Tx buffers. A Tx Buffer can be used for :
- TxFIFO (1 to 32) ;
- individual TxBuffers (0 to 30).
The user can choose any configuration, provided the total does not exceed 32, using ACANFD_GIGA_R1_Settings properties:
//--- Hardware Transmit Buffers
//    Required: mHardwareTransmitTxFIFOSize + mHardwareDedicacedTxBufferCount <= 32
public: uint8_t mHardwareTransmitTxFIFOSize = 10 ; // 1 ... 32
public: uint8_t mHardwareDedicacedTxBufferCount = 1 ; // 0 ... 30
Pierre

Le 9 mars 2024 à 23:07, emagnetto @.***> a écrit :
On the other hand, I've just saw mHardwareDedicacedTxBufferCount bounded to 0 to 32 ...
—
Reply to this email directly, view it on GitHub https://github.com/pierremolinaro/acanfd-giga-r1/issues/1#issuecomment-1986993016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWKZVBA55MAFFX6NPFL3T3YXOBYVAVCNFSM6AAAAABEOK7QWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWHE4TGMBRGY.
You are receiving this because you are subscribed to this thread.


Comments on channel page community tab

To Reproduce

Go to the settings page
Open the comments sub--category
Now go to your channel page
Switch to the community tab

Bug
All comments that were loaded earlier will now show up on this tab.
Expected behavior
Only show comments that were actually posted on the community tab.

d069aa0d8c1a620ebcad7d3227cc8bad5086530f


Difference between versions 3.2.1 and 4.5.0 in paralelism

My Experiment
I am working with 100 time series. My PC has 24 processors. I aim to run each time series in each processor using from joblib import Parallel fitting LightGBM model.
When I tried to do this task with LightGBM==4.5.0 I had concurrency problems: All 24 processors were using 100% of CPU and the processing was so slow that it seemed nothing was being calculated. It happened with either device_type="gpu" or device_type="cpu" or device_type="cuda". The problem was solved when I passed njobs=2 in Parallel (so, I was sending only 2 time series at a time for the 24 processors). LightGBM was always with n_jobs=1.
However, when I changed to pip install LightGBM==3.2.1 I could send the 24 time series simultaneously without causing concurrency problems: my code ran fine using 100% of all processors.
My hyperparameters
"LGBMRegressor": {
        "learning_rate": np.linspace(0.001, 0.2, num=8),
        "n_estimators": np.linspace(100, 300, num=2, dtype=int),
        "max_depth": [4, 6],
        "colsample_bytree": [0.7, 0.8, 0.9],
        "subsample": [0.7, 0.8, 0.9],
        "random_state": [42],
        "force_col_wise": [True],
        "verbose": [-1],  # < 0: Fatal, = 0: Error (Warning), = 1: Info, > 1: Debug
        "objective": ["regression_l1"],  # https://lightgbm.readthedocs.io/en/latest/Parameters.html
    },

Commands to install LightGBM
pip install lightgbm==4.5.0
pip install lightgbm==3.2.1

Specific Questions
Is there a big change in how LightGBM was programmed between 3.2.1 and 4.5.0?
Does LightGBM 4.5.0 run some internal code in parallel that 3.2.1 does not?

Thanks for using LightGBM.
Yes, there have been significant changes since LightGBM 3.2.1 (April 2021) and 4.5.0 (July 2024).
If you can provide a minimal, reproducible example we'd be happy to help. That's a small amount of fully self-contained code that replicates the issue. Here's a good example to start from: https://github.com/microsoft/LightGBM/issues/6620#issuecomment-2305600608
Having that would answer questions I have like:

what is Parallel?
what do you mean "run each time series"?


windowsForm

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5088aa3f-addb-a600-bc90-9c1e6a4c8dfd
Version Independent ID: 053d6ccf-6dff-ebb9-6a18-3adc0ea9f5f8
Content: Windows Forms - .NET
Content Source: dotnet-desktop-guide/net/winforms/index.md
Product: dotnet-desktop
Technology: dotnet-winforms
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hello @Elmerleonel1999 you, didn't leave a message with your question. Can you please add that? Thanks


Add a map showing all the countries that fellows are located in

Underneath projects and fellows, have an interactive map that displays where everyone is located.

[ ] When you click on the pin location for that fellow, it gives you a card with information about the fellow (similar to the fellow section

You can chose to have pins or use circular profile pictures to show where everyone is on the map. You could remove the fellows section and replace it with the map.

@khattakdev We will do this issue.


JSONB support

How to use filterableColumns with Postgres JSONB ?

const assigned_bids = await paginate<Bid>(request, qb, {
        relations: ['product', 'statuses', 'basisBuyer'],
        sortableColumns: sortBy.map((e) => e[0]) as PaginateConfig<Bid>['sortableColumns'],
        searchableColumns: (request.searchBy as PaginateConfig<Bid>['searchableColumns']) || [],
        defaultLimit: 4,
        maxLimit: 500,
        where: { user: { id: In(assignedIds) } },
        filterableColumns: {
          year: [FilterOperator.EQ, FilterOperator.NOT, FilterOperator.IN],

          mass: [FilterOperator.EQ, FilterOperator.BTW, FilterOperator.GTE, FilterOperator.NOT, FilterOperator.IN],
          'basisBuyer.id': [FilterOperator.EQ],
          'product.nomenclatureGroupId': [FilterOperator.EQ],

          // deliveryDate is JSONB field in PostgreSQL. ex:
          /*
          {
            "to": "2022-06-26",
            "from": "2022-06-20"
          }
          */
          deliveryDate: [FilterOperator.EQ, FilterOperator.BTW, FilterOperator.IN]

        }

Thanks

Currently not supported, or at least not covered with a test.
Happy to accept a PR 👋

add JSONB support for all features

Any update on this @ppetzold  :( ?

@ppetzold I have tried two different ways of solving this, both work. I'm unsure of which solution is preferred though. Would you mind advising on which you want a PR on?
    @Column({ type: 'json', nullable: true })
    metadata: Record<string, any>

  //Unless modified, this would only allow EQ checks.
  it('should filter with single value', async () => {
      const config: PaginateConfig<CatHairEntity> = {
          sortableColumns: ['id'],
          filterableColumns: {
              'metadata.length': true,
          },
      }
      const query: PaginateQuery = {
          path: '',
          filter: {
              'metadata.length': '$jsonb:5',
              //'metadata.length': '$jsonb:$eq,5', //Could also be a way to get all FilterOperators if going with this solution.
          },
      }

      const result = await paginate<CatHairEntity>(query, catHairRepo, config)

      expect(result.meta.filter).toStrictEqual({
          'metadata.length': '$jsonb:5',
      })
      expect(result.data).toStrictEqual([catHairs[0]])
      expect(result.links.current).toBe('?page=1&limit=20&sortBy=id:ASC&filter.metadata.length=$jsonb:5')
  })

OR
  //If using ->> as the way to use the JSONB logic, we can support any other FilterOperator in combination
  it('should filter with single value', async () => {
      const config: PaginateConfig<CatHairEntity> = {
          sortableColumns: ['id'],
          filterableColumns: {
              'metadata->>length': true,
          },
      }
      const query: PaginateQuery = {
          path: '',
          filter: {
              'metadata->>length': '$eq:5',
          },
      }

      const result = await paginate<CatHairEntity>(query, catHairRepo, config)

      expect(result.meta.filter).toStrictEqual({
          'metadata->>length': '$eq:5',
      })
      expect(result.data).toStrictEqual([catHairs[0]])
      expect(result.links.current).toBe('?page=1&limit=20&sortBy=id:ASC&filter.metadata->>length=$eq:5')
  })

Would personally prefer dot path notation. do you $jsonb operator is required? could be inferred by column type?

Would personally prefer dot path notation. do you think $jsonb operator is required? couldn't be inferred by column type?

I've updated it so it checks the column type instead, so dot path notation and no custom FilterOperator. It's limited to $eq checks currently. Shall I submit a PR for you to take a look at?

Sure please go ahead


Add Dependabot Version Updates

To add/enable Dependabot version updates to code, we will need to create the config file:
https://github.com/bcgov/digital-journeys/network/updates

This is to remediate the following scanned issues (Alerts): https://github.com/bcgov/digital-journeys/security/dependabot

@warrenchristian1telus - Hello and welcome back - I see we wanted to wait on this one post-launch. Is there an update on this ticket? I'm thinking we'll roll this ticket into our work with Senior Leaders team.

@MeghanStothers We have a meeting this afternoon to discuss the upgrade path. Just a note that we seem to have 4 active issues around updates: #271, #366, #487, #488


fix: bucket name reference in policy documents

:tada: This PR is included in version 1.1.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Introduce socket plugin helper

This change introduces socket plugin helper, and migrate out_forward to v0.14 API fully with plugin helpers.
This change does:

add fluent/plugin_helper/socket and #socket_create (_tcp, _udp) methods
fix server plugin helper to call it with existing socket (only for UDP, to create a server without any assigned port)
fix output plugin to move it into recovery (retry) state when chunk is rollbacked in async mode
rewrite out_forward with socket/timer/server/thread plugin helpers using #try_write for at-least-once mode

This change doesn't:

add tests for socket plugin helper itself ... not yet
tcp connection pools and/or keepalive implementation

@repeatedly Could you review this change?


ADH-497 make ranger_kms installing properly, mainly by fetching scrip…

…ts from HDP

Oh, shit! Looks like ranger_kms now installs without any error!


fix BlockchainFollower issue when catchup is disabled

the recent refactor introduced a bug when running with catchup disabled; we never set the catchup_complete event, so the main iterator waits on it forever.
This just sets the flag in the catchup thread if catchup is disabled, and makes sure we don't clear it again during a retry.

I think I'll do a patch version bump for this, for easier deployment


jails-fstab files disappear when stopping and/or starting the cbsdd daemon

I put an fstab file in the $cbsd_root/jails-fstab directory, named as:
fstab.httpd
with the entries similar to:
/device/path   /mount/point    nullfs rw 0 0
and when I restarted cbsdd the file disappeared. So next, I stopped cbsdd, created the same file, and it disappeared when I started the daemon again. Puzzled, I created the file again, and this time only stopped the cbsdd daemon and same thing, the file disappeared!
In the meantime, I've just appended the entries to the host's /etc/fstab:
/device/path    $cbsd_root/jails-data/httpd-data/mount/point nullfs rw 0 0
to work around the issue, but I'm not sure what's wrong. Is the documentation correct? Do you have an example fstab.$jailname file that doesn't disappear for you?
I ran a mkdir /path/to/httpd-data/mount/point before attempting any of this and each of the jails are base_rw
BTW: Sorry I'm such a pest :-P I really like cbsd and intend on using it from here out to manage my jails and eventually my VMs once I get a machine that will run the bhyve hypervisor. Thank you very much for your hard work!

You need use fstab with postfix .local for custom fstabs. E.g:
fstab.httpd.local

Thanks!


Feature Request - Unsubscribe Support

Knowing full well this would be a little more involved, it would be cool if unsubscribe support were available as well to handle conditions where a user updates their profile and $customer->isSubscribedToNewsletter() goes from true to false.

Thank you once again. Specially for you this was also improved in #787e62e7e8c935d3152486db6de915086ad4b522 commit 🎉

Thanks!


All my extensions were uninstalled

Type: Bug
after i reverted junk files from the source control all my vscode settings disappeared and all my extensions were unistalled
VS Code version: Code 1.86.2 (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:40:56.878Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 3750H with Radeon Vega Mobile Gfx   (8 x 2296)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.43GB (2.56GB free)

Process Argv
--crash-reporter-id c93e0667-9f4b-46b4-9f0c-7a499e1f6ce7

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30968133
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
d34g3935:30971562
edj9j583:30969295
fegfb526:30961430
7j2b6412:30969109

@DenisHristov12, do you remember what files were reverted?
@sandy081, any suggestions on how to investigate this issue?

Please open the extensions folder and user data folder and confirm that if you have not reverted these folders.

F1 > Open Extensions Folder
F1 > Open User Data Folder

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


add support of i18n for es2015 branch

Hi,
i saw you guys are now working on the es2015 branch,
So I just open a new branch based on es2015 for adding i18n support by using angular-translate

[x] Extract almost all encoded strings from templates as well as some messages in controllers.
[x] standalone json file in i18n folder for each language
[x] a sweet button at the top right conner of the status bar for switching different languages
[ ] full translation (now only part of chinese and german was done)
[ ] probably a better naming strategy for each string

the main configuration of this functionality is in app.js
    // Configuration of i18n Internationalization
    app.config(['$translateProvider',
      function($translateProvider) {

        // configures staticFilesLoader
        $translateProvider.useStaticFilesLoader({
          prefix: '/i18n/',
          suffix: '.json'
        })
        .registerAvailableLanguageKeys(['en', 'de', 'zh'], {
          'en_*': 'en',
          'de_*': 'de',
          'zh_*': 'zh'
        })
        // Check local language automatically
        .determinePreferredLanguage()
        // Use English as default language if no matched language is found.
        .fallbackLanguage('en');

      }]);

after the configuration, all hard-coded strings in views are replaced in angular-translate way, like:
{{ 'OVERVIEW.INFO' | translate }}

OVERVIEW.INFO will be replaced later with the string value Overview/Übersicht/概览 defined in json files in i18n folder.
😄

We'll have a look as soon as possible!

@Kaijun the PR looks really good! thanks for the work.
we could even provide the German translation if you want.
and could you please open the PR against master since es2015 is WIP and won't get merged soonish.

I discovered that when you open the language dropdown menu and move the cursor over the text it changes from pointer to selector.
However, I think it should behave the same way as the "help" dropdown behaves (with hand cursor).

the language selection is not persisted. whenever you refresh the admin ui it will detect the browser language again. I think there should be an item "Autodetect Language" in the dropdown that clears the previously persisted language value

I've done the German translation. I would push it to the new PR against master.

hi @Kaijun
any news on this? do you want us to finish the implementation?
best, christian

sry was busy yesterday. I'll send a new pr late today. Thanks!

@chaudum new PR  was opened. 🎉

merged into master with #205


[BDC]-[Notebook]- If we query a huge file in Notebook it reports - IOPub data rate exceeded

Issue Type: Performance Issue
In ADS Notebook if we query a large log file I notice the following warning and display data gets truncated.
IOPub data rate exceeded.
The notebook server will temporarily stop sending output
to the client in order to avoid crashing it.
To change this limit, set the config variable
--NotebookApp.iopub_data_rate_limit.
Current values:
NotebookApp.iopub_data_rate_limit=1000000.0 (bytes/sec)
NotebookApp.rate_limit_window=3.0 (secs)
This looks like relative to the Jupyter Notebook bug that has been already filed https://github.com/jupyter/notebook/issues/3010 https://github.com/jupyter/notebook/issues/2287, To work around the issue most of them have the following lines that needs to be executed https://stackoverflow.com/questions/43288550/iopub-data-rate-exceeded-in-jupyter-notebook-when-viewing-image.

To create a jupyter_notebook_config.py file, with all the defaults commented out, you can use the following command line:
$ jupyter notebook --generate-config
Open the file and search for c.NotebookApp.iopub_data_rate_limit
Comment out the line c.NotebookApp.iopub_data_rate_limit = 1000000 and change it to a higher default rate. l used c.NotebookApp.iopub_data_rate_limit = 10000000
This unforgiving default config is popping up in a lot of places. See git issues:
•	jupyter
•	IOPub data rate exceeded
It looks like it might get resolved with the 5.1 release
Update:
Jupyter notebook is now on release 5.2.2. This problem should have been resolved. Upgrade using conda or pip.

How to mitigate the Issue; How to apply the workaround that has been fixed. It looks like we are using Jupyter notebook of version 5.7.4 which is greater than the fixed build but the issue still occurs.
Repro:-
Just read some file from O/S or from K8s cluster either using cat or
!kubectl exec -ti control-rfx7c -c mssql-controller -n mssql-cluster -- cat /var/opt/controller/log/2019-05-07/controller-trace.log
!type C:\EAPWebinar\controller-trace.log
Azure Data Studio version: azuredatastudio 1.6.0 (eb35dae1d1238e03f1cab3bd45e151f381b22aef, 2019-04-17T07:11:15.944Z)
OS version: Windows_NT x64 10.0.14393

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2620 v3 @ 2.40GHz (12 x 2394)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.92GB (22.16GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    85	  5964	azuredatastudio main
    0	   289	  4264	   window (Azure Data Studio)
    1	   143	  4848	     extensionHost
    0	    70	  7620	   shared-process
    1	    80	 17208	   gpu-process
    0	    77	 19448	   window (Issue Reporter)

Workspace Info
;

Extensions (1)

Extension
Author (truncated)
Version

sql-vnext
Mic
0.12.1

@ronychatterjee - pushing this out to planning. We have 8 days left for feature improvements in June, and this will require adding a section to user settings which we can then copy over to the notebook config on startup. While that's not a crazy amount of work I'd guess it'll be 2 days and that doesn't fit.

This has since been fixed in our September release with our performance enhancements re: text editor models.


AddressStorageTests.testInFileAddressStorage() and PublisherToAsyncTests.testCancellation() failing

Failing tests:
AddressStorageTests.testInFileAddressStorage()
PublisherToAsyncTests.testCancellation()

@oa-s reassigned to @eviltofu along since it's related to #6673. Feel free to help out if you like

I ran AddressStorageTests.testInFileAddressStorage() for 100 times and there was no failure. :(

I figure it might fail more frequently if you run the complete suite

I'm now running the entire test suite but in randomised mode. I figured the failures will show up there.

Does XCTest let you only run a subset of the test easily? If it's possible, then maybe binary search to narrow it down to a smaller set that is repeatable?

And maybe this is obvious: if you run the complete suite and one of the test fails, then I suppose the offending subset is right there at that point?

These tests don't seem to fail anymore.

Can this be closed? @hboon

Yeah, since they pass


Windows Update Errors - Missing References

Doesn't contain entries for either 0x800F0922 or 0x80246007. 0x80246007 is referenced on https://docs.microsoft.com/en-us/windows/deployment/update/windows-update-error-reference but this does not include any mitigation steps.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cb9f2a2-76ad-8301-7d80-e33a7bb80a1b
Version Independent ID: dd070c32-53d5-53d6-7ba2-a4361b5263bb
Content: Windows Update common errors and mitigation - Windows Deployment
Content Source: windows/deployment/update/windows-update-errors.md
Product: w10
Technology: windows
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

This article was migrated to the Windows troubleshooting content library, which is owned by another team in support. I've shared this issue with them if they want to take action on it. I'm closing this issue as there's nothing actionable for my team since this content no longer exists in this repository.


Remove prompt to install packs for core languages

Now that we dont ship core language support out of the box, the prompt that we intend to do so in the future is not needed.
Related to #50588
cc @sandy081

@ramya-rao-a Thanks for the PR. I discussed with @dbaeumer about this and we decided to have this prompt for a milestone. Reason being, it will be easy to revert if there are issues.
So planning this for next milestone.

So are we going to continue to ship the core languages out of the box for June?

@ramya-rao-a No, we do not ship core languages. We just want to have minimal changes to revert to VS Code with core languages, in case if there is an issue.

ping @sandy081

Sample comment linking to another issue https://github.com/Microsoft/vscode-pull-request-github/issues/101

Sample comment with link https://github.com/Microsoft/vscode-pull-request-github/issues/101

Trying bold and some code

Try this link https://code.visualstudio.com

hello there

Lets target this change for August

In that case, I'll go ahead and merge this if you are ok with the changes

LGTM


v3 renders sliders and select items incorrectly

Steps to reproduce
Tell us about your environment:

Puppeteer version: 3.0.1
Platform / OS version: Windows 10
URLs (if applicable):
Node.js version: 12.16.2

What steps will reproduce the problem?
I've noticed that a standard input slider and select group no longer render in the same way that they did in puppeteer v 2.1.1
<input type="range" value="0">

  <select>
  	<option>A</option>
  </select>

In v2.1.1 they used to render like this:

In v3.0.1
the slider looks like this (blue circle rather than grey rectangle thumb):

and the select group looks like this (not shape of downward arrow):

I'm using puppeteer to capture screenshots in my test framework, but now all my tests are failing because the slider and selector look different.  How can I get them to render normally again?

I believe this to be correct, see https://blog.chromium.org/2020/03/updates-to-form-controls-and-focus.html


Application is not updating automatically via private GitHub repo

I have followed all the steps in this doc
Version:

electron: 7.1.3
electron-updater: 4.2.0
electron-builder: 21.2.0
electron-notarize: 0.2.1
Working on: MacOS Catalina 10.15

Build Config
"build": {
      {
        "repo": <REPO_NAME>,
        "private": true,
        "owner": "muhzi4u",
        "provider": "github",
        "publishAutoUpdate": true,
        "GH_TOKEN": <GITHUB_TOKEN>
      }
    ]
  }

Electron Entry

const { autoUpdater } = require('electron-updater');
app.on('ready', async () => {
  autoUpdater.checkForUpdatesAndNotify();
  createWindow();
});

The app is uploading to GitHub releases.

But when I release the further versions. The app is not updating automatically. What is the issue here?

@iffy Do you have any idea on this?

Any update guys?

@ivangomes Finally I managed to fix the issue. Could you please share the configuration. I can help you with this?

My package.json:
{
"name": "coldstorage",
"version": "1.0.0",
"description": "Go Cold Storage",
"main": "main.js",
"repository": {
"type": "git",
"url": "https://github.com/ivangomes/coldstorage.git"
},
"scripts": {
"start": "electron .",
"build": "electron-builder build --mac --publish never",
"deploy": "electron-builder build --mac -p always"
},
"author": "Ivan Gomes",
"license": "ISC",
"devDependencies": {
"electron": "^3.0.2",
"electron-builder": "^22.4.1"
},
"dependencies": {
"electron-log": "^1.3.0",
"electron-updater": "^4.0.6"
}
}
My electron-builder.json
{
"productName": "coldstorage",
"appId": "com.wmsgosoftware.coldstorage",
"directories": {
"output": "dist/${version}"
},
"publish": [
{
"provider": "github",
"repo": "coldstorage",
"owner": "ivangomes",
"vPrefixedTagName": true,
"token": "",
"private": true,
"releaseType": "draft",
"publishAutoUpdate": true
}
]
}
Sure any help will be very welcome!

update: using "electron-updater": "^4.0.6" works for me!
Are you using:
electron: 7.1.3
electron-updater: 4.2.0
electron-builder: 21.2.0
electron-notarize: 0.2.1

Yes

Working Again! Yay!

Hi @ivangomes @muhsin-k  does your app work if the repo is private? i get this error when i open the app downloaded from the asset of latest release.
"Error in auto-updater. HttpError: 404 "method: GET url: https://github.com/user/electron-updater-example/releases.atom\n\nPlease double check that your authentication token is correct"
But if i change the repo to public , the same app works if i reopen it.
electron": "^14.0.1",
"electron-builder": "^22.11.7",
"electron-notarize": "^1.1.1"
},
"dependencies": {
"electron-log": "^4.4.1",
"electron-updater": "^4.3.9"
},
Any idea on this? or does this auto-update only work if the repo if public?

Any fix on this?
@mr339 I've got the exact same error message showing in a log. Did you get it fixed?
Cheers


New dedicated report API

Replace Basium CRUD with a dedicated API for reports
Report time

User is automatically taken from the auth user
New report
Update report
Remove report
sync reports

fixed in commit c7785e086aec81bc8e842861ec68e39b4729a828


recipes-zarhus: images: zarhus-base-image-debug: delete

We can use overrides to add debug functionalities to images, this will decrease amount of images files, improve scalability and maintenance. This has been originally proposed here https://github.com/zarhus/meta-zarhus/pull/15#discussion_r1709655526.

@m-iwanicki, it does work now, I suppose I messed up with overrides to IMAGE_INSTALL, I used :dbg:append, but should have used :append:dbg.
But here is another problem to solve, pre commit argues about :dbg, I suppose it does not notice we declare this override inside .yml file:
Advanced oelint..........................................................Failed
- hook id: oelint-adv
- exit code: 2

/home/danillklimuk/Projects/Zarhus/meta-zarhus/recipes-zarhus/images/zarhus-base-image.inc:4:error:oelint.vars.specific:'IMAGE_FEATURES' is set specific to ['dbg'], but isn't known from PACKAGES, MACHINE, DISTRO or resources
/home/danillklimuk/Projects/Zarhus/meta-zarhus/recipes-zarhus/images/zarhus-base-image.inc:14:error:oelint.vars.specific:'IMAGE_INSTALL' is set specific to ['dbg'], but isn't known from PACKAGES, MACHINE, DISTRO or resources

It is strange thoulg that it does not argue about your changes in linux_yocto_%.bbappend where you use the override for Kernel configs.

@DaniilKl https://github.com/priv-kweihmann/oelint-adv?tab=readme-ov-file#configure-your-custom-machine-or-distro-settings

@DaniilKl I pushed fix for oelint error (we have to inform oelint about our overrides as it might not know them). We can generate correct format in kas:
sudo apt update
sudo apt install jq
bitbake-getvar --quiet --value OVERRIDES | tr ':' '\n' | jq -Rn  '{replacements:{ distros: [inputs]}}' > /repo/.oelint-custom-overrides.json

Also I think this part is needed:
 EXTRA_USERS_PARAMS = "usermod -p '${ROOT_PASSWD}' root;"
+EXTRA_USERS_PARAMS:dbg = ""

This way dbg version won't have password. Not sure if there won't be problems later when meta-zarhus will grow but this split on debug/prod target has downsides e.g. when including meta-zarhus in other layers we can't create .bbappend for .inc file.

@m-iwanicki, thank you!

This way dbg version won't have password.

This way the entire variable EXTRA_USERS_PARAMS will be overwritten, won't it?

This way the entire variable EXTRA_USERS_PARAMS for dbg will be overwritten, won't it?

Yes.

Not sure if there won't be problems later when meta-zarhus will grow but this split on debug/prod target has downsides > e.g. when including meta-zarhus in other layers we can't create .bbappend for .inc file so I'm for this debug/prod target > merge.
Maybe modify somehow .wic filename to contain debug to make it easier to differentiate images?

I am a bit worried here, as well.
Can we take a step back and consider what actual value we get by skipping the -dbg image recipe?
Having two recipes is advantageous to me, not only from the point as @m-iwanicki has mentioned, but we also have different image names. With this proposal, I cannot guess just from the image name, if it was debug or production image. Debug features can then easily sneak into production image, which is not a good thing to happen.

Some rebasing.

This way the entire variable EXTRA_USERS_PARAMS for dbg will be overwritten, won't it?

Yes.

And I am a bit worried here.

e.g. when including meta-zarhus in other layers we can't create .bbappend for .inc file
But .inc files are just being included into recipes, so we can overwrite features they provide.

Maybe modify somehow .wic filename to contain debug to make it easier to differentiate images?
We could make a note in documentation about this override and features it provides, so users will be aware of it. Users are also aware of it during building when they provide debug.yml file. And during runtime we could utilize e.g. uname -a output and these promts:

(...)
[    1.425516] systemd[1]: Detected architecture arm64.

Welcome to Distro for Zarhus product 0.1.0 (scarthgap)!

[    1.444064] systemd[1]: Hostname set to <zarhus-machine-cm3>.
(...)
[    6.571714] mmc_host mmc2: Bus speed (slot 0) = 375000Hz (slot req 375000Hz, actual 375000HZ div = 0)

Distro for Zarhus product 0.1.0 zarhus-machine-cm3 ttyS2

zarhus-machine-cm3 login:

Can we take a step back and consider what actual value we get by skipping the -dbg image recipe?

Reduce amount of surplus code.


Notebooks: Fix grid export column header duplication

This PR fixes https://github.com/microsoft/azuredatastudio/issues/13562
PR in main: https://github.com/microsoft/azuredatastudio/pull/13568

Pull Request Test Coverage Report for Build 392566093

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 41.254%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/platform/serialization/common/serializationService.ts
0
1
0.0%

Totals

Change from base Build 392544502:
0.002%

Covered Lines:
21854

Relevant Lines:
48612

💛  - Coveralls