Load javascript files in production

Have you ever tested in production? After you run sbt stage, all the assets are no longer available at val a = getClass.getResourceAsStream("target/web/public/main/javascripts/bundle.js"), but instead packaged in a jar file.

Thanks for pointing that out. I tried this only locally and not in production mode. Are you familiar with accessing those files once they've been packaged?

You can view my whole project here.
Basically I load the scripts from public assets like this:
val vendors = Play.application.resourceAsStream("public/javascripts/vendors.js")
val serverSideComponent = Play.application.resourceAsStream("public/javascripts/serverSide.js")

val vendorsReader = new InputStreamReader(vendors.get)
val serverSideComponentReader = new InputStreamReader(serverSideComponent.get)


Work with fixed version tags for Docker images, such as Keycloak and MySQL

Frequent updates and version changes of docker images can lead to compatibility issues and unexpected behaviour, especially when deploying the system across multiple environments.
Suggested Change:
Edit the docker files and compose file to fix the current working versions.

Suggested version tags:

mysql:8.3.0 - Current working version with the synchronisation team
keycloak:24.0.4 - latest, which updates and fixes an issue on the current version in testing and production.
nginx:1.25.5 - latest


OME redesign master

With @lunson away, merging the redesign topic branch into master for the rest of the team to begin migrating content.

Discussed with @joshmoore and @hflynn, looks good to me. Feel free to merge.


Core Data guide

Changes in this pull request
Issue answered: #407 #460 #461
I did not run any tool to generate documentation
Checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[x] I have reviewed the contributing guide

Thanks so much @racer1988 ! 💯 🥇
I made some minor inline edits. Everything looks good to me! 😎
Thanks for doing this!

@jessesquires Thanks for fixing it! I am not a native speaker, so a better formulation of the phrases and fixing typos is more than welcome :D


Add a block with options examples

This is just to show some of the options for locales at least.

Thank you!


Help wanted on these issues

Looking for issues to work?

Make sure you read this first.
Check issues tagged help wanted. These issues were typically explicitly looked at the LBRY team, are friendly to work on and desirable features, but are explicitly not a priority for us.
Check issues tagged Tom's Wishlist. These issues are typically workable and are highly desired, but not always new contributor friendly. You should only work on one of these if not assigned and should comment if you're going to work on them.

This issue is designed as a signpost for people exploring the help wanted tag.

@HarshKhandeparkar @jeffslofish just made this, thought you guys might want to know about @tzarebczan 's Wishlist tag.

I was just going through the list when I got this notif 😃.
On Fri, 24 Apr, 2020, 11:20 PM Jeremy Kauffman<EMAIL_ADDRESS>wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar @jeffslofish
https://github.com/jeffslofish just made this, thought you guys might
want to know about @tzarebczan https://github.com/tzarebczan 's
Wishlist tag.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/issues/4067#issuecomment-619158345,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJI5HYMP53L2VVRHQLWFK3ROHGOTANCNFSM4MQJFW2Q
.

For the last few weeks I've been playing around with the desktop app and the daemon and looking for issues to pick off.
Although the branching naming conversion uses fix/feature/feat nomenclature, as a newbie, its hard for an outsider to understand if issues are actively being worked on, and thus my coding could be wasted.
Perhaps if lbry could assign users when they're actively working on an issue and / or use the issue number as the branch name as we did at ConsenSys and other roles?

Hi. You don't really need to follow any branch naming convention. Just
giving the branch a descriptive name is enough.
Also if you want to know if someone is working, just drop a comment. Also,
if you want to claim an issue, just leave a comment.
If someone had claimed an issue and haven't replied in a long time, it can
be assumed that they abandoned it. Or you can just ask one of the
reviewers/maintainers to reassign it.
On Wed, 29 Apr, 2020, 3:06 PM Lucas Cullen<EMAIL_ADDRESS>wrote:

For the last few weeks I've been playing around with the desktop app and
the daemon and looking for issues to pick off.
Although the branching naming conversion uses fix/feature/feat
nomenclature, as a newbie, its hard for an outsider to understand if issues
are actively being worked on, and thus my coding could be wasted.
Perhaps if lbry could assign users when they're actively working on an
issue and / or use the issue number as the branch name as we did at
ConsenSys and other roles?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/issues/4067#issuecomment-621093853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJI5H6OLKP3UPNLHHV5L7DRO7YIFANCNFSM4MQJFW2Q
.

Also, I don't believe that outsiders with no contribution can be assigned
to an issue using the issue assign feature.
Although, we could create a label for that...
On Wed, 29 Apr, 2020, 3:28 PM M K<EMAIL_ADDRESS>wrote:

Hi. You don't really need to follow any branch naming convention. Just
giving the branch a descriptive name is enough.
Also if you want to know if someone is working, just drop a comment. Also,
if you want to claim an issue, just leave a comment.
If someone had claimed an issue and haven't replied in a long time, it can
be assumed that they abandoned it. Or you can just ask one of the
reviewers/maintainers to reassign it.
On Wed, 29 Apr, 2020, 3:06 PM Lucas Cullen<EMAIL_ADDRESS>wrote:

For the last few weeks I've been playing around with the desktop app and
the daemon and looking for issues to pick off.
Although the branching naming conversion uses fix/feature/feat
nomenclature, as a newbie, its hard for an outsider to understand if issues
are actively being worked on, and thus my coding could be wasted.
Perhaps if lbry could assign users when they're actively working on an
issue and / or use the issue number as the branch name as we did at
ConsenSys and other roles?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/issues/4067#issuecomment-621093853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJI5H6OLKP3UPNLHHV5L7DRO7YIFANCNFSM4MQJFW2Q
.

Hi. You don't really need to follow any branch naming convention. Just giving the branch a descriptive name is enough. Also if you want to know if someone is working, just drop a comment. Also, if you want to claim an issue, just leave a comment. If someone had claimed an issue and haven't replied in a long time, it can be assumed that they abandoned it. Or you can just ask one of the reviewers/maintainers to reassign it.
…
On Wed, 29 Apr, 2020, 3:06 PM Lucas Cullen, @.***> wrote: For the last few weeks I've been playing around with the desktop app and the daemon and looking for issues to pick off. Although the branching naming conversion uses fix/feature/feat nomenclature, as a newbie, its hard for an outsider to understand if issues are actively being worked on, and thus my coding could be wasted. Perhaps if lbry could assign users when they're actively working on an issue and / or use the issue number as the branch name as we did at ConsenSys and other roles? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4067 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJI5H6OLKP3UPNLHHV5L7DRO7YIFANCNFSM4MQJFW2Q .

Sure.  That being said, I was looking at issue #3800 and noticed branch https://github.com/lbryio/lbry-desktop/tree/feat-channelAbandon.  Im not sure if someone is actively working on this fix.  All good, just an observation / suggestion.


Fix reputation

Current coverage is 53.78% (diff: 0.00%)

Merging #21 into develop will not change coverage

@@            develop        #21   diff @@
==========================================
  Files            33         33
  Lines          2830       2830
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1522       1522
  Misses         1308       1308
  Partials          0          0

Powered by Codecov. Last update e73a987...7545c5e


Enable Function List for non-C# languages

Currently the Function List implementation for the VSCode extension only supports C# based on the VS extension implementation.  Ideally the feature could also work for other languages, possibly reusing metadata available in the VSCode Code Outline feature.

Mid-progress report:
The code changes I've made are for VS Code's codebase, so nothing to check in for this repository.
But current changes I've made so far includes:

Reporting the type of data in the Outline, e.g. "currentValue (number)" instead of just "currentValue".
a. This makes the information projected to a developer using screen reader to be the same as a sighted developer.
Reporting the line number in the Outline via aria-label and hover text.
a. So NVDA will read "currentValue (number) at line 1" and so forth. Same information if you hover over the element too.

Currently working on:

Hooking up the "show function, methods, and so forth" settings to the Outline settings for better quality of life usage.
Working on a shortcut key to quickly toggle between Show All (aka Code Summary) and Functions/Methods only (aka Function List).
Make reporting the line number a toggleable and optional setting.

But I do have something to demo for this area at the very least, and we can show it with multiple languages.

Completed

Hooking up the "show function, methods, and so forth" settings to the Outline settings for better quality of life usage.

Okay, I kind of have the Function List implementation down:

It's under a shortcut key "Ctrl + Alt + F" when you focus on the Outline pane, such that it'll toggle between show all elements and just the functions and methods and constructors. Since JavaScript may have multiple classes and interfaces in a single file, which isn't a design that's common in C#, I decided to include classes and interfaces in the Function List as well for context.
But also because the way the Outline pane is implemented as a tree, if the class and interfaces aren't included, the children elements won't be included either. And I'm not sure if I should add another feature to allow the tree view to flatten as a list, because I feel like I'm adding more and more features and scope creep.


Is it possible to have a delete feature on the row?

You might be able to use SwipeRow from react-native-swipe-list-view with version 0.2.2 of this component. See Issue #58

SwipeRow works well this component on iOS. Doesn't play so nicely on Android though. Having said that; I see more errors on the Android side of things in this component anyway.


Same-sex marriage outcomes in Australia: "High Commission" for "Embassy"

Trello card

This PR makes Content changes to the Same-sex marriage outcomes in Australia
i.e replacing "High Commission" for "Embassy".

Factcheck
Preview Link
GOV.UK
Expected changes
Before

After

Affected pages
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/ceremony_country/partner_british/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/ceremony_country/partner_local/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/ceremony_country/partner_other/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/third_country/partner_british/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/third_country/partner_local/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/third_country/partner_other/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/uk/partner_british/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/uk/partner_local/same_sex
https://smart-answers-pr-2557.herokuapp.com/marriage-abroad/y/australia/uk/partner_other/same_sex

👍

@leenagupte for letting me know.. @sistephens over to you.

Looks good, ready for deployment 👍

@sistephens thanks for the feedback.. thank you all


Allow Stroom to easily ingest the stroom.log

Ideally make this a configurable option, maybe if one supplied a feed name to the setup then the log is sent to that feed regularly.
There is lots of useful stuff in the event log that will help our monitoring

Should this configuration item be extended to

the proxy logs
the event logs
?

This issue has been discussed previously as we will soon have many more services producing log4j/slf4j type log output (i.e. n stroom nodes, n stroom-auth-service nodes, n stroom-stats nodes, etc) and there is no current means for collating all these logs and querying them.  Some form of kafka based log appender has been discussed so each service could send its log messages to a kafka topic (with a file based fallback for kafka un-availability).  Stroom would then consume from this topic, normalise, index and store in the stream store.


Confusing about the class DefaultIdStrategy

There is a field named collectionMapping in the class DefaultIdStrategy,the collectionMapping is a ConcurrentHashMap<String, CollectionSchema.MessageFactory> and the key of the map is String.
But the following code in the class:
@Override
protected void writeCollectionIdTo(Output output, int fieldNumber,
        Class<?> clazz) throws IOException
{
    final CollectionSchema.MessageFactory factory = collectionMapping
            .get(clazz);
    if (factory == null && clazz.getName().startsWith("java.util"))
    {
        // jdk collection
        // better not to register the jdk collection if using this strategy
        // as it saves space by not writing the full package
        output.writeString(fieldNumber, clazz.getSimpleName(), false);
    }
    else
    {
        output.writeString(fieldNumber, clazz.getName(), false);
    }
}

This code final CollectionSchema.MessageFactory factory = collectionMapping.get(clazz); looks like not correct.The result of that always null.Should change it to final CollectionSchema.MessageFactory factory = collectionMapping.get(clazz.getName());?

@zhuyiren You are correct.  It should be clazz.getName().


Ensure csrf token is available on dashboard panels

Fixes #7688

@gasman  epic, thank you, I gave this a go the other day but did not think to check the parent_context, thanks for adding unit tests also.
I have cherry picked this to 2.15.1 764eb14a38be247be9e1f35eed7a4fe2204bc3ff

Thanks @lb- and @gasman. I was pretty happy just to know it wasn't my fault. But you guys fixed it in 2 days. Impressive.


fix(APIChannel): rtc_region is optional

Reference Discord API Docs PRs or commits:
https://discord.com/developers/docs/resources/guild#guild-object

I have to ask, when can this be undefined? I am aware the docs say so, but I cannot find any voice channels with it missing 👀

Channels that aren't voice channels i guess?

Oh, duhhh. Thanks


Containers.ListContainersAsync times out immediately after calling it

Output of dotnet --info:
.NET Core SDK (gemäß "global.json"):
 Version:   2.1.503
 Commit:    4c506e0f35

Laufzeitumgebung:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.503\

Host (useful for support):
  Version: 2.1.7
  Commit:  cca5d72d48

.NET Core SDKs installed:
  1.1.0 [C:\Program Files\dotnet\sdk]
  2.0.0 [C:\Program Files\dotnet\sdk]
  2.1.200 [C:\Program Files\dotnet\sdk]
  2.1.201 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.300 [C:\Program Files\dotnet\sdk]
  2.1.400 [C:\Program Files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]
  2.1.402 [C:\Program Files\dotnet\sdk]
  2.1.403 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]
  2.1.503 [C:\Program Files\dotnet\sdk]

What version of Docker.DotNet?:
3.125.2

Steps to reproduce the issue:
I copied the following example code from the docker.net project page and ran it.
static void Main(string[] args)
{
    // Default Docker Engine on Windows
    DockerClient client = new DockerClientConfiguration(
            new Uri("npipe://./pipe/docker"))
        .CreateClient();

    var containers = client.Containers.ListContainersAsync(
        new ContainersListParameters()
        {
            All = true
        }).Result;
}

What actually happened?:
The issue I'm facing is that the call to ListContainersAsync immediately (after a few ms) times out and I get an exception.
What did you expect to happen?:
containers should be filled with the result from the call.
Additional information:
There is #314 regarding this method "hanging" on a corrupt Docker install but Docker itself is working correctly.

Hello @msdeibel,
Please change the uri from new Uri("npipe://./pipe/docker") to new Uri("npipe://./pipe/docker_engine")
It should work....

That fixed ist. Thanks :)


node old version

Problem/Motivation
integration with telldus stopped working in hass.io see : https://github.com/jchnlemon/homebridge-telldus/issues/55
Expected behavior
telldus plugin was upgraded, to support node 8, expected hass.io to also work
Actual behavior
didnt work
Steps to reproduce
reproducable in hass.io
Proposed changes
upgrade node

The change has been merged into the master branch and will be included in the next release.
Thanks for reporting the change request @dasam! 🏅

awesome! Good work, i am glad to help :-)


r.js unable properly optimize code using AMD build

AMD build uses define((function(JSON,RegExp) { ... })(JSON, RegExp)); call, which apparently can not be processed by require.js optimizer. Since both JSON and RegExp variables are global ones, I don't see particular use adding these into closure. If you get rid of it it should be usable with r.js optimizer I think.

https://github.com/WebReflection/circular-json/blob/master/template/amd.before and https://github.com/WebReflection/circular-json/blob/master/template/amd.after are the template used to generate the AMD version of this module.
How would you change those in a compatible way?

no answers, no changes.


how to make color black and white instead of purple and yellow in binary image segmentation

help!!

use numpy simply alot the class 255 pixel value in all 3 channel.
I guess you are using opencv or something to display image in python that's the issue
please read about proper display or saving image

Firstly, check if the pixel values of the image are 0 or 255. If that's ok, add (cmap='gray') to your show/imshow code line.
e.g., plt.imshow(image, cmap='gray')

There is no cmap attribute in visualize method, what should I do?


ZenjectException: Unable to resolve 'GameObject' while building object with type 'GameObjectAssetLoader'

Hello.
I did everything according to your documentation but always getting an error:
ZenjectException: Unable to resolve 'GameObject' while building object with type 'GameObjectAssetLoader'.

I've tried both options:
Method 1 - using AddressablePreloadListInstaller

Method 2 - using MonoInstaller and manually bind the AssetLoaders

Unity 2019.3.11f1
AddressableLoading v0.0.2
Extenject Version 9.2.0 / Version 9.1.0
Thank you.

In both methods you bind GameObjectAssetLoader to your container not GameObject. So you cannot do this.
[Inject] private GameObject gameObject;

You need to either use something like this
[Inject(Id="myPrefab")]GameObjectAssetLoader prefabLoader;

public void Initialize()
{
    GameObject prefab = prefabLoader.LoadedAsset;
}

or Bind GameObject in installer
Container.Bind<GameObject>().FromResolveGetter<GameObjectLoader>("myPrefab", loader=>loader.LoadedAsset).AsSingle();

Also congratulations on opening the first issue. I haven't replicated your problem in my computer. So if this doesn't help let me know. I can take a look later to replicate it.

Thanks for your reply.
The thing is that I don't understand how to use your classes. I would very much appreciate if you add a sample. For instance, a Unity project with: an addressable prefab, a scene, an installer/settingsInstaller where the prefab is binded, and a script where we load the binded addressable to the scene.

Added a sample folder. You have to provide the addressable prefab yourself. I structured this git repo as a UPM package so it could be easily added into project with git url. I don't think I can provide addressables with UPM package.
Note that I made this repo after receiving a lot of questions in Extenject gitter community. I made DecoratableKernel implementation for Extenject which recently got merged. This would be much easier with that implementation. So I would suggest taking a look at the source and understand the methodology itself.
I also plan on working on Async support for Extenject. So after that is completed this repo will be obsolete because there will be support for adressables in Extenject itself.

It worked.
Thank you for the example and clarification.
I am looking forward to having this feature as a part of Extenject.

Hello. Thanks for your work. I have same probjem. I opened your example. The prefab loads, but the injection doesn't work.
I added this code to my prefab, but I get a Null message in the console. Why? How to properly use prefab injection?
`public class MonoTestPrefab : MonoBehaviour
{
[Inject] Contexts _contexts;
public void Start()
{
Debug.LogWarning(_contexts);
}
}`

Hi @DrebotArtem ,
Its been a while since I looked at this repo. But if I remember correctly, I am only loading the assets (in your case prefabs). Instantiating it within Zenject's workflow is not part of the package.
In general if you want to instantiate a prefab with injections working, you should not use GameObject.Instantiate if that is what you are using. First item in the "gotchas" section mentions that.
https://github.com/modesttree/Zenject#general-guidelines--recommendations--gotchas--tips-and-tricks
Quickest way would be to use Container.InstantiatePrefab(loader.LoadedAsset);. That should inject into prefab.
https://github.com/modesttree/Zenject/blob/31f06cf81043f04301b1072ec81922b64149ea34/UnityProject/Assets/Plugins/Zenject/Source/Main/DiContainer.cs#L2008
If you want it to be done via factory, you would need to add it in your bindings. One way to do it would look like this.
Container.BindFactory<Enemy, Enemy.Factory>().FromResolveGetter<GameObjectLoader>("myPrefab", loader=>{
    var instance = Container.InstantiatePrefab(loader.LoadedAsset);
    return instance.GetComponent<Enemy>();
}).AsSingle();

I am not 100% if above binding will work. Haven't tested it. But like I said, this is a how do you "instantiate a prefab in Zenject question". There are many ways to do it.

Also async support I mentioned before has been added to zenject for a while now.
https://github.com/modesttree/Zenject/blob/master/Documentation/Async.md
It is not directly addressable related, but since Addressable loading ins async, it covers it too.

Thanks a lot for such a quick response. But the thing is, I can't use Container.Instantiate. I use Addressables.Instantiate. Here is my problem. I have a LoadingScreenProvider that inherits from a LocalAssetLoader.
  public class LoadingScreenProvider : LocalAssetLoader, ILoadingProvider
  {
    ...
    public async Task LoadProvider(GameStateEntity entity)
    {
      _entityLoadingProvider = entity;
      _loadingScreen = await Load();
      _entityLoadingProvider.isLoadedProvider = true;
    }

    private Task<LoadingScreen> Load()
    {
      return LoadInternal<LoadingScreen>(_sceneLoadingReference);
    }
    ...
}

And i have a LocalAssetLoader
  public class LocalAssetLoader
  {
    private GameObject _cachedObject;

    protected async Task<T> LoadInternal<T>(AssetReference assetRference)
    {
      var handle = Addressables.InstantiateAsync(assetRference);
      _cachedObject = await handle.Task;
      if (_cachedObject.TryGetComponent(out T component) == false)
        throw new NullReferenceException($"Object of type {typeof(T)} is null on " +
                                         "attempt to load it from addressables");

      return component;
    }

    protected void UnloadInternal()
    {
      if (_cachedObject == null)
        return;
      _cachedObject.SetActive(false);
      Addressables.ReleaseInstance(_cachedObject);
      _cachedObject = null;
    }
}

Can you tell me how to use injection in this case?

After you instantiate using Addressables.Instantitate, pass that GameObject to Container.InjectGameObject
https://github.com/modesttree/Zenject/blob/31f06cf81043f04301b1072ec81922b64149ea34/UnityProject/Assets/Plugins/Zenject/Source/Main/DiContainer.cs#L2284
Also you don't appear to be using my system in these code samples. I was trying to help thinking you were using this library. Your problem seems to be related to general Zenject issue. You should try main Zenject issues board or chatrooms for getting support for these problems.

Thanks for the help.


Resolves GitLab #67 - [merged]

In GitLab by @arisilon on May 30, 2023, 16:30
Merges feature/bumpver -> master

In GitLab by @arisilon on May 30, 2023, 16:34
mentioned in commit 16f90cc441eeab6d83e3b6719c5ee253fd09af58


Not work with [automount] options in /etc/wsl.conf

If /etc/wsl.conf contains this parameters, then socket file not creating:
[automount]
options = "metadata,umask=022,fmask=111"

It is impossible to invoke powershell.exe from WSL2 under the setting. If fmask=11, not 111, it should work.
I can't think of anything to do on the wsl2-ssh-agent side. If you know, please let me know.


部分图标显示错误，变成了奇怪的汉字

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
Settings
Steps to reproduce
PowerToysReport_2022-05-09-14-59-56.zip

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Sorry to hear it isn't working. We've seen many issues like this with version .58 - so this is probably a duplicate of #18032 or #18015.

Sorry to hear it isn't working. We've seen many issues like this with version .58 - so this is probably a duplicate of #18032 or #18015.
很遗憾听到它不起作用了。我们在0.58版本中见过很多类似的问题，所以这可能是 # 18032或 # 18015的复制品。

抱歉，我的意思是：很多图标变成了乱码，比如这个

I think I had to say #18055


UI Cleanup on note_component.tsx

Issue Details
Refactor and enhance the UI of note_component.tsx for improved consistency and user experience. This includes renaming the component, adjusting the UI elements, and preparing the codebase for the conversion from draft.js to plate.js (handled in a separate issue).
Technical Requirements

Rename the filename from note_component.tsx to note_editor.tsx
Rename the component from ToolPage to NoteEditor in the note_editor.tsx file.
Update all instances where ToolPage is imported to use NoteEditor instead.
Remove borders from the UI elements in NoteEditor.
Increase the size of the button icons in NoteEditor for better visibility and user interaction.
Update the button icons in NoteEditor to reflect the options available in the mobile app version, ensuring consistency across platforms.

Acceptance Criteria

The component in note_editor.tsx is renamed to NoteEditor, and all its instances are updated accordingly throughout the project.
The UI of NoteComponent no longer displays borders around elements.
The button icons in NoteEditor are larger and more user-friendly.
The button icons in NoteEditor match the options available in the mobile app, ensuring a consistent user experience across different platforms.
The code changes are clean, well-documented, and ready for the upcoming conversion from draft.js to plate.js, as outlined in issue #58.

Issue:
The note_editor.tsx requires a UI cleanup to enhance user interaction and maintain consistency with the mobile app. The component's renaming to `NoteEditor' aligns with the naming convention of the page it represents. Changes to the UI elements, such as removing borders and resizing button icons, along with aligning the icon options with the mobile app, are essential for a cohesive and intuitive user experience. Preparing the code for the draft.js to plate.js conversion (covered in issue #58) is also a key aspect of this task.

I believe this is just about done at this point


Failure not passing along extra parameters

If I call /auth/twitter?in_popup=true and the process is canceled twitter will redirect back to /auth/twitter/callback?in_popup=true&denied=foobar
The problem is that omniauth catches this failure and redirects to /auth/failure losing any of the added parameters I included.

Dunno why I did not follow up on your comment, @jeremyhaile, but my second solution still works, even for your use case. As you can see in the first solution, you have access to the strategy name inside the on_failure block, so you can use a case statement or constantize to redirect to the appropriate controller.
Something like this:
on_failure do |env|
  controller_name = env['omniauth.error.strategy'].name.capitalize + "Controller"
  controller = controller_name.constantize
  controller.action(:failure).call(env)
end

Is there any reason not to always pass along omniauth.params as part of the redirect querystring? If not, we should cobble together a PR.

Also, somewhat related for anyone coming here scratching their heads on mocked failure callbacks: #812

@booleanbetrayal did anyone ever figure this out? i want those omniauth.params!!! :+1:

Don't think there's been any progress on this or #812

thanks @guilhermesimoes for the solution!
i'm still hoping this can be properly fixed in upcoming version ;)

is this properly solved?

@guilhermesimoes your latest solution work! thank you so much for saving my day man

I realize this issue is super old, but when I try to use the workaround suggested earlier that looks like this:
  on_failure { |env| SessionsController.action(:failure).call(env) }

I get this CSRF error:

The browser returned a 'null' origin for a request with origin-based forgery protection turned on. This usually
means you have the 'no-referrer' Referrer-Policy header enabled, or that the request came from a site that
refused to give its origin. This makes it impossible for Rails to verify the source of the requests.

Perhaps if you do this you need to skip CSRF protection for that endpoint?


fix(generated-services) added eks to makefile

Signed-off-by: haarchri<EMAIL_ADDRESS>
Description of your changes
added eks to makefile generated_services

    setup_test.go:376: r: -want, +got:
          &v1alpha1.Addon{
          	TypeMeta:   {},
          	ObjectMeta: {Annotations: {"crossplane.io/external-name": "test-external-name"}},
          	Spec: v1alpha1.AddonSpec{
          		ResourceSpec: {},
          		ForProvider: v1alpha1.AddonParameters{
          			Region:                "",
        - 			AddonName:             &"test-addon",
        + 			AddonName:             nil,
        - 			AddonVersion:          &"v0.0.0",
        + 			AddonVersion:          nil,
          			ResolveConflicts:      &"test-resolve-conflict",
        - 			ServiceAccountRoleARN: &"test-role",
        + 			ServiceAccountRoleARN: nil,
          			Tags:                  nil,
          			CustomAddonParameters: {ClusterName: &"test-cluster"},
          		},
          	},
          	Status: {ResourceStatus: {ConditionedStatus: {Conditions: {{Type: "Ready", Status: "False", LastTransitionTime: s"2021-12-15 17:47:41.105807655 +0"..., Reason: "Creating"}}}}, AtProvider: {AddonARN: &"test-external-name"}},
          }

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

fixed with https://github.com/crossplane/provider-aws/pull/1110


Add an interface file for curve_choice

This PR adds curve_choice.mli, with an interface that matches both curve choices. This reduces the amount of code that gets rebuilt when switching between 298- and 753-bit curve profiles.
Eventually, these interfaces should be broken up, tidied up, and lowered into snarky and snarkette.
Checklist:

[ ] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Approving -- as a heads up I'm going to be deleting curve_choice when integrating the new curves :)


[engsys] Unpin Node target version for pipelines

Tracking issue to unpin the Node version once MSAL have published their workaround for the auto-npm pkg fix unintentionally adding an unwanted install script to the package manifest on publish.
Related:

https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/7022
https://github.com/Azure/azure-sdk-for-js/pull/29243
https://github.com/Azure/azure-sdk-for-js/issues/29244

I reopened this issue becuase the node 18.20.2 has issue for ci issue and pr. @timovv @ckairen Could you take a look?

This is a separate failure related to Rush and a Node security fix: https://github.com/microsoft/rushstack/pull/4637. Fixed in https://github.com/Azure/azure-sdk-for-js/pull/29389.


Add support for enum type creation.

Addresses https://github.com/vapor/postgres-kit/issues/149

@tanner0101 ready to merge if I didn't make any silly mistakes with the DROP TABLE support.


refactor delete all

Codecov Report

Merging #96 (deddf5b) into master (680819d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   98.18%   98.25%   +0.06%
==========================================
  Files           7        7
  Lines         331      344      +13
==========================================
+ Hits          325      338      +13
  Misses          6        6

Impacted Files
Coverage Δ

service/routes.py
98.34% <100.00%> (+0.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

good !


Update ketcher toolbar icons

Solution
Update icons for the following toolbar items:

Calculate CIP
Calculate values
Single down
Single up down
Single up
Text
Open
Save as
3D viewer
Templates/Structure library

@PetrKurkin please attach the icon SVG files

@KonstantinEpam23 icons in svg

![3d_viewer](https://github.com/epam/ke

tcher/assets/125649799/fb8478d1-988e-4895-97ce-8b43c044634d)

Attached "Calculate CIP" icon seems to be broken. Attaching fixed one:


When going back to the login screen the continue button should be disabled

Clicking back button in check your inbox page doesn't disable continue button

#175


Add disableOutsideClick prop

this should solve #43

Commit a66c796 and 871d82f should fix the closed issue #37 which is not fixed acutally.
Commit fd20b5f should fix #40

@mbj36 we don't really need to do any refs in the other files, since there is no interaction with the sideNav itself

@mbj36 Any idea when this will be merged ?

Thanks @roonie007 , Sorry for the delay


Use a more targeted npm link for integrations

Instead of linking to the npm front page, this changes the integrations guide link to use a targeted search for the recommended astro integration keyword (astro-component): https://www.npmjs.com/search?q=keywords:astro-component&ranking=popularity
Thoughts on whether that is helpful?

LGTM!
Maybe this means we need added content somewhere about installing npm packages meant for other UI frameworks? On framework-components, maybe? A new section? People do seem to be asking about installing stuff FOR REACT etc. and how to use it. (And then side-note: if we are NOT calling these "Integrations", then how ARE we distinguishing between "npm stuff for Astro" and "npm stuff for your other frameworks"?)
But I do agree, when talking about Astro Integrations, this link is perfect. 🚀

I think we should stick to using the term “Integration” specifically for a thing you import and pass to the integrations array in your astro.config.mjs. Anything else is a “module” or “package” and can usually be used “as you normally would” (with the exception of Vue plugins that document a App.use(plugin) pattern that isn’t compatible with Astro — explained very well in this Discord post). Obviously “as you normally would” is useless if you have never done something before, so this is probably something to improve in each framework’s docs (so I guess in the integration READMEs?) or in some future tutorial? Like, “here is how to use a date-formatting module with your framework”.


style(frontend): move "Back" button and context menu [GIX-2973]

Motivation
We move the Back link and the context menu on the sides of the token logo (except for Settings page).
NOTE: the context menu will be changed after.
Changes

Set the Back element to appear in the header only for Settings page.
Remove ContextMenu from the Actions.
Include both elements in the Hero content on the sides of the token logo and the balance.

Tests

Unsolicited opiniated feedback: Are you sure? Following is really the expected UI/UX? That look super weird, I don't think I have any mobile apps installed on my phone that have that behavior.

Unsolicited opiniated feedback: Are you sure? Following is really the expected UI/UX? That look super weird, I don't think I have any mobile apps installed on my phone that have that behavior.

Completly agreed, but it is just temporary: that button will change after this PR (i didn't want to put all together). If you prefer I can put it here

Ah ok, that wasn't clear for me when I read the description. Let's follow your path then, let me review the PR.


Added some extra explanations for whitespacing

Added some extra explanations for whitespacing on inherited codeblocks.

I just noticed that you pointed out how the first whitespace line was collapsed.  Did you want to point out the last one as well?

Closing due to inactivity.  Feel free to reopen.


[RFC/WIP] Embed client in producer and consumer

@wvanbergen

CI will probably fail because I didn't update the mocks.

This more-or-less requires we land a proper mock-client to embed in our mock-producer and mock-consumer.

Hmmm; it's not possible in go to make Client itself private, and only export its methods, right?
This might be overkill after all. I see legitimate use cases for exporting Topics() and Partitions() for the consumer (to figure out what topics and partitions you are going to consume), and potentially for Topics() could also be useful for the producer (e.g. validating whether a topic exists before producing a message). All the other Client methods I don't really see a likely use case for.

Hmmm; it's not possible in go to make Client itself private, and only export its methods, right?

Not automagically like this AFAIK.

All the other Client methods I don't really see a likely use case for.

I was still thinking that the basic CommitOffset helper and friends should live on the client, since they don't actually have anything to do with any state that the consumer stores...
I agree this feels kind of weird, but so does manually proxying a handful of methods. I agree the user shouldn't have to create a client in order to use the high-level consumer in the common case, but I'm not sure that's as true for the (current) low-level consumer.

I was still thinking that the basic CommitOffset helper and friends should live on the client, since they don't actually have anything to do with any state that the consumer stores...

On the other hand, that CommitOffset, FetchOffset, and (Refresh)Coordinator are only relevant when consuming, even though they don't have anything to do with the state Consumer stores per se. Whenever you want to use them, you will always have a Consumer instance available, but not necessarily a Client. So I think it's a good idea to have them available on the Consumer type; whether that means they should be implemented on that type or proxy to Client, is a different question.

I agree the user shouldn't have to create a client in order to use the high-level consumer in the common case, but I'm not sure that's as true for the (current) low-level consumer.

 So I think we shouldn't neglect the API usability of that one.

 Honestly, the only reason I ever published Client in the first place was because the original producer implementation was so simple I exposed the primitives in case somebody wanted to write their own. I've always approached Client as "all the primitives you need to write your own producer/consumer".

Yes, but is there a use case for the low-level consumer that involves calling Partitions or Topics? All the cases I can think of that currently involve low-level consumer in combination with Partitions/Topics are better-satisfied by the high-level consumer. The cases that remain for the low-level consumer don't involve that.

Yes, but is there a use case for the low-level consumer that involves calling Partitions or Topics? All the cases I can think of that currently involve low-level consumer in combination with Partitions/Topics are better-satisfied by the high-level consumer. The cases that remain for the low-level consumer don't involve that.

With our current API guarantees, it's much easier to add APIs than to remove them, so let's work on building the high-level consumer on top of the low-level consumer and the client, and see what proxies we need to add when that's done.

On the other hand, that CommitOffset, FetchOffset, and (Refresh)Coordinator are only relevant when consuming

Slightly tangential: WritablePartitions is only relevant when producing, but I don't think it belongs on the producer, because users of the producer don't care about it, only the producer itself uses it.
Similarly, the methods above are only relevant when consuming, but they should only be relevant to the consumer itself, not to the user of the consumer.

I still think that we should add Topics and Partitions as proxy.

The high level consumer is complicated to implement, as it will require adding Zookeeper as a direct dependency, or wait for Kafka 0.9.0. Adding these methods makes the API we currently have more usable, and a lot easier to test.
Even if the need for these methods completely disappears once we have the high-level consumer, the maintenance burden is negligible. It's just a proxy to the same method in Client, which we've committed to maintaining anyway.

The use cases we are addressing here are:

discovery of topics to consume (this should be rare I think, most of the time you know and hard-code which topics you want to consume)
discovery of partitions to consume (99% of the time, this is just "all of them")

So just ConsumeTopic(topic) on the low-level consumer might be a better solution?

ConsumeTopic(topic) won't allow you to set different offsets to start at for each partitions*. And, that API will definitely be useless once we have a high-level consumer, and will be a lot less trivial to maintain.

unless you make the final argument a map[int32]int64, but then you would need to know how many partitions the topic has.

If you have a list of offsets to start at, you know how many partitions are present and don't need to call Partitions at all

But then you would need a different API for when you don't know this yet.

It has to be a different path in the caller anyways, depending on whether you pass OffsetOldest or the saved custom value.

var consumers []*PartitionConsumer
partitions, _ := consumer.Partitions("topic")
for _, partition := range partitions
  offset, err := fetchOffset("topic", partition)
  if err != nil {
    offset = sarama.OffsetOldest // or OffsetNewest,
  }
  pc, _ = consumer.ConsumePartition("topic", partition)
  consumers := append(consumers, pc)
}

var consumers []*PartitionConsumer
offsets, err := fetchOffsets("topic")
if err != nil {
  consumers, _ = consumer.ConsumeTopic("topic", offsets)
} else {
  consumers, _ = consumer.ConsumerTopicFromOldest("topic")
  //  consumer.ConsumerTopicFromNewest("topic")
}

I prefer the first option, because I think it's more straightforward, especially in the case when the offsets map doesn't have all partitions in it (e.g. when partitions are added to the topic)

I also prefer the first option, it's just the idea of exposing Partitions on the consumer really grates on my soul :P

var consumers []*PartitionConsumer
partitions, _ := client.Partitions("topic")
for _, partition := range partitions
  offset, err := fetchOffset("topic", partition)
  if err != nil {
    offset = sarama.OffsetOldest // or OffsetNewest,
  }
  pc, _ = consumer.ConsumePartition("topic", partition)
  consumers := append(consumers, pc)
}

would be three lines longer (to account for creating the client) and feels much cleaner to me

This is turning into a :bike: :house:, let's just add them and I will swallow my pride until we get people confused and I can say I told you so :D

Except that testing is going to be way more complicated because you need to mock client, and is more susceptible to user error (by hardcoding partition numbers or creating a second client).

Anyway, I will just yolo-push

Creating a second client is not a terrible thing; it's not optimally efficient, but it's not going to cause problems.

ducks

See #431. This was previously discussed in #366 as well.


Feature/kafka integration

first implementation

The last week I've replaced my Kafka image with this the last week I've replaced my Kafka image with the this


ImageFormatter cannot find fonts in OS X 10.8 Mountain Lion

(Original issue 868 created by guillaumealgis on 2013-05-04T13:33:19.970901+00:00)
The fc-list command used to find available fonts on *NIX systems does not work on OS X 10.8, as it does not include X11 anymore.
See this stackoverflow.com question for alternatives.
In addition, I doubt the *NIX default font Bitstream Vera Sans Mono ever shipped on OS X (it is a least not available on 10.8).

(Original issue 868 last updated on 2017-01-22T18:39:32.131334+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2017-01-22T18:39:31.462923+00:00)
Merged in AndreBremer/pygments-main (pull request #597)
Image Formatter: Mac-specific lookup for fonts (fixes #868)
→ <>

(Original comment by birkenfeld on 2017-01-22T18:39:32.088224+00:00)
Added Mac-specific lookup for fonts (fixes #868).
→ <<cset 7923fcea19d6>>

(Original comment by birkenfeld on 2017-01-22T18:39:32.128966+00:00)
Merged in AndreBremer/pygments-main (pull request #597)
Image Formatter: Mac-specific lookup for fonts (fixes #868)
→ <>


project abandoned?!?

Hi.
no updates in ~4 years?!? so:

is the project abandoned?
is there any maintainer fork known / available?
any alternative known / used by someone?

maybe git-annex?!?

Pretty much.

:(


Bug: text not positioned properly

texts are not positioned properly with image

Hey @Anshuaman2001
I think the issue is already there, Can you please check it once.

I checked but this issues doesn't exist .
assign this to me .

Hey @Anshuaman2001 I think the issue is already there, Can you please check it once.

I checked but this issues doesn't exist .
assign this to me


How do I change override preference?

For example when i override DoSomething(), I get:

public override void DoSomething() => base.DoSomething();

But I want:

public override void DoSomething()
{
     base.DoSomething();
}

Where and how do i change this behaviour?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b2dad35-15b3-7597-6bca-4a7d617dac55
Version Independent ID: e0fee980-8e2c-d52e-a713-cd92530d926b
Content: Generate a method override - Visual Studio
Content Source: docs/ide/reference/generate-override.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@wrkettlitz -- thank you for your question.  You may find answers here:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

@TerryGLee -- please look into this issue.


[Kiali]Allow auth strategy configuration in Helm chart

This is a trivial patch to allow configuration of auth strategy in Kiali through the Helm chart values. Default behavior using 'login' strategy does not change.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: couniojc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: howardjohn
If they are not already assigned, you can assign the PR to them by writing /assign @howardjohn in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @couniojc. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: couniojc, jmazzitelli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: howardjohn
If they are not already assigned, you can assign the PR to them by writing /assign @howardjohn in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@couniojc: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@couniojc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@couniojc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I signed it!
I have been added to the WeWork mailing-list that should manage the WeWork agreement that is already signed.

I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@jmazzitelli Any idea why the CLA is not going through ? Do I need to do something ? Thanks

hmmm... I do not know. The only thing I could suggest is what the bot says:
"It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits."
If you've double checked everything, we'll have to ping a project owner.

@couniojc I think the problem is that the email you signed it with and the one you commited with are not the same?
On our internal cla tool (sorry its not public) it shows

couniojc |   | need_sender_cla

@howardjohn
Afaik I used<EMAIL_ADDRESS>for the commit, and that's how I've been added to the https://groups.google.com/a/wework.com/forum/#!forum/opensource that is supposed to be the one linked to the Google CLA for WeWork. That said no-one here is able to tell me for sure which mailing list the CLA is using for WeWork, so it will be great if you have a way to check this on your side.
Thanks !

I personally do not know how to see that - the page I can see does say you used the email you specified. I think what it is saying is that email has a CLA, but your github username does not. afaik it needs both

I changed my default email for my couniojc account to the wework email address, let's see if it makes the CLA bot happier like that

Boom ! That was the problem :-P

/test integ-security-k8s-presubmit-tests-master

this should be ready. but i don't know what this waiting for: istio_e2e_cloudfoundry-master Expected — Waiting for status to be reported

We added a new test since this PR was submitted. This might work...
/test istio_e2e_cloudfoundry-master

/ok-to-test
(I don't have permissions here to approve - I don't even think /ok-to-test will do much)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: couniojc, howardjohn, jmazzitelli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@couniojc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@couniojc: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-k8s-presubmit-tests-master

prow/integ-telemetry-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-telemetry-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
6fa8703153d476224d6a3f13dfcc30e5ceabc105
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[jvm-packages] why the libgomp.so.1 file used  in xgboost4j-spark

i builded xgboost4j-spark in a virtual machine, gcc version is 4.8, then i run spark jon on my spark cluster, gcc version is 4.1.2, but log messages show below error info~
18:42:20 WARN TaskSetManager: Lost task 2.0 in stage 8.0 (TID 801, <IP_ADDRESS>): java.lang.UnsatisfiedLinkError: /tmp/libxgboost4j1061727375559164064.so: libgomp.so.1: cannot open shared object file: No such file or directory.
i checked my cluster machine, most of my  machines  os in cluster  lack of libgomp.so.1 file.This file is a c lib file...

so...what's your problem?

xgboost4j-spark relies on xgboost which is a native lib further relying on libgomp....so.........

I had the similar issue . That is resolved once I install " gcc" on  spark cluster  i.e.  both on spark master and worker node.
apt-get install -y gcc
OR
yumt install -y gcc
based on your linux  flavor.


Do you want to have the enhancement of existing game ? 😀 Describe yourself..
In chess, the white player is supposed to move first, but that is not the case in this game.

Describe the solution you'd like
I will make it such that the white player makes the first move
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @VijaySamant4368 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @VijaySamant4368 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Scaffold repo scripts, add Slither

@lucas-janon thanks for getting this started. I've made some updates including multiple outputs (JSON, SARIF, and MD) and added the inquirer you suggested for selecting which set of contracts to run against. This gives everyone the ability to quickly run a basic SAST scan against the contracts locally and can later be integrated in the CI/CD pipeline.

Been running for 20 min


[Java Client] Optimize batch flush scheduling

Master Issue: https://github.com/apache/pulsar/issues/11100
Motivation
As observed in https://github.com/apache/pulsar/issues/11100, the Java client producer consumes cpu even when doing nothing. This is especially true when using many producers. Instead, we can make it so that the batch timer is only ever started and running when there are pending messages queued in the batch timer.
If there are concerns about this optimization, I will need to take some time to complete benchmarks.
Modifications

Skip message batch delivery if the producer is not in Ready state. As a consequence, ensure that messages pending in the batchMessageContainer are still eligible to fail for sendTimeout.
If there is no current batch flush task, schedule a single flush task when a message is added to a batch message container (assuming the message does not also trigger the delivery of the batch).
Schedule another batch flush task if and only if the batch flush task itself was responsible for sending messages.
Keep track of lastBatchSendNanoTime, and only flush a batch message container if the BatchingMaxPublishDelayMicros time has passed since the last send time.
Note that the timer task is only ever updated within synchronized (this) block, so we are guaranteed to have a consistent view free of race conditions. (There is one race condition, and that is that an existing batch timer might get canceled while it is starting. This is of little consequence since it'll result in either no delivery or a small batch.)

Verifying this change
There are existing tests that cover batch message delivery. Specifically, the BatchMessageTest in the pulsar-broker module covers these changes.
Does this pull request potentially affect one of the following parts:
This is a backwards compatible change.
Documentation

[x] no-need-doc

@lhotari and @merlimat - I realized that the cost of canceling and rescheduling a batch message timer for every batch might not be ideal, especially in high throughput producers. Therefore, I switched the logic to match that of the sendTimeout, which essentially reschedules a timeout if an insufficient amount of time has passed since an event (in this PR's case, that is the time since last sending a message).
I also rand into an issue with the SimpleProducerConsumerStatTest#testSendTimeout. It exposed the fact that my design did not allow for queued batch messages to get timed out when the producer is disconnected. I updated the logic with a naive solution. The one "surprising" affect of my solution might be that a message might get up to double the send timeout if the producer reconnects at the "right" time. I think this is fine, but let me know if this tradeoff is a problem.


Fixes bug: entra app permission remove fails when service principal d…

…oesn't exist. Closes #6291

Thanks! We'll try to have a look at it ASAP!

@Saurabh7019  I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

Merged manually, thank you 👏


Archetype-Edges rework

Problem
Single .Add operations are using Archetype-Edges to find the fitting archetype with the additional component faster. It basically creates a graph out of archetypes and traverses them.
The same does NOT exist for removal operations yet. So we should consider to add that. Furthermore ArrayDictionary could get replaced by a JaggedArray which only allocates buckets once needed. Would probably be cleaner and even faster -> MORE SPEED:

Partially solved in 8a4948f6adafa2cd4153cf5e0689b1d9bbf8dc63.
Next step is adding remove-edges for removal operations.


Flesh out event editor

Specific tasks:

[x] Fix /events's PUT endpoint (uses Mongoose's update(), which is not working for some reason
[x] Decide whether the event editor should be a modal on the admin page or stay as a separate page (leaning towards separate page so that some of the following can be implemented
[x] Support creation/editing of ticket categories during event editing/creation
[x] Support toggling of "closed" property on events (IE: if ticket sales are open/closed)

Closed in commit https://github.com/akeaswaran/tedxgt-ticketing/commit/265d49943880d6a5b700a069de37935ef39b3220


Export animation handle (CUBISPLINE) are wrong

Seems that handle (when CUBISPLINE) are not exported correctly.
See blend file and glb generated:
3 cubes with 3 different handle, but in exported glb, all 3 are animated same way.
handle_issue.zip

Must be retested after recent change on 5066a34067cae9719bfae6a1a791b787c1f3dfb3


Fix for Issue624

Workaround for #624.
Currently, when inserting empty string or null into encrypted variable-length columns, the driver sets the data length to 0 and the type to type(0) (varchar(0) for example). The workaround is to set the length to 1 and the type to type(1).

Codecov Report

Merging #632 into dev will decrease coverage by 0.15%.
The diff coverage is 62.5%.

@@             Coverage Diff             @@
##                dev    #632      +/-   ##
===========================================
- Coverage     46.55%   46.4%   -0.16%
+ Complexity     2226    2220       -6
===========================================
  Files           109     109
  Lines         25409   25417       +8
  Branches       4187    4187
===========================================
- Hits          11830   11794      -36
- Misses        11546   11586      +40
- Partials       2033    2037       +4

Flag
Coverage Δ
Complexity Δ

#JDBC42
46.28% <62.5%> (-0.11%)
2214 <0> (ø)

#JDBC43
46.31% <62.5%> (-0.16%)
2217 <0> (-8)

Impacted Files
Coverage Δ
Complexity Δ

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
61.6% <62.5%> (-0.85%)
63 <0> (ø)

...m/microsoft/sqlserver/jdbc/SQLServerException.java
75.2% <0%> (-1.66%)
28% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
44.24% <0%> (-0.68%)
103% <0%> (-2%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
62.54% <0%> (-0.67%)
0% <0%> (ø)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.75% <0%> (-0.53%)
241% <0%> (-4%)

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
50.28% <0%> (-0.25%)
155% <0%> (ø)

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
38.54% <0%> (-0.22%)
42% <0%> (ø)

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
77.62% <0%> (-0.17%)
4% <0%> (-1%)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
54.03% <0%> (-0.14%)
0% <0%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9277451...fcf8d48. Read the comment docs.

The workaround looks fine. After looking around the code, it seems like the valueLength is 0 if the user is using a callable statement and using the parameter as an output parameter. Have you considered this case / looked into what giving n/varchar(1) to the server implies?

I think it should be fine since I just tried the same scenario with output parameter, and it seems to work fine, but I wanted you to consider this scenario as well.

I tested the PR with both PreparedStatement and CallableStatement.


val_exprate=0 and save checkpoint

hello!thanks for your time!
When I transfer some code in decoder or use it directly,the val_exprate are always be 0.000,I don't know why.
Another problem is,I noticed that this code don't have the function to save checkpoint or something.Can you give me some help?Thanks again!

Hi, I think you may refer to issue #4, and see if you are encountered the same env problem.
For the second checkpoint problem, the pytorch lightning framework will automatically save the model with the highest val_ExpRate. Once your val_ExpRate increase, you will see a checkpoint file saved in your log folder.
In the config.yaml:
  - class_path: pytorch_lightning.callbacks.ModelCheckpoint
    init_args:
      save_top_k: 1
      monitor: val_ExpRate
      mode: max
      filename: '{epoch}-{step}-{val_ExpRate:.4f}'

The other packages are also the right version。But it do have this error，do you think it is the reason?

Sorry, I haven't seen this error before, this may be related to your hardware.
We run experiments on 4x1080Ti, hope that can help you.

Ｔ▽Ｔ May I have chance to change something to run successfully on 2*1080Ti? Appreciate for all your reply!!!

I cannot reproduce your problem in my 2x2080Ti, and val_ExpRate increases after 4 epochs.
I use cudatoolkit=11.0. You may try that configuration.

Thanks,you're so kind!!I'll try again!And hope you have a nice day!


Mail feature

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


WIP feat: implement HTTPRoutePortRedirect

Work in Progress
fixes: https://github.com/Kong/kubernetes-ingress-controller/issues/3681

What this PR does / why we need it:

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello, saw this while scanning through newer issues. Would you be interested in contributing a dedicated plugin to the https://github.com/Kong/kong repo?
We know we don't have the ability to implement GWAPI-style redirect configuration in the proxy yet, and I'd wanted to handle this with a general-purpose flexible redirect plugin that can issue redirects that keep portions of the original URL and replace others.
The serverless plugins can handle this (they're effectively a way to add plugin code without actually installing a plugin), but we'd prefer to avoid it as a means to handle these redirects because of its inherent security risks (they allow anyone with the permission to create plugins to run whatever code they want).

Would you be interested in contributing a dedicated plugin to the https://github.com/Kong/kong repo?

Sure, Thanks for your suggestions. I'll try to implement it.
Close the PR.

@cr7258 please ping me on the new PR (I'm not sure if you'll be able to add me as a reviewer, but if not, a comment mention should be fine); the KIC team doesn't see most Kong/kong PRs otherwise.

@rainest Ok, I will.


Feature Request: Export to csv/json

As a workaround for #428 I'd like to export results from a specific run to JSON (e.g. in the UI) for easier analysis.

You should be able to get JSON directly from the eval command, e.g. with promptfoo eval -o filename.json.  This outputs the same file format that's used to populate the UI.


[Recorder] Plan to test the recorder library

Some ideas for tests

[ ] Pick individual functions from utils and add independent tests for them
[ ] Create a fake project where we can probably start a server and hit the server for testing

[ ] Has to be done for both node and browser separately
[ ] For any new feature that we want to test, there are two tasks..

[ ] run record to test the feature - generate the recording
[ ] run playback and test the recording
[ ] for any new feature to be tested, HTTP request has to be such that the feature is being used in the record or/and playback modes.

Features to be tested

[ ] Skipping the test in record/playback modes should work as expected
[ ] Make sure the getUniqueName and the newDate works as expected

Keep adding more...

https://github.com/Azure/azure-sdk-for-js/pull/7204#discussion_r374303580

My PR goes a different way than the separate package, it works by mocking the most minimal set of things we need to test this. I've been able to catch some bugs with it, though my fixes are very similar to the HTTP timeout fixes that Harsha has found. I believe that with my PR and Harsha's PRs in, the recorder is now good enough moving forward. We will be able to make progress to separate fixes and tests as smaller drops of effort, more sparse over time.


Check Microsoft Defender is in Passive Mode

In the section "Verify that Microsoft Defender Antivirus is in passive mode", I'm not sure if the following commands are correct.
"Run the Get-MpComputerStatus cmdlet."
"In the list of results, look for AntivirusEnabled: True."
I took a look at a machine that has only Defender installed and another machine that has both Defender and Symantec installed, and in both cases the AntiVirusEnabled:True is the value that I see.
Also, For command prompt command:
"Type sc query windefend, and then press Enter."
We need more guidance as to what to look for after this command has been executed to verify that Defender is in fact running in passive mode.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bae59608-208f-5cec-39a4-95466faa0646
Version Independent ID: 20c0ab0d-fb2b-3d79-3fcb-d555fc95db14
Content: Phase 2 - Set up Microsoft Defender ATP - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/symantec-to-microsoft-defender-atp-setup.md
Product: w10
Technology: windows
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@jenujose thank you so much for this feedback. I will check on this and will post an update here soon. Really appreciate you taking the time to post this great question.

@jenujose and @e0i, just a quick note to let you know I have not forgotten about this. We are discussing the content updates internally. I will post another update as soon as I get the article updated.

Thank you for the updates, @denisebmsft

Hi!
We added the ForceDefenderPassiveMode registry key (as MS recommends) to our Windows Server 2019 (1809) registry, because of 3rd party AV.
And the question is the same: How could I check that Windows Defender is in passive mode?
Real-Time protection is On on the GUI , and the Get-MPComputerStatus command also gives: RealTimeProtectionEnabled       : True
Thank you your answer,
Pete

If you run the Get-MPComputerStatus command, it WILL state if it is in passive mode in the AMRunningMode. If you are running EDR Block mode as well, it will state EDR over passive.

Thank you all for the feedback and for your help! The article has been updated, and here's the procedure to confirm Antivirus is running in passive mode: (1) On a Windows device, open Windows PowerShell as an administrator; (2) Run the Get-MpComputerStatus cmdlet; and (3) In the list of results, look for either AMRunningMode: Passive Mode or AMRunningMode: SxS Passive Mode.


Remove extra bottom space in Mentors and User Form page

The Book Review and User Form page have extra space at the bottom.

Eliminating the space will give the pages cleaner look
Book Review Page

User Login Page

Could this issue be assigned to me under GSSoC'23?

could you improve UI of one of the page?

@VSatwika up for it?

@VSatwika up for it?

Hello! I've been trying but I'm unable to make the desired changes.

can I do this?

@VSatwika up for it?

Hello! I've been trying but I'm unable to make the desired changes.

oh np! Please find other bugs and you can fix them. thanks


Added option to fix feature file indentation

Signed-off-by: Parajuli Kiran<EMAIL_ADDRESS>

we need to come up with a way to organize the linter and fixer. Let's wait till then

closing on behalf of https://github.com/gherlint/gherlint/pull/16


dart test --coverage: getSourceReport: (-32000) Service connection disposed

Hello! I am facing an unexpected getSourceReport: (-32000) Service connection disposed error when running dart test --coverage=folder.
Unfortunately there's not much extra information. The full dart test log I have is:
✅ test/firebase_admin_app_test.dart: FirebaseAdminApp initializeApp() creates a new FirebaseAdminApp
✅ test/firebase_admin_app_test.dart: FirebaseAdminApp useEmulator() sets the apiHost to the emulator
getSourceReport: (-32000) Service connection disposed

This is an unexpected error. Please file an issue at http://github.com/dart-lang/test
with the stack trace and instructions for reproducing the error.
Unhandled exception:
getSourceReport: (-32000) Service connection disposed

Here is a Github Action log with the issue: https://github.com/invertase/dart_firebase_admin/actions/runs/9906073779/job/27366938724
cc @DanTup

Looking at the full error, I guess this should be filed at http://github.com/dart-lang/test (although I also wonder if the issue could be in https://github.com/dart-lang/coverage).
Assuming it's going through the code here, it seems like the VM is set to pause isolates on exit:
https://github.com/dart-lang/coverage/blob/044b7a27aecc183f204b25dd74c23d911343f9fb/lib/src/run_and_collect.dart#L18
Then it keeps polling until all isolates are paused, collects coverage, then resumes the isolates. This seems fairly sound to me, though I wonder if the VM crashes if it might result in this (for example, could it run out of memory collecting coverage, and would it fail in this way?).
Perhaps @natebosch or @jakemac53 are more familiar with how this works and know where best to file this and/or how to collect more info that might help identify the issue.

It looks like this exception is coming from package:vm_service. @bkonyi might be able to give some help on the cause of the exception.
I don't have context for whether package:coverage can ignore errors from getSourceReport. It looks like SentinelException is expected and causes us to skip a given isolate, but I don't know whether it is safe to continue after other exceptions like this one. @liamappelbe might be able to help with that question.
This doesn't look like something that is specific to package:test.

It looks like this exception is coming from package:vm_service. @bkonyi might be able to give some help on the cause of the exception.

The exception should only occur when the VM Service/DDS is shutdown/disconnected. Since the issue was reported against master it's possible it was affected by the  recentfix to https://github.com/dart-lang/sdk/issues/55559. It's not clear to me though whether the VM Service is terminating unexpectedly (if it crashes, would there be any output from dart test to indicate this?) of if test/coverage is trying to fetch coverage info later than it should. Nor do I know the best way to collect additional info to help track this down.

As Danny stated, that looks related to the fix for #55559. The service connection is being destroyed due to a crash, the VM shutting down, or a network issue while the getSourceReport RPC is outstanding.

dart test --coverage runs several commands under the hood. If there is a VM crash, my guess is we're not seeing the stack trace because package:test is running the test in a subprocess. In that case, the way to debug this is to run those commands manually so that any VM crashes are dumped to the terminal, or for the commands to be run in gdb. Something like this:
dart run --pause-isolates-on-exit --disable-service-auth-codes --enable-vm-service=8181 test

# In a separate terminal
dart pub global run coverage:collect_coverage --wait-paused --uri=http://<IP_ADDRESS>:8181/ -o coverage/coverage.json --resume-isolates

It would also be good to figure out why package:test isn't forwarding the crash logs to the terminal and fix that if possible.

I forked the repo and could reproduce the issue, so I tried splitting the commands in various ways, most recently like:
set -e -m

dart pub global activate coverage

firebase emulators:start --project dart-firebase-admin --only firestore,auth &

dart run --pause-isolates-on-exit --disable-service-auth-codes --enable-vm-service=8181 test &

jobs -l

dart pub global run coverage:collect_coverage --wait-paused --uri=http://<IP_ADDRESS>:8181/ -o coverage/coverage.json --resume-isolates --scope-output=foo &

jobs -l

fg %2

Unfortunately I haven't been able to reproduce the issue with the commands separate. However, it seems there are many more tests running now (the original cashes only show a few tests), which does make me think that something is crashing (and therefore all of the tests are not being run), but the crash is not reported correctly.
I'm not sure how to repro though - I don't know if the failure only occurs when run through firebase emulators:exec of it it's just coincidence that it only failed in my first run that way).

I did notice if I just put exit(1) in a test then dart test never reports that the process exited a) without completing or b) with an exit code.. Not sure if that's a bug? (maybe if it was reporting non-zero exit codes, it might at least be clearer if there is a crash here?)

Oops, I think I for confused along the way. I wanted to see if the crash would be noticed, but ofc pkg:test is running inside the same process, so the VM terminating with an exit code is not something test can detect (and if dart test is running pkg:test directly in the same VM and not spawning another process, I guess the same applies there).
I'm not sure why I can't repro the error without the firebase emulators:exec.. I don't know if it's causing something to crash. I did try running a script that just throws to ensure that it is passing stderr and exit codes on correctly (so firebase is not swallowing anything) and that seems to be the case:
✔  firestore: Firestore Emulator UI websocket is running on 9150.
i  Running script: dart run bin/throw.dart
Unhandled exception:
Oops
#0      main (file:///home/runner/work/dart_firebase_admin/dart_firebase_admin/packages/dart_firebase_admin/bin/throw.dart:2:3)
#1      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#2      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
⚠  Script exited unsuccessfully (code 255)
i  emulators: Shutting down emulators.
i  firestore: Stopping Firestore Emulator
i  auth: Stopping Authentication Emulator
i  hub: Stopping emulator hub
i  logging: Stopping Logging Emulator
Error: Script "dart run bin/throw.dart" exited with code 255
Error: Process completed with exit code 255.

I added some debug logging to a fork of pkg:test and also this anywhere isolates were spawned (+ main isolate):
isolate.setErrorsFatal(false);
isolate.errors.listen((e) => print('MAIN: $e'));

And now the "crash" no longer occurs and everything completes, but at the start of the output I see this:
✔  firestore: Firestore Emulator UI websocket is running on 9150.
Danny's custom version of test
Could not start the VM service:
DartDevelopmentServiceException: Failed to start Dart Development Service
running root group
running child group FirebaseAdminApp...

It's not clear to me if this error is the cause (or a symptom of the same issue). It's also not clear to me why this error didn't seem to be printed when coverage isn't enabled, given coverage (as far as I can tell) doesn't change anything until the end of the suite when it tries to collect (as far as I can tell, it's collecting coverage at the end of each suite? maybe because it's per-isolate?)

given coverage (as far as I can tell) doesn't change anything until the end of the suite when it tries to collect (as far as I can tell, it's collecting coverage at the end of each suite? maybe because it's per-isolate?)

The runner does collect coverage per-isolate at the end of each suite.
It also does connect the VM service before the suite runs whenever coverage is enabled.
https://github.com/dart-lang/test/blob/2c2ac49de0e9d6ea9744c6e7990d5730806410c0/pkgs/test_core/lib/src/runner/vm/platform.dart#L123
When coverage is enabled, config.debug is true.

This is starting to impact Dart team owned repos.
https://github.com/dart-lang/yaml_edit/actions/runs/10232023033/job/28368166876#step:5:24
@bkonyi @liamappelbe - were there any other changes to the VM service or coverage collection recently?

There haven't been any significant changes to coverage. How flaky is this? Can we git bisect the VM?

FWIW I can repro this locally (from a terminal with dart test --platform vm --coverage=./coverage) using the yaml_edit repo noted above. When I hit it, I see the same "Failed to start Dart Development Service" error (although I'm not sure whether that's the cause):

I tried tracing through the code trying to understand where the VM is being kept alive (the only --pause-isolates-on-start I could see was in bin/test_with_coverage.dart but I added a print() in there and don't see it in the output, so I don't know if it's using that). I'm also unfamiliar with the pkg:test code so I couldn't tell what code runs in what process (for example is pkg:test_core's Engine.run() running in the process that is being collected, or is it spawning another process to run the tests? If it's the same process, it's odd for the VM Service to go away while code is still being executed here, but if it's another process I'm struggling to see where it's launched).

Also FWIW, I only seem to be able to repro when there is more than one suite. If I put any suite name on the end from that repo, it always works. If I run without a suite name, even after deleting all but two suites (eg. windows and wrap), then the failure occurs. This may just be coincidence because it's a timing issue, but maybe useful info 🤷♂

@bkonyi I did a git bisect, and it looks like the culprit is https://dart-review.googlesource.com/c/sdk/+/375000. The bug repro's reliably when running dart test --platform vm --coverage=./coverage in yaml_edit.

Thanks for bisecting @liamappelbe! I'll take a look today.

There was a race condition where multiple calls to Service.controlWebServer in quick succession would result in the underlying VM service URI being returned while DDS was still starting. We'd establish connections to the VM service, only to have them closed once DDS invoked _yieldControlToDDS which causes the VM service to close all direct web socket connections, which is why we were seeing the "Service connection disposed" error.
Fix up for review: https://dart-review.googlesource.com/c/sdk/+/379700


Dgromov/use watch events

Watch update function will now use most recent event data instead of re-getting the value.

Coverage increased (+0.04%) to 67.412% when pulling 5b07f6bbf82ab8753bea49dee6a6f275bffee18c on dgromov/use_watch_events into b596a86b06f37c9150ea352d6ec1549ed19f304b on master.

Coverage increased (+0.09%) to 67.461% when pulling 53aa3583ee4f0dfe471a33686422bb13ca94296a on dgromov/use_watch_events into b596a86b06f37c9150ea352d6ec1549ed19f304b on master.

Coverage increased (+0.1%) to 67.484% when pulling 1f5dbd61e792d63c9d9b923d07aef8a7fee70384 on dgromov/use_watch_events into b596a86b06f37c9150ea352d6ec1549ed19f304b on master.

Coverage increased (+0.1%) to 67.491% when pulling 0cf68215cd921344ee7779d27acfcda100dc9bbf on dgromov/use_watch_events into b596a86b06f37c9150ea352d6ec1549ed19f304b on master.


WRLD 3D Cars

This is a simple question as to the functionality...
Is it possible to purposefully render vehicles in specific locations? It may not be in built, but is it possible? Not moving vehicles, just 3D placed on the road.

At the moment it's not possible to place arbitrary 3D objects onto the WRLD Map when using wrld.js, sorry!
This is a feature that's being tracked on our backlog but we don't have it scheduled on the roadmap at present.


GreenScreen on opening

Microsoft Windows [Versione 10.0.17692.1000]
As soon as i open The bash shell i have  a green screen with lxcore.sys crashing...
I can't find a way to generate a crashdump.

+1. When I'm trying to run wsl with normal privilege, I get a GSOD on SYSTEM_SERVICE_EXCEPTION in LXCORE.SYS

Same here. FeedbackHub asked me what happened and I replied I just tried to opening Ubuntu shell. I don't know if the minidump was automatically sent at that moment though.

Typically you will find the crashdump at \windows\memory.dmp. If you could email that to us -- see CONTRIBUTING.md, it would be appreciated. If you do not see a memory.dmp file, this option can be configured in the Startup and Recovery UI of System Properties (click start, start typing "view advanced system settings" and you should see the option).

problem is that windows doesn't create it... even if i have the option enabled (tried with full dump and small memory dump 256kb)
nothing in /windows/ no minidump and no memory.dmp

I just upgraded to '692 moments ago in the hopes of getting a dump to send in, but strangely no GSOD for me. I tried ubuntu.exe and ubuntu1804.exe, both as non-admin natch. So now the game is guessing the variable that is causing some to fail and others not.

Some way to extract them ?

Our most recent instances of GSOD affecting only a small group have been related to AV software. @Ansuel - the only other reliable mechanism would be to attach a kernel debugger and capture the information from a separate device.

well... i have windows defender as AV software...

Ok I tested some things and this is what I found. All these in build 17692 with a practically clean install.
I have installed Ubuntu 18.04 in C: drive through the store and I can open it (normal and elevated) without getting any GSOD.
I also have installed some other distros in G: drive and these can be opened with "run as admin" otherwise I always get the GSOD. A repo would be:

download centos.zip from https://github.com/x-distro/x.distro/releases
unzip on a folder and "run as admin" centos.exe to install the distro. Press a key to close the window.
double click on centos.exe will show the GSOD.

So I think launching distros installed through the Store shouldn't have this issue but distros installed manually should.

look like the disto should be signed in some way and cause this sign doesn't exist in manually installed (or upgraded) dist windows goes GSOD
Open bash with elevated permission skip this check and windows doesn't crash.

I also see this issue but with BSOD and same error of LxCore.sys.
As I said in this thread https://github.com/Microsoft/WSL/issues/1744#issuecomment-395531886, there is a new option in wslconfig.exe /upgrade. This has some relation with reparse points. In my case, that option solves this problem.
Also as @Ansuel said, with admin privileges bash.exe and wsl.exe doesn't cause this BSOD. 👏 for that tip, thanks.

i can't find the wslconfig.exe /upgrade option

That optional. The "run-as-administrator" tip works well ;) OK, that upgrade option works as wslconfig.exe /upgrade <distro_name>.
What you said about the signing

That optional. The "run-as-administrator" tip works well. OK, that upgrade option works as wslconfig.exe /upgrade <distro_name>. Ssssh.... Don't say it, it's hidden 🤐
What you said about the signing is somehow true. The Appx downloaded from Windows Store has a catalog file which check the integrity of that package. So that no malware can hamper it. Did you try to run the Windows Store distributions as administrator?

i never installed bash on windows from the store.
as my  installation is present before the introduction of bash on windows in the store... i can't even use the upgrade command on the legacy distro...

@Brian-Perkins Is it possible to debug kernel in VirtualBox remotely? Not in Hyper-V please. I've seen the article (from you link) that says about remote kernel debugging with COM port in a VM.

@Brian-Perkins Is it possible to debug kernel in VirtualBox remotely? Not in Hyper-V please. I've seen the article (from your given link) that says about remote kernel debugging with COM port in a VM.

It's seem to be weird. I install build 17692 in VirtualBox and attach windbg with pipe. But there is no blue/green screen with wsl.exe or bash.exe.

@Brian-Perkins I have sent a kernel memory dump. Hope it helps to fix this issue.
For those who can't generate a memory dump, in order to generate the MEMORY.DMP I had to check "Disable Automatic Deletion of Memory Dumps When Disk Space is Low".

Those of you who are seeing this problem, can you answer two questions for me:

What's the path where you installed your distro (the Windows location of the "rootfs" folder)?
What's the output of running icacls on that folder and its parent?

Using wslconfig /upgrade may fix the issue, but at this point doing this will have a few disadvantages (most notably file timestamps will not behave correctly), and there is no way to undo this upgrade.

@SvenGroot
Also wslconfig /upgrade doesn't work in Legacy disto...
anyway my rootfs folder is here
C:\Users\Ansue\AppData\Local\Lxss (this is where i have all the data)
C:\Users\Ansue\AppData\Local\Lxss\rootfs (rootfs dir)
C:\Users\Ansue\AppData\Local\Lxss BUILTIN\Administrators:(I)(F)
                                  BUILTIN\Administrators:(I)(OI)(CI)(IO)(F)
                                  NT AUTHORITY\SYSTEM:(I)(F)
                                  NT AUTHORITY\SYSTEM:(I)(OI)(CI)(IO)(F)
                                  NT AUTHORITY\SERVIZIO LOCALE:(I)(RX)
                                  NT AUTHORITY\SERVIZIO LOCALE:(I)(OI)(CI)(IO)(GR,GE)
                                  NT AUTHORITY\SERVIZIO DI RETE:(I)(RX)
                                  NT AUTHORITY\SERVIZIO DI RETE:(I)(OI)(CI)(IO)(GR,GE)
                                  BUILTIN\Users:(I)(RX)
                                  BUILTIN\Users:(I)(OI)(CI)(IO)(GR,GE)
                                  AUTORITÀ PACCHETTI APPLICAZIONI\TUTTI I PACCHETTI APPLICAZIONI:(I)(RX)
                                  AUTORITÀ PACCHETTI APPLICAZIONI\TUTTI I PACCHETTI APPLICAZIONI:(I)(OI)(CI)(IO)(GR,GE)
                                  AUTORITÀ PACCHETTI APPLICAZIONI\TUTTI I PACCHETTI APPLICAZIONI CON RESTRIZIONI:(I)(RX)
                                  AUTORITÀ PACCHETTI APPLICAZIONI\TUTTI I PACCHETTI APPLICAZIONI CON RESTRIZIONI:(I)(OI)(CI)(IO)(GR,GE)
                                  BUILTIN\Administrators:(I)(OI)(CI)(IO)(F)
                                  NT AUTHORITY\SYSTEM:(I)(OI)(CI)(IO)(F)
                                  BUILTIN\Users:(I)(OI)(CI)(IO)(RX)
                                  NT AUTHORITY\Authenticated Users:(I)(M)
                                  NT AUTHORITY\Authenticated Users:(I)(OI)(CI)(IO)(M)

Elaborazione completata per 1 file. Elaborazione non riuscita per 0 file

@Ansuel Thanks. From what I can make out, it seems that your user account does not have the "Delete subfolders or files" permission, which is what I suspected.
What's happening is that we're hitting an access denied error, and then the error handling path has a bug which is causing the BSOD. The bug in the error handling path has already been fixed internally. However, we also shouldn't be requiring these permissions, and we will fix that too.
In the mean time, you can work around this issue by granting yourself full control of the parent of your rootfs folder:
icacls "C:\Users\Ansue\AppData\Local\Lxss" /grant "<username>:(OI)(CI)(F)"
For other people following these instructions, make sure you determine where your "rootfs" folder is located, and use its parent in the above command. It may not be in the same place as this example.

@SvenGroot Indeed It worked. I used icacls "G:\WSL\Ubuntu\" /grant "<username>:(OI)(CI)(F)" and now I can launch Ubuntu non-store version again. Thanks for the workaraound.
wslconfig /upgrade didn't stop the GSODs though and I had to reinstall the distro again.

yes can confirm the command fixed the gsod

@Ansuel @onomatopellan Thanks, that's good to hear. I'm working on the fix for the permissions issue now.

@SvenGroot Is this permission configured from Windows side or WSL side during installation? Can chmod change that permission?

The temporary work-around was posted in https://github.com/Microsoft/WSL/issues/3304#issuecomment-398489972

@SvenGroot Is this permission configured from Windows side or WSL side during installation? Can chmod change that permission?
From @Voskrese's idea, If I add SD="D:P(A;;GA;;;WD)" in diskpart and add your options "<username>:(OI)(CI)(F)" in icacls I can install WSL in a virtual hard disk (.vhd or .vhdx file).

@Biswa96 на самом деле, эти параметры я взял из инструкции, а по факту просто создал виртуальный диск, отформатировал его в NTFS и основное, после присоединения, с корня диска, через GUI параметра, задал ПОЛНЫЙ доступ для ВСЕХ. распаковал дистриб, даже 5 на сегодняшний день, и тогда у меня все заработало

In fact, these parameters I took from the instructions, and in fact just created a virtual disk, formatted it into NTFS and basic, after attaching, from the root of the disk, through the GUI parameter, set full access for all. Unpacked Distrib, even 5 to date, and then I got everything worked

@Biswa96 This is a Windows permission and cannot be set with chmod. It can only be set with icacls.exe (as shown above), PowerShell's Set-Acl cmdlet, and the Windows Explorer security UI.
Also, I'd like to reiterate that this is a bug. We should not be requiring this particular permission. I've already fixed it and we'll let you know when the fix reaches an insider build.

The permissions issue should be fixed in Insider Build 17713

The permissions issue should be fixed in Insider Build 17713

Indeed it works well again. Thanks!

But the installation requires admin privileges or to use the above icacls command.

@SvenGroot Setting FILE_CASE_SENSITIVE_INFORMATION still requires the "Delete subfolders and files" permission. Is it a security feature by design, or the bug isn't fixed yet?

Adapting the file access permissions using icacls did not help in my case.
What did the trick was to invoke the bash command from a Windows shell with admin rights.
Since then I can use WSL / bash again also with normal user rights.


Check if new api rule violation was added

What this PR does / why we need it:
Introduce a check that we don't make new api violations.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
-->
NONE

/lgtm
Very nice. :+1:

/retest

/retest


perf: jpg改为webp

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update index.html

Hi, I have added some more meta tags will help to rank this website

Always try to update and make your site latest