Bootable SD card image

Hello,
I added pre-compiled sources for LittleKernel bootloader and new image class to assembly everything up together to boot DragonBoard410c from SD card.

hi,
many thanks for sending this out! Before getting into the details, I have some general comments:

overall, the idea of building an SD card is very important.. it's been a TODO item since the beginning.. so this is important
there are too many patches in the series that shows your development history, and they are not needed. it would be simpler to review if you development history was squashed properly.
there is a mechanism in OE core called 'wic' to generate bootable images. I would prefer to investigate using WIC instead of a custom class as you did. There is a bunch of documentation in the Yocto dev manual about wic, and also sample config files for a couple of boards. Any chance you can have a look at that?

Good points. Sure, thanks for the tip about WIC. Didn't know about that, because just beginning with Yocto/OE.  I will check how to use it to build SD card image and come back later.

I used WIC to assemble SD card image, but I met 2 issues (for morty branch):

OpenEmbedded/morty is using old WIC implementation, so WKS_FILE_DEPENDS doesn't work. It's needed to deploy LittleKernel images earlier.
WIC doesn't allow to give a name for partiontion (all partitions must have specific names). Even if part's argument "--label" (in wks file) is set, name of partition is always "primary". I was not able to find any other parameter to do that. However, I have a WIC patch to fix it, but WIC is a part of different repo, so will submit it there.

I will try to find workarounds, but any suggestions are welcome.

hi,
i finally got around to try these patches. I am testing on master branch, not morty, since I would like to get the OE core patch merged first.
the recipe for firmware-qcom-dragonboard410c-bootloader-sdcard-17.09 failed with:
ERROR: firmware-qcom-dragonboard410c-bootloader-sdcard-17.09-r0 do_populate_lic: QA Issue: firmware-qcom-dragonboard410c-bootloader-sdcard: LIC_FILES_CHKSUM points to an invalid file: /home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/
dragonboard_410c-linaro-linux/firmware-qcom-dragonboard410c-bootloader-sdcard/17.09-r0/firmware-qcom-dragonboard410c-bootloader-sdcard-17.09/LICENSE [license-checksum]
Since the LICENSE is set to Proprietary, I think it's not considered critcal error.. but we still need to fix that. Looks like it's because the files are not extracted in the right folder in WORKDIR.
Then I get another error from WIC:
| ERROR: _exec_cmd: export PATH=/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/sbin:/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work
/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/usr/sbin:/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/usr/bin:$PATH;mkdosf
s -n boot -S 512  -C /home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/deploy-rpb-console-image-image-complete/rpb-console-image-dragonboard-410c-20171102102739/tmp.wic.ex0cwlxi/f
s_None.6.vfat 16 returned '1' instead of 0
| output: mkfs.fat: warning - lowercase labels might not work properly with DOS or Windows
| mkdosfs: Attempting to create a too large filesystem
| mkfs.fat 4.1 (2017-01-24)
which i have not investigated yet.

I've already investigated the second issue. On master there is no way to create empty partition. In previous (Morty) version of WIC, was a bug that allows do that.
WIC by default set fstype to vfat and moreover 'part --source' by default is boot image kind. So for sec and devinfo partitions WIC is trying to create fat partition which is failing.
To fix it, I have two ideas. One is to extend WIC by new fstype option: None. The second is to write new source plugin, similar to sourceraw, but take input from let's say /dev/zero
Thank you for your support.
Dnia 2 listopada 2017 14:02:09 CET, Nicolas Dechesne<EMAIL_ADDRESS>napisał(a):

hi,
i finally got around to try these patches. I am testing on master
branch, not morty, since I would like to get the OE core patch merged
first.
the recipe for firmware-qcom-dragonboard410c-bootloader-sdcard-17.09
failed with:
ERROR: firmware-qcom-dragonboard410c-bootloader-sdcard-17.09-r0
do_populate_lic: QA Issue:
firmware-qcom-dragonboard410c-bootloader-sdcard: LIC_FILES_CHKSUM
points to an invalid file:
/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/
dragonboard_410c-linaro-linux/firmware-qcom-dragonboard410c-bootloader-sdcard/17.09-r0/firmware-qcom-dragonboard410c-bootloader-sdcard-17.09/LICENSE
[license-checksum]
Since the LICENSE is set to Proprietary, I think it's not considered
critcal error.. but we still need to fix that. Looks like it's because
the files are not extracted in the right folder in WORKDIR.
Then I get another error from WIC:
| ERROR: _exec_cmd: export
PATH=/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/sbin:/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work
/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/usr/sbin:/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/recipe-sysroot-native/usr/bin:$PATH;mkdosf
s -n boot -S 512  -C
/home/nicolas.dechesne/work/oe-rpb-master/build-rpb/tmp-rpb-glibc/work/dragonboard_410c-linaro-linux/rpb-console-image/1.0-r0/deploy-rpb-console-image-image-complete/rpb-console-image-dragonboard-410c-20171102102739/tmp.wic.ex0cwlxi/f
s_None.6.vfat 16 returned '1' instead of 0
| output: mkfs.fat: warning - lowercase labels might not work properly
with DOS or Windows
| mkdosfs: Attempting to create a too large filesystem
| mkfs.fat 4.1 (2017-01-24)
which i have not investigated yet.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-341413847

-- Wysłane za pomocą K-9 Mail.

being able to create a partition with no fs on it, is exactly what we need on QCOM boards. so adding this feature in WIC sounds the right thing to do.
I removed sec and devinfo for now, and it worked fine, i could make the SD image with partition names:
$ sudo gdisk -l tmp-rpb-glibc/deploy/images/dragonboard-410c/rpb-console-image-dragonboard-410c-20171102135611.rootfs.wic
GPT fdisk (gdisk) version 0.8.10

Partition table scan:
  MBR: protective
  BSD: not present
  APM: not present
  GPT: present

Found valid GPT with protective MBR; using GPT.
Disk tmp-rpb-glibc/deploy/images/dragonboard-410c/rpb-console-image-dragonboard-410c-20171102135611.rootfs.wic: 2005232 sectors, 979.1 MiB
Logical sector size: 512 bytes
Disk identifier (GUID): 6A606AC1-5AEC-4AF7-975A-8EFAD268FB04
Partition table holds up to 128 entries
First usable sector is 34, last usable sector is 2005198
Partitions will be aligned on 1024-sector boundaries
Total free space is 131039 sectors (64.0 MiB)

Number  Start (sector)    End (sector)  Size       Code  Name
   1          131072          132095   512.0 KiB   FFFF  sbl1
   2          132096          133119   512.0 KiB   FFFF  rpm
   3          133120          135167   1024.0 KiB  FFFF  tz
   4          135168          136191   512.0 KiB   FFFF  hyp
   5          136192          138239   1024.0 KiB  FFFF  aboot
   6          138240          269311   64.0 MiB    FFFF  boot
   7          269312         2005197   847.6 MiB   8300  rootfs

One thing I don't like much is that now we have all these bootloaders files that sit in DEPLOYDIR... That can be confusing for users, as they are really not needed at all for anything. Is there anyway we could keep these files in a less visible place?

Good to hear that you're able to build the image, even without these two partitions.
Yes, you're right these images should be somewhere in staging dir or something similar (ie workdir). But how to pass images path to WIC recipe? In a dynamic way, so if bootloader will be upgraded these paths should be updated automatically? Don't have any ideas how to resolve it, for now.
I'm still struggling how to add empty partition feature to WIC. Adding custom plugin would be relatively easy and can be kept in meta-qcom repository. On the other hand FS none is more flexible, but probably needs bigger changes in wic in openembedded-core repo.
Dnia 2 listopada 2017 14:59:56 CET, Nicolas Dechesne<EMAIL_ADDRESS>napisał(a):

being able to create a partition with no fs on it, is exactly what we
need on QCOM boards. so adding this feature in WIC sounds the right
thing to do.
I removed sec and devinfo for now, and it worked fine, i could make the
SD image with partition names:
$ sudo gdisk -l
tmp-rpb-glibc/deploy/images/dragonboard-410c/rpb-console-image-dragonboard-410c-20171102135611.rootfs.wic
GPT fdisk (gdisk) version 0.8.10

Partition table scan:
 MBR: protective
 BSD: not present
 APM: not present
 GPT: present

Found valid GPT with protective MBR; using GPT.
Disk
tmp-rpb-glibc/deploy/images/dragonboard-410c/rpb-console-image-dragonboard-410c-20171102135611.rootfs.wic:
2005232 sectors, 979.1 MiB
Logical sector size: 512 bytes
Disk identifier (GUID): 6A606AC1-5AEC-4AF7-975A-8EFAD268FB04
Partition table holds up to 128 entries
First usable sector is 34, last usable sector is 2005198
Partitions will be aligned on 1024-sector boundaries
Total free space is 131039 sectors (64.0 MiB)

Number  Start (sector)    End (sector)  Size       Code  Name
  1          131072          132095   512.0 KiB   FFFF  sbl1
  2          132096          133119   512.0 KiB   FFFF  rpm
  3          133120          135167   1024.0 KiB  FFFF  tz
  4          135168          136191   512.0 KiB   FFFF  hyp
  5          136192          138239   1024.0 KiB  FFFF  aboot
  6          138240          269311   64.0 MiB    FFFF  boot
  7          269312         2005197   847.6 MiB   8300  rootfs

One thing I don't like much is that now we have all these bootloaders
files that sit in DEPLOYDIR... That can be confusing for users, as they
are really not needed at all for anything. Is there anyway we could
keep these files in a less visible place?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-341429627

-- Wysłane za pomocą K-9 Mail.

had a quick look , and it seems that _create_partition() can take None for fstype, it's used in direct.py for example:
            self._create_partition(self.path, "extended",
                                   None, part.start - 1,
                                   self.offset - part.start + 1)

Yes, but in filesystem creation stage it validate only through known and supported fs'es. I will take a look on that today evening.
Dnia 2 listopada 2017 16:32:30 CET, Nicolas Dechesne<EMAIL_ADDRESS>napisał(a):

had a quick look , and it seems that _create_partition() can take None
for fstype, it's used in direct.py for example:
           self._create_partition(self.path, "extended",
                                  None, part.start - 1,
                                  self.offset - part.start + 1)

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-341460011

-- Wysłane za pomocą K-9 Mail.

The issue is in this piece of code (scripts/lib/wic/partition.py):
    def prepare(self, creator, cr_workdir, oe_builddir, rootfs_dir,
                bootimg_dir, kernel_dir, native_sysroot):
        """
        Prepare content for individual partitions, depending on
        partition command parameters.
        """
        if not self.source:
            if not self.size and not self.fixed_size:
                raise WicError("The %s partition has a size of zero. Please "
                               "specify a non-zero --size/--fixed-size for that "
                               "partition." % self.mountpoint)

            if self.fstype == "swap":
                self.prepare_swap_partition(cr_workdir, oe_builddir,
                                            native_sysroot)
                self.source_file = "%s/fs.%s" % (cr_workdir, self.fstype)
            else:
                if self.fstype == 'squashfs':
                    raise WicError("It's not possible to create empty squashfs "
                                   "partition '%s'" % (self.mountpoint))

                rootfs = "%s/fs_%s.%s.%s" % (cr_workdir, self.label,
                                             self.lineno, self.fstype)
                if os.path.isfile(rootfs):
                    os.remove(rootfs)

                prefix = "ext" if self.fstype.startswith("ext") else self.fstype
                method = getattr(self, "prepare_empty_partition_" + prefix)
                method(rootfs, oe_builddir, native_sysroot)
                self.source_file = rootfs
            return

For our empty partitions, the --source parameter is undefined (None), and fstype is set as default to vfat. In this case prepare_empty_partition_vfat is called.
I think, the best solution for now is to write very simple source plugin, which override default behavior.
Can you check my meta-qcom fork based on master with part-name patch applied to openembedded-core master?

hmm. by the way, have you tried booting the SD card without sec and devinfo partitions? I believe it should work. LK will complain that devinfo is missing, but it should be harmless iirc. and sec is definitely not mandatory.
if it is working, then we could go without them for now, and check with the WIC people how to best handle 'empty' partitions.

I tried if there was a vfat created on these partitions (adjusted size to fit vfat filesystem, but kept aligning)  and it didn't work. I will give it a try (evening, don't have board on me) without sec and devinfo.

I built a WIC image using oe/master and your patches, after removing sec and devinfo and it worked fine. I could boot it. Of course i had to change mmcblk1p9 to mmcblk1p7 for the rootfs.
so, i think we should focus on that for now and keep the 'empty' partition as a separate issue. it's probably a good idea to discuss this issue on the list or the OE IRC.
I think the remaining issues for this PR are:

the LICENSE checksum issue
the fact that we pollute DEPLOYDIR with irrelevant files
of course, we need the patch in WIC to be merged.

anything else?

That's good news. I've already fixed the license issue in my forked repo.
Remaining two are still on the table.
Only one more thing to remember is to update wks file and bootloader to use mmcblk1p7. Nothing else comes to my mind(for master). In Morty there is that wks file depend... But let's discuss it later.
Dnia 3 listopada 2017 12:06:03 CET, Nicolas Dechesne<EMAIL_ADDRESS>napisał(a):

I built a WIC image using oe/master and your patches, after removing
sec and devinfo and it worked fine. I could boot it. Of course i had to
change mmcblk1p9 to mmcblk1p7 for the rootfs.
so, i think we should focus on that for now and keep the 'empty'
partition as a separate issue. it's probably a good idea to discuss
this issue on the list or the OE IRC.
I think the remaining issues for this PR are:

the LICENSE checksum issue
the fact that we pollute DEPLOYDIR with irrelevant files
of course, we need the patch in WIC to be merged.

anything else?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-341674761

-- Wysłane za pomocą K-9 Mail.

I tried to sort out the issue with polluting DEPLOYDIR. There is WIC limitation(in rawcopy.py plugin to be specific). It takes KERNEL_DIR (which is resolved to DEPLOY_IMAGE_DIR in fact) as search path for source files, so this implies to put bootloader images in WIC accessible place (deploy dir). I think, it's better to leave bootloader files in deploy dir.
Since, we want to get master working first, should I open new PR to master branch, and then use this PR to backport changes to Morty later on?

hi,
ok, thanks for looking at the DEPLOYDIR issue. it's too bad, but if we don't have any choice, let's start with that. I will discuss more with the WIC people later.
Your WIC patch for --part-name is in the master-next branch, so it might get merged soon.. you can make another PR for meta-qcom/master, and we can keep this one opened until we have a backport in oe-core..

hi,
your patch was merged this week in OE-core/master. can you please make a new PR against meta-qcom/master that we can hopefully merge?

Yes, I'll do it today. I've been doing final test with oe. If fresh build success Ill immediately open PR.
Dnia 8 listopada 2017 11:46:55 CET, Nicolas Dechesne<EMAIL_ADDRESS>napisał(a):

hi,
your patch was merged this week in OE-core/master. can you please make
a new PR against meta-qcom/master that we can hopefully merge?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-342780449

-- Wysłane za pomocą K-9 Mail.

Hello ndechesne,
Could you backport this patch to morty branch? As gumstix is now using morty branch as its stable branch, and we want to have the SD card image feature. It would be nice to have the feature upstream without applying patch locally.
Thank you.

hi,
the SD can generation depends on a new feature in WIC which we implemented
in OE/master and backported in OE/rocko, but it was not backported in
OE/morty. The following commit needs to be backported fisrt on morty:
9b60e3466e wic: add 'part-name' argument for naming GPT partitions
At this point I am not sure if the OE people would take this patch in
morty? Do you want to test and send it?
On Fri, Dec 15, 2017 at 10:51 PM, Jason Liu<EMAIL_ADDRESS>wrote:

Hello ndechesne,
Could you backport this patch to morty branch? As gumstix is now using
morty branch as its stable branch, and we want to have the SD card image
feature. It would be nice to have the feature upstream without applying
patch locally.
Thank you.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-352120970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFwv3wUInYfWCFu-o_qI5tYOccAAI-Fks5tAunygaJpZM4QCpbI
.

Hi,
Patch for it has been already submitted to oe-core list:
http://lists.openembedded.org/pipermail/openembedded-core/2017-November/144032.html
As Nicolas stated, try to ping this on mentioned thread and if they
merge it to morty, it would be possible to move forward in meta-qcom
repo.
Dnia 18 grudnia 2017 09:35:23 CET, Nicolas Dechesne
<EMAIL_ADDRESS>napisał(a):

hi,
the SD can generation depends on a new feature in WIC which we implemented
in OE/master and backported in OE/rocko, but it was not backported in
OE/morty. The following commit needs to be backported fisrt on morty:
9b60e3466e wic: add 'part-name' argument for naming GPT partitions
At this point I am not sure if the OE people would take this patch in
morty? Do you want to test and send it?
On Fri, Dec 15, 2017 at 10:51 PM, Jason Liu<EMAIL_ADDRESS>wrote:

Hello ndechesne,
Could you backport this patch to morty branch? As gumstix is now using
morty branch as its stable branch, and we want to have the SD card image
feature. It would be nice to have the feature upstream without applying
patch locally.
Thank you.
--
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-352120970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFwv3wUInYfWCFu-o_qI5tYOccAAI-Fks5tAunygaJpZM4QCpbI
.

--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or mute the thread [2].

Links:
[1]
https://github.com/ndechesne/meta-qcom/pull/48#issuecomment-352358786
[2]
https://github.com/notifications/unsubscribe-auth/AMHRK5Dx2bDWHK4dNpVIrdjEx7TzTBE6ks5tBiPLgaJpZM4QCpbI


plugins: Rename plugins_linux.go to plugins_unix.go and use build tags

This allows pkg/authorization to build on OS X.
Fixes #32192
cc @anusha-ragunathan

LGTM

Is there something we can do to catch such cross platform build broken-ness earlier? Especially for docker/docker/pkg packages? Maybe perform a go get of the list of docker/docker/pkg/ packages as part of make cross to ensure that packages builds.

This change LGTM.

@vdemeester @tiborvass : Something like this should work. https://github.com/docker/docker/commit/c4d798e76eebfdaf587fc005725c3a9af248630c. It needs some TLC, since this will reveal build errors across the board and those need to be methodically fixed.

@anusha-ragunathan should be go install

I'm happy to add the go install command to hack/make/cross in this PR if people want.

@aaronlehmann : If you add it, it'll reveal a ton of build errors we need to fix alongside. Its probably better to do it in another PR.

The only errors I found were:
pkg/term/tc_other.go:12: undefined: Termios
pkg/term/tc_other.go:17: undefined: Termios
pkg/term/term.go:23: undefined: Termios

when trying to traget Solaris.

I think the build tags in tc_other.go just need to be fixed.
// +build !windows
// +build !linux !cgo
// +build !solaris !cgo

That's !solaris OR !cgo, which doesn't make sense. It should be !solaris,!cgo instead.

However, that package isn't cross-compilable when targeting Solaris anyway because the Solaris implementation needs cgo. So if we put the go install ... line in the if [ "$GOOS" != "solaris" ]; then section, we should be good.

I've added the check.

When I export DOCKER_CROSSPLATFORMS="linux/386 linux/arm darwin/amd64", I got these errors during make cross
github.com/docker/docker/pkg/devicemapper
pkg/devicemapper/devmapper.go:85: undefined: cdmTask
github.com/docker/docker/pkg/loopback
pkg/loopback/attach_loopback.go:21: undefined: LoNameSize
pkg/loopback/attach_loopback.go:21: invalid array bound LoNameSize
pkg/loopback/attach_loopback.go:22: undefined: LoNameSize
pkg/loopback/attach_loopback.go:22: invalid array bound LoNameSize
pkg/loopback/ioctl.go:25: undefined: loopInfo64
pkg/loopback/ioctl.go:39: undefined: loopInfo64
Makefile:114: recipe for target 'cross' failed
make: *** [cross] Error 1
aragunathan@aragunathan-XPS-13-9343:~/code/src/github.com/docker/docker$ echo $DOCKER_CROSSPLATFORMS
linux/386 linux/arm darwin/amd64

These are both packages that depend on cgo but do not declare the dependency in their build tags. I've updated the PR to fix this.

LGTM (albeit after the merge)

Can we please port the fix to 1.13.* ? :)


Where is when

Loads of information on Choose but nothing on When maybe we should right some documentation.
    <choose>
        **<when condition="">**

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6ea93fcc-2885-cd2e-d73a-a2a460421b25
Version Independent ID: bf801850-22b9-e887-fd4c-f289d473663e
Content: Azure API Management policy reference - choose
Content Source: articles/api-management/choose-policy.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

https://learn.microsoft.com/en-us/azure/api-management/api-management-policy-expressions
Maybe a nice reference to something like this would help

@Matthew-Schmidt-FMG
It looks like your issue is resolved since you closed this thread.
If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Add mt5

What does this PR do?

Add support for MT5
Add MT5 inference summarization notebook

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


setup monitoring for aws queues

Description/Reasoning

want to get an alert when rabit mq is growing and transactions are not getting processed via the broadcasters.
sync with @wilcollins

Current Behaviour
Expected Behaviour
Steps to reproduce (for bugs)
Relevant Logs or Files

This can be closed as far as it is concerned for micro services


Provide a way to create AuthCredentials given an AccessToken

GoogleCredentials supports creating an instance using a temporary AccessToken.
It would be nice to support it.
We could do that by getting the token string and expiration time and adding ourselves as AuthCredentials.CredentialsChangedListener to capture token updates.

Some analysis would need to be done to see if this is still relevant.

This issue may no longer be relevant due to its age.  If you are still experiencing this issue and are reasonably certain that it is a bug, please feel free to re-open this it with enough information to help us reproduce it.


Add CSP support

Hello,
I would like to ask for a change that makes Vue Toasted add its styles in a way that does not require unsafe-inline being present in CSP. We would like to have our CSP header as secure as possible and inline styles are definitely considered a risk.
It looks like nonce-based solution would be the best (safest and probably also easiest to implement too) option.
Please see a similar request in Vue Style Loader: https://github.com/vuejs/vue-style-loader/issues/33
Thanks!

+1. It would even be enough to just not include the styles. You can easily import the styles manually in main.js:
import 'vue-toasted/dist/vue-toasted.min.css'


Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got mezzanine.pages.views.page). Pass the callable instead.

I am trying to set up a home page using index.html. In the url.py under the project level not theme, I am support to do this -
url("^$", "mezzanine.pages.views.page", {"slug": "/"}, name="home"),
for some reason, i get the above error. Is there anything i can do.
Creating homepage editable for us. In any case, I am learning to.
I have done imports as -
from __future__ import unicode_literals

from django.conf.urls import include, url
from django.conf.urls.i18n import i18n_patterns
from django.contrib import admin
from django.views.i18n import set_language
from mezzanine.core.views import direct_to_template
from mezzanine.conf import settings
from mezzanine.pages.views import page

from cartridge.shop.views import order_history

Can somebody direct me where I am going wrong. This has something to do with django 1.10
It use to be 1.9.0, it must have upgraded.
regards

i needed to add imports -
import mezzanine
then it all works. Sorry to trouble anyone.
Regards


Hashscan - Verify contract | Analysis failed

Description
When attempting to verify the contract code (0.0.4414077) after uploading the .sol directory, I encounter the following message: 'Analysis failed.' In the console, I observe the following error:
TypeError:
    <anonymous> https://hashscan.io/:4
lockdown-install.js:1:94626
    functors moz-extension://cf59f65c-2346-4d61-b1cc-8e5e4d308209/lockdown-install.js:1

AllowListGateContract.json

Steps to reproduce

Navigate to the website https://hashscan.io/mainnet/contract/0.0.4414077
Select the option to verify a contract code.
Input the contract code "0.0.4414077" for verification.
Upload the .sol directory associated with the contract.
Observe the displayed message indicating that the analysis has failed.
Open the browser console to view detailed error message

Additional context
No response
Hedera network
other
Version
v0.1.0
Operating system
macOS

Hi @se7enarianelabs, thanks for reporting.
Could you provide AllowListContract.sol ?

Sure,
pragma solidity ^0.8.0;

import "./../Structs.sol";
import "./../interfaces/IValidationGate.sol";
import "./../commons/Common.sol";
import<EMAIL_ADDRESS>import "../interfaces/IExtension.sol";

/**
 * @author  Piotr Swierzy
 * @title   AllowListGateContract
 * @dev     This is gates validates if the sender is in the allow list
 * @notice  .
 */

contract AllowListGateContract is
    IValidationGate,
    Common,
    IExtension
{
    string public constant EXTENSION_NAME = "ALLOW_LIST_GATE";

    /**
     * @notice  .
     * @dev     This function validates if the sender address is in the allow list
     * @param   params claiming params
     * @return  result  .
     */
    function validate(
        GetNFTParams memory params
    ) external payable returns (bool result) {
        bytes32 leaf = keccak256(abi.encodePacked(msg.sender));
        result = MerkleProof.verify(
            params.merkleProof,
            getConfig().allowListMerkleRoot,
            leaf
        );
        require(result, string(abi.encodePacked(VALIDATION_ERROR_MESSAGE_PREFIX, EXTENSION_NAME)));

    }

    /**
     * @dev     Updates the allowListMerkleRoot
     * @param   newAllowListMerkleRoot new value of the allowListMerkleRoot
     */
    function setConfigAllowListMerkleRoot(bytes32 newAllowListMerkleRoot) external onlyOwner {
        getConfig().allowListMerkleRoot = newAllowListMerkleRoot;
    }

    /**
     * @dev     Returns the configured allowListMerkleRoot
     * @return  bytes32 configured allowListMerkleRoot
     */
    function getConfigAllowListMerkleRoot() public view returns (bytes32) {
        return getConfig().allowListMerkleRoot;
    }

    /**
     * @notice  This hook does nothing in this gate
     * @dev     .
     * @param   params  .
     */
    function hookAfterDistributed(GetNFTParams memory params) external payable {
        return;
    }

    /**
     * @dev     Get the module name
     * @return  Module name
     */
    function getExtensionName() external view returns (string memory) {
        return EXTENSION_NAME;
    }
}

https://github.com/hashgraph/hedera-claimbox-contracts/blob/main/contracts/gates/AllowListContract.sol

AllowListContract.sol imports many other files (Struct.sol, IValidationGate.sol …) : would it be possible to have all the solidity sources ? Without them we won't be able to reproduce the pb.
Also could you describe your gestures : do you drop a single folder containing all the sources and metadata ? Or do you drop them one by one ?
Regarding these messages:
TypeError:
    <anonymous> https://hashscan.io/:4
lockdown-install.js:1:94626
    functors moz-extension://cf59f65c-2346-4d61-b1cc-8e5e4d308209/lockdown-install.js:1

I don't think they come from HashScan.
It looks like they are issued by a FireFox extension (moz-extension:// prefix): may be a wallet ?

I tried to verify the contract and everything worked (see now https://hashscan.io/mainnet/contract/0.0.4414077?p=1&k=1705394073.960688003)
I think the problem was you were using the partial json (AllowListGateContract.json) and not the complete json for metadata.
My flow was this:

clone the repo (https://github.com/hashgraph/hedera-claimbox-contracts/tree/main)
npm i
update .env
npx hardhat compile
upload the generated metadata (./artifacts/build-info/252b358f334e40c3af95650a4970edda.json)
upload all the files under ./contracts
verify

Closing this issue since the verification failure was cased by incomplete/incorrect user input.
Capturing the fact there is room for improvement in the Verification Dialog in #881


Upgrades?

Upgrades?
The package has not been updated for some time. Are there any updates missing from the original package?
Thanks

i think yes, i try use this stealth but got many red when check it


use stable dependencies

Tx for this component. We're starting to use it.
Unfortunately at this version it made our build unstable. The dependency in packag.json on "angular2": "^2.0.0-beta.0" made our application upgrade without any change on our side to angular-beta.05 which broke our build.
Please depend on fixed versions in releases. :smile:

Hi Joost,
could you please create a pull request?

@joost-de-vries does that still happen when you include a fixed dependency yourself?


Opening Time in Local / Cart shows times of next day

Expected behavior:
In the upper section of /-restaurantname-/menus, the opening time below "We are open" should show the opening times of today.
Actual behavior:
It shows the opening time of the next day.
Reproduce steps:

Adjust the restaurant location's opening times to be different between today and tomorrow.
Go to the /-restaurantname-/menus page
Check if today's time is taken

Version:
v3.0.4-beta.19
Additional Information:
I've investigated, and it seems as if the local's location class object $location in partial localBox/box_two has the DateTime of the next day. Maybe somewhere the toIso() with +1 is applied too often?
$hasDelivery = $locationCurrent->hasDelivery();
$hasCollection = $location->current()->hasCollection();

// <-- here, $location has the wrong date of tomorrow

$schedule = $location->workingSchedule($location->orderType()); // <-- schedule list itself is correct

$openingTime = Carbon\Carbon::parse($schedule->getOpenTime());
$closingTime = Carbon\Carbon::parse($schedule->getCloseTime());

I'll attach the WorkingSchedule object with 7 days open, below:

Here's the WorkingSchedule object that we have configured. Even thou today is Saturday, it takes the Sunday values:
(
    [type:protected] => delivery
    [timezone:protected] =>
    [periods:protected] => Array
        (
            [monday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 9
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 18
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [tuesday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 9
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 18
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [wednesday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 9
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 18
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [thursday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 9
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 18
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [friday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 9
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 18
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [saturday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 10
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 16
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

            [sunday] => Igniter\Flame\Location\WorkingPeriod Object
                (
                    [ranges:protected] => Array
                        (
                            [0] => Igniter\Flame\Location\WorkingRange Object
                                (
                                    [start:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 10
                                            [minutes:protected] => 0
                                        )

                                    [end:protected] => Igniter\Flame\Location\WorkingTime Object
                                        (
                                            [hours:protected] => 17
                                            [minutes:protected] => 0
                                        )

                                )

                        )

                )

        )

    [exceptions:protected] => Array
        (
        )

    [days:protected] => 7
    [now:protected] => Carbon\Carbon Object
        (
            [date] => 2020-03-21 11:05:40.050292
            [timezone_type] => 3
            [timezone] => Europe/Zurich
        )

)```

I've also noticed that not all Carbon:now() calls pass the configured timezone.

@sampoyigi, the issue can be resolved with:
Update functions getOpenTime and getCloseTime in WorkingSchedule.php:
instead of new DateTime(), which has a time different from 00:00, adjust the time with ->setTime(0, 0):
    {
		$d = new DateTime($this->timezone);
		$d->setTime(0, 0);
        $time = $this->nextOpenAt($d);

        return ($time AND $format) ? $time->format($format) : $time;
    }

    public function getCloseTime($format = null)
    {
		$d = new DateTime($this->timezone);
		$d->setTime(0, 0);
        $time = $this->nextCloseAt($d);

        return ($time AND $format) ? $time->format($format) : $time;
    }```

@salam Thanks for investigating this issue completely, much appreciated! Do you think you could submit a quick PR for this on https://github.com/tastyigniter/flame?


Question: Install chart using chart name only

Is it possible to release a chart without generating a random name or having the need to specify a name:
Requested Feature:
helm install --namespace=moo stable/moo

$ helm list
NAME	REVISION	UPDATED                 	STATUS  	CHART        	NAMESPACE
moo 	1       	Mon Oct 30 11:12:59 2017	DEPLOYED	moo-0.1.0	kube-system

$ kubectl get svc --all-namespaces
NAMESPACE     NAME                   TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)         AGE
default       kubernetes             ClusterIP      <IP_ADDRESS>     <none>          443/TCP         2d
kube-system   default-http-backend   NodePort       <IP_ADDRESS>   <none>          80:31454/TCP    2d
kube-system   heapster               ClusterIP      <IP_ADDRESS>     <none>          80/TCP          2d
kube-system   kube-dns               ClusterIP      <IP_ADDRESS>    <none>          53/UDP,53/TCP   2d
kube-system   kubernetes-dashboard   ClusterIP      <IP_ADDRESS>   <none>          80/TCP          2d
kube-system   tiller-deploy          ClusterIP      <IP_ADDRESS>   <none>          44134/TCP       2d
kube-system   moo                    ClusterIP      <IP_ADDRESS>   <none>          443:30704/TCP   2d

Because right now, it would assign it a random value, like magic-mike or if I specified the --name=moo it would be moo-moo.

This is not possible, however the moo-moo name is an ongoing discussion on how to properly fix this. See https://github.com/kubernetes/helm/issues/1186#issuecomment-317856790 for a fix which you can apply to your chart.


ListenBrainz login no longer working

Not sure what version this started in but ListenBrainz (the non-server version) no longer logs in.  Seems to be new since the rebrand but I'm not sure.

Can confirm, happening since yesterday's Google Play Store update. Trying to log into ListenBrainz causes the app to crash.

With v1.6.3, either installed through Play Store, or sideloaded from Releases page, it wouldn't work for me, either. It would just crash when I put in the info.
Downgrading to v1.6.2 (from Releases page) fixed the issue for me, so this is specifically a regression on 1.6.2
An additional, possibly related issue, is that upon upgrading to v1.6.3, my login details were mixed up. My ListenBrainz user name was listed under last.fm, my last.fm under libre.fm, and my libre.fm listed under ListenBrainz. Clearing them out and reentering worked fine.

I'm guessing these changes are the cause: https://github.com/simple-last-fm-scrobbler/sls/compare/v1.6.2...v1.6.3#diff-6832bb0fda02fa478eee5e38d292e57e

Ok. I'm off to work.
Sorry about that ListenBrainz fans.

Seems to be fixed, thanks.


To automatically remove bigger images, set removeBig to true in images.js.


Clean up the metrics reporting code

Clean up the "metrics" implementation
Define/cleanup the list of metrics to be reported
Expose the Formatters/Reporters properly
Maybe abstract it away with a default impl.?

Probably connect this to IPerformanceMonitor


[SPARK-10740][SQL] handle nondeterministic expressions correctly for set operations

https://issues.apache.org/jira/browse/SPARK-10740

Merged build triggered.

Merged build started.

Test build #42794 has started for   PR 8858 at commit a1f41b5.

Test build #42794 has finished for   PR 8858 at commit a1f41b5.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42794/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42799 has started for   PR 8858 at commit 555cf3b.

Test build #42799 has finished for   PR 8858 at commit 555cf3b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42799/
Test PASSed.

LGTM. Merging to master and branch 1.5.


Suggestion: using curdling and HTTPretty

Seems like curdling and HTTPretty are two nice libraries to use.
curdling(https://github.com/clarete/curdling) insists to be a fast, concurrent package manager for python. It looks like a considerable in-the-place replacement for pip. It might speed up debugging and deployment.
HTTPretty(https://github.com/gabrielfalcao/HTTPretty) looks like a good http mocking library to use for testing purposes.
Some tests should be worked on before actually applying these libraries on the project, but they look good.

+1
curdling seems promising.  We can utilize it for our deployment system.
I’ve tried HTTPretty several times, and it also is useful.

curdling looks good.
I wasted some hours finding and installing dependencies of python packages.
I have no idea with HTTPretty, so I will follow other's decision.

+1


feat(avm/app/managed-environment): add certificate key vault properties

Description

Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[X] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[X] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[X] I'm sure there are no other open Pull Requests for the same update/change
[X] I have run Set-AVMModule locally to generate the supporting module files.
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings

@robvangeloven Can you add a link to your pipeline?

@robvangeloven You should either update the Max test to include testing this change or create a new one. Let me know if you need help with that.

@robvangeloven Can you add a link to your pipeline?

Link here: https://github.com/robvangeloven/bicep-registry-modules/actions/runs/9952753081, though my pipeline throws an error. Looking into that

@robvangeloven Can you add a link to your pipeline?

Link here: https://github.com/robvangeloven/bicep-registry-modules/actions/runs/9952753081, though my pipeline throws an error. Looking into that

Issue was easy enough, not enough rights for the service principal

@robvangeloven You should either update the Max test to include testing this change or create a new one. Let me know if you need help with that.

Yea, I'm going to need some help with that one. I see there's no test for dnsSuffix either so I don't have anything to build upon

@robvangeloven I swear I saw this option in the docs last week, but now I'm not seeing it there: https://learn.microsoft.com/en-us/azure/templates/microsoft.app/managedenvironments?pivots=deployment-language-bicep#customdomainconfiguration
Can you confirm if this is an available option still?

@robvangeloven I swear I saw this option in the docs last week, but now I'm not seeing it there: https://learn.microsoft.com/en-us/azure/templates/microsoft.app/managedenvironments?pivots=deployment-language-bicep#customdomainconfiguration
Can you confirm if this is an available option still?

I was looking at documentation for the wrong API version.

Hey @robvangeloven, 2 suggestions from my side:

For all that is holy, please run the .Platform - Toggle AVM workflows workflow in your fork at least once to disable all workflows and avoid them being triggered upon each change in main. You can enable workflows on demand 💪
To the PR at hand, as per other comments, it would be great to get a test in as well, if possible

Sorry for the radio silence, just got back. Will pick it up asap. And yes, I shall run that script. My subscription was suddenly without credits :-P

@robvangeloven I added tests that would support your addition in my own branch if you wanted to take a look and pull them into yours: https://github.com/hundredacres/bicep-registry-modules/tree/feat/issue/2719

@robvangeloven I added tests that would support your addition in my own branch if you wanted to take a look and pull them into yours: https://github.com/hundredacres/bicep-registry-modules/tree/feat/issue/2719

Will take a look today! Sorry for the delay, it was suddenly crunch time and had zero spare time

@robvangeloven I added tests that would support your addition in my own branch if you wanted to take a look and pull them into yours: https://github.com/hundredacres/bicep-registry-modules/tree/feat/issue/2719

Added the tests in my branch :-)

@robvangeloven I added tests that would support your addition in my own branch if you wanted to take a look and pull them into yours: https://github.com/hundredacres/bicep-registry-modules/tree/feat/issue/2719

Added the tests in my branch :-)

@robvangeloven Get a new pipeline run kicked off with the latest changes so we can confirm a successful deploy.

@robvangeloven I added tests that would support your addition in my own branch if you wanted to take a look and pull them into yours: https://github.com/hundredacres/bicep-registry-modules/tree/feat/issue/2719

Added the tests in my branch :-)

@robvangeloven Get a new pipeline run kicked off with the latest changes so we can confirm a successful deploy.

Getting errors I can't place:
FailedIdentityOperation
Identity operation for resource '/subscriptions/resourceGroups/dep-avm-app.managedenvironments-amemax-rg/providers/Microsoft.App/managedEnvironments/avmamemax001' failed with error 'Failed to perform resource identity operation. Status: 'BadRequest'. Response: '{"error":{"code":"BadRequest","message":""}}'.'.
pipeline link: https://github.com/robvangeloven/bicep-registry-modules/actions/runs/10620968388

@robvangeloven
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.
Please reach out if any support is needed.

@robvangeloven We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.
Please reach out if any support is needed.

@ReneHezser
I thought I ran it, but I'll redo the steps you linked.
I'm still stuck on the issue I mentioned before though: I'm getting bad request errors when running the tests and I have no idea where they're coming from.

@ReneHezser
I thought I ran it, but I'll redo the steps you linked.

Please also update your branch. It is way behind and won't update to the newest Readme schema.

@ReneHezser
I thought I ran it, but I'll redo the steps you linked.

Please also update your branch. It is way behind and won't update to the newest Readme schema.

Hey @robvangeloven just echoing what Rene said above. Please consider pulling latest from upstream, ensure your environment is cleaned up and try rerunning the pipeline again. I see from your badge that the latest run is from 2 months ago, worth a retry 🙂

@ReneHezser
I thought I ran it, but I'll redo the steps you linked.

Please also update your branch. It is way behind and won't update to the newest Readme schema.

Hey @robvangeloven just echoing what Rene said above. Please consider pulling latest from upstream, ensure your environment is cleaned up and try rerunning the pipeline again. I see from your badge that the latest run is from 2 months ago, worth a retry 🙂

Hi @ReneHezser ,
Took a bit longer then planned, but everything is again where it should be. Still getting the bad request operation and don't really have an idea where to look:
{
    "code": "DeploymentFailed",
    "target": "/subscriptions/xxxxxxxxxx/resourceGroups/dep-avm-app.managedenvironments-amemax-rg/providers/Microsoft.Resources/deployments/df555otrxohxs-test-amemax-init",
    "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
    "details": [{
            "code": "FailedIdentityOperation",
            "message": "Identity operation for resource '/subscriptions/xxxxxxxx/resourceGroups/dep-avm-app.managedenvironments-amemax-rg/providers/Microsoft.App/managedEnvironments/avmamemax001' failed with error 'Failed to perform resource identity operation. Status: 'BadRequest'. Response: '{\"error\":{\"code\":\"BadRequest\",\"message\":\"\"}}'.'."
        }
    ]
}


chore(bbob): update lock files

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   93.00%   93.00%
=======================================
  Files          15       15
  Lines         529      529
  Branches      120      120
=======================================
  Hits          492      492
  Misses         30       30
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af63e4...0b6d397. Read the comment docs.


Expose Port as Environment Variable

Allows users to set EBB_PORT to the desired Port. Defaults to 5000 if not set.
Fixes #3
Example Docker Compose:
services:
  ebookbuddy:
    image: thewicklowwolf/ebookbuddy:latest
    container_name: ebookbuddy
    network_mode: service:vpn
    restart: unless-stopped
    ports:
      - 5010:5010
    environment:
      EBB_PORT: 5010
      readarr_address: http://vpn:8788
      readarr_api_key:<PHONE_NUMBER>
      root_folder_path: /data/eBooks/Collection/
      auto_start: True
      search_for_missing_book: True
    volumes:
      - /path/to/config:/ebookbuddy/config
      - /etc/localtime:/etc/localtime:ro

No plans to make the internal port configurable, mainly for two reasons: consistency with other repositories and a policy of only making changes when they are strictly critical to functionality. Apologies if you put significant effort into this.
As a workaround see this from @TheLazyGeekGuy
https://github.com/TheWicklowWolf/Lidify/issues/3#issuecomment-2187351431

Download and modify gunicorn_config.py with the correct local port you want, mount it as a .. file !
it does the job :)
    volumes:
      - /local_path/gunicorn_config.py:/lidify/gunicorn_config.py


add gauges for seJUNO/OSMO, seJUNO/JUNO and SEASY/OSMO pairs

Hi @JeremyParish69 @jonator can we have this mereged please?


Notebook example of lats can not define Node

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code
import math
from collections import deque
from typing import Optional

from langchain_core.messages import AIMessage, BaseMessage, HumanMessage, ToolMessage

class Node:
    def __init__(
        self,
        messages: list[BaseMessage],
        reflection: Reflection,
        parent: Optional[Node] = None,
    ):
        self.messages = messages
        self.parent = parent
        self.children = []
        self.value = 0
        self.visits = 0
        self.reflection = reflection
        self.depth = parent.depth + 1 if parent is not None else 1
        self._is_solved = reflection.found_solution if reflection else False
        if self._is_solved:
            self._mark_tree_as_solved()
        self.backpropagate(reflection.normalized_score)

    def __repr__(self) -> str:
        return (
            f"<Node value={self.value}, visits={self.visits},"
            f" solution={self.messages} reflection={self.reflection}/>"
        )

    @property
    def is_solved(self):
        """If any solutions exist, we can end the search."""
        return self._is_solved

    @property
    def is_terminal(self):
        return not self.children

    @property
    def best_child(self):
        """Select the child with the highest UCT to search next."""
        if not self.children:
            return None
        all_nodes = self._get_all_children()
        return max(all_nodes, key=lambda child: child.upper_confidence_bound())

    @property
    def best_child_score(self):
        """Return the child with the highest value."""
        if not self.children:
            return None
        return max(self.children, key=lambda child: int(child.is_solved) * child.value)

    @property
    def height(self) -> int:
        """Check for how far we've rolled out the tree."""
        if self.children:
            return 1 + max([child.height for child in self.children])
        return 1

    def upper_confidence_bound(self, exploration_weight=1.0):
        """Return the UCT score. This helps balance exploration vs. exploitation of a branch."""
        if self.parent is None:
            raise ValueError("Cannot obtain UCT from root node")
        if self.visits == 0:
            return self.value
        # Encourages exploitation of high-value trajectories
        average_reward = self.value / self.visits
        # Encourages exploration of less-visited trajectories
        exploration_term = math.sqrt(math.log(self.parent.visits) / self.visits)
        return average_reward + exploration_weight * exploration_term

    def backpropagate(self, reward: float):
        """Update the score of this node and its parents."""
        node = self
        while node:
            node.visits += 1
            node.value = (node.value * (node.visits - 1) + reward) / node.visits
            node = node.parent

    def get_messages(self, include_reflections: bool = True):
        if include_reflections:
            return self.messages + [self.reflection.as_message()]
        return self.messages

    def get_trajectory(self, include_reflections: bool = True) -> list[BaseMessage]:
        """Get messages representing this search branch."""
        messages = []
        node = self
        while node:
            messages.extend(
                node.get_messages(include_reflections=include_reflections)[::-1]
            )
            node = node.parent
        # Reverse the final back-tracked trajectory to return in the correct order
        return messages[::-1]  # root solution, reflection, child 1, ...

    def _get_all_children(self):
        all_nodes = []
        nodes = deque()
        nodes.append(self)
        while nodes:
            node = nodes.popleft()
            all_nodes.extend(node.children)
            for n in node.children:
                nodes.append(n)
        return all_nodes

    def get_best_solution(self):
        """Return the best solution from within the current sub-tree."""
        all_nodes = [self] + self._get_all_children()
        best_node = max(
            all_nodes,
            # We filter out all non-terminal, non-solution trajectories
            key=lambda node: int(node.is_terminal and node.is_solved) * node.value,
        )
        return best_node

    def _mark_tree_as_solved(self):
        parent = self.parent
        while parent:
            parent._is_solved = True
            parent = parent.parent

Error Message and Stack Trace (if applicable)
      3 from typing import Optional
      5 from langchain_core.messages import AIMessage, BaseMessage, HumanMessage, ToolMessage
----> 8 class Node:
      9     def __init__(
     10         self,
     11         messages: list[BaseMessage],
     12         reflection: Reflection,
     13         parent: Optional[Node] = None,
     14     ):
     15         self.messages = messages

Cell In[8], line 13, in Node()
      8 class Node:
      9     def __init__(
     10         self,
     11         messages: list[BaseMessage],
     12         reflection: Reflection,
---> 13         parent: Optional[Node] = None,
     14     ):
     15         self.messages = messages
     16         self.parent = parent

NameError: name 'Node' is not defined"

Description
I'm trying to new a Node class.It threw an error just like this
System Info
langchain==0.2.16
langchain-community==0.2.7
langchain-core==0.2.39
langchain-experimental==0.0.47
langchain-fireworks==0.1.7
langchain-openai==0.1.24
langchain-qianwen==0.1.17
langchain-text-splitters==0.2.1
linux
python==3.10.12

@ZXTFINAL this is a python 3.10 issue w/ type annotations -- you can fix it by changing type annotation to this
class Node:
    def __init__(
        self,
        messages: list[BaseMessage],
        reflection: Reflection,
        parent: Optional["Node"] = None,
    ):

or running it on >= 3.11
hope this helps!

Closing since not a langgraph issue -- we'll adjust the notebook


The background color of the project in the current version is inconsistent with the background color of the project when the mouse hovers over it and the background color of the theme.

Hello! Thank you for a very good theme!
The background color of the project in the current version is inconsistent with the background color of the project when the mouse hovers over it and the background color of the theme. I hope you can improve it. Thank you very much! 😜

Windows10
Microsoft Visual Studio Version 17.6.5
Version 1.0

Markdown editing background color does not match preview background color

Find reference to the border color of the mouse hover area
Output Error List foreground color does not match theme foreground color

Hope to be the best theme of the first IDE in the universe!


How is g:AutoPairsShortcutMultilineClose and the new multiline close system working out?

Some concerns were raised regarding g:AutoPairsShortcutMultilineClose and potentially the now separate multiline closure system.
For anyone out of the loop on the general subject, multiline close was moved out and into a separate keybind because it's substantially easier and less prone to false positives. In a way, it's fly mode light mode, but without the ability to revert. Internally, it joins empty lines into a space, and considers the first close character on the first non-empty line as a part of the "match". As outlined in #21, this creates balancing problems.
Just to cover all bases here, the options are:

Back insert - this would make the entire functionality resemble fly mode, except for fly mode including text when searching
Outsourcing into an explicit function call (the option I went with; possibly not the best implementation): makes it periodically usable, doesn't obstruct general pair insertion. Essentially a weak opt-in flymode
Nuke the entire feature (probable candidate if the general feedback is that it has no place in anyone's workflow)
... potentially something else?

These won't work:

Add a modifier to the pair (keyboard layouts, terminal input processing, blah blah) for multiline
File-wide balance checks to make multiline checks feasible - this option is not feasible due to the implementation. Language semantics and structures mean it's extremely complex to parse just any file and have it work. Doing this would be an entire project on its own

So for the feedback bit:
For those of you using (or trying to use it), is it working out so far? And in general (open question to anyone who feels like it), any comments on the implementation? I'm not expecting a full code review of course, I largely mean in terms of usage (or potentially lack thereof).
What about the keybind? Alternatives are welcome as long as it doesn't conflict with terminal input processing and/or keyboard layouts.
Entirely alternate implementation ideas are also welcome - everything can be changed if needed, so if the feature isn't working out for most people in its current form, it can be changed.

Maybe It't better to use let g:AutoPairsMultilineClose = 1 or 0 ....

I was really hoping for more feedback, but since I guess it isn't coming, I'll be reverting the change I made, and make an attempt at making it less awkward to use. Might still keep the changes I made as an alternative, but we'll see.
Adding a separate option to toggle it would essentially make that system redundant as well. I'll revisit the implementation details tomorrow

How can I set default: Enabled multiline close and 'Disabled multiline close' throw g:AutoPairsShortcutToggleMultilineClose when I need?

I don't understand what you mean -- can't trigger a crash when clicking the keybind defined in g:AutoPairsShortcutToggleMultilineClose or find any other obvious errors related to it

Unless you mean that, for whatever reason, "Enabled multiline close" and "Disabled multiline close" are thrown as errors instead of being printed as information, in which case, I need your vim specs (no repro in 8.2 1-3013)

I want to the default behavior is Enabled multiline close without triggering shortcut g:AutoPairsShortcutToggleMultilineClose by myself.When I restart vim, it's default setting is Disabled multiline close unless I take the initiative to trigger and switch to the Enable multiline close. In other words, I only need Enabled multiline close and set it as default.

I use the old option for that, but it's set to 0 by default. let g:AutoPairsMultilineClose = 1 in your vimrc to enable it by default

Thanks, I thought this option was deprecated.

It was - I undeprecated it. I deprecated it in the first place because it wasn't used. Now it is, again ^^"


Shadow? [Suggestion]

I've been playing with your hint.css and found that there is no way to add shadow to the hint without adding a new class... but anyways i made that simple code to add a nice shadow to the hint :)
I would like to ask if this libary is open for ppl to suggest things like this that have chance to get into the product :p
.hint--shadow:after{
box-shadow:10px 10px 10px #333;
-webkit-box-shadow:10px 10px 10px #333;
-moz-box-shadow:10px 10px 10px #333;
}

Ahh. I found a bug! The shadows should have been present in hint.css. They were to be removed from base file (hint.base.css) but got removed from both. Fixing this.

This is fixed now. You will see shadows if you are using hint.css. Thanks for reporting :)

oh well then :) Thanks man :)
Registered just for this tho :p


Improve overall design/layout

Use some fancy Bootstrap theme
Apply some CSS-magic (help needed!)
Add some no-op functions that distract the attackers a bit (e.g. pagination, more images, ...)

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

good enough for now with v1.8.0 dark layout. New logo might follow with #97.


I love this library!

I just wanted to thank you for this awesome library!  We are using it on our multiplayer game and it's awesome!  Transfering the initial game state to the client with json was over 1.5MB when using json,  with schemapack it shrunk that to just a couple hundred KB! Such a performance improvement.  And It's soooo much easier that packing your own binary messages and couting bytelengths and offsets per type ugh!!!  They way you designed the schema definitions was just perfect for our needs.     I will always recommend using this for anyone using binary over websockets.  Thanks!

Did you put the schemas on the client side? I am also using this library but I find that I need to expose the entire communication protocol to the clients. Although the performance is improved it is more vulnerable for  potential network attacks.

@crazyyi yes of course the schema is on the client, because this is a javascript game.  But this library doesn't make it any more or less secure,  because even if we didn't use schemapack the client would still be sending messages to the server via websocket using some protocol, which could be reverse engineered if someone was motivated enough no mater what.
So we did take two steps to stop people protect against cheating.

We do all validation on the server. So if someone does figure out how to send wrong imput to the server it wouldn't pass validation.
We use uglify with mangle properties by prefix so all our schema files end up just being random characters.  so insread of PLAYER.POSITION  it's xf.df.

Number 1 is the most important for any multiplayer game.  Number 2 just makes it much harder to reverse engineer,  not guarrenteed defense, but a good deterent.

Thanks for your explanation. May I ask what uglify or obfuscate library do you use? I have tried uglify plugin for webpack but it doesn't work good with ES6 syntax.


BUG: t-stats in SUR with GLS are not homogeneous deg 0

standard errors are homogeneous of degree 0 and so t-stats are not.
Fixes an issue with how the x'x matrix is constructed when using GLS

No fix yet, just a failing test.


DRAFT: Simplifying my publishing workflow

A personal goal of mine this year is to blog more often. My current flow to publish a blog post looks like this:

Open up the repo for this website in a terminal
Generate a new post from a template using a nifty script I wrote for this purpose
Write!
Commit and push the new file

The CI (GitHub Actions) will take care of building and deploying the changes.
Even though this process is fairly easy in theory, there are still some mental hoops that I have to jump through before I can start writing.

Superseded by #432.
https://garrit.xyz/posts/2024-01-06-a-better-publishing-workflow-for-static-blogs


Host gets to "reconnecting" state and then back to "active" state when there are lot of container deletes.

Server version - V0.28.0
Steps to reproduce the problem:
Had set up with 3 hosts are many containers running on these hosts.
As part of cleaning up the existing set up, deleted all the existing containers.
When the containers are being deleted and purged , I notice that the host that are in "active" state switching to "reconnecting" state . After a while , it gets back to "active" state.
Why is the host agent getting to "reconnecting" state for while there is large number of activities like purging containers ?

It could due to network latency maybe. What network did you use for the IPSec connection (public or private)?

We addressed by making the host pinging less aggressive and by adding a timeout to our docker ps calls.

Ping @ibuildthecloud

Not encountered this issue when deleting lot of containers from host. I have been able to delete the containers successfully with out the hosts getting to "reconnecting" state.


Using MM entering an order into the book but cancelling it on MM make the order stuck in open orders

To reproduce (Use a MM acct)....
Enter an order into the order ticket: (ie sell 10 at .55) and hit place sell order, when the MM sign box appears, hit cancel....this leads to the order on the trading pg and portfolio pg in Open Orders stuck spinning in a processing state...
Only refreshing the pg fixes it

fixed


Publish to PyPI

After https://github.com/SymbiFlow/fasm/pull/28

I'm slowly getting there now, see my WIP pull request at https://github.com/SymbiFlow/fasm/pull/48/files

https://github.com/mithro/fasm/runs/1836865327?check_suite_focus=true

The Windows build continues to have issues with ANTLR

This is now happening.


Deprecate the deploy action Document the folder naming structure

It would be useful to document how to translate the folder naming structure that encodes the repo_id and the workflow_id and iteration in the deploy action.
A use case would be the following:
I just found a store that should not have passed the QC and I want to see the logs of the deploy action workflow that submitted this particular job.

I think in the longterm it is better to call runner directly from gh actions, since I am at this point the only user of the deploy action.


Support impersonate service account

TL;DR
I want to utilize impersonate service account to get a secret so that we can separate permissions to get a secret from an authenticated service account by google-github-actions/auth. By doing so, we can more securely manage roles and permissions for GitHub Actions.
Detailed design
It would be good to add an optional parameter to specify an impersonate service account to the Action.
    - id: 'secrets'
      uses: 'google-github-actions/get-secretmanager-secrets@v2'
      with:
        impersonate_service_account<EMAIL_ADDRESS>
Additional information
No response

Hi @yu-iskw - this is still a duplicate of https://github.com/google-github-actions/get-secretmanager-secrets/issues/263.


Adds note to pattern matching Kata to help guide/push towards use of new features

Adds note to pattern matching Kata to help guide/push towards use of new features of 'is' instead of falling back to older features, which is possible.

+1


Electric Black: Increase selected menu item contrast with background

Fixes #3

Both of these images have "Copy" selected.
Before:

After:

Thank you for this!


Transpose operation support

I've created a port of Numpy.transpose and associated unit test to support some of our in-flight development activity utilising the new TensorStride type. The implementation supports 1D through 4D transpose / swap axes operations.
There's also a fix included for the TensorStride overflow issue #215 for your consideration.

Code coverage fails of circleci build indicate that the build and unit tests of transpose pass and coverage of transpose is 100%.  Unsure why this reports a fail however.  Thoughts?

@mbartling Can you take a look why CI fails to generate code coverage report?
@victorromeo Great work. This PR looks good to me.
As the CI fixed, we'll merge it.

Looks like it's a pretty common issue with coveralls, I'll push a fix

Rebase done. Please let me know if further changes are required.

@dboyliao once this is merged can you add “add TransposeOp” to the cgen issue tracker ?

@dboyliao once this is merged can you add “add TransposeOp” to the cgen issue tracker ?

Sure thing.
I can also add it to cgen really quick.

@dboyliao once this is merged can you add “add TransposeOp” to the cgen issue tracker ?

Sure thing.
I can also add it to cgen really quick.

Can you cross link the feature request or PR here when you’ve got it in? Whichever is easier, thanks!

Looks good on my end. Great work! @dboyliao if you agree then feel free to merge

@mbartling I need to go to hospital for a report today so may not have time for working on cgen.
But I'll do it tomorrow.
If I forget to do it tomorrow, just send me a reminder. XD

https://github.com/uTensor/utensor_cgen/issues/127


Implement "Shipyard" functions

This is the load-out screen as specified in the game design doc.
Top of screen has slots (up to 8) for ships, middle of screen has ship selection, bottom has ok/cancel.
Also display amount of user XP / gold to spend

We decided to do this in the vs screen, it's done.


Show RDF data and ShEx/SHACL/SPARQL in parallel

When using a desktop computer with a wide screen it would be nice to be able to see the RDF data pane and the ShEx/SHACL/SPARQL pane side by side in parallel.

I agree, a UI overhaul is needed for some scenarios. For now, and to avoid redundancy, I'm closing this issue so that we can discuss this in #33.


[* DateTimeV2] Timex expression for last hour is incorrect

"last hour" is currently resolved as
2017-08-01T13:01:50,2017-08-01T14:01:50,PT1H
We should add PREV before PT1H.

@tellarin, here we will add "PREV" when a Before modifier is found (along with a Duration extraction) and "AFT" (or "AFTER"?) when an After modifier is found.
This will affect also cases like "in the 5 coming minutes", "few hours in the future", "previous 3mins"...
Since all these cases are currently in the specs, should we consider adding a config flag as suggested in #2037? Or can we simply update the resolution in the specs?

Please hold on this change for now.


pythonPackages.gyp: add Xcode 10 support

Motivation for this change
Attempting to use it with Xcode 10 installed results in this:
Traceback (most recent call last):
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/bin/.gyp-wrapped", line 12, in <module>
    sys.exit(script_main())
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/__init__.py", line 545, in script_main
    return main(sys.argv[1:])
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/__init__.py", line 538, in main
    return gyp_main(args)
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/__init__.py", line 523, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/generator/make.py", line 2159, in GenerateOutput
    part_of_all=qualified_target in needed_targets)
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/generator/make.py", line 795, in Write
creating build/bdist.macosx-10.10-x86_64/wheel/hypothesis-3.66.2.dist-info/WHEEL
    self.Pchify))
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/generator/make.py", line 1190, in WriteSources
    cflags = self.xcode_settings.GetCflags(configname)
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/xcode_emulation.py", line 545, in GetCflags
    archs = self.GetActiveArchs(self.configname)
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/xcode_emulation.py", line 420, in GetActiveArchs
    xcode_archs_default = GetXcodeArchsDefault()
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/xcode_emulation.py", line 118, in GetXcodeArchsDefault
    xcode_version, _ = XcodeVersion()
  File "/nix/store/kz342hyzg84cakgh2iraz85c2xv6wn8z-python2.7-gyp-2015-06-11/lib/python2.7/site-packages/gyp/xcode_emulation.py", line 1240, in XcodeVersion
    version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0]
AttributeError: 'NoneType' object has no attribute 'groups'

The fix is updating the regex to handle version numbers with multiple digits.
This is fixed in the nodejs fork of gyp (https://github.com/nodejs/node-gyp/issues/1454) but it's not fixed upstream, even on latest master. Given that upstream gyp is pretty much abandoned since the chromium project switched to GN, it might be worth switching to use the nodejs fork.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

cc @codyopel

ping @FRidh


Adding assignedObject to TwistSubscriber, TwistPublisher, and PoseStampedSubscriber

This is a proposed fix for #113 .
However, I am not sure if this is the best way to solve it. It follows the OdometrySubscriber but introduces an inconsistency: The PoseStampedPublisher binds to a Transform, while the PoseStampedSubscriber now uses a GameObject (but could easily be changed to also use a Transform – or vice versa).
Maybe a better solution is to either use specific components for all publishers and subscribers (e.g. the ImagePublisher and ImageSubscriber use a Camera and a MeshRenderer, respectively) or use GameObjects whenever possible – maybe even adding assignedObject to the Publisher/Subscriber abstract classes.
What do you think?

Thank you again @shoeffner for this elaborated reference solution!
I just merged an own pull request #115 where public Components instead of GameObjects are used in each Publisher and Subscriber script. This should also resolve the inconsistency you mentioned above.


list index out of range when running function_extractor.py

after I successfully ran the extraction_runner.py, I got func.out as following (There is only one function because I pick connection_table_lookup which only occurs once in Katran)

Then I tried to run function_extractor.py

It shows error like this

Can I get a sense of what is going on with this?

The problem is caused by line 311 function-extractor.py. By uncommenting the print("Prossing", line), we found that the parsing does not stop when there is no line needed to be parsed.

In the corresponding func.out, there is no line after  "reals,/home/ubuntu/opened/code_annotation/Katran.commented_OPENED_katran_balancer_kern.c, 199, 0"

Also, when extracting some functions, the func.out sometimes have the line
#DUPLICATE MAP DEFNS
{#map_name,file_locations
}
Which also causes IndesError when parsing.

@qthuang This should be fixed...please pull latest code and let us know if it works?


DNN-21973: retry the search when there have exception throw during search process.

Fix #2231.

Hey Team, any update on this? thx


Input element font is incorrect on react-select example

[x ] This is a v3.x issue.
[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The font in the input box should be "Roboto", "Helvetica", "Arial", sans-serif;
Current Behavior

The font on the input box is Arial (in chrome) , MS Shell Dlg 2 (in FF)
Steps to Reproduce

This only seems to be happening on mui v3+
Your Environment

Tech
Version

Material-UI
v3.0.0

React

Browser

TypeScript

etc.

So I don't really understand why this is happening. The input is getting its style from the user agent style sheet rather than picking up any of the other styles. I'm guessing this is something to do with the way react-select puts the components together.
My rather hacky fix is to change the valueContainer style to the following:
    valueContainer: {         display: 'flex',         flexWrap: 'wrap',         flex: 1,         alignItems: 'center',         '& input': {             fontFamily: theme.typography.fontFamily         }     },

You are correct, the input font comes from the default browser stylesheet. We should make the input inherit the font.

@wijwoj The following diff can solve the issue. Do you want to update our demo? :)
https://github.com/mui-org/material-ui/blob/dbc38be469c7bc7eb5c5af400857882483a2368a/docs/src/pages/demos/autocomplete/IntegrationReactSelect.js#L227-L232
    const selectStyles = {
      input: base => ({
        ...base,
        color: theme.palette.text.primary,
+       '& input': {
+         font: 'inherit',
+       },
      }),
    };

@oliviertassinari Yup, will give it a go when I have a moment. Thanks.


Completely remove "func" from ERR state.

Use EPERM not "1" in errtest.
Add comments on error code format, update documentation.
Clean up some code in err library.
This started because I gave an obscure comment https://github.com/openssl/openssl/issues/12276#issuecomment-650166747 and I was challenged to make a PR.  So here it is.  I think this fixes #12217, but it does it by fully removing
the function name (which we removed internally anyway).

This also uses the symbolic name EPERM instead of "1" and skips the test if the value of EPERM is too big.

I don't think function strings should remain.  We don't use them, and we don't have much evidence that people do anything with OpenSSL's error code stuff in their own code.

I don't think function strings should remain. We don't use them,

Er, we don't? So if the error output shows you a function name, that's not useful? I wholeheartedly disagree.
We added this so we wouldn't have to keep using _F_ macros and their associated strings, and switched to use _func_ and similar instead. Have you forgotten?

We don't use function names

Er, we don't?

No, we don't.   We made a conscious decision to stop putting internal OpenSSL fuction names.  The func-name stuff isn't used by openssl, and won't be because of that decision.  It might possibly by useful, but there are other ways -- error-data -- to get the same thing.

@richsalz, look back at #9452.  That's the main PR that replaced the old function indicators (_F_ macros with associated strings) with the new (based on OPENSSL_FUNC).  We didn't decide to remove function indicators altogether, we only decided that we want to get rid of the old.
Now, for some reason, you want to get rid of function indicators altogether...  but that doesn't mean that "we" want that.

I'll see your #9452, and raise you #9441 :)

This is what you want .. not what we want.

Aren't many PR's what the poster wants? Shrug.
If you don't like this, just take the one small fix to test/errtest.c

#9441 doesn't in any way contradict what I've said here.

And I don't see how #9452 adds to your argument, but that's okay.  You disagree with what I'm doing here, and that's okay.    Doesn't mean that I'm wrong. :)
Almost every time OpenSSL adds something because "someone might need it," as opposed to doing something that OpenSSL itself needs it, the project gets it wrong.  YAGNI, y'all.

https://mta.openssl.org/pipermail/openssl-project/2020-July/002091.html


Connect a Cognito user with an AppSync type

This is a continuation of https://github.com/aws-amplify/amplify-cli/issues/1313 which was closed and locked without guidance on how to complete this task with Amplify.
I'd preface this with acknowledging I'm new to Amplify (and general stitching together of AWS services), so I'm sure I'm missing something simple somewhere in docs.
To reiterate the question - after using something like Amplify UI (react) to create a new user (stored as a Cognito User?), how then do you connect this user to a Data Model? I.e. one Cognito User could be the owner of many Posts - but the Cognito User is not available and seemingly unknown with regards to the Data Model? I.e. Un-queryable by GraphQL?
I'd imagine there would be a way to sync a Cognito User with a User data model, as this would almost always need to be done but can't find anything in the documentation. The original issue: https://github.com/aws-amplify/amplify-cli/issues/1313 mentions updating the docs, but doesn't a provide a link to that document?
Really hoping I can find some help on this, cheers.
Amplify CLI Version
5.0.1
What AWS Services are you utilizing?
Amplify, Amplify Admin UI, Amplify UI (react)

Hi @thathurtabit, it sounds like what you're looking for is owner based auth rules. Using the @auth directive in your GraphQL model will generate additional resolver logic and add an "owner" field to the model. We don't have a directive like @user to directly link a Cognito user and a schema type together

Ah thanks @edwardfoyle ! That sounds promising 👍 I'll give that a go and close this shortly.


There is a typo in the emanaul of the open manipulator.

There is a typo in the emanaul of the open manipulator.
So I can see erro log the log is 'see Repository not found' when I download dynamixel_workbench.git and dynamixel_workbench_msgs.git .
Please Check this point. :)
http://emanual.robotis.com/docs/en/platform/openmanipulator/
$ git clone https://github.com/ROBOTIS-GIT/dynamixel_workbench.git
$ git clone https://github.com/ROBOTIS-GIT/dynamixel_workbench_msgs.git
->
$ git clone https://github.com/ROBOTIS-GIT/dynamixel-workbench.git
$ git clone https://github.com/ROBOTIS-GIT/dynamixel-workbench-msgs.git

thank you ~


Implemented Websocket via sockets-for-pcl

Deleted all implementations (Windows Phone, ect).
Upgraded targets : .net 4.5, Xamarin, and Windows Phone 8
Implemented websocket via sockets-for-pcl

Take a good look before merging as this has some large changes.

Thanks. I will have a look at it tonite.


Nothing works in IE 11

https://yadi.sk/i/D4GQ0HVcs5pKL

A corresponding issue from babel https://phabricator.babeljs.io/T6946 which in fact was closed as invalid :(


fix(web) - AttributesPanel UI improvements, last ApplyHistory UI changes

Icon improvements on ApplyHistory panel
type icons inside of input fields on AttributePanel
other minor style fixes in AttributePanel

bors merge


Update to scaffolding submodules for dotnet tool resolution workaround

Summary of the changes (Less than 80 chars)

Update the scaffolding submodule

Addresses dotnet/sdk#2698

@natemcmaster @wli3 @vijayrkn

Once PR checks pass, feel free to merge.
FYI @muratg @mmitche @Eilon - this should resolve the last 2.2.1 bug we're expecting to take. Once it, we're ready to re-build 2.2.1

We got some test failures in the ci build, but they don't look related to scaffolding. I don't know much about this repo, perhaps someone who knows it better has a better understanding of what may have caused these errors.
Also, I don't have rights to merge in this repo, so once we're good, someone else will have to.

Test failures in HttpSys and Kestrel are known, right @Tratcher @muratg ?
Merging so we can get a 2.2.1 build going.

Yeah, I think there are issues tracking the failures. Thanks for unblocking the 2.2.1 build!


opensearch: auto index upon container start

ref: cern-sis/issues-inspire/issues/530

before it was failing if the container would go down as the index was already created.
since rebuild does not index prexisting elements, document index must be run


how do i use "?" as variables for my values so that i don't get hacked?

I was wondering how do I use question marks so that I don't get hacked because when I use this:
SQL = "INSERT INTO users (id, username) VALUES ( " + message.author.id + ", " + message.author.username + ")"
it gives me an error: Unknown column '(my username)' in 'field list'
I know you will say that there is already a post like this, but I am kinda a beginner still so I don't understand what they are saying

https://github.com/mysqljs/mysql#escaping-query-values

thnakss


Add matrix for testing

adding the matrix testing approach allows us to test it for different versions

@lukasjhan you are correct, it seems that version 18 is and lower is not supported. At this point we have to decide:

should the crypto-node package include native support with a higher version number
should it be able to use them with lower support but with the help of external libraries

I haven't looked if we can implement the whole crypto-node stuff without the subtle. Code reusage is not possible then, but on the other hand the amount of functions is small that need to be implemented

So the good news is that the node code is working fine in nodejs v16 18 and 20 :)
But I needed to outcomment the browser test since these tests seem not to be performed as a browser test, but a node test and therefore the tests failed since node subtle is not supported with all requirements.
We should try to find a solution for the browser tests to get them up and running again before merging this

Found a good solution:
according to this issue jsdom is not supporting webcrypto, therefore the tests fail for node 16 and 18. For some reasons it's possible to call it in node 20, so I added a condition that the browser tests are only run in the matrix test when it's executed with at least 20.
Since we are only using the coverage of v20, we get the full coverage support for this. Since we do not have any version specific conditions like "only run this code when you are using v16, otherwise use this".
So we can also make sure the whole code base is running on node 16. I didn't check lower since from my point of view support 3 LTS versions should be enough.

3 TLS looks good :)


We Need The Main File

Which main file ?

@hiddenWEB the code source of the script not the test

Already shared check { hiddenbase/.client }


Typing ŭ in empty paragraph crashes the app

Typing ŭ in empty paragraph crashes the app. The crash is a complete app crash, not just a Dart crash.
To insert the character in question, select the "German" keyboard and then press:

opt + u
u

The crash only seems to occur when inserting into an empty paragraph.

I filed https://github.com/flutter/flutter/issues/104578 with Flutter. There's probably something on our end that we need to fix, which I'm looking into. Nonetheless, Flutter shouldn't completely crash the app, no matter what we do in Dart.

The root cause on our end is that we're not adjusting the composing region boundaries to account for our hidden text. For example, an empty paragraph has a hidden ". " value, which tricks the IME into auto-capitalizing the first character of IME input, while still preserving our ability to detect backspaces.
As a result of this hidden text, when the user enters "¨", the IME gives us a composing region that spans [2,3]. We need to adjust that composing region to [0,1] and send it back to the IME.


Wrong nsn result when trying to parse incomplete number of country with leading digits

When trying to format incomplete numbers for "as-you-type" formatting, some countries produce wrong numbers by adding excess leading number at some stage. I were able to reproduce it only for countries with existing nationalPrefixTransformRule in metadata.
Code to reproduce
import 'package:phone_numbers_parser/phone_numbers_parser.dart';

void main() {
  final fullBermudaNumber = PhoneNumber.parse('+14412957070');
  final incompleteBermudaNumber = PhoneNumber.parse('+14412957');

  print(fullBermudaNumber.nsn); //<PHONE_NUMBER> OK
  print(fullBermudaNumber.getFormattedNsn()); //<PHONE_NUMBER> OK

  print(incompleteBermudaNumber.nsn); //<PHONE_NUMBER> WRONG (4412957 expected)
  print(incompleteBermudaNumber.getFormattedNsn()); //<PHONE_NUMBER> WRONG (4412957 expected)

  final fullUSNumber = PhoneNumber.parse('+14056343023');
  final incompleteUSNumber = PhoneNumber.parse('+14056343');

  print(fullUSNumber.nsn); //<PHONE_NUMBER> OK
  print(fullUSNumber.getFormattedNsn()); //<PHONE_NUMBER> OK

  print(incompleteUSNumber.nsn); // OK
  print(incompleteUSNumber.getFormattedNsn()); // 405-634-3 OK
}

@cedvdb Thank you for the quick response! I'll try to implement this fix and make a PR today or tomorrow.

Did you have a stab at it ?

Sorry, didn't have enough time to dive deeply into it. Tried to implement naive fix, but it feels obviously wrong and even fails for some regions (mostly British overseas territories)

Hey @cedvdb @cupofme , if possible could you provide an estimated time to fix this bug fix... because I hope you agree it's kinda a major bug..not allowing certain phone numbers.. hampering the business of all the users of the library.

@nahimilega No timeline from me. Feel free to get your hands dirty.

@cedvdb, first, thanks for this lib, so much better than using all the platform-specific stuff. Does the fix @cupofme made work for you? Happy to make a PR for it if so.

No it did not work as intended, my comment here should give a rough idea of what's going on: https://github.com/cedvdb/phone_numbers_parser/issues/35#issuecomment-1341669974 but I don't think the fix explained is entirely correct as I remember having a quick stab at it.
A PR would very much be appreciated

I see. Are there a few test cases you could provide that fail, so I know exactly what the issue is? Or is the code in the reproduction a good test?

Fixed in next version


Add Links to other languages

There are several projects that provide credstash compatibility with other languages.  These should be acknowleged & linked from the README:

https://github.com/jessecoyle/jcredstash (Java)
https://github.com/adorechic/rcredstash (Ruby)
https://github.com/kdrakon/scala-credstash (Scala)
https://github.com/gmo/credstash-php (PHP)
https://github.com/roylines/node-credstash (Node.js)
https://github.com/winebarrel/gcredstash (Go)

thanks for the ticket! addressed in #120


First Pull Request demo using git hub.

This is for demo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: saichandra27 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.