Invalid sampling data - LOD to sample from was unspecified.

Describe the bug
GPUReadbackDisps.cs :: ComputeUndisplacedPosition(...)
Using Dynamic Water Physics 2, the DWP collision provider queries the Crest Ocean collision provider for information. It seems like when the LOD changes, the PerLodData tag is not filled in. This means that the function mentioned above throws null-reference errors and the collision does not work anymore. DWP doesn't get the height collision and the object falls through the ocean.
Log
GPUReadbackDisps.cs, NullReferenceException thrown on line:
for (int i = 0; i < 4 && lodData._resultData.InterpolateARGB16(ref guess, out disp); i++)
Debug log shows the Debug.Assert text found at the beginning of the method. Call stack is:
DWP2.CrestWaterDataProvider:GetWaterHeight
Crest.CollProviderCache:SampleHeight
Crest.GPUReadbackDisps:SampleHeight
Crest.GPUReadbackDisps:ComputeUndisplacedPosition
Adding a check under the assert removes the NullReferenceException error:
`
Debug.Assert(i_samplingData._tag != null, "Invalid sampling data - LOD to sample from was unspecified.");
        var lodData = i_samplingData._tag as PerLodData;

        if (lodData == null)
        {
            undisplacedWorldPos = i_worldPos;
            return false;
        }`

But obviously the Debug.Assert is still there, which spams the Debug Log window (999+ in a second or two).
Versions
Built-in render pipeline, Unity 2019.2.9f1, Crest-8.0.0 unity package.
To Reproduce
Create Crest ocean according to quick-start guide. From DWP2, drop in the "TorpedoBoat" prefab. Add a constant relative force of -320000 in the Z direction. Attach a movable camera script and move camera as boat moves panning out then back in. After the boat moves from one LOD to another, the boat will fall through the ocean.
Platform

Editor
Windows 10 Pro 1903

Hardware
AMD Ryzen 7 2700X, 32GB RAM, AMD Radeon RX580 8GB software version 19.9.2, not overclocked.

Hi,
I've seen scattered reports of this, but never got a good repro.
On the latest version, we changed out this system for a new one which is faster and simpler and completely sidesteps this issue. In the future we will completely remove the displacement readback system.
If you're comfortable to could you try latest from master, either cloning using git or using the green 'download' button? Otherwise i can make a new release, probably on the weekend.

I'll try pulling down the repo. Is this a breaking change or does the API remain the same? Hopefully I wouldn't have to re-write the DWP2 water collision system. If it is the same interface then it should be drop-in-and-go and I'll give it a try.
Thanks!

The API changes - theres a new Query() function and it takes an array of
points to query the heights. This allows queries to be batched, and brings
the system in line with other query backends like burst jobs which require
data in batches.
What is the interface with DWP2 - do you have an array of positions to
sample?
If so, the new change simplifies things. If you only have one position at a
time, and can't easily batch them, then let me know.
On Wed, 30 Oct 2019 at 12:43, ControlAware LLC<EMAIL_ADDRESS>wrote:

I'll try pulling down the repo. Is this a breaking change or does the API
remain the same? Hopefully I wouldn't have to re-write the DWP2 water
collision system. If it is the same interface then it should be
drop-in-and-go and I'll give it a try.
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/crest-ocean/crest/issues/358?email_source=notifications&email_token=AAHFO7I3BP5JY5RMHD2IOMDQRF6QFA5CNFSM4JGS6QH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECUASMA#issuecomment-547883312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHFO7P7WTPC2NG4XHN77JTQRF6QFANCNFSM4JGS6QHQ
.

The DWP queries the heights like this:
        public override float GetWaterHeight(Vector3 pos)
        {
            if (!_initialized) return 0;

            float r = 0.2f;
            rect = new Rect(new Vector2(pos.x - r, pos.z - r), 2f * r * Vector2.one);
            collProvider.GetSamplingData(ref rect, 2f * r, samplingData);
            if (OceanRenderer.Instance.CollisionProvider.SampleHeight(ref pos, samplingData, out height))
            {
                return height;
            }
            return OceanRenderer.Instance.SeaLevel;
        }

Without digging into the third-party code, I'm not sure what generates the pos that it is looking for. I would assume that DWP could benefit from passing in the position of the normals on the underwater portion of the boat, but I don't know what kind of (major) change that would be in the DWP code.

Hm ok, thats tricky. I mailed the authors of DWP to explain why we're moving to batched queries and to get their thoughts.

I haven't heard from the authors yet.
I made an attempt at an adaptor - an object that can act as a proxy between one-at-a-time queries and the underlying system that works with batches. #362 has the changes and instructions on its use. basically, one can create the object and call GetWaterHeight a bunch of times and it will proxy the queries through to the query system.
Could you let me know what you think?

Thank you, I'll give it a try tomorrow and let you know.

@furkandinc kindly tracked down the issue and we merged in his fix in #366
In the (near) future the DWP2 authors will connect directly to the compute-height-queries. The adaptor I made in #362 is no longer necessary.


Update quickstart.rst

GuzzleHttp namespace wrong, should be Guzzle\Http

The namespace was changed in v4.0 of Guzzle.

@mtdowling Ah, my bad, I've just come across this. It's not obvious from the github namespace to use guzzlehttp/guzzle (even though admittedly it does say in the documentation the correct one)


Tracking issue for supporting multithreaded WebAssembly

I've noticed that there's a few issues related to threads lying around, so I figure it's a good idea to go ahead and open a dedicated tracking issue for various work items. The work here that needs to happen I believe is:

[ ] Cranelift needs atomics support - bytecodealliance/cranelift#582
[ ] Ensure wasmtime internal data structures are threadsafe

wasmtime_runtime::LinearMemory
wasmtime::{Store, Module, Memory} (see https://github.com/bytecodealliance/wasmtime/issues/777)
...

[ ] Design a WASI (or other) API to spawn a thread
[ ] Port an existing library to this infrastructure and prove it out.

Port an existing library to this infrastructure and prove it out.

For atomics using cg_clif to compile a heavy atomics user like veloren (through rayon) should prove it. This would not need wasmtime to be made completely threadsafe, so it can likely be faster, as it is just changing the codegen for a few intrinsics in cg_clif.

I'll gladly help with the testing as the features are added for my project.
Also note that we need implementations of the C++ ABI like __cxa_guard_acquire/__cxa_guard_release or we would get into race conditions with static vars.

I think that is only necessary for C++ local static vars. According to https://arkaitzj.wordpress.com/tag/__cxa_guard_acquire/ their constructor is only called on the first use. For this to be thread safe, __cxa_guard_acquire and __cxa_guard_release are necessary. WASM however doesn't have lazily initialized globals. Also WASM globals can only store primitive types, so atomic instructions are enough.

Wasm does support C++ global/static variables with arbitrary types; they are allocated in wasm's linear memory rather than in global variables at the wasm level. It has lazy inits, with guard variables, following the Itanium C++ ABI. Fortunately, __cxa_guard_acquire and __cxa_guard_release are defined as library functions in libcxxabi, so we don't need any new host APIs for them.

Hi @alexcrichton, is this still the current TODO list for threading support? This there a more detailed roadmap to look at?

Cranelift has support for atomics, so that checkbox should be checked.

AFAIK it's basically still relevant, yeah. I don't believe that much work has been done to implement this in Wasmtime. I believe that most atomic operations are supported in Cranelift now as-mentioned but that's just the tip of the iceberg. I'm not sure how thoroughly tested they are or whether there's some missing instructions needing an implementation. I also don't know if normal loads/stores with memory need to be updated and/or change codegen in a shared-memory world. Overall I don't think we're in the position where we can simply say Cranelift is "done" and the work is elsewhere, but I could be wrong!
There's still quite a lot to do with Wasmtime itself. Designing shared memories and how that will work has not yet been done.

I have a question when we say threading support do we mean the ability to

to start a thread from a wasm function
to be safely called from two different threads (that are started outside wasm ex. by the WASI env, eg. python)

I'm more interested in the second

@muayyad-alsadi, for the "spawning a thread" question, you might be interested in wasi-threads, which you could read about in this blog post. For the second question, I think @bjorn3 is right; I would just add that care has been taken to ensure that the API is thread-safe, mainly by using Rust's thread-safety restrictions. E.g., if you try to do something unsafe using Wasmtime's API, the Rust compiler should complain.
@alexcrichton, I think we can close this issue?

Agreed!


gaumed, didelphis

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.2
logical conflict every: 1000
sleep for: 2100s
close stale after: 24 hours
[pullrequest]
requests per hour: 120
deps=[d,g]

/trunk merge


slice and cache_range_requests: allow header override

This adds the ability to override the internal slice skip header (was hard coded to X-Slicer-Info) and the cache_range_requests ims header (was hard coded to X-Crr-Ims).

@elsloo Can you please review this?

[approve ci rocky]

This was back ported to 9.2.x in #8898.


Login form broadcasts typing to other open browsers

When typing in the login form, the username/password are automatically populated in any other browsers that are currently viewing the login page, as you type.

This is also broadcasting passwords to other browsers on invalid login attempts.

Mike the gulp node server uses browser-sync http://www.browsersync.io/ for unified browser testing, so if you are using gulp serve it uses that plugin by default and from which ever browser you are accessing the local testing URL http://localhost:3000,
You will not see this behavior if you run the UI in apache, node etc...

let me know I can close this issue..

This really deserves a prominent mention in the docs. As it is now following your instructions to set up UI will result in the bizarre behavior above (extremely alarming if you don't know what's causing it).

sure we can add this as an advice that gulp serve can have this behavior... , we will put that in our next update , closing this thread now


Fix off by one error in keccak1600-armv4.pl

Tested locally with evp_xof_test

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Closing this in favor of @t8m PR that does more..


Move deploy to scripts folder and add wpiformat

Still need to do:

Add wpiformat only once (even if there are many robot_cc_binary calls)
Fail the Bazel build if the wpiformat run was not successful

Fail the Bazel build if the wpiformat run was not successful

That would mean it would need to have some auto-run or shim around with a test.  Be explicit, and have your CI run the wrapper

Do we want to fail the 'bazel run ...' if wpiformat fails?
I think we should leave the .styleguide and .styleguide-license for the users to create

You have added a .pyc bazelrio/scripts/wpiformat/__pycache__/wpiformat.cpython-39.pyc file.
Out of curiosity, do you need to change the working directory (as I suggested), or does the script still work if you do  -f os.environ["BUILD_WORKSPACE_DIRECTORY"]? That might help avoid generating that file, so teams that don't have .pyc in their gitignore don't do the same
As for failing, I would say yes, so you should probably keep the exit() in there that I left out in my suggestion.
Something fancy to add would be --create_patch or --failure_patch_file (or whatever) optional argument to do this. Would remove one step you would have to do in your CI config, but we can kick that can down the road

Unfortunately the way wpiformat works doesn't work with passing -f os.environ["BUILD_WORKSPACE_DIRECTORY"] because of this:
def get_repo_root():
        """Returns the Git repository root as an absolute path.
        An empty string is returned if no repository root was found.
        """
        current_dir = os.path.abspath(os.getcwd())
        while current_dir != os.path.dirname(current_dir):
            if os.path.exists(current_dir + os.sep + ".git"):
                return current_dir
            current_dir = os.path.dirname(current_dir)
        return ""

But I was able to find a flag to disable python caching


Format fixes

When diagnostic fixes (from clang) are retrieved as code actions, they don't include reformatting of the surrounding code.
class LongLongLongLongLongLongClassName {
  void longLongLongLongLongFunctionName() const;
};
void LongLongLongLongLongLongClassName::longLongLongLongLongFunctionName() {}

The fix will add const and the line will be >80 chars but will not be rewrapped.

I believe this is somewhat related to #429


Update bazel to 6.5.0

Update bazel to 6.5.0, the latest maintenance version https://bazel.build/release and revert #16600
The LLVM is also currently using 6.1.5, so we are on the same major version.

LGTM if the builds pass. Thanks!

Thanks, also do you know why the extra test suite failed? https://github.com/openxla/iree/actions/runs/8086418421/job/22096503710
It shouldn't be touched by this change?

LGTM if the builds pass. Thanks!

Thanks, also do you know why the extra test suite failed? https://github.com/openxla/iree/actions/runs/8086418421/job/22096503710
It shouldn't be touched by this change?

Yeah was just looking at that. I just added those new tests. Looks flaky 🤔
That check should be non-blocking so feel free to ignore it.


simplify prow  test scripts, export KUBECONFIG

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
15e5f9763ba6aa46fd041f8275a8108ea820d6a4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
/lgtm
(without looking in depth, red and less copy pasta looks great - just expecting you carefully checked/will check the builds)

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
15e5f9763ba6aa46fd041f8275a8108ea820d6a4
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

fixes #3474


factor: Fix test build failure introduced in #1573

Looks like CI is not correctly running each crate's tests, given that #1573 was green there...

CI runs the "global" coreutils tests but doesn't currently check tests for each individual utility crate.
I think that is something that should be done, but most utilities haven't had any individual tests to perform until recently and so this hadn't come up. We should put this on the near-future agenda.

the freebsd issue is network related. I will just ignore it
warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/users/0.10.0/download`, got 504

Thanks @sylvestre

CI runs the "global" coreutils tests but doesn't currently check tests for each individual utility crate.

Fixed by #1583.


feat(730): we should add multiple language alternatives for seo

Description
Added multiple language alternatives for google indexing
**discord username: Hakan Angın#9836 **
**closes #730 **
Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.
## Things to check before creating a PR

[ ] I have inspected my topic, checked.
[ ] If it is a core feature, executed detailed tests.

Creating PR rules

[ ] PR must be created for an issue with approved tag. Otherwise PR will be rejected.
[ ] Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
[ ] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
[ ] Related file selection: Only relevant files should be touched and no other files should be affected.
[ ] Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
[ ] Clean commit history: The commits where the changes are made should be clear and organized.
[ ] Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

[ ] A new feature (a change that adds a new feature, not a breaking change)
[ ] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

How were these changes tested?
Please describe the tests you did to test the changes you made. Please also specify your test configuration.
Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

reproduce edilemiyor. vercel'e erisim yok. erisimi olan biri bakabilir.

I have checked the preview link for metadata but it looks not okay. It is always Turkish. @khnbzkrt could you please check it?

I'm looking

@oguzergul this issue fixed you can continue. Thanks for your patience 👍🙏❤


s!add twitter lsxyz9 gives error

CommandInvokeError('Command raised an exception: TypeError: can only concatenate list (not "int") to list')

Thanks for notifying me about the issue. It has been resolved :)


Code names starting with lowercase character

In OrchestraFIXLatest.xml, there is currently a handful of fields that have code names starting with a lowercase character, as opposed to all the rest of the code names (for these and all other fields) starting with an uppercase character. These codes are as follows:

PaymentMethod(492)

20 (euroSIC)

UnitOfMeasure(992)

GJ (gigajoules)
thm (therms)
kL (kiloliters)
L (liters)

EntitlementAttribDatatype(1779)

1 (int)
6 (float)
12 (char)
23 (data)

PaymentMethod(492) looks to be intentional as it matches the name of the service. UnitOfMeasure(992) appears less clear, as for example the code names for all other units with a "kilo-" prefix start with an uppercase character. EntitlementAttribDatatype(1779) seems intentional as well, but notably the names "int", "float", and "char" can clash with the types int, float, and char in many programming languages.
Is it intentional that all of the code names above start with a lowercase character?

@jvirtanen thank you for raising the question. I do not think that the case was chosen intentionally in all cases. However, it should not be an issue for FIX implementations. I assume you are referring to the "symbolic names" shown in square brackets in FIXimate. The names of the valid values can have such as ".", "(", and other special characters which would not be used as names in programming languages.

The names for variables should concatenate the symbolic name with other elements to avoid clashes, e.g. 1779_int. Many values are identical across fields, e.g. "New", "Add".
Small correction UnitOfMeasure is tag 996, not 992.

Yes, I'm referring to the symbolic names (which match the name attribute of a fixr:code element in FIX Orchestra, hence the "code name" term I chose above).
I agree that the symbolic names shouldn't cause problems in practice. In my use case in Java, I define a final field for each value, using the symbolic name as the variable name. An example:
/**
 * Values for TimeInForce(59).
 */
public static class TimeInForceValues {

    public static final char Day               = '0';
    public static final char GoodTillCancel    = '1';
    public static final char AtTheOpening      = '2';
    public static final char ImmediateOrCancel = '3';
    public static final char FillOrKill        = '4';
    public static final char GoodTillCrossing  = '5';
    public static final char GoodTillDate      = '6';

}

For EntitlementAttribDatatype(1779), I currently have a special case in place to replace the symbolic names "int", "float", and "char" with "Int", "Float", and "Char" as int, float, and char would not be acceptable variable names. However, I'm also thinking if it would make more sense to just capitalize the symbolic names for all values, affecting also the other symbolic names starting with a lowercase character in the initial issue comment above.

@jvirtanen thanks for the additional information. Changing symbolic names after they have been published may cause existing applications to break, i.e. I am reluctant to go down that path to remove this obstacle for the current cases. We will make sure that we do not get additional cases going forward. However, I will bring this issue to the attention of the FIX GTC for discussion.
Could you add "_" as a suffix in general to avoid the problem? That would remove the need for a special handling of EntitlementAttribDatatype(1779).
Another question: are you declaring all of these variable as public in order to use them elsewhere? How do you handle/avoid symbolic names that are not unique across FIX fields? If you generate all of these classes, you will have such cases.

@kleihan I understand. To keep things as close to the specification as possible, I decided to keep the aforementioned special case ("char" to "Char" etc.) for the symbolic names in EntitlementAttribDatatype(1779) that clash with Java keywords and avoid altering any other symbolic names that start with a lowercase character.
In Philadelphia, these variables are declared as public so that applications using the library can refer to them. They are scoped within Java inner classes to avoid name clashes between symbolic names for different fields. For FIX 4.2, the fully qualified Java name for the value Side(59) = 1 (Good Till Cancel) is as follows:
com.paritytrading.philadelphia.fix42.FIX42Enumerations.SideValues.GoodTillCancel

With static imports in place, application code referring to this value typically looks like this:
message.addField(TimeInForce).setChar(TimeInForceValues.GoodTillCancel);


Add highlight-todo-comments

This feature will highlight // TODO comments in order to make them easier to see
I apologize for the high number of commits for such small feature, but I'm not too experienced with this kind of stuff 😬
Test URLs
https://github.com/iGabyTM/arcane-vouchers/blob/72f194e8866ce363ed93a827ccd058c60909a874/plugin/src/main/kotlin/me/gabytm/minecraft/arcanevouchers/items/ItemCreator.kt#L113
https://github.com/iGabyTM/arcane-vouchers/blob/72f194e8866ce363ed93a827ccd058c60909a874/plugin/src/main/kotlin/me/gabytm/minecraft/arcanevouchers/api/events/VoucherRedeemEvent.kt#L8
Screenshot
Working with permalinks to lines of code

Working with the code search function

And directly in the file explorer

This was requested in https://github.com/refined-github/refined-github/issues/2634 a while back but was eventually closed. I’m still unconvinced that this should be added to Refined GitHub

As mentioned in https://github.com/refined-github/refined-github/issues/2634#issuecomment-716287592, the information you're looking for is better highlighted by your linter and GitHub Actions. This can be seen in https://dev.to/jnybgr/how-to-visualize-eslint-errors-on-github-3f8p

This only applies to PRs however, and maybe commits, but not files.
For files, like https://github.com/iGabyTM/arcane-vouchers/blob/72f194e8866ce363ed93a827ccd058c60909a874/plugin/src/main/kotlin/me/gabytm/minecraft/arcanevouchers/items/ItemCreator.kt#L113, you can paste the CSS I provided earlier in Refined GitHub’s CSS field:
.pl-c[data-code-text^="// TODO:"] {color: yellow}

It's also likely that within the end of the year, the CSS above will work across the site, effectively applying the whole proposed feature in one line.


Fix phone number formatting in emails

Fixes phone number formatting in email templates.
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-2082 [Lush] broken e-mail


Docs website down

Describe the bug
I can't access the docs: dev.neovim.pro/lspsaga/  is down
Steps to reproduce
Go to https://dev.neovim.pro/lspsaga/
Expected behavior
Be able to view the website :)
Neovim version (nvim -v)
NVIM v0.9.1
lspsaga commit
not relevant
Terminal name/version
Not relevant

duplicate #1221   use nvimdev.github.io


Fixed NullPointerException with Cppcheck < 1.89 caused by missing 'column' attribute in XML result

Fixes #71.

@firewave This looks good to me. Feel free to merge when you feel its ready and I'll push a release. Thanks!

I've updated to cppcheck plugin version 1.6.2 in CLion and confirmed the fix.  Thank you!

I've updated to cppcheck plugin version 1.6.2 in CLion and confirmed the fix. Thank you!

@james-cxx Thanks for the confirmation.
And consider moving on to a newer version of Cppcheck if possible as more than 1400 tickets have been addressed in the latest version compared to the one available on ubuntu 18.04.


Mitigate https://github.com/kubernetes/kubernetes/issues/96635 in load test

Mitigates https://github.com/kubernetes/kubernetes/issues/96635 in load test.
Currently if the following scenario happens:

We delete deployment X
We delete configmap used by deployment X
Any node restarts (which is possible in 5k scale)
The node will not be able to delete pod in deployment X due to https://github.com/kubernetes/kubernetes/issues/96635

With this mitigation, we delete configmaps/secrets only when we already know that all pod using that pod have been deleted.
Ref https://github.com/kubernetes/perf-tests/issues/1575
/assign @jkaniuk

/lgtm
/hold on one comment

/lgtm

/hold cancel
The comment has been addressed


[6.0][Concurrency] Implicit global actor attributes imply Sendable.

Explanation: Sendable derivation was only checking for explicit global actor attributes, meaning types that have inferred global actor isolation did not have an implicit conformance to Sendable:
@MainActor protocol P {}

class NotSendable {}

struct S: P {
  var ns: NotSendable
}

struct TestSendable: Sendable {
  var s: S // error: stored property 's' of 'Sendable'-conforming struct 'TestSendable' has non-sendable type 'S'
}

This change looks at inferred isolation rather than looking for global actor attributes attached to the type.

Scope: Only impacts types that conform to protocols with global actor attributes.

Risk: Low; Sendable inference on concrete types typically only lifts limitations under complete concurrency checking / Swift 6 mode.

Testing: Added new tests.

Reviewer: @ktoso

Main branch PR: https://github.com/apple/swift/pull/73666

@swift-ci please test

@swift-ci please test


The _detail and _internal namespace should be the last one in the chain of namespace following SDK design precedence

We currently have types in headers that are in the _detail namespace which contain sub-namespaces like Cryptography.
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/tables/azure-data-tables/inc/azure/data/tables/internal/cryptography/url_encode.hpp#L12
The existing precedence in the SDK is that _detail/_internal is the last component of the namespace.
See examples:
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp#L18
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/core/azure-core/inc/azure/core/internal/credentials/authorization_challenge_parser.hpp#L15-L16
cc @RickWinter

I have fairly strong feelings about this rule - the "_detail" and "_internal" being terminal namespaces can be incredibly limiting - it precludes the ability to express internal-only C++ namespaces - namespaces which should NEVER be exposed to customers.
For instance, this rule requires that the RustInterop namespace (which should NEVER be exposed to customers) appears as a direct child of Azure::Core::Amqp - and that implies that the RustInterop namespace is intended to contain public types (and top level public types as well). It would be incredibly easy to accidentally forget to put the types in that namespace in the _detail sub-namespace and thus accidentally expose those types.
But by putting the entire RustInterop namespace under a _detail namespace, it means that it is much harder to accidentally expose types in that namespace.
For both of the Core::Cryptography and Core::Credentials namespaces listed above, there ARE public APIs in the Credentials and Cryptography namespace. So in the case of namespaces which are supposed to contain public types, using a terminal _internal and _detail namespace makes complete sense.
But it doesn't necessarily make sense for Tables::Cryptography or Amqp::RustInterop, where there should never be any public types in the namespace.

That's a very interesting point. Thanks for sharing the concrete example motivating an exception where requiring _internal/_detail as a terminal namespace can pollute the set of public namespaces.
Would it be okay with you if I propose the wording in the C++ guidelines to capture the nuance of our stance, and drive this conversation to conclusion? I think we can carve out a reasonable exception to the rule.

FYI, the additional nuance you shared @LarryOsterman (for the exception cases) would need to be reconciled with our previous guidance when we designed and shipped v1:
https://github.com/Azure/azure-sdk-for-cpp/issues/1789
#### Detail namespaces
The detail namespace is implementation that is internal to the package (i.e. service).  These are implementation details and can change at any time without notice.
DO NOT expose `::_detail` namespace to customers in public headers or return types.  Where possible the _detail namespaces should reside in private headers.
Each package can define _detail namespace(s) as they see fit under one condition.  The _detail namespace must be the last namespace in the namespace chain.

Example:
`<service>::<somenamespace>::_detail` is valid

`<service>::_detail::<somenamespace>::` is invalid

I'd be interested in seeing that rule.
My personal version of it is (which is consistent with previous guidance)

Types which are not expected to be consumed outside the current package should contain the namespace "_detail" in the name.
Types which are expected to be consumed by other packages in the Azure SDK should have "_internal" in their name.
If a namespace contains public types, then _internal and _detail types must be in a namespace under the public namespace.
Types which are intended to be consumed by clients outside the Azure SDK MUST NOT have "_internal" or "_detail" in their name.

The 3rd bullet encapsulates the current guidance, except for the final sentence (which I assert is excessively limiting).

That's a very interesting point. Thanks for sharing the concrete example motivating an exception where requiring _internal/_detail as a terminal namespace can pollute the set of public namespaces.
Would it be okay with you if I propose the wording in the C++ guidelines to capture the nuance of our stance, and drive this conversation to conclusion? I think we can carve out a reasonable exception to the rule.

I can't recall why we settled on this being the "final" part of the namespace. It does seem overly restrictive.
Looping in @vhvb1989 in case he recalls context on why it had to be the last part of the namespace.

IIRC at a time we discussed them, there was no strong reason for _detail/_internal to be the terminal namespaces, we just decided, to start with do X::_detail until we find out we need _detail::X, and that is it.
We could at least say, until there is no Azure::Widget::X namespace, there can be Azure::Widget::_detail::X namespace. After that, it becomes confusing, whether it is X::_detail, or _detail::X, plus Azure::Widget::_detail::X would have to refer to Azure::Widget::X::Class as X::Class, while Azure::Widget::X::_detail does no need any namespace prefix - it could just refer to it as X.

Yeah, I remember looping thru this issue for a while and having everyone agree on the structure and valid usage of it.
It's mostly blurry to me now, but we did not have @LarryOsterman back then. It might've been a design choice between Rick and Jeff back then. But maybe a good time to re-validate?


bug issue

Steps to reproduce
RenderBox was not laid out: RenderPhysicalShape#ee0e4 relayoutBoundary=up2
'package:flutter/src/rendering/box.dart':
Failed assertion: line 2164 pos 12: 'hasSize'

Expected results
open alert dialog but not open
Actual results
RenderBox was not laid out: RenderPhysicalShape#ee0e4 relayoutBoundary=up2
'package:flutter/src/rendering/box.dart':
Failed assertion: line 2164 pos 12: 'hasSize'
I get that issue
Code sample
void _showRepeatDialog() {
  showDialog(
    context: context,
    builder: (BuildContext context) {
      return StatefulBuilder(
        builder: (BuildContext context, StateSetter setState) {
          return AlertDialog(
            title: const Text("Select Days"),
            content: Container(
              constraints: const BoxConstraints(
                maxHeight: 300, // Limit height of the dialog content
              ),
              child: SizedBox(
                width: double.infinity, // Ensures the ListView uses the available width
                child: ListView.builder(
                  itemCount: daysOfWeek.length,
                  itemBuilder: (context, index) {
                    return CheckboxListTile(
                      title: Text(daysOfWeek[index]),
                      value: repeatDays[index],
                      onChanged: (bool? value) {
                        setState(() {
                          repeatDays[index] = value ?? false;
                        });
                      },
                    );
                  },
                ),
              ),
            ),
            actions: [
              TextButton(
                onPressed: () {
                  Navigator.pop(context); // Close dialog without saving
                },
                child: const Text('Cancel'),
              ),
              ElevatedButton(
                onPressed: () {
                  Navigator.pop(context); // Close dialog and save changes
                  setState(() {}); // Update the main UI
                },
                child: const Text('OK'),
              ),
            ],
          );
        },
      );
    },
  );
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
RenderBox was not laid out: RenderPhysicalShape#ee0e4 relayoutBoundary=up2
'package:flutter/src/rendering/box.dart':
Failed assertion: line 2164 pos 12: 'hasSize'

@DrCreation
Please provide complete runnable reproducible code sample (ex: main.dart) and flutter doctor -v.
https://stackoverflow.com/help/minimal-reproducible-example


#350: Improve logging practices in BaseGrpcTransport and GrpcChannel

Codecov Report
Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (2984ceb) to head (5f06815).

Files with missing lines
Patch %
Lines

...ain/java/tech/ydb/core/impl/BaseGrpcTransport.java
16.66%
5 Missing :warning:

...main/java/tech/ydb/core/impl/pool/GrpcChannel.java
33.33%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #351      +/-   ##
============================================
- Coverage     47.22%   47.21%   -0.02%
  Complexity     1750     1750
============================================
  Files           311      311
  Lines         12502    12501       -1
  Branches       1237     1237
============================================
- Hits           5904     5902       -2
- Misses         6139     6140       +1
  Partials        459      459

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add ProxyTag and static memory location tagging for cudagraphs

This is one of the outcomes of the design discussion re #981 .
We add a ProxyTag mechanism (with registration) and introduce STATIC_MEMORY_LOCATION as the first tag.
We then use this tag for knowing the static inputs in the CUDAGraph transform.

I'll send a follow-up blocking double registration.

Don't know what the CI wants there. :/

I guess I have a question here, what happens if the proxies are changed in some transform before they get a chance to be used? How do we intend to keep track of that?
CC some more people for visibility of this new feature
@IvanYashchuk @mruberry @kshitij12345 @kiya00 @crcrpar

I guess I have a question here, what happens if the proxies are changed in some transform before they get a chance to be used? How do we intend to keep track of that?
CC some more people for visibility of this new feature @IvanYashchuk @mruberry @kshitij12345 @kiya00 @crcrpar

Would you file an issue for this so we can track the discussion?


To work with python3

Change only line 88 to explicite cast from int to string.

I also had to make this change to support Python 3.I was thinking of doing a PR and it seems we already have one . Could the contributors approve this pull request ?


[BEAM-9019] Remove BeamCoderWrapper to avoid extra object allocation

It simplifies #10450 by removing the extra wrapper object allocation to instead reuse the already wrapped Coder and delegate the coding/decoding work to existing methods in CoderHelpers.
R: @echauchot

Run Spark StructuredStreaming ValidatesRunner

Run Spark StructuredStreaming ValidatesRunner

Run Spark StructuredStreaming ValidatesRunner

Updated with the requested change. PTAL @echauchot I rebased it accidentally but you can check the requested change in the latest commit.

Run Spark StructuredStreaming ValidatesRunner

manual merge for minor final touches.

Thanks, next time please let's discuss about squashing the commits and do not take that decision in your side, I am surprised you did this considering how picky you are about not squashing your own commits.

@iemejia I discussed it in the PR see my comment of 01/06. As you did not comment I thought it was ok.
Regarding my own commits: I apply the same rule remember that in the previous PR that you reviewed I also suashed all my refactoring commits into one!

Seems I missed the message. In any case you could have requested it again or remind me to do it, no need to take actions like that without discussing before.


Problems with running the new all-the-mods8 version

Describe the problem
Hey, first i wanna thank you for this amazing docker project!
I have following problems, if i install the normal all-the-mods-8 server everything seems fine, but when i try to join, it gives me following errors with the "Hexerei-0.3.2" mod.

Container definition
version: "3"

services:
  allthemods:
    image: itzg/minecraft-server:latest
    ports:
      - 25565:25565
    environment:
      EULA: "TRUE"
      MEMORY: "13G"
      TYPE: "AUTO_CURSEFORGE"
      CF_API_KEY: "API_KEY"
      CF_PAGE_URL: "https://www.curseforge.com/minecraft/modpacks/all-the-mods-8"
    tty: true
    stdin_open: true
    restart: unless-stopped
    volumes:
      - ./server-data:/data

Container logs
No response

It looks like hexerei is one that needs to be manually downloaded, looking at the logs:
2023-06-25T17:10:12.935399592Z [mc-image-helper] 17:10:12.935 WARN  : The authors of the mod 'Hexerei' have disallowed project distribution. Manually download the file 'hexerei-<IP_ADDRESS>.jar' from https://www.curseforge.com/minecraft/mc-mods/hexerei and supply via downloads repo or separately.
2023-06-25T17:10:12.940889707Z


how to train on my own dataset?

It's described at https://github.com/yuanming-hu/exposure#training-on-your-own-dataset


[Feature Request] Send "Clear-Site-Data" during the admin user login

Problem
One of the most common requests that we constantly get from concrete5 clients is:
"I am logged in to the site but the editing controls disappeared on a specific page, can you please update the content there."
I need to instruct them over and over again "please force refresh the page" and I need to Google them the instructions to do so under each OS and each browser. I have also written these same instructions to a bunch of user manuals (which people do not read when they pay for support).
Then after I have instructed this, I get a "thank you!" reply and week after that they email or call me about the exact same problem (but now it's on a different page).
Technical explanation
This relates to having the site cache enabled on the site which greatly improves the user experience for the site visitors.
Particularly with the cache enabled this is related to the c5 in-context editing where the URL for the editing view is 100% the same as the URL for the site visitors.
Solution
How about sending the Clear-Site-Data header to the admin users' browser when the users have logged in to the site:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data
This would clear the browsing data associated with the given website.
Seems to be supported by most modern browsers. For the rest, well I just keep on googling them the force refresh instructions.

We'd send this on the login_complete endpoint? That makes sense to me; I agree, on sites with full page caching enabled it can be a real challenge to get the browser to realize that things have changed.

Pull requests:

v8 - #8490
v9 - #8491

I'll also copy what I wrote in the first PR's description here:

Please note that at least with Chrome, this only works for secured connections, so make sure your site is running under https to test this. It will only work then.
Alternatively, you could try marking your development domain as secure (may or may not work):
chrome://flags/#unsafely-treat-insecure-origin-as-secure

We actually implemented this and merged in the link pull requests.
However, I've had to disable this in the core. This makes logging in take 20-30 seconds under some circumstances, which is obviously unacceptable. If browsers figure out how to do this asynchronously at some point we can look to re-enable this.
Thanks for all the work you've put in on this over the years.


Not falling to fallback lang (default locale) if file does not exist in locale path

Describe the bug
Let's say I have someComponent.json file under en (which is the default locale) directory, If I dont have same file (even empty) under other languages, it will not fall back to the default locale translations.
Occurs in next-i18next version
8.1.0
Steps to reproduce
just delete (or dont create) translation file under locale different then the default locale
Expected behaviour
Fallback to default locale translations
Screenshots
As you can see, the cookies modal has text (from default locale) because it takes it from common.js (which I created under that locale with empty object)
while the rest are not resolved at all.

OS (please complete the following information)

Device: Mac OS 10.15.7
Browser: Chrome Version 89.0.4389.72 (Official Build) beta (x86_64)

Additional context
I tried to upgrade to 8.1.1 but there are other issues there (it mix text from default locale and current locale where I do have text and it shouldnt mix/take from default locale)

You are able to pass any i18next options in that you'd like. next-i18next is just a thin wrapper over i18next. Good luck!

You are able to pass any i18next options in that you'd like. next-i18next is just a thin wrapper over i18next. Good luck!

@isaachinman I did pass fallbackLng and other options as well, nothing worked...

@ronfogel The config options available to you are the exact same which are available to next-i18next. As I said, it's just a thin wrapper. Perhaps you should open an issue on the i18next repo?


[Precision Problem] about the IRHeader when using pack and unpack

header = mx.recordio.IRHeader(0,[0,1],0,0)
print header.flag # 0
s = mx.recordio.pack(header, '')
header, _ = mx.recordio.unpack(s)
print header.flag # 2

The header.flag will be changed when the label is a list(according to the length of the list). is that a feature or bug?

And another "Feature" here:
header = mx.recordio.IRHeader(2,[33511722.0, 33511805.0],1,0)
print header.label # [33511722.0, 33511805.0]
s = mx.recordio.pack(header,'')
h, _ = mx.recordio.unpack(s)
print h.label #  array([33511722., 33511804.], dtype=float32)

It is so wired that the label in header can change automatically.
Which takes me two days to debug my code. orz

ok, after some digging into the source code, I figure it out. the code here
https://github.com/apache/incubator-mxnet/blob/225f71f744ac5e7bd29868b6d3ba0e4fe2527c43/python/mxnet/recordio.py#L338
using the np.float32, but somehow 33511805.0 this number will be changed when use such kind of dtype. change to np.float64 may solve the problem.

And about the IRHeader. Document here says that

flag (int) – Available for convenience, can be set arbitrarily.

but in fact, it is really according to the label length.

Thanks for submitting the issue @huyangc
You can use discuss.mxnet.io for discussions on MXNet with the community
For your question could you please follow the format posted in the issue template for submitting the issue? Posting details about your dev environment will be helpful for us to debug as well.

@mxnet-label-bot[Question]

@huyangc indeed the issue is with the conversion from float64 to float32.
If you use instead:
header = mx.recordio.IRHeader(2,np.array([33511722.0, 33511805.0], 'float32'),1,0)
print(header.label) # [33511722.0, 33511805.0]
s = mx.recordio.pack(header, bytes("", "utf8"))
h, _ = mx.recordio.unpack(s)
print(h.label)

you get
[33511722. 33511804.]
[33511722. 33511804.]

@ThomasDelteil Thanks, I need to use a nparray when construct an IRHeader.
Help a lot !

@huyangc I also encounter the same problem, header.flag changed after pack, how to solve this?

@HaoLiuHust you can change the type of irheader to be np.float64 and change the 4 to be 8 with pack and unpack will solve the problem

But this can only solve the problem of too big of the digit but not the flag problem, I think the flag problem is because of the design.

@huyangc yes, I have read the code too, if we want to use it as we want, we can write a custom pack and unpack

This bug has not been solved even today !!!
The flag will change its value when the label is of str type. Specifically, when we use:
header = mx.recordio.IRHeader(0,'2', idx, 0)

, and pack it to MXIndexedRecordIO. After unpacking we will get flag=1!


Some tooltips in the editor are black

Godot version
v4.0.rc.custom_build [4a2c2170b]
System information
Linux X11 Xfce
Issue description
Some tooltips in the editor appear black.

Apparently not all tooltips have this problem.

I would expect, that all tooltips show their content.
Bisecting lead to #72387
Steps to reproduce
Hover the mouse over CanvasItem-Editor Icons.
Minimal reproduction project
Happens in the editor

Will look into it right now.


Support for comments

Hi.
Thanks for the plugin.
Any plans to support comments? It would be great to have both full-line comments and end of the line comments.
End-line comments could go to a specific string, as a separate column - to provide some tips and context for translation.
Full-line comments could help separate sections in the strings files

Hi AAverin,
No problem, I was having a problem doing translation for my company app so I wrote this hastily. Hopefully it can help others as well.
About the comments feature, great idea!
CSV to XML with comments should be okay, I'll add them in the future if I'm free enough
XML to CSV with comments however, that one will have to wait abit longer.
Perhaps you can help in improving this tool by sending in a pull request. :)


⚠ Bofrost.de has degraded performance

In 3188843, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1622 ms

Resolved: Bofrost.de performance has improved in c33b24c after 1 hour, 17 minutes.


When will Horizon release to the UI?

Hey folks,
Curious when this theme will be available to pick from the theme editor, or is that maybe not part of the plan? Reading it was supposed to be released Q3 2022.
https://www.swell.is/blog/announcing-horizon-theme

Plans for our current theme editor have changed a bit and it's likely we will deprecate it in the near future, in favor of streamlining the effort to host Horizon (or any other storefront app) with a service like Vercel or Netlify. Most Swell users already do it that way.
Stay tuned for an update on those plans.

Thanks for clarifying!


PIRK-24: JMH and Pom, exclude benchmark classes and jmh jars from being packaged into uber jar

Changed the  of JMH dependencies to "provided", that excludes the jmh jars from being packaged into the uber jar
Added maven-jar-plugin and excluded "org/openjdg/jmh/" to exclude jmh generated classes and also excluded "org/apache/pirk/benchmark/" to exclude the PIRK benchmark classes that use jmh.


phone-number: Tests don't seem to match problem description.

According to the README file:
The format is usually represented as
(NXX)-NXX-XXXX

where N is any digit from 2 through 9 and X is any digit from 0 through 9.
This implies that the first digit [and the 4th digit] of the 10 digit number CANNOT be 1, but the tests all use numbers that translate down to<PHONE_NUMBER>.

Thanks for opening this issue, @derifatives!
The tests and the the description where recently changed by exercism/x-common#745, but the Haskell track hasn't yet adapted to the new test data.


ojdkbuild 13.0.3-1

Java 13 equivalent of https://github.com/microsoft/winget-pkgs/pull/810.
Microsoft Reviewers: Open in CodeFlow

Apparently all resolved now too :)


Add-on has gone

Hi Dave, for some reason the add-on had disappeared from my google sheet and I cannot see it listed on the google marketplace. Have you removed or renamed it.
Thanks, Paul

Possible duplicate of #89


Dynamically loaded fonts not working correctly until app reloaded

I tried to load the font after app has started but even after calling set state on widget, font not loading correctly into text widget.
Future<ByteData> loadFont(String path) async{
  File file = File(path);
  Uint8List bytes = await file.readAsBytes();
  return ByteData.view(bytes.buffer);
}

var custom = FontLoader('Pacifico');
custom.addFont(loadFont("/storage/emulated/0/Download/Pacifico-Regular.ttf"));
await custom.load();
setState(() {});

Does this mean font has to be loaded when main function starts ?
If yes then whats the point of dynamically loading font? Because even when font is dynamically loaded, it won't be active until app is restarted.
Currently dynamically loaded fonts works only under 2 circumstances

initializing and fetching font when main function starts
or
Reloading the entire app.

Please include the output of flutter doctor -v

[√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.778], locale en-US)
    • Flutter version 1.12.13+hotfix.9 at C:\flutter
    • Framework revision f139b11009 (4 weeks ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\premi\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = C:\Users\premi\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] Connected device (1 available)
    • E • G350RT058157000F • android-arm64 • Android 8.1.0 (API 27)

• No issues found!

/cc @chunhtai

@premingiet Can you try the with of master branch.
I verify it does reload correctly with latest master, the fix has not yet propagate to stable yet
This is the code i tested with
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'dart:typed_data';
import 'dart:io';
import 'package:permission_handler/permission_handler.dart';
void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  void _incrementCounter() async {
    Future<ByteData> loadFont(String path) async{
      File file = File(path);
      Uint8List bytes = await file.readAsBytes();
      return ByteData.view(bytes.buffer);
    }

    var custom = FontLoader('Pacifico');
    var result = await Permission.storage.request();
    print('result $result');
    custom.addFont(loadFont("/storage/emulated/0/Download/Pacifico.ttf"));
    await custom.load();
    setState(() {});
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text('test test test', style: TextStyle(fontFamily: 'Pacifico')),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

I just tried that code and doesn't work for me, i think that fix is still not on stable release yet. Maybe that fix has only been implemented on latest master but not merged to stable release yet.

can you try in the 1.17?

oh yes in version 1.17 stable it works good. I had to manually update flutter using flutter upgrade. Now it works perfectly fine. Thanks.


PHP7.4 debug breakpoint does not take effect

Issue Type: Feature Request
PHP7.4 debug breakpoint does not take effect
Extension version: 1.14.0
VS Code version: Code 1.49.1 (58bb7b2331731bf72587010e943852e13e6fd3cf, 2020-09-16T23:27:51.792Z)
OS version: Windows_NT x64 10.0.18363

https://marketplace.visualstudio.com/items?itemName=robberphex.php-debug
Follow the tutorial operation, but unsuccessful


error

Type: Feature Request
i cant seem to open folders and files in my vs code
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:57:04.379Z)
OS version: Windows_NT x64 10.0.25393
Modes:

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Do not require osg-testing or osg-upcoming-testing for osdf-cache

The required version of osdf-cache will be released tomorrow, so people won't have to get it out of testing anymore.

Failures unrelated, merging


Update version: daltonmenezes.electron-screen-recorder version 2.1.1

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

2:21:01 PM: 2024-01-17 14:21:00.210 [FAIL] Installer failed security check. Url: https://github.com/daltonmenezes/electron-screen-recorder/releases/download/v2.1.1/Electron-Screen-Recorder-2.1.1.exe Result: 0x80004005

(Automated response - build 586.)

Hi @vedantmgoyal2009,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 586.)

/AzurePipelines run

Automatic Validation ended with:

Manual Validation ended with:

2:46:19 PM: 2024-01-19 14:46:17.166 [FAIL] Installer failed security check. Url: https://github.com/daltonmenezes/electron-screen-recorder/releases/download/v2.1.1/Electron-Screen-Recorder-2.1.1.exe Result: 0x80004005

(Automated response - build 612.)

Hi @vedantmgoyal2009,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 612.)

This package has failed 2 Defender scans.

Automatic Validation ended with:

No errors to post.

(Automated response - build 675.)

/AzurePipelines run

This screenshot might be related to this PR - I'm not sure, but the name seems to be similar.

Automatic Validation ended with:

No errors to post.

(Automated response - build 679.)


Cluster: Add memberlist label configuration option

This PR makes it possible to set a label for the Memberlist cluster. This label is used to block any traffic that is not meant for the cluster.
For instance, in a situation where there are multiple alertmanager clusters, such as in K8s where IP addresses are shared and reused throughout the cluster, this label helps to prevent a wrong alertmanager cluster from receiving traffic meant for another cluster.

Thank you very much for your contribution!


[SPARK-26594][SQL] DataSourceOptions.asMap should return CaseInsensitiveMap

What changes were proposed in this pull request?
The DataSourceOptions use an immutable string-to-string map internally in which keys are case-insensitive, so while we call asMap, it should also return a case-insensitive map.
Here make DataSourceOptions.asMap return CaseInsensitiveMap.
How was this patch tested?
New case in DataSourceOptionsSuite.

ping @zsxwing.

Test build #103353 has started for PR 24062 at commit 8b06606.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8785/
Test PASSed.

Merged build finished. Test PASSed.

Test build #103353 has finished for PR 24062 at commit 8b06606.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103353/
Test FAILed.

Test build #103358 has started for PR 24062 at commit 83e1960.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8789/
Test PASSed.

Can we wait for https://github.com/apache/spark/pull/24025 ?

Ya. Let's proceed #24025 first.

Yeah, let's wait for #24025 finish first.

Test build #103358 has finished for PR 24062 at commit 83e1960.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103358/
Test FAILed.

As mentioned above, close this PR and maybe the jira can also be closed after #24025.

This File DataSourceOptions,  what is it renamed as in Spark-3 scala 2.12 code? As the complete directory structure is changed.

Hi, @chiragsanghvi18 . It sounds like a git command question instead of Apache Spark.

This File DataSourceOptions, what is it renamed as in Spark-3 scala 2.12 code? As the complete directory structure is changed.

Please try the following. SPARK-27106 removed it instead of renaming.
$ git log --oneline -n1 --all --full-history -- sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
2a80a4cd39 [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

Hi, @chiragsanghvi18 . It sounds like a git command question instead of Apache Spark question.

This File DataSourceOptions, what is it renamed as in Spark-3 scala 2.12 code? As the complete directory structure is changed.

Please try the following. SPARK-27106 removed it instead of renaming.
$ git log --oneline -n1 --all --full-history -- sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
2a80a4cd39 [SPARK-27106][SQL] merge CaseInsensitiveStringMap and DataSourceOptions

Thanks a ton, you're a savior.


How to associate uset with access token

i have login with g+ and facebook both in my app. I have this specific case which requires mandatory facebookdata, if an user is logged in from G+ i need to associate user with facebook profile using access_token not with email as i only require association and to avoid new user creation and access token again.

You would need to implement that in social auth pipeline or implement a custom backend for this.
Check the docs here.
As this is not really related to this project, I'll close this issue.
If however you weren't able to succeed only with social auth feel free to reopen.


Cpuversion

CPU counterpart of all dense operations.

Great PR ! I was also thinking adding knn. One little thing is missing IMHO. It is the mode where the neighbors are stored as a list of edges like in torch geometric (see this).

Yes makes sense. I would do it in the API layer though, not in the nanoflann code. Something for later, logging an issue


Fetching ESG data

Describe the problem
Empower the module by adding the capability of fetching the ESG data
Describe the solution
Via an API, I guess it's possible to fetch the data. Source:
https://github.com/eohne/YFinance.jl/blob/1b634671c5f191fb28d910db3bad3e90fb7038de/src/ESG.jl#L57
Additional context
How do I know the API works?
I saw it in the source code of a Julia package named YFinance.jl.

I am taking this one and will start working on the given feature request.

#1270 PR to fetch ESG data for ticker. Please review.


How do I change a String into a UserTag?

Hello,
I am receiving this issue:
Cannot convert value of type 'String' to expected argument type 'UserTag'
I am using a string as the UserTag, and was just wondering, how I can get it to the UserTag enum form.
Thanks

A UserTag is an enum to specify between a user_id or a screen_name; you can read more about it.
You can use do either UserTag.screenName("username") or UserTag.id("xxxxxxxxx")
Read more about it in SwifterTag.swift

Thank you chief


option to disable exposing php version

I will review this later, thanks for your pull request. 👍

Hi @c4m4 ,
This pull request will active after this test pass.

https://travis-ci.org/chusiang/php7.ansible.role/builds/430148141

But I change the vars name from php_expose to php_expose_php.
Have a good day.


Unable to get answers from the bot

Hi!
I'm trying to get the bot working but, after, successfully configuring everything I keep getting this error when a message is sent to the bot using /ask:
Started refreshing 8 application (/) commands.
Successfully reloaded 8 application (/) commands.
TypeError: clearPrompt is not a function
    at Object.run (/Users/javier/Documents/Desarrollo/discord-gpt-bot-master/commands/gpt/ask.js:48:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Client.init (/Users/javier/Documents/Desarrollo/discord-gpt-bot-master/events/interactionCreate.js:38:17)

Do you know what could be happening?
Thanks in advance!

Hello!
Thank you for reporting this issue. The fix is ready and pushed.
Feel free to message me if you have any other issue.

Sorry to bother again @Vortrix5 but I don't know if I'm doing something in the wrong way. With your latest changes now I'm getting this error:
><EMAIL_ADDRESS>start
> cross-env NODE_ENV=production NODE_NO_WARNINGS=1 node .

Ready! Logged in as Clayton.
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module '../config.json'
Require stack:
- /Users/javier/Documents/Desarrollo/discord-gpt-bot-master/events/ready.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Function.resolve (node:internal/modules/cjs/helpers:109:19)
    at Client.init (/Users/javier/Documents/Desarrollo/discord-gpt-bot-master/events/ready.js:68:53)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Emitted 'error' event on Client instance at:
    at emitUnhandledRejectionOrErr (node:events:394:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:84:21) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/javier/Documents/Desarrollo/discord-gpt-bot-master/events/ready.js'
  ]
}

It seems that config.json is not being found. Thank you very much for your time again!

Hey!
You can try to manually generate the config.json file in your project. I will try to figure out on my end why it is not automatically being generated as it should be.

Thanks, I created an empty config.json file (just with the {}) and now it works!


Add docker tasks to Taskfile.yaml

New tasks added:

docker              - Run docker-compose with specified CLI arguments.
docker:build        - Build container images.
docker:up           - Start all services.
dockeruppostgres  - Start PostgreSQL service.
docker:down         - Stop all services.
docker:purge        - Stop all services and delete all volumes.

@Alex-Izquierdo please review


The roles are quite not really usable like this

It would require a lot of effort for using these roles.
It would be better to have a single role with some subroles.
eg: cp-ansible/tasks/zookeeper/main.yml
kafka-broker/main.yml
Along with something like confluent_role: ["zookeeper", "kafka-broker"] that will include the correct tasks

We choose to use the ansible built-in role functionality versus creating subroles at this time.


Interface for accessing patterns in library

If there is a pattern library included with the source repo (such as in ceviche-starter) we should have a way to show what pattern components are available and probably a way to use them in the edit view (copy and paste code for first pass would be fine)

#214 is likely the solution for this, for now.


Remove current cursor (multi-cursor) using the keyboard

Currently, the only way to remove a cursor in a multi-cursor context is to manually Alt+Click using the mouse.
Combined with editor.action.focusNextCursor and editor.action.focusPreviousCursor, a command to remove the current cursor will allow the user to easily remove any arbitrary cursor with just using the keyboard.

PR welcome!

If you're using multi-cursor with Find Next Occurrence (Ctrl/Cmd + d) then you have this with slightly confusingly named Move Last Selection To Next Find Match (Ctrl/Cmd + k, Ctrl/Cmd + d) and Cursor Undo (Ctrl/Cmd + u).

If you're pressing Ctrl/Cmd + d but want to undo the selection you just made, make vscode pretend that piece of code doesn't exist and then continue making additional selections, you can press Ctrl/Cmd + k then press Ctrl/Cmd + d.
For example, selecting all chapters except chapter 4:
"course1": {
    "overview": "/online-course",
    "chapter1": "/online-course/chapter-1",    // <- select "chapter"
    "chapter2": "/online-course/chapter-2",    // <- select "chapter"
    "chapter3": "/online-course/chapter-3",    // <- select "chapter"
    "chapter4": "/online-course/chapter-4",    // <- NOT THIS ONE
    "chapter5": "/online-course/chapter-5",    // <- select "chapter"
    "chapter6": "/online-course/chapter-6"     // <- select "chapter"
}

Highlight first occurrence of chapter-
Press Ctrl/Cmd + d to add chapter 2
Press Ctrl/Cmd + d to add chapter 3
Press Ctrl/Cmd + d to add temporarily add chapter 4
Press Ctrl/Cmd + k then Ctrl/Cmd + d to unselect chapter 4 and select chapter 5
Press Ctrl/Cmd + d to add chapter 6

If you're not using Ctrl/Cmd + d to select items but instead using something like Select All Occurrences Of Next Match (Ctrl/Cmd + Shift + l) and wanting to deselect specific selections without using a mouse because there's too many matches to Ctrl/Cmd + d them all then this makes more sense.
In terms of the use-case for adding this feature (trying to multi-select many things except for specific cases as determined by the user), the use-case is shared by the issue here: https://github.com/microsoft/vscode/issues/212562


Add support for multiple published sources

Would require support to have multiple lines for one line in one source. Potentially could require two of our current lines being one line in alternately published source.
All our corrections are being done with published sources. It would be easier to simply make corrections / catalog differences between these sources by looking at the published works.
Our current sources will be "deprecated" as we move to figuring out all lines being from which published sources. Where we know our sources are based on certain publications we can set them now.
Related to https://github.com/ShabadOS/desktop/issues/410 where we will have incomplete published sources.
There will eventually need to be a dragger of sorts allowing for prioritization of these published sources

@Harjot1Singh need points on this

Originally posted in Slack by @Sarabveer
Currently in Shabad OS: ਨਮੋ ਰਾਜ ਰਾਜੇਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥
Nihung Santhia: ਨਮੋ ਰਾਜ ਰਾਜੇ ॥ ਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥

Originally posted in Slack by @Harjot1Singh
// previous lines
,{
  id: '21WF',
  gurmukhi: {
      sgpc: 'ਨਮੋ ਰਾਜ ਰਾਜੇਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥'
      ns: 'ਨਮੋ ਰਾਜ ਰਾਜੇ ॥'
  }
},
{
  id: 'G1GH',
  gurmukhi: {
      ns: ' ਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥'
     // Notice how SGPC is missing. And that's OK. We won't include the row/data when they use that source.
  }
},
// next lines

We need to adapt DB viewer too btw

Est difficulty 21
Actual difficulty 5 (3.5)

Duplicate #95


While creating a google doc file through cmd the open module is not found by the system

Expected Behavior
The file should be runned and should have created a file in GoogleDrive
Actual Behavior
The code is giving error that Open Module is not found
##Error

This doesn't appear to be any of the samples in this repo, but your own code. This issue tracker is only for issues related to the samples here. For general help with the Docs API, see https://developers.google.com/docs/api/support
From the error, it sounds like the issue is you're requiring a module that you don't have installed. Where you have your package.json file, try:
npm install --save open


Arducam 2MP + ESP8266 Esp-12F Nano Crash

Hi there.
I have recently treated myself to a Arducam 2MP mounted on the ESP8266 Esp-12F Nano Board.
It worked at first, but while i played around with the sample code, to increase the resolution, i must have done something wrong, as the ESP8266 crashes now everytime, i try to take a picture.
I uploaded the original sketch for capturing and forgot to save my changes, so the code which caused it is lost.
I get a stack trace during the crash, but i have no idea, how to make sense of it currently. Any help concerning this issue would be appreciated.
Thanks.
`ArduCAM Start!
OV2640 detected.
Share AP: arducam_esp8266
The password is:
<IP_ADDRESS>
Server started
CAM Capturing
Soft WDT reset
ctx: cont
sp: 3fff1770 end: 3fff1a70 offset: 01b0

stack>>>
3fff1920:  00000001 0000000d 3fff0a10 40206a19
3fff1930:  00000041 3ffeff88 3fff0928 402060d8
3fff1940:  001d87b1 3ffeff88 00000008 40206100
3fff1950:  00000001 00000001 3fff0a10 4020611c
3fff1960:  3fff1b6c 00000001 3fff0a10 402029d6
3fff1970:  3fff09f0 0000011a 0000011a 402045a8
3fff1980:  00000001 00000001 3fff2254 4020761a
3fff1990:  00000000 00000000 3fff2254 4020459e
3fff19a0:  3fff2254 3ffeffd4 3fff2254 402045da
3fff19b0:  00000000 00000000 00000000 40206f00
3fff19c0:  3fff2254 3ffeffd4 3ffeff94 40204669
3fff19d0:  3fff1b6c 0000000f 00000008 40203680
3fff19e0:  3ffeffd4 00000000 3fff0a50 00000001
3fff19f0:  00000001 40203c10 00000010 3fff0a50
3fff1a00:  00000000 00000000 3ffeff94 3fff0a3c
3fff1a10:  00000001 3ffeffb8 3ffeff94 402048cf
3fff1a20:  3ffe9510 00000000 000003e8 40207610
3fff1a30:  00000000 3fff262c feefeffe feefeffe
3fff1a40:  3fffdad0 00000000 3fff0a34 40202758
3fff1a50:  3fffdad0 00000000 3fff0a34 402074e8
3fff1a60:  feefeffe feefeffe 3fff0a50 40100718
<<<stack<<<

ets Jan  8 2013,rst cause:2, boot mode:(3,6)`

@dduenker
Hi,
Please try to add some yield() when sending image by the wifi.
Let us know if you need more help.
Regards,
ArduCAM support team.

@supprot
Thank you for your answer, this has not completely solved my problem, but now i have progressed from crashing to producing an infinite loop.
void serverCapture(){
yield();
start_capture();
Serial.println(F("CAM Capturing"));
yield();
int total_time = 0;

total_time = millis();

Serial.println(F("while start"));
while (!myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK)){
  yield(); //<-- this never ends
}
Serial.println(F("while end"));

So the condition
myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK)

never gets true.
Any hints on what to try next?
I tried setting the quality to a different setting, which sadly changed nothing so far.
Thank you.

@dduenker
Hi,
Don't worry, please send us your code.
We will test it  for you and give you a
reply as soon as possible.
Best regards,
ArduCAM support team.

Dearest support Team,
the code which produced the problem in the first place was overwritten by me, in an attempt to set everything back to normal, so it is lost for now.
I can give you the code  i am using now, but is just the example sketch with some added yields by now:
// ArduCAM Mini demo (C)2017 Lee
// Web: http://www.ArduCAM.com
// This program is a demo of how to use most of the functions
// of the library with ArduCAM ESP8266 2MP/5MP camera.
// This demo was made for ArduCAM ESP8266 2MP/5MP Camera.
// It can take photo and send to the Web.
// It can take photo continuously as video streaming and send to the Web.
// The demo sketch will do the following tasks:
// 1. Set the camera to JPEG output mode.
// 2. if server.on("/capture", HTTP_GET, serverCapture),it can take photo and send to the Web.
// 3.if server.on("/stream", HTTP_GET, serverStream),it can take photo continuously as video
//streaming and send to the Web.

// This program requires the ArduCAM V4.0.0 (or later) library and ArduCAM ESP8266 2MP/5MP camera
// and use Arduino IDE 1.6.8 compiler or above
#define OV2640_MINI_2MP
#include <ESP8266WiFi.h>
#include <WiFiClient.h>
#include <ESP8266WebServer.h>
#include <ESP8266mDNS.h>
#include <Wire.h>
#include <ArduCAM.h>
#include <SPI.h>
#include "memorysaver.h"
#if !(defined ESP8266 )
#error Please select the ArduCAM ESP8266 UNO board in the Tools/Board
#endif

//This demo can only work on OV2640_MINI_2MP or ARDUCAM_SHIELD_V2 platform.
#if !(defined (OV2640_MINI_2MP)||defined (OV5640_MINI_5MP_PLUS) || defined (OV5642_MINI_5MP_PLUS) \
    || defined (OV5642_MINI_5MP) || defined (OV5642_MINI_5MP_BIT_ROTATION_FIXED) \
    ||(defined (ARDUCAM_SHIELD_V2) && (defined (OV2640_CAM) || defined (OV5640_CAM) || defined (OV5642_CAM))))
#error Please select the hardware platform and camera module in the ../libraries/ArduCAM/memorysaver.h file
#endif
// set GPIO16 as the slave select :
const int CS = 16;

//you can change the value of wifiType to select Station or AP mode.
//Default is AP mode.
int wifiType = 1; // 0:Station  1:AP

//AP mode configuration
//Default is arducam_esp8266.If you want,you can change the AP_aaid  to your favorite name
const char *AP_ssid = "arducam_esp8266";
//Default is no password.If you want to set password,put your password here
const char *AP_password = "";

//Station mode you should put your ssid and password
const char *ssid = "SSID"; // Put your SSID here
const char *password = "PASSWORD"; // Put your PASSWORD here

static const size_t bufferSize = 4096;
static uint8_t buffer[bufferSize] = {0xFF};
uint8_t temp = 0, temp_last = 0;
int i = 0;
bool is_header = false;

ESP8266WebServer server(80);
#if defined (OV2640_MINI_2MP) || defined (OV2640_CAM)
  ArduCAM myCAM(OV2640, CS);
#elif defined (OV5640_MINI_5MP_PLUS) || defined (OV5640_CAM)
  ArduCAM myCAM(OV5640, CS);
#elif defined (OV5642_MINI_5MP_PLUS) || defined (OV5642_MINI_5MP) || defined (OV5642_MINI_5MP_BIT_ROTATION_FIXED) ||(defined (OV5642_CAM))
  ArduCAM myCAM(OV5642, CS);
#endif

void start_capture(){
  myCAM.clear_fifo_flag();
  myCAM.start_capture();
}

void camCapture(ArduCAM myCAM){
WiFiClient client = server.client();
uint32_t len  = myCAM.read_fifo_length();
if (len >= MAX_FIFO_SIZE) //8M
{
  Serial.println(F("Over size."));
}
if (len == 0 ) //0 kb
{
  Serial.println(F("Size is 0."));
}
myCAM.CS_LOW();
myCAM.set_fifo_burst();
if (!client.connected()) return;
String response = "HTTP/1.1 200 OK\r\n";
response += "Content-Type: image/jpeg\r\n";
response += "Content-len: " + String(len) + "\r\n\r\n";
server.sendContent(response);
i = 0;
while ( len-- )
{
temp_last = temp;
temp =  SPI.transfer(0x00);
//Read JPEG data from FIFO
if ( (temp == 0xD9) && (temp_last == 0xFF) ) //If find the end ,break while,
{
buffer[i++] = temp;  //save the last  0XD9
//Write the remain bytes in the buffer
if (!client.connected()) break;
client.write(&buffer[0], i);
is_header = false;
i = 0;
myCAM.CS_HIGH();
break;
}
if (is_header == true)
{
//Write image data to buffer if not full
if (i < bufferSize)
buffer[i++] = temp;
else
{
//Write bufferSize bytes image data to file
if (!client.connected()) break;
client.write(&buffer[0], bufferSize);
i = 0;
buffer[i++] = temp;
}
}
else if ((temp == 0xD8) & (temp_last == 0xFF))
{
is_header = true;
buffer[i++] = temp_last;
buffer[i++] = temp;
}
}
}

void serverCapture(){
yield();
start_capture();
Serial.println(F("CAM Capturing"));
yield();
int total_time = 0;

total_time = millis();

myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK);
Serial.println(F("while start"));
while (!myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK)){
  yield();
}
Serial.println(F("while end"));
total_time = millis() - total_time;
Serial.print(F("capture total_time used (in miliseconds):"));
Serial.println(total_time, DEC);

total_time = 0;

Serial.println(F("CAM Capture Done."));
total_time = millis();
camCapture(myCAM);
total_time = millis() - total_time;
Serial.print(F("send total_time used (in miliseconds):"));
Serial.println(total_time, DEC);
Serial.println(F("CAM send Done."));
}

void serverStream(){
WiFiClient client = server.client();

String response = "HTTP/1.1 200 OK\r\n";
response += "Content-Type: multipart/x-mixed-replace; boundary=frame\r\n\r\n";
server.sendContent(response);

while (1){
yield();
Serial.println(F("starting capture"));
start_capture();
Serial.println(F("capture started"));
while (!myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK));
Serial.println(F("capture done"));
size_t len = myCAM.read_fifo_length();
if (len >= MAX_FIFO_SIZE) //8M
{
Serial.println(F("Over size."));
continue;
}
if (len == 0 ) //0 kb
{
Serial.println(F("Size is 0."));
continue;
}
myCAM.CS_LOW();
myCAM.set_fifo_burst();
if (!client.connected()) break;
response = "--frame\r\n";
response += "Content-Type: image/jpeg\r\n\r\n";
server.sendContent(response);
while ( len-- )
{
  yield();
temp_last = temp;
temp =  SPI.transfer(0x00);

//Read JPEG data from FIFO
if ( (temp == 0xD9) && (temp_last == 0xFF) ) //If find the end ,break while,
{
buffer[i++] = temp;  //save the last  0XD9
//Write the remain bytes in the buffer
myCAM.CS_HIGH();;
if (!client.connected()) break;
client.write(&buffer[0], i);
is_header = false;
i = 0;
}
if (is_header == true)
{
//Write image data to buffer if not full
if (i < bufferSize)
buffer[i++] = temp;
else
{
//Write bufferSize bytes image data to file
myCAM.CS_HIGH();
if (!client.connected()) break;
client.write(&buffer[0], bufferSize);
i = 0;
buffer[i++] = temp;
myCAM.CS_LOW();
myCAM.set_fifo_burst();
}
}
else if ((temp == 0xD8) & (temp_last == 0xFF))
{
is_header = true;
buffer[i++] = temp_last;
buffer[i++] = temp;
}
}
if (!client.connected()) break;
}
}

void handleNotFound(){
String message = "Server is running!\n\n";
message += "URI: ";
message += server.uri();
message += "\nMethod: ";
message += (server.method() == HTTP_GET)?"GET":"POST";
message += "\nArguments: ";
message += server.args();
message += "\n";
server.send(200, "text/plain", message);

if (server.hasArg("ql")){
int ql = server.arg("ql").toInt();
#if defined (OV2640_MINI_2MP) || defined (OV2640_CAM)
myCAM.OV2640_set_JPEG_size(ql);
#elif defined (OV5640_MINI_5MP_PLUS) || defined (OV5640_CAM)
myCAM.OV5640_set_JPEG_size(ql);
#elif defined (OV5642_MINI_5MP_PLUS) || defined (OV5642_MINI_5MP_BIT_ROTATION_FIXED) ||(defined (OV5642_CAM))
myCAM.OV5642_set_JPEG_size(ql);
#endif
delay(1000);
Serial.println("QL change to: " + server.arg("ql"));
}
}

void setup() {
uint8_t vid, pid;
uint8_t temp;
#if defined(__SAM3X8E__)
Wire1.begin();
#else
Wire.begin();
#endif
Serial.begin(115200);
Serial.println(F("ArduCAM Start!"));

// set the CS as an output:
pinMode(CS, OUTPUT);

// initialize SPI:
SPI.begin();
SPI.setFrequency(4000000); //4MHz

//Check if the ArduCAM SPI bus is OK
myCAM.write_reg(ARDUCHIP_TEST1, 0x55);
temp = myCAM.read_reg(ARDUCHIP_TEST1);
if (temp != 0x55){
Serial.println(F("SPI1 interface Error!"));
while(1);
}
#if defined (OV2640_MINI_2MP) || defined (OV2640_CAM)
//Check if the camera module type is OV2640
myCAM.wrSensorReg8_8(0xff, 0x01);
myCAM.rdSensorReg8_8(OV2640_CHIPID_HIGH, &vid);
myCAM.rdSensorReg8_8(OV2640_CHIPID_LOW, &pid);
if ((vid != 0x26 ) && (( pid != 0x41 ) || ( pid != 0x42 )))
Serial.println(F("Can't find OV2640 module!"));
else
Serial.println(F("OV2640 detected."));
#elif defined (OV5640_MINI_5MP_PLUS) || defined (OV5640_CAM)
//Check if the camera module type is OV5640
myCAM.wrSensorReg16_8(0xff, 0x01);
myCAM.rdSensorReg16_8(OV5640_CHIPID_HIGH, &vid);
myCAM.rdSensorReg16_8(OV5640_CHIPID_LOW, &pid);
if((vid != 0x56) || (pid != 0x40))
Serial.println(F("Can't find OV5640 module!"));
else
Serial.println(F("OV5640 detected."));
#elif defined (OV5642_MINI_5MP_PLUS) || defined (OV5642_MINI_5MP) || defined (OV5642_MINI_5MP_BIT_ROTATION_FIXED) ||(defined (OV5642_CAM))
//Check if the camera module type is OV5642
myCAM.wrSensorReg16_8(0xff, 0x01);
myCAM.rdSensorReg16_8(OV5642_CHIPID_HIGH, &vid);
myCAM.rdSensorReg16_8(OV5642_CHIPID_LOW, &pid);
if((vid != 0x56) || (pid != 0x42)){
Serial.println(F("Can't find OV5642 module!"));
}
else
Serial.println(F("OV5642 detected."));
#endif

//Change to JPEG capture mode and initialize the OV2640 module
myCAM.set_format(JPEG);
myCAM.InitCAM();
#if defined (OV2640_MINI_2MP) || defined (OV2640_CAM)
myCAM.OV2640_set_JPEG_size(OV2640_320x240);
#elif defined (OV5640_MINI_5MP_PLUS) || defined (OV5640_CAM)
myCAM.write_reg(ARDUCHIP_TIM, VSYNC_LEVEL_MASK);   //VSYNC is active HIGH
myCAM.OV5640_set_JPEG_size(OV5640_320x240);
#elif defined (OV5642_MINI_5MP_PLUS) || defined (OV5642_MINI_5MP) || defined (OV5642_MINI_5MP_BIT_ROTATION_FIXED) ||(defined (OV5642_CAM))
myCAM.write_reg(ARDUCHIP_TIM, VSYNC_LEVEL_MASK);   //VSYNC is active HIGH
myCAM.OV5640_set_JPEG_size(OV5642_320x240);
#endif

myCAM.clear_fifo_flag();
if (wifiType == 0){
if(!strcmp(ssid,"SSID")){
Serial.println(F("Please set your SSID"));
while(1);
}
if(!strcmp(password,"PASSWORD")){
Serial.println(F("Please set your PASSWORD"));
while(1);
}
// Connect to WiFi network
Serial.println();
Serial.println();
Serial.print(F("Connecting to "));
Serial.println(ssid);

WiFi.mode(WIFI_STA);
WiFi.begin(ssid, password);
while (WiFi.status() != WL_CONNECTED) {
delay(500);
Serial.print(F("."));
}
Serial.println(F("WiFi connected"));
Serial.println("");
Serial.println(WiFi.localIP());
}else if (wifiType == 1){
Serial.println();
Serial.println();
Serial.print(F("Share AP: "));
Serial.println(AP_ssid);
Serial.print(F("The password is: "));
Serial.println(AP_password);

WiFi.mode(WIFI_AP);
WiFi.softAP(AP_ssid, AP_password);
Serial.println("");
Serial.println(WiFi.softAPIP());
}

// Start the server
server.on("/capture", HTTP_GET, serverCapture);
server.on("/stream", HTTP_GET, serverStream);
server.onNotFound(handleNotFound);
server.begin();
Serial.println(F("Server started"));
}

void loop() {
server.handleClient();
}

Thank you.

@dduenker
Hi,
We have tested our demo with 1600x1200 resolution
on our ESp8266 UNO board and it can work fine.
We attached a picture for you.

You stop at while (!myCAM.get_bit(ARDUCHIP_TRIG, CAP_DONE_MASK)); Maybe your camera work is not stable.Please ensure your hardware connection is stable and reset again.
Let us know if you need more help.
Regards,
ArduCAM support team.

Thanks again, i found what i did wrong: i forgot to set the
#define OV2640_MINI_2MP

in memorysaver.h
It works now. 😀
I have no idea, why it worked in the first place without this.
Best Regards,
Daniel

@dduenker
Hi,
So glad to hear you have solved the problem.
Best regards,
ArduCAM support team.


Show error if SSH url is entered for repo cloning

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.22621.0
Other software
No response
Steps to reproduce the bug

Go to the machine configuration tab
Click 'Clone repositories'
Click 'Add repository'
Copy the repository ssh url to 'Repository URL' input field
Click 'Add'
The program exit

Expected result
Show some error about why shouldn't I use ssh URL as a repository URL, or clone the repository like normal.the
Actual result
The program exit without any sign.
Included System Information
No response
Included Extensions Information
No response

For me the software doesn't exit, but it does report an error:

I can't seem to use any kind of URL but an HTTPS one.

I host my repos on a synology, that has git installed.
I can clone them manually onto my devdrive on my laptop. But once I've done that, they dont show up in Dev Home.

Dev Home does not have view to show all cloned repositories today. Adding to the list of feature asks.

Hello @swsd2544 can you please upgrade to a more recent version of Dev Home.  The URL screen shows text if the user put in an SSH link.
Closing as fixed in 0.2.


Update ripper_supported? for truffleruby and ripper specs

and allow ripper specs to produce exceptions.

This should be reverted, the check here is that ripper_supported? matches the two test definitions, are you saying the test definitions return true here? As that should be impossible if ripper is broken on truffleruby. Whats actually happening?

Github has lost the reply to this somewhere, whats the runtime error from those two detection methods? Is that what the rescue false was for originally? Out of those two solutions I'd prefer you rescue the specific exception with a note about truffle-ruby.

@JonRowe I've updated to add the begin;rescue with a note for truffleruby and removed the dependency on RubyFeatures.ripper_supported? to run the test. Thanks.

@JonRowe I've updated ripper_is_implemented? with your suggestion, thanks.


Prepare for v1.4.0 Release

Sadly, the release is broken. Our internal tests don't pass with 1.4.0 while they do with our internal release.
Please find attached our so file (I had to zip si GH accepts it): libbrotli.so.zip

Actually, I had a bug on my side and got confused by #18.
Still, sadly, release 1.4.0 is broken.

Released 1.4.1. Fixed missing OSX binary issue and also synced code with upstream.

Thanks a lot!


[Feature request] Option minHeight for geom interval.

G2 Version: 3.4.5
Platform: chrome latest
Mini Showcase(like screenshots): see codepen
CodePen Link: https://codepen.io/anon/pen/aQRbWB (js line 15)(echarts demo)

While max value of data is much larger than min value, likes [0.01, 0.001, 10000], geom interval renders 0px for min value. Adding minHeight to these bars would be a better render result.
Would you please taking some consideration? (It seems that having scale problems?)

The new feature will be considered in the next version of G2.


Normalization of uploaded images does not always work

If you open this MRI from OpenNeuro
sub-01_ses-01_acq-MEMPRvNav_rec-RMS_T1w.nii.gz
It ends up not normalized to the values between 0 and 255 in the Papaya viewer as the screenshot below taken after the preprocessing demonstrates (observe the value under cursor is 2060):

The model still runs fine and produces reasonable results, but the composite display on the left is broken because of the unnormalized values:

This bug is still happening somehow. Here is the example I used and this is the light model
https://s3.amazonaws.com/openneuro.org/ds005040/sub-002/anat/sub-002_T1w.nii.gz?versionId=0180to.LlPNn0Bl7s47oJYfD7ZRIhuSa


Build decks with owned stock / collection

Hi! I'm loving the app so far, but I was wondering if you could support deck building from owned cards. When building a deck it would be nice to be able to change the "source" where the cards are being pulled from, so that I can search only in my library / stock.

btw, if you're looking for contributors I would love to help! I have some experience with Java web development, but I would like to learn and help if able


Some identifiers are remembered but shouldn't, when using #:private tags

Fixed for constructors now.

Fixed for constructors. I don't think any fix is needed for structure.


This project should be renamed

bztools is too vague. We should rename it for something like relman-auto-nag

Renamed!


Error: Processed image is too large for the WebP format

I am getting an error in the console while converting PNG to WEBP. How can you get around this limitation? ( https://developers.google.com/speed/webp/faq#what_is_the_maximum_size_a_webp_image_can_be )
Image: https://drive.google.com/file/d/1Ovv6YVHzl_fAXBPfMblJpjl7JjMYhWZC/view?usp=sharing
Size image: 14,4Mb / w720px * h37062px
Example code:
const { data } = await sharp('path/file.png', { animated: true })
    .webp({
        lossless: true,
    })
    .toBuffer({ resolveWithObject: true });
const imageBuffer = new Uint8ClampedArray(data.buffer);
await sharp(imageBuffer).toFile('path/file.webp');

Version: --<EMAIL_ADDRESS>System:
OS: Windows 10 10.0.19042
CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
Memory: 15.73 GB / 23.94 GB
Binaries:
Node: 12.21.0
npm: 6.14.8

https://developers.google.com/speed/webp/faq#what_is_the_maximum_size_a_webp_image_can_be


[CREATE QUOTA] BACKEND + FRONTEND - work in progress

TRELLO CARD

 [DIT] As a Tariff Manager, I want to create a new quota and related data (108)


restart interrupted transfers

Today I watched a friend use wormhole send on a large (multi-GB) file over a relatively slow link, such that the transfer required several hours. About halfway through, the sending machine reported an error, probably due to a lost connection:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/wormhole/cli/cli.py", line 99, in _dispatch_command
    yield maybeDeferred(command)
Exception: Consumer asked us to stop producing
ERROR: Consumer asked us to stop producing

We don't know whether this was a transient network problem, or the simply the person at the far end closing the lid on their laptop.
What it made us think is that it'd be handy to have a way to resume an interrupted transfer. It'd be easier for files than for directories, but the basic idea would be:

when a transfer begins, write a record to some ~/.wormhole/ file, maybe ~/.wormhole/in-progress/RANDOM.json. The record should include a "Wormhole Seed", the code that was used, the pathname of the source/dest file, and the intended size
if the transfer finishes normally, delete the record
wormhole receive should do tab-completion against codes from the in-progress records, as well as the channels reported by the rendezvous server. Selecting an in-progress code means "please resume that previous connection". That will use the Seed to build a new connection, use the record to locate the previously-transferred contents, and ask the sender to start sending from a particular byte offset.

The goal is to allow "up-arrow" (aka !!, aka "re-run the exact previous command") to mean "please resume the previous transfer". I'm not entirely sure this would work well, so we might need a special flag for it (wormhole send --resume?), and we could remind the user about it if/when a transfer fails (Network connection lost: run "wormhole receive --resume 4-pink-snowmen" to resume).
We wouldn't actually re-use the wormhole code in this case (since re-using a PAKE code doubles an attacker's chances of guessing it). The code would just be shorthand for referring to the same file (or the same act of transferrence) as before. The Wormhole Seed would provide the cryptographic pieces needed to establish a new connection safely (and note that Seeds can be reused multiple times, since they start with a full-strength random key).
I think the temporary file data wants to live directly next to the target location (so it will be on the same filesystem), but we discussed multiple places for the metadata that remembers the incomplete transfer. We could either put it right next to the target file, or we could put them in a shared ~/.wormhole/SOMETHING/ directory.
Putting it next to the target file has the benefit of reducing the uncertainly of what directory should be used for the receive: the target file will always be in the CWD of the command, regardless of whether it's the first time executed or the second.
The downside is that it isn't clear which tempfiles might be magic-wormhole interrupted-file reminder records, and which are unrelated. We could use a naming convention to find them, and/or a checksum to exclude other files, but it felt cleaner to me to put all such records in a single ~/.wormhole/ directory, where their purpose would be unambiguous.
We also discussed just writing the metadata into the end of the temporary file, so there'd only be one tempfile left lying around. But I was uncomfortable with mingling user data and metadata.

Hello @warner,
Has there been any development on or changes to this issue yet? I think it would be really useful enhancement of magic-wormhole. If not, I would like to volunteer in writing the code for this if possible.

One way to address this is to do something like zsync (http://zsync.moria.org.uk/).  The sender generates it dynamically and sends it, then the receiver can figure out what parts it needs.  This way you don't have to worry about reusing connections or codes, it automatically works for partial files.

+1


Failed to compile template

I followed the exact steps as mentioned in the article on how to create an HTML email newsletter from Markdown files but got an error at the last npm run build command when compiling the markdown files. Can you please let me know on how to resolve this?

Hey, sorry I missed this. Looks like there's an issue with your CSS, maybe there's a typo or something in there. If this is still an issue and you can share a repo that I can look at (can be private too), I'll be happy to help :)

I resolved this and indeed there was an issue with CSS. Thank you.


Added Argon2 validator

Enhances
Make sure that you've checked the boxes below before you submit PR:

[x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

coverage: 73.913% (+0.01%) from 73.903%
when pulling 9aeb9ed0b40eaa848e9f8e7cd9280ef84bc8a0c2 on pixel365:argon2-regex
into 84254aeb5a59e615ec0b66ab53b988bc0677f55e on go-playground:master.