On macOS, closing the window should not quit the application

When you close the window, it quits the entire application.  This is abnormal for an application on macOS.

Ah.  I found a "Close to tray" option that makes it behave in the way I expected.  However, this option is only available if you turn on "Show tray icon".  Good thing I dug around.  Seems weird this option is hidden there when it still works when "Show tray icon" is disabled.

I agree with @cgatesman, and the same behaviour occurs on Win7.

same occurs on elementary os (linux, debian, ubuntu, etc.)


Change todo example to not modify payload.todo directly

Instead, the store should refer to its own state via data in the payload.
Thanks, @lostpebble and @andy-williams, for the catch.

Can I do a PR for this?

Go for it!

Fixed by #107


Allow the customization of the storage class for the PVC of pipelines

Changes
This commit enables to use storage classes other than the cluster-wide default storage class for the PVC of pipelines. The customization can be defined in the config map config-artifact-pvc.yaml - similar to how the size of the PVC can already be defined. By default, it will fallback to the cluster-wide default storage class. fixes #1101

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Release Notes
Allow the definition of a storage class for the artifact pvc using the ConfigMap `config-artifact-pvc`

@googlebot I signed it!

/ok-to-test

/lgtm


cmdReporter = mwin.findChild(QTextEdit, cmdReporters[0])  it always get "None" error

Hi Mackst, your script "cmdReporterHighlighter.py" works pretty well in maya2018(py2.7), great job!
but the script does not work for maya2022(py3.7)  and  maya2024(py3.10), in following line it always get "None" error, could you please take a look to fix the problem? thanks!
cmdReporter = mwin.findChild(QTextEdit, cmdReporters[0])
mwin.findChild(QTextEdit, cmdReporters[0])  -> return "None"
BTW: this line
stop = len(melProcedures) / maxlen
it should be changed to
stop = int(len(melProcedures) / maxlen)
(to fit with py3 )

Upgrade

thanks Mackst, it works for maya2024 now!


Allow on-premise sentry

https://docs.sentry.io/server/
added an option "baseSentryURL" to allow other sentry servers than those from "sentry.io"

Thanks for your contribution! 👍 😄 And I see this is your first PR! 🎉 🚀


Split the IDs and unit test projects

We should avoid referencing Microsoft.VisualStudio.QualityTools.UnitTestFramework from the assemblies they we deploy.

@jcansdale @paladique While you're at it, fix the AssemblyInfo.cs file to set the proper copyright notice for the project, as well as other related information.


Cyclic array?

I would like to create a bounded, cyclic array.
Is that supported?
Couldn't find such functionality in the doc.

Is the logical length finite or infinite? For infinite lengths, that's something that I hadn't considered; everything must have an int64 length, so it's a non-starter.
Do you mean this?
>>> import awkward1 as ak
>>>
>>> original = ak.Array(np.arange(7) * 1.1)
>>> original
<Array [0, 1.1, 2.2, 3.3, 4.4, 5.5, 6.6] type='7 * float64'>
>>>
>>> ak.Array(ak.layout.IndexedArray64(ak.layout.Index64(np.roll(np.arange(7), -2)),
...                                   original.layout))
<Array [2.2, 3.3, 4.4, 5.5, 6.6, 0, 1.1] type='7 * float64'>

The IndexedArray node wraps a view of the data cyclically, and you can change the view in a rather lightweight way (only replacing the IndexedArray node, leaving all the underlying data, which can contain complex records).
But fundamentally, I don't know what it is that you want.


Demon Hunter buffs not showing?

While running around on my Vengeance Demon Hunter I noticed I had no buff timers for 'Metamorphosis' or immolation aura.
If I targeted myself I could see a counter reflecting these times accurately, but I'm not seeing any above my normal health bar, nor near my minimap.
I am seeing buffs fine on my main and my other alts.
I can also see the well-fed buff fine.
but I can't seem to see class specific buff timers.

'Empowered Wards is showing properly on both the mini-map and the health bar buffs.

Ok. Finally got to the bottom of this (and it has driven me CRAZY for 2 days solid!)
The reason this isn't working is because somehow Blizzard filter it if you're using consolidated buffs (or HyperBuffs because they trigger consolidated buffs to the Blizz code at the same time). I don't know why but that's what seems to happen...
From the code it looks like Munglunch started (but hadn't completed) a rewrite of Hyperbuffs and has commented out much of them (meaning they don't work in any case).
Here's what you have to do:
Go into SVUI Settings
Select Auras on the left
On the Auras screen: Untick "HyperAuras Enabled"
This will now allow Metamorphosis (and Empower Wards and Immolation Aura) to appear on the Buff Bar (beside minimap in the default layout)
Next, select UnitFrames on the left then select "Player"
From the dropdown on the top-right, select "Buffs"
In the "Aura Filtering" Section, uncheck "Consolidated Buffs" (you may also have to uncheck "You can remove" if it's checked since that would filter out Metamorphosis which you can't remove :))
et voila! You will see your DemonHunter buffs on the buffbar and the unitframes :)
I'm not going to fix this behaviour at present because I'm going to be moving to the latest version of oUF which will mean I'll be fixing the behaviour by setting up oUF layout to do the filtering so there's no point in doing it twice.


Segment script and cookie consent changes

We're using Segment in this case as we already have it, but we'll want the same behaviour for the pixel tracking scripts.
Current behaviour

User lands on website
Users selects "Essential only" in cookies
Segment script does not load
User goes to Cookie Management modal and consents to "analytics" cookies, leaves the modal.
Segment script does not load
User navigates to next page/reloads current page
Segment script gets loaded and triggers.

then

User goes back to Cookie Management modal and revokes his "analytics" consent.
Segment script is not removed, nor as associated cookies
User navigates to next page/reloads current page
Segment script is removed, as are associated cookies.

Expected behaviour

User lands on website for the first time
Accepts all cookies
Segment script loads

or

User lands on website for the first time
Essential cookies only
Segment script does not loads

and

User lands on website
Users selects "Essential only" in cookies
Segment script does not load
User goes to Cookie Management modal and consents to "analytics" cookies, leaves the modal.
Segment script was added on consent change and triggers

then

User goes back to Cookie Management modal and revokes his "analytics" consent.
Segment script is removed, as are associated cookies

Things to look into:

Test Segment's Reset to see if it removes the cookies it set
Move script in the body and render it/not with state.

Done when

[x] Expected behaviour is the new normal, OR we come to an understanding on what's expected.
[x] Ensure it works on error pages (no access to serverData)

PR was approved but because we'd like to keep an eye on the results and effects and I'm off tomorrow, I suggest we wait until Monday to deploy.

Deployed changes to prod and will keep an eye on the reporting dashboard for any weirdness.


[CLOSED] Remove use of exceptions for flow control.

 Issue by kalleth
Monday 16 June 2014 at 15:29 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/114

Previously, an error was being thrown by the fetchable gem deep within the call stack which was then being rescued way up the chain in the SpecialistDocumentsController.
By creating a DocumentFinder to be used by the various helpers, which prevents calling the service and instead returns nil in cases where we want to render a 404, we're able to remove this use of exceptions.
[+ @bestie]

kalleth included the following code: https://github.com/alphagov/specialist-publisher/pull/114/commits

 Comment by evilstreak
Wednesday 25 June 2014 at 14:41 GMT

I don't think this approach makes anything clearer. I'm going to close the pull request for now, but let's talk about it after we've cleared down the decks a bit.


Dynamically add file available in testing inside preprocessor.

Hello,
In a preprocessor, I process a file (and return it, all works well), but also I create a new one that I need to have available during testing. How can I achieve this, inside a preprocessor.
Best

+1
I'm trying to get this working as well. What I'm doing is having both a framework and a preprocessor, and in the framework factory appending a file to the config.files list, and adding it to the config.preprocessors object as well. But for some reason it's not passed through my preprocessor. Is there some sort of timing issue where it's too late for the framework factory to add patterns to the config.preprocessors object? I can add them to config.files and they get included, just not processed.

Should be solved by #1341


No man-page tool helper.

When there is no man page entry, attempt to execute the binary with the -h or --help argument and use provided input for session.

Feature implemented.


Audit table - primary key (int)

May I ask why int was used instead of bigint/long?  It seems to me that a LOT of data can be generated very fast and that 2 billion could be reached quite quickly in a busy system (at which point this library would start failing).
Thanks.

Thank you for this suggestion.
We agree BigInt should have been used instead.
Since it's a breaking change, we will need to evaluate if we prefer to code & release this suggestion once we will re-write the library (Milestone 2.0) or right now.

Ok, thanks for the response.

I will close this issue to make easier to track other request. The next major version will for sure use a BigInt instead of a Int


Added dockerfile and documentation

It seems to be working but it downloads a 442M file in docker run phase. The related info is: https://cdn.huggingface.co/allenai/scibert_scivocab_uncased/pytorch_model.bin not found in cache or force_download set to True, downloading to /root/.cache/torch/transformers/tmpn121d99l. It would be nice to do if it is possible to read it from cache when available in a way.
Closes #3.

@metincansiper it is downloading the weights of the model along with the tokenizer and its vocabulary, the only way to get around that would be to somehow provide the weights yourself (not sure if this is possible or desirable, don't know a lot about Docker).

I guess my internet speed is not good today that is why downloading 442M looked too much to me. Maybe it is okay to let it download the file in docker run phase.

If you put its installation as a part of the build phase, then it will be cached in the container image.

On May 18, 2020, at 19:46, metincansiper<EMAIL_ADDRESS>wrote:

I guess my internet speed is not good today that is why downloading 442M looked too much to me. Maybe it is okay to let it download the file in docker run phase.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.

@metincansiper Just made a small change to the readme!

If you put its installation as a part of the build phase, then it will be cached in the container image.

@maxkfranz I think that the installation that I mentioned is done with the command that runs the app (uvicorn main:app). The docker line I have for that is ENTRYPOINT ["uvicorn","main:app","--host","<IP_ADDRESS>"].  If I update it as uvicorn --host <IP_ADDRESS> main:app then it hangs in the build stage as the server running.
@JohnGiorgi is it possible to separate that installation from the run command of the app in a way?

I don't have a preference for whether we cache at build time.  I just thought I'd mention the option since you asked about caching.  I think it's fine to merge this in as-is, unless someone has a strong preference for caching at build time.


update requests decoding and corpus set

Thanks for the fix @zslwyuan! On the main branch, running any of the examples creates an empty csv file, but this PR correctly saves the data.

Can the repo owner merge the pull request?


Apply material design 3 to MaterialEditor

Apply only the filled layout (outlined layout will be implemented in the future).
https://m3.material.io/components/text-fields/specs
Keep in mind the following issue to see if we can fix it:
#9

We are excited to announce that we are working on a new generation of controls based on Material Design V3, which we will be releasing soon.
This ticket has been included/fixed in the upcoming version of this NuGet package, which will include both current and new generations of controls.


Even more import/dependency errors

ImmuneBuilder is imported but not specified as an dependency.
Following the instructions from https://github.com/oxpig/ImmuneBuilder seems to work but when running plabdab I get.
  File "/home/yawi/projects/vhh_search/plabdab.py", line 1, in <module>
    from PLAbDab import PLAbDab
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/PLAbDab/__init__.py", line 1, in <module>
    from PLAbDab.database import PLAbDab
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/PLAbDab/database.py", line 7, in <module>
    from PLAbDab.structure_search import StructureSearch
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/PLAbDab/structure_search.py", line 3, in <module>
    from ImmuneBuilder import refine
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/ImmuneBuilder/__init__.py", line 1, in <module>
    from ImmuneBuilder.ABodyBuilder2 import ABodyBuilder2
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/ImmuneBuilder/ABodyBuilder2.py", line 8, in <module>
    from ImmuneBuilder.refine import refine
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/ImmuneBuilder/refine.py", line 1, in <module>
    import pdbfixer
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/pdbfixer/__init__.py", line 2, in <module>
    from .pdbfixer import PDBFixer
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/pdbfixer/pdbfixer.py", line 35, in <module>
    import openmm as mm
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/openmm/__init__.py", line 24, in <module>
    from openmm.openmm import *
  File "/home/useri/miniconda3/envs/test/lib/python3.8/site-packages/openmm/openmm.py", line 10, in <module>
    from . import _openmm
ImportError: /home/useri/miniconda3/envs/test/bin/../lib/libstdc++.so.6: version GLIBCXX_3.4.30 not found (required by /home/useri/miniconda3/envs/test/lib/python3.8/site-packages/openmm/../../../libOpenMM.so.8.0)

Is there a docker that has all the dependencies to run PLAbDab because it is very difficult to get it running.
Otherwise adding some instructions would be nice.

Hi @ywilke
Thanks again for spotting this. I have added some installation instructions.
Basically, PLAbDab depends on ImmuneBuilder which depends on a bunch of packages that are either not currently available via pip (anarci, openmm) or have multiple versions depending on your machine (pytorch). This is my reason for leaving them out of the setup.py. There are some installation instructions on the ImmuneBuilder repo that should guide you through this.
All the best,
Brennan


Cilium attaching to the wrong cgroup

Bug report
General Information
Version
Client: 1.9.4 07b62884c 2021-02-03T11:45:44-08:00 go version go1.15.7 linux/amd64
Daemon: 1.9.4 07b62884c 2021-02-03T11:45:44-08:00 go version go1.15.7 linux/amd64

Kervel Version
Linux broker1 5.10.18 #1-NixOS SMP Tue Feb 23 14:53:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Orchestration version (kubernetes)
Client Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.6-rc.0", GitCommit:"e338cf2c6d297aa603b50ad3a301f761b4173aa6", GitTreeState:"archive", BuildDate:"1980-01-01T00:00:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.6-rc.0", GitCommit:"e338cf2c6d297aa603b50ad3a301f761b4173aa6", GitTreeState:"archive", BuildDate:"1980-01-01T00:00:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

Setup
I am using NixOS (system state version 20.09) with unstable nixpkgs.
Kubernetes has been deployed using the provided config options, refer to the wiki. Changes have been made to said configuration, but those changes do not affect the setup.
The important parts of the rendered service files are:
ExecStart=/nix/store/m17a776xbvs4d1f91hcka0s3289hr8a7-kubernetes-1.19.5/bin/kubelet \
            [...snip...] \
            --cgroup-driver=systemd --anonymous-auth=false --cloud-provider=external
Slice=kubernetes.slice

Cilium was installed using helm with the following options (custom nix, but straight-forward):
{
    ctf.platform.node.config.kubernetes.helm.cilium = {
      repo = "https://helm.cilium.io/";

      charts = [{
        path = "cilium";
        name = "cilium";
        version = "1.9.4";
        namespace = ciliumNamespace;

        values = {
          # CNI config
          cni = {
            install = false;
            configMap = configMapName;
            customConf = true;
          };

          # Rollout on config changes
          rollOutCiliumPods = true;

          # Enable sockops acceleration
          sockops.enabled = true;

          # Have k8s manage ip addresses
          ipam.mode = "kubernetes";

          # Replace kube-proxy
          kubeProxyReplacement = "strict";
          k8sServiceHost = platform.getRoleDns "master";
          k8sServicePort = platform.cfg.kubernetes.apiPort;

          # Have services be reachable by the host
          hostServices.enabled = true;
        };
      }];
    };
}

(The cni.install=false setting is not of importance here, as cilium will be installed into the correct path by NixOS (required due to nixos-rebuild switch re-symlinking the directory))
Now I would expect cilium to attach to the root cgroup and everything to work, but it didn't. Symptoms included: routing between nodes and pods functioning (due to the kernel routing the PodCIDR to the cilium_host interface, thus applying the bpf), but service ips not being routed properly (exiting via bond0 in my case)
After hours of debugging it turned out, that cilium attached to the pod-internal cgroups, meaning that bpf was working properly, just inside of the pod.
$ nix run nixpkgs.bpftool --command bpftool cgroup tree
[...snip...]
/sys/fs/cgroup/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod2ca50d7d_4376_42f7_b95e_f6cfed8082b4.slice/docker-a305231644dfdac2d21ec70d7884c6ab8b9b24b298225b7c4b5b4eb1ba15e310.scope
    3179     ingress         multi
    3178     egress          multi
    3177     device          multi
    3180     device          multi
/sys/fs/cgroup/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod2ca50d7d_4376_42f7_b95e_f6cfed8082b4.slice/docker-6da42fbcf7aa862441877a5ca52f169247c39b73174b449253ddd00386316eca.scope
    3189     ingress         multi
    3188     egress          multi
    3619     sock_ops                        bpf_sockmap
    3190     device          multi
    3639     connect4
    3634     connect6
    3641     post_bind4
    3636     post_bind6
    3642     sendmsg4
    3637     sendmsg6
    3643     recvmsg4
    3638     recvmsg6
    3640     getpeername4
    3635     getpeername6
/sys/fs/cgroup/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod1e5fa539_4583_4147_bd6f_a2633dff45b4.slice
    1964     ingress         multi
    1963     egress          multi
/sys/fs/cgroup/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod1e5fa539_4583_4147_bd6f_a2633dff45b4.slice/docker-4e9678a09c7519bc612169ef5549dd521ef0e4c9ce1c2914adf6fa730509c9ea.scope
    2089     ingress         multi
    2088     egress          multi
    1279     device          multi
    2087     device          multi
/sys/fs/cgroup/kubepods.slice/kubepods-b
[...snip...]

Looking through the code here this is happening, because cilium mounts the cgroups itself from withtin the container, thus getting their own - namespaced - view.
	if err := unix.Mount("none", cgroupRoot, "cgroup2", 0, ""); err != nil {
		return fmt.Errorf("failed to mount %s: %s", cgroupRoot, err)
	}

Fix
The fix turned out to be a simple one - I just needed to mount the proper cgroups myself using (nix syntax again)
{
  # [...snip...]
  charts = [{
    path = "cilium";
    name = "cilium";
    version = "1.9.4";
    namespace = ciliumNamespace;

    values = {
      # [...snip...]
      extraConfig = {
        cgroup-root = "/var/run/host-cgroup";
      };

      extraHostPathMounts = [{
        name = "host-cgroup";
        type = "DirectoryOrCreate";
        hostPath = "/sys/fs/cgroup";
        mountPath = "/var/run/host-cgroup";
      }];
      # [...snip...]
    };
  }];
  # [...snip...]
}

After mounting the proper cgroups everything works as expected.
$ nix run nixpkgs.bpftool --command bpftool cgroup tree
[...snip...]
CgroupPath
ID       AttachType      AttachFlags     Name
/sys/fs/cgroup
4263     ingress         multi
4262     egress          multi
3007     sock_ops                        bpf_sockmap
3027     connect4
3022     connect6
3029     post_bind4
3024     post_bind6
3030     sendmsg4
3025     sendmsg6
3031     recvmsg4
3026     recvmsg6
3028     getpeername4
3023     getpeername6
/sys/fs/cgroup/kubernetes.slice
    4217     ingress         multi
    4216     egress          multi
[...snip...]

@Managarmrr Thanks for the detailed issue.

After hours of debugging it turned out, that cilium attached to the pod-internal cgroups, meaning that bpf was working properly, just inside of the pod.

Is cilium-agent running in non-host netns (namespace = ciliumNamespace)?

Oh sorry that might be confusing, no cilium is just deployed into ciliumNamespace in k8s, which in turn is kube-system:
{ config, lib, pkgs, ... }:

with lib;
let
  infraLib = import <infraLib> { config = config; lib = lib; };

  cniConfig = {
    cniVersion = "0.3.1";
    name = "cilium";
    type = "cilium-cni";
    enable-debug = false;
  };

  customConf = pkgs.buildEnv {
    name = "k8s-cni-config";
    paths = [ (pkgs.writeTextDir "05-cilium.conf" (builtins.toJSON cniConfig)) ];
  };

  configMapName = "cni-configuration";
  ciliumNamespace = "kube-system";
in
with infraLib;
{
  # [...snip...]
}

Could you paste cilium-agent log from a previous run when you didn't specify the cgroup root? Also, was /var/run/cilium mounted into the cilium container?

Sorry for the delay, I was really busy fixing our setup and meeting the deadline on Monday. Anyway, I could give you the logs, but I could also just spawn ou guys a test instance with all the settings and grant you root access for easier debugging. Which do you prefer? if you decide to go for the server access (don't worry about time-frames etc, we are very flexible) just DM me all the necessary SSH keys.

SSH access would be the fastest way to debug - https://github.com/brb.keys (I'm martynas on the Slack). Thanks.

@Managarmrr this will be resolved by https://github.com/cilium/cilium/pull/16259.


Swagger schema validation failed on Python 3.7.13

Hello again,
The schema todo app produces this openapi.json:
{"components":{"schemas":{}},"info":{"title":"todo","version":"0.1.0"},"openapi":"3.0.3","paths":{"/":{"post":{"parameters":[],"requestBody":{"content":{"application/json":{"schema":{"properties":{"due":{"format":"date-time","title":"Due","type":"string"},"task":{"title":"Task","type":"string"}},"required":["task","due"],"title":"Todo","type":"object"}}}},"responses":{"201":{"content":{"application/json":{"schema":{"properties":{"due":{"format":"date-time","title":"Due","type":"string"},"task":{"title":"Task","type":"string"}},"required":["task","due"],"title":"Todo","type":"object"}}},"description":"Todo(task: str, due: Union[datetime.datetime, NoneType])"}}}},"/ws":{"get":{"parameters":[],"responses":{}}}},"servers":[],"tags":[]}

https://apitools.dev/swagger-parser/online/ produces:
Swagger schema validation failed.
  #/paths/~1ws/get/responses must NOT have fewer than 1 properties

Error: Swagger schema validation failed.
  #/paths/~1ws/get/responses must NOT have fewer than 1 properties

    at o (https://apitools.dev/swagger-parser/online/js/bundle.min.js:1:95564)
    at https://apitools.dev/swagger-parser/online/js/bundle.min.js:29:45042

SyntaxError: Swagger schema validation failed.
  #/paths/~1ws/get/responses must NOT have fewer than 1 properties

    at Function.o [as syntax] (https://apitools.dev/swagger-parser/online/js/bundle.min.js:1:95564)
    at validateSchema (https://apitools.dev/swagger-parser/online/js/bundle.min.js:1:6322)
    at SwaggerParser.validate (https://apitools.dev/swagger-parser/online/js/bundle.min.js:1:3391)

Any idea as to why?
Regards,
Scott.

I assume the /ws path is a websocket route? In which case I think the issue is that there is no way to describe a websocket in OpenAPI.

Fixed in b68eaa0d8b7f1d9a60383ff489e35010f4fd7d6d


Allow consumeFirstStringMessageFrom to be called multiple times

In older versions of scalatest-embedded-kafka you were able to call
consumeFirstStringMessageFrom multiple times, with each invocation
causing the next message in a topic to be consumed. In the latest
version this is no longer the case: the first invocation works fine, but
subsequent invocations would result in exceptions as the first
invocation would cause all messages to be committed even though only
the first one is returned. We fix this by disabling auto-commit and
simply committing only the message that consumeFirstStringMessageFrom
returns.

Just to make sure we're on the same page, when you're talking about adding documentation are you just talking about adding a comment to the appropriate line in EmbeddedKafka.scala? Or updating README.md?

Scaladoc would be enough I'd say.

I've addressed your feedback and have squashed my changes into my previous commit. Let me know if you have any other feedback. Thanks!

Thanks @alexadriaanse - I just need to verify how the new config value for EmbeddedKafkaConfig plays together with customBrokerProperties. Don't have time to do it now but I'll have a look at it over the weekend. I'm sure I can get a release done before Xmas. Thanks for contributing!


Windows samples from Build pipeline

Description
A sample to connect to windows host from build pipeline.
Fixes # (issues)
New samples # (demos / Illustrations )
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[x] Free Tier
[x] Always Free
[x] Paid

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Updated/Sorted AIO.md file
[x] My changes generate no new warnings.
[x] All the sensitive information are masked or removed.
[x] All the links mentioned are valid and tested.
[x] Image names are separated only with '-'.
[x] Added instruction to clone only this sample and links to other common sample pages.

I have read the CLA Document and I hereby sign the CLA

recheck


[style]: Color Palette Update

What's the style idea?
Here's what I propose-
I think we should completely overhaul the website's color palette to introduce a sleek, dark theme that provides a contemporary, visually appealing experience for users. I've always found dark themes to be more modern and sophisticated, not to mention easier on the eyes, especially during long viewing sessions. For this redesign, the dark background should be complemented with vibrant accent colors, like electric blue or deep purple, which would make the generated images really stand out and catch users' attention. This change isn't just about aesthetics—it's about creating a more comfortable, enjoyable experience for our users. Implementing this upgrade would undoubtedly enhance the overall usability and attractiveness of the platform, making it not only more engaging but also more accessible and user-friendly. After all, a sleek and visually appealing interface can make a significant difference in how users perceive and interact with the platform.
Add screenshots
Add screenshots

I propose to change the color pallete
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Go ahead @snehas-05 , I will directly assign the level in the PR as I can't see the developed site now


⚠ RPC server - Conflux has degraded performance

In b6cf734, RPC server - Conflux ($CONFLUX_RPC_URL) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: RPC server - Conflux performance has improved in ee72ec4 after 5 minutes.


Add docs about AppResourceLoader

There is already https://yakworks.github.io/view-tools/app-resources/
Check if needs to be updated


rpc: Fix inconsistencies in gobject_prepare and gobject_submit

The parameter description for some parameter declare them as numeric e.g. https://github.com/dashpay/dash/blob/b3c830686758886aa9d026a3c07ac119709cc20d/src/rpc/governance.cpp#L129
However they get fetched witch get_str() like in here https://github.com/dashpay/dash/blob/b3c830686758886aa9d026a3c07ac119709cc20d/src/rpc/governance.cpp#L160
Providing numbers there throws an RPC error prior to this PR because of a type check https://github.com/dashpay/dash/blob/b3c830686758886aa9d026a3c07ac119709cc20d/src/univalue/lib/univalue_get.cpp#L99-L100
7104550 Using ParseInt32V, ParseInt64V and getValStr fixes this issue with backwards compatibility i.e. it accepts integer strings and just integers.
62e7689 Adjusts some parameter namings

@PastaPastaPasta I agree, there is a need for tests in the governance parts of the code but that exceeds the scope of this PR, no? Added a note about missing tests to the backlog. I realised this issue while i was writing tests for dash related ZMQ handler.. will open a PR for that soon which covers at least the minimal usage of those two commands.


fix: Tapping the carousel buttons triggers page zoom

This fixes issue #76. Please let me know if you like commits/PRs in a particular format.

Thanks for the fix!


Drawer tests

Accessibility tests for drawer cannot be written at the moment since it requires specific style rules to be checked, for example, left or right properties, position, etc.

@rishichawda Lets ignore style related things for now. We will be coming back to that anyway later.


Span tags in title

I think you mentioned this before, should I remove the span tags in the site title?

yes i believe i fixed this in my latest branch but you should make sure they are not appearing in the meta data


BUG - Make Single View Multi-sig Proposal Hero Section Smaller

The hero section of the single multi-sig proposal view takes up too much room on desktop and mobile. There should only be ~1 inch of padding on the top and bottom of the heading/action buttons so that the space usage is optimized.
Screenshots

Desktop details:
All browsers and operating systems.
Smartphone details:
All browsers and operating systems.

fixed with https://github.com/telosnetwork/open-block-explorer/pull/226


case is incorrect in contents addtabStateChange should be addTabStateChange

In the contents on LHS this method is shown ad addtabStateChange but it should be addTabStateChange because case is significant in JavaScript

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c2a4cc8-11ca-0379-445a-ca8cdde8664b
Version Independent ID: efe6fd94-6494-d278-a935-ca9aa9dc4c03
Content: addTabStateChange (Client API reference) in model-driven apps - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/formContext-ui-tabs/addTabStateChange.md
Service: powerapps
GitHub Login: @adrianorth
Microsoft Alias: jdaly

Thanks for your comment, @JamesHorsley. This issue has been assigned to the doc author for review.

Fixed the table of contents to match. addtabStateChange to be addTabStateChange


Build/Start hangs when building node image

Description
OS
My OS is:

[x] MacOS [Sierra]
[ ] Linux
[ ] Windows

Docker
The output of docker version:
Client:
 Version:	17.12.0-ce
 API version:	1.35
 Go version:	go1.9.2
 Git commit:	c97c6d6
 Built:	Wed Dec 27 20:03:51 2017
 OS/Arch:	darwin/amd64

Server:
 Engine:
  Version:	17.12.0-ce
  API version:	1.35 (minimum version 1.12)
  Go version:	go1.9.2
  Git commit:	c97c6d6
  Built:	Wed Dec 27 20:12:29 2017
  OS/Arch:	linux/amd64
  Experimental:	true

The output of docker-compose version:
docker-compose version 1.18.0, build 8dd22a9
docker-py version: 2.6.1
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2j  26 Sep 2016

(This might be a dupe of #71 but since the end result I'm getting is very different (I'm never getting any error message) I decided to open this as a new issue. If you feel it's the same, I'm happy to close this and report on that issue instead.)
On a fresh install, after successfully running init, ./vessel start and/or ./vessel build seems to get stuck and hang indefinitely on step 6 of building the node image, I believe while trying to download and install yarn.

As a test I've tried starting a new project from scratch a few times, and am seeing this happen consistently. Just for kicks, I let it run for as long as 15min but it never seems to be able to get past
Step 6/6 : RUN usermod -u $uid node
 ---> Running in 025a20fb8d20

Could this be caused by that apt-utils error debconf: delaying package configuration, since apt-utils is not installed?
Thanks for this project. I'm really looking forward to getting my feet wet with docker!

I’ll have to check - I think a recent version of the node base container
changed recently in a way that breaks the build.
On Sat, Mar 17, 2018 at 16:33 Brandon Kalber<EMAIL_ADDRESS>wrote:

Description OS
My OS is:

MacOS [Sierra]
Linux
Windows

Docker
The output of docker version:
Client:
Version:	17.12.0-ce
API version:	1.35
Go version:	go1.9.2
Git commit:	c97c6d6
Built:	Wed Dec 27 20:03:51 2017
OS/Arch:	darwin/amd64
Server:
Engine:
Version:	17.12.0-ce
API version:	1.35 (minimum version 1.12)
Go version:	go1.9.2
Git commit:	c97c6d6
Built:	Wed Dec 27 20:12:29 2017
OS/Arch:	linux/amd64
Experimental:	true
The output of docker-compose version:
docker-compose version 1.18.0, build 8dd22a9
docker-py version: 2.6.1
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2j  26 Sep 2016
(This might be a dupe of #71
https://github.com/shipping-docker/vessel/issues/71 but since the end
result I'm getting is very different (I'm never getting any error message)
I decided to open this as a new issue. If you feel it's the same, I'm happy
to close this and report on that issue instead.)
On a fresh install, after successfully running init, ./vessel start
and/or ./vessel build seems to get stuck and hang indefinitely on step 6
of building the node image, I believe while trying to download and install
yarn.
[image: screen shot 2018-03-17 at 4 53 54 pm]
https://user-images.githubusercontent.com/1141607/37560060-8cd7f616-2a07-11e8-9599-81486acb0e2a.png
As a test I've tried starting a new project from scratch a few times, and
am seeing this happen consistently. Just for kicks, I let it run for as
long as 15min but it never seems to be able to get past
Step 6/6 : RUN usermod -u $uid node
---> Running in 025a20fb8d20
Could this be caused by that apt-utils error debconf: delaying package
configuration, since apt-utils is not installed?
Thanks for this project. I'm really looking forward to getting my feet wet
with docker!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/shipping-docker/vessel/issues/72, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAch06-GOK1BL_nFMkt5Vj_eVXY1MJfRks5tfYFCgaJpZM4Su-TT
.

Hi, I'm facing the same problem, any update?
OS
My OS is:

[ ] MacOS [Choose one: Yosemite, El Capitan, Sierra, High Sierra]
[x] Linux [Debian 9 / Stretch]
[ ] Windows

Docker
The output of docker version:
Client:
 Version:       18.03.0-ce
 API version:   1.37
 Go version:    go1.9.4
 Git commit:    0520e24
 Built: Wed Mar 21 23:10:06 2018
 OS/Arch:       linux/amd64
 Experimental:  false
 Orchestrator:  swarm

Server:
 Engine:
  Version:      18.03.0-ce
  API version:  1.37 (minimum version 1.12)
  Go version:   go1.9.4
  Git commit:   0520e24
  Built:        Wed Mar 21 23:08:35 2018
  OS/Arch:      linux/amd64
  Experimental: false

The output of docker-compose version:
docker-compose version 1.20.1, build 5d8c71b
docker-py version: 3.1.4
CPython version: 3.6.4
OpenSSL version: OpenSSL 1.0.1t  3 May 2016

Really appreciate the help.

Whoops, this one I'll bet was just a temporary issue with Yarn. Let me know if not, however.

i'm running into the same issue:
Building node
Step 1/6 : FROM node:latest
latest: Pulling from library/node
f2b6b4884fc8: Pull complete
4fb899b4df21: Pull complete
74eaa8be7221: Pull complete
2d6e98fe4040: Pull complete
452c06dec5fa: Pull complete
7b3c215894de: Pull complete
b022daa6522d: Pull complete
261d9f7fbd08: Pull complete
Digest: sha256:bd6c5415c7e8be74a9cab65972df41a5464f032a6034b488a2138e887b74bd28
Status: Downloaded newer image for node:latest
 ---> 814364d36f69
Step 2/6 : LABEL maintainer="Chris Fidao"
 ---> Running in 227ac83ce0f8
Removing intermediate container 227ac83ce0f8
 ---> 52b71b9f7012
Step 3/6 : WORKDIR /var/www/html
Removing intermediate container 4779080c0583
 ---> 6f9ec1798a00
Step 4/6 : ARG uid=999
 ---> Running in 18de10098d8c
Removing intermediate container 18de10098d8c
 ---> 117cb93e253f
Step 5/6 : RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -     && echo "deb http://dl.yarnpkg.com/debian/ stable main" > /etc/apt/sources.list.d/yarn.list     && apt-get update     && apt-get install -y git yarn     && apt-get -y autoremove     && apt-get clean     && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
 ---> Running in bbc62610b834
OK
Get:1 http://dl.yarnpkg.com stable InRelease [11.5 kB]
Get:2 http://security.debian.org jessie/updates InRelease [63.1 kB]
Ign http://deb.debian.org jessie InRelease
Get:3 http://deb.debian.org jessie-updates InRelease [145 kB]
Get:4 http://dl.yarnpkg.com stable/main amd64 Packages [6780 B]
Get:5 http://deb.debian.org jessie Release.gpg [2434 B]
Get:6 http://security.debian.org jessie/updates/main amd64 Packages [643 kB]
Get:7 http://deb.debian.org jessie Release [148 kB]
Get:8 http://deb.debian.org jessie-updates/main amd64 Packages [23.1 kB]
Get:9 http://deb.debian.org jessie/main amd64 Packages [9064 kB]
Fetched 10.1 MB in 31s (320 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
git is already the newest version.
Recommended packages:
  nodejs
The following NEW packages will be installed:
  yarn
0 upgraded, 1 newly installed, 0 to remove and 5 not upgraded.
Need to get 691 kB of archives.
After this operation, 4403 kB of additional disk space will be used.
Get:1 http://dl.yarnpkg.com/debian/ stable/main yarn all 1.5.1-1 [691 kB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 691 kB in 0s (1903 kB/s)
Selecting previously unselected package yarn.
(Reading database ... 21671 files and directories currently installed.)
Preparing to unpack .../archives/yarn_1.5.1-1_all.deb ...
Unpacking yarn (1.5.1-1) ...
Setting up yarn (1.5.1-1) ...
Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 5 not upgraded.
Removing intermediate container bbc62610b834
 ---> e38be98d9dbc
Step 6/6 : RUN usermod -u $uid node
 ---> Running in 840b9f80698d

CPU load goes above 280% for "com.docker.hyperkit"
i have to kill the process manually.
macOS 10.13.3
Docker version 18.03.0-ce, build 0520e24
docker-compose version 1.20.1, build 5d8c71b
if you need anything else, let me know

Same issue here


FileNotFoundError: [Errno 2] Client secret file does not exist.: 'credentials.json'

I'm not sure what I'm doing wrong. Did the git clone, downloaded and placed credentials.json in the directory. Running the script manually writes the values to the spreadsheet:
$ ./speedtest-charts.py
Checking OAuth validity...
Starting speed test...
Starting speed finished!
Writing to spreadsheet...
Successfuly written to spreadsheet!

The cron job doesn't get this done. Calling the symlink manually runs fine, logs to the spreadsheet.The errors show up in /var/mail/pi:
$ ll /usr/local/bin/speedtest-to-google
lrwxrwxrwx 1 root staff 51 May 18 17:58 /usr/local/bin/speedtest-to-google -> /home/pi/google-speedtest-chart/speedtest-charts.py

$ crontab -l
*/1 * * * * PATH=$PATH:/usr/local/bin /usr/local/bin/speedtest-to-google

$ tail -f /var/mail/pi
  File "/usr/local/bin/speedtest-to-google", line 62, in main
    credentials = get_credentials()
  File "/usr/local/bin/speedtest-to-google", line 15, in get_credentials
    gc = pygsheets.authorize(outh_file="credentials.json")
  File "/home/pi/.local/lib/python3.5/site-packages/pygsheets/client.py", line 592, in authorize
    outh_nonlocal=outh_nonlocal)
  File "/home/pi/.local/lib/python3.5/site-packages/pygsheets/client.py", line 549, in get_outh_credentials
    raise IOError(2, "Client secret file does not exist.", client_secret_file)
FileNotFoundError: [Errno 2] Client secret file does not exist.: 'credentials.json'

Any ideas? Been scratching my head for quite a bit now.
Oh, and this is on a RPi 3.

As a test, can you try call the "speedtest-to-google" file directly instead of via the symlink?
Looks like a path issue - perhaps like the program is expecting the json file to be in /usr/local/bin/
I'll run it up here and see if I get the same issue.

Thanks for responding! New errors this time around when running the cron.
I specified the absolute path:
$ grep credentials.json /usr/local/bin/speedtest-to-google
#    gc = pygsheets.authorize(outh_file="credentials.json")
    gc = pygsheets.authorize(outh_file="/home/pi/google-speedtest-chart/credentials.json")

Calling "speedtest-to-google" runs fine, logs to the spreadsheet:
 $ speedtest-to-google
Checking OAuth validity...
Starting speed test...
Starting speed finished!
Writing to spreadsheet...
Successfuly written to spreadsheet!

Crons, however:
$ crontab -l | tail -n1
*/1 * * * * PATH=$PATH:/usr/local/bin /usr/local/bin/speedtest-to-google

$ tail -f /var/mail/pi
...
From: root@server (Cron Daemon)
To: pi@server
Subject: Cron <pi@server> PATH=$PATH:/usr/local/bin /usr/local/bin/speedtest-to-google
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Cron-Env: <SHELL=/bin/sh>
X-Cron-Env: <HOME=/home/pi>
X-Cron-Env: <PATH=/usr/bin:/bin>
X-Cron-Env: <LOGNAME=pi>
Message-Id: <E1fJo2g-0006Kp-KG@server>
Date: Sat, 19 May 2018 08:40:06 +1000

Checking OAuth validity...

Failed to start a local webserver listening on either port 8080
or port 8090. Please check your firewall settings and locally
running programs that may be blocking or using those ports.

Falling back to --noauth_local_webserver and continuing with
authorization.

Go to the following link in your browser:

    https://accounts.google.com/o/oauth2/auth?client_id=XXXXX-XXXXXXXXXXXXXXXXxxxxxxxxxxxxxXXXXXX.apps.googleusercontent.com&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&access_type=offline&response_type=code&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fspreadsheets+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive

Enter verification code: Traceback (most recent call last):
  File "/usr/local/bin/speedtest-to-google", line 82, in <module>
    main()
  File "/usr/local/bin/speedtest-to-google", line 63, in main
    credentials = get_credentials()
  File "/usr/local/bin/speedtest-to-google", line 16, in get_credentials
    gc = pygsheets.authorize(outh_file="/home/pi/google-speedtest-chart/credentials.json")
  File "/home/pi/.local/lib/python3.5/site-packages/pygsheets/client.py", line 592, in authorize
    outh_nonlocal=outh_nonlocal)
  File "/home/pi/.local/lib/python3.5/site-packages/pygsheets/client.py", line 555, in get_outh_credentials
    credentials = tools.run_flow(flow, store, lflags)
  File "/home/pi/.local/lib/python3.5/site-packages/oauth2client/_helpers.py", line 133, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/home/pi/.local/lib/python3.5/site-packages/oauth2client/tools.py", line 240, in run_flow
    code = input('Enter verification code: ').strip()
EOFError: EOF when reading a line

which is weird, because I'm sure I authenticated this before. Anyhow, opened up the link on the pi again, and after allowing access, I get a success code as below:

Do I need to specify this somewhere?

Can you check your home directory for either a .google directory or a .credentials directory? If so, do they have any files in them?  One of them should...I think I remember running into this a while ago...  when you do the authorization with an Oauth ID, a file is stored in one of those dirs (I think).  I wonder if when running the cronjob, that directory is not being seen, thus you get the request for authorization again.
Perhaps you could try a different way of authorizing your pi for this script...
As I read over the howto on enabling access for pygsheets, the method I used is definitely different as I dont even get the request for authorization that you are seeing. On my mini server, I set up a service account instead of an Oauthclient ID and then gave the associated email address access to the speedtest sheet manually...  This would possibly explain why my cronjob works.  Its 11pm here - I'll try an auth account tomorrow some time in place of the service account.
I'd suggest you try a service account in place of your Oauth ID...

@IamSierraCharlie I really appreciate your responses, mate!
I don't see those directories, just ran a find too.
This is all pretty new to me, I'll research further into how to set up a service account, I'll get back to you in a day or so.

Okay,  I ran up a OAuth account and I see this.....
Starting speed test... Storing credentials to /home/scarter/Documents/new/google-speedtest-chart/sheets.googleapis.com-python.json Starting speed finished! Writing to spreadsheet... Successfully written to spreadsheet!
The above when I call the script from the command line.....
I note that sheets.googleapis.com-python.json is the stored file - its actually in the speed test directory as you can see from the info above...
Now, when I replicate your issue, I end up with the same when running a cron job....
`Checking OAuth validity...
Go to the following link in your browser:
https://accounts.google.com/o/oauth2/auth?response_type=code&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fspreadsheets+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive&access_type=offline&client_id=743728854413-8h4fsltkn32of8bm0t5qe3k9267fij3q.apps.googleusercontent.com

Enter verification code: Traceback (most recent call last):
File "/usr/local/bin/speedtest-to-google", line 49, in
main()
File "/usr/local/bin/speedtest-to-google", line 32, in main
credentials = get_credentials()
File "/usr/local/bin/speedtest-to-google", line 15, in get_credentials
gc = pygsheets.authorize(outh_file="/home/scarter/Documents/new/google-speedtest-chart/credentials.json", outh_nonlocal=True)
File "/home/scarter/.local/lib/python3.5/site-packages/pygsheets/client.py", line 547, in authorize
outh_nonlocal=outh_nonlocal)
File "/home/scarter/.local/lib/python3.5/site-packages/pygsheets/client.py", line 509, in get_outh_credentials
credentials = tools.run_flow(flow, store, lflags)
File "/home/scarter/.local/lib/python3.5/site-packages/oauth2client/_helpers.py", line 133, in positional_wrapper
return wrapped(*args, **kwargs)
File "/home/scarter/.local/lib/python3.5/site-packages/oauth2client/tools.py", line 240, in run_flow
code = input('Enter verification code: ').strip()
EOFError: EOF when reading a line`
After some reading on the issue, - for example https://github.com/plamere/spotipy/issues/108
Running the cron job the way you are does not appear to be ideal.  The issue is that your cronjob doesnt see the directory that the command originates from - as a result, those required files are missing.... as far as the script is concerned.  I hope I'm making sense here :-)
There are many ways around this...
First being to use a service account.
Second one being to change your cron job to something like this:
cd ///google-speedtest-chart && /usr/local/bin/speedtest-to-google
in my case for example:
0 * * * * cd /home/scarter/Documents/new/google-speedtest-chart && /usr/local/bin/speedtest-to-google
This also works:
0 * * * *  cd /home/scarter/Documents/new/google-speedtest-chart && ./speedtest-charts.py
This sets the running directory to that of the speedtest-chart directory so when you run the speed test, those fines required are available to the script..
I've tested the above and it works for me even with an Oauth client file.
While I've no doubt there are many other ways to make this work (probably better than what I've offered up), I'm just not expert enough in this field - as a result, I use what works :-D
If anyone else sees this, comments and constructive criticism are welcomed all in the name of learning.
For all the messing around tho, I'd personally will stick with using the service account - especially if you don't plan on sharing this script with anyone else.
Last comment - I note your cron job runs quite frequently - is it fair to say that this is because of the need to test this issue as opposed to what you actually plan on running it?
best of luck again - I think you are in the home straight!!!

I followed your second suggestion, worked like a charm.

is it fair to say that this is because of the need to test this issue as opposed to what you actually plan on running it?

Indeed, was running it every minute to test.
I really appreciate your help on this one, you went above and beyond troubleshooting this for me, and explaining it all like a champ!
I'm not sure what the etiquette is for thanking people on github is (I'm fairly new here, as you would've guessed), you deserve some solid stars here!

ha - all good mate - just pay it forward when you get the opportunity.
also - close out the issue if this one is resolved.

Will do, thanks again!

@IamSierraCharlie Thanks a ton for supporting @mjsan on this <3
I totally agree with you guys - definitely have to update/rewrite the README to reflect the changes which were introduced when adding oAuth support.
Unfortunately I don't have much spare time lately, so all my little side projects are a bit neglected :(

@frdmn - no problem!!  Happy to help

@frdmn Thanks for putting all of this together in the first place!
Btw, how do I open a feature request ;) ? Do I open a new issue?


Accept Proposal should reuse credential definition id from the Proposal

accepting a proposal should take the credential definition id from the proposal to send a credential offer (if availalbe on the proposal). This functionality was there for v1 (and still is: https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/credentials/protocol/v1/V1CredentialService.ts#L204-L205), but itsn't present in v2. We should probably extract this from the proposal in the indy credential format service so we can reuse it across the v1 and v2 implementation. Currently throws an error that it is missing the credential definition id. It also means the user has to retrieve the message and extract the credential definition from the proposal themselves.
Same for the attributes, it shouldn't be required to pass the attributes when accepting a proposal as we can take them from the proposal (but should be optional for the case where there was no proposal preview and thus no attributes)

As per comment from @swcurran we need to ensure that this is valid, ie if the cred-def-id in the proposal is not one the issuer owns, they can't issue such a credential, so that check is a minimum.

This is fixed


Read operations are not visible in Read regions

Hi, I followed this instruction but the reads seem to happen at the Write region
What i did:

Add &readPreference=secondaryPreferred&maxStalenessSeconds=60 to the ReadOnly connection string.
In .NET code, here is how i get the collection:

private IMongoCollection<T> GetCollection(bool readOnly = false)
{
	var client =  new MongoClient(new MongoUrl(_options.Value.MongoConnectionStringReadonly));
	var db = client.GetDatabase(_options.Value.DatabaseId, new MongoDatabaseSettings
	{
		ReadPreference = readOnly
			? ReadPreference.SecondaryPreferred
			: ReadPreference.Primary
	});

	return db.GetCollection<T>(_options.Value.ProjectionCollectionId, new MongoCollectionSettings
	{
		ReadPreference = readOnly
			? ReadPreference.SecondaryPreferred
			: ReadPreference.Primary
	});
}

But the cosmos metric dashboard seem to not show anything in Read region

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77bd84a1-96ce-79e8-3c6a-11864759ece2
Version Independent ID: b1b9bc7b-27df-7b1e-0b4d-cccd59b44381
Content: Using MongoDB Read Preference with the Azure Cosmos DB's API for MongoDB
Content Source: articles/cosmos-db/mongodb-readpreference.md
Service: cosmos-db
Sub-service: cosmosdb-mongo
GitHub Login: @sivethe
Microsoft Alias: sivethe

@vanthoainguyen, Thanks for the question! We are taking a look into this and will get back to you soon.

@vanthoainguyen Are you wanting to perform read operations to the Secondary or are you wanting to perform read operations from a specific region? If you are wanting to perform read operations from a specific region, can you implement Tags. The following code snippet is an example. Specific information about tags can be found: Read using tags.

JaveScript Example:
{readPreference: new ReadPreference(ReadPreference.SECONDARY_PREFERRED, {"region": "West US"})}

.NET C#

        //Read using tags
        Tag tg = new Tag("region", readRegion);
        List<Tag> tgs = new List<Tag>();
        tgs.Add(tg);
        List<TagSet> tgSets = new List<TagSet>();
        tgSets.Add(new TagSet(tgs));
        ReadPreference rp = new ReadPreference(ReadPreferenceMode.SecondaryPreferred, tgSets);

I want to read from Secondary, assuming Secondary is ReadOnly region which is Australia South East as seen in the photo?
Could you tell anything wrong with my code if I wanted to do so?

@sivethe Could you please help with this issue.
I was able to reproduce the same behavior.
I tried using the code sample  with read preference set to ReadPreferenceMode.SecondaryPreferred but cannot see any throughput on the secondary

Forcing the preference to ReadPreferenceMode.Secondary results in the below exception

A timeout occured after 30000ms selecting a server using CompositeServerSelector{ Selectors = ReadPreferenceServerSelector{ ReadPreference = { Mode : Secondary, TagSets : [{ region : Japan West }] } }, LatencyLimitingServerSelector{ AllowedLatencyRange = 00:00:00.0150000 } }. Client view of cluster state is { ClusterId : "1", ConnectionMode : "ReplicaSet", Type : "ReplicaSet", State : "Connected", Servers : [{ ServerId: "{ ClusterId : 1, EndPoint : "Unspecified/cdb-ms-prod-westus2-fd20.documents.azure.com:10255" }", EndPoint: "Unspecified/cdb-ms-prod-westus2-fd20.documents.azure.com:10255", State: "Connected", Type: "ReplicaSetPrimary", WireVersionRange: "[0, 2]", LastUpdateTimestamp: "2019-11-25T09:53:15.2717759Z" }] }.

This scenario should work, and it does on a sample app I created - please share the connection string you are using (key redacted), driver version, and the command you are executing that does not go to the read region.

Thank for your quick response
Connection string: mongodb://wow-d-dx-cosmos-aae-orders:*********************@wow-d-dx-cosmos-aae-orders.documents.azure.com:10255/?ssl=true&replicaSet=globaldb
.NET CORE MongoDB driver version 2.8.1
The command i used is simply a search by Id. We've never seen traffic in the other region so i think it's the issue either with Cosmos or MongoDB .NET Driver.

Hi Van. Our apologies for the extraordinary time it has taken to resolve this. Thank you for your patience.
We would like to resolve this issue but we need to take offline to better do this. I will contact you at your email address on your GitHub profile so we can resolve.
Thanks.

@markjbrown do you think we should close this issue here and track it via email for any doc updates?

Yes, will close. This isn't a docs fix anyway but will unblock Van here offline.  --Thanks.
#please-close


chore: Update serialisation

This PR adds lots of serialisation methods and tests to noir-protocol-circuits.

Merging some fixes

snuck in a change so my drive-by fixes still build on your machine

Looks great! I'd double check the change to the ci workflow inputs with @ludamad

These changes were done by Adam I think! Certainly not by me.


community[major]: Add Together AI LLM integration

Created entry point inside @langchain/community. It is not exported from langchain.

Looks good to me! Thank you!


Do we still need the "Leaf-TXN" token concept.

Now that nested tokens are removed, should we retain the leaf txn concept?
Suggestion is to remove all mention of "leaf-txn token" throughout the doc.

Decision to remove.


Add rule W2530 to warn when SnapStart isn't configured correctly

Issue #, if available:
fix #2903
Description of changes:

Add rule W2530 to warn when SnapStart isn't configured correctly
Add rule I2530 to warn when SnapStart isn't configured on Java11 and Java17 runtimes
Add rule E2530 to error when SnapStart is configured on an unsupported runtime

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@greenwoodcm and @msailes some updates have been made based on your feedback


[Snyk] Upgrade html-snapshots from 3.6.3 to 3.7.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade html-snapshots from 3.6.3 to 3.7.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 10 days ago, on 2024-04-26.

Release notes

Package name: html-snapshots

3.7.1 -<EMAIL_ADDRESS>

3.7.0 -<EMAIL_ADDRESS>

3.6.3 -<EMAIL_ADDRESS>

    from html-snapshots GitHub release notes

Commit messages

Package name: html-snapshots

a387042 Merge pull request #703 from localnerve/rc-3.7.1
0366a58 Merge branch 'master' into rc-3.7.1
8831a74 Merge pull request #704 from localnerve/snyk-upgrade-84c9983c2648a6025ef522e38991c42f
3be0431 fix: upgrade html-snapshots from 3.6.3 to 3.7.0
6e96e2d @ 3.7.1 -<EMAIL_ADDRESS>d42a4d0 Merge pull request #702 from localnerve/rc-3.7.0
de4ed0c @ 3.7.0 -<EMAIL_ADDRESS>5dfe716 Merge pull request #701 from localnerve/snyk-upgrade-fad9419460e2a0c172d482dd1ee92286
efd39f7 fix: upgrade html-snapshots from 3.6.2 to 3.6.3
50057ee Merge pull request #700 from localnerve/snyk-upgrade-53dbc873325f7cc6fd5daf50bf5ed9f5
b9afe66 fix: upgrade html-snapshots from 3.6.2 to 3.6.3
91b0b16 Merge pull request #699 from localnerve/snyk-upgrade-9af950d1254f34d3ce0584cfa7c26563
21f92db fix: upgrade html-snapshots from 3.6.2 to 3.6.3
d64727f Merge pull request #698 from localnerve/snyk-upgrade-d89078e5f4ae2ea2329594eaac60e8a0
9c6db67 fix: upgrade html-snapshots from 3.6.2 to 3.6.3
403f489 Merge pull request #697 from localnerve/snyk-upgrade-67208043f8553111052dbdc17e065a92
b6e8fc0 fix: upgrade html-snapshots from 3.6.2 to 3.6.3
63bcd0c Merge pull request #695 from localnerve/snyk-upgrade-9e40748e2f7d38d1b2e6f5be18748c27
be19068 Merge pull request #696 from localnerve/snyk-upgrade-31b09fc1185d3fa5e188bff37ecb060e
861b4a3 fix: upgrade html-snapshots from 3.6.1 to 3.6.3
8c5933b fix: upgrade html-snapshots from 3.6.1 to 3.6.3
d771cda Merge pull request #692 from localnerve/snyk-upgrade-8bf2d7f8c3c2362e24d69c86fbcca47c
eb6cf98 Merge pull request #694 from localnerve/snyk-upgrade-e934bea5a2e69547c577a06d0b98429a
e143bc2 Merge pull request #690 from localnerve/snyk-upgrade-35f03e14225562c005702353ae3c24b2

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 99.245%. remained the same
when pulling b60b6fc0ca9a8294226667090d78030b3af78a03 on snyk-upgrade-0f1c701c8969082b7d02603a55615692
into 94c543f64d30a34a96478547a5064e15c164fd71 on master.


UI not accessible

When executing ./riotpot and calling localhost:2022 then I get a 404

Hey there! since the GSoC 2023 the repository has been moved to (here)[https://github.com/honeynet/riotpot].
Please use the code in that repository instead and let us know if you still have the same issue! :)


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 3.0.24 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to add borders between countries?

Like this:

Hi @fof-fa
Just add this line to the SimpleMap widget
  countryBorder: CountryBorder(color: Colors.white, width: 1),

Hi @LauDijksterhuis,
First of all, thank you for providing this amazing package, which has been instrumental in my project. I truly appreciate your work!
However, I am encountering a significant issue regarding country borders that could prevent my application from being published on app stores. Here's the situation:
Problem Description

Risks with Country Borders
Many app stores (e.g., Apple App Store, Google Play Store) have strict policies regarding maps, especially when it comes to representing political boundaries. Certain countries have disputes over territorial borders, and displaying such boundaries (even unintentionally) can lead to compliance issues, rejection during app review, or even legal complications in specific regions.

Setting countryBorder to null Still Displays Borders
I attempted to set countryBorder to null, hoping to completely remove all visual indications of borders. However, fine boundary lines are still visible on the map, which makes it unsuitable for avoiding the risks mentioned above.

Suggestions for Improvement

Option to Completely Remove Borders
It would be incredibly helpful to have an option to render the map without any visual indication of country borders, ensuring a completely boundary-free map for certain use cases. This could be a boolean parameter (e.g., showBorders: false) or an enhancement to the existing countryBorder implementation to truly hide all borders when set to null.

Support for Imprecise or Generalized Borders
To mitigate risks, another useful feature would be the ability to display simplified or less precise border lines. For example:

Using generalized or smoothed boundary shapes.
Representing regions without implying exact political borders.
Allowing customization of border rendering styles to avoid potential sensitivities (e.g., dashed lines, faint colors).

These features would provide developers with more flexibility and help avoid risks related to map usage in applications targeting international markets.
Questions

Is there currently a way to completely hide borders that I might have overlooked?
Would you consider implementing the above suggestions or providing guidance on how to achieve these capabilities using this package?

Thank you for your time and for considering these points. I believe adding such features will greatly enhance the utility and compliance of this package for a wider range of developers.
Looking forward to your thoughts!


base-16: nvim-tree: fix GitDirty circular link, update GitNew to match gitsigns

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Hello from nvim-tree
NvimTreeGitDirty was linking to itself. Used 0E as per gitsigns.
Updated NvimTreeGitNew from 0D to 0A as per neo-tree for better legibility.

Thanks! I didn't think linking to itself is even possible... I think it was meant to be linked to NvimTreeGitDeleted as per 'nvim-tree' default colors. But I like your second reasoning more: making it more aligned with 'neo-tree' seems like a better choice. In 'nvim-tree' NvimTreeGitDirty is used for unstaged files, so will make it aligned with NeoTreeGitUnstaged, i.e. base08 (which also the same for NvimTreeGitDeleted).
Change of NvimTreeGitNew to base0A is also good.
I'll merge in separate branch and make joint commit. Thanks for PR!

It is in main now.

I'll merge in separate branch and make joint commit.

Thank you. I'll be back when we finish modified buffer indication.

Thanks! I didn't think linking to itself is even possible...

It seems like it falls back to Normal when you do that.


[Decommission Hub][2024-10-30] nasa-esdis

Summary
We been asked (https://2i2c.freshdesk.com/a/tickets/2362) to decommission the NASA-ESDIS hub
Info

Community Representative:
Link to New Hub issue:
Proposed end date:

Task List
Phase I

[x] Confirm with Community Representative that the hub is no longer in use and it's safe to decommission
[x] Confirm if there is any data to migrate from the hub before decommissioning

[ ] If yes, confirm where the data should be migrated to

[ ] Confirm a 2i2c Engineer has access to the destination in order to complete the data migration

[x] If no, confirm it is ok to delete all the data stored in the user home directories

Phase II - Hub Removal
(These steps are described in more detail in the docs at https://infrastructure.2i2c.org/hub-deployment-guide/hubs/delete-hub/)

[ ] Manage existing home directory data (migrate data from the hub or delete it)
[ ] Manage existing cloud bucket data (migrate data, or delete it)
[ ] Delete the hub's authentication application on GitHub or CILogon (note CILogon removal requires the hub config in place)
[ ] Remove the appropriate config/clusters/<cluster_name>/<hub_name>.values.yaml files. A complete list of relevant files can be found under the appropriate entry in the associated cluster.yaml file.
[ ] Remove the associated hub entry from the config/clusters/<cluster_name>/cluster.yaml file.
[ ] Remove the hub deployment

TIP: Run deployer use-cluster-credentials <cluster_name> before running the commands below
helm --namespace HUB_NAME delete HUB_NAME
kubectl delete namespace HUB_NAME

Phase III - Cluster Removal
This phase is only necessary for single hub clusters.

[ ] Remove the cluster's datasource from the central Grafana with:

deployer grafana central-ds remove <cluster_name>

[ ] Run terraform plan -destroy and terraform apply from the appropriate workspace, to destroy the cluster
[ ] Delete the terraform workspace: terraform workspace delete <NAME>
[ ] Delete the terraform values file under the projects folder associated with the relevant cloud provider (e.g. terraform/gcp/projects/ for GCP)
[ ] Remove the associated config/clusters/<cluster_name> directory and all its contents
Remove the cluster from CI:

[ ] deploy-hubs.yaml
[ ] deploy-grafana-dashboards.yaml

[ ] Remove A record from Namecheap account

Definition of Done
A non-specific, pre-defined list of tasks that should be considered before marking the task complete.

[] All the tasks above have been completed
[] Existing functionality was not broken

I've requested confirmation that the user data is safe to delete.  No user files appear modified within the last 6 months.
Confirmation that this data is safe to delete:  https://2i2c.freshdesk.com/a/tickets/2362

The confirmation arrived. I decommissioned nasa-esdis fully, and messaged the community representative about deleting out AWS user's within their account which I lacked permissions to do myself.


switch to oCIS 4.0.3

Description
switch to oCIS 4.0.3
Related Issue

Unblocks #399

Motivation and Context
Keep oCIS up to date
How Has This Been Tested?

none

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[x] Documentation generated (make docs) and committed
[ ] Documentation ticket raised:
[ ] Documentation PR created:

@d7oc somehow the renovate comment also doesn't work. But I didn't have time to investigate

@d7oc somehow the renovate comment also doesn't work. But I didn't have time to investigate

Comment? Which comment?


Remove type from enumeration documentation

It is not possible to remove the type column (would require deeper customization).
Replaced the declared type with "enum"


New Functions and Improvements

Type

[x] Improvement: Added more properties to $msg
[x] Functions: $removeLinks, $removeNumbers, $removeNewLines $rulesChannelID,  $suppressEmbeds, $unsuppressEmbeds

Breakdown

$removeLinks[text] - Removes links from the provided text.
$removeNumbers[text] - Removes numbers from the provided text.
$removeNewLines[text] - Removes all new lines from the provided text.
$rulesChannelID[(optional) guildID] - Returns the server's rules channel ID.
$suppressEmbeds[messageID;channelID] - Suppresses embedded content from a message.
$unsuppressEmbeds[messageID;channelID] - Unsuppresses embedded content from the embed-suppressed message.
New properties in $msg include: webhookid, issystem, type, istts, editedtimestamp, editedat, iscrosspostable

Description
Made some new functions and improvements.
I'm open to feedback and suggestions.

Before merging / accepting,
I would suggest the new functions to use the correct format of catching / returning errors.

Before merging / accepting,
I would suggest the new functions to use the correct format of catching / returning errors.

[x] Fixed the issues in $rulesChannelID

Lmk if any others use the old system.


Increase Queue Alerts For user_sync

Increases to 6 hours, to prevent notifications firing off when there are long running processes overnight.

:tada: This PR is included in version 6.4.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ML-Build: Manually install Bazel verison compatible with the current Tensorflow release 1.13.0

Initial fix for #32

Well, at least it's not complaining about Bazel anymore
@rsnk96 Can you have a look at the support options which it's asking for?

For future reference, the configration flags can be found in configure.py in the TF repo

Good work @rajat2004

Thanks a lot @rsnk96 for this and granting push access.
I'll keep this in mind about putting the commands for installing the latest version in comments


Decaffeinate spec/enable-spec

Since I work on many files, I edit package.json to add useful shortcut to avoid misspelt filename.
    "test-decaff": "npx coffee --compile --output spec spec/${npm_config_name}.coffee",
    "test-coffee": "jasmine-focused --captureExceptions --coffee spec/${npm_config_name}.coffee",
    "test-js": "jasmine-focused --captureExceptions spec/${npm_config_name}.js"

Steps to reproduce decaffeination (guidelines):

[x] Check package.json for coffee-script version

version: 1.12.7

[x] Decaffeination with official Coffee program

npx coffee --compile --output spec spec/enable-spec.coffee
(or my shortcut:  ./bin/npm run test-decaff --name=enable-spec)

[x] Quality of Decaffeination

[x] Replace var with const and let if it's possible.
[x] Replace Nested Ternary Operators with if statements.
[x] Remove return when it's not needed.
[x] Remove Result Arrays when they are not needed.
[x] Replace for loops with for-of loops.
[x] Use Arrow Functions to write functions in a single line when it's possible.
[x] Remove unneeded ref variables.
[x] Remove do blocks and use let or const instead.
[x] Tests and assertions should be the same and success like in coffee file

Test from coffee and JS should output same successful result :
From coffee
$ jasmine-focused --captureExceptions --coffee spec/enable-spec.coffee
// or my shortcut $ `./bin/npm run test-coffee --name=enable-spec`
> 4 tests, 11 assertions, 0 failures, 0 skipped

to js
$ jasmine-focused --captureExceptions spec/enable-spec.js
// or my shortcut $ `./bin/npm run test-js --name=enable-spec`
> 4 tests, 11 assertions, 0 failures, 0 skipped

Superseded, but again appreciate you!


Add write vertices num to FragmentWriter to adapt the latest GraphAr format

Signed-off-by: acezen<EMAIL_ADDRESS>Committed-by: acezen from Dev container
What do these changes do?

Upgrade GraphAr to commit e6a59f4 to enable the fix of arrow version align;
Some LOG revise

Related issue number

Fixes #issue number

Hi @acezen, try to rebase again main. The format and lint issue has been resolved by #1394.


Support Sagemaker Notebook Create, Describe, Delete, List, Start, Stop, Update.

I see that porthunt has broken ground on adding Sagemaker support.  Glad to collaborate with them (if they'll be picking their work back up soon).

This is now part of moto >= 1.3.15.dev971. Feel free to open new issues for other methods that are needed. Thanks!


Term request: Language literacy competence

Literacy is different from a mere linguistic competence.  See attached proposal.
linguistic literacy term request for ogms.xlsx

I agree that literacy is different from competence. Based on the definition
I am not sure I would understand what precisely we mean by literacy. Is
there a description (not genus differentia) that would help my
understanding the intended meaning?
Thanks!
On Wed, Jul 15, 2020 at 4:27 PM Bill Hogan<EMAIL_ADDRESS>wrote:

Literacy is different from a mere linguistic competence. See attached
proposal.
linguistic literacy term request for ogms.xlsx
https://github.com/ufbmi/OMRSE/files/4927760/linguistic.literacy.term.request.for.ogms.xlsx
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/issues/109, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACF6DLWR7HFHN6UEVCMTMOLR3YGJJANCNFSM4O25QHTQ
.

Perhaps I'm focusing on the label too much, but I take it that "literacy" is typically used to refer to an ability realized in reading and writing. However, neither of those activities is mentioned in the definition or comments. So, I am also a little confused about what this is intended to represent. Is it something like fluency (as opposed to mere competence) that this is meant to capture, or is that way off?

It's more than just reading and writing.  It's also understanding (which is
a bit more than mere reading, I think).  Also, it involves cultural and
other competencies.  i explain a lot of this in the attached term request
document in the comments.
In terms of parent class, it's a child of disposition, so I am not sure I
fully understand the issue there.
I didn't try to comprehensively list all of the disposition parts it has,
because (1) I don't need/want to define those too and (2) I wouldn't be
confident I listed them all.
Finally, as I note in one of the aforementioned comments, literacy also
connotes doing something with language.  Hence the "personal goal" aspect.
FYI: the term request spreadsheet is attached to the original issue
request, not this email.
On Thu, Jul 16, 2020 at 4:51 PM Clint Dowland<EMAIL_ADDRESS>wrote:

Perhaps I'm focusing on the label too much, but I take it that "literacy"
is typically used to refer to an ability realized in reading and writing.
However, neither of those activities is mentioned in the definition or
comments. So, I am also a little confused about what this is intended to
represent. Is it something like fluency (as opposed to mere competence)
that this is meant to capture, or is that way off?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ufbmi/OMRSE/issues/109#issuecomment-659665667, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJR55SRWL27TTUUQCUPMLTR35R6TANCNFSM4O25QHTQ
.


Revert "Merge pull request #5 from NDINDABAHIZI/develop"

Reverts NDINDABAHIZI/Web-based-event-materials-booking--system#6

reverted


Allow for Overriding Build Image

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

I'd like the ability to override the image that k3s is built with.
Describe alternatives you've considered

Additional context

Backporting

[ ] Needs backporting to older releases

Not needed after all.


json-ptr package v1.3.0 breaking OAS

TypeError: jsonptr.get is not a function at /src/oas_3_tools.ts:268:18
Perform clean install of latest version of openapi-to-graphql
Translate an openapi spec with references.
UnhandledPromiseRejectionWarning: TypeError: jsonptr.get is not a function
at resolveRef (/node_modules/openapi-to-graphql/src/oas_3_tools.ts:268:18)
at Object.getRequestSchemaAndNames (/node_modules/openapi-to-graphql/src/oas_3_tools.ts:625:23)
at processOperation (/node_modules/openapi-to-graphql/src/preprocessor.ts:88:17)
at /node_modules/openapi-to-graphql/src/preprocessor.ts:302:33
at Array.forEach ()
at /node_modules/openapi-to-graphql/src/preprocessor.ts:256:10
at Array.forEach ()
at Object.preprocessOas (/node_modules/openapi-to-graphql/src/preprocessor.ts:207:8)
at translateOpenAPIToGraphQL (/node_modules/openapi-to-graphql/src/index.ts:260:61)
at /node_modules/openapi-to-graphql/src/index.ts:172:11

@johnmbarry-nhvr Thanks for filling this issue. I believe we have a fix in the works #338. I'll try to get this accepted as soon as possible.

@johnmbarry-nhvr There does seem to be some issue around this library as seen here. This issue should be, for the time being, addressed by #338 and the release of v2.2.4. However, depending on how the library will change in the future, more work may need to be done.


asegfrgr

@redddyhemanth Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Don't use public repositories for your own testing, use your own fork for that!.


Gh 142 codecov v2 - testing

PR required to get CodeCov to trigger a build - please don't merge.

Current coverage is 53.98% (diff: 100%)

No coverage report found for develop at b673d0a.

Powered by Codecov. Last update b673d0a...b5571ab

The following changes have been applied in order to get codecov integration working:

A new profile has been created (-Ptravis), specifically for building Gaffer on Travis. This is required since the previous profile used in the Travis build process required setting the Maven Surefire plugin's forkCount property to 0, which breaks JaCoCo and prevents the test reports from being generated.
Since the forkCount property must be set to 1, the tests fail due to memory issues in the Travis containerised environment. To resolve this, fork reuse has been disabled and the amount of heap memory available to the Java process has been increased (-Xmx3072m).

If there are any issues with the Travis build process in future (entirely possible, as I'm not sure how marginal the build process is on memory at the moment), this approach may need to be revisited.


Relative_Primes

Submission Title
Relative_Primes
Submission Type
Maths_And_Stats
Submission Description
In number theory, two integers a and b are said to be relatively prime, mutually prime, or coprime if the only positive integer that divides both of them is 1. Consequently, any prime number that divides one of a or b does not divide the other. This is equivalent to their greatest common divisor being 1
Folder Related To
Maths_And_Stats => Series => Relative_Primes => Filename.extension
Contributors

[x]  C++ -
[x]  C -
[x]  Python -
[x] Java -
[x] JavaScript -
[ ] TypeScript -
[ ] Golang -
[ ] Ruby -
[x] php -
[ ] Swift -
[ ] C# -

I will like to do it in c++

Hey! I can do it in C language.

I would like to do it in java😊

Please assign me in python

I would like to do it in Golang

HEY @Vimlesh-Kumar .
i would like to do this in javascript. please assign it to me.

I will like to do this in PHP

hey @Vimlesh-Kumar please assign me in javascript

thanks everyone :v:


Suggestion: Use without a popup!

This would be fantastic if we could use it without the popup feature.  For example, the Bootstrap UI datepicker will simply display the calendar as-is.
Has anyone suggested this or is there a PR in progress?  Nice module

+1
would love to see the option of using this amazing calendar embeded in a view, without a use of mdDialog!

+1

You can use service instead of built-in directive. References to https://github.com/logbon72/angular-material-datetimepicker/issues/85

Or in our branch release 1.6.7

The first part and the bigger one is built with md-dialog... I'm not sure if it's worth the time and effort.


Only remove images that are created at least GRACE_PERIOD_SECONDS ago

When running docker-gc on a build server, it can happen that images will be reaped that are just built, before having had a chance to be pushed to a registry. This PR will apply the GRACE_PERIOD_SECONDS parameter to the Created date of images, so new images are not deleted.

Thanks!


EndTime is always updated for tasks

We've been using conductor for a few months and the other day, we were trying to debug an issue to see why a particular workflow was taking longer than normal.
We use the conductor-ui, and when we inspected the the Task Details, we realized that the endTime for the task were closely related to the end time of the entire workflow. At first I thought this was some kind of indexing error, but when we pulled the JSON of the final workflow run, the times are indeed off. The way our workflows are structure is that there are some serial tasks along with parallel tasks. Some of these serial tasks we know take a few minutes to complete, so it should stand to reason that the end time should be significantly less than the end time of the later tasks. This is not the case.
I haven't had time to trace the code, but it looks like the updateTask() method is being called on the tasks at every decision point in the workflow. I'm not sure if this is expected to happen or if conductor can be smart and only update those tasks need it. I think it may be making additional network calls to redis and also to ES that it doesn't need to.
Anyways, it looks like in the RedisExecutionDAO's updateTask(), there is a following check:
		if (task.getStatus() != null && task.getStatus().isTerminal()) {
			task.setEndTime(System.currentTimeMillis());
		}

If this method is indeed called multiple times on already completed tasks, then this is what is setting the endTime. If I have time soon, I plan on making a PR to fix this issue, but I wanted to make this issue known for others until it's fixed.
NOTE: It seems like this doesn't happen on SystemTasks (DECISION, JOIN, EVENT, etc) those endTimes seem correct.
Conductor version: 1.12.0

@bitbier Thanks for reporting the issue. It's been a while, but we'll take a look.

Closing this issue, since this should be fixed as part of recent changes.


Cast Dialog (Templated control)

Create templated control of Cast Dialog that implements Chromecast Design Checklist
https://developers.google.com/cast/docs/design_checklist#cast-menu

[ ] Cast dialog, not connected (receivers available)
[ ] Cast dialog, connected but not casting
[ ] Cast dialog, while casting

Decided to drop all templated controls


How do I scan files inside a folder?

$ gitleaks detect -s ~/ubuntu/leak-scan/results/folder

    ○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

6:04AM ERR [git] fatal: not a git repository (or any of the parent directories): .git
6:04AM ERR  error="stderr is not empty"
6:04AM WRN partial scan completed in 12.6ms
6:04AM WRN no leaks found in partial scan

I am not trying to scan github repositories, would be possible to scan files? shouldn't make any difference in the scan at all, it should check leaks in files/folders.

What about if using actions? I am trying to set it up in a composite action and I need to scan a custom directory.
name: Gitleaks
description: Gitleaks scan

inputs:
  fetch-depth:
    required: false
    description: 'Number of commits to fetch during checkout. 0 indicates all history for all branches and tags'
    default: '1'

runs:
  using: "composite"
  steps:
    - name: Checkout code
      uses: actions/checkout@v4
      with:
        path: code
        fetch-depth: ${{ inputs.fetch-depth }}

    - uses: gitleaks/gitleaks-action@v2
      env:
        GITHUB_TOKEN: ${{ inputs.github_token }}
        GITLEAKS_LICENSE: ${{ inputs.gitleaks_license }}


Best Practice to only allow certain people to register

My actions before raising this issue

[checked] Read/searched the docs
[checked] Searched past issues
When I am on the login page

Basically everyone can register. For privacy concerns, I am wondering if there is a way to only allow certain people to register? Because of my limited knowledge of front-end tech stack, please recommend simple, effective solutions.

Steps to Reproduce (for bugs)

Follow the installation guide.
Possible Solution

Several ideas that I have:

disable the login page completely. Only give credentials to certain people through backend (don't like it, feel like cheating)
somehow people who are not authorized cannot register (don't know how to do that)

Your Environment

Git hash commit (git log -1): 44382be02e98a29c28e9adf42fd7c56bd3bde298
Docker version docker version (e.g. Docker 17.0.05): 24.0.4
Are you using Docker Swarm or Kubernetes? No
Operating System and version (e.g. Linux, Windows, MacOS): Centos

You can remove/disable /api/auth/register endpoint on backend.
After that users can still be added throught admin panel


Tips for Vim users who also use jshint

make sure your Syntastic is up to date (:PluginUpdate). standard support was only added a few months ago

If you use other syntax checkers, add this to your .bashrc or .zshrc and launch vim with vims to enable standard.

alias vims="vim -c \"let g:syntastic_javascript_checkers = ['standard']\""

Or alternatively let vim auto detect your config in root, defaulting to standard if none is found:
autocmd FileType javascript let b:syntastic_checkers = findfile('.jshintrc', '.;') != '' ? ['jshint'] : ['standard']

source

Anyone have a snippet to instead use ./node_modules/bin/standard?

@yoshuawuyts nice. Do you have any idea on how I could have jshint as default and use standard only in projects which list it in package.json?

@olalonde no idea, I'm not much of a viml expert. You could shell out to node or jq, read the json and check for the values you're expecting.

@yoshuawuyts thanks, I'll see if I can come up with something.

autocmd FileType javascript let b:syntastic_checkers = findfile('node_modules/.bin/standard', '.;') != '' ? [ 'standard' ] : [ 'eslint' ]

seems to work as expected.

as a neovim user i prefer https://github.com/benekastah/neomake. has built-in standard support and runs tools asynchronously (ie, no pause when you save files).


Add files via upload

This game is a fun, simple music maker game. You just move the character to the different coloured blocks and play some music! The multi coloured blocks are pre-written songs made by me. You can use the I, J, K, L keys for extra notes.
This is my 4th game for the sprig.

I already lost the amount of games you have haha

In this case it's not a game, it's an experience! anyway, very good! You're using it for hacktoberfest, right?

What's the hacktoberfest?

" HACKTOBERFEST IS FOR EVERYONE.  https://hacktoberfest.com/

you have a good profile for hacktoberfest

do you have slack? join the hack club community! https://hackclub.com/slack/


swww: 0.9.1 -> 0.9.4

Description of changes

Bumps version
Use cargoLock.lockFile to workaround the following error.

...
       > ERROR: The Cargo.lock contains git dependencies
       >
       > This is currently not supported in the fixed-output derivation fetcher.
       > Use cargoLock.lockFile / importCargoLock instead.
       >
...

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Maintainer pings
cc @mateodd25 @donovanglover

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 304842 run on x86_64-linux 1

1 package built:

swww


If a theme is applied, use the theme's token in the Modal component

Which package has an issue?
@yamada-ui/react
Package Version
1.3.0
Description
Currently, styling values in components ignore theme tokens. If a theme is applied, you should use the theme's token.
Yamada UI's style system provides fallback functions. If the value of the token in the first argument does not exist, it returns the second argument, the fallback value.
- outside = "1rem",
+ outside = "fallback(4, 1rem)",

- zIndex: 110,
+ zIndex: "fallback(jeice, 110)",

Link to Reproduction
No response
Steps to Reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

Browser
None
Operating System

[ ] macOS
[ ] Windows
[ ] Linux

Do you know how to fix the issue?
Yes
Are you willing to participate in fixing this issue and create a pull request with the fix?
None
Additional Information
No response

@hirotomoyamada
Can I work on this issue?

@GensIto Thanks!


Remove timing difference between 90° and 270° rotations (in the tiling Rust code)

When I tested the tiling rotation code from #464 with Chrome 72 (MacOS) there was something funky going on. Clocking the rotations with console.time, 270° rotations appeared to be 2-3x slower than 90° rotations. Based on my earlier PR #463 that this shouldn't be the case, and the code itself seemed fine. I ran the included benchmarks with V8 version 7.4.196, and sure enough, the optimizing benchmark (more or less) agreed with manual testing. For the record, Firefox 65 didn't seem to have this quirk.
This pull request modifies the code in following ways:

Fix one small bug in unwrap_hard when debug_assertions is set.
Apply some optimizations to the base code, using slice iterators when possible.
Divide the different rotation branches into their own functions, marked #[inline(never)]. This was a result of trial, error and guesswork, and is a separate commit from the other modifications in case there's a better solution.

It seems that both modifications 2 and 3 are required to remove the difference between 90 and 270 degree rotations. The resulting code is a bit faster on all benchmarks (YMMV).
Baseline:

rotation
μ before
σ before
μ after
σ after
delta

0°
54.74
7.93
43.95
8.51
-19.71%

90°
269.98
4.63
222.43
3.61
-17.61%

180°
68.91
1.00
46.83
0.67
-32.04%

270°
264.82
4.55
222.04
3.00
-16.15%

Optimizing:

rotation
μ before
σ before
μ after
σ after
delta

0°
22.68
6.79
14.87
6.49
-34.44%

90°
103.15
2.26
86.73
2.92
-15.92%

180°
24.34
0.73
16.78
0.70
-31.06%

270°
230.27
3.39
78.58
3.65
-65.87%

I don't really know what's up when it comes to the code size. Gzipped size for the modified code is 806 bytes vs. the original 680 bytes. However, the original code takes 890 bytes (Gzipped) when built with my dockerified toolchain (built with yarn build:image). Maybe we have different versions of the Rust compilers?

Stellar work. I’m gonna merge this! I am as surprised as you are that these two loops were show such contrasting performance characteristics.
cc @ThomasTheDane and @dschuff


x/website/tour: transparent gopher image is too dark in dark theme

At https://go.dev/tour
The asset is a transparent PNG, it looks nice in light theme but not so much in dark.

I suggest we keep the image transparent but fill the gopher with plain white color.

After fix suggested in CL 523415:

Dark theme

Light theme

cc @jamalc


Implicit bounding box filtering by aggregate_polygon

In the geopyspark backend, we currently use the bounding box of the geometry/feature collection specified in 'aggregate_polygon' as an alternative to 'filter_bbox' or spatial_extent in load_collection.
This is very convenient for the user, as he does not have to extract the bounds himself, which can be annoying, especially when working with large files, or when trying to write process graphs that take any file as input.
Is this something that we should clarify in the process definition, or can we leave it implicit? (Compatibility across backends would be affected if other backends choose not to support this.).
This unit test in our backend tries to show the type of process graphs that we want to support:
https://github.com/Open-EO/openeo-python-driver/blob/5c32f52363de96977745e6c9d43214e8086b4e70/tests/test_views_execute.py#L499

I guess the best way to find out would be to just make a PR and propose this change on the call on Thursday.

This is very convenient for the user, as he does not have to extract the bounds himself, which can be annoying, especially when working with large files, or when trying to write process graphs that take any file as input.

For this the user can use filter_polygon instead of filter_bbox, no?
Anyway, I also would implicitly filter data when using aggregate_polygon (we have not yet implemented this process)

Telco conclusion: agreed to improve documentation.
Some notes:

Explain the mechanism and conditions when a spatial filter can be 'pushed down'
Explain that backends might still throw an exception if the push-down behavior is not supported
Point user to 'filter_polygon' which can make his process graph more robust across different backends

What is "push-down behavior"? Seems like an internal optimization?! I don't think this is something a user would really understand or care about. It sounds reasonable to just say that aggregate_* also implicitly applies filter_*.

See PR #101 for a proposal.

PR #109 ?

Indeed, 101 is this issue.

Merged.