Listing -> Choose Data Type : Not enough space to create Data

Describe the bug
When trying to Choose Data Type action from a selection containing multiple non-aligned addresses on types like undefined3 and int3, a message like "Create int3(s) failed: Not Enough space to create Data" is shown and the data is not created. This appears to be a regression as I have been able to create data from such selections before
To Reproduce
The following is some python code to be run from the interpreter:
import ghidra.program.model.address.AddressSet as AddressSet
k = AddressSet()
# Click somewhere off-aligned
k.add(currentAddress)
# Click somewhere else off-aligned
k.add(currentAddress)
createSelection(currentAddress)

Then right click the listing and select Choose Data Type , type int3 or undefined3

I am able to reproduce and it certainly appears to have the wrong behavior.

I think I can safely tone-down the forced alignment for spot placement of datatypes (single address locations).  While range-based selections would continue to enforce alignment.  This is done to ensure that if a run of data created is converted to an array that the datatype components would be properly aligned based upon the compiler specification (i.e., data organization).
Could you indicate your program architecture being used and your rationale for using int3 and how this likely relates to how the program's source code defined the data.

I think I can safely tone-down the forced alignment for spot placement of datatypes (single address locations). While range-based selections would continue to enforce alignment. This is done to ensure that if a run of data created is converted to an array that the datatype components would be properly aligned based upon the compiler specification (i.e., data organization).
Could you indicate your program architecture being used and your rationale for using int3 and how this likely relates to how the program's source code defined the data.

The binary is MIPS big-endian 32-bit (unknown compiler). The int3 is used as a part of a structure as follows:
char * stringBase;
void * imageBase;
int n;
SymStruct syms[n];

SymStruct {
  byte flags;
  int3 stringOffset;
  int symOffset;
}

where each of the SymStruct defines a symbol at imageBase + symOffset with name read from stringOffset + stringBase.

There may still be restrictions within a structure where aligned-length will still be enforced.  I need to tone this down as well for non-packed structures but has not yet been done for forthcoming merge (GP-3675).  There are also some unresolved issues related to big-endian treatment for this situation.
I would assume this is not a valid C structure for the source code.  What would you expect the structure to look like in source code?  Are you doing this to compensate for lack of bitfield support in decompiler?

I just noticed some weird behaviour:
Create a SymStruct { byte, int3, int } in the listing and create Structure

The int3 is size 4 and the dword has vanished

I would assume this is not a valid C structure for the source code. What would you expect the structure to look like in source code? Are you doing this to compensate for lack of bitfield support in decompiler?

To be honest, I have no idea what the source code would look like, although I vaguely remember that certain structs like basic_string (https://shaharmike.com/cpp/std-string/) can be pretty weird in the decompiler

Yes, the current structure behavior is to force alignment.  My intention is to remove this behavior for non-packed structures (GP-3726).


Add reverse

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         984    993    +9
=====================================
+ Hits          984    993    +9

Impacted Files
Coverage Δ

dist/partial.lenses.cjs.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d4149...36cc5a9. Read the comment docs.


Option to override language file

Adds an option to create custom language file in directory mentioned in https://laravel.com/docs/5.2/localization#overriding-vendor-language-files, to override existing or creating new language file in Laravel 5.1 and 5.2.
Solves issue #188

I would strongly recommend documenting direct usage of the $resource parameter, so non-Laravel projects know how they can take advantage of this enhancement as well.

@danhunsaker does the last commit solve what you meant or did you mean more explict documentation?

Not quite.  It's good for Laravel users to know, but still doesn't address non-Laravel users.  These users will be better served by knowing they can pass the $resourcePath to Date:setLocale() manually, which will let them put those files wherever makes sense for their own projects, instead of being forced into Laravel's paradigm.


SELF_HOSTED_SETUP: Why doesn't it use k8s TokenReview API?

https://github.com/aws/amazon-eks-pod-identity-webhook/blob/master/SELF_HOSTED_SETUP.md looks dated.
There's no talk about TokenReview or k8s 1.18 ServiceAccountIssuerDiscovery feature.
Is that a miss or the support is expected sometime in the future?
Environment
A number of self-hosted k8s in aws.
AWS Region: us-west-2
Kubernetes version: 1.17.11 onwards

Hi thanks for the issue. The ServiceAccountIssuerDiscovery feature was released after this webhook was written and hasn't been updated to account for that feature. We'd welcome a PR!


Browser/Renderer bridge for passing replay events.

There's some slight cruft in this patch, but it establishes a replay-specific communication between the browser and render processes.
I also think that the place in this patch where the "KvKvTestEvent" message is sent (RenderProcessHostImpl::Init), or its caller, is likely where we want to inject the browser-side logic.
I still need to wire the receiver end of this code in the render process to pipe the events into our record_replay_interface.cc code.

I'm trying to update this to link the renderer rr-message handling code to pipe things to the V8 code where we run our instrumentation, but running into various scoping and namespacing and linking issues.  I think that while blink and v8 live in the same process, their code is linked separately.
The approach I'm going with is to use a global callback function pointer in the content code, which is set by the V8 code.  The resolution should be to make the callback-installer function part of the public API of the blink codebase, and then use it from the v8 code.

Been trying to get this to work for the last couple hours, and the build still doesn't work right.. however, the build failure occurs when we're building v8_context_snapshot_generator.
Realized the problem is maybe because v8 can be built standalone, in which case we wouldn't pull in the blink code.  So really the dependency needs to go the other way: blink calls an API function within V8 to deliver the messages directly.

Ok this push works fine.  The comments mention typing the, but it's probably better to find a way to convert base::Value to a JSON v8::Value to pass into our javascript instrumentation.  We can't use base::Value because it's defined at a higher level (for content), and there are no existing uses of it in the v8 binding code at all.

Added the final bits to convert the data payload to v8::Value frombase::Value and send it into the JS code for handling.  However, the browser is crashing somewhere later (somewhere in cpp/recording/ProgressCounter.cpp, where it asserts that a checkpoint has been created - apparently a progress counter is getting incremented despite the first checkpoint not having been created yet.

This should be good for review now.  The message pipeline from content down into the render process and our is instrumentation is implemented here.  Right now it terminates with a log message, but after we get the actual correct events flowing through we can fix that up to save the events and send them back to the controller.


Suggestion

Add two new taunts to the taunt menu.
1: Add the sleeping animation to the taunts.
2: Add the shrug animation to the taunts.

I would actually love the sleeping animation

what about the shrug animation? I think that one would be pretty funny.

well do what you need to do with the taunt wheel but i really want at LEAST the shrug animation in sm64js.

well do what you need to do with the taunt wheel but i really want at LEAST the shrug animation in sm64js.

Alright ig

Also for future reference, please name your suggestions in the issue title.
"Suggestion" is not helpful and wastes my time while I have to wait for GitHub to load the issue.

Ok i can do that :)


Admin setting was not found logged multiple times

Brief description of your issue
It seems that the admin setting for default proxy is being accessed or logging multiple times
Steps to reproduce
Run any command on a fresh install
Expected behavior
Settings would only be accessed / logged once
Actual behavior
See logs below
Environment
2024-06-28 12:52:56.126 [CORE] WinGet, version [1.9.1763-preview], activity [{56EDC85A-BE3B-4CD3-980B-5FA40D345B95}]
2024-06-28 12:52:56.126 [CORE] OS: Windows.Desktop v10.0.26241.5000
2024-06-28 12:52:56.126 [CORE] Command line Args: "C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WindowsApps\winget.exe" install Rustlang.Rust.MSVC --disable-interactivity --verbose --logs
2024-06-28 12:52:56.126 [CORE] Package: Microsoft.DesktopAppInstaller v1.24.1763.0
2024-06-28 12:52:56.126 [CORE] IsCOMCall:0; Caller: winget-cli
2024-06-28 12:52:56.138 [CLI ] WinGet invoked with arguments: 'install' 'Rustlang.Rust.MSVC' '--disable-interactivity' '--verbose' '--logs'
2024-06-28 12:52:56.138 [CLI ] Found subcommand: install
2024-06-28 12:52:56.138 [CLI ] Leaf command to execute: root:install
2024-06-28 12:52:56.140 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.140 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [YAML] Detected UTF-8
2024-06-28 12:52:56.140 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.141 [CORE] Setting action: Get, Type: Secure, Name: admin_settings
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [YAML] Detected UTF-8
2024-06-28 12:52:56.141 [CORE] Admin setting 'DefaultProxy' was not found or did not contain the expected format
2024-06-28 12:52:56.142 [CLI ] Executing command: install

I've been getting this as well. Couldn't find how to fix it.


SportsBrawl Sheet

Is there a publicly available ruleset available for this system? I can't seem to find "Sports Brawl".

There will be as soon as they are released on the Marketplace.  I have product manuals created in the individual campaigns, but nothing has been made public yet.  Dean has examples of the product manual in the Lost West Media demo campaign.


Location Object can't have 0 for Longitude/Latitude

When attempting to create Location objects with '0' as a value for either the latitude or longitude, the library raises a DependentPropertiesError when it should not. See relevant portion of the StackTrace below:
country = stix2.Location( File "/usr/local/lib/python3.9/site-packages/stix2/base.py", line 232, in __init__ self._check_object_constraints() File "/usr/local/lib/python3.9/site-packages/stix2/v21/sdo.py", line 398, in _check_object_constraints self._check_properties_dependency(['longitude'], ['latitude']) File "/usr/local/lib/python3.9/site-packages/stix2/base.py", line 109, in _check_properties_dependency raise DependentPropertiesError(self.__class__, failed_dependency_pairs) stix2.exceptions.DependentPropertiesError: The property dependencies for Location: (longitude, latitude) are not met.
I've traced the issue to the stix2\base.py _check_properties_dependency method where the function uses the "not" operator to check if a property is a valid value. In this scenario, '0' is a valid Longitude and Latitude and an additional layer of checking needs to occur for Number values. Note: Issue arises at if not self.get(p)
    def _check_properties_dependency(self, list_of_properties, list_of_dependent_properties):
        failed_dependency_pairs = []
        for p in list_of_properties:
            for dp in list_of_dependent_properties:
                if not self.get(p) and self.get(dp):
                    failed_dependency_pairs.append((p, dp))
        if failed_dependency_pairs:
            raise DependentPropertiesError(self.__class__, failed_dependency_pairs)

Thanks for the bug report and for tracking down the exact location in the code where this occurs! TIL: 0°N 0°E is known as "Null Island".

_check_properties_dependency mentioned above can be found at
https://github.com/oasis-open/cti-python-stix2/blob/master/stix2/base.py#L102
I think the problem is that the get method doesn't take into consideration that a value of 0 will be interpreted as None.  If the property has a value of 0, then it exists, and shouldn't cause this error.


Merge for v5.0.1

A minor bugfix release.
🔨 Fixes

fix close button callback for companion-widget popups
fix layer assignment for WebMap legends

🌳 New

add additional WebMap services to the 🧰 Companion Widget.

Codecov Report

Merging #119 (c3053e0) into master (3975db9) will decrease coverage by 0.03%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   71.69%   71.65%   -0.04%
==========================================
  Files          14       14
  Lines        6621     6630       +9
==========================================
+ Hits         4747     4751       +4
- Misses       1874     1879       +5

Impacted Files
Coverage Δ

eomaps/utilities.py
58.75% <33.33%> (-0.50%)
:arrow_down:

eomaps/_containers.py
65.94% <40.00%> (-0.21%)
:arrow_down:

eomaps/_webmap.py
79.77% <100.00%> (ø)

eomaps/eomaps.py
65.14% <100.00%> (+0.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Simple TimePointContext constructor fails

Trying to use the constructor for the TimePointContext object seems to result in an exception regardless of the input parameters.
from highdicom.sr.templates import TimePointContext

TimePointContext('whatever')

Results in:
Traceback (most recent call last):
  File "test.py", line 3, in <module>
    TimePointContext('whatever')
  File "/Users/christopher.bridge/Developer/highdicom/src/highdicom/sr/templates.py", line 214, in __init__
    self.append(time_point_item)
  File "/Users/christopher.bridge/Developer/highdicom/src/highdicom/sr/value_types.py", line 139, in append
    super(ContentSequence, self).append(item)
  File "/Users/christopher.bridge/.pyenv/versions/highdicom/lib/python3.8/site-packages/pydicom/sequence.py", line 62, in append
    super().append(val)
  File "/Users/christopher.bridge/.pyenv/versions/highdicom/lib/python3.8/site-packages/pydicom/multival.py", line 66, in append
    self._list.append(self.type_constructor(val))
AttributeError: 'TimePointContext' object has no attribute '_list'

I will keep thinking about it but for now this has me stumped. Any ideas appreciated.
I'm using pydicom version 2.1.2, python 3.8.7, highdicom master branch

@CPBridge there was just a call to super missing in the constructor. Created a draft pull request. Will add a couple of unit tests and then publish the PR.

Ahhh of course

@CPBridge I added tests (and fixed additional bugs). The PR is now ready for review.


Errors and no qa results

I've encountered following error from celerytask while performing QA. Do you have any idea what could cause it?
[2015-02-03 16:11:33,059: ERROR/MainProcess] Task qa.update[507f23c7-9eca-4f03-bd83-10616cad1ee7] raised exception: KeyError('package',)
Traceback (most recent call last):
  File "/usr/lib/ckan/default/local/lib/python2.7/site-packages/celery/execute/trace.py", line 47, in trace
    return cls(states.SUCCESS, retval=fun(*args, **kwargs))
  File "/usr/lib/ckan/default/local/lib/python2.7/site-packages/celery/app/task/__init__.py", line 247, in __call__
    return self.run(*args, **kwargs)
  File "/usr/lib/ckan/default/local/lib/python2.7/site-packages/celery/app/__init__.py", line 175, in run
    return fun(*args, **kwargs)
  File "/home/krzysiek/WebServer/ckan/lib/default/src/ckanext-qa/ckanext/qa/tasks.py", line 122, in update
    data['package'], data['position'],
KeyError: 'package'

I've corrected that in some commit as far as I remember.  See history for details.


[changed] Update to React 0.12. Fix warnings.

This PR makes react-modal require react 0.12 or latest. Also fixes the warnings and deprecation notices caused by the new API.
The migration plan is the same published by the React team when migrating from older versions to React 0.12.

Is there anything missing for having a new release containing this PR?

Is there anything missing for having a new release containing this PR?

Sorry I forgot to release. Now available under version 0.0.7.

thanks a lot!


[WIP] Remove old UI

Motivation and context

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 6682

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 69.099%

Totals

Change from base Build 6672:
0.05%

Covered Lines:
11147

Relevant Lines:
15621

💛  - Coveralls

Karma and qunit probably aren't needed anymore in Dockerfile.ci

@azhavoro , could you please look and test?


Show error dialog when filename does not have an extension.

This is a quick and dirty fix for #861. I haven't found how to automatically add the extension to the filename when it doesn't have one, because I can't find how to get the extension from the type selector in the showSaveDialog box.
Either way, this should really be fixed upstream instead, but this is just a minimal fix so the user can at least know that the file didn't save.

Also this should be tested on other platforms obviously.


Sumcheck: contractHandler.js

Description
Concise description of proposed changes
Closes https://github.com/evmts/tevm-monorepo/issues/1465
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address:
0x00655ABFA67C746F1b4F6DDD86Cf762b0D36DE07

Summary by CodeRabbit

Bug Fixes

Improved error handling for contract-related requests, enhancing clarity in error messages.
Ensured consistent representation of addresses in log messages and error reporting.

Chores

Refined logging practices for better clarity regarding contract bytecode and precompile absence.

Wrong commit was pushed
Have updated the code


Does prepatch get invoked on all vnode children?

Say I have these two structures
oldNode:

Hello world!

newNode:

Goodbye!

Plus the below to tie it to the DOM
oldNode = patch(theDom, oldNode)
If I do patch(oldNode, newNode), will this trigger a prepatch-hook for both the div and the span?
So far I'm only getting prepatch on the parent, but I suspect I may be doing something wrong.
I need to figure this out so I can do a good thunk-implementation (tried the one that exists, but it doesn't fit my scenario 100%)
Thanks in advance.

Ok, I answered my own question. Yes, prepatch is called.
const test = (

                Hello World

        );
        test.data = {
            hook: {
                prepatch: (old, newNode) => {
                    debugger;
                }
            }
        };
        test.children[0].data = {
            hook: {
                prepatch: (old, newNode) => {
                    debugger;
                }
            }
        };
        const r = patch(this.domElement, test);
        const test2 = (

                Goodbye

        );
        test2.data = {
            hook: {
                prepatch: (old, newNode) => {
                    debugger;
                }
            }
        };
        test2.children[0].data = {
            hook: {
                prepatch: (old, newNode) => {
                    debugger;
                }
            }
        };
        patch(r, test2);


Accept/visit pattern for getting user input

The goal is to eliminate branching.
do {
    var command = userInterface.GetUserCommand();
    if (command is AdviseCommand) {
        var advice = (AdviseCommand)command;
        move = Algorithm.GetMove(this, advice.Heuristic);
        userInterface.ReportAdvice(move, advice.Heuristic);
        move = null;
    } else if (command is ExitCommand) {
        throw new Exception(" The game has suddenly ended.");
    } else if (command is MoveCommand) {
        var unpack = (MoveCommand)command;
        move = new CongoMove(unpack.Fr, unpack.To);
        if (!isValid(move)) move = null;
    } else if (command is ShowCommand) {
        userInterface.Show(board);
    } else {
        /* do nothing */
    }
} while (move == null);


Driver for Sensirion SHT3x temperature and humidity sensor readded

I have written a driver and some examples for Sensirion SHT3x temperature and humidity sensors connected via I2C.
This is a redesigned version of the driver. The driver was already added temporarily some weeks ago. By pull request #444 I asked for merge into the master branch. However, due to some difficulties with separate development branches and a redesign of the drivers interface, I deleted the files and closed pull request #444 before the merge happened.
Now, the interface redesign has been finished and I am asking again for a merge into the master.

Could you please rebase this and squash it into a single commit because a lot has change, lot been deleted etc. So git rebase -i master, and then (except for the first commit) change the first letter to s, and the git push -f ... sht3x-driver. Back it up first, just in case, if new to this.

@ourairquality
The version I commited on Oct 3rd were that one which had the wrong abstraction level from your point of view. Based on your suggestions, I changed it completly and checked in these changes on Oct 5th. I had to delete unsuitable examples. This version is therefore obsolete.
The version from Oct 5th has been reviewed by you, many thanks again. The changes I checked in yesterday do not consider your suggestion you made in this review. I would like to discuss some of them a bit before I start to change again a lot. Some of them I do not agree completely.
My problem with git is, that I don't have git and a checked out version locally. I just use the web front end for uploads. I'm not sure how to make an existing local directory to an checked out version of a repository without getting conflicts and preserves my local changes.

@ourairquality
I have changed the driver interface according to most of your suggestions. Furthermore, I rebased the master as  asked for. I hope that everything is ok now for merging the driver into the master.

Thank you for the changes. It looks usable in my own app now, so that makes me happy. I have some sht3x on hand and hope to find time to test this soon. There are some white space issues, lines end in white space, a small nit that could be cleaned up later.

@ourairquality
Finally, I have squashed my last changes based on some of your suggestions and all small changes before into a single commit. Now, I would freeze the code for merging. I hope, you can live with it, it seems to be a compromise of your suggestions and my original code.

I changed all things according to your suggestions even though I am not really lucky with all of them. I hope it's ok now for merge.

This is not my project and I do not decide what lands or not. I took a particular interest in this driver because I will be supporting the device. I had been trying to communicate that, that you should design it as you wish. Sorry I don't want to be seen as blocking such work and do not want to comment further on this.

@ourairquality
I am really sorry that your are feeling to be the blocking, this wasn't my intention. I would like to thank you again for all the review work and your suggestions. I'm really very grateful. I appreciated it to discussed the different approaches with you. For me it is always very important to get a view from another perspective than my own. And I think the driver is now in a good state were it can be used by different users.
I hope that the driver as it is also somewhat usefull for you even though you would have designed it slightly different.
As you know, I like abstraction and to keep the user away from details. Therefore, I added one single function sht3x_measure that does the complete measurement in single shot mode with high repeatability. I believe that is the most easiest way to use the driver for users that don't want to know to many details how the sensor works.

While I have no sensor to test with I'd like to thank both of you @gschorcht and @ourairquality for your hard work on this PR. I am impressed with the level of documentation on this "extras"


Create codeql-analysis.yml

Coverage remained the same at 98.077% when pulling 51ad55344824dc6fa6be92d3d121c295a14ed78f on sthagen-patch-2 into 0a5389b1e37a33976fcba6d1f2d59bb33a9b9e10 on default.


imgui.core.ImGuiError: ImGui assertion error (draw_list->_VtxCurrentIdx < (1 << 16) && "Too many vertices in ImDrawList using 16-bit indices

I'm having the issue that the window draw list grows too large for the index type used (unsigned short).
See https://github.com/ocornut/imgui/issues/1188 and https://github.com/ocornut/imgui/blob/e0cab5664adf02c030f9cf2a05d2c334638a85f8/imgui.cpp#L3374-L3383
This leads to the following error:
imgui.core.ImGuiError: ImGui assertion error (draw_list->_VtxCurrentIdx < (1 << 16) && "Too many vertices in ImDrawList using 16-bit indices. Read comment above") at imgui-cpp/imgui.cpp:3383

It's hard for me to work around this using BeginChild/EndChild because I want to draw all these things in the same window...
Therefore I would like to ask if you would be willing to change the ImDrawIdx type to unsigned int as suggested in the comment (second link). If so I'd be willing to prepare a pull request.

Yeah, why not. If we just make sure that existing integrations work that's not a problem for me.

any updates on this ? i'm having the same issue and don't really know how to work around it ;(
any help would be gladly appreciated..

Feature released in 1.2.0


Enable switch between light and dark mode

Consider to reenable the switch for light and dark mode of the website. For many it may be easier to read text orientated pages (like Kit documentation or the TRGs) in light mode, than in dark mode. Dark mode could be set as default, but I would like to have the possibility to switch to light mode on demand.

This would require all Kits to adjust their figures. This is for sure feasible but should be coordinated with the respective stakeholders.

We are working on this - but as @arnoweiss already mentioned we need to make sure that figures and images are also working with the light mode.

I would really love to have this switch. It would increase readability so much. And I'm sorry for the KITs ;)

I'm pretty sure that a first step would be to require diagrams to either be readable in both modes AND setup config for the mermaid-based diagrams. Github for instance does this automatically for their mermaid-integration.
sequenceDiagram
    Stakeholder->>+Community: can I haz dark mode?
    Community->>+Stakeholder: maybe?


[SPARK-23500][SQL][FOLLOWUP] Fix complex type simplification rules to apply to entire plan

What changes were proposed in this pull request?
This PR is to improve the test coverage of the original PR https://github.com/apache/spark/pull/20687
How was this patch tested?
N/A

Merged build finished. Test PASSed.

Test build #88621 has started for PR 20911 at commit e4c1559.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1778/
Test PASSed.

Test build #88621 has finished for PR 20911 at commit e4c1559.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ComplexTypesSuite extends QueryTest with SharedSQLContext

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88621/
Test PASSed.

Test build #88654 has started for PR 20911 at commit ec47077.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1796/
Test PASSed.

Test build #88654 has finished for PR 20911 at commit ec47077.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88654/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1800/
Test PASSed.

Test build #88658 has started for PR 20911 at commit ec47077.

Test build #88658 has finished for PR 20911 at commit ec47077.

This patch fails from timeout after a configured wait of `300m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88658/
Test FAILed.

@henryr

Test build #88720 has finished for PR 20911 at commit 888645e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88720/
Test PASSed.

LGTM

Test build #88740 has started for PR 20911 at commit 5b990e5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1854/
Test PASSed.

Test build #88740 has finished for PR 20911 at commit 5b990e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88740/
Test PASSed.


Specify self.cert is used for SSL client certificates

In addition to #3539 clarify that self.cert is used for SSL client certificates

Looks good to me, thanks!


Twilio

Feature
Implement twilio/push notifications into the meeting process
Designs, Code, other relevant information / files for feature

Please include implementation details.

@zipper

(@)zipper is not zipper lmao

Working on it. Should be under the api route /sendtexts with params location which takes the address of the place, name which gives the name of the place, and friends which takes a json list of the friends you want to meet with.


CB: N1QL gen improvements, additional it enablement

Looks good – will merge when green.

Current coverage is 64.95% (diff: 97.14%)

No coverage report found for master at ce5b0ea.

Powered by Codecov. Last update ce5b0ea...8d2ac3f


Distributed System Sharing - Consensus and Blockchain - JP

https://jiapeish.github.io/work/2022/08/21/dist-share-blockchain/
Consensus algorithms play a key role in building reliable large scale software systems.They allow a collection of machines to work as a coherent group that can survive the failures of some of its memb

初始化评论系统。


Added missing dollar sign to 'key' variable in Client::buildCurlCommand()

Broke here: https://github.com/getsentry/sentry-php/commit/09de00d2fb3b7f664eb140b23b5ddcbf941b085b

Hrm not sure how this slipped through as it seems like it'd be causing some serious issues.
Thanks!


ISPN-9464 Notify listeners without holding the shared topology lock

https://issues.jboss.org/browse/ISPN-9464

Integrated into master, thanks @danberindei !


Why the custom-metric-api yaml file lost after release-0.11?

I am trying to test HPA with custom metrics , and I use the latest prometheus adapter to isntall
After installation , I can not see custom metric apiserver ,only v1beta1.metrics.k8s.io
could anyone can tell should I use release-0.10 to reinstall adapter ?

I use kube-prometheus-release-0.13 to deploy

when I deploy a HPA following the walkthrough
https://github.com/kubernetes-sigs/prometheus-adapter/blob/master/docs/walkthrough.md
I got this error in controller :
"Event occurred" object="seeburger/bis-dt-hpa" fieldPath="" kind="HorizontalPodAutoscaler" apiVersion="autoscaling/v2" type="Warning" reason="FailedGetPodsMetric" message="unable to get metric http_requests: unable to fetch metrics from custom metrics API: no custom metrics API (custom.metrics.k8s.io) registered"

Can find the resolution in this link https://github.com/prometheus-operator/kube-prometheus/discussions/996


Clarification on Inference Speed and k-NN Search Process

Hi, First of all, thank you for the great work on this project!
I have a question regarding the inference speed. Specifically, I want to clarify whether the reported inference time includes the time taken for the k-NN search.
From my understanding, during the inference stage, the process involves:

Extracting the features from the test image
Collecting the features of k nearest neighbors according to the retrieval indexs as the template
Comparing the test features with the template features to make the final prediction.

However, the retrieval indexes computation could be time-consuming and not included in the inference time?

Seems the retrieval process is not that time-comsuming

Thank you for your reply, meaningful work for real application!

I converted my PyTorch model to ONNX and am testing the model in python ONNXRuntime. However, during postprocessing (especially during operations like unfold and reshape), I am experiencing significantly long execution times — approximately 1 seconds. Can you share your demo script that is used to test time?

To troubleshoot the performance issue, you should first confirm the performance of the PyTorch model.  On a 4090 GPU, you should expect around 113 FPS.  Even if you include other overhead, the performance should still be at least 50 FPS, which means a single "unfold" operation should not take 800 ms.
For optimizing the inference time using TensorRT, you can refer to Torch-TensorRT

Thank you very much. This is not wrong related to the paper. The PyTorch version shows good speed and conforms exactly to the paper. However, in ONNX deployment, there’s a problem during inference with the converted ONNX model. I suspect that the ONNX model might be using a for-loop to handle the unfold operation, which could be causing the issue.


Draft for Moving Subscription Cleanup Job

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

@ralikio this is a draft right? name suggest so however it's not set as a draft PR.

@ralikio should this PR be closed?

@ralikio I'm closing this PR as clutters our team reviews request view since 3 weeks. Feel free to reopen it if needed.


Fix ending recurrence bug

Fix recurrence bug in refresh_next_occurrence when recurrence is ending. Set next occurrence to null

No, this method only gets calls when an existing recurrence definition changes and it needs to alter the next date based on the new definition. If the new definition caused the recurrence to end, it was erroring here since it was trying to compare to a datetime. Pretty rare event, only happened once in several months, but definitely a very likely and possible scenario.


config.md: fix some typo

Signed-off-by: Ling FaKe<EMAIL_ADDRESS>

LGTM for consistency.

LGTM

3d7e176f looks good to me, although I'm also fine with the plural
“implementations” phrasing.


Index filtering docstring improvements

Add list of most common keyword arguments to functions for filtering indices (commoninds, uniqueinds, etc.). Currently it's not so obvious to users what keyword arguments could be passed, as shown by a recent forum post.

@mtfishman please let me know if these docstrings look accurate to you

Looks good to me, thanks. One suggestion I would have is defining a function:
function index_filter_kwargs_docstring()
return """
  Optional keyword arguments:
  * tags::String - a tag name or comma separated list of tag names that the returned indices must all have
  * plev::Int - common prime level that the returned indices must all have
  * inds - Index or collection of indices. Returned indices must come from this set of indices.
  """
end

and interpolate that into the other docstrings with $(index_filter_kwargs_docstring()) so if we want to change or update it we just need to update it in one place.

Great, yes I was thinking that very same thing but couldn't remember quite how to do it. I'll make that change.

@mtfishman ok just made that change

Codecov Report

Merging #1171 (8ee3eba) into main (73bc07e) will decrease coverage by 5.82%.
Report is 13 commits behind head on main.
The diff coverage is 78.57%.

:exclamation: Current head 8ee3eba differs from pull request most recent head a13b205. Consider uploading reports for the commit a13b205 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   59.52%   53.70%   -5.82%
==========================================
  Files          87       86       -1
  Lines        8361     7831     -530
==========================================
- Hits         4977     4206     -771
- Misses       3384     3625     +241

Files Changed
Coverage Δ

src/ITensors.jl
100.00% <ø> (ø)

src/itensor.jl
80.22% <0.00%> (+31.06%)
:arrow_up:

src/mps/abstractprojmpo.jl
0.00% <ø> (-86.33%)
:arrow_down:

src/physics/autompo/opsum_to_mpo_qn.jl
0.00% <0.00%> (-97.64%)
:arrow_down:

src/oneitensor.jl
100.00% <100.00%> (ø)

... and 74 files with indirect coverage changes

Thanks!


Build with Nuxt 3

On the roadmap for stable release in June 2022 https://v3.nuxtjs.org/community/roadmap


Consider a better license or double licensing.

Hello again,
this software was previously under the GPL which was a more preferred license for me, then it got changed to whatever this thing is. GPL is probably too strict for this library, but I believe using Apache 2.0 would be better than the current license. The current license defines terms poorly and provides no patent protection.
So consider putting this software under Apache 2.0, which is a mature permissive license:
https://www.apache.org/licenses/LICENSE-2.0.html
Perhaps double-licensing it under LGPL v3+ would also be good for those who enjoy stronger copyleft:
https://www.gnu.org/licenses/lgpl-3.0.html
This would make it easier to integrate with my GPLv3 game.
Edit: seems like Apache 2.0 is incompatible with GPLv2 so maybe it's good to keep the license as is or unify unify it with what vector2 has (see below)

Alternatively use the same license the Vector2 part of the code uses.
That license allows sublicensing and also doesn't have clauses preventing modification of the copyright notice so I can add my copyright to it when I modify it.

Hey, sorry for the delay. Also, apologies in advance for my lack of knowledge around licensing - I'd normally much rather write code than worry about these sorts of things, so there's a lot that I'm ignorant of.

The current license defines terms poorly and provides no patent protection.

I much prefer the simple, easy to understand licenses, personally. Which terms are unclear to you? Additionally, I don't really think patent protection is necessary, since it's just basic math, which isn't patent-able from my understanding (IANAL),

This would make it easier to integrate with my GPLv3 game.

zlib is GPL-compatible.. Additionally, it's also GPLv3 compatible, if I'm reading this correctly. So I don't understand what about zlib it makes it difficult to integrate.

That license allows sublicensing and also doesn't have clauses preventing modification of the copyright notice so I can add my copyright to it when I modify it.

zlib allows for modification, so long as it is plainly marked as such. As far as changing the copyright, why would that be needed / desirable?

I made this issue late at night, sorry. My phrasing is probably too vague. After thinking about it all problems are purely cosmetic (keeping multiple copyright notices as separate comments in each file).

Which terms are unclear to you?

"3. This notice may not be removed or altered from any source distribution."
"This notice" is not defined anywhere, it most likely means that comment. In that case if I modify that file, then I need add a separate notice with my own copyright that's distinct from that notice.

So I don't understand what about zlib it makes it difficult to integrate.

If I understand the license correctly, even if I make changes under GPLv3 in the file, the original license still applies. Though I'm not sure at this point.

zlib allows for modification, so long as it is plainly marked as such. As far as changing the copyright, why would that be needed / desirable?

Keeping information for all authors of the code at the top of the document in single place would be desirable, though after rethinking I believe I can simply put another comment with a different license into another file.
So after rethinking it pretty much boils down to a minor annoyance of keeping copyright info multiple times in the same file. I guess I can live with that, sorry for nothingburger issue.

Hey no worries - I appreciate the interest! I am certainly no lawyer, nor am I tied to the zlib license, so I am open to changing it if it makes sense. Though I'd be more likely to change it to MIT, probably, if I do end up changing it. I'm going to close this for now, though feel free to re-open if it does end up being the case that zlib won't work for your needs :slightly_smiling_face:.


Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (C:\Users\Fabiano\AppData\Local\atom\app-0.179.0\resources\app\src\atom.js:54:11)
AtomJsHint.updateStatus (C:\Users\Fabiano\.atom\packages\atom-jshint\lib\atom-jshint.js:203:11)

@Joezo Please close this as a duplicate of #70. Blame Atom's own programming for this mess.


Preparation for data-tiled multi_mma codegen

The individual commits in this PR could be split into their own PRs if you prefer. All of these are mostly just preparation steps towards implementing codegen for data-tiled multi_mma.

Also update the PR description before landing describing what moved + how getIntrinsicSwizzle was generalized.

@qedawkins , I pushed a commit with fixes for your comments and also for something I thought of. Some WMMA intrinsics have tstrides=0. I have no idea what that means, but that does defeat my getSortingPermutation algorithm. For now I just added assertions against that so we get an explicit failure (at least in asserts builts) when we try doing WMMA data tiling (if ever). WDYT ?


tbody and table -- Each child in an array or iterator should have a unique "key" prop.

running w/ React 0.14.0
getting the above warning due to 2 different lines:
64: return $.tbody({}, [$.tr({}, $.td({}, this.getSetting('noRowsMessage') ))]);
80: return $.tbody({}, rows);
if I add a key to tbody in both lines and tr in line 64, the warning stops occuring.
64: return $.tbody({key: "__noRowsMessage__Table__"}, [$.tr({key: "__noRowsMessage__Row__"}, $.td({}, this.getSetting('noRowsMessage') ))]);
80: return $.tbody({key: this.getSetting( 'classPrefix' ) + 'TBody'}, rows);

I have removed the warning for the version 0.0.3. But the way of really giving a key for every row is setting the keyField in the tableSettings, to give every row a meaningful key.


Character count component does not display errors correctly

When you call the component with an error already set (eg. if its a mandatory field the user has left blank) the textarea itself does not get the correct classes set. Resulting with the box not having the red highlight.
It appears the js strips it out as the user hasn't reached the character limit yet.

Invoked with {{ govukCharacterCount({         name: "with-hint",         id: "with-hint",         maxlength: 200,         label: {           text: "Can you provide more detail?"         },         errorMessage: {           text: "This is an example"         },         hint: {           text: "Do not include personal or financial information like your National Insurance number or credit card details."         }       }) }}

Thanks @Jagordon. The red border of the character control box is intentionally tied to the character limit error condition, so the component is working as intended.
We discussed changing this following your useful feedback, but we've decided to keep it as is - we think it might be more jarring to have the red border immediately disappear once the user starts typing into the box.


Add FuboTV as AdobePass Provider

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Added Fubo TV as an AdobePass provider.
closes #26488

review @dstftw

Apologies, but this isn't ready to go yet after all. I did all my testing before actually cutting the cord with Spectrum, and I didn't realize that ytdl was caching my Spectrum credentials. So all the tests I thought were using Fubo were actually using Spectrum. Only after I dropped Spectrum over the weekend, and my downloads started failing (and printing a message including Spectrum's phone number) did I realize there was a cache, and only after I cleared it did I realize my code doesn't work. Sorry for the confusion.


[#3332] Fix running elevated tests with normal python test runner.

Scope
This fixes the way tests are selected to be executed on buildslaves
Changes
I have fixed the way tests are selected when arguments are provided.
As a drive by, added a test_diff helper which will run only tests which
Version 0.66.0 was already released.
How to try and test the changes
reviewers: @hcs0
This is used mostly for developers... but here were are :)
Check that you can select remote tests, just like you did on local.
Any paver test [ARGS] should be able to be replaced with paver test_remote ubuntu-1604 --wait [ARGS] and the same tests should be selected to be executed
# Both normal and elevated tests are executed with listing the names of the tests which were executed
$ paver test_remote ubuntu-1604 --wait -v

# Only the 2 elevated test are executed.
$ paver test_remote ubuntu-1604 --wait elevated.test_filesystem:TestBrinkFilesystem -v

# A single normal tests and a single elevated tests is executed
$ paver test_remote ubuntu-1604 --wait elevated.test_filesystem:TestBrinkFilesystem.test_placeholder test_filesystem:TestBrinkFilesystem.test_parseWindowsPaths -v

needs-review

Tested on server and brink repos:
./paver.sh test_remote ubuntu-1604 --wait -v
brink:
All Builds Complete
brink-ubuntu-1604: success (build successful) https://buildbot.chevah.com:10443/builders/brink-ubuntu-1604/builds/83

server:
All Builds Complete
server-ubuntu-1604: failure (failed test) https://buildbot.chevah.com:10443/builders/server-ubuntu-1604/builds/211

./paver.sh test_remote ubuntu-1604 --wait elevated.test_filesystem:TestBrinkFilesystem.test_placeholder test_filesystem:TestBrinkFilesystem.test_parseWindowsPaths -v
brink:
All Builds Complete
brink-ubuntu-1604: success (build successful) https://buildbot.chevah.com:10443/builders/brink-ubuntu-1604/builds/84

server:
All Builds Complete
server-ubuntu-1604: failure (failed test) https://buildbot.chevah.com:10443/builders/server-ubuntu-1604/builds/210

./paver.sh test_remote ubuntu-1604 --wait elevated.test_filesystem:TestBrinkFilesystem -v
brink:
brink-ubuntu-1604 - no build yet / pending - Waiting for [u'brink-ubuntu-1604']

Seems to go for some time, decided to stop it.
server:
server-ubuntu-1604 - test [ETA -11s] - Waiting for [u'server-ubuntu-1604']

Thanks for the review.
I think is ok.
When you see [no build yet / pending] you should check if the slave is busy... it might be that it is running tests for chevah/server or for another repo.
We now have a VM host down so a couple of VMs are not available https://chevah.com/buildbot/buildslaves


docs: Doc updates on classes.

Just adding things that personally I have learned/think is useful to know so far.
Check List

[x] yarn run prettier for formatting code and docs

@dai-shi okay, I've rebased this, I believe addressed all of your feedback, and also made some additions to the new Computed Properties guide. Let me know if I missed any comments, or any other changes you'd like. Thanks!

it would for getters and setters, but not methods in general.

Good point; I've just taken the "always" text out for now. I agree addressing methods would be useful, but probably as a follow up PR.
I kinda wonder if maybe snapshots should just have all methods dropped from the type; that would be possible with TypeScript mapped types, dropping all methods/functions, so only properties & getters would be invocable on the snapshot.
I'm also kind of wondering about some sort of function.bind / apply magic that would try to invoke object/class methods with this always bound to the proxy. So even snap.clickMe() would have this be the proxy. Not sure if that is possible or desirable, but just an idea.

May I merge this, or should wait?

Yep, feel free to merge. Thanks!

I kinda wonder if maybe snapshots should just have all methods dropped from the type; that would be possible with TypeScript mapped types, dropping all methods/functions, so only properties & getters would be invocable on the snapshot.

What do you mean?
This is still useful:
const state = proxy({
  firstName: '...',
  lastName: '...',
  getFullName() {
    return this.firstName + ' ' + this.lastName
  }
})

Just dropping types doesn't help for JS users anyway. I mean we want the same capability for JS and TS.

I'm also kind of wondering about some sort of function.bind / apply magic that would try to invoke object/class methods with this always bound to the proxy. So even snap.clickMe() would have this be the proxy. Not sure if that is possible or desirable, but just an idea.

Yes, for withClass util, I thing .bind() could be a nice magic. But, we need to know, if a method is for mutation, or just getting values. (If we disallow methods for getting values, and only recommends getters, it might be possible. Unfortunately, it's too counter-intuitive.)

This is still useful:

Ah yeah, a non-getter method; that's true, the wrinkle with methods is that we have to trust the user to not make any side-effecting calls, i.e. they shouldn't write:
const state = proxy({
  firstName: '...',
  lastName: '...',
  handleNewName(input) {
    this.firstName = ...
  }
})
const snap = snapshot(state);
const onClick = () => snap.handleNewName(...)

And so, dunno, it seems a little safer to just say "snapshots never have might-be-side-effecting methods", and nudge users to rewrite getFullName as a getter b/c it will better communicate "you really can't modify the state here".
Ah yep, exactly as you said, "we disallow methods for getting values".
I dunno, personally I find "methods can have side effects so snapshots don't have them" to be very intuitive, but agreed that would not be immediately obvious to beginners.

I thing .bind() could be a nice magic

Nice, yeah I'll play around with it a bit when I get a chance.

Continuing the last topic a little bit.
While I kept saying this is advanced, I don't mean to drop it. So, I'd expect this to work:
const state = proxy({
  name: 'valtio',
  setName(input) {
    this.name = input
  },
  getName() {
    return this.name
  }
})

state.setName('react') // expected to work as `state.name = 'react'`

snapshot(state).setName('react') // runtime error as `snap.name = 'react'`
//              ^ that can be `never` in TypeScript, but there's no way to guess if a method contains mutation

state.getName() // just works

snap(state).getName() // should work too as `snap.name`

Furthermore, this is valid, right?
const state = proxy({
  name: 'valtio',
  counter: 0,
  get theName() {
    ++this.counter
    return this.name
  }
})

While I kept saying this is advanced, I don't mean to drop it

Great!
Yep, everything you outlined makes sense to me, in terms of both making sense intuitively + being how Valtio behaves today.


remove extenstions property in order to prevent deprecation warning

remove deprecations

https://github.com/gcollazo/ember-cli-showdown/commit/015b255fd62e81fca039f1a8ee09144a6c6803d1 should resolve this
Released in 4.5.0


Do not shift to the File Explorer after selecting "Add to workspace ->Open in current window"

OS: Win10
Build Version: 20191202.1
Regression: Not a Regression
Repro Steps:

Enable "Azure Storage : Enable View In File Explorer".
Create a storage account --> Create a blob container --> Click "Open in File Explorer".
Select "Add to workspace" when asked.

Back to Azure Storage panel --> Click "Open in File Explorer" again for a same blob container.
Select "Open in current window".

Expect:
Focus should shift to the File Explorer.
Actual:
Stay in Azure Storage panel and nothing works.

Cleaning up Will's mess >:(


Check MDC Cloud Security Posture Management is using Standard plan

Existing rule
No response
Suggested rule
Any pricing plans deployed for Microsoft Defender for Cloud should use the Standard pricing tier.
CSPM is now GA so there should be a rule similar to other workload protections.
Pillar
Security
Additional context
Same as #1632 but for Defender CSPM.

I'm already on it, so I'd like to contribute on this one.


update slug validation to include forward slash

:+1: This looks good whenever the tests pass.
We figured we can be less strict in the Edition class for the slug validator then if we need to exclude forward slashes in one of the child classes we can explicitly exclude it there.


It does it wrong when converting from float to int.

Hi team,
I moved this from here: https://github.com/dotnet/docs.tr-tr/issues/17
the comments below were machine-translated
@XLIVE99 commented on Thu Apr 16 2020
(int) returns the result (2.02f * 100) 201, but returns the result (int) (2.02001f * 100) 202.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91266ab9-071d-067c-df52-8a297045af24
Version Independent ID: 1d378928-4bb5-6bcf-49ca-2026768ab2aa
Content: Casting and type conversions - C# Programming Guide
Content Source: docs/csharp/programming-guide/types/casting-and-type-conversions.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@CeciAc Do you have any more details on this issue? The testing I did shows the correct result, and the documentation matches the behavior.

When i try it on online compiler, result is wrong.

I get the output "1, 2" on .Net Framework in 32-bit mode, but "2, 2" on .Net Framework 64-bit and on .Net Core (both in 32-bit and 64-bit mode).
So I think that this is a .Net Framework bug, but one that's probably not going to be fixed.


[Bug] Unable to find library -lunwind (new NDK support)

Describe the bug
After switching to rust nightly (1.69), (because I needed to use the mutex_unpoison feature), my android builds started to error with "unable to find library -lunwind". I did some research and I found that in Rust 1.68, Rust finally updated their NDK support to r25. I was able to install the laatest NDK and the latest version of cargo-ndk, and I was able to build my app on Rust nightly.
This should be noted in the docs, and updated when Rust 1.68 is stable.
Codegen logs with RUST_LOG=debug environment variable
N/A

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

Sure, feel free to PR!


US 01.01.01

User Story
As an organizer, I want to create a new event and generate a unique QR code for attendee check-ins
Acceptance Criteria

Given

A button on the homepage to create a new event

Action

[ ] Once clicked, it will take the user to another fragment asking for the details about the event. This includes:

[ ] Event title
[ ] Description
[ ] Date and time
[ ] Location
[ ] Milestone number (asks the organizer to include a milestone number so that they will be notified once a milestone is reached. Can be left blank in which case, no milestone notifications will be sent)
[ ] Option to upload a poster to the event
[ ] A toggle button to create a unique check-in QR code.
[ ] Options to "hold to confirm event" or "hold to discard event"

Then

Store the event details and QR coed in the database.

Additional components

Storyboard demonstrating the feature
QR Code Generation
Firebase Integration
Multi-User Interaction
Image upload

added

A toggle button to create a unique check-in QR code.
Options to "hold to confirm event" or "hold to discard event"

Edit the XML when adding an event by adding "attendees" after the ___ of Milestone. It would look like this
Milestone: ____ Attendees


Not clearing changelists after submit, if no open files

Seems like after submitting a changelist, if no open files remain, the old changelist/files are "stuck" in the source control list.
Looking at the output, there's
"/usr/local/bin/p4" opened
ERROR:
File(s) not opened on this client.

Probably when an error occurs, the list isn't updated.
If I open any other file manually, p4 opened returns a list of files (well, 1 file at this point) and the list of open files is refreshed then correctly.
But then if I revert that one opened file, the same problem occurs: it's stuck forever in the list, because p4 opened returns an error.
Also, I am pretty sure I've seen this issue of p4 opened errors being discussed somewhere, but I can't find it o.O

Ah, found the original comment I was referring to:
https://github.com/stef-levesque/vscode-perforce/issues/62#issuecomment-312480112
In a little different context.
By the way, plugin version is 2.1.1

Closing as duplicate of #62


material_select() options ?

Hi, is there any options like dropdown for material_select ?
$('select').material_select({
    maxHeight: 200px,
    belowOrigin: true
});

+1 for this two features

Hi, I included this in my PR.

Closed due inactivity, feel free to reopen it if it is still necessary.


Temp release

ref
https://github.com/kserve/kserve/pull/2627
https://github.com/kserve/kserve/pull/2628

https://github.com/ddelange/kserve/releases/tag/v0.10.0-rc42


Problem: missing build/codecov info on front page

Solution: add build and codecov info, also need to add the build workflow

the commits are all wrecked, i will PR again


Update artifacts

Depends on proofcarryingdata/zupass#1758
This PR updates the circuit artifacts to accommodate the changes introduced in https://github.com/proofcarryingdata/zupass/pull/1734.

This PR updates the circuit artifacts to accommodate the changes introduced in https://github.com/proofcarryingdata/zupass/pull/1734.

I think you mean 1758 not 1734?


How do you get at events in WithStateHandlers?

Here's a contrived example (I'm using React Native).
const App = ({ positionX, handleButtonPressX, positionY, handleButtonPressY }) =>
  (<View style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}>
    <Button title="Set X Position" onPress={handleButtonPressX} />
    <Button title="Set Y Position" onPress={handleButtonPressY} />
    <Text style={{ marginTop: 30 }}>
      {`X: ${positionX}\nY: ${positionY}`}
    </Text>
  </View>);

const trackPositionX = compose(
  withState('positionX', 'setPositionX', ''),
  withHandlers({
    handleButtonPressX: ({ setPositionX }) => (event) => {
      setPositionX(Math.floor(event.nativeEvent.pageX));
    },
  }),
);

const trackPositionY = withStateHandlers(
  () => ({
    positionY: '',
  }),
  {
    handleButtonPressY: () => (event) => ({
      positionY: Math.floor(event.nativeEvent.pageY),
    }),
  },
);

When clicking the Set Y Position button I get the error
null is not an object (evaluating 'event.nativeEvent.pageY')
It seems  event is undefined. I know this is probably a basic programming concept I'm not getting. Can someone help me understand?
Thanks!

At the moment of setState state function is called event can be already freed, as React reuses event object.
Seems like we need to fix this somehow.

It will be a good first PR

For more details plz read React docs about event.persist

I really want to help with this but am completely out of my element even getting things set up.
I've forked the repo and cloned locally but don't know what to do next.
How do I set up my local project to use the cloned version of recompose?  I feel that will be the easiest way for me to test if my changes are working.  Is there a better way?
Sorry, total newb at contributing to an external project.

@GollyJer You can try to create a simplified version of your code base on this jsfiddle. Removing irrelevant code can help us help you.

@GollyJer You should run yarn install after cloning this repo, then run yarn run test:watch which will run all tests and watch all source file. If there is a change to source files, it will rerun the related tests.


Vertical Slider

Hello,
Following https://github.com/fonsp/Pluto.jl/issues/2827
For some notebooks it could make sense to have a vertical Slider
Following your comment https://github.com/fonsp/Pluto.jl/issues/2827#issuecomment-1966593467 I tried
html"""
<div>
    <input style="writing-mode: vertical-rl" type=range>
</div>
"""

but haven't been able to bind the value to the slider
Kind regards

Maybe this can be implemented with writing-mode. Need to take care that the show_value still works properly.

Until then you could use the html element directly:
@bind x html"<input style="writing-mode: vertical-rl" type=range min=5 max=25>"

@bind V1 html"""<input style="writing-mode: vertical-rl" type=range min=0 max=1 step=0.1 default=1>"""

is a good workaround (with triple quote)
Thanks @fonsp

On the other side... doing something like
begin
	ui_v1 = @bind V1 html"""<input style="writing-mode: vertical-rl" type=range min=0 max=1 step=0.1 default=1>"""
	md"""$(V1) $(ui_v1)"""
end

returns missing


Integration with Obsidian-Desmos

There's neet plugin for drawing graphs with desmos: https://github.com/Nigecat/obsidian-desmos
Unfortunately, it uses LaTeX for graphing syntax. What about some special switch to enable support of ASCIIMath in desmos-graph code blocks? I think, it should be as easy as we've already done with the obsidian's math blocks.
Also, I'm not sure, if this should be done by the obsidian-asciimath plugin, and not by the obsidian-desmos plugin.
What do you think?

I'm not sure how it parses the equations, and the formulas am generates will contain a lot of \left and \right, and I wonder if it may cause problems.
I will look into desmos' api and try to test in the future.


Force update drivers based on condition

Problem:
An already installed driver with an unknown condition can get stuck in
ithat condition
Solution:
If a condition is unkown force update the driver

LGTM


Chart doesn't display

Used the exact same example as given in the doc. Also tried the index.html file in examples/dist directory. Both the pages will load all the other elements, but the chart itself is not displayed at all.

i am also facing the same issue, i am using react. The chart seems to be rendered but the svg contents is loaded with 0 height (no css) . I think this is causing some issue .

Can you link to a live example of this issue? If a height of zero is being experienced, you may have to set a width and height on the container div. The library tries to utilize any existing height/width specifications on this container div.
Nevertheless, it should be setting a default width and height if it cannot determine one. I might have to look as to why that is not getting set.

Confirmed that neglecting to have any width or height added to the container did not trigger the library defaults.

Thanks! It's up now. Keep up the great work!


Fix SyntaxError ":"

SyntaxError
Unexpected token ':'
in http://<IP_ADDRESS>/luci-static/resources/view/status/include/10_system.js?v=git-21.100.21501-4576fd4:?
at http://<IP_ADDRESS>/luci-static/resources/luci.js?v=git-21.100.21501-4576fd4:178:29
at async Promise.all (index 0)

Thanks for PR.

BTW, openwrt-19.07 is outdated, please move to openwrt-21.02.


Confused about the inconsistency between the article and the code

Thanks for your work, but when I checked the code, I found that the method of calculating EU and AU in the code seems to be different from the method in the article. The method of calculating EU in the article is to calculate the entropy of the output under the same model parameters for different contexts, and the calculation of AU is through TU-EU, but there seems to be no corresponding process in the code. Instead, the calculation of AU can be calculated by calculating the entropy of the category probability obtained from different contexts, and the calculation of EU is TU-AU.
I am very confused as to whether there is something wrong with my understanding. I look forward to your reply.

The same question as  GuoCheng12

Sorry for the confusion, you can regard AU as EU (and vice versa) in the code. We made a mistake with the variable name.


A little additional clarity on the permission scope

It is unclear how to add this permission scope: /providers/microsoft.insights/eventtypes/management

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 564fcf4e-69b9-a8b0-a362-c4effeca4a8b
Version Independent ID: 7ae1feea-e9ca-bc0a-c984-81b19f4339b8
Content: Grant access to create Azure Enterprise subscriptions - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/grant-access-to-create-subscription.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @jureid
Microsoft Alias: jureid

Thanks for your comment. The feedback has been shared with the content owner for further review.

So adding User Accces Admin, per the article linked, does not allow access to that scope:
"The client [redacted]  with object id [redacted] does not have authorization to perform action 'Microsoft.Insights/eventtypes/values/read' over scope '/providers/Microsoft.Insights/eventtypes/management' or the scope is invalid. If access was recently granted, please refresh your credentials.

@tfitzmac Can you please review the issue and update document accordingly?


Ability to show screensaver depending on day and night

Codecov Report

Merging #317 into master will increase coverage by 0.04%.

@@            Coverage Diff            @@
##           master    #317      +/-   ##
=========================================
+ Coverage   14.16%   14.2%   +0.04%
=========================================
  Files          13      13
  Lines        1490    1521      +31
=========================================
+ Hits          211     216       +5
- Misses       1279    1305      +26

Impacted Files
Coverage Δ

Aerial/Source/Models/ManifestLoader.swift
8.74% <ø> (-0.84%)
:x:

...urce/Controllers/PreferencesWindowController.swift
10.78% <22.22%> (+0.28%)
:white_check_mark:

Aerial/Source/Controllers/Preferences.swift
61.19% <50%> (-1.11%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73333d...295f312. Read the comment docs.

Why dont push this on master?

As discussed here https://github.com/JohnCoates/Aerial/pull/501#issuecomment-424292645 and here https://github.com/JohnCoates/Aerial/pull/501#issuecomment-424389068, with the new JSONs, Apple no longer indicates time of day. We'll have to provide this data ourselves to reintroduce that feature.

As discussed in the other similar PR, reimplemented with 1.4 as the day/night information is no longer in the JSONs for the 4K versions. Thanks for your contribution!


NPE due to expired ephemeralId

For the NetBeans plugin I'm seeing
java.lang.NullPointerException
	at io.foojay.api.discoclient.DiscoClient.getPkgInfo(DiscoClient.java:1160)
	at org.netbeans.modules.java.disco.Client.getPkgInfo(Client.java:87)
	at org.netbeans.modules.java.disco.DownloadPanel.lambda$downloadBundle$0(DownloadPanel.java:113)

An expired ephemeralId returns a JSON like:
{
  "value":"c0a94587dd7058aa1a50006dd7aacc206d97d0aa",
  "detail":"Requested ephemeral id cannot be found or is outdated.",
  "supported":"Valid ephemeral id from package."
}

then discoclient tries to exact the filename and fails:
            final String     filename          = packageInfoJson.get(PkgInfo.FIELD_FILENAME).getAsString();

PR #10 fixes this.


[Q] Changing team type from corporate/work to academic

Hi W&B team,
Is it possible to change the following team's type from "Corporate" to "Academic"?
Team account: https://wandb.ai/sustainlab1
My personal account: https://wandb.ai/cpolzak
We didn't realize we'd run into an issue and my labmate and I hit the corporate hour tracking limit. We both just deleted other old academic teams we were on to make space for this one.
Thank you for your time and help!

Hi! I see that you already have a subscription under your account named waggle, without a team. It is marked as academic and therefore it does not let you make a second academic team. I can go ahead and delete it since it doesn't have a team anyway, and then mark sustainlab1 as academic for you.

Please do! I couldn't figure out how to fully delete waggle

Bumping thread in case my reply got lost -- I'm fine with waggle being deleted and having sustainlab1 marked -- if there's still an issue because of my teammate's account, he's also fine with that team being deleted (please also let me know if I need to provide evidence of that)

Thank you for the bump, this got completely buried 😓
Waggle is not deleted and sustainlab1 is marked as your academic team.
Cheers!
Artsiom

Thank you for the bump, this got completely buried 😓
Waggle is now deleted and sustainlab1 is marked as your academic team.
Let me know if you have any more questions regarding this!


Getting Crash on Release Mode and reported by Apple

When we are running on Release Mode App is getting crash due to Swift NIO. Sorry for the blaming. Please have a look at the Crash Report.
It clearly says: CNIOLinux Framework not Loaded
Exception Type:  EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note:  EXC_CORPSE_NOTIFY Termination Description: DYLD, Library not loaded: @rpath/CNIOLinux.framework/CNIOLinux | Referenced from: /var/containers/Bundle/Application/4F413213-073D-41FA-AF10-1EDEC4AC5D2A/*****.app/***** | Reason: no suitable image found.  Did find: | /private/var/containers/Bundle/Application/4F413213-073D-41FA-AF10-1EDEC4AC5D2A/*******.app/Frameworks/CNIOLinux.framework/CNIOLinux: mremap_encrypted() => -1, errno=12 for /private/var/containers/Bundle/Application/4F413213-073D-41FA-AF10-1EDEC4AC5D2A/*****.app/Frameworks/CNIOLinux.framework/CNIOLinux Triggered by Thread:  0
I have already heard one of your main contributors Swift-NIO Works very well on Release modes. But now I don't know, Why am I getting this crash. Because of this crash, we are stopped our App Release :(
We want some idea like, Should we need to do anything special for Swift NIO on Release Mode.
Enviornment Details
iOS 12.3.1 (16F203)
iPhone X
Thanks
Ranjith

No special steps should be required here. In your install process are you copying the CNIOLinux framework into your app?

No special steps should be required here. In your install process are you copying the CNIOLinux framework into your app?

I am embedding framework in application.

And there are no meaningful differences between your release binary’s install and linking process and the distribution binary?

@ranmyfriend / @MobileMatrix any updates here? There is nothing special that should be required for SwiftNIO in release mode at all.
How are you depending on SwiftNIO? Via the Xcode Packages support or via CocoaPods or via dragging in the project into your xcodeproj?

Thanks for your support @weissi  @Lukasa The issue is addressed and it was from our end

@ranmyfriend I'm experiencing the same issue on release mode. Could you please tell me how you resolved it?

@sehajc there was an issue from our end and not from NIO side. So we have fixed it. But am also saying NIO works well in debug as well as Release Mode. If you are facing any issue specifically please describe more about the issue and let us know.

@ranmyfriend Thanks. I understand it's not an issue from NIO side. We are using Carthage instead of swift package manager as our dependency manager. We get a crash in release mode(on iOS 12), the same as yours "Reason: no suitable image found." for "CNIOLinux".
My guess is that we are not setting up the .xcodeproj correctly but we haven't been able to figure it out yet

@sehajc Okay let me explain to you what we faced and how we resolved it. So initially we were used Swift NIO using Carthage but the way we wanted in a private framework which has a dependency for NIO. But here is the catch it was giving some problem, So we went with Cocoapods. Like we built our own framework and added Swift-NIO as dependency there. then it solved our issues and even it works well. Why dont you try the same approach on your project. And can you please confirm me? Are you using Swift NIO directly to your project or via custom framework?

@ranmyfriend Thanks. That's very helpful. We are trying the private framework approach as well. Using swift package manager to generate xcodeproj for swift-nio project and then using carthage to build all NIO frameworks. We are making sure to link all the NIO frameworks built with Carthage into the app, not just the private framework. We'll keep on trying with Carthage or eventually switch to SPM for swift-nio.
Unfortunately the project I'm working on is a couple years old with lots of dependencies and we rely heavily on Carthage so switching to Cocoapods is a no-go.
Thanks again for your help


fix(web): do not rely on ReadableStream.from or new ReadableStream

For #492

Please feel free to move writer.close() out of the async function, and perhaps into a .finally(...) block instead

CFW should raise the compatibility date in their config, or set the feature flag: https://developers.cloudflare.com/workers/configuration/compatibility-dates/#streams-constructors


以后接入 SignalR。

Incredibly simple real-time web for .NET

https://github.com/aspnet/SignalR-Server
https://github.com/aspnet/SignalR-Client-JS
client 还 under active development.

其实有个依赖 jquery的client。

😢

那等以后到了再说（


Couldn't register hook "directus-extension-searchsync"

Hi,
I get error below. Extension is not working for me.
23:38:55 ✨ Loaded extensions: directus-extension-searchsync, masked-interface
23:38:55 ⚠  Couldn't register hook "directus-extension-searchsync"
23:38:55 ⚠  Unexpected token '.'

{
  "name": "directus-playground",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "MIT",
  "dependencies": {
    "directus": "^9.0.0-rc.95",
    "pg": "^8.7.1",
    "directus-extension-searchsync": "dimitrov-adrian/directus-extension-searchsync#v1.0.0-rc.94"
  }
}

Should be fixed in v1.0.0-rc.95


chromecast api is always undefined

Everything seem to be loader properly but no button added to the player.
ChromecastSessionManager.isChromecastAPIAvailable() always return undefined so it get stuck.
Im on Mac, with chrome 83.0.4103.61
Looks like property: window.chrome.cast is undefined
Am I doing something wrong?

My error, I wasnt running file from server.

You saved my day! I do not know why but this plugin seems to work only on server, not work while developing  in localhost. Thanks

You saved my day! I do not know why but this plugin seems to work only on server, not work while developing  in localhost. Thanks

@yucomds Hello, I believe I'm having the same issue. Could you please share how did you manage to solve it?


[Gluten-core] Rename metrics name from wall nanos to totaltime to xxx.

Mentioned in #987

The CI failure during step Setup docker container might not be related. A fix proposed at #1036

cc @FelixYBW @rui-mo

@Yohahaha Thank you. We find cpu count is also useful to us, and can be used to calculte the avg time. Could you help add that back?

We find cpu count is also useful to us, and can be used to calculte the avg time. Could you help add that back?

Sure, submit commit in this pr or open another pr?
How do you calculate avg time? cpu_time / cpu_count or wall_time / cpu_count?

cpu_time / cpu_count or wall_time / cpu_count?

I think wall_time is more useful to us.

Got it.
It looks like cpu time is not important for us currently, and from Spark's point of view it is also unimportant, shall we remove this to make Spark UI more clearly?

It looks like cpu time is not important for us currently, and from Spark's point of view it is also unimportant, shall we remove this to make Spark UI more clearly? @rui-mo

@FelixYBW Binwei, how do you think so?

OK, let's remove cpu time, use wall time.


Order of Chapters

We'll use this issue to discuss the order of the chapters once enough chapters have commitments from authors.

Order of Chapters Project board created so we can drag the chapters in order:

Depending on the topics chosen/people who want to contribute, perhaps we could divide it into sub-categories like Computer DFIR/Mobile DFIR?

Depending on the topics chosen/people who want to contribute, perhaps we could divide it into sub-categories like Computer DFIR/Mobile DFIR?

I was already thinking that since we have 2 chapters covering mobile thus far! My chapter won't be technical so it'd just be part of a "General" section, I guess. TBD exact name

I think sub-categories could help with the flow so it's not jumping around too much. Could also look at beginner topics section and more advanced topics section to help target sections to people's experience level.

Definitely happy to help with the ordering. Agreed on the fact that there could be sections
Here are some groupings I see already:
Beginnings

Introduction
History of the Digital Forensics Discord Server
NEW TOPIC* History of DFIR
Analysis
Most Common Data Stores in Mobile Forensics
Basics of Malware Analysis
I have a password Hash now what
Large Scale Android Application Analysis
A Brief Look at Snapchat
Methodology for Parsing Unsupported Artifacts
Process
Setting up a Law Enforcement Digital Forensics Lab
Trust but Verify
Career Progression
Getting into Digital Forensics
DFIR Career Guidance
Gamification of DFIR - Playing CTF's for Sport and Profit

Introduction
I.   DFIR History

      History of the Digital Forensics Discord Server

      NEW TOPIC* History of DFIR Analysis

II.  Just the (arti)Facts Ma'am

    Most Common Data Stores in Mobile Forensics

    Basics of Malware Analysis

    I have a password Hash now what

    Large Scale Android Application Analysis

    A Brief Look at Snapchat

    Methodology for Parsing Unsupported Artifacts

    Process

III.  I want to Believe ##_____ (a 3rd article may tie the LE and Trust but verify...)

Setting up a Law Enforcement Digital Forensics Lab
Trust but Verify

IV.  Your DFIR Career

Career Progression
Getting into Digital Forensics
DFIR Career Guidance
Gamification of DFIR - Playing CTF's for Sport and Profit

https://github.com/Digital-Forensics-Discord-Server/CrowdsourcedDFIRBook/projects/1
I reworked the Kanban board and split up the sections so we can view things more horizontally than vertical in a single column.

@dwmetz did you wanna author the history of DFIR Analysis chapter? Or was that just a suggestion of a topic?

@AndrewRathbun ,  That was @B1N2H3X I believe

@AndrewRathbun , That was @B1N2H3X I believe

Hah, you're right, I didn't scroll up high enough and it's been a few weeks since I was last in this issue :) Thanks for pointing that out!

By my count, we have 6 chapters (including Chapter 0 - Introduction) ready for v1.0. 4 more and we're going to publish once they are edited and approved by all stakeholders.
https://github.com/Digital-Forensics-Discord-Server/TheHitchhikersGuidetoDFIRExperiencesFromBeginnersandExperts/labels/v1.0

As of the writing of this post, here's the chapter that are going to be in v1:
Chapter 0 - Introduction
Chapter 1 - History of the Digital Forensics Discord Server
Chapter 3 - The Basics of Malware Analysis
Chapter 4 - Password Cracking for Beginners
Chapter 5 - Large Scale Android Application Analysis
Chapter 8 - Deobfuscating PowerShell Scripts/Payloads
Chapter 9 - Gamification of DFIR - Playing CTFs
Chapter 16 - Artifacts as Evidence
Chapter 17 - Imaging
Which will pretty much be converted to the following:
Chapter 0 - Introduction
Chapter 1 - History of the Digital Forensics Discord Server
Chapter 2 - The Basics of Malware Analysis
Chapter 3 - Password Cracking for Beginners
Chapter 4 - Large Scale Android Application Analysis
Chapter 5 - Deobfuscating PowerShell Scripts/Payloads
Chapter 6 - Gamification of DFIR - Playing CTFs
Chapter 7 - Artifacts as Evidence
Chapter 8 - Imaging
9 chapters so far with one or two likely to be added on to this. We don't really have enough at this point to justify section dividers (yet). As more are added, I feel like we can justify adding section dividers, but right now, it's looking like a very large General section and one chapter in a Mobile Forensics section. It seems a bit silly to me to have dividers like that. Maybe in the end we end up scrapping the section dividers entirely but we'll see how it plays out.
Thoughts?


[autocomplete] Add tab-completion support for bash

Tab completion support for bash.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alexkaratarakis sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


lts version issue

As of today (Jul 19, 2019), nvm use lts picks up 12.6.0 which is indeed a Current release, but not an Active LTS yet. I believe it should pick up 10.16.0 as what nvm use dubnium currently does, until v12 becomes LTS in October.

We just need to tweak how the index is generated in _nvm_get_index. PR welcome! @tomyun 👋


[$500] Distance - While editing distance, "use current location" option is not displayed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.7-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap on a Workspace chat
Tap plus icon near compose
Tap request money---distance
Enter start and finish waypoints
Tap request
Tap on created distance request to open distance request detail page
Tap on distance
Tap start and note "use current location" option not displayed
Tap finish and note "use current location" option not displayed
Tap Add stop and note "use current location" can be seen

Expected Result:
While editing distance, "use current location" option must be displayed for start and finish waypoints.
Actual Result:
While editing distance, "use current location" option is not displayed for start and finish waypoints.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/c10e96b0-94d1-4982-b854-9a466c845eb3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011640a9e861eb16d6
Upwork Job ID:<PHONE_NUMBER>322466304
Last Price Increase: 2023-12-02

Proposal
Please re-state the problem that we are trying to solve in this issue.
While editing distance, "use current location" option is not displayed
What is the root cause of that problem?
Currently, "use current location" option is displayed when the search value is empty. But when editing distance, the search value will be current waypoint as default
What changes do you think we should make in order to solve the problem?
We can update to display "use current location" option even though search value is not empty
What alternative solutions did you explore? (Optional)
We can reset search value to empty in edit waypoint page

@trjExpensify Currently, "use current location" option is displayed when the search value is empty. But when editing distance, the search value will be the current waypoint as default. What do you think if we display "use current location" option even though search value is not empty

@DylanDylann Thanks for the proposal. Your RCA is correct. However I don't think we want to keep the "Use current location" option always visible as it may be annoying when searching for other places.

@Krishna2323 On it

@Krishna2323 Thanks! That's looks good to me 👍
🎀 👀 🎀 C+ reviewed
Link to proposal

@s77rt
updated proposal to disable "use current location" option if a user is editing the waypoint

@DylanDylann Thanks for the update. I don't think we should completely disable the "use current location" option even if the address input is empty. @trjExpensify meant this in the sense that this is not a bug.

Right, I think this issue should be closed. It's working as expected, IMO. When the field input is empty, it shows "use current location" otherwise it shows results that match what's entered.
Happy for a second opinion from Neil and Jason though before we close it out.


golangci-lint: 1.32.0 -> 1.32.1

Motivation for this change
Bump golangci-lint from 1.32.0 to 1.32.1.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 102239 run on x86_64-linux 1

2 packages built:

golangci-lint
vimPlugins.vim-go

Became obsolete by the later PR #103414.


Getting data from webview

Hey gyes
I am using nativescript webview to simply show the page but can i get data from the html file in my nativescript angular app ?
like we can get data from html forms using js
https://stackoverflow.com/questions/40889152/is-it-possible-to-get-data-from-html-forms-into-android-while-using-webview
and what if we get a string of html tags or what ever from which we grab the desired value
just an example if their a number 2 on the page i know the tag and its id so i get the tags html and then get over desired value directly into my app
is it possible ?

Hi @tahir-jamil,
Check out nativescript-webview-interface plugin, which can help you in making communication between WebView and the application. To make it work, you might need to make some changes in the page, which will be loaded in the WebView (including nativescript-webview-interface.js script, adding some event listeners). For more info, you can check the plugin's ReadMe file.


feat: split produce batches for MESSAGE_TOO_LARGE errors

This PR allows a batched produce() call to try and automatically handle MESSAGE_TOO_LARGE errors by splitting the aggregated batch in two, and submitting each half individually.
While most incidents of this error are due to bad configuration, it can occur even with correctly tuned message sizes due to the aggregator using the approximated record sizes. A WARN log event is emitted each time this automatic splitting is needed to surface any potential misconfiguration to the operator.
This automatic splitting has pros, and cons:

Pro: client doesn't have to care about batch sizing approximation going wrong
Pro: the produce caller retains the original Record, rather than giving up ownership - this makes resubmitting / error handling possible for the caller.
Con: extra pointer indirection & ref counting (negligent in the grand scheme of things)
Con: partial writes can be infrequently triggered in the MESSAGE_TOO_LARGE path, as are spurious produce errors

refactor: wrap record key/value in Arc (43b776e)
Allows "copies" of the key/value bytes to be held for produce request retries
without having to actually copy the underlying buffer, at the minor cost of
extra pointer indirection.

refactor: lend Records to produce() calls (39bac2d)
Changes the ProducerClient::produce() call to take a slice of Records rather
than a Vec, allowing the caller to retain the original buffer and easily
provide a subset slice of the original buffer as needed.

refactor: let MockClient return response sequences (9b7ecf1)
This change affects test code only, changing the MockClient to return a
sequence of configured errors, rather than the same error all the time.

As an example, this can be used to construct a test that observes an error,
followed by a different error, followed by a success - the previous mock was
restricted to always returning the same response.

feat: split produce batch for MESSAGE_TOO_LARGE (99e15b3)
Aggregating the records for produce requests is approximate, and as such
sometimes may result in a batch larger than the configured maximum - if the
size of the batch exceeds the broker's maximum allowed message size
(message.max.bytes) a MESSAGE_TOO_LARGE error is returned.

At this point and prior to this commit, the whole batch was dropped and the
caller has to retry, hoping the retries do not batch into a too-large batch
once again. After this commit, exactly one attempt is made to
automatically/internally split the batch in half and attempt to concurrently
produce each half transparently to the caller. A message is logged at WARN to
help the user identify and tune this config to avoid this.

The two downsides of this are:

   * Unpredictable latency if a batch needs splitting and re-submitting
   * A partial write may occur (writing one half succeeds, other fails)

These downsides are offset by the fact the MESSAGE_TOO_LARGE should be a rare
event, making the latency hit equally rare. Succeeding in producing one batch
but not the other is even rarer still, but does result in an error being
returned to the client even though have the records were successfully
produced. The caller had no control over which writes were in which aggregated
batches anyway, so has no expectation of two writes succeeding/failing
together (atomicity).

For the record: @domodwyer and I agreed that this approach doesn't really work if the aggregator just produces as single record (which is very likely for the IOx use case). Instead we would need to have some inverse operation to the aggregator (=splitter). Implementing this would be nice, but it needs some API design so the whole producer framework doesn't explode in terms of complexity. So we will postpone that for later.


Update pyproject.toml

@BooleanJulien @zackt113 all the changes have been already reviewed as part of the PR https://github.com/UBC-MDS/strappy/pull/41. This is just a version change.


Update redis.adoc

dependency for redis is not correct.
updated typo

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

Sign the contributor license agreement
Rebase your changes on the latest main branch and squash your commits
Add/Update unit tests as needed
Run a build and make sure all tests pass prior to submission

Thanks!