did not work

Describe the bug
I'm not sure but it did not work
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-kedpvd
Steps to reproduce
just typed in the prompt .. thats it
Expected behavior
it didn't work
Screen Recording / Screenshot
not sure why

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 61776531,
  "usedJSHeapSize": 43482567,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = FromByond
Chat ID = 60848bb571a3

Additional context
Error:
Something went wrong whilst creating your site on Netlify.

we're aware of this issue it's due to netlify rate limiting us we're trying to resolve the issue. Closing this issue in favour of tracking at https://github.com/stackblitz/bolt.new/issues/365 instead.


Make '+' mandatory for phoneNumber

What type of PR is this?
Add one of the following kinds:

correction

What this PR does / why we need it:
Make '+' mandatory for phoneNumber as specified in Commonalities.
Which issue(s) this PR fixes:

Fixes #47
Special notes for reviewers:
I've changed the version to v0.6.0-wip as we have released the v0.5.0
As Dawid is not able to review and Fernando still not codeowners I tagged you Herbert for help.
Changelog input
 release-note
- Make '+' mandatory for phoneNumber

Additional documentation
This section can be blank.
docs

As Dawid is not able to review and Fernando still not codeowners I tagged you Herbert for help.

@bigludo7 happy to help. I can't replace a codeowner review, but can help to get @fernandopradocabrillo getting codeowner if this is what is needed.


Update .yamllint for Renovate CI updates

Proposed Changes
This should fix the yamllint error blocking #469 from passing linter action.
Related Issues

(Github link to related issues or pull requests)

not needed any longer, just rebased pr #469 to retrigger a github-tag update


[Bug] Table not queryable when base type is combined with both mutable and immutable entities

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When creating a base type table that has both immutable and mutable entities, any query to the table fails.
In this example, FlowUpdatedEvent is mutable while all the other events are immutable:

A query like this:
query MyQuery {
  events {
    id
  }
}

Will result in an error:
{
  "errors": [
    {
      "message": "Failed to get entities from store: column c.block_range does not exist, query = /* qid: fea699475010fc57-1bb2f8eec95162fc */\nwith matches as (select 'FlowUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"flow_updated_event\" c\n where c.block_range @> $1\n\nunion all\nselect 'FlowOperatorUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"flow_operator_updated_event\" c\n where c.block$ <= $2\n\nunion all\nselect 'IndexCreatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_created_event\" c\n where c.block$ <= $3\n\nunion all\nselect 'IndexDistributionClaimedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_distribution_claimed_event\" c\n where c.block$ <= $4\n\nunion all\nselect 'IndexUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_updated_event\" c\n where c.block$ <= $5\n\nunion all\nselect 'IndexSubscribedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_subscribed_event\" c\n where c.block$ <= $6\n\nunion all\nselect 'IndexUnitsUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_units_updated_event\" c\n where c.block$ <= $7\n\nunion all\nselect 'IndexUnsubscribedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"index_unsubscribed_event\" c\n where c.block$ <= $8\n\nunion all\nselect 'SubscriptionApprovedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"subscription_approved_event\" c\n where c.block$ <= $9\n\nunion all\nselect 'SubscriptionDistributionClaimedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"subscription_distribution_claimed_event\" c\n where c.block$ <= $10\n\nunion all\nselect 'SubscriptionRevokedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"subscription_revoked_event\" c\n where c.block$ <= $11\n\nunion all\nselect 'SubscriptionUnitsUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"subscription_units_updated_event\" c\n where c.block$ <= $12\n\nunion all\nselect 'AgreementClassRegisteredEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"agreement_class_registered_event\" c\n where c.block$ <= $13\n\nunion all\nselect 'AgreementClassUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"agreement_class_updated_event\" c\n where c.block$ <= $14\n\nunion all\nselect 'AppRegisteredEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"app_registered_event\" c\n where c.block$ <= $15\n\nunion all\nselect 'GovernanceReplacedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"governance_replaced_event\" c\n where c.block$ <= $16\n\nunion all\nselect 'JailEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"jail_event\" c\n where c.block$ <= $17\n\nunion all\nselect 'SuperTokenFactoryUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"super_token_factory_updated_event\" c\n where c.block$ <= $18\n\nunion all\nselect 'SuperTokenLogicUpdatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"super_token_logic_updated_event\" c\n where c.block$ <= $19\n\nunion all\nselect 'RoleAdminChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"role_admin_changed_event\" c\n where c.block$ <= $20\n\nunion all\nselect 'RoleGrantedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"role_granted_event\" c\n where c.block$ <= $21\n\nunion all\nselect 'RoleRevokedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"role_revoked_event\" c\n where c.block$ <= $22\n\nunion all\nselect 'CFAv1LiquidationPeriodChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"cf_av_1_liquidation_period_changed_event\" c\n where c.block$ <= $23\n\nunion all\nselect 'ConfigChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"config_changed_event\" c\n where c.block$ <= $24\n\nunion all\nselect 'RewardAddressChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"reward_address_changed_event\" c\n where c.block$ <= $25\n\nunion all\nselect 'PPPConfigurationChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"ppp_configuration_changed_event\" c\n where c.block$ <= $26\n\nunion all\nselect 'TrustedForwarderChangedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"trusted_forwarder_changed_event\" c\n where c.block$ <= $27\n\nunion all\nselect 'AgreementLiquidatedByEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"agreement_liquidated_by_event\" c\n where c.block$ <= $28\n\nunion all\nselect 'AgreementLiquidatedV2Event' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"agreement_liquidated_v2_event\" c\n where c.block$ <= $29\n\nunion all\nselect 'BurnedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"burned_event\" c\n where c.block$ <= $30\n\nunion all\nselect 'MintedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"minted_event\" c\n where c.block$ <= $31\n\nunion all\nselect 'SentEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"sent_event\" c\n where c.block$ <= $32\n\nunion all\nselect 'TransferEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"transfer_event\" c\n where c.block$ <= $33\n\nunion all\nselect 'TokenDowngradedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"token_downgraded_event\" c\n where c.block$ <= $34\n\nunion all\nselect 'TokenUpgradedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"token_upgraded_event\" c\n where c.block$ <= $35\n\nunion all\nselect 'CustomSuperTokenCreatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"custom_super_token_created_event\" c\n where c.block$ <= $36\n\nunion all\nselect 'SuperTokenCreatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"super_token_created_event\" c\n where c.block$ <= $37\n\nunion all\nselect 'SuperTokenLogicCreatedEvent' as entity, c.id, c.vid, c.block_range\n  from \"sgd288379\".\"super_token_logic_created_event\" c\n where c.block$ <= $38\n\n order by \"id\", block_range\n limit 100)\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"flow_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $39\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"flow_operator_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $40\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_created_event\" c, matches m\n where c.vid = m.vid and m.entity = $41\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_distribution_claimed_event\" c, matches m\n where c.vid = m.vid and m.entity = $42\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $43\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_subscribed_event\" c, matches m\n where c.vid = m.vid and m.entity = $44\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_units_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $45\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"index_unsubscribed_event\" c, matches m\n where c.vid = m.vid and m.entity = $46\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"subscription_approved_event\" c, matches m\n where c.vid = m.vid and m.entity = $47\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"subscription_distribution_claimed_event\" c, matches m\n where c.vid = m.vid and m.entity = $48\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"subscription_revoked_event\" c, matches m\n where c.vid = m.vid and m.entity = $49\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"subscription_units_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $50\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"agreement_class_registered_event\" c, matches m\n where c.vid = m.vid and m.entity = $51\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"agreement_class_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $52\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"app_registered_event\" c, matches m\n where c.vid = m.vid and m.entity = $53\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"governance_replaced_event\" c, matches m\n where c.vid = m.vid and m.entity = $54\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"jail_event\" c, matches m\n where c.vid = m.vid and m.entity = $55\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"super_token_factory_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $56\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"super_token_logic_updated_event\" c, matches m\n where c.vid = m.vid and m.entity = $57\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"role_admin_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $58\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"role_granted_event\" c, matches m\n where c.vid = m.vid and m.entity = $59\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"role_revoked_event\" c, matches m\n where c.vid = m.vid and m.entity = $60\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"cf_av_1_liquidation_period_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $61\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"config_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $62\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"reward_address_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $63\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"ppp_configuration_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $64\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"trusted_forwarder_changed_event\" c, matches m\n where c.vid = m.vid and m.entity = $65\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"agreement_liquidated_by_event\" c, matches m\n where c.vid = m.vid and m.entity = $66\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"agreement_liquidated_v2_event\" c, matches m\n where c.vid = m.vid and m.entity = $67\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"burned_event\" c, matches m\n where c.vid = m.vid and m.entity = $68\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"minted_event\" c, matches m\n where c.vid = m.vid and m.entity = $69\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"sent_event\" c, matches m\n where c.vid = m.vid and m.entity = $70\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"transfer_event\" c, matches m\n where c.vid = m.vid and m.entity = $71\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"token_downgraded_event\" c, matches m\n where c.vid = m.vid and m.entity = $72\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"token_upgraded_event\" c, matches m\n where c.vid = m.vid and m.entity = $73\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"custom_super_token_created_event\" c, matches m\n where c.vid = m.vid and m.entity = $74\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"super_token_created_event\" c, matches m\n where c.vid = m.vid and m.entity = $75\nunion all\nselect m.entity, to_jsonb(\"c\".*) as data, c.id, c.block_range\n  from \"sgd288379\".\"super_token_logic_created_event\" c, matches m\n where c.vid = m.vid and m.entity = $76\n order by \"id\", block_range -- binds: [28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, 28151209, \"FlowUpdatedEvent\", \"FlowOperatorUpdatedEvent\", \"IndexCreatedEvent\", \"IndexDistributionClaimedEvent\", \"IndexUpdatedEvent\", \"IndexSubscribedEvent\", \"IndexUnitsUpdatedEvent\", \"IndexUnsubscribedEvent\", \"SubscriptionApprovedEvent\", \"SubscriptionDistributionClaimedEvent\", \"SubscriptionRevokedEvent\", \"SubscriptionUnitsUpdatedEvent\", \"AgreementClassRegisteredEvent\", \"AgreementClassUpdatedEvent\", \"AppRegisteredEvent\", \"GovernanceReplacedEvent\", \"JailEvent\", \"SuperTokenFactoryUpdatedEvent\", \"SuperTokenLogicUpdatedEvent\", \"RoleAdminChangedEvent\", \"RoleGrantedEvent\", \"RoleRevokedEvent\", \"CFAv1LiquidationPeriodChangedEvent\", \"ConfigChangedEvent\", \"RewardAddressChangedEvent\", \"PPPConfigurationChangedEvent\", \"TrustedForwarderChangedEvent\", \"AgreementLiquidatedByEvent\", \"AgreementLiquidatedV2Event\", \"BurnedEvent\", \"MintedEvent\", \"SentEvent\", \"TransferEvent\", \"TokenDowngradedEvent\", \"TokenUpgradedEvent\", \"CustomSuperTokenCreatedEvent\", \"SuperTokenCreatedEvent\", \"SuperTokenLogicCreatedEvent\"]"
    }
  ]
}

Just in case, I put the full version of the error on Pastebin (https://pastebin.com/fu8C6muz) but it is huge because we have many subtypes.
What is the expected behavior?
Return data without error.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Making all the entities of one kind (mutable or immutable) fixes the issue.
Here is a PR in Superfluid's repository:
https://github.com/superfluid-finance/protocol-monorepo/pull/798

hello, I am trying to test a failing case for this in our CI pipeline: https://github.com/superfluid-finance/protocol-monorepo/runs/6410597226?check_suite_focus=true
however, for some reason when I add the immutable tag to the entity, it is still able to successfully do a query for events like so:
query MyQuery {
  events {
    id
  }
}

I was wondering if I was missing something/how I could reproduce this locally so that our tests ensure that this will be caught in the future.
Thanks!

@0xdavinchee This is clearly a bug in graph-node; I am in the process of trying to fix that. Once this is fixed, there shouldn't be a need for you to test that in your CI. It should be totally fine to mix mutable and immutable entities in an interface, and queries should just work for these.


[feature] CONTRIBUTING.md documentation.

Add information about the logistics of contributing and pointers on how to get started contributing to the project, which issues to look at first, etc.
Probably need something about OpenSSF since it's an OpenSSF project. Does OpenSSF require a CLA? We currently don't enforce that.
From OpenSSF best practices:

[x] The project website MUST provide information on how to: obtain, provide feedback (as bug reports or enhancements), and contribute to the software. [interact]
[x] The information on how to contribute MUST explain the contribution process (e.g., are pull requests used?) {Met URL} [contribution]
[ ] The information on how to contribute SHOULD include the requirements for acceptable contributions (e.g., a reference to any required coding standard). {Met URL} [contribution_requirements]

OpenSSF will require CLA. This is being discussed in TAC.
cc. @david-a-wheeler

Should add some instructions on DCO as well. The slsa website repo has a good description.
https://github.com/slsa-framework/slsa/blob/main/CONTRIBUTING.md#signing-your-work


[Request] Backport to 1.20.1

Hey, is there a reason why is the mod specifically 1.20.4 and not 1.20.x, is it because of the ClothConfig v13 dependency?

Backporting shouldn't be too difficult. Boatism has been created for Modfest 1.20 which is an event dedicated to 1.20.4 but I might backport to 1.20.2 and 1.19.2 if people show interest. Which version would you be interested in?
The current focus is to improve the user experience since I have seen many people have trouble using and upgrading the engine.

Oh wow, didnt know there were jams for modding, thats dope!
Yeah im building a modpack on top of 1.20.1 so thats the version I am interested in
Dont worry, take your time, especially with UX


StyleBox fake AA improvements (make anti aliasing size a float property)

By allowing decimal values for StyleBoxFlat's anti_aliasing_size property the user has more control over it while the crispness of the fake AA can be slightly increased as seen in this screenshot (partly fixes #35279):

Although it is by far from perfect, I think this is still an improvement to the StyleBox resource and could be enough for using rounded corners in godotengine/godot#51159 (@Calinou What do you think?). This change can be combined with the addition of an enum for different fake AA techniques as suggested by Calinou in https://github.com/godotengine/godot/issues/35279#issuecomment-891406752.
Changes:

Changed the anti-aliasing size to be a float property and set the new default value to 0.625 (determined through testing)

Adjusted slightly how the anti-aliasing gradient ring is calculated when a border is drawn to partly solve the problems mentioned in #35279. As shown in these screenshots, the extent of the border fake AA gradient ring matches the extent when just the infill is drawn.
CURRENT MASTER:

THIS PR:

Corrected some comments and variable names to fit the Godot codestyle (camelCase variables and COMMENTS FULLY IN CAPS)

I would suggest that you try it out yourself and compile this PR to see it in action since resized screenshots can't properly depict how it looks in the end. Feedback is always appreciated :)

I tested this on my default project theme PR rework. Here are the results: https://imgsli.com/NjQ5MTA/3/5
It's definitely an upgrade over what we have currently, and it should still work nicely on rotated StyleBoxes. Nice work :slightly_smiling_face:

@Calinou @pouleyKetchoupp Thanks for testing.
I fixed the regression and changed some of the remaining comments to match Godot's codestyle (// Abc.) or removed them where they are unnecessary (primarily in the style_box header).

Thanks!

This doesn't seem trivial to cherry-pick so it might warrant a dedicated PR if it's wanted in 3.x.


cmd/vet jsonl error line number

Is your feature request related to a problem? Please describe.
cue vet data.jsonl schema.cue
-- schema.cue --
id: string
-- data.jsonl --
{"id":"2489651045"}
{"id":2489651064}

Gives
id: conflicting values<PHONE_NUMBER> and string (mismatched types int and string):
    ./schema.cue:1:5
    ./data.jsonl:1:7

The error says line 1 of the jsonl file (because each line is considered in isolation).
Describe the solution you'd like
A small nicety but it would be great if the error gave the correct line number, eg 2.

Thanks for reporting, this does seem like a bug. It might not be too difficult to fix, if you want to take a look at a patch :) Though we should likely wait for https://review.gerrithub.io/c/cue-lang/cue/+/555576 to land first, as otherwise this kind of command doesn't work very well.


Extra Space

The generated images have some extra space between lines..
How it should look:
11111111111111111
22222222222222222
But how it look like:
11111111111111111
22222222222222222

Screenshot: https://i.imgur.com/rMhnisd.png

Can you attach the specification of your environment?
For Example,
Platform: Desktop
Browser: Google Chrome
Browser Version: 99.0.4844.82 (Official build) (64-bit)

This error was with one single tweet only.
So closing it.


Draggable cannot choose to use root Overlay

Steps to Reproduce
Create an app with nested [Navigator]s. The non-root Navigator does not cover the full screen. Add within the non-root [Navigator], a [Draggable] with a visible feedback. Drag it.
Expected results: Draggable feedback is shown across the whole screen
Actual results: Draggable feedback is only shown within the bounds of the non-root [Navigator].
[Draggable] calls Overlay.of(context) to get the closest [Overlay]. Need to add a parameter to let user choose to use the root [Overlay] via Overlay.of(context, rootOverlay:true)

Hi @monkeyswarm
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

Flutter doctor output and code sample below. "flutter run --verbose" reveals private information.
I've already submitted a PR at https://github.com/flutter/flutter/pull/67375.
======
[✓] Flutter (Channel DraggableRootOverlay, 1.23.0-8.0.pre.143, on Mac OS X 10.15.6 19G73 x86_64, locale en-US)
• Flutter version 1.23.0-8.0.pre.143 at /Users/diglesia/Source/flutter
• Framework revision 6ae4e7861c (11 hours ago), 2020-10-05 20:57:08 -0700
• Engine revision a8d7d97bef
• Dart version 2.11.0 (build 2.11.0-185.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/diglesia/Library/Android/sdk
• Platform android-stable, build-tools 30.0.2
• Java binary at: /Applications/Android Studio with Blaze.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS (Xcode 11.7)
• Xcode at /Applications/Xcode_11.7.app/Contents/Developer
• Xcode 11.7, Build version 11E801a
✗ CocoaPods installed but not working.
You appear to have CocoaPods installed but it is not working.
This can happen if the version of Ruby that CocoaPods was installed with is different from the one being used to invoke it.
This can usually be fixed by re-installing CocoaPods. For more info, see https://github.com/flutter/flutter/issues/14293.
To re-install CocoaPods, run:
sudo gem install cocoapods
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio with Blaze.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] IntelliJ IDEA Community Edition (version 2019.3.5)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 49.0.2
• Dart plugin version 193.7547
[✓] Connected device (4 available)
• SM T860 (mobile) • R52MA0M1B7Z • android-arm64  • Android 10 (API 29)
• macOS (desktop)  • macos       • darwin-x64     • Mac OS X 10.15.6 19G73 x86_64
• Web Server (web) • web-server  • web-javascript • Flutter Tools
• Chrome (web)     • chrome      • web-javascript • Google Chrome 85.0.4183.121
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Column(
children: [
Container(
height: 200.0,
child: Navigator(onGenerateRoute: (RouteSettings settings) {
if (settings.name == '/') {
return MaterialPageRoute(
settings: settings,
builder: (context) => Container(
height: 300.0,
child: Center(
child: const Draggable(
data: 1,
child: Text('Source'),
feedback: Text('Dragging'),
),
)));
}
throw UnsupportedError('Unsupported route: $settings');
})),
DragTarget(
builder:
(BuildContext context, List data, List rejects) {
return Container(
height: 300.0, child: Center(child: const Text('Target 1')));
},
),
],
),
);
}
}
Result when dragging the [Draggable] towards the [DragTarget]

Preview

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Column(
          children: <Widget>[
            Container(
                height: 200.0,
                child: Navigator(onGenerateRoute: (RouteSettings settings) {
                  if (settings.name == '/') {
                    return MaterialPageRoute(
                        settings: settings,
                        builder: (context) => Container(
                            height: 300.0,
                            child: Center(
                              child: const Draggable<int>(
                                data: 1,
                                child: Text('Source'),
                                feedback: Text('Dragging'),
                              ),
                            )));
                  }
                  throw UnsupportedError('Unsupported route: $settings');
                })),
            DragTarget<int>(
              builder: (BuildContext context, List<int> data,
                  List<dynamic> rejects) {
                return Container(
                    height: 300.0,
                    child: Center(child: const Text('Target 1')));
              },
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.23.0-8.0.pre.185, on Mac OS X 10.15.7 19H2
    x86_64, locale en-GB)
    • Flutter version 1.23.0-8.0.pre.185 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 6620f831e9 (6 hours ago), 2020-10-06 18:15:15 -0700
    • Engine revision 7e6191de07
    • Dart version 2.11.0 (build 2.11.0-186.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.10.0.rc.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.0

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.7 19H2
      x86_64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      85.0.4183.121

• No issues found!

Closing as this should be fixed by #67375.


Posted a build howto

Not an "issue", but I made a screenshot walkthrough of building Pararena 2 in Basilisk II. Maybe I'll add it to the wiki here.
http://bslabs.net/2016/11/13/building-pararena/

Ha ha, that's clever.

I may try this on a Raspberry Pi + MinivMac.
Also, I saw that I would allow you to play the game on Nov. 9, 1965 (not my birthday, BTW).


Proxy service command missing

The command in this article only gives you half of what you need to correctly configure the service application as the proxy service command is missing. You need to add the following command to complete the setup: $proxyService = New-SPSubscriptionSettingsServiceApplicationProxy -ServiceApplication $sa

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43e2eef3-bbbc-7f77-167b-16a04242937e
Version Independent ID: eb78f6b8-1dc7-a269-2bcb-cf3308289a9a
Content: New-SPSubscriptionSettingsServiceApplication (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/New-SPSubscriptionSettingsServiceApplication.md
Product: sharepoint-2016-powershell
GitHub Login: @techwriter40
Microsoft Alias: kirks

The article is accurate; it goes into the specific command needed for creating the service application. The proxy portion is handled as part of https://docs.microsoft.com/en-us/powershell/module/sharepoint-server/new-spsubscriptionsettingsserviceapplicationproxy?view=sharepoint-ps.
@Techwriter40 should we add the full command to create the SA + proxy or leave it as-is with just the SA creation?

@Tseward you can add the full command if you like


Use shunit2 from Travis/Ubuntu xenial

https://packages.ubuntu.com/xenial/shunit2

All 🍏 :) :)

@drazisil Could give this one a click too?

@szepeviktor  Can you pin the version so I don't have to worry about changes possibly breaking things?

In Debian there is one version per release.
But all five release of Ubuntu has the same version, see the youngest: https://packages.ubuntu.com/focal/shunit2

You're welcome.


Add cost savings to take action

Overview
Adds inflation reduction act info into take action page
Closes #141
Demo

Testing Instructions
Go to the take action page, the new text is under Congress just passed a new bill making all of these cheaper!

@derekeder and @SuragNuthulapaty - should we also mention the EV tax credit? With up to $7.5k for new electric cars and up to $4k for used electric cars? Source: https://www.investopedia.com/electric-vehicle-tax-credits-6500157

@vkoves i think that's smart, ill add it

@derekeder and @SuragNuthulapaty - I also think we should move the EV credit first, since that's one of the biggest incentives and one of the more common purchases.


make bincode optional for plexi_core

This PR hides bincode dependency behind a feature. So that it is not a required dependency for plexi_core.
There are multiple reasons, one being that bincode 2 is not officially released and according to the dev team of bincode, the API is subject to breakages.

Merged. Thanks again for the contribution!


Add Error Returns to all Enc/Dec functions

Add error returns for all functions related to security to facilitate sliding window of rotation sets

Started process, utilization of these features will be more present in the rotation/refreshment portion


Devise render_with_scope was removed on version 2.0.0

method render_with_scope was removed in devise 2.0 and controllers in devise_security_extension stop working

i made pull request for this


Subscribe flow gets stuck on card declined

Customer example:
I have been trying to subscribe so I can keep moving forward. Yesterday I put my CC info in but there was a database error and now when I click subscribe nothing happens.

ı get the same error dude ı subscribe 2 times did they get my money twice or didn't get any ?


Move from hello to bye

https://github.com/swapagarwal/JARVIS-on-Messenger/blob/master/modules/src/hello.py#L10
^ This does not seem an appropriate response for hello. Let's move it to bye.

I can do that.

I ended up doing this, as it seems like dkansk1323 has not completed it yet - I hope that's okay.
945bf558eb6feab58bb981988dcc1c578125f5df
e0744454e61eb4dcc1172bf64c2f5083dc60f29f

It's already done sorry for late comment
https://github.com/swapagarwal/JARVIS-on-Messenger/pull/342/commits/f65a041b9579957a1435e3914d9933d3bcd3a2e6

It's already done... sorry for late comment.
#342

Is this bug fixed or is it still available to be worked on ? I am a beginner hoping to contribute.


Cannot follow anyone

I tried but Im unable to follow anyone.
https://github.com/kodadot/nft-gallery/assets/104380776/a1bc932a-faca-4de1-bf1c-ece8e023f0a1

We can only follow the address that has already created his profile.

We can only follow the address that has already created his profile.

can we have that in hover text above follow button? @exezbcz

I agree with exez, it would be nicer for people to follow accounts they like. This way they have to search who has profile and who not, which makes the whole process less enjoyable.
And then for the case when Im missing my profile and cannot follow pls make hover text with something like: "to follow others, you need to set up your profile first".

And then for the case when Im missing my profile and cannot follow pls make hover text with something like: "to follow others, you need to set up your profile first".

when you try to follow someone without profile setup, it will popup the modal to create the profile

@Jarsen136 would personally enable that

i would only limit the user if he did not created yet profile, if you try to follow anyone who does not have profile yet, but you have profile created, it should work

It's doable technologyly, though I do not know why it has not been implemented like this before.
I will give it a shot.


Improve content for session 03-debugging-in-unikraft

…
Adding support files part. Change the name of the session. Update schedule with new naming.
Signed-off-by: Viorel-Gabriel MOCANU (94548<EMAIL_ADDRESS>

@gabrielmocanu , you need to rebase the commit to make it mergeable.

@razvand  Done.


Preserving Partition in the Destination Cluster

Hi All,
This is great work guys in addressing all the short comings of mirror maker . We are trying to see if we can replace this our current setup of mirror with uMirrorMaker before we go live  . We have a strict requirement to preserve ordering of messages in destination cluster to be same as the source cluster . I was going through the code  and looks like there is a message handler support  . Is this the only change we need to do to get it going?
 private object defaultMirrorMakerMessageHandler extends MirrorMakerMessageHandler {
    override def handle(record: MessageAndMetadata[Array[Byte], Array[Byte]]): util.List[ProducerRecord[Array[Byte], Array[Byte]]] = {
      // rewrite topic between consuming side and producing side
      val topic = topicMappings.get(record.topic).getOrElse(record.topic)
//Changed to include source partition information
      Collections.singletonList(new ProducerRecord[Array[Byte], Array[Byte]](topic, record.partition(),record.key(), record.message()))
    }
  }

Also do you guys have any plans on enabling this as a run time parameter  so that we can override it.

Hi,
That is the correct change. Meanwhile, you also need to make sure:

keep the same number of partitions in source and destination brokers for the same topic.
set max.in.flight.requests.per.connection=1. Multiple in flight requests can lose order when previous request is failed.
set block.on.buffer.full=true. This is not related to disorder, but this config can prevent data loss since keeping order might impact performance.

However, there might still be some situations which can cause disorder:

If one request contains multiple records (even with linger.ms=0, there will still be batching) but acks from broker is lost, then producer will retry and order cannot be preserved. e.g. the result on broker will be like 1,2,3,1,2,3,…. For this situation, one solution is to flush after each record. This can prevent disorder, but will impact performance significantly.
If the process is killed before consumer committed latest check-point, when mirrormaker is restarted, it will consume and produce from last check-point which will cause disorder.

If #partition in src is bigger than #partition in dst temporarily, worker will hash the partition into dst. After you expand in dst, it will go back to 1:1 mapping again.

Also do you guys have any plans on enabling this as a run time parameter so that we can override it.

Is this still a manual code change today? If so, will the question/request ever get on the roadmap? And if not so, what's the needed configuration to enable it today?
Also, I'm interpreting this filed issue to mean preserving the partition key hashing of source cluster messages into the destination. Correct me if I'm wrong.

@daluu The partition mapping is already supported by adding a file in worker start command with --dstzk.config dstzk.properties. The content of that file only need enable=true.
Here is the code for the mapping: https://github.com/uber/uReplicator/blob/Federated-uReplicator/uReplicator-Worker/src/main/scala/kafka/mirrormaker/WorkerInstance.scala#L577
For the second part, it's more like preserving the partition number (more restrict than just key).

This is only available in federated uReplicator at the moment?


Position of events wrong in my setup

    <Scheduler       view="week"       week={{         step: 10       }}       events={[         {           event_id: 1,           title: "Event 1",           start: new Date("2023/10/30 09:30"),           end: new Date("2023/10/30 10:30")         },         {           event_id: 2,           title: "Event 2",           start: new Date("2023/10/30 11:00"),           end: new Date("2023/10/30 11:30")         }       ]}     />
Tried the same code in sandbox and my env both produce different results. Attaching screenshots as well. Please help me figure out.

I also have this problem. The issue is severity scales with the height of the calender and the lower down the event is. If you go all the way to the bottom it ends up looking like this. I'm guessing this has to do with how it's getting the screen height or the container height.
top:

bottom:

I also have this problem. The issue is severity scales with the height of the calender and the lower down the event is. If you go all the way to the bottom it ends up looking like this. I'm guessing this has to do with how it's getting the screen height or the container height.
top:

bottom:

Please see https://github.com/aldabil21/react-scheduler/issues/197
Feel free to reopen if you think its not the same issue

Please see #197
Feel free to reopen if you think its not the same issue

Doesn't seem to be?


[DX] Lint: react/no-unescaped-entities

I think escaping special chars in component content is good practice.
"react/no-unescaped-entities": 0,

Proposed:
"react/no-unescaped-entities": "error",

Can we vote on this?

@AleksandarDev  how should we handle cases when text is not hardcoded, but received from backend? Write something like encode everywhere?

@radovix I think in that case this shouldnt be a problem, because linting is done only in development/pre-biuld, not on actual element content in runtime.


Support for Valkey Cache and pricing

Right now the https://instances.vantage.sh/cache page shows only redis and memcached cost whereas AWS has already introduced the Valkey Redis alternative on their platform
Need to update UI too with the same

Reference : https://github.com/vantage-sh/ec2instances.info/pull/757


Audience disappears from items when expanding/collapsing them and saving

Whenever I expand/collapse an item the save button gets enabled, and if I save, the item looses all set audiences.
This happens both in internal and wrapper items.

Fixed in version 2.2.1.

Issue persists on latest version (2.2.11)


add vulkan support

CMAKE_ARGS="-DLLAMA_VULKAN=on" pip install llama-cpp-python

Also see https://github.com/abetlen/llama-cpp-python/issues/1138


Added recipe, diagnostics and documentation for Schlund et al., ESD (2020)

This PR adds the recipe, diagnostic scripts and documentation for Schlund et al., ESD (2020).
Since I used this exact code for the analysis in the paper, a thorough scientific review is not necessary. Please note that due to #1903 the recipe needs to be run with the --check-level ignore option.
Depends on #1874.

Closes #1916
Link to documentation: https://esmvaltool--2015.org.readthedocs.build/en/2015/recipes/recipe_schlund20esd.html

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 PR has a descriptive title for the changelog
[x] 🛠 Code follows the style guide
[x] 🛠 Documentation is available
[x] 🛠 YAML files pass pre-commit or yamllint checks
[ ] 🛠 Circle/CI tests pass
[ ] 🛠 Codacy code quality checks pass
[ ] 🛠 Documentation builds successfully on readthedocs

New or updated recipe/diagnostic:

[x] 🛠 Provenance information has been added
[x] 🛠 New dependencies are added to the project requirements
[x] 🧪 Documentation for the recipe/diagnostic clearly describes what it calculates from a scientific point of view
[x] 🧪 Recipe runs successfully on @esmvalbot or some other machine without modification
[x] 🧪 Figure(s)/data look as expected
[x] 🧪 Code is well documented and scientifically sound

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

@schlunma: I am giving up on trying to install ESMValCore v2.2 for testing. I'll take a look once ESMValCore v2.2 has been released and I succeed in setting up an environment again.

Absolutely no worries @axel-lauer! I will ping you again when ESMValCore is released and #1874 is merged.

Recipe ran fine, produces the plots from the paper, documentation clear and concise. Provenance runs correctly as well ;)
My only comment would be that

Please note that due to #1903 the recipe needs to be run with the --check-level ignore option.

this should be noted in the documentation or the header of the recipe otherwise the knowledge might get lost down the line before the issue is fixed.

Thanks for the review! :blush:
I added the caveat to the documentation.
About the Codacy issue: my local prospector and isort complain if I change the order of that import, so I guess I just leave it as is :smiley:

@valeriupredoi would you have time for a brief technical review of this? The vast majority of changes are related to documentation (there's no real new diagnostic here), so this should not take long! Thanks :beers:

@valeriupredoi would you have time for a brief technical review of this? The vast majority of changes are related to documentation (there's no real new diagnostic here), so this should not take long! Thanks beers

sure, will look at it in 10min :+1:

@schlunma looks good, I didn't read carefully all that documentation, since I trust all is good from a scientific point (I wouldn't know that stuff anyway). Two questions: did you really want to remove the pointers to the seaborn api documentation and could you pls fix that import complaint from Codacy? :beer:

Thanks for the review!! :+1:

The information in the documentation was duplicate since :func:'seaborn.set' points to the link I removed.
When I change the order my local prospector complains about it and isort automatically changes it back in pre-commit, so not sure what's correct here :smile:


Write metadata

@timadriaens, as we briefly discussed today, could you give a try to write the metadata for the RIPARIAS target list? I put a copy of the gdoc template in RIPARIAS/Action A1/data publicatie/RIPARIAS target list directory on gdrive. This is the link to the metadata gdoc: https://docs.google.com/document/d/1LMJyovw7Dw-snibDycEhRNfChk2R9yjFMoetdEPA2KY/edit#heading=h.m2h9y35m3fn4
Thanks.

more or less done with it

Thanks @timadriaens. I reviewed it. @peterdesmet, can you review further and in case proceed with the publication? Notice the two versions of the logo I added  at the end of the gdoc. These logos are project logos. I think we need to upload the project LIFE RIPARIAS to GBIF first before publishing the checklist?

Document reviewed, actions needed. No worries about the logo, that will be arranged.

Will look like this:

I think a community page is a good idea, even though we'll probably have less datasets/checklists published than for TrIAS for instance, it is good for visibility. Do you need a picture for that page? We could use the drone image they use on many comms materials.

@peterdesmet credits of this photo: ©AdrienLatli, I will upload the pic here

@peterdesmet: I think we are ready to publish this checklist, right? Do we need something more to close this issues? I don't think so.

Yes, the network is not blocking the publication of the checklist. Just good if someone follows up the progress on the network submission to GBIF.

I am following it up. Sent the document to Florence (BE) for a final review. Mail sent with you @peterdesmet in cc as well. I hope review follows fast.

Update: the network page text has been reviewed by BE. So, we can proceed to create the network on GBIF as well.

GBIF seems not intentioned to promote the use of networks for (temporary) projects. Networks should be a collaborations among institutes maintained over a long period of time. As LIFE RIPARIAS has a start and an end date, we should work by ifllling in project details in the metadata of each published dataset.


Performance issue with the heatmap demo

Issue Type
[ ] Performance
Description and/or steps/code to reproduce the problem
More samples > data > heatmap with async loading
once the "heat map" loads, which is just a set of non overlapping polygons with transparency, scroll panning is awful with hardware acceleration is on. With hardware acceleration off, it's smooth.
Environment
If it's a bug, version(s) of android this affects:
testing on android 6
Version of osmdroid the issue relates to:
6.0.0-SNAPSHOT on master

I'll have a look at it.

Here we are talking about hundreds of Polygons being displayed!
I guess that for that demo (with square areas), simple Paths would be faster, because each time we draw a Polygon a lot of computation is involved.
What I can do is try to optimize the LinearRing.buildPathPortion part.
But the HeatMap demo itself could be optimized too.

@spyhunter99 @pasniak Still relevant with the latest merged code?


Building Docker docs fails due to missing extends.md configuration (from compose)

Bulding Docker docs (make docs) fails with the following error:

The page "compose/yml.md" contained a hyperlink to "compose/extends.md" which is not listed in the "pages" configuration.

Since extends.md is new, an entry for it should be added in docs/mkdocs.yml.

Thanks for reporting @draghuram! Looks like this commit added the new document in compose;
https://github.com/docker/compose/commit/f3f7f000fec841a62cc1849462f851230614af85
/ping @moxiegirl @aanand does this have to be done manually in the docs/mkdocs.yml here or is there some script that pulls changes in?

@thaJeztah I'm working this today.  There are a couple of things wrong with the Makefile.

I can build the docs now but can't see the new content from extends.md any where. Is that what is expected? I guess I am not clear how compose's docs are being pulled into docker docs.

@draghuram The extends material was released before it was ready.  You can view that work on:
http://docs.master.dockerproject.com/compose/yml/
Or by pointing the docs/Dockerfile to pull master from the compose docs

Got it, thanks.


Misleading "please retry" message when checks are pending

When a check is still pending, the bot will tell you to try again later:
https://github.com/NixOS/nixpkgs-merge-bot/blob/c0cdb5179162ad5637e6a0ae9e5f4864cb341e9b/nixpkgs_merge_bot/commands/merge.py#L141
but it's stated in the nixpkgs README (see https://github.com/NixOS/nixpkgs/pull/305553) that the bot "patiently waits for ofBorg to finish before attempting the merge again".
If the bot will in fact automatically retry the merge once checks are done, the message should probably say something closer to:

One or more checks are still pending, will automatically retry after they are done (darwin checks are ignored).

At least in theory. I heard in some cases that retry doesn't work.


Consolidate test requirements in file

Test dependency mock was added to requirements.txt instead of being part of the test requirements. I also noticed that some of the test requirements only existed in travis.yml.
This PR creates a new file requirements_test.txt that contains all test requirements. They are referenced from setup.py via an "extras". travis.yml has been updated to install the test dependencies via the extras.

Tests are failing because the Travis variables are not made available to builds by PRs. Couldn't run the tests locally either because I didn't have the required constants. Soooooo… could use some help 😉


Serial and console are missing from kvm xml

Please add
<serial type='pty'>
                <source path='/dev/pts/1'/>
                <target port='0'/>
                <alias name='serial0'/>
            </serial>
            <console type='pty' tty='/dev/pts/1'>
                <source path='/dev/pts/1'/>
                <target type='serial' port='0'/>
                <alias name='serial0'/>
            </console>

in the devices section of the libvirt xml to make virsh console and vnc work properly

Fixed by https://github.com/g8os/core0/commit/b9d1fc79f18c7994c1d3d95a4d3d26e9c01e865b


Place systemd units in /usr/lib/systemd/system

Using /usr/lib/systemd/system allows local sysadmins to overwrite the unit file by placing one of the same name in /etc/systemd/system.
Fixes: #259

Coverage remained the same at 12.799% when pulling b818d744ebd4a5b16ffe073d78f7fc958cde2734 on behrmann:unitseachpath into ef35c563203c809a5c48a2310ca90430c064e7c3 on kardianos:master.

Just noticed, that in the meantime a merge conflict has occurred, so I rebased against current master.

Thanks. Also, this is a fine change, but for some operations, we need to check both the old and new path in sequence to not break existing programs.

Which operations do you have in mind?
When writing a new file to /usr/lib instead of /etc the latter will take precedence and as long as how the service is to be invoked it will keep in working. In most cases the same file will be recreated in /usr/lib. Sure, as long as there is a file in /etc all newly generated files won't take effect, but I don't think that is something this module can do something about, because the only way out is deleting that and that's generally not a good idea, because it could be a user-edited/user-supplied file.
I could imagine writing a warning when a service file is generated, that is shadowed by one in /etc.

Please reference documentation as to the different locations.
For checking existence or for removal, both locations should be checked.
For creating a new service instance, only the new location should be used.

1. Please reference documentation as to the different locations.

Where exactly should I reference documentation?

2. For checking existence or for removal, both locations should be checked.

I'm not sure I agree.
Removing files under /etc is just not a good idea. This module should never touch /etc. Managing files under /etc is the prerogative of the user/sysadmin or at the least the package manger, but daemons shouldn't touch it, since the risk of inadvertently deleting a file the user doesn't want to lose is too high.
Checking for existence of a file under /etc for the installation shouldn't really matter all that much, since it will generally mean that a user supplied their own service file. Supplying a vendor service file in /usr/lib still makes sense, so it might be prudent  to just get rid of the check
    _, err = os.Stat(confPath)
    if err == nil {
        return fmt.Errorf("Init already exists: %s", confPath)
    }

in Install and always clobber the file under /usr/lib.

3. For creating a new service instance, only the new location should be used.

Ok, I think that would be the case of the PR in its current state

Just add a comment near the referenced /usr/lib location.
Well, we are writing and removing now. So we need to continue looking for files there, at least for now, or bump to v2, and I don't think I want to bump to v2. We can add an option to opt out of looking at etc, so a new author can opt to use that.

1. Just add a comment near the referenced /usr/lib location.

Done.

2. Well, we are writing and removing now. So we need to continue looking for files there, at least for now, or bump to v2, and I don't think I want to bump to v2. We can add an option to opt out of looking at etc, so a new author can opt to use that.

That doesn't make it a good idea. Example: A binary I use currently uses this module and places its service file in /etc. The point of this PR is to not have to replace that file all the time anymore. If that binary now started removing that very same file again would make this change a bit pointless. :)
I consider writing to /etc a bug. The proper state of a service file under /etc is unknowable from the state of this module and I think it is definitely better to be safe and not to guess.

Cross-posting discussion in the GitLab issue queue:

https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2422

As a gitlab-runner user this is pretty frustrating - every time they push an upgrade everyone with custom overrides finds their runners break until they fix the unit file. What do we need to do to get this over the line? Can I help? I've never really used Go, but I don't mind having a crack if there's a spec the maintainer would be happy with. :smile:

For anyone who finds this while the PR is in limbo, workarounds are possible - see use of override configs in https://askubuntu.com/a/659268


Add standard Japanese fonts to web app

It would be useful to make these available:

IPAex - the traditional default of TeX engines
HaranoAji - many engines are switching to this as their new default

I added Harano Aji. IPAex is under a custom license, isn't it? Does the license put any limit on redistribution or commercial use of the font?

Looks like you can redistribute and use it commercially, but need to include a copy of the licence somewhere.  The text of the licence can be found in English here.
TBH just including HaranoAji is probably good enough.  As long as some kind of high-quality Japanese font is available.


Bug with adding to arrays on objects

let a = { a: [ 0, 1 ], b: 2 };
a.a[0] += 2
println(a)
will result in
{ a: [ 0, 1 ], b: 2, undefined: false }
instead of
{ a: [ 2, 1 ], b: 2 }
(this is not a bug with +=, as doing a.a[0] = a.a[0] + 2 will result in the same thing)

Doing
let a = { a: [ 0, 1 ], b: 2 };
let c = a.a;
c[0] += 2
works tho. it appears doing object.array[] will be trying to like set "array[]" of "object" instead of modifying "array" of "object"

Doing a.a[0] will result in [0, 1] instead of 0.

Caught the culprit probably.
if (expr.object.kind === 'MemberExpr') return this.lookupOrMutObject(expr.object as MemberExpr, value, expr.property as Identifier);
This here will fully ignore the previous portion.
so
a.b.c will see the object kind is member expr (a.b.) and then it will lookup "b" on "a" and return that, but it fully skips "c"

ok so i fixed a.b.c but i don't know the problem with a.b[c]

fixed that. #55


formatting the test

@irham0019 please send this pull request to 1.9.x branch as master mainly based on APIM 2.0 :+1:


Client progressively dropping

I don't know if this is a real issue or something related to the Pi environment. It has happened to me twice.
Basically, while the server sensors keep working fine, the client ones start missing more and more readings, see attached graph. One reboot didn't fix it (I rebooted where there's a vertical line), while another reboot fixed it (both the server and client were rebooted).
I should mention that while the problem was present, I didn't even get the numeric temperature reading. But the wifi connection to the client was good: ssh sessions were rock solid, and "wavemon" showed a perfectly usable signal level... And reading the sensor data via command line through ssh worked fine.

I see a lot on my setup and had assumed it was flakey network connections from the Pi (I mostly have wireless adapters), so it's interesting to hear your connections seem solid. I always see a numeric connection though. Did you see an error on the page (for the temperatures?).
Did you see a lot of errors in the log like this:
ERROR UnexpectedError(Failed to PUT temperature data to http://<IP_ADDRESS>:11900/temperature, response was 502 Bad Gateway: Right(Error in RRD Bad sample time:<PHONE_NUMBER>. Last update time was<PHONE_NUMBER>, at least one second step is required))

It happens when more than one sample comes in (although in theory, this shouldn't really happen) and RRD's resolution is a minimum of 1 second and thinks they clash. I'm going to change the whole model to prevent this at some point (move to a more staged event driven model).
Short answer is I don't know why it does this. If you do a reboot, I'd reboot them all (or experiment with just the server first) and always have a look in the logs.

Yes, me too, initially thought it was the wifi. Until I realized that I was still doing all my maintenance (and sensor sanity checks) via wifi... :)
The little program "wavemon" is great for checking, live, the wifi status.
I remember seeing the error you mention, in the past. But sadly, I forgot to save the logs before rebooting, and after rebooting, they were wiped. I remember that the server's log didn't have many errors logged, and not at the times where the dropout is. And I totally forgot to check the client's logs...

I have an update... I just had the issue reappear again, and I noticed that every single time that it happened, was when the temperature of a sensor of the client had gone below 1 degree. Is it possible that the system can't cope with temperatures starting with zero (or negative)?

Is it possible that I'm experiencing what I feared could happen, here https://github.com/tobyweston/temperature-machine/issues/9#issuecomment-363933288 ?
If the temp reading outside is, say, 0.5 degrees, and on the next reading it's 0.4, that's 20% less, and it would trigger the spike-rejecting code (I have it set to 10%). Could it be this? The client keeps being "healthy", and the Wi-Fi connection is solid.
If this is the issue, could the spike fix be changed so it reacts not to a percentage difference, but for an absolute difference of X degrees?

Hi Toby, I don't know if you saw the edit to my comment above. I don't think it could recover by itself... Imagine this scenario: the temp goes down, reaches a valid reading of 0.1, then the temp starts rising again. Say the next reading is 0.3, which is discarded because the jump is to high. Then the temp keeps increasing, but every me value is always discarded because they're all much higher than 0.1.
So, either the system changes to abs temperatures (yes, 5 degrees could be a sensible threshold, but I'd like it to be configurable) or three should be a sort of "watchdog" system: I.e. If more than 10 readings are discarded in a row, or can't be 10 spikes, so the reference value is updated with the current reading...
Actually, the best of both worlds world be to switch to configurable abs temperature differences AND add a watchdog... :)

Hmmm, just wrote a test and I think you're right.
Assuming you have 20% as you're limit, it will kick in:
  "Negative spikes values (single sensor), example from production" >> {
    val delegate = new StubWriter
    val writer = new ErrorOnTemperatureSpike(delegate, percentageSpike = 20)
    writer.write(Measurement(Host("example", None), Seconds(1), List(SensorReading("A", Temperature(0.5)))))
    writer.write(Measurement(Host("example", None), Seconds(2), List(SensorReading("A", Temperature(0.5)))))
    writer.write(Measurement(Host("example", None), Seconds(3), List(SensorReading("A", Temperature(0.4))))) must be_-\/.like {
      case e @ _ => println(e.message); ok
    }
    writer.write(Measurement(Host("example", None), Seconds(4), List(SensorReading("A", Temperature(0.4)))))
    delegate.temperatures must_== List(
      Measurement(Host("example", None), Seconds(1), List(SensorReading("A", Temperature(0.5)))),
      Measurement(Host("example", None), Seconds(2), List(SensorReading("A", Temperature(0.5)))),
      Measurement(Host("example", None), Seconds(4), List(SensorReading("A", Temperature(0.4))))
    )
  }

In the log, you should see something like this
An unexpected spike was encountered on:
 sensor(s)             : A
 previous temperatures : 0.5 °C
 spiked temperatures   : 0.4 °C (-20.0)

Yep, it's the last known good value that's used to check for % differences.
If you can decipher it, examples are in the following test.
https://github.com/tobyweston/temperature-machine/blob/master/src/test/scala/bad/robot/temperature/ErrorOnTemperatureSpikeTest.scala
My thinking was that if a % is breached, when the value comes within the normal range again, it'll carry on; when temperatures get back to normal, it should carry on.

I've done some commits for #9 to switch to absolute values rather than %. I haven't deployed it to my setup yet but if you want to test the bleeding edge, go ahead! I'll close this ticket pending your feedback.

Thank you Toby... Compiling now. I'll let you know how it behaves.
Cristian

Toby, I've let it run the whole night. There are a few issues. First, at every reboot, I get a huge spike (hundreds of degrees) so the graphs are unreadable.
The spike removal fix is installed, as reported by the log, and set to 10 degrees.
On the charts, I can only see the temperatures from the server and not the client. Even on the live graph, only the server's sensors are listed. But the numeric readings are present and correct for both server and client sensors.
The server's log:
Thu 15-Feb-201802:27:18.142[main]INFOStarting temperature-machine (server mode)...
Thu 15-Feb-201802:27:18.307[main]INFORRD initialising for 'PiZero', 'PiOld' (with up to 5 sensors each)...
Thu 15-Feb-201802:27:18.383[main]INFOOk
Thu 15-Feb-201802:27:18.406[main]INFOStarting Discovery Server, listening for 'PiZero', 'PiOld'...
Thu 15-Feb-201802:27:18.544[temperature-machine-discovery-server-1]INFOListening for broadcast messages...
Thu 15-Feb-201802:27:21.225[temperature-machine-discovery-server-1]INFOListening for broadcast messages...
Thu 15-Feb-201802:27:21.232[temperature-machine-discovery-server-1]INFOListening for broadcast messages...
Thu 15-Feb-201802:27:42.204[main]INFOMonitoring sensor file(s) on 'PiZero'
/sys/bus/w1/devices/28-041500a0f0ff/w1_slave
/sys/bus/w1/devices/28-031500e9feff/w1_slave
Thu 15-Feb-201802:27:44.015[main]INFOTemperature spikes greater than +/-10 °C will not be recorded
Thu 15-Feb-201802:27:50.302[main]INFOHTTP Server started on http://<IP_ADDRESS>:11900
Thu 15-Feb-201804:07:14.384[temperature-reading-thread-1]ERRORUnexpectedError(Failed to PUT temperature data to http://<IP_ADDRESS>:11900/temperature, response was 502 Bad Gateway: Right(Error in RRD Bad sample time:<PHONE_NUMBER>. Last update time was<PHONE_NUMBER>, at least one second step is required))
Thu 15-Feb-201804:07:14.384[temperature-reading-thread-1]ERRORUnexpectedError(Failed to PUT temperature data to http://<IP_ADDRESS>:11900/temperature, response was 502 Bad Gateway: Right(Error in RRD Bad sample time:<PHONE_NUMBER>. Last update time was<PHONE_NUMBER>, at least one second step is required))
The client's log:
Thu 15-Feb-201802:27:31.251[main]INFOInitialising client 'PiOld' (with 2 of a maximum of 5 sensors)...
Thu 15-Feb-201802:27:32.254[main]INFOSending ping request to /<IP_ADDRESS>
Thu 15-Feb-201802:27:32.264[main]INFOSending ping request to /<IP_ADDRESS>
Thu 15-Feb-201802:27:32.268[main]INFOAwaiting discovery server...
Thu 15-Feb-201802:27:32.867[main]INFOServer discovered on <IP_ADDRESS>, monitoring temperatures...
Thu 15-Feb-201802:27:48.699[main]INFOMonitoring sensor file(s) on 'PiOld'
/sys/bus/w1/devices/28-051690939aff/w1_slave
/sys/bus/w1/devices/28-0315009723ff/w1_slave
Thu 15-Feb-201802:27:52.498[main]INFOHTTP Server started to serve logs on http://<IP_ADDRESS>:11900
Thu 15-Feb-201802:28:15.654[temperature-reading-thread-1]ERRORUnexpectedError(Failed attempting to connect to /<IP_ADDRESS> to send Measurement(Host(PiOld,Some(+01:00)),1518658078 seconds,List(SensorReading(28-051690939aff,Temperature(1.5625)), SensorReading(28-0315009723ff,Temperature(25.1875))))
Error was: java.util.concurrent.TimeoutException: Client response header timeout after 8609 milliseconds.)
Thu 15-Feb-201802:28:15.654[temperature-reading-thread-1]ERRORUnexpectedError(Failed attempting to connect to /<IP_ADDRESS> to send Measurement(Host(PiOld,Some(+01:00)),1518658078 seconds,List(SensorReading(28-051690939aff,Temperature(1.5625)), SensorReading(28-0315009723ff,Temperature(25.1875))))
Error was: java.util.concurrent.TimeoutException: Client response header timeout after 8609 milliseconds.)

It's weird, something is plotted from 4 sensors, but only two are shown in the list on the bottom:

Toby, something very strange is happening with the latest build.
I have a server and a client, with two sensors each.
Basically, as shown on the screenshots above, only two sensors are plotted and listed at the bottom; they're listed as "PiZero" sensors, which is the server.
But - here's the weird thing - their plotted values are NOT their actual value. What is plotted, is actually an average between one of the server's sensors, and one of the client's sensors. So, one of the two graph lines shows "(Client_A + Server_A)/2" and the other shows "(Client_B + Server_B)/2".
The lines are also much more "noisy" and with many spikes, which are not caught by the fix code.
The numeric readings of the sensors are fine (I can see all four of the sensors, and the values are correct).
I'm wondering: does the last fix break the RRD compatibility? Should I have erased it?
Starman
See the inconsistencies on the top part of the screenshot attached. Also see that on the graphs on the bottom, there's a "discontinuity" where I updated the software; and even the old readings from the other two sensors, have disappeared from the weekly and monthly charts...

Bit of an odd one but I think adding timezone to the Host class broke the RRD writing. Will post a fix asap.

This should be fixed now. If you can confirm, I'll close the issue.

Ok, the graph is back with all four sensors now. But the spikes are back (even though the fix is activated, according to the log). There is no mention of removed spikes in the log, and the temperature change during the spike is greater than the set threshold.
Concerning the original issue, I couldn't test it yet, because the temperatures haven't gone so low yet, and the sensor itself is semi-permanently mounted in a non-easily-reachable place (bad idea, I know, but that's the best I could do). If the outside temperature stays high, I'll try experimenting with ice water with one of the indoor sensors... :)

K, gonna close for now 👍
NB. The avoid spikes fix has been temp disabled (but we didn't think it worked well anyway).


Output of metric() method

Description
Currently the metric() method of MahalanobisMixin returns the PSD matrix self.transformer_.T.dot(self.transformer_).
I am not sure when this is really useful in practice?Shouldn't we rather return the metric function itself as a callable, or better a DistanceMetric that can be plugged easily into some sklearn estimators? This seems more useful.
Defined this way, metric() could be an abstract method of BaseMetricLearner (since every metric learner should be based on some kind of metric).

I'd prefer to keep some way of accessing the "metric" matrix as currently implemented for maximum flexibility, but I do agree we could expose a more friendly API across all learner classes.

I agree it would be very convenient to have an object that can directly be used as a metric.
Regarding on whether returning a callable or a DistanceMetric, I am not sure whether DistanceMetric is supposed to be used by a user. I mean yes they provide a way to build a custom DistanceMetric using DistanceMetric.get_metric("pyfunc", func=myfunction), and this allows to call the pairwise routine. But trying to use it with KNeighborsClassifier, it does not work with a DistanceMetric but it works with a callable:
from sklearn.neighbors import KNeighborsClassifier, DistanceMetric
from sklearn.datasets import load_iris
from sklearn.model_selection import cross_val_score
def euc(arr1, arr2):
    return np.sqrt(np.sum((arr1 - arr2)**2))
d_euc = DistanceMetric.get_metric('pyfunc', func=euc)
X, y = load_iris(return_X_y=True)
clf = KNeighborsClassifier(metric=d_euc)  # works if I replace with euc
cross_val_score(clf, X, y)
# returns an error

Also, there's a thing: scikit-learn, when using a custom distance function say in KNN, needs a function that takes as input two 1D arrays (just two vectors) and returns a scalar. Then this function is called in a loop inside the algorithm on all pairs needed. Knowing that we have a distance parameterized by a matrix, we could probably do faster vectorizing the operations. But I don't know how to integrate it with scikit-learn then...
I'll look into scikit-learn issues to see whether this is a subject that is tackled already

I agree it would be very convenient to have an object that can directly be used as a metric.
Regarding on whether returning a callable or a DistanceMetric, I am not sure whether DistanceMetric is supposed to be used by a user. I mean yes they provide a way to build a custom DistanceMetric using DistanceMetric.get_metric("pyfunc", func=myfunction), and this allows to call the pairwise routine. But trying to use it with KNeighborsClassifier, it does not work with a DistanceMetric but it works with a callable (and by the way the stack trace if you give a bad metric like print('test'), shows that KNeighborsClassifier calls in fact DistanceMetric):
from sklearn.neighbors import KNeighborsClassifier, DistanceMetric
from sklearn.datasets import load_iris
from sklearn.model_selection import cross_val_score
def euc(arr1, arr2):
    return np.sqrt(np.sum((arr1 - arr2)**2))
d_euc = DistanceMetric.get_metric('pyfunc', func=euc)
X, y = load_iris(return_X_y=True)
clf = KNeighborsClassifier(metric=d_euc)  # works if I replace with euc
cross_val_score(clf, X, y)
# returns an error

Strange, because even KNeighborsClassifier(metric=DistanceMetric.get_metric('euclidean')) returns an error...
Note that DistanceMetric already has Mahalanobis distance where one can simply pass the matrix parameter so in principle it would be easy to construct. But returning a simple scalar function is fine as well.

Strange, because even KNeighborsClassifier(metric=DistanceMetric.get_metric('euclidean')) returns an error...
Note that DistanceMetric already has Mahalanobis distance where one can simply pass the matrix parameter so in principle it would be easy to construct. But returning a simple scalar function is fine as well.

Ah yes I didn't see the MahalanobisDistance, it's cool then they already have it implemented in cython !
Looking at this issue: https://github.com/scikit-learn/scikit-learn/issues/11807, I understood a new way to use custom DistanceMetric:
clf = KNeighborsClassifier(metric='pyfunc', metric_params={'func': euc})

(but it is probably not so useful here since clf = KNeighborsClassifier(metric=euc) is a shortcut for that)
or for MahalanobisMixin:
clf = KNeighborsClassifier(metric='mahalanobis', metric_params={'VI': mymatrix})

But then here we only use the raw matrix...
So for now, to have a coherent returned object from all the metric learners even those that wouldn't be MahalanobisMixin, I guess metric should return a callable ? But it is annoying not to be able to put a DistanceMetric because it would have allowed us to just return DistanceMetric.get_metric('mahalanobis', VI=mymatrix) and have a cython function out of the box. Maybe at one point we'll have our own callables returned by some function metric(), in cython, but I guess for now we'll just return a regular python callable ?

Also, there's a thing: scikit-learn, when using a custom distance function say in KNN, needs a function that takes as input two 1D arrays (just two vectors) and returns a scalar. Then this function is called in a loop (in Cython) inside the algorithm on all pairs needed. Knowing that we have a distance parameterized by a matrix, we could probably do faster vectorizing the operations. But I don't know how to integrate it with scikit-learn then...
I'll look into scikit-learn issues to see whether this is a subject that is tackled already

We should think of this ability to get the metric function as a convenience - it is okay if it is not necessarily the most efficient way of doing things in all situations. (In many cases, I guess the fastest way is probably to first transform the data and then use Euclidean distance.)

Yes I guess you're right. And if users really want performance they can always precompute distances in a vectorized fashion, and use the option 'precomputed' of scikit-learn estimators

Maybe at one point we'll have our own callables returned by some function metric(), in cython, but I guess for now we'll just return a regular python callable ?

Yes, I think this is good enough for now


RegExp should call property "lastIndex" using Symbol.search

Hi everyone,
there is an inconsistence on Chakra when I call this Proxy using Symbol.search.
The -ES6Experimental flag is activated.
Chakra: ch version <IP_ADDRESS>-beta
OS: Ubuntu 16.04 x64
Steps to reproduce:
function test() {
   var get = [];
   var p = new Proxy(
       { exec: function () { return null; } },
       { get: function (o,k) { get.push(k); return o[k]; }}
   );
   RegExp.prototype[Symbol.search].call(p);
   return get + "" ===
       "lastIndex,exec,lastIndex";
}
if (!test())
   throw new Error("Test failed");

Actual results:
Error: Test failed
Expected results:
Pass without failures
It was observed that the array get contains only "lastIndex,exec". The others engines (V8, SpiderMonkey and JavascriptCore) works as expected (lastIndex,exec,lastIndex).
cinfuzz

@tcare does/should -ES6Experimental include -ES6RegExSymbols ?
In any case ch -ES6Experimental -ES6RegExSymbols test.js still fails.

@dilijev at some point this corresponded with Edge feature staging in the settings dialog, but I don't think this is the case now. I'm not 100% sure though. I don't think any unit tests should be using -ES6Experimental...

Consolidating as part of #6390


Plz find errors in my code

function titleCase(str) {
var temp;
temp=str.split(' ');
for(var i=0 ; i<temp.length ; i++)
{
temp[i][0].toUpperCase();
}
return temp.join(' ');
}
titleCase("I'm a little tea pot");
I don't know why this return value doesn't change to "I'm A Little Tea Pot".

Challenge Name
Title Case a Sentence
Issue Description

Browser Information

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code

Screenshot

@ligun89 thanks for the issue but if you get stuck or have questions with a challenge in the future, please first ask questions to the Help Room. Happy coding!


(PUP-11846) Handle Deferred(Sensitive) file content

If file content is assigned a Sensitive value, then normally the content and ensure properties are marked as sensitive early on when the Puppet::Type::File instance is created[1].
The same is true if a sensitive value is wrapped in deferred and deferred functions are preprocessed, since that happens before the Puppet::Type::File instance is created.
However, if a sensitive value is wrapped in deferred and deferred functions are not preprocessed, instead evaluated lazily as each resource is evaluated, then the munge method may receive a PSensitiveType::Sensitive value. So we must unwrap the file content to compute the should/desired checksum and we must mark the content property as sensitive so that the output is redacted:
Notice: /Stage[main]/Main/File[/tmp/test.txt]/content: changed [redacted] to [redacted]

Also puppet handles created vs modified files differently. In the latter case, only the ensure property is managed[2], so we have to mark that as sensitive too, resulting in:
Notice: /Stage[main]/Main/File[/tmp/test.txt]/ensure: changed [redacted] to [redacted]

[1] https://github.com/puppetlabs/puppet/blob/fde57136980d63bd2a64532ad74f750cc3b73bc7/lib/puppet/type/file.rb#L977-L982
[2] https://github.com/puppetlabs/puppet/blob/fde57136980d63bd2a64532ad74f750cc3b73bc7/lib/puppet/transaction/resource_harness.rb#L81-L92

I think the approach in #9064 is better because it preserves the original behavior of how resource parameter values are passed to types, closing this.


fix hadoop dependency with rubix-presto

This fixes Rubix master UT.

Spoke offline. Dependency with other modules is not the beat way to do this. Not yet sure why UT is failing with H2.6 dependency where the yarn method exists.

It should be fixed now. Will merge after approval.

Did we test this in presto cluster ? If everything is fine, @pvam can we update this with the result. Then I can approve this .. Also get a approval from @stagraqubole as its Presto related. Lets get this done so that we can go ahead with the new release of Rubix

Opened #73, closing this. With #73, we dont dependency on yarn anymore we assume the property is populated via rubix client config.


Support function and class types for view

There shouldn't be any obligation for the view to be an object. Let it be a class or function as well. This may complicate the call since view and generalValueFn are both optional.

View can be an object that is instantiated from a class (not the class itself).
It can't be a function because since the view is optional, there is no way to say if it is actually the generalValueFn function when view is omitted.


VM is dead on full refresh (beta.near.org)

When using the bos-loader, on a full page reload I get some VM is dead errors for certain components for a brief moment. The first time I launched it (before being logged in, but after setting the flags for the bos-loader) all components showed this behavior.
https://github.com/near/near-discovery/assets/36507050/c3e372c0-6b0e-432a-98db-066fb5db6dd5

This occurs on beta.near.org


👨 Create new user endpoint: POST

Have a /v1/account endpoint that will create a new user with a JSON request body:
{
  "first_name": "sid",
  "last_name": "rawat",
  "username"<EMAIL_ADDRESS>  "password": "test1234",
}

NOTE: Have basic validations in place and proper HTTP response codes and messages in case of errors.

Include cors middleware


[ADD ME TO THE ORGANIZATION]

Name:
Sundram Awasthi
Location:
Lucknow ,India
Interest:
DevOPS , open source contribuation
Discord username(optional):-
Why do you want to join?

I want to join because
I want to join this commnuity because i want to contribuate and help to grow commnuity

You can also join our Discord community here
Feel free to check out other cool repositories of the Open Source Community here.

Welcome to the community!!! Thanks for creating this issue. Invitation has been sent to you. Accept it and make your membership public.


CORE: User Pages

These are roughed in. Currently have a placeholder for the Follow button.

Actually, lets call this done. Will open new issues for features.


Add end line and end col information to issues

Right now we're reporting issues only with line and col. To improve integration with tools like LSP we need also to report end line and col (some rules can report range where the problem appears).

Keyword naming rules needs this update - for example wrong case in keyword name is reported on first column of the line only.


Data Caching

I couldn't find an easy way to cache the data received from this API, so I've made (is still making) a wrapper that wraps this API.
Cached data, even when the data is from the STATIC V3 API, can be accessed repeatedly (thousands of times per second) without slowdowns. And it will be possible to implement native functions (such as searching and sorting) within the Wrapper without relying on the speed of Riot's GET Api.
https://github.com/bloc97/riot-api-java-cached/
It is still WIP but almost all the functions are available for caching.
Only the tournament methods are not cached.
Maybe someday it would be possible to merge the two projects?

We had the topic of caching come up a few times already, but maybe you can add something new to the discussion.
If we wanted to cache API calls, there are alot of open questions. Probably the biggest of all would be:
Where to cache data?
You could cache data in memory, but that would quickly become an enormous memory eater. Just take the matches endpoint for example, I just picked a random match from the Api and get a result that is 32261 characters in size, which approximately equals ~32 KB, assuming you cache the json String. If you were to cache the actual DTOs, it would probably be much bigger. It's not unusual that projects request hundreds of thousands or even millions of matches to calculate averages for certain things -- that would quickly sum up many GB of cache and end up in a java.lang.OutOfMemoryError and crash the application on many low-tier servers. Of course you could provide options to limit the cache size or allow uncached calls to go around this.
Alternatively you could store the cache on disk, maybe create a "cache" folder and store files there for each cached call. The big advantage is that your memory keeps clean and your cache survives a restart of the application. The downsides are that this would slow down the server, if it has to open and close files constantly. Also depending on your system, you might eventually run into "Too many open files" errors.
You could also cache your calls in third party databases or third party caching tools like memcached -- and if your project gets too big to run on a single dedicated server you eventually have to use a dedicated caching option, since local caching kinda gets pointless when running multiple instances. Each option has their advantages and disadvantages -- so what would we choose to provide with this api wrapper? Basically there is no general right or wrong, it simply depends on the specific use case of the developers using this api wrapper.
I personally belong to the latter category -- I have projects too big to be run on a single dedicated server, so a local cache is not really going to help my use case. Instead I use a memcached server for short-term caching and a few mariadb database servers for long-term caching.
There are many projects dedicated to caching data for tons of different use cases. I think every developer should decide on their own what caching method suits their needs. I personally don't believe there is the one caching method that's right for everyone, so I think it would be wrong to force one caching method upon everyone using this api wrapper.
What are your thoughts on this?

Well at first this is just a simple caching method for those small users who frequently access the same data, and it makes the code much cleaner. Instead of storing all the objects you need after calling once the Riot API, you just repeatedly call getSummonerByName for example. Then in your code there would be much less variables. Also, since my project is currently just a naive way to cache data, I can't really talk about memory efficiency. I could easily add in a cache size limit, since we know the average size of all the DTOs, and I just have to limit the map sizes for each DTO type.
I'm more for offering easier options for developers than forcing them to use something. People can use both cached and uncached methods.

After considering extreme use scenarios, I think a hybrid method would be best (storing common data in memory and all the rest on disk), but then, as you stated, there are Database libraries that already do this.
I don't think there is a need to overcomplicate things. Most people just need a simple API, that does things in a simple way (so it doesn't always break), just like what this api provides. riot-api-java is a very lightweight wrapper, and that is what I want to respect too with riot-api-java-cached. Keeping things simple is usually the best way to go.

For now, I will add a "purge" method in my API, so people can use a timer or purge the cache by themselves, then I will figure out an automatic way of clearing the cache or keeping the cache small.

I would suggest the library define an interface for caching and with one
(or maybe a couple) implementations, and then let others come up with other
implementations.  Memory, disk, memcache, redis, JDBC, so many ways people
might want to store and expire the content.
On Wed, May 10, 2017 at 10:11 AM, bloc97<EMAIL_ADDRESS>wrote:

After considering extreme use scenarios, I think a hybrid method would be
best (storing common data in memory and all the rest on disk), but then, as
you stated, there are Database libraries that already do this.
I don't think there is a need to overcomplicate things. Most people just
need a simple API, that does things in a simple way (so it doesn't always
break), just like what this api provides. riot-api-java is a very
lightweight wrapper, and that is what I want to respect too with
riot-api-java-cached. Keeping things simple is usually the best way to go.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/taycaldwell/riot-api-java/issues/98#issuecomment-300494151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArHBiRWSFIvW2uyrLZVOMXff7zRbU48ks5r4cV3gaJpZM4NVzwk
.

--
Serge Knystautas
PrestoSports Bringing Sports Information Online
<EMAIL_ADDRESS>301-789-1807 http://www.prestosports.com


PIL Bug - identifiers in match patterns

When running this file:
use std::debug::println;

machine Main {

    let foo: int = 4;

    let three: int = 3;
    let four: int = 4;

    match foo {
        3 => println("3"),
        4 => println("4"),
    };
    match foo {
        three => println("3"),
        four => println("4"),
    };
}

This prints:
4
3

The first print is correct, the second should also be 4.

The compiler should issue a shadowing error because match introduces new variables three and four that have already been defined.


update node graphs to angular-nvd3

Current coverage is 20.85% (diff: 0.00%)

Merging #359 into master will decrease coverage by 0.11%

@@             master       #359   diff @@
==========================================
  Files            20         20
  Lines          1612       1621     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            338        338
- Misses         1274       1283     +9
  Partials          0          0

Powered by Codecov. Last update b8bcc8c...92a98f3


Travis: add Django 1.10

Oh, duplicate - sorry: https://github.com/djangonauts/django-rest-framework-gis/pull/118.
Will close it when the build finished.


Add issue templates

This PR is part of https://github.com/conda-incubator/conda-store-ui/issues/254
This PR,

[x] Adds an issue template for bug reports
[x] Adds an issue template for feature requests
[x] Adds an issue template for general issues
[x] Adds a pull request template

This PR needs an approval for merging! I already copied all the changes from the conda-store PR


Fix inlay diagnostics for gopls

Also adds a panic hook, since the integer overflow crashed the process without any information in the log.

Hm, I marked it as a draft because it had an issue with diagnostics that contain ', but I'm not sure how to fix this and it doesn't seem related, so opening it back up.

Actually this does seem to make it buggier than it used to be, and I'm not exactly sure why.


@types are not updated

Your example says:

import BraftEditor, { EditorState } from 'braft-editor';

but TypeScript is complaining:

has no exported member 'EditorState'.`

And there is no updated types for new version 2.0.5

typescript :  import * as BraftEditor from 'braft-editor'

It does not help because:

TS2339: Property 'EditorState' does not exist on type 'typeof BraftEditor'

so because of that, this is not working:

BraftEditor.EditorState.createFrom(htmlContent)

I don't know much about TypeSrcipt, I haven't used it basically, the old version of @types/braft-editor file is done by one of my friends(@petitspois ), the new version of Braft Editor is not compatible with it, so if you use the new version, please do not install @types/braft-editor.
I will also get to know TypeScript as soon as possible and provide a usable @types/braft-editor as fast as I can.


feat: iroh node connections command to list connection info for all known nodes

Description
Display connection information for all nodes we have connected with or have supplied our node with addresses for.
Notes & open questions
Does anyone have examples of CLI output they think is nice for this kind of information? If we decide to keep this, I'd like it to look nicer 🤣
Can extend this functionality to the console.

depends on #1375
Change checklist

[ ] Self-review.
[ ] Documentation updates if relevant.
[ ] Tests if relevant.

ZOMG I WANT THIS.
Howeve, given that you had to censor the screenshot, I'd say right off the bat we should go with listing by NodeID, and omitting IP addresses. wdyt?

ZOMG I WANT THIS.
Howeve, given that you had to censor the screenshot, I'd say right off the bat we should go with listing by NodeID, and omitting IP addresses. wdyt?

What do you think is the "right" language when we don't have any latency info?

Can we use short NodeIDs, like we do for doc & author ids in the console? We could also do this in a follow-up.

What do you think is the "right" language when we don't have any latency info?

with a latency of Unknown, using "unknown" is the right thing to do here imho

@b5

Connections:
	hpf6qa4h…
	derp region: 1
	direct connection
	5175250ns latency

	nzx6mxi6…
	derp region: 1
	relay connection
	unknown latency

	xce2h4zq…
	derp region: 1
	relay connection
	unknown latency

	xuko33wo…
	derp region: 1
	direct connection
	3489375ns latency

If you write out one example of how you think it should look, I'll just do it, because it doesn't look right yet but i don't know how to adjust it.

Connections:
	xuko33wo…
	derp region: 1
	connection type: direct
	latency: 3489375ns

?

zomg you fast. the problem is you're not doing one entry per line. aim for a table layout:
nodeId    derp region    conn type    latency
xuko33wo…  1             direct       56.5678ms

Huge win here is each row will be a constant-ish length except for the last value (latency), which makes the formatting much easier, just use \t characters between values.
latency should be displayed in ms not ns.

will look at other ways to display latency tomorrow!

https://github.com/manlge/human-time makes nicer timestamps

https://github.com/Nukesor/comfy-table can render easy very nice tables :)

Can extend this functionality to the console.

lets add this to the repl for sure

We should add this to the client api as well, this will be very useful from the API

iroh node connections
CLI

Console

Adjusted the node id field to show the full ID, otherwise you wouldn't be able to fetch any individual node connection information with iroh node connection NODE_ID
iroh node connection NODE_ID
CLI

Console


Fix frontend and backend issues for manage flat feature

Description

Updated backend user.controller.ts, now can accept incomplete (with not all fields filled) PUT requests for updating user details. The compulsory field would still be firebaseId, all other fields are not compulsory.
Manage flat page now reloads on save
Manage flat page now disallows the owner from being removed from the flat.

Fixes/resolves # (issue)
Screenshots
Please include any screenshots or media that illustrates the changes made
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which improves existing functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:
Leave blank if not applicable
I have completed these steps when making this pull request:

[ ] I have assigned my name to the issue
[ ] I have moved the issue to the In Progress column
[ ] I have labelled the PR appropriately
[ ] I have assigned myself to the PR

Before opening the PR for review:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have added attributions to new dependencies and resources
[ ] I have moved the linked issue to the Review in Progress column

Good to see the owner check for occupant deletion!


merge package from arlac77/npm-package-template

.travis.yml

chore(travis): merge from template .travis.yml

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #418   +/-   ##
======================================
  Coverage    75.8%   75.8%
======================================
  Files           5       5
  Lines         434     434
======================================
  Hits          329     329
  Misses        105     105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b905137...64ee820. Read the comment docs.

Coverage remained the same at 77.075% when pulling 64ee8201e3485cf5cf8d32e34011b2bfe2467880 on template-sync-1 into b905137e5a81e604303332902ccbf42ad75e7302 on master.


adding maps to a new or existing mosaic when importing should be the default option

within imports, currently the checkbox is unchecked.

This should now be fixed within the codebase