iOS build fails post linking

I followed the documentation to add sentry to our project. Everything worked fine till linking. Post linking, when all the data regarding token, DSN and slug related info was captured, the iOS build started failing with the following issues:

The logs clearly states that RNSentry has issues in imports. I'd like to state that the import for RNSentry in AppDelegate was not added by the linking and had to be added manually.
Upon further investigation, it seems that xcode is trying to import React related files from two different locations:

from node modules (expected)

build directory from the iOS project (unexpected)

I've tried to tweak the header search paths for both our project as well as RNSentry, but to no avail. Any help or suggestion is appreciated!

Facing the same error. Redefinition of 'RCTRootViewSizeFlexiblity'
RN 0.44.0
Although in my case, checking the file of previous definition and redefinition both shows the same file(checked this by seeing the Previous definition was here file, which is same as the file in which the build error is reported).
@HazAT any ideas?

Update.
FWIW, after removing the import for <React/RCTRootView.h> and consecutive method + (void)installWithRootView:(RCTRootView *)rootView;, I was able to build successfully.

I will check that today and keep you posted.

@HazAT I tried to do a dry run with aforementioned hack, but the upload scripts doesn't seem to work. I can't see artifacts being uploaded to the Sentry console, and the crashes mention that Sentry cannot find dsym as well as jsbundle. I tried uploading both manually, after which Sentry stopped complaining about dsym, but the missing jsbundle issue still persists. So here are my questions:

Auto-upload not working while building from xcode - This issue seems unrelated from the hack. Could you point out if I've missed something while setting up, leading to this issue.
Sentry unable to resolve the path of jsbundle - Can this be anyway related to the hack or because of improper setup and hence related to the first question?

@samratshekhar Your two questions are related since your link step didn't go through, you have to change the react-native run script.
https://docs.sentry.io/clients/react-native/manual-setup/#build-steps
This should then upload the sourcemaps correctly and resolve your issue.

@HazAT sorry for the miscommunication. react-native link was successful, but the consecutive xcode build was not. Hence I had to remove the imports from RNSentry project and change the methods it exposes to build it successfully in xcode. Here are the results of linking, which looks alright:

The problem is even with these commands in place, there are no uploads initiated by xcode build.

Build is also failing for me, but a different error, it complains about env: node: No such file or directory. Was able to run npm install and react-native link without issues. Fails when building to the iOS simulator.
RN: 0.45.1
Node: 7.10.0
Thanks!

@feiyingx Can you check if this is in you PATH?
PATH=$PATH:/usr/local/bin
It seems like Xcode isn't able to call node.
In the run script phase you can change the location of node if necessary
export NODE_BINARY=node

@HazAT any update on the core issue of error with imports?

I am not able to reproduce this,
I've just tried it with a clean project:
react-native init AwesomeProject
cd AwesomeProject
yarn add react-native-sentry
react-native link react-native-sentry
react-native run-ios

Works!
Only thing that is different is your import
#if __has_include(<React/RNSentry.h>)
#import <React/RNSentry.h> // This is used for versions of react >= 0.40
#else
#import "RNSentry.h" // This is used for versions of react < 0.40
#endif

I will close this issue for now, it must be related to either not calling react-native link react-native-sentry or calling it too often.

Having exactly the same issue. Any updates?

Please make sure to make a clean build, also clear derived data.
And call react-native unlink react-native-sentry and then react-native link react-native-sentry

It's weird, but after couple links and unlinks (yes, unlink was the last one) it started to work...

We will look into this, since this should not happen no matter what.

Same issue like @feiyingx
Node: 6.10.3 (with nvm)
react-native-sentry: "^0.29.0"
I was able to fix it with:
ln -s /Users/{user}/.nvm/versions/node/v6.10.3/bin/node /usr/local/bin/node
Changing export NODE_BINARY={path to node} didn't work for me, I wondering if somewhere is /usr/local/bin hardcoded

The link worked:
ln -s $HOME/.nvm/versions/node/<node_version>/bin/node /usr/local/bin/node
But it takes a lot of time to finish the custom shell scripts


Additional border on Android device

I'm facing a problem with an Android device (Samsung Galaxy A10 - Android 11), where a strange border is added to the VideoPlayer...
To reproduce, just add a Padding to the example project...

While is loading, this not happens...

This border not appears on iOS (iPhone 7):

@newtaDev can you help me with this issue?
I was debugging but couldn't find what's happening...

I don't know why, but it doesn't happening anymore 🤷🏻♂, so I'll close this issue

While testing this issue, I was unable to reproduce it.
I'm not sure why it happened.
Thanks for closing ✌


Keep track of the checks changed at every Datadog Agent release

What does this PR do?
Adds the release agent_changelog command to ddev to provide a list of the changes for every Agent release in the form of a changelog file.
Motivation
The Agent changelog points to an invalid list of changed checks, from now on it can point directly the AGENT_CHANGELOG.md file from the root of this repo.
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Generating the changelog is still a manual procedure!

Failed on flake8?

Codecov Report

Merging #2277 into master will decrease coverage by 10.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2277       +/-   ##
===========================================
- Coverage   85.66%   74.84%   -10.82%
===========================================
  Files         188       17      -171
  Lines       13254      493    -12761
  Branches     1435       57     -1378
===========================================
- Hits        11354      369    -10985
+ Misses       1493      105     -1388
+ Partials      407       19      -388


Internationalization feature request

Feature request - internationalization for collection items.
As done in other headless cms (one starting with letter s).
Also to be available via API in a handy way.
Hope this will be implemented so that we could switch to PocketBase.
Thanks.

Hi, unfortunately, at least for v1.0.0, I don't plan to work on built-in internationalization support.
There are several existing workarounds for this, you could check - https://github.com/pocketbase/pocketbase/discussions/154
Although it could be used as a very basic headless CMS, PocketBase wasn't really intended to be a replacement for Strapi, Directus or any other more focused solution.
The Admin UI is primarily a developer dashboard (similar to Firebase console) since we don't support permissions on admin account level (the api rules affect only the users; all admins acts as "super admin" and have access to everything).

@ganigeorgiev Thanks for the explanation :)


feat: Add security hardening options.

Add the ability to enable the most common hardening options.

Thanks very much! This is a great feature to have.


Phishing issue related to Augur?

I've got a message from a bot in Slack Augur (REP) channel. Saying they have to "update" the smart contract. They send a link to https://myetherwallet.xyz/fix-wallet.php.
This seems pretty much like a scam to me but I wanted to share it with you. I know Github is for development but I didn't know where to send this.

One of the reasons that I mentioned this here, is that you have a big warning in red, on the website that "our domain" is .com. (which is good)
The problem is the link text here, is showing .com too. So it can quickly "disable" people's attention. Especially if the navigation bar is hidden for your browser.

Just scroll down https://twitter.com/myetherwallet to see the shitstorm.

I see.
I was wondering if on MyEtherWallet.com, the "best practices" / "must read" link should be closer to the interface CTA.
For example:

Good call. Will try to do at soem point soon.
We also have chrome extension now  Please install https://chrome.google.com/webstore/detail/etheraddresslookup/pdknmigbbbhmllnmgdfalmedcmcefdfn

Yeah this is tough.  At what point to you stop making big bold red text across your app?  I am a firm believer in tough love.  I think MEW does a fantastic job compared to most for warning its users, yet you still have people that fall for this crap.  At some point users are just going to have to accept responsibility for their actions.   I do think making it even more blatant on the first screen of MEW would help a bit more, but I feel like the only way to make it super obvious is to go the geocities route and cover the page in flashing gif animations or :parrots:, etc.
@AoDev are you part of the Augur team?  If not, can you put me in touch with someone who is?  I just dealt with this same sort of slackbot attack with the GAME/MGO slack server and want to compare notes.  Seeing this happening on quite a few slacks now and want to try and pinpoint the cause.  Im not sure if it was an API key that was compromised or an exploit in one of the slack apps.  I would really like to figure out how this is happening exactly and formulate a fix.  This is costing noobs quite a bit of money it seems.
Cheers

Here are things we've learned
Hi Jack,

I completely understand your frustration here, and I can assure you that the team is taking this very seriously and actively investigating. I do not have a timeline I can share, however I have added you to the bug report we have for this and we will be sure to let you know once we have made any changes.

Right now, I'm afraid that restricting webhooks that pop up and deleting reminders is our best workaround, as well as letting your team know to avoid clicking on any links they do not recognize.

Thanks, and I am sorry I could not give you a better answer for this,

Simone

Hi Kevin,

Thanks for getting in touch and flagging this with us, I'm sorry for the hassle here.

To remove the reminder(s) from a public channel, enter /remind list which returns the list view of all the current reminders scheduled for said channel and the option to delete them. I'd suggest asking your Team Owner or Admin to enable the Admin Approved Apps feature which enables you to create a list of approved or restricted apps for their team.

At this time we don't have any other suggestions to prevent /remind abuse for communities, however, I'll let you know if we have any additional information.

I'm sorry I wasn't able to help further at this time, please let me know if you have any other questions.

Aubrey (Slack)
Jul 6, 1:14 PM PDT

Hi C,

Thanks for letting me know. An owner on the team can prevent users from creating tokens.

To find a list of team Owners on your team, go to the Account page: https://my.slack.com/account/team.

At the top, you'll see Owners and Admins listed. If you have several Administrators, you'll see a view admins link instead. Just click the link to see the complete list.

Those owners will need to know about Admin Approved Apps to get token creation restricted. That info can be found here:
https://get.slack.help/hc/en-us/articles/222386767-Manage-apps-for-your-team

Sorry for any trouble that you might be having here. I hope this helps.

Hi Jack,

Thanks for writing in. Thanks for the report and my apologies for this experience.

The team are looking into this, but we have a couple of workarounds for you in the meantime.

If you are seeing the phishing attempts as reminders in a channel, if you type /remind list you'll be able to view a list of the reminders in that channels, as well as an option to delete them.

Also I would also suggest that you as the PO enables Approved Apps so you can moderate better which custom integrations get added on your team.

Lastly of course, you can disable the accounts that may be sending this to your team.

I'm sorry that we can't be of more help at this time, Jack.

Please let me know if you have any questions.

Thanks,

Simone

I still think the best solution - for now - is to empower the users to be responsible for their own safety - they will need to know this in a digital future. (edited)

And that means teaching every single person in our community to learn a few things. (edited)

Main thing to learn:

We cannot stop anybody posting @slackbot reminders

We cannot delete @slackbot reminders in an IM channel that isn't ours (edited)

But - we can teach every single person who belongs to a slack channel how they can remove @slackbot reminders

- - - - - - - -

Every community member could learn this: (edited)

Go to your @slackbot channel - right there under DIRECT MESSAGES on the left hand side

In your @slackbot channel type this:

`/remind list`

that will then show up current and future reminders

Most likely these are all spam and you want to delete them

- - - - - - - - - -

Channel owners could: (edited)

Ensure nobody can assign themselves a token (check here: https://api.slack.com/custom-integrations/legacy-tokens) (edited)

Teach their users how to delete @slackbot IM messages / reminders using the above command (edited)

Maybe they could form a group of Slack channel owners who could share security ideas - I noticed some ICO teams had their tokens locked down and some did not. (edited)

Just thought of another thing - get people to switch off slackbot email notifications. Ok - I'll lay this up onto some kind of readme jpeg that we could put out to help people work around slackbot reminders.

https://medium.com/@altcoinio/slack-api-for-icos-de61df6448c3

@mikeyb I am not part of Augur team. I was on their slack channel. I suggest you join their Slack team and you shall find people to speak with. http://invite.augur.net/
Regarding the UI / UX warnings. I still think they would be better closer to the user actions. Like below the textarea where to copy paste the private key. For example right now, the red banner is not fixed on top, so it is out of view when scrolling. Plus, usually "small text" means "not so important to read". Could be just the annoying cookie warning plaguing every website on Internet.

For sure @AoDev but the real question is, how ugly do you want to make your application to cater to the less intelligent?  Historically evolution has wiped out the these types, but now we live in a world of helmets and knee pads so people don't hurt themselves.  At some point, catering to this lack of critical thinking causes an abundance of people who can't critically think (crypto is unimaginably full of this already).  To me, having a warning at all is overkill.  If I am using a currency whether it be physical or digital, I should have some understanding of what happens when I make a bad decision.
  Just like if I am hanging out at a local coffee shop and someone dressed as a barista walks up and says "Hey hand me $5 and I will go get you a new coffee so you dont have to get up".  To me it would make no sense why someone would ask me that, it is not a standard procedure.  Even if coffee shops were a new idea to me, I would probably ask my friend if this is for real.  Not just hand over $5.
People willing to click on a random link requesting them to move money around, and do so without questioning even the most basic things about the request, kinda deserve to lose their money IMO.  I do not expect a coffee shop to hang red banners over every table that say "Do not give money to strangers", this should be common sense derived from critical thinking.
Don't get me wrong, I am not advocating people getting scammed is a good thing.  User education is a much needed thing in crypto (literally the biggest issue about crypto imo.  Far worse than block size or tx throughput).  I don't really see it being fair to expect MEW to degrade the visual appeal of their wallet for these people though.  The giant red banner at the top is pretty damn obvious, and if you don't read it because you can't be bothered when dealing with your finances, then please by all means send your money to scammers so evolution will rid us of the flawed genetic pool.  Personally I find the red banner at the top annoying as all hell, but I understand it also being a small price to pay for a lot of user awareness.

I am not asking for more red banners. Just trying to find the best place where to put these warnings.
Also it's not the same flow that many people are used to. No login, no 2-factor authentication, didn't have to identify yourself. The whole flow is just write some random text in an input and here you go, address and all.
MEW has a self-signed certificate. For years people were mislead to look at the "secure" message in their address bar to decide whether they are on a secure site or not. I wouldn't talk so high and mighty about people who, in the end, show interest in such technologies and are learning.

No login, no 2-factor authentication, didn't have to identify yourself.

😩

IF you want to have those features, please leave your crypto on and exchange. Thansk

I think you misunderstood my writings. I am trying to explain why such a different flow may look strange to newcomers.

Being a new comer does not excuse you from learning what you are interacting with.
  Proceeding with financial distribution before understanding something does.
  I don't even think these devs get income from this project?

No login

Do you login to the wallet in your back pocket?

No 2-factor authentication

Why would an offline utility require online validation?

Didn't have to identify yourself.

See above and also add, this is crypto.  Your private key is a string of text, who are you suppose to identify to?  I don't identify myself when I hand someone a $20 bill
I am literally confused why this would be expected of free software on a financial network.    Just like I would expect to crash into a wall and die if I got into a car without understanding how to use it.
  People will lose money.  That is how you learn in life and become less idiotic.  Sure, people make mistakes, but anyone sending money to a scammer from the scam you posted deserves it.      Again, I am not advocating scams.    I mean this in the truest sense of the words.
Anyone scammed could have easily not been scammed by performing this one weird trick:
Ask Questions
RE: Your high and mighty comment.  You got the wrong guy man.  If you thought I was coming off as high and mighty check your head.  You know how I learned all this stuff?  By reading and asking questions.  Do you know how many scammers scam me?  0
Please by all means, fork the software and make it all red with 19 confirmations that tell people to verify blah blah blah.    Just like the person wearing a helmet and knee pads can still ride their bike off a mountain.
Sure, MEW can move the warnings.  They could make them bigger.  Make them more red.  Make them flash.  You will still have someone sending money to a scammer because their ego was too big to be humble and ask a question.    Please, let evolution thin the herd.

And just to be clear, I think your points and suggestions are quite valid.  But at what point do we stop catering?  At what point is a big red banner at the top of the page not enough?

I don't know why you insist on the fact the website should be turn into an ugly state, with exaggerated warnings. Surely a UI/UX person can make a good job at designing a nice UI and carefully prepare a flow that can help people think better about what they are doing.
Now I won't continue this discussion. I've opened this Github issue to warn about the current phishing issue and suggest helping people by maybe, improving the current place of the warnings.
Good luck.

Also, since I am not a user of reddit but on this thread: https://www.reddit.com/r/ethereum/comments/6lfy73/warning_stop_clicking_links_stop_sending_to/ I've wanted to add the .xyz domain to the urls to report. But I have no reputation so it has been moderated. If one of you want to add.

Surely a UI/UX person can make a good job at designing a nice UI

And to you I say Fork the repo and make the world the way you see it working best.  Like I said.  I don't think they get paid.  If they do get some amount, I am sure it covers nothing close to the time costs they have submitted.
How about people just wise up and learn to use the tools people are offering them for free.

Ive got a bunch of URLs and Slacks and addresses and stuff here: https://docs.google.com/spreadsheets/d/1ErQGI2elbzVAapLBYzDePV7jqpiDnsJoSlmAlQ9_zno/edit?usp=sharing
I literally don't have time to do it all. If you want something, open a PR, please. Seriously. Please.


Maps converted using this tool do not have collision with stickybombs

This obviously doesn't matter for defrag, but it would be nice if there was a command line option/flag to convert maps in a way that gives brushes vphysics collision. I couldn't easily figure out why this isn't the case with the tool already - I didn't even know it was possible for brush geometry not to register with stickies - but maps on mmod ported with this tool and ones I've ported locally have stickies pass through all geometry. If Panzer or someone knows an easy way to add this capability that would be cool. If this is actually complicated to add, probably like me and 2 other people will be sad when trying to mess around with defrag maps in sj mode

@jason-e is working on some changes to vbsp that will generate vphysics collisions on existing/compiled bsps. It will fix sticky bomb collisions and improve displacement collisions. I'm not sure when it will be ready since he has been preoccupied with other features.


Feature/dataverse

Ready for a second pass :baby_chick:

Ready for another pass :hatching_chick:

lgtm :+1:
I'll make some of the suggested changes during the merge.


Prop Types warning

Hi! Using react-billboard I found this issue. It is recreated in these codeSandboxes
When you supply an object to tick.culling (C3 supports this, reference ) you get the next warning:
Invalid prop `axis.x.tick.culling` of type `object` supplied to `BillboardChart`, expected `boolean`.

The attribute is applying anyway.
Looking into the shapes, I found this, wich should be the same, but, it is not working.
CodeSandBox with cullingMax
CodeSandBox with culling.max

Ah so the prop types need to be updated, that's fine. I can update them soon, over the weekend at the latest.
Just to clarify something, since you mentioned that "the attribute applied anyway" ... PropTypes are soft validators, they notify when something doesn't match expectations but do not throw an error or prevent rendering. It's not specific to this library, but React as a whole.

Thank you very much for your early answer.
We are up to date with proptypes, but thank you for your clarification anyway!
So, since cullingMax is not applying (and doesn't seem to appear anywhere else in the code) will be removed?

As mentioned, I will update the PropTypes at my first opportunity, unless you are willing to do a PR (always welcome!).


Setup git actions testing

Created by Boyana Norris via monday.com integration. 🎉

Initial script works

Complete baseline (lint + pytest) passes with commit 726102f15c011589082fc220384a73366f226a78


Not working at all with version 1.4.0 of ngRx/store

I have updated ngRx to 1.4 today and could not use the devtools anymore. I am getting various errors. Hope this will be fixed soon we can continue working with this awesome package.

The latest release fixes this


docs(version): update docker images version

update the docker image tag of kubeArmor in the helm dependencies yaml file.
Purpose of PR?:
Fixes #1366
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[x] Bug fix. Fixes #
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@PrimalPimmy could you pls review the changes!!

This is values.yaml used for testing in our CI. It uses local docker images which has the tag latest. We don't want to update this file.

The referred issue expects us to update stable to versioned releases.
It's not as simple as updating images tag from stable to version but we also need a automated workflow to do that for us on each release. I think it would be best if you could propose a design or an opinion on release strategy in the main issue before working on anything.
Appreciate a lot you looking into this.


Initial variables display code

Description
This adds set variables to the package preview prompt
Related Issue
Fixes #1124
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

This is what this looks like now:


A11y_AzureDataStudio_Selectthedeploymentoption_AI4D:Label is wrong for "Version"and "deployment target" combo box.

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHubTags: #SQL Azure Data Studio;#A11y_AzureDataStudio;#A11yMAS;#A11yTCS;#WCAG1.3.1,#WCAG4.1.2;#WCAG4.2.1;#DesktopApp;#NVDA;#AI4D#Win32;
Environment Details:
Application Name: Azure Data Studio
Version: 1.12.0-insider (user setup)
Commit: 32df727ff9fe68421b004bf270cd509e4c5de165
Date: 2019-10-08T19:18:43.743Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
Additional Details:
AI4D
NVDA 2019.2
Steps to Reproduce :
1.Install /Launch the application Azure data studio.
2.Navigate to connections and click on more action button.
3.Select “Deploy SQL Server big data cluster” from more action drop down.
4.Click on “Deploy SQL Server big data cluster” .
5.Open AI4D and hover on the I accept check box.
Actual:
When we hover on the "Version "and "deployment target" combo box label is showing the same as list item is selected.
Expected:
Label for the "Version "and "deployment target"combo box should be "Version "and "deployment target" respectively.
User Impact:
Screen reader User will not able to relate with the combo box.
Attachment for refrerance
A11y_AsureDataStudio_Selectthedeploymentoption_AI4D2.pptx
Does this issue occur when all extensions are disabled?: Yes

GitHubTags:#SQLADS-Win32-May2019;


BUG: Can't alter parameter initially_suspended after warehouse creation.

invalid property 'initially_suspended' for 'WAREHOUSE'
snowflake.connector.errors.ProgrammingError: 001420: failed to execute sql, [ALTER WAREHOUSE TITAN_TEST_WH SET initially_suspended = True]
Also, why would titan want to modify this warehouse since it was already created in the previous apply, and I didn't change anything on it?
 SHOW PARAMETERS FOR WAREHOUSE TITAN_TEST_WH    (3 rows, 0.12s)

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Hello @aleenprd :)
Remove **initially_suspended** from the configuration for existing warehouses.
Use **SUSPEND** or **RESUME** to control warehouse state after creation.

@neehhaa06 as a suggestion, I think Titan should have the following workflow. If warehouse exists, exclude initially_suspended parameter. That's point 1. Point number 2 is: why does it want to alter the existing warehouse when I didn't modify its resource definition in the first place? This seems like a bug to me.

Hello @aleenprd
To resolve the issue, first, update Titan’s workflow to exclude the initially_suspended parameter when modifying existing warehouses, as this parameter is only applicable during warehouse creation. Next, investigate why Titan is attempting to alter the warehouse configuration despite no changes being made to its resource definition, as this behavior may indicate a bug or misconfiguration in Titan’s update process.

@neehhaa06 what configuration can I check precisely? There are no logs to check for debugging purposes, as far as I can tell. And there is no configuration for the blueprint other than run_mode which is set to create-or-update.
This is my existing warehouse:

And these are the logs from the plan:
~ urn::JF91634:warehouse/TITAN_TEST_WH {
  ~ query_acceleration_max_scale_factor = None -> 1
}

~ urn::JF91634:warehouse/TITAN_TEST_WH {
  ~ scaling_policy = None -> "STANDARD"
}

~ urn::JF91634:warehouse/TITAN_TEST_WH {
  ~ min_cluster_count = None -> 1
}

~ urn::JF91634:warehouse/TITAN_TEST_WH {
  ~ max_cluster_count = None -> 1
}

However, if I also run SHOW PARAMETERS FOR WAREHOUSE TITAN_TEST_WH; we can only see:

which is probably not sufficient for Titan to know what the actual rest of the parameters of the warehouse are.

Fixed in v0.9.


Add tests for KeywordTranslator

Why: To improve test coverage

Coverage increased (+12.06%) to 98.214% when pulling 51dd5079ca649ed5d0cc43043b4339a92ef58a0a on mb-keyword-translator into 1ebb4127e7b5714baac9bba3c90ae04a3ce40e33 on master.


Long strings are dropped in pattern matching optimisation

type maybe 'a =
  | Just of 'a
  | None
let fromMaybe d x = match x with
  | Just n -> n
let "123456789" = fromMaybe "no string" (Just "123456789")

results in a lint failure (about n not being bound), but this compiles:
-let "123456789" = fromMaybe "no string" (Just "123456789")
+let "12345678" = fromMaybe "no string" (Just "12345678")

OK, so the optimiser still does a kinda terrible job (we need to inline non-trivial atoms which are used once), but it's a good start.


Cancel callback not called

When I close the web extension popup window before sending a transaction the onCancel method is not called.
I am using Firefox, Stacks Wallet Web 2.10.0 and @stacks/connect 5.5.0 and connect-react 10.0.0
In the console I see
[Connect] Error during transaction request cancel index.js:1
    e index.js:1
    openTransactionPopup index.ts:121
    (Async: promise callback)
    openTransactionPopup index.ts:99
    _callee5$ index.ts:188
    Babel 10
    generateTokenAndOpenPopup vendors~main.chunk.js:21612
    openContractCall index.ts:203
    doContractCall use-connect.ts:82

typo in my code


Example html pages

Hey @sveltecult ! 😊, I just want to say I absolutely love your work! I'm really enjoying learning and working with your open source library. I have a quick question—it's not an issue, just curiosity. Do you happen to have the example pages from the Astro examples repo available in plain HTML by any chance?
I remember one of my teammates managing to get a page into HTML before, but since I'm still getting the hang of things, I could use a little help figuring it out. Thanks a ton in advance!

Just have a look here: 🙂
https://examples.franken-ui.dev/examples/mail
https://examples.franken-ui.dev/examples/dashboard
https://examples.franken-ui.dev/examples/cards
https://examples.franken-ui.dev/examples/tasks
https://examples.franken-ui.dev/examples/playground
https://examples.franken-ui.dev/examples/music
https://examples.franken-ui.dev/examples/authentication


Check existing ml

Description
Added check buttons to, in case that there is already a model saved in the experiment, ask the user if run the experiment again and overwrite previous results.
Also corrected a small error in the FI page that caused the page to crash.
Linked issues

#127

(Optional) Screenshots

This is how it is displayed:

If user chooses to not rerun and clicks Run Training:


Add 'buildTagsFromPaths' option.

@mohsen1 Can you please review it?

LGTM! Thanks for the documentation


Code block formatted incorrectly

Using the latest version of both mkapi and the mkdocs-material theme, the api code is formatted incorrectly.
This issue has been introduced by https://github.com/squidfunk/mkdocs-material/commit/4eb1a4393741b1ecf8019dd53292b7a4d02e16f5
I bypassed this for now by overwriting it:
.md-typeset .md-code__content {
    display: block !important;
}

But I assume this is not the proper solution and might need investigation.

Thanks @twsl this partially addresses the problem for me. The formatting is okay, but the [docs] link does not always appear on the correct line.

This is because span elements with an id attribute are inside source pages. It was resolved by changing a span element to a div element. The fix will be included in the next release.


Feature request: following links

Are you submitting a bug report or a feature request?
Feature request
What is the current behavior?

Squidwarc can't config to following links if url is same domain as seeds.
What is the expected behavior?
Can config to following links if url is same domain as seeds.

What I interpret this as (and @Sian1468, please correct me if wrong) is an option to only follow links if the links are in the same domain.
Normally I would think this is covered by domain restriction but I think what is being suggested is to ignore the "hops" restriction and keep following any links that are in the same domain. This is somewhat similar to "archive the whole site" provided the entire site is inter-linked from the starting seed.

What I interpret this as (and @Sian1468, please correct me if wrong) is an option to only follow links if the links are in the same domain.
Normally I would think this is covered by domain restriction but I think what is being suggested is to ignore the "hops" restriction and keep following any links that are in the same domain. This is somewhat similar to "archive the whole site" provided the entire site is inter-linked from the starting seed.

You correct @machawk1
I think Squidwarc can do more than capture from depth setting by capture whole site with single/by depth page's offsite links or without offsite links setting.

@Sian1468 thanks you for suggesting this and I believe your suggestion would be an excellent feature for Squidwarc.
I will be putting some thought into how to accomplish this nicely alongside the existing crawl modes.
Do you have any suggestions as to how you would like to be able to specify this crawl mode?

@Sian1468 thanks you for suggesting this and I believe your suggestion would be an excellent feature for Squidwarc.
I will be putting some thought into how to accomplish this nicely alongside the existing crawl modes.
Do you have any suggestions as to how you would like to be able to specify this crawl mode?

Recursive crawl mode
I got inspiration from other archiving tools & software eg. Wpulll, grab-site and crocoite

implemented and merged into master PR #47


Integrate search api into frontend

Trello ticket
Problem statement
Integrate search api into frontend
Solution description
Create a function, which return list orders by parameters and rendering it

add setTimeout before tests
change street on streetName in tests

add in tests:
afterAll(async () => {
await client.close()
})

Delete header searchTable by start application
Add description if havent order by request
Delete convert phone to number
Refactor code

Refactor code


Add whatsapps as a native option in the UIActivity view

What are your thoughts on adding some common apps, whatsapp in this case, as an option on the native share window. We've added the code from this repo https://github.com/jberlana/JBWhatsAppActivity to this plugin to achieve sharing with whatsapp in a more native way.
If it's of interest, I'll raise a PR on it.

WhatsApp finally has an iOS share extension. Yay!


CountOccurrences Function dont work

Hello Ruri, is me. I'm having problem with CountOccurrences, it dont work for any tries

Put  In Input
https://i.imgur.com/QtMkIHV.png
Parse it to a list but not return sum of them
https://i.imgur.com/nA4xNPx.png
And there any change to turn off auto execute "" regex in script?
Like I have a Loliscript like this
PARSE SOURCE LR "Test\\" "\\" -> VAR "HELLO"
This will break the config, same happen if put this in any order block type
Sorry for bothering, I'm noob at coding and still starting with Python, Thanks you Ruri.

Please make sure to check the commit history before opening issues that are already fixed, thank you.
Fixed here: https://github.com/openbullet/openbullet/commit/043c4ad635746e014781d05fb93cf892f1f0eb3b


.isValid() is no longer available on EditContext

Description
The code referring to editContext.isValid();, should be replaced with !editContext.GetValidationMessages(fieldIdentifier).Any();.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/forms/validation?view=aspnetcore-8.0#custom-validation-css-class-attributes
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/forms/validation.md
Document ID
bcb470e1-c859-0549-b4ef-c6c9b7ef2c72
Article author
@guardrex

Hello @MorneZaayman ... I'll take a closer look when I get back from vacation, but why do you say that? That approach is valid, but it isn't recommended IIRC.

isValid is not available on the EditContext object.

It's an uppercase "I" for IsValid ... and it will need the field identifier. See if this will work as the body of the GetFieldCssClass method ...
return editContext.IsValid(fieldIdentifier) ? "validField" : "invalidField";

I also note to myself for an update that the sample app hasn't embraced the IsValid approach that the article asks for (apparently). I just opened the BWA 8.0 sample app, and I see that the code is still using the Linq Any test.
Let's leave this issue open so that I can take a closer look after I get back from vacation next week. I think sample app needs an update (at least), but I'll also check the topic(s) to make sure that everything is in good order or apply updates.

Yeah ... it's definitely a 😈 in the topic ... it should be an uppercase "I" for IsValid. I'll make that change now quickly and take it live, but I'd still like to look things over when I get back from vacation. The sample app should probably use the approach. I'll need to see how the sample is linked in here for the code, etc. to resolve this issue completely.

Ok ... we're good. That will go live in the article in about ten minutes or so. Thanks again for the report. I'll update the sample apps next week as I move the new 8.0 bits into them, which is tracked by another issue.


Update the type hinting for core.py

As core.py is the foundation for the whole of Gymnasium, it should have good type hinting to help users understand the expected types for functions.
This PR fills the gaps in the implementation where type hints were currently missing.
One of the things not done in this PR is to make this require pyright strict type hinting to enforce a number of type hinting specifications that are not applied currently to the project
Edit: I have added ABC and abstractmethod to Env, Wrapper, Env.step, Env.reset

@RedTachyon Removing the ABC and abstractmethod allowed me to revert most of the changes to other files.
I have kept the changes to test_core.py as I thought that the tests before did not do a good job testing the base implementations (I actually found a weird bug). Let me know if you want it reverted back or more comments on the tests added.
The only major changes to before is two new TypeVars WrapperObsType and WrapperActType. These allow us to have  more complete types by differentiating between the wrappers environment types and the wrappers types. I believe this implementation is correct but due to Pyright having checks disabled we can't know for certain.
This is probably the motivation needed to fix the pyright properties.


Add tests to CUDA CI

Looks to be some test errors. Wondering if anyone on rocsparse team can have a look at them?

Looks to be some test errors. Wondering if anyone on rocsparse team can have a look at them?

It's on our list :)  I will keep you updated

Turned CI back on to see if we have all failures fixed

Jenkins automatically merges develop branch into PR branch when running CI


[Feature Request] Is it possible to show a loading component inside  ?

What is your enhancement?
Right now I'd like to show some Skeletons while the network request is being made, I didn't find this option in DataTable API, is it possible? Currently I'm rendering the table Skeletons below DataTable, but it's strange, I'd like to show them as rows (while the real data isn't available).
I tried rendering the skeletons INSIDE the table, something like this:
<DataTable
    /*...other props*/
    table={{
      /*...object*/,
      rows: {
         info: <Skeleton />
      }
    }}
/>

But unfortunately, the code above is never executed while the request is being made, only after the data is ready. So my skeletons would never appear.
Here you can see that my skeletons are below the table:

Finally I got to solve it:
const test = () => {
    return [
      {
        info: (<Skeleton variant="circular" width={40} height={40} style={{ marginRight: 20 }} />),
        ....
      },
    ];
  };

return (
   <DataTable
       table={{
           rows: loading ? test() : content?.data?.map((c) => ClientRow(c)),
         }}
  />
)


Honor RUSTFLAGS's target-cpu if given

Hey, thanks for maintaining a nice crate! This is a tiny build-related PR.
Problem
CPU instruction detection is done at compile time, which isn't compatible for cross-compiling in some case. For example, there is a condition in which compilation is done by a machine with AVX512 and compiled using it and then the binary is transferred to an older machine which lacks the AVX512 support.
Solution
To fix the cross compile issus, we can make reed-solomon's build.rs to accept/honor given RUSTFLAGS, which might have some info for intended CPU architecture in it.
So, we're forcibly reinterpreting RUSTFLAGS's cpu-type as CFLAGS's -march, but it's safe, I think.
That's because as far as I'm aware, the acceptable value of target-cpu is universal across OSS C and Rust toolchains, because rust and clang share the same backend (LLVM), then LLVM was in turn heavily influenced by the GCC because of the compatibility.
Ideally, these should be runtime-based switching for each SIMD implementations, but it would take some more effort than this.
FYI: we're coming from @solana-labs. I'm a collegue with @sakridge, who contributed as well. :) I've created an identical PR for our forked version of this repo: https://github.com/solana-labs/reed-solomon-erasure/pull/1

Coverage increased (+0.001%) to 96.259% when pulling bca41bb39364eb958cad6946e3a92760a615734d on ryoqun:guess-target-cpu-for-upstream into 195263f8b141d80769ec99b347e2143192c41b10 on darrenldl:master.

Thanks for the PR!
I think the fix is a really nice way of handling that in build.rs (I recall choosing -march=native initially after trial and error and giving up).
However, I'm gonna say that I haven't done much Rust nowadays, and so I'll wait a bit and see if other contributors or users have any more feedback.

@darrenldl Thanks for merging!! Now, I'm looking forward to a new patch release, hopefully. :)

@ryoqun Thanks for the PR again. I'll finish the required admin work (filling in changelog) and make a release in next 24 hours.

@ryoqun 4.0.2 has been published to crates.io
Let me know if there's any problem - kinda doing it in a rush, sorry if I missed some stuff during publishing.

So, we're forcibly reinterpreting RUSTFLAGS's cpu-type as CFLAGS's -march, but it's safe, I think.

For target-cpu=generic, rustc will accept that, but Clang rejects -march=generic. But this is a minor issue, target-cpu=generic is not the default.


Use "/track/restapi" instead of "/restapi/track"

Is your feature request related to a problem? Please describe.
The https://t.17track.net/restapi/track provides a limited number of information, and some of them are erroneous : timestamp are set according to the current package time zone with no information about it (e.g. 2024-09-02 22:25).
Describe the solution you'd like
The https://t.17track.net/track/restapi provides much more information including a latest_event.time_iso field (e.g. 2024-09-02T22:25:00+08:00) and a latest_event.time_utc field (e.g. 2024-09-02T14:25:00Z). The inputs (and HTTP method) are the same, only the output format changes.
It would probably be interesting to migrate over to this API, at least to fix this lack of timezone support (and maybe add additional fields such as package coordinates later on).

Also, I guess if the 'Out for delivery' state (code 32) could be added to PACKAGE_STATUS_MAP. I know It's available in the /track/restapi endpoint, although I'm not sure about /restapi/track
"shipments": [
    {
      "pre_status": 32,
      "prior_status": "OutForDelivery",
      "state": "Success",
      ...
    }
]

What do you think @shaiu ?


Removed liveness.sh e2e test

The test was ported to Go in #3715 and nobody in #3696
has objections to remove it.

Hold. :)

Please see #4501, #4406. The Go test is still not as reliable as the shell test.


Jjs/update buildkit 14

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes unit tests
[ ] Adds integration tests if needed.

See the contribution guide for more details.
Reviewer Notes

[ ] The code flow looks good.
[ ] Unit tests and or integration tests added.

Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.
Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

Closing this PR, as its changes are represented in #33