New Release?

Please don't mind but the latest release was on October 29 and April's end is approaching... almost 6 months. When can we expect the boatload of fixes on develop to come to the release channel?
If you want a tester, I can volunteer?

I truly wouldn't mind a tester.
As for getting the latest version, you can always use the nightly version. On there, if you truly want to help testing out the latest feature, JavaScript sources (which might be a little buggy), you'd have to enable it manually in your settings.ini file by adding a enableJsModels=true line just after [General].
The full release will be made when all issues in milestone 5.6.0 are completely finished. As far as I know, the remaining ones are:

https://github.com/Bionus/imgbrd-grabber/issues/925
https://github.com/Bionus/imgbrd-grabber/issues/1175 (not all sources have been converted yet, and some parts are still in the XML files)
https://github.com/Bionus/imgbrd-grabber/issues/1060 (the current counter is pretty ugly)

The nightly link isn't working or do you want me to setup the compilation environment and make the build?
It has been over 4 years that I have last worked on any desktop application...

My bad, I updated the link:
https://github.com/Bionus/imgbrd-grabber/releases/tag/nightly

The release stutters more now. Like on each page load it goes unresponsive for a small period. The pause during page change in an ongoing download is also more pronounced. But somehow the overall flow feels a lot smoother as long as you don't click in the app during those pauses which then sticks that non responsive mark on it momentarily.
I don't know about your implementation but last time when I developed a Steam like gaming client in C++ and Delphi, I had devised a successful solution. After months of research and experimentation, I had made the UI go in a separate thread with a queue of UI updates managed by another thread. The queue had nodes with locks, lock expiry time and some status flags to deal with race and error conditions.
Only then was our app responsive enough to simulate an internet like environment over LAN with games like Warcraft 3 with its frequent sub-second keep alive packets and many players. The UI was completely, hardware accelerated 3D. Unrelated scenario, I understand but shows the benefits in the responsive department.

Well the non responsive behavior is really difficult to deal with, while browsing and batch downloading, one does inadvertently make a click and windows being merciless, closes the program.
Also I repeatedly receive this warning while batch downloading:
[Warning] [Qt][default] QCoreApplication::postEvent: Unexpected null receiver

After further tests, the non responsive behavior occurs right after it downloads a page. In the response processing phase. I guess? Somehow now its always going into that state on page change and finally windows closes the program (now it doesn't take a click to do it).
Also seemingly its not respecting existing files and md5 existence always. I have done batch downloads of a group of tags back to back and every time it downloaded the same files again. As if, those files do not exist.

Pixiv support please

Images from rule34.paheal.net start out in a small size (Image Detail Window), almost the same size as a credit card placed at its longest at the vertical. Only when they are downloaded fully, do they revert to the default view.

Indeed, that's what happens when Grabber does not know the image dimensions when opening the image window. When it knows it, it will scale the thumbnail to the full size, to have a "blurry" image until the image is loaded.
I pushed a fix to the JS model to parse the width and height with the RSS source.

The release stutters more now. Like on each page load it goes unresponsive for a small period. The pause during page change in an ongoing download is also more pronounced.

I don't know about your implementation but last time when I developed a Steam like gaming client in C++ and Delphi, I had devised a successful solution. After months of research and experimentation, I had made the UI go in a separate thread with a queue of UI updates managed by another thread. The queue had nodes with locks, lock expiry time and some status flags to deal with race and error conditions.
Only then was our app responsive enough to simulate an internet like environment over LAN with games like Warcraft 3 with its frequent sub-second keep alive packets to many peers/clients through 4 separate interfaces. The UI was also completely, hardware accelerated 3D. Unrelated scenario, I understand but shows the benefits in the responsive department.

How long are those "freezes"? I also noticed them, but they maxed out at 2s, very rarely longer than that.
Does this only happen with JavaScript sources enabled or also when it's disabled? You can change this setting in your settings.ini file in the [General] category, with enableJsModels=true to enable them and enableJsModels=false to disable them.

After further tests, the non responsive behavior occurs right after it downloads a page. In the response processing phase. I guess?

Yes, it's very likely that those freezes occur when parsing the results.

But somehow the overall flow feels a lot smoother as long as you don't click in the app during those pauses which then sticks that non responsive mark on it momentarily.

What do you mean "smoother"?

Well the non responsive behavior is really difficult to deal with, while browsing and batch downloading, one does inadvertently make a click and windows being merciless, closes the program.

Somehow now its always going into that state on page change and finally windows closes the program (now it doesn't take a click to do it).

Doesn't Windows ask you whether you want to wait or kill the program in those cases? Then you could tell him to wait.

Also I repeatedly receive this warning while batch downloading:
[Warning] [Qt][default] QCoreApplication::postEvent: Unexpected null receiver

You can safely ignore them. Those warnings used to be hidden, I simply decided to add them to the log with this update, as they should be.

Also seemingly its not respecting existing files and md5 existence. I have done batch downloads of a group of tags back to back and every time it downloaded the same files again. As if, those files do not exist.

I can't reproduce on the latest nightly version. Maybe I fixed it as I worked on that part of the program in the last few days.
Otherwise, do you use the "multiple files" feature? (that is, one image saved in two locations on save, for example for each "artist" tag).

Pixiv support please

See issue #738.

Sometimes the freeze is about 10-15 seconds but sometimes it just gets stuck in it for a quite a while till windows closes it.
So there are three possibilities when freezing occurs. One is that you wait it out and it resumes downloading. Second is that it does not resume and in about a minute windows closes the app without giving the option to wait (Maybe its specific windows 10). Third is that you get frustrated and do a bunch of clicks, windows then throws that wait dialog.
Well smoother meaning that the browser seemed smooth in loading and displaying images and there were almost no placement issues. Like in the release version, I sometimes go to a page and an image (the last one in a random row) starts to swap positions with the row below.
I will do specific tests again with and without JS sources for the freezes. I don't remember the setup when I tested before.
I will also try to reproduce that existing images thing.

So the issues below only appear after about 3-4 hours of constant usage:

The save function in the preview window should wait for the file to get downloaded but for some reason it stops doing that. It just saves the image and stops the download when the "save" or "save and close" buttons get clicked. Thus image gets downloaded partially.
Grabber might start micro-freezing when doing bulk downloads. Only way to resolve this is to clear the log immediately. Does not happen, if the log tab is disabled. Happens on release version too. In fact, frequently clearing the log can make the app much less susceptible to crashing.
If you change pages and a media is being downloaded in a preview window, it gets interrupted.

The following issue occurs after Grabber survives (:P) 6-7 hours of use:

The preview window first randomly stops showing preview especially for bigger images then completely stops showing the previews. It might recover for some time but will relapse eventually. This behavior can happen earlier too, if higher resolution images are browsed.

When the above happens, its best to restart grabber as that indicates that a crash is imminent.
These all seem to be memory related issues.

Sometimes the freeze is about 10-15 seconds but sometimes it just gets stuck in it for a quite a while till windows closes it.
So there are three possibilities when freezing occurs. One is that you wait it out and it resumes downloading. Second is that it does not resume and in about a minute windows closes the app without giving the option to wait (Maybe its specific windows 10). Third is that you get frustrated and do a bunch of clicks, windows then throws that wait dialog.
I will do specific tests again with and without JS sources for the freezes. I don't remember the setup when I tested before.

 The fix was pushed two weeks ago: 35dceef1718185d3c0fa8d6feefe7001bdf2f657.
It's indeed totally unrelated to JavaScript sources.

Well smoother meaning that the browser seemed smooth in loading and displaying images and there were no placement issues. Like in the release version, I sometimes go to a page and an image (the last one in a random row) starts to play roulette with the first position in the row below.

Well, that's good to know then :smile:
I indeed did a bunch of changes to the layout, so some issues might have been fixed.

I will also try to reproduce that existing images thing.

If possible, because I could not reproduce this.


Exception while reading data: TypeError: 'float' object is not iterable

Deployed latest graphite-web yesterday and now see a lot of:
Traceback (most recent call last):
File "/opt/graphite/webapp/graphite/render/datalib.py", line 136, in fetchData
seriesList = _fetchData(pathExpr,startTime, endTime, requestContext, seriesList)
File "/opt/graphite/webapp/graphite/render/datalib.py", line 99, in _fetchData
fetches = [(node, node.fetch(startTime, endTime)) for node in matching_nodes if node.is_leaf]
File "/opt/graphite/webapp/graphite/node.py", line 30, in fetch
return self.reader.fetch(startTime, endTime)
File "/opt/graphite/webapp/graphite/readers.py", line 174, in fetch
for (timestamp, value) in cached_datapoints:
TypeError: 'float' object is not iterable

the hacky fix is to add:
if hasattr(cached_datapoints, 'iteritems'):
cached_datapoints = cached_datapoints.iteritems()
try:
cached_datapoints = CarbonLink.query(self.real_metric_path)
except:
log.exception("Failed CarbonLink query '%s'" % self.real_metric_path)
cached_datapoints = {}
  if hasattr(cached_datapoints, 'iteritems'):
    cached_datapoints = cached_datapoints.iteritems()

  for (timestamp, value) in cached_datapoints:
    interval = timestamp - (timestamp % data.timeStep)

    try:
      i = int(interval - data.startTime) / data.timeStep
      values[i] = value
    except:
      pass

I tried your hacky fix with no luck:
webapp/cache.log
Sat Feb 14 14:53:27 2015 :: CarbonLink sending request for carbon.agents.vmlinux-a.cache.size to ('<IP_ADDRESS>', 'a')
Sat Feb 14 14:53:27 2015 :: CarbonLink finished receiving carbon.agents.vmlinux-a.cache.size from ('<IP_ADDRESS>', 'a')
Sat Feb 14 14:53:27 2015 :: CarbonLink sending request for carbon.agents.vmlinux-a.cache.size to ('<IP_ADDRESS>', 'b')
Sat Feb 14 14:53:27 2015 :: CarbonLink finished receiving carbon.agents.vmlinux-a.cache.size from ('<IP_ADDRESS>', 'b')
Sat Feb 14 14:53:27 2015 :: CarbonLink cache-query request for carbon.agents.vmlinux-a.cache.size returned 2 datapoints

webapp/exception.log
Sat Feb 14 14:53:27 2015 :: Failed after 2 retry! See: 'float' object is not iterable
Traceback (most recent call last):
  File "/opt/graphite/webapp/graphite/render/datalib.py", line 136, in fetchData
    seriesList = _fetchData(pathExpr,startTime, endTime, requestContext, seriesList)
  File "/opt/graphite/webapp/graphite/render/datalib.py", line 99, in _fetchData
    fetches = [(node, node.fetch(startTime, endTime)) for node in matching_nodes if node.is_leaf]
  File "/opt/graphite/webapp/graphite/node.py", line 30, in fetch
    return self.reader.fetch(startTime, endTime)
  File "/opt/graphite/webapp/graphite/readers.py", line 177, in fetch
    for (timestamp, value) in cached_datapoints:
TypeError: 'float' object is not iterable
Sat Feb 14 14:53:27 2015 :: Exception encountered in
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/graphite/webapp/graphite/render/views.py", line 111, in renderView
    seriesList = evaluateTarget(requestContext, target)
  File "/opt/graphite/webapp/graphite/render/evaluator.py", line 7, in evaluateTarget
    result = evaluateTokens(requestContext, tokens)
  File "/opt/graphite/webapp/graphite/render/evaluator.py", line 18, in evaluateTokens
    return evaluateTokens(requestContext, tokens.expression)
  File "/opt/graphite/webapp/graphite/render/evaluator.py", line 21, in evaluateTokens
    return fetchData(requestContext, tokens.pathExpression)
  File "/opt/graphite/webapp/graphite/render/datalib.py", line 141, in fetchData
    raise Exception("Failed after %i retry! See: %s" % (settings.MAX_FETCH_RETRIES, e))
Exception: Failed after 2 retry! See: 'float' object is not iterable

Did you change it in both places (WhisperReader and CeresReader)? It looks like it should be fixed by:
https://github.com/graphite-project/graphite-web/pull/1122 but only for WhisperReader :(

I get the same error.
Эта ошибка появляется если я использую подключение через carbon link, и е очень часто когда Disk Utization 100%
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 115, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/opt/graphite-storage/webapp/graphite/render/views.py", line 111, in renderView
    seriesList = evaluateTarget(requestContext, target)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 7, in evaluateTarget
    result = evaluateTokens(requestContext, tokens)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 18, in evaluateTokens
    return evaluateTokens(requestContext, tokens.expression)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 21, in evaluateTokens
    return fetchData(requestContext, tokens.pathExpression)
  File "/opt/graphite-storage/webapp/graphite/render/datalib.py", line 141, in fetchData
    raise Exception("Failed after %i retry! See: %s" % (settings.MAX_FETCH_RETRIES, e))
Exception: Failed after 2 retry! See: 'float' object is not iterable

I get the same error.
This error appears if i use the option CARBONLINK_HOSTS, and it doesnt appear if i use only the option WHISPER_DIR in the file local_settings.py. Also this error appears very often when Disk Utization reaches 100% (it doesnt with WHISPER_DIR and hight Disk Utilization)
My configuration is the following
4 processes carbon-cache
1 gunicorn for graphite-wsgi
I`m ready to give any additional information.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 115, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/opt/graphite-storage/webapp/graphite/render/views.py", line 111, in renderView
    seriesList = evaluateTarget(requestContext, target)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 7, in evaluateTarget
    result = evaluateTokens(requestContext, tokens)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 18, in evaluateTokens
    return evaluateTokens(requestContext, tokens.expression)
  File "/opt/graphite-storage/webapp/graphite/render/evaluator.py", line 21, in evaluateTokens
    return fetchData(requestContext, tokens.pathExpression)
  File "/opt/graphite-storage/webapp/graphite/render/datalib.py", line 141, in fetchData
    raise Exception("Failed after %i retry! See: %s" % (settings.MAX_FETCH_RETRIES, e))
Exception: Failed after 2 retry! See: 'float' object is not iterable

This looks like a duplicate of #1139, which was resolved via #1122. If I'm incorrect please let me know and we can reopen.


Scan

Make content easy to grasp just by scanning or skimming

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ravishanker sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Preview:

It's a cool idea, but I think it's too much.
On the road to helping people digest the info quickly, I feel it distracts. Maybe that's just me.
But if we are going to do it ~ why not be consistent and put in icons for diversity, openness, and delightful tools?
As well as icons before PR, email and microsoft.
(Should this comment be comments on the code?)

@dosyago-coder-0 terms like diversity, openness, delightful tools are generic unlike the brand images used for well-known names.

Thanks for the contribution!
But, IMO, icons just add clutter. I like plain version more.
Maybe if you are trying to make it look more appealing, try it with emojis? 👀

An interesting experiment, but I think the legibility suffers. Thank you for your PR.


Paginate backwards for stargazers

Temporary solution to avoid exploding API quotas because the stargazers stream does not provide "since" or "sort/direction" parameters
To mitigate this, we traverse backwards and try to exit early.
WARNING - this does not work for large repositories such as facebook/react, see #120

Yes for large repositories it basically gets one page of data and then exists if there is a since parameter.
If there is no since parameter, it will do the same thing as before -> get all the data it can, which is not everything.
Eg for faceook/react we would get 40k out of 180k stargazers.
Note that this PR will probably be closed / useless if we move forward with #123

Less useful thanks to #120


⚠ ClamAV has degraded performance

In 55fd20c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 193 ms

Resolved: ClamAV performance has improved in e835203.


Feature Request: Allow 3 copies of AstroScript Pilot Program in casual decks

Making AstroScript limited to 1 per deck makes it impossible to create a legal NBN deck from the core set.
For people like me who play quite a lot with only the core set it would be nice to be able to choose whether AstroScript is limited or not.

the core set has two of the AstroScript, when making a legal deck from the core set only, you should be allowed at least two like the core set actually has.

I understand, but I'm not the one who makes the rules. The card has been errated by FFG to be "Limit 1 per deck", so it is. The deckbuilder abides by the official rules.

Try again, nowhere on it does the card in the core set say limit 1 per deck, which leads me to believe you have an old generation card under new generation rules. So double check that card. Also, if it really is limit one per deck, than why does the core set include two for the pre made deck. I find it very hard to believe that the nbn deck is the only pre made deck that is not legal.

@shadow-studios I'd appreciate that you use a different tone here. If you have a doubt, ask clarification. If you disagree, provide proof. But don't boss me around.
Regarding AstroScript Pilot Program, you can find the latest official FAQ, with official card erratas, here: https://www.fantasyflightgames.com/en/products/android-netrunner-the-card-game/. And I'm quoting:

Errata overrides the originally printed information on the card it applies to.


Generate Internal API documentation

We should use an API documentation generation tool like Sphinx to generate the documentation we need to show what classes/functions are available/how they are related and any docstrings they have explaining their use.

[ ] Each project (devtools/sharedmodels/PMD/csvwlib) should generate their own docs.
[ ] A Jenkins job should be created to generate these docs, they should be output as a ZIP artifact for the build process.
[ ] The docs should be available as a (searchable) static HTML website.

~Do we want to publish the static site somewhere or are we happy having a ZIP file to download at this stage?~ - We're happy enough with a ZIP for now.

@mikeAdamss has suggested we consider using mitmproxy/pdoc. Is worth considering using instead of sphinx when doing this ticket.

Some useful links for managing the current sphinx configuration I have setup:

sphinx-apidoc
sphinx-autodoc

Each project's API documentation config file can be found in docs/conf.py. That's where we configure things like the function names which are ignored, the ordering of the functions/attributes in classes/modules and the intersphinx referencing.


How to append more folder into the workspace?

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:45:32.595Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

vscode-eclipse-keybindings
alphabotsec
0.8.0

tortoise-svn
fantasytyx
0.1.1

php-intellisense
felixfbecker
0.0.12

composer
ikappas
0.5.0

material-icon-theme
PKief
1.1.5

Steps to Reproduce:

How to append more folder into the workspace?  I dont't like open multiple window to edit project

。。。 such as multiple folder from Sublime Text Editor

I don't think you can.

HOW TO SUPPORT IT?

it's in roadmap.
https://github.com/Microsoft/vscode/wiki/Roadmap
Multiple folders inside a single workspace

Yes it is on the roadmap and it is a duplicate of #396


A wish to use import statements in the handlebars custom helper functions...?

I am attempting to simply require a file into that helper function but it seems to me that when it runs it is running from the "renderer" path location.
/Applications/Obsidian.app/Contents/Resources/electron.asar/renderer
The absolute path for requiring a file works but would be nice to have relative paths.
Not sure if this is doable with ease...?
//example file to require: planets.js

module.exports = {
  planet_symbol: {
    sun: '☉',
    earth: '⊗',
    moon: '☾',
    mars: '♂',
    venus: '♀',
    mercury: '☿',
    jupiter: '♃',
    saturn: '♄',
    neptune: '♆',
    uranus: '♅',
  }
}
// js 'require' with path relative to the helper function file...
const Planets = require('./planets.js');
console.log(Planets.planet_symbol[sun])

The contents of the supplied additional handlebars custom helper file are read into the importer and used as the body of a function.
let initJsonHelpers = new Function('handlebars', await helperfile.text());
if (initJsonHelpers) initJsonHelpers(handlebars);

The function is then called and the handlebars parameter is provided for the helper file to register it's own helpers. My testing used a file containing the following:
function hb_farling() {
	let orig = arguments[0];
	orig += ' from Helper';
	return orig;
}
handlebars.registerHelper('farling', hb_farling);

Thanks @farling42. I love what thehelpfer functions can do and I love the functionality of your plugin!
I have got the helper functions working and have included an example of how I am trying to require the file... but it seems it goes beyond my basic javascript knowledge - because of how electron packages the module I got a bit lost.
Thought I would clarify - but no big issue if it gets complicated i will just use absolute paths to require the file.
console.log(__dirname);

const Elements = require('./elements.js');

/*
 I can add some of my extra js objects like this (below) "rt_expand_center()"
 that can be used in the helper functions etc.. but I was hoping to
 use require's to bring them in from a local directory so I can use them like on line 36
 but it seems due to the path when teh actual function runs
 it cannot find the file.
 */

const bodygraph_centers = {
  identity: 'G-center',
  life_force: 'Sacral',
  mind: 'Ajna',
  emotion: 'Solar Plexus',
  expression: 'Throat',
  intuition: 'Spleen',
  drive: 'Root',
  willpower: 'Heart/Ego',
  inspiration: 'Head',
};

const clean_string = (str) => {
  console.log('str:', str);
  console.log('_str:', str.replace(/\s/g, '_').toLowerCase());
  return str.toLowerCase().replace(/\s/g, '_');
};

function rt_get_planet_symbol() {
  console.log(arguments[0]);
  const planet = arguments[0];
  const _planet = clean_string(planet);
  const element = Elements.planet_symbol[_planet];
  console.log('element:', element);
  let str = `${planet} [${element}]`;
  return str;
}

handlebars.registerHelper('get_planet_symbol', rt_get_planet_symbol);

function rt_expand_center() {
  console.log(arguments[0]);
  const type = arguments[0];
  const _type = clean_string(type);
  const center = bodygraph_centers[_type];

  console.log('center: ', center);

  let str = `center: ${center}`;
  str += '\n';
  str += `center_type: ${type}`;
  return str;
}

handlebars.registerHelper('expand_center', rt_expand_center);

You could try using the full path from the root of your vault, such as:
const Elements = require(app.vault.root.path + 'foldername/elements.js');

That's perfect!!! It works...! Thanks so much!


Support Healthcheck port to be different from Service port

When HC_PORT variable is defined:

Use for healthcheck rather than using service port
Create an extra firewall rule to allow Google check ip ranges to connect on the hc_port

Also add Region field to forwarding_rule , it was only applied to the target pool

I signed it!

Hi @primeroz! Thank you for your interest in the project. I apologize for the extreme delay in responding. As this module requires more significant updates, I am closing this pull request in favour of #20 which we will be prioritizing immediately. This issue will address your request to configure the health check port.


Add Fabric version and update the support version to 1.17/1.17.1/1.18/1.18.1

My friend open a server and want to add a lift mod, but the lift mod on Minecraft 1.17 and above of this version and use Fabric API is extremely few.
So, could you add Fabric version and update the support version to 1.17/1.17.1/1.18/1.18.1?
If you can't, I will find a substitute.
Thank you!

I have no plans of re-writing this mod for any not-forge modloaders, as it is not a trivial thing to do, anyone else is free to try to do such a re-write, most of the code is actually in thutcore rather than this one.
My suggestion would be to try to use forge instead, as this is already on 1.18.1 for forge.


(vscode-icons) Update according to the guidelines

@gep13 Do you want to push this? Otherwise you can remove the Push required label

@pascalberger @AdmiringWorm sorry, I have been out of the loop on this repo, still playing catch up with a few things.  I thought there was now functionality to push individual packages based on a commit message.

Yes this works, but don't know if it works also with manual packages & package fix notation? @AdmiringWorm

@pascalberger let's give it a try 😄

@gep13 , @pascalberger
I'm sorry, I never noticed it was a manual package.
Yeah, the functionality to push package have been present for quite some time I belive.
Just add [PUSH packageName] to the commit title.

Just a note on that though, it won't use package fix I believe.
It will just push the package as is.

@AdmiringWorm So for pushing manual packages with package fix notation we need to update the version in the source first and then push it with the commit title syntax?

@pascalberger
Yeah, I believe so.

Pushed with https://github.com/chocolatey/chocolatey-coreteampackages/commit/79c4fb81c60a7f9b05f9e241831ec3a896c7b900

@pascalberger said...
So for pushing manual packages with package fix notation we need to update the version in the source first and then push it with the commit title syntax?

@AdmiringWorm said...
Yeah, I believe so.

And I think that this makes sense.  Since it is just a push, there is no updating of files in the repository, so source files should be made to be the required end result, prior to pushing.


Update windows-server.md

Docs Build status updates of commit 3947e68:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified commit because branch saraclay-patch-1 has been deleted or has been force pushed: fatal: Couldn't find remote ref saraclay-patch-1

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


timers plugin: Improve imbued heart detection

As is the case with other graphics-based timers, the imbued heart timer
will not fire if other graphics animations are triggered (such as those
created when fighting the Dagannoth Kings). To add this timer more
reliably, this commit will add the timer when a Magic stat boost occurs
which is large enough that it can only be triggered by the heart after
clicking the heart.
Because the heart's boost scales with the player's level, it gives an
equal boost to the Magic essence and Magic potion boosts, depending on
the base magic level. To account for this, it will only be applied if
the user's base magic level is high enough to assuredly identify that a
potion was not used to trigger the boost.
Closes #3516

Could this give a false positive between levels 40-49 if a spicy stew gives a +5 boost?

As-is, it can only do that if you have an imbued heart which you click at the same time. Even when I wrote this the first time around (without the click logic--which had false positives at CoX) that wasn't a case I bothered handling since ~0 users will ever boost their combat stats with spicy stews.

After some Discord discussion, I've removed the lower bound for level checking since all ambiguous cases should be properly handled by the imbued heart click check.

I've noticed that even when the animation is overridden, the sound effect of the imbued heart plays reliably. Could this be used to improve the detection of imbued heart usage?

This was added once before in 45c5df3379767146f91e1e4a1f48d9692599a1d4 and then reverted without a reason in 967fadf59d8808dd84f4a5f4c441031fe8bba4bb by you - do you know why this was done?

Yes. The original PR which added this feature made the false assumption that you could only ever achieve a boost equivalent to that of the imbued heart with the heart itself. Chambers of Xeric overload potions combined with some combination of Xeric's aid and revitalization and/or overload re-boosts can cause you to end up at the same boost amount which caused a lot of erroneous timers to appear for players doing raids. This PR addresses that by ensuring an imbued heart is actually clicked recently before the boost.

Does this create the timer twice then? Is there any reason to keep the existing graphic check?

This change would cause the timer to be added by both the stat change and graphic change events. It's probably safe to remove the graphic change event trigger, but I don't own an imbued heart so I can't say with confidence that would work.

It does seem to add two
2020-11-21 19:14:08 [Client] DEBUG n.r.c.plugins.timers.TimersPlugin - Creating timer IMBUEDHEART
2020-11-21 19:14:08 [Client] DEBUG n.r.c.u.o.infobox.InfoBoxManager - Adding InfoBox Timer(startTime=2020-11-22T00:14:08.278379200Z, endTime=2020-11-22T00:21:08.278379200Z, duration=PT7M)
2020-11-21 19:14:08 [Client] DEBUG n.r.c.plugins.timers.TimersPlugin - Creating timer IMBUEDHEART
2020-11-21 19:14:08 [Client] DEBUG n.r.c.u.o.infobox.InfoBoxManager - Removed InfoBoxes for filter net.runelite.client.plugins.timers.TimersPlugin$$Lambda$1519/0x000000080086c040@2cb522e from net.runelite.client.ui.overlay.infobox.InfoBoxOverlay@29f03df0
2020-11-21 19:14:08 [Client] DEBUG n.r.c.u.o.infobox.InfoBoxManager - Adding InfoBox Timer(startTime=2020-11-22T00:14:08.281383700Z, endTime=2020-11-22T00:21:08.281383700Z, duration=PT7M)

I've revisited this and updated it to remove the graphics trigger for the timer, and to allow partial boosts and boosts from debuffed stats to trigger the timer.

I've revisited this and updated it to remove the graphics trigger for the timer, and to allow partial boosts and boosts from debuffed stats to trigger the timer.


733: Merge request notification resolution

Pretty simple PR. Sets any merge request notifications to is_resolved=True when that request is approved/denied. Implemented via the handy pre-existing method merge_request_cleanup and a new class method on IndividualMergeRequestVote. Test coverage handles both merge requests and merge complete notifications.
No database or API changes, just an iteration over pending merge request notifications whenever one is resolved (which shouldn't be terribly often). That iteration happens because the data we want to filter on notification objects is inside the message_values dict.

but you should check the testing. Codecov says that you're not testing the two new methods

@hwindsor I'm a bit confused by that. Both methods are called (one calling the other) during the test. The asserts at the end of individuals/resources/test_merge.py::test_get_data_and_voting confirm the method was run, and I had some printouts while developing further confirming it (the last commit here was removing one).
Do we just ignore codecov in this case or is there some way to convince it otherwise?

I looked into the code coverage problem.  It's different from what I thought it was.  It turned out the test was skipped:
https://github.com/WildMeOrg/houston/runs/5223583774?check_suite_focus=true#step:10:2109

Our tests didn't print out the reason for tests being skipped so I added a commit to show skipped reason.
The reason this test was skipped is because we didn't have celery running in the github testing CI.  Which I now fixed in another commit.
This should fix code coverage for resolve_sent_notifications.

Awesome, thank you @karenc !


CodeCov would be reduced by current solution for issue #153

In Issue #153 a few lines of code were commented out to keep CodeCov at 100%. These lines contain a try-catch block to catch a possible LearningError and PredictionError for errors that we already cover. It may be possible that we didn't cover every Error and these would still be thrown. We cannot think of a case and can't write tests for these as a consequence.
Either we remove these lines completely or we take into account that CodeCov is not at 100% anymore.
Link to the PR: #355

We could implement dummy models that ust always raise the required exception.
E.g. a ValueErrorOnFitClassifier that will always raise a ValueError when calling fit (or predict) on it, then a ValueErrorOnPredictClassifier that only raises one when calling predict etc.

We could implement dummy models that just always raise the required exception. E.g. a ValueErrorOnFitClassifier that will always raise a ValueError when calling fit (or predict) on it, then a ValueErrorOnPredictClassifier that only raises one when calling predict etc.
Then use one of those dummy models whenever we can't cover some line using the normal ones.

This solution will be implemented in #355 so this issue is irrelevant


fix: add notification support for IJSONRPCLog

fixes #31

:tada: This PR is included in version 1.1.15 :tada:
The release is available on:

GitHub release
1.1.15
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Adding Move programming language book to the list of books

What does this PR do?
Add resource
For resources
Move is a safe and reliable language originally created by Diem. You can read language white paper on Diem developers website.
This book is a collection of all the information about Move language created by the team at Mysten Labs.
Why is this valuable (or not)?
The Move programming language is used currently as a Smart Contract language on Aptos and Sui blockchains, and is in great demand
How do we know it's really free?
The creators of the Move book website use GNU general public v3.0 license

I committed the changes @Thenlie

@baja-kralj Formatting looks good to me. Just a question of if we want to add this new language which I will defer to the other reviewers.

In decide where to put a resource that we want to list, such as this one, we have 3 considerations.

where are people who should be interested in the resource most likely to discover it?
Where will someone most likely to try to put it 6 months from now and discover it to be already listed
Will we be stuck with an "orphan category

Answers:

in the "blockchain" subject area.
in a new  "Move" language area. (because new users ignore the advise to use the search facility)
possibly

My preference is to put it in "blockchain" (#1), then relocate it when more resources appear. A good argument can be made for #2, but a clincher would be if there's already content related to Move in the blockchain area.
Please consider the 3 criteria, and we'll merge based on your considered recommendation.

I only considered "by programming language" list, because it is a book about the programming language, for subject it should go in "blockchain", but I don't see Solidity books referenced in "BY SUBJECT" list. @eshellman

Solidity has 2 books and 6 courses. What is your considered recommendation?


Jenkins-X with Helidon

Create a guide describing how to use Jenkins-x as a CI/CD for a Helidon service.

Would this be different to using Jenkins-x with a non-Helidon service?

I don't think there is anything special to be done on Helidon for this. I already use Jenkins-X with my Helidon projects. The changes you do are all bespoke depending on your pipeline

Closing this issue as there is nothing specific we need to do for Jenkins X.
Feel free to re-open with a detailed use case + expected support from Helidon, if the above statement is not true for you.


Changing procedures break locked gecko entities

Hey there, I stumbled upon a problem with gecko entities [plugin 4.4, mcr EAP 2023.1.04717, forge 1.19.2 (probably also for 1.18.2)]
When I attach a procedure to an animated entity's trigger in the entity triggers section (like on entity tick update, or any other), lock the entity's code, and change something in the procedure, there occurs an error saying that the entity could not compile with executing the procedure.
Example when changing on entity tick update procedure:
error: method execute in class HoverScooterOnEntityTickUpdateProcedure cannot be applied to given types;
HoverScooterOnEntityTickUpdateProcedure.execute(this.level, this.getX(), this.getY(), this.getZ(), this);

How to recreate:
Make an animated entity, create a procedure, e.g. on entity tick update, and add e.g. "strike lighting at x y z". Lock the entity's code, and try to change the procedure to "strike lighting at x position of event target entity, y, z"

This is not a geckolib error. This is just a case of arguments you require no longer matching the arguments provided.

For example, adding an entity to the procedure won't update the entity's code to provide it since its locked.


Convert Kapp-controller's own deployment to use ytt schemas

Describe the problem/challenge you have
they're clean, sleek and modern
Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX.]
Anything else you would like to add:
This work could be seen as peeling of a pre-requisite for : https://github.com/vmware-tanzu/carvel-kapp-controller/issues/774
so if it doesn't get done as a standalone work item then it will get done with #774 is tackled.

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Thank you @joe-kimmel-vmw for submitting this issue!  We appreciate your contributing to our community.

will be done as part of https://github.com/vmware-tanzu/carvel-kapp-controller/pull/926


Question: When Payment Fails it return only Token, not payment

Hi Guys,
My question is pretty simple when I create payment using $payment->create(Paypalpayment::apiContext()); it returns me a approval link and payment id which i store in my db.
I was expecting when user redirects back irrespective of failure or success, I will receive payment id which I can match with the database entry, instead of payment id, I am getting token https://i.imgur.com/cJMQ0t3.png which I don't get as one of the parameters while creating the payment. Now, how to match which payment is failed or succeeded or I am missing something?
Thanks

@webreinvent actually it does send the token and paymentId as query params. check this video https://www.youtube.com/watch?v=F67YuGKm220


[DO NOT MERGE] PP-3095 Added run-with-chamber.sh implementation and associated script to run the app

WHAT
Modification to run publicauth using Chamber, but skips the database migration logic (for now).
Do not merge. Experimental.

no longer necessary


Update index with 2 new links

@tifa64 Thanks for your contribution :raised_hands:
I know it could be a bit confusing :sweat_smile:
But we will not use the list in the sidebar.
It's just for projects that list or aggregate other projects (the same as Awesome Arabic Speakers itself).
So feel free to close this PR for now.


Google maps URL not getting parsed due to comma

I have this link from google maps - "http://maps.google.com/?q=28.6079884,77.0891879"
I use react-native gifted chat to open the link on clicked but the problem is when I use parsed method the URL I get is - "http://maps.google.com/?q=28.6079884"
Which is wrong.
Let me know what should I do to get the full URL.

Shipped in https://github.com/taskrabbit/react-native-parsed-text/releases/tag/v0.0.22 ! @raazatul7 -- please let me know if you have any issues.


Add tags component

Closes #2417

Coverage decreased (-0.008%) to 72.525% when pulling 8f17ed5edd288652858a3ee6e412583b33abddfa on eatonphil:add-tags-component into 83504c48049c21a7aa9ab91db643acc557fbb270 on linode:develop.

The tags should render after you hit save.  I had to reload the page to see the tags.
Additionally, after removing the (Lish SSH Key) tags I could no longer add new Lish SSH Keys.  (Each PUT sent authorized_keys:[])

Coverage decreased (-0.008%) to 72.01% when pulling 197adf66dc1d2fe918741723e40fa858326ac11c on eatonphil:add-tags-component into a3b51087967a2964b2000d97e7492d8bd75577fe on linode:develop.


ef core question re: reversing a custom migration

Describe what is not working as expected.
this is a QUESTION ONLY
If you are seeing an exception, include the full exceptions details (message and stack trace).
Exception message:
Stack trace:

Steps to reproduce
Include a complete code listing (or project/solution) that we can run to reproduce the issue.
following the example in
https://www.ryansouthgate.com/2017/05/22/entity-framework-core-custom-migrations/
i was able to create a CustomMigration.cs file that looked like ryan's code in:
https://github.com/ry8806/Blog-EFCore-CustomMigration/blob/master/EFCustomMigrations/Db/CustomMigrations/CustomerLocationMigration.cs
   [DbContext(typeof(ApplicationDbContext))]
    [Migration("CustomMigration_MyAdditions")]
//currently, with only one other migration (an init migration)
//this migration gets correctly executed AFTER that init migration
    public class MyAdditionsMigration : Migration
    {
        protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.Sql("..add a Postgresql check constraint to a created table.");
        }
       protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.Sql("..reverse of what was done in Up.; for example drop the Postgresql check constraint for a created table if the constraint already exists");
        }
}

when i did the following in the command prompt:
dotnet ef migrations add init
dotnet ef database update
Ef Core created a  _init.cs  and the other expected designer and snapshop files (so a total of just 3 files).
the _init.cs  contains migration code that did not include the migration code in my CustomMigration.cs file, but the database update  did create the Postgresql check constraint I needed to add to one of my tables, so that's my proof that the dotnet ef commands i executed DID PICK UP MY CUSTOM MIGRATION.
MY QUESTION:
Suppose I want to REVERSE my custom migration, what CLI command or other means would do this for me?
dotnet ef migrations remove did not do it for me.
Partial code listings, or multiple fragments of code, will slow down our response or cause us to push the issue back to you to provide code to reproduce the issue.
Console.WriteLine("Hello World!");

Further technical details
EF Core version: 2.1.1
Database Provider: Npgsql.EntityFrameworkCore.Postgresql
Operating system:
IDE: Visual Studio 2017 15.7.7

so if the only other migration is an "init" migration, and the "last migration" is my custom migration, i can reverse my custom migration by doing:
dotnet ef database update init
so my FOLLOW-UP QUESTION IS:
the approach discussed in ryan's article (referenced in my first post) puts custom migration class file(s) under a CustomMigrations folder in the project containing the ApplicationDbContext.cs file.
i did not have to do any kind of
dotnet ef migrations add custom_blah
for my custom migrations.
a "dotnet ef database update" just seems to pick up all my custom migrations and these custom migrations seem to execute as the last set of migrations.  and also, apparently, by naming my custom migrations "systematically", i can get them executed in the order i want (migration named [Migration("CustomIShouldBeFirst")] executes before [Migration("CustomIShouldBeSecond"], etc).
WHAT IF I want to reverse only one or a few of my specific custom migrations?
How to do this ??
What's the suggested tactic or approach???
Thanks for helping!

Here are the docs on Removing and Reverting EF Core Migrations. To rollback all migrations (or go back to the initial database), use 0 as the migration name.
You can also undo the changes of a previous migration by creating a new migration. This approach is better in team environments where re-writing the migrations history (e.g. removing a migration) will cause problems for other team members.

Thanks for replying.
I think your advice to just write another migration to reverse my own custom migrations might work.
I wonder if I could ask follow-up questions just to satisfy my own curiosity.
The original problem:
There are certain things EF Core cant do for me that requires me to go down the custom migration / custom sql path.
These custom migrations would always have to be executed last to make sure the tables I'm adding constraints to have been created.
Because I already know what these custom migrations would have to do, I write them in advance by creating subclasses of Migration, annotating them with the DbContext and Migration attributes (e.g., [DbContext(typeof(AppDbContext))] and [Migration("CustomMigrationNameForEFMigrationsHistoryTable")], and putting them in a CustomMigrations folder inside my data project that contains my AppDbContext class, etc.
The name I'm giving to the Migration attribute does not conform to the expected pattern of xxxxxxxxxxxxxx_name where the xxxxxxxxxxxxxx represents a timestamp, and consequently, this could be the reason why i cannot refer to my custom migrations by name.
So I was wondering:
Could I utilize some sort of naming trick that would enable me to refer to my individual custom migrations by name, like so:
yyyyyyyyyyyyyy_myfirstcustommigration
zzzzzzzzzzzzzz_mysecondcustommigration
where yyyyyyyyyyyyyy and zzzzzzzzzzzzzz are guaranteed to always be greater than the last timestamp stored in the _EFMigrationHistory table (maybe they always start in the year 2058xxxxxxxxxx)?
would this trick then allow me to refer to my custom migrations by name such as myfirstcustommigration and mysecondcustommigration :-)
thanks for tolerating my questions :-)

Why do you want to keep these migrations last? The normal workflow is just to edit the migration that adds the table (or immediately add another migration) that adds the additional constraints.
Think of it like using version control with your source code. You don't typically try to keep a specific changesets/commits at the tip. It's incredibly tedious and usually unnecessary.


 Is this problem reproducible in latest version?
https://code.visualstudio.com/Download

i also have the same problem vscode version 1.59.0 and this only happen when you are trying to close the app from another application

/gifPlease

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

even the insider build is affected

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

terminal log
Developer Tools console
when i clicked the button to close vscode nothing appeared inside the terminal,
i guess this is what should appear inside the terminal when i close vscode
[main 2021-08-07T14:30:53.244Z] Lifecycle#window.on('close') - window ID 7
[main 2021-08-07T14:30:53.244Z] Lifecycle#unload() - window ID 7
...
[main 2021-08-07T14:30:53.260Z] StorageMainService: closed workspace storage<PHONE_NUMBER>651)
[main 2021-08-07T14:30:53.266Z] Lifecycle#onBeforeCloseWindow.fire() - window ID 7
[main 2021-08-07T14:30:53.267Z] IPC Object URL: Removed channel vscode:4a441369-4670-406f-aba8-cb50dc18a729.
[main 2021-08-07T14:30:53.268Z] Lifecycle#window.on('closed') - window ID 7

Strange, I am not seeing anything obvious in those messages.
How about closing the window through the command palette in VSCode itself:

closing vscode from the command palette works

@deepak1556 this somewhat sounds like a possible Electron 13 regression to me then, maybe with the implementation of the native window buttons?

@Spinderman please share the gif following the steps at https://github.com/microsoft/vscode/issues/130286#issuecomment-894610877 that shows how the application is launched and what steps are performed before quitting the application. Its hard to understand the setup from your previous screenshot. Looks like you are focused on a different application while trying to quit the vscode application but then again that works on my machine, so it would be easier to understand if you can visualize the complete steps. Thanks!


Not consider zero(0) in data set.

If you have data like [3,0,1,2] and when you click to show the drop down. It shows only [3,1,2].

Now fixed in v3.0.1


initrd: support tar entries with non-null prefix field

This allows initrds to have files with absolute names longer than 100 characters

Merged, thank you!


remove_dead_code: reimplement find_used_variables

There is a fixpoint computation in module https://github.com/usubalang/usuba/blob/main/src/optimization/remove_dead_code.ml#L31 which out to be a (straightforward?) static analysis.

Also, why do we add variables in the lhs when one variable on the lhs is used?
If x is used in (x, y) = (42, 54), that doesn't mean that y is used too.


Tidy up CMakeLists.txt

CMakeLists.txt should be cleaned up using more modern CMake functionality, including adding installation support for easier vcpkg integration (#22) and adding relevant target_compile_features(...) (#29).

Closed by #34


Update Bluetooth.md

Added link (UWP-RFCOMM) as well as changed BT Sig link for GATT to inhouse one (UWP-BLE)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/connect-your-device/Bluetooth.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Providing a later more detailed update


fix indentation edge case in #763

Hi @siowyisheng I traced through the code. The solution is a simple fix to simply remove pre v6 functionality of auto-appending brackets for code such as below. Since the assumption is not to have backward compatibility, then the following block of code should have indentation given by user already instead of assuming indenting once on user's behalf.
for n from 1 to 10
echo `n`

This fix is tested to be working for -
for m from 1 to 3
    for n from 1 to 3
        echo `m`,`n`

and
for n from 1 to 20
    if (a==1)
        for p from 21 to 40
            echo `n` - `p`

For your review if this change works for the earlier test cases you used for this feature.

tested and working for the 6 cases in #746 . merged.


Update yeet-delete-repeat.mdx

Minor typo fix in the first post aside.
Great post @jlengstorf! Ty 👍

thank you!


Document how to start Stargate v2 APIs in non-Docker deployments

We need to update the installation docs to describe how to start the Stargate v2 API services. The documents describe how to install/run the coordinator via the starctl script, we need something similar for each API.
This depends on resolution of the following issue:

https://github.com/stargate/stargate/issues/2380

In particular, we have had multiple instances of developers who are familiar with Stargate v1 attempting to upgrade to Stargate v2 by simply downloading only the coordinator. When they attempt to use one of the APIs, they get "404 not found" errors because they have not started the API.
These sections need to be updated:

3.x: "Stargate on virtual machine or bare metal
4.0: Stargate on virtual machine or bare metal
DSE: Stargate on virtual machine or bare metal

It's important that users are made aware that there are separate scripts for starting each API. These scripts are defined in the repo at the following locations:

start-restapi.sh
start-docsapi.sh
start-graphqlapi.sh

The scripts are also included in a zip file for each API, which is included as part of the release contents. See for example: https://github.com/stargate/stargate/releases/tag/v2.0.8.
It's also important to note that starting the APIs requires Java 17. It is possible to start APIs on the same VM as the coordinator, but you'll need to have both Java 8 and Java 17 installed, and set JAVA_HOME appropriately before calling starctl (to point to Java 8), vs the start-*api scripts (to point to Java 17).


ItemEntity goes out of sync with client

An item entity likes to go out of sync with the client

sometimes appearing in a location but not being able to be picked up (normally after velocity applied)
after being alive for a while the item entity likes to go one block down into the ground (likely sync cooldown)

Can confirm, I was able to fix this by setting custom syncronization cooldown to 1 day 💀

Can confirm, I was able to fix this by setting custom syncronization cooldown to 1 day skull

I assume you were only able to fix the bottom thing

I assume you were only able to fix the bottom thing

I fixed both things, but before I was able to pick up an item without actually seeing it


How to use concurrent option after migrating from 8.x to 9.x?

After advanced options got deprecated, how to properly implement "concurrent": false in 9.x version?

I don't think it's possible, but we would love to have that ability back. Forcing concurrency introduces problems for us in our large TypeScript repo where not all tasks can be run in parallel.
@okonet What are the chances this can be re-introduced? v9.x is basically unusable for us 😢

You can take the lead on this one and create a PR with your proposal. We can discuss it there. We won’t add advanced config format back so it should be done differently. Maybe a CLI flag or something like that?

@okonet https://github.com/okonet/lint-staged/pull/742 initial pass here. Let me know what you think :)


Parameter sets for ML methods

@yanxon
I have resolved the conflicts. Please update your repo.
For the next step, please implement three sets of ml parameters as we discussed.
say
-light
-medium
-tight

Implemented

For the light set,
            grid = {'light': {"est__learning_rate": [0.1], "est__n_estimators": [1000], "fs__threshold": [0.0]},

Does these algorithm provide default parameters. I thought it is better to use those default parameters, instead of using some arbitrary parameters defined by ourselves.

@yanxon
It is also good to store these parameter sets in a separate file, instead of inserting them to method.py
I suggest we create a single file called default_sets (.yaml or .json) for algos.
yaml seems to be good option for this.

@yanxon  I have updated my plan regarding the rough idea of ML pipes and the definition of three sets of parameters.

            self.read_dict()
            if self.level in self.parameters_level:
                self.SGD_grid = grid[self.level]
            else:
                self.SGD_grid = self.dict
            search = GridSearchCV(SGDRegressor(tol = 1e-5), param_grid = self.SGD_grid, cv=10)
            search.fit(self.X_train,self.Y_train)

            best_penalty = search.best_params_['penalty']
            best_alpha = search.best_params_['alpha']
            best_learning_rate = search.best_params_['learning_rate']

            best_estimator = SGDRegressor(tol = 1e-5, penalty = best_penalty, alpha = best_alpha, learning_rate = best_learning_rate)

Looks like you are using this scheme for every algo. Why not make it more universal?
There should be a universal way to do so.
Besides: tol = 1e-5, cv=10 should go to yaml file. We should put all parameters to yaml file.


Added Sentence

Hi,
I added sentence players via MDT if you want to add it :)

👎 uses ghmattimysql

You can convert it if you like, it's not hard. 👍

THX* I'll convert it!


Changes to allow having stories in classpath with enconding different than UTF-8

We have our project encoding in ISO-8859-1 (sources and resources), and change it to UTF-8 is not an option at the moment. This change allows clients of LoadFromClasspath define their stories enconding, while maintaining UTF-8 as default.

http://jbehave.org/how-to-contribute.html

On 3 Sep 2015, at 13:24, donsenior<EMAIL_ADDRESS>wrote:
We have our project encoding in ISO-8859-1 (sources and resources), and change it to UTF-8 is not an option at the moment. This change allows clients of LoadFromClasspath define their stories enconding, while maintaining UTF-8 as default.
You can view, comment on, or merge this pull request online at:
https://github.com/jbehave/jbehave-core/pull/98
Commit Summary
Test fails on Windows because of line break representation (CRLF vs LF)
Let the client choose their stories encoding
Added javadoc to clarify the use of UTF-8 as default enconding
File Changes
M jbehave-core/src/main/java/org/jbehave/core/io/IOUtils.java (23)
M jbehave-core/src/main/java/org/jbehave/core/io/LoadFromClasspath.java (26)
M jbehave-core/src/test/java/org/jbehave/core/reporters/CrossReferenceBehaviour.java (10)
Patch Links:
https://github.com/jbehave/jbehave-core/pull/98.patch
https://github.com/jbehave/jbehave-core/pull/98.diff
—
Reply to this email directly or view it on GitHub.

Jira issue created: JBEHAVE-1120


How to automatically, CQRS handler registration in ASP.NET Core ?

hii Jason,
Thank for this example architecture,
i have question, How to automatically register our handler in startup?
I read this article [https://dejanstojanovic.net/aspnet/2019/may/automatic-cqrs-handler-registration-in-aspnet-core-with-reflection/]
and follow his step. but I have not succeeded
result error:
{"error":["Object reference not set to an instance of an object."],"stackTrace":"   at SmmCoreDDD2019Accounting.WebUI2.Controllers.DataPerusahaanController.CreateStructureOrganization() in C:\\Users\\Dermawan Gasali\\source\\repos\\SMMCodeDDD2019Accounting\\SmmCoreDDD2019Accounting.WebUI2\\Controllers\\DataPerusahaanController.cs:line 21\r\n   at Microsoft.AspNetCore.Mvc.Internal.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)\r\n   at System.Threading.Tasks.ValueTask1.get_Result()\r\n   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeActionMethodAsync()\r\n   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeNextActionFilterAsync()\r\n   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)\r\n   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)\r\n   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()\r\n   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextExceptionFilterAsync()"}`
thanks

i used this  `services.AddMediatR(typeof(Startup).GetTypeInfo().Assembly);' for manually register in startup.cs

I really like Scrutor project. It's a simple extension for DI.
      var applicationAssembly = typeof(XYZClass).GetTypeInfo().Assembly;

      services.AddMediatR(applicationAssembly);
      services.Scan(scan =>
        scan.FromAssemblies(applicationAssembly)
          .AddClasses(classes => classes.AssignableTo(typeof(IPipelineBehavior<,>)))
          .AsImplementedInterfaces()
          .WithTransientLifetime());

Wait wait... you don't need to do anything.

If you're using ASP.NET Core then you can skip the above configuration and use MediatR's MediatR.Extensions.Microsoft.DependencyInjection package which includes a IServiceCollection.AddMediatR(Assembly) extension method, allowing you to register all Handlers and Pre/PostProcessors in a given assembly.

https://github.com/jbogard/MediatR/wiki#aspnet-core

Wait wait... you don't have to to do anything.

If you're using ASP.NET Core then you can skip the above configuration and use MediatR's MediatR.Extensions.Microsoft.DependencyInjection package which includes a IServiceCollection.AddMediatR(Assembly) extension method, allowing you to register all Handlers and Pre/PostProcessors in a given assembly.

https://github.com/jbogard/MediatR/wiki#aspnet-core

yes thank you.
i solved this using    var assembly = AppDomain.CurrentDomain.Load("SmmCoreDDD2019Accounting.Application");             services.AddMediatR(assembly);


Mark unsupported-decls-in-cxx  as REQUIRES: distributed

The test tries to import Distributed, but it will fail to pass if the compiler/stdlib has not been built with experimental distributed support.

@swift-ci please test Windows platform

@swift-ci please test Windows platform


Use install_only archives for managed Python installations

These have a significant size reduction and are automatically prioritized to the optimized version for each platform, see https://github.com/astral-sh/uv/pull/4775#discussion_r1666890324
What are the downsides to using these? Rye does not appear to use them. I don't think we're using any of the build metadata.

Rye added support for toolchain installation without build info in https://github.com/astral-sh/rye/pull/917. It still fetches thefull version and then renames the inner install directory to the final target, discarding the build info in the process. I think it is possible for uv to use an install-only archive, thereby reducing the fetch size.

This makes sense.

Although it seems like you can't get PGO and/or LTO with install-only.

Oh nevermind, I misunderstood. They're already optimized. Let's use them!


Propagate row_major / col_major for certain view's

When "viewing" a row_major xcontainer like this:
xtensor<double, 4> a;
view(a, 1, 2, all(), all());

we can trivially propagate that the view is row major as well. This information will be used by the assign loops to speed up assignments / copies into containers.
This came up during the perf runs for GooseFEM.

This will become quite cool: the xview doesn't even have to own it's shape & strides because it just needs an offset for the original shape/strides

For the generic case we could also switch to something like a tuple based shape:
so that a list of slices like such would become a tuple like this:
all, newaxis, all, int -> size_t&@0, integral_constant<size_t, 1>, size_t&@1, int

etc... but this would require a lot of refactoring + we could not use the shapes as we do right now with begin/end iterators etc.

merged in #1039


java.lang.OutOfMemoryError when loading a large DNS Block List.

I'm trying to use this list: https://raw.githubusercontent.com/hagezi/dns-blocklists/main/domains/pro.txt Modify AdBlockerRepositoryImpl to avoid comments:
....
final response = await _getDataWithCache(_url);
 final results = <Host>[];
 for (final e in LineSplitter.split(response)) {
    if (!e.startsWith('#')) {
     final host = Host(authority: e);
     results.add(host);
    }
 }
return results;

The list loads, but when I try to use it to block ads, the app closes and I receive:
W/flutter.example( 6170): Throwing OutOfMemoryError "Failed to allocate a 16 byte allocation with 7704 free bytes and 7632B until OOM, target footprint 201326592, growth limit 201326592; giving up on allocation because <1% of heap free after GC." (VmSize 18446416 kB) E/AndroidRuntime( 6170): FATAL EXCEPTION: main E/AndroidRuntime( 6170): Process: com.islamdidarmd.example.adblockerwebview.flutter.example, PID: 6170 E/AndroidRuntime( 6170): java.lang .OutOfMemoryError: Failed to allocate a 16 byte allocation with 7704 free bytes and 7632B until OOM, target footprint 201326592, growth limit 201326592; giving up on allocation because <1% of heap free after GC.
E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValueOfType(StandardMessageCodec.java:381) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValue(StandardMessageCodec.java: 340) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValueOfType(StandardMessageCodec.java:434) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValue(StandardMessageCodec.java:340) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValueOfType(StandardMessageCodec.java:434) E/AndroidRuntime( 6170) : at io.flutter.plugin.common.StandardMessageCodec.readValue(StandardMessageCodec.java:340) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValueOfType(StandardMessageCodec.java:424) E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValue(StandardMessageCodec.java:340)
E/AndroidRuntime( 6170): at io.flutter.plugin.common.StandardMessageCodec.readValueOfType(StandardMessageCodec.java:434)

I also tried adding AndroidManifest.xml :
android:hardwareAccelerated="true"
android:largeHeap="true",

but I still get the same error, it seems flutter_inappwebview, _inAppWebViewOptions?.crossPlatform.contentBlockers, is not optimized to handle large lists.

Hi thank you for trying this out raising this issue. I will investigate more about this.
If flutter_inappwebview is indeed the one what is causing the issue, I might have to use native webview for this. Implementing own webview will take time. Meanwhile, can you provide a minimum reproducible sample?


Apply new limits to the splat min/max

For the giant splats that stick out from surfaces and edges, a useful option would be the ability to apply local limits on the min/max size of each splat.  Some of the splats generated by Poly.cam are incredibly large (10cm or more), which will be very efficient when they're orientated correctly, but is a major hassle when they are not.
This suggestion is to add some edit boxes/sliders showing the current min/max limits in use, and the ability to adjust them for the current selection. This would probably cross over with another suggestion about rescaling the model.
https://github.com/playcanvas/super-splat/pull/31

This is largely possible using the SPLAT DATA histogram panel and transform tools.


Resolve warnings found in Stratis.SmartContracts.IntegrationTests

https://app.clickup.com/t/1qzu02x

Perhaps @rowandh should comment about whether the modifications to the test contracts affect the validity of the tests in any way. They probably don't, but it is good to be sure.

Both contracts appear to be unused, so we could just remove them.

Seems at least one of the contracts is being referenced by a test case:

Ah, missed that one, better keep the test then. I'm not sure of the behaviour if using new so probably better just to rename the Transfer struct.


Getting ZeroDivisionError when using galai module

I keep getting the ZeroDivisionError with the galai module
import galai
model = galai.load_model("mini", num_gpus = 1)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "███/myconda/condaGA/lib/python3.7/site-packages/galai/__init__.py", line 39, in load_model
    model._load_checkpoint(checkpoint_path=get_checkpoint_path(name))
  File "███/myconda/condaGA/lib/python3.7/site-packages/galai/model.py", line 69, in _load_checkpoint
    offload_state_dict=True
  File "███/myconda/condaGA/lib/python3.7/site-packages/accelerate/big_modeling.py", line 358, in load_checkpoint_and_dispatch
    low_zero=(device_map == "balanced_low_0"),
  File "███/myconda/condaGA/lib/python3.7/site-packages/accelerate/utils/modeling.py", line 370, in get_balanced_memory
    per_gpu = module_sizes[""] // (num_devices - 1 if low_zero else num_devices)
ZeroDivisionError: integer division or modulo by zero

But if I use the transformers module it works perfectly on GPU

Hi @phineas-pta, can you check with galai version 1.1.0?

thank you, the new versions seems to work nicely but i'm still sticking to transformers


remove postinstall script

Description
Removes postinstall script

@omar-dulaimi any change we can get this update published to NPM?

@pianomansam Sorry about that. Released now.


Migrate to pydantic v2

The infisical python sdk is still using pydantic v1 even though v2 came out months ago.
The migrate and auto-migrate instructions are here: https://docs.pydantic.dev/latest/migration/

Thanks @gaby. I'll do this soon when I've time — It's quite hectic at the moment 😄

Thanks!


TP-846 Geographical area detail view throws error for Taiwan

Why
GeographicalMembership.other() raises a 500 ValueError complaining that 'Region TW is not part of membership geo_group__sid=168, member__sid=102'. This is because in memberships.jinja GeographicalArea.get_current_memberships() filters by 'member__sid', which returns both Taiwan the region AND country. This means that later in the template .other() is being called on the wrong membership.
What

Adds filtering on member__area_code to get_current_memberships method
Adds test for this scenario in geo_areas.models

Codecov Report

Merging #386 (5caf4ba) into master (a513741) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   91.59%   91.22%   -0.38%
==========================================
  Files         266      274       +8
  Lines       14812    16247    +1435
  Branches     1121     1317     +196
==========================================
+ Hits        13567    14821    +1254
- Misses       1043     1192     +149
- Partials      202      234      +32

Impacted Files
Coverage Δ

geo_areas/models.py
91.02% <ø> (ø)

geo_areas/tests/test_models.py
100.00% <100.00%> (ø)

workbaskets/tests/test_admin.py
92.15% <0.00%> (-7.85%)
:arrow_down:

workbaskets/admin.py
92.45% <0.00%> (-7.55%)
:arrow_down:

common/util.py
83.47% <0.00%> (-0.31%)
:arrow_down:

workbaskets/validators.py
100.00% <0.00%> (ø)

footnotes/tests/test_xml.py
100.00% <0.00%> (ø)

commodities/tests/test_util.py
100.00% <0.00%> (ø)

workbaskets/tests/test_views.py
100.00% <0.00%> (ø)

common/tests/test_serializers.py
100.00% <0.00%> (ø)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a513741...5caf4ba. Read the comment docs.


Update OpenLineage CI to publish to artifactory #89

Codecov Report

Merging #109 (03c4d78) into main (71925a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   89.27%   89.27%
=======================================
  Files          13       13
  Lines         541      541
=======================================
  Hits          483      483
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71925a8...03c4d78. Read the comment docs.

I've tested publish job, it works, I see snapshots in repo.
I've changed back config to publish only on main


Cannot right click .cmd file and "Run as Administrator".

I think the app should be running as administrator, so it can launch other things as administrator.   This has always been what prevents me from moving to the app - I have scripts that take physical drives on and offline, and network drive mappings that are created and destroyed in my scripts requiring administrative access.  I cannot run them from Files.  I have to use a different tool (OneCommander) to have a dual-pane and the ability to execute things.
If you fixed this I would bring several computers over.

Merging with #6333. Will be included in Files v2.3.


[SPARK-26440][WEBUI] Show total CPU time across all tasks on stage pages

What changes were proposed in this pull request?
Task CPU time was added since SPARK-12221. However, total CPU time across all tasks is not displayed on stage pages. This could be used to check whether a stage is CPU intensive or not.
This PR lets total CPU time across all tasks showed on stage pages.
How was this patch tested?
Manually tested locally.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #100440 has started for PR 23379 at commit d20252f.

Test build #100440 has finished for PR 23379 at commit d20252f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100440/
Test PASSed.

This change is so clearly.

This looks good!!! usefull and clear

Can one of the admins verify this patch?


⚠ GitLab Server has degraded performance

In a86f1a5, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6341 ms

Resolved: GitLab Server performance has improved in 3fd2516.


Update tonic, and auto-generate feature list

This PR changes the xtask script to automatically generate the
feature list in Cargo.toml and the build-all-features.sh script.
I also updated the googleapis submodule, and regenerated all
the files.
The reason for the 0.5.2 bump for tonic, is that I need to use the
new Interceptor trait, which is only available starting in 0.5.2.
I suggest you review the commits seperatly. I split out the xtask
changes into the first commit.

@lucacasonato Thanks your contribution. I will review it this weekend.


How to use with angularjs?

Expected behavior and actual behavior.
Provide a sample to use with angular
Steps to reproduce the problem.
Tried importing the JS file and then wrote a component based on it. But could not get it to work.
Specifications like the version of the project, operating system, or hardware.
Angular 2.4.3

can you provide a working angular example for this..
when i test this,it is not works

Closing, as it seems to have been answered.


Avoid locking of service creation in scope if possible

The idea is the Scope is usually created per thread or logical execution flow,
so it should be the rare cases when service creation is done on other threads.

Removing lock is gaining ~15% of warmup resolution in single threaded case.

We can add the rule to skip locking if you know what you doing but it is still risky.

The other problem with locking that we entering it prior to dependencies creation thus prolonging the lock duration.

Idea:

TryGet the entry first and if failed then
Create a var newEntry = new ImMapEntry<object>(NoItem);
AddOrKeep(factoryID, newEntry);
Get the entry and compare it to newEntry
if entry == newEntry then this thread won and may proceed with creating and setting the service without locking (!), otherwise the thread may SpinWait while (entry.Value == NoItem) SpinWait(++times);

Open questions:

What if another thread is failed - we need to signal somehow for the waiting threads or should we? Maybe we can just die or try-catch the creation of the service and set the value to new Failed(ex) or something to signal the other threads - how much will it cost - likely still less than locking?

The other problem with locking that we entering it prior to dependencies creation thus prolonging the lock duration

I think that's the only safe thing to improve on.
For instance for the Interpretation we can do the following:

Check if scoped service is created and then return it.
Otherwise, check if the service expression is NewExpression (or the MethodCall..) and extract its parameters.
Interpret all parameters and then do as usual: create a slot for service, lock on the slot entry, check under the lock if service is not yet created, interpret service with the parameter values interpreted earlier, exit the lock.

This way the lock will be of constant time - just a single constructor call with known argument values.
We may try to use a SpinWait here avoiding the context switch before going to full lock.


Pin sass-rails to prevent Sass compilation error

What
Pin Sass-Rails to a version less than 6.
Why
Sass-Rails v6 is a wrapper around SassC-Rails. SassC-Rails uses LibSass to compile the Sass files to CSS files. LibSass doesn't support CSS calc(), which is used in GOV.UK Frontend. Pinning Sass-Rails to v5 means that CSS calc() is supported and won't throw an error.
More information on SassC-Rails and why this throws an error be found on this issue on finder-frontend, and this issue on whitehall.

@injms have you raised this issue with the sassc-rails folks?


Web: Flutter does not fill out entire screen in landscape on iOS Safari iPhone XS Max

I am running a Flutter web app in a browser on an iOS 13.7 Safari browser on an iPhone XS Max .
When I turn the phone into Landscape orientation, the top widget does not fill out the entire browser window, but leaves empty stripes on the left and right sides. Here is a photo, where the top widget is just an empty blue container:

I am using the following flutter version:
Flutter (Channel beta, 1.24.0-10.2.pre, on Mac OS X 10.15.7 19H2 darwin-x64,
locale en-GB)
• Flutter version 1.24.0-10.2.pre at /Users/stevenobua/flutter
• Framework revision 022b333a08 (8 days ago), 2020-11-18 11:35:09 -0800
• Engine revision 07c1eed46b
• Dart version 2.12.0 (build 2.12.0-29.10.beta)
And the code is just that:
// @dart=2.9
import 'package:flutter/material.dart';

class TestApp extends StatelessWidget {

  Widget build(BuildContext context) {
    return Container(color: Colors.blue);
  }

}

void main() {
  runApp(TestApp());
}

@phlegmaticprogrammer
Can you elaborate on how are you running the web app on iphone browser ?

I am serving the web app from a server embedded in my iPad App. But I tried it now also via running python3 -m http.server --cgi 8080 from the build/web directory (on macOS Catalina), and I get exactly the same phenomenon.

I just tested it with Firefox on the phone, same behaviour. With Chrome on the phone, the behaviour is the worst: In landscape it stretches all the way from left to right, but the time the bottom part of the screen is empty. On refresh, the right part only is empty. On turning it to portrait, now too long empty stripes left and right appear.
Accessing the web app not from the iPhone XS max, but from an iPad, I don't have any problems like that using Safari. Accessing the web app from an iPhone 7 is also without problems using Safari. I guess it is somehow iPhone notch related?

@phlegmaticprogrammer
Did you find a solution ? I have the exact same problem for flutter web.

@0xAMPS
no, I think this is just a bug that needs to be fixed in Flutter. But let me know if you find a solution / workaround, I would be interested in that as well!

Adding steps to replicate for reference:

flutter create safe_area_issue
flutter build web
Go to build/web path and run python3 -m http.server 8000
Open iOS simulator / device that has a notch and open Safari browser.
Note IPv4 address.
In safari iOS browser, type http://8000
Rotate device.

A quick fix that I found by accident and that works for me is to change the background color of the body element in web/index.html. This way the stripes don't stand out if you make the background color the same color as your main content.

Update: @phlegmaticprogrammer good advice as a quick fix. We are working on a fix that sets viewport scale of meta tag by default. The issue is that SafeArea widget still needs to correctly work in that case so we are adding code on the engine side to read from browser and adjust window insets if the widgets is used (It is part of MaterialApp/Scaffold so most users should not experience change at all).

Update/Note: Tested env(safe-area-insert-) to resolve this. Even on iOS 14.1 it is not reliable, when browser page is refreshed viewport shifts. Chrome is in worse state https://bugs.chromium.org/p/chromium/issues/detail?id=1094366.
When we do add support for full screen (instead of browser handling padding for notches), it should be stable enough for MaterialApp with SafeArea widget to continue rendering correctly.

@ferhatb any idea if fullscreen is supported yet or planned to be? Also since iOS 15 is in BETA, will env(safe-area-insert-)be reliable?

Any update ? I am also facing the same issue while I'm running the webapp on an android browser.

Any update, I am still facing this issue while I'm running the web-app on iOS devices.

Any more updates? I am still facing this issue.

please fix~

Related to #84833
Add to your index.html
        return appRunner.runApp().then((_) => {
          document.querySelector('meta[name="viewport"]').setAttribute('content', "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover");
        })

Doesn't fix the issue.

Related to #84833
Add to your index.html
        return appRunner.runApp().then((_) => {
          document.querySelector('meta[name="viewport"]').setAttribute('content', "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover");
        })

it working for me but does it effect something?

nvm, this one's not from the bot, sorry.

The issue persists on the latest Flutter stable and master channels. Reproduced this on iPhone XS Max (has Notch) and iPhone 15 (has Dynamic Island) whilst it doesn't happen on iPhone 7 (no cutout area)

Demo

iPhone XS Max

landscape
portrait

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (8 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 123.0.6312.106

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.22.0-9.0.pre.17, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.0-9.0.pre.17 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a34086a573 (3 hours ago), 2024-04-11 18:07:20 -0700
    • Engine revision 6b37b17099
    • Dart version 3.5.0 (build 3.5.0-47.0.dev)
    • DevTools version 2.34.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.88.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 123.0.6312.123

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.


bench: Add run-jit-backdoor mode

BTW I just realized that 'mode' help does not work anymore:
ython benchmarks/user/benchmark.py run --help
Traceback (most recent call last):
  File "benchmarks/user/benchmark.py", line 507, in <module>
    benchmark()
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 1135, in invoke
    sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 641, in make_context
    self.parse_args(ctx, args)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 940, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 1477, in handle_parse_result
    self.callback, ctx, self, value)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 96, in invoke_param_callback
    return callback(ctx, param, value)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 860, in show_help
    echo(ctx.get_help(), color=ctx.color)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 516, in get_help
    return self.command.get_help(self)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 879, in get_help
    self.format_help(ctx, formatter)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 898, in format_help
    self.format_options(ctx, formatter)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 919, in format_options
    rv = param.get_help_record(ctx)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 1700, in get_help_record
    rv = [_write_opts(self.opts)]
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 1697, in _write_opts
    rv += ' ' + self.make_metavar()
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/core.py", line 1371, in make_metavar
    metavar = self.type.get_metavar(self)
  File "/home/gb4018/anaconda3/envs/devito/lib/python3.7/site-packages/click/types.py", line 149, in get_metavar
    return '[%s]' % '|'.join(self.choices)
TypeError: sequence item 3: expected str instance, tuple found

I think we should add this change in the README as well

Good point. Added a whole new paragraph

BTW I just realized that 'mode' help does not work anymore:

It's not "anymore" -- I just found out it doesn't work with master either. So I won't address this issue now due to time constraints

Merged.


No provider for DropdownService

After updating to angular 4.0.0 and angular/cli 1.0.0 I get a no provider for DropdownService error.

You forget to call .forRoot() method

Of dropdown module in your app.module like in documentation

That was it. Thank you.


use postgres downstream image

Summary
Use the postgres downstream image
Related issue(s)
https://issues.redhat.com/browse/ACM-10597
Fixes #

/retest

/retest

/retest

/retest

/retest


Improved the loading and working of the website

Closes

Closes #1096

Description

Earlier the images are in png/jpg format which requires more space and loading time
I go through each and every folder and changed all images to webp without breaking any image
I have changed more than 200+ images

Screenshots

Note to reviewers

Checklist:

[ x] I have linked the PR to the correct issue.
[x ] I have read the Contribution Guidelines
[x ] I have built and tested the changes, and they do not break or show any errors.

Hey @Vaishnavi-Patil2211 Please review it once


Capability to disable auto renewal of Let's Encrypt certificate

#7245
Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I wanted to have 2 instances on 2 distinct servers of traefik for HA purpose and i'd like to share the acme.json file in order to use the same certificate (transparency for client). The certificate was generated with dns challenge. The acme.json file will synchronized between the 2 instances.
But to avoid that both instances renew automatically the certificate, i'd like to disable automatic auto renewal on the second instance. It seems there's no option to disable this functionnality (cf. documentation).
So i would like, as new feature, this option to be added.
Thanks.

Hello @Diak,
that is currently not possible with the current intention of Traefik being a good old dataplane. As described in #5792, we have integrations with for example cert-manager which can do that for you.

cert-manager is ok with kubernetes it seems. I don't use kubernetes.
Whatever i still think it's not mandatory to want to renew automatically a certificate and it could have been a good option to permit or not this functionnality instead of imposing it.
But i will find another way.


Cannot find module 'system'

i wrote a js script to help my colleague rename a bunch of jpg files with regular name,in this script ,i used module system, just written as 'var fs=require('system')',blablabla,it works good. but i'm trying to make it more firendly ,so i searched a way to compile it into an executable （.exe）file by using pkg，here comes the problem

i checked some issues,but still got no clue,so posted it up,
thanks in advance

@qinqin772 there is no native module system in nodejs. Probably in old versions. Please check if your script works in pure nodejs before compiling with pkg.

when not compling with pkg,run my script in cmd like node 'my script name'  works good,but it comes to error like this when used compiling with pkg


Disable the depth test when clamped to ground zooms to wrong location

Select Disable the depth test when clamped to ground in http://localhost:8080/Apps/Sandcastle/index.html?src=Billboards.html&label=All and you'll be looking at the size of a mountain.  You need to move the camera to see the billboard.
This is using the viewer.zoomTo, so maybe we introduced a bug when clamping to ground?

Yup, noticed this too. I think what's happening is the billboard is initially clamping to a low LOD tile and the camera zooms to that spot. Then higher LOD tiles load in and the entity shifts upwards, so now the camera is underground looking at nothing.

I ran into this problem again during a CesiumJS release. My previous comment is not the full story, because even if the camera tracks the entity it still gets lodged underground.
I created a more minimal example below:
https://sandcastle.cesium.com/#c=bZJvb9MwEMa/yimvUik4y2CIla6CdRMgyjqtLQgp0uQ5l9bCsSv7kq1D++7Y+bMN2KvY5+f52fdcGm6hkXiLFk5A4y3M0Mm6Yt/bWpxHot3PjCYuNdo8Gr3Pda7LWguSRsO9MdXKfKF4BL9zDT2MEVrrDZfWNLJo4T1YWOSEP4xVxarTxIHojf4l6HU9ADVJkugYL4q4JQPsjJPh0vEAm3FLfsX1a1ZaU53hxiK6+FV2eMiy46N3Cbx56xfZ0SgZCFLTGHoegDDK2Cdc2LHl15+n8/V5Mmh28g7VUt7jGLKDg8fyFuVmS1dYokUt8BHy+e86m80/fru8Xi2uP10t1hdnvf8hfB76zvvILBe/sDgPje99EOgPvWzJdSG4I4UhipUx6obb05rIaD+eED+QAUl5lMAwlWEYT8MJrG5yaQprLUxV+YSDs5R3bfGZNkqiiaO9wunQ7AdZ7YwlqK2KGUsJq53yY3TpTe3fTEw41/UCMEmfWyeFbEAWJy/8SCAUd86flLVq882j6ST1+v+syvBC6s2iQav4Psi22XTeFRljk9RvX3ZSF9c/5D8

For now I hardcoded the camera position https://github.com/CesiumGS/cesium/commit/b3334483f6c543ce1f16a2e41d7c8c641f137567


Align configuration files to YARP devel

Modifies the iCubGenova04 configuration files to be used with the latest version of YARP and iCub.

@valegagge @randaz81 Do you think we can merge this?

I think it is ok!
I have one only suggestion: in order to avoid to increase number of files, I suggest to delete old file abouts strain and rename file for strain2 in strain.

I have one only suggestion: in order to avoid to increase number of files, I suggest to delete old file abouts strain and rename file for strain2 in strain.

We are still testing those new features. For the time being I think it is better to keep both files and remove them in a next PR.


Support for resonating inputs and buffers

This is very slightly still a WIP, in that it's missing the ability to actually load files into the buffer other than by recompiling the supercollider.
I ended up removing the pre-resonator reverb, as I couldn't get it performant enough. That said, this ain't bad.
Changes:

ring now scales with the wavelengh of the audio, and as it gets more resonant it reduces the amplitude to compensate
new parameter "absorb/emit" that crossfades between the resonators and the synthesized sines, but keeps the random crossfading behavior in the middle
can mix noise, input, and buffer into the resonators.

this looks great! I'll merge to a branch and do a little work on it too

(merged into v1.2)