[Refactor] Removed Custom Logger #4675

Removed custom Logger and moved to console.log and console.error
Issue : #4675

@saurabhan are you going to keep working on this PR or do you want someone else to take over?

I'm sorry, but I am on-call at work for the next week.
If anyone wants to pick this up in the meantime they can otherwise I will pick it up after my on-call ends.
Also, I tried but the mocking console inside the test still prints it to the terminal, writing it at the top of the tests like this
  let consoleMock : jest.SpyInstance;
  beforeEach(() => {
   consoleMock =  jest.spyOn(console, 'error').mockImplementation(() => {})
  })

  afterEach(() => {
    consoleMock.mockRestore()
  })

This works and stops the console from spilling over in the terminal. had to do this in every test file like mutations.test.tsx does not call the console explicitly but a function it calls from mutation.ts calls the console.error, doing the above stops console spill and tests pass as usual.

I updated with v5 and removed the error logging when a query errors. That means what is left is going through tests and mostly revert a lot of your changes, because no console logging actually happens when we have tests for error states. I started with that but ran out of time. To be continued.

Hi TkDodo, can you please have a look and tell me what all changes are to be made or reverted, I will get them done. Thanks

Hi TkDodo, can you please have a look and tell me what all changes are to be made or reverted, I will get them done. Thanks

I haven't looked at the errorBoundary tests yet, but it seems like we need to add a spy to the console whenever we use errorBoundary.
Apart from that, we don't need to change anything for queries that just reject the Promise and go into error state without error boundaries. There, we used to log to the console, but I have removed that.
for example, in this test:
https://github.com/TanStack/query/pull/4721/files#diff-3cd8cae55f836a38ea976d6cbf9f1b59e8fdfa4d3218b123cb1f9dccfc6824d2R2867-R2870
We shouldn't need the log spy because there is no error logging that we would expect.

I have removed consoleMock from the test and fixed some of the tests, also added consoleMock where Error boundary is being used.

@saurabhan can you please update with v5? seems like there are lots of conflicts

Fixed linting and Format, 🤞

.mockImplementation(() => {})

yields a lint error:
ESLint: Unexpected empty arrow function.(@typescript-eslint/no-empty-function)

let's just do .mockImplmentation(() => undefined) ?


x/mobile: build failing when using go modules

What version of Go are you using (go version)?

go version go1.13.7 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/axet/.cache/go-build"
GOENV="/home/axet/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/axet/.go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/5243"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/5243/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/axet/local/libtorrent/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build037966773=/tmp/go-build -gno-record-gcc-switches"

What did you do?
gomobile failed with "replacement module directory path ... cannot have version"
Probably because gomobile does not support 'go.mod replace command'. Full log:
# git clone -b dev https://gitlab.com/axet/libtorrent
# gomobile bind
gomobile: go build -buildmode=c-shared -o=/tmp/gomobile-work-296787665/android/src/main/jniLibs/armeabi-v7a/libgojni.so ./gobind failed: exit status 1
go: errors parsing go.mod:
/tmp/gomobile-work-296787665/src/go.mod:181: replacement module directory path<EMAIL_ADDRESS>cannot have version

It also failed with "proper" version like "v0.14.0" or "libtorrent-0.14.0"

Thank you for the report @axet!
Kindly cc-ing @bcmills @jayconrod.

What version of the gomobile command are you using? (This seems like a duplicate of #27234.)

Recent:
axet@axet-laptop:~$ gomobile version
gomobile version +0df4eb2 Wed Feb 5 17:02:28 2020 +0000 (android); androidSDK=/home/axet/Android/Sdk/platforms/android-29

I probably know what is going on, If I init gomobile staying inside my library "go.mod" directory it will fail.
go get golang.org/x/mobile/cmd/gomobile
gomobile init
ls go.mod

And now it bugged.

cc @hyangah

gomobile generates go.mod file based on the go list output influenced by the original go.mod. (https://github.com/golang/mobile/blob/0df4eb2385467a487d418c6358313e9e838256ae/cmd/gomobile/bind.go#L230)
It looks like the original file has
replace github.com/anacrolix/torrent v1.13.0 => gitlab.com/axet/torrent v0.0.0-20200205141541-92b4b9e7387e
and gomobile bind converted it to
replace github.com/anacrolix/torrent v1.13.0 =><EMAIL_ADDRESS>v0.0.0-20200205141541-92b4b9e7387e
cc @hajimehoshi

One thing to watch out for: it's not generally safe to use module directories in the module cache as replacements. Replacement modules must have a go.mod file, and a directory in the cache won't have a go.mod file if the original module didn't.

It is closed, but still failed to compile. Same library I build using old style GOPATH no problems, go.mod build failed with two errors, first run:
gcc: error: unrecognized command line option '-marm'; did you mean '-mabm'?

second run (same command: gomobile bind)
gomobile: go build -buildmode=c-shared -o=/tmp/gomobile-work-515390264/android/src/main/jniLibs/armeabi/libgojni.so ./gobind failed: exit status 1
go: cannot determine module path for source directory /tmp/gomobile-work-515390264/src (outside GOPATH, module path must be specified)

Example usage:
	'go mod init example.com/m' to initialize a v0 or v1 module
	'go mod init example.com/m/v2' to initialize a v2 module

Run 'go help mod init' for more information.

Should I create separate issue?

@axet Please do. You can refer to this issue if any of the information here is relevant.


[NEW] Make the "tracking" of Fabric/Analytics optional in "Settings"

All kind of tracking in our app needs to be a user's choice. By default this flag is TRUE now, because we want to track the crashes, but if someone wants to disable it, the user needs to be able to disable via settings.

I personally support tracking, but for data protection reasons I do not consider it permissible to switch it on by default. The more polite option would be to ask the user nicely during/after the installation if he wants to enable tracking to support the project.
In my environment of a public institution I therefore have to inform the users. I would therefore be pleased if the feature is not activated automatically.

@localguru All kind of tracking that we do is anonymous and do not have any sensitive content on it, just "actions" that the user is doing, such like sending message, reactions, etc. Also this specific issue can be closed already because the tracking is already optional in Preferences. Let me know if you've other suggestions, I'm sure we can improve it! This one that you just gave looks like a good idea.


docs: Add Provider Type

I think picking provider type is a common problem/situation for beginners.
While there's a section that explains All Providers, there's no need to know what type should we use when using code-gen variant.
So, I think Provider Type section before All Providers section might be helpful to explains that and discuss the differences.

This looks awesome. Thanks for the work!

Adding a section for keepAlive/family is left.
Should rename files suffixes from (stateless/stateful) to (fn/class) too.

There's still a horizontal scrollbar, albeit invisible by default. I was personally expecting to reduce the horizontal size of the table such that a scrollbar would no longer be needed.
We're missing a few millimeters at most.
Maybe a good candidate to reduce size is to trim the content of the left-most column. Like writing only "Sync/Async/Stream" instead of a sentence

I've tried doing the left column change myself rapidly, but it appears that there's a deeper issue.
Do you mind looking into it? :)

Perfect! Thanks a lot :)


Harmonize button size from React UI with current V3 desktop button

📝 Description
Fix button size in react-ui
❓ Context

Impacted projects: react-ui
Linked resource(s): https://github.com/LedgerHQ/ledger-live/pull/762

✅ Checklist

[ ] ~Test coverage~ - No testing in UI lib
[X] Atomic delivery
[X] No breaking changes

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

I updated the title, you can squash and merge if CI is green


Panic in setting up watch on /helix. Is etcd running at http://<IP_ADDRESS>:4001/ ?

I always have this error 5 minutes after helixdns is started.
During these 5 first minutes, everything is working fine.

I'm experiencing this issue when I start HelixDNS using docker and systemd on CoreOS alpha 709.0.0 or CentOS 7.1, pointed to an etcd cluster running on CoreOS (etcd version 2.0.11). HelixDNS starts and runs fine if I execute the command in the service file directly. When started with systemctl, it panics with a complaint about setting up the watch on /helix within a second or so of starting.
Here are the instructions to reproduce from my CentOS 7.1 machine (with etcd running on CoreOS at <IP_ADDRESS>):
Executing docker command directly works fine (it also works fine with the -d option):
$ sudo /usr/bin/docker run -p 53:53/udp --name helixdns probablyfine/helixdns helixdns -etcd-address="http://<IP_ADDRESS>:4001/" -forward="<IP_ADDRESS>:53" -port=53
2015/06/13 20:27:27 Starting server...
2015/06/13 20:27:27 Setting up watch to validate entries
...
2015/06/13 20:30:27 Could not get record for google.com., forwarding to <IP_ADDRESS>:53

After CTRL-C, create the following hdns.service file in /etc/systemd/system/
Description=HelixDNS
After=docker.service
Requires=docker.service

[Service]
TimeoutStartSec=0
ExecStartPre=-/usr/bin/docker kill helixdns
ExecStartPre=-/usr/bin/docker rm helixdns
ExecStartPre=-/usr/bin/docker pull probablyfine/helixdns
ExecStart=/usr/bin/docker run -p 53:53/udp --name helixdns probablyfine/helixdns helixdns -etcd-address="http://<IP_ADDRESS>:4001/" -forward="<IP_ADDRESS>:53" -port=53
ExecStop=/usr/bin/docker stop helixdns

[Install]
WantedBy=multi-user.target

$ sudo systemctl start hdns && sudo systemctl status hdns
hdns.service - HelixDNS
   Loaded: loaded (/etc/systemd/system/hdns.service; enabled)
   Active: active (running) since Sat 2015-06-13 16:33:38 EDT; 19ms ago
  Process: 14618 ExecStop=/usr/bin/docker stop helixdns (code=exited, status=0/SUCCESS)
  Process: 14666 ExecStartPre=/usr/bin/docker pull probablyfine/helixdns (code=exited, status=0/SUCCESS)
  Process: 14638 ExecStartPre=/usr/bin/docker rm helixdns (code=exited, status=0/SUCCESS)
  Process: 14632 ExecStartPre=/usr/bin/docker kill helixdns (code=exited, status=0/SUCCESS)
 Main PID: 14673 (docker)
   CGroup: /system.slice/hdns.service
           └─14673 /usr/bin/docker run -p 53:53/udp --name helixdns probablyfine/helixdns helixdns -etcd-address="ht...

Jun 13 16:33:45 redacted docker[14673]: 2015/06/13 20:33:45 Starting server...
Jun 13 16:33:45 redacted docker[14673]: 2015/06/13 20:33:45 Setting up watch to validate entries
Jun 13 16:33:45 redacted docker[14673]: 2015/06/13 20:33:45 Panic in setting up watch on /helix. Is etcd running at "http://<IP_ADDRESS>:4001/" ?

The error is caused by etcd 0.4, see coreos/go-etcd#170.


Select * from  on federated metastore does not work.

If I have a View View1 over Table T1 and T2 under hive database db1 in federated metastore FM1. Following command fails with Table Not Found Exception
Select * from fm1_db1.view1 ;
This will fail with Table T1 & T2 Not Found.
Additional Info:

WD is running in prefixed mode.

Looks like WD is not able to add prefix to table T1 and T2 when it expands view to table level.


[FLINK-14593][client] Port ClusterClient to asynchronous interface version

What is the purpose of the change
Port ClusterClient to asynchronous interface version
Brief change log

Port ClusterClient to interface
Port cancel/cancelWithSavepoint/stopWithSavepoint/getAccumulators to asynchronous version
Introduce a settable TestingClusterClient and remove FakeClusterClient
Adjust related code.

Verifying this change
This change is a refactor and covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Hi @kl0u @aljoscha could you take a look at this?

Thanks for your review @kl0u ! I've updated the pull request.

@flinkbot run travis

Thanks for your review @kl0u !


test

Codecov Report

Merging #377 into master will decrease coverage by 4.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage    90.6%   86.12%   -4.49%
==========================================
  Files         219      219
  Lines       10692    10692
==========================================
- Hits         9688     9208     -480
- Misses       1004     1484     +480


With version 2.9.13 it is not possible to add custom certificates

With version 2.9.13 & 14 it is not possible to add custom certificates. Nothing happens when you click the button in the SSL tab

Please use the search before opening issues. Duplicate of https://github.com/jc21/nginx-proxy-manager/issues/1676, https://github.com/jc21/nginx-proxy-manager/issues/1693, https://github.com/jc21/nginx-proxy-manager/issues/1700 and https://github.com/jc21/nginx-proxy-manager/issues/1707.
Though this issue was fixed in 2.9.14. Your browser probably still serves you the cached version of the website which still contains the bug. Make sure to clear your browsers cache and try again.


Removing Microsoft.AspNetCore.SpaTemplates project

[Fixes #176] KnockoutTemplate_Works_NetCore test flaky on VS

Removing the project and tests as per the announcement here: https://github.com/aspnet/Announcements/issues/289


Update setup

This fleshes out slightly the Docker steps.
I rule and have completed some work on Case Manager that's ready for review!
This is a documentation update for Docker setup. I can't vouch this is 100% correct but it worked for me. Feedback/tweaks/whatever is always welcome.
This pull request makes the following changes:

Update setup documentation


Difference between Azure Pricing Calc and Excel

Hi
Could you please explain the big difference between Azure Pricing Calculator and the Backup Detailed Estimate? If I use 1 Storage Account (azure Files) with 4 TB Data, 30 days, 12 weeks, 6 months and 1 year and low data churn I'm getting a difference of 347 USD (pricing calc) and 107.05 USD (in a nutshell) in the excel.
BR
Dave

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45baa4f3-2845-ae9b-a94e-b07ff7c44a63
Version Independent ID: 7ff62d1f-39f0-2bbd-70a0-c5d7570def2d
Content: Azure Backup pricing - Azure Backup
Content Source: articles/backup/azure-backup-pricing.md
Service: backup
GitHub Login: @v-amallick
Microsoft Alias: v-amallick

@DaveZimmermann Thanks for your comment. We will review the issue and get back to you shortly.

@DaveZimmermann The latest version of the Excel sheet assumes a slightly lower (more realistic) value of churn % for Low, Medium, High scenario for Azure Files. The corresponding changes have not yet gone into the online pricing calculator, and engineering team is working on pushing these changes to the Azure Pricing Calculator at the earliest.
Hence you are seeing a difference in the values of storage consumed between these 2 scenarios (to verify, you can go to the Excel sheet, select ‘Enter your own churn’ and input 2%, 6%, 18%, 40% for daily, weekly, monthly, yearly – this will then match with the online calculator)

Hi @SwathiDhanwada-MSFT
Thanks for your response!
I've tried to match it as close as possible and still have a huge difference:
https://azure.com/e/ec8c8b47e91b463a86ae6d103125e255
and
AzureDetailedEstimator.pdf
I cannot explain that to myself, even with different churns...

@DaveZimmermann Thanks for sharing these files.  Here are the changes that I made to the estimation file and I was able to get it.

Updated the estimate price as shown below image. As the Protected Instance price for Azure Backup is  CHF 5.7374 as shown in this document and also snapshot storage cost per GB to CHF 0.0681 as per this document.

Snapshot of Protected Instance price for Azure Backup:

Screenshot of Snapshot storage cost per GB

Also updated churn by  selecting ‘Enter your own churn’ and input 2%, 6%, 18%, 40% for daily, weekly, monthly, yearly.

AzureBackupDetailedEstimatesV8.2.xlsx
Hope this helps.

Hi @SwathiDhanwada-MSFT
Thanks a lot for the time you're spending for me! If I understood your first answer, then the default settings of the excel are realistic and therefore you don't need to enter "Enter your own churn", especially if we're not having own experiences so far, right?
Best Regards
Dave

@DaveZimmermann Yes. You are right.

thanks a lot for your answer and your great support! We can close it then here.


System Usability Survey - Internal

Task: Plan System Usability Survey with internal CIF users to understand overall success and pain points in their workflow.
** Acceptance Criteria: **

[x] Plan testing
[x] Create survey
[x] Send to CIF team members
[x] Analyze information (Note: this could be split into different ticket)
[x] Plan how feedback received will support/align with CIF team.

@rajpersram to break out the last three item's details.

To be repurposed into System Usability Survey Ticket

@rajpersram - reminder to update this ticket to be for the system usability survey. We can then pull into this sprint.

6 anonymous surveys were completed by CIF staff, with the results attached. This is our benchmark, so we can't draw too many conclusions from this until a relative future result is gathered (which should be the exact same questionnaire but for the new web-app).
https://app.zenhub.com/files/402862646/6f5ae2e4-ffcc-4032-bf5a-eac949dcb482/download

Thank you @rajpersram. I add a copy of the survey results (from link above) into our CIF Internal Users Channel.

In terms of what stood out, most of the answers were in the middle of the road in terms of the CIF's team's usability of their current system. I had expected answers to score lower in general but I think their answers are normal in the context that they're already used to the system they have, so there is a measure of acceptance for the status quo. There are no wrong answers for this benchmark, but it is just that; A starting point which ultimately needs another survey to follow up on the upcoming web-app. Those score will represent how we've evolved and ideally simplified their processes. Those scores can then be used to establish a rough ROI but we should collect more performance metrics such as what we covered in the KPI meeting with Lindsay, Jaimie, Taylor and Ram.
As for a plan to support/align, the results of this survey are recorded on the Miro 'CIF Metrics' board with a follow up plan and corresponding user story in ticket 118 for the next survey.

Thank you for the clarification @rajpersram :)


Added Jackett version 0.18.475.0.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

The bot has permanently died on this PR.


DropdownMenu: container prop for rendering it separately (#1685)

[x] Bug fix
[x] New feature
[ ] Chore
[ ] Breaking change
[x] There is an open issue which this change addresses
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

The tests for the new functionality were implemented with no use of enzyme. With enzyme, I did not manage to test the functionality using ReactDOM.createPortal.

Another commit associated to a different issue. Sorry for the lack of organization:

Modal: Trap focus on opened component (FIX #1497 and FIX #1679)


realtime gekko doesn't properly handle OS standby

A realtime gekko will poll an exchange regularly for market data and then convert the data into candles. However, if your system goes into standby mode whilst running Gekko, Gekko assumes no trades happened at the exchange and will calculate incorrect candles:

I am still receiving this error all the time I launch a live trading gekko on Mac OS. Any idea?

@elGuille what kind of computer do you use? If you for example use a macbook and it goes standby in any way (you close the laptop, you don't touch it for a few hours with default settings), it suspends all applications including Gekko. Gekko needs to run non stop so it can keep monitoring the market in realtime.

@askmike thank you for your quick reply!
I have a Macbook Pro and I set the EnergySaver setting to never sleep and never purt hard drive to sleep either.

Strange, it works great on my macbook pro for hours. After how long does this usually happen? Also on what exchange?

Less than 5 minutes, Im trying Kraken

This might actually be related to kraken, their API is having some trouble
at the moment. Could you check whether other exchanges (poloniex for
example) work? A paper trader should be sufficient, with regards to this
message there is no difference with a real trader and a paper trader.
On Mon, Nov 20, 2017 at 12:24 PM, Guille<EMAIL_ADDRESS>wrote:

Less than 5 minutes, Im trying Kraken
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/514#issuecomment-345594907, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MD6_Gn4JaecLdGfg6dWqCFcLjKD8oks5s4Q0fgaJpZM4LDq4K
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc

I will do that, thank you!

Noob question but what permissiosns do I add to Bitfinex API for Gekko trading?

those look good, but you can disable the: margin trading and margin funding one as well.

Thanks a lot!

Experiencing the same problem: "ERROR: Failed to tick in time, see https://github.com/askmike/gekko/issues/514 for details".
Using "binance" as exchange.

Happened to me with binance and macOS

happened with binance

Im having this issue with a dedicated server

I'm having this issue in an dedicated server under google cloud platform.
Using Poloniex.
Why child process has died?

https://i.imgur.com/w68utcL.png

For me this happened:
2018-02-10 16:19:37 (DEBUG):    Requested LTC/BNB trade data from Binance ...
Unhandled rejection TimeoutError: operation timed out
    at afterTimeout (D:\dev\projects\github\gekko\node_modules\node-telegram-bot-api\node_modules\request-promise\node_modules\bluebird\js\main\timers.js:16:15)
    at Timeout.timeoutTimeout [as _onTimeout] (D:\dev\projects\github\gekko\node_modules\node-telegram-bot-api\node_modules\request-promise\node_modules\bluebird\js\main\timers.js:59:9)
    at ontimeout (timers.js:475:11)
    at tryOnTimeout (timers.js:310:5)
    at Timer.listOnTimeout (timers.js:270:5)
2018-02-10 16:20:21 (DEBUG):    Processing 2 new trades. From 2018-02-10 15:19:34 UTC to 2018-02-10 15:19:57 UTC. (a few seconds)

 ERROR: Failed to tick in time, see https://github.com/askmike/gekko/issues/514 for details

Operating System: Windows 10
Exchange: Binance
Is it a good advice to start gekko with tools like forever to recover from this scenario?

Just FYI. This just happend to me an an AWS EC2. Seems strange that that will ever go to sleepmode.
tried to connect to my live instance running for about a week now and then it crashed. market watchers all disappeared and the error was in the command output. restarted watchers but on bitstamp it misses some candles now.

There might have been an error in the connection between gekko and the exchange.

thx @askmike for the reply.
yeah could be. but i suspect something with the AWS itself or the setup with nginx (other issue i know, but i seem to use unsecure connection although i set it up exactly like in the guide)
as all market watchers crashed when i tried to login. gdax and bitstamp

i had the same error again. same result. all market watchers crashed. i did try to see my available datasets in local data, but they loaded and maybe got stuck. maybe it has something to do with this limitation as i have quite a lot of datasets:
https://github.com/askmike/gekko/commit/7cf20f6900546ffa128d55091971134693204bf5
have to update and see if it helps

happens to my macbook air even with caffeinate running. Doesn't happen if I keep the display open and on mains power.
i  have a pretty good strat (non-TA) and was testing it live to see if i should put money into a raspberry pi to run gekko headless. Was on binance exchange. Happened as expected when went to sleep on battery mode, however with caffienate running on mains power it was unexpected.
Probably not relevant to pi anyway

Hello,
I had NO STANDBY, but anyway had this problem!
I am running a Amazon EC2 ubuntu 16.04 server. It's running 24/7.
Just had this happening 3 times in the last 24 hours. All my 4 productive strategies restarted + all paper traders + all candle writers also.
Can it have something to do with time changing ?
There is no NTP running, but maybe the amazon host server "decided" to change the time as it was a bit off.
Have in my work often had problems for instance on Hyper-V/VMware with Active Directory servers that did not like that time changes suddently.
My strats are running in a bash script that loops and restarts it. The bash script waits for xx:x0:00 before it starts gekko.
When the strategy crashes it there is one minute or more between that the last trades was outputted and the strategy is restarted. Here 01:46:33 it outputted last trades and 01:47:49 it gets to start the strategy again. This is almost 1,5 minutes.
2018-05-06 01:46:33 (DEBUG):    Requested BTC/USDT trade data from Binance ...

 ERROR: Failed to tick in time, see https://github.com/askmike/gekko/issues/514 for details

7:49 = waiting for 0:00

Or is gekko just trying so long time before giving up ?
Please enlighten me what is happening, so I can help fixing this :)

It continued all the time and I had to reboot the server to get it to stop :(
We should dig deeper in this. Please tell me what I can do to debug it next time ?

@askmike
Suggested fix
I have this problem on Amazon EC2 servers. It looks like they sometime are very slow, so alomost nothing happens for a minute and then gekko crashes. I understand that if this happens for an hour or a day, that is bad. But right now the max period is only 1 minute and that is too short.
My suggestion is that we take candlesize as a maximum. I have changed heart.js in my systems to be like this:
Heart.prototype.tick = function() {
if(this.lastTick) {
var CandleSize = 1;
if (util.getConfig().tradingAdvisor.candleSize) CandleSize = util.getConfig().tradingAdvisor.candleSize;
// make sure the last tick happened within the last candle
// @link https://github.com/askmike/gekko/issues/514
// if(this.lastTick < moment().unix() - TICKRATE * 3)
if(this.lastTick < moment().unix() - CandleSize * 60)
util.die('Failed to tick in time, see https://github.com/askmike/gekko/issues/514 for details', true);
}
that gives the following error on a test system that I just paused for 3 minutes, but otherwise it looks as if it works OK. I will test it now in production and see how it goes :) :
2018-05-11 08:34:22 (DEBUG):    Requested XBT/EUR trade data from Kraken ...
2018-05-11 08:34:23 (DEBUG):    No new trades.
2018-05-11 08:37:35 (DEBUG):    Requested XBT/EUR trade data from Kraken ...
Unhandled rejection TimeoutError: operation timed out
at afterTimeout (C:\Trade\gekko-dev-0.5.13\node_modules\node-telegram-bot-api\node_modules\request-promise\node_modules\bluebird\js\main\timers.js:16:15)
at Timeout.timeoutTimeout [as _onTimeout] (C:\Trade\gekko-dev-0.5.13\node_modules\node-telegram-bot-api\node_modules\request-promise\node_modules\bluebird\js\main\timers.js:59:9)
at ontimeout (timers.js:475:11)
at tryOnTimeout (timers.js:310:5)
at Timer.listOnTimeout (timers.js:270:5)
2018-05-11 08:37:45 (DEBUG):    Processing 54 new trades. From 2018-05-11 05:34:36 UTC to 2018-05-11 05:37:37 UTC. (3 minutes)
2018-05-11 08:37:55 (DEBUG):    Requested XBT/EUR trade data from Kraken ...
2018-05-11 08:37:55 (DEBUG):    No new trades.
2018-05-11 08:38:15 (DEBUG):    Requested XBT/EUR trade data from Kraken ...
2018-05-11 08:38:16 (DEBUG):    Processing 4 new trades. From 2018-05-11 05:37:59 UTC to 2018-05-11 05:38:17 UTC. (a few seconds)

Hello,
I'm new in using Gekko. I got exactly the same problem.
However, in my case I did many tests with different currency peer and identify that it seems that we get this "Failed to tick in time," error if I monitor a pair with low trading volume.
For example, if I monitor BNBBTC every minute it works fine, but if I try to monitor LUNBTC it does not work properly. I think that this is due to the fact that for those low trading volume pair it can be that there is no trade at all during few minutes (e.g. 10 minutes).
I have the feeling that in this case, if there is no price move and if there is no trade for a while, Gekko generates this "Failed to tick in time," error.
Let me know if you need more explanations about my case.

There was such a problem Win 7 VPS server. During the paper trade 9 o'clock the robot warmed up. Then he started a paper trade and after some time an error appeared. I tried again and again and every time this error, the exchange Bitfinex.


Adding missing member variable in TTS

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rdkservices/488/rdkcentral/rdkservices

Commit: 6302de19fefb2d19d814c6104c1e6a6dc7ad4ae8

Report detail: gist


Support for common super type

Description
NULLIF support for velox only exists when both arguments have same type.
Presto provide utility functions to get the lowest common super type (best possible super type) for 2 distinct types. This is used in a number of places within the presto codebase, and also for nullif. Thus presto is able to support NULLIF even for distinct types.
Presto implements this as a specialForm as it also includes optimisation when the first argument is null.
Due to NULLIF being specialForm and lack of common super type in velox, we had to branch within presto codebase  and provide an alternate code path in SqlToRowExpressionTranslator for native queries. Follow up issue: https://github.com/prestodb/presto/issues/20008
Providing support for common super type will help bridge the gap and remove the unnecessary branching in presto codebase.

cc @mbasmanova

@vermapratyush Just to clarify, are you suggesting to add support for NULLIF special form to Velox? It feels like you are asking for a specific solution (common super type), but it would be better to describe a problem and then look for best solution.

@mbasmanova Updated the description with the problem and the impact of the current workaround.

For reference, type coercion rules in Presto: com.facebook.presto.type.TypeCoercer#coerceTypeBase
At a high-level, I'm not sure if it makes sense for Velox to implement type coercion and do that in Presto-compatible way. Velox expects the application to resolve types and provide fully resolved and optimized query plans and expressions. It is not also not clear to me that the optimization for first arg of nullif being null is particularly useful.
That said, Prestissimo can implement type coercion compatible with Presto and that would allow to avoid branching the Java code you mentioned.

That makes sense. I will close this issue and continue the discussion in presto https://github.com/prestodb/presto/issues/20008

FYI, expression evaluation in Velox already has optimization for nulls, which would apply to the expression that NULLIF is being translated to: https://facebookincubator.github.io/velox/develop/expression-evaluation.html#handling-nulls


Request the id from a link crash

Describe the bug
Requesting the id attribute from a link make the request failed.
Reproduction steps
const { records: ascents } = await xata.db.ascents
      .filter({ "route.id": id })
      .select([
        "id",
        "attemptsCount",
        "createdAt",
        "climber.id", // This line make the app crash
        "climber.name",
        "climber.pictureUrl",
      ])
      .getPaginated();

FetcherError: columns invalid: table [climbers]: column [id]: column not found
    at fetch$1 (C:\Users\fabie\Projects\talk-berlin-ts-17-08-2022\server\node_modules\@xata.io\client\src\api\fetcher.ts:64:11)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at RestRepository.query (C:\Users\fabie\Projects\talk-berlin-ts-17-08-2022\server\node_modules\@xata.io\client\src\schema\repository.ts:213:40)
    at C:\Users\fabie\Projects\talk-berlin-ts-17-08-2022\server\src\routes.ts:59:34 {
  status: 400,
  errors: undefined,
  requestId: 'e52bb848-0025-436f-bc50-807f8a54291c',
  cause: undefined
}

Expected behavior
Not crashing 😅
Software version
<EMAIL_ADDRESS>"0.16.1"
Additional context
Please note that the climber.id was already part of the result, this was more to have the id explicitely requested.

Not an SDK problem. Fix in review: https://github.com/xataio/xata/pull/1024


Change has to exists

It wasn't possible to update a translated field value to an empty string. Because the has method returns false if the value is empty. This should be handled by the (form request) validation.

Thanks.
I'm curious: are you using Blender for any client projects?

Well, we need to build a new cms in the future. I didn't want to use Blender because I don't understand all the parts of it (yet), and it's very specific for your needs.
So I started tinkering on a cms from scratch. I look a lot at blender. Every time I want to add something, I look at blender to see how you guys did it. I only put code in the cms that I understand. So it's a great way to learn, fix typos, and maybe we can use it some day :)

Great way to go about building a new system of your own. Have fun!


Dynamic SPFx Bundling/Loading Web Part Example

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

What's in this Pull Request?
This web part illustrates how SPFx functionality and packages/libraries can be bundled in multiple '.js' file bundles, then be dynamically & asynchronously loaded into the page at execution time, with a button click.
It provides two different examples within the web part. The first is simple and bundles basic .ts/.js functionality into a separate file, imported upon a button click. The second examples shows how to separately bundle an library and '.scss' styles that are only needed upon a button click at execution time.

thx David, appreciated. Sorry for the small delay on getting this processed.

@VesaJuvonen no worries on the delay at all!! :) I think you were busy with something last week, but hmmm...what was it?? ;P LOL. Great job at Ignite on your sessions!!! 👍


Integrate email service

Since this is a public repository, we should integrate email service just to make it more realistic.

This isn't a core requirement as an email is sent to client on successful payment


How do I get double click to toggle zoom all-the-way out/all-the-way in

It's a great component but it's a bit lacking on the usage of the various parameters, like for example, how to implement double-click. If I wanted to say, double-click once to zoom all-the-way-in and then double-click again to zoom all-the-way-out, how would I do that?
The documentation is not clear on that and the demo page just zooms in partially, in increments. I see that there is a mode property of the doubleClick option ("zoomIn"/"zoomOut"/"reset") but there is not nothing to demonstrate how to use that.
Any help would be greatly appreciated.

I came up with a workaround for this sort of functionality that isn't perfect. It doesn't work properly if the double click is fired too fast.
I noticed that the only events that capture the double click are onPanningStart, onPanning, and onPanningStop. After a bit of messing around I found that if you set the doubleClick.step to a negative number it will zoom out. So I set up a new hook state variable and listened to the event.state.scale so that I could set it up as shown below:
hook:
const [doubleStep, setDoubleStep] = useState(8);

component:
<TransformWrapper
  key={imgUrl}
  centerOnInit
  centerZoomedOut
  doubleClick={{step: doubleStep}}
  onPanningStop={(e) => {
    if (e.state.scale !== 1) {
      setDoubleStep(-8);
    }
    else {
      setDoubleStep(8);
    }
  }}
>
  <TransformComponent >
    <img
      className={classes.itemImg}
      src={imgUrl}
      onError={e => { e.target.src = noImg; }}
    />
  </TransformComponent>
</TransformWrapper>

im also facing same issue

There is a zoom mode 'toggle' now that accomplishes this.


feat: FOX-ETH LP account selection [WIP]

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2628

PR #2629

PR #2630   👈

This comment was auto-generated by Graphite.


Update layout.js to add hook to remove window re-size event listener on destroy.

Hook to destroy layout plugin and remove window resize event listener.   Fixes #36.

Looks great, thanks!


Add test for single row & column

Closes https://github.com/pydata/pandas-gbq/issues/114

Tests pass: https://travis-ci.org/max-sixty/pandas-gbq/jobs/419781932


Fuzzy search for Quick switch feature

Is your feature request related to a problem? Please describe.
The "Quick Switch" feature is very good, it would be great if the search is fuzzy
Describe the solution you'd like
Example:
Say if the following are my services

Gmail
Slack
Whatsapp
Work - Gmail
OSS Slack
If i type "mail" both "Gmail" and "Work - Gmail" should come as a a result

What is currently happening is i don't see anything,
Describe alternatives you've considered
I am thinking it is fine if it is not completely fuzzy
instead of the "startsWith" if we change it to "contains" it would be great :-)

@kishaningithub - I just committed a PR for this: #1326 - if this is what you wanted, please upvote the PR

Please note that in javascript, if you want to match with special characters, you will need to escape the string. So, to match gmail and NOT match gitter, the search string needs to be g\*l

@kishaningithub - since this is now merged, could you please verify and close the issue?


Add StandardEventsFeature as a return type to features()

Just added StandardEventsFeature as a return type as it was missing and my IDE did not like it.

Seems like you were the one working on it @jordaaash - just a quick patch


Support Bootstrap icons

Please, support Bootstrap icons
https://icons.getbootstrap.com/
Their license is MIT

This seems to be obsolete, as we already have Bootstrap. Does it need to be updated? https://github.com/PanderMusubi/inkscape-open-symbols/tree/master/Bootstrap

Indeed. Yes, it needs to be updated. Renaming the title of this issue.


Add methods to user class

Description: Looking at the user class and unit tests, I think some methods for the user class would be helpful to reduce coupling found in some of the tests (as shown below) and likely current implementation of other integrated code.

Methods to implement:

User.followCount() and User.followerCount(): Would return an int of the current number of followers or users following
User.hasNoFollowers and User.followsNoOne: Would return a boolean of if the user has no followers or is following no one. This could easily be done using the implemented methods above or List.isEmpty()

I can start this branch by adding black box unit tests if we want to add these methods, but I'd like to hear people's thoughts on this.
Story Points: 2
Related Issues: #43

Will get closed with issue #110


"LA-2251,LA-2251 bug fix and removing delete functionality"

Reverts pepcus-Aish/simpleJSONEditordemo#1

@pepcus-Aish  Please add more details in the description about what is fixed and how it looks after this


+setAutoCreateSessionEnabled from QBConnection does not exist anymore

I have installed Quickblox version 2.4.3 I can't find this method so my question is: Before sign up or login  should I create a session ? I always get 401,  "Required session does not exist".
It says in the docs that sessions are managed automatically...

Hi,
In the latest versions SDK creates and manages the session automatically, so you dont have to set up anything.
If you are still recieving any errors regarding session creation please provide us more details on it.

Hi , thanks for answering


Add files via upload

@eliasdion First stage of verification passed, official domain is 1epal-neapol.thess.sch.gr as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://1epal-neapol.thess.sch.gr/index.php/mathiteia-epa-l


[GHSA-9822-6m93-xqf4] Rails has possible XSS Vulnerability in Action Controller

Updates

Affected products

Comments
This is a vulnerability in rails actionpack, so affected packages should be registered in actionpack.

Hi there @tenderlove and @jhawthorn! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


Compatibility for v1.2.21

seems because your profile is relatively new, nobody added you to the write-permission group. Can you merge now yourself? :)


Height grows infinite

Hi,
when ich want to load https://jurebu-kombi.vna.de/destinations.xhtml?agency=25297&tripId=2 via iFrame, the height is getting bigger and bigger. How can i stop this behavior. I tried every heightCalculation Method, but nothing helps.
Is it possible to get the class of the iframe body and set a maxHeight after finding „map“?

Check you css, if something is set to be bigger than 100% page height you
create a loop
On Fri, 27 Jul 2018 at 13:52, KARO<EMAIL_ADDRESS>wrote:

Hi,
when ich want to load
https://jurebu-kombi.vna.de/destinations.xhtml?agency=25297&tripId=2 via
iFrame, the height is getting bigger and bigger. How can i stop this
behavior. I tried every heightCalculation Method, but nothing helps.
Is it possible to get the class of the iframe body and set a maxHeight
after finding „map“?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/611, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAkHEkqRPX5x6IVRSs2jskOpii-yNkOHks5uKwz6gaJpZM4Vjcf9
.

--
Sent from my iPhone.

Correct, the iframe source is setting the min-height of the „html“ element to 100%.
What could i do?
Is it possible to get the body class and set a max heigth after finding „map“?

100% is fine, is something else always below the html element? You could
look at using taggedElement and tagging something in your page, set the
tolerance option to the amount it resizes by each time, or get the the real
issue and find and fix the big in your css.
On Fri, Jul 27, 2018 at 4:00 PM, KARO<EMAIL_ADDRESS>wrote:

Correct, the iframe source is setting the min-height of the „html“ element
to 100%.
What could i do?
Is it possible to get the body class and set a max heigth after finding
„map“?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/611#issuecomment-408445206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkHEkvyyUWjh0duyF4Jl3704c_XBaDfks5uKysHgaJpZM4Vjcf9
.

--
David J. Bradshaw )'<EMAIL_ADDRESS>


New issue #1 (test)

Ignore, just debugging some tooling.

Hi Mitch! Good luck with what you're doing! Take care 👋

Enjoy!

Well, its generating the e-mails correctly. They just aren't arriving due to spam filters ;(


Use rationale hash in freeform proposal title

The rationale field was removed from the proposals query due to a datanode bug which prevented any proposals being shown. This means that the title of a freeform proposal uses a (not super helpful) proposal ID. Once the datanode bug is fixed lets revert back to using rationale.hash.

This may not be required as URL and Hash look like they will be removed from proposals https://github.com/vegaprotocol/specs/issues/1184

closing as no longer required due to the changes to be implemented as part of:

https://github.com/vegaprotocol/specs/issues/1184


Add support for local auth configuration

Add an option in jetstream config to set up a user for local authentication as an alternative to remote auth. Will eventually remove the mandatory provisioning of a UAA.

NOTE default.config.properties should be excluded from merge until the corresponding front-end changes have been completed.

I will make a start on documenting the feature and config on a separate branch. That can be merged when the front end PR is complete. In the meantime if it's not clear when you try it out, let me know.


Implement an API for performance monitoring

Design an implement an API which provides information about the performance of the zot server which could be used for debugging.
Let's look at:

storage - how much space is used per repo
storage - how much total space is used
latency counters - min/max/average - per repo per specific time interval

We need to also check what docker is offering in this sense.

https://prometheus.io/docs/concepts/metric_types/

For zot minimal, we can have a in-memory counter set for metrics and under extended, prometheus is fine

We have two cases:
a) for zot extended a Prometheus client library is used (+1MB overhead on the zot binary size)
b) for zot minimal metrics are cached in-memory and a node-exporter was written for the middleware transformation from raw JSON format (zot) -> Prometheus types.
There is no binary overhead by adding instrumentation in this way.
Currently the code for node exporter is here: https://github.com/adodon2go/nodeexporter
The plan is to integrate it inside anuvu/zot (having an extra Makefile target for its build).
Ideally we should add it here after its maturity: https://github.com/prometheus/prometheus/wiki/Default-port-allocations
The types of events we are currently monitoring:

HttpConnRequests - counter - number of HTTP connection requests that was handled by zot server (that can be aggregated by http "method" and return "code" labels)
From this metric we can figure out requests rate (in what period of time the server was really busy) and errors rate.
We can then take a look at another metric : average request latency to see how the server behaved during that period of time
HttpServeLatency - summary - latency of serving http requests (that can be aggregated by image "repo" label)
From this we can figure out the average latency, minimum and maximum latency.
Also what present interest in this area is finding 95 percentile of the requests latency per repo (what is the latency in 95% of all requests made?)
StorageUsage - gauge - how much space each repo is using
UploadCounter & Download Counter - total number times an image was uploaded/downloaded (aggregated by repo)
5  ZotGeneralInfo - contains general information about zot - binary type (minimal/extended), what go version was used to compile the binary, commit number, etc

Other metrics maybe useful like finding out how much memory is zot using, number of goroutines in the system, etc (this should come for free using prometheus client library)

Histogram for what type of HTTP APIs called (GET, PUT, PATCH, etc) so we can tell what type of workload it is - read-heavy, write-heavy, mixed, etc

Here is the log information expecting from SRE point of view:
Size of the blob/layer/container with its name and tag details.
Latency between zot service and S3 bucket
Latency between zot service and client
Start time of request
Transaction time of request
Client IP/hostname
Bytes transferred from client
Response status to client with IP address in one line
Errors in case of terminated transaction.
Crash log location if any and one line reason
Apart from the above through prometheus node exporter, we expect to monitor

POd CPU utilization
POD men utilization
Host CPU and Mem
Pod evictions and their reasons
Container run time storage disk pressure
Host availability

Alerts will be set on all above observability params apart from S3 bucket storage utilization in AWS Will let you know, if I can think of more


fill new table errors

(3/3) ErrorException
Trying to get property of non-object (View: D:\php\OpenServer\domains\lava\blog\resources\views\scaffold-interface\layouts\app.blade.php) (View: D:\php\OpenServer\domains\lava\blog\resources\views\scaffold-interface\layouts\app.blade.php)
(2/3) ErrorException
Trying to get property of non-object (View: D:\php\OpenServer\domains\lava\blog\resources\views\scaffold-interface\layouts\app.blade.php)
(1/3) ErrorException
Trying to get property of non-object
in 8419f0d3f3f8c20cb024e94a862960099ac86cc6.php (line 65)

Normally this is happened because of the user property object.
go to localhost:9000/login and try to login or register a user account.

Error 403

Access forbidden!
You don't have permission to access the requested object. It is either read-protected or not readable by the server.

@jorjik Hi again
I checked and everything is working as expected. well, could you please tell where you got that error exactly.
Thanks

The decision to use port 9000 was an error!!!

so shall I close this issue ?


Allow user to force using internal/external memory

Closes #255

Codecov Report

Merging #365 (cee68b8) into main (d10fe11) will decrease coverage by 0.306%.
The diff coverage is 70.370%.

@@              Coverage Diff              @@
##              main      #365       +/-   ##
=============================================
- Coverage   96.496%   96.189%   -0.306%
=============================================
  Files           58        58
  Lines         3567      3595       +28
=============================================
+ Hits          3442      3458       +16
- Misses         125       137       +12

Impacted Files
Coverage Δ

src/adiar/internal/memory.h
92.857% <ø> (ø)

src/adiar/bdd/if_then_else.cpp
94.754% <64.286%> (-0.883%)
:arrow_down:

src/adiar/internal/pred.h
93.182% <70.000%> (-1.999%)
:arrow_down:

src/adiar/internal/product_construction.h
97.087% <71.429%> (-0.923%)
:arrow_down:

src/adiar/internal/quantify.h
96.053% <71.429%> (-1.226%)
:arrow_down:

src/adiar/internal/intercut.h
96.364% <75.000%> (-0.859%)
:arrow_down:

src/adiar/internal/reduce.h
97.895% <75.000%> (-0.510%)
:arrow_down:

src/adiar/internal/substitution.h
96.552% <75.000%> (-1.095%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10fe11...cee68b8. Read the comment docs.


Better handling of row failures during check-in

Currently, if a row upsert fails, we issue a session.rollback().  However, doing so expires the session that subsequent rows would've written to.  The result is that only rows prior to the failed row get checked in.  This needs to be modified so that a bad row is simply flagged as a failure, and the check-in should continue checking in valid rows.

The conditions stated in the issue do not actually occur.  If a row upsert fails, the process does in fact continue on with further rows.  However, we do need a different issue where row failures are re-exported to Sheets as a batch.


clustering: fix ipv6 advertise addresses

PR Description
The previous logic for handling IPv6 addresses for clustering was flawed.  This PR updates it so IPv6 addresses are properly joined with their ports, avoiding a too many colons in address error upon starting Alloy in cluster-mode.
Which issue(s) this PR fixes
There is not an open issue for this bug.
Notes to the Reviewer
PR Checklist

[x] CHANGELOG.md updated
[ ] Tests updated

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey Matthew! I think this fix makes sense; is there any easy way to add a test so that we don't accidentally regress on this?

I've moved the logic to a separate function so it can be tested independently. Right now it just tests that the port is correctly joined with the IP and that the loopback fallback works. Without digging deeper into where the advertise address is actually used, I cannot easily add a test ensuring that the proper address is used. But the test I did add should help avoid issues if the IP selection and port join logic changes.


Uncouple pipeline steps

Allow the user to run detection only, tracking only, or to evaluate the tracker or detector independently.

A nice modular approach was suggested here:


does the maxReconsumeTimes config really work?

i have config maxReconsumeTimes like below:
spring.cloud.stream.rocketmq.bindings.direct-in.consumer.push.maxReconsumeTimes = 2
anyway, it didn't work at all. Rocketmq still reconsume 16 times before sending message to dlq.
I cann't find config about setting 'maxReconsume' to DefaultMQPushConsumer either.
com.alibaba.cloud.stream.binder.rocketmq.integration.inbound.RocketMQConsumerFactory#initPushConsumer, here i find setting a DefaultMQPushConsumer. But i didn't find the initPushConsumer() method setting the maxReconsume to DefaultMQPushConsumer.

Welcome to contribute，refer: RocketMQConsumerFactory

this task

i will finish it 。

Subscribed

Plz try spring.cloud.stream.bindings.[destinationName].consumer.maxAttempts, maybe remove maxReconsumeTimes  latter.

Plz try spring.cloud.stream.bindings.[destinationName].consumer.maxAttempts.

maxAttempts is a client behavior, maxReconsumeTimes maybe a server behavior

Plz try spring.cloud.stream.bindings.[destinationName].consumer.maxAttempts.

maxAttempts is a client behavior, maxReconsumeTimes maybe a server behavior

Copy that，

This config seems to not working forCaused by: java.lang.ClassCastException: class java.lang.String cannot be cast to class com.dyrnq.sca.rocketmq.MessageInfo  before call in consumerEvent like below code.
exception happened before invoke this will always retry?
    @Bean
    public Consumer<Message<SimpleMsg>> consumer() {
        return msg -> {
            // Mock Exception in consumer function.
            throw new RuntimeException("mock exception.");
        };
    }

@yuhuangbin 2023.x branch missing this too.


_posts/0000-01-02-jerinja.md

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request


Window Swallow swallows windows that shouldn't have been swallowed

In config, it's this swallow_regex=^(foot)$
But if I open a window arrangement like this

Then I press the little toolbox.

The toolbox pop-up window got swallowed!!

In a word, if you got a pop-up and a terminal both in the same workspace, the pop-up will "swallow" the terminal

should be fixed in fd379db8466985edb9ed43823f05372f8b81f058

Yep, I can confirm that this is fixed!
Sry for the late response

Well, the specific way I reproduce it is fixed but not in the "new" way

nvm, I got it, it is in fact fixed


Fix doc which uses wrong property to disable a violation rule

The code sample in the documentation regarding the violation rules ("https://docs.gradle.org/current/userguide/jacoco_plugin.html#sec:jacoco_report_violation_rules") is wrong.
The property "enabled" is part of the task and will disable/enable the task itself. If "enabled=false", the task will be "SKIPPED".
Instead "isEnabled" should be used as a property, to enable/disable the rule.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Thanks @marcusschroeder !


Poisson Recon args

Hi,
Are there any more argument options for the poisson_reconstruction() besides 'depth'? 'Type' or 'samplesPerNode' ?
More importantly, the output mesh comes with lots of extraneous mesh bits (expected when a point cloud is not closed). How can we go about to remove that extra information? Can poisson_reconstruction() output a scalar density field that we can use to cut off low-density areas?
Many thanks!

the code is very well documented: see here


improvementEnable estimate hive table row count using file size.

Enable fetch hive table row count through file list by default. Change the sample partition count to 1000 to reduce resource consumption.
Using a table with 100000 partition to test the performance. Row count could be fetch within 0.2 second and the cpu used is less than 1 core.

run buildall

run buildall


Fix injection for Discord 1.x (Windows)

Discord 1.x has to be injected into Local AppData instead since the other folder doesn't work anymore. Not sure about macOS/Linux :)

@joe27g can you review this?

https://i.imgur.com/WoWblsv.png
In short, ED is dead.

@joe27g <@246107833295175681> Close this PR, it won't even work properly on most Discord module updates (just the first one after a host update, due to the -1 in the module folder name.  So installation to windows will soon be borked anyway most of the time as-is.


Use the lastrevid parameter to speed up the Backfillr Bot

The way I'm making the edits in the Backfillr Bot is not optimal:
When it processes a file, it fetches the current SDC using the API, works out the diff, then posts that back to WMC. There are two problems with this approach:

It's a lot of calls to get the current SDC, even though I have it all sitting in a local snapshot
It's not using the baserevid parameter to detect edit conflicts

If I were to use the SDC from the snapshot with the baserevid parameter, I'd be able to cut out a significant number of API calls, and only call the "get SDC" API when the SDC has changed since the snapshot was taken.

This is a nice idea in theory, but I can't work out what, if any, conflict detection it's doing, at least when adding new statements.
The problem is that if we write a new statement, it doesn't have an ID, and Wikimedia Commons will happily add that as a new statement w/o checking to see if it conflicts with or duplicates an existing statement. Grr.


OIDC Discovery Error: cURL error 28: Resolving timed out after 3000 milliseconds

Describe the Bug
same issue as OIDC Discovery Error: cURL error 28: Resolving timed out after 3000 milliseconds
The configuration is based off Authelia's example
I can curl the OIDC auto discovery end points from the bookstack container.
But when attempting to login using authelia Bookstack throws a cURL time out error 28, as indicated in the screenshot.
the Bookstack instance I am using is currently using the default local authentication that i want to reconfigure for use with Authelia OIDC
Steps to Reproduce

Setup docker containerised bookstack instance
Update the authelia and bookstack setups as per Authelia's example
attempt to login to Bookstack using the SSO / Authelia login.
it produces the cURL timeout error (28) as indicated in provided screenshot
the OIDC auto discovery url works fine when using curl in the bookstack docker container console, returning valid json with defined endpoints. (second screenshot below)

Expected Behaviour
Bookstack logs in using authelia authentication
Screenshots or Additional Context

Browser Details
Brave 1.56.11 on windows 11 64-bit
Exact BookStack Version
23.01.1
PHP Version
No response
Hosting Environment

Dockerised version of Bootstack on a different host machine
vs. Authelia, which is also setup as a docker container.
Reverse proxy: Caddy
Authelia setup to authenticate using an LLDAP instance

It appears the Curl command on the bookstack container console is taking just above 4 seconds to run, which may explain the timeout of 3 seconds in the error.
Is there a way to increase the timeout?
the output of
time curl https://auth.mydomain/.well-known/openid-configuration

real    0m4.281s
user    0m0.043s
sys     0m0.005s

Hi @nabeelmoeen, There is no supported way of changing the timeout, it's a hard-coded value.
The three second timeout is in place mainly to catch error scenarios, since three seconds would generally be far far greater than the time required for this request.
Have you looked into, or do you know, why it's so slow to respond here? Is the auth system running on a particular weak system? Is there something in-between adding latency?

its on a self hosted server, running proxmox and multiple VMs (each VM has between 1 and 2 GB RAM).
I am also using a dynamic DNS (duckdns), and Caddy reverse proxy. the delay could be any number of factors including the DNS lookup (I also have a pihole running), since I am using the external (public host names) for the services vs. LAN IPs.
Any how, since the auto discovery is consistently performing at between 4-5 seconds, we can confirm that's the cause of the error.and short of either modifying / recompiling the code (locally) or a potential future release providing a configuration option for the timeout, I will revert to using local sign in for bookstack.    On Tuesday, 25 July 2023 at 02:46:33 am AEST, Dan Brown @.***> wrote:
Hi @nabeelmoeen, There is no supported way of changing the timeout, it's a hard-coded value.
The three second timeout is in place mainly to catch error scenarios, since three seconds would generally be far far greater than the time required for this request.
Have you looked into, or do you know, why it's so slow to respond here? Is the auth system running on a particular weak system? Is there something in-between adding latency?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Okay, I'd suggest debugging and look to address that delay then since 4-5 seconds indicates something going wrong at some stage.
Since I wouldn't look to change the default timeout due to external present issues, and since you've reverted authentication method, I'll close this off.

I too have encountered a timeout issue running Authelia and Bookstack on a Raspberry Pi 4 Model B rev 1.2.
The access to /.well-known/openid-configuration via time curl takes 0.2-0.3s.
The culprit on my setup is POST /api/oidc/token, which takes ~4.2s (measured via tcpdump).
I'm also asking in the authelia repo how that time delay can be tuned.
Irrespective of improving the OIDC performance, it would be beneficial of allowing the timeout to be configurable (either a global setting or a dedicated setting for operations that are expected to take longer such auth).
Whats your opinion on such an addition, would you take a pull request for it? (Haven't looked at how easy it would be to add yet :thinking: )

@LenardHess It would be a very simple addition to be honest, but I have a general approach of not adding options without a clear need/purpose. I don't really look to add options if they're simply to work around issues external to BookStack, like this seems to me so far.
If there's a fundamental reason for slow OIDC requests, then I'd be happy to consider that, although I'd probably look to bump the default timeout a bit before resorting to a new option.

@ssddanbrown hi dan, could u please point me to the location where I could locally overwrite the timeout for these curl-commands? I tried to figure it out myself but failed... thanks a lot!
(i'm running authentik on a raspberry pi and this piece of python software is very slow, so it's always timing out during bookstack logins..)

@firlevapz This is where I believe the timeout is currently defined:
https://github.com/BookStackApp/BookStack/blob/38829f8a38a5bd90f9cce2535c79131c04ae01d6/app/App/Providers/AppServiceProvider.php#L80
Of course, changes to core app files are not supported and may interfere with updates.
Out of interest, just to help identify a need.

what Raspberry Pi are you running?
How log does the request take?

(As per above, can run something like time curl https://auth.mydomain/.well-known/openid-configuration to check, replacing auth.mydomain).

great, thanks @ssddanbrown! that worked like a charm - increased the timeout to 5 now, it works flawlessly every time! Maybe that would be a nice improvement to set it to 5 seconds, to solve this bug? But I can also write a custom patch for my setup locally.

I'm using a Raspberry Pi 4 with a dockerized setup of bookstack and authentik
curl usually takes about 2,5 seconds to retrieve the configuration, but it also sometimes times out after the OIDC-response. So increasing the timeout is definitely the easiest way for my setup

Okay, based upon the multiple reports here I'll look to bump the time-out to 5 seconds in the next feature release to provide a little extra time for weaker systems, since all reported so far have been within that time.
I'll re-open this to track that change, and have updated the title to suit.

Within the changes in #4525, this has now been bumped up to 5 seconds.
This will be part of the next feature release.


Route parameters with async await?

Currently when i try to use route parameters i get a panic with the message Chain out of cycle from the thruster-core-async-await crate L39.

Yikes! Can you provide a code sample to replicate the issue? Usually that happens when next is called but there isn't any more middleware to next to.

Sure i can! Happy you could respond so quickly. The offending code is here https://gitlab.nebulanet.cc/xacrimon/meme-api. Its very small. The problem happens with the routing and execution of the h_v2_random handler. When i specify a parameter it works without issues but if i omit the parameter it panics while i would expect it to not match the route.

Anything for dank memes!
Im on my phone right now, but will be able to get a closer look tomorrow
when I'm near a computer.
On Thu, Jul 4, 2019, 5:49 PM Acrimon<EMAIL_ADDRESS>wrote:

Sure i can! Happy you could respond so quickly. The offending code is here
https://gitlab.nebulanet.cc/xacrimon/meme-api. Its very small. The
problem happens with the routing and execution of the h_v2_random handler.
When i specify a parameter it works without issues but if i omit the
parameter it panics while i would expect it to not match the route.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/trezm/Thruster/issues/116?email_source=notifications&email_token=AAJWOLISHVCXQUHQ3D2A5YTP5ZV7ZA5CNFSM4H6AAR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZIFO5I#issuecomment-508581749,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJWOLND4QPDPJD5OGHXPLDP5ZV7ZANCNFSM4H6AAR2Q
.

Alright. Do so. I do have a suspicion it is due to the route matching erroneously without queueing the middleware. Thus it causing an out-of-chain.


DRM fix

Would it be possible to rewrite a DRM fix (https://www.xperifix.com) for XZ2*?
I think it applies on boot in initrd, probably by mounting some saved TA partition over a real one.
So AOSP blob will think the phone is still locked and there's no need to cripple the camera features.

Someone posted a link -in a place that i cant find now- that after android pie the camera isn't affected by unlocking the bootloader.
However. The camera needs to be optimized. And this is an ongoing process.

AFAIR it was said that since pie unlocking BL erases less proprietary keys than before, but it still disables some bits.

Anyway. I wouldn't expect something like this to come from this project. There are many stuff to fix in SFOS and the port in general.

AOSP uses different camera implementation and there is an ongoing major work on it. At some point, we will use that updated driver on SFOS as well. That's at least a plan right now.
As for other features disabled by TA wipe, you will have to check out at XDA. To make it properly work, it has to be done on AOSP side, if any. But I don't expect it to be done or be high priority.
Closing over here as its out of scope. But we will work on improving the port :)

And DRM is only part of the stock ROM.
SailfishOS uses the SODP.
Sony Open Device Project is from Sony, but has nothing to do with the stock firmware and its DRM. :)
The camera is just work in progress and will receive updates until the quality becomes good.


install error: process.cwd is not a function

From https://github.com/pikapkg/snowpack/discussions/911
/cc @benoitg

This is a good followup for #854 - how far do we go in polyfilling process? We should just take the snippet that we return in https://github.com/pikapkg/snowpack/edit/master/snowpack/src/rollup-plugins/rollup-plugin-node-process-polyfill.ts & replace it with the Rollup polyfill in its entirety (https://github.com/ionic-team/rollup-plugin-node-polyfills/blob/master/polyfills/process-es6.js) so that we keep parity and also don't have to keep addressing one offs like this one.

Pseudo code
const polyfillPath = require.resolve('rollup-plugin-node-polyfills/polyfills/process-es6.js');
const polyfillCode = fs.readFileSync(polyfillPath, 'utf-8');
...
return `/* SNOWPACK POLYFILL - process */\n${polyfillCode}`;

Testing
Will be covered by existing snapshot tests.

I would like to try it

Awesome! @MoonBall Thanks so much for jumping into these issues and helping out with PRs this last week, I really appreciate it!

Thanks for your praise. Let's make snowpack better.

PS: Do you have a Twitter?

My Twitter is @MoonBall_cxy.

@MoonBall I just tested 2.9.3.  I can confirm this issue is fixed by #920

Sorry, how do I use this? I'm on snowpack 2.15.1 and I'm getting process is not defined


Review connection to multiple devices

Review multiple devices on both Android and IOS.  Will require some changes to the current functionality:

BluetoothDevice (ios) and RNBluetoothService (android) will need to be massaged a little to ensure that they can be created multiple times by the module.  IOS is close to this (if not there) but Android needs to be modified to bring it more inline.
Module would need to update with the functionality to: manage a number of devices (Set most likely)
Javascript side should be updated to manage a BluetoothDevice object as well, which would be used for writing to.  A sample workflow would be:

let device1 = await RNBluetoothClassic.connect("address1");
device1.readUntilDeilmiter()
device1.read();
device1.write("Some data to write");

From what I saw (in IOS anyhow) there are ways to have multiple device emitters.  This may mean that each BluetoothDevice on javascript is also an emitter, although I'm not sure i saw anything on the native side that splits this well.  Otherwise, we could catch events and re-route them to their applicable BluetoothDevice since it should be known and maintained within the RNBluetoothClassic module.

I need to read from multiple devices on Android. How can I contribute?

I'm half way through converting the android version to allow for multiple devices and better configuration. I haven't pushed the branch yet though as it's still a rough cut. If you're interested I can push what I have and you can continue it.  Note that I had lumped a number of changes in with the branch, I just haven't had much time due to covid and my day job (and I don't do much extra programming in the summer).
Or you can run with it yourself.
But if ios isn't completed to match I won't accept a pull request. I don't want to have ios and Android maintained separately, it would make my whole purpose for this moot.

There is a fork that has the ios side done I believe, although I don't like parts of it. I'd have to review both forks to ensure the api is 100% matching.

This is currently available in release/1.0.x branch - serving as pre-release for release/1.60.x.


[next] m.mount() cleanup, fix #727

Win back ~40 bytes (we're still at 8095 bytes, .min.gzipped, though).

Closing, since this issue/PR has not been updated in over a month, and typically, issues inactive for that long do not usually produce any action. If you feel something in Mithril needs added or changed, please file a new issue/PR.


Migrated setup.py and setup.cfg to pyproject.toml

This change aims to bring the coxeter install files up to spec with PEP621. Both setup.py and setup.cfg have been replaced with minimal versions.
Motivation and Context
setup.py install has been deprecated, meaning that a working (and complete) pyproject.toml is important to ensuring users can install from source. In addition, the installation documentation has been updated to ensure the proper install script (pip install .[tests]) is recommended to the user.
Testing

[x] pyproject.toml validity has been checked with pyproject.toml
[x] pip install .[tests]; pytest works as expected
[x] pip install .[doc]; cd doc; make html works as expected
[x] Update docs
[x] Test building wheels

Testing wheels
>python -m pip wheel .
Processing /Users/$USER/Documents/GitHub/coxeter
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
...
Building wheels for collected packages: coxeter
  Building wheel for coxeter (pyproject.toml) ... done
  Created wheel for coxeter: filename=coxeter-0.6.1-py3-none-any.whl size=158710 sha256=4726a0e8f33a894b0d7c3f09462c86f7a62b102a90aff49716886b0675bc9cfa
  Stored in directory: dir
Successfully built coxeter

>ls | grep whl
coxeter-0.6.1-py3-none-any.whl

>python -m pip install coxeter-0.6.1-py3-none-any.whl

Processing ./coxeter-0.6.1-py3-none-any.whl
Obtaining dependency information for...
Installing collected packages: numpy, scipy, rowan, coxeter
  ...
Successfully installed coxeter-0.6.1 numpy-1.25.2 rowan-1.3.0.post1 scipy-1.11.2

Types of Changes

[x] Documentation update
[x] Bug fix
[ ] New feature
[x] Breaking change1

1The change breaks (or has the potential to break) existing functionality.
Optional requirements [test] has been renamed to [tests].
Checklist:

[x] I am familiar with the Contributing Guidelines.
[x] I agree with the terms of the Contributor Agreement.
[x] The changes introduced by this pull request are covered by existing or newly introduced tests.
[ ] I have updated the changelog and the credits.

Wheel building is working, docs build, and tests pass. This is a big change and a second verification of those tests would be greatly appreciated - but it seems like just about everything is in order.


chaperone complex (GO:0101031) missing children

chaperone complex (GO:0101031)
is defined
A protein complex required for the non-covalent folding or unfolding, maturation, stabilization or assembly or disassembly of macromolecular structures. Usually active during or immediately after completion of translation. Many chaperone complexes contain heat shock proteins. [PMID:21855797]
a) this is probably a strange grouping term because it , mixes different types of chaperone
and
b), if it is meant to cover all chaperons, there are many chaperone complexes that are missing this parentage
.
For example,
Swr1 complex, CAF-1 complex, FACT complex (among others) are histone chaperones.

Hi @ValWood
CAF-1 complex, FACT complex are not children of chaperone complex (GO:0101031)
I propose we rename 'chaperone complex (GO:0101031)' to match its definition, as well as the MF term 'GO:0044183
protein folding chaperone' , so it's not ambiguous  anymore. Does that work ?
Thanks, Pascale

Yes, I was going to suggest that. I think that works.


Fixes #3567: Logos in "About" screen are hardly visible in dark theme

Description (required)
Fixes #3567
What changes did you make and why?
Introduced an attr for the fill color of the logos in about screen
Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@isnirp Can you revert the unrelated changes in this PR, which seem to be part of another PR? Thanks.

@isnirp Can you revert the unrelated changes in this PR, which seem to be part of another PR? Thanks.

Hello @sivaraam thanks for your help today. I'm new to this PR stuff... I've been able to revert the unrelated changes.

Codecov Report

Merging #3592 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3592   +/-   ##
========================================
  Coverage      6.97%   6.97%
  Complexity      291     291
========================================
  Files           256     256
  Lines         11692   11692
  Branches        954     954
========================================
  Hits            816     816
  Misses        10805   10805
  Partials         71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b085091...2263374. Read the comment docs.

I'm new to this PR stuff...

That's fine. Everyone's new to it at some point of time. You'll get the idea of it over time :)
You could read the following articles to get a little idea:

About collaborative development models - GitHub Help
About pull requests - GitHub Help

I've been able to rever the unrelated changes.

Thanks.
A couple of things:

Apologies before hand for being pedantic. Have you ensured that the official logos (which are the ones we should be using) distributed by GitHub and Facebook use the same colors that you've used?
If you wish, you could see https://github.com/commons-app/apps-android-commons/issues/3567#issuecomment-604582741 to find links to the official logos.

Format your description as Fixes #3567 to ensure the issue is automatically closed when the PR is merged. Kindly do the same for your other PR too. For more information, see Linking a pull request to an issue - GitHub Help

Hello @sivaraam thanks for the information and the materials shared... I changed the color to white per the comment below.
https://github.com/commons-app/apps-android-commons/issues/3567#issuecomment-604891899
But I can have it changed to the official ones. I can't find that of facebook though.

Thanks @isnirp looks good to me now:)

Thank you @neslihanturan :)

I edited the description accordingly. Please review the docs shared by @sivaraam for next PR. And congratz for your first contribution :fireworks: :)

I edited the description accordingly. Please review the docs shared by @sivaraam for next PR. And congratz for your first contribution 🎆 :)

Thank you :)

But I can have it changed to the official ones.

It's fine. I just checked and the color used in the light versions of the official icons is #ffffff. So, we're good.

I can't find that of facebook though.

For future reference, they could be found at https://en.facebookbrand.com/facebookapp/assets/f-logo/?audience=landing
You can download them after checking the "I have read and accept the guidelines for use." box which enables the "Download" button.

But I can have it changed to the official ones.

It's fine. I just checked and the color used in the light versions of the official icons is #ffffff. So, we're good.

I can't find that of facebook though.

For future reference, they could be found at https://en.facebookbrand.com/facebookapp/assets/f-logo/?audience=landing
You can download them after checking the "I have read and accept the guidelines for use." box which enables the "Download" button.

Thank you @sivaraam


[KYUUBI #2690] Make ProcessBuilder.commands immutable

Why are the changes needed?
close #2690
When SparkProcessBuilder is constructed, the commands are generated according to conf and are immutable, so the tags will not take effect if they are set later.

Make several existing ProcessBuilder commands immutable.
Set tags when building commands.
Fix Flink tags may not be set to the right value.

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

is it possible to resolve te // TODO: Better to do this inside ProcBuilder ? it's confused we update the conf outside the builder. So the result of commands can be immuable.

So can we do this?
Add the parameter engineRefId when constructing ProcessBuilder, and call tagApplication when ProcessBuilder build commands.

yeah I think we can, the engineRefId should be bound to the engine builder

Codecov Report

Merging #2691 (70d0d7d) into master (60b9f6b) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 70d0d7d differs from pull request most recent head f4a830f. Consider uploading reports for the commit f4a830f to get more accurate results

@@            Coverage Diff            @@
##             master    #2691   +/-   ##
=========================================
  Coverage     64.07%   64.07%
  Complexity      275      275
=========================================
  Files           407      407
  Lines         19076    19074    -2
  Branches       2568     2568
=========================================
  Hits          12222    12222
+ Misses         5702     5699    -3
- Partials       1152     1153    +1

Impacted Files
Coverage Δ

...kyuubi/engine/spark/SparkBatchProcessBuilder.scala
96.66% <ø> (ø)

...ache/kyuubi/engine/spark/SparkProcessBuilder.scala
83.60% <ø> (-0.27%)
:arrow_down:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
68.00% <0.00%> (-1.34%)
:arrow_down:

...apache/kyuubi/session/KyuubiBatchSessionImpl.scala
90.90% <0.00%> (-0.40%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
96.62% <0.00%> (-0.12%)
:arrow_down:

...rg/apache/kyuubi/engine/trino/TrinoSqlEngine.scala
59.64% <0.00%> (+7.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b9f6b...f4a830f. Read the comment docs.

thanks, merging to master


[Enhancement] Optimize creation of scan mv in register mv

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #13969
Problem Summary(Required) ：

The creation of scan mv in register mv during mv query rewrite can be optimized.
Originally the creation of scan mv is based on sql,which can be enhanced
by constructing LogicalOlapScanOperator directly.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 95 / 100 (95.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/PlannerProfile.java
0
2
00.00%
[221, 222]

:large_blue_circle:
com/starrocks/sql/optimizer/MvRewritePreprocessor.java
81
84
96.43%
[59, 70, 78]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/MaterializationContext.java
6
6
100.00%
[]

run starrocks_admit_test


Add option to configure other node address like localhost directly on the deployed version

On this topic (maybe warrants a different issue), is it possible to have something like a default list of node endpoint URLs in some config file?


Master

front end matches documents

Current coverage is 19.56%

Merging #34 into master will not affect coverage as of a36167e

@@            master     #34   diff @@
======================================
  Files           86      86
  Stmts          961     961
  Branches        63      63
  Methods
======================================
  Hit            188     188
  Partial          5       5
  Missed         768     768

Review entire Coverage Diff as of a36167e

Powered by Codecov. Updated on successful CI builds.


test(all): add service worker log capture

Allure Report
allure-report-publisher generated test report!

processReports: ✅ test report for 5f4f10d6

passed
failed
skipped
flaky
total
result

Total
32
0
4
0
36
✅


Feat - LFU cache implementation

LFU cache eviction policy support in Dice

How LFU cache is implemented?

The implementation is similar to Redis - details
The access counter of a key is piggybacked to the LastAccessedAt field in Dice Obj defined here. The first 8 bits is allocated to maintaining the access counter and the last 24 bits are allocated to maintaining the last access time of a key
The access counter is an approximate counter which is incremented logarithmically
This PR does not include support for the decay mechanism as of yet.
This LFU implementation do not add any additional memory footprint

Issue: https://github.com/DiceDB/dice/issues/10

@JyotinderSingh please have a look. TIA!

@Rits1272 Please squash your commits before you push. You can do this once all changes are done.

Hey @Rits1272, could you please address the comments and fix any conflicts? This PR has been open a while, let's try to get it merged.

@JyotinderSingh didn't get time this week, but will work on adding test cases, resolving conflicts and comments by this weekend

@JyotinderSingh sorry for the delay. I have added test cases, please review
Since the PR has gotten stale, there are many conflicts from previous commits. Can we use Squash and merge for this PR during merge to master?


Removing Selected Assets (images) from camera roll after picking

Hi. First of all thanks for this awesome picker.
My query :  I want to delete images from camera roll after saving them in my app. I want those selected images to delete permanently from my camera roll. I am not sure how and where to take a start. Please help me. Thanks :)
Here's my code of opening DKPickerController and saving photos.
    func showImagePicker() {
    pickerController.defaultSelectedAssets = self.assets

    pickerController.didSelectAssets = { [unowned self] (assets: [DKAsset]) in
        print("didSelectAssets")
        print(assets.count)

        for asset in assets {
            asset.fetchOriginalImageWithCompleteBlock({ (image, info) in
                print(image!)
                self.storePhoto(image2: image!)  // Saving Images in my app through this function
                self.collectionView.reloadData()
            })
        }

        self.assets = assets
        self.collectionView?.reloadData()
    }
    self.present(pickerController, animated: true) {}
}

Hi @Owaisss10
Try this:
...
for asset in assets {
    asset.fetchOriginalImageWithCompleteBlock({ (image, info) in
        print(image!)
        self.storePhoto(image2: image!)  // Saving Images in my app through this function
        self.removeAssetFromCameraRoll(asset) // delete images from camera roll
        self.collectionView.reloadData()
    })
}
...

func removeAssetFromCameraRoll(_ asset: DKAsset) {
    PHPhotoLibrary.shared().performChanges({
        PHAssetChangeRequest.deleteAssets(PHAsset.fetchAssets(withLocalIdentifiers: [asset.localIdentifier], options: nil))
    }) { (success, error) in
    }
}

Worked like a charm ! :')
Thank you very much.


visualisation of (undefined/external) agents and activities

Agents are rendered in a pentagon/house shape, and activities as a rectangle. If now an agent/activity is not defined/declared within a PROV document, but is external (e.g. defined in a previous PROV document), then the dot graph is topographically still rendered correctly (with edges and the undeclared element rendered in grey), however the shape of the element is an oval (that of an entity).
I suppose that by the context (the type of an edge, e.g. through the wasAttributedTo or the wasGeneratedBy edges), the prov library may be able to declare the shape of the vertex for graph rendering with dot consistently.
Or is there something I'm missing, thus making the rendered graph and its behaviour correct in this context with undeclared vertices?

Hi @pohutukawa,
Thank you for the suggestion. I have implemented it in the above commit in the dev branch. For example, the statement used(a1, e1, - will generate the following:

I'm planning to make a minor release shortly, which will include the above feature.

BTW, works fine now. Would be good to get this merged into master with a service release.


Getting F821 Undefined name "xyz" for typing.Literal values when imported indirectly

Description
Ruff complains with F821 Undefined name "xyz" for the values described in arguments typed as typing.Literal. I was however only able to reproduce this when Literal is imported indirectly (i.e. not from typing import Literal).
As an example, the following file passes all checks:
from typing import Literal

a: Literal["fu", "bar"] = "fu"
a = "bar"

But this does not:

x.py
from typing import Literal
__all__ = ["Literal"]

y.py
from x import Literal
a: Literal["fu", "bar"] = "fu"
a = "bar"

Output:
$ ruff y.py
y.py:2:12: F821 Undefined name `fu`
y.py:2:18: F821 Undefined name `bar`

Reproduced without any configuration changes.

Ruff version:
$ ruff --version
ruff 0.0.225

Yeah we don't track that the re-exported Literal in that case is the same as typing.Literal.
We do have something to support this use-case though. If you want to treat every member of x as if it's a re-export of a typing member, you can do:
[tool.ruff]
typing-modules = ["x"]

(Relevant docs are here: https://github.com/charliermarsh/ruff#typing-modules)

(The canonical use-case for this is projects that have some kind of compatibility shim over typing and typing-extensions.)

Neat, that is exactly the use case (reference).

I'll close this as it is clearly pointed out in the documentation (😅)

Oh nice! Good to know that there are more examples of this, and glad it solves your problem :)

Solves my problem too, thank you! Though I use relative imports, so it seems to not be triggering on from .._compat.typing import Literal. If I change it to absolute, then it works.

Ah good call -- filed as #2005!

@henryiii - Heads up, I also checked out scikit_build_core and verified that (e.g.) F821 errors aren't being triggered for Literals with typing-modules = ["scikit_build_core._compat.typing"].


fixed getting stuck in exit

discussed here

1e3dcd2 is better fix because we can't assure that start.y+1 is a free spot


bug: colors not being used to build highlight groups

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.x
Operating system/version
PopOS 22
Describe the bug
Hello!
The docs clearly state:

These colors are utilized to generate the highlight groups.

However, none of the highlights (in extras/lua/*) use the colors defined in the colors table, but rather just duplicate the raw hex values:
e.g., (night theme):
local colors = {
  -- ...
  purple = "#9d7cd8",
  -- ...
}

local highlights = {
  -- ...
  ["@keyword"] = {
    fg = "#9d7cd8",
    style = {
      italic = true
    }
  },
  -- ...

The docs make it sound like it should be:
-- ...
local highlights = {
  -- ...
  ["@keyword"] = {
    fg = colors.purple,
    -- ...

If the highlights table was constructed with the colors table, then there would be no need to duplicate them between the different themes...all that needs to be changed is the colors used.
Steps To Reproduce
n/a
Expected Behavior
I would expect the highlight groups to use the colors defined in the colors table instead of duplicating the raw hex values.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

The highlights ARE using the colors defined in the colors table.
I have no idea what you're talking about tbh.
Check the theme.lua file.

The extras are auto-generated at build time.
The can't use any customizations you did in Neovim, since extras are not supposed to run inside Neovim

The real code that generates the extras is in lua/tokyonight/extras.
The files you are referring to are auto generated.
That is also explained at the bottom of the readme

The extras are auto-generated at build time.

Ah okay, but still the highlights table could still reference the colors table to prevent duplication right?

That lua file is not even a real extra. Have you read the docs?

Those extras don't use lua, so they can't refer to a lua table.
That lua extra is just for users that want to implement an extra and want to see what the colors resolve to.

Also, what is the issue you experienced? Is something not working?

Ah sorry for the confusion.
I was looking to override the default highlight for @variable (looks too white for me)---the docs pointed me to the extras to see the default colors:

For default values of colors and highlights, please consult the storm, moon, night, and day themes.

I just assumed that these files were the ones being used to build the colors.


Dark mode does not work in vivaldi for local files

I am using Midnight Lizard with Nord theme and by default it does not work in vivaldi for local html files opened via Ctrl-O. Seems to be a vivaldi-only problem (Firefox works fine for both websites and local html files) and only for local files (opening a website in vivaldi, even a local one via http://locahost works fine).
I have tried to explicitly enforce the Nord theme via Midnight Lizard -> Activation, but when I set the include match pattern to file:///. I get a None of the patterns match current page under the textbox and the Nord theme still does not get applied to the opened local html file.

It is forbidden by default in Chromium based browsers like Vivaldi.
To enable it please navigate to vivaldi://extensions
Find Midnight Lizard and open its Details
There just toggle: Allow access to file URLs

Thank you. Perhaps including an explicit hint about in Activation dialog could be useful. I wasn't able to figure this on my own, only looked in Midnight Lizard's own settings many times before opening the issue.


Suggestion: To re-organise the Data Structures folder

Data Structures folder can be re-organised by adding a sub-folder for Linked Lists and collecting solutions of LL of  the folder into the new subfolder.
Programming language

[ ] C
[ ] C++
[ ] Java
[ ] Python

@AtrikGit6174 structuring the files is something I was thinking about too...
Either it could be program wise or language wise.
Something that can be discussed.

@Ayush7614 thoughts?

I think doing it program-wise will be better...
Actually many problems are found similar across the sites. If there would have been a way of linking shortcuts, then it would have been much beneficial to keep one copy of same problems across the various folders of CP-sites.

@AtrikGit6174 I guess someone is already working on this issue. #1681


Change payment processing

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[ X]

Hi, for a custom project I'd like to change the payment from an hour-based calculation to an day-based (rent of technical equipment). Is this any where configurable or changeable in the code?
And I'd like to offer special rates for weekends? Where do I have to look / change the code to define own rules how the total payment amount is calculated?
Many thanks in advance

Hi, I found one part of my answer hidden in the docs. For every one searching this too, see the documentation in /doc/times.md
But my question concerning the calculation is still relevant. Any hints?

Hi,
To pass to hour mode to day mode you have to change time_unit parameter in CoreBundle from 60 to 1440.
The price calculation is made into \Cocorico\CoreBundle\Model\Manager\BookingManager::checkBookingAvailabilityAndSetAmounts method.
But offerer can choose to have different prices for week end or any other days in his dashboard listing calendar edition.