Ember.set on session data does not update the LocalStorage (but session.set works)

This works and does update the LocalStorage:
session.set('data.with-session-set', true);

But this does not update the LocalStorage:
Ember.set(session, 'data.with-ember-set', true);

If you do session.set after an Ember.set both values will be written.
This is unexpected and undocumented behaviour.
Here is minimal git Project demonstrating the Problem.

This is a known bug which I hope to fix in 1.2.

I'm starting to dive into this.

I have tested this on multiple versions of Ember and different scenarios, as well as written a test for it and it seems to be fixed.

I believe we might still be seeing this issue (Ember 2.7.2 / ESA 1.1.0). We're using devise-token-auth on the backend and need to update the client with a new token after each response.
Doesn't work
handleResponse(status, headers) {
  ...
  this.get('session').set('data.authenticated.access-token', headers['Access-Token']);
  this.get('session').set('data.authenticated.expiry', headers['Expiry']);
  ...
}

Works
handleResponse(status, headers) {
  ...
  this.get('session').set('data.authenticated.access-token', headers['Access-Token']);
  this.get('session').set('data.authenticated.expiry', headers['Expiry']);
  this.get('session').set('data.foo', 'bar'); //Hack
  ...
}

Also Works
handleResponse(status, headers) {
  ...
  var new_session = this.get('session.data');
  new_session["authenticated"]["access-token"] = headers['Access-Token'];
  new_session["authenticated"]["expiry"] = headers['Expiry'];
  this.get('session.store').persist(new_session);
  ...
}

@steveclarkin Thank you for the hack.
I took sometime and looked into it, the reason this hack works as following
Since internal-session itself is ObjectProxy[Link] (https://www.emberjs.com/api/ember/2.14.1/classes/Ember.ObjectProxy) object.
this.get('session').set('data.foo', 'bar'), it update content to content.data.foo = bar .
Will trigger setUnknownProperty(in internal-session) and cause content object to update.
Then setUnknownProperty will call _updateStore(), which calls _callStoreAsync('persist', data)
persist calls adaptive.js 's persist, which eventually calls local-storage.js 's persist to update browser's _localStorage_ to store the latest content`.
I definitely like
  var new_session = this.get('session.data');
  new_session["authenticated"]["access-token"] = headers['Access-Token'];
  new_session["authenticated"]["expiry"] = headers['Expiry'];
  this.get('session.store').persist(new_session);

better, wondering if there's a better way than calling persist explicitly.
BTW, data object became oneway in internal-session so, we need to change above code to
    this.set('session.content.authenticated.user.activated', true);
    let newSession = this.get('session.content');
    this.get('session.store').persist(newSession);


Release azure-cli-core 2.0.3

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Codecov Report

Merging #2873 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2873   +/-   ##
=======================================
  Coverage   63.17%   63.17%
=======================================
  Files         466      466
  Lines       26139    26139
  Branches     3997     3997
=======================================
  Hits        16514    16514
- Misses       8544     8547    +3
+ Partials     1081     1078    -3

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/__init__.py
100% <100%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
68.99% <0%> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
31.95% <0%> (ø)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923dfa6...7cb4e3e. Read the comment docs.

Started releasing azure-cli-core 2.0.3...

Release of 'azure-cli-core' with version '2.0.3' successful. View at https://pypi.python.org/pypi/azure-cli-core/2.0.3.

GitHub release created. https://github.com/Azure/azure-cli/releases.


Can not support vite-ssr auto import

Describe the bug
AutoImport({
      imports: [
        'vue',
        'vue-router',
        'vue-i18n',
        '@vueuse/head',
        '@vueuse/core',
      ],
      dts: 'src/auto-imports.d.ts',
      dirs: [
        'src/composables',
        'src/store',
        'src/common',
        'src/common/**',
      ],
})

use viteSSR:
"vite-ssr": "^0.17.1",

vercel debug console:
ReferenceError: getSEOLinks is not defined

but getSEOLinks function in 'src/common/tools.ts'
How to fix this. Thanks
Reproduction
stable
System Info
pnpm run build:ssr && pnpm run deploy:ssr:prod

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

need reproduction


ENH: Add cat from file functionality

It could be more convinient in some cases to store the files to concatenate into a file e.g. a csv rather than passing them as arguments in the cat command, for example, if there are a lot of pdfs to merge. For this a possible new command could be:
cat-from-csv "pdfs_data_to_merge.csv"  --filescol "col_with_file_paths" --pagescol "col_with_pages_to_cat".

this is a good idea~I also think so.I will try on the issue.     :)

I can try to create PR on this, if you want

I'm not sure that this really needs to be embedded in pdfly...
Fur such task, it may be better to combine pdfly cat with a CSV-parsing command like xsv or csvkit, or simply to write a dedicated Python script.
Quoting The UNIX Philosophy by Mike Gancarz:

Small is beautiful.
Make each program do one thing well.
...
Make every program a filter.


Bug in numba example

file is titled: "nubma_example.py"
https://github.com/Azure/aztk/blob/master/examples/src/main/python/gpu/nubma_example.py#L64 this line doesn't calculate a percentage

whoops


About

cc @maelle
Addresses issue #8 and some of issue #29
preview: https://about--cranky-lalande-e3373f.netlify.app/about/

In the post list, I'd expect the second post to come before the first one?

In the post list, I'd expect the second post to come before the first one?


Use Husky instead of pre-commit package

Is your feature request related to a problem? Please describe.
there is a better "pre-commit" package called husky
Describe the solution you'd like
run tests on push, run lint on commit
Describe alternatives you've considered
it's just a idea to make this more production ready, but still customizable
Additional context
https://www.npmjs.com/package/husky

Hey @conradkirschner, thanks for your suggestion! Our dev branch has already been switched to husky and so it will become the default with our next release.


Change Detection using MoCo SSL for S1 SAR 2 bands

Hi. Thanks for your awesome work and making this open source.
I am particularly interested in using the pre-trained model MoCo-ResNet50-S1-SAR-2-bands and integrating it with transfer_change_detection using the OSCD dataset.

What exactly are the preprocessing steps that are done when training the MoCo SSL backbone just using the S1 bands?
When integrating this pre-trained model with transfer_change_detection, are there any necessary steps that should be taken before training using OSCD dataset?

Thanks very much for your help.

Thanks for your question.

What exactly are the preprocessing steps that are done when training the MoCo SSL backbone just using the S1 bands?

We suppressed extreme values, and normalized the dB scale SAR images with mean and standard deviation for each channel.
https://github.com/zhu-xlab/SSL4EO-S12/blob/8b943466396c1eedb031f7175db0a0df167d0bc0/src/benchmark/pretrain_ssl/datasets/SSL4EO/ssl4eo_dataset.py#L104

When integrating this pre-trained model with transfer_change_detection, are there any necessary steps that should be taken before training using OSCD dataset?

We only used optical images for our OSCD experiments, but for SAR should be similar. It could be helpful to supress extreme values and normalize the pixel values either with OSCD mean and std, or mean and std from our dataset.
Hope the above would be helpful.

Thanks very much for your feedback. I used the mean and std values from OSCD dataset and updated the code to read and train using OSCD S1 Bands. But there is something wrong during the training. After training for five epochs, the val/precision and val/recall becomes completely zero as shown below. Your feedback is greatly appreciated. Thanks.
Epoch 4: 100%|██████| 27/27 [05:41<00:00, 12.65s/it, loss=0.182, v_num=0, train/loss=0.172, val/loss=0.227, val/precision=0.000, val/recall=0.000, val/f1=0.000, train/precision=0.00283, train/recall=0.000221, train/f1=0.000411]
Below are the screenshots from tensorboard logger

Does it work with training from scratch without loading a pre-trained model? I didn't test it on SAR-only, guess you have to tune the hyperparameters a bit.

Thanks very much @wangyi111. Increasing the epochs did the job but it seems something is still wrong in the training.

Can you suggest some of the hyperparameters that needs to be changed?
Is there any way I can see the network architecture (similar to keras model.summary() or like a keras.utils.plot_model()) for the below two models?

https://github.com/zhu-xlab/SSL4EO-S12/blob/8b943466396c1eedb031f7175db0a0df167d0bc0/src/benchmark/transfer_change_detection/main_oscd.py#L49
https://github.com/zhu-xlab/SSL4EO-S12/blob/8b943466396c1eedb031f7175db0a0df167d0bc0/src/benchmark/transfer_change_detection/models/segmentation.py#L17-L18


Compiling and bugs

I'm sorry to ask a very newbie question, but given the relevance of the project would someone care to give some hints on how to compile the project? I was able to extract the firmware. Although the firmware version was the same, the checksum was different, fixed that, the compiler asks for breath.Bin and asks if I performed make, which I did without result. Another problem is stubs which says there is no target. How should I proceed, please?

Technically (as far as I understand it) you do not need to make, unless you want breath and graph. For patch-airsense, just comment out patch_code or reference https://github.com/osresearch/airbreak/issues/33

Thank you for the reply. I was able to generate unlocked-stm32.bin by adjusting the hash on the patch, but my understanding is that without breath.bin the cvap and other  functions would not become available. Can anyone confirm that? If so, how to compile breath.c or breath.o and the others?

I'm not sure, but I think the compilation requires a xml generated by Ghidra (could try importing it using cortex as the language). Haven't really looked into it too deeply this far. Nonetheless, if you do compile it and generate the firmware, be aware the hex comparisons revealed that the breath.bin offset location for 306 is different than the 401 one for breath.bin, but it may still run (like said, haven't taken the time yet to test this yet).

@dblunk88 is there a way to PM you ?

I don't know if I'd be the best person to PM, but sure. I could temporarily post my discord, Twitter, or E-Mail If you want.

you seem to be the most active/helpful. I don't really need help just have a question about 401. email would be great. thanks.

@gszakacs sure<EMAIL_ADDRESS>Let me know when you have it


MRG, MAINT: Try conda-forge

Different approach to #7946 (just replace entirely; cc @hoechenberger ). Let's see what breaks! Locally at least I can create a seemingly-working env from this. It still only gets qt 5.12 on Linux which is a bummer, but might be good enough.

[x] Wait for Mayavi to release 4.7.2
[x] Wait for conda-forge to update to 4.7.2
[x] Move everything out of pip section

If this works, I can also take the channels: - conda-forge/label/vtk_dev from server_environment.yml to get it so that the only three things left in pip are mne/mayavi/PySurfer, which are stuck until mayavi updates. (We currently list pysurfer and mayavi in our requirements in the conda-forge recipe).

PyQt5 is still problematic if we don't move all packages that depend on pyqt to conda. Currently, it seems like at least pyvistaqt installed via pip will have a PyQt5 dependency, which will then overwrite whatever the pyqt package from conda installed previously. Besides creating conda-forge packages for these remaining packages (which would be the best solution), are there any alternative solutions to this problem?

One alternative we should try is a pip only environment. In my experience, this should have a pretty high chance to work out of the box.

PyQt5 is still problematic if we don't move all packages that depend on pyqt to conda. Currently, it seems like at least pyvistaqt installed via pip will have a PyQt5 dependency, which will then overwrite whatever the pyqt package from conda installed previously.

I don't think so -- removing the pip part entirely and doing:
$ conda env create -n test -f environment.yml -v
...
$ conda activate test
$ pip install pyqt5
Requirement already satisfied: pyqt5 in /home/larsoner/anaconda3/envs/test/lib/python3.8/site-packages (5.12.3)

pyqt                      5.12.3           py38ha8c2ead_3    conda-forge
pyqt5-sip                 4.19.18                  pypi_0    pypi
pyqtchart                 5.12                     pypi_0    pypi
pyqtwebengine             5.12.1                   pypi_0    pypi

No idea why those other components are from pypi...

I don't think that's true:
$ conda create -n test pyqt
$ conda activate test
$ pip install pyqt5
Collecting pyqt5
  Using cached PyQt5-5.15.0-5.15.0-cp35.cp36.cp37.cp38-abi3-macosx_10_6_intel.whl (55.3 MB)
Collecting PyQt5-sip<13,>=12.8
  Using cached PyQt5_sip-12.8.0-cp38-cp38-macosx_10_9_x86_64.whl (63 kB)
Installing collected packages: PyQt5-sip, pyqt5
Successfully installed PyQt5-sip-12.8.0 pyqt5-5.15.0

Indeed I get that behavior with your command. If I use conda-forge like in this PR's environment.yml:
$ conda create -c conda-forge -n test pyqt
...
$ conda activate test
$ pip install pyqt5
Requirement already satisfied: pyqt5 in /home/larsoner/anaconda3/envs/test/lib/python3.8/site-packages (5.12.3)

Can you reproduce? If so it seems like this is one (nice) difference between defaults and conda-forge provided PyQt's

I can try to package pyvistaqt for conda-forge tomorrow.
Another issue is mayavi, since typically conda-forge only accepts released package versions, while we currently seem to depend on an unreleased development version

Indeed I get that behavior with your command. If I use conda-forge like in this PR's environment.yml:
$ conda create -c conda-forge -n test pyqt
...
$ conda activate test
$ pip install pyqt5
Requirement already satisfied: pyqt5 in /home/larsoner/anaconda3/envs/test/lib/python3.8/site-packages (5.12.3)

Can you reproduce? If so it seems like this is one (nice) difference between defaults and conda-forge provided PyQt's

I see what @larsoner sees here.

Indeed for some reason the conda-forge pyqt package manages to sync its name with pip - if I do pip list I see a PyQt5 package installed, which is not the case in the defaults channel. Anyone know how this works?

@larsoner pysurfer is also in available in conda-forge. @hoechenberger it looks like the only package not available is mayavi, because we need some changes that have not been released yet. Maybe we can ask them if they are up for a new release?

And while we're at it, mne is of course also available from conda-forge 😝 .

And while we're at it, mne is of course also available from conda-forge 😝 .

So the way I typically used set up my MNE environment was, in fact, by simply doing
conda create -c conda-forge -n mne mne
conda activate mne
conda remove --force mne
pip install --no-deps -e ~/Development/mne-python

Obviously this doesn't work nicely anymore since the development dependencies have changed quite a bit since the last stable release, but … yeah, just wanted to share this with you. :)

@hoechenberger this nicely outsources everything in environment.yml to the conda-forge mne recipe. Do we want to go this way? Personally, I'd say yes.

@hoechenberger this nicely outsources everything in environment.yml to the conda-forge mne recipe. Do we want to go this way? Personally, I'd say yes.

I think we'd have to decide whether this shall be used for stable releases only, or also for development versions.
For releases, it should be no problem. If there's any pip-only dependencies, we should either package them for conda-forge too or provide a super-slim environment.yml that installs them.
For development versions, where all the dependencies are more dynamic, things might be a bit trickier, I guess. conda-forge currently doesn't support nightly or development builds of software. We could, however, work around this by git-tagging master once per day or week or so, and either maintaining a separate mne-dev conda-forge package, or creating a branch on mne-feedstock, which would allow us to publish different versions of the same package (all under the mne name).

What about this:

Provide mne-base on conda-forge, which installs only the most important hard dependencies (e.g. numpy, scipy, matplotlib)
Provide mneon conda-forge, which depends on mne-base and installs all additional (optional) dependencies (such as mayavi, vtk, etc.)
Use an environment.yml for the current dev version

What about this:

Provide mne-base on conda-forge, which installs only the most important hard dependencies (e.g. numpy, scipy, matplotlib)
Provide mneon conda-forge, which depends on mne-base and installs all additional (optional) dependencies (such as mayavi, vtk, etc.)
Use an environment.yml for the current dev version

I like this idea. I've been wanting to create an  mne-base package for a long time now… Which core deps would we need – how "basic" is base? Would we include pandas as well? And matplotlib -- or matplotlib-base? (the former comes with the Qt backend, the latter doesn't)

I like this idea. I've been wanting to create an mne-base package for a long time now… Which core deps would we need – how "basic" is base? Would we include pandas as well? And matplotlib -- or matplotlib-base? (the former comes with the Qt backend, the latter doesn't)

We could include just the required deps as mentioned in our README (numpy and scipy), but I tend to see matplotlib as a mandatory (or at least core) dependency as well. Not sure about matploblib or matplotlib-base though, but if the Qt backend is the only difference this will affect only macOS anyway, because I assume that they include the platform default backend in matplotlib-base. So I'd include matplotlib-base because this enables plotting on all three platforms (although we often advocate for the qt backend I still think the osx backend works nicely out of the box).
So except for these big three (numpy, scipy, and matplotlib-base) I wouldn't include any other dependency. pandas is not essential IMO.

FYI Mayavi will hopefully release in the next couple of weeks, see:
https://github.com/enthought/mayavi/pull/931#issuecomment-662895480

This PR was bit by the same bug as master on the pip-pre build (#8050, https://github.com/numpy/numpy/issues/16913, https://github.com/xianyi/OpenBLAS/issues/2728, https://github.com/xianyi/OpenBLAS/pull/2729) worked around the same way by setting OPENBLAS_CORETYPE="prescott" in the env vars.
So now we just want to decide if we want to go with conda-forge. I think it's worth a shot. Maybe wait on this until Mayavi releases, then everything can be conda-forge based. And if we're lucky, the OpenBLAS bug fixes will be in NumPy and SciPy as well. WDYT @cbrnr @hoechenberger @drammock ?

I think that's a great idea! Let's wait until Mayavi makes a new release and let's track progress in the OpenBLAS issue, and then we should be ready to go conda-forge.
What about my suggestion of splitting the release packages into mne-base and mne? Our pip package mne is already like an mne-base, but we can discuss PyPI stuff separately (this is now only about conda-forge). I would really like the idea of having two user packages, and for the dev env we could still have an environment.yml (probably also mostly based on conda-forge).

@cbnr I will create as MNE-base package before lunch today. :)

@cbrnr I will create as MNE-base package before lunch today. :)

https://github.com/conda-forge/mne-feedstock/pull/37

So now we just want to decide if we want to go with conda-forge. I think it's worth a shot. Maybe wait on this until Mayavi releases, then everything can be conda-forge based. And if we're lucky, the OpenBLAS bug fixes will be in NumPy and SciPy as well. WDYT @cbrnr @hoechenberger @drammock ?

Does it make sense to wait until #8009 is sorted out too?  I'm wary of changing our install instructions too many times in quick succession.  Perhaps that worry is more related to the suggestion of splitting off an mne-base package (which I'm not quite sold on yet).  Regardless, I'd like some time to test more thoroughly on different versions of macOS (after the mayavi release of course).

I think of mne-base as an advanced user thing, I don't think it should even show up in the advanced instructions. I think we want conda install mne to pull in the optional deps, and that we should tell people to use that version (unless they have a good reason not to).

I agree with @larsoner, although I would include mne-base in the advanced instructions. After all, this should also be supported by us.

@larsoner says:

I think of mne-base as an advanced user thing, I don't think it should even show up in the advanced instructions.

@cbrnr says:

I agree with @larsoner, although I would include mne-base in the advanced instructions.

OK, now I'm confused.  I thought mne-base was just MNE, numpy, scipy, and matplotlib.  That is not an advanced-user option, that is the first option we now offer in the install docs: "if you only want to do EEG / sensor level stuff, just do pip install matplotlib mne..."  What am I missing here?

I hadn't noticed that about our current install docs. If you think mne-base is the way to go in those docs I'm fine with it @drammock

So the docs would say something like this?

If you just want sensor-level analysis, do conda install mne-base.  If you want to be able to plot in jupyter notebooks or use the Qt backend for matplotlib, also do conda install matplotlib.  If you want to work with epoch metadata, also install pandas. If you want to do 3D plotting, do conda install mne and you'll get everything...

Am I alone in thinking that we're giving people too many choices?  What is the rationale for mne-base exactly?  Or put another way, if we can get the Qt / mayavi / vtk / etc. issues sorted out, such that conda install mne will just work on all platforms, what is the problem with telling EEG-focused users to conda install mne?  Is it a disk space issue? If so, perhaps we should be recommending miniconda instead of anaconda.

Or put another way, if we can get the Qt / mayavi / vtk / etc. issues sorted out, such that conda install mne will just work on all platforms, what is the problem with telling EEG-focused users to conda install mne? Is it a disk space issue? If so, perhaps we should be recommending miniconda instead of anaconda.

This is the direction I was thinking to go with conda install mne (and don't bother telling people about the other options). Give them a MNE-complete environment, people who want to cherry pick can do so in their own ways. We can mention mne-base in the advanced docs if we want. But the primary install docs can go back to the one way of installing a complete env.

I think mne (everything) should be the default option for almost all users. However, some users might prefer to install only packages that they need, therefore we have mne-base. Actually, mne-base will be identical to mne in PyPI.

This is the direction I was thinking to go with conda install mne (and don't bother telling people about the other options). Give them a MNE-complete environment, people who want to cherry pick can do so in their own ways. We can mention mne-base in the advanced docs if we want. But the primary install docs can go back to the one way of installing a complete env.

OK, now I get it, and I'm on board.

Actually, mne-base will be identical to mne in PyPI.

mne in PyPI doesn't pull matplotlib by default, right?  So mne-base won't be identical, but that's fine.  Almost everyone will want matplotlib.

Correct, but mne-base will pull matplotlib-base.

Can't move forward with VTK9 until https://github.com/conda-forge/mayavi-feedstock/pull/45 is merged (or some other similar PR). In the meantime I'll try removing our >=9 pin, I think we had that to optimistically fix some rendering bugs, not sure it ever actually happened. @GuillaumeFavelier do you recall if there was another reason we wanted VTK9 specifically over 8.2?

Hm... Plots that would require depth peeling didn't it at all after vtk 9.
It's really required for the notebook 3D backend though (server_environment.yml).

Okay, then this PR should probably wait until VTK9+mayavi is properly supported on conda-forge. Or we can kill mayavi+PySurfer from the requirements list instead...

Okay, then this PR should probably wait until VTK9+mayavi is properly supported on conda-forge. Or we can kill mayavi+PySurfer from the requirements list instead...

We don't need either of them anymore, do we?

It's still required for coreg I think

It's still required for coreg I think

Oh, that could be. We need to pay @GuillaumeFavelier more to get this out of the way too! 😁

The beast is the next on my list :)

VTK9 is available in conda-forge so things work more reasonably here now. Getting server_environment.yml updated was tricky so I just postponed that for now.
Last time I pushed there was a failure with library importing on Azure. We'll see if it repeats...

We shouldn't have to explicitly install BLAS or MKL.... there's now BLAS-based SciPy builds for Windows too

Looks like it doesn't matter. I was trying to speed it up, but the build still appears to be 20% slower or so compared to defaults-channel items.
I could add the defaults channel and move it up the priority list but combining the two seems like asking for trouble

I could add the defaults channel and move it up the priority list but combining the two seems like asking for trouble

Yes, that's always messy

Okay I was wrong -- the pytest step is 50% slower actually. It takes ~45 minutes on this PR, and ~30 on master. For an example, the slowest test on master is:
17.10s call     mne/channels/tests/test_interpolation.py::test_interpolation_eeg[None-3e-06-True-ctol0-0.0]

And on this PR it's on a test that does not even show up in the master slowest-20 list (meaning it's < 10 seconds):
93.65s call     mne/tests/test_cov.py::test_cov_estimation_on_raw[shrunk]

This seems like an unacceptable speed loss. And without the NUM_THREADS tweaks in here, it's even worse:
114.19s call     mne/tests/test_cov.py::test_cov_estimation_on_raw[shrunk]

So that's not the problem. And timing was similar when I forced MKL:
94.07s call     mne/tests/test_cov.py::test_cov_estimation_on_raw[shrunk]

Until we sort out what's causing this speed loss, I don't think this is an acceptable performance price to pay for switching.

Okay this one actually seems to be fixed. Unsetting the MKL_NUM_THREADS limit seems to really help the conda time, and it's no longer that much slower than master even without it (~52 min on master and ~60 min last I looked).
In theory after our recent CI tweaks this should come back happy. @cbrnr @hoechenberger are you happy with the conda-forge environment.yml?
@agramfort @drammock do you agree we should make this move? It does simplify our environment.yml, and it moves us past the PyQt5 5.9 (!) that is on defaults currently without needing to resort to pip to do it afterward (which has always been an iffy, ugly workaround).

I guess someone should go through the install docs and make sure the new environment.yaml file doesn't require changing the instructions anywhere.  I can do that tomorrow in a follow-up PR, if you don't want to wait on merging this.

Awesome, let's see if @cbrnr and @hoechenberger have comments on the actual setup, then merge.
@drammock we shouldn't need to update our stable install docs to reflect any upcoming changes to environment.yml, right?

I guess someone should go through the install docs and make sure the new environment.yaml file doesn't require changing the instructions anywhere. I can do that tomorrow in a follow-up PR, if you don't want to wait on merging this.

Let's wait. But from a very brief look I think we do create the mne env separate from the base env so hopefully no issues.

Very nice! @hoechenberger for a minimal env based on conda-forge an mne-base package would be really nice. I forgot if there's already an issue/PR on that? Now that I use conda config --add channels conda-forge and conda config --set channel_priority strict I can finally get rid of the default channel completely and have conda-forge-only envs (everyone else probably already knew this)!

Very nice! @hoechenberger for a minimal env based on conda-forge an mne-base package would be really nice. I forgot if there's already an issue/PR on that? Now that I use conda config --add channels conda-forge and conda config --set channel_priority strict I can finally get rid of the default channel completely and have conda-forge-only envs (everyone else probably already knew this)!

So I personally started using Miniforge, which comes with all of this preset, and already your base env is composed of conda-forge packages: https://github.com/conda-forge/miniforge
The men-base package is not ready yet, I will pick up looking into this again soon, though.
If we're lifting the PyQt limitation now, we can also include Spyder in the environment again, and ask users to run Spyder from the MNE environment.
In other news, I've discovered that Anaconda Navigator allows to create environments from an environments file entirely through the GUI; there's no need to go to the command line. So what I imagine is that we should add Spyder to the MNE environment and adjust our installation instructions for Windows and Mac such that:

users need to download the environment file
fire up Anaconda Navigator and use the "Import" functionality to create the MNE environment
navigate to the Anaconda Navigator home/welcome screen
select the MNE environment
click on Spyder
profit!

While we're talking about environments:
I gave a workshop on Monday and Tuesday and it was totally obvious to me that when teaching MNE for data processing, I also needed to give a brief introduction to BIDS; so we used MNE-BIDSas well. I would therefore suggest to include MNE-BIDS and its (few) dependencies in our user-centric environment, too.

I would therefore suggest to include MNE-BIDS and its (few) dependencies in our user-centric environment, too.

We could even include MNELAB!

So I personally started using Miniforge, which comes with all of this preset, and already your base env is composed of conda-forge packages: https://github.com/conda-forge/miniforge

I use Miniconda and if you set the two lines in your config and do conda install python==3.9, all packages in base will be switched to conda-forge!

The mne-base package is not ready yet, I will pick up looking into this again soon, though.

Thanks, let me know if I can help!

In other news, I've discovered that Anaconda Navigator allows to create environments from an environments file entirely through the GUI; there's no need to go to the command line. [...]

Note that Spyder now provides standalone installers for Windows and macOS. I'd prefer these separate installs, but of course this means that you have to point Spyder to the desired conda env.

I gave a workshop on Monday and Tuesday and it was totally obvious to me that when teaching MNE for data processing, I also needed to give a brief introduction to BIDS; so we used MNE-BIDSas well. I would therefore suggest to include MNE-BIDS and its (few) dependencies in our user-centric environment, too.

I didn't have time to participate - do you have a link to a recording?
I'm fine with including MNELAB as an optional package in our env file - actually, this is a great idea to let users know that there is a GUI available.

Okay let's get this in, then @hoechenberger @cbrnr feel free to open separate issues about whether we should add spyder back, etc. For Spyder in particular you could even just open a PR with it added to the env file to see if it just works, and we'll see if it causes some packages to get held back or not.

Sounds good to me. Thanks for your effort here, @larsoner


Adding WeAreDevelopers landing page

Issue being addressed:
We are going to pass out cards with a QR Code that directs people to this dedicated splash/landing page for the WeAreDevelopers conference. That has CTAs for:

GitHub
Docs
Discord

URL
https://deploy-preview-605--tbd-website-developer.netlify.app/wad23/

looking good @EbonyLouis! We should add the workshop location (Workshops M5), and maybe tell them they can stop by the booth any time (in addition to the Happy Hour)


Unable to download the pretrained models and datasets

Hi，great work！！！
The link for the pretrained models and the datasets seems broken. Could you please check them?
Thanks in advance.

Which were failing? I downloaded the rubble dataset and model with no problem earlier today.


Lit-GPT model integration

Hello HELM team, would you be interested in accepting a PR to integrate Lightning AI's Lit-GPT? If yes, I would love to contribute here.

Hi @aniketmaurya, this is something that we'd definitely like to have. HELM is also supporting the NeurIPS efficiency challenge, so it would be nice if users could run HELM on the Lit-GPT checkpoints directly.
Here's some related documentation:

development setup
adding new models

Would you like to take a shot at an initial PR? Otherwise I can take a look sometime next week and draft a PR.
Also, if this would be faster with sync communication, feel free to email me and set up a time for a video call. I can be reached at my email address in the git commit log.
One blocker is the Lit-GPT has a lot of configuration parameters; I'm currently working on configuration files for models over the next couple of weeks, which would solve this, but in the meantime, we might have to read configuration from environment variables or something.

hi @yifanmai, thank you for your reply! I have a initial PR here.
Yeah, I realized that for configuration I need to depend on environment variable. Would be supercool to have a configuration file. I will drop you an email to setup a time for call.

I think we should migrate to use the new LitGPT API. We could also consider using supporting LitServe.


breaking(integration_test_charm.yaml): Remove jhack tail logs

Fixes #223

Does it mean: impossible to speedup jhack tail?
It was really useful to see it events... a lot of new questions appear, e.g.:

Why juju stop sending update-status to mysql/1 and mysql/2 here
Why no events from 02:29:18 to 03:43:09
and more...

Proposal: do we see the log file size? Can we skip jhack tail run for huge logs only (or limit it to last 10000 lines of the log, etc)?

I take it the --output flag didn't work?

mm, too bad. Tomorrow I have some time to look at an optimization for --output mode


Tmux remote behavior

Currently, there is only a single global configuration for the session auto-started by the tmux module. This means, that whether 'name' is set or not, if I run a command on my machine locally, then ssh into it, the session with that running command is displayed. This is very frustrating behavior and having an option to have separate default sessions for local and ssh would maintain the convenient aspects of being able to attach to the previous sessions, or start a new one. Then, if I ssh in and a local command was running, (I have to do this, to keep my server running properly don't ask its a mess, and due to the network which I don't control)  it will not pop up in my face, but if I run one in an ssh session, disconnect, and then ssh in again, the prior ssh session would display.
This seems like far more convenient and intuitive behavior.

Edit: Implemented it myself, made a PR #1962


Actual Behaviour
Calling either of them freezes the video.
Functions affected
RtcEngine.disableVideo()
OS - Android
Device used - Redmi Note 4

Okay, I can only reproduce the disableVideo's affected in your scenario.
the muteLocalVideoStream only controls sending the local video stream, u can find more details here

@Matrixbirds Thanks for that, I have updated the description.

Finally, I have do some research. This is a design problem, Agora RTC SDK will keep the last video frame. My advice is to unmount this component in react layer, you need define a bool showVideo state and then render the AgoraView component when the state is true.

I have already update the simpleDemo, it is an example use the correct way to handle this case. If you still have any question here open the issue again.


Ion-icon with slot attribute wrong color in ion-item with color attribute on android

Bug Report
Slotted ion-icon does not apply the contrast color of the color variable that is set on ion-item on Android.
Ionic version:

[x] 4.x
Current behavior:
If I set the color attribute on an ion-item, the ion-icon with slot="start" does not apply the contrast color of my set color on Android.
Expected behavior:
Contrast color of my color variable is set to slotted ion-icon on Android the same it is on iOS.
Steps to reproduce:
<ion-item color="primary" lines="none">
   <ion-icon src="assets/icon/icon.svg" slot="start"></ion-icon>
   <ion-label>Label</ion-label>
</ion-item>

Related code:
Following CSS is probably interfering.
::slotted(ion-icon) {
    color: rgba(var(--ion-text-color-rgb,0,0,0),.54);
    font-size: 24px;
}

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.10.3 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.1
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.4.0

System:

   NodeJS : v10.14.1 (/usr/local/bin/node)
   npm    : 6.7.0
   OS     : macOS Mojave

Hi there,
Thanks for the issue! This has been merged (via #17585) and will be in the next release of Ionic.


remove toolbox turret from core

About the PR

Core had a syndicate turret toolbox mapped by accident, replaced it with a regular electrical toolbox.
Why / Balance

An oopsie
Technical details

N/A
Media

Turret in question.

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl

if they're working on an update I'll just close this

Thank you. There really needs to be some way to communicate that there should be no PRs for core right now, but I’m not sure what should be done.

Thank you. There really needs to be some way to communicate that there should be no PRs for core right now, but I’m not sure what should be done.

you should finally end your work with core and make the pr :trollface:

you should finally end your work with core and make the pr :trollface:

It would be easier if i didn’t have tests after tests with cramming every night. Anyway, expect the PR on the weekends.


Placeholder image as poster for video?

Hi there!
Thanks a lot for the plugin!
I just tried to give my <video></video> element a poster attribute and tried to place a blurry placeholder into this. This does not work, the poster attribute gets added, but stays empty. Is this a general limitation of the poster attribute or is this a limitation of the plugin?
Thanks!

Turns out it's rather a limitation of my intelligence ...
I did not realize I was trying to pull the placeholderUri from a thumbnail url instead of a file. 🤦
Now it works beautifully. Sorry for the fuss. 😅


Teardown sandbox network after stop.

Fixes https://github.com/containerd/containerd/issues/2546.
I thought about this a bit.
I don't think reversing the order will cause any problem. Previously, I was worried that we remove the sandbox when the sandbox container is not running but network is not tore-down yet. So we teardown the network first then stop the sandbox container.
However, now we also checks network namespace before sandbox removal, it should be fine to reverse the order https://github.com/containerd/cri/blob/master/pkg/server/sandbox_remove.go#L57
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM (not a maintainer)

What's current status?

What's current status?
Since this changes the timing .. I felt there was a risk if we didn't add a state flag for sandbox stop to halt new container creates, "TODO(random-liu): Introduce a state in sandbox to avoid future container creation."

After this:
https://github.com/containerd/cri/blob/master/pkg/server/container_create.go#L80
We'd check if sandbox.stopping... and return vs the possible error condition of creating a container after we've stopped all the containers in the sandbox.

Actually the risk is pretty low, because kubelet never does it. Kubelet
always stop all containers before tear down the sandbox. And it would never
create new containers at the same time.
On Thu, Dec 27, 2018 at 9:55 AM Mike Brown<EMAIL_ADDRESS>wrote:

What's current status?
Since this changes the timing .. I felt there was a risk if we didn't add
a state flag for sandbox stop to halt new container creates,
"TODO(random-liu): Introduce a state in sandbox to avoid future container
creation."
After this:
https://github.com/containerd/cri/blob/master/pkg/server/container_create.go#L80
We'd check if sandbox.stopping... and return vs the possible error
condition of creating a container after we've stopped all the containers in
the sandbox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/containerd/cri/pull/1000#issuecomment-450200477, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFjVu34P3LOKO6C5V9u42GJti759ysAxks5u9QmQgaJpZM4ZUcr9
.

My concern is for manual operation, which is relatively low priority.
On Thu, Dec 27, 2018 at 10:30 AM 刘澜涛<EMAIL_ADDRESS>wrote:

Actually the risk is pretty low, because kubelet never does it. Kubelet
always stop all containers before tear down the sandbox. And it would never
create new containers at the same time.
On Thu, Dec 27, 2018 at 9:55 AM Mike Brown<EMAIL_ADDRESS>wrote:

What's current status?
Since this changes the timing .. I felt there was a risk if we didn't add
a state flag for sandbox stop to halt new container creates,
"TODO(random-liu): Introduce a state in sandbox to avoid future container
creation."
After this:
https://github.com/containerd/cri/blob/master/pkg/server/container_create.go#L80
We'd check if sandbox.stopping... and return vs the possible error
condition of creating a container after we've stopped all the containers in
the sandbox.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/containerd/cri/pull/1000#issuecomment-450200477, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFjVu34P3LOKO6C5V9u42GJti759ysAxks5u9QmQgaJpZM4ZUcr9
.


Address a bad interaction between rustfmt and codegeneration.

With the addition of services codegeneration, we end up creating new files that are not formatted in the sense of rustfmt.
As a result, every new run of make fmt results in a diff. Currently, the problem is solved by commit the formatted version of the code.
This is still not great, because now every call to cargo build shows a diff until we run make fmt.
Finally, the current code does not make it clear enough what is generated and what is not. The last thing we want is for people to start editing/committing modified generated code.
This PR introduces the following solution:

generated code stays in src/. Putting it in target is a common way to fix these problem but it tends to confuse source code editor GoToDefinition. If generated code is not something we want to write, we often want to read it.

generated code goes into a codegen subdirectories. That subdirectory is not covered by rustfmt anymore. We commit non formatted version of the file (it does not hurt readability).

Thanks for looking into this. Codegen tries to format the code using prettyplease, but the output still differs from what you would obtain with rustfmt.

This is still not great, because now every call to cargo build shows a diff until we run make fmt.

This is not exactly accurate. After checking out a branch, the first call to cargo build usually re-runs the codegen build script and emits code formatted differently. Still, the subsequent calls won't unless proto files have been updated, the build script has been modified, or the codegen logic has changed. Reasons for Cargo to re-run the build scripts include upgrading dependencies or updating the Cargo.lock file. There are probably others.
Anyway, your fix applies regardless and it's nice to put the generated files in a codegen directory.


[19.07] luci-app-simple-adblock: needs curl as dep

Curl is needed to download any of the blocklists.

@stangri

Curl is one of the options, it's not a dependency and definitely not for the Luci app.

Hmm okay.  When I install after a fresh install the blacklist urls can’t download because there is no curl.  I see you have a PR to maybe correct a bug as well.  The service is broken or if the box.  One of the urls is using is bad.  But am assuming that this the LuCi side of things.


Android cannot find resource

Describe the bug
In an Ionic Angular project, the following method call in NativeAudio.java always returns 0.
      int identifier = ctx         .getResources()         .getIdentifier(assetPath, "raw", this.getContext().getPackageName());
To Reproduce
Steps to reproduce the behavior:

Create a new Ionic 5 Angular app
Create a directory assets/audio and put an mp3 file in it
Install this plugin + cap sync
Try to load the file with NativeAudio.simpleLoad()

Expected behavior
The audio plays
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I have tried this with every combination of directory paths I can think of. public/assets/audio, app/src/main/assets/public/assets/audio, just audio/, with and without filetype suffix, etc. No matter what I put there, it can't find the resource and returns 0.
I have even confirmed that this statement returns my "errorbeep.mp3"
ctx.getResources().getAssets().list("public/assets/audio");
But even still, it always results in this error
Sending plugin error: {"save":false,"callbackId":"24202082","pluginId":"NativeAudio","methodName":"preloadSimple","success":false,"error":{"message":"Resource ID #0x0"}}

At the end of my tether with this issue. Tried everything just as @mikelhamer  did. Anyone who can help ?

I managed to get it working (on iOS anyway, untested in Android) using a fork of this plugin
This plugin:
https://github.com/bazuka5801/native-audio
I had similar issues, which I was helped with here:
https://github.com/capacitor-community/native-audio/issues/25
In short, use the complex method for loading, and the files on iOS are in public/assets and on Android in res/assets

Here is how i got it to work (trial and error)

Use resource names instead of file names on Android (Use "errorBeep" instead of "errorBeep.mp3" as the audio assetPath

NativeAudio.preloadSimple("errorBeep", "error")

Make sure errorBeep.mp3 is present in android/app/src/main/res/raw
@mikelhamer  FYI

@mikelhamer Hi)
I fixed this issue and provide some example in readme, not plugin support only capacitor v3.


Add support for selecting a style, to provide new GitLab Scoped labels

I've added support for passing in a --style flag, which allows a different predefined style to be selected. If the style requested doesn't exist, we fall back to the current default one.
I thought this was a good approach to begin supporting the different formats vendors use. I've added the gitlab-scoped format in this PR as it has a label and value format, though I'd like to add support for other styles later.
I updated the README.md with examples and instructions. I've also updated the help(anybadge) output section to reflect the current output.
How does this sound @jongracecox? Are you happy with this? Anything you like changed?

Sorted the failing test. I hadn't realised the comments on the properties were used in the tests. Neat!

Thanks so much for taking the time to do this - I think it's a great addition to the package. This has given me some ideas for future updates. I like the idea of moving styles into package resource files to make them easier to manage. I also like the idea of setting defaults within the style templates (e.g. font), which would mean that each style could have its own default font.
I'm going to merge this and create a release candidate that you can use, but I might make a few minor tweaks before cutting a full release.

This change has been released as part of v1.9.0rc1. I'll try and get to the final release in the next couple of days, but in the mean time you should be able to pip install using the rc version.


Please provide some ways to bulk filter or delete instances in "HOSTS" and "CONTAINERS" page.

We use one of our linux machine to build our own docker images, during this process, it create so many stopped instances...

Please provide some ways to bulk filter or delete instances in "HOSTS" and "CONTAINERS" page.
We love rancher, keep up the good works!

+1 this feature would be so helpful.

Dupe of #342.  Some of the work needed for this was done with making all the table views sortable, just need to finish it.


[nereids] fix join fd computing bug

Proposed changes
[nereids] fix join fd computing typo bug
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


Add support for testing our Talon api; test "phones" and "format"

Fixes #1721

Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

2023-08-06 17:55:59.688 WARNING actions: skipped because they have no matching declaration: (user.cursorless_wrap, user.cursorless_reformat)
TalonRepl.ts:79
2023-08-06 17:55:59.708 WARNING actions: skipped because they have no matching declaration: (user.cursorless_wrap, user.cursorless_reformat)
TalonRepl.ts:79
2023-08-06 17:55:59.713 WARNING actions: skipped because they have no matching declaration: (user.cursorless_wrap, user.cursorless_reformat)
TalonRepl.ts:79

hmm. haven't seen that.  are you sure you're using version of cursorless-talon / cursorless-talon-dev from this branch and restarted talon?

Ah was my fallback code


Time-slider breaks if collection name contains colon character :

As the title says, the time-slider is not able coop with collection name containing one or more colon characters :.
If, in the client, a layer with the above described document is selected, the time slider crashes (reported by the browser console) and either it does not pop-up (if it is supposed to be displayed) or does not show any tick for the selected layer (if already displayed).
This pose a serious issue is it prevents use of URNs as collection identifies.

Solved in #18 (id not longer used in element)


ci(appveyor): create AppVeyor configuration

Platforms affected
Motivation and Context

Description

Testing

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   39.34%   39.34%
=======================================
  Files           5        5
  Lines         427      427
=======================================
  Hits          168      168
  Misses        259      259

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30afa29...fd7db95. Read the comment docs.


chore(scripts): Consistenly use the *.yaml file extension for Helm charts

@mnonnenmacher, does something need to be adjusted in your side due to this renaming?

@mnonnenmacher, does something need to be adjusted in your side due to this renaming?

No, the Helm chart was only used for local testing with Minikube but has unfortunately not been maintained for a while, so I doubt that it still works correctly.

No, the Helm chart was only used for local testing with Minikube

Ok, so then the good news is that the PR could be merged without breaking anything, right? Because it will still simplify dealing with YAML file pattern as part of .reuse/dep5.


Add doc on requirements for inputs

Seed: 3D nifti file or corrdinate in common space of the dataset
First level input example:
{
  "sub-001": ["Path/to/func.nii,gz", "path/to/confounds.nii.gz"],
  "sub-002": ["Path/to/func.nii,gz", "path/to/confounds.nii.gz"],
}

Design files:

TSV files
No index
Group level:

First column should be subject_label with subject id consistent with first level input json
Contrast file should contain the same headers as design
Separate file for confounds and design

Revised the first level input to a json file:
{
    "sub-001":{
        "func": "path/test.nii.gz",
        "confounds": "path/test.tsv"
    }
}


Default tab or route

I've read this paragraph a few times - looked through the sample code but can not understand what this is telling me to do.....

UI Bootstrap Tabs will not select a tab by default. If you want it to, specify the target sub-route when you show the tabs (ie. link the ui-view containing the tabs with the default (first) element as the sub-route example/#/user/settings in the example.)

Would it be possible to provide a small sample code?

+1

I can add something in, but i'm not sure how else to explain it :)
If you have tab routes of /user/settings/1 and /user/settings/2 if you have a link in another view pointing to
.../1 or .../2 it will load the tab view with the right sub-view and the tab highlighted.  So just put the link for the default route you want to use into the place that navigates to it (either $state.go or ui-sref etc).

Closing due to inactivity.

Just thought I'd try to provide some clarity here as I've been puzzling over it for some time - really just rewording your statement - now that it's working I can see how your statement makes sense, but hindsight is only so useful before you have it. .
I've just been retrofitting ui-router-tabs into an existing app with manually constructed tabs.
I have an app that has a state & view with user functionality (let's call it user), and a state & view with administration functionality - the administration view previously had manually constructed tabs in it, the first one being User Management. In my app, a user would click on an "Administration" menu item, which would navigate to the administration state, loading all of the manual tabs, and setting User Management to visible (all manually - no states involved yet). When I retrofitted ui-router-tabs into this, creating subroutes/states for all of my child tabs, I had the same problem - no default tab.
To solve this, I needed to modify my "Administration" menu item so that instead of navigating to the administration state, it navigated to the administration.userManagement state. This then loaded the administration view with the tabs, and also loaded the first tab.


Add gpt-4-vision model for requests with image recognition

Right now this feature works only for admin (alpha phase)

Later:

add this feature for every user with positive premium tokens balance


Prep for Enterprise v3.7.1

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[x] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.


Update Azure specifics

Signed-off-by: Andy Goldstein<EMAIL_ADDRESS>

cc @paulbouwer - this incorporates most of your docs for installing on Azure.

cc @jimzim @rasquill @squillace - would appreciate any feedback asap if you have time!

@ncdc @skriss @nrb - I added a few minor comments, but otherwise LGTM.
I built the updated guidance from a few passes at installing Ark on Azure, so the commands have been tested and should all just workTM.

@paulbouwer thanks! I've made the updates you suggested.

LGTM, merging.


[webpack] add a 'npm run dev-fast' command that is much faster

The tradeoff is that the sourcemap isn't as reliable, but good enough in most cases. I'm using this faster mode now and I'm thinking that if I need to do deeper debugging I'll fire up the old npm run dev
@graceguo-supercat you should try it out, it's so much faster!

Coverage remained the same at 69.39% when pulling a5369f8d3ad628a13194bd87a589a49fc75bd517 on mistercrunch:dev_fast into 46d60880ebb0c717e16cd81aef7a9ad15a6d966c on apache:master.

LGTM!


Rearrange Substituter and Expander

Currently:

Substituter literally just replaces RefTerm (🤯)
Expander applies beta reduction and delta reduction

Wanted:

Substituter replaces terms and applies beta reduction
Expander applies delta reduction

This seems faulty after some investigations (mostly done by @tsao-chi and @wsx-ucb). However, it is still desirable to have some beta-reduction logic after substitution, bc we are likely to need them. This change is added in an ugly way in #456 and #455 (both merged), and I wish someone can improve the code.

To solve this in the short term, I'll push a version that simply adds another visitor from scratch doing purely beta-reductions.
Admittedly, this introduces code duplication, namely the same beta-reduction logic in Normalizer, WHNFer, and this new visitor.
To address that, I'm thinking of adding a new helper interface (just like Expander) that will encapsulate recursive beta-reduction. (But I haven't come up with a good design yet.)
The intention here is to separate beta- and delta-reduction into separate pieces, and we can later mix and match them to form different reduction strategies.

I think you have to mix them. You're doing beta and eta at the same time.
What about just a pattern matching function?

I think you have to mix them. You're doing beta and eta at the same time.
What about just a pattern matching function?


Split TypeScript from Vue SFCs

TypeScript files should be splitted from the Vue SFCs.

It improves GitHub's ability to see how much TypeScript is used.
It allows to run external code inspection tools on the resulting .ts files.

Done. Although I already moved my own code to TypeScript, the default VuePress theme files included a lot of JavaScript. And as it's easier now to filter out .js files, the next step is to transform those files into TypeScript as well. Separate issue will be opened for that.

Just tested everything, build inside Docker is successful, website still works.

develop can be merged into main


update to panel==1.4.4

I could not find any visible side-by-side differences between panel 1.4.2 and 1.4.4. The file selector popup feels noticeably faster in 1.4.4 though! I did find a couple quirky UI issues that are ragna problems, not panel problems, and I will open separate issues for these.
Closes https://github.com/Quansight/ragna/issues/451

@pmeier Am I supposed to update requirements-docker.toml manually or let CI do it? I tried both ways and it's angry either way.

Hi @blakerosenthal, apparantly if you run locally -
pip-compile --quiet --strip-extras --output-file=requirements-docker.lock --extra=all pyproject.toml

It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally.
Until now docker-requirements / update (pull_request) job is just testing if current requirements-docker.lock matches the output of the above command and instead of updating it automatically for you it fails.
I did some workaround for that in arjxn-py/ragna#3 (See b60ca7a is auto-generated), please have a look. I'd be happy to open a PR to update update-docker-requirements.yml upstream too.

Hi @blakerosenthal, apparantly if you run locally -
pip-compile --quiet --strip-extras --output-file=requirements-docker.lock --extra=all pyproject.toml

It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally.
Until now docker-requirements / update (pull_request) job is just testing if current requirements-docker.lock matches the output of the above command and instead of updating it automatically for you it fails. Because the workflow is supposed to open a separate PR & only if it's manually triggered.
I did some workaround for that in arjxn-py/ragna#3 (See b60ca7a is auto-generated), please have a look.

It should do it, but I wouldn't recommend that because of the difference in environments on CI & locally.

No, this is a valid way to do it. The only thing that one needs consider is that our default dev env runs on
https://github.com/Quansight/ragna/blob/55f7fc5d3d13f321eebd16d3b0901ab35ac36bc7/environment-dev.yml#L4-L5
while the docker images uses
https://github.com/Quansight/ragna/blob/55f7fc5d3d13f321eebd16d3b0901ab35ac36bc7/Dockerfile#L1
Thus, the command should be run from Python 3.11.

Until now docker-requirements / update (pull_request) job is just testing if current requirements-docker.lock matches the output of the above command and instead of updating it automatically for you it fails. Because the workflow is supposed to open a separate PR & only if it's manually triggered.

Yeah, I imagined the workflow to just merge a PR like this as is and let the bot send a follow-up PR. This what I propose we do here to avoid blocking the PR.
@arjxn-py I saw refactored it so that the bot automatically pushes a commit to PR branch. I dislike this workflow, because it can mess up the branch I have locally. I don't think it is too bad here given that this file shouldn't be touched manually anyway, but I still have my concerns. If you want to have a different workflow, feel free to open a discussion issue. Maybe we can just go for a middle ground and let the bot run on every push to main and automatically send a PR if necessary rather than us starting the workflow manually?


Webpack support

When I use this plugin with Webpack .. i got several errors ... because I use momentJS ..  and I got several errors in locale folder ...

Same over here, im trying to do # tns run android --bundle and something in the moment implementation bows out
"nativescript-toolbox": "^3.0.1",

Hi
It seems moment.js is actually missing. You can add it for now in the sub-folder moment/. Just add the moment.js file as it is of course required.
Best

Same problem here.
@nea   Where did you find moment.js file?

Hi @bearoutthere
moment.js I downloaded from the official repo and added it to the node_module where it was missing.
Best

Thanks @nea.
I got to the same point as well but then compared index.js in the plugin with the moment repo and they looked very similar.  So i tried copying nativescript-toolbox/moment/index.js to nativescript-toolbox/moment/moment.js  and it seems to work.


Fix/template load working directory

:tada: This PR is included in version 0.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Introduce team deactivation

Until we have figured out how to properly delete teams (along with potential 3rd party data, like for instance GitHub teams and GCP projects) we want to introduce a flag for team deactivation. The frontend can use this information to visualise deactivated teams.

Fixed in 200079584edf889e4d6b73f9b4479d5341f8ad63


Remake/Redesign/Simplify the Gui

Remake/redesign the Application so it is more simple to use.

The GUI Remake is currently in progress

Released in #27 (Design Overhaul).
To get the latest version, please go to Downloads (#28).


Improve first-time developer UX

Print bound port to stdout
Explain how to run code without installing it

Thanks for the feedback @rnestler, I'll merge this. (If someone with more go experience has more feedback, that would be welcome of course.)


Connecting to OPC server with username/password

Hi,
many thanks for this library, it seems to be exactly what I need to develop simple client for data exchange with PLC running OPC server. A simple dll with all the required functionality. When using anonymous server access, everything works as expected (apart some TODO exceptions here and there, which I don't need anyway). However I have one problem regarding session with UserTokenType.UserName - is this implemented?
The user with password is defined on OPC server, there is an endpoint without security (MessageSecurity.None, SecurityPolicy.None) and UserTokenPolicy "Username". Every function in connection sequence return StatusCode Good including ActivateSession:
client.Connect();
client.OpenSecureChannel(MessageSecurityMode.None, SecurityPolicy.None, srv_cert);
var appDesc = new ApplicationDescription("urn:qs:TestClient", "uri:qs:TestClient",
new LocalizedText("OPC Test Client"), ApplicationType.Client, null, null, null);
client.CreateSession(appDesc, "urn:qs:TestClient", 120);
string username = textBoxUser.Text;
byte[] password = (new System.Text.UTF8Encoding()).GetBytes(textBoxPass.Text);
object usr_identity = new UserIdentityUsernameToken(srv_policy, username, password, Types.SignatureAlgorithmRsa15);
client.ActivateSession(usr_identity, new[] { "en" });
Variables srv_cert (correct array of bytes) and srv_policy ("1" matching the UserTokenPolicy "Username") are loaded before the Connect function from server using your example client code. Weird thing is the ActivateSession returns Good even when the username/password is wrong or missing. I looked into the source code of ActivateSession and found no handler for StatusCode.BadUserAccessDenied. Any attempt to browse nodes using function Browse in this "Good" session ends with exception about array dimensions. The Browse function tries to create an array with impossible length in numRefDesc right after the server response:
refDescs = new ReferenceDescription[numRefDesc];
I then tried to connect to the server with free Prosys OPC UA client application and for username/password access it worked as expected - wrong user was rejected, correct one was allowed. But I don't have sources for the client to look at obviously.
One more thing - I also tried latest official OPC UA stack from OPCFoundation here on GitHub, compiled the client example and upon connection with the same access as in the Prosys client and my client it ended with 5 exception about security, so it cannot connect to the server with those official libraries too, so I am at lost here as in the Prosys client it somehow worked...

Hello,
Yes, UserIdentityUsernameToken is correctly implemented according to the official OPC UA specification.
ActivateSession will return with any bad status code, such as BadUserAccessDenied. If the official OPC UA client cannot connect to the same server, then I think your UA server does not exactly follow the binary serialization specification. In this case, numRefDesc in Browse might also not work because the data structure deserialized does not match the specification. AFAIK, I've tested with 20+ commercial UA servers from different vendors, and Browse/BrowseNext functionality has always worked.
Not all OPC UA providers follow the specification. For more information, you might try using the OpcUa plugin for Wireshark to sniff and disassemble traffic between the Prosys OPC UA client and server, and look at the message structure. If you attach that information here, I could also take a look. I suspect one or more structures in the protocol are different from the official specification.


Increased tumor incidence terms

1.  What's the difference between our terms hepatoma and increased susceptibility to hepatoma?  These terms seem to reflect the same thing (i.e. an increased incidence of hepatoma).
2.  We have many specific tumor types that are not listed as children of more general tumor types:
-adrenal gland adenoma [MP:0009044] is not a child of adrenal tumor
-skin hamartoma [MP:0009469]  is not a child of skin tumor
-hepatic hemangioma [MP:0002047] is not a child of liver tumor while retinal hemangioma is a child of retinal tumor
-medulloblastoma [MP:0006283] is not a child of brain tumor
3.  We have specific organ tumors without parents for the general tumor type:
-no renal tumor even though we have several types or renal tumors
4.  Some tumor types we do not list:
-mesothelioma (3 associated alleles I will be adding 10 more using various combinations of 3 alleles not already associated with this tumor type)
-schwannoma (2 plus 5 more genotypes entered earlier today and more to come)
-meningioma (4 plus)
-osteomas (10 plus)
-lymphosarcoma (4 plus)
-neurofibroma (18 plus)
-cholangiocarcinoma (2 plus)
-odontosarcoma (just added alleles with this term in the genotype)
-odontoma (just added alleles with this term in the genotype)
This terms might not all be needed but are suggestions.
Michelle
Reported by: michknow
Original Ticket: obo/mammalian-phenotype-requests/363

Section was previously reorganized.


Ingress controller is not updating loadbalancer entries in Ingresses (nginx-ingress-controller:0.9.0-beta.3)

Setup:
A: Ingress controller, ingress-class: internal
B: Ingress controller, ingress-class: external
C: Ingress for a service, initially using internal ingress
Observed:
When updating C to have the ingress class 'external', it is not updated.
When adding another ingress (D) to use either 'internal' or 'external' ingress-class, nothing is done - the loadbalancer is left blank.
When the ingress controller pod that matches the ingress-class on C or D is deleted (and replaced by kubernetes), the entries update.
Expected:
When updating C to use 'internal', we should see the loadbalancer for this appear on the Ingress.
When adding a new Ingress that uses the class, it should get the appropriate loadbalancer assigned.
Versions
gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.3
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.4", GitCommit:"7243c69eb523aa4377bce883e7c0dd76b84709a1", GitTreeState:"clean", BuildDate:"2017-03-07T23:34:32Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}

My experience is that 2 ingress controllers still don't work in beta.3.

@egeland please check if the image quay.io/aledbf/nginx-ingress-controller:0.89 solves the issue

Confirming that the issue has been fixed on master. We ended up compiling our own version as we needed some of the changes from 0.9.0-beta.2.


Add PivotalTracker CSV Import option

FWIW - I have not gotten this to work yet because of issues with the CLI that are unrelated to this PR.

@trevorrjohn want to give me a shout on Slack once you verified it works and I'll give it a look. Thanks for putting up the work!


Cannot search for packages

When attempting to search for any package, I receive the following error:
Searching packages failed: Application error
Nothing is logged to the console. I have tried completely wiping out all config files and cached files to no avail.
Mac OS X 10.9
Atom v0.104.0

This seems to be back @izuzak

This seems to be back @izuzak

Yeah, I'm noticing it too.  /cc @thedaniel
I'm not sure but I think that might be related to network connectivity problems between Heroku and GitHub which have been going on today (I've noticed network connectivity problems affecting GitHub users as well).

I'm also getting this problem at the moment.

To to everyone, if this happens, it is likely that atom.io is having issues.

The search cluster briefly went down overnight, causing some search errors. Things seem to be fine now.

Looks like this is happening again.

Yeah, https://atom.io/packages/search?q=haml it is down.

Can't install any package in atom GUI or apm.  :confused:
Clean Windows 7 x64 installation.

same thing happening here. the site is down :(

The Atom team is aware that https://atom.io is having some problems.  Hopefully it'll fix itself in a few hours, but in the meantime, please be patient - commenting on already-solved issues won't help at this point.  Thanks!


Update Ramanathan's section in AboutUs.md

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (37c0923) compared to base (d275b50).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Methods in YODA Files

Which methods belong in the simplified timeseries YODA template?  Right now I'm automatically generating actions as "Observations" at each sampling feature (so no "Instrument Deployments" or anything else).  So all methods would have to be "Observation" methods.  Does it make sense to do it this way, even though we know this template will be used primarily for sensor data from in-situ instruments?
Also, WRT methods, how do we deal with the method used by a sensor/piece of equipment vs. the action method?  The result producing action for a sensor would be an "Instrument Deployment" type but the sensor itself should be operating using an "Observation" type method or maybe some other new method type.  To me an "Instrument Deployment" method in the actions table should be something like "mounted to rebar in thalweg of stream" while any details of how that sensor is actually taking measurements (ie, water depth via capacitance) belongs in the instrument output variables table.  So, for someone with the equipment extension it can be sorted out.  But without the equipment extension, what is best?

My iUTAH time series examples use a MethodType of "Instrument deployment" for the Method that is associated with an Action that is of type "Observation".  Based on our recent conversations, the MethodType and ActionType should be the same, so I will fix these in my examples. They should both be "Instrument deployment", which can produce a Result.
My full Method description is a description of the specific sensor that was used. The text description I wrote doesn't really describe the details of the deployment (e.g., mounted on a sensor cross arm that is mounted to the tower at a height of 2 m) or the specific method used by the sensor, but it could if I wanted it to.  Without the Equipment extension, the full description of the sensor, its deployment, and the "method" that the sensor uses needs to be in a single Method description.  That's up to the data manager to write.
In terms of which Methods to include in the file - the YODA file should include any Methods that are used in the file (i.e., to define the Method for Actions that are included in the file).


Document our approach to logging

How should a developer use logging? How do a user configure logging? What goes into logs, at what levels?
Related to https://github.com/weaveworks/weave-gitops/pull/2139#pullrequestreview-970972939_

@ozamosi - is this still valid? Perhaps a x-team topic?


Dual for shutters

How to make relay off after xx seconds?So it can control motors like roller shutter.
@maximkulkin Can you add a variable (xx seconds) to config setup under ssid and password.
if 0 seconds normal mode no auto-off else relay will be off after xx seconds?
I am new for opensdk.. Thanks

Please anyone confirm dual example works well?

As I said before, we try to keep examples less cluttered so people can understand what's going on. they are not meant to be one-fits-all solution.


AFD managed certificate autorotation

I believe Microsoft should highlight the fact that  AFD managed certificate autorotation will always fail for apex domains if the validation record is not regenerated between rotations.
I see this is mentioned in the doc : https://learn.microsoft.com/en-us/azure/frontdoor/apex-domain#azure-front-door-managed-tls-certificate-rotation
However, it will benefit the customers to have a NOTE section in this document as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 02772612-08a7-06a1-f0ca-d6d8c5de3ed7
Version Independent ID: 97b248ee-d8e4-901c-c399-e5b75b9f8236
Content: Onboard a root or apex domain to Azure Front Door
Content Source: articles/frontdoor/front-door-how-to-onboard-apex-domain.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

duongau, please review this request and update the docs as necessary

@KapilAnanth-MSFT , thank you for your feedback.
@duongau , for your review.

@KapilAnanth-MSFT Thanks for moving this forward. I'm also referring to this concept page. :)

Hello @KapilAnanth-MSFT,
I added to the note to the Apex domain page. Please let me know if we need to make any other changes. Thank you.
#please-close


FadeOut on DiGraph does not work smoothly

Description of bug / unexpected behavior
ManimCE v0.18.1
Using self.play(Fadeout()) on a DiGraph() object does not correctly fade out the edges, only the nodes and arrow tips. Removing the individual subobjects works.
Link to the Discord discussion
Expected behavior
All elements of a DiGraph() should fade smoothly out.
How to reproduce the issue
Code for reproducing the problem
class IntroductionToGraphs(Scene):
    def construct(self):
        vertexs = [num for num in range(1,7)]
        arestes = [(1,2), (3,1), (1,5), (1,6), (5,1), (5,6), (3,4)]
        layout = "circular"

        graf_arestes1 = Graph(vertexs, arestes, labels = True, layout = layout)
        graf_arestes2 = DiGraph(vertexs, arestes, labels = True, layout = layout)
        graf_arestes3 = graf_arestes2.copy()

        graf_arestes1.scale_to_fit_width(14/3).to_edge(LEFT, buff=0)
        graf_arestes2.scale_to_fit_width(14/3)
        graf_arestes3.scale_to_fit_width(14/3).to_edge(RIGHT, buff=0)

        self.play(
            Create(graf_arestes1),
            Create(graf_arestes2),
            Create(graf_arestes3),
        )
        self.wait()
        self.play(
            FadeOut(graf_arestes1),
            FadeOut(graf_arestes2),
            FadeOut(*[obj for obj in graf_arestes3])
        )

Additional media files
Images/GIFs
https://github.com/ManimCommunity/manim/assets/8582807/20f06405-6c81-453c-ac62-c6d32f16635c

System specifications
System Details
irrelevant - the problem occurs on both Windows 10 and Manimator

This is an issue with the edge updater in the DiGraph. I'll take a look at it.


add write back instructions

When we use @binding.Args we can get the args of the enhanced method. Now with the array args, we can modify the input parameters of the target method. As demonstrated in BytekitDemo.java.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

这个具体是什么场景下的需求？

需要对任意方法入参进行修改时，比如servlet的流量截取。将入参servletRequest和servletResponse替换为自己的代理request和代理response，以获取request的inputStream中的请求内容和response的outputStream中的返回内容。
虽然使用instrument-api的方式能做到修改入参，但又不易对任意方法进行增强。


Add difference-of-squares exercise

I'm very relieved that upgrading the 8th version in the test runner has fixed the depth check problems.


Release CI is using deprecated commands and actions

See for example the warnings under https://github.com/nautobot/nautobot/actions/runs/6855609166 (1.6.5) and https://github.com/nautobot/nautobot/actions/runs/6855644835 (2.0.4):

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-python@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Some of this was fixed in 2.0.x by #4265 and may just be backportable to ltm-1.6, however more work is needed to get both release trains building without warnings.

Hey team! Please add your planning poker estimate with Zenhub @gsnider2195 @HanlinMiao @timizuoebideri1


"Galbena" is listed in the drop-down menu

Description:
When user writes "Galbena" the location appears in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Galbena"

Expected results
The location appears in the drop-down menu as "Galbena, Alba (Arieșeni)"


Rectify typos in tutorials

The prompt_template parameter in .generate() is passed wrongly and this PR addresses the same.

CI tests failing does not relate to this PR. merged


Updates ptvsd version table.

Updates ptvsd version table.
Excludes .vs folder from git.
cc @kraigb, and @int19h to double check my version numbers

@zooba,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.gitignore
:white_check_mark:Succeeded

docs/python/debugging-cross-platform-remote.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add property blacklist

Adds a propBlackList (ref #25).
Leaves the propWhiteList behaviour intact, but the propBlackList  will override it:
// margin is ignored
{
  propWhiteList: ['margin', 'height'],
  propBlackList: ['margin']
}

// only margin is ignored
{
  propWhiteList: [],
  propBlackList: ['margin']
}

// margin is ignored (would be anyway), defaults are transformed
{
  propBlackList: ['margin']
}

// font is ignored, only other defaults are transformed
{
  propBlackList: ['font']
}

This is more powerful but I would like it to be less confusing for people. The confusion is that propWhiteList already has defaults.
How about something more like this:
{
  propList: ['font', 'margin', '!border']
}

Include font and margin but not border

I see how this is powerful but it might be a little confusing for people since propWhiteList has default properties.
How about something like this:
{
  propList: ['~font', 'line-height', 'letter-spacing']
}

This would be the same as the current defaults. ~ allows "font" to match "font-size"
{
  propList: ['~margin', '!margin-left']
}

Match all "margin" properties expect "margin-left"
{
  propList: ['*', '!~border']
}

Match everything except all "border" properties
{
  propList: []
}

Still match everything
Support propWhiteList -> propList for legacy.

Added PR #29


NMS.GEN.LANG.004 - language determination for user with unknown location

If the location information of FLW/MCTS-beneficiary is not known corresponding to the received MSISDN number, then following rules for language determination apply:

Case A: If the circle information cannot be determined, the user is prompted in the national default language by the IVR to enter their Language-location code via DTMF.
Case B: If the circle information can be determined and
Case B1: there is only one “Language-location code” possible in the circle (based on geographical coverage of the circle), then the corresponding “Language-location code” shall be used for the received MSISDN number.
Case B2: there are multiple languages possible in the circle (based on geographical coverage of the circle), the user is prompted in the circle’s default language by the IVR to enter their Language-location code via DTMF.

Case B2 covers two types of cases. One case is of north-east where there are multiple states in a circle and consequently multiple languages. Another case is that where multiple languages are used within a state. Both cases are covered in this scenario.

Right now our API rejects calls which omit the Circle.

This is dependent on #119

Does this need to be open for the issue outlined in the PR?

I opened a new ticket to track that.

ok, just wanted to make sure in case you were planning to link them :)

Good point.  Case B1 is under discussion with IMI about who should implement it.  That discussion is being tracked in #252


Added support for working with private repos

With this changes we can work with mercurial private repos.

Sorry for the very, very slow response. Would you mind rebasing from master so test coverage can be checked on all systems?

Looks useful. Can you rebase to resolve merge conflicts?

Rebased and merged in! Grats @marctc!

thanks @pydanny!!


Add ChainerX native float16

By the way, shouldn't it defined outside of native backend scope?
I think dtype.h should have access to it.

Rebase and squashed.

jenkins, test this please

Jenkins CI test (for commit db3af32c0737632d90c883fe8ac0f1170c238988, target branch master) succeeded!

jenkins, test this please

jenkins, test this please

Jenkins CI test (for commit d86c4b7cfc25e88f9a7ced1700386f790c9d6473, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

jenkins, test this please

Jenkins CI test (for commit d86c4b7cfc25e88f9a7ced1700386f790c9d6473, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

jenkins, test this please

Jenkins CI test (for commit 01abc0ee972969d9e76100f1a3f973641c051bb1, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

jenkins, test this please

Jenkins CI test (for commit c4f90355614bf2c0af3cbf42cce02b7f1b3c0f6c, target branch master) succeeded!


Support roll, pitch, thrust and yaw rate in OFFBOARD

Several offboard attitude control implementations build on a [roll, pitch, *yawrate*, thrust] framework. It does not look like PX4 supports that (apologies if I'm wrong). Setting yawrate has no effect if an attitude quaternion is provided. At present, one has to set IGNORE_ATTITUDE for rates to take effect (which would prevent roll and pitch commands). Also, ignoring the rate on one axis ignores it on all axes L1385, handle_message_set_attitude_target().
In short, if you used "setpoint_raw/attitude" plugin from Mavros to send a packet with:

attitude quaternion, thrust
yaw-rate
IGNORE_ROLL_RATE, IGNORE_PITCH_RATE

then yaw-rate is ignored as well. Tested with latest stable release on real hardware.
It would be useful to have PX4 choose yaw vs yaw-rate depending on the bit masks specified in Mavlink packets.
A solution
Check for the specific bit mask set_attitude_target.type_mask & (1 << 2) to see if yaw-rate was requested. If it is, then bypass the yaw field in the quaternion (have the attitude controller working on roll, pitch and yaw-rate). Similar to Arducopter's parsing. This might break an existing workflow that doesn't specifically ignore yaw-rate though. I'm not sure if there's a simple workaround to that.

I can control the simulated vehicle (px4 firmware) via dronekit by sending set_attitude_target message. The vehicle must in OFFBOARD mode and the msg has to be sent in a frequency faster than 2Hz.

@caomxin Not quite sure if it is "supposed to" maintain altitude when setting thrust to 0.5.  You need an outer-loop that converts errors in altitude to (scaled) thrust values.
However, this is not related to this issue/feature-request -- which itself has, curiously, gotten no other response ..

I believe this has been fixed #10892.

@julianoes Briefly went over the commit - it appears so. Thanks! :)


add some more tests to further increase coverage

Codecov Report
Patch coverage has no change and project coverage change: +0.54 :tada:

Comparison is base (2da7a7d) 88.93% compared to head (dd855c0) 89.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   88.93%   89.47%   +0.54%
==========================================
  Files          17       17
  Lines        2024     2024
  Branches      872      872
==========================================
+ Hits         1800     1811      +11
+ Misses         90       84       -6
+ Partials      134      129       -5

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Device doesn't try to reconnect more than 50 times in 10 minutes

What is the expected behavior?
Under no network, the device does not try to reconnect more than 50 times in 10 minutes when it is unable to connect to the AVS webservice.

Issue:  Whenever internet is disconnected with the device, the device should be able to re-connect to the AVS web server in the background. Then the device does not try to reconnect more than 50 times in 10 minutes
Can someone please share the exact procedure to reproduce this issue.

Hi @dipalisb, please follow our issue reporting guide when creating a new issue.

Hi @dipalisb, please follow our issue reporting guide when creating a new issue.

Also, please fill out the following information. You can copy and paste this into your original comment and then fill it out as appropriate. This will help us get started in debugging your issue.
Briefly summarize your issue:

Device doesn't try to reconnect more than 50 times in 10 minutes

What is the expected behavior?

Expected behavior must be: Device doesn't try to reconnect more than 50 times in 10 minutes when the device is not connected with any network.

What behavior are you observing?

We need the steps to test this condition.

Provide the steps to reproduce the issue, if applicable:

Please let me know how to test the described condition

Tell us about your environment:

Android-P

What version of the AVS Device SDK are you using?

v1.12

  <x.y.z>

Tell us what hardware you're using:
* [ ]  Desktop / Laptop - Yes

* [ ]  Raspberry Pi

* [ ]  Other - tell us more:

Tell us about your OS (Type & version):
* [ ]  Linux - Yes

* [ ]  MacOS

* [ ]  Raspbian Stretch

* [ ]  Raspbian Jessy

* [ ]  Other - tell us more:

Hi @caleighatamazon ,
To reproduce this issue, we have observations using two scenario's:

Using AVS-SDK logs
Using Wireshark logs
Please check the attached AVS-SDK logs, shows that the retrailCount to connect is 33 times i.e less than 50 times
PUPC-9679AVS_SDK_LOGS.txt
but in Wireshark, we have got the count more than 50 times. Also check the logs of wireshark.
Askey_CDR8010_EN_test2.zip
### The following is the test Procedure :
Steps using Wireshark:
[Precondition]

PC can provide wifi hotspot.
Install Wireshark software on PC (Wireshark official download link: https://www.wireshark.org/download.html).
UUT has already logged in Alexa account.
[Steps]
PC connects to the internet router via wire cable. (Must not use wifi because PC will stop sending package once it recognizes the wife disconnect.)
UUT connects to PC's wifi hotspot.
Open Wireshark. Capture > Option> select the network provided by the router.
The router disconnects to the internet, but PC still connects to the router.
Wait for 2 minutes.
Wireshark: Capture > Start, wait for 10 minutes. Make sure the number in Time column is over 600.
Type dns.qry.name matches "avs-alexa-fe.amazon.com" in the Filter.
Count how many times UUT sends a package to PC in 600 seconds

No.of retries is more than 50 times here.

Steps using AVS-SDK:

adb root
2.adb remount
3.sudo bash setup.sh config.json -a androidConfig.txt
4.Once  we get the message " **** Completed Configuration/Build ***" ,
give permission to the SampleApp using chmod command ( adb shell chmod a+x /product/avs/bin/SampleApp )
Now, use the 3rd command shared earlier (LD_LIBRARY_PATH=/product/avs/lib SampleApp product/avs/AlexaClientSDKConfig.json DEBUG9)
6.Capture the logs using adb logcat > log.txt

The retrailCount we got is "33 times"

Please suggest which is the correct procedure to reproduce this issue or let us know if any other test-scenario's are there to test this issue. Hope this is a critical issue & need response from your side ASAP.
@amazon-auto  @caleighatamazon

Hello @dipalisb,
As to which is the correct way to test the scenario, that depends upon what you are trying to do.
If you can explain your objective, we may be better able to answer your question.
The 33 HTTP2Transport retries look completely normal.  They start out with a small timeout (less than 1 second) before the next retry, and the timeout expands over a few iterations to a maximum retry interval that is less than 30 seconds but averages around 20 seconds, and the exact retry intervals are somewhat random.  This is the expected behavior.
There are also a two iterations of attempts by InternetConnectionMonitor to check if internet connectivity (not just connectivity to AVS) is available.  Those checks are supposed to occur about every 5 minutes, and they appear to have done so.
Best regards,
-SWH

Closing this due to inactivity, but please open a new issue if you are still experiencing problems.


Upgrade update-notifier and fix issues from npm audit.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 0.29.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How do I get the name of final file in Python?

I am using this currently:
        def my_hook(d):
                        if d['status'] == 'finished':
                            d1 = d['filename']
                            ...
                    ydl_opts = {
                        'progress_hooks': [my_hook],
                        'outtmpl': 'dls/%(playlist_title)s_%(title)s_%(format)s_%(autonumber)s.%(ext)s'
                    }
                    with youtube_dl.YoutubeDL(ydl_opts) as ydl:
                        d2 = ydl.extract_info(url)

But d2 doesn't have any filename attributes and my_hook is called two times when audio and video files are downloaded separately and then merged, and it is actually not called for the final, merged file.

I tried this as well:
file_name = 'dls/' + str(uuid.uuid4())
                    ydl_opts = {
                        'outtmpl': file_name
                    }
                    with youtube_dl.YoutubeDL(ydl_opts) as ydl:
                        d2 = ydl.extract_info(url)
                        file_name_with_ext = file_name + "." + d2['ext']
                        ...

It works sometimes, but when the file is merged into an mkv, d2['ext'] wrongly returns 'mp4'.

https://github.com/rg3/youtube-dl/issues/10987#issuecomment-284041577