modified the tests in the responsive web design curriculum Step - 13

Checklist:

[ ] I have read and followed the contribution guidelines.
[ ] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #51961
Modified tests in of the Responsive Web Design - Learn HTML by Building a Cat Photo App - Step 13

I'm thinking this extra test for white space should be on step 12, not step 13, since step 12 is where the user actually adds the "cat photos" link. Step 13 is just having the user delete the link below the p element, so they shouldn't be messing with the "cat photos" link at all.
If we want to keep this new test on step 13 as well, that's fine, it won't cause any harm. But then I guess you could make the argument that we should have it on step 14 as well.

Also, while your new test is catching white space after "photos", it is still allowing white space before "cat", at least with Firefox 118.

Also, while your new test is catching white space after "photos", it is still allowing white space before "cat", at least with Firefox 118.

My first test is checking for typos therefore it allows whitespaces you can check that by simply testing it using this code
function testWhiteSpaces(inputString) {

  const pattern =/^\s*cat photos\s*$/;

  const result = pattern.test(inputString);

  return result;
}

console.log(testWhiteSpaces(' cat photos'))
console.log(testWhiteSpaces('cat photos '))
console.log(testWhiteSpaces(' cat photos '))
console.log(testWhiteSpaces('cat photos'))
console.log(testWhiteSpaces('foo bar'))

AND
My second test is checking for 'cat photos' i.e innerText === 'cat photos' which is basically checking for whitespaces before and after cat photos

If we are really concerned about the anchor element content we shouldn't be lowercasing it or removing anything and we should use textContent or innerHTML and not innerText.
Something about this I didn't realize is the spacing inside innerText only happens if the a element is followed by outside text (which seems bizarre).

testing  cat photos  test

testing  cat photos

const nestedAnchor1 = document.querySelector('#test1 > a');
const nestedAnchor2 = document.querySelector('#test2 > a');

console.log('test 1', nestedAnchor1.innerText.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false
console.log('test 2', nestedAnchor2.innerText.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // true

textContent and innerHTML will always show the actual element content.
console.log('test 1', nestedAnchor1.textContent.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false
console.log('test 2', nestedAnchor2.textContent.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false

Please also replace jQuery in any test that is using it.

If we are really concerned about the anchor element content we shouldn't be lowercasing it or removing anything and we should use textContent or innerHTML and not innerText.
Something about this I didn't realize is the spacing inside innerText only happens if the a element is followed by outside text (which seems bizarre).

testing  cat photos  test

testing  cat photos

const nestedAnchor1 = document.querySelector('#test1 > a');
const nestedAnchor2 = document.querySelector('#test2 > a');

console.log('test 1', nestedAnchor1.innerText.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false
console.log('test 2', nestedAnchor2.innerText.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // true

textContent and innerHTML will always show the actual element content.
console.log('test 1', nestedAnchor1.textContent.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false
console.log('test 2', nestedAnchor2.textContent.toLowerCase().replace(/\s+/g, ' ') === 'cat photos') // false

Please also replace jQuery in any test that is using it.

@lasjorg

LowerCasing: I think the lowercasing is important because the user can type in any casing. I don't think we should be that strict about the casing we only want the content to be cat photos.
textContent or innerHTML: You are right I will commit new changes with innerHTML because we need exact spacing and also need to make sure that there are no other content inside anchor tag.
Removing jQuery: If I may ask why so? I will replace jquery in my tests anyways.

If we care about spaces that don't even show up visually then I'm not sure why we wouldn't care about the casing of the words. That seems much more important than the spaces. Anyway, I realize that is how the tests are now, but I just question the reason for it.
Great.
Because we do not need it and it is just an extra unnecessary dependency. Removing it should be done whenever challenge tests are updated.

Just going to point out one more time that we want the test for white space in the link test on step 12 since that's the step they add the link. I suppose it doesn't hurt to have it on step 13, but they aren't supposed to mess with the p element or the link inside of it in step 13, so I'm not sure we really gain anything by having it on step 13. Would probably make more sense to add it to step 14 as well since they are messing with the link on that step and there is a possibility they could change the spacing in the link text.

The issue is not technically the whitespace. We are checking the link text but if they add a space to the text it will not match the test.

Either we care about the text and whitespace and warn about both.

Or we only care about the text and should strip the whitespace before testing for just the text.

With the tests as they are in this PR, we should warn about both the text accuracy and the space.

The link's text should be cat photos. You have either omitted the text, have a typo, or have added spaces to the anchor text.

Or something like that.

The link's text should be cat photos. You have either omitted the text, have a typo, or have added spaces to the anchor text.

I think the intent was to have a separate test/hint just for the extra white space since so many people are getting caught by it. Having one hint that mentions everything that could be wrong with the link text is possibly too confusing.

Have a test/hint that verifies the text is "cat photos" (yes, enforce all lowercase).
Have a separate test/hint that checks for extra white space either before after "cat photos" in the link text.

Right, I wasn't looking at this correctly. I see now it was added as a second test. So that is fine.

BTW, we do have a removeWhiteSpace helper function. But I guess the regex works as well.
https://github.com/freeCodeCamp/curriculum-helpers/blob/main/lib/index.ts

I think the tests might be a little confusing. Thinking about this for a bit I might suggest the following.
The test that checks the correctness of the text:
Strip the whitespace. This should make it obvious we are simply testing that the text is correct.

The link's text should be cat photos. You have either omitted the text or have a typo.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isTrue((removeWhiteSpace(innerContent) === 'cat photos'));

The test that checks for whitespace:
Explicitly check for whitespace at the start|end. I would prefer if the test expressed what it is testing for, the intent isn't obvious from the test itself. The assert message is really the only thing that makes it clear.

The link's text should be cat photos. You either have leading or ending whitespaces.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isNotTrue(/^\s+|\s+$/.test(innerContent));

I also removed the toLowerCase because it doesn't make sense to me if we care about the correctness of the text.
Let me know if it makes sense.

I think the tests might be a little confusing. Thinking about this for a bit I might suggest the following.
The test that checks the correctness of the text:
Strip the whitespace. This should make it obvious we are simply testing that the text is correct.
Edit: Well, I guess I'm not quite awake yet because using removeWhiteSpace would remove the whitespace between the words. We just want to strip any starting/ending whitespace. Sorry about that. I edited the code.

The link's text should be cat photos. You have either omitted the text or have a typo.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isTrue(innerContent.trim() === 'cat photos'));

The test that checks for whitespace:
Explicitly check for whitespace at the start|end. I would prefer if the test expressed what it is testing for, the intent isn't obvious from the test itself. The assert message is really the only thing that makes it clear.

The link's text should be cat photos. You either have leading or ending whitespaces.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isNotTrue(/^\s+|\s+$/.test(innerContent));

I also removed the toLowerCase because it doesn't make sense to me if we care about the correctness of the text.
Let me know if it makes sense.

@jeremylt @bbsmooth any thoughts on this approach?

@lasjorg's approach looks good to me. Test that the text in the link is "cat photos" and test that there is no extra white space at the beginning or end of the link text. I think that's exactly what we want here.

@lasjorg's approach looks good to me. Test that the text in the link is "cat photos" and test that there is no extra white space at the beginning or end of the link text. I think that's exactly what we want here.
Also, I'll repeat one more time, these tests should be on step 12, not step 13.

@bbsmooth have written the same.
Test 1 is checking for typos and Test 2 is checking for whitespaces.
I actually wanted your thoughts on lowercasing the content before checking it.

@lasjorg's approach looks good to me. Test that the text in the link is "cat photos" and test that there is no extra white space at the beginning or end of the link text. I think that's exactly what we want here.
Also, I'll repeat one more time, these tests should be on step 12, not step 13.

@bbsmooth I have written the same.
Test 1 is checking for typos and Test 2 is checking for whitespaces.
I actually wanted your thoughts on lowercasing the content before checking it.

your thoughts on lowercasing the content before checking it

The link text is supposed to be "cat photos", all lowercase. The tests should enforce that.

your thoughts on lowercasing the content before checking it

The link text is supposed to be "cat photos", all lowercase. The tests should enforce that.

Ok so no lowercasing the content during test runs.

Can we do both steps 12 and 13 in this PR? That might be easier than having separate PRs.
@Yash-Ambekar Would you be up for that?
Also, please make sure the tests are passing before you push.

For future reference. You should be working on a separate branch from your main branch. Please review the docs again.
https://contribute.freecodecamp.org/#/how-to-contribute-to-the-codebase

Please make the agreed-upon changes to the tests.

Please make the agreed-upon changes to the tests.

Which changes can you mention them? My tests are checking the agreed upon criteria:

Checking for typos
Checking for whitespaces

And if they are wrong can you elaborate why they are wrong? I am trying to learn in the process.

It is not about correctness, it is about readability. The changes I suggested make it more clear what is being tested for.

I think the tests might be a little confusing. Thinking about this for a bit I might suggest the following.
The test that checks the correctness of the text:
Strip the whitespace. This should make it obvious we are simply testing that the text is correct.
Edit: Well, I guess I'm not quite awake yet because using removeWhiteSpace would remove the whitespace between the words. We just want to strip any starting/ending whitespace. Sorry about that. I edited the code.

The link's text should be cat photos. You have either omitted the text or have a typo.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isTrue(innerContent.trim() === 'cat photos'));

The test that checks for whitespace:
Explicitly check for whitespace at the start|end. I would prefer if the test expressed what it is testing for, the intent isn't obvious from the test itself. The assert message is really the only thing that makes it clear.

The link's text should be cat photos. You either have leading or ending whitespaces.

const nestedAnchor = document.querySelector('p > a');
const innerContent = nestedAnchor.innerHTML;
assert.isNotTrue(/^\s+|\s+$/.test(innerContent));

I also removed the toLowerCase because it doesn't make sense to me if we care about the correctness of the text.
Let me know if it makes sense.

Are these the changes you want? @lasjorg

I don't think this branch is changing the correct step. Step 13 is only about deleting 1 line. Why do we need to change it at all here?
There are a lot of changes in here but really the issue is only about adding a whitespace agnostic test in addition to the current test that cares about whitespace. I'm not sure why so many other lines were touched

Considering step 13 already had a check for the anchor text why do we not just implement it correctly using the same logic as in step 12? Otherwise, I would suggest we remove that test completely from step 13.
@bbsmooth @jeremylt would you not agree?

I think we only need to check that the first p element wasn't changed on Step 13

The tests we have now on step 13 are checking that nothing was changed other than the asked-for deletion of the below a element.
Including this test which checks the anchor text:

The link's text should be cat photos. You have either omitted the text or have a typo.
const nestedAnchor = $('p > a')[0];
assert(
  nestedAnchor.innerText.toLowerCase().replace(/\s+/g, ' ') === 'cat photos'
);

If we believe they might change the text is it not also possible they might add spaces?
Considering how much we are checking for in this step to make sure the code from the previous step wasn't changed when they deleted the below a element I see no harm in testing for whitespace as well.

How many possible specific changes do we want to check for on Step 13?

Not sure, but right now it seems that we are literally testing for anything that might have changed between 12 and 13 after they are asked to delete the a element.
That would seem to be the original intention of the tests, to make sure only the below a element was deleted and nothing else was changed.
I didn't look but I guess it might be some leftover testing from a step split as you suggest.

I honestly think we can just have a single test and let it be all-encompassing.

Do not make any changes to the elements you created in the previous step.

assert.strictEqual(document.querySelector('p').innerHTML, 'See more cat photos in our gallery.')

Or something like that.

@Yash-Ambekar I think what we have now looks good. I just wonder if we should simplify the tests for step 13 as I suggested here. It seems more to the point and would eliminate most of the tests.

@Yash-Ambekar I think what we have now looks good. I just wonder if we should simplify the tests for step 13 as I suggested here. It seems more to the point and would eliminate most of the tests.

I completely agree with you for adding a simplified test to step 13 as the task is just to delete the outside anchor tag. But I also agree with what sir @jeremylt said that it is a separate issue and 1 PR should not touch line of codes unrelated to the main issue.

It would just be easier to get it done now. You have already made changes to step 13. But sure, I can approve this and we can make the other changes in a new PR.

It would just be easier to get it done now. You have already made changes to step 13. But sure, I can approve this and we can make the other changes in a new PR.

Yes I can raise a new PR with the changes to step 13. Also it was a great learning experience for me as a newcomer to open source.

I will open a new PR as this PR was on the main branch.


Pending Transaction Filing

Describe the bug
Swap is not working. Pending transaction filling-up, speed up several times already the recent transaction in the history but still not working to be completed.
Steps to reproduce
Steps to reproduce here.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Currently experiencing this issue on katla, tried bridging ETH to Holesky about an hour ago but it remains "pending"

More than 24 hrs now, Hekla swap is still pending.


Remove cpu-only service from achatina required services

I accidentally left this in while I was trying to get achatina/achatina to work. The plugin service should be covered by the $ACHATINA_PLUGIN above.
Signed-off-by: Clement Ng<EMAIL_ADDRESS>

Apparently I am a terrible reviewer since I did not notice this either! Thanks @clementkng !


Cleaned up internal classes

Hi.
I was in need of this feature in my project, so I created something similar in a local branch.
Feel free to use any of it if you want to.
batch-polling-patch.txt
Disclaimer: I was not sure where you were headed with the rest client, so I simply copy/pasted the old poll impl (including Obsolete marking) and made the change.
Thank you for your great work

@madsph Awesome! That will be surely handy 😄
Also, what is your opinion about the current design using System.Threading.Tasks.Task<>? Our other SDKs have a slightly different strategy, which is similar to a custom thread pool for each worker.
We'll work to make a release soon, stay tuned 😎

@gardusig Great thanks - will be looking out for that :-)
Regarding Threads vs Tasks. I haven't given that much thought, so this is just what comes out top of my head.
I am a lazy bastard :-) so I would go a long way to avoid messing around with my own thread handling, even though I see how you could make a case for threads being "the right" way of implementing parallel workers. In my project, Tasks will suffice, but I realize that that may not be the case for all projects. But I guess you could just run multiple instances of the service hosting the workers, if different threads are truly needed, and then keep the code for this project as simple as possible. Simple would in my view be using Tasks.

Hey @madsph, I will let things move smoothly by shortening this PR to a few cleanup of the internal classes. Also agree with your answer :) Will use it as reference at the next PR with batch polling updates.


Add Membership Schema to the SILC Group Model

This will allow members to belong to more than one group and at the same time be able to opt-in or out of the groups. When a member leaves the group, their status can be set to left, dead, deactivated due to subscription credits expiring.
Below is an example of a membership schema which can be embedded as a collection of objects within the SILC Group Schema:
{
   _id: ObjectId,
   date_joined_group: String,
   status: {
                type: String,
                enum: ['active', 'left', 'deactivated']
             },
  date_of_leaving: String,
  reason_for_leaving: {type: String, enum:['end_of_cycle','subscription_expired','group_misconduct','voluntary','died'],
  silc_group_member: {type: ObjectId, ref: 'SILCGroupMember'}
}

I am working on this issue this weekend.


Handling Dependencies

Thanks for providing this library, looks really helpful!
Was wondering, how have you handled injecting dependencies into the queued task?
At https://docs.microsoft.com/en-us/aspnet/core/fundamentals/host/hosted-services?view=aspnetcore-2.2#consuming-a-scoped-service-in-a-background-task, they show injecting IServiceProvider into the hosted service to create a scope and pull services from that but don't see a way to do it with this library.

I might get round to supporting this on registration, there is a open PR but it needs changing to support passing the IServiceProvider in the invoking delegate as well as on exceptions. This hasn't been a priority for me though because I think MS will include the functionality in this package in Core 3.0.
However because it is just a delegate you can pass IServiceProvider into the delegate, just remember to create a new scope rather than just get the service.
public EmailController(BackgroundQueue backgroundQueue, IServiceProvider  serviceProvider)
{
   _backgroundQueue = backgroundQueue;
   _serviceProvider = serviceProvider;
}

[HttpPost, Route("/")]
public IActionResult SendEmail([FromBody]emailRequest)
{
   _backgroundQueue.Enqueue(async cancellationToken =>
   {
       using (var scope = _serviceProvider.CreateScope())
        {
            var scopedProcessingService = scope.ServiceProvider.GetRequiredService<IScopedProcessingService>();

            scopedProcessingService.DoWork();
        }
   });

   return Ok();
}

Caveat I haven't tested this, but see no reason why this shouldn't because IServiceProvider is a singleton.

Hi. I tried to get this going. I have an app that downloads big files in the background but needs to write to the database during this process for progress etc.
Here is Startup.cs
`public void ConfigureServices(IServiceCollection services)
{
services.Configure(options =>
{
// This lambda determines whether user consent for non-essential cookies is needed for a given request.
options.CheckConsentNeeded = context => true;
options.MinimumSameSitePolicy = SameSiteMode.None;
});
        services.AddBackgroundQueue(onException: exception =>
        {
            Console.WriteLine(exception.Message);
            throw exception;
        });

        services.AddDbContext<ApplicationDbContext>(options =>
            options.UseSqlServer(
                Configuration.GetConnectionString("DefaultConnection")));
        services.AddDbContext<Models.db_productpriceContext>();
        services.AddDefaultIdentity<IdentityUser>()
            .AddDefaultUI(UIFramework.Bootstrap4)
            .AddEntityFrameworkStores<ApplicationDbContext>();

        services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_2);
        services.AddScoped<IDownloadRepository, DownloadRepository>();
        services.AddScoped<IDownloadHandler, DownloadHandler>();

    }`

Here is DownloadsController.cs
`using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using DalSoft.Hosting.BackgroundQueue;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using Updater1.BackgroundTasks;
using Updater1.DAL;
using Updater1.Models;
namespace Updater1.Controllers
{
public class DownloadsController : Controller
{
private readonly db_productpriceContext _context;
private readonly BackgroundQueue _backgroundQueue;
private readonly IDownloadRepository _downloadRepository;
private IServiceProvider _serviceProvider;
    public DownloadsController(db_productpriceContext context, BackgroundQueue backgroundQueue, IDownloadRepository downloadRepository,  IServiceProvider serviceProvider)
    {
        _context = context;
        _downloadRepository = downloadRepository;
        _backgroundQueue = backgroundQueue;
        _serviceProvider = serviceProvider;
    }

....
    [HttpPost]
    [ValidateAntiForgeryToken]
    public async Task<IActionResult> Create([Bind("Id,FeedId,DateValidUntil")] Download download)
    {
        if (ModelState.IsValid)
        {
            _downloadRepository.InsertDownload(download);
            download.DatedownloadStarted = DateTime.Now;
            _downloadRepository.Save();
            IServiceScopeFactory scopeFactory = _serviceProvider.GetRequiredService<IServiceScopeFactory>();
            using (var scope = scopeFactory.CreateScope())
            {
                _backgroundQueue.Enqueue(async cancellationToken =>
                {
                    using (var scopedDownloadHandler = scope.ServiceProvider.GetRequiredService<IDownloadHandler>())
                    {
                        await scopedDownloadHandler.DownloadAsync(download);
                    }
                });
            }

            return RedirectToAction(nameof(Index));
        }
        ViewData["FeedId"] = new SelectList(_context.Feed, "Id", "Name", download.FeedId);

        return View(download);
    }

`
I tried your code too but I keep getting Object already disposed on DeQueue method - is this significant.

I was trying to use something like this post:
https://github.com/aspnet/DependencyInjection/issues/440

Is this still going? Awesome Nuget, but I face same DI problem when trying to insert into db. It always states that any custom service I use in same controller is disposed.

Fully supported in v2.0.0
Updated in README.md has an example showing how to do this in v.2.0.0
v2.0 has a fully working EF example in the repo


Lock whitenoise dependency version

Whitenoise starting at 5.0.0 (10/12/2019) does not support python2.7 anymore and fails building. Locking to latest version that supports python2.7
https://pypi.org/project/whitenoise/5.0/

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0aacb4c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2606   +/-   ##
=========================================
  Coverage          ?   80.21%
=========================================
  Files             ?       87
  Lines             ?     9335
  Branches          ?     1988
=========================================
  Hits              ?     7488
  Misses            ?     1564
  Partials          ?      283

Impacted Files
Coverage Δ

webapp/graphite/readers/ceres.py
92.00% <0.00%> (ø)

webapp/graphite/wsgi.py
40.62% <0.00%> (ø)

webapp/graphite/url_shortener/models.py
100.00% <0.00%> (ø)

webapp/graphite/composer/views.py
23.80% <0.00%> (ø)

webapp/graphite/render/attime.py
98.63% <0.00%> (ø)

webapp/graphite/settings.py
75.00% <0.00%> (ø)

webapp/graphite/tags/redis.py
90.74% <0.00%> (ø)

webapp/graphite/render/glyph.py
41.28% <0.00%> (ø)

webapp/graphite/account/migrations/0001_initial.py
100.00% <0.00%> (ø)

webapp/graphite/singleton.py
82.22% <0.00%> (ø)

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aacb4c...65d986e. Read the comment docs.

A slightly more complete version of this change showed up just recently in a different open PR: https://github.com/graphite-project/graphite-web/pull/2409/commits/e18778dac566426c11e6fe78ae73ced6c274177b

Happy to close this one!


swagger-validator reports valid string with format="date" as invalid

    "swagger-tools": "^0.9.0",

While dealing with a response, 2 dates are rejected:
  swagger-tools:middleware:validator   Response validation: failed +7s
  swagger-tools:middleware:validator   Reason: Failed schema validation +4ms
  swagger-tools:middleware:validator   Errors: +0ms
  swagger-tools:middleware:validator     0: +0ms
  swagger-tools:middleware:validator       code: INVALID_FORMAT +0ms
  swagger-tools:middleware:validator       message: Object didn't pass validation for format date: 2015-08-19T03:36:07.000Z +0ms
  swagger-tools:middleware:validator       path: ["result","320","lastModifiedDate"] +0ms
  swagger-tools:middleware:validator     1: +0ms
  swagger-tools:middleware:validator       code: INVALID_FORMAT +0ms
  swagger-tools:middleware:validator       message: Object didn't pass validation for format date: 2015-08-19T03:36:07.000Z +4ms
  swagger-tools:middleware:validator       path: ["result","320","submittedDate"] +0ms

...while they are perfectly valid according to RFC3339 examples are recognized as such by Node.js:
> d = new Date("2014-03-18T06:46:26.000Z")
Tue Mar 18 2014 07:46:26 GMT+0100 (Romance Standard Time)

Invalid formats and types are handled by z-schema and its logic is based off of this section of the RFC3399 spec: http://tools.ietf.org/html/rfc3339#section-5.6  I know for Swagger 1.2 support I copied the date and date-time format validators from z-schema for Swagger 1.2 support, which I had to manually validate things since Swagger 1.2 objects are not valid JSON Schema, and it uses a RegExp like this: /^([0-9]{4})-([0-9]{2})-([0-9]{2})$/  That being said, I'm not surprised your date-time value is not passing date validation but since z-schema is the one performing the validation, I'd suggest you open an issue with them if you don't agree with what I've described above.


Make the stylesheet a configuration option.

The stylesheet is currently hardcoded into the plugin. Would like to see this as an option so the look can be more customizable.

You can actually use your own custom modal and stylesheet very easily - need to rename this issue something like 'Include instructions for a custom modal / dialog'

I'm using custom modals but there is still a stylesheet taking over? Am I missing something?

@alexmills Can you show an example of your modal implementation with code?  I'll post how and why it doesn't collide and close this issue.

Configured in main.ts
export function configure(aurelia) {

    // Developement Profile
    aurelia.use
      .standardConfiguration()
      .developmentLogging()
      .plugin('aurelia-html-import-template-loader')
      .plugin('aurelia-dialog')
      .plugin('aurelia-validation');

  aurelia.start()
  .then(a => a.setRoot());
}

Simple Modal HTML (UploadErrorModal)
<template>
  <require from="common/select"></require>
  <ai-dialog class="little">

    <ai-dialog-header>
      Upload Error: ${name}
    </ai-dialog-header>

    <ai-dialog-body>

Unable to upload file, please try again.

    </ai-dialog-body>

    <ai-dialog-footer>
      <button class="btn-green-outline" click.trigger="controller.cancel()">OK</button>
    </ai-dialog-footer>

  </ai-dialog>
</template>

Called using DialogService (dialog)
this.dialog.open({viewModel:UploadErrorModal,model:file})

But there is CSS inserted at the top of the page which takes over footer buttons

The ai-dialog custom element and it's children would all use their own styling - if you want to have your own modal implementation you should create your own variation such as am-dialog or my-modal or whatever you want to name it.  This prevents collision for styling and naming.


More fsevent apis

Ping @octplane, this one is much simpler. :-P

Thanks, will have a look shortly!

Thanks! Now working to do a release :)

And everything is released! Thanks again for your time <3

https://crates.io/crates/fsevent-sys/4.1.0
https://crates.io/crates/fsevent/2.1.2

And everything is released! Thanks again for your time <3

https://crates.io/crates/fsevent-sys/4.1.0
https://crates.io/crates/fsevent/2.1.2

@octplane Thanks! :-)


Fixing test actions

Codecov Report
Base: 87.83% // Head: 87.83% // No change to project coverage :thumbsup:

Coverage data is based on head (c938b54) compared to base (93c526f).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   87.83%   87.83%
=======================================
  Files           2        2
  Lines        1143     1143
  Branches      178      205   +27
=======================================
  Hits         1004     1004
  Misses         99       99
  Partials       40       40

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Determine best approach for collecting responses to PRA approved customer satisfaction survey

@KameronKerger is going to clarify/confirm that USDS can host the survey and collect the responses and exactly what "burden to EPA" means
Long term we are recommending that CEQ apply for their own generic PRA clearance - @KameronKerger and @lucasmbrown-usds are providing them with some guidance about the types of things we would want to colled & the justifications

There's just one outstanding issue @KameronKerger will discuss with @vim-usds regarding whether the header could be put into the separate tab version of the survey, but we can track that separately


Diagram is not rendering in live preview mode

Please check that what is going wrong with it because it is not rendering in live preview mode which is very important otherwise I can't see it while writing my notes.

You just need to refresh it removing and putting it back or closing and reopening the note it fix it i don't know if there is a faster workaround, but this work for me

Yes .. this is pretty non-intuitive. I wish there was a "refresh" menu option or (better) icon.


Enhancement: Improve Handling of Error State in Global Store

Currently, the setError function in our global store lacks a clear method for displaying errors to users. We need to refine this to provide a better user experience.
Proposed Changes:

Enhance setError to include a standardized error presentation model.
Implement support for additional error metadata.
Introduce a centralized error component for consistent error display.

Objective:
By improving setError, we aim to enhance the user experience by providing clearer error messages.
setError on store:
   setError(state, payload) {
     state.error = payload
 },

Looks good @jvJUCA .
Please assign me this issue

even i am also intrested in the issue @jvJUCA

Looks good @jvJUCA . Please assign me this issue

Assigned to you. Ready to begin?

@jvJUCA can i also work on it ?

Looks good @jvJUCA . Please assign me this issue

Assigned to you. Ready to begin?

Yes, will let you know if I need any assistance.


Fix array items to also handle raw types

Add handling parser.rb to handle constructs like { "type" => "string" } in the items list/hash for an array
Fix ObjC parser to account for this (and move some functions into Utils modules)
Update tests for parser and Obj properties

Dang. :+1:
I'll dig through this in a bit. Thanks for the PR!

Ship It! Looks great to me. Chris, please give this a cursory glance and merge when you get some time.

Looking.

Looks great. Thanks for the changes David. Sorry for the wait. Merging now.
I'll follow up with the TODO items in separate issue (#38).

Bugs are fixed. Waiting for CI to verify. Once thats done, I'll release this in 0.2.2.

Released: https://rubygems.org/gems/nidyx/versions/0.2.2


Dagster dbt link broken link in docs

Steps to reproduce:

In the dbt docs for Dagster here, the link for dagster_dbt goes to a broken page
Expected results:

I think it should be dagster-dbt instead:
https://docs.dagster.io/_apidocs/libraries/dagster-dbt
Actual results

Instead, it goes to here and has an error:

Extra details

Thanks Sarah! Just updated the link :)
For broken links / quick fixes, feel free to use the "Edit this page" button at the bottom of each docs page


fix hmr for hot-server-dumb

@keybase/react-hackers
makes
yarn run hot-server-dumb actually HMR when you edit

@keybase/react-hackers bump


Not working with typescript

Hi friends i have this module installed but it does not seem to be working for typescript .ts files. To be honest im not even sure if tree-sitter is working at all, ive noticed no difference, but the rainbow parenthesis color is deff no working.
init.vim
lua << EOF
require'nvim-treesitter.configs'.setup {
  rainbow = {
    enable = true,
    extended_mode = true, -- Highlight also non-parentheses delimiters, boolean or table: lang -> boolean
    max_file_lines = 1000, -- Do not enable for files with more than 1000 lines, int
  }
}
EOF

:TSConfigInfo
{
  ensure_installed = {},
  ignore_install = {},
  modules = {
    highlight = {
      additional_vim_regex_highlighting = false,
      custom_captures = {},
      disable = { "c", "rust" },
      enable = true,
      loaded = true,
      module_path = "nvim-treesitter.highlight"
    },
    incremental_selection = {
      disable = {},
      enable = false,
      keymaps = {
        init_selection = "gnn",
        node_decremental = "grm",
        node_incremental = "grn",
        scope_incremental = "grc"
      },
      module_path = "nvim-treesitter.incremental_selection"
    },
    indent = {
      disable = {},
      enable = false,
      module_path = "nvim-treesitter.indent"
    },
    rainbow = {
      enable = true,
      extended_mode = true,
      max_file_lines = 1000
    }
  },
  update_strategy = "lockfile"
}

:checkhealth nvim_treesitter
health#nvim_treesitter#check
========================================================================
## Installation
  - OK: `tree-sitter` found  0.19.5 (8d8690538ef0029885c7ef1f163b0e32f256a5aa) (parser generator, only needed for :TSInstallFromGrammar)
  - OK: `node` found v12.18.3 (only needed for :TSInstallFromGrammar)
  - OK: `git` executable found.
  - OK: `cc` executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl" }
  - OK: Neovim was compiled with tree-sitter runtime ABI version 13 (required >=13). Parsers must be compatible with runtime ABI.

Can you paste the typescript code here?

Just want to point out im prettier new to this plugin, so i could be doing something entirely wrong. Let me know if you need me to provide you with more information
import MySQL from "./services/mysql.service";

export const InsertIntoPersonGame = async (payload) => {
    const connection = MySQL();

    const query = "INSERT INTO person_game SET ?";

    try {
        const results = await connection.query(query, payload);

        return results;
    } catch (err) {
        throw err;
    } finally {
        await connection.end();
        connection.quit();
    }
};

export const GetTrackedGames = async () => {
    const connection = MySQL();

    const query = `
        SELECT *
        FROM discovery_games
    `;

    try {
        const results = await connection.query(query);
        return results;
    } catch (err) {
        throw err;
    } finally {
        await connection.end();
        connection.quit();
    }
};

Should be fixed now, sorry about that - I don't know typescript so I couldn't test it thoroughly

Should be fixed now, sorry about that - I don't know typescript so I couldn't test it thoroughly

thanks, and how do i update the module to get your fix?

Use the update command from your package manager

Use the update command from your package manager

Ye thats the first thing i tried :PlugUpdate but no change to nvim-treesitter

Did you install this module using vim-plug?

Did you install this module using vim-plug?

I have installed nvim-treesitter via vim-plug and this is one of the modules included https://github.com/nvim-treesitter/nvim-treesitter/wiki/Extra-modules-and-plugins

It's not "included" in the main plugin, it just works with the main plugin's module system. You still have to install it separately

It's not "included" in the main plugin, it just works with the main plugin's module system. You still have to install it separately

oh! Well yep its working now hhhh


Fix some typos in settings

Awesome work! This is very minor.

Thanks to you @TrevorSayre for the corrections! I've deployed them


Fix NPE in semantic highlighting job

In case the editor is closed, no interactive compilation unit can be
retrieved and null is returned. This bug occurred while stepping through
multiple files in the debugger.
Fixes #1002386

LGTM! thanks!


Add test for array constructor references

See discord discussions. I think it would be good to resugar it to int[]::new instead of a lambda.

Maybe add int[][]::new to this list?

Sure. My idea was "primitive array" + "object array" + "array array", but a separate case for $\textsf{primitive array}^2$ might be good to have too.

Thanks for the extra tests!


How to change the news feed?

I try adding others but they won't show up. I would like to use this - any ideas? thanks in advance...
http://hosted.ap.org/dynamic/fronts/NOTICIAS_DEPORTIVAS?SITE=AP&SECTION=HOME

I found the links
http://hosted2.ap.org/APDEFAULT/APNewsFeeds
but i keep getting errors, any ideas?
03-02 20:19:06.448 24562-24613/net.maxbraun.mirror E/News: Parsing news XML response failed:                                                             org.xmlpull.v1.XmlPullParserException: unexpected type (position:END_DOCUMENT null@1:1 in java.io.StringReader@b3b585d)                                                                 at org.kxml2.io.KXmlParser.nextTag(KXmlParser.java:2054)                                                                at net.maxbraun.mirror.News.getData(News.java:61)                                                                at net.maxbraun.mirror.News.getData(News.java:18)                                                                at net.maxbraun.mirror.DataUpdater.update(DataUpdater.java:105)                                                                at net.maxbraun.mirror.DataUpdater.access$000(DataUpdater.java:16)                                                                at net.maxbraun.mirror.DataUpdater$1.run(DataUpdater.java:81)                                                                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)                                                                at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:279)                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:152)                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)                                                                at java.lang.Thread.run(Thread.java:818)

Ok never mind the link works now

how did you get this to work? i live in the uk so want to use one of these 3 feeds:
http://feeds.bbci.co.uk/news/rss.xml
http://feeds.skynews.com/feeds/rss/uk.xml
http://feeds.reuters.com/reuters/UKTopNews
BBC or Sky is probably better option but i imagine it has something to do with it being RSS and not Atom feed? this is my first time working on an android app so its probably something obvious?


Urls incompatibilities with django 1.10

Hi guys, i want report this:
/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/paypal/express/urls.py:23: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  name='paypal-direct-payment'),

/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/paypal/express/dashboard/app.py:19: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  name='paypal-express-detail'),

We are also running into this issue. Any update as to whether/when django-oscar-paypal will support django 1.10?

@sterago I don't know about it.

@codeinthehole can we expect django 1.10 support anytime soon and, in general, maintenance updates or should we look somewhere else as far as paypal integration with django-oscar is concerned?

@sasha0 Hey man.

I've addressed this and other issues in  #159.


Restore music playback after TTS

We need to make services to save the current state of playing music and restore it. Same as media_player_sonos_snapshot and media_player_sonos_restore.

What does TTS mean?

text to speech


Color weirdness.

Any idea why the dark theme doesn't fill in all the colors? The light theme works well.

Hi Jack,
Not able to elaborate that much without more details, the only reason that I can see for the moment is that you are setting the background before changing the colorscheme.
You can have a look at the following issues where people did encounter the same problem.
#49, #50, #51
Let me know if that works

Thanks :)


When Now CLI is installed globally (the first time), render a suggestion

In order to prevent breakage (from upgrading Now CLI), we want to recommend people to pin Now CLI to a certain version (installing it locally).
As part of this, we'll also bundle all the default Builders.
We could encourage people to do so using a message like this (which should render the first time you install Now CLI globally):

We recommend adding Now CLI to your project directly: npm install -S now

The command should change based on whether yarn or npm was used.
This also relates to https://github.com/zeit/now-cli/issues/2792.

Closed in favor of https://zeit.atlassian.net/browse/PRODUCT-101?atlOrigin=eyJpIjoiMmU3OGJkNWUxZWY4NDkzYzg1NGFmZTE2MmY1YTczMjEiLCJwIjoiaiJ9


[DOCS] Remove / change comparison between Adaptive / Composer to Waterfall

Version
doc - https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/bfcomposer-intro.md#advantage-of-developing-bots-botframework-composer
We should remove the table.
We can pick some of the benefits highlighted in to the "advantage" column.
Adaptive is built on top of V4 SDK. You will be able to call a waterfall dialog from within Adaptive.
But we should not compare.

Removed the table, added advantages in bullet format. Closing now that changes are live and visible.


Usually the main manifest is the latest, but there are examples of packages where it's the opposite:  the main version is the old one, and newer ones have version suffixes.  In rare cases the main manifest is so old that it doesn't have a tools version, and the new logic for tools version loading incorrectly reported an error in those cases.
rdar://73267827

@swift-ci please smoke test

@swift-ci please smoke test


Sequencer pulls L1 -> L2 messages from archiver

The sequencer queries the archiver to get the L1 -> L2 message to include into its next next block.

Depends on #520


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-05-28)
CI

actions: add changelog-types for release (09cd541)

Docs

counter: add example for Counter (5ebd264)
example: add Counter Example (ac5af06)

chore

release 1.0.0 (6145cec)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/gemone/gounter/releases/tag/v1.0.0 :sunflower:


fix(shard_mapper): fix nil pointer dereference in creating an Iterator

Closes #21065
Describe your proposed changes here.
If there is an error in creating an Iterator,  the input return by sg.CreateIterator(ctx, mm, opt) will be nil.
however, when close the Iterator, There is no operation to check the status, so there is a panic for close()

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Rebased/mergable
[x] Tests pass
[x] Sign CLA (if not already signed)

@lesam  i see you have approved a similar commit for the enterprise version. Can you approve this one for OSS too?

Can we push this? Flux is quite buggy and it does not work for 1.8.10

at this time, we are guiding our community users to InfluxDB 2.1...it has the latest fixes and advances for Flux and where we are focusing our efforts.  If you run into issues or blockers that would prevent you from upgrading to the 2.x release line, we want to know about those too!  We have been working to eliminate those regressions and continue to streamline that experience.

Yes I understand but atm I can't upgrade my legacy installation of influxdb to 2.1. so i need to continue to use 1.8.x. but seems that it's badly broken

What is blocking the upgrade? Flux v0.65 was a pretty early implementation and we made a pretty big change to it which then became a stepping stone to InfluxDB v2. Effectively, we aren't going to address defects with Flux in 1.8. If you need those fixes, move to v2. If you need help, please outline how we can help you complete the upgrade.

at this time, we are guiding our community users to InfluxDB 2.1...it has the latest fixes and advances for Flux and where we are focusing our efforts. If you run into issues or blockers that would prevent you from upgrading to the 2.x release line, we want to know about those too! We have been working to eliminate those regressions and continue to streamline that experience.

I'm running on the latest version(2.1.1) but I'm still getting the same error. Do you have any solution for it?

2021-11-22T23:49:13.712684Z     info    Execute source panic    {"log_id": "0XzW6NFl000", "service": "storage-reads", "error": "panic: runtime error: invalid memory address or nil pointer dereference"}
goroutine 2134 [running]:
runtime/debug.Stack()
/home/circleci/.tools/go/src/runtime/debug/stack.go:24 +0x65
github.com/influxdata/flux/execute.(*executionState).do.func1.1()
/home/circleci/go/pkg/mod/github.com/influxdata/flux@v0.139.0/execute/executor.go:286 +0x205
panic({0x80c17a0, 0x7569700})
/home/circleci/.tools/go/src/runtime/panic.go:1038 +0x215
github.com/influxdata/influxdb/v2/v1/services/storage.(*Store).measurementFields.func1()
/home/circleci/go/src/github.com/influxdata/influxdb/v1/services/storage/store.go:546 +0x1c
panic({0x80eaf40, 0xc0006475c0})
/home/circleci/.tools/go/src/runtime/panic.go:1038 +0x215
github.com/influxdata/influxdb/v2/v1/services/storage.(*Store).measurementFields(0xc000772330, {0x9923390, 0xc00262c980}, 0xc0040e3bd0)
/home/circleci/go/src/github.com/influxdata/influxdb/v1/services/storage/store.go:549 +0x33f
github.com/influxdata/influxdb/v2/v1/services/storage.(*Store).TagValues(0x98f62e8, {0x9923390, 0xc00262c980}, 0xc000647470)
/home/circleci/go/src/github.com/influxdata/influxdb/v1/services/storage/store.go:406 +0x390
github.com/influxdata/influxdb/v2/storage/flux.(*tagValuesIterator).Do(0xc001316900, 0x619c2c79)
/home/circleci/go/src/github.com/influxdata/influxdb/storage/flux/reader.go:970 +0x1c6
github.com/influxdata/influxdb/v2/query/stdlib/influxdata/influxdb.(*Source).processTables(0xc000b591e0, {0x9923390, 0xc00262c980}, {0x98ebd20, 0xc001316900}, 0xc004642670)
/home/circleci/go/src/github.com/influxdata/influxdb/query/stdlib/influxdata/influxdb/source.go:76 +0xbf
github.com/influxdata/influxdb/v2/query/stdlib/influxdata/influxdb.(*readTagValuesSource).run(0xc000b591e0, {0x9923390, 0xc00262c980})
/home/circleci/go/src/github.com/influxdata/influxdb/query/stdlib/influxdata/influxdb/source.go:492 +0x114
github.com/influxdata/influxdb/v2/query/stdlib/influxdata/influxdb.(*Source).Run(0xc000b591e0, {0x9923390, 0xc00262c980})
/home/circleci/go/src/github.com/influxdata/influxdb/query/stdlib/influxdata/influxdb/source.go:56 +0x168
github.com/influxdata/flux/execute.(*executionState).do.func1({0x9924f58, 0xc000b591e0})
/home/circleci/go/pkg/mod/github.com/influxdata/flux@v0.139.0/execute/executor.go:291 +0x20e
created by github.com/influxdata/flux/execute.(*executionState).do
/home/circleci/go/pkg/mod/github.com/influxdata/flux@v0.139.0/execute/executor.go:261 +0x228

@thanhdat6716 that looks like a different issue entirely (though still a panic). I recommend you file a new bug, ideally with a way to reproduce it.

please outline how we can help you complete the upgrade.

By providing an armv7 build


Disabled cookies lead to - Overbearing permissions required to sign CLA

When using cla-assistant in the past, I've only needed to grant email address read access to cla-assistant in order to sign a CLA. In my settings, I can confirm this is the only permission granted to cla-assistant:

A new contributor to our repository https://github.com/smallstep/certificates is reporting that cla-assistant is asking for extraneous permissions:

and is discouraged from signing our CLA using cla-assistant because it's not clear why cla-assistant would need to configure web hooks, update commit statuses, and edit gists in order to facilitate signing our CLA. You can view the details on https://github.com/smallstep/certificates/pull/251.
In my current setup, I am able to view the CLA by visiting https://cla-assistant.io/smallstep/certificates?pullRequest=251 and I am not prompted to provide additional authorization.
Has something changed? Is this a regression? My expectation has been that general users are able to sign CLAs without needing to pull in the additional permissions that appear (well, my guess) to be associated with configuring a repo for integration with CLA assistant.

Hi David, nothing changed in terms of authorization scope requests on CLA assistant site. I believe the user tries to access cla-assistant via the landing page (https://cla-assistant.io) which leads him to the admin view and for that CLA assistant requires extended permissions. If the user would just follow the link to your cla and click the button "Sign in with GitHub to agree" everything would work fine without additional authorization scope.

That aligns with my understanding. I'd already suggested the user use the direct link in the PR https://github.com/smallstep/certificates/pull/251#issuecomment-625612438 and according to their following comment they did not have success. I'll reiterate. If they're still having issues I'll try to repro and report back. Thanks!

Hi, I landed on this page as well, and I did not access via the landing page (https://cla-assistant.io/).
My steps were:

I accessed https://cla-assistant.io/tldr-pages/tldr (via link near the top of this page)
I clicked Sign in with GitHub to agree and was brought to the page asking for Email permissions only
I clicked Authorize... and was brought to another page asking for these additional permissions

@ibakshay @michael-spengler can we reproduce this? Something seems to go wrong here...

Hi @KharitonOff,
I tried to reproduce with the same steps as how @jn64 did.
Step 1,2 are the same to me too.

However in step 3 after clicking authorize, I was not brought to another page asking for additional permissions. I tried other possibilities, but till now I am not able to reproduce this :(.

I revoked CLA assistant from my account and tried again, same result. Screencast:

I believe the cause is I have cookies disabled by default, which was reported in #97 and never resolved.

@jn64 thanks for the hint! We lost track of this issue, since it was closed long time ago

Issues #78 and #97 etc. are (prematurely closed) duplicates of this issue, and so are #810 and #863 (both still open), plus likely more.


Fix ValueError exception

Description:
prevous code:
structure = '>{:c}'.format(data_types[register.get(CONF_DATA_TYPE)][register.get(CONF_COUNT)])
give:
ValueError: Unknown format code 'c' for object of type 'str'
If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@MartinHjelmare I don't know why Tarvis fails.


Can't find graphql config

I've defined both in the package.json like this:
"graphql": {
    "request": {
      "url": "https://api.graph.cool/relay/v1/cj2b3cy...3556gi9j5u"
    }
  },

and exported the environment variable like this:
export GRAPHQL_ENDPOINT="https://api.graph.cool/relay/v1/cj2b3cy...3556gi9j5u"
And I'm running react-native run-ios
Even with these both set, I receive the message saying it can't find the config.
Am I doing something wrong?

Huh. I think I have to run npm run start to run the packager, but if I do react-native run-ios it won't work?

Could you post your full package.json?

{
  "name": "Lavapp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "graphql": {
    "request": {
      "url": "https://api.graph.cool/relay/v1/cj2b3cyaz71ye013556gi9j5u"
    }
  },
  "dependencies": {
    "axios": "^0.15.3",
    "react": "15.4.2",
    "react-native": "0.41.2",
    "react-native-button": "^1.8.2",
    "react-native-calendar": "^0.11.0",
    "react-native-drawer": "^2.3.0",
    "react-native-elements": "^0.10.0",
    "react-native-linear-gradient": "^2.0.0",
    "react-native-lock": "^0.4.0",
    "react-native-maps": "^0.13.0",
    "react-native-router-flux": "^3.38.1",
    "react-native-star-rating": "^1.0.7",
    "react-native-vector-icons": "^4.0.0",
    "react-relay": "^0.10.0",
    "recompose": "^0.23.1",
    "styled-components": "^1.4.5"
  },
  "devDependencies": {
    "babel-jest": "18.0.0",
    "babel-plugin-react-relay": "^0.10.0",
    "babel-plugin-transform-react-jsx-source": "^6.22.0",
    "babel-preset-react-native": "1.9.1",
    "babel-relay-plugin": "^0.11.0",
    "jest": "18.1.0",
    "react-test-renderer": "15.4.2"
  },
  "jest": {
    "preset": "react-native"
  },
  "rnpm": {
    "assets": [
      "./app/assets/fonts"
    ]
  }
}

But now my problem is different.
I'm getting the transform error message:

But when I run babel fileWithRelayQL.js it correctly transpiles the QL calls to an IIFE calls.

This is what worked for me: restarting my mac. So weird.
I got the answer here: http://stackoverflow.com/questions/39137302/react-native-relayql-unexpected-invocation-at-runtime

@marktani just to be clear: it only picks up the config if I run npm run start, that is, run the packager manually.  Correct?


Scripts not run on private window

STR:
just open private window and load a site that has custom script.

No fixes? :-/ I would like this as well, possibly optionally.

Seems like we need to add this link to package.json
"permissions": {"private-browsing": true}

https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/private-browsing#Opting_into_private_browsing

:+1: Yes please :-) I'm not familiar with manually building extensions (and https://jetpack.mozillalabs.com/sdk/latest/docs/ 404s?), but I'm patient..

^^ Landed fix. It will go out in next version

The new version has already been approved and released: https://addons.mozilla.org/en-US/firefox/addon/dotjs/
:balloon:

\o/ thanks!


Tab length can't be set

I'm not entirely sure if this is an issue with this package or something else, but I am having an annoying issue where my tab length keeps getting set to 4. If I try to edit the setting to 2, the 2 is immediately replaced by a 4. If I just delete the 4, placeholder text says Default: 2, but this is not actually the case when I try to autoindent and get 4 spaces instead of 2.
I also see similar behavior when editing config.cson: I can add tabLength: 2 under the appropritae settings, but as soon as I save, that line is deleted and replaced with tabLength: 4! This does not happen with editor settings with any other language.
My default tab length is set to 4, but I would like to use 2 spaces for Javascript.
Atom version:
$ atom --version
Atom    : 1.7.4
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

language-babel version 2.23.0.

Appears to be a bug in Atom itself.  As a fix you will need to remove the lines shown in the image below from config.cson and save it. Atom creates these when a non-default setting has been set on a grammar's settings but they keep getting created when a global tab length is changed!!!!! Very bad.
Detail: Atom has a global tab setting and each grammar package can have an individual tab setting. e.g. In language babel's package settings you will see two distinct grammar settings Babel ES6 Grammar and Regular Expressions (Babel) Grammar. If you set a tab length here you will see something like this in config.cson

However setting a global tab length also set's these two options. BUT resetting the global doesn't reset the individual settings. The same seems to happen for any grammar if that grammars tab length is changed just once!!

Referred to Atom https://github.com/atom/atom/issues/11840

Thank you!

Anyone experiencing this issue? I am using 1.14.1 Atom and Latest version of the package but I am having the same issue.

I still have this problem even in Atom 1.19. Had to work around with manual edit as @gandm wrote.

gandm's technique does not work for me.  My tab settings are always set to 8 no matter what tabLength parameter I have in any setting.  Yet 8 shows up nowhere in any config file.  Very frustrating.


carousel sequence problem

The issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.
Bug description:
I have a problem with sequence transition, when I load more than 10 slides. sequences becomes crazy skip sequence order and didn't follow index order.
Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/DUtA2cHnZkM2ZVp91fAE?p=preview
Version of Angular, UIBS, and Bootstrap
Angular:
angular 1.5.0
animate 1.5.0
UIBS:
angular-ui-bootstrap 1.2.5
Bootstrap:
Bootstrap 3.3.6

@carlosMoncada, this is fixed in master.  In the future, please be more respectful of our time by searching both open and closed issues before entering anything.  Thanks.


LimitlessLED not able to switch to warm white / cold white while an RGB color is active

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.49.0
Python release (python3 --version):
Python 3.4.2
Component/platform:
limitlessled
Description of problem:
When trying to switch from any color back to cold white/warm white, nothing happens, whether by dragging the color temperature slider or calling light.turn_on with color_temp/kelvin parameter. The bulb has to first be switched back to "white mode" by setting an RGB white.
Expected:
The bulb should switch to white mode automatically when it is currently in RGB color mode.
Problem-relevant configuration.yaml entries and steps to reproduce:
light:
  - platform: limitlessled
    bridges:
      - host: <IP_ADDRESS>
        groups:
        - number: 1
          type: rgbww
          name: Decke
        - number: 2
          type: rgbww
          name: Couch
        - number: 3
          type: rgbww
          name: Schreibtisch
        - number: 4
          type: rgbww
          name: Tisch
        - number: 1

Set bulb to any RGB color
Try to switch to a warm white/cold white

Traceback (if applicable):

Jul 21 12:03:44 hassbian hass[738]: 2017-07-21 12:03:44 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: service=turn_on, domain=light, service_data=entity_id=light.schreibtisch, color_temp=252, service_call_id=1977592784-243>
Jul 21 12:03:44 hassbian hass[738]: 2017-07-21 12:03:44 INFO (Thread-19) [limitlessled.pipeline] Starting a new pipeline on group 3 (Schreibtisch) @ <IP_ADDRESS>
Jul 21 12:03:44 hassbian hass[738]: 2017-07-21 12:03:44 INFO (Thread-19) [limitlessled.pipeline]  -> Running stage 'transition(0, color=Color(R=255, G=2, B=157), brightness=1.0)' on group 3 (Schreibtisch) @ <IP_ADDRESS>
Jul 21 12:03:44 hassbian hass[738]: 2017-07-21 12:03:44 INFO (MainThread) [homeassistant.core] Bus:Handling <Event state_changed[L]: new_state=<state light.schreibtisch=on; rgb_color=(255, 2, 157), min_mireds=154, color_temp=252, friendly_name=Schreibtisch, max_mireds=500, brightness=255, supported_features=63 @ 2017-07-21T14:02:41.436799+02:00>, entity_id=light.schreibtisch, old_state=<state light.schreibtisch=on; rgb_color=(255, 2, 157), min_mireds=154, color_temp=359, friendly_name=Schreibtisch, max_mireds=500, brightness=255, supported_features=63 @ 2017-07-21T14:02:41.436799+02:00>>
Jul 21 12:03:44 hassbian hass[738]: 2017-07-21 12:03:44 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=1977592784-243>
Jul 21 12:03:45 hassbian hass[738]: 2017-07-21 12:03:45 INFO (Thread-19) [limitlessled.pipeline] Finished pipeline on group 3 (Schreibtisch) @ <IP_ADDRESS>
Jul 21 12:03:49 hassbian hass[738]: 2017-07-21 12:03:49 INFO (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: service=turn_on, domain=light, service_data=entity_id=light.schreibtisch, color_temp=382, service_call_id=1977592784-244>
Jul 21 12:03:49 hassbian hass[738]: 2017-07-21 12:03:49 INFO (Thread-19) [limitlessled.pipeline] Starting a new pipeline on group 3 (Schreibtisch) @ <IP_ADDRESS>
Jul 21 12:03:49 hassbian hass[738]: 2017-07-21 12:03:49 INFO (MainThread) [homeassistant.core] Bus:Handling <Event state_changed[L]: new_state=<state light.schreibtisch=on; rgb_color=(255, 2, 157), min_mireds=154, color_temp=382, friendly_name=Schreibtisch, max_mireds=500, brightness=255, supported_features=63 @ 2017-07-21T14:02:41.436799+02:00>, entity_id=light.schreibtisch, old_state=<state light.schreibtisch=on; rgb_color=(255, 2, 157), min_mireds=154, color_temp=252, friendly_name=Schreibtisch, max_mireds=500, brightness=255, supported_features=63 @ 2017-07-21T14:02:41.436799+02:00>>
Jul 21 12:03:49 hassbian hass[738]: 2017-07-21 12:03:49 INFO (Thread-19) [limitlessled.pipeline]  -> Running stage 'transition(0, color=Color(R=255, G=2, B=157), brightness=1.0)' on group 3 (Schreibtisch) @ <IP_ADDRESS>
Jul 21 12:03:49 hassbian hass[738]: 2017-07-21 12:03:49 INFO (MainThread) [homeassistant.core] Bus:Handling <Event service_executed[L]: service_call_id=1977592784-244>
Jul 21 12:03:50 hassbian hass[738]: 2017-07-21 12:03:50 INFO (Thread-19) [limitlessled.pipeline] Finished pipeline on group 3 (Schreibtisch) @ <IP_ADDRESS>

Additional info:

I opened without realizing a duplicate: https://github.com/home-assistant/home-assistant/issues/9107. There is some extra information to be found.

@PheiPheiPhei
One quick fix that i found it's to insert in ˜/homeassistant/components/light/limitlessled.py after line 350 the following: self._color = WHITE (check the indent to be the same as line 350).
This has the following effect: As soon as you set the color_temp to a valid value, the color will default to white:
light.living_room_table_light:
  state: on
  brightness: 255
  #color_name: white -> not needed anymore / has to be removed
  color_temp: 154

@happyleavesaoc - FYI

I don't have an rgbww bulb to test this fix with. I could see if it has adverse effects on the v5 bridge though.

this should only affect rgbww -  but the transition is not smooth when changing from a RGB color like before 0.49. There where some fundamental changes in that release that don't agree much with v6 - especially with transitions.

@balloob
Nope :) a new release won't fix this. A suggestion for the fix can be found in the upper comment.


Feature: Task scheduling, e.g. Druid cluster refresh

Adds a task scheduling system using crontab expressions:

Tasks are configured using JSON, the specific task is determined by type and are implemented in tasklist.py
Tasks can be edited/removed whenever
Tasks run in the background and automatically restart with Superset
E.g. a crontab expression of 30 * * * * will run on the 30th minute of each hour

Currently implements druid_cluster_refresh task which will periodically refresh specified Druid Clusters. Task will force refresh by default or simply scan for new datasources if refresh_all=false.
Also adds more control over Druid refreshing in the UI:

Coverage increased (+0.8%) to 70.989% when pulling b189984dd5bcf7fa42027e8958007e44537fa3ac on Mogball:mogball/feature/task_manager into 064363df78da2a490a297b91fb07dd5c095548b7 on apache:master.

Notice: this issue has been closed because it has been inactive for 201 days. Feel free to comment and request for this issue to be reopened.


Setup nhs theme

Merge Setup nhs theme into master

Hey @dsayce !
This looks really interesting, could you add more detail on what you're proposing to add to the prototype kit?
Looking at your changes I'm not sure we can merge this like it is since it
a) is a really big change
b) overrides defaults that are used by people working on GOV.UK Services.
Would love to hear what you'd need to make this possible without setting defaults specific to NHS.
Then it'd be good to break this down into smaller changes that can be reviewed properly.
What do you think?
Nick

it's possibly a PR intended for the fork here: https://github.com/infinityworks/nhsd-govuk-prototype-kit

@davesayce is this pull request made to the correct repo?

Sorry guys!
Yes, i've put the pull request to the wrong master
Will close that


Workflow graphs

Hi,
Is it possible to run pipeline preprocessing without having to create workflow graphs? I am constantly getting an error generating the workflow graphs using nipype.
Thank you!

I will look into it, but this Warning, while unsightly, can be safely ignored.


SimpleConsoleCommandSender.java:106: Implement...

The puzzle 1-6df509b8 from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/24d02de4e698c2d724c0a733186145a34d4b3621/src/main/java/net/shiruka/shiruka/command/SimpleConsoleCommandSender.java#L106-L106
The puzzle was created by Hasan Demirtaş on 01-Feb-21.
Estimate: 10 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-6df509b8 has disappeared from the source code, that's why I closed this issue.


cid mismatch - attachement

Hi,
First, thanks for you great & useful project,
I'm having some issues with some emails that have CID mismatch in the attahchment versus the HTML content, for ex:

HTML will show
ATTACHMENT getContentId() will show<EMAIL_ADDRESS>The issue is that I cannot update the HTML with the updated attachement url because I have no way to knowing what html part to update like this:
str_replace("cid:".$attachment->content_id, 'URL HERE', $content_html);

any ideas what I'm doing wrong?
Thanks,

Sorry, sounds like a generic php question (please post to stackoverflow.com) and not related to issues using mail-mime-parser.
Feel free to reopen if there's a bug or issue though.
All the best


Updates for dotnet6 and Azure Functions Runtime 4

Also updated the Functions Bindings versions for Event Hubs / Cosmos


PackageId:CPython39.Exe.x64;PackageAction:Install;ReturnCode:1638;

This issue has been moved from a ticket on Developer Community.

[regression]
Describe your issue here
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64;PackageAction:Install;ReturnCode:1638;

Original Comments
Feedback Bot on 9/1/2022, 08:07 PM:
(private comment, text removed)

Original Solutions
(no solutions)

Hi there, looking at the logs, the cpython is failing to install because another version of this product is already installed. Could you check your C:\Program Files (x86)\Microsoft Visual Studio\Shared and see if Python39_64 is installed already? If so, use Add/Remove Programs on the Control Panel to reinstall it, then reopen vs installer to repair vs. Please let us know if that doesn't work. Thanks! 😊

Going to close this out. If the issue still persists, please reopen with the information requested. Thanks.😊


Use ShelleyNTC for version check in node queries

Changelog
- description: |
    Use ShelleyNTC for version check in node queries
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context
Fixes https://github.com/input-output-hk/cardano-api/issues/391
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated. See Running tests for more details
[ ] Self-reviewed the diff

Thanks @amesgen ! I think I prefer to rely on the consensus change and your assumption:
In order to reduce the number of possible version combinations, we currently follow the convention that all `ShelleyNodeToClientVersion`s in one `CardanoNodeToClientVersionX` are equal.

this way we can just use NodeToClientVersion and avoid introducing redundant code.
@Jimbo4350 thoughts?

Closing because of: https://github.com/IntersectMBO/cardano-api/pull/403#issuecomment-1880960379


Remove ugly spacing

See haml/haml#894

Just nitpick, I suppose this is "pretty" spacing. This spaces exist only in pretty mode and the removed result is ugly mode.

Good point. I amended the commit & issue title.


Formatter not able to process this code

Hello @hilkoc
The format function is not able to process the code below:
Sub SplitNotes( _
    ByVal NotesStr As String, _
    ByVal IDStr As String, _
    ByRef Notes() As String, _
    ByRef TaskLocal As TaskType)

    Dim tmpArray() As Variant
    Dim tmpID() As Variant
    Dim tmpNote() As String
    Dim a As Integer
    Dim b As Integer
    Dim arrayMax As Long
    Dim IDMax As Long
    Dim counter As Long
    Dim tblNotes As ListObject
    Dim clNotes As ListColumns
    Dim rowNote As ListRow
    Dim found As Boolean

    Set tblNotes = Sheets("InternalConfig").ListObjects("TblNotes")
    Set clNotes = tblNotes.ListColumns

    tmpArray = SplitBase1(NotesStr, "]")
    tmpID = SplitBase1(IDStr, Chr(10))

    If IsArrayAllocated(tmpArray) Then
        arrayMax = UBound(tmpArray)
        If tmpArray(arrayMax) = "" Then arrayMax = arrayMax - 1
    Else
        arrayMax = 0
    End If

    If IsArrayAllocated(tmpID) Then
        IDMax = UBound(tmpID)
    Else
        IDMax = 0
    End If

    If IDMax < arrayMax Then
        ReDim Preserve tmpID(1 To arrayMax)
        tmpID(arrayMax) = ""
    End If

    ReDim Notes(1 To 3, 1 To (arrayMax + tblNotes.ListRows.Count))

    'add note to TODOist and/or properly format
    For a = 1 To arrayMax
        tmpNote = FormatNote(tmpArray(a), tmpID(a), TaskLocal)
        Notes(1, a) = tmpNote(1) 'id
        Notes(2, a) = tmpNote(2) 'date
        Notes(3, a) = tmpNote(3) 'note
    Next

    'include notes in local table not yet in the array
    counter = arrayMax
    For Each rowNote In tblNotes.ListRows
        'check if note belongs to task
        If rowNote.Range(clNotes.Item("item_id").Index) = TaskLocal.ID Then
            found = False

            'check initial range if note was not already included
            a = 1
            Do While a <= arrayMax
                If rowNote.Range(clNotes.Item("id").Index) = Notes(1, a) Then
                    found = True
                    'check if note was deleted in TODOist
                    If rowNote.Range(clNotes.Item("is_deleted").Index) = "1" Or _
                        rowNote.Range(clNotes.Item("is_archived").Index) = "1" Then
                        'delete
                        If a < arrayMax Then 'not in the end of the array
                            For b = a + 1 To arrayMax
                                Notes(1, b - 1) = Notes(1, b)
                                Notes(2, b - 1) = Notes(2, b)
                                Notes(3, b - 1) = Notes(3, b)
                            Next
                        End If
                        arrayMax = arrayMax - 1
                        counter = counter - 1
                    End If
                    Exit Do
                End If
                a = a + 1
            Loop
            'if not found and not deleted
            If Not found And _
                rowNote.Range(clNotes.Item("is_deleted").Index) = "0" And _
                rowNote.Range(clNotes.Item("is_archived").Index) = "0" Then
                'add
                counter = counter + 1
                Notes(1, counter) = rowNote.Range(clNotes.Item("id").Index)
                Notes(2, counter) = Format(DateConv(rowNote.Range(clNotes.Item("posted").Index)), "yyyy-mm-dd")
                Notes(3, counter) = rowNote.Range(clNotes.Item("content").Index)
            End If
        End If
    Next

    If counter > 0 Then
        If counter <> UBound(Notes, 2) Then ReDim Preserve Notes(1 To 3, 1 To counter)
    Else
        ReDim Notes(0, 0)
    End If

End Sub

From what I see, it's trying to align the "Exit Do" at the same indent as the "Do While", making the "Loop" to have the indent reduced. It is throwing the error below:
Error while formatting Module1
9 Subscript out of range
 on line 105: End Sub
indentLevel: -1 , levelChange: -1

Best regards,
Mauricio

The issue is caused by having a comment at the end of an If ... Then statement. In particular, this line:
If a < arrayMax Then 'not in the end of the array

Removing the comment will mean that the module correctly indents.
The error is caused by the isOneLineIfStatemt function thinking the line is a "one line if statement" because it doesn't end with Then. I think any trailing comments need to be stripped off the line before checking it's syntax and then added back.

Nice catch! I moved the comment to the next line, and worked like a charm.
Thanks!


Resolve Webpack deprecation warning for loaderUtils.parseQuery()

Seeing the following deprecation warning after updating to the latest version of Next beta. Can anyone else confirm?
DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.

We fixed it. I hope it's coming from a other plugin using it.
Need to investigate.

@arunoda noob here, what is the fix exactly? Can you link me to it?

@arunoda The error comes from<EMAIL_ADDRESS>#391. Already corrected but are still in alpha v7.0.0-alpha.1

Thanks @aranajhonny .
Frankly, there's nothing we can about this until babel released v7.0.0

Even though I install this version, and it still shows me the same warning. we will wait.

I just upgraded to next.js 2 official and am still getting this error:

I tried wiping and reinstalling node_modules, but no luck.
I am using yarn instead of npm if that matters.

@trevordmiller this is not an error.
It's a warning emit by babel-loader.
It's fixed with babel-loader 7. But we can't use that because still it's beta.


dbinteract.py changes

create a function that takes in input guild_id and deletes all deadlines relating to that database
create a function which creates a table that stores guild_id with the timezone difference in minutes. default to +330min(5hrs30min)

I would like to resolve this issue.


Improve JSON output

Pull Request Test Coverage Report for Build 60

0 of 71 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.4%) to 9.948%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

conntrack/conntrack.go
0
71
0.0%

Files with Coverage Reduction
New Missed Lines
%

conntrack/conntrack.go
1
0.0%

Totals

Change from base Build 55:
-1.4%

Covered Lines:
38

Relevant Lines:
382

💛  - Coveralls

Pull Request Test Coverage Report for Build 58

0 of 71 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.4%) to 9.948%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

conntrack/conntrack.go
0
71
0.0%

Files with Coverage Reduction
New Missed Lines
%

conntrack/conntrack.go
1
0.0%

Totals

Change from base Build 55:
-1.4%

Covered Lines:
38

Relevant Lines:
382

💛  - Coveralls


refactor from custom tags > 'topics'

https://github.com/blog/2309-introducing-topics

this'll resolve #16

time to get moving.  github isn't hiding our custom tags anymore.


Add metadata options to the import and delete CLI commands

This PR adds options to set the lineage, updating person, and reason for update for the import and delete CLI commands. For import, additional options have been added to set the creation date mode and termination date mode.

Thanks @clausnagel. Nice enhancement of the CLI interface. I have only one remark: The importCityDBMetadata is missing the MetadataOption of the import operation. Would be good to also include it.

I added a --use-metadata-from-file flag. If set, the values for lineage, updating person and reason for update from the input file take precedence over the values provided through the --lineage, --updating-person, and --reason-for-update options. Note that this does not affect creationDate and terminationDate, because they have their own individual modes.


Run 'unit_grpc_gcp' tests only with Python 2.7 / 3.6.

why 3.6 instead of 3.7?

Those are the same versions for which we run system tests.  3.6 is the system python3 on current LTS Linux releases.


Capture an image from canvas

Hi. I have a problem with capturing image in canvas. I used this method below but my problem is that it causes an error (Cannot read property toDataURL is undefined). I don't know what is wrong because my player works fine.
<script type = "text/javascript"> 	var canvas = document.getElementById('video');       	var ws = new WebSocket("ws://<IP_ADDRESS>:9999")       	var url = "ws://<IP_ADDRESS>:9999";       	var player = new JSMpeg.Player(url, {canvas: canvas, autoplay:true,audio:false,loop: true});         function captureFix(){ 		var img = document.createElement('img'); 		img.src = player.canvas.toDataURL('image/webp', 0.7) 		var capImage = document.getElementById("capImage"); 		capImage.src = img.src;         } </script>

The preserveDrawingBuffer option has to be enabled for canvas.toDataURL() to work
https://github.com/phoboslab/jsmpeg/blob/master/README.md#usage

Like this one? I tried below but error still persists

There is no player.canvas property anymore. You can access the canvas element through player.renderer.canvas, though this is undocumented and may change.
The preferred way to do this is to use your own reference to the canvas element. Since you do var canvas = document.getElementById('video'); (and later hand that canvas over to jsmpeg) you can just call img.src = canvas.toDataURL('image/webp', 0.7).


Added David J Harding to contributors

(btw, the "Request Changes" is temporary here... will keep this open until we can go through a contribution nomination)

Nomination thread here: https://github.com/covidgreen/covid-green-app/issues/19


GetSubscription API added to subscriptionserver

Codecov Report

Merging #385 (11f65fc) into master (e71f2f5) will decrease coverage by 2.38%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   58.63%   56.25%   -2.39%
==========================================
  Files         124      124
  Lines        6743     6751       +8
==========================================
- Hits         3954     3798     -156
- Misses       2442     2623     +181
+ Partials      347      330      -17

Flag
Coverage Δ

integration
?

unittests
56.25% <75.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

service/web/server.go
88.00% <0.00%> (-3.67%)
:arrow_down:

service/web/subscriberserver.go
66.42% <100.00%> (+1.50%)
:arrow_up:

pkg/messagebroker/kafka.go
18.51% <0.00%> (-35.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71f2f5...11f65fc. Read the comment docs.

@sumitkrzp LGTM. Let's merge this to master.


Bug: SAS_USERNAME and SAS_PASSWORD not found

I have previously authorized my target "COSA" with https://sas.4gl.io but receive the following message when running a test program
jeremy@LAPTOP-43CAINGU:/mnt/c/Users/jerem/projects/cosa_poc$ sasjs run aaaaa.sas -t COSA
ℹ Target COSA was found in your local sasjsconfig.json file.                                                                                18:10:54

 ERROR  An error has occurred when running your SAS code.                                                                                18:10:55
 The following attributes were not found:
* SAS_USERNAME
* SAS_PASSWORD
Please run "sasjs auth" for your specified target to apply the correct credentials.

I think it might also also causing my react-seed-app to get stuck at the login screen, checking web console shows the following when clicking 'LOGIN'
sasContext.tsx:138

       TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at t.eval (AuthManager.ts:212:13)
    at eval (writeStream.ts:10:20)
    at Object.eval [as next] (writeStream.ts:10:20)
    at a (writeStream.ts:10:20)

Hi @TeMeta - thanks for raising
We are able to reproduce the sasjs run bug for SASJS serverType.  It's also a problem in the VS Code extension - we'll fix it asap
The login issue though should not be related, we will confirm that though and get back to you

@TeMeta - should be fixed now, are you able to confirm?


--project-dir flag name

Preview > v1.4
What are you changing in this pull request and why?
Thank you to @aBBDnGus for noticing and mentioning within https://github.com/dbt-labs/dbt-core/issues/7445 that this should be --project-dir instead of --profiles-dir:

Checklist

[x] Review the Content style guide and About versioning so my content adheres to these guidelines.

wanted to double-check whether this page should be updated to --project-dir as well?

That other page looks correct as-is, so no PR needed, but smart to confirm! 👍

--profiles-dir: where to look for profiles.yml
--project-dir: where to look for dbt_project.yml

Easy to get them mixed up when typing them out!


[FR] - 1.13.1 tag for commit c17483d

External
Can we please have a Tag 1.13.1 or similar for the commit c17483d?

This was a master commit that worked with the HTN genesis and also had the functionality
to claim the rewards. This is currently not possible with the latest master branch.
Thx!!!

Tagged as 1.13.0-rewards


docs(ce/rate-limiting) fix-config-policy

made policy param semi-required
added example value
added explaination in description for semi-optional

Please refer Kong/kong#4965 for issues due to this.

The docs page for rate-limiting currently does not list policy in config in the examples which cause issues to people who are using the same declarative configuration file in DB-less mode.

@h3xar0n @levfishbluefish Can I please request your review on this? Thanks!

@kikito Can I please request your review on this?

@kikito I have made the requested changes.

@Kong/team-docs Core Team reviewed and approved — removing the "Core Team review" from this one! :+1:


bug: demo link in readme

the demo link provided in the readme don't work

Yup, thanks.
It was fixed :)


Change package naming

Package structure refers to the old project name (io.toolsplus.atlassian.connect.jwt.scala). With the name change to atlassian-jwt this should become io.toolsplus.atlassian.jwt.

Resolved by #5