react-router should re-export necessary functions from the history project

history is a great project, but if I want to use react-router, I find it surprising that I have to install it as well as a top-level dependency, when it's really just a dependency for react-router. I could understand it if I'm doing something really low-level and internal, but if all I want to do is use a browserHistory instead of hashHistory (which is probably one of the most common use cases) I have to suddenly deal with this other library.
I suggest that react-router should just re-export the few things necessary from history that users need, like createBrowserHistory.
How do you make sure that I have the right history version installed? It's now a peer dependency, essentially.
For example, I upgraded to<EMAIL_ADDRESS>and upgrade history to the latest version. But then I wanted to downgrade (for no reason of react-router, I was just debugging something). I removed react-router and re-installed 1.0.0-rc2. After I did this, I had two versions of history:

The top-level one is the more up-to-date one, and npm (rightly) installed the old one for react-router. As expected I got an obscure error when trying to run it.
Hiding the history project within react-router would avoid users having to manage two separate projects that are actually dependent.

I strongly agree with this.

Would it be awful to make it an actual peer dependency? React Router seems to me like a plugin to History, in the same way that various components are plugins to React.

@taion peer deps are deprecated and going to be removed at some point, if they aren't already. They are super confusing for similar reasons I stated above (even with npm trying to help).

Thanks for starting this discussion, @jlongster. I agree the current situation isn't ideal.
Maybe the easiest thing to do is
export * from 'history'

in our top-level exports. The way I see it, react-router is essentially an extension of the history package. A "router" is basically history + routes. So re-exporting everything from history gives us:

the ability to "hide" history inside react-router so users don't have to explicitly install it
the ability for us to pin react-router to a specific history version
all of the tools that history gives us. this is important so we don't have to create our own abstraction on top of the history API (which <Router> currently is, but hopefully we can move away from that)

The main downside to this is that our UMD build is going to be a lot bigger than it needs to be. I was originally thinking that, in order to make builds as small as possible we could recommend to people that they reach into the lib directory and only import the pieces of history/react-router that they need. I'd like to preserve the ability to do this for people who need smaller builds.
Thoughts?

@jlongster
Where did you see that? It's true that they don't get auto-installed any more on NPM3, so the install instructions would have to be npm i -S react-router history if History were made a peer dependency, but I haven't seen anything official saying that they're going away.
@mjackson
I think this is a little strange in the sense that, at least recently, History has been releasing much faster. Suppose someone adds createFancyNewHistory to History - how would you manage that if history were a dependency of react-router? It seems like in that case users would have to separately install history anyway.
Though for the UMD build, would it not be possible to specify history per se as an external, but use a history/lib import for the parts we want to bundle?

AFAIK peer deps is an on going discussion - https://github.com/npm/npm/issues/5080 (that may never end X-D)
I'm not sure this is a valid use case for peer deps, though.  The history dep is pinned to a specific version in package.json and in @jlongster's example, installing a version of history two patch versions away from react-router's version causes errors.  This is a pretty tight coupling and probably not appropriate for peer deps.
Regarding bundle sizes, would it be reasonable to start by just covering 80% of use cases by only providing createBrowser/Memory/HashHistory?  The re-exports could even be in separate files in modules so that they can be imported separately.
history may be releasing quickly, but are new history implementations being created that regularly?  If not, keeping up-to-date doesn't seem intractable.  Also, if having a different version installed at the top-level break things anyway (as it did for @jlongster and myself) then one doesn't have the option to use the newest history anyhow.
A related question: why is the history dep pinned?

@taion peer deps are deprecated and going to be removed at some point, if they aren't already.

This is misinformation that people keep spreading because peerDeps were bad in NPM 2 :-)
NPM 3 doesn't deprecate peer dependencies. It just changes their behavior to be warnings instead of hard errors, and that they don't cause automatic installs. But they stay. The point is that the developer is aware the peer dep is unmet, but isn't forced to correct the mistake. That's it:
From https://github.com/npm/npm/issues/6565#issuecomment-74971689:

To be clear, peerDependencies aren't going away.

Personally I think that:

history should be a peer dependency of react-router, with only major version specified (caret range)
history shouldn't break API :-)

This way router can depend on history API, but user may update history for patch fixes and new features.

I agree entirely with what @gaearon says above.
I think this is the most correct way to set things up. There's a small cost in forcing users on NPM3 to npm i history react-router, but I don't think that's material.

Hah, yes, following semver would certainly make this a reasonable use of peer deps. :joy: Agree that it's the best possible outcome.  Doable in practice?

Is History not currently follow semver?

Is History not currently follow semver?

Uh, I thought I was.
@jlongster @SpainTrain Is there some way I violated semver between history 1.12.1 and 1.12.3?
Sounds like this is the perfect use case for a peer dep.

Wow, English language fail. That was directed at @SpainTrain. I meant to assert that as far as I could tell, History was following semver just fine.
You know who would definitely disagree with this, though? @ljharb. Because unlike with React, it's also the case that nothing would actually break if there were two versions of history installed.

Apologies, I didn't mean to imply there wasn't good faith effort to follow semver, but whether it was effective in practice.  That's why I asked why the history dep was pinned, rather than a semver range.  Also thought that was the implication of the comment "history shouldn't break API :-)"
The issue I encountered would have been preventable with an up-to-date peer dep, so sharing the error I got is not useful.  @jlongster could you share the details of the obscure error you mentioned?  The diff looks fine, so maybe it's an edge case?

Ah, no need to apologize. It wouldn't be the first time I've been a semver bad guy :)

Oh, that is weird - why is the dependency pinned?

Because I'm scared I'll break my own library? I dunno.

RE: peer deps, @ljharb brought up an interesting point -
If you make<EMAIL_ADDRESS>a peer dependency of react-router, then you break the case where (suppose one day a<EMAIL_ADDRESS>comes out) a user wants to separately use<EMAIL_ADDRESS>but still wants to use react-router, but not pass in a hypothetical history object from the history v2 library.
I'm not convinced that this use case really matters, but it's an interesting point. ¯\_(ツ)_/¯

Sorry to spread misinformation about peer deps.
I still don't understand why history just isn't a normal dependency, when it clearly is... a dependency. If, for some reason, I want to directly use history it's not hard for me to install it manually like we're forced to do now. But I don't think users of react-router should have to think about it (maybe if using more esoteric features, I dunno).

The only stated benefit so far is that it's easy to keep UMD builds lean. I'm sure we could figure out a solution to that, and it seems like a very minor benefit for more hassle.

It is a dependency.
The problem is that just re-exporting a library that potentially changes under you seems prone to inconsistent behavior.
As long as history doesn't change its API, it seems like it'd be better to encourage the user to specify his or her version of history explicitly; compared to the re-export which gives you some mystery version of history that the user can't directly control.

It can't change under you. Any changes will dictate a new react-router version as well.
If you are calling history methods directly, you can simply install it yourself as we do now and hope that it works with the current version of react-router.
I may be viewing this differently. I'm honestly a naive outside user who just came here to use this library. To me I just want to install one project, read docs on one project, etc, and be done.

That's only the case if React Router pins the dependency on History to a specific version, no? If React Router specifies a version range, then all bets as to the actual installed version of History are off.
If you go with pinning the History dependency, then you end up having to release a new version of React Router every time you update History. At that point, why not just merge History back into React Router?
That last question isn't rhetorical, BTW. From the PoV of making things as easy as possible for users of React Router, it'd probably be easiest if History were just part of the library. Otherwise, I think the best compromise would be to make History a peer dependency, to allow separate versioning, without raising the question of "what about this instance of history that react-router depends on".

fwiw, keeping builds clean is the job of the consumer, not the publisher. browserify/webpack/et al all make this easy, and there's zero reason any publishing module be concerned about build size, or UMD at all, in 2015.

So, I had proposed exporting our own wrapper for createMemoryHistory this week: https://github.com/rackt/react-router/pull/2175#issuecomment-145953269
What if we did that an also exported createBrowserHistory and createHashHistory? They're the most common use cases for exporting history's API.

Thinking through this a bit, then, I think the way we'd handle re-exports from a semver POV would be to specify the version on history like 1.12.x or ~1.12.4, and bump the minor version on react-router every time we bump the minor version dependency on history.
Would that be acceptable? I still think the peer dependency solution is a bit cleaner, though.

I would go with the peer dependency solution. In my opinion main reasons is that it does not make sense to bump up the versions of both history and react-router. Especially that React Router can work without the History module.
Thinking a bit forward what if we add scroll module (for managing the scroll behaviour) in the future, or any other module? I think it won't be a good practice to change the version of the react-router every time any of those change.

I think it won't be a good practice to change the version of the react-router every time any of those change.

Of course it would. It's good practice to change the version every time anything changes, big or small, as frequently as is possible. Version numbers aren't sacred, and the appropriate major/minor/patch should be bumped aggressively.

Especially that React Router can work without the History module.

Is that really true? I mean, do we really ever expect people to use it without the history module, and re-implement everything that history does? This seems like a case of over-modularization.

@ljharb But those won't be the changes to react-router itself, but to the separate module(s).

@knowbody which should cause corresponding dep changes in react-router, and a corresponding version bump.

Especially that React Router can work without the History module.

Perhaps this is part of the problem? If it only worked without it, there'd be no issue - if you gave it something that wasn't a history object, it'd simply throw, and "optionalDependencies" or "peerDependencies" might help warn people at install time. If it only worked with it, it's a strict dependency. By doing both, this question comes up. In addition, history may want to provide a simple way of checking that a given instance was from the correct version, at runtime, so that consumers don't need to rely on questionable install-time checks.

If you re-export pieces of History in React Router, semver requires that minor bumps to History lead to minor bumps in React Router, because otherwise you'd be e.g. adding a new feature to ReactRouter.createBrowserHistory (via History.createBrowserHistory) without making a minor version bump.
I don't object to making these bumps per se, but it does mean that you'd need to release React Router more often than you otherwise would, i.e. whenever History has a minor version bump.
If we don't expect people to use React Router without also explicitly using a (compatible) version of History, then it seems like a peer dep would be the right way to go. In other words, if it weren't for the default hash history, I'd think that a peer dependency just would be the right way to go.

It's npm. Releasing a new version should be cheap and easy and frequent, and not something to be afraid of.

I think @ljharb got the point here. But I'm still not 100% sure that this is the best solution. I can just see ppl sending issues "hey I'm trying to do this in 1.0.27 and it doesn't work" and us wondering what has changed since.
Also what if someone wants to use their own implementation of history?

React Router can work without the History module

We're not very far from completely decoupling react-router from history, but we're not quite there yet. Places where we still depend on history:

We default to using hash history so users don't have to explicitly provide <Router history> if they don't want to. This is strictly for convenience.
<Link>s use their history object to pushState. We could possibly fix this dependency with a <Router onChange> prop that just calls pushState to update the URL.
<Link>s use their history object to create their href.
The History mixin puts the history object on component instances to make it easy for components to navigate around.

So, while I'm hopeful that at some point in the future we can completely decouple the router from the history package, we still actually do depend on it for the time being.

the appropriate major/minor/patch should be bumped aggressively

Agreed. I'm not scared at all of releasing new versions. Let's release as frequently as possible.

keeping builds clean is the job of the consumer, not the publisher

Agreed. I'm not terribly concerned about our UMD build size. Just said that it's a downside of re-exporting everything. Not a huge deal.
For now, this seems like the canonical use case for a peer dependency.

I just want to install one project, read docs on one project, etc, and be done

If we go the peer dep route, you'll have to install two projects. You ok w that @jlongster?

This seems like a case of over-modularization

There are a few reasons I extracted the history package out of the router. I realize that over-modularization is a real problem in large packages, but I don't think that's what's going on here.
Most importantly, history is a really useful library without react router. This isn't a case of creating one function per module. There are a myriad of routing experiments with redux, like routex that took advantage of the fact that history was a separate package to try something new. It's my hope that many other client-side routing libraries can take advantage of the capabilities of the history package as well.
Besides that, keeping history in a separate package helped us to focus in on solving several long-standing bugs and edge cases that easily get lost in discussions about higher-level concepts, like routing. If you check out the history issues, you'll see some interesting stuff that has nothing to do with routing.

@ljharb I dunno, NPM seems to think it's a pretty big deal, with how they've hardcoded the name "history" and all.
@mjackson How do you picture React Router working without History? Would it be some one-shot routing with actual hard page transitions and the browser itself doing the actual history management?

I just want to install one project, read docs on one project, etc, and be done

If we go the peer dep route, you'll have to install two projects. You ok w that @jlongster?

Well, the peer dep route was something I was hoping not to do for that reason. But I suppose it's better than the current situation, where history is installed behind-the-scenes but later when I want to do a very common task (use browserHistory) I need to retro-actively change how it's installed. It does seem better to do either/or.
A big part is advertisement. history isn't even mentioned in react-router's README, and if it's really meant to be more of an "addon" to history then I think the wording should be changed for the project. Right now it reads like a full-blown routing solution, so it's surprising to be thrown to history pretty quickly.
I think if my expectations were different I wouldn't have been as surprised, and now I understand it better but I think it would help to mention history more prominently.

Besides that, keeping history in a separate package helped us to focus in on solving several long-standing bugs and edge cases that easily get lost in discussions about higher-level concepts, like routing. If you check out the history issues, you'll see some interesting stuff that has nothing to do with routing.

Yeah, sorry for the strong statement, it's not really a case of over-modularization (there are obvious reasons why history is separate, it has a lot of non-react stuff), but I was talking more about over-worrying about react-router just re-exporting all of history. I understand the intentions of the projects better now.
If you're not going to make react-router just re-export everything and update versions every time history change (which I still don't see a problem with), I definitely think it'd be good to force history to be installed up-front as a peer dep.

You're not meaningfully changing how it's installed, though. Why does the built-in history even matter? It's an implementation detail of React Router.

You're not meaningfully changing how it's installed, though. Why does the built-in history even matter? It's an implementation detail of React Router.

Very confused, I don't really know what you mean. That it's an implementation detail is exactly how I feel about history and why it should be a normal dep.
But I don't really care that much. If it's a peer dep, that's ok, just make me install it up-front. Not going to spend a whole lot more time on this, I'll just follow whatever decisions the maintainers make,

What I mean is - whether or not the react-router package has a dependency on the history package should be irrelevant to you. It's just another dependency for NPM to manage.
But in some sense, how you manage history is orthogonal to how you do routing. Someone could make a my-awesome-history package that is API compatible with history, and it might be nice if it were possible to use that instead of using history. And the converse as well.
Is this really just more of a documentation/advertisement issue like you mention on https://github.com/rackt/react-router/issues/2211#issuecomment-147232777, where history isn't even mentioned in the README? Maybe it'd be better just to fix the README instead of enforcing history as a peer dep.

@taion Whether something is a normal dep or peer dep is a big difference, as seen in my original post. We do have to be aware of where things are installed, realistically, whether it's node_modules/history or node_modules/react-router/node_modules/history. Granted, I haven't upgraded to the latest npm yet and they may do things that make this better. But you still generally need to be aware of what's going on.
Updating the documentation would definitely be the biggest help, yeah. But I also thing that we should go peer deps full force if that's what we really are trying to do.

I do agree with @jlongster on the documentation part. @jlongster we will update the docs and clarify what React Router and History are and what role they are playing.

@jlongster
Now I don't understand. In general you shouldn't have to be aware of the direct dependencies of the libraries you install at all. Certainly it matters whether or not history is a peer dependency of react-router, but to someone installing the package, I don't see how there would be any direct observable difference between history being a dependency and history not being a dependency.
Although looking back at your initial example, you should be aware that the error you saw was most likely because the 1.0.0-rc2 release was broken due to an NPM bug. That's a separate issue - in general you should not "[get] an obscure error" by doing that sort of thing.

:+1: @ peer deps
Aside: something like http://greenkeeper.io/ would have caught/fixed the inadvertently pinned dep


read_probeinterface() does not read in device_channel_indices

Hello,
I got this problem when attempting to attach a probe read in using read_probeinterface(). Since I have only one probe, I first convert the read in probegroup to dataframe then instantiate a Probe object from dataframe. The .json file was able to retain the device indices I saved but the read in function didn't take this column in as it was not in the dataframe. Is there something I misunderstood and did wrong, or it was a glitch of the function?
Thanks,

Hi @ThetaS.
Can you share the piece of code to generate the probe + the dataframe + the json file ?

Thanks for the response and sorry for the delay! Sure, here are the code snippets:

This is the calling from my analysis code:

I'm working with the UCLA Masmanidis probes and had quite a hard to generate the probe map because they are checkerboard patterned and multi-shank. Hope I didn't miss any shortcuts and solutions for handling this problem.
Thank you very much.
ThetaS
128ANbottom_map.zip

128_ANbottom_map.csv
This is the CSV associated. Basically, the information from the Masmanidis lab's Matlab program and the wiring configuration to Intan 128 headstage.
Best

Hi,
You have device_channel_ids, in probeinterface it should device_channel_indices and it should be starting from 0.
So a zero-based index and not an "id" (identifier).
contact_id = id = str or int = zeros-based orone-based
device_channel_indices = index = zero-based in the python ecosystem

The plan axes is a bit more complicated. This is used internally for rotation. And so not so well documentated.
On this example : https://probeinterface.readthedocs.io/en/main/examples/ex_08_more_plotting_examples.html#sphx-glr-examples-ex-08-more-plotting-examples-py
you can see that some some probe are rotated. In that case you should inspect the plane_axes and you will understand how this is used.
By default, you should not use this plan_axes and everything should be OK and with no rotation.

Yes, I tried deleting the plane_axes parameter and the plotting works. But the previous question, I tried the keyword "device_channel_indices" and zero-based my indices and it failed to work.

The save part is the same as above, key modifications are shown in the images.

I think the problem is how you're setting the probe in SpikeInterface!
You need to use in_place=True if you want to modify an existing object. Otherwise the set_probe/probegroup will return a separate object (see here: https://spikeinterface.readthedocs.io/en/latest/modules/core.html#handling-probes)
Basically you can do:
data.set_probegroup(probe, group_mode="by_shank", in_place=True)
# or
daa_w_probe = data.set_probegroup(probe, group_mode="by_shank")
# then continue with data_w_probe


Feat: Settings Component

Updating settingscontainer component and debugging to render in browser

To do:

Add security to account management
Fix the MongoDB 'DuplicateKey' bug regarding the email in Edit Profile section


FEAT: generate JSON rendered docs

First step for generating rendered JSON documentation.

Codecov Report

Merging #19 (0eb1d72) into main (a1ca7da) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0eb1d72 differs from pull request most recent head b144f66. Consider uploading reports for the commit b144f66 to get more accurate results

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   96.87%   96.87%
=======================================
  Files           3        3
  Lines          64       64
=======================================
  Hits           62       62
  Misses          2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Feature request: Figma - Auto layout

Feature request:
Figma - Auto layout ➡ Unity - Horizontal/Vertical Layout Group

@glimyU This should now be implemented - let me know if this works as expected

@simonoliver yup it works! thanks!


AttributeError: partially initialized module 'logging' has no attribute 'getLogger' (most likely due to a circular import)

when I imports genesis,wrong is happen
AttributeError: partially initialized module 'logging' has no attribute 'getLogger' (most likely due to a circular import)
python=3.12.7
cu124 pytorh2.51

I met the same problem, too. It seems like installing from the repository code got some error.

Haha.ang I was not find way to use it
---Original---
From: "Ferry @.>
Date: Mon, Dec 30, 2024 14:46 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Genesis-Embodied-AI/Genesis] AttributeError: partiallyinitialized module 'logging' has no attribute 'getLogger' (most likely due toa circular import) (Issue #139)
I met the same problem, too. It seems like installing from the repository code got some error.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Add typescript support

Migration to typescript.
Seems like MSW does not export all the types we need so a Typescript workaround was necessary. @kettanaito care to give some assistance? <3
The way this is seems good to me too. It's not really necessary to export those types from msw, although it would be nice!
Closes #38

Hey, @yannbf. Thank you for these improvements! I've rebased the feature branch and pushed some minor changes. Please let me know if those align with your intention here.

Thanks a lot @kettanaito! I worked through your feedback and this is ready to be reviewed once again!


Remove Deprecated Eval Function

Removes eval(..., rootIndex) which was a wrapper for eval(..., *pool.root(0)).
Also fixes a minor issue when building without readline.

Nice 💯


Update de_de.json

Fixed german translation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The 2 "Symbole" should be also "Icons". Icons is a well used word for gamers meanwhile in germany too. I'm "throwing" the lang-file in the first way through deepl.com and afterwards i check the translation for typos or not to understand translations for a german. I overseen this two, sorry for that. You're absolutly right, that it has to be more consistent.
How can i correct this now?


WIP synchronize to base modeler

Synchronize to the latest Camunda Modeler stage (master#572a641) cf. c86564a
Add license header to all Zeebe related extensions cf. b9c1e66

Waiting for another release for final update 🚧

It seems that the importXML is broken after syncing (throwing out the namespace handling).

Can be closed since we decided to synchronize with the latest beta of Camunda Modeler.


[0.6.x] Wrong optimization of array_apply() on an Array[Array[Char]]

The following code crashes on the first isInstanceOf:
  def main(args: Array[String]): Unit = {
    import js.DynamicImplicits.truthValue

    val a = Array(Array('a'))
    val b = arrayGet(a, 0)
    assert(b.isInstanceOf[Array[Char]])
    val c = b.asInstanceOf[Array[Char]]
    val d = arrayGet(c, 0)
    assert(d.isInstanceOf[Char])
    assert(d == 'a')
  }

  @inline
  def arrayGet[A](a: Array[A], i: Int): Any = a(i)

a(i) is compiled down to ScalaRunTime.array_apply(a, i) because a is a polymorphic array. There's a wrong optimization of array_apply(a, i) in this case because a is an Array[Array[Char]]: the optimizer wants to box the Array[Char] it gets from a[i] into a java.lang.Character.
The problematic test is here. It is missing an && depth == 1.
The bug does not exist in 1.x obviously, because of cc56fe758fbd1e6505ba05494142eb89b159780e

Fixed in  a59e8e6.


🐛 [cloud_firestore] Fails to build for iOS on M1 (Apple Silicon) MacBook

Bug report
Describe the bug
Adding the latest version of cloud_firestore causes the build to fail on an Apple Silicon M1 MacBook
Steps to reproduce
Steps to reproduce the behavior:

Use an Apple M1 MacBook
Install latest stable flutter through git pull
Create a new project with flutter: flutter create firebase_demo
Build Success
Add cloud_firestore: ^0.14.3 to pubspec.yaml file
run flutter pub get
build and run

Expected behavior
Expected the build to pass and the app to run

Additional context
This is after connecting the project to Firebase through the Google_Info.plist
Output from flutter run
Launching lib/main.dart on iPhone 12 Pro Max in debug mode...
lib/main.dart:1
Xcode build done.                                           15.1s
Failed to build iOS app
Error output from Xcode build:
↳
    objc[4084]: Class AMSupportURLConnectionDelegate is implemented in both ?? (0x1fe9e67a0) and ?? (0x118aac2b8). One of the two will be used. Which one is undefined.
    objc[4084]: Class AMSupportURLSession is implemented in both ?? (0x1fe9e67f0) and ?? (0x118aac308). One of the two will be used. Which one is undefined.
    ** BUILD FAILED **
Xcode's output:
↳
    /Users/qubyt/Programming/Testing/firebase_demo/ios/Pods/gRPC-Core/src/core/ext/filters/client_channel/xds/xds_api.cc:37:10: fatal error: 'envoy/api/v2/cds.upb.h' file not found
    #include "envoy/api/v2/cds.upb.h"
             ^~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Constructing build description
Could not build the application for the simulator.
Error launching application on iPhone 12 Pro Max.
Exited (sigterm)

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.24.0-8.0.pre.313, on macOS 11.0.1 20B29 darwin-arm, locale en-US)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed
      instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
[!] Android Studio (not installed)
[✓] Connected device (1 available)

! Doctor found issues in 2 categories.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.12.0-50.0.dev
Flutter SDK 1.24.0-8.0.pre.313
firebase_demo 1.0.0+1

dependencies:
- cloud_firestore 0.14.3 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- cupertino_icons 1.0.1+1
- firebase_auth 0.18.3 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0-nullsafety.3 [collection]
- boolean_selector 2.1.0-nullsafety.3 [source_span string_scanner]
- characters 1.1.0-nullsafety.5
- charcode 1.2.0-nullsafety.3
- clock 1.1.0-nullsafety.3
- cloud_firestore_platform_interface 2.2.0 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.2.1 [flutter flutter_web_plugins http_parser meta firebase_core firebase_core_web cloud_firestore_platform_interface js]
- collection 1.15.0-nullsafety.5
- fake_async 1.2.0-nullsafety.3 [clock collection]
- firebase_auth_platform_interface 2.1.3 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core 0.5.2 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- intl 0.16.1 [path]
- js 0.6.3-nullsafety.3
- matcher 0.12.10-nullsafety.3 [stack_trace]
- meta 1.3.0-nullsafety.6
- path 1.8.0-nullsafety.3
- plugin_platform_interface 1.0.3 [meta]
- quiver 2.1.5 [matcher meta]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.4 [charcode collection path term_glyph]
- stack_trace 1.10.0-nullsafety.6 [path]
- stream_channel 2.1.0-nullsafety.3 [async]
- string_scanner 1.1.0-nullsafety.3 [charcode source_span]
- term_glyph 1.2.0-nullsafety.3
- test_api 0.2.19-nullsafety.6 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0-nullsafety.5 [collection]
- vector_math 2.1.0-nullsafety.5

@jchand99 Are you sure your not using the precompiled libraries in your Podfile? Referenced here: https://firebase.flutter.dev/docs/overview#improve-ios-build-times
If you are remove that line and let it build the framework libraries fresh for the M1 and it might work.

Hi @jchand99
Have you taken a look at Developing with Flutter on Apple Silicon? Are you sure this can't just be a pod issue?
Thank you

@slightfoot I was not using those precompiled binaries in the file so I don't that could be the issue.
@markusaksli-nc I looked at that and made sure I was running the correct flutter version (they recommend 1.22.4 I'm on 1.24.0) the page is kind of outdated though since it states that flutter can't launch to the simulator but it works for me when launching for the simulator without using the cloud_firestore package.
I have tried a few things to fix it all to no avail:

I fixed an issue with cocoa pods and ffi by running my terminal in rosetta 2 and re-installing cocoa pods as well as ffi (https://github.com/CocoaPods/CocoaPods/issues/10220) (https://stackoverflow.com/questions/64901180/running-cocoapods-on-apple-silicon-m1). This allowed me to run pod install in a native terminal like normal.
I tried removing the default configurations in the podfile and let cocoapods set their own configurations (https://stackoverflow.com/questions/26287103/cocoapods-warning-cocoapods-did-not-set-the-base-configuration-of-your-project)
I also tried running the code through Normal VSCode (through rosetta2) which I was not sure if it would do anything or not but tried it anyways to no avail.
Tried flutter clean at all the steps to make sure it was a clean environment and tried removing the Pods/ folder as well as Podfile.lock then running pod install again to see if that would fix it, but it did not.

I should also mention that I have basically zero Mac/iOS development experience and this is all new to me, so I apologize for any ignorance. :)

This isn't an issue with precompiled libraries, podfile seems completely default.
I don't have Apple Silicon on hand to check this yet so labeling just in case for now.

My app uses
cloud_firestore: ^0.14.3+1
and I managed to build and run my app on macbook air ARM, even on simulator it works.
Here are my dependencies, if it helps.
Dart SDK 2.12.0-76.0.dev
Flutter SDK 1.24.0-8.0.pre.374

dependencies:
- animated_text_kit 2.5.4 [flutter characters]
- apple_sign_in 0.1.0 [flutter]
- audioplayer 0.8.1 [flutter]
- audioplayers 0.15.1 [uuid path_provider flutter flutter_web_plugins]
- auto_size_text 2.1.0 [flutter]
- cached_network_image 2.3.3 [flutter flutter_cache_manager octo_image]
- catex 0.0.1+6 [flutter meta]
- charts_flutter 0.9.0 [charts_common collection flutter intl logging meta]
- cloud_firestore 0.14.3+1 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- confetti 0.5.4+1 [flutter random_color vector_math]
- country_code_picker 1.4.0 [flutter]
- cupertino_icons 1.0.1+1
- date_utils 0.1.0+3 [intl]
- dio 3.0.10 [http_parser path]
- fading_edge_scrollview 1.1.4 [flutter]
- firebase_analytics 6.2.0 [meta flutter firebase_core firebase_analytics_web firebase_analytics_platform_interface]
- firebase_auth 0.18.3+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.5.2+1 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_crashlytics 0.2.3+1 [flutter stack_trace firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface]
- firebase_dynamic_links 0.6.2 [flutter firebase_core]
- firebase_messaging 8.0.0-dev.9 [meta flutter firebase_core firebase_core_platform_interface firebase_messaging_platform_interface]
- firebase_performance 0.4.2 [flutter firebase_core]
- firebase_remote_config 0.4.2 [flutter firebase_core]
- firebase_storage 5.1.0 [flutter firebase_core firebase_core_platform_interface firebase_storage_web firebase_storage_platform_interface quiver]
- fl_chart 0.12.0 [flutter path_drawing equatable]
- flare_flutter 2.0.6 [flutter flare_dart meta]
- flushbar 1.10.4 [flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_dialogflow 0.1.3 [flutter http googleapis_auth]
- flutter_linkify 4.0.2 [flutter linkify]
- flutter_local_notifications 1.5.0+1 [flutter platform flutter_local_notifications_platform_interface]
- flutter_ringtone_player 2.0.0 [flutter]
- flutter_spinkit 4.1.2+1 [flutter]
- fluttertoast 3.1.3 [flutter]
- font_awesome_flutter 8.10.0 [flutter]
- google_sign_in 4.5.6 [google_sign_in_platform_interface flutter meta google_sign_in_web]
- highlighter_coachmark 0.0.3 [flutter]
- http 0.12.2 [http_parser path pedantic]
- image_cropper 1.3.1 [flutter]
- image_picker 0.6.7+14 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- joniPlugins 1.0.0+1 [flutter cupertino_icons sqflite skeleton_text webview_flutter]
- launch_review 2.0.0 [flutter]
- material_design_icons_flutter 4.0.5755 [flutter]
- package_info 0.4.3+2 [flutter]
- path 1.8.0-nullsafety.3
- percent_indicator 2.1.8 [flutter]
- permission_handler 4.4.0+hotfix.4 [flutter meta permission_handler_platform_interface]
- photo_view 0.10.3 [flutter]
- provider 3.1.0 [flutter]
- purchases_flutter 1.1.1 [flutter]
- record_mp3 2.1.0 [flutter]
- shared_preferences 0.5.12+4 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web shared_preferences_windows]
- skeleton_text 1.0.0 [flutter]
- smooth_star_rating 1.1.1 [flutter]
- social_share 2.0.5 [flutter path_provider]
- sqflite 1.3.2+1 [flutter sqflite_common path]
- transparent_image 1.0.0
- url_launcher 5.7.10 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos url_launcher_windows]
- video_player 1.0.1 [meta video_player_platform_interface video_player_web flutter]
- webview_flutter 1.0.7 [flutter]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0-nullsafety.3 [collection]
- boolean_selector 2.1.0-nullsafety.3 [source_span string_scanner]
- characters 1.1.0-nullsafety.5
- charcode 1.2.0-nullsafety.3
- charts_common 0.9.0 [collection intl logging meta vector_math]
- clock 1.1.0-nullsafety.3
- cloud_firestore_platform_interface 2.2.0 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.2.1+1 [flutter flutter_web_plugins http_parser meta firebase_core firebase_core_web cloud_firestore_platform_interface js]
- collection 1.15.0-nullsafety.5
- convert 2.1.1 [charcode typed_data]
- crypto 2.1.5 [collection convert typed_data]
- equatable 1.2.5 [collection meta]
- fake_async 1.2.0-nullsafety.3 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- firebase 7.3.2 [http http_parser js]
- firebase_analytics_platform_interface 1.0.3 [flutter meta]
- firebase_analytics_web 0.1.1 [flutter flutter_web_plugins firebase firebase_analytics_platform_interface meta]
- firebase_auth_platform_interface 2.1.3 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2+1 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core_platform_interface 2.1.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1+1 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- firebase_crashlytics_platform_interface 1.1.3 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_messaging_platform_interface 1.0.0-dev.6 [flutter meta firebase_core plugin_platform_interface]
- firebase_storage_platform_interface 1.0.1 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_storage_web 0.1.1 [async crypto firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flare_dart 2.3.4
- flutter_blurhash 0.5.0 [flutter meta]
- flutter_cache_manager 2.0.0 [flutter path_provider uuid http path sqflite pedantic clock file rxdart]
- flutter_local_notifications_platform_interface 1.0.1 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- google_sign_in_platform_interface 1.1.2 [flutter meta quiver]
- google_sign_in_web 0.9.2 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- googleapis_auth 0.2.12 [crypto http]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.1 [flutter meta http plugin_platform_interface]
- intl 0.16.1 [path]
- js 0.6.3-nullsafety.3
- linkify 3.0.0
- logging 0.11.4
- matcher 0.12.10-nullsafety.3 [stack_trace]
- meta 1.3.0-nullsafety.6
- octo_image 0.3.0 [flutter flutter_blurhash]
- path_drawing 0.4.1+1 [vector_math meta path_parsing flutter]
- path_parsing 0.1.4 [vector_math meta]
- path_provider 1.6.24 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+6 [flutter]
- path_provider_platform_interface 1.0.4 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+3 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.9.2 [meta]
- permission_handler_platform_interface 1.0.0 [flutter meta plugin_platform_interface]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- process 3.0.13 [file intl meta path platform]
- quiver 2.1.5 [matcher meta]
- random_color 1.0.5 [flutter]
- rxdart 0.24.1
- shared_preferences_linux 0.0.2+4 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 0.0.1+11 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 1.0.4 [meta flutter]
- shared_preferences_web 0.1.2+7 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 0.0.1+3 [shared_preferences_platform_interface flutter ffi file meta path path_provider_platform_interface path_provider_windows]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.4 [charcode collection path term_glyph]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.6 [path]
- stream_channel 2.1.0-nullsafety.3 [async]
- string_scanner 1.1.0-nullsafety.3 [charcode source_span]
- synchronized 2.2.0+2
- term_glyph 1.2.0-nullsafety.3
- test_api 0.2.19-nullsafety.6 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0-nullsafety.5 [collection]
- url_launcher_linux 0.0.1+4 [flutter]
- url_launcher_macos 0.0.1+9 [flutter]
- url_launcher_platform_interface 1.0.9 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.5+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- url_launcher_windows 0.0.1+3 [flutter]
- uuid 2.2.2 [crypto convert]
- vector_math 2.1.0-nullsafety.5
- video_player_platform_interface 2.2.0 [flutter meta]
- video_player_web 0.1.4+1 [flutter flutter_web_plugins meta video_player_platform_interface]
- win32 1.7.4 [ffi]
- xdg_directories 0.1.2 [meta path process]

@joniaiuser I can confirm, using version cloud_firestore: ^0.14.3+1 does indeed deploy to the simulator at the very least. Didn't get time to test on physical device but I'm assuming it will work for now. If it doesn't I will update.
Thank you.

I had difficulty compiling in debug mode on an actual device. The app always seem to crash at the end. However release mode works, so I'm dismissing it as one of Flutter's issues with the new ARM devices. Hopefully these will be resolved in due time. ◡̈ Don't think it's associated with cloud_firestore specifically.

I see, I just built the template flutter project that only contains the cloud_firestore package and everything works fine after the app has been trusted.

Based on the last few comments here and the fact that I can build and run the official cloud_firestore example with ^0.14.4 on both simulator and physical on both the latest master 1.26.0-2.0.pre.103 and latest stable 1.22.5 I'm going to close this as solved.

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-2.0.pre.103, on macOS 11.0.1 20B29 darwin-arm, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.103 at /Users/nevercode/development/flutter_master
    • Framework revision 32741c0ec8 (7 hours ago), 2020-12-21 18:34:02 -0600
    • Engine revision af6889a600
    • Dart version 2.12.0 (build 2.12.0-169.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Users/nevercode/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/nevercode/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Connected device (3 available)
    • Nevercode’s iPhone (mobile) • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 14.3
    • iPhone 12 Pro Max (mobile)  • 09D9E93F-A98D-4735-B6E6-6E57F9CD01D8     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • Chrome (web)                • chrome                                   • web-javascript • Google Chrome 87.0.4280.88

• No issues found!


feat: Export layer API for language binding

For now, we already exported layers for Python since #1591. I think we should export layer for other language bindings

[ ] c
[ ] cpp
[ ] dotnet
[ ] go
[ ] haskell
[ ] java
[ ] lua
[ ] nodejs
[ ] ocaml
[ ] php
[x] python
[ ] ruby
[ ] swift
[ ] zig

Please discuss one by one. It's not an actionable task to export layers one by one.


How to (correctly) get an access token with "aud" claim set to AAD app registration's ClientId?

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.15.0
Wrapper Library
Not Applicable
Wrapper Library Version
.
Description
The scenario is the simplest ever:

Azure Function App acting as an API and protected by EasyAuth module.
Client-side JavaScript SPA, that only wants to call that API. To uderscore: it doesn't need to call MS Graph or anything else, just its own backend - it is that simple.

To make that work I need an access token, that has my-client-id set as an audience, where my-client-id is a GUID and nothing else. I need it to be like that, because a) this is how EasyAuth Express setup always worked - default audience value was always set to relevant ClientId and b) my app is already deployed en-masse across the globe, I can't afford breaking those deployments (all using their own AAD app registrations) with a new version that now uses MSAL.js v2 and c) this basic scenario was supported like that by adal.js, msal.js v1 etc. ever since.
I could instead use the id_token, but for some reason this approach is not recommended (why?).
After tons of experiments, I managed to get a proper access token by setting scopes = ['my-client-id/.default'] :

Question: did I get it right?
Is this the recommended approach? If yes, is it documented somewhere?
Is there a code sample, that illustrates this exact flow (digged through the entire repo and all the docs and failed to find any - all samples concentrate on calling MS Graph/other external APIs)?
MSAL Configuration
No response
Relevant Code Snippets
const tokenRequest = {
    scopes: [`2437fdc6-a893-42b9-adf8-4b807b8e3515/.default`],
};

Identity Provider
Azure AD / MSA
Source
Internal (Microsoft)

@scale-tone The way to do this is to expose an API on your app registration and request this custom scope when acquiring a token using MSAL. This tutorial walks you through the process of exposing an API on your app registration.

Thanks @tnorling , but as I was trying to explain, this is not an option.
I do not have control over those hundreds of AAD app registrations out there and I do not have an option to drop backward compatibility. I can't just break all those deployments with a new version and then say 'hey, you now need to add custom scopes to your AAD app'.
Do you have any better ideas?

@scale-tone How are the existing apps working today? What scopes are they requesting?

@tnorling , as I was trying to explain, with adal.js and msal.js v1 people have always just put AAD app registration's ClientId (plain GUID) as a requested scope. This matched well EasyAuth Express settings. And always resulted in an access token containing that ClientId in its aud claim.
To underscore again, there're billions of existing AAD app registrations out there, that do not have any custom scopes defined. It would be very customer-unfriendly to break all of these.

@scale-tone In Adal.js and Msal.js v1 requesting clientId as scope results in an idToken not an accessToken. Msal.js v1 API may return the token in the accessToken field but if you crack it open (using jwt.ms or other jwt decoder) you'll see that it is actually an idToken. To avoid breaking changes during migration to v2, use the idToken. However, idTokens should be used to identify users not to secure APIs, so if you are currently using idTokens to obtain access to APIs you may need to come up with a migration plan to using access tokens if you want to do this correctly moving forward.

Msal.js v1 API may return the token in the accessToken field but if you crack it open (using jwt.ms or other jwt decoder) you'll see that it is actually an idToken

OK, that was my suspicion as well...

However, idTokens should be used to identify users not to secure APIs,

Can you explain why exactly they should not be used? I mean, I know, that the documentation page says so, but it doesn't explain that either. Are they less secure or what?

you may need to come up with a migration plan to using access tokens if you want to do this correctly moving forward.

As I was trying to explain, the above-described workaround with client-id/.default scope does produces an actual access token (not an id_token).
Are you saying that this approach is not recommended, should be avoided and might suddenly stop working at some point?

@scale-tone

Can you explain why exactly they should not be used? I mean, I know, that the documentation page says so, but it doesn't explain that either. Are they less secure or what?

IdTokens only contain information about who the user is, not about what they can access (scopes). There's also the issue of validating tokens, the API should only ever accept tokens issued for its own clientId and reject those that don't match.
Access tokens can also benefit from additional security mechanisms including Proof of Possession

As I was trying to explain, the above-described workaround with client-id/.default scope does produces an actual access token (not an id_token).
Are you saying that this approach is not recommended, should be avoided and might suddenly stop working at some point?

The /.default scope means "give me an access token for every scope registered on this app registration for this resource". If that's what you want, this is a fine approach. It does mean, however, that if you add scopes to your app registration, for this resource in the future your users will be prompted for consent to the new scopes at that time. It is usually recommended practice to request only as much permission as you need, when you need it. (If you only have a single API this may be irrelevant). You can read more about the /.default scope here

Access tokens can also benefit from additional security mechanisms including Proof of Possession

This makes sense, thanks for explanation.

if you add scopes to your app registration, for this resource in the future your users will be prompted for consent to the new scopes at that time. It is usually recommended practice to request only as much permission as you need, when you need it. (If you only have a single API this may be irrelevant)

Again, yes, here we're talking about the simplest yet most typical "SPA+its own API" scenario, where the app registration doesn't have nor will ever have any custom scopes. Therefore this approach really seems to be the way to go. I suggest it to be explicitly documented and/or illustrated with a dedicated sample.

@scale-tone You'll find a sample for this scenario here. Closing as the original question has been answered.

Thanks, @tnorling , but again, as I was trying to explain, that sample requires creating custom scopes.
The goal is to avoid requiring that, so that your library remains backward-compatible.
People are very much outraged already by this never-ending migration saga (adal->msal v1->msal v2->...) , can we please try to not complicate things even more?


Science dev

Added LOS velocity in skewer info panel and modified the plots to show units for everything

@farhantasy can you create a pull request to merge your changes onto the Dev branch instead of Master?


Buffer changed event doesn't handle line endings correctly

Tested on windows.
Test
Open the console when a text file is active and run the following:
ed = atom.workspace.getActiveEditor()
ed.setText("\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n");
ed.buffer.onDidChange(function(diff){ console.log(JSON.stringify({ oldText: diff.oldText, newText: diff.newText })) });

Now make the text file active and press enter.
Errors
What is actually inserted : \r\n
What is reported by the buffer : \n.
Refs
Refs : https://github.com/TypeStrong/atom-typescript/issues/354

Thanks for the report, @basarat. I'm seeing the same on OSX. /cc @nathansobo @maxbrunsfeld

Actually, I don't believe this is a bug ...
I followed the instructions above and then viewed the file with the hex package:

Unless you're expecting to see 0x0D 0x0D 0x0A?

@lee-dohm What did you see in the devtools console as the output?

I saw the output reporting that \n was inserted, as I expected because that's what 0x0D 0x0A equals in Windows newline mode.

@lee-dohm The part that's confusing me is that when I execute ed.getText() after running the snippet -- I see that a \r\n was added at the end, but the console.log from the snipped above wrote {"oldText":"","newText":"\n"} to the console.

Yes, this is Atom detecting the line endings to use based on the other line endings in the file. Unix uses just 0x0A to mean \n, but Windows uses 0x0D 0x0A to mean \n. So if I insert \r\n into a file that uses Unix line endings, I would expect the changed event to tell me that \r\n was inserted. But if I insert \r\n into a file that uses Windows line endings (like the example above), I would expect the changed event to tell me that \n was inserted.

Of course, I would also expect that if I inserted \n into a file with Windows line endings that 0x0D 0x0A would be inserted into the file and that the changed event would still tell me that \n was inserted.

And that's exactly what happens:
> editor.insertText("\n")
{"oldText":"","newText":"\n"}

But if I insert \r\n into a file that uses Windows line endings (like the example above), I would expect the changed event to tell me that \n was inserted.

Interesting, I'm not sure I would have expected that -- I kind of expected to see the raw text changes which were applied to the file. However, line ending confuse me almost as much as encodings and timezones, so I'm going to politely :runner:  away from this one. :smile_cat:
Just in case that's helpful, I'm seeing:
ed.insertText("\r\n")
{"oldText":"","newText":"\r\n"}

ed.insertText("\n")
{"oldText":"","newText":"\n"}

And when I just press enter in the editor:
{"oldText":"","newText":"\n"}

But if I insert \r\n into a file that uses Windows line endings (like the example above), I would expect the
changed event to tell me that \n was inserted.

Interesting, I'm not sure I would have expected that -- I kind of expected to see the raw text changes
which were applied to the file.

Yeah, this is a text-buffer bug. Though windows and unix display the \n and \r characters differently, the string \r\n is two characters regardless of your platform. We just made a simple error in this code: we define the event before we normalize the line endings.

By the way thanks a lot for the report @basarat.

The fix will be in Atom 0.202.

Thanks, @maxbrunsfeld :zap:

Thanks ! :rose:


ERROR: 'lowrisc:dv:chip_verilator_sim' or any of its dependencies requires 'chip_verilator_sim', but this core was not found

nicolast0604@nicolast0604-VirtualBox:~/opentitan$ fusesoc --cores-root . run --flag=fileset_top --target=sim --setup --build lowrisc:dv:chip_verilator_sim
WARNING: Unknown item formal in section Target
WARNING: Unknown item formal in section Target
WARNING: Unknown item formal in section Target
ERROR: 'lowrisc:dv:chip_verilator_sim' or any of its dependencies requires 'chip_verilator_sim', but this core was not found
Any hint is welcome, I am new to this field. Thanks a lot.

Have you made any change to the source tree? The command works for me on a clean opentitan checkout, and also runs in CI.

Hi I didn't make any change to the source tree.
opentitan-earlgrey_silver_release_v5-561-g5392c8604
I will re-git clone it again and try to see if I missed anything.

The repro I just git cloned works so I guess there is database truncated last time I download.
Thanks a lot.


Add shebang to build.py

Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also needed in test.py.

Also needed in test.py.

Test.py needs some other changes, too, so I was going to roll those together.

I actually have this as part of https://github.com/opensearch-project/opensearch-build/pull/163/files which is the first time we need this, if you just want to close this, or merge, up to you.

Whichever change gets approved first is fine with me :) I've approved #163.

Let's do this in #163 to group related changes.


Provide selection of current editor to Navie if it's opened from the AppMap tool window

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/688
Previously, the text selection was only used if Navie was opened via Tools > AppMap > Explain with Navie.
With this PR, opening Navie with the blue button is now using the selected text, too.

:tada: This PR is included in version 0.66.0 :tada:
The release is available on:

v0.66.0
GitHub release

Your semantic-release bot :package::rocket:


.xaml files weren't indexed (VS repo)

E.g. the file TreeViewItemStyles.xaml doesn't seem to be there.

Also something weird about ?leftProject=Microsoft.VisualStudio.TestWindow.UI


The metadata watcher should not use a proxy.

[Current coverage][cc-pull] is 98.43%

Merging [#305][cc-pull] into [development][cc-base-branch] will increase coverage by 0.02%

@@           development       #305   diff @@
=============================================
  Files               34         34
  Lines             2644       2691    +47
  Methods              0          0
  Messages             0          0
  Branches           131        131
=============================================
+ Hits              2602       2649    +47
  Misses              37         37
  Partials             5          5

Powered by Codecov. Last updated by [27b5a1f...c0b59fa][cc-compare]
[cc-base-branch]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/branch/development?src=pr
[cc-compare]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/compare/27b5a1f9c58bf114d872667655d969d2273216f8...c0b59fab765245a6b1862c9efa9f4014167555b6?src=pr
[cc-pull]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/pull/305?src=pr

LGTM


Add tgik146 title image

I guess I'm doing this. 😁

(Are there additional files I should put in now, like a README?)


please update modeling_llama_moe_hf.py

llama2 does not seem to be supported, please update modeling_llama_moe_hf.py

Hi there, thanks for your attention on this project ~
Could you provide more details about the current problem and the version of transformers you are using?

My transformer version is 4.38.1 I use llama2 7b chat model this is my inference code:
import torch
from llama_moe.modeling_llama_moe_hf import LlamaMoEForCausalLM
from transformers import AutoTokenizer
model_dir = "petrelfs/share_data/quxiaoye/models/LlamaMoEForCausalLM/Random/Qwen1.5-0.5B-Chat_llamafy-16Select4-gate_proj-Scale1.0"
tokenizer = AutoTokenizer.from_pretrained(model_dir)
model = LlamaMoEForCausalLM.from_pretrained(model_dir, torch_dtype=torch.bfloat16,load_in_4bit=True,device_map="auto")
model.eval()
#model.to("cuda:0")

input_text = "Suzhou is famous of"
inputs = tokenizer(input_text, return_tensors="pt")
inputs = inputs.to("cuda:0")

pred = model.generate(**inputs, max_length=50, temperature=0.1)
print(tokenizer.decode(pred.cpu()[0], skip_special_tokens=True))

Thanks for the response. The model directory to petrelfs/share_data/quxiaoye/models/LlamaMoEForCausalLM/Random/llama2-7B-Chat-16Select4-gate_proj-Scale1.0 seems to be not correct.
Have you split the FFNs to experts from llama-2-7b-chat-hf and continually pre-trained the corresponding model to recover language abilities?

Thanks for the response. The model directory to petrelfs/share_data/quxiaoye/models/LlamaMoEForCausalLM/Random/llama2-7B-Chat-16Select4-gate_proj-Scale1.0 seems to be not correct.
Have you split the FFNs to experts from llama-2-7b-chat-hf and continually pre-trained the corresponding model to recover language abilities?

Thank you your response,I'm not pretrain moe model,I will training it next.

After converting the dense model into MoE, you may try to load the model and make text completions, but the prediction quality is not guaranteed, so continual pre-training is needed for language ability recovery.


Setting GOPATH variable in netplugin/Makefile

When we DO NOT set GOPATH, netplugin/Makefile uses an empty GOPATH variable without setting it. Hence, when we run make k8s-test, the line https://github.com/contiv/netplugin/blob/master/Makefile#L164 fails with the following error:
cd /src/github.com/contiv/netplugin/scripts/python && PYTHONIOENCODING=utf-8 ./createcfg.py -scheduler 'k8s' -binpath contiv/bin -install_mode 'kubeadm'

/bin/bash: line 0: cd: /src/github.com/contiv/netplugin/scripts/python: No such file or directory

This PR sets the GOPATH variable in netplugin/Makefile before using it.
Tested on Mac laptop.
Signed-off-by: Vikram Hosakote<EMAIL_ADDRESS>

build PR

This is wrong. All the targets have failed on the CI.

The GOPATH environment variable must be set before invoking the Makefile. This is related to how Go development is done and it's something which applies to other targets as well, not only to this target.

build PR

if GOPATH is not in the environment, which we have no certainty is correct
@chrisplo When GOPATH is not set in the environment, I see go env GOPATH shows the right path:

$ unset $GOPATH
$ echo $GOPATH

$ go env GOPATH
/Users/vhosakot/go
$ go env | grep GOPATH
GOPATH="/Users/vhosakot/go"

you just happened to make your GOPATH ~/go, that's not valid for my environment for example . . looked up an example of bailing on unset variable:

build PR

@chrisplo @unclejack @dseevr How does this look now? I've tested for all cases for GOPATH - set, unset, default, non-default, export, non-export(local).

build PR

build PR


feat: add additional maps when running from docker

we need to rebuild the Dockerfile according to this:
https://github.com/carla-simulator/carla/issues/6912

https://github.com/carla-simulator/carla/issues/6912#issuecomment-2009307756


Glitch: Scroll Bar appearing on Katex snippet

Browsing the demo I stumbled upon this.

https://sylhare.github.io/Type-on-Strap/2014/11/28/markdown-and-html.html

@danisztls it's nothing. I checked it and came to the conclusion that if the problem(Katex math problem) is big and there isn't enough space, it compresses and adds the scroll bar to scroll the problem.

observed on other sites too

Indeed, the only issue is that Firefox has an ugly scrollbar compared to other browser. :sweat_smile:

@sylhare That's on Chromium.

Alright cool, I'll add an extra long equation and put your fix to the test 😛

Well after testing making the overflow visible is too risky, so we'll leave it as is. But it could be something to be solved by the KaTex team :+1:


Add support for Java 9 multi release jars #61

A property for library jar exclusions (libraryJarExclusion)

I'm closing this and leaving the newer one open (https://github.com/wvengen/proguard-maven-plugin/pull/76) They seem to be equal.


refactor(pf-m-action): change to pf-m-plain

fix https://github.com/patternfly/patternfly-next/issues/550

Deploy preview for pf-next ready!
Built with commit 9064a1a2535e84cea84da0b010ede6d0c1b19d9a
https://deploy-preview-560--pf-next.netlify.com

Idk, I think it should be .pf-m-icon as it will only ever contain an icon..

@andresgalante rebased.
@mattnolting the idea was that this (mostly) "unstyles" something, so it could apply it to some other component that you want to want to remove the borders, background/colors, and just present something with minimal styling.

@michael-coker Works for me!

:tada: This PR is included in version 1.0.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Default CoreDNS config does not work on AWS Wavelength

The default coredns ConfigMap installed by microk8s points to Google's DNS (<IP_ADDRESS>).
On AWS in general, that works fine. But on Wavelength, those DNS servers are blocked:
$ nslookup google.com <IP_ADDRESS>
;; connection timed out; no servers could be reached

To make it work I had to edit the ConfigMap to use
forward . /etc/resolv.conf

and add
--resolv-conf=/run/systemd/resolve/resolv.conf

to the kubelet args in /var/snap/microk8s/current/args/kubelet (as suggested by https://kubernetes.io/docs/tasks/administer-cluster/dns-debugging-resolution/#known-issues)
This situation could be detected using something like my nslookup command above. If the installer had done this it would have saved me many hours.

Thanks for the big, that’s very useful information.  Out of interest, do you know if <IP_ADDRESS> and <IP_ADDRESS> are blocked too?

Thanks for the big, that’s very useful information.  Out of interest, do you know if <IP_ADDRESS> and <IP_ADDRESS> are blocked too?

They are blocked, yes.
I would not be surprised if all DNS traffic to outside servers is blocked, since Wavelength is all about speed optimization. So using AWS DNS servers makes sense.
Btw, ping <IP_ADDRESS> works.

They are blocked, yes.
I would not be surprised if all DNS traffic to outside servers is blocked, since Wavelength is all about speed optimization. So using AWS DNS servers makes sense.
Btw, ping <IP_ADDRESS> works.

Thank you for reporting and debugging this @codefrau. We would need to detect such cases in [1] and act accordingly.
[1] https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/actions/enable.dns.sh

Thank you for reporting and debugging this @codefrau. We would need to detect such cases in [1] and act accordingly.
[1] https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/actions/enable.dns.sh


Commenter failing on PNG images

This is strange, as it was working just fine last week. No commiting PNG file to the repo (for documentation purposes) results in a following build failing:
+ echo 'tfsec violations were identified, running commenter...'
tfsec violations were identified, running commenter...
+ commenter
Starting the github commenter...
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details could not be resolved

Is there anything we can enable to debug this more?
We are using v0.1.10

I think this is when the patch details are calculated which wouldn't work with a png or other binary format. I will fix and update in the morning

@romankaminski  - I've fixed this in v1.0.1 of the action. it will gracefully step over binaries

Checked and it works. Thank you for quick reaction. Appreciated.


Nightly JDK11U builds are not being published...?

There have been no nightly jdk11u builds published for 2 days here: https://adoptopenjdk.net/nightly.html?variant=openjdk11&jvmVariant=openj9

Not specific to OpenJ9 - also true for HotSpot/JDK11, but not JDK8

I think this may be a side effect of https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/612 as some of the arm jobs were blocked. Will get things freed up ...

Killed the following which were stuck at Cannot contact build-scaleway-armv7-ubuntu16-04-[12]: java.lang.InterruptedException

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-arm-hotspot/9/
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-arm-hotspot/12/
Machines had fallen over for the second time in the last few days - possibly a result of extra testing being enabled on the platform - and this seems to have stopped the flows from completing and the publish job not being triggered.

Machines now recovered and will keep an eye on them. The jobs from the 3rd onwards are still in progress - the one from the 3rd has just published (dated the 6th on the nightly pages) and the others will likely follow in due course later today

Seems to have now caught up - closing


bug(all): Remove dependency to fsevents

Bug description

When I add the powertools to my project, it adds dependency to fsevents. On my Mac, running npm install defines the platform darwin for fsevents. The CI build run in CodeBuild and Linux. The build fails because the platfrom doesn't match.

npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"linux","arch":"x64"})
--
51 | npm ERR! notsup Valid OS:    darwin
52 | npm ERR! notsup Valid Arch:  undefined
53 | npm ERR! notsup Actual OS:   linux
54 | npm ERR! notsup Actual Arch: x64

I want to develop on my Mac and still be able to use Linux in CI.
Expected Behavior

Npm should install all dependencies on both platforms.
Current Behavior

See above. fsevent seems to use features of a specific operating system. Thus, I can't develop on my machine while using Linux in CI.
Possible Solution

Steps to Reproduce

npm install powertools on mac
add package.json and package-lock.json, commit and push
checkout code on a Linux machine
rum npm ci

Environment

Powertools version used: 0.2.0
Packaging format (Layers, npm): npm
AWS Lambda function runtime:
Debugging logs:

Related issues, RFCs

Hello thank you @timohirt for opening the issue. We'll have to look into it more closely and get back to you.

Hello @timohirt I've been looking at this and I'm unable to reproduce. Could you please confirm that this is still an issue using the latest version on main and using<EMAIL_ADDRESS>together with<EMAIL_ADDRESS>as described in the CONTRIBUTING document?
We are also using linux in our CI/CD and it seems to not be an issue.

Hello @dreamorosi! It works for me now. Thanks!


Bump server in client with prerelease packages

Description
Bump protocol-definitions, server-services-client, server-local-server, protocol-base, server-services-core, server-test-utils, and gitresources, tinylicious package versions in client repo.
Modified the ISnashotTree to add a prop: omitted to let service communicate to client whether it omitted the contents or not.
This change was made in protocol-defn package which was upgraded in server repo, and now upgrading server and protocol defn packages in client repo.
This is related to Data Virtualization.

I suggest not doing prereleases of server. It's a time bomb that will blow up for the person who has to do a server release before they can release client. Because server releases can contain all sorts of changes and the longer we leave it the changes will pile up and become a major hassle for the person who has to do the real server release.
If you need a server change, do a full server release, major version, and bump the client to use it.

That said, since the prerelease was already done, carry on. Maybe for next time, though, do a full server release.


Team Meeting - February 3 2024 @ 12:00 PM

Reviewed work done this week. Assigned items to be done before demo. Planned out integration of separate features.


Enhance grayscale model.image by expanding the values range to 0 - 255

Implemented using a median filter to get robust min/max estimates, then the range is shifted and expanded.


Geofence error

Traccar is presenting a bug in the geofence, is that although the GPS reports in the geofence, traccar does not trigger the event enter geofence or exit geofence. It is happening when I assign a geofence to a group, in some devices the event of enter geofence or exit geofence is not performed, I tried associating the devices directly to the geofences and it fails intermittently. That is 5 times that passes through the geofence 1 time the event does not occur.
The geofences are assigned 150 devices reporting every 100 meters the shape of the geofence is a rectangle of 120 meters.
example

Please provide details of a case when it failed to detect entering or existing geofence. We would need geofence object details and logs with device passing through it.

Geofence
POLYGON((9.193534299509523 -75.8161426350667, 9.193550186034159 -75.81580467673082, 9.192078031723497 -75.8157456681325, 9.192078031723497 -75.8160889908864, 9.193534299509523 -75.8161426350667))
Pictures.zip

How can I find your device in the log?

id device<PHONE_NUMBER>

I have tested your geofence with data from logs and I see 2 geofence events, so everything is working as expected:

If it didn't work for you, most likely it means that something was misconfigured.


Failed to set DB password with escape charater '\n' in harbor.cfg

Setting DB password  Root1234\n, failed to apply to starting mysql container.

Fixed by #1988 .


Add detection for guice 4.

This guice-4-detection seems to fix the issue https://issues.apache.org/jira/browse/SHIRO-493.

Thanks frido!
I guess the next step is to add a (failing) test for guice 4 where a custom filter is used (i.e. to trigger the IllegalArgumentException), and see whether it can be solved.  I'm doubtful with the current interface, as Key has only a default constructor so options seem limited without an API change - the challenge is open!


Test: cell tag editing and slideshow support

Refs https://github.com/microsoft/vscode-jupyter/issues/1121, https://github.com/microsoft/vscode-jupyter/issues/1121

[ ] anyOS @alexdima
[ ] anyOS @minsa110

Authors: @rebornix
Complexity: 3
Create Issue

We added support cell tags and slideshow in ipynb file opened in notebook editor. A good demo of how the cell tag insertion/deletion and slideshow works is https://github.com/microsoft/vscode-jupyter/issues/1182#issuecomment-1254098790 , please test (after installing the prerelease of Jupyter extension in Insiders)

You can add tags to a cell through cell toolbar commands
You can delete tags from cell status bar
You can jump to a cell metadata in an ipynb json file from a notebook editor through cell toolbar commands
You can add slideshow types through cell toolbar commands
etc ...

Please see https://github.com/microsoft/vscode-jupyter/issues/11467 , none of the actions have any effect for me 🤷 .

@alexdima thanks for the bug report, it's a very good one

The cell context menu in notebook editor is using UriComponents as context, but the cell toolbar is using NotebookCell. Since we populate commands from cell toolbar to the cell context menu, those commands won't work in cell context menu. It's a bit too late to make this change, let's fix it in Oct https://github.com/microsoft/vscode/issues/162018
For now, let's workaround this by checking if the context is a NotebookCell or UriComponents.

To continue testing, we can use the cell toolbar (placed at the top right of a cell) or command palette to perform those actions.


Adding Customization of MeshMap Snapshot in docs

Notes for Reviewers
This PR fixes #8298
Documenting how users can add custom triggers to workflow and also adding steps how contributors  can add Meshmap snapshot to their PR
Signed commits

[x] Yes, I signed my commits.

Hey @leecalcote, @Chadha93 and @Abhishek-kumar09  need your feedback on this

🚀 Preview for commit b8f6d9f6b68002df22cc1e250c0aac04975f86cd at: https://64d690c79f906a09628c31cb--meshery-docs-preview.netlify.app

@yash37158 let's discuss this on websites call, please add this as an agenda item in the meeting minutes.

^^ call for review @leecalcote

@yash37158 thanks. I have seen your multiple call for reviews on GitHub and in Slack.

@yash37158 We couldn't cover this on Monday. Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Sure

🚀 Preview for commit ad22a13b0bca5c8dab6eb1d5f262cc1dbae8f17d at: https://64dd1de3a975f21b4581d8b7--meshery-docs-preview.netlify.app

🚀 Preview for commit 29ad89ede4d597cda114407fa49d201805024fa2 at: https://64dd1f6c4267721a2c41916c--meshery-docs-preview.netlify.app

Hey @leecalcote, let me know your thoughts on this.

🚀 Preview for commit 9c0fbfb48ab4eb3e795a38c5538a1afe2f7c2d7e at: https://64dfbc6e5755400b58fa6bd6--meshery-docs-preview.netlify.app


Port to rkyv 0.8.9 instead of 0.7

This PR contains my attempt to port the code to rkyv 0.8.9 instead of 0.7 that was used before.
Not everything is successful, in particular this line does not work. @Handy-caT  maybe you can take a look?
Closes #11.

It looks like there is no AlignedBytes data type in rkyv 0.8. This data type is used in the code.


[WFLY-18163] Add tests for JaasSecurityRealm via a custom-realm resource

https://issues.redhat.com/browse/WFLY-18163
Related to https://github.com/wildfly/wildfly/pull/17044
Requires:
https://issues.redhat.com/browse/WFCORE-6411

Superseded by https://github.com/wildfly/wildfly/pull/17622, already merged


Editor has crashed on Mac High Sierra 10.13.6 atom vs 1.29.0 and 1.30.0

Edit by @rsese to clean up formatting

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
[Description of the issue]
Steps to Reproduce

Open Atom on Mac high Sierra 10.13.6
Atom opens and says Editor has crashed, keep it open, reload or close window
I tried closing / then reloading, then keep it open.

Expected behavior: [What you expect to happen]
I just need atom.io to open and be usable.
Actual behavior: [What actually happens]
Nothing, after the window popup that says the editor has crashed.
Reproduces how often: [What percentage of the time does it reproduce?]
Atom has not worked in days( about one week)
Versions
1.29.0
1.30.0
Mac High Sierra 10.13.6
Additional Information
---I have tried going through the debugging steps, I tried clear window state, I tried safe mode, I tried rebooting, I deleted atom.io 1.29.0 and installed a newer vs of atom 1.30.0, nothing works. I checked the forum, I Googled atom Editor has crashed, I also tried lookin at my permissions after reading a related person's post that said this fixed the issue. Nothing has worked. Atom is now unusable???? I have attached the latest crash log.
atom crash report sept 8.txt

Thanks for the report - just to clarify, Atom worked ok for you previous to version 1.29?

I have tried going through the debugging steps, I tried clear window state, I tried safe mode, I tried rebooting, I deleted atom.io 1.29.0 and installed a newer vs of atom 1.30.0, nothing works

When you tried these debugging steps, was there any difference at all, or did Atom crash in the same way?  Is Atom crashing after some amount of time, or right away?
Did you also try temporarily resetting to factory defaults?

That was it. I failed to try that one, I was hoping to not have to reset it back to the default. Just tried it on vs 1.30.0. It now works. Thank you. Closing this now.

Factory defaults command worked on vs 1.30.0

Atom did not work on 1.29 either.
That was it, I didn’t want to have to do that last one. But I just tried it and it now works.
Thank you.
I closed this issue.

On Sep 10, 2018, at 11:53 AM, Robert Sese<EMAIL_ADDRESS>wrote:
Thanks for the report - just to clarify, Atom worked ok for you previous to version 1.29?
I have tried going through the debugging steps, I tried clear window state, I tried safe mode, I tried rebooting, I deleted atom.io 1.29.0 and installed a newer vs of atom 1.30.0, nothing works
When you tried these debugging steps, was there any difference at all, or did Atom crash in the same way? Is Atom crashing after some amount of time, or right away?
Did you also try temporarily resetting to factory defaults https://flight-manual.atom.io/hacking-atom/sections/debugging/#reset-to-factory-defaults?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/atom/atom/issues/18009#issuecomment-420021080, or mute the thread https://github.com/notifications/unsubscribe-auth/AetouPWNKkFyvlSmOrYC2aQcij4R0aB7ks5uZrVCgaJpZM4WgFLD.


[#691] Rename u-gap-m to u-gap-l

Fixes #691
Changes
Cleanup after #674 — renames all the uses of u-gap-m in our documentation to u-gap-l, to match the renamed classname
Checks
Delete if not applicable:

[x] Storybook documentation has been updated

I first had a mild heartattack and though, oh no we need to rename all the things in our projects as well. But then I saw that the original change was just fixing the stories file 🤣. Good change.

I first had a mild heartattack and though, oh no we need to rename all the things in our projects as well. But then I saw that the original change was just fixing the stories file 🤣. Good change.

@andreasknoepfle yeh this is only cleaning up the docs :D But that was necessary because the gap classes were updated in another PR (and these instances of the classname were missed). For updating — the old classnames can be kept by changing the config to how it was before. (but this change was actually something requested, so maybe we do want to make the change to the new naming in our projects…)


flipkart web scraping  GGSoC'23

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
Web scaping on filpkat of mobile under 50000 as it most necessary devices now days.
1.PRODUCT NAME
2. PRICES
3. DESCRIPTION
4. REVIEW
I will do web scraping for like some pages and provide you the SOURCE code and CSV file too.
Screenshots
No response
Code of Conduct

[X] I follow Contributing Guidelines of this project.

We are working on the provided dataset only. Won't work on web scraping as for now. Try to work on other issues.

okay no problem


[Performance] Default flat map on slower devices instead of globe

Disable global projection or swap map implementation if:

device is detected to be incompatible with mapbox
somehow measure that performance is really degraded
maybe default to one or the other and allow user to change setting in user preferences

the map performed well on an iphone 13, but clicking a tree was really difficult


Detection support

Overview
Identify the target procedure
Features

[ ] Document calling convention
[x] Parse the call
[x] Handle procedure schema
[x] Handle argument schema
[x] Test the best candidate
[x] Handle quotes
[ ] OUT parameters
[ ] Provide two modes for detection, with internal API and Fail back with Queries

Related specific issue #13

Due to complexity of pg_proc, we have to build a stored procedure for that

@ng-galien, ok!


 It seems that azkaban can only kill job on its executor server. So how can i kill such spark job on yarn launched by azkaban, is there anyone can help this?

I solved it

@JoaNIO How can you fix it.


There was an issue fetching the favorite status of this dashboard.

When the anonymous user opening the dashboard, Display an error"There was an issue fetching the favorite status of this dashboard"
Screenshots

How to reproduce the bug
1.the anonymous user opening the dashboard
2.See error
Environment
(please complete the following information):

superset version: superset master
python version: python --3.7.4
node.js version: node -V14.15.5

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Hi @xch-jack,
Can you share your configuration for the Public role, list of permissions. Are you using PUBLIC_ROLE_LIKE config key?

Hi，
My  PUBLIC_ROLE_LIKE are the default.I have tried configuration Public role with administrator permissions,But the error still appears to be.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/superset"                                                                                @.>;
发送时间: 2021年5月20日(星期四) 晚上6:28
@.>;
<EMAIL_ADDRESS>主题: Re: [apache/superset] There was an issue fetching the favorite status of this dashboard. (#14720)
Hi @xch-jack,
Can you share your configuration for the Public role, list of permissions. Are you using PUBLIC_ROLE_LIKE config key?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

The default for PUBLIC_ROLE_LIKE has no permissions https://github.com/apache/superset/blob/master/superset/config.py#L284 this means that non authenticated don't have access to any resource.
Please share your Public role permissions, goto Security -> List Roles -> Edit (Public Role)

Hi,
This is My  Public role permissions,same as admin Public role permissions.
But the error remains
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/superset"                                                                                @.>;
发送时间: 2021年5月21日(星期五) 下午4:00
@.>;
<EMAIL_ADDRESS>主题: Re: [apache/superset] There was an issue fetching the favorite status of this dashboard. (#14720)
The default for PUBLIC_ROLE_LIKE has no permissions https://github.com/apache/superset/blob/master/superset/config.py#L284 this means that non authenticated don't have access to any resource.
Please share your Public role permissions, goto Security -> List Roles -> Edit (Public Role)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Fix merged, closing. Feel free to re open if the problem persists


Docker : spin multiple containers using curl

Hi,
I am trying to spin multiple containers using curl.
For example ,
i have the following sample config.json file.
{ #1st redis container
"name" : "redis1",
"Hostname" : "",
"Domainname" : "",
"User" : "",
"AttachStdin" : false,
"AttachStdout" : true,
"AttachStderr" : true,
"Tty" : false,
"OpenStdin" : false,
"StdinOnce" : false,
"Env" : [],
"Cmd" : [],
"Entrypoint" : [],
"Image" : "redis:latest",
"Labels" : {},
"Volumes" : {},
"WorkingDir" : "",
"NetworkDisabled" : false,
"ExposedPorts" : {},
"HostConfig" : {
"Binds" : ["/tmp1:/tmp1"],
"Memory" : 0,
"MemorySwap" : 0,
"CpuShares" : 0,
"RestartPolicy": {
"MaximumRetryCount": 2,
"Name": "always"
},
"PublishAllPorts" : false,
"Privileged" : false
},
{ #2nd redis container
"name" : "redis2",
"Hostname" : "",
"Domainname" : "",
"User" : "",
"AttachStdin" : false,
"AttachStdout" : true,
"AttachStderr" : true,
"Tty" : false,
"OpenStdin" : false,
"StdinOnce" : false,
"Env" : [],
"Cmd" : [],
"Entrypoint" : [],
"Image" : "redis:latest",
"Labels" : {},
"Volumes" : {},
"WorkingDir" : "",
"NetworkDisabled" : false,
"ExposedPorts" : {},
"HostConfig" : {
"Binds" : ["/tmp1:/tmp1"],
"Memory" : 0,
"MemorySwap" : 0,
"CpuShares" : 0,
"RestartPolicy": {
"MaximumRetryCount": 2,
"Name": "always"
},
"PublishAllPorts" : false,
"Privileged" : false
}
Then using docker HTTP API end point to create the conatiners by passing the above json file.
curl -X POST --header "Content-Type: application/json" http://localhost:2375/containers/create --data @config.json
But unfortunately , containers are not created.
Is it really possible to spin up multiple containers using the method above???
Output of docker version:
Client:
Version:      1.10.1
API version:  1.22
Go version:   go1.5.3
Git commit:   9e83765
Built:        Thu Feb 11 19:27:08 2016
OS/Arch:      linux/amd64
Server:
Version:      1.10.1
API version:  1.22
Go version:   go1.5.3
Git commit:   9e83765
Built:        Thu Feb 11 19:27:08 2016
OS/Arch:      linux/amd64
Regards,
Prabal

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

The create endpoint creates a single container, not multiple; https://docs.docker.com/engine/reference/api/docker_remote_api_v1.22/#create-a-container. If you want to script creating containers from the shell, perhaps just use the docker binary (docker create ..), or you may be interested in Docker compose, which allows you to define all the containers for your project in a single docker-compose.yml file https://docs.docker.com/compose/compose-file/
Please keep in mind that the GitHub issue tracker is not a general support forum for working with docker, but for reporting bugs and feature requests. For other type of questions, consider using:

forums.docker.com
the #docker IRC channel on freenode
StackOverflow

I'm going to close this issue, because this is not a bug report, but feel free to comment here after I've closed


Supress reposting of all-caps posts

Report an all-caps title only once, and then automatically ignore it. If no-one edits it after the first report, it is unlikely to be edited by Tavern folks on subsequent reports.
Original request by Behaviour in The Tavern on the Meta: http://chat.meta.stackexchange.com/transcript/89?m=2858969#2858969

As I said to Behaviour in the Tavern, it is a good idea, but the list might grow very long and take many disk space.
What do you think about storing those all-caps titles for 24 hours and then remove (un-ignore) them? After 24 hours, it's unlikely that they still be in all-caps.

Closed via https://github.com/Charcoal-SE/SmokeDetector/commit/6b781e9f85dc6891a07fb51e4d9fd8788dce44a5

Wait, are you storing a list of all previously stored allcaps posts?
We have a mechanism in place for ignoring edited posts but it deliberately has a small cache, I didn't want to accumulate titles over time. I don't think we should do that here either.

They are just stored for 7 days. Then the list certainly won't grow too large.


Add a test for a C# example

@lukehoban I also changed the build scripts to copy the nuget package to the local source


E117 is missing: overindented code blocks

Documented in master

Thanks! Do you manually build your website or do build it automatically?

I use GitHub pages, which builds it automatically. When I say "documented in master" what I mean is that I just documented it and pushed to master. So you're right; it was missing. Apologies for the confusion there!


cgroup: introduce proper cgroup/v1, cgroup/v2 packages

Currently we have func .V[1|2]. named function names in the cgroup
package.
This factors those functions into two separate packages cgroup/v1, and
cgroup/v2.
This is a prerequisite for #3242

@lucab @squeed looking green enough for a review ;-) PTAL


Possible issue with large client numbers in 1.0.0b12

A script that runs daily to gather client usage stats gave an error few nights ago, again last night, and several times today when testing to track down...
aiomeraki.networks.getNetworkClients raises an exception "argument of type 'URL' is not iterable"
t = 24 * 60 * 60
clients = await aiomeraki.networks.getNetworkClients(net['id'], timespan=t, perPage=1000, total_pages="all")
Testing shows out of three orgs and > 200 networks only seeing the issue on a single 'appliance' network that has a large number of clients - when checked in Dashboard over 3100 clients seen in last 24 hours, maybe it's triggering an issue in the page handling?
The script has been running ok for several weeks, only seen this since 1.0.0b12, but it may simply be that client numbers haven't been as high previously.

Can you send the raw log file to me please<EMAIL_ADDRESS>

Issue is resolved in https://github.com/meraki/dashboard-api-python/commit/0ad00acb115bcabcc9f40e3c4acfd7475b789378


Deploy OCS prometheus alerts - substitute for PR #733

Follow-up to PR #705
Substitute for PR #733 in order to make progress while @umangachapagain is out.

Interesting changes.

Why is Rook vendor change a part of this PR? These aren't related in any way.
What is the justification for using Go structs instead of YAML for alerting rules?
I have added my reasons for using YAML instead of Go Structs here: https://github.com/openshift/ocs-operator/pull/733#discussion_r481863240


HDDS-11885. Download Hadoop for S3A test from mirrors if available

What changes were proposed in this pull request?
acceptance (s3a) downloads Hadoop source tarball for running contract tests.  Currently it uses archive.apache.org directly.  This PR changes the URL to use closer.lua, which checks mirrors first.
https://issues.apache.org/jira/browse/HDDS-11885
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/12232729746/job/34120102070#step:6:21

Thanks @jojochuang for the review.


RT-2.7: IS-IS Passive is enabled at interface level

PR is created to address this issue.
https://github.com/openconfig/featureprofiles/pull/1807