fixes nix builder

As far as I can tell, the following feature advertised in the README.md isn't working:

Packages can be fetched from a binary cache or built on the fly if necessary.

This PR resolves this!

Ah good spot! looks like a typo to me. I've checked it doesn't break anything on my machine so should be good for merge @elpdt852!

I don’t understand how this slipped through integration tests… good catch. I’ll have to investigate why it went unnoticed.

@elpdt852 I think it is because the integration tests preload the VM with the images so the nix store is already populated!


[BUG] An exception occured while running bloxtrap

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?

The same error you got. Got it today afternoon

You're not using the latest version. Go download it. https://github.com/pizzaboxer/bloxstrap/releases/latest


Mismatch of command and description in README

Overview
A clear and concise description of what the bug is.
Steps to Reproduce
Steps to reproduce the behavior:

Go to Setting Up a Node section in README
Check the command and description

Expected Behavior
Description to be related to the command given or vice cersa
Screenshots

verified and closing this issue as fixed


Fix issues in Bulk Data tooling

Critical Changes
Changes

Mappings for extract_dataset and load_dataset can now specify fields as a simple list of Salesforce API names. CumulusCI will infer the database column names. Mappings may omit the table key and CumulusCI will use the object name.
extract_dataset and load_dataset stop and show an error if mappings do not use a consistent object Id mode.
extract_dataset and load_dataset correctly handle junction objects which have no fields.

Issues Closed

Adding Beth as a reviewer because this fixes (allegedly!) a key blocker for her in one project.


zulip: Reraise exceptions in do_api_query.

There are cases where the call to get_server_settings returns a JSON response with a connection error. In the case of such an unsuccessful response, we should raise an appropriate exception instead of parsing the response as though it was successful.
@timabbott Could you please take a look at this? Not sure if this is the right fix. Also, wondering if I should put a test for this somewhere in zulip_botserver?

This looks correct to me.  @andersk FYI.
For testing, I would prefer a test for the main zulip module, since the code is for that module.  I'm not sure we are setup to make it easy to write such a test, but at the very least I'd like to see the output from trying to connect to a non Zulip server with this.

@neiljp I was realizing it'd be helpful to have your review on this, since zulip-terminal probably cares about this aspect of error handling.

@andersk I just addressed your feedback. Thanks!
@timabbott I am honestly not sure how to write a test for this within the module. Seems like it might be better to write a test for this server-side? Should we maybe write some sort of a mocking framework that mimics a Zulip server and raises exceptions at certain points?

A server-side test that we run alongside test-api in CI could work.  If we want to write proper tests, we need to write a bit of a test framework, which is probably out of scope for this issue.
Grepping for connection-error call_on_each_event makes use of the old error handling convention, and needs to be ported to handle exceptions.  We can test the ported version manually by just pointing a bot at the development environment and trying things like ctrl+C on the development server to generate connection errors.
(It's an important part of the call_on_each_event interface that it will continue running even if you get connection errors once it has started, so that your bot using that API will continue working even if the server has temporary downtime)

@timabbott This PR is mostly ready for review, just needs to be tested manually. Thanks!

A summary of next steps or what needs to be done:

This PR needs to be manually tested.
As for automated testing, we need to write a test framework that mimics a Zulip server to be able to test this in the same repository.
In the absence of such a test framework, a server-side test that we run in something like tools/test-api would probably work.

Thanks!

Forgot to mention that the previous feedback has all been resolved on thsi PR! :)

Merged, thanks @eeshangarg for your work on this.


Add support for fetching data that loads from the top

We use this in our application. This PR adds a "isReverse" property that causes the loadMore function to be called when the user scrolls to the top of the area rather than to the bottom. One downside with this is that the module user has to make sure that after new items are added to the top of area that the area is scrolled back down to the original position. Otherwise the loadMore function will be triggered repeatedly.

Looks good! Thanks

Do we need to update the page start? I added the isReverse={true} but now view seems to load in the middle of the window.


Fix prebuild trigger

Problem statement
The devcontainer for this repository gets built in two steps:

A devcontainer is built from the src directory and then published as an image to the GitHub Packages repository.
The devcontainer.json file references the GitHub Packages repository and pulls the edge tag as the base image.

Or to put it another way: This project dogfoods its own devcontainer via self-reference. This is, necessarily, a two-step process.
The issue is that we want to use GitHub's Codespace prebuilds, but all three trigger options are unsuitable.

Every push — Unsuitable because the src build is run at the same time as the prebuild in devcontainer.json. This means that the prebuild is always based on the src build from the last commit.
On configuration change — This is unsuitable because we want the prebuilds to follow changes made to both the devcontainer.json and src builds.
Scheduled — Not suitable for rapid feedback-cycles during development because you'll have to wait until the next scheduled build to pick up your changes in a prebuilt codespace.

Proposed solution

Create a new branch named edge
Modify the Docker workflow to update the edge branch with the latest changes after publishing the image.
Change the Codespace prebuilds to trigger on every push to the edge branch instead of the main branch. This approach can be thought of as a pattern of the typical live or production branch. Changes to the branch follow from the deployment, not the other way around.

The result is that we enforce a dependency chain between the builds by using an intermediary branch.

Codespaces prebuilds require us to use a branch, so this change needs reworking.

Fixed in:

https://github.com/nomirose/devcontainer/pull/22


Update Compose UI application .yml example

Describe the proposed changes

Unreleased project version

Related issue

Related issue or PR in another project

Please take a look

Current Compose UI example is v1 and out of date. Changing code to v2 example from Compose Quickstart (also in docs) so that this works. We do still need to change the screenshots, but at least this will bring working code.

Deploy preview ready!
Built with commit a566d9aeeae12f86f6042b130f92d506a4a91567
https://deploy-preview-742--docker-docs.netlify.com


ICU stays seem to include other ward transfers

Hi there! I have another question regarding the icustays table in MIMIC-IV in the context of ICU readmission.
When looking at hospital admissions with multiple ICU stays (ordered by intime), I noticed that the intime of every stay_id (starting from the second) is equal to the outtime of its prior stay_id within the same hadm_id group. This feels like it means a direct transfer from one ICU to another ICU. But when checking out the similar scenario in MIMIC-III, none of the >3k admissions that I found with multiple ICU stays has them concatenated with each other.
I wonder if that implies a different derivation strategy or definition for stay_id based on transfers in MIMIC-IV compared to MIMIC-III (icustay_id), or if it's just the difference in data. Thank you so much!

I guess here's an example of what puzzles me. I was looking at hadm_id=22415651 and could found three icu stays (35582965, 35797310, 36061570, ordered by intime), of which the first and second stays cover transfers to ICU and also Med/Surg/Trauma transfers (based on intime and outime). This is in contrast with the third one 36061570 that did not include the Med/Surg/Trauma transfer at the end. Is it because it's close to discharge? Just wondering how I should interpret them. It seems MIMIC-III instead only covers icu transfer for each icu stay. But correct me if I'm wrong! Thanks!

Hi everyone!
I stumbled upon the same issue. Since I want to predict ICU readmissions for patients that were discharged to a lower level of care or home, this is critical for me. Just to add another (simplified) example for subject_id = 10002428

eventtype
careunit
intime
outtime

admit
Medicine
2000-01-01 12:00
2000-01-01 16:00

transfer
MICU
2000-01-01 16:00
2000-01-05 16:00

transfer
Medicine
2000-01-05 16:00
2000-01-09 16:00

transfer
MICU
2000-01-09 16:00
2000-01-16 16:00

transfer
Medicine
2000-01-16 16:00
2000-01-19 16:00

discharge

2000-01-19 16:00

Expected entries in icustays:

first_careunit
last_careunit
intime
outtime

MICU
MICU
2000-01-01 16:00
2000-01-05 16:00

MICU
MICU
2000-01-09 16:00
2000-01-16 16:00

Given entries in icustays:

first_careunit
last_careunit
intime
outtime

MICU
MICU
2000-01-01 16:00
2000-01-09 16:00

MICU
MICU
2000-01-09 16:00
2000-01-16 16:00

Just as @JHLiu7 mentioned the transfer to the medical ward between two ICU stays is included, but the stay at the end is not.

Thank you for raising this issue @JHLiu7 and sorry I didn't respond in a timely manner. Thanks also @stefanhgm for the clear follow up. As mentioned in #11, there was a change between MIMIC-III and MIMIC-IV in the definition of an icustay_id, which we now call stay_id (to help distinguish it from MIMIC-III, and because eventually we will include stays outside the ICU and having a single identifier name for all of them will be convenient). We no longer merge together nearby ICU stays unless they are adjacent. In the case above described by @stefanhgm there is a stay in a medicine ward between the ICU stays, so we should not merge these into a single ICU stay. Of course you have all found cases where we do in fact merge over the interim stays. The logic I implemented is flawed and only works for the final ICU stay for a given hospitalization, so the ICU stay before an in-hospital ICU readmission will incorporate ward stays when it shouldn't. I implemented a fix for this that will be included the next version of MIMIC-IV.

Thanks for the quick follow-up and the detailed explanation.
Two further questions:

Does this also explain the problem with the missing icustay I added at the end of my comment?
When do you plan to release the fix? Sorry for being impatient, but I need to decide if its worth to implement my own routine to determine the right stays for my experiments. From my experience these selection methods are very error-prone and I'd rather re-use your code.

Thanks for the quick follow-up and the detailed explanation.
1. Does this also explain the problem with the missing entry in `icustays` I added at the end of my previous comment?

Yes! Same issue.

2. Is the code for generating `icustays` from the `transfers` table available somewhere?

Not publicly but I'll describe the rough process in the new release.

3. When do you plan to release the fix? Sorry for being impatient, but I need to figure out if its worth to implement my own routine to determine the stays for my experiments. From my experience, these selection routines are very error-prone and I'd rather re-use your code.

Just being reviewed at PhysioNet - so pretty soon (within the month). Trying to clean up a few of the other issues around transfers/admissions/icustays being a little bit inconsistent.

This is now fixed in MIMIC-IV v1.0: https://mimic-iv.mit.edu/docs/overview/changelog/#mimic-iv-v10
For example the hadm_id you provided @stefanhgm -
select * from mimic_core.transfers where hadm_id = 28662225 order by intime

Row
subject_id
hadm_id
transfer_id
eventtype
careunit

1
10002428
28662225
32007337
ED
Emergency Department

2
10002428
28662225
38519116
admit
Medicine

3
10002428
28662225
37824512
transfer
Emergency Department Observation

4
10002428
28662225
33987268
transfer
Medical Intensive Care Unit (MICU)

5
10002428
28662225
32875370
transfer
Medicine

6
10002428
28662225
38875437
transfer
Medical Intensive Care Unit (MICU)

7
10002428
28662225
30025354
transfer
Medical Intensive Care Unit (MICU)

8
10002428
28662225
38277070
transfer
Medical Intensive Care Unit (MICU)

9
10002428
28662225
31606213
transfer
Medicine

10
10002428
28662225
37069433
discharge
null

... is now properly associated with two ICU stays:
select * from mimic_icu.icustays where hadm_id = 28662225 order by intime

Row
subject_id
hadm_id
stay_id
first_careunit
last_careunit

1
10002428
28662225
33987268
Medical Intensive Care Unit (MICU)
Medical Intensive Care Unit (MICU)

2
10002428
28662225
38875437
Medical Intensive Care Unit (MICU)
Medical Intensive Care Unit (MICU)

Note the stay_id is identical to the first transfer_id - this will always be the case when multiple transfers are merged into a single stay_id. Note though as there is no flexibility in the assignment, I've found cases where a 3 minute ward stay breaks up the stay_id (i.e. MICU -> Medicine for 3 minutes -> MICU results in distinct stay_id for the MICU stays). Just something to keep in mind!


Change dcos/dcos submodule to public HTTPs git URL

The URL given to the submodule dcos/dcos is the one used with the SSH key. However this causes issues when simply trying to clone recursively the repository dcos/dcow-windows with the public HTTPs URLs.
Usage example: http://paste.openstack.org/show/m3yyrOvOcrNisp3Cq3aV
It makes more sense to simply have the public URL for the submodule as well, since that submodule repository is also public.

@yakman2020, please review this.


Should we introduce a "when cloud variable updates/changes" hat block?

In discussions about cloud vars, users have expressed desire for an easier, more straightforward way to take action when a cloud var has changed.
This can be done using various patterns -- e.g., use a local variable to mirror the cloud variable, and have a forever loop check the cloud value against the local value.
But a "when cloud variable updates/changes" hat block would greatly simplify this.
Could be easier to do after/as part of moving cloud variables into an extension (see https://github.com/LLK/scratch-blocks/issues/1889 )

This reminds me of an extension I made a couple days ago:

Thoughts on implementing an extension like that instead of this block? Obviously it would work nicely with cloud variable blocks, so I think it would be an interesting way to encourage users to mix and match extensions so that they work together.
(The overall benefits to my extension are that it's very generally useful, both practically and educationally; I just think it fits extra well with cloud variables as discussed here.)


Cannot load filters from disk in branch setup_cleanup

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).

If you try to compute_filters() on a data object where they already have been computed and stored in HDF5 file, for some reason the code tries to construct a Filter() object anyway and uses an unassigned variable name:
#!python

UnboundLocalError                         Traceback (most recent call last)
<ipython-input-1-abd318541669> in <module>()
----> 1 import ppp_paper as ppp; data=ppp.load(); ds=data.channel[209]; g=ds.good()

/Users/fowlerj/Microcal/Tupac_analysis/Riken_calibration_metals/ppp_paper.pyc in load(channels, massname, reset_bad_channels)
     77     data.avg_pulses_auto_masks()
     78     data.compute_noise_spectra(1000)
---> 79     data.compute_filters(f_3db=5000)
     80     data.filter_data()
     81     data.drift_correct()

/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/mass/core/channel_group.pyc in compute_filters(self, fmax, f_3db, forceNew)
   1139                 print("chan %d skipping compute_filter because already done, and loading filter" % ds.channum)
   1140                 h5grp = ds.hdf5_group['filters']
-> 1141                 ds.filter = Filter(avg_signal, self.nPresamples-ds.pretrigger_ignore_samples,
   1142                                    spectrum, ds.noise_autocorr, sample_time=self.timebase,
   1143                                    fmax=fmax, f_3db=f_3db, shorten=2)

UnboundLocalError: local variable 'avg_signal' referenced before assignment

Can you restore this to its former behavior? Can't merge this to master if it won't load filters from HDF5 file! @oneilg  might be able to help.

Original comment by Young Il Joe (Bitbucket: jojo978, GitHub: jojo978).

I fixed this problem (avg_signal => ds.average_pulse, spectrum => ds.noise_spectrum). I tested this and it worked but I don't understand why it worked before.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

p.s. Note that I committed a small change this morning about the .gitignore file. You should pull that before working on this.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Okay, now I have a new one.
#!python

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-1-abd318541669> in <module>()
----> 1 import ppp_paper as ppp; data=ppp.load(); ds=data.channel[209]; g=ds.good()

/Users/fowlerj/Microcal/Tupac_analysis/Riken_calibration_metals/ppp_paper.pyc in load(channels, massname, reset_bad_channels)
     77     data.avg_pulses_auto_masks()
     78     data.compute_noise_spectra(1000)
---> 79     data.compute_filters(f_3db=5000)
     80     data.filter_data()
     81     data.drift_correct()

/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/mass/core/channel_group.pyc in compute_filters(self, fmax, f_3db, forceNew)
   1140                 h5grp = ds.hdf5_group['filters']
   1141                 ds.filter = Filter(ds.average_pulse[...], self.nPresamples-ds.pretrigger_ignore_samples,
-> 1142                                    ds.noise_spectrum[...], ds.noise_autocorr[...], sample_time=self.timebase,
   1143                                    fmax=fmax, f_3db=f_3db, shorten=2)
   1144                 ds.filter.peak_signal = h5grp.attrs['peak']

AttributeError: 'MicrocalDataSet' object has no attribute 'noise_spectrum'

Original comment by Young Il Joe (Bitbucket: jojo978, GitHub: jojo978).

But it doesn't check that average pulses are already calculated and stored in the HDF5 file. Maybe I should put more dependency check there.

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Bug fix in instantiating Filter from HDF5 data. Fixes #26

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Bug fix in instantiating Filter from HDF5 data. Fixes #26


Fix the git commit messages hash link

...because the title was changed, probably. :smile:

Thanks!


fix(bundling) Remove parse5 dependency.

This builds on the work done in #652 (and obsoletes it).
Delete the parse5_adapter module. Create a dummy DOM adapter and
register it for that code (cough @angular/router cough) that
logs diagnostic messages via the DOM adapter.
Register the DOM adapter dynamically, if and only if you can
discover @angular/platform-browser.
Hopefully one day @angular/router and @angular/http won't import
@angular/platform-browser and we can strip it from the release
bundle completely.
NOTE: Bundled production builds that have router tracing enabled will continue to crash. That seems like the reasonable tradeoff with removing the @angular/platform-browser dependency. Router tracing should be disabled in production builds anyway.

@hdeshev @vakrilov does this mean we won't have to use .html for view templates any longer and could just use .xml?

@NathanWalker No. .html as usual -- the DOM adapter wasn't being used (most of the time) anyway.

Ok good to know - just checking, thanks 👍


Unsupported post request. Object with ID 'xxxxxxxxxx' does not exist

I am not sure how to solve this error. I just started using this repository today and I am very new to the WhatsApp API/Facebook Developer Ecosystem.

Hello,
We can't help you if you don't provide more information about your problem. What did you try to do? Which information did you try to send to the Cloud Api?
Thanks.

I no longer get that error.
I found the phone number ID on the following page:
https://developers.facebook.com/apps/xxxxxxxxxx/whatsapp-business/wa-dev-console/?business_id=xxxxxxxx
Afterwards, I tried to send a message using the following script:
<?php

// Require the Composer autoloader.
require 'vendor/autoload.php';

use Netflie\WhatsAppCloudApi\WhatsAppCloudApi;

// Instantiate the WhatsAppCloudApi super class.
$whatsapp_cloud_api = new WhatsAppCloudApi([
'from_phone_number_id' => 'xxxxxxxxx',// https://developers.facebook.com/apps/xxxxxxx/whatsapp-business/wa-dev-console/?business_id=xxxxxxx
'access_token' => 'xxxxxxxx', //How to get Permanent Access Token in WhatsApp Cloud API - https://www.youtube.com/watch?v=gqiBzFlF44c
]);

$whatsapp_cloud_api->sendTextMessage('+18764586888', 'Hey there! I\'m using WhatsApp Cloud API. Visit https://www.netflie.es');

?>

PLEASE NOTE- The from_phone_number_id and access_token values have been removed from the code snippet for security purposes.
When I run the code at the following url: http://localhost/whatsapp_api/  I don't get a message on my phone and the screen is blank.

WhatsApp Cloud Api doesn't allow start a conversation with a simple text message. You have to start a business-initied conversation sending a template: https://developers.facebook.com/docs/whatsapp/pricing/. Please, read and understand the Facebook Documentation before use this PHP client.

I wasn't trying to send a template. According to WhatsAppCloudApi.php there are various functions one of which is SendTemplate() but I was using sendTextMessage().

So after you send a template you will be able to start sending simple text messages?

Unsupported post request. Object with ID 'xxxxxxxxxxxxxxxxxx' does not exist, cannot be loaded due to missing permissions, or does not support this operation.
I still get this error. Please any solution or suggestion. I am sending a message templet but i get this error


add key for GStreamer plugins for GL

Provides the library libgstopengl.so for gstreamer GL plugins

Arch: https://archlinux.org/packages/extra/x86_64/gst-plugins-base/
Debian: https://packages.debian.org/sid/gstreamer1.0-gl
Fedora: https://src.fedoraproject.org/rpms/gstreamer1-plugins-base
Ubuntu: https://packages.ubuntu.com/bionic/gstreamer1.0-gl

@mabelzhang thanks for catching the inconsistency with the quotes. fixed in 30527cb

@mabelzhang thanks for catching the inconsistency with the quotes. fixed in 30527cb

@zflat Thanks for iterating!


IFrames in HTML

Description
Describe more about the issue.
Doc Domain

[ ] Html
[ ] CSS
[ ] JavaScript
[ ] Bootstrap

Are you contributing under any open-source program ?
hacktoberfest

I want to work on this issue!!

describe more about the issue and doc domain

@girija0707 i want to work on this issue


Exception when selecting a game in GarlicPress.0.0.2308.121

Describe the bug
Exception is thrown when selecting a game on SD Card 2 (Card 1 not tested), unable to access \assets\tempimg.png.  Tested by running GarlicPress normally, and as administrator on Windows 11.
To Reproduce
Steps to reproduce the behavior:

Connect to device
Select SD Card 2
Select a system (I used different ones, but GBA, GBC, etc all reproduced)

Result:  Exception:
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

I can't replicate this issue sorry.
Wondering if as your running the app from the desktop onedrive is trying to sync it?
can you try extracting and running it from another path?

Moved to program files, but the same behavior remains.  I also tested on another Win 11 system, and could still reproduce.  Tried turning off my antivirus (Bitdefender), no difference.
My SD card 2 has folders at the root:
H:\Roms\GBA\files.zip
H:\BIOS\gba_bios.bin
H:\Saves
etc.
I should not, I had the previous version of GarlicPress installed and none of the files were appearing when selecting the drive and systems.

If I do a search in ProcessExplorer for the file after the assert appears, I see:

The  entry appears a second or two after the GarlicPress.exe entry shows up.

And here's the process monitor output when filtering on garlicpress and tempimg.png:
12:01:00.4759965 PM	GarlicPress.exe	35248	CreateFile	C:\Program Files\GarlicPress\assets\tempimg.png	SUCCESS	Desired Access: Read Attributes, Disposition: Open, Options: Open Reparse Point, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened
12:01:00.4760438 PM	GarlicPress.exe	35248	QueryNetworkOpenInformationFile	C:\Program Files\GarlicPress\assets\tempimg.png	SUCCESS	CreationTime: 8/11/2023 11:50:57 AM, LastAccessTime: 8/12/2023 11:57:15 AM, LastWriteTime: 8/12/2023 11:53:51 AM, ChangeTime: 8/12/2023 11:53:51 AM, AllocationSize: 167936, EndOfFile: 163943, FileAttributes: A
12:01:00.4760563 PM	GarlicPress.exe	35248	CloseFile	C:\Program Files\GarlicPress\assets\tempimg.png	SUCCESS
12:01:00.4761785 PM	GarlicPress.exe	35248	CreateFile	C:\Program Files\GarlicPress\assets\tempimg.png	SHARING VIOLATION	Desired Access: Read Attributes, Delete, Disposition: Open, Options: Non-Directory File, Open Reparse Point, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a

One final note, if I quit GP, delete the tempimg.png file, relaunch and go into SD Card 2 / GBA, I see the following in process monitor:

And the tempimg.png file is created with the Advance Wars image (my first rom), though not displayed in GP, but that may be normal?
Selecting another rom gives the assert and file access issues as reported above

I second this issue. I noticed in the exception details, there seems to be a hardcoded folder path, featuring a the username, "ashle". This does not match my windows username, of course. Please find my exception details below. Thank you!

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
 I will do some more digging. Issue seems to be related to supporting rom files inside the root of the second SD.
Some have setup the second SD cards with /GB/rom.zip instead of /Roms/GB/rom.zip  This then creates an issue as images still need to be in /Roms/GB/Imgs/rom.png and by me adding support for that I have somehow broken support for people with roms No on the root like yourself.
I will take a closer look now.

I can make it do it now.
It does not happen when I run it in debug mode in Visual Studio only when in Release builds.
Getting Closer!

The error happens with SD 1 or 2! I have no idea why this is happening now!

I worked it out. Building a new release now


Expose code_private_function as separate voice command

Currently the only way to call code_private_function is indirectly via code_default_function (except for R).
This poses a few problems:

Python and Scala override code_default_function to call code_public_function. This currently makes it impossible to use their code_private_function implementations without adding a custom voice command.
The Java implementation of code_protected_function creates a method without any modifiers, which is confusing.

It should insert the protected access modifier, but then there would be no way to insert a method with no access modifiers (i.e. a package-private method, distinct from protected).
As a workaround, one can say state protected, pause, then pro funky ..., but this is clearly inconsistent and disrupts the flow.

I would like to propose the following:

a new private funky <text> command, which calls code_private_function
a new action code_default_static_function, to be called by static funky <text>, can default to calling code_private_static_function
a new private static funky <text> command, to replace current usage of static funky <text>

This would allow for:

Java: creating methods with all possible access modifiers (including package-private and protected) using the commands in functions.talon
TypeScript: creating functions outside methods, whilst still being able to create private methods (see also #824)
Python/Scala: actually creating private functions

This sounds good to me.

What might be nice is the following:
{user.function_modifier}+ funky <user.text>: user.code_function(function_modifier_list, text)

Then there could be a default implementation
    def code_function(modifier_list: list[str], text: str):
        """Inserts function declaration"""
        formatted_text = actions.user.formatted_text(
            text, settings.get("user.code_function_formatter")
        )
        modifier_string = " ".join(modifier_list)

        result = f"{modifier_string} function {formatted_text}"

        actions.user.code_insert_function(result, None)

Individual languages could then override the implementation to look at modifier_list and choose a different formatter / use different template for the function
Definitely a different approach, but figured I'd throw it out there.
It is related to #807

I actually really like pokey's suggestion. It opens this up to more keywords like async, and even putting in return types depending on the language. To facilitate all that we'd probably make function_modifier a capture instead of a list.
The complexity of the extra abstraction could be offset by defining a 'standard' way of ordering modifiers as well as a standard list of command words. Something like this in the .talon file:
# This command is used for inserting a function definition with modifiers (e.g. private, protected, async) or return types.
# Since this gives a lot of flexibility, it could also make usage vary unnecessarily between programming languages.
# To encourage consistency consider the following guidelines:
#
# * Use these names for modifier labels: pro -> protected, pub -> public, static, private, async
# * The order of modifiers should be this: visibility (private, pro), other (static, async), return type (int, bool).
#
# So with the above in Java you might be able to say 'private static void funky hello world' to get 'private static void helloWorld()'

Another bonus would be removing irrelevant commands from the grammar, which should theoretically improve recognition. I'm on board.

The complexity of the extra abstraction could be offset by defining a 'standard' way of ordering modifiers

Not sure I follow. If we use a + after the list (or capture), then the order shouldn't matter

Yeah, if we use the + that would be true. We probably don't need the comments about ordering in that case.

This should be covered off by #879 . Closing issue.


Error "SignatureDoesNotMatch". Google Cloud Storage Bucket PUT.

I'm loosing my mind.
I'm using Shrine (https://github.com/janko-m/shrine) with Google Cloud Storage (https://github.com/renchap/shrine-google_cloud_storage), but when I start the PUT call I get this:
<Error>
SignatureDoesNotMatch
<Message>
The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.
</Message>
<StringToSign>
PUT
image/jpeg
1518399402
/mybucket.appspot.com/7d5e4aad1e3a737fb8d2c59571fdb980.jpg
</StringToSign>
</Error>

I followed this info (http://shrinerb.com/rdoc/classes/Shrine/Plugins/PresignEndpoint.html) for presign_endpoint, but still nothing:
class FileUploader < Shrine
  plugin :presign_endpoint, presign_options: -> (request) do
    filename     = request.params["filename"]
    extension    = File.extname(filename)
    content_type = Rack::Mime.mime_type(extension)

    {
      content_type: content_type
    }
  end
end

I tried with and without this (restarting the Rails server everytime).
Where am I wrong?
I also tried with Postman with a PUT to that URL and withtout any content-type. But still nothing.
I read here: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1976 and here: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1695
How can I try without Rails?
Is there a REPL (or similar) to try with my credentials and with a file?

Closing this one in favour of https://github.com/renchap/shrine-google_cloud_storage/issues/22, as this appears to be a bug with shrine-google_cloud_storage, not Shrine itself.

Maybe dear @janko-m after all this (https://github.com/renchap/shrine-google_cloud_storage/issues/22) you can take a look?

I can't find "content_type" in this file: https://github.com/janko-m/shrine/blob/master/lib/shrine/plugins/presign_endpoint.rb. Is it normal?

@johnunclesam Yes. :content_type is a presign option that's specific to the underlying storage. S3 and GCS both support a :content_type option, but for example Cloudinary does not. Shrine's presign endpoint doesn't have any knowledge about which kind of presign options you're constructing, it just forwards whatever options you specified to the Shrine::Storage#presign call, and then the storage takes it from there.
Nothing in this issue indicates a problem with Shrine itself, especially because in https://github.com/renchap/shrine-google_cloud_storage/issues/22 you showed that you have the same issue when using Shrine::Storage::GoogleCloudStorage#presign directly, which doesn't use any code from this repository whatsoever.
An issue with Shrine would be presign_endpoint misbehaving, but there is nothing that would indicate this; moreover, you were able to reproduce the issue without using the presign enpdoint. That's why I closed the issue here, because this problem is 100% related to shrine-google_cloud_storage, so it makes more sense to triage it there.

No, @janko-m. I have the problem just with presign_endpoint. In fact now my workaround is to use Shrine.storages[:cache].presign directly.
I strongly think the problem is with content_type but I can't help the seach more, unfortunately I'm newbie!

@johnunclesam The issue is that shrine-google_cloud_storage doesn't return the corresponding Content-Type header in the presign object. I opened https://github.com/renchap/shrine-google_cloud_storage/pull/23 which adds the request headers required for the upload, which will then automatically be returned by the presign_endpoint, and then on the client side they should be added to the request headers for the upload.

No, @janko-m. I have the problem just with presign_endpoint. In fact now my workaround is to use Shrine.storages[:cache].presign directly.

Just to re-iterate, the same problem appeared when using Shrine::Storage::GoogleCloudStorage#presign directly, and even when using the bare google-cloud-storage gem (without shrine-google_cloud_storage). So it indeed wasn't a problem in Shrine's presign_endpoint, as it only exposes the information that Shrine::Storage#presign returns 😉


chore: release 1.2.26

:robot: I have created a release *beep* *boop*
1.2.26 (2021-10-08)
Features

build: enable static CGO builds for linux (fbf4877)
build: static CGO build (463a148)

Bug Fixes

spelling (994af88)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.26 :sunflower:


adapt to tjbot node-red nodes

Added changes so TJBot Node-RED nodes will continue working with tjbot lib 2.0.2

Closing due to being out of date in relation to the latest updates


Delete old deprecated badges

Fixes #6514.

Messages

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against 6b4f7096a834ea8d8fca62f76878762bea8f0046


compromise between row select and expandability.

This might prove an awesome repo for me if the following is either do-able right now, or possible:
Show a set of rows, some expandable, some not BUT, expansion only occurs if the + button is tapped. Selection of the row itself should be as normal.
I will dig through the code to see if i can figure out if this is implemented.

You can clone and change didSelectrow to other function. Thanks!


Link to  "Configurable Language and Cultural Settings" is broken.

It links to http://go.microsoft.com/fwlink/?LinkID=242307, but content is not found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58bcd6e9-7aee-ec93-4707-3207d0166ea6
Version Independent ID: beb3e794-eaad-4f56-175c-73f07fc19a39
Content: Set-Culture (international)
Content Source: docset/windows/international/Set-Culture.md
Product: w10
Technology: powershell-windows
GitHub Login: @andreabarr
Microsoft Alias: v-anbarr

Closing via #1860


[Question]: Use triplets directly

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hey all!
I have text files with triplets like:
John, is, Male
John, is, 56
Emily, isDaugther, John
Emily, is, 16
etc.

Can I use that directly to build the knowledge graph index without converting it to RDF or Neo4J format?

I mean, they need to be in some kind of format to build the index.
There's a section here that shows building it from existing triplets
https://docs.llamaindex.ai/en/stable/examples/index_structs/knowledge_graph/KnowledgeGraphDemo.html#id1

Thanks @logan-markewich! What I didn't really get is this part:
nodes = node_parser.get_nodes_from_documents(documents)
Is that just a file with the "node" names? and then the code you linked to established the edges for each node?

I namely have a knowledge graph already, nodes and their relationships, so not really documents I have to search through.


Amex cards

Hi,
Having a bit of trouble identifying American Express cards.  As well as my real card number some of these test amex numbers dont seem to work:
http://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm

Hi @adamskinner
When making such claims please provide a link to a demo (CodePen, JSFiddle, etc). I really don’t have the time to test all reported supposedly not working numbers.
By looking at the link you’ve provided, these numbers should work. They start with 37 and are 15 digits long — definitely supported.
I’ll happily look into it if you can link to a demo that shows these numbers aren’t recognised.

Hi @PawelDecowski
Sorry - your quite right. Amex card do work.
I had an error in my code and then tried your main website (http://jquerycreditcardvalidator.com/)
Because an amex card graphic didn't come up - I wrongly assumed it was broken.
Regards
Adam

Hi @adamskinner
You weren’t the only one to assume something was broken because the demo doesn’t support all the cards that the plugin supports. In the most recent update I included a help text under the CC field that says which cards are supported by the demo. Hopefully that will help avoid confusion!


Cannot find the proper candidate when the scope resources have same resource type

In GuestConfiguration, we have these three resources:
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/{guestConfigurationAssignmentName}
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HybridCompute/machines/{machineName}/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/{guestConfigurationAssignmentName}
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachineScaleSets/{vmssName}/providers/Microsoft.GuestConfiguration/guestConfigurationAssignments/{name}

They extend from different resource but have the same resource type, aka Microsoft.GuestConfiguration/guestConfigurationAssignments. In such case, the generator will find more than one candidate for the list method and the generation will fail.

Fixed in https://github.com/Azure/autorest.csharp/pull/2633


Feature/num 2025 cleanup old eps without pagination

NUM - 2025 remove old EP for get organizations, get/search users, get projects, get aql categories and aql queries that do not support pagination

NOTE : please do not merge this PR yet. First, all FE tasks related to pagination should be done. Thanks!


Reformatted Mapzer

Motivation and Context
When travis attempted to build a release it failed because the formatter decided Mapzer.java had the wrong kind of blank line in it.
What has changed
Mapzer.java has been reformatted
How to test?

check out branch
mvn clean install
ensure that there are no local modifications

Links

failed travis build

Please explain

Adding mvn fmt:check will fail the build preventing merging


ERROR: Request Error: {query} - Connection Lost - Read ECONNRESET [mssql]

Environment
Knex version: "knex": "^0.19.1",
Database + version: MSSQL (Azure)
OS: Unbuntu
Select applicable template from below.
@smorey2
Bug

Explain what kind of behaviour you are getting and how you think it should do

I have a base64 image which i store, when i was developing on windows, this worked without issue, now what I am running it on Unbuntu (re-installing from package.json) i get this error on only 1 route, and only 1 query.  All of my other writes/reads to the DB work without issue. It is also the largest insert by far.

Error message
[/saveDelivery] ERROR: RequestError: insert into [driver_CompletedDeliveries] ([amtItems], [bins_recovered], [deliveryTime], [driverID], [imgDataBase64], [moneyCollected], [signeeName], [targetID], [type]) values (@p0, @p1, @p2, @p3, @p4, DEFAULT, @p5, @p6, @p7) - Connection lost - read ECONNRESET
Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to MySQL or PostgreSQL, then single file example which initializes
needed data and demonstrates the problem.
``

router.post('/saveDelivery', async (req, res) => {
const knex = req.app.locals.knex; //This is my knex instance.
const { clientID, Image, Amount, Signee, Time, Type, Money, PickedUp } = req.body;
if (!req.session.driverID) {
    res.send({ success: false, message: 'You must be logged in, and a driver to save deliveries.' });
}
const dt = new Date(Time).toISOString().slice(0, 19).replace('T', ' ');
try {
    await knex('driver_CompletedDeliveries')
        .insert({
            type: Type,
            targetID: clientID,
            bins_recovered: PickedUp,
            amtItems: Amount,
            imgDataBase64: Image,
            signeeName: Signee,
            deliveryTime: dt,
            driverID: req.session.driverID,
            moneyCollected: Money
        });
    res.send({ success: true, message: 'Delivery Saved successfully!' });
} catch (err) {
    console.error('[/saveDelivery] ERROR: ${err}');
    res.send({ success: false, message: '[/saveDelivery] Error Saving: ${err}' });
}

});
``
Ultimately:  When i do this request on my dev-station (windows 10, with same package.json) it works without issue.  When I moved it to production it started having this issue, in this one route, there are about 30 other routes which use all the CRUD features to the same database, and tables.  This is the only one that has the issue.  If i console log the req,body it does have the fields (i suspected it may have been a post payload size issue, it wasnt).
Has anybody seen this before?  This is my connection string
const knex = require('knex')({
    client: 'mssql',
    connection: {
        server: 'THEDATABASE.database.windows.net',
        user: 'USER',
        password: 'PASSWORD',
        database: 'da',
        options: {
            port: 1433,
            encrypt: true  // mandatory for microsoft azure sql server
        }
    },
    pool: { min: 2, max: 10 }
});
app.locals.knex = knex; //Put Knex on req.app.locals.knex

Any ideas?!  Anything more you would require to see?
Package.json

"knex": "^0.19.1",
    "mssql": "^5.1.0",

Oh, also for clarification, the payload size of the base64 Image is about 8k  (only)

When I run the same code in RunKit, it generates the same error!

Further update, I re-installed on two new servers. 1 Windows Server 2019. Installs and runs 100%. Installed on Unbuntu 18.04 Fresh, gives same error.
This is now making me suspicious it may be a low level driver or library that is used by Knex, as the windows binary/library/whatever works and the Linux one does not. Side by Side, the win32 works, the Linux does not.
Could this be a issue with Tedious or mssql in general?!

@andrew-caines Are you positive that there are no network/connectivity issues that prevent Ubuntu from connecting? Error itself looks like something that you would get when server itself is refusing connection, before DB itself kicks in. Can you try connecting to DB directly using Linux mssql cmdline client from Ubuntu in question and see if that works?

If it does work, and problem is only on that one query, it does sound like a low-level issue, as knex delegates pretty much all the down-to-metal stuff to driver in question, so node-mssql might be a good place to start investigation.

All queries work, until the size of the payload is over 4096 bytes, the moment it hits 4k, it breaks.  Basically, when i have some Base64 (varchar(MAX)) data to the server it breaks, i know its 4096, because if i send 4097 it gives the error, 4096 it doesn't.
Like i said, wierdly, on Windows it doesn't throw this error. Something about the base library that knex uses on linux?

You should try to reproduce your problem using mssql (or tedious) driver directly and ask help from their forums. This is certainly not caused by knex.

@andrew-caines did you solve this issue? If yes! what was the solution?


Create redirects for NuGetAudit NU codes

I created a single NU1901-NU1904 page, rather than creating 4 separate pages.
But clicking on one of these NU codes in VS' Error List window takes you to a 404. This PR tries to fix: https://github.com/NuGet/Home/issues/13321

@JonDouglas  @Mikejo5000 When I try to open the preview URL, it tells me I don't have access. Am I supposed to request access to something now, or is there a bug and all MSFT employees are supposed to have access, like before?

@JonDouglas @Mikejo5000 When I try to open the preview URL, it tells me I don't have access. Am I supposed to request access to something now, or is there a bug and all MSFT employees are supposed to have access, like before?

I have the same problem.

I have access now, so it looks like it was a temporary issue. However, the redirect isn't working: https://review.learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1901?branch=pr-en-us-3265
I don't know if redirects don't work on the reviews site, or if there's something wrong with my PR.  @Mikejo5000 @JonDouglas can someone help me, please?


Fix timeout for http client (6.x)

See https://github.com/elastic/elasticsearch-net/issues/6062

Thanks for this PR @aldobrynin. While CI is failing, the core tests run fine locally for me, so I'll go ahead and merge this. I'll schedule this into a patch release ASAP.


Notation for the central charge.

In the series of fusion rings, we (will) often make the link to CFTs, and their central charge (not modulo 8)
The central charge from the anyon models is 'only' defined modulo 8. I propose to call the latter the 'topological central charge', denoted by $c_{\rm top}$. Then we can use 'central charge', denoted by $c$ for the 'ordinary' central charge.

Sounds fine to me :)
Maybe we should, in the future, also make a page about central charge and another one about CFT

sounds good


in #2135 we removed the ical nodejs module, as the default modules don't need it. but 3rd party calendar modules may.

I'm not sure if this is a bug
should we keep it to support those other calendar modules?

That's an interesting point. I would say: just keeping removed. But let's see what the forum users say.

How about leaving ical in there but add a warning notice, that it will go away with 1.1.2021 ?

Yeah, that sounds like a reasonable idea.

Closed, since we merged the solution. Thanks Sam!

see https://forum.magicmirror.builders/topic/13745/warning-warning-2-13-advisory-calendar-module-changes


feat(typescript):alias import for codegen

Closes #

Support for typescript codegen using aliasing import
Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

coverage: 98.778% (+0.005%) from 98.773%
when pulling f2c6d632a98151845d37e1c911fa9b5db3b116bc on salujajaskeerat:sahib/typescript-alias-import
into e4968a6c32e5b880eb6c317cbf27e59c2243f74b on accordproject:main.


Consider integrating this project into main sirthias/borer repo

This makes #11 less important ;) since this project might be moved into serializer-akka sbt module of borer project.

Realistically, I think that the extra codecs should go directly into Borer indeed, but the serializer should stay in the repo... esp. once it includes a dedicated compiler plugin, it'd be too loosely related to Borer to merit keeping it in the same repo.


added support for 96 x 96 ssd1351 mikroe board

added support for 96 x 96 ssd1351 mikroe board
framebuffer was mirrored and viewport was misaligned.
all examples work on the mikroe OLED C click using this driver.

@rm-hull can you put out a new release?

@thijstriemstra: not sure about layout changes made in 3e09ec7 - find it a bit hard to digest when the comments are stacked above each line. Any objections if I change that back?

Also it looks like (at least for now) that settings['displayoffset'] and settings['startline'] are both invariant, and we could just use 0x00 for both. Indeed, the settings['height'] and settings['width'] could also be replaced with height-1 and width-1.
        # Set column address
        self.command(0x15, settings['displayoffset'], settings['width'])
        # Set row address
        self.command(0x75, settings['displayoffset'], settings['height'])

becomes:
        self.command(0x15, 0x00, width - 1)   # Set column address
        self.command(0x75, 0x00, height - 1)  # Set row address

Actually, is width=0x6F a mistake in https://github.com/rm-hull/luma.oled/pull/192/files#diff-5cdd2e38808395886cb0470afe406f72R344 ? 0x6F is 112 decimal ... should that be 0x5F (95 decimal)


Use bytes.Buffer for string concatenation to improve performance

Ran into a performance issue when trying to serialize large nested data. Changing the code to use a bytes.Buffer for string concatenation helped speed up the performance.
For example:
// build up ["VALUES": ["ID_0": 0, ..., "ID_9999": 9999]]
subData := php_serialize.PhpArray{}
data := php_serialize.PhpArray{
	"VALUES": subData,
}

for i := 0; i < 10000; i++ {
	subData["ID_"+strconv.Itoa(i)] = i
}

startTime := time.Now()
php_serialize.Serialize(data)
log.Printf("Time took: %s", time.Since(startTime).String())

Before: ~2s
After: < 15ms

@hathos thank you a lot for your contribution!


Added list name on product summary page

Related issues and discussion
#fixes #2250
Screen-shot

Can you move it to below the Nova/Nutri-Score ?
Also, I was thinking of a perhaps colored chip design with numbers (different PR)

@prashantkh19 can you take another look at this?

We can ship it without a fancy UX if it's stable.

Ok, merging then 👍
Thanks a lot @prashantkh19


Investigate performance of anonymous usage statistics requests

Describe the bug
Telemetry data is being sent to fishtownanalytics.sinter-collect.com on dbt run. The speed of dbt run improved to 17 sec from 111sec (~2min) for about when the domain was blackholed (pointing to <IP_ADDRESS>)
Expected behavior
When disabled telemetry:
Finished running 100 view models, 2 table models in 16.80s.

When enabled telemetry:
Finished running 100 view models, 2 table models in 111.62s.

Each request to the telemetry server is taking about 1second. For 100 view models, its adding additional 100 seconds or 1 second per run.
The output of dbt --version:
installed version: 0.15.0
   latest version: 0.15.0

Up to date!

Is there a way to disable telemetry via commandline or via env variable?

hey @sairam - check out the docs for disabling anonymous usage statistics here: https://docs.getdbt.com/docs/configure-your-profile#section-usage-statistics
I'm surprised to see this is ballooning your dbt runtime - we coded this such that a single failed event request would prevent future requests from being made. Let me take a deeper look here - the behavior you're seeing is not right.

Thanks for the link, I initially searched for telemetry and analytics, but could not find the right config.
config:
  send_anonymous_usage_stats: False

@drewbanin , feel free to close this issue.

I wanted to share that this was run with 1 thread.
Looks like a request to a remote server is happening after each view/action is done which explains close to 100second delay. Changing the location to edge endpoint may help instead of us-east-1.

Ok - that's not right - 1 second is far, far too long for these individual requests. I'll leave this issue open to investigate adding edge endpoints, batching the requests, or making the requests async. They actually used to be async but we had issues with the thread not being cleaned up and it causing dbt to hang. Thanks again for bringing this one to our attention.

would it possible to have a dedicated thread just for sending out the analytics?

Yep, that's totally possible. Alternatively, we could try batching these events and sending more of them at once. The payloads are pretty tiny (timestamps, the command that was run, etc) - the really slow thing here is just the round-trip to us-east-1 I think.

Fixed in #2089


HADOOP-18088. Replace log4j 1.x with reload4j. (#4052)

Cherrypick of two patches from branch-3.3, as the 3.4/trunk branches are still on log4j 1.x
HADOOP-18088. Replace log4j 1.x with reload4j. (#4052)
HADOOP-18354. Upgrade reload4j to 1.22.2 due to XXE vulnerability (#4635
Compilation works; lets see what yetus says.
I'm also doing local release build to make sure there are no log4j 2 artifacts being pulled in as part of dependencies -looks like mockito-core and cosmos-db pull them in somehow
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

full clean build with this and there are no log4j jars on the classpath
> find hadoop-dist/target/hadoop-3.5.0-SNAPSHOT -print | grep log

hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/libexec/tools/hadoop-archive-logs.sh
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/libexec/shellprofile.d/hadoop-archive-logs.sh
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/etc/hadoop/httpfs-log4j.properties
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/etc/hadoop/kms-log4j.properties
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/etc/hadoop/yarnservice-log4j.properties
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/etc/hadoop/log4j.properties
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/hadoop-archive-logs-3.5.0-SNAPSHOT.jar
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/sources/hadoop-archive-logs-3.5.0-SNAPSHOT-test-sources.jar
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/sources/hadoop-archive-logs-3.5.0-SNAPSHOT-sources.jar
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/sls/sample-conf/log4j.properties
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/yarn-service-examples/appcatalog
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/yarn-service-examples/appcatalog/appcatalog.json
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/hadoop-yarn-applications-catalog-webapp-3.5.0-SNAPSHOT.war
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/common/lib/commons-logging-1.1.3.jar
hadoop-dist/target/hadoop-3.5.0-SNAPSHOT/share/hadoop/hdfs/lib/commons-logging-1.1.3.jar

Incidentally, as this is a backport I don't need a vote from anyone but myself :-)
just making sure it is good


Add iOS support

Lots to do with the docker containers still. Will need further debugging, but tor fails to build for aarch64 with a link error (think I need to write a C wrapper for ld.

Moved to https://github.com/05nelsonm/kmp-tor-resource


new folder

this one bme
Description

[ ] I have added a folder(Named it as my GitHub user id)
[ ] I have added a Readme.md file inside the folder
[ ] I understand the GitHub Forking Concept fully

new folder created


Flags fully saturated pixel columns as DO_NOT_USE

Issue Addressed
This PR addresses Issue #597 in which columns that were fully saturated (the first group already saturated) were still being used in Stage 3 and saturation was being manually removed from the first group if found.
Fix Introduced
From conversations with @erinmay the best fix seemed to be to get rid of the portion of the code that removed saturation from the first group, as well as mark any columns that are fully saturated as DO_NOT_USE. And with @cicanas help to understand JWST flagging I was able to brainstorm a path forward for this by establishing a similar condition check to what was already established for partial saturation but for full saturation.
Elegance
I tried to keep the same format that was being used for most of the script, and I did wonder if maybe a more elegant approach for the conditions was an if/else loop, but I was worried that separating the conditions would omit actual saturation flags that might still be needed in favor of just DO_NOT_USE flags. But happy to work on a more elegant solution if anyone sees any obvious ways to update it.
Testing
I was able to test this on WASP 39b data with full saturation in columns 60-144 and also tested it with only partial saturation in the second group to make sure the condition was not catching partial saturation. If others want to test it feel free! I'll post a side by side comparison below of one of our Stage 3 results that showcase the bug fix.

This is not something that needs to be addressed in this PR, but this new (helpful!) feature will further increase the need to address issue #546. Just noting that here and linking that issue to remind myself and others why resolving that other issue is important


[proposal] Internal mutateArgs usage in core

For more background, see https://trello.com/c/QapDT6XY/87-could-not-fetch-session-socket-has-no-cookie-in-its-handshake-edit-nevermind-see-updated-description

This demonstrates how mutateArgs could be used to hypothetically make queries faster by avoiding unnecessary object cloning internally.  The next step is to benchmark this-- without benchmarks proving this is actually faster, it would be a mistake to merge this into core.

@sgress454 I reckon you're talking about .archive() right?  (I think the PRs might have crossed streams)

@mikermcneil I was commenting in the source, I guess the specific commit must be part of this PR...


fix bug with like filter on missing columns not correctly considering extractionFn

Description
Fixes a bug with LikeFilter that can occur when using an extractionFn that replaces null values with non-null values, such as a lookup with replace missing values set, and then querying a segment with a missing column. In this case, the query would incorrectly check if the like-matcher matched null instead of applying the extractionFn which might change null to not, and choose the incorrect index for the case.
The added test models this case, and fails without the changes to LikeFilter.

This PR has:

[x] been self-reviewed.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[x] been tested in a test Druid cluster.

not sure what the failing CI docs thing is all about, seems unrelated to changes here:
Error:  Invalid docusaurus-theme-mermaid version 2.4.3.


Add support for parsing boolean values in from_json

Closes https://github.com/NVIDIA/spark-rapids/issues/9597
Changes in this PR:

Add support for parsing boolean values in from_json

build

build


Need better messaging about workspaced junctions

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Mar 30, 2019, 10:52
Background
As reflected by my silly panic which resulted in filing #978, it can be quite easy to not be aware that you are working with an active workspace on a junction element.
Regular (non-junction) elements do not have the same problems, because:

At least whenever we start a session we display which elements in the pipeline have open workspaces

We don't show the junctions in the regular bst show codepaths which construct the pipeline summary, so we don't see these at session start

Parse/load errors cannot originate from inside a workspace unless it is a workspace of a junction

When load errors start happening because of a ref mismatch of a subproject, i.e. the subproject is not what you expect it to be, then you have to remember that you had a workspace open on the junction element.
Task description

[x] Display active junctions beside the pipeline summary at session start
This should just be done anyway, this is important information about a session and it's currently missing.
Using the same codepaths as we use to display other elements will ensure that open workspaces will be indicated.

[ ] Enhance provenance to specify open workspaces
Whenever a LoadError is raised, the provenance of the error should indicate that it's project is junctioned.
Currently provenance only specifies the full element name including it's junction with junction.bst:element.bst colon notation, in the case that junction.bst has an open workspace, it will be useful to the user to indicate that, probably by specifying the path to the open workspace.

[ ] Enhance missing file errors to specify open workspaces
The errors which say: "element.bst was not found in project referred to by junction.bst", should specify the junction's workspace path if the junction has an open workspace

In GitLab by [Gitlab user @tristanvb] on Mar 30, 2019, 10:52
marked this issue as related to #978

In GitLab by [Gitlab user @tristanvb] on Apr 1, 2019, 08:55
marked this issue as related to #960

In GitLab by [Gitlab user @tristanvb] on Apr 1, 2019, 08:55
Marking this as, at least tangentially related to #960

In GitLab by [Gitlab user @tristanvb] on Apr 2, 2019, 06:58
mentioned in merge request !1251

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 07:23
marked the task Display active junctions beside the pipeline summary at session start as completed


UZB Z-Wave USB Stick from Z-Wave Me is detected as HS1DS Window / Door Sensor

Describe the bug
I'm using the UZB Z-Wave USB Stick from Z-Wave Me (https://z-wave.me/products/uzb/) with zwavejs2mqtt but zwave-js detects it as HS1DS Window/Door Sensor.
To Reproduce
Steps to reproduce the behavior:

Start zwavejs2mqtt with this USB stick plugged in
It shows up as HS1DS Window / Door Sensor

Device information
Which device(s) is/are affected? UZB Z-Wave USB Stick from Z-Wave Me (https://z-wave.me/products/uzb/)
What are the node IDs? 277-1-1024 (0x0115-0x0001-0x0400)
Logfile:
This file contains logs from zwave-js as well as zwavejs2mqtt: zwavejs2mqtt-uzb.log

packages\config\config\devices\0x0115\hs1ds.json needs to be modified and renamed. Accepting PR


Create clear standard instructions for adding LGPL to a GitHub repository

It would be ideal if all instructions and flows provided by GitHub matched each other and were what was created when you generate a new repository with a license template included or at least if choosealicense made it clear that you should ignore the GNU instrucitons and the basic license flows in the case of the LGPL, where a few extra steps should be taken.

GNU says to put the GPL in COPYING and LGPL in COPYING.LESSER
choosealicense says to put the GPL in LICENSE and LGPL in COPYING.LESSER -- Is this a mistake or did choosealicense intend for two different base file names?
Choosing the LGPL as the license template at repository creation generates only LICENSE with the LGPL (no GPL)
Following the GitHub blog instructions for adding a license to an existing repository generates only LICENSE with the LGPL (no GPL)

Quickly examining a handful of LGPL repositories, most didn't include the GPL anywhere.
I've seen users suggest using LICENSE and LICENSE.LESSER as these are a broader standard outside of the linux community where the standard is COPYING for the license file.
So, what is the standard for GitHub?  If I follow the instructions on choosealicense and use LICENSE and COPYING.LESSER, will the LGPL be properly detected as the repository license, or will it think the repository is under the GPL?

If I follow the instructions on choosealicense and use LICENSE and COPYING.LESSER, will the LGPL be properly detected as the repository license, or will it think the repository is under the GPL?

It'll be detected as LGPL. The code that does this is in https://github.com/benbalter/licensee/blob/1961b0e82d6c92242f5403d7fd41c5053aa3f8d5/lib/licensee/projects/project.rb
On your points 1 and 2, I agree the instructions here could be more consistent. I'll leave this open until it is fixed.
Point 3 can't be addressed in this repository. I'm not sure it's a big practical problem; LGPL will be detected by itself. I'll pass the feedback along though. On point 4, I'm not sure what blog instructions you're referring to, but I suspect it is the same as point 3.

When you specify the license as GNU Lesser Public... when creating a new repository,  it only creates a LICENSE file with the LGPL additions.   The GPL (as required) is not included.
As mentioned by @colosi ,  to provide users with the LICENSE,  GNU recommends that you:

Add a COPYING file with a copy of the GNU GPL or GNU AGPL.
Also add a COPYING.LESSER file with a copy of the GNU LGPL, if you use that.

I think the @GitHub default of only including the LGPL additions,  but completely missing the rest of the license is quite broken.

On your points 1 and 2, I agree the instructions here could be more consistent. I'll leave this open until it is fixed.

In #709 I specified only COPYING for GPL-3.0 so as to make the instructions between the [L]GPL-3.0 consistent.
As to the behavior on github.com, this repository can only address this to a very limited extent: the license picker can't add multiple files at this time, and this repo isn't a place to fix that. I've changed the Lesser GPL 3.0 metadata to make it less likely it will be arrived at through the picker (eventually; code from this repo ends up supporting the picker via being vendored in licensee) and hid the sidebar form on choosealicense.com for LGPL-3.0 which leads to the picker.

@mlinksva Respectfully, I think you implemented the wrong solution to this thread.
Although @colosi discusses standards in terms of the choosealicense.com workflow, their concern seems to be to make sure that the licenses are properly detected. That sounds like a licensee issue, not a choosealicense.com issue.
Next, I disagree with @dcousens that the previous behavior of choosealicense.com for LGPLv3 was "broken": The added terms of the LGPLv3 are fine to understand, unambiguous, and have been used for years without an issue. They are appropriately detected by GitHub and serve to report on the usage of LGPLv3. (What would be great is if variants described by @colosi could also be properly detected—but since currently the Licensee API does not even detect licenses that are in Markdown, I don't think its accuracy should drive design decisions.)
I think what is "broken" is that two users with no affiliation that I can see to @github have been able to convince the company to restrict choice for ALL users that use GitHub/choosealicense.com.
Indeed for new programmers, removing LGPLv3 as an option in the license picker may very well just make them unaware of LGPLv3.
I suggest that https://github.com/github/choosealicense.com/pull/709 be reversed. If @dcousens would like to not use this, they do not have to! 😖 We can discuss with @colosi how to update Licensee for better detection as a separate conversation.

Just to add my experience to this discussion.
It seems LGPLv3 is detected if you have a LICENSE and LICENSE.LESSER file: https://github.com/licensee/licensee/issues/287#issuecomment-1689554311
It was confusing to me though that LGPL-3.0 was not an option anymore, because I could select it in the past. I almost selected LGPLv2.1 because I wanted it to be LGPL. Had to guess from https://choosealicense.com/licenses/lgpl-3.0/#how-to-apply that it is no longer an option because technically the old approach was not correct. I manually had to add an extra file.
By having both files, my repo is indicated as GPL-3.0, LGPL-3.0 licenses found as opposed to just LGPL-3.0 license though.

"COPYING.lesser" seems the right thing. Why not add that to the help article.
It is utterly bizarre that you need to study some source code if you want to correctly add LGPLv3 :-D


Edge Tools for VS Code in Windows cannot resolve extends in tsconfig.json

Environment (please complete the following information):
Version: 1.66.0 (user setup)
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-03-30T05:50:14.623Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22581

Edge Tools: v1.4.6
VS Code is running on Windows without WSL.
Describe the bug:
Edge Tools reported an error that it cannot find the target file in extends field of tsconfig.json. It seems that it cannot resolve the node_modules directory properly.

The error is gone if Microsoft Edge Tools extension is disabled.

Repro steps:

Clone this repository: https://github.com/tkesgar/vscode-tsconfig-extends-error-example
Open in VS Code with extension enabled
View tsconfig.json

Expected behavior:
No error is reported, since it is the recommended practice from https://github.com/tsconfig/bases#available-tsconfigs.
Additional context:
The error does not appear if I open VS Code in WSL.

Workaround:

Run VS Code under WSL in Windows
Disable the plugin

Thanks for filing and providing these details. They're very helpful.
I have a vague recollection about seeing a similar problem recently. @codepo8 do you remember if this is already known and being tracked?


Don't Use PW in ENV vars and default SSL on

New Description to account for changes in direction during the life of this PR and feedback received.

Don't use ENV vars to specify passwords for running containers
Setup script and yml file will

generate an ELASTIC_PASSWORD if one is not provided by the user at script execution time.
generate certs for security
generate keystores to store passwords securely

Use docker secrets (aka a volume mount in compose) to securely include the sensitive info (keystores, certs, etc) in containers at container run time.
Each configuration file is now included in the config directory and no longer are configs managed via env vars.

this makes it easier to see what the configs are
make changes to them for personal use or experimentation
configs pull sensitive information from keystores previously generated.

Security is enabled by default and communication between services is done over ssl/tls.

with the exception of kibana. Kibana runs on port 5601 without ssl enabled. This is to avoid the hoops of navigating to a website with an untrusted (self signed) cert. But communication between Kibana and Elasticsearch are secured and use SSL.

@elasticdog Make is for Linux/Mac people. Windows users can use the multiple -f in docker compose.
I’ll upstate to dynamically create keystores and certs.
Thanks for the feedback.

There's something nasty happening with file permissions. When I bring up the stack I see this:
heartbeat            | Exiting: error loading config file: config file ("heartbeat.yml") can only be writable by the owner but the permissions are "-rw-rw-r--" (to fix the permissions use: 'chmod go-w /usr/share/heartbeat/heartbeat.yml')
heartbeat exited with code 1
metricbeat           | Exiting: error loading config file: config file ("metricbeat.yml") can only be writable by the owner but the permissions are "-rw-rw-r--" (to fix the permissions use: 'chmod go-w /usr/share/metricbeat/metricbeat.yml')
metricbeat exited with code 1
packetbeat           | Exiting: error loading config file: config file ("packetbeat.yml") can only be writable by the owner but the permissions are "-rw-rw-r--" (to fix the permissions use: 'chmod go-w /usr/share/packetbeat/packetbeat.yml')
auditbeat            | Exiting: error loading config file: config file ("auditbeat.yml") must be owned by the beat user (uid=0) or root
packetbeat exited with code 1
filebeat             | Exiting: error loading config file: config file ("filebeat.yml") can only be writable by the owner but the permissions are "-rw-rw-r--" (to fix the permissions use: 'chmod go-w /usr/share/filebeat/filebeat.yml')
filebeat exited with code 1
auditbeat exited with code 1
apm_server           | Exiting: error loading config file: config file ("apm-server.yml") can only be writable by the owner but the permissions are "-rw-rw-r--" (to fix the permissions use: 'chmod go-w /usr/share/apm-server/apm-server.yml')

Same behaviour on Windows and Linux.

I'm in two minds about running Kibana on HTTPS. It means that the first thing a brand new user sees is an error page with the word "unsafe" in it. We know that's just a self-signed cert, but it doesn't give that "it just works" feeling.

@elastic/infra if anyone would like to review this PR I'm happy to answer any questions. i think it's ready to go now for real world use.

Keystores are pre-configured with the "changeme" password

Assuming I understand this correctly, can we please not do this.
We went to a lot of trouble to get rid of default passwords from ES, please don't add them back in via docker.
Ping: @elastic/es-security

@tvernum
What are you trying to understand. I'm creating a keystore and then adding the password "changeme" to it.
If you're wanting to get away from the password "changeme" I can default it to something else.
the other option is I can use an automatically generated password and output it in the setup script after everything is done. Something like:
The elastic password is: blahblahblah

Will that work?

@fxdgear Sorry, I had forgotten that stack-docker has historically had a pre-configured password ( 😢  😭 🤢 😡 )
I would truly love if we never shipped anything that had any preconfigured password in it. Even for things that are intended to be examples rather than production ready - users take what we provide as a gold standard and do likewise.
If it's possible for the setup process to ask for a password, or generate a password that would be a wonderful step forwards.

@tvernum Does the latest commit work for you?
https://github.com/elastic/stack-docker/pull/39/commits/e1306b4997b04fba39dda28453a84222ff27c511
thanks for taking the time to review this!

@Crazybus 💥 thanks for the feedback. I forgot that I modified the Makefile. I'm gonna set that back to it's normal thing cause I put all the setup in a docker container. There's no need to do the make file anymore.

@jarpy @tvernum @xeraa @Crazybus
You all have commented on this PR at some point. I'd like to invite you to review it again.
I feel like I've addressed everyones comments and concerns, and would like to get this "done" with so it's not something I have lingering anymore :)
Thanks for all your assistance with this.

I think this breaks on Windows because it depends on the docker Unix socket.
C:\Users\jarpy\src\stack-docker [nick/dont_use_pw_in_env ≡]
λ  docker-compose -f setup.yml up
WARNING: The PWD variable is not set. Defaulting to a blank string.
WARNING: The Docker Engine you're using is running in swarm mode.

Compose does not use swarm mode to deploy services to multiple nodes in a swarm. All containers will be scheduled on the current node.

To deploy your application across the swarm, use `docker stack deploy`.

Creating stack-docker_setup_1 ... error

ERROR: for stack-docker_setup_1  Cannot create container for service setup: b'Mount denied:\nThe source path "\\\\var\\\\run\\\\docker.sock:/var/run/docker.sock"\nis not a valid Windows path'

ERROR: for setup  Cannot create container for service setup: b'Mount denied:\nThe source path "\\\\var\\\\run\\\\docker.sock:/var/run/docker.sock"\nis not a valid Windows path'
ERROR: Encountered errors while bringing up the project.

@jarpy ahh thanks for this. you have to specify some env vars for a windows user and I forgot to put those in the read me. I'll add thanks. :)

Possible error conditions I've found:
On second attempts to -f setup.yml up, some files may already exist:

When elasticsearch.keystore exists, it is not regenerated. Still, a new ELASTIC_PASSWORD is generated and used in Kibana and Logstash, but not set in elasticsearch.keystore. Workaround: Remove elasticsearch.keystore and -f setup up again.

Kibana's SSL files, when they already exist, may not be repopulated. Workaround: Remove all new/modified files in config/ and git checkout . to restore normal files, then -f setup up again.

@jordansissel if you have make installed you can run a make clean which will solve this as well. BUT unfortuanly make isn't installed by default on windows :(
Thank you so much for all your help on windows testing!

Tested latest commit, and it works for me (Tested on Windows 10 / powershell).

@Crazybus can you please review again. I hope I've addressed all your changes.
@jordansissel +1 thanks for the patch super helpful.
@russcam Can you please review the README again. i've taken your suggestion and added it.
@jarpy When you have time lets sit down and see where you are blocked.

The PowerShell environment variable change looks good @fxdgear 👍


[fix] remove hack breaking 'fetch' with Undici / CF Wrangler (#5109)

Fixes sveltejs/kit#5109
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

thank you!


Remove the need for epoxy

Recompile libmgba without OpenGL, this should remove the need for epoxy
Consider also enabling minimal core

Not worth doing, don't want to get sucked into editing mGBA


Add unit tests

It should be possible to easily spin-up grpc servers in-memory for tests and exercise probing capabilities.
It can be either execing out to a binary, or we could export the probing code to a pkg and just invoke that (but that wouldn't probably test the CLI flags).

I worked on this and the results are at testing branch. https://github.com/grpc-ecosystem/grpc-health-probe/tree/testing
This has reduced main.go (which, right now has all the code in the project) from 235 lines to 181 lines of code. However it resulted in the project come up to 613 lines of code.
Honestly I'm thinking since the project mostly relies on grpc-go’s behavior (e.g. returned error types/codes, timeouts etc), mocking all that stuff with testing seemed redundant. I'm initializing actual tcp server for connection testing, which is good, but then I have to replicate every kind of error (timeouts, general failures, tls hanging etc).
Similarly testing buildCredentials has been vastly unnecessary as we're trying to test the behavior of how gRPC credentials.TransportCredentials object behaves.
I call this a failed experiment and I think we should keep the source code of this project short, given it has not yielded any bug reports despite >80k downloads so far.

@ahmetb , once again I am trying to contribute to this issue as well. I have added one endtoend testcase. It does following.

Created a grpc server which has the health check impl.
Made a binary of our source code and set it to the current path.
The new testcase will do following.

Lauch the grpc server
Execute the binary by pointing addr = addr of above grpc server
As an output, it expects it need to be in SERVING status.

@arindamnayak You should definitely check out https://github.com/grpc-ecosystem/grpc-health-probe/tree/testing. I think where we actually need tests is around TLS/credentials/flags. It would be much better if we can bring the tests inside unit-test code instead of exec-ing (that way we can tweak the server etc).


Have a clean webroot folder with no code

Hey @pasichDev,
Would it be OK if you modified your folder structure to the following?

config/

.env <-- Use the ENV functionalities to store the local private data, like DB passwords and API keys
Have a look at: https://packagist.org/packages/vlucas/phpdotenv

src/

(All the code)

webroot/

index.php <-- this has little to no code and just gets all the functionality from the src folder above
.htaccess
img/

(all the images)

js/

(all the Javascript)

css/

(all the Cascading Style Sheets)

README.md
LICENSE
.gitignore
.gitattributes

This way when we create the virtual host on apache2, we point it at the folder webroot.
This leaves all the code OUTSIDE the webroot folder and apache cannot serve it, so no need for the defined(pasich) or die().
This will also begin to prepare you folder structure to use composer.
We need to have a talk about Name Spaces on your classes and probably use a better HTTP Client to access the explorer API.
But the composer stuff can wait, first the folder structure, please :smiley:
Many, many thanks!!
Cheers,
Gus

Hey @gcarreno I have noticed your question. I'm already halfway to a solution.


Fixed-point multiplication

This doesn't improve the score since it implements instructions with 0b10 in OPCODE2 but those are not contained in corpus.


PlotMe support

Plotme github: https://github.com/WorldCretornica/PlotMe-Core
Example Plugin support: https://github.com/WorldCretornica/PlotMeHookExample
Would like to see things like:
<player.plots> - returns a list of plots owned by player
<player.has_plots> - returns boolean if player owns any plots
<location.plot> - returns the plot entity/id of the location (or null)
<plot.owner> - returns the player object of the owner of the plot
<plot.id> - returns the id of the plot
<plot.cuboid> - returns the cuboid of the plot
<world.isPlotWorld> - returns boolean of whether or not the world was PlotMe generated

In the future, could add functionality to modify plots, like owner, properties, etc.

Initial attempt ready, need testing and potentially refining.

Preliminaries are done, will request more as needed.  Thank you.


replicate all the internal (our components) tagged images we have in the current public registry to the new ACR

We can get the list of such components semi-automatically: we can list all the repositories in the old registry, subtract what we have defined in retagger and the result should be (more or less) list of our images. We can then sync them with skopeo.

Done by @kubasobon


Dataset Version

Hi, it's a really wonderful work. I am wondering if there is a lite dataset version to download or the split zip dataset? It seems the gelsight dataset is too larger (800GB+). Many Thanks!

I am not aware of any toy version of this dataset. I will check in the lab if we can share something small for you. Ping here again in a week if I don't respond on this.

Oh, thanks a lot!

Hi, is there something small to share? Thanks.

I am not aware of any toy version of this dataset. I will check in the lab if we can share something small for you. Ping here again in a week if I don't respond on this.

Hi, is there something small to share? Thanks.

I am not aware of any toy version of this dataset. I will check in the lab if we can share something small for you. Ping here again in a week if I don't respond on this.

Hi, I'm a student that also uses this dataset. I can share with you a smaller version that I use (~100G).  Can you wait for another day? I'm packing things up.

Hi, is there something small to share? Thanks.

I am not aware of any toy version of this dataset. I will check in the lab if we can share something small for you. Ping here again in a week if I don't respond on this.

Hi, I'm a student that also uses this dataset. I can share with you a smaller version that I use (~100G). Can you wait for another day? I'm packing things up.

Ok, thank you! This shall help me a lot!

Hi, please check this link:
https://drive.google.com/file/d/1nRR2-GOhmePqmKrzRKloOenIbu5NB0_1/view?usp=drive_link

Hi, please check this link:
https://drive.google.com/file/d/1nRR2-GOhmePqmKrzRKloOenIbu5NB0_1/view?usp=drive_link

Wow, Thanks!!! I will download it later.


IGNITE-2555 fix

Added offheap usage (used/free/committed) to local node reports.

IGNITE-2555 Logging non heap memory usage and node uptime

Sorry, closed by mistake.
Reopening

Added test, that check logging correctness and node liveness. Included test in IgniteBasicTestSuite.

Closed


Infinite loading of checkpoints and settings

I see an endless loading spinner instead of a dropdown list of checkpoints and settings items in the settings. There are no errors in the interface or console. Latest version of notebook. Checkpoints are definitely not corrupted, even the default 1.5 checkpoint is also a problem.

I was having similar problem, but solved part of it, the checkpoints and extentions were endless loading but this can be fixed.

how do you fix it?

img2img stopped working for me


cytoscape not defined in require

It seems that an issue similar to this one ( https://github.com/iVis-at-Bilkent/cytoscape.js-context-menus/issues/5 ) exists in this repository as well.

This problem seems to be fixed now.


quinn relies on undocumented guarantees about quinn-proto timers

quinn currently polls for timer updates only when it has no current timer or its current timer expires.  This contradicts the quinn-proto documentation.

This is in fact incorrect, not just undocumented. Thanks for the catch!

You’re welcome!  I am using git HEAD in libp2p-quic and found that as I was looking through the recent breaking changes.


Thanks!

Just wanted to send over a quick note of thanks for updating this library. A contractor who worked on our project used the original mobnetic version, it was a relief to see your updated fork. I hope you'll keep it going!

Closing to not clutter things up.


fix regression with user bootstrap

fix for issue 3069
The change https://github.com/cloudfoundry/uaa/pull/3033 forbids the user and group creation with UAA origin but assigns always the origin from the user itself
This breaks the scim user bootstrapping from uaa.yml.
Separate the create user into

from uaa.yml (propertiesSetup)
from shadow user creation

In case of propertiesSetup and LDAP origin we allow again the creation of group assignments to UAA origin

@mikeroda FYI: this PR will not revert all from your former PR . So I assume you have no issue with this PR here ?

close it because of https://github.com/cloudfoundry/uaa/issues/3069#issuecomment-2393403258


Resource references do not use the api-version defined by the resource

Bicep version
Bicep CLI version 0.6.1 (73193aa4c4)
Describe the bug
For a resource, using the resourceName.properties.propertyName produces a reference that does not use the api-version of the resource definition. However, if you use the existing keyword on the resource it does. This is producing some inconsistent behaviors with some resources, most notably is the Microsoft.Network/expressRouteCircuits/authorizations resource.
To Reproduce
param circuitName string
param name string

resource expressRoute 'Microsoft.Network/expressRouteCircuits@2021-05-01' existing = {
  name: circuitName
}

resource authorization 'Microsoft.Network/expressRouteCircuits/authorizations@2021-05-01' = {
  name: name
  parent: expressRoute
}

resource _authorization 'Microsoft.Network/expressRouteCircuits/authorizations@2021-05-01' existing = {
  name: name
  parent: expressRoute
}

output authorizationKey string = authorization.properties.authorizationKey
output _authorizationKey string = _authorization.properties.authorizationKey

Compiled ARM template
{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
  "contentVersion": "<IP_ADDRESS>",
  "metadata": {
    "_generator": {
      "name": "bicep",
      "version": "<IP_ADDRESS>15",
      "templateHash": "10266332226095429963"
    }
  },
  "parameters": {
    "circuitName": {
      "type": "string"
    },
    "name": {
      "type": "string"
    }
  },
  "resources": [
    {
      "type": "Microsoft.Network/expressRouteCircuits/authorizations",
      "apiVersion": "2021-05-01",
      "name": "[format('{0}/{1}', parameters('circuitName'), parameters('name'))]"
    }
  ],
  "outputs": {
    "authorizationKey": {
      "type": "string",
      "value": "[reference(resourceId('Microsoft.Network/expressRouteCircuits/authorizations', parameters('circuitName'), parameters('name'))).authorizationKey]"
    },
    "_authorizationKey": {
      "type": "string",
      "value": "[reference(resourceId('Microsoft.Network/expressRouteCircuits/authorizations', parameters('circuitName'), parameters('name')), '2021-05-01').authorizationKey]"
    }
  }
}

Additional context
This particular provider/resourceType behaves different between the two reference calls. Discovered this during MS case<PHONE_NUMBER>009203.

Interesting find. I think the issue is that the results from the PUT response (w/o existing) is slightly different that the GET response (w/ existing), which should not be the case. So while the API version is the same, you are technically talking to two different APIs with these two blocks of bicep code. I think this is something that can be solved with by the Networking RP. Is the MS Case still open and can you share this context with them?
This seems like a duplicate of #5328. cc @bmoore-msft / @majastrz as FYI

Yes, it is and will do. Is there a reason that the reference function doesn't use the api-version but the existing resource does?

I think because of this: https://github.com/Azure/bicep/issues/5328#issuecomment-1069394733 - without the apiVersion we assume the resource is defined in the template and use the response from the PUT rather than issue a GET (iirc).  When we issue the GET we need the apiVersion.
@alex-frankel - looks like a dupe to me too...  we might want to change the title on #5328 - no reasonable human (apparently we're not reasonable) will make the connection as titled.

Closing as dup


Initial implementation of safe area snapping

Adds four new container classes:

SnapTargetContainer: A Container that defines a region that may be "snapped" to.  Automatically caches via an ISnapTargetContainer interface.
EdgeSnappingContainer: A Container that will resolve the nearest parent ISnapTargetContainer and optionally snap individual edges to that container by applying negative Padding.
SafeAreaTargetContainer: A subclass of SnapTargetContainer that caches itself explicitly rather than via an interface, and provides a Bindable<MarginPadding> that by default is bound to Window.SafeAreaPadding but may be changed.
SafeAreaContainer: A subclass of EdgeSnappingContainer that snaps to the nearest SafeAreaTargetContainer and also applies a positive Padding based on the current value of the target container's bindable.  Individual edges can be padded.

The general use case of the safe area classes is thus:

The root of the scenegraph has a SafeAreaTargetContainer, bound to Window.SafeAreaPadding.
Any drawables that should snap back to the edge of the screen (generally non-interactive elements such as background images) should be placed in a SafeAreaContainer with SnappedEdges configured as required.
Any drawables that should never be obscured by notches/rounded corners etc. (generally interactive elements and text) should be placed in a SafeAreaContainer with SafeEdges configured as required.

These containers may be placed anywhere in the scenegraph and still work as expected, but any "snapped" Drawables will not visible if a parent has Masking enabled.
Note that SafeAreaContainer supports both SnappedEdges and SafeEdges (providing they don't conflict) as there could potentially be situations where you want elements in the same container to handle both cases.
Also applies these containers to the visual test browser.  Due to the aforementioned caveat, Masking has been disabled in the test case ScrollContainer and the search box has been brought to the front.
Screenshot shows the visual test browser using a hardcoded SafeAreaPadding of (50, 50, 50, 50), with SafeAreaContainer.SafeEdges set to Edges.Top | Edges.Left | Edges.Right.
The test scene itself has a SafeAreaTargetContainer with adjustable safe area margins.  It has two SafeAreaContainer children, where one simulates a background that should be snapped to the screen edge (blue box), and the other simulates contents that should be pushed to fit inside the safe area (coloured squares).  Note that the SafeAreaContainers are inset to show that they can be anywhere in the scenegraph and work as expected.

EdgeSnappingContainer in the test scene has a size of 0:

I'd like to see a test which shows actual real-world usage of this, with an ISnapTargetContainer that acts like a device with unreachable edges where you can increase or decrease the size of these at each side.
It would show elements which shouldn't enter the margin and (background) elements which should.

I'd love to have the ability to simulate mobile devices on desktop.  Pass a command line argument etc. that will force a set resolution and safe areas to match an iPhone X, for example.  It would make UI tweaking very easy, especially since we could utilise dynamic compilation.
The iOS simulator just doesn't cut it unfortunately, since build times are long and we can't use AOT.  Also, framework consumers may wish to design with mobile in mind, but not have a macOS setup available for testing iOS.

I'm wondering why you can do what I proposed above: have a higher level container which caches the SafeAreaPadding (and changing the lookup to not be just from the gamehost).

Updated description with a screenshot of the new test scene.

Any reason you didn't go with the proposal of caching the SafeArea and instead use a property?

Safe area insets can change when you rotate the device.

That's fine – it would be cached as a bindable. Just saves having the property you added to the container (which feels a bit weird since it's only really used for testing, right?)

Oh cache the bindable, gotcha.  Will do that in a sec.

Note that you'll probably want to make a custom type, either BindableSafeArea : Bindable<MarginPadding> or use a new struct that isn't MarginPadding i guess..
probably just the custom bindable type.

The bindable itself doesn't actually function any differently from a Bindable<MarginPadding> though, is it necessary to introduce a new type?

If you don't you'll be caching a global MarginPadding. Dangerous.

I'm thinking I may first make another PR to introduce a separate struct to store the insets, as it could also store device orientation, etc.  It would only store dimension-related properties that can change at runtime through some action outside the control of the framework (rotating the screen, iPhone "call bar" appearing, etc.)
Is this overthinking it?

LGTM 👍


Create product via tycho eclipse-repository plugin

Because of issue #33, the product isn't created anymore. (The product packaging was changed from eclipse-repository to eclipse-plugin.) Make this work again.

Seems good to go now, closing.


pkgs/release: Add some static interpreters and tools

Description of changes
Add some low hanging fruit to pkgsStatic in release.nix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I think it would make more sense to put this in release-cross.nix?  Since pkgsStatic is just cross-compilation (at least on Linux), and it already has a structure for this.


Add video_play_count property

Hello 👋
I found this field might be helpful for video metrics, so add it to the Post.
It's different than "View" as "View" might have multiple "Play" for video.
I just realized this could also close #2145 .

Hi. It seems that for a video Post constructed with Post.from_shortcode() it fails with a KeyError: 'video_play_count'. Does it only work for Posts build with from_iphone_struct?

Hi. It seems that for a video Post constructed with Post.from_shortcode() it fails with a KeyError: 'video_play_count'. Does it only work for Posts build with from_iphone_struct?

same issue i'm having even with iphone struct

How can i use from_iphone_struct(cls, context: InstaloaderContext, media: Dict[str, Any])
its taking media as a parameter from where to obtain this
an example will be very helpful
Thanks in advance

@steven5538 i also get the same error when using it with posts from Profile.get_posts(), do you have any idea how to do this?
If this works it would mean so much for me thank you!