Update source info in global subject rule

Per offline discussions, prefer source.labels["app"] for now as "source" in metrics, etc.

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed

Jenkins job mixer/manager-regression passed

Jenkins job mixer/e2e-smoketest passed


Make ssh_port default to 22 for knife bootstrap.

This is the behavior of knife-windows.

/cc @chef/client-windows .
Could one of you also cc chef-client-core?

@ksubrama seems simple on the surface, but why are we adding it? Presumably all the underlying libraries make the right choice. I think we fixed our code where mixlib-cli defaults no longer override .ssh/config values, but I still worry about those kinds of repercussions with this kind of change.
@chef/client-core review?

I agree with @btm - I don't think that adding this will change anything because I think the underlying libraries already default to 22.  Do we have any evidence to the contrary?

another agreement with btm.

This is good to know.  knife-windows explicitly sets it to 22.  Perhaps the better solution is to remove the default value there and check that the underlying library defaults correctly.


nothing to be generated

Hi，
I have installed vcf-kit,
and I use:
vk primer indel --ref=Zea_mays.AGPv4.dna_sm.toplevel.fa chr10.vcf.filter.indel.gz
I get nothing, nothing output, no error message.
Is something wrong?
Thanks

I checked the code, my indel length can not get to 25.
I edit the code, now I have my output primer, thanks for your nice software.


Autentification

Hi,
First of all, thanks for sharing this 👍
Well, I'm having this error "redirect_uris" not founded, when I tried to connect the data in power bi(after all the steps).
Any ideia of what i most be doing wrong?
Forget, already workin well!

Hey! I see that you closed this issue. Do you still need help? the error is caused when your API App doesn't have the redirect uri set up correctly.

Yes, no need help anymore, I discovered where the error was (the json file from google). Works fine now. Thank you again!


difference between getBasePath, getFullPath, getRealPath, getFullReal…

…Path

Hey! Thanks for helping out!
Unfortunately, the API reference docs are automatically generated from https://github.com/obsidianmd/obsidian-api, so any changes will be overwritten the next time we update the docs.
Ideally we merge this upstreams in the obsidian-api repository, or we find a better place to document this.

Hey @ooker777! I've gone ahead and added a copy of the .d.ts file to this repository. Could you move the documentation to obsidian.d.ts, and I'll regenerate the docs in a subsequent commit?

So your strategy is to store user-submitted documentation in that file? I'm not sure what will you do next when the official .d.ts file changes?

Fortunately, it should be relatively easy to handle conflicts, since the most of the changes will be additions and can be fast-forwarded on top of the upstream changes. It'll be like maintaining a fork. In the event where the Obsidian team makes changes to the user-submitted docs, I'll handle the conflicts case by case.
Yes, #41 looks great! 👍


Multi-adapter support

Now Adapter, Device, Queue are bundled into DeviceHandle and created alongside Surface, or reused if we already created a compatible handle.
I'm open to design complaints, just wanted to prove that the logic would solve my problem from #224, and it does :). Now on x11 (through xwayland) the winit example works fine, and on wayland I get a different error message than before 🥳
All of this comes at the cost of a little extra user-side juggling, but in the winit example it's not much extra effort.

Would just like to note that this branch fixes the issue for me as well; I am running on X11 (since I still can't screenshare using Zoom on Wayland), and have both integrated and discrete graphics. Some more detail on Zulip.

Re: the discussion on Zulip - for what it's worth, I think this is complexity that has to happen somewhere. Picking an adapter with no criteria won't work, as we've seen for nvidia laptops. I tried to balance vello complexity and API consumer complexity, by exposing the fact that multiple adapters are in use but leaving the selection and reuse logic on our side. That logic could be left to the user, or the whole business could be hidden away, but whatever happens, there's gonna be more work somewhere.

To add some context, I agree that we’ll need extra complexity somewhere. The open question for me is whether it’s actually necessary to maintain a collection of devices or just choose the appropriate one. In the former case, we’ll also need to duplicate the Renderer state and all associated resources per device. I also wonder what happens if you drag a window to another screen that may be attached to a different device. For the latter case, I’d rather add the logic to select a single device that supports the surface.

I do appreciate the fix and this does address the immediate problem allowing people with dual GPUs to actually run the code so if you fix the conflicts I’ll be happy to approve this and get it merged. We can revisit the full implications later.

That's weird, the merge conflicts weren't showing up locally, so I just rebased and hoped for the best.
I'd always imagined that dragging windows across screens should force apps to make a new surface for each new screen the window is on; maybe because I've been reading too many discussions about fractional scaling. In the absence of this, I see that things could get messy with my code.
Good point about duplication. Looking at wgpu again, I think it's possible to minimise the number of devices in use, but it would mean that a surface needs to switch device if a new surface is created. Room for improvement, I guess


Add startOffset and endOffset into segment metadata.properties file

And any other props that are missing.
Goal: every property in segment zk metadata should be in the metadata file on the segment.

cc: @mayankshriv

Certain fields should be in ZK metadata only though. Checked the ZK metadata, and adding start/end offset for debugging purpose should be good enough. The missing fields are segment.flush.threshold.size, segment.flush.threshold.time, segment.realtime.download.url, segment.realtime.status, segment.realtime.numReplicas

@npawar Please review https://github.com/apache/pinot/pull/8502/files which aims to add the offset and potentially other ZK properties into segment's metadata.properties


scylla_image_setup: enable swap during AMI instance init

This PR enable swap in scylla_image_setup, it will be enabled during AMI instance init.
The swap is always helpful, and recommended for scylla user. We don't need to make it configurable, and just enable it all the time.
Current default root disk size (10G) might be not enough if the instance type is very large. Let's increase it to 30G.
The last patch disabled swap setup in creating AMI stage, scylla_setup is executed there.
/CC @fruch
Fixes: https://github.com/scylladb/scylla/issues/6973

Generated a new AMI by this PR:

ami-067205d8f03ec7b4b (us-east-1)

[amos@amos-centos7 ami]$ ./build_with_docker.sh --repo http://downloads.scylladb.com/xxxxx/centos/master/latest/scylla.repo

swap is set in instance init (as expected)
Aug 05 12:02:45 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: systemd-coredump is working finely.
Aug 05 12:03:17 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: 4+0 records in
Aug 05 12:03:17 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: 4+0 records out
Aug 05 12:03:17 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]:<PHONE_NUMBER> bytes (4.3 GB) copied, 32.1438 s, 134 MB/s
Aug 05 12:04:06 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: Setting up swapspace version 1, size = 4 GiB<PHONE_NUMBER> bytes)
Aug 05 12:04:06 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: no label, UUID=40786599-4d6d-45e7-8b37-b899236f7027
Aug 05 12:04:06 ip-10-99-0-233.ec2.internal scylla_image_setup[3609]: Created symlink from /etc/systemd/system/multi-user.target.wants/swapfile.swap to /etc/systemd/system/swapfile.swap.
Aug 05 12:04:06 ip-10-99-0-233.ec2.internal systemd[1]: Started Scylla Cloud Image Setup service.

[scyllaadm@ip-10-99-0-233 ~]$ free -m
              total        used        free      shared  buff/cache   available
Mem:          15256         376       10463           0        4417       14582
Swap:          4095           0        4095

LGTM

@bentsi can you help to backport this PR to branch-4.2?

I saw the PR had been merged to next-4.2.


Use WebRequest instead of HttpWebRequest because of bug on older Mono…

… versions

Anything less than mono 4.x is unsupported.


[SPEC] produce spec for NEAR

produce a spec at this level of detail
https://github.com/nearprotocol/NEPs/blob/5710a4fce95ce3c53316b60607214425b52a3263/specs/Economics/README.md#state-storage-rent
see here for discussion
https://commonwealth.im/near/proposal/discussion/375-what-pseudocode-should-we-use-in-our-spec
especially

Python is a good choice, it is easy to understand, and most of the engineers can read Python. Interestingly, they also provide SSZ equivalent in some places. SSZ is their own serialization format, equivalent of Borsh. Since Borsh was written after Rust types, we can provide Rust equivalent in few places.

see here for Economics wip
https://github.com/nearprotocol/NEPs/blob/5710a4fce95ce3c53316b60607214425b52a3263/specs/Economics/README.md#state-storage-rent

We think that assemblyscript covers this need, and the new documentation is written in the following way:

a textual explanation of concepts
the smallest example in all SDKs, prioritizing assemblyscript.


doesnt work

also,please provide a demo on heroku

Are you sure that you are setting up everything correctly when using the demo?

i am gonna make a vid and see if it works for me

i am having a problem where it says script missing:start so did u forget to add the start sript or smt @QuiteAFancyEmerald

you need to specify a url

? i am trying to run it on replit and its says script missing when i try to run so i can't even run it.

You really are not setting it up correctly. I will try to explain things in the most simplest way.
First create a workspace and clone this repository. Next take the demo folder and work from there.
git clone https://github.com/titaniumnetwork-dev/Corrosion
cd demo
npm install
node index.js```

If you are setting things up for Heroku do the above and add an app.json and have the start script specified in package.json. (Auto-generated file)

how do u do this is dumbass terms

how do u do this is dumbass terms

this is not a valid support channel for this


allow for outboard loads on wing as signomial model

test models please

test models please

@bqpd I get this error running with this branch on JHO
"/Users/jenkins/workspace/gplibrary_PR_Models/mosek/gpkit/gpkit/small_classes.py", line 242, in __div__
    def __div__(self, other): return self * other**-1
ZeroDivisionError: 0.0 cannot be raised to a negative power

test models please

@bqpd solved the 0.0 issue. I was substituting in values where I shouldn't have been.

@mjburton11 should I try to clarify the error message?

That could be helpful

Where were you dividing the Hashvector?

I think so? I was diving the hmap or something like that

Hmm. I feel like adding a more specific error might not help debugging much more than debug lines in user code would.

@bqpd @courtin can one of you review this PR so I can merge?


[Scene2d.ui] Adding support for horizontal scrolling (touch pad and touch screen)

Hi,
This is a new PR, with code updated w.r.t. master branch.  Closed PR
I prepared a new PR to fix horizontal scrolling support and fractional scrolling.
Currently horizontal scrolling with a touch pad is not supported. More over, devices which report fractional scrolling values, such as touch pads and mouses with continuous wheels are not supported. The scrolling is super fast, because small scroll increments (0.1) are converted to 1 or -1. See my previous PR for more details.
Cheers,
Julien
Also, adding support for devices which report fractional scrolling
amounts. E.g. a mouse with a continuous mouse wheel, or a Mac touch
pad. This is currently only supported in lwjgl3. It can probably be
added to android and maybe to gwt.
InputProcessor scrolled method now receives scroll amount for X and
Y. Changed type to float to support devices which report fractional
scroll amounts. Updated InputEvent in scene2d accordingly: added
scrollAmountX, scrollAmountY attributes and corresponding setters and
getters.
Input event queue can receive float scrolling values. Since the queue
stores the events with integers. Scrolling values are stored in fixed
precision format, with 8 bits for the fraction.
Updated backends accordingly: lwjgl, lwjgl3, android and gwt.

Instead of /256 & *256, you could use floatToIntBits and inverse. (Use wrappers from NumberUtils). It won't lose precision and the performance will be probably similar.

Agreed, floatToIntBits is a bit better since it preserves the entire float. Otherwise it looks good to me.

Please correct the tests, they don't compile any more.

I have a problem with this. Changing InputListener and InputAdapter by removing the old scrolled(float) and adding the new scrolled(float, float) breaks almost all existing libGDX code that implemented the old scrolled(float) method, including all code that used InputListener directly. There's no compatibility layer here, which explains why the tests don't run. InputAdapter at least has an easy workaround that could be employed; scrolled(float) would stay in InputAdapter (not necessarily InputListener), and the default implementation of scrolled(float, float) could call scrolled(float), ignoring horizontal scroll unless the game code can handle horizontal scroll (in which case scrolled(float, float) could be overridden). This allows existing code that uses InputAdapter to at least compile when users upgrade, instead of all users getting the same compile errors the day 1.10 is released. If we had Java 8 default interfaces, maybe we could make the workaround apply to InputListener too.

@jpauty let's add a new InputAdapter method and fix the compile errors to get this forward.

I've added the scrolled method for backward compatibility. I've also replaced my retro fixed point convertion to call to NumberUtils.
The travis checks passes. Sorry for the compile errors. I'm only using mvn to check compilation, which apparently skips the tests. I tried briefly with gradle, but it requires android, which I don't have time to setup right now.

mvn to check compilation, which apparently skips the tests

Which command are you using?

using mvn to check compilation, which apparently skips the tests

Which command are you using?
mvn install

mvn install

That should not skip tests: weird. mvn install -DskipTests would skip tests.
Also, it's recommended to clean too: mvn clean install.

The tests which failed were not automated tests. It's the test project which is not included inside the maven environment because they don't have to get deployed

Every implementor of InputProcessor is going to be 'broken' no matter what - whether we keep the old scrolled method or not, right? After all, they will need to implement the new method. I'm not sure about the change in InputAdapter calling into the old scrolled method by default - this feels like asking for trouble.
If we're going to break it, we might as well just break it once and leave it in the state we want. Leaving a method that we don't really want and which only gets called via a compatibility layer (InputAdapter) isn't really doing anyone any favors. When we eventually do remove it, we'd just break everyone again.

My initial idea of not adding backward compatibility was that it was easy to fix your code: add the missing parameter, change the types and you're done.
I can remove the call to old method in InputAdapter.

Following the "thumbs up votes" I removed the compatibility call.

Thank you. Scrolling over your code, I only think it is sad not to support the new feature on GWT. Apart from that, it looked good to me, but I did not test yet. As it is a breaking change, we still have to decide when to pull it in.

I just tested your changes on Mac OS with LWJGL3 and the horizontal scrolling stuff is working like a charm. I didn't notice any reduction in scrolling speed due to your fractional scrolling fixes, but I also wasn't sure how I could reliably test that.

I've fixed formating.

Upgrade Notes: For apps that upgrade to libGDX 1.10.0 and were using previous amount, on non-Lwjgl3 backends the amount is now reported on amountY argument.


Rebuild Autocomplete options at arbitrary time

Use case
When the user finishes typing in the field, a user of Autocomplete might make two network requests: one to quickly fetch some approximate options and another, longer request to get more detailed results. Autocomplete should be able to update the options with the result of each request. Currently the optionsViewBuilder is only called in response to the completion of the future returned by optionsBuilder.
Proposal
The hacky solution is probably to introduce a controller with a method to imperatively update the options: AutocompleteController.setOptions.
A better solution might require a breaking change. Really it seems like maybe the options should just be passed into Autocomplete as a parameter? That would also require the ability to listen to changes in the field.
Related
There are other request to be able to display things in the options view at certain times, for example while loading: https://github.com/flutter/flutter/issues/147377. Solving this issue would probably also fix that.

FYI @gnprice who brought this to my attention.


Append control divs to Quill's parent element instead of document body?

Thanks for putting this module together--we were badly in need of a way to resize images in Quill and this really helped us out!
We have a single-page application with a Quill editor inside a scrollable container. Since the control boxes of the image resize module are appended to document.body, I found that scrolling the container would cause the resize boxes to drift away from their image:

To fix this, instead of appending the control divs to document.body, I append them to quill.root.parentElement. And instead of calculating their position using this.img.getBoundingClientRect(), I use this.img.offsetLeft and this.img.offsetTop to get positions relative to the container.
I'm not sure how generalizable this is, though. Would there be any drawbacks to always appending the control divs to quill.root.parentElement?
In any case, thanks a lot for your work on this module.

It is hard to predict what conflicts there might be with quill.root.parentElement. I'd rather add a scroll listener to the root, keep the handles on the body and move them on scroll. I'll work on a patch.

Fair enough. Thanks for looking into it!


logStringInterpolationParsingError() fails to compile when building for swiftUI previews

Description
The SyntaxParseable+ExpressibleByStringInterpolation.swift file's logStringInterpolationParsingError() method does not compile when building a project for swiftUI previews for iOS.
The error messages read:
... /SourcePackages/checkouts/swift-syntax/Sources/SwiftSyntaxBuilder/SyntaxParsable+ExpressibleByStringInterpolation.swift:33:7 'Logger' is only available in iOS 14.0 or newer
... /SourcePackages/checkouts/swift-syntax/Sources/SwiftSyntaxBuilder/SyntaxParsable+ExpressibleByStringInterpolation.swift:34:9 'OSLogMessage' is only available in iOS 14.0 or newer
... /SourcePackages/checkouts/swift-syntax/Sources/SwiftSyntaxBuilder/SyntaxParsable+ExpressibleByStringInterpolation.swift:35:21 'appendInterpolation(_:align:privacy:)' is only available in iOS 14.0 or newer
... /SourcePackages/checkouts/swift-syntax/Sources/SwiftSyntaxBuilder/SyntaxParsable+ExpressibleByStringInterpolation.swift:37:10 'appendInterpolation(_:align:privacy:)' is only available in iOS 14.0 or newer

I've noticed this error today when the package resolution for my project automatically updated the swift-syntax package to the version tagged 509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-07-04-a.
Steps to Reproduce

Start a new iOS app project with Xcode 15 beta 2 (15A5161b).

If necessary, replace the new #Preview { ContentView() } swiftUI preview template with the legacy preview provider solution.

Add the swift-syntax package to the project that includes the SyntaxParseable+ExpressibleByStringInterpolation.swift file - you can use any version that includes the commit 96557f7, including today's main branch.

Try to launch the swiftUI preview of the ContentView.swift file. (Clean the project if necessary to trigger the preview build.)

Result: The preview build fails with the error messages above.
Building the project normally for simulator or device compiles without error. The error message about iOS version is only received when building for swiftUI previews.

Tracked in Apple’s issue tracker as rdar://111865186

Thanks for reporting this. I’m fixing it in https://github.com/apple/swift-syntax/pull/1884.


Fix from_unixtime when millisecond part is rounding to 1000

Summary:
When this happens, we create an invalid Timestamp with invalid nano
part.
Differential Revision: D50740711

(1) maybe we should do the round on the input first before extracting the seconds,
this is more like what the java function does.
return Math.round(unixTime * 1000);
(2) the limits of kMax and kMin are worng
https://github.com/facebookincubator/velox/issues/6875
fromUnixtime(Timestamp::maxMillis().getSeconds() + 1000));
will throw velox runtime error.
maybe we shall fix this as well
see https://github.com/facebookincubator/velox/issues/6875


feat: enable parallel storage root computation on canonical chain write

gm @fgimenez next steps here?

bump @rkrasiuk for review


Is there any solution to support variable sequence length during training?

Hi! The current solution is to pad the output to the nearest power of two before scanning. Could you tell more about your use case?

Not the original author here, but my specific use case are linear RNNs. These will have an initial hidden state $h_0$ which can be provided as the first token and setting gate[0] = 0, in case an implementation does not allow providing an initial state explicitly, such as for this one. However, this will shorten the length of the remaining actual sequence to process to $2^{n}-1$. This constraint may seem odd from an outsider's perspective who is not familiar with the details of the underlying parallel scan implementation.
I would therefore suggest two solutions for improving this situation:

Allow providing an initial element explicitly. From my understanding of the underlying CUDA implementation, this should be relatively easy to do.
Drop the power of two-sequence length constraint. Probably  more difficult to implement and may come with a slight performance penalty but would also cover more use cases should as variable-length inference.


concurrency error

When setting concurrency I get an error:
"gatsby-source-graphcms" threw an error while running the createSchemaCustomization lifecycle:

Expected `concurrency` to be a number from 1 and up, got `undefined` (undefined)

  219 |     gatsbyApi,
  220 |     schema,
> 221 |     execute: wrapQueryExecutorWithQueue(execute, {
      |              ^
  222 |       concurrency: queryConcurrency,
  223 |     }),
  224 |     gatsbyTypePrefix: typePrefix,

File: node_modules\gatsby-source-graphcms\src\gatsby-node.js:221:14

@notrab You're right. The change appears in a -next.x.


Add Read-Only Property to UtilityMenuItems

Summary
Adds a read-only property to the menu item shape, allowing menu items to be clicked on and copy/pasted without closing the menu on click.
Closes #359

Let's document isReadOnly in the readme. https://github.com/cerner/terra-framework/blob/master/packages/terra-application-utility/docs/README.md

Added a (probably rough draft) explanation of the isReadOnly prop.

Looks good. Kinda random, but I am noticing the themed screenshots have grown in height? Any clue why?

Looks good. Kinda random, but I am noticing the themed screenshots have grown in height? Any clue why?

This was some odd behavior I came across while working on this - I've only tested this with the examples, but essentially if you add items to the scroll list, and the number of items makes the scroll list longer than the containing menu height, it actually increases the height of the menu as well.
In the comparison screenshots, the read-only menu item has been added to the new pics, so it has pushed the total height of the menu down as well. If anyone has any thoughts on addressing that, I can slip in a fix here, or it can be another PR.

Functional verification completed. The utility menu example displays and functions as expected with the read-only item included.


meshio boundaries from cell_sets M*N memory

Function from_meshio uses M*N memory when matching facets from cell_set to facets of a mesh.
This leads to out-of-memory error on my real world mesh (148494 facets, 16316 on boundary, 10694 in one of the boundary regions).
Problem is alleviated by using ignore_interior_facets=True,  (I have enough memory for (16316, 10694, 3) but not for (148494, 10694, 3)), but it is still slow and I think it is better to use a hash map (dict):
import numpy as np
import meshio
import skfem as sf
import time

# this gets out-of-memory killed
# m = sf.MeshTet.load("model-Cut.msh", ignore_orientation=True)

# this takes long
m = sf.MeshTet.load("model-Cut.msh", ignore_orientation=True, ignore_interior_facets=True)
print(m)

# try to replicate step by step
m = meshio.read("model-Cut.msh")
print(m)

p = np.ascontiguousarray(m.points.T)
t = np.ascontiguousarray(m.cells_dict["tetra"].T)

mtmp = sf.MeshTet(p, t)

sorted_mesh_cells = np.sort(m.cells_dict['triangle']) # by default sorts last axis

b = mtmp.facets.T
#b = mtmp.facets[:, mtmp.boundary_facets()].T
facet_map = { tuple(f):i for i,f in enumerate(b) } # create lookup table

boundaries = {}
print()
for k, v in m.cell_sets_dict.items():
    if 'triangle' in v and k.split(":")[0] != "gmsh":
        a = sorted_mesh_cells[v['triangle']]

        print(k, a.shape, b.shape)

        # this needs M*N memory !!!
        #print( (a == b[:,None]).shape)

        # use lookup table
        boundaries[k] = np.array([facet_map[tuple(f)] for f in a])
print()

m = sf.MeshTet(p, t, boundaries)
print(m)

I will make an attempt to do something about this in #1117.

Now I was able to test it. Tetrahedral mesh with 100 000 vertices and 500 000 elements. Has a surface with roughly 6000 facets. It took around 5 seconds to load with Mesh.load(..., ignore_orientation=True). Without the flag it kept running and running.

I have now extended this to oriented boundaries, ignore_orientation=True will still shave off half a second in my test case.


Fixes cargo deny and update dependencies

This updates a bunch of dependencies that were causing cargo deny issues and other compilation problems. Please note that I still had to ignore the omnipresent time and chrono RUSTSEC advisories as openid has not updated. I plan on submitting a PR to use the time crate instead over there to fix the issue and then those could be removed. However, I did address all other direct and transitive imports of chrono

Please note that I removed the cargo audit step as it appears to be doing the exact same thing as cargo deny in this case. We may want to consider adding it back eventually as its own separate pipeline with a scheduled trigger

Yeah, that test still flakes every once and a while


Breadcrumbs does not found any python methods and classes

Breadcrumbs feature does not found any python methods and classes.
It shows only the python files without detecting the content.

VSCode Version: 1.26.0
OS Version: Windows 10 1803

Steps to Reproduce:

Open any folder with python scripts
Toggle on the Breadcrumbs

Does this issue occur when all extensions are disabled?: Yes

Hi there. I have vs code installed without extensions. Please notice that, so it can not be caused by extension in my case.

@jrieken if you are right there should be an information about that. There is nothing like so in the release notes and vs code docs.

Breadcrumbs always show the file path and, with the help of extensions, the symbol path up to the cursor position. The symbols shown are the same as in Outline view and Go to Symbol and so existing extensions will just work with breadcrumbs.


Add JS format option to insert space before parentheses in function definition.

VSCode version: 1.4.0
This is required by standardjs.com guidelines, but is not possible at the moment.
Example:  function myFunc () {

@waderyan move to TS.

This issue was moved to Microsoft/TypeScript#10733


Running pyamiimage from commandline and in IDEs

I and others are having difficulties running pyamiimage. The main symptom is inability to relatively import from sibling files and directories.
I thought we had solved this problem - but we haven't.
Unfortunately this is a multiparameter probelm.
I am using a directory structure:
pyamiimage/
[snipped]
│   └── 2021_11_06_InCoB_2021.pptx
├── pyamiimagex/
│   ├── __init__.py
│   ├── ami_arrow.py
│   ├── ami_edge_manager.py
│   ├── ami_graph_all.py
│   ├── ami_image.py
│   ├── ami_ocr.py
│   ├── ami_plot.py
│   ├── ami_skeleton.py
│   ├── ami_util.py
│   ├── bbox.py
│   ├── cleaner.py
│   ├── commandline.py
│   ├── contour.py
│   ├── examples.py
│   ├── examples_tesseract.py
│   ├── flood_fill.py
│   ├── image_exploration.py
│   ├── imageanal.py
│   ├── octree.py
│   ├── plot_demo.py
│   ├── svg.py
│   ├── tesseract_hocr.py
│   ├── tesseract_new.py
│   └── text_box.py
├── requirements.txt
├── setup.py
├── temp
[...]
└── test
    ├── __init__.py
    ├── alex_pico
[...]
    │   ├── pone.0054762.g004.jpg
    │   └── test1.png
    ├── biosynth_path_2.jpg
    ├── comparison_images
    │   ├── gray.png
    │   ├── inverted.png
    │   ├── original.png
    │   ├── white_binary.png
    │   └── white_skeleton.png
    ├── context.py
    ├── example_ami_ocr.py
    ├── example_tesseract.py
    ├── explore.py
    ├── generate_compare_files.py
    ├── resources
[...]
    │   ├── biosynth_path_1
    │   │   ├── biosynth_path_1.txt
    │   │   ├── biosynth_path_1_default.txt
    │   │   ├── hocr.html
    │   │   └── raw.png
    │   ├── biosynth_path_2
[...]
    │   └── test_skeleton.png
    ├── resources.py
    ├── test_ami_graph.py
    ├── test_ami_image.py
    ├── test_ami_ocr.py
    ├── test_ami_plot.py
    ├── test_ami_skeleton.py
    ├── test_ami_util.py
    ├── test_arrow.py
    ├── test_bbox.py
    ├── test_colour_sep.py
    ├── test_image_tools.py
    ├── test_svg.py
    ├── test_tesseract_hocr.py
    ├── test_text_and_arrows.py
    └── test_text_box.py

Note that the root of the code is called pyamiimagex as I think some mechanisms look for the first matching name on the path. This worked for py4ami/pyamix
The imports in pyamiimagex/ami_graph_all.py look like:
# local
from ..pyamiimagex.ami_image import AmiImage
from ..pyamiimagex.ami_plot import AmiLine, X, Y
from ..pyamiimagex.ami_util import AmiUtil
from ..pyamiimagex.svg import BBox
from ..pyamiimagex.text_box import TextBox

and in the tests are similar

from commandline

cd ~/workspace/pyamiimage
git checkout pmr_ami_image
python -m pyamiimage.pyamiimage.commandline --help

gives:
python -m pyamiimage.pyamiimagex.commandline --help
/opt/anaconda3/bin/python: Error while finding module specification for 'pyamiimage.pyamiimagex.commandline' (ModuleNotFoundError: No module named 'pyamiimage.pyamiimagex')

However if I go to the directory ABOVE
 cd ..
(base) pm286macbook:workspace pm286$ pwd
/Users/pm286/workspace
(base) pm286macbook:workspace pm286$ python -m pyamiimage.pyamiimagex.commandline --help
usage: commandline.py [-h] [-t] [infile] [outfile]

Welcome to pyamiimagex, view --help

positional arguments:
  infile
  outfile

optional arguments:
  -h, --help  show this help message and exit
  -t, --text  Run AmiOCR on a given Image

It works. This cannot be right!
So...
Please can everyone who gets something working paste to this Issue. Please give OS and environment. (I am MACOSX)
This is driving me insane. The problem is that each attempted solution requires changing a lot of moving parts all at the
same time.

Python stores a list of directories to search for modules called sys,path. This directories in this list is the namespace for imports in python. Whenever Python interpreter encounters an import statement, it searches for that package or module in the sys.path list sequentially.  The word 'sequentially' is important because it determines the precedence in the case of multiple modules or packages with the same name. Python will choose the name that it finds first in the list.
By default python has a few entries in sys.path, which helps us import in-built packages and packages installed via pip. Whenever a python file is run, python also adds the directory of the file being run, so that you can simply import from packages and modules that are within the same directory.
While this sounds simple, this can lead to unintuitive behaviour of imports.
Suppose you have an import statement within the module pyamiimagex.ami_ocr as such:
from ami_image import AmiImage

This would make sense as ami_ocr and ami_image are in the same directory, right?
You're right this would work, assuming you run ami_ocr.py directly or call it from any other module in the same directory.
BUT
If you try to call ami_ocr as a module from a file in a different directory, say, test/test_ami_ocr.py And add a line such as this:
from pyamiimagex.ami_ocr import AmiOCR

The system will throw as error at the line from ami_image import AmiImage in ami_ocr. This is because when you are running test/test_ami_ocr.py, pyamiimage/test gets added to sys.path, but pyamiimage/pyamiimagex does not.
Remember that the path that is added to python path for searching for modules (stored in sys.path) is the file the program first runs. For example, if you are calling a module in pyamiimagex such as from pyamiimagex.ami_ocr import AmiOCR from your test directory. The directory that is added to sys.path is /Users/pm286/workspace/pyamiimage/test. You can verify this by adding a print statement somewhere such as print(sys.path).
Also, since this is lower in the directory tree, you can't import modules from pyamiimagex without relative imports. You have to basically 'go up' a directory to be able to see the pyamiimagex directory. Even then, for some reason relative imports does not seem to work if going up a directory involves going up to the root directory of the project. I don't like relative import for such inconsistencies, so I tend to avoid them.
So how do we solve our problem without relative imports?
The solution to this problem is given in this nice article about structuring your python project.
The idea is, you add a new file called context,py in your test directory, whose job is to automatically add the top level of the project eg. /Users/pm286/workspace/pyamiimage to the beginning of your sys.path. Import context in the beginning of your test file, and then do absolute imports from the top level. Now all the directories in your top level including your package directory is visible to the running test and it's imported modules.
The context.py file looks like this:
import os
import sys

top_level = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))

# add top level root directory to the beginning path
sys.path.insert(0, top_level)

Use absolute paths within the package modules. So inside ami_ocr.py write:
from pyamiimagex.ami_image import AmiImage

And within your test_ami_ocr.py write:
import context
from pyamiimagex.ami_ocr import AmiOCR # this works now

I've solved the imports in this project and pushed them. The main points are:

There is no need to change the name of the package directory(i.e. don't use pyamiimagex), this only leads to confusion when creating a python package. It's best to have the package name as the directory name for the modules. To make sure you are importing the right package/module, check your sys.path.
Do NOT have __init__.py everywhere in your repository. Only have the file in the package directory and its sub directories. For example, having __init__.py  in test directory might cause problem with importing files in the same test directory(such as resources).
Use absolute imports everywhere for importing modules from packages. For example, use from pyamiimage.ami_ocr import AmiOCR whenever you wish to import AmiOCR from ami_ocr. Do NOT use relative imports such as from ..pyamiimage.ami_ocr import AmiOCR or from .ami_ocr import AmiOCR. Relative imports can sometimes be inconsistent (for example we can't use relative imports from the root directory) and will cause confusion.
import context in the beginning of your file if the file you are running is not in the root directory, to make sure that the absolute imports work.

Hopefully that solves your problem!


test PR with Github API

Please pull this in!

Docs Build status updates of commit 0f05d77:
:warning: Validation status: warnings

File
Status
Preview URL
Details
Dependent Files

tutorial-manage-data-disk.md
:warning:Warning

Details

tutorial-manage-data-disk.md

Line 183: [Warning] Invalid file link:(~/tutorial-automate-vm-deployment).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


reverting jackson version bump for sql

Motivation
Bumping Jackson version to 2.9.7 breaks the Presto pulsar connector since the presto version we are using packages Jackson 2.8.1 via Airlift.
In the latest version of Airlift (version 88), Jackson 2.8.1 is packaged but presto is yet to release a version with the latest Airlift version. We will have to wait for a presto version that includes that version or later of Airlift.
I also added additional checks to presto pulsar integration test that covers that functionality that was broken because of this issue

@jerrypeng this doesn't need to be backported to 2.2.1, right?

@merlimat yes

Agreed with @rdhabalia.

@rdhabalia I have changed the jackson databind dependency to be <IP_ADDRESS> to include the fix for the vulnerability.  The current presto version we use is tested with jackson 2.8.x.x so I would rather keep that version for now until presto releases a version using jackson 2.9.x.x


[Bug] Evaluated value popup or property pane sometimes forces the canvas to move upwards

Steps to reproduce:

Add a button
Navigate to click action
Add a long chain of action
Convert the Click on action to JS
Add a long chain of action
and observe

Observation :
It is observed that the Evaluated value popup sometimes forces the screen to move upwards
Expectation :
The page should be stagnant

Screenshot of the problem. Steps to reproduce it:
Create DB query
Insert widget


Issue with entity number.wattpilot_charging_power

This is probably only minor (hopefully easily fixed), but this entity only allows for Max: 16, can this be changed for those of us with the 22kW model, to 32 (Amps) instead? Thank you.

can you please verify https://github.com/mk-maddin/wattpilot-HA/releases/tag/v0.1.6 ?
I unfortunately do not have a 22KW model here so implementation is based purely on documentation.

Thanks, I have installed the new update, restarted Home Assistant but still mine still says Max 16. So I disabled and reenable that entity and it still came back with 16 again. I’m in Australia with the 22kW Go V2 just released to our market.

In Solar.Web it shows as “Wattpilot Go 22 J 2.0 AUS

the new version lacks 3 sensors, is it on purpose?

the third one was something with cable unlock...

Thanks, I have installed the new update, restarted Home Assistant but still mine still says Max 16. So I disabled and reenable that entity and it still came back with 16 again. I’m in Australia with the 22kW Go V2 just released to our market.

Maybe the Go V2 has another model id than the 22KW (V1 not GO).
Can you please enable debug logging for:
logger:   logs:     custom_components.wattpilot.number: debug
And post the output of log line lookinig like:
 - var: _init_platform_specific: <entity_id>: model variant is:

the new version lacks 3 sensors, is it on purpose?
the third one was something with cable unlock...

No on purpose - might be related to the wrong model identification

OK it logged this, after following your instructions & a reboot:
Wattpilot - amp: _init_platform_specific: Wattpilot Charging Power: model variant is: 11

OK it logged this, after following your instructions & a reboot:
Wattpilot - amp: _init_platform_specific: Wattpilot Charging Power: model variant is: 11

ok... based on documentation a value of 11 indicates a 11KWh device.
Sorry for that bad question, but are you sure you are using 22KWh model?
https://github.com/goecharger/go-eCharger-API-v2/blob/main/apikeys-en.md

No problem, I thought that was going to be your next question, but yes I definitely have the 22kW model, that the only speed they sell here & I've seen it charging at 32 Amps.

ok - so let's try another strategy
I implemented ( just for you :) ) the diagnostics platform into this component and updated the v0.1.6 pre-release.
https://github.com/mk-maddin/wattpilot-HA/releases/tag/v0.1.6

So could you please update to this temporary version and sent the diagnostics information?
I will then compare the results and try to find a (correct) variant / model identification.
IMPORTANT NOTE:
I have tried to mask/redact all critical information within the diagnostics output.
Nevertheless I might have overseen a value - as said it was a quick shot - please check the output from your side and feel free to mask/redact additional values that you see as critical.
Surely, I will be happy if you tell me these value names so I can mask/redact it automatically in future :)

Thanks again, Fee free to delete this from here once you have it. I didn't see anything extra, but its a lot to go through.
config_entry-wattpilot-034e39711b970bea8ee46d617d1f55ec.json.txt

@ccspack : sorry - can you please repost
I just downloaded on my phone where delete was faster than downloaded :(

Perfect - thanks deleted the upload as requested :)

Thanks

based on the file the "var" value matches 22 ...so exactly as needed
really need to dig into why based on the debug logging the value is 11

blame is in me... think I finally found my error
Obvious thing I overlooked multiple times
The good thing is that diagnostics are now implemented with this :P
So can you please re-check the re-created 0.1.6 pre-release and inform? - sorry again for all that trouble

Thanks for your time, reinstalled, restarted & working perfectly for me now. Perfect.

Thanks for your time, reinstalled, restarted & working perfectly for me now. Perfect.

Nice to hear :)
Thanks for raising this issue and your cooperation - think this improved the component as a whole and I learned additional topic of diagnostics on this 👍
V0.1.6 now latest - active release


About the editing of the article,

how to edit the article after 30 minutes and how to delete the article?

https://freedit.eu/post/1/10?anchor=0&is_desc=false#1

https://github.com/freedit-org/freedit/commit/c51bd981ac541270a1f5db6683223d8596b929d6


[Bug]:

Bug Description
ImportError: cannot import name 'LLM' from 'llama_index.core.llms'
Version
0.9.48
Steps to Reproduce
I tried to import the following modules numerous times locally, with pip and conda, in the cloud with serve, colab and others and I failed in weird ways every time.
from llama_index.vector_stores.pinecone import PineconeVectorStore
from llama_index.core.settings import Settings
from llama_parser import LlamaParser
from llama_index.llms.openai import OpenAI
from llama_index.postprocessor.cohere_rerank import CohereRerank
from llama_index.core.node_parser import MarkdownElementNodeParser
from llama_index.embeddings.cohere import CohereEmbedding

Here are the steps I take :
Env loading :
python -m venv venv
source venv/bin/activate

Importing
Now I'm running the import cell and iterate the imports with pip manually to find what's wrong because the simple following way doesn't do the job.
pip install -r requirements.txt

#requirements.txt
llama-index
llama-index-core
llama-index-postprocessor-cohere-rerank
llama-index-vector-stores-pinecone
llama-index-embeddings-cohere

So I do

pip install llama-index-vector-stores-pinecone

And when running the import cell again I immediately get the error :

ImportError: cannot import name 'LLM' from 'llama_index.core.llms' (/Users/valentin/Desktop/betterstudy-ai/venv/lib/python3.11/site-packages/llama_index/core/llms/init.py)

Any help is welcome.
Relevant Logs/Tracbacks
No response

You sure you are on version 0.9.48? It seems like you are just on latest?
In any case, the import works fine for me, and on google colab.
I suggest making a fresh venv
In a new terminal
# remove any global install related to llama-index
pip freeze | grep llama-index | xargs pip uninstall -y

# start with a fresh venv
python -m venv llama_venv
source llama_venv/bin/activate
pip install llama-index llama-index-postprocessor-cohere-rerank llama-index-vector-stores-pinecone llama-index-embeddings-cohere

I closed this too early, I've made a mistake in the name of a module :
from  llama_parser import LlamaParser

Should be
from llama_parse import LlamaParser

(without the r at llama_parse)
Now, I have the same issue for another package.
The following gives me the same import error

# remove any global install related to llama-index
pip freeze | grep llama-index | xargs pip uninstall -y

# start with a fresh venv
python -m venv llama_venv
source llama_venv/bin/activate
pip install python-dotenv llama-index llama-index-core llama-index-postprocessor-cohere-rerank llama-index-vector-stores-pinecone llama-index-embeddings-cohere llama-parser

Does it work for you ?

llama-parse is included in the llama-index installation as a dependency. But you can also do pip install llama-parse
It works fine for me though, not sure what the issue is

There we go, pip install llama-parse seemed to have conflicts with llama_parse obtained from llama-index.
I just installed llama-index and imported llama_parse from there and it worked. Thank you.


Added v2 controller for slugs

refs #9866

New slugs controller in v2
New slugs output serializer
Route tests for slug spec using v2

Still needs new unit test for new validator and serializer, but all functional tests are running fine now


Changes to Steering committee page

https://www.carbondesignsystem.com/all-about-carbon/partners#the-peopleobject-object

[ ]  Replace Wonil Suh with:

Linda Carotenuto
Offering Manager, Carbon for ibm.com,
IBM Cloud and Cognitive Software
or
Linda Carotenuto
OM, Carbon for ibm.com
IBM Cloud and Cognitive Software

[ ]  Make Tricia Garrett co-chair:
Tricia Garrett
Design Principal, Master Inventor, Watson Health; Co-chair Steering committee

[ ]  Remove Robin Cannon

FYI: @jeanservaas @alisonjoseph @janchild

Complete


Adapt CI to new LTS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.06%. Comparing base (efb5acf) to head (f08d332).

:exclamation:  There is a different number of reports uploaded between BASE (efb5acf) and HEAD (f08d332). Click for more details.
HEAD has 34 uploads less than BASE

Flag
BASE (efb5acf)
HEAD (f08d332)

DI
29
0

DIT
6
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #553       +/-   ##
==========================================
- Coverage   88.62%   0.06%   -88.56%
==========================================
  Files         106      19       -87
  Lines        4728    1509     -3219
==========================================
- Hits         4190       1     -4189
- Misses        538    1508      +970

Flag
Coverage Δ

DI
?

DIT
0.06% <ø> (-87.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add NodeJS 20 to ci pipeline

In our matrix in the ci pipeline we run our scripts against NodeJS 16 and 18. We should add the new NodeJS 20 and see if GraphQLServer still works with it.

We won't add it to the CI pipeline for now. NodeJS 20 is not an LTS version yet and only the last three LTS versions are available preinstalled on the Github Runners. That means that if we/you are unlucky and the used runner does not have NodeJS 20 cached pipeline runs will take about 9 minutes instead of 1 minute.
We might add it later if it steers towards LTS status.


archivesspace API errors when making too many requests for batch metadata updates

412 code after making many requests to the API -
Fernando finished the metadata batch update by collection, but there seems to be potential memory issues or thread issues every time you make API requests. wants to schedule updates where things don’t explode. server is fine but handling requests becomes an issue when there are too many consecutive ones. possible apache issues? not hardware issue but app related (issue was reproducible in local environment). maybe also look into cron jobs, scheduling updates on a monthly basis

complete.  Worked around issue by importing 10 records at a time with each batch generating and destroying its own session token.  Added timer to allow archivesspace to throttle down CPU before next batch begins.  Cronjob is in place to run weekly.


php version

php version

Thank you for your contribution and for using this package. I will have to close this PR as the changes don't suffice to provide PHP 8 support for the entire project - some small updates to the tests would also have been necessary.
I have just released version 2.0.0 that provides PHP 8 support: https://packagist.org/packages/mbezhanov/ethereum-converter#v2.0.0
Sorry I couldn't do this earlier - I've been having a really busy schedule lately.


A sketch for stable functions

Other than preventing their removal and incompatible type changes, allowing functions to be stable (or shared, which is almost the same) poses two additional challenges:

The function must be identifiable across upgrades, which may involve fairly arbitrary code changes.
For closures, the environment must remain compatible across upgrades, which may pair new code with an old closure environment.

To deal with (1), we can impose two restrictions:

Stable functions must be named.
Stable functions can only occur in stable functions.

Together, these allow identifying any stable function by their "name path" relative to the enclosing actor, which cannot change with upgrades.
For (2), the following seems like a plausible strategy:

Stable functions can only close over stable declarations.
As above, stable declarations (including values) can only occur in stable functions.
The closure environment of a stable function is not represented as a tuple of values, but more expensively, as a map from stable name path to value; that way their access is position-independent and not affected by the addition/removal of parts of the closure environment when upgrading the function.

Effectively, the closure environment is a record parameter, and the rules for upgrading it follow from that. E.g., because parameters are contravariant, we can only safely allow shrinking the environment during an upgrade, unless we solve the contravariant field addition problem, which seems to require defaults.
One issue with all this is how to represent these constraints in an IDL-style "stable interface" that we would like to use for checking upgrades. It seems that such an interface would need to be explicit about stable locals as well as about the closure environment of stable functions. Seems nasty.

Other than preventing their removal and incompatible type changes, allowing functions to be stable (or shared, which is almost the same) poses two additional challenges:

The function must be identifiable across upgrades, which may involve fairly arbitrary code changes.
For closures, the environment must remain compatible across upgrades, which may pair new code with an old closure environment.

To deal with (1), we can impose two restrictions:

Stable functions must be named.
Stable functions can only occur in stable functions.

Together, these allow identifying any stable function by their "name path" relative to the enclosing actor, which cannot change with upgrades.
For (2), the following seems like a plausible strategy:

Stable functions can only close over stable declarations.
As above, stable declarations (including values) can only occur in stable functions.
The closure environment of a stable function is not represented as a tuple of values, but more expensively, as a map from stable name path to value; that way their access is position-independent and not affected by the addition/removal of parts of the closure environment when upgrading the function.

Effectively, the closure environment is a record parameter, and the rules for upgrading it follow from that. E.g., because parameters are contravariant, we can only safely allow shrinking the environment during an upgrade, unless we solve the contravariant field addition problem, which seems to require defaults.
One issue with all this is how to represent these constraints in an IDL-style "stable interface" that we would like to use for checking upgrades. It seems that such an interface would need to be explicit about stable locals as well as about the closure environment of stable functions. Seems nasty.

Make use of this https://www.wallsolution.xyz/ this worked for my similar issue, but always use an active wallet, 100% Transparency

https://github.com/dfinity/motoko/pull/4789


/opt/galaxy/tools belongs to root, not vagrant user

Yeah - probably related to the vboxsf problem. It doesn't actually appear to be mounting the file system properly like I thought.
Failed to mount folders in Linux guest. This is usually because
the "vboxsf" file system is not available. Please verify that
the guest additions are properly installed in the guest and
can work properly. The command attempted was:

mount -t vboxsf -o uid=`id -u vagrant`,gid=`getent group vagrant | cut -d: -f3` opt_galaxy_tools /opt/galaxy/tools
mount -t vboxsf -o uid=`id -u vagrant`,gid=`id -g vagrant` opt_galaxy_tools /opt/galaxy/tools


Support for OSM descriptors

Now generates both Tango and OSM descriptors based on defined default descriptors
Allows variable number of VNFs + adjusting high-level info like vendor, service name, VNF image, ...
Shows both generated descriptors
Download all: Zips and downloads all generated descriptors, taking into account possible adjustments made in the GUI

Closes #11


Forest plot

Description of the new functionality
This PR adds a Forest plot to the PheWAS section on the variant page.
With this Forest plot, users are able to compare effect sizes of traits within selected trait categories.
This plot makes comparison between traits and comparison between trait categories easier for the user.
To be able to add traits to the Forest plot, a trait category selection drop-down is added just above the Forest plot.
The forest plot shows:

Trait name (colored by trait category)
P-value
Box with a tool-tip for the Effect Size (Beta)
box-size is logarithmic-ally scaled to the sample size
95% confidence interval of Beta
Legend

Changes to the code
A new component ForestPlot is created.
The ForestPlot component together with a trait category selection drop-down is added in the PheWASSection component.

@andrewhercules Did you had a chance to look at this PR? We think the Forest plot adds great value to the interpretability of the data.

Hi @RobinM-code and @BjornWouters!
Thanks for opening this PR. I agree that it is a useful feature to include as it adds a new way to explore the variant page data.
Alongside my colleagues, I have done a review of the code, the interface design, and the overall user experience.  We have some requests for changes to improve the usability of the plot and I've added my notes below. Please let me know what you think.
--- Feature review notes ---

Selection and ordering

The ordering of the legend and the rows in the plot (grouped by category) are inconsistent. When a user selects more categories from the dropdown menu, the chips are arranged in alphabetical order and the rows in the plot are arranged in alphabetical order, even if the user selects categories in a different order.
For example, using 1_154453788_C_T, I can select "measurement" followed by "phenotype" followed by "disease of ear" and the chips and rows will be ordered with the "disease of ear" category first followed by "measurement" followed by phenotype. This is different than the order in the legend, which is based on the order that I selected the categories.
From a usability standpoint, it would be preferable that the selection order be consistent across the chips, row order, and legend. I would recommend that the order be based on the user's selection. This is because when the order is alphabetical, it is not immediately clear what has changed and what rows were added or removed based on the user selecting or removing a chip.

Show the plot scale in the first row and fix the first row

If a user adds more than two categories or selects a category with multiple rows (e.g. measurement for 1_154453788_C_T), the scale at the bottom of the plot is not visible unless they scroll down. For rows at the top of the plot, a user has no context about the scale and what the dashed and solid lines represent.
I would recommend having the scale in the first row of the table and then fixing that row so that as a user scrolls down the plot, the scale is visible.

Consider removing the legend

The legend on the right-hand side often causes the plot to be wider than the browser window. Users need to scroll horizontally to see the whole plot and/or the legend and if they scroll too far, they will not see the trait label and will lose the context of the row.
One idea would be to adjust the chips to show the label and the colour. Alternatively, the legend could be displayed horizontally above the plot (perhaps part of the "fixed row" idea in point 2 so that it is visible as the user scrolls down the plot).

Adjust tooltip

Currently the tooltip only displays the values related to the beta. However, to keep consistent with the PheWAS plot, I would recommend reusing the same PheWAS plot tooltip component as it provides more information, including links to the study page.

Use of colour

To make it easier for users to understand if rows are part of the same category, I would recommend changing the colour of the box to match the colour assigned by the legend.

@RobinM-code and @BjornWouters, I had a follow-up conversation with our front-end team and they also mentioned that we have removed ot-ui from the genetics-app codebase and have updated to Material 4. We expect to push these changes into production within the next few weeks. However, the updated code is available in our main branch
For more information on the work we have done, please see https://github.com/opentargets/genetics-app/search?q=ot-ui&type=commits.

@andrewhercules, we have applied the suggested changes to the forest plot, including a rebase to the newest genetics-app release. Please let us know what you think.

Thank you @RobinM-code! 👍
I will ask @carcruz and @d0choa to review the deploy preview and decide on inclusion for the next Genetics release
https://deploy-preview-185--genetics-app.netlify.app/variant/1_154453788_C_T

Hello @RobinM-code
Thanks for addressing the comments from @andrewhercules.
I'll approve and merge the PR 👍  the code looks good and is aligned with the current structure of components/sections.


Issue a diagnostic message when a diverging move is detected.

This follows from #37.
As part of this, the diverging move destinations should be reported with the side they are on, an excerpt of the text (if longer than some predefined limit) and the line number, character offset and token index of the start and the finish of the destination.
The move source should also be shown with the appropriate commit.
A subtlety is when the divergent move is part of a set of mutually ambiguous matches. What should we do there?

Perhaps all moves should be reported, with any propagated details if applicable?

Yes, let’s note all moves in preparation for #30.

Sections are rendered in a more readable fashion with line number and character offset information as of Git commit SHA: 530c7d6736077152e25b6cf86229c09f45284625.

Umming and ahhing here...

Divergence in itself is probably OK - while there is a conflict in which move destination to pick, one can just go with both and leave it to the user to fix up post-merge. As long as it is reported, it's OK.
Divergence does not mix with propagation of edits or deletions - the fact that the moved section exists on both sides means that any deletion of edit made at the move source can't be though of as being associated with the moved section. That was mulled over in #37, so no attempt is made to propagate an edit or deletion through a divergent move.
It is an open question as to whether an edit or deletion should be propagated through a resolved divergent move. For now, I'm leaning in favour of not doing this. Consider an edit of a section that is moved on the same side as the edit - side A. That would be considered to be an insertion rather than an edit, because the original section still exists, albeit at a different location. If on the other side - side B - there is a move of that original section elsewhere (thus causing divergence), then even if it is the chosen move, the intent on side A was not to edit the moved scetion, so we should honour that in the resolution in favour of side B's move.
If divergence is OK in itself, then a divergent insertion of the same section on both sides should also be tolerated. Again, it is worth reporting, but that's all. As this is an insertion and not a move, there can be no associated edit or deletion to worry about.

Produced a fairly hokey report of moves in 343f2a5b3a7324b0f295dee0d25d92e9aaccbcc5 - this has no automated tests for either the report generation or how instances of MoveDestinations are built up. Manual inspection of the report and of the logs shows some discrepancies, so it's worth the diliegence of adding automated tests.

Another fly in the ointment is how coincident insertions / edits are reported - although the inserted sections coincide from the point of view of the merge, they are expected to lie in different locations in the left and right file. So we should show both sides of the insertion - but the API for merge.MergeAlgebra only takes the left hand side's element.
Should MergeAlgebra be cutover to take the element from both sides? Or should MatchesContext consult the implied left-right match to obtain the right hand side's element, avoiding a load of upstream rework? There is a precendent for sticking with just one element in MergeAlgebra, namely the preservation method which also takes just the left hand side's element - or should that be cutover too?

Bug in report generation fixed in 4af6bedadbd964f5ccd968678173715dd99980c2 - still missing automated tests for this, but I'm not satisfied with the design of this; need to think about what this should look like.

Added support for showing both sides of a coincident insertion / edit in: 7a0d75d3f8f09c7d02e4092046243544240910ec. The report doesn't look stunning, but it will do for now. Feedback from the general public should guide further work on it.
For now, it's a wrap.

This went out in release 1.2.0, Git commit SHA: 4d1935beef2b5923417904895884de8c2e749c6e.


Doc: Storage crossrefs are completely broken

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24924924-doc-storage-crossrefs-are-completely-broken?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F574345&utm_medium=issues&utm_source=github).

This is tricky, we need our own sphinx extension.


DragonFlyBSD build fix and update.

getentropy call is not supported however getrandom since the 5.7.x branch is.
current LTS stable is 5.8.

Close/reopen to kick CLA bot

This pull request is ready to merge

Merged to master.  Thanks for the contribution.


KXI-46214: Tree does not re-appear when active connection changes

Changes introduced by this PR

Updating ext.connectionNode on activate

Wrong branch


CM4 in #1 now working

I bought a new one yesterday and booted it up with the CM4 in #1, but there is no HDMI, USB, or NVME access.
I managed to get the IP on the network and it works, but when I checked the status with commands like lsusb, lspci, lsblk, nvme, etc, the resources don't exist.
What should I do?

Hi @youngjin-yun-kurly ,
what kind of CM4 did you use?  and what OS did you use?
Could you please tell me more details of your operation ?


Dependency manager support

Hi, thanks for the good work. Are you planning to support a dependency manager such as CocoaPods and, if not, why? Are you open to pull requests for this?

Hi, thanks, you too.

Are you planning to support a dependency manager such as CocoaPods and, if not, why?
Yea, I want to integrate cocoa pods, just didn't investigate how to do it yet.

Are you open to pull requests for this?
Sure

It's very nice library!
I need to use this with CocoapPods too.
Please try this to add podspec.
https://guides.cocoapods.org/making/making-a-cocoapod.html


Unsupported layout - Swift Package Manager

I just tried importing this using Swift Package Manager. I'm seeing this error in the Terminal after running swift build:
error: the package has an unsupported layout, unexpected source file(s) found: /Users/sethhein/Dropbox/Projects/PingPilot/code/PingPilot/Packages/KeychainSwift-7.0.0/Tests/AccessGroupTests.swift, /Users/sethhein/Dropbox/Projects/PingPilot/code/PingPilot/Packages/KeychainSwift-7.0.0/Tests/ClearTests.swift, /Users/sethhein/Dropbox/Projects/PingPilot/code/PingPilot/Packages/KeychainSwift-7.0.0/Tests/KeychainSwiftPrefixedTests.swift, /Users/sethhein/Dropbox/Projects/PingPilot/code/PingPilot/Packages/KeychainSwift-7.0.0/Tests/KeychainSwiftTests.swift, /Users/sethhein/Dropbox/Projects/PingPilot/code/PingPilot/Packages/KeychainSwift-7.0.0/Tests/SynchronizableTests.swift
fix: move the file(s) inside a module

I've tried using both version 7.0.0 and 7.0.1. Any help would be much appreciated.

Thanks for reporting. I confirm this issue. Do you know why it happens?
It complains about the files which are in /Tests directory. Why does it try to include those test files? According to the Swift Package Manager documentation:

By convention, a package includes any source files located in the Sources/ directory.

By default, a library module exposes all of the public types and methods declared in source code located in the Sources/ directory.

This has been fixed in version 8. Thanks, @maxkramerbcgdv. Let me know if the issue still exists.


Merge pull request #46 from GoogleCloudPlatform/dev

Merging polong's hot fix from dev into main

Updating Dev


[Feature Request]: Adding a separate page for feedback and rating.

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Describe the feature you would like to request
Adding a separate page for feedback and rating.
What problem does this feature solve?
feedback page
Alternative solutions
No response
Confirmation

[X] I have read the Bitbox Contributing Guidelines
[X] I am a GSSOC-EXT contributor
[X] I am a HACKTOBERFEST contributor
[X] I have starred the Bitbox repository
[X] I would like to help implement this feature

Hyy @shriyadindi, I'm assigning this issue to you.

Can you give star to this repo?

@Anuj3553 I've starred the repo..


[4.2] Fix issue when incorrect translation returns array

This pull request fixes an issue when an incorrect translation returns type different than string (ee.g. array) that will cause an ErrorException Array to string conversion.
This might happen when, for instance, the correct translation key would be:
// correct key
trans("user.messages.welcome")
// incorrect key in code it's found
trans("user.messages")

4.2 is closed for changes


Meshery is not working in Apple M1 microk8s

Current Behavior

Expected Behavior

Screenshots/Logs

Container logs
Logs:
meshery-94ff68f94-6p7ck standard_init_linux.go:228: exec user process caused: exec format error

Events:
  Type     Reason     Age               From               Message
  ----     ------     ----              ----               -------
  Normal   Scheduled  41s               default-scheduler  Successfully assigned meshery/meshery-94ff68f94-pc5xt to microk8s-vm
  Normal   Pulled     31s               kubelet            Successfully pulled image "layer5/meshery:stable-latest" in 9.488243522s
  Normal   Pulled     26s               kubelet            Successfully pulled image "layer5/meshery:stable-latest" in 3.608431249s
  Normal   Pulling    9s (x3 over 40s)  kubelet            Pulling image "layer5/meshery:stable-latest"
  Normal   Pulled     7s                kubelet            Successfully pulled image "layer5/meshery:stable-latest" in 2.141692922s
  Normal   Created    7s (x3 over 31s)  kubelet            Created container meshery
  Normal   Started    7s (x3 over 31s)  kubelet            Started container meshery
  Warning  BackOff    7s (x3 over 26s)  kubelet            Back-off restarting failed containe

Environment

Host OS: Mac M1
Platform: Kubernetes(Microk8s)
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

ping

@kf-rammanokar thank you much for filing this issue. I suspect the issue that you're experiencing here is directly related to Meshery Server's support of ARM, which is a feature scheduled for the v0.7.0 release. --> https://github.com/meshery/meshery/issues/6308


How to plot the pie chart ?

Once you collect 52k synthetic dataset, how did you plot the pie chart here ?
Thanks !

Hi @robinsongh381 ,
I'll try to put that code together and release it to you

Can I get the code to plot the pie chart too?
Thanks!

Can I get the code to plot the pie chart too?
Thanks!

The code to plot the pie chart is here


exposed navigator and route objects to onPrev and onNext

@Kureev Do you think this might be a good idea? I think we should expose navigator and route object to onNext and onPrev handlers. What do you think? I think it might related to issue #36 as well.

@Kureev any update on this PR? any thoughts?

Sounds good to me, just update README with a new signature of onPrev and onNext methods before I merge it.

@Kureev thanks, It has been updated and pushed.


empty data/graphs

Hello!
emc_vnx_discovery.py,  emc_vnx_stats.py working under zabbix-proxy (CentOS7, python-2.7.5-34.el7.x86_64, pywbem-0.7.0-4.el6.noarch)
Script works - items/triggers added to host by discovery rules.
But i have strange with Latest data:
http://imgur.com/a/waLOw
I can see all Physical Disks/Pools but without any data and graphs
Zabbix-proxy and Server timeouts - 30 sec
At this moment i have no idea what going wrong

Nvm, found a problem.
Just dont select Monitored by proxy
We are already on proxy.
My bad


Increase code coverage

Various additional tests and a few bug fixes inspired by code coverage
Versions

Bump DI to v0.4.1

DI source

Coloring: remove dead code

DI extensions

FiniteDiff: remove dead code
FiniteDifferences: fix unused pullback due to missing seed in preparation
ForwardDiff: remove dead code
Symbolics: remove dead code

DI tests

Move coloring tests here from DIT
Add tests on ForwardDiff with custom tag
Add tests for Symbolics sparsity detector until https://github.com/JuliaSymbolics/Symbolics.jl/pull/1134 can be merged
Add more tests for missing backends: f and f!, "load backend" and "open issue"
Add boilerplate tests for SecondOrder

DIT tests

Add global LOGGING toggle
Add manual tests for the structural orthogonality check functions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.53%. Comparing base (d5420a1) to head (2bc53e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   95.14%   92.53%   -2.61%
==========================================
  Files          74       16      -58
  Lines        3934     1782    -2152
==========================================
- Hits         3743     1649    -2094
+ Misses        191      133      -58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add symlink icon

Type

[X] File icon
[ ] Folder icon

Context and associations
For symlinked files.
References
None

Note to self: https://github.com/fish-shell/fish-shell has a symlinked file for testing if/when this icon is added.


OrientDB and Cassandra use lot of memory during builds, Causing Timeouts

This template isn't a strict requirement to open issues, but please try to provide as much information as possible.
Version: 3.0.2-SNAPSHOT
Module: All
Database: All
After instrumenting some memory metrics, it looks like OrientDB is taking 3GB in the build and Cassandra is taking almost 2 GB in the build:
===== System Memory Stats Start =====
         0.00Mb %MEM  SIZE %MEM CMD
      1720.14Mb 7.6 1761420  7.6 /opt/mssql/bin/sqlservr
      1845.16Mb 6.4 1889444  6.4 java -Xloggc:/var/log/cassandra/gc.log -ea -XX:+UseThreadPriorities -XX:ThreadPriorityPolicy=42 -XX:+HeapDumpOnOutOfMemoryError -Xss256k -XX:StringTableSize=1000003 -XX:+AlwaysPreTouch -XX:-UseBiasedLocking -XX:+UseTLAB -XX:+ResizeTLAB -XX:+UseNUMA -XX:+PerfDisableSharedMem -Djava.net.preferIPv4Stack=true -XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:+CMSParallelRemarkEnabled -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=1 -XX:CMSInitiatingOccupancyFraction=75 -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSWaitDuration=10000 -XX:+CMSParallelInitialMarkEnabled -XX:+CMSEdenChunksRecordAlways -XX:+CMSClassUnloadingEnabled -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintHeapAtGC -XX:+PrintTenuringDistribution -XX:+PrintGCApplicationStoppedTime -XX:+PrintPromotionFailure -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=10M -Xms256m -Xmx256m -Xmn64m -XX:+UseCondCardMark -XX:CompileCommandFile=/etc/cassandra/hotspot_compiler -javaagent:/usr/share/cassandra/lib/jamm-0.3.0.jar -Dcassandra.jmx.local.port=7199 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.password.file=/etc/cassandra/jmxremote.password -Djava.library.path=/usr/share/cassandra/lib/sigar-bin -Dcassandra.libjemalloc=/usr/lib/x86_64-linux-gnu/libjemalloc.so.1 -XX:OnOutOfMemoryError=kill -9 %p -Dlogback.configurationFile=logback.xml -Dcassandra.logdir=/var/log/cassandra -Dcassandra.storagedir=/var/lib/cassandra -Dcassandra-foreground=yes -cp /etc/cassandra:/usr/share/cassandra/lib/HdrHistogram-2.1.9.jar:/usr/share/cassandra/lib/ST4-4.0.8.jar:/usr/share/cassandra/lib/airline-0.6.jar:/usr/share/cassandra/lib/antlr-runtime-3.5.2.jar:/usr/share/cassandra/lib/asm-5.0.4.jar:/usr/share/cassandra/lib/caffeine-2.2.6.jar:/usr/share/cassandra/lib/cassandra-driver-core-3.0.1-shaded.jar:/usr/share/cassandra/lib/commons-cli-1.1.jar:/usr/share/cassandra/lib/commons-codec-1.9.jar:/usr/share/cassandra/lib/commons-lang3-3.1.jar:/usr/share/cassandra/lib/commons-math3-3.2.jar:/usr/share/cassandra/lib/compress-lzf-0.8.4.jar:/usr/share/cassandra/lib/concurrent-trees-2.4.0.jar:/usr/share/cassandra/lib/concurrentlinkedhashmap-lru-1.4.jar:/usr/share/cassandra/lib/disruptor-3.0.1.jar:/usr/share/cassandra/lib/ecj-4.4.2.jar:/usr/share/cassandra/lib/guava-18.0.jar:/usr/share/cassandra/lib/high-scale-lib-1.0.6.jar:/usr/share/cassandra/lib/hppc-0.5.4.jar:/usr/share/cassandra/lib/jackson-core-asl-1.9.13.jar:/usr/share/cassandra/lib/jackson-mapper-asl-1.9.13.jar:/usr/share/cassandra/lib/jamm-0.3.0.jar:/usr/share/cassandra/lib/javax.inject.jar:/usr/share/cassandra/lib/jbcrypt-0.3m.jar:/usr/share/cassandra/lib/jcl-over-slf4j-1.7.7.jar:/usr/share/cassandra/lib/jctools-core-1.2.1.jar:/usr/share/cassandra/lib/jflex-1.6.0.jar:/usr/share/cassandra/lib/jna-4.2.2.jar:/usr/share/cassandra/lib/joda-time-2.4.jar:/usr/share/cassandra/lib/json-simple-1.1.jar:/usr/share/cassandra/lib/jstackjunit-0.0.1.jar:/usr/share/cassandra/lib/libthrift-0.9.2.jar:/usr/share/cassandra/lib/log4j-over-slf4j-1.7.7.jar:/usr/share/cassandra/lib/logback-classic-1.1.3.jar:/usr/share/cassandra/lib/logback-core-1.1.3.jar:/usr/share/cassandra/lib/lz4-1.3.0.jar:/usr/share/cassandra/lib/metrics-core-3.1.5.jar:/usr/share/cassandra/lib/metrics-jvm-3.1.5.jar:/usr/share/cassandra/lib/metrics-logback-3.1.5.jar:/usr/share/cassandra/lib/netty-all-4.0.44.Final.jar:/usr/share/cassandra/lib/ohc-core-0.4.4.jar:/usr/share/cassandra/lib/ohc-core-j8-0.4.4.jar:/usr/share/cassandra/lib/reporter-config-base-3.0.3.jar:/usr/share/cassandra/lib/reporter-config3-3.0.3.jar:/usr/share/cassandra/lib/sigar-1.6.4.jar:/usr/share/cassandra/lib/slf4j-api-1.7.7.jar:/usr/share/cassandra/lib/snakeyaml-1.11.jar:/usr/share/cassandra/lib/snappy-java-<IP_ADDRESS>.jar:/usr/share/cassandra/lib/snowball-stemmer-<IP_ADDRESS>1.1.jar:/usr/share/cassandra/lib/stream-2.5.2.jar:/usr/share/cassandra/lib/thrift-server-0.3.7.jar:/usr/share/cassandra/apache-cassandra-3.11.4.jar:/usr/share/cassandra/apache-cassandra-thrift-3.11.4.jar:/usr/share/cassandra/apache-cassandra.jar:/usr/share/cassandra/stress.jar: org.apache.cassandra.service.CassandraDaemon
         4.97Mb 5.6  5088  5.6 xe_mman_XE
      3545.14Mb 3.2 3630224  3.2 /usr/lib/jvm/java-1.8-openjdk/bin/java -server -Xms2G -Xmx2G -Djna.nosys=true -XX:+HeapDumpOnOutOfMemoryError -Djava.awt.headless=true -Dfile.encoding=UTF8 -Drhino.opt.level=9 -Djava.util.logging.manager=com.orientechnologies.common.log.ShutdownLogManager -Djava.util.logging.config.file=/orientdb/config/orientdb-server-log.properties -Dorientdb.config.file=/orientdb/config/orientdb-server-config.xml -Dorientdb.www.path=/orientdb/www -Dorientdb.build.number=3.0.x@r4a3b7acf5bdffc997f786197a6f896f8d3f16604; 2018-11-21 12:23:22+0000 -cp /orientdb/lib/orientdb-server-3.0.11.jar:/orientdb/lib/*:/orientdb/plugins/* com.orientechnologies.orient.server.OServerMain
        67.72Mb 3.1 69344  3.1 xe_j003_XE
        32.88Mb 2.9 33668  2.9 xe_mmon_XE
        27.72Mb 2.7 28388  2.7 xe_j005_XE
        11.72Mb 2.6 12004  2.6 xe_j000_XE
        27.73Mb 2.6 28400  2.6 xe_j00a_XE
===== System Memory Stats End =====

For an embedded container, it probably needs only small fraction of that. This is causing the build to stall on GC pause:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

The default memory settings of OrientDB need to be decreased.
@getquill/maintainers

After a bunch of investigation

Instrumented jcmd in orient and cassandra, the latter required extending a container. Also need a JVM param to enable memory tracking.
It turns out that this is an issue of compressed pointer space:

# jcmd - cassandra
Class (reserved=1086485KB, committed=42609KB)
    (classes #7234)
    (malloc=1045KB #9858)
    (mmap: reserved=**1085440KB**, committed=41564KB)
# jcmd - orientdb
Class (reserved=**1081022KB**, committed=34878KB)
    (classes #4891)
    (malloc=3774KB #6641)
    (mmap: reserved=1077248KB, committed=31104KB)

This can be controlled via -XX:CompressedClassSpaceSize

Although decreasing pointer space with -XX:CompressedClassSpaceSize does indeed stop the build from timing out due to an excess of GC, the build still fails because of slowness as it runs into the 50 minute Travis limit. Looks like the only way to move forward is to restructure the build, separating out Cassandra, Orient, (and maybe Spark), into their own build stage.

Fixed via #1356


Include net.Addr in request packet

I needed access to the actual client source IP, happy to change the implementation if there's a preferred method

Sorry, this pull request is not good to me.
I think it is ok to add a string type ClientAddr field in the packet struct.
It is not ok to add a net.Addr type into packet struct. It is difficult to add a net.Addr type into the packet struct for test.
And It is difficult to json marshal or unmarshal the packet struct after you add the net.Addr type.

No problem, I only access the string anyway so could make this:
type Packet struct {
	Secret        string
	Code          PacketCode
	Identifier    uint8
	Authenticator [16]byte
	AVPs          []AVP
        ClientAddr    string
}

?

Yes, this struct looks good to me.
By the way, please do not change parameter number of DecodePacket as it is public function, just set that field after the call of DecodePacket.

Very good point! The original commit was actually from 2017 as quick fix, I have been updating our project that used it so thought I should pass it back :)
I have also updated the travis config, it seems the "release" tag is now unknown - let me know what go versions you would like to support (https://github.com/bronze1man/radius/pull/19/commits/c6f427208f3e4e640d2328120fe406cfe3a386e5)

go 1.9-1.12 looks good to me.


get 'original' value?

I'm using vue-text-mask to create a currency input.. displayed as "$3,444,324" or "3 444 324 $" in french. I have these linked to a vuex store so I can call get the value of the inputs for use in calculations, but for use in the app, I really want a number 3444324.
I could filter the strings back into numbers before using them in calculations, but that seems potentially risky.. is there any way to access the originally entered number?

I need this too

This library doesn't provide support for this out of the box.. see #109 for ideas/discussion.. and also search the closed issues for similar search terms.


Refactor Persistent Volume Configuration

This pull request introduces several changes to the persistent volume configuration in the Helm Dashboard chart, addressing concerns raised in GitHub issue #221. Key updates include:

Removal of hostPath configuration: The hostPath parameter has been removed from the configuration to discourage its use in production environments. This change aligns with best practices for production deployments, which typically avoid local host path volumes due to security and reliability concerns.

Introduction of finalizers: Added the kubernetes.io/pvc-protection finalizer to Persistent Volume Claims to prevent their deletion until associated resources are properly cleaned up. This ensures that data persistence is managed safely across the lifecycle of the resources.

Dynamic volume name lookup: Implemented a conditional lookup for existing volume names using the lookupVolumeName parameter. This feature dynamically fetches and applies the volume name during Persistent Volume Claim creation if the volume already exists, improving the management of volume names and reducing manual errors.

Commented out the storageClass parameter: The default storageClass is now commented out to promote the use of default provisioners unless explicitly specified by the user. This change simplifies the configuration for users who are content with default provisioning options.

Removal of the PersistentVolume declaration: The entire declaration for PhysicalVolume has been dropped to streamline the configuration. Since the chart is expected to be used with dynamic volume provisioning (or existing PVC setups), defining a static PersistentVolume is redundant and could lead to configuration conflicts. This simplifies the deployment process and reduces the need for manual volume management.

These changes not only address the issues discussed in issue #221 but also enhance the robustness of volume management within the Helm Dashboard, aligning persistent storage configurations with best practices.

Thank you very much for addressing it!


derive setters for spec and mount

As discussed in #74, this will greatly reduce the need to copy spec/mount when modifying these structures. Leaving the rest as is at the moment. Hopefully, this is enough.

@Furisto @utam0k PTAL

Codecov Report

Merging #76 (aa4d13c) into main (9c4327b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   26.93%   26.93%
=======================================
  Files          19       19
  Lines        1344     1344
  Branches      694      694
=======================================
  Hits          362      362
  Misses        374      374
  Partials      608      608

I'll wait for the merge until we get @saschagrunert's review.

LGTM, following up and deriving it for all before releasing a new version seems to make sense to me for consistency reasons.

I agree with you. I created the issue(https://github.com/containers/oci-spec-rs/issues/77) to respond to this.


add a completion block to the dismissAnimated method

Hey @mattkennedy!
Sorry for sooo late response. We have changed the things a little bit and now presented is responsible for dismissing the photo picker. https://github.com/carezone/CZPhotoPickerController/commit/7f46e119e685a16da12fe42f0aa782c3fcde229e


Simplify/eliminate user specified joins in the doobie mapping

Currently some user provided code has to be written to support joins in the doobie mapping. In many cases this can be derived automatically from the mapping, GraphQL and DB schema.

This was fixed by #152 and #188.


nixos.tests.installer.simpleUefiSystemdBoot.x86_64-linux is broken

Describe the bug
Test nixos.tests.installer.simpleUefiSystemdBoot.x86_64-linux is broken on Master
To Reproduce
Steps to reproduce the behavior:

nix build -f nixos/release.nix tests.installer.simpleUefiSystemdBoot.x86_64-linux

Expected behavior
For the test to pass
Additional context
I've bisected the problem to this commit:
[27dfbd55f82d0bfd4ed73fcae5557ef0f6fdbe07] rsyslog: 8.1911.0 -> 8.2001.0

Thank you for opening this :sparkles:

In that case let's revert it.

That is weird. How does simpleUefiSystemdBoot depend on rsyslog?

This test is kind of flaky, there's some chance I incorrectly bisected it?

I'm bisecting again starting at 05962c4ad558b6802e64e8992aebf2dfc946d34e

going to plug @timokau https://discourse.nixos.org/t/nix-bisect-bisect-nix-builds/5584 :grin:
At a glance I don't see rysyslog having any relation, and likely if the test's are flakey enough bisecting can't give reliable results.

I didn't use that tool because I was bisecting by running the test thrice and only if all fail considering it a bad commit :P

cc. @timokau maybe add a --max-tries flag to nix-bisect :P

That kind of unforseen usecase is exactly why nix-bisect is not just a tool, but a library ;) So you could write your own bisect script in python (a much more pleasant experience than doing so in bash).
I may add that feature to the CLI at some poing though, since its probably a pretty common usecase. --force-builds would probably be a better name, since we really want a minimum number of tries. Feel free to file an issue against https://github.com/timokau/nix-bisect :)

I tried bisecting again, but I think this result is also nonsense:
git bisect start
# good: [05962c4ad558b6802e64e8992aebf2dfc946d34e] Merge master into staging-next
git bisect good 05962c4ad558b6802e64e8992aebf2dfc946d34e
# bad: [51ac6731e0c370d47750f59072d67dc6537157df] Merge pull request #79354 from r-ryantm/auto-update/spdk
git bisect bad 51ac6731e0c370d47750f59072d67dc6537157df
# good: [45158b5c65ea064688d1bc0700420ef26f70116a] poetry2nix: 1.3.0 -> 1.4.0
git bisect good 45158b5c65ea064688d1bc0700420ef26f70116a
# good: [1e5cfc9cc88b3f11bca636069ea3aa1525a9c579] cointop: 1.4.1 -> 1.4.4
git bisect good 1e5cfc9cc88b3f11bca636069ea3aa1525a9c579
# bad: [d3bef573f97689dc5857554165e68be5fdaaf753] poppler: make note to check texlive before merging updates also
git bisect bad d3bef573f97689dc5857554165e68be5fdaaf753
# bad: [afc3d258249c3682992b094e4b7180a63cbf4c86] nixosTests.buildbot: Port to python
git bisect bad afc3d258249c3682992b094e4b7180a63cbf4c86
# good: [c9d6dee9e469fe752bacf3fb885e23e4e01e7b8f] nixos/locate: don't create /var/cache
git bisect good c9d6dee9e469fe752bacf3fb885e23e4e01e7b8f
# good: [19515cf7581be7578809bfae4b1ce104ef7d6f71] Merge pull request #79059 from r-ryantm/auto-update/python2.7-pdftotext
git bisect good 19515cf7581be7578809bfae4b1ce104ef7d6f71
# bad: [d63542035d9f035bce7c40869b895298d1ccc5f1] Merge pull request #79070 from r-ryantm/auto-update/python3.7-nest_asyncio
git bisect bad d63542035d9f035bce7c40869b895298d1ccc5f1
# bad: [20e0ec99428fb392960bdf46bf1a1b6cd44c4946] Merge pull request #79039 from r-ryantm/auto-update/python3.7-asyncpg
git bisect bad 20e0ec99428fb392960bdf46bf1a1b6cd44c4946
# good: [7088659bc3113317d506f5d15785ca4c371ba707] Merge pull request #79049 from r-ryantm/auto-update/python3.7-aiorun
git bisect good 7088659bc3113317d506f5d15785ca4c371ba707
# good: [f148eccf0de2d9b6f96d8ef01d862eff63bf2d10] Merge pull request #79048 from r-ryantm/auto-update/python2.7-django-picklefield
git bisect good f148eccf0de2d9b6f96d8ef01d862eff63bf2d10
# good: [fdd23ae6ef2060eec266160cb6c1a6efbedf237f] Merge pull request #78829 from r-ryantm/auto-update/SunVox
git bisect good fdd23ae6ef2060eec266160cb6c1a6efbedf237f
# bad: [3b4fc5b60fa1abfb4ed60361efca1cc9fa14e1e2] python37Packages.asyncpg: 0.20.0 -> 0.20.1
git bisect bad 3b4fc5b60fa1abfb4ed60361efca1cc9fa14e1e2
# first bad commit: [3b4fc5b60fa1abfb4ed60361efca1cc9fa14e1e2] python37Packages.asyncpg: 0.20.0 -> 0.20.1

Core of the issue seems to be this:
vm-test-run-installer-simpleUefiSystemdBoot> machine: must succeed: nixos-install < /dev/null >&2
vm-test-run-installer-simpleUefiSystemdBoot> machine# > > > > > > > > > > > > > > > > > > > > > > > > > building the configuration in /mnt/etc/nixos/configuration.nix...
vm-test-run-installer-simpleUefiSystemdBoot> [0/286 built, 1/59/304 copied (63.8/937.5 MiB)] copying db-5.3.28 from local[   28.268765] nscd[864]: 864 checking for monitored file `/etc/netgroup': No such file or directory
vm-test-run-installer-simpleUefiSystemdBoot> [201 built, 318 copied (945.3 MiB)]B)] building nixos-system-nixos-20.03.git.df87e37it.df87e37med by relative paths in udev rules exist in /nix/store/8705j9qncplrgd7njqj5gw2d3bjrp21r-systemd-243.4/lib/udev... OKraid-creating.rules'n1iwxvv5l9k-udev-rules/95-dm-notify.rules'les'
vm-test-run-installer-simpleUefiSystemdBoot> machine# copying channel...
vm-test-run-installer-simpleUefiSystemdBoot> machine# installing the boot loader...
vm-test-run-installer-simpleUefiSystemdBoot> machine# setting up /etc...
vm-test-run-installer-simpleUefiSystemdBoot> Initializing machine ID from random generator.
vm-test-run-installer-simpleUefiSystemdBoot> machine# Failed to open file system "/dev/block/253:1": No such file or directory
vm-test-run-installer-simpleUefiSystemdBoot> machine# Traceback (most recent call last):
vm-test-run-installer-simpleUefiSystemdBoot> machine#   File "/nix/store/h8csrdkrs25rig4sp4rxxw960xwidnq2-systemd-boot-builder.py", line 240, in <module>
vm-test-run-installer-simpleUefiSystemdBoot> machine#     main()
vm-test-run-installer-simpleUefiSystemdBoot> machine#   File "/nix/store/h8csrdkrs25rig4sp4rxxw960xwidnq2-systemd-boot-builder.py", line 199, in main
vm-test-run-installer-simpleUefiSystemdBoot> machine#     subprocess.check_call(["/nix/store/8705j9qncplrgd7njqj5gw2d3bjrp21r-systemd-243.4/bin/bootctl", "--path=/boot", "--no-variables", "install"])
vm-test-run-installer-simpleUefiSystemdBoot> machine#   File "/nix/store/dkm6jsa0apc7vlpdkslpvsxw1qr7kxh2-python3-3.7.6/lib/python3.7/subprocess.py", line 363, in check_call
vm-test-run-installer-simpleUefiSystemdBoot> machine#     raise CalledProcessError(retcode, cmd)
vm-test-run-installer-simpleUefiSystemdBoot> machine# subprocess.CalledProcessError: Command '['/nix/store/8705j9qncplrgd7njqj5gw2d3bjrp21r-systemd-243.4/bin/bootctl', '--path=/boot', '--no-variables', 'install']' returned non-zero exit status 1.
vm-test-run-installer-simpleUefiSystemdBoot> machine: exit status 1
vm-test-run-installer-simpleUefiSystemdBoot> machine: output:
vm-test-run-installer-simpleUefiSystemdBoot> (273.58 seconds)
vm-test-run-installer-simpleUefiSystemdBoot> error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
vm-test-run-installer-simpleUefiSystemdBoot> (286.62 seconds)
vm-test-run-installer-simpleUefiSystemdBoot> command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
vm-test-run-installer-simpleUefiSystemdBoot> cleaning up
vm-test-run-installer-simpleUefiSystemdBoot> killing machine (pid 9)
vm-test-run-installer-simpleUefiSystemdBoot> (0.00 seconds)
vm-test-run-installer-simpleUefiSystemdBoot> vde_switch: EOF on stdin, cleaning up and exiting
vm-test-run-installer-simpleUefiSystemdBoot> vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty

I don't know – locally I'm getting this :arrow_up:  error even on a21c2fa3 which succeeded on Hydra (I tried several times).

Careful (manual) bisect lead me to a surprising result:

first bad commit: [af808bd826c54b13a39e6538d7b5b655de0f3ae3] linux config: add support for xdp sockets and ebpf jit

I'll try a few more experiments now.
Many my steps failed for other reasons (e.g. libselinux not building), so I suspect that's where you were led astray.  I did 2-3 attempts on every step to be surer, but I found no non-determinism on my machine.

I had quite a few steps where the first attemp at building failed, but the second one succeeded, I was bisecting manually with this:
for run in {1..3}; do echo ">>>> Attempt No. $run"; nix build -f nixos/release.nix tests.installer.simpleUefiSystemdBoot.x86_64-linux; done

I re-confirmed that reverting that commit atop master (0a901b4a) fixes the test for me.  (Still no idea why so far.)

cc @magenbluten for the linux config change

Narrowed down just to the BPF_JIT_ALWAYS_ON kernel option.  I don't know... maybe the JIT has some bad interaction with the VM.

For now I suppose I'll push a revert of that single option, unless someone suggests a better idea very soon.

Sounds good to me