Processing request with an empty Content-Type header causes ArgumentNullException when accessing that header or enumerating all headers

Tested with Microsoft.AspNetCore.Server.HttpSys version 2.0.2 on Windows 10 Fall Creator's Update
Steps to reproduce:

dotnet new webapi (using .Net Core SDK 2.0.*)
Optionally add a specific dependency to HttpSys 2.0.2
dotnet restore
In Program.cs, add UseHttpSys() in the host builder chain
dotnet run
POST http://localhost:5000/api/values, set header Content-Type without a value

This will give a 500 response, since first the Model Binder throws when checking if the request is a form, and then the developer exception page throws when enumerating the request headers.
The log should show both stack traces. They have the top part in common:
System.ArgumentNullException: Array cannot be null.
Parameter name: chars
   at System.Text.UTF8Encoding.GetChars(Byte* bytes, Int32 byteCount, Char* chars, Int32 charCount)
   at Microsoft.AspNetCore.Server.HttpSys.HeaderEncoding.GetString(SByte* pBytes, Int32 byteCount)
   at Microsoft.AspNetCore.Server.HttpSys.NativeRequestContext.GetKnownHeader(HttpSysRequestHeader header)
   at Microsoft.AspNetCore.Server.HttpSys.RequestHeaders.get_ContentType()

It looks like the problem is on https://github.com/aspnet/HttpSysServer/blob/2.0.2/src/Microsoft.AspNetCore.Server.HttpSys/RequestProcessing/HeaderEncoding.cs#L21 where this is happening: https://stackoverflow.com/a/17091802/1246739 i.e. pinning an empty array is implementation defined, and in this case we're getting a null pointer.
So one solution is to have a special case for the input being empty there.

If I were to make a pull request with a fix, which branch/tag/revision should I base it on?

This is a duplicate of https://github.com/aspnet/HttpSysServer/issues/381


Ability to modularize the rust code (and remove dependency on mod.rs?)

Is your feature request related to a problem? Please describe.
I have an app where I have a full API in rust and a bunch of widgets I want to use in the flutter app. My directory is such:
rust
├── Cargo.lock
├── Cargo.toml
└── src
├── api
│   ├── mod.rs
│   ├── rectangles
│   │   └── widgets.rs
│   ├── rectangles.rs
│   ├── my_company
│   │   └── api
│   │       ├── sample_doc_pic.png
│   │       └── simple.rs
│   │       └── full.rs
│   ├── my_company.rs
│   └── simple.rs
├── frb_generated.rs
└── lib.rs
Where the my_company module holds two different apis, and rectangles holds a bunch of iced widgets. NOTE: According to the rust docs, mod.rs is deprecated, and one should use the <module>.rs syntax going forward. Here is the makeup of my modules:
file: rust/src/api/mod.rs
pub mod my_comapny;
pub mod rectangles;
mod frb_generated;

file: rust/src/api/my_company.rs
pub mod api;

file: rectangels.rs
pub mod widgets;

file:
use my_company::api::simple;
use rectangles::widgets;

#[derive(Widget)]
pub RectanglesWidget = widgets::RectanglesWidget;

pub api = simple;

Describe the solution you'd like
I would like this to generate two files: lib/src/rust/api/my_company/api/simple.dart and lib/src/rust/api/my_company/rectangles.dart and do all the necessary bindings for bopth of them. Currently, I can only get the first one built.
Describe alternatives you've considered
I have tried all manner of adding the last one to the project, including what your documentation says to do by adding it to a list in the config yaml:
rust_input: crate::api,crate::api::my_company,crate::api::rectangles
rust_root: rust/
dart_output: lib/src/rust

Additional context
I am a bit new to rust, but I have a few projects under my belt. I believe I am following all the documentation but it doesn't seem to work accordingly. I know there may be some things i am missing, but I can't find it anywhere.

Hmm, does rust_input: crate::api work for you?
Note that you need some functions in a file, otherwise that file may be skipped. Thus try to add things like pub fn f(){} to your e.g. rectangles.rs or whatever file that you find it missing.

Close since inactivity, but feel free to reopen if you have any questions!


fix: improve loading performance of individual highlight

Description

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[x] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Adds direct link to OpenGraph image on individual highlight
Removes extra requests from SSR request for individual highlight

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

I had trouble QAing this. created a video
https://github.com/open-sauced/insights/assets/5713670/64455f93-2e64-4847-90f9-7b5751d43b04

https://deploy-preview-1349--oss-insights.netlify.app

Interesting. This happens on current beta also without these changes, so I'll take into that also

@bdougie @jpmcb should be good to go now.

Feed loads without issues
Individual Highlights pop up from clicking on one and fresh page reload
Repo filters are applied when clicked
Follow button in dropdown menu is aligned correctly


Narrow iphone fix

This PR handles narrow iphone screens so the Saved Shows text does not get truncated off the screen on smaller iphone devices.

#skip_new_tests

Warnings

:warning:

Missing Test Files:

src/lib/Components/Lists/__tests__/ShowItemRow-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

merge on green


CreateEvents: Add Location selection

https://github.com/sopra-fs23-group-07/sopra-fs23-group-07-client/commit/220741d963220315613e77bf07f8e96d41e11851

https://github.com/sopra-fs23-group-07/sopra-fs23-group-07-client/commit/220741d963220315613e77bf07f8e96d41e11851


ActiveRecordShards: rename rails_env to app_env, accept APP_ENV

Applications that are not Rails applications can make use of this gem, as long as they depend on activerecord and activesupport.
With that in mind, I renamed ActiveRecordShards.rails_env to ActiveRecordShards.app_env, and included APP_ENV and ENV['APP_ENV'] in the list of places we look for environment information. It'll work nicely with non-Rails applications. Makes sense to keep the check for Rails.env as it'll be fairly common to be defined.
The new tests might be overkill, but figured out it wouldn't hurt much to test the static method.
Risks

Low: maybe some applications might be overwriting ActiveRecordShards.env, seems unlikely but a minor bump should warn developers of the breaking change, otherwise gem behavior shouldn't change.

Could you add a sentence to the Changelog, please?

Could you add a sentence to the Changelog, please?

@bquorning done!

@zendesk/database-gem-owners mind taking another look? thanks!


Cannot use with actual Flutter Version

I am using Flutter Version 0.4.4 but it seems to me that app_review requires Flutter version 0.3.1.
Output of flutter packages get in project folder:
Running "flutter packages get" in project...
The current Flutter SDK version is 0.4.4.
Because project depends on app_review from git which requires Flutter SDK version ^0.3.1, version solving failed.
pub get failed (1)
Output of Flutter Doctor -v:
[✓] Flutter (Channel beta, v0.4.4, on Mac OS X 10.13.3 17D102, locale de-DE)
• Flutter version 0.4.4 at /flutter
• Framework revision f9bb4289e9 (4 weeks ago), 2018-05-11 21:44:54 -0700
• Engine revision 06afdfe54e
• Dart version 2.0.0-dev.54.0.flutter-46ab040e58
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
• Android SDK at /Users/robjan/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-27, build-tools 27.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 9.3.1, Build version 9E501
• ios-deploy 1.9.2
• CocoaPods version 1.5.2
[✓] Android Studio (version 3.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 24.2.1
• Dart plugin version 173.4700
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
[✓] VS Code (version 1.23.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Dart Code extension version 2.13.2
[✓] Connected devices (1 available)
• iPhone 5s • XXX • ios • iOS 11.3 (simulator)
• No issues found!

I patched this on the master branch. I am currently using it on the latest flutter. Is it working for you now?

Closing resolved on the latest master branch.


feat: introduce keycloak

Before start the app

Generate a new .env file with the keycloak variables.
Execute once  ./scripts/setup_keycloak.sh to generate keycloak initial assets.
Check .env file for the initial user and password.
Visit http://localhost:8080 and create more users and realms.

IMPORTANT NOTE
App users authenticate against keycloak and admin users against Django Auth. This means that no keycloak user can access the admin section (forced by the fact that the admin section has no realm restrictions).

Note: you don't need to build common if you don't want to; include the volumes entry in each aether modules in docker-compose.yml file and the module will be accessible with the last changes.
  kernel:
    extends:
      file: ./docker-compose-base.yml
      service: kernel-base
    # ...
    volumes:
      - ./aether-common-library/aether/common:/code/aether/common

keycloak
Go to http://localhost:8080
Read: https://www.keycloak.org/documentation.html if you need help to set it up properly.
first page

dev realm

aether client in the realm

@lordmallam @adamvert  is it ok for you?


add citations file

Add citations.cff according to the https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files

Good example from kornia: https://github.com/kornia/kornia/blob/main/CITATION.md
This appears in the repo's metadata also

Closed with PR - https://github.com/serengil/deepface/pull/999


Excellent

Excellent
Originally posted by @Lilwertkorn1 in https://github.com/louislam/uptime-kuma/issues/122#issuecomment-914183243

Duplicate of #272


old encoded image jxl cannot decode by new version

Describe the bug
I have along time to use this image format. The version I started using for my application is v0.6.x.  So I had a problem, what I cant  resolve. Please help me to fix it.
A received an report that there was an image jxl cannot be decoded, so that I tried to decode by chrome old version (supported jxl), firefox trunk, ... so I put  to the sample decode_oneshot, it failed to decompress this file (what I upload for this report),
I tried all version 0.7.x, 0.8.x, ... 0.10.x .. and the main git version but the image wasnt able to decode.
I tried the version 0.6.x and the image could be decoded. So that please fix for this case. Thanks!

Environment

OS: [e.g. Windows, Android, Linux, iOS]
Compiler version: [e.g. clang 11.0.1]
CPU type: [e.g. x86_64, ARM64, ARM32]
cjxl/djxl version string: [e.g. cjxl [v0.3.7 | SIMD supported: SSE4,Scalar]]

Bisecting suggests that this started happening at https://github.com/libjxl/libjxl/pull/1046. Any thoughts, @jonsneyers?

Thanks for the report, @doanquocnam!

Could you share the jxl file that no longer decodes?

@jonsneyers it is linked above

Could you share the jxl file that no longer decodes?

Didnt you see that link of jxl image what I've uploaded.?

You can download it here: https://b-f67-zpg-r.zdn.vn/jxl/7220520585340013593/c56f50ec47dfe481bdce.jxl

Oh, interesting, on my browser (Thorium) I didn't see a broken image icon and a filename but an empty area the size of that image :)
(so it doesn't decode but it does know the image dimensions, it just doesn't paint any pixels)
Thanks for finding this regression!


statistics

If you fix the naming, remove the classmethod decorator, and fix the merge conflict I think this is ready to go.


dcr: Reimplemint privacy screens.

dcr: Reimplemint privacy screens.

dcr: Use default account on creation.

In order to make mixing opt in, start with it off and do not create the
accounts. Allow sending from the default account on creation.

closes #171

Current screenshots on desktop, yet to try mobile:

Fixing most of the TODOs https://github.com/crypto-power/cryptopower/compare/2bb9f5ff465caac886c9dad280b6777f56b83fb3..a49d0ec318d0122b549cc9d5915815830317ee89

Fixed the spacing around the manual screen back arrow https://github.com/crypto-power/cryptopower/compare/a49d0ec318d0122b549cc9d5915815830317ee89..befab2bf2ef08de596310212857243a6b593b33c

Oh its broken on mobile, should this pr worry with that?

usually mobile work is focused for a different PR
but feel free to include it here if you want, i see the figma screens are ready

but feel free to include it here if you want, i see the figma screens are ready

Actually another pr would be good if that's alright, this one focuses on desktop.

The default sending account is already ok. Made it impossible to toggle off the spend unmixed funds if mixing is not set up. https://github.com/crypto-power/cryptopower/compare/befab2bf2ef08de596310212857243a6b593b33c..28be9d560bcf5ab875620b4aa37524419980e297

the top margin is too much, i can't also see the button

i get this while trying to setup manual mixer, i don't think the user should have funds in order to create a mixer

trying auto setup, i selected auto move funds (i don't have any funds to move, so i assume that should be skipped)

clicking ok, i get stuck on this screen

Fixing all but three of the inline comments so far https://github.com/crypto-power/cryptopower/compare/b2dd44e2eac4e31ab45a48699ffa3845a8fc1ac7..4b6cb728c2272b91dfa10e73598ff8fbfde8406c

i get this while trying to setup manual mixer, i don't think the user should have funds in order to create a mixer

Not funds, accounts. You need three accounts to set up mixing. Automatic will create them but if manual you already need them. I will look into the other error now.

@dreacot hopefully this fixes the no funds bug https://github.com/crypto-power/cryptopower/compare/4b6cb728c2272b91dfa10e73598ff8fbfde8406c..6f807e50846b3423fb9e7b49ce14cc2dae0254a1

@dreacot hopefully this fixes the no funds bug https://github.com/crypto-power/cryptopower/compare/4b6cb728c2272b91dfa10e73598ff8fbfde8406c..6f807e50846b3423fb9e7b49ce14cc2dae0254a1

it does

i'm still having the issue where i can't see the button

What button.

the top margin is too much, i can't also see the button

This the button to start mixer setup

This the button to start mixer setup

Ohh. On desktop? I guess the card needs a set minimum thats higher than it is currently

This the button to start mixer setup

Ohh. On desktop? I guess the card needs a set minimum thats higher than it is currently

I think the top padding is too much as well

@dreacot reduced a lot of the space https://github.com/crypto-power/cryptopower/compare/379d9f3c1fcfbe9ea63e7f49ebd9160689332b31..c63e28790fbd65d581fd10524348bc1fd62c80a5
Setting a max Y in the layout doesn't seem to be respected. These changes make the buttons viewable with as small a screen as I can make. I guess there is a minimum size I cannot makes the window smaller than?

@dreacot reduced a lot of the space https://github.com/crypto-power/cryptopower/compare/379d9f3c1fcfbe9ea63e7f49ebd9160689332b31..c63e28790fbd65d581fd10524348bc1fd62c80a5
Setting a max Y in the layout doesn't seem to be respected. These changes make the buttons viewable with as small a screen as I can make. I guess there is a minimum size I cannot makes the window smaller than?

the app window? yeah its 650px minimum

I just rebased and there's still conflicts lol

I don't think click title row is back button is good idea

Do you suggest just the arrow or arrow and "Manual Setup" label
I did the entire row because it's easier to click on mobile, if these screens can be reused.

I don't think click title row is back button is good idea

Do you suggest just the arrow or arrow and "Manual Setup" label
I did the entire row because it's easier to click on mobile, if these screens can be reused.

i think the arrow and manual setup label should be fine

int() -> gtx.Dp() https://github.com/crypto-power/cryptopower/compare/da8ba79152ffc3cb7759f6cfa576401fd5a5404f..ec869d05893efb1ad871773b95d20f7be18f1cdf


Storing IV after encryption

https://github.com/kokke/tiny-AES-c/blob/12e7744b4919e9d55de75b7ab566326a1c8e7a67/aes.c#L513
Is storing of IV really necessary at the end of AES_CBC_encrypt_buffer? My use case requires the same IV for each encryption, so now I must call AES_ctx_set_iv each time. There are two unnecessary memcpy calls then. Sure I can comment the line out, but maybe you could add an #ifder configuration macro for this?

I think, and I could be wrong, but what you're defining here isn't CBC mode, which this function implements? But instead, you should perhaps, wrap around ECB mode with your own IV manipulation?

Hi @Tardymo :)
I agree with what @jmons says: It sounds like you're doing something other than CBC?
See https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#Cipher_block_chaining_(CBC)
The IV should be updated between each block. That is the reason for the memcpy-call.


Update docs/examples to use multi-arch tagged images

What this PR does / why we need it:
I wanted to test deploying to armv7hf devices, but the examples in the docs used images that were not multi-architecture tagged. The pods failed to start because amd64 Linux containers were pulled and could not run on my Odroid HC1/XU4 device.
If applicable:

[x] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Both deploy now on my ODroid HC-1
 helm list
NAME                    REVISION        UPDATED                         STATUS          CHART           APP VERSION     NAMESPACE
quarreling-saola        1               Mon Dec 24 06:32:54 2018        DEPLOYED        alpine-0.1.0    3.3             default
tufted-gnat             1               Sat Dec 22 23:06:33 2018        DEPLOYED        nginx-0.1.0                     default


Provide Ingress configuration option for reverse proxy (or documentation if already available)

Is your feature request related to a problem? Please describe.
In investigating the security posture and configuration of ArgoCD and the GitOps Operator, there seems to be potential risks due to the access that ArgoCD has to the Openshift cluster.  ArgoCD has a portal, but its core functionality is not in providing a secure portal, but providing cluster configuration.  ArgoCD's documentation provides the capability to setup a reverse proxy, but the GitOps operator only appears to use a route-configuration instead of ingress.
In investigating security we came across this: https://www.trendmicro.com/vinfo/au/security/news/vulnerabilities-and-exploits/abusing-argo-cd-helm-and-artifact-hub-an-analysis-of-supply-chain-attacks-in-cloud-native-applications I found this, which uses the redhat-cop github as a basis for it's exploits and investigation, including making several security recommendations about protecting the portal.
If this is already available, it is not clear to us in the configuration or in documentation as to how to use it - in which case we would request documentation to provide instructions on this setup.
Describe the solution you'd like
ArgoCD has the capability to provide an ingress-based reverse-proxy - https://argo-cd.readthedocs.io/en/stable/operator-manual/ingress/.  In order for this to function with a reverse proxy protecting the ArgoCD portal, we need to be able to configure ingress and potentially a secure-configuration of a reverse proxy instead of the route configuration.
Describe alternatives you've considered
In our case, our clusters are public by necessity due to the service we provide, so the OCP API is public.  We have no other way to protect the ArgoCD cluster given their positioning.
Additional context
You can see more about our services at
https://github.com/redhat-cop/babylon and
https://github.com/redhat-cop/anarchy
@jkupferer is also attached to this request as we are working together to try and secure ArgoCD/GitOps as a way of managing our clusters.

In investigating security we came across this: https://www.trendmicro.com/vinfo/au/security/news/vulnerabilities-and-exploits/abusing-argo-cd-helm-and-artifact-hub-an-analysis-of-supply-chain-attacks-in-cloud-native-applications I found this, which uses the redhat-cop github as a basis for it's exploits and investigation, including making several security recommendations about protecting the portal.

There is an option provided for disabling the console URL in the ArgoCD CR. Would that be helpful for overcoming this security risk ?
https://access.redhat.com/documentation/en-us/openshift_container_platform/4.12/html-single/cicd/index#gitops-customize-argo-cd-consolelink_setting-up-argocd-instance
ArgoCD operator provides the following options for configuring the Server Ingress.
https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#server-ingress-options

Name
Default
Description

Annotations
[Empty]
The map of annotations to use for the Ingress resource.

Enabled
false
Toggle creation of an Ingress resource.

IngressClassName
[Empty]
IngressClass to use for the Ingress resource.

Path
/
Path to use for Ingress resources.

TLS
[Empty]
TLS configuration for the Ingress.

Hi @9strands, the GitOps Operator is based on the upstream Argo CD Operator and provides most (if not all) of its functionality. If you have deployed an Ingress controller to your cluster, you can configure the Operator's CR to create an Ingress object instead of a Route.

Hi, @jannfis, interesting. I'll see if I can tinker that in my development cluster with the operator.


[Web App] Create Frontend form for web_app

Before applying, Read our Contributor Guidelines and README.
Create new frontend for our form based on figma(mobile and desktop)
Please use bootstrap for responsive design
Code is here: https://github.com/CarmineOptions/derisk-research/blob/master/apps/web_app/templates/notification.html
Text me in DM to get access to figma and write also in your message your email

Hi, I'm a Full Stack Developer proficient in Python and its templating framework, Can I take care of this issue?

Hi, let me work on this. I like Cherry


How to set seqs_per_struct >=2 when relax_cycles =1 ?

Hi, very great work! And also great for sharing method !
I have one question that it seems that seqs_per_struct must be 1 if relax_cycles > 0, defined in dl_interface_design.py.
How to implement seqs_per_struct >=2 when relax is allowed ?

-relax_cyle 5

-relax_cyle 5

Many thanks !

Having seqs_per_struct > 1 and relax_cycles > 0 is not currently enabled. This combination can lead to a combinatorial explosion in the number of Rosetta relax trajectories which are performed so I just do not allow it. This check is pretty easy to turn off in the code though if you're keen to take off the training wheels.


Howto: Create a package that does not exist yet in https://search.nixos.org/packages

It would be interesting to see how a package is created from zero:

High-level considerations
Process of creating it
Loading it in nix once done

I am thinking of a very simple software, e.x. sendmidi (https://github.com/gbevin/SendMIDI) which is very simple I guess.
Thank you in advance.

Please take a look at this tutorial and let me know if you have any other questions!


Fixed typo in AD FS deployment script

Fixed issue #15391

@agarwal-akash : Thanks for your contribution! The author, @jeffgilb, has been notified to review your proposed change.

#sign-off


insert 21236 into input field

implemented in commit https://github.com/birkin/easyrequest_project/commit/baa1b6df78621958dbd1ea55fd7d086036b133f9.


RingCentral has unset trust

Currently the autopkg script fails with a TRUST INFO issue. If you override the copy that you have created, and set trust on the local machine you get this error:
Error: creating pkginfo for /Users/user/Library/AutoPkg/Cache/local.munki.RingCentral/downloads/RingCentral.dmg failed: Could not mount /Users/user/Library/AutoPkg/Cache/local.munki.RingCentral/downloads/RingCentral.dmg!
If you could please reverify the trust info against the download package after you modify it, and if you could please double check the URL path - as currently this is failing.
Thanks

Recipes do not have trust info. Only recipe overrides do. Recipe overrides are created by each user of autopkg -- they are not shared by recipe authors.
There may be issues with this recipe, but they aren't related to the lack of trust info, which is expected and normal.
Please review https://github.com/autopkg/autopkg/wiki/AutoPkg-and-recipe-parent-trust-info


PR: Add entry point plugin discovery and add plugin deps solver

Description of Changes

[x] Wrote at least one-line docstrings (for any new functions)

Issue(s) Resolved

Fixes #

[x] Move to setuptools
[x] Add entry points for internal plugins
[x] Add plugin discovery via entry points
[x] Add plugin dependency solver

Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

Hello @goanpeca! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 299:80: E501 line too long (86 > 79 characters)
Line 301:80: E501 line too long (81 > 79 characters)
Line 302:80: E501 line too long (81 > 79 characters)

In the file spyder/app/mainwindow.py:

Line 568:80: E501 line too long (86 > 79 characters)
Line 595:80: E501 line too long (81 > 79 characters)

Hi @ccordoba12 this one is ready for review.


Datagrids lack accessible names

Describe the accessibility issue
A part of our app consists in a screen with several datagrids that have a title above them,
After a11y audit, it is stated that Assistive technologies will not be able to programmatically identify these grids and convey their purpose to users.
I'd like to create a discussion whether this is actually needed, as I'm wondering what the accessibility review for the current implementation of the datagrid is.
WCAG Guideline
Success Criterion 4.1.2 Name, Role, Value
(Level A)
https://www.w3.org/TR/WCAG21/#name-role-value
Steps to reproduce the behavior:

Create a basic datagrid as the one provided in the examples
Observe that there is no possibility to edit or provide any aria-label or aria-labelledby

Expected behavior
Provide a possibility to include an aria-label or aria-labelledby to datagrids
Versions
App
Currently no version supports this. If included, I think it will be best to backport it.
Device:

Type: [MBP]
OS: [iOS]
Browser [FF, Chrome]
Version [TOT]
Screen Reader: [NVDA]

For screen readers, we primarily support the following combinations, and other combinations will be considered on a case by case basis.

NVDA + Firefox (Windows)
VoiceOver + Safari (Apple)

Additional notes
Add any other notes about the problem here.

@chlane I am not sure I understand what is required here, can you please take a look if it is valid and if we already track it internally.

@chlane I am not sure I understand what is required here, can you please take a look if it is valid and if we already track it internally.

I'm guessing that, according to the a11y review we got, we should have the possibility to add aria-label or aria-labelledby to the datagrid.
I come to this conclusion from the following lines in our review:
See the relevant HTML/CSS below.

[User Impact]
Assistive technologies will not be able to programmatically identify these grids and convey their purpose to users.

I'm guessing that, according to the a11y review we got, we should have the possibility to add aria-label or aria-labelledby to the datagrid.
I come to this conclusion from the following lines in our review:
See the relevant HTML/CSS below.

[User Impact]
Assistive technologies will not be able to programmatically identify these grids and convey their purpose to users.

This issue in now tracked internally by our accessibility team

This issue in now tracked internally by our accessibility team

Thanks for the update. Please, do close it if it's tracked elsewhere so that we avoid duplication.

Thanks for the update. Please, do close it if it's tracked elsewhere so that we avoid duplication.

I think someone on the Clarity team needs to close it I don't see the option

I think someone on the Clarity team needs to close it I don't see the option


fix demotion of players when someone changes color

The promote API (https://api.tabletopsimulator.com/player/instance/#promote) does not take an argument, and just toggles whether a player is promoted.
We therefor must check if a player is already promoted before trying to promote them.

Much appreciated, thanks for this!


SVG images

I noticed while working on #14 that base64 SVGs don't work, or even regular SVG urls, in loadImage()

sorry dupe of #6.


Option to disable serving static files?

I'd like an option to disable serving static files altogether. Is there interest in that? In particular to completely negate the possibility of path transversal attacks, but also to achieve the goal of "simplicity" for anyone who doens't need that feature.
I pushed a proof-of-concept implementation to https://github.com/scurest/simple-server/commit/a95deca417f80b240e8cbd1c4bb709f4e28cdadf. It adds a dont_serve_static_files method so the API change is backwards compatible, but there are other ways you could do it of course.

Sure; I'd be happy to accept a PR that does this. It's a bit late, but that commit looks pretty solid, or at least, the overall approach does; send in a PR and I'll review it soon!

Wouldn't it be simpler to change the existing method from
fn set_static_director(Path)

to
fn set_static_director(Option<Path>)

Yes, but like I said I added a separate method that way so it would be backwards compatible since steveklabnik mentioned not wanting to change the main interface for 0.4 here.
If no one minds that, I'm fine with going with set_static_directory(Option<Path>).

Whoops, I see


Metrics for unexpected startup crash / exits

Description
We want to have available metrics for lifecycle manager exits from main, to be able to see if exits are unexpected or not. Furthermore we can use these for alerts and the overview dashboard.
Reasons
No response
Acceptance Criteria

[ ] Increase counter metric lifecycle_mgr_exit when context is cancelled here

Feature Testing
No response
Testing approach
No response
Attachments
No response

We can use kube_pod_container_status_last_terminated_reason instead of create own metrics


determine necessity of test_distance_band_weights

an older test (test_distance_band_weights) may not be reliable / necessary and needs review.

Resolved by #175


Mods to the official apps?

Since we now have access to the apk files of the official apps, I am wondering whether it is possible to modify the apps.   One particular mod I would like to have is to change the way of toggling the menu bar:
Currently, touching the screen anywhere toggles the the menu bar.  I find the behavior distressing.  It would be better if the menu bar is toggled only when the top portion of the screen is touched.
Can this be done by hacking the apk files?

It's illegal, violation of Sony's Copyright.
No binary patch to sony's app is allowed.

Yes, it would be  illegal if you distribute a modified binary.  Just figuring it out and publishing a howto  should be perfectly legal.  Correct me if I were wrong.

Yes, it would be illegal if you distribute a modified binary. Just figuring it out and publishing a howto should be perfectly legal. Correct me if I were wrong.

Yes, you are right.
But if that happens, this repo might be facing a DACA take-down if sony got noticed.

thanks @zhangyl08
and @junrenshi, im not interested in it. technically, it's just Android apk, but without source it will be very difficult to change the app itself. you should contact them to get a better app, not through hacks


Add attributes to user context

Adds generic attributes to user context

Coverage decreased (-0.04%) to 89.585% when pulling 525691bee749d145814cbc53176e58a3a158fac0 on subacc-tech-access into 7b66160f396ac73bc12ddb75a663fc7128301cae on master.


2018 Scotian shelf has spp that are not in the tax list

Review the species and add them to the taxonomy file.

Running the script add-spp-to-taxonomy.R in the R folder of the OceanAdapt repo.

It looks like there are 1325 rows in Scotian shelf summer and fall that are NA for spp in the survey data.  These will generate the warning message mentioned above but they will be trimmed out in the next step.


Added a new section for programming paradigms.

Also included a link to a research paper that does a great job of explaining the various paradigms.

Thanks for contributing!
I would probably add it to the Practices section. Not sure whether Paradigms deserve a separate section.
I am afraid it will grow uncotrollably.
WDYT?

Ya, I could see people starting to link multiple articles to various programming paradigms and maybe even languages. Perhaps it is better in the Practices section.


test：Why are there some black point clouds around the obtained point cloud?

Hope to receive your reply! I have some doubts about the point cloud results obtained from testing:
Why are there some black point clouds around the obtained point cloud?

Hi, these black points can be considered as noise points, which will affect the accuracy metric. These noise points can be filtered out by increasing the thresholds (confidence  and geometric  thresholds) at the fusion stage.
Or you can change  here, in our implementation, the confidence map of the last stage is applied for fusion. Another way is to multiply the confidence maps of all stages together as the final confidence map, like:
photometric_confidence = confidence_list[0]*confidence_list[1]*confidence_list[2]*confidence_list[3]

Of course you need to adjust the confidence threshold accordingly. The latter is a more rigorous filtering method that produces point clouds with fewer noisy points.

Hi, these black points can be considered as noise points, which will affect the accuracy metric. These noise points can be filtered out by increasing the thresholds (confidence  and geometric  thresholds) at the fusion stage.
Or you can change here, in our implementation, the confidence map of the last stage is applied for fusion. Another way is to multiply the confidence maps of all stages together as the final confidence map, like:
photometric_confidence = confidence_list[0]*confidence_list[1]*confidence_list[2]*confidence_list[3]

Of course you need to adjust the confidence threshold accordingly. The latter is a more rigorous filtering method that produces point clouds with fewer noisy points.
Hello, first of all, thank you for your excellent work. I have encountered the same problem. I have a question, is it still possible to achieve the results in the paper after the modifications you made in your previous answer. Looking forward to your answer.

@KAWHIPAUL
The strict filtering method can obtain better Acc., while the loose filtering method can obtain better Comp.. However, the  metric Overall   is the average of Acc. and Comp.. I did not try to carefully adjust the hyperparameters of the strict filtering method, so I do not know whether the Overall  result in the paper can be achieved after modification to strict filtering.

Hope to receive your reply! I have some doubts about the point cloud results obtained from testing: Why are there some black point clouds around the obtained point cloud?

Hello, I want to ask, you asked before that there is noise around your point cloud, you solved this problem, if it is solved, can you please tell me the specific operation, thank you very much

Hope to receive your reply! I have some doubts about the point cloud results obtained from testing: Why are there some black point clouds around the obtained point cloud?

Hello, I want to ask, you asked before that there is noise around your point cloud, you solved this problem, if it is solved, can you please tell me the specific operation, thank you very much
Sorry, I can't get the metrics in the paper and a good visualization at the same time. According to the author's answer, I changed the conf to 0.2, and there will be a lot fewer black dots, but the indicators will be worse. Hope it helps.

After you change the conf index to 0.2, can the visualization effect correspond to the article? After you modify the indicators, the relevant parts in the test_dypcd_dtu.py file have been modified. Photometric _ confidence = confidence _ list [0] * confidence _ list [1] * confidence _ list [2] * confidence _ list [3]. After I revised the index to 0.2, the index is very close to the article. I suggest you try it several times. Are you still doing the follow-up research on this article?
---Original---
From: "Ye @.>
Date: Tue, Jul 2, 2024 11:12 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [TQTQliu/ET-MVSNet] test：Why are there some black point clouds around the obtained point cloud? (Issue #12)
Hope to receive your reply! I have some doubts about the point cloud results obtained from testing: Why are there some black point clouds around the obtained point cloud?
Hello, I want to ask, you asked before that there is noise around your point cloud, you solved this problem, if it is solved, can you please tell me the specific operation, thank you very much
Sorry, I can't get the metrics in the paper and a good visualization at the same time. According to the author's answer, I changed the conf to 0.2, and there will be a lot fewer black dots, but the indicators will be worse. Hope it helps.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

After you change the conf index to 0.2, can the visualization effect correspond to the article? After you modify the indicators, the relevant parts in the test_dypcd_dtu.py file have been modified. Photometric _ confidence = confidence _ list [0] * confidence _ list [1] * confidence _ list [2] * confidence _ list [3]. After I revised the index to 0.2, the index is very close to the article. I suggest you try it several times. Are you still doing the follow-up research on this article?
…
---Original--- From: "Ye @.> Date: Tue, Jul 2, 2024 11:12 AM To: @.>; Cc<EMAIL_ADDRESS>Subject: Re: [TQTQliu/ET-MVSNet] test：Why are there some black point clouds around the obtained point cloud? (Issue #12) Hope to receive your reply! I have some doubts about the point cloud results obtained from testing: Why are there some black point clouds around the obtained point cloud? Hello, I want to ask, you asked before that there is noise around your point cloud, you solved this problem, if it is solved, can you please tell me the specific operation, thank you very much Sorry, I can't get the metrics in the paper and a good visualization at the same time. According to the author's answer, I changed the conf to 0.2, and there will be a lot fewer black dots, but the indicators will be worse. Hope it helps. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Thank you for your answer. I am still continuing to study this issue. Can you provide me with a contact information for easy communication?

After you change the conf index to 0.2, can the visualization effect correspond to the article? After you modify the indicators, the relevant parts in the test_dypcd_dtu.py file have been modified. Photometric _ confidence = confidence _ list [0] * confidence _ list [1] * confidence _ list [2] * confidence _ list [3]. After I revised the index to 0.2, the index is very close to the article. I suggest you try it several times. Are you still doing the follow-up research on this article?
…
---Original--- From: "Ye @.> Date: Tue, Jul 2, 2024 11:12 AM To<EMAIL_ADDRESS>Cc: _<EMAIL_ADDRESS>Subject: Re: [TQTQliu/ET-MVSNet] test：Why are there some black point clouds around the obtained point cloud? (Issue #12) Hope to receive your reply! I have some doubts about the point cloud results obtained from testing: Why are there some black point clouds around the obtained point cloud? Hello, I want to ask, you asked before that there is noise around your point cloud, you solved this problem, if it is solved, can you please tell me the specific operation, thank you very much Sorry, I can't get the metrics in the paper and a good visualization at the same time. According to the author's answer, I changed the conf to 0.2, and there will be a lot fewer black dots, but the indicators will be worse. Hope it helps. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
Thank you for your answer. I am still continuing to study this issue. Can you provide me with a contact information for easy communication?

OKOK，my wechat<PHONE_NUMBER>4


Missing Supercarriers

On Capital Manufacturing tab you are missing:
Aeon
Hel
Nyx
Wyvern

Thanks for the report, I'll be fixing this on the beta branch later today and the changes will be merged into the main branch at the end of the month.


Feature: remove the BIN Keys from Ceremony/Bootstrap Process

An idea from Jussi talk.
As the CLI Ceremony mentions,

Recommended: 2 Keys and Threshold equal 2. Keys discarded after the ceremony.

https://github.com/kaprien/kaprien-cli/blob/bee2254d4b67e8c93cb11db18d9da6f0e8ec9ab4/kaprien/cli/admin/ceremony.py#L99

Remove from the CLI Admin Ceremony step to load targets keys
Implement during Ceremony CLI process to generate the targets and discard

If we decide to remove the BIN keys and instead directly use succinct hash bin delegations in 1.targets.json this means we will no longer need 1.bin.json.

I'm sharing my suggestions for this implementation at a high level for you.
It will require some issues to be implemented in different components.
Worker
No changes required
The current repository.MetadataRepository.bootstrap is straightforward and saves the roles metadata that is in payload sent by the API to the message queue.
This doesn't break the compatibility with the current CLI once this data is still valid content from the current process.
The automatic jobs also don't operate on BIN, as it is an offline key.
CLI
The CLI is about simplifying cli.admin.ceremony, reducing the process.

Remove the BIN configuration
Remove the BIN keys loading

API
The API changes are related to removing BIN from the bootstrap

Isn't more correct to say that we will directly remove the whole BIN role?
Then the removal of the BIN keys from the ceremony/bootstrap process is a consequence.

Isn't more correct to say that we will directly remove the whole BIN role?
Then the removal of the BIN keys from the ceremony/bootstrap process is a consequence.

I'm detailing all changes in a way we can break down into small changes/issues.
So we can file them and understand each change.

All of the issues that need to be closed in order to close this issue are:

https://github.com/vmware/repository-service-tuf-api/issues/224
https://github.com/vmware/repository-service-tuf-worker/issues/165
https://github.com/vmware/repository-service-tuf-cli/issues/174
https://github.com/vmware/repository-service-tuf/issues/212

@MVrachev looks like all tasks are done! 🎉
Well done! Please, have the honor and close this feature issue 🍾

Hahaha, thanks @kairoaraujo.
Closing 🎉


#80: Fix reports for models having multiple process definitions

MethodCoverage: Use definition resource name AND process definition key for determining all process definitions
ProcessCoverage: Filter definitionFlowNodes and definitionSequenceFlows according the process definition key to fix the percentage
CoverageReportUtil: Do not generate method empty method reports

Ad 3: The coverage tool cannot know which process has been tested as part of a specific test method. So the easiest way is to drop all reports having a coverage of 0%. This might lead to missing reports if the coverage is really 0% but doing process tests is not meant to build test methods having 0% coverage ;-). Since the class coverage is always correct (and might break a build if below the requested coverage) I decided that missing test method reports is fine since this should only happen on creating new test methods.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I checked it and the problem is gone with 1.0.0-SNAPSHOT.


Fix include task guard copy issue

There was an issue when using a non-lazy IncludeTask where its guard task will not be cloned/copied whereas it would be if the task was lazy:
(needToResetToSpawn?) include subtree:"data/aiBehavioursTree/spawn_reset.btree" // Here the guard will simply be omitted in the final tree
(needToResetToSpawn?) include subtree:"data/aiBehavioursTree/spawn_reset.btree" lazy:true // Here the guard will be included in the final tree

Looks good, from what I can tell. I fixed the Gradle version conflict because that was my fault; I think I can just merge this now.


Update Composer dependencies (2023-02-09-00-09)

Visual regression test passed!
View the visual regression test report


Transfer doesn't trigger signer window

When I've tried top up payout bot, transfer doesn't work, doesn't trigger signer pop-up
Seems we should use another RPC node?
going on this url

https://beta.kodadot.xyz/transfer/?target=G29NScLSew5zqwmJAPupvJWDCDkpxKUhDnMeVdD2BBcnHar&usdamount=1000

broke on beta and production seems

now it's tryin to connect to localhost 🤔

👋

Seems being stuck indefinitely


Fix nit in noisy_policy

If player_id is 0 then not player_id is True, however we only want not player_id to be True in the case of player_id = None. Therefore, I have changed this to test player_id is None.
I have updated the tests. I guess the test in the test is due to stochasticity of the output of the test (b/141737795).
I wonder if noisy_policy has been ever used, it seems that even this initialization is not correct: https://github.com/deepmind/open_spiel/blob/38941dee3beb52ffdb134b66f420a758634d9a20/open_spiel/python/algorithms/best_response.py#L318

Btw, the name of the noisy policy test does not seem correct.

I do not understand why I got some error for build wheels on macOS-10.15.
Can you help me understand this error?

I did not see any error logs, so I could not tell what the problem was. I restarted the tests. Maybe it was just a fluke?

I am not sure who wrote this code originally nor where it is used. When I find out, i will tag them or contact them.

Thanks Theo, looks good & good find :)


[TACHYON-949] Optimize the behavior of moveBlock when srcLocation equals dstLocation

https://tachyon.atlassian.net/browse/TACHYON-949
Optimize the behavior of moveBlock when the src location equals dst location.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4880/
Test PASSed.

@fanshiqing Thanks for discovering this inefficiency, I actually was doing something similar when I was trying to optimize move. I did a pass over the changes, overall I think the implementation could be simpler.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4902/
Test PASSed.

@fanshiqing Looks good overall, just one minor comment left.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4908/
Test PASSed.

@fanshiqing This looks good to me, could update with the latest master?

Okay, wait a minute, I will update it!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4914/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4915/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4916/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4956/
Test PASSed.

@apc999 @calvinjia Any more feedback? Thanks!

LGTM

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5046/
Test PASSed.


boards: arm: b_l4s5i_iot01a: fix OSPI flash size

The OSPI flash driver expects size in bits. This PR uses bits instead of bytes for the size.
Fixes #52691.

Seems that stm32h7b3i_dk.dts too is  declaring size of the mx25lm51245 nor octoflash in MBytes :
size = <DT_SIZE_M(64)>;  --> size = <DT_SIZE_M(512)>;

Seems that stm32h7b3i_dk.dts too is declaring size of the mx25lm51245 nor octoflash in MBytes : size = <DT_SIZE_M(64)>; --> size = <DT_SIZE_M(512)>;
That could be fixed here in another commit ?

can be done here


regression: fix broken space detection after -D on command line

fix that commandline:
cmake -G "NMake Makefiles" -D CMAKE_C_COMPILER=gcc-4.2
will not use the local CMakeList.txt since the space after -D confuses cmake

If this was a regression, in what version did it last work?  Also, please add a case to Tests/RunCMake/CommandLine/RunCMakeTest.cmake to cover the behavior.

I guess I made a mistake, because by default you need to specifiy the path where to look for the CMakeList.txt. Somehow I missed that. Sorry.


Minor fixes in logs when respawning and restoring actor

Fix wrong type in RESTORE Runtime Actor (was Level)
In log "Respawning actor of type" use DigitsWithHyphens. Easier to find same Guid in log.

Thanks!


{AKS} Update AKS tests to allow enable AAD legacy when creating cluster

The PR updates AKS tests to allow enable AAD legacy when creating cluster.

AKS

some lb related cases failed in CI, could you please help take a look? @MartinForReal

I found several issues and I will raise a pr later in azure-cli and azure-cli-extension.

@FumingZhang shall we merge this PR or hold on until @MartinForReal 's PR is merged?

I think so. Sorry for the delay.

pr has been merged. Could you please rerun the test? @bingosummer

Close as change has been performed by #6719


Allow user creation when logged in

Send Users#new -> Registrations#new (and delete views, etc)
Add Person dropdown to Registrations#new if current_user
Make Devise routes go to override Registrations controller
Change css text-center -> has-text-centered
Change css on error_messages partial

Temporarily closing this PR to reduce clutter for hacktoberfest. Issue #668 will hopefully remind us to pick it back up.


Pushing dotnetcore app with java sidecar

How to specify build-packs in this case? specifying both java and dotnetcore complains as java expects a jar and thus errors. I need dotnetcore buildpack for main app and java buildpack for sidecar. Please let me know how to address this.

@sannidhi @reneighbor @sethboyles @tcdowney @selzoc

Hello @hmble2 would you mind creating an issue for this on https://github.com/cloudfoundry/cloud_controller_ng/issues ?
This is just a repo for sample app and doesn't get much visibility.


Feature 🧑💻✨: Add progress bar in scroll to top button

Describe the feature
Describe the feature
Hey @subhadeeproy3902  ,
I have noticed a small issue that I believe could enhance the user experience. Currently, there is no progress bar in the scroll to top button present on the website, which makes navigation a bit cumbersome, especially when users need to return to the top of a lengthy page.
Though it may seem minor, the absence of this feature can impact the overall usability and performance of the website.
Describe the solution you'd like
@subhadeeproy3902  ,Could you please assign me this issue under gssoc'24 ?
GSSOC'24
Describe alternatives you've considered
Add progress in scroll to top button!
Add ScreenShots

@subhadeeproy3902
/assign
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@TheNikhilRaj No need of intricate detailing


Not possible to use HubFramework in framework project

I am trying to extend an application that uses HubFramework for the UI layer. I have created my own framework project to keep my code separate from the main application. Unfortunately, when I try to add HubFramework to my framework via CocoaPods & build, I get a compiler error.

'sharedApplication' is unavailable: not available on iOS (App Extension) - use view controller based solutions where appropriate instead.

I would like the ability to define components, actions, etc in a separate framework Xcode project and make use of those components in a separate application Xcode project.
It appears that AFNetworking has an interesting way of solving this issue. It would be nice if HubFramework could adapt a similar solution for supporting framework projects.

I was able to work around this issue with the following snippet applied to the bottom of my Podfile. This is likely not an ideal solution for all use cases, but it works for me.
post_install do |installer_representation|
    installer_representation.pods_project.targets.each do |target|
        if target.name == 'HubFramework'
            target.build_configurations.each do |config|
                config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO'
            end
        end
    end
end

The Hub Framework is being phased out at Spotify, and therefore we will not be maintaining it further.


Enhancement/add .vscode to .gitignore

Add .vscode to .gitignore #2291
As szokeasaurusrex Said in the problem statement mentioned below
Problem Statement
The .vscode directory, which is used to store local VSCode configuration options, is being tracked by Git. Since my local settings differ from what is stored in the repo, I always need to make sure not to stage my .vscode directory when commuting changes in Git. Since different developers may have different VSCode configurations, I don’t see any reason why we should be tracking this directory in our repo.
Solution Brainstorm
Add the .vscode directory to .gitignore. If we implement this change, we should probably also delete the .vscode directory from the GitHub repo.
I have successfully deleted the .vscode directory from the project and also added .vscode directory in .gitignore file.

Hello szokeasaurusrex
I am trying to revert the unwanted changes but these changes are just the next line at the end of every file.
These changes are done by running the "pre-commit run --all-files" command.


Delete duplicate stty from README table

There's a duplicate 'stty' in the progress table in the README.

thanks!

thanks!


Downloadable PDF Document

A great resource for Azure architecture here. Is it possible to download the document in pdf like other Azure doc sites?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cade8ea3-b02f-6c92-b7b1-8f37a5c9d701
Version Independent ID: c0bde50c-5e28-5ff2-1507-5a8711ae3022
Content: Azure Application Architecture Guide
Content Source: docs/guide/index.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @MikeWasson
Microsoft Alias: pnp

@PingPongSet Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Yes, definitely would like a PDF version of this to download on iPad or mobile.

You can access directly from here:
https://download.microsoft.com/download/2/D/2/2D29C8A8-A758-4152-A204-2BE86548F995/Cloud_Application_Architecture_Guide_EN_US.pdf

AB#160200 - Thanks for reporting - this issue is under review

Any updates? There used to be a PDF link earlier, which seems to be missing.

@sombanerjee is the link working now?

@Sarkie - I still don't see the link.

Should be fixed shortly.

@doodlemania2 and @Sarkie - Thank you, the download PDF link is now working.


No option to delete attached file

Description
Steps to reproduce

Create an issue
Add text, paste in an image
Image is saved as image.png
Save
Go edit last comment
Remove link to attached image from comment`s content
Paste image again
Save

Now you have two attachments image.png and only one of them can be deleted. After deleting one of them, the other remains and there is no controls to delete it.
Screenshots

Gitea Version
1.19.3
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
win
Browser Version
chrome 113

This is working fine. If you see this error again please feel free to reopen again.


corrected the color scheme and added link + corrected button.

Closes #305
The color scheme has been corrected and the task given by @SahityaRoy has been done.
BEFORE:

AFTER:

Please also add the level otherwise it will not be added to my points.


Can we just adapt e.g. log15 or logrus instead of building and maintaining our own package log?

https://github.com/inconshreveable/log15
https://github.com/Sirupsen/logrus

@ChrisHines @tsenart

That doesn't change much for me. I'm already one of the two maintainers for log15. I see the gokit/log package as an opportunity to address some issues with the current log15 API that we have discussed, but require breaking changes and thus bumping the API version from 2 to 3, which make it difficult to justify doing in an established project. In my mind gokit/log is basically log15.v3.

Thanks for your clarification. I don't have super strong opinions on the change, I'm just noticing that we're spending some nontrivial effort, and wondering if it's justified. But I defer to your domain expertise. I'm also happy to encode the strong opinions I do have about structured logging :)
Thanks for the response!


Websockets bug

Description
In checking live.eddiehub.io (production, not locally) I noticed no data in the panel.
In inspection of the network although the websocket connection is 101 as expected, it appears that no data is being transferred.
May be a configuration issue with websockets. See screenshots from the network tab.
Tested in chrome and firefox (latest) on a mac 12.5.1
Screenshots

Additional information
No response

Tested again after adding this issue out of curiosity and now I do see a "github event" in the websocket traffic, but something is still amiss and no data is displayed.

Oh yes, I forgot about this, you need to opt in to have your event data for the EddieHub Org displayed
I think we need to add that to the README
Issue to opt into the webhook event being displayed
https://github.com/EddieHubCommunity/support/issues/new?assignees=&labels=EddieHub-API-add&template=add-api-user.yml&title=Please+add+me+to+the+EddieHub+API

@eddiejaoude Ah! That makes sense.  I will close this ticket as not a bug

closed, not a bug.


[Question] how to import 1 xls file to 2 tables

Prerequisites

[ ] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[ x] Checked that your issue isn't already filed.
[ x] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 7.1.6
Laravel version: Valet 2.0.12
Package version: 2.1

Description
hello, so i have 2 tables here
tb_user consisting of column id, name, email etc
tb_biodoctor consisting of column id, codeDoc, etc
i've been successfully import:
tb_user column id, name, email
tb_biodoctor column codeDoc
i want to fill tb_user.id to tb_biodoctor.id but i dont know how, here is my code
public function doctorImport(Request $req)
    {
        $this->validate($req, ['import_file' => 'required|mimes:xls,xlsx,csv']);

        if(Input::hasFile('import_file')){
            $path = Input::file('import_file')->getRealPath();
            $data = Excel::load($path, function($reader) {

            })->get();
            if(!empty($data) && $data->count()){
                foreach ($data as $key => $value) {
                    $insert[] = [

                    'name' => $value->nama,
                    'email' =>  $value->email,
                    'password' => bcrypt($value->password),
                    'level' => $value->level,
                    ];
                $inserts[] = [
                    'nik' => $value->nik,
                    'codeDoc' => $value->codedoc,
                    'bidang' => $value->bidang,
                    'pangkat' => $value->pangkat,
                    ];

                }

                if(!empty($insert)){
                     DB::table('tb_user')->insert($insert);
                    DB::table('tb_biodoctor')->insert($insert);

                return redirect('/admin/doctor')->with('info','Record Uploaded Successfully');
                }
            }
        }
        return back();
    }

I think this question is better asked at a forum (Laracasts) or at Stackoverflow. The issue tracker is meant for reporting bugs. This is application implementation.


Python: add cli args to enable execution tracing

done in Go. I might want the same interface

Python frontend has been removed.


Link city3 in the footer

We need to link to city3.community in the footer where it says city3.

Fixed by @siddharthachatterjee!


Update docker-compose with examples for bazarr and readarr

Description of the change

Additions added to docker-compose for bazarr and readarr. These additions enable the docker-compose to fully populate the example Grafana dashboard. Entries follow consecutively with port allocations (9712 and 9713) and use default URLS for each (http://bazarr:6767 and http://readarr:8787).
Also updated the docker-compose with latest ghcr.io/onedr0p/exportarr major version (v2.0).

Benefits

Explicit examples for bazarr and readarr exporters.
Easier onboarding of new users.

Possible drawbacks
NA
Applicable issues
NA
Additional information
NA

Thanks!


Allow execution of shell commands [Edit: without the need for a ! prefix]

In my use of the aws-cli/SAWS I find I'm frequently interacting with basic shell commands.  aws-shell does not allow me to do this, which seems to force me to pop in/out of aws-shell.
This is supported on SAWS:

See: https://github.com/donnemartin/saws/issues/8

This seems to be related: https://github.com/awslabs/aws-shell/issues/72


WIP Initial implementation of NDOC support for DCL

@bot-gradle test RFN, APT

I've triggered the following builds for you. Click here to see all build failures.

Ready for Nightly (Trigger) (Check)
All Performance Tests (Trigger)

@bot-gradle test APT

I've triggered the following builds for you. Click here to see all build failures.

All Performance Tests (Trigger)

@bot-gradle test APT

I've triggered the following builds for you. Click here to see all build failures.

All Performance Tests (Trigger)

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

Ready for Nightly (Trigger) (Check)

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

Ready for Nightly (Trigger) (Check)


create3 not scanning for network

Please provide the following information:

OS: Ubuntu 22
ROS Distro: Humble
Built from source or installed: deb package
Package version: Current Firmware Version: H.2.2 (Humble)

Expected behaviour
List of SSIDs to select network on the create3 web interface.
Actual behaviour
Dropdown remains empty.  Digging in logs, the message "network is down" keeps coming back.
What I've done so far:

restarted the application
restarted the robot
cold restarted the robot
restored to factory settings
re-flashed the turtlebot4 sd-card to the humble image
Upgraded through apt upgrade
re-uploaded the humble 2.2 firmware for icreate

every time followed by looking in the dropdown and re-scanning for networks.
In the logs, I keep seeing a message Interface doesn't support scanning : Network is down for wlan0.
Similarly, manually setting the SSID and password don't work.
Logs
Aside from the issue at hand,  It would be nice to better understand the relation between the create3 and the rest of the bot.  They seem to be 2 independent systems, yet not entirely.  I'm having a hard time identifying the relation.

Looking through the logs I do see a lot of "missing file" errors and network errors overall.  Not sure if that should be the case?
Sep  3 12:21:42 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file product.regdom
Sep  3 12:21:44 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/main.c:347 errno:No such file or directory) failed to set regdomain
Sep  3 12:21:44 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/main.c:353 errno:No such file or directory) Could not find product.regdom key
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file network.ssid
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_misc.c:754 errno:No such file or directory) Failed to stat file /opt/irobot/persistent/opt/irobot/data/bbk/user_wpa_supplicant.conf
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_misc.c:801 errno:No such file or directory) Failed to open file: /opt/irobot/persistent/opt/irobot/data/bbk/user_wpa_supplicant.conf
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file robot.disc_reconnect_sleep_sec
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/kvs_json.c:21 errno:No such file or directory) Failed to retrieve key "robot.disc_reconnect_sleep_sec"
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file network.watchdog_interval_min
Sep  3 12:21:51 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/kvs_json.c:21 errno:No such file or directory) Failed to retrieve key "network.watchdog_interval_min"
Sep  3 12:21:52 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_misc.c:86 errno:No such file or directory)  MODULE : network_manager CMD (sudo network_dhcp_arp_control.sh disable) failed with status = 1, ret = 256
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/mqtt_client.c:695 errno:Resource temporarily unavailable) firr_transfer failed
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/main.c:184 errno:Resource temporarily unavailable) Error publishing sta:0 FIRR request.
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file network.addr_type
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/kvs_json.c:21 errno:No such file or directory) Failed to retrieve key "network.addr_type"
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/aos_kvs_helper.c:51 errno:No such file or directory) Failed to stat file network.ssid
Sep  3 12:21:57 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/network_utils.c:262 errno:No such file or directory) cannot load ssid
Sep  3 12:22:21 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/mqtt_client.c:695) firr_transfer failed
Sep  3 12:22:21 iRobot-6F2890FA31C0486E80A20C80E321CE4D daemon.err network[1462]: [ERROR] (src/discovery.c:407) falied to get cap from tsprime

If the Network is down, it can be brought up by doing the following series of steps (Ignore the step numbers, do them in the order that I am showing here):

These are a subset of the create3 setup guide found here: https://edu.irobot.com/create3-setup. You can go through all of the steps listed there but you should have already done the update step and the mutli-robot namespacing should be done through the turtlebot4-setup tool not through the create3 interface.
Additionally, please note that for discovery server, the create3 should not be connected to the internet. It is only for simple discovery where the create3 should be directly connected to the internet.

Thank you @hilary-luo
The updates have been done already indeed.  Without the wifi working I ended up switching to discovery network.  But that seems to be bringing down my wifi as soon as I do something in Rviz.

Hmmm, you can give it a try but simple discovery does result in more network traffic so if you are seeing an issue with the network not being able to handle the traffic then this is unlikely to fix it. Good luck and feel free to let me know if you are looking for more assistance.

It would seem I'm not out of the woods yet.
So I've moved things over to simple discovery and both the bot and pi are connected to the same wifi.
However, when launching diagnostics no data is coming though.  Running Rviz is showing OK for the camera but no image is showing.   Yet, using the teleop keyboard on my pc I can make the bot move.
If I compare the topic list from the PI to the pc, there seems to be a significant difference.  Does that mean that icreate and the bot aren't really communicating well? What would be the right steps to try and resolve this?
--- /Users/sascha/Downloads/bot/ubuntu_pc.txt	Tue Sep  5 14:17:51 2023
+++ /Users/sascha/Downloads/bot/ubuntu_pc.txt	Tue Sep  5 14:18:32 2023
@@ -1,34 +1,35 @@
 /battery_state
+/clicked_point
+/cliff_intensity
+/cmd_audio
+/cmd_lightring
 /cmd_vel
-/color/preview/image
-/diagnostics
-/diagnostics_agg
-/diagnostics_toplevel_state
 /dock_status
-/function_calls
+/goal_pose
 /hazard_detection
-/hmi/buttons
-/hmi/display
-/hmi/display/message
-/hmi/led
 /imu
+/initialpose
 /interface_buttons
-/ip
-/joint_states
-/joy
-/joy/set_feedback
+/ir_intensity
+/ir_opcode
+/kidnap_status
+/mobility_monitor/transition_event
 /mouse
 /oakd/rgb/preview/camera_info
 /oakd/rgb/preview/image_raw
-/oakd/rgb/preview/image_raw/compressed
-/oakd/rgb/preview/image_raw/compressedDepth
-/oakd/rgb/preview/image_raw/theora
+/odom
 /parameter_events
 /robot_description
+/robot_state/transition_event
 /rosout
 /scan
-/stereo/depth
+/slip_status
+/static_transform/transition_event
+/stop_status
 /tf
 /tf_static
 /wheel_status
+/wheel_ticks
+/wheel_vels
+

It's also worth noting that the display on the bot isn't giving battery info, and there are only 3 of the 5 led lights on. (left, middle and right)

So for now I've given up on simple discover - instead I'm trying with the discovery server again. However the moment I run ros2 launch turtlebot4_viz view_model.launch.py with lidar and camera the wifi is saturated.
Do you have any thoughts on ways to reduce the network traffic?  Or maybe some thoughts on wifi routers that have more bandwidth?

I agree that it seems as though the devices were not all set up properly in simple discovery. But as you say, we can continue with discovery server.
In regards to the network, have you connected the raspberry pi to a 5GHz network? That would be the first place to start, in order for your system to be able to support full functionality. What are the symptoms that make you say that the wifi is saturated? I am running my turtlebots off of a dlink router I got from a thrift shop, I just made sure that it supported 5 GHz.
In the meantime, there are some things you can do to limit the network traffic but it involves reducing which features that you use. When you say that when you launch rviz with lidar and camera, the wifi is saturated, are you trying to actually display the camera feed in rviz or just launching rviz to begin with? You should be able to launch rviz without subscribing to / displaying the camera feed. That should really cut down on the network traffic. Also, if you have diagnostics on, try turning it off (can be turned off through the turtlebot-setup tool). That should also reduce the network traffic.

I agree that it seems as though the devices were not all set up properly in simple discovery. But as you say, we can continue with discovery server.

Fair enough. I'll probably like to circle back to this once the networking issue is resolved. As you say simple discovery will increase the network traffic even more.  So that sounds like #1 to deal with.

In regards to the network, have you connected the raspberry pi to a 5GHz network? That would be the first place to start, in order for your system to be able to support full functionality. What are the symptoms that make you say that the wifi is saturated? I am running my turtlebots off of a dlink router I got from a thrift shop, I just made sure that it supported 5 GHz.

So the wifi is pre-dual band.  I read in the docs that dual-band would work better, never realising that this dual band is really a requirement more than an optional "improvement".
The AP I ordered last night is a Zyxell NWA210X. Probably overkill judging from your response - but this current pre-dual band router I'm using isn't cutting it.

In the meantime, there are some things you can do to limit the network traffic but it involves reducing which features that you use. When you say that when you launch rviz with lidar and camera, the wifi is saturated, are you trying to actually display the camera feed in rviz or just launching rviz to begin with? You should be able to launch rviz without subscribing to / displaying the camera feed. That should really cut down on the network traffic. Also, if you have diagnostics on, try turning it off (can be turned off through the turtlebot-setup tool). That should also reduce the network traffic.

Hmm, can't seem to find that option in the turtle-bot setup.  I did see some options like this when running ros2 service list but I'm not sure where to find the docs to identify the service-type and request with these calls.  Can you point me in the right direction?

Investing in a good quality AP sets you up well for future work.
I assume that you are referring to finding the option to turn off diagnostics. It is actually a setting on the robot that you will change, not accessed through ROS2 services. SSH into the robot and run turtlebot4-setup -> go under ROS Setup -> Bash Setup -> Select TURTLEBOT4_DIAGNOSTICS -> Disabled -> Save -> Back out to the main menu -> Apply Settings -> Yes

Success!  So for sure, buy yourself a modern Wifi Access point.  Lol
I made a pull-request on the docs to stipulate that you really want to have 5G wifi.  None of this old stuff - it just doesn't have the bandwidth.
I'll try getting the simple discovery running as well.

If the Network is down, it can be brought up by doing the following series of steps (Ignore the step numbers, do them in the order that I am showing here):
These are a subset of the create3 setup guide found here: https://edu.irobot.com/create3-setup. You can go through all of the steps listed there but you should have already done the update step and the mutli-robot namespacing should be done through the turtlebot4-setup tool not through the create3 interface.
Additionally, please note that for discovery server, the create3 should not be connected to the internet. It is only for simple discovery where the create3 should be directly connected to the internet.

I do not understand the step 3. Where is the listing supposed to be exactly? I work with Ubuntu 22.04 VM.

If the Network is down, it can be brought up by doing the following series of steps (Ignore the step numbers, do them in the order that I am showing here):
These are a subset of the create3 setup guide found here: https://edu.irobot.com/create3-setup. You can go through all of the steps listed there but you should have already done the update step and the mutli-robot namespacing should be done through the turtlebot4-setup tool not through the create3 interface.
Additionally, please note that for discovery server, the create3 should not be connected to the internet. It is only for simple discovery where the create3 should be directly connected to the internet.

Here's the downloaded log file for your reference:
messages(1).txt
Do you recommend any resource(books, video tutorials, blog articles etc..) to make sense of the messages in the log file? That would be much appreciated. Thank you.

@ramakrishnasakethi Please discuss your issue on your open ticket. If you wish to ask other people questions you can tag them on your ticket but for my own sanity I will be responding to you with troubleshooting steps etc. on your ticket only (or tickets when you have multiple independent issues open).
I have responded there about the fact that you have not successfully enabled the hotspot / wifi on your create3 robot.
@sdobbelaere Would you agree that this issue is now resolved for you and the ticket can be closed? Thank you for entering the PR, I (or a colleague) will review and get back to you.

Indeed, ticket resolved. Thank you for your help @hilary-luo


Neil_Validator

[validator.Neil_Validator]
consensus_public_key = "00bcd9893c5d7cbb1d48e86ed5875fb63b56d66364dfe848df1f7107f272f8fa98"
account_public_key = "00882a9e3822c9b90367c0ff8961bc20fd8b1989a8c2e5ffc87a95aeb954858608"
protocol_public_key = "00fc5f7b9ef98cb65c47e14a90930f28f2ee4349ceb61c49c53b1c0b0b1989b0f5"
dkg_public_key = "600000004a6bfd2fbbc45b54786d4311e01348f14cd3299993dfcb0c003db341856d71d226d45b1b302bb2b4eeda68e2e746950940c0fddbe69ea97beb111232e6aff133b693612a83f52b2d3f34607df22875648a18a748dc54b0a24f91e2b89c505c94"
commission_rate = "0.05"
max_commission_rate_change = "0.01"
net_address = "<IP_ADDRESS>:26656"
tendermint_node_key = "0032f69487b732f0f5e07dc0d4b82de6bc12ae7e4b13bc3860172e8b5ff22a784e"

Hi, I'm Neil, Crypto enthusiast since 2019. I have done fullnodes and validators on Aptos testnet, I have also done fullnodes on Celestia as well as on Alephium where I participate a lot in the community. I like to take part in crypto projects to integrate the community and help people as I can.
Twitter : @weineil_
Discord : Neil#7985
You can find my genesis information above


Can this plugin be used to make feature extraction on mobile ?

I don't want classification or object detection … what i am looking for is feature extraction with my custom model.
Is this possible here ?

Do you have any android example I can follow?

https://github.com/pytorch/android-demo-app from this repo

@zezo357 I don't understand

@zezo357 I don't understand

What is feature extraction, and does an example for it exist in the link above?
If yes most probably I can implement it

@zezo357
Feature Extraction extracts information from input image and outputs feature vector.
There is no example for it in the link you provided but it's fairly easy to implement.
I was using this plugin for feature extraction but it was not updated to pytorch 2.0.0 and the maintainer is not responding so i am unable to use it now. Is it possible to support a similar feature in your plugin ?

So you want to input and image and get the raw output ?

Your plugin works with the latest version of PyTorch, Correct ?

Yes it should, I updated to the last pytorch lite available when I was working on it.
And if not I will try to update it

You are a real hero. Thanks for the effort

can you try loading the model as a classification model then running  getImagePredictionList on it?
it should get you the raw output from the model, i cant test it since i dont have your model

Thanks, I was able to fix my problem in the plugin i was already using (updated the pytorch version using your plugin).
@zezo357


Updating "Why can't I set maxPods below 30?"

@MikkelHegn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @MikkelHegn - Program Managers should work in the private repository. I see that you have submitted PRs in the private repo (azure-docs-pr) before. Could you please submit these updates in a PR that targets the private repo? We'll close the PR. Thanks very much.


add support to open the browser after ViteDevServer started without open configured

Description
We're adding none provider to Vitest browser to allow run tests in the browser without playwright/webdriverio.
Right now, the draft PR (https://github.com/vitest-dev/vitest/pull/3674) will configure open = true before creating ViteDevServer: https://github.com/vitest-dev/vitest/pull/3674/files#diff-0820b575c16b5a3f5f4fab98f25d1a896a476dc1fe768b4ef79f49b2eaa9f19fR51-R52.
We want to delay opening the browser, and open it in the appropiate time: https://github.com/vitest-dev/vitest/pull/3674/files#diff-ead1606bb6c60ea8c5c6dea3c305fffa9ec9813b3c70f785aafd4349c71b5f2eR34-R36
Suggested solution
Just allow open url at any time
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

We exposed server.openBrowser() here: https://github.com/vitejs/vite/pull/11974. If open is false, and then you call this function I think it should work as you expect.
You mentioned in a DM that you wanted to control the loaded URL, no? So the default won't be enough if I understand correctly and you would need openBrowser to take an optional param to open a different URL. Is that correct?

yes


🔀 Switch base image to NVIDIA's Ubuntu 22.04 CUDA base

This pull request:
Is part of https://github.com/ministryofjustice/analytical-platform/issues/4120

Switches to nvidia/cuda:12.4.1-base-ubuntu22.04

source https://gitlab.com/nvidia/container-images/cuda/-/blob/master/dist/12.4.1/ubuntu2204/base/Dockerfile

Signed-off-by: Jacob Woffenden<EMAIL_ADDRESS>

This branch was used to produce https://github.com/ministryofjustice/analytical-platform-visual-studio-code/releases/tag/1.2.0-nvidia-cuda-base


Add new single-kernel implementation of sparse to ragged index conversion

Adds a new op, SparseIndicesToRaggedRowSplits, and modifies RaggedTensor.from_sparse to use this op in place of the previous implementation. On a single A100-40GB GPU, my tests showed a speedup of 5x up to 150x depending on the input SparseTensor.  The op is also implemented for CPU.
This op accepts SparseTensor indices as input and returns a tensor of row_splits which can be used to create a RaggedTensor. If argument validate_ragged_right is set to true, the op will additionally check that the input indices represent a ragged-right SparseTensor.
Because this change modifies RaggedTensor.from_sparse to create the new RaggedTensor with the from_row_splits constructor instead of from_value_rowids as before, PR #59508 or another such change will be necessary to avoid regression for existing code that repeatedly calls row_lengths() or value_rowids() on a RaggedTensor created with from_sparse.

Hi @vysarge Can you please resolve conflicts? Thank you!

Conflicts have been resolved.

Hi @JXRiver Can you please review this PR ? Thank you!

Hi @JXRiver Can you please review this PR ? Thank you!

Closed the prerequisite of this PR github.com/tensorflow/tensorflow/pull/59508. Going to close this one as well.


Fix lazy initialisation bug for parametizability

Lazy initialisation doesn't work on wasm for some (unknown yet) reason. This fix it by computing stuff at compile time.

I did some tests and it indeed seems to fix the issue.


opus-recorder plugin: fixes for opus-recorder 8.x

Coverage remained the same at 74.637% when pulling be9e763589ced35a4d73d10c98999fa60bd98e65 on opus-recorder-8-fix into 2004aac2f3e1c6916748e954b427e4310f1a2aa6 on master.


turbodbc installation failed due to missing boost/locale.hpp file on AIX7.2

I have compiled boost1.73 and generate its header files.  As you can see below, locale.hpp is available in /software/thirdparty/boost_1_73_0/boost.
Login=xzhang: Line=130 > pwd
/software/thirdparty/boost_1_73_0/boost
Login=xzhang: Line=131 > ls -l locale.hpp
-rw-r--r--    1 xzhang   xzhang          887 Apr 22 2020  locale.hpp

I also defined BOOST_ROOT=/software/thirdparty/boost_1_73_0.

How to make sure turbodbc installation will search for boost hpp files?  Thanks.

Can you post the full build log and the value of the environment variables CFLAGS, CXXFLAGS and LDFLAGS?

I didn't define CFLAGS, CXXFLAGS and LDFLAGS.  I expected they are defined in your makefile or something similar.  Attached is the complete log file.
Thanks.
turbodbc-4.1.1.tar.gz.log

@xhochy:
Do you have any update on my issue?
Thanks.

@xhochy:
Do you have any update on my issue?
Thanks.

I checked your setup.py.  Basically, you defined 3 platforms: darwin, win32, and others, which means AIX is in others group.    So I defined UNIXODBC_INCLUDE_DIR and UNIXODBC_LIBRARY_DIR accordingly.  Now I have totally different errors.  The 1st error is below and the other errors are similar.
    gcc -maix64 -fPIC -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -I/usr/include -I/opt/freeware/include -I/opt/freeware/include/ncurses -DAIX_GENUINE_CPLUSCPLUS -D_LINUX_SOURCE_COMPAT -Wl,-brtl -O2 -fPIC -I/usr/include -I/opt/freeware/include -I/opt/freeware/include/ncurses -DAIX_GENUINE_CPLUSCPLUS -D_LINUX_SOURCE_COMPAT -Wl,-brtl -O2 -fPIC -Iinclude/ -I/opt/freeware/lib/python3.7/site-packages/pybind11/include -I/usr/local/include/ -I/opt/freeware/include/python3.7m -c src/turbodbc/buffer_size.cpp -o build/temp.aix-7.2-3.7/src/turbodbc/buffer_size.o --std=c++11
    In file included from /usr/local/include/boost/variant/apply_visitor.hpp:16,
                     from /usr/local/include/boost/variant/detail/hash_variant.hpp:22,
                     from /usr/local/include/boost/variant/variant.hpp:34,
                     from include/turbodbc/field.h:3,
                     from include/turbodbc/description.h:3,
                     from include/turbodbc/buffer_size.h:3,
                     from src/turbodbc/buffer_size.cpp:1:
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                     ^~~~
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected ')' before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                    ~^~~~
                     )
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                     ^~~~
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:8: error: expected unqualified-id before 'decltype'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
            ^~~~~~~~

Attached are log file and hpp file in question.  I have to add ".txt" suffix to fool around github system.  Would you mind to take a look?
Thanks.
turbodbc-4.1.1.tar.log
apply_visitor_binary.hpp.txt

I checked your setup.py.  Basically, you defined 3 platforms: darwin, win32, and others, which means AIX is in others group.    So I defined UNIXODBC_INCLUDE_DIR and UNIXODBC_LIBRARY_DIR accordingly.  Now I have totally different errors.  The 1st error is below and the other errors are similar.
    gcc -maix64 -fPIC -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -I/usr/include -I/opt/freeware/include -I/opt/freeware/include/ncurses -DAIX_GENUINE_CPLUSCPLUS -D_LINUX_SOURCE_COMPAT -Wl,-brtl -O2 -fPIC -I/usr/include -I/opt/freeware/include -I/opt/freeware/include/ncurses -DAIX_GENUINE_CPLUSCPLUS -D_LINUX_SOURCE_COMPAT -Wl,-brtl -O2 -fPIC -Iinclude/ -I/opt/freeware/lib/python3.7/site-packages/pybind11/include -I/usr/local/include/ -I/opt/freeware/include/python3.7m -c src/turbodbc/buffer_size.cpp -o build/temp.aix-7.2-3.7/src/turbodbc/buffer_size.o --std=c++11
    In file included from /usr/local/include/boost/variant/apply_visitor.hpp:16,
                     from /usr/local/include/boost/variant/detail/hash_variant.hpp:22,
                     from /usr/local/include/boost/variant/variant.hpp:34,
                     from include/turbodbc/field.h:3,
                     from include/turbodbc/description.h:3,
                     from include/turbodbc/buffer_size.h:3,
                     from src/turbodbc/buffer_size.cpp:1:
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                     ^~~~
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected ')' before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                    ~^~~~
                     )
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
                     ^~~~
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:17: error: expected primary-expression before 'auto'
    /usr/local/include/boost/variant/detail/apply_visitor_unary.hpp:131:8: error: expected unqualified-id before 'decltype'
     inline decltype(auto) apply_visitor(Visitor&& visitor, Visitable&& visitable,
            ^~~~~~~~

Attached are log file and hpp file in question.  I have to add ".txt" suffix to fool around github system.  Would you mind to take a look?
Thanks.
turbodbc-4.1.1.tar.log
apply_visitor_binary.hpp.txt

I am confused with the following logic in your setup.py file.  Apparently, turbodbc installation requires boost.  However, BOOST_ROOT is only defined in "win32" platform.   Does BOOST_ROOT is required or not on AIX? my unixODBC is installed in /usr/local/unixODBC while /usr/local/lib and /usr/local/include are boost lib/include libraries.  How do I define UNIXODBC_INCLUDE_DIR and UNIXODBC_LIBRARY_DIR on AIX?  I tried them with /usr/local/include and /usr/local/bin, but the installation failed as mentioned in my last post.  Other tries were failed with missing files.
Any help is really appreciated.
if sys.platform == 'darwin':
    extra_compile_args.append('--std=c++11')
    extra_compile_args.append('--stdlib=libc++')
    extra_compile_args.append('-mmacosx-version-min=10.9')
    hidden_visibility_args.append('-fvisibility=hidden')
    include_dirs.append(os.getenv('UNIXODBC_INCLUDE_DIR', '/usr/local/include/'))
    library_dirs.append(os.getenv('UNIXODBC_LIBRARY_DIR', '/usr/local/lib/'))
    from distutils import sysconfig
    vars = sysconfig.get_config_vars()
    vars['LDSHARED'] = vars['LDSHARED'].replace('-bundle', '')
    python_module_link_args.append('-bundle')
    builder = setuptools.command.build_ext.build_ext(Distribution())
    full_name = builder.get_ext_filename('libturbodbc')
    base_library_link_args.append('-Wl,-dylib_install_name,@loader_path/{}'.format(full_name))
    base_library_link_args.append('-dynamiclib')
    odbclib = 'odbc'
elif sys.platform == 'win32':
    extra_compile_args.append('-DNOMINMAX')
    if 'BOOST_ROOT' in os.environ:
        include_dirs.append(os.getenv('BOOST_ROOT'))
        library_dirs.append(os.path.join(os.getenv('BOOST_ROOT'), "stage", "lib"))
        library_dirs.append(os.path.join(os.getenv('BOOST_ROOT'), "lib64-msvc-14.0"))
    else:
        print("warning: BOOST_ROOT enviroment variable not set")
    odbclib = 'odbc32'
else:
    extra_compile_args.append('--std=c++11')
    hidden_visibility_args.append('-fvisibility=hidden')
    python_module_link_args.append("-Wl,-rpath,$ORIGIN")
    if 'UNIXODBC_INCLUDE_DIR' in os.environ:
        include_dirs.append(os.getenv('UNIXODBC_INCLUDE_DIR'))
    if 'UNIXODBC_LIBRARY_DIR' in os.environ:
        library_dirs.append(os.getenv('UNIXODBC_LIBRARY_DIR'))
    odbclib = 'odbc'

I am confused with the following logic in your setup.py file.  Apparently, turbodbc installation requires boost.  However, BOOST_ROOT is only defined in "win32" platform.   Does BOOST_ROOT is required or not on AIX? my unixODBC is installed in /usr/local/unixODBC while /usr/local/lib and /usr/local/include are boost lib/include libraries.  How do I define UNIXODBC_INCLUDE_DIR and UNIXODBC_LIBRARY_DIR on AIX?  I tried them with /usr/local/include and /usr/local/bin, but the installation failed as mentioned in my last post.  Other tries were failed with missing files.
Any help is really appreciated.
if sys.platform == 'darwin':
    extra_compile_args.append('--std=c++11')
    extra_compile_args.append('--stdlib=libc++')
    extra_compile_args.append('-mmacosx-version-min=10.9')
    hidden_visibility_args.append('-fvisibility=hidden')
    include_dirs.append(os.getenv('UNIXODBC_INCLUDE_DIR', '/usr/local/include/'))
    library_dirs.append(os.getenv('UNIXODBC_LIBRARY_DIR', '/usr/local/lib/'))
    from distutils import sysconfig
    vars = sysconfig.get_config_vars()
    vars['LDSHARED'] = vars['LDSHARED'].replace('-bundle', '')
    python_module_link_args.append('-bundle')
    builder = setuptools.command.build_ext.build_ext(Distribution())
    full_name = builder.get_ext_filename('libturbodbc')
    base_library_link_args.append('-Wl,-dylib_install_name,@loader_path/{}'.format(full_name))
    base_library_link_args.append('-dynamiclib')
    odbclib = 'odbc'
elif sys.platform == 'win32':
    extra_compile_args.append('-DNOMINMAX')
    if 'BOOST_ROOT' in os.environ:
        include_dirs.append(os.getenv('BOOST_ROOT'))
        library_dirs.append(os.path.join(os.getenv('BOOST_ROOT'), "stage", "lib"))
        library_dirs.append(os.path.join(os.getenv('BOOST_ROOT'), "lib64-msvc-14.0"))
    else:
        print("warning: BOOST_ROOT enviroment variable not set")
    odbclib = 'odbc32'
else:
    extra_compile_args.append('--std=c++11')
    hidden_visibility_args.append('-fvisibility=hidden')
    python_module_link_args.append("-Wl,-rpath,$ORIGIN")
    if 'UNIXODBC_INCLUDE_DIR' in os.environ:
        include_dirs.append(os.getenv('UNIXODBC_INCLUDE_DIR'))
    if 'UNIXODBC_LIBRARY_DIR' in os.environ:
        library_dirs.append(os.getenv('UNIXODBC_LIBRARY_DIR'))
    odbclib = 'odbc'

I can look into the logs next week but you will probably be mostly on your own on this. AIX is not officially supported and will probably never be as well. I also don't have access to an AIX setup as this is really uncommon.

I can look into the logs next week but you will probably be mostly on your own on this. AIX is not officially supported and will probably never be as well. I also don't have access to an AIX setup as this is really uncommon.