CodeCop Rule AA0218 and AA0225 - Should not warn when ShowCaption = false

AL Extension Version: 5.0.254558

Server Version: not important

This is code that is very similar to the field on page 5200 Empleyee Card, where a label is used for the field to create a clickable "link".
ShowCaption = false, because the caption should not be shown.
The rules AA0218 and AA0225 should not be applicable when you use the property ShowCaption = false, as the Caption and the Tooltip are not shown in the page.
To follow the warning would only result in unused Caption and Tooltip text, that needs translations which would be unnecessary.

See #5670 "AA0225 warns about missing caption when ShowCaption = false"

@MarcHansenMicrosoft can you take a look?

This issue has been fixed for AL extension with a version higher than 5.0.272418

Thanks


Fix for Issue#17 - Supporting custom schemas in incremental models

@rahulj51 thank you for submitting the PR.
Could you please reword your commit to
Support custom schemas in incremental models

Resolves: #17

Can you also add a test for your PR?

Fixed the commit message. The tests may take a while for me to write as I am not familiar with the dbt_adpater_tests plugin. I'll give it a shot.

We have an incremental model already here: https://github.com/starburstdata/dbt-trino/blob/master/docker/dbt/jaffle_shop/models/marts/core/dim_order_dates.sql
We may create a new schema in the memory connector or simply define a new memory connector here
https://github.com/starburstdata/dbt-trino/tree/master/docker/trino/catalog
Then with
make dbt-trino-tests

you should be able to test whether your new change actually works
Explaining this in writing makes it clear to me that the tests in place need to be improved

I am sure I am missing something but how does the Makefile run the models and tests inside jaffle_shop? When I run
make dbt-trino-tests, it only triggers the unit and integration tests, none of which run the models inside jaffle_shop.
Shouldn't the Makefile internally call run_tests.bash ?

@rahulj51: i also saw that, I think it's missing that call.

@rahulj51: i also saw that, I think it's missing that call.

I added the call to the Makefile. And changed the jaffle-shop incremental model to use a custom schema in order to test the fix.
Let me know if this makes sense.

@rahulj51
sorry for misleading you
./docker/dbt/build.sh
./docker/init_trino.bash
./docker/run_tests.bash

This should be what you need.
As described here:
https://github.com/starburstdata/dbt-trino#running-tests

Added a new incremental model for custom schema.
Removed the changes from Makefile
Modified run_tests.sh to rerun the incremental model


"Error: Component legend.scroll not exists. Load it first."

When trying to use the scrollable legend on demand I am getting this error, it works fine for the plain legend type. Is there another way I should be importing this?
import 'echarts/lib/component/lgend';
legend: {           type: 'scroll',           orient: 'vertical',           right: 10,           top: 20,           bottom: 20,         },

Fixed it with import 'echarts/lib/component/legendScroll'
Might not hurt to add to readme


Pre-compile xs_duration regex for use in parsing MPDs

We were doing some perf and memory testing / tuning of our application and noticed a lot of small allocations and overhead of compiling the regex for xs_duration (we have a lot of streams currently processing MPD updates every ~2s; we're not using fetch, but potentially the template url resolution there could benefit from this too though that's a much simpler regex).  Moving it to a static improved things a good deal.  This does introduce a dependency on lazy_static crate but there was already a transient dependency on it.  Let me know what you think.

Excellent, thanks! I'll look at this also for the fetch module, though that already has significant memory allocation requirements for downloading segments.


swarm: Managers back off to Worker role without demoting

Output of docker version:
Client:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   56fb100
 Built:        Thu Jul 14 18:01:59 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   56fb100
 Built:        Thu Jul 14 18:01:59 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 0
Server Version: 1.12.0-dev
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-28-generic
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.954 GiB
Name: node01
ID: ZTNM:55LA:E6YV:QC3Y:5QNC:LFMK:L4IE:MQ3Q:S43M:D45D:H4P7:HPLC
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 15
 Goroutines: 23
 System Time: 2016-07-14T16:45:45.518075087-04:00
 EventsListeners: 0
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Digital Ocean VMs:
3 Managers: 2 GB Memory / 40 GB Disk / Ubuntu 16.04 x64
3 Agents: 1 GB Memory / 30 GB Disk / Ubuntu 16.04 x64
Steps to reproduce the issue:

Create the cluster with 3 Managers and 3 Agents
Create a service
Scale the service to a high value (1000/2000)

Output of docker node ls:
ID                           HOSTNAME  MEMBERSHIP  STATUS  AVAILABILITY  MANAGER STATUS
0kcj1xdtbngheh54s1dxitevi    node06    Accepted    Ready   Active
0zy1wr8fh9lbs4myosr5pqhmx    node02    Accepted    Ready   Active        Reachable
124kqfd9u7eo3w1qsdfmrr27s    node05    Accepted    Ready   Active
7bpe7qdm50o7k15m3vormjd12    node04    Accepted    Ready   Active
anbi7afpj7aoj5lj4nnffoub1    node03    Accepted    Ready   Active        Reachable
e3lsnbu80kepinnzriq0gwc9m *  node01    Accepted    Ready   Active        Leader

Describe the results you received:
The Managers will all drop their Manager status and fall back to Worker mode somehow giving:
Error response from daemon: This node is not a Swarm manager. Worker nodes can't be used to view or modify cluster state. Please run this command on a manager node or promote the current node to a manager.

on docker node ls for the 3 Managers.
Raft is still running in the background but seems like another component is causing the Manager to stop in a weird way (there are error logs to state that the dispatcher is stopped at this point).
Describe the results you expected:
Manager keeps running and working even in degraded scenario (like this was the case recently). I'm not sure if this is a problem with certificate issuance or role assignment. But the Managers back off to Worker role even though some of the components are still up and running (like raft).
Additional information you deem important (e.g. issue happens only occasionally):
Seems to happen consistently. Will try to navigate through the flow of logs to see what happened exactly.

Any chance you have logs from this? Goroutine crash?

No crash now that the daemon has a lower default OOM score, but the sum of operations going on due to the massive scale operation makes it very hard to parse what is going on.
After running pprof, it seems that we spend most of the time swapping memory to disk, thus there might be some issues with certificate issuance which makes the daemon "think" it is back to Worker mode after some time.
Somehow I didn't encounter this behavior while testing #24516
Also I've noticed that if I scale down just before the Managers back off to Worker mode, they are in Worker mode for some time but go back to Manager once the cluster stabilizes and probably has more resources thanks to the scale down operation.
I'll retry with current master and see if I can reproduce.

I tried to run 1000 redis on 5 node cluster with command docker service create --replicas 1000 redis:3.0.7. I lose access to cluster after that.
ubuntu@ip-172-19-241-147:~$ docker node ls
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
ubuntu@ip-172-19-241-147:~$ docker service ls
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
ubuntu@ip-172-19-241-147:~$ docker ps -a | wc -l
125

Raft reports raft: failed to process the request: node lost leader status after this service.
grep -i "Jul 19 23:" backuplog | grep -i leader
Jul 19 23:02:54 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:02:54.030834384Z" level
=info msg="raft.node: 2cf0d4a8eb0185fa lost leader 57565e9aad5b2018 at term 6"
Jul 19 23:03:00 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:03:00.144399970Z" level
=info msg="2cf0d4a8eb0185fa became leader at term 7"
Jul 19 23:03:00 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:03:00.144580719Z" level
=info msg="raft.node: 2cf0d4a8eb0185fa elected leader 2cf0d4a8eb0185fa at term 7"
Jul 19 23:05:08 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:05:08.954771779Z" level
=info msg="raft.node: 2cf0d4a8eb0185fa lost leader 2cf0d4a8eb0185fa at term 35"
Jul 19 23:05:09 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:05:09.006052246Z" level
=error msg="failed to move all nodes to \"unknown\" state: raft: failed to process the reque
st: node lost leader status" module=dispatcher
Jul 19 23:05:09 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:05:09.149576141Z" level
=error msg="failed allocating ingress network during init: raft: failed to process the reque
st: node lost leader status"
Jul 19 23:05:09 ip-172-19-241-145 dockerd[8292]: time="2016-07-19T23:05:09.496159301Z" level
=error msg="scheduler tick transaction failed" error="raft: failed to process the request: n
ode lost leader status"

@dongluochen This makes sense as scheduling that many tasks exhausts memory, and we are stuck in a loop where the OOM trigger kills tasks but the orchestrator keeps retrying. Most of the time is spent swapping and the cluster becomes completely blocked. Gossip and Raft heartbeats deadlines are missed, vote requests are ignored, etc.
While the cluster becomes unstable in such scenario, Managers should keep their role until we are able to fix the problem with a docker service scale redis=50 for example. In my case the Managers are literally dropping their role and they consider themselves as Workers after some time. Which makes it impossible to fix the problem.
Restarting the Managers fixes the problem so there is a short time window where this can be fixed with scaling down but I would expect to be able to avoid this issue without restarting the daemons.
The real solution is documentation I think and using --availability drain on the Managers. Yet as Manager/Worker is the default, It would make sense to avoid such a scenario to happen in the first place.
I'm not sure what a good solution could be, maybe reserving a fixed chunk of memory for the daemon that no container could use if this is something that could be achieved. But this is a complex problem that a critical piece like Raft runs alongside containers without exclusive resource constraints.

@abronan In my case the cluster never recovered. Restarting managers doesn't help. I have to re-bootstrap the cluster.
I think service scaling may take the approach of service rolling update. New tasks are created in batches. Users can stop the rollout and change the service. It'd prevent fat finger errors.

@dongluochen I don't think anything will prevent this issue from happening as long as raft/gossip and other critical components don't have reserved resources that other process can't use/override.
I opened docker/swarmkit#1156 to track the service scaling potential user error.
Also opened docker/docker#24857 to recommend setting the Managers with --availability drain for scenarios where users might scale containers without resource constraints.

@abronan should I change this to a "documentation" issue?
/cc @sfsmithcha

Actually; I see we have the documentation merged; I'm closing this issue because https://github.com/docker/docker/pull/24857 is merged


support update context through Context ?

In order to update headers like Authorization or custom headers

https://github.com/HollyPony/react-rest-api/commit/82812459536b14781b82b65d288d388be89e69d0


travel agency

I created a suggestion:
https://github.com/MaestroGlanz/osmic/blob/master/amenity/travel-agency-14.svg
unfortunately it doesnt display as intended (zoom).

Just saw, that this already exists as well.

"already exists", see https://github.com/gmgeo/osmic/issues/34#issuecomment-298315579.

I think limiting the suitcase to one would already reduce clutter and look better.


[Style] Make color coding same.

What's the style idea?
We need to change the color of CalcDiverse in the navbar on the main page to make the color on whole navbar similar.
This will help in maintainability of the website in the same color throughout.

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 I would like to work on this issue, could you assign me this under GSOC'24 label?

Proceed @Aarzookhunger


[BETA][EAS] Filters are Misleading/Undocumented

Making use of /v1/applications as part of the Beta Automate API for EAS and encountered a few bumps trying to get it working.
First and foremost is there's no documentation regarding the endpoints other than in V1 Policies (there's nothing for V2). This provides the permissions required but nowhere else can pagination or filtering arguments be found, which led to me initially think the endpoint was bugged (#2610). I ended up using the source code [1],[2] to get my code working.
Second, the filters seem to correspond more to Compliance than to Habitat Services. Consider this return object:
{
  "services": [
    {
      "supervisor_id": "0710a75e58fc460ca5861559deac1d14",
      "release": "sirajrauff-public/sample-node-app/0.1.4/20191218214052",
      "group": "sample-node-app.default",
      "health_check": "OK",
      "status": "RUNNING",
      "application": "sample-node-app",
      "environment": "local-test",
      "fqdn": "2531d46609d9",
      "channel": "stable",
      "update_strategy": "AT-ONCE",
      "site": "laptop",
      "previous_health_check": "NONE",
      "current_health_since": "15 hours 16 minutes",
      "health_updated_at": "2020-01-14T01:05:58.885441Z",
      "disconnected": true,
      "last_event_occurred_at": "2020-01-14T01:07:28.965647Z",
      "last_event_since": "15 hours 14 minutes"
    },
    ...
  ]
}

The status filter corresponds to health check, which is misleading as the object has both status and health_check. i.e. the first time I saw the status filter, I tried to do status:RUNNING which is incorrect.
The buildstamp filter corresponds to Release and should be called release. In the same vein, service corresponds to name. I would've assumed service is sample-node-app.default, i.e <name>.<group>, not just the name
release is the full identifier. Would've been nice if this was renamed ident or identifier and an additional property release was returned with only the buildstamp/release.
group searches by the suffix, i.e. sample-node-app.default, but group in the object returned is in the format <name>.<group>. This would be more clear if only the suffix was returned in the property or if both were used in the filtering. This also means you can't use group as it exists in the return object and use it in subsequent filters, you'd have to do a split('.')

Misc:

Would be nice to have disconnected be a filter, I often don't care about disconnected services and want to see what version/releases of a particular service are currently running

Hi, thanks for filing this.
To your first point, I'll file an internal issue to make the API docs more complete. I as mentioned elsewhere, we are working to publish API docs online using the swagger stuff as the basis.
For the other stuff:

status: for filtering this is a combined concept covering both health checks and disconnectedness currently. Using status:disconnectedreturns only the disconnected services.
identifier/buildstamp/group/etc.: Some of this naming predates the habitat project standardizing some of the terms. We selected the filter-able fields based on what we thought would simplify the most common use-cases and match the labels in the UI as best as possible. It's unlikely we're going to prioritize changing these as it's a pretty high churn but low visibility task.
disconnected filter: As I mentioned, we have a filter to select the services that are disconnected. Sounds like you're asking to exclude them. The way the status filter currently works doesn't support that. We have explored some other ways of structuring this to give you more granular control, but haven't committed to that work at this time. We do plan to reintroduce the ability to manually remove disconnected services without waiting for the automatic deletion to clean them up.


Lumina-pdf silently crashes when scrolling/searching through a 744 page motorcycle manual

Lumina-pdf silently crashes when scrolling/searching through a 744 page motorcycle manual
the search would appear NOT to be doing anything. walk away, and it would be gone. Same issue, when I scrolled to the back of the PDF to look through contents list.one moment lumina-pdf is there, the next gone.
pkg info | grep lumina-pdf
lumina-pdf-1.5.0_201907010802  PDF viewer from the Lumina Desktop
pkg info | grep qt5-core
qt5-core-5.12.2_2              Qt core non-graphical module
about - Trident
about
Project Trident Information
OS Version: TOS-12-U2
Build Date: Wed Aug  7 07:47:52 EDT 2019
Boot Type: UEFI

Just check with the recent version, using the Project-Trident version.
no longer crashes


How to use .mutagen.toml with Docker

I searched the whole docs, but I can't find any information how to use the .mutagen.toml file for a local project.
There are some basic short notes to define exclude files, but no example config for a docker setup.

Maybe you are confused because this configuration file can't set alpha/beta URIs. You still have to configure those URIs through command line arguments.

@Toilal Thanks for jumping in to help.
@core23 Sorry for the slow reply, I've been traveling.  As @Toilal said, Mutagen's TOML configuration files (either the one at ~/.mutagen.toml or one specified with the -c/--configuration-file flag) just control synchronization behavior - they don't configure the synchronization endpoints, which are specified via command line arguments.  The synchronization behavior is independent of the protocols used for synchronization.
I've got a pending update to the documentation, so I'll try to make this distinction a little clearer in the introduction.
In the future, there may be some sort of higher-level orchestration tool where you specify the endpoint URLs in configuration files, but that will probably be something that scripts Mutagen.

Thanks for the explanation @Toilal @havoc-io 👍
So I'll have to create some custom bash script that will create and destroy the alpha and beta URls for now

You may have a look to mutagen-helper.


fix(parseGhost): apply correct delta transformations

:tada: This PR is included in version 3.7.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Conductor index page slow to load

Should try to fix with Postgres indexing

Maybe we should materialize views with the results of those queries.

Or perhaps caching.


chore: update MSRV to 1.75

We use features in code from 1.72, and [lints] is from 1.75, so we should update MSRV to 1.75
closes #5965

unused manifest key: lints


People not playing parkour are going to get teleported to the parkour lobby

Issue with PlayerListener following #250 - this will teleport non-parkour players who fall into the void to a parkour lobby
} else if (!playing && parkour.getConfig().isVoidDetection()) {
                parkour.getServer().getScheduler().runTaskLater(parkour, () -> {
                    parkour.getLobbyManager().teleportToNearestLobby(player);
                }, 1L);

That's the desired functionality; I agree it's strange as it's unlike anything Parkour has done before.
I think it's acceptable as some servers may have a floating lobby where players can be handled if they fall off, and most importantly it's disabled by default so will only be enabled by servers with an appropriate set up.


When paying back loan limit the amount that can be entered as loan repayment

What UI/UX improvements would you like to be implemented:
A few things When repaying back loan using DFI

Input field value should be denominated in the chosen repayment token DFI  (raised in #2121)
Available amount should display the available balance of the token in the wallet (DFI or DUSD) depending on the repayment token.
Max and 50% button should be calculated token required according to the loan balance, and indicate if there isnt enough in the wallet.
Excess amount and Resulting balance doesnt consider overpaying of the loan using DFI, and what will be returned back to the wallet in such case.

Why is this needed:
Better UX
Which component/screens does this concern?:
Light Wallet Manage Loan
Anything else we need to know?:

Hi @dougl888 , thank you for reporting! we are in discussion with UX behaviour related to this


Install command attempts to install even when no arguments are passed

Describe the bug
This is a trivial bug and more so a cleanup step then anything but when running ctp install without a specific input argument, the cli attempts to install rather than detect that there was no input and exit gracefully.
Observed behaviour
The issue I've seen is as follows:

Install and build the cli.
run ./ctp install
ctp attempts to install packages and attempts to check for installed packages but outputs nothing.

Expected behavior
ctp returns an error indicating that for the install com
Screenshots

mand cannot have an empty arg.
Device Information
OS: MacOS

This can also be extended to include all instances where we are expecting a slice of inputs (install, remove etc)
for remove command:
func removeInstalled(packages []string) {
	fmt.Println("Checking if the packages are installed...")

	// determine if there are packages in the packages slice
	if len(packages) == 0 {
		fmt.Println("No packages found to uninstall.")
		// gracefully exist the program if there are no packages
		os.Exit(0)
	}
    // rest of code ...
}

I was thinking perhaps no arguments could trigger a help dialog? Informing the user on how to use the command.

@DakshG07 I'm going to work on this issue :) Just commenting so y'all know

Alright, got that!

I've picked this up and will try to finish it soon.


Fix clippy lints

Going to merge with leak sanitizer build broken and will investigate what is going on separately.


Add PriorityQueue

This adds a priority queue implementation which we've copied in some form or another to use as a queue for timeouts. We're currently using a simplified version in amphp/http-server and I've used similar code in some personal and work projects. @bwoebi would now like to use this in amphp/quic without having to copy the implementation yet again, so I'm proposing we add it here.
This queue implementation provides ordering of array-keys based on an updatable priority. These array keys may then be used with a separate map to reference any other value, such as an object.

We ship a similar implementation as Timer Queue in Revolt. Should we place it there instead?

We could, though I hesitate to provide extra tools in revolt/event-loop which aren't directly related to the loop API. We could make it a separate library under Revolt. What do you think?

Quick note: The revolt loop uses a similar class, but is tailored for TimerCallback objects and uses floats for timer expirations. We could use this implementation there, but it would require multiplying timeouts by 1000 (or more?) and a map of timer IDs to TimerCallback.

Moving this to amphp/sync instead, see https://github.com/amphp/sync/pull/27.


Fix usePress with HTML input elements

This makes usePress work better with HTML <input> elements, which have default keyboard behavior. For example, checkboxes toggle when the space key is pressed. Previously this was somewhat broken, in that onPressStart would only be triggered on key up due to the browser firing a virtual onClick event.
In #3380, I changed usePress to look at the currentTarget rather than target when determining whether to handle an event. This caused TableView's select all checkbox to stop working, because the event would bubble to the cell and get handled there (with preventDefault).
Now we allow the space key for checkboxes and other input elements to trigger onPressStart on key down, but do not call preventDefault, allowing the browser to toggle the checkbox.

One slight change is that the Enter key on checkboxes will now bubble since the checkbox doesn't handle it, so table row selection will toggle in that case as well. I think this is ok?


Address #349: Resolve misc warnings

The following 3 types of warning are resolved, to address #349.

discarded non-Unit value

A => U instead of A => Unit as same as in IterableLike#foreach
Explicitly add () to synchronized block

implicit numeric widening

.toInt is used explicitly.

The outer reference in this type test cannot be checked at run time.

final modifier are removed for private case class. https://issues.scala-lang.org/browse/SI-4440

Before (https://github.com/sbt/zinc/commit/ad46221ca148629df111dbc1561ac348d2b15c9c)
The below commands shows the warnings except tons of never used.   I will address never used warnings in another PR.
$ sbt -warn ";clean;compile" | grep -E "\[.*warn.*/zinc" | grep -E -v "is never used" --count
24

$ sbt -warn ";clean;compile" | grep -E "\[.*warn.*/zinc" | grep -E -v "is never used"
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/DelegatingReporter.scala:15:15: Unused import
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala:75:75: discarded non-Unit value
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala:78:23: discarded non-Unit value
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala:16:15: Unused import
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:80:56: implicit numeric widening
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:81:48: implicit numeric widening
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:86:37: implicit numeric widening
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavacProcessLogger.scala:34:18: discarded non-Unit value
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavacProcessLogger.scala:37:18: discarded non-Unit value
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/AnalyzingCompiler.scala:347:56: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:72:67: method compilerJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:73:65: method otherJars in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:98:37: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:141:27: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala:82:12: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/Analyzer.scala:51:41: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavaCompiler.scala:105:43: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ClassName.scala:94:33: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:155:30: The outer reference in this type test cannot be checked at run time.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:156:30: The outer reference in this type test cannot be checked at run time.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:157:30: The outer reference in this type test cannot be checked at run time.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala:158:30: The outer reference in this type test cannot be checked at run time.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-ivy-integration/src/main/scala/sbt/internal/inc/ZincComponentCompiler.scala:94:30: The outer reference in this type test cannot be checked at run time.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-benchmarks/src/main/scala/xsbt/ZincBenchmark.scala:352:24: Unused import

After this PR
$ sbt -warn ";clean;compile" | grep -E "\[.*warn.*/zinc" | grep -E -v "is never used" --count
12

$ sbt -warn ";clean;compile" | grep -E "\[.*warn.*/zinc" | grep -E -v "is never used"
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/DelegatingReporter.scala:15:15: Unused import
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala:16:15: Unused import
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala:82:12: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/Analyzer.scala:51:41: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/compiler-bridge/src/main/scala/xsbt/ClassName.scala:94:33: method isImplClass in class Symbol is deprecated (since 2.12.0): trait implementation classes have been removed in Scala 2.12
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/AnalyzingCompiler.scala:347:56: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:72:67: method compilerJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:73:65: method otherJars in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:98:37: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/CompilerArguments.scala:141:27: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/javac/JavaCompiler.scala:105:43: method libraryJar in trait ScalaInstance is deprecated: see corresponding Javadoc for more information.
[warn] /home/exoego/IdeaProjects/zinc/internal/zinc-benchmarks/src/main/scala/xsbt/ZincBenchmark.scala:352:24: Unused import

The above remainings are left intentionally for compatibility, as was in the past PRs .

To validate this pull request against other sbt modules, please visit this link.

A validation involving this pull request is in progress...

The validator has checked the following projects against Scala 2.12, 2.11, 2.10,
tested using sbt-allsources.sh.

Project
Reference
Commit

sbt
1.x
sbt/sbt@e078c126d15a1967910357a1a2e06971a56c66c6

zinc
pull/500/head
sbt/zinc@947f39ad646ee59bc186bdeb672485155ad75ed4

io
1.x
sbt/io@438474e08d34e0ef892e9ee632b028e7563aa466

librarymanagement
1.x
sbt/librarymanagement@0d21ae6369a3e4054ed434902ea84b2520d21da9

util
1.x
sbt/util@85f7d807e116b0247c233259f66b592e05a14ffe

website
1.x
sbt/website@c605957d2356e43c37a99831fafd484fa13b8bda

:white_check_mark: The result is: SUCCESS
(restart)

I'm concerned about the type-signature change to avoid the non-unit discarding, as well as opening those case classes for extention..
Let's see first what CI thinks.

@dwijnand
https://platform-ci.scala-lang.org/sbt/zinc
Looks like Drone CI got stuck for days on several PRs...
Could you restart pending builds ?

Drone CI fix, PR validation restarted @exoego


dutch locale returns wrong format for differences of more than a year in colloquialSinceNow()

How to produce:
let regionAmsterdam = Region(tz: TimeZoneName.europeAmsterdam, cal: CalendarName.gregorian, loc: LocaleName.dutch)
let threeYearsFromNow = DateInRegion(absoluteDate: Date() + 1.year + 1.month, in: regionAmsterdam)
let colloquial = try! threeYearsFromNow.colloquialSinceNow().colloquial
print(colloquial) // "over 2018 jaar" -> literal translation: "in 2018 years"

I also tried it with the .englishUnitedStates locale an that returns "on 2018", which also doesn't seem like desired behavior.

It should be "on 2016". what's the equivalent for "on"? I see "in" in google translate; is this correct?

Can you make a check of the /Sources/SwiftDate/SwiftDate.bundle/nl-NL.lproj/SwiftDate.strings and tell me if there is something else wrong?
File link


bpf: redo regular ct entry upon service collision

Signed-off-by: Daniel Borkmann<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.06%) to 41.766% when pulling c176761b608e4ceb358836baa845b1674316dfbb on pr/fix/svc-coll into 9499c3d70f144d4e555ce7b282dec48613bfc743 on master.

test-me-please

test-me-please

/cc @brb PTAL, the analysis is in the commit desc.


Solidus Support

I wanted to know if this extension also works for Solidus? If not, are there any extension similar to this that works with Solidus or what should I change to this one to make it work for Solidus?

Someone has forked this project for Solidus. Check it out https://github.com/gildardoperez/solidus_flexi_variants


Build fails with can't find crate for proc_macro on musl target

When targeting musl (nightly-2017-02-13, but the stable 1.15.1 fails too.), I'm encountering the following error:
Compiling proc-macro-hack v0.3.0
error[E0463]: can't find crate for `proc_macro`
 --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro-hack-0.3.0/src/lib.rs:1:1
  |
1 | extern crate proc_macro;
  | ^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

error: Could not compile `proc-macro-hack`.

Here is a dockerized test: https://github.com/golddranks/proc_macro_test (run with docker build .)

I don't know much about musl but based on macros 1.1 implementation details it doesn't sound like procedural macro crates can be statically linked. It should still be possible to use a dynamically linked proc macro crate's macros from within a statically linked other crate - if not, file a Cargo issue.

So it seems that on musl target, "normal" derive marcos as introduced in the book work without a hitch, but proc-macro-hack fails. The reason seems to be that on musl target it can't find the proc_macro crate unless the crate using it is also marked [lib] proc-macro = true.
I think the problem is, indeed in static and dynamical linking, but a actually the proc macro part seems to work fine, and the problem is the statically linked part that still links to proc_macro.

The reason why proc_macro is linked from proc-macro-hack seems to be because of these lines TokenStream is mentioned:
            pub fn $func(input: $crate::TokenStream) -> $crate::TokenStream {

Is importing TokenStream a necessity here?
I'm going to also file an issue to the Rust repo about the inability to link to proc_macro.

Okay, the reason seems to be that proc_macro is currently always dynamically linked, so it's incompatible linking it with a binary built for the musl target.
This makes proc-macro-hack incompatible with musl unless either the dependency to proc macro in the declaration crate can be gotten rid of, or unless rustc starts supporting linking proc_macro statically.

I released 0.3.2 with a fix. Try it out with:
proc-macro-hack = { version = "0.3.2", default-features = false }

Your crate is responsible for providing ::proc_macro:
extern crate proc_macro;

#[macro_use]
extern crate proc_macro_hack;

proc_macro_expr_impl! {
    /* ... */
}

Tried with the binary_macros crate (newest commit on master), but the following error occurs:
error: attempted to repeat an expression containing no syntax variables matched as repeating at this depth
 --> src/lib.rs:9:1
  |
9 | proc_macro_expr_decl!(base2! => base2_impl);
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro outside of the current crate

error: attempted to repeat an expression containing no syntax variables matched as repeating at this depth
 --> src/lib.rs:9:1
  |
9 | proc_macro_expr_decl!(base2! => base2_impl);
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a macro outside of the current crate

That looks like the error from https://github.com/rust-lang/rust/issues/39889. You need to use stable 1.15 or beta 1.16 at least until tomorrow's nightly is out. See the note in the readme.

Oops, that's right! This was an unrelated error.

@dtolnay: Thanks, this works.
For future reference: for the default features to be omitted, every crate linking to proc-macro-hack must set default-features = false, so this might be a bit fragile solution, but it works for me, at least.

@alexcrichton made a point which made me think that not referencing proc_macro, (like it now does without default features) is the "proper" way to do this. Not that it matters too much if this crate is just a hacky stop-gap solution, just a pointer.


fix(releases): android submission issues

This PR resolves []
Description

Updates the s3 path to the newer path and moves to a variable
Adds s3 upload that was missing from beta deploy

Draft until I test.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against a7138bec45e96abc35575148e251c6415333c01d


Postgres TPR stays in unknown state

I created a new postgres using:
apiVersion: kubedb.com/v1beta1
kind: Postgres
metadata:
  name: cowrypay-qa-db
  namespace: default
spec:
  databaseSecret:
    secretName: cowrypay-qa-db-admin-auth
  storage:
    accessModes:
    - ReadWriteOnce
    class: pd-standard
    resources:
      requests:
        storage: 10Gi
  version: 9.5-db

Since the version 9.5-db, it immediately went into a Failed state. I was able to see that from Pharm.
Then I edited the TPR to change version to 9.5. It was not picked up. Then I deleted the TPR and created a new one. It was not picked up also. Now, it went into unknown state. Now, Pharm is also giving me 500 error.
FYI, the underlying StatefulSet existed from before from old k8sdb.com group. What is the issue here?

version should be string type
version: "9.5"

@aerokite , I did that. still failing

Your previous statefulset & service labels do not match with new one

You diagnosis about incorrect version # is correct. but fixing that was a pain.
I have essentially disabled the operator. manually delted the TPR, SS, Svc. Then restarted the operator. Then created the TPR again. Things worked after that.
I think the todo here is, design the ux, when users make a mistake like this.

https://github.com/k8sdb/apimachinery/pull/107 will automatically turn 9.5 into "9.5"

This problem is fixed.


Cannot set background to transparency on stats

Hi! I cannot set the background of the line and pie graphs to transparent, even if I edit functions-infos.php! No matter what I do, it stays white!
how do I set it?

Don't know if that's possible with the current graph library we're using, Google Charts. Check there.

Found something https://developers.google.com/chart/image/docs/chart_params (find background fills).
Where would I set that parameter though?


ROX-19561: Add Sensor message rate limit

Description
This PR adds global rate limiting for sensor messages sent from all connected secured clusters.

Added env variable to set rate limit for sensor messages (check CHANGELOG)
Refactored init sync manager to rate limit manager

Add support for Sensor message rate limiting
Add init sync boost (not configurable) per sensor
Changed previous logic for max init sync sensors - if it's unlimited, it will be set to math.MaxInt (that simplifies logic with boost)

By default, we will not limit sensor messages, and for a negative rate limit, the app will panic on start

For benchmarks, check the description on PR: #8116
Considerations

Should we increase boostInitSyncRateLimit?
Should we remove boost logic?

Pre-requirement: #8116
Checklist

[x] Investigated and inspected CI test results
[x] Unit test and regression tests added
[x] Evaluated and added CHANGELOG entry if required
~[ ] Determined and documented upgrade steps~
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed
Here I tell how I validated my change

Added GoLang unit tests
Planning to test it with scale scripts

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

If there is a single cluster misbehaving, does it make sense to target it and throttle that? I'm not sure that a single high cap for all sensors gives us the flexibility we want

@connorgorman I understand your concerns, and I agree that the flexibility here is limited. In the case of ACSCS, our intention is to utilize this feature sparingly and only in exceptional circumstances as a manual intervention (SOP). Currently, our approach doesn't involve throttling messages; instead, it leads to the termination of a connection.
The primary objective of this limitation is to safeguard the central from resource depletion, whether caused by a single misbehaving sensor or a substantial load from multiple sensors. Therefore, the rate limit must be defined globally for the central.
With this requirement in mind, what solution would you suggest? One possibility is to track the "resource consumption" (number of messages) by each sensor and disconnect the largest consumer when the limit is reached.

/retest

We decided to postpone this functionality and implement a solution that would isolate problematic sensors in a better way. I have created another ticket for that. I'll close this PR to keep the JIRA state clean.


Swinv2

Hi,
I have trained a Swin transformer but I am getting a weird error when trying to load the saved model (.h5) with keras load_model.
The traceback I get is this one:
File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/keras/utils/traceback_utils.py", line 67, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/keras/layers/merge.py", line 96, in <setcomp>
    batch_sizes = {s[0] for s in input_shape if s} - {None}
TypeError: unhashable type: 'list'

Any idea what may be the cause?

It's caused by swin_transformer_v2.py#L95 attn = keras.layers.Add()([attn, mask]). It can be fixed using attn = attn + mask instead:
# Use `attn = attn + mask` instead of `attn = keras.layers.Add()([attn, mask])`
from keras_cv_attention_models import swin_transformer_v2
mm = swin_transformer_v2.SwinTransformerV2Small_ns()
mm.save('aa.h5')
bb = keras.models.load_model('aa.h5')

But then it will throw error using TPU with bfloat16 in model saving... Not sure if any method fit both situation.
Currently, you may reload using load_weights:
from keras_cv_attention_models import swin_transformer_v2
mm = swin_transformer_v2.SwinTransformerV2Small_ns(input_shape=..., num_classes=...)
# Any other layers
mm.load_weights("{pretrained.h5}")

Maybe wrapping make_window_attention_mask as a layer can work for both situation. Will take a try.

It should works now, for both situation. May save and load your model again:
from keras_cv_attention_models import swin_transformer_v2
mm = swin_transformer_v2.SwinTransformerV2Small_ns(input_shape=..., num_classes=...)
# Any other layers
mm.load_weights("{pretrained.h5}")
mm.save("aa.h5")

bb = keras.models.load_model('aa.h5')

It works now, amazing job!


Fix bunny support for when pop does not return a message

Currently, if pop a message results in no message (because the queue is
empty), an error is logged because of a NoMethodError on nil:NilClass.
This fixes it by skipping recording the segment if no message was
returned.
I'm not sure if the skip is the correct solution, but it makes it so the log file isn't filled with errors when you do a lot of pops against empty queues.

Thanks for your contribution, @soupmatt! We'll be evaluating it for possible inclusion in a future Ruby agent version.

I added another commit to handle another NoMethodError we were getting when using Queue.pop.

We've incorporated your fix, with credit, into the just-released version 6.1 of the agent. Once again, thank you! Closing this PR as complete.


find way to do api.Work.do better

it is not good (not flexible):
case <-time.After(time.Second):

partial solution is 7d2df842790990e8d3a453989509d6e82691b3c5


transferring: Add maintainer metadata

@josephholsten im :+1: on that, Was something I considered when migrating things in.

@zuazo how's that?

got open PRs for each cookbook applying this

Perfect! :+1:


[TOPI][Hexagon] Implement global_avg_pool2d for hexagon

This PR adds implementation, testcase and schedule for quantized and float16 global_avg_pool2d op for hexagon. The op supports NCHW layout.

Hi @mehrdadh, this PR passed all the checks.


fix(v2): adjust sidebar menu close icon to center

Motivation
Make correct vertically centering of sidebar menu close icon on mobiles.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Before
After

Now it's off center for browser with narrow width :/

But I guess it's ok since we're fixing it for mobile

Now it's off center for browser with narrow width :/

Hmm, this is very strange, it should not be like this :(


401 status code instead of redirect when securing API

I added an option to send 401 (Unauthorized) instead of redirecting to '/login' by default. This should be useful for securing APIs when accessed by client-side script.

Temp solution:
Create a route;
router.get('/401', (req, res) => {
    res.sendStatus(401);
});

Redirect if unauthorized:
router.post('/submit/', connectEnsureLogin.ensureLoggedIn('/401'), asyncWrapper(paletteCtrl.submit));


Upgrade babel-jest to use babel 7

Do you want to request a feature or report a bug?
feature
What is the current behavior?

Babel jest uses babel-core which doesn't work in my project where I upgraded babel 7

What is the expected behavior?

Update to babel-jest to use Babel 7

I want to work on this. I understand that this is breaking change. Any idea on how to maintain backward compatibility?

You don't need to upgrade babel in babel-jest - it works with babel 7 already. See the note here: https://facebook.github.io/jest/docs/en/getting-started.html#using-babel


[RFC] Change property names of src in SfImage

Instead of small and normal perhaps we could use mobile and desktop which is more descriptive and can't be misunderstood (for example normal can be misunderstood as thumb or sth)
@leomp12 ?

Yup, sounds better!
Just to remember, it would be a breaking change, SfGallery and SfProductCard must be updated after that.

I'll take it

@NessaMr

@leomp12 awesome, thanks. Yeah I'm aware of it


 I'd suggest to either improve the syntax or not expose it to the user at all

We can do some massaging.


added my name to guestbook.md

Wonderful job writing this book. Thank you so much Sean.

Thank you! I am so happy you enjoyed the course!


Solid Earth Tide using per pixel Azimuth Time derived from ISCE2 orb.geo2rdr

Solid Earth Tide computation using the orb.geo2rdr which outputs a tuple azimuth_time and range as noted here shared by @mgovorcin.
Steps are:

Get azimuth time array with coordinate frame determined by `science/grids/imagingGeometry
Compute Solid Earth tide for the azimuth time rounded to nearest second above and below precise azimuth time and compute a weighted average.
Package into an xarray georeferenced dataset

The notebook test is for interacting with the output and the pytest test file ensures georferencing is done correctly so can be ready by gdal or rasterio.

Here are some sample products with overlapping spatial/temporal area: GUNW 0 and GUNW 1.
To update a product with the solid earth tide yourself, here is the sample code:
from pathlib import Path
import xarray as xr
from hyp3lib import get_orb
from isce2_topsapp.solid_earth_tides import update_gunw_with_solid_earth_tide

nc_path = Path('<GUNW_PATH>')
group = f'science/radarMetaData/inputSLC/reference'
with xr.open_dataset(nc_path, group=group) as ds:
    slc_id_ref = ds['L1InputGranules'].values[0]
group = f'science/radarMetaData/inputSLC/secondary'
with xr.open_dataset(nc_path, group=group) as ds:
    slc_id_sec = ds['L1InputGranules'].values[0]

orb_file_ref, _ = get_orb.downloadSentinelOrbitFile(slc_id_ref)
orb_file_sec, _ = get_orb.downloadSentinelOrbitFile(slc_id_sec)

update_gunw_with_solid_earth_tide(nc_path, 'reference', [orb_file_ref])
update_gunw_with_solid_earth_tide(nc_path, 'secondary', [orb_file_sec])

For the API, I have a list of orbit files, but I don't think that is necessary. May want to have single path or string.
@sssangha - take a look at it when you get back and then let Marin give a final review after you make any necessary modifications.

There is an issue that was discovered by @sssangha with this PR.
Unsure how this is normally dealt with.
It appears that orb.geo2rdr requires more steps to converge to the azimuth time and rng distance when using the full orbit file. In  ISCE3 there are options to increase the number of iterations of the numerical method to approximate this and in Raider there is a clipping of the orbit around is reference acquisition time. Because ISCE2 does not have options to increase the number of iterations we will pursue the latter.

@sssangha - this is ready for review - the same code snippet above still works.
I also added a test that I will link to below that resolves the issue you caught regarding geo2rdr.

@cmarshak I fixed the shift of lat array (previously the factor was added in this line) vis-a-vis the mintpy convention here.

@sssangha - I am reverting this.
Note in the mintpy is using the affine transform where we are using positive resolutions. The + was correct. Mintpy is using the signed resolutions as noted earlier in its code: https://github.com/insarlab/MintPy/blob/main/src/mintpy/prep_aria.py#L181

@sssangha - please approve once you are ready. After that, David can also review with you.
Thanks!


step in decrcounter is pass by value

https://github.com/fioprotocol/fio/blob/ea4dafb7df1ed83cca52d773fcb6d1fe6beec7a3/fio.contracts/contracts/fio.address/fio.address.cpp#L1051
Recommend:
  void decrcounter(const string &fio_address, const int32_t &step)

Resolved by #82

Fixed in https://github.com/fioprotocol/fio/pull/92


Add validation for images.

[ ] you need to validate the size of the picture, as well as check whether the picture itself really comes and not .pdf or something else, before throwing it on the azure
[ ] and in the user profile you need to add the same validation to the image (at the front and at the back to check the size)


DPE-5123 MySQL HA modules

Description
We need to offer HA modules for MySQL k8s and VM as part of 24.10 cycle.
Type

[ ] Fix issue
[x] Add module.
[ ] Change existing module.
[ ] Other. Please describe bellow.

How to test

cd modules/{k8s,vm}/mysql-ha/
terraform init
terraform apply -var='mysql_charm_constraints=arch=amd64'

Var mysql_charm_constraints required to workaround juju provider bug.
All applications should become active and related. Mysql will have mysql_client interface offer.
Additional context

I'm aware of current spec to get these modules within projects repo, but until is settled, would like to merge it here.

@jsimpso @fbertetto Can you take a look please?

@jsimpso @fbertetto Can you take a look please?

@amandahla I've discussed the module internally and there's a couple features to be included still

LGTM, and thanks for including links to relevant bugs @paulomach !


Rename example project files

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-100.0%) to 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-100.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

Generally, we expect the first PR to get the repo to some functional state; more than just renaming files from the skeleton. It should do something useful, even if it's a super bare-bones version of what the repo will eventually become.

@nickviola , @JCantu248 , @ameliav - For the sake of bare-bone functionality, can we add in the functions from staging get_json_file, parse_json and update Usage. Correct me if I am wrong, but this will take in the report data and have it ready for the report generation which can be in a follow-up PR.

Unit test cases will be implemented with the upcoming PR for Issue: https://github.com/cisagov/tpt-reports/issues/6


Gh 1289 update accumulo

Before merging this in we need to check the gaffer-tools 'slider' implementation will still work.

Codecov Report

Merging #1300 into develop will decrease coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1300      +/-   ##
=============================================
- Coverage      64.57%   64.44%   -0.14%
+ Complexity      1532      992     -540
=============================================
  Files            688      311     -377
  Lines          22236     9675   -12561
  Branches        2734     1170    -1564
=============================================
- Hits           14359     6235    -8124
+ Misses          6756     2953    -3803
+ Partials        1121      487     -634

Impacted Files
Coverage Δ
Complexity Δ

...onutil/iterable/LimitedInMemorySortedIterable.java
47.22% <0%> (-2.78%)
15% <0%> (-1%)

...lostore/key/impl/ElementPostAggregationFilter.java

...q/gaffer/parquetstore/utils/SparkParquetUtils.java

...rk/operation/dataframe/GetDataFrameOfElements.java

...processor/processor/QueryAggregationProcessor.java

.../addelements/impl/RDD/AggregateGafferElements.java

...antiles/binaryoperator/StringsUnionAggregator.java

...er/parquetstore/io/writer/ElementWriteSupport.java

...ov/gchq/gaffer/parquetstore/index/ColumnIndex.java

...e/impl/classic/ClassicIteratorSettingsFactory.java

... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2b1bb...4e58f9c. Read the comment docs.


When passing a relative path to configure, custom build scripts fail

This is because they are run from the module root directory. Need to figure out a way to ensure that path to custom build script is always absolute

aacc51393c9845a46d4b0637c0afa608136ce3d9


DAWN-690 ⁃ Enable integration tests

Many of the tests were disabled temporarily due to bios related limitations. With Phil's launcher changes it should be possible to re-enable these tests.
ATC:
Run following tests successfully:
tests/p2p_tests/sync/test.sh
tests/p2p_tests/sync/test.sh p 2 d 10
tests/p2p_tests/sync/test.sh -m p 21 n 21 d 5 l
tests/trans_sync_across_mixed_cluster_test.sh p 1 n 2
tests/distributed-transactions-test.py p 1 n 4
tests/distributed-transactions-remote-test.py --dump-error-detail
tests/restart-scenarios-test.py ~~c resync p3 -~~dump-error-details
tests/restart-scenarios-test.py ~~c replay p3 -~~dump-error-details
tests/consensus-validation-malicious-producers.py w 80 dumperror-details
tests/nodeos_run_test.py
tests/nodeos_run_remote_test.py
tests/nodeos_run_test.py --mongodb

The following tests re-enabled via #1852
tests/nodeos_run_test.py
tests/nodeos_run_test.py --mongodb

All of the tests are now enabled.


[New chain]: IRISHub Mainnet

ChainId
6688
Chainlist
https://chainlist.org/chain/6688
Contract deployed

[x] I confirm that the contracts are deployed

Version of contracts deployed
v1.4.1
Relevant information
PR: https://github.com/safe-global/safe-deployments/pull/746

PR #746 merged


Add frozen_string_literal pragma to generated files

Up for discussion obviously
Is your feature request related to a problem? Please describe.
I'm always frustrated when the files from a generator are generated do result in linting tools (mostly rubocop) screaming at me.
I know obviously that completely adhering to one style is obviously a bit pointless. But the first one rubocop offense top of the file. String literals are not frozen. And a rspec test file completely full of string literals. This is not a Style issue, it is a technical issue.
I think it would help developer UX when that would not be necessary to change after the generator execution.
Describe the solution you'd like
Template files start with the now very common frozen_string_literal: true pragma.
Describe alternatives you've considered

Excluding the cop check from spec directory. Uncool
Freeze strings by default when executing the ruby interpreter? yeah, not happening. To cumbersome, too brittle.

Additional context
It was even decided that string literals will not be frozen by default with Ruby 3. So the problem will not go away automatically when the rails projects are getting updated to ruby 3
See: https://bugs.ruby-lang.org/issues/11473#note-53

Is there any evidence that freezing literals in spec files gains any benefit in terms of memory consumption or execution time? Is there a case that a string object might be accidentally mutated and have side effects on other examples?
Related: https://github.com/rspec/rspec-core/issues/2264 https://github.com/rspec/rspec-core/pull/2662

Some prefer it with this pragma, some - without.
I'm not aware of generator integration with style configuration, it would be barely possible to yield results that would appease style checkers. With RuboCop though, it should be possible to extend generators to run rubocop --safe-auto-correct on generated files. Would it work for you?

Is there any evidence that freezing literals in spec files gains any benefit in terms of memory consumption or execution time?

In my opinion this does not matter, which is why I would not bother with making a benchmark.
Freezing string literals is objectively better, it reduces less memory; it enforces to use some more explicit code, etc. It is what the ruby community should strive for as a whole.

Some prefer it with this pragma, some - without.

Why would anyone prefer that unless for some annoying compatibility reason? Besides, we are talking about generated, emtpy, shallow test files.

I did some benchmarks back in the day when optimizing a huge test suite, and couldn't find any improvements in memory consumption with that pragma turned on.
One of the real-life reasons to turn it off is two meaningless lines, and I'd really love to see a good justification for that. It's not that two lines are a big deal, but what's on the other side of the scales?

:wave: I don't think you sound rude, but there is back story you are missing as to why we don't do this currently. RSpec is semantically versioned and we are also catering to the lowest common denominator, we want everyone to be able to use RSpec to test things. We haven't historically recommended it because it has to work out of the box, sure its frustrating when things aren't setup the way you want, but imagine the frustration a new comer has when things don't work at all out of the box. Also remember rubocop is not the defacto ruby standard, it's their set of opinions.
So prior to the upcoming release it was a breaking change for us to introduce this to generated code, people may not have been able to use it. I'm open to changing this in RSpec-Rails 4 provided its tested as working, as I'm not sure Rails is 100% frozen string literal safe.

@klyonrad What are your thoughts on this?

Oh sorry, did not realize that were questions to me. I guess we can close this issue. I mean, I didn't actually expect that anyone says "yeah let's do it" but I thought it would be nice to document the reasonings here.
I still think that it wouldn't be thaaaat big of deal but given that not even the rails generators add the pragma comment (also super annoying when I just generate a DB migration 😁) I would say it's reasonable to keep it as it is (or postpone this to version 5.x or something. Although I would argue that rspec-rails can be a bit more "bleeding edge than rails 😉.
See for example https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_unit/scaffold/templates/functional_test.rb.tt

Also remember rubocop is not the defacto ruby standard, it's their set of opinions.

As mentioned, this is not about rubocop, but more about the ruby ecosystem. I interpret the history of the https://bugs.ruby-lang.org/issues/11473 in the way that freezing the string literals is still a good idea but Matz is only afraid about compatibility (gems and projects). So by raising awareness to this stuff the ruby ecosystem might be more carefully with string literals and maybe at some point in the future Matz would feel more confident in changing the default after all.

One of the real-life reasons to turn it off is two meaningless lines

If we would have the case that those lines become meaningless with Ruby 3, then yeah the lines have would become meaningless in the future. But how it looks now is that they will not become meaningless.

I'm not sure Rails is 100% frozen string literal safe.

I find it very hard to believe that actually rails itself would have a problem with frozen strings - they started caring about it too in their codebase. It is not unlikely that the codebases of people would break in some way - but when that happens it would not be to much of a dealbreaker to catch it in tests, right? Remember, we're not talking about applying frozen_string_literal: true to every existing file without people noticing, but to adding it to new files, the very early stage of development.

Remember, we're not talking about applying frozen_string_literal: true to every existing file without people noticing, but to adding it to new files, the very early stage of development.

Remember that new files interact with existing files, and the frozen strings can and do migrate through to existing code. This is the compatibility problem.

Closing since there's no clear way on how to proceed. At least not adding a pragma is less harmful, so let's keep it this way for now.

I think there is a way to proceed, we can make this opt-in with a configuration option

@klyonrad Would you like to tackle on this option?

Yeah, but more like around April or May

I think there is a way to proceed, we can make this opt-in with a configuration option

Hmm. I tried fiddling around with the rspec configuration object (something like RSpec.configuration.frozen_string_pragma?) but it looks to me that this is not available in the generators. Adding it to the require list in lib/generators/rspec.rb breaks completely.
@JonRowe Or was your suggestion meant as (yet another) command line flag?

It'd probably have to be a command line flag I'm afraid (that seems to be how generators work)


Look into optimizing the running of MLST

We are currently using --threads in the mlst program, but this may not be the fastest way. Look at running separate mlst instances instead of using the --threads parameter.

This is now fixed in #85


Add series description to fields for unique fields in tabulate

HCP sequences use series_description.

Let me know if you guys would like access to a test project on Flywheel

@cookpa we actually did patch this after the meeting, I just forgot to push the commits to master, see 77db798


Performance & Memory Measurement Features

Let's support performance & memory measurement features.
The feature can be broken down into two main parts - measure and visualization, which should run seamlessly from User's view.
Measure
The measurement must be available both on remote linux machine (docker or system) and remote TV board.

[ ] Enable performance measurement (Prerequisite: execution environment support)

[ ] Enable on simulator
[ ] Enable on H/W
[ ] Make easy of simulator-H/W selection

[ ] Enable memory measurement in compilation environment : Generate mondrian csv file
[ ] (advanced support) Provide further inspections: total execution time, bottleneck ops, NPU utilization info, ...

Visualization
Performance Visualization

[ ] Support view for performance result (number in string)
[ ] Support view for chrome trace json file

Memory Visualization

[ ] Support view for mondrian csv file

Etc

[ ] (additional support) Provide related terminology explanation with pop-ups, mainly for developers familiar with other frameworks.

/cc @Samsung/one-vscode

"showing DRAM info" took higher priority when we discussed UX. How about adding that item into the list?

@hyunsik-yoon As far as I remember, runtime memory usage is very tricky to measure, so we only talked about providing static analysis using Mondrian, didn't we?

FYI, it's easy to show just memory of a process but not easy to analyze memory of the process.

Maybe the expression "showing DRAM info" could cause confusion.
I meant the second one in the list below. I should have used "static DRAM usage". 😹

showing dynamic DRAM state (measured frequently after running a process) --> challenging
showing statically calculated DRAM usage (e.g., input, output, weight, etc) --> from, e.g., backend profiling tool

@hyunsik-yoon Sure. I added the line Support view for internal profiling tool output (number in string) 😄

Does anyone work on Enable memory measurement in compilation environment : Generate mondrian csv file? I suppose this feature requires support for both ONE toolchain and backends. I want to implement support for this feature in one of backends and synchronize it with frontend support (in case there's any).

@ai-moiseev Sure it is not taken yet. You can make an issue to notify others that the job is taken and go on it :-D

I've created an issue for this: #395
I'll keep it in sync with ONE support. I'm currently investigating a ways for implementation of memory visualization utility with extensible input format support (it was discussed that current CSV-based format lacks a few important features and is hard to extend - so I want to prepare a draft documentation on a new JSON format with model metadata, memory block origin data etc.).

Enable performance measurement (Prerequisite: execution environment support)
Enable on simulator
Enable on H/W
Make easy of simulator-H/W selection

This looks similar to #306 + #307.

As I told, I'm intereste din Enable performance measurement (Prerequisite: execution environment support)

@YongseopKim @llFreetimell @struss I have updated the top comment about kick-off and deadline schedule. They are mostly about 1months span. Please tag your name after the task you are interested. We will have each the kick-off meeting at the date and begin the task.


Bump openshift-os to latest release-4.12

/test e2e-gcp-upgrade

/override ci/prow/e2e-gcp-upgrade


queue dies

Hi there,
so far I've been unable to get even the most basic of queue working properly: see the following (coffeescript) code:
Firebase = require 'Firebase'
Queue = require 'firebase-queue'

ref = new Firebase("https://myhost.firebaseio.com/testQueue")

# set up queue and listen for messages
queue = new Queue ref, (data, progress, resolve, reject) ->
  console.log "packet on queue: "
  console.dir data
  resolve()

# post 10 messages to the queue
for num in [1..10]
  ref.child('tasks').push({ msg: 'this is message ' + num })
  console.log 'added message ' + num

this usually outputs the following:
added message 1
added message 2
added message 3
added message 4
added message 5
added message 6
added message 7
added message 8
added message 9
added message 10
packet on queue:
{ msg: 'this is message 1' }
packet on queue:
{ msg: 'this is message 3' }
packet on queue:
{ msg: 'this is message 4' }
packet on queue:
{ msg: 'this is message 5' }
packet on queue:
{ msg: 'this is message 6' }
packet on queue:
{ msg: 'this is message 7' }
done.

yes, it usually skips message 2 and typically leaves 4-6 messages on the queue that it never picks up.
Am I missing something here or is this library plain broken?
thanks
Peter

Also, how can I turn on the debug logging externally, for these classes?

This was also sent to support@ for help there, and we're working on being
able to reproduce the issue (currently we can't)
To answer your second question, this is how you enable debug logging on the
queue:
var winston = require('winston');
winston.level = 'debug';
On Thu, Jun 11, 2015 at 3:32 PM, Peter Hulst<EMAIL_ADDRESS>wrote:

Also, how can I turn on the debug logging externally, for these classes?
—
Reply to this email directly or view it on GitHub
https://github.com/firebase/firebase-queue/issues/22#issuecomment-111294554
.

This was also sent to support@ for help there, and we're working on being
able to reproduce the issue (currently we can't)
To answer your second question, this is how you enable debug logging on the
queue:
var winston = require('winston');
winston.level = 'debug';

So it looks like this is related to the version of Node you're running. TL;DR use a stable version of Node (don't use 0.11.x)
Node 0.10.x and 0.12.x stable releases work, but some versions of 0.11.x are based off a version of V8 with a broken SHA hash implementation which breaks Firebase transactions. Upgrading 10 0.12.4, downgrading to 0.10.38 or using io.js should all fix the problem.

that did it. thanks for the help in tracking this down!

I am seeing similar behavior, leaving tasks in finished state, and next state is not activated. Restarting the process start processing again. Still trying to debug into it.


Feature: Set expanded state for all operations

What feature or improvement do you think would benefit Files?
I would like to request a better/improved file operations dialog/menu or to add the ability to have it automatically open or show a popup when an operation is done. Like in Edge browser the download dialog opens when a download starts or in explorer.exe it shows advanced view for every operation after I select more info instead of me having to hit more info every single time. Maybe the option to also have it show as a separate/pop-up window too.
Requirements

Keep last expand state and apply it to all future operations

Files Version
<IP_ADDRESS>
Windows Version
Windows 11 Pro 22621.3810
Comments
Thanks for the hard work.

Thanks for the feedback, We're tracking showing the menu when starting in #13560 and separate window support in #8207. You can check there or click subscribe in the right sidebar for updates.

Is this not planned or did you not see that I updated this request to only be about one (Default expend states for status center operations) and merged for the other two?

Ah, I see this this was edited.


[Bug]: create an event for accessing templates tab

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Since the month of January, Mixpanel stopped recording the ROUTE_CHANGE event.

Steps To Reproduce
Check this Mixpanel dashboard - https://mixpanel.com/s/2NvN6q
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
V 1.9.9

Since this is not a bug, closing this in favour of this


fix for non page files in nextjs projects

Includes the change from here to better support helper files that aren't react components

closed given has a cross dependency with another pr, so included there


Relax Arc cfg; remove Send bound from Valid; implement Valid & CanonicalDeserialize for Rc

Description

closes: https://github.com/arkworks-rs/algebra/issues/649
depends on https://github.com/arkworks-rs/std/pull/48

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

So, I think the remaining action item is to remove the patch?

@weikengchen no, quite the opposite. It relies on latest std master

Let me revert my change.

But it looks like ready to merge? I think the changes are easy to follow and seem straightforward.

Yes, it's ready to merge. The dependency PR had already been merged to std


operator: releasing to Operator Hub

Instructions are not quite correct (old release files must not be overwritten) and the script lacks something (obsoletes field).

I think this was fixed.


URL's not rendering

Two URL's are not rendering correctly . I pre-emptively created a PR for this: https://github.com/MicrosoftDocs/azure-docs-pr/pull/53013. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2535ccd-140c-9935-352e-6574208f3c6b
Version Independent ID: 6e0b0906-7100-48ee-5980-9cb1c9ad59cb
Content: Tutorial: Create and manage a Stream Analytics job by using Azure portal
Content Source: articles/stream-analytics/stream-analytics-manage-job.md
Service: stream-analytics
GitHub Login: @sidramadoss
Microsoft Alias: sidram

PS - Think a fix for this got merged in this morning. Might want to double-check and verify.


fix: users shouldn't have to press down arrow twice to select an option

Not the nicest solution, but seems to work.
I tried a few other things, like getting the HTML element and calling .focus() etc, but it seems these the selected state is actually state in the combobox maybe, and you can't set that from outside?
Closes #3787

can we have playwright test? to make sure this doesnt regress?

or tell qawolf just as long as some one has it


Revert "[cxx-interop] Fix two issues with extending nested types across modules."

This reverts commit 6ba7a1ec1ed2665e56bb25c93f41d29c2884b59c.

@swift-ci please smoke test

@zoecarver sorry about reverting this but this commits seems to be breaking our internal adopters. More specifically, exposing all symbols from the bridging header gives us errors of ambiguous types error.


LAMB optimizer

Description
LAMB optimizer - https://arxiv.org/pdf/1904.00962.pdf
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

will add documentation.
@apeforest @eric-haibin-lin

@anirudhacharya Please resolve the conflict.

@anirudhacharya Any update?

sorry for the delay. i was away.
these are the changes i will do to the existing PR -
create multi-tensor kernel that performs the following part of the optimizer.
        grad *= self.rescale_grad
        if self.clip_gradient is not None:
            grad = clip(grad, -self.clip_gradient, self.clip_gradient)

        mean, var = state
        mean[:] = self.beta1 * mean + (1. - self.beta1) * grad
        var[:] = self.beta2 * var + (1. - self.beta2) * mx.nd.square(grad)
        if not self.bias_correction:
            g = mean / (mx.nd.sqrt(var) + self.epsilon) + wd * weight

        else:
            mean_hat = mean / (1. - mx.nd.power(self.beta1, t))
            var_hat = var / (1. - mx.nd.power(self.beta2, t))
            g = mean_hat / mx.nd.sqrt(var_hat + self.epsilon) + wd * weight

then use the existing multi_sum_sq operator to calculate the norms
r1 = weight.norm()
r2 = g.norm()

create another multi-tensor kernel to perform the clipping operation on r1 tensor and calculating the trust ratios.
if not self.bias_correction:
r1 = mx.nd.minimum(mx.nd.maximum(r1, self.lower_bound), self.upper_bound)
# calculate lamb_trust_ratio
r = 1. if r1 == 0. or r2 == 0. else r1 / r2
lr *= r

and finally call the existing multi_sgd_update rule to update the weight matrices.
        # update weight
        weight[:] -= lr * g

related: https://github.com/apache/incubator-mxnet/pull/16122/files


Refactor module tests.

Refactor most of the module tests that follow the old test form of
exporting all tests in an array.
Thanks to sed! ^^
sed -i 's/module\.exports\.tests = \[{/\ntest(/' $1
sed -i 's/, {/\ntest(/' $1
sed -i 's/fixture: /processCss,\n    /' $1
sed -i "1s/.*/import test from 'ava';\nimport processCss from '.\/_processCss';/" $1

sed -i "s/message: //" $1
sed -i 's/expected: //' $1
sed -i 's/options: //' $1

sed -i 's/^}$/);\n/gm' $1
sed -i 's/}];/);/' $1

Coverage remained the same at 100.0% when pulling 1c9468023dccfefa96f1e3690cff58bc1065c5c1 on Siilwyn:refactor-module-tests into 1c6c36cb143e36c3f4634df1075cfbf501cee694 on ben-eb:master.

Wow, awesome work! 👍
I think that the CI is having problems with concurrency now because the number of test files has gone up. Can you try updating the AVA config in package.json to see if this resolves the issue? New config should be:
{
  "ava": {
    "concurrency": 5,
    "require": "babel-core/register"
  }
}

Thanks! :blush:

Coverage remained the same at 100.0% when pulling 50dfbbccfa1dd9599619ac3691e5d3100ee3de20 on Siilwyn:refactor-module-tests into 1c6c36cb143e36c3f4634df1075cfbf501cee694 on ben-eb:master.


Change 'Approve Deliverable' CTA to 'Approve' in the accelerator deliverable view

#2292  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


Fails on github

When you try to delete a repo on github it asks you to type in repo name, but you cannot copy it from text.
So this addon doesn't help there.

You can copy it from here.

This extension is only designed to keep websites from preventing you from pasting text.
This issue is out of scope since GitHub is not preventing you from pasting text. GitHub is preventing you from selecting text. Other extensions like https://addons.mozilla.org/en-US/firefox/addon/enable-copy-by-gary/ can help with that.


VSTest.Console.Exe /Tests: parameter matches substrings

Description
The command-line vstest.console.exe MyTests.dll /Tests:"Add" runs ALL TESTS that contain the word "Add".
Furthermore, given the command-line vstest.console.exe MyTests.dll /Tests:"ns1.ns2.c1.Add", the following tests would match:
ns1.ns2.c1.Add
newns1.ns2.c1.Add
ns1.ns2.c1.AddSomethingElse

Steps to reproduce
Create a suite with the tests Add and AddThisToThat
Run the command-line vstest.console.exe MyTests.dll /Tests:"Add"
Both tests run
Expected behavior
Only the specified test should run
OR
The documentation should clearly state that this is a substring.
There also appears to be no way to force this switch to use literal names, which makes it basically useless if you want to only run specific tests.
Actual behavior
Both tests run
Diagnostic logs
NA
Environment
NA

@evilC This is by design.
@pvlakshm Pratap, we need to change the documentation as suggested.

@evilC Don't know if this will be helpful but you can use:
/TestCaseFilter:"FullyQualifiedName=Namespace.ClassName.MethodName" in case you want to run a specific test.

Yes, I worked that out, I just though that the docs needed updating as it caused us quite some confusion.

This is already done: here

@pvlakshm I don't see it.
The entry for /Tests:[ test name ] is identical to what it was before, nothing has changed.


404

👋 Welcome!
We’re using Discussions as a place to connect with other members of our community. We hope that you:

Ask questions you’re wondering about.
Share ideas.
Engage with other community members.
Welcome others and are open-minded. Remember that this is a community we
build together 💪.

To get started, comment below with an introduction of yourself and tell us about what you do with this community.
Originally posted by @AntonOsika in https://github.com/AntonOsika/gpt-engineer/discussions/98

Tnx


Notification force formatting settings

Describe the bug
Some of us have email clients where we have only 2 options to display the message body: text or HTML. This is particularly the case with the popular emClient email client. The issue is that with changedetection's email notification the message body is rearranged as non-structured text in both notification as text only or HTML.
Unfortunately the email client does not allow any formatting of the email whatsoever, making the tracking of changes impossible in the client.
With the general notification settings:

{{watch_title}} had a change...
{{watch_url}}

{{diff_added}}

one would expect to get the following email notification:

https://changedetection.io/CHANGELOG.txt
had a change...

(added ) HEAD / 2023-06-28 00:03:02 +0200:
(added ) - Fix - Watches werent falling back to global default formats correctly when required (#1656)
(added ) 0.43.1 / 2023-06-27 18:28:18 +0200:
(added ) - 0.43.1
(added ) - Bug fix - Notification settings were not cascading from global -> tags -> watch correctly in some cases (#1654)
(added ) - Bug - Fix watch clone (#1647)
(added ) - UI - Dont allow empty tag names (#1641)

but instead the email looks like this:

https://changedetection.io/CHANGELOG.txt had a change... ____________________________________________ (added ) HEAD / 2023-06-28 00:03:02 +0200: -(added )  Fix - Watches werent falling back to global default formats correctly when required (#1656) (added ) 0.43.1 / 2023-06-27 18:28:18 +0200:  - 0.43.1  (added ) - Bug fix - Notification settings were not cascading from global -> tags -> watch correctly in some cases (#1654)  (added ) - Bug - Fix watch clone (#1647)  (added ) - UI - Dont allow empty tag names (#1641)

You can easily see that without any formatting it is extremely difficult to see the changes, additions...
Version
v0.43.1
To Reproduce
Steps to reproduce the behavior:

Set any Text or HTML notification in changedetection
have the wrong email client

Expected behavior
Would it be please possible to introduce some formatting elements into the notifications? For example, I would really appreciate if the same formatting would show up (with forced left indentation and forced CR LFs) as under the Diff button in changedetection's web frontend.

Just to add, this seems to be something which was introduced only with 0.43.1 this week. Prior to this version a diff rendered correctly, while after it does not. Im using Protonmail via a browser, and that has the same issue.
Before:

After:

Diffs from different watches obviously. Both are Github tag pages, albeit different apps.
Thanks.

Agreed- there is some issue, looking into it

kinda weird thing, when I select HTML I get the two versions (which is correct) but the HTML one has no <br> etc

--===============4993939228724319407==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

fallback-body http://localhost:5005/test-endpoint had a change. --- (change=
d) Which is across multiple lines (into) which has this one new line ---
--===============4993939228724319407==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

fallback-body http://localhost:5005/test-endpoint had a change.
---
(changed) Which is across multiple lines
(into) which has this one new line
---


Scatter in inner_loop

The PR adds another scatter in the inner_loop function.  This gets the SS unit tests passing (the issue being when calling a particular function the global p_scatter was None).
However, this may add an unnecessary scattering of the parameters object.
@talumbau, what do you think?

Codecov Report
Attention: Patch coverage is 90.55118% with 12 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (scatter_once@04e3212). Click here to learn what that means.

Additional details and impacted files

@@               Coverage Diff               @@
##             scatter_once     #916   +/-   ##
===============================================
  Coverage                ?   73.38%
===============================================
  Files                   ?       19
  Lines                   ?     4595
  Branches                ?        0
===============================================
  Hits                    ?     3372
  Misses                  ?     1223
  Partials                ?        0

Flag
Coverage Δ

unittests
73.38% <90.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

ogcore/SS.py
71.72% <100.00%> (ø)

ogcore/output_plots.py
96.51% <100.00%> (ø)

ogcore/output_tables.py
96.81% <100.00%> (ø)

ogcore/parameter_plots.py
82.41% <100.00%> (ø)

ogcore/utils.py
88.47% <78.94%> (ø)


Fix post model deletes tags when editing post only

fixes #6919

adds tests at both the model (using withRelated) and API (using includes) layers
resolves the problem by guarding for tags being undefined:

If it is undefined, we don't do any tag processing
To delete all tags, you would provide tags: []

TODO:

[x] add tests to check correct behaviour of an empty array
[x] check that behaviour is the same if the tags property is set explicitly to undefined, or not provided

Have extended the tests & added handling for the null case. Consider this ready once the build is green 😁


Cannot find module ../AdalConfig

This page contains a reference to adalConfig that is never resolved.
This code:
import adalConfig from '../AdalConfig';
The module AdalConfig has not been defined anywhere in the page. There is an interface defined, IAdalConfig, but no AdalConfig.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fc6b567-0762-fb88-e9f6-11482e81a5b2
Version Independent ID: c64e977e-5adf-e31d-955b-1bafae3e9006
Content: Call the Microsoft Graph API using OAuth from your web part
Content Source: docs/spfx/web-parts/guidance/call-microsoft-graph-from-your-web-part.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Check the note at the top of this doc... it was added after you left this comment. It's much easier and recommended to use the MSGraphClient / AadHttpClient to call the Microsoft Graph / obtain an access token to call the Microsoft Graph.


Translation missing

Written by @xqliu
Created at 2016-02-21T23:15:27.000+0800
Link to http://betterlife.atlassian.net/browse/BE-175

Change all Chinese only strings to translatable.

Written by @xqliu
Created at 2016-02-28T19:15:50.735+0800


option to "win on equal values"

ok I'm pretty sure i know what's up!
node A writes ID 1
node B writes ID 1
node A receives ID 1 from node B -> no rows impacted, declares that changeset as a no-op
node B receives ID 1 from node A -> no rows impacted, declares that changeset as a no-op
node C receives B:1 from node A -> stores it as a no-op
node C receives A:1 from node B -> stores it as a no-op
node C does not know about ID 1, but thinks it knows about all changes

Perhaps a clearer rundown:

node A writes ID 1 -> produces version A:1
node B writes ID 1 -> produces version B:1
node A receives B:1 -> no rows impacted, declares that changeset as a no-op
node B receives A:1 -> no rows impacted, declares that changeset as a no-op
node C receives B:1 from node A -> the changeset it got was empty, this is a no-op and it stores it as such
node C receives A:1 from node B -> the changeset it got was empty, this is a no-op and it stores it as such
node C does not know about the row from A:1 and B:1, but thinks it knows about all changes

And the explained with SQLite...
Node A:
sqlite> create table foo (a integer primary key not null, b integer);
sqlite> select crsql_as_crr('foo');
sqlite> insert into foo values (1, 2);
sqlite> .mode quote
sqlite> select "table", pk, cid, val, col_version, db_version, coalesce(site_id, crsql_site_id()) as site_id, cl, seq from crsql_changes;
'foo',X'010901','b',2,1,1,X'067757d8c09546078d5284126042a0bb',1,0
sqlite> begin;
sqlite> insert into crsql_changes ("table", pk, cid, val, col_version, db_version, site_id, cl, seq) values ('foo',X'010901','b',2,1,1,X'9b0f66ec412b45f38ede4ae4c8103467',1,0);
sqlite> select crsql_rows_impacted();
0

Node B:
sqlite> create table foo (a integer primary key not null, b integer);
sqlite> select crsql_as_crr('foo');
sqlite> insert into foo values (1, 2);
sqlite> .mode quote
sqlite> select "table", pk, cid, val, col_version, db_version, coalesce(site_id, crsql_site_id()) as site_id, cl, seq from crsql_changes;
'foo',X'010901','b',2,1,1,X'9b0f66ec412b45f38ede4ae4c8103467',1,0
sqlite> begin;
sqlite> insert into crsql_changes ("table", pk, cid, val, col_version, db_version, site_id, cl, seq) values ('foo',X'010901','b',2,1,1,X'067757d8c09546078d5284126042a0bb',1,0);
sqlite> select crsql_rows_impacted();
0


"Quick start" installation fails

LTS Haskell 13.8 includes versions of Earley, code-page and containers that are not compatible with morte's dependency requirements. This means that stack install morte fails:
Error: While constructing the build plan, the following exceptions were encountered:

In the dependencies for morte-1.7.1:
    Earley-<IP_ADDRESS> from stack configuration does not match >=<IP_ADDRESS> && <0.13  (latest matching version is <IP_ADDRESS>)
    code-page-0.2 from stack configuration does not match >=0.1.1 && <0.2  (latest matching version is 0.1.3)
    containers-<IP_ADDRESS> from stack configuration does not match >=<IP_ADDRESS> && <0.6  (latest matching version
                       is <IP_ADDRESS>)
needed since morte is a build target.

Some different approaches to resolving this:

  * Set 'allow-newer: true' in /home/tswijk/.stack/config.yaml to ignore all version constraints and build anyway.

  * Consider trying 'stack solver', which uses the cabal-install solver to attempt to find some working build
    configuration. This can be convenient when dealing with many complicated constraint errors, but results may be
    unpredictable.

  * Recommended action: try adding the following to your extra-deps in /home/tswijk/.stack/global-project/stack.yaml:

Earley-<IP_ADDRESS>@sha256:f1c5305adb9665dfa80a138dd8c619760233f03649d698ca5146c559817bca9d
code-page-0.1.3@sha256:9e13dee5c6d23e570f72cb376e7996ffcd9728c4a6daa60f05f2f2c204296eec
containers-<IP_ADDRESS>@sha256:28ad7337057442f75bc689315ab4ec7bdf5e6b2c39668f306672cecd82c02798

Plan construction failed

In addition to the fix you submitted, I also want to note that the successor to morte is dhall so you might want to try seeing if dhall already does what you want since it supports a wider range of compiler versions and installation mechanisms


jest-serializer: Enable fail on CSS change?

I'm on a design system team at Microsoft leveraging Fluent v9. We were exploring using the serializer, but would prefer snapshots still fail if there is a CSS change so we can verify that it was an intended change.
In the serializer README, it states "your rules get included in the snapshot" so we were wondering if we were missing an option, or were misunderstanding the intended outcome of the serializer. If it's not possible to fail on a CSS change, is there another method to have that behavior that you're aware of?

Hello, I work with Stephanie and was wondering if this issue has been triaged yet or if we can provide additional information to help come to a resolution. Thanks!

In the serializer README, it states "your rules get included in the snapshot" so we were wondering if we were missing an option, or were misunderstanding the intended outcome of the serializer. If it's not possible to fail on a CSS change, is there another method to have that behavior that you're aware of?

Hey, it's misunderstanding, let me correct the README file.
The goal of the serializer is to remove classes generated by Griffel, that's it 🐱

If it's not possible to fail on a CSS change, is there another method to have that behavior that you're aware of?

Well, then don't use the serializer and have snapshots with classes, it will fail on changes 😊
However, it's not the best option as class generation is considered as internal API - we can change it in future to get something more effective and accidentally fabc can become fbcd 🥲
Our suggestion as Fluent UI team is to use visual regression tests for CSS related changes due the following reasons:

unit tests don't provide good DX
JSDOM (and other non-browser environments) don't work with CSS well i.e. assertions like .toHaveStyle() are not reliable

We adopted that practice in Fluent UI & recommend it for consumers. We don't plan to add additional functionality to the serializer now.

Thank you for the detailed explanation!


Implementation review : Improvements for group-id interface

This will be kept hold till the first phase of the implementation is done.