Installation instructions

We should include some installations instructions (at the moment how to install the package from Github) both via conda or pip. We should also include description of dependencies and ESMF/xESMF-shenanigans.
cc @angus-g

I tried to create an empty conda env and then do
conda install pip
pip install git+https://github.com/COSIMA/regional-mom6.git

This worked, but then:
$ python3                                                                        [13:42:26]
Python 3.11.4 | packaged by conda-forge | (main, Jun 10 2023, 18:08:41) [Clang 15.0.7 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import regional_mom6
Traceback (most recent call last):
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/xesmf/backend.py", line 22, in <module>
    import esmpy as ESMF
ModuleNotFoundError: No module named 'esmpy'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/regional_mom6/__init__.py", line 6, in <module>
    from .regional_mom6 import *  # noqa
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/regional_mom6/regional_mom6.py", line 8, in <module>
    import xesmf as xe
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/xesmf/__init__.py", line 4, in <module>
    from .frontend import Regridder, SpatialAverager
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/xesmf/frontend.py", line 12, in <module>
    from .backend import Grid, LocStream, Mesh, add_corner, esmf_regrid_build, esmf_regrid_finalize
  File "/Users/navid/Research/test_mom6/env/lib/python3.11/site-packages/xesmf/backend.py", line 24, in <module>
    import ESMF
ModuleNotFoundError: No module named 'ESMF'
>>>

Any ideas? It's related to the ESMF/xesmf shenanigans I guess? Probably because pip doesn't look into the environment.yml for deps, right?

That's correct, you need to install ESMF through Conda/externally, and all the other dependencies are requested by the package itself.

I presume when we push to conda-forge we can do that. But as far I understood by googling you can't install a package directly from Github via conda. So at the moment, we are left with pip install git+... and thus we need to manually install emspy via conda ourselves before that.
That's what I had to do in #58; happy for any suggestions to smooth out that installation workflow!


Update requirements: celery-related & Pillow

Coverage remained the same when pulling b07ac3da51c053eabbf89958e71f533cd2b2db8a on update_reqs_pillow_celery into b9d1ec45d328df56728f284566b735ce71d6d645 on master.


CRT fixes for MM-44210 & MM-44156

Summary
Ticket Link
NONE

@anurag6713 did you test it ?

I have tested and found some flows where it wasn't working. Can you review the changes? @enahum

I have tested and found some flows where it wasn't working. Can you review the changes? @enahum

Reviewed!
Can you please add the description and ticket links, then feel free to merge


Problem with circular dependency when including a Matrix object in the Weighted graph class

I have tried to get around it, but nothing worked.

Resolved in commit


Adding ktor-test-server app for auth poc

This looks great, Zach! I see the unit tests, which look fantastic. However, do you have any postman or any other supporting external test scaffolding you can check in as part of this PR?

Unfortunately no. Most of my testing was manual with Postman and relied on the Keycloak credentials. This PR doesn't have any protected/wrapped routes in it. But when I was testing out the middleware, I wrapped a fake test-route to handle the testing. I took out that test route when I finalized this PR.


add  liveness probe

Fix issue: https://github.com/kubernetes-sigs/descheduler/issues/652
Add liveness probe

/ok-to-test

/retest

/assign @ingvagabund

@JaneLiuL is it possible to update the helm chart while you're at it. if not i can when this merges.

if not i can when this merges.

Sure. so sorry that I forget the helm chart, I will update soon.

/retest

@a7i  @ingvagabund Already fix all comments, would you help to approve and lgtm label?
Thanks a lot.

/approve
/lgtm
@JaneLiuL Thank you for taking the time to add the healthz check!!!
@a7i Many thanks for the review


How to wrap a struct with lifetime parameter?

🐛 Bug Reports
This is different to issue 246.
🌍 Environment

Your operating system and version: 4.15.0-50-generic #54-Ubuntu SMP
Your python version: Python 3.6.8
How did you install python (e.g. apt or pyenv)? Did you use a virtualenv?: Anaconda 64bit
Your rust version (rustc --version): rustc 1.34.0-nightly (e1c6d0057 2019-02-22)
Are you using the latest pyo3 version? Have you tried using latest master (replace version = "0.x.y" with git = "https://github.com/PyO3/pyo3")? version: 0.7.0

💥 Reproducing
When using a struct with lifetime as follow:
use pyo3::prelude::*;

#[pyclass]
struct MyClass<'a> {
    r: &'a u32,
}

results in the compiler error:

error[E0106]: missing lifetime specifier
--> pycore/src/trace.rs:114:8
|
114 | struct MyClass<'a> {
|        ^^^^^^^ expected lifetime parameter
error: aborting due to previous error

Using dependency:
[dependencies]
pyo3 = {version = "0.7.0", features = ["extension-module"]}

It's not allowed now since it's really difficult to handle the lifetime from Python side.

For illustration, the issue is that as a pyclass, the object has to be passed into Python code. For that, it has to be put onto the Python heap, at which point the lifetime is out of control of Rust and the borrow checker.  It can be kept alive potentially indefinitely by Python references.

That said, the error could be a lot clearer :)

That said, the error could be a lot clearer :)

Agreed :+1:

@birkenfeld I thought so already...

PR with better error message has been merged

Is there a workaround for the fundamental issue here? If I need to wrap a struct from a pure-Rust library that uses lifetimes, how do I do that, short of rewriting the pure-Rust library to work within PyO3 limitations? Is there some clever hack/indirection to get around this limitation?

You could only unsafely transmute MyStruct<'a> into MyStruct<'static> and store that inside a #[pyclass]. Of course, it will then be your responsibility to ensure that the correct lifetimes will be applied during usage. (Generally speaking, this seems unlikely to work as the lifetime 'a in MyStruct<'a> suggests that it references data stored elsewhere. This relationship can just not be managed automatically using the Python heap.)


Use enum as permission code

What I'm trying to achieve
Code transparency and type safety.
Describe a proposed solution
Return enum instead of string as permission code.

Blocks #2964

I removed the blocker label - let's implement those changes using strings for permission codes and later we'll refactor them to enums.

Please, how can I locate where the permission codes are?

@the-bionic permissions are obtained via get_permissions() helper function (it only gets the ones we are using)

I'm sorry, I missed this. I picked another ticket. When I finish with that and this is still open, I'll pick it up.

Doing this:
PermissionEnum = graphene.Enum(
    'PermissionEnum', [(str_to_enum(permission.codename), permission.codename)
                       for permission in get_permissions()])

during import time crashes the app when testing.
django-pytest complains because the code is trying to access the database during import time here: get_permissions()
def get_permissions(permissions=None):
    if permissions is None:
        permissions = MODELS_PERMISSIONS
    codenames = [permission.split('.')[1] for permission in permissions]
    return Permission.objects.filter(codename__in=codenames).prefetch_related(
        'content_type').order_by('codename')

What if the MODELS_PERMISSIONS  was used instead?

Why do we need to fetch permissions from the database? We already know which permissions are supported.


Many To Many relations are not allowed between Referenced and Embedded relations

I've a User model embedding "one to many" Watchlists like the following :

class User
  include Mongoid::Document

  field :uid
  field :name

  embeds_many :watchlists
end

class Watchlist
  include Mongoid::Document

  field :html_url
  field :description
  field :created_at, :type => DateTime

  embedded_in :user
  has_and_belongs_to_many :tags
end

The Watchlist should also references a many to many Tag model and vice versa :

class Tag
  include Mongoid::Document
  field :name, type: String

  has_and_belongs_to_many :watchlists
end

but that's causing an error and seems that kind of "mixed" relation is not possible ( but it should from my point of view ):

Mongoid::Errors::MixedRelations (Referencing a(n) Watchlist document from the Tag document via a relational association is not allowed since the Watchlist is embedded.):
  app/controllers/home_controller.rb:53:in `tagging'

Hey mate. It's not possible to reference an embedded document. This is because you'd need to know which document the embedded document is embedded in.


subParam does not work when called on a param that uses template_oid

The child param field cannot be found when attempting to subParam due to the params field not getting copied over since only the value, name and contraint field is currently being taken from template_oid

template_oids are now evaluated for nested params when the param gets built, with deep copies of all the (empty) fields.


Restructuring repo to better handle complex content.

Issue #, if available:
Description of changes:
Completion of restructuring the project space.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yifeim this PR can be closed without merging upon review of https://github.com/aws-samples/amazon-personalize-samples/pull/34 I believe that followed the practices you were looking for.

Closing PR due to a duplication of items in another PR.


Hold notes are way too long

Describe your bug here.
Psych engine build

Non-psych engine build

These notes have the exact same hold times, which are often seem to be longer than they are programmed to be. I chart using an external program, so if these issues do not occur in psych engine's editor, then sorry about that. However, when porting songs from different engines to psych engine, hold notes become a lot longer, meaning you have less time to comfortably switch between notes.
I do not know if this is a visual bug or if it actually requires that the notes be held longer. The fix is to interpret all notes in a chart as being ever-so-slightly shorter than they are.
Example where a problem could rise:

Notice that I have a very small time window between lifting up <- and pressing down.
Command Prompt/Terminal logs (if existing)
-

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No source code changes.

idk exactly how the game puts the sprites, whether it's accurate to the actual length or not, idk. I did actually port some kade charts over to psych and the hold notes we're a little longer than expected. You can probably just go into the editor and easily fix all the elongated hold notes.

That is VERY tedious as you'll have to do that for every note, unless you make an external program that shortens all sustain notes.

either way, I don't think this is a bug, it's just the fact that psych uses a different charting system than whatever you use

No way! DIfferent engines work differently and charts from another engine might not be ported fully properly?? Wow!


version paradox / ux issue w latest

if the manifest doesnt define a version but points to the main branch. and is named latest.
installing a package will show as installed latest version
if there is then a update, the new latest will be different. but since versions are the same. it would think we have the same version installed. and no update is needed
to avoid we can force people to version their packages. but then we loose the flexibility of just clicking install and getting the latest version. ideally we want both.

we could use a tag, unversioned-DD-MM-YYYY and add install date


add bash completion for smt

Especially when default labels are assigned, using smt commands that take labels as positional arguments is onerous.
The argcomplete module seems like it would make this straightforward to add.

Nice idea.

As a more large-scale issue, interfacing subcommand and options with bash completion would be greatly facilitated by migrating all the parsing to a library.
Currently the top-level parsing just uses sys.argv then dispatches to subcommands which each have their own parser constructed with argparse. Although argparse has great aspects, I believe it's a bit tough to build a subcommmand-driven parser with it (thus the current construction I guess).
There are some great-seeming, recently-developed tools capable of implementing a complex CLI like smt. One example is cliff, but click seems more well-supported and documented. (See repo example for a subcommand system.)
Moving to one of these would not only support completion, but could aid long term maintenance and extensibility. For example, at the cost of some UI rigidity, it will make the CLI a little more self-documenting (removing the need for maintaining bin/smt by using entry points and providing top-level options for the smt command. Additionally, click in particular is python 2/3 agnostic so could help ease that transition (though of course the CLI is a very small part of this issue).

+1 for migrating command-line parsing to a more modern library. Can you create a new ticket for this?

Done. And closing this for now. PR #230 is a rough implementation with current codebase. Longer term migration #234 will have to deal with this in context


add database initilization

need to init database for basic info

ref reateDatabaseIfNecessary

we may use https://github.com/AndyBarron/app-dirs-rs

we need to copy the empty database from local db directory to system app data directory and use it there.


Update MLM JSON schema to enforce mlm:input band checks as intended

Description

[!WARNING]
If an existing MLM definition was succeeding with https://github.com/crim-ca/mlm-extension/tree/v1.2.0, it might fail with this revision due to the stricter validation of bands. Older definitions could be considered "incomplete" from the missing "bands" reference if they were not employing other extensions properly (see https://github.com/crim-ca/mlm-extension/tree/fix-comments#bands-and-statistics for details).

Added

Add raster:bands required property name for describing mlm:input bands
(see https://github.com/crim-ca/mlm-extension/tree/fix-comments#bands-and-statistics) for details).
Add README warnings about new extension eo and raster versions.

Changed

Split ModelBands and AnyBandsRef definitions in the JSON schema to allow them to be referenced individually.
Move AnyBandsRef definition explicitly to STAC Item JSON schema, rather than implicitly inferred via mlm:input.
Modified the JSON schema to use a if check of the type (STAC Item or Collection) prior to validating further
properties. This allows some validators (e.g. pystac) to better report the real error that causes the schema
to fail, rather than reporting the first mismatching type case with a poor error description to debug the issue.

Deprecated

n/a

Removed

Removed $comment entries from the JSON schema that are considered as invalid by some parsers.
When mlm:input objects do NOT define band references (i.e.: bands: [] is used), the JSON schema will not
fail if an Asset with the mlm:model role contains a band definition. This is to allow MLM model definitions to
simultaneously use some inputs with bands reference names while others do not.

Fixed

Band checks against eo, raster or STAC Core 1.1 bands when a mlm:input references names in bands are now properly validated.
Fix the examples using raster:bands incorrectly defined in STAC Item properties.
The correct use is for them to be defined under the STAC Asset using the mlm:model role.
Fix the https://github.com/crim-ca/mlm-extension/blob/fix-comments/stac_model/examples.py that incorrectly referenced some bands in its mlm:input definition without providing any definition of those bands. The eo:bands properties have been added to the corresponding model Asset using the pystac.extensions.eo utilities.
Fix various STAC Asset definitions erroneously employing mlm:model role instead of the intended mlm:source_code.

Related Issue

closes https://github.com/crim-ca/mlm-extension/pull/38

Type of Change

[x] :books: Examples, docs, tutorials or dependencies update;
[x] :wrench: Bug fix (non-breaking change which fixes an issue);
[x] :clinking_glasses: Improvement (non-breaking change which improves an existing feature);
[ ] :rocket: New feature (non-breaking change which adds functionality);
[x] :boom: Breaking change (fix or feature that would cause existing functionality to change);
[ ] :closed_lock_with_key: Security fix.

Checklist

[x] I've read the CONTRIBUTING.md guide;
[x] I've updated the code style using make check;
[ ] I've written tests for all new methods and classes that I created;
[ ] I've written the docstring in Google format for all the methods and classes that I used.

@rbavery FYI
I'm still working on this...
I've realized that by enabling the following:
https://github.com/crim-ca/mlm-extension/blob/5212acfbde02f22a651b6922321b9f7d7eaa3806/json-schema/schema.json#L53-L56
... many of the "band" checks across EO/Raster/STAC-core were actually incorrect, as well as some of the provided examples.
For example, https://github.com/crim-ca/mlm-extension/blob/6338f4d25867222509efe06807b2094eb2725f8b/examples/item_raster_bands.json#L208 uses raster:bands at the Item properties level, when they MUST be under an Asset according to raster extension.
Similarly, https://github.com/crim-ca/mlm-extension/blob/v1.2.0/stac_model/examples.py defined mlm:input with some bands, but they were never actually validated correctly. I've added the https://github.com/stac-utils/pystac/blob/main/pystac/extensions/eo.py extension wrapper to it, to maek it work correctly with band checks.

@rbavery
Forgot to ping you again. The PR is ready now.
Let me know if it works with your examples whenever you have some time.

Merging and will pin as v1.3.0 to avoid dealing with the integration before move to https://github.com/stac-extensions/mlm.
If anything doesn't work, a v1.3.1 could be considered, or users can refer to the v1.2.0 in the meantime.


no translation on iOS context menu

when selecting files or image to upload it shows always english language
"Photo Library"
"Choose Files"
even when iOS system is set to spanish language or any other language

Well, hello at first. 👋
These button labels are part of the native OS behavior and are out of scope of this library. We do not set them manually anywhere in our code. You might want to play around with your Browser's language or the <html lang="es"> tag.

thanks


[MM-19490][MM-20039] Refactor Complex Display Logic

Summary
Refactors the display logic in components/channel_members_dropdown/channel_members_dropdown.jsx. As part of the refactoring, I also noticed MM-20039 bug which is addressed within the same PR (Line 73 and 83 in components/channel_members_dropdown/channel_members_dropdown.jsx address the bug).
Ticket Link
https://mattermost.atlassian.net/browse/MM-19490
Also addresses https://mattermost.atlassian.net/browse/MM-20039 bug

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4188.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Hi @hahmadia
I tested and found the following issue. Can you please check:

If a regular member (with CHANNEL_MEMBER permissions) is promoted as System Admin, then the option to Manage Members do not appear in the dialog. The user needs to reload the screen for the changes to be applied.

Upon further investigation, it seems this is unrelated to my changes and is a bug currently on master. A separate ticket should be made for this.

This issue has been raised separately and will be tracked.
https://mattermost.atlassian.net/browse/MM-20164

Test server destroyed

Removing myself from the reviewers as there's already 2 devs on there.


Wrong version on the Ruby repository

First I have to say that this tool is absolutely awesome to extract bib data. So much time saved with just one command line, many many thanks!
However I had to build the gem myself to have the 0.1.1 version. The one in the repository seems to be outdated, without extract-bib etc... even though the version of the package indicate 0.1.1
Just wanted to point that out.
Thanks again.

@Xealog Can you include instructions on how to build the gem? I'm a newcomer to ruby and I'm not sure what it entails. Thanks

Any news on this? Same here, am a newcomer to Ruby it would be really helpful that such features were in the Gem itself, plus allowing to easily replicate setups between different machines.

Take it easy, just build it for yourself : )
git clone https://github.com/CrossRef/pdfextract
cd pdfextract
gem build pdf-extract.gemspec
gem install pdf-extract-0.1.1.gem
And you may check #20

@AnikoG Sure, but I want to plug it to another library I am writing, written in Python. As most of my users will be Pythonistas, and not people from the Ruby side, it would be really nice if installing it could be as easy as gem install pdf-extract, without issues such as this one or #20 =(


Feature - Created a Profile page

Changes that I made are:

Created a profile page for app.

Checklist

[x] My code follows the code style of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.
[x] The title of my pull request is a short description of the requested changes.

Merging PR #5


Pass -q to git reset --hard

Will suppress the many lines of "Checking out files" - errors will still be displayed.

I think it's actually coming from the pull: see #238.

fixed by #238

I don't know if it will still matter, but git reset will also display that if the working tree is hugely different
dra27@summer:~/opam-repository$ rm -rf packages && git reset --hard upstream/master
Checking out files: 100% (17364/17364), done.
HEAD is now at 698815dce8 Merge pull request #16998 from hhugo/jsoo-menhir


Capability to parse in json a model with custom activation functions

First of all, Awesome project,
Does anyone know how we can save a model using a custom activation function.
For example, I'm doing the next:
def swish(x):
    return (K.sigmoid(x) * x)

get_custom_objects().update({'swish': Activation(swish )})

then we are able to use a custom activation function but when I'm trying to parse a model using this custom function in json (model.to_json())
I got the following:
AttributeError: 'Activation' object has no attribute '__name__'`

Any idea to proceed?
Thanks!!

get_custom_objects().update({'swish': swish}) is the way to go. Activations used as the activation argument of a layer should be plain functions, not layers.


LogNorm colormap doesn't work correctly

Using the LogNorm colormap argument in, e.g., pcolormesh doesn't work correctly in proplot.
Data link: http://s000.tinyupload.com/index.php?file_id=02946064711977690771
With matplotlib:
import matplotlib.pyplot as plt
import cartopy.crs as ccrs
import matplotlib.colors as colors

ds = xr.open_dataset('chl_cal.nc')

f, ax = plt.subplots(subplot_kw=dict(projection=ccrs.PlateCarree()))
p = ax.pcolormesh(ds.lon, ds.lat, ds, norm=colors.LogNorm(vmin=ds.min(), vmax=ds.max()))
plt.colorbar(p)

With proplot:
f, ax = plot.subplots(proj='pcarree', tight=False, axwidth=6, colorbar='r')
p = ax.pcolormesh(ds.lon, ds.lat, ds.values, norm=colors.LogNorm(vmin=ds.min(), vmax=ds.max()))
ax.set_extent([-140, -105, 20, 50])
f.rightpanel.colorbar(p)

Here's a workaround, but I think using LogNorm is preferred so it handles the labeling and all that for you. Now this is of course in actual log10 units.
# Just log-transform before
ds = np.log10(ds)
f, ax = plot.subplots(proj='pcarree', tight=False, axwidth=6, colorbar='r')
p = ax.pcolormesh(ds.lon, ds.lat, ds.values,)
ax.set_extent([-140, -105, 20, 50])
f.rightpanel.colorbar(p)

Thanks for posting this, it triggered a much-needed cleanup of cmap_wrapper (commit 42ec0be). Details are in the cmap_wrapper documentation. Try this new example:
import proplot as plot
import xarray as xr
import numpy as np
%matplotlib inline
ds = xr.open_dataarray('/Users/ldavis/tmp/chl_cal.nc')
f, ax = plot.subplots(proj='pcarree', tight=False, axwidth=6, colorbar='r')
p = ax.pcolormesh(ds.lon, ds.lat, ds.values, norm='log', levels=15)
# p = ax.contourf(ds.lon, ds.lat, ds.values, norm='log', levels=15) # also works!
ax.set_extent([-140, -105, 20, 50])
f.rightpanel.colorbar(p)

Now the pcolor level selection behavior is like the matplotlib contourf selection behavior -- boundaries are "nice" by default (uses matplotlib.ticker.MaxNLocator). And now you can have nicely-spaced levels in plots with logarithmically-scaled colormaps, which was always really tricky to do in matplotlib. Note that setting vmin and vmax to the data minimum and maximum isn't really necessary.
By the way it looks like you still have that issue with thin fonts? If you run
rm ~/anaconda3/lib/python3.6/site-packages/matplotlib/mpl-data/fonts/ttf/Helvetica*

and restart IPython it should fix the issue. Font control in matplotlib is really tricky, for now I have to add font files directly to the matplotlib data folder but am considering changing this.
Also keep in mind one of the big things with ProPlot is you no longer have to refer to these verbose class names (e.g. matplotlib.colors.LogNorm) -- everything is registered just like axis scale names or basemap projection names, including colormap Normalizers, Locators, Formatters, and cartopy projections. This is less verbose, fewer import statements, etc. This point is now emphasized in the README.
And now I'm going to sleep.

This is awesome, thanks @lukelbd. Resulting plot from this update is going on my poster I'm working on. Thanks also for the cmap_wrapper documentation. I didn't realize I could just pass arguments directly from there into pcolor, etc.


CRUD : Adding Multiple Child Records (1-n relationships) on related CRUD form?

Hey,
If you feel this is too redundant or not the place to pose this question, feel free to blast this post away. @tabacitu is usually super-tuned in to these posts. I have searched through the tickets and Google, but I'm not sure I am asking the question the right way... or if there is even an answer out there...
I am running into situations where I have a Model that I would like to add multiple related (child) records too, using just one CRUD form. Some examples would include adding multiple files... but let's start small. I have found the following posts that have similar topics, but not clear answer on the best way to do this.

#463
#132
#427

Is the best way to use the table Field Type? https://laravel-backpack.readme.io/docs/crud-fields#section-table But, I guess the drawback is not having validation on the child records?
A similar tutorial to this one would be cool: https://backpackforlaravel.com/articles/tutorials/nested-resources-in-backpack-crud
So, an example would be where I have a Journey model and would like to add multiple Chapters to the Journey directly on the same Journey CRUD form.
Let me know if this question makes sense... and any suggestions/advice you can share.
Thanks,
JFK

Sorry... I realized this isn't a bug and should be posted via another channel:
http://stackoverflow.com/questions/43723259/crud-adding-multiple-child-records-1-n-relationships-on-related-crud-form
Closing this "Issue".

@BinaryBlock Hey man I'm facing through the same question is there any advice that you can give me ? did you had luck on this?

@edgcarmu So... sorry. I didn't have any luck. The creator suggested the following on Stackoverflow:

My recommendation would be to edit the EntityCrudController::store() and EntityCrudController::update() methods, to check for the values of the "table" field and add/update/remove connected entries.

I ended up splitting out the relationships to other forms and the user would have to select which parent relationship they wanted to create a new child from. 😢
I believe there are other Laravel Admin systems that can handle (n-1 relationships) on the same CRUD form, but I have not used them. One example is Laravel Voyager
Hope that helps.

Update: We still don't have a built-in solution for this.
But a possible solution would be to have a 1-n field that allows you to add items (plus button that opens a modal with a form for the child record, hit save and it would be added to the db and selected in the select). It's mentioned elsewhere in our Github as "adding items on the fly".
This third-party package had a solution for Backpack v3, but for Backpack v4 we're working on a first-party solution. I'll try to update this thread as we work towards a complete solution for Backpack v4.
Sorry for the bad news.

I think many of us would like to have this :smile:

@aula2030 I have good news for you then 😄 We have it now 🥳

When inside a create/update form, you can add related entities in a modal. We call the operation InlineCreate, check out the release notes here for a quick look https://backpackforlaravel.com/docs/4.1/release-notes#new-operation-inlinecreate
Then:

InlineCreate docs here
relationship field docs here (the field that uses the InlineCreate operation)

:smile: Oh, yes, I've seen that! After seeing your last comment I thought it was not complete (I'm using 4.1.16) :sweat_smile:
Sorry, I was thinking ahead and focusing on my problem.... I see now that the issue says "Adding child records", so you are right!! :+1:
But let me explain the situation (maybe I should open a new issue?):
In my test: I have Projects and Tasks (hasMany). When editing a project I have a relationship field with tasks. It retrieves the tasks list correctly. I can add a new task through the modal (the project is not assigned directly to the current one although I understand that it is something I must do), but the problem comes when, for any reason, I want to delete one task from the current project. This cannot be done. When you click on the cross, option disappears from list but obviously task FK to project in the DB is not updated (after saving)...

So I hoped, expected, wanted a way to "Delete child records" in a hasMany relationship. :sweat_smile: (similar to the behaviour of the table field). Maybe for the future.....?
Anyway, thanks for the great job!

@aula2030 that's odd. This field should definitely do both:

add the relationships in the pivot table
remove the relationships from the picot table

Yes, please open a differrent issue with your addField code and relationship definition in the models. It should be doing all that for you.

Hi @tabacitu! In this case it's not a pivot table. Projects and tasks have a 1:n relationship: 1 project - n tasks. So Tasks has a FK to Projects and when I delete a task from list in one project, it doesn't update the task record in the BD setting the FK to project to null (BD allows that).

@aula2030 I'v just submited a PR that I think addresses your issue. #3196
If you don't mind give it a go a test it out, give us your feedback in the PR thread, it will help us alot and speedup the merging process.
Wish you the best,
Pedro

@pxpm of course! My pleasure! This afternoon I'll check it :+1:


added zigcc

@dom96 Should a single command (discard execShellCmd "zig cc " & commandLineParams().join(" ")) be a nimble package?

I don't see why not. In this case it makes using zig cc with Nim much easier.


Cpp appear two times!?

Why are there two c++ sections under Languages Used in main Readme.md file?

Donno but easy fix!

Exactly, waiting for someone to fix it.

Can I do that?

Yes.

Can I do that?


ISLE: split algebraic.isle into several files

Split algebraic.isle into several files, grouping similar operators together.

It's definitely a good idea to split up these rules, and I like the division you've chosen between operations. But I think you probably intended to delete cranelift/filetests/filetests/egraph/algebraic.clif too, right?

It's definitely a good idea to split up these rules, and I like the division you've chosen between operations. But I think you probably intended to delete cranelift/filetests/filetests/egraph/algebraic.clif too, right?

Yes, that should have been removed

I see that algebraic.clif is still not deleted though, and I've made one other request below. Could you take care of those? I'd be happy to merge this on Monday.

I have deleted algebraic.clif several times now, very confused


Set custom current date for MudDatePicker

Feature request type
Enhance component
Component name
MudDatePicker
Is your feature request related to a problem?
Our application functionality is strongly dependent on current date (and time of day). Because of this we use a custom DateTime provider, which sets an arbitrary "current" date and time throughout the application. We use this for development, automated testing and presentations. We pretty much only use real time in production and for UAT. The whole project is implemented this way, except for date pickers. It's currently impossible to do this with the MudDatePicker, as it currently uses DateTime.Today to determine the current date.
Describe the solution you'd like
It should be possible to inject a custom DateTime provider, that would allow users to set a different "current" date on the component.
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi. I would suggest you to PR this feature if it's important for you.

I would like to work on this if no one else has taken it yet

I would like to work on this if no one else has taken it yet

sure

Do I understand correctly that we are talking about the TimeProvider? Should be possible now when we dropped the .net7

@TheGreenAirplane TimeProvider was added in v8,
Example how can you mock the current date using Microsoft.Extensions.TimeProvider.Testing
[Test]
public void DatePicker_CustomeTimerProviderTest()
{
	var timeProvider = new FakeTimeProvider();
	Context.Services.AddSingleton<TimeProvider>(timeProvider);
	timeProvider.SetUtcNow(new DateTime(2003, 4, 4, 0, 0, 0, DateTimeKind.Utc));
	var comp = Context.RenderComponent<DatePickerCustomDateTest>();
	// click to open menu
	comp.Find("input").Click();
	comp.FindAll("div.mud-picker-open").Count.Should().Be(1);
	comp.Find(".mud-button-outlined").InnerHtml.Should().Contain("4");
	comp.Find(".mud-button-month").InnerHtml.Should().Contain("April");
	comp.Find(".mud-button-year").InnerHtml.Should().Contain("2003");
}


TypeScript language server exited with error

Type: Bug
I have no idea how to reproduce this, but it's getting really annoying... It keeps crashing like every few minutes for no reason at all.
TypeScript language server exited with error. Error message is: write EPIPE.
Source: TypeScript and JavaScript Language Features
also gives me The JS/TS language service crashed.
Source: TypeScript and JavaScript Language Features
VS Code version: Code - Insiders 1.88.0-insider (9ccb0fa738a2f7a1c5328800c9fe18f4dd5b4f8a, 2024-03-18T05:49:11.301Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 5.4.0-173-generic

System Info

Item
Value

CPUs
AMD Ryzen 5 3600X 6-Core Processor              (12 x 3800)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.91GB (9.02GB free)

Process Argv
--crash-reporter-id 6e60ae21-3bbe-4909-8cb6-1a9f457f94c2

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: <IP_ADDRESS>

OS
Linux x64 5.4.0-173-generic

CPUs
Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (1 x 2499)

Memory (System)
0.94GB (0.15GB free)

VM
100%

Extensions (13)

Extension
Author (truncated)
Version

es7-react-js-snippets
dsz
4.4.3

auto-rename-tag
for
0.1.10

discord-vscode
icr
5.8.0

remote-ssh
ms-
0.109.0

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.3

material-icon-theme
PKi
4.34.0

errorlens
use
3.16.0

npm-intellisense
chr
1.4.5

path-intellisense
chr
2.8.5

vscode-eslint
dba
2.4.4

prettier-vscode
esb
10.1.0

indent-rainbow
ode
8.3.1

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
vsaa593cf:30376535
py29gd2263:30784851
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
h48ei257:30986171
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
d6fi2104:30968146
pydisww1:30991133
cppperfnew:30980852
8082a590:30961435
fegfb526:30952798
bg6jg535:30979844
ccp2r3:30958153
pythonait:30973460
7ghi1836:30988844

Please try collecting the TS Server log from the crashed instance:

Set "typescript.tsserver.log": "verbose"

Restart VS Code and reproduce the problem

Open the TypeScript section of the output panel

At the very top, find the first line that prints to path to the semantic error log file. It should look something like:
[Info  - 19:54:59.247] <semantic> Log file: /Users/matb/Library/Application Support/Code - Insiders/logs/20200213T104930/exthost55/vscode.typescript-language-features/tsserver-log-ZT2zau/tsserver.log

That file contains the typescript logs.

Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

Open the TypeScript section of the output panel

After following step 1 and 2, I can't seem to find the TypeScript section in the output panel

It seems I just had to wait a little, the TypeScript option appeared after scrolling through about 50 times and restarting a few times.
Now I don't really see any error or I might just be blind... Can I just send you the file?

Same thing happening to me again and again...any solution??

@CuteNikki Do you see a dropdown link this on the right side of output?

@CuteNikki Do you see a dropdown link this on the right side of output?

Yeah, as I said, I found it. It just took me a while because it didn't show up.
I don't see anything in the log though. Can I send the file to someone to take a look at it?

@mjbvz
Just started coding some more and the server immediately crashed with this error:

Now I did check the log right below the error and it ends at 21:20:08 but the error happened at 21:20:09!
The next log starts at 21:20:10, completely skipping the error...
So I don't really know what to do at this point.
This time it said "SIGKILL" but most of the time it says "write EPIPE"
I can wait for that to happen and then check the logs again.

Just as a follow up, while writing that comment, the TS Server crashed 4 more times with the same error, not leaving a log again.

I have noticed that I also get the error "SIGTERM"...
So now we got "write EPIPE", "SIGTERM" and "SIGKILL"

I'm seeing the SIGTERM also. I added "typescript.tsserver.log": "verbose", and now I'm seeing what I think @CuteNikki saw where Typescript is not showing in the Output dropdown.

Also, the Command Palette (cmd+shift+p) also doesn't show any typescript related commands (e.g. Restart Typescript Server).
The issue I was originally researching was that my Quick Fixes (blue lightbulb) were gone, I'm assuming this is why.
Here are some other deets:
Version: 1.89.0
Commit: b58957e67ee1e712cebf466b995adf4c5307b2bd
Date: 2024-05-01T02:10:13.496Z (1 day ago)
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

I'm going to try the preview build and see if it works there when I get a chance.
Thanks!

Hi @liquidg3 , did you fix the problem? On my side it also happened. Tried reinstalling vscode and downgrading vscode, typeScript version. It looks like the typescript language service could not be loaded.

Hey @mjbvz, this issue might need further attention.
@CuteNikki, you can help us out by closing this issue if the problem no longer exists, or adding more information.

I haven't had this issue recently. But I believe it only happened when I was connected via ssh to a remote server which I also haven't done since then. I could be wrong and this also happened locally but I'm unsure about that. It has been a while since I opened this issue.


Create tox configuration to handle testing multiple Python environments

We should use tox to test in multiple Python environments. Travis should just call into tox.

Fixed in #282


FINERACT-1971: Delinquency evaluation should be happen only for Active Loans

Description
Delinquency evaluation should be happen only for Active Loans
FINERACT-1971

Approve Loan (Delinquent data in zeros)

Active Loan

Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

LGTM But please dont forget to cover with test! Also the PR title and commit message does not fit for the requirements: FINERACT-XXXX:

@adamsaghy Done! The PR has been updated according the latest comments. Thanks!


docs/user-guide: update "not found in pkgs" FAQ

Follow up to https://github.com/nix-community/nixvim/pull/2150, https://github.com/nix-community/nixvim/pull/2160, and https://github.com/nix-community/nixvim/pull/2139.
Since starting to use lib.mkPackageOption throughout nixvim, users will see a slightly different error message when encountering mismatched nixpkgs channel errors.
Also fleshed out some recommendations.
The example error message is taken from this build from a PR that uses a package not yet in our locked nixpkgs revision.

@mergifyio queue


Fix reporting ES pod disk free

… stats

The current script iterates through each word (from split()) that came back from "df"; if it finds "/elasticsearch/persistent" then it backs up 2 words and returns the value there. I don't like this pattern and am rewriting it.


Support for avatars/attachments when possible

Matterbridge currently offers the best existing way of creating guest users/publishing a channel. To do this one just needs to create two teams, internal and visitors on the same server. Then creating private or public channels in visitors team and linking them via matterbridge to corresponding channels in the internal team offers a decent realization of one of the most popular requested [features]((https://mattermost.uservoice.com/forums/306457-general/suggestions/9982719-add-restricted-users). As of now, on the mattermost side the planned implementation of the feature is partial (right now only single-channel guest users are planned), and only intended for the E10-edition: https://mattermost.atlassian.net/browse/PLT-3636
Therefore improving matterbridge support for single-server bridges would be very useful. As far as I can tell, there are several things that are currently not handled by matterbridge, and that would be nice to handle:

Modifying the avatars on message
Handling file attachments
¿custom emoji?
Is there anything else?

At the moment the bridge are very generic, to do what you propose I'll need to add some kind of capability system to know what every bridge can support (beside just text).
Not committing to this, but I'll think about it.
File attachments are handled already btw, in the way that a download URL is posted.

BTW just verified that something goes wrong with attachments:
This is what I get with click + copy public link:
https://our.mattermost.server/api/v3/public/files/get/nh5rs8bpitrxtdr5juit3tdz4r/psbs9a5kmfga5biiho41eer5jy/hbwgxekk8inktn3beng4ewjr8r/oqtntdukobgo9fiwjda9syu8jr/Image Pasted at 2016-10-18 23-53.png?h=N4huqINVMkUc4BdL2ytW6R5-UHFd8qjZ68A9TC_QnFs
and this is what matterbridge wrote:
https://our.mattermost.server/api/v3/public/files/get/nh5rs8bpitrxtdr5juit3tdz4r/psbs9a5kmfga5biiho41eer5jy/hbwgxekk8inktn3beng4ewjr8r/oqtntdukobgo9fiwjda9syu8jr/Image%20Pasted%20at%202016-10-18%2023-53.png?h=kJm5rYTmtNz_t6qbsDw6q5C8jRbCyBboDLAtj1oCuIw
and it results in {"id":"api.file.get_file.public_invalid.app_error","message":"The public link does not appear to be valid","detailed_error":"","request_id":"bj5jdogatiytzdo1wujzohuq8h","status_code":400}

I can not reproduce this, works fine for me

Could it be a bug with mattermost lingering after several subsequent upgrades?

About the additional things that may be worth including in the bridge similarly to avatars:

message editing (supported at least by slack, mattermost, and gitter).
message responses (specific to mattermost I believe)

Message editing (and responses) should now be working.
They are sent as a normal message so every protocol is supported


New Metrics

New Metrics:
Activity Metrics
issues_with_close(self, owner, repo=None):
 issue_response_time(self, owner, repo=None):
pull_acceptance_rate(self, owner, repo=None):

pull_acceptance_rate is done
issues_with_close is done
issue_response_time : Query performance issue, @sgoggins is working this.

This will make query response time super fast, and it also delivers additional data for no additional cost ... it can be part of an "issue response service call" @howderek  & @ccarterlandis
Query Delivers:
1. Time to first comment on an issue
2. Time of most recent comment on an issue
3. Total comments on an issue
4. Fields are issueid, repoid, issue created at, first comment, last comment, total comments by issue
SELECT
issues.id AS "issue_id" ,
issues.repo_id,
issues.created_at as "issue_create_timestamp",
TIMESTAMPDIFF(MINUTE,issues.created_at,MIN( issue_comments.created_at )) as "first_comment",
TIMESTAMPDIFF(MINUTE,issues.created_at,MAX( issue_comments.created_at )) as "most_recent_comment",
count(*) as "total_issue_comments"
FROM
issues
JOIN issue_comments ON issue_comments.issue_id = issues.id
WHERE
issues.repo_id = 1334
GROUP BY
issues.repo_id,
issues.id,
issues.created_at

Backend is finished. @ccarterlandis  is working on a stacked bar chart visualization that will be a stacked bar chart that distinguishes between open, closed and reopened issues.


PY 24/25 Award Configuration Updates - FT

Description of Task
Adjust award configuration calculations to reflect policy changes to become effective for PY 24/25
Placeholder Tasks, to be completed with details later:

[ ] Full-time Canada Student Grants (CSG-FT) will be capped at the federal assessed need
[ ] Amounts for all canada student grant types will be increased by 40% above pre-pandemic level
[ ] A stacking order will be implemented for CSG-FT
[ ] The existing stacking order for CSG-PT will be ammended
[ ] CSG for Services and Equipment will be disbursed via eCert file (instead of external to SIMS as is currently the case)
[ ] BC lifetime maximum amount may be increased
[ ] Federal weekly loan limit will be increased from $210 to $300
[ ] Update all needs assessment tables
[ ] Expand size and eligibility criteria for BCAG

@CarlyCotton just cleaning shop a bit - can you confirm that this is obsolete? This was very early placeholder, which I believe is now more comprehensively handled as part of the BRRRRRRRRRK outcomes.
Can we close?

@HRAGANBC  I think we can keep this as it's work that still needs to be done. I wasn't able to find a BRRK outcomes ticket so I'd prefer to have this around while those get confirmed.


Ord implementation now covered by macro

Unifies impl Ord for various types.
Also upgrades from PartialOrd to Ord, since Godot defines total order on these types.

bors r+


Simple table support

Discuss in #public-issue-16--simple-table-support
https://developers.notion.com/changelog/simple-table-support
This means that the unsupported change can be fixed!  I'll see if I can get it done some time this week unless it is already being worked on.

This would be great to have, thanks!


[Bug] [A11Y] Low text and icon contrast: orange on grey

Related issue
https://github.com/Orange-OpenSource/ods-ios/issues/563
A11Y team contact
@pya35

light gray background has been replaced by white, can be closed


flutter format should support --line-length parameter

dartfmt supports it, flutter format should pass-through the value (if set).

fyi, i just thought about reopening this PR, just to discover it was already merged in another PR https://github.com/flutter/flutter/pull/36679 🎉


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit 2394b37:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add options to the run options editor for overriding schemas

This depends on dataform-co/dataform#98
We should add two settings to the run options component that allow overriding the dataformSchema and assertionSchema properties of the RunOptions proto message, once they are implemented in the above issue.
By default, for a branch named my_branch - with a project level default dataformSchema value (as defined in dataform.json) of dataform - we should set the override value in any user triggered runs to be dataform_my_branch.
This should work similarly for the assertionSchema value.
Runs triggered from the production branch should use the default schema value as is, without any suffix.

Done in #232.


Adding support to remote/network devices on fpicker

In order to fuzz on a remote device (running 'frida-server') I added support using the Frida core options.
Added details to README.
I just noticed some additional 'diff', because my editor is removing trailing white spaces from edited files.

I also fixed build issues for Linux.

Hey, thanks for your contribution! That looks really nice.

I just noticed some additional 'diff', because my editor is removing trailing white spaces from edited files.

Ouch, thanks for catching that! Not sure how these got added...

I also fixed build issues for Linux.

Hmm, the reason I had the differentiation between the -linux, -ios, and -macos headers and libs is that I often build the fuzzer out of the same directory for the different platforms. It's not really an elegant solution but it at least keeps me from having to copy and paste the different architecture libs into the directory, so I reverted that back.

Understood, I'll keep the Linux changes to myself.
BTW, thanks for the tool. It's working great.


Submitting exercise 06

Submitting exercise05

Well done. You used pandas methods very effectively to write succinct functions.


ARTEMIS-1872 Check for queue exists before creating shared queue

Add tests case to verify issue and fix, tests also tests for same behavior using CORE, OPENWIRE and AMQP JMS Clients.
Update Core Client to check for queue before creating, sharedQueue as per createQueue logic.
Update ServerSessionPacketHandler to handle packets from old clients to perform to implement the same fix server side for older clients.
Correct AMQP protocol so correct error code is returned on security exception so that amqp jms can correctly throw JMSsecurityException
Correct AMQP protocol to check for queue exists before create
Correct OpenWire protocol to check for address exists before create

See for full description of the problem, or see test case.
https://issues.apache.org/jira/browse/ARTEMIS-1872

@andytaylor

Wouldn’t this make a blocker for 2.6.0? Or this is not that critical ?
I’m reading on the iPhone with limited visibility of the changes. But it seems to warrant a -1 on the current release vote.
Let me know please.

Can you bring this up on the voting thread?

@michaelandrepearce it looks fine to me: probably I would have performed the check about the queue existence just for the durable ones

@franz1981 non durable also needs it.

I'm running the testsuite first before merging this...

These following tests are failing:
Test Result (14 failures / +14)
org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryQueueNotAuthorized
org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryTopicNotAuthorized
org.apache.activemq.artemis.tests.integration.jms.consumer.JmsConsumerTest.testValidateExceptionsThroughSharedConsumers
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelector
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelector
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentTopic
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorSrcFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorSrcFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorTargetFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorTargetFilterNull
These tests also failed when I ran but they are probably part of the intermittent failures:
org.apache.activemq.artemis.protocol.amqp.util.CreditsSemaphoreTest.testDownAndUp
org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testFailThenReceiveMoreMessagesAfterFailover2
org.apache.activemq.artemis.tests.integration.cluster.reattach.MultiThreadRandomReattachTest.testD
org.apache.activemq.artemis.tests.integration.cluster.reattach.NettyMultiThreadRandomReattachTest.testE
(Although I believe CreditsSemaphoreTest failed because of these changes.. I'm not 100% sure)

CreditsSemaphoreTest passed under same github commit on another box where I ran.. so non related... but the Sharedconsumer ones and the queue related seem broken by this change.

Ill have a look i think i know what it is (need to add filter check at same point as exists check and should be super simple.

Should be sorted now.
Added checks for address and filterstring at along side checking the queue exists.
Ive run locally SharedConsumerTest you mentioned and with this it now passes.

This looks good to me. @clebertsuconic, what do you think?

@michaelandrepearce Maybe I'm being slow.. but why do you need to check for version here?
shouldn't this be a simple fix on checking the address before?
from what I udnerstood from the fix is that you always remove the queue when creating a shared subscription?

that would mean older clients will still hit the bug if you keep the version check

compatibility tests are passing with this.. do you know any cases where this would brea compatibility and the current tests have missed it? if that's the case we need to add a test on the compatibility...

the more I digg.. the more I'm convinced there's no need for the version check... if we can speak on IRC before we merge this?
The version check was basically for wire compatibility... for semantic you just change the server... there's no wire changes here. .just keep it this way?
and if this is breaking the client->server contract in a way it needs a raise to the properties. .this would bump the release into 2.7.0...
We can't make changes to versioning on point releases... if later on we need to make any other changes into 2.7.0... it will be some extra complexity on bumping the release there again.
It seems we can simplify this a lot?

Ill close this if you merge yours, im happy with yours.

I am merging your changes.. however I'm reverting the portion of the version properties check. we may revisit this later if you see any other issues.
To make eventual cherry-picking into 2.6.1 easier.. I'm making this a single commit.


Better vision augmentations

Resolves issue #32.

Tests will fail until DataAugmentation.jl#39 is released.


Image not loading onClick when searching #61

Now the search button is working fine.

Kindly resolve conflicts before continuing

Rest looks good

Pull data before making changes, project structure has changed!

Can you please tell me again what should i do? i don't get your point ;(

Actually the resolve conflict button isn't clickable ;(

Can you please tell me again what should i do? i don't get your point ;(

Like the project has merge conflicts that need to be solved.
And the commit hooks are not working

Is the PR close? should i make a new PR?


Option to make pip window unclickable/uninteractable

Sometimes it would be convenient if clicking into the pip window would be ignored.

This would be a very good feature for watching videos while playing games.

It would be nice if we added such a feature.

Is there any way to do this at the moment? It would be a nice feature to have

Yeah, PiP lock would a nice feature. No one has at the moment, at least i don't know any app that has this feature


Enhance download method

use generator instead of list
don't wait for all threads to complete to start another urls.txt
decrease thread count from 300 to 100 to prevent being killed for using up all memories

Sorry, sent the request to the wrong branch


Update to v2.18.8

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


new pypi release?

Hello,
I noticed that there have been several updates that are quite usefull like direct copy. Is it possible that you give us new version on pypi?
Best regards 😃

Disclaimer: I am not the author nor a maintainer.
Notice in the README under Setup > 5. Install from PyPI it is mentioned that "Legacy. Due to the quick turnaround time for bug ad feature fixes, this is deprecated." Some alternatives are mentioned there. Good luck :)


optimization going slowly

I am currently running a big optimization and suggesting new locations starts to get slower.
The problem I am working on has about 20 dimensions to optimize and I was  hoping I could use gpyopt to find a good set of hyperparameters.
There are currently 3000 datapoints and the function suggest_next_location is starting to take a long time.
Is there any way to make the process faster (feed in new locations but not create a whole new model each time) or use all cpu cores (all 16 not only 8)?
I am using an external objective:
        # devide the dataset into x and y
        X_steps = dataset[:,1:-1]
        Y_steps = dataset[:,-1:]

        # create an bayesian object with existing datapoints
        myBopt = GPyOpt.methods.BayesianOptimization(f=None,                    # External evaluation
                                                 X = X_steps,
                                                 Y = Y_steps,
                                                 domain=params,                 # Defined parameter space
                                                 acquisition_type='MPI',         # Expected Improvement
                                                 exact_feval = False,           # Expect noisy solution from training
                                                 normalize_Y = True,
                                                 de_duplication = True
                                                 )

        print("suggesting next locations")

        # create a new set of parameters while ignoring current runs
        x_next = myBopt.suggest_next_locations(pending_X = pending)

Hey @theudas , did the advice from Javier help at all?

Hi @apaleyes @theudas, @javiergonzalezh
I confirm that 'model_type=sparseGP' solves the problem with ~3000 initial experimental samples.
However, I'm still concerned by the memory burden and the speed to suggest the next location. I'm afraid that when the initial number of experimental samples will grow, we could encounter the same issue. Also, I would suggest using another model for evaluation than GP regression if the amount of data samples permits it (e.g. Random Forest, etc.).
Thanks again @javiergonzalezh


Add ALPN bindings to security-framework-sys

This pull request adds ALPN function bindings to the crate.
The bindings are currently in module "secure_transport_priv" because these functions are defined in SecureTransportPriv.h. Because these functions are currently private APIs, I extracted the API definitions and put them in a header file with the same name under "priv-headers" so that the binding tests can continue to work.

I'm not really comfortable adding private APIs here.

You are welcome to bind to these yourself in your own crates, but I'm not willing to land them in here.


Unused variables warnings

  Warning number 32
  (No file name)

  unused value query.

  Warning number 32
  (No file name)

  unused value make.

  Warning number 32
  (No file name)

  unused value makeWithVariables.

  Warning number 32
  (No file name)

  unused value query.

  Warning number 32
  (No file name)

  unused value make.

  Warning number 32
  (No file name)

  unused value makeWithVariables.

  Warning number 32
  (No file name)

  unused value query.

  Warning number 32
  (No file name)

  unused value make.

  Warning number 32
  (No file name)

  unused value makeWithVariables.

When I only expose what I need using an interface file, I get a lot of warnings of unused variables. Perhaps this can be solved by not declaring variables on the root, but only within the module.

Closing this, AFAK this has been fixed in 1.0.

I'm interested in this fix. How do you install the 1.0 beta releases? They don't seem to appear on npm.

They are published on the @next tag (https://www.npmjs.com/package/@baransu/graphql_ppx_re).

Regarding these errors: Keep in mind that the hover values for rendered gql (like on fragments) also need to be exposed for RLS to be able to read them. I've been thinking about pushing all of them inside some HELPERS_DO_NOT_TOUCH module (bad name, but you get the gist).


Unable to right click "choose option" on game screen

Type
Other
Operating System
Windows
OS Version
Windows 10 Build 19045.3324
Bug description
Unable to right click in game area to bring up the choose option menu unless there is a player under the cursor. Both items and NPCs seemingly won't register/display the right click unless there's a player under the cursor as well and then the choose option will come up.
Right click works on all other parts of the game interface (inventory, quick prayers, etc)
Temporary work around is using single button mode.
Screenshots or videos
Attempting to right click exchange booth with cursor just off of the players

Right click with cursor slightly to the left so there's a player under it

Right clicking in inventory

RuneLite version
Runelite: <IP_ADDRESS>
Launcher: 2.4.2
Oldschool: Rev 216
Logs
client.log
launcher.log

Give this a try:
In the Camera plugin enable Right click objects, or disable Right click moves camera

That did the trick! Thanks for the quick response.


boards: Add "ram" and "flash" properties for a number of boards

Currently, it seems that only boards with smaller amount of RAM
get a value for "ram" property, and very few boards have "flash"
defined. However, to test bigger sample applications, it's helpful
to have these properties universally defined.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

This popped up while working on a test for https://github.com/zephyrproject-rtos/zephyr/pull/5985 - despite specifying min_ram and min_flash (for a biggish mbedTLS application), I was getting linker errors. Turned out, many board yaml files miss the needed properties.

Codecov Report

Merging #6617 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6617   +/-   ##
=======================================
  Coverage   53.51%   53.51%
=======================================
  Files         437      437
  Lines       41420    41420
  Branches     7935     7935
=======================================
  Hits        22165    22165
  Misses      16038    16038
  Partials     3217     3217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a5d26...3e4e702. Read the comment docs.

How about making sanitycheck dt aware so these come from there instead.

How about making sanitycheck dt aware so these come from there instead.

yes, i will start looking at this for 1.12, i think there is an issue for this.

yes, i will start looking at this for 1.12, i think there is an issue for this.

@nashif, thanks!

Otherwise, the CI of this gets affected by https://github.com/zephyrproject-rtos/zephyr/issues/6616, so I'm going to include fix for it here too.

Why don't we just update arduino_101 and the test for now.

Because not just arduino_101 is affected, but many (all?) boards for which these basic properties aren't specified.

Seems silly to add all these, just to remove them later.

Well, that's called "development" and "refactoring" ;-). As pointed by @MaureenHelm, these things represent existing feature and can be added now (ahem, could have been added before). Where's taking it from DTS is just a modal idea.

Than how about we update sanitycheck to require these properties as part of this PR

I think it's worth mentioning that we already have Kconfigs which express this information because the linker scripts require this data to set up the binary correctly.
There might be some variation in how this is expressed in Kconfig across arches, but I'd really like to see this sort of info pulled from one source, rather than maintaining it in a few different places. If DTS ends up being the canonical source that's fine w/me.

I think it's worth mentioning that we already have Kconfigs which express this information because the linker scripts require this data to set up the binary correctly.
There might be some variation in how this is expressed in Kconfig across arches, but I'd really like to see this sort of info pulled from one source, rather than maintaining it in a few different places. If DTS ends up being the canonical source that's fine w/me.

DTS will end up being the source, that should be the case for the linker scripts that use this info.  We need to cleanup the issue across arch'es around what SRAM, FLASH, MEMORY, ICCM, DCCM, etc mean and are getting used for.

There might be some variation in how this is expressed in Kconfig across arches, but I'd really like to see this sort of info pulled from one source, rather than maintaining it in a few different places. If DTS ends up being the canonical source that's fine w/me.

Right, we want to pull all of this from DTS now that most boards/archs are supporting DTS. That was  a stop-gap.


Adding debug flag so we can peer into the docker container.

Thinking about how this is going to be used.
You can re-run a failed jenkins job. When you do, it allows you to modify the Jenkinsfile before re-running the build. You can add this env variable to the envs we pass to the build:
        openshiftBuild buildConfig: 'openshift-tools-test', env: [[ name: 'PULL_REQUEST', value: pull_request_string ], [ name: 'BUILD_URL', value: env.BUILD_URL ], [name: 'OO_PAUSE_ON_BUILD', value: "true"]], showBuildLogs: true

[test]


Feat: support dual interfaces for all external facing contracts

Description
External facing smart contracts should implement dual facing interfaces to allow better composability. It means that this contracts should support snake_case and CamelCase at the same time for external functions.
Example on open-zeppelin: https://github.com/OpenZeppelin/cairo-contracts/issues/596

I assume this one will be for later right

why is this needed for a brand new protocol on Cairo 2 though?

It's to facilitate integration of products that already exists for GMX on EVM such as https://twitter.com/Puppetcopy.
But I don't think it's high priority yet. Let's build a working app first :rocket:

Imo it would be better to handle this on the sdk side. Applications like Puppetcopy would already need a starknet sdk. It can easily abstract this by converting camel case to snake case before constructing the txn


Relashionship's not working on custom tables

Laravel Version: 5.5
Voyager Version: 1.0.6
PHP Version:7.7
Database Driver & Version:MYQSL

Description:
Hi, im working on a personal project and trying to use relationships in custom tables, i follow the steps that the tutorial said and everything works fine, until the moment i save the data, cause the data is never saved and always shows "No Results"

Steps To Reproduce:

There are a couple of PRs for this already. See #2121 and #2141.

Related PRs are merged.  Closing


Prove queried value source providers can be captured by tasks

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Fix: Promote project's standards to C++17

As titled. :tada:
Many greater benefits compared to C++11, especially to do with constexpr, lambdas, and standard algorithms.
This gives developers tools to refactor the codebase and to express intent of code, in a much more simple way, (with a focus) to other developers reading the project's code.

Closed as this PR was supposed to be merged with upstream / mainline, not local origin. :face_with_spiral_eyes:


mentionSelf question

[question]
I use wechaty API of .mentionSelf() && .self() to judge wheather the message is mention me,most of time is
worked correct,but sometimes  is return false when  the message is really mention for me,the way of mention is through input "@" word and automatic popup list  of wechat group,then  select some contact.
the following code:

This issue might exists. It's highly depends on what puppet protocol you use, and what Wechat client the user who mentioned you are using.

I use wechaty-puppet-padplus,the Wechat client is on Mac or iOS,your means the client should on iPad?

I can confirm the following setting can reproduce this issue:

Bot Puppet: padplus
User client: Macos WeChat
Steps: user mention bot in a room, mentionSelf not works.

Please confirm your environment with the details information like mine to reproduce this issue to help us make this problem clearer.
Thank you very much!

ok!As mentioned above：
1.Bot Puppet: padplus
2.User client: Macos WeChat
3.Steps: user mention bot and a question in a room, mentionSelf not works.the message such as "@bot question",This is not inevitable in the same environment,I met this problem three times today.

@huan @sunshinearea
I‘m working on this issue, could you please provide some detail info for this issue? I can not reproduce this problem.

Bot Puppet<EMAIL_ADDRESS>User client: Macos<EMAIL_ADDRESS>(13292)
Steps: user mention bot in a room, mentionSelf() works.

My Log:
10:24:39 SILL ==P==A==D==P==L==U==S==<GRPC DATA>==P==A==D==P==L==U==S==
10:24:39 SILL GRPC_GATEWAY responseType: MESSAGE_RECEIVE, data : {"Status":3,"CreateTime":1589250277026,"FileName":"<msgsource>\n\t<atuserlist>wxid_orp7dihe2pm112</atuserlist>\n\t<silence>0</silence>\n\t<membercount>3</membercount>\n</msgsource>\n","NewMsgId":8539760895582207996,"FromMemberUserName":"Soul001001","msgSourceCd":2,"ToUserName":"wxid_orp7dihe2pm112","MsgType":1,"L1MsgType":5,"ImgStatus":1,"wechatUserName":"wxid_orp7dihe2pm112","MsgId":"8539760895582207996","MsgSource":"<msgsource>\n\t<atuserlist>wxid_orp7dihe2pm112</atuserlist>\n\t<silence>0</silence>\n\t<membercount>3</membercount>\n</msgsource>\n","PushContent":"苏畅12在群聊中@了你","fromMemberNickName":"苏畅12","ImgBuf":"","FromMemberNickName":"苏畅12","fromMemberUserName":"Soul001001","Content":"Soul001001:\n@jessicaTu hai","FromUserName":"21529888566@chatroom","Uin":"289099750"}
10:24:39 SILL ==P==A==D==P==L==U==S==<GRPC DATA>==P==A==D==P==L==U==S==

10:24:39 SILL PuppetPadplus roomRawPayload(21529888566@chatroom)
10:24:39 SILL PuppetPadplus onPadplusMessageFriendshipEvent({id=8539760895582207996})
10:24:39 VERB Message static load(8539760895582207996)
10:24:39 SILL Accessory #4<Message> constructor()
10:24:39 VERB Message constructor(8539760895582207996) for class Message
10:24:39 VERB Message ready()
10:24:39 SILL PuppetPadplus messageRawPayload(8539760895582207996)
10:24:39 SILL PuppetPadplus messageRawPayloadParser()
10:24:39 SILL messageRawPayloadParser messageType 7
10:24:39 SILL Accessory #5<Room> constructor()
10:24:39 SILL Room constructor(21529888566@chatroom)
10:24:39 VERB Room ready()
10:24:39 SILL PuppetPadplus roomRawPayload(21529888566@chatroom)
10:24:39 SILL PuppetPadplus roomRawPayloadParser()
10:24:39 SILL PuppetPadplus roomMemberList(21529888566@chatroom)
10:24:39 SILL Accessory #6<Contact> constructor()
10:24:39 SILL Contact constructor(wxid_orp7dihe2pm112)
10:24:39 SILL Accessory #7<Contact> constructor()
10:24:39 SILL Contact constructor(wxid_atjcz7dvaxn422)
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="Soul001001"
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="wxid_orp7dihe2pm112"
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="wxid_atjcz7dvaxn422"
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="Soul001001"
10:24:39 SILL PuppetPadplus contactRawPayloadParser()
10:24:39 SILL PuppetPadplus contactRawPayloadParser()
10:24:39 SILL PuppetPadplus contactRawPayloadParser()
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="wxid_orp7dihe2pm112"
10:24:39 SILL Contact ready() isReady() true

    ============================================
    on message : {"domain":null,"_events":{},"_eventsCount":0,"id":"8539760895582207996","payload":{"id":"8539760895582207996","timestamp":1589250277.026,"type":7,"fromId":"Soul001001","mentionIdList":["wxid_orp7dihe2pm112"],"roomId":"21529888566@chatroom","text":"@jessicaTu hai","toId":"wxid_orp7dihe2pm112"}}
    ============================================

10:24:39 VERB Message mentionList()
10:24:39 SILL Contact ready() @ Puppet#0<PuppetPadplus>(tu) with id="wxid_orp7dihe2pm112"
10:24:39 SILL Contact ready() isReady() true

      The bot has been memtioned in the room: Room<Create Room 693>

@su-chang thanks for looking into this.
My situation is that on my Macos client it does not work, however I know some friends that their Macos client works without any problem.
I'll post my Macos WeChat client version later

@su-chang hello:
This is my situation :
1.Bot Puppet<EMAIL_ADDRESS>2.User client: Macos WeChat@Version. 2.3.31 (13331)

@sunshinearea Could you please upgrade your WeChat to v2.4.1 (14470, This is the new version for Mac OS) in Mac OS, and have a test again. Waiting for your response.
Thank you very much.

My MacOS WeChat Version 2.3.29 (13326)

@su-chang I can upgrade my WeChat's version,but i can't ensure other client version that sends me the message to my wechaty bot in the group,how can this situation be resolved?

Understand, you are right, I will collect some WeChat version info and try to fix it.
Thanks for your response.

@su-chang @huan @su-chang
i got the similar situation, and after 2 hours debug,  i think the reason is

selfId is stored as the original WXID like  wxid_t909c6jrfsxx
the contact => contact.id may come like wxid_t909c6jrfsxx -- success
or, use the updated one like "mywxid" as example  --- failed

my solution is
  public async mentionSelf (): Promise<boolean> {
    const mentionList = await this.mentionList() // mywxid or wxid_t909c6jrfsxx
    const selfId = this.puppet.selfId()  // mywxid
    if (mentionList.some(contact => contact.id === selfId) ) {
     return true;
     }
     const selfIdorg = this.puppet.selfIdorg()  // wxid_t909c6jrfsxx
     if (mentionList.some(contact => contact.id === selfId) ) {
     return true;
     }
     return false;
  }


doc: Include docs for initConfig

Updated documentation of some exposed function which will fix the CI.

@cptrodolfox @DavidMazarro Can you take a look at this?


Getting User Data

Any chance we could have getUser() back? Was a really handy function to have allowing us easy access to the user data.

A user service with a getUser method could be made, but a getUser on the client doesn't really fit anymore. It was there for convenience since the login endpoint returned user data, but OAuth has its own set of requests and responses which don't contain such details.
Therefore it doesn't make sense to have that data globally available like it was before; it's no longer a global resource.


show crds command output separated by document separator

What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

issue: https://github.com/helm/helm/issues/12623
issue: https://github.com/helm/helm/issues/11261

Could someone review this?

@mattfarina could you review this fix?


manifest.json find_deps fails to load the file when symlinks are involved

Describe the bug
Since client-side find_deps does a string based get on the manifest file, symlinks may not be properly handled if the working directory is different. Since this utility is within Svelte's codebase, this should be fixed here.
Reproduction
If I had the project in: C:\projects\awd-portfolio where C:\projects links to C:\some\other\path\projects, then the client-side manifest.json would have ../../some/other/path/projects/awd-portfolio instead of ../../projects/awd-portfolio
This will cause find_deps to not find the correct file if my current directory uses the symlink path, since manifest uses a different path
/**
 * @param {string} file
 * @param {import('vite').Manifest} manifest
 * @param {Set<string>} css
 * @param {Set<string>} js
 */
export function find_deps(file, manifest, js, css) {
	const chunk = manifest[file];

	if (js.has(chunk.file)) return;
	js.add(chunk.file);

	if (chunk.css) {
		chunk.css.forEach((file) => css.add(file));
	}

	if (chunk.imports) {
		chunk.imports.forEach((file) => find_deps(file, manifest, js, css));
	}
}

Logs
No response
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 Intel(R) Core(TM) i7-3930K CPU @ 3.20GHz
    Memory: 29.96 GB / 47.94 GB
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.3.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 99.0.4844.74
    Edge: Spartan (44.19041.1266.0), Chromium (99.0.1150.46)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.33
    @sveltejs/kit: next => 1.0.0-next.301
    svelte: ^3.44.0 => 3.46.4

Severity
annoyance
Additional Information
Easy fix if using absolute path comparisons (with fully resolved symlinks) instead of a string comparison. Also, adding an error-handler for chunk being null/undefined would be good. I can try to submit a patch for this if you'd like

A patch (with tests! :) would be great, thank you

closing this as not planned since the method has since been refactored, causing this issue to be stale
https://github.com/sveltejs/kit/blob/d94a854f9f5e8ed474c97cf7d51f2e0db3fe16ac/packages/kit/src/exports/vite/dev/index.js#L578-L614


Alternative Structure

As discussed in our last WG meeting, I was really excited to get the last set of changes merged so that I could have a go describing an alternative layout that might be easier to reason about and discuss.  This is the result of some long nights of work bringing that together.
There are two different dimensions to this PR.  First, the final result is modularized into a small number of core specifications (application projection, provisioned service, service binding) and a number of additional and orthogonal extension specifications (binding secret generation strategies, value mapping, environment variable exposure, and synthetic provisioned services).  The second is that the work was completed in separate commits for each section so the changes for each one are mostly isolated and can be discussed separately from each other.  Each commit also has a reasonable message that discussion the thinking behind each change as well as some important highlights to watch for when reviewing.
Given these two dimensions I'd recommend first taking a look at the specification holistically as the result of all of the commits and reviewing it from that angle.  Once you've done that, or if that turns out to be overwhelming (I totally get that given the volume of words that were changed) take a look at the particular commit for each section to see how it was changed from the previous incarnation of the content.
Rendered

@sbose78 I wanted to check in and see if the conversation about has addressed your inquiries.  Is there anything else we can add?

@nebhale thank you very much! I think I've managed to get through almost all of it. This looks good, I will take another pass!

@arthurdm I think we've still got enough active discussion to keep this open until tomorrow's meeting where I'm hoping wI'll have either addressed everything via the PR or we can finish with verbal discussion.
@sbose78, @BarDweller, and @Avni-Sharma you've still got open conversations that I've responded to (some in the last couple of minutes, so no rush!) and my request is that you go through and resolve the conversions in the GitHub UI if you're satisfied with my responses.  The PR discussion is getting long at this point so I'm trying to use the resolution functionality to keep track of the live threads and identify when we're ready to merge.

If anybody wants to play with this model in a cluster, I've been tracking the changes here in the riff bindings repo. Currently the core spec is implemented except for .spec.type and .spec.provider on ServiceBinding.
https://github.com/projectriff/bindings/pull/18


Problem with implementation (very basic)

First of all I'm not a programmer. I can't make the app work. I want to implement it in my comments.
class CommentForm(forms.ModelForm):
    captcha = ReCaptchaField(widget=ReCaptchaV3())
    class Meta:
        model = Comment
        fields = ('name', 'body','captcha')
        widgets = {
            'name': forms.TextInput(attrs={'class': 'form-control mb-2', 'placeholder':'Nombre de usuario'}),
            'body': forms.CharField(widget=CKEditorUploadingWidget(attrs={'class': 'form-control'})),
        }

It works perfectly now

@GSnchez - looks like you found out the issue. I am stuck, however. Like you I am using forms.ModelForm. What minimum score did you use here for V3?


feat: support pre-warming PartitionClient

This exposes a method that can be used to drive leader discovery before the first call to produce() on a PartitionClient. This allows us to "pre-warm" the cached broker connection to the leader and avoid doing it when we send through the first write.
Ideally we would do this automatically when initialising the PartitionClient, but that would be a breaking change  as the constructor would need to become async - happy to change it if a breaking change is acceptable :+1:
I wasn't really sure how to test this :shrug:

feat: support pre-warming PartitionClient (b612f08)
Adds a refresh_leader() method to force the PartitionClient through the
discovery process.

This will ensure a cached connection to the leader is (likely) already
established by the time the first produce() call is issued, preventing the
first produce() calls (multiple of which may be queued up on the discovery
mutex) from experiencing excessively high latency.

refactor: pre-warm PartitionClient connection (387a96d)
Change the Client::partition_client() constructor to always perform leader
detection and establish a connection to the broker immediately, instead of
differing the work until the first produce() call.

This eliminates the unusually high latency of the first produce() call.

BREAKING CHANGE: PartitionClient constructor is now async

I have made the breaking change proposed in the description - now all users will have a fully-primed PartitionClient without any extra hops 👍


Get only visible items on table

I'm trying to implement striped rows (zebra) on my table, I can do it using indexOf on my items' array, but the problem is when a row has expanded, because it fetches the children and changes the array length when it's collapsed, so the rows looks weird. Is there any way to get only visible items on screen? I'm trying using querySelectorAll passing the className "nestable-item" but it doesn't refresh properly

Hi. Could you make 2 screenshots: what you have and what you need?

In your case task 1 would have dynamic color. That's unexpected UI. But if that's what you want, you can try to do something like:
import React from 'react';
import Nestable from 'react-nestable';
import 'react-nestable/dist/styles/index.css';

const styles = {
  position: "relative",
  padding: "10px 15px",
  fontSize: "20px",
  border: "1px solid #f9fafa",
  background: "#f9fafa",
  cursor: "pointer"
};

const stylesEven = {
  ...styles,
  background: "orangered",
};
const stylesOdd = {
  ...styles,
  background: "steelblue",
};

const items = [
  {id: 0, text: 'Andy'},
  {id: 1, text: 'Harry', children: [{id: 2, text: 'David'}]},
  {id: 3, text: 'Lisa', children: [{id: 4, text: 'Richard'}]}
];

let i;

class Example extends React.Component {
  renderItem = ({ item, collapseIcon, handler }) => {
    if (item.id === items[0].id && i !== 2) {
      i = 1;
    }
    i++;
    return (

        {handler}
        {collapseIcon}
        {item.text}
        {i}

    );
  };

  render() {
    return (

        <Nestable
          items={items}
          renderItem={this.renderItem}
        />

    );
  }
}

Archived